HALT instruction (0x76) increments PC

Almost all the HALT tests seem to expect PC incremented by one, while PC should remain unchanged, for the definition of HALT.

 HALT is pretty problematic to test since it has no end. But you're right, PC shouldn't have incremented.
I have not fixed this behavior in my core, but have in the tests, I think. Please let me know if it is fixed for real.

I confirm that now it's fixed. Thanks.

Sorry, but he halt does increment PC during the opcode fetch, as all others do. The CPU neither decrements nor avoids incrementing PC "so that the instruction is re-executed" as Sean Young writes in section 5.4 of "The Undocumented Z80 Documented". During the HALT state, the CPU repeatedly executes an internal NOP operation. Each NOP consists of 1 M1 cycle of 4 T-states that fetches and disregards the next opcode after halt without incrementing PC. This opcode is read again and again until an exit condition occurs (i.e., INT, NMI or RESET).
This was first documented by Tony Brewer in 2014, and was later re-confirmed by the HALT2INT test written by Mark Woodmass (AKA Woody) in 2021.

@redcode recently merged in a fix that should have gotten this too, I'm pretty sure


Restored tests/libc HeapPageCount/StackPagecount

Reverting Heap/stack sizes in tests/libc/enc/enc.c as this is not yet enabled with ELF enclaves.

bors try


Add file upload

Add file upload to parts and assemblies, specifically

drawing (PDF)
documentation (PDF)
Toolpath (gcode)

Uploaded files shall be stored in a directory structure
Organization should be similar to the following:
[PART ID]
|----drawing
\----[PART_ID]_[VERSION].PDF
|----docs
\----[PART_ID]_docs.PDF
|----toolpath
\----[PART_ID].gcode

"Version control" shall be implemented for drawing uploads.

A current revision latter shall be stored as a part instance variable. The letter is incremented every time a new drawing (and only drawing) is uploaded. If we use 26 versions:
-- Smack the CAD team
-- Roll over to AA, AB, etc

The rev letter shall be displayed in the part info page

The rev letter may be reset to a previous version by an admin, which changes the drawing that the part page points to or renders

Uploads shall be capped at 5MB.

Access to viewing uploaded files shall be restricted to users who are signed in

When a part is deleted, recursively delete the associated directory.

State of the union for part_uploads branch:

File upload and associated directory management is workings

PDFs and Links will show if they exist and dependent on has drawing checkbox, they need styling

Version control currently increments and saves old files, but no way to "revert" yet

Uploads are size restricted and type restricted with client side validation

Added revert to previous revision letter

@morops I've restricted revision control to administrators - perhaps we need a new permission for this

I think we need some new classes of users as well. Currently we have admin, edit, and read only. I would like to add design as a special class of user editing with a little more access than general edit, which would be presumably for shop students.

That's more of less what I meant by new permission, but I'm agreed with you


Adding release notes for 2.0.0-rc1 (#193)

Signed-off-by: Sagar Upadhyaya<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Adding release notes to 2.0 branch from main.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #194 (b3b9323) into 2.0 (81d019a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.0     #194      +/-   ##
============================================
- Coverage     72.01%   71.93%   -0.08%
+ Complexity      369      368       -1
============================================
  Files            44       44
  Lines          2519     2519
  Branches        169      169
============================================
- Hits           1814     1812       -2
- Misses          593      595       +2
  Partials        112      112

Impacted Files
Coverage Δ

...analyzer/collectors/MasterServiceEventMetrics.java
72.29% <0.00%> (-1.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d019a...b3b9323. Read the comment docs.


Dialogs with discard button do not adhere to Material guidelines

The "Discard comment?" dialog has the discard button on the left.
According to the Material guidelines, this shouldn't be the case. It is mentioned specifically as a Don't.
It should be checked whether other dialogs have the same issue.
https://m3.material.io/components/dialogs/guidelines

Small note: sometimes when I just typed something in, IME still being visible, a back press makes this dialog show up.
But more often, and imo expectedly so, first IME is closed. Only on a second back press, the dialog shows up.


Clear All Outputs tests

For #7853

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #8595 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8595      +/-   ##
==========================================
+ Coverage   59.05%   59.11%   +0.05%
==========================================
  Files         512      512
  Lines       23762    23762
  Branches     3838     3838
==========================================
+ Hits        14033    14046      +13
+ Misses       8799     8792       -7
+ Partials      930      924       -6

Impacted Files
Coverage Δ

src/client/datascience/constants.ts
100% <0%> (+0.33%)
:arrow_up:

src/client/common/process/proc.ts
14.84% <0%> (+1.56%)
:arrow_up:

src/client/interpreter/locators/helpers.ts
73.17% <0%> (+2.43%)
:arrow_up:

src/client/linters/pylint.ts
98.18% <0%> (+3.63%)
:arrow_up:

src/client/datascience/debugLocationTracker.ts
83.01% <0%> (+3.77%)
:arrow_up:

src/client/linters/pydocstyle.ts
89.74% <0%> (+5.12%)
:arrow_up:

src/client/common/platform/pathUtils.ts
72.22% <0%> (+5.55%)
:arrow_up:

src/client/common/utils/platform.ts
76.47% <0%> (+11.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4cb1d...0a40cc2. Read the comment docs.


Auto generated CSS works ony on customizer preview

Issue description:
While using type color with transport auto, the auto generated CSS works only on customizer preview. The latest color control which is changed is generated only on frontend. Note that the controls is being shown by active callback value of another control. I have been stuck on this for a week now.
Version used:
3.0.39
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
If you provide me with gitlab username, I can give you the access to the theme.

Are you by any chance adding your controls on customize_register or something like that?

username on gitlab is the same as here: aristath

No. I have loading it directly into the functions.php.
I have added you on my theme. Please have look.

@sachyya I just cloned your repo and tried it, I don't see an issue... I tried with the header_bg_color. Should I try with some other control?

The issue is in the Advanced Options->Colors->Heading typography:

Still works fine for me...
What is the ID of the setting you have an issue with?

The control is being generated in a loop:
foreach ( $heading_typo_defaults as $i => $value ) {
			$i++;
			$font_size = $value[0];
			$line_height = $value[1];
			$headings_typo[] = array(
				'type'        => 'typography',
				'settings'    => 'global_h' . $i . '_typo',
				'transport' => 'auto',
				'section'     => 'colors',
				'default'     => array(
			        'color'			 => '#000',
			        'font-size'			=> $font_size,
			        'line-height'	=> $line_height,
			        'letter-spacing'	=> '0px',
			        'text-transform'	=> 'none',
			        'font-family'    => '"Playfair Display", serif',
			        'variant'        => 'regular',
			    ),
				'output' => array(
				    array(
				        'element'  => array( '.entry-content h' . $i, '.sidebar h' . $i, 'footer h' . $i ),
				    ),
				),
				'active_callback'  => array(
			        array(
			            'setting'  => 'global_headings_list',
			            'operator' => '==',
			            'value'    => 'h' . $i,
			        ),
			    ),
			);
		}

h1_color and h2_color

Ummmm I don't know if I'm missing something, but I can't find $heading_typo_defaults anywhere in your code. Is it on some other branch? Is it on some code you haven't committed to your repository? Some code someplace else?

The issue is another branch: feature/regenerate-bug

First of all, instead of this:
foreach ( $heading_typo_defaults as $i => $value ) {
	$i++;
	$font_size = $value[0];
	$line_height = $value[1];

you may want to do this:
for ( $i = 1; $i <= 6; $i++ ) {
	$font_size = $heading_typo_defaults[ $i - 1 ][0];
	$line_height = $heading_typo_defaults[ $i - 1 ][1];

Incrementing $i on each loop and re-defining it in the loop as a key can get a little confusing. The above solution is easier to understand and leaves no room for error.
In your customizer you have a radio-buttonset that you use as a tab-switcher. Then in the customizer controls you have an active_callback to show/hide fields. However, active_callback also affects the output of the css... If a field is inactive, its CSS is not printed.
To remove that behaviour and add CSS for fields even if they are hidden, you can add this filter:
add_filter( 'kirki_code_manas_config_css_skip_hidden', '__return_false' );

@aristath , this works. Thanks a lot.


Why is my docker run creating my domain as an organization not a domain

Trying to figure out why my dc=test,dc=test1 when i click on it says its a organization not a domain. Driving me nuts the openldap docker seems easy but it  seem to get around it.

I sure can, I have an existing openldap server, i have gotten my ldifs that i need to import. When i use the osixia openldap it creates an organizational unit rather than a domain. I have attached a sreenshot of my original domain definition and the definition that gets created with the osixia, I need it to be defined as top domain so that my backup ldif can import definitions into it. Capture 1 is what i get with osixia openldap, Capture 2 was a manual build. What do i have to do to get it defined as like Capture 2.     On Monday, October 24, 2022, 12:58:42 PM CDT, João E. Pereira Jr @.***> wrote:
Hello @migace001,
Could you provide more details about the issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@migace001,
Sorry, I could'nt find the screenshots. Check if the  LDAP_ORGANISATION and LDAP_DOMAIN enrironment variables are properly set when starting the container via docker-composer. Inspect the containers and compare the outputs.

Here is what i a reffering to

@migace001,
I see. As far as I know using organization as the sctructural attribute in this scenario is the right behaviour. openldap also defines domain objectClasses to be used in other scenarios like DNS or email. In your case the domain is test.test1, but presented in 2 domain components dc=test,dc=test1. I think you shold proceed this way and things will work as expected.


Problem with dropped HTML nodes - update() doesn't work as expected

My experience with ractive so far has been that it performs really well with fairly flat object trees, but with more complex trees, it often tends to miss when object trees are dirty or values have changed. That is, given object A and template B, it will correctly render most of the time with updates. But then, once in a while (0.1% of the time?), given the same object structure, it will either fail to update or render certain nodes, seemingly at random. Some objects & template pairs don't seem to do this, but throughout my app, there are certain ones with these occasional failure rates, and I've formed the habit of forcing ractive to completely replace the ractive data (by creating a new object with the same structure as the old, and binding to the root data) for certain sections of the app. The update() method has no effect, no matter what keypath I give it that I know to be dirty.
Let me give you an example. I have this template:
{{#top}}
	{{#each .sources}}
		{{# { files: ., category: @key } }}

			{{#.files:i}}
				{{#if i == 0}}

{{ category }}

				{{/if}}
				{{>file}}
			{{/}}

		{{/}}
	{{/each}}
{{/top}}

And this data:

99.9% of the time, it renders this:

Today, it rendered this:

Restarting the app, with the same data and the same template produces the correct layout with correct HTML nodes. But besides being confused and concerned about why this happens and how often it might happen, update() has no effect, even though the documentation states that it will do a dirty check. Well... I should say, that is, it has no effect on rendering the correct HTML nodes. If I use ractive.get() it shows the above object tree. Both "CSS" and "LESS" are there, present, in the ractive object tree, but, in this 0.1% case, it drops an HTML node (and obviously all of its child nodes).
I can tell you with certainty as I've developed with Ractive over the last year, that while objects and templates don't change their structure, the resulting HTML is not 100% predictable. Like I said, the failure rate is fairly low (and there are never errors in the console), but in some cases, given Object A and Template B, you will get Layout X 99.9% of the time, and Layout Y 0.1% of the time. I don't know if it's an issue in the HTML diffing algorithm, but  part of my question (other than the obvious "why is this happening") - is there a way to tell Ractive to always ALWAYS make sure that the data it has corresponds to the HTML it's rendering? As in, even if it THINKS the data hasn't changed, for whatever reason, that it really super serious has created the nodes that it thinks it has? And if that can't be done via update(), what would be the correct method?
One thing I should say about this: once a Ractive has failed, it will always fail. That is, if you keep rebinding an object, even if you use set() and update() at various keypaths, it will forever omit the HTML nodes it is missing (unless, I think, the object structure has changed significantly? I haven't figured out a pattern here).
I almost think that it's Ractive being overly conservative here - trying to only render the HTML it needs to based on data changes. But I wonder if Ractive shouldn't check its work afterwards, if it's not going to update all the HTML. But I don't know the lib well enough to suggest how to do this. (Would this be reset()? Or the undocumented resetTemplate()?)
As this pertains to core functionality / purpose of Ractive, I'm wondering if you can help me out. Is there something I may have missed? What might cause these occasional failures? And how can they be avoided?

have you tried this with edge?

@heavyk No, this is with the latest official release. Why, is there reason to believe this wouldn't happen with 0.8? The problem for me is that I'm close to releasing the software where this is used, so I would be hesitant to change versions right before a final release. And it happens so infrequently that it's hard to tell if it's solved or not. Which I know makes this a ¯\(ツ)/¯ kind of bug, I know. But I swear to you that this is happening as described.

Maybe the question could be phrased this way, if the source of the problem is not known -- Is there a way to tell Ractive to always entirely create the virtual DOM when values change in the data, and check that against rendered nodes to see if anything is missing? Without ruining Ractive performance?

This happened again today. This time, neither CSS nor LESS nodes were rendered. Same object structure. Using ractive.get() demonstrated that the data was present, just not rendered.
I tried the equivalent of ractive.set('top', ractive.get('top')) and ractive.set('top', JSON.parse(JSON.stringify(ractive.get('top')))).
I inspected the ractive.template object structure to see if maybe the parsing was mucked (which wouldn't really make sense since it would be unchanged during the same session. Still nothing. Template is there and parsed, and data is there, it just doesn't render some of the time. Somehow ractive spontaneously stops knowing how to render the data.

@matthew-dean Sorry you're having issues.
Having just built a fairly large app using 0.7 this year, I haven't noticed sporadic failures as you mention. But the two areas I had problems with were transitions in nested and dynamic components, and I noticed something similar to what you mentioned with nested if blocks within components that involved mapped (from higher level parent) data.
I could even put in a {{console.log(someData)}} and see that expression being re-evaluated, but an adjacent if block would just not update.
I worked around this by unnesting the blocks. So instead of:
{{#if foo}}
    foo
    {{#if bar}}bar{{/bar}}{{/if}}
    qux
{{/if}}

I changed it to:
{{#if foo}}foo{{/if}}
{{#if foo && bar}}bar{{/bar}}{{/if}}
{{#if foo}}qux{{/if}}

I have to say that I have found Ractive to be very deterministic. I suspect because it updates synchronously. So when I saw this condition, I could always recreate it reliably.
Just looking for what would be causing the difference in working vs not working: Are you doing any direct DOM manipulation? Or is there asynchronicity that may be resolving at different times? Are there particular data values for which this is happening?
Given what you have described, I suspect under the covers that either the model layer or the virtual believes the data has already changed and so calling update won't help (as you have noticed). Ideally we would resolve the bugs, but perhaps it would be useful to have a ractive.update( 'foo', { force: true } ) option that would force the dependants to update completely.

@martypdx I've found the issue! And can reproduce it!
Basically, once you set a keypath to undefined, Ractive 0.7.3 will never update that keypath, ever again. At least with an each, but possibly with other bindings. (Which is obviously not right, since it should be the same behavior as Handlebars, where an "each" can be shorthand for "forEach only if not falsy".) And, funnily enough, I had just tried the "if" workaround which worked for me.
0.7.3 bug demonstration: http://codepen.io/matthewdean/pen/epbvjy
0.7.3 bug workaround with if: http://codepen.io/matthewdean/pen/yYGbNK
0.8-edge (fixed) http://codepen.io/matthewdean/pen/ZbVKbR
My last link verifies that this is fixed in latest edge version. However, I couldn't find any previous issue that describes this bug, so maybe this should be marked as a fixed bug? And hopefully there's now a test for this in 0.8?  And also for your test cases, because working "if" and "each" blocks is kind of a fundamental building block of ractive templates.
This has been driving me crazy so I'm at least glad there are ways around it.

Good find!

Oops, I just had this problem occur on a template with the "workaround" applied. It looks like 0.7.3 is irreparably broken in this regard. When will 0.8 be released?


Update README.md

Change Slack link to Discord link

Thanks @tpayet
Don't worry, it's on my todo to change this in all the repos with the integration script 💪
Will probably take the time next week

bors merge


swagger.json not found with Azure Service Fabric applications

I am really struggling to work Swagger with an Azure Service Fabric Cluster. We are working on Azure service fabric and we have a couple of SF applications. Each application type is having again a couple of services with it. Now we have integrated the Swashbuckle Swagger as :
           services.AddSwaggerGen(c =>             {                 c.SwaggerDoc("SwagService1", new Info { Title = "Something", Version = "v1.0" });             });
`            app.UseSwagger(c => c.PreSerializeFilters
.Add((swagger, httpReq) => swagger.Host = httpReq.Host.Value));
        app.UseSwaggerUI(c => c.SwaggerEndpoint("/AppName/ServiceName/swagger/SwagService1/swagger.json",
            "SwagService1"));

`
Also we have used an aggregated Swagger UI for all of our SF services across from different applications in a single service as follows ;
           var apiList = Configuration.GetSection("FromAppSettingsJson").Get<SettingsModel>();             app.UseSwaggerUI(c =>                 apiList.APIListItems.ForEach(apiItem => c.SwaggerEndpoint(apiItem.EndpointUrl, apiItem.Name)));
and we have stored all the swagger endpoints configurations (the above ones) in this appsettings.json.
This thing is working pretty good in my local service fabric cluster but after deploying to Azure SF, I am not able to access Swagger UI. I am getting the following error..
Failed to load API definition
Fetch error > swagger.json not found.
However when I try to access individual service specific swagger.json then I am able to access swagger.json but again could not able to access SwaggerUI.
Can anyone help me on this ?

@domaindrivendev I am not sure it is a CORS issue, when I try to access the Swagger UI, I get the following header and error

@starklord07 - is the Request URL you've shown above correct? In other words - does it work when you access directly via browser?

I have a similar SF setup and the issue we faced is that the swagger UI is served by accessing the reverse proxy while the service hosting that is not really aware so the url for the swagger.json is relative to the node serving the swagger ui anf not the reverseproxy, so in short it points to a path that does not exist when using the proxy.

Having the same issue with a Service Fabric cluster. My local 1 node cluster does not have this problem. The Development or Qa cluster (5 nodes) has this Not found problem unable to fetch /swagger/v1/swagger.json
However I can see the json by using the absolute url (e.g: https://mydevcluster:19008/MyProject/WebApi/swagger/v1/swagger.json  so there must be something being done at the proxy with the Urls.
Is there anything in Swashbuckle to add prefix in swagger url? I have a similar issue with other things such as Hangfire where I must specify a PrefixPath such as /MyProject/WebApi when running in a multi node service fabric cluster.
If swashbuckle supports something similar I suspect the issue is that my swagger app "thinks" it's running under a different url and I need to instruct it to assume that is running behind a reverse proxy and add some prefix.

I think I figured out what it is because I had a similar issue with AD authentication in a different service also on SF.
I never verified if it is the case with swashbuckle, but I guess its the same thing.....
You need to tell the stack that is sitting behind a proxy: https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/proxy-load-balancer?view=aspnetcore-5.0
I ended up doing a variation on the following
// In the ConfigureServices(IServiceCollection services) method
       // Service Fabric Reverse Proxy Configuration
            services.Configure<ForwardedHeadersOptions>(options =>
            {
                options.ForwardLimit = null;
                options.RequireHeaderSymmetry = false;
                options.KnownNetworks.Clear(); // This is not really that smart - we should probably add a list of known proxies/networks
                options.KnownProxies.Clear();
                options.ForwardedHeaders = ForwardedHeaders.XForwardedHost |
                    ForwardedHeaders.XForwardedFor | ForwardedHeaders.XForwardedProto;
            });

and
// In the Configure(IApplicationBuilder app, IWebHostEnvironment env) method
app.UseForwardedHeaders();
            app.Use((context, next) =>
            {
                var fabricServiceName = Environment.GetEnvironmentVariable("Fabric_ServiceName"); // ex fabric:/AppName/ServiceName
                if (string.IsNullOrWhiteSpace(fabricServiceName))
                {
                    return next();
                }

                var fabricServiceUri = new Uri(fabricServiceName);
                var servicePathBase = fabricServiceUri.AbsolutePath; // ex /AppName/ServiceName
                context.Request.PathBase = new PathString(servicePathBase);
                return next();
            });

Its not as such pretty - but it works for the authentication issue I had that is very similar.
I think a similar approach should work here...need to adjust it obviously.

The solution was rather easy for a workaround. Not so easy for automation as per @esbenbach proper suggestion that path are tweaked at proxy level.
The following was sufficient.
app.UseSwagger();
app.UseSwaggerUI(c => c.SwaggerEndpoint("/MyProject/WebApi/swagger/v1/swagger.json", "My Scheduler"));

@esbenbach as per your previous answer, I managed to have the Azure AD authentication (id_token) for my service under service fabric by adding ForwardedHeaders and by customizing the request's PathBase as you mentioned. Thanks
However this does only work when there is just one instance of the service in the service fabric cluster. If I deploy it to some environment with 3 instances, for example, I get a 500 error when AD issues the token and the POST return uri to /oidc-signin is called. I'm guessing it's again some error related to the fact that there is a proxy/load balancer and it does not know where to forward that token or which instance initiated the flow. Sorry for the sligthly off-topic but, did you happen to resolve that?

@diegosasw Actually i didnt since the services in question where i have the OIDC signin I have only needed one instance of. I just tried scaling it and, immediately got an Exception: Unable to unprotect the message.State.
Presumably because the state was generated by a different node.
My guess would be that we need to wire up some external data protection stuff like described here (blobstorage):
https://stackoverflow.com/questions/53490663/asp-net-core-2-1-cookie-authentication-appears-to-have-server-affinity/53501066#53501066
Or here (redis):
http://www.tugberkugurlu.com/archive/asp-net-core-authentication-in-a-load-balanced-environment-with-haproxy-and-redis
Or since we are in SF already
https://github.com/SoCreate/service-fabric-data-protection
https://github.com/MedAnd/AspNetCore.DataProtection.ServiceFabric
I have not tested anything, so just guessing here.....
@domaindrivendev pretty sure this entire thread is not related to a swashbuckle issue, so you can probably just close it.


Send the original text instead of the translated one in Translate Writing in Discord

In Discord, when I use the translate writing hotkey, it writes the translated text, but when I press enter, the original text is sent
for example, I write Farsi, then I press the translate writing hotkey, the text is converted to English, But when I press enter, the text entered in the view box is Farsi
https://github.com/ttop32/MouseTooltipTranslator/assets/123282471/bdfe82c8-35e9-481d-990a-e33ca434213c

@ttop32
Thank you very much, you are a real hero
friends, the problem was solved with the update [0.1.113 (https://github.com/ttop32/MouseTooltipTranslator/tree/0.1.113)

/solve

0.1.113


Nice extension!

Hi @jonghwanhyeon, congrats, the extension is super clean! It's fun to see that you have managed to implement our built-in expression modernization in an extension :smile: I will reference it in our docs :slightly_smiling_face:

Oh by the way, you might want to add a griffe-extension topic to the GitHub repository, for discoverability :smile:

I created this extension because I needed its functionality for personal use. If it has caused any discomfort, I will unpublish it.

I apologize if this has caused any discomfort, and I will unpublish the package.


Update appveyor.yml

Description by Korbit AI

[!NOTE]
This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?
Update the AppVeyor configuration to use Visual Studio 2022 instead of Visual Studio 2019.
Why are these changes being made?
This change ensures compatibility with the latest development tools and takes advantage of new features and improvements in Visual Studio 2022. This update is necessary to keep the build environment current and maintain support for modern development practices.

:white_check_mark: Build POC-dotnet-Dijkstra 1.0.213 completed (commit https://github.com/GuilhermeStracini/POC-dotnet-Dijkstra/commit/6de00bbfb9 by @guibranco)


Remove Nvidia Insight Compute in 2023 containers

Nvidia Insight Compute is an interactive debugger for CUDA and OptiX which is taking up almost 1GB in /opt/nvidia in ci-osl:2023 and possibly other containers. It doesn't need to be in there, and we should try to get rid of it to reduce container image bloat.

Insight Compute has been added to nvidia/cuda:11.8.0-devel-rockylinux8 between our 2023.0 and 2023.1 releases, unfortunately it's not simple to remove something from a base image and reclaim the space.

Nsight Compute gets installed in /opt/nvidia/nsight-compute and takes up 1.5GB as of the 2024.1 container images.
It is owned by the following RPMs:
nsight-compute-2023.3.0-2<IP_ADDRESS>-1.x86_64
cuda-nsight-compute-12-3-12.3.0-1.x86_64

where cuda-nsight-compute installs a couple of wrapper scripts:
/usr/local/cuda-12.3/bin/ncu
/usr/local/cuda-12.3/bin/ncu-ui

Although dnf -y erase nsight-compute will remove the RPMs, we would then need to use some third party tool to 'squash" the resulting images, which may not fit well in the build pipeline. So it might be preferable to avoid installing nsight-compute in the first place.
[templates/redhat/devel-dockerfile.j2]](https://gitlab.com/nvidia/container-images/cuda/-/blob/master/templates/redhat/devel-dockerfile.j2?ref_type=heads) in the (Nvidia CUDA Linux Container Image Sources] repo is where Nsight compute gets added to the CUDA base image we build on top of.

Perhaps docker-squash could be used to flatten layers after removing nsight-compute from the base image?

Seems to work, the following Dockerfile:
FROM nvidia/cuda:12.6.1-devel-rockylinux8
RUN dnf -y erase nsight-compute nvidia-nsight-compute

goes from 7.18GB to 5.93GB after applying docker-squash to the top 3 layers.


build(cargo): bump up swc_core

This PR bumps up swc_core to near-latest to pick up some changes incomaptible to build next.js.

Thanks!


MODELIX-560 bulk-model-sync quality of life improvements

This PR adresses 2 pain points:

Including multiple modules required listing them individually. As a shortcut they can now be included by specifying a prefix.
The sync was almost like a black box. This PR adds some progress indicators.

:tada: This PR is included in version 3.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


View: Toggle Panel removes scrollbar from the panel.

Issue Type: Bug
Then I hotkey on "View: Toggle Panel", panel appears without a scrollbar but I can scroll with mouse wheel.
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 5.3.0-40-generic snap

this is specific to terminal based on my testing.

/duplicate https://github.com/microsoft/vscode/issues/91135


fold_block highlighting improvements and new syntax file to support Function::Parameters

@chumakd This looks good, thanks for sending this our way.  Quick question about 5fb3987eb: was foreach not being properly detected?

@chumakd Any thoughts on my question?

Sorry, I somehow missed your post.. And should have written a proper commit msg with a better explanation of the change, in the first place.
The point of that patch ( 5fb3987 ) is that it enables perlBlockFold for a code like
for my $i (@list) {
}

Original version supports it only for the foreach, but not for.

@chumakd Thanks for filling me in, and for submitting the code!


Password not being reset

Reported by user:
"
I changed my password, but after logging out and back in, it didn't recognize the new password.
"

I ran through the workflow and everything appeared to be working as desired.  Closing for now


Implement support for raw public keys (RFC 7250)

Implement support for raw public keys, as described in RFC 7250 and RFC 8446 (section 4.4.2 especially). Also added tests to validate the implementation. Note that only TLS 1.2 is tested since BC's support for 1.3 isn't finished yet, but these changes should not create any additional work for 1.3.

Just rebased this on top of the 1.67 tag. Also did some interop testing with GnuTLS, which revealed a mistake in the encoding of raw key certificates. That is now fixed and BC works against both gnutls-serv and gnutls-cli using raw keys.

@peterdettman @dghgit This PR has been languishing for the last year and a half. I've rebased it on top of 1.71 to fix the conflicts. Also performed interop testing against GnuTLS, which confirmed the code works as both client and server, with TLS 1.2 and 1.3. Could you guys take a look? Thanks.

@peterdettman @dghgit This PR has been languishing for almost 3 more months since my last comment. I don't mean to be a pest about this, but I also don't want to keep maintaining this patch forever and it already has merge conflicts again. Also, judging from the thumbs-up on my last comment, it looks like I'm not the only one who'd like to see this get merged. Is there any chance you guys could review and merge this? Thanks.

@rdicroce I'm working on merging this now (leave the conflicts to me).

@peterdettman Did you finish merging this? If not, is there anything I can do to help move this along?

As I recall, I didn't like the negotiated certificate type being stored in the CertificateRequest and had intended to move it into the SecurityParameters. If you wanted to make that change it would help me out timewise.

I've now merged this. Thanks for your patience. It will be in 1.72 that is releasing shortly.
Note that I cleaned up extraneous whitespace changes and also fixed some problems with the BC TlsCertificate implementations (around sigalg and keyusage).

Thanks Peter! Much appreciated.


Create button shouldn't be displayed on all namespaces list view

Description
Users couldn't be able to click Create on the All Namespaces view.

Expected result
Users couldn't be able to click Create on the All Namespaces view.

Actual result
Users can click Create on the All Namespaces view.

Tip
There is disableCreate property.

Also in details for example in Pizza create is disable, but I can click Create


.travis.yml: The 'sudo' tag is now deprecated in Travis CI

Travis are now recommending removing the sudo tag.
"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"

Thanks for the heads up. We'll update.


Connection timeout on start

Starting rtv I get:
Connecting...
Connection timeout
I installed on OpenSUSE Tumbleweed using pip.
Starting rtv with a log yields:
INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): api.reddit.com
WARNING:py.warnings:/usr/lib/python3.4/site-packages/rtv/__main__.py:122: ResourceWarning: unclosed <socket.socket fd=5, family=AddressFamily.AF_INET, type=2049, proto=6, laddr=('<IP_ADDRESS>', 35078), raddr=('<IP_ADDRESS>', 443)>
  print('Connection timeout')

Hi! Sorry for the late reply, I would like to get to the bottom of this. Could I start by asking which version of rtv you're using? You should be able to do
pip show rtv

I get this:
---
Metadata-Version: 2.0
Name: rtv
Version: 1.5
Summary: A simple terminal viewer for Reddit (Reddit Terminal Viewer)
Home-page: https://github.com/michael-lazar/rtv
Author: Michael Lazar
Author-email<EMAIL_ADDRESS>License: MIT
Location: /usr/lib/python3.4/site-packages
Requires: requests, praw, six, kitchen

Ok cool, it looks like you have the latest version. Correct me if I'm wrong but it looks like you're using your system python installation. My first guess is that your python-requests is acting funky or is sticking to an older, incompatible version. My second guess is that it may be some masked SSL issue.
Try upgrading via pip and paste the log
pip install -U rtv
pip install -U requests

Then I get:
pip install -U rtv
Requirement already up-to-date: rtv in /usr/lib/python3.4/site-packages
Collecting requests (from rtv)
  Downloading requests-2.8.1-py2.py3-none-any.whl (497kB)
    100% |████████████████████████████████| 499kB 617kB/s
Requirement already up-to-date: kitchen in /usr/lib/python3.4/site-packages (from rtv)
Requirement already up-to-date: praw>=3.1.0 in /usr/lib/python3.4/site-packages (from rtv)
Collecting six (from rtv)
  Downloading six-1.10.0-py2.py3-none-any.whl
Collecting decorator>=3.4.2 (from praw>=3.1.0->rtv)
  Downloading decorator-4.0.4-py2.py3-none-any.whl
Requirement already up-to-date: update-checker>=0.11 in /usr/lib/python3.4/site-packages (from praw>=3.1.0->rtv)
Installing collected packages: requests, six, decorator
  Found existing installation: requests 2.7.0
    Uninstalling requests-2.7.0:
Exception:
Traceback (most recent call last):
  File "/usr/lib64/python3.4/shutil.py", line 523, in move
    os.rename(src, real_dst)
OSError: [Errno 18] Invalid cross-device link: '/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst' -> '/tmp/pip-dv2am2i1-uninstall/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/pip/basecommand.py", line 211, in main
    status = self.run(options, args)
  File "/usr/lib/python3.4/site-packages/pip/commands/install.py", line 311, in run
    root=options.root_path,
  File "/usr/lib/python3.4/site-packages/pip/req/req_set.py", line 640, in install
    requirement.uninstall(auto_confirm=True)
  File "/usr/lib/python3.4/site-packages/pip/req/req_install.py", line 716, in uninstall
    paths_to_remove.remove(auto_confirm)
  File "/usr/lib/python3.4/site-packages/pip/req/req_uninstall.py", line 125, in remove
    renames(path, new_path)
  File "/usr/lib/python3.4/site-packages/pip/utils/__init__.py", line 315, in renames
    shutil.move(old, new)
  File "/usr/lib64/python3.4/shutil.py", line 536, in move
    os.unlink(src)
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst'

and
pip install -U requests
Collecting requests
  Using cached requests-2.8.1-py2.py3-none-any.whl
Installing collected packages: requests
  Found existing installation: requests 2.7.0
    Uninstalling requests-2.7.0:
Exception:
Traceback (most recent call last):
  File "/usr/lib64/python3.4/shutil.py", line 523, in move
    os.rename(src, real_dst)
OSError: [Errno 18] Invalid cross-device link: '/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst' -> '/tmp/pip-vn67ynzz-uninstall/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/pip/basecommand.py", line 211, in main
    status = self.run(options, args)
  File "/usr/lib/python3.4/site-packages/pip/commands/install.py", line 311, in run
    root=options.root_path,
  File "/usr/lib/python3.4/site-packages/pip/req/req_set.py", line 640, in install
    requirement.uninstall(auto_confirm=True)
  File "/usr/lib/python3.4/site-packages/pip/req/req_install.py", line 716, in uninstall
    paths_to_remove.remove(auto_confirm)
  File "/usr/lib/python3.4/site-packages/pip/req/req_uninstall.py", line 125, in remove
    renames(path, new_path)
  File "/usr/lib/python3.4/site-packages/pip/utils/__init__.py", line 315, in renames
    shutil.move(old, new)
  File "/usr/lib64/python3.4/shutil.py", line 536, in move
    os.unlink(src)
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3.4/site-packages/requests-2.7.0.dist-info/DESCRIPTION.rst'

Hmm that's not what I expected to see but it looks like your running requests-2.7 so that should be up-to-date enough :) If you don't mind, could you quickly add the following line to the rtv launch script and try re-launching rtv? That should force it to re-throw the HTTP error so we can see the source of the problem.
/usr/lib/python3.4/site-packages/rtv/main.py
@@ -120,6 +120,7 @@
         print('Invalid password for username: {}'.format(args.username))
     except requests.ConnectionError:
         print('Connection timeout')
+        raise
     except requests.HTTPError:
         print('HTTP Error: 404 Not Found')
     except SubmissionError as e:

Sure, on which line exactly should I place the code?

Looks like the same problem that you posted here https://github.com/untitaker/vdirsyncer/issues/224. A fix in requests https://github.com/kennethreitz/requests/issues/2659 is pending as of 2 weeks ago.

Ahh, good. A fix has been made so I (and other users) are just waiting for the fix to reach us down-stream.
Thanks for your time!

glad I could help


Add start of design notes documentation

This is just a place to collect various design rationale for
botocore for those curious.
cc @kyleknap @mtdowling @rayluo

Looks good. Had one comment. :ship:


swb: fixes from stressing Basics and Strings tests

Lower.cpp: needs WB from JIT set string item slots.
Added bunch of missing annotations that may contain GC pointers.
CompoundString: block buffer may contain chars or pointers. Ammended to
handle pointers correctly.

@dotnet-bot test Linux tests please

:shipit:

Thanks @digitalinfinity @leirocks


Add support for filepath repository rules

Fixes: #3231.
This is an attempt to add support for file_path_restriction in repository rules. It will implement #3231

Thank you, @tomfeigin !
Merging.

@gmlewis sorry to trouble you but when is the next release due?

@gmlewis sorry to trouble you but when is the next release due?

No troubles.  It looks like we are due for a roughly-monthly release so I will try to get this done by tonight (EDT).

@gmlewis sorry to trouble you but when is the next release due?

Release completed: https://github.com/google/go-github/releases/tag/v64.0.0


Body fails when it contains double quotes.

Like https://github.com/meeDamian/github-release/issues/10#issuecomment-562814389, probably need to replace " with \". The sed filter could probably be moved inline to toJsonOrNull to make sure it covers other fields (really just release name).
I know this action is semi-deprecated but I am also stuck on this until the GitHub provided one handles some of the same use cases as your fantastic action.
I'll try to open a PR to fix this but I've worked around it on my end already so unless it comes up again, I may forget, so I thought I'd document it in an issue for the time being.

Hey, it should be fixed by https://github.com/meeDamian/github-release/commit/5264f5bc3f3ab31750ca5e6b416b27acf83e3187, and I'll tag it as v2.0.2 soon.

Hey, now it fails when the body contains a backslash.
What worked for me
json_escape () {
printf '%s' "$1" | python -c 'import json,sys; print(json.dumps(sys.stdin.read()))[1:-1]'
}
The python dependency is the downside.
https://stackoverflow.com/questions/10053678/escaping-characters-in-bash-for-json
Actually, could you use jq itself?
echo $body | jq -R

@stm2 Can you check if #15 works for you with sth like:
uses: meeDamian/github-release@escaping
with:
	…

?

Running a quick test in my test repo produced this release, looks good to me.

Uhm, I think it works as intended, but not for me.  I'd like to do something like
jobs:
  build:
    steps:
      - name: Produce body
        run: |
          text=$(echo -e "Hello!\nWorld!\n")
          echo "set-env name=BODY::$text"
      - name: Create release
        uses: meeDamian/github-release@escaping
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          tag: ${{ env.TAG }}
          name: Pre-Release
          body: |
            ${{ env.BODY }}

But BODY only contains the first line. How would I go about producing a multiline body like this?

Could you try with:
body: >
  ${{ env.BODY }}

and
body: ${{ env.BODY }}

Also, I'd avoid using echo -e, or assigning from it w/o quotes (like text="$(…)").

text=$(echo -e "Hello!\nWorld!\n") 🤔
MacOS

Debian

Maybe try:
echo "set-env name=BODY::$(printf 'Hello!\nWorld!\n')"

or
text="Hello!
World!"

echo "set-env name=BODY::$text"

You were right about double quotes, of course. I figured out a workaround now from https://github.com/actions/create-release/pull/11. The trick is
  text=$(cat CHANGELOG.txt; echo -e '\n\nHello, World!\n')
  text="${text//'%'/'%25'}"
  text="${text//$'\n'/'%0A'}"
  text="${text//$'\r'/'%0D'}"
  echo "set-env name=BODY::$text"

They've also added a way to directly take the body from a file, which I find quite handy: https://github.com/actions/create-release/pull/50

Ok, closing the issue again, as the problem seems to be resolved.


The way we should load custom fonts

WPF approach:
Specify font family with pack://application:,,,/fonts/#MySuperFont Bold (res://AssemlyName.dll/fonts/#MySuperFont or res:/fonts/#MySuperFont in our case)
Upsides:

really easy to isolate fonts between assemblies
auto-discovery of font variants (italic, bold)
Downsides:
verbose
fonts might get duplicated
we need to migrate to WPF's model of handling resources that preserves actual file paths in the project. That will require an MSBuild task and runtime support in our asset loader. We need to completely migrate from resm, because relative uris won't work otherwise. That will break existing applications.

CSS approach
Register fonts globally somewhere. CSS does it like that:
 @font-face {
    font-family: myFirstFont;
    src: url(sansation_bold.woff);
    font-weight: bold;
    font-style: italic;
}

In our cast that would be:
<Application.Fonts>
  <FontResource FontFamily="MyFont" Uri="resm:Fonts.myfont.ttf" FontWeight="Normal" FontStyle="Italic"/>
</Application.Fonts>

Upsides:

It would be possible to write <TextBlock FontFamily="MyFont"> and it will just work

Downsides:

It's needed to manually specify ttf file for each font variant (bold, italic)
It won't be possible to have assembly-local fonts that don't interfere with anything else
It would be troublesome to register fonts from component assemblies

@grokys @danwalmsley @jkoritzinsky @wieslawsoltes

About fonts duplicating / interfering, as part of this we should allow comma separated font family names, where it searches maybe: Local assembly, then resources, then system fonts.
The issues with css method like trouble registering from component assembly, we are able tondo this with styles already so this could be overcome? Font variants perhaps we can have a syntax to specify multiple ttf files?

I like the WPF way, even if just for the relative paths for resources.
Also, couldn't we get syntax similar to the pro in the CSS section while still using the WPF-style loading?

As a temporary measure we could use zip files embedded as resources and treat them as "font collections".

The real question here is whether we want to switch to path-preserving resource model or not.

we need to migrate to WPF's model of handling resources that preserves actual file paths in the project.

What prevents loading fonts via the existing resm: scheme?

We need to completely migrate from resm, because relative uris won't work otherwise. That will break existing applications.

You mean that support for resm: resources would have to be removed? Why is that?

What prevents loading fonts via the existing resm: scheme?

Fonts consist of several ttf files. Some of them contain only one font variant, some contain multiple. WPF solves that by accepting a directory path with font name, then it scans all font files in said resource directory and constructs a collection of typefaces for that font. We can't do that with resm, because directory separator char becomes dot and we can't distinguish between them at run time.

You mean that support for resm: resources would have to be removed? Why is that?

Relative paths won't work between res and resm schemes, that will generate a lot of confusion. resm scheme was a workaround for Mono not having proper build targets, if I remember correctly. We were planning to implement our own build task later, but never done so.

Another option that won't require us to have path-preserving resource system is globbing.
E. g. <TextBlock FontFamily="resm:Some.Namespace.myfont*.ttf">

For relative paths between resm and res, we could standardize on resm always being in the root directory.

resm scheme was a workaround for Mono not having proper build targets, if I remember correctly

I don't think so - if I remember correctly it was because mono didn't have support for WPF-style resources (reading or writing)

mono didn't have support for WPF-style resources

Mono can read them without any issues, but xbuild/msbuild-on-mono doesn't have the required build targets for generating them.

Now that #1564 is merged I'm going to mark this as fixed.


ORC-577  row-level filtering

To support row-level filtering functionality as part of the ORC Reader this PR adds an new Reader.option as:
Options setFilter(String columnName, Consumer<VectorizedRowBatch> filter)
The idea is to use a generic Consumer callback that can implement any kind of filtering logic that is completely independent of the rest of the row reading logic in ORC. As a result the we cut down on the total code dependency between ORC and the consumer frameworks.

The filter callback with have to set the selected and selectedSize values (that already exist) in the VectorizedRowBatch class. For instance the filter-example below will filter-out all the rows except the first one:
public static void intFirstRowFilter(VectorizedRowBatch batch) {  LongColumnVector col1 = (LongColumnVector) batch.cols[0];  int newSize = 0;  for (int row = 0; row <1024; ++row) {  // Pass ony Valid key     if (col1.vector[row] == 0)        batch.selected[newSize++] = row;      batch.selectedInUse = true;  }  batch.size = newSize;
The logic of the row-level filter is as follows TreeReader Logic:

First, read the give columnName(s)
Evaluate the filter callback – filling the selected array and setting the selectedSize value as part of the VectorBatch
For the remaining columns of the VectorBach read only the selected rows to reduce the number or read/decoded rows thus saving CPU cycles

Ok, I've updated this patch to go with my proposed changes with HIVE-23215 and pushed it to https://github.com/omalley/orc/tree/orc-577-v2 .

Ok, I've updated this patch to go with my proposed changes with HIVE-23215 and pushed it to https://github.com/omalley/orc/tree/orc-577-v2 .

Awesome, thanks @omalley !  Patch look good -- only comment is that I used a single instance of IOUtils per Reader on purpose to avoid false-sharing, for example when having multiple reader on the same machine--  so I think it makes sense to keep it
Other than that, does it make sense to create an ORC branch for the effort? or just port the changes here? I am pretty sure we will have to make more changes before merging

All of the calls were static methods on IOUtils, so it seemed better to remove them unless there is a huge performance impact.

All of the calls were static methods on IOUtils, so it seemed better to remove them unless there is a huge performance impact.

Let me dig deeper on this and I will create a follow-up depending on the findings.
Just updated the PR addressing the comments including the proposed changes plus some cleaning -- please let me know what you think.
Cheers

Consolidating ORC-577 work and using recently released storage-api 2.7.2 that included FilterContext


Turn off ControlLoop in Disconnect

I'm confused why only keep_running_ is set to false in Terminate() and not also Disconnect(), as I do not want to std::terminate()! Thus, only Disconnect()-ing and destructing results in a segfault in SendRobotCmd()

I'm confused why only keep_running_ is set to false in Terminate() and not also Disconnect(), as I do not want to std::terminate()! Thus, only Disconnect()-ing and destructing results in a segfault in SendRobotCmd()

Thank you for your feedback! Indeed usage of std::terminate() in this case is not a good idea.
We have refactored the SDK multiple times and made a lot of improvements. If your hardware is compatible with the latest SDK in main branch, we encourage you to have a try.


Move ModelType out of api.

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 98.785% when pulling 56a89fe4d31b4c5b2d17871492d625205a960a9c on model_type into 988c7c0491a5c720a2c8bff315d010046e6c60d0 on main.


Hardhat tasks can be refactored more...

I have gone through all the hardhat tasks and have observed there are a few lines in each task that can be refactored.
Those few lines are:
const privateKey = getPrivateKey();
const rpcProviderUrl = getProviderRpcUrl(blockchain);
const provider = new providers.JsonRpcProvider(rpcProviderUrl);
const wallet = new Wallet(privateKey);
const signer = wallet.connect(provider);

In some tasks the rpcProviderUrl is named as sourceRpcProviderUrl and provider is named as sourceProvider.
It is a matter of naming convention we can decide upon using only rpcProviderUrl and provider and refactor the above code into a function.
The function can either be called setup or accountAndNetworkSetup in a file namely setup.ts.
This file then can be imported in almost all hardhat tasks and the function will be invoked instead of using the redundant 5 lines.
What this will do?

Improve code readability, thus making it easier to understand.
Remove redundant lines, thus making the code concise and compact.

Please do let me know what you think about, if this sounds good, I can open a PR for the same.
@andrejrakic @zeuslawyer

Perfect , will make the changes and submit a PR!


Does this work with react.js?

No matter what I try, I get
Uncaught Error: Invariant Violation: _registerComponent(...):   Now I've gotten rid of that, but I have no idea how to specify the UI of mocha.  This webpack/mocha thing is a real head scratcher.  There's even a youtube video which pretty much demonstrates how confusing it all is.  Once I figure it out I'll report back.


a way to add fake hands would be nice

my avatar cant crouch because it doesnt have hands
fun

Good idea, added to my todo list


[sct_register_gm] no option to use custom template for -winv

-winv use PAM50 or MNI-POLY-AMU... I would like to use a custom template...

Prerequisites
The files needed from the template (other than the warping fields) are :
1- the GM from the template warped to the subject space (i.e. label/template/PAM50_gm.nii.gz)
2- the WM from the template warped to the subject space (i.e. label/template/PAM50_wm.nii.gz)
3- a file from the template's original space (i.e. spinalcortoolbox/data/PAM50/template/PAM50_t2.nii.gz) --> only if the inverse warping field is requested
How to do it
--> a new flag is needed to input the file name of the template in it's original space (file 3-) to be able to concatenate the inverse warping fields: what would be the best name for this flag ?
--> for files 1- and 2-: two options to add the possibility of using a custom template:
A) --> keep flag -t and impose the structure label_custom/template/blabla_gm.nii.gz
PRO: keep the flags as they are,  preserve compatibility with older codes
CON: forces the user to reorganize its custom template
B) --> create 2 new flags  -t-gm and -t-wm (that would replace flag -t) with default values
PRO: the user can use whatever template organization, no impact on the people using the default parameters
CON: changing the flags implies that users who had scripts with flag -t would have to change them (probably very few people)
Additional information
Documentation of  sct_register_graymatter:
DESCRIPTION
Registration function to improve the template registration by accounting for the gray and white
matter shape using a multi-label approach. Output is a warping field from the template to the
target image accounting for the gray matter shape. If -winv is used, output also includes the
inverse warping field (from the target image to the template).

USAGE
sct_register_graymatter -gm <file> -wm <file> -w <file>

MANDATORY ARGUMENTS
 -gm <file>                   Gray matter automatic segmentation
 -wm <file>                   White matter automatic segmentation
 -w <file>                    Warping field: template -> image

OPTIONAL ARGUMENTS
 -t <folder>                  Path to template (registered on target image) Default value = label/
 -param <str>                 Parameters for the multimodal registration between multilabel images
                              Default value =
                              step=1,type=seg,
                              algo=centermassr
                              ot,metric=MeanSq
                              uares:step=2,typ
                              e=im,algo=syn,me
                              tric=MeanSquares
                              ,iter=10,smooth=
                              0,shrink=2:step=
                              3,type=im,algo=bsplinesyn,metric=MeanSquares,iter=5,smooth=0

OUTPUT OTIONS
 -winv <file>                 Warping field: image -> template.
 -ofolder <folder_creation>   Path to an output folder

VALIDATION: Use both flags for validation.
 -manual-gm <file>            Manual gray matter segmentation on the target image.
 -sc <file>                   Spinal cord segmentation on the target image.

MISC
 -qc {0,1}                    Output images for quality control. Default value = 1
 -r {0,1}                     Remove temporary files. Default value = 1
 -v {0,1,2}                   verbose: 0 = nothing, 1 = classic, 2 = expended Default value = 1

@SaraDupont: about file #3: if you only need an image with correct matrix/header, why not using PAM50_gm or PAM50_wm since they are in the same space of PAM50_t2?

i would be leaning towards option A. I think the current number of people with custom template is N=1 ;-)


Decide on the default max transaction size accepted by the mempool

We want to consider changing the default config for the mempool to accept larger transactions.
https://github.com/celestiaorg/celestia-core/blob/094cd2c631a5b970ce89e04a81f404c99c38bdf8/config/config.go#L744
related to #243
and there are concerns as well https://github.com/celestiaorg/celestia-core/issues/243#issuecomment-804273440 https://github.com/informalsystems/audit-celestia/issues/6

Can potential DoS vectors be fixed by somehow rate limiting transactions by IP or blacklisting IPs that repeatedly send invalid transactions?

yeah that makes sense, and is likely something we will need to build in the future. afaiu this would require some significant changes to the p2p stack. I believe this is actually something that the tendermint v0.35 p2p stack was attempting to address.

This isn't really a DoS vector (it's still a DDoS vector, but those are unavoidable) since the cost of validating even a large transaction really isn't that much, and a blacklist would be applied swiftly. Of course, this means we need a blacklist on invalid transactions, but that's needed anyways. Each invalid transaction can only consume a bounded amount of resources for finite time.

The point is that right now I don't think there's a blacklist, and also the problem is not just with invalid transactions, but with valid but very low/zero fee transactions.

afaiu this would require some significant changes to the p2p stack

after doing further digging, the state sync reactor has some form of peer blacklist
https://github.com/celestiaorg/celestia-core/blob/094cd2c631a5b970ce89e04a81f404c99c38bdf8/statesync/snapshots.go#L54
other reactors do not have this afaik, but it doesn't look that hard to do when we don't generalize it across reactors

I may be echoing what @adlerjohn said above but it seems like there are two separate issues being discussed here:

Decide on a value for MaxTxBytes
Design and implement a peer blacklist mechanism for the mempool

I think the issues are distinct and we need to reach consensus on (1) and can punt (2) until later. It also seems like (2) shouldn't impact (1) because an attacker could construct several small transactions or one large transaction. Peers of the validator can be forced to check the validity of the several small transactions or one large transaction so (2) is desirable regardless of what we decide for (1).

The point is that right now I don't think there's a blacklist, and also the problem is not just with invalid transactions, but with valid but very low/zero fee transactions.

If we are concerned about the mempool being flooded with low/zero fee transactions, a naive mitigation to this is to implement tx prioritization https://github.com/celestiaorg/celestia-app/issues/513#issuecomment-1282984922 and then configure either or both of these mempool parameters (both default to 0):
# ttl-duration, if non-zero, defines the maximum amount of time a transaction
# can exist for in the mempool.
#
# Note, if ttl-num-blocks is also defined, a transaction will be removed if it
# has existed in the mempool at least ttl-num-blocks number of blocks or if it's
# insertion time into the mempool is beyond ttl-duration.
ttl-duration = 0

# ttl-num-blocks, if non-zero, defines the maximum number of blocks a transaction
# can exist for in the mempool.
#
# Note, if ttl-duration is also defined, a transaction will be removed if it
# has existed in the mempool at least ttl-num-blocks number of blocks or if
# it's insertion time into the mempool is beyond ttl-duration.
ttl-num-blocks = 0

If we are concerned about the mempool being flooded with low/zero fee transactions

This might be in some other issue somewhere, but what about setting the default minimum fee in the app.toml to something other than zero?

It seems like the default minimum gas price is set by a full-node operator here but we can provide a default higher than 0 here. Based on the docs below, I propose we rely on the default mempool configuration of:
ttl-duration = 0
ttl-num-blocks = 0

and encourage full-node operators to use a minimum gas fee > 0
Screenshot from Cosmos SDK AnteHandler:

Screenshot from Cosmos SDK auth module:

Just as a ballpark, 1 MB messages should probably a good starting point upper bound I think

Sourced from https://github.com/celestiaorg/celestia-core/issues/243
but given the default is 1 MiB I expect that comment is outdated. Do we have an updated estimate for the the size of messages we intend on supporting?

I think we should change the default value for ttl-num-blocks to something non-zero, as per suggested in #812
as discussed elsewhere, without a blocklist, the size of the tx isn't that important as a malicious node could spam their peers with many small txs and have the same effect. Projects have expressed having the ability to submit up to 2MB blocks, so imo we should just stick with that for now.
@rootulp does that sound reasonable? can we add this as a default in celestia-app and close this?

Yea, SGTM.

Projects have expressed having the ability to submit up to 2MB blocks

Out of curiosity, which projects?


Thread pool unit test

What is the purpose of the change
unit test for package com.alibaba.dubbo.common.threadpool
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #1802 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1802      +/-   ##
============================================
+ Coverage     39.81%   39.99%   +0.18%
- Complexity     4327     4345      +18
============================================
  Files           626      626
  Lines         30078    30078
  Branches       5314     5319       +5
============================================
+ Hits          11975    12031      +56
+ Misses        16190    16136      -54
+ Partials       1913     1911       -2

Impacted Files
Coverage Δ
Complexity Δ

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
77.77% <0%> (-11.12%)
5% <0%> (-2%)

...aba/dubbo/common/compiler/support/JdkCompiler.java
61.81% <0%> (ø)
2% <0%> (ø)
:arrow_down:

...m/alibaba/com/caucho/hessian/io/Hessian2Input.java
19.27% <0%> (+0.11%)
63% <0%> (ø)
:arrow_down:

...on/src/main/java/com/alibaba/dubbo/common/URL.java
26.34% <0%> (+0.44%)
77% <0%> (+1%)
:arrow_up:

.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java
59.09% <0%> (+2.27%)
8% <0%> (ø)
:arrow_down:

...a/com/alibaba/dubbo/remoting/exchange/Request.java
85.71% <0%> (+2.38%)
20% <0%> (ø)
:arrow_down:

...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java
71.42% <0%> (+2.85%)
3% <0%> (ø)
:arrow_down:

...a/dubbo/remoting/transport/netty/NettyChannel.java
66.25% <0%> (+8.75%)
21% <0%> (+2%)
:arrow_up:

...mmon/threadpool/support/eager/EagerThreadPool.java
100% <0%> (+10%)
3% <0%> (+1%)
:arrow_up:

...ibaba/dubbo/common/threadlocal/InternalThread.java
36.84% <0%> (+10.52%)
4% <0%> (+1%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78f6d4...c35c34b. Read the comment docs.


[External Memory Version] Check failed: batch.index != nullptr

Using the external memory version of the python implementation, I ran into the above error while testing on a test dataset (sparse, but not empty, see below).
Similar to #1827, but not on spark, so I opened a new issue.
Full Error output:
raise XGBoostError(_LIB.XGBGetLastError())
xgboost.core.XGBoostError: b'[19:54:41] src/data/././sparse_batch_page.h:88: Check failed: batch.index != nullptr \n
\nStack trace returned 10 entries:
\n[bt] (0) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost4data16SparsePageSource6CreateEPN4dmlc6ParserIjEERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x318a) [0x7fd7521b74da]
\n[bt] (1) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost7DMatrix6CreateEPN4dmlc6ParserIjEERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x20b) [0x7fd7521d368b]
\n[bt] (2) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost7DMatrix4LoadERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEbbS8_+0xe33) [0x7fd7521d4d43]
\n[bt] (3) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(XGDMatrixCreateFromFile+0x1d0) [0x7fd7522a3240]\n[bt] (4) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c) [0x7fd773e12ec0]
\n[bt] (5) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call+0x22d) [0x7fd773e1287d]
\n[bt] (6) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(_ctypes_callproc+0x2ce) [0x7fd774027dee]
\n[bt] (7) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(+0x12825) [0x7fd774028825]
\n[bt] (8) python(_PyObject_FastCallDict+0x8b) [0x55e1af2c11bb]\n[bt] (9) python(+0x19cd3e) [0x55e1af34ed3e]\n'

For other similar datasets, everything seems to work fine, so I speculated this might be caused by the sparsity of this testing dataset.
To check if the dataset is indeed not empty I did:
In [1]: ls
dtest.r0-1.cache.row.page  dtrain.r0-1.cache  dtrain.r0-1.cache.row.page  fold_4_test.txt  fold_4_train.txt
In [2]: from scipy import *
In [3]: from sklearn.datasets import load_svmlight_file
In [4]: data = load_svmlight_file("fold_4_test.txt")
In [5]: sum(data[0])
Out[5]:<PHONE_NUMBER>.3337207
In [6]: sum(data[1])
Out[6]: 19627.0
In [7]: data[0].shape
Out[7]: (4150265, 108)
In [8]: data[1].shape
Out[8]: (4150265,)

Environment info
Operating System: Ubuntu 16.04.4 LTS
Package used: python xgboost package, installed with pip, as available of June 2018
Python: 3.6.4

Can you post the dataset you used to train the model?

This is the part of the dataset where the problem occurs:
https://www.dropbox.com/s/rhyno7kx9g2tok9/Login.txt?dl=0

This is the part of the dataset that causes the problem:
https://www.dropbox.com/s/7vfnj6caoam7vf6/fold_4_train.txt?dl=0

Any news on this issue?

I'll take a look at it this weekend.

@MonsieurWave So far I am unable to re-produce the issue. Can you post your training script as well?
Here is my attempt:
import xgboost as xgb

dtrain = xgb.DMatrix('./fold_4_train.txt#dtrain.cache')
param = {'max_depth':2, 'eta':1, 'silent':1, 'objective':'binary:logistic'}
watchlist = [(dtrain, 'train')]
num_round = 2
bst = xgb.train(param, dtrain, num_round, watchlist)

@hcho3 : Thank you for your help!
Here is the part of my script responsible for training and which fails:
import os
import xgboost as xgb

params = {
    'base_score': 0.5,
    'booster': 'gbtree',
    'colsample_bylevel': 1,
    'colsample_bytree': 1,
    'eval_metric': 'auc',
    'gamma': 0.84,
    'learning_rate': 0.4,
    'max_delta_step': 0,
    'max_depth': 1,
    'min_child_weight': 10.0,
    'n_estimators': 999,
    'n_jobs': -1,
    'objective': 'binary:logistic',
    'random_state': 0,
    'reg_alpha': 0.8671463346569078,
    'reg_lambda': 0.5916603334004378,
    'scale_pos_weight': 1,
    'silent': True,
    'subsample': 0.7925462136041614,
    'tree_method': 'hist'
}

n_estimators = params['n_estimators']

iteration_dir = './'
ext_mem_extension = '.txt'
fold = 'fold_1'

fold_dir = os.path.join(iteration_dir, fold)

dtrain = xgb.DMatrix(os.path.join(fold_dir, fold + '_train' + ext_mem_extension)
    + '#' + os.path.join(fold_dir, 'dtrain.cache'))
dtest = xgb.DMatrix(os.path.join(fold_dir, fold + '_test' + ext_mem_extension)
    + '#' + os.path.join(fold_dir, 'dtest.cache'))

trained_model = xgb.train(params, dtrain,
    num_boost_round = n_estimators,
    evals = [(dtest, 'Test')],
    early_stopping_rounds = 30,
    verbose_eval = False)

Here is the associated data again:
https://www.dropbox.com/sh/iu9evsluagxsu68/AABXOIqn8XrxepcKcacsPYxNa?dl=0

@MonsieurWave I was still unable to re-produce the error, even with your script.

@hcho3 : That is strange.
I have reinstalled from source the latest master as specified here, however it is still failing with the same error, although the error output has changed slightly.
Here is the full output upon execution of the script now:
python temp.py
[08:43:42] 288958x109 matrix with 21589322 entries loaded from /home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/fold_1_train.txt#/home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/dtrain.cache
[08:43:47] Writing row.page to /home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/dtest.cache in 14.1066 MB/s, 64 written
[08:43:52] Writing row.page to /home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/dtest.cache in 16.8679 MB/s, 160 written
[08:43:55] Writing row.page to /home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/dtest.cache in 17.3135 MB/s, 224 written
[08:44:02] SparsePage::Writer Finished writing to /home/user/data/working_data/saved_data/old_CV_10_folds/iteration_0/fold_1/dtest.cache.row.page
Traceback (most recent call last):
  File "temp.py", line 39, in <module>
    + '#' + os.path.join(fold_dir, 'dtest.cache'))
  File "/home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/core.py", line 357, in __init__
    ctypes.byref(self.handle)))
  File "/home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/core.py", line 151, in _check_call
    raise XGBoostError(_LIB.XGBGetLastError())
xgboost.core.XGBoostError: b'[08:43:56] include/xgboost/data.h:205: Check failed: batch.index != nullptr \n\nStack trace returned 10 entries:\n[bt] (0) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(dmlc::StackTrace[abi:cxx11]()+0x56) [0x7f4c925d75a6]\n[bt] (1) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(xgboost::data::SparsePageSource::Create(dmlc::Parser<unsigned int, float>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x1bd4) [0x7f4c926ad5f4]\n[bt] (2) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(xgboost::DMatrix::Create(dmlc::Parser<unsigned int, float>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x11b) [0x7f4c926ca41b]\n[bt] (3) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(xgboost::DMatrix::Load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x883) [0x7f4c926cad43]\n[bt] (4) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(XGDMatrixCreateFromFile+0x15e) [0x7f4c9277dcde]\n[bt] (5) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c) [0x7f4ca913eec0]\n[bt] (6) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call+0x22d) [0x7f4ca913e87d]\n[bt] (7) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(_ctypes_callproc+0x2ce) [0x7f4ca9353dee]\n[bt] (8) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(+0x12825) [0x7f4ca9354825]\n[bt] (9) python(_PyObject_FastCallDict+0x8b) [0x5612b07b41bb]\n\n'
Exception ignored in: <bound method DMatrix.__del__ of <xgboost.core.DMatrix object at 0x7f4ca957e048>>
Traceback (most recent call last):
  File "/home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/core.py", line 483, in __del__
    _check_call(_LIB.XGDMatrixFree(self.handle))
  File "/home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/core.py", line 151, in _check_call
    raise XGBoostError(_LIB.XGBGetLastError())
xgboost.core.XGBoostError: b'[08:44:02] src/c_api/c_api.cc:714: DMatrix/Booster has not been intialized or has already been disposed.\n\nStack trace returned 10 entries:\n[bt] (0) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(dmlc::StackTrace[abi:cxx11]()+0x56) [0x7f4c925d75a6]\n[bt] (1) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(dmlc::LogMessageFatal::~LogMessageFatal()+0x28) [0x7f4c925d7cb8]\n[bt] (2) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/site-packages/xgboost-0.72-py3.6.egg/xgboost/./lib/libxgboost.so(XGDMatrixFree+0xf7) [0x7f4c92776787]\n[bt] (3) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c) [0x7f4ca913eec0]\n[bt] (4) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call+0x22d) [0x7f4ca913e87d]\n[bt] (5) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(_ctypes_callproc+0x2ce) [0x7f4ca9353dee]\n[bt] (6) /home/user/anaconda3/envs/stroke-predict/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(+0x12825) [0x7f4ca9354825]\n[bt] (7) python(_PyObject_FastCallDict+0x8b) [0x5612b07b41bb]\n[bt] (8) python(+0x19cd3e) [0x5612b0841d3e]\n[bt] (9) python(_PyEval_EvalFrameDefault+0x30a) [0x5612b086619a]\n\n'

Complete environment:
xgboost version : 0.72
Python 3.6.4 with Anaconda 3
OS: Ubuntu 16.04.4 LTS

I have just tested on my local system, and it works fine there. Unfortunately running all the data locally is not an option for me...
xgboost version: 0.72
Python 3.6.4
OS: Mac OS X 10.13.6, Darwin Kernel Version 17.7.0

Have just tried on an Arch machine, where the same error occurs:
xgboost version: 0.72.1
Python 3.6.5 with Anaconda3
OS Kernel: Linux 4.16.11-1-ARCH

@MonsieurWave I tried your script on an EC2 instance with Ubuntu 16.04 and I couldn't reproduce the error. Without re-producing the error on my end, I cannot fix it.
Can you create either a VM image (VirtualBox) or AMI (on EC2) where the error is triggered?

@MonsieurWave Any update on this?

@hcho3 : I have not been able to reproduce the issue on a VMI launched from a local Mac, but the issue persists on all my linux servers. Will try to launch a VMI from there to see if it is hardware related.

@MonsieurWave Any update?

Closing for now. Re-open it if you have any update.


Use eventfd to implement signal.

https://github.com/Berrysoft/compio/issues/28#issuecomment-1711592536

I'm not familiar with eventfd. Do you know why eventfd causes EBUSY in io-uring? @DXist

Haven't used it yet.
Do you have full completion queue when you try to submit? Do you read in blocking way?
There is a relevant issue in monoio

Poller::post is removed because it is not consistent between platforms. A new type Event is added, providing functionality to wake up driver. Event uses eventfd for io-uring, and calls PostQueuedCompletionStatus on Windows.

I think we could move RefCells into runtime and wrap Runtime::driver field.

I'll try that.


Test Issue created at Sun, 18 Jul 2021 02:15:14 GMT

Test issue body  Sun, 18 Jul 2021 02:15:14 GMT

Comment on issue at Sun, 18 Jul 2021 02:15:16 GMT


Merging dev-rating-system branch to main branch

Implementation of rating system.

Looks great, let's merge this.

Looks good to me too. let's merge this.

Thanks for the reviews!


Prevent slider from extending farther than the last pip

Fix #708

@olance we have a strict contributing policy.
It should be fix(rangeSlider): 	prevent slider from extending farther than the last pip.

@redox that should be OK now? :)

:+1: @olance

@redox: Do you think the message you wrote could be added as some part of automatic check by the algobot?

Yes, need to check how to do that; but definitely :)

Basically we could just develop our own algolia contribution bot doing more checks but right now travis already does a decent job

Maybe just posting the Travis error message (if we can get the meaningful one in the list) in the thread.


how to use mapMultiRowFields on nested state ?

i use nuxt js, i want to implementation dynamic form like https://markus.oberlehner.net/blog/how-to-handle-multi-row-forms-with-vue-vuex-and-vuex-map-fields/
how to access mapMultiRowFields on nested state store, bookingData.flight.passengers ?
and i got error store.getters[getterType] is not a function
store/bookingData.js
import { getField, updateField } from 'vuex-map-fields'

export const state = () => ({
  flight: {
    contact: {
      title: '',
      fullname: '',
      email: '',
      phone: ''
    },

    passengers: [
      {
        title: '',
        fullname: '',
        birthday: ''
      },
      ...
    ]
  }
})

export const getters = { getField }

export const mutations = {
  updateField
}

component.vue
<template>
.card.shadow.mb-4(v-for="passenger, index in passengers" v-on:key="'passengers'+index")
  input.form-control(
    type="text" required
    v-model="passenger.fullname")
.....

<script>
.....
computed: {
  ...mapMultiRowFields({ passengers: 'bookingData.flight.passengers' })
}
.....

Hey @blackinitial!
Am I right that bookingData is a namespaced module? If so, this should help: https://codesandbox.io/s/2v042zjw0r
You can read more about dealing with namespaced modules here: https://github.com/maoberlehner/vuex-map-fields#namespaced-vuex-modules

I solve it with:
import { createHelpers } from 'vuex-map-fields'
import { mapMutations } from 'vuex'
const { mapFields, mapMultiRowFields } = createHelpers({
  getterType: 'my_module/getField',
  mutationType: 'my_module/updateField',
})

export default {
  // ...
  computed: {
    ...mapMultiRowFields(['address']),
  },
  // ...
}

I think it will be helpful for you!

Closing this due to no further feedback from OP.

Hey @blackinitial!
Am I right that bookingData is a namespaced module? If so, this should help: https://codesandbox.io/s/2v042zjw0r
You can read more about dealing with namespaced modules here: https://github.com/maoberlehner/vuex-map-fields#namespaced-vuex-modules

I'm struggling with this exact issue; the difference is that I'm using Nuxt.js and am having trouble implementing this part:
const store = new Vuex.Store({   // ...   modules: { bookingData } });
Any advice? Also get this message in my developer console when I use mapMultiRowFields
"(error during evaluation)"


Inconsistency in comment for RESTORE

this line says we used RESTORE: https://github.com/spine-generic/spine-generic/blob/master/process_data.sh#L292
but at the end we did not

Do we want to only clarify line with the comment (i.e., delete info about RESTORE) or switch algorithm from standard to restore?:
https://github.com/spine-generic/spine-generic/blob/e457dbc0afd184725a95f6ce9f386f45f5b069f4/process_data.sh#L293

only clarify comment


Overhaul qbt list command to make it more readable

Fantastic project you have here, its been super helpful lately! I felt like the qbt list was pretty hard to read so I decided to try and write some of my first Go code to help out!
Screenshot of this PR's current changes (excuse the torrent choices):

These were the properties I found useful to actually be listed, but if you think there are more I missed or something I should remove let me know!
Lastly, I corrected the json property attached to DlSpeed from dl_speed to dlspeed.

Thanks, happy it's useful!
Nice improvement! I used list mostly to see if there was any output at all and working connection, but with this it's more useable.
Will take a look at the code in a bit.

Any updates on if this could be merged?

Great! Then I'll merge this :+1:
Thank you for your contribution :100:


CBTBE blocks weapons in arms locations of troopers in melee

@FancyRaptor i actually only just noticed that in logs. month after BA rework, LOL
CBTBE is blocking weapons of "Arms" troopers in melee
should not block any except "NeverMelee" for CU squads

Fixed already ; see https://github.com/BattletechModders/CBTBehaviorsEnhanced/blob/master/CBTBehaviorsEnhanced/CBTBehaviorsEnhanced/Melee/States/WeaponAttack.cs#L79


[GEP-7] Fix restoration of Machines and MachineSets

How to categorize this PR?

/area control-plane-migration
/kind bug
/priority normal
What this PR does / why we need it:
Fixes a bug where machines were being recreated during migration scenario.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@vlvasilev can you "throw an eye"
Release note:

NONE

/invite @vlvasilev
/needs-second-opinion


Drop node 8

Drop node 8 as it reached it's EOL

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: add flag docs

Codecov Report

Merging #37 (2c2a67e) into main (2a2a2f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   68.19%   68.19%
=======================================
  Files          10       10
  Lines        1393     1393
=======================================
  Hits          950      950
  Misses        348      348
  Partials       95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2a2f2...2c2a67e. Read the comment docs.


License for seebi/dircolors-solarized?

Hi seebi,
Thank you for the great work on dircolors-solarized. I really want to use your script at work but my employer requires that dircolors-solarized has an explicit open-source license on Github page. So far I see that dircolors.256dark has a license (even though not GPL / MIT). Can you add license to the whole repo or to the other dircolors.ansi-* files? Thank you for your work.

ok, added a standard MIT License


Treemap example does not work

I was trying out the treemap example today as given in the repo and for some reason the treemaps won't render properly. Here's what I'm getting:
https://imgur.com/vdrhJCv

My code for reference:
`// Copyright (c) 2016 - 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
import React from 'react';
import {Treemap} from 'react-vis';
function _getRandomData(total) {
const totalLeaves = total || Math.random() * 20;
const leaves = [];
for (let i = 0; i < totalLeaves; i++) {
leaves.push({
name: total ? total : String(Math.random()).slice(0, 3),
size: Math.random() * 1000,
color: Math.random(),
style: {
border: 'thin solid red'
}
});
}
return {
title: '',
color: 1,
children: leaves
};
}
export default class DynamicTreemapExample extends React.Component {
state = {
hoveredNode: false,
treemapData: _getRandomData(20),
useCirclePacking: false
}
render() {
const {hoveredNode, useCirclePacking} = this.state;
const treeProps = {
animation: {
damping: 9,
stiffness: 300
},
data: this.state.treemapData,
onLeafMouseOver: x => this.setState({hoveredNode: x}),
onLeafMouseOut: () => this.setState({hoveredNode: false}),
onLeafClick: () => this.setState({treemapData: _getRandomData()}),
height: 300,
mode: this.state.useCirclePacking ? 'circlePack' : 'squarify',
getLabel: x => x.name,
width: 350
};
return (

<Treemap {...treeProps}/>
click above to the update data
{hoveredNode && hoveredNode.value}

);
}
}
`

If you are using dom mode (the default) you need to make sure to import the style sheet

Thanks! That solved the issue. :)

If you are using dom mode (the default) you need to make sure to import the style sheet

Which stylesheet do I need to use?

Just the regular one! You can import (among other ways) by including it in the html with
<link rel="stylesheet" href="https://unpkg.com/react-vis/dist/style.css">

Hi,
I am using the stylesheet but I am just getting a square still. Is there anything else I have to do? Here is my code:
const myData = {
"title": "analytics",
"color": "#12939A",
"children": [
{
"title": "cluster",
"children": [
{ "title": "AgglomerativeCluster", "color": "#12939A", "size": 3938 },
{ "title": "CommunityStructure", "color": "#12939A", "size": 3812 },
{ "title": "HierarchicalCluster", "color": "#12939A", "size": 6714 },
{ "title": "MergeEdge", "color": "#12939A", "size": 743 }
]
},
{
"title": "graph",
"children": [
{ "title": "BetweennessCentrality", "color": "#12939A", "size": 3534 },
{ "title": "LinkDistance", "color": "#12939A", "size": 5731 },
{ "title": "MaxFlowMinCut", "color": "#12939A", "size": 7840 },
{ "title": "ShortestPaths", "color": "#12939A", "size": 5914 },
{ "title": "SpanningTree", "color": "#12939A", "size": 3416 }
]
},
{
"title": "optimization",
"children": [
{ "title": "AspectRatioBanker", "color": "#12939A", "size": 7074 }
]
}
]
};
render(){

...

}


Translation possibility and a suggestion of update to the item icon

Hello. I'm a Brazilian Portuguese (PT-BR) speaker and it would be awesome if I could do a translation file for the mod. I hope it gets implemented! Right now the copper hoper item as well as the container are named "Item Filter" but I didn't find any en_us.json with the references.
Also, I tweaked the copper hopper texture to be more in line with copper-made items and blocks. I put more shiny spots to give a metalic feel to the item, hope you like it. Feel free to use in the mod.

Hi!  Yes, localization support is on my TODO list.  If you wanted give me the pt-be translation, I’ll be sure to include it.
In the meantime, you can change the name in the copper hopper.json config file if you want.
And thanks so much for the texture!  I’m a terrible artist so that’s really helpful.  Will definitely use it (and give you a shout-out!)
thanks!

Thanks for the support! I'm happy you like the texture.

Ok, I just released a new version that includes i18n support (with an en_us.json file) and also has your texture.  Thanks again!


Prepping Falco 0.28.0

Signed-off-by: Leonardo Di Donato<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
Adds the CHANGELOG for Falco 0.28.0
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
While prepping Falco 0.28.0 I noticed the correct date (YYYY-MM-DD) to provide to GitHub filters is not the day before the previous release. Instead, it's the day the latest release happened.
Also added clearer instructions on how to generate the CHANGELOG.
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from leodido after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.28.0

/cc @fntlnz
/cc @leogr

LGTM label has been added.  Git tree hash: 828785f46896fadead8b4283c3ee76ee06975b31

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add bindings for WebSockets

This PR adds bindings for WebSockets.
One thing that's missing is support for CloseEvent, which adds a code attribute to the normal attributes of an event. I wasn't sure if there's an easy way to include the interface for Event.

A few things that are missing from this PR:

t_of_js and t_to_js (so one can convert Event.target back to WebSocket.t)
The binaryType property
The readyState property and corresponding constants

Added. Will squash once the jsoo bug is fixed.

@leviroth Thanks! binaryType should also be settable, the rest looks good to me.

I've squashed this down to one commit.

Thanks!


Flag is not changing with phone number

Hi,
I am facing a problem while changing my phone number. when I pick a country from the modal Picker and tries to change my phon number then sometimes the phone number does not reflect with that country code. Also, my flag got vanish from the input. Please see the below screenshot

pls enter cerroct contry code

Please make a pull request. I have taken ownership of this repo because the previous publisher stopped following up. I'm happy to check and publish updates, but I don't have much time to dedicate to the project development at this time. I will try to work on the development more when my schedule fees up.

This has been resolve with the latest PRs. I've also fixed the autoFormat property.


feat(xdg-compliance): rc file location hierarchy

vue-cli now uses the following hierarchy for hosting its rc file:

VUE_CLI_CONFIG_PATH
XDG_CONFIG_HOME/vue/.vuerc
HOME/.config/vue/.vuerc
HOME/.vuerc

Let me know if you need something changed
I would like to point out that the middle 2 paths probably shouldn't be hidden files. Left that up to the devs though.
closes #1325

Should be fixed now


error in unity 2019.4.40

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in :0
at ReferenceFinderData.UpdateReferenceInfo () [0x00037] in **\Assets\Editor\ReferenceFinder\ReferenceFinderData.cs:60
at ReferenceFinderData.CollectDependenciesInfo () [0x000c0] in **\Assets\Editor\ReferenceFinder\ReferenceFinderData.cs:43
UnityEngine.StackTraceUtility:ExtractStackTrace ()
UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[])
UnityEngine.Logger:Log (UnityEngine.LogType,object)
UnityEngine.Debug:LogError (object)
to resolve:
in ReferenceFinderData.UpdateReferenceInfo()
 foreach(var assetGuid in asset.Value.dependencies)
 {
    if (assetDict.ContainsKey(assetGuid))
       assetDict[assetGuid].references.Add(asset.Key);
 }

Has been fixed.


I modded Support PNG and JPEG format image file . But I have problem .

Hello !
I modded HackBGRT to support PNG format image file using upng library .
https://github.com/FREEWING-JP/HackBGRT/tree/test/add_upng
But Ihave problem .

Build only the 64-bit version .
Because I don't know how to write a Makefile script .
This modify is TRUE SAFE ?
I don't know it has any MEMORY LEAK or/and STORAGE FILE BREAK .

Hello !
I add support JPEG format image file using picojpeg library .
https://github.com/FREEWING-JP/HackBGRT/tree/test/add_picojpeg
But still I have problem .

This modify is TRUE SAFE ?

The author of this mod hasn't been active since February. I don't know much about it being truly safe or not, but good job!

Version 2.0.0 converts images during install. I think it's a better approach, because any extra code in the boot loader stage (with full access to the computer HW, firmware, disks and all) can cause unexpected and terrible problems.

Version 2.0.0 converts images during install.

But BMP file format is Very FAT .
BMP files waste space on EFI .

any extra code in the boot loader stage

I think so .
But There are no special characteristics to be concerned about in the program code that expands compressed images .

But There are no special characteristics to be concerned about in the program code that expands compressed images .

Buffer overflows are very common in decoding and decompression implementations. For example, the upng library (which you apparently used) warns that "Several potential buffer overflows in the original source have been fixed in uPNG, but there may be more. Do NOT use uPNG to load data from untrusted sources, e.g. the Web. Doing so may open a remotely exploitable buffer overflow attack in your application."
Also, many of these tiny libraries support only a limited set of features, so some images would still need to be re-encoded.
I'm not convinced about upng or picojpeg for this project.

Buffer overflows are very common in decoding and decompression implementations.

Okay . I finally understood .