Missing season torrent will block the rename and link, for single episode

When I search and download a season, and the system found a wrong season (or another tv show). therefore I decided to replace one by one, and remove the wrong full season downloading in transmission.
The system will throw error at
const isComplete = transmissionTorrent.percentDone === 1;
in refresh-torrent.processor.ts
Cannot read property 'percentDone' of undefined
Because there's no season torrent exists in transmission client, thus transmissionTorrent is undefined, and rest of the process will break.
I think it needs to check the object before getting percentDone, or any suggestion?  I'm trying to learn the code from today, see if I can help in the feature.
I temporarily add const isComplete = !! transmissionTorrent && transmissionTorrent.percentDone === 1;
to by pass it.

Hey @qqnc that is a pretty good fix, can you open a PR and then I will be happy to do a code review and help you out 👍

And this is linked to #50 because bobarr is downloading a season pack but it can't allow to select another season pack or to stop the download.

thanks, haven't checked this for quite a while

thanks, haven't checked this for quite a while


Implementing support for exporting threads

Hi,
This PR adds support for dumping threads (in the regular Slack format) from channels.
Please see here for some more background: https://github.com/zach-snell/slack-export/issues/40
Cheers,
Andrew
Signed-off-by: Andrew V. Jones<EMAIL_ADDRESS>

Just got this message, any clues?
Successfully authenticated for team ******* and user *****
Found 13 Users
Found 2 Public Channels
Traceback (most recent call last):
File "slack_export.py", line 384, in
bootstrapKeyValues()
File "slack_export.py", line 284, in bootstrapKeyValues
groups = slack.conversations.list(limit = 1000, types=('private_channel', 'mpim')).body['channels']
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 217, in list
'limit': limit
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 120, in get
api, **kwargs
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 102, in _request
raise Error(response.error)
slacker.Error: missing_scope
Thank you

Just got this message, any clues?
Successfully authenticated for team ******* and user *****
Found 13 Users
Found 2 Public Channels
Traceback (most recent call last):
File "slack_export.py", line 384, in
bootstrapKeyValues()
File "slack_export.py", line 284, in bootstrapKeyValues
groups = slack.conversations.list(limit = 1000, types=('private_channel', 'mpim')).body['channels']
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 217, in list
'limit': limit
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 120, in get
api, **kwargs
File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 102, in _request
raise Error(response.error)
slacker.Error: missing_scope
Thank you

https://github.com/andrewvaughanj/slack-export/tree/thread_dump produces
Traceback (most recent call last):
File "slack_export.py", line 424, in
fetchDirectMessages(selectedDms)
File "slack_export.py", line 226, in fetchDirectMessages
messages = getHistory(slack.im, dm['id'])
File "slack_export.py", line 36, in getHistory
response = pageableObject.history(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 601, in history
return self.get('im.history',
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 120, in get
return self._request(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 104, in _request
raise Error(response.error)
slacker.Error: unknown_method

Just got this message, any clues?
Successfully authenticated for team ******* and user ***** Found 13 Users Found 2 Public Channels Traceback (most recent call last): File "slack_export.py", line 384, in bootstrapKeyValues() File "slack_export.py", line 284, in bootstrapKeyValues groups = slack.conversations.list(limit = 1000, types=('private_channel', 'mpim')).body['channels'] File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 217, in list 'limit': limit File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 120, in get api, **kwargs File "/Users/syox/Library/Python/2.7/lib/python/site-packages/slacker/init.py", line 102, in _request raise Error(response.error) slacker.Error: missing_scope
Thank you

@filipedematos: you get this error if the "bot" you've created to get access to the channel does not have enough access permissions to read what you're trying to export.

I'm trying to export my channels but the script keeps trying to fetch the first channel forever, irrespective of which channel (public or private) I choose.
Output:
"Fetching history for Public Channel: b'what_is_slack'
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
..............................................................................................................................................................................
.............................................................................................................................................................................. "

Why do you think it is not still running? This export is extremely slow because Slack heavily rate-limits connections.

Because when using https://github.com/lumbric/slack-export/tree/working-draft the job is done in less than 5 minutes (yes, without threads), whereas this script has now been running for 2 hours and is apparently still working on the first (public) channel, which contains barely any messages. And it has not written any data during those 2 hours expect at the beginning, when the channels.json, dms.json, groups.json, mpims.json and users.json files were created. The what_is_slack directory is still empty.

Are you getting "fresh dots"? I no longer have access to a Slack instance to heavily test this with (which is why I wrote it).

channels.json, dms.json, groups.json, mpims.json and users.json files were created.

These don't get updated when dumping threads; you get separate json files for each date (and in each channel). I can't remember if they're written as dumping happens or at the end.

whereas this script has now been running for 2 hours and is apparently still working on the first (public) channel

I left this running over a whole weekend to dump a "small" channel. The rate limits on Slack are something like 10 messages (or maybe 100) every 1 second -- it really takes a long time to dump this way.
If you care, before this line:

https://github.com/andrewvaughanj/slack-export/blob/bdbc09e53b6fb3ae024bf1d3164ef9526990f334/slack_export.py#L48

add a print of response["messages"] to see what's being dumped.

After running for about 20 hours, the script breaks:
Traceback (most recent call last):
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/home/asterix/anaconda3/lib/python3.8/http/client.py", line 1332, in getresponse
response.begin()
File "/home/asterix/anaconda3/lib/python3.8/http/client.py", line 303, in begin
version, status, reason = self._read_status()
File "/home/asterix/anaconda3/lib/python3.8/http/client.py", line 264, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/home/asterix/anaconda3/lib/python3.8/socket.py", line 669, in readinto
return self._sock.recv_into(b)
File "/home/asterix/anaconda3/lib/python3.8/ssl.py", line 1241, in recv_into
return self.read(nbytes, buffer)
File "/home/asterix/anaconda3/lib/python3.8/ssl.py", line 1099, in read
return self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/adapters.py", line 439, in send
resp = conn.urlopen(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 724, in urlopen
retries = retries.increment(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/util/retry.py", line 403, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/packages/six.py", line 735, in reraise
raise value
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 670, in urlopen
httplib_response = self._make_request(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/urllib3/connectionpool.py", line 335, in _raise_timeout
raise ReadTimeoutError(
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='slack.com', port=443): Read timed out. (read timeout=10)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "slack_export.py", line 479, in
fetchPublicChannels(selectedChannels)
File "slack_export.py", line 235, in fetchPublicChannels
messages = getHistory(slack.conversations, channel['id'])
File "slack_export.py", line 126, in getHistory
messages.extend(getReplies(channelId, message["thread_ts"], pageSize))
File "slack_export.py", line 23, in getReplies
response = conversationObject.replies(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 246, in replies
return self.get(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 120, in get
return self._request(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/slacker/init.py", line 97, in _request
response = request_method(
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/api.py", line 76, in get
return request('get', url, params=params, **kwargs)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/home/asterix/anaconda3/lib/python3.8/site-packages/requests/adapters.py", line 529, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='slack.com', port=443): Read timed out. (read timeout=10)

¯_(ツ)_/¯
you're welcome to dive into the code


Opening Distance and Direction causes ArcMap 10.5.1 to crash

Trying to open the tool using the single addIn causes ArcMap 10.5.1 to crash.

@pHill5136 Can you look at this issue when you have a moment?

Working for me with latest build.

Just installed 10.5.1 and MT build 1611.  Clicking DD button to bring up the pane causes ArcMap to crash.

The crash does not seem to be happening within the single DD component.

I have the same issue on 10.3.1 when trying to access the Distance and Direction component installing Military Tools. I am using build 1611 as well.

Seen in 10.5 as well.

@NatalieCampos safe to assume issue exists in 10.3.1?

@kgonzago ..yes safe to assume as @topowright see it in 10.3.1

Oops didn't see @topowright's comment.

I only get the crash when installing from the addin on jenkins. If I build the addin manually I don't see it.

@NatalieCampos will continue to test previous builds to determine when the crash was introduced. Possibly just an issue with the single add-in.

Build 1591 - does not cause crash.
Build 1592 - does cause crash.
@kgonzago @pHill5136 @lfunkhouser @nfeuerstein

@lfunkhouser @nfeuerstein @NatalieCampos @dfoll
@kgonzago is looking into the jenkins build with this. Our testing has pointed to a likely jenkins related issue.
fwiw: I noticed that the addin size of the good (built manually) addin is slightly larger than the addin on jenkins (one that crashes dd).

Build 1614 @10:36 does not cause a crash

with MTA build 1614 I no longer have this crash with AM10.3.1


Consumable - Documentation Update

Update the documentation for prebid and prebid-server to add the additional bid parameters for app and ctv traffic.  Give more detailed examples and documentation
🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[x ] new feature
[x ] text edit only (wording, typos)
[ ] bugfix (code examples)
[x ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked
[x] https://github.com/prebid/prebid-server/pull/3338

Its been a week with no movement on getting this merged in.  Is there an issue with the documentaiton?


tests test_backup and test_secondary hangs on many non-amd64 archs

Building v0.4.0-alpha.7 on Debian build-daemons fails the testsuite on amd64 architecture:
     Running `CARGO=/usr/bin/cargo CARGO_MANIFEST_DIR='/<<PKGBUILDDIR>>/lib/oxigraph' CARGO_PKG_AUTHORS='Tpt<EMAIL_ADDRESS>CARGO_PKG_DESCRIPTION='a SPARQL database and RDF toolkit
' CARGO_PKG_HOMEPAGE='https://oxigraph.org/' CARGO_PKG_LICENSE='MIT OR Apache-2.0' CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=oxigraph CARGO_PKG_README=README.md CARGO_PKG_REPOSITORY='https://github.com/oxigraph/oxigraph/tree/main/lib/oxigraph' CARGO_PKG_RUST_VERSION=1.70 CARGO_PKG_VERSION=0.4.0-alpha.7 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=4 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE=alpha.7 LD_LIBRARY_PATH='/<<PKGBUILDDIR>>/target/aarch64-unknown-linux-gnu/release/build/oxrocksdb-sys-e1b09f1ba1e679da/out:/<<PKGBUILDDIR>>/target/aarch64-unknown-linux-gnu/release/deps:/<<PKGBUILDDIR>>/target/aarch64-unknown-linux-gnu/release:/usr/lib/rustlib/aarch64-unknown-linux-gnu/lib' /<<PKGBUILDDIR>>/target/aarch64-unknown-linux-gnu/release/deps/store-8d157228edb37d15 --skip test_backward_compatibility`

running 24 tests
test test_backup_on_in_memory ... ok
test test_bulk_load_dataset ... ok
test test_bulk_load_empty ... ok
test test_bulk_load_graph ... ok
test test_bulk_load_graph_lenient ... ok
test test_bad_stt_open ... ok
test test_bulk_load_on_existing_delete_overrides_the_delete ... ok
test test_bad_backup ... ok
test test_dump_dataset ... ok
test test_dump_graph ... ok
test test_load_dataset ... ok
test test_load_graph ... ok
test test_load_graph_generates_new_blank_nodes ... ok
test test_bulk_load_graph_on_disk ... ok
test test_open_bad_dir ... ok
test test_open_read_only_bad_dir ... ok
test test_open_secondary_bad_dir ... ok
test test_load_graph_on_disk ... ok
test test_bulk_load_on_existing_delete_overrides_the_delete_on_disk ... ok
test test_snapshot_isolation_iterator ... ok
test test_snapshot_isolation_iterator_on_disk ... ok
test test_read_only ... ok
test test_backup has been running for over 60 seconds
test test_secondary has been running for over 60 seconds
E: Build killed with signal TERM after 150 minutes of inactivity

It might be relevant to note that Debian build-daemons are configured to block network access, to ensure a stable build invironment.
If those tests require network access to work, I suggest to mark them as ignore, and in appropricate CI environments enable them.
...or if that is deemed too cumbersome to juggle upstream, I am fine explicitly skipping those tests.

Same test failure occurs on several architectures: arm64 armhf i386 mips64el ppc64el ricv64 s390x.
Full build log for arm64 is here

Thank you! By chance, are you compiling with RocksDB 9.x? If I remind correctly tests are failing with it (Oxigraph repo is still using 8.x).

Quoting Thomas Tanon (2024-07-07 13:51:57)

Thank you! By chance, are you compiling with RocksDB 9.x? If I remind correctly tests are failing with it (Oxigraph repo is still using 8.x).

Indeed, Debian packaging links against RocksDB 9.x.

I now simply skip checking those two tests, when targeted Debian that links against RocksDB 9.x.

We dropped secondary store in Oxigraph 0.4. This bug is not applicable anymore


[MOD] correct filter for active discussion table

Modification
Corrected dataview query to only show terms with tag discuss.

Great


Version 12.13.38 Is breaking execute resources in chef run

Cookbook version
12.13.38
Chef-client version
12.3.0
Platform Details
RHEL 6.8,  6.6
Scenario:
When 12.13.38 cookbook is being used we get an error on an execute block
DEBUG: Re-raising exception: NoMethodError - execute[setup password expiration for rundeck] (wdprt_sece_base::users line 21) had an error: NoMethodError: Undefined method or attribute set_cookbook_attribute' on node'
/opt/chef/embedded/apps/chef/lib/chef/node/attribute.rb:468:in method_missing'  /opt/chef/embedded/apps/chef/lib/chef/node.rb:229:in method_missing'
Steps to Reproduce:
It seems that execute block in multiple recipes in the run_list cause this error
Expected Result:
Run through to completion without errors
Actual Result:
chef-client exits out at the execute block with

execute[setup password expiration for rundeck] action run
================================================================================
Error executing action run on resource 'execute[setup password expiration for rundeck]'
NoMethodError
Undefined method or attribute set_cookbook_attribute' on node'
Cookbook Trace:
/var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/run_context.rb:165:in initialize' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:78:in run_action'
/var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in block (2 levels) in converge' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in each'
/var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in block in converge' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:105:in converge'

Running handlers:
[2016-08-25T11:32:21-04:00] ERROR: Running exception handlers
Running handlers complete
[2016-08-25T11:32:21-04:00] ERROR: Exception handlers complete
[2016-08-25T11:32:21-04:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
Chef Client failed. 4 resources updated in 5.373306389 seconds
[2016-08-25T11:32:21-04:00] ERROR: execute[setup password expiration for rundeck] had an error: NoMethodError: Undefined method or attribute set_cookbook_attribute' on node'
[2016-08-25T11:32:21-04:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
Rolling back to 12.10.7 fixes the issue.

/var/chef/cache/chef-stacktrace.out contents along with the actual code you're running would also be useful.

this is called in the initializer of the run_context, it has nothing to do with execute resources that i can see...

Here is the full stack trace
Generated at 2016-08-25 13:17:15 -0400 NoMethodError: execute[setup password expiration for rundeck] (wdprt_sece_base::users line 21) had an error: NoMethodError: Undefined method or attribute set_cookbook_attribute' on node' /opt/chef/embedded/apps/chef/lib/chef/node/attribute.rb:468:in method_missing'
/opt/chef/embedded/apps/chef/lib/chef/node.rb:229:in method_missing' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/run_context.rb:165:in initialize'
/opt/chef/embedded/apps/chef/lib/chef/guard_interpreter/resource_guard_interpreter.rb:96:in new' /opt/chef/embedded/apps/chef/lib/chef/guard_interpreter/resource_guard_interpreter.rb:96:in get_interpreter_resource'
/opt/chef/embedded/apps/chef/lib/chef/guard_interpreter/resource_guard_interpreter.rb:28:in initialize' /opt/chef/embedded/apps/chef/lib/chef/guard_interpreter.rb:28:in new'
/opt/chef/embedded/apps/chef/lib/chef/guard_interpreter.rb:28:in for_resource' /opt/chef/embedded/apps/chef/lib/chef/resource/conditional.rb:59:in configure'
/opt/chef/embedded/apps/chef/lib/chef/resource/conditional.rb:82:in continue?' /opt/chef/embedded/apps/chef/lib/chef/resource.rb:1074:in block in should_skip?'
/opt/chef/embedded/apps/chef/lib/chef/resource.rb:1073:in each' /opt/chef/embedded/apps/chef/lib/chef/resource.rb:1073:in find'
/opt/chef/embedded/apps/chef/lib/chef/resource.rb:1073:in should_skip?' /opt/chef/embedded/apps/chef/lib/chef/resource.rb:561:in run_action'
/var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:78:in run_action' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in block (2 levels) in converge'
/var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in each' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in block in converge'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/resource_list.rb:83:in block in execute_each_resource' /opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in call'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:116:in call_iterator_block' /opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:85:in step'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:104:in iterate' /opt/chef/embedded/apps/chef/lib/chef/resource_collection/stepable_iterator.rb:55:in each_with_index'
/opt/chef/embedded/apps/chef/lib/chef/resource_collection/resource_list.rb:81:in execute_each_resource' /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:105:in converge'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:339:in block in converge' /opt/chef/embedded/apps/chef/lib/chef/client.rb:334:in catch'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:334:in converge' /opt/chef/embedded/apps/chef/lib/chef/client.rb:353:in converge_and_save'
/opt/chef/embedded/apps/chef/lib/chef/client.rb:457:in run' /opt/chef/embedded/apps/chef/lib/chef/application.rb:271:in block in fork_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:259:in fork' /opt/chef/embedded/apps/chef/lib/chef/application.rb:259:in fork_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:225:in block in run_chef_client' /opt/chef/embedded/apps/chef/lib/chef/local_mode.rb:39:in with_server_connectivity'
/opt/chef/embedded/apps/chef/lib/chef/application.rb:213:in run_chef_client' /opt/chef/embedded/apps/chef/lib/chef/application/client.rb:402:in block in interval_run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application/client.rb:392:in loop' /opt/chef/embedded/apps/chef/lib/chef/application/client.rb:392:in interval_run_chef_client'
/opt/chef/embedded/apps/chef/lib/chef/application/client.rb:382:in run_application' /opt/chef/embedded/apps/chef/lib/chef/application.rb:60:in run'
/opt/chef/embedded/apps/chef/bin/chef-client:26:in <top (required)>' /usr/bin/chef-client:51:in load'
/usr/bin/chef-client:51:in <main>'

TIL the guard interpreter stuff creates its own run_context.  So this most likely happens with an execute resource, with a guard.  Although it should also happen with any sub-run-context created by a use_inline_resources style provider as well...

The one we have does have a guard.
     21: execute 'setup password expiration for rundeck' do      22:   command 'chage -I -1 -m 0 -M 90 -E -1 rundeck'      23:   action :run      24:   not_if 'chage -l rundeck | grep 90'      25: end      26:


Fix AWS S3 related issues.

I had 2 troubles when running Koel with the official Koel-AWS package

MySQL Error: "Integrity constraint violation - Column 'lyrics' cannot be null" when AWS Lambda function request to Koel's Song API. (Environment: MySQL v5.5.47 & PHP v7.1)

Similar to this issue.

After storing a new songs, the song, album and artist didn't show up in Koel UI, because media cache remains.

Thanks!

@phanan Are you going to bump release version to v3.7.3 with this fix?


Fixes 4281: remove 8-stream from public repos

Summary
and make repos removed from the external_repos.json file no longer public
Testing steps

on main run make repos-import
connect to the db and query 8-stream public repos:

make db-cli-connect
# select public, url from repositories  where url ilike '%8-stream%';

Check out this PR, re-run make repos-import
re-query the query and make sure the 8-stream repos are no longer public
query the 9-stream repos and make sure they are still public

# select public, url from repositories  where url ilike '%9-stream%';

Checklist

[ ] Tested with snapshotting feature disabled and pulp server URL not configured if appropriate

https://issues.redhat.com/browse/HMS-4281

/retest

QE ACK, tested OK


[Api.ai] sessionId parameter

Keep continue the Api.ai course of conversation using the sessionId parameter

Guess the error occurs because of the driver method getName you are calling now that wasn't there before and this method call wasn't expected.

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage     86.02%   86.02%
  Complexity      593      593
=========================================
  Files            50       50
  Lines          1789     1789
=========================================
  Hits           1539     1539
  Misses          250      250

Impacted Files
Coverage Δ
Complexity Δ

src/Mpociot/BotMan/Middleware/ApiAi.php
96.87% <100%> (ø)
10 <ø> (ø)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9291cb6...af9e4a2. Read the comment docs.

Thanks @christophrumpel! I realized that there is an existing function getOriginatedConversationIdentifier I used this to keep the user in the conversation flow.

Thank you!


Call composite closes but call is still ongoing

Describe the bug
I am using this library inside React Native, and am seeing an issue with the CallComposite.dismiss() function. I have a push notification that, when received, calls dismiss() but when the app is in the background and moved to foreground by pressing the notification, the composite is dismissed, but the android os still says the call is active. I believe this is due to having two activities open, but was wondering if there could be someway to completely kill the call. I did some digging and found CallingAction.CallEndRequested() in the exit() function. Maybe a boolean to pass that kills the call? I can work on the fix if there is some guidance on the best course of action.
To Reproduce
Steps to reproduce the behavior:

With two activities open, and acs being the one on top, make the launch() call from the bottom activity and add a timer that x seconds after launching the composite, dismiss() is called
Send app to background (not killed)
Open app: The composite will close but the os will show that the call is still ongoing
This bug is [always] reproducible.

Expected behavior
A clear and concise description of what you expected to happen.
The composite is closed and the os does not say the call is ongoing
Screenshots

AzureCommunicationUILibrary (please complete the following information):

Version [1.4.0]

Smartphone (please complete the following information):

Device: [Pixel 4a]
API: [33]

Hi @cheymonty,
May I suggest that please feel free to use our latest released publicly available version 1.6.1 of AzureCommunicationUILibrary.
We could not reproduce the reported issue on our latest released version.
Thank you.


Bug in orderby when written different ways

As far as i understand, both should return the same ordered result, but the bottom one does nothing.
Version: js-data 1.5.8  + js-data-angular 2.2.3
From Docs: http://www.js-data.io/v1.5.2/docs/query-syntax#sorting-sortorderby
Works:
Image.bindAll({
	orderBy: [
		['sort_order', 'DESC']
	]
}, $scope, 'images');

Doesn't Work:
Image.bindAll({
	orderBy: ['sort_order', 'DESC']
}, $scope, 'images');

Image.bindAll({
	orderBy: ['sort_order', 'DESC']
}, $scope, 'images');

will be rewritten to
Image.bindAll({
  orderBy: [
    ['sort_order', 'ASC'],
    ['DESC', 'ASC']
  ]
}, $scope, 'images');

The shorthands only work when sorting in ascending order.

Thanks, looks like the docs need to be tweaked, because this is what it says.
// Sorts users by age in descending order
User.filter({
  orderBy: ['age', 'DESC']
});

http://www.js-data.io/v1.5.2/docs/query-syntax#sorting-sortorderby

Fixed thanks.


Wrong logo

Hi, it looks like you are using a greek helmet in place of a roman helmet for your logo. ☺
Apart that, maybe something like a styled Colosseum illustration could fit the project better since, first of all it is more iconic for Rome, and, finally, it's related to a "building" tool and it could be a good reference for a solid building.

There's a place where this is discussed over here

From the README:

Rome has a logo of an ancient Greek spartan helmet. It's not very relevant since it's not Roman, but it looks cooler than a Galea.


composite example broken

$ ./scripts/tilestache-server.py --config examples/composite/composite.cfg
Traceback (most recent call last):
  File "./scripts/tilestache-server.py", line 55, in <module>
    app = TileStache.WSGITileServer(config=options.file, autoreload=True)
  File "/Users/dane/projects/TileStache/TileStache/__init__.py", line 297, in __init__
    raise Core.KnownUnknown("Error loading Tilestache config file:\n%s" % str(e))
TileStache.Core.KnownUnknown: Error loading Tilestache config file:
[Errno 2] No such file or directory: u'file:///Users/dane/projects/TileStache/examples/composite/composite-stack.xml'

The appears to happen because 'file:///foo' is passed to open() inside of expatbuilder.parse(file) which fails.
>>> file = 'file:///Users/dane/projects/TileStache/examples/composite/composite-stack.xml'
>>> open(file,'rb')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
IOError: [Errno 2] No such file or directory: 'file:///Users/dane/projects/TileStache/examples/composite/composite-stack.xml'
>>> file = '/Users/dane/projects/TileStache/examples/composite/composite-stack.xml'
>>> open(file,'rb')
<open file '/Users/dane/projects/TileStache/examples/composite/composite-stack.xml', mode 'rb' at 0x108925420>

Since it appears that stackfile is deprecated I tried to look at converting the file to json but I have no idea how to do that.

Good idea, this module has seen a lot of work since I wrote the example.


3.0.0 not tagged?

Hi @solarkennedy
Puppetforge has version 3.0.0 but there is no tag 3.0.0 to (easily) identify what it is here.
Steve.

whoops, I made this release manually and didn't add --tags when I git pushed. It is there now.

Merci @solarkennedy


[gitlab] contaiener_deploy: fix missing targets

What does this PR do?
Follow up to #30641 - missed setting the targets for public facing images for RC and final builds.
Missed this in the branch testing somehow.
Motivation
Need the additional images to get the OTel beta closer to the standard release workflow.
Describe how to test/QA your changes
Next RC build will help validate the fixes.
Possible Drawbacks / Trade-offs
Additional Notes

/merge


⚠ Bofrost.at has degraded performance

In c969897, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 892 ms

Resolved: Bofrost.at performance has improved in dcdd48c.


test: add tests for addTrack

adds tests for addTrack which were promised during the review of #559
@henbos PTAL, do you want more tests?
@jan-ivar looks like you throw InvalidParameterError instead. Filed a bug for you. We can soon mark that test as expected failure

squash and we're good? Need to add expectations for #609

@jan-ivar looks like you throw InvalidParameterError instead. Filed a bug for you. We can soon mark that test as expected failure

@fippo Thanks! BTW, shouldn't this be a WPT test as well?

made a minor change to the chrome shim to make this not work:
pc.addTrack(stream.getTracks()[0], stream);
pc.addStream(stream)

moar tests ;-)


[docker] mountaindude/butler-sos:5.0.0 not found

Hi there,
First of all, this is a great tool, thank you for sharing !
Just for you to know, currently there is no 5.0.0 tag available on your docker image as stated in the doc, only tags 5.0.0RC1 and 5.0.0RC2.
Thanks
Best regards,

SORRY my bad, it's now ptarmiganlabs/butler-sos
Thanks!

Ok good that you found it.
I check just now, and
https://butler-sos.ptarmiganlabs.com/docs/getting_started/choose_platform/ does
link to the correct Docker Hub page.
/Göran
On Mon, 21 Oct 2019 at 10:59, Tehes<EMAIL_ADDRESS>wrote:

SORRY my bad, it's now ptarmiganlabs/butler-sos
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ptarmiganlabs/butler-sos/issues/72?email_source=notifications&email_token=AAH3JDVTGDMCAQK3OUSLNMTQPVVN3A5CNFSM4JC2H2W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBZSZ2I#issuecomment-544419049,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH3JDVKO3SKCVBS5ACC2CDQPVVN3ANCNFSM4JC2H2WQ
.


⭐ Ideas to explore

Just noting the ideas to explore... feel free to contribute your ideas here:

executable code in rectangles (see org-babel, jupyter for inspiration)
org-mode, markdown support in rectangles
connection between documents and meta view of connected documents (see org-roam for inspiration)
collaborative editing (use bevy_matchbox)
code based drawing (see plantuml for inspiration)
ChatGPT assistance

Aggregation and tiling of sticky notes
The same set of notes can be accessed under different tabs

Aggregation and tiling of sticky notes
The same set of notes can be accessed under different tabs

Could you expand on your points? I don't understand the use cases. Feel free to join discord server (link in readme) if you want to chat about it.

I've created separate issues for ideas I'd like to explore, closing this issue for now.


'User' object has no attribute 'is_verified'

Current Behavior
Whenever the user login and try to activate his TOTP, the message pops:
AttributeError at /account/two_factor/setup/complete/  'User' object has no attribute 'is_verified'
Your Environment

Browser and version:
Python version: 3.6
Django version: 3.0.4
django-two-factor-auth version: 1.7.0

Do you have django_otp.middleware.OTPMiddleware in MIDDLEWARE?

Also do you really have 1.7.0 installed? That's quite old and I doubt it works properly with Django 3.0

Here is my middleware:
`
MIDDLEWARE = [
'django.middleware.security.SecurityMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django_otp.middleware.OTPMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
]
Sorry my django-two-factor-auth is at v. 1.11.0
Thanks in advance.
`

You have AuthenticationMiddleware listed several times. Remove all but the first one and your issue should be fixed.

That solved my problem. Thanks alot.


Setup design

Çompleted

Completed https://dribbble.com/shots/24288527-SupaChange-Exchange-Currency-Mobile-App


Ic solutions info theory 1

 IC Solutions SL - Sheet 5

PDFs added
Solved the typos
Instead of adding a theta, I added something different after the sum, please take a look at that and let me know your opinion.

I moved the Entropy exercise to the second IC exercise sheet of Info Theory
I added the KL divergence exercise to the first IC exercise sheet and uploaded a draft for the solution.


Add ability to disable the message of death.

Add ability to disable the message of death.
And according to the configuration file: DeathMessages = true/false.

This should be event + plugin

Okay.So make a plugin.


CAMEL-15260 - opentracing: fixes header extraction regression

This fixes a regression introduced with https://github.com/apache/camel/pull/4001 spotted by @valdar here https://github.com/apache/camel/pull/4001#issuecomment-662892861
This change makes the tracer fall back to camel's header extract adapter when a span is not found for the exchange. That's a span that would be there when utilizing instrumentation. So this would work with instrumentation, or without as it worked before the regression. It also introduces an integration test to prevent issues in the future.
@valdar let me know if this satisfies the issue for you and I'll mark the PR as ready.

What's the process @oscerd ? Do I point to master and then you'd merge down into 3.4, or should I point to 3.4.x?

You can open a pr against 3.4.x too, or if you don't have time, I'll backport myself

Hi @jam01 thanks a lot for the effort and the quick response. I was reasoning about your assumptions/conditions:

Camel should only attempt to read from the incoming headers when there's not already an active span for that exchange. This is in case instrumentation already extracted the parent from the headers. Activating the span for the exchange in instrumentation is the part I'm still working on.

Only read headers for components that are not internal (seda, direct, vm, etc).

Only add the Server tag when.... the component is not internal and no span is active for the exchange. Whether we found a parent in the headers or not.

While I understand the principle behind, is the #2 really necessary? I have a real use-case coming from a camel subproject: camel-kafka-connectr where Kafka Connect api and camel are interfaced using exactly direct endpoints as the route starter. So the uber-trace-id is coming from the kafka message consumed by Kafka connect api and passed to camel-kafka-connector. Then camel-kafka-connector crafts an exchange coping the uber-trace-id in the proper header and finally sending it to the direct endpoint using a producerTemplate.
At the end of the day if the exchange is initiated in another route it should already have an active span right?
There would be another way to handle this and still comply to your conditions?

Ah I see. So in this case you want the kafka-connector to just fwd over the headers. Acting sort of as a non-trace-participant proxy. You don't care about capturing kafka specific tags like in KafkaSpanDecorator. Your trace would be something like:
[--------------------- trace --------------------------------------]
[-- kafka outbound span --] possibly kafka outbound tags
                                       [--- camel:direct -------] server tag, camel-direct decorator tags

instead of
[--------------------- trace --------------------------------------]
[-- kafka outbound span --] possibly kafka outbound tags
                            [--- camel-kafka inbound span---------] server tag, camel-kafka decorator tags
                                      [--- camel:direct --------] camel-direct decorator tags

I hadn't thought of a scenario like this. I thought of it as an user error to receive an out-of-process request and not:

Extract the parent context
Create a new Span before as its child
Call ActiveSpanManager#activate before using a producer termplate.

but that doesn't take into consideration libraries like kafka-connector :astonished: where you may not be ready to depend on a Tracing API yet. I also didn't know there were camel "components" that were not Endpoints so I didn't consider that.
So that said, I think I'll go ahead and allow internal endpoints to also extract from the headers. Perhaps it's worth noting in the docs that for application developers it is an error not to do the process above when using producer templates.
A little unrelated... Is the connector looking for uber-trace-id specifically? If so it wouldn't support tracers different than Jaeger when using default context propagation. I think the only way to do that "correctly" without relying on opentracing or opentelemetry is to use the standardized W3C header names (proxying like this is a driving force behind the standard), or make the headers to fwd configurable so library users could use any tracer implementation.

@jam01 I will try to answer:
camel-kafka is the camel component that connects to a Kafka broker. camel-kafka-connector is a camel subproject that makes easy to use camel components as Kafka Connect connectors.
The connector is not looking for "uber-tracer-id" it is using the tracer mechanism trough the .extract() method. This has a specific implementation for each tracer, the Jaeger tracer looks for that header, others might look for different ones.
I understand that I can actually do the steps you mentioned BEFORE using the producer template, I was trying to reason about what we get and loose by doing them regardless. I see 3 possible scenarios:

the exchange coming to an internal endpoint has already an active span/context registered in the exchange property (i.e. it is coming from an internal camel routing call and somewhere else during the camel routing a tracing span/context has been activated)

the exchange coming in has no span activated but the tracer.extract() return a context to use (i.e. someone has used a producer template setting the right headers for this to happen)

the exchange coming has no span activated and tracer.extract() does not return a tracing context (i.e. someone has used a producer template without passing a tracing context)

1 is what you handle right now, if we are not in this case then we can fall back to  2 and then 3. In the case of 3, we can either start a new trace or ignore for tracing (I would vote for starting a new trace).
I might miss something but I don't see what we lose or have not considered in acting this way.

Gotcha. Thanks for the explanation. With my last commit we'd support 1 -> 2 -> 3 :)
So it'd support whichever approach you decide to take as far as activating the exchage property before executing the producer template or not.
What you gain when activating it is that you can add the metadata that won't be available to camel since there's no Kakfa endpoint/kafka decorator involved. Also an extra kafka-connector Span which may or may not be critical if the connector doesn't take long before fwding to camel.
What you lose... yeah if you already depend on opentracing to extract the context I can't think of anything you'd lose from activating a Span. Unless you wanted to hide kafka-connector from traces.

@jam01 Let's forget for a minute about my use-case and reason more generally about tracing support in camel. Do you see any problems or missing cases in taking this approach?

Hmm you know I think there is one minor change I'd like to propose/reintroduce. In scenario 3, do create a Span but only add a server tag if it's not an internal endpoint.
With scenario 2 someone was deliberate enough to fwd the headers, so it feels ok to assume they want camel to appear as the inter process handler.
With scenario 3, we can't make the same assumption. I imagine a scenario where an application dev is using any non-camel http server, has a server Span created but forgets to activate it on the exchange before delegating to camel for a response. We'll end up with 2 independent traces regardless, but if we add a server tag then we have 2 server spans for what's really a single service execution.

A TracedProducerTemplate would be good. It could grab whatever is the active Span at time of execution and activate it on the exchange.

Oh more appropriate use cases for skipping the server tag with internal endpoints:

Quartz or other scheduled job that delegates to camel
Any application with an in-process interface that delegates to camel ie. a desktop app, command line app

@valdar what do you think? I'll mark the PR as ready, unless you still have reservations.

@rubenvp8510 so this became a little more complicated to merge. I think in order to have the functionality be the same between camel-otel and camel-otracing in the way that camel-tracing handles things we'll need to introduce a ContextAdapter which may not be trivial. I haven't looked at how otel implements theirs...
Or just have each implementation do the same operations on their own, should be a minor duplication.
cc: @oscerd

OK, I've rebased and setup opentracing to extract the headers correctly, however I can't seem to figure out how to extract an otel SpanContext from the headers...
Following what OpenTelemetryTracer#inject does I tried to do
OpenTelemetry.getPropagators().getHttpTextFormat().extract(Context.current(), sd.getExtractAdapter(exchange.getIn().getHeaders(), encoding), new OpenTelemetryGetter());

but that returns a Context and Span.Builder#setParent(io.opentelemetry.trace.SpanContext) visibly expects a SpanContext
I'll dig down a little more and see if I can figure this out... but not finding a way so far.

Figured it out... should be good to go! All opentelemetry and opentracing tests are passing

I guess this will need to be backports to 3.4.x too for the regression, but we don't have camel-tracing common module there @jam01

I have the original work saved up. If/when you merge this one I'll open a PR to 3.4.x

Merged @jam01

OK I'm on it ...

oh it seems we're also missing https://github.com/apache/camel/pull/3919 and https://github.com/apache/camel/pull/4001 so the functionality in 3.4.x is as it was originally. Would you like me to send a PR that includes all changes?

If the regression reported from @valdar apply in 3.4.x I believe we need to backport whatever is needed to fix it, but if it's a complex situation or the behavior will change completely, then I don't think it's a good idea, we need to fix the specific case of the regression. @davsclaus FYI

It does not apply, the regression never made it to 3.4.x. Just the behavior in 3.4.x will be different than 3.5

Sorry, I'm having some confusion, from what I understood @valdar had some trouble with 3.4.x, so I thought it was related

Oh you're right... I was under the same impression. But my changes never made it to https://github.com/apache/camel/commits/camel-3.4.x/components/camel-opentracing/src/main/java/org/apache/camel/opentracing/OpenTracingTracer.java I guess valdar just noticed the problem when building against 3.5 or just happened to notice the PR


Remove composer installers

According to the new logic introduced in cakephp/cakephp#5641 the vendor plugins should be installed into the vendor folder and they will be automatically linked with the CakePHP. The plugins folder should be used for internall app plugins only.
The composer/installers also needs to be updated, but maybe it will be not possible, since the "type": "cakephp-plugin" in composer.json is also used for 2.x and 3.x plugins and the new logic with the vendor folder is only in 3.x.
But not requiring the composer/installers will do the trick. Otherwise it installs all the plugins to the plugins folder instead of vendor folder.

Hello,
I get this error when I do a Composer update;
Loading composer repositories with package information
Updating dependencies (including require-dev)

Installing codaxis/cakephp-bootstrap3-helpers (dev-master b5a1184)
Cloning b5a11843b7b701a442029c0c231e726469aab32c

[RuntimeException]
Unable to get primary namespace for package codaxis/cakephp-bootstrap3-helpers.
Ensure you have added proper 'autoload' section to your plugin's config as stated in README on https://github.com/cakephp/plugin-installer
I think that this pull request will correct the problem.

Why not remove the entire require section, instead of leaving it empty?

@ceeram You are correct, I removed it

I am not a pro about composer and I don't have time to check it right now so I will trust you on this one. Thanks for the update.

I still have the same error, I'll look where it comes from and whether I would need a pull-request

OK I foud the problem... My bad...

@Holt59 There is a comment by the author of CakePHP, Mark Story, saying that the plugins should not require the composer installer now.

@Laykou I just created a new CakePHP application using the latest composer and then add my plugin using composer and everything looks ok, so thanks again for the update!

./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)

Installing holt59/cakephp3-bootstrap3-helpers (dev-master 1ea67d2)
Cloning 1ea67d24cbac1febce160dd09348b8cbec2a7052
Failed to download holt59/cakephp3-bootstrap3-helpers from source: Failed to
clone git@github.com:Holt59/cakephp3-bootstrap3-helpers.git, git was not found,
check that it is installed and in your PATH env.

'git' is not recognized as an internal or external command,
operable program or batch file.
Now trying to download from dist

Installing holt59/cakephp3-bootstrap3-helpers (dev-master 1ea67d2)
Loading from cache

@kibriame how does that relate to this issue?

Sorry missing first line. Here it is :
D:\xampp\htdocs\techstunes1>composer require holt59/cakephp3-bootstrap3-helpers:
dev-master
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)

Installing holt59/cakephp3-bootstrap3-helpers (dev-master 1ea67d2)
Cloning 1ea67d24cbac1febce160dd09348b8cbec2a7052
Failed to download holt59/cakephp3-bootstrap3-helpers from source: Failed to
clone git@github.com:Holt59/cakephp3-bootstrap3-helpers.git, git was not found,
check that it is installed and in your PATH env.

'git' is not recognized as an internal or external command,
operable program or batch file.
Now trying to download from dist

Installing holt59/cakephp3-bootstrap3-helpers (dev-master 1ea67d2)
Loading from cache

Generating autoload files

@kibriame The point is that your issue has probably nothing to do with this #10 pull request.
You should probably open a new issue. And you should also ask what is the problem actually? You just copy-pasted some output from the console. But yeah, it is obvious that you do not have installed git. http://git-scm.com/download/win and make sure you add git folder to your system PATH. Because as you can see the git command was not found globally.

Thanks for your quick response. Now it works.


some tips

一些提示：
1.确保电脑有蓝牙功能，否则无法使用
2.尽量使用英伟达显卡，cpu处理图像过慢且卡顿
3.不要大力拆卸模块，针脚比较脆弱
4.使用Arduino IDE可以查看硬件情况
5.IDE中开发板的版本为2.0.17
Some tips:
1.Make sure your computer has Bluetooth functionality; otherwise, it cannot be used.
2.Try to use NVIDIA graphics cards, as the CPU is too slow and laggy for image processing.
3.Do not forcefully disassemble the modules, as the pins are quite fragile.
4.Using the Arduino IDE allows you to check the hardware status.
5.The version of the development board in the IDE is 2.0.17.
把针脚弄坏了，在ide串口监视器里可以查看设备初始化状态显示摄像头错误

Windows有什么特别注意的吗，characteristicvaluechanged这个回调不触发


Fix text in image accessiblity in Bootstrap grid challenge

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #10968

Description

As discussed in #10968, there is an accessibility issue in the challenge "Use the Bootstrap Grid to Put Elements Side By Side". This pull request fixes that issue by linking to the page that is the source of the image, instead of the original image. Screen readers will be able to read out the content.
Happy coding!

Thanks for the PR! Would you mind making this change in the translated versions as well?

Oops, sorry about that @ltegman! I just updated it. I left the title of the image the same in French. I don't know enough French to change it. Technically it still enlarges what you see in the image when you click on it, so I don't think it's that big of a deal. The Spanish translation already had the title in English, so I updated that to the new English title.

Perfect -- thank you! :tada:

@systimotic @ltegman not to be picky, but I think we should try to fix the translations while this was open. I also think the English text might be better as below:
English: "Click to view the Bootstrap grid documentation"
Spanish: "Haga clic para ver la documentación rejilla Bootstrap"
French: "Cliquez pour voir la documentation de la grille Bootstrap"
Now that it's merged, I'm not sure how hard it is to re-open so w/e.

Sorry for taking so long to get back. @dhcodes Are these translations verified? As a non-native English speaker, I often prefer no translation over a poor translation 😅 In reality, by now I always prefer English over Dutch (my native language), but in that case I'm an exception. I'd be happy to submit a new PR with the fixed translations if we're sure they're correct.

Yeah, I verified with native speakers in the Gitter chat @systimotic

Great! New PR incoming...


Q: include files in themes?

Is there a way to put include files in themes, e.g., lib/whatever/inc? I have several snippets that are shared between templates, and including them in the template directory rather that in the root inc directory seems more portable. thx - Greg

Hi Greg. I'm not sure I understand the use case -- could you give me an example?

I am trying to build a theme that I can use across several sites. I can do what I want with template inheritance, but it feels very contrived: it would be a lot easier to have:
<!DOCTYPE html lang="en">
<html>
  <head>
    {% include mathjax %}
    {% include plausible %}
    ...template-specific stuff...
  </head>
  ...

in several places - putting those files in the inc directory of the project rather than in lib/whatever/inc feels leaky.

You should be able to put files like that directly into the theme's templates directory -- that's where Jinja and Ibis are configured to look for files included using the {% include %} tag.

Thanks, that seems to work.

Excellent. I've updated the documentation to hopefully make that clearer for future users.


'route' watch triggered after 'created' hook

Using 'parentsList' for dynamic breadcrumbs '$route' watch is triggered after 'breadcrumbChanged' event when navigating using router.push/router.replace. As '$route' watch clears 'parentsDynamicRoutes' therefore only current breadcrumb is generated not the full trail.

@jorups  Thank you for a report! I will try to find free time to fix it

I think that is the case when breadcrumb is a function.

The fix seems to be
replacing
  watch: {
    $route() {
      // Set empty component's 'parentsDynamicRoutes' property on each route change
      this.parentsDynamicRoutes = [];
    },
  },

with
  beforeRouteUpdate() {
    // Set empty component's 'parentsDynamicRoutes' property on each route change
    this.parentsDynamicRoutes = [];
  },

Or removing that completely.
Also hot reload empties that list.

I get the same behaviour, was there a fix for this?

@rosshulford No, there wasn't.
Can you provide reproduction link for this issue?


feat: implement procedure annotation syntax

This commit introduces the concept of attributes/annotations to Miden Assembly procedures. These can be used to represent interesting/useful bits of metadata associated with specific procedures in three different forms:

Marker attributes, e.g. #[inline], a name with no associated data
List attributes, e.g. #[inline(always)], i.e. a parameterized marker; multiple values can be provided as comma-delimited values.
Key-value attributes, e.g. #[key = <value>], where <value> can be a "meta expression" of three possible types: identifier, string, or integer (in either decimal or hexadecimal format).

Attributes will provide the foundation for upcoming changes that will rely on being able to attach metadata to procedures. For now, attributes may only be attached to procedure definitions, not re-exports or any other syntactic construct.
NOTE: This does not yet act on any attributes, nor store them anywhere when assembling to MAST. For now, they are simply parsed, made available in the AST, and ignored. Future PRs will introduce these as needed.
Closes #1434

Also, I'm trying to think through the syntax choice #[...]. On the one hand, we use # for comments and so this syntax overloads comments a bit. But on the other hand, maybe that's not a bad thing.

Hmm, now that you mention it, I'm not super excited about that either. The choice itself is a common one, but I hadn't considered the edge cases parsing-wise.
I think my preference would be to use @name, @name(args, ..), and @name(key = value) instead. That's a small change to make, and syntactically should stand out much better.

For now, attributes may only be attached to procedure definitions, not re-exports or any other syntactic construct.

This is fine for the initial PR - but we'll probably need to lift this restriction fairly soon. The reason is that when defining account code, we'd want to attach attributes to re-exports. For example, we may define a basic wallet as something like this:
export.::miden::contracts::wallets::basic::receive_asset
export.::miden::contracts::wallets::basic::create_note
export.::miden::contracts::wallets::basic::move_asset_to_note

#[storage(offset = 0, size = 1)
export.::miden::contracts::auth::basic::auth_tx_rpo_falcon512

I didn't want to deal with some of the thorny questions around re-exports and attributes and their semantics, but it sounds like we'll need to deal with it, so:

Does a re-exported procedure inherit the attributes of the original definition? One might intuitively expect "yes", with respect to things like @inline, but:
What happens when the same attribute appears on both the original definition and a re-export? For example, @inline(never) on the original, and @inline(always) on the re-export. Or to use the expected use case here, conflicting storage offsets and size. With inlining, we could ignore the conflicting re-export attribute and raise a warning, but that may not be the right approach for some attributes, especially anything that the procedure code actually relies on.
If attributes can appear on re-exports, that means we can't just treat them as simple aliases of the original procedure, they effectively become their own unique definitions. That isn't exactly accurate, but a few things fall out of that:

We need to accumulate/resolve attributes when resolving procedure paths, so that we know the precise set of attributes that should be applied at a given call site
We need to store data associated with re-exported procedures, rather than just delegating to the original definition, in the MAST/Library/etc.
It isn't clear to me whether or not attributes can have an effect on how the code of the procedure is generated. Inlining isn't too problematic here, but imagine one using attributes for decorator-like cross-cutting concerns (i.e. not our usual notion of decorators, but the more general programming concept), e.g. #[global(name = FOO, data = 0x...)] which injects code to prepare data in memory from the advice provider, and replaces any reference to a pseudo-constant FOO in the procedure with the address at which the data is placed. This would affect the contents of the procedure.

There was something else as well, but it's early in the morning and I haven't fully woken up yet, so I lost it 😅, but I'll follow up when it comes back to me.
Anyway, we might be able to come up with some partial solutions for this for specific attributes, but for generality, we'll want to make sure we think through all of the implications before we lean too far on any one solution for this.

@bobbinth I've updated the PR with some syntax changes, improved code organization, and a few ergonomics improvements as well.
As noted in my other commit (and now in the commit and docs as well), annotations now come in the following varieties:
# A marker attribute, e.g. @inline
@<name>
 # A list attribute with a single item, e.g. @inline(always)
@<name>(<expr>)
 # A list attribute with multiple comma-delimited items, e.g. @deprecated("0.1.0", "Use foo::bar instead")
@<name>(<expr0>, .., <exprN>)
# A key-value attribute, e.g. @storage(offset = 1)
@<name>(<key> = <value>)
# A key-value attribute with multiple comma-delimited items, e.g. @storage(offset = 1, size = 2)
@<name>(<key0> = <value0>, .., <keyN> = <valueN>)

Furthermore, key-value annotations can be stacked, so long as the keys are unique, e.g.
@storage(offset = 1)
@storage(size = 2)
export.get_item
  ...
end

Conflicting declarations that trigger syntax errors:

Any two non-key-value attributes with the same name
Any two attributes with the same name, but differing type
Multiple key-value attributes with duplicated keys

In the process of making these changes, I also realized my test case was not actually testing anything because I forgot to update the equality implementation for Procedure 🤦, and I had actually specified !#[...] in the grammar originally, not #![...], so those attributes were being parsed as comments anyway. In any case, I'm happier with the new syntax anyway, so that last bit is irrelevant anyway. I've verified the tests are actually working now though, so it's actually exercising all the parser rules for annotations now.


Bug fix

Thank you. Someone has already submitted a patch, so I will close this PR without merging.


remove unnecessary glamor dependency in v3 migration

A change to the migration doc because the glamor-react re-exports all of glamor, thus making an explicit dependency on glamor in a user's app's package.json unnecessary.

You're right. Thanks.


GPU requirements

What are the requirements for the GPU? In the paper the NVIDA V100 GPU is mentioned for the trainingstep but here in the comments RTX8000 48GB and GeForce 3090 are mentioned.
Also, is there any trained model for use?

Hi,

Hi, we do the search phase and training phase on SceneFlow dataset by NVIDA V100 GPU. For Middlebury, as we take the input_size of half of the original images, it needs a GPU ( RTX8000 48GB ) with a larger memory.
Please check the best models on each benchmark.


Preserve port when computing the login URL

When using a registry URL that contains a port, ensure the port is preserved when computing the login URL.
Motivation:
Currently if you run the following
swift package-registry set https://packages.example.com:8081
swift package-registry login --token XYZ

You might get something like
Error: Unable to connect to server: https://packages.example.com

That's because the login url is built like this and ignores the port: URL(string: "https://\(host)\(loginAPIPath ?? "/login")")
Modifications:

Use URLComponents to build the login URL (which maintains the port)
Add a testing target for SwiftPackageRegistryTool

Result:
SPM can use registry URLs with ports.
I do have a question though, the registry authentication configuration dingus currently uses the host as the key:
https://github.com/apple/swift-package-manager/blob/main/Sources/PackageRegistryTool/PackageRegistryTool%2BAuth.swift#L234-L237
I suspect it's pretty unlikely that someone would use multiple registries available at the same host on different ports, but should I update that, as well?

@swift-ci please test

@swift-ci please smoke test

I suspect it's pretty unlikely that someone would use multiple registries available at the same host on different ports, but should I update that, as well?

I agree that it's unlikely to have multiple registries on the same host.
If we were to support/fix this however, I don't know if using host:port instead of just host is good enough. What if instead of different ports, different paths (e.g., /staging-1, /staging-2) on the same host are used for multiple registries? Using (registry) URLs as keys could make things tricky in RegistryClient. But then I think distinguishing registries by paths is even less likely to happen than ports.
I think changing from host to host:port is pretty straight-forward--the :port portion should only be added if registryURL.port is non-nil, so I am open to us making that change. I don't think the change is a MUST though.

I think changing from host to host:port is pretty straight-forward--the :port portion should only be added if registryURL.port is non-nil, so I am open to us making that change. I don't think the change is a MUST though.

Done!

@swift-ci please smoke test

@swift-ci please test Windows platform

@swift-ci please test Windows platform

@swift-ci please smoke test

@swift-ci please test Windows platform

@swift-ci please test Windows platform

@swift-ci please test Windows platform

@Palleas This looks good to merge! Can you please create a PR for the release/5.9 branch also?

@Palleas This looks good to merge! Can you please create a PR for the release/5.9 branch also?

Here you go! https://github.com/apple/swift-package-manager/pull/6715

@Palleas Thank you!


[ownership] Enable SILMem2Reg for OSSA

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 6b3258ab08db7b4fb79ef24595d7a5e123c6a56f

@swift-ci test

@zoecarver I am going to test https://github.com/apple/swift/pull/30812 with this branch and see how it goes.

@zoecarver I am going to test #30812 with this branch and see how it goes.

Sounds good! You should make sure you can also build the stdlib with both patches applied.

@zoecarver I am going to test #30812 with this branch and see how it goes.

Sounds good! You should make sure you can also build the stdlib with both patches applied.

No new bugs with access instructions. I think its best to handle it separately from this PR.  #30812 will need some OSSA tests.

No new bugs with access instructions.

Great.

I think its best to handle it separately from this PR.

SGTM.

#30812 will need some OSSA tests.

Happy to add them. But they're useless until this patch lands (I can rebase that patch on this one for the time being).

Add a case for DestroyAddrInst to isWriteOnlyAllocation.

Looked into this. This is not okay because we just erase instructions in the case of isWriteOnlyAllocation. But a destroy_addr will need to be transformed to the destroy_val of the RunningVal

Looked into this. This is not okay because we just erase instructions in the case of isWriteOnlyAllocation. But a destroy_addr will need to be transformed to the destroy_val of the RunningVal

Fair enough.

@meg-gupta one thing that you should look into is changing all SILBuilder -> SILBuilderWithScope with this change.

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 84f17c0a1b929e99525887e17b557a8987230d4e

Build failed
Swift Test Linux Platform
Git Sha - 84f17c0a1b929e99525887e17b557a8987230d4e

Had to force push for to fix an aggressive assert. Only difference after the approval :
--- a/lib/SILOptimizer/Transforms/SILMem2Reg.cpp
+++ b/lib/SILOptimizer/Transforms/SILMem2Reg.cpp
@@ -407,7 +407,8 @@ static void replaceLoad(LoadInst *LI, SILValue val, AllocStackInst *ASI) {
   if (LI->getOwnershipQualifier() == LoadOwnershipQualifier::Copy) {
     LI->replaceAllUsesWith(builder.createCopyValue(LI->getLoc(), val));
   } else {
-    assert(val.getOwnershipKind() != ValueOwnershipKind::Guaranteed);
+    assert(!ASI->getFunction()->hasOwnership() ||
+           val.getOwnershipKind() != ValueOwnershipKind::Guaranteed);
     LI->replaceAllUsesWith(val);
   }

@swift-ci test

@swift-ci test source compatibility

I'll fix the remaining comments in a follow up PR as suggested.


Fix dragging the slider on iOS

In Safari on iOS I noticed that dragging the slider doesn't work, if the finger is moved along the track. This doesn't practically happen in your demos, as the track is very tiny, but if you increase the size for better touch support, you'll see this issue. Another issue is, that while dragging the slider, the page will scroll with the finger.
Broken demo (maybe you have to download the video to be able to watch it).
A call to preventDefault() in the touchstart handler fixes this issue. However, React attaches the event handler as passive and currently doesn't offer an API for opting into active mode. Therefore we need to handle the handler registration ourselves.
Now everything works as expected: Working demo
Would be great if we could get this merged and released in the near future 🙂

I've been having this problem for a while and this fix LGTM 👍

Ping @davidchin 🙂

I need this too!

Thx for fixing!

:clap: please merge @davidchin :clap:

I've published a fork in the meantime in case someone needs an urgent fix: react-input-range-ios-fix

@amannn Just gave you package a try. I still seem to be missing dragging on my iphone 8+

Ah, yes that's correct. I've seen that the component has a draggableTrack config option, but I've personally never used that so I can't really tell how that works – sorry.

Thanks for the fix!
@davidchin could you merge this PR

Ping @davidchin

Hey @davidchin, sorry for bothering you again. Would be really helpful if you could have a loot at this / merge it, as other people seem to experience the issue as well.


[NNPA] Turn a broadcasting BinaryOp whose one of the inputs is a constant into a non-broadcasting BinaryOp

In the bertsquad model, there are many broadcasting BinaryOp(s) whose one of its inputs is a constant, e.g.
%0 = "onnx.Constant"() {value = dense<1.0> : tensor<768xf32>} : () -> tensor<768xf32>
%1 = "onnx.Mul"(%arg0, %189) : (tensor<256x768xf32>, tensor<768xf32>) -> tensor<256x768xf32>

Since NNPA does not support broadcasting, these ops will not be executed on NNPA. To overcome this, we expand the constant to have the same shape as the other input, so that there is no broadcasting and the op can be run on NNPA. The above onnx.Mul will become:
%0 = "onnx.Constant"() {value = dense<1.000000e+00> : tensor<768xf32>} : () -> tensor<768xf32>
%1 = "onnx.Shape"(%arg0) : (tensor<256x768xf32>) -> tensor<2xi64>
%2 = "onnx.Expand"(%0, %1) : (tensor<768xf32>, tensor<2xi64>) -> tensor<256x768xf32>
%3 = "onnx.Add"(%arg0, %2) : (tensor<256x768xf32>, tensor<256x768xf32>) -> tensor<256x768xf32>

With --canonicalize --constprop-onnx, we get:
%0 = "onnx.Constant"() {value = dense<1.000000e+00> : tensor<256x768xf32>} : () -> tensor<256x768xf32>
%1 = "onnx.Add"(%arg0, %0) : (tensor<256x768xf32>, tensor<256x768xf32>) -> tensor<256x768xf32>

Jenkins Linux s390x Build #6937 [push] [NNPA] Turn a broadcasti... started at 22:55

Jenkins Linux amd64 Build #6922 [push] [NNPA] Turn a broadcasti... started at 21:55

Jenkins Linux ppc64le Build #6030 [push] [NNPA] Turn a broadcasti... started at 22:56

Jenkins Linux amd64 Build #6922 [push] [NNPA] Turn a broadcasti... failed after 17 min

Jenkins Linux s390x Build #6937 [push] [NNPA] Turn a broadcasti... passed after 1 hr 28 min

Jenkins Linux ppc64le Build #6030 [push] [NNPA] Turn a broadcasti... passed after 1 hr 34 min


Create new entity over existing entity

If you create a new custom entity with the exact same name as an existing one it updates and the schema status is set to "New".
Weird behaviour? Should maybe give error "Entity already exists" or similar?

Was fixed long ago.


pass file list data through json encoder

The claim objects in the response from file_list are missing some fields like permanent_url. Jack says this is prolly a bug with the Claim json encoder.
claim_address and permanent_url are inconsistent in claim subfield of file vs claim results.

The goal is to have the output of file_list and claim_list consistent on claim fields (file is associated to a claim so it needs to show the claim information as expected from other claim commands)

fixed in #2447


545-Replace req user with req userEntity in the user.controller.ts

Issue link / number:
https://github.com/chaynHQ/bloom-backend/issues/545
What changes did you make?
Replace req["user"] with req["userEntity"] in the user.controller.ts
Why did you make the changes?
To use the pure UserEntity schema/types for all internal functions.
Did you run tests?
Yes, cypress and unit tests ⭐
<!---IMPORTANT NOTE ABOUT RUNNING TESTS: ->
- Some tests may require multiple runs before success.
- Some test failures may not be due to your contribution and can be ignored.
- If tests fail without resolution, please let us know here.
- Directions for running tests are in the README.md

<!--- PR CHECKLIST: PLEASE REMOVE BEFORE SUBMITTING —>
Before submitting, check that you have completed the following tasks:
- [ ] Answered the questions above.
- [ ] Read Chayn's Contributing Guidelines in the CONTRIBUTING.md file.
- [ ] Enabled "Allow edits and access to secrets by maintainers" on this PR.
- [ ] If applicable, include images in the description.
After submitting, please be available for discussion. Thank you!

@annarhughes Thank you for reviewing! I've made the updates, please take a look!

Brilliant thanks!


feat: added example for e-mail notification

Fixes #

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (c531882) compared to base (9c78dcc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           52        52
  Branches        15        15
=========================================
  Hits            52        52

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


receiveFrame return this

Coverage remained the same at 100.0% when pulling 8047be9b8cffc52eff73b1b6cbac17e8b53f8894 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.

Coverage remained the same at 100.0% when pulling 8047be9b8cffc52eff73b1b6cbac17e8b53f8894 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.

Coverage remained the same at 100.0% when pulling 8047be9b8cffc52eff73b1b6cbac17e8b53f8894 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.

Coverage remained the same at 100.0% when pulling 6bade3e96797b5ffe8b1c2b3e90e43b7af9167f0 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.

Coverage remained the same at 100.0% when pulling 6bade3e96797b5ffe8b1c2b3e90e43b7af9167f0 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.

Coverage remained the same at 100.0% when pulling 6bade3e96797b5ffe8b1c2b3e90e43b7af9167f0 on receiveFrame01 into e2901b7966f7bdeb49283673b5d97152a9c86c4e on master.


Added getPlaybackRate() method

Unable to use this.setPlaybackRate(1) in this.getPlaybackRate().
An "Uncaught TypeError: Cannot read property '0' of undefined" error would occur at isPaused() method.

Ok. I'll change accordingly.

Thanks! By the way, you don't need to create new PRs, you can just commit and push to the same branch of yours.

oh. i didn't know that. ok. last pr from me regarding this issue. closing the original request as well.


npm install should map to yarn add

Using npm install foobar produces error
yarn install v1.9.4
error `install` has been replaced with `add` to add new dependencies. Run "yarn add foobar" instead.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

An alternative is to pin to using an old yarn, but that probably isnt what people want.

This package is deprecated. Please don't use


Data for SEO for easier sharing and being searched

Adding a plugin for jekyll so that when a page link is shared, it has better information, on different social networks and communication channels
Add images of what it will look like from, using my page fork as an example. I leave related link
Plugin Jekyll
https://github.com/jekyll/jekyll-seo-tag
Test tool
https://developers.facebook.com/tools/debug
https://cards-dev.twitter.com/validator
Link test
https://thecodingtrain.com/CodingChallenges/152-rdp-algorithm.html
https://nocheprogramacion.com/Tutoriales/064_Como_usar_Discord_Paso_a_Paso.html
Test Twitter

Test Discord

Test Telegram

discuss my english
Sharing
Instagram: ALSWnet
Twitter: ALSWnet
Youtube: ALSWnet

Thank you!!

Thank you @chepecarlos so much for helping with this! What a wonderful new feature! 🚂🚀


Fix ImageButton bool return value for pressed

This was a regression in 0.2.0, in that large change the build function lost its return value so one couldn't check if the image button had been pressed or not.
Would it be possible to have a 0.2.1 published on crates.io with this fix?

Thanks! :smile:
Yeah, I'll release 0.2.1 of imgui + imgui-winit-support later today


Support for dgraph-io/badger

Hello, I've wanted to add support for https://github.com/dgraph-io/badger, but most recent badger/v4 uses go 1.19, and trm is 1.13 due to backward compatibility. So I have a few questions

will go-transaction-manager bump its go version someday?
How can I contribute with badger support without bumping go version? I am aming for supporting badger/v4, maybe with separate it with build-tags?
Could I fork go-transaction-manager for my personal usage and bump go there?

Hello,

I am not planning to bump the version.
You can see the gorm example, which supports only going 1.16  and up by build tags.
I cannot forbid you to fork. It is your right :) However, I suggest you use the gorm approach to add badger in go-transaction-manager.

I want to separate the interface and implementation in different go.mod packages. When it would be done, I don't know.
There is an issue with that https://github.com/avito-tech/go-transaction-manager/issues/75

Yes, you can continue my pr or review it.
https://github.com/avito-tech/go-transaction-manager/pull/92

If you have a desire to contribute, reopen the issues and feel free to create a PR.


Add Dataset Size Requirements Section

Summary
Adding a section that explains the need to know max_batch_size_train when submitting a training job. Customers were running into issues with datasets that were too small, so this section concisely explains how to check the max_batch_size_train parameter when preparing your dataset. Additional explanation is provided in a collapsable Explanation section to give relevant context, but not overwhelm the reader who's just getting started.

Good eye, I agree that the first few sentences under ### Dataset Size Requirements are a little too broad. I like your suggestions as they're straight to the point. Will add those in now!
I would like to keep the ###Dataset Size Requirements header though since I believe a lot of users infer what they need to read by skimming headers and having a header that clearly indicated a requirement around dataset size will at least get them to acknowledge that there are some things to consider here. WDYT?

Epic, this is so helpful! Thank you for adding. Quick clarifying question, is "Local batch size" the same as max_batch_size_train in the metadata.yaml file?

Yeah, should I change the name? Just want to clarify that this is local batch size not global batch size

I think the important thing is that it has the same name as the line in metadata.yaml, otherwise the user will be confused. IMO, our users won't be concerned with the difference between local and global batch size when it comes to studio since their workflow will just consist of setting the batch size in the hyperparams section of studio.

I think the important thing is that it has the same name as the line in metadata.yaml, otherwise the user will be confused. IMO, our users won't be concerned with the difference between local and global batch size when it comes to studio since their workflow will just consist of setting the batch size in the hyperparams section of studio. So to this end, I think if we just keep it to max_batch_size_train in both spots, we won't run into any issues. If we do get questions about whether it refers to local or global, we can make a change to be more specific at that point. WDYT?

Sounds good I changed the naming to just batch size in most recent push

So clean!


master

ERROR: Command errored out with exit status 1:
command: /home/electronsz/anaconda3/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-8mwzsk7e/advanced-pca/setup.py'"'"'; file='"'"'/tmp/pip-install-8mwzsk7e/advanced-pca/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
cwd: /tmp/pip-install-8mwzsk7e/advanced-pca/
Complete output (5 lines):
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-8mwzsk7e/advanced-pca/setup.py", line 15, in
with open(path.join(this_directory, 'README.md'), encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-8mwzsk7e/advanced-pca/C:/Users/Fredo/Google Drive/Knowledge Center/Data Scientist Nanodegree/pr-pypi-package/README.md'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Fixed readme.md error read when installing package from remote machine or from pypi

So i removed the readme.md call from setup.py

upvote


Warnings from grunt-contrib-watch with spawn:false are not displayed.

Warning is not displayed through grunt-notify, when grunt-contrib-watch is used with spawn:false option.
As @vict-shevchenko notices:
grunt-watch suppresses error and warning events, so in command line you'll see only
Warning:
but not
Warning: Use --force to continue.Aborted due to warnings. and notification miss this.

Also having problems with this: https://github.com/dylang/grunt-notify/issues/122


nvidia-x11: Add patches for kernel 5.1.

Fixes https://github.com/NixOS/nixpkgs/issues/61165
Produced this on my own based on the errors and kernel changes:
https://github.com/torvalds/linux/commit/3d3539018d2cbd12e5af4a132636ee7fd8d43ef0
This is an intentional breaking change forcing drivers to acknowledge that the
return type of vm_vault handlers has changed to vm_fault_t and that VM_FAULT_*
must be returned. The driver only needs to be fixed to actually return vm_fault_t,
it already returns VM_FAULT_* values.
https://github.com/torvalds/linux/commit/fcd70cd36b9bf697122538c9e38e8cf954b2342b
Some DRM helper functions were moved to a separate header.

Motivation for this change
Drivers do not build with kernel 5.1.
Things done
Builds without warning/errors and runs without obvious problem on my system with kernel 5.1. Plasma desktop with compositing and some random WebGL samples work fine. I think a few more people should test it.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Sorry this doesn't actually work with these drivers, I was testing this with 418 drivers. I tried backporting but hit some issue about apparent breakage in linux acpi headers:
/nix/store/kaxpcplyarp30d6c5dxw5k742xzp6rrs-linux-5.1-dev/lib/modules/5.1.0/source/include/acpi/acpi_bus.h:44:25: error: unknown type name 'acpi_handle'; did you mean '__sighandler_t'?

I managed to fix that but there are more errors, I don't think it is reasonable to keep trying to patch this version.


DropdownV2 highlights all items if items have no id property and selectedItem is used

Using the DropdownV2 component with items that have no id property and setting the selectedItem results in items that all have the highlighted class attached. This is due to the check in https://github.com/IBM/carbon-components-react/blob/master/src/components/DropdownV2/DropdownV2.js#L191
If item and selectedItem both have no id property the check becomes undefined === undefined which is true.

Work around for this is to add an id to selectedItem and/or the other items
https://codesandbox.io/s/n5x6jj8p2j

It's possible to know if the isActive property of a MenuItem is truthy with a strict equality operator, which is being used on the following line https://github.com/IBM/carbon-components-react/blob/master/src/components/DropdownV2/DropdownV2.js#L188. Maybe a pull request using the same logic in the isHighlighted will solve this issue.


net/url: optimize unescape and escape

According to a profiling data from a large number of servers at Google, URL related functions are among the top 150 functions by CPU time. The simplest optimizations I see are around using LUTs in shouldEscape, isHex, and unHex.

Based on the profiling data that you mention, it looks like the unescape time is split evenly between runtime.makeslice and 	runtime.slicebytetostring.
The net/url.shouldEscape function is responsible only for ~7% of the CPU time. LUTs might not help as much as we would like.

Regarding the allocations and slicebytetostring, see compiler feature request #6714.
/cc @randall77 @cherrymui @josharian @dr2chase

See also: #18990

I'm not sure it's the kind of optimization you want, but I find that if I do some "hand optimization", just eliminating branches, I get pretty significant speed increases:
package perf

import (
	"net/url"
	"testing"
)

const ESCAPE_ME = "net/url: optimize unescape and escape"

var s string

func BenchmarkPathEscape(b *testing.B) {
	for i := 0; i < b.N; i++ {
		s = url.PathEscape(ESCAPE_ME)
	}
}

func shouldPathEscape(c byte) bool {
	if 'A' <= c && c <= 'Z' || 'a' <= c && c <= 'z' || '0' <= c && c <= '9' {
		return false
	}
	switch c {
	case '-', '_', '.', '~', ':', '@', '&', '=', '+', '$':
		return false
	}
	return true
}

func MyPathEscape(s string) string {
	hexCount := 0
	for i := 0; i < len(s); i++ {
		if shouldPathEscape(s[i]) {
			hexCount++
		}
	}
	if hexCount == 0 {
		return s
	}
	t := make([]byte, len(s)+2*hexCount)
	j := 0
	for i := 0; i < len(s); i++ {
		c := s[i]
		if shouldPathEscape(c) {
			t[j] = '%'
			t[j+1] = "0123456789ABCDEF"[c>>4]
			t[j+2] = "0123456789ABCDEF"[c&15]
			j += 3
		} else {
			t[j] = c
			j++
		}
	}
	return string(t)
}

func TestMyPathEscape(t *testing.T) {
	expected := "net%2Furl:%20optimize%20unescape%20and%20escape"
	if actual := MyPathEscape(ESCAPE_ME); actual != expected {
		t.Fatalf("expected \"%s\", got \"%s\"", expected, actual)
	}
}

func BenchmarkMyPathEscape(b *testing.B) {
	for i := 0; i < b.N; i++ {
		s = MyPathEscape(ESCAPE_ME)
	}
}

goos: darwin
goarch: amd64
BenchmarkPathEscape-8     	 3000000	       438 ns/op
BenchmarkMyPathEscape-8   	10000000	       147 ns/op

It seems to me like calls to functions like escape should probably be inlined when a parameter on which many branches depend is given a const argument:
func PathEscape(s string) string {
    // not inlined, but probably should be since it would allow significant optimizations:
    return escape(s, encodePathSegment)
}

@ccbrown I also experimented with some optimizations (mostly unescpae) but have not cleaned them up in a CL yet. So i am interested what we can improve too. Maybe i still get around to finish them for 1.10.
I was thinking of creating a table [256]uint8 where byte contains some flags. e.g. shouldPathEscape (if we need more flags this can become uint32)
so we can use the same lookup table in multiple functions to quickly look up properties of ASCII characters while at the same time not wasting ram for a lookup table each time. This could be even stored in a separate package so multiple std lib packages (e.g unicode.IsSpace or strings.Fields) can use the same table.
Some comments while briefly looking at the code:

t[j+2] could maybe avoid some bounds check here by checking _ = t[j+2] earlier in the block.
we could remember the first position where a to be escaped symbol is and skip ahead to that in the second loop after making a copy of the start up to that symbol. But that would make performance worse when to position is very near the start of the string.

if shouldPathEscape(s[i]) {
 hexCount++
}

if this is not already recognized by the compiler to become a setCC instruction with an add on AMD6 4 instead of a branch we should have a look at optimizing that. (maybe there is even an add that just takes the flag without setCC)
Does your new version pass all the tests?

Tried a few more things.
Using a boolean LUT does make things faster:
func MyBoolLUTEscape(s string, shouldEscapeLUT [256]bool) string {
	hexCount := 0
	for i := 0; i < len(s); i++ {
		if shouldEscapeLUT[s[i]] {
			hexCount++
		}
	}
	if hexCount == 0 {
		return s
	}
	t := make([]byte, len(s)+2*hexCount)
	j := 0
	for i := 0; i < len(s); i++ {
		c := s[i]
		if shouldEscapeLUT[c] {
			t[j] = '%'
			t[j+1] = "0123456789ABCDEF"[c>>4]
			t[j+2] = "0123456789ABCDEF"[c&15]
			j += 3
		} else {
			t[j] = c
			j++
		}
	}
	return string(t)
}

BenchmarkPathEscape-8              	 3000000	       438 ns/op
BenchmarkMyPathEscape-8            	10000000	       144 ns/op
BenchmarkMyBoolLUTPathEscape-8     	10000000	       128 ns/op

Compacting all of the different encodings into a single [256]byte LUT is slower, but still reasonably fast (and would potentially save 6*256 bytes in memory):
func MyLUTEscape(s string, mode encoding) string {
	hexCount := 0
	mask := byte(1 << byte(mode))
	for i := 0; i < len(s); i++ {
		if shouldEscapeLUT[s[i]]&mask != 0 {
			hexCount++
		}
	}
	if hexCount == 0 {
		return s
	}
	t := make([]byte, len(s)+2*hexCount)
	j := 0
	for i := 0; i < len(s); i++ {
		c := s[i]
		if shouldEscapeLUT[s[i]]&mask != 0 {
			t[j] = '%'
			t[j+1] = "0123456789ABCDEF"[c>>4]
			t[j+2] = "0123456789ABCDEF"[c&15]
			j += 3
		} else {
			t[j] = c
			j++
		}
	}
	return string(t)
}

BenchmarkMyLUTEscape-8             	10000000	       151 ns/op

Note while these functions can be re-used by all of the encodings, I'm still excluding the c == ' ' && mode == encodeQueryComponent case for now. If needed, query component encoding can get its own function implementation.
@martisch

t[j+2] could maybe avoid some bounds check here by checking _ = t[j+2] earlier in the block.

we could remember the first position where a to be escaped symbol is and skip ahead to that in the second loop after making a copy of the start up to that symbol. But that would make performance worse when to position is very near the start of the string.

Tried both. Neither really made a measurable difference for me.

if this is not already recognized by the compiler to become a setCC instruction with an add on AMD64 instead of a branch we should have a look at optimizing that.

That function actually got inlined for me. So it didn't use any conditional instructions like that there.
But in the LUT version, maybe that sort of thing could work here:
perf_test.go:207	0x10f004d		4084f8			TESTL DI, AL
perf_test.go:207	0x10f0050		74e3			JE 0x10f0035
perf_test.go:208	0x10f0052		48ffc6			INCQ SI
perf_test.go:207	0x10f0055		ebde			JMP 0x10f0035

I'm not really gonna try to optimize this at such a low level yet though.

While working on 134296 I saw that the benchmark for the String() method still shows about 60 allocations being made. This is because we don't pre-size the strings.Builder and also call escape at least 5 times for different url components.
I think this could be optimized by pre-sizing the builder with the known lengths (scheme, opaque, rawquery) and passing the builder to a new escape function that writes to a builder. The existing escape function could be modified to create a builder and call the new function or the existing callers of escape could do it (QueryEscape, PathEscape etc.)
I can work on this if there is interest in this approach.

@iand, sounds reasonable.

After spending several more minutes examining the String benchmark I realised that the reported timings and allocations are the cumulative totals of all 20 test cases.
I investigated modifying the various escape functions write to a shared strings.Builder but couldn't reduce the allocations and timings by enough to justify the extra complexity.
Also looked at pre-sizing the builder. It's easy enough to calculate the capacity needed for the fixed components and estimate the length of most of the encoded parts, but path is little more tricky. Performing these calculations adds timing overhead which makes the function slower overall, even with the one or two allocations it saves.
I found I could get just as good a benefit by simply growing the builder to a fixed 64 bytes. Some timings for variants on this approach are below. However, it's likely that I'm just fitting to the test cases.
I'm happy to send a CL for a one line change setting the initial builder size to 64 bytes, but I'm not convinced it adds much value.
Current master:
BenchmarkString-8        500000	      3393 ns/op	    1664 B/op	61 allocs/op

Pre-sized builder.
32 bytes:  BenchmarkString-8   500000	2966 ns/op	    1632 B/op	43 allocs/op
64 bytes:  BenchmarkString-8   500000	2837 ns/op	    1648 B/op	33 allocs/op
128 bytes: BenchmarkString-8   500000	2891 ns/op	    2800 B/op	32 allocs/op

What is the state of this issue? Looks like it's stalled after 1.13 freeze, but no other problems are mentioned. Kindly ping @iand

I write a new version of FastQueryEscape(), it's 7.33 times faster than url.QueryEscape().
Of course, I based your codes.
The detail is here: https://www.cnblogs.com/ahfuzhang/p/17473178.html


[BACKLOG-18878] Removed code that dynamically tried to add RSA relate…

…d features that are no longer needed and was causing an error.
@mkambol / @flbrino / @aminmkhan

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'plugins/engine-configuration/impl' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/engine-configuration/impl' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/engine-configuration/impl' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/engine-configuration/impl/src/main/java/org/pentaho/di/engine/configuration/impl/spark/SparkRunConfigurationExecutor.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.engine.configuration.impl.spark.SparkRunConfigurationExecutor

Branch Change:  + 7.34%
Complexity Change:  + 7.14%
Instruction Change:  + 2.65%
Line Change:  + 1.58%


Playground device detection

Hi,
I got some issues.
On win 11 - I dont even see my usb radio dongle.
I see it in vmware debian but flashing firmware did not work.
So I am here without any progress possible.
I also got raspbian by hardwario (hub) and there it also does not detect the dongle.
I am out of ideas. I am using latest version of hardwario playground.

I was able to flash firmware via CLI in raspberry pi hub according to documentation. But I cant see the USB device being detected anywhere.

Finaly I made it work. Had to not only restart the rasperry pi. but to unplug POE power wait couple seconds and plug the power again. Then the USB dongle got dettected and I paired the other part of hardwario tower (some sensor) However, it was complicated to make this run

This link does not work: To learn more about HARDWARIO Playground, visit the Desktop Programming section.

@Comodore125 Thanks for reporting the broken link issue. We will fix that ASAP. I am glad it worked in the end. Yes, we should improve the experience to make it easier.

Hello @Comodore125 I fixed the link in the documentation. Thanks for the heads up. If you run into any other issues, feel free to contact us again.