AttributeError: module 'tensorflow' has no attribute 'estimator'

After I install tensorflow_hub, tensorflow and tensorflow_hub get the error "tf.estimator package not installed."
Steps to reproduce:

Install tensorflow with pip3 install tensorflow
Run python code

import tensorflow as tf
tf.estimator # Output: <module 'tensorflow.python.estimator.api.estimator' from '/usr/local/lib/python3.6/site-packages/tensorflow/python/estimator/api/estimator/__init__.py'>

Install tensorflow hub with pip3 install tensorflow_hub
Run python code

import tensorflow as tf # Output: tf.estimator package not installed.
import tensorflow_hub as hub
# Error output of
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-5c017171c13e> in <module>()
----> 1 import tensorflow_hub as hub

/usr/local/lib/python3.6/site-packages/tensorflow_hub/__init__.py in <module>()
     21 import tensorflow as tf
     22
---> 23 from tensorflow_hub.estimator import LatestModuleExporter
     24 from tensorflow_hub.estimator import register_module_for_export
     25 from tensorflow_hub.feature_column import image_embedding_column

/usr/local/lib/python3.6/site-packages/tensorflow_hub/estimator.py in <module>()
     59
     60
---> 61 class LatestModuleExporter(tf.estimator.Exporter):
     62   """Regularly exports registered modules into timestamped directories.
     63

AttributeError: module 'tensorflow' has no attribute 'estimator'

If I uninstall tensorflow hub with pip3 uninstall -y tensorflow_hub, tf.estimator works again in TensorFlow
Environment:

macOS 10.14 Beta (18A384a)
Python 3.6.5
pip 10.0.1
TensorFlow 1.10.1
TensorFlow Hub 0.1.1

Sorry, could not reproduce (on MacOS 10.13 with Python 3.6.4). Could you dig deeper?

Have you solved this problem? @damienpontifex

Came across this today because I was using an old version of Tensorflow from a super old conda environment (1.0.1). Updating to anything from r1.1 onwards should resolve.
tf.estimator doesn't appear to exist prior to Tensorflow r1.1 - verify using the branch dropdown at top left here: (https://github.com/tensorflow/tensorflow/blob/r1.1/tensorflow/python/estimator/estimator.py)


NETOBSERV-184: decouple components into a pipeline

As a previous step for NETOBSERV-184 (Split and Integrate flowlogs2metrics in
kube-enricher), this PR provides an asynchronous pipeline and wraps the current
components into the following roles:

Ingester: a wrapped version of Goflow2
Transformer: the Pod & Service Enricher
Submitter: the Loki processor

This is only a previous step of the above task to avoid having too large PRs.
The following PRs will try to simplify and decouple even more some existing
components (e.g. Goflow-Kube), remove duplicities. After that, we will
make the Pipeline object to evolve to accomodate the new functionalities
from flowlogs2metrics

We are migrating all to flowlogs-pipeline, where this is already implemented


Bug: Inconsistent delay_offset computation in time domain wfs driving functions

The delay_offset return value of the delayline is given in samples, while the calculations in driving_function_imp_wfs are assuming seconds. Which convention is the correct one?

Both are correct. The whole calculation in delayline() is done in samples as I found this to be more intuitive when working with integer delays and the whole calculation for the WFS driving functions is performed in seconds.
But you are correct, there is a bug then in line 150 of driving_function_imp_wfs which reads
delay_offset = delay_offset + delayline_delay;

at the moment and should read
delay_offset = delay_offset + delayline_delay/fs;

instead.
Maybe we should avoid this by restricting us to use always t / s as input and output arguments in the whole Toolbox? At the moment sound_field_imp() uses also t / samples.

Yeah, as the purpose of delay_offset is to somehow incorporate its value into sound_field_imp() in order to get the correct time snapshot, it is quite complicated that one has to convert it from seconds back to samples. However, I don't know how many functions would be effected from such a change and if it's worth the effort.

Maybe, we should merge the fix and open another issue/pull request to discuss the seconds/samples convention?

OK, I merged it and created a new branch time_in_sec where we can start work and discuss a change in the general time behavior (no pull request yet as this is not possible without a change in code).


Add support for SQL data bindings

SQL bindings
This feature allows users to execute SQL queries on databases and bind their results to named attributes in Gwen. This is facilitated through the following new DSL:
<attribute> <is|will be> defined by sql "<selectStmt>" in the <dbName> database
Where:

<attribute> = the name of the attribute to bind the SQL result to
<selectStmt> = the SQL select query statement (must return one result with one field)
<dbName> = the name of database to execute the query on. This name is used to configure the database as follows:

A gwen.db.<dbName>.driver setting must be set to the name of the JDBC driver implementation class
A gwen.db.<dbName>.url setting must be set to the JDBC URL of the database
The GWEN_CLASSPATH environment variable must be set to include a path to the JDBC driver JAR

If more than one record is returned by a query, then the result in the first one will be returned and the others discarded. For best results, you should narrow the query using a where clause to ensure that only one record is returned. If no records are returned, then an error stating that no records were found will be reported. The query will be executed and the result will be bound to the attribute when it is referenced at evaluation time.
An example using a MySQL database
Sample usage:
The following example executes a query on a comments table in a feedback database and assigns the result to the email attribute and then checks the value. This example returns the value of the first record. A more realistic example would narrow the records down to one result by including a where clause in the select statement.
# define the binding using a select query (in meta)
Given the email is defined by sql "select email from comments" in the feedback database

# check the value returned by the query (in the feature)
 Then the email should be<EMAIL_ADDRESS>
Sample configuration:
To enable the above to work with Gwen, you will need to perform the following:

Download the JDBC driver JAR for your database.
Set the GWEN_CLASSPATH variable in the environment to include the path to the JDBC driver JAR

Unix: export GWEN_CLASSPATH=/path-to-driver/mysql-connector-java-5.1.40-bin.jar
Windows: set GWEN_CLASSPATH=c:/path-to-driver/mysql-connector-java-5.1.40-bin.jar

Configure the database in your Gwen settings (gwen.properties file). In this example, <dbName>=feedback

gwen.db.feedback.driver = com.mysql.jdbc.Driver
gwen.db.feedback.url = jdbc:mysql://localhost/feedback?user=myUser&password=myPassword&serverTimezone=UTC&useSSL=false

Let's not merge this yet. I'd like some feedback and also need to run more tests.

@gtsihitas, this SQL capability might help you with issue #32
I've published snapshot build: 2.0.1-2-g9ad787c-SNAPSHOT
Be sure to point your maven repo to https://oss.sonatype.org/content/repositories/snapshots

All working on the oracle front.  Great work!  we can merge this Branko.


Make HiScore lookup always deprioritized

It is super annoying to accidentally have left-click option on stuff
that never has one.
Signed-off-by: Tomas Slusny<EMAIL_ADDRESS>

What is this fixing?

Chatbox having left click lookup action (in vanilla, there is no left-click action for chatbox ever, just left-click right click)

Closes  #3759


chore: update to libdns/libdns v0.2.2 - fix build errors with caddy v2.8.0+

Compare to:
https://github.com/libdns/netcup/pull/1
https://github.com/caddy-dns/netcup/pull/6

Thanks for updating this

@rnavarro Happy to help :D


net: Move include files outside of extern "C" block

This is related to findings in #17997 and changes network
related header files to have include files outside of
extern "C" { } block.
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

This PR doesn't seem to fix any bug (no "Fixes: " header). And neither the commit message not referenced #17997 explain what issue is being fixed either.

This PR doesn't seem to fix any bug (no "Fixes: " header). And neither the commit message not referenced #17997 explain what issue is being fixed either.

@pfalcon It fixes 'extern "C"' linkage errors when including one of these header files in a C++ module. Before the original PR #17993 (referenced in #17997), this was the exact error message (thrown by GCC):
In file included from ../zephyr/include/sched_priq.h:9,
                 from ../zephyr/include/kernel_includes.h:23,
                 from ../zephyr/include/kernel.h:17,
                 from ../zephyr/include/nvs/nvs.h:15,
                 from ...:
../zephyr/include/misc/util.h:53:1: error: template with C linkage
 template < class T, size_t N >
 ^~~~~~~~
In file included ...:
../zephyr/include/nvs/nvs.h:11:1: note: 'extern "C"' linkage started here
 extern "C" {
 ^~~~~~~~~~

Sorry for not mentioning this in the commit message.

@mrfuchs: Thanks for explanation. Yes, it would have been good if more details went into the commit message.

Updated the commit message.


Does Goldy support 0.9 version?

Could I use Goldy like DTLS terminator? Does Goldy support openSSL 0.9?
Thank you for all :)

Goldy doesn't use OpenSSL at all; instead, it depends on another TLS library called mbedTLS (from ARM).


Protein fixes

New batch of fixes and additions for the protein plugin
Summary of Changes

Adds the UncertaintyCartoonRenderer and all related modules that have been resurrected from their graves
Fixes an issue that placed the results of the SimpleMoleculeRenderer always in front of the GUI.
Fixes the compilation of the protein plugin for the newest core versions

References and Context

Test Instructions

/format


⚠ GazelleGames has degraded performance

In cda29fb, GazelleGames ($GGN) experienced degraded performance:

HTTP code: 200
Response time: 9383 ms

Resolved: GazelleGames performance has improved in 7766f1a.


Add WASM option to vite create

Description
WASM is a technology allows for fast execution in the browser an integration in Web3 components
Suggested solution
In vite-create, after asking to use JS or TS, ask a question"Add WASM  to project".  There are two ways it can be accomplished,
Have all the files in the template
Alternative
Run "wasm-pack new". This second option would offer greater flexibility..
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Thanks for the proposal @greenpdx, but this is outside of the scope for create-vite. A user can directly used wasm-pack new as you noted in the alternative.


Import JavaScript Library in Angular Prj

How I add Javascript files to an Angular project?
I've found this great post about how to do it using the Angular CLI but I'm not sure how to translate that to this project template.

angular.cli.json
"scripts":[ "../node_modules/underscore/underscore.js" ]

It sounds like you just want to load a .js file as a global in your web page. Webpack provides various ways to include scripts in its bundles (check Webpack docs for details), but for this simple case, you don't even need to use Webpack. You can put the .js file into wwwroot and add a <script> tag on to your layout or Index.cshtml to load it.
If you're trying to do something more sophisticated, then there isn't just one way to do it. It depends on what library you're trying to add and how it's intended to integrate with Angular and/or Webpack. The only way to know how to do this in general is to become familiar with Webpack (see: webpack docs) and in the case of Angular add-ins, find out how the author of the add-in expects it to be set up with Webpack. But it sounds like this might not be necessary in your case as you might be just trying to load a script file globally.

@SteveSandersonMS copy that.  Thanks!!! 🎉


Use tabular numbers for character count message

By default different numbers take up different amounts of horizontal space, for example ‘1’ is narrower than ‘0’, just like an ‘i’ is narrower than an ‘m’.
In the character count component the amount of space take up by the message changes as the user types. This causes the words after the count (‘characters remaining’) to jump around in a distracting way.
Tabular numbers take up a fixed amount of space, which means the words after the count do not change position as long as the count maintains the same number of digits (which will be true for most keystrokes).
Before

After

Thanks @36degrees, I’ve updated the changelog in 7e75d73e

Thanks @36degrees, I’ve updated the changelog in 7e75d73e


Add unit test runner for autocompletion

To prevent GDScript changes from breaking auto completion capabilities.

This PR adds the possibility to write Auto Completion tests. However it does not add any tests. I want to have the runner merged before working on test cases.

Just noticed that there is no Github CI that runs tests with mono enabled. Would this be possible? I see no reliable way to test auto completion with SCRIPT types without using another script language besides GDScript. Because any way of obtaining a SCRIPT typed reference to a GDScript might break if we decide to intelligently upgrade the type in the future.

Just noticed that there is no Github CI that runs tests with mono enabled

There is, GHA / 🐧 Linux / Editor w/ Mono (target=editor)

This is because of issues, see the workflow file comment:

Disabled due freeze caused by mix Mono build and CI

I've tested running a few times with the tests enabled and don't see any freezing, but I think this should be enabled and tested extensively in a separate PR to avoid any problems

This should be ready for a first round of review now, since I added the features which I wanted to add.
What still remains to do:

squash the commits (will do at the end, but while in review having the history might be helpful)
remove dummy tests (will do at the end, but they are needed for testing)

Thanks for working on this, BTW. It is something on my mind for a while so I'm glad to have tests for completion.

I also wonder if we can have an easy way to create the cfg files since writing them by hand might be tricky and prone to typos, especially if they get big (though tests should probably be small anyway).

Generating them through CLI like the other GDScript test would be quite inconvenient I think. It sounds more like an entry for the tools menu which gives you some UI that allows to configure the test and spits out the cfg and maybe also the script with the inserted sentinel char. But since it would be dev only, having it in the menu seems wrong.
Maybe I will write a little editor plugin for it, but that is something to think about when actually writing test cases. I can also imagine that copy and pasting an existing cfg will be quite sufficient for most cases.

Thanks!


Handle ui rerequest on push

We were only handling it on pull_request, we had to do a whole different
thing to make it  work on push.
We set the sender to the one who clicks on the rerequest on push,
compared on pull_request which we assume the sender is pr author.
The only way to be able to do a rerequest on push is to be a owner of
the repository, so that should be harmless.
Closes #111
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>

/lgtm


Create Mesh Terrain

[ ] For each patch point

[x] Locate relative tile from patch tiles list using point and tile Lon, Lat
[x] Move tile point (tile mesh, point)

[x] Move vertex
[x] Create new mesh from clipboard vertices

[x] Test https://docs.unity3d.com/ScriptReference/Mesh.MarkDynamic.html
[x] Optimize DGM data Reading #3
[x] Split XYZ data to files containing only heights #6
[ ] If is missing point (left column, bottom row), locate relative tile from tiles with missing points list using point and tile Lon, Lat
[ ] Move tile missing point (tile mesh, point)

[x] Create patch tiles list: List(Tile)
[x] Create tiles for each patch:

[x] For each vertical tile <  tile count

[x] For each horizontal tile <  tile count

[x] Instantiate tile[ht, vt]
[x] Name tile as coordinates
[x] Position tile
[x] Add tile to patch tiles list
[x] Add top row tiles and right column tiles to tiles with missing points list

[x] Create tile with missing points list: List(Patch)

[x] Convert Lon, Lat to full numbers like points: 123456, 1234567
[x] Patch { Lon, Lat, Tile }
[x] Tile { Lon, Lat, Mesh }

[x] Create tile mesh as prefab:

[x] Pivot at lower left corner
[x] Tile resolution = (patch resolution / tile count) + 1

Skip it, can create from terrain data directly


Whether circular dependencies work depends on the order objects are retrieved from the injector

For example:
class A {
    @Inject
    A(B b) {
    }
}

class B {
    @Inject
    A a;
}

class MyModule extends AbstractModule {
    @Override
    protected void configure() {
        bind(A.class).in(Singleton.class);
        bind(B.class).in(Singleton.class);
    }
}

public class FooTest {
    @Test
    public void testAFirst() {
        // Fails
        Guice.createInjector(new MyModule()).getInstance(A.class);
    }

    @Test
    public void testBFirst() {
        // Passes
        Guice.createInjector(new MyModule()).getInstance(B.class);
    }

    @Test
    public void testProduction() {
        // Fails for me, probably not deterministic?
        Guice.createInjector(Stage.PRODUCTION, new MyModule());
    }
}

I think I understand why this happens, but I don't think it's particularly desirable.  In fact, when it does "work," we're still passing a partially-initialized B instance to A's constructor, which could be problematic if it tries to use B instead of just storing it in a field.
My proposed resolution is a new flag binder().disableCircularDependencies() that completely disallows dependency cycles (unless broken by a Provider).  Or possibly binder().disableCircularClassDependencies() if we want the option to allow circular dependencies through interfaces, since those work due to proxying.

100% agreed on disabling completely.  Doing so would require a bit more
analyzing of the graph, which would enable some other niceties too.
On Wed, Dec 9, 2015 at 4:19 PM Tavian Barnes<EMAIL_ADDRESS>wrote:

For example:
class A {
@Inject
A(B b) {
}
}
class B {
@Inject
A a;
}
class MyModule extends AbstractModule {
@Override
protected void configure() {
bind(A.class).in(Singleton.class);
bind(B.class).in(Singleton.class);
}
}
public class FooTest {
@Test
public void testAFirst() {
// Fails
Guice.createInjector(new MyModule()).getInstance(A.class);
}
@Test
public void testBFirst() {
    // Passes
    Guice.createInjector(new MyModule()).getInstance(B.class);
}

@Test
public void testProduction() {
    // Fails for me, probably not deterministic?
    Guice.createInjector(Stage.PRODUCTION, new MyModule());
}

}
I think I understand why this happens, but I don't think it's particularly
desirable. In fact, when it does "work," we're still passing a
partially-initialized B instance to A's constructor, which could be
problematic if it tries to use B instead of just storing it in a field.
My proposed resolution is a new flag
binder().disableCircularDependencies() that completely disallows
dependency cycles (unless broken by a Provider). Or possibly
binder().disableCircularClassDependencies() if we want the option to
allow circular dependencies through interfaces, since those work due to
proxying.
—
Reply to this email directly or view it on GitHub
https://github.com/google/guice/issues/970.

All yours :-)
On Wed, Dec 9, 2015 at 4:38 PM Tavian Barnes<EMAIL_ADDRESS>wrote:

Alright I'll cook up a patch (unless you want to).
—
Reply to this email directly or view it on GitHub
https://github.com/google/guice/issues/970#issuecomment-163401327.


Assert that certain Extract Symbol null-checks are unnecessary

Fixes #18852

Closing in favor of a change from @andy-ms.


Comment on ingestion start time

@kerend : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@kerend : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[Eslint-plugin] Add require-media-dimensions rule

Description
There's a ton of unnecessary layout shifts that happen in the admin and other frontend apps across the org, a lot of which happen in bursts (when one or more individual layout shifts occur in rapid succession with less than 1-second in between each shift and a maximum of 5 seconds for the total window duration — see linked video). A common culprit for this is not specifying explicit dimension attributes for media elements.
Rendering media elements like img and video in the browser without explicitly specifying width and height attributes often would cause an unexpected page movement/jump during load which could interrupt a user's current flow and potentially result in unintended actions which in some cases could be costly — this scenario is called a layout shift.
However, when width and height attributes are specified upfront, modern browsers are able to compute an aspect ratio and reserve the right amount of space while the media loads, leaving only a paint task once the media is ready.
In this video (slowed for illustrative purposes), you'll notice that the layout shifts significantly 4 times in about 2 seconds, which is a lot.
This rule is simply one step towards the right direction of minimizing these jumps — it enforces the presence of width and height attributes on standard media elements (img, video), the Polaris Image component, and provides an avenue to specify custom components and elements that should be analyzed for violations.
There's still a lot that needs to be done to be able to really contain these shifts like exposing interfaces to specify media dimensions for compound components and components that render other media components like EmptyState, Thumbnail etc.
Type of change

[ ]  Patch: Bug (non-breaking change which fixes an issue)
[x] @shopify/eslint-plugin Minor: New feature (non-breaking change which adds functionality)
[ ]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

https://shopify.slack.com/archives/C02E6ML0GS1/p1645735515794759?thread_ts=1645721034.727849&cid=C02E6ML0GS1


Bug fix tooltip for touchscreens

Details

This PR will fix the tooltip showing on touchscreens without mouse/pointer. A condition for pointer is added in filed Tooltip/index.js that show Tooltip only when there is pointer present otherwise don't show the Tooltip.
Fixed Issues

$ https://github.com/Expensify/App/issues/9737
Tests

Open any report in mWeb.
Long press back button in report screen and see the when navigated back back tooltip is not shown.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Launch the app on mWeb.
Press on any report to open it.
Long press back button in report screen header.
Navigated back and back tooltip is not shown.
Repeat the above steps multiple times to verify that tooltip doesn't appear on Touchscreens

[x] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

https://user-images.githubusercontent.com/36359331/190351463-0bdc655d-6e44-40e0-9dbf-971564714cc7.mp4
Desktop

https://user-images.githubusercontent.com/36359331/190360386-39cb83da-b34c-431a-b666-706f3c5050cc.mov
iOS

https://user-images.githubusercontent.com/36359331/190366748-2ec299ac-6d9a-4dd5-bce8-866f0b632f54.mov
Android

https://user-images.githubusercontent.com/36359331/190363103-8468e16c-33ae-4760-997e-adde5e39a5d2.mov

Lint, unit tests, security checks have failed check this.

Thats strange npm run test is passing all the test.

Can you merge with latest main.

@Santhosh-Sellavel  Are you asking me to merge with latest main
?

Yes pull latest main code into your branch

@Santhosh-Sellavel Pardon me, i don't understand what you mean ? How can i merge latest main branch in this forked repo branch ?

@aneequeahmad It looks like you've created this PR using the main branch of your fork, which is not what I would recommend, because it makes it impossible for you to have more than one PR open in this repo at a time. Here's what I would recommend you do:
# Make sure you're on the main branch in your fork
git checkout main

# Create a branch for this PR
git checkout -b fix-tooltip

# Then reset your main branch to the last commit that's not from you (just rewinding one commit here, since you've only got one commit in this PR)
git checkout main
git reset --hard HEAD~1

# Add the upstream remote
git remote add upstream git@github.com:Expensify/App.git

# Fetch upstream changes
git fetch upstream

# Rebase your main branch to be in-sync with the upstream main
git rebase upstream/main

# Then merge your updated main branch into your PR branch, and resolve conflicts as needed
git checkout fix-tooltip
git merge main

# Finally, push your PR branch
git push origin fix-tooltip

Once you've done that, you can change the base branch of this PR from aneequeahmad:main to aneequeahmad:fix-tooltip and re-request reviews from us. After your PR has been merged, you can clean up by doing the following:
git checkout main
git fetch upstream
git rebase upstream/main
git branch -d fix-tooltip

I'd recommend you follow this workflow for any future PRs as well:

Make sure your fork's main is up-to-date with the upstream
Create a branch off of your fork's main for the feature or bug fix you're working on. Push this branch and use it to create the PR.

Thanks for the quick help here. @roryabraham

@roryabraham Thanks for your suggestion. I couldn't change the aneequeahmad:main to aneequeahmad:fix-tooltip so i did what you said above and created a new PR.
I would take care of all these things from now on. Thanks agaIn.

Cool, let's close this one!


Adds ECC provisioning feature

IMO we shouldn't move to this until we know it's working 100% correctly and the chips are configured exactly the same way as using the original tool.
As this tool isn't used by anyone in production yet we need to be extra careful


Ability to filter communities, followers, circles

I'd like to see more categories in "Timeline filters" section.
For example circle connections (already there), following, communities,...
This way, I could get rid of all community posts when I only want to see stuff posted by my following friends that I haven't put in a circle (yet).

From my slack message

Yep, someone suggested having tabs on the main page. We’ll try something like “All” for your connections|followers and another one “Communities” for all communities. When switching tabs, the available filters will also be different. In communities we’ll add filters for category like “Fun”, “Entertainment” and the ones marked as Favorite.


Add automatic build testing for linux arm build targets

CI gfxreconstruct build queued with queue ID 21286.

This PR depends on PR 566 to work.

CI gfxreconstruct build # 534 running.

CI gfxreconstruct build # 534 passed.

Superceded by #596


Display non-printing characters in codemirror editor

Your idea:
The non-printing characters for CR, LF, TAB, SPC can have an effect on how the markdown text is parsed in ways which are not obvious because those characters are visible.
Consider this example:

Note how the bullet list is indenting strangely? That's due to some markdown bullets being preceded with two spaces while others are preceded with a tab. Note word three breaks to a new line while word two did not? That's because there are two trailing spaces after two.
Inspecting the current code mirror generated html I can see that a couple of these already have css classes which could be used to cause display to occur.
cm-trailing-space-new-line
cm-tab
I would suggest → (RIGHTWARDS-ARROW U+2192) for TAB; and ¶ (PILCROW U+00B6) or ⏎ (RETURN SYMBOL U+23CE) for CR and LF. Both styled with color: #ccc to dim them to grey.

We already implemented this and removed it due to user complaint. See https://github.com/naturalcrit/homebrewery/issues/1622

I'm going to close this one since it's a duplicate of #1622 which already has a linked PR and discussion, and can be reopened if necessary.


[RFC] activateAll config flag

I use an own config file myself and I am glad that I don't have to configure all rules myself (threshold etc.). Yet, I prefer an opt-out over an opt-in. Especially because I don't know how stable the default config stays and I don't have the time to track this all the time. Thus I would like to be able to say activateAll rules and then I only deactivate the ones I don't want.

Looks like you want: failFast: true

Linking to #663 #662

I don't think so. I assume failFast is used to stop analysis after first failure. No?

@Mauin oh... I see, it's a naming problem

activateAllRulesAndFailFast would not mind that name although can we find something shorter?


Every one is able to run the coverage

Comment when it works for you!
Works for me :)

works for me

Works for me! (And I know it works for Julian)


problems working on the develop branch?

I was looking at fixing issue #46, and wanted to make the changes against the develop branch (as we are supposed to).
However, I find I can't work with the develop branch because I can't get it to compile.
E.g. when I try to build just the xml module it fails saying:
Could not find artifact psidev.psi.mi.jami:jami-core:jar:3.0.6-SNAPSHOT in nexus-ebi-repo-old (http://www.ebi.ac.uk/intact/maven/nexus/content/repositories/ebi-repo/)
Any advice on how to work with it?
Also, looking at the network graph, is there a minor issue with changes/workarounds made to the master branch but not the develop branch?
cheers,
c

E.g. when I try to build just the xml module it fails saying:
Could not find artifact psidev.psi.mi.jami:jami-core:jar:3.0.6-SNAPSHOT in nexus-ebi-repo-old (http://www.ebi.ac.uk/intact/maven/nexus/content/repositories/ebi-repo/)

Please run: mvn install -Dmaven.test.skip=true, this should install psidev.psi.mi.jami:jami-core:jar:3.0.6-SNAPSHOT in your local maven repository.

Thanks Max. You're right. I don't know how to work maven.
also, no need to skip tests as core in develop branch is passing them


Make trees fall over when harvested

This is a placeholder issue for the tree felling feature that will eventually make it's way into a future release.  Once this feature is complete then Dynamic Trees will be at version 0.8.X.
Notes about the new feature:
This is my attempt to provide a long awaited feature to my mod and minecraft in general.  Since Dynamic Trees can maintain a solitary tree structure in the world it provides some opportunities previously unavailable to minecraft trees.  We can make a entity model with the branches and animate it using whatever means we please.  Falling down when chopped(felling), branches falling down when cut, tree bits flying through the air when a creeper blows up.  The entire tree model can be cached as a BakedModel for performance.  I will apply animations that are only rudimentary based on physics.  These animations can be easily overridden with another mod if someone wants more(or less) complex animations. This system is by no means perfect.  I don't intend to make it perfect. The falling entities will not have accurate collision detection with the environment, moments of inertia, even the rotations are hokey. Keep in mind that this is meant to be a fun little animation to give minecraft more charm while being quick and dirty.  I won't add a plethora of options for people to tweak the falling speed and what have you.  If you're interested in doing so then you can create your own animations in another mod.
Todo before launch:

[x] Falling tree entity
[x] Tree falls and hits the ground when chopped at it's base.
[x] Falling trees damage living entities
[x] Taller trees take longer to fall
[x] Balance falling tree damage with game play
[x] Add damage multiplier for falling tree damage to configuration
[x] Falling trees damage players
[x] Burning trees drop limbs as they are damaged
[x] Dropped limbs are on fire an burn the ground where they land
[x] Falling tree limbs float on water
[x] Data efficiently sent to client via entity
[x] Falling trees feature is optional
[x] Fully tested falling trees
[x] Fully tested falling trees in dedicated server mod
[x] Fully tested with feature disabled to ensure nothing broke
[x] Trees damaged by explosions have limbs that are thrown by the explosive force
[x] Tree entity changes the rooty dirt to plain dirt when cut at it's base
[x] Sneak while chopping to make tree fall in opposite direction
[x] Palm trees
[x] Cacti
[ ] Falling sound effect(don't know where i'm going to get this)
[ ] Optionally line up logs where the tree fell like tree chopper mod(disabled by default)
[ ] Optionally scatter harvested tree parts where the tree fell(disabled by default)
[x] Ignore dynamic leaves blocks collisions so trees can semi-reliably fall in a forest.

Won't fix:

Objects in trees that don't update if the leaves around it are destroyed will hang in the air after the tree falls. e.g. Bee Hives.  Not my problem.
Physics isn't perfect. It's not supposed to be.
Falling trees will collide with vanilla leaves.

Here's a preview of the tree falling feature.
https://imgur.com/Xkk3JZ2

Thanks :)
A little description of the work so far..   The portion of the tree you see falling is an entity.  It's created from the data that is collected before the tree cut off portion is destroyed in the world.  This data is compressed by storing all of the relative offsets and encoding them as an integer array.  The connection sizes for each node are similarly stored in an integer array.  This compressed data is stored in an NBT Integer array and shot off to the client side entity where it recreates the data in the form of a model.  This model is cached as an array of baked quads for performance reasons.  An animation style is selected based on how the branch was cut.  Once the animation is complete the entity will drop it's payload using whatever method is appropriate for the animation.
For those of you who rub your nipples when the frame rates are high you'll be glad to know that this operation is not going to kill your frame rate.  I'm using methods not unlike falling gravel and sand block entities.  Also, this feature is entirely optional and can be disabled in the config file.  So quit yer bitchin'
At the moment the "fallover" animation simply makes the tree rotate over with acceleration depending on how high it's center off mass is from the cutoff point.  When the tree reaches 90 degrees then the animation ends and the payload is dispensed at the cutoff point.  It completely ignores surroundings and the model harmlessly goes into hills and other would-be obstructions.  This is not how I intend it to be in the end.  I plan to make the animation end when the trunk encounters a solid block.  Also mobs and other players can take damage from being in the wrong place when the tree falls(yes, configurable damage of course).

Here's another point to bring up..  Many people want the tree to fall to the ground and stay there so they can hack it up into pieces à la Tree Chopper.  If you know anything about how Dynamic Trees function then you'll understand right away why that can't be.  Instead I will try to include an option where the appropriate amount of whole logs are placed at the trees final resting place surrounded by the remaining wood in the form of stick itemStacks.  Everyone has their own idea about how this should function, many of those same people have no idea how Dynamic Trees work at all.  Just remember that perfect is the enemy of good.

re: Falling sound effect
What would be ideal? I was considering helping before realizing some possible complications.

Chopping a thin branch shouldn't make the same heavy crack & thump a whole tree would.
Some trees hit the ground sooner/later than other trees because of surrounding elevation/slope differences, so sfx for impacts should play separately from sfx for breakages.
Sfx for impacts for trees without leaves should sound different from trees with leaves.

Maybe I'm giving it too much thought. Anyway, attached is a clip of a leafy tree hitting the ground.
dt_leafy_tree_impact_32kbps.zip source

What if it was two sounds?  One for the creaky fall and the other on impact.  The sounds could be pitch shifted for tree size.  Terminating the sound early could be a problem as I don't think MC lets you do that.
Plus the sounds MUST be royalty free with no restrictions.

Yeah separate sounds is what I was thinking in the 2nd point. Pitch shifting based on wood diameter sounds elegant. Would you want leafy and non-leafy versions?
That clip's source is under the Creative Commons license and probably has more to offer than just the leafy impact. I haven't spent much time searching Freesound yet.

There would need to be 2 or 3 variations of the same sounds so the audio doesn't get repetitive.  Yeah, having a leafy and non leafy ground contact sound might be something to consider.

Here are a handful of sfx I pulled and edited from other Freesound.org samples, including the previously posted one, bundled with license info and source URLs.

Here are a handful of sfx I pulled and edited from other Freesound.org samples, including the previously posted one, bundled with license info and source URLs.
dt_felling_sfx_32kbps.zip

Thanks naqaden.  I might be able to use these.

I suggest to add some radomness when cutting the tree(only 4 directions of course), for example the tree can fall in the player direction, that will make cutting a tree a little bit more dangerous. ;-)

Thanks for the suggestion but I think it's presumed that Steve is a knowledgeable enough woodsman to make the tree fall in a favored and controlled direction. Such is an easy task for any worker in that field.

This is mostly implemented aside from the sound which is an asset issue.


Fix bl808-firmware dependencies

Hello, I've finally gotten around to starting to use my new 0x64 and I ran into some issues when attempting to build. I use BB_NUMBER_THREADS = "20", so I think that made me more likely to run into some race conditions.
This PR includes fixes for two problems I encountered on my build. Let me know if you think anything should be different.
Thanks for the meta layers! Can't wait to get the 0x64 into a state where I can use it for Zigbee automation.
Fix for python3-native dependency and unnecessary RDEPENDS.
When I attempted to build, I noticed that it was compiling Python 3 for bl808-firmware. This was unnecessary since python3 is installed on the system and is included in the native-path by python3-native. Upon investigation, I found the Python core dependency in RDEPENDS. Since the bl808-firmware task does not install programs that are used within the Linux runtime on the target, there are no need for runtime dependencies. This change removes the RDEPENDS and removes python3-native from DEPENDS because it is already included within the python3native.bbclass. Also, I've changed the shebang line at the top of "mergebin.py" to use the python3 in PATH from the bitbake native-path. This ensures that the task runs using the python3 given by bitbake if it's ever different than the system python3.
Fix for bl808-firmware do_install dependencies
When using DEPENDS, bl808-firmware.do_prepare_recipe_sysroot requires opensbi.do_populate_sysroot. do_populate_sysroot can happen before do_deploy, so do_deploy for opensbi does not always complete before do_install in bl808-firmware is attempted.
A simplified dependency graph from "task-depends.dot" as it is now is:
bl808-firmware.do_install -> do_compile -> do_configure -> do_prepare_recipe_sysroot -> :

opensbi.do_populate_sysroot -> opensbi.do_install (does not depend on on_deploy)
u-boot.do_populate_sysroot -> u-boot.do_install (does not depend on on_deploy

This proposed fix explicitly states that do_install for bl808-firmware depends on do_deploy for both u-boot and opensbi. The graph after this fix looks like:
"bl808-firmware.do_install" -> "opensbi.do_deploy"
"bl808-firmware.do_install" -> "u-boot.do_deploy"
This ensures that the required blobs are in the deploy directory before they are copied in do_install.

Thanks!


Feat: Add support for sumDouble and supporting functions for Double

Is your feature request related to a problem? Please describe.
Currently an attribute of Double type can't be summed/operated upon in a constraint creation stream.
Describe the solution you'd like
Please add support for Double/ other data types.
Describe alternatives you've considered
Writing own sumDouble and other functions
Additional context
Add any other context or screenshots about the feature request here.

Thank you for reporting the issue!
Unfortunately, we will not be implementing this feature; double is intentionally omitted.
You can read why.
If you absolutely need to, you can implement your own sumDouble by looking at the implementation of sum or sumLong. However, my recommendation is to avoid it and either use BigDecimal or fixed-point arithmetic.


Update CREATE PROPERTY and ALTER PROPERTY

Add remark for min and max attributes in CREATE PROPERTY
Add remark for min and max attributes in ALTER PROPERTY
Add example for default sysdate() in CREATE PROPERTY

Not sure.if we have test cases with default sysdate()


Support page up/down keys for command history

Add support for using page up and page down keys to instantly move thru command history.
current up/down key support is good, but can be slightly frustrating with it's added "move to beginning/end of line" behaviour

implemented and released as part of 2.2.0


some fixes in this fork https://github.com/devloic/AzuraCast-Player

Hi,
thanks for your code.
I added some little fixes to AzuraCast-Player you might find relevant:

fixed some scss deprecations
added "serve": "http-server . -p 8484 -a localhost" script to package.json ( webpack serve might be better but my understanding on how to migrate webpack.config.js is limited)
added @error="$event.target.src=apiBaseUrl()+'/static/img/generic_song.jpg' so if a azuracast playlist has no image it will use the default azuracast icon ie generic_song.jpg
changed "toText" filter so it doesn't strip accents for languages that use accents or umlaut (ex:  è, é, ê, ë...)
changed .jpg to .png filename which was needed in my specific setup ( might be worse finding a trick to make detection automatic or add it as config parameter)

plans:

add the player to the azuracast docker image
make it work for a single station (no sidebar) or multiple stations (sidebar)

Hi @devloic,
Thanks if you like this code and for add future for this code. This code is free for developing and add some future.

It is using Vue 2 right ? would it be complicated to migrate it to Vue 3 ?

Yes with Vue 2. Actually not to be complicated if want to migrating to Vue 3 if with current future.


Microsoft website clone

Describe the project you want to add with tech stack
Clone of Microsoft website using HTML,CSS and JS
Expected behavior
Fully responsive and functional
Screenshots (optional)

Additional context (optional )

@MohitGupta121 Can you please assign this issue to me under GSSOC'23


Test format on save

Test for #12449

[ ] any os
[ ] any os

We added support to format a document on save. Please test that

there is a setting editor.formatOnSave and that the setting is documented and a good fit
format on save won't work and auto save is on
format on save works with all the other save options (focus lost etc)
format on save produces the same result as the format action from the context-menu would

@jrieken I'm assuming this also covers #239.

@chrmarti I have added https://github.com/Microsoft/vscode/issues/12640 for that

#12827 is the only "issue" I found with this feature.

Small thing, I would just put a comma after the conjunction "and" so it's not a run-on sentence.


Implement /v1/oauth2/token

Grant Type
Minimum Requirements

[X] authorization_code

[x] PKCE #1

[X] refresh_token

MVP Requirements

[ ] device_code

Refactor Completed.


Calling forms programmatically

Hi,
I have installed the django-forms-builder in my aplication. This way unexperienced admins could create forms that I use to call services.
The problem is that, until now, I created the forms programmatically and generate the interface this way:
    def serviceInterface(request):
    if request.method == 'POST':
            service = Script.objects.get(exeName=request.POST.get('exeName'))
            files = listUserFiles(request)
            myForm= getattr(forms, service.form)
            form = myForm(user = request.user, request = request)
            return render(request, 'serviceInterface.html', {'name': service.name, 'exeName': service.exeName, 'files': files, 'form': form})

and in my forms.py:
class serviceForm(forms.Form):
    filename = forms.ChoiceField(label="Filename", widget=forms.Select(attrs={'class':'selector'}))
    K = forms.CharField(label='K', max_length=1)
    fullOut = forms.CharField(label='fullOut', max_length=1)

The problem here is that I can't get forms generated by the django-form-builder. How could I get them? I can port all my forms to django-form-builder and modify my serviceInterface view

Can't help you there, you might like to try stackoverflow or the django-users mailing list.


chore: bdd-sbhg-1587813777 to 0.0.1

chore: Promote bdd-sbhg-1587813777 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


⁉ ⁉

requirements

token type(one of web protocol, padlocal, paimon, wxwork, and more ...) [required]
version of python-wechaty [required]
version of wechaty docker image [optional]

Describe your problem

A clear and concise description of what the bug is.

Reproduce your problem
simple code to reproduce your problem

Error info
# copy your log info at here from your terminal

Your experiments

please tell us your experiments and ideas about this issue. It's valuable for us to help you find the solution.

想请教一下，哪儿出错了

There is qrcode display error which depends on the font-size of your terminal. So you can use cmd or powershell to run the application to display login qrcode which only display in login stage.
Whats's more, there are some requirements info you have lost in the description. So I hope you can comment it later, so we can help you fix the issue.  Please feel free to tell us more.

2022-04-17 12:10:39,648 - Wechaty - INFO - receive  event <EventScanPayload(status=<ScanStatus.Scanned: 3>, qrcode='https://login.weixin.qq.com/l/4bw6p9I8Gw==', data=None)>
2022-04-17 12:10:39,648 - Wechaty - ERROR - internal error <>
2022-04-17 12:11:12,850 - PuppetService - INFO - receive error info <{'data': '登录失败。'}>
2022-04-17 12:11:12,850 - Wechaty - INFO - receive  event <EventErrorPayload(data='登录失败。')>
2022-04-17 12:11:12,851 - Wechaty - ERROR - internal error <Uncaught, unspecified 'error' event: EventErrorPayload(data='登录失败。')>
您好，这个应该不是窗口大小问题，我换cmd或powershell登录也是扫码后，显示登录失败

If you are using WeChat web protocol, it will fail in most of account. I suggest that you get the padlocal or pamion token to start your bot.


Probably wrong translation for button "Convert to book" / "In Buch umwandeln"

Describe the Bug
Hi Dan,
I am actually not sure if this is a bug or not. :)
Shouldn't the "In Buch umwandeln" button be called "Buch in Regal umwandeln" in this section (see attached screenshot)?

Settings are in the german translation "Deutsch (Du)".
If I switch the language to english, the button also seems wrong. Shouldn't it be called "Convert book to shelf"?

Thank you and cheers
Daniel
Steps to Reproduce

Edit a book
See wrong translation or not (Maybe I'm misunderstanding the function here?) :)

Expected Behaviour
Nothing, if I misunderstood the function. If not, little changes to the translation.
Screenshots or Additional Context
Already provided above.
Browser Details
No response
Exact BookStack Version
v23.12.2

Hi @eldan0815,
The "Convert Book" English text seems fine to me, since pressing the button will convert the book to a shelf.
Button text is usually short, and I don't see the need for the full "Convert book to shelf" text since the context is provided by the card/section that button sits within.
I don't know German well enough to have opinions there.
If you believe there's a better suggestion feel free to join the translation project on Crowdin to update translation text.

The translation is indeed wrong, but only exists in the informal German translation.
I updated the value on crowdin to match the english "convert book" which should be sufficient since the text above explains what happens

@lommes Thank you very much.
@ssddanbrown Thank you, I will join the translation project next time (if @lommes isn't so fast ;) )

Thank you @lommes for updating!
And thanks @eldan0815 for reporting and for looking to get involved.
I'll therefore close this off.


Fix rounding error in Clip Content [4.0]

Rounds the position and size of the final clip rect to avoid flickering issues.
Fixes https://github.com/godotengine/godot/issues/46493
3.2 version: https://github.com/godotengine/godot/pull/46495

Before (notice the artifact at bottom and clipped edge at the top)

After (notice the smooth edge at the top)

Thanks!


how to execute code when browser closed?

What versions are you running?
$ go list -m github.com/chromedp/chromedp
github.com/chromedp/chromedp v0.7.6
$ google-chrome --version
Google Chrome 95.0.4638.54
$ go version
go version go1.17.2 linux/amd64

What did you do? Include clear steps.
how to execute code when chrome window closed by user?
for example, by clicking the close button at top right, or by closing all tabs.

in case someone is looking for the answer, this seems to work:
ctx, cancel := ...
go func() {
  <-chromedp.FromContext(ctx).Browser.LostConnection

  /* do something on browser exit */
}()


[tool_crash] ProcessException: Operation not permitted Command: /Users/user/apps/android/gradlew, OS error code: 1

Command
flutter --no-color build apk

Steps to Reproduce

...
...
...

Logs
ProcessException: Operation not permitted Command: /Users/user/apps/ 2/android/gradlew, OS error code: 1

[✓] Flutter (Channel stable, 1.22.6, on macOS 13.5 22G74 darwin-arm, locale en-ID)
    • Flutter version 1.22.6 at /Users/xx/fvm/versions/1.22.6
    • Framework revision 9b2d32b605 (2 years, 7 months ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/xxx/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/xx/Library/Android/sdk
    • Java binary at: /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_371-b11)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[!] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    • CocoaPods version 1.12.1

[!] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[!] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • Redmi Note 8 Pro (mobile) • r8yh596dhmr4ztbu • android-arm64 • Android 11 (API 30)

! Doctor found issues in 4 categories.

Flutter Application Metadata
Type: app
Version: 2.0.3+16
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 2ae34518b87dd891355ed6c6ea8cb68c4d52bb9d
Plugins
flutter_map_arcgis-1ed33275d4ee08de57fe610499b6a87dc628b845
flutter_plugin_pdf_viewer-85e5b127b7fa8a3b4d5b77b7484efcaa6d99c90a
connectivity-2.0.2
connectivity_for_web-0.3.1+4
connectivity_macos-0.1.0+7
file_picker-2.1.7
firebase_core-0.5.3
firebase_core_web-0.2.1+1
firebase_messaging-7.0.3
flutter_keyboard_visibility-4.0.6
flutter_keyboard_visibility_web-1.0.1
flutter_native_image-0.0.5+3
flutter_native_timezone-1.0.4
flutter_plugin_android_lifecycle-1.0.11
gallery_saver-2.0.3
geocoding-1.0.5
geolocator-6.2.1
geolocator_web-1.0.1
image_picker-0.6.7+22
image_picker_for_web-0.1.0+2
package_info-0.4.3+4
path_provider-1.6.28
path_provider_linux-0.0.1+2
path_provider_macos-0.0.4+8
path_provider_windows-0.0.4+3
phone_number-0.6.3
search_choices-1.0.17
share_plus-1.2.0
share_plus_web-0.1.0
shared_preferences-0.5.12+4
shared_preferences_linux-0.0.2+4
shared_preferences_macos-0.0.1+11
shared_preferences_web-0.1.2+7
shared_preferences_windows-0.0.2+3
sqflite-1.3.2+4
url_launcher-5.7.10
url_launcher_linux-0.0.1+4
url_launcher_macos-0.0.1+9
url_launcher_web-0.1.5+3
url_launcher_windows-0.0.1+3
webview_flutter-0.3.24

Hi @muchlisre , you are on an older version of flutter. Kindly upgrade to the latest version of flutter. This issue was reported in https://github.com/flutter/flutter/issues/50880 and has since been fixed.
Closing this as it has already been fixed.
If you still experience this issue after upgrading to the latest version of flutter, kindly leave a report below.
Thank you


TypeError for init() when migrating

File "manage.py", line 15, in
execute_from_command_line(sys.argv)
File "/home/kbhide/django/django/core/management/init.py", line 366, in execute_from_command_line
utility.execute()
File "/home/kbhide/django/django/core/management/init.py", line 342, in execute
django.setup()
File "/home/kbhide/django/django/init.py", line 24, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/kbhide/django/django/apps/registry.py", line 112, in populate
app_config.import_models()
File "/home/kbhide/django/django/apps/config.py", line 198, in import_models
self.models_module = import_module(models_module_name)
File "/usr/lib/python3.5/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 673, in _load_unlocked
File "", line 665, in exec_module
File "", line 222, in call_with_frames_removed
File "/home/kbhide/.local/lib/python3.5/site-packages/helpdesk/models.py", line 26, in
class Queue(models.Model):
File "/home/kbhide/.local/lib/python3.5/site-packages/helpdesk/models.py", line 227, in Queue
verbose_name=('Default owner'),
TypeError: init() missing 1 required positional argument: 'on_delete'
While running  ./manage.py migrate helpdesk. I get the above error I followed all the steps on
http://django-helpdesk.readthedocs.io/en/latest/install.html#adding-to-your-django-project
Can some one help me with this.

Hello! Looks like you're using our current release (0.1.18) on Python 3, which isn't fully supported. The master branch supports Python 3. I intend on releasing version 0.2.0 which supports Python 3 in the next few days after some last minute tests, either check out master or give 0.2.0 a shot when it comes out.

Hi Garret.
I checked-out the master branch with  git clone -b master https://github.com/django-helpdesk/django-helpdesk.git
later I installed it with python3 setup.py install
But still I get the same error:
Traceback (most recent call last):
File "./manage.py", line 15, in
execute_from_command_line(sys.argv)
File "/home/kbhide/django/django/core/management/init.py", line 366, in execute_from_command_line
utility.execute()
File "/home/kbhide/django/django/core/management/init.py", line 342, in execute
django.setup()
File "/home/kbhide/django/django/init.py", line 24, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/kbhide/django/django/apps/registry.py", line 112, in populate
app_config.import_models()
File "/home/kbhide/django/django/apps/config.py", line 198, in import_models
self.models_module = import_module(models_module_name)
File "/usr/lib/python3.5/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 673, in _load_unlocked
File "", line 665, in exec_module
File "", line 222, in call_with_frames_removed
File "/usr/local/lib/python3.5/dist-packages/django_helpdesk-0.2.0-py3.5.egg/helpdesk/models.py", line 22, in
class Queue(models.Model):
File "/usr/local/lib/python3.5/dist-packages/django_helpdesk-0.2.0-py3.5.egg/helpdesk/models.py", line 261, in Queue
verbose_name=('Default owner'),
TypeError: init() missing 1 required positional argument: 'on_delete'

Sorry! I didn't look too closely, I saw you were using Py3 and hoped that would fix it.
What version of Django are you using? Are you using a beta or master for django? on_delete shouldn't be required until Django 2.0 according to this page and the demo project seems to work well for me under Py3 + Django 1.11, so I'd have to dig in more if that isn't the case.

my django version is 2.0.dev20170827005745

Hmm well somehow you ended up with the development branch of django 2.0 (it hasn't been released yet). Django 2.0 makes a bunch of changes and I haven't checked for them yet. We only support Django 1.11. I think you can do something like pip install django=1.11 to install a particular version. Please give that a try and let me know if it fixes the problem. I'll have to update our documentation to say we don't support Django 2.0 in this upcoming release. Thanks!

Thanks, it works now.

Awesome! I updated our documentation to say that only Django 1.11 is supported in the next release (0.2.0). Let me know if you have other questions but I will close this for now.


ci: add versions fixture generator for Red Hat

This adds a semantic fixture generator for the Red Hat ecosystem - as this ends up being just under 2mb, I've not committed the file like the others, instead making the test suite only use it if it's actually present.
It works by leveraging rpms built-in Lua interpreter, which includes exposing the vercmp function meaning we can have rpm tell us what the result of comparing two versions are so long as there's a version of that available.
In terms of actually getting a version of rpm, that turns out to be a lot harder with Docker I assume just because CentOS & co is a less open-source-y distro vs the others; there are images, but they're all generally very big. In an interesting twist though it turns out Debian actually ships a version of rpm for building and the like - it has had it's package management abilities neutered, but that's not something we need so a simple apt install rpm gives us the dependency we need.

Semantic / generate-redhat-versions (pull_request) Successful in 15m

nice, that's a very reasonable "worst case with no cache" time given the size
(as a reminder, Debian is also pretty big typically taking 5+ minutes, but with caching it only takes ~20 seconds 😄)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.55%. Comparing base (ce6950e) to head (add759d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   68.43%   68.55%   +0.11%
==========================================
  Files         183      184       +1
  Lines       17620    17762     +142
==========================================
+ Hits        12058    12176     +118
- Misses       4898     4920      +22
- Partials      664      666       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Suggestion: Command line flag for "browse"

It would be nice to have a command line flag to turn on "browse".
I often use caddy to quickly transfer files from one computer to another, and to have browsing functionality, I have to start it for example:
echo "<IP_ADDRESS>:2015\nbrowse" | caddy

It would be better just to write
caddy -b

or similar :)
Keep up the good work!

Thanks. I agree it could be even easier to spin up certain features directly from the command line. Will take a look at this!

Thank you, Matt!

+1, I was thinking maybe a set of predefined configs that we can call "modes"  or something. Something like:
$ caddy -mode browse

I suspect there will be at least a few common scenarios that people will want, but browse is probably the most common indeed.

^ That's a good idea. Let's assume caddy can build its own internal, ephemeral Caddyfile based on command line inputs like this (this example shows all available keywords):
$ caddy --enable browse,errors,gzip,log,markdown,templates

would produce this Caddyfile internally:
<IP_ADDRESS>:2015
browse
errors error.log
gzip
log
markdown /
templates

But of course, you could do just caddy --enable browse which only turns on the "browse" directive. I haven't examined the plausibility of this, but it seems very useful as you've said. Feel free to refine this idea further.
Anyone is also welcome to get started on it before I do. Probably wouldn't be too hard; there's a function in main.go called loadConfigs which might be a good place to start.

Maybe this deviates too much from the Caddyfile format, but could support these as normal command args, like caddy [enable...]
$ caddy browse
$ caddy browse errors=error.log gzip

Ideally the Caddyfile format would be perfectly backwards compatible, except one argument per arg (quoted if necessary) rather than one argument per line. Might make sense to make the Caddyfile format also work with =, then. Such as:
browse
errors=error.log
gzip

Maybe taking this too far, though. :)

Adapting your idea slightly, consider:
$ caddy "browse, errors error.log, gzip, header { ... }, "

We can leave the Caddyfile syntax the same but when parsing it from the command line like this, we just replace commas with newlines, and presume the address is the default. It'll work only for one listener (the default, unless modified by -host or -port flags) but it'll get you up and running quickly:
$ caddy browse

How about that?

What's the benefit of bundling all the options into one big argument string, rather than separate ones? Could even stick with no = if that's what's bothersome (now that I think of it, that addition is superfluous anyways—it just reads a bit better in the cli).
$ caddy "browse" "errors error.log" "gzip" "header"

Quoting an argument merges into one Arg slot, so it'll be really easy to parse. Quoting is optional if it's just one thing, so:
$ caddy browse

will still work as desired; as will
$ caddy browse gzip

and other quick shortcuts like that.
I feel like having to quote the entire thing is going to be more harm than good unless we're expecting to add more positional arguments that are unrelated to the config.

The only reason I suggested containing it in quotes is to keep the parsing simple. With an arbitrary number of arguments, we need to distinguish stuff like this:
$ caddy -quiet -host=abc.com -port=1234

from this:
$ caddy header / { -host }

(Slightly contrived I know, but imagine there's a header called "host" that they want to strip from the response for some reason.) And what if the user wants want to do both?
$ caddy -quiet -host=abc.com -port=1234 header / { -host }

We either need to specify a certain order/place for the Caddyfile content to appear in the arg list, like requiring it to be last, or stick to the flag convention a little more.

Right, you'll need to quote anything that is not a single word. This should work with the flag module without any extra work, though:
$ caddy -quiet -host=abc.com -port=1234 "header / { -host }"

Although, if we use commas as separators, comma value escaping will still be required, whereas quote position arg escaping is already done by every flag parser.

Yeah, I think that'll be fine. This is just supposed to be for simple Caddyfiles anyway. :stuck_out_tongue:

Thank you guys!
My personal use case is when I occasionally run Caddy on my Android phone to share a directory with people on the same WiFi for 10-15 minutes; since I have to type everything on a tiny-tiny keyboard, I'm very happy about every character saved (especially special ones)... :)

^ First actual use case I've heard of on Android. Awesome :+1: We're on it.

I submit a PR #234 as a start to work on this

Merged! You can now pass configuration without flags:
$ caddy browse

will do what you want @kkovacs, and similarly:
$ caddy browse "log acccess.log" "errors error.log" gzip

should work.


Meeting minutes on Friday

Tasks are assigned as follows:

Get deployment done.  Joey
Get the dashboard roughly done.

[x] Left world map. Ben
[x] Right charts - two bar chart. Joey
[x] Right chart - one pie chart. Hayley
[x] Right chart - partition chart. Ian
[x] compile files and improvement. Ben

Readme file - Hayley
Reflection - Ian

Tasks done


[Bug] Sass linter wrong errors for Sass each over a map

VSCode Version: 0.1.2
OS Version: Mac OSX El Capitan

Steps to Reproduce:

Paste this into a new file with Sass syntax:

@each $color, $hex in $colors {

  .color-#{$color} {
    color: $hex;
  }

  .border-#{$color} {
    border: 1px solid $hex;
    border-radius: 2px;

  }

  @each $side in ('top', 'left', 'right', 'bottom') {
    .border-#{$side}-#{$color} {
      border-#{$side}: 1px solid $hex;
      border-radius: 2px;
    }
  }

  .background-#{$color} {
    background: $hex;
  }
}

Current output:

The errors of the linter:

Duplicate of #1758 (?)

Not exactly dup but related, the issue he has is when declaring maps, which i also have (just checked my $colors map), but mine is when using the map with an @each to generate styles, however it's worth mentioning that the base of both is that map syntax is still not supported.

@Luchillo It might work in the latest insider build, see https://github.com/Microsoft/vscode/issues/7434#issuecomment-225379421.

Ok, but for now i will stick with the style extension mentioned, i'll test when the official release is out.

Sorry, there hasn't been any work on SCSS map support yet.

Duplicate of #1758


when  select  from  a  as400 table  when the  data  is  "0001-01-01" throw  an  exception
sql  error 181 01534: sql0181 value in  date time  or  timestamp  string  not  valid

The reason can be similar with https://github.com/dbeaver/dbeaver/issues/9378

I'm afraid we can't fix this from dbeaver side. It is a jt400 driver exception.
Please see https://stackoverflow.com/questions/13447252/as400-database-access-via-jdbc
Perhaps adding connection properties ;date format=iso;time format=iso; will solve the problem.

I'm afraid we can't fix this from dbeaver side. It is a jt400 driver exception.
Please see https://stackoverflow.com/questions/13447252/as400-database-access-via-jdbc Perhaps adding connection properties ;date format=iso;time format=iso; will solve the problem.

This resolved my issues. Thanks @serge-rider.


Mutiworld not working

When Me and my brother try to connect the multiword services it won't let us connect. Do you know what the problem is and how do I fix it?

Whoops, sorry about that! I transitioned hosts, and apparently I flubbed up a config. Can you give it another go when you have a chance?

Looking at the logs, it seems like someone played a full game on the 18th. Considering this closed unless we hear back about other issues.


Feature/add docker

add Docker files to mock profile and content api so basic e2e tests can be run

Coverage remained the same at 83.065% when pulling 163dc636d0b596ad1b9d8a3d541f42e698387474 on feature/add-docker into 057dd418d357fcedc0fb065f4f71adf212337779 on develop.


⬆ AZ CLI Version update and prepare next release

Bumped AZ CLI to 2.15.1
Prepare next release with same AZ CLI version and Terraform 0.14.0-rc1

Need to correct the lint-build-test action
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/


Display added Activites on map

Value proposition
As a user,
I want to to see added activities on map
so that i can see where they are located
Description

Acceptance criteria

[ ] activities added by the user should also be displayed on the map
[ ] activities should display onclick tooltip with name and location on the map
[ ] Activities will be added through navigation "Add"
[ ] "Add" opens an overlay to add activities no matter on which page the user is at that moment

Complexity
medium
Tasks

[ ] Create branch
[ ] Inputfield "location" musst handle input in a way to get longitude & latitude from that location
[ ] update spec for ModalInput

Hey Ben,
great feature! :)
Please see my comments on your previous user story. Same principles apply here.
As well you wrote:  Inputfield "location" musst handle input in a way to get longitude & latitude from that location
I would add in the acceptance criteria how the user will input the location, meaning will the user be able to enter any location or does a dropdown menu appear with suggestions for existing locations... or does the user even need to type in the coordinates?
And one more question: What do you mean by "ModalInput"? It sounds a bit confusing as your input field is not a modal, I assume 🤔 maybe it's best to rename that.

Updated scribble and AC


"a.y is not a function" when writing a property called "y" from javascript into an object

I just stumbled upon this problem:
I define a class in scalajs, export it to javascript and run it through fullOpt.
Then I create a new instance from that class from javascript and set a field, which is not defined in the class. In my case y.
Then javascript crashes with the following error: a.y is not a function.
The error makes sense. The optimizer cannot know what I write to the object from javascript and runtime and uses these short names as minified/optimized internal function names. So this name-clash can occur.
This was very strange to me in the first place, because the error occurred in production, but not in development mode.
I was able to worked around this by specifying the member y in the class:
@JSExport def y(): Int = -1

using a var or def without () was not working, I cannot explain why.
I think this should be mentioned in http://www.scala-js.org/doc/export-to-javascript.html, to prevent others losing lots of time on such an error.
Are there any other thoughts on this?

Hi,
It is indeed against the specification to add a field to a Scala.js class that does not export it. Actually even your exporting a def y() and then setting y from JS is against the spec, and could break.
What you have to do is to provision for the field and declare it as an @JSExport var y: Int = -1. The type should also be correct, so if it's Int you can only put an integer in that field. With an exported var, your JS code doesn't have to create a new field, and therefore you're in-spec.
It doesn't fail in dev mode because the dev mode uses longer names. In particular nothing could be named y in dev mode, but that's an implementation detail of the current impl. I guess we could seal all Scala.js objects in dev mode to highlight this error earlier.

As mentioned above, using var also was my first intuiton. But now - I tried it again - it fails with the same error message.
Sealing sounds like a good idea to prevent confusion.

If var does not work, I would very much like a reproduction. It might be a bug.

I'm very busy right now, but I'll come back and make a reproducible example.

Ping @fdietze

Closing as there was no follow up.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

:tada: This PR is included in version 7.0.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: add script to update contract uri of a voucher

Codecov Report

Merging #463 (466b986) into main (82833ed) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 466b986 differs from pull request most recent head 4894b66. Consider uploading reports for the commit 4894b66 to get more accurate results

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   54.65%   54.65%
=======================================
  Files         127      127
  Lines        3692     3692
  Branches      629      629
=======================================
  Hits         2018     2018
  Misses       1674     1674

Flag
Coverage Δ

common
84.82% <ø> (ø)

core-sdk
51.22% <ø> (ø)

eth-connect-sdk
18.30% <ø> (ø)

ethers-sdk
67.12% <ø> (ø)

ipfs-storage
94.02% <ø> (ø)

metadata
97.56% <ø> (ø)

unittests
54.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP: add support for direct scan-out

This adds support for direct scan-out. This is a required feature before working on planes.
This PR tries to to as little changes as possible to make it easy to review and avoid re-writing everything. The current DRM backend and interface are not great but refactoring can happen incrementally with future PRs.
This PR is missing a lot of checks. I first wanted to make sure this actually works. I've tested with a modified version of weston-simple-dmabuf-egl. Depending on your hardware it might be easier or more difficult to test.
A new wlr_output_set_dmabuf function has been introduced. It's a bad name if we keep it that way. It does the same thing as wlr_output_swap_buffers without actually rendering. Then plan was originally to also add a wlr_output_commit/present function, but I'm not sure how to implement it for the Wayland and X11 backends.
I'm not sure wlr_dmabuf_attributes is the right data structure to use. Thoughts?
Fixes https://github.com/swaywm/wlroots/issues/193

Proposal:
// Same as wlr_output_make_current
bool wlr_output_attach_render(struct wlr_output *output);
// Instead of rendering to a buffer, use an existing DMA-BUF
bool wlr_output_attach_dmabuf(struct wlr_output *output,
	struct wlr_dmabuf_attributes *attrs);
// Submit a frame
bool wlr_output_present(struct wlr_output *output); // or commit, see #1640

This is now working pretty well. Apart from the API not being final yet, there is one more issue: synchronization.
When compositing, we can send wl_buffer.release as soon as we've swapped buffers, because implicit synchronization will take care of holding the buffers until we've finished drawing.
When scanning out, we need to wait for the buffer to stop being visible before sending wl_buffer.release. I've implemented this in https://github.com/swaywm/wlroots/pull/1641/commits/27ee4bd9110e2fb350f2ad9100ad13ca2c21c8df by making rootston reference the wlr_buffer when scanning out. It works, but I'm not a fan of this approach: rootston can only guess when the backend is done with the buffer. Here with the DRM backend it needs to hold the buffer for two pageflips (because we draw right after pageflips, so there is one whole pageflip during which the buffer has been drawn and submitted to DRM but it's not yet visible). For the Wayland backend it would need to wait differently (depending on the wl_buffer.release signal of the parent compositor).
To fix this, I think the most straightforward solution is to pass the wlr_buffer to the backend. Thoughts?

All right, this is ready for review. Note that on Intel, I915_FORMAT_MOD_Y_TILED can't be scanned out and is used by default on my machine (so you need to disable it to test direct scan-out).
Here is a patch that adds debugging logs and disables I915_FORMAT_MOD_Y_TILED: https://sr.ht/nd2t.diff

Ping

I'm no expert on the implementation details, but the API looks solid and there are no obvious mistakes.

Thanks!


packet: Use user-specified pool name for TF pool

This patches are extracted from https://github.com/kinvolk/lokomotive/pull/119. I found a bug in the code that I needed to change for that PR, so I fixed it.
That PR is not yet ready to be merged, so I'm including the fixes I found while writing it in this PR. Most of the commits are cosmetic (create a function for this and that) and make way more sense when PR #119 is merged, as those functions will not be so simple. To keep the backport simple, I decided to include them here, though
The fix is in patch: packet: Use user-specified pool name for TF pool, all the rest are cleanups or cosmetic changes. I c&p here the commit message from that patch, as it explains quite well what is doing and why it is important (let me know if I'm missing something!):
Before this commit, the pool name specified in lokoctl was being
completely ignored. The terraform code just iterated over the worker
pools, and the first one was named "pool-0", second "pool-1", etc.
This can create confusion for the user (an error on "pool-1" when the
name was "foo" is not meaningful, is difficult to know to which pools
servers belong). But, WAY more importantly, if the user reorders the
pools in the lokocfg file (or if for some reason that order is not
guaranteed by golang), it will create a mess in terraform.
This patch just makes that part sane: the terraform worker pools are
created with the user specified name. Therefore, errors in terraform are
meaningful to the user, the user can match servers hostnames in Packet
and can re-order pools without making terraform go nuts.
Also, this patch adds adds a check that all pool names are different

Since @rata is on vacation today I fixed the review comments that made sense to me. PTAL.

@invidian @iaguis thanks!


"CVV_FORMAT_ERROR" - Reason Unknown

I'm getting the "CVV_FORMAT_ERROR" even though I'm clearly sending through this object:
cardCvx: "123",
cardExpirationDate: "1219",
cardNumber: "4706750000000033"
Any thoughts onto what could be going wrong. I'm assuming the cardregistration.init works seeing as it does not throw up an error.
Thanks

me too, do you have fix it??? please help me, thank you so much

Hello @scottwooden, @yendevy97,
Could you tell me what kind of card you are trying to register?
It will be very helpful.
Thanks a lot.
Mickaël

As @mickaelpois said, make sure you send correct CardType.
If you don't send it, the https://github.com/Mangopay/cardregistration-js-kit/blob/master/kit/mangopay-kit.js#L299 will always return false.
This parameter is not optional, as it is with the server-side cardRegistration.create https://docs.mangopay.com/endpoints/v2.01/cards#e178_create-a-card-registration
The possible values for the cardType are [MAESTRO, BCMC, AMEX, CB_VISA_MASTERCARD], which is different from possible values for the server-side cardRegistration.create (check in the link above).
Also check carefully the case of the arguments you are passing to all the functions.
I had some problems when I directly passed the output of cardRegistration.create from https://github.com/Mangopay/mangopay2-nodejs-sdk/blob/master/docs/CardRegistrations.md to this cardkit.
The object returned has capitalized field names (as specified in https://docs.mangopay.com/endpoints/v2.01/cards#e177_the-card-registration-object), and the kit expects lowercase field names.
The errors returned are non-obvious.


TodoTrouble issues

If I haven't launched Trouble before and I launch TodoTrouble, it launches Trouble with all files in the cwd. However, if Trouble has already been launched, TodoTrouble will throw an error, saying that the buffer ID is invalid. In other words, TodoTrouble is not working.
The error I get after launching Trouble, then TodoTrouble:
Error executing vim.schedule lua callback: ...myNeovimPackages/start/trouble.nvim/lua/trouble/view.lua:452: Vim(luafile):E5113: Error while calling lua chunk: ...start/todo-comments.nvim/lua/todo-comments/highlight.lua:284: Invalid buffer id: 17
OS: NixOS Unstable
Neovim: Nightly
I'm lazyloading the plugin on BufRead and BufNewFile using autocmds that run packadd and luafile.
I can try to provide more details as necessary.
EDIT: After hitting enter on the error, TodoTrouble launches as usual. However, if I close it and launch it again after that, the same issue will happen as if I launched it before launching Trouble (it launches Trouble with all files in cwd).
EDIT 2: It seems that it always throws an Invalid buffer id error, and the ID is always the same as the newest buffer's ID + 1. I've tested this after opening one buffer, as well as after opening multiple buffers.
EDIT 3: The problem goes away entirely if I stop lazyloading the plugins (todo-comments and trouble), but I want to lazyload to keep loading times down. If I find a fix, I'll relay.

I just pushed an update that might fix your issue.
I'm also lazy loading those two plugins, but don't have the issue you mentioned

I found out that the way NixOS handles plugins incorrectly, so the issue may be on my end. I'll update if I find any new info. In the meantime, thanks!


Add support for Pester 4.x.x

Add support for both Pester 3.4.3 and 4.0.3 by including both modules within the tasks
Default to 3.4.3 to provide consistent behaviour with previous versions.
Allow the user to choice the version with a drop down list in the advanced section (or they can use any other version by overriding the load path as before)

Added in 5.0.7


Unify the behavior when the result of any request is empty

Use 204 No Content rather than 404 Not Found for HTTP status code


Nv websocket client - subscription stopped callback and select the looper for callbacks

Add callback that is executed whenever a subscription stopped and there are no listeners waiting for it (i.e. after subscription is ready).
Added option to select the looper that all callbacks will be fired on. This already makes sure that callbacks are fired on the user thread.
Exposed getLoginToken() so that other access methods (REST calls) can use the same login information.

Very much appreciated, thank you!
In general, it is better to create separate pull requests for individual features, but we'll be able to dissect this pull request into its original parts here.
It is closed because the target branch does not exist anymore (it was not created against master).
Regarding the looper: Why did you need to set it manually? Right now, all callbacks should execute on the UI thread already. And if you don't want that, you probably don't want another specific thread but the calling thread (in each individual case), right?

Will do a commit per feature next time.
Regarding the Looper: I have a background thread that works with Meteor (not he UI thread). So it is more convenient to have all Android-DDP callbacks issued on my background thread (using its Looper) instead of having to handle moving the callback event from the UI thread to my background thread.
And, if I understand your comment regarding the correlation between the calling thread and the callback thread, I would not tie both of them together and leave the flexibility to the developer (i.e. call Android-DDP from any thread and receive callbacks on the selected Looper thread).
Thanks,
Shai


[Backport 2.6.x] Resource re-watch

What we did in https://github.com/rancher/dashboard/issues/5997 needs to go into 2.6.x.

@richard-cox may have done this already.

Duplicate of https://github.com/rancher/dashboard/issues/7707, closing


leap with langmap

,s{char1}{char2} and then pressing (for instance) a movement key, results only in leap exit, no movement happens.

This has been already solved with a workaround: for russian mapping we have empty safe_labels, which means you always have to press the  third key.


[Do Not Merge] New Swagger specification for Microsoft.SqlVirtualMachine Resource Provider.

The SQL IaaS Team is adding a new Resource Provider. This Swagger contains all the restful operations that can be performed by the customers.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x ] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Adding @jaredmoo.

Automation for azure-sdk-for-node

Can one of the admins verify this patch?

You will need a readme.md. I can help you with this.

@pratraw is added to the review. #Closed

@seliu is added to the review. #Closed

@yareyes could you address comments from @jaredmoo ?

@sergey-shandar comments have been addressed.

The description updates are great, thanks!


Day47: 'Binary Tree Zigzag Level Order Traversal' solution

Binary Tree Zigzag Level Order Traversal
https://leetcode.com/problems/binary-tree-zigzag-level-order-traversal/
Given the root of a binary tree, return the zigzag level order traversal of its nodes' values. (i.e., from left to right, then right to left for the next level and alternate between).

Example 1:
Input: root = [3,9,20,null,null,15,7]
Output: [[3],[20,9],[15,7]]
Example 2:
Input: root = [1]
Output: [[1]]
Example 3:
Input: root = []
Output: []


fix(hls): Support playing media playlists directly

Closes #3536

You have a new test that needs to be updated with the new default codec string.  Looks good otherwise, though.


File-uploads folder should be configurable

Currently BodyHandler in server verticle requires file-uploads path for storing file uploads. It's required to have this path configurable on Server verticle level.

Already fixed in #320


add versioning the HubEvaluationModuleFactory

This PR couples the module repositories on the hub with the main repository in evaluate, based on tags that are propagated from evaluate to each space when they are pushed to the hub via actions (see evaluate/.github/hub/push_evaluations_to_hub.py).
The logic is:

if user provides revision, this is used.
else: there is no revision is provided then,

if evaluate has a dev tag main is used
else version tag of evaluate is used (e.g. v0.2.0)

This addresses the massive issues when merging #188. This will not solve the issues for existing versions but at least for newer versions this should not be an issue anymore.

Alternatively it can use main by default, but if it contains a requirements.txt with an old version of evaluate it can check the tags ?

The issue with that is that we'll never be able to have a breaking change between the hub modules and the github repository without breaking every older version of the library.
this is what's happening with #188: since changed the module structure a bit all the older version of evaluate will try to load them.

If we use release tags release-* we can resolve to the latest tag with a requirements.txt that is compatible with the user's local version of evaluate no ?