Passing arguments to vscode command in code action from non-js language server

When a language server (implemented in OCaml) sends a code action with a command editor.action.goToLocations, it needs to pass various arguments to the command: uri, position, locations, multiple (optional), noResultsMessage (optional), and openInPeek (optional). From diving into implementation, I have several questions:

AFAIU, uri, position, locations should be of format supported by vscode, e.g., position is not common position format for lsp: {line: number, character: number} BUT {lineNumber: number, column: number}. Shouldn't command arguments be more lsp friendly and support common to LSP format?

More importantly, when I pass uri, AFAIU, vscode has the following check for it (from here)

static isUri(thing: any): thing is URI {
		if (thing instanceof URI) {
			return true;
		}
		if (!thing) {
			return false;
		}
		return typeof (<URI>thing).authority === 'string'
			&& typeof (<URI>thing).fragment === 'string'
			&& typeof (<URI>thing).path === 'string'
			&& typeof (<URI>thing).query === 'string'
			&& typeof (<URI>thing).scheme === 'string'
			&& typeof (<URI>thing).fsPath === 'string'
			&& typeof (<URI>thing).with === 'function'
			&& typeof (<URI>thing).toString === 'function';
	}

How does one send this json such that this returns true, taking into account with and toString properties?
I see there is some code that converts json to js objects, but it's minimalistic

I think that given vscode has a limited number of commands, the code could specialize handling of arguments to make it more friendly or there is some other easier way to go about this?

When a language server (implemented in OCaml) sends a code action with a command editor.action.goToLocations

For starters, you are aware that editor.action.goToLocations is not mentioned anywhere in the language server protocol and is specific to Visual Studio Code, correct? This means this particular feature of your server will not work with other LSP clients.

AFAIU, uri, position, locations should be of format supported by vscode, e.g., position is not common position format for lsp: {line: number, character: number} BUT {lineNumber: number, column: number}. Shouldn't command arguments be more lsp friendly and support common to LSP format?

Ideally, yes, but an editor's API does not have to conform to the LSP API.

More importantly, when I pass uri, AFAIU, vscode has the following check for it (from here)

static isUri(thing: any): thing is URI {
		if (thing instanceof URI) {
			return true;
		}
		if (!thing) {
			return false;
		}
		return typeof (<URI>thing).authority === 'string'
			&& typeof (<URI>thing).fragment === 'string'
			&& typeof (<URI>thing).path === 'string'
			&& typeof (<URI>thing).query === 'string'
			&& typeof (<URI>thing).scheme === 'string'
			&& typeof (<URI>thing).fsPath === 'string'
			&& typeof (<URI>thing).with === 'function'
			&& typeof (<URI>thing).toString === 'function';
	}

How does one send this json such that this returns true, taking into account with and toString properties?

I think the answer here is that you can't.

For starters, you are aware that editor.action.goToLocations is not mentioned anywhere in the language server protocol and is specific to Visual Studio Code, correct? This means this particular feature of your server will not work with other LSP clients.

Correct.

Ideally, yes, but an editor's API does not have to conform to the LSP API.

But here we're talking more about vscode-languageserver and vscode-languageclient, which actually could glue LSP and vscode better. (I'm not criticizing someone's work or ordering them to do the work, just discussing a possibility of such feature, whoever ends up implementing them voluntarily)

I think the answer here is that you can't.

This is my understanding as well, but that seems like quite a limitation? I think there is nothing really hard preventing this functionality.

Ideally, yes, but an editor's API does not have to conform to the LSP API.

But here we're talking more about vscode-languageserver and vscode-languageclient, which actually could glue LSP and vscode better. (I'm not criticizing someone's work or ordering them to do the work, just discussing a possibility of such a feature, whoever ends up implementing it voluntarily)

Certainly, I think that vscode-languageclient could play a role here. I don't know what the maintainers think though.

I think the answer here is that you can't.

This is my understanding as well, but that seems like quite a limitation? I think there is nothing really hard preventing this functionality.

https://github.com/microsoft/vscode-languageserver-node/blob/3076e79c8e6569fcdeac61446cbffe5a20ff8034/client/src/common/client.ts#L2073-L2075
On second thoughts, I think you might be able to achieve this yourself by using middleware to intercept the returned objects and make conversions yourself to satisfy the requirements of the editor.action.goToLocations command.

The best you can do is to use the middleware right now since it will allow you to modify the result before it is handed back to VS Code.
I am not sure if I want to go down the road of officially supporting this unless we come to a clearer specification of commands as requested here: https://github.com/microsoft/language-server-protocol/issues/642


Adding a new row in Invoice Editor does not indicate that it can be edited

When clicking + Add credit card transaction, there should be some indication that it can be edited. Maybe focusing the row after the button click is enough. On mobile this is maybe more critical since the double tap to edit is not necessarily apparent to the user.

There is no such public API in grid / grid-pro that can be used for:

Focusing the new row
Scrolling to the new row
Programatically start editing the new row.


Cannot use mean_absolute_error

I made a very simple neural network on tf and I wanted to use mean absolute error loss function, however I got this error right after I created the optimizer:
No gradients provided for any variable, check your graph for ops that do not support gradients, between variables [...] and loss Tensor(...)
This is what I did:
cost = tf.metrics.mean_absolute_error(pred, y)[0]
optimizer = tf.train.AdadeltaOptimizer(learning_rate=learning_rate).minimize(cost)

I tried another loss function and it worked. In fact, I read that it's difficult to provide a gradient when the absolute value is involved, but I did exactly the same in Keras and it works. In fact, I also did the following (which is basically the mean absolute error) and it works as well!
cost = tf.reduce_mean(tf.abs(tf.subtract(pred, y)))
optimizer = tf.train.AdadeltaOptimizer(learning_rate=learning_rate).minimize(cost)

Why the function doesn't work?
JM.

@jmlipman you might want to use another loss function like mean_squared_error for the optimization. Apart from that you can use mean_absolute_error to measure the "accuracy".

@gissemari can you please explain more detail how to implement mean_absolute_error to evaluate?
CC @reedwm

Sure. According to the example here, cost can be used for the optimization, while performance can be just the metric (as the module tf.metrics suggest).
cost = tf.losses.mean_squared_error(y, predictions)
optimizer = tf.train.AdadeltaOptimizer(learning_rate=learning_rate).minimize(cost)
performance  = tf.metrics.mean_absolute_error(pred, y)[0]

Why do you say that mean absolute error has no gradient? It is piecewise smooth, just like a ReLU layer, and the gradient should be the mean of the gradients of each absolute error (well-defined everywhere except at 0). I was surprised not to find a mean_absolute_error in tf.losses, as right now I thought I could be better off training for that, because I suspect squared error is too strict for my data (perhaps encouraging the model to output the mean when it is uncertain, rather than risking a huge squared error by making a guess. Maybe I am wrong). Anyway, it should be possible to use tf.reduce_mean(tf.abs(predictions-targets)).


CoffeeScript incompatibility with predefined values

'civet coffeeCompat'

class Foo
  [Symbol.toStringTag]: 'Foo'

console.log Foo::[Symbol.toStringTag]

This prints 'Foo' in CoffeeScript and undefined in Civet.

One could argue that this is a bug in CoffeeScript. See https://github.com/jashkenas/coffeescript/issues/4552 (especially toward the end).
That said, it probably make sense to have a compatibility flag that triggers CoffeeScript's IIFE behavior, and perhaps the same coffeeClasses flag makes sense. Related to #457.

As a workaround you can do this:
'civet coffeeCompat'

class Foo
  get [Symbol.toStringTag]() 'Foo'

console.log Foo::[Symbol.toStringTag]


Chickens vanish from breeding pens

Issue Description:
Modpack: Skyfactory 3
Issue:  Chickens in nesting boxes all vanished.  Free roaming chickens did not.  The boxes were then bugged and would not accept new chickens until broken and replaced.
Steps to reproduce (important):
I am re-breeding and replacing chickens to see if the same thing happens after my next logout.
Affected Versions (Do not use "latest"):

Chickens: 4.2.2
Minecraft: 1.10
Forge:  Not sure.

This is not his mod.. the nesting pens belongs to my mod. Hatchery please close this amd add it to hatchery not chickens.

https://github.com/GenDeathrow/Hatchery/issues/42

https://github.com/GenDeathrow/Hatchery/issues/46

Sorry about the confusion!


Eberg Aqumi 50

Describe the bug
Eberg Aqumi 50 dehumidifier, integrated with Tuya, unfortunately, when I try to control with HA, I get the message "Failed to call the humidifier / set_humidity service. Cannot set humidity, device doesn't provide methods to set it". From the level of the application and the IoT platform, I can control it without any problems.
Expected behavior
Dryer control and parameter download.
Diagnostics for integrations and devices
You can download the diagnostics text file by clicking the "Download diagnostics" button in (Configuration -> Integrations -> Tuya Integration -> lower right button), please check the image below:
Screenshots

Home Assistant Version

2022.10.1

Device info (please complete the following information, which can be found in log):
like this:
{
"home_assistant": {
"installation_type": "Home Assistant OS",
"version": "2022.10.0",
"dev": false,
"hassio": true,
"virtualenv": false,
"python_version": "3.10.5",
"docker": true,
"arch": "x86_64",
"timezone": "Europe/Warsaw",
"os_name": "Linux",
"os_version": "5.15.67",
"supervisor": "2022.09.1",
"host_os": "Home Assistant OS 9.0",
"docker_version": "20.10.17",
"chassis": "vm",
"run_as_root": true
},
"custom_components": {
"pgnig_gas_sensor": {
"version": "2.3.0",
"requirements": []
},
"hacs": {
"version": "1.27.2",
"requirements": [
"aiogithubapi>=22.2.4"
]
},
"nodered": {
"version": "1.1.2",
"requirements": []
},
"tauron_amiplus": {
"version": "v2.1.3",
"requirements": [
"requests"
]
},
"sonoff": {
"version": "3.3.1",
"requirements": [
"pycryptodome>=3.6.6"
]
},
"hikconnect": {
"version": "1.3.0",
"requirements": [
"hikconnect==1.0.0"
]
},
"tplink_deco": {
"version": "2.2.3",
"requirements": [
"pycryptodome>=3.12.0"
]
},
"philips_ambilight_hue": {
"version": "1.0.1",
"requirements": [
"ha-philipsjs==2.7.6"
]
}
},
"integration_manifest": {
"domain": "tuya",
"name": "Tuya",
"documentation": "https://www.home-assistant.io/integrations/tuya",
"requirements": [
"tuya-iot-py-sdk==0.6.6"
],
"dependencies": [
"ffmpeg"
],
"codeowners": [
"@Tuya",
"@zlinoliver",
"@frenck"
],
"config_flow": true,
"iot_class": "cloud_push",
"dhcp": [
{
"macaddress": "105A17*"
},
{
"macaddress": "10D561*"
},
{
"macaddress": "1869D8*"
},
{
"macaddress": "381F8D*"
},
{
"macaddress": "508A06*"
},
{
"macaddress": "68572D*"
},
{
"macaddress": "708976*"
},
{
"macaddress": "7CF666*"
},
{
"macaddress": "84E342*"
},
{
"macaddress": "D4A651*"
},
{
"macaddress": "D81F12*"
}
],
"loggers": [
"tuya_iot"
],
"is_built_in": true
},
"data": {
"endpoint": "https://openapi.tuyaeu.com",
"auth_type": 0,
"country_code": "48",
"app_type": "tuyaSmart",
"mqtt_connected": true,
"disabled_by": null,
"disabled_polling": false,
"name": "Osuszacz",
"model": "DET",
"category": "cs",
"product_id": "Ae4ugOtmLWfbe7Go",
"product_name": "Dehumidifier",
"online": true,
"sub": false,
"time_zone": "+01:00",
"active_time": "2022-10-06T12:26:10+00:00",
"create_time": "2022-10-06T07:16:26+00:00",
"update_time": "2022-10-06T12:26:15+00:00",
"function": {
"temp_set": {
"type": "Integer",
"value": {
"unit": "\uff05",
"min": 15,
"max": 80,
"scale": 0,
"step": 5
}
},
"windspeed": {
"type": "Enum",
"value": {
"range": [
"0",
"2"
]
}
}
},
"status_range": {
"temp_set": {
"type": "Integer",
"value": {
"unit": "\uff05",
"min": 15,
"max": 80,
"scale": 0,
"step": 5
}
},
"windspeed": {
"type": "Enum",
"value": {
"range": [
"0",
"2"
]
}
},
"fault": {
"type": "Bitmap",
"value": {
"label": [
"P1",
"E3",
"E5",
"EH",
"E1",
"E2",
"0"
]
}
}
},
"status": {
"temp_set": 40,
"windspeed": 0,
"fault": 0
},
"home_assistant": {
"name": "Osuszacz",
"name_by_user": null,
"disabled": false,
"disabled_by": null,
"entities": [
{
"disabled": false,
"disabled_by": null,
"entity_category": null,
"device_class": null,
"original_device_class": "dehumidifier",
"icon": null,
"original_icon": null,
"unit_of_measurement": null,
"state": {
"entity_id": "humidifier.osuszacz",
"state": "off",
"attributes": {
"min_humidity": 0,
"max_humidity": 100,
"device_class": "dehumidifier",
"friendly_name": "Osuszacz",
"supported_features": 0
},
"last_changed": "2022-10-06T12:30:14.278751+00:00",
"last_updated": "2022-10-06T12:30:14.278751+00:00"
}
}
]
}
}
}
Device specifications (please complete the following information, which can be found in log):
Same device's id, like this:
Additional context
Data from Tuya IoT Platform:

Add any other context or logs about the problem here.

Hi, did you ever resolve the problem?

Unfortunately, the problem is not solved, the device is visible in HA, no
control is possible.
czw., 18 maj 2023 o 20:28 Łukasz Przeniosło @.***>
napisał(a):

Hi, did you ever resolve the problem?
—
Reply to this email directly, view it on GitHub
https://github.com/tuya/tuya-home-assistant/issues/857#issuecomment-1553453905,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXFZGGTHJHQA2ZGTBBBEEPDXGZS3DANCNFSM6AAAAAAQ6U5DC4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Revert "Check if driver support DPAS and 2D block operations"

Reverts intel/intel-xpu-backend-for-triton#1565

I have work in progress that conflicts with this PR. Let's revert, push in the big change in PRs #1588 AND its dependent before changing this code.

@whitneywhtsang pls approve this one.


BashOperator has a collision with xcom_push method

Problem
BashOperator has a collision with xcom_push class member, BashOperator hides/overloads (how do you this trick it python) xcom_push method inherited from BaseOperator.
Solution
rename BashOperator class member

I merged the fix, thanks for digging in.


Maya: Fix capture preset camera options not working

Brief description
This fixes #3573
Description
Camera options from project settings project_settings/maya/publish/ExtractPlayblast/capture_preset/Camera Options should now correctly propagate into the extracted reviews.
Testing notes:

Tweak settings
Ensure they end up in the extracted review

Thanks @m-u-r-p-h-y - luckily that's unrelated to this PR.
For now could you try enabling this setting: project_settings/maya/publish/ExtractPlayblast/capture_preset/Viewport Options/override_viewport_options?

That would avoid the call to parse_active_panel and thus avoid the error.

Looking at the logic I think that would even override the actual camera too! I feel there's a much bigger bug there.

Yes, you are completely right. It needs some cleanup for sure!
camera options are working now (with the override_viewport_options enabled)

just a small note, I had Depth of Field on

but it is not working as you said. Shouldn't this option be part of camera options as it is a camera attribute, not viewport?

just a small note, I had Depth of Field on
but it is not working as you said. Shouldn't this option be part of camera options as it is a camera attribute, not viewport?

I believe it's actually a setting on both.
If it's disabled on the camera you'll see this as tooltip for DOF button in the viewport menu:

That button will set the "Depth of Field" setting from the Viewport's Shading Menu:

So the DOF is enabled with both:

{camera}.depthOfField attribute.

Which has additional settings:

{camera}.focusDistance
{camera}.fStop
{camera.focusRegionScale

hardwareRenderingGlobals.renderDepthOfField viewport 2.0 settings

So currently the setting is only exposed in the Viewport Options to either enable/disable it. Then it's up to the scene user to set it on the camera or not if they'd like. I'd say that's actually quite accurate in workflow and allows settings to Enable/Disable it while still allowing an artist to set it up needed for the shot without hardcoding a specific focus distance.
Basically, it should be good as is.

But wouldn't the overrides skip the camera attributes settings?
For now, it does not work. If I enable DOF in settings and also keep it on camera shape there is no dof rendered . . .

For now, it does not work. If I enable DOF in settings and also keep it on camera shape there is no dof rendered . . .

Of course - you are correct. It would require the values to be passed along to persist since otherwise capture library reverts it to its default values.
We might be best of doing this:
# Persist the camera depth of field value no matter what
# Depth of field is enabled/disabled through Viewport Options
preset["camera_options"]["depthOfField"] = cmds.getAttr(cam ".depthOfField")

Let me take a look.

Yep, definitely needs to be passed into capture.py through grabbing the preset value for it!

is this one still ready to go?

No sorry - will still need to pass that depthOfField argument along as described. It's not necessarily the exact same Issue to be fixed here. But it shouldn't be too hard either to get it in.

Apparently the logic to "try and fix" this was already there. However, there was a typo in the camera_options name. So I've refactored it with https://github.com/pypeclub/OpenPype/pull/3817/commits/d0d80b0b90648b1633a11c5980c0c66e3a3cff7f
@Allan-I Should work now. Could you test?
Looking at the logic for Extract Thumbnail it looks like it was already doing it correctly to allow thumbnails with DOF.

I'm happy to merge this as soon as some confirms the artist side functionality here.

Up next... merging soon?

hope it won't revert changes done in #3852

That looks much cleaner actually, good work, code looks good will give it a whirl later when I'm home!

There is another thing in camera options.
I suppose Display Resolution is meant for Resolution Gate
if so, we have it wrong as Gate can only have one state at a time (Resolution Gate, Film Gate , No Gate)
and should be changed to drop down selection instead of a tick box

There is another thing in camera options.
I suppose Display Resolution is meant for Resolution Gate
if so, we have it wrong as Gate can only have one state at a time (Resolution Gate, Film Gate , No Gate)
and should be changed to drop down selection instead of a tick box

Thanks @m-u-r-p-h-y
The lovely bits of Maya.

They are individual attributes on the camera actually.
Those viewport settings actually toggle multiple attributes, note how toggling between "Resolution Gate" and "No Gate" sets multiple attributes differently on the camera - including tweaking the overscan.
Maya can actually show all three at the same time.

So the setting is actually accurate in settings.

Maya can actually show all three at the same time.
It does show me however that the settings is lacking the "Gate Mask Opacity" and "Gate Mask Color".
Also, maybe for familiarity it helps to re-order the settings to match the attribute order of the Attribute Editor for cameras. Which would just mean moving Display Gate Mask to below Display Film Gate and adding in the two missing key-values.

Wow, Maya is just so perfect name for the software! Everything is just an illusion :)
Speaking of missing attributes we should add Fit Resolution Gate (Fill, Horizontal, Vertical, Overscan - with Horizontal as default) to have all gate attributes there

Speaking of missing attributes we should add Fit Resolution Gate (Fill, Horizontal, Vertical, Overscan - with Horizontal as default) to have all gate attributes there ;)

Oof - good question. I'd like to actually preserve that from whatever the scene is at - which is actually what happens if we do not provide it since capture sets no default for that. As such, I'd actually like to keep that separate from these settings. If you'd want to ensure a certain fit mode on your cameras I'd say that might need to be a different validator on its own to also ensure not only playblasts are that way, but also your camera publishes etc.

@m-u-r-p-h-y @BigRoy I'm not sure if last messages means it should be fixed in this PR or not? If the issue was not caused by this PR but was already there I would merge this.

Overscan value other than 1 is breaking the display options (the titles and gate will disappear)

how about the overscan issue?

I'm not sure if last messages means it should be fixed in this PR or not? If the issue was not caused by this PR but was already there I would merge this.

Yes, ignore here - make an issue of its own if we need other things like validating camera fit mode if you need that in production.

Overscan value other than 1 is breaking the display options (the titles and gate will disappear)

Could it be that you had this setting disabled: project_settings/maya/publish/ExtractPlayblast/capture_preset/Viewport Options/headsUpDisplay?
Having the HUD hidden would also not show the camera overlays.

I did find an issue where the first frame did not get the capture settings applied. These are of the same "capture"

I've seen this reported with maya.cmds.playblast and/or capture library before and feel it's not related to this PR.
So I'd say ignore that for now too.

@m-u-r-p-h-y Could it be that you had this setting disabled:

definitely not. Just generated playblast with overlays on. changed ONLY overscan and new playblast lost overlays.

I did find an issue where the first frame did not get the capture settings applied. These are of the same "capture"

notice the same issue as well.
seems like the first frame is overwritten? thumbnail or something?

I've seen this reported with maya.cmds.playblast and/or capture library before and feel it's not related to this PR. So I'd say ignore that for now too.

Ok

definitely not. Just generated playblast with overlays on. changed ONLY overscan and new playblast lost overlays.

Interesting, because I have just done reviews with overscan 1.0 and 1.3 and it came out ok as in the screenshot above (which is 1.3).
What overscan value did you try?

seems like the first frame is overwritten? thumbnail or something?

That's a good question actually. Is that something you have to time debug further? (And still wondering whether it's related to this PR - don't recall changing anything that might now make it overwrite files.)

That's a good question actually. Is that something you have to time debug further? (And still wondering whether it's related to this PR - don't recall changing anything that might now make it overwrite files.)

can we compare the timestamp on the sequence files? It would suggest there is something fishy. I can have a look tomorrow . . .

2022-09-21T16:36:35.576041 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain.1001.jpg
2022-09-21T16:36:34.860949 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain.1002.jpg
2022-09-21T16:36:34.945902 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain.1003.jpg
2022-09-21T16:36:35.121817 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain.1004.jpg
2022-09-21T16:36:35.214748 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain.1005.jpg
2022-09-21T16:36:36.195686 C:\Users\Roy\AppData\Local\Temp\pyblish_tmp_7qznodvr\reviewMain_h264.mp4

Good catch, @m-u-r-p-h-y - looks like the first frame is getting modified later and likely overwritten by ExtractThumbnail

looks like the first frame is getting modified later and likely overwritten by ExtractThumbnail

We handle that elsewhere with creating stagingDir in temp dir for the thumbnail representation.

We handle that elsewhere with creating stagingDir in temp dir for the thumbnail representation.

Are you sure? I can't find any of that logic.

Maya Extract Thumbnail uses the regular staging dir
Maya Extract Playblast uses the same regular staging dir

I think you are referring to this global Extract Thumbnail because that does create a new temp dir.
So it does definitely look like Maya's Extract Thumbnail is writing into the source file. I've added this commit to match the global thumbnail extractor logic.

So, the initial approval is a bit lost in comments. Is it still valid? Is this ready to merge?

there are definitely a lot of fixes and I would suggest merging it, and IF - THAN continuing with issues in fresh PR . . .


Remove krzysied from OWNERS

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm
/retest


Added Mathcad wrapper and Newton-Raphson for Region 3

Began a framework for adding a Mathcad wrapper for if97.    Also made
some changes to if97.h that included:

Newton-Raphson solver in Region 3 for accuracy and later addition of saturation properties
Minor tweaks to exception messages/types for clarity in the Mathcad wrapper
Put limit checks on psat97() and Tsat97() to keep from calling outside saturation region.

OK, I think it's updated...

Should the file if97_validation.xmcd be included?  It looks to be rather large.  And not diffable.

Also, please run a spell check on PDF.  Some issues I noted

supplimental -> supplemental
imlementation -> implemental

Typos fixed.  Mathcad's spell check is not "passive".
Per our earlier conversation.  Let's leave the .xmcd file there as it will give people a feel for usage of the DLL once they compile and install it.  It's only 304KB and we won't be adding more or migrating it to the CoolProp area.


Fix/clean repo

get rid of unnecessary clutter from initialisation and update dependencies

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0a2b1bc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   18.18%
=========================================
  Files             ?        4
  Lines             ?       11
  Branches          ?        2
=========================================
  Hits              ?        2
  Misses            ?        9
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2b1bc...664418b. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
1.0.0

Your semantic-release bot :package::rocket:


[1.10.2] [Bug] Compatibility Issue (Visual) with FTB Utilities/Vanilla

Hello,
A quick bug to report regarding Cyclic for Minecraft 1.10.2, here are the details of the issue. . .
Important Information

Minecraft 1.10.2
Minecraft Forge <IP_ADDRESS>4
Cyclic 1.10.2-1.7.8
Other Mods:

FTB Utilities 2.1.0

Issue Description
Crafting cake crafting table hides FTB Utils icons and potion effects.
Issue Media

Yeah i see whats going on there.  Thanks for reporting this.  Ill get a release out asap

Cause:
When i eat the 'Inventory Upgrade' cake, and use that button. the FTB utils HUD does stay in the top left. This is because its a "player type" of screen, and FTB Utils can detect this as part of the player.  But the way I set up the workbench screen. its basically an extension/clone of the Crafting table, so FTB Utilities treats it the same as it would the vanilla crafting table (and the hud does not show up in the vanilla crafting table, which is expected).
Solution:
So i have to change the crafting gui to be more like a player screen (extend the player gui classes) so that other mods like FTBUtils knows this is a player inventory screen and not a table screen.  Possibly related to #69 .
This is not a quick fix like i thought, but i am looking into it.

Fixed in new release.  Rebuilt the inventory crafting screen.  https://minecraft.curseforge.com/projects/cyclic/files/2333207


Vulkan BadDrawable - Engine crashes on startup

Godot version:
master - 7899b3e
OS/device including version:
Kubuntu 20.04 LTS
GeForce GTX 950M/PCIe/SSE2 (nvidia-driver-440)
Issue description:
The engine crashes on startup. The following output log is printed:
Godot Engine v4.0.dev.custom_build.7899b3e73 - https://godotengine.org
X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
  Major opcode of failed request:  149 ()
  Minor opcode of failed request:  4
  Resource id in failed request:  0x3600006
  Serial number of failed request:  66
  Current serial number in output stream:  72

Steps to reproduce:
Start the compiled engine.
This issue has been extracted from https://github.com/godotengine/godot/issues/37102#issuecomment-619533192

If you've updated your NVIDIA graphics driver, you need to restart your PC so you can start 3D applications again.

Are you running Plasma on Wayland? If so, do you have xwayland installed?
Does the Nvidia GPU otherwise support Vulkan application? Check vulkaninfo or vkcube.

@Calinou I'm quite novice to the topic of drivers (especially graphics drivers), so here's what I did: I changed to NVIDIA only in the nvidia-settings, disabled the nouveau drivers and that was it (I think)
@akien-mga Thanks for the tip with vkcube. Last time I used a vulkan application it worked fine, but it was still on my old OS (where I have bodged many things so I don't recall much). After installing primus-nvidia the vkcube worked again and the master is working fine
TIL for anybody with the same issue: take a look at this page maybe it can also help you


Add tokio-trace-macros crate with a trace-ified version of std::dbg!

The Rust standard library has a quite useful dbg! macro which
evaluates an expression, prints the result of the expression, and then
returns the result. This allows users to write code like
let foo = dbg!(7 + 9);

and get useful debug logging in the process.
However, since neither log nor tokio-trace are available in the
standard library, this macro simply outputs to stderr, so its output
can't be processed by tokio-trace or located within a trace tree.
This branch introduces a tokio-trace-ified version of dbg!, which
generates tokio-trace Events. The generated events contain a single
field, whose name is the string representatation of the evaluated
expression and whose value is the result. tokio-trace applications can
use this macro in place of std::dbg!.
The macro is in a new tokio-trace-macros crate, to which I expect to
add new macros in the future. However, the proc macro for the #[trace]
attribute is currently also named tokio-trace-macros on master. I've
renamed that crate to tokio-trace-derive, rather than adding the new
macro_rules macro to that crate. I'm not sure if crates exporting
proc-macros can also export macro_rules macros, and I figured some
users might want one or the other, but not both.
Signed-off-by: Eliza Weisman<EMAIL_ADDRESS>

Note that I'm not attached to the name tokio-trace-derive for the proc-macro
crate, and it's not super correct as that crate doesn't actually provide new
derive attributes. @davidbarsky, I'm open to bikeshedding on what the right
name is...

I'm not sure if crates exporting proc-macros can also export macro_rules macros, and I figured some users might want one or the other, but not both.

I think only procedural macros can be exported from a proc-macro crate. I know you were kinda opposed to this, but when 1.33 is released, we can move everything to use proc-macros and simplify the naming (because of Tokio's versioning policy). This might be a blocker, though—https://github.com/dtolnay/proc-macro-hack/issues/20. I'm not sure if that pattern is (or should be?) supported in Tokio Trace.
The changes themselves are good, I'm just not a fan of the the name. Maybe tokio-trace-proc-macros?

@davidbarsky

I know you were kinda opposed to this, but when 1.33 is released, we can move everything to use proc-macros and simplify the naming (because of Tokio's versioning policy)

I'm fine with that as long as it's compliant with the minimum version policy. However, I don't think we'll be able to replace the "core" macros in tokio-trace (i.e. span!, event!, etc) with proc-macros, as I'd prefer them to be provided by the tokio-trace crate, which also has to expose non-macro code.

The changes themselves are good, I'm just not a fan of the the name. Maybe tokio-trace-proc-macros?

I went with -derive rather than -proc-macros because it was shorter, but I'm happy to change it if you prefer. As a third option, WDYT of tokio-trace-attr?

I went with -derive rather than -proc-macros because it was shorter, but I'm happy to change it if you prefer. As a third option, WDYT of tokio-trace-attr?

I'd prefer proc-macros over -attr because it gives us the option to introduce a #[derive(Instrumented)] macro.

-proc-macros it is, then! 3c813f2f74c44a6254f8731152804a3873e5a895


Ignoring Non-Textual files in Directory-level scans

Hello,
We were trying to use the tool for directory-level scans (using --dir) over a bunch of cloned repositories. For instance, we tried scanning gitea, it results into following:
$ license-scanner --dir gitea/
Error: failed to normalize data: invalid input text with control characters
We had a similar observation on a few more directories containing some non-textual files such as UI assets, binaries, etc.
Will it be possible to get a Warning for such file occurrences, and those files being ignored, and the scanner continuing to scan the remaining files? Or perhaps a command-line argument to set such a behavior by the tool?

I had a workaround for this. There is a bit more to it that I need to untangle (probably not specific to this issue), but basically here (below) is where the error can be changed to log-and-continue.
I'll assign this to me. There is some a pending PR and some repo moving again that might delay this though.
===================================================================
diff --git a/normalizer/normalizer.go b/normalizer/normalizer.go
--- a/normalizer/normalizer.go
+++ b/normalizer/normalizer.go
@@ -151,7 +151,13 @@
// Check if the text contains control characters indicative of binary or non-text files.
// match against /[\u0000-\u0007\u000E-\u001B]/
if ControlCharactersRE.MatchString(n.OriginalText) {

  return fmt.Errorf("failed to normalize data: invalid input text with control characters")

  if n.IsTemplate {

  	return fmt.Errorf("failed to normalize data: invalid input text with control characters")

  } else {

  	Logger.Errorf("failed to normalize data: invalid input text with control characters")

  	n.NormalizedText = ""

  	return nil // continue

  }

}


Support for spellsuggest

(Really appreciate your work on this - really is a valuable library for anyone building a vim-like editor)
Most vim commands work as expected with vim.Execute(...).  Looking through the code it looks like spellsuggest would be supported and that the sequence:
vimExecute("let sug = spellsuggest('hellllo')")
s = vimEval("string(sug)")

should bring back the suggestions in a stringified list.  What I get is always an empty list.
I have tried to place the spelling and suggestion files in a variety of places and explicitly set the file locations via "set spell spelllang=...". Nothing has worked.
Is executing the spellsuggest command supported by libvim?

I now see that nothing related to spelling appears to be enabled including support for normal mode commands like ]s.
As noted above executing set spell spellang=... doesn't enable spelling support -- any advice as to whether it is possible to do so would be helpful.

OK see now that spelling was out of scope for the project.


stdenvs: Distinguish between extraBuildInputs and extraNativeBuildInputs

Motivation for this change
Additionally, instead of pulling them from setup.sh, route them via Nix. This gets us one step closer to making stdenv be a plain attribute set instead of a derivation. Also, moves complexity from bash to Nix, which is an improvement.
Things done
Currently the Linux stdenv fails to build, saying xz -5 results in an xz been unrecognized. I'm guessing this is because dependencies are processed in a slightly different order. I can try tweaking the order, but think the underlying conflict is best fixed first.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Ah so the underlying issue is bootstrap-tools/bin gets on the PATH. IMO that's a pretty large path entry, but fixing it is another can of worms.

Eh, ok now I see why the hack was needed (which is really difficult since it's one commit doing a multitude of things). But that now means this:
nix-repl> hello.nativeBuildInputs
[ «derivation /nix/store/bcfkyf6bhssxd2vzwgzmsbn7b5b9rpxc-patchelf-0.9.drv» «derivation /nix/store/4wnshnz9wwanpfzcrdd76rri7pyqn9sk-paxctl-0.9.drv» /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/move-docs.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/compress-man-pages.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/strip.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/patch-shebangs.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/audit-tmpdir.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/multiple-outputs.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/move-sbin.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/move-lib64.sh /home/tmtynkky/opt/nixpkgs/pkgs/build-support/setup-hooks/set-source-date-epoch-to-latest.sh «derivation /nix/store/d35pgh1lcg5nm0x28d899pxj30b8c9b2-gcc-wrapper-6.4.0.drv» ]

... which seems highly undesirable.

We could have default* attributes on the derivation, if you like. That still accomplishes my goal of less bash.

So every derivation call & .drv file gets to repeat the same list of 10+ dependencies over and over again? And with that hack still being needed?
Reverted in 7320fa9d4581e634fec4db848d7a4d157a51303d. Please get proper reviews before changing semantics of core stuff like this and consider the evaluation performance impacts of changing mkDerivation.


foundation: allocation with multi memory

If we based on multi memory, each instance and runtime can share a common memory. Then if we can allocate data on that memory, there will no need to "write" to instance since the pointer should be accessible for that instance now.
Warning: have no experiment now, I cannot ensure that would work fully as expected

https://github.com/WasmEdge/WasmEdge/issues/2463 might related

This is impossible, since literally no tool chain supporting


Fixed unittests on Windows with python prior to 3.7

Regarding issue #79: unittests fail on Win7
This fixes python3.6 on Win7 last issues.

This will not work.  The reason for adding the version number is to allow either py2 or py3 tests to run.  On my msys/mingw install, the following did exist:
python2
python3
python -> python3
My python version came as 3.8.2

I just tested it in my branch on Windows 7 with python 2.7, 3.6 and 3.8. Log is below.
My system does not resolve python2 or python3 to anything. I believe newer systems like Win10 do. That's why you have python2 and python3 aliases.
But my patch will work in both cases. Since tox creates venvs, running just "python" is enough. See the log for yourself. I couldn't just run "tox" because last release of ctypesgen is broken and tox fail the tests. So I manually activated tox environments.
Testing log

C:\projects\ctypesgen>.tox\py27\Scripts\activate.bat
C:\projects\ctypesgen>pytest -v -x --showlocals ctypesgen/test/testsuite.py
============================= test session starts =============================
platform win32 -- Python 2.7.16, pytest-4.6.9, py-1.8.1, pluggy-0.13.1 -- c:\pro
jects\ctypesgen.tox\py27\scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\projects\ctypesgen
collected 46 items
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_null PASSED [  2%]
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_string PASSED [  4%
]
ctypesgen/test/testsuite.py::StdBoolTest::test_stdbool_type PASSED       [  6%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition PASSED [  8%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition_json PASSED [
10%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_constant_int PASSED [
13%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide PASSED [ 1
5%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide_json PASSE
D [ 17%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus PASSED [ 19
%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus_json PASSED
[ 21%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod PASSED [ 23%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod_json PASSED [
26%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multipler PASSED
[ 28%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multiplier_json P
ASSED [ 30%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose PASSED
[ 32%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose_json PA
SSED [ 34%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus PASSED [
36%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_json PAS
SED [ 39%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus PAS
SED [ 41%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus_jso
n PASSED [ 43%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple PASSED
[ 45%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_json PA
SSED [ 47%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus PA
SSED [ 50%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus_js
on PASSED [ 52%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false PASSED [
54%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false_complex
PASSED [ 56%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_json PASSED [
58%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true PASSED [
60%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true_complex P
ASSED [ 63%]
ctypesgen/test/testsuite.py::StructuresTest::test_fields PASSED          [ 65%]
ctypesgen/test/testsuite.py::StructuresTest::test_pack PASSED            [ 67%]
ctypesgen/test/testsuite.py::StructuresTest::test_pragma_pack PASSED     [ 69%]
ctypesgen/test/testsuite.py::StructuresTest::test_struct_json PASSED     [ 71%]
ctypesgen/test/testsuite.py::StructuresTest::test_typedef_vs_field_id PASSED [ 7
3%]
ctypesgen/test/testsuite.py::MathTest::test_bad_args_string_not_number PASSED [
76%]
ctypesgen/test/testsuite.py::MathTest::test_sin PASSED                   [ 78%]
ctypesgen/test/testsuite.py::MathTest::test_sqrt PASSED                  [ 80%]
ctypesgen/test/testsuite.py::MathTest::test_subcall_sin PASSED           [ 82%]
ctypesgen/test/testsuite.py::EnumTest::test_enum PASSED                  [ 84%]
ctypesgen/test/testsuite.py::EnumTest::test_enum_json PASSED             [ 86%]
ctypesgen/test/testsuite.py::PrototypeTest::test_function_prototypes_json PASSED
[ 89%]
ctypesgen/test/testsuite.py::LongDoubleTest::test_longdouble_type PASSED [ 91%]
ctypesgen/test/testsuite.py::MainTest::test_help PASSED                  [ 93%]
ctypesgen/test/testsuite.py::MainTest::test_invalid_option PASSED        [ 95%]
ctypesgen/test/testsuite.py::MainTest::test_version PASSED               [ 97%]
ctypesgen/test/testsuite.py::UncheckedTest::test_unchecked_prototype PASSED [100
%]
========================= 46 passed in 10.16 seconds ==========================
C:\projects\ctypesgen>.tox\py36\Scripts\activate.bat
C:\projects\ctypesgen>pytest -v -x --showlocals ctypesgen/test/testsuite.py
============================= test session starts =============================
platform win32 -- Python 3.6.5, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- c:\proj
ects\ctypesgen.tox\py36\scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\projects\ctypesgen
collected 46 items
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_null PASSED [  2%]
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_string PASSED [  4%
]
ctypesgen/test/testsuite.py::StdBoolTest::test_stdbool_type PASSED       [  6%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition PASSED [  8%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition_json PASSED [
10%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_constant_int PASSED [
13%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide PASSED [ 1
5%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide_json PASSE
D [ 17%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus PASSED [ 19
%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus_json PASSED
[ 21%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod PASSED [ 23%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod_json PASSED [
26%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multipler PASSED
[ 28%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multiplier_json P
ASSED [ 30%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose PASSED
[ 32%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose_json PA
SSED [ 34%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus PASSED [
36%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_json PAS
SED [ 39%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus PAS
SED [ 41%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus_jso
n PASSED [ 43%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple PASSED
[ 45%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_json PA
SSED [ 47%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus PA
SSED [ 50%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus_js
on PASSED [ 52%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false PASSED [
54%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false_complex
PASSED [ 56%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_json PASSED [
58%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true PASSED [
60%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true_complex P
ASSED [ 63%]
ctypesgen/test/testsuite.py::StructuresTest::test_fields PASSED          [ 65%]
ctypesgen/test/testsuite.py::StructuresTest::test_pack PASSED            [ 67%]
ctypesgen/test/testsuite.py::StructuresTest::test_pragma_pack PASSED     [ 69%]
ctypesgen/test/testsuite.py::StructuresTest::test_struct_json PASSED     [ 71%]
ctypesgen/test/testsuite.py::StructuresTest::test_typedef_vs_field_id PASSED [ 7
3%]
ctypesgen/test/testsuite.py::MathTest::test_bad_args_string_not_number PASSED [
76%]
ctypesgen/test/testsuite.py::MathTest::test_sin PASSED                   [ 78%]
ctypesgen/test/testsuite.py::MathTest::test_sqrt PASSED                  [ 80%]
ctypesgen/test/testsuite.py::MathTest::test_subcall_sin PASSED           [ 82%]
ctypesgen/test/testsuite.py::EnumTest::test_enum PASSED                  [ 84%]
ctypesgen/test/testsuite.py::EnumTest::test_enum_json PASSED             [ 86%]
ctypesgen/test/testsuite.py::PrototypeTest::test_function_prototypes_json PASSED
[ 89%]
ctypesgen/test/testsuite.py::LongDoubleTest::test_longdouble_type PASSED [ 91%]
ctypesgen/test/testsuite.py::MainTest::test_help PASSED                  [ 93%]
ctypesgen/test/testsuite.py::MainTest::test_invalid_option PASSED        [ 95%]
ctypesgen/test/testsuite.py::MainTest::test_version PASSED               [ 97%]
ctypesgen/test/testsuite.py::UncheckedTest::test_unchecked_prototype PASSED [100
%]
============================= 46 passed in 11.37s =============================
C:\projects\ctypesgen>.tox\py38\Scripts\activate.bat
C:\projects\ctypesgen>pytest -v -x --showlocals ctypesgen/test/testsuite.py
============================= test session starts =============================
platform win32 -- Python 3.8.2, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- c:\proj
ects\ctypesgen.tox\py38\scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\projects\ctypesgen
collected 46 items
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_null PASSED [  2%]
ctypesgen/test/testsuite.py::StdlibTest::test_getenv_returns_string PASSED [  4%
]
ctypesgen/test/testsuite.py::StdBoolTest::test_stdbool_type PASSED       [  6%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition PASSED [  8%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_addition_json PASSED [
10%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_constant_int PASSED [
13%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide PASSED [ 1
5%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_divide_json PASSE
D [ 17%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus PASSED [ 19
%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_minus_json PASSED
[ 21%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod PASSED [ 23%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_mod_json PASSED [
26%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multipler PASSED
[ 28%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_math_multiplier_json P
ASSED [ 30%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose PASSED
[ 32%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_string_compose_json PA
SSED [ 34%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus PASSED [
36%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_json PAS
SED [ 39%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus PAS
SED [ 41%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_minus_plus_jso
n PASSED [ 43%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple PASSED
[ 45%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_json PA
SSED [ 47%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus PA
SSED [ 50%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_subcall_simple_plus_js
on PASSED [ 52%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false PASSED [
54%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_false_complex
PASSED [ 56%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_json PASSED [
58%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true PASSED [
60%]
ctypesgen/test/testsuite.py::SimpleMacrosTest::test_macro_ternary_true_complex P
ASSED [ 63%]
ctypesgen/test/testsuite.py::StructuresTest::test_fields PASSED          [ 65%]
ctypesgen/test/testsuite.py::StructuresTest::test_pack PASSED            [ 67%]
ctypesgen/test/testsuite.py::StructuresTest::test_pragma_pack PASSED     [ 69%]
ctypesgen/test/testsuite.py::StructuresTest::test_struct_json PASSED     [ 71%]
ctypesgen/test/testsuite.py::StructuresTest::test_typedef_vs_field_id PASSED [ 7
3%]
ctypesgen/test/testsuite.py::MathTest::test_bad_args_string_not_number PASSED [
76%]
ctypesgen/test/testsuite.py::MathTest::test_sin PASSED                   [ 78%]
ctypesgen/test/testsuite.py::MathTest::test_sqrt PASSED                  [ 80%]
ctypesgen/test/testsuite.py::MathTest::test_subcall_sin PASSED           [ 82%]
ctypesgen/test/testsuite.py::EnumTest::test_enum PASSED                  [ 84%]
ctypesgen/test/testsuite.py::EnumTest::test_enum_json PASSED             [ 86%]
ctypesgen/test/testsuite.py::PrototypeTest::test_function_prototypes_json PASSED
[ 89%]
ctypesgen/test/testsuite.py::LongDoubleTest::test_longdouble_type PASSED [ 91%]
ctypesgen/test/testsuite.py::MainTest::test_help PASSED                  [ 93%]
ctypesgen/test/testsuite.py::MainTest::test_invalid_option PASSED        [ 95%]
ctypesgen/test/testsuite.py::MainTest::test_version PASSED               [ 97%]
ctypesgen/test/testsuite.py::UncheckedTest::test_unchecked_prototype PASSED [100
%]
============================= 46 passed in 8.83s ==============================

committed a more generic fix


allowInsecureProtocol doesn't parse correctly in repositories

steps
I have the following ~/.sbt/repositories on one of our CI machines:
[repositories]
maven-local
local
jcenter-proxy-releases: http://laraquad3.epfl.ch:8081/artifactory/jcenter , allowInsecureProtocol
jcenter-ivy-proxy-releases: http://laraquad3.epfl.ch:8081/artifactory/jcenter, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext], allowInsecureProtocol
proxy-maven: http://laraquad3.epfl.ch:8081/artifactory/libs-release , allowInsecureProtocol
proxy-ivy: http://laraquad3.epfl.ch:8081/artifactory/ivy-release/, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext], allowInsecureProtocol

problem
Sbt fails with this error, which suggests that it merges the URL together with the allowInsecureProtocol option when there is no Ivy pattern in between. Here's what I see on the CI:
Getting org.scala-sbt sbt 1.4.4  (this may take some time)...

:: problems summary ::
:::: WARNINGS
		module not found: org.scala-sbt#sbt;1.4.4

	==== Maven2 Local: tried

	  file:///root/.m2/repository/org/scala-sbt/sbt/1.4.4/sbt-1.4.4.pom

	  -- artifact org.scala-sbt#sbt;1.4.4!sbt.jar:

	  file:///root/.m2/repository/org/scala-sbt/sbt/1.4.4/sbt-1.4.4.jar

	==== local: tried
	  /root/.ivy2/local/org.scala-sbt/sbt/1.4.4/ivys/ivy.xml

	  -- artifact org.scala-sbt#sbt;1.4.4!sbt.jar:
	  /root/.ivy2/local/org.scala-sbt/sbt/1.4.4/jars/sbt.jar

	==== jcenter-proxy-releases: tried
	  http://laraquad3.epfl.ch:8081/artifactory/jcenter/allowInsecureProtocol  <---- HERE IS THE PROBLEM

	==== jcenter-ivy-proxy-releases: tried
	  http://laraquad3.epfl.ch:8081/artifactory/jcenter/org.scala-sbt/sbt/1.4.4/ivys/ivy.xml

		::::::::::::::::::::::::::::::::::::::::::::::
		::          UNRESOLVED DEPENDENCIES         ::
		::::::::::::::::::::::::::::::::::::::::::::::
		:: org.scala-sbt#sbt;1.4.4: not found
		::::::::::::::::::::::::::::::::::::::::::::::

:: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
unresolved dependency: org.scala-sbt#sbt;1.4.4: not found
Error during sbt execution: Error retrieving required libraries
  (see /root/.sbt/boot/update.log for complete log)

expectation
I'd like a way to disable the ban on http repos that works in repositories
notes

What does
$ sbt --launcher-version
sbt launcher version 1.1.5

print?
I tried to resolve 1.99, and got the following error:
$ sbt -Dsbt.repository.config=/tmp/repositories
[info] [launcher] getting org.scala-sbt sbt 1.99  (this may take some time)...

:: problems summary ::
:::: WARNINGS
		module not found: org.scala-sbt#sbt;1.99

	==== Maven2 Local: tried

	  file:///Users/eed3si9n/.m2/repository/org/scala-sbt/sbt/1.99/sbt-1.99.pom

	  -- artifact org.scala-sbt#sbt;1.99!sbt.jar:

	  file:///Users/eed3si9n/.m2/repository/org/scala-sbt/sbt/1.99/sbt-1.99.jar

	==== jcenter-proxy-releases: tried

	  http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.pom

	  -- artifact org.scala-sbt#sbt;1.99!sbt.jar:

	  http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.jar

	==== jcenter-ivy-proxy-releases: tried

	  http://laraquad3.epfl.ch:8081/artifactory/jcenter/org.scala-sbt/sbt/1.99/ivys/ivy.xml

	==== proxy-maven: tried

	  http://laraquad3.epfl.ch:8081/artifactory/libs-release/org/scala-sbt/sbt/1.99/sbt-1.99.pom

	  -- artifact org.scala-sbt#sbt;1.99!sbt.jar:

	  http://laraquad3.epfl.ch:8081/artifactory/libs-release/org/scala-sbt/sbt/1.99/sbt-1.99.jar

	==== proxy-ivy: tried

	  http://laraquad3.epfl.ch:8081/artifactory/ivy-release/org.scala-sbt/sbt/1.99/ivys/ivy.xml

		::::::::::::::::::::::::::::::::::::::::::::::

		::          UNRESOLVED DEPENDENCIES         ::

		::::::::::::::::::::::::::::::::::::::::::::::

		:: org.scala-sbt#sbt;1.99: not found

		::::::::::::::::::::::::::::::::::::::::::::::

:::: ERRORS
	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.pom

	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.jar

	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/jcenter/org.scala-sbt/sbt/1.99/ivys/ivy.xml

	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/libs-release/org/scala-sbt/sbt/1.99/sbt-1.99.pom

	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/libs-release/org/scala-sbt/sbt/1.99/sbt-1.99.jar

	Server access Error: Operation timed out url=http://laraquad3.epfl.ch:8081/artifactory/ivy-release/org.scala-sbt/sbt/1.99/ivys/ivy.xml

:: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
[error] [launcher] unresolved dependency: org.scala-sbt#sbt;1.99: not found
[error] [launcher] error during sbt launcher: error retrieving required libraries
  (see /Users/eed3si9n/.sbt/boot/update.log for complete log)
[error] [launcher] could not retrieve sbt 1.99

I think it's correctly trying to hit http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.pom.

The same version as yours, 1.1.5:
root@c35e3e87d142:/# sbt --launcher-version
sbt launcher version 1.1.5

I can confirm the incorrect parse on windows, using sbt 1.3.13 and 1.4.6.
The exact same file works fine on our Linux machines.
The workaround (for windows) is to explicitly set the resolvers withInsecureProtocol in build.sbt. Unfortunately this only seems to work in 1.3.13 and not in 1.4.*.

I can confirm the incorrect parse on windows, using sbt 1.3.13 and 1.4.6.
The exact same file works fine on our Linux machines.
The workaround (for windows) is to explicitly set the resolvers withInsecureProtocol in build.sbt. Unfortunately this only seems to work in 1.3.13 and not in 1.4.*.

I can confirm this problem still occurs - it happened to me on sbt launcher 1.1.3.
I don't know why it occured, but on MacOS, running brew update; brew upgrade sbt helped. You can also use the workaround described by @gnarroway.

For me adding allowInsecureProtocols is not working on windows 10.
Using e.g. sbt 1.3.12 everything works fine
using sbt 1.4.7 it fails with switch to HTTPS or opt-in as ("snapshots" at "http://foo.bar.com/libs-local-snapshots").withAllowInsecureProtocol(true), or by using allowInsecureProtocol in repositories file [error] java.lang.RuntimeException: insecure protocol is unsupported
Launcher version
> sbt --launcher-version
sbt launcher version 1.1.6

I've tried to reproduce this on Mac and I installed a Windows 10 VM, but haven't had any luck in generating the same error message so far. I've been trying the same method that @eed3si9n described:  https://github.com/sbt/sbt/issues/6212#issuecomment-748506200.
I also tried writing a test in the launcher package's ConfigurationParserTest to check if the space and comma were the problem, but the test passed just fine.
I'm not sure what else to try at this stage so I'll perhaps take a break on this issue for now.
PS C:\Users\Amina\ScalaAmina\Test> sbt --launcher-version
sbt launcher version 1.3.3
PS C:\Users\Amina\ScalaAmina\Test> sbt --script-version
1.5.5

PS C:\Users\Amina\ScalaAmina\Test> sbt -Dsbt.repository.config=$HOME\.sbt\repositories -Dbst.override.build.repos=true
[info] [launcher] getting org.scala-sbt sbt 1.99  (this may take some time)...
[error] [launcher] xsbt.boot.internal.shaded.coursier.error.ResolutionError$CantDownloadModule: Error downloading org.scala-sbt:sbt:1.99
  not found: C:\Users\Amina\.m2\repository\org\scala-sbt\sbt\1.99\sbt-1.99.pom
  not found: C:\Users\Amina\.ivy2\local\org.scala-sbt\sbt\1.99\ivys\ivy.xml
  download error: Caught java.net.ConnectException: Connection timed out: connect (Connection timed out: connect) while downloading http://laraquad3.epfl.ch:8081/artifactory/jcenter/org/scala-sbt/sbt/1.99/sbt-1.99.pom
  download error: Caught java.net.ConnectException: Connection timed out: connect (Connection timed out: connect) while downloading http://laraquad3.epfl.ch:8081/artifactory/jcenterorg.scala-sbt/sbt/1.99/ivys/ivy.xml
  download error: Caught java.net.ConnectException: Connection timed out: connect (Connection timed out: connect) while downloading http://laraquad3.epfl.ch:8081/artifactory/libs-release/org/scala-sbt/sbt/1.99/sbt-1.99.pom
  download error: Caught java.net.ConnectException: Connection timed out: connect (Connection timed out: connect) while downloading http://laraquad3.epfl.ch:8081/artifactory/ivy-release/org.scala-sbt/sbt/1.99/ivys/ivy.xml
[error] [launcher] could not retrieve sbt 1.99


Disable no-multiline-string in recommended ruleset

See discussion at https://github.com/Microsoft/tslint-microsoft-contrib/issues/454.
Feel free to leave this open for a while until decision is taken, and then merge or close accordingly.

@JoshuaKGoldberg, any thoughts on this?


Animation Name : Coffee Cup filling Animation

Description
It is a coffee cup filling animation which can be turned as a loading screen. It is done by using HTML and CSS.
Screenshot Section

Demo Video Section
https://github.com/Durgesh4993/web_Animation/assets/92166294/3ce27968-0f08-4935-a478-8c20255f4784
pls assign it to me under hacktoberfest. I would like to contribute :)

@Durgesh4993 i would like to work on it. plz assign it to me under hacktoberfest :)


drivers: spi: rv32m1: Added LPSPI driver for RV32M1

Modified mcux SPI driver to also support the RV32M1 SOC as they have fairly compatible LPSPI peripherals. They both use their own SOC specific HAL, but those share a fairly common fsl_lpspi interface. Also enabled the SPI flash module on the openVEGA board as a first user of the driver.

I've followed mostly the lead of this commit by @henrikbrixandersen that added I2C,
https://github.com/zephyrproject-rtos/zephyr/commit/8a4dbb5b0357b5cbfb1a3d63d65353ecd6cee665
Except that I've extended the mcux spi driver with rv32m1 specifics, which is only adding  CLOCK_SetIpSrc() to select the peripheral clock source.
@MaureenHelm I don't know if extending the mcux driver is ok with you, or if there should rather be a rv32m1 standalone driver. The difference at least in fsl_lpspi.h looks minor, but that might be deceiving

In terms of testing I ran the spi_flash sample on the RV32M1, and that seems to be able to erase + write + readback. I don't have any other board that uses the mcux spi driver so cannot test if that is broken now :-( I built BOARD=twr_ke18f with SPI enabled, and that worked.

@MaureenHelm
No worries about the delay, thanks for catching it :-)
I dropped combining both drivers inside of the mcux lpspi driver and forked into it's own .c driver. But I otherwise did create a carbon copy, including keeping structures and functions named with mcux. That way patches would transfer more easily. Is this acceptable?
Also this relies on https://github.com/zephyrproject-rtos/hal_openisa/pull/2

@MaureenHelm Adjusted the west repo pointer and rebased on top of master due to a codeowner merge conflict

Btw I also added openisa as a vendor, not so sure how that got picked considering it's a NXP datasheet and a Fgreescale marking :-)
I just kept that inline with the prefix that was used for all other rv32m1 drivers


Missing space in "develop-and-build-7e30686.md"

Dear @okovalenko88, thank you for spotting this!
The error has been fixed and the correction will be visible with the next publication.


gonic: enable on darwin

Description of changes
Turns out this builds and runs just fine on darwin now that it's been updated to 0.16.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1610

Result of nixpkgs-review pr 307801 at cf7dfc8f run on aarch64-darwin 1

1 package failed to build:

gonic


Unstable Mod Error

I have followed all the directions for updating my mod. This includes ensuring that my game is updated to the latest version before updating the mod. I have the Palace of Ice DLC and whenever I try to import a saved game I get the attached error message. This also occurs if I try to just simply load a previously saved game. I am unsure what is happening. I have attached screenshots of my mod version, game version and the error message.

Confirmed that I was able to start a new game and make a save file but I am unable to load a new game from the main menu. I get the same error message.

You haven’t read the changelog on previous Respec requirements. Not a bug.


Styling the selected value

Hey,
Using optionRenderer I was able to style the components of the Selection List.
I would like to be able to style the selected option (collapsed) in the form.
In this gif you can see how the Courier logos appear in the drop down, but once the value is selected the styling isn't applied to the selected component:

Is there an official way to achieve this?
Thanks.

The collapsed UI is rendered by react-select, not this library. This library just renders the menu (drop down) portion and otherwise passes params through to react-select:
https://github.com/bvaughn/react-virtualized-select/blob/aa47a7f43bb7574acbd47ab1483e737d66979b6a/source/VirtualizedSelect/VirtualizedSelect.js#L50-L61
I'd suggest checking out the docs for react-select on how to style it 😄


instance_profile error with invalid count on first apply

Describe the Bug
Input instance_profile will throw the below error on apply
│ Error: Invalid count argument
│
│   on .terraform/modules/instance/main.tf line 85, in data "aws_iam_instance_profile" "given":
│   85:   count = local.enabled && var.instance_profile_enabled && var.instance_profile != "" ? 1 : 0
│
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work
│ around this, use the -target argument to first apply only the resources that the count depends on.
╵
╷
│ Error: Invalid count argument
│
│   on .terraform/modules/instance/main.tf line 96, in resource "aws_iam_role" "default":
│   96:   count                = var.instance_profile_enabled ? local.instance_profile_count : 0
│
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work
│ around this, use the -target argument to first apply only the resources that the count depends on.

Expected Behavior
Expected behavior is that the instance will use the precreated instance profile
Steps to Reproduce
resource "aws_iam_role" "default" {
  depends_on = [aws_iam_policy.default]
  name = "test-role"
  assume_role_policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "",
      "Effect": "Allow",
      "Principal": {
        "Service": [
          "ec2.amazonaws.com"
        ]
      },
      "Action": "sts:AssumeRole"
    }
  ]
}
EOF
}

resource "aws_iam_policy" "default" {
  name        = "test-policy"
  path        = "/"
  description = "IAM  Policy"

  policy = jsonencode({
    "Version": "2012-10-17",
    "Statement": [
        {
            "Action": "s3:ListBucket",
            "Resource": *,
            "Effect": "Allow"
        },
        {
            "Action": [
                "s3:PutObject*",
                "s3:GetObject*",
                "s3:DeleteObject*"
            ],
            "Resource": *,
            "Effect": "Allow"
        }
    ]
})
}

resource "aws_iam_role_policy_attachment" "default" {
  depends_on = [aws_iam_policy.default, aws_iam_role.default ]
  policy_arn = aws_iam_policy.default.arn
  role       = aws_iam_role.default.name
}

resource "aws_iam_role_policy_attachment" "ssm_attach" {
  role       = aws_iam_role.default.name
  policy_arn = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
}

resource "aws_iam_instance_profile" "default" {
  name        = "${var.aws_profile}-${local.service}"
  role        = aws_iam_role.default.name
  depends_on  = [aws_iam_policy.default, aws_iam_role.default, aws_iam_role_policy_attachment.default ]
}

Module
module "instance" {
  source  = "cloudposse/ec2-instance/aws"
  version = "1.4.0"

  ssh_key_pair                = var.ssh_key_pair
  instance_type               = var.instance_type
  instance_profile      = aws_iam_instance_profile.default.id
  vpc_id                      = var.vpc_id
  security_groups             = var.security_groups
  subnet                      = var.subnet
  name                        = "ec2"
}

Will throw the earlier Error "Invalid count argument"
Comment instance_profile and it will work
module "instance" {
  source  = "cloudposse/ec2-instance/aws"
  version = "1.4.0"

  ssh_key_pair                = var.ssh_key_pair
  instance_type               = var.instance_type
  #instance_profile      = aws_iam_instance_profile.default.id
  vpc_id                      = var.vpc_id
  security_groups             = var.security_groups
  subnet                      = var.subnet
  name                        = "ec2"
}

After initial apply, you can then un-comment instance_profile and it will apply
module "instance" {
  source  = "cloudposse/ec2-instance/aws"
  version = "1.4.0"

  ssh_key_pair                = var.ssh_key_pair
  instance_type               = var.instance_type
  instance_profile      = aws_iam_instance_profile.default.id
  vpc_id                      = var.vpc_id
  security_groups             = var.security_groups
  subnet                      = var.subnet
  name                        = "ec2"
}

Screenshots
No response
Environment
Mac OS
TF 1.8.2
Additional Context
No response

I am still seeing this error with the 1.6.0 tag.

The cause is:
https://github.com/cloudposse/terraform-aws-ec2-instance/blame/8e754f8620742138c7fea981dc3ec77230b73685/main.tf#L6
locals {
  instance_profile_count = module.this.enabled && var.instance_profile_enabled && var.instance_profile == "" ? 1 : 0
}

This is then subsequently used as a count, but it depends on knowing the name of the instance profile before it can be calculated. If your instance profile name is being generated by a module, rather than by declaring the resource directly in the same module as occurs in the example used for testing, then this causes the error as seen above.
The only workaround currently seems to be if you can predict the name of the created profile and just have that as a string literal passed to the instance_profile variable.

Or you can change it to
locals {
-  instance_profile_count = module.this.enabled && var.instance_profile_enabled && var.instance_profile == "" ? 1 : 0
+  instance_profile_count = module.this.enabled && var.instance_profile_enabled ? 1 : 0
}

Also side note that it seems like a bug that var.instance_profile == "" is part of the condition to enable the instance profile. Sounds more like it should be !=. However, even if it were, it would most likely still cause OP's error.

I don't think that is a bug. There are three modes:

no instance profile should be used (var.instance_profile_enabled == false)
a default instance profile should be created and used (var.instance_profile_enabled && var.instance_profile == "")
a given instance profile should be used and no default created (var.instance_profile_enabled && var.instance_profile != "")

I think breaking those last two out with a boolean flag like create_instance_profile and assigning it the name in var.instance_profile, or simply using var.instance_profile if creation is disabled, would be the way to go. But this would be a breaking change as it modifies the semantics of the inputs.


Updated dependencies versions

Fixes #1
Fixes #2

Removed noReflect option (https://youtrack.jetbrains.com/issue/KT-44361)
Added -Xjvm-default=all-compatibility to make interface default methods compatible (https://kotlinlang.org/docs/java-to-kotlin-interop.html#compatibility-mode-for-default-methods)
Updated dependency versions (there was some issue I couldn't understand with updating gradlew to 7.4, for now kept it as it is)

Please let me know if there are any suggestions.

@morazow , thank you for your interest and contributions.
Since technically I am not working for badoo anymore, I am currently not in position to approve or reject changes in badoo organization. What I suggest to do is the following:

Fork this repo and play around with it for a few weeks. Make it compatible with latest Kotlin and JVM trends, etc. Fix tests.
Make one combined pull request.
I'll ping a person who still works for badoo and who will be able to review & approve changes.

Please note, Exasol made a lot of changes in the most recent versions. For example, now the latest protocol version is 3. Exasol SAAS uses OpenID tokens for authentication. Encryption is now enabled by default and it will be mandatory starting from Exasol v8.
It might be worth sticking with JDBC for production-critical workloads. The only real advantage of kexasol is "CSV streaming".

Hey @littleK0i,
Thanks for the update! I have added changes for other two issues, I'll check issues with build.
It would be good to have continued maintenance of the library. At the moment, we are going to use it for a connector in enclosed cloud service. As you said we would like to use the CSV features from Java.
I'll discuss with our PM if joint collaboration could be arranged. Thanks a lot for the great work!

Ah, you're from Exasol dev team.
In theory, you may just fork this repo and maintain it in Exasol organization. Since the license is Apache 2.0, no one will object to this.


v9.2

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin , please rerender

the error message is not helpful
@gqmelo
do you have any hints here?

the error message is not helpful
@gqmelo
do you have any hints here?

So, the message is:
x86_64-conda_cos6-linux-gnu-c++: fatal error: no input files
compilation terminated.
make[4]: *** [alloc-ipa.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `$SRC_DIR/build/gdb/gdbserver'
make[3]: *** [subdir_do] Error 1
make[2]: make[3]: Leaving directory `$SRC_DIR/build/gdb'
*** [all] Error 2
make[2]: Leaving directory `$SRC_DIR/build/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `$SRC_DIR/build'
make: *** [all] Error 2

Looks like the compiler is being called without any input files at some point. Maybe some env var is not set, making a path blank?

But there is also this warning before the error:
x86_64-conda_cos6-linux-gnu-c++: warning: '-x c++' after last input file has no effect

Maybe this is causing the error? Is there a chance that this -x c++ is added by conda-forge compiler?

the error message is not helpful
@gqmelo
do you have any hints here?

So, the message is:
x86_64-conda_cos6-linux-gnu-c++: fatal error: no input files
compilation terminated.
make[4]: *** [alloc-ipa.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `$SRC_DIR/build/gdb/gdbserver'
make[3]: *** [subdir_do] Error 1
make[2]: make[3]: Leaving directory `$SRC_DIR/build/gdb'
*** [all] Error 2
make[2]: Leaving directory `$SRC_DIR/build/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `$SRC_DIR/build'
make: *** [all] Error 2

Looks like the compiler is being called without any input files at some point. Maybe some env var is not set, making a path blank?

Don't know, I just checked on "linux from scratch" and the steps are similar, I will try to add the verbose mode to the makefile to see if it is going to be helpful

But there is also this warning before the error:
x86_64-conda_cos6-linux-gnu-c++: warning: '-x c++' after last input file has no effect

Maybe this is causing the error? Is there a chance that this -x c++ is added by conda-forge compiler?

Probably, but I am not sure that it is causing the problem. However, we can check it

I was searching and it seems to see somekind of race condition
But I am not sure, I will try to compile it with just one core, let's see

There is a small problem here
make[4]: Circular alloc-ipa.o <- ../alloc.c dependency dropped.

it seems as it found a circular dependency, the makefile removed it from the list of files to be compiled, and it is failing exatcly with this file. Well, that is a guess, but lets see how is it going to work when compiling with just one thread

Just saw that, it will not work for make <=3.81, so I updated the build section

@conda-forge-admin , please rerender

@marcelotrevisani why did you delete run_test.sh and process_to_debug.py ?


typo: Double word "be"

@nschonni : Thanks for your contribution! The author, @jeffgilb, has been notified to review your proposed change.


about the paper

Hello! When will you release your full paper?

Thank you for your interest in our work. We are pleased to inform you that our paper has been published online: cvpr24_ast

Thanks for your interest in our work. We are pleased to inform you that our paper has been published online: cvpr24_ast


XD UI Kit

Hello, friends,
Are there any "Get Flutter" UI kits available for adobe XD?

Yes , we have soon will share in docs.

@PietechSolution Thank you!

@eashanui You can access the XD link now on our docs.
http://docs.getflutter.dev/


What about wrong codes?

Hi! Interesting plugin!
Tested and works well but not sure about "Wrong code" event.
I only receive:
Error
We're sorry, but an unhandled error occurred. Please see the details below.
Wrong code!
/var/www/html/usi/plugins/vojtasvoboda/codelogin/components/CodeLogin.php line 95
/*
* Find user by password
*/
$users = new UserRepository();
$userToLog = $users->getUserByPassword(array_get($data, 'code'));
if ($userToLog === null) {
$exception = new ValidationException([trans('vojtasvoboda.codelogin::lang.form.wrong_code')]);
throw $exception;
}
    /*
     * Authenticate user
     */

Do I have to work in "exception" condition? Or this is itegrated in plugin's components?

Hi. This exception is automatically handled by October AJAX framework, so be sure you have framework and framework extras directive included in your layout. For more see Readme, chapter 1.

:S
Strange behaviour....
I checked directives and they are listed:
...

{% component 'session' %}
{% framework %}
{% framework extras %}
{% scripts %}

October version: system Build 414,

Wow, that is strange. There has to be some changes in Ajax framework. I made a fix, can you please test it?
https://github.com/vojtasvoboda/oc-codelogin-plugin/commit/bb8c97e7dd9bdc0fff0b3051b17895bb78100856
Thanks a lot for reporting issue.

Same behaviour:
Edited file with line sent:
/var/www/html/sistemas/plugins/vojtasvoboda/codelogin/components/codelogin/default.htm
When I go to protected Page, it redirects to Login Page
If I put rigth Code, Protected page is shown
If I put a wrong Code, Exeption error Page is shown (attached)  :(

Sorry for the long delay. I found the problem and make new version 1.0.5 (now ready at the Market).
I've tested it on fresh CMS installation and everything works well with right login and also with bad one.


Avoid using "label" field when parsing PR response

To obtain the owner/fork-name combo, instead of reading it from "label" field from the PR response simply read from Head.Ref and Head.Repo.Owner.Name instead. This is because label is meant to be human-readable, isn't well-documented in GitHub API docs, and is unclear when it contains two components (delimited by :) or when it contains only one.
Maybe fixes #816

LGTM :+1:. The build fails at not accepting GitHub CLA?

Yes I needed to accept the CLA myself for this repo. We've only just enabled that feature.


[sql] integer columns for postgresql return null

select integer_value from mytable limit 1;
returns
[
{
"integer_value": null
}
]
The Setup:
-PostgreSQL 14.2, compiled by Visual C++ build 1914, 64-bit
-rustc 1.70.0 (90c541806 2023-05-31)
-tauri 1.4

thanks for the report. Do you have an example sql statement (the create table ... thingy) or something which i can use to test this?

@FabianLars Hello, faced the same issue today, here is some data to play around
Create Table: CREATE TABLE IF NOT EXISTS passwords (id int4 PRIMARY KEY NOT NULL,name varchar  NOT NULL,password varchar  NOT NULL,tags varchar  ,createdAt timestamptz  NOT NULL,updatedAt timestamptz  NOT NULL);
Insert Data: INSERT INTO passwords (\"id\",\"name\",\"password\",\"tags\",\"createdAt\",\"updatedAt\") VALUES ('1','test','test','test1,test2','2023-08-12T03:40:03.520Z','2023-08-12T03:40:03.520Z'),('2','test2','test2','test3,test2','2023-08-12T03:40:03.520Z','2023-08-12T03:40:03.520Z'),('3','test3','test3','test5,test4','2023-08-12T03:40:03.520Z','2023-08-12T03:40:03.520Z');
Select: SELECT "passwords"."id" FROM passwords ;

@jeffshadap An temporary solutions would be cast it to varchar like so
Select id::varchar from ...

@jeffshadap An temporary solutions would be cast it to varchar like so Select id::varchar from ...

Thanks


Fix header reflow issues

Closes #2246

Coverage remained the same at 71.735% when pulling 5d456b69f572ac813e1bf76adec4389dfcdd4d90 on eatonphil:header-reflow-fixes into 327b412be8a7a66f4782e4fb39cee58ea1b89159 on linode:master.

Coverage remained the same at 71.735% when pulling 5d456b69f572ac813e1bf76adec4389dfcdd4d90 on eatonphil:header-reflow-fixes into 327b412be8a7a66f4782e4fb39cee58ea1b89159 on linode:master.

Coverage remained the same at 72.325% when pulling 44c3617c91ec67acff5f23eaf6b1a3b61d862686 on eatonphil:header-reflow-fixes into bce405bc11d15b5f55397ae74429d8de8bfb2e3d on linode:develop.

Coverage remained the same at 72.325% when pulling 86ee9ae089aa49aed59b4ce6f475a813847e4104 on eatonphil:header-reflow-fixes into bce405bc11d15b5f55397ae74429d8de8bfb2e3d on linode:develop.

Coverage remained the same at 72.325% when pulling 86ee9ae089aa49aed59b4ce6f475a813847e4104 on eatonphil:header-reflow-fixes into bce405bc11d15b5f55397ae74429d8de8bfb2e3d on linode:develop.

If this is easy enough to fix, it may be worth doing it now:

Coverage remained the same at 72.325% when pulling 25c0acb7b89190c851ef60ce2d9b6e665bf398bf on eatonphil:header-reflow-fixes into bce405bc11d15b5f55397ae74429d8de8bfb2e3d on linode:develop.


/mv delete doesnt delete worlds

I'm on 2.6.0 with Spigot on 1.12.2
Whenever I try to /mv delete a world, it gives me a confirmation that the world was deleted - but upon restart the world re-appears.

Is this still happening? What is the world's name? Can you check after /mv delete if the world folder is deleted? If so, then it sounds like upon restart that a plugin is regenerated the world, or you have your default world specified as the world you're deleted and it's required on server start so it generates.

Closing ticket due to lack of information. Please open a new ticket with more valid information if this issue is still occurring in the latest versions or for a faster response, you can also receive support on the Multiverse Discord.


[#451] Add processors to remove sources

I needed to add two processors because this process takes multiples steps. One
of them deletes all sources' data except the trials. This is because a trial
can have multiple sources, including sources that we don't want to remove. We
can't simply delete them, otherwise we would loose their IDs, so the process
has to be:

Run remove_sources_data to delete all data from the sources except the
trials;
Run all other sources' processors to update the remaining trials with
the data from sources we won't remove;
Run trial_remover to remove trials without records;
Run sources_remover to finally remove the sources themselves.

Fixes opentrials/opentrials#451

The reverse operation for this would be to run the corresponding processor(s), right?
I haven't found anything suspicious, so I guess this is ready to be merged. I even learned a thing or two about the libs we're using while reading this :)
Let's merge and run it 👍


google.java.functions-framework builder does not support Gradle Kotlin DSL build.gradle.kts

Describe the bug
Having created a project via gradle init (Gradle 8.7) and chosen the Kotlin DSL, the following error ultimately surfaces:
[builder] Done "./gradlew clean assemble -x test --build-cache --quiet" (1m6.044632762s)
[builder] === Java - Functions Framework<EMAIL_ADDRESS>===
[builder] --------------------------------------------------------------------------------
[builder] failed to build: (error ID: 0f436744):
[builder] function has neither pom.xml nor already-built jar file; directory has these entries: .git, .gitattributes, .github, .gitignore, .gradle, README.md, build, build.gradle.kts, gradle, gradlew, gradlew.bat, settings.gradle.kts, src

Creating a project via gradle init and choosing the Groovy DSL leads to a buildable project.
Note that it seems necessary to "flatten" the project out of its default, multi-module shape. I don't believe this is relevant to the above, but will be necessary to avoid masking the error above.

Additional context
How are you using GCP buildpacks?

[x] pack and the gcr.io/buildpacks/builder
[ ] Cloud Functions
[ ] Cloud Run
[ ] Cloud Build
[ ] App Engine Standard
[ ] App Engine Flex

Did this used to work?
(Yes/No)
Unknown
What language is your project primarily written in?
(Python/Java/Node.js/Go/etc.)
Kotlin
Steps To Reproduce
Steps to reproduce the behavior:

gradle init per above, choosing Application, Kotlin, Java 21, Single application project, Kotlin DSL, no new apis/behaviors
"flatten" the generated code by moving src up out of app and removing the include from settings.gradle. Note that this is to avoid masking the error.
pack build \         --builder gcr.io/buildpacks/builder:latest \         --env GOOGLE_FUNCTION_SIGNATURE_TYPE=http \         --env GOOGLE_FUNCTION_TARGET=org.example.App \         --env GOOGLE_RUNTIME_VERSION=21 \         my-first-function

Expected behavior
It builds.
Actual behavior
It gives the error above:

function has neither pom.xml nor already-built jar file

The error appears to come from:
https://github.com/GoogleCloudPlatform/buildpacks/blob/5bbd4eb223214116d2257d134c98067fc8ba1b69/cmd/java/functions_framework/main.go#L146
Earlier in that func classpath, the Gradle check only checks for (Groovy DSL syntax) build.gradle, neglecting to check for build.gradle.kts:
https://github.com/GoogleCloudPlatform/buildpacks/blob/5bbd4eb223214116d2257d134c98067fc8ba1b69/cmd/java/functions_framework/main.go#L119

Note that a fix to support build.gradle.kts went into the google.java builder in https://github.com/GoogleCloudPlatform/buildpacks/commit/37ecf33ead9b4feb296fd15b25a0d1f16825cc30 , but that did not touch the functions-framework builder.

Hi @StephenWithPH, thank you for spotting this issue, and for providing the detailed analysis.
I can reproduce this issue on my end. I'm working on a fix for this.
In the meantime, could you share the test app that you created? If possible, could you share it as a Github repo? I am specifically interested in the build.gradle.kts & settings.gradle files in your app.

@SandeepTuniki ... that's great to hear! Thank you for picking this one up.
You can see a repro (same code works with Groovy DSL and fails with Kotlin DSL) at https://github.com/StephenWithPH/buildpack-kotlin-dsl-repro .

Hi @StephenWithPH, thanks for the extra details! I dug into this and found that the fix is a bit more involved than just adding a check to the build.gradle.kts file. This is actually a feature we haven't fully implemented yet—Cloud Functions doesn't currently support Kotlin DSL.
We've got this on our radar for future updates, but for now, I'd recommend using either Maven or Gradle with Groovy DSL. We've got some helpful guides on that here: [Link to guides].

@SandeepTuniki ... the non-functions-framework builder for Java does handle Kotlin DSL. See https://github.com/GoogleCloudPlatform/buildpacks/issues/26 and https://github.com/GoogleCloudPlatform/buildpacks/commit/37ecf33ead9b4feb296fd15b25a0d1f16825cc30 .
Possible to crib from that in the functions-framework Java builder?

@StephenWithPH Yes, I went through that issue and PR already while investigating. We found that changes for Functions are not as straightforward as the earlier ones. This feature is on our roadmap, but I can't provide a specific timeline right now due to other pressing priorities. Rest assured, I'll share updates as soon as we have a clearer picture.


Add gallery thumbnails

This reduces the download requirement for the main page by about 1967.5KiB (the original screenshots totaled about 2007 KiB, vs 39.5KiB for the thumbnails).
This is only a basic thumbnail, a more complete version would include more sizes.
The images are resized to 380x214 at 50% quality.
Also, it would be great if jekyll could generate these automatically (I didn't look into this).

:+1:


add config

Coverage increased (+0.5%) to 63.615% when pulling 053c0a36384bc1418fb28051faf0daa13a81da8f on config into 7a0600ff441b006d28b77d38d06cfa9a2975b395 on master.


Perform in-place resampling during read_audio.

For long audio files (a single ~800MB mp3 in my case, 48kHz sampling rate), torchaudio.load is extremely expensive memory-wise.
This code performs channel reduction and resampling on-the-fly, reducing the peak memory usage significantly.

Aren't sox effects going to be deprecated in the newest version of torchaudio because of their movement to ffmpeg?
Maybe for multi-channel 48 kHz audio it is better to use something like this - https://github.com/snakers4/silero-vad/blob/master/utils_vad.py#L35-L38, with plain channel averaging?

Aren't sox effects going to be deprecated in the newest version of torchaudio because of their movement to ffmpeg? Maybe for multi-channel 48 kHz audio it is better to use something like this - https://github.com/snakers4/silero-vad/blob/master/utils_vad.py#L35-L38, with plain channel averaging?

I don't know.
Looking at torchaudio 2.2.0 documentation it seems fully supported.
Looking at torchaudio 0.7.0 documentation it seems that other classes were deprecated, but this API wasn't.
The main benefit from the proposed implementation is that the file is never fully loaded into memory, reducing the footprint by 3-6x (48kHz, stereo)

I mean this discussion - https://github.com/pytorch/audio/issues/2950
Maybe it is worth exploring the mainstream option, that would not break in future?

I mean this discussion - pytorch/audio#2950
Maybe it is worth exploring the mainstream option, that would not break in future?

Thanks for the link.
Going through that and similar discussions, found pytorch/audio#2586.
It appears like this isn't solved in torchaudio yet, however they do have this capability for sox specifically.
It seems like sox is not deprecated, it is simply optional now.
Three options I see moving forward (without changing torchaudio :)):

Do nothing; I patch my local code to resample on-the-fly.
Keep both: Implement sox-based resampling, with fallback to current implementation if sox backend is not available.
SoX-only: keep this PR as is. Instruct users to install sox.

What do you think?

Do nothing; I patch my local code to resample on-the-fly.

It is an open question, whether we should support such edge cases in the vad code and if there is an edge case, I assume the user should be knowledgeable enough to solve it.

Keep both: Implement sox-based resampling, with fallback to current implementation if sox backend is not available.

I wonder if torchaudio has a native flag to check the avsilable backends, not to complicate the vad usage instructions, to keep it simple.
If so, it is optimal then.

SoX-only: keep this PR as is. Instruct users to install sox.

This definitely is a bad idea, we opted for torchaudio because it was bundled with torch, usually and just worked.

Keep both: Implement sox-based resampling, with fallback to current implementation if sox backend is not available.

I wonder if torchaudio has a native flag to check the avsilable backends, not to complicate the vad usage instructions, to keep it simple.
If so, it is optimal then.

I can use torchaudio.list_audio_backends() to detect whether sox is supported.
Agreed?
If so, I'll fix and update this PR.

I can use torchaudio.list_audio_backends() to detect whether sox is supported.
Agreed?

https://github.com/snakers4/silero-vad/assets/12515440/69fbd9f6-b3cf-4b8f-8186-2e9e3b6a9faa

I can use torchaudio.list_audio_backends() to detect whether sox is supported.
Agreed?

giphy.mp4

The correct function name is torchaudio.list_audio_backends() and the correct backend name is sox_io

sox_io is what you get if you don't have libsox-dev installed.
It does not get the work done.
If you install it, you'll get 'sox'.
list_audio_backends() - apologies, fixing.

The correct function name is torchaudio.list_audio_backends() and the correct backend name is sox_io

sox_io is what you get if you don't have libsox-dev installed. It does not get the work done.
If you install it, you'll get 'sox'. list_audio_backends() - apologies, fixing.

I encountered an error when loading mp3 using torchaudio 0.14.0 The error message is:
Traceback (most recent call last):
  File "/root/.cache/torch/hub/snakers4_silero-vad_master/utils_vad.py", line 134, in read_audio
    wav, sr = torchaudio.sox_effects.apply_effects_file(path, effects=effects)
  File "/opt/conda/lib/python3.9/site-packages/torchaudio/sox_effects/sox_effects.py", line 285, in apply_effects_file
    raise RuntimeError("Failed to load audio from {}".format(path))
RuntimeError: Failed to load audio from test.mp3

The torchaudio.list_audio_backends() output ['soundfile', 'sox_io']
After update torchaudio to 2.3.0, the error disappeared and the torchaudio.list_audio_backends() output ['soundfile', 'ffmpeg']


Updatealldev

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: LouisGrx:x: louis girauxlouis giraux seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@LouisGrx Hi, it seems there's an issue with the CLA, please see the [above comment}(https://github.com/aragon/aragon-wiki/pull/475#issuecomment-500506684) to resolve the issue.

hey @Smokyish,
I changed my machine and looks like the git parameters messed things up. Should be ok with the next ones but I couldn't solve the CLA problem on this one.


Merge GO:0031497 chromatin assembly into GO:0006325 chromatin organization

There is no difference between these terms with the reorganization in #22135
There were only 20 direct EXP annotations, see https://docs.google.com/spreadsheets/d/1qT9dWC7iBk7jBtqTMw7BuLPkfsWrQDdqTkeSjlpN7EE/edit#gid=0.
These have been re-housed or can be automatically reannotated to GO:0006325 chromatin organization upon merge.

Dear all,
The proposal has been made to obsolete GO:0010847 regulation of chromatin assembly. The reason for obsoletion is that the the 'parent' term, GO:0031497 chromatin assembly, has been merged into its parent  GO:0006325 chromatin organization. There were 2 annotations to  this term, see regulation of chromatin assembly
2 EXP, see https://docs.google.com/spreadsheets/d/1qT9dWC7iBk7jBtqTMw7BuLPkfsWrQDdqTkeSjlpN7EE/edit#gid=0
1 dictyBase, 1 UniProt (changed). There are no mappings to this term, this term is not present in any subsets.
You can comment on the ticket:
https://github.com/geneontology/go-ontology/issues/23549
Thanks, Pascale