Unable to get public accounts media

Requirements

[x] I've searched the Issues
[x] I've read the basic concepts
[x] I'm using the latest version

Platform

[x] I'm using Node.js version14.17.4

Description
trying to get an igtv of a public instagram page, but it says media is unavailable, while it's available and anyone can see it
Code
// link = "https://www.instagram.com/tv/CTxlYjplcWE/?utm_medium=copy_link";
var id = ref.urlSegmentToInstagramId("CTxlYjplcWE");
// id =<PHONE_NUMBER>019671428;
ig.media.info(id).then(m =>{
      .....
})
.catch(ex => { .... })

Error and Output
IgResponseError: GET /api/v1/media/2662073270019671428/info/ - 400 Bad Request; Media not found or unavailable
    at Request.handleResponseError (.../node_modules/instagram-private-api/dist/core/request.js:125:16)
    at Request.send (.../node_modules/instagram-private-api/dist/core/request.js:53:28)
    at async MediaRepository.info (.../node_modules/instagram-private-api/dist/repositories/media.repository.js:9:26)

I can repro this. Looks like it requires authentication now:
https://i.instagram.com/api/v1/media/1099495795706759376_31787241/info

I can repro this. Looks like it requires authentication now:
https://i.instagram.com/api/v1/media/2662073270019671428/info/

First of all i do a login to my account, then i use this function, i think i authenticated before but still get nothing from it

IIrc, the format should be /^\d+_\d+$/ so e.g. 32454432_45544332436632.

@Nerixyz that doesnt change anything, still says login required.

still says login required.

GET /api/v1/media/2662073270019671428/info/ - 400 Bad Request; Media not found or unavailable

That's not login-required. If you get a login_reqiured, you need to relogin your session.

@Nerixyz were talking about anonymous access here, so your comment is not appropriate.

IIrc, the format should be /^\d+_\d+$/ so e.g. 32454432_45544332436632.

how can i get such id? the url-to-code library give me that kind of id<PHONE_NUMBER>019671428).

how can i get such id? the url-to-code library give me that kind of id<PHONE_NUMBER>019671428).

This kind of id might work too now that I think about it. I'll take a look at it.

were talking about anonymous access here, so your comment is not appropriate.

This library or rather the IG Android API requires you to be logged in. You can't see a post in the app without being logged in.

how can i get such id? the url-to-code library give me that kind of id<PHONE_NUMBER>019671428).

This kind of id might work too now that I think about it. I'll take a look at it.

were talking about anonymous access here, so your comment is not appropriate.

This library or rather the IG Android API requires you to be logged in. You can't see a post in the app without being logged in.

Tnx to you if you look at it. i just have the link and needs to get media by that link, i try this such id but it was unsuccessful

when i send it as an direct item, it show me that it's a "placeholder" item but of course it's "felix share"
the response data is :
{
  item_id: '30111053639820498298384609236221952',
  user_id:<PHONE_NUMBER>,
  timestamp: '1632323488606047',
  item_type: 'placeholder',
  placeholder: {
    is_linked: false,
    title: 'Post Unavailable',
    message: 'This post is unavailable.'
  },
  client_context: '6846460932261670658',
  show_forward_attribution: false,
  is_shh_mode: false,
  tq_seq_id: 2706
}

it show me that it's a "placeholder"

That's because this library is emulating an outdated version of the app.

outdated version of the app.

@Nerixyz
oh i see. can it be update? i have another issue about version of app (#1471), and there is several issues and a pull request

oh i see. can it be update?

Yeah there's a PR, though I can't publish a new version on npm.

oh i see. can it be update?

Yeah there's a PR, though I can't publish a new version on npm.

oh nice, so i will use that PR
and if you found any update about that link and id, i will be glad if you help me
tnx

Yeah there's a PR, though I can't publish a new version on npm.

Where?

I got the request working, but it seems to only work with authentication:
GET /api/v1/media/2662073270019671428/info/ HTTP/2.0
Host: i.instagram.com
authorization: Bearer IGT:2:eyJkc191c2VyX2lkIjoiNDkzOTg0NTg5MDUiLCJzZXNzaW9uaW...
user-agent: Instagram <IP_ADDRESS>.121 Android

@Nerixyz  What is your suggestion for me to fix this problem?

@Nerixyz What is your suggestion for me to fix this problem?

Basically #1471 would need to be addressed.

@Nerixyz What is your suggestion for me to fix this problem?

Basically #1471 would need to be addressed.

Yes, is there any ways for me to fix this for myself? or i must wait until new version of package?

Yes, is there any ways for me to fix this for myself?

You can clone a repo that has updated constants. In your package.json you can specify a path dependency (docs). Though note that you have to compile the library first (npm ci && npm run build).

As a workaround, you can make a request like this:
GET /p/CTxlYjplcWE/?__a=1 HTTP/1.1
Host: www.instagram.com
User-Agent: Instagram <IP_ADDRESS>.120 Android
Authorization: Bearer IGT:2:eyJkc191c2VyX2lkIjoiNDkzNzgxNzEzMzQiLCJzZXNzaW9uaW...

You can omit the last line if you under the rate limit.

As a workaround, you can make a request like this:
GET /p/CTxlYjplcWE/?__a=1 HTTP/1.1
Host: www.instagram.com
User-Agent: Instagram <IP_ADDRESS>.120 Android
Authorization: Bearer IGT:2:eyJkc191c2VyX2lkIjoiNDkzNzgxNzEzMzQiLCJzZXNzaW9uaW...

You can omit the last line if you under the rate limit.

Tnx, as you mention the app version on the request is different from this package app version, and it works well

Yes, is there any ways for me to fix this for myself?

You can clone a repo that has updated constants. In your package.json you can specify a path dependency (docs). Though note that you have to compile the library first (npm ci && npm run build).

I didn't found any packages with updated constants, is there any standard schema for that? to find updated version info and use them in repo

It's related to #1571


The Deep link to navigate to a chat is not working on the android client.

Steps to reproduce

Open the Teams android client (tested on Samsung Galaxy S21).
Click on the deep link to navigate to a chat that created using the method suggested in the official documentation.
Instead of navigate to the chat, a message saying "No tab available" is displayed.

Expected behavior
It navigates to the chat successfully.
Actual behavior
Instead of navigating to the chat, a message saying "No tab available" is displayed.
Error details
This issue started occurring suddenly within the last week, even though it was working fine before. I suspect that a recent update might have caused this bug.
P.S. - The displayed message is translated from the Korean "탭이 없습니다" to English, so it may not be the exact message. Thank you for your understanding :)

No response

Additionally, I tested that it works correctly on desktop, web, and iOS clients.

@ungsdev, thanks for raising your issue. We will check this at our end and will get back to you.
Just for confirmation, you are using below deep link URL right? and is it a group chat?
https://teams.microsoft.com/l/chat/<chatId>/conversations

@Prasad-MSFT, thanks for reply. Yes. I use below deep link url. and it is a group chat.
<EMAIL_ADDRESS>
@ungsdev, thanks for raising your issue. We will check this at our end and will get back to you. Just for confirmation, you are using below deep link URL right? and is it a group chat? https://teams.microsoft.com/l/chat/<chatId>/conversations

@ungsdev, we are able to repro this issue in Mobile (Android)Teams version.

We have raised a bug for the same and engineering team is looking into it. We will inform you once we get any further update. Thanks!

@Prasad-MSFT Sorry to bother you, but this issue has been ongoing for over a month, so I wanted to check in again. Is there any updates or progress on this issue? Thank you.

I am experiencing the same issue. I would like to know when it will be resolved.

We are closing this issue for now. Please feel free to reopen if required. Thanks!


SYNBICT: setPropertyValue not implemented

Running python3 sequences_to_features.py -n http://synbict.org -t ../test/genetic_nand.xml -f ../test/cello_library.xml raises:
Traceback (most recent call last):
  File "sequences_to_features.py", line 845, in <module>
    main()
  File "sequences_to_features.py", line 807, in main
    annotated_identities = feature_annotater.annotate(target_library, int(args.min_target_length))
  File "sequences_to_features.py", line 418, in annotate
    True, min_target_length)
  File "sequences_to_features.py", line 269, in copy_component_definition
    definition_copy.setPropertyValue('http://wiki.synbiohub.org/wiki/Terms/synbiohub#ownedBy', '')
  File "/Users/bbartley/Dev/git/sd2/SYNBICT_venv/lib/python3.7/site-packages/sbol-2.3.3b0-py3.7.egg/sbol/object.py", line 292, in setPropertyValue
    raise NotImplementedError("Not yet implemented")

This method has recently been changed in pysbol. It used to raise a LookupError if the property did not exist. Now it sets that property. Mimic the latest behavior.
This method was deprecated in the same pull request. We should probably deprecate it in this library as well.

setPropertyValue can have odd or unexpected behavior that should be mimicked. It only sets the first element in an underlying list. For example, note the final value of the ModuleDefinition's roles property:
>>> import sbol
>>> md = sbol.ModuleDefinition('md')
>>> md.roles = [sbol.SBO_PRODUCT, sbol.SBO_LIGAND]
>>> md.roles
['http://identifiers.org/biomodels.sbo/SBO:0000011', 'http://identifiers.org/biomodels.sbo/SBO:0000280']
>>> md.setPropertyValue(sbol.SBOL_ROLES, '')
>>> md.roles
['', 'http://identifiers.org/biomodels.sbo/SBO:0000280']
>>>

The C++ code that underlies pysbol defaults to the value being a Literal, not a URIRef. So if setPropertyValue gets a string that is neither a Literal nor a URIRef, convert it to a Literal.


Add support for mappings/////

Where the returned resource is a JSON Paths file as generated by schema-ddl v0.2.0.

Before doing this we need to check this is really the right direction of travel.
The question is: do we really need a static mapping file to perform the conversion?
In Snowplow's SQL enrichment, we map from JDBC types into JSON, all dynamically without creating some kind of intermediate representation of the transformation.
The idea of an intermediate representation of the transformation here (the JSON Paths file) originates in AWS' own COPY FROM JSON syntax. But do we really need this static file to do our transformation?
Needs further thought.


Search bar no longer working

This code:
      <SearchBar
        lightTheme
        onChangeText={onChangeSearchText}
        placeholder="Search Players..."
      />

Is causing this crash:

The issue is that SearchBar isn't being exported from this package although I don't know why. The code seems fine

I encountered the issue too and resolved it by using another name instead of SearchBar. If I use something likeimport { SearchBar as _SearchBar } from 'react-native-elements', it's working pretty well!

Just pushed a new release and this is fixed, thanks for the feedback and pointing this out! Best.


JSONEncoding not working

if Use parameters with JSONEncoding it returns response with string included as \t\t\n\t\n\t\t\n\t\n\t\t\n\t\n\t\t\n\t\t\t ?
how to handle this ?

Could you provide an api sample?

Closing this due to inactivity, please come back if you're still having issues @iOSUser110! We'd love to help get this working for you 😄


Add "exporter as windows service" guide

sabj

depends on #52 and #16

It should be checked if exporter can handle windows service shutdown (relates to #17)


OTG-FS enabling for STM32L475 disco iot board

This patch enable USB for the disco_l475_iot board.

Enable correct USB pinmux
Enable usbotgfs node in dts
Add support for LSE clock
Add support for MSI PLL-Mode
Add support for MSI as source clock for USB

Codecov Report

Merging #8841 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8841   +/-   ##
=======================================
  Coverage   52.32%   52.32%
=======================================
  Files         195      195
  Lines       24730    24730
  Branches     5140     5140
=======================================
  Hits        12941    12941
  Misses       9715     9715
  Partials     2074     2074

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f733da8...b87deed. Read the comment docs.

Thanks for testing @ydamigos, I'm going to check this sample as well (only tested usb-net for now).

Today I tried cdc_acm on my side as well and I get same error as @ydamigos (failed to set dtr/rts). Looking at the code, it seems the USB controller does not generate generates SETUP complete IRQ (USB_OTG_DOEPINT_STUP) anymore (after a certain sequence). This causes control transfer failure and leads to cdc_acm errors...  However host is still sending new SETUP tentatives, controller correctly generates SETUP PKT RECEIVED interrupt (STS_SETUP_UPDT) but never generates the SETUP complete one.
It's interesting to note that I also generated a cdc_acm sample from STM32CubeMX application and I obtained same errors. So upper stack does not seem to be the problem here.

@ydamigos , @loicpoulain , any news on that problem?
Did you manage to identify CubeMx issue?

@erwango Unfortunately, I didn't have much time to check it. I'll try to do it asap.

@erwango, this seems to be L4 specific yes and since it reproduced with cube MX, it's probably an hardware or Hal issue. Can you check internally if it's a known or reported issue. We can speak next week and I can also share the cubeMX config if necessary.

@loicpoulain , thanks for the update.
Do you think it could be linked to the board itself (as we were uncertain USB could work w/o HW fix) or more likely L4 generic?

ping @loicpoulain

ping @loicpoulain

I've sent some debug info to Erwan for internal investigation.
This is not strictly a blocker since the problem does not occur with all USB classes (e.g. ok with USB ECM/EEM), but let's wait a bit more to see if root cause can be found on ST side.

@loicpoulain, I rebased your change and got it working.
Issue lies in missing configuration of SYS_CLOCK_HW_CYCLES_PER_SEC.
It is set depending of the use case in Kconfig.defconfig, so you need to tweak this part to set it to 48000000 in case USB is used.
Can you cross check and confirm?

@erwango , I rebased and do not observe the issue anymore, not sure why.
@ydamigos can you please check/test again?

CI failed due to mps2_an385 issue

recheck


feat: add warning banner to recipe page

What does this PR do?
This PR just have the code for adding the warning banner to the recipe page. It is based on https://github.com/containers/podman-desktop-extension-ai-lab/pull/856
Screenshot / video of UI

What issues does this PR fix or reference?
it resolves #874
How to test this PR?

same as #856 but on the recipe page

@jeffmaury ok, i'll merge this then.
Can you please open an issue elaborating a bit more about your first concern? I didn't get it tbh.
For the podman machine should we open an issue as well to investigate more and tell it to the podman team? Or maybe @vrothberg have some more info about it

For the podman machine should we open an issue as well to investigate more and tell it to the podman team? Or maybe @vrothberg have some more info about it

I think it's best to open an issue against Podman with a reproducer.


avoid using global

global is not standard in the browser (yet?), using it blocks using this lib with some build tools (e.g., angular-cli with socket.io imports)
see https://github.com/socketio/socket.io-client/issues/1166#issuecomment-386764202
@TooTallNate @nevir

Published as<EMAIL_ADDRESS>(latest source is at https://github.com/amitport/blob)


ci: add Android x86_64

This PR enables Android x86_64 in the CI/CD as suggested in https://github.com/uutils/coreutils/pull/5821 and should be merged after it.

More failure!

Unfortunately yes :|

Do you have an idea why this android build is so unstable?
The emulator is configured for 2GB (2048MB) of RAM.
Can we test if increasing this to e.g. 8GB helps?
My phone has 12GB of RAM and I had sporadic errors due to memory allocation errors.

I started to look into the problem of why the android build is instable and how to improve.
I have one question: why is it running on a mac os runner? I read today that mac os the most expensive runner. Windows is next and linux would be the cheapest. So why is the android-runner a mac-runner?

I honestly don't know. Maybe you can find some explanation in the PR that introduced the Android CI?

I think the original reason was that hardware acceleration was only available on macOS VMs: https://github.com/ReactiveCircus/android-emulator-runner/issues/46 . According to https://github.com/ReactiveCircus/android-emulator-runner/issues/46#issuecomment-1899848624 this is no longer relevant and so it might be worth to try to switch to Linux.

it was the same with the freebsd runner (running on mac first), it is now much better :)

let's take this patch anyway :)


No ambermini

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

ambermini used to be a minified distribution of ambertools used in some packages (specially in the omnia channel). This is incompatible with the full ambertools distribution so we are using the run_constrained trick to explicitly declare it as such instead of crossing our fingers :D

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-admin, please rerender

If you wanted to condense the test a bit, I think ! conda install -c omnia ambermini would work too. Though the current test is absolutely fine. Actually, I'm a bit surprised conda doesn't have something like expect_failure for tests.

If you wanted to condense the test a bit, I think ! conda install -c omnia ambermini would work too. Though the current test is absolutely fine. Actually, I'm a bit surprised conda doesn't have something like expect_failure for tests.

Oh, silly me, I didn't think of that and ended up overengineering it. I'll make that change before the merge. Thanks!

Now I think of it, conda install -c omnia ambermini 2>&1 | grep -q "PackagesNotFoundError" would be better.

Well, the conda install solver will do whatever needed to be able to install ambermini next to ambertools which means it will downgrade to the non-run_constrained version if needed.
I have tested locally and you have to really specific about what you want:
This should fail as expected:
conda install omnia::ambermini 'conda-forge::ambertools>=19.11_*5'

I doubt this will help much, but I'll merge anyway. AT20 is being released soon and it will be marked as incompatible with ambermini too, but in that case it will be easier to pin because of the major version change (instead of the unnoticeable build number).


[MWC-WALLET] Swap if the mwcmqs listener is already started, doing a process to send via mwcmqs should use the listener, rather than complain that one is already started

swap --process --method mwcmqs  --dest xmfcZq9XPXZNF7xKdH25NbJaHGzbJapZcoFT3hfRi95FCbEvf9RS --secondary_fee_per_byte 1 -i 57b9b64d-c208-437c-863e-4a9fbe657e4d
when an mwcmqs listener is already started gives an error complaining that the listener is already started.  It should instead just use the listener.

Testing:
mwc-wallet> open
Password:
Command 'open' completed
mwc-wallet> listen -m mwcmqs
20200814 17:37:26.966 WARN grin_wallet_controller::controller - Starting MWCMQS Listener
Command 'listen' completed
mwc-wallet> 20200814 17:37:27.906 WARN grin_wallet_impls::adapters::mwcmq -
mwcmqs listener started for [xmgHFXM1ryJ1ug7kGPsjmDj8Gd7XC18cfhQ8n8uyjxL3JzAq9r73] tid=[3joWR68SozTVPrtV8HfGU]
Here is a swap command that sending the message with mwcmqs
mwc-wallet> swap --process -i c1529988-df34-4f8b-806a-77c273c2c8ad -m mwcmqs -d xmggm9xA2ryzDARaRKNEdbw9rmSHxyLTMCqNua8iSPjCQAvsyx6s
Command 'swap' completed


Error when trying "use with get" example

I tried the following example from the readme:
<button
  value="Hola!"
  {{on "click" (set this.greeting (get _ "target.value"))}}
>
  Español
</button>

When this is done on a route template with this.greeting living on the controller, #3 happens. When it's done in a component template with this.greeting living on the component instead, I get this error:
Error: Assertion Failed: you must pass a path and a value to the `(set)` helper. The value can be a defered value, using placeholder syntax, e.g. `(set this.value _)`

Repro in brand new app with latest Octane preview: https://github.com/CodingItWrong/set-helper-error

So it appears that this issue is being caused by the AST transform not running at all against co-located components, going to have to look into this upstream to figure out what's going on

This should be fixed in the latest releases, can you verify when you get a chance?

I just recreated the project with the latest Ember Octane Preview and<EMAIL_ADDRESS>but unfortunately I'm still getting the same error:
Error: Assertion Failed: you must pass a path and a value to the `(set)` helper. The value can be a defered value, using placeholder syntax, e.g. `(set this.value _)`

Reproduction repo has been updated: https://github.com/CodingItWrong/set-helper-error

I'm not sure if this is the same issue or not, but I am getting you must pass a path to {{set}}. Did mut used to not blow up if you passed something undefined to it? I'm confused why I see this with set and not with mut.

Sorry I didn't have time to dig into this. I'm releasing a new version of ember-set-helper which changes the API to match ember-simple-set-helper, and deprecating that addon. I'll be releasing a new major version then. I expect that these issues should be solved in the new version, I found a couple of edge cases and solved them, so I'm going to close this for now. Please reopen if it's still an issue!

Will try the new syntax soon and will report back if we encounter any errors. Thanks!


Fix the solidity combined-json result key

In solidity version 0.4.9 the --combined-json output has
changed.
Now the dictionary key by which a contract is identified is the relative
filepath followed by ':' and finally follow by the contract name.

merged #435 instead


Fixed "size is not defined" error when reporting options is defined.

undefined reporting options is now obsolete.
Warning: size is not defined Used --force, continuing.

created a pull for this issue. https://github.com/k-maru/grunt-filesize/pull/7


RAS-917 SupplementaryDatasetService dataset call via existsByExerciseFK not required

What and why?
Changes how we check if an SDS in already linked to a collection exercise since the collection exercise already has the liked sds in scope through the ORM instead of querying the database every time.
How to test?

Deploy to your env
Run the acceptance tests
publish a message to your sds topic

{
      "survey_id": "139",
      "period_id": "1912",
      "form_types": [
         "0001"
        ],
      "title": "Quarterly Business Survey | QBS | 139 | 1912",
      "sds_published_at": "2023-08-24T11:55:00Z",
      "total_reporting_units": 1,
      "schema_version": "v1.0.0",
      "sds_dataset_version": 2,
      "filename": "eccb61ad-4eb3-4714-8afd-8c8426960b43.json",
      "dataset_id": "eccb61ad-4eb3-4714-8afd-8c8426960b43"
}

make sure that in the logs there is no linked collection exercise found and that there is no log saying that the sds has been removed
check an sds entry has been added to the database
publish the same message again (you can edit the sds id to make sure that the old one has been removed and a new one added)
Make sure the above logs are now present and the new sds entry is in the database`

Jira
RAS-917

There's an @SDS acceptance test that can be run against this build too.

/deploy pricem

/deploy pricem

Moved to verified branch https://github.com/ONSdigital/rm-collection-exercise-service/pull/340


--explode option make the weekly reports not generated

Hello,
when using the --explode option, the weekly reports sounds not to be generated in incremental mode. is it the expected behavior?
I would expect to have some weekly reports for each database (and ideally an index to provide list of database, but can easily be managed in nginx for this part).
thx!

What is your pgbadger command?

full one is pgbadger --explode --format=jsonlog --outdir=/usr/share/nginx/html/reports --incremental --jobs 4 --retentio
n=0 --exclude-db=postgres --exclude-user=postgres --exclude-user=cloudsqladmin --wide-char --extra-files *json
which don't create the weekly reports.
just remove --explode will trigger the creation of daily and weekly reports

in fact, I think it is something which could be linked to this already corrected : https://github.com/darold/pgbadger/commit/63e3fb959eddbc10113e5833d6c248b7795a9f4a
I was using the "official" package available with apk. but using the last one available in github master, can"t reproduce the issue. therefore it is fine.


Missing hash key: "development" (KeyError)

Hello! First of all thank you for this shard. I have spotted a strange behaviour.
This is my configuration file:
ENABLED_ENV_PATH: "asd"
DISABLED_ENV_PATH: "qwe"

This is the code loading it:
Ambience.application(path_to_file, "development")
Ambience.load

This code triggers a compile exception with this stracktrace:
[4582919] *CallStack::unwind:Array(Pointer(Void)) +87
[4582810] *CallStack#initialize<CallStack>:Array(Pointer(Void)) +10
[4582762] *CallStack::new:CallStack +42
[4745529] *KeyError +41
[4745465] *KeyError::new<String>:KeyError +105
[4782014] *Hash(YAML::Type, YAML::Type) +270
[4781734] *Hash(YAML::Type, YAML::Type) +6
[4758057] *Ambience::Application#environment_configuration<Ambience::Application>:(Hash(String, String) | Hash(YAML::Type, YAML::Type) | Nil) +1161
[4756863] *Ambience::Application#load<Ambience::Application>:(Hash(String, String) | Hash(YAML::Type, YAML::Type) | Nil) +47
[4756619] *Ambience::load:(Hash(String, String) | Hash(YAML::Type, YAML::Type) | Nil) +107
[4728188] *Env::Manager::load_envs:(Hash(String, String) | Hash(YAML::Type, YAML::Type) | Nil) +204
[4527122] ???
[4537545] main +41
[233773866693] __libc_start_main +245
[4487785] ???
[0] ???

I can fix this specifing the development in the configuration file like this:
ENABLED_ENV_PATH: "asd"
DISABLED_ENV_PATH: "qwe"

development:

Why is it needed? Am I missing something?
By the way, it happens also with the kemal example in this repo.
Thank you.

@endorama Thanks for the test case. I'll take a look in the evening. By the way PR's are welcome. :smile:

@endorama I just pushed a new version. Can you check if this one works out for you?

Thank you! I'll test it in this week!

It works perfectly! Thank you for your time.


Manually add TypeForwardedTo in ref assemblies

We need to manually add TypeForwardedTo assembly attributes in ref assemblies for some packages. Tested locally:

WIP while confirming this resolves the original issue.

@Pilchie I searched for TypeForwardedTo assembly attributes in our *.cs files. Are there other ways of adding this attribute I'm not aware of (some MSBuild magic)?

This PR is ready for review and I'll follow up with the servicing request tomorrow.
A few items to potentially address as a followup:

How do we ensure everyone who added TypeForwardedTo attributes knows to add a Manual.cs file and set the property in the csproj?
I'll followup with corefx to see what mechanisms they have.

So this entire setup is manual, adding a type forward requires editing two or three files? As a temporary fix to 3.0 I understand how we ended up here, but for every future version this is going to be a maintenance nightmare.
The bare minimum requirement for this process in 3.1 needs to be adding an enforcement mechanism (e.g. code check makes sure everything is in sync). Even with that, this is going to prove painful unless it can be auto-generated like the rest of the ref assemblies.

Issue links?

Yes I filed https://github.com/dotnet/arcade/issues/4026 for a feature request. I'll file followup issues for enhancement improvements when this PR is complete.

@JunTaoLuo you guys should also consider enabling ApiCompat in your builds to catch this kind of issues early: https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.ApiCompat

A few unresolved issues:

We've decided that MSB3243 warnings are benign given the way we build our ref packs. However, I can't seem to disable the these build warnings specifically using NoWarn. Looking at the source code I tried setting ResolveAssemblyReferencesSilent property to true. This works but in the future it may hide other issues.
I see file version differences in FrameworkList.xml:

Assembly file versions seem to be generated based on the package version so it doesn't surprise me that this will be updated. Can someone confirm?
I see package version differences in PackageOverrides.txt:

These seem like package versions so I'm thinking that this file looks correct? cc @nguerrera @dsplaisted since I'm not sure how this file is used in conflict resolution.
I see assembly version and file version differences in PlatformManifest.txt:

The current build logic takes the PlatformManifest.txt generated by the .Runtime project which builds the shared framework with the implementation assemblies. If we want to use assembly versions of the ref assemblies instead, which would make sense to me, I'll need to update the logic. cc @nguerrera @dsplaisted since I'm not sure how this file is used in conflict resolution. Also, the same assembly file version issue as 2.

Assembly file versions seem to be generated based on the package version so it doesn't surprise me that this will be updated. Can someone confirm?

I believe assembly file versions are mostly ignored and agree they're generated based on package versions. As long as the source package version is of the .Ref package and not .Runtime package, I think we're good. But, to be sure, I defer to @nguerrera and @dsplaisted on this point too.

If we want to use assembly versions of the ref assemblies instead, which would make sense to me

We absolutely want to use assembly versions of the ref/ assemblies in the .Ref package as well as the wrapping installers. To do anything else would just muddle things.

You should be able to use MSB3243. (I've argued before that we should support NoWarn, but we don't. See  https://github.com/microsoft/msbuild/issues/442).
That said, can you share a .binlog with these warnings being generated, I'd like to confirm they are truly benign and see if they can be prevented instead of suppressed.

I believe the package versions should in PlatformManifest should remain at 3.0.0. Otherwise, if I ref 3.0 in a framework-dependent app + a 3.0.1 package, it won't deploy the 3.0.1 package and it would use the 3.0.0 in the shared framework if run on an unpatched machine.

I think it is fine for the file versions to change, as long as they match the reference assembly file versions.

+1 that AssemblyVersion in FrameworkList must match the AssemblyVersion of reference assembly.

cc @ericstj

I believe the package versions should in PlatformManifest should remain at 3.0.0.

I get your logic. But, this would mean we ship a fixed copy of the Microsoft.AspNetCore.App.Ref package that's externally indistinguishable from the broken one. And, I'm not sure any NuGet client would be "smart" enough to get the newer copy -- doesn't NuGet focus entirely on package versions?

(We'd be fine keeping package versions unchanged if https://www.nuget.org/packages/Microsoft.AspNetCore.App.Ref/3.0.0 didn't exist and the package was just an input to the targeting pack installers.)

I think we're talking about two different things.
The package version of the Microsoft.AspNetCore.App.Ref should become 3.0.1
The package versions in the platformmanifest.txt inside the nupkgs should stay at 3.0.0.

I think we're talking about two different things.

Agreed.
But, most of the listed "package versions" in the PlatformManifest.txt file aren't packages at all. The named items primarily ship only in the shared framework. Is the PlatformManifest.txt file from Microsoft.AspNetCore.App.Ref used in the shared framework world?

Sorry, mixed up which versions were in which file. The packageoverride versions should be 3.0.0 and the file and assembly versions in platform manifest should be what you get from 3.0.0 shared framework. The platform manifest is used. If a package provides a runtime asset that's in there at equal or higher version, then FDD deployment will know that it doesn't need to deploy it because it's in the shared framework.

Updated the artifacts so that now only the assembly file version in PlatformManifest and FrameworkList is updated.

Updated the artifacts so that now only the assembly file version in PlatformManifest and FrameworkList is updated.

Sounds good. Technically, I think the FileVersion in PlatformManifest should be the 3.0 version, but:

That would have to be hard-coded, but in a way that it gets reverted for 3.1+.
FileVersion is the last resort comparison. Any file with at least the file version of 3.0.1 should win conflict resolution anyway and any real 3.0.1 runtime files would win by assembly version first anyway.

So all good if the assembly and package versions are 3.0.0 and the file versions are from current build .

Found some missing and unexpected entries in the platform manifest. Investigating.

@nguerrera @ericstj @dougbu I've addressed the feedback. Currently verifying a test fix but otherwise this PR is ready for another look.

@nguerrera @ericstj I'm running into an issue in the template tests due to the mismatch in ref assembly version and impl assembly version.
Startup.cs(51,17): error CS1705: Assembly 'Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore' with identity 'Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'Microsoft.AspNetCore.Http.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' which has a higher version than referenced assembly 'Microsoft.AspNetCore.Http.Abstractions' with identity 'Microsoft.AspNetCore.Http.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' [C:\gh\AspNetCore\src\ProjectTemplates\test\bin\Debug\netcoreapp3.0\TestTemplates\AspNet.blazorserverindividualuld.ebis04ruz0g\AspNet.blazorserverindividualuld.ebis04ruz0g.csproj]

The project under test has a reference to Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore which is not shipped in the shared framework and therefore doesn't have ref assembly in the ref pack. The project therefore resolves it as a package reference which provides the impl assembly (in the unofficial build the assembly version is <IP_ADDRESS> but in an official build it would be <IP_ADDRESS>). The impl assembly is built by referencing other impl assemblies and therefore references Microsoft.AspNetCore.Http.Abstractions <IP_ADDRESS>. This does not match what's in the targeting pack which is now pinned to <IP_ADDRESS>. So I'm wondering what's the right behaviour here. How is a project supposed to use a targeting pack that's pinned at <IP_ADDRESS> but contains packages that are 3.0.1 without running into the error?
The binlog for this project can be found at the location I shared yesterday in email.

@JunTaoLuo the Windows x64/x86 build also failed. Did it hit similar problems to the template tests?
On the template tests, are the version tracking bits in those tests getting enough information in? And, is the passed information correct?

The release/3.0 is broken: https://dev.azure.com/dnceng/public/_build/results?buildId=377534&view=logs&jobId=1b89928a-2219-5ef9-602f-f95beb3da4dc. Even though the Windows x64/x86 build shows as successful, there is the same failure message as this PR:
The element 'metadata' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd' has invalid child element 'icon' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd'. List of possible elements expected: 'description, frameworkAssemblies, dependencies, language, copyright, contentFiles, releaseNotes, summary, serviceable, requireLicenseAcceptance, iconUrl, packageTypes, developmentDependency, frameworkReferences, license, references, repository, tags' in namespace 'http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd'. This validation error occurred in a 'icon' element.
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073: The command "powershell -NoProfile -NoLogo F:\workspace\_work\1\s\\src\Installers\Windows\GenerateNugetPackageWithMsi.ps1 ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'AspNetCore.SharedFramework' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'F:\workspace\_work\1\s\artifacts\installers\Release\aspnetcore-runtime-3.0.1-ci-win-x86.msi' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'F:\workspace\_work\1\s\artifacts\installers\Release\sfx_x86.cab' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'F:\workspace\_work\1\s\\src\Installers\Windows\SharedFramework\SharedFrameworkPackage.nuspec' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'F:\workspace\_work\1\s\artifacts\packages\Release\NonShipping\' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'x86' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       '3.0.1-ci' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       'F:\workspace\_work\1\s\' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       '3' ^
F:\workspace\_work\1\s\src\Installers\Windows\SharedFramework\SharedFramework.wixproj(99,5): error MSB3073:                       '0'" exited with code 1.

Looks like the NuGet client brought in is not new enough

@wtgodbe I see that the current version of nuget.exe that we are using is 5.2.0 which doesn't have icon support yet: https://github.com/NuGet/Home/issues/8660. I'll revert the changes in wixprojs since they download a nuget.exe directly here: https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Installers/Windows/GenerateNugetPackageWithMsi.ps1#L27. I don't like how we are using a nuget.exe here but I do realize that nuget pack with nuspec isn't supported by dotnet nuget or dotnet pack (at least a while ago, but I'm not sure if support has been added).

@nguerrera looks like we build the targeting pack installers as well. I'm going to double check that they have the correct contents ASAP.

@rrelyea why does https://dist.nuget.org/win-x86-commandline/latest/nuget.exe point to the 5.2.0 client and not the 5.3.0 one? From https://docs.microsoft.com/en-us/nuget/release-notes/nuget-5.3 it seems 5.3.0 supports <icon>.
Separately, could we now be using dotnet pack in our .wixproj files i.e. is the following old news?

nuget pack with nuspec isn't supported by dotnet nuget or dotnet pack

We usually wait a few weeks before we bless new versions of nuget.exe .
When we bless them, we turn on three auto update mechanisms:

update tools.json per these docs: https://docs.microsoft.com/en-us/nuget/api/tools-json
update the nuget.exe version behind the "Latest" url:  https://dist.nuget.org/win-x86-commandline/latest/nuget.exe
update nuget.commandline package on nuget.org, which feeds "nuget update -self"

This allows us to test new versions in the wild for a couple weeks before we auto-update people using these mechanisms to download nuget.exe

Thanx @rrelyea. What does that mean as far as timing of the 2nd update?

We will likely bless 5.3.x this coming week, as long as feedback is all still positive

Regarding this: https://github.com/aspnet/AspNetCore/pull/14538#issuecomment-538598548
You should not ship anything in a package compilation assets that reference things in the shared framework at version > <IP_ADDRESS>. If you have a package with a frameworkreference, the versions of the assembly refs in the compilation assets of that package must match the assembly versions of the framework ref pack.
So I don't think 3.0.1 packages should be compiled against 3.0.1 implementation assemblies, but rather against 3.0.0 reference assemblies. It should be the equivalent of what you'd get if you were to build this package in a separate repo and use a FrameworkReference.
I seem to recall in the 2.x days, there was effort done to make package servicing "jagged": only shipping serviced packages when there were changes, and not having depedency versions all line up to the patch version. I think the same sort of thing is still required for 3.0.x.
Another possibility, which is hacky, would be to pin the implementation assembly version to <IP_ADDRESS> as well...
I am really not feeling well, so tagging @dsplaisted and @ericstj to help with the follow up here.

@JunTaoLuo Yes, I think anything that ships in a package should build against the reference assemblies, if possible.  I'm not sure how much of an upheaval to your build that would be though.

I'll give that a try. Thanks @nguerrera @dsplaisted !

Seems like compiling ref assemblies is a little tricky. Applying the hacky fix of pinning implementation assembly version first to see if it unblocks us (local testing was promising). I'll work on compiling against ref assemblies in a separate branch.

I've verified the contents of the targeting pack of the internal build and it looks good (zip, M.A.App.Ref, tar.gz, deb, rpm, msi). Merging since this is approved.


Fetch purchase's suppliers from compras.dados.gov.br

Related with issue #189. The script collects the data of all suppliers related with purchases made by federal government. The purchases could be by a company or by a person. The API is brand new and ew have few info in this website: http://compras.dados.gov.br:8080/docs/lista-metodos-fornecedores.html.

Yay — many thanks 🎉


Do not force isDevelopingAddon.

In general, this will make linting errors and whatnot show up in consuming apps.  It is very useful to turn this on while developing (especially while linking) but should be removed before publishing.

Oh yes, just a mistake.


Unable to get property 'add' of undefined or null reference

Hi there ,
When i connect ie 9 from ie 11 as simulator  i am getting this error. I use modal component of vue-strap version is 1.1.32
Anyone can help? this bug

this issue has closed by verison 'v1.134'


No an issue, but a request

Hi, I understand your frustration with other people copying your work, and I respect your decision to stop the releases.
I'm trying to sell my matebook-x-pro, and as I was trying to reset it (delete my personal data) I think I messed it up, and now I'm trying to fix it, but All I have is an old flash drive with Catalina, I was wondering if you could privately share the latest release please.
I can be reached on this email<EMAIL_ADDRESS>thank you

Hi, I understand your frustration with other people copying your work, and I respect your decision to stop the releases. I'm trying to sell my matebook-x-pro, and as I was trying to reset it (delete my personal data) I think I messed it up, and now I'm trying to fix it, but All I have is an old flash drive with Catalina, I was wondering if you could privately share the latest release please. I can be reached on this email<EMAIL_ADDRESS>thank you

just use mine. wipe the data, if you still have this issue.


Create New Address Form - Full Address Field - Hyphen

Requirement: Entering a hyphen between two whole numbers should result in the first number being transferred to the base field and the second number being transferred to the high field.
When a hyphen is included the full address field does not transform at all.

Implemented - Please test in next version

Error has been fixed.

Reopened because further testing found the format 300-312 now correctly transfers to 300 in the base field and 312 in the high field. But 1/300-312 does not transform at all. It should transform to 1 in the unit field, 300 in the base field and 312 in the high field.

now handling  1/300-312 and  G101/300-312

All tested examples transform.


improve vram safety with 5% vram memory buffer

In testing how much VRAM should be allocated we typically used a model which could be entirely loaded into VRAM. This masked an issue when a model is larger than the available VRAM it is possible to consume all available VRAM and fail with an error:
Error: llama runner failed: out of memory

This change leaves a 10% buffer on available VRAM to prevent running out of memory.
Tested on a T4:

llama2:7b: easily offloads all layers to GPU
llama2:13b: easily offloads all layers to GPU
llama2:70b: offloaded 29 layers to GPU, was slow but did not run out of memory on load (as it did before)

Resolves #725

Something to check I encountered with a similar approach: when the model is reloaded (which may be often, I need to file a PR for the reflect.DeepEquals that seems to trigger on things that should be generation, not model parameters), there may be a race between unloading the old model and loading the new one. When looking at the "free" VRAM, this may result in less than expected offloading.

Good callout on the race condition. I added a wait for the subprocess to finish, which should release the memory.

ollama version 0.1.1
firefox / spotify running on Debian 12

nvidia-smi output on memory:
   FB Memory Usage
        Total                             : 6144 MiB
        Reserved                          : 215 MiB
        Used                              : 489 MiB
        Free                              : 5438 MiB
    BAR1 Memory Usage
        Total                             : 256 MiB
        Used                              : 14 MiB
        Free                              : 242 MiB

journal output during startup of llama2-uncensored ( 3.8 GB SIZE )
ollama[5853]: 2023/10/13 14:40:32 llama.go:239: 6144 MiB VRAM available, loading up to 54 GPU layers
ollama[7150]: ggml_init_cublas: found 1 CUDA devices:
ollama[7150]:   Device 0: NVIDIA GeForce GTX 1660 SUPER, compute capability 7.5
ollama[7150]: llama.cpp: loading model from /usr/share/ollama/.ollama/models/blobs/sha256:b5749cc827d33b7cb4c8869cede7b296a0a28d9e5d1982705c2ba4c603258159
ollama[7150]: llama_model_load_internal: format     = ggjt v3 (latest)
ollama[7150]: llama_model_load_internal: n_vocab    = 32000
ollama[7150]: llama_model_load_internal: n_ctx      = 2048
ollama[7150]: llama_model_load_internal: n_embd     = 4096
ollama[7150]: llama_model_load_internal: n_mult     = 256
ollama[7150]: llama_model_load_internal: n_head     = 32
ollama[7150]: llama_model_load_internal: n_head_kv  = 32
ollama[7150]: llama_model_load_internal: n_layer    = 32
ollama[7150]: llama_model_load_internal: n_rot      = 128
ollama[7150]: llama_model_load_internal: n_gqa      = 1
ollama[7150]: llama_model_load_internal: rnorm_eps  = 5.0e-06
ollama[7150]: llama_model_load_internal: n_ff       = 11008
ollama[7150]: llama_model_load_internal: freq_base  = 10000.0
ollama[7150]: llama_model_load_internal: freq_scale = 1
ollama[7150]: llama_model_load_internal: ftype      = 2 (mostly Q4_0)
ollama[7150]: llama_model_load_internal: model size = 7B
ollama[7150]: llama_model_load_internal: ggml ctx size =    0.08 MB
ollama[7150]: llama_model_load_internal: using CUDA for GPU acceleration
ollama[7150]: llama_model_load_internal: mem required  =  468.40 MB (+ 1024.00 MB per state)
ollama[7150]: llama_model_load_internal: allocating batch_size x (512 kB + n_ctx x 128 B) = 384 MB VRAM for the scratch buffer
ollama[7150]: llama_model_load_internal: offloading 32 repeating layers to GPU
ollama[7150]: llama_model_load_internal: offloading non-repeating layers to GPU
ollama[7150]: llama_model_load_internal: offloading v cache to GPU
ollama[7150]: llama_model_load_internal: offloading k cache to GPU
ollama[7150]: llama_model_load_internal: offloaded 35/35 layers to GPU
ollama[7150]: llama_model_load_internal: total VRAM used: 4954 MB
ollama[7150]: llama_new_context_with_model: kv self size  = 1024.00 MB
ollama[7150]: CUDA error 2 at /go/src/github.com/jmorganca/ollama/llm/llama.cpp/ggml/ggml-cuda.cu:6290: out of memory


Timeline duration support. Updated most of abilities, but not sure ab…

…out some, as do not play those classes fulltime.

For the DoTs, if they're on GCD that might get a bit weird. Is it possible to use the job colours, or a differentiator for damage vs heals/shields?

For the DoTs, if they're on GCD that might get a bit weird. Is it possible to use the job colours, or a differentiator for damage vs heals/shields?

This implementation for ogcd abilities and effective when duration <= cooldown to show actual time cooldown is working
For gcd ones it is better to expand table with additional status row to show actual duration of applied effect

I thought Windbite on BRD was a GCD 🤔
Still wondering about colours for the fills tho, going by the code and your screenshots in discord.

I thought Windbite on BRD was a GCD 🤔
Still wondering about colours for the fills tho, going by the code and your screenshots in discord.

Any proposals for colors? And in this case we need some way to identify what color to use, should it be property on ability?

Job colours I guess, they're in data/JOBS. Could maybe use a fill for regular actions, and either light blue/yellow for heals/shields, or just lower transparency or something.

From my experience abilities with active duration could be splitted into types as:
Self defense - light blue
Party Defense- darker blue
Self damage buff - light red
Party damage buff - darker red
Healing buff - light green
Does this make sense?

Anything from my side should be done here?

Sorry for the delay in getting back to you.
Based on the conversation Ackwell and I had on Discord last Wednesday, I'm going to update #594 to switch the order of the linking between Actions and Statuses (so that Actions have a property for which Statuses they generate).  Once that's in place, you should be able to use that value to look up the status and get the duration from the status data.
I should have the PR updated later today, can't guarantee when it's going to be merged in and available.  If you have any thoughts on how you want those linkages to map up, let me know.

The links from ACTIONS to the STATUSES they grant should be in place. If you notice any that are missing or incorrect, let me know or feel free to correct them. I’m happy to talk on discord if you have any questions on what I did.

I have reviewed approach to show statuses in timeline. This approach depends on statuses attached to actions and uses fflogs event to populate statuses with exact values of durations based on these events.

I am going to add more statuses and link them to actions with next PRs. Or even other contributors can help me with this.


add modules

any idea how to install modules?

not sure what you mean - what modules ?
Did you mean to open this in https://github.com/engineer-man/piston ?


Update zkp.markdown

caught another typo
Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet.
Explain your changes here.
Explain how you tested your changes here.
Checklist:

[x] Tests were added for the new behavior
[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them:

Closes #0000
Closes #0000

Can you include this change in https://github.com/CodaProtocol/coda/pull/2778?


⚠ Bofrost.at has degraded performance

In e389e18, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1358 ms

Resolved: Bofrost.at performance has improved in 6518a03.


Cross platform/engine/storage abstraction for original and prepared s…

…cripts
// ScriptStore manages versioned storage of both source scripts and prepared scripts. We intent to pass a ScriptSTore implementation
// directly into the JSI runtime from host. It will enable the following,
// 1. Pass richer data and metadata on the source scripts from host to JSI runtime without being constrained by the various layers in between.
// 2. Potential performance benefits as it will allow us to directly stream the source script and the prepared scripts from arbitrary storages and encoding without being constrained by intermediate layers.
// 3. Consolidate Source script versioning and storage logic into a single component.
// 4. Consolidate prepared script storage and persistance formats across platforms and aross JS-engines.
// 5. Allow co-existance of multiple Javascript engines, versions, strategies. (Some more work required to support multi-version)
// 6. Allow platform/storage/engine specific extensions for better performance.
:warning: Make sure you are targeting Microsoft/react-native for your PR :warning:
(then delete these lines)

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and Microsoft/react-native :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into Microsoft/react-native :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Description of changes
(give an overview)
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

/azp run


32-bit support

Describe the feature you would like
My team and I have been looking at 32-bit support for zkevm-circuits.  Currently, builds fails due to this check - https://github.com/scroll-tech/zkevm-circuits/blob/develop/zkevm-circuits/src/lib.rs#L24, which forbids non-64 bit builds.
Of course, removing this check does not succeed since I presume there are a lot more code changes that would need to be done to make it work on 32-bit platforms.
For our specific usecase, K=12, and we are not really concerned about performance right now. Is there a way to make it work for 32-bit platforms? If so, potentially what changes would need to be done?
Thanks!
Additional context
Attempting to build for 32-bit platforms.

Any ideas/thoughts on this? If there is no plan to support 32-bit (for technical/logistical) reasons, it'd be great to see some confirmation of that so that we can close this issue. Thanks!

yes nowadays modern CPU is almost all x86-64 and aarch64.  Unless we want to support wasm32 or riscv (we have no such plan in forseeable future), assuming 64bit makes sense for us.

yes nowadays modern CPU is almost all x86-64 and aarch64. Unless we want to support wasm32 or riscv (we have no such plan in forseeable future), assuming 64bit makes sense for us.

Okay, thank you for the update!


Crash on Moto Z android7.0 - Failed to load libdashplayer.so

Hi guys, this crash appear on google test pre launch :

 flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.3.3-pre.16, on Mac OS X 10.14.3 18D109, locale en-IT)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.3)
[✓] VS Code (version 1.31.0)
[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/393 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 314703f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-02-05-08-25-56 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-02-05-08-25-56

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


False positives for match in RegexpMatch

The RegexpMatch is a bit too eager in flagging usage of match. Here's a simple example that is flagged when extending Rubocop's own API:
class MyCop < Cop
  KERNEL_PATTERN = RuboCop::NodePattern.new('(const nil? :Kernel)')
  def on_send(node)
    if KERNEL_PATTERN.match(node)
      # do stuff
    end
  end
end

I would suggest making the match_method? logic more selective, and only flag usage by receiver types known to have a regexp matching match method.  At risk of getting too into implementation details, rather than:
def_node_matcher :match_method?, <<-PATTERN
  {
    (send _recv :match _)
    (send _recv :match _ (int ...))
  }
PATTERN

RegexpMatch could instead do:
def_node_matcher :match_method?, <<-PATTERN
  {
    (send {regexp str sym} :match _)
    (send {regexp str sym} :match _ (int ...))
  }
PATTERN

I'm happy to open a PR if this is agreeable.
Expected behavior
The snippet above should not trigger a Performance/RegexpMatch violation
Actual behavior
Offenses:

repro.rb:4:8: C: Performance/RegexpMatch: Use match? instead of match when MatchData is not used.
    if KERNEL_PATTERN.match(node)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

Steps to reproduce the problem
rubocop file.rb --only Performance/RegexpMatch with the above snippet saved in file.rb
RuboCop version
0.68.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.5 x86_64-darwin17)

I believe https://github.com/rubocop-hq/rubocop-performance/pull/47 would fix this issue?

I think that's a different issue. Let me put together a PR with a failing test and a suggested fix, it might take a day or three though.

Yes. This is different from #47.
@pocke You are the original author of Performance/RegexpMatch cop. Do you have an opinion on this proposal?

I agree with this change. Thank you!


Api endpoint to get deployment manifest with expanded runtime config

Is your feature request related to a problem? Please describe.
As a bosh operator, in order to record a reliable current state of a bosh deployment, I need a deployment manifest with the applied runtime config. Then I archive this deployment manifest (typically in git) in order to track history of changes applied by my automation pipelines.
Currently, the runtime config may change, but the current endpoint has not yet options to render the applied runtime config. For cloud-config, it does support indicating the cloud-config within the deployment is outdated, see https://github.com/cloudfoundry/bosh/blob/69dea967cf0a45f1468d749b651fa1b84d894a73/src/bosh-director/spec/unit/api/controllers/deployments_controller_spec.rb#L1073-L1100
Describe the solution you'd like
A new param to the /deployments/<deployment> endpoint to render the deployment manifest along with the add-ons.
Describe alternatives you've considered
I looked for existing task debug traces and could not find a dumped rendered manifest.
Looking at source code, the planner below seems to perform the manifest merge but does not yet dump it https://github.com/cloudfoundry/bosh/blob/4f0656826132d4794d4e5070381717ba067f9cc4/src/bosh-director/lib/bosh/director/deployment_plan/planner_factory.rb#L50-L126
A clear and concise description of what you want to happen.
I'm also considering fetching the full manifest directly from the director db, but would need guidance into the current director db schema, as https://github.com/cloudfoundry/bosh/tree/main/docs/director_schema seems outdated

The /deployments/:deployment/diff endpoint does use runtime configs to generate the diff between the old manifest and the new manifest.
https://github.com/cloudfoundry/bosh/blob/6b40dfc6db5d4e6b1764bd05884cbc92a30ba951/src/bosh-director/lib/bosh/director/api/controllers/deployments_controller.rb#L469-L489
Seems like a lot of that code could be used to do what you want on /deployments/:deployment.
Since that endpoint currently renders the "currently deployed manifest", if you're adding an option to add runtime configs, it feels correct that the option should have a flag for "currently deployed manifest + runtime configs", but also adding a flag for "currently deployed manifest + new runtime configs" seems like a fine option too.
You might also be able to just use the diff endpoint to achieve what you want without any changes, but I'll leave that up to you.


Add login system to Authentication app

Still have to clean it  from comments and fix some bugs | ready to test but not for merging


Extend HealthKitManager with Logging

Adds more logging and cleaner error handling to try and get to the bottom of the recent HealthKit issues.
Thanks for @scrappy for reminding to PR this.

It would be good with a bit more descriptive log and message. For instance instead of "Saved blood glucose" it could read "Glucose save to Health Store", because glucose is also saved in glucoseStorage and CoreData in other places. Same thing with the error message, which could read "Couldn't save glucose to Health Store ...".
Regarding the carbs message, it's not just carbs but also other treatments, like temp basals and boluses saved to Health store. It would be good to see which treatment in logs and error message.
There are also bugs concerning deletion of Health Store currently. It would therefore be good including logging and errors of deletion of Health Store objects.

Added more verbose logging.
In the context where the "carb entry" logging was added, it is indeed storing carb entries (function signature reads func saveIfNeeded(carbs: [CarbsEntry]) {…}). I think talking of a "carb entry" there is okay.
Example log entry:
Stored insulin entry in HealthKit Store!  Metadata: Optional(Dictionary.Values([1, "f81a58640a502d7c083439309510a614", 1, true, "f81a58640a502d7c083439309510a614"]))
All deletion functions already have logging in case of an error. Would you like success logging, too?

Ah, yes I remember now from
seeing some logs that deletion is logged and in fact I added some more descriptive logging here already

And yes it looks better now, thanks!


Edit Changes for Concept Topics

This PR includes the following updates:

Edit changes as per OCP Guidelines
A bit of rewording based on Minimalism Principals

Please Note:

We might have to get the index.adoc reviewed by the PM once we have had our internal review.
In the concept topic I have not removed Pipeline Resources and the diagram  for now, I will add Workspace and Trigger info when I work on respective JIRAs.

JIRA: https://issues.redhat.com/browse/RHDEVDOCS-1692
Thanks
Nidhi

@Preeticp @joaedwar : Please review. Thanks!

@Preeticp - Have incorporated all comments except one. Please see my comment above on that. Thanks!!


fixed reposense link for wilburrito.md

Codecov Report

Merging #201 (64a5af0) into master (3c49025) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     74.46%   74.46%
  Complexity      698      698
=========================================
  Files           109      109
  Lines          2060     2060
  Branches        235      235
=========================================
  Hits           1534     1534
  Misses          460      460
  Partials         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c49025...64a5af0. Read the comment docs.


Fix: sentieon variant calling subworkflow

PR checklist
Glnexus process in the deepvariant subworkflow was getting triggered even when choosing sentieon as a variant caller. I have fixed that error in this PR and made a few formatting changes.

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR> -stub).
[ ] Ensure the test suite passes (nextflow run . -profile test2samples,docker --outdir <OUTDIR> -stub).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Thanks for the review @jemten Yes, I have tested it with test data 😄


check errors from ffmpeg sub process to address issue

This patch removes the -v quiet command line option from invocations of ffmpeg.  It does so to allow ffmpeg to report errors. Maybe a better setting is avialble; less verbose, but not the default.
Then, code is added to the downloaded to check the return code from the ffmpeg process.
If the command wasn't found, a clear error message is printed and processing stops; spotdl can't do anything without ffmpeg.
If the command failed, the error output from ffmpeg is printed along with the command-line given to ffmpeg.  This isn't pretty, but it's better than simply crashing or hanging with a stack dump. Users can see the command given so they can try it themselves; the output should reveal whatever error messages ffmpeg gave describing its own failure. In this case, any half-baked output file is deleted and processing is allowed to continue.
If the command worked, processing continues as normal.
This PR also removes the infinite loop that waits for an output file to appear. This loop isn't necessary, and would leave spotdl hung when ffmpeg failed and didn't produce any output file.
This isn't perfect. Notably, the error output from ffmpeg can be very long, and could be repeated for multiple concurrent invocations of the program. Also, error reporting while concurrent processing is happening is tricky -- maybe output reporting to the suer should be serialized or batched somehow.
But with this fix, the important improvement is that errors in ffmpeg processing are actually reported to the user so they can take clear action (or ask for specific help) rather than hanging or crashing. Many reported issues against spotdl are actually because errors aren't being reported or diagnosed properly, and this change should help address those situations.
Examples follow.
When ffmpeg isn't installed
Before
When ffmpeg isn't installed, the program would say that ffmpeg was not found, then hang:
pi@twang2:~/spotify-downloader $ python3 -m spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b?si=1stnMF5GSdClnIEARnJiiQ
/usr/lib/python3.7/runpy.py:125: RuntimeWarning: 'spotdl.__main__' found in sys.modules after import of package 'spotdl', but prior to execution of 'spotdl.__main__'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
Fetching Song...
Searching for: The Weeknd - Blinding Lights
 75%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▉                                                  |ETA: 00:01, 0.08min/song/bin/sh: 1: ffmpeg: not found
 90%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▋                    |ETA: 00:00, 0.08min/song

The user might have a hint of what's wrong, but the program shouldn't hang. The user is likely confused that the ETA is zero, but only 90% and nothing is happening, so the user might ask for help. But certainly they have to kill the process and help that they notice the error message.
After
With this change in place, the problem is detected and an error message is raised. The output looks like this:
pi@twang2:~/spotify-downloader $ python3 -m spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b?si=1stnMF5GSdClnIEARnJiiQ
/usr/lib/python3.7/runpy.py:125: RuntimeWarning: 'spotdl.__main__' found in sys.modules after import of package 'spotdl', but prior to execution of 'spotdl.__main__'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
Fetching Song...
Searching for: The Weeknd - Blinding Lights
 83%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▋                                  |ETA: 00:00, 0.07min/song
ffmpeg was not found. spotDL can't continue

When ffmpeg isn't the right version
Before
It's possible the user has ffmpeg installed, but the version installed isn't compatible with spotdl. In that case, ffmpeg runs, generates a zero-byte output file, and ends up throwing a Python exception:
pi@twang2:~/spotify-downloader $ python3 -m spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b?si=1stnMF5GSdClnIEARnJiiQ
/usr/lib/python3.7/runpy.py:125: RuntimeWarning: 'spotdl.__main__' found in sys.modules after import of package 'spotdl', but prior to execution of 'spotdl.__main__'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
Fetching Song...
Searching for: The Weeknd - Blinding Lights
 95%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▊          |ETA: 00:00, 0.06min/songTraceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/pi/spotify-downloader/spotdl/__main__.py", line 130, in <module>
    console_entry_point()
  File "/home/pi/spotify-downloader/spotdl/__main__.py", line 96, in console_entry_point
    downloader.download_single_song(song)
  File "/home/pi/spotify-downloader/spotdl/download/downloader.py", line 74, in download_single_song
    self._download_asynchronously([songObj])
  File "/home/pi/spotify-downloader/spotdl/download/downloader.py", line 355, in _download_asynchronously
    self.loop.run_until_complete(asyncio.gather(*tasks))
  File "/usr/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/home/pi/spotify-downloader/spotdl/download/downloader.py", line 350, in _pool_download
    return await self.download_song(song_obj)
  File "/home/pi/spotify-downloader/spotdl/download/downloader.py", line 247, in download_song
    self.set_id3_data(convertedFilePath, songObj)
  File "/home/pi/spotify-downloader/spotdl/download/downloader.py", line 264, in set_id3_data
    audioFile = EasyID3(convertedFilePath)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/easyid3.py", line 169, in __init__
    self.load(filename)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/_util.py", line 185, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/_util.py", line 156, in wrapper
    return func(self, h, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/id3/_file.py", line 152, in load
    self._header = ID3Header(fileobj)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/_util.py", line 185, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/mutagen/id3/_tags.py", line 59, in __init__
    raise ID3NoHeaderError("%s: too small" % fn)
mutagen.id3._util.ID3NoHeaderError: The Weeknd - Blinding Lights.mp3: too small
Exception ignored in: <function tqdm.__del__ at 0x757dd8a0>
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/tqdm/std.py", line 1134, in __del__
  File "/usr/local/lib/python3.7/dist-packages/tqdm/std.py", line 1281, in close
  File "/usr/local/lib/python3.7/dist-packages/tqdm/std.py", line 1467, in display
  File "/usr/local/lib/python3.7/dist-packages/tqdm/std.py", line 1137, in __repr__
  File "/home/pi/spotify-downloader/spotdl/download/progressHandlers.py", line 23, in format_dict
  File "/usr/local/lib/python3.7/dist-packages/tqdm/std.py", line 1424, in format_dict
TypeError: cannot unpack non-iterable NoneType object

A zero-byte MP3 file is left behind in this case. The user again has no idea what to do with this information. The zero byte file might cause errors in trying again, and will also inhbit correctly restarting the download. They'll probably end up asking for help, since they won't be able to make sense of the call stack given to them.
After
With this PR in place, a sensible (but probably too-long, LOL) error message is shown to the user.
pi@twang2:~/spotify-downloader $ python3 -m spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b?si=1stnMF5GSdClnIEARnJiiQ
/usr/lib/python3.7/runpy.py:125: RuntimeWarning: 'spotdl.__main__' found in sys.modules after import of package 'spotdl', but prior to execution of 'spotdl.__main__'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
Fetching Song...
Searching for: The Weeknd - Blinding Lights
 84%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████                                 |ETA: 00:00, 0.05min/song
ffmpeg returned an error (1)
the ffmpeg command was "ffmpeg  -y -i "/home/pi/spotify-downloader/Temp/The Weeknd - Blinding Lights.webm" -acodec libmp3lame -abr true -b:a 141963 -af "apad=pad_dur=2, dynaudnorm, loudnorm=I=-17" "The Weeknd - Blinding Lights.mp3""
ffmpeg gave this output:
=====ffmpeg version 4.1.6-1~deb10u1+rpt1 Copyright (c) 2000-2020 the FFmpeg developers
  built with gcc 8 (Raspbian 8.3.0-6+rpi1)
  configuration: --prefix=/usr --extra-version='1~deb10u1+rpt1' --toolchain=hardened --incdir=/usr/include/arm-linux-gnueabihf --enable-gpl --disable-stripping --enable-avresample --disable-filter=resample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librsvg --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-lv2 --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-omx-rpi --enable-mmal --enable-neon --enable-rpi --enable-libdc1394 --enable-libdrm --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libx264 --enable-shared --libdir=/usr/lib/arm-linux-gnueabihf --cpu=arm1176jzf-s --arch=arm
  WARNING: library configuration mismatch
:
: lots of output
:
  libavutil      56. 22.100 / 56. 22.100
  libavcodec     58. 35.100 / 58. 35.100
  libavformat    58. 20.100 / 58. 20.100
  libavdevice    58.  5.100 / 58.  5.100
  libavfilter     7. 40.101 /  7. 40.101
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  3.100 /  5.  3.100
  libswresample   3.  3.100 /  3.  3.100
  libpostproc    55.  3.100 / 55.  3.100
Input #0, matroska,webm, from '/home/pi/spotify-downloader/Temp/The Weeknd - Blinding Lights.webm':
  Metadata:
    encoder         : google/video-file
  Duration: 00:03:19.06, start: -0.007000, bitrate: 132 kb/s
    Stream #0:0(eng): Audio: opus, 48000 Hz, stereo, fltp (default)
Stream mapping:
  Stream #0:0 -> #0:0 (opus (native) -> mp3 (libmp3lame))
Press [q] to stop, [?] for help
[Parsed_apad_0 @ 0x1259ee0] Option 'pad_dur' not found
[AVFilterGraph @ 0x12598e0] Error initializing filter 'apad' with args 'pad_dur=2'
Error reinitializing filters!
Failed to inject frame into filter network: Option not found
Error while processing the decoded data for stream #0:0
Conversion failed!

=====

 95%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▋          |ETA: 00:00, ~min/song
pi@twang2:~/spotify-downloader $

Here, we get a clear error, though we trip over progress reporting a bit. They can find "Error initializing filter 'apad' with args 'pad_dur=2'" and "Error reinitializing filters!" and might be able to formualte a guess. The version number of ffmpeg is apparent in the output, so if they do ask for help, the version information is right there.

better to check if the ffmpeg exists (and probably validate the version) at the very beginning of the execution,

Yep, that would be nice. I can't find any docs that say which version is required as a minimum. With that information, tho, it may also be possible to gracefully degrade ... shed options that aren't compatible, for example, in the installed version.

I believe the base version that conclusively works is v4.3.1-full build

Hello @mikeblas, good to see your contribution 👍👍👍
If you intend this as a hotfix that will later be reworked for the next release you can base this branch off hotfix else, this should be based of the dev branch.
Why not just check the FFmpeg version and FFmpeg existence in __main__.py before anything else is run? (Just a doubt/sugession)

I believe the base version that conclusively works is v4.3.1-full build
Why not just check the FFmpeg version and FFmpeg existence in main.py

Once you know for sure, another change can be made to test the version directly and get a direct error message. Even with that code implemented, this code would remain because the ffmpeg process can raise any error at any time.

If you intend this as a hotfix that will later be

I intend this as an emergent fix to a fundamental problem in the product -- the failure to check for errors in spawning ffmpeg, which implements a fundamental competency of the tool.  I can't find any docs describing the intended use of the dev or hotfix branches, so I've made my contribution as-is, where-is.  If it should follow some other path, feel free to make it so.
I have opened a couple of issues to track the points you make here.

Why not just check the FFmpeg version and FFmpeg existence in __main__.py before anything else is run? (Just a doubt/sugession)

I guess it is good as it is now, and we can later extract some parts of it to check for the ffmpeg early.
@mikeblas - please change the base branch to dev.

Progress is blocked on this due to issue #1170

@mikeblas - any chance to rebase this to dev and actually merging it? Or should one of us redo this branch from scratch?

I could work on this if you want @aklajnert

I could work on this if you want @aklajnert

Sure, if you have time for that, go ahead. I would work on that myself, but I'm quite busy now.


[FSDE-4397] Improve data table unsorted behavior

[x] Makes unsorted step optional instead of the default behavior for data table sorting
[x] Makes data table portal complex example sort by name in ascending order by default
[x] Fixes "localeCompare is not a function" related bug.

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/1/. :white_check_mark:

You can check this PRs instance in https://a61de7f8e032748929f04fa60270da7c37b124c0-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/2/. :white_check_mark:

You can check this PRs instance in https://b591eb255831640a6f776142e95e8393d9d1cbf3-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/3/. :white_check_mark:

You can check this PRs instance in https://4c3665f27dcc74beeaa14673d41fa36e967d6c16-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/4/. :white_check_mark:

You can check this PRs instance in https://89dc17080777f00aeb04a87ff6abf271ff349690-chi-pr.enterprise.ctl.io

@SergioQCL can you review it?

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/5/. :white_check_mark:

You can check this PRs instance in https://985128b366887f81f4a72086553bd5ef0107b779-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/7/. :white_check_mark:

You can check this PRs instance in https://181d1357bfb80d12dc07f0c5fb6154f36ee510b3-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/8/. :white_check_mark:

You can check this PRs instance in https://7bf8cae3a7a924d6b6099f1d22522d282b5bee4f-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-166/9/. :white_check_mark:

You can check this PRs instance in https://f9e6216b8748c3caec7f7327fe8ced32ea81252f-chi-pr.enterprise.ctl.io

@evansito 👍 nice work! this is a big UX improvement


[Event Request] Add multiple events to codeunit 5632 "FA Jnl.-Post Line"

Describe the request
Hi,
Could you please add the following events  to codeunit 5632 "FA Jnl.-Post Line":

OnBeforePostMaintenanceFromGenJnlLine

To procedure GenJnlPostLine, before call PostMaintenance procedure:
    ....

    if "FA Posting Type" = "FA Posting Type"::Maintenance then begin
        MakeMaintenanceLedgEntry.CopyFromGenJnlLine(MaintenanceLedgEntry, GenJnlLine);
        MaintenanceLedgEntry.Amount := FAAmount;
        MaintenanceLedgEntry."VAT Amount" := VATAmount;
        MaintenanceLedgEntry."Transaction No." := NextTransactionNo;
        MaintenanceLedgEntry."G/L Entry No." := NextGLEntryNo;
        // >>>>>>>>>>>>>>>>
        OnBeforePostMaintenanceFromGenJnlLine(GenJnlLine, FALedgEntry, FAAmount, VATAmount);
        // <<<<<<<<<<<<<<<<
        PostMaintenance();
    end else begin
        MakeFALedgEntry.CopyFromGenJnlLine(FALedgEntry, GenJnlLine);
        FALedgEntry.Amount := FAAmount;
        FALedgEntry."VAT Amount" := VATAmount;
        FALedgEntry."Transaction No." := NextTransactionNo;
        FALedgEntry."G/L Entry No." := NextGLEntryNo;
        OnBeforePostFixedAssetFromGenJnlLine(GenJnlLine, FALedgEntry, FAAmount, VATAmount, GLRegisterNo);
        PostFixedAsset();
    end;

    ....

[IntegrationEvent(false, false)]
local procedure OnBeforePostMaintenanceFromGenJnlLine(var GenJournalLine: Record "Gen. Journal Line"; var FALedgerEntry: Record "FA Ledger Entry"; FAAmount: Decimal; VATAmount: Decimal)
begin
end;

OnBeforePostFixedAsset

To procedure PostFixedAsset, after begin:
OnBeforePostFixedAsset(FANo, DeprBookCode, FAPostingType, FALedgEntry, IsHandled);
if IsHandled then
    exit;

....

[IntegrationEvent(false, false)]
local procedure OnBeforePostFixedAsset(FANo: Code[20]; DeprBookCode: Code[10]; FAPostingType: Enum "FA Journal Line FA Posting Type"; FALedgEntry: Record "FA Ledger Entry"; IsHandled: Boolean)
begin
end;

OnBeforePostAllocation

Need to change the PostAllocation procedure type from local to global.
To procedure PostAllocation, after begin:
OnBeforePostAllocation(FALedgEntry, IsHandled);
if IsHandled then
    exit;

....

[IntegrationEvent(true, false)]
local procedure OnBeforePostAllocation(var FALedgEntry: Record "FA Ledger Entry"; var IsHandled: Boolean)
begin
end;

We also need to have access to the sender instance in:
[IntegrationEvent(true, false)]  //IncludeSender changed to true
local procedure OnBeforePostDeprUntilDate(var FALedgEntry: Record "FA Ledger Entry"; var FAPostingDate: Date; Type: Option; var IsHandled: Boolean)
begin
end;

Additional context
We need to make some changes to this codeunit to suit local needs
Internal work item: AB#538714

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 21752.

Availability update: We will publish a fix for this issue in the next update for release 24.
Build ID to track: 21807.


Beeps 3 times but not paired

Similar to some other people, I replaced my w10 vacuum mainboard which resulted in breaking the vacuum/dock pairing.
Vacuum would still return to the dock and charge, but the buttons on the dock don't control the vacuum and the mops won't clean.
I followed the instructions listed under the "direct" method, and the dock beeped 3 times to confirm connection.
After restarting the dock and vacuum, the buttons on the dock still don't control the vacuum, and the mops still don't get washed.
Are there any specific steps that take place after the 3 beeps? Should I be waiting longer before a restart?
Should the rx/tx/gnd be Disconnected before the restart?

After trying many things and switching back to the old board (which I was replacing due to a wheel not running), it seems that maybe there is an issue with my new mainboard?
When intercepting the pairing sequence via UART on the new mainboard, the vacuum only sends back <ZA_>.
(There is no mac address being sent back to the dock).
Does anyone know if there is another way to get the mac address?
My assumptions (through looking at the mainboard) is that the W10 robot communicates with the dock via the onboard RF chip.
That being the case, could I swap the transceiver chip on the mainboard with the chip from the old board?
Or is the RFM300 chip just a transceiver, while any pairing information is actually on another part of the mainboard?
If anyone else is having a similar issue, that would be great to know.

We can try to fiddle with it together, I don't know if we will get somewhere but we can try, you can find me on telegram (@picakia)


/api/1.1/traffic_monitor/stats.json report status code 500

Not sure if reproducible, but we get an error code 500 on this API call.
First observation was the "Health Table View" on the TO UI. I also tried the same using an ansible-playbook
- hosts: localhost
  gather_facts: False
  connection: local
  tasks:
  - name: Login
    uri: url={{ traffic_ops_url }}/login method=POST status_code=302
         body="u={{ traffic_ops_user }}&p={{traffic_ops_pass}}" HEADER_Content-Type="application/x-www-form-urlencoded"
    register: login

  - name: stats
    uri: url={{ traffic_ops_url }}/api/1.1/traffic_monitor/stats.json return_content=yes method=GET HEADER_Cookie="{{ login.set_cookie }}"
    register: stats

  - debug: var=stats

To run the playbook :
ansible-playbook test.yml

This is against 1.1.1

Seems like this looks fine in our lab. Here's the trace
[2015-06-01 21:05:59,517] [ERROR] No TrafficMonitor servers found for: cdn_name at /opt/traffic_ops/app/script/../lib/MojoPlugins/TrafficMonitorConnection.pm line 49.
	MojoPlugins::TrafficMonitorConnection::__ANON__(API::TrafficMonitor=HASH(0x7e688e8), HASH(0x8038fa8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Controller.pm line 37
	Mojolicious::Controller::AUTOLOAD(API::TrafficMonitor=HASH(0x7e688e8), HASH(0x8038fa8)) called at /opt/traffic_ops/app/script/../lib/API/TrafficMonitor.pm line 46
	API::TrafficMonitor::get_host_stats(API::TrafficMonitor=HASH(0x7e688e8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 126
	Mojolicious::__ANON__(undef, API::TrafficMonitor=HASH(0x7e688e8), CODE(0x80ec880), 1) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Plugins.pm line 20
	Mojolicious::Plugins::__ANON__() called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Plugins.pm line 23
	Mojolicious::Plugins::emit_chain(Mojolicious::Plugins=HASH(0x49ef400), "around_action", API::TrafficMonitor=HASH(0x7e688e8), CODE(0x80ec880), 1) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Routes.pm line 106
	Mojolicious::Routes::_action(TrafficOps=HASH(0x49ee290), API::TrafficMonitor=HASH(0x7e688e8), CODE(0x80ec880), 1) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Routes.pm line 194
	Mojolicious::Routes::_controller(Mojolicious::Routes=HASH(0x49eed88), Mojolicious::Controller=HASH(0x93c7e38), HASH(0x8180558), 1) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Routes.pm line 43
	Mojolicious::Routes::continue(Mojolicious::Routes=HASH(0x49eed88), Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Routes.pm line 51
	Mojolicious::Routes::dispatch(Mojolicious::Routes=HASH(0x49eed88), Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 118
	Mojolicious::dispatch(TrafficOps=HASH(0x49ee290), Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 127
	Mojolicious::__ANON__(undef, Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Plugins.pm line 20
	Mojolicious::Plugins::__ANON__() called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 199
	eval {...} called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 199
	Mojolicious::_exception(CODE(0x8045b98), Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Plugins.pm line 20
	Mojolicious::Plugins::__ANON__() called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious/Plugins.pm line 23
	Mojolicious::Plugins::emit_chain(Mojolicious::Plugins=HASH(0x49ef400), "around_dispatch", Mojolicious::Controller=HASH(0x93c7e38)) called at /opt/traffic_ops/app/local/lib/perl5/Mojolicious.pm line 133
	Mojolicious::handler(TrafficOps=HASH(0x49ee290), Mojo::Transaction::HTTP=HASH(0x945cea8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server.pm line 71
	Mojo::Server::__ANON__(Mojo::Server::Prefork=HASH(0x29b7850), Mojo::Transaction::HTTP=HASH(0x945cea8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/EventEmitter.pm line 15
	Mojo::EventEmitter::emit(Mojo::Server::Prefork=HASH(0x29b7850), "request", Mojo::Transaction::HTTP=HASH(0x945cea8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Daemon.pm line 83
	Mojo::Server::Daemon::__ANON__(Mojo::Transaction::HTTP=HASH(0x945cea8)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/EventEmitter.pm line 15
	Mojo::EventEmitter::emit(Mojo::Transaction::HTTP=HASH(0x945cea8), "request") called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Transaction/HTTP.pm line 65
	Mojo::Transaction::HTTP::server_read(Mojo::Transaction::HTTP=HASH(0x945cea8), "GET /api/1.1/traffic_monitor/stats.json?data_type=json HTTP/1"...) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Daemon.pm line 186
	Mojo::Server::Daemon::_read(Mojo::Server::Prefork=HASH(0x29b7850), "b3cd0535fc3e420407920b82762c2d60", "GET /api/1.1/traffic_monitor/stats.json?data_type=json HTTP/1"...) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Daemon.pm line 166
	Mojo::Server::Daemon::__ANON__(Mojo::IOLoop::Stream=HASH(0x7e6b1a0)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/EventEmitter.pm line 33
	eval {...} called at /opt/traffic_ops/app/local/lib/perl5/Mojo/EventEmitter.pm line 33
	Mojo::EventEmitter::emit_safe(Mojo::IOLoop::Stream=HASH(0x7e6b1a0), "read", "GET /api/1.1/traffic_monitor/stats.json?data_type=json HTTP/1"...) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/IOLoop/Stream.pm line 116
	Mojo::IOLoop::Stream::_read(Mojo::IOLoop::Stream=HASH(0x7e6b1a0)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/IOLoop/Stream.pm line 53
	Mojo::IOLoop::Stream::__ANON__(Mojo::Reactor::Poll=HASH(0x28dbe18)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Reactor/Poll.pm line 115
	eval {...} called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Reactor/Poll.pm line 115
	Mojo::Reactor::Poll::_sandbox(Mojo::Reactor::Poll=HASH(0x28dbe18), "Read", CODE(0x93f3ff0), 0) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Reactor/Poll.pm line 47
	Mojo::Reactor::Poll::one_tick(Mojo::Reactor::Poll=HASH(0x28dbe18)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Reactor/Poll.pm line 92
	Mojo::Reactor::Poll::start(Mojo::Reactor::Poll=HASH(0x28dbe18)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/IOLoop.pm line 130
	Mojo::IOLoop::start(Mojo::IOLoop=HASH(0x28dbd88)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Prefork.pm line 214
	Mojo::Server::Prefork::_spawn(Mojo::Server::Prefork=HASH(0x29b7850)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Prefork.pm line 122
	Mojo::Server::Prefork::_manage(Mojo::Server::Prefork=HASH(0x29b7850)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Prefork.pm line 96
	Mojo::Server::Prefork::run(Mojo::Server::Prefork=HASH(0x29b7850)) called at /opt/traffic_ops/app/local/lib/perl5/Mojo/Server/Hypnotoad.pm line 77
	Mojo::Server::Hypnotoad::run(Mojo::Server::Hypnotoad=HASH(0x20cfe80), "/opt/traffic_ops/app/script/cdn") called at /opt/traffic_ops/app/local/bin/hypnotoad line 24

Found the root cause on this one. An imported profile had a "CDN_name" not in used. I also had an orphaned CDN_name laying around. That's probably how it can be reproduced. Now the "Health Table View" is back.

Problem still preset in 1.1.3. Removing orphaned CDN_name restore back.

I'm seeing the same problem right now... although the request times out. We've added Traffic Routers and Traffic Monitor last week. Getting stuck here
[2015-08-31 18:07:55,950] [DEBUG] GET "/api/1.1/traffic_monitor/stats.json".
[2015-08-31 18:07:55,960] [DEBUG] Routing to controller "API::TrafficMonitor" and action "get_host_stats".

Talked to Steve - can close.


diagnostic appears as message before being displayed as a popup

There is a strange issue when I use successive Prev/NextDiagnostic. Sometimes the diagnostic is displayed next to the statusline right before being displayed as a popup, see the bottom of the screenshot:

Maybe it's something in my config but I am not sure what.

The message is from location list because I use location list to jump around. I've changed it to run silently. It should be fixed now, please update and check!

that seems to have fixed it thanks !