Invalid query generation if smart join with $and/$or used together with same table join in orderBy

Describe the bug
The following query will fail
const reports = await em.findAndCount<Report>(
        Report,
        {
            $or: [
                { organization: { domain: 'test' } },
                { product: { code: 'RR' } }
            ],
        },
        {
            orderBy: { organization: { name: "ASC" } },
        },
    );

Stack trace
[query] select `e0`.* from `report` as `e0` left join `organization` as `e3` on `e0`.`organization_id` = `e3`.`id` left join `product` as `e2` on `e0`.`product_id` = `e2`.`id` where (`e1`.`domain` = 'test' or `e2`.`code` = 'RR') order by `e3`.`name` asc [took 14 ms]
{ Error: Unknown column 'e1.domain' in 'where clause'
    at Packet.asError (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/packets/packet.js:708:17)
    at Query.execute (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/commands/command.js:28:26)
    at Connection.handlePacket (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/connection.js:408:32)
    at PacketParser.Connection.packetParser.p [as onPacket] (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/connection.js:70:12)
    at PacketParser.executeStart (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/packet_parser.js:75:16)
    at Socket.Connection.stream.on.data (/home/alexandermartynov/Рабочий стол/mikro-orm-test-1/mikro-orm-test/node_modules/mysql2/lib/connection.js:77:25)
    at Socket.emit (events.js:198:13)
    at Socket.EventEmitter.emit (domain.js:448:20)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)
  code: 'ER_BAD_FIELD_ERROR',
  errno: 1054,
  sqlState: '42S22',
  sqlMessage: 'Unknown column \'e1.domain\' in \'where clause\'' }

To Reproduce
Check attached sample project
Additional context
Most probably it is related to incorrect joined table name counter if table present multiple times because of smart join, sorting and deep population
Versions
3.0.0-rc.4

mikro-orm-test.zip

Will be part of next RC.

This is broken again in latest version. It doesnt work anymore.

Nope, it is not broken again. The fix had a test case for regressions, and it is still passing. If you face similar issue, please file proper report with steps to reproduce (ideally including reproduction repository), as well as all the requested information in the issue template.


Hide accelerators when they are not present in the SR selection

Closes: RHOAIENG-547
Description
Hides and modifies the description list under Serving Runtime section.

1. When accelerator is selected

2. When accelerator is not selected

3. When no accelerator is enabled

How Has This Been Tested?

Deploy a SR
Try different cases with selecting, deselecting or disabling accelerators

Test Impact
Added integration test to check if the accelerator and other fields.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@vconzola

@Gkrumbach07 What happens when you've already added an accelerator to a servingruntime but then you disable it from the admin section?
I would assume if the gpu nodes are still there, the model's pod will still use the gpu right?
I'm just trying to figure out what's the best case for when a InferenceService contains the gpus but the accelerator is disabled in the admin panel, should we still display that the accelerator is available?

@Gkrumbach07 What happens when you've already added an accelerator to a servingruntime but then you disable it from the admin section?
I would assume if the gpu nodes are still there, the model's pod will still use the gpu right?
I'm just trying to figure out what's the best case for when a InferenceService contains the gpus but the accelerator is disabled in the admin panel, should we still display that the accelerator is available?

@lucferbux when we already have an accelerator added but disabled, we show them with (disable) added with name.

@dpanshug thanks, funny that i tested it but missed the diabled label. Thanks for clarifying that!

@dpanshug thanks, funny that i tested it but missed the diabled label. Thanks for clarifying that!

I forgot that case, just added now. Tests still pending in latest change pushed

@vconzola are we ok with this change? to me seems great

@lucferbux Yes, lgtm.


[Core] Ensure inline toupper/tolower

Some standard lib headers (e.g. stdlib.h) end up setting __NO_CTYPE. When ctype.h is processed with this flag different code is compiled, amongst others making toupper/tolower and some isxxx() not inline but calling extern functions (which is slower). Because of include guards to ensure the inlining, ctype.h must be the first header file included for a module.

This behaviour is a potential libstdc++ bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100128


Add R to executors

Thanks for this awesome project! If it's welcome, I added R support to the executors. I've only tested this locally but it seems to work nicely.

Rscript is a command-line tool that's installed along with R, and should behave in a way that's compatible with your approach.

Thanks!


Typescript support please

Hello.
I'm a big fan of objection.js
I trying to use objection-db-errors, but there is problem with typescript.
When I extends Objection.js Model with DbErrors in typescript, they cannot get Model's method like query().
Could you please support Typescript?

I'd definitely merge a PR for typings.

Actually the PR should be addressed to the db-errors library, which contains the error classes. This library is just a few lines of code to turn that library into an objection plugin.

1.1.0 has been released with typings.


Classifai screen stuck when import empty folder

To Reproduce
Import an empty folder
Expected behavior
Back to labelling tool without error
Screenshots

Desktop (please complete the following information):

Windows
v1.0.0

Not particularly urgent, doesnt need to complete in this week. will include in v1.1.0 as fix
Work on this when docs for open sources are almost done or pending my feedback
Please base the fix from this branch https://github.com/CertifaiAI/classifai/tree/v1.1.0
Thanks @toh-sie-hung

okay, sure

Resolved with #226


laravel 5.2.14 issue

Hi,
I am wondering if anyone else having issue with:
Class 'Jenssegers\Mongodb\Eloquent\Model' not found
Using: "jenssegers/mongodb": "^2.3"
I have registered a provider in config/app.php:
Jenssegers\Mongodb\MongodbServiceProvider::class,
my model looks like this:
namespace App;

use Jenssegers\Mongodb\Eloquent\Model as Eloquent;

class SomeCustomer extends Eloquent
{
    protected $collection = 'customers';

    protected $connection = 'mongodb';
}

So when I try to use it:
$customers = SomeCustomer::first();
I get the erorr:
Class 'Jenssegers\Mongodb\Eloquent\Model' not found
so I am wondering its just me doing something awkward, or there is some known issue?
thanks

What version are you using?

"jenssegers/mongodb": "^2.3"

2.3 uses Jenssegers\Mongodb\Model. This is a change in the new 3.0.0 version.

In my last commit both classes should work for you. Will tag new version.

That worked brilliantly!
thanks!


Help Application content missing

Summary
After pr https://github.com/eclipse-tractusx/portal-assets/pull/226
likely the application app broke.
Issue Env.: portal-rc.dev
Current screen:

This is expected for the (rc).dev env as the content isn't retrieved from a specific tag and the logic defaults to the main branch. In other words, the directory structure is already adjusted but not the content. Once the release branch for 1.8.0-rc2 gets merged into main, the content will match the new directory structure. Such an intermediate state can't occur on envs which running released versions, like int env, as a release always comes with a specific tag.

The release branch for 1.8.0-rc2 gets has been merged into main.


Invariant Violation: requireNativeComponent: "RNCSlider" was not found in the UIManager.

Environment

react-native info output:

(node:31988) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
System:
    OS: Windows 10 10.0.19045
    CPU: (6) x64 Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
    Memory: 1.40 GB / 15.94 GB
  Binaries:
    Node: 16.14.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.0 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK:
      Android NDK: 22.1.7171670
    Windows SDK: Not Found
  IDEs:
    Android Studio: Version     2<IP_ADDRESS> AI-203.7717.56.2031.7678000
    Visual Studio: Not Found
  Languages:
    Java: 11.0.18
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: ^0.70.8 => 0.70.8
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

are you using the new architecture?
No.

which version of react & react-native are you using?
react : 18.1.0
react-native : 0.70.8

Description
Upgrading existing react native cli project. I am upgrading the reaction native version to 0.68.6 -> 0.70.8. I was warned to change to @react-native-community/slider because react-native no longer supports sliders after the version up. So I changed it, but I received the same error as above.
I wondered if it was a problem because I called from multiple screens, but the same problem occurs when I just call the slider in the App.js file. The bigger problem is that after you create a new project, the slider works and you don't know what the problem is. If necessary, I will compress and upload my node_modules.
 Thanks for taking the time to report it.
This issue has already been reported in #330, so let me close this one as a duplicate.

@BartoszKlonowski I'm not using tvos, and the version and environment are different from the problem you mentioned. Nevertheless, it's disappointing to end like this without properly checking and supporting just because it's the same error phrase. None of the writing on the issue you mentioned was helpful to me.

Hello @gwonsuji!
Sorry for misunderstanding. Thing is, that in the issue I linked is a place for me to keep all those errors in one place so I can easier keep track on all of them. Note that after I linked your issue I also added new label noticing it indeed does affect different environment than the original issue just like you said, so please do not worry.
Also, the fact that I closed the issue you created in favor of having it in the first reported for such error doesn't mean your issue will not be worked on, do not worry about it 👍  When having all of them linked in the "original one" I can still see all of them even when they are closed and I will cover all of them when I get to this issue regardless of their state or platform.
Let me know if explanation of my approach covered your concerns.

@BartoszKlonowski  Oh, I'm sorry I misunderstood. I just thought I was closing my problem and no more support. I'll be waiting.

I reinstalled dependencies several times (delete node_modules, pods, build and install node packages, pods and build in XCode), and you know. there's a status bar in XCode. I think I may've tried to build while it's doing something, which isn't noticiable, and I put a couple hours into it and it works now.


python38Packages.ijson: 3.1.3 -> 3.1.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.ijson is: "Iterative JSON parser with a standard Python iterator interface"
meta.homepage for python38Packages.ijson is: "https://github.com/ICRAR/ijson"
meta.changelog for python38Packages.ijson is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.1.4 with grep in /nix/store/cz2n27gc3m9745xzgdp29zdlyskg7nri-python3.8-ijson-3.1.4

directory tree listing: https://gist.github.com/1dd7a52ad13d97b148dacf1ed8f6f15e

du listing: https://gist.github.com/93023cde190a3d07ecfea0aa34593798

Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)

8 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.ijson
python38Packages.pysnow
python38Packages.snowflake-connector-python
python38Packages.snowflake-sqlalchemy
python39Packages.ijson
python39Packages.pysnow
python39Packages.snowflake-connector-python
python39Packages.snowflake-sqlalchemy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cz2n27gc3m9745xzgdp29zdlyskg7nri-python3.8-ijson-3.1.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.ijson https://github.com/r-ryantm/nixpkgs/archive/a6ae1d5dbf6b7f2c7761cdca4e607a235b94f199.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cz2n27gc3m9745xzgdp29zdlyskg7nri-python3.8-ijson-3.1.4
ls -la /nix/store/cz2n27gc3m9745xzgdp29zdlyskg7nri-python3.8-ijson-3.1.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

python38Packages.ijson
python38Packages.pysnow
python38Packages.snowflake-connector-python
python38Packages.snowflake-sqlalchemy
python39Packages.ijson

Maintainer pings
cc @rvl for testing.

@ofborg eval

Result of nixpkgs-review pr 116079 at a6ae1d5d run on aarch64-linux 1

5 packages built successfully:

python38Packages.ijson
python38Packages.pysnow
python38Packages.snowflake-connector-python
python38Packages.snowflake-sqlalchemy
python39Packages.ijson

Result of nixpkgs-review pr 116079 run on x86_64-linux 1

5 packages built:

python38Packages.ijson
python38Packages.pysnow
python38Packages.snowflake-connector-python
python38Packages.snowflake-sqlalchemy
python39Packages.ijson


GPay button is not shown on Firefox iOs

This question is related to:

[ ] React component (@google-pay/button-react)

I have a problem with displaying a button on the screen. Everything works fine on all platforms in all browsers in test and production enviroment except firefox ios.
<GooglePayButton
                      environment={googlePayEnvironment as google.payments.api.Environment}
                      paymentRequest={{
                        emailRequired: true,
                        apiVersion: 2,
                        apiVersionMinor: 0,
                        allowedPaymentMethods: [
                          {
                            type: 'CARD',
                            parameters: {
                              allowedAuthMethods: ['PAN_ONLY', 'CRYPTOGRAM_3DS'],
                              allowedCardNetworks: ['MASTERCARD', 'VISA'],
                            },
                            tokenizationSpecification: {
                              type: 'PAYMENT_GATEWAY',
                              parameters: {
                                gateway: gateway,
                                gatewayMerchantId: gatewayMerchantId,
                              },
                            },
                          },
                        ],
                        merchantInfo: {
                          merchantId: googlePayMerchantId,
                          merchantName: googlePayMerchantName,
                        },
                        transactionInfo: {
                          totalPriceStatus: 'FINAL',
                          totalPriceLabel: 'Total',
                          totalPrice: `100.00`,
                          currencyCode: 'UAH',
                          countryCode: 'UA',
                        },
                      }}
                      onLoadPaymentData={(paymentRequest) => {
                        myownmethodhere(paymentRequest)
                      }}
                      buttonType="plain"
                    />

Hi @FedkinAndrey Currently isReadyToPay always returns false for Firefox on iOS. The button components use isReadyToPay to determine if the button should be displayed. That's the reason why you don't see the button.

Thank you very much for your reply. If I understand you correctly, there is no way I can influence this behavior?

Thats correct. We are currently looking into this.

@FedkinAndrey we adjusted isReadyToPay to return true for Firefox on iOS. You should now see the Google Pay button.

Sounds cool! I need to test it and will let you know after that
But thank you anyway ))


Packages refinement - Stage 1

Description
We have been reviewing the packages building process, and we need to adjust some things to smooth out the following steps.
Functional requirements

The GH workflow to build packages must not build packages if there are packages for the same commit (last one) in the S3 bucket.
To improve performance, shallow clone the plugins' repos git clone --depth 1.
The service file must preserve the previous state on upgrade. If the wazuh-indexer service was running, the upgrade script must start the service after the upgrade. Same if the service was stopped (stopped ⇾ stopped, running ⇾ running).

Plan

[ ] #486
[ ] Shallow clone plugins' repos
[ ] Preserve previous state of wazuh-indexer.service on upgrade

References:

https://github.blog/open-source/git/get-up-to-speed-with-partial-clone-and-shallow-clone/

Update: actions/checkout performs a shallow clone by default.


Play Store Crash Alert: java.lang.SecurityException error skyrocketed

Describe the bug
After integrating this plugin the crash report on Play Store skyrocketed about "java.lang.SecurityException"
To Reproduce
Couldn't reproduce here, this is happening with real users, mostly Samsung.
Console Logs
java.lang.SecurityException:
at android.os.Parcel.readException (Parcel.java:1693)
at android.os.Parcel.readException (Parcel.java:1646)
at android.app.IAlarmManager$Stub$Proxy.set (IAlarmManager.java:228)
at android.app.AlarmManager.setImpl (AlarmManager.java:734)
at android.app.AlarmManager.set (AlarmManager.java:390)
at com.google.firebase.iid.FirebaseInstanceIdService.zza (Unknown Source)
at com.google.firebase.iid.FirebaseInstanceIdService.zza (Unknown Source)
at com.google.firebase.iid.FirebaseInstanceIdService.handleIntent (Unknown Source)
at com.google.firebase.iid.zzc.run (Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:607)
at java.lang.Thread.run (Thread.java:762)
Plugin Version
cordova-plugin-firebase 2.0.5
Additional context
This guy is saying that is just add some extra permissions, I'll test https://github.com/distriqt/ANE-Firebase/issues/125#issuecomment-351041824

Didn't solve! I'll try this fork:https://github.com/vnc-biz/cordova-plugin-firebase/commits/master
There are several issues fixed and some refactor possibly related to that.


Get-NavContainerAppInfo can return one app multiple times

I have situation, where I am using container with only one tenant, but the command
Get-NavContainerAppInfo -containerName XXX -tenantSpecificProperties -sort None
is returning one app, one version multiple times. Seems that it is added as standard app and even as dependency of another app. I will dig more to find the problem and potentially do the bugfix, but I am not sure if I will enough time till next week.

Additional info:
Result is duplicated even when -tenantSpecificProperties is not use nor None is changed to anything else.

If you enter a powershell command in the container, then Get-NavAppInfo must also duplicate them.
Are all instances installed and published?

No, it was in situation, that not all app versions were installed and published. Get-NAVAppInfo is giving each app/version only once. I think that it is because multiple version of one app exists, thus it will take the dependencies again and put them into list again. I will try to do more research when I will find some time. Right now I solved it with using
Select-Object -Unique -Property *
on the result...

Ok, tested it now (cannot leave it without testing for now :-))
If there is only one instance of the app- all is ok
If I published older version to have two version of same app - returns 4 apps - each version 2 times
If I published another older version - returns 9 apps, each version 3 times...
The app do not need to have dependencies. Just any app with multiple different versions published.

Any chance you can email me a .bak file and a imagename that has this problem?

Email on the way...

Fixed in <IP_ADDRESS>


GPL-nnn Convert the Broker class to use a Context Manager workflow

User story
As developers, we'd like to change the Broker class to use a context manager workflow. This will simplify calling the class/publishing RabbitMQ messages/error recovery
Who are the primary contacts for this story
Phil
Chris F
Acceptance criteria
To be considered successful the solution must allow:

[ ] Update the Broker class/RabbitMQ message publish workflow to use a context manager workflow

Dependencies
This story originates from the review of changes required for #203
Additional context
See pika documentation https://github.com/pika/pika/pull/627

https://github.com/pika/pika/issues/736


Make $route.hash mutable

Apologies if this has been raised up before (in which case I have failed at searching through the closed issues).
Is there any obvious reasons that we do not want to provide a mutable $route.hash property?
One thing I can think of is history.pushState compatibility which we may be able to just use a simple if..else to fallback to location.hash:
if (window.history.pushState) {
  window.history.pushState(null, null, '#hash|values')
} else {
  window.location.hash = '#hash|values'
}

Is there any obvious reasons that we do not want to provide a mutable $route.hash property?

Is there a specific use case for which it should be?
the whole $route object is generally immutable - a new one gets created for every navigation. I don't see what's special about the hash prop on the $route object.

This is a fresh use case I've just encountered -- imagine a view with such component http://element.eleme.io/#/en-US/component/collapse where a user would be able to share a link of the view with the states of the collapses (on/off) indicated and synced through URL hash.
For example http://example.com/collapses#consistency|efficiency would open the view with consistency and efficiency collapse sections opened and the others closed.
It's probably a minor use case, and pretty simple to achieve by manually doing what I proposed about pushState/location.hash. But if there's no anti-use case, I would think this is a really good convenience feature to make $route.hash mutable.

As explained, $route is designed to be immutable, it's a one-way reflection of the current browser location. Making it mutable opens up many potential issues. If you want to update the location, update it from the source.


Rewrap (F1) can't be undone and doesn't mark a buffer as changed.

I noticed that after rewrapping source files (tested with Rust and Swift), the changes can't be undone, and if rewrap was the only change, the containing window can be closed without warning. (Typically an attempt to close a changed file triggers an alert with a warning.)
Found on a fresh build of master (commit 9af3f596e3122ab54eecd279c323077497cac448).

@timburks thanks for this!
rewrap from the debug menu was very much a testing feature, and should probably be removed, although it may be getting used for real width measurement, which is currently in flight.
If you'd like a more useful version of rewrap, you can set a column width in your preferences file.

Also it shouldn't mark a buffer as changed, because it only affects the view. Perhaps you're thinking of a feature like "gwap" in vi, which would also be useful.

Thanks for your explanations! I don't need the Rewrap feature; I was just poking around and this struck me as a minor surprise worth mentioning.
It would be more clear that rewrap only affects the view if the line numbers on the left didn't update to reflect the wrapping. Also, rewrap seems to put the view in a wrapping mode that causes new text to be wrapped. I haven't found a way to exit that mode.

@timburks you're correct on both counts. The line numbers should be considered a bug, and there's an open issue in xi-core (https://github.com/google/xi-editor/issues/184) and the 'not being able to exit this mode' is an acceptable consequence of this only existing for testing. For finer-grained playing around you can change your config file. :)


How to increase limit

Limit 20mb
How to increase 2gb

Limit 20mb
How to increase 2gb

https://github.com/mohammad425/Public-Link-Telegram-Files/issues/1#issuecomment-602619779


Storage: add support to choose the namespace, and list

Currently, Storage trait only exposes a set and a get method and the ZDB implementation does not support choosing the namespace
We need the following

Support choosing the namespace
Support namespace SCAN (iterate over all objects)

We need both functionality to implement #21

Closed in d45c24855bf2178082c8e74de1e0ec3fad323903


Can't set custom message on required property

I have the latest 0.3.0 code.  Can't set custom message on required property.  I am trying this:
this.validator = new Validator(person);
this.validator.ensure('name').required({message: '^Enter your name'})

Results in the default error message - Name can't be blank.
This works OK for format.
this.validator.ensure('name').format({ pattern: "[a-z0-9]+", flags: "i", message: "^Bad format"})

Just looked at the changes.  This is because although changes were made to the validation rule class to ensure any configuration is being pushed through to validatejs, the same change wasn't made to the methods on the validator class.  For example, here are the length, and required rules on the validator class.
length(configuration) {
    this.config.addRule(this.currentProperty, ValidationRule.lengthRule(configuration));
    return this;
  }
presence() {
    this.config.addRule(this.currentProperty, ValidationRule.presence());
    return this;
  }

and here is the corresponding static methods in the validation rule class:
static presence(config = true) {
    return new ValidationRule('presence', config);
  }
static lengthRule(config) {
    return new ValidationRule('length', config);
  }

The methods on the validator class are missing the handling of the configuration parameter, therefore they will never pass the configuration through, even though the validation rule itself would accept the configuration and pass it on to validatejs.  Additionally we can't use the validation rule class directly as it's not exposed.
I'll see if I can submit a PR for this, although I'm already behind on my first planned submission haha

Definitely let's get this fixed up my bust.

Closed by https://github.com/aurelia/validatejs/pull/57


Refactor DataJobEphemeralStorageIT and DataJobTerminationStatusIT

Currently, the two tests DataJobTerminationStatusIT and DataJobEphemeralStorageIT (link won't work until https://github.com/vmware/versatile-data-kit/pull/1291 is merged) have some duplicated code. This code should be refactored to avoid the duplication.
The most likely solution would be to include the specific methods in the BaseIT class as both tests inherit from it.

Triaged. The issue seems to be fixed.


monaco.editor.createWebWorker in ESM

monaco-editor version: 0.16.6
Browser: Any
OS: Win 10
monaco.editor.createWebWorker requires a moduleId to load an AMD module. I am using ESM modules with parcel and I am not using the AMD loader. How can I use monaco.editor.createWebWorker without using AMD?
Is there another way to create a MonacoWebWorker with support for synchronizing models, etc.

You can call monaco.editor.createWebWorker and the also define MonacoEnvironment.getWorker or MonacoEnvironment.getWorkerUrl and then you can instantiate the worker by yourself. In the worker code, you can load the expected ESM module from the editor.
e.g.
https://github.com/Microsoft/monaco-editor-samples/blob/3e322e5dfb7a016f6bb4fdca250c1929f3876ca9/browser-esm-webpack/index.js#L3-L19
https://github.com/Microsoft/monaco-css/blob/8a2b406930aa2149e261480c9cf28f389f504ad8/src/css.worker.ts
import * as worker from 'monaco-editor-core/esm/vs/editor/editor.worker';
import { CSSWorker } from './cssWorker';

self.onmessage = () => {
	// ignore the first message
	worker.initialize((ctx, createData) => {
		return new CSSWorker(ctx, createData)
	});
};

Hi Alex. I have done all of that and pretty much copied the HtmlWorker example verbatim:
xml.worker.ts
import * as worker from 'monaco-editor/esm/vs/editor/editor.worker';
import XmlWorker from './XmlWorker';

self.onmessage = () =>
{
    // ignore the first message
    worker.initialize((ctx, createData) =>
    {
        return new XmlWorker(ctx); // don't need createData yet
    });
};

XmlWorker.ts
import * as ls from 'vscode-languageserver-types';
import { worker, Thenable, languages } from 'monaco-editor/esm/vs/editor/editor.api'

import IWorkerContext = worker.IWorkerContext;
import XmlLanguageService from '../Service/XmlLanguageService';

/** Worker for the XML code editor. */
export class XmlWorker
{
    private _languageId: string;
    private _ctx: IWorkerContext;
    private _languageService: XmlLanguageService;

    constructor(ctx: IWorkerContext, createData: ICreateData)
    {
        this._ctx = ctx;
        this._languageService = new XmlLanguageService();
        this._languageId = createData.languageId;
    }

    public doComplete(uri: string, position: ls.Position): Thenable<ls.CompletionList>
    {
        let document = this._getTextDocument(uri);
        let xmlDocument = this._languageService.parseXmlDocument(document);
        return Promise.resolve(this._languageService.doComplete(document, position, xmlDocument));
    }

    private _getTextDocument(uri: string): ls.TextDocument
    {
        let models = this._ctx.getMirrorModels();
        for (let model of models) {
            if (model.uri.toString() === uri) {
                return ls.TextDocument.create(uri, this._languageId, model.version, model.getValue());
            }
        }
        return null;
    }
}

export interface ICreateData {
    languageId: string;
    languageSettings: languages.html.Options; // use HTML options for now
}

export function create(ctx: IWorkerContext, createData: ICreateData): XmlWorker
{
    console.log('creating xml worker..');
    return new XmlWorker(ctx, createData);
}

I am using the parcel bundler and I have set up getWorkerUrl:
MonacoWorkerSetup.ts
export class MonacoWorkerSetup
{
    /** Sets up the worker configuration for Monaco. */
    public static setup()
    {
        (<any>self).MonacoEnvironment =
        {
            getWorkerUrl: function (moduleId, label)
            {
                switch (label)
                {
                    case "xml": return './js/workers/xml.worker.js';
                    //case "html": return './js/workers/html.worker.js';
                }
                return './js/workers/editor.worker.js';
            }
        }
    }
}

export default MonacoWorkerSetup;

XmlWorkerManager.ts
import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';
import IDisposable = monaco.IDisposable;
import Uri = monaco.Uri;
import { XmlWorker } from './XmlWorker';

const STOP_WHEN_IDLE_FOR = 2 * 60 * 1000; // 2min

export class XmlWorkerManager {

    private _idleCheckInterval: number;
    private _lastUsedTime: number;
    private _configChangeListener: IDisposable;

    private _worker: monaco.editor.MonacoWebWorker<XmlWorker>;
    private _client: Promise<XmlWorker>;

    constructor()
    {
        this._worker = null;
        this._idleCheckInterval = window.setInterval(() => this._checkIfIdle(), 30 * 1000);
        this._lastUsedTime = 0;
    }

    private _stopWorker(): void
    {
        if (this._worker)
        {
            this._worker.dispose();
            this._worker = null;
        }
        this._client = null;
    }

    dispose(): void
    {
        clearInterval(this._idleCheckInterval);
        this._configChangeListener.dispose();
        this._stopWorker();
    }

    private _checkIfIdle(): void
    {
        if (!this._worker)
        {
            return;
        }

        let timePassedSinceLastUsed = Date.now() - this._lastUsedTime;
        if (timePassedSinceLastUsed > STOP_WHEN_IDLE_FOR)
        {
            this._stopWorker();
        }
    }

    private _getClient(): Promise<XmlWorker>
    {
        this._lastUsedTime = Date.now();

        if (!this._client)
        {
            this._worker = monaco.editor.createWebWorker<XmlWorker>({

                // module that exports the create() method and returns a `XmlWorker` instance
                moduleId: 'vs/language/xml/xmlWorker', // ?? Not using AMD

                label: 'xml',

                // passed in to the create() method
                createData: {
                    languageId: 'xml',
                    languageSettings: null
                }
            });

            this._client = <Promise<XmlWorker>><any>this._worker.getProxy();
            console.log(this._client);
        }

        return this._client;
    }

    public getLanguageServiceWorker(...resources: Uri[]): Promise<XmlWorker>
    {
        let _client: XmlWorker;
        return this._getClient().then((client) =>
        {
            _client = client;
        }).then(_ => {
            return this._worker.withSyncedResources(resources)
        }).then(_ => _client);
    }
}

export default XmlWorkerManager;

However, I don't see the log from my XmlWorker create method, so it appears it cannot create the correct proxy and create() is not called. However I am unsure why this is.
I have built xml.worker.js and editor.worker.js seperately and editor.worker.js loads fine; I do not get any 'worker not found' messages.

@DJBMASTER Here is what works for me (with parcel):

index.js

import * as monaco from 'monaco-editor/esm/vs/editor/editor.api.js';

self.MonacoEnvironment = {
	getWorker: function (moduleId, label) {
		if (label === 'xml') {
			return new Worker('xml.worker.js')
		}
		return new Worker('../node_modules/monaco-editor/esm/vs/editor/editor.worker.js')
	}
}

const worker = monaco.editor.createWebWorker({
	moduleId: 'anything',
	label: 'xml',
	createData: {
		anything: 'anything'
	}
});
const proxy = worker.getProxy();
proxy.then((p) => {
	p.doComplete(null, null).then((r) => {
		console.log(`doComplete result: ${r}`);
	})
});

xml.worker.js:

import * as worker from 'monaco-editor/esm/vs/editor/editor.worker';

export function XmlWorker(ctx, createData) {
	this._ctx = ctx;
}
XmlWorker.prototype.doComplete = function() {
	return Promise.resolve('hello world');
};

self.onmessage = () => {
	// ignore the first message
	worker.initialize((ctx, createData) => {
		return new XmlWorker(ctx, createData);
	});
};

If you are using TS, the web worker code that creates a proxy from a class cannot in version 0.14.x cannot accurately read methods compiled to ES6, i.e. classes like XmlWorker must be written with the old prototype pattern. New ES6 classes will work once we ship the new version.

Hi Alex.
Aha!..after compiling my TS to target ES5 rather than ES6 everything started working correctly without any code changes. Is this limitation with web workers and compiling to ES6 documented anywhere?

No, it is just a coincidence that we have discovered it when we moved the VS Code codebase to ES6 a few weeks ago.
This is the commit which made it work with ES6 classes - https://github.com/Microsoft/vscode/commit/8fad1eec756d42b9fd757ea6170d0a7e37d91ca7#diff-b16e73e73cd4b54495d784ab26e5e92f

Heey @alexandrudima
I'm trying to implement a custom language/worker in combination with react-monaco-editor
This is my webpack config:
 entry: {
      app: [
        // Include an alternative client for WebpackDevServer. A client's job is to
        // connect to WebpackDevServer by a socket and get notified about changes.
        // When you save a file, the client will either apply hot updates (in case
        // of CSS changes), or refresh the page (in case of JS changes). When you
        // make a syntax error, this client will display a syntax error overlay.
        // Note: instead of the default WebpackDevServer client, we use a custom one
        // to bring better experience for Create React App users. You can replace
        // the line below with these two lines if you prefer the stock client:
        // require.resolve('webpack-dev-server/client') + '?/',
        // require.resolve('webpack/hot/dev-server'),
        isEnvDevelopment &&
          require.resolve('react-dev-utils/webpackHotDevClient'),
        // Finally, this is your app's code:
        paths.appIndexJs,
        // require.resolve('monaco-yaml/out/monaco.contribution'),
        // We include the app code last so that if there is a runtime error during
        // initialization, it doesn't blow up the WebpackDevServer client, and
        // changing JS code would still trigger a refresh.
      ].filter(Boolean),
      // Package each language's worker and give these filenames in `getWorkerUrl`
      // json', 'yaml', 'python', 'markdown
      // 'editor.worker': 'monaco-editor/esm/vs/editor/editor.worker.js',
      // 'json.worker': 'monaco-editor/esm/vs/language/json/json.worker',

      'editor.worker': 'monaco-editor/esm/vs/editor/editor.worker.js',
      'json.worker': 'monaco-editor/esm/vs/language/json/json.worker',
      'yaml.worker': 'monaco-yaml/out/yaml.worker',
    },
    output: {
      globalObject: 'self',
      // The build folder.
      path: isEnvProduction ? paths.appBuild : undefined,
      // Add /* filename */ comments to generated require()s in the output.
      pathinfo: isEnvDevelopment,
      // There will be one main bundle, and one file per asynchronous chunk.
      // In development, it does not produce real files.
      filename: isEnvProduction
        ? 'static/js/[name].[contenthash:8].js'
        : isEnvDevelopment && 'static/js/bundle.js',
      // TODO: remove this when upgrading to webpack 5
      futureEmitAssets: true,
      // There are also additional JS chunk files if you use code splitting.
      chunkFilename: isEnvProduction
        ? 'static/js/[name].[contenthash:8].chunk.js'
        : isEnvDevelopment && 'static/js/[name].chunk.js',
      // We inferred the "public path" (such as / or /my-project) from homepage.
      // We use "/" in development.
      publicPath: publicPath,
      // Point sourcemap entries to original disk location (format as URL on Windows)
      devtoolModuleFilenameTemplate: isEnvProduction
        ? info =>
            path
              .relative(paths.appSrc, info.absoluteResourcePath)
              .replace(/\\/g, '/')
        : isEnvDevelopment &&
          (info => path.resolve(info.absoluteResourcePath).replace(/\\/g, '/')),
    },

Then I use the following react code:
import React, { useRef, useEffect } from 'react';
import './App.css';

import MonacoEditor from 'react-monaco-editor';
import 'monaco-editor';
import 'monaco-yaml/out/monaco.contribution';

// @ts-ignore
// eslint-disable-next-line no-restricted-globals
self.MonacoEnvironment = {
  getWorkerUrl: function(moduleId: any, label: any) {
    console.log(moduleId, label);
    if (label === 'json') {
      return '/static/js/json.worker.chunk.js';
    }
    if (label === 'yaml') {
      return '/static/js/yaml.worker.chunk.js';
    }
    return '/static/js/editor.worker.chunk.js';
  },
};

const editorWillMount = (monaco: any) => {
  console.log(monaco.languages);
};

const App: React.FC = () => {
  const editorRef = useRef<any>(null);
  return (
    <MonacoEditor
      ref={editorRef}
      editorWillMount={editorWillMount}
      language={'yaml'}
      width="100%"
      height="100%"
      value={'px'}
      onChange={value => {
        console.log(value);
      }}
      options={{
        formatOnPaste: true,
        scrollBeyondLastLine: false,
        autoIndent: true,
        formatOnType: true,
        minimap: { enabled: false },
        renderWhitespace: 'all',
        automaticLayout: true,
      }}
    />
  );
};

export default App;

My workerManager.js:
/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
'use strict';
var STOP_WHEN_IDLE_FOR = 2 * 60 * 1000; // 2min
var WorkerManager = /** @class */ (function() {
  function WorkerManager(defaults) {
    var _this = this;
    this._defaults = defaults;
    this._worker = null;
    this._idleCheckInterval = setInterval(function() {
      return _this._checkIfIdle();
    }, 30 * 1000);
    this._lastUsedTime = 0;
    this._configChangeListener = this._defaults.onDidChange(function() {
      return _this._stopWorker();
    });
  }
  WorkerManager.prototype.dispose = function() {
    clearInterval(this._idleCheckInterval);
    this._configChangeListener.dispose();
    this._stopWorker();
  };
  WorkerManager.prototype.getLanguageServiceWorker = function() {
    var _this = this;
    var resources = [];
    for (var _i = 0; _i < arguments.length; _i++) {
      resources[_i] = arguments[_i];
    }
    var _client;
    return this._getClient()
      .then(function(client) {
        _client = client;
      })
      .then(function(_) {
        return _this._worker.withSyncedResources(resources);
      })
      .then(function(_) {
        return _client;
      });
  };
  WorkerManager.prototype._stopWorker = function() {
    if (this._worker) {
      this._worker.dispose();
      this._worker = null;
    }
    this._client = null;
  };
  WorkerManager.prototype._checkIfIdle = function() {
    if (!this._worker) {
      return;
    }
    var timePassedSinceLastUsed = Date.now() - this._lastUsedTime;
    if (timePassedSinceLastUsed > STOP_WHEN_IDLE_FOR) {
      this._stopWorker();
    }
  };
  WorkerManager.prototype._getClient = function() {
    this._lastUsedTime = Date.now();
    if (!this._client) {
      this._worker = monaco.editor.createWebWorker({
        // module that exports the create() method and returns a `YAMLWorker` instance
        moduleId: 'vs/language/yaml/yamlWorker',
        label: this._defaults.languageId,
        // passed in to the create() method
        createData: {
          languageSettings: this._defaults.diagnosticsOptions,
          languageId: this._defaults.languageId,
          enableSchemaRequest: this._defaults.diagnosticsOptions
            .enableSchemaRequest,
        },
      });
      console.log(this._worker);
      this._client = this._worker.getProxy();
    }
    return this._client;
  };
  return WorkerManager;
})();
export { WorkerManager };

As you can see here the _foreignProxy isn't getting resolved. And I don't know why.
I'm trying to implement the following code monaco-yaml

@ToonvanStrijp Did you ever figure out the issue with _foreignProxy never getting resolved? I ran into the same think when trying to get monaco-yaml to work with react-monaco-editor.

@humandad Yup I solved it by making my own implementation based on the monaco-yaml support library. https://gist.github.com/ToonvanStrijp/44b8f96f934ee18dce6a96b887beca64


Remove duplicated entry from README

Remove the duplicated entry mips-unknown-linux-musl in the README.

Thanks for catching this.
bors r+


one first time init  run  twice

This is a workaround for various issues using the documented way to start a tour from a specific step:
introJs().goToStep(2).start(); //starts introduction from step 2


webapp loading message

let the user know something is happening

+1 +1 +1
On Sun, May 6, 2018 at 10:35 PM, marcovzla<EMAIL_ADDRESS>wrote:

let the user know something is happening
You can view, comment on, or merge this pull request online at:
https://github.com/clulab/eidos/pull/308
Commit Summary

show loading message in webapp
validate text

File Changes

M webapp/app/views/index.scala.html
https://github.com/clulab/eidos/pull/308/files#diff-0 (7)
A webapp/public/images/loading.svg
https://github.com/clulab/eidos/pull/308/files#diff-1 (1)
M webapp/public/javascripts/main.js
https://github.com/clulab/eidos/pull/308/files#diff-2 (21)
M webapp/public/stylesheets/main.css
https://github.com/clulab/eidos/pull/308/files#diff-3 (26)

Patch Links:

https://github.com/clulab/eidos/pull/308.patch
https://github.com/clulab/eidos/pull/308.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/308, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFInicnxHdzbp22IhtLBV4Kj9-0ng6Z_ks5tv90rgaJpZM4T0bA_
.

Cool!  Do you mind if I change the typography a little?  That's a nice n-dash, so I'd like to continue and write alert("Please write something."); and "Reading text..."
These have been great changes recently.  If you have any more in mind I wonder if some planning or prioritizing would be useful.  Perhaps you already discussed it with others or these are ports from something else you're working on, though.  Thanks for the updates.

Sure, feel free to change anything. I will push another commit to change the textfield into a text area.
@bsharpataz feel free to change anything too.

I don't really have anything planned. So feel free to make suggestions.

Changes in the graphic will have to wait for a different PR, I guess.

ok -- yes, marco just showed me the funnest site for making/customizing
them, so I will actually prob submit a pr for one later, but my all means
merge w/o that :)
On Mon, May 7, 2018 at 10:46 AM, Keith Alcock<EMAIL_ADDRESS>wrote:

Changes in the graphic will have to wait for a different PR, I guess.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/308#issuecomment-387146124, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFInibph1BLw1Kj3yzWvOi56ZwbvTX23ks5twIh3gaJpZM4T0bA_
.


Ubuntu 17.04

On a virgin Ubuntu 17.04 desktop, after installing my app, doubleclicking on the app icon does nothing.  I then go install visual studio code and it works after that.  So it seems the deb is missing some dependencies for 17.04.

If I'm not mistaken, what this means is that your app has visual studio dependencies, not the electron-installer-debian. You should use the options.depends to add a list of the libraries and packages that your app depends on, so they'll be installed together with your app.


Use systemd to manage Telegraf's dcos_statsd socket

High-level description
This PR makes the socket for the command API for Telegraf's dcos_statsd plugin the responsibility of systemd, rather than leaving Telegraf to manage it.
This depends on a systemd API that was added with version 227: https://lwn.net/Articles/660733/

File descriptors passed during socket activation may now be named. A new API sd_listen_fds_with_names() is added to access the names. The default names may be overriden, either in the .socket file using the FileDescriptorName= parameter, or by passing FDNAME= when storing the file descriptors using sd_notify().

Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4465 dcos_statsd API socket should be managed by systemd

Related tickets (optional)
Other tickets related to this change:
N/A
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: This is a refactor with no change to external behavior.
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: Covered by existing tests.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

This PR is failing most CI jobs because it requires systemd >= 227. These failed jobs are deploying DC/OS on top of one of the operating systems we support, CentOS 7, which provides systemd 219. This PR will have to wait until we're certain that all our targeted OS's have a new enough version of systemd.


Update aokzoe_table.sh

update table to add A1 Pro to list.
Simplify A1 checks now that we know product names are reliably different.

I'll do a more comprehensive, full PR.


name issue

the reason youre not able to display the name from firebase is because the syntax is wrong.It should be username instead of name...cheers!

Hey @Getinwiththem
I'm setting the name here: https://github.com/sar-gupta/space/blob/49e012b70f104dc2f0bfffc8756357ec1b5e33b2/src/actions/auth.js#L18
I'm using user.displayName to get the name from the signed in user information, as you can see in the code linked above. Could you be more specific where you found the problem in the code? (It'd be great if you could provide the permalink to the line of code)

Closing due to no response.


grok-1 support.

This branch contains experimental adjusments to support Grok-1. By these adjusment this version doesn't support Llama 2 model anymore, so to merge this PR I need to make more changes to support both models at the same time.
How to run Grok-1?

Clone this repository (grok-1 branch).
git clone -b grok-1 https://github.com/b4rtaz/distributed-llama.git
Build Distributed Llama:
make main
Download quantized (Q40) weights from https://huggingface.co/b4rtaz/grok-1-dllama (180GB).
Merge split models files:
cat dllama-grok-1-q40.binaa dllama-grok-1-q40.binab dllama-grok-1-q40.binac dllama-grok-1-q40.binad dllama-grok-1-q40.binae dllama-grok-1-q40.binaf dllama-grok-1-q40.binag dllama-grok-1-q40.binah dllama-grok-1-q40.binai > dllama-grok-1-q40-final.bin
Run workers:
./main worker --port 9999 --nthreads 8
Run root node:
./main inference --weights-float-type q40 --buffer-float-type q80 --prompt "Hello world" --steps 128 --nthreads 8 --tokenizer tokenizers/grok-1-tokenizer.t --model dllama-grok-1-q40-final.bin --workers <IP_ADDRESS>:9999

Test
I successfully started the inference of Grok-1 on 4 x 16 vCPU, 64 GB RAM (4 x Google Cloud n2d-standard-16). Achieved 1.8 tokens/second. 🎉

What is interesting is that Grok-1 (314B) requires only 20 MB of data to synchronize and generate a single token. For comparison Llama 2 70B requires 32 MB.

Test
2 x c3d-highcpu-90 (90 vCPU, 45 core, 177 GB memory). During the test was used only 2 x 64 cores due to Distributed Llama limitations. Achieved 4.3 tokens / second. 🎉


[Program]: Write a GO program to check armstrong number

Description
Write a GO program to check armstrong number
An Armstrong number is a number that is equal to the sum of cubes of its digits.
Input  : 153
Output : Armstrong Number

How to contribute

Save the solution in program/program/check-armstrong-number/check_armstrong_number.go file

!assign


Summer time changes between the workshop weeks

Add an explicit note of this and add one converter per week.
Review: general

Thanks for that!


Pilosactl create should be able to create hosts in AWS

This is being broken out of #171 as a separate task.

cody and I are going to look into qaz for AWS provisioning - that may get baked directly into Pilosa tooling at some point, but that's pretty far removed from this, so I'm going to close it.


[Feature]: Fluid Ounce

Describe the feature you want to add
Support Fluid ounce unit (for water)
Describe your proposed solution
No response
Describe alternatives you've considered, if relevant
No response
Additional context
References:

https://www.inchcalculator.com/convert/volume/

@sadrasabouri Please take care of this when you have some free time. 💯


Add Dockerfile for dependency check

After a discussion on #577 I am creating a new pull request for the Dockerfile, with HTTPS source and fetching of current release.
After the pull request is accepted, I will create the repository on hub.docker.com.

I tried to create a docker repository, but I am limited to my own git repositories to add.
We have the option that you add me to as privileged to this git repository or that you create an account and we ask someone like @psiinon with more rights to add you @jeremylong to the OWASP group on hub.docker.com so that you can create the docker repository by yourself.

No problem adding relevant people to the OWASP docker hub - just let me know the docker hub usernames. Ideally in an email from the relevant OWASP email acc.

Is there any chance to get the docker repository up to docker hub? Apparently it is not up there https://hub.docker.com/u/owasp/ - so the documentation in README.md is currently wrong.


Refactor: Use last ambientTemperature from lastState

this should build upon #853
within ThermalGrid.energyDemand I introduced the last ambientTemperature very quick and dirty. This can and should be refactored. The ambientTemperature of the last state is also part of the last HpState and can be taken from there. That would make the method more comprehensive. This may lead to further adaptions...
see:
          Note from my side: In my opinion both temperatures are necessary here, the ambientTemperature of the last state and the actual one. Since the HpState contains the lastAmbientTemperature this can be done nicer and would be a good HiWi-Job. As well some tests for different cases like falling and rising temperature would be great.

Originally posted by @danielfeismann in https://github.com/ie3-institute/simona/pull/853#discussion_r1724463737

Blocked by #929
Note to self: After #929 is completed update this issue here


Licensing

What license is php-casperjs licensed under?

Hello,
php-casperjs is licensed under MIT


[html] auto rename broken state when deleting tags

Testing #85973
<html>
    <foo>

    </foo>
</html>

put cursor at the end of foo of line 2
press backspace three times
auto rename mode doesn't exit, and leave the document in a weird state

When you don't have a complete pair, I think updating <f to <bar when you rename f to bar is fine. Or is your case different?

This one seems caused actually by https://github.com/microsoft/vscode/issues/86151


is amplify still being developed?

Doesn't look like it

Basically, appendTo shut down for a while then got bought, this pretty much halted development on the project as the staff there were maintaining it. I'm not sure what @mikehostetler plans to do with this, but right now there is no core maintainer/reviewer for PRs, features, fixes, etc.

This may be inappropriate here but I'm not one to ask for permission before doing things :)
Anyway, I'm the maintainer of msngr.js so if you're looking for an actively maintained library that supports pub / sub type of messaging you could always check that out. It doesn't provide a store API like Amplify but it does have basic AJAX like requests (so it can somewhat replace Amplify's APIs).

Anyone have any thoughts on setting up a fork to replace it?

@dotnetchris As Jordan said above, unfortunately there's no effort being spent towards Amplify at this time.  I'm happy to bring on another maintainer or support a friendly fork.


failed to retrieve block from DALC with local-celestia-devnet v0.9.2 and onwards

8:38PM DBG trying to retrieve block from DA daHeight=17 module=BlockManager
8:38PM ERR failed to retrieve block from DALC daHeight=17 errors="failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later; failed to retrieve block: current head local chain head: 16 is lower than requested height: 17 give header sync some time and retry later" module=BlockManager

same on v0.9.5?

yes.

Should we move this to rollkit/local-celestia-devnet?

i think the fix should happen in rollkit, so the issue can be here.

I wonder if this is looking for a height+1 and that's the issue?

This might have been introduced from https://github.com/celestiaorg/celestia-node/pull/2108

I'm experiencing this on:

celestia-node v0.10.0
network: blockspacerace
rollkit version v0.7.3

3:00PM ERR failed to retrieve block from DALC daHeight=565665 errors="failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data; failed to retrieve block: client-nd: response code is not OK: share: namespace not found in data\ngetter/ipld: failed to retrieve shares by namespace: share: namespace not found in data" module=BlockManager

Full logs can be found here

oh wow, didn't know 0.8.0 was released. nice!

fixed in celestia-node v0.10.3 release. i tested it using node v0.10.3 and celestia-app: v0.13.2


Fire a map-loaded event

It would be nice to have a mechanism to know when the map is fully loaded.

[ ] Discuss public api
[ ] Implement this new api.

As long as I know, we only have full control over the layer objects, and its better not to pollute the mapbox namespace. So my approach would be something like:
layer.on('loaded', callback);

Map loaded can be a syntetic-event fired when all layers are loaded.
@davidmanzanares any idea about how to implement this?

Should be layer.on('load', callback); to be Mapbox GL naming consistent.
The data layer should have an internal mechanism to let the layer know that everything needed is loaded. This could be another callback parameter to the _bindLayer() method. Once this is fired Layer must keep track of the "All data is here" state and then, after 2 repaints (in the moment the first repaint happens the data is painted over the GL context, but that the framebuffer hasn't been swapped yet) it should fire the event.
Regarding the implementation on the Dataset class, you need to keep track of the last requested tiles, and each time a new tile is returned from the server, you need to check if this is the last one you needed to inform the layer.

Related to: https://github.com/CartoDB/renderer-prototype/issues/39

https://github.com/CartoDB/renderer-prototype/pull/113


refactors application controller and search service to ts. adds servi…

…ce annotations to ts registry for ember/service

Codecov Report

Merging #1252 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1252      +/-   ##
=========================================
- Coverage     5.9%   5.83%   -0.07%
=========================================
  Files          59      57       -2
  Lines        2220    2211       -9
  Branches      480     478       -2
=========================================
- Hits          131     129       -2
+ Misses       2089    2082       -7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2218fc1...9b6d404. Read the comment docs.

Coverage remained the same at 27.594% when pulling 9b6d404a41f8cc9d542971a754170c3471a16704 on theseyi:refac-sources into 2218fc12d5d5b0270927a3fc0180e24f367a55b7 on linkedin:master.


failed (add): exec: "sh": executable file not found in $PATH

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Warning  FailedCreatePodSandBox  22s   kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "1b84b823053ccde1c218e402407ee2a1fde9db134d4373b3ea18061dad04230a": plugin type="istio-cni" name="istio-cni" failed (add): exec: "sh": executable file not found in $PATH
Warning  FailedCreatePodSandBox  6s    kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "1609d24df83e6b7ee26493a923b1b68c4d1fde55efdde10485122e2f6b7ed257": plugin type="istio-cni" name="istio-cni" failed (add): exec: "sh": executable file not found in $PATH
It works in 1.20.1
Version
istio 1.20.2

Additional Information
No response

this issue is happening on EKS bottlerocket

i kept the istio control plane at 1.20.2  . just changed istio cni to 1.20.1 and this configuration works

A similar issue: https://github.com/istio/istio/issues/48746
This is fixed by https://github.com/istio/istio/pull/48757

https://github.com/istio/istio/issues/48746


Add an OEP-2 compliant openedx.yaml file

This adds an openedx.yaml file, as described by OEP-2:
http://open-edx-proposals.readthedocs.io/en/latest/oeps/oep-0002.html
The data in this file was transformed from the contents of
edx/repo-tools-data:repos.yaml

@edx/platform-team: I've assigned this repo to you guys.

Why not? 😄 👍


Grid align prop possible values are limited

Problem description
Using v1/next: If I try to use <Grid align='baseline'>...</Grid>, I get the following prop-type warning (in dev mode only):
Warning: Failed prop type: Invalid propalignof valuebaselinesupplied toGrid, expected one of ["flex-start","center","flex-end","stretch"]

Grid align prop doesn't allow baseline and other possible align-items flexbox values. Authorized Grid values are listed here.
But flexbox specification allows more than those 4 values: see here.
Link to minimal working code that reproduces the issue
Here a webpackbin. Open the console to see the warning.
Versions

Material-UI: v1-beta3
React: 15.6.1
Browser: Chrome, Firefox, probably others...

The baseline value should be supported.  I've submitted a PR for this.


Test 2

Task 1 Prediction - Adsorption Energy (No Coordinate Data
Mean Absolute Error: 2.138
R2: -2.927
Normalised Mean Absolute Error (Assessed): 1.783
Points: 0
Task 2 Prediction - Adsorption Energy (Coordinate Data)
Mean Absolute Error: 2.138
R2: -2.927
Normalised Mean Absolute Error (Assessed): 1.783
Points: 0


Migrate errorMessage string ref

Summary
Migrate errorMessage string ref to new ref syntax
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/16037

Hello @sridhar02,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thanks for the PR @sridhar02. Heads up that some types checks failed with :
components/admin_console/admin_settings.tsx:269:29 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: Readonly<OverlayProps>): Overlay', gave the following error.
    Type 'HTMLDivElement | null' is not assignable to type 'Function | Element | Component<any, {}, any> | undefined'.
      Type 'null' is not assignable to type 'Function | Element | Component<any, {}, any> | undefined'.
  Overload 2 of 2, '(props: OverlayProps, context?: any): Overlay', gave the following error.
    Type 'HTMLDivElement | null' is not assignable to type 'Function | Element | Component<any, {}, any> | undefined'.
      Type 'null' is not assignable to type 'Function | Element | Component<any, {}, any> | undefined'.

269                             target={this.errorMessageRef.current}
                                ~~~~~~

  node_modules/@types/react-bootstrap/lib/Overlay.d.ts:14:9
    14         target?: Function | React.ReactInstance;
               ~~~~~~
    The expected type comes from property 'target' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<Overlay> & Readonly<OverlayProps> & Readonly<...>'
  node_modules/@types/react-bootstrap/lib/Overlay.d.ts:14:9
    14         target?: Function | React.ReactInstance;
               ~~~~~~
    The expected type comes from property 'target' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<Overlay> & Readonly<OverlayProps> & Readonly<...>'

Found 1 error.

Could you please take a look?

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

Hi @sridhar02, could you address the failing type checks?  Once those are fixed, I'll assign reviewers to the PR and move toward getting full reviews and merge!

@jfrerich  @hanzei  I have updated the PR and all the checks are passing, I don't know why the build is failing can you check and review the PR?

@sridhar02 I've restarted CI. Let's see if that fixes the issue.

@hanzei I think it fixed the issue, You just have to remove the stale label and work in progress label then we can see about all the checks for the PR

/update-branch

/update-branch

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 4fe70242dcfe697053773f56a96d3c54acaa9f4a


Update disable-access-to-services-with-microsoft-365-powershell.md

Made changes to the PS script
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12333

@JohanFreelancer9 Please copy review


Merge in v2.20.1

Merges v2.20.1 into our fork
The previous patches applied cleanly - see the diff: https://github.com/braze-inc/mongo-ruby-driver/compare/v2.20.1..merge-2.20.1

I see a bunch of tests fail with the upstream test matrix, I think we should run the tests for this version in gemtester before we say its ready

Passing with gemtester - https://github.com/braze-inc/gemtester/compare/mongo-2.20.1


Response variations via Node Red...

Hi,
I've just started to implement Watson into our workflow. I've noticed that if the response type is sernt to sequential, the assistant node always returns the same response (unlike the test chat online), how can we avoid this?

Please provide an example for clarification. Sequential is an option on the Conversation dialog editor, so don't know how it would relate to node-red. What happens if you clear out the context and session on the online test chat?


Ext/play next

I've encountered persistent issues with this extension over the past few days, which prompted me to take action and contribute towards resolving them. Despite being unable to pinpoint the root cause of the errors, I've made a series of quality-of-life improvements. Specifically, I've enhanced the method of adding tracks to the top of the queue by utilizing insertIntoQueue instead of appending to the end and subsequently reordering the queue. Additionally, I've integrated a more robust album fetching function, inspired by the 'shuffle+' extension. My aim is to enhance the overall functionality and reliability of this extension, as it holds a significant place in my daily usage.

Thanks for the PR @TechShivvy, sorry It took a long time to reply lol; I updated the extension with this logic locally, as there were conflicts, and added you as a co-author.
Thanks for contributing!


2 n64 connections

Is it possible to connect 2 n64 connections using this method, if so what connections should be used?

I don't think it's possible since the timing is super precise and there's barely enough time at the Arduino clock rate to read one N64 controller's signal. Sorry!


Restrict access by origin domain and limit the number of connections

Hello there,
I've been able to successfully implement the cli/workerman/staging.php script which is now running as shown below.
php cli/workerman/staging.php start
Welcome to PHP Chess Server
Commands available:
/accept {"jwt":"<string>"} Accepts an invitation to play online with an opponent.
/draw {"action":["accept","decline","propose"]} Allows to offer a draw.
/heuristics {"fen":"<string>","variant":"<string>"} Returns the heuristics of a chess position.
/leave {"action":["accept"]} Allows to leave a game.
/legal {"position":"<string>"} Returns the legal FEN positions of a piece.
/online_games Returns the online games waiting to be accepted.
/play_lan {"color":"<string>","lan":"<string>"} Plays a chess move in long algebraic notation.
/randomizer {"turn":"<string>","items":"<string>"} Starts a random position.
/rematch {"action":["accept","decline","propose"]} Allows to offer a rematch.
/resign {"action":["accept"]} Allows to resign a game.
/restart {"hash":"<string>"} Restarts a game.
/start {"variant":["960","capablanca","capablanca-fischer","classical"],"mode":["fen","san","play","stockfish"],"settings":{"color":["w","b"],"fen":"<string>","movetext":"<string>","settings":"<string>","startPos":"<string>"}} Starts a new game.
/stockfish {"options":{"Skill Level":"int"},"params":{"depth":"int"}} Returns Stockfish's response to the current position.
/stockfish_eval {"fen":"<string>","variant":"<string>"} Returns Stockfish's evaluation for the given position.
/takeback {"action":["accept","decline","propose"]} Allows to takeback a move.
/tutor_fen {"fen":"<string>","variant":"<string>"} Explains a FEN position in terms of chess concepts.
/undo Undoes the last move.

Listening to commands...
Workerman[cli/workerman/staging.php] start in DEBUG mode
------------------------------------------- WORKERMAN --------------------------------------------
Workerman version:4.1.14          PHP version:8.3.1           Event-Loop:\Workerman\Events\Select
-------------------------------------------- WORKERS ---------------------------------------------
proto   user            worker          listen                      processes    status
ssl     standard        none            websocket://<IP_ADDRESS>:8443    1             [OK]
--------------------------------------------------------------------------------------------------
Press Ctrl+C to stop. Start success.

Now I'd want to write a production script called cli/workerman/prod.php to enable some restrictions similarly as with cli/ratchet/prod.php.
Here are two questions.

Is it possible to limit the number of connections to the chess server?
How can I restrict access by origin domain?

Thank you for the help, and keep it up.

No.
When workerman version <= 4.1
you can see https://www.workerman.net/doc/workerman/appendices/about-websocket.html

<?php
require_once __DIR__ . '/vendor/autoload.php';

use Workerman\Connection\TcpConnection;
use Workerman\Worker;

$ws = new Worker('websocket://<IP_ADDRESS>:8181');
$ws->onConnect = function($connection)
{
    $connection->onWebSocketConnect = function($connection , $httpBuffer)
    {
        // This is where you can determine if the connection is from a legitimate source and close it if it is not.
        // $_SERVER['HTTP_ORIGIN'] identifies the site from which the page initiated the websocket connection.
        if($_SERVER['HTTP_ORIGIN'] != 'https://www.workerman.net')
        {
            $connection->close();
        }
        // onWebSocketConnect where $_GET $_SERVER is available.
        // var_dump($_GET, $_SERVER);
    };
};
Worker::runAll();


Undesirable zoom when entering page with ViewPager2

I have such a problem - when scrolling with view pager some of the pages are auto zoomed a little and after a second they revert to original size. This seems to not occur when scale type of an imageView is set to Matrix, but not confirmed. I have a default configuration in code, nothing custom. Additionally autoReset seems to not work everytime i lose interaction with image.
app:zoomage_autoResetMode="ALWAYS"
app:zoomage_restrictBounds="true"
app:zoomage_animateOnReset="true"
app:zoomage_autoCenter="false"
app:zoomage_translatable="false"
app:zoomage_zoomable="false"
app:zoomage_minScale="1"
app:zoomage_maxScale="5"
app:zoomage_doubleTapToZoom="false"

Are you using the current release or the snapshot?

Release version
pon., 9 mar 2020 o 19:52 Jeff Sibbold<EMAIL_ADDRESS>napisał(a):

Are you using the current release or the snapshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jsibbold/zoomage/issues/88?email_source=notifications&email_token=AGPFOUC7IKX4HXBVCPXYGRTRGVCIZA5CNFSM4LCH6KRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOITPIQ#issuecomment-596719522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGPFOUCHY2IJA53EDVXF7T3RGVCIZANCNFSM4LCH6KRA
.

--
Andrzej Piątkowski
phone: 696928942
<EMAIL_ADDRESS>

Can you please give the snapshot a try and see if you experience the same issues?

Unfortunately I am not able to because we have restrictions regarding
access to custom repositories.
W dniu pon., 9.03.2020 o 22:22 Jeff Sibbold<EMAIL_ADDRESS>napisał(a):

Can you please give the snapshot a try and see if you experience the same
issues?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jsibbold/zoomage/issues/88?email_source=notifications&email_token=AGPFOUF5DFRP2PKBGTXAUTTRGVT2TA5CNFSM4LCH6KRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJD2IY#issuecomment-596786467,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGPFOUCL7PV2EL43Z4P5OKTRGVT2TANCNFSM4LCH6KRA
.

--
Andrzej Piątkowski
phone: 696928942
<EMAIL_ADDRESS>

Hi,
I'd like to confirm that I have a similar problem and that using matrix fixes the issue but (at least for me) if I zoom and translate the it gets restored to the previous size after I release the tap.
I don't use a viewpager and load the pictures with Glide

1.3.1 is in jcenter now


[Feature] exclude option for check_cols snapshot

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Right now snapshots have check_cols - we could add a new config for the inverse, something like check_exclude_cols.
This would be similar to the incremental model config - merge_exclude_columns
Describe alternatives you've considered
No response
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response

hey, if this feature is still relevant i'd be keen to have a go at it this weekend. not contributed here yet but have a bit of time and should be able to get something together

That would be great @will-sylvera!  I have to make changes here and in the adapters repo here. should I just raise PRs in both places at once?

Yep! You can just raise both PRs at once, and we will review them together


Remove var

Declaring variables with var is considered in javascript as deprecated and as a bad practice, since it can overwrite variables already declared in your code block. Use const or let instead.
You can read about this in an article like Why don't we use var anymore?

Changed var statements to const & let statements
Documentation updated

I've been coding using var with that in mind
My habits are just hard to adjust to const and let
but also var is very much simpler

The code base is pretty stable so I don't see the need to change anything unless something is broken

in that case I will close the pr


M6 history

Replaces #1577 with an additional fix for the BF doc link - sphinx doesn't like you repeating the link text with a different URL. I'll open a corresponding PR on the codebase to make these match again.
Staged at https://www.openmicroscopy.org/site/support/omero5.3-staging/users/history.html
cc @jburel

To be replaced by autogen version


Unfold

I'm using your wonderful library to implement RAFT model for some video work, and I've encountered a snag with
https://pytorch.org/docs/stable/generated/torch.nn.functional.unfold.html?highlight=unfold#torch.nn.functional.unfold
It seems that this function maps to some other function in tch-rs.
https://docs.rs/tch/latest/tch/struct.Tensor.html#method.unfold has a completely different set of arguments.

Looking at the Python implementation of unfold, it seems to call the PyTorch im2col C++ function under the hood and not the unfold one. You can access this function via Rust, see im2col on docs.rs which arguments are more in line with the Python version.

Thank you!. I was able to resolve my issue. Still, It'd be nice to add this function to bring the API closer to the python one.


Conv/final admin UI

It should work now! Pulled main and fixed the conflicts!

use this PR instead now https://github.com/lnbits/lnbits/pull/553


Consider the EU S3 location constraint

The code that gets the region of a bucket was not considering the location constraint EU, even though it is a valid value as it's stated here: https://docs.aws.amazon.com/general/latest/gr/s3.html. Specifically, EU refers to the region eu-west-1. This PR modifies that code to take into account the EU value.

Closing because https://github.com/tableau/altimeter/pull/162 has been merged.


turbo-ignore can't find a commit, even though it exists

What version of Turborepo are you using?
1.5.2
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
OS is Mac, but CI is on Linux.
When trying to deploy something, I am getting an errorg from turbo-ignore.
Expected Behavior
I am expecting, that turbo-ignore works, and does not continue to deploy the app (because there was no change).
The commit, that is reference is available though.
To Reproduce
Hard to tell, if this is reproducable. I will try to get something up and running, until then, here is the log:

Cloning github.com/xxx/xxx (Branch: preview, Commit: fd30856)
--
09:37:08.089 | Cloning completed: 1.284s
09:37:08.091 | Running "npx turbo-ignore"
09:37:09.198 | npx: installed 1 in 1.023s
09:37:09.215 | ≫ Using Turborepo to determine if this project is affected by the commit...
09:37:09.216 | ≫ Inferred `@x/marketing` as scope from "/vercel/path0/apps/marketing/package.json"
09:37:09.217 | ≫ Found previous deployment for project
09:37:09.217 | ≫ Analyzing results of `npx turbo run build<EMAIL_ADDRESS>--dry=json`...
09:37:12.287 | exec error: Error: Command failed: npx turbo run build<EMAIL_ADDRESS>--dry=json
09:37:12.287 | ERROR  run failed: failed to resolve packages to run: commit 89bed4ad4dd822d40934ee113bb34f0c2d0e7f9f does not exist

EDIT:
Just attaching the image, showing that the commit is there:

What is your CI environment
→ I am using GitHub Actions. I am able to invite to the repo, but not to share publicly unfortunately.
How is it cloning your repo (shallow, up to a certain depth, etc)?
→ For cloning → I am using Vercel, so this is it. I think it's using the default git clone without flags? But honestly don't know.
Are you manually setting VERCEL_GIT_PREVIOUS_SHA?
→ No.

Could this be the case, because I am not "developing" on the main branch, but on a preview branch (like staging)?

@iduuck Since you're deploying to Vercel we have what we need to diagnose the issue available to us.
@tknickman dpl_EiRN39bbKxMSMC4EzpjLzUrAc8JR

Of note:
cloneDepthArg	--depth=10
cloneDepthType	depth

@tknickman I know what the issue is here: the state of our shallow-since flag. If you look at that deploy's buildEnv our env var is not set (we're not hitting the fallback path) and this commit is not within ten.
@iduuck This is a Vercel-specific issue, we know what it is, we're actively working on it, and it isn't an issue with turbo-ignore.
For now you can set VERCEL_DEEP_CLONE=1 in your environment variables to ensure that you get proper ignoring behavior, but there will be a point where that is strictly inferior to our default behavior (using --shallow-since). Also, the turbo-ignore error is not impacting correctness; it's just resulting in additional time spent building. Since you're using remote caching this doesn't make a significant difference.

@iduuck I recommend leaving your implementation as is; it will automatically start working with the ideal outcomes when we resolve the other issue.
I'm going to close this issue as there is nothing to do here.

@nathanhammond Is there an issue for this on the vercel repo? I'd like to track it as I have several apps within a monorepo and having each and every one rebuild is not ideal.

Literally working on this right now. No ETA (has to roll out) but 🔜

Awesome, thank you!

Please help me.

Hey @nathanhammond, sorry to mention you, but I have the same problem over and over again.
My default branch is preview, and I have a web, marketing, and sanity "app" in my monorepo, also I have several "packages" in my monorepo. I am currently working on the marketing page, but still the web app is deployed over and over again, because of the error from the initial thing.
turbo-ignore could not complete - commit does not exist or is unreachable

I'm seeing the same issue once again. I've made a commit in a monorepo that has multiple Vercel projects pointing to different parts of it and a single Vercel project was rebuilt - because of the commit does not exist or is unreachable turbo-ignore error. Deployment of every other project has been cancelled, as expected (the commit did not affect any of the projects).
dpl_58RTurS25hSHtW3ZAjH3PpXs66Ks

We had to pause roll out because of side effects. As a consequence of that, you will need to set VERCEL_DEEP_CLONE to make sure that you have enough commits on the build box in order for it to complete the comparison.
This is a consequence of the default cloned depth being 10.

Not completely related but I was having an issue running npx turbo-ignore in a github action.
Leaving my problem and solution here incase anyone else with the same issue stumbles across this thread.
When running npx turbo-ignore in a github action I was getting:
≫   UNKNOWN_ERROR: Error: Command failed: npx turbo run "test" --filter=frontend...[HEAD^] --dry=json
 ERROR  run failed: failed to resolve packages to run: git error: fatal: ambiguous argument 'HEAD^...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Turns out by default actions/checkout@v3 only has access to a single commit so git could not compare the current commit against a previous commit.
Fixed by passing fetch-depth: 0 to actions/checkout@v3 - fetches entire git history making previous commits accessible.
https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches


How to automate the [threshold] parameter in Honest example?

We realized we have to manually adjust the [threshold] parameter in Honest example in order to get acceptable results. We want to know what is the plan to automate the [threshold] parameter  adjustment? It is not very user friendly and not very practical as well.

Perhaps this could help: https://github.com/andyzoujm/representation-engineering/issues/22#issue-2004070656

Very helpful, thanks Andy


[spinel] add vendor hook for the host side of spinel

Allow out-of-tree compilation of vendor specific changes to the host side of spinel. By setting OT_SPINEL_VENDOR_HOOK_SOURCE_DIR, OT_SPINEL_VENDOR_HOOK_SOURCE and OT_SPINEL_VENDOR_HOOK_HEADER, the corresponding compile flags OPENTHREAD_SPINEL_CONFIG_ENABLE_VENDOR_HOOK and OPENTHREAD_SPINEL_CONFIG_VENDOR_HOOK_HEADER get set which force the use of the VenorRadioSpinel class instead of the regular RadioSpinel  in src/Posix/platform/radio

Does this PR need new tests because it relies on new buildflags that are not triggered by the current builds in testing

@abtink : I cannot retrigger the failing test, could you do this, or do I need to force push the same commit with a different hash?

@abtink : I cannot retrigger the failing test, could you do this, or do I need to force push the same commit with a different hash?

We can re-trigger. Just let us know.
I also have an script that retries all recent failed builds on OT GH (I usually ran it every morning and evening) - have been looking to see if we can automate this.

@abtink could you review once more?

@thcu-gp , can you help resolve the CLA check?

has something changed on the CLA part? I have authored commits in the past ...


Calculated Token value in object

What do you think about geting Token(keys) value from cassandra into Model ?
For example it need for calculating approximate progress bar :)

We are migrating all Github issues to the public Jira. Please find this issue in Jira: https://datastax-oss.atlassian.net/browse/PYTHON-268


Some fixes on Bluetooth (IDFGH-7972)

A set of small fixes on bluetooth.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.


Check lambda function invoke in cloudtrail logging

Steps to Reproduce
Name of the check I tested: awslambda_function_invoke_api_operations_cloudtrail_logging_enabled
When the cloudtrail data event is enabled with the ALL FUNCTIONS option, the prowler considers the status as FAIL.
When enabling the cloudtrail data event and specifying the name of a lambda function, the prowler considers the status as PASS
Expected behavior
Status as PASS when cloudtrail data events is enabled for all lambda functions
Actual Result with Screenshots or Logs
1-prowler_screenshots_data_events_disabled.png - running the prowler with the cloudtrail data event disabled.

2-aws_cli_screenshots_data_events_disabled.png - checking cloudtrail properties using aws cli. Cloudtrail Data event disabled.

3-prowler_screenshots_data_events_enabled_full.png - running the prowler after enabling the cloudtrail data event as FULL for all aws lambdas.

4-aws_cli_screenshots_data_events_enabled_full.png - checking cloudtrail properties using aws cli. Cloudtrail data events enabled as FULL for all aws lambdas.

5-prowler_screenshots_data_events_enabled_specifying_aws_lambda.png - running the prowler after enabling the cloudtrail data event and specifying the name of a lambda.

6-aws_cli_screenshots_data_events_enabled_specifying_aws_lambda.png - checking cloudtrail properties using aws cli after enabling the cloudtrail data event and specifying the name of a lambda.

How did you install Prowler?
From pip package (pip install prowler)
Environment Resource
At my workstation
OS used
Linux. Pop OS
Prowler version
Prowler 3.1.1
Pip version
pip 22.0.2 from /usr/lib/python3/dist-packages/pip (python 3.10)
Context
No response

Hi @stenionljunior, can you use the last version of prowler pip install --upgrade prowler? These errors should be solved in version 3.2.4. Let us know if that fixes the error.

Hi @sergargar, I updated the prowler version but it showed the same behavior.

Hi @stenionljunior,
We are going to review this and let you know asap !!
Thanks for using Prowler !!

Hi @stenionljunior,
We are trying to reproduce your issue but we can't.
We have created a trail that logs all Lambda events through an advanced event selector:

And then launched the check against 4 lambdas:

Can you launch the tool again with the --verbose flag to verify which check is failing ?

Hi @n4ch04,
I found something interesting. Running the same check using docker, the checks were PASS. Using via pip continues with the same behavior.
Using Docker:

Using pip:

Command used in docker:
docker run -ti --rm
--name prowler
--volume "$(pwd)":/prowler/output
--env AWS_ACCESS_KEY_ID
--env AWS_SECRET_ACCESS_KEY
--env AWS_SESSION_TOKEN
toniblyx/prowler:latest
-c awslambda_function_invoke_api_operations_cloudtrail_logging_enabled --verbose
Command used in pip:
prowler aws -c awslambda_function_invoke_api_operations_cloudtrail_logging_enabled --verbose

Hummm interesting, we are going to check if everything is up to date with pip package, thank you for the catch !!
Can you try Github installation from docs ? It should work fine https://docs.prowler.cloud/en/latest/#installation

Yep, @stenionljunior you are right, the last release (3.2.4 that comes from pip) does not include a fix for this case.
We are going to release a new one asap to solve it, until then we encourage you to use the latest version either from the repo or the docker container.
Thanks for using Prowler !!!


X-Content-Type-Options: nosniff is automatically added when Pagespeed is enabled

When mod_pagespeed is enabled it automatically adds X-Content-Type-Options: nosniff to the headers of images. Internet Explorer seems to have issues loading images when X-Content-Type-Options: nosniff is enabled.
Internet Explorer shows the following error in the console:
DOM7009: Can't decode image on URL (translated from Dutch).
After refreshing the page the image loads correctly from local cache.
It should be possible to disable the X-Content-Type-Options: nosniff header with an option.

Any news on this?

I ran a couple of tests with IE 11, and I could not confirm that X-Content-Type-Options: nosniff fails to load images yet.   Some more information to reproduce the DOM7009 error would be helpful:

Which IE version(s)
An example of an image that fails to load, plus the url that it was originally served from, and the full response headers that came with it.
The configuration of mod_pagespeed

Hi Otto,
Can I send you the information in a private mail?

@matthijsoli sure<EMAIL_ADDRESS>

You've got mail!

@matthijsoli found a way to reproduce it repeatedly.
I'm not sure yet where the bug exactly is, but one observation is that the images are served with content-encoding: gzip (without mod_pagespeed).
When you turn on mod_pagespeed, it will start intercepting these images at some point and serve the optimized version instead. But without gzip encoding. It's when the content-encoding gets switched from gzip to none that IE seems to get confused.
Can you turn off gzipping of the images? I suspect that will resolve the problem.

Hi @oschaaf, I tried disabling gzip completely and verified the headers but the issue remains.

@matterbury sorry, you're right.
Some more (stripped) observations
PageSpeed version is <IP_ADDRESS>-0
The url has a .JPG extension.
Response for the image with mod_pagespeed turned off:
   Cache-Control: public, max-age=2678400
   Content-Length: 108420
   Content-Type: image/png
   Date: Mon, 26 Jun 2017 12:34:39 GMT
   Expires: Thu, 27 Jul 2017 12:34:39 GMT
   Last-Modified: Wed, 04 Nov 2015 08:27:14 GMT
   Vary: User-Agent

(This works even tough the response body is a jpeg, because X-Content-Type-Options: nosniff is not present)
Responses for the image with mod_pagespeed turned on:
1st request. (OK):
   Cache-Control: public, max-age=2678400, s-maxage=10
   Content-Length: 108420
   Content-Type: image/png
   Date: Mon, 26 Jun 2017 12:35:01 GMT
   Expires: Thu, 27 Jul 2017 12:35:01 GMT
   Last-Modified: Wed, 04 Nov 2015 08:27:14 GMT
   Vary: User-Agent

2nd request (FAIL):
   Cache-Control: public, max-age=2678400, s-maxage=10
   Content-Length: 108420
   Content-Type: image/png
   Date: Mon, 26 Jun 2017 12:35:23 GMT
   Etag: W/"PSA-Tg6_ePFI2M"
   Expires: Thu, 27 Jul 2017 12:35:01 GMT
   Last-Modified: Wed, 04 Nov 2015 08:27:14 GMT
   Vary: User-Agent
   X-Content-Type-Options: nosniff

(This fails because X-Content-Type-Options: nosniff is present, but the response body is still a jpeg)
3rd request (OK):

   Accept-Ranges: bytes
   Cache-Control: max-age=2678358, public
   Connection: Keep-Alive
   Content-language: nl
   Content-Length: 92077
   Content-Type: image/jpeg
   Date: Mon, 26 Jun 2017 12:35:42 GMT
   Etag: W/"PSA-aj-dtCp9GrBh7"
   Expires: Thu, 27 Jul 2017 12:35:01 GMT
   X-Content-Type-Options: nosniff
   X-Original-Content-Length: 108420

The above observations are about the IPRO flow, but the issue also occurs with .pagespeed. urls when we also only apply cache extension.
I'm not sure that adding an option to completely disable emitting the nosniff header is ideal.
But in the case where IE fails to render the image, no changes have been applied to either the Content-Type header or the  response body.
Maybe the module should refrain from injecting the X-Content-Type-Options: nosniff header in that case, (if we can detect it).

IIUC the issue is that PageSpeed has transient bad responses in IPRO when the origin has an extension that does not match its content-type.  The problem goes away once PageSpeed has fully optimized the image.
What's confusing is that PageSpeed is responding with W/"PSA-* etag when the image is not yet optimized, though the input was cached.  I didn't think we would do that.
However, the problem is completely resolved by fixing the origin to specify the correct content-type (jpeg). Is that right? That might be the best resolution for this problem.
I think there is probably a potential fix in PageSpeed but I'm not sure what it should be.  It does get fixed in IPRO once we've optimized it.  For the cache-extension case, I wonder if we should sniff the content-type ourselves and just refuse to cache-extend if the sniffed content-type does not match the content-type header.  @morlovich WDYT?

Title was: X-Content-Type-Options: nosniff is automatically added when Pagespeed is enabled
Changing it to be more precise.

@jmarantz "However, the problem is completely resolved by fixing the origin to specify the correct content-type (jpeg). Is that right?"
I can confirm that.