Build failure on macOS 13

Looks like a plain build doesn't work due to segfaults in various binaries. I think it is related to this problem in the Sorbet Slack (https://sorbet-ruby.slack.com/archives/CFT8Y4909/p1671215417909629).

Has anyone succeeded in compiling Sorbet on the latest macos? It seems to be segfaulting when auto generating LSP files

Well, it’s actually not a compilation error. It segfaults when trying to run the generate lsp messages binary to autogen the LSP types. After trying to debug, it seemed like trying to print anything would always segfault, but we couldn’t figure out why

I responded in that thread with:

I tried building on Ventura 13.0.1 (22A400) and also got a segfault when this command runs:
bazel-out/host/bin/parser/parser/generate_diagnostics dclass

(via bazel build //main/lsp/... --verbose_failures --sandbox_debug with Sorbet commit 865fa620c160624a26619f77c7cb052b6db168d2)
On running lldb -- bazel-out/host/bin/parser/parser/generate_diagnostics dclass, it looks like the segfault is happening in dyld's initialization, before main even runs.
(lldb) thread backtrace
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000000000000
    frame #1: 0x0000000100024618 generate_diagnostics`std::__1::__stdinbuf<char>::imbue(std::__1::locale const&) + 40
    frame #2: 0x0000000100023df1 generate_diagnostics`std::__1::DoIOSInit::DoIOSInit() + 129
    frame #3: 0x00000001000253ec generate_diagnostics`_GLOBAL__I_000101 + 44
    frame #4: 0x000000020011c618 dyld`invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const + 172

That would explain why you couldn't print anything.
Some quick hacks by trying to set LC_ALL=C and LANG=C didn't seem to do anything.
At first glance, this seems like a libc++ bug. Looks like the binary is linking libc++ statically.
❯ otool -L bazel-out/host/bin/parser/parser/generate_diagnostics
bazel-out/host/bin/parser/parser/generate_diagnostics:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)

So another possibility is that we're statically linking a system-incompatible libc++.
I don't have time to look into this further at the moment, but I would typically expect libc++ to be linked dynamically on macOS as that would be compatible with the system. It might be worthwhile to look into the build configuration for that, there is a //tools/config:linkshared variable which controls this.

However, that's not the only issue. I'm seeing a similar issue with the scip-ruby build, I suspect because protoc is statically linking in a too old libc++.
ERROR: /Users/varun/Code/scip-ruby/proto/BUILD:9:17: ProtoCompile proto/Name.pb.h failed: (Segmentation fault): protoc failed: error executing command bazel-out/host/bin/external/com_google_protobuf/protoc '--cpp_out=bazel-out/darwin-fastbuild/bin' -I. proto/Name.proto

OK, so things are a little messy here. Ideally, we'd "just" submit a PR to Sorbet upstream with a bump to LLVM 14 or 15, and that would be the end of it (assuming that fixes the issue). LLVM 15 is less preferable because it also requires getting Sorbet to work natively as arm64 on macOS (the last LLVM release with x86_64 binaries for macOS is LLVM 14).
Sorbet is currently on LLVM 12, and picking up the toolchain from their own fork which is 106 commits behind upstream. So first that fork needs to be patched, then the version of LLVM needs to be bumped, and then we need to test if that fixes the issue on macOS.

Yep, the protoc issue is similar.
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000000000000
error: memory read failed for 0x0
Target 0: (protoc) stopped.
(lldb) thread backtrace
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000000000000
    frame #1: 0x000000010022cc88 protoc`std::__1::__stdinbuf<char>::imbue(std::__1::locale const&) + 40
    frame #2: 0x000000010022c461 protoc`std::__1::DoIOSInit::DoIOSInit() + 129
    frame #3: 0x000000010022da5c protoc`_GLOBAL__I_000101 + 44
    frame #4: 0x000000020082c618 dyld`invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const + 172
    frame #5: 0x000000020086bde9 dyld`invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const + 242

This confirms my suspicion to some extent: https://github.com/llvm/llvm-project/issues/59623

No longer an issue with Version 13.3.1 (a) (22E772610a)


Cleanup IREE runtime API definitions to have proper calling conventions

There's a few missing bits to get our API really C compatible; or at least there are some places that are not 32-bit (x86) compatible.
Example: mismatched calling conventions:
[build] D:\Dev\iree\iree\vm\stack_test.cc(200): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast
[build] D:\Dev\iree\iree\vm\stack_test.cc(223): error C2440: '=': cannot convert from 'void (__cdecl *)(void *)' to 'iree_vm_ref_destroy_t'

Example: struct as result:
[build] D:\Dev\iree\iree/vm/module_abi_cc.h(84): error C2440: '=': cannot convert from 'iree_string_view_t (__cdecl *)(void *)' to 'iree_string_view_t (__stdcall *)(void *)'
[build] D:\Dev\iree\iree/vm/module_abi_cc.h(84): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast

Doing a scrub of these errors (found when compiling for x86 with msvc) would be good for all targets, and have the side-effect of allowing us to build on x86 (which is required to use msvc asan). It may also be a good time to review IREE_API_EXPORT/etc to make sure they do what we want (they are mostly placeholders).

Sending to backlog due to the date of the issue - please reprioritize if needed.


Set Policy Configuration with API

Is there any way to create and mange branch policy other then the Web interface? We would like to be able to control our branches through the API so automation can handle setup and removal for us.
https://docs.microsoft.com/en-us/azure/devops/repos/git/branch-policies?view=azure-devops

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 354c468d-46b3-868e-d93d-538c0d6779f7
Version Independent ID: 9b38e43d-6640-4402-1498-d8bb07af5560
Content: Policy Configurations (Azure DevOps Git)
Content Source: docs-ref-autogen/azure-devops-server-5.0/git/Policy%20Configurations.yml
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

I am also attempting to do this, and would love to be able to remove an annoying manual step in our setup process.

You can make post requests against https://dev.azure.com/$Organization/$ProjectId/_apis/policy/configurations?api-version=3.2 - Check in your Developer Tools to see the data being posted from the web when you modify your policies to get an idea of the Post data you need.

Actually - https://docs.microsoft.com/en-us/rest/api/azure/devops/policy/configurations/create?view=azure-devops-rest-5.1

@goflores What work is this tracking? It seems like it's already been answered.

Configuration file for Azure Devops policies still lacks documentation of properties. The closest automation we have is creating a script that uses az cli to setup policies for repositories.


Add support for mm-dd-yyyy format

This PR adds support for date and timestamps which have their month, date and year part in mm-dd-yyyy format. I have borrowed the implementation fromslash_mdy_family function and have added appropriate tests.
I had a use case where I needed to support this scenario, so I thought of creating this PR in case maintainer(s) think the package can benefit from it.

Hi @ankita-shankar, thanks for submitting the PR, and sorry for the late reply. I will have a look today.

thanks so much @waltzofpearls!


Adding more supported regions and adaptor

Hi @ms-prkhad, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (prkhad). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


licenses: update copyright year

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Happy 2017 😊

Small note, this does not need to continuously be updated, we can just remove the ending year. To be valid, the notice requires only the first year.

That sounds a lot more sensible.

Agreed. The Homebrew Cask license can also now be removed given they are a single codebase.

Oh, I updated this. (Force pushed, so you wouldn't have got a notification.)

hurrah, thanks @alyssais.


[stable/redis] Slave do not connect to master if password is not used.

Describe the bug
When authentication is disabled, slaves are created in master mode and don't connect to master.
Version of Helm and Kubernetes:
kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-10T23:35:51Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.5", GitCommit:"2166946f41b36dea2c4626f90a77706f426cdea2", GitTreeState:"clean", BuildDate:"2019-03-25T15:19:22Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

helm version
Client: &version.Version{SemVer:"v2.12.1", GitCommit:"02a47c7249b1fc6d8fd3b94e6b4babf9d818144e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.1", GitCommit:"02a47c7249b1fc6d8fd3b94e6b4babf9d818144e", GitTreeState:"clean"}

Which chart:
stable/redis
What happened:
When usePassword: false is used, slaves don't connect to master.
What you expected to happen:
Slaves should connect to master.
How to reproduce it (as minimally and precisely as possible):
helm install stable/redis --set usePassword=false

kubectl run --namespace redis redis-client --rm --tty -i --restart='Never' \
   --image docker-hub.artifactory.playticorp.com/bitnami/redis:5.0.4 -- bash

I have no name!@redis-client:/$ redis-cli -h redis-slave info replication

and output is
# Replication
role:master
connected_slaves:0

Anything else we need to know:
I made a fix

Thanks for the PR. I just added the proper labels to get it tested and merged!


add test for utils/conf

We should merge utils/conf and utils/CacheConf, maybe even remove it in favor of a single conf. The additional layers makes it confusing.

History: CacheConf was originally extracted from one of Sindre's pkg which has it's own pkg now here.

Sure, I'll merge them

okay, not sure if I'm going to look to it anytime soon.
I'll close the other ticket, that's what I meant with "merge" 😇

I'm taking a look at this one.

🚀


Does not work with RD Gateway or with VMware Horizon View.

Does not work with RD Gateway or with VMware Horizon View. (VDI)  RD Gateway is a MS production along with NPS and NPS Extension for AzureMFA, so this is a supprise that it doesn't work and that MS doesn't spend time resolving this.  VDI already supports RADIUIS/NPS with OTP so not sure why it doesn't work in this scenario either.  Big fail!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d46abb2-6ad9-e86e-8808-b69ca11922d8
Version Independent ID: c4ccd9d6-13c7-6150-6a44-241bdf9b0982
Content: Use number matching in multifactor authentication (MFA) notifications (Preview) - Azure Active Directory
Content Source: articles/active-directory/authentication/how-to-mfa-number-match.md
Service: active-directory
Sub-service: authentication
GitHub Login: @mjsantani
Microsoft Alias: justinha

@trchosen1
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

#please-close


STL-1085 Go TP Reconnect

Previously, there were a number of problems with the shutdown and
reconnect code. Graceful shutdown would hang if the processor was
registering or if the validator never responded with an unregister
response. Reconnection could fail when a validator disconnected
because threads were blocked waiting for a response and would never
stop.
This commit solves these problems by using a ZMQ socket to signal
shutdown so it can be included in a poll with a receiving socket
and by aggresively closing sockets that worker threads depend on
so any send/receives will unblock and the worker threads can shutdown.

So you have a recommended way to test this?

@peterschwarz I started up a validator, rest api, go tp, and workload and messed around with killing the validator and go tp to make sure things continued to work.


assists with language input for issue directive of file indication of use

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
URL(s) with the issue:.
Please provide a link to the documentation entry, for example: https://keras.io/guides/customizing_what_happens_in_fit/
Description of issue (what needs to be changed):.
Correct links.
Is the link to the source code correct?
Parameters defined.
Are all parameters defined and formatted correctly?
Returns defined.
Are return values defined?
Raises listed and defined
Are the errors defined?
Usage example
Is there a usage example?
See the API guide: https://www.tensorflow.org/community/contribute/docs_ref on how to write testable usage examples.
Request visuals, if applicable.
Are there currently visuals? If not, will it clarify the content?
Submit a pull request?.
Are you planning to also submit a pull request to fix the issue? See the docs contributor guide:

This looks like a bot creating issues. Please close.

@fig666 Could you please provide more information on this issue?
Thanks!


Multiplatform docker builds

Take a look at the comments on this issue and see if we can get multiplatform releases working.
https://github.com/docker/build-push-action/issues/982

closing in favor of publishing images at a higer level, if at all


Minify state names v2

Alternative to #3701

Actually, it's not a problem with the env vars not getting passed. Tests are failing due to _var_set_state which is called during init_subclass hooks and writes the state names into the vars.

Actually, it's not a problem with the env vars not getting passed. Tests are failing due to _var_set_state which is called during init_subclass hooks and writes the state names into the vars/vardata.

@masenf do you have any idea how to solve this?

as for the _var_set_state, we probably could just save a reference to the state class and defer formatting of the state name until it's actually needed (_var_full_name_needs_state_prefix)

Thanks, i was thinking about that. Do you want me to migrate to state refs in this PR or in a followup?

i think you can do the refs in this PR, as long as it's not too invasive. We have a big Var refactor coming in the next week or so, that might conflict, but we can fix that up

Merged origin/main and made a few fixes on top to get the tests working for me locally.

Do we still want to get this in? I will rebase it if there is intention to review it

yes, we want to get it 🤞 thanks @benedikt-bartscher

Marking this as Draft until the conflict with main are solved.
(Yes we want that PR 👍 )

Hi @Lendemor and @masenf good to hear that you want this :rocket:
I resolved all the conflicts, we just need to coordinate the env vars with #4248 otherwise this PR is ready for review

Thanks for your work on this.
I believe we should work on getting #4248 merged first, then adapt this one to work with it.

Thanks for your work on this. I believe we should work on getting #4248 merged first, then adapt this one to work with it.

You are welcome. Sounds good, I will wait for a review of #4248 then

@Lendemor I based this onto #4248 and migrated the minify states env to the new env system to speed up the process

Thanks, @masenf! I checked the diff again, looks good to me

this patch doesn't seem to work anymore. the state names in context.js have a mix of full and minified names and i'm getting key errors left and right.
export const clientStorage = {"cookies": {"reflex___state____state.U.my_cookie": {"path": "/", "sameSite": "lax"}, "reflex___state____state.U.custom_cookie": {"name": "CustomNamedCookie", "path": "/", "maxAge": 3600, "sameSite": "lax"}}, "local_storage": {"reflex___state____state.U.my_local_storage": {"sync": false}, "reflex___state____state.B.data_raw": {"sync": false}}, "session_storage": {}}

export const main_state_name = "cQ"
export const update_vars_internal = "cu.update_vars_internal"
export const state_name = "cQ"

export const exception_state_name = "reflex___state____state.cs"

i tried this on the commit before i rebased, 7652fa18671e3d70f3efe25027ecffcdb012bae0

@masenf thanks for testing it again
It seems like the prod mode env is not set early enough when using the cli (reflex run --env prod)
Traceback (most recent call last):
  File "/.cache/pypoetry/virtualenvs/minified-state-names-IlpRchCp-py3.13/bin/reflex", line 5, in <module>
    from reflex.reflex import cli
  File "/reflex/reflex/reflex.py", line 18, in <module>
    from reflex.state import reset_disk_state_manager
  File "/reflex/reflex/state.py", line 2228, in <module>
    class State(BaseState):
    ...<3 lines>...
        is_hydrated: bool = False
  File "/.cache/pypoetry/virtualenvs/minified-state-names-IlpRchCp-py3.13/lib/python3.13/site-packages/pydantic/v1/main.py", line 282, in __new__
    cls = super().__new__(mcs, name, bases, new_namespace, **kwargs)
  File "<frozen abc>", line 106, in __new__
  File "/reflex/reflex/state.py", line 576, in __init_subclass__
    f.name: get_var_for_field(cls, f)
            ~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/reflex/reflex/state.py", line 277, in get_var_for_field
    field_name = format.format_state_name(cls.get_full_name()) + "." + f.name
                                          ~~~~~~~~~~~~~~~~~^^
  File "/reflex/reflex/state.py", line 951, in get_full_name
    name = cls.get_name()
  File "/reflex/reflex/state.py", line 935, in get_name
    raise Exception(
        f"{EnvironmentVariables.REFLEX_ENV_MODE.get()=}\n{EnvironmentVariables.REFLEX_MINIFY_STATES.get()=}"
    )
Exception: EnvironmentVariables.REFLEX_ENV_MODE.get()=<Env.DEV: 'dev'>
EnvironmentVariables.REFLEX_MINIFY_STATES.get()=False

@masenf I do not really like it but with https://github.com/reflex-dev/reflex/pull/3728/commits/6ce9471e6feb05b280623d7ad19e4d7dca0ccb6e it works

@masenf I fixed the ci
https://github.com/reflex-dev/reflex/actions/runs/11944696408/job/33296085097?pr=3728 seems like a temporary failure

Fixed conflicts and ci failure due to recent reflex-web changes as well
Should be ready to merge, let me know if anything else is needed or issues arise

Note to myself: consider porting EnvVar default_factory support to a separate PR for https://github.com/reflex-dev/reflex/pull/4430

If there is smth missing here please let me know

Just a friendly remainder, i am still interested in getting this one in. Please let me know if anything is missing or not working properly. I could also split it up into multiple PRs if wanted

Please let me know if anything is missing or not working properly.

I'm testing this with reflex-web workflow like follows
reflex export --frontend-only --no-zip

run a caddy webserver over .web/_static
reflex run --backend-only --env prod

The first thing I noticed is that reflex export does not set prod mode, so the resulting files are using unminified names against the backend which is expecting minified names and doesn't work.
If I set REFLEX_ENV_MODE=prod in the environment before the export, then it produces a static bundle that is able to talk to the minified state backend.
So I tried to update the code to set REFLEX_ENV_MODE=prod anytime an export is performed, this partially worked, but it seems that not all of the states got minified correctly (maybe set the var too late?). I'm doing some investigation on where things go wrong and have a small patch i'm planning to push to your branch when I get things working (wip https://github.com/reflex-dev/reflex/commit/34a5592a9b14b6a6b73b93ed20a1313c19bea2a4)

okay, i probed a little further... and it turns out that rxconfig.py in reflex-web imports stuff in the app, which eventually imports from reflex.state, which causes the in-built states to get defined and get non-shorted named before the REFLEX_ENV_MODE is set by the export command (config = get_config() is evaluated early in reflex/reflex.py). that in itself shouldn't be a huge issue, just sub-optimal... but the main_state_name seems to get inserted into context.js incorrectly

i tried out this patch
diff --git a/reflex/config.py b/reflex/config.py
index a882ce9d2..29ab353d9 100644
--- a/reflex/config.py
+++ b/reflex/config.py
@@ -3,10 +3,13 @@
 from __future__ import annotations

 import enum
+from functools import lru_cache
 import importlib
 import inspect
 import os
+import subprocess
 import sys
+import tempfile
 import threading
 import urllib.parse
 from importlib.util import find_spec
@@ -900,3 +903,28 @@ def get_config(reload: bool = False) -> Config:
             # Restore the original sys.path.
             sys.path.clear()
             sys.path.extend(sys_path)
+
+
+@lru_cache
+def get_config_safe() -> Config:
+    """Get the app config without introducing import side-effects.
+
+    Returns:
+        The app config.
+    """
+    with (
+        tempfile.NamedTemporaryFile(mode="w", encoding="utf-8") as script,
+        tempfile.NamedTemporaryFile() as config_json,
+    ):
+        script.write(f"""
+from pathlib import Path
+from reflex.config import get_config
+
+Path({config_json.name!r}).write_text(get_config().json())
+""")
+        script.flush()
+
+        subprocess.run(
+            [sys.executable, script.name],
+        )
+        return Config.parse_file(config_json.name)
diff --git a/reflex/custom_components/custom_components.py b/reflex/custom_components/custom_components.py
index 1406e37bc..92ee1a576 100644
--- a/reflex/custom_components/custom_components.py
+++ b/reflex/custom_components/custom_components.py
@@ -17,11 +17,11 @@ import typer
 from tomlkit.exceptions import TOMLKitError

 from reflex import constants
-from reflex.config import environment, get_config
+from reflex.config import environment, get_config_safe
 from reflex.constants import CustomComponents
 from reflex.utils import console

-config = get_config()
+config = get_config_safe()
 custom_components_cli = typer.Typer()

 POST_CUSTOM_COMPONENTS_GALLERY_ENDPOINT = (
diff --git a/reflex/reflex.py b/reflex/reflex.py
index 7b74071f3..3b5c561a5 100644
--- a/reflex/reflex.py
+++ b/reflex/reflex.py
@@ -15,7 +15,7 @@ from reflex_cli.utils import dependency
 from reflex_cli.v2.deployments import check_version, hosting_cli

 from reflex import constants
-from reflex.config import environment, get_config
+from reflex.config import environment, get_config, get_config_safe
 from reflex.custom_components.custom_components import custom_components_cli
 from reflex.utils import console, telemetry

@@ -29,8 +29,8 @@ except TypeError:
     # Fallback for older typer versions.
     cli = typer.Typer(add_completion=False)

-# Get the config.
-config = get_config()
+# Get the config via subprocess without triggering import side-effects.
+config = get_config_safe()

 def version(value: bool):

And while it does work for avoiding import side-effects before we have a chance to set the REFLEX_ENV_MODE appropriately, it has the unfortunate effect of slowing down reflex cli commands by over 0.5s on my M2 mac (and I assume much worse on windows and lower spec machines).
I don't think we can take that much of a slowdown on startup, there must be another way to implement this feature. Particularly, we need something that is more deterministic and doesn't depend on the import order, because I'm sure some innocuous looking change somewhere will regress this current approach in the future, and it doesn't seem like our current tests are able to effectively catch that.
We need an approach where the minified name is not tied so strongly to the initialization of the state class but can be turned on before compilation and still work. I think it would also be nice if either regular or minified name could be used against the same backend.

i tried adding _reset_name_cache and set_env_mode methods to facilitate re-naming and minifying already imported states when changing the REFLEX_ENV_MODE... but this also didn't seem to work because of how the backend runs in a separate process, it ends up getting mismatched between what is exported and the app doesn't work.
code i tried
diff --git a/reflex/reflex.py b/reflex/reflex.py
index 7b74071f3..1e4d57f28 100644
--- a/reflex/reflex.py
+++ b/reflex/reflex.py
@@ -18,6 +18,7 @@ from reflex import constants
 from reflex.config import environment, get_config
 from reflex.custom_components.custom_components import custom_components_cli
 from reflex.utils import console, telemetry
+from reflex.utils.exec import set_env_mode

 # Disable typer+rich integration for help panels
 typer.core.rich = None  # type: ignore
@@ -136,7 +137,7 @@ def _run(
     """Run the app in the given directory."""
     # Set env mode in the environment
     # This must be set before importing modules that contain rx.State subclasses
-    environment.REFLEX_ENV_MODE.set(env)
+    set_env_mode(env)

     from reflex.state import reset_disk_state_manager
     from reflex.utils import build, exec, prerequisites, processes
@@ -318,7 +319,7 @@ def export(
     """Export the app to a zip file."""
     # Set env mode in the environment
     # This must be set before importing modules that contain rx.State subclasses
-    environment.REFLEX_ENV_MODE.set(constants.Env.PROD)
+    set_env_mode(constants.Env.PROD)

     from reflex.utils import export as export_utils
     from reflex.utils import prerequisites
@@ -668,7 +669,7 @@ def deployv2(
     """Deploy the app to the Reflex hosting service."""
     # Set env mode in the environment
     # This must be set before importing modules that contain rx.State subclasses
-    environment.REFLEX_ENV_MODE.set(constants.Env.PROD)
+    set_env_mode(constants.Env.PROD)

     from reflex_cli.v2 import cli as hosting_cli
     from reflex_cli.v2.utils import dependency
diff --git a/reflex/state.py b/reflex/state.py
index c1e423f9e..c25ff745f 100644
--- a/reflex/state.py
+++ b/reflex/state.py
@@ -554,18 +554,23 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
         if parent_state is not None:
             cls.inherited_vars = parent_state.vars
             cls.inherited_backend_vars = parent_state.backend_vars
+        else:
+            # Track class_subclasses of the BaseState
+            parent_state = BaseState

-            # Check if another substate class with the same name has already been defined.
-            if cls.get_name() in set(
-                c.get_name() for c in parent_state.class_subclasses
-            ):
-                # This should not happen, since we have added module prefix to state names in #3214
-                raise StateValueError(
-                    f"The substate class '{cls.get_name()}' has been defined multiple times. "
-                    "Shadowing substate classes is not allowed."
-                )
-            # Track this new subclass in the parent state's subclasses set.
-            parent_state.class_subclasses.add(cls)
+        # Check if another substate class with the same name has already been defined.
+        #if not _reflex_internal_reinit and cls.get_name() in set(
+        if cls.get_name() in set(
+            c.get_name() for c in parent_state.class_subclasses
+        ):
+            breakpoint()
+            # This should not happen, since we have added module prefix to state names in #3214
+            raise StateValueError(
+                f"The substate class '{cls.get_name()}' has been defined multiple times. "
+                "Shadowing substate classes is not allowed."
+            )
+        # Track this new subclass in the parent state's subclasses set.
+        parent_state.class_subclasses.add(cls)

         # Get computed vars.
         computed_vars = cls._get_computed_vars()
@@ -970,6 +975,21 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
             name = ".".join((parent_state.get_full_name(), name))
         return name

+    @classmethod
+    def _reset_name_cache(cls):
+        """Reset `get_name` and `get_full_name` cache to use minified state names."""
+        subclasses = sorted(cls.class_subclasses, key=lambda x: x.__name__)
+        cls.get_name.cache_clear()
+        cls.get_full_name.cache_clear()
+        if cls is BaseState:
+            cls.class_subclasses.clear()
+        else:
+            cls.__init_subclass__()
+            print(f"REINIT {cls.__name__} ({cls.get_full_name()})")
+            print(minified_state_names)
+        for subcls in subclasses:
+            subcls._reset_name_cache()
+
     @classmethod
     @functools.lru_cache()
     def get_class_substate(cls, path: Sequence[str] | str) -> Type[BaseState]:
@@ -1658,6 +1678,8 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
             raise ValueError(
                 "The value of state cannot be None when processing an event."
             )
+        if name not in substate.event_handlers:
+            breakpoint()
         handler = substate.event_handlers[name]

         # For background tasks, proxy the state
diff --git a/reflex/utils/exec.py b/reflex/utils/exec.py
index 5291de095..56c16f712 100644
--- a/reflex/utils/exec.py
+++ b/reflex/utils/exec.py
@@ -497,6 +497,19 @@ def is_prod_mode() -> bool:
     return current_mode == constants.Env.PROD

+def set_env_mode(mode: constants.Env):
+    """Mark the app as running in dev or prod mode.
+
+    Args:
+        mode: The mode to set the app to.
+    """
+    environment.REFLEX_ENV_MODE.set(mode)
+    from reflex.state import BaseState
+
+    # Ensure that minified names are or are not used based on the mode.
+    BaseState._reset_name_cache()
+
+
 def is_frontend_only() -> bool:
     """Check if the app is running in frontend-only mode.

I think a proper solution for minifying the state names needs a more deterministic approach.
Either

hashing the state name into something smaller, or
writing out the minified mapping as a compilation artifact, so that the frontend and backend can always agree on what the minified names are.

Basically the following needs to work for reflex-web (and any app, but reflex-web seems especially finicky becausee its rxconfig.py ends up importing rx.State).
reflex export --frontend-only --no-zip
python3.12 -m http.server -d .web/_static 3000 &
reflex run --env prod --backend-only

So unfortunately this PR won't make it into our last release of 2024, but we do still want it, and think it's helpful for reducing network payload.

Thanks for all the details and ideas @masenf! I will work through your comments in the next days and try to find a better approach. Will keep you posted.

So unfortunately this PR won't make it into our last release of 2024, but we do still want it, and think it's helpful for reducing network payload.

Absolutely no problem, we obviously need to properly address all issues first.
Btw, it also reduces the redis key size a lot.

@masenf since this PR is quite old now I have solved conflicts many times. We could also drop the minify default for prod and only allow experimental support via REFLEX_MINIFY_STATES env which mitigates the issues you have reported. We could then implement a proper prod default in a followup. Wdyt?


Is there any way to run without apex?

Actually, it's my bad... apex can also be installed on RTX 3090...

I face the same problem
it is hard to compile the apex

@laulampaul Please use our provided docker.


Items game and csgo_english

All data are retrieved from items_game.txt and csgo_english.txt. These files use Valve's KeyValue text file format and have to be parsed with vdf-parser.

Where do you found these files in CS2 folder? I searched but it's 404 in the GameTracking-CSGO repository and I have CS2 installed and I don't found these files. Its inside a vdf?

Hi, the docs and the README are outdated. You can find items_game.txt and all the languages files here https://github.com/ByMykel/counter-strike-file-tracker/tree/main/static

Thanks a lot!!


why transaction cost on diff of position ?

Hi,
Debugging the code i noticed that the difference of the position is being used to apply commissions. Why is that?
If the position size is 0.5 and the next position is 0.7 you calculate the commission on 0.7-0.6=0.1 * commission and then you subtract this to the captured return. Shouldn't you calulcate it on the actual position itself so 0.5 * 0.1 and then substract from captured return?
Also the position used is the scaled one so it would even be smaller than the actual real position size.

Hi @makovez this is explained in the paper https://arxiv.org/pdf/2112.08534.pdf with the equation:
$R_{t+1}^\mathrm{TSMOM} = \frac{1}{N} \sum_{i=1}^{N} R_{t+1}^{(i)}, \quad R_{t+1}^{(i)} = z_t^{(i)}~\frac{\sigma_{\mathrm{tgt}}}{\sigma_t^{(i)}}~r_{t+1}^{(i)}$
The amount of volatility scaling is recalculated at each time step, therefore we introduce the $\sigma_\text{tgt}/\sigma_t^{(i)}$ term into the calculation to account for this and calculate the true position size. I hope this makes sense.

Ignoring the volatility scaling framework for now, lets say 0.5 represents 5 contracts and 0.6 represents 6 contract. If we change our position from 0.5 to 0.6 we only need to pay transaction costs for 1 contract, which is why we use the difference.

Ignoring the volatility scaling framework for now, lets say 0.5 represents 5 contracts and 0.6 represents 6 contract. If we change our position from 0.5 to 0.6 we only need to pay transaction costs for 1 contract, which is why we use the difference.

Ok now makes sense. Thanks for the clarification

Ignoring the volatility scaling framework for now, lets say 0.5 represents 5 contracts and 0.6 represents 6 contract. If we change our position from 0.5 to 0.6 we only need to pay transaction costs for 1 contract, which is why we use the difference.

But why you use the diff of scaled_position, I thought we should use the diff of actual position.


Paths support in tsconfig

Is your feature request related to a problem? Please describe.
Currently all imports in scaffold are in a shape of ../../server/..something, which makes it clunky and harder to read, in my opinion. I don't really know what others think on this point.
Describe the solution you'd like
Would you accept a PR changing the tsconfig.json in template and respective file to use something like @server/db/..etc instead of ../../server/..etc?
Describe alternatives you've considered
Keep as is if there is a good reason why paths aliases aren't worth the scaffold

I would dig a "src/" or "app/" path alias of some form. Had back luck w/ path aliasing and monorepos tho so not sure if I'd want it to be the default 🤔

We won't implement this, a person brought it up on the discord server and we had decided that if someone is unfamiliar with paths, they will be really confused.
If you want to, you can make the path alias on your own.
We could also make this a prompt but is this really required?

Appreciate your response guys!
I can see how this can be annoying in monorepos.
I would not call it a strong requirement, to me it was a small but improvement as I dislike these forests of empty slashes, so I don't think it deserves a CLI prompt just for this.
One can do a small refactor or fork it and make personal changes then :)
Thanks!

Yeah agreed, I'm closing this now

Sorry to necromance this but it's semi-related: what are your thoughts on having path aliases in the create-t3-app code? I'm asking because with the issue #116 I'm having to import files that are quite far away and that causes tons of ../../.. in imports.

@juliusmarminge sorry to ping you, not sure if you saw the above comment.
Since I think those aliases affect only the contributors and not the consumers maybe it's a different topic and the decision taken here does not apply? If you see fit I'll create a new issue to discuss how the aliases should be.

@juliusmarminge sorry to ping you, not sure if you saw the above comment.

Sorry didn't get notified of that.

Since I think those aliases affect only the contributors and not the consumers maybe it's a different topic and the decision taken here does not apply? If you see fit I'll create a new issue to discuss how the aliases should be.

Yeah do that and we can take it from there 👍


[Bug] Improvements on default values and timeout description

Customers were encountering the following error from the agent:
I encountered an error while trying to use the tool. This was the error: argument of type 'NoneType' is not iterable.
 Tool Firecrawl web scrape tool accepts these inputs: Firecrawl web scrape tool(url: 'string', page_options: 'object', extractor_options: 'object', timeout: 'integer') - Scrape webpages url using Firecrawl and return the contents url: 'Website URL', page_options: 'Options for page scraping', extractor_options: 'Options for data extraction', timeout: 'Timeout for the scraping operation'

I've added some default values and better description for timeout for fixing this issue.

great catch! <3


Variables set for generate random features

Arrays with all possible characters added. Generate random with [Math.floor(Math.random() * ____.length)];
Pseudo code added to outline and note possible solution for the function to generate a random password given the selected character types.
Links were added to the README to be included in the credits sections as sources that I used to write my code.

Current problem is that the generate random only runs once, picks a random element from allPossible array, and writes that element over the length of passLength. Need a function to ensure at least one of each selected character type is included.


Update Anthropic Client

Anthropic changed their python sdk - making this code line outdated.
https://github.com/RoguePenguins/gpt-engineer-anthropic/blob/33f5161babee31f311084000ff67d31eaa01fb26/gpt_engineer/ai.py#L46
—-
Would love to know if this might help - https://github.com/BerriAI/litellm
~Simple I/O library, that standardizes all the llm api calls to the OpenAI call
from litellm import completion

## set ENV variables
# ENV variables can be set in .env file, too. Example in .env.example
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["ANTHROPIC_API_KEY"] = "anthropic key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# anthropic call
response = completion("claude-v-2", messages)

cc: @AntonOsika @patillacode


Alter lake table drop partition

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

[FE PR Coverage Check]
:disappointed: fail : 12 / 19 (63.16%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
16
62.50%
[571, 4575, 4576, 4583, 4584, 4585]

:large_blue_circle:
com/starrocks/lake/ShardDeleter.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 31 / 49 (63.27%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
5
40.00%
[433, 434, 435]

:large_blue_circle:
com/starrocks/alter/Alter.java
2
4
50.00%
[385, 502]

:large_blue_circle:
com/starrocks/catalog/CatalogUtils.java
1
2
50.00%
[37]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
14
23
60.87%
[571, 1418, 1419, 1420, 1440, 1441, 1442, 4588, 4589]

:large_blue_circle:
com/starrocks/catalog/TempPartitions.java
6
8
75.00%
[88, 89]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
4
5
80.00%
[1618]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/lake/ShardDeleter.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 16 / 26 (61.54%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
5
40.00%
[433, 434, 435]

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
15
60.00%
[571, 1429, 1430, 1431, 4575, 4576]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 21 / 28 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
5
40.00%
[433, 434, 435]

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
14
17
82.35%
[571, 4575, 4576]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 17 / 24 (70.83%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
4
50.00%
[432, 433]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
14
71.43%
[571, 1436, 1437, 4574]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 17 / 24 (70.83%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
4
50.00%
[433, 434]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
14
71.43%
[574, 1439, 1440, 4515]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 17 / 22 (77.27%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
3
66.67%
[433]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
13
76.92%
[574, 1439, 4514]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 17 / 26 (65.38%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/Alter.java
1
2
50.00%
[385]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
17
58.82%
[574, 1439, 1449, 1455, 1457, 1458, 4519]

:large_blue_circle:
com/starrocks/catalog/CatalogRecycleBin.java
2
3
66.67%
[433]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]


✨ Support saving to Swift file format when creating a new file

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
After clicking File -> New to create a file, add an option to save it as a Swift file format

Describe alternatives you've considered
Save the corresponding file format according to the file extension name edited by the user
Additional context
.

I'll take this one.

@lukepistrol fix merged #900, can be closed?


[Packaging Request] ryujinx-ldn

Project description
Ryujinx's internet multiplayer build, even supporting interconnectivity with Switch Consoles.
Metadata

homepage URL: https://www.patreon.com/posts/introducing-ldn2-45268370
source URL: https://github.com/Ryujinx/Ryujinx
license: MIT
platforms: linux

Hi! I am one of the maintainers of the existing Ryujinx package and thought I'd give my two cents.
The source code for Ryujinx LDN is currently not released, because of that we would have to patchelf a precompiled binary which can be quite a pain with dotnet application if I recall correctly.
I've also talked to upstream devs about this version before, if i recall correctly they said it needs a rework and won't be releasing the source code before that's done.
I'm personally inclined to wait with packaging this build until that's done.

cc @06kellyjac

I agree with @IvarWithoutBones
The release tar.gz would need patching not only of the shared objects the binary is linked to but also the other libraries that are loaded at runtime like libSDL2.so & libsoundio.so, but if someone does get it working then cool
Also I wouldn't really call it MIT licensed until the code is actually public, I'd license it as unfree or unfreeRedistributable if we get permission

I agree with you guys, I was not aware that the source code was not public yet. Do I close or keep this issue open?

you can keep it open so it's visible if you don't mind having an issue open

I'll just keep this issue open, others can see the conversation we had and understand the reason this is not a native package yet.


Initial commit for cloud fp content

The cloud FP content.
Requires JDk11+ to build it.
Depends on some internal artifacts, EAP8 test release maven repo is to be unzipped in maven local cache.

@jmesnil , the EAP8 cloud FP content


Nearby: make list resize and display message when empty

Description
Make the list of nearby places resize up to its old size, depending on the content. Handle the empty case by displaying a message.
Fixes #3727
What changes did you make and why?

Made the list wrap-content and wrapped it in a transparent layout of fixed size (the old size).
Added a textview with a message to be displayed when the list is empty.

Tests performed
Tested betaDebug on Pixel XL with API level 29.
Screenshots
List at full size

List resized

Message displayed when list is empty

Codecov Report

Merging #3746 into master will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d687c3...0275a9b. Read the comment docs.

Codecov Report

Merging #3746 into master will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d687c3...beb7952. Read the comment docs.


[Storage] BlobBaseClient.DownloadAsync() throws XmlException if server response has no body

If the server response has no body, BlobBaseClient.DownloadAsync() tries to parse the emtpy stream as XML throws the following exception.  Instead, I think the client should check for empty body and throw a better exception.
Unhandled exception. System.Xml.XmlException: Root element is missing.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Load(Stream stream, LoadOptions options)
   at Azure.Storage.Blobs.BlobRestClient.Blob.DownloadAsync_CreateResponse(ClientDiagnostics clientDiagnostics, Response response)
   at Azure.Storage.Blobs.BlobRestClient.Blob.DownloadAsync(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Uri resourceUri, String version, String snapshot, Nullable`1 timeout, String range, String leaseId, Nullable`1 rangeGetContentHash, Nullable`1 rangeGetContentCRC64, String encryptionKey, String encryptionKeySha256, Nullable`1 encryptionAlgorithm, Nullable`1 ifModifiedSince, Nullable`1 ifUnmodifiedSince, Nullable`1 ifMatch, Nullable`1 ifNoneMatch, String requestId, Boolean async, String operationName, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.StartDownloadAsync(HttpRange range, BlobRequestConditions conditions, Boolean rangeGetContentHash, Int64 startOffset, Boolean async, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadInternal(HttpRange range, BlobRequestConditions conditions, Boolean rangeGetContentHash, Boolean async, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadAsync(HttpRange range, BlobRequestConditions conditions, Boolean rangeGetContentHash, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadAsync(CancellationToken cancellationToken)
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadAsync()

To repro, first start an HTTP server which sends an error response (say 404 to prevent retries) but no body:
new WebHostBuilder()
    .UseKestrel(options =>
    {
        options.Listen(IPAddress.Any, 5000);
    })
    .Configure(app => app.Run(context =>
    {
        Console.WriteLine("Received request");
        context.Response.StatusCode = 404;
        return Task.CompletedTask;
    }))
    .Build()
    .Run();

Then call a storage API like DownloadAsync() against this server:
BlobClient client = new BlobClient(new Uri("http://localhost:5000"));
Console.WriteLine("Calling DownloadAsync()...");
await client.DownloadAsync();
Console.WriteLine("Done");

That should be fixed in .NET generator.

Why should we do this?  What better exception should we throw when somebody mangles the response and doesn't meet the API contract?  What should we do if somebody MITMs a successful response and returns garbage XML?

@tg-msft, @kasobol-msft: If I recall correctly, I saw this exception in our live tests, because network issues can occasionally cause the client to receive headers but no body.  The repro steps above are an artificial way to simulate this occasional real-world scenario.
As a customer, if I got an XmlException when calling BlobClient.DownloadAsync() I would be fairly confused.  I'm not trying to do anything with XML, just Storage.  XML is an implementation detail that should be hidden from callers.
Maybe Storage should catch the XmlException and throw a different exception?

@tg-msft: I think the key point here is network issues alone can cause the client to see a mangled response.  It's not limited to the server failing to meet the API contract or a MITM attack.

What would you throw instead?  +@pakrym and @KrzysztofCwalina.  I can't think of something I'd prefer to throw over XmlException or JsonException if we receive a malformed body.

I think the key point here is network issues alone can cause the client to see a mangled response.

I don't think the HttpClient should allow successful reading of the body if the connection failed. If it does it's a bug.

Closing as we're not planning to do anything.  Please start a discussion if that's not satisfactory.


conv4d and higher dimension generalization

Are there some plans to include a 4D (and possibly higher dimension generalization) convolution op? Would be nice for doing 3D + time processing for example (for the 4D version).
Also, should something be done to offer the user the possibility to choose the shape of the kernel? For example allowing both the natural hyper cube kernel nodes location or a hyper thetrahedron location? Could have consequences on the computing power requested:
http://arxiv.org/pdf/1505.02890v2.pdf

@jerabaul29, generalizing convolutions to higher dimensions would be a great addition to TensorFlow, especially the GPU implementation. It will be great if someone in the community can take this up.

I think that this impact Eigen upstream

I'm no expert, but I think that Eigen supports tensors with arbitrary dimensions (albeit compilation gets really slow when it's more than 8 or something), and judging by the cuDNN manual, it can also take 5D Tensors (as in 3D+1D-color+1D-batchsize) or maybe even higher-dimensional.
The code in tensorflow/core/kernels/conv_ops.cc looks fairly generic, and might even be extensible to include higher-dimensional and GPU-accelerated convolutions.
I'm afraid it would require a serious amount of digging, though.

https://github.com/tensorflow/tensorflow/commit/6a187ccddaebb741ea77fc3201c6e36625f0aadb for an example of adding 3d convolutions, which uses cudnn Nd tensor interface and eigen for CPU.  Something similar could be done for conv4d, conv1d, etc.
If someone wants to tackle this, please let us know (cc @rewonc), since we now have conv2d and conv3d to provide a template for generalization.  We may still be missing something though, so no guarantees it will be straightforward.

@vrv Cool -- definitely seems like there's an opportunity to generalize a template. Will take a look and let you

Are there any news on this?
A 4D operation would be a really nice feature. Especially now that more and more people from other fields, where 4D (3D + time)  is the common use case (i.e. physics), are jumping in on deep learning.
Even if the n-dimensional generalization is not easily implementable, I think a separate conv4d would be very helpful.

I know it hasn't been long but is there any news on this ? We are currently using Caffe for 4D light-fields convolutions but would love to shift to tensorflow.

@vincentvanhoucke know anyone at Google that likes 4D convolutions?

@yaroslavvb not that I know of. I think it would be a perfectly good feature for a motivated contributor to pick up. Note that in my experience, treating the time dimension convolutionally is not always a good idea. It makes you throw a lot of parameters at a dimension that comparatively has a lot less semantic content than the spatial dimensions. YMMV.

Any word on this? I am working with volumetric spectral scans, and a 4D convolution would make a great tool for what I need.

I've plugged a conv4d equivalent together in python. It's just on python level, so most likely not the fastest, but if you want to start with that you can find it here:
https://github.com/mhuen/TFScripts
If you do decide to give it a try, let me know if you have any suggestions or if you come across any bugs as I haven't extensively tested it yet.

vote for the improvement too

I think this is unlikely to happen in a way that makes anyone happy, so closing.  All applications of 4D convs that I know of will almost certainly be forced to use special factorizations for efficiency.

nD convolutions can be realized by summing a sequence of (n-1)D convolutions. See here for an implementation of a 4D convolution layer using TensorFlow's conv3d layer. Details can be found in the docstring.

Any news on this? I am working on human action recognition and I could greatly benefit from 4D convolutions since my representation is in the format (x,y,z,t).

@josuerocha, is there any reason the 4D convolution linked above would not work for your use case?

@vrv It might be late, may I ask if there is any plan recently to add n-d conv? We are working on a pure math problem, already get it worked under 3d, but really need to give evidence that this can work on arbitary dimensional data to finish the paper. Or anyone else is working on this can work together? If not a very huge task, we may try do it by our team people……

Any news on this? If this is not available we will have to shift to another framework for one of our upcoming project, which would be a bit sad. If the 4D conv as a sum of 3D convs is the solution you want to keep for now, could this be added natively to tensorflow - nothing would prevent changes in the implementation later on anyways as long as the API choice is good?


Several fixes and improvements

Pull Request (PR) description
Various bug fixes, and improvements.
This Pull Request (PR) fixes the following issues
N/A

This change is

@ykuijs Hold off reviewing this one. I will bite the bullet and change its logic to use AzureAD instead

Codecov Report

Merging #107 into Dev will decrease coverage by 0.89%.
The diff coverage is 73.64%.

@@            Coverage Diff            @@
##              Dev     #107     +/-   ##
=========================================
- Coverage   89.23%   88.33%   -0.9%
=========================================
  Files          36       36
  Lines        2962     2949     -13
  Branches        4        4
=========================================
- Hits         2643     2605     -38
- Misses        315      340     +25
  Partials        4        4

Impacted Files
Coverage Δ

.../DSCResources/MSFT_SPOHubSite/MSFT_SPOHubSite.psm1
93.52% <100%> (+0.04%)
:arrow_up:

.../DSCResources/MSFT_ODSettings/MSFT_ODSettings.psm1
93.04% <100%> (ø)
:arrow_up:

...inAuditLogConfig/MSFT_O365AdminAuditLogConfig.psm1
89.36% <50%> (-3.98%)
:arrow_down:

...5DSC/DSCResources/MSFT_O365User/MSFT_O365User.psm1
92.52% <60%> (-1.66%)
:arrow_down:

...SC/DSCResources/MSFT_O365Group/MSFT_O365Group.psm1
72.04% <60%> (-20.09%)
:arrow_down:

...SC/DSCResources/MSFT_TeamsUser/MSFT_TeamsUser.psm1
93.1% <75%> (-1.54%)
:arrow_down:

...365DSC/DSCResources/MSFT_SPOSite/MSFT_SPOSite.psm1
85.06% <83.33%> (-0.12%)
:arrow_down:

...Resources/MSFT_TeamsChannel/MSFT_TeamsChannel.psm1
92.42% <83.33%> (-2.82%)
:arrow_down:

...SC/DSCResources/MSFT_TeamsTeam/MSFT_TeamsTeam.psm1
93.69% <90.24%> (-0.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9e0d6...61ded83. Read the comment docs.

@ykuijs all yours to review


Ability to resolve with nothing bazel6

Change Type (required)
Indicate the type of change your pull request is:

[ ] patch
[ ] minor
[ ] major

Does your PR have any documentation updates?

[ ] Updated docs
[ ] No Update needed
[ ] Unable to update docs

dummy PR


Have Maverick send MAVlink messages from SITL out, via telemetry radios

Ok, some background first:
I have installed Maverick on a Raspberry Pi 3 and have SITL running a instance of 'copter'. I can connect to SITL via TCP in Mission Planner and have it run virtual missions. As far as I can tell Mission Planner thinks it is a real copter. All good so far.
I am also in the process of building an antenna tracker, using Ardutracker and a Pixhawk, on a 3D printed pan/tilt platform I am designing. What I would like to have happen is that MAVLink messages would be sent to the Pixhawk on the tracker from the Raspberry Pi3 via telemetry radios. This would allow me to test the mechanical design of the tracker.
As discussed in the Ardupilot forum,  https://discuss.ardupilot.org/t/using-a-raspi3-to-run-sitl-can-it-be-done/24099  post 18, it appears that Maverick only receives MAVLink messages via telemetry radios.
S0, what I am asking as a feature is the ability for Maverick to be able to SEND MAVLink messages over a connected telemetry radio. I think having this feature would be a good addition to Maverick, it would allow users to use Maverick to more fully imitate a UAV and allow it to be used to test other components in the system via telemetry radios.
If I somehow missed where this can be accomplished with the existing feature set, please let me know.
Rusty

Interesting question.  Theoretically this can possibly be done at the moment thanks to mavlink routing by setting the usb as the IN device.  I think depending on the router you should still be able to connect to it and it will act as a 'sender'.  I'll test with a set of radios.
Alternatively, a separate serial endpoint option can be added.

BTW, if you had any interest we would love to have a tracker recipe in goodrobots - an easy to follow procedure to setup the hardware and software.  It's a model I see being a very popular deployment model for the upcoming maverick 2.0 release.

Following up.
I edited the localconfig.json (sp?) file and un commented the line the specified MAVPROXY as the proxy to use, did a "maverick configure" and a reboot and no change,, all the while the tracker was listening for a UAV on the telemetry radio. I then entered "mavproxy.py --out dev/tty/USB0"  and the tracker sprang to life, however I do not think it was receiving correct information, it was randomly pointing in many different directions, and I was seeing random characters in the terminal window from where I had issued the mavproxy.py command. I am going to try and debug with an actual UAV and see if the tracker is working correctly before I go further.

RE:  "Tracker Recipe"  Interested, but need more info...   What are you looking for ? I am currently designing/3D printing a tracker, using Ardutracker as the brains, I plan on documenting that build for my website/blog, and could share that??

Central logic support for outbound serial device added, and mavlink-router config template updated and tested.
Still have to add support for cmavnode and mavproxy.

re: tracker if you're interested come and have a chat in gitter: https://gitter.im/goodrobots/Lobby

Confirmed working with two raspberries and set of 3drv2 radios: on a raspberry pi 3, set sitl to forward mavlink out of usb/radio:
	"maverick_dev::sitl::mavlink_serialout": "/dev/ttyUSB0",
	"maverick_dev::sitl::mavlink_outbaud": 115200,

On raspberry pi zero with other radio, set to receive from usb:
	"maverick_fc::mavlink_input": "/dev/ttyUSB0", // Input source for mavlink proxy, how the Companion Computer connects to the Flight Controller
	"maverick_fc::mavlink_baud": "115200", // Input baud rate for UART connections


Error message

When I put https://data.gov.cz/ as a SPARQL endpoint (is is not a SPARLQ endpoint) nothing happens. In addition to progress (#31) there should be warning/dialog that not even the first query was executed. Now I need to open Developer console as the UI give me no information.

Better then before, I would lower the priority yet keep it in the list. As I need to read documentation in order to know the meaning of this.


Gwright99/extract scripts from githooks

Putting all the Python scripts in the .githooks folder was a super dumb idea (mine) which makes it much harder to extend / reuse this logic for related initiatives.
This PR does a few things:

Splits the Python scripts into their own top-level folder scripts and ties in a preliminary pytest implementation.
Adds some rudimentary VSCode configurations for Flake8, Black, and pytest.
Modified the Python FileHandler to RotatatingFileHandler to avoid infinite file growth.

Note: assets/src/python/get_access_token.py looks like it has changed significantly, but this is formatting only (due to the fact I enabled Black auto-formatting on save ...oops).

@schaluva -- this one is going to need eyes and some prodding to make sure I haven't missed anything (please).


Possible issue with parallel running

I think the line below may delete the database table containing the EN background check, so if running in parallel one of the processes could delete information already stored by another.
https://github.com/IQuOD/AutoQC/blob/0ef7ff9b659ffb5e5d11f726756185c80ebe4f15/qctests/EN_background_check.py#L201

You're right, that does delete the db table in question - but doesn't the loadParameters function only ever get called before we create the pool of worker processes? That was always the intention, but if this is causing problems then it must be sneaking in somewhere else...

Yes, you are right. I'll close the issue.


Pcap selection page

Description
Add a summary of the change and which issue is fixed, including motivation, context, dependencies, etc.
Checklist:

[ ] Code follows the style guidelines
[ ] Code commented in relevant places
[ ] Changes to necessary documentation made
[ ] Has test cases for code.

Tests Performed:

[ ] Upload data to Datastore
[ ] Retreive data from Datastore
[ ] Map Visualization
[ ] Network Map Visualization
[ ] List other manual test cases performed

Clicking the row sends a form to servlet which stores entity name as a session object.


Extend unit testing

Once we have more code to work with, write tests for model inference.
ideally, these tests can also run on GH Actions, e.g. by pulling the latest version of the dataset/model from Google Cloud Buckets. Since we now know how to authenticate the gcloud cli in Actions, this should be feasible.

For example, we could test the inference API by doing a simple curl:
curl -X 'POST'
'http://APIADRESSHERE/predict?input_data="[8000207.0%2C0%2C6%2C6%2C16%2C15%2C9%2C0%2C0%2C0%2C0%2C0%2C1%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C0%2C1%2C650%2C1]"'
-H 'accept: application/json'
-d ''

extended tests for predict_model, i.e. the inference with fastapi
also one test added to check model.pth exists after training
still missing are currently tests for the google cloud connection, i.e. loading the data and saving the model


Benri Blog Post

TBD's SSI-Service hosted by benri.io

💯 amazing stuff!

@angiejones the url is actually ok, but maybe the wording is bad:
➜  curl -X GET  https://ssi.benri.io/api/health
{"status":"OK"}

re: anchor text. Yep! no problem. Will change shortly.


publish images: amd64/arm64 images containing cli only

There was no prebuilt image available for multiple architectures, this provides an image from scratch only containing cilium-cli binary.
This ensures that the image can be used directly as a standalone solution or included within other containers
example dockerfile
FROM quay.io/cilium/cilium-cli:tag as cilium
FROM exampleimage
COPY --from=cilium /usr/local/bin/cilium /usr/local/bin/cilium ---
Fixes: #2755

As there are changes to github ci i think these steps need to run from this branch to check if it builds correctly

Thanks for the refactor, looks good to me except for one change.

Ah yes, I'll change that back

Thanks for the refactor, looks good to me except for one change.
@asauber I believe it is in order now, can you sign off the requested changes?

@michi-covalent Anything blocking this merge?

hi @leppeK thanks for the PR 👋 . a couple of things:

please resolve the conflict in Dockerfile.
this wouldn't work as is because there is no quay.io/cilium/cilium-cli repository right now, and i'm somewhat hesitant to introduce a new image repository for this purpose. could we use a different tag suffix (maybe something like -scratch) instead? that's what we do with https://quay.io/repository/cilium/cilium-ci?tab=tags. we push 2 additional images -race and -unstripped. the workflow is defined in https://github.com/cilium/cilium/blob/main/.github/workflows/build-images-ci.yaml.

cc @tklauser what do you think? 💭

If I understand this change correctly, we would be publishing these cli-only images on every PR and push to main. I think we should only publish these for releases. Or do you have a specific use case in mind where you'd need to publish these images on each PR/push?

I think it is okay to only do releases for these images so we'd only have stable/latest and release tags.


Fix top-n-distinct for cases where the group columns are a sub-set of the source

Summary of the changes / Why this improves CrateDB
TopNDistinct.outputs contained all outputs of the source instead of
the actual outputs of the operator. This led to ClassCastExceptions
on execution.
Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

@Mergifyio backports 4.1


IPv6 on localhost important

https://github.com/ansible-lockdown/RHEL8-CIS/blob/a0d2d830bb07c0a1ca5e1aaeb297ae180f1e5296/tasks/section_3/cis_3.1.x.yml#L16
Red Hat's solution 8709 to disable IPv6 mentions

# By default, we do not disable IPv6 on localhost, as it's important for multiple
# components.  If you want to disable it anyway, change the following
# value to 1.
net.ipv6.conf.lo.disable_ipv6 = 0

Feature request: make IPv6 on localhost a separate config item.

Yet even after disabling ipv6 alltogether with this role I still see:
[root@vm]# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:c0:ff:ee:c0:de brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic noprefixroute eth0
       valid_lft 796576sec preferred_lft 796576sec

[root@vm]# ss -tln
State        Recv-Q        Send-Q               Local Address:Port               Peer Address:Port       Process
LISTEN       0             128                        <IP_ADDRESS>:22                      <IP_ADDRESS>:*
LISTEN       0             128                           [::]:22                         [::]:*

There is no inet6 address, yet ssh seems to listen??
Adding this line to /etc/ssh/sshd_config will drop that socket listener:
AddressFamily inet

@bbaassssiiee
Thank you as always, i have added an optional setting in prelim for the June23_updates branch to set sshd accordingly if rhel8cis_ipv6_disable_sshd_inet6 and not rhel8cis_ipv6_required
Feel free to take a quick look an d see if that works.
Cheers
uk-bolly

I think rhel8cis_ipv6_required is irrelevant, I see rhel8cis_ipv6_disable_sshd_inet6 as a defense in depth measure.
The main issue is that IPv6 on localhost is important to multiple components according to Red Hat, so that deserves a variable too.

If you disable IPv6 on localhost, take care to remove or comment this entry in /etc/hosts:
::1         localhost

Thanks


Webstorm / IntellIJ generated commit message "Merge remote-tracking branch 'origin/master'" fails

IntellIJ / Webstorm auto generates a commit message when it sees new commits on the remote branch when pushing commits. You have the option to rebase or to merge. When merging, the message "Merge remote-tracking branch 'origin/master'" is generated but it fails the commitlint.
Expected Behavior
It shouldn't fail, but ignore the commit message
Current Behavior
Fails because it's not added to the ignore wildcards
Affected packages

[ ] cli
[x] core
[ ] prompt
[ ] config-angular

Possible Solution
Extend the regex of is-ignored to include the message above.

Executable
Version

commitlint --version
6.1.3

git --version
2.15.0.windows.1

node --version
8.9.4

Let's fix this by adding a new wildcard entry here: https://github.com/marionebl/commitlint/blob/master/%40commitlint/is-ignored/src/index.js#L18
PR welcome!

I have the same issue on BitBucket with a different pattern: Automatic merge from release/4.0 -> master. I made a PR

Fixed via https://github.com/marionebl/commitlint/commit/e9ea17fc40f5ccf4b6ca80a990b984fbb466dc47


Backtrack more aggressively when resolving

Resolving a dependency graph may involve quite a bit of backtracking to select
different versions of crates, but the previous implementation of resolution
would not backtrack enough.
Once a dependency is completely resolved it's possible that any number of
candidates for its transitive dependencies were left out of the resolution
process (e.g. we didn't hit them yet). These candidates were not previously used
for backtracking (because resolution overall of the dependency finished), but
this commit alters the implementation to instead consider these as candidates
for backtracking.
Architecturally this changes the code to CPS to pass around a finished
continuation to allow tweaking the behavior whenever a dependency successfully
resolves. The key change is then that whenever a candidate for a dependency is
activated, we ensure the recursive step for the rest of the graph happens as a
sub-call. This means that if anything in the recursive call fails (including
some previous up-the-stack resolution) we'll retry the next candidate.
Closes #1800

r? @wycats
(rust_highfive has picked a reviewer for you, use r? to override)

Hm, maybe don't r+ just yet, want to test out on Servo to make sure this doesn't blow any stacks. It'd be unfortunate to have to switch to an explicit stack...

Ok, I have overhauled this to include some more changes. This has evolved into a bit of a larger scale refactor of the resolution code, although most of the changes are just code movement. I can split out the literal code movement changes if it makes it easier to review. The other changes made are:

Many functions are now on impl Context directly.
Many functions are tagged #[inline(never)] to limit the stack size of the recursive activate and activate_deps functions.
Documentation has been added for the module as a whole as well as the performance tricks currently in play
The Rust snapshot version has been updated as its LLVM apparently has a few optimizations Cargo needs to get those smaller stacks.

r? @brson

:umbrella: The latest upstream changes (presumably #1812) made this pull request unmergeable. Please resolve the merge conflicts.

r=me

@bors: r=brson bcdb747

:hourglass: Testing commit bcdb747 with merge a10897c...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-64


.exceptionally not getting called if a state that is canceled throws a RuntimeException.

In this example:
   State s1 = new State("s1");
   State s2 = new State("s2");

    DependentPromise<String> promise = DependentPromise.from(
            CompletableTask.asyncOn(executorService)
    ).thenApplyAsync(
            (aVoid) -> longTask(...), true
    ).thenApplyAsync(
            (s) -> longTask(...), true
    ).exceptionally(
            (e) -> {
                System.out.println(e.getMessage());
                return null;
            }, true
    );

If I call promise.cancel() and lets say that longTask will throw a RuntimeException when it gets interrupted. Should exceptionally() get called since the task did not complete successfully?

lachinois,
No, it shouldn't be called. You cancel target stage so no transition happens. However, in the following example:
State s1 = new State("s1");
   State s2 = new State("s2");

    DependentPromise<String> execPromise = DependentPromise.from(
            CompletableTask.asyncOn(executorService)
    ).thenApplyAsync(
            (aVoid) -> longTask(...), true
    ).thenApplyAsync(
            (s) -> longTask(...), true
    );
    DependentPromise<?> errorPromise = execPromise;
   .exceptionally(
            (e) -> {
                System.out.println(e.getMessage());
                return null;
            }, true
    );
    execPromise.cancel(true);

...block inside exceptionally will be called with CompletionException wrapping CancellationException (execPromise is not resolved yet, obviously).

Humm... I was puzzled, because in the Javadoc of cancel, it states:
cancel():
if not already completed, completes this CompletableFuture with a CancellationException.
So in theory, the .exceptionally() should complete with a CancellationException and trigger itself at the same time?

No, this standard behavior -- either you cancel promise and have no trigger, or you cancel a previous promise in chain and have trigger fired. Please compare with standard CompletableFuture:
        CompletableFuture<?> f = CompletableFuture.runAsync(() -> {
           try {
               Thread.sleep(1000);
           } catch (final InterruptedException ex) {
               Thread.currentThread().interrupt();
           }
        });
        CompletableFuture<?> z = f.exceptionally(e -> {
            e.printStackTrace(System.out);
            return null;
        });
        System.out.println("Z is about to be cancelled...");
        z.cancel(true);
        System.out.println("Z is cancelled");
        if (null != System.out) {
            return;
        }

If you cancels z as in example above you see no stack trace. If you cancel f you have a stack trace.

Closing the issue while this is expected behavior.


Add target data

Adds target data from the latest release of NHSN hospital admission data

Ready for re-review @dylanhmorris
I changed starting date to reflect first full week of mandatory reporting period.
I will add GH action to update the data every week on a separate PR.


Consider adding ignore method to each type

I've found myself reaching many times for something like AsyncResult.ignore or AsyncResultOption.ignore to do the same thing that Async.Ignore does.
I've just been replacing it with AsyncResult.map (fun _ -> ()) in my code, but I thought it might be a useful addition to the library for when you want to use the do! syntax on a function and you don't care about the response.

Side note: Instead of AsyncResult.map (fun _ -> ()) you can do AsyncResult.map ignore.

Thanks, @CameronAavik for the suggestion. Yes, It'd be useful. Are you planning to send any pull request?

Yes, I'll make a PR later tonight for it.

Finished in #58


doc: add note about checkpatch during dev workflow

This is adding simple note to demonstrate usage of checkpatch during
dev workflow.
Signed-off-by: Sahid Orentino Ferdjaoui<EMAIL_ADDRESS>

I wonder if it would be worth making it part of make lint, to avoid the additional command (or having a different target that groups both)? thinking

I don't have hard thinking about having it part of make lint. The point of the change was to inform contributors (mostly new) that they can execute this before pushing their changes to avoid CI failing.


Experimental/mapper update

This is to include work done on improving search for overlapping intervals using Interval Trees (ENSCORESW-2337) and updating the Slice project/project_to_slice methods, and correspondingly the higher level mappers, to correctly return the coordinates of the projected bits of the source slice (ENSCORESW-2289).

Coverage increased (+0.1%) to 82.089% when pulling a61d88fa79c698e2c4335d31855e9b674359cb58 on experimental/mapper_update into 16541d2c837cac72056c1fdbc8091b167bfe3432 on master.

Some changes pending:

review the description of arguments for methods where the order of arguments has changed
rebase against master, we should not be getting all the copyright updates
ensure xref code returns comparable results with new tree implementation, see https://www.ebi.ac.uk/panda/jira/browse/ENSCORESW-2602?filter=14252

once this has been addressed, we can review the merge conflicts

@avullo What is the state of this pull-request? Are you happy that you've resolved all comments so far?

I've got to roll-back wrt some later updates concerning the RangeRegistry and re implement differently. Then I've got to address one last issue which has appeared recently.  I've discussed with Mag and we think it's better if I close this and make another one.

Thanks @avullo ! Closing - the trail of critique has gone cold.


Building etc. on other islands

add a command to enable flying and building on other players islands

done


New commit

👷 Deploy Preview for crpp-ai-oncology processing.

Name
Link

🔨 Latest commit
b4edfc4dbf902f1b32025e528a57c432d5169043

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology/deploys/638625385670c600095e05ff


Warning: findDOMNode is deprecated in StrictMode.

In my console, I received the following warning:
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputMaskChildrenWrapper which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
was able to resolve this warning by removing <React.StrictMode> from my index.tsx. However, I'm looking for suggestions or a fix that would allow me to keep using <React.StrictMode> without encountering this warning.
Does anyone have any suggestions or a solution to address this issue while still using React Strict Mode?
My component:

My packages:
react: ^18.2.0
react-dom: ^18.2.0
react-hook-form: ^7.47.0
react-input-mask: ^3.0.0-alpha.2
@types/react-input-mask: ^3.0.3

react-dom@19 does not support react-input-mask anymore because of this problem.
I tested @johanguse's suggestions and it works. Why not have it published in the official react-input-mask repository?


Default distribution comes without networking enabled

Bit of a catch-22, as I can't rebuild to enable networking, and I can't have networking without rebuilding.
Maybe having at least dhcpcd or dhclient will be good, or the networking.dhcpcd.enable = true; option as default?

This does not seem to be an issue on the latest release. Feel free to re-open or open a new issue if you encounter another problem


Compilation error with Kakao new version 3.5.0

There is a difference between the JDK being used to build the library vs the "target" it is set to. The best practice is to set the JDK to the most up to date to get compiler benefits. But the target is better to be set at a minimum level to increase compatibility. This is similar to libraries setting Android minSdk to 21 or 23. Most Kotlin libraries are set to 11.
I see in this PR from before that 2 things are updated together:

JDK that is used in the CI: https://github.com/KakaoCup/Kakao/pull/105/files#diff-1da7a27709d11ac16eef3de8e46ed10672b7b1d63a790ffbcbd23a94b19efdcbR24
JVM Target: https://github.com/KakaoCup/Kakao/pull/105/files#diff-367321b2f284ceade658bdabfb5640b75f96629be4f94f3a467f7753102a4c91R15

2nd one is not needed and it creates the below incompatibility.
Steps to reproduce:

Just update the version
Compile/assemble test build

Observed Results:
The following error is observed

e: ScreenExtensions.kt:33:12 Cannot inline bytecode built with JVM target 17 into bytecode that is being built with JVM target 11. Please specify proper '-jvm-target' option

Expected Results:
Compile just fine when the host app targets JVM 11

@tasomaniac unfortunately here is technical difference between minSdk and tooling versions. minSdk is supportive parameter, but keeping build tooling up to date is a technical debt in project.
https://developer.android.com/build/releases/gradle-plugin
Regarding to android gradle plugin documentation you follow this compatibility map

For Kakao we trying to maintain out debt and support all latest versions as we can, because migration between minor versions is much easier then from example Gradle 4 -> 8.
If you want to use latest library version you may migrate you project to the latest tooling set as well
We don't have plans to roll back to gradle 8.3 and Java 11

Maybe you got me wrong. I was giving an analogy. You can use all the latest tools in your project. You can even use JDK 21 (much newer than 11). But you don't have to change the target version. If you do change it, you force your users of the library to go up too. You can still use whatever Java version and Android version internally but keep the compatibility to a lower number. This is actually how most libraries do including Google's AndroidX project etc.

Sorry mate @tasomaniac I still didn't get a point what exactly you want to change without rolling back to previous tooling versions. Please raise a Pull Request with proposal changes.

@tasomaniac I've tried many other options to make it run with 11 java compatibility, unfortunately with no results

https://github.com/KakaoCup/Kakao/pull/128


[Prometheus] add storage api latency graphs

Motivation
add api latency graphs to grafana
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
n/a

1000000 is us, not ms.

remove it and do this:

create a "api_name" variable, like this:

and define widget like this:

and new widget will show up / disappear automatically when we add / remove new apis.

@bors-libra r=msmouse

:pushpin: Commit a58c2dd has been approved by msmouse

:hourglass: Testing commit a58c2dd5b2c99389fb9182dcabd2517da8967eaf with merge d74adad582e91a8966e47c1ccca9a47249f84343...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: msmouse
Pushing d74adad582e91a8966e47c1ccca9a47249f84343 to master...


Fix a react-unknown-props warning

The react-unknown-props warning occurs before withHandler's warning, so the test is failed.
   1. withHandlers-test › withHandlers warns if handler is not a higher-order function

  t.is(error.firstCall.args[0], 'withHandlers(): Expected a map of higher-order functions. Refer to ' + 'the docs for more info.')
                           |
                           "Warning: Unknown prop `foo` on <button> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop\n    in button (created by withHandlers(button))\n    in withHandlers(button) (created by Unknown)\n    in Unknown"

This is a quick fix for helping CI back to normal. There are still react-unknown-props warnings in other tests.

Thanks


Compatible with LowCardinality type data write

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Looks reasonable.
As I understand, the case is when you shard by a function of LowCardinality data type.
But there is lack of test and comment.

CREATE TABLE db.table_all ( id String ) ENGINE = Distributed(cluster1, db, table, sipHash64(id))
ALTER TABLE db.table_all MODIFY COLUMN id LowCardinality(String)
INSERT INTO db.table_all (id) VALUES ('123')
 DB::Exception: Sharding key expression does not evaluate to an integer type

The user uses ALTER to modify the field type to LowCardinality.
The function of type LowCardinality needs to be the same as the result of the function used before, otherwise the user needs to re-import the historical data, which seems to me to be the same as the effect of my modification.

Ok. Still waiting for a test and code comment.

The code does not compile.

Ok. Still waiting for a test and code comment.

Done.


None of the css files are working

I have been using this template for a project im working on. And the css wasn't working and a few days ago the css started working, like everything I changed actually starting showing. But today none of the css files are working again.  (I deleted everything out of all the css files and my page still showed all the css)
P.S. I was wondering which of the css files I need to use, because there are multiple files)
Thanks in advance,
I

I've been having problems too. It works fine with the files on my local machine, but not at all on my github hosted page

Same here. Forked the template, changed nothing and the css files are not loading, accessing directly gives 404 error, but I see them in the repo. So, so confusing!

I was reading on another templates issues and they figured it out. I changed the vendor folder name to lib then had to change all of the vendor instances to lib in the index file, that's it! Works perfectly again!

Wow, thanks a million, I thought I was getting crazy! Works perfectly.. almost. Still some bugs in the element inspector console, but at least the CSS works.

What sort of front end framework are you using to get this bug? I will be renaming all of the vendor folders in a future build, but I am just curious about where you're getting this bug.

Uh.. just hosting it here, on GitHub, I guess? I'm not really a framework-and-stuff savvy guy, I just followed the instructions for using the template on GH and that's all I can help you with. Thanks for the beautiful template, by the way!

After changing the folder name of the folder 'vendor', there are still some bugs. For example, the alignment is not correct and I can't see the navigation bar. What should I do?

It is imperative that you link the Bootstrap.css first, then the creative.css file, and then any other style sheet after that.
Order matters with stylesheets, so if you're using Gulp or Grunt, be sure to do your script in that order. If you're just hard-coding the stylesheet's into your html header, be sure they go from top to bottom in the order I just described.

In the next build vendor is going to be changed to lib so hopefully that will help moving into Bootstrap 4
I'm sure there will be conflicts with lib vs. vendor but it seems to me that lib is going to be the better choice moving forward.
Closing this for now.


instructions unclear for Job templates

This step fails unless fgrp-ffmpeg-input container exists in the storage account.  See Q&A issue. https://learn.microsoft.com/en-us/answers/questions/1064844/index.html

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aa4764ae-47a1-2764-98a1-b34f32c9e17e
Version Independent ID: 7e02c746-ab94-6845-936e-95396cf29738
Content: Run jobs end-to-end using templates - Azure Batch
Content Source: articles/batch/batch-cli-templates.md
Service: batch
GitHub Login: @harperche
Microsoft Alias: prkannap

@DerekHerman-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

@DerekHerman-MSFT
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@harperche
Can you please check and add your comments on this doc update request as applicable.

#reassign@alfpark

#unassign@alfpark
#please-close. We have already addressed this in another context. Should there be any other clarification with regards to the fgrp-ffmpeg-input job-template.


Implement Gouraud shading in using some linear gradients

I did that few years ago to export some 3D graphics:
http://gitweb.scilab.org/?p=scilab.git;a=blob;f=scilab/modules/scirenderer/src/org/scilab/forge/scirenderer/implementation/g2d/motor/DrawTools.java;h=c797704466bd4808a628ae3e0e7360122d21f156;hb=2797926fe5a3af91029ce4fc018ced0c286e6fe3#l52
the goal was to render some triangles with Gouraud shading.
It could be a way faster (and maybe nicer) to use that but we need check that's correct, it'd be a replacement for:
https://github.com/mozilla/pdf.js/blob/bf870bd2acc7eb3ddd64752522172651544e46c0/src/display/pattern_helper.js#L62
If you think it's useless to work on that, feel free to close this "issue".

Please see https://github.com/mozilla/pdf.js/wiki/Benchmarking-your-changes which outlines how to do benchmarking of e.g. rendering performance in the PDF.js library (you'd "only" have to find a couple of good test-cases to use).

First and last page of this file is a nice test case
http://www.math.ubc.ca/~cass/graphics/manual/pdf/ch14.pdf


Re-enable the ability for users to define custom operators

https://rescript-lang.org/blog/editor-support-custom-operators-and-more#custom-operators

That's huge!! Thank you @IwanKaramazow 😄

That's huge!! Thank you @IwanKaramazow 😄


Q29 alternate solution

fixes #87
provided alternate solution to Q29

Thanks.  the md/notebbok are now generated from exercises100.ktx. Could you modify your PR?

So, remove all changes from the files except  exercises100.ktx. Am I right?

Yes. Optonally, you can re-generate all the files and add them to the PR (there are some pending modifications I think).

@rougier Pl have look at new changes and let me know any changes required

Thanks !

@acharles7 Thanks, much appreciated !


Rename value set JSON Schema file

valueset.json is maybe not the clearest name for the JSON Schema file, so maybe rename it to DCC.ValueSets.schema.json?
In addition, it might be worthwhile considering moving all actual value set files to a sub dir. value-sets/ (or similar).

Given the current state of the EU DCC, I'm closing this issue.


Trim execution time of sanitizer and valgrind workflows

Apply the same change (truncating data files) to other runs executed as part of clang sanitizer and valgrind workflows.

Resolved with PR #118


Adding VSCode Workspace code to fixtures

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Lightning-CLI/21/rdkcentral/Lightning-CLI

Commit: 6e5a194b955899f83d104101c32247f4ca26707c

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: Better not to host vscode/app.code-workspace if not actually needed.

Commit: 6e5a194b955899f83d104101c32247f4ca26707c

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[iOS] [4.0] Export: Add a method to embed a framework

Fixes #41037
This PR restores previous behavior for add_ios_framework method in EditorPlugin, meaning only linkage mode for framework.
Additionally added a add_ios_embedded_framework method that allows to embed specified framework.

Thanks!


add MiniKF slack channel to community page

@RFMVasconcelos adding the Slack channel for MiniKF to the community page to make it easier for Kubeflow users to find help on MiniKF when they need it.
Did not want to place this at the top of the list so I placed it in alphabetical order by "MiniKF." Happy to label this as "MiniKF (Arrikto)" instead of "Arrikto MiniKF"

@berndverst @Jeffwan @RFMVasconcelos would you mind taking a look at this? I'd like to make sure community members can find there way to help with questions as they try out Kubeflow.

I believe this would make MiniKF the only distribution channel added to the list.

@RFMVasconcelos @shannonbradshaw as proposed in https://github.com/kubeflow/website/issues/2807, we are planning to remove the About / Community page and replace it with new pages that are more specific:

Kubeflow Slack: a page which describes (and provides an invite to) the official Kubeflow Slack
Kubeflow Mailing List: a page which describes (and links to) the kubeflow-dicsuss mailing list
Kubeflow Blog: a page which describes (and links to) the offical Kubeflow blog
Kubeflow Working Groups: a page which lists and describes the Kubeflow Working Groups

possibly links to the kubeflow/community pages
possibly include links to calendars for meetings

@Arhell please stop drive-by /lgtming PRs.

After https://github.com/kubeflow/website/pull/3007 the community page has been rewritten.
Furthermore, as there are no other distributions in the "called out" slack channels, I am closing this issue.
/close

@thesuperzapper please don't make unilateral choices such as closing a PR. A better approach, IMO, would be to ping signaling that you believe it would make sense to close and provide a last opportunity for some discussion.