flickering issue when scrolling with network image wrap inside material widget while having background color

Steps to Reproduce

Execute flutter run on the code sample
Whenever i wrap network image inside any material widget such as Physical modal Material with provided backround color, the background color would flicker on scroll. temprorary fix is to make colors.transparent. But i want have background color. and more ever  why this is happening
Currently working on linux but can also be seen with android.

Expected results: scroll   without flickring
Actual results:
https://user-images.githubusercontent.com/45158405/164726500-19e2e105-de37-443b-9f80-1e4d40fe06df.mp4

Code Sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black,
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: ListView.builder(
        itemBuilder: ((context, index) {
          return Padding(
            padding: const EdgeInsets.all(8.0),
            child: PhysicalModel(
              color: Colors.white,
              elevation: 20,
              child: Image.network(
                'https://images.pexels.com/photos/2409038/pexels-photo-2409038.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=1',
                fit: BoxFit.cover,
                height: 400,
                alignment: Alignment.topCenter,
              ),
            ),
          );
        }),
      ),
    );
  }
}

Logs

[sky@fedora hello]$ flutter run -d linux -v
[  +60 ms] executing: uname -m
[  +28 ms] Exit code 0 from: uname -m
[        ] x86_64
[   +5 ms] executing: [/home/sky/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +25 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] c860cba910319332564e1e9d470a17074c1f2dfd
[        ] executing: [/home/sky/flutter/] git tag --points-at c860cba910319332564e1e9d470a17074c1f2dfd
[  +12 ms] Exit code 0 from: git tag --points-at c860cba910319332564e1e9d470a17074c1f2dfd
[        ] 2.10.4
[   +8 ms] executing: [/home/sky/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/home/sky/flutter/] git ls-remote --get-url origin
[   +3 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +74 ms] executing: [/home/sky/flutter/] git rev-parse --abbrev-ref HEAD
[   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +49 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +64 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +130 ms] Skipping pub get: version match.
[  +77 ms] Generating
/home/sky/Music/hello/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +97 ms] Initializing file store
[   +8 ms] Skipping target: gen_localizations
[   +5 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs
have updated contents: /home/sky/Music/hello/.dart_tool/package_config_subset}
[  +21 ms] gen_dart_plugin_registrant: Complete
[        ] Skipping target: _composite
[   +1 ms] complete
[   +4 ms] Launching lib/main.dart on Linux in debug mode...
[   +4 ms] /home/sky/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
/home/sky/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root
/home/sky/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --incremental --target=flutter
--debugger-module-names --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill
/tmp/flutter_tools.GDDAGS/flutter_tool.ERSQYK/app.dill --packages
/home/sky/Music/hello/.dart_tool/package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false
--enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root --initialize-from-dill
build/c075001b96339384a97db4862b8ab8db.cache.dill.track.dill --enable-experiment=alternative-invalidation-strategy
[  +26 ms] Building Linux application...
[  +21 ms] <- compile package:hello/main.dart
[   +1 ms] executing: [build/linux/x64/debug/] cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug
-DFLUTTER_TARGET_PLATFORM=linux-x64 /home/sky/Music/hello/linux
[ +796 ms] -- Configuring done
[   +4 ms] -- Generating done
[   +9 ms] -- Build files have been written to: /home/sky/Music/hello/build/linux/x64/debug
[   +8 ms] executing: ninja -C build/linux/x64/debug install
[  +13 ms] ninja: Entering directory `build/linux/x64/debug'
[+13869 ms] [1/5] Generating /home/sky/Music/hello/linux/flutter/ephemeral/libflutter_linux_gtk.so,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_basic_message_channel.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_binary_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_binary_messenger.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_dart_project.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_engine.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_json_message_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_json_method_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_message_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_method_call.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_method_channel.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_method_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_method_response.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_plugin_registrar.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_plugin_registry.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_standard_message_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_standard_method_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_string_codec.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_value.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/fl_view.h,
/home/sky/Music/hello/linux/flutter/ephemeral/flutter_linux/flutter_linux.h, _phony_
[   +2 ms] [  +67 ms] executing: uname -m
[        ] [  +39 ms] Exit code 0 from: uname -m
[        ] [        ] x86_64
[        ] [   +5 ms] executing: [/home/sky/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [   +3 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [        ] c860cba910319332564e1e9d470a17074c1f2dfd
[        ] [        ] executing: [/home/sky/flutter/] git tag --points-at c860cba910319332564e1e9d470a17074c1f2dfd
[        ] [  +11 ms] Exit code 0 from: git tag --points-at c860cba910319332564e1e9d470a17074c1f2dfd
[        ] [        ] 2.10.4
[        ] [   +7 ms] executing: [/home/sky/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[        ] [   +3 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] [        ] origin/stable
[        ] [        ] executing: [/home/sky/flutter/] git ls-remote --get-url origin
[        ] [   +3 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] [        ] https://github.com/flutter/flutter.git
[        ] [  +50 ms] executing: [/home/sky/flutter/] git rev-parse --abbrev-ref HEAD
[        ] [   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] [        ] stable
[        ] [  +43 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [  +79 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [   +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[        ] [  +79 ms] Initializing file store
[        ] [   +5 ms] Done initializing file store
[        ] [  +47 ms] Skipping target: gen_localizations
[        ] [   +8 ms] Skipping target: gen_dart_plugin_registrant
[        ] [+1017 ms] Skipping target: unpack_linux
[        ] [ +445 ms] kernel_snapshot: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs
have updated contents: /home/sky/Music/hello/lib/main.dart}
[   +1 ms] [   +9 ms] /home/sky/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
/home/sky/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root
/home/sky/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --target=flutter
--no-print-incremental-dependencies -DFLUTTER_WEB_AUTO_DETECT=true -Ddart.vm.profile=false -Ddart.vm.product=false
--enable-asserts --track-widget-creation --packages /home/sky/Music/hello/.dart_tool/package_config.json
--output-dill /home/sky/Music/hello/.dart_tool/flutter_build/682a1cd66435675efa3a1bbe2ea6537f/app.dill --depfile
/home/sky/Music/hello/.dart_tool/flutter_build/682a1cd66435675efa3a1bbe2ea6537f/kernel_snapshot.d
package:hello/main.dart
[        ] [+8811 ms] kernel_snapshot: Complete
[        ] [+1111 ms] debug_bundle_linux-x64_assets: Starting due to {InvalidatedReasonKind.inputChanged: The
following inputs have updated contents:
/home/sky/Music/hello/.dart_tool/flutter_build/682a1cd66435675efa3a1bbe2ea6537f/app.dill}
[        ] [ +139 ms] debug_bundle_linux-x64_assets: Complete
[        ] [ +292 ms] Persisting file store
[        ] [   +4 ms] Done persisting file store
[        ] [   +4 ms] build succeeded.
[        ] [   +7 ms] "flutter assemble" took 12,084ms.
[        ] [ +255 ms] ensureAnalyticsSent: 251ms
[        ] [   +1 ms] Running shutdown hooks
[        ] [        ] Shutdown hooks complete
[        ] [        ] exiting with code 0
[+1744 ms] [2/5] Building CXX object CMakeFiles/hello.dir/flutter/generated_plugin_registrant.cc.o
[ +151 ms] [3/5] Building CXX object CMakeFiles/hello.dir/my_application.cc.o
[ +174 ms] [4/5] Linking CXX executable intermediates_do_not_run/hello
[        ] [4/5] Install the project...
[  +24 ms] -- Install configuration: "Debug"
[   +8 ms] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/hello
[  +25 ms] -- Set runtime path of "/home/sky/Music/hello/build/linux/x64/debug/bundle/hello" to "$ORIGIN/lib"
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/icudtl.dat
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/lib/libflutter_linux_gtk.so
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/kernel_blob.bin
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/packages
[        ] -- Installing:
/home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/packages/cupertino_icons
[        ] -- Installing:
/home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/packages/cupertino_icons/assets
[        ] -- Installing:
/home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/packages/cupertino_icons/assets/CupertinoIc
ons.ttf
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/fonts
[        ] -- Installing:
/home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/fonts/MaterialIcons-Regular.otf
[        ] -- Installing:
/home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/AssetManifest.json
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/NOTICES.Z
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/version.json
[        ] -- Installing: /home/sky/Music/hello/build/linux/x64/debug/bundle/data/flutter_assets/FontManifest.json
[   +9 ms] Building Linux application... (completed in 16.9s)
[+1953 ms] Observatory URL on device: http://<IP_ADDRESS>:45169/PFCux7VsXgQ=/
[   +9 ms] Caching compiled dill
[  +53 ms] Connecting to service protocol: http://<IP_ADDRESS>:45169/PFCux7VsXgQ=/
[ +126 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at
http://<IP_ADDRESS>:45169/PFCux7VsXgQ=/.
[  +66 ms] DDS is listening at http://<IP_ADDRESS>:45913/jOhCyGH7cGE=/.
[  +53 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:45169/PFCux7VsXgQ=/
[ +737 ms] DevFS: Creating new filesystem on the device (null)
[  +20 ms] DevFS: Created new filesystem on the device (file:///tmp/helloYQTCVO/hello/)
[   +3 ms] Updating assets
[  +97 ms] Syncing files to device Linux...
[   +1 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[        ] Processing bundle.
[   +1 ms] <- recompile package:hello/main.dart f5f2334c-f986-4c1f-8696-93a87d2716b5
[        ] <- f5f2334c-f986-4c1f-8696-93a87d2716b5
[   +1 ms] Bundle processing done.
[  +79 ms] Updating files.
[        ] DevFS: Sync finished
[   +1 ms] Syncing files to device Linux... (completed in 84ms)
[        ] Synced 0.0MB.
[   +1 ms] <- accept
[   +2 ms] Connected to _flutterView/0x1059ab0.
[   +2 ms] Flutter run key commands.
[   +1 ms] r Hot reload. 🔥🔥🔥
[   +1 ms] R Hot restart.
[        ] h List all available interactive commands.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] 💪 Running with sound null safety 💪
[   +1 ms] An Observatory debugger and profiler on Linux is available at: http://<IP_ADDRESS>:45913/jOhCyGH7cGE=/
[ +506 ms] The Flutter DevTools debugger and profiler on Linux is available at:
                    http://<IP_ADDRESS>:9101?uri=http://<IP_ADDRESS>:45913/jOhCyGH7cGE=/
[+37830 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +2 ms] DevFS: Deleting filesystem on the device (file:///tmp/helloYQTCVO/hello/)
[ +252 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +9 ms] "flutter run" took 59,171ms.
[ +254 ms] ensureAnalyticsSent: 251ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 0

[sky@fedora hello]$ flutter doctor -v
[✓] Flutter (Channel stable, 2.10.4, on Fedora Linux 36 (Workstation Edition Prerelease) 5.17.2-300.fc36.x86_64,
    locale en_US.UTF-8)
    • Flutter version 2.10.4 at /home/sky/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (4 weeks ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /home/sky/Android/Sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /home/sky/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 14.0.0 (Fedora 14.0.0-1.fc36)
    • cmake version 3.22.2
    • ninja version 1.10.2
    • pkg-config version 1.8.0

[✓] Android Studio (version 2021.1)
    • Android Studio at /home/sky/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin version 66.0.1
    • Dart plugin version 211.7811
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.66.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.38.1

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Fedora Linux 36 (Workstation Edition Prerelease)
      5.17.2-300.fc36.x86_64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 100.0.4896.88

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@Akaatsukhi
I think the flickering is occuring due to antialiasing and mapping from logical pixels to device pixels. There's an open issue for this which you can follow-up in for further updates. https://github.com/flutter/flutter/issues/14288.
See this similar issue and issue comment that was closed in favor of linked issue above. Closing this as a duplicate.


updating user Models and controller to get user_model_spec passing

Coverage increased (+17.69%) to 68.8% when pulling f28adaf7dc3bb153fcd080aa5a0285ed163e7ca5 on testing into b5d0df03c7e1528d9bb5ecef59bb895cb3079211 on development.


[tlul_adapter_sram] assertion issue

Hi Eunchan,
When I run fpv on spi_device and flash_ctrl, I found the assertion violation:
  `ASSERT(rvalidHighWhenRspFifoFull, rvalid_i |-> rspfifo_wready)

My sequence is to trigger a back to back read, and in the TL interface, set the tl_i.a_valid signal to low. So in tlul_adapater_sram, the weady signal is low.
However, rvalid_i signal seems to stay high for one more cycle, and triggers the assertion fail.
In u_memory_2p:
 a_rvalid_sram <= a_req_q & ~a_write_q;

Could you help check if there is any potential protocol concerns? If not, maybe we can consider relax this assertion?

Thanks @cindychip .
@tjaychen Looks like this is related to the increase of Outstanding by 1 in the request FIFO but not in the response FIFO inside tlul_adapter_sram to support back-to-back write. Should we increase the response FIFO also? or revise flash_phy to allow two Outstanding?

hmmm it does sound like maybe matching the rsp and reqfifo is the right thing to do.
@eunchan i didn't quite get your point about flashy_phy though, can you elaborate?

Close this issue as the PR merged and assertion error fixed.


Integration does not show up in HA after adding to HACS

I have added the integration to HACS, but it still does not show up in HA when I search for it. I probably did something trivially wrong, I just can't put my finger on it.

Hi, do you have the same issue like this one: https://github.com/FL550/dwd_weather/issues/41?

Hmm, this is weird, yesterday evening it did not show up in this list, I am certain of it:

Now it shows up this morning, without me even doing any additional restart or changing anything in HA.
I am really positive that I was clicking on the "add integration" button, unlike in #41 .
Anyway, this can be closed and sorry for wasting your time, I should have waited a day first.


Adsk Contrib - Harden test temp folder handling

Hardening the temp folder creation and deletion routines against file system errors in the CPU unit tests.

Thanks for fixing this, Cuneyt. I've merged this into the main repo. I needed to redo it because of a sign-off problem, probably related to me trying to make a PR from your branch. Then I merged a few additional PRs that were approved. Feel free to update the fork when it's convenient for you.  I've decided not to do a 2.3.3 release right now given that 2.4 is almost out and no one else has encountered the bug in the two years it's been there.  We may do a 2.3.3 as we get closer to 2.4.0.


Deploy using Netlify to get preview

Great, I will do this when we have implemented the home page.

I think I will need to do it as I am the one with the rights there

Okay! Thought anybody can deploy the website on Netlify by importing the project from Git repo since the GMN repo is public. What do you think?

No only the owner of the repository

It works now: see #13


Custom mesh as an optional field in route request

At some point, route requests will need to be able to be requested to be calculated using a specific mesh.

Done in d136849f1e0fa01644092834951988ab9944c258


Improve documentation

Fix links in XML doc comments
Avoid using code font for links in Markdown, as they're unclear
Include Pub/Sub example in README.md
Include Datastore querying example in README.md/index.md

LGTM


Schema fixes for new API

Correct some syntax (e.g. missing colons), type names (e.g. Integer -> Int) to make things
consistent.
Adds a root.gql with an empty Query (needed to be without {} like this
https://stackoverflow.com/questions/54322029/graphqljs-query-root-type-must-be-provided).

I know it's working because I can generate docs from it with npx docusaurus docs:generate:graphql and the linter is less angry (though not totally satisfied :joy: #3136
https://discord.com/channels/707636530424053791/1020603304583106560/1020961611445456946

LGTM shall we add the linter to CI until we find a definitive solution for this? So we don't forget to run the linter manually and commit broken schemas :pray:
Once this new API gets merged into main validation won't be necessary since it'll be done at compile time through Go's graphql parser. Linting will very likely still be needed, so adding the CI part here won't be useless. I see a cloak extension coming? :scream:


MAUI support

Hi
In the overview page I read IoT Core only support UWP apps.
Does this include MAUI or will MAUI be supported?

IoT Core only supports UWP apps.  IoT Core Services does not change that design.


Add support for parsing XYZ layers

This adds basic support for parsing XYZ layers.
Please review @terrestris/devs.

Thanks for the review!


Partial branches not detected in comprehensions

First of all, thank you for creating coverage.py—it is a fantastic tool, and I use it in all of my Python projects (at least those that have tests 😅).
Describe the bug
I discovered a situation in my code recently where I had a missing test that should have been flagged as a partial branch in my function. However, coverage.py did not flag the branch as partial, and I posited it was because I had written my function as a comprehension.

To confirm this theory, if I rewrite the above as multiline for loop, coverage.py correctly flags the partial branch:

To Reproduce

What version of Python are you using? 3.11.0
What version of coverage.py shows the problem? The output of coverage debug sys is helpful. A. See command output below
What versions of what packages do you have installed? The output of pip freeze is helpful. A. See requirements.txt in my demo repository (link below)
What code shows the problem?  Give us a specific commit of a specific repo that we can check out. If you've already worked around the problem, please provide a commit before that fix. A. See my demo repo below
What commands did you run?

Write some code using any type of comprehension that contains an if clause
Write a test where the result of the comprehension has the same length as the input iterable (meaning the if condition always evaluated to True during the test run)
Run coverage run -m unittest && coverage report && coverage html
Open htmlcov/index.html in your browser; if you view your source file, you'll see that coverage.py covered all lines in your function
Now, if you rewrite that list comprehension as a multiline for loop (i.e. appending to a list on each iteration), and rerun the command from step (4), you'll see that coverage.py does flag the partial branch (as expected)

Expected behavior
I expect that a partial branch in a comprehension (of any type) to be recognized/flagged by the coverage report.
Additional context
I've created a repository to demonstrate the issue, including code, tests, and instructions.
https://github.com/caleb531/coverage-partial-branch-bug
Debug output
Output of running coverage debug sys:
-- sys -------------------------------------------------------
               coverage_version: 6.5.0
                coverage_module: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.virtualenv/lib/python3.11/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                   configs_read: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.coveragerc
                    config_file: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.coveragerc
                config_contents: b'# Configuration for coverage.py (https://pypi.python.org/pypi/coverage)\n\n[run]\n# Enable branch coverage\nbranch = True\n\n[report]\n\n# Regexes for lines to exclude from consideration\nexclude_lines =\n\n    pragma: no cover\n\n    # Ignore non-runnable code\n    if __name__ == .__main__.:\n\n    pass\n\n# Only check coverage for source files\ninclude =\n    animal_utils.py\n'
                      data_file: -none-
                         python: 3.11.0 (main, Oct 26 2022, 19:06:18) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
                       platform: macOS-13.0.1-arm64-arm-64bit
                 implementation: CPython
                     executable: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.virtualenv/bin/python
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 16250
                            cwd: /Users/caleb/Repositories/personal/coverage-partial-branch-bug
                           path: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.virtualenv/bin
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>                                 /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.virtualenv/lib/python3.11/site-packages
                    environment: HOME = /Users/caleb
                                 PYTHONDONTWRITEBYTECODE = 1
                   command_line: /Users/caleb/Repositories/personal/coverage-partial-branch-bug/.virtualenv/bin/coverage debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.39.4
             sqlite3_temp_store: 0
        sqlite3_compile_options: ATOMIC_INTRINSICS=1, COMPILER=clang-14.0.0, DEFAULT_AUTOVACUUM,
                                 DEFAULT_CACHE_SIZE=-2000, DEFAULT_FILE_FORMAT=4,
                                 DEFAULT_JOURNAL_SIZE_LIMIT=-1, DEFAULT_MMAP_SIZE=0, DEFAULT_PAGE_SIZE=4096,
                                 DEFAULT_PCACHE_INITSZ=20, DEFAULT_RECURSIVE_TRIGGERS,
                                 DEFAULT_SECTOR_SIZE=4096, DEFAULT_SYNCHRONOUS=2,
                                 DEFAULT_WAL_AUTOCHECKPOINT=1000, DEFAULT_WAL_SYNCHRONOUS=2,
                                 DEFAULT_WORKER_THREADS=0, ENABLE_COLUMN_METADATA, ENABLE_FTS3,
                                 ENABLE_FTS3_PARENTHESIS, ENABLE_FTS4, ENABLE_FTS5, ENABLE_GEOPOLY,
                                 ENABLE_MATH_FUNCTIONS, ENABLE_PREUPDATE_HOOK, ENABLE_RTREE, ENABLE_SESSION,
                                 MALLOC_SOFT_LIMIT=1024, MAX_ATTACHED=10, MAX_COLUMN=2000,
                                 MAX_COMPOUND_SELECT=500, MAX_DEFAULT_PAGE_SIZE=8192, MAX_EXPR_DEPTH=1000,
                                 MAX_FUNCTION_ARG=127, MAX_LENGTH=1000000000, MAX_LIKE_PATTERN_LENGTH=50000,
                                 MAX_MMAP_SIZE=0x7fff0000, MAX_PAGE_COUNT=1073741823, MAX_PAGE_SIZE=65536,
                                 MAX_SQL_LENGTH=1000000000, MAX_TRIGGER_DEPTH=1000,
                                 MAX_VARIABLE_NUMBER=250000, MAX_VDBE_OP=250000000, MAX_WORKER_THREADS=8,
                                 MUTEX_PTHREADS, SYSTEM_MALLOC, TEMP_STORE=1, THREADSAFE=1

Hey @nedbat I would appreciate your thoughts on this.
I'm also seeing this behaviour on a project using Python 3.10.13 with Coverage.py 7.3.1 on debian bullseye
For anyone else coming to this, it's noted in the version 7.2.6 release notes that:

Python 3.12 beta 1 now inlines comprehensions. Previously they were compiled as invisible functions and coverage.py would warn you if they weren't completely executed. This no longer happens under Python 3.12.

So I am assuming it is indeed expected behaviour that comprehensions should be flagged as uncovered correctly in earlier versions of Python?


Link banner improvements

[ ] Add more top margin
[ ] Don’t wrap spoilers
[ ] Wrap themes differently

Done, done, and done


HostScaling group using selectors

Host scaling using selectors.

Create a host say dev1 and add a unique label to it foo=bar.
All hosts with label foo=bar will fall under the same HostScalingGroup. While adding new hosts, one of the hosts with this label will be used for cloning
Create a webhook to scale hosts from scaling group with label foo=bar.  Creation fails if no hosts are found with that label.
In Execute, get all hosts sorted in descending order of created time. Find all hosts with label foo=bar. Number of such hosts is the length of the HostScalingGroup. If scaling up, consider the least recently created host with that label as the base host. Then from the HostScalingGroup, find the first host (most recently created) that matches base host prefix. Since it is the most recently created one, use its suffix to calculate suffix for the next clone host. Add the selector label foo=bar to this clone. Create as many clones as specified by the amount.
If scaling down, among all hosts sorted by created time, get the amount number of most recently or least recently created hosts (whichever option is given in the webhook), and deactivate and delete them.
Irrespective of min given by the user, scaling below 1 host in HostScalingGroup is not allowed.

Why selector labels would help:

If we use a host ID to create webhook, and accidentally delete this host, then no webhooks for it will work. But using a label, we can keep using the webhooks without any restrictions on which hosts to delete, since we won't allow scaling below 1 for any group.
All hosts with the label fall in same group. So if I have host dev1 and its clones, and I manually created some host say dev12, which I don't want to get deleted, then since dev12 won't have the selector label, it will be excluded from the group and not get affected.
This also separates different scaling groups.

https://github.com/rancher/rancher/issues/7713

@mrajashree I just learned that we have an api resource that will deactivate and remove a host in one call. It is a externalHostEvent. Here's a screenshot of it in our API:

We should use this instead of calling deactviate and then remove

LGTM


Add proposed syntax highlighting types

Adds types for https://github.com/microsoft/vscode-languageserver-node/pull/367
I used this to implement syntactic highlighting in https://github.com/ul/kak-lsp
It also adds the base64 and byteorder crates to parse the semantic tokens.
The kak-lsp client has been tested with clangd

byteorder crate has been removed, and ive switched to using the Base64Display struct for encoding.


python3Packages.langchain-openai: init at 0.1.17

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build python3Packages.langchain-core python3Packages.langchain-openai

@ofborg build python311Packages.langchain-core python311Packages.langchain-openai

Changes that still need to happen:

Review the files where you updated the hashes and make sure you also updated the checkout refs. (They should only be langchain-core== for the langchain-core file. Otherwise, use the name of the thing you're building.)
You're going to run into ModuleNotFound on langchain-standard-tests. I'm currently banging my head on that -- do we add libs/standard-tests to the module search path? Do we build it as a subpackage (but not put into the nix cache)?

1. Review the files where you updated the hashes and make sure you also updated the checkout refs. (They should only be `langchain-core==` for the langchain-core file. Otherwise, use the name of the thing you're building.)

I think this is what I did and fixed.

2. You're going to run into `ModuleNotFound` on [langchain-standard-tests](https://github.com/langchain-ai/langchain/tree/master/libs/standard-tests). I'm currently banging my head on that -- do we add `libs/standard-tests` to the module search path? Do we build it as a subpackage (but not put into the nix cache)?

I fixed that too in a preConfigure flag.

I fixed that too in a preConfigure hook.

Clever. TIL.
P.S. Closes #328033

langchain-community is still checking out langchain-core.
Also, if you look at #328033 we also need to roll back a couple of version numbers in other files (and fix checkout paths).

langchain-community is still checking out langchain-core.

Yes, on purpose. There's no tag for langchain-community... https://github.com/langchain-ai/langchain/tags

There is in the releases: https://github.com/langchain-ai/langchain/releases/tag/langchain-community%3D%3D0.2.7

Woops ! Nice one. I fixed it in this PR too.

Apologies for how many loops we're performing.
If you run nix-build -A python312Packages.langchain-community you'll see that the checkout fails and falls back on langchain==0.2.9.
I had to look back in the commit history to find the correct fix:
    rev = "langchain-community==${version}";
    hash = "sha256-r0YSJkYPcwjHyw1xST5Zrgg9USjN9GOsvhV97imSFCQ=";

There was a broad change a month ago that started checking out refs/tags/langchain-community==... and that was the start of the breakage.
I tested my suggestion and it builds and checks properly. (Now if I only could figure out suggesting changes in a PR...)

Apologies for how many loops we're performing.
If you run nix-build -A python312Packages.langchain-community you'll see that the checkout fails and falls back on langchain==0.2.9.
I had to look back in the commit history to find the correct fix:
    rev = "langchain-community==${version}";
    hash = "sha256-r0YSJkYPcwjHyw1xST5Zrgg9USjN9GOsvhV97imSFCQ=";

There was a broad change a month ago that started checking out refs/tags/langchain-community==... and that was the start of the breakage.
I tested my suggestion and it builds and checks properly. (Now if I only could figure out suggesting changes in a PR...)

But isn't all of this fixed in https://github.com/NixOS/nixpkgs/pull/328207/commits/0d32e0b76ab441c0b797fc035950824cd068cc88 ?

@ofborg build python3Packages.langchain-core python3Packages.langchain-openai python3Packages.langchain-community
@ofborg build python311Packages.langchain-core python311Packages.langchain-openai python311Packages.langchain-community

But isn't all of this fixed in 0d32e0b ?

These do show up in the tags, so yes that should do it. I'm checking now by building each piece individually.

Result of nixpkgs-review pr 328207 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

28 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

Error when testing on Darwin: Langchain-core fails testing at test_queue_for_streaming_via_sync_call and test_same_event_loop due to the test comparing execution time with magic values. Suggest skipping.
2.

Result of nixpkgs-review pr 328207 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

28 packages failed to build:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

I'm running a final nixpkgs-review on Linux and Darwin. Once those post, I'll approve.

OK I just pushed some other changes, can you please review those as well ? I will stop now adding stuff :)

Result of nixpkgs-review pr 328207 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

36 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

I just fixed langchain-text-splitters too.

Result of nixpkgs-review pr 328207 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

40 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

I just fixed langchain-text-splitters too, so your ticket can be completely done.

 Can you edit your description to match what you've done and add Closes #328033?
(Had to restart Darwin for some reason. It's nearly done with the review.)

I just fixed langchain-text-splitters too, so your ticket can be completely done.

 Can you edit your description to match what you've done and add Closes #328033?
(Had to restart Darwin for some reason. It's nearly done with the review.)

Done. The related issue will be automatically closed when this PR will be merged. Hopefully asap, I need it at work!

Result of nixpkgs-review pr 328207 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

40 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

@SuperSandro2000 Your changes were made. Can you mark as resolved? (Thanks!)

Planning to self merge this at lunchtime (UTC, 10:00a). Hurry for the reviews :)

Result of nixpkgs-review pr 328207 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

40 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

Result of nixpkgs-review pr 328207 run on aarch64-linux 1

8 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist

34 packages built:

pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

Result of nixpkgs-review pr 328207 run on x86_64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

6 packages failed to build:

open-webui
open-webui.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist

34 packages built:

pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

Result of nixpkgs-review pr 328207 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

18 packages failed to build:

python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist

22 packages built:

open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist

@ofborg build python3Packages.langchain-openai python3Packages.langchain-mongodb python3Packages.langchain-huggingface python3Packages.langchain-azure-dynamic-sessions python3Packages.langchain-text-splitters python3Packages.langchain-chroma python3Packages.langchain-community
@ofborg build python311Packages.langchain-openai python311Packages.langchain-mongodb python311Packages.langchain-huggingface python311Packages.langchain-azure-dynamic-sessions python311Packages.langchain-text-splitters python311Packages.langchain-chroma python311Packages.langchain-community

@ofborg build python3Packages.langchain-openai python3Packages.langchain-mongodb python3Packages.langchain-huggingface python3Packages.langchain-azure-dynamic-sessions python3Packages.langchain-text-splitters python3Packages.langchain-chroma python3Packages.langchain-community python3Packages.langchain python3Packages.langchain-core
@ofborg build python311Packages.langchain-openai python311Packages.langchain-mongodb python311Packages.langchain-huggingface python311Packages.langchain-azure-dynamic-sessions python311Packages.langchain-text-splitters python311Packages.langchain-chroma python311Packages.langchain-community python311Packages.langchain python311Packages.langchain-core


⚠ UdeS website (prod) has degraded performance

In 7a495ce, UdeS website (prod) (https://www.usherbrooke.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1855 ms

Resolved: UdeS website (prod) performance has improved in 65bd7a4.


traning time

Hi. when I train fast rcnn with the MobileNet, I have found that the traning time is very long.
It takes 90sec every 20 iteration while  the ResNet only takes 17sec.
Is it normal?
how to speed up?
my gpu is gtx1080

training mobilenet with caffe is very slow, perhaps as slow as training resnet with 80-100 layers.
you can implement channel-wise conv by yourself for speedup.

thanks for your answer


pkg-config: prepend added flags

The go toolchain calls pkg-config using "--" to separate flags and packages. For example:
pkg-config --cflags -- zlib
This breaks if addFlags are appended. This commit therefore prepends the addFlags to the command.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc @vcunat if something around this breaks

I wonder if this is too intrusive for backporting to stable.

I am not sure of the criteria around backporting. At work I'm using an overlay on top of stable with this change to enable go builds with CGO_ENABLED to work correctly with pkg-config. It would be nice to have it in stable if possible, but it does feel like it would cause many things to be rebuilt :)

The rebuilds are not an issue (they'll only delay getting to channels).  I personally just don't have much confidence about the probability that this change of order could also break someone else's setup.

Ah right. The addFlags was added in https://github.com/NixOS/nixpkgs/commit/801078806b8664c8c5aa90587dcabf8b285e9269, with meson being the target at that time.

The rebuilds are not an issue (they'll only delay getting to channels). I personally just don't have much confidence about the probability that this change of order could also break someone else's setup.

Also backporting should not break packages and require time from us fixing them.

As the author of the original addFlags mechanism, I think this change should be fine to backport — perhaps important to note that addFlags is only used with static builds. But if it's of unclear impact it's the release managers' call, not mine. :)

I revisited this, and I agree it seems safe enough.


Build Warning

Thanks for updating the test suite. There is currently a build warning:
Running 1 test suite...class-test.js: `MyComponent4` was skipped because of invalid field(s) `foo` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.

This is actually expected. It is a little unfortunate how we print messages from tests given the parallel nature of jest. This log is coming from the class transform and only means that a class was (correctly) skipped. The test should probably spy on console.log and not actually print this :)


Remove Extra Paragraph Tag from Lesson Section Index Page

Overview
Removes extra <p> tag in the lessons index page. This was causing an HTML validation error in Rocket Validator.
Closes #128

Thanks @kinson!


Sentiment slider

Codecov Report

Merging #1 into master will decrease coverage by 0.33%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   96.87%   96.53%   -0.34%
==========================================
  Files           9        9
  Lines         256      260       +4
==========================================
+ Hits          248      251       +3
- Misses          8        9       +1

Impacted Files
Coverage Δ

sentiment/web/views.py
98.92% <75.00%> (-1.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b0f3e...0769c22. Read the comment docs.


Add Java discovery MVVM scaffold

Wow, this change was an immense amount of work.

Add a new SampleConfig class that contains an easy to traverse
heirarchy of discovery types.
Add a JSON based override mechanism that can be used to override any
field within the SampleConfig or it's children.
Support name collisions by storing computed names in a symbol table as
they are generated.
Refactor the Java discovery snippet to handle exceptions, and split
out service generation code to facilitate alternative auth
boilerplate.

Okay, @garrettjonesgoogle I've moved all type name generation logic into the ApiaryConfigToSampleConfigConverter where type name generation is facilitated by TypeNameGenerator and JavaTypeNameGenerator

I'm doing some last passes to clean up sections of code here and there and adding more elaboration to docstrings.
Things to do:

Include a test that makes use of the overrides functionality
Clean up
Things done:
Everything else

Otherwise, please begin the review - If we can start with structural comments first, and nitpicks in phase 2 that will help me keep things straight :)

The PR-based approval isn't an LGTM yet - I'm still getting used to this new flow.

LGTM (assuming tests pass)

Can you suggest a logical order to review these files? (Esp for someone who hasn't coded this MVVM.)

I've added two files:
test/java/com/google/api/codegen/testdata/discoveries/adexchangebuyer.v1.4.json.overrides
test/java/com/google/api/codegen/testdata/discoveries/java/java_adexchangebuyer.v1.4.json
This demonstrates the overrides file, it's test, and also the format of the client.

Okay, commits added, sorry about that

Current coverage is 81.01% (diff: 87.50%)

Merging #476 into master will decrease coverage by 1.82%

@@             master       #476   diff @@
==========================================
  Files           203        220    +17
  Lines          7721       8139   +418
  Methods           0          0
  Messages          0          0
  Branches       1019       1067    +48
==========================================
+ Hits           6396       6594   +198
- Misses         1033       1247   +214
- Partials        292        298     +6

Powered by Codecov. Last update b5f2674...bc5d62f


ipad "show keyboard" button does not show up in ios 13

Steps to reproduce

Open the monaco-editor homepage in safari on an ipad with ios 13+ installed
Note that the "show keyboard" button does not appear in the bottom right of the screen

In the following screenshot, the left side is an ipad simulator with ios 12.4 and the right side is an ipad simulator with ios 13.3. The keyboard button is visible in the left and not on the right.

monaco-editor version: 0.19.3
Browser: Safari
OS: ios 13.3
The cause is that the user agent string for safari in ios 13 was changed to mimic the user agent for desktop safari.

@riknoll Is there any other tell-tale that the current page is Safari on iOS than the user agent?
Currently, here we decide to show the keyboard icon if the browser is an iPad -- https://github.com/microsoft/vscode/blob/b8cace23ff07521a17df6c07ecb3becdb6db8d46/src/vs/editor/standalone/browser/iPadShowKeyboard/iPadShowKeyboard.ts#L26-L29
And here is where we check if it is an iPad -- https://github.com/microsoft/vscode/blob/b8cace23ff07521a17df6c07ecb3becdb6db8d46/src/vs/base/browser/browser.ts#L123
Do you know alternative ways to do this?

@alexdima I am not sure how to detect a difference between iPhone and iPad, but checking for navigator.maxTouchPoints > 0 should work for a check between desktop and mobile Safari.

Yep, I used navigator.maxTouchPoints > 0 to detect it in MakeCode. I think that might also trigger if they have a touch screen monitor connected to their mac but that seems like a pretty niche scenario.


Skip Nginx connection change for Docker build

The call to systemctl fails when building on Docker.

Demo
With master: https://ocd.appscale.com:8080/job/Create-Docker-Container/4372/
With branch: https://ocd.appscale.com:8080/job/Create-Docker-Container/4379/


Add readme for spec

As part of the PR initial readme is added and ignored readme file for jscpd

@sp98 PTAL


Adding an icon for history

eRegs uses its own icon font and we want to move over to cf-icons. Right now we use this history icon for the Regulation Timeline, and there isn't a good replacement for it in cf-icons.
Any chance we can add this in the next release?

(I got an svg too)

Paging @Dnpizarro, who doesn't watch this repo :)

Closed in #43


Upgrade PROJ API to 6.2+

This PR keeps the current C extension interface the same but upgrades the underlying PROJ version to 6.2+ instead of using the deprecated API.
This could be a good candidate for a minor release that will work on newer versions of Ubuntu and get the gem away from the deprecated API. Eventually, though, a thorough upgrade should be done that pulls in all of the new features of the PROJ library and use current best practices for PROJ (proj string syntax seems to have changed a bit since this was released).
This is not currently passing all the tests but is passing the majority of them, so hopefully just a few tweaks can get this to being releaseable.

@arkirchner this is what I have so far. Looks like the .travis.yml and extconf.rb files need to be updated as well, but it may work better than the tests show on your system if you want to try it.
Feel free to make any contributions or leave suggestions here. Thanks!

@keithdoggett Sorry for the late replay. Thank you very much for sharing your current progress! I will try my best to help!

I tried to get forward with the C implementation. The last 3 days I worked on this I made no progress ... 😢
I tried to not convert the proj strings into a CRS with +type=crs. This will create a transformation object instead of an CRS. The only thing I have achieved with that is creating the old canonical string.
pj = proj_create(0, '+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs');
str = proj_pj_info(pj).definition;

str will be proj=longlat ellps=WGS84 datum=WGS84 no_defs towgs84=0,0,0. So the original canonical without the + in front.
Well this doesn't help much but I felt like sharing. I try to a version in ffi for now. If I find a solution that way I will implement it in C.
I hope you have better luck than me!

Thanks for looking into this more. If you want to discuss anything about the changes you make, I'd be happy to take a look.

@keithdoggett Is there a timeline for when this is going to be finished, or is there a particular thing that is preventing it from being finished?

@keithdoggett Is there a timeline for when this is going to be finished, or is there a particular thing that is preventing it from being finished?

@mzagaja, unfortunately, no. This has fallen in priority a bit, but I can probably take another try at it in a month/month and a half. I can also review PRs and give guidance if you want to try to modify this branch.
If I remember correctly, this was pretty close to working, but a lot of the tests needed to be rewritten because the proj string format changed slightly and a "+" is always needed to indicate a CRS is being specified. Have you tried running this branch?

@mzagaja, unfortunately, no. This has fallen in priority a bit, but I can probably take another try at it in a month/month and a half. I can also review PRs and give guidance if you want to try to modify this branch.
If I remember correctly, this was pretty close to working, but a lot of the tests needed to be rewritten because the proj string format changed slightly and a "+" is always needed to indicate a CRS is being specified. Have you tried running this branch?

@keithdoggett I have not, but if the modifications required are that minor then when I have some bandwidth I'm happy to take a run at it .

@keithdoggett I have not, but if the modifications required are that minor then when I have some bandwidth I'm happy to take a run at it .

@mzagaja I took another look at it last night. There are about a dozen test failures, but it looks like ~10 of them are due to some minor issue.
Also what needs to be added is the "+type=crs" flag to every proj string to specify it's a CRS, not just a "+". I

@mzagaja I took another look at it last night. There are about a dozen test failures, but it looks like ~10 of them are due to some minor issue.
Also what needs to be added is the "+type=crs" flag to every proj string to specify it's a CRS, not just a "+". I

@mzagaja @arkirchner the version I have up passes locally for me (Ubuntu 18). I'm having issues getting proj to install on Ubuntu runners in the CI. Looks like the macos runners are having issues installing geos or linking it to RGeo.
I'll take another look at getting the CI figured out soon, but in the meantime, if you want to try/review the changes that would be helpful. Thanks!

For some reason, the Ubuntu CI runners in this repo can't install a proj version >4.9, even though with the exact same CI.yml file it works on my fork (https://github.com/keithdoggett/rgeo-proj4/runs/1965549117?check_suite_focus=true) and installs version 6.3.

Thanks for the feedback!

Some other points of attention:
* Couldn't we leverage usage of `GC.compact` right now since we are doing all those changes ? You can take a look at [the reference](https://github.com/ruby/ruby/blob/master/doc/extension.rdoc#label-C+struct+to+Ruby+object) or [this great talk](https://youtu.be/1F3gXYhQsAY?t=1868) by @tenderlove (I've pointed to the part about updating a lib to support compaction, but the whole talk is great really)

Yes, I definitely think we should use the newer features where possible and this will be helpful to figure out the best practices on a smaller extension here before moving into the core library. I'll take a look through those soon.

* Did you try the new version for potential memory leaks ? Since we're not expert enough, I think we should use valgrind and/or some other tool to test what you've done here and make sure we won't induce leaks..

Not yet, but I can take a look sometime this week.

I'd be glad to help on these two points whenever I can find enough time. And the GC compact part may not be mandatory, it's just a plus..

Thanks that would be great. We might as well at least try to figure out GC.compact since we're already making big modifications to it.

@keithdoggett one more insight on the GC.compact, we should be really careful on this one since i saw we use RSTRING_PTR for the original_str. Since GC.compact moves references, the pointer stored in C (in the proj4 api) may be pointing to another resource...

@BuonOmo I added support for compaction per the video you sent and your PR on oj (https://github.com/ohler55/oj/pull/650/commits/6e88d14556badf2413f8d9bef5bfc8414561b4bb). I also changed from RSTRING_PTR to StringValuePtr which should be safer with compaction. Do you think we need to add a test for compaction?
The last thing left at this point should just be to find a way to test for memory leaks programmatically. I've done a little bit of research, but will look a little more to see how we could integrate valgrind into a rake task.

@keithdoggett I don't have time to review everything yet unfortunately :/. However, I stumbled over two things that should be interesting:

On RSTRING->ptr (or RSTRING_PTR) vs StringValuePtr, I suggest reading the part struct RString of https://ruby-hacking-guide.github.io/object.html
On testing GC.compact, there's a method for that since ruby 2.7 (https://docs.ruby-lang.org/en/2.7.0/GC.html#method-c-verify_compaction_references).

1. On `RSTRING->ptr` (or `RSTRING_PTR`) vs `StringValuePtr`, I suggest reading the part _`struct RString`_ of https://ruby-hacking-guide.github.io/object.html

After reading through the guide, it seems that no matter how we access the char* it will be fine as long as we don't assign to it. Right now, we only pass it in to proj_create which is assigned to proj_data->pj. Since we never modify proj_data->pj we should be fine. I'm not sure if this method verifies the VALUE is an RSTRING first, but I can check that.

2. On testing GC.compact, there's a method for that since ruby 2.7 (https://docs.ruby-lang.org/en/2.7.0/GC.html#method-c-verify_compaction_references).

I found this article (https://alanwu.space/post/check-compaction/) which demonstrates using GC.verify_compaction_references in a test suite. We could easily add this to ours.
I tried looking at the outputs of GC.compact and GC.verify_compaction_references (they both have the same output), and it is difficult to verify that a specific in a testing context since there are many T_DATA objects. In an IRB shell, it is possible to see that only 1 T_DATA object is moved, but it is around 350 when running the tests. Personally, I think calling GC.verify_compaction_references(double_heap: true, toward: :empty) is enough to verify.

@BuonOmo I've removed the compaction test for now because LineString creation in the core gem is causing a seg fault when it is enabled. I don't think there's any way to just test the Proj extension for it since the tests rely on RGeo objects. We should probably just test for it once the core library is updated.
Is there anything else you think we need to check before this is ready for release?

Thanks for all the help on this @BuonOmo! 3.0.0 has just been released :tada:


Return informative errors on CLI if user request API while node is still syncing

Description
Follow up of #2417
On this PR, the notion of synced state was introduced on SDK, and on CLI we update properly the value of the /status endpoint. Also, some sensible endpoints (like channels) are made available only once the SDK finishes syncing. Before that, the CLI may currently return some not very informative errors, like 500 or 404. We should add proper error messages there, so the user is infomed they need to wait for the SDK to finish syncing before requesting those endpoints.
Acceptance criteria

Tasks

[ ]

Closing, user is not expected to make api calls while syncing other than to the status endpoint.


Add .devcontainer for NubesGen project

PTAL @jdubois @cmaneu

Oups I am closing this momentaneously til I add two or three missing things.


jspm install -y ERROR

Hi, I get an error on trying to run this project:

Do I really need credentials to get this files?
Update: OK, I have :)
kind regards

Because jspm makes requests from github to import released packages, it is possible that you can exceed the github rate limit. In that case, you will need to provide your credentials. We are trying to work with the jspm team to see if they can alter their implementation to use some other fetching technique that avoids this.

Hi Eisenberg, sorry, I should read more precisely. Works fine now ;)
thanks!

No problem. We would like this to be a nicer experience in the future.


feat(lib): Take env vars into account

Environment variables OPT_IN and OPT_OUT are taken into account when no package.json or .opt-in /
.opt-out file is present.

Current coverage is 100.00%

Merging #21 into master will not affect coverage as of 05cf0ce

@@            master     #21   diff @@
======================================
  Files            2       2
  Stmts           69      76     +7
  Branches         0       0
  Methods          0       0
======================================
+ Hit             69      76     +7
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 05cf0ce

Powered by Codecov. Updated on successful CI builds.


useSSL no present

Hi,
Our S2 has SSL enabled by default, how to use S2 driver with SQLTols to add use SSL parameter?
Thanks,
Robert

Hi Robert,
Thanks for your request. At the moment it is not possible to set SSL parameters with this driver.
I opened an internal feature request to add this possibility.


Characteristic.onUnsubscribe not called on disconnect

When a bluetooth device gets disconnected, it's notify listeners remain active.

+1

+1

Hi @adi1133, @jor3l, @henla464,
This has been implemented in https://github.com/sandeepmistry/bleno/commit/1a3cbd49bbaf7d024faa4e0a8d3bc4d17d25cc99. Please try it our via npm install sandeepmistry/bleno and provide your feedback.

We're having the same issue. When will this be released?

@mattsson I've published v0.4.2 to npm now.

@sandeepmistry Cool, thanks.

Hi @sandeepmistry,
Was this issue fixed in 0.4.2?
I'm using 0.4.2 and still onUnsubscribe not being called on disconnect.
I'm wondering if there is an issue on my end or maybe it wasn't fixed yet?
10x.

Hi @sandeepmistry ,
Fixed it by adding the code in 1a3cbd4 manually.
10x


CFE_EVS_Register not validating inputs first

Describe the bug
inside EVS register it clears the AppData record before it validates all the inputs. If some of the inputs are invalid that then causes the app to crash.
Expected behavior
Validate inputs first before anything else.
Code snips
https://github.com/nasa/cFE/blob/33a4f19ce6dc2c132823b3c8c487a59d5b4b81a8/modules/evs/fsw/src/cfe_evs.c#L46-L74
Reporter Info
Alex Campbell GSFC

Could you provide a little more info on what actually causes a crash?  Was it observed or by analysis?  Both AppDataPtr and AppID are internal and success is checked, I'm not seeing how invalid parameters could cause a crash.

So for example when FilterScheme != CFE_EVS_EventFilter_BINARY the function set the status to a failure code and stops. However  memset(AppDataPtr, 0, sizeof(EVS_AppData_t)); has already happened so it leaves the AppData as cleared out and never rebuilds it. This causes the functional test to print out this error "EVS Port1 66/1/CFE_EVS 41: App CFE_TEST_APP not registered with Event Services. Unable to send event." and then unable to finish the rests of the tests.
I found this while trying to write the functional tests for this.

So for example when FilterScheme != CFE_EVS_EventFilter_BINARY the function set the status to a failure code and stops. However memset(AppDataPtr, 0, sizeof(EVS_AppData_t)); has already happened so it leaves the AppData as cleared out and never rebuilds it. This causes the functional test to print out this error "EVS Port1 66/1/CFE_EVS 41: App CFE_TEST_APP not registered with Event Services. Unable to send event." and then unable to finish the rests of the tests.

Sounds to me like this is how it should work?  Either way (not calling CFE_EVS_Register or calling it with incorrect values) should leave the app in a state of not being able to send events.  You need to successfully register with EVS to be able to send events.  If it was working because AppDataPtr wasn't getting cleared that would be an actual bug.  Happy to chat if it helps.


Fix operation on nested type-choices in FhirPatch implementation

Per the FHIR specification on Patch operations on choice types:

Note that for elements with a choice of data types, the FHIRPath name in the name of the parameter does not include the data type suffix (per the rules in the FHIRPath Specification), but the parameter value does.

This was being handled correctly by the FhirPatch implementation for top-level parameters, by appending a [x] to the element name when retrieving the child definition, here.
However, the same logic was not being applied for nested fields. A common use-case exhibiting this behavior can be seen when adding an extension to a resource via PATCH.
The solution proposed here is to use the same logic to append [x] to the element name when retrieving the child for nested parameters.

Thanks for the PR! Looks good to me, will merge when CI passes.
This just made the code freeze for the upcoming 6.6.0 release (cutoff is today) so this should be in.

Thanks again @zachdoctolib - Apologies, this did not end up making the cutoff for 6.6.0 but we'll have snapshot builds of 6.8.0 up with this fix included within the next day or so.

No worries @jamesagnew ! While I've got you though, would it be possible to get a review on #4489 ? It's another frequent issue that our team has been facing 🙂
Thanks for all of the hard work on hapi-fhir!


Additional traces

@PoshChan-Staging please remind me in 1 minute

@SteveL-MSFT, this is the reminder you requested 1 minute ago

@PoshChan-Staging please remind me in 1 minute

@SteveL-MSFT, this is the reminder you requested 1 minute ago

@PoshChan-Staging please remind me in 1 minute

@SteveL-MSFT, this is the reminder you requested 1 minute ago

@PoshChan-Staging please remind me in 1 minute

@SteveL-MSFT, this is the reminder you requested 1 minute ago


[create-environment] "environment-url" output "masked"

Hi team,
I thought it would be great to use the environment-url output provided in the create-environment action but face an unexpected issue during my first test.
It seems the value in the environment-url output is "masked" (ex: https://***19***/).
In my case, I tried to put the value of the environment-url output in a job output to use it in other places in my workflow but got the following message: Skip output 'dev_environment_url' since it may contain secret.
Is it normal that the value of the output is "masked"?
If yes, do you think you could provide a way to have the unmasked value so we can use it in the workflow? (ex: mask-aws-account-id input in aws-actions/configure-aws-credentials)
Thank you in advance for your help.

Hi team,
There is perhaps nothing to do on your side about this issue...
I have tried to implement a workaround using the pac admin list --environment command with the environment id I was able to see in the logs of the "create environment" action and I think it is the GitHub runner itself whick mask the URL...
I will try to find more details about this hypothesis and will let you know if I find something.

Hi team,
I opened a GitHub ticket regarding this issue.
It seems it is currently the expected behavior for the management of things like URLs (Environment URL not set because env may contain secret).
In the meantime, I will close this issue because I think there is nothing we can do on our side and I hope it will be address by GitHub in the near future 🤞🏼.

Hi team,
For your information, I have done another test and this issue now seems really resolved.


Chocolatey package

Thanks for making this driver plugin. I have built a Chocolatey package docker-machine-vmwareworkstation which is in review at the moment. But anyone can use it already with
choco install docker-machine-vmwareworkstation -version 0.9.0

This also installs the docker-machine Chocolatey package.

Great stuff! is there anything i can do to help with that or make it easier for you to maintain the choco package?

Oh, just got first feedback from package review:
'docker-machine-vmwareworkstation' is Submitted.
doc left the following comment(s):

The site of the project should be this:
https://github.com/pecigonzalo/docker-machine-vmwareworkstation

docker-machine-vmwareworkstation is marked as a Pre-release:
https://github.com/pecigonzalo/docker-machine-vmwareworkstation/releases
If the program is supposed to be stable some day, for the pre-releases you would have to change the version to for example 0.9.0-prerelease (it doesn't have to be 0.9.0-prerelease, it can be 0.9.0-alpha, 0.9.0-beta or whatever you want). Those would be exempted versions and you would have to install them using choco install docker-machine-vmwareworkstation -pre

Your release 0.9.0 is marked as pre-release. I've tested it today and it worked out of the box. IMHO it is worth a release and not just a pre-release. As the next version probably has a higher version number this is fine thesedays ;-)
You may find the Chocolatey package sources here: https://github.com/StefanScherer/choco-docker-machine-vmwareworkstation
I first thought of sending you a PR with the few files and put it into your repo as well. This might also work very vell with AppVeyor doing a "go build", some unit tests, publish the binary as a github release if it was a git push --tags and then also build and test the choco package and deploy it to chocolatey.org. Could all be done in one appveyor.yml.
But I can make you a collaborator to my choco repo. No problem at all.
I tested it in a Windows 10 VM with

Installing Chocolatey
choco install -y vmwareworkstation and activated the license
choco install -y docker-machine-vmwareworkstation and then
docker-machine create -d vmwareworkstation dev

Worked out of the box, but haven't used it further. But at work I'll install it on a DELL notebook and use it in parallel to VirtualBox...

The idea of merging it to this project with a PR so we can then automate it with appveyor sounds good, if you are still keen on that ill love to do that and help get it done.
One of the reasons i didnt mark it as release is because i dont have any testing on the build/functionality as of yet, but im ok to change the name of the prerelease versions to append the "-prerelease" ill do that today.

I think you can leave the 0.9.0 release as it is. The reviewer at chocolatey suggested the suffix for the choco package if you plan to release a "final release" still as 0.9.0. But I think you will increase the version number so there is no need for such a suffix.
And yes, a merge of the two repos would look even better as the complete build and deployment is done in one repo.
To build a go binary at http://www.appveyor.com there is eg. a build for packer: https://github.com/mitchellh/packer/blob/master/appveyor.yml
I used AppVeyor to build C++ programs and deploy it as a GitHub release, eg. here: https://github.com/StefanScherer/win-getaddrinfo/blob/master/appveyor.yml
So we only have to put all pieces together...

Ill start the appveyor stuff i have an account and all.
Btw your c++ app, you are publishing your token, i dont think that is recommended.

Initial AppVeyor is set, ill start building some more test cases, feel free to submit a PR for the choco stuff.

Ill close this if you agree.

Sure. I'll send a PR for choco later.


Exposing default and constant values

I was wondering if it were possible to expose GripperState::max_width in the ROS parameter server or maybe in the result of the HomingAction.
On a different but related note, I find myself having to define many static constexpr  values for, for example, the bit "_linkN" from "panda_linkN" or "_leftfinger" (since I can get the arm_id from /franka_state_controller") from the SRDF. I can find the joint names in the parameter server, but not the link names...and I haven't found another way to get those.
Same goes for static const geometry_msgs::Vector3 distance_flange_to_center_of_fingers_closed describing the (0.0, 0.0, 0.1034) vector you provide on the research manual (pag. 44). This one is needed for a static transform broadcaster which I would gladly remove from my code if you had a default one in franka_state_controller.
As far as I know, these should all be constant for all Panda robots. I personally prefer to avoid having my own definition for defaults if defaults are already in place from someone else. It would really be nice to have these setup, though they are not a critical concern. At the same time I'm not sure wether this is regarded as a "best practice" in the ROS community, especially when talking about the SRDF parameters.

A note on the distance_flange_to_center_of_fingers_closed: I was looking for frame panda_K which franka_state_controller indeed publishes. I was always reading a number somehow different from 0.1034 and thought you were publishing the distance to the center of the tips of the fingers, not the center of the fingers. Glad I was wrong!

I have accidentally found:

MoveGroupInterface::getLinkNames() for panda_linkNs;
RobotModel::getActiveJointModelsBounds (accessible via MoveGroupInterface::getRobotModel) for an easy GripperState::max_width.


Remove old _gcp signature

Fixes #23
Should still probably re-think how we do these tests (not done here), but will save that for later.

All tests passing (except likely unrelated Julia nightly issues). Merging!


BUG IPython colors config for jug execute --pdb (fixes #27)

This resolves #27 for me (Python 3.4, IPython 3.2.1)

thank you. Ipython's lack of a stable API is such a PITA.

;-)


Buit-in PHP docs and intellisence

Would be great if we could have built-in PHP docs, as we do have for JS and a proper intellisence that be able to map classes and functions from my project files, besides PHP native functions.

By PHP docs, do you mean the information on hover?

Hey @ramya-rao-a. Nop, I'm talking about the comment block started by /** ...  */ . It would be really useful if it works for PHP in the same way it's working now for JS files.
As for intellisence, I mean a buit-in one, coz now I'm using some extensions, but usually it duplicates the suggestions and doesn't understand some FW packages, such as Codeigniter.

cc @mjbvz who worked on the jsdocs
@mousetraps can speak more to the intellisense part of the query

Great! I'd love to hear from them. :) Thanks.

@rogeriotaques For the PhpDocs support, did you mean picking up intellisense information from the phpdoc comments or were you referring to the JSDoc autocomplete support vscode provides in JavaScript and TypeScript?

@mjbvz the second, the autocomplete support vscode provides for JSDoc in JavaScript and TypeScript.
Just in case, if possible to have the intellisence (from PHPDocs) too, that would be amazing good!

@mjbvz have u seen my last message?

Hello all. I've searched issues with "PHP and Comment" query and this comes up.
I also would be happy, if PHP language has the same intellisense option when you type /**

@mousetraps is maintaining the PHP extension so she can follow up on the feature request.
I've marked as help wanted in case anyone wants to start taking a look. We use onEnter rules for basic jsdoc expansion in JS/TS. The auto filled JSdoc templates come  through this completion provider. Intellisense inside of jsdocs comes from the typescript server that powers our js and ts language features

Here's another php intellisense offering that might be suitable: https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client

@bmewburn thanks. Will give a try.

Only the extensions would be able to do this. Also the fixed comment matching support just landed.


Bug: Allow for One tuple in DC

Files that need changes: parser_interface, dc featurizer, and dc error detector

Closed: As this bug fixes requires a new grammar parser. This issue will be lumped in with Issue #113.

Can you please give an example


[MINOR] Typos, renaming, other stuff

Before I forget to address the last somments on the PR, here it is.
I'm not sure it is best to add further logs before the return 1 in registry functions, when there is no log at that point it is because a log has already been prompted in the function where the error happened. Unless you want to add genereic log messages like "failed while uploading the index", etc.

Yeah, the point is to always have a log message once smth goes wrong, in either the calling side or the API side. I am fine with both but just want to catch the errors with the finest precision.

Yes, I see. After looking at it a bit more, from what I see there the try/except blocks fall into one of these categories:

error specific to the backend used, logs should be inside the backend
ValueError that is future PorcelainError -> to be modified later
ValueError in git index: it's the only kind of error, and we always log a specific message where the failure happened


Ember route based bodyclasses

We need some special bodyclasses for various view states on the settings ui. Details as follows:

If route = /settings/ bodyclass should be .settings-main
If route = /settings/[thing]/ bodyclass should be .settings-view
If route = /settings/[thing]/[thing]/ bodyclass should be .settings-subview

See https://github.com/TryGhost/Ghost/issues/3792#issuecomment-53401253 for more specifications

@JohnONolan can we close this for now and reopen if we decide it's needed again?

yes


[flutter_tool] Pin DevTools to 2.4.0

Currently, DevTools can be updated out of band, which can close the tree on an unrelated commit in a way that is difficult for the gardener to diagnose. See https://github.com/flutter/flutter/issues/86121. This PR pins DevTools to avoid this issue.

Fyi @kenzieschmoll @devoncarew. This will mean that Flutter will stop getting updated versions of DevTools out of band. That is probably ok as we will have the same out of band update restrictions when we switch to deploying DevTools as part of the Dart SDK.

I suggest using a constant so that we don't have to update the tests when we roll devtools. That might make testing it on the devtools side easier too.
It would be good to have an autoroller of some sort so that we know that we don't have to keep manually bumping this.
If we pin, we can stop trying to activate devtools every 12 hours, right?

I suggest using a constant so that we don't have to update the tests when we roll devtools. That might make testing it on the devtools side easier too.

Follow-up here: https://github.com/flutter/flutter/pull/86130

It would be good to have an autoroller of some sort so that we know that we don't have to keep manually bumping this.

I believe there is a plan to move DevTools into the Dart SDK, which will help with this. Do I have that right @jacob314 ?

If we pin, we can stop trying to activate devtools every 12 hours, right?

Yeah, I think we can remove that logic.

For posterity, the file to update is now bin/internal/devtools.version.
Having this pinned in flutter/flutter is definitely incentive for us to move to a model where we ship devtools in the sdk and keep it continually updated. Otherwise we won't know what version of DevTools people will get for stable releases - different users will be on different versions depending on how they had opened DevTools; we won't be able to coordinate devtools features w/ major events.


fix: fix issues with form recognizer parsing and form ontology learner

Summary
Briefly describe the changes included in this Pull Request.
Tests
Describe what tests have you performed to validate your changes before submitting the Pull Request. Use 'N/A' if not applicable.
Dependency changes
If you needed to make any changes to dependencies of this project, please describe them here.
AB#1781126

/azp run

Codecov Report

Merging #1506 (a09d10c) into master (f232058) will decrease coverage by 79.85%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #1506       +/-   ##
==========================================
- Coverage   84.20%   4.34%   -79.86%
==========================================
  Files         296     267       -29
  Lines       14923   13618     -1305
  Branches      708     708
==========================================
- Hits        12566     592    -11974
- Misses       2357   13026    +10669

Impacted Files
Coverage Δ

...ure/synapse/ml/cognitive/FormOntologyLearner.scala
0.00% <0.00%> (-87.24%)
:arrow_down:

...ft/azure/synapse/ml/cognitive/FormRecognizer.scala
0.00% <0.00%> (-75.93%)
:arrow_down:

.../azure/synapse/ml/cognitive/FormRecognizerV3.scala
0.00% <0.00%> (-67.65%)
:arrow_down:

...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/spark/ml/param/ModelParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/spark/ml/param/UDPyFParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/NamespaceInjections.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/param/DataTypeParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/ByteArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/EvaluatorParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f232058...a09d10c. Read the comment docs.

/azp run

/azp run