Gwright99/31-implement-python-verification

Several concerns about the script.

I think all removal of comments should be in another script, it would be much more readable and organized. Are you sure a simple sed wouldn't work? :)
The way python gets the AWS configuration is machine specific, this should run always on a pipeline ideally. We should think how to standardize it so that it works everywhere otherwise.
Should it be a githook? Maybe a script call in a makefile before terraform plan it's simpler?
Should we work before in a simple standard pipeline (Atlantis or whatever) before adding this script?
...

Thoughts:

Comment extraction was moved to a separate module to keep the main script cleaner. I think we should keep the two mechanisms together because the edge-cases (jamming together a multi-line entry) will break if you don't rip out interspersed or inline comments.
i. I added a comment agreeing that roll-your-own-parser is normally dumb. I'd prefer to use sed but - prior to you joining - we had several issues where MacOS sed did not behave the same way as Windows/Linux sed. Using a pure Python solution means we don't need to think about OS mismatches or include this as a test case.  I've kept the suggested sed command in the script anyways in case we change our mind / get feedback from the field that the current solution is stupid (I could be convinced).

Not sure I understand the boto3 concern. Agree that it's AWS-specific right now, but that's the only environment we support right now (TBD if we do the same for Azure/GCP). Subnet mismatches are pretty common and we have at least a few examples of clients trying to work with an existing VPC who encountered subnet configuration errors.

I'm happy to make this a bit more agnostic if we think it's easy to do, but don't want to over-optimize/abstract too early. Let's discuss.

The code is in a .githook folder because it needs to be there to run a pre-commit action. I don't think its placement in the project precludes a Make file from calling it. I was thinking checks happen in two places:

Via Make file before deployment (i.e. I'll often run a configuration prior to commiting).
A secondary check in the pre-commit phase (_to ensure a misconfiguration wasn't introduced between the deployment test and submission to the git repo).

Do you think you can start implementing an Atlantis branch in parallel to this work. Working concurrently would be beneficial, particuarly if you can do your work if I promise to not change the script entrypoint being .githooks/check_configuration.py

Fine by me.
Oh, you added a variable for the AWS profile, I think I saw a hardcoded profile there... never mind.
Ok, we can call it from both places, that's fine.
Yes:), I'll start looking at https://www.runatlantis.io

Makefile and pre-commit mechanism working:

@adriannavarrobetrian -- seeing as I wrote the code in this PR, it would be a little self-serving of me to approve it too. I can't assign you as a Reviewer since you've opened the PR, so I'm tagging @markpanganiban for the sanity check.

@markpanganiban I'll update the README, but you need the following commands to test:

pre-commit hook:

In the root of the repo, execute: git config core.hooksPath .githooks
Add a file to the branch and then try to commit.
You should see the Python script fire.

Validation before TF execution:

In the root of the repo, type: make plan.
You should see the Python script fire and then cascade into a terraform plan if all checks are passed.


plugin Does not show up in PowerBIVisualsPlayground plugins list

i create a new iVisual item as the documentation says, named "CalenderView"
Now as per documentation it says it need to uncomment this code to be able to see my plugin in the
PowerBIVisualsPlayground plugin list, i have done that. But it is not displaying in the PowerBIVisualsPlayground plugin list. I have also tried to put this code in the plugins.ts, but still no result.
How can i fix this problem, thanks a lot in advanced ...
/* Creating IVisualPlugin that is used to represent IVisual. */
//
// Uncomment it to see your plugin in "PowerBIVisualsPlayground" plugins list
// Remember to finally move it to plugins.ts
//
module powerbi.visuals.plugins {
export var calenderview: ivisualplugin = {
name: 'calenderview',
capabilities: calenderview.capabilities,
create: () => new calenderview()
};
}

there are couple of error in your code.
in the first line ivisualplugin it Should be IVisualPlugin
Change your class and capabilities name from calenderview to Calenderview
So the answer is :
export var calenderview: IVisualPlugin = {
    name: 'calenderview',
    capabilities: Calenderview.capabilities,
    create: () => new Calenderview()
};

Hope it will help you.

I got a same issue

After you make several capitalization changes in your visual you will need to add your file ref to the list in tsconfig.json

I did everything in Steps above and still do not see my new visual.

Ok I now see my visual.  I needed to rebuild using Gulp.  For some reason the rebuild in VS2015 is not working.


GDriveAutoremover doesn't work

My Google Drive has 15G space, after two day's video auto uploading, the space is full right now when I checked.
Although I've set autoremoved=on in conf/gdrive.conf, but it's not working, I checked GDriveAutoremover.log
There are repetitive lines of 'out of range', like:
sh:<PHONE_NUMBER>6: out of range
sh:<PHONE_NUMBER>6: out of range
sh:<PHONE_NUMBER>6: out of range
And file uploading failed due to GDrive space limitation, the GDriveUploader.log tells:
{ "error": { "errors": [ { "domain": "global", "reason": "storageQuotaExceeded", "message": "The user's Drive storage quota has been exceeded." } ], "code": 403, "message": "The user's Drive storage quota has been exceeded." } }
Obviously, that script doesn't function normally.

I think I've found the bug, I've submitted the new code.

I need more time to work on it, I still found some out of range output this morning, not as frequent as I had before.


OpenCV support not built-in. Certain features will not work.

During make, I'm getting this output:
make
Building bin/loader.so...
g++ -shared -o bin/loader.so -fPIC -Wall -Wno-deprecated-declarations -O3 -std=c++11     src/loader.cpp
In file included from src/loader.cpp:19:
In file included from src/loader.hpp:27:
src/matrix.hpp:39:2: warning: ("OpenCV support not built-in. Certain features will not work.") [-W#warnings]
#warning ("OpenCV support not built-in. Certain features will not work.")
 ^
1 warning generated.

I just installed OpenCV3 with homebrew. What's might be wrong?
My env:
macOS Sierra 10.12.3 (16D32)

Not sure why it's not detecting your OpenCV installation, but you can ignore the warning in this case. This code uses a custom data loader that does not depend on OpenCV.


Provide sha256 checksums for release binaries

To be able to verify the downloaded binary it would be good if you can provide sha256 checksums for the released binary files

DUP https://github.com/byteball/byteball/issues/70
Just because I'm not sure if admin/mods get notifications of new comments after closing, I'm just going to mention that I proposed a simple and common solution in #70.

Binaries are signed and have certificates, OS checks them automatically. AppImage for Linux has SHA256 checksum https://github.com/byteball/obyte-gui-wallet/releases


Pma 24

Tree of hierarchy has been implemented into Home Page

Thanks for your contribution! Unfortunately, these changes are not related to the sample app. The sample app use case is a real estate agency sales / field service app.
Additionally, if you want to submit more PRs in the future, the CLA must be signed and the CI must pass.


Develop

Turn any error raised in Calendar.from_ical into a DataFailureException.

Coverage decreased (-0.2%) to 90.603% when pulling c501bf127bf0fdbc2a17bfd43a29f24d7fc26494 on develop into 606a766f9b826e5aa969f29c50ca2a9aadcc5ae8 on master.

Coverage decreased (-0.2%) to 90.603% when pulling c501bf127bf0fdbc2a17bfd43a29f24d7fc26494 on develop into 606a766f9b826e5aa969f29c50ca2a9aadcc5ae8 on master.

Coverage decreased (-0.2%) to 90.603% when pulling c501bf127bf0fdbc2a17bfd43a29f24d7fc26494 on develop into 606a766f9b826e5aa969f29c50ca2a9aadcc5ae8 on master.

Coverage decreased (-0.04%) to 90.769% when pulling f0de191caf97b4e50b78299f8beaa31b29888a51 on develop into 606a766f9b826e5aa969f29c50ca2a9aadcc5ae8 on master.


docker restart flag not working correctly after locksmithd OS update

Description
When FlatCar has been updated by locksmithd docker engine is not starting(?) but all starts when someone ssh to machine
Impact
Every stable release I need to ssh to all my machines
Environment and steps to reproduce

A standard flatcar AWS machine with single locksmith coordinator
Run docker image with the flag --restart=always
Let locksmithd to reboot the machine
Let the system run for a bit and ssh to box

Expected behavior
Containers to automatically start without user to ssh to the machine.

There is documentation for this topic: https://kinvolk.io/docs/flatcar-container-linux/latest/container-runtimes/getting-started-with-docker/#permanently-running-a-container
You can enable the Docker service and disable the socket activation (on-demand start of Docker), to always have Docker running.
The preferred way however is to use systemd units:
[Unit]
Description=your container
Wants=docker.service
After=docker.service
[Service]
Type=simple
Restart=always
RestartSec=5s
TimeoutStartSec=0
ExecStartPre=-docker rm -f yourcontainer
ExecStartPre=docker run --name yourcontainer -d yourimage yourargs
ExecStart=docker logs -f yourcontainer
ExecStop=docker stop yourcontainer
ExecStopPost=docker rm yourcontainer
[Install]
WantedBy=multi-user.target

There is documentation for this topic: https://kinvolk.io/docs/flatcar-container-linux/latest/container-runtimes/getting-started-with-docker/#permanently-running-a-container
You can enable the Docker service and disable the socket activation (on-demand start of Docker), to always have Docker running.
The preferred way however is to use systemd units:
[Unit]
Description=your container
Wants=docker.service
After=docker.service
[Service]
Type=simple
Restart=always
RestartSec=5s
TimeoutStartSec=0
ExecStartPre=-docker rm -f yourcontainer
ExecStartPre=docker run --name yourcontainer -d yourimage yourargs
ExecStart=docker logs -f yourcontainer
ExecStop=docker stop yourcontainer
ExecStopPost=docker rm yourcontainer
[Install]
WantedBy=multi-user.target

Hello
Thank you for an update, I will apply changes and update the ticket in next release.

Hello
Thank you for an update, I will apply changes and update the ticket in next release.

@HubertBos Closing this issue. Feel free to reopen if the issue persists.


[com.google.fonts/check/dsig] Suggest lowering level to INFO

(NOTE: Please include the check-id on the issue title. Check-id example [com.google.fonts/check/metadata/parses])
Observed behaviour
Check level in check-opentype is WARN.
Expected behaviour
Check level in check-opentype should be INFO.
Resources and exact process needed to replicate
worksans.zip
Rationale
dsig is part of the spec and I am quite far along on implementing it properly.

The dsig check is not merely informative. It is actually a warning about something that a user should at least consider addressing. The fact that you're "quite far along on implementing it properly", does not change this.
I'd avoid making WARNs into INFOs, because the tendency is to have the check-results less visible to the vast majority of users. So we reserve the INFO level to be used exclusively on checks that are really just informative, such as showing a table of statistics computed from a font, but not a hint of any actual problem to be considered.

whether or not there is a free software implementation, DSIG is part of the spec and having it is not an error

Having it is not, indeed, a FAILure case. But it's largely useless and the manufacturer should consider removing it, so WARN is correct here.


RHBPMS-3973: A ClassNotFound exception is shown while a Service task is being executed

replaced by https://github.com/droolsjbpm/jbpm/pull/519 with test case


Add info icon for a dependency if the dates is invalid.

Show an icon if there's a problem with the dependency's dates.

@LiXin2014 We haven't had any unit tests until now since we really haven't had any business logic. I think now is the right time to add some for this dependency problem stuff.

@shutchings , @ezambra , could you take a look at my most recent commit?
The one that gest workitemtypemapped states form backlog configuration?
I am using that information to check if a work item is in state "InProgress".


[DOC] [Remote State] Meta issue for documentation

What do you want to do?

[X] Request a change to existing documentation
[X] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Description
We need to update public documentation for any PRs raised for remote cluster state
PRs tracked:
https://github.com/opensearch-project/OpenSearch/pull/10814
https://github.com/opensearch-project/OpenSearch/pull/10665
https://github.com/opensearch-project/OpenSearch/pull/10447

@rahulkarajgikar - And which features are targeting 2.12?

Hi @Naarcha-AWS , can you please track this down and see if there is anything related to 2.12? Or are these already implemented/documented in a previous version?

@hdhalter These are being tracked for 2.12 release

Thanks, @soosinha ! Can you please add these issues to the roadmap/project tracker for visibility?

@hdhalter These issues are already resolved and code is merged in 2.x branch.
Do you still want me to add in the project tracker? If yes, then can you provide the project tracker link ?

@hdhalter These issues are already resolved and code is merged in 2.x branch. Do you still want me to add in the project tracker? If yes, then can you provide the project tracker link ?

Yes, so we can see all features at a glance. The marketing team uses this list to determine what features to highlight in the release blog.


Restrict APIs to those allowed in app extensions for macOS and tvOS

#41 enabled the app extension API restriction for iOS. Looking at the configuration currently in the project file, the restriction was enabled for all builds of the ObjExceptionBridge and all builds of XCGLogger targets except macOS and tvOS.
This PR enables the restriction to only app extension compatible APIs for XCGLogger on macOS and tvOS, so that all targets are configured equivalently.

Merged, thanks for the PR.


Ingress pathType: Prefix returning 404

Bug description:
Creating Kubernetes ingress resource with pathType: Prefix, additional path parts don't route properly and returns 404 incorrectly.
For example, when ingress path: /, /get incorrectly returns 404 (<IP_ADDRESS> is nginx ingress controller LoadBalancer IP):
$ curl -v <IP_ADDRESS>/get
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> GET /get HTTP/1.1
> Host: <IP_ADDRESS>
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Tue, 04 May 2021 20:29:01 GMT
< Content-Length: 0
< Connection: keep-alive
<
* Connection #0 to host <IP_ADDRESS> left intact

Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ X ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
Demo                       [ ]
CI System                  [ ]

Expected behavior:
$ curl -v <IP_ADDRESS>/get
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> GET /get HTTP/1.1
> Host: <IP_ADDRESS>
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Tue, 04 May 2021 20:29:16 GMT
< Content-Type: application/json
< Content-Length: 259
< Connection: keep-alive
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Credentials: true
<
{
  "args": {},
  "headers": {
    "Accept": "*/*",
    "Host": "<IP_ADDRESS>",
    "User-Agent": "curl/7.58.0",
    "X-Forwarded-Host": "<IP_ADDRESS>",
    "X-Scheme": "http"
  },
  "origin": "<IP_ADDRESS>",
  "url": "http://<IP_ADDRESS>/get"
}
* Connection #0 to host <IP_ADDRESS> left intact

Steps to reproduce the bug (as precisely as possible):

Install osm:

osm install

Install nginx ingress

kubectl create namespace ingress-basic
helm install nginx-ingress ingress-nginx/ingress-nginx \
    --namespace ingress-basic

Create deployment for httpbin:

# Create the httpbin namespace
kubectl create namespace httpbin

# Add the namespace to the mesh
osm namespace add httpbin

# Deploy httpbin service in the httpbin namespace
kubectl apply -n httpbin -f - << EOF
apiVersion: v1
kind: ServiceAccount
metadata:
  name: httpbin
---
apiVersion: v1
kind: Service
metadata:
  name: httpbin
  labels:
    app: httpbin
    service: httpbin
spec:
  ports:
  - name: http
    port: 14001
    targetPort: 80
  selector:
    app: httpbin
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
  template:
    metadata:
      labels:
        app: httpbin
    spec:
      serviceAccountName: httpbin
      containers:
      - image: kennethreitz/httpbin
        imagePullPolicy: IfNotPresent
        name: httpbin
        ports:
        - containerPort: 80
EOF

Create ingress:

kubectl apply -f - << EOF
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: httpbin-ingress
  namespace: httpbin
spec:
  ingressClassName: nginx
  rules:
  - http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: httpbin
            port:
              number: 14001
EOF

Curl

This works correctly (<IP_ADDRESS> is ingress controller IP):
curl <IP_ADDRESS>

This does NOT work (but should work):
$ curl -v <IP_ADDRESS>/get
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80(#0)
> GET /get HTTP/1.1
> Host: <IP_ADDRESS>
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Tue, 04 May 2021 20:24:18 GMT
< Content-Length: 0
< Connection: keep-alive
<
* Connection #0 to host <IP_ADDRESS> left intact

How was OSM installed?:
Using osm cli:
osm install

Anything else we need to know?:
Logs from envoy sidecar of httpbin pod:
{"bytes_received":0,"protocol":"HTTP/1.1","x_forwarded_for":"<IP_ADDRESS>","user_agent":"curl/7.58.0","requested_server_name":null,"start_time":"2021-05-04T20:15:38.772Z","duration":0,"upstream_cluster":null,"bytes_sent":0,"upstream_host":null,"authority":"<IP_ADDRESS>:80","time_to_first_byte":null,"method":"GET","request_id":"091398d96c15fff7d7ac6d98413de6ac","response_code":404,"response_flags":"NR","upstream_service_time":null,"response_code_details":"route_not_found","path":"/get"}

Ingress controller logs:
<IP_ADDRESS> - - [04/May/2021:20:15:38 +0000] "GET /get HTTP/1.1" 404 0 "-" "curl/7.58.0" 82 0.002 [httpbin-httpbin-14001] [] <IP_ADDRESS>:80 0 0.004 404 091398d96c15fff7d7ac6d98413de6ac

Environment:

OSM version (use osm version):

Version: v0.8.3; Commit: 6fa4a5791cd70ec5eb2f0abaa0c09b7993c2fd34; Date: 2021-04-20-21:44

Kubernetes version (use kubectl version):

k3d version v4.4.0
k3s version v1.20.4-k3s1 (default)

Size of cluster (number of worker nodes in the cluster):

1 master, 2 worker

Others:

Thanks @micya for reporting this, I'll look into this.

Hey @micya, there are 2 reasons why this won't work:

Ingress pathType matching is not supported in OSM v0.8.x, this feature is only available to use in the next release of OSM v0.9.0
There is a caveat with how Envoy performs regex matching on certain paths, such as the wildcard prefix /. https://github.com/openservicemesh/osm/pull/3296 should address this.

So to be able to use Ingress V1 and a wildcard path / whose pathType=Prefix, one needs to use v0.9.0 (release date is TBD).

The codebase on main branch should have this fixed:
$ kubectl apply -f - << EOF
> apiVersion: networking.k8s.io/v1
> kind: Ingress
> metadata:
>   name: httpbin-ingress
>   namespace: httpbin
> spec:
>   ingressClassName: nginx
>   rules:
>   - http:
>       paths:
>       - path: /
>         pathType: Prefix
>         backend:
>           service:
>             name: httpbin
>             port:
>               number: 14001
> EOF
ingress.networking.k8s.io/httpbin-ingress configured
$
$ curl -I http://<IP_ADDRESS>/status/200
HTTP/1.1 200 OK
Date: Wed, 05 May 2021 01:07:09 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 0
Connection: keep-alive
access-control-allow-origin: *
access-control-allow-credentials: true
x-envoy-upstream-service-time: 1

$ curl -I http://<IP_ADDRESS>/get
HTTP/1.1 200 OK
Date: Wed, 05 May 2021 01:07:14 GMT
Content-Type: application/json
Content-Length: 363
Connection: keep-alive
access-control-allow-origin: *
access-control-allow-credentials: true
x-envoy-upstream-service-time: 2


Warn before committing to protected branches

It can be helpful to warn before committing to commonly protected branches like main, master, dev, release, etc.
The warning can contain these actions "Create a new branch", "Commit anyway", and "Don't show me again for this repository".

Related to 62665
I've been burned by this before, and have just been burned by it again now, so I went looking to see if this has been reported before and found this issue.
In today's case it was extremely fortunate that we had good knowledge of the changes, but this has potential to be extremely annoying/catastrophic. Looking at the history it seems that it ignores the protected branch that's on @github and uses some kind of forceful pushing mechanism to write to the main/master/trunk branch. Wondering if this could be changed as a short term fix to not be forceful and then a more eloquent solution, like the suggestion in the issue description or creating an array of protected branches in the settings or something.

Adding an array of branches names that should be protected to the workspace settings is a great idea.
Still, I would like to see a message that will allow me to create new branch instantly, skip the warning temporary, or disable the protection for this workspace or globally.
I agree that it should be balanced. It can be very annoying in some cases, like personal small projects that you want to commit the main branch directly, but to be protected when the repository defines protected branches.

Closing as duplicate of #148783.

Thanks @lszomoru ! Any reason why the older request that got enough votes (this one, mine) closed as duplicate of newer feature request that didn't get enough votes yet?
Why it was implement due to the new one and not this one?
I'm asking to understand if something is wrong with my request

@rhalaly, there was nothing wrong with the feature request that you have filed. Even though I labeled the issue when it was filed in January, I simply forgot about it when https://github.com/microsoft/vscode/issues/148783 was created so I have used that to track the implementation. I only remembered about this issue couple of days ago when a new comment was posted to it. Hope that answers your concerns.

Thanks @lszomoru!


Update plugin-mq-notifier.yml

I have gotten OK by Tomas Westling, my colleague at Axis Communication to maintain this plugin. Will continue to do so until he is back from parental leave. You can see the PR history that I have several changes in the plugin and I have been added as a collaborator on the team page.

Description
https://github.com/jenkinsci/mq-notifier-plugin
Submitter checklist for changing permissions
Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

@twestling Please confirm.


glob not finding files in pre-push hook

Hello, I'm having trouble getting this pre-push hook to detect files, specifically for the style command:
pre-push:
  parallel: true
  commands:
    javascript:
      files: git diff --name-only HEAD @{push}
      glob: "*.{ts,tsx,js,jsx}"
      run: npx eslint -- {files}
    styles:
      files: git diff --name-only HEAD @{push}
      glob: "*.{less,css}"
      run: npx stylelint -- {files}
    types:
      run: npm run type-check

When I manually run git diff --name-only HEAD @{push}, I see an expected .less file in the output. However, when I run ./node_modules/.bin/lefthook -v run styles, I see this output:
Lefthook v0.6.3
RUNNING HOOKS GROUP: styles

SUMMARY: (SKIP EMPTY)

Any idea why this may be? It seems like the glob is failing somehow. This is not a new file but rather modifying an existing file in the repo.

You need to run a hook level, like that:
./node_modules/.bin/lefthook -v run pre-push

Hi @Arkweid,
I get the same problem when running at the hook level. Here's some truncated output:
  EXECUTE > javascript
(SKIP. NO FILES FOR INSPECTING)

  EXECUTE > styles
(SKIP. NO FILES FOR INSPECTING)

SUMMARY: (done in 3.49 seconds)
✔  types

I also see this logged several times, hard to tell which step it's coming from but I believe it's styles:
Files before filters:
 []

Files after filters:
 []

Try this variants:
      files: git diff --name-only HEAD master
      glob: "*.{ts,tsx,js,jsx}"
      run: npx eslint -- {files}

      glob: "*.{ts,tsx,js,jsx}"
      run: npx eslint -- {push_files}

Closed. Open it again if you have more questions


Emmet kicks in when editing pure xml documents

VSCode Version: 1.45.0 and 1.46.0-insiders
OS Version: macOS Catalina 10.15.4

Steps to Reproduce:

Create an xml document. containing

<a>

</a>

Within the <a> tag, start typing a, emmet proposes a *ton of snippets.

Emmet should not contribute to xml completion with unrelated HTML bloat.

Does this issue occur when all extensions are disabled?: Yes

As the docs says:

Emmet abbreviation and snippet expansions are enabled by default in html, haml, pug, slim, jsx, xml, xsl, css, scss, sass, less and stylus files, as well as any language that inherits from any of the above like handlebars and php.

You can disable emmet for xml in settings.json like so
"emmet.excludeLanguages": [
    "xml"
]

Read here for more info.

I forgot that workaround existed.
I still think that XML, even when Emmet is enabled, shouldn't output HTML abbreviations, though, which it still does.


exp/orderbook: Include empty paths in path finding response

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
Fixes https://github.com/stellar/go/issues/4131
If the source asset is included in the list of destination assets we will include the empty path in the path finding response. For example:
If we receive the following /paths/strict-send query:
destination_assets=native,BTC:GAUTUYY2THLF7SGITDFMXJVYH3LHDSMGEAKSBU267M2K7A3W543CKUEF

source_asset=BTC:GAUTUYY2THLF7SGITDFMXJVYH3LHDSMGEAKSBU267M2K7A3W543CKUEF

source_amount=0.0005953

We will include the following empty path in the response:
{
        "source_asset_type": "credit_alphanum4",
        "source_asset_code": "BTC",
        "source_asset_issuer": "GAUTUYY2THLF7SGITDFMXJVYH3LHDSMGEAKSBU267M2K7A3W543CKUEF",
        "source_amount": "0.0005953",
        "destination_asset_type": "credit_alphanum4",
        "destination_asset_code": "BTC",
        "destination_asset_issuer": "GAUTUYY2THLF7SGITDFMXJVYH3LHDSMGEAKSBU267M2K7A3W543CKUEF",
        "destination_amount": "0.0005953",
        "path": []
      }

Why
Simple payments (e.g. payments where an asset is transferred from one account to another without any conversions into another asset) are also valid path payments. Because the path finding endpoint is used to construct path payments we should not omit paths corresponding to simple payments.
Known limitations
[N/A]

Will this also work when a destination_account is given (instead of the list of destination assets) and vice versa with a given source_account (instead of source_assets)?

@marcinx yes, it should work. the destination account is converted into a list of assets before reaching this code.


Please make ui.loadFontFromList return bool to indicate success/failure, like io.Socket.setOption() does

Hello,
Problem:
How do i know that the font loading completed successfully, or failed.
Solution:
dart:ui.loadFontFromList should return Future<bool> if the operation was completed successfully, and not Future<void>, which seems like a blackbox
Related:
The dart:io.Socket.setOption function, "Returns true if the option was set successfully, false otherwise.",
deceleration of which is bool setOption(SocketOption option, bool enabled);,
thanking you...

From feature request triage: This requires investigation. It's not clear that the necessary information is available at the time that the Future completes.


Internship: Update images of interns

Replaced placeholders with actual images.
TEST=manual

Checked website to see if images displayed

Change-Id: I466525a6a925d4cf1aac975633c042c56cec5aa4

Code Review comments can be found at https://gerrithub.io/q/I466525a6a925d4cf1aac975633c042c56cec5aa4


🐛 BUG: Some labelled buttons are not rectangular

What operating system are you using?
Mac
Describe the Bug
Some labelled buttons on the site are completely oval in shape.
I believe this was not intended since this is not a pattern I have seen elsewhere. Buttons with labels are almost always rectangular, hence that is what I expect from these buttons as well.
Below are the two buttons I noticed, though there may be more.

戻る button in LivestreamDetailsModal
https://github.com/sugar-cat7/vspo-portal/assets/155891765/a403927c-3985-4ddf-b202-6672a206c916
設定 button in side nav
Please provide any relevant error logs
No response

This is not intentional. Let's make it a rectangle.

I'll take this one. Will also try to check all the labelled buttons in the website


fixes order_by_u64_field and order_by_fast_field should allow sorting in ascending order #1676

Codecov Report

Merging #2111 (7d3fd5d) into main (3fef052) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff            @@
##             main    #2111    +/-   ##
========================================
  Coverage   94.39%   94.39%
========================================
  Files         321      321
  Lines       60650    60792   +142
========================================
+ Hits        57248    57385   +137
- Misses       3402     3407     +5

Impacted Files
Coverage Δ

src/collector/top_score_collector.rs
98.02% <100.00%> (+0.15%)
:arrow_up:

... and 14 files with indirect coverage changes


add "invite me to the organisation" label

@sairish2001 please add (create)  invite me to the organisation Label as it is required for workflow of invitation.yml

@satyampgt4 Thanks, Will do👍🏻

Is this label auto added to the template?


attitude_estimator_q added

Added simple quaternion-based attitude estimator with gyro bias estimation and acceleration compensation. Idea is similar to MARG, implemented using mathlib quaternions. Tested in HIL. Need real flight tests.
CPU consumption: 3.2% (vs 18.6% for attitude_estimator_ekf).
TODO

Tune stack size
Auto declination detection
TESTING
Maybe some more parameters tuning, current parameters tuned for not too sensitive magnetometer and relatively fast gyro bias compensation (stabilization time is ~30s).

Awesome! Beautifully compact! Looking forward to fly this one.

Short demo: all corrections disabled after gyro bias stabilized - stable enough even on strong rotations. (Only problems with yaw - strong magnetic interference).
https://www.dropbox.com/s/19ca6196jt5k7wj/IMG_1522.MOV?dl=0

Nice demo, really nice results!

@LorenzMeier, @tumbili, any comments why this was changed? https://github.com/PX4/Firmware/commit/a252f4a99111597babd447c962208287e3f244ba Old code was not working?

Looks like Quaternion.rotate was used ONLY in test_math... Now all tests passed.

Everything is ready, tested in room, without GPS and in hIL. Need to test more magnetic declination detection and real flight performance.

@DrTon on https://github.com/PX4/Firmware/commit/a252f4a99111597babd447c962208287e3f244ba: The method suffers from corner cases which can lead to wrong conversions (we proved this with an unit test). The method implemented after the change follows Shoemake, Quaternions, http://www.cs.ucr.edu/~vbz/resources/quatut.pdf

Good for flight tests?

Sure! Already flown without GPS indoor :) Going to test today outside. BTW need to think about handling bad/no accel/mag data. I think the estimator should still allow to land in manual even without gyro/accel data, but need to switch to CRITICAL state in this case to notify user.

Regarding gyro / accel data: I have worked out what we would need to look at to catch the kind of failures we've seen in the past, and I would propose to implement a C++ class to do online signal analysis and eventually voting as part of the estimation and control library. This way we can augment all estimators with the same functionality. The first three things we could do are:

Simple timeout logic
Look at the signal RMS. If the gyro fails like in Damiano's case the RMS will drop sharply because all noise is gone
Feed back the estimator's prediction of the gyro / accel value and use it together with the 2nd gyro / accel to do a (safe) 3-vote system. Not perfect, but much more reliably than magic numbers / thresholds.

Yes, agree with all 3 points! Will think how to implement it better.

Just tested in flight, no issues noticed!

@DrTon I'll ask more people to do some validation testing and then I'm ok to default to it. @tumbili Could you add this to your flight test list please?

Can you help me duplicate the HIL testing you did here?

Yes I can. You need to setup jMAVSim first.

I had an issue with java.  In your instructions, you use pacman to get the java libraries, but this didn't work, and installing pacman didn't work yet either.  I'm using ubuntu 14.04 and already have java-1.7.0-openjdk-amd64 on my system, but not the libraries you refer to in https://github.com/DrTon/jMAVSim (j3dcore).
/usr/lib/jvm/java-1.7.0-openjdk-amd64$ ls jre/lib/amd64
headless             libinstrument.so libjawt.so libsaproc.so
IcedTeaPlugin.so libj2gss.so libjdwp.so libsctp.so
jli                  libj2krb5.so libjsdt.so libsplashscreen.so
jvm.cfg              libj2pcsc.so libjsig.so libunpack.so
jvm.cfg-default      libj2pkcs11.so libjsoundalsa.so libverify.so
libattach.so         libjaas_unix.so      libjsound.so libzip.so
libawt.so            libjava_crw_demo.so  libmanagement.so  server
libdt_socket.so      libjavagtk.so        libmlib_image.so  xawt
libfontmanager.so libjavajpeg.so libnet.so
libhprof.so libjavalcms.so libnio.so
libicedtea-sound.so libjava.so libnpt.so
/usr/lib/jvm/java-1.7.0-openjdk-amd64$ ls jre/lib/ext
dnsns.jar          java-atk-wrapper.jar  localedata.jar       sunpkcs11.jar
icedtea-sound.jar  libatk-wrapper.so     sunjce_provider.jar  zipfs.jar

OK I have jMAVSim running.  I should be ok from here.  Thanks.
On Tue, Apr 21, 2015 at 8:32 AM, Anton Babushkin<EMAIL_ADDRESS>wrote:

Yes I can. You need to setup jMAVSim first.
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/pull/2013#issuecomment-94840014.

@DrTon @LorenzMeier I gave this a try today, seems to be working fine. Nice work Anton!

Good, thanks for testing :)
Found some potential problems to fix:

Parameters collision with attitude_estimator_ekf, if don't compile old one everything is ok
Argument here may be > 1 and cause NaN, even for "normalized" quaternion (rounding errors etc.): https://github.com/PX4/Firmware/pull/2013/files#diff-68f310e3bd613da3feab7dca0fff9045R220
We use assumption that all sensors updated on each step, but this may be not true if e.g. mag is too slow. Need to do the same trick as in inav: store correction on each mag/accel update and apply on each time step. This should improve accuracy for long and fast yaw rotations.

What was the update rate of the estimator in the video demo?

Default, 250Hz

F450 quad felt very good with this estimator, log: https://copy.com/NyYxVPkdQLXYVYMJ

Awesome, mainlining!

As always, many thanks Anton for this great contribution. The code is really pretty!

@LorenzMeier might want to give devs a heads-up that this changes the default attitude estimator?
What's the best mechanism for that? I noticed that the commit description just says "merged PR ... att_estimator_q added", so it may not be apparent to all that this changes the default att estimator.

Is it worth putting a note in the documentation at the top of the source file that this is based of MARG?

I'm not so sure. The concept you are referring to is used in any of the estimators I've seen in the last three years.

Perhaps this is a subject for another issue, but is it possible to add support for an external mocap attitude update? This would probably be useful to prevent drift as it would allow for external updates based on either actual mocap measurements or estimates from more sophisticated algorithms running on companion computers.

@mrkris13 Extend this : #2667


Handle nested transactions in Rails 5

Currently, the setup added to the spec in the PR causes a NoMethodError: 'undefined method add_to_transaction' when running against ActiveRecord 5.
This PR adds a naive fix, which makes Que compatible with ActiveRecord 5. It's not the best possible solution (which is described in a comment), but it removes the blocker for anyone moving to Rails 5.

@chanks - would be awesome if you could take a quick look over this now Rails 5 is out. Am I right that calling wake! here would be a nice to have, and needn't be a blocker for people updating?

I'll be able to look at it tomorrow, Friday is my open source day at work.
On Thursday, June 30, 2016, Grey Baker<EMAIL_ADDRESS>wrote:

@chanks https://github.com/chanks - would be awesome if you could take
a quick look over this now Rails 5 is out. Am I right that calling wake!
here would be a nice to have, and needn't be a blocker for people updating?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chanks/que/pull/160#issuecomment-229824679, or mute
the thread
https://github.com/notifications/unsubscribe/AASUGkWjfifo9zzu6k7HMGIwTYH-Wx82ks5qRF58gaJpZM4JATpX
.

Looked at it, yeah, you're right, calling wake! would be a nice-to-have, but I don't think it's strictly necessary. And I'd worry about maintaining backward compatibility with older versions of Rails with more invasive changes.
Will merge and release a new minor version.


Add version: snakefoot.snaketail version 1.9.7

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116608&drop=dogfoodAlpha

Close with reason: Duplicate; Existing package has correct ARP


Windows Virtual Desktop is now Azure Virtual Desktop

[Enter feedback here]
Please change the title because the solution name is now Azure Virtual Desktop
https://azure.microsoft.com/en-us/blog/azure-virtual-desktop-the-desktop-and-app-virtualization-platform-for-the-hybrid-workplace/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d22ea47-5aea-b8cc-616c-081f09a22193
Version Independent ID: 9dd14a9a-5abb-8635-d4b9-9d793fb549b9
Content: Using Windows Virtual Desktop with Azure NetApp Files
Content Source: articles/azure-netapp-files/solutions-windows-virtual-desktop.md
Service: azure-netapp-files
GitHub Login: @b-juche
Microsoft Alias: b-juche

Thanks, @mmoioli.  Making the name change through PR#168015
(https://github.com/MicrosoftDocs/azure-docs-pr/pull/168015 )

PR#168015 has been merged for publishing.
#please-close


Base64 feature branch integration

What does this PR do?
Merges the base64 feature branch into develop
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1597 (e3addc0) into develop (bf9b6c3) will increase coverage by 0.05%.
Report is 8 commits behind head on develop.
The diff coverage is 88.27%.

@@             Coverage Diff             @@
##           develop    #1597      +/-   ##
===========================================
+ Coverage    83.58%   83.63%   +0.05%
===========================================
  Files          443      451       +8
  Lines        15122    15550     +428
  Branches      2264     2317      +53
===========================================
+ Hits         12639    13005     +366
- Misses        1885     1923      +38
- Partials       598      622      +24

Files Changed
Coverage Δ

...sionreplay/material/MaskInputTabWireframeMapper.kt
0.00% <ø> (ø)

...d/sessionreplay/material/MaskTabWireframeMapper.kt
100.00% <ø> (ø)

...replay/internal/recorder/wrappers/BitmapWrapper.kt
20.00% <ø> (ø)

...ndroid/sessionreplay/internal/utils/Base64Utils.kt
66.67% <0.00%> (ø)

...android/sessionreplay/internal/utils/CacheUtils.kt
15.79% <15.79%> (ø)

...id/sessionreplay/internal/recorder/base64/Cache.kt
25.00% <25.00%> (ø)

...eplay/internal/recorder/base64/BitmapPoolHelper.kt
62.50% <62.50%> (ø)

...nreplay/internal/recorder/base64/Base64LRUCache.kt
76.74% <76.74%> (ø)

...ionreplay/internal/recorder/mapper/ButtonMapper.kt
87.50% <80.00%> (-12.50%)
:arrow_down:

...eplay/internal/recorder/base64/Base64Serializer.kt
84.52% <85.45%> (-5.27%)
:arrow_down:

... and 15 more

... and 22 files with indirect coverage changes


Remove: SAPIEN.PowerShellStudio version <IP_ADDRESS>

Requires a specific user agent to download now

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Microsoft Reviewers: Open in CodeFlow

URL: https://sapien-sps.s3.amazonaws.com/SPS23Setup_5.8.230_091123_x64.exe
Response status code does not indicate success: 403 (Forbidden).
(Automated message - build 830)


[Bug] Tab completion issue with Copilot

Report summary
Does this issue occur when all extensions are disabled?:
I'm not sure how to use --disable-extensions while still enabling Copilot?

Running the Extension Bisect (two times) always return that the issue is copilot, or at least the combination of extensions never solves the tab issue

VS Code Version: 1.60.0-insider | 7c25c174726ab969db3f99058cdf24bcfae1cfbe
OS Version: Darwin x64 19.6.0 (Catalina)

Report
Hi,
As discussed in #127797 I have the same issue, but it is not related to Emmet.
And running bisect I could not found if another extension was causing this.
@hediet You told me to tag you so here we are, I think @bala0406 have the same issue, do not hesitate to post details here.
Thanks

Running the Extension Bisect (two times) always return that the issue is copilot, or at least the combination of extensions never solves the tab issue

Please disable all extensions and only enable the Copilot extension.
A gif would also be very helpful, so I can try to reproduce!

Please disable all extensions and only enable the Copilot extension.

Is there an easy way to enable all but one? Cf:

I'm not sure how to use --disable-extensions while still enabling Copilot?

The issue still persists with all the extensions disabled except co-pilot.

I have the same issue. It's showing me the recommendation but there's no shortcut I can enter to actually accept that change. I tried adding/changing the shortcuts that show up under "copilot" in keyboard shortcuts but other than "Open Copilot" (which opens up a side bar, with the recommendations) none of the others work.

Is there an easy way to enable all but one? Cf:

You can disable all extensions:

And then just enable Copilot.

This looks like there is another extension active that shows "Expected indented block", I guess Error Lens.

Also, one more associated isuue, when github co-pilot is active, brackets are not auto-closing. Tried setting "editor.autoClosingBrackets": "always", but still brackets don't close automatically.

This looks like there is another extension active that shows "Expected indented block", I guess Error Lens.

Yes!! Enabling only Python and Copilot, works.
And I actually thought: How can someone know what keybindings an addon sets?... I then looked at my keybindings.... There is an extension column (BTW having a way to sort would be nice) and the culprit is...... 🥁
TabOut (marketlink)
I feel so dumb. In my defense, I had no idea about this extension 😅
I'm leaving it open for @bala0406 I think you can track it down as I did.

Closing he also found his issue (Windows Default Keybindings)

Also, one more associated isuue, when github co-pilot is active, brackets are not auto-closing. Tried setting "editor.autoClosingBrackets": "always", but still brackets don't close automatically.

This should be a similar issue, an extension that overrides the behavior somehow, you should open a new issue!

This should be a similar issue, an extension that overrides the behavior somehow, you should open a new issue!

This is copilot and a known issue that is already being tracked.

This should be a similar issue, an extension that overrides the behavior somehow, you should open a new issue!

This is copilot and a known issue that is already being tracked.

Privately or do you have an issue #?

I think it is privately tracked in the Copilot org, as it is not an issue related to VS Code.
VS Code has everything that is needed to fix that issue on Copilot's side.

For me it was editing editor.action.inlineSuggest.commit in the key bindings


[release-1.24] Disable DNS jitter to 0

Manual cherrypick required.
#53760 failed to apply on top of branch "release-1.24":
Applying: Set default DNS jitter to 0
Applying: Undo DNS jitter
Using index info to reconstruct a base tree...
M	pilot/pkg/features/pilot.go
M	pilot/pkg/networking/core/cluster_builder.go
M	pilot/pkg/networking/core/cluster_builder_test.go
Falling back to patching base and 3-way merge...
Removing releasenotes/notes/52877.yaml
Auto-merging pilot/pkg/networking/core/cluster_builder_test.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/cluster_builder_test.go
Auto-merging pilot/pkg/networking/core/cluster_builder.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/cluster_builder.go
Auto-merging pilot/pkg/features/pilot.go
CONFLICT (content): Merge conflict in pilot/pkg/features/pilot.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Undo DNS jitter

Closed by #53776


breaking with react-virtualized

Hi,
whenever I try to update react-virtualized data, it throws an error
Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

error stack
VM7842:1 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at eval (eval at evaluate (:117:21), <anonymous>:1:9)
    at Object.removeResizeListener (http://l.housing.com:4000/searchView.js:4972:7)
    at AutoSizer.componentWillUnmount (http://l.housing.com:4000/searchView.js:2366:35)
    at unmountComponent (http://l.housing.com:4000/vendor.js:4244:55)
    at unmountComponent (http://l.housing.com:4000/vendor.js:4247:20)
    at recollectNodeTree (http://l.housing.com:4000/vendor.js:4112:24)
    at removeOrphanedChildren (http://l.housing.com:4000/vendor.js:4108:63)
    at innerDiffNode (http://l.housing.com:4000/vendor.js:4105:32)
    at idiff (http://l.housing.com:4000/vendor.js:4055:279)
    at innerDiffNode (http://l.housing.com:4000/vendor.js:4101:21)

. I set up a plunker of react-virtualized with preact and its working fine on first render. This is mainly an issue with preact-compat I guess.

cc: @bvaughn - in case anything can be done from your side. This error doesn't occur if I don't change the height of the container.

@bvaughn - curious if there's anything funky being done on your end relating to height measurement?

Ah, I have an idea what is causing this. Preact's diff removes elements it didn't create, React's doesn't. I'll look into a reliable way of ignoring unknown children!

Hey @ritz078
I created a Plnkr a few days back that showed Preact and react-virtualized working together. Have you seen it, by chance?
https://embed.plnkr.co/48amzdx0Wkv6pja4j99j/
In Facebook onboarding all day without a laptop FYI so my responses will be few and far between unfortunately.

saw it. I don't think there's any error in react-virtualized. Its a preact-compat issue. Just tagged you incase anyone else faces the same issue with RV.
btw I didn't expect your reply as I was familiar that today's your 1st day at fb. 😄

@developit let me know if there's is any immediate fix.

@ritz078 I'm thinking this might be the same issue as (and thus solved by) developit/preact#373

Actually it doesn't solve the issue.

Ah right, I forgot this was more related to removal of non-owned nodes. Sorry about that!

Pretty sure I have a way to make this work. Will ping you about it once I have a beta ready.

Nice!

<EMAIL_ADDRESS>(beta) should fix this.

I had a similar bug with Mapbox GL. Mapbox's DOM was getting removed. Updating to<EMAIL_ADDRESS>fixed this.

Awesome. Yeah this change should fix a ton of those little things, it's been a long time coming.

Sadly the issue remains. Actually I had forked react-virtualized and commented the line that caused error so I was getting no error but with RV it still exists. using v7.0.3

Hey @ritz078,
I really want RV and Preact to play nice out of the box. If there's a backwards compatible patch I could apply on the RV side to help, let me know.
If you guys are still on the 7.0 version, I'm willing to make one last 7.x bugfix release even.

we are on 8. You can see the line creating the error.

I removed it and everything worked fine but I don't think that's an error on RV side.

Oh! Sorry. I mistook your 7.0.3 reference to be about RV. 🙇
Yeah, I see the error but I don't now the implications of commenting out that line. (Admittedly, I haven't been following along super closely because I've been distracted with other things recently.) If there's a safe way to handle/catch/prevent that error- I'd be willing to consider patching it on the RV side.
If Preact can handle it, better still. 😁

Is the auto size thing part of RV, or something else?

It started off as a for of sdecima/javascript-detect-element-resize (because that util wasn't really packaged up to be used by RV) but since then I've added several performance optimizations to it- mostly to prevent unnecessary reflows.

Maybe I should package it up as its own standalone lib that RV specifies a dependency to.

Could do. I only mentioned it because I tried to reproduce this issue and I felt like I was missing that piece. I couldn't get RV to break :(

I couldn't get RV to break - Jason Miller

To Twitter! 😂
On Nov 19, 2016 2:55 PM, "Jason Miller"<EMAIL_ADDRESS>wrote:

Could do. I only mentioned it because I tried to reproduce this issue and
I felt like I was missing that piece. I couldn't get RV to break :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-compat/issues/228#issuecomment-261745295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABznXKgDK5mdDduv1TZjJvCQlEaY67Uks5q_35DgaJpZM4KY5HA
.

I tried on plunker but was unable to reproduce. Commenting that line is helping but will see if there are any perf issues. There aren't any functional issues though.

Unfortunately, I'm still seeing this issue with preact 7.1.0, preact-compat 3.9.3 and react-virtualized 8.7.0 (using AutoSizer exclusively).
Using the webpack alias method to swap in preact:
alias: {
  'react': 'preact-compat',
  'react-dom': 'preact-compat',
  'react-addons-css-transition-group': 'preact-css-transition-group',
  'react-addons-shallow-compare': 'shallow-compare'
}

I wonder if AutoSizer is actually moving the element? That would be an issue for sure..

AutoSizer is built on top of a modified (for performance) version of the detect-element-resize library. You can see the DOM manipulation it's doing here.
Let me know if you'd like to chat about it.

So continuing here. this fixes it.
Any other error after removing this ? Not so far. Have been testing internally since more than a month.
Perf issues ? Doesn't seem so. (but maybe I missed something ? monitoring.)

Oh man! If that's the only error- let's get that commit merged into RV and I'll put out a point release.
Looks like you guys are based off of 8.2.0. RV main is on 8.9.0 now so the fix would go out as 8.9.1 - but if it's important for you to stay on 8.2.0 I could release an 8.2.1 fix as well.

We shouldn't have any problem upgrading. Will get this tested by tomorrow or maybe you can do a pre-release 8.9.1 beta and I can test it.

brian that technique for unsetting the element reference is my favorite

FYI this change has been applied to react-virtualized with 78910b6 and released as 8.11.0.

Think we can close this issue now?

I think we can. 👏 we are upgrading now and will comment here if something doesn't work.

Fantastic. Best of luck
On Jan 16, 2017 10:51 PM, "Ritesh Kumar"<EMAIL_ADDRESS>wrote:

I think we can. 👏 we are upgrading now and will comment here if
something doesn't work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-compat/issues/228#issuecomment-273036024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABznTdc03eHQBbAYyblswXYDJca-fVJks5rTGUCgaJpZM4KY5HA
.

you guys are the best


Added missing type cast for ordernumbers

1. Why is this change necessary?
Hooking into sOrder::sSaveOrder and reading the return value gives you different types depending on the fact whether there are ordernumber filters present or not.
2. What does this change do, exactly?
Adds a cast to match the return type declared in the phpdocs.
3. Describe each step to reproduce the issue or behaviour.

Have a subscriber:

<?php declare (strict_types=1);
/// ...
    public static function getSubscribedEvents()
    {
        return [
            'sOrder::sSaveOrder::after' => 'onSaveOrder',
        ];
    }

    public function onSaveOrder(\Enlight_Hook_HookArgs $args)
    {
        /** @var string $ordernumber */
        $ordernumber = $args->getReturn();
        $this->processOrdernumber($ordernumber);
    }

    public function processOrdernumber(string $ordernumber)
    {
    }

This will break at calling processOrdernumber as the variable was not a string as the number incrementor returns an int
Have any Shopware_Modules_Order_GetOrdernumber_FilterOrdernumber subscriber that returns the number as string
Now the call processOrdernumber does not break

4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

5. Bonus
The quickfix is the following subscriber:
<?php
// ...
    public static function getSubscribedEvents()
    {
        return [
            'Shopware_Modules_Order_GetOrdernumber_FilterOrdernumber' => 'makeOrdernumberOfTypeString',
        ];
    }

    public function makeOrdernumberOfTypeString(Enlight_Event_EventArgs $args)
    {
        return (string) $args->getReturn();
    }

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23686
Please use this issue to track the state of your pull request.

Hi @JoshuaBehrens,
since this might actually be a small break, we'll move the PR to the 5.6 branch internally.

I didn't expect it to be breaking but I understand that I change types here. Thanks for taking this intense rebase on your side :grin:

Thanks for your Contribution! :blue_heart:


Update request: yubikey-manager-qt (arch: linux) → yubikey-manager-qt (arch: linux, darwin)

It's not that the package is out-of-date but it's that it doesn't support the macOS architectures.
Precompiled macOS binaries are on the same releases page that holds the source code this nix package grabs to compile for Linux.
(I just started using Nix and if I knew how to make this package support multi-arch I'd attach a PR to this issue, sorry, maybe soon though!)
EDIT: Link to package definition in nixpkgs.

Package name: yubikey-manager-qt
Latest released version: 1.2.5

Current version on the unstable channel: 1.2.5
Current version on the stable/release channel: 1.2.5
[x] Checked the nixpkgs pull requests

Notify maintainers
@avdv (maintainer, last commit 4 years ago), @ryantm (his robot last touched the file most recently)

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

What's the error you get after replacing platforms.linux with platforms.unix?

@avdv (maintainer, last commit 4 years ago), @ryantm (his robot last touched the file most recently)

The package definitely needs a new maintainer. Volunteers welcome.


Unique paths

Work in progress:
Enforce all paths within a given parent to be unique.
Closes #7

Let's merge this as it does the right thing client side, and then enforce it in the server side handler later


remove React.Children.only() from Broadcast

It seems like there is no reason why Broadcast can't accept more than one child

That may be the case in React 16 (still need to test it) but in React 15 a component is only allowed to return a single element so if you give it multiple children this will be a problem.

Ah, you would need to introduce an extra wrapper. Makes sense if you don't want to force a particular wrapper tag although it makes it feel a little less at home in normal JSX usage.

Is there a reason Issues are disabled on this repo?


Use of debug as a bit mask?

The debug value that gets propagated to BinReader._debug ends up being used in bit operations (e.g. if self._debug & 0x02:). Meanwhile cli.py treats debug as a boolean. This leads to some unexpected behaviour. For example, -d 4 on the command line results in less debugging information than -d 3. It looks to me like there are effectively three different debugging paths controlled by the same variable:

top level debugging output when debug != 0
some internal debugging when debug & 0x1
field debugging when debug & 0x2

Is this intentional?
Related to https://github.com/openjournals/joss-reviews/issues/766.

Yes, this is intentional, but I can imagine it is a bit confusing. I'll add a guard for invalid debug levels and some documentation to explain the different levels.


feat(#174): refactor 'replaceConstructors' method and add XmlProgram

Add XmlProgram class and refactor replaaceConstructors method.
Closes: #174.

History:

feat(#174): add XmlProgram class
feat(#174): move findClass method into XmlProgram
feat(#174): remove puzzle for 174 issue
feat(#174): use XmlProgram in XmlBytecode
feat(#174): remove redundant code from XmlClass
feat(#174): return XmlProgram copy when set top level class
feat(#174): add more puzzles

PR-Codex overview
This PR focuses on refactoring the code related to XMIR representation in the project.
Detailed summary

Introduced a new class XmlProgram to handle XMIR programs.
Replaced the usage of XmlClass with XmlProgram in various places.
Simplified and optimized the code related to finding and replacing constructors in XMIR programs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here


missing handlers, what's next?

I was intrigued when I read that you were using push->pull and pub->sub in order to move a request/response from the web server to the handler and back. I've looked at the code and I was sufficiently impressed. (non of which is a bug).
I'm hoping that you have a novel approach to solving this particular problem that will arise... and possibly someone who knows will write a test case.
SCENARIO:
there is a web server. it spawns threads or processes with each incoming user-request and in turn issues a zmq connect() to the handler which has already been bind() as an endpoint.
Now say there are 40 instances of the handler.
Now say only half will actually start... so when the first 40 requests arrive at the web server, only half will be served and half with be blocked.
JUSTIFICATION:
The GUIDE says that a connect() will generate a valid connection even if the server providing the bind() is not currently running. Therefore, the transaction will be queued until the server arrives.
I'm going back into the code... could this be a flaw?

(see https://github.com/rbucker881/freelance_bug)

I'm not sure I understand...
In mongrel2 the webserver does bind, not the handler.
If you don't have a server running, the handler gets no requests (since all requests come from the server), so there is no issue.

So you have a mongrel2 setup. There is a server. That server makes
connections  number of handlers. The handlers bind to the server.
For example there are 3 handler instances and three connections from the
server.
However, one of the handlers does and never restarts.  What happens next?
According to ZMQ, depending on the HWM you could lose a minimum 1
transaction as it waits in the ZMQ queue.
/r
*
*
On Tue, Jan 31, 2012 at 6:32 PM, Jason Miller <
<EMAIL_ADDRESS>
wrote:

I'm not sure I understand...
In mongrel2 the webserver does bind, not the handler.
If you don't have a server running, the handler gets no requests (since
all requests come from the server), so there is no issue.

Reply to this email directly or view it on GitHub:
https://github.com/zedshaw/mongrel2/issues/101#issuecomment-3750558


Update migrations to add a new field isInternal to table accountIntegrations.

https://github.com/Shippable/pm/issues/9578

COmpleted.


Add a test that ensures RTs with spaceful IDs fail to validate?

See https://github.com/LD4P/sinopia/pull/201

Fixed by #471


Allow 'ninja -t compdb' accept targets

Fix #1544
Cherry-picked https://github.com/ninja-build/ninja/pull/1546 and addressed the comments.
May I have your code review @jhasse ? Thanks

This looks good to me, but will require @jhasse 's approval.
Can I ask you to add some regression test in misc/output_test.py for this feature though?

fwiw, i really like this feature and look forward to this PR being merged!
one obvious use case for C/C++ users is to produce the database consumed by clangd. It means i get more concise & relevant search hits when e.g. asking clangd for all references to some symbol x in some program foo.
it also means the CPU fans in my PC no longer go crazy as a consequence of clangd's attempt to background-index a large number of source files that i didn't even want to browse (because they don't participate in building the executable foo).
thank you, @csmoe!

side note (for anyone who, like me, only learned about the jq command recently): in addition to compile commands, -t compdb --target foo will produce entries for commands that don't translate C/C++ code to machine code (e.g. linker invocations, generation of header files, etc), so in case anyone wants to spare clangd from attempting to read object files, you could do something like:
ninja -t compdb --target foo | jq '[.[] | select( .command | test("/bin/clang.* -c"))]' > compile_commands.json

(or test("/bin/your_compiler_here.* -c")

ninja -t compdb --target foo | jq '[.[] | select( .command | test("/bin/clang.* -c"))]' > compile_commands.json

In some future PR, it might be nice if the compilation database format were extended to allow a field like "command_type" as in:
  { "directory": "/home/user/llvm/build",
    "command": "clang-cl.exe [args...] /c /o t.o t.cc",
    "command_type": "compile_CXX",
    "file": "t.cc" },

...which generator programs might communicate to Ninja in the form of a rule variable:
 rule some_cxx_rule
   command = clang-cl.exe [args...] /o $out /c $in
   command_type = compile_CXX
   description = Building CXX object $out

...so that our jq query would be a little more portable:
ninja -t compdb --target foo | jq '[.[] | select( .command_type | test("^compile_(CXX|C)$"))]' > compile_commands.json

(But again, this would be a separate PR, and afaict the current PR is complete.)

https://github.com/ninja-build/ninja/actions/runs/10105777720/job/27951482409?pr=2319 @jhasse sorry for bothering you here, this error seems not caused by my patches.

Would it be better to shift out arguments so that no flag is required for the targets list?
so instead of
-t compdb --target foo,bar
you would have
-t compdb foo bar
or if a flag is really necessary to break out of flag-only parsing, use syntax like in git
-t compdb -- foo bar
so they can be space separated instead of comma separated

Would it be better to shift out arguments so that no flag is required for the targets list?
so instead of
-t compdb --target foo,bar
you would have
-t compdb foo bar

Prior to the commits in this PR, the output of ninja -t compdb -h is:
usage: ninja -t compdb [options] [rules]

options:
  -x     expand @rspfile style response file invocations

so ninja -t compdb foo bar already means "emit every compile command that uses foo or bar", and we probably don't want to break that.

or if a flag is really necessary to break out of flag-only parsing, use syntax like in git
-t compdb -- foo bar
so they can be space separated instead of comma separated

i guess this would work:
ninja -t compdb [options] [rules] -- [targets]

if this is happening in a bash script, and if you've defined an array parameter where each element is the name of a target, then this alternative syntax might save users from learning how to join strings in bash:
ninja -t compdb --target $(targets=( $(cat $WORKSPACE/active-executables.txt)); echo $(IFS=','; echo "${targets[*]}"))

so, boiling down the above, it seems like the only open question is whether we want:

option 1 (same old command form, but new option for [options]):

ninja -t compdb --target TARGETS [rules]

...where TARGETS is a comma-separated list of names of targets;
or:

option 2 (new command form):

ninja -t compdb [options] [rules] [-- targets]

i prefer the first form (as already implemented), since the second form requires me to remember that -t compdb foo -- bar means "rule foo and target bar", as opposed to "target foo and rule bar".
@mcprat, @csmoe, what do you think?

minor nit: if we go with option 1 (--target TARGETS), can we change the spelling of the option to --targets (plural)? (I already accidentally used the plural form a couple times.)

in case we need more motivation to merge this PR: i just wrote a small extension for Telescope (which is pretty straightforward) that reads a compilation database and hands the list of all primary source files from that database over to Telescope.
For example, if i cd to the build directory produced by cmake for building ninja itself and then run:
ninja -t compdb --target ninja > compile_commands.json

...here's what i see when i invoke my Telescope extension:

For anyone starting to read the Ninja source code for the first time, this seems like a good starting point. (And as soon as i hit <enter> to load any source file in that list, clangd indexes all translation units named by the same compile_commands.json, and none of the translation units not named therein. This means that e.g. the LSP command to list all references to a symbol will include only search hits from the correct set of translation units.)
By contrast, when i use an IDE to load project files generated by cmake, it is not at all obvious which source files are linked into the executable in which i'm currently interested.
To me, this means that i'll have an easier time browsing a C/C++ program foo with  -t compdb --target foo and Telescope than i would with an IDE. And it's not because i've developed more muscle memory with these tools; it's because this set of tools is actually better!

I like ninja -t compdb --targets TARGETS [rules], @JamesWidman Are you interested to take over this pr? I might not always in radar.
Feel free to modify anything or recreate one, but preserve lkchen's contribution record, he completed the main part.

@JamesWidman Are you interested to take over this pr? I might not always in radar.

@csmoe sure! How should we proceed? (Does github's PR interface have something like a 'bequeath' button so that you can bequeath the PR to me, or should i open a new PR like you did, or...?)

github seems not support that, so create your pr😃


[FLINK-30271] Introduce Table.copy from dynamic options

At present, our processing of dynamic options is relatively independent. In FileStoreTableFactory, this is not conducive to other engines configuring dynamic options.
We should propose an interface on the Table, and dynamic options can be configured at any time.

👍 LGTM


update gdscript files

Add no_plugin_maps
undo ft maps
Improve/simplify gdscript syntax

I'll include this, thanks.


cloudCover inaccurate

Loving the work @alexander0042 - great service. I had one oddity lately: cloudCover in currently seems to flip from 0 to 1 randomly, and any number in between. This is for SE England, a country which spends most of its time under cloud. At the time, it was cloudy, probably near 80% coverage, but the API said 0. An hour later it flipped to 1. It's now 0.93, which seems accurate, but there's little confidence given the number seems to change so often. Is that a bug or an error from whoever you're scraping?
Lastly, how often does this figure update in currently?

Your location the API uses GFS/GEFS global models which update every six hours with the last run time being displayed in the flags section and isn't high resolution. The plan is to replace those models with the NBM model which should help improve things.
Similar issues have been posted before and is something that is on the roadmap to be implemented but there is no ETA on when it will be added. https://github.com/alexander0042/pirate-weather-ha/issues/64, https://github.com/alexander0042/pirate-weather-ha/issues/50 and https://github.com/alexander0042/pirate-weather-ha/issues/30
For your other question cloudCover is updated once per hour usually at around 30 minutes past the hour.

@alexander0042 Do you think adding in RAP data would be a good temporary solution until NBM gets integrated? From what I see RAP is pretty much just HRRR on a larger scale which includes parts of Europe and South America so it should be pretty quick to add.
Here's the link on AWS if you want to check it out https://registry.opendata.aws/noaa-rap/


Add screenshots to manifest.json

More context on this https://web.dev/add-manifest/#screenshots
Example:

I would love to work on designing the screenshots. I'll post an updates soon:)

I have designed a couple of screenshots. Lemme know if I need to make  any changes to the screenshots!

I have designed a couple of screenshots with 2 variants. I'll also make cards explaining each screenshot. Lemme know if I need to make any changes to the screenshots!

Looks good to me! I prefer the black phone variant since the background is white. Describing features in each screenshot would make it perfect. What do you guys think?

Description of each screenshot with both variants. I have described Excalidraw in a nutshell with the screenshots! Lemme know what you think!

I have made a few changes to the existing iteration along with a new variation, explaining the screenshots with Virgil.

I really like the first and second row. My personal favorite is the first row :)
What do you guys think?
CC:  @ad1992 @dwelle @lipis

closed via https://github.com/excalidraw/excalidraw/pull/3369


joystick controller

Closing in favour of a later PR with the finished interface

Closing in favour of a later PR with the finished interface


Simplify and fix the system tests

So here's a funny story.  You may notice, that this PR breaks the systems tests.  This is freaking fantastic for 2 reasons:

Holy cow, we can run system and sample tests on PRs now safely 🥂
In this case, the system tests are failing because I fixed the glitch.

Turns out, there was some code in here that was causing certain system tests to be skipped when credentials weren't available.  This was masking actual system test failures, as these were always skipped in CI.
@googleapis/node-team @googleapis/yoshi-nodejs even though this breaks the tests, I think we should merge it since it fixes the hidden failures. Then we should follow up with an actual fix.
What are others thoughts here?

I'm fine but please at least fix gts check in lint before merging :)


[bug]  - Checkbox checkable on disabled when not in a tile group

Describe the bug
When a rh-tile is disabled and has a checkbox, we can still toggle the checkbox through a click event.  When in a tile group, it appears the checkbox is actually disabled
Which Component?
rh-tile
Steps to reproduce

Go to the checkable tile demo
Click on the disabled tile
The checkbox will be checked even though it's disabled

Expected behaviour
The checkbox should not be able to be toggled while disabled when not in a tile group
Screenshots

Element HTML
<rh-tile checkable bleed disabled>

Headline

    Lorem ipsum dolor sit amet, consectetur adipiscing elit.

Suspendisse eu turpis elementum

  </rh-tile>

Operating System (OS)
macOS
Browser
No response
More browser information

Chrome Version 118.0.5993.88 (Official Build) (arm64)

Additional Info
No response

https://deploy-preview-1302--red-hat-design-system.netlify.app/elements/tile/demo/checkable/

#1302 will fix this


Add renovate

add self hosted renovate

renovatebot can't use allowedPostUpgradeCommands, so don't use it
renovatebot cannot be versioning unless it is self-hosted

だるいので一旦却下


PerformanceFix: Deactivate trace and debug levels at compile time in …

…release
Deactivating the logs at compile-time remove many cpu cycles

The PR is good, but by playing a bit with it it turns out that there are some un-anticipated compilation issue: when changing the log level Cargo will not always re-compile due to caching rules with features. That causes some really non-intuitive outcome such as no logs when there should be, or too many logs where they shouldn't.
I implemented another option, compile-time checking, in another PR: #351. I will close this PR in favor of the other, as it achieves a similar result without the re-compilation issues.


Recent Files Menu

This will list the most recently loaded files - whether assemblies or projects - most recent first. Selecting a file opens it in the Gui.

Currently, this is working for assemblies. For projects, the file name is saved but it fails to open correctly from recent files menu. However, it can be opened successfully using File | Open menu.

Now working provided that the project file extensions are installed.


Error when using the "show -all" command

Hi,
Thank you for this tool!
When I use the command show -all I get the below error. The root cause seems to be that the earlier enumeration never produced the file groups.csv:

Great! Using the dev branch works.
I have a question about the mssql command. I can execute it and get the query to add an existing domain user account to the database. This works and I can get the AdminID of the account afterwards. However, SCCMHunter does not prompt me to enter the AdminID as shown in your screenshot. How is this supposed to work?

Never mind my question. I actually read the query and saw that it is all done in one command :)

Yes! That was a recent change and I haven't updated the ReadMe just yet. I'm considering having both the 1 liner and the separated commands, do you think that would be useful?


Support ChainerX in reinforcement learning example

Part of #6661.
It seems no other fix is needed for running ChainerX.

Jenkins, test this please.

Jenkins CI test (for commit 69da7687f8eb3c937b30be5edad9028df4fc9332, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit 69da7687f8eb3c937b30be5edad9028df4fc9332, target branch master) failed with status FAILURE.

CI failures seem unrelated. LGTM!

Jenkins CI test (for commit 69da7687f8eb3c937b30be5edad9028df4fc9332, target branch master) failed with status FAILURE.

@hvy Let's backport this PR.


@import rule not compatible with Dart Sass 3.0.0

When using this with the latest sass version (1.80.4) I get this deprecation warning concerting the @import rule:
Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
19 │ @import "../../components/blocks/accordion_item/style.scss";
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    src/scss/styles.scss 19:9  root stylesheet

@abel-sch That deprecation warning will be triggered by any use of @import whether you're using this plugin or not. If some cases you might be able to use @use "../../components/blocks/accordion_item/style.scss" instead, which is supported by this plugin.


Revert "To collect the documentation contributions"

Integrated to a course branch Reverts coderefinery/word-count#45

Wrong branch, closing request


Support enumerated_attribute

This is a feature request. I tried implementing it myself but got stuck. I want to see if a patch would be accepted to do this, or if anyone else would implement it more easily.
enumerated_attribute is a gem for creating enumerated fields on objects. It integrates with ActiveRecord but uses different method names such that rails_admin doesn't notice them.
Here's an example:
t=Tractor.new
e = t.enums(:plow)                # => [:up, :down]
e.labels                          # => ['Up', 'Down']
e.hash                            # => {:up=>'Up', :down=>'Down'}
e.select_options                  # => [['Up', 'up'], ['Down', 'down']]
e.label(:up)                      # => 'Up'

Rails Admin would check respond_to?(:plow_enum), putting the attribute in the method name, but enumerated_attribute's convention for the same is object.enums(:plow). I tried adding this to enum.rb with:
      register_instance_option(:enum) do
        if bindings[:object].respond_to?("enums")
          bindings[:object].send('enums', self.name)
        else
          bindings[:object].send(self.enum_method)
        end
      end

But it never passes this test I added in rails_admin_config_edit_spec.rb:
    it "should auto-detect enumeration when object responds to 'enums(\#{method})'" do
      class Team
        def enums attribute_name
          puts "#{self.class} object.enums called with #{attribute_name}"
          ["blue", "green", "red"] if attribute_name.to_sym == :color
        end
      end
      RailsAdmin.config Team do
        edit do
          field :color
        end
      end
      visit new_path(:model_name => "team")
      should have_selector("select.enum")
      should have_content("green")
      Team.send(:remove_method, :enums) # Reset
    end

The enums() method gets called and returns the correct value, but the select doesn't end up rendering.
I see a case for adding support for Rails Admin to enumerated_attribute rather than vice-versa, but if support were added to Rails Admin, it would work for all the existing users of enumerated_attribute instead of requiring an upgrade and creating duplicate functionality (of aname_enum and enums(:aname)).

field :plow, :enum do
  enum_method do
    binding[:object].enums(:plow).hash
  end
end

Yeah, that would work for a specific field. I'm looking for a solution that doesn't require any configuration.
enumerated_attribute has accessors for the enumeration values. I'm asking if Rails Admin can be made to read these automatically.


Extra text outside the window

Description
When we open https://creativecommons.org and when we zoom out to around 25% there are extra texts appear on the left side of the screen, which are useless
Reproduction

Open https://creativecommons.org
Zoom out to around 25%
See error

Screenshots
Bug:

Expectation
The extra text should not be there.

Environment

Device: Desktop
OS: Windows 10
Browser: Chrome
Chrome Version: 122.0.6261.95 (Official Build) (64-bit)

Resolution

[ ] I would be interested in resolving this bug.

can i contribute in this?

@TimidRobot i have resolved this issue and have request PR in the vocabulary-theme repo as the original files of the website were in that repo so please check that and accept my PR. it resolves full issue of extra text outside.

@keshav861 Hi! I'm working on it. The fix would have to happen here (I did some digging and it's present here too), and then be carried over to vocabulary-theme after successful merge.


Fragment reassembly

Based on my understanding of the code it looks like Zmap doesn't do fragment reassembly prior to handle_packet ( recv.c ) handing the packet up to the probe module's process_packet function. Is this correct?
while I can see how this wouldn't have been needed or caused a problem in the past given the original design and usage, I'm currently running into issues with this when handling large responses to UDP probes.
Are there currently any plans for implementing fragment reassembly in Zmap?  Would there be any concerns would doing so?
Thanks much.

You are correct---we do not currently reassemble packet fragments. Prior experiments for the protocols we've scanned have resulted in only a negligible number of packets being fragmented. There is data provided in --metadata-file if you're trying to measure this.
At this point, we do not have any plans on adding support. However, I'm not strictly against the idea. We would, however, need to figure out a lightweight manner of doing this that would wouldn't slow down other scans. This shouldn't be too difficult to do given that the first packet will tell you whether there are additional fragments coming. If you think you can implement a reasonable solution, we'd happily consider.

This hasn't been touched in years and given that the core team has no plans to address this issue, closing.


avoid large object retrieval from database

If the collections in mongoDB contains very large documents, the await cursor.exec() can be slow. Projecting only the id may improve performances.
Bye!

great job 💯
what do you think of fixing this as well https://github.com/entria/graphql-dataloader-boilerplate/issues/47?


Add Data.Functor.Free.TH to a cabal file

I hope it will be fixed a problem with installing free-functors via stack or cabal

Oops, I didn't want to expose that module anymore, but forgot that you have to add it to other-modules! Should be fixed now.

Any examples how can I use it?


Dyld Shared Cache - Method Symbol Resolution

Version and Platform (required):

Binary Ninja Version: 4.2.6455 (02c8da1e)

OS: macOS Sonoma
OS Version: 14.6.1
CPU Architecture: Apple M2 Max

Bug Description:
IPSW:
iPhone 8+
iOS 14.4.2
Version: 18D70
Link:
https://updates.cdn-apple.com/2021WinterFCS/fullrestores/071-22616/63E5DC4B-1767-4697-9CD3-97DD4A0E033A/iPhone_5.5_P3_14.4.2_18D70_Restore.ipsw
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Go to...
Click on...
Scroll down to...
See error

Expected Behavior:
Please provide a clear and concise description of what you expected to happen.
I expect the symbols to be fully resolved as the attached screenshot from IDA Pro shows:

Opened dyld cache file and selected the MessageProtection framework.
When the analysis was complete, I started browsing the symbols. When looking at the class NGMFullDeviceIdentity, in the symbol viewer, the method names are corrupted.
Screenshots/Video [Recording:]()
Screen shot showing corrupted method names is attached.

Binary:
Due to the size of the file it is not reasonable to attach to ticket. Download link is provided above.
Additional Information:
Please add any other context about the problem here.

I think the v3 slide info has the same bug I noticed in the v5 slide info and mentioned in https://github.com/Vector35/binaryninja-api/pull/6172#issuecomment-2492639808. The page_start[i] value needs to be divided by 8 before being used as an offset into the page.

The v2 slide info handling also appears to be incomplete. It doesn't deal with rebase locations being split across multiple linked lists (DYLD_CACHE_SLIDE_PAGE_ATTR_EXTRA). I'm not sure which slide info format is used by iOS 14.4.2.

It seems the issue here is that reader->ReadCString in DSCObjCProcessor::ReadMethodList returns garbage if it attempts to read an unmapped address.

#6192 will fix selectors either loading as garbage or being entirely missing from the symbol list with shared caches for recent macOS versions and some older iOS versions (~14 or so).


Templating: impossible to not escape slashes inside

If I have a type:
type FooBar struct {
  Url string
}

And in my controller:
foobar := FooBar { "https://www.example.com/foobar" }
return c.Render(foobar)

And in my template:
<script type="text/javascript">
        var item = {
            Url: '{{.foobar.Url}}',
         }
</script>

The resulting template output is:
<script type="text/javascript">
        var item = {
            Url: 'https:\/\/www.example.com\/foobar',
         }
</script>

Nothing I do seems to fix the escaping of forward slashes. I have tried using template.URL, template.HTML, template.Js instead of string for the type. I have tried {{raw .foobar.Url}}. There appears to be no way to prevent Revel from doing this bizarre slash escaping.
If I change the <script text="text/javascript"> element to <script type="text/javazcript"> then the escaping stops, but of course I need to have the proper type attribute.

Hi
THis has nothing to do with Revel, this is Go's html templating system being very secure aware. To prevent the escaping you can wrap certain fields in template types to prevent this - for example the template.JSStr type will wrap prevent your issue with the script text being escaped.


Document CArray.allocate

The problem
CArray.allocate from https://github.com/rakudo/rakudo/pull/1779/commits/a02131d53d52bf96ba8f7bd56d04c45771dbb08c is undocumented
Solution provided
The old example showing how to allocate a CArray was updated to use the new method

You should already have a commit bit to this repo and can commit directly.

Ah, right


Create Centro Universitario Senac

Centro Universitario Senac
senacsp.txt
Url Oficial 1: https://www.ead.senac.br/cursos-por-area/tecnologia-da-informacao
Url Oficial 2: https://www.sp.senac.br/graduacao/curso/tecnologia/analise-e-desenvolvimento-de-sistemas
Dominio Emails Academico<EMAIL_ADDRESS>

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 Centro: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@vamaral2020 I have to close this request without merging. I added your school's email domain to the repository manually. Please see an email from JetBrains Support to you. Thank you!


Cleanup example repo

Remove garbage
Remove old testing code
Remove empty .ini files

Only unused files are deleted.

@dschwabeS11 Add a yml-linter in another merge request, that's using travis CI...
Good that you remove this stuff, it doesn't really work anyway 👍