HDFS-15923. Authentication failed when rename accross sub clusters.

Rename accross subcluster with RBF and Kerberos environment. Will encounter the following two errors:
Save Object to journal.
Precheck try to get src file status
So, we need use Proxy UGI doAs create DistcpProcedure and TrashProcedure and submit Job.
In patch i use proxy ugi doAs above method. It worked.
But there are another strange thing and this patch not solve:
Router use ugi itself to submit the Distcp job. But not user ugi or proxy ugi. This may cause excessive distcp permissions.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
29m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 53s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 15s

trunk passed

+1 :green_heart:
shadedclient
16m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 17s

the patch passed

+1 :green_heart:
shadedclient
17m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
23m 44s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

134m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterFederationRename

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux<PHONE_NUMBER>6e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 22f65bf61522127f940c3cc7a6aed538d61c07d1

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/1/testReport/

Max. process+thread count
2061 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

It is strange that i can pass test TestRouterFederationRename on my local computer

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
5m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 55s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 22s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 20s

trunk passed

+1 :green_heart:
shadedclient
17m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 18s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 23s

the patch passed

+1 :green_heart:
shadedclient
16m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
26m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

114m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterFederationRename

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 46ed824fb395 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bfc7ae17a3386618cf73a9984118f7beaaddc65

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/2/testReport/

Max. process+thread count
1906 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 27s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 23s

trunk passed

+1 :green_heart:
shadedclient
17m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 23s

the patch passed

+1 :green_heart:
shadedclient
17m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
25m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

108m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3f4a540e031b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8a2cd53a4d27271f9498f4e02e3901d17c5c1a9c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/3/testReport/

Max. process+thread count
2062 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 34s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 16s

trunk passed

+1 :green_heart:
shadedclient
14m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 18s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 16 new + 0 unchanged - 0 fixed = 16 total (was 0)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 15s

the patch passed

+1 :green_heart:
shadedclient
14m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 17s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

94m 15s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 50f94adff27d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 561d305b9953f81ba4261fe78d0d9f4f7d4f1c83

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/5/testReport/

Max. process+thread count
2704 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 17s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
16m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 19s

the patch passed

+1 :green_heart:
shadedclient
16m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
22m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

106m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterWebHdfsMethods

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux fa8b8428199f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f2e12ad5788c0724bea9c83f23d4323aaa990dfa

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/6/testReport/

Max. process+thread count
2019 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 17s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 20s

trunk passed

+1 :green_heart:
shadedclient
17m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 16s

the patch passed

+1 :green_heart:
shadedclient
16m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
25m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

112m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 37b8ebb1141e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6c6fe4ff608a1fca5a697e57c8f229aeed5fdf92

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/7/testReport/

Max. process+thread count
2192 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
26m  0s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 26s
/branch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 26s
/branch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-rbf in trunk failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-0 :warning:
checkstyle
0m 26s
/buildtool-branch-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
The patch fails to run checkstyle in hadoop-hdfs-rbf

-1 :x:
mvnsite
0m 26s
/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in trunk failed.

-1 :x:
javadoc
0m 25s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 26s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-rbf in trunk failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
0m 25s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in trunk failed.

+1 :green_heart:
shadedclient
2m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 22s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 22s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
javac
0m 22s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/buildtool-patch-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
The patch fails to run checkstyle in hadoop-hdfs-rbf

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 16s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 16s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-rbf in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
0m 22s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
shadedclient
3m 34s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
40m 58s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

82m 29s

Reason
Tests

Failed junit tests
hadoop.fs.contract.router.web.TestRouterWebHDFSContractCreate

hadoop.hdfs.server.federation.router.TestRouterFederationRenameInKerberosEnv

hadoop.hdfs.server.federation.router.TestRouterRpcSingleNS

hadoop.hdfs.server.federation.router.TestSafeMode

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2819

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 3442eb89e8bb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a9182108322a885da38a29d315a0e379990014bd

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/8/testReport/

Max. process+thread count
1962 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2819/8/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Unable to shrinkwrap if the dependency tree contains request@2.66.0,2.66.1

This bug seems a bit crazy, but hear me out:
We recently updated some dependencies and tried to shrinkwrap, but shrinkwrap continually fails with extraneous dependencies in the module tree.
It appears to be related to the recent release of request, so:
If I try to shrinkwrap request:
git clone git@github.com:request/request.git
npm i --production
~/code/opensource/request $ npm shrinkwrap
npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! extraneous<EMAIL_ADDRESS>/Users/andrewn/code/opensource/request/node_modules/sshpk

However, if I try:
git checkout d46a4c727ed7368e4625f9204f140904cc3f4478 # 2.61.1
rm -rf node_modules/
npm i --production
npm shrinkwrap # --> Success

Note, that I'm not actually trying to shrinkwrap request. The problem is that if I try shrinkwrap my module and my module depends on request, then the shrinkwrap for my module will fail with the same error.
I'm not sure if this is a problem with request or a problem with npm, most likely it's npm, but I'm reporting it here since other people are likely to experience the same problem (we've tried this on different developers environments and are getting the same issue)
Some details:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

+1

@scottgrasley are you also experiencing this problem? I'm still digging, but if definitely appears to be an issue with npm rather than request itself.

See this: https://github.com/request/request/issues/1909
and this https://github.com/joyent/node-http-signature/issues/51

Thanks for the pointers @simov. I'll close this issue then as a duplicate of #1909.

I'll actually re-open this for now. It will be easier to find it if it's open.

@suprememoocow Yes, I'm seeing the same problem with sshpk when running npm shrinkwrap.  I ended up including<EMAIL_ADDRESS>in my package and that mitigates the problem for now.
Thanks!

http-signature & sshpk already patched peerDependency issue - https://github.com/joyent/node-http-signature/issues/51
One more build should resolve this problem.

<EMAIL_ADDRESS>is published on NPM :tada:

Thanks for the quick turnaround on this @simov @sonyschan!


Add finiteFlatten function

Using the builtin flat method on tokenTree caused TypeScript to throw Type instantiation is excessively deep and possibly infinite.ts(2589). This introduces a finiteFlatten method which TypeScript is ok with.

finiteFlatten is exported so that other langs with custom detokenizers can make use of it


Remove global state

Currently lots of assumptions are made about CWD, dependencies directory, ...
due to heavy usage of global Lazy statics and getter functions which have no state, meaning none of these variables are configurable.
Random example 1: deep in "health check" is usage of global DEPENDENCY_DIR https://github.com/mario-eth/soldeer/blob/b31317860b576d40fa72df4ee52c969e2d65d02d/src/janitor.rs#L24
Random example 2: utils::get_base_url has to use an environment variable to override the value on cfg(test)
https://github.com/mario-eth/soldeer/blob/660b6c95e33965e532dabedce30d0e48c5d174bc/src/utils.rs#L89-L95

An example fix would be something like struct Project or whatever you want to call it (like Rust crate) that contains dependency_dir: PathBuf, and these global functions are instead methods on this struct.
There are more ways to do this, but the main point is removing the global state to make it configurable.

We have version 0.4.0 on the making which takes care of all of these lazy and more modular. But we are releasing slowly. This release aimed sub-dependencies and an improved git support.
Version: 0.4.0 will have more improvements


[Feature] Improve accessibility of the devtools

Would be great if the devtools was more accessible. See for example the sad accessibility tree when I select the collapse button:

The toggle button, should have an aria-label and be linked to the panel via aria-controls, aria-haspopup and aria-expanded.
The panel itself should be an <aside> and also have a descriptive name via aria-label.
The buttons inside the panel and such could probably be improved too, but at least the above should make the devtools itself more "visible" in the accessibility tree. 🙃

Valid for the feedback itself. It's an open-source project if you have a strong opinion (a valid one) about things you can contribute and send us a PR. Rolling face around doesn't add any value to the project and shows any thought of appreciation toward people using their free time on the project like myself.
So conclusion: Feel free to send a PR to improve on the accesiblity. thanks

Sorry, wasn't aware the 🙃 smiley was considered offensive or ungrateful, I just wanted to be nice. Removed it now.

all good. It's a contextual thing, like I said it's valid feedback in general.

So what is being done to make the devtools more accessible?


containerview service call (passing data)

hi hussain,
i m using this in one of my application and im facing issue while calling webservice and passing data.
i have a view controller containing buttons and this containerview , containerview has 2 embeded viewcontrollers <ListingVC, MapVc>, one for listing and other for map.
this is the hirarchy -> subcategoriesVC contains buttons of map and listing , with listing as a first viewcontroller of conatainer.
now i need to call webservice to get data for listing and map data, and then i have to pass that data on  respective VC of containers, how can i do this ?
1> should i call service on subcategoriesVC or containerview?
2> how can i pass data to both VCs of container?

you should call the api in subcategoriesVC since its the parent.
There is a property of currentViewController inside ContainerViewController. You can use that to pass data. or you can use the viewControllers array that I just committed to pass data to your child controllers.

Hope this helps.

I think you have not set the initial controller through storyboard. That's why currentviewcontroller is inaccessible. in your viewDidLoad try
container!.segueIdentifierReceivedFromParent("first")

yes. thanks . other than that above implementation is correct for passing data ??

I'm not sure if its the best practice but it is the correct way to pass data.


Use of theme.json in desktop client (and possibly other clients)

theme.json returns a list of logos which the desktop client should display for branding purposes. Unfortunately, at the moment, the default ownCloud icon is the same for both default and default-dark: a white-filled version of the ownCloud logo.
The desktop client supports multiple themes, too. By default, we use the light theme. With the given logo, we would need to display a white logo on a white background. This doesn't work for obvious reasons.
Is it possible to provide a suitable logo on the theme.json endpoint? I'd expect some dark color logo for the default (i.e., light) theme. If the web interface requires the white logo for the light theme, too, we could provide a dedicated URL for client use. If my assumption that default means light is wrong, please correct me.
Regarding branded instances, I expect we'll have a single logo that isn't purely white but typically represents the organization that operates the instance. Here a single logo may work for both themes.

@fmoc @hosy propose a JSON change?

First I need to understand the purpose of the single fields. If default means "light theme" and the logo is supposed to be white there, too, we'd probably need our own "client logo" next to the other fields (i.e., default.logo.client, default-dark.logo.client).

@fmoc the theme.json is derived from the ownCloud Web theme. There the white logo works in both the light (on dark blue background) and the dark (on dark-greyish background) theme.
default is the light theme, default-dark is the dark theme, that's correct.

@fmoc The linked json file is outdated
Please check https://owncloud.dev/clients/web/theming/
This was added to ocis master, so not part of ocis.owncloud.com
Please check out our continous deployments https://owncloud.dev/ocis/deployment/continuous_deployment/ where latest means the ocis master branch.
You see, we have changed the format to offer every client his own key and a common key.
You can now add in the same schema a desktop key with one or more dark and light themes like oc web does.
The idea behind the common key was to use it for general assets which are the same regardless of the specific theme.

Seems like this comment I wrote around 3 weeks ago still has not been posted... Thanks, GitHub!
Looks a lot better than what I expected! Thanks for the links. The latest demo lives here, as far as I can see. (Maybe such a link should be included in the docs, too.)
A custom section would work best for the desktop client. The common section could serve as a fallback, but I'm not sure that's a good idea. What I can tell so far is that as-is, the default icon doesn't work well with our default (light) theme, being white on light grey, so we'd need a specific light theme icon to work with. I guess it won't be much of a problem to just provide a single icon twice in a light and dark theme section if an instance provides only a single icon for both modes.

A custom section would work best for the desktop client.

Just open PR…

The common section could serve as a fallback, but I'm not sure that's a good idea.

Probably not…

We could also just extend the common section to also provide default and default-dark, as shown in this mockup:
> http http://<IP_ADDRESS>:5000/themes/owncloud/theme.json
HTTP/1.1 200 OK
Connection: close
Content-Length: 454
Content-Type: application/json
Date: Tue, 14 Mar 2023 14:32:16 GMT
Server: Werkzeug/2.2.2 Python/3.10.6

{
    "common": {
        "default": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        },
        "default-dark": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        }
    },
    "desktop": {
        "default": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        },
        "default-dark": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        }
    }
}

@fmoc there is a logo_dark.svg now which you could try to embed (just use it in the theme.json). Happy about feedback. :-)

Works quite well, thanks! I changed my theme.json demo server accordingly:
{
    "common": {
        "default": {
            "logo": {
                "compact": "themes/owncloud/assets/logo_dark.svg"
            }
        },
        "default-dark": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        }
    },
    "desktop": {
        "default": {
            "logo": {
                "compact": "themes/owncloud/assets/logo_dark.svg"
            }
        },
        "default-dark": {
            "logo": {
                "compact": "themes/owncloud/assets/logo.svg"
            }
        }
    }
}

It's a little counterintuitive that the dark logo is used in the light theme, but that's just a matter of configuration and won't affect the overall result, of course.


Setup 'main' as default branch? 🤶🏽

Would it be useful (until main becomes default in git) to add a requirement for having a "new enough" version of git and setting up git config --global init.defaultbranch main?
(mentioned in https://github.com/coderefinery/testing/pull/101)

+1 from me.

I read a bit quickly on the minimum Git version that understands this. @rkdarst has a good point that we should not require a too new Git.

We can keep the issue. It is a good suggestion but maybe too early.

main is now the main branch

This was not about main branch here but main branch in the Git lesson material.

ah sorry, didn't read carefully


Add to_ansidata/1 to Ecto.LogEntry

Like discussed in the mailing list, this PR adds a color code based on the SQL statement type.
It is heavily inspired by the Rails 5.0 feature 😉
The function to_ansidata/1 is not yet used by the logger because we will need to find a way to use it from a config or even better to use it by default and fallback to to_iodata/1 from a config.
Here is a screenshot of the output in action in one of my app:

🌈

Beautiful!

Should we check if the log is for SQL adapter first? Or maybe let the adapter handle the coloring?

I think this looks really great but it will cause problems for Logger backends so am :-1:. This will put ANSI encodings inside all logs, which is undesirable. Also it will clear the ANSI colours before the end of the line when using a custom formatter that includes characters after the end of the message.
Custom formatting should be done in the Logger formatter of a backend not by the sender. I think it would be better to add ansi_color: color, or similar, metadata to the log and handle that in the default Logger.Backends.Console formatter, This will allow other adapters and applications to take advantage of this, and not interfere with custom formatters or backends.

I was thinking about this as well @ericmj. Handling this at the adapter level seems like a better approach.

@fishcakez right now it is just a function and it is not being used by default. We will investigate how to enable/disable it. Maybe we can enable it only for development.

@josevalim yeah I see that but I am :-1: the approach in general before we go down this path. We should not be formatting like this from a sender of a log.

To be clear I want the feature, it is a really nice addition, but not this method.

After reviewing your comments I also think that adding meta data at the adapter level is the way to go.
The Ecto.Adapters.SQL would simply add a ansi_color key to the LogEntry struct. I’m not sure how to modify the Logger.Backends.Console to apply this new key.

@simonprev setting a color from the adapter sounds like at least a good way to get started. :D

setting a color from the adapter

@josevalim I added the key ansi_color as suggested by @fishcakez at the adapter level. I don’t know the right way to add test to this or how the logger might implement this new feature.
I willing to work on whatever part of the feature but I might need pointers on where to start 😄 Thanks!

Thank you @simonprev!
@fishcakez are you OK with us sending ANSI escapes code to the Logger during development only?

Glad this has been merged, can I help in any way to implement this in the logger?

@simonprev support is in logger master already :smile:


hi, a quick question out IMS & DMS exp

Hello, have you ever tried any experiments on IMS tasks?   I'm curious about the performance of DLinear on IMS tasks.

Hello! We didn't conduct experiments on IMS tasks. I think in IMS tasks, DLinear is quite similar to statistical methods -- It is a weighted sum of historical values, where weights are learned.
Also, in IMS tasks, the predicted length is only 1. The number of parameters in DLinear will be extremely small (LookBackWindow*2). Therefore the capacity of DLinear might be too small.

Thanks for your explanation and DLinear is indeed an outstanding work. However, i am looking for works testing on IMS tasks, could you like to recommend me some good works. Thanks :D .

Maybe you can try another work from our lab -- SCINet. With an output length 1, it can be an IMS model. Also, you can try N-beats.


Is there any way to get Influxdb worked on HP-UX systems ?

Directions
GitHub Issues are reserved for actionable bug reports and feature requests.
General questions should be sent to the InfluxDB Community Site.
Before opening an issue, search for similar bug reports or feature requests on GitHub Issues.
_If no similar issue can be found, fill out either the "Bug Report" or the "Feature Request" section below.
Erase the other section and everything on and above this line.
Bug report
System info: [Include InfluxDB version, operating system name, and other relevant details]
Steps to reproduce:

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Additional info: [Include gist of relevant config, logs, etc.]
Also, if this is an issue of for performance, locking, etc the following commands are useful to create debug information for the team.
curl -o profiles.tar.gz "http://localhost:8086/debug/pprof/all?cpu=true"

curl -o vars.txt "http://localhost:8086/debug/vars"
iostat -xd 1 30 > iostat.txt

Please note It will take at least 30 seconds for the first cURL command above to return a response.
This is because it will run a CPU profile as part of its information gathering, which takes 30 seconds to collect.
Ideally you should run these commands when you're experiencing problems, so we can capture the state of the system at that time.
If you're concerned about running a CPU profile (which only has a small, temporary impact on performance), then you can set ?cpu=false or omit ?cpu=true altogether.
Please run those if possible and link them from a gist or simply attach them as a comment to the issue.
Please note, the quickest way to fix a bug is to open a Pull Request.
Feature Request
Opening a feature request kicks off a discussion.
Requests may be closed if we're not actively planning to work on them.
Proposal: [Description of the feature]
Current behavior: [What currently happens]
Desired behavior: [What you would like to happen]
Use case: [Why is this important (helps with prioritizing requests)]

This issue appears to have just posted the default issue template so I'm going to close it.


chore(main): release 0.16.0

:robot: I have created a release beep boop
0.16.0 (2024-05-21)
Features

custom translation (8b106a0)
display more outdoor data (429ae8e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/GeotrekCE/Geotrek-rando-widget/releases/tag/0.16.0 :sunflower:


Don't die if examples are not available

Previously if examples are not present there was a runtime error: hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /nfs/public/rw/ensembl/libs/perl/share/perl5/JSON.pm line 154

Looks fine to me (most of this code is mine originally I think) but I'll let web merge as it's their repo.


Download LSP server button doesn't appear

λ ls ~/.config/Code\ -\ OSS/User/globalStorage/
state.vscdb  state.vscdb.backup

I get the above when freshly installing the extension. I'm on Arch Linux using Code - OSS. Is there something else that needs to be done? Are only some Linux platforms supported?

Can you please open command palette with Ctrl+Shift+P, write Toggle Developer Tools and press enter to open the Developer Tools, then open Console tab and send its contents here?
Also please give the contents of Help > About window in VSCode?

I suspect @matklad published old version to Marketplace right now

Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-20T11:11:01.597Z
Electron: 6.1.7
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.5.2-arch1-1

Yes, I am 90% sure this is the old version of extension right now on Marketplace. Already pinged him...

@skeet70 How did you install the extension? I suspect that you are using the old version of client extension that you've built from sources.
Can you please try to uninstall the extension and install it from marketplace again?

@Veetaha is there an effective way to uninstall the one I built from source? I've uninstalled -> reloaded -> installed several times now with the same issue.

@skeet70 The 99% method is rm -rf ~/.vscode/extensions/matklad.rust-analyzer-0.1.0

Glad, it wors now!

Re-installing without uninstalling also works fine. Only uninstalling without quitting before re-installing keeps the old version cached.


Update instructions to use the 2023 tutorial tag

Looks good to me. I'm going to go ahead and merge.


Suppress prompt spawned by subprocess when using pythonw

On Windows, using pythonw.exe for GUI applications, while determining the release using Git via subprocess a command prompt window is temporarily visible.
This fix updates the subprocess STARTUPINFO dwFlags to use the wShowWindow attribute, which defaults to SW_HIDE hiding the prompt.

Here's a one-liner to invoke the subprocess call with pythonw to test for the prompt popup:
pythonw -c 'import sentry_sdk; sentry_sdk.utils.get_default_release()'

Tested on Windows 11, in Windows Terminal, with Git Bash and Command Prompt. (The subprocess popup emitted within a Bash shell is persistent and easier to verify.)

I know it has been years @collinbanko but if you bring your branch up to date with our new master and resolve the conflict, than I will merge it immediately! promised!

Oh, nevermind @collinbanko , I figured out how to create a PR that has no conflicts and still has your commits in it: https://github.com/getsentry/sentry-python/pull/2936 Will merge the other one in favor of this one.
Thanks again for the contribution and sorry for the long time it took. Will close this PR and merge the other one.

Thank you for getting this merged in @antonpirker! Better late than never 😄


Hotkey hides other application Hotkey

If Vault is start but not focused, CTRL+S not seding to other app (Word, Notepad++, etc.)

Fix in <IP_ADDRESS>


Remove component union types

...and bump wasm-tools deps.
Fixes #6871

Assuming it also gets merged, the first commit here should be refactored to use vhttps://github.com/bytecodealliance/wasm-tools/pull/1182

I just pushed an update here anticipating a wit-bindgen 0.11.0 release. Obviously CI failed, but someone with access can hopefully just retrigger the CI jobs after that release and this should then be mergeable.

At this rate I think I'll post a bump for 0.11.0 on Monday, but it'll definitely include this

Oh oops wrong project, I see now! I think it's ok to avoid a wit-bindgen update here as that's mainly used for tests. The dependency between wit-bindgen and wasmtime mainly goes the other direction where wit-bindgen relies on wasmtime for tests, but it's ok in this regard for them to be slightly out of sync.

Ah yeah I didn't really think that through. Well I'll fix it up when I get a chance if someone else doesnt get to it.

This should be ready now.


Post install script failing on windows because of unix rm command.

It looks like we already have a built index file in lib. Do we need to have this post install script in package json? As long as you're building index before publishing to npm I don't think this script is necessary.

@ParivedaLuke Yes you are right. Thanks for catching that. Fixing in the next PR


Windows 11 Left Taskbar activation

Description of the new feature / enhancement
The idea is to bring back the taskbar option to be dock at the left / or right of the screen.
It improves drastically performances when using a PC.
Scenario when this would be used?
With a left/Right task bar , we can set pinned application to a precise position without activating the "combine" button from a classic taskbar because it takes too much place when you need to switch between 5 or 8 apps constantly.  (without using virtual desktop which removes the possibility to see if any badge or action appers on other apps)
It improves drastically performances when using a PC.
Supporting information
Alternativly, ( or at least I would say) remove /limit the size of the title which is shown into the taskbar buttons (Only the Icon and tooltip is fine)

/feedbackhub


Disable variant check except for LGC

This changes the lint config syntax to allow negating string
conditions, which formerly was not supported.  This provides a simpler
alternative to disabling globally and then selectively enabling.

LGTM


jsonplaceholder.typicode.com not working

From iOS app:
NSLocalizedDescription=The request timed out.,  NSErrorFailingURLStringKey=https://jsonplaceholder.typicode.com/posts,  NSErrorFailingURLKey=https://jsonplaceholder.typicode.com/posts.

Error sending request: The request timed out.

Also, when trying to open jsonplaceholder.typicode.com in a browser, the request also ends with a server timeout.

When I go to: https://jsonplaceholder.typicode.com/
I get a Code 502 - I am in the USA
Is this website just down?


request help: Local Test for Master Barnch Failed 26% Cases

Issue description
I ran test locally against master branch, however too many tests failed.
I would expect master branch to have no test failure.
Test Summary Report
-------------------
t/plugin/authz-keycloak.t            (Wstat: 2048 Tests: 24 Failed: 8)
  Failed tests:  13-15, 17-18, 22-24
  Non-zero exit status: 8
t/plugin/grpc-transcode.t            (Wstat: 4864 Tests: 48 Failed: 19)
  Failed tests:  7-15, 30-35, 39-41, 45
  Non-zero exit status: 19
t/plugin/limit-count-redis.t         (Wstat: 0 Tests: 69 Failed: 31)
  Failed tests:  10-15, 17, 19, 22-25, 29, 31, 34, 36-41
                43, 45, 48-51, 55, 57, 62-63
  Parse errors: No plan found in TAP output
t/discovery/eureka.t                 (Wstat: 0 Tests: 22 Failed: 10)
  Failed tests:  1-2, 8-10, 13-14, 20-22
  Parse errors: No plan found in TAP output
t/router/radixtree-sni.t             (Wstat: 2304 Tests: 80 Failed: 9)
  Failed tests:  9, 20, 28, 36, 42, 50, 58, 66, 72
  Non-zero exit status: 9
t/plugin/http-logger.t               (Wstat: 1024 Tests: 47 Failed: 4)
  Failed tests:  21, 27, 33, 41
  Non-zero exit status: 4
t/router/multi-ssl-certs.t           (Wstat: 768 Tests: 31 Failed: 3)
  Failed tests:  9, 18, 27
  Non-zero exit status: 3
Files=120, Tests=4022, 425 wallclock secs ( 1.37 usr  0.23 sys + 76.17 cusr 35.19 csys = 112.96 CPU)
Result: FAIL
Makefile:179: recipe for target 'test' failed
make: *** [test] Error 1

Environment

apisix version (cmd: apisix version): 1.4
OS: Linux 2d-pc 5.3.0-62-generic #56~18.04.1-Ubuntu

This is the step I followed to setup the test env:
# get source
$ git clone git@github.com:apache/incubator-apisix.git
$ cd incubator-apisix

# prepare runtime and start apisix process
$ etcd --enable-v2=true &
$ make init # create config files
$ make deps
$ make run

# install required test-nginx repo to sibling file path
$ git clone https://github.com/openresty/test-nginx.git ../test-nginx
# invoke the test in incurbator-apisix using `prove`
$ TEST_NGINX_BINARY=`which openresty` \
prove  -I./ -I../test-nginx/lib -I../test-nginx/inc -r ./t

More details can be found here: https://mqiu.me/post/apisix-test-setup/
What Do I Need Help With
How could master branch fail 26% of all tests, what should I do to make my test setup correct?

May I ask which specific test cases failed?
Some tests rely on external services, such as grpc test, cluster rate limiting test, etc.

May I ask which specific test cases failed?
Some tests rely on external services, such as grpc test, cluster rate limiting test, etc.

Sure this is the full list: https://gist.github.com/mtx2d/b64a79afabf0186c979a24ca448bb7dc

Apache APISIX's CI need to install Lots of dependencies:
https://github.com/apache/incubator-apisix/blob/master/.travis/linux_openresty_runner.sh#L36
Most of these failed test cases are dependency problems

Apache APISIX's CI need to install Lots of dependencies:
https://github.com/apache/incubator-apisix/blob/master/.travis/linux_openresty_runner.sh#L36
Most of these failed test cases are dependency problems

Got it, I was still trying to figure out the correct workflow.
Seems to me the right thing to do is to let CI handle all the tests.

I will close this. The recommended way to test is to file a PR and trigger CI to run full set of tests.


Remove web-console gem

We use pry and byebug as a REPL and debugger.
web-console doesn't add much value, and sometimes annoying on small
screens as it has a position: fixed; at the bottom.
Having a browser inspector opened horizontally with the web-console,
hides almost Rails' error message and the stack trace.
Anyone is using it?

Nope, and totally agree to remove it. :+1:

Totally agree too ! :+1:


Toit.Jaguar version igger_tls

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Accidental pull request of prerelease.


Update to registry.access.redhat.com/ubi8/ubi-minimal:8.10-1130

Updating the base image for OSD-14653

/hold
we've had base image updates break this operator before

Will be merged as part of: https://github.com/openshift/certman-operator/pull/317 bot PR


cannot get dynamic resampling in databricks python notebook (or generated html)

Greetings,
I am trying to generate a standalone html file, as plotly does, with the plotly-resampler such that it will dynamically resample based on zoom events. Currently, I get statically resampled windowed data that does not resample on zoom.
I have tried various combinations from the documentation, including:

register_plotly_resampler(mode="widget", default_n_shown_samples=1500)  # auto inline_persistent inline widget
FigureWidgetResampler

Databricks notebook is free here:
https://community.cloud.databricks.com/login.html
The only addition I made were the python libraries here with this cell:
%pip install plotly_resampler lttbc
Thank you for your time.
Cheers,
Joe

Hi @jhgorse,
regarding the HTML export, I suggest you first look at our docs' FAQ and this related issue #175
I have not yet tried the DataBricks notebooks. But we already observed that plotly-resampler does not seem to work in Kaggle notebooks. This is caused by:

Kaggle did not seem to support Plotly FigureWidgets at the time of the investigation. Can you make a plain plotly FigureWidget work in the Databricks notebook environment?
Furthermore, the notebooks did not allow forwarding the network port that needs to be spawned for the Dash app.  Are there any settings or documentation w.r.t. port forwarding for Databricks notebooks?

As a final note. Plotly-resampler leverages the Python back-end to perform aggregation based on javascript (front-end) interaction. So you always need a connected kernel to perform aggregation.
The only way you would be able to create such resample visualizations in HTML without a connected Python kernel is if the unaggregated data resides within the HTML file and the aggregation would be performed in the JavaScript code. This would increase the size of HTML files significantly, making it a big hassle to share and load these files.
I hope this answers your question,
Kind regards
Jonas

Jonas,
Thank you kindly for writing.
The FAQ question and answer content
What is the difference between plotly-resampler figures and plain plotly figures?
belong on the main github plotly-resampler readme. Before Features and after the intro paragraph. This is the key architectural information which communicates what plotly-resampler actually is. Thus prescribing its intended use and limitations.
I read #175. My use case is different.
We have a lot of data. Few look at it. The notebooks are all specialized with great learning curves and people are spread thin. I want to fix the viewing problem by making self-contained, browser-only dependency, html js plots with a good deal of data historical data up to the present. The target is about 50 to 100 MB of compressed data, which gets you pretty far in terms of visibility. If they want to change things, use the notebook it came from. I want data exploration to be painless click-drag, point zoom, plotly-esque. I want it to start zoomed out and allow significant zooming in to the finer granular data.
So, if possible, I want a standalone plotly-resampler.
If I must have a server involved in this, then I also want live, real-time updates (sub 5 second latency). =)
Hope this finds you well.
Cheers,
Joe


Remove deprecated API

Remove deprecated Connection interfaces in the 4.x branch:
Interfaces

RedisClusterAsyncConnection
RedisClusterConnection
RedisAsyncConnection
RedisConnection
BaseRedisAsyncConnection
BaseRedisConnection
RedisGeoAsyncConnection
RedisGeoConnection
RedisHashesAsyncConnection
RedisHashesConnection
RedisHLLAsyncConnection
RedisHLLConnection
RedisKeysAsyncConnection
RedisKeysConnection
RedisListsAsyncConnection
RedisListsConnection
RedisScriptingAsyncConnection
RedisScriptingConnection
RedisSentinelAsyncConnection
RedisServerAsyncConnection
RedisServerConnection
RedisSetsAsyncConnection
RedisSetsConnection
RedisSortedSetsAsyncConnection
RedisSortedSetsConnection
RedisStringsAsyncConnection
RedisStringsConnection

RedisClient Methods

public RedisClient constructors
RedisClient.connectAsync
RedisClient.connectSentinelAsync

RedisClusterClient Methods

public RedisClusterClient constructors
RedisClusterClient.connectCluster
RedisClusterClient.connectClusterAsync

Tasks:

Remove deprecated API
Adopt Tests

The best option seems to keep the deprecated API until 5.0.


really simple perf regression test

This works, and is a backstop, but it makes things a lot slower.  3.8 went from 3.5 to 4.5 minutes, not the end of the world.
3.11 went to 15 minutes.  rerunning to see if I got a bad runner for that single execution.

unable to merge commit to main


Welcome/Empty/Error screens

Welcome/Empty State component
Open in Storybook ↗        Design specs in Figma
Component includes a few state examples

Welcome
Hello
Empty
Error
Thanks

All fields and elements are editable.
Design requirements allows to build custom state in the scope of the current layout.
Welcome state:

Also, PR included:

Storybook updated to v6 + TypeScript fix
Global Themes Enum added

@thure Changes are not huge but affect all library components.

Looks excellent! I don't see any issues at this time.
I wonder if we should call the component something other than States, since that could potentially be confused with redux reducers or some interaction-oriented HOC, but we can revisit it if #2 ever gets prioritized.

Agree, I will discuss it, also, with design team for better naming


Aesthetics issues

The sidebar should have color: rgba(0, 0, 0, 0.7) !important for both the side links and "Hello, Guest"
The top text should be white

I don't want to change it, it looks bad


ci: update installation skip message

This pull request just updates the messages echoed when the installation is skipped.

I visually inspected the log and they look good.


Card hover animations

Title and Issue number

Title: Card Hover Animations
Issue Number: 936
Close #<issue_no>

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

Screenshots

Please review my code and add to your repository with the label hactoberfest.


Ajustes para el nuevo sistema de pistas

Codecov Report

Merging #11 (826c19a) into master (13d122f) will decrease coverage by 3.26%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     77.95%   74.68%   -3.27%
+ Complexity      117      107      -10
============================================
  Files            28       24       -4
  Lines           322      316       -6
  Branches         17       17
============================================
- Hits            251      236      -15
- Misses           67       76       +9
  Partials          4        4

Impacted Files
Coverage Δ

src/main/java/edu/fiuba/algo3/modelo/Juego.java
0.00% <0.00%> (-71.43%)
:arrow_down:

src/main/java/edu/fiuba/algo3/modelo/Ciudad.java
100.00% <100.00%> (ø)

...va/edu/fiuba/algo3/modelo/detective/Detective.java
100.00% <100.00%> (ø)

...ava/edu/fiuba/algo3/modelo/edificios/Edificio.java
90.90% <100.00%> (+3.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d122f...826c19a. Read the comment docs.


Minor correction and clarification in README

The example for creating the GDNative library works, however,
some details were slightly off before this commit. I also made minor
changes in text for clarification.

My very first pull request, I just never came around to make one before this. If there's something I've missed, please feel free to enlighten me =)

Thanks for the contribution! The PR itself is fine, it's just some technical stuff that's a bit off or confusing, but maybe I didn't understand correctly :D

Thank you =)
But yes you're right, this PR will not correct things. Let me revise some things and I'll update again :)

@meraz mind giving this a once over again, I think most of these things have changed now with api.json being embedded in godot_headers and that being a submodule now?

Thanks @meraz , hope you are well!


--bumped-version broken in some scenarios?

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
npx git-cliff --bumped-version and git cliff --bumped-version both are returning the old version instead of the new one (1.38.0, in my case).
When I run git cliff --unreleased --bump --context, I see 1.38.1 in the context, which is what I had expected the bumped version command to produce.
This happened for two of our repositories.
We've been using npx git-cliff --bumped-version for 6 weeks or so (ran 3 times successfully) in a GitHub Action workflow and it's been great, but when I went to release today it failed to change the version. I looked at our git commits and there are ones that should cause a minor version bump. I even checked out individual commits in case one of the messages was causing an issue, and none of them were bumping to the right version, including the one right after the last correctly bumped version.
I've verified that the tag exists as well. I'm not seeing what could've broken it on our end...
Steps To Reproduce

Have changes that would bump a version
Run npx git-cliff --bumped-version or git cliff --bumped-version
See that you get the previous version
Run git cliff --unreleased --bump --context

Expected behavior
--bumped-version provides the next version (1.38.1 in my case)
Screenshots / Logs
No response
Software information

Operating system: GitHub Action Linux runner and MacOS laptop
Rust version: N/A for GitHub Action, I'm using NPM, but I have Rust 1.78 on my Mac
Project version: v2.2.1 and v2.3.0

Additional context
No response

Quick follow up, I just did a third release today and it worked. Same exact GitHub Action setup, so maybe it's something in our commit messages then?
Going to dig in more now.

Super weird.
Something is up with some of the tags. I deleted and re-added them to the same commits and then git-cliff worked.
This must be an issue on the GitHub or VS Code side of things then?
Curious if anyone else has run into this...

 It's because the tags are made on the "Update version number" step, but then I destroy that commit hash by amending with the updated CHANGELOG.md.
I need to revisit the Action. This is a me problem 😁 Sorry to add to your GitHub notifications!


Added FAQ to README.md

So, I got someone to test it out and he can use it on IE11 without the patch. Although it might be good to keep this in the FAQ for a while just to make sure.

That's looking better. If we're going to make a list of supported browsers though, we should probably test all the major ones. Some glaring omissions I see are Safari and Opera. We might even test some older versions of IE. I'm out of town right now but I could probably help with this Saturday or Sunday. Also I'm not sure the link to issue #45 is necessary.
P.S. Thanks for contributing!

Wetty works with Safari and Opera just fine. I couldn't get it to work with IE 10 or below though.

Are there any changes I need to make before this can be merged?

merged manually


Documentation does not specify how the .Data property of an Exception is handled by Application Insights

Can you pass additional information in the .Data property of an exception or is it ignored?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95aee749-dc67-58c6-c911-a8cfcfd387a2
Version Independent ID: 21056412-21a5-1e79-f588-5bbb846789bf
Content: Diagnose failures and exceptions in web apps with Azure Application Insights
Content Source: articles/application-insights/app-insights-asp-net-exceptions.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@IanMercer Thank you for the feedback!  We are investigating this and will get back to you shortly.

@IanMercer We're still looking into this, and should have an answer soon.

@IanMercer it will be ignored.
I agree it's not clear in our documentation but, we only capture StackTraces from Exceptions.

TrackException() sends stack traces.
https://docs.microsoft.com/en-us/azure/application-insights/app-insights-asp-net-exceptions#custom-tracing-and-log-data

You can review the implementation here: https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs
Workaround 1
If you look at the code sample here: https://docs.microsoft.com/en-us/azure/application-insights/app-insights-asp-net-exceptions#reporting-exceptions-explicitly
You can add additional custom properties. You parse Exception.Data as you wish and add it here.
Workardound 2
If you want a more global solution, you can add a TelemetryInitializer  to your project that parses the Exception object and adds additional details to the Properties field.

@IanMercer We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


is [applications: [:ecto_translate]] really necessary?

In the docs it is mentioned:

Ensure ecto_translate is started before your application:

def application do
[applications: [:ecto_translate]]
end

But is this really necessary?
When I get information about the :applications option with mix help compile.app I read the following:

:applications - all applications your application depends
on at runtime. By default, this list is automatically inferred
from your dependencies. Mix and other tools use the application
list in order to start your dependencies before starting the
application itself.

it says "this list is automatically inferred from your dependencies".

From elixir 1.3+ this is not necessary but still harmless to add :)


Update app setup to use docker for postgres/redis

related: https://github.com/bullet-train-co/bullet_train/pull/464
related: https://github.com/bullet-train-co/bullet_train/pull/1620
What are you doing?
Started playing around with bullet train
(🙌) and didn't like having to
install bare-metal postgres / redis.
Personally, I tend to avoid from running background services directly as I often forget about them, and also have conflicts across various repos using different versions. Also, lets promote developers dipping their toes into Docker as it's a critical tool to learn. To that end, I've updated the setup/dev scripts to expect and use docker for those services.
Specific changes:

Separated the configure/setup scripts into their own folders
Use a shared utils.rb script for configure/setup/dev
Added a check_docker.rb to script/setup to check the user has Docker installed and running
Added various helper functions to utils.rb for interacting with docker containers
Change setup/dev to start and stop containers as needed so the system is unchanged when running the app
Re-wrote the bin/dev script to be Ruby since we seem to have decided to go all in on Ruby scripts for /bin

What does all this actually do?
Generally configure/setup/dev remain mostly unchanged.

bin/setup now checks that docker is installed and running (give option to start it if not)
bin/setup now starts postgres to run migrations and stops it after
bin/setup doesn't check if postgres / redis are installed as they are container services now
bin/dev takes care of starting/stopping services as needed when the app boots

Testing
I tested on Mac os specifcally:
clone repo as normal

[ ] bin/configure works as expected
[ ] bin/setup works as expected
[ ] bin/dev works as expected
[ ] ctrl + c out of overmind stops running containers

@Drew-Goddyn, thanks for the PR! Unfortunately this does way too much for us to be able to accept it as is.
If you can split it into several smaller PRs then we'll be able to consider each logical change on their own merits. We try to stick with small focused PRs so that they're easier to review by members of the core team, and so that downstream developers have an easier time of seeing exactly what's changed from version to version. I hope you can see where we're coming from on that point.
Other than the issue of the giant PR, a lot of these look like reasonable changes, but some of these we probably won't be able to accept at all.
Rewriting bin/dev in ruby seems like a good call and is also something that we'd be very likely to accept in a dedicated PR.
Using a single shared utils.rb between configure and setup would be something we could probably accept in a dedicated PR that does only that.
But reorganizing bin so that things live in bin/scripts/setup instead of bin/setup-scripts seems unnecessary and will potentially cause merge conflicts and/or confusion when people go to update, so we probably wouldn't accept that, even in a stand-alone PR. If you can make a solid case for why it's necessary or desirable we'd certainly give your reasons some consideration, but it would need to be something concrete and tangible. It seems like just a matter of personal organizational preference. Since people directly pull changes from the starter repo into their own projects we have to exercise more discretion than your average project when it comes to cosmetic reorganization.
All the stuff about running services in Docker is something that's less clear cut. There's been some discussion around this sort of thing in the past (as you noticed with the linked PRs) and we're not sure that this is something we're prepared to maintain and support. Speaking only for myself, I don't really like running those kinds of services in Docker because I find it to generally be slower and more "fiddly" than just running native services. If you can make a much smaller PR for only the Docker stuff then we'd be able to give your particular implementation of the idea a proper evaluation. I think we'd be more likely to accept it if it were something that people could opt into. Making a wholesale change that amounts to "this is how we do it now whether you like it or not" is going to be a much harder sell.
I'm going to close this since we can't accept it in the current form, but please do open some smaller PRs for things that you'd like to see changed.


Refactor clumsy if statements

Breaking change

No breaking changes found locally.
Proposed change

Motivation: Clumsy if statements contributes to decreased code reliability and unnecessary complexity which is a major/critical code quality issue. A standard in python projects is to follow the pydantic code formatting standards that PEP8 and other libs follow. Refactoring clumsy if statements can therefore lead to increased readability and facilitate continuous development.
Explanation:
homeassistant/components/bluetooth_le_tracker/device_tracker.py
line-192) Simplify complexity of if statement by merging outer if statement with inner
homeassistant/components/ecobee/climate.py
line-182) Simplify if statement by following pydantic standards as a result increasing readability
homeassistant/components/homeassistant_yellow/init.py
line-17) Simplify if statement by following pydantic standards as a result increasing readability
homeassistant/components/homeassistant_yellow/hardware.py
line-22) Simplify if statement by following pydantic standards as a result increasing readability
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[x] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Looks good. Both motivation and code changes are reasonable.


[BUG] The tab sometimes stick in the screen after switching files

The tab sometimes stick in the screen after switching files.
Just like this image.

Only happened when I'm using this fantastic theme, and my device is XiaoMi Pad 6 Pro.


Annotation config.kubernetes.io/apply-time-mutation not registered / documented

This is a Bug Report

Problem: https://github.com/kubernetes-sigs/cli-utils/blob/master/README.md mentions an annotation, config.kubernetes.io/apply-time-mutation. We haven't documented this in https://kubernetes.io/docs/reference/labels-annotations-taints/ (which means it's not registered).
Proposed Solution:
Document that annotation.
Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:
/language en
/sig docs

/assign

Hey @sftim, If I am not wrong this is how it's gonna look like?
config.kubernetes.io/apply-time-mutation
Type: Annotation
Example: config.kubernetes.io/apply-time-mutation: "enabled"
Used on: Deployment

/triage accepted

/triage accepted

As per this comment, there has been no activity by the assignee regarding this issue from long period.

/assign

Hi ! the below statement was made earlier regarding this annotation on the raised PR by Tim :

Is this mutation used within Kubernetes / formally being registered on behalf of a SIG? The reference to https://github.com/GoogleContainerTools/kpt/blob/main/CONTRIBUTING.md makes me wonder if it might not be.
@kubernetes/sig-architecture-pr-reviews may be able to confirm.

tagging sig architecture  here as well so the issue is noticed.
@kubernetes/sig-architecture


v13.1.6 improve Path Processor masks

Current coverage is 98.61%

Merging #268 into master will not affect coverage as of f135a25

@@            master    #268   diff @@
======================================
  Files           24      24
  Stmts          362     362
  Branches         0       0
  Methods         77      77
======================================
  Hit            357     357
  Partial          0       0
  Missed           5       5

Review entire Coverage Diff as of f135a25

Powered by Codecov. Updated on successful CI builds.


Created branch in fork and made suggestions.

This is a set of changes for OpenTelemetry that includes the information about Infinite Tracing (uri overrides). While I was adding the Infinite Tracing information (uri overrides), I made these additional suggestions I'd like you to consider:

Added Prerequisites section.
Created new section "Get the software" and moved "Published artifacts" and "Build" underneath it.
Under "Startup" changed the format of the Insights insert key and service.name so it is closer to our docs convention. Is this OK?
In the "Startup" section, I added comments in the startup examples for uri.override.
Created a new section "Change Endpoints" and created two new subsections: "EU endpoints" and "Infinite Tracing."
Made minor formatting changes in "Testing."
In "Example," I converted the material into a numbered list of steps.

I just made one more commit related to the pull request: To avoid reproducing that EU and Infinite Tracing information in various repositories (Go, .NET, and Java), I moved that information into a standalone topic in our main docs site and propose that we link to it there: https://docs.newrelic.com/docs/integrations/open-source-telemetry-integrations/opentelemetry/opentelemetry-advanced-configuration

I just made one more commit related to the pull request: To avoid reproducing that EU and Infinite Tracing information in various repositories (Go, .NET, and Java), I moved that information into a standalone topic in our main docs site and propose that we link to it there: https://docs.newrelic.com/docs/integrations/open-source-telemetry-integrations/opentelemetry/opentelemetry-advanced-configuration


Update dependencies

Codecov Report

Merging #167 (de62292) into main (64a88fa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           22        22
=========================================
  Hits            22        22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a88fa...de62292. Read the comment docs.


doc: 01-04 In-Memory Storage

Signed-off-by: Runji Wang<EMAIL_ADDRESS>

I think the doc is basically ready (except for the pictures)!


Add files via upload

File For Students Licence

@jishnu-ramachandran Please:

rename file/lib/domains/com/rvsgroup.txt to lib/domains/com/rvsgroup.txt
provide us with (in a comment here):

the university official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the university
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the students.

@philipto

The Official Website for Our College is http://www.rvsgroup.com/
The URL of a official website that offered an IT related longterm cource named MCA - Master Of Computer Applications is http://masterofcomputerapplication.rvscas.ac.in/
And i will rename the file name too

@jishnu-ramachandran Thank you for the clarification. Please rename the file in the request. It is now file/lib/domains/com/rvsgroup.txt. If your email pattern is<EMAIL_ADDRESS>the filename has to be  lib/domains/com/rvsgroup.txt
Thank you!

@jishnu-ramachandran You might miss my previous comment. Please react.

@philipto Ok. I will do that...

@jishnu-ramachandran I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the abovementioned issue. Thank you for the understanding!


Problem reading nested Octet Strings

It seems like the OctetString Reader is not capable of reading nested Octet Strings.
In our public cert file the SubjectIdentifier is stored as:
0416 	0414 		06a926722d485a3cf7ac997e47376d478fb61273
The Value of the SubjectIdentifier Extension is '041406a926722d485a3cf7ac997e47376d478fb61273' after reading the file and not '06a926722d485a3cf7ac997e47376d478fb61273' how it should be.
It seems like the Java Version correctly reads the private key, but not the public key.
If needed I can provide the public key.

@ggrote Do you have an example? When I tried to reproduce this with:
using System;
using System.Collections.Generic;
using System.IO;
using System.Text;

using Org.BouncyCastle.Asn1;
using Org.BouncyCastle.Asn1.X509;
using Org.BouncyCastle.OpenSsl;
using Org.BouncyCastle.Utilities.Encoders;
using Org.BouncyCastle.X509;
using Org.BouncyCastle.X509.Extension;

var sr = File.OpenText("cert.pem");
var pr = new PemReader(sr);

var o = pr.ReadPemObject();
var cert = new X509Certificate(o.Content);

var e = cert.GetExtensionValue(X509Extensions.SubjectKeyIdentifier);
Console.WriteLine("e=" + Hex.ToHexString(e.GetOctets()));

I got:
$ dotnet run
e=0414b18deae423a77e098eb5ee31e06add9e343765ac

Where e here seems to be the correct encoding of this parsed octet value.

I think you got the same problem with your example.
The subject identifier should be:
b18deae423a77e098eb5ee31e06add9e343765ac
The 0414 at the beginning marks another octet string (0x04) with the length 0x14 inside the octet string for the extension. Just have a look in the pen with openssl or any other tool.

@ggrote  I don't see any bug, you just aren't parsing the extension value.
An Extension has a value which is an OCTET STRING. In your example, the OCTET STRING is "041406a9...", encoded as "0416041406a9..." in the ASN.1. In the case of SubjectKeyIdentifier, that value is interpreted as an encoding of an ("inner") OCTET STRING. So to process this extension correctly, you need to actually parse the contents octets of the value OCTET STRING, which would give you back the OCTET STRING "06a9...".
Anyway, we have a convenience method for this type of thing, so just try:
cert.GetX509Extensions()?.GetExtensionParsedValue(X509Extensions.SubjectKeyIdentifier)

and you should get back the Asn1OctetString that you expect.

Okay got it.
We faced the problem using MimeKit for decrypting S/Mime Mails which uses BouncyCastle.
The Implementation is as follows:
`		///
/// Gets the private key for the certificate matching the specified selector.
///
///
/// Gets the private key for the first certificate that matches the specified selector.
///
/// The private key on success; otherwise null.
/// The search criteria for the private key.
protected override AsymmetricKeyParameter GetPrivateKey (ISelector selector)
{
foreach (var certificate in certificates) {
var fingerprint = certificate.GetFingerprint ();
			if (!keys.TryGetValue (fingerprint, out var key))
				continue;

			if (selector != null && !selector.Match (certificate))
				continue;

			return key;
		}

		return null;
	}`

Which uses the X509CertStoreSelectors Match function in which the SubjectKeyIdentifier is compared:
if (!MatchExtension(subjectKeyIdentifier, c, X509Extensions.SubjectKeyIdentifier)) 				return false;
private static bool MatchExtension(byte[] b, X509Certificate c, DerObjectIdentifier oid) 		{ 			if (b == null) 				return true; 			Asn1OctetString extVal = c.GetExtensionValue(oid); 			if (extVal == null) 				return false; 			return Arrays.AreEqual(b, extVal.GetOctets()); 		}
Shouldn't this be cert.GetX509Extensions()?.GetExtensionParsedValue(X509Extensions.SubjectKeyIdentifier) like you said?
Because now the parsed value from the incoming Mail is compared to the unparsed value from the certificate.

Any news about it?

I agree that there seems to be a problem in the selector. This code was all ported from bc-java so I think the confusion arises partly because of the behaviour of the JDK X509CertSelector class.

Okay maybe there is a problem too. In my opinion the selector should compare the inner most octet string with the given value, as this could be the only option where it could match. Otherwise this whole selector can not work.

So the problem turned out to be that the selector's SubjectKeyIdentifier is not being set appropriately by the CMS recipients (KeyAgreeRecipientInformation and KeyTransRecipientInformation).
It might be a good idea to change the way AuthorityKeyIdentifier and SubjectKeyIdentifier are set on X509CertStoreSelector, but for the moment I've just fixed the recipients.

Thank you!

@jstedfast This issue affects selection of CMS recipients (KeyAgree/KeyTrans) that are specifying SubjectKeyIdentifier (instead of the more common IssuerAndSerialNumber). I am a bit surprised that we have no test coverage of that option between BouncyCastle (even bc-java) and MimeKit, so we probably should add some.

@jstedfast I've published 2.4.0-beta.61 to allow testing of the fix.

@jstedfast With the "fix" I now get errors from MimeKit tests, and I have to take back the claim that you don't have test coverage for this case. I'm a bit confused how things used to work and why they break now though; needs more investigation.

@peterdettman I'll try to look into the test failures this weekend. Is the published fix on nuget.org?

Hmmm, odd, I installed the 2.4.0-beta.61 version and MimeKit UnitTests all passed?

Added more tests for this and now I'm getting failures for SubjectKeyIdentifier but not IssuerAndSerialNumber (using 2.4.0-beta.61). I'll check v2.3.1 as soon as the meeting I'm in is over.

all tests pass on v2.3.1

MimeKit sets the SubjectKeyIdentifier incorrectly in RsaOaepAwareRecipientInfoGenerator.Generate (also in CmsEnvelopeAddEllipticCurve method just below there). That was "cancelling out" this issue in BouncyCastle.
After updating MimeKit to use 2.4.0-beta.61, then fixing those two places in MimeKit, things go back to working (but now would be correct for third-party messages - which our test suites ought to incorporate examples of).

Ah, got it.

Edit: @ggrote presumably saw the error because he was decrypting something with MimeKit that wasn't generated by MimeKit.
I can't 100% confirm, but I'm pretty sure the service provider we got the mail from does not use MimeKit.

The commit above depends on BouncyCastle 2.4.0-beta.61
@peterdettman What I ended up doing is writing unit tests for MimeKit that would encrypt using the System.Security backend and then verifying that the BouncyCastle backend could decrypt it. Likewise, I also added a unit test that would encrypt using the BouncyCastle backend and verifying that the System.Security backend could decrypt it.
Both tests try IssuerAndSerialNumber and SubjectKeyIdentifier so that we make sure that both work in both directions.

@peterdettman what are your plans for releasing 2.4.0? I didn't realize that 2.3.1 fixed some security issues and so I'm getting requests to make a release with >= 2.3.1.

@peterdettman what are your plans for releasing 2.4.0? I didn't realize that 2.3.1 fixed some security issues and so I'm getting requests to make a release with >= 2.3.1.

@jstedfast I'm planning to release 2.4.0 this coming weekend.