Draft: Kafka queue

Codecov Report
Patch coverage has no change and project coverage change: +1.77 :tada:

Comparison is base (a88a556) 98.22% compared to head (dd2dad8) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           xkafka        #9      +/-   ##
===========================================
+ Coverage   98.22%   100.00%   +1.77%
===========================================
  Files          18         8      -10
  Lines         282        84     -198
===========================================
- Hits          277        84     -193
+ Misses          5         0       -5

see 10 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support unnamed structs in IDL

In continue of #605.
How :anchor: should support unnamed structs (syn::Feilds::Unnamed)? I see two ways:

Add arrays support to IDL.
Add a new derive macro (AnchorType for example) which will add fields names to such structs:

#[derive(AnchorType)]
struct Z(#[field(name = x)] u64, #[field(name = y)] u64);

Additional derive macro looks better for me because it adds verbosity to JS and makes things more clear.

Arrays are currently supported in the IDL. Is there anything in the current implementation lacking for your use case? For example, generic lengths can't be used at the moment.

I did not know that arrays are supported. Looks like I need to check IDL again :smile:

It would be great if transparent newtype structs were at least supported, for example:
#[derive(
    Clone, Copy, Default, PartialOrd, Ord, PartialEq, Eq, AnchorSerialize, AnchorDeserialize,
)]
#[repr(transparent)]
pub struct Address(pub [u8; 20]);

This compiles fine and generates an IDL with Address references, but the Address type itself is missing. anchor test will then run and report "success! 0 test cases" when it fails to parse the IDL 😄

Added in https://github.com/coral-xyz/anchor/pull/2824.


Python source stages now optionally receive a reference to mrc.Subscription

Description

Update existing Python sources to receive a reference to mrc.Subscription and to stop if mrc.Subscription.is_subscribed() returns False
This fixes #1838 allowing source stages to shutdown properly when a downstream error has occurred.
Update conftest.py to set the loglevel to DEBUG if the GLOG_v environment variable is defined.

Closes #1838
By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

/merge


Allow empty webhook query in SaleorAsyncWebhook()

query or queryAst is always required, even if handler doesn't need this data (or want to use default payload). It should be optional.

Closing, empty query is deprecated


Clicking a link inside frame does not work in IE

Originally submitted to Google Code by @yanne on 14 Feb 2010

See test/acceptance/keywords/frames.txt suite for a failing example.

Originally submitted to Google Code by Andreas.EbbertKarroum on 23 Apr 2010

It works in IE, but waiting on the page to load does not. Changed acceptance test to
not wait after clicking the link

Originally submitted to Google Code by Andreas.EbbertKarroum on 23 Apr 2010

This issue was closed by revision 7192b41e68.

Originally submitted to Google Code by @pekkaklarck on 24 Apr 2010

We use 'Done' status instead of 'Fixed'. Unfortunately there doesn't seem
to be option to configure the state used when issues are closed by commit
messages.

Originally submitted to Google Code by @pekkaklarck on 24 Apr 2010

Not sure was one test commented out on purpose in revision 7192b41e68.

Originally submitted to Google Code by Andreas.EbbertKarroum on 24 Apr 2010

If I had used the correct issue number in the commit comment, this would now be done
:) Anyway, this is fixed in revision 63ec6cfb68. Test is active again.

Originally submitted to Google Code by @pekkaklarck on 28 Apr 2010

Want this to be shown on the release notes generated automatically from the tracker
based on Target-xxx label.

Originally submitted to Google Code by @yanne on 27 May 2010

Major improvements warrant a major version


The Great Rename (Part 2)

Coverage remained the same at 85.317% when pulling 1a9bcde7fa5ba5aa8466d12cbeeccc4cb84ac611 on pyokagan:rename-part2 into b14e14bae62c6c2c995f9044e7d093cdeb889490 on CS2103AUG2016-T11-C4:master.

Coverage remained the same at 85.317% when pulling 1a9bcde7fa5ba5aa8466d12cbeeccc4cb84ac611 on pyokagan:rename-part2 into b14e14bae62c6c2c995f9044e7d093cdeb889490 on CS2103AUG2016-T11-C4:master.

Coverage remained the same at 85.317% when pulling 6b45d6dd9f9d9f2d19816a0f160ad5027afc4062 on pyokagan:rename-part2 into b14e14bae62c6c2c995f9044e7d093cdeb889490 on CS2103AUG2016-T11-C4:master.


Upgrade IAVL and SDK with various imrovements for v6.4

Closes: #XXX
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #907 (61809a2) into v6.x (9002356) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v6.x     #907   +/-   ##
=======================================
  Coverage   19.06%   19.06%
=======================================
  Files         167      167
  Lines       23684    23684
=======================================
  Hits         4516     4516
  Misses      18387    18387
  Partials      781      781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9002356...61809a2. Read the comment docs.


ImportError: cannot import name 'lookup_needs_distinct' from 'django.contrib.admin.utils'

i implement on Django 4.0.1 when i installed dal_admin_filter then installed in settings.py showning below
ImportError: cannot import name 'lookup_needs_distinct' from 'django.contrib.admin.utils'

Help~

From the release notes:
The undocumented django.contrib.admin.utils.lookup_needs_distinct() function is renamed to lookup_spawns_duplicates().

Its a django-autocomplete-light issue. See https://github.com/yourlabs/django-autocomplete-light/issues/1260
Seems to be resolved since v3.9.5


Not compatible with aioredis 2

When running with aioredis 2, you immediately run into ImportError: cannot import name 'create_redis_pool' from 'aioredis'
See https://aioredis.readthedocs.io/en/latest/migration/

Thanks for noticing this. I will migrate the project to be compatible with aioredis 2, for the moment I have added version lock to the pip requirements.

@Skehmatics the latest version of quart-redis now uses aioredis 2.x.


Task page shows completion that was never created

Describe the bug
Every new task shows some kind of completion, even before starting labeling anything.
To Reproduce
Steps to reproduce the behavior:

Import some tasks
Open any task
Under completions, see New completion Created undefined by Awesome User

Expected behavior
The completion list should be empty
Screenshots

I understand. It is still strange to see that, though, for various reasons:

who is Awesome user?
the completion looks like any real completion (for instance, it can be deleted, it can be set as ground truth)
it is not clear that the completion is empty (my first istinct was to try and figure out what was in there)

I suggest to not show this temporary completion on the frontend side, even if it is necessary to create it for technical reasons

who is Awesome user

I've removed Awesome user, and now it's a little bit clearly:

2 & 3.

the completion looks like any real completion
it is not clear that the completion is empty
But it has a blue point at the left and name "New completion".
Yes, it's a little bit confusing, I think we will rework this mechanics in future.

Thank you, this is already much more clear


XP Play info not parsed on Defensive Return TDs

So I've been working extensively with this data, and I've been pulling on a play by play basis. I've noticed that on plays where theres a defensive TD (Fumble return for a TD or INT for a TD) there seems to be no indication of an XP attempt. I don't know if its because they never actually post the message on the client or it's something else.

Please inspect the source data directly for the XP. If it isn't there, then there's nothing we can do.


Swift 4 / Xcode 9 support

Right now, following the steps to get started SlackKit does not seem to work with Swift 4 and its revised package manager.

Hi, I would like to add that opening in Xcode 9.x shows errors in some of the packages required for SlackKit (Swifter has 19 warnings and 3 errors which forbids me to compile). Is there a bleeding edge commit I can test with swift 4/xcode 9.x ?
Thanks

I'd be happy to merge any PRs for upgrading to Swift 4.
It might be awhile before I can update everything personally as I've got a newborn baby at home occupying my time.

Resolved in 4.1.0: https://github.com/SlackKit/SlackKit/releases/tag/4.1.0


made changes

You didn't change any significant functional thing or add a new feature so I am closing this pull request.


REQUEST: Add "Update Now" Button to subscriptions page.

Hi Mate,
Thank you again for your nice work. Hopefully your app is useful to other as it has been to me. Can emphasize that enough.
Add "Update Now" Button to subscriptions page.

Taking advantage here on this request and asking if you could also add another filter like the one you added. So we could choose to download < and >.  ;-)

I will try to add this soon, got a bit of work right now but I will have time to add it this week

Since subscriptions are no longer possible due to YouTube changes, I am closing this
Sorry I didn't get to implement it after all


Demo: Create a sample repository

Create a sample presentation + demo repository to walk through the features.

Slides

[ ] Title slide
[ ] About me
[ ] What is Demo Time
[ ] Features
[ ] Getting started
[ ] Install
[ ] Initialization
[ ] Creating your first demo

[ ] Open a markdown preview
[ ] Open a second markdown preview
[ ] Create a new file + add code
[ ] Highlight some code
[ ] Run a terminal command

Documentation

[ ] How to create good demos - splitting, starter templates, ...


Add named exports for extent

I am so happy to see us finally moving in this direction. Thanks Andreas and Tim!
I hope to cut some time tomorrow for looking into this, if you review each other before that, that is fine as well.

@ahocevar, I remember to have seen a discussion about using named exports and their benefit in some comments of an issue, but I could not find it again.
Do you have information or a pointer? Is it an improvement for tree shaking?

@gberaudo I don't find the ticket comment either. But we discussed in a meeting a while ago. Anyway, this is indeed an improvement for tree shaking.

This is now ready for review.

(disclaimer: I've no es6 module experience)
Not specific to this pull request but I don't understand why we are using named and default export:
// foo.js
export function bar() { ... }
export function baz() { ... }

export default {
  bar: bar,
  baz: baz
};

Is it to be able to support the following use import ?
import foo from 'foo.js'

foo.bar();
foo.baz();

And:
import {bar, baz} from 'foo.js'
bar();
baz();

Exactly, and mostly for compatibility with the existing ol package. We will provide a codeshift transform to update the paths (CamelCase classes instead of lowercase), and running that transform is all that ol v4.x users will need to do to upgrade.

Regarding the default export, it might be worth revisiting this before release.  In the transform, we could rewrite things like this:
// using ol@4
import extent from 'ol/extent';

// using ol@5
import * as extent from 'ol/extent';

This would be relatively straightforward to implement if we consistently provide named exports from lowercase modules (and provide a default export from uppercase modules).
I don't think we should make any more changes in this branch though.  We can remove the default exports after preparing the transform.

I've also read that the default export can be created by importing and exporting itself:
// foo.js
import * as myself from './foo.js';
export default myself

export function bar() { ... }
export function baz() { ... }

I've opened #7580 to get rid of the default export from ol/index.js.  I think we can follow the rules mentioned there and still provide a decent upgrade path for ol@4 users.


it is not clear how file journals_cumulative_path.txt is made

scripts cumulative.py and TETTRIs-mapping-taxonomists\src\data\gender.py both require the file journals_cumulative_path.txt as input, but it is not clear how this file is created or where it comes from.

cumulative.py makes journals_cumulative_path.txt. I added some clarification in the comments


[feat][website] REST API URL does not go to the correct place

All REST API URL on Pulsar documentation has this issue.
Website: https://pulsar.apache.org/docs/en/next/admin-api-tenants/

@urfreespace thinks the anchor does not work correctly but we have not figured out how to solve this issue
Anyone would like to fix it? Thanks

Feedback from @BewareMyPower:
Hi, I'm reporting a bug of the new website again:joy:The rendering of the REST API is wrong. See https://pulsar.apache.org/docs/next/schema-manage/#topic-level.
We can see GET /admin/v2/topics/:tenant/:namespace/:topic. However, the original text is
{@inject: endpoint|GET|/admin/v2/topics/:tenant/:namespace/:topic|operation/schemaCompatibilityStrategy?version=[[pulsar:version_number]]}
It's frustrated that I cannot compare it with the rendering of the old website. (should we add an entry point to the old website?) But the rendering result should be like the 2nd image.
BTW, I think the description Send a PUT request to this endpoint: is redundant. See the 3rd image from https://pulsar.apache.org/docs/next/admin-api-topics.

@Anonymitaet you can access the old website here: https://pulsar.staged.apache.org/ (it's the old website backup, it will be closed AFTER the new site is stable)

@urfreespace OK, thanks!

The pr https://github.com/apache/pulsar-site/pull/127 submit, maybe fix this problem

@momo-jun I check some occurrences on master, and they do not function well. For example:

https://pulsar.apache.org/docs/next/admin-api-functions
Can you take a look? Thank you!

@momo-jun your PR was merged 3 hours ago and the website build was done 4 hours ago, maybe that is the reason why the new changes do not take effect. Let's wait for a while to see if it works.

Master only. I want to verify whether they work well before applying the changes to more versions.

@momo-jun
I check some occurrences randomly and find that:

It shows loading all the time, do you have the same issue?
package: https://pulsar.apache.org/docs/next/admin-api-packages

Some contain version while others not, is this intended behavior?

Left: https://pulsar.apache.org/docs/next/admin-api-packages
Right: https://pulsar.apache.org/docs/next/admin-api-tenants

Same on my side. I checked the MD file and its syntax {@inject: endpoint|POST|/admin/v3/packages/:type/:tenant/:namespace/:packageName/:version} doesn't contain any anchor nor the version number variable, that's why it cannot be loaded. Since it doesn't contain the version number variable, such cases are not covered in the previous fix. I need to use a new search term to clean up this type of occurrence. Thanks for your check.

It shows loading all the time, do you have the same issue?
package: https://pulsar.apache.org/docs/next/admin-api-packages

The version we can see here does not refer to the injected version number, but a static text. The display text is correct. The only issue is the same as above - the syntax needs to be fixed by adding a version number variable and an anchor.

Some contain version while others not, is this intended behavior?

Left: https://pulsar.apache.org/docs/next/admin-api-packages
Right: https://pulsar.apache.org/docs/next/admin-api-tenants

When searching for the remaining incorrect REST API links, I found the REST API docs missed "lookup topic" and "get bundles".
@shibd helped checked the issue in code and pushed a PR-#16470  to fix it.
I've fixed other incorrect REST API links in #16433 and will update for  "lookup topic" and "get bundles" as soon as #16470 is merged.

This issue can be closed after #16746 is merged. Any other problematic occurrence is an individual case of error.


CMake failed

I tried to follow the build/install instructions. It failed whilst building vender/llama
Building wheels for collected packages: llmsearch, llama-cpp-python
  Building wheel for llmsearch (pyproject.toml) ... done
  Created wheel for llmsearch: filename=llmsearch-0.6.1.dev0+g5243360.d20240214-py3-none-any.whl size=51977 sha256=88d36d6f58cf861648ea59aca6b622c60902d85e9ed073303d41fe789458c350
  Stored in directory: /home/brad/.cache/pip/wheels/19/34/30/d9d88eb34ce7925c34d871c614b71065630f4ba7aff90abcf6
  Building wheel for llama-cpp-python (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for llama-cpp-python (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [44 lines of output]
      *** scikit-build-core 0.8.0 using CMake 3.28.3 (wheel)
      *** Configuring CMake...
      loading initial cache file /tmp/tmpof6qnuza/build/CMakeInit.txt
      -- The C compiler identification is GNU 11.3.0
      -- The CXX compiler identification is GNU 11.3.0
      -- Detecting C compiler ABI info
      -- Detecting C compiler ABI info - done
      -- Check for working C compiler: /usr/bin/cc - skipped
      -- Detecting C compile features
      -- Detecting C compile features - done
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Check for working CXX compiler: /usr/bin/c++ - skipped
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      -- Found Git: /usr/bin/git (found version "2.41.0")
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
      -- Found Threads: TRUE
      -- Could not find nvcc, please set CUDAToolkit_ROOT.
      CMake Warning at vendor/llama.cpp/CMakeLists.txt:381 (message):
        cuBLAS not found

      -- CUDA host compiler is GNU
      CMake Error at vendor/llama.cpp/CMakeLists.txt:784 (get_flags):
        get_flags Function invoked with incorrect arguments for function named:
        get_flags

      -- ccache found, compilation results will be cached. Disable with LLAMA_CCACHE=OFF.
      -- CMAKE_SYSTEM_PROCESSOR: x86_64
      -- x86 detected
      CMake Warning (dev) at CMakeLists.txt:21 (install):
        Target llama has PUBLIC_HEADER files but no PUBLIC_HEADER DESTINATION.
      This warning is for project developers.  Use -Wno-dev to suppress it.

      CMake Warning (dev) at CMakeLists.txt:30 (install):
        Target llama has PUBLIC_HEADER files but no PUBLIC_HEADER DESTINATION.
      This warning is for project developers.  Use -Wno-dev to suppress it.

      -- Configuring incomplete, errors occurred!

      *** CMake configuration failed
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for llama-cpp-python
Successfully built llmsearch
Failed to build llama-cpp-python
ERROR: Could not build wheels for llama-cpp-python, which is required to install pyproject.toml-based projects

Any ideas?

I hadn't installed the nvidia cuda support. Installed it and now the install finishes.


(For Vik/Duy) Switching XCom serialization logic

Purpose:

https://github.com/SiftScience/code/issues/31076
XCom data serialization works fine with all API calls except for when writing from the Admin UI. This should fix it (and, in certain ways, clean up the serialization logic in the SQLAlchemy model)

Technical overview:

The SQLAlchemy model says that the "data" field in the xcom table is a binary field. It is populated with either a pickled version of an object (legacy mode, but the one we use), or an UTF-8-encoded json string.
The way this translation happens is by making sure that all the set and get operations go through some transformation function. And that works for most use cases, except for the Admin UI, which uses flask-admin and goes directly from the form to the SQLAlchemy model. That means that it tries to write a string into a binary field.
The actual solution is to not call it a binary field, but some type we control and then provide a serialization/deserialization in the type format itself. This means that we don't have to deal with doing serialization/deserialization in the getters/setters, which have also been removed.

Testing/deployment plan:

Tested manually overwriting Airflow and it seemed to have worked
Working on deployment mechanism by hosting our own PyPI repo
Tried to run the unit tests, but was unable to do it.

Yes, there is more to it. And that's what I'm working on right now (well, while I still try to figure out why truncation validation failed). More information on the issue that is linked above.

With great power comes great operational cost (i.e., we'll need to migrate whatever solution we come up with for PyPI to GCP)


This repository needs a rewrite

This repo was written in the context of Apigility.  It is very useful in Apigility but the name of this repository and what it does best is to populate a QueryBuilder based on an array.  For instance this is used in api-skeletons/zf-doctrine-graphql where Apigility shouldn't be a requirement.
Specific problems

Hydrator\Strategy\CollectionLink is specific to Apigility.  This strategy is duplicated in api-skeleletons/zf-doctrine-hydrator (which also has strategies in the same tool type as this strategy)
Query Providers are specific to Apigility.  I think these classes would do well in their own repository.

And with these out of the way this repo can do the job of array > Query Builder cleanly.
I'm willing to do this for a cleaner repo.  What do you say?

This repository has been closed and moved to laminas-api-tools/api-tools-doctrine-querybuilder; a new issue has been opened at https://github.com/laminas-api-tools/api-tools-doctrine-querybuilder/issues/2.


Update Composer dependencies (2021-01-13-00-07)

Visual regression test passed!
View the visual regression test report

Visual regression test passed!
View the visual regression test report


Register and Login pages - cosmetics

This is about the UI of these pages:
https://bookmark.org/users/register
https://bookmark.org/users/log_in
The style of these forms should be changed to match the style of the "Add archive" form on https://bookmark.org/
That means, no white background, larger input fields, rounded corners etc

Duplicated requirement -> https://github.com/bookmark-org/bookmark/issues/66


Allow sending data to multiple endpoints

Currently data can only be sent to a single endpoint that has been configured in the settings. It would be useful to be able to contribute data to multiple different location services
Think about:

What to do when uploading to one endpoint succeeds but uploading to another fails?

If we want to make sure that data is uploaded to each endpoint exactly once, we need to keep track for each report where we have successfully sent it

When to show reports as uploaded in the UI, after they have been uploaded to at least one endpoint or all of the endpoints?

Tying this a bit to #113, upon inserting a new endpoint, one should be able to select whether the endpoint is to receive ichnaea format or wigle format (once it is implemented)
In regards to the questions: The reports could form a queue per endpoint that upon successful upload increments an upload counter (internal to the app, no need to be exportable) placed per report in the report list view. When all endpoints are satisfied, then the report can finally vanish from the list

I just created https://gitlab.com/sim6/geocollector to submit my collected data, maybe can help some of you.


OpenGOAL Debugger - Reading/Writing Memory

The debugger will need to attach to the runtime and read and write its memory.  In Linux we can do this with ptrace. There's probably a Windows equivalent.
We should also be able to disassemble code. Writing an x86-64 disassembler is hard so we could use a library like https://github.com/zyantific/zydis

Done in https://github.com/water111/jak-project/pull/109


Polonium not installing in Plasma 6

Describe the bug
I added the libsForQt5.polonium nixpkg to my plasma 6 configuration but it does not appear despite being present in the kwin folder in /run/current-system/sw. Perhaps a package titled kdePackages.polonium needs to be added for Plasma 6.
Steps To Reproduce
Steps to reproduce the behavior:

Add libForQt5.polonium to configuration.nix
sudo nixos-rebuild switch
reboot
polonium missing in kwin scripts control panel.

Expected behavior
After adding polonium to configuration.nix, rebuilding, and rebooting, polonium should appear in the kwin scripts control panel.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

its because the latest release 0.6.0 is not compatible with plasma 6. there is a pre-release that is, but its currently not in the nixpkgs i guess

Should I request a version update to the latest build?
[image: photo]
Carlos Echenique
Photographer at  CE Photography
P<PHONE_NUMBER>  <305.219.2433>
E  @.***  @.***>
W ce.photography
https://mailtrack.io/l/dce29d1298ced17f1a7990d9fb8207a4931ea7f5?url=https%3A%2F%2Fcephotographic.com&u=3957204&signature=38a9c74908e43b18
https://mailtrack.io/l/47d8d10079c153a1520a6ef39d88862cbcf959a8?url=http%3A%2F%2Finstagram.com%2Fcephotographic&u=3957204&signature=07ea563810ead936
https://mailtrack.io/l/4300ae6c6548c49ccf1472d75ab41188e16eafcb?url=http%3A%2F%2Ffacebook.com%2Fcephotos&u=3957204&signature=05ff67aff59c7362
https://mailtrack.io/l/ba97a24623b749f1a72fcf0ae2b86f39dc7de0e4?url=http%3A%2F%2Fwww.flickr.com%2Fphotos%2Fechenique&u=3957204&signature=fed9194ce0149cfe
On Tue, Mar 5, 2024 at 2:15 AM Leonard-Orlando Menzel <
@.***> wrote:

its because the latest release 0.6.0 is not compatible with plasma 6.
there is a pre-release that is, but its currently not in the nixpkgs i guess
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/293409#issuecomment-1978100844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYBYQCJ2B3SXW2NYA7PSYTYWVWIXAVCNFSM6AAAAABEGN5VHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGEYDAOBUGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


chore: reduce browser targets

https://browserslist.dev/?q=bGFzdCA1IENocm9tZSB2ZXJzaW9ucywgbGFzdCA1IEVkZ2UgdmVyc2lvbnMsIGxhc3QgNSBPcGVyYSB2ZXJzaW9ucywgbGFzdCA1IEZpcmVmb3ggdmVyc2lvbnM%3D
Friend noticed this should be further reduced

Tested build and dev with Chrome and dev with Firefox

do you know what caused the broken build last time?

do you know what caused the broken build last time?

Missed the browserlist update I believe  which lead to: https://github.com/getAlby/lightning-browser-extension/pull/911/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR6611-R6614


The commands are wrong in the documentation

The /e command was specified with an incorrect description:
/s | Copies subdirectories. This option automatically excludes empty directories.
/e | Copies subdirectories. This option automatically excludes empty directories.
It should be
/s | Copies subdirectories. This option automatically excludes empty directories.
/e | Copies subdirectories. This option copy subdirectories, including Empty ones.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bf2281d4-1470-0658-ec5a-687fe2cd451c
Version Independent ID: 2ce2be3e-e3a2-790c-3bff-90efe7318450
Content: robocopy
Content Source: WindowsServerDocs/administration/windows-commands/robocopy.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Closed in commit https://github.com/MicrosoftDocs/windowsserverdocs/commit/bbd9904c2b6a53f4543fdd1fc5fd50acd4a4fed9 . See also issue ticket #4759 for duplicate issue report.

#please-close

#please-close


add option to sort asc or desc in sort functions

example: ModxContentModel::where('alias','=','/about-us')->sortPublished('desc')->get();

made a parameter for that, and by default it's DESC so you get the latest published resource first.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Terver Aosu

Discord Username(if exists):

terveracode#4610

Additional Context:

Twitter

I want to start contributing to open source
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Update Contributing guidelines !!

I would like to update the contributing guidelines for this project so that if a new person is approaching your repo then :

He/She gets access to the code with proper comments.
Know the basic structure of your repo.
Clear with the git commands to contribute.
What features to add or improvements to make.

Yes. Please do this. It would be better.

@codeAbinash Assign me this issue.

@utkarsh006 Done 😊

@utkarsh006 README.md has been updated, guideline has been given, code example is given, this issue is not longer available.

@ArshErgon R u Project Admin or collaborator of this repo? If Yes then u must know that it's the need for this repo. If No, then kindly create another issue and a PR to justify your changes. Let others do their work.

@ArshErgon  Wow, see what I found https://github.com/codeAbinash/leetcode-solutions/pull/3 https://github.com/codeAbinash/leetcode-solutions/pull/5 anything else you wanna say?

@ArshErgon Firstly I am not here to argue. Secondly, I haven't made my PR yet. Kindly let others work.

@utkarsh006  he already did, and he merge my branch

@utkarsh006 I added the pull_request_template.md too, please check it. And anything else to change or edit?

@ArshErgon Great to hear that. Let Project Admin decide what to do or not.

@codeAbinash I will update you with my PR tomorrow. Thanks :)

Thankyou @utkarsh006 , you are always welcome for contributing 💚

@codeAbinash make a small video of your project and tweet it with #leetcode #opensource, from there we will retweet it, that's how you will get more contributors, do the same with on linkedin


Stdin support

Work in progress.
This PR introduces the possibility of running gcvis with the content of Stdin.
@davecheney if you have any advice on adding integration tests on the CLI, I'm all ears :smile:.

@davecheney quick update: I think it's in a ready state.
I added an example folder for the sake of proving what it should be like now with stdin support. Ideally that should be part of the test suite... Something I'll probably do later :smile:.
Let me know what you think of this.


[docs] GettingStarted: Tweak one more Ninja target suggestion to work on Apple Silicon

Thanks to @Rajveer100 for noticing this.
See https://github.com/apple/swift/issues/62017

@swift-ci please smoke test

Thanks to @Rajveer100 for noticing this.
See #62017

Thanks for mentioning me...I should thank you too for believing and uplifting me from the very start when I didn't even have my setup done to fixing my first issue, and coincidentally solving other issues while building and debugging various fixes...

@swift-ci please smoke test


[Question] Set a ReadOnly policy to a bucket ?

Hello,
I'm discovering the minio sdk and have a probably simple question have policies. I was looking for 'How am i suppose to create a bucket and set a policy to make it "readonly" for anonymous access'. Creating a bucket was as easy, but it looks like creating a policy is cleary not. I was expecting an api like client.SetBucketPolicy("myBucket", policy.ReadOnlyPolicy), but i feel like I must craft some JSON ? Am I missing something obvious ?
Thanks a lot for your help!

I'm discovering the minio sdk and have a probably simple question have policies. I was looking for 'How am i suppose to create a bucket and set a policy to make it "readonly" for anonymous access'. Creating a bucket was as easy, but it looks like creating a policy is cleary not. I was expecting an api like client.SetBucketPolicy("myBucket", policy.ReadOnlyPolicy), but i feel like I must craft some JSON ? Am I missing something obvious ?

@JulienTant you need to look at examples here  https://docs.minio.io/docs/golang-client-api-reference#SetBucketPolicy  .  To construct a policy you should use https://awspolicygen.s3.amazonaws.com/policygen.html

Hi,
Thank you for your response. I ended out using mc to create a download policy, then coding a small utility to download the policy, and then reused it in my codebase ^^

I'm going to make this a feature request. If we can do mc policy download http://minio:9000/images it would be nice to also do s.Client.SetBucketPolicy("images", "download")

Please open the issue in mc @lukepighetti

This is a mini-go issue, the inability to easily set a bucket policy with the shorthand keywords like download

We used to have that, but it is intentional the way it is right now. Because we cannot satisfy all policy requirements and variations - so we will not be implementing it @lukepighetti

The fragmentation between mc and minio-go feels incomplete. Do you plan to remove canned style from mc?

mc is a higher level tool, it does both custom policy and canned - minio-go is library they are not meant to replace each other

I understand and respect your position but I do think this would add significant ease of use to minio-go users. Thank you for your consideration.

I understand and respect your position but I do think this would add non-trivial ease of use/developer experience to minio-go users. Thank you for your consideration.

Yes, we had that in mind but there were many who wanted a more elaborate input. That is when it was found that taking a JSON input would satisfy everyone.   We can additionally add SetCannedBucketPolicy() like APIs, feel free to open a new github issue we will take a look.


Make theme able to load custom javascript

Look for the field 'customScript' in editorTheme (settings.js)
Add it to mustach context
Load list on template side (index.mst)

Coverage decreased (-0.08%) to 87.226% when pulling 9d8872552beca59202ab1dffae6f29fe64c8d58e on david-alex-cohen-zone:editor-custom-js into b2390f1cafefb413f4413e069d1de12f900e6b94 on node-red:master.

Coverage decreased (-0.08%) to 87.226% when pulling 9d8872552beca59202ab1dffae6f29fe64c8d58e on david-alex-cohen-zone:editor-custom-js into b2390f1cafefb413f4413e069d1de12f900e6b94 on node-red:master.

Coverage decreased (-0.08%) to 87.226% when pulling 9d8872552beca59202ab1dffae6f29fe64c8d58e on david-alex-cohen-zone:editor-custom-js into b2390f1cafefb413f4413e069d1de12f900e6b94 on node-red:master.


Add Alaz to observability

This PR has been inactive for over a year, I'm closing it. Please update and re-open if still relevant.


weave net CNI support

Hi, first of all, I wanna say thanks for a nice attempt for solving this K8s egress problem, if I understand right, this solution doesn't support weave net CNI for now? I tried to test it on my own on-premise K8s cluster with Weave CNI but it looks like it does not work properly.

I would like to request this too.


Change account to payment pointer

Update Rafiki to not reference accounts but rather be reference provisioning Payment Pointers

requires https://github.com/interledger/open-payments/pull/145 and https://github.com/interledgerjs/interledgerjs/pull/294

related to https://github.com/interledger/rafiki/issues/296


[AST/Diagnosis] Add originalType to UnresolvedType, similar to existing ErrorType support.

This preserves more info (i.e. archetypes) for error messages found via the contextual type passed into typeCheckChildIndependently(). Showing _ in a type during diagnoses when the problem isn't structural is very misleading.
Inspired by SR-8644, prior to this PR produces
error: cannot convert value of type '(U) -> Z?' to expected argument type '(_) -> _?'

after:
error: cannot convert value of type '(U) -> Z?' to expected argument type '(T) -> Z?'

@swift-ci Please smoke test.

Jenkins crashed
@swift-ci please smoke test macOS platform

Yeah, exploring this a bit more, avoiding rechecking expressions is definitely the way to go. The problems this approach fixes are pretty limited.


wasm: strip port from host when match host

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes #616
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #626 (35d8471) into main (26654ae) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   35.42%   35.30%   -0.13%
==========================================
  Files          71       71
  Lines       10240    10240
==========================================
- Hits         3628     3615      -13
- Misses       6327     6338      +11
- Partials      285      287       +2

see 2 files with indirect coverage changes


Fix#252

This fixes #252, which is in fact the issue @chrisbrossard were having in #301 besides OOM. As you can see in #301, @chrisbrossard tested the changes and confirmed it fixes the issue. However it is hard to tell why this problem shows up now while i haven't seen it for a while.
In fact, i already made a PR for this. But it was never merged because it included other changes related to other issues. We already discussed the change made here, in #261, and you finally agreed the changes.
Version bumped to 2.1.7

Also, about the badge, i noticed that if we include this in readme.md :
https://img.shields.io/badge/TileView-2.1.7-blue.svg
it creates the badge on the fly. So all we have to do is to update the version number in the url. What do you think?

re: PR, looks great, i remember it a bit, read up on it again, makes sense, +1.  i'll merge when i have a few minutes to generate artifacts.  do you want me to set you up on bintray so you can publish artifacts?
re: badge - i think the url you pasted is bad (it has the version number hardcoded in the URL)
thanks

I will be available starting from tomorrow evening (so for you it is in about 20 hours). If you do it in the meantime, it's ok.

I don't mind doing it, but do you want to be set up for releases in the future?

Sure. When I make a PR and you are OK with it, this could speed things up if i can generate artifacts.

cool.  do you have a https://bintray.com/ account (that's jcenter)?  if so, what's your user?  you can email me directly if you want (also, fwiw, you're free to email me directly any time).  i'll also post the gradle script i use to generate the aars...

No don't have an account yet. I will create one tomorrow and I will email you.

:thumbsup:

also, about the badge, the one i have in the readme auto-updates, i just forgot to draft a new release.  i just did so and it updated as expected.
anyway, ttyt

I sent you an email at your address associated with your bintray account. Idk if you use the same for github.

I got it, I'll try to get everything set up tonight

i think my emails might be going in your spam...?

Sorry, i completely forgot i didn't have notifications for this email address and haven't read your mail until now.
So i agree for merge and publish.

I just made some tests again to double check. No issues. Let's merge..


Shorten forced fit measurement names

Fix #733.

These changes implicitly limit the number of forced fits measurements per source to be 1000. That's more than sufficient to handle the VAST survey (it will be at absolute most 400 measurements per source), but it could come into play in the future. I've documented that limitation in the changelog, but I feel like it should be mentioned somewhere else in the docs just in case. Any thoughts @mauch?


bump versions

I updated the version of the dependencies:
ndarray: 0.13 => 0.14
approx: 0.3.2 => 0.4
ndarray-rand: 0.11 => 0.13
rand: 0.7 => 0.8

Thanks for this. I am away from keyboard until Monday but will check it out then. Did all the tests pass with the new versions?

Yes, all tests passed. Thank you for the very useful crate!


How do we handle API related rate  and limits when using this?

I'll close this since the question is too vague, and I'm not sure how to discuss this.


Array Mismatch in NIRSpec data

This issue pertains the NIRSpec data from the tiny NIRSpec files uploaded by @AarynnCarter in BOX
I'm still unsure about the nature of the issue and whether it is a Eureka error or a data error, but after a conversation with @taylorbell57 and his experience with a similar issue, I'm officially opening this issue for other people to take a look at it.
THE ERROR

THE ISSUE
The error occurs affter running Eureka's S2 wrapper on the JWST pipeline and then trying to use the resulting file on Eureka's Stage 3, the error appears during the S3 run. It seems that an array mismatch happens between the subdata and subgain arrays (the trimmed data and gain arrays). After further tracking the issue, it seems the subgain array only has 2 dimensions (x,y) but the subdata array contains 3 (n,x,y) of which n stands for a single iteration. Eureka is not doing anything to trim that third dimension and therefore the arrays have a mismatch. Yet, even after zeroing in on a single iteration and trimming the subdata array to, say, [0, : , : ] there is still a mismatch in the x dimension between the subdata and subgain arrays that I was unsure how to trace since I am not too familiar with the actual nature of the files themselves. Hence this issue being opened.
THE FILES USED FOR THIS PARTICULAR RUN

Data Simulation Working Group/NIRSpec/Tiny/jwdata0010010_11010_0001_NRS1_TINY_uncal.fits (used to run Eureka's S2 on it)
Data Simulation Working Group/NIRSpec/Ancillary Files

HANDWRITTEN NOTES ON THE ISSUE
IN-DEPTH NOTES ON ISSUE

I can take a look at this over the next few weeks, hopefully it's nothing too serious and just me doing something wrong when I made the files.
@gianninapr Thanks for making the effort to detail everything and provide your hand-written notes! I'll let you know if I have any questions :)

@gianninapr Did you run Stage 2 directly on the _uncal.fits file? Or did you process it through Stage 1 / the JWST pipeline first? If it's the former, I expect that might be why we are having issues with array mismatches, as the _uncal.fits file has each individual ramp image, whereas the _rateints.fits file (output from Stage 1) has a single image for each integration.
Obviously Stage 1 isn't up and running yet, so if it is the above then once we get some clarity on JWST package versions I can test all of this again when I try to merge the Stage 1 updates with the main branch.

@AarynnCarter Hi! Sorry, I just checked and I copied the wrong filename into the issue here, but I did use the rateints file to run Stage 2 as you describe, not the uncal file. @jbrande is running it on his own with the same file to see if the error is replicated. I'll update the issue description when I'm on my computer!

@gianninapr No worries! Probably something more involved then.
Since I messaged, David Sing and I have started up making new NIRSpec data for the upcoming March meeting. As a result, I’m probably going to hold off looking at this until I have the new dataset ready. They may well have exactly the same issue (I’m betting they will), but I don’t want to commit too much time if it’s an issue unique to this dataset.
@jbrande Thanks for taking a look on your end!
We’re hoping to have things ready in the next week or so, at which point I’ll also produce a new tiny dataset for testing!

@jbrande Sounds good, I'll reach out at some point next week when I have things more organised!

Okay I'm not getting this issue with the new tiny NIRSpec dataset, and s3 is running to completion (albeit the results still aren't great yet).
@gianninapr Could you grab the new dataset and run Stage 2 and 3 again to see if this error still persists? I've attached the .ecf files I used below. Also, if you happen to see the same error as #108, let me know!
Data: https://app.box.com/folder/154382715453?s=tj1jnivn9ekiyhecl5up7mkg8xrd1htl
ECF's: why_does_github_hate_ecfs.zip

@AarynnCarter I think I'm actually in charge of this now, I'll take a look.

Great, thanks!

yes @AarynnCarter sorry about that! Because I have a master thesis to present this semester I passed the baton to Yoni on this respect. I'll still be around if you have anything you want me to take a look at but I'm probably best reached through the Slack since Github notifications are sent to one of my secondary emails and it may get lost!

Is this still an issue that we need to worry about, or can we close this issue now?

Yeah, we fixed this a while ago.


Add content/pt-br/docs/reference/glossary/userns.md

Added translate content/pt-br/docs/reference/glossary/userns.md

/lgtm

/approve

Thanks


Slider, divisions: 175 / 350, the result is not always 0.5. Is that ok by default?

Hey, if I didn't make any mistake the Slider when using the divisions set to 175 / 350 should have as a result a double increasing or decreasing by 0.5, right?
                              child: Slider(
                                value: weight,
                                min: 25,
                                max: 200,
                                divisions: 350,
                                // activeColor: Color(0xFFEB1555),
                                onChanged: (double newValue) {
                                  setState(() {
                                    weight = newValue;
                                  });
                                },
                              ),

Hi @haizen007
Please try code sample

Code Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  double weight = 50;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Text(weight.round().toString()),
            Slider(
              value: weight,
              min: 25,
              max: 200,
              divisions: 350,
              // activeColor: Color(0xFFEB1555),
              onChanged: (double newValue) {
                setState(() {
                  weight = newValue;
                });
              },
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

This is probably due to drag precision
Thank you

Hey, thanks, I solved using:
weight.toStringAsFixed(1),
But my point is, I thought Flutter by default wouldn't need to do that because sometimes was:
128.0
128.5
Was ok, but sometimes:
127.9999999...
so it's strange behavior.

CC @clocksmith

Duplicate of https://github.com/flutter/flutter/issues/39510

Closing as duplicate of https://github.com/flutter/flutter/issues/39510

Closing as duplicate of https://github.com/flutter/flutter/issues/39510


Linting

Some errors remain in the generated clients' doc files:
><EMAIL_ADDRESS>lint C:\Users\sawch\dev\nodejs-logging
> repo-tools lint --cmd eslint -- src/ samples/ system-test/ test/

lint: Linting files in: C:\Users\sawch\dev\nodejs-logging
lint: Running: eslint src/ samples/ system-test/ test/

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_api_label.js
  38:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_api_monitored_resource.js
  94:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_logging_type_http_request.js
  87:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_protobuf_any.js
  121:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_protobuf_duration.js
  84:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_google_protobuf_timestamp.js
  88:4  error  Insert `⏎`  prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_log_entry.js
  128:5  error  'LogEntry' is assigned a value but never used                no-unused-vars
  154:5  error  'LogEntryOperation' is assigned a value but never used       no-unused-vars
  181:5  error  'LogEntrySourceLocation' is assigned a value but never used  no-unused-vars
  183:3  error  Insert `⏎`                                                   prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_logging_config.js
  117:5   error  'LogSink' is assigned a value but never used            no-unused-vars
  128:1   error  Delete `⏎`                                              prettier/prettier
  142:10  error  Insert `,`                                              prettier/prettier
  143:4   error  Insert `,`                                              prettier/prettier
  171:5   error  'ListSinksRequest' is assigned a value but never used   no-unused-vars
  191:5   error  'ListSinksResponse' is assigned a value but never used  no-unused-vars
  211:5   error  'GetSinkRequest' is assigned a value but never used     no-unused-vars
  250:5   error  'CreateSinkRequest' is assigned a value but never used  no-unused-vars
  291:5   error  'UpdateSinkRequest' is assigned a value but never used  no-unused-vars
  312:5   error  'DeleteSinkRequest' is assigned a value but never used  no-unused-vars
  314:3   error  Insert `⏎`                                              prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_logging_metrics.js
   65:5   error  'LogMetric' is assigned a value but never used               no-unused-vars
   74:1   error  Delete `⏎`                                                   prettier/prettier
   83:10  error  Insert `,`                                                   prettier/prettier
   84:4   error  Insert `,`                                                   prettier/prettier
  109:5   error  'ListLogMetricsRequest' is assigned a value but never used   no-unused-vars
  129:5   error  'ListLogMetricsResponse' is assigned a value but never used  no-unused-vars
  144:5   error  'GetLogMetricRequest' is assigned a value but never used     no-unused-vars
  167:5   error  'CreateLogMetricRequest' is assigned a value but never used  no-unused-vars
  191:5   error  'UpdateLogMetricRequest' is assigned a value but never used  no-unused-vars
  206:5   error  'DeleteLogMetricRequest' is assigned a value but never used  no-unused-vars
  208:3   error  Insert `⏎`                                                   prettier/prettier

C:\Users\sawch\dev\nodejs-logging\src\v2\doc\doc_logging.js
   42:5  error  'DeleteLogRequest' is assigned a value but never used                          no-unused-vars
  111:5  error  'WriteLogEntriesRequest' is assigned a value but never used                    no-unused-vars
  121:5  error  'WriteLogEntriesResponse' is assigned a value but never used                   no-unused-vars
  139:5  error  'WriteLogEntriesPartialErrors' is assigned a value but never used              no-unused-vars
  195:5  error  'ListLogEntriesRequest' is assigned a value but never used                     no-unused-vars
  222:5  error  'ListLogEntriesResponse' is assigned a value but never used                    no-unused-vars
  243:5  error  'ListMonitoredResourceDescriptorsRequest' is assigned a value but never used   no-unused-vars
  263:5  error  'ListMonitoredResourceDescriptorsResponse' is assigned a value but never used  no-unused-vars
  292:5  error  'ListLogsRequest' is assigned a value but never used                           no-unused-vars
  312:5  error  'ListLogsResponse' is assigned a value but never used                          no-unused-vars
  314:3  error  Insert `⏎`                                                                     prettier/prettier

And in the client, about todo comments. I actually started removing these, but wasn't sure how to handle:
C:\Users\sawch\dev\nodejs-logging\src\v2\logging_service_v2_client.js
  26:1  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\src\v2\metrics_service_v2_client.js
  26:1  warning  Unexpected 'todo' comment  no-warning-comments

Samples aren't too happy, either:
C:\Users\sawch\dev\nodejs-logging\samples\fluent.js
  18:23  error  "express" is not found            node/no-missing-require
  26:32  error  "fluent-logger" is not found      node/no-missing-require
  53:33  error  'next' is defined but never used  no-unused-vars

C:\Users\sawch\dev\nodejs-logging\samples\logs.js
   21:27  error  "@google-cloud/logging" is not found          node/no-missing-require
   66:26  error  "bunyan" is not found                         node/no-missing-require
   69:33  error  "@google-cloud/logging-bunyan" is not found   node/no-missing-require
  103:34  error  "@google-cloud/logging-winston" is not found  node/no-missing-require
  129:33  error  "@google-cloud/logging-bunyan" is not found   node/no-missing-require
  143:34  error  "@google-cloud/logging-winston" is not found  node/no-missing-require
  158:27  error  "@google-cloud/logging" is not found          node/no-missing-require
  192:27  error  "@google-cloud/logging" is not found          node/no-missing-require
  224:27  error  "@google-cloud/logging" is not found          node/no-missing-require
  265:27  error  "@google-cloud/logging" is not found          node/no-missing-require
  336:21  error  Empty block statement                         no-empty

C:\Users\sawch\dev\nodejs-logging\samples\quickstart.js
  20:25  error  "@google-cloud/logging" is not found  node/no-missing-require

C:\Users\sawch\dev\nodejs-logging\samples\sinks.js
   21:27  error  "@google-cloud/logging" is not found  node/no-missing-require
   71:27  error  "@google-cloud/logging" is not found  node/no-missing-require
  100:27  error  "@google-cloud/logging" is not found  node/no-missing-require
  127:27  error  "@google-cloud/logging" is not found  node/no-missing-require
  154:11  error  'results' is defined but never used   no-unused-vars
  166:27  error  "@google-cloud/logging" is not found  node/no-missing-require
  179:11  error  'results' is defined but never used   no-unused-vars

C:\Users\sawch\dev\nodejs-logging\samples\system-test\sinks.test.js
  18:25  error  "@google-cloud/logging" is not found  node/no-missing-require
  33:19  error  't' is defined but never used         no-unused-vars
  37:25  error  't' is defined but never used         no-unused-vars

C:\Users\sawch\dev\nodejs-logging\samples\test\fluent.test.js
  18:28  error  "proxyquire" is not published  node/no-unpublished-require
  19:25  error  "supertest" is not published   node/no-unpublished-require
  20:22  error  "ava" is not published         node/no-unpublished-require

And this seems legitimate. I didn't get to the step in the migration doc about this yet:
C:\Users\sawch\dev\nodejs-logging\system-test\logging.js
  30:19  error  "../../../system-test/env.js" is not found  node/no-missing-require

Overall:
✖ 74 problems (72 errors, 2 warnings)
  16 errors, 0 warnings potentially fixable with the `--fix` option.

And in the client, about todo comments. I actually started removing these, but wasn't sure how to handle:

I intentionally left these as warnings, not errors. I want to see them in the output, but do not want CI to block them.

In response to:
  18:28  error  "proxyquire" is not published  node/no-unpublished-require
  19:25  error  "supertest" is not published   node/no-unpublished-require
  20:22  error  "ava" is not published         node/no-unpublished-require

In speech and in storage, the directory was samples/system-test, and I wrote an .eslintrc.yml to suppress this rule. Does logging have both a samples/test and a samples/system-test, or just one?
If it has both, then I would like to figure out why. If it has one, let's standardize.

I fixed the prettier command in the migration doc, which should fix your "some errors remain".

Does logging have both a samples/test and a samples/system-test, or just one?

Some of our samples have both. Tests in test/ are unit tests, and should execute very quickly. Tests in system-test/ are system tests, and generally hit some service.

I'm down to these errors now:
C:\Users\sawch\dev\nodejs-logging\src\metadata.js
  115:9  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\src\v2\config_service_v2_client.js
  26:1  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\src\v2\logging_service_v2_client.js
  26:1  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\src\v2\metrics_service_v2_client.js
  26:1  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\samples\test\fluent.test.js
  18:28  error  "proxyquire" is not published  node/no-unpublished-require
  19:25  error  "supertest" is not published   node/no-unpublished-require
  20:22  error  "ava" is not published         node/no-unpublished-require

C:\Users\sawch\dev\nodejs-logging\system-test\logging.js
   30:19  error  "../../../system-test/env.js" is not found  node/no-missing-require
   33:1   error  'describe' is not defined                   no-undef
   48:3   error  'before' is not defined                     no-undef
   59:3   error  'after' is not defined                      no-undef
  120:3   error  'describe' is not defined                   no-undef
  121:5   error  'it' is not defined                         no-undef
  139:5   error  'it' is not defined                         no-undef
  165:5   error  'it' is not defined                         no-undef
  189:5   error  'describe' is not defined                   no-undef
  193:7   error  'before' is not defined                     no-undef
  202:7   error  'it' is not defined                         no-undef
  214:7   error  'it' is not defined                         no-undef
  223:5   error  'describe' is not defined                   no-undef
  226:7   error  'before' is not defined                     no-undef
  235:7   error  'it' is not defined                         no-undef
  243:7   error  'it' is not defined                         no-undef
  253:7   error  'it' is not defined                         no-undef
  268:3   error  'describe' is not defined                   no-undef
  303:5   error  'it' is not defined                         no-undef
  317:5   error  'it' is not defined                         no-undef
  330:5   error  'describe' is not defined                   no-undef
  331:7   error  'before' is not defined                     no-undef
  335:7   error  'it' is not defined                         no-undef
  349:7   error  'it' is not defined                         no-undef
  363:5   error  'it' is not defined                         no-undef
  367:5   error  'it' is not defined                         no-undef
  404:5   error  'it' is not defined                         no-undef
  432:5   error  'it' is not defined                         no-undef
  454:5   error  'it' is not defined                         no-undef
  489:5   error  'it' is not defined                         no-undef
  524:5   error  'it' is not defined                         no-undef
  557:5   error  'it' is not defined                         no-undef
  573:5   error  'it' is not defined                         no-undef
  577:5   error  'it' is not defined                         no-undef
  581:5   error  'it' is not defined                         no-undef
  585:5   error  'it' is not defined                         no-undef
  589:5   error  'it' is not defined                         no-undef
  593:5   error  'it' is not defined                         no-undef
  597:5   error  'it' is not defined                         no-undef
  601:5   error  'it' is not defined                         no-undef

18:28  error  "proxyquire" is not published  node/no-unpublished-require

These errors confuse me.

Leaving this small mess:

lint: Linting files in: C:\Users\sawch\dev\nodejs-logging
lint: Running: eslint src/ samples/ system-test/ test/

C:\Users\sawch\dev\nodejs-logging\src\metadata.js
  115:9  warning  Unexpected 'todo' comment  no-warning-comments

C:\Users\sawch\dev\nodejs-logging\system-test\logging.js
  30:19  error  "../../../system-test/env.js" is not found  node/no-missing-require


Why is this not working when we put the data in a different file?

In my render method, I have this:
<SuperTreeView data={myData}/>

The myData variable has sample information taken from the sample demo. It works now.
However, if I were to take this myData json array and put it in a different js file and export it from there and then import it in my react component jsx file, it wont work. Only the top level is displayed. The checkboxes or arrows wont go further.

Please share your code, maybe with codepen and I can take a look. It should
work.
On Fri, Jun 28, 2019, 11:29 AM rohitmarneni<EMAIL_ADDRESS>wrote:

In my render method, I have this:

The myData variable has sample information taken from the sample demo. It
works now.
However, if I were to take this myData json array and put it in a
different js file and export it from there and then import it in my react
component jsx file, it wont work. Only the top level is displayed. The
checkboxes or arrows wont go further.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/azizali/react-super-treeview/issues/24?email_source=notifications&email_token=AAT6QLGIAYUTN7Q24U6VLY3P4Y37FA5CNFSM4H4G26C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4LKNKQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT6QLDOE6GGSKESEQYWF5TP4Y37FANCNFSM4H4G26CQ
.

My bad, it was a simple issue with updateCb callback. Thanks for your reply. Closing the issue. Have a nice day.


Begin every comment with a space

This makes the comments more visually pleasing.
Maybe we could define a base style for comments and add it to the documentation?

The amount of lines touched by this PR is considerable. This may break some PRs and I undertand if it's seen as a superfluous change.

Is there a rule for this in Clang? It would probably make more sense to apply a new rule and have the changes get picked up over time as files are worked on.

What sampengilly said. Also, comments should start with a capital letter and end with a full stop.

See also #35998 (which needs a rebase).

it should be like this IMO
// A comment.
//commented_out_code();

@ThakeeNathees  I guess that could be done matching commented lines ending with ; but that might not cover all the cases. I don't know how much can the change be automated and the amount of comments is quite big.

@Calinou  Yeah  #35998 would be good to be done before this as it would simplify the work required for this PR. I guess I'll leave this in standby as there is no priority for a change like this and  #35998 would be a nice PR to have merged before working on comment correctness.

Also, it might make more sense to do this incrementally, rather than throughout the entire codebase at once. For example, one user could make a PR for all of the files in core/, and another user could make a PR for editor/, etc.

@aaronfranke that might be the best approach to reduce the impact of PR conflict.

Relates to #31261, at this time idk if I will finish it ¯_(ツ)_/¯.

This PR has been inactive for quite some time, and it has a massive impact. I believe we want this, but ideally we want to make sure our comment formatting rules are preserved and new PRs don't break them. Not sure if clang-format allows this or not.
Either way, this PR as it stands needs a massive rebase, and it needs to comply with the rest of the comment formatting rules, such as starting with a capital letter and ending with a period. And if it's a code line that is commented, it should not be affected at all. If we are doing a pass like that then we might as well do it right.
So I suggest remaking this anew, and use the approach @aaronfranke suggested, doing it in batches.


Signal stack size too small on Linux

On my Linux box, this line...
https://github.com/onqtam/doctest/blob/fec6e4a5f570dfa8ba4b715bc8fa4f51a8b70557/doctest/doctest.h#L4485
... expands to 8kiB of signal stack. This seems to be too small, as I sometimes get segmentation faults in logTestStart (or rather, snprintf) when handling signals. The windows branch of this code uses 32kiB, so I suggest to do the same for POSIX boxes.
Also, I suggest replacing later ocurrences of  SIGSTKSZ with sizeof(altStackMem) for increased maintainability.

sounds reasonable!


Implement apply-setters for subpackages

Implement the apply-setters function to support adding setters for subpackages using path expressions.

This problem should be solved for all function input and not just for apply-setters which will be done in Q2.


cargo can't find rustc-demangle in a local-registry

if you declare a package with a (direct or indirect) dependency on rustc-demangle:
% cat Cargo.toml
[package]
name = "testcargo"
version = "0.1.0"
authors = ["Bryan Donlan<EMAIL_ADDRESS>edition = "2018"

[dependencies]
"rustc-demangle" = "0.1.13"

and then build a local-registry:
% cargo local-registry -s Cargo.toml local-registry
    Updating crates.io index
add this to your .cargo/config somewhere:

    [source.crates-io]
    registry = 'https://github.com/rust-lang/crates.io-index'
    replace-with = 'local-registry'

    [source.local-registry]
    local-registry = '/local/home/bdonlan/testcargo/local-registry'

and then enable the local registry by copying the above-cited lines into .cargo/config, then cargo check fails:
% cargo check
error: no matching package named `rustc-demangle` found
location searched: registry `https://github.com/rust-lang/crates.io-index`
required by package `testcargo v0.1.0 (/local/home/bdonlan/testcargo)`

Contents of the local registry:
% ls -lR local-registry
local-registry:
total 24
drwxr-xr-x 3 bdonlan bdonlan  4096 May 21 20:41 index
-rw-r--r-- 1 bdonlan bdonlan 18721 May 21 20:41 rustc-demangle-0.1.14.crate

local-registry/index:
total 4
drwxr-xr-x 3 bdonlan bdonlan 4096 May 21 20:41 ru

local-registry/index/ru:
total 4
drwxr-xr-x 2 bdonlan bdonlan 4096 May 21 20:41 st

local-registry/index/ru/st:
total 4
-rw-r--r-- 1 bdonlan bdonlan 456 May 21 20:41 rustc-demangle
% cat local-registry/index/ru/st/rustc-demangle
{"name":"rustc-demangle","vers":"0.1.14","deps":[{"name":"compiler_builtins","req":"^0.1.2","features":[],"optional":true,"default_features":true,"target":null,"kind":null},{"name":"rustc-std-workspace-core","req":"^1.0.0","features":[],"optional":true,"default_features":true,"target":null,"kind":null}],"cksum":"ccc78bfd5acd7bf3e89cffcf899e5cb1a52d6fafa8dec2739ad70c9577a57288","features":{"rustc-dep-of-std":["compiler_builtins","core"]},"yanked":false}

Version information:
% cargo --version
cargo 1.34.0 (6789d8a0a 2019-04-01)

cargo local-registry has no --version, but was just now installed via cargo install cargo-local-registry.

This appears to only occur with rustc-demangle 0.1.14; using "rustc-demangle" = "=0.1.13" does not result in the same error.

Also encountered this issue, debug output:
> RUST_LOG=debug cargo check
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_root - is root /private/tmp/workspace2/Cargo.toml
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_members - /private/tmp/workspace2/foo/Cargo.toml
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_members - /private/tmp/workspace2/Cargo.toml
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_root - trying /private/tmp/workspace2/Cargo.toml
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_root - found a root checking exclusion
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_root - found!
[2019-06-08T18:21:08Z DEBUG cargo::core::workspace] find_root - is root /private/tmp/workspace2/Cargo.toml
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer autocfg v0.1.4
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer backtrace v0.3.30
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer backtrace-sys v0.1.28
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer cc v1.0.37
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer cfg-if v0.1.9
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer failure v0.1.5
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer failure_derive v0.1.5
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer foo v0.1.0 (/private/tmp/workspace2/foo)
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer libc v0.2.58
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer proc-macro2 v0.4.30
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer quote v0.6.12
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer rustc-demangle v0.1.15
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer syn v0.15.35
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer synstructure v0.10.2
[2019-06-08T18:21:08Z DEBUG cargo::ops::resolve] attempting to prefer unicode-xid v0.1.0
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/missing  /private/tmp/workspace2/foo
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] loading source /private/tmp/workspace2/foo
[2019-06-08T18:21:08Z DEBUG cargo::sources::config] loading: /private/tmp/workspace2/foo
[2019-06-08T18:21:08Z DEBUG cargo::core::resolver] initial activation: foo v0.1.0 (/private/tmp/workspace2/foo)
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/missing  registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] loading source registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::config] loading: registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::config] following pointer to local-registry
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] skipping update due to locked registry
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z INFO  cargo::sources::registry::index] failed to parse `rustc-demangle` registry package: Feature `rustc-dep-of-std` includes `core` which is neither a dependency nor another feature
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] falling back to an update
[2019-06-08T18:21:08Z INFO  cargo::sources::registry::index] failed to parse `rustc-demangle` registry package: Feature `rustc-dep-of-std` includes `core` which is neither a dependency nor another feature
[2019-06-08T18:21:08Z DEBUG cargo::core::resolver] no candidates found
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] attempting query without update
[2019-06-08T18:21:08Z DEBUG cargo::sources::registry] falling back to an update
[2019-06-08T18:21:08Z INFO  cargo::sources::registry::index] failed to parse `rustc-demangle` registry package: Feature `rustc-dep-of-std` includes `core` which is neither a dependency nor another feature
[2019-06-08T18:21:08Z DEBUG cargo::core::registry] load/match    registry `https://github.com/rust-lang/crates.io-index`
[2019-06-08T18:21:08Z DEBUG cargo] exit_with_error; err=CliError { error: Some(ErrorMessage { msg: "no matching package named `rustc-demangle` found\nlocation searched: registry `https://github.com/rust-lang/crates.io-index`\nrequired by package `backtrace v0.3.30`\n    ... which is depended on by `failure v0.1.5`\n    ... which is depended on by `foo v0.1.0 (/private/tmp/workspace2/foo)`" }), unknown: false, exit_code: 101 }
error: no matching package named `rustc-demangle` found
location searched: registry `https://github.com/rust-lang/crates.io-index`
required by package `backtrace v0.3.30`
    ... which is depended on by `failure v0.1.5`
    ... which is depended on by `foo v0.1.0 (/private/tmp/workspace2/foo)`

same error here

So the key error appears to be: failed to parse rustc-demangle registry package: Feature rustc-dep-of-std includes core which is neither a dependency nor another feature

The following was added to rustc-demangle from 0.1.13 to 0.1.14:
[dependencies]
core = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-core' }
compiler_builtins = { version = '0.1.2', optional = true }

[features]
rustc-dep-of-std = ['core', 'compiler_builtins']

I think this is closely related to: https://github.com/rust-lang/cargo/pull/5993

So if I generate the local registry, with a project using rustc-demangle version 0.1.15 then I get the following in the registry/index/ru/st/rustc-demangle file:
{"name":"rustc-demangle","vers":"0.1.15","deps":[{"name":"compiler_builtins","req":"^0.1.2","features":[],"optional":true,"default_features":true,"target":null,"kind":null},{"name":"rustc-std-workspace-core","req":"^1.0.0","features":[],"optional":true,"default_features":true,"target":null,"kind":null}],"cksum":"a7f4dccf6f4891ebcc0c39f9b6eb1a83b9bf5d747cb439ec6fba4f3b977038af","features":{"rustc-dep-of-std":["compiler_builtins","core"]},"yanked":false}

Which is different from what crates.io has for that version at https://github.com/rust-lang/crates.io-index/blob/master/ru/st/rustc-demangle:
{"name":"rustc-demangle","vers":"0.1.15","deps":[{"name":"compiler_builtins","req":"^0.1.2","features":[],"optional":true,"default_features":true,"target":null,"kind":"normal"},{"name":"core","req":"^1.0.0","features":[],"optional":true,"default_features":true,"target":null,"kind":"normal","package":"rustc-std-workspace-core"}],"cksum":"a7f4dccf6f4891ebcc0c39f9b6eb1a83b9bf5d747cb439ec6fba4f3b977038af","features":{"rustc-dep-of-std":["core","compiler_builtins"]},"yanked":false,"links":null}


regression tests not running on CI

Regression tests are not running well on CI systems

[ ] Test behavior on Travis environment is intermittent. Sometimes tests are getting failed with some errors in f8-m-p like #1133 #111. The potential reason for test failure could be test environment infrastructure or issues with f8-m-p.
[ ] Fixed the build issue for OpenShift v3.7 #1130 as its affecting overall test behavior and performance as well

Related to #1103

@hrishin Can we close this issue?


Add dockerfile to istiod

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
075dd4e4aee8dcc608cf8e3ce3076ab8b2b4a089
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix https://github.com/tot0/ObsidianPPV/issues/6

Fix https://github.com/tot0/ObsidianPPV/issues/6 by replacing do-date-obj with do-date in lines 22, 33, 34.

Thanks for making the New Month button fix! Seems like I don't get notifications for PRs on this repo, I'll need to fix that. I just committed a couple of fixes I had built up in my vault, which did include the month fix already, so unless you want to keep the do-date change we can close this one :)

@tot0 after your fixes and explanation regarding #6 , there is no need to this PR. Hence I'm closing it.


IntelliJ IDEA-Plugin not working on Windows 11 Enterprise Machines

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Windows 11 Enterprise (10.0.22631 Build 22631)
- Continue: 0.0.50 (also tested 0.0.47 and 0.0.51)
- IDE: IntelliJ IDEA 2024.1.4 (Ultimate Edition)
- Model: *cannot select model due to the bug*
- config.json:

{
    "models": [
        {
            "title": "Speed",
            "model": "speed",
            "provider": "openai",
            "apiBase": "https://{{our-domain}}/api/generic/openai/v1",
            "useLegacyCompletionsEndpoint": false,
            "apiKey": "hidden",
            "requestOptions": {
                "headers": {
                    "X-Authentication-Mode": "TemporaryApiKey"
                }
            }
        },
        ...
    ],
    "allowAnonymousTelemetry": false,
    "disableIndexing": false,
    "slashCommands": [
        ...
    ],
    "customCommands": [
        ...
    ],
    "contextProviders": [
        ...
    ]
}

Description
Overall Situation
Currently we are unable to use the continue-Plugin with JetBrains IntelliJ. Whenever we start continue it is unable to locate any models listed in our config.json - which at the same time works perfectly fine in VS Code.
The following observation has been made by multiple people, all working on the same OS setup (Windows 11 Enterprise).
However, the same config.json seems to work fine using Windows 10 Enterprise.
Additional Information

default config.json is not working either
~/.continue/core.log is missing (tested with multiple machines and users)
the following log appears on console when using the 0.0.51-version:

To reproduce
https://github.com/continuedev/continue/assets/9252676/433ec7cb-79c7-4cd1-b2dd-01e89583a9c3
Log output
not existing (as described above)

Some additional infos (based on Continue 0.0.51 for Jetbrains IntelliJ IDEA) from the IntelliJ Logs:
Exception 1
The Plugin crashes when trying to set the initial selected index when no models seem to be available at that moment.
(there are models in the config.json - vscode loads them correctly)
2024-07-06 13:23:59,958 [  64161] SEVERE - #c.i.i.p.PluginManager - setSelectedIndex: 0 out of bounds
java.lang.IllegalArgumentException: setSelectedIndex: 0 out of bounds
	at java.desktop/javax.swing.JComboBox.setSelectedIndex(JComboBox.java:652)
	at com.github.continuedev.continueintellijextension.editor.CustomPanel.<init>(InlineEditAction.kt:271)
	at com.github.continuedev.continueintellijextension.editor.InlineEditAction.makePanel(InlineEditAction.kt:214)
	at com.github.continuedev.continueintellijextension.editor.InlineEditAction.actionPerformed(InlineEditAction.kt:128)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.doPerformActionOrShowPopup(ActionUtil.kt:304)
	at com.intellij.openapi.keymap.impl.ActionProcessor.performAction(ActionProcessor.java:32)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher$actionProcessor$1.performAction(IdeKeyEventDispatcher.kt:495)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner$lambda$4$lambda$3(IdeKeyEventDispatcher.kt:844)
	at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:106)
	at com.intellij.openapi.application.TransactionGuardImpl.performUserActivity(TransactionGuardImpl.java:95)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner$lambda$4(IdeKeyEventDispatcher.kt:844)
	at com.intellij.openapi.actionSystem.impl.ActionManagerImpl.performWithActionCallbacks(ActionManagerImpl.kt:1166)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareWithCallbacks(ActionUtil.kt:321)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner(IdeKeyEventDispatcher.kt:842)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.access$doPerformActionInner(IdeKeyEventDispatcher.kt:1)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processAction$intellij_platform_ide_impl(IdeKeyEventDispatcher.kt:571)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processAction(IdeKeyEventDispatcher.kt:508)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processActionOrWaitSecondStroke(IdeKeyEventDispatcher.kt:447)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.inInitState(IdeKeyEventDispatcher.kt:440)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.dispatchKeyEvent(IdeKeyEventDispatcher.kt:302)
	at com.intellij.ide.IdeEventQueue.dispatchKeyEvent(IdeEventQueue.kt:623)
	at com.intellij.ide.IdeEventQueue._dispatchEvent$lambda$11(IdeEventQueue.kt:585)
	at com.intellij.openapi.application.impl.RwLockHolder.runWithEnabledImplicitRead(RwLockHolder.kt:138)
	at com.intellij.openapi.application.impl.RwLockHolder.runWithImplicitRead(RwLockHolder.kt:129)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:585)
	at com.intellij.ide.IdeEventQueue.access$_dispatchEvent(IdeEventQueue.kt:77)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:362)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:361)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:843)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:361)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:356)
	at com.intellij.ide.IdeEventQueueKt.performActivity$lambda$1(IdeEventQueue.kt:1022)
	at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:114)
	at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1022)
	at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda$7(IdeEventQueue.kt:356)
	at com.intellij.openapi.application.impl.RwLockHolder.runIntendedWriteActionOnCurrentThread(RwLockHolder.kt:209)
	at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:830)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:398)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)

Exception 2
Another Exception that happened after the one above when trying to perform inline edits
2024-07-06 13:24:11,144 [  75347] SEVERE - #c.i.i.p.PluginManager - Cannot invoke "com.intellij.openapi.Disposable.dispose()" because the return value of "com.intellij.openapi.util.Ref.get()" is null
java.lang.NullPointerException: Cannot invoke "com.intellij.openapi.Disposable.dispose()" because the return value of "com.intellij.openapi.util.Ref.get()" is null
	at com.github.continuedev.continueintellijextension.editor.InlineEditAction$actionPerformed$diffStreamHandler$1.invoke(InlineEditAction.kt:112)
	at com.github.continuedev.continueintellijextension.editor.InlineEditAction$actionPerformed$diffStreamHandler$1.invoke(InlineEditAction.kt:111)
	at com.github.continuedev.continueintellijextension.editor.DiffStreamHandler.reject(DiffStreamHandler.kt:158)
	at com.github.continuedev.continueintellijextension.editor.DiffStreamService.register(DiffStreamService.kt:12)
	at com.github.continuedev.continueintellijextension.editor.InlineEditAction.actionPerformed(InlineEditAction.kt:117)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.doPerformActionOrShowPopup(ActionUtil.kt:304)
	at com.intellij.openapi.keymap.impl.ActionProcessor.performAction(ActionProcessor.java:32)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher$actionProcessor$1.performAction(IdeKeyEventDispatcher.kt:495)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner$lambda$4$lambda$3(IdeKeyEventDispatcher.kt:844)
	at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:106)
	at com.intellij.openapi.application.TransactionGuardImpl.performUserActivity(TransactionGuardImpl.java:95)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner$lambda$4(IdeKeyEventDispatcher.kt:844)
	at com.intellij.openapi.actionSystem.impl.ActionManagerImpl.performWithActionCallbacks(ActionManagerImpl.kt:1166)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareWithCallbacks(ActionUtil.kt:321)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.doPerformActionInner(IdeKeyEventDispatcher.kt:842)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcherKt.access$doPerformActionInner(IdeKeyEventDispatcher.kt:1)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processAction$intellij_platform_ide_impl(IdeKeyEventDispatcher.kt:571)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processAction(IdeKeyEventDispatcher.kt:508)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processActionOrWaitSecondStroke(IdeKeyEventDispatcher.kt:447)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.inInitState(IdeKeyEventDispatcher.kt:440)
	at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.dispatchKeyEvent(IdeKeyEventDispatcher.kt:302)
	at com.intellij.ide.IdeEventQueue.dispatchKeyEvent(IdeEventQueue.kt:623)
	at com.intellij.ide.IdeEventQueue._dispatchEvent$lambda$11(IdeEventQueue.kt:585)
	at com.intellij.openapi.application.impl.RwLockHolder.runWithEnabledImplicitRead(RwLockHolder.kt:138)
	at com.intellij.openapi.application.impl.RwLockHolder.runWithImplicitRead(RwLockHolder.kt:129)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:585)
	at com.intellij.ide.IdeEventQueue.access$_dispatchEvent(IdeEventQueue.kt:77)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:362)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:361)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:843)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:361)
	at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:356)
	at com.intellij.ide.IdeEventQueueKt.performActivity$lambda$1(IdeEventQueue.kt:1022)
	at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:114)
	at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1022)
	at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda$7(IdeEventQueue.kt:356)
	at com.intellij.openapi.application.impl.RwLockHolder.runIntendedWriteActionOnCurrentThread(RwLockHolder.kt:209)
	at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:830)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:398)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)
2024-07-06 13:24:11,145 [  75348] SEVERE - #c.i.i.p.PluginManager - IntelliJ IDEA 2024.1.4  Build #IU-241.18034.62
2024-07-06 13:24:11,145 [  75348] SEVERE - #c.i.i.p.PluginManager - JDK: 17.0.11; VM: OpenJDK 64-Bit Server VM; Vendor: JetBrains s.r.o.
2024-07-06 13:24:11,145 [  75348] SEVERE - #c.i.i.p.PluginManager - OS: Windows 11
2024-07-06 13:24:11,145 [  75348] SEVERE - #c.i.i.p.PluginManager - Plugin to blame: Continue version: 0.0.51
2024-07-06 13:24:11,145 [  75348] SEVERE - #c.i.i.p.PluginManager - Last Action: continue.inlineEdit

Exception 3 (resulting in Warnings)
Warnings like this appear very often in the IntelliJ Logs
2024-07-05 15:54:10,201 [  64979]   WARN - #c.i.u.j.JBCefJSQuery - Set the property JBCefClient.Properties.JS_QUERY_POOL_SIZE to use JBCefJSQuery after the browser has been created
java.lang.IllegalStateException
	at com.intellij.ui.jcef.JBCefJSQuery.create(JBCefJSQuery.java:66)
	at com.intellij.ui.jcef.JBCefBrowserJsCall.createQueryWithinScope(JBCefBrowserJsCall.kt:169)
	at com.intellij.ui.jcef.JBCefBrowserJsCall.createResultHandlerQueryWithinScope(JBCefBrowserJsCall.kt:154)
	at com.intellij.ui.jcef.JBCefBrowserJsCall.invoke(JBCefBrowserJsCall.kt:137)
	at com.intellij.ui.jcef.JBCefBrowserJsCallKt.executeJavaScriptAsync(JBCefBrowserJsCall.kt:60)
	at com.github.continuedev.continueintellijextension.toolWindow.ContinueBrowser.sendToWebview(ContinueBrowser.kt:250)
	at com.github.continuedev.continueintellijextension.toolWindow.ContinueBrowser.sendToWebview$default(ContinueBrowser.kt:235)
	at com.github.continuedev.continueintellijextension.toolWindow.ContinueBrowser$1$2.invokeSuspend(ContinueBrowser.kt:140)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

and another perhaps helpful addition:
the problem doesn't seem to be limited to windows 11 enterprise devices.
I just tried to get it to run on my private notebook running on:
Windows 11 Pro 22631.3737
with IntelliJ IDEA 2023.3.7 (Ultimate Edition)
The default continue config is used in the following example (the .continue folder was created by continue when running the ide)
https://github.com/continuedev/continue/assets/8578769/204aad98-f373-478b-8444-7ae30e249b12
I'll try to update my IntelliJ IDEA Version to 2024.1 and will add additional info, if this happens to change the described behavior.

🔎 More insights
Through further analysis by @Hakenadu we could narrow the issue down to the following line: https://github.com/continuedev/continue/blob/main/extensions/intellij/src/main/kotlin/com/github/continuedev/continueintellijextension/continue/CoreMessenger.kt#L229
The admin/infrastructure team of our org uses AppLocker (https://learn.microsoft.com/en-us/windows/security/application-security/application-control/windows-defender-application-control/applocker/applocker-overview) to restrict the usage of executables on employee devices, which causes the bundled .exe-files (continue-binary.exe and esbuild.exe) to fail during startup of the continue plugin. From our experience the inevitable consequence is that you either need an exemption folder and migrate your plugin files there (see: https://intellij-support.jetbrains.com/hc/en-us/articles/207240985-Changing-IDE-default-directories-used-for-config-plugins-and-caches-storage) or to convince your org to lift AppLocker restrictions for you.
⚠Implications
From my point of view this has the following implications:

this issue is not a "bug" as per the usual definition
the documentation or troubleshooting guide should be updated to reflect this (I am rather sure that others will face similar issues, as restricting executables seems to be a no brainer for many regulated industries)
it would be great to have some logging of the plugin start (which would massively aid in identifying issues like this one)

Hi
Thank you @MarcoNiemann.
Just to update, it seams the indexation issue can also occur on VS Code with some Antivus such as Microsoft Defender.
As suggested by Marco, updating the Troubleshooting guide with the suggested workaround could help (for both JetBrains and VS Code).


Add install telemetry

For #

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] ~Has a news entry file (remember to thank yourself!).~
[x] Appropriate comments and documentation strings in the code.
[x] Has sufficient logging.
[x] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] ~Test plan is updated as appropriate.~
[ ] ~package-lock.json has been regenerated by running npm install (if dependencies have changed).~
[ ] ~The wiki is updated with any design decisions/details.~

Codecov Report

Merging #13653 into master will decrease coverage by 59.71%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #13653       +/-   ##
===========================================
- Coverage   59.71%    0.00%   -59.72%
===========================================
  Files         673       14      -659
  Lines       37658       38    -37620
  Branches     5402        3     -5399
===========================================
- Hits        22488        0    -22488
+ Misses      14003       38    -13965
+ Partials     1167        0     -1167

Impacted Files
Coverage Δ

src/client/debugger/constants.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

src/client/common/process/constants.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

src/client/common/platform/constants.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

src/client/datascience/notebook/constants.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

src/client/interpreter/autoSelection/constants.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
0.00% <0.00%> (-50.00%)
:arrow_down:

src/client/testing/explorer/failedTestHandler.ts

src/client/debugger/extension/adapter/logging.ts

...lient/testing/unittest/testConfigurationManager.ts

...overy/locators/services/windowsStoreInterpreter.ts

... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63332cb...c02ab65. Read the comment docs.

The Mac failure is due to infrastructure (see #13608) and is not related to this PR.