SL review: Stop forms from getting deleted

In SL review submission workflow there is a fix date 6th December 2023 set to delete application and submission.
Based on final update from the form owner Jodi. We should keep all forms in DJ. To do that new changes needs to deploy that sto SL forms getting delete via workflow.
Task

[ ] Add condition that skip SL submission getting deleted.

Will be included with mat/par deployment

Tested code and it is working fine. Delete function skip all SL submissions. If form name is "Senior Leadership Review Form" then it will not delete application/submission from the digital journey database.

Bhumin noted this ticket can be closed


Update ring and hyper-rustls

This allows downstream crates to use newer versions of ring.

The clippy failures seem to be unrelated to my PR. Maybe clippy started emitting more lints, which made existing code start failing?

yes, clippy is sometimes a bit strict.


[9.x] Support arrays on Enum validation rule

The in and exists validation rules can be used to validate all values of an array, but the Enum rule does currently not support this. This PR fixes that.
// Before
return [
    'enum_values_array' => [
        'required',
        'array',
        'min:1',
    ],
    'enum_values_array.*' => [
        'required',
        new Enum(SomeEnum::class),
    ]
]

// After
return [
    'enum_values_array' => [
        'required',
        'array',
        'min:1',
        new Enum(SomeEnum::class),
    ],
]

This feels a bit breaking? For example if I just had ['required', new Enum(...)] before I could expect that it would ensure the incoming value was a string but now it might be an array?


Checking image paths for each cell in transform(needed for latex)

Note :-  The function cell_output_to_nodes is copied from https://github.com/jupyter/jupyter-sphinx for demonstration purposes only. And this PR is not intended to be merged.
Hey @choldgraf @mmcky , I have added a few harmless lines of code to the cell_output_to_nodes  function (also added to cell_output_to_nodes_inline), to target the image file not readable error in https://github.com/ExecutableBookProject/cli/issues/115 . It is beneficial for latex builds in scenarios where the source directory has subdirectories. Won't affect anything for html or other builds.
If it looks ideal, maybe we can create a PR for this at https://github.com/jupyter/jupyter-sphinx ?

@choldgraf @mmcky I have modified this PR and removed the local declaration of cell_output_to_nodes. Changes to cell_output_to_nodes_inline are required, so have kept that.
This branch should be good to merge now.

@AakashGfude jupyter-sphinx just released a new version, which I gather is related to this PR? If so then you should feel free to merge this PR, but I won't do so in case you think there is something else to be done

@choldgraf  nicee. This PR is ready to be merged from my side. Thanks

fixes https://github.com/executablebooks/jupyter-book/issues/505


add support for generating Siren Hunts links

SUMMARY
add a button to the train recorder that generates a scout tracker link for sirenhunts.com, with the marks pre-populated based on what is in the train recorder.
NEW FEATURES

added a button in the train recorder, next to the export button, that will generate a pre-populated siren hunts link and put it in the clipboard.

post a message to the chatlog indicating that the link was generated.

added content to the plugin settings window (previously empty) for advanced settings that probably don't need to be in the map window's settings ui.

added a setting for the siren hunts base url, in case someone wants to use a replica of siren hunts on a different domain (such as if siren hunts goes down, or if someone makes a new tracker supporting the same link format).

TECH NOTES

added a json file with all the data necessary for encoding a siren hunts url based on the marks listed in the train recorder. this is a lot of data, and essentially duplicates the spawn point data. however, i ended up on this choice because it ended up being easier. it's also now more encapsulated, so we don't need to think about how changes to other areas like the spawn point data might affect this. they are completely separate.
this does support instances, but right now that requires configuration in the json. that is pretty easy to do, but means there would be a period of time right after patch releases where the links won't work correctly, until the updated data is released.

it would be helpful to be able to at least manually override the instance data in a setting somewhere, so users can still make it work with the new instances, before an official release goes out with the update. this might be another good candidate for the "advanced settings".

i left arr out of the siren hunts data, meaning it won't work for arr marks. it's worth adding them in, and it should be a pretty small change to add that support, but getting the data for arr was a bit of a nightmare. the url encoding for some of the marks is not obvious. i got fed up trying to figure it out so just gave up for now XD.

AUTHOR NOTE
there were a lot of decisions i was unsure about because they are a bit of a different style from what's currently in the code, or i just wasn't sure the right way to do them. so please let me know about any changes to fit more with the existing styles, or maintainer preferences for this project.

I don't really know what Siren Hunts is, but it seems to be used to record trains via website?
So I guess the use case would be for sharing with console players and people not using plugins who conduct trains.
Personally, seeing the amount of extra code and data required to handle this and the fact that it seems like a not so common use case.
At a glance, I can work out that the individual spawn positions are assigned letters on Siren Hunts and there is a specific map or mob order, etc. But it seems like something that requires adequate documentation -- I don't feel confident if I had to maintain or update this stuff in the future.
Given how simple the end functionality is but how involved generating the URL seems to be, I'd suggest this implementation be taken and made into your own 'companion' plugin that could take in a HuntHelper train export code (and could also be expanded upon to work with other formats for users who don't use HuntHelper). I could then update the export message to notify people of the optional plugin for SirenHunts integration.
This would be cleaner and better for maintenance since the current implementation seems to be mostly separate.
I recommend changing the implementation to use IDs instead of names to be language agnostic, but leaving the English names in the JSON for readability.
like:
 "mobOrder": [
    {
        "name": "hunt one",
        "mobID": 123
    },
    {
        "name": "hunt two",
        "mobdID": 323
    }
]

or in consideration of other potential formats, maybe having all names and determining client language would be better,
 "mobOrder": [
    {
        "en": "hunt one",
        "jp": "hunto ichi",
        "de": "hunt eins",
        "fr": "hunt un",
        "mobID": 123
    }
]

oh i actually really like the idea of making this a companion plugin! that way it can easily be updated to support more options, without having to fill the hh repo with all the specifics. i have no idea how to make a companion plugin, so would love some advice, but i can start poking at doing that.
i realize now, though, that i didn't explain the point of this very well >_<. this is actually a big use case for people who run trains. trains are all scouted before they are conducted. the scouters fly around all the spawn points, using hh to make that easier, and record which marks they find at which spawn points. they then share that info with the conductors who run the trains. the way they record which marks they find where, is with scout tracker websites like:

https://www.sirenhunts.com/scouting
https://tracker.beartoolkit.com/train
https://prime-hunt-tools.web.app/#/

regardless of which site is used this is how scouters share spawn locations with conductors.
i started scouting recently and was doing the same thing, when i realized the train recorder in hh could be used to do this for us. the purpose of this change is to make it easier to populate those scout trackers, to make scouting easier. so since a lot of scouters use hh, this would actually help most trains, i think.
i have already been using this to help me scout, and i've gotten feedback from a number of other scouters who are interested in the feature.
regarding the companion plugin idea, i actually really like that. i started with siren hunts, but i plan to add support for the other 2 websites i listed above, as well as others that come up. so the companion plugin sounds like a really great way to keep the messiness of all the custom logic for each site, out of hh. that said, i've been told it takes a long time to get a plugin added to dalamud, so if you're open to it, i'd love to get this change added to hh in the short term, and i'll start working on the companion plugin now, so we can remove this from hh and switch to that as soon as possible.

Unless I'm misunderstanding, that sounds like what the export / import functions are for? So people can share their scouts.
example:

Is it not obvious in the UI or am I misunderstanding lol?
As for starting your own plugin:
I suggest using this as your base: https://github.com/goatcorp/SamplePlugin
and then tbh you should be able to copy and paste most of your Siren Hunt code and get it running quickly.

Unless I'm misunderstanding, that sounds like what the export / import functions are for?

i don't know why it is the case, i just know that in the scouting communities i've interacted with, people aren't using the export/import functions, they are using these scout tracker websites.
one reason i could guess, for why people are using websites instead of the export/import, is that i think there are some out-of-game tools people use to generate macros and other stuff to help with conducting, and they can do that very easily from the tracker websites, compared to the export data. but i really don't know if that's the reason >_<.


aligning with latest bot-graph-dialog API

@morsh
This is the code aligning with the latest bot-graph-dialog API.
feel free to try and run it locally.
@limorl - FYI

@morsh - please add LGTM

LGTM


JBPM-5030: Access control based on the new UF's authz subsystem

Changes required to support the new UF's security APIs
This PR depends on uberfire/uberfire#321

Am I missing something, or this PR removes security from drools-wb? (couldn't find any policy file changed nor restrictions applied)

Security is enabled for any UF app.
A default app security policy can be set by adding the security-policy.properties files to the webapp's classpath. Also the SecurityManagementPerspective can be added included into the app's menus in case you want to edit user/groups/roles and permissions.

+1


Move most of the Linq querying tests to Storyteller and use in docs

Think we could radically clean up the testing project and even the documentation if we could move most of the Linq testing to Storyteller tables and then embed the specs into the docs.

@jeremydmiller is it still applicable?

Still applicable, and I think this is actually the first step in the Linq overhaul just trying to make the tests faster and quicker to extend. But, I don't think the Storyteller tests are even being executed these days, so let's go backward and get everything in to xUnit tests instead.
More content forthcoming in a couple hours....

@jeremydmiller storyteller tests are executed in CI runs

@mysticmind My mistake. I'd definitely leave the ones for the event store there.

I'm declaring success for now. The way it is, it'll be pretty easy to add more stuff

Done in a branch.


PDB/small molecule to SVG converter

Get goodsell style PDBs with configurable colors from a PDB entry code.

For pdb files could use something like this https://ccsb.scripps.edu/illustrate/downloads/
Vectorize with Inkscape Terminal

Another alternative:
Mol* star either with stylized or illustrate style -> hi res png -> inkscape trace
Inkscape settings for stylized:
Single Scan -> Edge detection with default settings
Multicolor scan

https://github.com/visioncortex/vtracer


#15 Update main readme to assist Windows users with getting started

As per discussion in https://github.com/openai/universe/issues/15
Readme now makes it more obvious how to get started running the agent in a docker container. Directs Windows users to this option.

Thanks @jamesweakley !


Swift Package Manager support

I have:

[X] searched open and closed issues for duplicates

Issue description
When using Xcode 11 many developers will inevitably be moving dependencies over to the Swift Package Manager instead of using Cocoapods or Carthage.

SPM support is definitely on our list, but we'd be happy to get some help here :)

Any updates to this?

work in progress, a bit stuck with xcframework'ing openssl

I don't lie — we are working on SPM! :)
@julepka
[Xcode is tricky to work with large C-based projects, so for starters we will distribute ThemisSPM as built XCFramework, not as code.]
https://github.com/cossacklabs/themis/pull/789#pullrequestreview-610841800
https://github.com/cossacklabs/openssl-apple/pull/22
ETA: couple of weeks for beta release, ~1-2 month for stable release with docs and examples.

It's official!
Since 0.13.8 Themis supports SPM!
Checkout docs:
https://docs.cossacklabs.com/themis/languages/swift/installation/#installing-with-spm
Viva @julepka 👏

Awesome thank you!


Support embedded resource manifests on Windows

Summary of the new feature / enhancement
Windows exe's can have resources embedded in them so they can ship/sign just one file.  dsc would need to check every exe to see if it has an embedded resource manifest, but with caching, this should only be an expensive operation the first time for resource discovery and we can invalidate specific portions of the cache if a directory's modified date changes.  The embedded resource manifest would take precedence over any external file equivalent.
Proposed technical implementation details (optional)
No response

Need an example of an embedded resource manifest please.

Need an example of an embedded resource manifest please.

The file format is exactly the same, but we need to use a win32 api to retrieve it.  Looks like there is at least one crate that also does this https://docs.rs/native-windows-gui/latest/native_windows_gui/struct.EmbedResource.html


Need help

Hey guys nice job on this class.
I need to integrate it to one of my projects and i am having a few issues ...
When i create an email for the first time it's added to the archive ... then i retreive the ID from the createContact() result to add the contcat to the contact list ... Works great ... But if i delete the user from the list and try again, the createContact() returns an error ... and no output ... So how am i supose to add him to the list?
if ($_POST[newsletter_form]){

    // Adding the user to mailjet
    $contact = createContact($_POST[courriel], $_POST[nom]);

    // If it worked we should have an ID
    if ($contact[Data][0][ID]){
        // Use the ID to add the user to list 1
        $list = addContactToList($contact[Data][0][ID], 1);
    }else{
        // The user was already added to the archive section
        // How can i get the ID that was assigned to his email?
        // ???????????????????????????????
    }

}

I started working on my own function but so fare it's not working ... Do i need to edit the class?
function getcontact($email) {
    $mj = new Mailjet();
    $params = array(
        "method" => "POST",
        "contact" => "$email"
    );

    $result = $mj->contactInfos($params);
    $result = json_decode(json_encode($result),true);

    if ($mj->_response_code == 201)
       $result[status] = "1";
    else
       $result[status] = "0";

    return $result;
}

An other issue i am having is allowing a user to delete it self from a contact list providing only his email ... I did not find any function for that. Please help
I tryed making this function but it's not working.
function deletecontact($id, $email) {
    $mj = new Mailjet();
    $params = array(
        'method' => 'POST',
        'contact' => $email,
        'id' => $id
    );

    $result = $mj->listsRemoveContact($params);
    $result = json_decode(json_encode($result),true);

    if ($mj->_response_code == 201)
       $result[status] = "1";
    else
       $result[status] = "0";

    return $result;
}

Hey Patrick,
Thanks for reaching out and provide us with a detailed description of your problem.
Sorry to hear that you had troubles using our API.
I assume here that your createContact method calls our contact API ressource to create contact in our system, right? If it's the case, as described in our documentation, you can't delete a contact. This is on purpose to be sure we can provide you with the history of messages, even for emails not assigned to contacts lists and also when using the transactional system.
Back to your first example, I would suggest to change the way to proceed, by try-ing first to retrieve a contact (similar to what you did with the getContact function) and if it does not exist, create it. It gives the following code:
if ($_POST[newsletter_form]){

    // Does the user already exist at Mailjet?
   $params = array(
      "method" => "VIEW",
      "Email" => $_POST[courriel]
   );
    $contact = $mj->contact($params);

    // If it worked we should have an ID
    if ($contact[Data][0][ID]){
        // Use the ID to add the user to list 1
        $list = addContactToList($contact[Data][0][ID], 1);
    }else{
       // Create the contact
       $contact = createContact($_POST[courriel], $_POST[nom]);
    }
}

To add/remove a contact in a list, I invite you to take a look at the listrecipient API ressource, which represents the link between a contactslist and a contact.
According to our documentation, since the listrecipient ressource has ContactALT and ListALT properties, you can identify this link by using the contact's email and the list's name (instead of ID).
This is this ressource which should be used in your addContactToList method.
Based on that, and since - as said above - you can't delete a contact in the system, your deleteContact (here deleteContactFromList would be more explicit) should be defined as below:
function deleteContactFromList($listId, $email) {
    $mj = new Mailjet();
    $params = array(
        'method' => 'DELETE',
        'ContactALT' => $email,
        'ListID' => $listId
    );

    $result = $mj->listRecipient($params);
    $result = json_decode(json_encode($result),true);

    if ($mj->_response_code == 201)
       $result[status] = "1";
    else
       $result[status] = "0";

    return $result;
}

Hope it helps.
Don't hesitate to reach us again if you have further questions or if I missed something.
You can also find additional examples in our Working with Contacts guide and Working with Lists guide.
Best.

Wow thanks arnaudbreton! I am pleased to see how well responded my issue was. It solved my problems. Before i close this issue, is there any chance you can add deleteContactFromList() and getContact() to the readme? You have an exemple on how to delete a contact list but not a user. And there was no exemple on how to get a users data based on his email.
Great job, keep it up!

Patrick,
Thanks for the quick feedback. Glad to see everything's OK for you now!
You're right we should improve our README. I'll take care of it ASAP.
Best.
Arnaud.

Sounds good. Have a nice week end!


[TW#15769] Better docs needed for esp_ble_gatts_create_service -> num_handle

There is a new signature on the exposed API called esp_ble_gatts_create_service.  It has a new parameter called num_handle which only has the documentation:

num_handle: number of handle requested for this service

I'd like to humbly request that the documentation for this be improved upon.  My guess is that this parameter represents the number of handles to be allocated to the service.  Reading the current statement, one might assume that this is the "number OF the handle" to be used as the start of handles.  That might just be a simple grammar error.
However, when attempting to contemplate this function, the reader will now be puzzled by the notion.  Among his questions will be:

What is a handle?
How many handles do I need to allocate?
What metric/algorithm should I use to choose the value?
What errors will be produced that would indicate that I have allocated too few?
What is the impact if I make this number too large?
How much "resource" is allocated when I allocate a handle?

@nkolban What is a handle? --> An attribute handle is a 16-bit value that is assigned by each server to its own attributes to allow a client to reference those attributes. An attribute handle shall not be reused while an ATT Bearer exists between a client and its server.
Attribute handles on any given server shall have unique, non-zero values. Attributes are ordered by attribute handle.
An attribute handle of value 0x0000 is reserved, and shall not be used. An attribute handle of value 0xFFFF is know as the maximum attribute handle.
Note: Attributes can be added or removed while an ATT Bearer is active, however, an attribute that has been removed cannot be replaced by another attribute with the same handle while an ATT Bearer is active. You can find this explain in the Bluethooth Spec 4.2 Part F 3.2.2
How many handles do I need to allocate? --> We already know that each attribute corresponds to a handle, so how many attributes are required in a service? For example, there are three characteristic in a service, where the first characteristic has two descriptors, and the second characteristic has only one descriptor, and the third characteristic has no descriptor. Then the number of handles needed should be 1 (svc attr) + 4 (1 char declaration attr, 1 char value attr, 2 descriptors attr) + 3 (1 char declaration attr, 1 char value attr, 1 Descriptor attr) + 2 (1 char declaration attr, 1 char value attr) = 10, that is, to create such a service requires 10 handle.
What metric/algorithm should I use to choose the value? --> I don't understand it, can you explain please. What does the value here mean?
What errors will be produced that would indicate that I have allocated too few? --> If the handle too few, when you added the characteristic or descriptor which exceed the number of the handle, then the BT stack will print the error log "handle space full. handle_max = %d next_handle = %d\n", and return nothing.
What is the impact if I make this number too large? --> too large it is doesn't matter, but you have to make sure you have enough memory.
How much "resource" is allocated when I allocate a handle? --> This is very uncertain, this mainly depends on whether you set up ESP_GATT_RSP_BY_APP or ESP_GATT_AUTO_RSP. If ESP_GATT_RSP_BY_APP, then each attribute occupies the memory is almost the same for the 2 bytes uuid attribute occupies about 24 ~ 28bytes, for the 16-byte uuid attribute occupies about 40 ~ 44bytes.
If it is ESP_GATT_AUTO_RSP, mainly to see the characteristic of the value set the value.

This is pure gold and MANY thanks for taking the time to write it up.  I'm thinking that folks may not find this information easily.  Would it be possible to write up this information in the documentation somewhere in here:
http://esp-idf.readthedocs.io/en/latest/
Again ... many thanks.


How to set route for WebSocket server?

I have an html client and I would like listen to messages to the below path
ws://localhost:8980/MySampleApp/CarRental
By looking at the server constructor options I didn't find any options? Could you please let me know how to pass a path to the server so that the server listens to that path and not the root path like 'ws://localhost:8980'?

See: https://github.com/theturtle32/WebSocket-Node/issues/245


Popular repositories should be optional

Folks - we have a use case where we want registries to be public, but not necessarily listed on the login screen. For immediate use we're going to pull the "Popular Repositories" code from the login screen and remove the API call. Would there be interest in having that as a feature, configurable via harbor.cfg?

@lweitzman @tonycgil
Please provide comments for this requirement. Thanks.

hi  - i would like to understand your use case a little better. could you explain why its different than hub.docker.com where you can see popular repos without logging in. that would be helpful - thanks.

We're setting up a public version of Harbor to distribute images to customers. For things like private betas, I'd like to be able to point a user at a non-published repository to grab the private beta version. It's not sensitive enough where I want to create and manage a login to access that repository, and I don't want users to have to worry about docker login, or that login timing out when they go to get a new image.
So a public repository works for this, but with the "Popular repositories" UI and API, anybody who hits the homepage can see the semi-private URL.

Just in case it's not clear from comment 1 above - I'm writing this, will host it in a public github repo. Only question is if you guys would be interested in a pull request for this functionality.

yes, lets make content on the login page (popular repos)  optional

Love it @jlk. 'preciate the issue and idea.
PR would be very much welcomed. 😄

OK - we've been using it internally since last summer, will rebase and get a PR in hopefully within the week.

@jlk Welcome and thanks.

Hi @jlk – are you still interested in contributing the patch? Happy to help if needed.

Yes! Sorry...I seem to be under constant severe time crunches. :/
I'm away for the weekend, but let me see what I can do next week. We have the code and are running it - still just need to rebase and clean up a little. Setting calendar reminder for mid next week...


Bi-LSTM+CRF error

hello, I try to run BiLSTM_CRF example. I add one example to training_data and get
"""
training_data = [(
"the wall reported apple corporation made money".split(),
"B I O B I O O".split()
), (
"georgia tech is a university in georgia".split(),
"B I O O O O B".split()
), ("China".split(), 'B'.split())
]
"""
And then, when I run
"""
precheck_sent = prepare_sequence(training_data[2][0], word_to_ix)
print model(precheck_sent)
"""
I get an output 3, which means Start_TAG.
And then I try to change the code of function _viterbi_decode
I change
"""
terminal_var = forward_var + self.transitions[self.tag_to_ix[STOP_TAG]]
best_tag_id = argmax(terminal_var)
path_score = terminal_var[0][best_tag_id]
best_path = [best_tag_id]
"""
to
"""
terminal_var = forward_var + self.transitions[self.tag_to_ix[STOP_TAG]]
temp = terminal_var.data
temp[0][self.tag_to_ix[STOP_TAG]] = -10000
temp[0][self.tag_to_ix[START_TAG]] = -10000
temp = torch.autograd.Variable(temp)
best_tag_id = argmax(temp)
path_score = temp[0][best_tag_id]
best_path = [best_tag_id]`
"""
then I get a correct output 1, which means 'B'.
I wonder to know why it produces a completely wrong answer, START_TAG. Thank you!

Hey Zhixiu,
I discovered similar behavior. If I understood the problem correctly, the Viterbi decoder basically still takes a transition to the start or stop state into account, which it shouldn't.
I think a little bit more elegant fix would look like this:
terminal_var = (forward_var + self.transitions[self.tag_to_ix[STOP_TAG]]).clone()
terminal_var[0, self.tag_to_ix[STOP_TAG]] = -10000.
terminal_var[0, self.tag_to_ix[START_TAG]] = -10000.
best_tag_id = argmax(terminal_var)

You can open a PR if you want, otherwise I'll open one.
@rguthrie3 What do you think about this issue? I guess since it's also part in the official PyTorch tutorials, this should as people probably rely on that code.

Hi, I think I see what you are saying.  My code does not enforce in any way that START and STOP cannot be part of the best path.  E.g START START B STOP would be a valid path for a sentence of length 2, if that makes sense.  This is probably wrong to do, but with enough training such paths should never get decoded since transitioning to START should have a low weight, and transitioning from STOP should have a low weight.  If you want to enforce this constraint plainly, you could intialize the transition matrix from the start to give those transitions very low scores.
This is what I think it is if I understand your question.  I can't run this at work but I will look into it when I can.  Are you training the model and still getting that output (I.e it decodes sequences with START and STOP) or is that the output before training?

 I ran into this issue as I while evaluating before training, so that completely matches with your guess.
Actually the first fix does not seem to prevent that, but my second one does.
So yeah, it's your code and depends on you if you want to "fix" this (basically it would not be a fix, just different behavior).

Here is the fix, which I will add later tonight.  In init, after defining self.transitions, add
self.transitions.data[tag_to_ix[START_TAG], :] = -10000
self.transitions.data[:, tag_to_ix[STOP_TAG]] = -10000

The first line makes it never transition to START, the second makes it never transition from STOP.  This will enforce those constraints a priori without having to depend on the model learning that those two states should never be transitioned to / from respectively.
Note like I said I can't run this right now, so I might have gotten the syntax slightly wrong above, but I hope the intent is clear (set the whole START row to -10000 and STOP column to -10000)

Great, that's actually more elegant! Thanks for the feedback and thanks in general for the whole work you did :)

I just pushed the fix so I will close this issue.  Also, I appreciate the nice comment and am happy the tutorial was helpful for you.


Add package yamlscript

@ingydotnet Hello, https://github.com/yaml/yamlscript/tree/main/nim doesn't have any code in it. Did you publish it by accident? You should also specify the subdir like https://github.com/yaml/yamlscript?subdir=nim.

Thanks for the subdir tip. Was wondering. I'll add some code. Cheers.


[opt](remote scan) Fix remote scan parallelism

What problem does this PR solve?
Do same thing with https://github.com/apache/doris/pull/42633 on master
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall


fix bug with unassigned 'last_activity'

Commenting out the line that assigned last_activity caused an occasional bug in zk_timer_cb: because last_activity was never assigned. When it happend to contain very large values the timer repeat was set far in the future and never happened. Replacing EV_A with uv_default_loop()->ev works for now, although its obviously a little dirty.

Dave, this 1-line change uncomments a variable that was commented by you. I don't have full context here, so it would be good if you could review it.

Yeah, this fix just fixes the original build issues by updating the pointer to the libev loop instance.
We're rolling out a production system that relies heavily on node-zookeeper, so I'd be happy to take over maintainership if you'd like.

I also can not maintain it right now as I have 0 free time. At some point I plan to implement something similar to curator https://github.com/Netflix/curator/wiki but not right now.
So,Russel,your initiative is more than welcome! I just added you to the list of collaborators, and you have write access to this project. I only ask that you regress all unit tests every time there is a change.
Thanks,
Yuri

heh, I'm pretty sure Yuri means that you should NOT regress the unit tests .... :).  ;)

p.s., if you create an NPM account, I can give it publish permissions for the 'zookeeper' module in the NPM Registry.
"npm help adduser"

Regarding the tests, I figured :)
My npm username is russell_h.
We actually already have something vaguely similar to curator's Framework class built on top of node-zookeeper. When I get the chance I'd like to split our "recipes" out more cleanly and release the lot of it, but I want to let things settle down a little here before I touch any of that code.


Should "OneDrive" license be added to the requirements section?

Is a OneDrive/SharePoint license required for the Guest User to be able to sync a library with OneDrive?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 551144b4-b57a-251c-79ef-7bbddfd60e16
Version Independent ID: 2eab7898-16c7-d764-2334-fb561b34c8fb
Content: B2B Sync - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/b2b-sync.md
Service: one-drive
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hello @thiagottss
How are you?
I think that is implied and covered by

Sharing recipients must have a Microsoft 365 work or school account (in Azure AD).

Was the user you were trying to use not licensed at all?
Thanks

Hello @thiagottss How are you? I think that is implied and covered by

Sharing recipients must have a Microsoft 365 work or school account (in Azure AD).

Was the user you were trying to use not licensed at all?
Thanks

Hi!
He was a guest of our tenant. He had a license for their own tenant not for ours.
We were trying to share a large number of files and folders with him and the sync would help a lot.
Thanks,
Thiago.

Hello @thiagottss Thiago,
I tested the scenario on my lab based on your comments, and I had no issues to sync the shared content.
If you still face issues I recommend opening a support request.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

Hello @thiagottss Thiago, I tested the scenario on my lab based on your comments, and I had no issues to sync the shared content. If you still face issues I recommend opening a support request.

Were you able to sync a library from another tenant? Without the need of assigning a license to the Guest account?

I can confirm I just followed the instructions here.

I learned that the "Source" organization needs 1/5 license for external users for B2B


When using Omit, (TypeA | TypeB) & {...} doesn't work as expected anymore

Bug Report
🔎 Search Terms
Omit, OR
🕗 Version & Regression Information
I tried multiple versions on the playground, but all(?) of them have it.
If using Omit, an OR statement doesn't work as expected anymore.
(sorry, I don't know how to call the (TypeA | TypeB) part)
⏯ Playground Link
Playground link with relevant code
💻 Code

type AButNotB = { a: number; b?: never }
type BButNotA = { a?: never; b: number }

type Test = (AButNotB | BButNotA) & { c: number; d: number; e: number }

const test1: Omit<Test, "e"> = {
  a: 1, // INCORRECT: where is the error??? `a` and `b` are both defined
  b: 2,
  c: 3,
  d: 4,
}

const test2: Test = {
  a: 1, // CORRECT: gives error
  b: 2,
  c: 3,
  d: 4,
}

🙁 Actual behavior
No error for test1
🙂 Expected behavior
Error like test2

Omit uses keyof, which only returns common properties for union types. Works as expected.

Hmm, okay, is there any way to accomplish what I expect then?

Look up "distributive omit".

Clear, thank you for the detailed answer ! :)


chore: ignore dartdoc generated api files

Followup to #26.
cc @kevmoo @kwalrath

@chalin FYI: I've moved docs to doc to follow package conventions.
Would you change the ignore to align there?

Closing until fixed – just to make sure it doesn't sneak in. Happy to reopen.


Using connect-mongo with db instance created via createConnection method

I'm using mongoose method "connect" to create instance of my db and defining MongoStore option "db" as db.connection.db. Yes, we are using old version of connect-mongo). So, now I need to connect additional db to my application, it can be possible only via another method of mongoose - "createConnection". I've replaced methods and now my sessions dont work. First of all there was error: Trying to open unclosed connection, after that I've been making any changes: updating version of connect-mongo, passing different options to new MongoStore store, url, db etc. but its not working, sometimes without errors.  We are also using "passport" for identification. Did anybody have such trouble? I think the main problem in different approach in "createConnection" than in "connect" but I'm not shure. Thanks for answers.

I've resolved this issue, createConnection returns another instance, so you need to manage it differently.

Hello @kutsokon can you share how you managed to convert the instance to desired type for MongoStore

app.use(session({
		store: new mongoStore({
			mongooseConnection: db
		})
	}));

db is a mongoose instance

Thanks @kutsokon :)


refactor: updating gitignore file

Minor fix to update gitignore file.

Closing as these changes have been merged into develop.


Add a closeUrlLauncher method to package:url_launcher

This issue is in relation to my comment on #357 (https://github.com/flutter/flutter/issues/357#issuecomment-404877612), and I plan on sending a PR for this (in fact, I'm about to start working on one).
In addition to canLaunch and launch, I 100% believe that the url_launcher package needs a way to close the launched URL, at least when running in a WebView.
In cases like OAuth or other single-sign on flows, once the user has signed in, there is currently no way to close the WebView opened by launch. Having this would be nice in such situations, because the user never has to leave the application get signed; plus, IMO this is low-hanging fruit and can be easily patched with a well-tested community PR.
Anyways, I'm not so sure exactly what the name of the function would be. close is far too common. unLaunch sounds decent at first, but is not so intuitive and might confuse non-native English speakers. closeUrlLauncher is long, but descriptive. I might stick with that, or closeWebview.
I'll get started on this ASAP.  It might take me a little bit of time, though, because I know just about zero Objective-C.

Android changes are done; preview them in this branch: https://github.com/thosakwe/plugins/tree/add-close-to-url-launcher

@thosakwe this seems great, any joy getting the pull request done - really want to use this functionality!

Sorry for necro'ing this issue, but I just wanted to ask if there's been any progress on this... I'd be happy to help with this if anything's needed on Android at least.

Closing, as the feature has been added for a while now.


Addition of 4 missing reactions to RXNO

closes #23

Hi @batchelorc,
please have a look at this. Many Thanks!
Kind regards from the NFDI4Chem TIB team.


Probe-commit control transfer failed with error: RS2_USB_STATUS_IO

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ D456}

Firmware Version
(<IP_ADDRESS>

Operating System & Version
Ubuntu20.04

Kernel Version (Linux Only)
(L4T 5.10.192)

Platform
NVIDIA Jetson orin nano

SDK Version
{ legacy / 2.5.0 }

realsense-ros Version
{ 2.3.2 }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot}

Issue Description
After I use the RSUSB backend without the kernel patching and build the SDK using the RSUSB method it still have error when i lanuch the rs_d435_camera_with_model.launch
ERROR [281472375587184] (uvc-device.cpp:862) Probe-commit control transfer failed with error: RS2_USB_STATUS_IO
[ERROR] [1721367780.707439652]: An exception has been thrown:
Failed to resolve the request:
Format: RGB8, width: 640, height: 480
Into:
Formats:
YUYV
[ERROR] [1721367780.709325917]: Exception:
Failed to resolve the request:
Format: RGB8, width: 640, height: 480
Into:
Formats:
YUYV

Hi @LQ0212  Have you defined a custom FPS speed for the 640x480 resolution, please?  The Failed to resolve the request error usually occurs because a stream configuration has been requested that the camera is not able to provide.
For example, if a custom FPS of 6 was set on a D455 or D456 then this error would occur because these particular camera models have a minimum FPS of 5.

Thank you for your attention, i did't modify the launch file. I think the fps is be set correctly. There is the my launch info.
roslaunch realsense2_camera rs_d435_camera_with_model.launch
... logging to /home/cc/.ros/log/28ecf2e4-45a5-11ef-bdbb-488f4cff0b90/roslaunch-ubuntu-64174.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
xacro: in-order processing became default in ROS Melodic. You can drop the option.
started roslaunch server http://ubuntu:35177/
SUMMARY
PARAMETERS

/camera/realsense2_camera/accel_fps: 250
/camera/realsense2_camera/accel_frame_id: camera_accel_frame
/camera/realsense2_camera/accel_optical_frame_id: camera_accel_opti...
/camera/realsense2_camera/align_depth: False
/camera/realsense2_camera/aligned_depth_to_color_frame_id: camera_aligned_de...
/camera/realsense2_camera/aligned_depth_to_fisheye1_frame_id: camera_aligned_de...
/camera/realsense2_camera/aligned_depth_to_fisheye2_frame_id: camera_aligned_de...
/camera/realsense2_camera/aligned_depth_to_fisheye_frame_id: camera_aligned_de...
/camera/realsense2_camera/aligned_depth_to_infra1_frame_id: camera_aligned_de...
/camera/realsense2_camera/aligned_depth_to_infra2_frame_id: camera_aligned_de...
/camera/realsense2_camera/allow_no_texture_points: False
/camera/realsense2_camera/base_frame_id: camera_link
/camera/realsense2_camera/calib_odom_file:
/camera/realsense2_camera/clip_distance: -2.0
/camera/realsense2_camera/color_fps: 30
/camera/realsense2_camera/color_frame_id: camera_color_frame
/camera/realsense2_camera/color_height: 480
/camera/realsense2_camera/color_optical_frame_id: camera_color_opti...
/camera/realsense2_camera/color_width: 640
/camera/realsense2_camera/confidence_fps: 30
/camera/realsense2_camera/confidence_height: 480
/camera/realsense2_camera/confidence_width: 640
/camera/realsense2_camera/depth_fps: 30
/camera/realsense2_camera/depth_frame_id: camera_depth_frame
/camera/realsense2_camera/depth_height: 480
/camera/realsense2_camera/depth_optical_frame_id: camera_depth_opti...
/camera/realsense2_camera/depth_width: 640
/camera/realsense2_camera/device_type:
/camera/realsense2_camera/enable_accel: True
/camera/realsense2_camera/enable_color: True
/camera/realsense2_camera/enable_confidence: True
/camera/realsense2_camera/enable_depth: True
/camera/realsense2_camera/enable_fisheye1: False
/camera/realsense2_camera/enable_fisheye2: False
/camera/realsense2_camera/enable_fisheye: False
/camera/realsense2_camera/enable_gyro: True
/camera/realsense2_camera/enable_infra1: True
/camera/realsense2_camera/enable_infra2: True
/camera/realsense2_camera/enable_infra: False
/camera/realsense2_camera/enable_pointcloud: False
/camera/realsense2_camera/enable_pose: False
/camera/realsense2_camera/enable_sync: False
/camera/realsense2_camera/filters: pointcloud
/camera/realsense2_camera/fisheye1_frame_id: camera_fisheye1_f...
/camera/realsense2_camera/fisheye1_optical_frame_id: camera_fisheye1_o...
/camera/realsense2_camera/fisheye2_frame_id: camera_fisheye2_f...
/camera/realsense2_camera/fisheye2_optical_frame_id: camera_fisheye2_o...
/camera/realsense2_camera/fisheye_fps: 30
/camera/realsense2_camera/fisheye_frame_id: camera_fisheye_frame
/camera/realsense2_camera/fisheye_height: 480
/camera/realsense2_camera/fisheye_optical_frame_id: camera_fisheye_op...
/camera/realsense2_camera/fisheye_width: 640
/camera/realsense2_camera/gyro_fps: 400
/camera/realsense2_camera/gyro_frame_id: camera_gyro_frame
/camera/realsense2_camera/gyro_optical_frame_id: camera_gyro_optic...
/camera/realsense2_camera/imu_optical_frame_id: camera_imu_optica...
/camera/realsense2_camera/infra1_frame_id: camera_infra1_frame
/camera/realsense2_camera/infra1_optical_frame_id: camera_infra1_opt...
/camera/realsense2_camera/infra2_frame_id: camera_infra2_frame
/camera/realsense2_camera/infra2_optical_frame_id: camera_infra2_opt...
/camera/realsense2_camera/infra_fps: 30
/camera/realsense2_camera/infra_height: 480
/camera/realsense2_camera/infra_rgb: False
/camera/realsense2_camera/infra_width: 640
/camera/realsense2_camera/initial_reset: False
/camera/realsense2_camera/json_file_path:
/camera/realsense2_camera/linear_accel_cov: 0.01
/camera/realsense2_camera/odom_frame_id: camera_odom_frame
/camera/realsense2_camera/ordered_pc: False
/camera/realsense2_camera/pointcloud_texture_index: 0
/camera/realsense2_camera/pointcloud_texture_stream: RS2_STREAM_COLOR
/camera/realsense2_camera/pose_frame_id: camera_pose_frame
/camera/realsense2_camera/pose_optical_frame_id: camera_pose_optic...
/camera/realsense2_camera/publish_odom_tf: True
/camera/realsense2_camera/publish_tf: True
/camera/realsense2_camera/reconnect_timeout: 6.0
/camera/realsense2_camera/rosbag_filename:
/camera/realsense2_camera/serial_no:
/camera/realsense2_camera/stereo_module/exposure/1: 7500
/camera/realsense2_camera/stereo_module/exposure/2: 1
/camera/realsense2_camera/stereo_module/gain/1: 16
/camera/realsense2_camera/stereo_module/gain/2: 16
/camera/realsense2_camera/tf_publish_rate: 0.0
/camera/realsense2_camera/topic_odom_in: odom_in
/camera/realsense2_camera/unite_imu_method:
/camera/realsense2_camera/usb_port_id:
/camera/realsense2_camera/wait_for_device_timeout: -1.0
/robot_description: <?xml version="1....
/rosdistro: noetic
/rosversion: 1.16.0

NODES
/
robot_state_publisher (robot_state_publisher/robot_state_publisher)
rviz (rviz/rviz)
/camera/
realsense2_camera (nodelet/nodelet)
realsense2_camera_manager (nodelet/nodelet)
auto-starting new master
process[master]: started with pid [64198]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to 28ecf2e4-45a5-11ef-bdbb-488f4cff0b90
process[rosout-1]: started with pid [64215]
started core service [/rosout]
process[camera/realsense2_camera_manager-2]: started with pid [64222]
process[camera/realsense2_camera-3]: started with pid [64223]
process[robot_state_publisher-4]: started with pid [64224]
process[rviz-5]: started with pid [64225]
[ INFO] [1721376114.393385207]: Initializing nodelet with 8 worker threads.
[ INFO] [1721376114.560917941]: RealSense ROS v2.3.2
[ INFO] [1721376114.561154619]: Built with LibRealSense v2.50.0
[ INFO] [1721376114.561290335]: Running with LibRealSense v2.50.0
[ INFO] [1721376114.614467111]:
[ INFO] [1721376114.806712075]: Device with serial number<PHONE_NUMBER>06 was found.
[ INFO] [1721376114.807599905]: Device with physical ID 2-1.3-13 was found.
[ INFO] [1721376114.807958154]: Device with name Intel RealSense D455 was found.
[ INFO] [1721376114.808961027]: Device with port number 2-1.3 was found.
[ INFO] [1721376114.809182280]: Device USB type: 3.2
[ INFO] [1721376114.812278421]: getParameters...
[ INFO] [1721376114.889602612]: setupDevice...
[ INFO] [1721376114.889665654]: JSON file is not provided
[ INFO] [1721376114.889685750]: ROS Node Namespace: camera
[ INFO] [1721376114.889706679]: Device Name: Intel RealSense D455
[ INFO] [1721376114.889723255]: Device Serial No:<PHONE_NUMBER>06
[ INFO] [1721376114.889741144]: Device physical port: 2-1.3-13
[ INFO] [1721376114.889755384]: Device FW version: <IP_ADDRESS>
[ INFO] [1721376114.889769688]: Device Product ID: 0x0B5C
[ INFO] [1721376114.889782489]: Enable PointCloud: On
[ INFO] [1721376114.889794809]: Align Depth: Off
[ INFO] [1721376114.889806809]: Sync Mode: On
[ INFO] [1721376114.889892699]: Device Sensors:
[ INFO] [1721376115.021968458]: Stereo Module was found.
[ INFO] [1721376115.062943651]: RGB Camera was found.
[ INFO] [1721376115.064753904]: Motion Module was found.
[ INFO] [1721376115.065141657]: (Confidence, 0) sensor isn't supported by current device! -- Skipping...
[ INFO] [1721376115.065314845]: Add Filter: pointcloud
[ INFO] [1721376115.066024879]: num_filters: 1
[ INFO] [1721376115.066736737]: Setting Dynamic reconfig parameters.
hwmon command 0x80( 5 0 0 0 ) failed (response -7= HW not ready)
hwmon command 0x80( 5 0 0 0 ) failed (response -7= HW not ready)
hwmon command 0x80( 5 0 0 0 ) failed (response -7= HW not ready)
hwmon command 0x80( 5 0 0 0 ) failed (response -7= HW not ready)
[ INFO] [1721376120.961467782]: Done Setting Dynamic reconfig parameters.
[ INFO] [1721376120.962220120]: depth stream is enabled - width: 640, height: 480, fps: 30, Format: Z16
[ INFO] [1721376120.962471326]: infra1 stream is enabled - width: 640, height: 480, fps: 30, Format: Y8
[ INFO] [1721376120.962693700]: infra2 stream is enabled - width: 640, height: 480, fps: 30, Format: Y8
[ INFO] [1721376120.963107502]: color stream is enabled - width: 640, height: 480, fps: 30, Format: RGB8
[ INFO] [1721376120.963151599]: gyro stream is enabled - fps: 400
[ WARN] [1721376120.963175376]: No mathcing profile found for accel with fps=250
[ WARN] [1721376120.963193072]: Using default profile instead.
[ INFO] [1721376120.963207857]: accel stream is enabled - fps: 100
[ INFO] [1721376120.963231281]: setupPublishers...
[ INFO] [1721376120.967409465]: Expected frequency for depth = 30.00000
[ INFO] [1721376121.021746811]: Expected frequency for infra1 = 30.00000
[ INFO] [1721376121.052392882]: Expected frequency for infra2 = 30.00000
[ INFO] [1721376121.095670977]: Expected frequency for color = 30.00000
[ INFO] [1721376121.145150635]: setupStreams...
19/07 16:02:01,591 WARNING [281472448123248] (ds5-motion.cpp:473) IMU Calibration is not available, default intrinsic and extrinsic will be used.
19/07 16:02:01,905 WARNING [281472216850800] (messenger-libusb.cpp:42) control_transfer returned error, index: 300, error: Resource temporarily unavailable, number: b
19/07 16:02:01,909 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,911 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,914 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,917 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,919 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,922 WARNING [281472023916912] (messenger-libusb.cpp:42) control_transfer returned error, index: 4, error: Resource temporarily unavailable, number: b
19/07 16:02:01,922 ERROR [281472448123248] (uvc-device.cpp:862) Probe-commit control transfer failed with error: RS2_USB_STATUS_IO
[ERROR] [1721376122.115376196]: An exception has been thrown:
Failed to resolve the request:
Format: RGB8, width: 640, height: 480
Into:
Formats:
YUYV
[ERROR] [1721376122.115534120]: Exception:
Failed to resolve the request:
Format: RGB8, width: 640, height: 480
Into:
Formats:
YUYV

Thank you very much for the log.
The recommended firmware to use with librealsense 2.50.0 is <IP_ADDRESS> rather than <IP_ADDRESS>, which is designed for librealsense 2.55.1.
The launch file rs_d435_camera_with_model.launch is typically only used when performing robot simulation with Gazebo.   Do you experience the error if you use the rs_camera launch file?
roslaunch realsense2_camera rs_camera.launch

yes, if i modify the launch file like below it also has the same error. the origin rs_camera.launch can run without error but i can't get the topic /camera/depth/color/points which is necessary to my project

  <arg name="enable_pointcloud"        value="$(arg enable_pointcloud)"/>
  <arg name="pointcloud_texture_stream" value="$(arg pointcloud_texture_stream)"/>
  <arg name="pointcloud_texture_index"  value="$(arg pointcloud_texture_index)"/>
  <arg name="enable_sync"              value="$(arg enable_sync)"/>
  <arg name="align_depth"              value="$(arg align_depth)"/>

  <arg name="fisheye_width"            value="$(arg fisheye_width)"/>
  <arg name="fisheye_height"           value="$(arg fisheye_height)"/>
  <arg name="enable_fisheye"           value="$(arg enable_fisheye)"/>

  <arg name="depth_width"              value="$(arg depth_width)"/>
  <arg name="depth_height"             value="$(arg depth_height)"/>
  <arg name="enable_depth"             value="$(arg enable_depth)"/>

  <arg name="confidence_width"         value="$(arg confidence_width)"/>
  <arg name="confidence_height"        value="$(arg confidence_height)"/>
  <arg name="enable_confidence"        value="$(arg enable_confidence)"/>
  <arg name="confidence_fps"           value="$(arg confidence_fps)"/>

  <arg name="color_width"              value="$(arg color_width)"/>
  <arg name="color_height"             value="$(arg color_height)"/>
  <arg name="enable_color"             value="$(arg enable_color)"/>

  <arg name="infra_width"              value="$(arg infra_width)"/>
  <arg name="infra_height"             value="$(arg infra_height)"/>
  <arg name="enable_infra"             value="$(arg enable_infra)"/>
  <arg name="enable_infra1"            value="$(arg enable_infra1)"/>
  <arg name="enable_infra2"            value="$(arg enable_infra2)"/>
  <arg name="infra_rgb"                value="$(arg infra_rgb)"/>

  <arg name="fisheye_fps"              value="$(arg fisheye_fps)"/>
  <arg name="depth_fps"                value="$(arg depth_fps)"/>
  <arg name="infra_fps"                value="$(arg infra_fps)"/>
  <arg name="color_fps"                value="$(arg color_fps)"/>
  <arg name="gyro_fps"                 value="$(arg gyro_fps)"/>
  <arg name="accel_fps"                value="$(arg accel_fps)"/>
  <arg name="enable_gyro"              value="$(arg enable_gyro)"/>
  <arg name="enable_accel"             value="$(arg enable_accel)"/>

  <arg name="publish_tf"               value="$(arg publish_tf)"/>
  <arg name="tf_publish_rate"          value="$(arg tf_publish_rate)"/>

  <arg name="filters"                  value="$(arg filters)"/>
  <arg name="clip_distance"            value="$(arg clip_distance)"/>
  <arg name="linear_accel_cov"         value="$(arg linear_accel_cov)"/>
  <arg name="initial_reset"            value="$(arg initial_reset)"/>
  <arg name="reconnect_timeout"        value="$(arg reconnect_timeout)"/>
  <arg name="wait_for_device_timeout"  value="$(arg wait_for_device_timeout)"/>
  <arg name="unite_imu_method"         value="$(arg unite_imu_method)"/>
  <arg name="topic_odom_in"            value="$(arg topic_odom_in)"/>
  <arg name="calib_odom_file"          value="$(arg calib_odom_file)"/>
  <arg name="publish_odom_tf"          value="$(arg publish_odom_tf)"/>
  <arg name="stereo_module/exposure/1" value="$(arg stereo_module/exposure/1)"/>
  <arg name="stereo_module/gain/1"     value="$(arg stereo_module/gain/1)"/>
  <arg name="stereo_module/exposure/2" value="$(arg stereo_module/exposure/2)"/>
  <arg name="stereo_module/gain/2"     value="$(arg stereo_module/gain/2)"/>

  <arg name="allow_no_texture_points"  value="$(arg allow_no_texture_points)"/>
  <arg name="ordered_pc"               value="$(arg ordered_pc)"/>

</include>

The pointcloud is disabled by default in the launch file.  It can be enabled using the launch command below.
roslaunch realsense2_camera rs_camera.launch filters:=pointcloud
https://github.com/IntelRealSense/realsense-ros/tree/ros1-legacy?tab=readme-ov-file#point-cloud

I also try this, it can run.  However, when i try to echo the topic /camera/depth/color/points  there are the log about
[ INFO] [1721380215.120778310]: publishing unordered pointcloud.
[ WARN] [1721380215.346897315]: No stream match for pointcloud chosen texture Process - Color
and there is no output in the rostopic echo

No stream match for pointcloud chosen texture Process - Color means that color frames are missing because they are being dropped.
You can publish an ordered pointcloud instead of an unordered one by adding ordered_pc:=true to your roslaunch instruction.
If this does not make a difference then you could try texturing the pointcloud with the infrared image instead of the RGB color image.
roslaunch realsense2_camera rs_camera.launch filters:=pointcloud pointcloud_texture_stream:="RS2_STREAM_INFRARED"

Sometimes the pointcloud filter of the ROS1 wrapper will not work with Jetson boards.  A workaround is to perform an RGBD launch instead of rs_camera.

Install support for an RGBD launch with the command below.

sudo apt-get install ros-noetic-rgbd-launch

Use the rs_rgbd.launch file.

roslaunch realsense2_camera rs_camera.launch
You do not need to enable the pointcloud filter on this launch file as it is already enabled by default.
The pointcloud will be published to depth_image_proc instead of /camera/depth/color/points
/depth/image/proc

thanks for your help. I will try it on Monday and update the results @MartyG-RealSense

You are very welcome.  I look forward to your next update.  Good luck!

Sorry to bother you @MartyG-RealSense . I try the method which use orderd_pc doesn't make any difference. And when I use infrared image the log output as below.
[ INFO] [1721609567.428119131]: publishing unordered pointcloud.
[ WARN] [1721609567.745491636]: No stream match for pointcloud chosen texture Process - Infrared
I try to use rs_rgbd.launch file
roslaunch realsense2_camera rs_rgbd.launch
I can't find any topic with depth_image_proc.

You're very welcome.  I'm pleased to hear that rs_rgbd worked for you!

Hi @LQ0212  Do you require further assistance with this case, please?  Thanks!

Hi @MartyG-RealSense thanks for your assistance, I have no further issue. I will close this issue.

Thanks very much @LQ0212 for the update!


looper check implementation

Raised by @rcorces

whenever I run looper check, it always reports statistics for all folders in the results directory, not just the samples that correspond to the annotation file that is detailed in the config.yaml file.
Is this really the desired behavior? I know its pretty easy to just use the ls | xargs | sort | uniq one-liner but doesn't it seem like the correct behavior would be to only report the status of samples associated with the annotation.csv file?

He is right. the current implementation of looper check is just looking at the project output folder, and then running an ls to get all subfolders. It should instead actually build the project and then loop through each samples in Python, instead of using the shell.

I'll also add that I definitely see value for having the ability to check the status of all subfolders of the results directory. It just seems like the default behavior of "check" should mimic the other looper functions like "run" which only act on the samples in the annotation file. So maybe an ideal implementation would allow for both. Perhaps something like an optional argument "-a" for "report all subfolders in the results directory"
looper check config_file
only outputs the status of the samples in the annotation file detailed in the config file
looper check -a config_file
outputs the status of all samples in the results dir detailed in the config file


How to ignore searching inside node_modules

Using !(node_modules)/**/package.json still seems to search within node_modules...or at least its still very slow compared to every other library I'm testing.

Agree, without this feature, I can't adopt tiny-glob, which I was planning to do for storybook.

It's probably easier to add an exclude option to prevent traversing of unwanted directories.
see #74
see How to exclude directory from reading? for fast-glob

any update?


UTF-8 Everywhere best practices

While the majority of the library is already written using classic Win32 wchar_t style (i.e. UTF-16 LE), to support UTF-8 Everywhere the library should be updated in a few ways:

Existing Win32 API calls should use the "W" version rather than relying on auto-selection based on the UNICODE macro (i.e. use CreateFileW and not CreateFile).

All APIs that currently take wchar_t* for filenames should have an overload which takes a char * which is UTF-8.

SpriteFont was already updated to take UTF-8 strings for DrawString.

The only Win32 API that takes a string used by the library is CreateFile which I already use CreateFileW. On Windows 8 or later, I'm using CreateFile2 which only has a Unicode version.
I did find a few issues in xwbtool that I fixed.

Need a UTF-8 variant of the TextConsole helper as well.

I also updated the directx-vs-templates


post /v3/conversations cause an "Cannot read property 'payload' of undefined"  error  (V4 Preview)

Hi,
I post "emulatorserver/v3/conversations" with body  through Fiddler when V3 Emulator is running.
V3 Emulator will show createConversation 200.
When I change to V4 Emulator, I will get {"code":"InternalError","message":"Cannot read property 'payload' of undefined"} in fiddler.
The fiddler Request Body is below,
 {
  "bot": {
    "id": "405b2580-9170-11e8-bdc0-fda88c496bd5"
  },
  "members": [
    {
      "id": "default-user"
    }
  ],
  "activity": {
    "from": {
      "id": "xxxxRMBot"
    },
    "recipient": {
      "id": "tds"
    },
    "membersAdded": [],
    "membersRemoved": [],
    "reactionsAdded": [],
    "reactionsRemoved": [],
    "attachments": [],
    "entities": []
  }
}

Hey @rainmakerho,
I tried to POST your payload to the emulator-server/v3/conversations endpoint on both V3 and V4 and the same error for both of them but a different error than the one you got:
Cannot read property '1' of null.
I tracked it down to being a result of the POST not having an Authorization: Bearer <token> header attached to the request.
I then tried to POST the same payload to both V3 and V4 with an Authorization header and got a 200 back with the conversation id.
So just out of curiosity, did you have an Authorization header with a bearer token attached to either of your POST requests? I saw a similar piece of code in the emulator that tries to read a .payload property of a decoded bearer token, but the code should detect the token is non-existent before then and throw a 401.
Although, this still doesn't really explain why your POST worked on V3 and not V4, but it might help me debug the issue further.

@tonyanziano ,
I post it through Fiddler, and not having an Authorization.
My code is below (MessagesController's Post([FromBody]Activity activity)),
if(activity.Type == ActivityTypes.Message)
{
	try
	{
		var userId = activity.From.Id;
		var botId = activity.Recipient.Id;
		var emulatorServiceUrl = activity.ServiceUrl;
		var message = new Activity();
		var userAccount = new ChannelAccount(userId);
		var botAccount = new ChannelAccount(botId);
		message.From = userAccount;
		message.Recipient = botAccount;
		message.ServiceUrl = emulatorServiceUrl;
		var members = new List<ChannelAccount>() { userAccount };
		var conversationParams = new ConversationParameters(bot: botAccount, members: members, activity: message);
		var connectorClient = new GssConnectorClient(new Uri(emulatorServiceUrl));
		var replyConversation = await connectorClient.Conversations.CreateConversationAsync(conversationParams);
		message.Conversation = new ConversationAccount(id: replyConversation.Id);
		var replyMessage = message.CreateReply();
		replyMessage.Text = $"my new conversationId:{replyConversation.Id}";
		await connectorClient.Conversations.SendToConversationAsync(replyMessage);
		var response = Request.CreateResponse(HttpStatusCode.OK);
		return response;
	}
	catch(Exception exx)
	{

		throw;
	}

}

It will get new conversationId on V3, error on V4 .
error code is below,
at Microsoft.Bot.Connector.Conversations.d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Bot.Connector.ConversationsExtensions.d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at VitalsESPBot.Controllers.MessagesController.d__0.MoveNext()
Thanks for your help.

@rainmakerho , I have looked into this issue, and all you need to do is add an Authorization header to your POST request and it should work in the v4 emulator. The Authorization header is something that is required in the v3 DirectLine POST activity schema (Directline POST schema) and so in the Emulator as well.
Here is an example of the request I posted to the Emulator to successfully create a new conversation:
Request:
POST http://localhost:54089/v3/directline/conversations
Authorization: Bearer iamatoken

Response:
{
    "conversationId": "4cca5ce0-03c2-11e9-9e3b-95e19b0f415e",
    "token": "http://localhost:3978/api/messages",
    "expires_in":<PHONE_NUMBER>,
    "streamUrl": ""
}

@tonyanziano ,
Do I need to give token even if i use Emulator?
Do I need to issue token from botframework.com ?
Thank you.

@rainmakerho , If you are talking to a bot through the Emulator UI, you should not need to generate a token because auth will be handled for you by the Emulator. If it's a remote bot that you are talking to, you will of course have to supply the correct MSA App ID and Password.
If you are posting directly to the Emulated endpoint like in your original comment, then you will need to supply a token. If the bot is a local bot, you can just pass in any value for the token, such as:
Authorization: Bearer someTokenValue or Authorization: Bearer imadethisup
If the bot is remote, you will need to use an actual token issued by the bot service.

Hi @tonyanziano ,
I got it.
Thank you for your help.

@rainmakerho No problem!


pa.sh does not handle arguments correctly

It seems that pash has a bug in its argument handling.
The script to run is test.sh.
#!/usr/bin/env bash

printf '%s\n' "$@"

When executed via pa.sh, the space-separated words are the individual arguments.
$  ./test.sh "foo bar" baz
foo bar
baz

$ pa.sh -- ./test.sh "foo bar" baz
foo
bar
baz

In addition, pathname expansion is performed.
$ ls
file1  file2  file3  test.sh

$ pa.sh -- ./test.sh foo '*' baz
foo
file1
file2
file3
test.sh
baz

Thanks for reporting these, we will take a look! In general, PaSh has multiple issues with quotes and escaping at the moment, which we are aiming to deal with in a principled way.

These issues are fixed by PR #578 !

Closing since the issues were fixed, but feel free to reopen if you find some other issue related to this, thanks!


Review and update plant details

Implement a details page for plant attributes and a form to submit updated information on that plant.
Fulfills use case "plant reviews".

@markus2330 should this also be provisionally placed as it's own route like the seeds use case? Additionally, should all information on the plant be displayed and be editable or only a subset?

@markus2330 should this also be provisionally placed as it's own route like the seeds use case?

This is an implementation detail and not necessary to be written in a use case.

Additionally, should all information on the plant be displayed and be editable or only a subset?

Only a small subset, mostly the things which were created specifically for PermaplanT (e.g. is_tree, companions).

This is an implementation detail and not necessary to be written in a use case.
I thought I was assigned to implement this use case as part of this weeks tasks, at least thats what we talked about on Tuesday. And in that case I do need implementation details.

No, this is an misunderstanding then. This week is for you "only" about:

finalizing the use cases itself
DB/ER Diagram
Colors in Frontend
Mockups (iirc 3 week deadline from last Pavlo meeting)

Together with the other stuff everyone needs to do I think it is more than enough :+1:

Ok, then i'm sorry for the misunderstanding. I will immediatelyshift focus to the other tasks.

This issue still doesn't have importance, I'll close it.


Enhancements: Permission Checks and Error Handling

Implemented utility functions for permission verification and improved error handling across azimuth-cli, particularly in createClient. These changes streamline permission checks, enhance security, and improve reliability during network requests. Refactored relevant command files to leverage these improvements, significantly boosting code maintainability and debuggability.

Hey, sorry in the delay in getting back to you. This looks great. I'll try to merge it shortly.


Issues appear when downloading songs from a spotify playlist with --use-youtube and target download is a usb drive.

System OS
Windows
Python Version
3.9 (CPython)
Install Source
GitHub
Install version / commit hash
v3.9.0
Expected Behavior vs Actual Behavior
To download songs and seems to be doing so. I do not know what this error means. It asked me to report it lol.
Steps to reproduce

Open Windows Powershell
Select where you want the songs to download to (ex: H:) (usb drive)
type (spotdl https://open.spotify.com/playlist/4IVC6SId5jvTLPSItS2bOM?si=391648fecc4c4452 --use-youtube)
Let it run
While it fetches songs, I start to receive errors.

Traceback
Googled spotdl
download the ffmpeg
download python
run spotdl
select usb drive
type (spotdl https://open.spotify.com/playlist/4IVC6SId5jvTLPSItS2bOM?si=391648fecc4c4452 --use-youtube)
It runs
I then get there weird errors
They so far don't cause harm
Have not finished fetching
So therefor I do not know how downloading will go.
Will update with further information

Other details

Please

Provide the link to reproduce your error. "Download a playlist with almost 1000 songs" will not help us.
Change the title
Provide a full traceback of your error, from top to bottom.

Please

Provide the link to reproduce your error. "Download a playlist with almost 1000 songs" will not help us.
Change the title
Provide a full traceback of your error, from top to bottom.

It should be updated now.

It should be fine, it's not an issue with spotdl tho.
/cc @tfdahlin

It should be fine.
/cc @tfdahlin

okay. Just wanted to report it somewhere.


Fix issue #141

Coverage remained the same at 90.461% when pulling 2fba78955816bc73e6a4aaf57584816674e6483a on issue_141 into b7941cf4fd6256542b153623229fa285b4160175 on master.


Improve rsc syntax highlighting

Here's a couple of small improvements.

escape sequence highlighting
and or in operator highlighting

Is it intentional that rscSpecial is included in rscString?

Closing as this was supposed to go elsewhere.  Operator error of a new GitHub client...


test: add playwright test for ask interaction

Purpose
Add a E2E test for the "Ask a question" interaction.
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: Test

How to Test
npm run test:playwright

LGTM but some tests are failing?


Allow functions to have unique symbol or new symbol as the return type

Search Terms

unique symbol
new unique symbol
new symbol

Suggestion
I request that unique symbol be allowed as the return type of a function declaration.
Alternatively, it might be better to use new symbol to disambiguate https://github.com/microsoft/TypeScript/issues/40106#issuecomment-677741032.
Use Cases
Currently, it’s impossible to create an alias or a wrapper function for the global Symbol constructor and use that to construct unique symbols:
// ./es-globals/fundamentals.js
export const ESSymbol = Symbol;
export const { for: ESSymbol_for } = ESSymbol;

// ./es-globals/fundamentals.d.ts
export import ESSymbol = globalThis.Symbol;
export declare const ESSymbol_for: typeof ESSymbol.for;

// ./symbols.js
import { ESSymbol, ESSymbol_for } from "./es-globals/fundamentals.js";

// should be `unique symbol`, but is instead `symbol`:
export const customSymbol = ESSymbol("custom");

// should be `unique symbol` or `global symbol "nodejs.util.inspect.custom"`,
// but is instead `symbol`:
export const nodejs_util_inspect_custom = ESSymbol_for("nodejs.util.inspect.custom");

// should be `unique symbol` or `global symbol "nodejs.util.promisify.custom"`,
// but is instead `symbol`:
export const nodejs_util_promisify_custom = ESSymbol_for("nodejs.util.promisify.custom");

Examples
This would allow defining SymbolConstructor as:
declare interface SymbolConstructor {
	/**
	 * Returns a new unique Symbol value.
	 * @param description Description of the new symbol value.
	 */
	(description?: string | number): new symbol;

	/**
	 * Returns a Symbol object from the global symbol registry matching the given key if found.
	 * Otherwise, returns a new symbol with this key.
	 * @param key key to search for.
	 */
	for<T extends string>(key: T): global symbol T;
	// or, until GH-35909 is implemented:
	for(key: string): new symbol;
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

See also

https://github.com/microsoft/TypeScript/issues/36468
https://github.com/microsoft/TypeScript/issues/35909 (global symbol "<name>" proposal)
https://github.com/microsoft/TypeScript/pull/24738
https://github.com/microsoft/TypeScript/issues/24506
https://github.com/microsoft/TypeScript/issues/40106
https://github.com/microsoft/TypeScript/pull/42543

You can sort of get around it using some epik type-level hax, but I don't know if as casting is cheating.
const sym: (a: string) => { readonly 0: unique symbol }[0]
  = a => Symbol(a) as ReturnType<typeof sym>

const bad = sym("wat")
// const bad: symbol
const good: ReturnType<typeof sym> = sym("neat")
// const good: unique symbol

I tried everything even @Shou's hack.  There is no work around and we def need some changes.
// What I originally expected to work
const [$arr, $head, $tail] = 'array head tail'.split(' ').map(Symbol.for);
// A computed property name in a class property declaration must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1166)
interface TestClass { [$arr]: boolean; } // using interface for this test because then I don't have to come up with new name for each example

// Can't cast to unique symbol. Err: 'symbol' expected.ts(1005)
const [$arrAofUS, $headAofUS, $tailAofUS] = 'array head tail'.split(' ').map(Symbol.for) as unique symbol[];
const [$arrCAofUS, $headCAofUS, $tailCAofUS] = 'array head tail'.split(' ').map(Symbol.for) as Array<unique symbol>;
// A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
interface TestClass { [$arrAofUS]: boolean; [$arrCAofUS]: boolean; }

// None of these work either
const [$arrEAofS, $headEAofS, $tailEAofS] = 'array head tail'.split(' ').map(Symbol.for) as [symbol, symbol, symbol];
// 'unique symbol' types are not allowed here.ts(1335)
const [$arrEAofUS, $headEAofUS, $tailEAofUS] = 'array head tail'.split(' ').map(Symbol.for) as [unique symbol, unique symbol, unique symbol];
// A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
interface TestClass { [$arrEAofS]: boolean; [$arrEAofUS]: boolean; }

// It's not the split messing it up.  Error: 'unique symbol' types are not allowed here.ts(1335)
const [$arrAM, $headAM, $tailAM] = ['array', 'head', 'tail'].map(Symbol.for);
// Doesn't work with destructuring!
const [$arrD, $headD, $tailD] = ([Symbol.for('array'), Symbol.for('head'), Symbol.for('tail')]);
// A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
interface TestClass { [$arrAM]: boolean; [$arrD]: boolean; }

// Even when trying @Shou's hack
type UniqueSymbol = ReturnType<(a: string) => { readonly 0: unique symbol }[0]>;

// testing if UniqueSymbol works on the simple cases
// NOPE! Err: Type 'typeof $test' is not assignable to type 'typeof 0'.ts(2322)
const $testCustomUniqueSymbol: UniqueSymbol = Symbol.for('test');
// This does if it's casted before assignment
const $testCastedCustomUniqSym: UniqueSymbol = Symbol.for('test') as UniqueSymbol;
// but it's still not a unique symbol! Err: Type 'typeof 0' is not assignable to type 'typeof $testUniqSym'.ts(2322)
const $testNativeUniqSym: unique symbol = $testCustomUniqueSymbol;
// however it does work for regular symbol
const $testNativeSym: symbol = $testNativeUniqSym;

// Attempt at destructuring again, and even explicit casting
const [$arrFnUS, $headFnUS, $tailEFnUS]: [UniqueSymbol, UniqueSymbol, UniqueSymbol] = 'array head tail'.split(' ').map(Symbol.for) as [UniqueSymbol, UniqueSymbol, UniqueSymbol];
interface TestClass {
  [$testCustomUniqueSymbol]: boolean;   // Works so we know our UniqueSymbol type works for some cases
  [$testCastedCustomUniqSym]: boolean;  // Works
  [$testNativeUniqSym]: boolean;        // Works
  // Surprised testNativeSym doesn't work!
  [$testNativeSym]: boolean;  // Err: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
  [$arrFnUS]: boolean;        // Err: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
}

// Attempts to hack around it:
// Err: Type 'symbol[]' is not assignable to type '(unique symbol)[]'. Type 'symbol' is not assignable to type 'unique symbol'.ts(2322)
const toSymArr = (str: string): UniqueSymbol[] => str.split(' ').map(Symbol.for);
// hack around the error
const toSymArr2 = (str: string): UniqueSymbol[] => str.split(' ').map(Symbol.for) as any;
// will it work?
const [$arrFn, $headFn, $tailFn] = toSymArr('array head tail');
// nope! Err: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1169)
interface TestClass { [$arrFn]: boolean;  }

Relative to the cost here, quite a bit more 🙃. 15 upvotes and 3 comments in two years is not a lot.

Would like to add my voice to this.  Currently passing around magic strings instead of Symbols.  Until this is implemented, the main use case of Symbols doesn't work in TS... though I guess Symbols are only used by a minority of high-level devs.

This bug gums up the inner workings of an internal system for securely exposing subsets of class APIs to untrusted third party scripts for Transcend Consent. We have a createInterfaceViewerKeypair function that returns two new symbol that cannot currently typed correctly in TypeScript.


profile_utils.py:164 causes warning message

Summary
The profile_utils.py causes following annoying warning messages. Please figure out a way to eliminate it.
profile_utils.py:164: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  data['time'] = data['time'].astype(float)

Version
Python 3.10.6
Pandas 1.5.3
Environment
Ubuntu 22.04.1 LTS
Steps to reproduce
python3 profile_utils.py
Observed behavior
The annoying warning messages presented above
Expected behavior
No warning messages presented in the console output

OneSmpl_Team3 working on this.

(OneSmpl_Team3) -
@shuangpe
We tried running this code with various arguments, but we see no warnings coming.
PFB screenshot for the same:


Performance Issue: Gin Index on Guid[] property is not used when querying on child collections

Posting this here after a discussion on Discord: Full Discussion
Additionally, I have a minimal repro created which demonstrates the issue on a number of queries and can be ran locally: https://github.com/lucaswalter/MartenGinIndexRepro
In short, I have a document with a Guid[] property and a gin index created on the property.
In my system, I need to query for documents which have a matching Guid inside the array property. When executing LINQ queries such as .Contains() or .Any(), the executed query performances a sequential scan and takes over 5 seconds to run.
Document
public record Game(
    Guid Id,
    string Name,
    Guid[] GenreIds
);

Config
public static void AddGameModule(this StoreOptions options)
    {
        options.RegisterDocumentType<Game>();

        options.Schema
            .For<Game>()
            .Index(o => o.Id, cfg =>
            {
                cfg.IsUnique = true;
            });

        options.Schema
            .For<Game>()
            .Index(o => o.GenreIds, cfg =>
            {
                cfg.Method = IndexMethod.gin;
            });
    }

Attempted Queries (Each take over 5 seconds to complete)
/*
 * Attempts to query games where the given 'genreId' is in the 'GenreIds' array using '.Contains()'
 */
app.MapGet("/games/contains-query", (Guid? genreId, int? skip, int? take, IQuerySession session) =>
{
    var genreIdValue = genreId ?? Guid.Parse("61d3504e-ac0b-4330-9c52-44beed79ff76"); // Racing Genre
    var dbQuery = session
        .Query<Game>()
        .Where(o => o.GenreIds.Contains(genreIdValue))
        .Skip(skip ?? 0)
        .Take(take ?? 100);

    // var sql = dbQuery.ToCommand();
    // var queryPlan = dbQuery.Explain();

    var games = dbQuery.ToList();
    return Results.Ok(games);
});

/*
 * Attempts to query games where the given 'genreId' is in the 'GenreIds' array using '.Any()'
 */
app.MapGet("/games/any-query", (Guid? genreId, int? skip, int? take, IQuerySession session) =>
{
    var genreIdValue = genreId ?? Guid.Parse("61d3504e-ac0b-4330-9c52-44beed79ff76"); // Racing Genre
    var dbQuery = session
        .Query<Game>()
        .Where(o => o.GenreIds.Any(id => id == genreIdValue))
        .Skip(skip ?? 0)
        .Take(take ?? 100);

    // var sql = dbQuery.ToCommand();
    // var queryPlan = dbQuery.Explain();

    var games = dbQuery.ToList();
    return Results.Ok(games);
});

Duplicate with https://github.com/JasperFx/marten/issues/2051

Subsumed by https://github.com/JasperFx/marten/issues/2703


Make options params optional in useMachine hook type

Currently, the useMachine hook's second parameter is optional and has a default fallback value of {}. However, this fallback value is not declared in the type definition file, causing a type error when it is used.
This pull request addresses the issue by updating the type definition file to include the fallback value {} for the second parameter of the useMachine hook. This change ensures that the type declarations align with the actual behavior of the hook, preventing type errors in usage.
To provide more context, the screenshot below illustrates the current type error:

This fix will enhance the developer experience and prevent potential issues related to incorrect typings when using the useMachine hook.

I'm closing this PR for housekeeping purposes as I think that it's not something that we want to pull. If you feel that we should reconsider this decision - feel free to comment back so we could continue the discussion.


some tests around workflow mocking

TL;DR
Some additional test cases for #218 to document current behaviour
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

Moved to #222


Update codeschools.yml

Updates codeschools.yml and created new location endpoints
Location endpoints feature request
CodeSchools.yml add devCodeCamp request
Issue Resolved:

Added endpoints for the frontend team to have an api to add additional locations for a school
Adds the devCodeCamp to the .yml file. with required information

Concerns:
I'm concerned that running the rake task rake schools:populate would result in duplicate code_school entries in the database because we don't validate on uniqueness. I could update this as well but would like to hear other thoughts on this.
Also I haven't updated documentation for the API. Just wanted an initial review from @hpjaj
CC
@hpjaj could you confirm if codeschools.yml this might be an issue or not? I'm uncertain as to how the file is used other than the way I used it(as a rake task to populate the db.)

Closing this pull request because it references two issues.

Issue #213 Feature add location endpoints
Issue #205 update codeschools yml


Q2 Recap/Update

@RichardLitt I'm not entirely sure on what this update will include. Could you fill in a bit to get it rolling for @jbenet?

Closing this because window of opportunity has passed.


Consider adding/moving Windows 10 information into appropriate sections

Windows 10 is mentioned only in section "How to remove SMB v1". Consider moving the subsection that explains how to detect, enable and disable SMB protocols on Windows 10 into the appropriate section, i.e. move it to "How to detect status, enable, and disable SMB protocols on the SMB Server" section. Also, add Windows 10 information to "How to detect status, enable, and disable SMB protocols on the SMB Client".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a91db45-ca3c-7a2e-3f32-2f5b57837b03
Version Independent ID: b83cbaab-c0df-d6e7-a67f-f4c99a46e30a
Content: How to detect, enable and disable SMBv1, SMBv2, and SMBv3 in Windows
Content Source: WindowsServerDocs/storage/file-server/Troubleshoot/detect-enable-and-disable-smbv1-v2-v3.md
Product: windows-server
Technology: storage
GitHub Login: @Deland-Han
Microsoft Alias: delhan

#assign:IngridAtMicrosoft

This issue is addressed in PR https://github.com/MicrosoftDocs/windowsserverdocs-pr/pull/2405
@IngridAtMicrosoft

Addressed. #please-close


participant_label option error when using fmriprep-docker

Running the following command
fmriprep-docker --participant_label "001" "$BIDSROOT" "$OUTPUT" "participant"
produces the following error:
fmriprep: error: argument --participant_label/--participant-label: expected at least one argument
Note that using using the following works just fine:
docker "run" -ti --rm \
  -v "$BIDSROOT:/data" \
  -v "$OUTPUT:/output" \
  -v "$FSHOME:/fs_home" \
  "poldracklab/fmriprep" \
  "/data" "/output" "participant" --fs-license-file "/fs_home/license.txt" --participant_label "001"

What am I missing?

Trying to put flagged arguments before the positional arguments (data, output and analysis level) can cause problems with the parser. Because --participant-label can take multiple arguments, there's inherent ambiguity to that argument string, and it seems that the parser interprets "001" as your data directory.
The following should work:
fmriprep-docker "$BIDSROOT" "$OUTPUT" participant --participant_label 001

Hello,
Thanks, indeed in that case it works ! But adding multiple participants labels

--participant-label="001 002"

gives me the error

Could not find data for participant(s): "001 002"

Running separately with 002 alone works well.
I tried escaping double quotes, and/or putting the whole list into single quotes, but nothing seems to make it happy. Any ideas?

Don't use quotes. Just use --participant-label 001 002.

Ok it works, thanks!


Netflix addon error the dependency on xbmx.python version 3.0.0 could not be satisfied

I'm submitting a ...

[x] support request

General information
i have installed latest version of kodi leia 18.7 and now i can't open netflix i have installed it from CostagnaIT repository.
i have tried to install it using the file: plugin.video.netflix-master.zip but im still getung the same error
(((the dependency on xbmx.python version 3.0.0 could not be satisfied)))
Please help guys to solve my problem.
Im using Kodi on raspberry pi 3

You must install the Leia version of the addon, not the Matrix version.
https://github.com/castagnait/repository.castagnait/raw/master/repository.castagnait-1.0.1.zip

You must install the Leia version of the addon, not the Matrix version.
https://github.com/castagnait/repository.castagnait/raw/master/repository.castagnait-1.0.1.zip

Thanks for your respond,
i have installed the version 1.12.2 from the link provided below however I'm still getting the same error, also i ha e noticed the that always the update icon it shows next to the addon.

I would say try to delete both Netflix addons and reinstall. And why don't you ask those questions on the CastagnaIT page?


linux-linaro-qcomlt-dev: remove DT-schema-disablement patch

Respective change was merged upstream, so drop unused patch.
Signed-off-by: Dmitry Baryshkov<EMAIL_ADDRESS>

What does that mean, it was merged upstream?

@ndechesne yes, see https://github.com/torvalds/linux/commit/75e895343d5a2fcbdf4cb3d31ab7492bd65925f0#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

nice! I didn't know!


Permission request

There is no video here showing the behavior on mobile vs web, it's kind of hard to confirm the logic works just by looking at it


nothing displayed on LCD

I just purchased a Sparkfun SH1106 LCD and have it connected to an ESP32-C6.  The Sparkfun Arduino OLED simple "Hello" text example works.
When I switch over to Rust and run the text.rs example it works.  But after power down/up or reset the board the Rust example no longer works.  If I switch back to Arduino and upload the same Hello text example is works, and so does the Rust text.rs example again.
There seems to be something missing in the init() method, I think.

I solved my problem.  After looking this the Sparkfun Arduino OLED library I found that it used a SSD1306 "device" module and not a SH1106.  There documentation show that the LCD contains a SH1106.
Once I switched to the SSD1306 crate the OLED display works well.


Added option to disable deploy of Pull Request after testing

Despite on guidelines changes to dist/scripts/app.js were very gentle.

Nice :+1:


Fix sorting when value is integer

When an integer value was set via "valueField", the associative array "_items" used the value of "valueField" as key and the array was incorrectly sorted by "valueField" With this pull request it should maintain the correct ordering.

that would break setHiddenVal
wouldn't it be possible to simply cast to integer to a string?


Fix #755: Add Instruction how to install on windows

Hi, please i need this, i have this message on cli : 'Failed to start local web server'. after run 'platform login', any idea ?
Thanks

Git Bash (based on mintty) is just one terminal that doesn't support piping commands with |, so it's not really a "Windows" problem. Other shells such as Bash on the WSL will support piping commands.
So at least - in addition to this PR - I/we should see if the WSL makes everything easier, and strongly recommend it if so.