Istio TCP L4 Matching not working properly

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Istio TCP L4 Matching not working properly
It only routing to the first endpoint when the destinationSubnets match if I provide multi destinationSubnets and route destination
Version
istioctl version
client version: 1.24.1
control plane version: 1.24.1
data plane version: 1.24.1 (6 proxies)

kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.31.1
Kustomize Version: v4.5.7
Server Version: v1.31.1

Additional Information
I have a Gateway like this:
apiVersion: networking.istio.io/v1
kind: Gateway
metadata:
  name: tcp-gateway
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: tcp
      number: 8999
      protocol: TCP

And Virtual Service:
apiVersion: networking.istio.io/v1
kind: VirtualService
metadata:
  name: tcp-routing-1
  namespace: istio-system
spec:
  gateways:
  - tcp-gateway
  hosts:
  - '*'
  tcp:
  - match:
    - destinationSubnets:
      - <IP_ADDRESS>
    route:
    - destination:
        host: nginx-service.nginx1.svc.cluster.local
        port:
          number: 80
  - match:
    - destinationSubnets:
      - <IP_ADDRESS>
    route:
    - destination:
        host: nginx-service.nginx2.svc.cluster.local
        port:
          number: 80

But when I request into istio, all the request route to nginx1 service
I want the request into IP <IP_ADDRESS> -> nginx-service.nginx1.svc.cluster.local:80 and request IP <IP_ADDRESS> -> nginx-service.nginx2.svc.cluster.local:80
I dont know where i was wrong
│ [2024-12-19T02:51:00.510Z] "- - -" 0 - - - "-" 74 203 4 - "-" "-" "-" "-" "<IP_ADDRESS>:80" outbound|80||nginx-service.nginx1.svc.cluster.local <IP_ADDRESS>:45894 <IP_ADDRESS>:16443 <IP_ADDRESS>:58418 - -                                                                                │
│ [2024-12-19T02:51:00.662Z] "- - -" 0 - - - "-" 74 203 6 - "-" "-" "-" "-" "<IP_ADDRESS>:80" outbound|80||nginx-service.nginx1.svc.cluster.local <IP_ADDRESS>:45898 <IP_ADDRESS>:16443 <IP_ADDRESS>:34022 - -

Install:
I install using the command: istioctl install --set profile=demo

Bug report:
Target cluster context: bke-hanoi-envoy-test

Running with the following config:

istio-namespace: istio-system
full-secrets: false
timeout (mins): 30
include: {  }
exclude: { Namespaces: kube-node-lease,kube-public,kube-system,local-path-storage }
end-time: 2024-12-23 09:00:04.087628591 +0700 +07

Cluster endpoint: https://5mkb7syoi9z1n9eq.api.hn.bke.bfcplatform.vn
CLI version:
version.BuildInfo{Version:"1.24.1", GitRevision:"5c178358f9c61c50d3d6149a0b05a609a0d7defd", GolangVersion:"go1.23.2", BuildStatus:"Clean", GitTag:"1.24.1"}

The following Istio control plane revisions/versions were found in the cluster:
Revision default:
&version.MeshInfo{version.ServerInfo{Component:"pilot", Revision:"default", Info:version.BuildInfo{Version:"1.24.1", GitRevision:"5c178358f9c61c50d3d6149a0b05a609a0d7defd", GolangVersion:"", BuildStatus:"Clean", GitTag:"1.24.1"}}}

The following proxy revisions/versions were found in the cluster:
Revision default: Versions {1.24.1}

Fetching logs for the following containers:

default/httpbin/httpbin-7b549f7859-5zjrx/httpbin
default/httpbin/httpbin-7b549f7859-5zjrx/istio-proxy
default/nginx0/nginx0-66b5657bbd-bznhl/istio-proxy
default/nginx0/nginx0-66b5657bbd-bznhl/nginx
istio-system/grafana/grafana-6b45c49476-6h64r/grafana
istio-system/istio-egressgateway/istio-egressgateway-84bfcbdd68-7rjwq/istio-proxy
istio-system/istio-ingressgateway/istio-ingressgateway-6f84dc8d4-fzbrx/istio-proxy
istio-system/istiod/istiod-b877844fb-fbv95/discovery
istio-system/jaeger/jaeger-54c44d879f-sq7k6/jaeger
istio-system/kiali/kiali-79b6d98d5d-xpzrw/kiali
istio-system/prometheus/prometheus-6dd9fd5446-fwz4q/prometheus-server
istio-system/prometheus/prometheus-6dd9fd5446-fwz4q/prometheus-server-configmap-reload
nginx1/nginx/nginx-66b5657bbd-4l5h8/istio-proxy
nginx1/nginx/nginx-66b5657bbd-4l5h8/nginx
nginx2/nginx/nginx-66b5657bbd-8c89f/istio-proxy
nginx2/nginx/nginx-66b5657bbd-8c89f/nginx

Fetching Istio control plane information from cluster.

Fetching CNI logs from cluster.

Running Istio analyze on all namespaces and report as below:
Analysis Report:
Warning [IST0133] (EnvoyFilter istio-system/custom-envoy-filter) Schema validation warning: EnvoyFilter exposes internal implementation details that may change at any time. Prefer other APIs if possible, and exercise extreme caution, especially around upgrades.
Warning [IST0133] (EnvoyFilter nginx1/custom-envoy-filter) Schema validation warning: EnvoyFilter exposes internal implementation details that may change at any time. Prefer other APIs if possible, and exercise extreme caution, especially around upgrades.
Warning [IST0133] (EnvoyFilter nginx2/custom-envoy-filter) Schema validation warning: EnvoyFilter exposes internal implementation details that may change at any time. Prefer other APIs if possible, and exercise extreme caution, especially around upgrades.
Info [IST0102] (Namespace kube-node-lease) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-node-lease istio-injection=enabled' to enable it, or 'kubectl label namespace kube-node-lease istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace kube-public) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-public istio-injection=enabled' to enable it, or 'kubectl label namespace kube-public istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace kube-system) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-system istio-injection=enabled' to enable it, or 'kubectl label namespace kube-system istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0118] (Service istio-system/grafana) Port name service (port: 3000, targetPort: 3000) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service istio-system/jaeger-collector) Port name jaeger-collector-grpc (port: 14250, targetPort: 14250) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service istio-system/jaeger-collector) Port name jaeger-collector-http (port: 14268, targetPort: 14268) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kube-system/kube-dns) Port name metrics (port: 9153, targetPort: 9153) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service nginx1/nginx-service) Port name  (port: 80, targetPort: 80) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service nginx2/nginx-service) Port name  (port: 80, targetPort: 80) doesn't follow the naming convention of Istio port.
Info [IST0131] (VirtualService istio-system/tcp-routing-1) VirtualService rule #1 match #1 is not used (duplicate/overlapping match in rule #0).

destinationSubnets only works for sidecars. It doesn't really make sense for Gateways -- in (the vast majority of cases) a gateway has a single IP and serves traffic on that IP.
This constrasts with sidecars, where they serve every possible IP due to the iptables redirection

A new warning in the webhook for this use case would be a good idea to add.

@howardjohn so how is the "right" config to serve my usecase
I am following the docs by gardener https://github.com/gardener/gardener/blob/master/docs/proposals/08-shoot-apiserver-via-sni.md
They said after L4 matching support, I dont need envoy filter like that anymore

This is my except, but now both node are return this is nginx1
@howardjohn

@howardjohn In theory istio gateway can support this case

The use case is fundamentally inverted. The nginx IPs being matched are the source IPs not destination IPs. Istio doesn't have a source IP match.
I wouldn't recommend it, either. Just use a distinct port, SNI, etc to do the matching.


Slow algebra operations

Hi @brainandforce,
Thanks for making this - and sorry about not reacting to it for a long while.
I was testing it out today, but noticed that algebra operations seem quite a bit slower than what I had with SqSMatrix from Crystalline:
using Crystalline: SqSMatrix
using LengthFreeStaticMatrices
using BenchmarkTools

m = rand(3,3)
a = SqSMatrix(m)
b = LSMatrix{3,3}(q)

@btime $a * $a; # 2.700 ns (0 allocations: 0 bytes)
@btime $b * $b; # 412.060 ns (4 allocations: 176 bytes)
@btime $m * m; # 46.714 ns (1 allocation: 128 bytes)

@btime $a + $a; # 2.000 ns (0 allocations: 0 bytes)
@btime $b + $b; # 412.000 ns (4 allocations: 176 bytes)
@btime $m + $m; # 35.915 ns (1 allocation: 128 bytes)

From a quick look at @descend I couldn't immediately figure out why the LSMatrix's performance is tanked though.

Thanks for noting this! I've also been dealing with COVID so I haven't had the energy to look at the codebase until now.
After a bit of inspection, I think the issue arises from the construction of the LSMatrix from a Tuple. This is allocation-free in the case of SMatrix but not for LSMatrix:
julia> n = NTuple{9}(rand(3, 3))
(0.32679312795172377, 0.40409735138671576, 0.5485210832135201, 0.7476844907512854, 0.4914803662663604, 0.6171702976695008, 0.5581075594544184, 0.031936215729606254, 0.6175643815086478)

julia> @benchmark SMatrix{3,3}($n)
BenchmarkTools.Trial: 10000 samples with 1000 evaluations.
 Range (min … max):  2.213 ns … 183.109 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     2.245 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   2.539 ns ±   2.437 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

  █▅▂▅▄▃▄▁▂                                                   ▁
  █████████▅▃▄▄▃▁▃▄▁▃▆▇████▇▇▇█▇█▇▇██▆▇▆▆▆▅▇▆▆▄▅▅▆▄▅▅▄▃▃▅▅▆▆▆ █
  2.21 ns      Histogram: log(frequency) by time      5.21 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

julia> @benchmark LSMatrix{3,3}($n)
BenchmarkTools.Trial: 10000 samples with 186 evaluations.
 Range (min … max):  553.677 ns …  33.971 μs  ┊ GC (min … max): 0.00% … 95.55%
 Time  (median):     654.207 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   769.750 ns ± 713.016 ns  ┊ GC (mean ± σ):  1.94% ±  2.35%

  ▄█▅▅▄▄▃▅▃▃▃▃▂▃▁▃ ▂▁ ▄ ▂▂ ▂  ▁▂  ▃▃ ▁ ▁                        ▂
  ██████████████████████████████▇▇██▇███▇▇▆███▇▇▅▅▅▅▆▄▅▅▄▄▃▅▄▃▄ █
  554 ns        Histogram: log(frequency) by time       1.66 μs <

 Memory estimate: 176 bytes, allocs estimate: 4.

julia> @code_warntype SMatrix{3,3}(n)
MethodInstance for (SMatrix{3, 3})(::NTuple{9, Float64})
  from (::Type{SA})(x::Tuple) where SA<:Union{SHermitianCompact, MArray, SArray, SizedArray} @ StaticArrays ~/.julia/packages/StaticArrays/yXGNL/src/convert.jl:166
Static Parameters
  SA = SMatrix{3, 3}
Arguments
  #self#::Type{SMatrix{3, 3}}
  x::NTuple{9, Float64}
Locals
  SA′::Type{SMatrix{3, 3, Float64}}
Body::SMatrix{3, 3, Float64, 9}
1 ─      nothing
│        (SA′ = StaticArrays.construct_type($(Expr(:static_parameter, 1)), x))
│   %3 = StaticArrays.need_rewrap(SA′::Core.Const(SMatrix{3, 3, Float64}), x)::Core.Const(false)
└──      goto #3 if not %3
2 ─      Core.Const(:(Core.tuple(x)))
│        Core.Const(:((SA′)(%5)))
└──      Core.Const(:(return %6))
3 ┄ %8 = (SA′::Core.Const(SMatrix{3, 3, Float64}))(x)::SMatrix{3, 3, Float64, 9}
└──      return %8

julia> @code_warntype LSMatrix{3,3}(n)
MethodInstance for (SquareLSMatrix{3})(::NTuple{9, Float64})
  from (LSMatrix{M, N})(t::Tuple) where {M, N} @ LengthFreeStaticMatrices ~/git/LengthFreeStaticMatrices.jl/src/LengthFreeStaticMatrices.jl:73
Static Parameters
  M = 3
  N = 3
Arguments
  #self#::Type{SquareLSMatrix{3}}
  t::NTuple{9, Float64}
Body::SquareLSMatrix{3, Float64}
1 ─ %1 = LengthFreeStaticMatrices.LSMatrix::Core.Const(LSMatrix)
│   %2 = $(Expr(:static_parameter, 1))::Core.Const(3)
│   %3 = $(Expr(:static_parameter, 2))::Core.Const(3)
│   %4 = LengthFreeStaticMatrices.promote_type::Core.Const(promote_type)
│   %5 = Base.broadcasted(LengthFreeStaticMatrices.typeof, t)::Base.Broadcast.Broadcasted{Base.Broadcast.Style{Tuple}, Nothing, typeof(typeof), Tuple{NTuple{9, Float64}}}
│   %6 = Base.materialize(%5)::Core.Const((Float64, Float64, Float64, Float64, Float64, Float64, Float64, Float64, Float64))
│   %7 = Core._apply_iterate(Base.iterate, %4, %6)::Core.Const(Float64)
│   %8 = Core.apply_type(%1, %2, %3, %7)::Core.Const(SquareLSMatrix{3, Float64})
│   %9 = (%8)(t)::SquareLSMatrix{3, Float64}
└──      return %9

This call has some cruft which I think doesn't need to be there. I expect this function to be slower than its SMatrix counterpart, but the calls to promote_type, Base.broadcasted, and Base.materialize may be the problem.

The problem is likely in the function LengthFreeStaticMatrices.nest_tuple. I've written this function very generically, but since this package is only going to deal with matrices, I don't have to worry about nesting tuples to arbitrary depth, so I think I can write a significantly better implementation.


trian CUB-200-2011 error

hi,can you help me? Thank you very much.
Traceback (most recent call last):
File "main.py", line 580, in
main()
File "main.py", line 571, in main
trainer.train()
File "main.py", line 84, in train
for iteration, batch in enumerate(self.data_loader'train'):
File "/home/wuchenxi/Desktop/DPGN-master/venv/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 582, in next
return self._process_next_batch(batch)
File "/home/wuchenxi/Desktop/DPGN-master/venv/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 608, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
ValueError: Traceback (most recent call last):
File "/home/wuchenxi/Desktop/DPGN-master/venv/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 99, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/wuchenxi/Desktop/DPGN-master/venv/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 99, in
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/wuchenxi/Desktop/DPGN-master/venv/lib/python3.7/site-packages/torchnet/dataset/listdataset.py", line 54, in getitem
return self.load(self.list[idx])
File "/home/wuchenxi/Desktop/DPGN-master/dataloader.py", line 285, in load_function
support_data, support_label, query_data, query_label = self.get_task_batch()
File "/home/wuchenxi/Desktop/DPGN-master/dataloader.py", line 259, in get_task_batch
task_class_list = random.sample(self.full_class_list, self.num_ways)
File "/usr/local/python3.7.5/lib/python3.7/random.py", line 321, in sample
raise ValueError("Sample larger than population or is negative")
ValueError: Sample larger than population or is negative

hi, successhaha
The log says "ValueError: Sample larger than population or is negative". Please check the value of  self.full_class_list and self.num_ways in  the task_class_list = random.sample(self.full_class_list, self.num_ways) .


Add script to run Rollouts tests against gitops-operator repo

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR adds a new shell script which can be run to verify the Argo Rollouts functionality within gitops-operator.

It runs the (cluster-scoped) E2E tests of the Argo Rollouts operator
It runs the upstream E2E tests from the argo-rollouts repo

This PR only adds the scripts to the repo, so they can be called manually. We can add integration to CI in a separate PR.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

/test v4.12-kuttl-sequential

Thanks @chetan-rns!


Update passwords.php

Change 6 to 8 required symbols of password.

Laravel 6.x and 7.x excluded the use of this key.
The key has also been removed from this package: db23833785bb4e675ed1d06582f375ccbb8d4e6a and #1215

Thank you


Please apply this pull request

Adding a language

[ ] The code displays "Hello World" (tio.run may help for testing)
[ ] I have no association with the language
[ ] There are no copyright issues with this code
[ ] The language has not been added prior to this pull request
[ ] I have updated the README

Link to programming language:

Please ignore this request.


Add more obvious notice on citation in README

Description
Add more obvious notice on how to cite/highlight TeachOpenCADD usage at the top of README.
ToDos

[ ] Add notice before TOC: "If you use TeachOpenCADD in a publication, please cite us! If you use TeachOpenCADD in class, please include a link back to our repository. In any case, please star (and tell your students to star) those repositories you consider useful for your learning/teaching activities."
[ ] Move funding paragraph from "Citation" section to a new "Funding" section.
[ ] Update/add citation links/bibtex

Questions
None.
Status

[ ] Ready to go

Closing this PR, since I branched of dominiquesydow/master and not volkamerlab/master as intended.


Fix file path

Fix path of yaml file in oc create commands which are used to deploy operator

Deployment instructions have changed.
/close


Enable operating in webworker extension host

Hello from the VS Code team! 👋
I'm a big fan of your work on this extension!
I took a look at what it'd take to get it running in a browser via webworker extension host used by places like github.dev more info.
In this case, webpack is able to shim some (but not all) node imports to work in a browser, with the biggest exception being fs. Here I solve that by shimming fs.readFileSync in the web build with an webpack-inlined import of the webview_base.html file (all other accesses return the empty string). This worked surprisingly well and makes the extension fully functional for single-file shaders on the desktop webworker extension host, but there are still some issues with loading resources when running in an actual browser.
Imports still don't work, but resolving that is a larger change due to them using the sync variants of the node's fs, which are not implemented on vscode.workspace.fs.
If this is something you're interested in supporting I'd love to chat more on the finer points of this conversion! Otherwise no worries I can close this out.

Yes, that makes a lot of sense  :D
I wouldn't be surprised if there are other places in our code that make assumptions about this kinda stuff. We'll see when testing it a bit.

Yes, one bigger sticking point is in loading textures. Running thorough some of the demos, it seems even the textures that simply reference https URI's cause node fs.existsSync and readdirSync calls to be executed, which end up just throwing as I only shimmed readFileSync so far. Reading relative paths also needs some work. But a good number of the demos also work perfectly fine! One import that does work well is self.

@JacksonKearl I'm sorry for not seeing your message, yes ofc you can do whatever you want. The license is permissive so you do you. I really appreciate your work. And I really hope I'll find the time and energy to take a look at it too.

Posted "Shader Toy (Web)" to the extension marketplace. It's currently designed for web use only and will not activate if it finds the normal shader toy installation active. https://marketplace.visualstudio.com/items?itemName=jakearl.shader-toy-web

Hi @JacksonKearl,
I'm hoping to try this a bit over the holidays. Is there anything I should be looking at in particular?
I recall you mentioned that the filesystem stuff was not working, but I am not sure I follow whether that makes sense to support on the web-version of VSCode or not.

@Malacath-92 hey sorry I was offline for the holidays. I did go through and categorize the demos that work on web versus those that do not, https://github.com/JacksonKearl/shader-toy/tree/master/demos/web-ready. The central theme with the ones broken tends to be imports of resources, which may be 100% not possible in some cases due to CORS issues, but in other cases (for instance local imports), it should be theoretically possible.

Hi @Malacath-92, I was wondering if you might have any new thoughts on this? We're happy to discuss if you have questions or feedback. Thank you!

Sorry @bamurtaugh I've still been really bad at doing this. I tried once to setup a testing environment for this but failed, I should try again. It always ends up falling lower on my priority list, but at this point I need to stop making excuses. I will give it another try this weekend and if I fail I will look for help.
My main questions at this point:

how likely will it be that we can do local imports but I will have to guess that I will, Jackson said it would be theoretically possible but I myself am probably not familiar enough with what it would take
my understand is that the extension could be made to function for both web and desktop in one (when we merge this ofc, I know in the current setup is necessary to have two extensions)

No need to answer these right now, I need to hold up my end of the bargain first  😅

I managed to configure stuff today, my issues were very banal last time. But I am now struggling to debug this extension as the webview hosting VSCode window crashes whenever I hit a breakpoint. I will take a closer look later or tomorrow. But maybe one of you two has an idea what is going?

Took another quick look and from what I can see we will have to wrap all file reads via vscode.workspace.fs which only supports an async interface. So I guess we'd have to do the long overdue and actually port all file reads to use the async fs interface. Correct me if I am wrong about that, for example if there is some workaround to use the async interface in a sync call.

cc @tanhakabir @aeschli if you have any thoughts on the above comment.

I worked on two commits on-top of this PR, it should be possible to just cherry-pick those. I can later do cleanup when we merge this, we don't have to drag this PR out more than I have already done. The commits in question are

https://github.com/Malacath-92/shader-toy/commit/d63678cc4ad35913d2ee37edf31c8f4c8ee85f67
https://github.com/Malacath-92/shader-toy/commit/d4f2ef27bf8a26c6af805a68ddf5c11e707fd302

From my testing everything works other than remote images via URLs. It's also technically unnecessary at this point to shim our own fs in, but again this is cleanup that I could do later.
The last question remaining for me is whether at the state this is at right now, if we deploy the extension, will it work both in desktop and web or is there some additional work we need to do?

To me this is still not clear, I waited for input from Jackson so far, but not sure if it will come (no judgement) Right now as this stands the extension works in web and desktop but there are still features that are broken on both. So some mechanism is still needed to distinguish web or desktop in order to make said features work on desktop while they don't work on web.
Plus the work I did in those two commits I linked needs to be integrated into this PR. Afaik I do not have the required permissions to do that myself.

@JacksonKearl it's been a while. Are you eventually coming back to this or should I just close the PR and we keep two separate extensions?

Closing due to inactivity


GITHUB_LOGIN is missing a value when starting local gRPC server

Docker-compose needs two args:
args:
- GITHUB_LOGIN=${GITHUB_LOGIN:?}
- GITHUB_TOKEN=${GITHUB_TOKEN:?}
And there is no .env file

Added these as vars in the build script.


Refactor get one call weather

Codecov Report

Merging #240 (bc7d33d) into main (9aec054) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   91.96%   91.97%
=======================================
  Files          10       10
  Lines         846      847    +1
=======================================
+ Hits          778      779    +1
  Misses         68       68

Impacted Files
Coverage Δ

weather_command/_weather.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


python311Packages.asyncsleepiq: 1.3.5 -> 1.3.6

Changelog: https://github.com/kbickar/asyncsleepiq/releases/tag/v1.3.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251328 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.sleepiq
python310Packages.asyncsleepiq
python310Packages.asyncsleepiq.dist
python311Packages.asyncsleepiq
python311Packages.asyncsleepiq.dist


Added bucket delete support, moved AWS hash generation into separate classes

I wasn't able to test this since I couldn't pull sirius test kernel JAR but it should work ok - it did in the 2.0 version :)

Thanks for your effort! It would be great if you could fix the points i commented on (minor stuff anyway...). Also you now should be able to pull the tests.jar for sirius-kernel as it is in maven central. Just out of curiosity - could you give it a try?

My pleasure :) Yeah, sorry, IntelliJ used the settings from my current
project and it never occurred to me to ask about coding conventions
beforehand. Thanks for pushing the library, I'll let you know how the
testing went.
On Mon, 8 Jun 2015 08:53 Andreas Haufler<EMAIL_ADDRESS>wrote:

Thanks for your effort! It would be great if you could fix the points i
commented on (minor stuff anyway...). Also you now should be able to pull
the tests.jar for sirius-kernel as it is in maven central. Just out of
curiosity - could you give it a try?
—
Reply to this email directly or view it on GitHub
https://github.com/scireum/s3ninja/pull/22#issuecomment-109882802.

I made the required changes (except the one for removing StringUtils - currently, Strings has no methods that provide the required functionality) and I've also included Spock tests in Maven build process by adding a few plugins. The delete bucket functionality is working okay and I've added a Spock test to confirm.

Sorry...I somehow missed the GitHub notification of your last change. Its now merged, thanks again for your contribution :-)


ISPN-6243 Query tests involving topology change always fail

https://issues.jboss.org/browse/ISPN-6243

integrated! thanks @gustavonalle !


batch get_comment_details

get_comment_detials should optionally (but by default) divide the input vector into batches 5k, updating an comment_details_temp.rda file every 5k

i.e., save(comment_details_temp.rda) inside the loop and then it gets deleted if the loop finishes and returns the full results

Saving batches to a temporary data file was working, but seems to not be working anymore -- assigned to me so I can return to this.


Fix edit itinerary to 0 people bug

Codecov Report
Base: 48.26% // Head: 48.28% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (b81d29d) compared to base (119c695).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     48.26%   48.28%   +0.02%
- Complexity      488      489       +1
============================================
  Files           111      111
  Lines          2362     2365       +3
  Branches        271      272       +1
============================================
+ Hits           1140     1142       +2
  Misses         1139     1139
- Partials         83       84       +1

Impacted Files
Coverage Δ

...va/seedu/waddle/logic/parser/AddCommandParser.java
72.72% <0.00%> (ø)

...main/java/seedu/waddle/model/itinerary/People.java
76.92% <75.00%> (-3.08%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Additional Color Support

This is a feature request to support colors of Amber and UV.
Most of my DJ fixtures support Amber, it is one of my pre-requisites for a light actually, helps with the color tone of some hues.

Ok, cool. One of my favorite soft washes is a 50/50 mix of Blue & Amber. It makes a really nice soft lavender which is great for spotlight dances with white spots on the B&G.
UV would definitely be industry standard, but I kind of figured that is what Black meant.


Allow for S3 FileStorage

[ ] Create a FileStorage ComponentConnector
[ ] Allow Connection to S3 to store files

Configuration of a component locally or in FileStorage (ComponentConnector: FileStorageComponentConnector, only one per system, in the init we mount and maybe we don't 'mount' but just sync / dowload with a path for this connector )

S3FileStorageComponent or BaseFileStorageComponent


How to add an addon command?

I'm working on knative add on and would like to add the kn CLI command like “microk8s kn”
I'm able to download clip binary to SNAP bin dir, but the command doesn't show as available
I followed the examples of cillium and linked, but luck getting to work

Hi @csantanapr, apologies, I missed the notification on this, I see you figured it out already for #5. #70 adds documentation for this on the HACKING.md file.
Thanks for bringing attention to it!


merge from arlac77/template-github,arlac77/template-kronos-module

package.json

fix(engines): add >=13.13.0 remove >=13.12.0 (engines.node)

.travis.yml

chore(travis): (jobs.include)
chore(travis): add 13.13.0 remove 13.12.0 (jobs.include.node_js)

Codecov Report

Merging #1290 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1290   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           28        28
  Branches         1         1
=========================================
  Hits            28        28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831f4d1...f7d6da2. Read the comment docs.

:tada: This PR is included in version 3.0.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Driver is not thread safe

Hi,
I'm a developer on the Open Lighting Project ( https://github.com/OpenLightingProject/ola ) and we'd like to add support for your devices. However the code provided isn't thread safe since there is no locking provided around the output TDMXArray. This will lead to corrupted DMX frames.
Are there plans to provide a thread safe driver?

Closing this, because this driver is intended to keep the api of the legacy driver. I'll probably make a new driver with a better api.


defineNuxtConfig is not defined

defineNuxtConfig is not defined

Did you disable auto imports? If so, you'll want to disable auto imports in unocss too.

Duplicate of #2018


Requested but not Supported by System (L2/MBA)

Having trouble using CAT with the L2.
System Information:
[uname -R]
4.10.0-041000-generic
[cpuinfo]
processor       : 47
vendor_id       : GenuineIntel
cpu family      : 6
model           : 79
model name      : Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz
stepping        : 1
[/etc/os-release]
NAME="Ubuntu"
VERSION="14.04.5 LTS, Trusty Tahr"
ID=ubuntu
ID_LIKE=debian
When using pqos to do L2 or MBA allocation
sudo pqos -e l2:2=0x1
I get this error:
Socket 0 MBA COS1 - FAILED!
Allocation configuration error!
L2ID 0 L2CA COS2 - FAILED!
Allocation configuration error!
Tried same thing with RDTSET
sudo rdtset -t 'l2=0xf;cpu=2' -c 2 sleep 10
got this error:
Allocation: L2CA requested but not supported by system!
Requested configuration is not valid!
Allocation: Failed to configure allocation!
Tried with resctrl
echo "L2:0=1;1=1" > COS1/schemata
error: bash: echo: write error: Invalid argument
I am able to do L3 +CAT using all three methods but L2 and MBA allocation are erroring out. Am I allocating these incorrectly? Thanks.

Hi shelbyt,
Thanks for getting in touch.
Unfortunately the error message you are receiving is correct.
Allocation: L2CA requested but not supported by system!
Your Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz does not support L2 or MBA CAT.
It does support L3 CAT and CDP.
Sorry about this.
Best,
Aaron

Thanks for the fast response Aaron. Where can I find what capabilities are supported by which processor? The main wiki for CMT says that CAT is supported by E5 v4 but not which models specifically.

Hi shelbyt,
I have just read the wiki and have seen it has not been updated for L2!
Apologies for this, we will fix this ASAP.
To answer your question the Intel (R) Atom C3000 series support L2 CAT
https://ark.intel.com/products/series/97941/Intel-Atom-Processor-C3000-Product-Family?q=atom c300
As for MBA, no current system is available with MBA CAT.
We programmed how to do it based on specifications found in the software developers manual:
https://software.intel.com/en-us/articles/intel-sdm
I hope this helps clear things up,
Let me know if I can provide any more information.
Best,
Aaron

"To clarify, L3 CMT, L3 CAT, MBM and CDP is available on all Intel (R) Xeon E5 v4 products." - and Intel(R) Xeon(R) E7 v4 porducts, too.

Hi @ahetheri ,
I'm just wondering if you found which systems on ark.intel.com support MBA?
Thanks,
Meng

@PennPanda MBA will be present in Skylake servers according to Fenghua Yu

Hi @shelbyt
Can you point to the location where Fenghua provided this information please?
Best,
Aaron

@ahetheri  Talked with him over email.

Since the above information comes from private conversation and it is not confirmed via any other sources I have no choice but delete the above responses.

Closing this issue. Please reopen if needed.
Regards,
Marcel

Can anyone give me the information about which specific model supports MBA?

Please refer to the Intel(R) RDT hardware support table in our README which outlines features that are supported on specific models.
Regards,
Marcel

Hi Jeongseob,
Apologies for the delayed response.
All Intel(R) Xeon(R) Scalable Processors Bronze/Silver/Gold support MBA.
Note:
Please find errata for Intel(R) Xeon(R) Processor Scalable Family at:
https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-scalable-spec-update.pdf?asset=14615
Regards,
Marcel


NO-JIRA: Fix Issue 611

Hi, just trying it out if I can fix a recent issue: https://github.com/MyPureCloud/terraform-provider-genesyscloud/issues/611
Problem: The phone number contact can be set just by using display property. The issue is it's auto-formatted after creation/update of the contact to this kind of format: +1<PHONE_NUMBER> regardless of input format.
Solution: Add a DiffSuppressFunc that will compare the phone numbers after E164-formatting them.

Also, changes to the makefile because some indentation are spaces. -> converted them to tabs


refactor(tree): Remove parameter from abstract methods in LazyEntity

Description
Extracting part of this proposal (which became https://github.com/microsoft/FluidFramework/pull/20286) into its own PR for independent review.
Removes a parameter in a few abstract methods in the abstract class LazyEntity. Concrete classes already have access to what the parameter is passing through a symbol-keyed property in the abstract class, so this is technically doable... but I'm not sure I like it. Particularly the fact that the abstract class actually makes a call to one of the abstract methods, which guarantees that the passed parameter will be the symbol-keyed property owned by it. After the change, concrete classes can technically provide something else (although they don't in this PR), but I'm not familiar enough with this code to know if that's a potential bug, or a feature.
Reviewer Guidance
The review process is outlined on this wiki page.

Looks good to me, but as the original author maybe we want a different or additional reviewer.


Logout not working on iOs

Hi, I'm currently facing an issue with logout on iOs 12.
Everything works well, but even if I call logOut method on LoginManager instance, my user is always logged in.

OS: iOs 12
FacebookComponents Version: <IP_ADDRESS>

I see current token and profile (in my app context) are null after logout, but Safari's session still has the previous user.
private LoginManager facebookLoginManager = new LoginManager();
...
...
facebookLoginManager.LogOut();
facebookLoginManager.LogIn(facebookPermissions, this, OnFacebookLoginHandler);

Let me know if you need further information.
Thank you very much

@christianascone Thanks for reporting this. Can you provide a test case of this, please? Thanks in advance!

@SotoiGhost Thank you for your reply.
Currently I am able to login, but after I call logout and login methods again it always stay logged with previous user, so the only way to change user is using Safari.
Is there anything specific I can provide which may help you more?
Thank you

@christianascone Does this error happen on simulator or device?

I have only tried on devices, with ios 12 and ios 13.

I tried in the simulator and the error is happening
I was using version 5.12.0
Not sure if there are some useful information here https://github.com/facebookarchive/facebook-swift-sdk/issues/215


accordion optional props

Closes #768
📑 Description
Since all the Accordion props have default values them should be optional in type descryptor.
Status

[] Not Completed
[x] Completed

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] I have checked the page with https://validator.unl.edu/
[ ] All the tests have passed
[x] My pull request is based on the latest commit (not the npm version).

Completely agree. PR good to go.


Make registry configurable

Add mechanism for passing global configurations
The biggest change in this commit is the addition of src/config.py, which acts as a
singleton module to pass global configs around SPRAS. When the Snakefile is run, it
uses it's magically available config to instantiate the config object in the config
module. After instantiation, other modules can import src.config as config, which allows
them to access various config parameters. For example, to access the container framework,
you can do:
import src.config as config
framework = config.config.framework

In addition to modularizing configuration, I also added the ability to specify container
registries and owners in the config. A full container name looks like
docker.io/reedcompbio/pathlinker:latest. The config option considers docker.io the base_url,
reedcompbio the owner, and then pathlinker will be hardcoded by that method. Lacking in this
implementation is the ability to specify exactly what tag to run each PRM against. With the new
config module, that should be relatively simple to add.
As far as implentation choices, since the config module makes various values globally available,
I decided to stop passing some values like singularity down through nested levels of function
calls, and instead get those values close to where they're needed. The only place this was obviously
not the clean way to do this was in the tests -- for now, I toggle config.config.framework in the
places where we need to test singularity.

@agitter This wound up being a bit more like open heart surgery than I anticipated. Let's discuss the approach and decide if we like doing things this way or not.

@agitter, I think I've covered all of the things we discussed in our last meeting, and this should more or less be ready for a final review.

Merging #126 created merge conflicts in this pull request


Client for Cud?

Maybe you can add plugin for CudaText too? Python API.

Interesting idea. How popular is this editor?
We’ll add it to our backlog and will review and handle it by priority.

If anyone wants to help here:
https://github.com/codota/TabNine/blob/master/HowToWriteAClient.md


Need reason and method for why Create Dev Drive option is greyed out

Windows 11 Enterprise 22631.2361 (23H2 release)
64GB RAM
6TB Drive
Option shows greyed out:

Please detail why so users can use the feature.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bfda7965-bc34-ab88-fdc9-efef4a5d8a9e
Version Independent ID: bfda7965-bc34-ab88-fdc9-efef4a5d8a9e
Content: Set up a Dev Drive on Windows 11
Content Source: hub/dev-drive/index.md
Product: dev-environment
Technology: windows-devhome
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

Ok, so I re-read the page and found the bit about adding an intune policy.
It was that.


tests fails, server implemented

Co-authored-by: heojay0309<EMAIL_ADDRESS>Co-authored-by: Lzzhengyi<EMAIL_ADDRESS>Co-authored-by: leolew97<EMAIL_ADDRESS>Co-authored-by: thedrewery<EMAIL_ADDRESS>


Alternative environment hash option

First off, great module, this works flawlessly with my dev environment 😄
The issue I'm having is getting it to work on our CI server, as the mtimes of the node_modules directory and package.json etc will always change, hence this plugin won't work on a CI server. Calculating the md5 hash of every file in the node_modules directory isn't feasible for performance reasons, however now that yarn exists, you can just compute a hash of the yarn.lock file, plus package.json and the webpack config file contents, which should give you a performant and accurate environment hash (providing you use yarn to install your dependencies)
There are 2 possible options I propose to handle this:

add a contentsHash: true (there's probably a better name) option to the environmentPaths config that will calculate the md5 of each listed files contents, rather than using the mtime of each file.
add an alternative environmentHash option that accepts a function that returns the environment hash. The user can then use whatever logic they prefer to calculate the environment hash.

Opening this up for discussion first before I start building a pull request for this, let me know what you'd prefer 😄

+1 to this.  I ran into the same issue, but solved it with a workaround.

That's awesome, thanks so much for implementing this! 😄


Rancher still not mysql galera cluster compatible

Rancher versions:
rancher/server:
Docker version: (docker version,docker info preferred)
1.12.6
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
RancherOS 4.9.24-rancher
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher, External DB
Percona XtraDB GALERA Cluster 5.7
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cannot start rancher server so no environmnt can be made
Steps to Reproduce:
Create 3 node mysql galera cluster as recomended by rancher for resillience.
"For true HA, a replicated MySQL database with proper backups is recommended. Using Galera and forcing writes to a single node, due to transaction locks, would be an alternative."
https://www.percona.com/software/mysql-database/percona-xtradb-cluster
Results:
Err_empty_response from rancher master and nothing happends
rancher database error.txt

The log is 10mb of basically cattle.DATABASECHANGELOG [needs a] explicit primary key with pxc_strict_mode = ENFORCING or MASTER.  Have you tried adding one (or reducing strict mode)?

PXC_STRICT_MODE has been tried with both ENCORFING & MASTER as well as scaling the cluster down to 1 node instead of 3.
If i set it to permissive the whole cluster b0rks after a while as rancher is doing some non cluster safe table lockings it seems.
Also all writes are directed to a single node as per Rancher instructions

Rancher needs to provide a working example of a mysql HA setup certified to work with their product or remove the instructions regarding it.

Galera and XtraDB are not the same thing.  Galera has no such strict mode and works fine, and XtraDB is mentioned nowhere in our docs.

that is correct. strict mode ensures non supported operations are blocked. like the ones you are doing.
https://www.percona.com/doc/percona-xtradb-cluster/LATEST/features/pxc-strict-mode.html
Percona XtraDB Cluster is an active/active high availability and high scalability open source solution for MySQL® clustering. It integrates Percona Server and Percona XtraBackup with the Codership Galera library of MySQL high availability solutions in a single package
Please provide a Rancher certified solution for mysql HA with hot-standby / active failover
Also please update the docs on your homepage to mention that Percona Cluster is NOT supported as it's a very popular product to create HA mysql clusters

Merging this into https://github.com/rancher/rancher/issues/9329, if you are able to test the proposed solution, that would help.


Animation cannot be done infinite times

Animation cannot be repeated or done infinite times. If someone wants t o repeat same animation again and again, it cannot be done

It's not the purpose of this library @varunsahni003 Animation can only be repeated once scrolling back up, and down again, and so on.


.all doesn's fetch all SObjects

Hello,
I'm dealing with a salesforce setup with more than 2k Accounts, but I'm not able to fetch all of these.
Salesforce::Account.all.count
# => 1000

Thanks,
Hans

It makes sense that it won't otherwise the gem would be loading way to many objects into memory so the gem implements paging for you. Store the result of Salesforce::Account.all which will be a Collection class instance (defined by the gem). From there you can call instance methods to determine if a next or previous page exists and if so to retrieve it. Select the Collection class from the docs: http://rubydoc.info/github/heroku/databasedotcom/master/frames. I haven't tried this but from digging around the source this is what it should be doing. Hope it helps.

Hello Javier,
thanks for your answer! You are totally right.
accounts = Salesforce::Account.all
accounts.class
# => Databasedotcom::Collection
accounts.next_page?
# => true

I know that salesforce returns paginated results, but I somehow expected that to be handled by the gem. Because memory consumption cannot be the reason, perhaps its performance.

So how do we get all the results i mean all accout susing this gem . Can some logic be used to do that

I guess it could work like this(not tested):
accounts =  Salesforce::Account.all
while accunts.next_page?
  accounts += accounts.next_page
end

Collections are paginated. See the README for details.
On Thursday, February 23, 2012, yatishmehta27 wrote:

So how do we get all the results i mean all accout susing this gem . Can
some logic be used to do that

Reply to this email directly or view it on GitHub:
https://github.com/heroku/databasedotcom/issues/45#issuecomment-4137367

The above code works only for one iteration. accounts gets converted to Array object by accounts += accounts.next_page. How do we solve this issue?

@bhushanlodha I edited my code snippet. Its not tested and should only provide a direction.

account_class = client.materialize("Account")
accounts_with_pages=[]
as=account_class.all
accounts_with_pages<<as
while as.next_page?
as=as.next_page
accounts_with_pages<<as
end
accounts_with_pages is the array of collections

@i0rek I edited your code snippet to update accounts object. It is tested and works like charm
sobjects = accounts.dup.to_a
while accounts.next_page?
sobjects += accounts.next_page
accounts = accounts.next_page
end

pagination is common when dealing with api data.
@lareb that seems to be functioning as intended. there is no next page because there are less than 1000 records.
for googlers looking for a pagination solution, try the following code example, replacing Thing with your desired sobject class name:
things = Thing.all
while things.any? do
  things.each do |thing|
    # DO SOMETHING CRAZY
  end
  things = (things.next_page? ? things.next_page : []) # if there is no next page, set the variable to an empty array to stop the while loop
end

if merged, PR #170 will add this information to the README.

When there is no more data, next_page returns an empty collection.
So we can skip the next_page? check...
records = Account.all
until records.empty? do
  records.each do |account|
    # Use account
  end
  records = records.next_page
end


Corne v3 case files

Hi, I have been able to find the the svg files for the corne's plates, but I don't know where to find the dimensions for them so I can cut out my own acrylic case. Could you add the dimensions and what files you used to make your own to the guide.

Hey, I sent the files to my local laser cut shop, and without any questions, it sent me the cases.
I suggest opening an issue in the official keyboard repository.
https://github.com/foostan/crkbd

@MasonJohnHawver42 can I close this issue?


arch/xtensa: add support for capture driver on ESP32 and ESP32|S3|

Summary
This PR adds support for the capture driver on Xtensa ESP32 and ESP32S3. It is based on the MCPWM peripheral.
The basic functionality of MCPWM capture is to record the time when any pulse edge of the capture signal turns active.
Implmentation comments:

Having only one measurement is not sufficient to estimate frequency or duty cycle, because you still need at least one repetition of the pulse. In this case, 4 pulses are expected before a calculation is made.
Up to 3 channels are possible (/dev/capture0, 1 and 2) and they are independent.

Impact
Allows use of the capture driver.
Testing
Tested on ESP32, ESP32S3 with the capture example using two ESP boards.
Also tested from 20 to 2000 Hz with varying duty cycle.

Hi @fdcavalcanti nice work! I think you will need to refresh the configs, seems it is failing on CI

Hey @acassis! Sorry I don't see what the issue is. I'm looking over the logs and I can't find what failed during Xtensa build.

@fdcavalcanti try it:
$ ./tools/refresh.sh --silent chip:esp32
$ ./tools/refresh.sh --silent chip:esp32s2
$ ./tools/refresh.sh --silent chip:esp32s3
Then execute "git diff" to see which defconfig were modified


Remove opinionated lock on golang

Hi @johnbellone,
The lock on golang is too opinionated, folks should be able to lock themselves (or default to unlocked) in my opinion.
Thanks in advance

:+1:

@johnbellone any chance to get a patch bump for this?


fix cert warm failure with tests

https://github.com/istio/istio/issues/33146
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test release-notes_istio

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test release-notes_istio

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test release-notes_istio

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

gencheck_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

gencheck_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test gencheck_istio

release-notes_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

release-notes_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test release-notes_istio

gencheck_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test lint_istio

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

release-notes_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test release-notes_istio

gencheck_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0b9a294eec0861ad98d900f9420bf3ea05905a2d
link
/test unit-tests_istio

release-notes_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test release-notes_istio

gencheck_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test release-notes_istio

gencheck_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test lint_istio

unit-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test lint_istio

unit-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test unit-tests_istio

gencheck_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

unit-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test unit-tests_istio

gencheck_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test gencheck_istio

lint_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
9c60d56f578b9d0b6c2d49230df3334860bf8763
link
/test integ-telemetry-mc-k8s-tests_istio

gencheck_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test gencheck_istio

lint_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test lint_istio

unit-tests_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
d4f7790861f2f9cc543177253341af01a84fc8c3
link
/test unit-tests_istio

lint_istio
ebeaf560ab18baaab32942819423b0624fe64b50
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ebeaf560ab18baaab32942819423b0624fe64b50
link
/test lint_istio

unit-tests_istio
ebeaf560ab18baaab32942819423b0624fe64b50
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fa810d99895e8d111a681c6ea81836786845b05c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5ebc8ef9bb078b593a6495dc85770093e41b5e3e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c435bdfd0325ac13b5f177f2bc5f42c01a695142
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3a9b4145d07cc03c50d6435715cc0173f3fbd473
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Some basic question regarding yarn: passing arguments

Hello,
it's me again with another basic question : )
Currently, running
yarn start
runs a process of index.ts, which is prompting for email and password input from the console.
Would it be possible to pass these parameters (and possibly others, like wikifolio ID) via flags to the call, rather than being prompted to enter them? Something along the lines of
yarn start --email<EMAIL_ADDRESS>--password verySecretPassword
would be convenient to have (with an optional keyboard prompt if no flags are passed).
However, since I don't know enough of yarn and typescript I'm not certain if and how this would be feasible.
Cheers

I've implemented only a very basic arguments feature, because I don't want to pollute the repository with 3rd-party libs which would've been required otherwise and might pose a security threat. We're already on very sensitive grounds with these plaintext credentials.
yarn start<EMAIL_ADDRESS>myPa$$w0rd

I've implemented only a very basic arguments feature, because I don't want to pollute the repository with 3rd-party libs which would've been required otherwise and might pose a security threat. We're already on very sensitive grounds with these plaintext credentials.
yarn start<EMAIL_ADDRESS>myPa$$w0rd


Add payload generation to CLI.

As above.

Reworking this to have some of the sample scripts incorporated into the CLI.


Unexpected API Call Triggered by Cancel Button on Login Screen

Description:
On the login screen, clicking the "Cancel" button causes the "Next" button to display a loading state momentarily before returning to the previous screen. However, this behavior triggers an API call for login with empty details, which is unexpected and unnecessary.
Expected Behavior
When the user clicks the "Cancel" button, they should be immediately redirected back to the previous screen without triggering any API calls.
Steps to Reproduce

Navigate to the login screen.
Press the "Cancel" button.
Observe that the "Next" button briefly shows a loading state.

Screenshot

This issue results in an unnecessary API call upon clicking the "Cancel" button, which should be addressed to improve the user experience.If this issue seems valid, then I am happy to contribute.

also a good issue to tackle


MAA control plane 2021-06-01

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? October, 2022
When do you expect to publish the swagger? October, 2022
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The listed breaking change does not make much sense:
Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-attestation - 2.0.0b1
Diff with approved:
+	Model AttestationServiceCreationSpecificParams no longer has parameter attestation_policy
Diff with base:
+	Model AttestationServiceCreationSpecificParams no longer has parameter attestation_policy

Could someone from the review board kindly decipher this error message and advice on the potential fixes or the exception retrieval process?

closed and opened two new instead of this one:

https://github.com/Azure/azure-rest-api-specs/pull/24125
https://github.com/Azure/azure-rest-api-specs/pull/24124


data augmentation

Hey - one quick question. I scanned the code a bit but could not find any data augmentation on cifar 10 / cifar 100. Is that correct? The results reported in the paper on the cifar 10/100 task are achieved by training on the cifar 10 / cifar 100 without data augmentation?
Many thanks!

Yes, that's correct. We did not use any data augmentation.
On 02/05/2019 12:46, Johannes Oswald wrote:

Hey - one quick question. I scanned the code a bit but could not find
any data augmentation on cifar 10 / cifar 100. Is that correct? The
results reported in the paper on the cifar 10/100 task are achieved by
training on the cifar 10 / cifar 100 without data augmentation?
Many thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ganguli-lab/pathint/issues/4, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLI2XAHHKLEWS4QXW2574TPTLIB5ANCNFSM4HJ5TJRQ.

Thank you for the quick reply!


clarify connectivity works for both ios and android

cc @mehmetf @mravn-google

I think this is correct :)


Technical University of Gdansk

Technical University of Gdansk
Official Website: https://pg.edu.pl/en
Faculty of Electronics, Telecommunications and Informatics : https://eti.pg.edu.pl/en
Students email: https://cui.pg.edu.pl/en/available-services/electronic-mail

@pettigrew1 I am sorry, the domain pg.edu.pl is removed from our trusted domains list because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.5 to before v5.4.181",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2f4ce5ec1d447beb42143a9653716a2ab025161e",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=aca7e5b6a5008dcf551516490b0ba4510e073d08"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "2f4ce5ec1d447beb42143a9653716a2ab025161e",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "aca7e5b6a5008dcf551516490b0ba4510e073d08",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "libsubcmd: Fix use-after-free for realloc(..., 0)\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.181 by commit aca7e5b6a5008dcf551516490b0ba4510e073d08, it was introduced in version v4.5 by commit 2f4ce5ec1d447beb42143a9653716a2ab025161e. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000354


exectools.cmd_gather should not busy-wait on output

/lgtm
Sounds good to me. But why?

/lgtm
/approve
@tbielawa because a no-wait loop will peg the CPU. Telling it to sleep even barely will let the CPU context switch. In C I used to be able to do sleep(0) but in Python you need to give it a non-zero number.


Fix upstream conflict

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
https://devopsmx.atlassian.net/browse/OP-13600

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Close the PR, add Jira ticket number in comments, reopen the PR to trigger a new pipe in spinnaker.Reviewers approve only after jira reference is added.

https://devopsmx.atlassian.net/browse/OP-13600

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01FZG2B9NAMR9DMHW4Y7SSG4ZA

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01FZG2BJ74K8JSBMTYKP0PJY6G

SUCCESSFUL RunTestJar RESULT: Total tests run: 196, Failures: 1, Skips: 0 Reviewers ,  this PR did not cause the failures in  https://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-2381.html

https://devopsmx.atlassian.net/browse/OP-13600

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01FZG397PT4D9EKRC967G9FNEV

SUCCESSFUL RunTestJar RESULT: Total tests run: 196, Failures: 1, Skips: 0 Reviewers ,  this PR did not cause the failures in  https://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-2383.html


I want to contribute to this ⭐

Hello @dynamic2code 👋🏾
I'm a Software Developer from Nigeria and would like to contribute to this project. I can do 2-3 hours a day, but will need an initial starting point for contribution (bug fixes, features, tests, etc).
I saw your post on LinkedIn and was intrigued by it. Happy to start collaboration immediately.

Hello,
Some of the documentation is at https://donation-tracking-nuxt.vercel.app/  . Currently am at the messaging part with Africa's talking on the back-end part. You could work on that.  Am working on the Nuxt app


⚠ Bofrost.at has degraded performance

In 193b428, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2374 ms

Resolved: Bofrost.at performance has improved in ffe3ccf after 8 minutes.


Fix paging links  parameter error

Is there an open issue describing what this solves? I don't remember seeing one.

This was resolved in #2246


fix: inverse the treeSelect treeCheckStrictly attribute

Types of changes

[ ] New feature
[ √ ]  Bug fix
[ ] Enhancement
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

https://arco.design/react/components/tree-select
树形选择器，treeCheckStrictly属性，介绍描述为父子节点是否关联，应该是true为关联，false为不关联，但实际效果相反

Solution

对treeCheckStrictly属性引用进行取反，其他逻辑不变
How is the change tested?

同样界面，点击相反即可
Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

ps 我这个改的有问题，还需要进一步验证

这个没有写反哈 ～ 严格选中的意思是节点的选中状态之跟自己有关系

好滴，那我等明天提个文档描述的pr看一看哈哈


rename master to main

I just realized that the default branch of this repo is called master. Should this repo adopt the new main branch convention?
In case yes, this might help.

What will be gained by renaming? This is probably super bikeshedy 😅

What will be gained by renaming?

I was planning to do this in the coming weeks, thanks for bringing it up!
@vtomole - the industry is moving away from terms with historical baggage of misuse and oppression - e.g. master, blacklist, whitelist, etc. E.g. see https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/ - Github itself is now creating new repos with main.

@balopat I see. Good to know!

This has been completed.


[DOCFIX]Add doc for verifyInodesList

Add doc for PermissionCheckerTest#verifyInodesList.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15030/
Test PASSed.

Merged build finished. Test PASSed.


Update lib/pq dependency to avoid errors with Postgres 14

The following error is observed when trying to use await with Postgres 14:
Resource unavailable: pq: unknown authentication response: 10
This is due to Postgres changing it's default to scram-sha-256 rather than md5.
Updating to the latest version of lib/pq resolves this issue

Declining in favor of a proper branch based PR


Introduce CODEOWNERS

This commit introduces GitHub's CODEOWNERS file to automatically add reviewers to pull requests. Listed owners are a starting point for reviews, or to add other contacts to the pull request.
Gitignore is also updated to add Python's __pycache__.

Thanks for reviewing. We will submit any additions / modifications in follow up pull requests. This should be a good starting point for now.


Travis build with MinGW

Enable a MinGW build with a cross-compiler in Docker

to fix:

how to organize running in containers without making a mess into travis.yml
after_success.sh was broken, for yet unknown reason

Closed to stop the notifications while reworking


"Find usages" of a field doesn't find usage in Builders

Short description
When clicking 'Find Usages' or ctrl+clicking on a field of a class that has a Lombok builder added to it using @Builder, those instances where this field is set via that builder are not included in the usages.
This creates a problem of refactoring, as developers need to know all usages of a particular variable, including where it's being set via builders.
Expected behavior
Upon clicking 'Find Usages' or ctrl+clicking on a field, it should include all instances where this field is set via the builder of that class
Version information

IDEA Version:
2017.3.2 Ultimate
Build #IU-173.4127.27
JDK Version:
JRE: 1.8.0_152-release-1024-b8 amd64
OS Type & Version: Windows 10
Lombok Plugin Version:
<IP_ADDRESS>
Lombok Dependency Version: lombok-1.16.10.jar

Steps to reproduce

Create a simple class with one field and a Lombok builder:

Build this class and set the field to some value:

Try to find usages of the field that was set in the builder:

Closed as duplicate of #144


PyTango minimal version

Is there a particular reason why pytango = ^9.4.1 was chosen as version constraint?
It was changed from ^9.3.0 in this pull request.
We run mostly pytango==9.3.6, so I guess it would make our life easier if this version was not excluded.
@oldfielj-ansto @marcus-oscarsson

That would be fine

For information, we had a problem with pyTango 9.3.4. The problem is on the server side. When a device server is started with pyTango 9.3.4, it gives the attribute error. When started with 9.3.3, even a 9.3.4 client works fine.


Does 'tp' command supports orientations?

I want to teleport the agent with specific yaw
However tp command with (x y z yaw pitch) parameter does not work.
Is there another way to do this?

I found it~
It was 'setYaw '

Hi @gliese581gg - thank you for reporting this, and for providing the workaround. The expected behavior is that yaw is respected in the tp command. I'll re-open this for now so that we remember to look into this.

@gliese581gg is correct - the AbsoluteMovementCommands include separate commands for setting position, yaw and pitch - there is no command to set the x/y/z/yaw/pitch atomically.
See the documentation here: http://microsoft.github.io/malmo/0.21.0/Schemas/MissionHandlers.html#type_AbsoluteMovementCommand
(apologies for old version in the docs - but AbsoluteMovementCommand hasn't changed since 0.21.0)
The tp command "respects" the yaw in that it won't change the yaw/pitch, so it's possible to set the yaw and then teleport. But perhaps there should be a new command for setting everything at once. If this would be desirable, please open a new issue as a feature request - am closing this one.


[ENH] Major NeuroLibre web app enhancements to complete the NeuroLibre workflow

Not to merge at this point, created the PR to clearly see the changes.

[ ]  Refactor TODOs
[ ]  Improve in-line comments
[ ]  Ensure consistent var names

@agahkarakuzu should we merge this? it looks like this branch has been into production for months.

@pbellec this repo is obsolete. Since I've moved the whole thing to the new joss, neurolibre.org is deployed from https://github.com/neurolibre/neurolibre-neo. Similarly for roboneuro, roboneuro-neo.
I have not archived this one yet, but we may.


Cannot pull docker images for grafana and turbine server

Hi I am using

minikube v0.9.0
gofabric8 v0.4.48

and I get the following errors in docker daemon logs concerning

grafana
turbine server

"Handler for GET /images/fabric8/grafana:2.2.243/json returned error: No such image: fabric8/grafana:2.2.243"
"Calling GET /containers/json?all=1&limit=0"
"Calling GET /images/fabric8/turbine-server:1.0.18/json?size=1"
"Handler for GET /images/fabric8/turbine-server:1.0.18/json returned error: No such image: fabric8/turbine-server:1.0.18"

sorry about this @ssouris - seems our release builds got a little broken.
I think I've fixed the turbine-server, its looking like its pushing images again: https://hub.docker.com/r/fabric8/turbine-server/tags/ - I'm about to test a fix for grafana shortly...

OK the grafana image is now created properly too; but it won't quite be usable from gofabric8 just yet until we cut the next release in the next day or two.
As a workaround you could edit the grafana Deployment object to use version 2.2.245 from https://hub.docker.com/r/fabric8/grafana/tags/

@jstrachan thanks for the reply :)
I edited the kubernetes yaml file for grafana and the docker image was pulled successfully :)

this should be fixed in the latest release now - sorry about that!


restructure project

Closes #31

Seems like a good first step. Any thoughts @alarsyo @erbesharat?

Other than this (but it might not be better for the overall project structure) it looks good!

/LGTM


Add encryption support for RBD volumes with IBM HPCS KMS

Describe the feature you'd like to have
IBM Cloud™ Hyper Protect Crypto Services is a key management and cloud hardware security module (HSM). It is designed to enable a user to take control of their cloud data encryption keys and cloud hardware security models, and is the only service in the industry built on FIPS 140-2 Level 4-certified hardware. The request here is to support this KMS integration thus enable the HPCS users to make use of the same in RBD volume operations.
Initial design/Identified changes:
Below parameters can be used to establish the connection to the HPCS service from the CSI driver and make use of the encryption operations:
KMS_SERVICE_NAME=[kms_service_name]
A unique name for the key management service within the project.

SERVICE_INSTANCE_ID=[service_instance_id]
The Instance ID of the IBM HPCS service, ex:  crn:v1:bluemix:public:hs-crypto:us-south:a/5d19cf8b82874c2dab37e397426fbc42:e2ae65ff-954b-453f-b0d7-fc5064c203ce::

SERVICE_API_KEY=[service_api_key]
Ex:  06x6DbTkVQ-qCRmq9cK-p9xOQpU2UwJMcdjnIDdr0g2R

CUSTOMER_ROOT_KEY=[customer_root_key]

BASE_URL=[base_url] → only required if the instance is in a different region
 The base URL (key management endpoint URL ) specifies the URL where your  HPCS instance resides. It is region specific. Ex:
https://api.us-south.hs-crypto.cloud.ibm.com:9756

TOKEN_URL=[token_url] → only required if the different than the default token url
 Ex:  https://iam.bluemix.net/oidc/token

IBM key protect APIs can be used for the integration and examples can be found here:
Doc:
https://cloud.ibm.com/docs/key-protect

Clients:

https://github.com/IBM/keyprotect-go-client
https://github.com/IBM/keyprotect-python-client
https://github.com/IBM/keyprotect-java-client

Authentication:

https://github.com/IBM/keyprotect-go-client#authentication

Examples:

https://github.com/IBM/keyprotect-go-client#examples

afaict, Libopenstorage also got support for key protect APIs  https://github.com/libopenstorage/secrets/tree/master/ibm  , so we are good to use it via LOS or directlty the key protect clients

After some disussions  on this, we are going ahead with key protect API SDK for this inegration atleast in the first phase.

* [ ]  The LibOpenstorage api interation looks like bit old (2 years) https://github.com/libopenstorage/secrets/tree/master/ibm , so one thing which we need to take a decision here is :   what is the preferred way of integration here ? ie, will use libopenstorage or use direct client SDKs of key protect APIs? @nixpanic  any preference ?

The libopenstorage client protect API update PR is in up for review https://github.com/libopenstorage/secrets/pull/58 :+1:

Unfortunately the LBS repo maintenance looks to be really slow/not progressing. We will use KP client SDK directly for this integrataion.

This has been done and PR is merged, one small update to the internal code base about the env variable name is waiting for confirmation from other related components for consistency. As soon as its available, will clear the milestone or close this issue.

This has been done and PR is merged, one small update to the internal code base about the env variable name is waiting for confirmation from other related components for consistency. As soon as its available, will clear the milestone or close this issue.

https://github.com/ceph/ceph-csi/pull/2747 should address this.

Removing from the release tracker, however keeping this issue open.

@humblec what else is pending here?

@humblec what else is pending here?

Verification from cloud provider is still going on, based on the feedback I have to adjust the requirement or call it as Done.

As I havent heard any issues so far on this, I am closing this one.. will reopen if required..


CockroachDB doc updates needed

This issue is for collecting additional content we need to add to the Cockroach docs. (Please edit this section to add new items.)

Add information about the default behaviour of autoincrement  starting at a high number by default (example:<PHONE_NUMBER>38327297) when doing a Prisma Client query or manual insert.
Link to relevant CockroachDB docs.
For details, see this Slack convo.

Closed via https://github.com/prisma/docs/pull/2830


Can't download highlight videos

Only work once, after that it just outputting Fetch info API failed with status code: 400 with Failed- Network error on file download
https://github.com/y252328/Instagram_Download_Button/blob/6d672405446bb036677ca4fe445ed8d111ce54ba/instagram-dl.user.js#L481

Running into this issue too. Seems like it tries to download the blob URL and then my browser shows "Failed - Network error".


update readme

modify README.md

Merged https://github.com/atanughosh01/DemoSpringBootKafka/pull/1


The type or namespace name 'Services' does not exist in the namespace 'Microsoft.Crm'

The line:
Microsoft.Crm.Services.Utility.DeviceIdManager.LoadOrRegisterDevice()
throws a missing assembly reference error,
The type or namespace name 'Services' does not exist in the namespace 'Microsoft.Crm' (are you missing an assembly reference?)
Using Microsoft.CrmSdk.CoreAssemblies v. <IP_ADDRESS>.  Added all the using statements at the top, and error persists.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6114d6c3-688b-765a-9a96-fb656fe748a4
Version Independent ID: 687f9106-e35a-5295-670d-0b4061dbda3e
Content: Sample: Authenticate users with Dynamics 365 Customer Engagement web services (Developer Guide for Dynamics 365 Customer Engagement (on-premises))
Content Source: ce/customerengagement/on-premises/developer/sample-authenticate-users-web-services.md
Product: d365ce-op
GitHub Login: @JimDaly
Microsoft Alias: jdaly

@pmf2021 Sorry about that code not working. I can tell you that code is very old and we have much newer and easier APIs available for D365 authentication. I suggest you start with Sample: Quick start for Dynamics 365 Customer Engagement
sample code

@pmf2021 In the meantime, I will look into finding a better sample for that topic. Thanks for pointing this issue out to us.

Any time!  I live and breathe by your documentation.  Keep up the great
work!
On Fri, Aug 20, 2021 at 6:46 PM Peter Hecke @.***>
wrote:

@pmf2021 https://github.com/pmf2021 In the meantime, I will look into
finding a better sample for that topic. Thanks for pointing this issue out
to us.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/dynamics-365-customer-engagement/issues/2353#issuecomment-903010724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUAR5FQUBNZ67RPK5OXUPCLT53SMJANCNFSM5CRCRQ5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


[type:feat] login token convert user.

With pull requests:

Open your pull request against main
Your pull request should have no more than two commits, if not you should squash them.
You should pass all tests by go test -v ./... at the project root path in local.
It should pass all tests in the available continuous integration systems such as GitHub Actions.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.

Codecov Report

Merging #121 (160e775) into main (1e26e2a) will increase coverage by 0.32%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   14.31%   14.63%   +0.32%
==========================================
  Files          14       14
  Lines         845      888      +43
==========================================
+ Hits          121      130       +9
- Misses        710      744      +34
  Partials       14       14

Impacted Files
Coverage Δ

internal/core/openapi/openapi.go
0.00% <0.00%> (ø)

internal/core/openapi/user.go
0.00% <0.00%> (ø)

internal/core/openapi/token.go
17.30% <7.31%> (+17.30%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Esc on the suggestion will be swallowed by somehow for 0.5 seconds

While turning to normal mode from insert mode, the last Esc will be frozen for 0.5 seconds, then jump to the previous letter.
Any input during this 0.5 seconds takes no effect.

By commenting init.vim, I found that this problem will be caused by set showmatch command.
Will be fine after removing this command, just don't know why it will cause this problem in vscode-neovim plugin.

what does :set matchtime? say?

set matchtime?says 5, when I set it to 1 there will be a quick flick. Quite annoying might just delete this line.


Update firebase.js and firebase-simple-login.js includes to latest version.

Friend of mine ran into trouble getting google auth to work, since the seed is referencing an old version of simple login.

Hey Mike, thanks for reaching out, but we're no longer maintaining this starter pack for new versions of Firebase. Perhaps you could check out the Web client for FriendlyChat to see a more up-to-date auth example.