Error on new RN 0.45.1

After run ./node_modules/.bin/rn-nodeify --hack --install
.....
......
installing from npm readable-stream
installing: npm install --save tradle/react-native-http#834492d<EMAIL_ADDRESS>npm WARN gentlyRm not removing /Users/anhtai/Develop/RNApp01/node_modules/.bin/jest as it wasn't installed by /Users/anhtai/Develop/RNApp01/node_modules/jest-cli
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>added 2 packages, removed 686 packages and updated 61 packages in 38.5s
/Users/anhtai/Develop/RNApp01/node_modules/rn-nodeify/cmd.js:66
      if (err) throw err
               ^

Error: ENOENT: no such file or directory, open '/Users/anhtai/Develop/RNApp01/node_modules/rn-nodeify/shim.js'

And because of it remove almost module, so react-native project can't run anymore.

@TaiPA I haven't tried rn-nodeify with RN > 0.42.3 yet. If I understood correctly, I'm sorry to hear it broke your project! Other than package.json, it should only touch files in node_modules, so you should always be able to rm -rf node_modules and npm install again.
Maybe you can try to figure out what goes wrong and submit a PR? :)

I ran into this same issue. It appeared to delete itself in the process. I re-ran the process after a simple rm -rf node_modules/ and it worked. May also be worthing noting that I am using npm 3.

I have the same issue，but it worked when i use node 6.9.2 and npm 3.10.9.

yea, tldr use npm@3, npm@5 has some issues. See
https://github.com/infinitered/ignite/issues/1101
https://github.com/npm/npm/issues/16839

Hi @mvayngrib
Getting the same issue on running ./node_modules/.bin/rn-nodeify --hack --install.
/<my_location>/node_modules/rn-nodeify/cmd.js:74
      if (err) throw err
               ^

Error: ENOENT: no such file or directory, open '/<my_location>/node_modules/rn-nodeify/shim.js'

I want to use the node js crypto module in my react native project.  I am on version 0.57.3.
Can you suggest what might be the issue here or if there are any workarounds?

rm -rf node_modules

worked for me after rm -rf node_modules, then yarn install


Testing botify ping

Details

Testing https://github.com/Expensify/Web-Expensify/pull/33223
Testing edit!
Fixed Issues

$ GH_LINK
Tests

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I clearly indicated the environment tests should be run in (Staging vs Production)

[ ] I wrote testing steps that cover success & fail scenarios (if applicable)
[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests & veryfy they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I added comments when the code was not self explanatory
[ ] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[ ] I followed proper naming convention for platform-specific files (if applicable)
[ ] I followed style guidelines (in Styling.md) for all style edits I made
[ ] I followed the JSDocs style guidelines (in STYLE.md)

[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I corroborated the UI performance was not affected (the performance is the same than main branch)
[ ] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Great even the edit event worked that it did not apply the ping again!


Use built in views unless project directory contains custom views

For any given view, if the view is not defined in the project the server should fall back on the respective view from the npm package.

https://github.com/anvilresearch/connect/pull/179


Bug fix: Added support for using schema as kwargs.

Fixed bug: set as_kwargs=True when using Schema raises an AttributeError.

Thanks!


JsonLines

I had some trouble using the JSONLinesFileSource; it was hanging when trying to process a large file and processing smaller files unpredictably.
After having a look at the source, I realised that JSONLinesFileSource is designed to process streaming JSON where all of the objects are on one line, using a buffer. JSONLines is a format where each object is on a separate line (http://jsonlines.org).
It might be a good idea to rename the Source in order to avoid this confusion?

I intended to make a jsonlines source. I see that I did not test it properly. Apologies. I'll fix that asap.
-P.

I tested it with a small test case, and found no issues. Are, perhaps, your per-line JSON objects very very large? Can you provide an example file so that I can reproduce the problem?

Thanks Pablo. I created a test file:
https://gist.github.com/benjaminsims/be9791259f0ce2b5c8c14d30a8956291
This contains 10,000 random words in JSON objects. When I run it locally, the processing only gets as far as line 3688. Adding or removing lines previous to that point will change the point at which processing fails but not in a predictable way, which makes me think it may be do with buffer size?
On a side note, is it correct to say that JSONLines files are not splittable? I'm too new to Beam to know how much of a performance difference it makes, but we use them specifically because they can be split and parallel processed.

Thanks for the sample, Benjamin! The bug is a corner case related to the stripping of the new lines, and the buffering of the file. I'm pushing the fix now.
Regarding the splitting, I need to check how to implement the splitting logic; but as long as it's possible to split on new lines (which I think it is), we should be fine. Give me another week to try to get out a split routine for this.

Thanks for the quick fix Pablo, much appreciated.
The format officially splits on '\n'. The reason I'd thought you were targeting files with all the objects on one line was the reference in the code to http://stackoverflow.com/questions/21708192/how-do-i-use-the-json-module-to-read-in-one-json-object-at-a-time/, which is specific to that use case.
With a valid file separated by newlines, I'm not sure if using a buffer has advantages over just reading the lines?

I see your point. I had originally used that code because I thought that JSON objects did not need to escape the newline character within strings (e.g. a json string could contain newlines), and just reading line by line would fall into this trap; but seeing that strings in json do have to escape the newline, it should be possible to just read line by line and decode that.
I guess I over-engineered the source : )
I'll push this simplification later today then.

I pushed the simplification.


EAsun iSolar SM IV 5.6kW support

Hello,
I have this EAsun iSolar SM IV inverter but most commands seem to report values equal to zero.
[16:39:23][D][pipsolar:775]: CRC OK
[16:39:23][D][pipsolar:448]: Decode QPIGS
[16:39:23][D][text_sensor:067]: 'inverter0_last_qpigs': Sending state 'QPIGS'
[16:39:23][D][sensor:125]: 'inverter0_grid_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_grid_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_ac_output_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_ac_output_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_ac_output_apparent_power': Sending state 0.00000 VA with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_ac_output_active_power': Sending state 0.00000 W with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_output_load_percent': Sending state 0.00000 % with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_bus_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_battery_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_battery_capacity_percent': Sending state 0.00000 % with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_inverter_heat_sink_temperature': Sending state 0.00000 °C with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_pv_input_current_for_battery': Sending state 0.00000 A with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_pv_input_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:23][D][sensor:125]: 'inverter0_battery_voltage_scc': Sending state 0.00000 V with 1 decimals of accuracy
[16:39:24][D][sensor:125]: 'inverter0_battery_discharge_current': Sending state 0.00000 A with 1 decimals of accuracy
[16:39:24][D][sensor:125]: 'inverter0_pv_charging_power': Sending state 0.00000 W with 1 decimals of accuracy
[16:39:24][D][pipsolar:838]: Sending polling command : QPIWS with length 5
[16:39:24][D][pipsolar:772]: checking crc on incoming message
[16:39:24][D][pipsolar:775]: CRC OK
[16:39:24][D][pipsolar:525]: Decode QPIWS
[16:39:25][D][pipsolar:838]: Sending polling command : QMOD with length 4
[16:39:25][D][pipsolar:772]: checking crc on incoming message
[16:39:25][D][pipsolar:775]: CRC OK

How could I make this work?

Could you enable the debug output of the uart component and provide some more logs? It looks like the response to QPIGS is just QPIGS.
uart:
  id: uart0
  baud_rate: 9600
  tx_pin: XXX
  rx_pin: YYY
  debug:
    direction: BOTH

[18:07:58][D][pipsolar:429]: Decode QPIRI
[18:07:58][D][sensor:125]: 'inverter0_grid_rating_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_grid_rating_current': Sending state 0.00000 A with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_battery_rating_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_input_voltage_range': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_output_source_priority': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_charger_source_priority': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_machine_type': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_topology': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][sensor:125]: 'inverter0_battery_redischarge_voltage': Sending state 0.00000  with 1 decimals of accuracy
[18:07:58][D][uart_debug:114]: <<< 51:50:49:52:49:F8:54:0D
[18:07:59][D][pipsolar:838]: Sending polling command : QPIGS with length 5
[18:07:59][D][uart_debug:114]: >>> 51:50:49:47:53:B7:A9:0D
[18:07:59][D][pipsolar:772]: checking crc on incoming message
[18:07:59][D][pipsolar:775]: CRC OK
[18:07:59][D][pipsolar:448]: Decode QPIGS
[18:07:59][D][text_sensor:067]: 'inverter0_last_qpigs': Sending state 'QPIGS'
[18:07:59][D][sensor:125]: 'inverter0_grid_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_grid_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_ac_output_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_ac_output_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_ac_output_apparent_power': Sending state 0.00000 VA with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_ac_output_active_power': Sending state 0.00000 W with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_output_load_percent': Sending state 0.00000 % with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_bus_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_battery_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_battery_capacity_percent': Sending state 0.00000 % with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_inverter_heat_sink_temperature': Sending state 0.00000 °C with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_pv_input_current_for_battery': Sending state 0.00000 A with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_pv_input_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_battery_voltage_scc': Sending state 0.00000 V with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_battery_discharge_current': Sending state 0.00000 A with 1 decimals of accuracy
[18:07:59][D][sensor:125]: 'inverter0_pv_charging_power': Sending state 0.00000 W with 1 decimals of accuracy
[18:07:59][D][uart_debug:114]: <<< 51:50:49:47:53:B7:A9:0D
[18:08:00][D][pipsolar:838]: Sending polling command : QPIWS with length 5
[18:08:00][D][uart_debug:114]: >>> 51:50:49:57:53:B4:DA:0D
[18:08:00][D][pipsolar:772]: checking crc on incoming message
[18:08:00][D][pipsolar:775]: CRC OK
[18:08:00][D][pipsolar:525]: Decode QPIWS
[18:08:00][D][uart_debug:114]: <<< 51:50:49:57:53:B4:DA:0D
[18:08:01][D][pipsolar:838]: Sending polling command : QMOD with length 4
[18:08:01][D][uart_debug:114]: >>> 51:4D:4F:44:49:C1:0D
[18:08:01][D][pipsolar:772]: checking crc on incoming message
[18:08:01][D][pipsolar:775]: CRC OK
[18:08:01][D][pipsolar:471]: Decode QMOD
[18:08:01][D][text_sensor:067]: 'inverter0_device_mode': Sending state 'M'
[18:08:01][D][uart_debug:114]: <<< 51:4D:4F:44:49:C1:0D
[18:08:02][D][pipsolar:838]: Sending polling command : QPIRI with length 5
[18:08:02][D][uart_debug:114]: >>> 51:50:49:52:49:F8:54:0D
[18:08:02][D][pipsolar:772]: checking crc on incoming message
[18:08:02][D][pipsolar:775]: CRC OK

But please not my baud_rate is 2400.

Sorry for the confusion. I didn't want to suggest another baudrate. The important part was:
  debug:
    direction: BOTH

Could you provide a photos of your wiring?

I just received a new adapter and I tried with this one instead. The messages changed but they still don't look good to me.
[19:31:40][D][pipsolar:755]: timeout command to poll: QPIWS
[19:31:40][D][uart_debug:114]: <<< FF:7F:EF:FF:FF:DF:FF:FD:DF:FF:FD:FD:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF
[19:31:40][D][pipsolar:838]: Sending polling command : QMOD with length 4
[19:31:40][D][uart_debug:114]: >>> 51:4D:4F:44:49:C1:0D
[19:31:41][D][uart_debug:114]: <<< FF:FF:DF:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:EF:DF:FF:FF:FF:FF:FF:FF:F7:FF:FD:FF:FB:FF:FF:FF:DF:DF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:ED:FF:FF:DF:DF:FF:FF:FF:DF:FF:FF:FD:FF:FF:FF:FF:DF:DF:FF:FF:FF:BF:FF:F7:FF:FF:FF:FF:FF:FF:F7:F7:FF:FF:FD:FD:FF:FF:FD:DF:FF:EF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:BF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FB:FF:BD:FF:DF:FD:DF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:D7:EF:FF:BF:FF:FD:FF:FF:FF:FF:FF
[19:31:42][D][uart_debug:114]: <<< FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:D7:FF:9D:FF:FF:FF:FF:FF:FB:AF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:FF:FF:FD:FF:FD:FF:FF:FF:FF:FF:FF:FF:FF:FF:9F:FF:FF:FF:FF:FF:FF:FF:EF:FF:EF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:DF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:BD:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:F7:FF:FD:DF:DF:FF:FF:FF:FF:FF:DB:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:DD
[19:31:43][D][uart_debug:114]: <<< FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FB:FF:FF:BF:FF:EF:DF:FF:FF:FF:FF:FD:FF:FF:FF:FF:FD:FD:FF:FF:FF:FF:BF:EF:FF:FF:FD:FF:FF:FF:FF:FF:FF:FD:DF:FD:FF:FF:FF:FF:DF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:BF:FF:FF:FF:F5:FF:FF:FD:FF:FF:FD:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:DF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FD:7F:DF:FF:FB:EF:FF:FF:FF:FF:FF:FF:FF:FF:DF:DF:DF:FF:FF:D7:FF:F7:DF:FF:FF:FF:FF:FF:FF
[19:31:44][D][uart_debug:114]: <<< FF:FF:FF:7F:F7:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:7F:EF:FF:FF:FF:FF:FF:FF:FF:FF:77:FF:DF:7F:FF:FF:FF:FF:FF:EF:FF:FF:FF:FB:FF:FF:BF:BF:FF:FF:FF:EF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FD:FD:FF:7F:FD:FF:FF:FF:FD:DF:F7:FF:DF:FF:FF:FD:DF:DD:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:FF:FD:FF:DF:FF:FF:FF:FF:FD:FF:ED:FF:FF:FF:DF:FF:FF:DF:FF:FF:DF:FD:BD:FF:FD:DF:FF:FF:FF:FF:FF:FF:FF:FB:FF:FF:FF:FD:FF:FF:FF:FF:FF:FF:FF:FD:DF:FF:FF:FF:FD:FF:FF:FF
[19:31:45][D][uart_debug:114]: <<< FB:FF:FF:FF:FF:FF:BF:FF:FF:FF:FF:FF:FF:BF:FF:FD:FF:FD:FF:FF:FF:FF:FF:FF:FF:DF:FF:DF:F7:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FD:BD:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:DF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:DF:FF:DF:FF:DF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:DF:7F:FF:FF:FF:FF:FF:FF:FF:FF:FB:FF:FF:DF:FF:FF:EF:FF:FF:EF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF
[19:31:45][D][pipsolar:755]: timeout command to poll: QMOD
[19:31:45][D][uart_debug:114]: <<< EF:FF:FF:FF:FF:DF:FB:FF:FF:FF:FF:FF:F7:DF:FF:FF:FF:FF:FF
[19:31:45][D][pipsolar:838]: Sending polling command : QPIRI with length 5
[19:31:45][D][uart_debug:114]: >>> 51:50:49:52:49:F8:54:0D
[19:31:47][D][uart_debug:114]: <<< FF:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FD:FD:FF:FF:FF:FF:FF:FF:DF:FF:DF:FF:FF:FF:FB:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:BF:FF:FF:FF:FD:DF:FF:7F:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FD:DF:DF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:F7:FF:DF:FF:FF:FF:FF:FF:FF:FF:F7:DF:FF:FF:FF:DB:FF:F7:FF:EF:FF:F7:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:BF:FF:FF:6F:FF:7D:FF:FF:FF:FF:FF:FD:FF:DF:BF
[19:31:47][D][uart_debug:114]: <<< DF:FF:DF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:D3:FF:F7:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:FF:FF:DF:FF:FF:DF:EF:FF:FF:FD:FE:FF:FF:FF:FF:EF:DF:FF:FF:FD:FF:FD:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:FF:FF:FF:F7:FF:F7:FF:FF:FF:FD:7F:FF:FF:EF:DF:FF:BF:DF:FF:FF:FF:FF:FF:FF:FF:FF:CF:FF:3F:FF:FF:FF:FF:EF:FF:FF:FF:FF:7F:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF
[19:31:49][D][uart_debug:114]: <<< FF:EF:FF:F7:FB:FF:7F:FF:FF:FF:EF:FF:FF:FF:FF:D7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FB:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:DF:FF:FF:F7:FF:DF:FF:DF:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:FF:FF:FF:EF:BF:FF:FF:DB:FF:FF:FF:FF:FF:FF:FE:FD:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:EF:FB:FF:FF:DD:FF:FF:DF:FF:FF:FD:FD:FF:FF:FF:FF:D7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:BF:FF:FF:FF:FF:FF:FF:FF:EF:DF:FF:FF:EF:FF:FF:FF:FF
[19:31:50][D][uart_debug:114]: <<< FF:FF:FF:FF:FD:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FB:FF:DF:FF:BD:FF:FF:FF:DF:FF:FF:FF:DF:FB:FF:EF:DF:FF:FF:FF:FD:FF:EF:FF:FF:FF:FF:F7:F7:FF:FF:FD:FF:FF:FF:FF:FF:F7:FF:DF:FB:FF:DF:DF:FF:FF:FF:FF:FF:EB:FF:FF:FF:FF:FF:DF:FD:FF:EF:7F:FF:7F:FF:FF:FB:FF:FF:FF:FF:FF:FF:FF:FF:DF:DF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FD:FF:FF:DF:FF:FF:FF:DF:DF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7
[19:31:50][D][pipsolar:755]: timeout command to poll: QPIRI
[19:31:50][D][uart_debug:114]: <<< FF:FF:FF:FF:FF:FF:EF:FF:FF:DF:FF:FF:FF:FF:DF:FF:FF:FF:DF:FF:FB:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:EF:FF:EF:FF:FF:FF:FF:F7:FF:FB:FF:FF:FF:FD:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:EF:FF:FF:FF:FF:FB:FF:FF:FB:FF:FF:DF:FF:FF:FF:EF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FD:FD:FF
[19:31:50][D][pipsolar:838]: Sending polling command : QPIGS with length 5
[19:31:51][D][uart_debug:114]: >>> 51:50:49:47:53:B7:A9:0D
[19:31:52][D][uart_debug:114]: <<< FF:FB:FF:DF:D7:FF:FF:FF:FF:EF:DF:BD:FF:DF:F7:FF:FF:FF:FF:F7:F7:FF:F7:F7:FF:FF:FD:FF:FF:FF:FF:FF:FF:FF:FF:FF:E7:DF:FF:FF:DF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:7F:FF:FF:EF:7F:FB:FF:FF:FF:FF:FF:FF:EF:FF:7F:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:EF:F7:FB:FF:FF:FF:BF:FF:FF:FF:FF:FF:FF:FF:FF:FB:DF:FF:FF:FF:FF:FF:DF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:EF:FF:FF:FF:EF:FF:FD:FF:FF:FF:ED:FF:FF:DF:DF:DF:FF:DF:FF:EF
[19:31:53][D][uart_debug:114]: <<< FB:FF:FF:DF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:FF:FF:FF:EF:EF:FF:FF:FF:F7:FF:FF:FF:FF:EF:EF:7F:DB:FF:CF:FF:FF:FF:FF:FE:7F:FF:FF:FF:FF:F7:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:EF:FF:F7:FF:FF:FF:FF:FF:FF:FF:DF:EF:FF:FF:7F:FF:FF:FF:FF:FF:F7:F7:DF:FF:FF:FF:DF:FF:DF:EF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:F7:FF:FF:FF:7F:EF:EF:FF:F7:FF:FF:FB:D7:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:DF:FF
[19:31:54][D][uart_debug:114]: <<< EF:FF:DF:EF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:F7:FF:FF:FF:EF:DF:FF:EF:FF:FF:FF:FF:FF:FF:FF:EF:DF:FF:FF:FF:DF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:EF:FF:FF:DF:FF:FF:FF:EF:FB:DF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FB:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FD:FF:FF:FF:FF:DF:EF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FB:BF:FF:FF:FF:FF:FF:7F:FF:FF:FF:EF:DF:FF:CF:FF:FF:FF:DF:FF:DF:FF:FF:FF:F7:FF:FF:FF:FF:FF
[19:31:55][D][uart_debug:114]: <<< FB:FF:FF:7F:FF:FF:FF:FF:FF:FF:DF:7F:FF:FF:FF:FD:FF:FF:F7:FF:FF:FF:FF:FF:FF:FD:FD:FF:FF:FF:FF:FD:FF:FF:FF:F7:DF:FF:FF:FF:DF:FF:FF:FF:FF:FF:F7:BF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:BF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:F7:FF:DF:FF:FF:FF:FF:FF:FF:DF:FF:EF:D7:FF:EF:DF:FF:FF:DF:FF:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:F7:DF:FF:FF:FB:FF:DF:FF:FF:FF:FF:FF:F7:FF:7F:FF:DF:FF:7F:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF
[19:31:55][D][pipsolar:755]: timeout command to poll: QPIGS
[19:31:56][D][uart_debug:114]: <<< FF:DF:FF:FF:FF:7F:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:EF:F7:FF:FF:FF:F7:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FB:FF:FF:FF:FF:FF:FF:FF:FF:DF:FF:FF:FF:FF:FF:FB:BB:FF:FF:FF:F7:FF:FF:F7:FF:FF:F7:FF:F7:7F:FF:FF:EF:D7:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:FF:7F:FF:FF:FF:DF:FF:FF:FF:FF:FF:FF:FF:FF:FF:F7:FF:FF:7F:FF:DF:FF:FF:FF:DF:FF:FF:FF:FF:FF:7F:FF:FF:FF:FF:FF:FD:FF:FF

Does this tell you anything? I will also try to make some photos and send them.

Did you connect GND properly? Please make sure the baudrate is 2400 baud.

Dude, you are the best!
This new adapter had a different pinout even though the board is quite similar. I incorrectly assumed the pinout would be the same but GND was switched with TX on this board as opposed with the other board. It's impressive that the chip was powered though.
Thanks a lot!
In conclusion for others reading this thread in the future:

syssi is the best
not all adapters actually work. I have one with MAX232 which works.
try to rotate RX/TX until you get it right.

 If you want to do me a favor please provide a photo of your rs232 converter + wiring. It looks like a proper connection/wiring is the hardest part of the journey. ;-)

To be very precise: You are using a MAX3232. This is the 3.3V version of the MAX232. This is important & good because driving a MAX232 with 3.3V is out of spec and driving a MAX232 with 5V leads to a logic level (TTL) of 5V too. The GPIOs of a ESP aren't 5V tolerant.


The time cost of the training process in step 1

Hello, thank you for sharing!
In the training process of step 1, an epoch costs one to two hours, and you set up 200 epoch. Is this training time normal? Is there any way to improve the training speed?

Hi!
The given number of epochs 200 is more for the training on the Wireframe dataset (step 4). For synthetic training, less epochs are needed. 30 to 40 should be more than enough. It took a bit more than a day on a single GPU in our case. You can monitor the training metrics in Tensorboard and stop the training as soon as they stop increasing.
The training on the Wireframe dataset is however quite slow. It took a bit more than 4 days in our case to reach the 200 epochs. Fine-tuning the pre-trained model available on this repo will greatly accelerate this training time though.

Thank you for your replying. In order to accelerate the training time, I used the pre-trained 'model sold2_synthetic.tar' you provided and changed the batch_size from 6 to 60 in the first step. Is that ok?

Sure, that should help making it faster and should not hinder the performance anyway.

Hi,
In view of the slow training speed, I would like to ask if it is possible to change the code into multi-GPU training?

Hi, I am not sure I would have time to do this change in the future unfortunately... I recommend you to try it on your own if you really need it.

Hi, I am not sure I would have time to do this change in the future unfortunately... I recommend you to try it on your own if you really need it.

Ok, thank you very much!
Another question, you recommend testing the results on a few samples of my dataset to check the quality of the output, and modifying the hyperparameters if need be. Could you please tell me how I test the results on a few samples of my dataset to check the quality of the output and where the hyperparameters in?

I meant checking the results visually by looking at a few sample detections and checking that the detections you want are there. I will also release later an evaluation pipeline to evaluate some metrics of the paper.
Regarding the hyperparameters, you mainly need to tune the detection parameters in 'line_detector_cfg' in config/export_line_features.yaml. I would try different values for detect_thresh, inlier_thresh (0.9 or 0.99 should work though), whether you want to use candidate_suppression or not (i.e. using NMS or not), and whether to use the heatmap_refinement or not. You can try with and without it, and keep the ones that seems the best for your application. The explanation of the first two parameters can be found in the original paper.

But the result of step3 is .h5 file, like wireframe_train.h5 file, how can I get visualization result from the .h5 file and further check that the detections I want are there?

There is no ready-made code for this in this repo unfortunately. But it is just a matter of opening a .h5 file and visualizing the images in it. This can be done in just a few lines in Python.

There is no ready-made code for this in this repo unfortunately. But it is just a matter of opening a .h5 file and visualizing the images in it. This can be done in just a few lines in Python.

I tried as you said. For each ground truth, there are seven variables shown in the figure. How can I get the visualization image like the detection results in your paper in the help of these seven variables.

Sorry, I should have given a bit more details. These seven variables should be coming from the output of step 2, no? These are only the raw outputs of homography adaptation. The two main variables are heatmap_prob_mean and junc_prob_mean, which are the averaged line and junction heatmaps.
But after running step 3, you should get a new .h5 file containing the line segments. You can then directly plot them with matplotlib, or using the following function: https://github.com/cvg/SOLD2/blob/71c3243f9d3a695788d0a6bfd134b9849425900a/misc/visualize_util.py#L340.

Sorry, I should have given a bit more details. These seven variables should be coming from the output of step 2, no? These are only the raw outputs of homography adaptation. The two main variables are heatmap_prob_mean and junc_prob_mean, which are the averaged line and junction heatmaps.
But after running step 3, you should get a new .h5 file containing the line segments. You can then directly plot them with matplotlib, or using the following function:
https://github.com/cvg/SOLD2/blob/71c3243f9d3a695788d0a6bfd134b9849425900a/misc/visualize_util.py#L340
.

The .h5 file obtained after running step 3 contain two variables including 'junctions' and 'line_map', the shape of these two variables are 300x2 and 300x300 respectively, but the shape of the input 'lines' in the function 'plot_lines' is 80x2x2, I am confused about this and I don't know how to plot the 'junctions' and 'line_map' by using the function 'plot_lines'.

Have a look at this part of the code: https://github.com/cvg/SOLD2/blob/71c3243f9d3a695788d0a6bfd134b9849425900a/model/line_detector.py#L108
There is an example on this line and the following ones showing how to get the line segments from junctions and line heatmap.

Thank you so much, I have finished the pseudo ground truth visualization according to the method you said. And after the step4 training, I get the visualization results from the trained model on my own datasets. However, the detection results is so bad. The first image is the pseudo ground truth and the second one is detection result. To solve this problem, I observed that the train images in the same scene in wireframe dataset are continuously placed. I would like to ask if there are any requirements for the image placement order in the training set.

Hi, your problem seems to be a scaling problem mainly, it looks like that your predicted lines are rescaled to 1/2 of the image scale, for some reason. So try to upsample their coordinates by 2 to make them fit to the full image.

I am closing this now, feel free to reopen it if you still have issues.


Fiber inheritance refactor

Starting the fiber refactor for different fiber types. Fixed the offset bug in FiberContainer::matvec that caused strange behavior where the velocities of the first fiber overwrote all of the other fibers up to some strange offset.

I merged up ddd21e5 with some edits.
On Wed, May 17, 2023 at 3:37 PM Chris Edelmaier @.***>
wrote:

Starting the fiber refactor for different fiber types. Fixed the offset
bug in FiberContainer::matvec that caused strange behavior where the
velocities of the first fiber overwrote all of the other fibers up to some
strange offset.
You can view, comment on, or merge this pull request online at:
https://github.com/flatironinstitute/SkellySim/pull/24
Commit Summary

608d287
https://github.com/flatironinstitute/SkellySim/pull/24/commits/608d287f6d01dd685524758d4b27182c5fcc294e
Test commit, fixed bug in create_uvsphere for spherical shells in blender
ddd21e5
https://github.com/flatironinstitute/SkellySim/pull/24/commits/ddd21e5f3e84d4798cd7c5b5a432c309f445220a
core: fixed matvec bug with offsets

File Changes
(11 files https://github.com/flatironinstitute/SkellySim/pull/24/files)

M Doxyfile
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-ad99e4a448d7bc3792ea4acfb4c5a9048e2d604b1e9a9613fc39a2dbb53c48a9
(2)
M include/fiber.hpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-0fa9149abd76b11952f0ba5bb3813b3b8584f5d1a072be62ef34f65c58db7c47
(18)
M include/params.hpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-9223d869108700a6bc67156fd0cbb700de7590e46baef5f07028c5fae9e7ccea
(3)
M include/skelly_sim.hpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-5e194a76bb00d5d6db2e225f7058184bf6e30e6edde069ca30800ee7c49aead5
(3)
M scripts/skelly_blend.py
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-e954008a7809d28b8b06fa57c54ebf35451fda54009bb00e05812c764352008c
(2)
M src/core/fiber.cpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-bfafad63f67ec2cb66e182ef40595d04f062b259ab14e0b6767c155a2cca0083
(7)
M src/core/fiber_container.cpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-e646c1a1d33a985b885a24b46e7542f27adf69dd20ed8fbeb58692d06ff64c07
(10)
M src/core/params.cpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-402f95f8b56815165182b7df0f44458b62a3ca927d2c3b013b9d7f4e270bee08
(37)
M src/core/system.cpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-0597dd469f5bb1c5263dda826bbd9526868764ce6bd1e3f16316d040b03e9f57
(17)
M src/skelly_sim.cpp
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-f0c1b11aae44e8bf01be8634995a422ef9ae26055e37414d5643706078f862f9
(3)
A tests/combined/test_fiber_dualfilament.py
https://github.com/flatironinstitute/SkellySim/pull/24/files#diff-0ec7c18a2302b926c71a1dbb7d3a70c233e4131e496492ae87e375fe205098a5
(83)

Patch Links:

https://github.com/flatironinstitute/SkellySim/pull/24.patch
https://github.com/flatironinstitute/SkellySim/pull/24.diff

—
Reply to this email directly, view it on GitHub
https://github.com/flatironinstitute/SkellySim/pull/24, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACY7UUFFE3WKTSO3IT5AP3XGUSHBANCNFSM6AAAAAAYFRKBRA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Convert uls to tables in API page.

The unordered lists don't really look great, nor are they very readable. It would make more sense to format this data as a table.

Should have been closed with #124.


Visual Studio 15.8.5 Qt C++ Project can't see installed libs but a console project can.

I have vcpkg version 0.0.113-nohash
Visual Studio Community 2017 15.8.5
ReSharper 2018.2.3
I successfully cloned, built and ran the integrate install command. I then installed the libraries and started Visual Studio.
I have the QT Visual Studio tools installed and tried creating a sample GUI application. Even when I tried the simple sqlite3 sample, it can't find the header file
#include "stdafx.h"
#include "Techne.h"
#include <sqlite3.h>      --- Says it can't find sqlite3.h in search paths

Techne::Techne(QWidget *parent)
	: QMainWindow(parent)
{
	ui.setupUi(this);
}

void Techne::on_pushButton_clicked()
{
	ui.lineEdit->setText(sqlite3_libversion());
}

Oddly enough, I tried a simple Windows Console Application and it worked. Could the QT VS tools somehow be interfering with the included paths?

you may need to check your project property and see if it is x64.
vcpkg build x86-windows in default as same as a c++ console project in vs, but your default qt version in qt vs tool option may be x64, then your qt project is set to x64 :-).
just switch you qt vs tool option and create a new project.

@willkara, please reopen this issue if it still be a problem for you.


Default voltage and Startup Sequence?

AXP2101.pdf
Is it true that the first time it starts, the DCDC1 voltage will be 3.3 Vdc according to section 7.6 of the datasheet I attached? How will the starting order of the voltages be configured? I don't see instructions in the documentation.
Please help me!

Already replied in other repositories


requestIdleCallback for non-essential code-paths

Anything that's not directly contributing to app-responsiveness should be queued up via requestIdleCallback to avoid blocking the main thread. This goes, in particular, for analytics.
Even if we're not going to refactor all old code right away, we should get in the habit of using this when writing action-creators and when the criteria outlined in [^1] are fulfilled.
This should make our own perform a bit better. :)

[^1]:  concept overview and code example on mdn: https://developer.mozilla.org/en-US/docs/Web/API/Background_Tasks_API
[^2]:  docs on mdn: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestIdleCallback
[^3]: old but exhaustive explanation; by now supported by chrome, ff and opera: https://developers.google.com/web/updates/2015/08/using-requestidlecallback

Depends on whether or not we want that performance gain ^^
I'd put it in the "later" column tho :)

I think for our usecase (the rdfstore) there are more feasible options, either replacing it with a different "caching" mechanism or moving it into a web worker where its executions don't need to be chunked (a requestIdleCallback with a long-running function still blocks the main thread).
We could create a new issue "Remove load from UI thread" and list the options we have in the description.

@peacememories, i am also in favor of creating a new issue (put it in later) reference this issue as a comment here, and close this one after

Closing in favor of #2203 as discussed above


I'm not sure if this is causing any errors

but I'm pretty sure this is a spelling error that would mean format_geometry would never get called.

Coverage increased (+2.44%) to 95.12% when pulling d5c18eaa0b3f9ed4d8e6509e3d3217a2fec5675f on Joshua-Pearson:spelling-mistake into d55754545bbd131a735f3cbd51c621655287f1a7 on ruby-av:master.

Coverage increased (+2.44%) to 95.12% when pulling d5c18eaa0b3f9ed4d8e6509e3d3217a2fec5675f on Joshua-Pearson:spelling-mistake into d55754545bbd131a735f3cbd51c621655287f1a7 on ruby-av:master.


Can not supply port when creating external services

When I create an external service with a specific port, using: rio external create onedotonedotonedotone <IP_ADDRESS>:53, the services does not get created in the background.
When running rio systemlogs I get the following error:
rio-controller | E0614 16:29:11.090083       1 controller.go:117] error syncing 'default/onedotzero': handler stack-external-service-object-controller: failed to create default/onedotzero /v1, Kind=Service for stack-external-service default/onedotzero: Service "onedotzero" is invalid: spec.externalName: Invalid value: "<IP_ADDRESS>:53": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), requeuing

Additionally, is there a way to specify protocols (UDP or TCP) and multiple ports on one service?

This should be fixed in v0.2.0. Please reopen the issue if the latest release doesn't work for you.


Lock on creating redis connections

#253

@JonCole

@JunTaoLuo,
I would recommend that you structure the fix something like the following psuedo-code to avoid lock contention when the connection has already been created.
if (connection is null)
{
    //avoid taking the lock in the cases where the connection
   //has already been created.
    TakeLock();
    {
        if(connection is null)
        {
              CreateConnection()
        }
    }
}

@JonCole Yup that works, I was just talking to @sebastienros about the exact same thing.

@muratg we need to decide whether this goes into 1.0.4 as well.
cc @mikeharder

@JunTaoLuo Please file a separate bug for 1.0.4. (and link it from #253).
Also, we should keep #253 open after this is checked in to dev branch.  For 1.1.1, we'll need to port it to some rel/* branch as 1.1.1 approaches.

The code looks correct.  Personally, I would extract the initialization logic into a helper class, named something like AsyncLazy<T>.  Similar to Lazy<T> in the framework , but supporting both sync and async initialization.  Then the code in this class would just be the following:
private AsyncLazy<IDatabase> _cache = new AsyncLazy<IDatabase>(() => /* sync init code */, () => /* async init code */);

var cache = _cache.Value();
var cache2 = await _cache.AsyncValue();

You shouldn't even need to keep an explicit reference to the ConnectionMultiplexer, since the IDatabase reference will prevent it from being GC.  This change would also eliminate the need to call Connect() before other operations.


Nuxt not working with sound

Hi @Tahul ,
You asked for my experience with nuxt and this package. I tried to get it to work after the latest update, but it seems like it doesn't work. I have a sound in my public folder like this : public/sounds/back.wav

`

`
This is my test component
    modules: ['@vueuse/sound/nuxt'] sound: {     sounds: {       scan: true,     },   },
Did I have something wrong or do I need to change something to get it to work?
Thanks in advance!

Any news on this issue ? Still don't work @Tahul

@louia @ThimoDEV Have you tried setting the config options like this?
defineNuxtConfig({
[...]
},
    sound: {
        scan: './src/public/sounds/',
    },
});

Maybe the readme is wrongly showing the scan: true option being in sound.sounds but needing to be directly in the sound module config at the "top level".
In my case I had to use a string for the path as the module didn't pickup my sounds in a different src dir, but I haven't investigated further than that as it at least generates the types definitions with the config posted.


Move sanity_check

Closes https://github.com/dart-lang/angular2_components_example/issues/2

Ping, @filiph 😄


Small Improvements

Why did it attempt to push to master?

You might want to make the base branch dev-build instead. Also, if you're making changes here, it would be nice if you pushed a PR to LagoLunatic/wwrando too, so that everything ends up in the official randomizer eventually.

Key chest texture change resolved by LagoLunatic#307.


HADOOP-18024. SocketChannel is not closed when IOException happens in Server$Listener.doAccept

Description of PR
HADOOP-18024
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

This is a follow-up for https://github.com/apache/hadoop/pull/2727.
@iwasakims @ferhui We previously had some discussion in https://github.com/apache/hadoop/pull/2727. So if you have time, you can take a look at this new patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 21s

trunk passed

+1 :green_heart:
compile
22m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 46s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 37s

trunk passed

+1 :green_heart:
shadedclient
22m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
21m 56s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
21m 56s

the patch passed

+1 :green_heart:
compile
19m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 45s

the patch passed

+1 :green_heart:
shadedclient
22m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 43s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

199m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3719

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e25179bc9802 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b0f8903268f6d234e15ec004fc7c3661aba2a816

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/1/testReport/

Max. process+thread count
1281 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 58s

trunk passed

+1 :green_heart:
compile
24m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 44s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 35s

trunk passed

+1 :green_heart:
shadedclient
24m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
22m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 30s

the patch passed

+1 :green_heart:
compile
19m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 38s

the patch passed

+1 :green_heart:
shadedclient
22m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 54s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

208m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3719

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5947c8be1a76 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4ba818b7a5cd5aa460cf3401ffff6ace0335901b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/2/testReport/

Max. process+thread count
1267 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani I've pushed a commit for the unit test testIOEOnListenerAccept. I've confirmed that it can pass only if we have this patch.
The inspiration comes from hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java. I leverage some existing scaffolds in TestIPC.java:
https://github.com/apache/hadoop/blob/c0f405a46b402b4bdf5b7771f5124790fc866965/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java#L487-L532
https://github.com/apache/hadoop/blob/c0f405a46b402b4bdf5b7771f5124790fc866965/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java#L420-L425
Then I just override some methods of TestServer and Server$Listener to inject the IOException.
In testIOEOnListenerAccept, the first client call encounters the injection in server and thus gets its socket closed. Hence we expect EOFException. The second client call should work normally.
Any comment or suggestion? Thank you!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 40s

trunk passed

+1 :green_heart:
compile
25m  4s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 51s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
25m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
23m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 27s

the patch passed

+1 :green_heart:
compile
20m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
20m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 12s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 227 unchanged - 0 fixed = 229 total (was 227)

+1 :green_heart:
mvnsite
1m 41s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
22m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 57s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

213m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3719

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 00fa48069eb5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f7540e419293db72caec53323ca20f89d89e95db

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/3/testReport/

Max. process+thread count
1367 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani Thank you for pointing out the checkstyle issue. I've pushed a new commit to resolve it.
To minimize the checkstyle modification, I move the configureSocketChannel method from Server$Listener to Server, so that we can solely override this method to enable the unit test. Server$Listener remains private.
I also add the @VisibleForTesting and @InterfaceAudience.Private annotations.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  4s

trunk passed

+1 :green_heart:
compile
23m 39s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 31s

trunk passed

+1 :green_heart:
shadedclient
22m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
23m  5s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m  5s

the patch passed

+1 :green_heart:
compile
20m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
20m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 227 unchanged - 0 fixed = 228 total (was 227)

+1 :green_heart:
mvnsite
1m 44s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 43s

the patch passed

+1 :green_heart:
shadedclient
22m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 56s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

203m 47s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3719

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 01a1ff19013e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ad029c8d4c3188b88683ae132ed19daeea27764

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/4/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This time, testIOEOnListenerAccept failed. I haven't figured out the reason. The previous CI tests and my location tests always pass. So I added a log for the unexpected error to see what happened.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 27s

trunk passed

+1 :green_heart:
compile
21m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
22m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
21m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
21m 17s

the patch passed

+1 :green_heart:
compile
19m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 227 unchanged - 0 fixed = 228 total (was 227)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 36s

the patch passed

+1 :green_heart:
shadedclient
22m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 30s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

195m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3719

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8fc0cd86018e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f755f5748fb8f60b84e1b3f3b0277f05b433b54a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/5/testReport/

Max. process+thread count
1249 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3719/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Seems better. Thanks @functioner. Once more checkstyle warning is pending related to Javadoc.

@virajjasani Sorry that I overlooked this. I've just pushed a new commit.

Are there any other issues or concern with the current patch and test? If any, I will resolve ASAP. Will this PR be merged soon by any chance?

+1 (non-binding), Thanks @functioner

I merged this. Thanks, @functioner and @virajjasani.


Add ability to see fractional widths on Report tab

Maybe this should be a toggle switch?

Let's just go with two decimal places for now.

This is fixed in commit 59896568e7ec6b97931d0df992fbc8787ff3965a


recognize! can't be used in alt!

I spent a few hours debugging this issue: recognize! contains a return statement and can therefore not be used directly in an alt! statement.
I implemented my own version in my crate without return and it seems to work fine.

Thanks for the report! It is fixed in c60fbaa


Fix parsing of re-export and unquoted string in list

Fix #42
Fix #62

very nice, thanks! you're doing great work with tree-sitter-nu, much appreciated.


Adding @react-native-community/google-signin causes Android app to fail to load.

Adding @react-native-community/google-signin causes Android application to fail to open. And I am unable to find the steps I had to take to fix it documented.
(I am new to RN and Firebase and this package. I apologise in advance if I do not provide the right info in this issue - please let me if there is anything else I need to add.)
Steps to Reproduce
(Omitted from the steps below were many invocations of gradlew clean, and many restarts/wipe data of the Android emulator.)

Create project codebase

npx<EMAIL_ADDRESS>init --template=<EMAIL_ADDRESS>MyApp

Run gradlew signingReport to generate SHA1.

Log into Firebase console and add new Android application to Firebase project.

Download google-services.json to MyApp/android/app

Enable sign-in methods: Email/Password, Google, Anonymous.

npx react-native run-android (SUCCESS!! 😄  Application loads in Android emulator)

npm i<EMAIL_ADDRESS>

npx react-native run-android (SUCCESS AGAIN!! 😄 Application loads in Android emulator)

npm i @react-native-community/google-signin

npx react-native run-android ( 💥 FAILS TO OPEN!! Application fails to start in emulator possibly due to: java.lang.ClassNotFoundException: com.facebook.flipper.ReactNativeFlipper).

Open MainApplication.java and comment out the following line:

initializeFlipper(this); // Remove this line if you don't want Flipper enabled

npx react-native run-android ( 😞 STILL FAILS TO OPEN!! Application fails to start in emulator possibly due to: Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.swiperefreshlayout.widget.SwipeRefreshLayout")

Add the following to build.gradle:

implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0-alpha02'

npx react-native run-android (😄 SUCCESS !! Opens)

Expected Behavior

By adding @react-native-community/google-signin I expected the application to still load.
I expected the documentation to include the steps I had to take to fix this.
Actual Behavior

By simply adding @react-native-community/google-signin as an NPM dependency the application fails to load in Android. logcat is the only way to find out why it failed to load.
Environment
Package.json:
  "dependencies": {
    "@react-native-community/google-signin": "^3.0.4",
    "@react-native-firebase/app": "6.7.1",
    "@react-native-firebase/auth": "^6.7.1",
    "react": "16.9.0",
    "react-native": "0.61.5"
  },

The emulator was running Android 9.0 (Google Play)
Please let me know if there is any further information I can provide.
Thank you for building and maintaining this package!

@vegemite4me hello and thanks for reporting! Can you please let me know if #890 solves this for you?
regarding step 10(java.lang.ClassNotFoundException: com.facebook.flipper.ReactNativeFlipper) that, to me, sounds unrelated.
Please let me know if the mentioned PR sounds like an improvement to you or if you think something else should be updated too, thanks!

Yes looks good. I'll take your lead if you think Flipper is unrelated as I am new to all this. Do you want me to approve the PR? With my little knowledge in all this my approval might not carry much weight. 😄

thanks for confirming, I merged it :)


DE analysis and filter_rank_genes_groups

Hi there,
I am doing a DE analysis using the functions rank_genes_groups and filter_rank_genes_groups.
I noticed that when two groups are compared (I did not check when multiple groups are compared) the parameter min_in_group_fraction of the function filter_rank_genes_groups is used only to filter the first group.
I applied twice the functions rank_genes_groups and filter_rank_genes_groups to filter the calculated genes (I am asking that a gene is expressed in at least X% of cells).
There are mainly two possibilities, namely:

a gene is expressed in at least X% of cells of both groups;
a gene is expressed in at least X% of cells of either group1 or group2.

In Seurat, the function FindAllMarkers has the parameter min.pct that is used to only test the genes that are detected in a minimum fraction of min.pct cells in either group1 or group2.
It would be interesting to include these filtering steps in the filter_rank_genes_groups (maybe both strategies, i.e., both groups and either group1 or group2). What do you think?
Thanks!
Andrea

I just realized that it is the rank_genes_groups function that returns only one group when the reference is set and groups is a list with one element. So, the filter_rank_genes_groups is filtering correctly but it can only filter the only returned group.


🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/index.md

This PR translates the tutorial/dependencies/index.md to Japanese.
Please review tutorial/dependencies/index.md.
~Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.~

@tokusumi
I approved your suggetions! Thank you!

📝 Docs preview for commit fcb10ad3cc7489530f7343338c38e1cf0471ad4a at: https://6499cb4e7bcac500837f92f0--fastapi.netlify.app

As this was handled in https://github.com/tiangolo/fastapi/pull/1958, I'll go ahead and close this one. Thank you! ☕


Add eslint-promise

PR-Codex overview
This PR updates ESLint configuration by adding the eslint-plugin-promise, refactors code formatting in a file, and improves code readability in another file.
Detailed summary

Added eslint-plugin-promise to ESLint plugins
Refactored code formatting function in a file
Improved code readability in another file by updating code logic

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

📝 Changed routes:

/cli/login

(view full size)

Commit a276628dc8cd4aced2fea194fca222e6775f48e2 (https://thirdweb-51cl0butv.thirdweb-preview.com).


WSL2 does not redirect to localhost

What's your CLI version?
0.76.7
Description & steps to reproduce
When I am running containers in my local or cloud, the ports are not redirecting to the localhost or <IP_ADDRESS>
============ User Services =================

UUID           Name          Ports                                              Status

fd97db9a1002   mongodb       mongodb: 27017/tcp -> mongodb://<IP_ADDRESS>:32803    RUNNING

4ff9b3f4228e   novu_api      novu_api_port: 3000/tcp -> http://<IP_ADDRESS>:3000   RUNNING

8fd20e961c72   novu_embed    novu_embed: 4701/tcp -> http://<IP_ADDRESS>:4701      RUNNING

40bde6f5387c   novu_web      novu_web: 4200/tcp -> http://<IP_ADDRESS>:4200        RUNNING

ee7c041bc2e6   novu_widget   novu_widget: 4500/tcp -> http://<IP_ADDRESS>:32804    RUNNING

569d075ba341   novu_worker   <none>                                             RUNNING

9cb48000d596   novu_ws       novu_ws: 3002/tcp -> ws://<IP_ADDRESS>:3002           RUNNING

3d3a4a079e20   redis         client: 6379/tcp -> <IP_ADDRESS>:32802                RUNNING

Desired behavior
When I click the link, it should redirect localhost on my browser.
A temporary solution is: https://superuser.com/questions/1594420/cant-access-127-0-0-180-outside-of-wsl2-ubuntu-20-04
WSL2 uses a virtual network inside so it has an actual IP address on our network.
I was able to connect using that physical address.
What is the severity of this bug?
Painful; this is causing significant friction in my workflow.

Wanted to add a nuance to this problem: that while you can access the services via this virtual network (ip address) that WSL uses, it creates problems when using a browser to connect/access a web server. The web server will provide a URL for the services the client (browser) needs to access inside the enclave and will often use localhost as the hostname. This doesn't work if you instead have to access the services through the WSL virtual network interface.
One example of this failing is: novu-package

@mieubrisse Yes and no: we (@ericobi) was able to access the Novu application through the WSL virtual network adapter ip. Loading the page itself works fine, but any interaction from that website with other parts of the system (like APIs, ws etc.) fails because the services expect each other to be accessible though a deterministic hostname (in this case localhost or <IP_ADDRESS> which does not match the WSL ip).

Hey @ericobi - with the rollout of cloud.kurtosis.com, users can now visit our web-app to view and interact with enclaves created locally or in our cloud. Closing this now as we believe the new offering will enable you to perform this workflow (and more) in a cleaner way. Thank you!


Change Cursor type in Device Settings of teams when in meeting

Current Behaviour: Cursor is text type while in the device settings dropdown.
When?  : During a meeting

Expected Behaviour: Cursor is pointer or hand type.

It's still not fixed


Extended attributes disappear when system is installed to disk

Extended attributes disappear when system is installed to disk.
Compare the output of
% sudo lsextattr user /.url
/.url   url     sha     build

to the output of the same command on an installed system.

is this at fault?
https://github.com/helloSystem/ISO/blob/eaf018ce49ff7ccd897d2e5c9859407380918404/overlays/uzip/furybsd-live-settings/files/usr/local/bin/furybsd-install#L75
Why are we not using zfs send (like the initd does)?

is this at fault?
https://github.com/helloSystem/ISO/blob/eaf018ce49ff7ccd897d2e5c9859407380918404/overlays/uzip/furybsd-live-settings/files/usr/local/bin/furybsd-install#L75
Why are we not using zfs send (like the initd does)?

According to https://forums.freebsd.org/threads/copying-freebsd-to-a-different-disk.55606/#post-315897,

cpdup does not take care of Extended Attributes and ACLs

...which is bad. We should replace it.

According to https://forums.freebsd.org/threads/copying-freebsd-to-a-different-disk.55606/#post-315897,

cpdup does not take care of Extended Attributes and ACLs

...which is bad. We should replace it.

Maybe use tar --xattrs | untar as an alternative?

Maybe use tar --xattrs | untar as an alternative?


fix case

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@66e79bb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6948   +/-   ##
=========================================
  Coverage          ?   77.61%
  Complexity        ?    12294
=========================================
  Files             ?     1536
  Lines             ?    49752
  Branches          ?     5982
=========================================
  Hits              ?    38613
  Misses            ?     8165
  Partials          ?     2974

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e79bb...b7e7b5e. Read the comment docs.


How to design a shell file to specify the num of inserting / deleting key for mongoDB?

In Step 2. Choose the appropriate DB interface layer
$ ./bin/ycsb shell basic
> help
Commands:
  read key [field1 field2 ...] - Read a record
  scan key recordcount [field1 field2 ...] - Scan starting at key
  insert key name1=value1 [name2=value2 ...] - Insert a new record
  update key name1=value1 [name2=value2 ...] - Update a record
  delete key - Delete a record
  table [tablename] - Get or [set] the name of the table
  quit - Quit

How to write a shell file to specify the num of inserting key operations, deleting key?
I know I have workloads/workloadx. However, I need to design mine workload for mongoDB.

mongodb can run with any of the existing workloads. if you want to use the same ratio of operations as an existing workload but a lareger number of keys, you can override just that property.
e.g. for 1m records
$ ./bin/ycsb load mongodb -s -P workloads/workloada -p mongodb.url=mongodb://localhost:27017/ycsb?w=0 -p recordcount=1000000


Update crawled-and-managed-properties-overview.md

Fix #1440

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Re-enable test with ifelse in assignment rules

Given MTK v9.49.0 the tests should work again.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (1b3b84f) to head (5ab5996).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.56%   96.56%
=======================================
  Files          22       22
  Lines        1687     1687
=======================================
  Hits         1629     1629
  Misses         58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add activity log alerts & Log alerts

Activity log alerts
The following document described the activity log alerts limit.

https://docs.microsoft.com/en-us/azure/azure-monitor/platform/activity-log-alerts

In a subscription up to 100 alert rules can be created for an activity of scope at either: a single resource, all resources in resource group (or) entire subscription level.

Log alerts
It is not documented in publicly.

@tksh164 : Thanks for your contribution! The author, @rboucher, has been notified to review your proposed change.

@tksh164  Per our email exchange. Can you change this to 512 for log alerts and call support for max?  I don't seem to be able to submit an update to this PR.

@tksh164 : Thanks for your contribution! The author, @rboucher, has been notified to review your proposed change.

@rboucher Updated this PR. Thanks.

#sign-off


[BVTCK-201] submit compatible value for validation

Squashed the commits and merged.

Thanks Matt. FYI, our convention is to simply use the JIRA issue number in front of the commit message. We don't use square brackets.


Status not updating

When I send a power action to a server, and I try to fetch the resource usage and status, it's not updating.
For example: I send the kill action to a server. On the panel, I can see it's killed, but in my NodeJS application it's not updating. It's already in a setTimeout to give the server time to stop.
Who can help me with this?

Hello there, it will be hard to fix this without showing the code to your project as there can be one of two things

The promises are not being called one after another (Eg, you setServerStatus, then in the .then of that promise youll need to get the server status, as the actual setServerStatus isn't finished until .then of setServerStatus is called)

There is an actual error with pterodactyl returning the wrong status, i dont think its this im pretty sure its #1 but it wont be possible to know without showing some code

By the way you will get faster support on our discord: https://discord.gg/akjNcgyp

I will look into option 1


Update the cryptography dependency to 1.2.3

This fixes the conflicting types for 'BIO_new_mem_buf' error when running with a recent openssl version, e.g. under Alpine Linux. See https://github.com/pyca/cryptography/issues/2750

Current coverage is 83.86%

Merging #162 into develop will increase coverage by +83.86% as of a16cd3d

@@            develop    #162   diff @@
=======================================
  Files             0      19    +19
  Stmts             0     917   +917
  Branches          0       0
  Methods           0       0
=======================================
+ Hit               0     769   +769
  Partial           0       0
- Missed            0     148   +148

Review entire Coverage Diff as of a16cd3d

Powered by Codecov. Updated on successful CI builds.

(I feel silly doing all this for such a simple pull request, but at ascribe have a strong stance on respecting people's intellectual property, and do our best to respect it...)
Hi @roderik
Before we can merge this pull request, which may contain your intellectual property in the form of copyright or patents, our lawyers say we need you or your organization to agree to one of our contributor agreements. If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:

Go to: https://www.bigchaindb.com/cla/
Read the Individual Contributor Agreement
Fill in the form "For Individuals"
Check the box to agree
Click the SEND button

If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:

Go to: https://www.bigchaindb.com/cla/
Read the Entity Contributor Agreement
Fill in the form "For Organizations”
Check the box to agree
Click the SEND button

We will email you (or your employer) with further instructions.

Done!

BEGIN BLOCK
This is to confirm that I agreed to and accepted the BigchainDB Entity Contributor Agreement at https://www.bigchaindb.com/cla/ and to represent and warrant that I have authority to do so.
DU5F0zNNK8vkQGfcpXpbOtavH8hrCI51Ja1bg46wP13t73BMmjIUw1qh1YoFznb


English dates in french opportunity posters

Hey @markwooff. Noticed this today when I toggled to French on an opportunity page:

Is there a way for the dates to be in french format?  E.g. le lundi 22 janvier 2018

These dates will now appear in French formatting on the FR pages!


How to convert datepicker date to mysql date

Sir, I am having problem inserting date in mysql table. I have formated datepicker to display dd-mm-yyyy and mysql needs the date in format yyyy-mm-dd. Can you suggest me how to configure this. I want the date to be displayed in dd-mm-yyyy and converted to mysql format when insert / update.
Please guide.

The datepicker is designed to work that way, so I guess you are doing something wrong.
You can set the format of the datepicker using the following code:
$('#myDatePicker').datepicker({
    format: 'dd/mm/yyyy'
});

This only modifies the format for displaying purposes. The actual value is still a javascript Date object and can be easily parsed to the ISO format or any other format you like:
var date = $("#myDatePicker").datepicker("getDate");
console.log(date.toISOString()); // Logs in the format YYYY-MM-DDTHH:mm:ss.sssZ

However I would advice you to send the javascript date object to your backend and let the serializer do the work. I dislike keeping track of dates as a string.


Add information to "Participants".

I would grab the information from the ISMIR2019 site for the following four categories (and subcategories):
For authors
For attendees
For presenters
For sponsors/exhibitors
Put the information in the ISMIR2020 staging site (https://ismir.github.io/ISMIR2020/) so that the ISMIR organizing committee can edit the content.
After everyone is happy, we will make a pull request to the production site (https://ismir.github.io/ISMIR2020/)

These categories may still be relevant for the redesign of the website in July 2020.


ErrImagePull when using OrbStack k8s

Describe the bug
Custom built docker images cannot be pulled and run with OrbStack k8s.
To Reproduce

Create a custom Docker Image with Dockerfile:

FROM  python:3
EXPOSE  8000
CMD ["python", "-m", "http.server"]

docker build -t server .

Run in OrbStack k8s:

kubectl run server --image=server --port=8000

In new OrbStack k8s pod you should see Status: ImagePullBackOff with logs:

Error from server (BadRequest): container "server" in pod "server" is waiting to start: trying and failing to pull image
Failed with status 1

Expected behavior
No response
Diagnostic report (required)
OrbStack info:
Version: 1.0.1
Commit: 0d4cdcf185489f992cf8e3187884f11f4feab1aa (v1.0.1)
System info:
macOS: 13.0.1 (22A400)
CPU: arm64, 10 cores
CPU model: Apple M1 Max
Model: MacBookPro18,4
Memory: 64 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2023-11-04T19-25-12.906114Z.zip

Screenshots and additional context (optional)
No response

+1
Facing same issue

Kubernetes has imagePullPolicy set to Always by default, meaning that it always tries to pull the latest version of the image from the registry.
Set the policy to IfNotPresent or Never to fix this:
kubectl run server --image=server --port=8000 --image-pull-policy=IfNotPresent


Unable to connect to x3270 terminal from Mac machine

Hello Team,
I am using python 3.9 in my Mac. Also sharing the robot script which I have created to launch the Mainframe x3270 application
MF2.robot.zip
Getting the following error while running the robot script
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/Mainframe3270/x3270.py", line 65, in open_connection
self.mf.connect(self.credential)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/Mainframe3270/py3270.py", line 358, in connect
self.exec_command(command)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/Mainframe3270/py3270.py", line 307, in exec_command
c.execute()
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/Mainframe3270/py3270.py", line 78, in execute
return self.handle_result(result.decode("utf-8"))
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/Mainframe3270/py3270.py", line 91, in handle_result
raise ValueError('expected "ok" or "error" result, but received: {0}'.format(result))

Just fyi, I am running Mocha TN3270 Lite on my Mac for this.

I was trying to assist @sayom88 and it looks like Mocha TN3270 has a different executable name (not x3270) and different argument structure [1]. It also seems there are many different x3270 emulators under MacOS [Here is one reference that notes its executable is c3270]. Thus support for MacOS might complicate things a little...

Hi @samuelpcabral can update on this issue please..

Any progress on this please?

Hello, I have now able to run the x3270 simulator on my Mac. Thanks.

@sayom88 Could you please explain how you get it working?

Hi @sayom88, We are currently dealing with this issue. If you recall any details about how you resolved it, please explain. Thank you!

Hi @vinnus8660 ,
With the newest update we're able to use it on MacOS, if visible = False has been defined.
You do not have a graphical interface but it is working. Kind regards Michael


Audit report link broken

The link is missing a "public" in the url.
Should be: https://github.com/blockstack/stacks-wallet-web/blob/main/public/docs/least-authority-security-audit-report.pdf

Where is this broken URL exactly?

Closed in https://github.com/blockstack/stacks-wallet-web/pull/1383


Evaluate whether we can make miri a rustc backend

Right now miri is a rustc driver, but we may be able to make miri a codegen backend like llvm and cranelift. Not sure what benefits this brings, but it seems to me like miri behaves more like a backend than anything else.

Disadvantages

You have to provide your own metadata loader for rlibs and dylibs (CodegenBackend::metadata_loader). Feel free to copy https://github.com/bjorn3/rustc_codegen_cranelift/blob/169140506366d5aa96967a71b6af98563a9c2988/src/metadata.rs#L1-L59 though.
You have to provide the target feature whitelist yourself by providing the target_features_whitelist for LOCAL_CRATE. (The default list should probably be moved out of the codegen backend though)

Advantages

You can decide which target features are presented to the rust code using #[cfg(target_feature = "...")] by overriding the target_features method of CodegenBackend, or using the default of none. This means you have to worry less about supporting all SIMD intrinsics.

Could we still have all Miri-specific code in this separate repo? I think that helps with making Miri easier to work on.

You can decide which target features are presented to the rust code using #[cfg(target_feature = "...")] by overriding the target_features method of CodegenBackend, or using the default of none. This means you have to worry less about supporting all SIMD intrinsics.

That would be nice indeed! Is there no way to get that effect with a driver? (Or maybe we could have a minimal backend on the rustc side that does just that, but still otherwise keep e.g. all the shims and Stacked Borrows separately in this repo.)

Could we still have all Miri-specific code in this separate repo? I think that helps with making Miri easier to work on.

Yes, all you need to do is compile miri as a dylib exporting the function
/// This is the entrypoint for a hot plugged rustc_codegen_cranelift
#[no_mangle]
pub fn __rustc_codegen_backend() -> Box<dyn CodegenBackend> {
    Box::new(MiriCodegenBackend)
}

then implement rustc_codegen_ssa::traits::CodegenBackend for the unit struct MiriCodegenBackend. Finally to use it you pass -Zcodegen-backend=/path/to/miri.so to rustc.

Is there no way to get that effect with a driver?

Not that I know of. create_session already adds the target features:
https://github.com/rust-lang/rust/blob/40008dcb494a00571123b7d59115068a200ebe34/src/librustc_interface/util.rs#L77
Once that function returns, Session can no longer by modified. (except using unsafe of course, but that would be a stacked borrow violation)

I just thought about another disadvantage that would also be nice to solve for cg_clif: There is no way to accept options that are not already recognized by rustc. In cg_clif, I use env vars as workaround, but it would be nice if it could be real options behind for example a new -X flag.

Would this make it easier to use MIRI as a general-purpose Rust interpreter? I'm wondering if that might be a path toward providing a faster debug/test cycle than Cranelift.

I don't think this has any effect on the usability of miri, all we do is shuffle around a few things in the parts of miri that the user doesn't see.

I'm wondering if that might be a path toward providing a faster debug/test cycle than Cranelift.

Given how slow Miri is, I don't think Miri can fill that niche, even for those libraries/applications where Miri supports all the APIs they use.

@BatmanAoD I have got a WIP branch for cg_clif that lazily compiles functions as necessary in JIT mode: https://github.com/bjorn3/rustc_codegen_cranelift/tree/wip_lazy_jit.

Thanks all! I understand. @bjorn3 that sounds really promising!


⚠ BCR Bot has degraded performance

In 890867f, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 827 ms

Resolved: BCR Bot performance has improved in ebae9ef.


Missing features - grid-node on /etc/hosts

Reported by Ulf

Done in https://github.com/CSC-IT-Center-for-Science/ansible-role-pxe_config/commit/9a0a9c818e86066f17486e81a1ed319fcd1f2e1e


Adds checkboxes for admin control of workspace status in tree view, #307.

Added admin checkboxes controlling isStale and isEligibleForOracle flags on workspaces in tree view.  This reuses the checkbox pattern from the admin checkboxes on the root workspace page.  Similar code is now being used in 4 spots, so might want to factor that out into an AdminCheckbox component.

Thanks!
Looking at the tree, there's some redundancy now:

The indicators and check boxes present the same information. Large trees will be less readable, since the checkboxes take up quite a bit of space.
How difficult would it be to integrate the checkboxes and indicators in a way that lets admins change the status, but also displays the status to non-admins?

Not difficult, just made a commit to do that.  Current caveat is that "is eligible for oracle" is displaying even when not in oracle mode (as opposed to the "Oracle Only" status display).  We can easily make it not display when not in oracle mode if desired.

Just noticed that this displays messily when "Was Answered By Oracle" is displayed as well, fixing now.

Also, as a future PR, I think it would be great to use your approach to refactor the admin controls on the front page: i.e., use updateQuery instead of refetching "RootWorkspacesQuery". This will make those checkboxes much more responsive.


Nydus logs lost in /var/lib/containerd-nydus/logs/

In the early version (v0.4.0) of nydus snapshotter package, the logs of nydusd are automatically output to the /var/lib/containerd-nydus/logs/ directory. So we can check the operation of nydusd according to the method in this document.
grep mirrors /var/lib/containerd-nydus/logs/**/*log

But now these logs are not output by default, which makes it difficult to use in the container environment positioning problem.
Hope to be able to output the nydusd log to the original place by default when the nydus-snapshotter image is packaged.

Can you please print your nydusd command line like ps -ef|grep nydusd

It's because you enabled --log-to-stdout for nydus-snapshotter, which means both nydusd and nydus-snapshotter would print logs to stdout

It's because you enabled --log-to-stdout for nydus-snapshotter, which means both nydusd and nydus-snapshotter would print logs to stdout

Thanks, maybe there is a bug in the helm chart or the snapshotter Dockerfile, I will try to fix it.
Another question is, when --log-to-stdout is not specified, will the log be automatically output to /var/lib/containerd-nydus/logs/?

It's because you enabled --log-to-stdout for nydus-snapshotter, which means both nydusd and nydus-snapshotter would print logs to stdout

Thanks, maybe there is a bug in the helm chart or the snapshotter Dockerfile, I will try to fix it.
Another question is, when --log-to-stdout is not specified, will the log be automatically output to /var/lib/containerd-nydus/logs/?

Yes. It's default to logs


Add a demo profile which should create various elements by default

This profile should start the server with various organizations, projects, resources, tags, etc...

After various tests, this approach seems to be completely flawed and way too complicated. I had to fight against both Spring Security and Spring Data in order to setup things properly with regards to the SecurityContextHolder and the management of transactions.
I don't want to have to manage this, I only want to have default data easily.