FIX: Correctly escape parameters in URL.

Before this, the words containing non-ascii characters (for example "winkel", "artenschutz","fängen" -- see new test case) failed to resolve.

Strange, I tested without URLEncode an d without error with these 3 words : winkel. artenschutz. fängen
	public void testNonAsciiCharactersDE() {
		What3Words w3w = new What3Words(API_KEY, "de");
		String[] words = {"winkel", "artenschutz", "fängen"};
		double[] coords;
		try {
			coords = w3w.wordsToPosition(words);
			assertEquals(2, coords.length);
			assertEquals(49.423903, coords[0]);
			assertEquals(8.282732, coords[1]);
		} catch (Exception e) {
			assertTrue(false);
		}
	}

I added a FR test with
	public void testNonAsciiCharatersFR() {
		What3Words w3w = new What3Words(API_KEY, "fr");
		String[] words = {"noël", "étain", "rizière"};
		double[] coords;
		try {
			coords = w3w.wordsToPosition(words);
			assertEquals(2, coords.length);
			assertEquals(-21.951124, coords[0]);
			assertEquals(166.685219, coords[1]);
		} catch (Exception e) {
			assertTrue(false);
		}
	}

let's see what @chrismayer think about all of that.

According to the comments in the thread: http://stackoverflow.com/questions/10786042/java-url-encoding-of-query-string-parameters, using the URLEncode.encode to encode URL is not the best way to encode query params. It is best explained here: http://stackoverflow.com/a/16226168/3730269
I will send a different merge request with the correct solution to this issue.

Having done some more research on how to escape query parameters with plain Java (not using any external library as I otherwise do), it seems that the solution used in this merge request is probably one of the best.
Surely, it is better that having no encoding of the query params at all. I am therefore reopening this. If somebody finds a better way to encode parameters with plain Java, they can contribute another merge request.


redirect adminbro.com to adminjs.co

Describe the bug
The old website is still showing the old docs instead of the new adminJS docs.
https://adminbro.com/ should take us to https://adminjs.co

I can confirm that I walked into the adminbro documentation first and was using that version of this project for some time before discovering the shift. Any documentation on why the name changed?

adminbro.com now redirects to adminjs.co


CORS rules not being applied to PUT responses

Hello! I'm the author of this issue which was solved on this PR. So first off I'd like to thank you for looking into it.
Some time has passed but only now we've been able to update to the new Moto and try to get rid of our workaround. Unfortunately, the change did not solve the issue for us.
Moto version: 4.1.0.dev0 (Moto standalone server)
How I installed it:
sudo apt install python-pip
pip install "moto[s3]"
pip install flask
pip install flask_cors
Environment: pipenv with Python 3.8.0 running on an Ubuntu 18.04.6 LTS machine.
The original problem was that Moto for S3 accepted GetBucketCors requests but didn't apply the CORS rules later on. We in particular needed to set "ExposeHeaders": ["ETag"] so that Moto would send an Access-Control-Expose-Headers: ETag header in the response. This is because we're using the standalone Moto server and working with a browser controlled by Selenium, and the browser won't let the S3 client running inside it (EvaporateJS) read the ETag if that header isn't present.
In the current version, if we add a CORS rule, Moto takes it into consideration when responding to a CORS preflight request, which is an OPTIONS request. However, our upload still isn't working. After some more investigation and debugging, we came to the conclusion that it's not enough for the browser to receive the Access-Control-Expose-Headers: ETag in the preflight response, the server also needs to provide that header when responding to each individual PUT request that the client does to upload the file parts.
Here's how Amazon S3 responds to our PUT requests when we upload each part:

And here's the same response from Moto:

I used BurpSuite to debug the scenario, and if I add the missing header Access-Control-Expose-Headers: ETag to the Moto response for each part's PUT, it works fine. The header is present in the preflight response thanks to the fix from the PR I mentioned, it's just missing from the PUT response.
I looked a little bit into the code and it looks like the extra headers are added in the _set_cors_headers() in moto/s3/responses.py. This method is only called from _response_options() which handles OPTIONS request. I'm guessing something similar needs to be done in _key_response_put() but I don't have the expertise in this project to do it myself.
Could you please look into this one more time? Thank you very much in advance!!

Hi @dcappellini, thanks for letting us know! I've raised a PR to also return these headers for GET/PUT requests.

This should now be fixed as of moto >= 4.1.12.dev8 @dcappellini  - just let us know if you run into any other issues.

It looks like it works fine now, thank you so much!!


Custom fields in config files ?

Hello,
Is it possible to use development.yaml, production.yaml, staging.yaml to add custom config ?
I see it's possible for passwords.yaml.
I think about smtp config for now.
Have a good day.

That would be a nice addition! I guess it's technically possible to use the passwords file for this until this feature is implemented.

Yes for sure. I'll create a passwords.yaml template without passwords to be able to git push.

An option is also to do the configuration in code, rather than having it in a config file. Or just load a different config file depending on you run mode. You can access the run mode from Serverpod.instance!.runmode. It can be set to one of: ServerpodRunMode.development, ServerpodRunMode.staging, or ServerpodRunMode.production.

Thanks. Good to know Serverpod.instance!.runmode.

I can see this is already implemented in serverpod 1.1.0 , I think this issue should be closed

It seems it's not yet implemented if I'm not mistaken. I think this would be very cool to have.


Integration of Azure Application Insights

Integrate Application Insights info code
Ensure budget controls applied to Subscription

This should be optional for other implementations


Updating stuff

@costrouc, @tylerpotts, @dharhas,
I have created several PRs to update stuff.

Upgrade Dask-Gateway to v0.9.0: #315 and qhub-terraform-modules-37
Upgrade Jupyterhub to v0.11.1: #318 and qhub-terraform-modules-38
Update Docker images to Ubuntu 20.04, Jupyterlab 3, other minor changes: #319

Each PR was tested individually, also the PRs were merged and tested together.  Testing was performed via Kubernetes in Docker (kind).
Notes for upgrading existing clusters:
Existing qhub config files need to be updated to appropriate image tags and dask versions.
Terraform initially failed to update the helm charts in place, however to successfully upgrade a previously deployed cluster I simply had to uninstall the existing helm charts and then Terraform was able to deploy the new versions successfully.
The most pressing pain point I am trying to solve is being stuck on an old version of Dask.
What needs to happen from here to get these PRs reviewed and merged?  I would like to keep this moving forward and am happy to assist however I can.

@brl0 Thanks for the PRs!
@aktech Has some time over the next few days, and will be focused on merging #287 and then figuring out the dask gateway story.
With dask gateway, @costrouc has mentioned a few times that removing helm was a pre-requisite. It looks like you may have found a workaround, but I want to double with Chris before making any architectural decisions. I've created #322 to track that.
As for #319, I'll bring this up in our Tuesday internal sync. Upgrading to Jupyterhub 3, in particular, could potentially break things and I'd like to get some more input before making that step.
Thanks again! I'll get back to you here when I have more information

@tylerpotts,
Thanks for the response and the update, I really appreciate it.

Upgrading to Jupyterhub 3, in particular, could potentially break things
Based on my testing Jupyterlab 3 seems to work without issue even with the version of Jupyterhub (0.9.0-beta.3) currently in use by qhub.  That particular PR (#319) is a stand alone and can be considered separately from any of the other PRs I have submitted.

I'd like to get some more input before making that step.
Understood, no problem.

Most of the updates have been completed or are irrelevant, closing.


Fix type of createjs.Ticker.paused

The type of createjs.Ticker.paused property was declared as "number" when it should be "boolean".

@jsaelhof Thanks mate!


feat(pci.instances): warn about extra bandwidth cost

@marie-j Is there any internal ticket reference related to this pull request?
Thanks!


Missing trailing comma in struct causes subsequent comment to be moved

Both in relation to defining and instantiating structs, if the last field does not have a trailing comma, then rustfmt inserts one. However, if a comment is subsequently present, then it is moved up as well.
If the comma was already present, then the comment is not moved.


An in-line variable can break the CSS rule

In the last version of Polymer paper-spinner the animation was updated. Now it contains a CSS variable. Like you can see in this issue, the minification removes the space after the value of the variable.

I believe this is a duplicate of #780, isn't it?

Yes! I didn't found this issue... 🍻

👍


ion-input with FormControl doesn't enable/disable

Ionic version:  (check one with "x")
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
Current behavior:
When using FormControl / Reactive forms, I can't enable/disable an ion-input but a plain html input works fine.
Expected behavior:
...to work like the plain one.
Steps to reproduce:
https://stackblitz.com/edit/ionic-aqjjpy
Related code:
see stackblitz

Other information:
When I inspect the inputs, I can see disabled being added/removed from the plain input when toggling, but the ion-input doesn't change.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages:

    @ionic/cli-utils  : 1.10.2
    ionic (Ionic CLI) : 3.10.3

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.4
    Cordova Platforms  : ios 4.3.1
    Ionic Framework    : ionic-angular 3.6.1

System:

    Android SDK Tools : 24.4.1
    ios-deploy        : 1.9.2
    ios-sim           : 6.0.0
    Node              : v6.11.2
    npm               : 5.4.2
    OS                : macOS Sierra
    Xcode             : Xcode 8.3.3 Build version 8E3004b

Hello! Thank you for opening an issue with us! We will look into this.
Thank you for using Ionic

I updated the StackBlitz with another related issue. The third input doesn't look disabled even though it has been in the code. Once you click on it, it greys out.

same error
ionic info
@ionic/cli-utils  : 1.9.0
ionic (Ionic CLI) : 3.9.0

global packages:
Cordova CLI : 7.0.1

local packages:
@ionic/app-scripts : 1.3.12
Cordova Platforms  : none
Ionic Framework    : ionic-angular 3.5.0

System:
Node : v6.10.3
npm  : 5.5.1
OS   : Windows 10

+1


Updates val webhook selector to reduce invocations

Changes
When we install net-istio with serving, multiple validating
webhooks are registered.
Previously, the webhooks were configured with just namespace
selectors that are identical. Thus when config-istio is updated,
the serving webhook is invoked (which is a noop) and vice-versa
for any serving config maps.
To avoid this, this PR updates the validating webhook to use an
objectSelector and includes an extra label (component:net-istio)
to further distinguish net-istio resources from serving resources.
/kind cleanup
Part of https://github.com/knative/serving/issues/12594
Release Note
Updates net-istio validating webhook to use an objectSelector to reduce unnecessary webhook invocations

Docs

/lgtm
/approve


AttributeError: 'Table' object has no attribute 'data', and how to convert to a pandas dataframe

Hi! I'm currently following the README document, and whenever I run data = tables[0].data, it's returning the error:
AttributeError: 'Table' object has no attribute 'data'

My .numbers file currently contains two (2) tables -- Table 1 has only 2 rows filled, while Table 2 is empty. I tried different workaround to fix it (i.e. modifying my .numbers file from my iOS device and all), but it's still returning said error.
Also, would anybody here know how to convert .numbers to a pandas dataframe? That's my end goal actually. Thanks!

I think there’s an error in the README. It should be data().

On Dec 29, 2021, at 8:28 AM, Oshean Lee Garonita @.***> wrote:

Hi! I'm currently following the README document, and whenever I run data = tables[0].data, it's returning the error:
AttributeError: 'Table' object has no attribute 'data'
My .numbers file currently contains two (2) tables -- Table 1 has only 2 rows filled, while Table 2 is empty. I tried different workaround to fix it (i.e. modifying my .numbers file from my iOS device and all), but it's still returning said error.
Also, would anybody here know how to convert .numbers to a pandas dataframe? That's my end goal actually. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

@semireg also tried it too, and not working also.

@osheanlee since the return value of data() is a list of lists, you should be able to pass it straight to pandas like this:
from numbers_parser import Document
import pandas as pd

doc = Document("tests/data/test-1.numbers")
sheets = doc.sheets()
tables = sheets[0].tables()
data = tables[0].rows(values_only=True)
df = pd.DataFrame(data, columns=["A", "B", "C"])
print(df)

I've pushed changes to the Readme (not on PyPI yet) for the correct method to extract all data, which is rows()

I've also added the pandas example to the README. Holler if you spot any issues.

I've also added the pandas example to the README. Holler if you spot any issues.


Add a license to the project?

Howdy! Love this game. Was curious if you may add a license to this repo so others can use it as well.? That would make it so that others can use it without worries you might sue them😆
Here’s how to add a license: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
Thank you so much !! :)

Hi! Thanks for the suggestion. I've added a license (MIT), so feel free to use the code in your project! :) Have a nice day.


Remove semicolons to remove gcc -Wpedantic warnings.

Fixes #5

@wally-the-cartographer merge

Merge requested by authorized user cschuet. Merge queue now has a length of 1.


Consumer is not able to poll and process valid messages when a lot of invalid messages occurred

Hi,
I try to understand how parallel-consumer works and I found one case which is not clear to me. I'm not sure if it's an expected behavior or bug.
I have prepared an environment with 1 kafka broker, 1 topic and 3 partitions. There is 10000 events in this topic, with 5 different keys. 1 key is treated by my custom logic as invalid and an exception will be thrown when consumer will try to process message with this key. So there will be around 2000 messages with this invalid key.
ParallelConsumer config with example message handling:
var options = ParallelConsumerOptions.<String, String>builder()
        .ordering(KEY)
        .maxConcurrency(12)
        .consumer(kafkaConsumer)
        .commitMode(PERIODIC_CONSUMER_SYNC)
        .build();

ParallelStreamProcessor<String, String> parallelConsumer = ParallelStreamProcessor.createEosStreamProcessor(options);

parallelConsumer.subscribe(of(inputTopic));

parallelConsumer.poll(context -> {
    if (ERROR_KEY.equals(context.key)) {
       throw new RuntimeException()
   }
   messageHandle.saveToFile(context)
});

I've expected that 8000 messages will be processed correctly and 2000 will not. But in this case, only 504 messages were processed correctly and application is not able to process more. Why this happened? I noticed that this behavior occurred only if there is a lot of invalid messages.
If my description is not clear to you, I can prepare and publish a sample project with this case.

@kapmati can you supply the reproducible code and we will investigate.
thanks

@kapmati may I know what is the distribution of the invalid message?
Since parallel consumer will retry failed message forever if you don't catch them

Closing as seems stale.
@kapmati please reopen with any new info


Prevent duplicates in keywords in package.json

I sometimes accidentally write the same keyword twice.

Good idea! Thanks for the suggestion.


Create a servlet-only release (no container)

A separate release without the bloat or possible conflicts caused by having Jetty would be convenient.

no one seems to have asked for this so closing.


Details Missing

Hi there,
I have now noticed that this page is missing a lot of information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1de935ce-1b09-28e1-3d57-7993891973a8
Version Independent ID: 1e5178a1-e518-b6d0-3074-0a9cf2eab664
Content: Get-CsAdditionalInternalDomain (skype)
Content Source: skype/skype-ps/skype/Get-CsAdditionalInternalDomain.md
Service: skypeforbusiness-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@officedocsbot assign @yogkumgit

Hello @TheWatcherNode thanks for your feedback.
I created a pull request to add the missing details.
Thank you

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @TheWatcherNode Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Changed jackson databind version to <IP_ADDRESS> and kotlin and jacoco ve…

Signed-off-by: Mohit Kumar<EMAIL_ADDRESS>Description
Jackson databind version changed to <IP_ADDRESS> , kotlin version changed to 1.6.0 and jacoco version changed to 0.8.7
Issues Resolved
https://t.corp.amazon.com/V739021076
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #605 (703dba2) into 1.x (98cf601) will decrease coverage by 0.46%.
The diff coverage is n/a.

:exclamation: Current head 703dba2 differs from pull request most recent head a61e09e. Consider uploading reports for the commit a61e09e to get more accurate results

@@             Coverage Diff              @@
##                1.x     #605      +/-   ##
============================================
- Coverage     71.32%   70.85%   -0.47%
- Complexity      900      961      +61
============================================
  Files           139      141       +2
  Lines          4453     4560     +107
  Branches        525      506      -19
============================================
+ Hits           3176     3231      +55
- Misses          956     1000      +44
- Partials        321      329       +8

Impacted Files
Coverage Δ

...ch/replication/task/CrossClusterReplicationTask.kt
77.92% <ø> (-6.29%)
:arrow_down:

...rch/replication/action/status/ShardInfoResponse.kt
35.29% <0.00%> (-39.49%)
:arrow_down:

...lin/org/opensearch/replication/util/Injectables.kt
71.42% <0.00%> (-28.58%)
:arrow_down:

...arch/replication/metadata/UpdateMetadataRequest.kt
77.27% <0.00%> (-22.73%)
:arrow_down:

...ication/action/status/ReplicationStatusResponse.kt
47.27% <0.00%> (-15.23%)
:arrow_down:

.../action/status/TransportReplicationStatusAction.kt
79.34% <0.00%> (-15.10%)
:arrow_down:

...h/replication/task/index/IndexReplicationParams.kt
77.77% <0.00%> (-14.53%)
:arrow_down:

...lication/action/status/TranportShardsInfoAction.kt
83.33% <0.00%> (-13.22%)
:arrow_down:

.../replication/metadata/store/ReplicationMetadata.kt
62.96% <0.00%> (-12.37%)
:arrow_down:

...ch/replication/task/autofollow/AutoFollowParams.kt
84.21% <0.00%> (-10.24%)
:arrow_down:

... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Input connector pinout mismatch

https://github.com/FrameworkComputer/Mainboard/blob/main/Electrical/Pinouts.md#input-cover-interface=
Pins 30 and 32 are both KBL_P, looks like a copy-paste error, one of them ought to be KBL_N

GND is the other end of KBL_P.  Two pins are used due to the potential current needs.

o h
thank you, wonderful to know - I almost made a board that would've been faulty! fixing!


feat: Support for multiple identity certificates

Closing because we decided to abandon this approach in favour of #219.


Can I still use this library with JDK8?

Hi @alexeyOnGitHub
I see you raised the compatibility level to 11, but I did not see where 11 was necessary. Is it possible to downgrade back to 8 so I could still use it without upgrading my project to JDK11?

I see now where you needed JDK11.


[Bug] Anchor seems not working with french accents

Is this a regression?
No
Description
I completely forgot to raise this bug I encounter since the beginning of the project 😜
I have anchor like this:

Sélection par défaut (optionnel)

In markdown, it is:
#### Sélection par défaut (optionnel)

When I click on the anchor to share it, here is how it is translated inside the URL:
http://localhost:4200/one-libraries/one-theme/radio#s%25C3%25A9lection-par-d%25C3%25A9faut-optionnel
And when I refresh the page, it does not scroll directly to this specific title.
Did I do something wrong ? Or is it something you have to handle ?
Thank you in advance for your help 😄
Please provide the exception or error you saw
No response
OS
Windows
Browser
Chrome
Node version
20.13.1
Anything else?
No response

I am unable to reproduce the bug where the page does not scroll to the header after refreshing. Do you have a demo where I could see this?
This bug was present before, but it was resolved within #172

My bad, I was on the previous version just before this fix :)
Sorry for the inconvenience!

My bad, I was on the previous version just before this fix :)
Sorry for the inconvenience!

No problem! 🙂


Is your kabsch_rmsd calculation wrong?

https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/box_dimensioner_multicam/calibration_kabsch.py
I looked at the principle of the Kabsch algorithm and found that your RMSD calculation is not correct: you only calculate the rotation matrix, but not the translation vector, and then calculate the RMSD. I don't know why.

All code history is public on github, you are welcomed to reach out to the authors.
However, the example is trying to demonstrate how to work with the camera and not how to correctly implement any particular algorithm.


Redis cluster discovery on unhealthy

Description:
Added options to refresh topology after failure or host degraded events. This is useful for when the cluster is scaling down or when a node failed or replaced.
Risk Level: Low
Testing: Added unit tests
Docs Changes: Yes
Release Notes: Yes

@FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg please take a first pass.
/wait


Update contributors.yml

original template: https://github.com/github/contributors?tab=readme-ov-file#example-workflows

do we need this step too:
      - name: Get dates for last month
        shell: bash
        run: |
          # Calculate the first day of the previous month
          start_date=$(date -d "last month" +%Y-%m-01)

          # Calculate the last day of the previous month
          end_date=$(date -d "$start_date +1 month -1 day" +%Y-%m-%d)

          #Set an environment variable with the date range
          echo "START_DATE=$start_date" >> "$GITHUB_ENV"
          echo "END_DATE=$end_date" >> "$GITHUB_ENV"
          ```

- name: Get dates for last month
    shell: bash
    run: |
      # Calculate the first day of the previous month
      start_date=2023-01-01

      # Calculate the last day of the previous month
      end_date=$(date -d "$start_date +1 month -1 day" +%Y-%m-%d)

      #Set an environment variable with the date range
      echo "START_DATE=$start_date" >> "$GITHUB_ENV"
      echo "END_DATE=$end_date" >> "$GITHUB_ENV"


Lazy initialization of massive models

Initialize a model that takes no host or CPU memory (for cases where the model is larger than the host memory)
Replay the operations that were played while initializing a model or a partition of the model

Reading

Current best practices to initialize massive (50B parameter+) models #16944 [[link]](https://github.com/Lightning-AI/lightning/discussions/16944)
LazyTensor: combining eager execution with domain-specific compilers [link]
Initialize a model with 100 billions parameters in no time and without using any RAM [[link]](https://huggingface.co/docs/accelerate/v0.11.0/en/big_modeling)
Section 3.1 Model Initialization, in PyTorch FSDP: Experiences on Scaling Fully Sharded Data Parallel [link]

Hello, please assign this to me.


Update item in document array

hello arangotans
playing on the solution to this issue
problem: update an item, in an array, on a document
sample document:
 {
   music: [
     { id: 2pac },
     {id: nipsey},
     {id; mozzy}
   ]
}

my query
   aql`
          LET doc = DOCUMENT(${collectionName}/${thisDocKey})
          let itemId = ${itemId}
          let obj = ${obj}
          let prop = ${prop}
          FILTER doc[prop][*].id == itemId
          let updated = (
            FOR item in doc[prop]
            return MERGE(item, obj)
          )
          UPDATE doc WITH { [prop]: updated} in ${db.collection(collectionName)}
          RETURN UNSET(doc, "_key", "_id", "_rev")
        `

I also tried this one with the filter inside the subquery
   aql`
          LET doc = DOCUMENT(${collectionName}/${thisDocKey})
          let itemId = ${itemId}
          let obj = ${obj}
          let prop = ${prop}
          let updated = (
            FOR item in doc[prop]
            FILTER item.id == itemId
            return MERGE(item, obj)
          )
          UPDATE doc WITH { [prop]: updated} in ${db.collection(collectionName)}
          RETURN doc

        `

neither query throws an error, but neither query actually does what its suppose to.
obviously its an error with arango, and not my query ;)

was receiving an error

this indeed works in directly in the arango web interface query thing
LET doc = DOCUMENT("Paths/account-collectors")
let itemId = 'base'
let obj = { wtf: 'yo' }
let prop = 'strategies'

let updated = (
FOR item in doc.strategies
FILTER item.id == itemId
return MERGE(item, obj)
)
UPDATE doc WITH { [prop]: updated} in 'Paths'
RETURN doc

but fails when I use the node arango thing

if anyone else arrives here thinking wtf the solution was definitely thinking about the returned error.
in node you have to declare the variables within the aql template
working query:
aql`
          let colName = ${collectionName}
          let key = ${thisDocKey} // <---
          LET doc = DOCUMENT(colName,key) // <---
          let itemId = ${itemId}
          let obj = ${obj}
          let prop = ${prop}

          let updated = (
            FOR item in doc[prop]
            FILTER item.id == itemId
            return MERGE(item, obj)
          )
          UPDATE doc WITH { [prop]: updated} in ${db.collection(collectionName)}
          RETURN doc

        `

IS there a better way to do what im doing here?

@jsteemann ^^

ps, always return NEW mf

ps read this https://www.arangodb.com/docs/3.6/aql/examples-data-modification-queries.html


How to Play Ads from a VAST URI Before Content is Loaded in Shaka Player?

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v4.3.7
Question: I am trying to play ads from a VAST URI before the content is loaded in Shaka Player, using the code below:
let vastURI = 'https://raw.githubusercontent.com/InteractiveAdvertisingBureau/VAST_Samples/master/VAST%203.0%20Samples/Inline_Companion_Tag-test.xml';
player.load(vastURI).then(function() {     console.log('The AD has been loaded!'); }).catch(function(error) {     console.error('Error code', error.code, 'object', error);     loadContent(player, manifestUri); }); player.addEventListener('adended', function() {     loadContent(player, manifestUri); });
However, the VAST URI I am using requires authorization, so I am using a sample link for testing purposes. When I run this code, Shaka Player sends a HEAD request to the VAST URI, but there is no response, resulting in the error message 'failed to load response data: no data found for resource with given identifier.' I have tried changing all the HEAD requests to GET requests in the  shaka-player.ui.js file, and this allows me to retrieve the XML response, but the ads do not play.
The issue is that Shaka Player sends a HEAD request to retrieve the VAST URI content, and although the request returns a 200 status code, there is no response in the network tab. When Shaka Player sends a GET request, it is able to retrieve the response from the VAST URI, but is unable to play it.
In contrast, other players such as JW Player allow the VAST URI to be added to the player configuration with a simple tag. I would like to know what is the configuration for Shaka Player to play ads from a VAST URI before content is loaded.
I am able to retrieve the XML response from both URLs using the GET and HEAD method in curl, but I am unable to do so in Shaka Player.

I found the answer in Shaka's document. I used the client-side approach described there, and it successfully displayed the ads
// Load the VAST URI
const adManager = player.getAdManager();
const container = video.ui.getControls().getClientSideAdContainer();
adManager.initClientSide(container, video);
const adsRequest = new google.ima.AdsRequest();

adsRequest.adTagUrl = 'https://raw.githubusercontent.com/InteractiveAdvertisingBureau/VAST_Samples/master/VAST%203.0%20Samples/Inline_Companion_Tag-test.xml';
adManager.requestClientSideAds(adsRequest);
adManager.addEventListener(shaka.ads.AdManager.AD_STARTED, () => {
  console.log('An ad has started');
});
// console.log(shaka.Player.version);

player.load(manifestUri).then(function() {
  // This runs if the asynchronous load is successful.
  console.log('The video has now been loaded!');
}).catch(onError);

}
But there is another problem:
$(document).ready(function () {     $('video').on('ended', function () {       location.replace("/player");     });   });
I want to redirect to another page when the main video ends, but the above code is also running when the ads end. I only want it to run for the main video.

It solved with following code:
$('video').on('ended', function () {
if (this['title'] == "Advertisement") {
return;
}
location.replace("/player/{{next_video.id_base64}}{{query_param}}");
});
:)


attempt to call method 'watch' (a nil value)

** attempt to call method 'watch' (a nil value)**

** attempt to call method 'watch' (a nil value)**
** attempt to call method 'watchdir' (a nil value)**
the same to watchdir

please take a look at this test case, confirm you are using with right way:
https://github.com/iresty/lua-resty-etcd/blob/5e3037f94d3fd350e7d6ce1d29f93d93edc6d522/t/v3/key.t#L125
if you still have a problem, please provide your mini case.

please take a look at this test case, confirm you are using with right way:
https://github.com/iresty/lua-resty-etcd/blob/5e3037f94d3fd350e7d6ce1d29f93d93edc6d522/t/v3/key.t#L125
if you still have a problem, please provide your mini case.
my code:

please take a look at this test case, confirm you are using with right way:
https://github.com/iresty/lua-resty-etcd/blob/5e3037f94d3fd350e7d6ce1d29f93d93edc6d522/t/v3/key.t#L125
if you still have a problem, please provide your mini case.

please take a look at this test case, confirm you are using with right way:
https://github.com/iresty/lua-resty-etcd/blob/5e3037f94d3fd350e7d6ce1d29f93d93edc6d522/t/v3/key.t#L125
if you still have a problem, please provide your mini case.

`local etcd, err = require("resty.etcd").new({protocol = "v3"})
local body_chunk_fun, err = etcd:watch("/4c",{timeout = 0.5})
if not body_chunk_fun then
ngx.say("failed to watch: ", err)
end
local idx = 0
while true do
local chunk, err = body_chunk_fun()
if not chunk then
if err then
ngx.say(err)
end
break
end
idx = idx + 1
ngx.say(idx, ": ", require("cjson").encode(chunk.result))
end
`
The log:
2020/02/21 22:20:53 [info] 1565#1565: *1127 [lua] v3.lua:502: request_chunk(): http request method: POST path: /v3beta/watch body: {"create_request":{"key":"LzRj"}} query: nil, client: <IP_ADDRESS>, server: localhost, request: "GET /gray HTTP/1.1", host: "<IP_ADDRESS>" 2020/02/21 22:20:54 [error] 1565#1565: *1127 lua tcp socket read timed out, client: <IP_ADDRESS>, server: localhost, request: "GET /gray HTTP/1.1", host: "<IP_ADDRESS>"
web
1: {"created":true,"header":{"raft_term":"4","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"18"}} timeout

the error log is info level, we can ignore it.
if you use watch API, you need to confirm your data in etcd is a JSON value.
please take a mini case like this one: https://github.com/iresty/lua-resty-etcd/blob/5e3037f94d3fd350e7d6ce1d29f93d93edc6d522/t/v3/key.t#L125
We do not know what is the value in your etcd.  If you need help, please provide an example that can reproduce the problem.


Always-passthrough offset buffer

A version of #3992 which is always cow=False
Fuzz tests are less relevant because their purpose was to test CoW logic agains naive copy when cow and slice when not cow and now there isn't really much to test

I've wrote in #3992 why i think that copy on write by default approach is better but it's arguably also less clean so yeah

I've been very busy recently and can't finish it - @geohot can you unlock the bounty?


Does not work with Elixir 3.0

I believe 3.0 has some API changes for extension creating: https://github.com/laravel/elixir/releases
Error when I run gulp:
module.js:340
throw err;
^
Error: Cannot find module 'laravel-elixir/ingredients/commands/Utilities'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/path/to/project/node_modules/laravel-elixir-livereload/index.js:3:17)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)

Oh no! Nice find.
I can look into this.
Also I should add elixir to this package too so hopefully it will warn you if you start upgrading further than I have been.

+1

I didn't have a great test case for this. I haven't quite bumped my projects up to these new versions yet.
@drehimself  and @LoveAndHappiness could you take some time to try this fix out and let me know if it works as well as it had. Lots to improve upon but I think that can be the next step.

@EHLOVader
I updated my package.json file so laravel elixir is version 3.0.0 and this package is version 0.0.5. Ran a npm update and getting the following error upon trying to run gulp:
/path/to/project/gulpfile.js:16
mix.livereload();
^
TypeError: Object # has no method 'livereload'
at /path/to/project/gulpfile.js:16:9
at Elixir (/path/to/project/node_modules/laravel-elixir/index.js:20:5)
at Object. (path/to/project/gulpfile.js:14:1)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:108:3)

Sorry I haven't had a chance to update the readme but I bumped versions to allow for backwards compatibility with L4.x/Elixir 2.x on the 0.x version of this extension...  Change the package.json to use ~1.1.0 for this from now on.

Uhm, er perhaps I also forgot to publish. Check back in a few minutes.

Thanks @EHLOVader it's working now.
Note I had to set laravel-elixir (^3.0.0) to be a dependency and not just a dev dependency in my package.json file.
{
  "private": true,
  "devDependencies": {
    "gulp": "^3.8.8",
    "laravel-elixir-livereload": "1.1.0"
  },
  "dependencies": {
    "laravel-elixir": "^3.0.0"
  }
}

Laravel Elixir was previously just a dev dependency before. Looks like new versions of laravel are including it as a dependency, so it should be all good. Thanks again for updating your package, I can't see myself not using it!


added my bookmarks plz merge

I have added my twitter bookmarks . Plz merge

added twitter bookmarks

Great @harinadh76

Thank You


Ddu:uiDone is triggered only once

Problems summary
Following :h ddu-ui-ff-fqq-25, I set autocmd like bellow.
autocmd User Ddu:uiDone ++nested call ddu#ui#async_action('openFilterWindow')

First, calling ddu#start() work fine. Filter window is automatically opened.
However quit the ddu window and then re-call ddu#start(), filter windows does not appeared.
It seems that Ddu:uiDone event was triggered only once.
Expected
Ddu:uiDone should triggered evey time ddu#start().

How to reproduce the problem from neovim/Vim startup (Required!)

Start vim with vim -u min.vimrc -N min.vimrc or nvim -u min.vimrc min.vimrc
Press L to open ddu. Filter window automatically opened.
Press <Esc> to leave filter windows and q to quit ddu.
Press L again. Filter window does not appear.
:message shows only one line Ddu:ui Event!. Ddu:uiDone event triggered only once.

Fixed.  Please update ddu.vim.

Confirmed. Thanks


Permissions related question

Hi there,
FYI : I have added the same question on Gogs official repo as both projects are linked.
Not really a bug but a question about the permissions : they are not very clear to me, am I the only one?
I want to use Gogs as a private repositories hosting app. When installing Gogs, I have set in the options that Gogs is private, no registration, no public page. This part works.
I have created an organisation named MyOrg and I have created 10 repositories whose owner is MyOrg (not me). When visiting the "Explorer" page as me (admin), I can list my 10 repos.
Then I have created a team MyTeam in MyOrg with write permission in which I have added an user "user1". And I have created another user "user2" with no team.
When logging as "user2", this user could see the 10 repos in "Explorer". I was at first surprised because this user does not belong to any organisation nor team then I realized that I had to set "Private" in the repo settings. Doing so, "user2" could not see any repo any longer, which was good.
When logging as "user1", this user could not see any repo in "Explorer" despite it belongs to the team in the organisation. Also, even when browsing on the organisation page, it could not see any repo.
Once again, I realized I had to manually add each repo to the team and this is weird and time consuming. Doing so, the "user1" can now see the repos from the organisation page (but not from the "Explorer" page, which is weird). So I got to the point where my 10 repos are owned by me (Owner) and as a duplicate by the team (MyTeam). Plus adding a repo to a team is not very user-friendly as you must remember the name of the repo for autocompletion (so I did this in the database directly).
Finally, I was really surprised when I realized that me (Owner and admin) could not see any repo in Explorer any longer. I had to go through the organisation page.
Taking Bitbucket as an example, it is not the way Bitbucket works. Once a team is affected to an organisation, the team has permission to list and/or write (according to the given permission) on all repos of this organisation. It is not required to manually affect each repo to the team as these repos are already affected to the organisation. Plus, on Bitbucket, when listing the repos, it will output all the repos you have access to. I don't understand why the "Explorer" page is now empty.
Is there anything I missed?
Sorry for the long post, wasn't easy to be shorter.
Thanks
Axel

"why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough"
By example, in our company : we don't want that repo A was visible from users who only have read permission on repo B. We also use this feature to hide a lot a repos from trainees or to hide "non android" projects to Android developpers.

^
The same word private which has different meaning.

Hello,
"why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough" ==> my mistake I did not finish this sentence, I forgot to get rid of it prior to posting...
Yes, that's my point. I have my internal devs, they are in my team and can access all repos of my organisation.
But I also have external devs on particular projects and they must have access to one given repo (which works well when adding the user directly in the repo settings). But same issue for external devs : even if they have access to a repo, this repo doesn't show up in the Explorer.
That's why I use private repos on my org. So the two issues I can see here are :

why doesn't the Explorer list all repos you have access to?
why a team member cannot list all repos of a given organisation?

Thanks

I add a comment in the issue because it is related :
because my users can't see anything in the Explorer page, they also can't use the search engine.
Plus, because all the repos are ordered by updated date, it is a pain to find a repo : I have to browse all the pages, one by one, to find the repo I'm looking for. I have 50 repos so far and more are coming. It's frustrating.
So my guess would be to :

allow users to order repos by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie)
allow users to browse all the repos they have access to in the Explorer page (not only the public one)
therefore, allow users to use the search engine (not only for public repos but all repos they have access to).
allow all users of a given team to access (read, read/write or admin according to the team permission) to all repos of the organisation owning the team, no matter the repo belong to the Owner of the organisation or to the team. This point is actually quite weird in term of functionality by the way, because when adding a repo, I did set the owner to "MyOrg" in the select list but in reality, the repo is assigned to the "Owners" team of the "MyOrg" org, not directly to the "MyOrg" organisation like I asked.

That would make me very happy and I can't imagine I'm the only one. I'm a good web developer and CTO and I'm mad at myself I don't know a thing about Go. I know exactly what should be modified and where in the sources, line by line, but it will take me so much time to do so... :(
Thanks a lot

I'm almost done with:

allow users to order repos anywhere by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie)
allow users to browse all the repos they have access to in the Explorer page (not only the public one)
therefore, allow users to use the search engine (not only for public repos but all repos they have access to).

I'll create a PR tomorrow

@bwko awesome, thanks. You're fast.
I have to dig into Go. How do you set a dev environment ?

On Tue, Nov 22, 2016 at 12:26:34AM -0800, axeloz wrote:

How do you set a dev environment ?

See https://golang.org/doc/install
Once you're setup (Go installed and GOPATH env variable set)
you'd do:
 go get code.gitea.io/gitea
 cd $GOPATH/src/code.gitea.io/gitea
 ./gitea web

Thanks @strk does it include a file watcher which will recompile when I update the code? Or should I rerun the server each time?

The commands I showed do not include a file watcher.
You need to recompile (go build from within the
source directory) and then re-run the server, upon
changes.

OK thanks,
I asked because Gogs uses a watcher according to its documentation :
You can enable live compile by executing bra run in the Gogs source folder To install bra: go get -u github.com/Unknwon/bra

Any file watcher included bra is still avaiable for Gitea. @axeloz

@Bwko thanks for the pull request, nice piece of work. Hopefully it will be merged soon.
Also, did you guys have the time to consider my last point?

allow all users of a given team to access (read, read/write or admin according to the team permission) to all repos of the organisation owning the team, no matter the repo belong to the Owner of the organisation or to the team. This point is actually quite weird in term of functionality by the way, because when adding a repo, I did set the owner to "MyOrg" in the select list but in reality, the repo is assigned to the "Owners" team of the "MyOrg" org, not directly to the "MyOrg" organisation like I asked.

I think Bitbucket model is easier to understand and to manage.
Thanks
Axel

I'll look into that. I hope to create a PR in a couple of days

Hello @all,
sorry for bringing that up again. I understand the search in private repo and ordering will be fixed soon. What's about the team permission related question I asked? @Bwko you said you would create a pull request soon but I don't think you did, right? Are you still considering this point? It's very time consuming to add each repo to each team who should have access to it. When you have 40 repos and 2 teams, you must replicate this action 80 times.
Thanks a lot

@axeloz The search in private repo feature is already added to the latest master . I haven't had the time to create a PR for this issue. I hope to create a PR in a couple of days/ weeks.


Disable sccache when building ICU for Android

These jobs are hitting a known fatal error in sccache where files aren't removed from the cache:
sccache: encountered fatal error
sccache: error: thread 'tokio-runtime-worker' panicked at src\lru_disk_cache\mod.rs:204:17: Error removing file from cache: `"C:\\a\\swift-build\\swift-build/.sccache\\preprocessor\\8\\f\\2\\8f2e7d1b9af7ff2cc23c6829fc3cae3044c631d88bf597901be5e04795779aad"`: failed to remove file `C:\a\swift-build\swift-build/.sccache\preprocessor\8\f\2\8f2e7d1b9af7ff2cc23c6829fc3cae3044c631d88bf597901be5e04795779aad`
sccache: caused by: thread 'tokio-runtime-worker' panicked at src\lru_disk_cache\mod.rs:204:17: Error removing file from cache: `"C:\\a\\swift-build\\swift-build/.sccache\\preprocessor\\8\\f\\2\\8f2e7d1b9af7ff2cc23c6829fc3cae3044c631d88bf597901be5e04795779aad"`: failed to remove file `C:\a\swift-build\swift-build/.sccache\preprocessor\8\f\2\8f2e7d1b9af7ff2cc23c6829fc3cae3044c631d88bf597901be5e04795779aad`

There's an open issue about this at https://github.com/mozilla/sccache/issues/2092.
Test
https://github.com/thebrowsercompany/swift-build/actions/runs/9749014927

Please inline the error message in the commit message so that we can follow what is going on, the logs are inaccessible due to the corporate security and broken Arc.

Done

Hmm, its unclear if this is really the right approach - it just seems like you have a corrupted cache? What happens if you clear out the cache?

Hmm, its unclear if this is really the right approach - it just seems like you have a corrupted cache? What happens if you clear out the cache?

I don't think clearing the cache will fix things, given that this is flaking on both GitHub and Azure images where each Android ICU job executes in  a fresh VM instance. It seems like a bug in sccache that surfaces with higher probably when building for Android, so disabling it just unbreaks the build for the time being.
That being said, how does one clear the cache used by sccache? Where in the workflow could we do this if we wanted to workaround the error when building ICU?

You are missing the point of sccache ;-). The entire point is that the content is cached, even on a fresh VM image. You should look at the caches for the job, clearing out all the old runs should hopefully fix the issue.

Ah, I see what you mean.  I just deleted each of the android ICU caches and will see if that works.

That did it, thanks for the tip!

Reopening because the sccache corruption comes back each time we attempt to target Android when building ICU, and it's not immediately clear what is causing this. We'll need to disable this while we debug.

I'll need @compnerd to merge since I don't have write access

This is not needed after https://github.com/compnerd/swift-build/pull/757.  The reason for the cache misses is that the cache size was too small to begin with, so the first cache we create when building Android for ICU does not contain all of the expected entries causing sccache to subsequently fail when purging existing entries to make space


Suggestion: Allow line selection in terminal

testing #46594
Suggestion: Allow selecting a line at a time while navigating in terminal line by line.
With #46594 I can use CMD+UpArrow CMD+DownArrow to navigate, and can press Shift+CMD+UpArrow and Shift+CMD+DownArrow to select a block of text in the terminal (between commands).  This is cool for selecting blocks of text that are the output of a command.
But, what if I want to select a single line at a time?  Since I can use CMD+ALT+PageUp and CMD+ALT+PageDown to navigate line by line in the terminal, perhaps Shift+CMD+ALT+PageUp and Shift+CMD+ALT+PageDown could be used for that.

Opening to PRs, this will involve adding 2 new commands "terminal.integrated.selectToNextLine/selectToPreviousLineand handling it withinTerminalCommandTracker`.

@Tyriar Mind if I tackle this? I was just in the integrated terminal code so this code be a good issue for me.

@ddruker sure! This will probably involve having some additional state in TerminalCommandTracker to tell whether it's a command or a line focused.
https://github.com/Microsoft/vscode/blob/3fbfccad359e278a4fbde106328b2b8e2e2242a7/src/vs/workbench/parts/terminal/node/terminalCommandTracker.ts#L25-L26
We probably want to create a new marker whenever the line is changed (if the previous line is not a command), if we just track it with a number it might be invalid when lines are trimmed off the top of the terminal.

@Tyriar I'm assuming this would only be previous line selection and only one line can be selected at a time using the proposed commands. Does that sound right?
Also, would the UX be similar to line by line navigation, where the terminal window always scrolls? For example, the terminal window does not need to scroll unless the line is out of view.

I'm assuming this would only be previous line selection and only one line can be selected at a time using the proposed commands. Does that sound right?

Next should be added as well to mirror the existing commands. Users could for example go one line too far and want to go back.

Also, would the UX be similar to line by line navigation, where the terminal window always scrolls? For example, the terminal window does not need to scroll unless the line is out of view.

@ddruker for the selectTo* commands, the 'focused' line is always in the middle of the viewport.

Very good. Thank you! 🙏

On Apr 9, 2018, at 1:18 PM, Daniel Imms<EMAIL_ADDRESS>wrote:
I'm assuming this would only be previous line selection and only one line can be selected at a time using the proposed commands. Does that sound right?
Next should be added as well to mirror the existing commands. Users could for example go one line too far and want to go back.
Also, would the UX be similar to line by line navigation, where the terminal window always scrolls? For example, the terminal window does not need to scroll unless the line is out of view.
@ddruker for the selectTo* commands, the 'focused' line is always in the middle of the viewport.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Commands added in https://github.com/Microsoft/vscode/pull/47991

Select to previous line works great.
However I was not able to get anything useful from the select to next line since I always have the last line focused in my terminal. Even if I select some text in the middle of the terminal select to next
line simply jumps back to last line. What am I missing here?

@isidorn select next command/line need to be used after select previous command/line.

@Tyriar ok, adding verified even though I find it a bit unintuitive.
I would expect that the select next line would work even if I have 3 lines manualy selected.


Attempt to plumb plugins up to the CLI flags

Attempt to plumb plugins up to the CLI flags
Add fmt::Display to ResponseStatusCode.
Dirt simple PR to implement displaying of response codes.
Remove dead contingency table code.
This was dead code because I reimplemented contingency tables
in a better way.
Fix Type Incompatibilities between Actors
I had the type signatures incorrect for the actors. Some took Observation,
other T, and the incompatibility is that an Observation is a Group + T,
so DecisionEngines were actually able to be constructed.
Implement Chi Square engine and add different types of contingency tables.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#11  👈
#10
trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RobbieMcKinstry and the rest of your teammates on  Graphite

Merge activity

Oct 28, 6:03 PM EDT: A user started a stack merge that includes this pull request via Graphite.


Unable to make error validation visible...

Describe the bug
Error validation is not visible / indicated.

its working for the TextBox but not for my usercontrol, what do i miss?
To Reproduce
Im using the INotifyDataErrorInfo interface for property value validation in combination with ValidatinAttributes for the differenct errors and messages (evalutating the attributes in viewmodel and raising ErrorsChanged). But its not visible.
Do i miss something?
Expected behavior
No response
Avalonia version
11.1.3
OS
No response
Additional context
No response

@trashhacker don't ask questions as a bug report please. 🙏 Thx.
To answer your question: please have a look at Avalonia.Samples > RatingControlSample how we did add validation there.

Sorry.. cant find RatingControlSamples

https://github.com/AvaloniaUI/Avalonia.Samples/tree/main/src%2FAvalonia.Samples%2FCustomControls%2FRatingControlSample


vue3+vite配置报错

How about some English and some actual errors?
Closing as super low effort right now, add some more details if you're encountering an error in a supported use case, but this is a plugin for webpack and not for vite which AFAIK uses rollup
If you want to make a plugin for vite as a separate package a PR is also welcome

Vite/rolllup plugin is now available as @prerenderer/rollup-plugin


Collect logarchives for iOS 10.0 devices or later

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Description
Changes how we collect logarchive bundles from the Simulator so that it only happens when supported. iOS 10.0 devices on macOS Sierra (10.12) support logarchives. iOS 9 devices do not support logarchives and macOS El Capitan (10.11) does not support logarchives.
Motivation and Context
Trying to collect logarchives from an iOS 9 device on macOS 10.12 results in an error and no logs are provided to the scan and snapshot actions.

@hjanuschka can you review?

@mfurtak can you merge it too? I don't have that permission.

this is great thx @lyndsey-ferguson


Get iscroll to work with form fields

Hello,
Thanks for the great plugin. Really wanted to use this plugin, but the breaking of form was a dealbreaker for us, so I came up with the changes in this pull request.  This change is related to this issue: https://github.com/cubiq/iscroll/issues/13. Simply detects what's being touched and returns if a form input element.
Thanks again,
Gerard

What is the status for the solution of this problem?

In iScroll.js version 5.2.0
line no. 1653 add one condition && !e.target.tagName=="INPUT"
fix the issue for input type "datetime-local"

In iScroll.js version 5.2.0
line no. 1653 add one condition && !e.target.tagName=="INPUT"
fix the issue for input type "datetime-local"


API proposal : Remove singleRefine from RefinementList

It seems to me that this parameter is redundant with the menu.
Since the menu is already handling disjunctive + single refine, it is here only for conjunctive faceting.
We have two options:

If we're considering single value attributes => Then it's already the only refinement displayed
If we're considering array attributes => Then why limit the user in his filtering abilities ?

Hey! It's here to expose a feature of the RefinementList (component) to the widget.
So that if you want to build a list of checkboxes where only one checkbox can be ticked at a time, while still displaying the other options then you use refinementList + singleRefine, then you can.
Like "shipping options" (point relais, collissimo..) it fits in it, while using a menu for shipping options may not be obvious to the user.
What do you think?

So that if you want to build a list of checkboxes where only one checkbox can be ticked at a time, while still displaying the other options then you use refinementList + singleRefine, then you can.

But isn't exactly what the menu is doing? Having a list where only one item can be checked at a time ?
In the end I think we need to remove refinementList from the exposed widgets. Instead we should expose widgets for each use-case. Maybe we should keep this discussion in #219?

Back from the other discussion, here are my current thoughts:

We keep the refinementList as a widget (me suggesting removing it was a misunderstanding on my part)
We remove the singleRefine option form the refinementList widget (we keep it in the component). We already have the menu widget for that. Maybe this is not the best name, but we can work on finding a better name on another issue (singleSelection, radioList, ...)

We remove the singleRefine option form the refinementList widget (we keep it in the component). We already have the menu widget for that. Maybe this is not the best name, but we can work on finding a better name on another issue (singleSelection, radioList, ...)

I am up for it but also concerned. If I want to make a refinementList out of radio buttons, I will need the singleRefine option. Of course I can use menu to do so, but really menu is sugar on top of refinementList. So from the docs, I would go for refinementList. That's why I am unsure about removing this option.
It's currently not restricting us to do anything right? So let's keep it and see if we need to remove it later on?

menu should be a widget like any other widget, not sugar. The fact that we are internally reusing the same React components should not make it a second-class widget.
refinementList should be used only for multiple choices selections (AND or OR). If you want to do a list of radio element, where you can only select one, you should use menu instead.
The current refinementList widget code is more complex than it should be because we need to ensure that both operator and singleRefine are mutually exclusive. This should instead be handled directly inside the menu widget (which will not expose the operator attribute).

menu should be a widget like any other widget, not sugar. The fact that we are internally reusing the same React components should not make it a second-class widget.
refinementList should be used only for multiple choices selections (AND or OR). If you want to do a list of radio element, where you can only select one, you should use menu instead.
The current refinementList widget code is more complex than it should be because we need to ensure that both operator and singleRefine are mutually exclusive. This should instead be handled directly inside the menu widget (which will not expose the operator attribute).

The current refinementList widget code is more complex than it should be because we need to ensure that both operator and singleRefine are mutually exclusive. This should instead be handled directly inside the menu widget (which will not expose the operator attribute).

Ok good points! So let's remove it, but we will need a name for this one. And we failed a lot in finding a good one :D

I've recently spent a considerable amount of time trying to implement a single-selection filter using the useRefinementList hook, under the assumption that it was the go-to solution for all types of facet filtering in React InstantSearch. It was only after delving deep into the documentation and community resources that I discovered useMenu is actually the recommended approach for single-selection scenarios.
Given this, I believe it would be highly beneficial for the documentation to explicitly clarify the distinction between useRefinementList for multiple selections and useMenu for single selections. A clear indication of this difference could save developers a significant amount of time and confusion.
I understand the flexibility and power of Algolia's InstantSearch hooks and appreciate the wide range of customization options available. However, a straightforward guide or note in the official documentation highlighting the specific use cases for useRefinementList vs. useMenu would be incredibly helpful for those of us integrating Algolia into our React projects.

Hello Algolia Team!
I've recently spent a considerable amount of time trying to implement a single-selection filter using the useRefinementList hook, under the assumption that it was the go-to solution for all types of facet filtering in React InstantSearch. It was only after delving deep into the documentation and community resources that I discovered useMenu is actually the recommended approach for single-selection scenarios.
Given this, I believe it would be highly beneficial for the documentation to explicitly clarify the distinction between useRefinementList for multiple selections and useMenu for single selections. A clear indication of this difference could save developers a significant amount of time and confusion.
I understand the flexibility and power of Algolia's InstantSearch hooks and appreciate the wide range of customization options available. However, a straightforward guide or note in the official documentation highlighting the specific use cases for useRefinementList vs. useMenu would be incredibly helpful for those of us integrating Algolia into our React projects.
Best regards

@tomo-kn, why don't you use useMenu for a single-select instead?

@Haroenv

why don't you use useMenu for a single-select instead?

Yes, what I was trying to convey is that it's difficult to discern from the official documentation that useMenu should be used for single-select scenarios, while useRefinementList is intended for multi-select scenarios. I believe that the documentation for useMenu should include a link to useRefinementList, and vice versa, to make this distinction clearer.


API for enhanced epinio information pre-log in

Is your feature request related to a problem? Please describe.

When the Epinio UI is embedded in the Rancher UI it shows a list of all epinio clusters. The user will be able to select a cluster and (soonish) sign in using either a local user or one via dex
In order to support this the UI needs to know...

Cluster State

It confirms the epinio cluster's API is available by making a request to /api/v1/info.

Cluster Version

It shows the version the epinio cluster via the contents of the /api/v1/info. This is a nice to have and adds information the user may want to see in that context

Cluster Auth Mechanisms

It's possible to remove the dex provider such that only the local user auth mechanism is supported
If the dex provider is not available the user should not be able to log in via dex

For the first two this depends on the /info endpoint. However this requires credentials which at that point the user does not have. This might have always been like this (for demo's credentials were hardcoded)

Describe the solution you'd like
An endpoint that will

be reachable without credentials
provide the Epinio version
provide the supported auth mechanism

Describe alternatives you've considered

There's a /ready endpoint which could be used / beefed up. At the moment though it's not available due to CORS errors

Additional context

I'll link the UI PR containing auth integration when it's up. That will need this new endpoint

Let's schedule this for the next milestone. I'm just curious to know if exposing the cluster/Epinio version could be considered as a security flaw.

@richard-cox

There's a /ready endpoint which could be used / beefed up. At the moment though it's not available due to CORS errors

On a first glance simply extending /ready might be the easiest way to do this.
How complicated is fixing the CORS errors on your side ?
Would a new endpoint, like, for example /hello, also be subject to CORS rules ?
@enrichman

... if exposing the cluster/Epinio version could be considered as a security flaw.

IMHO not really.
Concealing it feels like security by obscurity to me, and that is something which in general will not work.
I strongly suspect that there will be over ways of fingerprinting an E server to determine its version even if we hide it.

@andreas-kupries I think the CORS errors were more related to somewhere API side that allowed cross-origin requests from specific domains (the rancher url is supplied via helm value, and checked in go middleware somewhere). We might have a way around this UI side, but won't be available in this first iteration of auth (it will probably require changes Rancher API side).
@enrichman it might be worth checking with the security team. otherwise, given the user must have some visibility of kube resources, is the epinio version stored somewhere easily accessibly via the kube api?

I've checked with @thesp0nge. It should be fine for the same reason exposed by @andreas-kupries.
By the way the user should/could not have any access to the kube APIs/resources.

Ok. Thanks for all the answers. Plan now is to move /info to unauthenticated, and extend it with the information about auth methods.


Bug: Missing network icon

Description
When i open the app, the network icon is missing.
Steps To Reproduce

Steps to fix

Add missing icon

Files Version
Wersja: <IP_ADDRESS> OS Version: 10.0.22621.963
Windows Version
Windows 11 22621.963
Relevant Assets/Logs

Can confirm.

Yes. Same issue here as well

Which icon is supposed to show?

Which icon is supposed to show?

Same as file explorer

This should be resolved through #10839

We already use that icon for the section header so it would be confusing to use it for the sub item as well. We can do what we did in the past and display a standard folder icon (not sure why that was removed).

I'll change it now


fix(truncateLargeString): truncate binary strings properly

we're getting giant hex arrays rendered that lag and look messy, so here's fix

Could you add some unit-tests to cover your changes please.

chore: fix(truncateLargeString): cover truncating strings with tests
The fix(truncateLargeString): part should be removed from the title, isn't it?


Want to add Google Search Engine Clone

Issue Type:

[x] Feature Request

Describe the bug

This was not a bug, I want to add Google Search Engine Clone

Screenshots

@gurjeetsinghvirdee did you raise this issue in some other repo as well?

@gurjeetsinghvirdee did you raise this issue in some other repo as well?

In Ace the front end

@gurjeetsinghvirdee did you raise this issue in some other repo as well?

In Ace the front end, So there was an issue like you can't add the same project because I saw many contributors add the same project in another repo

Yes ik about it, what I meant was I saw a similar issue in one of the 3repos that I maintain. That's why was just confirming.

@gurjeetsinghvirdee did you raise this issue in some other repo as well?

In Ace the front end, So there was an issue like you can't add the same project because I saw many contributors add the same project in another repo

Yes ik about it, what I meant was I saw a similar issue in one of the 3repos that I maintain. That's why was just confirming.

yeah I also saw, but In front end template someone added a google clone but that was just HTML and CSS, don't know about other repo may be they also like design not work at all


Remove ghost_branded_generics measure and associated view

The underlying issue which led to the Ghost-Branded Generics problem has
been fixed.
After deployment the measure will need manually deleting from the db with:
./manage.py delete_measure --delete-live-measure ghost_generic_measure

For hygiene's sake we should probably delete the BQ view as well: vw__ghost_generic_measure.

The underlying issue which led to the Ghost-Branded Generics problem has been fixed.

Impact!


Support ONNX Export for HF_TEXT

Code changes to support ONNX export for HF_TEXT
Write and example to export an ONNX model and also a sample test
Add raw feature output (before pooling) for hf_text
Add raw feature distillation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I just noticed a conflict file. We can merge this in once the “eval” is replaced with “evaluate” and the  conflicting is resolved.


There is no check for timestamp range boundaries.

select '2262-04-11 23:47:16.854775807 +0000'::timestamp9;

returns: 2262-04-11 23:47:16.854775807 +0000
select '2262-04-11 23:47:16.854775808 +0000'::timestamp9;

returns: 1677-09-21 00:12:43.145224192 +0000

Can this pull-request resolve your problem? #13


downloads section hasn't been updated since 1.15.0

Original issue 240 created by sam.clegg on 2014-06-17T20:39:53.000Z:
But from the commit history it looks like 1.17.0 was released.
Can you update the downloads section please?

Now that the project is hosted on GitHub releases can all be downloaded (as a zip or tgz file) at https://github.com/google/leveldb/releases.


Implement logical expressions

This should be as simple as possible for version 1.0
Grammar:
LogExp > Relation (("and"/"or") Relation)?
The result should ONLY be used in IF statements.

Done, available in current develop branch.


LIFT deployment

A new MC server is needed for the LIFT project.

[ ] Get domain name for lift.materialscommons.org
[ ] Configure NGINX with key files for lift.materialscommons.org
[ ] Setup NFS mount for TurboStorage
[ ] Request admin (sudo) account for Terry Weymouth on lift server
[X] Build mcstored
[ ] Resolve external firewall issues for lift server
[ ] Resolve internal se-linux issues for lift server
[ ] Install Tika

Server deployed. No persistent connection to Turbo.


Swagger 2 specs

Changes Unknown when pulling ae0cdf43fce8a26b564cac63d241af15f84a7da1 on swagger_2_specs into ** on master**.

Changes Unknown when pulling ae0cdf43fce8a26b564cac63d241af15f84a7da1 on swagger_2_specs into ** on master**.

Changes Unknown when pulling f9ae378afd3f541176b580e6acf648ed989a55bd on swagger_2_specs into ** on master**.

Changes Unknown when pulling f9ae378afd3f541176b580e6acf648ed989a55bd on swagger_2_specs into ** on master**.


Implement half-floats

See https://www.opengl.org/registry/specs/ARB/half_float_pixel.txt

Anybody working on this? I'd like to give it a shot.

@Sixstring982 go for it!
@kvark while we're at it, is there anything we can do to promote half floats in vertex formats? Using u16 and mem::transmuteing would probably work, but doesn't look very nice.

@fkaa current format module has F16 type, but it doesn't do anything... We can put logic into it for f16<->f32 conversion.

Looks like f16 was at one point being considered as a native type: https://internals.rust-lang.org/t/adding-minifloats-f24-f16-f8-as-native-types/2367/13
I think f32<->f16 conversions are probably OK for most circumstances, even though IEEE 754 16-bit floats would act differently.

I'd love some native f16 support.

Alright, I built some half floats. So far they can be converted to and from any of the other numeric primitives. Is that all we need, or should I implement Add, Mul, etc. for them?

@Sixstring982 that should be fine. I assume if people want any real computation with them on CPU side they can convert to/from f32. Is your code big? Do you think you'd be able to just put it into our gfx_core::format::F16 implementation, or as a separate crate?

@fkaa rendering-wise our GL backend already supports GL_HALF_FLOAT just fine. At least for vertex attributes and texture formats, that is.

I have about 300 lines. It could probably be in its own crate.

@Sixstring982 yeah, that's rather big
We could depend on it as a feature.

I believe this is exposed in gfx-hal


Parallel API for layout viewport?

Should there be a parallel API for layout viewport?
A couple reasons this might be interesting:

Enables developers to move away from the ambiguous APIs altogether.  Those that do will be explicitly thinking about which viewport they're interested in when consuming the API.
If a developer is really only interested in responding to changes to the layout viewport and not the visual viewport, the "scroll" event is noisier than needed today.  It fires when the user has zoomed and is moving the visual viewport around within the layout viewport but not touching the edges of the layout viewport.

My preference is to make all the ambiguous APIs relative to the layout viewport. This would make window.{scrollX|scrollY|innerWidth|innerHeight} the de jure layout viewport API and make content that hasn't explicitly opted into using the visual viewport oblivious to browser UX features like pinch-zoom and on-screen keyboard. I think this would include making the "scroll" event in your second point only fire for layout viewport scrolls.
We already so some aliasing with documentElement delegating to the window object so I'm a bit worried about adding another alias like this, especially given that I'm not sure people will opt into using it ("layout viewport" is the harder of the two viewports to explain).
The other (probably separate) issue I see here is that we should be clear about how we define the layout viewport. As far as I can tell, position: fixed elements in Edge stick to the box defined by the 's width attribute (i.e. layout size). This makes "layout viewport" an accurate term. In Chrome however, our "layout viewport" would more accurately be called the "position: fixed viewport" or "minimum scale viewport". We size and position fixed elements relative to the viewport at minimum-scale, rather than the layout size. This really only causes differences in badly built legacy cases and only on mobile devices so I consider it an edge case (also, browsers are notouriously quirky in how they handle these cases), but it's something to keep in mind as we discuss spec language.

I may have contradicted myself a bit with my last paragraph there. Because Chrome's "layout viewport" isn't actually tied to layout, the only way to get the layout viewport size, in general, is to create a phantom position: fixed element with width/height 100% and read that with getBoundingClientRect.
On a "well behaved" web page this isn't actually needed, and even on more tricky pages I think scrollingElement.clientWidth/Height will work today but we have some experiments where this might change. e.g. make the URL bar behave more like Safari where the scrollingElement's size doesn't change with the URL bar. An explicit API might help us here.


[Relay] Simplify the square of a binomial

Simplifies the expression of form axx + bxy + cyy to (x+py)(x+qy).
Also added the appropriate test.

@tvm-bot rerun


pidgin-discord: init at 2018-04-10

Motivation for this change
Adds new pidgin plugin that brings Discord support. In addition, add myself to the maintainers list.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@jtojnar mind reviewing this again? Sorry about the new pull request, did not know GitHub would close it, when I forced a push to squash my commits. Also thank you for telling me about PKG_CONFIG_${package}_${variable} it is awesome.

@GrahamcOfBorg build pidgin-discord

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pidgin-discord
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: pidgin-discord
Partial log (click to expand)
rm po/it.mo po/es.mo po/ru.mo
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10
shrinking /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10/lib/pidgin/libdiscord.so
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10/lib
patching script interpreter paths in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10
checking for references to /build in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10...
/nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10

@jtojnar changes applied, sorry for the oversight.


[1987] Attributions can be marked as "preferred"

The goal is to enable that attributions can be marked as "preferred". Also removing the mark should be possible.
This should only be possible in audit view.
Further preferred attributions should be markedby a star (e.g.
https://mui.com/material-ui/material-icons/?query=star).
The star icon should also be displayed on report view.
--
Part of #1987

Implemented in #2008


update yarn lock

What does this PR do and why?
fixed a conflict from down the stack
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1647

PR #1648

PR #1665

PR #1667
PR #1710   👈

This comment was auto-generated by Graphite.

closing stack, for more context: https://github.com/jbx-protocol/juice-interface/pull/1712


Incompatibility with vue 2.7

After upgrading to vue:2.7, which has composition-api built in, I started getting this compilation error when running my app:
 ERROR  Failed to compile with 1 error                                                                                12:19:59 PM

 error  in ./node_modules/vue-concurrency/dist/vue2/vue-concurrency.module.js

Module not found: Error: Can't resolve '@vue/composition-api' in '/home/micael/code/webapp/node_modules/vue-concurrency/dist/vue2'

ERROR in ./node_modules/vue-concurrency/dist/vue2/vue-concurrency.module.js 1:0-140
Module not found: Error: Can't resolve '@vue/composition-api' in '/home/micael/code/webapp/node_modules/vue-concurrency/dist/vue2'
 @ ./node_modules/vue-concurrency/dist/index.module.js 1:0-45 1:0-45
 @ ./node_modules/babel-loader/lib/index.js!./node_modules/ts-loader/index.js??clonedRuleSet-41.use[1]!./node_modules/@vue/vue-loader-v15/lib/index.js??vue-loader-options!./src/components/form/CFileUpload.vue?vue&type=script&lang=ts& 5:0-42 9:26-33
 @ ./src/components/form/CFileUpload.vue?vue&type=script&lang=ts& 1:0-252 1:268-271 1:273-522 1:273-522
 @ ./src/components/form/CFileUpload.vue 2:0-63 3:0-58 3:0-58 9:2-8
 @ ./src/components/ sync [A-Z]\w+\.(vue%7Cjs)$ ./form/CFileUpload.vue
 @ ./src/main.ts 99:21-81

Is there anything I'm missing to make this work? Or is vue-concurrency incompatible with vue:2.7?

Hello @mdcarreira it's quite possible the library is incompatible with vue 2.7. For a long time the situation was that in case of Vue 2 I had to require the @vue/composition-api module.
I had a lot of issues making the lib compatible with both Vue 3 and Vue 2.7. This actually makes it easier.
I think I'll support only Vue 2.7 in new version of vue-concurrency. But I'm swarmed with work, not sure if I can manage to do it in this or next week.

Hey @MartinMalinda, thanks for the fast reply!
Yeah, I understand. If I knew more about vue, I might try to give you a helping hand and make a PR. But unfortunately I'm a vue noob...
I'll keep watching your repo and crossing my fingers that you will find the time to look into it :)

@MartinMalinda, by any chance have you managed to look into this or plan to look into it soon?
Sorry for being insistent, but we've come into a point where we cannot upgrade to vue 3, neither want to downgrade back to vue < 2.7... So if you are not planning to update vue-concurrency to support vue 2.7, we will need to find an alternative solution :(

hi @mdcarreira, yes I gave it a try and unfortunately vue-concurrency does not run in 2.7. Seems like the reactivity implementation there is different from the previous @vue/composition-api module because I'm seeing errors I haven't seen before with Vue 2.
I suspect this has something to do with its reactive implementation and maybe the errors point out some problems within my code, but I don't have time in the nearby future to refactor the lib:(

Argh, that's a shame... Thanks for letting me know the current state of things!

Is this fixed in the latest 2.7 release? I noticed there is handful of reactivity changes.

@Hawxy I just tried and yes, unfortunately

yes, unfortunately it's fixed? Why is that unfortunate?

A too quick answer from me, sorry. I mean the error is unfortunately still present. It's still going in infinite loop.


fixup! Expand on the definition of our ops

Squashable suggestions addressing my concerns with the recent
state-scope wording (opencontainers/specs#225).  The “optional
operation” wording I was trying to reference was in your commit,
where b473dfdd had both:

… the entity using a runtime to create a container MUST be able to
use the operations defined in this specification against that same
container.

and:

OCI compliant runtimes MUST support the following operations, unless
the operation is not supported by the base operating system.

which seem at odds with each other.  In the fixup-patch I'm floating
here, I've stuck with the “if the operating system supports it”
approach.
I've also made the conditions under which state-retrieval MUST succeed
more explicit by:

Including timing information.
Replacing “entity” with (hopefully ;) testable wording about users,
namespaces, and runtime installations.

I also relaxed the uniqueness constraint so it uses the same scope as
the state registry (however far the runtime chooses to stretch that
scope).  Requiring runtimes to enfore uniqueness on a larger scope
than we do for the registry seems like it would lead to implementation
difficulties.

Please make comments on the PR itself, not the branch - didn't even notice this was here :-)  and would prefer to keep all of the conversations in one spot.

On Mon, Feb 22, 2016 at 06:46:16AM -0800, Doug Davis wrote:

Please make comments on the PR itself, not the branch - didn't even
notice this was here :-) and would prefer to keep all of the
conversations in one spot.

Fixup commits seemed like an easier way to discuss my suggestions,
since they allow me to sketch the suggested changes in more detail,
are easy to apply if they look good, and are easier to ignore (in the
main PR) if they are bad.  I dropped 1 into the original PR right
after GitHub's auto-generated 2, but I'm happy to ping you on IRC or
whatever if I'm tempted to create secondary PRs like this in the
future.  I'm also fine avoiding secondary PRs and keeping discussion
in the primary PR.  That seems noisy and like more work for you, but
if it's what you want, it's certainly doable ;).


Set up CI with Azure Pipelines

Now that this repo is in a working state, I think it's worth adding something simple here to make sure these samples continue to build.

Ah forgot, we need .NET 5 Preview 4:
error NETSDK1082: There was no runtime pack for Microsoft.NETCore.App available for the specified RuntimeIdentifier 'android.21-x86'.

I'll finish this once that is available.


Predicate Based Asset IDs

Abstract
Right now, our asset ID construction allows for contracts to mint assets with specific sub IDs. This is very useful for enabling rich multiple native assets. One sticking point with the UTXO model is that enabling blacklisting is nearly impossible for native assets. Many popular stable coins such as Tether and USDC require this feature to ensure that can take appropriate steps to blacklist bad actors from their system. While Fuel should encourage permissionless token design philosophically, not having reasonable facility for blacklisting on minted assets would be a net negative for the protocol. In this proposal, I suggest we consider changing the sub ID we currently have to a predicate ID root, in which, any actor can override existing predicates with this particular logic. This would enable system wide black listing, while retaining parallelism and minimally altering our existing asset system.
Current Asset ID
sha256(CONTRACT_ID ++ SUB_IDENTIFIER)

Proposed Asset ID
sha256(CONTRACT_ID ++ PREDICATE_IDENTIFIER)

Proposed Predicate Validation Logic
The asset predicate takes priority over the "owner" predicate and allow overriding. So the predicate logic would have to be able to both check if the asset based predicate is presented first, then if not, would check the owner predicate. This only introduces an additional check in the logic itself.
Minimal Changes
All existing behavior of multiple native assets can be retained, as token developers can still mint assets with a random predicate identifier or one that is clearly definable by the developer (e.g. "no_predicate").
Use-Cases

Global blacklisting of assets (no-matter who or where they are held)
Meta-transactional services, whereby additional actions can be triggered by third parties (but still retain the original owner)

UX Hurdles
Users would have to be made aware of these additional predicate conditions on their assets, but this can be done easily off-chain.

Very supportive of this idea, however we need to preserve the ability to have SubIDs as well (not simply replacing them with predicate IDs)
How about including the Predicate ID within an additional hash?
sha256(CONTRACT_ID ++ sha256(PREDICATE_IDENTIFIER ++ SUB_IDENTIFIER))

As for how this could be executed in practice, I believe the easiest implementation would be to add a new input-type, which would overwrite the normal ownership.
InputPredicateCoin

name
type
description

txID
byte[32]
Hash of transaction.

outputIndex
uint8
Index of transaction output.

owner
byte[32]
Owning address or predicate root.

amount
uint64
Amount of coins.

asset_id
byte[32]
Asset ID of the coins.

sub_id
byte[32]
The sub-ID of the asset, used for generating the asset ID.

txPointer
TXPointer
Points to the TX whose output is being spent.

maturity
uint32
UTXO being spent must have been created at least this many blocks ago.

predicateGasUsed
uint64
Gas used by predicate.

predicateLength
uint16
Length of predicate, in instructions.

predicateDataLength
uint16
Length of predicate input data, in bytes.

predicate
byte[]
Predicate bytecode.

predicateData
byte[]
Predicate input data (parameters).


Uncaught TypeError: Cannot assign to read only property 'value' of object '#'

This error occurs in normalizeField:
finalField.value = normalizer(finalField.value, previousState && previousState[field.key] && previousState[field.key].value, values, previousValues);

So what can I do so solve it?

Released as v5.3.3.


OpenSSL::SSL::SSLError

Unable to watch files using shopify_theme. When I try to, I get the error below. I've triaged the issues in this repo with SSL in the subject, but most seem to point to Windows issues, and not Mac.
Uploading:
assets/theme.scss.liquid/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:918:in `connect': SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server session ticket A (OpenSSL::SSL::SSLError)
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:918:in `block in connect'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/timeout.rb:52:in `timeout'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:918:in `connect'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:862:in `do_start'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:851:in `start'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:1367:in `request'
	from /Library/Ruby/Gems/2.0.0/gems/httparty-0.13.3/lib/httparty/request.rb:98:in `perform'
	from /Library/Ruby/Gems/2.0.0/gems/httparty-0.13.3/lib/httparty.rb:539:in `perform_request'
	from /Library/Ruby/Gems/2.0.0/gems/httparty-0.13.3/lib/httparty.rb:501:in `put'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme.rb:73:in `send_asset'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:231:in `block in send_asset'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:294:in `show_during'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:230:in `send_asset'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:153:in `block in watch'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:185:in `block in watcher'
	from /Library/Ruby/Gems/2.0.0/gems/filewatcher-0.3.6/lib/filewatcher.rb:32:in `block in watch'
	from /Library/Ruby/Gems/2.0.0/gems/filewatcher-0.3.6/lib/filewatcher.rb:26:in `loop'
	from /Library/Ruby/Gems/2.0.0/gems/filewatcher-0.3.6/lib/filewatcher.rb:26:in `watch'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:184:in `watcher'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/lib/shopify_theme/cli.rb:141:in `watch'
	from /Library/Ruby/Gems/2.0.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /Library/Ruby/Gems/2.0.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /Library/Ruby/Gems/2.0.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /Library/Ruby/Gems/2.0.0/gems/shopify_theme-0.0.21/bin/theme:24:in `<top (required)>'
	from /usr/bin/theme:23:in `load'
	from /usr/bin/theme:23:in `<main>'

Looks like system ruby has an issue with SSL certificates.
I guess the work around would be to use a ruby manager like rbenv, which should include the correct SSL certificates.

I did try rbenv actually, by following this(http://cbednarski.com/articles/installing-ruby/) but no luck.  Also tried running it with bundler, still no luck.

What version of OpenSSL is your computer using?
openssl version
http://stackoverflow.com/questions/25814210/opensslsslsslerror-ssl-connect-syscall-returned-5-errno-0-state-sslv3-read

OpenSSL 0.9.8za 5 Jun 2014
what should it be?

According to the article on Stack Overflow it should be at 1.0.1 or higher.
I think you can just brew install openssl and that will fix it.

ok, tried that, now i get Warning: openssl-1.0.1i already installed

Hmmm.... this is really weird. I know post Heartbleed Shopify changed something with SSL.
Is there something like rvm osx-ssl-certs update for whatever ruby manager you are using? This is definitely one of those easy to fix problems that are a pain to figure out because they happen so rarely :(

@komplexb did you manage to resolve the issue? Ran into the same issue and cannot seem to find the solution.

I ran in to this problem as well. I fixed it with brew link openssl --force.

I think this might have had something to do with a change in certificates. It seems to have gone pretty stale so I think it's no longer an issue. If it still is, let me know.


Added Important Message

Added "Important" message for setting instance name to MSSQLServer for default instance when configuring the inventory database

@ChrisLound : Thanks for your contribution! The author, @HJToland3, has been notified to review your proposed change.

#sign-off

@GitHubber17 : Thanks for your contribution! The author, @HJToland3, has been notified to review your proposed change.

@GitHubber17 : Thanks for your contribution! The author, @HJToland3, has been notified to review your proposed change.

#sign-off

@hjtoland3 - The PR is now merged. Thanks!


[Enhancement] adapter refactors

(es) refactors menores dentro de adapters
(en) minor refactors inside adapters

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b90d0b8). Click here to learn what that means.
The diff coverage is 26.92%.

@@            Coverage Diff             @@
##             develop     #881   +/-   ##
==========================================
  Coverage           ?   31.73%
==========================================
  Files              ?      325
  Lines              ?    17323
  Branches           ?     1551
==========================================
  Hits               ?     5498
  Misses             ?    11170
  Partials           ?      655

Impacted Files
Coverage Δ

...c/main/java/com/mercadopago/BankDealsActivity.java
0% <0%> (ø)

...rcadopago/adapters/IdentificationTypesAdapter.java
0% <0%> (ø)

...in/java/com/mercadopago/CustomerCardsActivity.java
0% <0%> (ø)

...ava/com/mercadopago/adapters/BankDealsAdapter.java
0% <0%> (ø)

.../mercadopago/adapters/CustomerCardItemAdapter.java
0% <0%> (ø)

...va/com/mercadopago/adapters/PayerCostsAdapter.java
75% <100%> (ø)

.../java/com/mercadopago/adapters/IssuersAdapter.java
73.33% <100%> (ø)

...mercadopago/uicontrollers/issuers/IssuersView.java
70.83% <100%> (ø)

...src/main/java/com/mercadopago/IssuersActivity.java
56.04% <100%> (ø)

...ain/java/com/mercadopago/InstallmentsActivity.java
44.29% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90d0b8...9014fb8. Read the comment docs.


Add a MockWebServerExtension, inspired by okhttp, which can allow tes…

…ting client code by conveniently mocking responses and examining requests.
At least in this version, I don't want to implement every knob that the okhttp version has, but added the delay knob since I've already worked on code that uses it.
Reference:
https://square.github.io/okhttp/4.x/mockwebserver/okhttp3.mockwebserver/-mock-response/
Fixes #1884
/cc @adriancole

I didn't implement a JUnit4 version since I don't think it can work well with a @ClassRule, as we need to reset state before each test method. JUnit5 is nice by allowing us to only start a single server, but also resetting state each test.

One use case I'd like to satisfy is health check going red to green on account of time. So, I think any method with delay will help with this. easier to add methods later anyway. thx

@anuraaga Thanks for your always awesome PRs!

At least in this version, I don't want to implement every knob that the okhttp version has, but added the delay knob since I've already worked on code that uses it.

I agreed with your opinion. This MockWebServerExtension is simple and easy to use based on Queue. 👍
Additionally, I was learning of okhttp's mockwebsever, Dispatcher also looks good when a user needs more dynamic dispatch. Next time I'd like to add this feature :-)

Any other comments, @ikhoon ?


*: let the tick interval of patrol region configurable

This is more controllable．

/run-all-tests

PTAL

/run-common-test

/run-integration-common-tests

LGTM.

PTAL @siddontang

/run-integration-common-test


An exception thrown when trying to query table within AGOL feature service

Consider a hosted feature service with two objects - layer id 0 is of type Feature Layer, and layer id 1 is of type Table. Trying to run the sample https://github.com/Esri/ArcREST/blob/master/samples/query_agol_service.py will throw an exception:
features.append(Feature(feat, jd['spatialReference']['latestWkid']))
KeyError: ('spatialReference',)

It seems as it cannot find spatial reference for the table (when trying to return a featureset from a JSON string - fromJSON method of FeatureSet). Is it a bug? When working with a feature service with feature layers, accessing them is no problem.
It breaks on the last line:
ldf.addFilter(1, where="1=1")
print fs.query(layerDefsFilter=ldf,returnCountOnly=False)

resolved


Not Public key

I Started the floodgate but the  public key did not generate in the folder

Hello there, you are probably watching an older tutorial. The public key.pem has been renamed to just key.pem, You do not need to copy paste the key anymore unless you are using a proxy network setup like bungeecord. For more information on how to setup floodgate you can check https://wiki.geysermc.org/floodgate/setup/.
thanks.


First release

With these changes we are ready to upload the package to PyPI.
Summary of changes:

Add a changelog
Add installation instructions to the README
Add metadata to pyproject.toml for PyPI

As you can see there's no setup.py; all that needs to be run is poetry build then poetry publish.
Closes #5

@kevinheavey borsh-construct is now published on pypi! https://pypi.org/project/borsh-construct/ (CI pipeline is still in the works, so it was published manually by our SRE team)
I have also updated the links here: https://github.com/near/borsh#implementations