service.storage_passwords.list misses space in username field

Describe the bug
service.storage_passwords.list misses space in username field.
To Reproduce
Steps to reproduce the behavior:

Install https://splunkbase.splunk.com/app/2731/
Add

[ test]
account_name = ucspe
account_password = ucspe
disable_ssl_verification = True
server_url = <IP_ADDRESS>

to local/splunk_ta_cisco_ucs_servers.conf.
3. Go to Splunk, open Cisco UCS app and refresh the page.
4. Run this Python script
from splunklib.client import connect

service = connect(username="admin", password="<your-admin-password>")

all_passwords = service.storage_passwords.list(count=-1, search="")

for p in all_passwords:
    print(p.state)

See that username field does not have space, but the stanza that we add in step 2 has.

Expected behavior
Username field should have space in it.
Splunk (please complete the following information):

Version: <IP_ADDRESS>
OS: MacOS 11.6
Deployment: single-instance

SDK (please complete the following information):

Version: 1.6.16
Language Runtime Version: Python 3.7
OS: MacOS 11.6

Hi @arys-splunk , We have fixed the issue, and the changes will be available in the next release.
PR for reference - #416

@arys-splunk please refer the latest python-sdk release 1.6.19, and please let us know if the issue still exists.


Publish the source code for Ramzor app

The source code for Ramzor app on Android/iOS is not published/open-source, please publish the code in github, thus enabling developers and testers to look at the code and suggest improvements, find bugs, etc..
see related issue in hamgen repo https://github.com/MohGovIL/hamagen-react-native/issues/289
which include source-code for hamagen app, the repo includes 215 issues & 74 PRs.
I opened 77 issues (20 was closed) in hamagen repo, some are security & privacy issues, and would like to check the source-code of the Ramzor app as well.

We know current MOH plans are to not release Ramzor app as Open Source (contrary to @MohGovIL/hamagen-react-native ). Hopefully enough likes / comments to this issue would change that.

If the MOH truly commits to providing a secure and safe solution with the Ramzor app, releasing the code as open source will go a long way towards that goal. +1,000

Please release the code so we can audit it

Right now, there is no plan to publish the source code for the "Ramzor" app. The application is not developed as an open source app, and it contains features that cannot be published without compromise MOH infrastructure or application users. Parts of it will be posted here, like the verification function. But most of the code is not related to the certificates or the verification process and cannot be published here for security and privacy reasons.

@svetamorag,
With enough reverse-engineering, eager developers will be able to find all of the inner workings the app has.
By making the code open-source, you are allowing developers who are not interested in reverse-engineering to give their input on the security & raise bugs, which would otherwise be exposed by people who are mostly interested in malicious activity.

Now that I know this app's code contains things that make it either too insecure, too buggy or too fishy to be shared by MoH, I probably won't install it.

The application [...] contains features that cannot be published without compromise MOH infrastructure or application users.

If the application is so vulnerable, as you say, that with reverse engineering people may find practical ways to exploit it, then it shouldn't be installed on so many phones. It should be rewritten if things are as dire as you describe in that comment.


v9.0.2-deno Request to https://www.youtube.com/youtubei/vtrue/player?key=[REDACTED]&prettyPrint=false&alt=json failed with status 400

Steps to reproduce
getBasicInfo is always throwing 400 error
import { Innertube } from<EMAIL_ADDRESS>const youtube = await Innertube.create();
const ytid = 'TIQ5hrfermg'

Deno.serve(async (req: Request) => {
    try {
        const metadata = await youtube.getBasicInfo(ytid, 'iOS');
        return new Response(metadata);
    } catch (err) {
        return new Response(err.message);
    }
});

Failure Logs
n/a

Expected behavior
Should return the appropriate information about the youtube id
Current behavior
Erroring out with 400 bad request error
Version
Edge
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Fixed in https://github.com/LuanRT/YouTube.js/commit/2068dfb73eefc0e40157421d4e5b4096c0c8429c.

awesome!!


Add files via upload

@xF3d33 First stage of verification passed, official domain is itarchimede.it as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@xF3d33 First stage of verification passed, official domain is itarchimede.it as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

ok, thanks. how long does it take usually?

@xF3d33 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


create docs folder for the github pages

including the updated version of the spec

@dachafra This is fixed in the latest commit I think: there is now docs/rendered.html with the latest version

thanks!


Ability to use GEOREF coordinates

Users might need to have the ability to use GEOREF coordinate type in both add-ins

Verifying if this is actually needed based on the seven types that we have added since this issue was logged.


Turn off H2 and accessioning during WEKA storage migration

We want to make it impossible for users to deposit content via H2 during the stacks/purl storage migration to WEKA over the weekend of Aug. 3-4. The maintenance page should be displayed at sdr.stanford.edu.
Several tasks:

Test the maintenance page on prod/qa/stage to make sure it works. Verify with @amyehodge the exact language that should appear on the page.
Late afternoon on the 2nd, put up the maintenance page. Something something about whether we can stop just the robots or need to take down everything per dlss.
On Monday morning when @andrewjbtw gives the all clear, @justinlittman will take down the maintenance page and return everything to normal.

For the message:
reason = maintenance work, during which time SDR depositing is unavailable
deadline = on Monday


Compilation failed due to server_fn, no method found

When running cargo leptos build, this is returned
error[E0599]: no method named `set_headers` found for struct `RequestInit` in the current scope
   --> /home/kyler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/server_fn-0.6.15/src/request/browser.rs:196:10
    |
196 |     init.set_headers(&headers);
    |          ^^^^^^^^^^^
    |
help: there is a method `headers` with a similar name
    |
196 |     init.headers(&headers);
    |          ~~~~~~~

error[E0599]: no method named `set_method` found for struct `RequestInit` in the current scope
   --> /home/kyler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/server_fn-0.6.15/src/request/browser.rs:197:10
    |
197 |     init.set_method("POST");
    |          ^^^^^^^^^^
    |
help: there is a method `method` with a similar name
    |
197 |     init.method("POST");
    |          ~~~~~~

error[E0599]: no method named `set_body` found for struct `RequestInit` in the current scope
   --> /home/kyler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/server_fn-0.6.15/src/request/browser.rs:198:10
    |
198 |     init.set_body(&stream);
    |          ^^^^^^^^
    |
help: there is a method `body` with a similar name
    |
198 |     init.body(&stream);
    |          ~~~~

For more information about this error, try `rustc --explain E0599`.
error: could not compile `server_fn` (lib) due to 3 previous errors
Error: Failed to build tulip

Not sure what to do in this case.

Given that you don't provide a way to reproduce the error, it's a bit hard to guess. If I recall correctly, this error comes from a wasm-bindgen and/or web-sys dependency that is not the latest. Try updating to the latest cargo-leptos (if you're using it), latest wasm-bindgen in Cargo.toml, and running cargo update.

Ah yes, thank you. I wish this issue was more well documented


socks proxy + authentication fails

I did some quick curl testing, and it seems that with socks mode enabled, single user and no anonymous modes both fail (I didnt have time to test htpasswd mode). If I remove the --socks flag, everything works as expected. I also tried embedding the username and password in the proxy url: http://test:test@localhost:8080 with the same result.
Steps to reproduce the problem:

$ mitmdump --socks  --nonanonymous --port 8080

or

$ mitmdump --socks  --singleuser test:test --port 8080

$ curl -socks5 localhost:8080 --proxy-user test:test http://www.cnn.com

What is the expected behavior?
The http response should have been written to STDOUT.
What went wrong?
The actual response was:
curl: (52) Empty reply from server
Any other comments?
Without the --socks argument mitmdump works fine. I wrote a quick inline script to validate that the authenticator was correctly being set, and call the test method on a hardcoded username and password. It looks like the credentials are being sent over and set correctly, but they are not being validated for requests.
localhost:8080: clientconnect
{'password_manager': <netlib.http.authentication.PassManSingleUser object at 0x7f19c61fb090>,
 'realm': 'mitmproxy'}
{'password': 'test', 'username': 'test'}
True
localhost:8080: Proxy Authentication Required
localhost:8080: clientdisconnect

mitmdump version: mitmdump 0.13.1
Operating System: Ubuntu/Docker

Thanks for the excellent report. We're currently rewriting this part of mitmproxy and will revisit this issue once the new parts are in place. :smiley:

SOCKS Proxy Authentication is a feature that is out of scope for us at the moment, but we do welcome external contributions. :smiley:

Is the issue still open for external contributions?

Yes - we are happy to accept PRs!


Low SV Count When Performing SV Calling on HG002 ONT Data

Hello, when I use Dysgu for SV calling with ONT data, the number of SVs obtained is only 5000. Below is my code. Could you please help me understand why this is happening?
/dysgu call --pl nanopore --min-size 50 -c -p 20 --mode nanopore ./GCF_000001405.25_GRCh37.p13_genomic.fa ./HG002.ONT_vulcan_dysguwd ./HG002.ONT_vulcan.sort.bam

Hi @Flooooooooooooower,
Could you share the stderr output from dysgu. I have not tested vulkan mapper, so not sure if it's compatible.

Sorry, I meant the log output that is generated by dysgu e.g:
2024-08-19 15:44:55,602 [INFO   ]  [dysgu-run] Version: 1.6.6
2024-08-19 15:44:55,602 [INFO   ]  run --clean -x --procs 12 ucsc.hg19.fa wd HG002.bam
2024-08-19 15:44:55,603 [INFO   ]  Destination: wd
2024-08-19 15:45:20,409 [INFO   ]  dysgu fetch HG002.bam written to wd/HG002.dysgu_reads.bam, n=1394166, time=0:00:24 h:m:s
2024-08-19 15:45:20,409 [INFO   ]  Input file is: wd/HG002.dysgu_reads.bam
2024-08-19 15:45:20,433 [INFO   ]  Sample name: HG002.dysgu_reads
2024-08-19 15:45:20,433 [INFO   ]  Writing vcf to stdout
2024-08-19 15:45:20,433 [INFO   ]  Running pipeline
etc

Im not sure if you have this available for the different mappers, but If you do, it can be helpful for debugging and I might be able to offer some insight about what is going on.
I was wondering what type of ONT reads are these? Are they 'Kit14' or older R9.4 reads? Also what coverage do you have? Have you tested other SV callers?
Also might be worth updating to the latest version of dysgu v1.6.6.

Hello, the issue has been resolved when I used the latest version 1.6.6. Thanks for your help.


Datepicker: Order wrong for balChange and balBlur

Datepicker/Input field: Wrong order balChange and balBlur
During applying the new library, the development team discovered an issue related to the datepicker / input field
Detailed description
current behavior (order):
	balBlur (x2) -> balChange
expected behavior (order):
	balChange -> balBlur

In combination with the balBlur (2x), the issue also happens that the calendar will have a few milliseconds showing the flickering below:

will be done by #207


[BUG] Memory issue with loading .tif files into BrainRender

Describe the bug
We are receiving the error:  ERROR: MemoryError: Unable to allocate 262. GiB for an array with shape<PHONE_NUMBER>5,) and data type float64 when trying to plot a tiff file against the Allen Mouse Brain Atlas using Spyder
It also does not seem to be using virtual memory
To Reproduce
Implement the user_volumetric_data.py file with a .tif file, our .tif file contained 1827 frames and was of size 130 GB
Expected behaviour
Our data volume should have been plotted against the Allen Mouse Brain Atlas.
Log file
Please attach the l
brainrender(8_26_24).txt
Computer used (please complete the following information):

OS: [Windows 10]
Version [21H2]
Hardware specs [e.g. 256 GB RAM, AMD Ryzen Threadripper PRO 5955WX 16-Cores CPU].

Hi @c3rry,
I assume this is happening because the example creates a copy of your data to reorient your data to the atlas, and that requires more memory than you have.
What are you trying to achieve with brainrender? The normal use case is to visualise data that has been aligned to an anatomical atlas, typically processed features (cell coordinates etc.). The method to visualise volumetric data is normally used for e.g. gene expression data.
If your data is 130GB, I assume it's raw data that hasn't been aligned to an atlas?
If you want to visualise raw volumetric data, I would recommend napari, perhaps alongside the napari brainrender plugin.

Hi @c3rry I'm going to close this now. Let us know if you have any further questions.


[Feature request] Fuzzy matching

Is it possible to change the matching method into fuzzy matching, so you can type "detco" to match "detached collar" or "bosh" to match "bookshelf"?
I don't like to move my right hand between jkl and arrow keys often when typing, that means for some tags I need to type out most of it to make it on top of the list. Ex. "detached_co" for "detached_collar"
Many programs are using this matching method, like Visual Studio Code, PowerToys Run, Obsidian, etc. I think adding fuzzy matching would make the user experience much better.

It's definitely a consideration for the future. I tried implementing it in the past, however I quickly encountered issues with balancing the fuzzy search results and other sort/filter conditions already in place and ultimately abandoned it for workign on other features.
While the basic fuzzy search functionality is quick to implement using one of the many libraries that exist for it, it becomes really hard to balance for all aspects that TAC has to consider. Just to name a few issues:

Tags already have an intrinsic sorting (the associated post count), which conflicts with the sorting imposed by a fuzzy match score (better matches at the top). It would have to combine these two scores in some way. But even then, it would partially inhibit the fuzzy match functionality by pushing potentially better matches further down.
TAC can search for many different types of results at once and also has to consider special syntax for Lora, embeddings, wildcards etc.
Tags can have aliases or translations, so even more data sources to consider that often do not share the same format

Since these map to a different tag, the fuzzy result would also have to be handled differently to result in correct displaying

This doesn't mean it can't be done, just that it's not straightforward and would likely require quite a bit of work to fit in nicely with the rest. Technically, each of the sources above could have its filter condition (at least partly) replaced by a fuzzy matcher, but that would still leave the displaying and sorting issues, which definitely need some custom logic. See the image below for the bookshelf example: The matches are mostly sensible, but not in a useful order based on the match, and due to the way aliases are implemented, TAC wrongly assumes most of the results come from one (but no matching mapping for display is found)

Another option would be that the fuzzy matcher takes over completely and handles sorting / displaying on its own, however that could lead to issues with the matched tags not necessarily being common enough to be understood by models. Such a mode could instead work well if normal word lists are used instead of tags, which could be a valid use case too depending on the model.
For the near future, I instead opted for a different method to require less typing, which is currently in "beta" on the https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/tree/feature-sort-by-frequent-use branch (hopefully merged soon, after I find the time to iron out the last few kinks). While the filtering is still exact there, it favors frequently used tags over others, so a tag you like to use in your prompts will rise to the top automatically over time. This would at least handle the "I need to type out most of it to make it on top of the list" side. Not abbreviations or typos though.
But once that's released, I'm definitely up for giving this a proper try.

Looks like it's more complicated than I thought.
For the first stage of the implementation, I think you can just use the current sorting order (sort by post count), and require the first letter of the input to match one of the initial letters of the tags.
Using bosh as an example, the first letter is b, which doesn't match cowboy_shot's initial letters c and s. In this case, bookshelf would actually be on top of the list, so it looks pretty promising to me.
Btw I'm not a native speaker and don't quite understand what this sentence means: "and due to the way aliases are implemented, TAC wrongly assumes most of the results come from one (but no matching mapping for display is found)", so I could be missing something important.
Sort by frequency sounds like a good idea. I guess it could solve a large part of my issue here, so I'm looking forward to it. Thank you.

For the first stage of the implementation, I think you can just use the current sorting order (sort by post count), and require the first letter of the input to match one of the initial letters of the tags.
Using bosh as an example, the first letter is b, which doesn't match cowboy_shot's initial letters c and s. In this case, bookshelf would actually be on top of the list, so it looks pretty promising to me.

That would be a good workaround, yeah (and also more similar to how it currently behaves). But it doesn't work for every case out of the box, e.g. tags containing parentheses or special syntax for Loras, wildcards etc. that starts with a different letter. That wouldn't be too hard to check, though.

Btw I'm not a native speaker and don't quite understand what this sentence means: "and due to the way aliases are implemented, TAC wrongly assumes most of the results come from one (but no matching mapping for display is found)", so I could be missing something important.

This is just a technical detail, nothing important. In different terms, it's just that the current method assumes that an alias or translation was typed if whatever you entered couldn't be found in the result text. Without fuzzy matching, this would always be true, so the display logic could rely on that and add the arrow etc. With fuzzy matching, what you typed can still match a tag despite the letters being incomplete or even out of order, so this assumption doesn't work anymore. It's not hard to fix and was just meant as an explanation for why the results in the image look a bit broken.

If I may weigh in, the limited addition of regex for models in #275 could probably be extended with relative ease to tags, along with the handy ^/$ positional anchors. "^det*co" for example is two more letters to type but would get the job done without having to rely on magic libraries.

If I may weigh in, the limited addition of regex for models in #275 could probably be extended with relative ease to tags, along with the handy ^/$ positional anchors. ^det*co for example is two more letters to type but would get the job done without having to rely on magic libraries. Sure beats typing whole words in any case.

That would be a possibility, but has some of the same implementation challenges as the "magic" approach with sorting and display logic. So from a work standpoint, it wouldn't be that much easier, while also having the downside that users need to know their way around regex syntax.
Some of the libraries I toyed around with actually already support an autocomplete-like mode that takes word position into account (or can be configured in such a way), so it could be the best of both worlds if done properly. Probably also faster than any custom way I could come up with. The pure regex way would be a quick and dirty solution though if some challenges with the library approach pop up that I can't solve in a timely manner.

Yeah, I went with saving the pattern under result, and translations were definitely a hassle, though I think gpt refactored that part and added pattern extraction pretty well (didn't implement that part in my test though).
One thing I noticed is that in fuzzy you'd probably lose the "bold pattern matched" bit from addResultsToList(), potentially yielding unclear matches.

If I end up using a library for it, most have a highlighter of their own to use. If not, it won't be hard to extend the current solution to work for all matches, even just highlighting the first time each typed letter shows up might be enough.


Handle errors in subscribe error not next

Very good. Except errors should be send to the error handler of subscribe not next. Errors should not be handled by the next handler of an observable. Should be:
this.ng2ImgToolsService.resize([someImage], 2000, 1000).subscribe(file => {
// resized file handler
}, err => {
// handle error
}, () => {
// handler when we are all done
});
Which would be much cleaner.

Please excuse the delay @JonathanYates, I was very busy the last few weeks. Version 0.2.0 solves this issue: https://github.com/bergben/ng2-img-tools/releases/tag/0.2.0
Thanks for pointing it out, I appreciate it!


fix(Sign): requestPath

Missing query in the requestPath
see #64

Thanks For the fix !

good job, thank you :+1:


Adding docs

Adding docs which are generating a html page with mkdocs and uploaded to GitHub pages

Codecov Report

Merging #47 (22a996e) into master (798b9a6) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

:exclamation: Current head 22a996e differs from pull request most recent head 4250a67. Consider uploading reports for the commit 4250a67 to get more accurate results

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   87.53%   87.08%   -0.45%
==========================================
  Files           9       10       +1
  Lines         393      395       +2
==========================================
  Hits          344      344
- Misses         49       51       +2

Flag
Coverage Δ

unittests
87.08% <0.00%> (-0.45%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

frosch/activate.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798b9a6...4250a67. Read the comment docs.


feat(tutorial): complete step 5

@alisonjoseph
here is the URL https://carbon-tutorial-topgunbasten.mybluemix.net/#/ under my IBM cloud account

Per instructions in the tutorial step 5, please include your mybluemix.net URL for your deployed app in your pull request description.

Done that @alisonjoseph


Unable to Join tables of different databases

is their any way to perform join on tables of different databases in sqlite using swift

Can you give an example of what you mean?


gstreamer 1.22.3

Full changelog for this release can be found here

[x] Verified local build
[x] Verified home page URL
[x] Verified license identifier in SPDX
[x] Verified package summary
[x] Verified dev_url
[x] Verified doc_url (the previous doc URLs pointed to the GitHub repos - which are mirrors - and the URLs for the base package was incorrect)

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:47: host_section_needs_exact_pinnings: output "gstreamer": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:114: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:115: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:115: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:118: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:119: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:196: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:198: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:199: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
WARNING: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:233: missing_description: The recipe is missing a description
ERROR: /tmp/abs_226po0s13l/clone/recipe/meta.yaml:233: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:47: host_section_needs_exact_pinnings: output "gstreamer": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:114: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:115: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:115: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:118: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:119: host_section_needs_exact_pinnings: output "gst-plugins-base": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:196: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:198: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:199: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:233: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_bcd3bxollk/clone/recipe/meta.yaml:233: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8132apyo4e/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_19bfbi3w3a/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_99f1o9mwg5/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_faliwnvv5n/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_00ndyo4ukv/clone/recipe/meta.yaml:202: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_70k6r8gc6p/clone/recipe/meta.yaml:202: host_section_needs_exact_pinnings: output "gst-plugins-good": Packages in host must have exact version pinnings, except python build tools.
Errors were found


extra "S"

[Enter feedback here]
There's an extra "S" on the sentence Use the following steps to add another RD Sesssion Host to your deployment:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8cc57542-d28d-f0f5-8baa-bf439c8a1b04
Version Independent ID: 36a9dd84-5284-5cfd-2366-546c978b1852
Content: Scale out your RDS deployment by adding an RD Session Host farm
Content Source: WindowsServerDocs/remote/remote-desktop-services/rds-scale-rdsh-farm.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

#assing:xelu86

Hey @fedesoundsystem,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change has been made correcting grammar issues within and changes will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day. #please-close


Deprecate in favor of django-two-factor-auth

I started this project in 2021 because I needed FIDO2 authentication for Django and there was no good library available. However, that changed. In January 2023, version 1.15.0 of django-two-factor-auth was released with FIDO2/WebAuthn support.
django-two-factor-auth is maintained by jazzband and much more popular than django-mfa3. So even though I like working on this library, I think it is the responsible thing to deprecate it.
Steps to do:

review django-two-factor-auth
contribute any features that are missing compared to django-mfa3
document the migration process
make a release to announce the deprecation

There is a small chance that after reviewing django-two-factor-auth I find out that the approaches are different enough so that it makes sense to keep both projects around. But honestly I don't think that will happen.

These are notes for migration. I will update this comment as I find out more.

add django-two-factor-auth[phonenumberslite,webauthn] as a dependency
add the following to INSTALLED_APPS:'django_otp',
'django_otp.plugins.otp_static',
'django_otp.plugins.otp_totp',
'two_factor',
'two_factor.plugins.webauthn',

add 'django_otp.middleware.OTPMiddleware' to MIDDLEWARE (after django.contrib.auth.middleware.AuthenticationMiddleware)
set TWO_FACTOR_WEBAUTHN_RP_NAME (replaces MFA_DOMAIN)
Register URLs: `path('', include('two_factor.urls'))
Overwrite the templates at two_factor/

Other notes

It uses a different fido2 implementation
forcing users to use two factor auth is not implemented
There is about 10x the amount of python code (5000sloc), so it is much harder to review
It is based on django-otp, even though the author of that said that there is a fundamental mismatch. I have to investigate that further.
It uses the WizardView from formtools to implement multi-stage authentication
For some (historic?) reason it requires phonenumbers. What is worse, it requires an outdated version.

I love django-two-factor-auth and this is the best approach for a traditional django implementation.
Unfortunately if a preexisting and enterprise level authentication system, based on django and with SAML2, OAuth2 and OpenID Connect, is more difficult to get a good integration with an MFA without huge reworking and efforts.
I have tested all the mature MFA libraries ready for django and I found in django-mfa3 the best code and the most flexible and impactless approach, then I have decided to use this (and helping developments as well) for my SAML2 and OpenID Connect (Identity) Providers.
simplicity is a feature, code readability is a value, quick and smart interaction with the authors is unvaluable.
thank you @xi

Just to give you an example, this issue never got a formal answer
https://github.com/jazzband/django-two-factor-auth/issues/641


[RIP-9] Add the system configuration option doc: Direct ByteBuffer me…

[RIP-9] Add the system configuration option doc: Direct ByteBuffer memory size

LGTM

@Crab2died  Can you adjust you PR content formate?You can refer to others.


Please help with the example

Hello, sorry to write here, but I'm still a very young developer, and please provide me with an example of reading a string from the memcached storage-I can't really find anything on the Internet on this topic.
I tried this, but it doesn't return the expected string...
    Memcache first_client("--SERVER=<IP_ADDRESS>:11211");
    first_client.addServer("<IP_ADDRESS>", 11211);
    std::vector<char> ret_val;
    ret_val.resize(100);
    bool a = first_client.get("HLWRD", ret_val);
    for (auto const &element: ret_val)
    std::cout << element << ' ';

Please give an example of reading a string by a key! very necessary!

I guess you wanted to use std::vector::reserve() instead of ::resize().
Please direct your general programming questions to an appropriate medium, this is an issue tracker, thus not an appropriate place, thanks.

@m6w6 - I have been waiting for a week for an answer to this question on the sites stackoverflow.com and qna.habr.com, But I didn't get anything except one comment, it seems that no one uses this library at all - I can't even find examples in google

I actually wrote here already out of desperation...

I already gave you the answer. It is a C++ STL usage error, not libmemcached usage error.


Postcard from Google Earth

#googleearth https://earth.app.goo.gl/?apn=com.google.earth&isi=293622097&ius=googleearth&link=https%3A%2F%2Fearth.google.com%2Fweb%2F%4033.58312717,-84.30863213,265.42439118a,1428.91318522d,35y,101.32859907h,0t,0rhttps://www.jw.org/en/library/bible/

https://github.com/Jwcp2424/Go-Away-in-the-name-ofJehovah-/issues/405


Copy file from container to host

Is there a way to copy data from a running container to host, in this case to copy a file.
What I found as some possible solutions:

Using docker.exec(). To execute a command like "cat ./file.log" - and send back output as stdout.  link, but didn't work.

To use .getArchive and .putArchive - but it seems this works only with *.tar files.

He is my working example. If you have some recommendation to make it better will be tankfull:
       const docker = new Docker({ socketPath: process.platform === 'win32' ? '//./pipe/docker_engine' : '/var/run/docker.sock' });
       const container = docker.getContainer("docker_id");

       const newStream = require('stream');

        const stdoutStream = fs.createWriteStream("./test.log", {flags:'a'});

        var options = {
          Cmd: ['cat', 'catch_me.log'],
          WorkingDir: "/var/log/service",
          Tty: false,
          AttachStdout: true,
          AttachStderr: true,
          AttachStdin: true
        };

        await new Promise((resolve, reject) => {
          container.exec(options, function(err, exec) {
            if (err) {
              reject('Container exec failed!')
              return;
            }
            if (exec) {
              exec.start({ hijack: true}, function(err: any, stream: any) {
                if (err) {
                  reject('Container start execution failed!')
                  return;
                };

                var stdout = new newStream.PassThrough();
                var stderr = new newStream.PassThrough();
                container.modem.demuxStream(stream, stdout, stderr);

                stdout.on('data', function (chunk: Buffer) {
                   stdoutStream.write(chunk);
                });

                stream.on('end', () => {
                  stdoutStream.close();
                  console.log('Close stream')
                  resolve('Ready')
                });

                exec.inspect(function(err, data) {
                  if (err) {
                    reject('Execution Inspect failed!')
                    return;
                  };
                });
              });
            }
          });
        })```

+1


Feature/include dependency build in lifecycle

When using the Helm custom lifecycle
<packaging>helm</packaging>
The user will get an error if the chart has dependencies not downloaded yet to the local filesystem. We can solve it by enriching the custom lifecycle created and binding the helm:dependency-build to the prepare-package phase.

Thanks for the PR.
I run in the same Issum like #81. My chart use a helper function from a remote subchart. But helm lint falls because the subchart is not downloaded yet at this maven phase.
So I think the dependencies download should be bind in the pre-test phase at least.


fix(transformer): TypeScriptOptions deserialize should fallback to default

#3012  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


这也没有一个可用的文档或者daemon学习?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
好歹给点使用文档和范例呀

中文文档目录：https://github.com/baidu/bfe/blob/develop/docs/zh_cn/SUMMARY.md
安装说明：https://github.com/baidu/bfe/blob/develop/docs/zh_cn/install.md
使用示例：https://github.com/baidu/bfe/blob/develop/docs/zh_cn/SUMMARY.md 中使用示例 章节

如果遇到其它问题欢迎反馈


Efficient way to format directly to hstring

This introduces a new API, winrt::format, the exact equivalent of std::format (including compile-time format string checking), that efficiently formats to an hstring by using hstring_builder. It avoids the copies that would be required if using std::format.
Note that this will only light up on VS 17.5 Preview 1 (which is not available to the public yet), but I've manually tested it on VS 17.4 previews by changing std::wformat_string to std::_Fmt_wstring (the internal name before it became a public API).

Note that this will only light up on VS 17.5 Preview 1 (which is not available to the public yet)

Would this work on Clang? I'm reluctant to merge this in until we can test it.

It depends on changes in the STL, but it should work in Clang once VS is updated.

I meant we could use Clang to test it so long, but yes if its STL-dependent then we'd have to wait for MSVC to catch up.

Clang also uses the MSVC STL on Windows, so it's also blocked on 17.5 preview 1. I'm totally okay with waiting for a preview release before merging, I just opened this because it's work I had already done.

It's very cool - similar to Rust's format so this is lovely. ❤

Commenting to avoid closing. This is stale because it's blocked on VS 17.5

Going to look at this soon, VS 17.5 preview is out now

Just took a look: this works fine on 17.5 Preview 1 with no changes needed 🎉

Looks good - I assume the CI build isn't yet validating this as its still using a previous version of the compiler. Is that correct?
@DefaultRyan did you want to take a look at this?

I would assume so as well, since 17.5 is preview only at the moment.

@kennykerr any chance of making a new release? I'd like to start using this

Coming up! (2.0.221117.1)

fyi, wil has std::str_printf, but does not support winrt::hstring, so this is a useful improvement.

Could you add winrt::format for older versions using the internal API (on MSVC at least) or simply being a wrapper on std::format that copies the result into an hstring?

No, because the STL team strongly recommended against using the internal std::_Format_string (so we cannot just wrap std::format either, being able to wrap it was the entire reason for std::format_string to be made public), and std::vformatted_size would be required if we decided to just take a normal std::wstring_view for the format string, but that API does not exist.
You need to use VS 17.5 for this.


websocket fails to determine global this in SvelteKit SSR

I've been trying to isolate an issue which occurs when I try to use @supabase/supabase-js in SvelteKit; it appears supabase-js uses websocket, which uses es5-ext to try and robustly identify a globalThis across browsers in this block of code:
try {
    _globalThis = require('es5-ext/global');
} catch (error) {
} finally {
    if (!_globalThis && typeof window !== 'undefined') { _globalThis = window; }
    if (!_globalThis) { throw new Error('Could not determine global this'); }
}

Unfortunately, this fails in SvelteKit:
5:49:56 PM [vite] Error when evaluating SSR module /node_modules/websocket/lib/browser.js?v=f34fcf64:
Error: Could not determine global this
    at /node_modules/websocket/lib/browser.js?v=f34fcf64:7:28
    at instantiateModule (/home/ixxie/repos/minex/node_modules/vite/dist/node/chunks/dep-66eb515d.js:69030:166)

To reproduce this, run the following in an empty folder:
npm init svelte@next
npm install
npm install websocket
sed -i "s/<script>/<script>\n\timport { w3cwebsocket } from 'websocket';\n\tconsole.log(w3cwebsocket);\n/" ./src/routes/index.svelte
npm run dev

It seems es5-ext is a dead project; at least it hasn't had any Github activity in the last year. I noticed the seems to be globalThis support in all major browsers since spring of 2019 (except Edge, which got support in January 2020); perhaps this could resolve the issue?

@ixxie thanks for bringing this up and pointing out the new globalThis support. I've updated the code to check for and use globalThis first if it's available.
As for es5-ext, it still gets 10,643,967 weekly downloads according to npm, so I wouldn't exactly call it dead. It's one of those types of projects that, once it's done, working, and stable, probably doesn't really require much ongoing change or maintenance. This situation, however, may be an exception to that. Let me know if websocket-node v1.0.34 resolves your issue.

@theturtle32 thanks for the rapid response! This resolves the issue successfully, although now I am running into challenges relating to ESM interoperability (but this is a different scope - I will raise a different issue if appropriate).


helm tillerless does not accept sane arguments

When running helm in tillerless mode (recommended) you need to set sane defaults to avoid issues. The helm tiller plugin illustrates this nicely https://github.com/rimusz/helm-tiller/blob/master/scripts/tiller.sh#L5. Obviously secret storage and max history is important if you care about security and stability in your cluster. Therefore we should probably allow people to pass in a map of arguments to pass to tiller when starting in tillerless mode easily?

@willejs Good point!
I'd gladly accept PRs that enhances the config syntax to accept respective tiller args per release, and under helmDefaults:

tillerStorage
tillerHistoryMax

I don't think we need other options.
Especially for tiller port and tiller probe port,  I believe they should be computed automatically to not collide, while removing the restriction of 1 concurrency when tillerless is enabled #694

Sounds good @mumoshu I will put together a pr. Sorry i started the issue to track this and make everyone aware whats missing and meant to say i will have a go at improving it. Thanks for the lightening fast feedback!

In addition to that,

for tiller port and tiller probe port, I believe they should be computed automatically to not collide

But perhaps we'd want tillerPortMin and tillerPortMax and eventually tillerPortBlacklist to instruct helmfile to use available ports for tiller. Alternatively we can automate it by trying to bind the port beforehand, so that we can decide the port is available for use by tiller.

...But that's an another story and I believe it isn't a must-have for the first impl.


running make -C just install requires sudo

env
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 21.04
Release:        21.04
Codename:       hirsute

when following the setup in just/readme.md
the cmd make -C just install fails
make: Entering directory '/home/poop/git/foss/justjs/just/just'
mkdir -p /usr/local/bin
cp -f just /usr/local/bin/just
cp: cannot remove '/usr/local/bin/just': Permission denied
make: *** [Makefile:123: install] Error 1
make: Leaving directory '/home/poop/git/foss/justjs/just/just'

but it does work with sudo...
poop@spaceship:~/git/foss/justjs/just$ sudo !!
sudo make -C just install
make: Entering directory '/home/poop/git/foss/justjs/just/just'
mkdir -p /usr/local/bin
cp -f just /usr/local/bin/just
make: Leaving directory '/home/poop/git/foss/justjs/just/just'

related

usr/local permissions

Hello @noahehall  I am not a dev in this repo.  Running 'make install' in almost any project will fail because the build system assumes you want to install into system-controlled directories, not to directories in the user's home.  So 'sudo' is normally expected if one runs 'make install' with no modifications.  However, this is also usually able to be overridden by changing an ENV variable.
I opened the Makefile for this project and noticed that it uses ENV variable 'INSTALL' as the prefix path for where the binary will be installed.  If you take a look yourself, you'll see that this does indeed default to a system-controlled path.  If you want to be able to install it locally, add an ENV variable assignment to with your make command like so:
$ INSTALL=~/bin; make install
and then it will use the path you specify as the installation dir.  Of course you can do things to make this permanent (including editing the Makefile to use your preferred default INSTALL value) if you want.

thanks @mkvalor!


Fixing command-line option name

The command-line option --unstable-options does not exist, but --unstable-features does. From rustfmt --help:
--unstable-features
                Enables unstable features. Only available on nightly
                channel

Thanks!


Add support for dict values in the expert mode (#5039)

Pull request opened by the merge tool on behalf of #5039

Merged in 3b0d15848e04e835b0387f11a08a2e161294c400


CoinMarketCap

Pull request checklist

[ ] Did you bump the project version?
[ ] Did you add a description to the Pull Request?
[ ] Did you add new tests?
[ ] Did you add reviewers?

@pseagal thanks for the PR, I think Coinmarketcap should be a separate library.


Use pyproject.toml to manage dependencies

All dependencies are now defined in pyproject.toml and most are installed with poetry install. Conda dependencies are put in custom sections in the file and you have to use scripts/make_deps.py to generate a requirements.conda file. scripts/install-deps-[g/c]pu.sh will do it for you.
This also moves some scripts into scripts/.
Oh, and PyTorch is upgraded to 1.3.0. Unfortunately there are a few errors with 1.4.0 (to investigate).

I like the consolidation, but there are several disadvantages for me:

installing the package locally is harder (pip install -e .)
most dependencies are now managed through pip instead of conda and we need to mix a virtualenv with a conda env to install
The only way for a user to install everything is to use the ci install scripts and those make several assumptions that do not apply to random user machines
The resulting install (even if done manually) mixes packages from conda with a virtualenv which is generally a bad idea.

  So I am against this PR.

Maybe this can help: https://github.com/eigentechnologies/cpip

@abergeron

installing the package locally is harder (pip install -e .)

poetry install performs a local install into the active conda env or virtualenv. It won't install the conda packages, but neither does pip install -e .

most dependencies are now managed through pip instead of conda and we need to mix a virtualenv with a conda env to install

Several of our dependencies are not available on conda anyway, so I'm not sure what difference it makes. We already had to use pip. Poetry will install into a conda environment if it is activated.

The only way for a user to install everything is to use the ci install scripts and those make several assumptions that do not apply to random user machines

Which assumptions? Anyway, perhaps it'd be better to commit the requirements.conda files.

The resulting install (even if done manually) mixes packages from conda with a virtualenv which is generally a bad idea.

This was already the case, no?

Maybe this can help: https://github.com/eigentechnologies/cpip

Hm, maybe.

most dependencies are now managed through pip instead of conda and we need to mix a virtualenv with a conda env to install

Several of our dependencies are not available on conda anyway, so I'm not sure what difference it makes. We already had to use pip. Poetry will install into a conda environment if it is activated.

Yes we had to use pip, but now there is (potentially) a virtualenv on top of that.  poetry will create a virtualenv if you are in the base environment of conda

The only way for a user to install everything is to use the ci install scripts and those make several assumptions that do not apply to random user machines

Which assumptions? Anyway, perhaps it'd be better to commit the requirements.conda files.

Like that you want to install the conda packages in the current env (which might be the base one).  I do this, but other people hate it.

The resulting install (even if done manually) mixes packages from conda with a virtualenv which is generally a bad idea.

This was already the case, no?

Not unless you explicitly create a virtualenv.

Maybe this can help: https://github.com/eigentechnologies/cpip

Hm, maybe.

Also I found this too: https://pypi.org/project/poetry2conda/
It goes a long way for me since I could just generate a conda env file from the poetry (minus the conda requirements).  With some wrangling it could be a better alternative than cpip since that seems like an unholy mess of bash functions with very little error checking and doesn't work on mac.

most dependencies are now managed through pip instead of conda and we need to mix a virtualenv with a conda env to install

Several of our dependencies are not available on conda anyway, so I'm not sure what difference it makes. We already had to use pip. Poetry will install into a conda environment if it is activated.

Yes we had to use pip, but now there is (potentially) a virtualenv on top of that. poetry will create a virtualenv if you are in the base environment of conda

Okay, true. I kind of feel the base environment should never be used, but it's true that we should still support all workflows whenever possible.

The only way for a user to install everything is to use the ci install scripts and those make several assumptions that do not apply to random user machines

Which assumptions? Anyway, perhaps it'd be better to commit the requirements.conda files.

Like that you want to install the conda packages in the current env (which might be the base one). I do this, but other people hate it.

I see. It's not too hard to activate the desired target env before running the script, but point taken.

Maybe this can help: https://github.com/eigentechnologies/cpip

Hm, maybe.

Also I found this too: https://pypi.org/project/poetry2conda/
It goes a long way for me since I could just generate a conda env file from the poetry (minus the conda requirements). With some wrangling it could be a better alternative than cpip since that seems like an unholy mess of bash functions with very little error checking and doesn't work on mac.

Okay, that sounds good. I can try messing around with it and see if it generates a good env file.

Something that could help is that pytorch has pypi packages and it might be possible to wrangle some wheels out of tvm.  They have the appearance of working but I suspect it's never tested and it doesn't seem to work when I tried.
If I have some time I can try to get it to work and add a section to the packages repo to build some wheels that are not horrible.  I don't know where we would publish them though and I don't want to put them on PyPI since I don't want to be the official maintainer of said wheels for the larger public.

I think we can install wheels from a GitHub URL (or any URL).

Just to leave a trace but I also found this: https://direnv.net
It could be useful to automatically activate the relevant environment when entering the project dir.

There should be a new version of poerty2conda out next Monday (June 1st) that has some modifications that should help us solve all of our issues.

I did a rebase and some work to make the file pyproject2conda compatible.
There are some package specifications that break poetry (because they are not available on pip), so we would need a solution for that.  Those are currently commented out.

I have no idea what jenkins doesn't like and the certificate is expired so I can't check.

Now that we have access to jenkins, I fixed the last few problems with the CI so this is ready to go in.


It is no longer possible to return null with defineRender

Hi, after this change e74058c it's not possible to return null or undefined with defineRender. RenderFunction allowed to return null. Is this behavior correct?

Fixed, thanks for your feedback


ambiguous licence position

You depend on https://github.com/outworkers/phantom which is licenced under a dubious proprietary licence including such gems as
"You may not publish any tutorials or educational material on phantom, any blog posts or any written published content on phantom without our explicit written consent."
and
"any new clause provided by future updates of this license will apply to all existing versions of phantom irrespective of any timeframe."
Indeed several members of the scala community have received takedown notices of their blog articles.
Explicitly noting in https://github.com/outworkers/phantom#license-and-copyright that "it is not provided under an OSS license." (emphasis mine)

Phantom has been removed.

Congratulations!


Should Widgets be entities? - Artemis Queues

Can multiple of the same component be added to a single entity?
If so, is that order consistent?
Both Widgets & Dialogues could be a horizontal queue or vertical stack does that make sense as entities though as it's on a per player basis?

An entity can only have one of each component.
Dialogues will need a queue inside of a component:
queue: LinkedList<SuspendingCoroutine>
Which will need it's own system for addition and removal but it doesn't make sense to handle these as entities.
The current widget system is functional and there's no reason to rewrite it at this point in time.


Actually use the xp parameter.

This changes addOreSmelting(String, ItemStack, float) to actually use its last float parameter, instead of always using 0.2. It also adds a new function, addOreSmelting(String, ItemStack) to call addOreSmelting(String, ItemStack, float) with the float value of 0.2.

Great catch, thanks!


Add contribute.md for better documentation for PRs

@arihan01 could you pls assign me this

done

Hii can you please assign this to me?


Fix for error messages when VPC is used and some other minor optimizations

Issues summary:

Fix for situation when a security group is assigned a valid vpc_id upon which the EC2 API expects 'ip_protocol', 'from_port' and 'to_port' parameters to be also supplied.
Replace the fixed timeout and wait for SSH-ability of the slave instances.
Fix for situation when several slave proceses running in parallel end up sending create a new security group request to the EC2 API resulting in error messages popping in the console saying that a security group with the specified name already exists. We make sure that the corresponding security group is already created before launching pool of processes.
Add Name tag to EC2 locust-swarm instances to simplify their identification in the AWS console.

Coverage decreased (-2.29%) to 36.01% when pulling f30afd6f3013401566dff92ad59224efdbc5b01b on syrgak:master into bd652b7fb6fc2c0cb23ef2b6a7f0c5abd80973d7 on ryankanno:master.


Issue 19 - add fixes to problems identified by ruff

I added a development configuration for ruff (as linter/formatter) and went through most of the problems it raised.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update
[ ] This is a documentation update

Action Checklist

[X] Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
[X] Fork the pyani-plus repository under your own account (please allow write access for repository maintainers)
[X] Set up an appropriate development environment (please see CONTRIBUTING.md for this repository)
[X] Create a new branch with a short, descriptive name
[X] Work on this branch

[X] style guidelines have been followed (please see CONTRIBUTING.md for this repository)
[X] new code is commented, especially in hard-to-understand areas
[ ] corresponding changes to documentation have been made
[X] tests for the change have been added that demonstrate the fix or feature works

[X] Test locally with pytest-plus -v non-passing code will not be merged
[X] Rebase against origin/master
[X] Check changes with linting/formatting tools before submission (please see CONTRIBUTING.md for this repository)
[X] Commit branch
[X] Submit pull request, describing the content and intent of the pull request
[X] Request a code review
[ ] Continue the discussion at Pull requests section in the pyan-plus repository

The changes required to fix #19 appear to have already been merged into the main branch. For instance, the last commit on issue_19 is a1fc9cc, but the same changes have been merged into main under commit 0187278. I don't think this PR needs to be retained.


Names of entities messed up

Version of the integration
Version 2.2.0
Configuration
Tapo Switch P110, Firmware 1.2.3 Rel 142542
Describe the bug
After integration the switch with version 2.2.0, the names of the entities are messed up, the name of the device is doubled.
The device name ist Stecktdose_Powerventilator:
sensor.steckdose_powerventilator_steckdose_powerventilator_month_energy
Two other switches, integrated with a version <2.0 , are correct.

Well, still not right, know all entities got the same name:
sensor.steckdose_powerventilator
sensor.steckdose_powerventilator_2
sensor.steckdose_powerventilator_3
sensor.steckdose_powerventilator_4
sensor.steckdose_powerventilator_5
sensor.steckdose_powerventilator_6
The Type of entities in the name is now missing.

Have you try to remove and re-add device?

Yes, because the names didn't change from "sensor.steckdose_powerventilator_steckdose_powerventilator_month_energy" to
"sensor.steckdose_powerventilator_month_energy" that i have expected.
So after the removal and readd the names where "sensor.steckdose_powerventilator", "sensor.steckdose_powerventilator_2" and so on.

Well, still not right, now all entities got the same name:
sensor.steckdose_powerventilator sensor.steckdose_powerventilator_2 sensor.steckdose_powerventilator_3 sensor.steckdose_powerventilator_4 sensor.steckdose_powerventilator_5 sensor.steckdose_powerventilator_6
The Type of entities in the name is now missing.

Its the same for me.

I don't understand if you are using version 2.3.0? The issue is related to 2.2.0

Yes, because the names didn't change from "sensor.steckdose_powerventilator_steckdose_powerventilator_month_energy" to "sensor.steckdose_powerventilator_month_energy" that i have expected.
So after the removal and readd the names where "sensor.steckdose_powerventilator", "sensor.steckdose_powerventilator_2" and so on.

Sorry, I don't understand: are you using version 2.3.0? The issue is related to 2.2.0

Yes, i used 2.3.0.

@saschaabraham I'm working on a fix, this is that:

New version of home assinstant handles entity name in a different way. So in your device resume you will get the entity name of plug and sensor are without "Portatile" prefix cause relates to same device:

The section "All entites" show you entities with prefix "Portatile":

The dashboard behaves differently. If you create a group of entity (or  the ones created automatically created by dashboard) you will see something like point 1.
If you add a specific entity the dashboard assign a complete friendly name (left side of image below)

I have checked the 446 branch and now the entities are correct.
switch.steckdose_powerventilator
sensor.steckdose_powerventilator_current_power
sensor.steckdose_powerventilator_month_energy
sensor.steckdose_powerventilator_month_runtime
binary_sensor.steckdose_powerventilator_overheat
sensor.steckdose_powerventilator_signal_level
sensor.steckdose_powerventilator_today_energy
sensor.steckdose_powerventilator_today_runtime


Deletion button being disabled

Description
Fixes #1398
Fix state and text color of the deletion button if the operation is aborted. Changed state and text if user clicks "OK" to delete photo.
Tests performed
Tested on {API level & name of device/emulator}, with {build variant, e.g. ProdDebug}.
{Please test your PR at least once before submitting.}
Screenshots showing what changed
{Only for user interface changes, otherwise remove this section. See how to take a screenshot}

Codecov Report

Merging #1403 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1403      +/-   ##
=========================================
- Coverage     3.3%    3.3%   -0.01%
=========================================
  Files         128     128
  Lines        6837    6841       +4
  Branches      669     668       -1
=========================================
  Hits          226     226
- Misses       6596    6600       +4
  Partials       15      15

Impacted Files
Coverage Δ

...fr/free/nrw/commons/settings/SettingsActivity.java
61.11% <ø> (ø)
:arrow_up:

...c/main/java/fr/free/nrw/commons/AboutActivity.java
0% <ø> (ø)
:arrow_up:

...n/java/fr/free/nrw/commons/MediaDataExtractor.java
0% <ø> (ø)
:arrow_up:

...fr/free/nrw/commons/media/MediaDetailFragment.java
0% <0%> (ø)
:arrow_up:

...free/nrw/commons/upload/MultipleShareActivity.java
0% <0%> (ø)
:arrow_up:

...fr/free/nrw/commons/settings/SettingsFragment.java
28.57% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23f752...2fa7a4f. Read the comment docs.

It seems like you worked on your other PR #1402 . So there are unrelated changes here. Please remove them, then we can test it.

Great @gabrielaradu , congrats your first time contribution :dancer:


Upgrade to Livewire 3

This PR needs targeting at a new 3.x branch instead of 2.x.

Hmm, my only issue is that the branch versions / plugin versions are intended to match the Pest major versions.
@nunomaduro, what are your thoughts on this? 🤔 Unless we do some check for the version of Livewire you have installed, and switch between them?

@danharrin Can you support both versions, doing something like a class_exists, and define the trait witin the if and else??

Oh sorry, I thought the branching strategy matched Livewire. I can try the conditional approach, yeah

Alright it should be ok now 👍 Not worth merging before LW3 release as the tests will fail.

This should be ready for merge now.


html renderer

Description
This is a feature request.
I'ld like to be able to display an html page in atom, found nothing so far, I expected this package to do the trick. Nothing complicated, I've all inclusive tests reports, it's a waste of tome to have to open it somewhere else.

Can this package https://github.com/harmsk/atom-html-preview satisfy your request?

I switched to vscode since then.


Why plugin can clear a directory only BEFORE build?

What if I need to clear directory at the end of the build?
I need to build assets, create a zip file and remove everything in a directory except the zip file.
But looks like CleanWebpackPlugin everytime runs before all other plugins...
plugins: [
    new CleanWebpackPlugin(...),
    new CopyWebpackPlugin
    new StringReplacePlugin(),
    new ZipWebpackPlugin(...),
    new CleanWebpackPlugin(...)
]

Can you help me?

I'm seeing this too.

Same here.

remove old file after webpack build
https://github.com/jackypan1989/del-webpack-plugin

Hopefully resolved in #72.

For v2 use cleanAfterEveryBuildPatterns to solve this issue. Additional v2 Information can be found here.


Numba 0.53.0rc2 checklist

llvmlite

[x] merge & cherrypick https://github.com/numba/llvmlite/milestone/11
[x] merge change log changes

[x] https://github.com/numba/llvmlite/pull/703 (went to master)

[x] cherrypick changelog

[x] https://github.com/numba/llvmlite/pull/704 (includes changelog changes)

[x] annotated tag 0.36.0rc2 on release branch
[x] build conda packages on buildfarm
[x] build wheels (3.6, 3.7, 3.8, 3.9)
[x] upload wheels and sdist to PyPI
[x] Verify packages uploaded to Anaconda Cloud (numba main channel)
[x] verify wheels for all platforms arrived on PyPi

numba 0.53.0rc2

[x] Merge to release branch:

[x] https://github.com/numba/numba/pull/6763

[x] merge change log changes

[x] https://github.com/numba/numba/pull/6759

[x] cherrypick changelog

[x] https://github.com/numba/numba/pull/6759

[x] annotated tag 0.53.0rc2 on release branch
[x] build conda packages on buildfarm
[x] build wheels (3.6, 3.7, 3.8, 3.9)
[x] upload wheels and sdist to PyPI
[x] Verify packages uploaded to Anaconda Cloud (numba main channel)
[x] verify wheels for all platforms arrived on PyPi
[x] Send RC announcement email / post announcement to discourse group
[x] Post link to twitter

🎉


Add support for more than 8 files

The message would be
changed 16 files, deleted 2 files etc

Thanks for the interest.
This is a duplicate of #38.


Portfolio Template

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #267

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Explain the Testing instructions
Test Configuration:

Operating system:
Version:
Text-editors used:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@dexterousb did u make this template by your own ?
and did u add this in any other repo of our project because i have seen this template before

Made this template on my own , i have also contributed for Starbucks frontend UI that's why It will be showing again!


chore: Make Lighthouse CI run on local build

Motivation
Current setup to run Lighthouse on Netlify deploy previews is fragile and unreliable.
Notably the Wait for the Netlify Preview step which only waits for the first deployment, and then on the next commits will not wait, leading to a stale Lighthouse report.
Running on a local build is also less likely to fail
Test Plan
CI

cc @johnnyreilly I think I read your blog post on that topic and maybe you'd be interested to replicate this new setup?

cc @johnnyreilly I think I read your blog post on that topic and maybe you'd be interested to replicate this new setup?

Hey @slorber - do you mean this post? https://johnnyreilly.com/azure-static-web-apps-a-netlify-alternative

@johnnyreilly this one: https://johnnyreilly.com/lighthouse-meet-github-actions
You have a similar Static Web App - wait for preview step that imho is not ideal

I don't know - it's worked pretty well for me. But yeah, I'd be happy to help you with that. Would you like me to?

If you create a Static Web App for Docusaurus (they're free) then I can start the work of plugging my approach into the pipeline?

There'd be some CI fun and games but we could turn it out pretty fast I think

And you can leave the Netlify stuff running in parallel either permanently or until you want to drop it.

Essentially what you want is this I think: https://github.com/johnnyreilly/blog.johnnyreilly.com/blob/main/.github/workflows/build-and-deploy-static-web-app.yml
And use this to handle auth between Azure and GitHub: https://github.com/jongio/github-azure-oidc
If you find this tricky I can jump on a call; I've done this a bunch of times

@johnnyreilly I don't know what you mean here, I have no intention to switch to Azure 😅 and even less can convince Meta in a short time frame to do so.
I want to run lighthouse on a local build, which is what I did in this PR, and recommend you to adopt. If you are satisfied with your Azure setup, fine.
Remote urls are more flaky, depend on CDN availability/network, and the "wait for deployment" function is not super reliable and can easily lead to running lighthouse on a deployment url on subsequent deployments, misleading you. I prefer to use something entirely local.

oh right - I haven't set up Lighthouse to run on a local build before.  You can flip open devtools in Chrome and do that pretty easily though.  I guess this risk with running locally though, is that any extensions you have installed may pollute the results?

Maybe there's a way to do it with a docker container and spinning up Chrome headless inside?  Haven't done it myself though.

Maybe something like this could work? https://github.com/GoogleChrome/lighthouse-ci/tree/main/docs/recipes/docker-client

If you get Docusaurus running locally, does this work for you @slorber?
docker container run --cap-add=SYS_ADMIN \
  -v "$(pwd)/lhci-data:/home/lhci/reports/.lighthouseci" \
  patrickhulce/lhci-client \
  lhci collect --url="http://localhost:3000/"

@johnnyreilly I don't understand why you keep suggesting me things I don't look for 🤪 I don't want to run lighthouse locally, I want to run lighthouse on a local build (instead of a remote url), in the CI, in an automated way. It is working fine already 😅 I don't want to use docker inside github actions, there's no browser extension there

No you misunderstand me!
If I understand you correctly, you want to run lighthouse locally on a local build.
I'm suggesting that you can do that by running locally by spinning up Docusaurus with yarn build && yarn serve and then running the following in a separate process:
docker container run --cap-add=SYS_ADMIN \
  -v "$(pwd)/lhci-data:/home/lhci/reports/.lighthouseci" \
  patrickhulce/lhci-client \
  lhci collect --url="http://localhost:3000/"

This should allow you to run locally and run lighthouse locally without being subject to extensions running on your version of Chrome.  Does that make sense?

I'm actually not totally sure what you're trying to do.

I'm not trying to do anything now, it's done already in this PR and working as I want it to 😅

@johnnyreilly To clarify: the "local" here does not mean on your very own machine. It means building and serving the website within the action runner, where the lighthouse is also run.

ahhhhhh.  I get it.  That's totally not what I took from "local" 😆


Logic for handling duplicate image uploads

Warn on uploading a duplicate?
Reference count?
How to handle duplicates across users?

What does duplicate mean:

this image has been added to this collection already?
somebody added this image to another collection somewhere?

I think we should allow people to add the same image to different collections - that's an interesting result. For example, someone adds an image to a private collection, and then someone else finds it online somewhere in the public domain, that's also interesting.
I think we can decouple the "identity of an image" (defined in the context of a collection) from the "entity of an image" (defined by its unique hash). If that's right, then the "duplicates" we wish to avoid are duplicate image identities (same image in the same collection). In that case, adding the same image twice could be a no-op (de-bounce style).

Initially I thought this might be a problem - maybe in some circumstances we just want to alert a user that they're re-uploading the same entity. But maybe it won't be all that common and not a big concern. Let's keep this as a low-pri issue and see if we start to run into cases where we want to dedupe.

I'm tempted to:

return 201 if this is the first time the image was added to this collection
smile and wave (200) if this is not the first time the image was added to this collection
reveal no information about the fact that this image is or is not already in another collection.

nb: @koriaf this ticket relates to the conversation we were having somewhere about how to handle duplicates. In summary: duplicate (avoid) means the same image twice in the same collection...

I agree

we calculate hashes of images before saving them
we just ignore images which are already uploaded (user sent 20 images but 18 were uploaded and total number increased from 100 to 118)

I think most of the uploads will be bulk so no problem here, they won't notice and don't need to. In the future we might improve API responses to return slightly different responses (both success) so JS client can understand what's going on and display stats to the user - if decides to do so. In the end it doesn't matter, I want this image in the collection, it's there, good.

201 = yes I added it
200 = sure no problem (it was already there)


Added multiple subdomain wildcard example

Added example showing multiple-subdomain effect of top-level wildcard

Docs Build status updates of commit f56e380:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/firewall/firewall-faq.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off


Add tests for out-of-tree platform support

This PR is a WIP for adding tests for out-of-tree platform support. I originally had issues with this, so I want to give it a try in a separate pull request. None of these issues appear on my machine while running these tests as of this rebase - if everything seems okay on CircleCI after this rebase against master, I will ditch the [WIP] tag. Otherwise, I will see if I can find a way to make this work.
The bunch of JS files that will give this a "Large PR" tag are in RNTester/js/OutOfTreeTestPlatform - they are only used by the bundler and not executed at any point in time. So if another file needs to be added when React Native's module structure changes, you do not need to have a functional JS file in there as a stub. module.exports could be null if you wanted. I just had copied over stubs from Libraries because I wanted a non-trivial haste module map to be in the test.
Test Plan:
A test has been added to hasteImpl.js's test, so you can try it out by running yarn test. I've added an e2e test for running the bundler on this "dummy" platform.
Release Notes:
[CLI] [ENHANCEMENT] [jest/hasteImpl.js] The hasteImpl is now aware of whether it's in React Native CI, and will change where it looks for "plugins" accordingly
[CLI] [ENHANCEMENT] [jest/tests/hasteImpl-test.js] hasteImpl.js' plugin support is tested
[INTERNAL] [ENHANCEMENT] [ContainerShip/scripts/run-ci-e2e-tests.sh] Bundling the "dummy" platform is now part of the E2E test
[INTERNAL] [ENHANCEMENT] [package.json] The "dummy" platform has been added as a devDependency

Warnings

:warning:

:lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

:warning:

:clipboard: Release Notes - This PR may have incorrectly formatted Release Notes.

:warning:

:exclamation: Big PR - This PR is extremely unlikely to get reviewed because it touches 717 lines.

  Generated by :no_entry_sign: dangerJS

Yep, still the same issue: (test_objc)
error: bundling failed: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: react-native-dummy
  Paths: /Users/distiller/react-native/RNTester/js/OutOfTreeTestPlatform/package.json collides with /Users/distiller/react-native/node_modules/react-native-dummy/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at setModule (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:462:17)
    at workerReply (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:512:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)
::1 - - [31/Aug/2018:02:11:31 +0000] "GET /IntegrationTests/IntegrationTestsApp.bundle?platform=ios&dev=true HTTP/1.1" 200 - "-" "RNTester/1 CFNetwork/901.1 Darwin/17.4.0"
error: bundling failed: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: react-native-dummy
  Paths: /Users/distiller/react-native/RNTester/js/OutOfTreeTestPlatform/package.json collides with /Users/distiller/react-native/node_modules/react-native-dummy/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at setModule (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:462:17)
    at workerReply (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:512:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Will have to come up with a way to fix this.

The dummy platform has been moved to its own module/repo, and tests look much better now!
https://github.com/react-native-community/react-native-dummy
https://www.npmjs.com/package/react-native-dummy

test_android failure is unrelated. again.
No build file at ReactAndroid/src/main/java/com/facebook/thecount/BUCK when resolving target //ReactAndroid/src/main/java/com/facebook/thecount:thecount.

This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook/thecount:thecount' of target '//ReactAndroid/src/main/java/com/facebook/react/bridge:bridge'

Rebased against master and things look better 👌

Not sure what it got caught on

Re-trying.

@empyrical the internal diff is failing JavaScript tests:
 FAIL  jest/__tests__/hasteImpl-test.js
  ✕ returns the correct haste name for a file with an out-of-tree platform suffix (34ms)
  ○ skipped 6 tests

  ● returns the correct haste name for a file with an out-of-tree platform suffix

    expect(received).toEqual(expected)

    Expected value to equal:
      "AccessibilityInfo"
    Received:
      "AccessibilityInfo.dummy"

      58 |         ),
      59 |       ),
    > 60 |     ).toEqual('AccessibilityInfo');
         |     ^
      61 |   }
      62 | });
      63 |

      at Object.<anonymous> (jest/__tests__/hasteImpl-test.js:60:5)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 6 skipped, 7 total
Snapshots:   0 total
Time:        0.518s, estimated 1s
Ran all test suites related to changed files.

Very weird that it is working in OSS but not internally. Since react-native-dummy is a new dependency, do you have internal checks/approvals that need to be done to allow new dependencies through?

Or -- would adding the changed yarn.lock to this PR help?

I did have to take care of that internally, since we have an offline yarn mirror.
Let me re-import, as the internal diff might be out of date.

I am still working on this. Will update soon.

I'm at a loss. Jest is still failing the new test case when run internally:
 ● returns the correct haste name for a file with an out-of-tree platform suffix

    expect(received).toEqual(expected)

    Expected value to equal:
      "AccessibilityInfo"
    Received:
      "AccessibilityInfo.dummy"

      58 |         ),
      59 |       ),
    > 60 |     ).toEqual('AccessibilityInfo');
         |     ^
      61 |   }
      62 | });
      63 |

      at Object.<anonymous> (jest/__tests__/hasteImpl-test.js:60:5)

So, the reason that test would fail is because findPlugins isn't able to see the react-native-dummy platform for some reason.
https://github.com/facebook/react-native/blob/f5dd2c48c9e557127785aadafc86dec5a6fc4444/jest/hasteImpl.js#L16-L26
In hasteImpl, I've set it to look in ../node_modules if it detects that it is being ran as part of React Native's tests, rather than ../../../node_modules where it's inside of a react native project. It does this detection by checking if the cwd() is the parent directory. It is possible that cwd() may be different somehow for the internal tests.
If you were to have a console.log or something there to print the value of the REACT_NATIVE_CI variable, does it show up as true or false? If it's false that may be the issue and I'd have to come up with a different way to detect if it's in CI.

A-ha! We're using Yarn Plug-n-Play, so node_modules is not a thing in the environment these tests are running.

The way that findPlugins currently works is it doesn't use require.resolve or anything like that - it concats the input directory + node_modules + {module_name} + package.json.
https://github.com/facebook/react-native/blob/4b106be47765dd391f7a4cc6cf0e705ae977b90a/local-cli/core/findPlugins.js#L104-L111
It looks like RNPM will need to be adapted to work with Yarn Plug 'n Play. For now, perhaps this test could somehow be skipped on the internal test suite until YPNP is made public?

Actually - perhaps I could modify the test to skip itself if the node_modules folder isn't detected.

@hramos I modified the hasteImpl test to skip if node_modules/react-native-dummy isn't present. Will this pass in the internal test suite?

Sorry for the delay. I just incorporated your updates into the internal diff. Will merge if tests pass. Thanks!


Not working with Laravel 5.4?

Hi,
first of all thank you for this greate package!
Will there be any Laravel 5.4 support?
Because I saw in the commits that you reverted the 5.4 support.
There are errors when trying to create an entity with your package.
Type error: Argument 1 passed to Rinvex\Repository\Listeners\RepositoryEventListener::entityCreated() must implement interface Rinvex\Repository\Contracts\RepositoryContract, string given
Regards,
CewlBird

Yes, Laravel 5.4 support will be available very soon on the dev-develop branch and then will make it to the next major release later on, but the 2.x branch will kept compatible with up to L5.3.

Awesome. glad to hear that.
Again thank you for this great work, really looking forward for more awesome stuff!

@Omranic Hi. Do you have an ETA ?

Hi.
There's an issue with latest dev-develop branch.
$repo->setCacheDriver('foobar');

Doesn't throw any error as 2.0.2 do.

This Midnight UTC 😬

Fixed on dev-develop please composer update & post again if there's still any other issues. Sorry for the long wait 🙂  e2226399eb315f84f5ef3398c1ccdfec8540b56c

Thank you very much :)


[Feature Request] Loading images for token classification

Is your feature request related to a problem? Please describe.
There is no way (as far as I can tell) to display images in the app. This causes difficulties when annotating text from OCR, especially since the text is often in a bit of a weird order and the image provides valuable context.
Describe the solution you'd like
When tagging tokens for NER that come from OCR text, it would be helpful to have the image beside the text.  Support for loading images next to text for token classification would be appreciated.
Bonus points if the text NER annotations are reflected on the image :)
Describe alternatives you've considered
I mean, I guess I could make the PR/code change myself, I just haven't had time to dive into it
Additional context
Document Understanding and OCR is a hot topic recently (Donut, LayoutLMV1/2/3, LiLT, UDOP). Support in the app for tasks related to it (like NER), would be very cool.

Hi @logan-markewich, @burtenshaw actually made a really cool hack to be able to do this.

@davidberenstein1957 Perfect timing!! Is there any plans to merge that @burtenshaw ? Otherwise I'll try out your branch

@logan-markewich Merging the hack requires some upstream work. For now, you can do any of these:

pull the image burtenshaw/argilla-image
duplicate my HF space: https://huggingface.co/spaces/burtenshaw/argilla-image
build from the fork: https://github.com/burtenshaw/argilla

I'm also working on a tutorial at the moment that uses it.

@burtenshaw cool, that should work!


Regarding GAIL dataset

Thanks for such clear code!
l have some questions on the dataset provided by https://drive.google.com/drive/folders/1h3H4AY_ZBx08hz-Ct0Nxxus-V1melu1U.
Does this dataset contains multiple full episodes or subsample the episodes as openai/imitation did?
Thanks!

@fiberleif Hi have you figured out how to interpret the expert data? I'm quite confused too.


pull request for e2e test at 01/11/2017 05:56:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


autocomplete scroll

Can you do all computations in adjustScroll instead of moveUp and moveDown?
Let's cache this.els.hints.children[this.selectedIndex] into variable.


[DUOS-2009][risk=no] DAA Acceptance Modal on SO Console

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2009

Have you read Terra's Contributing Guide lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

Good work Connor!
Not sure if this is in scope, but you might want to check with the product owner: how can a signing official see these two links again if they need to reference them?

One bit of visual feedback while I review the code. Note how the modal loads behind the tab border:

Second piece of visual/UX feedback. I have a UX objection to a modal that is not cancelable. We should add a cancel button and if the user has not accepted the terms, then all features should be disabled. Lastly, in this world, we need to somehow give the user the ability to accept them if they haven't already.


Refactoring to be more testable

Inject EsterolesLogic to EsterolesViewModel to be more testable.
Add System.IO.Abstractions to be more testable.

Testing project added


List all members of an organization

For UCSB-CS56-W15 organization, list the github IDs of every member to a file.
It currently only lists 40.
points:75

looks good

F16 OK (80 pts)

F17 OK (50 points)

Awarded 50 points


[ICON REQUEST] GitLab

Describe the icon you'd like to be added
An icon for GitLab; something based around their standard logo.
Sample icon

One from Feather and two from FontAwesome.
Thanks!

@htbrown icon added.


Add sceneryLog to scenery unit tests

This is something that I have felt would be very nice for a while. At one point I developed a halvsey solution just for a11y, but we should revert that and support sceneryLog fully.

@jonathanolson please review.

Looks good to me, thanks!


Update comment in environment.yml

The environment.yml file currently has a comment saying scores is unavailable from any conda repositories, which is no longer the case. Update the comment to say this uses pip in order to install the all variant, as conda only has the minimal variant. This file is for use by contributors who likely want the all variant dependencies in an environment.

This has been by PR #658


fix: host robots.txt

fix: remove robots location from general conf
feat: block all bots from staging sites
feat: block GPTBot from .org sites

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

All our sites return 404s for robots.txt:
https://www.freecodecamp.org/robots.txt
https://www.freecodecamp.dev/robots.txt
https://api.freecodecamp.org/robots.txt
https://api.freecodecamp.dev/robots.txt
This PR fixes that and includes the GPTBot blocking that was intended to be introduced by https://github.com/freeCodeCamp/freeCodeCamp/pull/51201
Finally, we want to block all bots from .dev, so that config now disallows all user agents.

Closing until I have time to properly explore the mystery of SEO.


Fix app crash after dragging waypoints

Details

When we rearrange the waypoints order by dragging it, the app will crash.
Fixed Issues

$ https://github.com/Expensify/App/issues/32964
PROPOSAL: https://github.com/Expensify/App/issues/32964#issuecomment-1853906022
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open a money request page
Switch to Distance tab
Drag the waypoints to reorder it
Verify the app doesn't crash

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/c56262c0-8c78-432d-a488-956c78e9014a

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/bb20b4fd-c581-4486-99b8-7ce647919676

iOS: Native

https://github.com/Expensify/App/assets/50919443/4c93dca5-7ec0-4ead-ac47-13cbc5846580

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/4c3931a1-f719-49ad-ba54-c7d47db9bad4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/7627a3c9-faed-422a-b6c1-d8eda6c507df

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/ca7e38be-b9fa-4644-86eb-aa305bbb2b6c

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅