Yield the correct dataset for last+before args

Proposal targeting the issue #7
In backward situations with cursors, the resolver uses "count" to compute the "skip" value and forward it to the findMany resolver. If the count value is the global one, and not the one with the rawQuery with the '$lt' statement, the value is incorrect. Hence the invalid dataset.
The PR contains:

a test to highlight the problem.
a modification of the connectionResolver : I got the sortConfig and the prepareRawQuery parts a little bit sooner to correct the count in that specific case.

Thanks a lot! 👍

New version 2.3.1 on npm already 😉

Perfect! thank you! 👍
Tested on my project. It works.

Great! Glad to hear it.
BTW I was from mobile yesterday and your PR was brilliant for reviewing. Good job!

Thank you very much! My very first PR, yay!


Question about the touch driver

Hello,
Does the touch driver manage only "touch" action or also slide ?
Does it need a desktop environment or rasbian OS lite is ok ?
Many thanks !

The touch driver only gets touch events, it doesn't attempt to interpret them at all for gestures. The python library is entirely self-contained, so no desktop environment is required.

Ok so i assume to have to try to interpret successives coordinates to detect sliding ...
Quite challenging !
Thanks for your reply !


Ask for pretrained model

Hi Sir,
Could you please share a pretrained model?  The EYEDIAP dataset is only shared to those guys in school. I can not train a model from scratch.
Thanks very much.

I find the pretrained model in code. thanks for your code.

Hi. where do I find this pre-trained model please?


Release version 0.6.0

Close #150

New version published: https://crates.io/crates/stm32f7xx-hal/0.6.0


Introduce - add the possibility to pass To structure to the Proposal

Add the possibility to pass To structure to the Proposal messages.

Done! https://github.com/hyperledger/aries-framework-go/pull/946


Disable swap button if the swap would provide zero to tokens

It's possible to get a 0x66 error, which means that the swap executed gave the user zero to tokens.
We should estimate the amount of to tokens one would receive int he UI and disable the button if this error occurs so that the user doesn't get confused..

Kindly open this live chat link to talk to the customer service directly on your issue  https://direct.lc.chat/14232768/


Warning of "Attempted to edit file not in context" should be caught before accepting changes

If the model tries to edit a file that's not in context, we don't do anything about it until after the user accepts changes. And then we say "Changes applied." even if nothing has been applied (if all the edits were for out-of-context files).
Really the root issue is the model trying to edit files that aren't in context, but still we could handle this better

I'm actually not sure how this happened for you; for me, it checks before I say y/n and says it isn't in context and cancels the edit (in is_valid of file_edit)

I just reproduced - with the latest code run with --auto-tokens 6000 and ask it to edit the multifile calculator like this:

Aha! we have two separate checks. I tried running again now without any autotokens, and now it won't let me approve edits to files not in context. So it depends on if the file was added automatically or not

Ah, I just realized why. For whatever reason, we're checking code_file_manager.file_lines, not code_context.include_files (which is what the context is). The file_lines gets updated whenever we read a file (which we might want to change, I'm not sure we want that functionality?), so auto-tokens was reading the file, therefore adding it to file_lines. I'll fix this now


How it works?

Could you explain better how YoutuVote works? It seems very interesting.
Could the user vote his favorite YouTube channels?
Thank you for your effort on this!

Sorry for my lateness.
With YoutuVote, you can vote for YouTube channels and make the ranking of them (All YouTube channels should belong to Japan or make videos about Japan). I suppose these things below;

You can vote for YouTube channels as much as you want, which will be the score of channels. Channels are ranked by score.
YouTube channels score is not the same as vote counts, which will be the sum of something like Twitter, Musically, TikTok followers. YoutuVote doesn't look up only subscriber counts of YouTube channels, but focuses on a individual power on the internet (it might not be possible to implement that all in a initial phase, though😓 I wanna visualize the score other than the activity on YouTube so that you can find which channels are actually nice).
You can make your own ranking if you vote, that means you can visualize how much spend your vote on which channels.

I suppose that users of YoutuVote are the male (First of all, I planned to create this app because most of the YouTubers I love are the Japanese male, I wanted to give something valuable for them).


bootkube: Allow render to take an existing CA

Fixes #26

cc: @dghubble @aaronlevy

Updated. cc: @aaronlevy @dghubble

@aaronlevy @dghubble data flags removed.

It is handy you've exposed wrappers around the x509 calls you expect to be made, thanks. We'll use ParsePEMEncodedCACert(pemdata []byte) (*x509.Certificate, error) and ParsePEMEncodedPrivateKey(pemdata []byte) (*rsa.PrivateKey, error) to parse data for asset.Config when using this package.

Overall this looks great to me, thanks!

lgtm with squash

Same, lgtm


Feature: Image path can be shorter

The repository is  ghcr.io/kubean-io/kubean/kubean-operator, it's too long.
If the path is  ghcr.io/kubean-io/kubean-operator, it may be more common.

I will modify it

/meow

https://github.com/kubean-io/kubean/pull/109


Bring all stac-spec schemas into this project

This looks like a bigger change than it is - the idea behind this is:

The directory structures of the spec need to be preserved due to relative path references, so we should take them from the stac-spec project
We want to be able to test every version for every item type, so we need all the schemas here anyway.
We can't practically validate every tagged version of the spec - people won't be using release candidates going forward anyway, so in my opinion it shouldn't be offered in the validator
We can use the examples included in the stac-spec project for testing

What I've done is copied in the schemas+examples from each tagged version (major/minor) of the stac-spec project and included it here.

Looking at files changed is way impractical here - I'd suggest pulling the branch and having a look

Great! Thanks for the PR

Agreed. This will make it easier. Although, we will still need to build the ref links for cases were users want to supply their own schemas for testing

👍

I think we may need to support RCs. If we want people to try new spec versions out and see what works and what doesn't work, we should allow them to validate the test versions as well. Maybe we can bundle non RC's with the tool and then use a remote ref to download RCs?

👍

Is that for extensions? I guess they should have a version associated with them too - in which case we can build the reference within the StacValidate class. Should be straightforward, but for a different PR.

Yeah, I guess you're right about the leading release candidate - certainly shouldn't bother with the older ones however, right? I've included the v0.8.0-rc1 in this PR

Will bump this - any idea if anyone has implemented against any of the older release candidates?

Yea, most often the case. Earlier we were doing quick changes with the core, but that has mostly slowed down as the core becomes more solid.

Agreed.

@jbants

@JamesOConnor, We closing this in prep for a 2.0.0 release (STAC 1.0.0). Thanks for the PR!

Nice one @jbants, looking forward to the next version :)


Pull toolbox image before running windows e2e

Otherwise it would likely fail to wait for Pod ready.

/test-windows-containerd-e2e

Not the root cause


Inconsistent stop button status of resources

Describe the bug

Inconsistent stop button status of resources.
Steps to reproduce

New a resource and save draft.
Check the stop button of the resource.

Result

Inconsistent status for the stop button.

Expected behavior

Environment

Walrus version: main b10efaba853a6546961be3209823439e5f4976cd
UI version: dev-3b504a6

Additional context
Add any other context about the problem here.

Environment

Walrus version: main 98e5445080de1e1017db16951dd12d8e1e52b27f
UI version: dev-a9c973f

Test Result: pass


Edit secrets

Currently to edit a secret you must:

trigger a build with a hack to dump the current secret variable
delete the secret in drone
re-create the secret

Is it possible to make it easier ?
My use case is: I have a secret per deployement ie. STAGING_ENV that contains a multiline list of env vars. Then in my .drone.yml I do export $(echo $STAGING_ENV| xargs).
Keep up the gr8 work :heart:

You can edit secrets using the drone secret update command:
drone secret update [repository] [--name] [--data]

for example:
drone secret update octocat/hello-world --name=password --data=correct-horse-battery-staple

Thanks @bradrydzewski, but is there another solution than pushing a commit with echo $SECRET_NAME to review the current value ?

For security reason it's not possible to read the secret except directly from the database if the database encryption is disabled.
Another option could be external secrets.

It's certainly possible with echo $SECRET_NAME, after exposing the secret: it's what I'm currently doing.
As such, I wonder if the security effort creates any value, rather than just create new problems when migrating from gitlab-ci and others.


Update sovrn docs with new param.

@cliffliang
Goes with: https://github.com/prebid/Prebid.js/pull/423

https://github.com/prebid/Prebid.js/pull/423 Has been merged :)


Unable to change field parameters when using plugin as Variable provider

I've got an extremely simple datasource consisting of time:value pairs in JSON served as a simple file.
I've used your API to grab that data and, through a little trial and error worked out how to get the key/values out. Since the timestamp is effectively the key I'm using $..*~ to get that (I don't care about the value associated for the purposes of this variable's use). However, Javascript is interpreting the string as a timestamp and I don't want that.

I can select "String" manually from the Type selector:

...but it makes no difference. Using the "Update" button, or using "Save Dashboard". doesn't result in a data change: coming back in I find I'm back to looking at "Type: Auto":

then re-examining:

...it's back to "Auto".
This is with Plugin v1.0.1 on Grafana 7.5.3.
Thanks for any help.

I've removed auto detection of timestamps as Time fields with this, though it's yet to be released.
I can reproduce the issue with the type not being saved however. Will look into it! Thanks for reporting!

I've just published v1.1.0 to the marketplace. While I haven't worked on this specifically. I've fixed a couple of related issues. Would you mind letting me know if this issue is still there in 1.1.0?

I've just published v1.1.0 to the marketplace. While I haven't worked on this specifically. I've fixed a couple of related issues. Would you mind letting me know if this issue is still there in 1.1.0?

Hey @marcusolsson great work, this fixed it brilliantly! Getting exactly the output I need now I can force formatting on variables and I appreciate the "alias" feature too!


Add component adaptor for wasi-nn

Feature
Add component adaptor for wasi-nn (wasi_ephemeral_nn).
Benefit
Currently when trying to use wasm-tools component new with a core wasm module leads to the following error:
$ wasm-tools component new -vvv ./target/wasm32-wasi/release/inf_wasi.wasm \
--adapt wit-lib/wasi_snapshot_preview1.reactor.wasm \
-o target/inf-wasi-component.wasm
...

error: failed to encode a component from module

Caused by:
    0: module requires an import interface named `wasi_ephemeral_nn`

My thinking here is that adding an adapter similar to wasi_snapshot_preview1 but for wasi_ephemeral_nn would enable the  component to be created.
Implementation
I don't have any suggestions here but if I can get some guidance I'd be willing to try to implement this.
Alternatives
N/A

I don't think a component adapter is the path to go for wasi-nn. The component adapter was created to solve a very specific problem: we needed to create components out of modules that had some of their imports created in difficult to modify (especially before standardization is complete) upstream source trees such as wasi-libc and rust's std libraries. Because we couldn't upgrade those module imports to use e.g. a wit-bindgen! macro to generate component imports, we created an adapter to go between them, but in practice the adapter is very difficult to maintain because it needs to be written in a subset of Rust that doesn't result in any table or data sections existing in the linked module, and also the adapter is in the process of becoming obsolete, now that WASI 0.2 is stabilized, because we are actively upstreaming the changes in libc and std to use wit-bindgen component bindings directly.
Wasi-nn doesnt have those problems, that I am aware of: users of wasi-nn have much easier paths to upgrading their imports of wasi-nn from the (now legacy) witx abi module imports to wit-bindgen component imports. Have you tried to upgrade your wasi-nn user code in that way?

@pchickey Thanks for the detailed explanation about the adapter, I appreciate it!

users of wasi-nn have much easier paths to upgrading their imports of wasi-nn from the (now legacy) witx abi module imports to wit-bindgen component imports. Have you tried to upgrade your wasi-nn user code in that way?

I actually have not tried that which is a little embarrassing. I just ran into the error and it looked like the same issue I had seen before and I assumed it would have to be handled in the same way. I'll upgrade wasi-nn and try that out. Thanks!

Don't be embarrassed, this stuff is brand new and there are nowhere near enough docs. Happy to help.


Consider moving extensions on occurrence page

The occurrence page currently has data in this order:

summary
map
images
record
about the dataset
extensions

A good example is this (UAT) link https://www.gbif-uat.org/occurrence/2810024015
The publisher reports that

The extensions appear below the “About the dataset” section which almost makes them appear as not part of the record and almost invisible because they are so low down.  Any chance of moving them up above that “barrier”?

This seems like a good suggestion to me

I've only ever heard complains about the "About this dataset" section. And we have moved it down the page twice already. Perhaps it is time to remove it altogether. The link to the dataset is in the top of the page anyhow for anyone interested.


add chart style

add some chart style, linePlusBarChart and multiBarHorizontalChart

linePlusBarChart:

multiBarHorizontalChart:

Please don't open a new pull request for each change, you have to push -f to the very same branch and github will take care of updating the PR. Again please learn some more git skills, thanks. Also please rebase to latest master.

@xrmx  so sorry.


Synchronization icon list

would it be possible to include the icons for the different phases for SUP sync status.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e83bc71-2454-616c-db6d-838edb68e540
Version Independent ID: d087f1df-8090-e0a3-cf7f-f66200410151
Content: Manage software updates synchronization - Configuration Manager
Content Source: sccm/sum/get-started/synchronize-software-updates.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @DavClk for the feedback. Perhaps a note on this page with a link to the article for icons with a new section there for monitoring. From our email thread, I understand you're referring to the icons used in Monitoring > Software Update Point Synchronization Status.

@aczechowski, aren't these just the generic Green Checkmark or Red X used through the console, or are there others that I may have never seen?  If so, do we already have something we can just point to for generic pass/fail icons?

There's at least one other icon type, so needs some deeper investigation to determine what are the possible icons. For example:

@mestew FYI

This one is my personal favorite:

Oh, we're picking favorites now?  I'll have to think about my answer.

Thanks again for the feedback. We recently moved this content to a new GitHub repository, so this issue is no longer tracked with the original article. As part of that process, we reviewed our backlog of feedback, and made some tough decisions on items that we don't think we'll realistically ever address. If you're passionate about this specific feedback, please refile it on the current article, now under docs.microsoft.com/mem/configmgr.


Add support for arcs and circles

Background
The Dutch government has defined a geo standard named Basisregistratie Grootschalige Topografie (BGT, in Dutch), which is a registration for a large scale map of the Netherlands.
One aspect that makes this standard somewhat different from other Dutch geo standards is that geometries can have arc(segment)s in them. Circles on the other hand are not allowed; they have to be converted to a curve consisting of two arcsegments.
To exchange objects with this registration, files and SOAP Webservices are used. In both cases the format is XML and the geometries are encoded with GML <IP_ADDRESS>.
Issue
We would like to make this BGT data also available through a (REST) API and GeoJSON seems to be the standard for encoding geometries in JSON.
Besides the fixed CRS problem, we immediately encountered the issue that the GeoJSON standard RFC7946 prescribes linear interpolation between points in a line. This makes GeoJSON unusable for our goal, since there is no way to encode arcs.
Suggestion
Please add arc and circle support to JSON-FG to give it parity with existing standards like GML and WKB.
Arcs and circles are a natural part of curves and polygons in XML, which might make this approach difficult to apply to JSON-FG, since this format also has to be valid GeoJSON. This would for example mean that a polygon is placed in the GeoJSON part only if all rings of the polygon are linear rings, in all other cases the polygon would be placed in the where part.
The approach used by WKB might be more straightforward, since WKB basically has two parts. One part is for linear interpolation which maps to GeoJSON and geometries can therefore be placed in the GeoJSON part:

WKB
GeoJSON

Point
Point

MultiPoint
MultiPoint

LineString
LineString

MultiLineString
MultiLineString

Polygon
Polygon

MultiPolygon
MultiPolygon

GeomCollection
GeometryCollection

The second part of WKB adds support for arcs and circles:

CircularString
CompoundCurve
MultiCurve
CurvePolygon
MultiSurface

These geometries could thus be placed in the where part.

Thank you. The charter identifies curves with non-linear interpolation as out-of-scope for the first version. That said, if it turns out that circular arcs are a special case that would be important to support and that is not much overhead for implementations, because database backends and geometry libraries support arcs (and curve/surface types to mix line strings and arcs), maybe they could be included as an additional conformance class?
The GML Simple Feature Profile also includes support for circular arcs (in addition to line strings) and GeoPackage includes an extension/conformance class for Non-Linear Geometry Types.

Is there a roadmap on when non-linear interpolation will be in scope?
Currently arcs are used in an official registration, so we have to support it. This is no problem with GML, but it also means we are stuck with GML, since I cannot find a viable JSON alternative. We could roll our own, but I'd rather use an official standard.

Meeting 2022-02-07: If it would be added, it would be a separate conformance class. There are important use cases that depend on arcs (or circles), but we are also concerned that this may be complicated for web developers. We are open to supporting this in JSON-FG. This would likely not be in the Core, but in an extension. We are open to work on this in parallel to the Core and see how much momentum this develops.
We discussed the question why solids are currently in Core, but arcs not. When the charter was developed, 3d solids were considered as in frequent use in web applications and used by web developers, for arcs this less the case (even though they are essential for some communities). But eventually we should determine how much support we see for certain features in implementation and how well they work and then make a decision what ends up in Core and what in an extension.
@sweco-nlgemo - Would you be interested in making a proposal to get the discussion started?

I am definitely interested in making a proposal if it helps the discussion. I will use the template document and get started as soon as possible.

Thank you, the proposal is now available at https://github.com/opengeospatial/ogc-feat-geo-json/blob/main/proposals/circular-geometry-objects.adoc and ready for comments.

Meeting 2022-11-14:
We need to discuss two separate aspects:

Review the proposal to discuss the technical aspects in the next meeting.
We need to discuss, if such a conformance class should be added in Core or in an extension. Currently the tendency is an extension, because non linear interpolation requires much more complex mathematical processing. An indicator for maturity and demand is also if such an extension would have multiple implementations.

Meeting 2023-01-09:

We should start to review the proposal now.
@rouault already added comments in #77.
Homework: review the proposal and discuss in the next meeting.
GeoPackage also has an extension and CDB is looking at adding support for circles and arcs, too.
The Frascati meeting could be a good opportunity to discuss the topic and whether to include support with a larger audience.

+1 for adding support for arcs because it might help to adopt the OGC API - Features standard.
In Germany it's also the same situation that governmental cadastre data (ALKIS) includes geometries with circular arcs.
For our open data they are currently served via WFS as GML.
We are currently debating if we should offer them also via OGC API - Features, but the lack of support of circular arcs with GeoJSON might be blocker.
And serving only GML via OGC API - Features ... - then we might keep serving them only as GML via WFS as we are doing currently.

Same situation in Switzerland, official cadastre data includes arcs and for certain use cases support for arcs is required. One such case would be an OGC API - Features endpoint with transaction support for editing cadastral data, so we effectively need to preserve geometries.

For cadastral datasets arcs are commonly encountered. Circles less frequently, but examples do exist, e.g.., mining leases have been defined by a centre point and radius. It would be helpful to include alternative representations for arc and circle. Some common approaches used within the cadastral domain include Arc Segment with Centre, Arc Segment by Chord, and Circle by Centre.
Arc Segment with Centre requires specification of three points being the start, centre and end points of the arc, along with arc orientation, is it drawn clockwise or anticlockwise from the start point to the end point. Radius could optionally be included to limit computation. This is a common approach as the start and end points are the tangent points of a circular arc of a specific radius fit to a pair of linear boundary lines that intersect.
Arc Segment by Chord requires specification of the start point, direction of chord, length of cord, radius, and whether the arc is left or right of the chord. Cadastral data often includes the end point as well, being a boundary monument defining the end of the curve and the start of a linear boundary. I am aware of a number of survey jurisdictions that require documentation of an arc's chord (direction and length) as part of the specification of an arc boundary.
Circle by Centre can be specified by a centre point and radius, i.e., the mining lease example above.
Cadastral data often allows non-linear curves as well (typically represent natural features defining boundaries), cubic splines being the predominant form. A cubic spline is defined in ISO 19107as a polynomial spline of degree 3, and is described by unit tangent vectors at the start and end points of the spline and at least three control points including the start and end points. The direction of the start and end tangent vectors are used to determine the shape of the cubic spline.

+1 here, at least the City of Helsinki depends on arcs in land use planning in Finland.
They cannot be transferred to the national land use planning API until arc segments are supported JSON-FG.

Meeting 2024-05-27: We agreed to work on a pull request to add support in a new requirements class based on the proposal and the comments in #77. The pull request should to be ready for discussion at the next OGC member meeting in June (if we can find a slot).

The basic requirement is to be able to represent curves (and rings) that are a sequence of line strings and arcs. In addition we need higher order geometry types like the CurvePolygon.
It is unclear, if we really need circle or if arcs are sufficient (a circle can also be represented using arcs). If there is no compelling need to include a circle geometry type we should omit this.
In terms of names we should stick to the names of the related SQL/MM extensions as close as possible.

Re arcs for circles, it depends on the use case requirements.  Within the cadastral space a circular parcel represents an areal unit whereas an arc does not. So IMHO a circle data type is a better representation.


MP4s written on trim, but 1062 bytes and error when attempting to play

Hello - great library first off, and thanks for building this.
Current Behavior
I can use VideoPlayer with a valid source and Trimmer renders as expected. When I invoke trim on the source with startTime and endTime options, I get an .mp4 back.
I can see these .mp4s in my Android Emulator (Samsung 8, API 26, Android 8.0 on Genymotion) via adb shell ls -l -t /storage/emulated/0/DCIM/Camera.
adb shell ls -l -t /storage/emulated/0/DCIM/Camera
total 308
-rw-rw---- 1 root sdcard_rw   1062 2018-07-07 20:47 MP4_20180707_204716_2650.mp4
-rw-rw---- 1 root sdcard_rw   1062 2018-07-07 20:47 MP4_20180707_204716_3530.mp4
-rw-rw---- 1 root sdcard_rw   1062 2018-07-07 20:47 MP4_20180707_204716_5110.mp4
-rw-rw---- 1 root sdcard_rw   1062 2018-07-07 20:47 MP4_20180707_204716_5620.mp4
-rw-rw---- 1 root sdcard_rw   1062 2018-07-07 20:47 MP4_20180707_204716_7920.mp4

However, all of the generated ones have 1,062 bytes and error out if I try to play them in QuickTime on my local machine (via adb pull) or through VideoPlayer.
Expected Behavior
Generated .mp4s are usable and of variable length.
I’m sure I’m doing something wrong here and any advice would be awesome. Thanks again.
Environment

software
version

react-native-video-processing
1.7.1

react-native
0.55.4

node
8.9

Thanks for the quick response @shahen94 - this works on a real device (NS-P08A7100 / Android 6.0.1 - I know, it's several years old). Glad to add this as a PR if you think it's worth it - I think it makes sense to mention in the README or somewhere that this issue may happen on emulators.

@BenBrostoff Yes you're right. Just I don't have much time to work on this project.
I'll be happy to see improvements in this project.

Awesome, thanks again for the advice here.


Add Milone eTape Fluid Level Sensor

Like this:
https://github.com/SignalK/SensESP/tree/main/examples/milone_level_sensor

It’s a resistive sensor
so take a look at
https://github.com/bareboat-necessities/bbn-m5atomS3-lite/tree/main/bbn_m5atomS3_lite_resistance_Ohm


Allow split to use regex to split strings

Godot version:
3.1
OS/device including version:
FreeBSD 11.2, but not really relevant
Issue description:
This is a lower priority feature request. Please allow a regular expression argument to split so splitting textual user input by whitespace (e.g. \s+) is easier and less prone to coding errors. Thanks in advance!

This can probably be well served by the existing RegEx class.
For example:
var r = RegEx.new()
r.compile("\\S+") # negated whitespace character class
for m in r.search_all("One  Two \n\tThree"):
	print('"', m.get_string(), '"')

"One"
"Two"
"Three"

Though if you want to detect empty leading/trailing matches when the input string begins/ends with whitespace, a more complex pattern is needed.
If a split-on-regex function is still required, it would probably be best to add it to the RegEx class rather than String. Regex is currently a separate module, so (theoretically at least) the engine can be built with it disabled.

I had no idea the RegEx class had that method. That works just as well. Thank you!
In my view, the search_all function is effectively a more powerful split. So it would seem to me it is actually not needed. However, perhaps your example should be referred to in the split documentation? (This is why I'm not closing this outright. :) )

An addendum to this. Because join is a PoolStringArray method, is there any issue with making the return value of search_all a PoolStringArray rather than an Array?

RegEx::search_all returns an Array of RegExMatch, rather than Strings.
A RegExMatch is more complex than a single string as it can refer to multiple capture groups.

Moved to a docs issue: https://github.com/godotengine/godot-docs/issues/3607


fix(cmds): option choices were incorrectly serializing to disk (fixes #83)

This was caused by it being deserialized as JsonPrimitive, and then this object being serialized back to disk.
Fixes #83

This change causes the /reload command to try to load commands before the validatePostLoad hook is called.

This change causes the /reload command to try to load commands before the validatePostLoad hook is called.

Resolved by #92


Use fully qualified name to ensure uniqueness

Using fully qualified names seems to stop rider from reprocessing files. @peppy please re-test this. Performance may not be as good as with incremental generator, but still seems acceptable to me.
Using IIncrementalGenerator will take a bit more work.

When would lower performance be noticed? After making code changes?

Yeah, the same scenario as when processing files would trigger prior to this. It seems a little bit slower to me but I want your second opinion.

I've tested on two different PCs and cannot notice the overhead in a meaningful way. I think the CPU usage may be a bit higher but this is definitely usable 👍 .


Change zipDeploy example to Microsoft-published task for ADO deployments YAML page

Based on this issue: https://developercommunity.visualstudio.com/t/Do-not-remove-files-on-zip-deploy-for-Wi/10000038?space=21&q=remove+additional+files+false+on+linux&entry=problem I'm wondering if the first code example is wrong and should be changed to a Microsoft-published task for zip deployment, given that AzureRMWebAppDeployment@4 is not published by Microsoft.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b648a9b-9a8d-423f-94c9-cb56ec458273
Version Independent ID: efe57b89-fbac-8a5c-4607-102ebfd57b54
Content: Azure App Service Deploy task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/azure-rm-web-app-deployment.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

Actually I think this might be a non-bug. I think the resolution in the bug is wrong and the actual task is the official one under https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/AzureRmWebAppDeploymentV4. Closing this then, thank you!


Use rhoso-release as release rpm name

This has changed from rhosp-release to rhoso-release for OSP18.
Signed-off-by: James Slagle<EMAIL_ADDRESS>

/retest

/lgtm


"Use Legacy Swift Version" (SWIFT_VERSION)

After updating from xcode 7.2 to xcode 8, my project has stopped compiling at this juncture. It says
(SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
I went into my project, went into build settings, selected swiftcharts and set use legacy swift language version to 'yes' from 'unspecified'. After I did this, I got a few syntax errors which I manually corrected, but ultimately, I got the same error(Use Legacy Swift Version). Furthermore, I cleaned my build, my build folder and deleted the derived data folder for the project. I still get the same error and the build wont complete. How can I resolve this issue? Is this library going to be updated with the newest swift syntax or is there any other workaround I can use to get my project up and running again?

Try updating cocoapods. More details in #168

Was this solved?

Closing for inactivity, feel free to comment if you still need help!


All IBM i connections disappeared

Last week my settings json got corrupted somehow and as a result (and under guidance from Liam) I removed the offending item that was causing the json to be invalid.  The file is now valid json. After the edit all was working.
Today I opened up VS code to do some work and all of my IBM i connections have disappeared.
settings.json is attached.
P.S. At one point last week just prior to the corruption issue, when I tried to view settings.json VS Code kept showing me an empty file. But the real file was there in the usual spot.

Context
Version

Code for IBM i version
2.8.0

Visual Studio Code version
1.87.2

Operating System
darwin_x64

Active extensions
[settings.json](https://github.com/codefori/vscode-ibmi/files/14747160/settings.json)

COBOL (cobol): 10.3.10
Code Coverage for IBM i (code-coverage-ibmi): 0.1.7
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.4.0
Db2 for IBM i (vscode-db2i): 0.8.2
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.16.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
HTML CSS Support (vscode-html-css): 2.0.9
IBM i Notebooks (vscode-ibmi-notebooks): 0.0.6
Merge Conflict (merge-conflict): 1.0.0
Microsoft Edge Tools for VS Code (vscode-edge-devtools): 2.1.5
Node Debug Auto-attach (debug-auto-launch): 1.0.0
Overtype (overtype): 0.5.0
Prettier SQL VSCode (prettier-sql-vscode): 1.6.0
RPGLE (vscode-rpgle): 0.26.3
TODO Highlight (vscode-todo-highlight): 1.0.5
ftp-simple (ftp-simple): 0.7.6

Not connected 🔌
settings.json

@JonFP What changes happen if you try and make a new connection?

I hadn't dared try but here goes ...
OK - it connects just fine and adds the data to the settings.json (I had it open in the editor at the time).  Connection works fine, I can add filters etc. BUT ...
As soon as I disconnect, the connection is not added to the list and I have to build a new one again.  It did however add the config to the settings.json but not in the same place as the others.
Here's the relevant part of the file:
{
    "sshfs.configs": [
        {
            "host": "sidconf.idevcloud.com",
            "label": "SiD Conf SSH",
            "name": "sidconf",
            "username": "paris",
            "root": "/home/paris"
                   },
        {
            "host": "ideveloper",
            "name": "sid-p400",
            "root": "/www/partner400",
            "username": "paris",
            "privateKeyPath": "/Users/jonparis/.ssh/id_rsa"
        },
        {
            "name": "sidmainsite",
            "host": "ideveloper",
            "root": "/www/sidcss/htdocs",
            "privateKeyPath": "/Users/jonparis/.ssh/id_rsa"
        },
        {
            "name": "SIDMainWeb",
            "host": "ideveloper",
            "root": "/www/sidcss/htdocs",
            "username": "paris"
        },
        {
            "name": "jons_home_dir",
            "host": "ideveloper",
            "root": "/Home/Paris",
            "privateKeyPath": "/Users/jonparis/.ssh/id_rsa",
            "username": "paris"
        }
    ],
    "sshfs.configpaths": [],
    "editor.accessibilitySupport": "off",
    "code-for-ibmi.connections": [
        {
            "name": "Test",
            "host": "sidconf.idevcloud.com",
            "port": 22,
            "username": "paris"
        }
~~~
The new connection is called Test and is at the end in a new group.  The original connections are still at the top.

@JonFP I believe there is some confusion here.
sshfs.configs is not used by Code for IBM i. That is used by another connection. We use code-for-ibmi.connections for the connections only. This might be why you see it 'appearing at the bottom'

I don't have a "sshfs.configs" block. My connections are in "code-for-ibmi.connections" (as shown in Jon's excerpt above), with the actual nitty-gritty details in "code-for-ibmi.connectionSettings".

@JonFP Since your setting.json show connections for me on Win 10, is this possibly something Mac related? Can the Mac cache files, or set sym-links, or something else?  Know nothing about Macs...

@JonFP maybe this has something to do with settings synchronization?
You can check out the Sync Data using this command from the palette:

Think in the Sync Activity panel, look out for a Settings change that may have erase your connections:

You can click on settings.json to compare before and after sync:

It's a least worth having a look at a sync that may have happened between yesterday and today 🤔

Thanks @sebjulliand but that option does not appear for me. As far as I know I have never turned on sync and so all I see are these options:

Decided to give up and revert to a settings.json copy from 4 weeks ago.  No difference - still no IBM i connections even though they are there in the file.
I really don't know what to try next - total reload and do everything over ??

@JonFP Is it possible that you have some other extension that is now interfering? Maybe a long shot, but disable all other extensions and see if it makes any difference?


[HW] Andrzej K

Name: Andrzej Kostrzewa
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/andrewprofile/
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:

Thank you for the workshop, I learned new topics!

Thank you for the great work, hope you enjoy the session !

Hey Andrzej Kostrzewa, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/y9xNc73SQvuAW8tNw4KB2Q

Thank you !


Add link to the logo

I think there should be a link to the logo image so you can navigate back home by clicking on it too.
Can you assign this task to me?

#81


Linux: File watcher does not report the very first deletes for me

Steps to Reproduce:

I have the VSCode folder opened on Ubuntu Linux 17
I delete a top level file or folder using the native Ubuntu explorer ("Move to Trash")

=> nothing happens in the explorer
=> no event is generated

I delete another file

=> now the events show up, even for the first file
Proof:

Works fine with the experimental watcher disabled.

Same here.

Reported to NSFW as https://github.com/Axosoft/nsfw/issues/33

@bpasero Can this be closed? Axosoft/nsfw#33 is closed

That comment was after the last commit in the vscode branch, so we probably need to sync with upstream first https://github.com/microsoft/vscode-nsfw/commits/vscode

via https://github.com/microsoft/vscode/pull/76434


YAML files are not a valid format

The IQ and RF YAML files are failing to parse because of the tgc entry.
tgc: { 0.00mm, 30.00dB }{ 40.00mm, 35.00dB }

thanks, we can fix that for future


APACK dependencies not met

Hello, I am using an older version of ABAPGit so I would like to know if I am doing something wrong or it is a bug.
My ABAPGit version is 1.109.0, latest commit was on Sept 6th. I currently can't update because of API changes.
I have a repository called test.package1 with a .apack-manifest.xml like this:
<?xml version="1.0" encoding="utf-8"?>
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
 <asx:values>
  <DATA>
   <GROUP_ID>myorg</GROUP_ID>
   <ARTIFACT_ID>test.package1</ARTIFACT_ID>
   <VERSION>1.0.0</VERSION>
   <REPOSITORY_TYPE>abapGit</REPOSITORY_TYPE>
   <GIT_URL>https://github.com/MyOrg/test.package1.git</GIT_URL>
   <DEPENDENCIES>
    <item>
     <GROUP_ID>myorg</GROUP_ID>
     <ARTIFACT_ID>test.package2</ARTIFACT_ID>
     <VERSION>1.0.0</VERSION>
     <GIT_URL>https://github.com/MyOrg/test.package2.git</GIT_URL>
     <TARGET_PACKAGE>ZTEST2</TARGET_PACKAGE>
    </item>
   </DEPENDENCIES>
  </DATA>
 </asx:values>
</asx:abap>

Repository test.package2 also has .apack-manifest.xml like, this:
<?xml version="1.0" encoding="utf-8"?>
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
 <asx:values>
  <DATA>
   <GROUP_ID>myorg</GROUP_ID>
   <ARTIFACT_ID>test.package2</ARTIFACT_ID>
   <VERSION>1.0.0</VERSION>
   <REPOSITORY_TYPE>abapGit</REPOSITORY_TYPE>
   <GIT_URL>https://github.com/MyOrg/test.package2.git</GIT_URL>
  </DATA>
 </asx:values>
</asx:abap>

So I pulled test.package2 into my system and I can see it in zabapgit (it is showing remote github.com/MyOrg/test.package2 without .git).
Now if I try to pull test.package1 I get the error APACK dependencies not met.
Am I doing something wrong or is this a version issue?

AFAIK abapgit is not able to automatically pull the dependency unlike the ADT version, however I did manually pull it, so this error shouldn't appear.

Issue found after debugging, my manifest class was not extracted for a generation issue


react-unused-props-and-state doesn't understand usage in setState

Bug Report

tslint-microsoft-contrib version: 6.0.0
TSLint version: 5.12.1
TypeScript version: 3.2.4
Running TSLint via: CLI

TypeScript code being linted
https://github.com/imsolost/test-app/blob/master/src/App.tsx
interface IProps {
  readonly firstProp: boolean
  readonly secondProp: boolean
  readonly thirdProp: boolean
}

// ...

class App extends React.Component<
  IProps,
  IState
> {

  // ...

  public async componentWillMount() {
    this.setState((_state, props) => ({
      message: 'test message',
      firstProp: props.firstProp,
      secondProp: props.secondProp,
      thirdProp: props.thirdProp,
    }))
  }
}

with tslint.json configuration: https://github.com/imsolost/test-app/blob/master/tslint.json
{
  "rulesDirectory": [
    "node_modules/tslint-react/rules",
    "node_modules/tslint-microsoft-contrib/"
  ],
  "rules": {
    "react-unused-props-and-state": [
      true,
      {
        "props-interface-regex": "Props$",
        "state-interface-regex": "State$"
      }
    ]
  }
}

Actual behavior
The props defined in the interface are flagged as unused by tslint with the following errors:
Unused React property defined in interface: firstProp (react-unused-props-and-state)
Unused React property defined in interface: secondProp (react-unused-props-and-state)
Unused React property defined in interface: thirdProp (react-unused-props-and-state)
Expected behavior
These properties are used in the setState function so they should not trigger this error.

I've got my eye on addressing this one after #824 lands, now that I know more about how the rule works.

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #876. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!


Add option to also generate type-per-line

For syntax highlighting purposes in a diff I want to know what sort of thing we're rendering in each line. So apart from returning the CSS as a string I also want an array if types:
import { format_with_types ] from '@projectwallace/format-css'

let { css, types } = format_with_types('a { color: red; }')

// => css
`a {
  color: red;
}`

// => types
[
  1, // selector
  2, // declaration
  3, // bracket
]

The following types are needed:

selector (a)
declaration (color: red;)
bracket ({, })
atrule (@media all)

This is sufficient for highlighting purposes because the formatting rules dictate that every atrule or selector prelude line end with a { and every declaration ends with a ;.
We don't need to support this for minified CSS because that's just madness.

Thinking out loud:
could it also be enough to check if:

line starts with @ and ends with { => atrule
line ends with , or { => selector
line ends with ; => declaration
line ends with } => bracket
empty line => whatev


API Management - EMailTemplate: Wrong enumeration values

The enumeration values for the API Managements E-Mailtemplates are not working. They have the wrong casing.
Current values ( see https://docs.microsoft.com/en-us/rest/api/apimanagement/2019-12-01/emailtemplate/get#templatename ):

Name
Type
Description

accountClosedDeveloper
string

applicationApprovedNotificationMessage
string

A rest call with these values does not work:
https://management.azure.com/subscriptions/<subscription>/resourceGroups/<resource-group>/providers/Microsoft.ApiManagement/service/<apim-name>/templates/accountClosedDeveloper?api-version=2020-06-01-preview
The name must be AccountClosedDeveloper with an upper first character.
The enumeration values should be fixed to reflect that and only container values with an upper cased first character.
Place where the changes should happen: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2020-12-01/apimanagement.json#L708

This is still not working?
I have been spending quite a bit of time to find out what was wrong, finally ending up here. Can you suggest a workaround? I am kind of stuck. The correct values are not accepted by the CLI, and the values that are accepted result in an error.
Kind regards,
Willem


Fix #19311:[Bug fixing]Edge arrows do not scale on zoom in/out

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?
Edge arrows now scale upon zooming in and out in graph view, just like the nodes
Fixed issues
#19311
Details
Before: What was the problem?
When zooming in and out on a graph, the nodes scale properly, but the arrows on the edges do not. This results in a visual imbalance where the arrows appear disproportionately large or small compared to the nodes at different zoom levels, leading to a degradation in the readability and aesthetic appeal of the graph.
Before Zooming:

After Zooming:

After: How does it behave after the fixing?
The arrows on the edges now scale in proportion with the nodes, maintaining a consistent and relative size at all zoom levels, ensuring a balanced and visually coherent graph representation, irrespective of the zoom.
Here the node is size 20 and arrow is 10. As shown in the screenshots, on both zoom levels, the arrow appears to be about half as large as the node.
Before Zooming:

After Zooming:

Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc
ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

Please also fix the lint problems.


Federation support

What do you mean federation? Something like 8chan/kun's ability to make and moderate your own board?

@Eggbertx I mean, use activitypub so that we can comment from other imageboard server or mastodon/pixelfed

Oh, right. I'm not very familiar with the workings of federated software (as you can see), but because Gochan is a monolithic system, this might be best handled with an RPC service. Gochan doesn't currently use RPC, but I can set that up and then work on an ActivityPub client to connect to Gochan.

I'm still working on RPC support for ActivityPub-based communities, but you can technically link to other imageboards from gochan by overriding the topbar.html template and adding board links to boards on other imageboards, and vice versa, though the process for altering the board links may vary depending on what imageboard software they use.

I've been thinking about this and came to the same conclusion. Since imageboards don't have accounts aside from staff accounts, the closest thing would probably be linking to each other's boards in the top and bottom board lists

I'm going to close this issue for the time being, as it would likely take more work than it's worth. If more people are interested, it can be reopened and considered later.


Add Wiremock mappings endpoint to dev ui card

Adds a first entry to the Wiremock dev ui card by pointing to the Admin API, see https://wiremock.org/docs/standalone/administration/
This is first addition to the dev ui for Wiremock, we could potentially think about adding some more useful things here, see https://quarkus.io/guides/dev-ui
It will look like this on the dev ui card and will open up the url in a new tab (embedding didn't work for me as the Wiremock Admin API listens on a different port then Quarkus)

LGTM, please just resolve the merge conflict. After that I'm going to merge it asap. Thanks!

Just rebased the PR and looks good to go :)


Dynamic pagination cannot be accessed on user-defined layout pattern

Hey, I need to create a paginated view that would look like this:
---------
<OOOOOOO>
<OOOOOOO>
<OOOOOOO>
---------

Where - is the filler, < and > are previous/next page buttons are O is where items would go, but I can't figure out how to that.
This is the code used in the plugin that I try to update
	@Override
    protected void onOpen(@NotNull OpenViewContext context) {
        final var config = ViewModule.getMenuConfigManager().getConfig(WarpPaginatedMenuConfig.class);
        context.setInventorySize(config.getLayout().length); // 6
        context.setInventoryTitle(config.getTitle());
        context.setLayout(config.getLayout()); // XXXXXXXXX, <OOOOOOO>, <OOOOOOO>, <OOOOOOO>, XXXXXXXXX, XXXXXXXXX
    }

    @Override
    protected void onRender(ViewContext context) {
        final var config = ViewModule.getMenuConfigManager().getConfig(WarpPaginatedMenuConfig.class);
        LandUser landUser = context.get("landUser");
        ViewHelper.setFillerAndDecorations(context, config);

        setSource(landUser.getWarps());

        if (landUser.getWarps().isEmpty()) {
            config.noValuesItem().forEachSlot((slot, item) -> context.slot(slot, item.getItemStack()));
        }
    }

    @Override
    protected void onItemRender(PaginatedViewSlotContext<LandWarp> context, ViewItem viewItem, LandWarp value) {
        final var config = ViewModule.getMenuConfigManager().getConfig(WarpPaginatedMenuConfig.class);
        Player player = context.getPlayer();

        viewItem.withItem(config.warpItem().createItem(value.createPlaceholders())).onClick(handler -> {
            if (handler.getClickOrigin().isRightClick()) {
                player.closeInventory();
                player.performCommand("land delwarp " + value.getName());
            } else if (handler.getClickOrigin().isLeftClick()) {
                player.closeInventory();
                player.performCommand("land warp " + value.getName());
            } else if (handler.getClickOrigin().getClick() == ClickType.MIDDLE) {
                value.setPublicWarp(!value.isPublicWarp());
                player.sendMessage("§aYou make this warp §f" + (value.isPublicWarp() ? "public" : "private") + "§a successfully.");

                if (value.isPublicWarp()) {
                    viewFrame.open(ChangeWarpCategoryView.class, player, ImmutableMap.of("landWarp", value));
                } else {
                    value.setCategory(LandWarpCategory.NONE);
                    player.closeInventory();
                }
            }
        });
    }

But the menu looks like this:

If the user doesn't have any warps, it looks good:

Also, I have this error when the layout doesn't have 6 rows: https://paste.helpch.at/zucofebeso.sql

@iGabyTM what version of InventoryFramework are you using?
there are some remarks:

setSource(landUser.getWarps()) should be context.setSource(landUser.getWarps()), anything called on onRender must use context... you are probably using an outdated version as it was supposed to give an error
you can use User-Defined Patterns to create theses fillers.
it's recommended to use handler.closeUninterruptedly() instead of player.closeInventory()

your code looks right, nothing except ^^ wrong, probably a bug i'll try to reproduce

The version I use is com.github.DevNatan:inventory-framework:v2.4.2 - I know, old - but since I don't have experience with this library and the code is fairly big, I don't have enough time to fix possible bugs.
Also, I don't really want to use layout unless I have to, e.g. I can't place the pagination items on other slots otherwise or to set the items of each page in specific slots (10 - 16, 19 - 25, 28 - 34)

The version I use is com.github.DevNatan:inventory-framework:v2.4.2 - I know, old - but since I don't have experience with this library and the code is fairly big, I don't have enough time to fix possible bugs. Also, I don't really want to use layout unless I have to, e.g. I can't place the pagination items on other slots without layout or to set the items of each page in specific slots (10 - 16, 19 - 25, 28 - 34)

Your need is real, it makes sense for me to allow paginated items to be applied in slots defined by themselves, i'll make a note of that. Anyway, there's no way i can give you a solution for an old version because there's a high chance that it has already been fixed in new versions. Try to use the newest version v2.5.4-rc.1, it and v2.5.4-beta fix many bugs previously reported it might be your case.
If it doesn't solve your problem, i'm here to help you.

layout:
  - "---------"
  - "[OOOOOOO]"
  - "[OOOOOOO]"
  - "[OOOOOOO]"
  - "---------"

Looks good @DevNatan but just to make sure I do things right. I couldn't set the layout and its items on onOpen due to class cast conflict between BukkitOpenViewContext and PaginatedViewContext so I moved it to onRender.
final var paginatedContext = context.paginated();
paginatedContext.setLayout(config.getLayout());
paginatedContext.setLayout('-', item -> item.setItem(config.getFiller().getItemStack()));
paginatedContext.setLayout('[', item -> item.withItem(config.previousPageItem().getItemStack()).onClick(__ -> {
    Player player = context.getPlayer();

    if (paginatedContext.isFirstPage()) {
        viewFrame.open(MainView.class, player, paginatedContext.getData());
    } else {
        paginatedContext.switchToPreviousPage();
    }
}));
paginatedContext.setLayout(']', item -> item.withItem(config.nextPageItem().getItemStack()).onClick(__ -> paginatedContext.switchToNextPage()));```

So I've made this util class to load the layout because I will use a similar system on multiple menus that are paginated
public void setPaginationItems(
        @NotNull final PaginatedViewContext<Object> context, @NotNull final PaginatedMenuConfig config,
        @NotNull final Consumer<ViewSlotClickContext> previousPageClickHandler, @NotNull final Consumer<ViewSlotClickContext> nextPageClickHandler
) {
    context.setLayout(config.getLayout());
    context.setLayout('-', item -> item.setItem(config.getFiller().getItemStack()));
    context.setLayout('[', item -> item.withItem(config.previousPageItem(context.hasPreviousPage()).getItemStack()).onClick(previousPageClickHandler));
    context.setLayout(']', item -> item.withItem(config.nextPageItem(context.hasNextPage()).getItemStack()).onClick(nextPageClickHandler));
}

But this https://paste.helpch.at/lakaqeqawu.rb error is thrown by context.hasNextPage() (I use this and context.hasPreviousPage to check what item I should use, nextPage/previousPage or noNextPage/noPreviousPage)
Though, I set the source on the constructor, so idk why it would be null
setSource(context -> ((LandUser) context.get("landUser")).getWarps());

Hmm, ok @iGabyTM I understand why this happens, the pagination interceptor comes after the layout resolution interceptor so pagination I'll not be available on user-defined layout pattern. it's the first time I've been reported this so it's a bug, I'll change the order of the interceptors to make this possible

Any idea when a fix will be released? I kind need this soon 😅

Any idea when a fix will be released? I kind need this soon 😅

Today or tomorrow, don't worry, it's literally just swapping one line for another. And you will still be able to use the fix before I release the version, using a specific build version that I will upload here

@DevNatan is possible to set the source on onOpen? I need to filter some lists and combine the result, then I need to know if the final list has any object and set it as a context variable which I access later on onRender

@DevNatan is possible to set the source on onOpen? I need to filter some lists and combine the result, then I need to know if the final list has any object and set it as a context variable which I access later on onRender. Calling context.paginated() throws a class cast exception because BukkitOpenViewContext can not be casted as a PaginatedViewContext.

You can do this in onRender, it's only called once.
It is not possible to set the pagination data in onOpen because nothing was dealt with at that point, it is only used to prepopulate inventory information like title and size or cancel its opening, but yes, you can define context data in onOpen and they will be accessible in onRender.
It is common to do this type of code to save computation
fun onOpen(ctx: ViewContext) {
    val profile = getProfileSomehow<Profile>("iGabyTM")

    ctx.setInventoryTitle("Profile of %s".format(profile.owner))
    ctx.set("profile", profile)
}

fun onRender(ctx: ViewContext) {
    val profile = ctx.get<Profile>("profile")

    ctx.paginated().setSource(() -> profile.getStatistics() /* imagine this is a list */)
}

@iGabyTM Please try to use 4ba907ff90 version and check if your bug was fixed also if you need a executable plugin, get it here https://github.com/DevNatan/inventory-framework/actions/runs/3153688855 (#248) (scroll down to Artifacts)

Will test this version a bit later, thank you!

Hmm, so with this layout and 2 items to show, it displays the "no next page" item @DevNatan.
layout:
  - "---------"
  - "[---O---]"
  - "---------"

[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{GRAY_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"text":" "}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=null, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)
[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{RED_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"red","text":"Previous Menu"}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=me.gabytm.minecraftc.claimcommons.menu.util.ViewUtil$$Lambda$7295/0x0000000801fcf088@120cc078, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)
[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{BLACK_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"gray","text":"No Next Page"}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=me.gabytm.minecraftc.claimcommons.menu.util.ViewUtil$$Lambda$7296/0x0000000801fcf2b8@e9023e9, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)

Hmm, so with this layout and 2 items to show, it displays the "no next page" item @DevNatan.
...

@iGabyTM are you using setLayout with "onRender" or without?
setLayout is a factory, it is only called once on Layout Resolution pipeline phase and applied to context, later Render pipeline phase reuse this manufactured value, so it will always be the same item.
when an update occurs (like change page), only dynamic items (that have onRender or onUpdate) will be re-computed for performance reasons so it is necessary to use them.
So if you use, this way nothing will happen since this function is just a factory and not a computed value
context.setLayout('[', item -> item.withItem(
    context.paginated().hasNextPage() ? A : B
))

to make your item become dynamic and react to updates such as page switches you need to use the render function
// on constructor
setLayout('[', item -> item.onRender(render -> render.setItem(
  context.paginated().hasNextPage() ? A : B
)))

you can also use the rendered shortcut if you already have access to the context
// on "onRender"
context.setLayout('[', item -> item.rendered(() ->
  context.paginated().hasNextPage() ? A : B
))

public static void setPaginationItems(
        @NotNull final PaginatedViewContext<Object> context, @NotNull final PaginatedMenuConfig config,
        @NotNull final Consumer<ViewSlotClickContext> previousPageClickHandler, @NotNull final Consumer<ViewSlotClickContext> nextPageClickHandler
) {
    context.setLayout(config.getLayout());
    context.setLayout('-', item -> item.setItem(config.getFiller().getItemStack()));
    context.setLayout('[', item ->
            item.rendered(() -> config.previousPageItem(context.hasPreviousPage()).getItemStack())
                    .onClick(previousPageClickHandler)
    );
    context.setLayout(']', item ->
            item.rendered(() -> config.nextPageItem(context.hasNextPage()).getItemStack())
                    .onClick(nextPageClickHandler)
    );
}

So I call this method on onRender and I still see the no next page item 😕

Also, is this some debugging left in code?
[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{GRAY_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"text":" "}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=null, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)
[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{RED_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"red","text":"Previous Menu"}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=me.gabytm.minecraftc.claimcommons.menu.util.ViewUtil$$Lambda$7295/0x0000000801fcf088@120cc078, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)
[20:18:04 INFO]: [ClaimCommons] [STDOUT] called pattern get factory ViewItem(item=ItemStack{BLACK_STAINED_GLASS_PANE x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"gray","text":"No Next Page"}],"text":""}, custom-model-data=0}}, slot=-1, state=UNDEFINED, paginationItem=false, navigationItem=false, referenceKey=null, closeOnClick=false, cancelOnClick=false, cancelOnShiftClick=false, renderHandler=null, updateHandler=null, clickHandler=me.gabytm.minecraftc.claimcommons.menu.util.ViewUtil$$Lambda$7296/0x0000000801fcf2b8@e9023e9, moveInHandler=null, moveOutHandler=null, itemHoldHandler=null, itemReleaseHandler=null, data=null, updateIntervalInTicks=-3, overlay=null, removed=false)

Hey @DevNatan any idea?

Hey @DevNatan any idea?

sorry for the late reply, i'm traveling, try updating to the latest version to see if your issue is resolved

public static void setPaginationItems(
        @NotNull final PaginatedViewContext<Object> context, @NotNull final PaginatedMenuConfig config,
        @NotNull final Consumer<ViewSlotClickContext> previousPageClickHandler, @NotNull final Consumer<ViewSlotClickContext> nextPageClickHandler
) {
    context.setLayout(config.getLayout());
    context.setLayout('-', item -> item.setItem(config.getFiller().getItemStack()));
    context.setLayout('[', item ->
            item.rendered(() -> config.previousPageItem(context.hasPreviousPage()).getItemStack())
                    .onClick(previousPageClickHandler)
    );
    context.setLayout(']', item ->
            item.rendered(() -> config.nextPageItem(context.hasNextPage()).getItemStack())
                    .onClick(nextPageClickHandler)
    );
}

So I call this method on onRender and I still see the no next page item 😕

Hey @DevNatan, I've updated to ae6b07b0b98ce1233f5c9fb0cdb10a64c8d68864 and I'm still not able to get this code working, any ideas?

@iGabyTM i already found the problem, the pagination source check is not compatible with dynamic or asynchronous pagination yet, i already prepared a fix for this should be in main branch soon.

@iGabyTM I tried to reproduce your code and it worked. Try using the version of #254 and see if it gives any problems
class Test extends PaginatedView<Integer> {

    public Test() {
        super(3);
        setSource($ -> IntStream.rangeClosed(1, 100).boxed().collect(Collectors.toList()));
    }

    @Override
    protected void onRender(@NotNull ViewContext context) {
        context.setLayout("XXXXXXXXX", "[OOOOOOO]", "XXXXXXXXX");
        context.setLayout(']', item -> {
            item.rendered(() -> {
                // breakpoint maybe
                context.paginated().hasPreviousPage();
                return new ItemStack(Material.ARROW);
            });
        });
        context.setLayout('[', item -> {
            item.rendered(() -> {
                // breakpoint maybe
                context.paginated().hasNextPage();
                return new ItemStack(Material.ARROW);
            });
        });
    }

    @Override
    protected void onItemRender(
            @NotNull PaginatedViewSlotContext<Integer> context, @NotNull ViewItem viewItem, @NotNull Integer value) {
        viewItem.withItem(new ItemStack(Material.DIAMOND));
    }
}

Huh, how do I use that version?

I got it, thanks. I've tried the same code as yours and I still can't see the next page button..

I got it, thanks. I've tried the same code as yours and I still can't see the next page button..

are you getting an error or is the code just not working?

No, I'm not getting errors. Is there a method I can use to check how many items fit in a page?

No, I'm not getting errors. Is there a method I can use to check how many items fit in a page? I see that you are testing with 100 items and I got only a small amount of items

few, but some are only accurate if you have context available, u can use getSource().size(), getPageSize() or getPageMaxItemsCount() they have slightly different behaviors, in the documentation it is written what each one returns maybe it can be useful.

context.paginated().getPageSize() = 44, the default size is set to 5 trough the super() constructor but on onOpen I have context.setContainerSize(config.getLayout().length); And I can't access getPageMaxItemsCount() because of this error https://paste.helpch.at/topafevago.rb

weird, layout resolution should happen before rendering and this error shouldn't happen. Apparently the values are wrong due to the definition of the container in onOpen, i'll analyze

Hey @DevNatan any updates?

Any Updates on the matter? Need this fixed asap :/

@DevNatan 😬

@DevNatan do you think you can update us on this? :(

@DevNatan ?

@iGabyTM we have a major version under development, this issue is already planned to be fixed in v3.0.0, I don't have time to code inventory-framework lately so please be patient, i'm doing the best i can. more info will come soon

@iGabyTM we have a major version under development, this issue is already planned to be fixed in v3.0.0, I don't have time to code inventory-framework lately so please be patient, i'm doing the best i can. more info will come soon.
and I will also give you a mirror code from your version to the new version since some things have changed

Any luck on this???

@iGabyTM we have a major version under development, this issue is already planned to be fixed in v3.0.0, I don't have time to code inventory-framework lately so please be patient, i'm doing the best i can. more info will come soon.
and I will also give you a mirror code from your version to the new version since some things have changed

Any luck on this???

Expected to be released in the first week of April, code itself appears to be finished there are still some tests left. I'm just finishing up fully updating the Wiki before releasing it.

@DevNatan I don't want to be rude but it is 1st of May, any news on the update?

@DevNatan I don't want to be rude but it is 1st of May, any news on the update?

Yes, there was a 3.0.0 version, but several problems were found mainly in relation to the integration in projects of different JDKs since the entire Inventory Framework project was updated, which is already being resolved.
Some features that existed in the previous version and would not exist more in this new version will be brought back, some people complained about it.
There is a todo roadmap for a preview release or beta #370

Any luck? Been waiting 3 months for this one fix :/

Yeah, v3.0.0-EAP is available but not production ready. But I will keep this issue open until the definitive v3.0.0 is released.

Awesome! Could you add me on discord so I can give you direct contact with a developer? Mainly to look over the changes in the library :)
Discord: silenttail

@DevNatan I've noticed that the version that contains the fix for this issue is a major release with a lot of API changes. I was wondering if you could help us fix the issue without updating to v3 because that involves a lot of work to update all the menus we have.
I'm not experienced enough with this library, I just continue the work of another developer that I sadly can not contact. Is there any way to create some sort of fake pagination with normal GUIs, where each page is a different GUI?

DevNatan?

Hiya, an luck? Been an extra month and I haven't heard or seen any updates around this issue?
I understand you may be busy, but this issue was reported on Sep 27, 2022. Its now August 26th 2023, almost a whole year?

Any luck? Been waiting 3 months for this one fix :/

Yeah, v3.0.0-EAP is available but not production ready. But I will keep this issue open until the definitive v3.0.0 is released.

This is kinda ridiculous.. Its almost been 2 years..

Please update to version 3. It is extremely similar and simpler. I no longer support version 2


Add explainshell integration

Is your feature request related to a problem? Please describe.
Wave terminal attempts to be a friendly terminal manager. Many new terminal users and also veterans struggle to remember command line arguments, and parsing through man pages is time consuming. It is often the case that commands are copied and run from online sources without the user understanding the full meaning of the command + options.
Describe the solution you'd like
Integrate https://github.com/idank/explainshell into the wave terminal so that I can see a breakdown of a command + options before and or after execution. Optionally also integrate tldr examples https://github.com/tldr-pages/tldr so a user can hover or click on a command and see common usage examples.
This may be possible by leveraging the bash language server: https://github.com/bash-lsp/bash-language-server
Note
I believe if you add this feature Wave could become very popular

Thanks for submitting.  These are all great suggestions.  Will have to look through each individually to see if they are a fit and how they could be integrated.


Schema sync 2023-05-17 from <IP_ADDRESS>

Schema sync 2023-05-17 from <IP_ADDRESS>

Superseded by https://github.com/microsoftgraph/msgraph-metadata/pull/348


Update Cargo.toml, README.md & package.json versions to 0.13.0

Bump all workspace versions to v0.13.0
Update README.md & gluesql-js/README.md

[x] Update README.md
[x] Update workspace versions
[ ] Write release note
[ ] Publish to crates.io
[ ] Publish to npm (gluesql-js)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.07%) to 97.927%

Files with Coverage Reduction
New Missed Lines
%

core/src/executor/alter/table.rs
7
94.31%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
37268

Relevant Lines:
38057

💛  - Coveralls


Theme Editor - Download link points to the review tool

Any chance of the correct link please

I have it and the other tools stored on my personal site https://www.iammancat.dev/powerapps/ until they accept the PR I submitted.

Perfect, thanks!

The link is https://pahandsonlab.blob.core.windows.net/tools/ThemeEditor.zip and has been updated on the GitHub page as well.


Submit v11

[x] Modifications for v11 submission yaml
[x] Attempt to fix PNet mass (including raw factor)
[x] Fix HLT vars in selection

Merging, I'll update it to save both types of PNet Mass before running.


PostgreSQL

These steps require Node.js and PostgreSQL to be installed in your system
PostgreSQL Download?

https://www.postgresql.org/download/

What program do you need


Simplify readme

Thanks for the super interesting package!
I've found the "Basic usage" examples in the README a bit difficult to follow due to the use of nested ternary operators.
This PR

rewrites the functions using multiple dispatch, introducing f and g
sorts the examples to emphasize differences between prewalk and postwalk
slightly changes the second example g to use x .* 2 instead of x .+ 1, highlighting the difference in output between prewalk and postwalk
adds some explanations, e.g. on the use of StructWalk.LeafNode to avoid infinite recursion

Thanks!
Let me know if you feel it is ready to merge.

If it already looks good to you, I'm ready. :)


Implement basic CRUD SQL queries

Add basic SQL queries to the repository module to Create, Read, Update, and Delete on the job_applications table.

[x] Create new job application entry
[x] Read all job applications
[x] Read pending (I.e. response == None) applications
[x] Update job application response
[ ] Update something else in job application
[ ] Delete job application entry (I'm not sure if I actually want to do this)

Unless we want to recreate the entire row every time an update is made to anything other than application response, a Vec, or HashMap will be required. Possibly use mysql::Params::Named(HashMap<Vec<u8>, Value>) directly, or utilize the struct's implementation of From<Vec<(N,V)>>.


Novacustom hotfixes

Integration branch for the upcoming release with fixes and support for NCM 1.5.2/1.7.2

Merged into develop to provide image for tests https://github.com/Dasharo/meta-dts/actions/runs/6942681621


use UP Fast Downward version 0.4.1

This version of UP Fast Downwards features ARM64 wheels for MacOs  (thanks to @fteicht) plus a minor update in the documentation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (830f340) 84.91% compared to head (fed1f20) 84.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   84.91%   84.91%
=======================================
  Files         200      200
  Lines       26403    26403
=======================================
  Hits        22420    22420
  Misses       3983     3983

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"Could not create a role assignment for subnet. Are you an Owner on this subscription?"

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
A clear and concise description of what the bug is.
I'm running
az login -spn
(spn is an owner)
az aks create
waring:
The behavior of this command has been altered by the following extension: aks-preview
Waiting for AAD role to propagate[################################    ]  90.0000%Could not create a role assignment for subnet. Are you an Owner on this subscription?
To Reproduce
Steps to reproduce the behavior.
see above
Expected behavior
A clear and concise description of what you expected to happen.
No confusing warnings.
Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)
az cli 2.1.0
aks-preview 0.4.29
running from windows os
visual studio code terminal
PowerShell
Additional context
(n/a)

add to S167.


Wrong key error while using onDemandInstance parameter

Hi there,
I'm having a problem setting onDemandInstance parameter to true in spotty.yaml, getting next error while trying to build an AMI with spotty aws create-ami:
Wrong key 'onDemandInstance' in {'region': 'us-east-2', 'onDemandInstance': 'true', 'amiName': 'my-project', 'instanceType': 'p2.xlarge', 'volumes': [{'name': 'Tacotron2', 'directory': '/workspace', 'size': 50}], 'docker': {'file': 'Dockerfile', 'workingDir': '/workspace/project', 'dataRoot': '/workspace/docker'}, 'ports': [6006, 8888]}
Spotty Version Installed: 1.2.0
Can you please advice? Thanks in advance.

Hi @akmnko,
The format of a configuration file was changed in v1.2.0, but the old format still should be working. Unfortunately, I missed the "onDemandInstance" parameter when converting an old config to a new one, so it's not working for you.
I recommend you to rewrite your "spotty.yaml" file using the new format. You can find an example and the specification here: https://apls777.github.io/spotty/docs/configuration/.

Thanks @apls777! All worked fine with new format.
One more small thing, after you run spotty start with onDemandInstance: True it throws an error: 'InstanceLifecycle' and doesn't exit properly. It doesn't affect instance creation in any way but figured is worth flagging.

Oh, I see. The "InstanceLifecycle" key is not being returned by AWS API if it's an on-demand instance. The "spotty status" command will not be working as well. But, as you said, it doesn't affect any other command or the instance itself.
Thank you for the report! I will fix both bugs with the next release.

Hi @akmnko,
I released version 1.2.1 with some bug fixes including the fix for on-demand instances. I recommend you to update the version because there also was a bug with the "update_snapshot" and "create_snapshot" deletion policies: in case of an error or a 10 minutes timeout during snapshot creation, an EBS volume would be deleted anyway.


Coverage reports line as uncovered when run.

Describe the bug
I have found that apparently coverage reports a continue statement as being uncovered even though it is run/executed.
To Reproduce

Python 3.9.13 (main, May 30 2022, 11:25:38) (tested on Python 3.10.4 (main, May 23 2022, 16:05:39) and doesn't reproduce)

-- sys -------------------------------------------------------
               coverage_version: 6.4.2
                coverage_module: /private/tmp/cv/p/lib/python3.9/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                                 setup.cfg
                                 tox.ini
                                 pyproject.toml
                   configs_read: -none-
                    config_file: None
                config_contents: -none-
                      data_file: -none-
                         python: 3.9.13 (main, May 30 2022, 11:25:38) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
                       platform: macOS-12.4-x86_64-i386-64bit
                 implementation: CPython
                     executable: /private/tmp/cv/p/bin/python
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 29182
                            cwd: /private/tmp/cv
                           path: /private/tmp/cv
                                 /opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python39.zip
                                 /opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9
                                 /opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/lib-dynload
                                 /private/tmp/cv/p/lib/python3.9/site-packages
                    environment: HOME = /Users/jmg
                   command_line: /private/tmp/cv/p/lib/python3.9/site-packages/coverage/__main__.py debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.38.5
             sqlite3_temp_store: 0
        sqlite3_compile_options: ATOMIC_INTRINSICS=1, COMPILER=clang-13.0.0, DEFAULT_AUTOVACUUM,
                                 DEFAULT_CACHE_SIZE=-2000, DEFAULT_FILE_FORMAT=4,
                                 DEFAULT_JOURNAL_SIZE_LIMIT=-1, DEFAULT_MMAP_SIZE=0, DEFAULT_PAGE_SIZE=4096,
                                 DEFAULT_PCACHE_INITSZ=20, DEFAULT_RECURSIVE_TRIGGERS,
                                 DEFAULT_SECTOR_SIZE=4096, DEFAULT_SYNCHRONOUS=2,
                                 DEFAULT_WAL_AUTOCHECKPOINT=1000, DEFAULT_WAL_SYNCHRONOUS=2,
                                 DEFAULT_WORKER_THREADS=0, DISABLE_INTRINSIC, ENABLE_COLUMN_METADATA,
                                 ENABLE_FTS3, ENABLE_FTS3_PARENTHESIS, ENABLE_FTS4, ENABLE_FTS5,
                                 ENABLE_GEOPOLY, ENABLE_MATH_FUNCTIONS, ENABLE_RTREE, ENABLE_STAT4,
                                 ENABLE_UNLOCK_NOTIFY, MALLOC_SOFT_LIMIT=1024, MAX_ATTACHED=10,
                                 MAX_COLUMN=2000, MAX_COMPOUND_SELECT=500, MAX_DEFAULT_PAGE_SIZE=8192,
                                 MAX_EXPR_DEPTH=1000, MAX_FUNCTION_ARG=127, MAX_LENGTH=1000000000,
                                 MAX_LIKE_PATTERN_LENGTH=50000, MAX_MMAP_SIZE=0x7fff0000,
                                 MAX_PAGE_COUNT=1073741823, MAX_PAGE_SIZE=65536, MAX_SQL_LENGTH=1000000000,
                                 MAX_TRIGGER_DEPTH=1000, MAX_VARIABLE_NUMBER=32766, MAX_VDBE_OP=250000000,
                                 MAX_WORKER_THREADS=8, MUTEX_PTHREADS, SECURE_DELETE, SOUNDEX,
                                 SYSTEM_MALLOC, TEMP_STORE=1, THREADSAFE=1

coverage==6.4.2

What code shows the problem?

for i in ['a', 'b', 'c']:
	if i == 'a':
		print('d')
	elif i == 'b':
		print('e')
	elif i == 'c':
		print('f')
	else: # pragma: no cover
		raise ValueError('unhnadled')

	continue

	raise Exception('an exception')

What commands did you run?

python -m coverage run t.py
python -m coverage report -m

Expected behavior
I expect that the report only shows that line 13 is uncovered, but line 11 should be covered as it is the continue that prevents line 13 from running.
Additional context
Add any other context about the problem here.

This is because jumps to jumps are often optimized away:
% python3.9 -m dis bug1432.py
  1           0 LOAD_CONST               0 (('a', 'b', 'c'))
              2 GET_ITER
        >>    4 FOR_ITER                76 (to 82)
              6 STORE_NAME               0 (i)

  2           8 LOAD_NAME                0 (i)
             10 LOAD_CONST               1 ('a')
             12 COMPARE_OP               2 (==)
             14 POP_JUMP_IF_FALSE       26

  3          16 LOAD_NAME                1 (print)
             18 LOAD_CONST               2 ('d')
             20 CALL_FUNCTION            1
             22 POP_TOP
             24 JUMP_ABSOLUTE            4

  4     >>   26 LOAD_NAME                0 (i)
             28 LOAD_CONST               3 ('b')
             30 COMPARE_OP               2 (==)
             32 POP_JUMP_IF_FALSE       44

  5          34 LOAD_NAME                1 (print)
             36 LOAD_CONST               4 ('e')
             38 CALL_FUNCTION            1
             40 POP_TOP
             42 JUMP_ABSOLUTE            4

  6     >>   44 LOAD_NAME                0 (i)
             46 LOAD_CONST               5 ('c')
             48 COMPARE_OP               2 (==)
             50 POP_JUMP_IF_FALSE       62

  7          52 LOAD_NAME                1 (print)
             54 LOAD_CONST               6 ('f')
             56 CALL_FUNCTION            1
             58 POP_TOP
             60 JUMP_ABSOLUTE            4

  9     >>   62 LOAD_NAME                2 (ValueError)
             64 LOAD_CONST               7 ('unhnadled')
             66 CALL_FUNCTION            1
             68 RAISE_VARARGS            1

 11          70 JUMP_ABSOLUTE            4

 13          72 LOAD_NAME                3 (Exception)
             74 LOAD_CONST               8 ('an exception')
             76 CALL_FUNCTION            1
             78 RAISE_VARARGS            1
             80 JUMP_ABSOLUTE            4
        >>   82 LOAD_CONST               9 (None)
             84 RETURN_VALUE

Notice that nothing jumps to offset 70 (line 11), and all the places that should have be re-written as jumps to offset 4, where line 11 would jump to.
This is being changed in Python 3.10 and later.  If you use that version, you should see line 11 covered.
(Duplicate of #198)


fix(#44): image can not display

fix #44

Codecov Report

Merging #45 (60df9c8) into main (55c6349) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           11        11
  Branches         1         1
=========================================
  Hits            11        11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c6349...60df9c8. Read the comment docs.


fixes issue #309

I wouldn't mind getting input from @blukai, I chose colors that would be easy to read.

hover state:

Probably Material-ui Grid List can be better here?

Idk, I was just fixing what was listed in the issue (text contrast). If you want to explore using the material ui component I think it's worth looking into. I do sort of like the current aesthetic more than the 'photo album' aesthetic of the material-ui component.

@blukai you can just push those changes to this branch, assuming the changes you asked for are with the heroes page


Npm- cannot find module "are-we-there-yet"

Hi everybody,
I use centos os ver 6.7, when i use npm, i get error "error 'REPLACE_INVALID_UTF8' is not member of V8::String". Then i enter command " npm -g install npm", i get error "Npm- cannot find module "are-we-there-yet"". Who can tell me how to fix it? Thanks so much.

This is an issue for npm, have a look through the issues here: https://github.com/npm/npm/search?q=are-we-there-yet&type=Issues&utf8=✓
Unfortunately I don't think we can give clear advice on this as it seems to be very dependent on exactly what you have installed and the npm folk are best placed to help. The only suggestion I have is to stick with npm v2 for now, npm install npm@2 -g, although it's possible your installation is borked now and you need to reinstall node/npm from scratch.

Thanks for reply!


Ct unstable

:tada: This PR is included in version 1.1.0 :tada:
Your semantic-release bot :package::rocket:


Floating heart animation added

Title and Issue number

I have added the project .Can it be merged now?
Close #4714

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

@MohitGupta121 ,@TusharKesarwani Please review my PR.


Image pull is failing in Portainer, whilst working in the CLI

Bug description
Image pull with codait/max-object-detector:arm-arm32v7-latest is failing in Portainer, but pulls correctly via CLI
Expected behavior
If it works via CLI, it should work in Portainer.
Steps to reproduce the issue:

Go to images view and try to pull codait/max-object-detector:arm-arm32v7-latest
See failure unable to pull image
See errors in console and in response

EDIT: After pulling via CLI, deleting it and pulling via Portainer again it pulled successfully. So there must be an error in our retry logic if the pull is slow (its a 1.68GB image) maybe it times out and messes up the pull causing the JSON and JS errors
Technical details:

Portainer version: 1.24.0
Docker version (managed by Portainer): 19.03.8
Platform (windows/linux): Linux,RPI4 endpoint
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): docker stack deploy
Browser: FireFox

Additional context
Pulls fine via CLI

I have just tested this... it fails on the edge agent and regular agent... seemingly the download stream is interrupted for some reason and we cannot tolerate that.
The error seen in the portainer logs is:
2020/06/10 09:49:01 httputil: ReverseProxy read error during body copy: http: unexpected EOF reading trailer
TBH, a 1.6GB image requires a pretty solid and uninterrupted connection to download

True :) I am the one that reported this in the first place. The main problem is that it fails silently and it is hard for the user / operator to understand the reason for the failure. But in fairness it should be able to pull the image. For me I use this for a ML project for object detection, and the ML model is quite big ....

We will investigate ways to work around in future versions.. unfortunately we delegate the pull to the Docker engine via the Docker API and it doesnt provide updates during the process.. just get a success or failure message.

@ncresswell Same is happening for a 753 MB image, Portainer 1.23.2.  Is there any update to this issue?
Also, I'm unclear on your comment regarding '[delegating] the pull to the Docker engine via the Docker API."  To my understanding, the CLI is doing the same and if the CLI, via 'docker pull ' is working, then why is Portainer failing prior to the complete download?  Is there a timeout in Portainer associated with pulling an image?  Note, there are docker and compose timeout environment variables which can be set, e.g. COMPOSE_HTTP_TIMEOUT.

Not yet. We are seeing it across all versions of Portainer.. only for large images being pulled via a slow link. Its earmarked to have a workaround in CE 2.1.

Having a similar issue.
Tested with several images of different sizes, like 20MB and more.
Looking on the web, some says about the internet connection speed, but it's not my case with 300MB/s of downloading speed.
Pulling the image with Portainer always gave me an error. Pulling the same image with Docker has no error.
From the Portainer log:
2020-12-15T08:18:35.085454193Z 2020/12/15 08:18:35 http error: Error response from daemon: Head https://registry-1.docker.io/v2/library/postgres/manifests/13.0: Get https://auth.docker.io/token?scope=repository%3Alibrary%2Fpostgres%3Apull&service=registry.docker.io: net/http: TLS handshake timeout (err=Error response from daemon: Head https://registry-1.docker.io/v2/library/postgres/manifests/13.0: Get https://auth.docker.io/token?scope=repository%3Alibrary%2Fpostgres%3Apull&service=registry.docker.io: net/http: TLS handshake timeout) (code=500)

Any idea?

same issue here

same issue here

New on this issue resolution?

@XargonWan Hey, this isn't something that is currently on our roadmap, but we would welcome any contributions on this.

Still happening; any news, it's 16 months since last update?

met the same problem occasionally when i switched to amd64 platform
the portainer works quite good while in armv8 platform

I have the same issue when import 6.3G image

noticing this issue with 2.19.5 and ghcr.io images. docker hub works fine.


EFS - Encryption of Data in Transit (Question)

@darrylsosborne,
Can you confirm this template enables encryption of data in transit to/from EFS?
I just came across this AWS News Blog announcing Encryption of Data in Transit for Amazon EFS dated after your Version 2.0.2 template, so wanted to check. Reference article: https://aws.amazon.com/blogs/aws/new-encryption-of-data-in-transit-for-amazon-efs/
Thank you, Mike

@darrylsosborne ... would welcome your thoughts!

@michael-newman  It says PRETTY clearly it is over a private network? Who's going to perform a MIM attack on that?

@ecout AWS's official recommendation is to use Encryption of Data in Transit for PII/Sensitive data even while on a private network.
AWS recommends that organizations implement encryption of sensitive information in motion wherever possible.
https://aws.amazon.com/blogs/security/how-to-address-the-pci-dss-requirements-for-data-encryption-in-transit-using-amazon-vpc/


Add support for pandas_profiling

Is your feature request related to a problem? Please describe.
It takes quite a bit of code to analyze the data
Describe the solution you'd like
With pandas_profiling, an informative report could be created in one line of code. This library becomes increasingly popular. Would be nice if we support this in our Datapane report

Thanks for the suggestion. Would you want this as an extension to the table viewer (probably opening the profile in another view, like a modal), or would you want it as a separate component?

I think either way would work great!


Render Loaders and Responses

Description
Describe change or new feature here.
Refactored redux actions to be able to have singular loading and error response to reduce unwanted message triggering. Added loaders to buttons and also to the email confirmation.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] I have performed a self-review of my own code
[x] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works .
[ ] New and existing unit tests pass locally with my changes

Great work Richyy!