diagnostics from non-lsp: linters

https://github.com/brianaung/yasl.nvim/blob/6c37bd4728f728474c223e61203dd0c938ccfee2/lua/yasl/builtins/diagnostics.lua#L16-L18
this lines of code block linters

Hey there!
I tried to reproduce the error using this minimal config with none-ls linter but could not replicate it.
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system {
        "git",
        "clone",
        "--filter=blob:none",
        "https://github.com/folke/lazy.nvim.git",
        "--branch=stable",
        lazypath,
    }
end
vim.opt.rtp:prepend(lazypath)

require("lazy").setup {
    {
        "nvimtools/none-ls.nvim",
        dependencies = {
            "nvim-lua/plenary.nvim",
        },
        config = function()
            local null_ls = require("null-ls")
            null_ls.setup {
                sources = {
                    null_ls.builtins.diagnostics.selene,
                },
            }
        end,
    },
    {
        "brianaung/yasl.nvim",
        config = function()
            require("yasl").setup {
                enable_icons = true,
            }
        end,
    },
}

Which linter are you using? Can you provide me a bit more info so I can look into this further?

Regardless that check shouldn't be needed anymore.
I used to display different status for LSP "OFF" and active and copilot was attaching to it, but that's no longer the case.
I will update it but your problem might be different so I will wait for it first.

yes, I am using https://github.com/mfussenegger/nvim-lint so any diagnostics from the linter will not be displayed on the statusline.

Hey the fix has been merged.
I have tested it and it works. let me know if the error still persists.

it works fine, thank you.


Bump CI to ubuntu-24.04

CI fails to install g++-13 on older ubuntu versions.

Clearly it's not as simple as this. How does the pypi release get done currently?

Hi,
Thanks for the patch, however, we plan to support 20.04 at least until April next year which is the maintenance deadline of this Ubuntu version.
We deployed 6.24.0 to Pypi successfully, and we'll deploy 6.24.1 hopefully soon, too.


The official docs are misleading

I wonder if it would make sense to hold off merging drastic changes like removing sveltekit until ready to also update the docs?
Or have the install script from for example https://tauri.app/v1/guides/getting-started/setup/sveltekit point to a stable version of create-tauri-app? Definitely anyone new who's discovering tauri at the moment is going to be super confused when the official docs doesn't even have a Svelte (without kit) option, and yet the app has meanwhile gotten rid of sveltekit.

create-tauri-app isn't the same as the guides one the website, they aim to solve the same problem but in different ways and they don't need to have parity. l
We will be updating the docs to make this more obvious.


Removed unnecessary code

Removed unnecessary IDisposable pattern and repeated code to make the example easier to understand. I also had to update the MongoDB driver to make the application build.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: eskaufel sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Android - Attachment - Long images are not displaying correctly in the chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:

On a conversation, click on the + button in the compose box
Upload this long image to a conversation
Notice image zoom in and out fast automatically

Expected Result:
Image should display correctly in the chat and don't flash.
Actual Result:
Long image are not displaying correctly in the chat and flashes.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/f0768d8f-a491-45f4-94ba-25f93a9ac17c

View all open jobs on GitHub

Production video
https://github.com/Expensify/App/assets/115492554/18a71438-0023-4978-8cb6-08c3c04fa08c

@youssef-lr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Thanks @izarutskaya. I'm looking at the checklist now to see if I can find any PRs that might have caused this.

could you please upload the image you used for testing?

That works, thanks!

I'm unable to reproduce this one.
https://github.com/Expensify/App/assets/9680864/0cb6d89b-e852-4918-9d2a-c9c39f3d2eea

No update yet, we need reproduction. Will ask again tomorrow as I'm about to sign off.

Let us know how you get on! Also, doesn't that look wrong as it's super skinny?

@youssef-lr any luck?

I think we can just close this. We haven't got any real world reports from this and I wasn't able to reproduce.

Also, doesn't https://github.com/Expensify/App/issues/37725#issuecomment-1978605674 as it's super skinny?

I don't think there's a way around it, the image has weird dimensions and is super super long.


Close to the Left isn't working

Very strange, but all other menu items that this extension adds are working, and the 'Close to the Left' menu item does nothing. I also separately tried another extension that provides this same menu item, and noticed the same thing. I've used that extension for years and it worked fine, and then stopped working recently. Also worth noting that running the "Close Editors to the Left in Group" command from the command palette behaves as expected, as does the built-in "Close to the Right" command. I've tested this both on the latest stable VSCode, 1.77.3, and 1.78-insiders.
Version: 1.78.0-insider
Commit: e410e7c66e7ce5c6bc31f73150d66857804a0ee9
Date: 2023-04-28T12:48:09.032Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: Yes

Thanks for the report!
This extension basically adds a new button that calls the existing vscode commmand workbench.action.closeEditorsToTheLeft so if on vscode it still works is definitely weird.
I checked the command name just in case it has changed but it doesn't seem.
I'm gonna further investigate :)

A final solution for this can be implemented after https://github.com/microsoft/vscode/issues/188572


Upgrade node-sqlite3 in promise-sqlite

Once https://github.com/mapbox/node-sqlite3/pull/723 lands, we should hop to the latest version. Free performance improvements!

Fixed by 8432e89b97ed81e5037812b260b7c2060be17903.


Broken link in README

There is a broken link in the following sentence in Team section of README:

You can read more about Duo.js and Component here.

If you provide a PR I'll happily merge it.

Unfortunately I don't know the correct link.


Fix dolphin's dedpendency on the StandaloneRTC project

The StandaloneRTC project really shouldn't be included in the SLNs of the other projects so if it's included in Dolphin and preventing it from building without the RuntimeIdentifiers, we should remove that.
Originally posted by @NarryG in https://github.com/redscientistlabs/RTCV/pull/239#discussion_r491750370

Resolved
https://github.com/redscientistlabs/dolphin-vanguard/commit/03022bc0b0639520ab0744a076ed641fa18951f4
https://github.com/redscientistlabs/dolphin-vanguard/commit/4256ae5664e17f04f6b97ba5e3d382f42715c75b


mgmt regen resources module for checkstyle fix

autorest.java PR https://github.com/Azure/autorest.java/pull/566

What happen for the manual fix? Could it be done by generator?

@ChenTanyi
Currently major thing is build() -> buildClient(), which I am still checking with Redmond whether they are OK with the change. Since it is only 1 per service, I figure it is not urgent.
The rest is either on conflict class always in resources (since it got 4 clients, instead of 1 for usual services), or on Features (which is strange). I will check Features later.
Generator is on v4_fix_checkstyle1 branch. Not merged.

@ChenTanyi
Currently major thing is build() -> buildClient(), which I am still checking with Redmond whether they are OK with the change. Since it is only 1 per service, I figure it is not urgent.
The rest is either on conflict class always in resources (since it got 4 clients, instead of 1 for usual services), or on Features (which is strange). I will check Features later.
Generator is on v4_fix_checkstyle1 branch. Not merged.

Is this for consistency? Normally it should be build() for Builder class.

@xccc-msft
checkstyle requires it be buildClient for class annotated with @ServiceClientBuilder.

@xccc-msft
checkstyle requires it be buildClient for class annotated with @ServiceClientBuilder.
Got it. Yes, resources has more clients as it contains different RPs.


Initial MWE sketch of registry app

As discussed with @PeterKraus and @unkcpz in today's office hours.
<create fresh env>
pip install -r requirements.txt
python app.py &
curl localhost:5000/filetypes

Still need to find the right place to put the other code we sketched out


Upgrade Remotion.Linq dependency to RTM

Resolves https://github.com/aspnet/EntityFrameworkCore/issues/9311
@Eilon - for approval
cc: @ajcvickers @natemcmaster

@natemcmaster - When will these changes propagate to EF repo? Is there any manual step required to do so?

Normally, over the weekend our automation would update EFCore. But, you can do this manually yourself now that your change made it into a build and is on myget.
./run.ps1 -u upgrade deps


plugin version as variable in standalone-servers

Motivation
Adjust standalone-servers pom to allow successful processing by PME (http://release-engineering.github.io/pom-manipulation-ext/)
Modifications
Swarm plugin version has been changed from hardcoded to ${project.version}.
Result

[X] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[X] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[X] Have you built the project locally prior to submission with mvn clean install?

Can one of the admins verify this patch?

ok to test


3.2 no python console , debug  ipython console ,debug command not display and not work for me

Description of your problem
What steps will reproduce the problem?

because spyder 3.2 no python console . in ipython console ,debug mode command not display and not work .  but downgrade to 3.1.3 use python console is ok.
I don't know why in python don't debug and show command. from mac 10.9.5 in spyder 3 to now.
3.Thanks .

What is the expected output? What do you see instead?
 10 import JohhnsonUtil.johnson_cons as ct
 12 from JSONData import powerCompute as pct
 13 from JSONData import stockFilter as stf

/Users/Johnson/Documents/Quant/pyQuant/stock/sina_Market-DurationDn.py(12)()ipdb> ()ipdb>()ipdb>()ipdb> (no debug command [next|continue]....)

Please provide any additional information below
Versions and main components

Spyder Version: 3.2
Python Version: 2.7.11 |Anaconda 2.4.0 (x86_64)
Qt Version:     5.6.2
PyQt Version: 5.6.0
Operating system: 10.12.6

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
IPython >=4.0;<6.0:  5.3.0 (OK)
cython >=0.21     :  0.23.4 (OK)
jedi >=0.9.0      :  0.9.0 (OK)
nbconvert >=4.0   :  5.1.1 (OK)
numpy >=1.7       :  1.10.1 (OK)
pandas >=0.13.1   :  0.17.1 (OK)
psutil >=0.3      :  5.2.1 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pyflakes >=0.5.0  :  1.5.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
pylint >=0.25     :  1.6.5 (OK)
qtconsole >=4.2.0 :  4.2.1 (OK)
rope >=0.9.4      :  0.10.5 (OK)
sphinx >=0.6.6    :  1.5.3 (OK)
sympy >=0.7.3     :  <IP_ADDRESS> (OK)

problem :
"The latter link indicates that the error is caused by the fact that the debugger outputs step-by-step ipdb content into the interpreter. One user reported that the behavior stopped when he (and I quote)
disabled logging to console before running in debug mode"
thanks


How to set the system armed

At first thank you very much for the work.
I am able to download videos and get camera status, but how can i arm / disarm the system ?
#!/usr/bin/python3
from blinkpy import blinkpy
blink =<EMAIL_ADDRESS>password='4711', refresh_rate=30)
blink.start()
blink = blinkpy.BlinkSyncModule(blink, network_name='Daheim', network_id='312553', camera_list='845730')
blink.arm()
There are two cameras at Daheim.
Thanks in advance

Hi Kevin,
thank you very much - it works :-)
Is there any (understandable) document to find things like this ?
Best regards
Jörg
------ Originalnachricht ------
Von: "Kevin Fronczak"<EMAIL_ADDRESS>An: "fronzbot/blinkpy"<EMAIL_ADDRESS>Cc: "TCRW"<EMAIL_ADDRESS>"Author"
<EMAIL_ADDRESS>Gesendet: 13.05.2020 15:26:08
Betreff: Re: [fronzbot/blinkpy] How to set the system armed (#257)

Closed #257 https://github.com/fronzbot/blinkpy/issues/257.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fronzbot/blinkpy/issues/257#event-3332062232, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGLDDITO7WMRSZISSSCWF3RRKNXBANCNFSM4M7XMECQ.


Make it clear the location of the flags matter

I always find this quite annoying about the docker cli, where it matters in which place the flags are passed (docker --flag run --other-flag is not the same as docker --other-flag run --other-flag). This makes sense for command specific arguments (e.g. --qr) but feels quite confusing for other flags.
Maybe the error message ("Error: No endpoint supplied. Supply an endpoint either via `--endpoint` or via `--config`") can be extended to make this more clear.
❯ aries-cli connections get-all
Error: No endpoint supplied. Supply an endpoint either via `--endpoint` or via `--config`

~
❯ aries-cli connections get-all --endpoint https://agent.community.animo.id
error: Found argument '--endpoint' which wasn't expected, or isn't valid in this context

	If you tried to supply `--endpoint` as a value rather than a flag, use `-- --endpoint`

USAGE:
    aries-cli connections get-all

For more information try --help

I took a look at this again today, and I came to the same conclusion that I think its technically possible to add but there will be a lot of collision.
siera -a connection invite -a -> first -a is --api-key and second a is ---auto-accept
Do you think that some documentation at the siera -h command would suffice?


Update QUICHE from f326e9346 to 667c58656

https://github.com/google/quiche/compare/f326e9346..667c58656
$ git log f326e9346..667c58656 --date=short --no-merges --format="%ad %al %s"

2023-09-13 birenroy Adds an OgHttp2Session option for the initial assumed value of the remote endpoint's max concurrent streams setting.
2023-09-13 quiche-dev Add missing absl includes
2023-09-13 quiche-dev Allow truncating of binaryhttp request
2023-09-12 vasilvv Set a fixed CC algorithm in quic_generic_session_test
2023-09-11 bnc Make QuicErrorCode underlying type uint32_t, avoid narrowing when parsing.
2023-09-11 quiche-dev Registering a new use case to test out go/at-integration-guide.
2023-09-11 vasilvv Introduce support for basic WebTransport stats.
2023-09-11 vasilvv Add missing QUICHE_EXPORT directives.
2023-09-07 vasilvv Fix QUICHE_EXPORT directives for Chromium merge
2023-09-07 vasilvv Add missing QUICHE_EXPORT annotations

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

I see there is also https://github.com/envoyproxy/envoy/pull/29602, which is marked as draft too. Are these PRs coordinated?

I have no idea.  @birenroy asked me to make sure I got his change in and I did?

Sorry, I decided to work through the Envoy QUICHE import instructions, and forgot that this would end up being publicly visible. I was just practicing, and didn't mean to start a competing PR.

Sorry, I decided to work through the Envoy QUICHE import instructions, and forgot that this would end up being publicly visible. I was just practicing, and didn't mean to start a competing PR.

AH! Thanks for the backstory. If it's any consolation, GH is profoundly terrible about PRs, visibility, reviews, etc. You did everything right...


chore: release main

:rock: I've created a release for you
crash-handler: 4.1.6
4.1.6 (2024-07-11)
Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^4.1.5 to ^4.2.0

log-error: 4.2.0
4.2.0 (2024-07-11)
Features

add a logUserErrorsAsWarnings option (8c7541a)

middleware-log-errors: 4.2.0
4.2.0 (2024-07-11)
Features

add a logUserErrorsAsWarnings option (8c7541a)

Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^4.1.5 to ^4.2.0

middleware-render-error-info: 5.1.6
5.1.6 (2024-07-11)
Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^4.1.5 to ^4.2.0

opentelemetry: 2.0.5
2.0.5 (2024-07-11)
Bug Fixes

disable the pino instrumentation (7daaa7b)
manually pass a meterprovider to host metrics (63c8216)
wrap the Reliability Kit logger (28640ee)

Dependencies

The following workspace dependencies were updated

dependencies

@dotcom-reliability-kit/log-error bumped from ^4.1.5 to ^4.2.0

This PR was generated with Release Please. See documentation.

:robot: Created releases:

crash-handler-v4.1.6
log-error-v4.2.0
middleware-log-errors-v4.2.0
middleware-render-error-info-v5.1.6
opentelemetry-v2.0.5
:sunflower:


Get MltDecoderTest.compareTiles working

I noticed that the tile comparison in the decoder tests only asserts on Feature IDs and currently not more: https://github.com/maplibre/maplibre-tile-spec/blob/22a0fc8659962d313af78dab8a4c01fd5024fbe3/converter/java/src/test/java/com/mlt/decoder/MltDecoderTest.java#L90-L136.
(There are some asserts, but they are commented).
This needs to assert on all aspects of the MVT spec that are comparable, including:

Layer names
Feature properties
Feature geometry type and coordinates

/cc @mactrem @ebrelsford @nyurik

@springmeyer yes, I always have tested all information of the tile. But as I’m currently doing a larger refactoring where a lot of has changed, I step by step getting the tests to run again and adding the asserts on different aspects step by step. I hope to commit a version by today where all aspects are tested again

Asserts restored now (https://github.com/maplibre/maplibre-tile-spec/blob/1d08bd24c7661883a3b0fd2b518880dcc0fcecf6/converter/java/src/test/java/com/mlt/decoder/MltDecoderTest.java#L126-L211) after #52


implement --device=auto

What
Fix #131.

Codecov Report

Merging #135 (7172e6e) into dev (55a586b) will decrease coverage by 0.01%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##              dev     #135      +/-   ##
==========================================
- Coverage   65.89%   65.88%   -0.02%
==========================================
  Files          66       66
  Lines        4900     4910      +10
==========================================
+ Hits         3229     3235       +6
- Misses       1671     1675       +4

Impacted Files
Coverage Δ

src/kwja/cli/utils.py
48.00% <16.66%> (-3.12%)
:arrow_down:

src/kwja/cli/cli.py
23.84% <100.00%> (+1.62%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


tools/remill_disass/ida: invalid syntax in disass.py

From tools/remill_disass/ida/disass.py:
# Python 2.7 doesn't range on longs
def lrange(start, end):
  """Duplicate of the range() function for long integers."""
  num = long(start)
  while num < end:
    yield num
    num += 1L

Build error from make install:
copying remill_disass.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying remill_disass.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying remill_disass.egg-info/dependency_links.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying remill_disass.egg-info/entry_points.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying remill_disass.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
  File "build/bdist.linux-x86_64/egg/remill_disass/ida/disass.py", line 394
    num += 1L
            ^
SyntaxError: invalid syntax

The following patch solves the syntax error on my system, running Python 3.6.0.
 # Python 2.7 doesn't range on longs
 def lrange(start, end):
   """Duplicate of the range() function for long integers."""
   num = long(start)
   while num < end:
     yield num
-    num += 1L
+    num += 1


Why is not ingress included in jaeger-operator?

Most of the charts contain an ingress, but this is omitted in the jaeger-operator. I would like to enable tls.

I also want to enable TLS.


Upgrade to Node.js 20

Upgrading to Node.js 20 as Node.js 16 is end-of-life

Apologies for my initial comment being sparse. Before submitting, I did scan through the project for any dependencies or processes that would disagree with Node.js 20, but I didn't find anything


Add cBO (1D Problem)

Added notebook in example folder for 1D version. The 2D version is larger than 25 MB, so wont be able to upload. Please review. Thank you

The piecewise function is just a demonstration to showcase how it will work with some incorrect information (which it worked still!).
We can use different mean function as well.
On the prior distribution, the normal values are changed to real values and therefore the unif distribution is provided as part of the real parameter space (non-normalized one) [0, 15]. Please look below.
@jit
def mean_func(x: jnp.ndarray, params: Dict[str, float]) -> jnp.ndarray:
x_data = x[:,0]
#jax.debug.print("x_norm: {}", x_data)
**lb = 0
ub = 15
x_data = x_data*(ub-lb) + lb**
#jax.debug.print("x: {}", x_data)

return jnp.piecewise(
        x_data, [x_data < params["t"], x_data >= params["t"]],
        [lambda x_data: (params["a2"]*jnp.sin(x_data*params["a1"])),
         lambda x_data: (params["b2"]*jnp.sin(x_data*params["b1"]))])

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b7c2577) 95.59% compared to head (e2c8189) 95.62%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   95.59%   95.62%   +0.02%
==========================================
  Files          51       51
  Lines        3930     3930
==========================================
+ Hits         3757     3758       +1
+ Misses        173      172       -1

Flag
Coverage Δ

unittests
95.62% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Yes definitely, I am advising Shakti (Sergei’s postdoc) to apply cBO on nano indentation problem. We can use that notebook as real problem.


fix(workloads details): fixed a total risk filter + empty state

I fixed the total risk filter so it should work with mock data
I added an empty state for 0 matching results

:tada: This PR is included in version 1.37.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Call to undefined method Omnipay\Common\Http\Client::post()

laravel-omnipay/omnipay-alipay 3.0
Call to undefined method Omnipay\Common\Http\Client::post()
httpclient 找不到，已经引入 guzzlehttp/guzzle 6.3

同问

Composer 安装 league/omnipay


Check integrity at branch 'Funktionalität'

check spelling & grammar
check integrity (missing 'Fehlerbedingung:' at 'Wunschkriterien')
check style
specify 'Vorbedingung'; 'Nachbedingung'; 'Fehlerbedingung'

PF1090 doesn't make any sense.
Cluster position calculation should not depend on sensors at all (only lat/lon).
Sensor assignment to a certain cluster should only depend on sensor location, not the specific data or its average.

Please check PF1150, PF1160, PF1170. What is the underlying criterium?

Please check PF1150, PF1160, PF1170. What is the underlying criterium?

MK2060?


fix: fix recovery hang and in-consistency for create/drop streaming jobs

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fixed several bugs in recovery deterministic test with --kill-meta:

recovery deterministic will hang occasionally.

Originally posted by @yezizp2012 in https://github.com/risingwavelabs/risingwave/issues/5444#issuecomment-1254868444
the reason is #5145. In this PR, I persist the notification version and try not to block waiting ddl operation using correct dll version.

added catalog error for meta and reported it to frontend to fulfill should retry check in simulation. Because currently it uses whether the error message contains exists as should retry condition, but some e2e test SQLs will contains exists as well. So I changed the condition to whether the error message contains exists and Catalog error.
since we introduced asynchronously delete streaming job in StreamingJobBackgroundDeleter, those to-delete streaming jobs should be cleaned before recovery and should not be rebuilt. If not so, the recovery process will fail due to source not found error. So in this PR, I added a tracker in_progress_creation_streaming_job in catalog manager, to avoid some in-consistency when cleaning streaming jobs at the beginning of recovery. This's just a workaround and should be refactored when we start to refactor CatalogManager and TableFragmentManager.

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
Resolve #5145 Part of #4527

After this PR merged, there will be only one bug found here:
command
RUST_BACKTRACE=1 MADSIM_TEST_SEED=1 ./risedev sslt --release -- --kill-meta "e2e_test/streaming/tpch_upstream.slt"

bug
actor exist unexpected when executing include ../tpch/insert_orders.slt.part:
2022-01-02T02:50:32.590521Z ERROR node{id=8 name="compute-3"}:task{id=966416}: risingwave_stream::task::stream_manager: actor exit actor=76007 error=Executor error: Deleting non-existent element
2022-01-02T02:50:32.590523Z ERROR node{id=8 name="compute-3"}:task{id=966412}: risingwave_stream::executor::actor: actor exit without stop barrier actor_id=76001
2022-01-02T02:50:32.590524Z ERROR node{id=6 name="compute-1"}:task{id=970788}: risingwave_stream::executor::actor: actor exit without stop barrier actor_id=76006
2022-01-02T02:50:32.590527Z ERROR node{id=8 name="compute-3"}:task{id=966418}: risingwave_stream::executor::subtask: actor downstream subtask failed
2022-01-02T02:50:32.590527Z ERROR node{id=8 name="compute-3"}:task{id=966418}: risingwave_stream::task::stream_manager: actor exit actor=76008 error=Executor error: Deleting non-existent element
...
2022-01-02T02:50:32.664685Z ERROR node{id=8 name="compute-3"}:task{id=966220}: risingwave_stream::task::stream_manager: actor exit actor=25019 error=Executor error: failed to pull left message, stream closed unexpectedly
2022-01-02T02:50:32.664695Z ERROR node{id=7 name="compute-2"}:task{id=974637}: risingwave_stream::task::stream_manager: actor exit actor=25028 error=Executor error: right barrier received while left stream end
2022-01-02T02:50:32.664747Z ERROR node{id=7 name="compute-2"}:task{id=974635}: risingwave_stream::task::stream_manager: actor exit actor=25027 error=Executor error: right barrier received while left stream end
2022-01-02T02:50:32.664839Z ERROR node{id=6 name="compute-1"}:task{id=970246}: risingwave_stream::task::stream_manager: actor exit actor=40012 error=Executor error: right barrier received while left stream end
2022-01-02T02:50:32.664850Z ERROR node{id=6 name="compute-1"}:task{id=970674}: risingwave_stream::task::stream_manager: actor exit actor=49011 error=Executor error: left barrier received while right stream end
2022-01-02T02:50:32.664888Z ERROR node{id=8 name="compute-3"}:task{id=966502}: risingwave_stream::task::stream_manager: actor exit actor=46008 error=Executor error: right barrier received while left stream end
2022-01-02T02:50:32.664935Z ERROR node{id=8 name="compute-3"}:task{id=966276}: risingwave_stream::task::stream_manager: actor exit actor=19015 error=Executor error: left barrier received while right stream end

Seems like this bug caused in range cache of dynamic_filter state. Need more investigation.


public ip list NAT provisioning problems

I had infrastructure created and working till last week. I did not change anything on the configuration, just updated the version of tf to 0.11.11 from 0.11.10 and successfully executed terraform plan hence my state files are now 0.11.11 but now when I try to reprovision the infrastructure I get the following error:
module.noise.module.vpc.aws_nat_gateway.this[3]: element: element() may not be used with an empty list in:
${element(aws_subnet.public.*.id, (var.single_nat_gateway ? 0 : count.index))}

This is my terraform code for it:
module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "1.57.0"

  name = "${var.project_name}"

  cidr = "${var.vpc_cidr_block}"

  azs = ["${data.aws_availability_zones.azs.names}"]

  public_subnets      = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24", "<IP_ADDRESS>/24"] // this has been expanded
  private_subnets     = ["${var.vpc_private_subnets}"]
  database_subnets    = ["${var.vpc_database_subnets}"]

  // Private subnets in your VPC should be tagged accordingly so that
  // Kubernetes knows that it can use them for internal load balancers
  private_subnet_tags = "${map(
      "kubernetes.io/role/internal-elb", "1"
    )}"

  enable_nat_gateway     = true
  single_nat_gateway     = false
  one_nat_gateway_per_az = true

  tags = "${merge(map(
      "Name", "${var.project_name}",
      "kubernetes.io/cluster/${var.project_name}", "owned",
    ), var.vpc_extra_tags)}"
}

As I said, this part of the code has not been changed for a while. I am not sure if I am missing something or it is a bug. We have terraform init a couple of times to introduce new modules.
Thanks in advance

I've fixed it by recreating the NAT gateway (setting it to false and then true again) but not sure why it fixed it also, couldn't have done it in live production. Closing this.


Programming Exercises: Viewing the exercise details results in an internal server error for the diff-report route

Describe the bug
When opening the exercise details of an exercise (that I just imported), I get an internal server error:

This is the corresponding Sentry issue: https://sentry.ase.in.tum.de/organizations/aet/issues/2192/?query=is%3Aunresolved&referrer=issue-stream&stream_index=2
So it looks like this issue was introduced with the latest release. Maybe a dependency update for jgit?
To Reproduce

Click on a programming exercise
See the internal server error message at the top right

Expected behavior
The exercise details page should be displayed correctly.
Screenshots

Which version of Artemis are you seeing the problem on?
7.7.5
What browsers are you seeing the problem on?
Safari
Additional context
No response
Relevant log output
No response

I think the 500 Internel Server Error is specific to this particular programming exercise (Java). The details in the network tab reveal the following:
{
    "type": "https://www.jhipster.tech/problem/problem-with-message",
    "title": "Internal Server Error",
    "status": 500,
    "detail": "Name is null",
    "path": "/api/programming-exercises/15589/diff-report",
    "message": "error.http.500"
}

In any case, the rest of the page should be displayed normally, even when there is an error with one specific REST call.

according to the stack trace on Sentry, this is an internal null pointer exception in JGit's DiffFormatter, I am not sure if we can fix this. Maybe, the exercise uses a Java feature, that the DiffViewer cannot handle? In any case, the programming exercise for which this error occurs is using Java 17. I'll try to find out more locally.

seems to happen with DiffEntry[MODIFY gradle/wrapper/gradle-wrapper.jar]. This is a binary file and could be excluded from the diff

Here is a branch that improves the error handling on the page so it gets rendered completely: bugfix/diff-report-error-handling

This seems to be a recent JGit bug which affects diff files with gitattribute -diff (or binary). This has been fixed in a recent commit: https://github.com/eclipse-jgit/jgit/commit/f2741cacec9f46724a0e48cc55cbb8892361e3d0. But there's no release yet.

I can confirm that the error with the recent dependency update of JGit: https://github.com/ls1intum/Artemis/commit/96ca4ec8bcbe508ba3d4ed247fdf57642146ba2d#diff-3d103fc7c312a3e136f88e81cef592424b8af2464c468116545c4d22d6edcf19L22

I think the 500 Internel Server Error is specific to this particular programming exercise (Java). The details in the network tab reveal the following:
{
    "type": "https://www.jhipster.tech/problem/problem-with-message",
    "title": "Internal Server Error",
    "status": 500,
    "detail": "Name is null",
    "path": "/api/programming-exercises/15589/diff-report",
    "message": "error.http.500"
}

In any case, the rest of the page should be displayed normally, even when there is an error with one specific REST call.

This is interesting because for the original exercise, from which I imported this exercise, the exercise details can be displayed 🤔

The JGit update has been reverted in https://github.com/ls1intum/Artemis/commit/3a6832e88ba1a3c5f44251d2f893d3bea89b1d0a.


Minds Java SDK

Short description of current behavior
The goal of this issue is to develop a new Java SDK for Minds.
Steps 🕵♂ 🕵♀

You can familiarize yourself with Minds.
Review the existing Python SDK as a reference.
Create a new repository in your account and submit a Pull Request (PR) to this repository, adding the new SDK to the Other SDKs section of the README.
Multiple contributors are welcome, but the SDK with the highest standards—such as clear documentation, robust tests, and overall code quality—will be accepted.

📢 Additional rewards 🏆
This issue brings 1⃣ 2⃣ 0⃣ points for SWAG and entry into the draw for a 👇 :
3⃣ ❌ 💻 Razer Blade 16 Gaming Laptop
👕 🐻 MindsDB Swag
ℹ For more info check out https://mindsdb.com/hacktoberfest 👈

I already had created an issue for mindsdb repo - https://github.com/mindsdb/mindsdb/issues/9790 which I'm assigned to and working on.
The issue is same. Hence, requesting to be assigned to this issue.

Since this needs a separate repo, minds-java-sdk - https://github.com/Better-Boy/minds-java-sdk.

  Please review once.
The following are done:

All functionalities except chat completion are done - (reason - no official java sdk from openai)
Unit test done
Integration test done
Documentation done
Readme update

Open to any feedback

@quest-bot embark


WIP: Refactoring and clean up

This PR has some refactoring to the Store constructor and a few other changes
Closes #31

This is on hold waiting for the ipfs-log update. Which I'll take a stab and try to get done today

Closing (unfortunately) stale PR. Let me know if I should re-open or if anything in here should be reconsidered for future work.


Add hook to register plugin macros

Instead of overriding the packageBooted() method when extending the Filament/PluginServiceProvider, this PR adds a method that also makes it possible for Filament to control when macros should be registered.
Also suggest to add the method to the Plugin development documentation.

Thanks :)


Authentication expired for @gmail.com

I'm getting repeated "Authentication expired" errors

Reloading the same cookie file produce "Invalid cookies file" error
Only solution found so far is to restart the procedure from scratch but sooner or later the error comes back.

Please read the following and let me know if it helps:
https://community.home-assistant.io/t/enhanced-google-maps-integration/682993/55

I had skipped the following step :
"Go to Security → “Manage all device” (under “Your devices”). All currently signed in sessions (including the one you just started) should be listed. Click on, and sign-out of, all of those sessions. You won’t, of course, be able to sign-out of the current session (probably listed at the top) this way."
I'm going to try this approach and see if it works

Something I don't understand.
In the readme there is this warning  (which I had strictly observed)
"It is extremely important to NOT log out from Google in the browser you use to get the cookies file. "
but in the forum post
"Now sign-out of the current session "
What is the difference between "log out" ans "sign out" ?

Those are two different procedures. And sign out & log out are just two different terms for the same thing.
In the forum post it's explaining how to make sure all other sessions are logged out. In this procedure you should log out when you're done.
In the readme (and the procedures in the actual config flow) it's explaining how to grab the cookies file. In this procedure you should NOT log out, but should rather close the browser window.

@gpion were you able to get it to work? If not, could you enable debug for the custom component, and then check the log for any messages near and/or related to the error?

@gpion were you able to get it to work?

Connection has been stable since reconfiguration
Fingers crossed


Keep focus on continuous scanning

Hi guys.
I am using your Continuous scanner sample app and I have following problem. Every time when qr code is being scanned camera auto focuses. I am wondering why it happens. I want it to scan very fast without auto focusing after each iteration. So my question is how can I achieve that?
Thanks.

Hi @yelnar
Your question seems confusing for me, do you want to disable auto focusing??

Hello @Bajranghudda1
Now I get it. The problem is that if when use this sample application (Continuous Scan), sometimes when the QR code is scanned the camera tries to refocus. For example, the qr code is scanned four times in a row very fast, then camera refocuses and again three-four times fast scanning and so on. So my question is that how can I avoid this refocus action.
P.S. I do not move the camera while it is scanning, so actually there is no reason to change the focus.

Hello @yelnar
I got it now, Ok lets see what you can do, make a flag variable (isThisDialogWindow = false) and if you successfully read bar code make it true, thats all.
  private final BarcodeCallback callback = new BarcodeCallback()
{
    @Override
    public void barcodeResult(BarcodeResult result)
    {
        if (!isThisDialogWindow)
        {
            if (result.getText() != "" || result.getText() != null)
            {
               beepManager.playBeepSoundAndVibrate();
                staffId = result.getText();
                Log.d(LOG," Scanned_staffId- "+ staffId);
                isThidDialogWindow = true;
              }
        }
        //Added preview of scanned barcode
        /*ImageView imageView = (ImageView) findViewById(R.id.barcodePreview);
        imageView.setImageBitmap(result.getBitmapWithResultPoints(Color.YELLOW));*/
    }

    @Override
    public void possibleResultPoints(List<ResultPoint> resultPoints)
    {
    }
};

Thanks @Bajranghudda1
I tried your solution but unfortunately it didn't help.
Actually why it should make sense? I mean, when the scanner first time scans some QR code it sees that the flag is false so it runs this code:
if (result.getText() != "" || result.getText() != null)
{
    beepManager.playBeepSoundAndVibrate();
    staffId = result.getText();
    Log.d(LOG," Scanned_staffId- "+ staffId);
    isThidDialogWindow = true;
}

And when it scans another time it just ignores that code. So what is the reason of this solution. I didn't get it.
Thank you

@yelnar The default is to focus around every two seconds or so. Is this what you're seeing?

@rkistner yes it is. But sometimes it becomes blurry and tries to focus very long time ~ 5-8 sec. So I can not figure why does it happen.

I hope to subscribe to this thread as I am seeing this issue in our production app. I installed and reproduced the issue on the sample app. I've attached a screen recording converted to GIF:

Hello, I am having the same issue.
Can please anyone give some help on this?

@yelnar @rkistner Is this somehow related to #304 ? I'm getting high scan times (several seconds) for a single code and it has to do with the camera autofocus. Using a Samsung J7 with 6.0.

@eligiobz it is kinda same, but I am not sure. Actually I do not work on this now and all I can say that the issue was related to autofocusing. When I tried to scan QR code, after each successful attempt the app tried to autofocus again, which lead to big delay between each successful scans. But I wanted this app to scan very fast, and wondered why even autofocusing did happen.

@yelnar Are you still working on your project? I found that if I made the scan window a little smaller and set the focus mode to MACRO I get faster scans, it helps if what you're scanning is still.

// Camera settings
settings = new CameraSettings();
settings.setFocusMode(CameraSettings.FocusMode.MACRO);

//Barcode settings
barcodeView = (DecoratedBarcodeView) findViewById(R.id.barcodePreview);
barcodeView.getBarcodeView().setCameraSettings(settings);
barcodeView.decodeContinuous(callback);

beepManager = new BeepManager(this);

See the discussion in #450.


Webtoon Hatti: Last page issue

Source information
Webtoon hatti
Source language
turkish
Steps to reproduce
lastpage not downloaded
Expected behavior
lastpage not downloaded
Actual behavior
lastpage not downloaded
Mihon/Tachiyomi version
0.15.3
Android version
android 10
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

They deliberately put fake images

Is there anything we can do to solve this or can I do?

Website owner keep changing stuff to mess with mihon and hakuneko. As a user you cant do anything.

I understand thank you for the answer

I couldn't reproduce this problem, perhaps it was solved in #3281

If you encounter this issue again, make a new request & put the names of the entries doing this


Added Google groups restriction feature

Added feature that restricts access to Raneto only to the selected google group.
Useful if you want to limit acceess to your knownledge base only to curated list of members of your organization.
In order to use it, you need to enable AdminSDK access for your Google application, and generate API key, that needs to be pasted in confg file

Very neat. I'll have to do an in-depth analysis/testing on this before merging. Scheduling on calendar for Sept 27th

Alright, I'll merge this to keep things moving because the code looks good and there aren't any breaking changes to the default functionality.
I'm unable to make an internal OAuth app because I'm not a GSuite user and the "public" one wants ToS/PrivacyPolicy + approval from Google.
Are you able to provide access for testing long-term? Whether adding me or keeping an eye on this functionality. I could sign-up for a trial for a few days but it would be a long-term expense. Can another user test this functionality?
Ideas?


Add optional parameter to filter events using minimum duration

Introduces new optional parameter to filter events based on duration.
Additions

New minimum_event_duration option for evaluation_tools.events.event_detection.decomposition methods

Removals

None

Changes

Additional optional parameters and documentation

Testing

Added test_list_events_noise method that simulates and tests a noisy signal

Notes

This is a common post-processing step. These algorithms are prone to false positives

Todos

None

Checklist

[x] PR has an informative and human-readable title
[x] PR is well outlined and documented. See #12 for an example
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (see CONTRIBUTING.md)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
[x] Placeholder code is flagged / future todos are captured in comments
[x] Reviewers requested with the Reviewers tool :arrow_right:

Thanks for the fixes!


Objective-C version of PanModal

@ishall1
`
HWPanModal is used to present controller and drag to dismiss. Similar with iOS13 default present Modal style.
Inspired by PanModal, thanks.
`
我没有说？而且你看过源码吗？我的功能和抄的完全一致吗？

我早都关了，你又何必这么冲呢


[core-https] Port request policies to new pipeline model

This PR covers migrating existing policies that we want to keep over to the new model. It also handles providing a convenience function for making a default pipeline, much as in the previous version, although this is no longer coupled to ServiceClient, as that is being moved out into a new package.
I kept the level of testing about the same as before, so you may notice some parts are better tested than others. Don't worry! More unit tests are on the way in later PRs; I just didn't want to block getting something that could be tested end to end.
The next PR I am going to work on will be extracting serialization and mapping into a new core package.

Did a review with @bterlson earlier, going to check this in when it goes green unless folks have any additional feedback they wish to see addressed. @chradek @jeremymeng ?


txn_types: Add GC fence feild to Write records

Signed-off-by: MyonKeminta<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number:
Adds a gc_fence field to Write records which will be used to resolve the compatibility issue between async commit and gc compaction filter/cdc/tiflash.
What is changed and how it works?
Added a gc_fence field.
Related changes

Check List
Tests

Unit test

Side effects
Release note

No release note.

/merge

/merge

/run-all-tests

/merge


Checkbox dialog: background not dimmed

If I use a config with loading = false, the background behind the checkbox dialog is not dimmed.
Samsung S21 Android 12 device
SDK version 3.3.3

@e271828- should we always dimm background regardless of loading config value? Or should we introduce some extra config to control dimming?

@CAMOBAP we should always dim if the checkbox is visible. We don't want to dim if it's a passive sitekey.
Aside from that, probably letting people control this directly is a good config option to add.


Add test for SQL Server

All of the SQL Server tests have passed against the SQL Server 2014 Express using the ODBC Driver 11 for SQL Server: https://ci.appveyor.com/project/lexicalunit/nanodbc/build/1.0.9/job/r7idvj2etpdb510v


Space in Directory structure breaks checkov scan

Hi Bridgecrew Team,
I'm testing out the chevkov-vscode plugin on a Windows 10 Endpoint with VS Code and using CFNGoat. Checkov throws an exception when using the plugin and its scanning a file that contains a space in the directory structure:

This issue can be fixed by encapsulating the cmdline argument in quotations e.g.
checkov -s --bc-api-key **** --repo-id bridgecrewio/cfngoat -f "c:\Users\XXX XXX\Documents\Bridgecrew\cfngoat\cfngoat.yaml" -o json
Also - any future plans at this point to release an extension for Visual Studio?

I'll sort this one out as just encountered it as well while reviewing checkov.


WFLY-16240 Component Upgrade of Narayana to 5.12.6.Final

https://issues.redhat.com/browse/WFLY-16240
The component upgrade brings some minor updates (mainly testing) and also backs out the native jakarta version of LRA (since quarkus isn't ready for Jakarta just yet).
The release notes are https://issues.redhat.com/secure/ReleaseNote.jspa?projectId=12310200&version=12380127

Thanks @mmusgrov


Add Image compression and an Admin Panel

Image Compression
Add a toggleable setting for image compression for slow networks/
Admin Panel
Add an Admin panel to set everything up. For example port, base URL, accepted file types.

Progress on Image Compression is tracked at #9


Add match_prev_cmd strategy and fix default strategy

Re-raised #129 as requested. There is also a bugfix for the default strategy. Feedback is welcome.

Thanks for this. Looks like good stuff! Will dig in a bit deeper as I have time over the next few days.


ci: test on MacOS

Summary of Changes

Run tests on MacOS.

@Marsmaennchen221 Should we skip the failing tests on MacOS or is there a way to guarantee consistent behavior across platforms?

@lars-reimann do you have a way to create snapshots on macos? Then we could generate snapshots for each os

@lars-reimann do you have a way to create snapshots on macos? Then we could generate snapshots for each os

Only in CI, but that's too cumbersome.

:tada: This PR is included in version 0.24.0 :tada:
The release is available on:

v0.24.0
GitHub release

Your semantic-release bot :package::rocket:


Feature: Define a master file in a project which will always be run instead of other files

From<EMAIL_ADDRESS>on 2013-08-27T08:58:25Z
Feature Request... What is the expected output? What do you see instead? If I press one of the run/debug buttons, I expect that a specific file is run and not the current selected file tab. Perhaps there could be an option to mark a opened file as a master file of the project (perhaps in the context menu of a file tab). This file is then the master file of the project and it will always be run instead of, for instance, another selected file tab which I am working on at the moment. (Comparable to TeXstudio behavior for a master file in a LaTeX project) What version of the product are you using? On what operating system? Spyder 2.2.3
Python 2.7.5 32bits
Qt 4.8.4
PyQt4 (API v1) 4.10.2
Windows 64bit
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1537

From ccordoba12 on 2013-09-04T12:10:28Z
Good suggestion. We'll see what we can do about it.
Labels: -Type-Defect Type-Enh Cat-ProjectExplorer MS-v2.4

+1 on this, I also wanted to report this.
For now I use "Ctrl-F6 - re-run last script" to emulate the desired behaviour.


Bug:"Super Breakout" game select switch missing

The Atari arcade game "Super Breakout" contains 3 different games that the player can select. But in MAME the game select switch seems to be missing, so it only plays "Progressive Breakout" mode.
https://strategywiki.org/wiki/Super_Breakout

For what it is worth, there is a "Machine Configuration" setting in the TAB menu which allows all 3 modes to be selected.

For what it is worth, there is a "Machine Configuration" setting in the TAB menu which allows all 3 modes to be selected.

Thanks, I didn't even check, and neither did the OP.


Throttle update

adds a "throttleValueUpdate" optional binding which will throttle the updates to the ko viewmodel by the number of ms specified in the binding.
This is pulled into the binding instead of just extending the observable because otherwise every keystroke will invoke editor.getContent() which is a non-trivial call and may take a while, depending on the content.
Usage: data-bind="tinymce: val, throttleValueUpdate: 500"
note: this pull request also includes the proposed changes from https://github.com/immense/knockout-tinymce/pull/7 but I wanted to open another pull request since this is an addition to the api.

I don't think this adds any editor.getContent() avoidance after implementing the caching. Care to elaborate on the necessity of this functionality?

The caching takes care of not calling editor.getContent() when a change is inbound from the viewmodel that was just writting to it previously.
This is actually a change in behaviour (and hence optional), that will not update the viewmodel more often than once every x milliseconds specified in the additional handler.


[ Trivial ] Fix Android build error in CIFAR_Classificaiton

Fix build error in CIFAR_Classification Applicatin for android
fix ML_API_COMMON_INCLUDES path
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1471. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1471-202108091956470.061528921127319-0ffa75bd77f4a434cc6744a6e24f07bc4cca0090/.


Set up testing with pytest and integration with Travis CI

First steps toward accomplishing #4. 😄

@vphill @damonkelley @somexpert @jason-ellis @ldko
Would you guys be willing to take a look at branch issue-25 (cb855bb, 10f5f98, and 0cfc1c5)? I've been struggling with this the past week, and I want to make sure the way I'm doing this makes sense.
So, first, I set things up for testing with pytest (cb855bb). To get test databases to generate the way I wanted them to, I had to make some changes to a few underlying configuration-y pieces, most notably my database router (10f5f98). Because of that, and partially to get some practice writing tests, I took the opportunity to write some tests for the router to make sure it behaves and has the effects I want it to (0cfc1c5).
And the tests are where I feel like I need feedback the most. I may have picked a particularly difficult thing to test (or not), but I've literally spent all week going back and forth on what the best way to test this is--and even if tests for routers are really needed.
Here's what I ended up with.
The first couple of test functions are more unit-test-like, as they directly test the routers.SierraRouter methods, passing various parameters and checking results.
The last three test functions are I guess more integration-test-like, as they are testing the effects of the router, and not testing the router directly at all. test_table_in_database checks to make sure that a model's table was generated in the correct database (e.g. the default Django DB or the Sierra DB). test_db_read_routing generates a QuerySet object from a given model class and checks the db attribute to make sure it's reading from the right database. And test_db_write_routing generates and saves a fake model instance using model_mommy and then generates a QuerySet to make sure that object is present in the correct database.
The thing about this that I found difficult is that, when you define a custom router, you're defining a small bit of custom code that's otherwise completely subsumed by framework code. So while writing tests that check to make sure the router's methods return expected results is fairly straightforward, testing to make sure the router has the intended effect is tricky--e.g., isolating the effects of the router from the effects of other pieces of the framework. For at least one thing I wanted to test, I found that I couldn't isolate the router and so didn't write the test. (The comment on the last test.)
It also occurred to me that those last three test functions maybe are getting into "testing the framework" territory and may not really be necessary? As long as the router class returns the results that the framework expects, then the framework should behave as it's supposed to? But then again, I guess I should still test/verify that the results the router class returns are results that have the desired effect in context of the rest of the framework and what I'm trying to accomplish with that router.
I don't know, maybe I'm overthinking all of this. What do you guys think?


Bug Fixes for User Registration and Profile Update Functionality

GSSoC Contributor
I have encountered several bugs in the user registration and profile update functionality of our Express application. Here’s a summary of the identified issues and proposed solutions:
1. User Registration Password Validation:
Issue: The password validation checks are overly restrictive and may prevent valid passwords.
Solution: Adjust the password validation checks to ensure that users can create strong but valid passwords.
2. User Login Validation:
Issue: The user login route doesn't handle incorrect passwords gracefully.
Solution: Ensure that we check for incorrect passwords and return appropriate error messages.
3. Updating User Email:
Issue: The update email route allows updating the email to an empty string without validation.
Solution: Add validation to ensure the new email is not empty and follows a valid format.
4. Profile Photo Update:
Issue: The file upload feature does not handle errors properly.
Solution: Add error handling for file uploads to provide clearer feedback on failures.

Please assign this task to me

you can work on it @chikatlarakesh

Please assign this task to me

@ADeshmukh80 the tasks are assigned on first come first serve basis. kindly find any other issue to work on ;)

completed under #89
hence closing


Add qualitative table

Add a table with qualitative information for frameworks and curves supported by zk-Harness.

#32


Getx Navigation Issue when click on Push Notification in Notification Tray

I am using getx view, getx controller and binding along with Getx material app.  everything is working fine, except , when I click on notification icon, while the app is in foreground , the app showing me , "Null Operator used on a null value ", and then if I lock the device and then unlock , it Show, "A globalkey was used multiple times inside one widget"
first screen appear just after click on notification
My GetxMaterialApp
@override
Widget build(BuildContext context) {
return GetMaterialApp(
themeMode: ThemeMode.system,
theme: MyTheme.lightTheme(context),
darkTheme: MyTheme.darkTheme(context),
initialRoute: AppPages.INITIAL,
getPages: AppPages.routes,
debugShowCheckedModeBanner: false,
);

}

same issue

any updates?


Add a non-default icon to the 'Get Text' function

I think it would be nice to show a monitor (not a PC) as the glyph in the tree.

already done at some point


Support variants that start with numbers

VTK-m has the variant 64bitids, which fails to build under nixpack with:
        376755|     (when (variantMatches spec.variants.ascent_types true && variantMatches spec.variants.64bitids true) "+ascent_types Ascent types requires 32 bit IDs for compatibility")];

Fixed by 8d8a8dc.


Revert "Add introduce about "useBabelrc" and ES import"

Reverts kulshekhar/ts-jest#270

The Test code w/ ES (Webpack 2+) dynamic import section seems unnecessary.  I don't think that's the case. @GeeWee can you confirm one way or another?

Sorry. I must waited for your check.

@morajabi that's ok. Git allows us to rectify these things. Can you make the changes in this PR itself?
This also got me to think whether we should do something like this

I'm on vacation but I'm reasonably sure we do not use babelrc by default

Yes:

When using Babel, ts-jest, by default, doesn't use the .babelrc file.

and this is the section on how to enable it manually.

Looks good for now then. Merging it in


Remove undefined clang-format make rule references

This target does not exist. With current code, we have to commit every
changes before running tests (otherwise it fails with unrelated error)
Change-Id: Iff2d01d8cd71ad5b587ea02d882ce11aa99b2917

cc @aboten

I do not recommend this change. I let the rest of the team decide.

If it's annoying, which I can understand, we'd better do a pre-submit hook in Git instead of removing it.

Discussed irl, clang-format rule was not defined in container image leading me to think it was useless.
I've fixed the setup in #18 (unrelated PR) and will close this one.


Completing schedule has remnants

Describe the bug
Doing a schedule and starting over has remnants from previous schedule
To Reproduce

Do a schedule with a large amount of teams
Do a schedule with less teams

Resolved in v2.0.0


InvalidFieldValue: Field "supported_features" of type tuple[PlayerFeature, ...] ...

What version of Music Assistant has the issue?
2024.1.0b2 (2.0.0b94)
The problem
I can use Music Assistant and it seems to work as it should, but in the logs I have the following error message that keeps appearing. I have no idea what the problem is.
How to reproduce
Play music/radio stations
Relevant log output
Error doing job: Exception in callback Players._handle_event(MassEvent(eve...ra_data': {}}))
Traceback (most recent call last):
File "", line 37, in mashumaro_from_dict
File "/usr/local/lib/python3.12/enum.py", line 744, in call
return cls.new(cls, value)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/enum.py", line 1158, in new
raise ve_exc
ValueError: 'enqueue_next' is not a valid PlayerFeature
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.12/asyncio/events.py", line 84, in _run
self._context.run(self._callback, *self._args)
File "/usr/local/lib/python3.12/site-packages/music_assistant/client/players.py", line 302, in _handle_event
self._players[event.object_id] = Player.from_dict(event.data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 39, in mashumaro_from_dict
mashumaro.exceptions.InvalidFieldValue: Field "supported_features" of type tuple[PlayerFeature, ...] in Player has invalid value ['sync', 'volume_mute', 'volume_set', 'enqueue_next', 'pause']
Additional information
No response
What version of Home Assistant Core are your running
2024.2.2
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi

What players are you using?

Sorry, I had overlooked the notification. The problem has arisen since I started using the Ikea SYMFONISK (Sonos):
https://www.ikea.com/us/en/p/symfonisk-sonos-wifi-bookshelf-speaker-black-smart-gen-2-20506584/

You need to update the server to a newer beta. Looks like you're running into an incompatibility between HA integration and the server.

I have done the update and wanted to test it first before I write that everything is ok. But yesterday the problem no longer occurred, but I wasn't able to test it today. It seems to be solved with the update.  Thank you!


Fix storybook production build?

Our production version of storybook (static page that shows the components and their abilities) isn't working. If we ever need to make it work (it may be a convenient way to document and demonstrate to extension developers what components they can use), we need to fix the production webpack configuration in .storybook/main.ts.
The cost to fix the storybook publication build was too expensive so we decided to create a separate repo that would have all of the components and run storybook. This turned into a research task to understand what options are available for Figma and Storybook integration. Below is the link to the research results:
Figma and Storybook Integration Research
To test the production storybook, follow the steps here: https://storybook.js.org/docs/react/sharing/publish-storybook
Depends on #39

This turned from a programming task to a research task. There are some sample projects linked in the research document:
Figma and Storybook Integration Research


The same NPC can have different voices (inconsistency)

Is there a way I can help with the project so that NPCs maintain the same voice for different texts?
Example: Thrall has a voice when reading the text of QUEST A, but he has another voice when reading the text of QUEST B.

This is a major area currently being focused on via the WIP website DB.


The URI of the POST request is incorrect

http://msdn.microsoft.com/en-us/library/jj839746.aspx
there should be subscription/topic there instead of queue.

@gcheng Thank you for the suggestion.  Since you are a MSFT employee, we ask that you use the GitHub capability to contribute to the article by submitting a change and a pull request through the process.  If you need guidance on how this works, please see the contributors guide here: https://github.com/Azure/azure-content-pr/blob/master/contributor-guide/contributor-guide-index.md


add photos to article from content in Strapi

Depends on #42 being merged first

What's that on the resources page? I will have a look again, but it will be difficult to review this haha

Soooo @QJWork accidentally committed that to main -- i think it might have been fixed now but it wasn't fixed when this branch was created I think. I'll see if I can fix it


Rework Kafka health check in manageiq-messaging-ready

The push/pop approach for Kafka health checks is not ideal because this can lead to timing issues when dealing with multiple consumers (multiple appliances). Therefore using a simple call to retrieve metadata from the Kafka server, this will fail if the server is down which is ideal for a health check
Kafka client connections should be closed to prevent issues with multiple consumers on the same topic

Depends on:

[x] https://github.com/ManageIQ/manageiq-messaging/pull/88
[x] https://github.com/ManageIQ/manageiq/pull/23020
[x] https://github.com/ManageIQ/manageiq-messaging/pull/89

@miq-bot assign @agrare
@miq-bot add_reviewers @agrare
@miq-bot add_label bug

Backported to radjabov in commit 37f57f195b1cfb087a7b816f823cf3a630e09b83.
commit 37f57f195b1cfb087a7b816f823cf3a630e09b83
Author: Adam Grare<EMAIL_ADDRESS>Date:   Fri May 3 16:17:04 2024 -0400

    Merge pull request #384 from nasark/close_kafka_broker_connection

    Rework Kafka health check in manageiq-messaging-ready

    (cherry picked from commit b3a5a1f99dd440ed776e53b4f4ae2e5b34442095)


feat: in MissionRuntime step, auto select the most compatible version

[x] includes tests.

Closes #305

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update pt_BR

Hello there. I just started using nwg-clipman and the brazilian portuguese translation is a bit off. So I made some changes
"Claro" isn't the correct word for the context of this software translation wise, "Limpar", "Zerar" or "Apagar" are more fitting meaning that all them makes sense for emptying the list. Prévia seems also more fitting etc.
On the case of "claro", it can mean bright, of course, transparent, translucent etc. This seems to have been translated by using a tranlation tool/auto-translated.

Thank you. I don't know a word of Portuguese.


Update quickstart-synapse-studio.md

@saveenr : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Can you give an example for cmake correlation_cost in Windows

Thank you for your great work. Can you give an example for make the "tensorflow-recipes/OpticalFlow/user_ops/" on windows 10 platform.

There is a related issue for windows:
https://github.com/PatWie/tensorflow-cmake/issues/31
I will not support windows in this repo. Hopefully, we can find a workaround in the other issue.

Thank you. Can you share the compiled correlation_cost_op.so?

I doubt this would work across different systems. But anyway, here you go:
user_ops.zip


Reduce duplicate string allocation for GC improvements

Motivation
If broker loads 100K topics with replication enabled for them, then we see around 3M of String objects presents into heap. this contribute in gc-pause for brokers. Out of 3M strings, we saw half of them duplicate string which we can reduce.
Modifications
After checking GC roots for duplicate string:

interning replicator strings
cache NamespaceName that keeps duplicate namespace-name

Result
Reduce duplicate string.

retest this please

@rdhabalia It might be worth to just try to have the JVM do that with -XX:+UseStringDeduplication

https://blog.codecentric.de/en/2014/08/string-deduplication-new-feature-java-8-update-20-2/

@rdhabalia The only concern I have around intern() is to whether the Strings are ever deleted from the interned pool. It's not clear from the Javadoc (https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#intern--). Anyway, since it's done on the clusters string, it probably won't matter.

@rdhabalia What about the client version? https://github.com/apache/incubator-pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L118 and https://github.com/apache/incubator-pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java#L89

What about the client version?

Yes, I just targeted the main strings. We can do it for client-version as it will be small set. let me add it,


cartocss: warning suggests marker-type: rectangle but it's not supported

when writing an invalid marker-type, warning suggests marker-type: rectangle but it's not really supported
after discussion with @rochoa this happens because torque do support marker-type: rectangle

we should at least control the literal not appearing in non-torque maps

We are using torque-reference.js from carto for all kind of layers, which is mapnik-reference 2.1.0 + torque extensions.
We need to split both references and upgrade mapnik-reference to 2.3.0, which is the version supported by the backend.


ot3: add gripper test protocols

Adds 4 protocols for science testing w/ gripper:

Bead_Cleanup_OT3_Mag_Plate_w_Mp1000 - successfully analyzes on emulator & ot3, dryrun tested on an EVT OT3
IDT_xGen_EZ_gripper_EDITED - successfully analyzes on emulator & ot3
Quick_Zymo_RNA_Bacteria_OT3_8channel - successfully analyzes when instrument.current_volume, LabwareCore.get_well_grid and LabwareCore.get_parameters are implemented. A PR to add those is in the works. This protocol requires multi-channel pipettes.
HDQ_Cells_gripperOT-3 - is not fully curated and will not be used for EVT testing since it requires a 96-channel pipette

Will be adding further changes (like replacing 20uL tips with 50uL) and any updates from the science team as we test these protocols. Merging these as is for now.


Trace feign clients

Fixes #3

@alesj / @cmoulliard / @objectiser / @jpkrohling / @malafeev could you please review?

@alesj you could chime in here and also #7. Do we want to put these auto-configs into separate artifacts? Is there any benefit as we are not pulling in all artifacts which we instrument.

I will let Ales to review what you did which is I think excellent. Question : As we plan to use this project on OpenShift or Kubernetes, we should verify that the Ribbon list of endpoints will be provisioned using : https://github.com/spring-cloud-incubator/spring-cloud-kubernetes/tree/master/spring-cloud-kubernetes-ribbon/src/main/java/org/springframework/cloud/kubernetes/ribbon ?

I will let Ales to review what you did which is I think excellent. Question : As we plan to use this project on OpenShift or Kubernetes, we should verify that the Ribbon list of endpoints will be provisioned using : https://github.com/spring-cloud-incubator/spring-cloud-kubernetes/tree/master/spring-cloud-kubernetes-ribbon/src/main/java/org/springframework/cloud/kubernetes/ribbon ?

I think it's not necessary. it does not affect tracing. It's just a configuration for ribbon (if I get it correctly).

Let's move this forward. I will merge this to establish dependency conventions. If there is something required then comment here and I will submit changes in separate PRs.


update winner's emails and winners section page

Update head of organization and account holder winner's emails.
Add 2017 winnder's section page.

 [QAE16IMP] Prepare the Winners' Resources page for 2017, because it currently just says "TODO!"


WIP epochs.plot_image(gfp=True)

I'm still annoyed by the fact that epochs.plot_image throws so many figures at you.
This allows one to plot the single-trial GFP.

Codecov Report

Merging #4227 into master will increase coverage by 0.01%.
The diff coverage is 89.9%.

@@            Coverage Diff             @@
##           master    #4227      +/-   ##
==========================================
+ Coverage   86.24%   86.25%   +0.01%
==========================================
  Files         357      357
  Lines       64566    64606      +40
  Branches     9831     9837       +6
==========================================
+ Hits        55685    55727      +42
+ Misses       6180     6175       -5
- Partials     2701     2704       +3

What do people think? Do we even want an epochs.plot_image(gfp=True) method?

Also we should have epochs.plot_joint_image() (e.g. erpimage with joint topoplots), and for that we need this anyways.

no objection with the gfp image

Alternative API suggestion, inspired by the tfr.plot_joint API:
epochs.plot_image(aggregate='gfp')
epochs.plot_image(aggregate=np.std)
epochs.plot_image(aggregate=np.mean)
epochs.plot_image(aggregate=np.median)

(vs. epochs.plot_image(gfp=True))
Thoughts?

I like aggregate option - would use it with picks often. I prefer reduction as the kwarg name though (which reminds me of my neglected welch reduction PR :) )

YAGNI? will you really use more than GFP? Now on the positive side and
think it's more explicit than GFP jargon :)

@agramfort I sometimes stuff model fits or similar stuff into mne insts for plotting convenience. If your values are e.g. r or R^2, the std doesn't make so much sense anymore, but maybe the median or some other metric would.
Or what if the data isn't averaged to a common ref anymore, but still on a common scale (e.g. the bipolar stuff)? Essentially a bunch of data transformations might require a different measure.
Not saying it's super important, but it's only like 3 lines of code, 2 lines of doc and 2 lines of test so ...

... any chance of having this one to actually default to gfp=True (or aggregate='gfp') in the future?
Reason: if called without specifying picks, the user gets 5 figures. That's a lot of plots, and the first 5 are usually far from the most important. The GFP is only 1-3 figures, and typically a lot more informative.
I doubt it would hurt any existing pipelines, because these probably don't rely on leaving picks unspecified and we changed the behavior for this case anyways a few releases ago.

@teonbrooks
(This is a very high SNR data set though.)
Actually, "inferno" or 'viridis' look much better than "Reds" for a lot of my tests

Votes on:

defaulting epochs.plot_image to plotting the gfp if no picks are given, yes/no?

having an aggregate param instead of a gfp param, yes/no?

name for the aggregate param? aggregate vs. reduce vs. ..? (In any case, if #4134 is merged first, I will follow its lead!)

I'm for the 1st option in all cases.

giving a try to this PR gives me:
In [2]: epochs.plot_image(gfp=True)
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-2-a38d371c8036> in <module>()
----> 1 epochs.plot_image(gfp=True)

/Users/alex/work/src/mne-python/mne/epochs.py in plot_image(self, picks, sigma, vmin, vmax, colorbar, order, show, units, scalings, cmap, fig, axes, overlay_times, gfp)
   1009                                  show=show, units=units, scalings=scalings,
   1010                                  cmap=cmap, fig=fig, axes=axes,
-> 1011                                  overlay_times=overlay_times, gfp=gfp)
   1012
   1013     @verbose

/Users/alex/work/src/mne-python/mne/viz/epochs.py in plot_epochs_image(epochs, picks, sigma, vmin, vmax, colorbar, order, show, units, scalings, cmap, fig, axes, overlay_times, gfp)
    138             data_ = data[:, picks_, :].std(1)
    139             data_per_type.append(data_)
--> 140             evoked_data = scalings[ch_type] * evoked.data[picks_, :].std(0)
    141             evokeds.append(evoked_data)
    142         data = np.asarray(data_per_type)

IndexError: index 366 is out of bounds for axis 0 with size 366

I just tried
epochs.plot_image(gfp=True)
after running %run plot_visualize_epochs.py

how about a group_by param as we have in raw.plot now?
picks will be used to select what channels to consider and if group_by=None
then show individual channels and if group_by='type' show GFP by channel
type. But we could have group_by='selection'
wdyt?

group_by='selection' would be for interactive mode?

no it would give you the GFP image per selection of channels like raw.plot
does it to make the butterfly rendering by selection

Sorry if misunderstanding conv up to now but was directed here to provide input if possible (and doesn't seem to be in same train of thought? could be wrong)
is it possible to have a: epochs.plot_image(average_over_picks = bool) param where instead of plotting all chans in picks, you plot one image of average voltage/field at all chosen channels? sometimes valuable if looking at broader cortical (e.g. visual) response ?
would require iterating over epochs to calculate evoked for average of channels, then plotting in exact same way as current function?
something like:
e.g. use:
mne.epochs.plot_image(epochs, picks = picks, average_over_picks=True) and do something like this within the function....
n_epochs = np.shape(epochs)[0] # number of epochs in struct
selected = []
for i in range(len(n_epochs)):
    i_evoked = epochs[i].average() #has a shape of [nchans,timesamples]
    picked = i_evoked.data[picks,:] #get data from chosen channels
    chanaverage = np.nanmean(picked,0) #average across chosen channels
    selected.append(chanaverage) #add single epoch data, averaged across chosen chans -> new array

I could be on the wrong path here, but would create new array of single epoch data with only one 'channel' (average of picked channels) which could be stored back as an EpochArray to feed into the original epochs.plot_image code?

	You're essentially asking for the "reduce" or "aggregate" option proposed upthread.

Although usually the GFP is a better measure than the mean for eeg data ...

ah ok, makes sense. mean would keep consistency with other non-python packages like FieldTrip, no? useful if people are working in both alongside each other as a sanity check (this is happening in my lab as a couple of us are trying to move people away from matlab...)

I'm sure if we can convince a few MATLAB users to switch with that, it'll  be possible to implement this :)

@agramfort I finally tried the group_by thing in plot_raw and 1. we should have this for 10/20 data too (it's a predictable mapping from name to ROI) and I'd like to do that eventually, 2. i think that should be parallel to the aggregation.
partially because if you have a ROI-like parameter, grouping by ROI means aggregating via the mean actually makes sense and is very common. E.g.,
evoked.plot_image(group_by=my_ROI_dict, aggregate="mean")
Also you have to admit switching between grouping channels to aggregating over them via the GFP is really overloading the group_by keyword :)

Btw @schekroud don't use this style in Python:
n_epochs = np.shape(epochs)[0] # number of epochs in struct
selected = []
for i in range(len(n_epochs)):
    i_evoked = epochs[i].average() #has a shape of [nchans,timesamples]
    ...
    selected.append(some_function(i_evoked))

Almost always, you can do something like this:
for item in iterable_of_items:
    do_something_with(item)

And usually
collection = [do_something_with(item) for item in iterable_of_items]

That's much more readable!
In this case, I think you want something like:
[evoked.data.mean(0) for evoked in epochs.iter_evoked()]
or just straight-forward
epochs.get_data().mean(1)
This would give you the data averaged over channels.
My idea for this function is to have:
epochs.plot_image(aggregate=agg_kind)
where agg_kind can be False (for current behavior), gfp, or e.g. a function (e.g. np.mean) that will be applied to aggregate over channels.

Also you have to admit switching between grouping channels to aggregating
over them via the GFP is really overloading the group_by keyword :)
what do you mean? I am not sure about the name aggregate but otherwise I
think the API is nice.

You mean you'd be okay with something like:
evoked.plot_image(group_by=my_ROI_dict, reduce="gfp")
evoked.plot_image(group_by='type', reduce=np.mean)
?

yes
but maybe aggregate is better? no strong feeling. I feel that aggregate is
really geeky...

thanks for the tips - only been python-ing for a (relatively) short period so brevity of code is an issue...
maybe grouping_measure is a  better (read: less geeky) term than aggregate?
epochs.plot_image(group_by = ROI_dict, grouping_measure  = 'gfp')
epochs.plot_image(group_by = ROI_dict, grouping_measure = np.mean)

@agramfort I think I'm the only one who prefers aggregate :)
We have mne.combine_evokeds, so combine is another option.
@schekroud grouping_measure is too long IMO and also the wrong term- the grouping separates channels from each other, the aggregation reduces them.

+1 for combine
it also matches the split-apply-combine approach of pandas

My 2c rankings:

aggregate
combine
groupby

we need both group_by and combine

Oh god, we need some consensus here :) So what do we call this param? @jaeilepp maybe you have an opinion?

Ok, then I'll do combine unless anybody has strong objections.

yes but we agree that we need both group_by and combine right?

Should it default to None or to 'type' though? I guess 'type'?

no strong feelings, combine is ok. I'll try to revive my welch-reduction PR in a few days and I'll change reduction to combine then.

I do like "reduce" because it's standard to talk about map-reduce operations, but I think "combine" is more common in MNE so +1 for that from me

I'm working on this again ... next thing I'll do.

Did something very weird. I'll open a new PR.


Add version for mobile

I would like if there could be a version for mobile,so i can work even without the computer.Im on samsung and if you would do that I would be very grateful!

The closest we have right now is https://vscode.dev. We are currently not planning on having a mobile version.

Zen Mode gets us much (maybe most) of the way there fwiw.


ormolu plugin fails to build

In currently latest build efd32ffcfa984a1ad008513e953556755f2839ab the ormolu plugin fails to build. The previous build from 15 October worked fine (thanks) so I can probably get it to work by experimenting with the versions of GHC, stack resolver and Cabal declared at the top of the Dockerfile. However, I am new to Haskell.
Version of Docker is 4.1.1 with Windows 11 and WSL 2
 > [25/28] RUN cabal install ormolu:
#28 3.521 Resolving dependencies...
#28 4.168 Build profile: -w ghc-8.10.7 -O1
#28 4.168 In order, the following will be built (use -v for more details):
#28 4.168  - Cabal-<IP_ADDRESS> (lib) (requires build)
#28 4.168  - Diff-0.4.0 (lib) (requires download & build)
#28 4.168  - ghc-lib-parser-<IP_ADDRESS>11101 (lib) (requires download & build)
#28 4.168  - gitrev-1.3.1 (lib) (requires download & build)
#28 4.168  - ormolu-<IP_ADDRESS> (lib) (requires download & build)
#28 4.168  - ormolu-<IP_ADDRESS> (exe:ormolu) (requires download & build)
#28 4.169 Downloading  gitrev-1.3.1
#28 4.400 Starting     Cabal-<IP_ADDRESS> (lib)
#28 4.817 Downloaded   gitrev-1.3.1
#28 4.817 Downloading  ghc-lib-parser-<IP_ADDRESS>11101
#28 4.822 Starting     gitrev-1.3.1 (lib)
#28 5.494 Building     Cabal-<IP_ADDRESS> (lib)
#28 5.690 Downloaded   ghc-lib-parser-<IP_ADDRESS>11101
#28 5.690 Downloading  Diff-0.4.0
#28 5.953 Starting     ghc-lib-parser-<IP_ADDRESS>11101 (lib)
#28 6.007 Building     gitrev-1.3.1 (lib)
#28 6.347 Downloaded   Diff-0.4.0
#28 6.347 Downloading  ormolu-<IP_ADDRESS>
#28 6.355 Starting     Diff-0.4.0 (lib)
#28 6.857 Downloaded   ormolu-<IP_ADDRESS>
#28 7.158 Building     ghc-lib-parser-<IP_ADDRESS>11101 (lib)
#28 7.239 Installing   gitrev-1.3.1 (lib)
#28 7.593 Building     Diff-0.4.0 (lib)
#28 7.867 Completed    gitrev-1.3.1 (lib)
#28 10.31 Installing   Diff-0.4.0 (lib)
#28 10.90 Completed    Diff-0.4.0 (lib)
#28 279.5 Installing   Cabal-<IP_ADDRESS> (lib)
#28 280.8 Completed    Cabal-<IP_ADDRESS> (lib)
#28 280.9
#28 280.9 Failed to build ghc-lib-parser-<IP_ADDRESS>11101.
#28 280.9 Build log (
#28 280.9 /home/haskeller/.cabal/logs/ghc-8.10.7/ghc-lib-parser-<IP_ADDRESS>11101-7427952d5d66716c4348d5fbe98361103ae308a4934ef5ec6b096d0b96ae9327.log
#28 280.9 ):
#28 280.9 Warning: ghc-lib-parser.cabal:136:5: The field "autogen-modules" is available
#28 280.9 only since the Cabal specification version 2.0. This field will be ignored.
#28 280.9 Warning: ghc-lib-parser.cabal:1:22: Packages with 'cabal-version: 1.12' or
#28 280.9 later should specify a specific version of the Cabal spec of the form
#28 280.9 'cabal-version: x.y'. Use 'cabal-version: 1.22'.
#28 280.9 Configuring library for ghc-lib-parser-<IP_ADDRESS>11101..
#28 280.9 Preprocessing library for ghc-lib-parser-<IP_ADDRESS>11101..
#28 280.9 Building library for ghc-lib-parser-<IP_ADDRESS>11101..
#28 280.9 [  1 of 333] Compiling GHC.BaseDir      ( libraries/ghc-boot/GHC/BaseDir.hs, dist/build/GHC/BaseDir.o, dist/build/GHC/BaseDir.dyn_o )
#28 280.9 [  2 of 333] Compiling GHC.Data.SizedSeq ( libraries/ghc-boot/GHC/Data/SizedSeq.hs, dist/build/GHC/Data/SizedSeq.o, dist/build/GHC/Data/SizedSeq.dyn_o )
#28 280.9 [  3 of 333] Compiling GHC.Exts.Heap.ClosureTypes ( libraries/ghc-heap/GHC/Exts/Heap/ClosureTypes.hs, dist/build/GHC/Exts/Heap/ClosureTypes.o, dist/build/GHC/Exts/Heap/ClosureTypes.dyn_o )
#28 280.9 [  4 of 333] Compiling GHC.Exts.Heap.Constants ( dist/build/GHC/Exts/Heap/Constants.hs, dist/build/GHC/Exts/Heap/Constants.o, dist/build/GHC/Exts/Heap/Constants.dyn_o )
#28 280.9 [  5 of 333] Compiling GHC.Exts.Heap.FFIClosures ( libraries/ghc-heap/GHC/Exts/Heap/FFIClosures.hs, dist/build/GHC/Exts/Heap/FFIClosures.o, dist/build/GHC/Exts/Heap/FFIClosures.dyn_o )
#28 280.9
#28 280.9 libraries/ghc-heap/GHC/Exts/Heap/FFIClosures.hs:45:1: error:
#28 280.9     parse error on input `import'
#28 280.9    |
#28 280.9 45 | import GHC.Exts.Heap.FFIClosures_ProfilingDisabled as Reexport
#28 280.9    | ^^^^^^
#28 280.9 cabal: Failed to build ghc-lib-parser-<IP_ADDRESS>11101 (which is required by
#28 280.9 exe:ormolu from ormolu-<IP_ADDRESS>). See the build log above for details.
#28 280.9
------
executor failed running [/bin/sh -c cabal install ormolu]: exit code: 1
[3084074 ms] Command failed: docker build -f c:\Users\ken_g\tutorials\haskell1\.devcontainer\Dockerfile -t vsc-haskell1-dd26aa4cd8b70001a933c278e2e09d8a c:\Users\ken_g\tutorials\haskell1

Sorry, must've missed it this issue. I'll look into it. Probably need to pin the version compatible with the GHC used.

It should be fixed now, apparently it was some temporary issue with ghc-heap, I will try to not forget and pin packages versions for the given.


Http0.7.0 -> master

This version seems to be working (the examples are), but tests are currently incomplete, and there is lots of debugging code present.
To display  @debug messages, include test/logformat.jl
Plan to continue work and squash before merging this PR, but now is a good time for discussing interface changes.
Locally, this has been partly tested with HTTP 0.7.1.

Coverage decreased (-32.09%) to 63.946% when pulling 070c4f929ad82f7f475e55328be4a0b281960a4b on http0.7.0 into 20bbf25fa1289235d8ead0362cba5b91232119f7 on master.


Excessive and incorrect warn-level logging in plugin response cache

Is your feature request related to a problem? Please describe.
Excessive logging here
          shouldCacheResult({ cacheKey, result }) {
            const shouldCached = options.shouldCacheResult
              ? options.shouldCacheResult({ cacheKey, result })
              : !result.errors?.length;
            if (shouldCached) {
              const extensions = (result.extensions ||= {}) as ResponseCachePluginExtensions;
              const httpExtensions = (extensions.http ||= {});
              const headers = (httpExtensions.headers ||= {});
              headers['ETag'] = cacheKey;
              headers['Last-Modified'] = new Date().toUTCString();
            } else {
              logger.warn('[useResponseCache] Failed to cache due to errors');
            }
            return shouldCached;
          },

Every time a request should not be cached (which can be a user decision via shouldCacheResult) we get a warn log with no information. Not helpful, and why is that even a warning? And it is also incorrect, it is not necessarily due to errors.
And to add further to the case this is not even trying to cache so it is not failing to cache, this is just a function without side effects that returns the decision.
Describe the solution you'd like
I think this logging can either be removed, or demoted to a debug log. And if so, it can be helpful to provide a bit more information. Maybe something like:
logger.debug('[useResponseCache] Will not cache', { errors: result.errors?.length ?? 0, shouldCacheResult: options.shouldCacheResult?({ cacheKey, result }) ?? null });

Describe alternatives you've considered
Not passing the logger to Yoga, but then I miss out on other actual helpful logs.
Additional context

I think the condition of warning needs to be corrected like if(result?.errors?.length)

I edited adding the remark that this is not even trying to cache, it is just doing read only operations to decide wether to cache or not. Now if cache.set actually failed, that is relevant to log (or throw) but that is not what we are looking at here.

If we demot the log to the debug level, I think it's fine if the log appear here even if it's not actually the exact place where the skip is done. The decision of skipping is still there, even if the actual side effect is somewhere else.

Do we even want this log line, could we remove it completely?
I don't think there exist a valid argument to keep it. If someone is relying on logs to trigger alerts, well, then they should think again and add telemetry.

If I understand the conclusion that we:

keep log line
demote to debug
add some extra info

If so, I can start working on a fix in my spare time.

Yes I think this is a good summary :-)

Added 2 PRs, if we can merge envelop first and release a new version of that would be ideal, then I can update the yoga PR to use that package instead


Implement -–pinned–posts

Pinned posts are a channel scoped set of posts.  Ad a method to view and search pinned posts and bookmark the

consolidating https://github.com/jfrerich/mattermost-plugin-bookmarks/issues/81


linalg.logm slower, than naive computation using svd (valid for pos-def only)

It seems the function linalg.logm is significantly slower than a naive way to compute the matrix logarithm using SVD.
If we compute the matrix logarithm of a random positive definite matrix, I see a difference in performance of roughly factor 10 independent of matrix size.
mat = np.random.normal(size=(1000,1000))
mat =<EMAIL_ADDRESS>
U,S,V = np.linalg.svd(mat)
U@np.diag(np.log(S))@V
# takes 302ms on my machine

scipy.linalg.logm(mat)
# takes 2.79s on my machine

logm has to also work for other matrices:
import numpy as np
from scipy.linalg import expm
z = np.triu(np.random.rand(100, 100))
z += np.eye(100)

# Computing via eigenvalue decomposition is unstable
w, v = np.linalg.eig(z)
g = v @ np.diag(np.log(w)) @ np.linalg.inv(v)
print(abs(expm(g) - z).max())
# -> 6.250060342629731e+29

# logm is stable
g = logm(z)
print(abs(expm(g) - z).max())
# -> 1.7763568394002505e-15

Given the speed difference, and the fact that PD is a significant use case, I think adding a flag for PD sounds like a good approach.
However a quick overview of the literature seems to suggest that also for positive definite matrices a Briggs-Padé method is most efficient. As far as I understand this is the type of method used by the current implementation. This makes me wonder just why it is significantly slower than using a spectral method.

The first step in the algorithm is a Schur decomposition. The LAPACK zgees call is already 2x slower than the SVD implementation. The rest is probably slow because there's a nested double pure-Python loop in _sqrtm_triu, which could be moved to Cython to speed all of the dependent algorithms up.

If we take the Schur decomposition of a PD matrix, A=Z T Z^* then T will be diagonal, and the matrix log of T is just the log of the diagonal entries.
I suggest that in linalg._matfuncs_inv_ssq.logm_triu(T) we put a simple check to see if the upper triangular matrix is diagonal, and if so take a shortcut. This is also what is suggested in Higham's book algorithm 9.6 / 11.11
This still leaves the fact that Schur decomposition is slower than SVD, but its a significant improvement,

Probably a good idea, PRs are welcome. For the structure assumption flag, it would probably be best to follow solve with assume='gen'/'sym'/'her'/'pos'.

I went over the code base a bit and there are some low-hanging fruits that we can benefit by vectorizing and more importantly Cythonizing. However, the code is a bit too scattered hence it will take some time to collect the pieces. Thus indeed PR are most welcome in case there are concrete steps. It doesn't have to be a full overhaul but we can improve also incrementally.