session fixation attack

It's possible to do a session fixation attack against a site using passport where you are able to obtain the session ID of a browser session pre-login, allow the user to login, and then use that session ID elsewhere.
Now, this is a somewhat minor issue since assuming there are no other security issues, you would assumingly need physical access to the machine.
Now, with that said, it seems worthwhile to address this issue. The best way to fix this is to simply regenerate the session after the user authenticates, destroying the old one.
However, because of my lack of knowledge on how all the different passport modules interact, I'm not sure where to implement this fix. My initial thought is in req.login.

For anyone stumbling across this trying to avoid a session fixation attack by regenerating session IDs on login, and wondering how to not break passport in the process, this Stack Overflow question was helpful for me: http://stackoverflow.com/questions/22209354/creating-a-new-session-after-authentication-with-passport

@jaredhanson

What you are describing is not a session fixation attack. Assuming an attacker had the ability to observe session IDs being issued by an application, they can also easily observe any newly regenerated session IDs.

The lack of session ID regeneration after login is the base of a session fixation attack.
The attack works by inducing a user to use a sessionID which you are aware of. Note that this does not mean that you can observe all session IDs. Abstract techniques to launch such an attack can be found at @https://www.owasp.org/index.php/Session_fixation .
A simpler but also rarer scenario is the following:
Attacker has temporary physical access to victims browser. The attacker captures the session ID, walks away and waits for the victim to authenticate himself. Provided that the unauthenticated session has not expired on the server-side and that the cookie was nor removed from the browser (e.g. by closing the browser), the attacker will be able to high-jack the session as soon as the victim logs in.
That was a very simplistic example and I acknowledge that if the attacker has physical access, the security of the session is the least of our concerns.

I'd be fine with adding an option to do that to req.logIn.

I believe that this would be a great addition.

Application use case for not regenerating session IDs:

anonymous user begins adding items to a shopping cart
user proceeds to check out
user logs in, in order to select previously registered shipping address

Ideally, just the session ID would be regenerated without loosing all the data that were imported in the session object. I've been trying to customize authenticate() as mentioned at @http://stackoverflow.com/questions/22209354/creating-a-new-session-after-authentication-with-passport but I had little lack transferring the session data.

+1

I think this is an issue.

More detail on session fixation in this research paper: http://www.acrossecurity.com/papers/session_fixation.pdf
Looks like there are many attack vectors besides directly compromising the browser and OWASP states "The session ID regeneration is mandatory to prevent session fixation attacks" (https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Renew_the_Session_ID_After_Any_Privilege_Level_Change)
So if countermeasures can't be implemented directly as part of a "secure by default" strategy, I think they should at least be prominently advised in the documentation. Maybe it's also possible to issue console warnings if the session id is not being regenerated.

The links posted by @eug48 have been moved to a github repo. It is correct that OWASP states this behavior is a vulnerability. A great explanation is available here
I'm hoping that passport will be updated to keep up with current best practices.
@jaredhanson any thoughts on this now that a few years have passed?

@jaredhanson - Any thoughts on re-addressing this given that OWASP treats this behavior as a vulnerability?

+1 🙏

I've changed my earlier assessment on this topic, and released<EMAIL_ADDRESS>which now actively defends against session fixation by regenerating the session.   Read the announcement for more info.   Thanks for the discussion here!

I've recently updated my passport from 0.4.1 to 0.6.0 and kept everything the same.  Now when I make a request, it turns out it's making a new session for every request. So now I can't access data that has already been established at login because essentially I'm getting a new session.  I've gone through the documentation and read Jared's article regarding 0.6.0, the only thing I seem to understand to have the normal behavior I had before the update is to use the keepSessionInfo flag. But it's still not working.
app.use(   session({     secret: process.env.SESSIONSECRET,     name: "id",     resave: false,     saveUninitialized: false,     cookie: {       httpOnly: true,       secure: process.env.NODE_ENV === "production" ? true : false,       sameSite: process.env.NODE_ENV === "production" ? "none" : "strict",       maxAge: 900000,     },     rolling: true,     store: new RedisStore({ client: redisClient}),   }) );


Visualization of torus

Reported by beutlich on 5 Jul 2013 12:50 UTC
Torus.n_ri and Torus.n_ro are labled as number of points around inner or outer radius, respectively. Since in SurfaceCharacteristics.torus the torus is automatically closed (division by (nu-1) and (nv-1)) the first point of each dimension is computed twice. In result you see one point less as actually expected. See screen shot with a low resolution.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1200

Comment by otter on 7 Jul 2013 08:23 UTC
Replying to [ticket:1200 beutlich]:

Torus.n_ri and Torus.n_ro are labled as number of points around inner or outer radius, respectively. Since in SurfaceCharacteristics.torus the torus is automatically closed (division by (nu-1) and (nv-1)) the first point of each dimension is computed twice. In result you see one point less as actually expected. See screen shot with a low resolution.

Fixed in 7b981cb383294a351cdbe32f3bf702b5ae053e4b and 7f6f4e6265410d79725c7e60b77a2af73b29cd10:
If opening angle > 0, the number of points n_ri, n_ro are correct. It makes not much sense to handle the special case of one real value specially. Therefore, just improved the documentation to explain this property:
In the advanced menu the discretization of the surface visualization can be defined by the number of points of the inner radius of the torus (n_ri) and by the number of points of the outer radius of the torus (n_ro). In case the torus is closed (that is, opening = 0 degree), the actual number of points is one less (that is n_ri-1, n_ro-1), because the first and the last point of the parametrization coincide in this case.

Modified by otter on 7 Jul 2013 08:23 UTC


initial work to split rendering from webapi

There are a number of use-cases where it is convenient to
be able to render a chart based on the uri without going
through the webapi. Examples:

Alerting through LWC with a certain buffer for the data
being streamed through. If an alert triggers, then it
is desirable to be able to include context in the email
or other notification. The graph image helps the user
understand why it fired.
Spark queries over the data in S3. We want to be able
to let a user use the exact same graph uri they use for
the main backend and run it on spark.

This is an initial step and we'll try it out a bit to see
what changes make sense. A subset of the tests from the
GraphApiSuite have been moved over. Most of the rest will
follow later on so we can ensure that there isn't anything
being added in the graph layer.

Verified that chart generation for wiki still works as expected.


Updated the golang to 1.22.6 the latest available stable release

What this PR does / why we need it:
The current version of Go used in kapp-controller is golang:1.21.11, which is outdated and no longer aligned with the latest Kubernetes release.
Which issue(s) this PR fixes:

Fixes #https://github.com/carvel-dev/kapp-controller/issues/1617

@yashsingh74 Bumping Go would require bumping some other libraries, including controller-runtime, there is a WIP PR for it, but it might take some time to get that in.


AEROGEAR-8610 sleep for some time let NPM publish be effective

See the history in JIRA: https://issues.jboss.org/browse/AEROGEAR-8610

Verification: https://circleci.com/gh/aerogear/voyager-server/719


session_sticky_hide_cookie  action violate rfc6265

Ⅰ. Issue Description
tengine version: Tengine/2.3.3
Ⅱ. Describe what happened
I configured session_sticky  and session_sticky_hide_cookie , and send a request.
The cookie header in the request sended to upstream may be Cookie:   or Cookie: aaa;
Ⅲ. Describe what you expected to happen
According to RFC6265,
cookie-header = "Cookie:" OWS cookie-string OWS
cookie-string = cookie-pair *( ";" SP cookie-pair )
cookie-pair       = cookie-name "=" cookie-value
So, the cookie header couldnot ended with";" neither just be empty.
Ⅳ. How to reproduce it (as minimally and precisely as possible)

configure a single server ,like
server {
listen      2122 reuseport;
listen      [::]:2122 reuseport;
server_name _;
location / {
session_sticky_hide_cookie  "upstream=test";
proxy_pass                  "http://test";
}

}
upstream "test" {
session_sticky    cookie=test option=indirect maxage=3600;
keepalive         256;
keepalive_timeout 60;
server            <IP_ADDRESS>:80;
}

send a request
see what upstream server get

Ⅴ. Anything else we need to know?

If applicable, add nginx  debug log doc.

Ⅵ. Environment:

Tengine version (use sbin/nginx -V):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Others:

Besides, if i use session_sticky with indirect mode and donot configure session_sticky_hide_cookie. It seems that the session_sticky function cannot work: tengine's response to client wont add set-cookie header.


Cannot navigate between Neovim windows when in tmux session.

Status

Does not work

Navigating between Neovim windows in tmux

Works

Navigating between tmux panes
Navigating between Neovim windows outside of tmux

System

OS: MacOs 15.1.1
Terminal: iTerm2
Tmux: 3.4
Vim: Neovim 0.10.1

Neovim (in tmux)

Plugin manager: Lazy
:TmuxNavigatorProcessList -> Ss+  zsh (qterm)
:! echo $TMUX -> /private/tmp/tmux-502/default,4816,0
:verbose nmap <C-h>

      n  <C-H>       * :<C-U>TmuxNavigateLeft<CR>
        Last set from ~/.local/share/nvim/lazy/vim-tmux-navigator/plugin/tmux_navigator.vim line 19

Neovim (no tmux)

:TmuxNavigatorProcessList -> E 492: Not an editor command
:! echo $TMUX -> empty
:verbose nmap <C-h>

      n  <C-H>       * :<C-U>TmuxNavigateLeft<CR>
        Last set from ~/.local/share/nvim/lazy/vim-tmux-navigator/plugin/tmux_navigator.vim line 19

A couple of things based on what you shared:

The E 492: Not an editor command is due to the lazy config not having 'TmuxNavigatorProcessList' -- I just updated the example config with a fix for that (see this commit).
Your tmux process list does not look to contain any vim process. I'm not sure what to make of that, but that's definitely the issue.

E 492: Not an editor command still persists outside of a tmux session despite the change to Lazy config—the TmuxNavigatorProcessList command does not load, other commands load and work fine. 😕 Said command gets loaded in a tmux session.
I will dig around and report back why no vim process can be seen in my tmux session.

I have a solution to this problem here:
https://github.com/BriHan-Tech/is-vim

Hi @BriHan-Tech,
Excellent, that solved my problem! Thank you very much. Very well documented and explained as well. 🙌


Symbol @ from the scope in package name appears in generated Java files

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?
Yes.
Tell us about the problem
In a nativescript plug-in, if a dependency declares a Java subclass using extend() without passing the fully qualified name, then the generated class name includes the scope of the dependant package, including the @ symbol.
This Java class cannot be compile, because @ is an invalid symbol.
Please provide the following version numbers that your issue occurs with:
tns --version:
3.4.1

    "tns-android": {
      "version": "3.4.1"
    }

Did the error happen while the app was being constructed? (buildtime error)
The main error is below.

Please tell us how to recreate the issue in as much detail as possible.
While developing two separate nativescript plug-ins, I included one of the following nativescript plugins as dependencies.
https://github.com/NathanaelA/NativeScript-Websockets
https://github.com/shripalsoni04/nativescript-webview-interface
Because the npm scope in the package name of my plugins is set to the company name, both plugins will not compile as-is. I confirmed that assigning a valid fully qualified name in the call to extends in a company fork of NativeScript-Websockets. I rediscovered this problem with extends in the second nativescript plug-in when a colleague handed over the unfinished plugin and I set the scope in the package name.
Unfortunately, I cannot reproduce this bug in a clean template. I tried putting starting a new plugin from a template, but something is causing a different behaviour in the build. The file platforms/android/build-tools/android-static-binding-generator/bindings.txt has the entries:
com.shripalsoni.natiescriptwebviewinterface.WebViewInterface*_ftns_modules_@example_nativescript_extend_breaks_java_compiler_node_modules_nativescript_webview_interface_index_l10_c96__*onWebViewEvent***
common.WebViewInterface*_frnal_ts_helpers_l58_c38__WebViewInterface*_initWebView,_setAndroidWebViewSettings,_executeJS***

but no such Java classes were produced. You can find the project here:
https://github.com/Adelrisk/nativescript-extend_breaks_compiler

@Adelrisk
I confirmed that assigning a valid fully qualified name in the call to extends in a company fork of NativeScript-Websockets.
Please elaborate on this.
We don't support skoped dependencies as nativescript plugins yet.

@Plamen5kov

We don't support skoped dependencies as nativescript plugins yet.

That is a pity, I didn't realize this lack of support. Would this and other exceptions be documented somewhere?
Does this statement also hold for scoped apps?

I confirmed that assigning a valid fully qualified name in the call to extends in a company fork of NativeScript-Websockets.
Please elaborate on this.

The situation again in brief: my scoped package is dependant on a third-party plugin (NativeScript-Websockets) that declares a Java subclass through the extend() method, and this extend call does not pass in a qualifying name.
To elaborate on the above statement, I theorized that passing a qualified name would fix this problem. So, after forking the project NativeScript-Websockets, patching in a qualified name and publishing to a company registry so that I could cleanly install and test this configuration, I confirmed my theory. The combination of my scoped plugin and the 'unnamed' subclass broke the build process, resulting in the generation of invalid Java.

@Adelrisk you're the first one using {N} plugins as scoped dependencies. We haven't thought about {N} dependencies as scoped ones, simply because there has been no need for that up to now. But if more people start creating "scoped {N} plugins" we might adopt it as a feature.
I theorized that passing a qualified name...
A qualified name of a plugin, class, method?

I theorized that passing a qualified name...
A qualified name of a plugin, class, method?

Sorry, I guess showing is easier than telling:
https://github.com/NathanaelA/nativescript-websockets/blob/master/src/websockets.android.js#L78
https://github.com/shripalsoni04/nativescript-webview-interface/blob/master/index.android.js#L10
org.java_websocket.client.WebSocketClient and com.shripalsoni.natiescriptwebviewinterface.WebViewInterface are two Java classes. In the Javascript code, subclasses are declared using the extend method, as defined here:
https://docs.nativescript.org/runtimes/android/generator/extend-class-interface
If the first parameter is a string, then this string defines the fully qualified name of the generated Java class. Without it, the generator obviously uses the package name as a source of "uniqueness" or identification and makes the mistake of using the '@' symbol from the scope, generating a class like this:
./platforms/android/app/src/main/java/com/tns/gen/com/shripalsoni/natiescriptwebviewinterface/WebViewInterface_ftns_modules__companyname_nativescript_restpackagename_node_modules_nativescript_webview_interface_index_l10_c96__.java
package com.tns.gen.com.shripalsoni.natiescriptwebviewinterface;

public class WebViewInterface_ftns_modules_@companyname_restpackagename_node_modules_nativescript_webview_interface_index_l10_c96__ extends com.shripalsoni.natiescriptwebviewinterface.WebViewInterface implements com.tns.NativeScriptHashCodeProvider {
        public WebViewInterface_ftns_modules_@companyname_restpackagename_node_modules_nativescript_webview_interface_index_l10_c96__(java.lang.String param_0){
                super(param_0);
                com.tns.Runtime.initInstance(this);
        }

        public void onWebViewEvent(java.lang.String param_0, java.lang.String param_1, java.lang.String param_2)  {
                java.lang.Object[] args = new java.lang.Object[3];
                args[0] = param_0;
                args[1] = param_1;
                args[2] = param_2;
                com.tns.Runtime.callJSMethod(this, "onWebViewEvent", void.class, args);
        }

        public boolean equals__super(java.lang.Object other) {
                return super.equals(other);
        }

        public int hashCode__super() {
                return super.hashCode();
        }

}

@Plamen5kov

Adelrisk you're the first one using {N} plugins as scoped dependencies. We haven't thought about {N} dependencies as scoped ones, simply because there has been no need for that up to now. But if more people start creating "scoped {N} plugins" we might adopt it as a feature.

Just so you are aware there are already 15 published SCOPED plugins from 12 different companies.    This is going to become a lot more prevalent...
And shouldn't it be trivial to add a regex that strips everything except a-z, 0-9, and _ which would fix this issue (And other characters) in the java generation...   Or am I missing something?
@Adelrisk - Please feel free to post a pull request on my https://github.com/Nathanaela/nativescript-websockets for whatever feature/fix you are doing...     I love them, and then you can at least eliminate one of your scoped package issues....  :grinning:

@Plamen5kov
Thank you for your words. I appreciate your works (not just the one plugin!), and now also that you voiced my thoughts.

Just so you are aware there are already 15 published SCOPED plugins from 12 different companies. This is going to become a lot more prevalent...

I have yet to test if an app will break the same way too. I did not receive clarification about this.

And shouldn't it be trivial to add a regex that strips everything except a-z, 0-9, and _ which would fix this issue (And other characters) in the java generation... Or am I missing something?

My suspicions exactly. I would check it myself, if I knew where to start. It can't be too bad - the filepath is obviously created similarly, but is sanitized differently/correctly.

@Adelrisk

I have yet to test if an app will break the same way too. I did not receive clarification about this.

I suspect this will only occur if the plugin needs to generate some specific java for it (probably the main case is the .extend call).    I know  3 or 4 of those scoped plugins are in the nstudio namespace; so I'm sure I would have heard if they were causing problems, so I don't believe it is all scoped plugins...

@NathanaelA
And shouldn't it be trivial to add a regex that strips everything except a-z, 0-9, and _ which would fix this issue (And other characters) in the java generation... Or am I missing something?
Unfortunately, it's not that simple, but once we know that there's such demand, we'll think about a solution.

@Plamen5kov -
I was really hoping that it was a trivial fix...  Rats...  NPM has recommended going to scopes for a while now.
I can also tell you demand is increasing drastically; I know all our future nStudio plugins -- (which the devs of nStudio accounts for currently around 15% of the entire plugin ecosystems plugins, last time I looked) which means that the demand is their just from nStudio alone.   ;-)
So if 1/7 of all the new plugins continue to be done by nStudio devs, we (nStudio) are going to run into it way sooner rather than later.   And at that point we would need to have it fixed as everything is now going under the @nstudio namespace.      So, is that enough demand for you.  :grinning:

@Adelrisk, with the changes in the static binding generator in 4.0.0 this issue seem to be resolved. I am no longer able to reproduce it with<EMAIL_ADDRESS>The @ no longer appears in generated class names and the application compiles successfully.
Could you please confirm that?

@darind I no longer produce the bug after switching back to the original packages. I updated the app and various of plugins to nativescript 4.0.0 for this, and it all seems to still work, so thanks for your efforts! :+1:

@Adelrisk, thanks for confirming those observations.


Injection script should be able to reuse local iso

currently if you have the iso already downloaded in the same dir, it will refuse to inject the file. It should be safe to reuse the same iso over and over to inject the registration file.
$ .github/elemental-iso-add-registration initial-registration.yaml
Pulling artifacts from isv:Rancher:Elemental:Stable OBS project
Error: /home/itxaka/projects/elemental/elemental-teal.x86_64.iso already exists, aborting

This is already supported, elemental-iso-add-registration only downloads the iso if you don't provide one. If the ISO is explicitly provided as the second argument it is not downloaded.


Upload empty docker archive with metadata

CLOUDBLD-7354
Signed-off-by: Ladislav Kolacek<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Readme looks good to me now

@lkolacek code looks good to me, I would add the jira issue to the commit message though

code looks good, needs UT

PR checks failed due to pulling Fedora:35 image. Unrelated to code changes.


STO: Document Policy Failure Ingestion

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66e71cf539d3a124edc592be--harness-developer.netlify.app

We should do the same for AquaSecurity too. It should be placed in the same place as these are.
Done, added those changes.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66ea7e84df191b26c3c179bb--harness-developer.netlify.app


AndroidX support

Have you any plans to move to androidx library?
Also have you any plans to publish new release with fixes? Latest release has some critical issues like issue #185

The switch to Android X was made in https://github.com/evrencoskun/TableView/pull/236, but is not yet released.

@MGaetan89 What is the timeline for that release? Also, can anyone publish an alpha version at least in the meantime

I'm just contributing to this project, not maintaining it.
@evrencoskun is taking care of some personal business and will update the lib as soons as he can work on it (https://github.com/evrencoskun/TableView/pull/251#issuecomment-545154539).

Hi @wadealer. v0.8.9 has been updated to use AndroidX. Can you close this issue if it works fine for you?


Music Cog is Essentially Broken

The music commands technically work, but there seem to be a lot of issues.  The primary issue(s) at this point are:

Can't seem to get the queue to work as expected (this seems to be because there's no way to asynchronously play one track after the next without stopping the stream).  However, there may well be a much easier fix for this that I'm not aware of.
At this time, the stream function only seems to work with an exact URL -- ideally, I'd like it to also be able to search YouTube and play the video whose title most closely matches the search string.
Ultimately it would probably be good to rename most (all?) of the commands to avoid confusion: should "stream" really be the "play" function? And "play" is really more like "resume"...

Queue seems to work with the latest release. #147
Still some minor issues, but at least the thing works (somewhat) now.


which license statement is correct?

the License file states "all rights reserved", but the project is registered as BSD:

which is the case?

cc-ing @heuer and all other contributors:
@marcobiscaro2112 @svanheulen @luzfcb @menglewis @broamski @zhicheng
cheers, Mario

The "all rights reserved" is in reference to the copyright, not the license.

I'm not sure I follow this. the License file in the root directory does not make any explicit reference to BSD. it does state this "https://en.wikipedia.org/wiki/All_rights_reserved".

I'm sorry, the text is the BSD-3
https://en.wikipedia.org/wiki/BSD_licenses#3-clause_license_.28.22BSD_License_<IP_ADDRESS>C_.22Revised_BSD_License.22.2C_.22New_BSD_License.22.2C_or_.22Modified_BSD_License.22.29

Hi Mario,
It's the 3-Clause BSD License, correct.
It's a permissive license so you can use the project in allmost all cases regardless which license your code uses.
Regards,
Lars

from wikipedia


fix(discovery): Revert "improve MQTT discovery for scene CC"

Reverts #3539, fixes #3570.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-1 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 22.082%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/lib/Gateway.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
3763

Relevant Lines:
18119

💛  - Coveralls

cc @kpine


Changed default behavior of DataFrameBuilder to add a gene column

Also added missing allele-counts script

This change is

LGTM % comment

And, to confirm, the extra columns arg is also additional behavior? LGTM


⚠ Bofrost.lu has degraded performance

In e907744, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2824 ms

Resolved: Bofrost.lu performance has improved in 4e066a0 after 27 minutes.


Incorrect perfect fuzz.partial_ratio score

>>> import rapidfuzz
>>> rapidfuzz.__version__
'2.6.0'
>>> begin = 'a' * 24 + 'ba'
>>> end = 'a' * 8 + 'baaab' + 'a' * 8 + 'ba' + 'b' * 10 + 'abbcb'
>>> s1 = begin + 'c' + end
>>> s2 = begin + 'b' + end
>>> rapidfuzz.fuzz.partial_ratio(s1, s2)
100.0
>>> rapidfuzz.fuzz.partial_ratio(s2, s1)
98.46153846153847

fuzz.partial_ratio is supposed to be commutative and return a perfect score of 100.0 if and only if one string is a substring of the other.

Thanks for reporting. fuzz.partial_ratio is not always commutative right now as described in https://github.com/maxbachmann/RapidFuzz/issues/219. However the particular case you did run into is indeed a bug in the current implementation. This is fixed in https://github.com/maxbachmann/RapidFuzz/commit/b36ec678a96f11205972551956d5965df917aca0. I will release a patch version with the fix later today.


Breaking changes proposal for HTTP API

See document.
Will not merge into master. This is just for reviewing.
Let's have a presentation on Thursday or Friday on these proposals.

Codecov Report

Merging #1522 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1522   +/-   ##
=======================================
  Coverage   98.41%   98.41%
=======================================
  Files          58       58
  Lines        2779     2779
=======================================
  Hits         2735     2735
  Misses         44       44

We were able to reach consensus on the base of this document.
Next steps are to implement the changes agreed on (for core: largely done already) and write up a list of all the breaking changes.
In favor of the list of breaking changes (#1547), I'm closing this PR.


Put KODO doc into the right directory

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4106/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


Great Work

hi,
i really want to congratulate you on this small, but awesome librarary, i already started using it and it is so cool.
could i ask why you push towards IEnumerable instead ot ToList(), is it to make performance better ?
another thing, it would be great if you create a Tree Extension method so we can create tree like structure and add it to this lib
thanks in advanced. and good luck

I won't be implementing this as it is geared toward specific DB usage. This library is only aimed for Linq2Objects.


Locale FR added with it's 3 translations

Just translated 3 strings for the admin

Nice :) thanks


scripts is now an SDK style project as well that is part of the solut…

…ion build

ported to master and 5.x


Remove payload converter

Motivation
Remove payload decoding support (because of new endpoint: nns-dapp/get_proposal_payload)
Changes

removed payload conversion
nnsFunctionName generation was moved to nns-dapp to provide i18n support

@mstrasinskis  Note that at the moment get_endpoint_support() can break the nns-dapp without warning, by filling up memory, so until that is addressed, we cannot use it.


Firefox scroll issue in freemode.

When freemode is enabled scrolling is hard.
Please check the codepen in FF.
http://codepen.io/asim-coder/pen/NGGxKa
Chrome (Version 43.0.2357.81 (64-bit)) - good
FireFox (38.0) - Scrolling is not smooth. Pixels scrolled per event is low.
Other Browsers - Not tested.

What is your OS? Do you see the same behavior at http://www.idangero.us/swiper/demos/32-scroll-container.html? As for me both Chrome and FF are smooth

Ubuntu 14.04.
I see the same behavior  at the link too. Looks like pixels scrolled per mouse event is like 5px.

Please check the video for more information.
http://youtu.be/mujhswpmqu8
-or-
https://drive.google.com/file/d/0B2zWMerQcAOkT0dWQmNtazk2S0E/view?usp=drivesdk
Note: Touch slide is OK in FF. Only mouse scroll having the issue.

Sorry, Swiper doesn't make scrolling "smoother", it is just scroll content on the value received by scroll event. So in your case is more system+browser issue. You can try to tweak this behavior using mousewheelSensitivity  parameter

Thanks for your help.

Thanks for your help. Sorry for the word 'smooth'. I would say different behavior in Ubuntu FF. Let me try mousewheelSensitivity param.

Hi,
I have tested on OS X Yosemite. Firefox version: 39
Scrolling is good, even though chrome has moved more content per event.
And Windows 7, Firefox version 40
scrolling is same as  Ubuntu.
just for your information.

Hi, after some digging I found that the delta value getting from the 'wheel' event (mousewheel.js: line number: 47 - 61) is '3' in Firefox where chrome is giving '120' from the event. This small delta value was causing this problem. So I normalized it using:
if(Math.abs(delta) < 50){
  delta > 0 ? (delta = delta + 120) : (delta = delta - 120);
}

when freeMode is enabled. Is this okay?

I have the same issue. After some digging i found this question and this answer: http://stackoverflow.com/a/30134826

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


TypeError: BaseKITTIDataset.init() got an unexpected keyword argument 'extend_ratio'

First of all, thank you for sharing this repo!
So I'm trying to run the test.py script.
Kitti dataset is downloaded and unzipped, first the color, then velodyne and then calib with overwriting, as described in the Dataset Preparation section.
I've activated my venv envorinment, I then ran the given python test.py ... command and iteratively pip installed everything it said my environment is lacking.
But in the end I get the following error
(venv) nofreewill@nofreesill:~/Documents/CalibNet_pytorch$ python test.py --inner_iter=1 --pretrained=./checkpoint/cam2_oneiter_best.pth --skip_frame=1 --pcd_sample=-1
args have been received, please wait for dataloader...
Traceback (most recent call last):
  File "/home/nofreewill/Documents/HomeOffice/CalibNet_pytorch/test.py", line 95, in <module>
    test_dataset = BaseKITTIDataset(args.dataset_path,args.batch_size,test_split,CONFIG['dataset']['cam_id'],
TypeError: BaseKITTIDataset.__init__() got an unexpected keyword argument 'extend_ratio'

What is happening, what do I do wrong?

First of all, thank you for sharing this repo!
So I'm trying to run the test.py script. Kitti dataset is downloaded and unzipped, first the color, then velodyne and then calib with overwriting, as described in the Dataset Preparation section. I've activated my venv envorinment, I then ran the given python test.py ... command and iteratively pip installed everything it said my environment is lacking. But in the end I get the following error
(venv) nofreewill@nofreesill:~/Documents/CalibNet_pytorch$ python test.py --inner_iter=1 --pretrained=./checkpoint/cam2_oneiter_best.pth --skip_frame=1 --pcd_sample=-1
args have been received, please wait for dataloader...
Traceback (most recent call last):
  File "/home/nofreewill/Documents/HomeOffice/CalibNet_pytorch/test.py", line 95, in <module>
    test_dataset = BaseKITTIDataset(args.dataset_path,args.batch_size,test_split,CONFIG['dataset']['cam_id'],
TypeError: BaseKITTIDataset.__init__() got an unexpected keyword argument 'extend_ratio'

My apologies to forget to update some files. the extend_ratio is an arg to enlarge the FOV of the camera to include more LiDAR points distributed along the image boundaries. I re-uploaded some files, and It would be fixed now. (At least I hope so)

You can reopen this issue if there are still issues.

Oh yeah it's now solved, thank you very much for the quick solution! ^^


yarn + latest wallet selector + latest near-api-js == error

Prerequisites

[X] I'm using the latest version of near-api-js.
[X] I have tried to start with a fresh project and reproduce the defect with minimal code changes.
[ ] I have read the console error messages carefully (if applicable).

Description
Multiple people is reporting that some of our examples have stopped working when using the latest version of near-api-js and wallet-selector.
Reproducible demo
https://github.com/near-examples/guest-book-examples/tree/main/frontend
Steps to reproduce

Fork the repo
use yarn install on the frontend
use yarn dev
try to post a message without attaching NEAR

Expected behavior
A transaction saving the message should be triggered, and thus the message saved
Actual behavior
Unhandled Runtime Error

Error: Expected string not undefined(undefined) at value.signerId
Call Stack
expect_type
node_modules/borsh/lib/cjs/utils.js (34:1)
BorshSerializer.prototype.encode_string
node_modules/borsh/lib/cjs/serialize.js (85:1)
BorshSerializer.prototype.encode_value
node_modules/borsh/lib/cjs/serialize.js (45:1)
BorshSerializer.prototype.encode_struct
node_modules/borsh/lib/cjs/serialize.js (180:1)
BorshSerializer.prototype.encode_value
node_modules/borsh/lib/cjs/serialize.js (61:1)
BorshSerializer.prototype.encode
node_modules/borsh/lib/cjs/serialize.js (37:1)
serialize
node_modules/borsh/lib/cjs/index.js (35:1)
encodeTransaction
node_modules/<EMAIL_ADDRESS>(35:1)
sendTransactionUntil/<
<EMAIL_ADDRESS>(81:1)
__awaiter</<
<EMAIL_ADDRESS>(8:1)
__awaiter<
<EMAIL_ADDRESS>(4:1)
sendTransactionUntil
<EMAIL_ADDRESS>(80:1)
sendTransaction/<
<EMAIL_ADDRESS>(93:1)
__awaiter</<
<EMAIL_ADDRESS>(8:1)
__awaiter<
<EMAIL_ADDRESS>(4:1)
sendTransaction
<EMAIL_ADDRESS>(92:1)
signAndSendTransaction/</result</<
node_modules/<EMAIL_ADDRESS>(89:1)
fulfilled
node_modules/<EMAIL_ADDRESS>(5:43)

Your environment

NEAR JavaScript API version used: 4.0.3
Frontend framework (if applicable): NextJS
Relevant dependencies (if applicable): "@near-wallet-selector/core": "^8.9.11",

Self-service

[ ] I'd be willing to fix this bug myself.

Just to add onto this, the issue is seen only while using yarn, I have not seen it when using npm or pnpm.
Maybe that's a good place to start looking into it.

A potential fix https://t.me/neardev/53025 , the idea is to remove NAJ yarn remove near-api-js and then install it again yarn add<EMAIL_ADDRESS>in wallet-selector project.
Somehow yarn.lock there contains some wrong versions of dependencies this should fix them.
Node v22.5.1
Yarn v1.22.19

Hey guys,
the issue is related to here-wallet because<EMAIL_ADDRESS>use<EMAIL_ADDRESS>I will try to find a solution asap.
Thanks for provided info ... helped me a lot.

few more:

mintbase-wallet use<EMAIL_ADDRESS>near-mobile-wallet use<EMAIL_ADDRESS>who use<EMAIL_ADDRESS>

#1154 fix @peersyst/near-mobile-signer 🚀


How to implement onEndReached ?

When I pass my onScroll event to ScrollViewProps, it overwrites the default onScroll, so scrolling logic stops working

Hi, @bohdan145
Please, try the latest version. I've fixed this in this commit.
Thanks for your comment.

Now it works, thanks @FSPinho

Hello, it doesn't seems to work for me even in the latest version. Could you please explain how to use onEndReached function or extend the readme file?
Thanks.


Make UploadPartResponseUnmarshaller public

It appears that most of the unmarshallers (at least in the S3 client) are public. However, UploadPartResponseUnmarshaller is not. Is there a reason why? Can it be made public?
Expected Behavior
Expect UploadPartResponseUnmarshaller to be publicly accessible.
Current Behavior
UploadPartResponseUnmarshaller is currently internal.
Possible Solution
Currently, I have to work-around this limitation using reflection:
var uploadUnmarshallerType = typeof(UploadPartRequestMarshaller).GetTypeInfo()
  .Assembly.GetType("Amazon.S3.Model.Internal.MarshallTransformations.UploadPartResponseUnmarshaller");
uploadUnmarshaller = (ResponseUnmarshaller)uploadUnmarshallerType.GetRuntimeProperty("Instance").GetValue(null);

Your Environment

AWSSDK.Core version used: 3.3.8
AWSSDK.S3 version used: <IP_ADDRESS>
Operating System and version: Windows, Mac, and Linux
Visual Studio version: VS 2015
Targeted .NET platform: .Net CoreCLR

.NET Core Info

.NET Core version used for development: 1.0.0-preview2-1-003177
.NET Core version installed in the environment where application runs: 1.0.0-preview2-1-003177
Output of dotnet --info:

.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
 Version:            1.0.0-preview2-1-003177
 Commit SHA-1 hash:  a2df9c2576

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

This was an oversight. Every other service's marshallers are generated and public, except S3's, and this is one of the uneven edges. We'll make all the marshallers public.
Out of curiosity, what is your use-case of creating and using the marshaller manually?

I have a custom implementation of IHttpRequestFactory. In my code, I needed to pass some contextual information (mostly tracing) down to the IHttpRequest object. The only way that I could find to do that was through deriving from RequestContext and passing that with the call. Consequently, the only way that I could find to do that was effectively duplicate the logic of UploadPartAsync and InvokeAsync on the S3 client. A bit cumbersome but still glad that the necessary extension points were available to make it happen.

If your goal is to use a custom IHttpRequestFactory instead of the default one, you can achieve it using the following steps. Does this help?

Subclass the AmazonS3Client and override CustomizeRuntimePipeline method.

Replace the default HttpHandler with a custom one. We need to call the base method to retain customizations in the parent class.

protected override void CustomizeRuntimePipeline(RuntimePipeline pipeline)
{
    base.CustomizeRuntimePipeline(pipeline);

    var myHttpRequestFactory = [Initialize your IHttpRequestFactory implementation]
    var myHttpHandler = new Amazon.Runtime.Internal.HttpHandler<System.Net.Http.HttpContent>(
        httpRequestFactory, this);
    pipeline.ReplaceHandler<Amazon.Runtime.Internal.HttpHandler>(myHttpHandler);
}

I already have the custom IHttpRequestFactory wired in. Not sure BeforeRequestEvent would work for my use case since it is a shared S3 client, so call-specific contextual information wouldn't be available in a shared client event handler.

All S3 marshallers have been made public, closing.

And I see that it has already been pushed to nuget, thanks.


Add Turkish translation

Thanks for that! Might be a while before I make a new release though.

OK, thanks for merging.


Improving README with minor fixes

What:

Adding path import to launcher class in README.
process.cpus().length --> os.cpus().lenght

Why:

Examples in document should ideally work off the shelf. The current example launcher errors out as it is unable to load the path module.
cpus() is a function of the os object

Thanks :)


init: add shared target

Signed-off-by: Yuchen Dai<EMAIL_ADDRESS>Extracted from #8523
@mergeconflict mentioned we can also maintain a collection of TargetImpl(and a initialize_ flag, std::once_flag) at the target owner.
I agree it works but a SharedTarget provides stronger cohesion.
Follow up:

update #8523 on top of this PR
complete fuzz test #8714

/assign @htuch

@mergeconflict  Thank you! I am updating the PR

@mergeconflict So the latest tests are
[ RUN      ] Init/TargetImplTest/0.Name
[ RUN      ] Init/TargetImplTest/0.InitializeWhenAvailable
[ RUN      ] Init/TargetImplTest/0.InitializeWhenUnavailable
[ RUN      ] Init/TargetImplTest/0.ReadyWhenWatcherUnavailable
[ RUN      ] Init/TargetImplTest/1.Name
[ RUN      ] Init/TargetImplTest/1.InitializeWhenAvailable
[ RUN      ] Init/TargetImplTest/1.InitializeWhenUnavailable
[ RUN      ] Init/TargetImplTest/1.ReadyWhenWatcherUnavailable
[ RUN      ] SharedTargetImplTest.ReInitializeWhenUnavailable
[ RUN      ] SharedTargetImplTest.NotifyAllWatcherWhenInitialization
[ RUN      ] SharedTargetImplTest.InitializedSharedTargetNotifyWatcherWhenAddedAgain
[ RUN      ] SharedTargetImplTest.EarlySharedTargetReadyNotifyWatchers


Enabled origami_auto_zoom_on_focus - Not Zooming

Maybe I misunderstand how this should be functioning.  Is there a way make hovering change the column sizes?  Id like whichever column I am currently hovering over to stretch to the size specified.

Focus implies that the pane is active, i.e. that you've switched to it. Hovering won't work. Sublime Text gives plugins very little ability to handle anything having to do with the mouse. See https://www.sublimetext.com/forum/viewtopic.php?f=6&t=8381#p40381

Did the above answer your question? Can this issue be closed?

You should specify to set up origami_auto_zoom_on_focus  in the default settings file and not in "origami"'s one


Deleting events having attendees

I am working on a Sabre Caldav with MongoDB as backend and I encounter problem while deleting some events.
When creating an event having attendees, Sabre creates N events in the DB where N is the total number of event participants. And when the event is deleted by the organizer, only one of these event is removed form the DB. And the remaining events are still accessible to other attendees even though the event should have been deleted.
Should I implement the removal of all these events in the \Sabre\CalDAV\Backend\AbstractBackend sublclass or is this part of Sabre Caldav main code (and therefore my code does not trigger it properly) ?

Hi Graham,
You should not. If all works correctly, the remaining events should all have gotten a STATUS:CANCELLED property. This allows the other clients to become aware of the fact that the previous event has been cancelled.
Does this make sense?

Hi Evert and thanks for the quick answer !
It makes sense, and I'll make sure that my client handles well Canceled events.
However it seems to not work everytime. In my case it only works when the event only has 2 attendees (organizer + an other one). When there is more than 2 attendee the STATUS is not updated.
It works very well in a 2 persons event.
Any idea of what my implementation lacks ?

No idea, this sounds like a bug though! It certainly should work...

I am a bit sceptical if this is a bug within sabre/dav, just because you have your backend (mongoDb), so to further debug this, I think it would be good if you could share a bit more information.
Lets start with the first level. Hopefully we don't have to go super deep ;)
Could you share the events in your database, including the state that sort of demonstrates that the STATUS is not correctly set to CANCELLED ? Ideally you would share as many calendarobjects as you can that all have the same UID. There's likely an organizer copy, attendee copies and perhaps also the copies in the various inboxes would be helpful.
Let me know, or let me know if you have an alternative suggestion on how to dive deeper into this issue to find the root cause.
I'm also curious about your implementation of getCalendarObjectByUID(), and if you use shared calendars or not.

I found what my mistake was, the STATUS of the events was CANCELLED but it was not properly shown in my mongo clients and also not properly handled by my code. So in fact there is no  bug.
Thanks a lot for your time and your fast answers

Great to hear!


Fix error handling in GetUsers

A missing return statement caused GetUsers to return missleading results
when the identity backend returned an error.

Worth a changelog or not so much? ;-) in any case, code looks good.

Good point. Added.

:boom: Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...


Update the snapshotter docs to refer to the snapshots package

Update the snapshotter docs to refer to the snapshot package for WithLabels.

Signed-off-by: Eric Hotinger<EMAIL_ADDRESS>

Codecov Report

Merging #3056 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   43.87%   43.87%
=======================================
  Files         102      102
  Lines       10903    10903
=======================================
  Hits         4784     4784
  Misses       5384     5384
  Partials      735      735

Flag
Coverage Δ

#linux
47.48% <ø> (ø)
:arrow_up:

#windows
41.08% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24a743...e13a4b6. Read the comment docs.

LGTM


Tr/static analysis new

PR Type
enhancement, tests, documentation

Description

Implemented FileSummary class to summarize file content using tree-sitter queries.
Added tree-sitter query files for multiple programming languages including C, C++, Java, Python, and more.
Developed tests for the FileSummary class, covering various languages like C++, TypeScript, and Java.
Updated requirements.txt to include new dependencies for tree-sitter and related libraries.
Added documentation credits for query logic adoption from the Aider project.

Changes walkthrough 📝
Relevant filesEnhancement17 files

file_summary.pyImplement FileSummary class for static analysis

pr_agent/static_analysis/src/file_summary.py
Implemented FileSummary class for summarizing file content using tree-sitter queries.  Added methods for query processing and rendering file summaries.  Integrated language detection based on file extension.

+150/-0

tree-sitter-c-tags.scmAdd tree-sitter queries for C language

pr_agent/static_analysis/queries/tree-sitter-c-tags.scm
Added tree-sitter queries for C language.  Defined patterns for class, function, and type definitions.

+9/-0

tree-sitter-c_sharp-tags.scmAdd tree-sitter queries for C# language

pr_agent/static_analysis/queries/tree-sitter-c_sharp-tags.scm
Added tree-sitter queries for C# language.  Defined patterns for class, interface, and method definitions.

+46/-0

tree-sitter-cpp-tags.scmAdd tree-sitter queries for C++ language

pr_agent/static_analysis/queries/tree-sitter-cpp-tags.scm
Added tree-sitter queries for C++ language.  Defined patterns for class, function, and method definitions.

+15/-0

tree-sitter-elisp-tags.scmAdd tree-sitter queries for Emacs Lisp language

pr_agent/static_analysis/queries/tree-sitter-elisp-tags.scm
Added tree-sitter queries for Emacs Lisp language.  Defined patterns for function and macro definitions.

+8/-0

tree-sitter-elixir-tags.scmAdd tree-sitter queries for Elixir language

pr_agent/static_analysis/queries/tree-sitter-elixir-tags.scm
Added tree-sitter queries for Elixir language.  Defined patterns for module, function, and macro definitions.

+54/-0

tree-sitter-elm-tags.scmAdd tree-sitter queries for Elm language

pr_agent/static_analysis/queries/tree-sitter-elm-tags.scm
Added tree-sitter queries for Elm language.  Defined patterns for function and type definitions.

+19/-0

tree-sitter-go-tags.scmAdd tree-sitter queries for Go language

pr_agent/static_analysis/queries/tree-sitter-go-tags.scm
Added tree-sitter queries for Go language.  Defined patterns for function and method definitions.

+30/-0

tree-sitter-java-tags.scmAdd tree-sitter queries for Java language

pr_agent/static_analysis/queries/tree-sitter-java-tags.scm
Added tree-sitter queries for Java language.  Defined patterns for class, method, and interface definitions.

+20/-0

tree-sitter-javascript-tags.scmAdd tree-sitter queries for JavaScript language

pr_agent/static_analysis/queries/tree-sitter-javascript-tags.scm
Added tree-sitter queries for JavaScript language.  Defined patterns for class, function, and method definitions.

+88/-0

tree-sitter-ocaml-tags.scmAdd tree-sitter queries for OCaml language

pr_agent/static_analysis/queries/tree-sitter-ocaml-tags.scm
Added tree-sitter queries for OCaml language.  Defined patterns for module, function, and class definitions.

+115/-0

tree-sitter-php-tags.scmAdd tree-sitter queries for PHP language

pr_agent/static_analysis/queries/tree-sitter-php-tags.scm
Added tree-sitter queries for PHP language.  Defined patterns for class, function, and method definitions.

+26/-0

tree-sitter-python-tags.scmAdd tree-sitter queries for Python language

pr_agent/static_analysis/queries/tree-sitter-python-tags.scm
Added tree-sitter queries for Python language.  Defined patterns for class and function definitions.

+12/-0

tree-sitter-ql-tags.scmAdd tree-sitter queries for QL language

pr_agent/static_analysis/queries/tree-sitter-ql-tags.scm
Added tree-sitter queries for QL language.  Defined patterns for module, class, and predicate definitions.

+26/-0

tree-sitter-ruby-tags.scmAdd tree-sitter queries for Ruby language

pr_agent/static_analysis/queries/tree-sitter-ruby-tags.scm
Added tree-sitter queries for Ruby language.  Defined patterns for method, class, and module definitions.

+64/-0

tree-sitter-rust-tags.scmAdd tree-sitter queries for Rust language

pr_agent/static_analysis/queries/tree-sitter-rust-tags.scm
Added tree-sitter queries for Rust language.  Defined patterns for class, function, and trait definitions.

+60/-0

tree-sitter-typescript-tags.scmAdd tree-sitter queries for TypeScript language

pr_agent/static_analysis/queries/tree-sitter-typescript-tags.scm
Added tree-sitter queries for TypeScript language.  Defined patterns for class, function, and interface definitions.

+41/-0

Tests4 files

test_file_summary.pyAdd tests for FileSummary class functionality

pr_agent/static_analysis/tests/test_file_summary.py
Added tests for FileSummary class.  Included test cases for C++, TypeScript, and Java files.  Validated output against expected summaries.

+43/-0

AES.cppAdd example C++ file for AES encryption

pr_agent/static_analysis/tests/example_files/AES.cpp
Added example C++ file for testing static analysis.  Implemented AES encryption context classes.

+428/-0

calc.javaAdd example Java file for calculator UI

pr_agent/static_analysis/tests/example_files/calc.java
Added example Java file for testing static analysis.  Implemented a simple calculator UI.

+586/-0

match.tsAdd example TypeScript file for pattern matching

pr_agent/static_analysis/tests/example_files/match.ts
Added example TypeScript file for testing static analysis.  Implemented pattern matching functionality.

+138/-0

Documentation1 files

Credits.mdAdd credits for query logic adoption

pr_agent/static_analysis/queries/Credits.md

Added credits for query logic adoption from Aider project.

+5/-0

Dependencies1 files

requirements.txtUpdate requirements with tree-sitter dependencies

requirements.txt

Added new dependencies for tree-sitter and related libraries.

+6/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...


feat: improve prove_finality api

It will be helpful if export the low level api for grandpa.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2382141

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2382156

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2382231

@andresilva Hi, I think adding one more method to FinalityProofProvider is enough.
But I wonder why encode justification twice?

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2387882

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2387878

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2387871

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2387872

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2387873

bot merge


Weird issue

Hey dude when i run this against a users repo i am getting the following despite providing a user token?

looks like these repo's are public but need auth to download which is weird.

umm, thats really odd. I've never seen that error before on Github.

ill try find another repo i can present to you as an example to help debug :)

I am closing this for now because I have not been able to replicate this.


ImportError: cannot import name 'create_tuned_model' from 'genai' in VSCode

Description of the bug:
I want to fine tune "models/gemini-1.5-flash-001-tuning" but i took an ImportError  in VSCode.
!pip install -q -U google-generativeai

import pandas as pd
import time
import seaborn as sns
from genai import create_tuned_model, GenerativeModel

# File path to the dataset
file_path = "datasets/Question-Types.csv"  # Adjust this if needed

# Read the file, skipping the first row
df = pd.read_csv(file_path, header=None, names=["RawData"], skiprows=1)

# Split the data into 'Question' and 'Question Type' columns based on the semicolon delimiter
df[['Question', 'Question Type']] = df['RawData'].str.split(';', n=1, expand=True)

# Drop the original 'RawData' column and inspect the result
df = df.drop(columns=['RawData'])
df.head()

# Use the dataset loaded in the previous step
training_data = df

# Initialize the base model
base_model = "models/gemini-1.5-flash-001-tuning"

# Set up the model tuning
operation = create_tuned_model(
    display_name="increment",
    source_model=base_model,
    epoch_count=20,
    batch_size=4,
    learning_rate=0.001,
    training_data=training_data,
)

# Monitor training status
for status in operation.wait_bar():
    time.sleep(10)

# Retrieve tuning results
result = operation.result()
print(result)

# Plot the loss curve
snapshots = pd.DataFrame(result.tuning_task.snapshots)
sns.lineplot(data=snapshots, x='epoch', y='mean_loss')

# Initialize the tuned model for generation
types2question_model = GenerativeModel(model_name=result.name)
generated_result = types2question_model.generate_content("Negative Factual Information Question")
print(generated_result.text)

csv file: Question-Types.csv
Error Stack:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[46], [line 4](vscode-notebook-cell:?execution_count=46&line=4)
      [2](vscode-notebook-cell:?execution_count=46&line=2) import time
      [3](vscode-notebook-cell:?execution_count=46&line=3) import seaborn as sns
----> [4](vscode-notebook-cell:?execution_count=46&line=4) from genai import create_tuned_model, GenerativeModel
      [6](vscode-notebook-cell:?execution_count=46&line=6) # Use the dataset loaded in the previous step
      [7](vscode-notebook-cell:?execution_count=46&line=7) training_data = df

ImportError: cannot import name 'create_tuned_model' from 'genai' (c:\Users\tokel\OneDrive\Masaüstü\Learnify\.conda\Lib\site-packages\genai\__init__.py)

Actual vs expected behavior:
It must generate a Negative Factual Information Question
Any other information you'd like to share?
System Info

Python 3.10.11
Windows 64bit

genai info:
Name: genai
Version: 2.1.0
Summary: Generative AI for IPython (enhance your code cells)
Home-page:
Author: Kyle Kelley
Author-email<EMAIL_ADDRESS>License: BSD-3-Clause
Location: [c:\users\tokel\appdata\local\packages\pythonsoftwarefoundation.python.3.10_qbz5n2kfra8p0\localcache\local-packages\python310\site-packages](file:///C:/users/tokel/appdata/local/packages/pythonsoftwarefoundation.python.3.10_qbz5n2kfra8p0/localcache/local-packages/python310/site-packages)
Requires: ipython, openai, tabulate, tiktoken
Required-by:

Hi @elifbeyzatok00 ,
The problem is in the import ,  genai is an alias for the google.generativeai  module . it imported like this :
import google.generativeai as genai

You first need to configure the api (Set up authentication)
import os

genai.configure(api_key=os.environ["API_KEY"])

Then you can set up the model tuning:
operation = genai. create_tuned_model(
    display_name="increment",
    source_model=base_model,
    epoch_count=20,
    batch_size=4,
    learning_rate=0.001,
    training_data=training_data,
)

then Initialize the tuned model for generation
types2question_model = genai.GenerativeModel(model_name=result.name)

Take a look at : Gemini API : Fine-tuning tutorial

from genai import create_tuned_model, GenerativeModel

Hi, careful, the package is google.generativeai try:
from google.generativeai import create_tuned_model, GenerativeModel


CoinCbcProblem - clone?

Hello! Quick question: Is there a technical reason that CoinCbcProblem doesn't have a #[derive(Clone)] attribute?
I would like to reuse my existing CoinCbcProblem over many parameters by cloning it and then adding two constraints (from the parameters I'm iterating over). Perhaps there is already a way to do this?

Sorry about opening that here, seems it should have been opened to good_lp.


Issue with Too Many Items in Details Pane Not Fitting

This is probably an edge case, but here goes:
I currently use eMixedNite in grid view with a large Details pane that takes half of my window. This is fine 99% of the time, but for a handful of my games the add-on integration leads to stuff not fitting on the screen.
In this example, I used DuplicateHider to group the entire Hitman World of Assassination trilogy, and I own Hitman 2016 twice, leading to 4 platforms and the completion status going off the screen like so:

Only the flag is now visible.
A similar thing happens if a game has too many links, the links continue off the edge of the details pane, where I can no longer click them.
I don't know what can be done to avoid this, but if I can make a suggestion maybe making additional rows if it would go off the edge?

Fixed in v2.60


Push latest version to Celpa?

The version on Celpa is 20210204.2712 but there are a lot of commits from the next day. Would you mind pushing a new version up? I have been hitting some errors and would like to see if it fixes them before reporting a bug.

Done. We do need more bug tester for this package. Feel free to open new issue if you encountered any.


"Show in Menu Bar" Reactiavtion

I actually don't find a way to reactivate the icon back to menu bar to change some settings. TRex is running but not accessible.

If you launch TRex again, when it's running and not showing the menu bar item, it should open the preferences screen.
If that doesn't work use url-scheme to open preferences trex://showPreferences

Thanks! Works perfect. Didn't found it in the documentation.


Resurrect test-coverage target in Makefile

The test-coverage target in the Makefile used the now-deleted test-all script.

This was done in #6142.

This was done in #6142.


Webcam resolution

Thanks for the work thus far, the feed is incredibly smooth compared to the default gr.image component!
I noticed that I'm able to get 1440x1920 images from my iPhone's back webcam using gr.Image, but am only getting 480x640 using the WebRTC equivalent. Occasionally, the feed automatically drops down to an even lower resolution (around 300+px). Hoping to be able to stream better quality images (for tracking), or at least at a fixed resolution, wonder if you have any ideas/advise?

Dear @freddyaboulton , thanks for the quick update! I just tested it out, but none of the constraints (min resolutions, max resolutions, frame rates) seem to be followed (also tried the simpler "facingMode" option, which ended up not being respected.
Here's the relevant section:

Perhaps on a related note, I seem to be getting these warnings from (I think) ffmpeg, regardless of whether constraints were specified:

I'm testing with an iPhone 15 back camera, and the server with:
aiortc==1.9.0
gradio==5.6.0
gradio_client==1.4.3
gradio_webrtc==0.0.14
If you're able to provide a minimal working example with versions etc, it'll be great for me to test on my end and narrow down the issues!

Hi @kianwei96 - it was a bug on my end. You can now set the constraints like this (as of version 0.0.15). Note the new rtp_params argument which is telling WebRTC to preserve the resolution no matter what. Sometimes it will recale images to maintain a higher framerate.
            image = WebRTC(
                label="Stream", rtc_configuration=rtc_configuration,
                mode="send",
                track_constraints={"width": {"exact": 800},
                                   "height": {"exact": 600},
                                   "aspectRatio": {"exact": 1.33333}
                                   },
                rtp_params={"degradationPreference": "maintain-resolution"}
            )

@freddyaboulton  great! thanks for the quick update, I will test it out soon, looking forward to continuing to build off this component!


Write a Ruby program to check upper case

Description
Write a Ruby program to check upper case
Check if the given character is upper case (A-Z).
Input  : A
Output : Upper Case

How to contribute

Save the solution in CheckUpperCase.rb file
Add CheckUpperCase.rb file in check-upper-case folder

!assign


Should we standardize statuses?

I'm poking around, and I'm seeing statuses like "Running" and "No execution." I'm wondering if you think that some list of valid statuses should be implemented in the schema, or it should be up to the implementation? It seems like something general enough that we could make a specific list, and we could even have a GET /m1/statuses endpoint so the client can know them in advance. E.g.,:
GET /m1/statuses

{"statuses": [{
      "name": "running",
      "description": "The workflow is currently running" ,
    },{
      "name": "pending",
      "description": "The workflow has not started, and is not scheduled." ,
    },{
      "name": "scheduled",
      "description": "The workflow has not started, and is scheduled." ,
    },{
      "name": "error",
      "description": "The workflow exited with an error." ,
    },{
      "name": "completed",
      "description": "The workflow has finished." ,
    },
}

For the above, the minimal recommended would be running, pending, and completed, and others (e.g., scheduled) might be an example of something added for a more complex system. What do you think @fgypas ? What others would there be? Given an error, how does the client see the error message?

I'll include something like this in a PR soon to discuss further!

@vsoch As in most cases, I agree with you. Just one question. When would a workflow take the status scheduled? This would be in cases when the jobs are submitted to a cluster?

Yes exactly! I don't think it applies for panoptes, but you can imagine if there is some kind of scheduler, then there is a difference between pending (not scheduled) and scheduled. Scheduled would be an example of an extra status, right now the default I have are:

completed
running
error
pending

I'll submit this in a PR later today to review!


finish release error (Mac OS)

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] puppy => You're not submitting a puppy. I already have one and he's adorable

What is the current behavior?
Finish release doesn't work

Is this a bug? Sorry about that. If so give me explicit details how to reproduce:
Try to finish a release: I got this error from console:
12:16:20.224: [locapp] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false flow release finish -m "Tagging version 1.52.0" 1.52.0
Fatal: Branch 'release/version' does not exist and is required.

What is the expected behavior?
it'd finish the release

What is the motivation / use case for changing the behavior?
I found that from the cli it works if I put the tag version before the -m
git -c credential.helper= -c core.quotepath=false -c log.showSignature=false flow release finish 1.52.0 -m "Tagging version 1.52.0" works fine

Please tell me about your environment:

Gitflow4idea version: find in IntelliJ settings plugins
0.7.1

Gitflow version: run in terminal >git flow version
1.12.3 (AVH Edition)

IntelliJ Help -> about > click copy icon and paste here. Should look like this:

PhpStorm 2019.3.2
Build #PS-193.6015.48, built on January 22, 2020
Licensed to Sintesia S.r.l. / Marco Stagno
Subscription is active until March 16, 2020
Runtime version: 11.0.5+10-b520.30 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.15.2
GC: ParNew, ConcurrentMarkSweep
Memory: 1981M
Cores: 8
Registry: run.processes.with.pty=TRUE, ide.tooltip.initialDelay=999
Non-Bundled Plugins: Gitflow, org.psliwa.idea.composer, org.sylfra.idea.plugins.linessorter

Other information (e.g. detailed explanation, stacktrace, related issues, suggestions how to fix, links for me to have context words of praises, pictures of puppies (again with the puppy??) )

the problem is also in 'finish hotfix'
git -c credential.helper= -c core.quotepath=false -c log.showSignature=false flow hotfix finish -m "Fix  js increment number" 1.57.0
Fatal: Branch 'hotfix/js' does not exist and is required.

@MarcoStagno just to make sure I understand - in the first case where you tried to finish a feature, what branch were you on?
In the second case, when you tried to finish the hotfix, what branch were you on?
Also - the next time this happens, can you try and run the corresponding command from the console and see if you get the same error?
IE if finish hotfix fails, run something like
git flow hotfix finish -m "my commit message" 1.0.0 and see what output you get
I'm trying to ascertain whether the issue is endemic to the plugin, or something specific with your gitflow/project/system etc

@OpherV in both cases I was in the branch that I was trying to finish; in the first case I was on branch release/1.52.0 and in the second case on hotfix/1.57.0
I already run the same command on console and the error was the same; I had to change it manually (on console) to makes it works
for example from:
git flow hotfix finish -m "my commit message" 1.0.0
to
git flow hotfix finish  1.0.0 -m "my commit message"
thank you for your support!

Oh that is interesting
On the AVH wiki it says that the version param is last, so seems there might be a bug there?

Anyhow I guess I can work around it by flipping the order of the parms. I'll have a look

Hi there,
same problem same solution for me.
Here is the trace in the console:
Switched to a new branch 'release/v3.11.1'
$ git -c credential.helper= -c core.quotepath=false -c log.showSignature=false add --ignore-errors -A -f -- parent/pom.xml
$ git -c credential.helper= -c core.quotepath=false -c log.showSignature=false commit -F /private/var/folders/zs/50_tqfb15xl4m7wlf9dmr0d40000gn/T/git-commit-msg-.txt --
[release/v3.11.1 d073814] release v3.11.1
 1 file changed, 1 insertion(+), 1 deletion(-)
$ git -c credential.helper= -c core.quotepath=false -c log.showSignature=false flow release finish -m "Tagging version v3.11.1" v3.11.1
Fatal: Branch 'release/version' does not exist and is required.

It might come from the git command parser...
The solution was to place the -m "message" after the version number:
$ git -c core.quotepath=false -c log.showSignature=false flow release finish v3.11.1 -m "Tagging version v3.11.1"

So we have a workaround...
Thanks for the plugin!

Fixed in 0.7.2


Multiple cursors from selection

Add ability to turn selection into multiple cursors. Like in TextMate:

Select all the lines you want to edit. Turn it into a column selection ( ⌥ ).

Does the Main Menu Selection/Column Selection Mode do what you want?

Thank you


Can't add script component 'FulldomeCamera' because the script class cannot be found.

I'm using the 2022.2.20f1 version, it showed this error when I tried to attach the FulldomeCamera.cs code to an empty game object as the instruction suggested. Any idea what caused that? Is it a compatibility issue?

Which error?

"Can't add script component 'FulldomeCamera' because the script class cannot be found."

Is there any compile errors on the console?
If there are errors, are them from the plugin or other scritps?
Sometimes one script error can impact other scripts.
But I have not tested the plugin on 2022.2, maybe something changed on Unity and it needs to be adapted

When I imported FulldomeCamera.cs, there were these errors:
Assets/Scripts/FulldomeCamera.cs(146,3): error CS0246: The type or namespace name 'FulldomeGizmo' could not be found (are you missing a using directive or an assembly reference?)

Assets/Scripts/FulldomeCamera.cs(42,4): error CS0246: The type or namespace name 'EnumFlagsAttribute' could not be found (are you missing a using directive or an assembly reference?)

Assets/Scripts/FulldomeCamera.cs(42,4): error CS0246: The type or namespace name 'EnumFlags' could not be found (are you missing a using directive or an assembly reference?)

I see what went wrong. I dragged the whole package into the project and that caused some conflicts. Should only import the FulldomeCamera folder. Now I can attach the script.
Another issue is that after I adjust the dome tilt, it always bounces back to 0. Any idea why?

hmm, no reason comes to mind
I would have to try and see, but I don't really have an Unity test environment here at the moment

The strange thing is that I could move the slider on the Dome Tilt and have it saved, but not typing in the number there (if I typed, it would bounce back to 0).


UAT v0.3.3 | Case Stage Localization in header

Localization of Partially Convicted as 'Case Stage'
Currently reads 'PARTIALLYCONVICTED'
Should read Partially Convicted

Hi @Ramu-kandimalla  @rajeshcherukumalli  Tested in QA, Working fine,

Hi @Ramu-kandimalla @rajeshcherukumalli Tested in UAT env, Working as Expected,
Ref,
https://jam.dev/c/3110b2c6-eeb2-4c22-afe3-bc1cadc77399


Transparent Lobe Pattern in KML

Lobe indicating sector is opaque , it may be made to outlined pattern

I think we can add it as an option

Yes, we need provide option 1.Outline 2.Outline Filled with Colour With 50% Transparency.


[Bug]: Unnecessary warning generated for service-decl resources with non-public symbols

Description
The generated warning is "attempt to expose non-public symbol"

For network interactions and data binding, the shape of the data is enough. The type name is not required.  The type name is an internal representation.
This warning adds unnecessary complexity to the service developer.
Tools like OpenAPI, DocGen should be able to handle this without breaking existing functionalities.

For e.g.: For doc generation, if a type is not public, it can render the shape of the type without exposing the type name.

Remove this warning for service-decl for now.
We should revisit, where should we generate this warning and it will be captured as part of the #30324
Steps to Reproduce
Source code used.
import ballerina/http;
service / on new http:Listener(9090) {
    isolated resource function post hello (@http:Payload Foo foo) returns error?{

    }
}

type Foo record {|
 int x;
 string y;
|};

Affected Version(s)
This is observed in 2202.2.0 2202.2.2, Not in Update 2201.1.1.
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

@KavinduZoysa We need to fix this, where we validate "attempt to expose non-public symbol" warning. Skip this validation for service-decl.

Fixed via #38476

Do this apply to the objects as well?
For example, in a Ballerina GraphQL service, we can return a service type. Currently, we see this warning all the places. Adding more to the complexity, when we mark a service type as a public type, then the resource functions are complaining about isolation since it does not infer the isolated property for public types.


Bump kubernetes to 1.4.5, Bump libvirt fedora virtbox to 24-cloud-base

Fixes: #1953

This change is

Tested on F24 and CentOS7 with Vagrant.

@redhat-k8s-bot test please


assembly.sw module

Despite having the preference of abstracting the users away from direct usage of asm and opcodes some users may desire to do so which means they must read the spec and experiment.
It would be useful to have a module which consists of wrappers for all opcodes.
Each wrapper would document the utility of the opcode and its usage with appropriate documentation standards making it easier to start using the opcodes.
This may require compiler work because having stand alone opcodes (outside of asm blocks) or calling functions inside of asm blocks likely is unsupported at this time.

I don't think this is a good idea for multiple reasons:

having multiple equivalent means of doing the same thing is bad design
wrapping assembly does not remove any of the complexity of having to deal translating values to registers
the standard library should not be this strongly tied in design to a particular virtual machine, implementation and support do require some coupling, but we should avoid it as much as possible so as to retain the ability to support other backends.

A library like that may be a good learning aide but it does not belong in the standard library.


Help needed: How to create index and perform search using it?

I know, that search by _key, or _id is possible. But can I create another index, perhaps, on username field, and get document by that key?

Ok, thanks


Home:  Patient Demographics Query for Mobile, wrong title?

http://build.fhir.org/ig/IHE/ITI.BasicAudit/branches/main/index.html#patient-demographics-query-for-mobile
Title is Patient Demographics Query for Mobile, but should be probably: Basic Audit Log Patterns (BasicAudit) Content Profile
Priority:

Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

same page has word: extream


Add support for milliseconds

This PR adds support for milliseconds, as suggested in https://github.com/Toblerity/Fiona/issues/744
Additionally, the PR refactors test_datetime.py. In contrast to before, the output of drivers that convert date, datetime or time silently to str are not tested anymore. Otherwise, the test would grow immense in size for something we cannot really control.
=> https://github.com/rbuffat/Fiona/blob/917e208aab98b1d3b61a8628b771b241e30f516c/tests/test_datetime.py
On the plus side, the test covers now datetime.* objects.

Coverage remained the same at 83.343% when pulling 11f7b1191c7ae0e6d18a09b0924d3cf2e8f80744 on rbuffat:add_support_for_milliseconds into e1f0e1b20ef39ba368a54fbf3925335b5270e9cd on Toblerity:maint-1.8.

While expanding the date / datetime/ time tests to include more drivers I noticed that it would be advantageous to refactor the checks in collection.py if a driver converts a datetime field type to string and if a driver supports a datetime field type to drvsupport. This allows them to be also used in the tests.

This is probably too much for this PR but somewhat related: some drivers (such as geojson for gdal 1.x or csv) convert date / datetime / time silently to string and do not follow a standard format. As Fiona already parses the datetimes, it would not take much to convert date/datetime/time to string in Fiona using isoformat(). This would ensure a consistent conversion among all drivers.
I created a sample implementation based on this PR: https://github.com/rbuffat/Fiona/compare/add_support_for_milliseconds...rbuffat:test_str_convertion_format
If this is something that should be included in Fiona I can create a separate PR.

@rbuffat I think a function that can take either seconds or microseconds is a little awkward to use. I'd prefer that set_field_datetime and get_field_datetime take float seconds (allowing microseconds) if possible.

@sgillies  I refactored set_field_datetime and get_field_datetime to take seconds as floats instead of seconds and microseconds as ints.
Additionally, I refactored driver_converts_field_type_silently_to_str so that it is possible to test gdals behavior (and thus update the function if gdal behavior changes with future versions).
What is your opinion about using Pythons isoformat to convert date / datetime / time fields to string for drivers that convert these types to string silently?
I'm really not creative with names. driver_converts_field_type_silently_to_str is a horribly wrong function name. If you have any suggestion to rename it I will be gladly in favor.

@rbuffat I think the long name is fine. We could also make it "private" by changing the name to _driver_converts_field_type_silently_to_str.

What is your opinion about using Pythons isoformat to convert date / datetime / time fields to string for drivers that convert these types to string silently?

I think I don't understand the situation well enough to say. Can you show me an example of the formats that these drivers use for datetimes?
So many changes have been made to the tests that I can't be sure how much behavior has changed. Is there any way you can revert the formatting changes?

I modified the tests so that also drivers are tested that convert date / datetime / time to string.
Examples of conversions that are different from the isoformat formatting are the following:

CSV: "2018-03-25T22:49:05" => "2018/03/25 22:49:05"
PCIDSK: "22:49:05" => '0000/00/00 22:49:05'

Manually conversion of the types to string would be quite easy to achieve:
The following code
                    # Add microseconds to seconds
                    ss += ms / 10**6
                    set_field_datetime(cogr_feature, i, y, m, d, hh, mm, ss, 0)

needs to be replaced with:
                if driver_converts_field_type_silently_to_str(collection.driver, schema_type):
                    # GDAL 1.x does not support milliseconds
                    if GDAL_VERSION_NUM < calc_gdal_version_num(2, 0, 0):
                        ms = 0
                    else:
                        # GDAL has only milliseconds precision
                        ms = int(ms / 1000.0) * 1000
                    if schema_type == 'date':
                        d = datetime.date(y, m, d)
                    elif schema_type == 'time':
                        d = datetime.time(hh, mm, ss, ms)
                    else:
                        d = datetime.datetime(y, m, d, hh, mm, ss, ms)

                    value_bytes = d.isoformat().encode(encoding)
                    string_c = value_bytes
                    OGR_F_SetFieldString(cogr_feature, i, string_c)
                else:
                    # Add microseconds to seconds
                    ss += ms / 10**6
                    set_field_datetime(cogr_feature, i, y, m, d, hh, mm, ss, 0)

Additionally, the field type must be overridden to string in WritingSession.
The full difference to the last commit can be seen here: https://github.com/rbuffat/Fiona/compare/add_support_for_milliseconds...rbuffat:add_support_for_milliseconds_convert_to_string
This would ensure that most of the supported drivers use the same format.

@rbuffat I'm a little concerned that changing the date/time formatting for the formats that silently convert to strings might break some assumptions of those drivers. Let's leave that aside for now.

That's fine with me.
I would propose that once you are ok with the changes, I remove the old tests, as well as all tests for drivers converting the types to string. The old tests are covered by the new ones, and as we do not control the conversion, I think there is not much to gain with testing the special formatting of gdal drivers. It is sufficient to test if the field type is converted to string.

Included in https://github.com/Toblerity/Fiona/pull/915

Thanks @rbuffat !


Docker-compose healthcheck expects curl

Affected module
Docker compose sample documents.
Describe the bug
Docker would see the app as unhealthy because the healthcheck uses curl, although is not installed in the docker image.
To Reproduce
docker compose up -d with any of the provided examples.

[ ] Postgres
[ ]  MySQL

Expected behavior
The healthcheck should pass if the instance is healthy.
Version:

OS: All
Python version: all
OpenMetadata version: 1.1.0
OpenMetadata Ingestion package version: all

Additional context
Possible solutions:

Install curl by running apk add curl in the base image
Change the healthcheck to use wget instead

  healthcheck:
    test: [ "CMD", "wget", "-q", "--spider",  "http://localhost:8586/healthcheck" ]

Fixed by https://github.com/open-metadata/OpenMetadata/pull/12550


update: cross-section / segment model

with ref to https://github.com/ufechner7/Tethers.jl/issues/4

update calculation of tether cross-section
changes in chain model

updated version of the segmented based tether model Tether_08.jl is available on https://github.com/johhell/TestTether.jl
new features are:

segmented
air friction of moving segments
boundary condition at the end can be free defined
impact of wind to the tether can be studied (first draft)

I added your commit as Tether_08.jl and fixed issues with the latest version of MTK and use ControlPlots instead of PyPlot. I also fixed most issues of Tether_07.jl. If you have the time, please check if the new version of Tether_07.jl matches your results.


i18n(de): update basics/layouts.mdx

Description (required)

update basics/layouts.mdx

Related issues & labels (optional)

#9240
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

de/basics/layouts.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Adding CLI support

Fixes: #9
Adds CLI support to the package. It can be executed using both:
python -m gtrending

and
gtrending

Tasks

[x] Add code to support command line execution
[ ] Update README
[ ] Add tests

Codecov Report

Merging #55 (1a38b52) into master (04b8188) will decrease coverage by 58.64%.
The diff coverage is 1.28%.

@@             Coverage Diff              @@
##            master      #55       +/-   ##
============================================
- Coverage   100.00%   41.35%   -58.65%
============================================
  Files            2        4        +2
  Lines           56      133       +77
============================================
- Hits            56       55        -1
- Misses           0       78       +78

Flag
Coverage Δ

unittests
41.35% <1.28%> (-58.65%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

gtrending/__main__.py
0.00% <0.00%> (ø)

gtrending/cli.py
0.00% <0.00%> (ø)

gtrending/fetch.py
98.14% <100.00%> (-1.86%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hedyhli I'm done with initial implementation. I've not added tests yet. Please review when you get some time and if everything seems okay I'll work on tests and documentation

Will do.

@hedyhli I've pushed the requested changes with added tests and documentation.
The CI is failing due to https://github.com/hedyhli/gtrending/blob/master/gtrending/fetch.py#L48
I suspect that on the last CI run, gtrending api returned a None value so the line was covered. But now there's no such response from the Api, and the line is not covered.


Enable debuggability by providing function name

Ref https://github.com/alexreardon/tiny-invariant/pull/15

👍


boards: nrf52_bsim: Use simplified nrf_bsim_models

The simplified bsim implementation reuses nrfx directly instead
of using manually modified header files.
It requires nrfx_glue.h to include a header which redefines the defines from nrfx and nRF MDK which are not valid when compiling for simulated hardware.
Signed-off-by: Rubin Gerritsen<EMAIL_ADDRESS>The PR uses the original BabbleSim remote to test that it integrates as expected. See https://github.com/BabbleSim/ext_NRF52_hw_models/pull/13.
Another PR has been created for the zephyr downstream of BabbleSim. Before merging this PR, the manifest file must be updated to use this remote. See https://github.com/zephyrproject-rtos/nrf_hw_models/pull/3
Requires https://github.com/zephyrproject-rtos/hal_nordic/pull/53.

Rebased on master to resolve merge conflict in west.yml

Rebased on master to resolve merge conflict

@anangl , @aescolar . Just rebased this PR on master to trigger CI. I will update west.yml after https://github.com/zephyrproject-rtos/hal_nordic/pull/53 and https://github.com/BabbleSim/ext_NRF52_hw_models/pull/13 have been merged.

@rugeGerritsen Please update :)


Sync up sync-ledger-app

Update icon for Ledger Nano X
Fix aggregate tx parser function

Hi JB, grydz,
Please help to approve this MR - We had fixed bugs for NanoX and bump version 0.0.5
-- Thu Cao

Hi JB, grydz,
Please help to approve this MR - We had fixed bugs for NanoX and bump version 0.0.5
-- Thu Cao

Please remove https://github.com/LedgerHQ/app-symbol/pull/1/commits/a2995d16872dd3a840352a93f46e240f282bf180
App name is definitive

Please remove https://github.com/LedgerHQ/app-symbol/pull/1/commits/a2995d16872dd3a840352a93f46e240f282bf180
App name is definitive


How does this library work?

How does this library work as in what's the technical background behind it and not how you use it?
I'd love to understand how that library works behind the scenes but I'm having some difficulties understanding what's going on in the source code. Can anybody shed a little light on this? 🤗

Sorry, due time constrains, can't participate in generic programming talks. May be, if you ask something more concrete, i could try to explain. Start with reading sources of sync method, those are trivial.

Alright, perfectly understand!
My main question is where do you actually get the information from? From the header of the remote source?

If you ask about remote images - information is taken from remote source. It does not depends on extension, mime type and so on. Downloads stars and is immediately tested by multiple parsers in parallel https://github.com/nodeca/probe-image-size/tree/master/lib/parse_stream.
Each parser needs very few data to decide it it succeeds or fail. So, when each got decision - download is terminated and joined decision is returned.
That's a principal difference with other solutions - no need to load full source into memory.
If you need to understand, what exactly is tested - see sync variant, it does he same, but looks much more simple https://github.com/nodeca/probe-image-size/tree/master/lib/parse_sync

@puzrin ah i see! thank you very much for your explanation!


Add customTitle property

In order to be able to render custom component as title (e.g. images/logos etc.).

Good point! I'll add it asap

@Kureev take a look on this PR - https://github.com/Kureev/react-native-navbar/pull/4 it contains important fix.

Done in 0.2.1


Add a overall files count and uploaded chunk function

I am the maintainer of the Flowupload app for Nextcloud which uses ng-flow extensively. Recently @TessyPowder added two functions to ng-flow which adds a counter for all files and a function to count already uploaded chunks. I would like to bring these changes to upstream so other projects can use them as well and so they are in the right place.
The original PR on my repository can be found here:
https://github.com/e-alfred/flowupload/pull/57

We no longer use ng-flow in flowupload so this Pull Request can be closed without merging.


Old revision tag shown as deployed even after deploying a new revision from the current revision

Description:

Old revision tag shown as deployed even after deploying a new revision from the current revision

My understanding is wrong on how revisioning and deployment work.
Both are two separate things.

Creating a new revision does not mean the new revision will get deployed.
Restoring a new revision does not mean the restored revision will get deployed.
Current deployed revision will be shown under API Gateways.
If you want to change the Deployment in the Gateway, then you need to undeploy the revision from the gateway and select the revision that you want to deploy.
You can check the configurations in each revision in read only mode by selecting the Current API dropdown on the upper right corner.
Restoring the revision makes that Revision equal to the Current API so that you make changes on top of that and create a new revision from it.


Allow containerd config imports

Issue #, if available:
https://github.com/awslabs/amazon-eks-ami/issues/1628
Description of changes:
adding an import path for containerd to read for merging config tomls: https://github.com/containerd/containerd/blob/main/docs/man/containerd-config.toml.5.md#complete-configuration
avoid the need for users to directly edit the containerd config toml.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

/ci

We need a user guide section about this, this should be the preferred way of amending the EKS containerd defaults.

@ndbaker1 do we create the directory? (is /etc/containerd/config.d/ already present on disk)

We need a user guide section about this, this should be the preferred way of amending the EKS containerd defaults on AL2.

updated the user guide 👍 PTAL

do we create the directory?

we weren't, just added this to bootstrap.sh to allow users to assume it exists when piping/writing to it

I changed the base branch to main and this is gonna need a rebase + some TLC. Sorry!

thanks for the reminder! rebased now @cartermckinnon

Could we get an eye on this :smiley: it would be nice to get a release with this fix so that we can resolve upstream issues.

/ci

/ci


Reversing this procedure

It would be helpful to have documentation on how to back out of this procedure.
I.E. how to remove the redirect, then swap the URL back.
Thanks for considering this!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5475fd83-52fa-6d49-d08f-fc75fabee09c
Version Independent ID: 19ede247-e62c-9f1a-700c-4c878fec7f78
Content: Change a site address - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/change-site-address.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

@robertafreese Thanks for submitting feedback. We will consider adding this in the future.