Using initial guess in antsRegistrationSyn.sh

Hello. I am currently trying image registration using antsRegistrationSyn.sh. I made my first try with affine registration using
bash $ANTSPATH/antsRegistrationSyN.sh -d 3 -f reference.nii.gz -m input.nii.gz -t a -o Output

and obtained the files "OutputWarped.nii.gz" and "Output0GenericAffine.mat"
I now would like to register another image (say "input2.nii.gz") to "reference.nii.gz" using "Output0GenericAffine.mat" as initial guess for affine matrix.
How can I do that?
Thanks a lot.

I figured out by myself but I am not sure this is correct. I modified as follow "$ANTSPATH/antsRegistrationSyN.sh" and renamed in "$ANTSPATH/antsRegistrationSyN_init.sh"
from line 256
while getopts "d:f:h:j:m:n:o:p:r:s:t:i:" OPT
  do
  case $OPT in
      h) #help
   Help
   exit 0
   ;;
      d)  # dimensions
   DIM=$OPTARG
   ;;
      f)  # fixed image
   FIXEDIMAGES[${#FIXEDIMAGES[@]}]=$OPTARG
   ;;
      j)  # histogram matching
   USEHISTOGRAMMATCHING=$OPTARG
   ;;
      m)  # moving image
   MOVINGIMAGES[${#MOVINGIMAGES[@]}]=$OPTARG
   ;;
      n)  # number of threads
   NUMBEROFTHREADS=$OPTARG
   ;;
      o) #output name prefix
   OUTPUTNAME=$OPTARG
   ;;
      p)  # precision type
   PRECISIONTYPE=$OPTARG
   ;;
      r)  # cc radius
   CCRADIUS=$OPTARG
   ;;
      s)  # spline distance
   SPLINEDISTANCE=$OPTARG
   ;;
      t)  # transform type
   TRANSFORMTYPE=$OPTARG
   ;;
      i) # initial guessing .mat files
   INIT=$OPTARG
   ;;
     \?) # getopts issues an error message
   echo "$USAGE" >&2
   exit 1
   ;;
  esac
done

and in line 410
RIGIDSTAGE="--initial-moving-transform $INIT [${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1] \
            --transform Rigid[0.1] \
            --metric MI[${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1,32,Regular,0.25] \
            --convergence $RIGIDCONVERGENCE \
            --shrink-factors $RIGIDSHRINKFACTORS \
            --smoothing-sigmas $RIGIDSMOOTHINGSIGMAS"

yes - that is good progress. something like that is correct but you will
have to verify your code yourself.
brian
On Tue, Jan 26, 2016 at 8:22 AM, pog87<EMAIL_ADDRESS>wrote:

I figured out by myself but I am not sure this is correct. I modified as
follow "$ANTSPATH/antsRegistrationSyN.sh" and renamed in
"$ANTSPATH/antsRegistrationSyN_init.sh"
from line 256
while getopts "d:f:h:j:m:n:o:p:r:s:t:i:" OPT
do
case $OPT in
h) #help
Help
exit 0
;;
d)  # dimensions
DIM=$OPTARG
;;
f)  # fixed image
FIXEDIMAGES[${#FIXEDIMAGES[@]}]=$OPTARG
;;
j)  # histogram matching
USEHISTOGRAMMATCHING=$OPTARG
;;
m)  # moving image
MOVINGIMAGES[${#MOVINGIMAGES[@]}]=$OPTARG
;;
n)  # number of threads
NUMBEROFTHREADS=$OPTARG
;;
o) #output name prefix
OUTPUTNAME=$OPTARG
;;
p)  # precision type
PRECISIONTYPE=$OPTARG
;;
r)  # cc radius
CCRADIUS=$OPTARG
;;
s)  # spline distance
SPLINEDISTANCE=$OPTARG
;;
t)  # transform type
TRANSFORMTYPE=$OPTARG
;;
i) # initial guessing .mat files
INIT=$OPTARG
;;
?) # getopts issues an error message
echo "$USAGE" >&2
exit 1
;;
esacdone
and in line 410
RIGIDSTAGE="--initial-moving-transform $INIT [${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1] \            --transform Rigid[0.1] \            --metric MI[${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1,32,Regular,0.25] \            --convergence $RIGIDCONVERGENCE \            --shrink-factors $RIGIDSHRINKFACTORS \            --smoothing-sigmas $RIGIDSMOOTHINGSIGMAS"
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTs/issues/276#issuecomment-175008452.

the code seems fine,
maybe putting in line 410
RIGIDSTAGE="--initial-moving-transform $INIT \
            --transform Rigid[0.1] \
            --metric MI[${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1,32,Regular,0.25] \
            --convergence $RIGIDCONVERGENCE \
            --shrink-factors $RIGIDSHRINKFACTORS \
            --smoothing-sigmas $RIGIDSMOOTHINGSIGMAS"

is better for my purpose.
I am afraid that with this modify the argument "-i" becomes mandatory, so I kept "$ANTSPATH/antsRegistrationSyN.sh" and "$ANTSPATH/antsRegistrationSyN_init.sh" as separate scripts.
Thank you for checking

yes - i think that is a good solution for your case.
brian
On Tue, Jan 26, 2016 at 8:38 AM, pog87<EMAIL_ADDRESS>wrote:

the code seems fine,
maybe putting in line 410
RIGIDSTAGE="--initial-moving-transform $INIT \            --transform Rigid[0.1] \            --metric MI[${FIXEDIMAGES[0]},${MOVINGIMAGES[0]},1,32,Regular,0.25] \            --convergence $RIGIDCONVERGENCE \            --shrink-factors $RIGIDSHRINKFACTORS \            --smoothing-sigmas $RIGIDSMOOTHINGSIGMAS"
is better for my purpose.
I am afraid that with this modify the argument "-i" becomes mandatory, so
I kept "$ANTSPATH/antsRegistrationSyN.sh" and
"$ANTSPATH/antsRegistrationSyN_init.sh" as separate scripts.
Thank you for checking
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTs/issues/276#issuecomment-175016590.


ZTS should not send empty policy data since the client must expand the expiration periodically.

I believe ZTS should not send empty policy data since the client must expand the expiration periodically.
When ZPU receives an empty data, it doesn't update the policy file, nor the expiration.
https://github.com/yahoo/athenz/blob/86165415e025ce5f3c6ba862c04e2cb3c2ec1b53/utils/zpe-updater/zpu_client.go#L90-L93
I think it's ok to send empty policy data with "HTTP/1.1 304 Not Modified" if the zpe client is not checking the expiration of the policy file.
And the current implementation of this open-source seems to not be checking it.
https://github.com/yahoo/athenz/search?utf8=✓&q=DENY_DOMAIN_EXPIRED&type=
However, the previous implementation does so, I think we should keep the backward compatibility.

No, this is not a correct change. ZTS does not need to sign and send back the data every time. There are clients that periodically check for any updates like every minute so we can't sign and return the data every time a request comes in.
It seems to be you're referring to a possibly a wrong logic in zpu in which case that needs to be fixed and not this change in ZTS.

Yes, I understand that we shouldn't sign and return the new data every time a request comes in.
However, some ZPE clients are checking the "expiry" field in the policy file during the authorization process, hence we also must update the policy file's expiration before it really expires.
In order to prevent the policy file from expiration, the only way I could find was to update the entire policy file frequently.
At this point, I also found another obstacle, that there is no way for ZPU to update the policy file's expiration if ZTS sends empty data.
Hence, I figured the only two ways to prevent the unauthorized response from ZPE client are:

To fix ZPE client not to check the policy file's expiration during the authorization check process.
To fix ZTS to send the entire policy data(including expiration) every time so ZPU can update the file.

And, as an open-source, the only option I think we have is the second one.

It is ZPU's responsibility to update the policy before it expires and I believe it does it correctly. Before asking ZTS Server for an update, it checks to see what is the ETag to be sent to the server:
https://github.com/yahoo/athenz/blob/master/utils/zpe-updater/zpu_client.go#L143
The default config expiry check is set to 2 days. So the policy expires in 7 days. Even if zpu is configured to run daily, 2 days before the policy expires, it will send the request to ZTS with no Etag which will cause the full policy file with a new expiration date to be sent back to the client. And this should cause ZPE to reload the file with a new expiration date.
So which part is not working in your enviornment?

Thank you for your prompt reply.
After reading it, I see my concern was for nothing.
Now I know that the default config expiry check is set to 2 days, the only question I have left: Is it intentional for the implementation to lock the config expiry check to 2 days?
https://github.com/yahoo/athenz/blob/master/utils/zpe-updater/zpu_config.go#L125
Since ZPU can be run in any frequency that client configures(crontab or etc.), I thought it would be more useful for the users to be able to configure the frequency of the expiry check.


ALC282 Not working

i have dell inspiron 3521 ALC282 with layout ID 28 & speakers & microphone & line in are not working

here is the info you requested on y

I think you need to contact the people who are good at resource making, maybe check #100 for a hint?

It is starting to mislead the project goals by posting resource issues without the solutions on github. Here we do not help to explore code dumps and are not interested in them. Please avoid creating issues unless you have working resources.
For the aforementioned reason all the unlrelated issues are closed.


Config change safenotes

Can someone help me I am trying to change the config of safenotes but I can't. I have it running on docker. :)

Hi, @svenvanstijn . Can you describe in more detail the issue you are having?


Add uploadId to the log on a successful Initiate MPU

Should target 6.2.5

Fixed by scality/S3#579


Fix some typos in README.md

Just fixing a couple of typos in the readme which I noticed today

Thanks!


GPII-3121: Test CI integration.

See GPII-3121 for details.

Closing this out as we are currently exploring a wider range of options.


refactor: remove named capture groups in parseAssetId regular expression

Description
Non-breaking changes.
This removes the use of named capture groups in parseAssetIdRegExp to maintain compatibility with the Secure ECMAScript runtime.

@pastaghost please fix failing tests

I suspect we can also revert the changes made to ASSET_NAMESPACE_STRINGS since we found the real issue with type narrowing, which was the missing assertIsAssetReference type guard assertion.


ALVR can't connect without wifi turned on

Regression
It says "IP is not specified" even though i don't want wifi to be turned on, and it doesn't connect to ALVR configured with <IP_ADDRESS>
19:57:07.032079201 DEBUG Failed to recive client connection packet. This is normal for USB connection.
Try again

Constantly tries to connect from PC side

It can't actually connect at all, after few tries it once connected with cable, then it time-outed, caused steamvr to lock driver, after restarting it just spammed the same message and never connected
So wired mode might be completely broken

Okay i double-checked on latest master and it does connect with wifi turned on but it's certainly funky, inconsistent
Either way definitely needs some digging on what has changed

Cause: this line https://github.com/alvr-org/ALVR/blob/master/alvr/client_core/src/connection.rs#L139
It breaks out of loop and never gives a chance to connect via direct connection
Moving it after LAN connection still causes to fail loop entirely, because for successful connection it needs to do it twice
Also on a side note, after connection (1-2 sec) it disconnects and then reconnects back quickly

After removing line and playing for a while, it tends to timeout for no reason and if you try to connect again, it will crash steamvr

Is there a working version that can be used meanwhile?

Also on a side note, after connection (1-2 sec) it disconnects and then reconnects back quickly

This is because of xr session reinitialization. And no, to keep this sane we should also reinitialize the connection. This workaround will be removed after we have a 2d connection screen (like visionOS)


Actions you can take section

Description
Addresses: Actions to take section
Update actions you can take in accordance with new mocks / content
Changed
ActionSection to support background images
Testing and Reviewing
Desktop:

Mobile:

Should those files have the yellow on them? I would guess we'd store raw file and have a yellow div overlay

Member

Yeah I just exported them in figma as a group bc I didn't know how to do a partial overlay


add Simplified Chinese translation

Add Chinese translation. I'm not sure how to test it, so I only checked it manually.

Super, it will be available in the beta rolling release soon!


Rework the Response to make the copy optional

The idea behind the design of the Response is that you can build a Response object without having to tie it to the request.
This allows the user to build multiple responses and choose the right one afterwards, makes testing easier because you don't need a mock request, etc.
Therefore the Request object holds ownership of a reader that implements the trait Read and contains the data. When you answer the request, it calls something like std::io::copy(&mut socket, self.data).
I suggest to make things more direct and allow the user to bypass this copy and write directly to the socket. Instead of taking an object that implements Read, the Response would take an object that implements Render:
pub trait Render {
    type Err;
    fn render<W: Write>(&self, &mut W) -> Result<(), Err>;
}

If you call Response::from_file or Response::from_string, tiny-http would build the appropriate object that implements Render and that copies data from the file or string to the socket.
This change is not trivial, as it requires more changes like adding a EqualWriter type, plus the error handling thing needs some thinking.

A with_writer function could also be added:
let response = Response::with_writer(|output| {
                                                               write!(output, "hello world")
                                                           });


Test and Deploy Snapshotter V2 architecture (uniswap v2) to finalise current changes

https://github.com/PowerLoom/pooler/pull/63

Moving couple of iterations ahead in time.


Add Auto-deploy: trailer to merge message

This PR alters Hoff's merge behaviour for PRs approved with the "merge and deploy" command.
When a PR is approved with this command, Hoff will

Always create a merge commit (even for single-commit PRs), and
Set a trailer Auto-deploy: true in this merge commit's message.

The behaviour of the "merge" command is mostly unaffected: Hoff will still merge single-commit PRs by fast-forwarding, but will add a Auto-deploy: false trailer to the merge commit messages created to merge PRs with multiple commits.
Changes in this PR:

Alter Git.tryIntegrate's signature to accept a new boolean flag alwaysMergeCommit, which causes a merge commit to be created even for single-commit PRs.
Alter Logic.tryIntegrate, Logic.ActionFree and Logic.runAction to propagate this new flag.
Alter Logic.tryIntegratePullRequest to add a Auto-deploy: true trailer to the merge commit if "merge and deploy" was used, Auto-deploy: false otherwise.
Alter Logic.tryIntegratePullRequest to set alwaysMergeCommit to True if the "merge and deploy" command was used, False otherwise.
Update tests to adjust to new trailer and trailing newline in messages passed to Git.
Update changelog.

Re-requested review: The ATryIntegrate type you commented on was only used in the tests, I've now also updated the corresponding action type in Logic.

Re-requested review: The ATryIntegrate type you commented on was only used in the tests, I've now also updated the corresponding action type in Logic.

@OpsBotPrime merge

@OpsBotPrime merge

Pull request approved by @maartenberg, rebasing now.

Pull request approved by @maartenberg, rebasing now.

Rebased as e9c16a98b0b86d9513c3e335c484dece123c2c7b, waiting for CI …

Rebased as e9c16a98b0b86d9513c3e335c484dece123c2c7b, waiting for CI …


SynthesizedDeclarations.cs is generated even when it isn't needed

I ran into a similar issue with custom declarations that represent something defined externally and implemented https://github.com/InfectedLibraries/Biohazrd/commit/8531038ef39e617bf95abcf923d3ee65e7e216e8 as a workaround. Ideally we could just detect files with no output automatically and skip writing those files out. However, the output sessions stuff isn't really well-structured for this.
We'd also need to add namespace awareness to the C# code writer (which would be nice for other reasons regardless.)

I ran into a similar issue with custom declarations that represent something defined externally and implemented https://github.com/InfectedLibraries/Biohazrd/commit/8531038ef39e617bf95abcf923d3ee65e7e216e8 as a workaround. Ideally we could just detect files with no output automatically and skip writing those files out. However, the output sessions stuff isn't really well-structured for this.
We'd also need to add namespace awareness to the C# code writer (which would be nice for other reasons regardless.)

This was indirectly fixed by the fix to https://github.com/InfectedLibraries/Biohazrd/issues/146

We'd also need to add namespace awareness to the C# code writer (which would be nice for other reasons regardless.)

This happened in https://github.com/InfectedLibraries/Biohazrd/commit/705834980745ec016e83b7e866cf2e4a458568a4, but the "effectively empty file" check did not. I think I'm at least partially considering that aspect to be a solved problem and will address it if it comes up again.


KeyError in connectionpool?

I'm getting a weird error during this call conn = old_pool.get(block=False) in connectionpool.py:410.
The Error in Sentry is: Queue in get, KeyError: (1, True)
And this is the  traceback, which doesn't make sense, as requests/packages/urllib3/connectionpool.py catches that Empty exception; plus I have no idea what that KeyError is coming from ... any ideas?:
Stacktrace (most recent call last):

  File "pac/business/views.py", line 49, in get_eticket
    response = requests.get(url, timeout=timeout, verify=False)
  File "requests/api.py", line 69, in get
    return request('get', url, params=params, **kwargs)
  File "requests/api.py", line 54, in request
    session.close()
  File "requests/sessions.py", line 649, in close
    v.close()
  File "requests/adapters.py", line 264, in close
    self.poolmanager.clear()
  File "requests/packages/urllib3/poolmanager.py", line 99, in clear
    self.pools.clear()
  File "requests/packages/urllib3/_collections.py", line 93, in clear
    self.dispose_func(value)
  File "requests/packages/urllib3/poolmanager.py", line 65, in <lambda>
    dispose_func=lambda p: p.close())
  File "requests/packages/urllib3/connectionpool.py", line 410, in close
    conn = old_pool.get(block=False)
  File "python2.7/Queue.py", line 165, in get
    raise Empty

@Kronuz What version of requests are you using, please?

Sorry, forgot to say. I'm using v2.8.1, from PyPI.

Are you running Python 3?

Nope, I'm using Python 2.7.11

Ok, so I'm inclined to believe that the traceback you're showing me cannot be right. It just doesn't seem to make any sense at all. Are you able to see this live?

This os the Sentry link:
https://sentry.dubalu.com/pac/finkok/group/7500/

Well, that traceback looks impossible. Short of some insane monkeypatching, I'm not sure how this TB could be right.

Does sentry always elide the full path of things as well? That's just frustrating. The path to an installed version of requests is not the same as the path to Queue.py.

@Kronuz can you give us an idea of what other packages are installed on your system? Something else may be monkey patching the stdlib and causing this issue.

It's Django and many other things. Celery, REST Framework... But searching around there doesn't seem to exist monkey patching of the standard libs. But it's true it seems "impossible"

@Kronuz things like eventlet and gevent may be used in one of your dependencies and they tend to monkey-patch Queue. This is why we asked for your dependencies. Many packages do things without telling the end-user.
Further, it's absolutely bizarre that you're getting a KeyError when the error raised is Queue.Empty.

Yes, it is really weird. And it has happened in our development boxes from time to time as well as in production. I'm not using fervent or eventlet, but I'll try to dig further to see if there's anything else that could be patching Queue.

I got the same traceback, using python 2.7.5.  so I changed into urllib2 to avoid it.
File "Bee.git/src/agent/custom/article_parser.py", line 23, in get_html
r = requests.get(url, timeout=10)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 67, in get
return request('get', url, params=params, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 53, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 350, in exit
self.close()
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 649, in close
v.close()
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 270, in close
self.poolmanager.clear()
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 100, in clear
self.pools.clear()
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/_collections.py", line 94, in clear
self.dispose_func(value)
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 66, in
dispose_func=lambda p: p.close())
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 410, in close
conn = old_pool.get(block=False)
File "/usr/lib64/python2.7/Queue.py", line 165, in get
raise Empty

This traceback remains impossible. Can anyone get a regular reproduction scenario?

if i run the function alone, it works good.
I change the "close" function in connectionpool.py. it seems this code can not  catch Empty.
def close(self):
"""
Close all pooled connections and disable the pool.
"""
# Disable access to the pool
old_pool, self.pool = self.pool, None
    try:
        while True:
            print '-'*10
            conn = old_pool.get(block=False)
            print [conn]
            if conn:
                print conn.__dict__
                conn.close()

    except Empty:
        print 'queue empty!!!!!!!!'
        import traceback
        print traceback.format_exc()
        pass  # Done.

get follow message
[<requests.packages.urllib3.connection.HTTPConnection object at 0x113e390>]
{'_HTTPConnection__state': 'Idle', '_buffer': [], '_tunnel_headers': {}, '_tunnel_host': None, 'sock': <socket._socketobject object at 0x10e8ec0>, 'port': 80, 'strict': True, 'host': 'news.bitauto.com', '_tunnel_port': None, 'timeout': 10, 'socket_options': [(6, 1, 1)], 'source_address': None, '_HTTPConnection__response': <httplib.HTTPResponse instance at 0x1143200>, '_method': 'GET'}
[None]
[None]
[None]
[None]
[None]
[None]
[None]
[None]
[None]
Traceback (most recent call last):
this line didn`t run   print 'queue empty!!!!!!!!'
after i change "except Empty" to "except Exception", the problem does not show ,

@fqroot Are you using gevent or eventlet? Or anything that monkeypatches the Queue module?

I have removed all the code about gevent.

@fqroot So, to be clear, you are not using gevent? Because if anything monkeypatches the Queue module to change its idea of what Empty is then this code is at risk of failing.

@fqroot, I haven't had the chance to try it myself yet, but why don't you catch Exception as exc And then inspect exc to see what the type of it is and where it's source code has been defined.

I have also stumbled upon problems sort of like this one when imports fail at a certain time or during circular imports, which then leave closures with variables pointing to half constructed modules; such objects in turn generally become None and some times become a whole different type object from there on.
This could be the case of Empty in the exc variable in your except Exception as exc. Ceck where the exc object type's code was defined (to see if it was monkey patched) and compare the exc type's id() against Empty to see if it's any different, or even None and please comment about your findings

@Kronuz OK, I will debug it tommrow.  maybe there is a relationship with the module "importlib", I think

@Kronuz
   def close(self):
        """
        Close all pooled connections and disable the pool.
        """
        # Disable access to the pool
        old_pool, self.pool = self.pool, None

        try:
            while True:
                conn = old_pool.get(block=False)
                if conn:
                    conn.close()

        # except Empty:
        except Exception as exc:
            print 'a', type(exc)
            print 'a', type(Empty)
            print 'a', id(exc)
            print 'a', id(Empty)
            pass  # Done.

output
a <class 'Queue.Empty'>
a <class 'Queue.Empty'>  ###  it should be  <type 'type'>
a<PHONE_NUMBER>58592
a<PHONE_NUMBER>58592

and I have found where the err code lead to my problem.

@fqroot, where? ...Wait, what? how?
It's really weird... why doesn't the except Empty catches it then?

@Kronuz   I noticed that there is an error code in other part
simple like
def handle():
try:
    pass # some code
except Exception, Queue.Empty:  # may drink too much : )
    pass

the handle function was created by module importlib
so Queue.Empty is not <type "type"> any longer and become a instance of Queue.Empty
This explanation is my guess.

@fqroot, I still don't get it :/
Could you please elaborate a bit more? I'm getting KeyError instead of Empty (or so the log in Sentry says)... What where you getting there?

My situation may not suit you.
what type exception you get in that close function？

@fqroot, I'm getting KeyError((1, True)) ...for some reason

@Kronuz I don't know how to help you...

To anyone who happens upon this thread in the future, a few things:

@Kronuz and @fqroot are having similar (on the face) but very different problems

@fqroot is using Python 2 in which you could do
try:
    # ...
except ExceptionClass, exc:
    # Use exc as the instance of ExceptionClass

when they meant to use
try:
    # ...
except (ExceptionClass1, ExceptionClass2, ExceptionClass3):
    # Catch one of those exception classes but do not store it as a local

this is why Queue.Empty was no longer of type type in @fqroot's case and why he was seeing the Queue.Empty exception as being unhandled by requests/urllib3.

@Kronuz is getting an entirely different exception from code that should only ever raise a Queue.Empty exception. At the time of this writing, it is still unclear how this is either happening or even possible.

I still keep getting this error (the original one I posted) ...and I honestly have no idea why or how to figure it out.
What are your best guesses?

@Kronuz My best guess is that something is monkeypatching the Queue.Empty import, either in the Queue module or in requests.packages.urllib3.connectionpool. That's the only way I can see that we'd hit a problem where the implicit isinstance check in except fails to work.

@Lukasa, but even if Queue.Empty is monkeyparched, how the message ends up being KeyError: (1, True) ?? And if the method LifoQueue.get() or LifoQueue was monkeyparched, the traceback would come with the monkeyparched version of it, wouldn't it? This is weird!

@Kronuz Yeah, this is definitely one of the weirdest things I've seen. You're probably going to want to try to find a consistent reproduction scenario and then shrink it down to as little code as you can.

This doesn't always happen either ...maybe it not always happening has to do with that old_pool in connectionpool.py and why/when the get() is called and under what circumstances the object could be empty or full or something. What does that old_pool is for? What is it doing there in that part of the code and why? How does that work?
I'll report my findings... if anyone can think of a way to track this down, please, please suggest.

The purpose of old_pool is to ensure that everything gets cleaned up quickly.
Essentially, when close is called on the pool the old reference to the pool is moved to old_pool (which is only in scope in the close function) and the pool reference gets changed to None. We then grab all the connections from old_pool so that we can properly close them and throw them away.
Do you have any form of logging other than Sentry, that may contain a complete traceback?

@Lukasa, Sentry provides the full raw log as well, it's the one I pasted above... But I'll try to log more things ...the bad news is it's not always happening either :/

@Kronuz I haven't actually seen a full, Python-formatted traceback from you in this thread, which is why I asked. I'm just worried that somewhere along the way we're losing information.

I'll check the server log files for a complete traceback as it comes from Python, hopefully is there.
Also, I don't even have gevent installed (in the whole system), but I'll also look for other things that might be monkeyparching stuff. e.g. do a regex search of\.(Empty|LifoQueue|get)\s*= and setattr\([^)]+["'](Empty|LifoQueue|get)["']\) ...suggestions here?

On that front I have absolutely no suggestions. =(

I would think the first regexp would be the better one to use. @Kronuz, are you still on 2.8.1 or have you changed versions of requests?

@sigmavirus24, I'm still in 2.8.1
The search across all my files with those regexps didn't yield anything even remotely interesting...

Finally found it!
http://kronuz.io/nasty-bugs-crawling-in-some-python-libraries.html

Hah, very nicely done @Kronuz! And a very subtle bug it was too.

:cake: for @Kronuz and @Yhg1s


How to use multi-GPU  for training CycleGAN

Thanks to the author, I have successfully run with my own data set. I want to know how to use multiple GPUs.

I think this is your answer
https://datascience.stackexchange.com/questions/23895/multi-gpu-in-keras


simplify doesn't work

Hello :
when I obfuscate this :
if (a==0) { for (i=0;i<5;i++) if (b[i]==0) alert(1); } else alert(2);
with the default option preset,
I have the result :
if(a==0x0)for(i=0x0;i<0x5;i++)if(b[i]==0x0)alert(0x1);else alert(0x2);
So the "else" is now on the condition b[i]==0, no more for the condition a==0 and the script is not the same (with my code, if a ==0, I could have 0 alert if all b are != 0. With your code, I have 5 alerts)
If I unchecked the "Simplify" = no problem = the {} stay
If I write this :
if (a==0) { for (i=0;i<5;i++) { if (b[i]==0) alert(1); } } else alert(2);
I have the result
if(a==0x0)for(i=0x0;i<0x5;i++){if(b[i]==0x0)alert(0x1);}else alert(0x2);
so it works because the {} for the "for", useless, is not simplify (bug number 2).
Another example for bug n°2, if I write :
for(i=0;i<5;i++) {if (b[i]==0) alert(1);} alert(2);
I have the result :
for(i=0x0;i<0x5;i++){if(b[i]==0x0)alert(0x1);}alert(0x2);
the {} is still there.
The second bug is not really a bug (could be better but not a problem for me)
The first bug changes the meaning of javascript so I think it is a big problem
Best regards
Mahab

PR:
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/861

PR:
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/861

Glad to see this issue being fixed so fast.

Released as 2.10.2

Released as 2.10.2

Glad to see this issue being fixed so fast.

Good job, thanks

Good job, thanks


file run in freebsd

the main can not run in freefsd os ,the pictures is the info about os and app info

@wike2019 please open an new issue and complete the entire template. Thank you.


Feat: User should have option to make their own password

Describe the feature
When the user try to register their is two input fields email and password so when the user want to make their account in the website. If he wants make their own password there is no option to for a user to make their own password.

So my suggestion is to give an another input field for confirm the password so that the user can remember their password as there are chances that the user may enter wrong passord
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hi please assign me this issue under Gssoc 2024


bootstrap.sh Error: aws-sam-cli 1.8.0 is already installed

Running bootstrap.sh as described on https://cicd.serverlessworkshops.io/java/setup/bootstrap.html fails with
Error: aws-sam-cli 1.8.0 is already installed
To upgrade to 1.10.0, run `brew upgrade aws/tap/aws-sam-cli`.

Workaround is to change line 34 from install to upgrade.

Thanks for pointing this out @deki . The bootstrap script was written to upgrade AWS SAM to the latest version because Cloud9 used to ship with a very old version. Looks like this is no longer a problem so the bootstrap script may not even be necessary anymore.

If you think you have the fix. Feel free to submit a PR to the dev branch. We can test it on the dev environment http://dev.cicd.serverlessworkshops.io/ before pushing to the official domain name.

With the applied fix SAM 1.8.0 is used. This is working fine for NodeJS but for Java some folks reported the following error message:
samcli.local.docker.manager.DockerImagePullFailedException: Could not find amazon/aws-sam-cli-emulation-image-java8:rapid-1.8.0 image locally and failed to pull it from docker.
We were able to fix that using brew upgrade aws-sam-cli with version 1.10.0. So I'll submit another PR.

Awesome, thank you @deki


Add support for VRF leaking under router-general

Change Summary
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue(s)

Fixes issue #669
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add support for router_general for vrf leaking
router_general:
  vrfs:
    <destination-vrf>:
      leak:
        source_vrf: <source-vrf>
        policy: < rm policy >

How to test
Please check Molecule scenario
Checklist:

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated molecule CI testing accordingly
[x] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Add support for multiple source VRFs
+router general
+   vrf test
+      leak routes source-vrf test3 subscribe-policy all
+      leak routes source-vrf test2 subscribe-policy all
+!

Ready for testing and review.
cc: @sebastianw @mpergament

Changes applied in commit 7b15495.
Ready for final review and merge


Runtime translations and config stuff

This will eventually expand to other resource pack / data pack entries. Translations are just the start.
This is of course a draft as the branch is not complete.
Update
This is not only ARRP now, I also added config validation. Why? Yes.

This seems to mostly work and be stable. I want to get this merged as soon as possible, I'll do other translations after that.

Any objections before I merge?

If it launches it's good enough for me :)

It launches, translations work. I don't know if I broke existing features though - I've not been following the progress and so I don't know how to test those.

I'll merge in 5 minutes


Does Qwen (DashScope) only support cloud service calls? Can the locally private deployed Qwen large model support calls as well?

The langchain4j-dashscope is a wrapper for the model service provider DashScope (by Aliyun). If you want to use some local runtime framework to run the Qwen2 model and implement the relevant interfaces of langchain4j, you will need to implement it separately.


[Format] Add AdbcStatementExecuteSchema

It would be useful to be able to get the schema of a query's result set without actually executing it. For example, Ibis uses this to allow embedding arbitrary SQL within its DSL. And Flight SQL already supports this.
We could add a new function:
AdbcStatusCode AdbcStatementExecuteSchema(
  struct AdbcStatement* statement,
  struct ArrowSchema* schema,
  struct AdbcError* error);

Drivers may implement this by executing the query.
They may attempt to transform the query to limit side effects and execution time, however, this is not guaranteed.

In other words, don’t use this with DML/DDL queries, though that doesn’t really make sense in the first place.
If the client itself is able to transform the query to limit execution time, this is still a good idea.

This applies across languages. See #317 for how backwards compatibility would be managed.

I started rewriting spark-flight-sql data source to spark-adbc (https://github.com/tokoko/spark-adbc), this function would greatly simplify efficient schema inference. I can give implementing this a try (at least in Java) if that's okay with you.
P.S. Wouldn't it make more sense for the drivers to fail if schema detection can't be accomplished without significant execution time? (up to drivers to decide what "significant" means) I'm thinking of stored procedures in case of jdbc, for example. It would force clients to explicitly call executeQuery in such cases and avoid inadvertently executing long-running queries.

Failing probably makes more sense, we should make sure to define the error code in that case.
Since this affects the spec, we're still deciding how best to handle the development process; if you're interested, please chime in on the mailing list. https://lists.apache.org/thread/3y73755p0w4n25rd5ry2ppnhzkz3thv3


Bump v1.10.x to 1.10.1-pre1

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
  +0.0%     +21 [None]                          +109  +0.0%
   +13%     +11 src/cpp/common/version_cc.cc     +11   +13%
       +28%     +11 grpc::Version[abi:cxx11]         +11   +28%

  +0.0%     +32 TOTAL                           +120  +0.0%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                               cpu_time    real_time
----------------------------------------------------------------------  ----------  -----------
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144  -6%         -6%

Failures: bazel infra, removed beta_interface tests for Python, TLS error on Python, Java docker image download infra failure


Redo/undo functionality

extracted from https://github.com/apclary/dungeon-revealer/issues/132

Ctrl+Z Undo (Probably a new feature for a Undo/Redo Stack)
Ctrl+Y Redo

In the meantime an alert to confirm shroud all/clear all would be great, as clicking one of those currently will lose all of your revealing process

@Jared0430 Great idea. I created https://github.com/dungeon-revealer/dungeon-revealer/issues/472 for tracking this.


New version of Newtonsoft.Json

Hello,
There is new version of Newtonsoft.Json
When I put the new version .dll I got the following error:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeI
nitializationException: The type initializer for 'Ghpr.NUnit.Extensions.GhprEventListener' threw an exception. ---> Syst
em.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicK
eyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified.
at Ghpr.Core.Helpers.ReporterHelper.GetSettingsFromFile(String fileName)
...
Please, if possible, update to the new version of Newtonsoft.Json

Hi!
Sure, I will prepare an update for Ghpr packages

@nikembala this is done now, the new version is 0.4.6 for both Ghpr.Core and Ghpr.NUnit

Thank you!


Added strict class attribute to OptsMagic

This PR addresses the issue raised in #1373
With strict=True:

And strict=False (default):

I used sys.stderr because the magic classes are not parameterized and the root param logger adds very little of value and would make this type of warning a lot uglier than necessary.

Looks good to me, thanks!

This is exactly what I would liked 👍

You said you didn't like the red warning, do you want to just use IPython.display to render the HTML warning or are you okay with it now?

I have a pretty negative association with warnings and that red color - mostly due to ipywidgets, numpy warnings you can't do anything about etc. I do think it looks ugly but maybe that is a good thing: it means users should fix incorrect options so we never have to see them!
I can use this PR as a opportunity to update the message. What would be a good way to help make sure the user has loaded all the backends they want?

I'm now filtering plot options at the Plot.lookup_options level. I'm now wondering if Options should ever be dropping their kwargs (the parameter is skip_invalid not drop_invalid).
  If the tests pass we can think more carefully about whether it is the right thing to do (I suspect so).

@philippjfr Ok the tests passed with my last commit. So..

Are you happy with these changes? All filtering is now done by Plot.lookup_options instead of some of it, with some filtering by options.
Are we happy with the current message? Maybe a line at the end to suggest loading more backends? 'If you believe this keyword is correct, please make sure the backend is loaded using notebook_extension.' Something like that?

Maybe @jbednar has a better suggestion for the latter?

Are you happy with these changes? All filtering is now done by Plot.lookup_options instead of some of it, with some filtering by options.

I'm going to have to go through the code to double check options are never accessed directly elsewhere.

Are we happy with the current message? Maybe a line at the end to suggest loading more backends? 'If you believe this keyword is correct, please make sure the backend is loaded using notebook_extension.' Something like that?

This warning will also appear outside a notebook context right? So I suppose it should be:

If you believe this keyword is correct, please make sure the backend has been imported or loaded with the notebook_extension.

This warning will also appear outside a notebook context right?

I'm not sure it will.
The OptsMagic generates this message and only the OptsMagic currently uses the StoreOptions.validate_spec method to do this kind of validation.

The OptsMagic generates this message and only the OptsMagic currently uses the StoreOptions.validate_spec method to do this kind of validation.

So what happens when using the __call__, no validation at all?

Right, __call__ simply uses:
StoreOptions.set_options(deep_clone, options, **kwargs)

The validation you'll get are the option errors in skip_invalid is False and the allowed_keywords are set - which given what I found out above, might not be working.

Note that even if we added the same sort of validation to __call__ (which would be a valid feature request, just not for this particular PR) then the message would be generated at that point.
As the current validation only happens in the OptsMagic, the message we are currently discussing will only apply to notebooks.

Seems like that message could appear in other contexts if we add explicit Opts parsing via python calls to the parser, so Philipp's version seems less confusing to me.

I would agree if it were StoreOptions.validate_spec that generates the message. Instead it generates an OptionError which is then formatted and output appropriately at the point where it is caught.
Right now this is in the opts magic with the message discussed in this PR and in future it could be in the __call__ method where it could output a similar message but one that is agnostic to the notebook. I don't mind using Philipp's suggestion, it is just that I don't think the ' backend has been imported' bit is relevant currently.

I've used Philipp's suggestion as there is no harm in including the extra bit which may be good advice if we add validation to __call__ later. Here is what it looks like:

The wrapping in the warning is a bit annoying but that is probably something that varies from browser to browser and monitor to monitor.

Could you have a look at MPLRenderer.plot_options and BokehRenderer.plot_options? I think they need extra handling now.

It's possible they can just use Plot.lookup_options as well.

It's possible they can just use Plot.lookup_options as well.

That probably makes the most sense.

Using Plot.lookup_options from the renderers seems fine with nosetests at least. Let's see whether it is also ok with the notebook tests.

Looks like it will pass, merging.


workflow(sca): check commits in CI

Codecov Report

Merging #674 (8c6de25) into main (0548cf4) will decrease coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 66.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   92.96%   92.94%   -0.02%
==========================================
  Files         128      128
  Lines        5627     5630       +3
==========================================
+ Hits         5231     5233       +2
- Misses        396      397       +1

Flag
Coverage Δ

unittests
92.94% <66.66%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

ggshield/cmd/sca/scan/ci.py
88.37% <66.66%> (-1.63%)
:arrow_down:


Fix history to remove blobs above 3 MiB

I used bfg-repo-cleaner to remove all blobs above 3 MiB.
bfg --strip-blobs-bigger-than 3M
# I have no idea what the script below does but the script above told me to do it!
git reflog expire --expire=now --all && git gc --prune=now --aggressive

This is a bit of a mystery what this tool does and I'm concerned we could break things. Have you checked the git log after runnign this command?

I agree that this is scary haha! The history is the same as the main branch on my fork (which I stupidly submitted the merge_rasters PR on...):
commit fd670e4fa0489531854a5411d62d3d3f131d3e80 (HEAD -> fix_history, origin/main, origin/fix_history, origin/HEAD, main)
Author: Erik Holmlund<EMAIL_ADDRESS>Date:   Wed Mar 10 10:32:36 2021 +0100

    Added function to merge rasters using any callable (mean, median, sum etc.)

    Former-commit-id: 4ed6d81fb93c51896a845b8abd3e20f9f5d31b64

commit b6cfa7b74555d649e73c0b28021c4796e9a33b9a (upstream/main)
Merge: 4972ed1 cdf6273
Author: Romain Hugonnet<EMAIL_ADDRESS>Date:   Wed Mar 10 10:06:42 2021 +0100

    Merge pull request #34 from erikmannerfelt/main

    Move examples to one place: a separate examples directory + ICP coreg improvements

    Former-commit-id: 0182b822172a63232943cda5b4baea95fea73938

commit cdf62732c63fa3c748f713d4ee17089f0600e8c3
Author: Erik Holmlund<EMAIL_ADDRESS>Date:   Tue Mar 9 15:20:28 2021 +0100

    Improved nodata handling and made sure input DEMs are (converted to) floats

    Former-commit-id:<PHONE_NUMBER>2db4829d0e35a0af726264b42e599b

commit 38ea614873254addb7fb668c8e9b960218b543f1
Author: Erik Holmlund<EMAIL_ADDRESS>Date:   Tue Mar 9 15:18:44 2021 +0100

    Added opencv as an optional dependency

    Former-commit-id: 3f937a2ef07233e3c1c97f90e0cb1d9a3c20e1ed

commit 206de2b0b57c0dbf68ba3ac277bbec1a38ffdc53
Merge: 124e9c2 4972ed1
Author: Erik Holmlund<EMAIL_ADDRESS>Date:   Tue Mar 9 14:57:10 2021 +0100

    Merged pull and fixed conflicts with environment

    Former-commit-id: 9c722b465412c3ea00b327237295ef50689956fd

commit 124e9c2c8322c68582618681767f57fee536fbae
Author: Erik Holmlund<EMAIL_ADDRESS>Date:   Tue Mar 9 14:39:08 2021 +0100

    Modified PDAL ICP implementation to handle memory better. Added opencv ICP implementation which is much faster. Set the opencv ICP approach as the default 'icp' method.

    Former-commit-id: 66d20f676fa0780a3e6b8287b614b7033d80ef23

I mean, what does the log look like for the commits where the data was added/modified?

This rewrites the entire history to exclude the blobs.
The merging method would decide how it would look in the xdem/main history

Maybe I should emphasise that this has not been a lot of work for me, so we can reject the PR and then let a git-wizard (anyone know of any??) do this operation for us.

Maybe I should emphasise that this has not been a lot of work for me, so we can reject the PR and then let a git-wizard (anyone know of any??) do this operation for us.

Don't know about any git wizard :mage: , unfortunately!

I just compared the history between your branch and the master, and it seems like the changes are pretty transparent. The files are gone forever from the git history, which is a good thing.
I think we can try to merge.

I just fixed the merge conflicts, so it's ready when you are!


org.bouncycastle.crypto.fips.FipsOperationError: Module checksum failed: expected

Getting below error when I try to include bc fips jar into my jar. How do I solve this?
[735510be1bb5157434c14d1e1ca9844b6971634fc03481d93eec75ff27b27034] got [4fc88822bd6ca528e6963f3951c4056aa33976ae3e8b82f7c8cc3f433a1e1f3f]
at org.bouncycastle.crypto.fips.FipsStatus.moveToErrorStatus(Unknown Source)
at org.bouncycastle.crypto.fips.FipsStatus.checksumValidate(Unknown Source)
at org.bouncycastle.crypto.fips.FipsStatus.isReady(Unknown Source)
at org.bouncycastle.crypto.CryptoServicesRegistrar.getDefaultMode(Unknown Source)
at org.bouncycastle.crypto.CryptoServicesRegistrar.(Unknown Source)
at org.bouncycastle.jcajce.provider.ProvSecureHash$MD5.configure(Unknown Source)
at org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider.(Unknown Source)
at org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider.(Unknown Source)
at org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider.(Unknown Source)

Hi,
The checksum is a FIPS requirement.
Merging it with another jar is the equivalent of adding other classes to it which causes the checksum to  be different and this causes the module startup failure you are seeing.
A solution for you is to include it on the same classpath that loads "myjar".
MW

Any modification or repackaging of the jar will cause the checksum failure, which is by design. The only way to "resolve the issue" is to not do those things.

Any modification or repackaging of the jar will cause the checksum failure, which is by design. The only way to "resolve the issue" is to not do those things.

I downloaded the checksum from the Bouncy Castle official website. Here is the reference

bc-fips-<IP_ADDRESS>.jar
9008d04fc13da6455e6a792935b93b629757335d
703ecd8a3a619800269bc8cd442f2ebf469bd2fe70478364f58ddc6460c35f9f

but when I opened bc-fips-<IP_ADDRESS> jar and checked, the checksum value was different. Please see this reference
repo1.maven.org/maven2/org/bouncycastle/bc-fips/<IP_ADDRESS>/bc-fips-<IP_ADDRESS>.jar.sha256
why this difference? in my code, i am getting this
Exception in thread "main" org.bouncycastle.crypto.fips.FipsOperationError: org.bouncycastle.crypto.fips.FipsOperationError: Module checksum failed: expected [9f6751f059ab42f7d83e4e107881438036787e1e1821cd23a53c4b8181cc300f] got [44a0ea1cfdbcd90db49358391eeefdc443fb61bb50d69975128d94cb43a91fce]
Note : we are not modify or repackage the bc-fips jar
On Tue, Jun 25, 2024 at 3:47 PM Peter Dettman<EMAIL_ADDRESS>wrote:
Any modification or repackaging of the jar will cause the checksum failure, which is by design. The only way to "resolve the issue" is to not do those things.—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

@prabusenthil You are confusing two different checksums. There is the SHA-256 checksum that is an externally-calculated SHA-256 digest over the jar file so that you can confirm correct download (e.g. with something like "openssl dgst -sha256 bc-fips-<IP_ADDRESS>.jar").
However the jar also maintains an internally-stored checksum so that it can self-validate at startup (per FIPS requirement). The exception message relates to this internal checksum.

Note : we are not modify or repackage the bc-fips jar

Great, then you aren't getting the exception.


Puller Bear is not assigning the correct CME when PR is ready for review

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a PR with a linked issue
Set it to ready for review
Check the puller bear assignment

Expected Result:
Puller bear should assign the same CME that reviewed the proposals
Actual Result:
Puller bear is not assigning the correct CME.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Github

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Example PR: https://github.com/Expensify/App/pull/4801
Extra information from @roryabraham:

To be clear, I think this is working for when new PRs are created (assuming they correctly tag the linked issue), but I think it might not be working when a draft PR is marked as ready-for-review and converted into a "real" PR

@Beamanator was working on these issues:
https://github.com/Expensify/Expensify/issues/173915
https://github.com/Expensify/Expensify/issues/162941
Expensify/Expensify Issue URL:
View all open jobs on GitHub

From @roryabraham https://expensify.slack.com/archives/C01GTK53T8Q/p1630360934157300

When a draft PR is marked as ready-for-review, PullerBear does not correctly tag the CME that reviewed proposals on the linked issue. Example: https://github.com/Expensify/App/pull/4801

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Assigning @Beamanator per slack thread

@Beamanator Eep! 4 days overdue now. Issues have feelings too...

It looks like the GitHub webhook event pull_request, with action ready_for_review is sent when a draft PR is marked "Ready for review". I think we have two methods of attack:

This event can re-request PullerBear as a reviewer, which will try again to find a CME on a related issue. If a linked issue isn't found or if we can't find a CME on a linked issue, a new Engineer will be requested

This could be "non-ideal" since someone will always be assigned when the PR is created (I don't believe it's possible to create a PR in a draft state)

The event will trigger attempting to find a CME reviewer (reusing most of the PullerBear::getCashReviewerlogic) but will not add a new Engineer if a CME isn't found

Changing to Weekly since we are correctly assigning CMEs, this issue is just to "try again" when PRs are moved from draft -> ready for review

Asked for more feedback in Slack, before moving forward

This event can re-request PullerBear as a reviewer

Are you sure this will work? I think that webhook handlers might not be able to trigger other webhook events?

This could be "non-ideal" since someone will always be assigned by PullerBear when the PR is created (I don't believe it's possible to create a PR in a draft state)

I don't follow – you can definitely create PRs in a draft state and PullerBear is not assigned.

The event will trigger attempting to find a CME reviewer (reusing most of the PullerBear::getCashReviewer logic) but will not add a new Engineer if a CME isn't found

I think this programatic approach is probably the best way to do this, but I think it should add an Engineer reviewer if a CME isn't found

This event can re-request PullerBear as a reviewer

Are you sure this will work? I think that webhook handlers might not be able to trigger other webhook events?

Huh you're thinking if a webhook handler does something like comments on an issue, no webhook will be triggered since the source was a webhook handler? You may be right! I will test this out 👍

This could be "non-ideal" since someone will always be assigned by PullerBear when the PR is created (I don't believe it's possible to create a PR in a draft state)

I don't follow – you can definitely create PRs in a draft state and PullerBear is not assigned.

Really?? I've looked but can't find anywhere to make a PR a draft, can you see this option in this test branch? https://github.com/Expensify/App/compare/fake?expand=1

The event will trigger attempting to find a CME reviewer (reusing most of the PullerBear::getCashReviewer logic) but will not add a new Engineer if a CME isn't found

I think this programatic approach is probably the best way to do this, but I think it should add an Engineer reviewer if a CME isn't found

I am fine with this, but I think it should check if an Engineer is already assigned as a reviewer - like if a person created the PR, put it in draft, then marked "ready for review" -> I don't see why we'd want a 2nd Engineer automatically assigned at this point -> And if the author does want a 2nd reviewer, they can assign PullerBear

Update: I tested this on my personal repo & webhook, and I saw the comment "test" retrigger itself 3 times before I manually killed it, so I think you may be wrong?

Cool, I know that by default GitHub Workflows can't trigger other workflows, but I guess that's not the case for webhooks. Thanks for testing 👍

Really?? I've looked but can't find anywhere to make a PR a draft, can you see this option in this test branch? fake?expand=1 (compare)

Yep, here's the draft PR 😉 https://github.com/Expensify/App/pull/5236.
Edit: it's closed now.

I am fine with this, but I think it should check if an Engineer is already assigned as a reviewer - like if a person created the PR, put it in draft, then marked "ready for review" -> I don't see why we'd want a 2nd Engineer automatically assigned at this point

Agreed, good point 👍

Ok thinking about this again, I think I can edit PullerBear to not be assigned if the PR is in a draft state. If that works, scenario 1 above won't be an issue. Will look into this this week, time permitting

Hmm from these GH docs (Draft Pull Requests), it seems like CODEOWNERS shouldn't be respected when a PR is created in a draft state 🤔

When you create a pull request, you can choose to create a pull request that is ready for review or a draft pull request. Draft pull requests cannot be merged, and code owners are not automatically requested to review draft pull requests. For more information about creating a draft pull request, see "Creating a pull request" and "Creating a pull request from a fork."

Ok after a bit more thinking, since CODEOWNERS will always request @Expensify/pullerbear as a reviewer once the PR is in a "ready for review" state (either when first created or after initially converted from Draft to "ready for review"), I can't think of a scenario when an engineer WON'T already be assigned to review.

If PullerBear finds a CME, they'll be assigned.
If PullerBear doesn't find a CME, an engineer will get assigned

Therefore this new webhook event should only try to assign CMEs

@kadiealexander I'm removing n6-hold from this issue b/c this change is purely internal, and only relates to how pull request reviewers are automatically assigned :)


[ WIP ][ layer ] Custom Multi Head Attention layer

Changes made in this PR:

Added CustomMultiHeadAttentionLayer class with CPU implementation of custom MHA from FELICE repo.
Added API endpoint CustomMultiHeadAttention and required enums.
Modified app_context to register custom MHA.

Work In Progress:

GPU implementation of this custom MHA
Valid unit tests
Sanity checks

Signed-off-by: Debadri Samaddar<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2650. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @s-debadri, nntrainer/layers/custom_multi_head_attention_layer.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406251521590.086549997329712-1a28a52e2fd5702a2bd8940e130b5b515865a8df/.

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406251558170.7800760269165-841c14247caf0bc3e2d15f140d299a26b5ddc5a7/.

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406261917230.12148904800415-17b2ecf7f09e068719dedb8b6a9fb9dc46840bb2/.

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202407031816100.44195008277893-38617fe195c419773bd664aed2bd9308d602c7d6/.

Another clean PR raised for the same: #2671


Code samples are title "Windows Command Prompt" instead of Terminal

This is a little detail, but it confused me for a second as to why I'd be using CMD to configure Mac settings, so I thought I'd mention it. Doesn't appear to be something I can edit on the page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 49b8ce2e-bda2-4835-d535-ec018117b668
Version Independent ID: ccba60e4-da58-4ed9-b5a7-de5dce2a711f
Content: Configure Microsoft Edge for macOS using a property list.
Content Source: edgeenterprise/configure-microsoft-edge-on-mac.md
Product: microsoft-edge
GitHub Login: @kelleyvice-msft
Microsoft Alias: brianalt

@cchambers-cap Thanks for the feedback!  We are working to update the documentation, which you should be able to see shortly.


Topic

Current coverage is 80.26%

Merging #91 into master will not affect coverage as of c3a4991

@@            master     #91   diff @@
======================================
  Files           10      10
  Stmts          897     897
  Branches         0       0
  Methods          0       0
======================================
  Hit            720     720
  Partial          0       0
  Missed         177     177

Review entire Coverage Diff as of c3a4991

Powered by Codecov. Updated on successful CI builds.


chore: bump provider js deps to pre.11

closing this because the provider is going to be migrated to a new repository + we've locked things in pre-10


How to use this plugin in Pycharm?

In #48 , you said:

Create nginx server in settings, use auto-completion in its conf files, start and stop server from Run Configuration settings.

Then I create a new nginx server
.
But I don't know how to add nginx server info to it.

Don't manually enter the config values. Click new first on the right and choose your nginx executable


row: allow title to be truncated to (n) lines

i had to do some awkward things to make this a non-breaking change. let's discuss
resolves #497
Outstanding

[ ] docs

change to be true/false is truncated. truncate to 2 lines


Tech Debt: Case Summary API is not implemented

Describe the bug
The case summary API  is not implemented yet in the case management service. This API returns only the public fields of a case that is visible to everyone.
To Reproduce
Steps to reproduce the behavior:

Open Postman
Create a GET request for /casemanager/case/v1/_summary as specified in the API spec.
Hit "Send"
See response error code 404.

Expected behavior
The summary API should return a 200 OK response with the public fields of a case.
Additional context

The case search API will return 200 OK with data only if the requester is a part of the case as a litigant/judge/bench clerk. Otherwise, it will return a 401 Forbidden.
The UI should call the summary API to join a case.

Closing this as a duplicate of 1451


Mistake in documentation

Hello,

Need to change "that is not in this list" to "that are in this list" in below statement.

WDI_TLV_DISALLOWED_BSSIDS_LIST X The list of BSSIDs that are not allowed to be used for association. If specified, the adapter must not associate to any AP that is not in this list.

It would be good if all TLVs are in table format. Something like below link
https://docs.microsoft.com/en-us/windows-hardware/drivers/network/wdi-tlv-scan-mode

Thanks & Regards
Vishnu Beema

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 55ed9d58-53a0-482e-197b-2c6de9f06b0b
Version Independent ID: 281142aa-df29-2103-6ad4-9efed33ee562
Content: WDI_TLV_CONNECT_PARAMETERS
Content Source: windows-driver-docs-pr/network/wdi-tlv-connect-parameters.md
Product: windows-hardware
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

Thanks, @beemavishnu. @duncanmacmichael, looks like this was formatted as a table but something went wrong along the way to publishing. Can you make it purty? Might want to do a quick spot check of the other TLVs to see if it's more widespread than just the one.

Hi @beemavishnu , thanks for finding this. It looks like the table was garbled during a content migration we did a while back and ended up slipping through the cracks. We usually do have the TLV values in table form, and I confirmed that this is the only one I know of by doing a random spot check of a dozen+ other TLVs. I've made the fix and the change should be live later today or tomorrow. Thanks for your interest in the docs!


Fixed CapabilityStatement validation error

Fixed invalid narrative section for Touchstone

Coverage remained the same at 94.353% when pulling 52de27887c550d44b24e1658475841acc7d8afc8 on cody-capability-statement-validation into a97617732874f5c13294db2773f636e0d6e65c26 on main.


Extend filter-hook "table_add_row_action_array" by parameter "keyword"

I use the plugin AuthMgrPlus for giving different editing-rights to different users.
As I want users of type "contributor" to be able only to edit their own URLs I nevertheless want them to see all existing URLs in the YOURLs-instance. Though this is possible by giving them the right "ViewAll" via user-config this also leads to having the buttons for "Edit" and "Delete" visible and clickable for them, also for URLs which are not their own.
Now from a UI-perspective, I think it would be better to hide (or deactivate) functionality which is not available to a user, rather than letting him click on it and then display an error (which currently doesn't work properly either).
While I tried to figure out, how it could be achieved to hide these buttons for a user URL-wise, I came across the filter-hook "table_add_row_action_array" in the functions-html.php (on line 566 in version 1.7.9).
But then I realized that for the use of this hook in a plugin the context of the keyword is missing. Without that, a filter-function could not decide wether a user should be able to edit/delete a keyword or not.
So this is the reason for my request to introduce a second parameter "keyword" to the hook, like I did now manually:
	$actions = yourls_apply_filter( 'table_add_row_action_array', $actions, $keyword );
So a plugin (maybe authmgrplus) could handle this properly.
Many thanks!

Very open to adding hooks as needed ! Could you open a pull request with the proposed change?

Very open to adding hooks as needed ! Could you open a pull request with the proposed change?

This is my first pull request, hopefully I got it right.


Sudden error with torchvision

🐛 Describe the bug
Hello I have problem with pytorch
!pip install torch==1.9  #I NEED TO USE THIS VERSION and the following code has been working so far until now.
I don't know why I get this error just now
from torchvision import transforms
ModuleNotFoundError: No module named 'torch.ao.quantization'
Full code:
###############################
!pip install torch==1.9
import numpy as np
from matplotlib import pyplot as plt
from google.colab import files
from PIL import Image, ImageShow
import glob
import torch
from torch.utils.data import Dataset
from torch.utils.data import DataLoader
from torch.utils import data
from PIL import Image
from torchvision import transforms
from os import listdir
from os.path import isfile, join
from google.colab import drive
import os
import json
torch.version
os.CUDA_LAUNCH_BLOCKING = "1"
#################### ERROR ############
/usr/local/lib/python3.7/dist-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: libtorch_cuda_cu.so: cannot open shared object file: No such file or directory
warn(f"Failed to load image Python extension: {e}")
ModuleNotFoundError                       Traceback (most recent call last)
 in ()
9 from torch.utils import data
10 from PIL import Image
---> 11 from torchvision import transforms
12 from os import listdir
13 from os.path import isfile, join
4 frames
/usr/local/lib/python3.7/dist-packages/torchvision/models/quantization/mobilenetv2.py in ()
3 from torch import Tensor
4 from torch import nn
----> 5 from torch.ao.quantization import QuantStub, DeQuantStub
6 from torchvision.models.mobilenetv2 import InvertedResidual, MobileNetV2, model_urls
7
ModuleNotFoundError: No module named 'torch.ao.quantization'

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
Versions
Collecting environment information...
PyTorch version: 1.9.0+cu102
Is debug build: False
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A
OS: Ubuntu 18.04.5 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
CMake version: version 3.12.0
Libc version: glibc-2.26
Python version: 3.7.13 (default, Mar 16 2022, 17:37:17)  [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-5.4.144+-x86_64-with-Ubuntu-18.04-bionic
Is CUDA available: True
CUDA runtime version: 11.1.105
GPU models and configuration: GPU 0: Tesla V100-SXM2-16GB
Nvidia driver version: 460.32.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.0.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.0.5
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
Versions of relevant libraries:
[pip3] numpy==1.21.6
[pip3] torch==1.9.0
[pip3] torch-summary==1.4.5
[pip3] torchaudio==0.11.0+cu113
[pip3] torchsummary==1.5.1
[pip3] torchtext==0.12.0
[pip3] torchvision==0.12.0+cu113
[conda] Could not collect

Hi @LJ-00 , seems like the problem is incompatible version between torch and torchvision.
You can see the compatible pair on the table here: https://github.com/pytorch/vision#installation.
Specifically, I think if you want to use torch==1.9.0, you should use torchvision==0.10.0.

To complement @YosuaMichael's answer: The usage of torch.ao.quantization was introduced in #4554 and was first published in the 0.12.0 release. The fact that it worked before was pure luck, because presumably the torch and torchvision were already not in sync.
Your env is also broken in a another way: your torch version was built against CUDA 10.2, whereas torchaudio and torchvision where built against CUDA 11.3. I suggest you start with a clean environment and install with
$ pip install torch==1.9.0 torchvision==0.10.0 --extra-index-url https://download.pytorch.org/whl/cu102

Alternatively, you can also replace the cu102 in the link with cu111 if you want to use CUDA 11. Note that torch==1.9.0 is not available for CUDA 11.3.


Rename ‘mustard’ → ‘legacy’

'mustard' has been renamed 'legacy' in DCF and WDN. Renaming here for clarity and consistency.

scss/legacy/_legacy.test.scss has mustard references in the contents of the file


Send message fails to retry on ratelimited error

Description
We had a send fail with:
Run<EMAIL_ADDRESS>axios post failed, double check the payload being sent includes the keys Slack expects
{
  username: 'github/repo',
  channel: '#some-channel',
  text: 'A message'
}
Error: {"retry_after":1,"ok":false,"error":"rate_limited"}
Error: Request failed with status code 429

It seems like this failure could be retries after a default timeout
What type of issue is this? (place an x in one of the [ ])

[X] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.
[X] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 1.25.0
node version:
OS version(s):
Steps to reproduce:

Have a message get a rate_limited error

Expected result:
The action would retry up to an upper limit of time
Actual result:
The action just fails
Attachments:
Run<EMAIL_ADDRESS>axios post failed, double check the payload being sent includes the keys Slack expects
{
  username: 'github/repo',
  channel: '#some-channel',
  text: 'A message'
}
Error: {"retry_after":1,"ok":false,"error":"rate_limited"}
Error: Request failed with status code 429

Hi @andre-qumulo thanks for writing in 💯
This seems to be a feature request for a retry option, we already have #245 open on the subject

👋 Hello! We landed support for a retries option in @v2.0.0 that'll retry failed API requests that might succeed again, such as the 429 rate_limited error you're finding here.
Different options of available timing are included in the README, but an example step with retries and the latest update might resemble:
- name: Allow multiple attempts for sending
  uses<EMAIL_ADDRESS>  with:
    retries: rapid
    webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
    webhook-type: webhook-trigger
    payload: |
      username: "github/repo"
      channel: "#some-channel"
      text: "A message"

This option applies to all other sending techniques too, and now that it's been released I think we can close this issue! Please feel free to follow up if you're finding this isn't working as you're expecting, but otherwise I hope rate limits can be mostly avoided with good timings 👻


feat(addon-doc): support target property for links

I think that's excessive. Can we just add rel="noreferrer noopener" there? What's the potential downside?


Add support for admin port on ZooKeeper

Fixes #549
Motivation
We need to be able to access the ZooKeeper admin endpoint to perform automated snapshots to an external system.
Modifications
I have added the admin port to the list of Zookeeper ports, and made the relevant changes on the zookeeper-service.yaml & zookeeper-statefulset.yaml to use the admin port.
Verifying this change

[ ] Make sure that the change passes the CI checks.

Good point @lhotari, there is some security implications. Especially for existing clusters, where they might not expecting the admin port being exposed.
I'll update the PR to make the field optional, and removed by default.


please

Hello, I desperately need to look at the code to solve some of my questions. I hope you can release the code as soon as possible, and I will be very grateful.

Sorry for late reply. Because of recent events, I finally organize the codes!

Thank you very much. I wish you all the best.


Copy trait limitations for the agent

Hi team, good work with the simulator and thanks for sharing it with the community. I am developing a simulation using the tool and I have a question regarding the agent's implementation.
All the agents are required to implement Copy trait. This prevents me from assigning dynamic properties to an agent.
For example, I have a time series data of varying lengths and each agent will be randomly assigned a series. Since the length of the time series can vary, I tried defining it as a vector. However, vector has no copy trait.
The only way I could think of is the simulation state holding this data and assigning each agent with a piece of data based on the current time step. That feels hacky. Since I am new to the tool, I wanted to check with you if there is a better way of providing Agent with dynamic sized information.

I found an alternative way of providing the necessary data. Thanks for sharing the tool!


Updates README

adds info on vdi_jupyter and gadi_jupyter scripts hosted at coecms/nci_scripts repo
fixes some broken URLs

@AndyHoggANU, the readme specifically says "There's some documentation here but it's very out-of-date - caveat lector." If the documentation is outdated I suggest we remove the link from the README. Outdated documentation only creates problems, it does not solve any...

Yes, I agree. A link to this documentation is negatively useful. (That is, it is worse than useless.)
But it might be worth a link to the COSIMA recipes doco??

a link to cosima-recipes is included!


Pin boto3 requirement to range

Requiring a specific version of boto3 causes issues with version conflicts

Can we check this works ok with moto - this caused us problems before https://github.com/alphagov/digitalmarketplace-utils/pull/452

Can we check this works ok with moto - this caused us problems before #452

Good point.
I haven't had any issues with moto in this repo, will check against the other repos now.

Should be fine as long as we're using moto3<=1.3.7


Vpx

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

libvpx is not available for Windows, so you will need to exclude it for that platform.


Fix for marking date as 'now'

Default 'now' prop in Month view so that the .rbc-now class is correctly added to the current date when the 'now' prop isn't supplied to the Calendar.

thanks!


Press day in next month go to last month

In current month view, if we press a day in next month, calendar should go to next month.
But sometimes it does not go to next month but go to last month.
For instance, in Dec 2016, we press "3" which means Jan 3rd 2017. It should go to Jan 2017 but it doesn't.

It goes back to Nov 2016.

This bug occurs in every Dec.
Similar problem in Jan if day in last month is pressed. It doesn't go back to last Dec but go Feb.

Nice catch

Fixed in v1.4.2


[MM-42366] Add summary to the playbook editor

Summary
This PR adds summary to the playbook editor
https://user-images.githubusercontent.com/2340127/165731331-11e8b558-7831-460e-acb9-eb98182f2d43.mp4
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-42366
Checklist

[ ] Gated by experimental feature flag
[ ] Unit tests updated

Merged with master, new UI:
https://user-images.githubusercontent.com/2340127/166262218-df8889ca-b867-46d6-8946-91f5b8afe19a.mp4

Merging this as status updates PR is depending on this. @abhijit-singh, we can fix UI in the next PR, since this PR is not changing the current flow


concurrency takeover safe for 6.0

Motivation:
Letting NIO take over the Concurrency thread pool is important for performance. We saw roughly 30% improvements on Linux for non-I/O code and much more for I/O code.
Modifications:
Allowlist Swift 6.0.
Result:
More perf for more versions.

Nightly failure is known and expected due to new warnings


chore(depends): Upgrade devDependencies

fixes security issue

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


refactor: ignore HTTP response errors by status code

This was broken out of #782 since it is likely to run into linting errors in files that are not directly related to the VLAN resource.

This was an extra flaky CI AccTest run, mostly around network resources but also devices that timed out during provisioning and projects not being cleaned up as a result.
Triggering a retest.

(out of pr scope)
We could avoid these in the future with a test fuzzing (ignore attribute changes within a few seconds).
=== NAME  TestAccMetalDevice_importBasic
    resource_test.go:591: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.

          map[string]string{
        - 	"updated": "2024-09-25T21:58:29Z",
        + 	"updated": "2024-09-25T21:58:30Z",
          }

Looking at the failures again, they seem relevant to the change:
=== NAME  TestAccMetalGateway_privateIPv4
    resource_test.go:15: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: Failed to delete Metal Gateway 00448d03-8c3c-446c-86b2-d8082f0a7c3d

        API Error HTTP 404 404 Not Found Not found
--- FAIL: TestAccMetalGateway_privateIPv4 (22.67s)

404s should be considered successful deletes. It wasn't picked up. This happens for a few different resource types.
A device_timeout test fails with a 403, which may be exactly what we would have expected.

404s should be considered successful deletes. It wasn't picked up. This happens for a few different resource types.


[release-v1.5] Use AllowRestrictedPodSecurityStandard in vendored creation.go

Add remaining vendor changes from https://github.com/openshift/knative-eventing/commit/6ea60fb516fc80f5db539e8ef68c1b95abe50036

/cherrypick release-v1.4

/cherrypick release-v1.6

@pierDipi Apologies for this forgotten change.


Sign-up

As a user I want to be able to sign up to the application so that I have an account to use

Acceptance criteria:  When the user inputs their password and username it should create an account and direct the user to the login page.

this issue was started to be implemented (android side) but not finished and now is out of scope, due to lack of time and also because it's not a priority


Fixes https://github.com/fastlane/fastlane/issues/10237

precheck shouldn't run during deliver init.

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

Name
File

Deliver::CommandsGenerator :init option handling can use the username short flag from tool options
commands_generator_spec.rb

Deliver::CommandsGenerator :init option handling can use the app_identifier flag from tool options
commands_generator_spec.rb

  Generated by :no_entry_sign: Danger


Failed to upgrade node group with taints

Versions

Module version [Required]: "~> 20.0"

Terraform version: v1.8.4

Provider version(s): ~> 5.50.0

Reproduction Code [Required]
module "eks" {
    source                                      = "terraform-aws-modules/eks/aws"
    version                                     = "~> 20.0"

    cluster_name                                = var.cluster_name
    cluster_version                             = var.cluster_version

    enable_irsa                                 = false
    create_node_security_group                  = false
    create_cluster_security_group               = false
    cluster_security_group_id                   = var.cluster_sg

    cluster_timeouts                            = var.cluster_timeouts

    create_kms_key                              = false
    cluster_encryption_config                   = var.cluster_encryption_config

    include_oidc_root_ca_thumbprint             = false
    create_cloudwatch_log_group                 = false
    create_cluster_primary_security_group_tags  = false
    enable_cluster_creator_admin_permissions    = false

    cluster_endpoint_public_access              = true
    cluster_endpoint_private_access             = true

    authentication_mode                         = var.authentication_mode

    create_iam_role                             = false
    iam_role_arn                                = var.iam_role_arn

    vpc_id                                      = var.vpc_id
    subnet_ids                                  = var.subnet_ids
    cluster_endpoint_public_access_cidrs        = var.cluster_endpoint_public_access_cidrs
    cluster_addons = {
        aws-ebs-csi-driver = {
            addon_version               =   "v1.29.1-eksbuild.1"
            service_account_role_arn    =   "arn:aws:iam::570318669348:role/AmazonEKS_EBS_CSI_DriverRole"
        }
    }
    # EKS Managed Node Group(s)
    eks_managed_node_group_defaults = {
        cluster_version               = "${var.cluster_version}"
        ami_type                      = "AL2_x86_64"
        capacity_type                 = "ON_DEMAND"
        create_launch_template        = false
        use_custom_launch_template    = true
        create_iam_role               = false
        iam_role_arn                  = "arn:aws:iam::570318669348:role/managed_node_group-20230117143844845900000001"
        use_name_prefix               = false
        launch_template_id            = aws_launch_template.eksManagedNodeGroupsTemplate.id
        launch_template_name          = aws_launch_template.eksManagedNodeGroupsTemplate.name
        launch_template_version       = aws_launch_template.eksManagedNodeGroupsTemplate.latest_version
        update_config = {
            max_unavailable = "1"
        }
        node_role_arn = "arn:aws:iam::xxx:role/managed_node_group-202301171438448459xxx"
  }

  eks_managed_node_groups = {
    dev_data_node_group_1 = {
      node_group_name = "dev_data_node_group_1"

      min_size     = 5
      max_size     = 5
      desired_size = 5

      labels = {
        "node-role.kubernetes.io/de"    = "de"
        "role"                          = "de"
      }

      taints = [{
        key    = "role"
        value  = "de"
        effect = "NO_SCHEDULE"
      }]

      instance_types = ["t3.xlarge"]

      launch_template_version       = "2"

    }
    dev_node_group_1 = {
      node_group_name = "dev_node_group_1"

      min_size     = 4
      max_size     = 8
      desired_size = 6

      instance_types = ["t3.xlarge"]
      launch_template_version       = "1"
    }
    dev_node_group_3 = {
      node_group_name = "dev_node_group_3"

      min_size     = 2
      max_size     = 2
      desired_size = 2

      instance_types = ["t3.2xlarge"]

      subnet_ids = ["subnet-01facb0592261f852", "subnet-0c2d089d580923efd"]
      launch_template_version       = "1"
    }
  }
}

Steps to reproduce the behavior:
 No
 Yes
Expected behavior
A node group is being created
Actual behavior
When updating a cluster, a node group with taints is not created, and the following error occurs in the AWS console:
NodeCreationFailure  - Couldn't proceed with upgrade process as new nodes are not joining node group dev_data_node_group_1
But if you create this node group without taints and then attach them, then everything will be fine.

The problem was with labels, not taints.
I had to jump onto a managed node and look at the kubelet logs
failed to validate kubelet flags: unknown '[kubernetes.io](http://kubernetes.io/)' or '[k8s.io](http://k8s.io/)' labels specified with --node-labels: [[node-role.kubernetes.io/de](http://node-role.kubernetes.io/de)]
So, as i understand it validate that is not correct only at startup, but if you add it in place it will use kubectl label nodes instead and pass it without any errors

Is anybody using taints with a custom CNI? For example, I want to create a mng with no taint to allow VPC CNI to come online and progress EKS module creation. Then I strip out the VPC CNI, add a taint for node.cilium.io/agent-not-ready: NoExecute, then install Cilium CNI. I have this working, however on subsequent plan/apply's TF wants to remove the taint since it isn't written into the mng definition of the EKS module.


Need install additional package "pwsh"

[Enter feedback here]
To execute azd command, it also needs to install additional package "pwsh", which be used in "azd up" command.
The document needs to describe this dependency.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2f283f7f-dc6c-e976-8994-7b685852b701
Version Independent ID: 2f283f7f-dc6c-e976-8994-7b685852b701
Content: Install the Azure Developer CLI (preview)
Content Source: articles/azure-developer-cli/install-azd.md
Service: azure-dev-cli
GitHub Login: @alexwolfmsft
Microsoft Alias: alexwolf

Thank you, this was removed as a dependency.
#please-close


release tgz accidentally added to git repo

An 80+ Mb release tgz was accidentally added to the repo https://github.com/logsearch/logsearch-for-cloudfoundry/blob/master/logsearch-for-cloudfoundry-boshrelease/releases/logsearch-for-cloudfoundry/logsearch-for-cloudfoundry-3.tgz
Can we remove it?
a) anyone can recreate this with bosh create release --with-tarball <path/to/release.yml>
b) people can download it from bosh.io when you get it added there

I think I did something strangely in the process, but all the other filter-branch commands from docs were rewriting the whole repository history and not just these commits. So, I've gone ahead with pushing this anyway given this whole thing is already a naughty git action.
Affected commits have been rewritten...
old commit                               rewritten to                             notes
2d812a80a0faa691efaf0e43bf7b409dbcb94a88 838770e8ee65f1608b65873b1b59f24aa627b51d
ad7adebafc9bc49874d18b2442e2a14fc664d417 96a91b5029c9e1aa7f7c262615a036d0c89a035e
d06a453ee1d45aef3859cff3c742e2a0bdaa51b8 3170b3b11e7ab671ce79ef8989541b7220be28d0 refs/tags/v3
ec5db414a8a0325559d2d6596fe022d27098bdcd 3170b3b11e7ab671ce79ef8989541b7220be28d0

Collaborators...
If your local branches include these commits, you must not merge. Instead, rebase your changes onto the rewritten commit. The following may be helpful...
First, be sure you have fetched the rewritten repository.
$ git fetch

If you see the following, you'll need to rebase.
$ git status
Your branch and 'origin/master' have diverged,
and have 5 and 3 different commits each, respectively.

You can check to see which old commit you have using the following.
$ git rev-parse $( git rev-list origin..HEAD | tail -n1 )^1
ec5db414a8a0325559d2d6596fe022d27098bdcd

Use the command's output and the table above to lookup the new commit. Then use those values in your rebase...
$ git rebase --onto 3170b3b11e7ab671ce79ef8989541b7220be28d0 ec5db414a8a0325559d2d6596fe022d27098bdcd

You should then see...
$ git status
Your branch is ahead of 'origin/master' by 2 commits.

(Also, thanks for creating the issue about it)


Create Blog “this-is-another-example”

Automatically generated by Netlify CMS

👷 Deploy Preview for famous-kulfi-ae21db processing.

Name
Link

🔨 Latest commit
53e03b5dcf5ae8a9758c88009b7d88fd4c41cc6a

🔍 Latest deploy log
https://app.netlify.com/sites/famous-kulfi-ae21db/deploys/657d9ee953b6050008d1e792


Dot syntax chaining doesn't work

So it parses dot syntax chains as left associative which is super confusing...
:tea: :seedling:

Now it does


ci: check minimal-versions on MSRV feature powerset

Inspired by #4272
Using cargo update -Z direct-minimal-versions (or cargo update -Z minimal-versions) is known to be complicated. I started playing with these and had not much success due to various combinations of dev dependencies and other edge cases.
cargo-minimal-versions worked great, however, and given it's a superset around cargo-hack which we already use in the check-feature-powerset job, I decided to just upgrade that job a bit to run a minimal-versions check on MSRV.
This caught a few extra cases where our minimal dependencies were too low.

If no concerns I'll probably merge this soon given it improves end user packaging slightly.


footer should be improved

Is your feature request related to a problem? Please describe.
yes
Describe the solution you'd like
I want to improve the footer section
Describe alternatives you've considered
improving footer section
Additional context
No response

what changes would you make?

below the icon about contact and home section should be added @wasimreja


Orphaning a resource

Is there a standard way we can orphan a resource with this operator? We want to transfer the control of our bindings and instances currently managed by BTP Operator in one cluster and move them to another cluster.
One way I was thinking is to just set the desired replicas for the operator deployment to 0, then force delete the CR from the cluster. This should work, but I wanted to know if there was any smoother way to do it (perhaps by using a paused annotation).
Thanks.

There is no feature to move resources between clusters, you can use the recovery feature to acheive it.
Note that you can "move" a resource between physical clusters but not logical clusters (cluster id for resource cannot be changed, it is part of its context).
About the way you proposed, it will not work- you will not be able to delete the resource if the operator is down (the webhook call will fail).
What you can do is install the operator with the same cluster id and recover the instances in the new cluster (NOTE - if the CRs and cluster id are not identical the recovery will not work and a new resource will be created).
To delete the CR in the original cluster remove the finalizer and after the finalizer is removed delete the resource.
Please test it on one of the resources to verify the process.


Add GCC 11.2

I re-applied the patches from GCC 10.3.0, and dropped the 0005-libstdc-futex-time64 patch, as that has made it upstream.

Closing as GCC 11.2.0 is now available.


routerEnableTracing in environment

This PR is to solve #163

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


operator-sdk bundle create --generate-only is removing the CSV and CRD's content

Bug Report
What did you do?
Run the following command for Memcached Go Sample upgraded to use SDK 0.17
 $ operator-sdk bundle create --generate-only
INFO[0000] Building annotations.yaml
INFO[0000] Generating output manifests directory
INFO[0000] Building Dockerfile

What did you expect to see?
The bundle be created successfully
What did you see instead? Under which circumstances?
The command is removing the content of the CSV in the manifest dir. See:
$ cat deploy/olm-catalog/memcached-operator/manifests/memcached-operator.clusterserviceversion.yaml
Environment

operator-sdk version: 0.17
go version: 1.3

Additional context
By @estroz :

shows that the issue is if values of --output-dir == --directory, the library overwrites the output directory and we set --ouput-dir to --directory by default to help migrate users to the new manifests/metadata format

Further clarification on the race condition: if --output-dir directory is the same as the value passed to --directory, the generation library truncates all files in that directory as a side effect of iteratively copying between the same file. This behavior could be considered a bug in the library itself since it is an edge case of copying between identical files, although --output-dir might not be intended to work in the way described. @kevinrizza thoughts?
This behavior is experienced when running operator-sdk bundle create because the output dir if unset will be set to the default manifests directory to help migrate users to the new manifests/metadata format; in case that default already exists as a valid bundle, all files in manifests get overwritten.
To fix this behavior temporarily in the SDK, it must check if a manifests directory exists already, and only set the output dir to that default value if not.

Further clarification on the race condition: if --output-dir directory is the same as the value passed to --directory, the generation library truncates all files in that directory as a side effect of iteratively copying between the same file. This behavior could be considered a bug in the library itself since it is an edge case of copying between identical files, although --output-dir might not be intended to work in the way described. @kevinrizza thoughts?
This behavior is experienced when running operator-sdk bundle create because the output dir if unset will be set to the default manifests directory to help migrate users to the new manifests/metadata format; in case that default already exists as a valid bundle, all files in manifests get overwritten.
To fix this behavior temporarily in the SDK, it must check if a manifests directory exists already, and only set the output dir to that default value if not.

This is because bundle generate was supposed to be a "run once" command. --output-dir is intended to only exist for the "I want to differentiate between my pure "manifests directory" AND my "bundle directory that includes a /manifests folder". So, you shouldn't ever set --output-dir == --manifests, because if you are then you just shouldn't set --output-dir.

Closed by #2944