zkApp transaction with empty accountUpdates gets stuck in mempool

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues
[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions

Description
The following transaction is broadcast and accepted by the node but never gets included in a block.
mutation {
  sendZkapp(input: {
    zkappCommand: {
  feePayer: {
    body: {
      publicKey: "B62qqPo32ULMxYW745CFdF1z8KAtxbT6Du7jnxVy2XWrBxryQeX72HH",
      fee: "100000000",
      validUntil: null,
      nonce: "29"
    },
    authorization: "2Xvuve2hGHS8UTZSKJrqqkySBvsM4gLz3cJns3BoYo3vtEbfKnfZqG3SHU9gLSBpjV3H7Sho3sha7wDUvqvk88wVp6mdLMt"
  },
  accountUpdates: [],
  memo: "E4Z6JXwWFiYD6n6AeZp2UsZ6qsNhpbi71SSwQyaaLKkPvckWYs23t"
}
  }) {
    zkapp {
      hash
      id
      failureReason {
        failures
        index
      }
      zkappCommand {
        memo
        feePayer {
          body {
            publicKey
          }
        }
        accountUpdates {
          body {
            publicKey
            useFullCommitment
            incrementNonce
          }
        }
      }
    }
  }
}

Steps to Reproduce
This file created the tx - wasn't intentional, and the code has been revised to correctly generate the account updates. However, it is possible to create transactions that never get included and do not get removed from the mempool.
https://gist.github.com/garethtdavies/45329cb7ab45abb2402f1420a3bb2221/cc436a37f3dc85c5b9b6f3ef818f8950f5df5647
Expected Result
The transaction is either rejected or included in a block.
Actual Result
The transaction is accepted into the mempool but never removed until it expires.
How frequently do you see this issue?
Always
What is the impact of this issue on your ability to run a node?
Low
Status
Running this version https://github.com/MinaProtocol/mina/discussions/11872

Additional information
No response

Seeing some with Invalid_fee_excess and Account_nonce_precondition_unsatisfied
    "source": {
      "module": "Staged_ledger",
      "location": "File \"src/lib/staged_ledger/staged_ledger.ml\", line 1961, characters 18-30"
    },
    "level": "Error",
    "metadata": {
      "user_command": [
        "Zkapp_command",
        {
          "zkapp_command": {
            "account_updates": [],
            "fee_payer": {
              "body": {
                "valid_until": null,
                "fee": "0.0101",
                "nonce": "5",
                "public_key": "B62qkMipWDgmFqpQdrKyKZvZWgSLR4HYqNkk5AgzXa22zUcPZoZ73r1"
              },
              "authorization": "2YUy6UkNnDAm6MGDixb8Sa98StDUYgipA7DDiiYxzGvsF9XMNhP1MhnAwZXwzKKfxEo6rNKCZkTGaSdPoXgCppQ7B1DjWMr"
            },
            "memo": "E4YM2vTHhWEg66xpj52JErHUBU4pZ1yageL4TVDDpTTSsv8mK6YaH"
          },
          "verification_keys": []
        }
      ],
      "error": {
        "string": "[[0,[[\"Invalid_fee_excess\"],[\"Account_nonce_precondition_unsatisfied\"]]]]",
        "commit_id": "[DIRTY]32a91613c388a71f875581ad72276e762242f802"
      },
    },
    "message": "Staged_ledger_diff creation: Skipping user command: $user_command due to error: $error"
  },
}

and some with only Invalid_fee_excess
{

  "jsonPayload": {
    "message": "Staged_ledger_diff creation: Skipping user command: $user_command due to error: $error",
    "metadata": {
      "error": {
        "string": "[[0,[[\"Invalid_fee_excess\"]]]]",
        "commit_id": "[DIRTY]32a91613c388a71f875581ad72276e762242f802"
      },
      "user_command": [
        "Zkapp_command",
        {
          "verification_keys": [],
          "zkapp_command": {
            "memo": "E4Z6JXwWFiYD6n6AeZp2UsZ6qsNhpbi71SSwQyaaLKkPvckWYs23t",
            "account_updates": [],
            "fee_payer": {
              "authorization": "2YDcmFCJbkJSNZrupkupAsKsvbfE9LKsZHT3YDPf7faYRkQKMUrKbNQtaEK8xuXaxHjG2dnxftZMQMW8ctFMXGkqKzJhyVL",
              "body": {
                "public_key": "B62qqPo32ULMxYW745CFdF1z8KAtxbT6Du7jnxVy2XWrBxryQeX72HH",
                "valid_until": null,
                "nonce": "29",
                "fee": "0.1"
              }
            }
          }
        }
      ]
    },
    "level": "Error",
    "source": {
      "module": "Staged_ledger",
      "location": "File \"src/lib/staged_ledger/staged_ledger.ml\", line 1961, characters 18-30"
    }
  },

Simple way to replicate using SnarkyJS:
    const transaction = await Mina.transaction(
      {feePayerKey: zkAppFeePayerPrivateKey, fee: decimalToMina(txnFee)},
      () => {
        // Empty accountUpdate[]
      },
    )
    await transaction.prove()
    const txnHash = await transaction.send().hash()

cc @mitschabaude

Such transactions could be used for replacement/cancellation

The invalid_fee_excess failure has been fixed. And the Account_nonce_precondition_unsatisfied failure is a side effect of the invalid_fee_excess.

We should verify this is fixed if possible.

Tested this here https://berkeley.minaexplorer.com/transaction/CkpYnuAeaNnLydiedtwnmSnswTe38vRh4P3h3zWsPQnFqSz2VRzcJ. So the empty account update was included in a block, which based on Deepthi's comment that these tx can be used for replacement/cancellation is likely the intended behaviour. So think this issue can be closed.


User Password update doesn't respect to beforeChangeHooks (and others)

Link to reproduction
No response
Describe the Bug
When user update the password from console, we have a beforeChangeHooks to modify the user input password, however we found that the modification doesn't work and payload updated to the original user input password.
After investigation, we found that the password is already assigned before the beforeChangeHooks run, therefore the modification doesn't work.  Currently only beforeOperationHooks can modify the password.
https://github.com/payloadcms/payload/blob/1a0ef4824b3d6548d36e7f28a2030640361c0655/packages/payload/src/collections/operations/updateByID.ts#L94
To Reproduce

Create a collection with auth
Create a new user with password '123456Aa'
Create a beforeChangeHooks: if(operation === "update") data.password = data.password + "abcd"
Login to that user and modify the password to '12345678Aa'
Logout
Login with password '12345678Aaabcd' is failed
Login with password '12345678Aa' is succeed

Payload Version
2.12.1
Adapters and Plugins
No response

@soapwong703 I have this PR open. But I am wondering, what is the use case here?
Are you going to inform the user that their password is not what they typed in?

@JarrodMFlesch Thanks for the quick update!  We are integrating payload with our own user system and the actual password are stored there, all the authenticate performs in our system before user login, thus the password on payload is not the user's actual password.


⚠ Bofrost.lu has degraded performance

In 9c7217d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1237 ms

Resolved: Bofrost.lu performance has improved in 6ba48aa.


Cannot install make on darwin 10.11

I tried to install "make" on OSX 10.11 and i'm getting the "install XCode" popup window. When I select "not now" I get the message  :
installing ‘make-1.0’
these derivations will be built:
  /nix/store/3qpj4n9fivwgff8nx5si2ydsqp1dhvi1-make-1.0.drv
building path(s) ‘/nix/store/sdx1b3lzjynrh16n1r32q49f6rc9mnk3-make-1.0’
unpacking sources
unpacking source archive /nix/store/5mp18dzcswfca57b11m3yj52nmzs53bh-gnustep-make-2.6.6.tar.gz
source root is gnustep-make-2.6.6
patching sources
configuring
configure flags: --prefix=/nix/store/sdx1b3lzjynrh16n1r32q49f6rc9mnk3-make-1.0
checking for gcc... clang
checking for C compiler default output file name...
configure: error: C compiler cannot create executables
See `config.log' for more details.
builder for ‘/nix/store/3qpj4n9fivwgff8nx5si2ydsqp1dhvi1-make-1.0.drv’ failed with exit code 77
error: build of ‘/nix/store/3qpj4n9fivwgff8nx5si2ydsqp1dhvi1-make-1.0.drv’ failed

I did a channel update nix-channel --update and it worked.
Not sure what went wrong the first time... maybe it got fixed already a few days ago ?

Could we close this?

Yes :)


Add more examples on how to use Hydrogen

We started a collection of examples in our documentation: https://nteract.gitbooks.io/hydrogen/docs/Usage/Examples.html
It would be really cool if we could add more for other languages and kernels.
Add more examples by editing this file.
Read our Contributing Guide on how to locally build the documentation website to get a preview.

I would like to have an example how to use hydrogen for R data analysis.
For python everything works perfectly like by using Jupyter, but for R I dont how to have the inline output and plots. Thanks Jai


Add support of HDFS as remote object store

Which issue does this PR close?

Closes #1060. It's a refactor version of PR #1062.
Rationale for this change

Currently, we can only read parquet files from local file system. It would be nice to add support to read parquet files that reside on HDFS.
What changes are included in this PR?

Introduced hdfs as one of the object store. With the feature of hdfs, it will depend on the fs-hdfs crate which provides the Rust client to hdfs. Then we can run some sql-based unit test with data on hdfs.
Are there any user-facing changes?

One example for querying on the hdfs data can be seen in the method of hdfs.run_with_register_alltypes_parquet in  tests/sql.rs. Firstly create a HadoopFileSystem. Then register it with hdfs scheme.

Thank you very much @yahoNanJing .
I personally would like to see such integration / connector code live in other repos (rather than a feature flag on datafusion). My primary rationale is to keep DataFusion and Ballista development easier.
DataFusion and Ballista already have fairly substantial overhead to working on this codebase, so adding another integration will make testing / coding changes in this repo take longer.
For example, I don't know how to run / test hdfs locally. I tried on this branch:
-*- mode: compilation; default-directory: "~/Software/arrow-datafusion/" -*-
cargo test --features=hdfs  -p datafusion --test sql
   Compiling fs-hdfs v0.1.3
   Compiling parquet v6.0.0
error: failed to run custom build command for `fs-hdfs v0.1.3`

Caused by:
  process didn't exit successfully: `/Volumes/RAMDisk/df-target/debug/build/fs-hdfs-e451fc9b245fa518/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'JAVA_HOME shell environment must be set: environment variable not found', /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/fs-hdfs-0.1.3/build.rs:132:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I am sure I could go figure out how to setup the HDFS dependency, but I don't have the time right now.
Putting the HDFS code in this repo will help ensure we keep DataFusion's API resonably stable as you mentioned on https://github.com/apache/arrow-datafusion/pull/1062#discussion_r741575976 and effectivly make the maintenance of the hdfs connector easier.
However, in total, I selfishly would like to optimize for the maintenance of DataFusion as it currently exists rather than the hdfs connector.
Thoughts @houqp  @Dandandan @Jimexist @rdettai ?
BTW if there is consensus for putting this code into the arrow-datafusion repo, prior I would like to see:

CI coverage (aka testing that this works as part of the github checks -- I may have missed it but I don't think this is covered now)
A developer's guide explaining how to configure / run the tests

I also prefer us maintaining these 3rd party dependency heavy extensions in separate repos. At the very least it should be managed as a separate crate. As @alamb already mentioned, the datafusion python binding and ballista crates we have right now are already slowing us down. We can link to these extensions in our readme and docs for better discovery so it's still easy for users to add. From the end user's point of view, there is not that much of a difference between adding a new feature flag v.s. adding a new dependency in Cargo.toml.

Hi @alamb and @houqp, I agree that the core of DataFusion should be as simplified as possible. However, if we position it to be used in the production environment with some large scale cluster. It's better to support some remote shared storage as part of the architecture of storage and compute separation.
If we don't include the connectors into DataFusion, it's still better to provide an official repository for them. Otherwise, it might not be good for the community unity.
By the way, for the interface of register_store in ObjectStoreRegistry, there may be several ObjectStore with different endpoints for the same scheme. For example, hdfs://localhost:60000 and hdfs://localhost:60001

I also prefer to have source/sink connectors such as S3 and HDFS in separate repo or even in separate org for fast iterations. Adding links for these connectors in DataFusion's README is sufficient for those interested in these connectors.
Maybe it's time for us to create the org @houqp mentioned https://github.com/apache/arrow-datafusion/issues/907#issuecomment-902468450, or @andygrove mentioned arrow-experiment-* https://github.com/apache/arrow-datafusion/issues/907#issuecomment-902694324 ?

FYI. Apache Pulsar has a separate repo for connectors https://github.com/apache/pulsar-connectors and a hub hosting all reference repos https://hub.streamnative.io/.

I also prefer to have source/sink connectors such as S3 and HDFS in separate repo or even in separate org for fast iterations.

I think the separate org for fast iterations is an excellent point. Shall we make one?

@yahoNanJing I agree with you that pooling these extensions into a single namespace would be better than splitting into personal namespaces. I started a discussion thread in the dev mailing list to see if it's something we could do: https://mail-archives.apache.org/mod_mbox/arrow-dev/202111.mbox/browser.

@yahoNanJing I have invited you to https://github.com/datafusion-contrib, let me know if you have access to create new repos there. If not, I can help create one for you.

I see that the support for hdfs is moved to the contrib org now that this pull request can be closed?

@yahoNanJing 's version is based on the jvm hdfs implementation I believe, so it's different from https://github.com/datafusion-contrib/datafusion-hdfs-native. I think there is still value in porting this PR into a self-contained extension repo into datafusion-contrib if @yahoNanJing is still interested in maintaining this code base as an alternative implementation.


at_hash and c_hash claims missing in id_token in OIDC hybrid flow

Steps to reproduce:
Setup OIDC Hybrid flow (https://docs.wso2.com/display/IS560/OpenID+Connect+Hybrid+Flow)
Try the code id_token flow
Check the received id_token
at_hash and c_hash claims will be missing which breaks the clients expecting it.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Related Hidden Services down?

Is this project dead or on hold?
All servers from https://github.com/Jesse-V/OnioNS-common/tree/master/src/assets are down. Am I right?

@donkfukker yes, sorry about that. I was starting a new job and I was also rewriting the code, which caused me to remove the servers from the public list.


Update to kube-prometheus-stack chart 43.2.1

Changes:
Update to Prometheus-Operator v0.61.1, Prometheus to v2.40.5 and Thanos
to v0.29.0.

By double-checking:

https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack#upgrading-an-existing-release-to-a-new-major-version

I think that we need to (part of updates from 39.x to 40.x):
kubectl delete daemonset -l app=prometheus-node-exporter

The CRD updates should be handled by Flux.

I have done:
$ kubectl delete daemonset -n prometheus -l app=prometheus-node-exporter
daemonset.apps "kube-prometheus-stack-prometheus-node-exporter" deleted


Add reason to complete function

Allow to specify the reason (or any other context options) when calling cmp.mapping.complete
fix #528

Perfect. Thank you!


Allow counter to stop the scroll

Let's say i want the marquee to scroll 3 times then just stop scrolling.
It would be nice to have :
Marquee(
  text: 'Some sample text that takes some space.',
  style: TextStyle(fontWeight: FontWeight.bold),
  **repetitionCounter: 3,**
  scrollAxis: Axis.horizontal,
  crossAxisAlignment: CrossAxisAlignment.start,
  blankSpace: 20.0,
  velocity: 100.0,
  pauseAfterRound: Duration(seconds: 1),
  startPadding: 10.0,
  accelerationDuration: Duration(seconds: 1),
  accelerationCurve: Curves.linear,
  decelerationDuration: Duration(milliseconds: 500),
  decelerationCurve: Curves.easeOut,
)

Added a PR for this feature #28

I really like this idea! Thanks for creating the PR 👍


Which functions to call for a batch-export?

Hello again!
As I wrote before (https://github.com/KhronosGroup/glTF-Blender-IO/issues/1135), I forked the Khronos exporter and extended it by a few custom functionalities. The way I did this was to copy and modify gltf2_blender_export.py and gltf2_blender_gltf2_exporter.py. From within those files, I am calling the functions and classes from the default Blender gltf Exporter. This works very well, but due to the rather complicated structure of the exporter, I'm having some trouble with the next step:
Another function I want to include in my Blender addon is the ability of a batch export of the scene. The goal is to generate multiple gltf+bin files for different LODs of the object. For this, the exporter is looking for keywords in the collections, so all objects of an LOD collection will be exported separate from other objects in other collections.
The main exporter function is the save(context, export_settings) in gltf2_blender_export.py. And I started sorting out my collections in that method. Where I'm stuck now is how I can limit the objects to export, to those in the lod collections.
I hope someone here can give me some pointers how to do this sort of batch export.

I don't believe there is any easy way to do this right now. Related issues:
#192 Export specific collection
#1073 support context override

Hi, thanks for helping out again!
It seems like the "selected objects" export works fine now. One cheeky solution would probably be to make a selection of the first collection, run the exporter with "selected objects" active, then select the next collection and export and so on.
It's just not a very elegant way to do this and I was hoping there's a more straight-forward to this by calling some functions and passing values manually.
I'm fine with the way being hard, I already forked the exporter to make some further changes, I just can't figure out in which function the exporter is actually getting the scene's data from.

Gathering the glTF data starts in gather_gltf2, which calls __gather_scene, which calls gather_node on the root objects to start gathering nodes.

Would it be possible to instantiate a new, empty, scene object and for each batch, copy the objects from the collection into this new scene - then pass the new scene to the __gather_gltf2 function?

Can't you just, like, replace blender_scene here
https://github.com/KhronosGroup/glTF-Blender-IO/blob/92a2e5d24a0de25242f6c879c13fd6a1426ce581/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py#L54
with the collection you want to export from?

I started doing that, but I keep running into issues with it. I set up a simple scene with three collections with one primitive in each of them. When I run my exporter, it generates the three gltf file, but only the first file actually contains data and only one .bin file is being generated.
While it is almost certain that I am doing things wrong, it feels to me as if the exporter doesn't quite lend itself to what I'm trying to do:
It seems that there is multiple places in multiple scripts in which the exporter is fetching data directly from the scene and it's writing that data into the files. Hence my idea to create an instance of a scene, fill it with the relevant objects and just pass that :)

I got this figured out now and I'll provide some of the insights I gained from this here. Maybe it'll help some other people who want to try a similar thing.
Instead of pursuing one of the possible solution I described above, I looked further into what @scurest described. I had my exporter working to the extend that it would create the gltf files, according to the LODs, but it wouldn't fill it with any geometry information. I wrongly concluded that it must've something to do with the scene object, hence my suggestion to create a new one. But the answer is much simpler:
the Khronos exporter was caching the result of the _gather_scene function. And so when my exporter called the function a second time, it'd skip the step.
The solution is simply to remove the @cached  property of the function, of course after modifying the function in a way scurest describes above.
So thank you again for putting me on the right track, you've been incredibly helpful!
I would provide my code, but it is very customized to our application, so I don't think it'd add more value to what has already been said above.


disable protection on mac devicelab machines

once https://github.com/flutter/flutter/issues/132700 is confirmed to be the solution, please make sure to disable it on the following machines as well:
mac-38
mac-47
mac-49
mac-34

csrutil has been disabled on all machines listed on ticket.


[Storage - Blob] BlobClient Node.js only query should work with where conditionals failing in nightly runs

Storage - Blob nightly test runs are failing with:

Error message:
Expected values to be strictly deep-equal:  '' !== '250\n'
Stack trace:
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
'' !== '250\n'
at Context. (D:\a_work\1\s\sdk\storage\storage-blob\test\node\blobclient.spec.ts:539:12)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1114923&view=results

Passed on rerun, closing and logging


Async cleanup fixes - Part 1

Explicit move semantics on task scheduling.
Context retains the background scheduler so Scheduler doesn't recycle it. Combine VectorTileTest definitions.
Prevent edge case causing captures to prevent destruction defer. De-template scheduler classes for code size.
Reset global count in Map.KeepRenderData to avoid failures in repeated test runs.

Sorry, looks like I need to set up the Qt build too...


Create ZetaTokenConsumer

Overview
Create an abstraction to make it easy for contracts to pay for the gas on the destination chain + ZetaChain fees.

rename to aaiello/zeta-444-create-zetagaspayer


"Jump back" not working with "Goto Definition"

Version: Current master HEAD - 40439d
Platform: MacOS
SublimeText version: Sublime Text 3.0 build 3143
When I go to a definition (using cmd+., cmd+g or cmd+shift+left click) in the same or different file, I'm unable to jump back to original position (using cmd+., cmd+[).
For "goto definition", I see logs like these:
** 2017-10-17 17:08:08.223231 **:
opening /Users/aps/workspace/golang/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kinesis_firehose_delivery_stream_test.go:357:5
--------------------------------

But no logs when I try to jump back.
Is this a bug, or am I doing something wrong here? Thanks!

Use the native Sublime Text feature alt+- or shift+alt+-.


runners: jlink: Make port selectable for J-Link IP

If multiple J-Links with IP support are used,
they can be selected with different ports.
The actual implementation is just using the default port.
Make the port selectable with <ip>:<port>.

@carlescufi @swinslow can you have a look?

Ping @carlescufi @kartben

@marnold-b, I am seeing the below error when trying to flash to my board. Any suggestions on how to fix this?
  File "/home/mmahadevan/zephyrproject/zephyr/scripts/west_commands/runners/jlink.py", line 34, in is_ip
    ipaddress.ip_address(ip.split(':')[0])
                         ^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

@marnold-b, I am seeing the below error when trying to flash to my board. Any suggestions on how to fix this?
File "/home/mmahadevan/zephyrproject/zephyr/scripts/west_commands/runners/jlink.py", line 253, in do_run
    ('ip' if (is_ip(self.dev_id) or is_tunnel(self.dev_id)) else 'usb') +
              ^^^^^^^^^^^^^^^^^^
File "/home/mmahadevan/zephyrproject/zephyr/scripts/west_commands/runners/jlink.py", line 34, in is_ip
    ipaddress.ip_address(ip.split(':')[0])
                         ^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

Created #80349 to fix this.

@marnold-b, I am seeing the below error when trying to flash to my board. Any suggestions on how to fix this?
File "/home/mmahadevan/zephyrproject/zephyr/scripts/west_commands/runners/jlink.py", line 253, in do_run
    ('ip' if (is_ip(self.dev_id) or is_tunnel(self.dev_id)) else 'usb') +
              ^^^^^^^^^^^^^^^^^^
File "/home/mmahadevan/zephyrproject/zephyr/scripts/west_commands/runners/jlink.py", line 34, in is_ip
    ipaddress.ip_address(ip.split(':')[0])
                         ^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

Created #80349 to fix this.

@pdgendt Yeah that make sense. Thank you!


[Elastic-SAN] BREAKING CHANGE az elastic-san: Support private endpoint, remove --tags from volume-group and volume

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

Support 2022-12-01-preview regen and rerun tests, --tags were removed by volume and volume-group
General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Elastic-SAN

@jsntcy If I remember correctly, breaking-change release needs to update major version, right?


V0.6.1 rc

Summary

This PR is a release candidate
I created a helper PR (#720) to make it easier to see the diffs in this branch w.r..t develop, but please review this one.

OK, I'll look over #720 but put comments and approvals on this PR.


Use UID other than 1000

To resolve all the issue from https://github.com/glotcode/docker-run/issues we can specify a fixed UID for the glot user which is not 1000.
By default UID is set to 1000 which also mostly corresponds to the local user UID. Because of this limits are enforced based on the resource usage of the local user + glot. Current nproc hard limit defaults to 100, and there are usually more than 100 processes running for a typical Linux desktop user. Because of that the container cannot exec any more processes and fails with: resource temporarily unavailable.
The UID in the nix definition probably shouldn't be a magic number but I know no nix to help parameterize it :)

@prasmussen please


Use release tags

It would be nice to have release tags with names equal to version (according to semver). A lot of projects do that (e.g. Backbone). Some tools like jspm can benefit from such tags.

https://github.com/jackspirou/clientjs/releases


Folder options

Would it be possible to explicitly exclude/hide certain directories (e.g. "Screenshots"), and also have the possibility to show images from all folders (instead of just from one specific at a time)? At least the latter would go pretty well with other currently requested features such as browse by tags or sort by location – especially when using multiple camera apps which use different storage areas each (think of e.g. putting large high-res photos on the external card while keeping others internal for e.g. speed issues with series).

You can already exlcude whole directories through the File Explorer.

I must have missed the File Explorer – found it now. Figured that can also be done from the context menu directly with the specific "album" open from the viewer, so count that one solved.
For the second one: Yes, that was the idea: all directories which are not hidden – or, even better, "selected directories". Think of it like "master views" or "virtual directories". If a user could define them, that would e.g. offer the possibility to join all "camera folders" to one such "master view" (aka "all photos"), have another one for e.g. "all covers" (from the music), Screenshots, etc – and then (optionally) even hide the original folders. If one wished to, it were even possible to create specific "albums" like "Vacation 2017", "Family" etc – but that part could also be left to tags (#83).

I just added the option to create Virtual Albums via settings & add paths the the virtual Album via the FileExplorer. This then creates an album with all the images from the included paths. So e.g for a "Camera" virtual album you just need to add the DCIM-folder.

Is this issue then solved?

Sorry for my late response, I just returned from vacation. That sounds great! Will have a look ASAP.
PS: Just wondering about the versionName: versionCode 29 is v1.7.2, and 30 is v1.0 – quite unusual. One would expect a "higher name". Will confuse the one or the other user :wink:


Configure Sentry

Would help with:

#29

Logged in to Sentry via my Gmail account and Google SSO, now creating a new Organization:
https://sentry.io/organizations/new/

Setting it up for Django:

I'm going to use this pattern instead to read a SENTRY_DSN environment variable:
import sentry_sdk
from sentry_sdk.integrations.django import DjangoIntegration

SENTRY_DSN = os.environ.get("SENTRY_DSN")
if SENTRY_DSN:
    sentry_sdk.init(
        dsn=SENTRY_DSN,
        integrations=[DjangoIntegration()],
        # Set traces_sample_rate to 1.0 to capture 100%
        # of transactions for performance monitoring.
        # We recommend adjusting this value in production.
        traces_sample_rate=1.0,
        # If you wish to associate users to errors (assuming you are using
        # django.contrib.auth) you may enable sending PII data.
        send_default_pii=True,
    )

Now running this:
flyctl secrets set SENTRY_DSN="..." -a pillarpointstewards

I hit http://www.pillarpointstewards.com/sentry-debug/ and it recorded an error, so this is working!


PT-152718992 Validate received block target/difficulty

[Finishes #152718992]

@zp-sd Does this need to move the persisted chain to a distinct folder in the environments i.e. similarly to https://github.com/aeternity/epoch/pull/410 ?

@lucafavatella The block structure will not change, but we will start to recalculate difficulty for every block/header (whereas we are doing this only every RECALCULATE_DIFFICULTY_FREQUENCY headers/blocks now). So validation of previously mined blocks may fail.

So validation of previously mined blocks may fail.

Does this affect loading persisted chain?
Anyway - this seems change large enough for starting mining new chain.

@lucafavatella Agree to start fresh.
@sennui What do you think?


Create widget showcase gallery

This is an initial implementation of a widget showcase gallery for the jupyter.org website.

See test page: http://sylvaincorlay.github.io/widgets.html

@fperez we discussed this in San Francisco last month.

Fantastic! I would like to user test this. Could you write up a vert short description on this PR of:

When a user gets to this page, what are they trying to do? What is their motivation, or end goal?
A short list of tasks that I can give to a user (non-technical) related to this page that I can have a user perform (while being recorded) and a set of questions they can answer while their perform those tasks.

Here is a short example:
Goal:
A user doesn't know what our widgets are, and they are trying to find out what they are.
Tasks:

Go to the jupyter.org home page and find the page about widgets.
Read the page and describe what widget are.
Based on this page, in what situations would you use widgets?
What is the leaftlet widget for?
If you wanted to use widgets, what would be your next step?

Once we have this information, I propose we merge and then I can perform the tests and post the results. Then iterate...
Also @cameronoelsen at some point, it would be great if you could take a design pass at this page.

Good idea to user test it!
It still certainly lacks some narrative text in each section (hence the "WIP").

From a user experience perspective, there are multiple links in the navbar that send the user outside of the jupyter.org website.
Both DOCUMENTATION and INSTALL go to the readthedocs documentation. Until we come up with a better way to embed this inline, I propose we remove those links from the navbar and add them to the front-page... The expectation is that the navbar items are not external links.
The NBVIEWER and BLOG items point to subdomains.We could handle this case separately...

cc @jdfreder

This seems to work well in chrome, firefox, safari, and ubuntu web browsers. Anyone who owns a windows computer can try to build it locally to try on IE.

Works with IE. Had to add a workaround for a IE11 svg scaling bug. (I truly hate IE.)

Typo in the ipyleaflet section.  After clicking on ipyleaflet on the left, the title in the middle reads "ipyleafet" - missing an L.

Fixed typo.

Reset Icon is confusing, I would use "home" or smth else.
Save Icon is confusing, I would use Download/Down Arrow .

Could the treejs be a Jupyter logo, or a sphere of Jupiter ?

Reset Icon is confusing, I would use "home" or smth else.
Save Icon is confusing, I would use Download/Down Arrow .

This is a bqplot issue. Want to open the issue in bqplot?

Could the treejs be a Jupyter logo, or a sphere of Jupiter ?

Jupiter ? ;)

Jupiter ? ;)

Yes, the planet, with the red spot. And Moooons.

Attempting a Problem Statement for this page:
I am: user of the Jupyter Notebook
I am trying to: [outcome/job]
But: [problem/barrier]
Because: [root cause]
Which makes me feel: [emotions]

Why did you close the PR?

I am: prospective user of Jupyter Notebook
I am trying to : compare it to Rstudio and other widget frameworks
But: I have to become a user to see what this widget thing is
Because: we don't have an easy way to quickly see what widgets are outside of the notebook
Which makes me feel: 😢 (until I find this page, then I feel 😀 🎆 🍰 )

Which makes me feel: sad :cry: (until I find this page, then I feel happy :grinning: :fireworks: :cake: )

:100:

Ooops did t mean to
Sent from my iPhone

On May 31, 2016, at 11:52 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:
Why did you close the PR?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@jasongrout - thanks the persona helps. I think that we should probably address the questions uses will have about comparing this to RStudio, Shiny, etc.

@SylvainCorlay is this PR in a good enough state that we could deploy it, run user tests and iterate? I can run the user tests quickly.

It would just be nice to know (document) how highlight.css has been generated.
And likely figure out  a way how reduce the html in the widget page, though I agree that in this case it can be quite hard.
Might be possible to wrap in {% markdown %}{% end%} tags, but I'm fine if this is added on the
Technical Dept sheet and opened as separate issues.

https://sylvaincorlay.github.io/bqplot.js  is 404 on your fork.

https://sylvaincorlay.github.io/bqplot.js is 404 on your fork.

Wait, no, require says its 404 but it's probably a search path, as the graph works.
Unrelated, on the Home page the "Widget" card should link to this new page.
@ellisonbg might want to enable typekit on your fork for testing.
I'm regularly confuse on the website and search the "Home" link in the nav bar, which is the Logo, but it is not "obvious", my brain often take a second or 2 to figure that out.

https://sylvaincorlay.github.io/bqplot.js is 404 on your fork.

Yeah these are search paths indeed.

how reduce the html in the widget page

In the template file itself, there is really little. The generate html is long because the json is inline.

@SylvainCorlay is this PR in a good enough state that we could deploy it, run user tests and iterate? I can run the user tests quickly.

I think that it is ok. It may require a more recent version of browsers than the rest of the website...

Unrelated, on the Home page the "Widget" card should link to this new page.

Yes, but I would make it a separate PR, making each one of the cards a link.

Merge?

Yes!
On Fri, Jun 3, 2016 at 8:07 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

Merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/pull/93#issuecomment-223605012,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0BjY0S0uRwGdpThZyMBYAjvcpOSjks5qIEMugaJpZM4IpN4e
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I"ll assume Brian is on his phone and cannot press the merge button so I'll do it for him.

Thanks so much @SylvainCorlay for pushing on this, and everyone else! I've really, really wanted this for a long time :)


haste-boot fails on Mac OS X 10.9

I installed using cabal update followed by cabal install haste-compiler. However, haste-boot fails with the following message:
Warning: Instead of 'ghc-options: -XCPP' use 'extensions: CPP'
cabal: Missing dependency on a foreign library:
* Missing (or bad) header file: HsBase.h
This problem can usually be solved by installing the system package that
provides this library (you may need the "-dev" version). If the library is
already installed but in a non-standard location then you can use the flags
--extra-include-dirs= and --extra-lib-dirs= to specify where it is.
If the header file does exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.
Command '/Users/colin/.cabal/bin/haste-inst' failed with error  code 1

Full gist: https://gist.github.com/rcolinray/9928335

Assuming this is fixed since I can't reproduce it and there's been no word that someone else can. Reopen with new repro instructions if this assumption is wrong.


Resolve "latest" to the actual version

The operator uses latest as a default (see here).
This is directly being used as the image tag.
It is best practice to not use latest as an image tag, but instead the actual version. The operator should resolve latest to the actual version of the agent.

Hey @estahn !
Since the operator releases are not in sync with the OneAgent releases setting this to a fixed version is not an option.
This field is meant to allow you specifying a specific version of the OneAgent you want to use.
However since most customers would like to have their OneAgent up to date and we also wanna provide them with the latest features we are using latest here.

@DTMad I believe you misunderstood. The operator should request the latest version from an endpoint, e.g. GitHub or Dynatrace API and use that versioning instead of the tag latest.
The tags should be immutable. We cache them hence it's a hassle to roll out a new latest tag.
Also it's against best practices.


adding cutecoder.org

Added

Link to cutecoder.org's Business section.

Changed

Renamed "Making the Switch" to "Walled Garden Farmers"
Use cutecoder.org's Programming section.

Thanks for the updates!


the total_cost and wd_cost become nan.

hi, when I test your code with train_stg1.sh and compute the teacher model. the logs show that the total_cost and wd_cost become Nan, I did not change any code.
the data and the gpu is as follows:
DATASET='coco_train2017.1@10'
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7

There is a rare case a single forward can make the loss be nan, and when it is accumulated to the moving average of total_cost and wd_cost variables, it makes the stdout being nan. We haven't fix this internal issue but it does not affect the training.

There is a rare case a single forward can make the loss be nan, and when it is accumulated to the moving average of total_cost and wd_cost variables, it makes the stdout being nan. We haven't fix this internal issue but it does not affect the training.

Thank you for your reply. In my case, It actually have a bad affect on my result. After the model is trained, when I  run 'eval_stg1.sh' , the results eg mAP, AP50... all become zero.

From your screenshot, the recall results seem correct. So I am wondering if the problem is not because of nan but others. All scripts we provided are tested before. Can you during training, the COCO eval matrics in tensorboard are correct?
If not, could you pls list all the exact commands you run. I can not inspect based on currrent information

From your screenshot, the recall results seem correct. So I am wondering if the problem is not because of nan but others. All scripts we provided are tested before. Can you during training, the COCO eval matrics in tensorboard are correct?
If not, could you pls list all the exact commands you run. I can not inspect based on currrent information

Hi，
this is my training script in 'train_stg1.sh':

this is my eval script in 'eval_stg1.sh':

I do not have much modification, only from ’model-18000‘ to ’model-6000‘：
the evaluation result is as follows:

what a strange problem!

Thanks. We haven't met this issue in our training and seems other users also do not report this. I would suggest

whether your tensorflow version (1.14) mets our listed requirement
whether you follow the right data prepartion.

No need to tune parameteres to avoid this issue, the default parameters should work.

Thanks. We haven't met this issue in our training and seems other users also do not report this. I would suggest

whether your tensorflow version (1.14) mets our listed requirement
whether you follow the right data prepartion.

No need to tune parameteres to avoid this issue, the default parameters should work.

Hi，
I have solve the porblem, I use the released branch 'dependabot/pip/tensorflow-gpu-1.15.2', and also my tf version is 1.15.2, I downgrage the tf version to 1.14.0 and the python version to 3.6.8, the NaN problem and the OOM problem is solved!
It seems that the released branch 'dependabot/pip/tensorflow-gpu-1.15.2' is not robust and still have some bugs.


Homekit Automations Failing

Homekit commands I issue (manually changing the temperature) are working. However, timed automations are not functioning and returning an error code.
Specific Logs:
[02/08/2021, 12:00:01] [HoneywellHome] "Request failed with status code 400"
(node:894) UnhandledPromiseRejectionWarning: Error: HAP Status Error: -70408
at new HapStatusError (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/util/hapStatusError.ts:15:5)
at Thermostats.apiError (/usr/local/lib/node_modules/homebridge-honeywell-home/src/devices/thermostats.ts:634:11)
at /usr/local/lib/node_modules/homebridge-honeywell-home/src/devices/thermostats.ts:261:16
at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:894) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:894) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Config:
{
"bridge": {
"name": "Homebridge ",
"username": "0E:73:7E:31::",
"port": 516,
"pin": "--"
},
"accessories": [],
"platforms": [
{
"name": "Config",
"port": 8581,
"auth": "form",
"theme": "auto",
"tempUnits": "f",
"lang": "auto",
"platform": "config"
},
{
"devices": [
{
"ipAddress": "10..1.",
"serialNumber": "VV6-US-*******",
"credentials": "eyJTZXJpYWwiOiJWVjYtVVMtS0ZBMTgxMUEiLCJOYW1lIjoiTWFzduIjoiRUNHMlBGLjAyLjA2LjAwMy4wMDAyIiwiTG9jYWxDcmVkZW50aWFscyI6IjRQVk9sbG1iUGdzWExBRzdHSHB4dytPMnZscHBrVzc4U1d5UnByOW53WGsveEprQURnTTBtMlE0aHBSMVRrY2duaWVtRm1OWmdCME4xWFJhdEQ5Ty9MQnJ2bHNVNkYvL2hvd2NJV0F5NktuajdTaVFoNXBRZTBQd0ZGMkw5Rmc5cXpMNU1DNjNCbXZGa2ZVaSs2aTNFdUVsbU5HNS**********mY3R0hFNncxYWx2eEFsRGVtalQyaSIsIkF1dG9VcGRhdGUiOnRydWUsIk5ld1ZlcnNpb25BdmFpbGFibGUiOmZhbHNlLCJQcm9kdWN0VHlwZSI6IjUyMCIsIkNvbm5lY3Rpb25UeXBlIjoid3NzIiwicGFzc3dvcmQiOiJsMjFqT1pYQWVMMDJGaFhIakZQTTROOEpSaWJRbDhDdit0aldtUmlaYUhrUVJwOW02clhaaGQ2UEpJYUk4ZkwrNENVZHpmcHgrd0JTRkNmNHRqU0Rqdz09In0=",
"enableAutoModeWhenActivating": true,
"enableOscillationWhenActivating": true,
"isNightModeEnabled": false,
"isJetFocusEnabled": false,
"isContinuousMonitoringEnabled": false,
"isTemperatureSensorEnabled": false,
"isHumiditySensorEnabled": false,
"isAirQualitySensorEnabled": false,
"isSingleSensorAccessoryModeEnabled": false,
"isSingleAccessoryModeEnabled": false,
"isFullRangeHumidity": false,
"isHeatingDisabled": false
}
],
"platform": "DysonPureCoolPlatform"
},
{
"name": "Rachio",
"api_key": "-b085-43c4--cd5f25624fc7",
"external_webhook_address": "http://104..178.44:",
"internal_webhook_port": 808,
"clear_previous_webhooks": true,
"platform": "Rachio-Platform"
},
{
"name": "HoneywellHome",
"options": {
"refreshRate": 300,
"thermostat": {
"thermostatSetpointStatus": "PermanentHold"
},
"roompriority": {
"priorityType": "PickARoom"
}
},
"platform": "HoneywellHome",
"credentials": {
"consumerKey": "urhvPtSeCA*******f5aFgKGyYOoT",
"consumerSecret": "Dxj0Q8ipnYe",
"accessToken": "10dyY1MCxgvVG8uUBihMp",
"refreshToken": "BXNZn1TP6lmZ9yAIg0Y9q"
}
}
]
}
Model: Lyric T6
Environment:

Node.js Version: v14.17.4
NPM Version: 6.14.14
Homebridge Version: 1.3.4
Homebridge Honeywell Home Plugin Version: 9.6.0
Homebridge Config UI X Plugin Version: 4.41.2
Operating System: Homebridge running on Pi

I looked through some old issues and saw that someone fixed a similar error by deleting the cache. I deleted mine and now the automations seem to be working without spitting back error codes.
Feel free to close this.
Thank you for the app!


How to open data file when use pgcontents

Hi,
when I use pgcontents as jupyter notebook's contents, I have a trouble.
I don't know how to open a data file like .csv in notebook.
When I call open("test.csv"), it just show 'No such file'.
What should I do?

@00Kai0 looks like the issue here is the same as https://github.com/quantopian/pgcontents/issues/42. When you use pgcontents as your contents manager, you're telling the Jupyter Notebook application to store notebooks and any other files you upload through the Jupyter UI in a Postgres database. That doesn't change anything about how the rest of Python works, so the open built-in function will still look at your filesystem.

@ssanderson Hi, I write some methods about how to read/save.
https://github.com/embarkchina/embarkTools.
It's not stable yet and just can read abs path.
Can't you give me some suggestions ?


some prepare_systme performance exhibits anomalies in certain scenarios.

Bevy version
main
Windows 11  rust 1.72.0
{ name: "NVIDIA GeForce RTX 4070 Ti", vendor: 4318, device: 10114, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "528.49", backend: Vulkan }
What you did
run many_foxes stress test with directional_light removed and increase foxes number to 100,000
What went wrong
some system such as prepare_cluters,prepare_fog take far more time than expected (takes 15ms in write buffer)

screenshots

I've seen the assorted prepare systems take a large amount of time in my projects as well. From what I was told, this is due to the way that they block, waiting on all data to be uploaded to the GPU.

Yup. They get blocked writing to buffers that are in use by the GPU. At some point I want to try having a rotation of buffers to see if that helps for dynamic data that is updated every frame.

I'm going to close this as "unactionable known issue", but we will keep working to improve this!


Submitting kfp pipeline with user namespace in pipeline runtime returned invalid link to experiment

Describe the issue
Submitting kfp pipeline with user namespace in pipeline runtime returned invalid link to experiment
To Reproduce
Steps to reproduce the behavior:

Create a new pipeline runtime with the user namespace populated
Open or create any pipeline
select the new pipeline runtime you just created and submit
success message, click to see your runtime job
Get error message in kfp pipeline UI saying cannot find experiment.

Screenshots or log output
If applicable, add screenshots or log output to help explain your problem.
Expected behavior
success dialog box to provide valid link to experiment in kfp ui
Deployment information
Describe what you've deployed and how:

Elyra version: 2.1.0rc1
Operating system:  linux ubuntu 18
Installation source: pypi
Deployment type: local

Pipeline runtime environment

Kubeflow Pipelines - v1.3.0

Runtime configuration settings
If the issue is related to pipeline execution, document the runtime configuration settings from the Elyra UI, omitting confidential information.

This is a known issue. As a workaround one needs to open the Kubeflow Pipelines GUI and select a namespace. Then the link does work. I couldn't find a way to make the namespace part of the URL payload - just appending namespace=... didn't do the trick.

@ptitzler - im going to take a stab at fixing this, wont spend that long on it though if i hit a wall.

Issue no longer exists to my knowledge. Elyra supports several authentication methods now with kubeflow and assuming the user is authenticated via the KFP dex portal, should be directed to their respective namespace in kubeflow and be able to view their runs/experiements via the provided link.


How to actually implement an LED light in onff_light example?

I'm confused where I would add user code to actually do something with the on/off commands are received, am I missing something from the example code?   It would seem that this is internally handled by OnOffCluster with no ability for me to observe changes like we see with other clusters like MediaPlaybackCluster.  Perhaps we could include some simple print debugging or something when the user code would be expected to interact with a physical device to make this clearer for folks?

This question has popped up before, but I can't find a link to it, and yes - we should be clearer in the examples and in a future guide as to what the user is supposed to do.
The TL;DR is: OnOffCluster is just an example implementation. You are not supposed to use it in production. Roll your own.
Longer story:
A cluster is really a combination of two things, that don't necessarily need to come together, and I'm not sure we need to provide support for the second one (see below):

Metadata. This we should gradually implement for all clusters. The on-off cluster metadata is this one.
A Handler (or AsyncHandler) implementation. This you should provide by yourself. Note that a single Handler instance can handle reads/writes/commands for multiple clusters. Or even multiple endpoints. It is really up to you how you'd like to arrange it.

Also, there are multiple places where you can plug yourself in the framework - ordered in increasing level of control and decreasing level of "out of the box" experience with the lib. It is just that currently these are not well documented. As in, e.g. you can "pass" on the whole callback (a.k.a. "Handler") approach for your custom clusters, as long as you are willing to spin your own async loop and not re-use the giant future.

Forgot to add: for the "system" clusters which are required by the Matter spec so that e.g. your provisioning works, we obviously provide both metadata and concrete Handler implementation. However for the user clusters - the things which describe your actual devices/peripherals, I'm not convinced we need to provide "ready to use" Handlers. What would they do, after all? They still need to get some sort of "user callback", so we would end up with a Handler impl (which is already a callback), that delegates to the "real" user callback. A bit pointless, specifically for "simple" user clusters.


Update to CAPI v1beta1

Towards https://github.com/giantswarm/roadmap/issues/674

Tested on gravity.


Use a helm chart to install tinkerbell stack

Description of changes:
This PR introduces helm chart for installing tinkerbell stack as it provides more configurability then static manifests
Testing (if applicable):
Created a cluster using the changes and verified everything worked as expected
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve

/lgtm


hugolib: Conditionally suppress .Site.Author deprecation notice

Suppress the .Site.Author deprecation notice unless the Author key is present and not empty in the site configuration.
Closes #12297

This may not be the most elegant solution to the underlying problem, but I think it's the simplest.


Fix issue with icons on TabView clipping with textscaling > 175%

Description

Set IsTextScaleFactorEnabled to false on the close and add button for TabView.
Motivation and Context

Fixes #1650
How Has This Been Tested?

Tested manually
Screenshots (if appropriate):

Normal:

Textscaling 225%:

/azp run


improved vertex picking, only Opengl VS Input

The new vertex picking solution raycasts from the mouse's position,
picking vertices based on

The triangle it has intersected (take the nearest triangle)
The nearest vertex to the intersection point on the triangle

This is replacing a solution that was based on how close the vertex was
to the mouse in screen space and its depth.
This commit only supports the OpenGL path in the VS Input window. I'm submitting a PR so we can start a dialog.
I have disabled vertex picking in Vulkan for now, as there are some
cross dependencies (debuguniforms.h).
It might be nice to be able to use the old solution for picking odd kinds of input like lines and points, as this won't intersect with those things at all. (Actually, my compute shader would probably crash on those inputs).
Here's a gif of it in action.

This looks good, thank you for the work and the PR! I think it looks very promising.
I've left a few notes on specific points, the main thing is that the method seems like it only handles triangle list topologies which you maybe already have a plan to fix. I think I'd want to wait until all topologies will at least work, even if it's just a fallback to the old method (presuming that makes sense). Likewise Vulkan would need to be at least the same as it was before, although I think most of your work is API agnostic so it would translate very simply over to Vulkan and with a little rejiggering to D3D11.
Other minor point - when you run clang-format-3.8 to fix the formatting (tabs vs spaces etc), please rebase that into your current commit as I like to avoid style fix commits in the history wherever possible.

@baldurk Do you happen to have a test capture for adjacencies?

@Velro I might have one for D3D11 but not for GL I'm afraid. It shouldn't be too complex to make a toy example - from memory it's not far off a triangle strip really.

Hey @baldurk don't worry about the captures, I was able to make some test cases for it. Thanks. I'm feeling pretty good about the OpenGL path, so I'm going to get going on the Vulkan path next.

@baldurk I think I am done with this PR. All three platforms are at parity with the improved picking. I'd like to tackle another task in the project now.

I'll take a proper look at this tomorrow. I notice there are some notes that VS_Out picking isn't working fully - what's involved in solving that? I don't really want to merge something in that will regress, but it's fine if it falls back in some cases so even just a check on VS_Out to fall back to the old method would be OK.

When the camera looks back on the guessed projection frustrum it doesn't
pick triangles correctly. In other words, It picks fine as long as the
viewing direction is less than 90 degrees different from the guessed
projection. I'm not too sure why it's doing that, but figured it might be a
small case. I'll give it another look this evening.
On Sep 26, 2016 1:43 PM, "Baldur Karlsson"<EMAIL_ADDRESS>wrote:

I'll take a proper look at this tomorrow. I notice there are some notes
that VS_Out picking isn't working fully - what's involved in solving that?
I don't really want to merge something in that will regress, but it's fine
if it falls back in some cases so even just a check on VS_Out to fall back
to the old method would be OK.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/baldurk/renderdoc/pull/353#issuecomment-249642290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC74_OSOx59ok6vRuRFMlNYPaadDJtlNks5quARNgaJpZM4J7NEx
.

Hey Baldur I found a fix for the VS_Out problem case mentioned earlier. The other commented problem, point meshes not picking correctly Vulkan, is a pre-existing problem I discovered while testing between my changes and before.

Thanks for the feedback. Could you upload that tesselation capture please?
I did not test the GS/DS window, so I'll take any other samples you have
for that if it's not acting correctly.
On Sep 27, 2016 12:48 PM, "Baldur Karlsson"<EMAIL_ADDRESS>wrote:

@baldurk requested changes on this pull request.
I pulled and tested this - it's a really nice improvement. I found a
couple of cases where it breaks.
It seems to be that when in the VSOut, the picking only works for rays
that are facing the same direction in z as the camera forward direction. By
that I mean, if you go and look at the object horizontally but with your
camera facing slightly positive (along with the direction of the frustum),
only the right side of the screen with vectors also going along with
the frustum direction will pick. If the camera turns to the side and faces
slightly negative, only vectors going against the frustum will work. I
think it's probably just an extra sign flip that needs to be accounted for
depending on the ray direction, but it's worth taking a look.
I also found some behaviour I'm having a harder time nailing down and
understanding, but it seems like there are cases where the picking fails on
GS/DS output and I'm not sure why. I can upload a sample tessellation
capture on D3D11 for you to look at if it would help, it seemed to happen
for me to varying degree on most of the tessellation outputs that I checked.
btw I noticed while testing a couple of things that were already broken in
current master. The picking doesn't properly set w=1 for the unproject=0
case, so the divide by w can screw up vertexdata if it's set to something
other than 1.0f. It also doesn't account for the base index/base vertex
offsets in the drawcall. Once your PR is merged I can fix those though, it
was broken before so it doesn't have to be fixed in this PR.

In renderdoc/data/glsl/debuguniforms.h
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

@@ -130,17 +130,28 @@ BINDING(0) uniform FontUBOData
}
INST_NAME(general);

+#define MESH_OTHER 0    // this covers points and lines, logic is the same
+#define MESH_TRIANGLE_LIST 1
+#define MESH_TRIANGLE_STRIP 2
+#define MESH_TRIANGLE_FAN 3
+#define MESH_TRIANGLE_LIST_ADJ 4
+#define MESH_TRIANGLE_STRIP_ADJ 5
These defines should go with the rest of the type/enum kind of defines at
the bottom of the file.
In renderdoc/data/glsl/mesh.comp
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

{

	vertid *= 2;

	vertid0 = vertid;

	vertid1 = vertid+2;

	vertid2 = vertid+4;

	break;

}

}

vec4 pos0 = meshpick.use_indices != 0u ? vb.data[ib.data[vertid0]] : vb.data[vertid0];
vec4 pos1 = meshpick.use_indices != 0u ? vb.data[ib.data[vertid1]] : vb.data[vertid1];
vec4 pos2 = meshpick.use_indices != 0u ? vb.data[ib.data[vertid2]] : vb.data[vertid2];

+#ifdef VULKAN

if(meshpick.unproject == 1u)
{

spaces used here instead of tabs. As I mentioned I don't have clang-format
to apply to the shaders unfortunately, but at least it should be consistent
within a file.
There are a couple of other places in the shaders the same - double check
the indentation all matches.
In renderdoc/data/hlsl/mesh.hlsl
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

@@ -120,25 +120,199 @@ wireframeV2F RENDERDOC_WireframeVS(float3 pos : POSITION, uint vid : SV_VertexID
return OUT;
}

+#define MESH_OTHER 0    // this covers points and lines, logic is the same
+#define MESH_TRIANGLE_LIST 1
+#define MESH_TRIANGLE_STRIP 2
+#define MESH_TRIANGLE_FAN 3
+#define MESH_TRIANGLE_LIST_ADJ 4
+#define MESH_TRIANGLE_STRIP_ADJ 5
These #defines can go in the same kind of header as they do in glsl - in
debugcbuffers.h. It's included from both mesh.hlsl and d3d11_analyse.cpp
(although in that case it's included half way down the file for.... no good
reason. You can just move it to the top, but place it on a new section with
a space between it and the 'real' includes just so it doesn't affect
anything outside the .cpp).
In renderdoc/data/hlsl/mesh.hlsl
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

[numthreads(1024, 1, 1)]
void RENDERDOC_MeshPickCS(uint3 tid : SV_DispatchThreadID)
{

if (PickMeshMode == MESH_OTHER)
{

defaultPath(tid.x);

}
else
{

trianglePath(tid.x);

}
+}

+//
+//
+//
+/*
Commented code like this can be deleted, we always have source control if
we need it again (and it's in defaultPath() anyway 😄).
In renderdoc/driver/d3d11/d3d11_analyse.cpp
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

{

case eTopology_TriangleList:
{

 cbuf.MeshMode = MESH_TRIANGLE_LIST;

 break;

};
case eTopology_TriangleStrip:
{

 cbuf.MeshMode = MESH_TRIANGLE_STRIP;

 break;

};
case eTopology_TriangleFan:
{

 cbuf.MeshMode = MESH_TRIANGLE_FAN;

 break;

};

It doesn't matter either way so you don't need to delete this code, but
just FYI fans are not supported on D3D or Vulkan so this won't actually get
hit.
In renderdoc/driver/gl/gl_debug.cpp
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906:

@@ -1007,6 +1007,7 @@ bool GLReplay::GetHistogram(ResourceId texid, uint32_t sliceFace, uint32_t mip,
return true;
}

+// TODO: VS_Out triangles doesn't pick correctly if you look back on the frustrum, (gl as well)
This TODO can be deleted right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/baldurk/renderdoc/pull/353#pullrequestreview-1757906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC74_Hl_5SBnxcHf2ZZCHlpi7PplrccTks5quUj0gaJpZM4J7NEx
.

Here's a very simple capture from the DX SDK: DetailTessellation.zip. The GS/DS Out sometimes picks, but sometimes there are areas where it doesn't - it's a bit inconsistent.
Here's a more complex one from a Unity DX11 demo: http://renderdoc.org/SailShip.rdc.zip. If you go to EID 3871, from some angles the picking seems to break down. In the default camera it works OK but from this angle it seems like no vertices will pick:

This is now working for the cases you described.

Merged in by hand to rebase it onto master rather than merging.
Thank you very much! This is a great new feature :smile:.


Emoji keyboard makes logout in Ubuntu really slow

When the emoji keyboard process is running, logout is really slow for some reason. (takes too long to kill the process?)

There was a bug with signal handling, it may have caused this. Try latest release, should be fixed.

That works, thanks!


Background enhancement :  Adding Particles.js in background

Sorry, but I want to keep project minimalist wherever possible.
No need of particle.js for now.


landing page: redesign details section and move key details to sidebar

closes #1061
Moved all one level details + subjects & upload information to the sidebar. Moved 'additional descriptions' to the description section:

New layout for the details section (heads-up: very open to discuss this solution. Let me know!):

Thanks for the feedback! The spacing and the rest of the headlines I will fix as part of another task (#1062). I'll test your suggestions for the details section and sidebar-details! :-)

Updated design after review (discussed in person). Still open for changes (See last section for other suggestions). Let me know!
Changes

Moved more details to the side bar (Funding, dates - part of the details-section in the side bar, identifiers - including DOI).
Redesigned details section in the main section. Displayed with tabs (Related works & References). To be discussed if some content should move back to the main section from the side bar.
Renamed details section in the main content to avoid having two sections with the same headline.
Moved additional titles to accordion on the main title.
Added keyboard accessibility for accordions and tab menus.

Note: Headlines for all sections (e.g. "Description" and spacing will be fixed as part of another task (#1062)
Current design
Additional titles

Additional descriptions (part of the main description)

Main details section - Additional data (with context.)

Side bar (with context.)

Contributors section, spacing & headlines for the main section will be fixed as part of other tasks.
DOI-label is not visible here as I was not able to show it (not working yet?), but can be expected as the first element of the "Identifiers"-box

Alternative suggestions
Additional titles more visible

Related works & References as direct part of the main content

This PR/branch is included in #1099

#1099


Cant import APIS to micogateway 3.0.1

we cant import APIs to the micro gateway v3.0.1.When we use the import command it gives an error
micro-gw import -l CALCULATING calculator
Enter Username:
admin
Enter Password for admin:
Enter APIM base URL [https://localhost:9443]:
You are using REST version - v0.14 of API Manager. (If you want to change this, go to <MICROGW_HOME>/conf/toolkit-config.toml)
Enter Trust store location: [lib/platform/bre/security/ballerinaTruststore.p12]
Enter Trust store password: [ use default? ]
micro-gw: Internal error occurred while executing command. - Error occurred while creating oAuth application Status code: 500

@ShanJayaweera Shall we move the issue to the product-mgw repo and close this issue?

@rmsamitha Ok. I'll move the issue to the repo product-mgw


Adds conversions to and from JSON

A big driving force behind http-types was the desire to share repeated logic between Tide and Surf, and in the process establish common idioms for web protocols. So far we've covered headers and URLs, but bodies are part of that as well.
So far for Body we have Body::from_string and Body::into_string with the corresponding Request::body_string and Response::body_string methods. This adds a parallel path for that for JSON as well. This is the first step to bringing us on par with surf's conversions.
Future directions
After this patch we should probably fill out the rest of the chart:

text/plain
octet-stream
JSON
www-form-encoding
mime detection

Body::from_string
Body::from_bytes
Body::from_json
Body::from_form
Body::from_file

Body::into_string
Body::into_bytes
Body::into_json
Body::into_form
Body::into_file

Request::body_string
Request::body_bytes
Request::body_json
Request::body_form
Request::body_file

Response::body_string
Response::body_bytes
Response::body_json
Response::body_form
tbd

This will make implementing these methods in both Tide and Surf significantly easier, making it so we only need to forward function calls. Thanks!

This is a sibling PR to https://github.com/http-rs/http-types/pull/100

similar to #106, this seems like it could benefit from using impl TryInto<Body> wherever impl Into<Body> is currently accepted?

@jbr oh yeah that's much better. Updating the patch!

finished implementing the full conversion chart. The method overview in Body looks quite nice now:


Not recognicing $HOME when used with cd -f

When using the variant with cd -f, rpg does not recognice $HOME so no healing will be done anymore.

What version are you trying this on? it should have been fixed in 1.0.1

Ah, yes. I use the version from Gentoo, which is 1.0.0


Bin firmware file

Please provide bin file for updates without cc debugger too.
(As mentioned here: https://github.com/Koenkk/zigbee2mqtt/issues/320)

Yes please, flashing with an Arduino is a hassle. The SerialBootTool is much better.

Done!

For router as well

@Koenkk could you please provide the bin files for the CC2531 router too?

@ptvoinfo would it be possible to provide this?

@Anon0ne It is here: https://ptvo.info/cc2531-based-router-firmware-136/

@Koenkk @ptvoinfo I think I noticed that the bin files wouldn't make sense for the router. I tried flashing a router to a coordinator (with SerialBootTool) and I experienced that the USB port of the router doesn't get recognized on multiple machines.
So my guess would be that the router firmware doesn't include the needed USB port connection to be able to use the SerialBootTool. Is that true?

@h4nc The router firmware does not include USB features because it is useless for a router. Also, SerialBootTool cannot upload new firmware through USB.

@ptvoinfo thanks for your answer.

The router firmware does not include USB features because it is useless for a router.

Ok, so it absolutely makes sense that there are no bin files available for the router firmware, because updating a router with the SerialBootTool wouldn't work. I only see one case that could work. Flashing a coordinator to a router. But I understand that it doesn't make much sense to provide files for this case, because flashing would be one way (meaning if it would work you couldn't flash it again with the SerialBootTool).

Also, SerialBootTool cannot upload new firmware through USB.
You mean that the SerialBootTool is only able to update devices and not to do the very first flashing process, right?

@ptvoinfo thanks for your answer.

The router firmware does not include USB features because it is useless for a router.

Ok, so it absolutely makes sense that there are no bin files available for the router firmware, because updating a router with the SerialBootTool wouldn't work. I only see one case that could work. Flashing a coordinator to a router. But I understand that it doesn't make much sense to provide files for this case, because flashing would be one way (meaning if it would work you couldn't flash it again with the SerialBootTool).

Also, SerialBootTool cannot upload new firmware through USB.

You mean that the SerialBootTool is only able to update devices and not to do the very first flashing process, right?

@h4c SerialBootTool: Yes, the previous flashed firmware should support it. It works through UART pin P02&P03 (not USB).

It works through UART pin P02&P03 (not USB).

With that you mean the first/previous flashing process needs to be done through UART (for example with the CCDebugger), right?
Afterwards you can use the SerialBootTool which works with USB (of course only if the firmware supports it -> coordinator)

It works through UART pin P02&P03 (not USB).

@ptvoinfo With that you mean the first/previous flashing process needs to be done through UART (for example with the CCDebugger), right?
Afterwards you can use the SerialBootTool which works with USB (of course only if the firmware supports it -> coordinator)

@h4nc Generally, the first time you should flash using CCDebugger (or alternative flashing method). CCDebugger does not use UART pins. Afterward, you can use the SerialBootTool tool.

@ptvoinfo thanks for clearing that up and sorry that I got your last message wrong. So the SerialBootTool works with UART. I was confused by

(not USB)

And I just reread this:

ZNP firmware for cc253* has a built-in bootloader that can be used to updated firmware via USB / UART into the cc2531 stick


Bluetooth a2dp_source program works with Echo Dot on ESP-IDF v3.2.2 but not with v4.0 (IDFGH-3114)

Environment

Development Kit: HiLetgo / NodeMCU ESP32

Module or chip used:  ESP32-WROOM-32 / ESP32D0WDQ6

IDF versions:

v4.2-dev-1126-gd85d3d969
v4.0
v3.2.2

Build System: Both Make and CMake / idf.py

Compiler versions:

xtensa-esp32-elf-gcc (crosstool-NG esp-2020r1) 8.2.0 (for v4.2)
xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0 (for v4.0)
xtensa-esp32-elf-gcc (crosstool-NG esp-2020r1) 8.2.0 (for v3.2.2)

Operating System: Linux

Using an IDE?: No

Power Supply: USB

Problem Description
The Bluetooth a2dp_source example connects successfully to Echo Dot with ESP-IDF v3.2.2, but fails to do so with v4.0 or v4.2 (current master branch).
For more information, see https://esp32.com/viewtopic.php?f=13&t=14888
I recently tried to simplify the a2dp_source example to see if I could figure out more about the cause of the problem.
I can spend some more time looking into this issue, but I'm running out of things to try. My next idea is to start comparing the differences in Bluetooth source between v3.2.2 and v4.0, but I think that may be a major effort. I've tried enabling the verbose mode for all the Bluetooth logging, but aside from some general patterns about what works and what doesn't I can't really spot the problem. Is there any way to see just what's "going over the wire" between the ESP32 and the Echo Dot, so I can compare the difference between a working environment and a failing one?
Expected Behavior
To pair the a2dp_source with an Echo Dot as a sink and use it as a Bluetooth speaker that I can send audio data to.
Actual Behavior
It pairs successfully, but the MEDIA_CTRL_START command fails after about 15 seconds (in later versions of ESP-IDF).
Steps to reproduce
It is possible to reproduce this problem using the ESP-IDF a2dp_source example as well as the  stripped-down version I've attached.

Go into the Alexa app and disconnect and forget the a2dp_source to return to a known starting condition. This may require unplugging / replugging the Echo Dot while the ESP32 is powered off.

For the a2dp_source, replace ESP_SPEAKER with the name of the Echo Dot. For my stripped-down version, fill in the six byte Bluetooth Device Address (BDA).

Compile and flash the standard a2dp_source example, or the version I've attached. Tell the Echo Dot to pair.

With ESP-IDF v3.2.2 it pairs successfully, including disconnecting and reconnecting. On ESP-IDF v4.0 (or v4.2 current master) it pairs but it fails to start the audio stream.

Code to reproduce this issue
This is the basic logic. See attachment for the delay function and a2dp_callback and event formatting functions. It's also possible to recreate the problem using the standard a2dp_source example.
#define $ ESP_ERROR_CHECK
void app_main()
{
    esp_log_level_set("phy_init", ESP_LOG_INFO);

    nvs_flash_init();
    $(nvs_flash_init());

    esp_bt_controller_config_t bt_cfg = BT_CONTROLLER_INIT_CONFIG_DEFAULT();
    $(esp_bt_controller_init(&bt_cfg));
    $(esp_bt_controller_enable(ESP_BT_MODE_CLASSIC_BT));
    $(esp_bluedroid_init());
    $(esp_bluedroid_enable());

    $(esp_bt_dev_set_device_name("ESP32"));
    $(esp_a2d_register_callback(a2dp_callback));
    $(esp_a2d_source_register_data_callback(data_callback));
    $(esp_a2d_source_init());

#if ESP_IDF_VERSION_MAJOR > 3
    esp_bt_gap_set_scan_mode(ESP_BT_CONNECTABLE, ESP_BT_GENERAL_DISCOVERABLE);
#else
    esp_bt_gap_set_scan_mode(ESP_BT_SCAN_MODE_CONNECTABLE_DISCOVERABLE);
#endif

    esp_bd_addr_t echo_dot;
    echo_dot[0] = 0x0c;
    echo_dot[1] = 0xee;
    echo_dot[2] = 0x99;
    echo_dot[3] = 0x26;
    echo_dot[4] = 0x2d;
    echo_dot[5] = 0x81;

    delay(30, "Please place the speaker in pairing mode");
    $(esp_a2d_source_connect(echo_dot));
    delay(10, "Please wait for device to connect");
    $(esp_a2d_media_ctrl(ESP_A2D_MEDIA_CTRL_CHECK_SRC_RDY));
    delay(5, "Please wait for response from check-source-ready");
    $(esp_a2d_media_ctrl(ESP_A2D_MEDIA_CTRL_START));
    delay(10, "Please wait for data to stream");
    $(esp_a2d_media_ctrl(ESP_A2D_MEDIA_CTRL_CHECK_SRC_RDY));
    delay(5, "Please wait for response from check-source-ready");
    $(esp_a2d_media_ctrl(ESP_A2D_MEDIA_CTRL_STOP));
    $(esp_a2d_source_disconnect(echo_dot));
    delay(10, "Please wait for restart");
    esp_restart();
}

Debug Logs
One difference in the successful version is that MEDIA CTRL ACK event occurs very shortly after starting the audio:
W (46932) MAIN: a2dp_callback event=ESP_A2D_MEDIA_CTRL_ACK_EVT
W (46932) MAIN: a2dp_callback cmd=ESP_A2D_MEDIA_CTRL_START
W (46942) MAIN: a2dp_callback status=ESP_A2D_MEDIA_CTRL_ACK_SUCCESS
W (46942) MAIN: a2dp_callback event=ESP_A2D_AUDIO_STATE_EVT
W (46952) MAIN: a2dp_callback state=ESP_A2D_AUDIO_STATE_STARTED
W (46962) MAIN: a2dp_callback remote_bda=0xc:0xee:0x99:0x26:0x2d:0x81

Whereas in the failing version, it is delayed for about 15 seconds
W (62012) MAIN: a2dp_callback event=ESP_A2D_MEDIA_CTRL_ACK_EVT
W (62022) MAIN: a2dp_callback cmd=ESP_A2D_MEDIA_CTRL_START
W (62022) MAIN: a2dp_callback status=ESP_A2D_MEDIA_CTRL_ACK_FAILURE

Other items if possible

The Echo Dot can act as both a Bluetooth source (i.e. to an external speaker) as well as sink (i.e. from a laptop or phone, or an ESP32 source). I realize that the a2dp_source example is not expected to have this dual mode capability, but I wonder if the presence of it on the Echo Dot causes trouble for the ESP32 to connect as a source. I imagine that the Echo Dot figures out it is supposed to work as a sink when pairing with the ESP32 because of the Class of Device bits the ESP32 sends. Has anyone tested a2dp_source with devices that have this dual capability?
As mentioned in the referenced forum post, I can connect without any issues to the Echo Dot from a laptop or phone. The Echo Dot is a current (v3) model.
I get a sense from forum posts that others have had similar trouble sending data from an ESP source to Bluetooth speakers. One solution is to try other Bluetooth speakers until you find one that works, but it's hard to develop a product based on the ESP32 without confidence that it will work with a broad range of customer's Bluetooth speakers. It would be great to get this working. Let me know how I can help.

attachments.zip

Just verified that the simplified a2dp_source example also works with ESP-IDF v3.3.2 (as well as v3.2.2) so the changes that causes it to no longer work was introduced between v3.3.2 and v4.0.

I'm attempting to do a git bisect to see if I can figure out which change causes it to no longer work.
However, it's hard to figure out the toolchain requirements (e.g. compiler and python script versions) for each of the intermediate commits.
I've tried various combinations of my existing v3.2.2, v3.3.2, v4.0 and v4.2 toolchains, but the make process complains about mismatches and unexpected version numbers (e.g. IDF_TOOLS_PATH must go with IDF_PATH, which must meet the Python requirements).
The brute force approach would be to install the toolchain for each of the 10-ish bisect points, but I wanted to make sure I wasn't overlooking an easier way?

I made some progress with the git bisect and I'm down to about 30 commits. It looks like the program stops connecting to the Echo Dot somewhere between commit ab672a5ee (344 commits beyond v4.0-dev) and commit g603d29336 (375 commits beyond v4.0-dev).

The problem commit is 603d293. The program connects to the Echo Dot in commit 8b2128ce0 (372 commits beyond v4.0-dev) and fails to connect in commit 603d293 (375 commits beyond v4.0-dev). The three commits between them were all part of branch that was merged into v4.0-dev on Apr 15, 2019. This branch contains the AVRCP Target APIs and included a lot of modifications (32 changed files with 2,445 additions and 468 deletions).

Commit 603d293 adds AVRCP target support. Amongst other functions, this allows a remote A2DP sink (like the Echo Dot), acting as an AVRCP controller, to remotely control an A2DP source (like an ESP32), acting as an AVRCP target. An example of this would be to set the volume at the ESP32 source using the volume control buttons on the Echo Dot sink.
The ESP-IDF a2dp_sink example illustrates use of the AVRCP target support (i.e. the other way around), specifically to allow the A2DP sink to be controlled as an AVRCP target. In conjunction with this, the ESP-IDF a2dp_source example illustrates how to implement an AVRCP controller, but it also seems to have some AVRCP target code in it that looks like it is non-working (see https://esp32.com/viewtopic.php?t=14888).
Although highly speculative, my current hypothesis is that commit 603d293 changed the previous default "no-AVRCP-target" behavior in such a way that during the connection process, the Echo Dot (as an AVRCP controller) detects that the ESP32 A2DP source is an AVRCP target, but doesn't get back what it expects.
I assume that use of the AVRCP feature is optional and that an A2DP source application should work without using AVRCP. However to test this, I added a simple AVRCP target, and found that it was also not able to play to the Echo Dot.
$(esp_avrc_tg_init());
$(esp_avrc_tg_register_callback(avrcp_tg_callback));
esp_avrc_rn_evt_cap_mask_t evt_set = {0};
esp_avrc_rn_evt_bit_mask_operation(ESP_AVRC_BIT_MASK_OP_SET, &evt_set, ESP_AVRC_RN_VOLUME_CHANGE);
$(esp_avrc_tg_set_rn_evt_cap(&evt_set));

So to net things out: ESP-IDF Bluetooth A2DP source support stopped working for some classes of Bluetooth devices (like the Echo Dot), at commit 603d293,

Hi @tonystuart
Thanks for all your info!
We have an internal test case to test with the A2DP and AVRCP. We will look into the issues.
Thanks
Weitianhua

Thanks! Let me know if you need any more info.

@tonystuart Please update the latest branch to see if the issue still there.

Hi @tonystuart
I agree with your opinion that A2DP can be used without AVRCP and this is what we have done on:
release/v4.2 commit: 84cda60478d7a657be039339c706f4366ee2e861
release/v4.0 commit: 53c57cf2a3dbdd71957c45002371f1c0d94b9bd7
The strategy now is that you can use A2DP without AVRCP, but if you want to use AVRCP, you must initiate AVRCP before A2DP and must use A2DP at the same time. May this change help you.
Thanks

Hi @tonystuart
I agree with your opinion that A2DP can be used without AVRCP and this is what we have done on:
release/v4.2 commit: 84cda60478d7a657be039339c706f4366ee2e861
release/v4.0 commit: 53c57cf2a3dbdd71957c45002371f1c0d94b9bd7
The strategy now is that you can use A2DP without AVRCP, but if you want to use AVRCP, you must initiate AVRCP before A2DP and must use A2DP at the same time. May this change help you.
Thanks

Thanks for reporting, feel free to reopen.

Thanks for reporting, feel free to reopen.

Hi @tonystuart
We have tested the Echo Dot (3rd Gen), but no such issue happens.
Thanks

Hi @tonystuart
We have tested the Echo Dot (3rd Gen), but no such issue happens.
Thanks


Emulation problems on Win95

I've been having too many issues trying to run Shivtanium on my old Win95 personal computer.

If you tap now to watch a short video, you'll receive 30 minutes of ad free music.

Shvitanium requires Windows NT


Add automatic module name for runtime jar (#1)

This commit fix the issue https://github.com/Vankka/DependencyDownload/issues/1 by add in manifest the module name.
This change keep the compatibility with non modular system, but add compatibility with modular system.
Now, we can add "requires" in module-info.java for this libraries

Thank you for your contribution


almost impossible to build the app

Too many discrepancies between your blog and the real environment, it's almost impossible to build the app.

Yes currently the hub console has changed a lot. We are pending some more updates then I will get this updated. For now you can easily integrate Pinpoint and Push in AWS Amplify


[1.18.2] Stuck during world generation process with latest mod version

This was concluded with only the HT Tree Chop mod in the mod folder.
Mod version: TreeChop-forge-1.18.2-0.17.3.jar
Forge version: 40.2.1
Minecraft logs: https://mclo.gs/8jneNPd
It spams the logs with the same error message : "Duplicate Capability Key: minecraft:treechopchop_settings_capability"

Grrr. Sorry about that, I’ll get it fixed

Hopefully fixed in 0.17.3b, just posted.

Fixed indeed!
Thank you very much!


Prepare for release v1.8.11

Summary of Changes
Minor Changes:

Envoy use of original source address in upstream connetions is disabled when datapath is tunneling. (Backport PR #16497, Upstream PR #14594, @jrajahalme)
Update k8s libraries to 1.18.19 (#16249, @nathanjsweet)

Bugfixes:

[v1.8] bpf: unconditionally enable tail calls in bpf_lxc (#16965, @kkourt)
bpf: fix hw_csum issue for icmp probe packets (Backport PR #16655, Upstream PR #16604, @borkmann)
DNS proxy is now more available during Cilium restarts, including upgrades. (Backport PR #16745, Upstream PR #16391, @jrajahalme)
Fixed bug causing policy realization being skipped in some scenarios with endpoint identity churn. (Backport PR #16497, Upstream PR #16271, @jrajahalme)
Ignore K8s namespace events that have the same labels (Backport PR #16497, Upstream PR #16268, @aanm)
pkg/option: Fix default assignment of EnableWellKnownIdentities (Backport PR #16655, Upstream PR #16434, @mauriciovasquezbernal)
Remove previous PERM ARP entries installed by Cilium when kube-proxy-replacement and IPSec are disabled. (#15993, @aanm)

CI Changes:

ci: restart portmap service on CI nodes (Backport PR #16655, Upstream PR #16506, @nebril)
Fix and add more commands in CI sysdumps (Backport PR #16912, Upstream PR #16721, @aanm)
Improve ipsec compile-time testing in CI (Backport PR #16276, Upstream PR #15872, @joestringer)
node-neigh: Fix concurrent arping update unit test flake (Backport PR #16655, Upstream PR #16578, @brb)
node-neigh: Fix unit test flake (Backport PR #16276, Upstream PR #16072, @brb)
node: fix arpping test (Backport PR #16497, Upstream PR #16432, @jibi)

Misc Changes:

Add missing bpftool map dumps (Backport PR #16497, Upstream PR #16055, @h3llix)
build(deps): bump actions/download-artifact from 2.0.9 to 2.0.10 (#16593, @dependabot[bot])
build(deps): bump actions/upload-artifact from 2.2.3 to 2.2.4 (#16580, @dependabot[bot])
build(deps): bump docker/build-push-action from 2.4.0 to 2.5.0 (#16329, @dependabot[bot])
build(deps): bump docker/build-push-action from 2.5.0 to 2.6.1 (#16785, @dependabot[bot])
build(deps): bump docker/login-action from 1.9.0 to 1.10.0 (#16639, @dependabot[bot])
build(deps): bump docker/setup-buildx-action from 1.3.0 to 1.4.1 (#16684, @dependabot[bot])
build(deps): bump docker/setup-buildx-action from 1.4.1 to 1.5.0 (#16761, @dependabot[bot])
build(deps): bump docker/setup-buildx-action from 1.5.0 to 1.5.1 (#16854, @dependabot[bot])
build(deps): bump helm/chart-testing-action from 2.0.1 to 2.1.0 (#16314, @dependabot[bot])
build(deps): bump helm/kind-action from 1.1.0 to 1.2.0 (#16708, @dependabot[bot])
Clarify one-time setup for backporting (Backport PR #16497, Upstream PR #16016, @christarazi)
contrib/docs: rename 'cilium-actions.yml' with 'maintainers-little-helper.yaml (Backport PR #16912, Upstream PR #16750, @aanm)
contrib: Explicitly set remote for backport branches (Backport PR #16912, Upstream PR #16804, @twpayne)
contrib: Identify upstream commits by author and date (Backport PR #16655, Upstream PR #16572, @pchaigno)
contrib: Make upstream commit check more generic (Backport PR #16276, Upstream PR #16160, @joestringer)
contrib: simplify check-docker-images script (Backport PR #16497, Upstream PR #16176, @aanm)
daemon: Improve logging of device auto-detection (Backport PR #16497, Upstream PR #16118, @brb)
docs: add a "Copy Commands" button for shell-session snippets (Backport PR #16497, Upstream PR #16408, @qmonnet)
docs: add ids to the list of special identities (Backport PR #16276, Upstream PR #16123, @bmcustodio)
docs: Clarify coordination for backporting process (Backport PR #16276, Upstream PR #15989, @christarazi)
docs: document the policy for backporting documentation changes (Backport PR #16497, Upstream PR #16137, @qmonnet)
docs: ENIs should not be managed by the OS (Backport PR #16497, Upstream PR #16186, @gandro)
Improve author attribution scripts (Backport PR #16276, Upstream PR #15899, @joestringer)
k8s: Fix logging (Backport PR #16655, Upstream PR #16530, @jrajahalme)
Misc. GH workflow improvements and hardness (Backport PR #16962, Upstream PR #16908, @aanm)
pkg/k8s: add pod IP event change (Backport PR #16797, Upstream PR #16190, @aanm)
release: Automate image digest PR creation (Backport PR #16465, Upstream PR #15818, @joestringer)
Specify scrape interval for Hubble metrics (Backport PR #16276, Upstream PR #16214, @christian-2)

Other Changes:

.github: Rename maintainer's little helper's config file (#16455, @pchaigno)
[v1.8] ipam: Add extra debug info when blacklisting routes (#16678, @christarazi)
install: Update image digests for v1.8.10 (#16132, @joestringer)
test: Redeploy registry during Vagrant provision (#16379, @nebril)
v1.8 backport: ci: Disable NFS locking (#16970, @kkourt)

test-backport-1.8


Custom boolean type converters behave strangely

As raised on the picocli mailing list by Sven K. (Many thanks!)
Problems

Custom type converters for primitive boolean.class (Boolean.TYPE), registered with CommandLine.registerConverter, appear not to be invoked, resulting in errors that the custom value cannot be converted to boolean.

Custom type converters for java.lang.Boolean, are invoked twice, once with the original value provided on the command line, and a 2nd time with the String value of the conversion result. (E.g. if 123 is converted to true, the converter is called once with 123 and again with true.)

Reproducer project: https://codeberg.org/sven.k/picocli-reproducer
Main class: https://codeberg.org/sven.k/picocli-reproducer/src/branch/master/app/src/main/java/org/example/ConverterDemo.java
Analysis
Problem 2:
The reason why the converter for java.lang.Boolean is invoked twice:
There is special logic for boolean values that determines the boolean value of the command line argument, changes it to its opposite if the option is negatable, converts that boolean value back to a String, and finally again converts that String value to a boolean.
Solution: only convert if necessary (if the option is actually negatable), and otherwise retain the original command line value.
(Note that the issue still exists - but seems unavoidable - for negatable options; this should be documented somewhere.)
Problem 1:
Again, the special logic for boolean values is the culprit.
When determining the boolean value of the command line argument, the converter used is that for java.lang.Boolean, regardless of the actual type of the option.
Solution: obtain the type of the option to get the converter, instead of hard-coding the converter to be for  java.lang.Boolean.

Fixed in main. Thank you for raising this, Sven!


Valorantcc not launching at all

No activity in task manager when i double click the application, reinstalled it, tried multiple versions of runtime, tried running as admin, tried reinstalling the program and still nothing.

this is where Valorant CC is stuck

WHEN i ty and download it it keep saying " make sure you trust valorantCC (3).EXE BEFORE you open it


Api token 79

This should be the completed issue 79. Please let me know if anything needs to be changed (Especially the README)

Apologies for the delay. This is it updated!


Update Midnight Ghost Hunt (915810)

Game Title
Midnight Ghost Hunt
Status of the Anti-Cheat
😥 Broken
Tinkering Steps
Some people are having luck with Steam Flatpak, but most are not (including me, who's running Steam Flatpak).
Another detail, the status column of this game points to SCP: Secret Laboratory and not the actual game's ProtonDB page.
Proof of Mention
https://www.protondb.com/app/915810

Thanks for the note!
Some games don't work when you're not using the flatpak, seeing though that they're running inside of the flatpak I consider it as running (with "workarounds")

Thanks for the addotional note!
Some games don't work when you're not using the flatpak, seeing though that they're running inside of the flatpak I consider it as running (with "workarounds")

Then other games such as Genshin should be in the state of "Running" too, no? Because they work, but require workarounds, on top of being consistent unlike this case where the workaround does not works for me.

Thanks for the addotional note!
Some games don't work when you're not using the flatpak, seeing though that they're running inside of the flatpak I consider it as running (with "workarounds")

Then other games such as Genshin should be in the state of "Running" too, no? Because they work, but require workarounds, on top of being consistent unlike this case where the workaround does not works for me.

Oh also thanks for pointing out that it doesn't work for you inside the flatpak, that should count as broken then


Update dependency kubernetes/kubernetes to v1.24.7

This PR contains the following updates:

Package
Update
Change

kubernetes/kubernetes
patch
v1.24.6 -> v1.24.7

⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

Release Notes

kubernetes/kubernetes
v1.24.7
Compare Source
See<EMAIL_ADDRESS>Additional binary downloads are linked in the CHANGELOG.
See the CHANGELOG for more details.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (v1.24.7). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


[Missing ontologies] NEWT, BTO, CL, DOID, PSI-MOD

Ontologies are available at:
NEWT: https://www.uniprot.org/docs/speclist (no standard uri availiable)
BTO: http://purl.obolibrary.org/obo/bto.owl
CL: http://purl.obolibrary.org/obo/cl.owl
DOID: http://purl.obolibrary.org/obo/doid.owl
PSI-MOD: http://purl.obolibrary.org/obo/mod.owl
Reasons for this addition
PRIDE (ProteomeXchange) submission tool requires terms of several specific ontologies. For the proteomics template, the user must use the terms of the respective ontology on different fields, otherwise an upload won't be possible.

Result: Not accepted, better to import specific terms into NFDI4PSO and xref them.


POW Elite (POWR316D FW1.0.2) entity has 4 switches, but no power metering sensors

Systeam Health page:
Sonoff
Version	3.1.0 (3871c0b)
Cloud devices online	1 / 2
Local devices online	1 / 1
Debug page	–

no warning or error in logs

no debug page despite it is enabled in the integration configuration

similar issue, but unknown solution:
https://github.com/AlexxIT/SonoffLAN/issues/820

Diagnostics will be attached soon.

#942


Multiplayer breaks when more than one player tries to join

Describe the bug
Multiplayer works fine between two people. When a third person joins, however, one of the previous two will be stuck in the grayed out "client is joining" screen.
To Reproduce
Steps to reproduce the behavior:

Host starts multiplayer session
First client joins multiplayer session. Everything loads fine.
Second client (third player) joins multiplayer session. Other two players are locked out for loading purposes
After second client finishes loading, the first client is still locked out.

Expected behavior
All locks are released when the second client finishes loading
Active DLCs
Green Cities
Active mods
Multiplayer
Unlimited money, soil
Versions
Type /version into the in-game chat and paste the version numbers here:

Mod version: 2003.3.0
Game version: Base game, 1.13.0-f7

Have also had a similar error. Willing to provide crash logs

For everyone with this issue: Please enable debug logging for the mod in the settings menu.