 Please see the screen shot below:

Preview

The issue happens on both iOS and Android with different fonts. I tested with package google_fonts.
Code:
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        body: NestedScrollView(
          headerSliverBuilder: (_, __) => [
            SliverAppBar.medium(
              title: Text("G g y j"),
            )
          ],
          body: ListView.builder(
            itemBuilder: (_, position) => ListTile(
              title: Text("Item $position."),
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
C:\Users\May\Desktop>flutter doctor -v
[√] Flutter (Channel master, 3.1.0-0.0.pre.864, on Microsoft Windows [Version 10.0.19044.1706], locale vi-VN)
    • Flutter version 3.1.0-0.0.pre.864 at C:\Users\May\Apps\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c5d046c00c (7 hours ago), 2022-05-23 18:43:05 -0700
    • Engine revision f065dc1278
    • Dart version 2.18.0 (build 2.18.0-145.0.dev)
    • DevTools version 2.13.1

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\May\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Users\May\Apps\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.1.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.1.32228.430
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Users\May\Apps\android-studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.19044.1706]
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 101.0.1210.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Issue is reproducible only on master (since this feature isn't available on stable yet) using the code sample provided above.

screenshots

SliverAppBar.medium
SliverAppBar.large

flutter doctor -v
[✓] Flutter (Channel master, 3.1.0-0.0.pre.869, on macOS 12.3.1 21E258 darwin-arm, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.869 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f9765c136f (3 hours ago), 2022-05-23 22:57:34 -0700
    • Engine revision b1fafb96f7
    • Dart version 2.18.0 (build 2.18.0-146.0.dev)
    • DevTools version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 101.0.4951.64

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

cc:@darrenaustin
https://github.com/flutter/flutter/blob/a12a69a47c928e6017196f75fd9f691f32866e88/packages/flutter/lib/src/material/app_bar.dart#L2366
_MediumScrollUnderFlexibleConfig.expandedHeight  and font type is matching M3 sepcs but the issue seems to be with line height.
Top app bar specs suggest line height is suppose to be 32.

but actual height is only 28

Thanks for the investigation info @TahaTesser. That is a bit odd. The font size is 24 for headlineSmall, but it has a height of 1.33 which should make it 32 high. Not sure what is going on here. I will need to spend some more time debugging this.

Shouldn't it be allowed to overflow ?

I can reproduce this by simply running an official example.
P letter is getting cut off in the "Medium App Bar"  when SliverAppBar.medium is expanded.
When comparing the Medium top bar and Large top bar from Android with Flutter, they look shorter, status bar size is not accounted for.

Writing tests, looks like some existing  defaults tests don't account for M3 and fail when migrating to M3.
cc: @Piinks I will cover M3 tests and file a PR on Monday.


experimenting with a multiline controller design

Pull Request Test Coverage Report for Build 882072607

50 of 51 (98.04%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.3%) to 80.044%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

matrix.go
50
51
98.04%

Totals

Change from base Build 881311263:
2.3%

Covered Lines:
365

Relevant Lines:
456

💛  - Coveralls


Problem with some style syntaxes in markdown

Hello, I've noticed that some syntaxes in markdown don't work, like the italic style made with an underscore instead of an asterisk, and the spoiler style

There are problems with language support, an example in TypeScript:
 But here I noticed that if I remove nohighlight from the class of the div element, the syntax appear.
The markdown hyperlinks doesn't show in html:

I rewrotted a function for this:
/**
 * Convert markdown hyperlinks to html hyperlinks
 * @param {string} text The text to convert to html `a` tag
 * @returns {string} The converted text
 * Base was found here: https://gist.github.com/alordiel/ed8587044be07e408f5f93b3124836b3
 */
function markdownHLToHtmlHL(text) {
  // Replace carriage return, line feed by classic line break in html
  text = text.replace(/(?:\r\n|\r|\n)/g, '<br />');

  // Check for links
  const elements = text.match(/\[.*?\)/g);
  // If no links, return base text
  if (elements.length === 0) return text;
  else {
    for (const element of elements) {
      // Get the content of the hyperlink
      const content = element.match(/\[(.*?)\]/)[1];
      // Get the link of the hyperlink
      const url = element.match(/\((.*?)\)/)[1];

      text = text.replace(
        element,
        `<a href="${url}" target="_blank">${content}</a>`
      );
    }
  }
  return text;
}

If I can make a suggestion, for the syntax styling, this theme of highlight.js is the same that discord uses.
I would have gladly made a pull request, unfortunately, it's beyond my capabilities 😓

I completely forgot about underscore italics!
Thanks for the report - I'll fix everything asap.

This should all be fixed now.
I'll push all my changes in a second.
syntax highlighting and underscore italics: https://img.derock.dev/o5Mhpx.png
spoilers: https://img.derock.dev/ts9I0j.gif
inline links: https://img.derock.dev/jXxEH4.png
(can only be used by webhooks, or embed descriptions/fields since that's how discord does it)


Experiments with borrowed Query and Path extractors

impl<'a, 'r, S, T> FromRequest<'a, WebRequest<'r, S>> for Query<T>
where
    S: 'static,
    T: Universe,
    T: Deserialize<'a>,
{
    type Type<'b> = Query<T::Type<'b>>;

Where Universe is the infamous trait:
trait Universe {
    type Type<'a>: 'a;
}

But this requires every type to be deserialized to impl Universe; an ergonomic hurdle but mybe overcome by a homebrew derive(XitcaDeserialize) that implements both serde::Deserialize and Universe and should also be applicable to Path extractor.
Originally posted by @aliemjay in https://github.com/HFQR/xitca-web/pull/201#discussion_r862337881

Yea it can be added to codegen crate.
I think we can offer two version of the Query as Owned and Borrowed so people don't want codegen could choose the owned one.

Lazy<Extractor> has been added to enable zero copy deserialization. They are not clean extractor type but it works now. We can revisit true zero copy extractor later when time comes.


Readd custom css

Description
This readds the custom.css file to overwrite the default cloudstack styles.
Currently this is only possible by adding them to the custom.scss in the repository and compile them into the cloudstack3.css.
Now there is an empty custom.css created when compiling the scss source. This custom.css can be overwritten with the custom styles afterwards.
This functionality was broken by https://github.com/apache/cloudstack/pull/3328.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?
Deployed this to our test environment and tested functionality.

@anuragaw @shwstppr can you take a look?

Can someone confirm testing?
This does not need to have smoketests as it is purely UI change.

@anuragaw i see the same like you.

@rhtyd yes i test it locally and it works.


Huggingface_Hub Issue

I am trying to run a LIama 2 7B demo model. I am facing these issues

"ImportError: cannot import name 'get_full_repo_name' from 'huggingface_hub' (G:\Anaconda\envs\smoothquantEnv\lib\site-packages\huggingface_hub_init_.py)"
ImportError: cannot import name 'CommitInfo' from 'huggingface_hub' (G:\Anaconda\envs\smoothquantEnv\lib\site-packages\huggingface_hub_init_.py)

Please help me to solve this issue. (current huggingface-hub version: 0.23.1)
It would be very helpful if you let me know the clear steps for the execution of your code. Thanks.

I have the same problem！

I also have this problem.


Reproduce e2e NER experiments

I attempted to replicate a Named Entity Recognition (NER) experiment but encountered several issues during the process.
Firstly, when executing the command python slue_toolkit/prepare/prepare_voxpopuli_nel.py create_manifest to generate manifest files, I noticed that the dev.tsv, fine-tune.tsv, and test.tsv files were merely symbolic links. They were unusable for running the end-to-end NER model. To resolve this, I had to manually copy dev.tsv and fine-tune.tsv from slue-toolkit/manifest/slue-voxpopuli into the e2e_ner directory.
Additionally, I faced a problem while performing evaluations with the command bash baselines/ner/e2e_scripts/eval-ner.sh w2v2-base test combined nolm. It appears that the processed test files are missing. Could you provide guidance on how to properly prepare these files for evaluation?

Hi @thomasnguyen92
Thank you for your interest in our work!
The test data is not public yet. We'll update the repo when we make it public (soon). Until then, if you'd like the test set evaluated, you can follow the instructions here.
Can you point out the specific step/script that gave you trouble because of the symbolic links?

I can provide the steps as i faced the same problem
following the steps as mentioned after python slue_toolkit/prepare/prepare_voxpopuli_nel.py create_manifest
when you run the cmd bash baselines/ner/e2e_scripts/ft-w2v2-base.sh manifest/slue-voxpopuli/e2e_ner save/e2e_ner/w2v2-base
you would get the following error
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 198, in run_and_report
    return func()
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 347, in <lambda>
    lambda: hydra.run(
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py", line 107, in run
    return run_job(
  File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 129, in run_job
    ret.return_value = task_function(task_cfg)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq_cli/hydra_train.py", line 27, in hydra_main
    _hydra_main(cfg)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq_cli/hydra_train.py", line 56, in _hydra_main
    distributed_utils.call_main(cfg, pre_main, **kwargs)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq/distributed/utils.py", line 404, in call_main
    main(cfg, **kwargs)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq_cli/train.py", line 134, in main
    task.load_dataset(valid_sub_split, combine=False, epoch=1)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq/tasks/audio_finetuning.py", line 140, in load_dataset
    super().load_dataset(split, task_cfg, **kwargs)
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq/tasks/audio_pretraining.py", line 153, in load_dataset
    self.datasets[split] = FileAudioDataset(
  File "/content/slue-toolkit/baselines/ner/e2e_scripts/fairseq/fairseq/data/audio/raw_audio_dataset.py", line 269, in __init__
    with open(manifest_path, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/content/manifest/slue-voxpopuli/e2e_ner/dev.tsv'

even if the file exists as a symbolic link.


Problems with quantization and qwen2 inference

Hi! When I try to quantize the Qwen2-57B-A14B-Instruct model, I get the following error, is the model not supported?
E:\exllamav2>python convert.py -i D:\text-generation-webui\models\Qwen_Qwen2-57B-A14B-Instruct -o working -nr -om Qwen_Qwen2-57B-A14B-Instruct.json -ss 2048 -hb 8  !! Warning, unknown architecture: Qwen2MoeForCausalLM  !! Loading as LlamaForCausalLM Traceback (most recent call last):   File "E:\exllamav2\convert.py", line 71, in <module>     config.prepare()   File "E:\exllamav2\exllamav2\config.py", line 331, in prepare     raise ValueError(f" ## Could not find {prefix}.* in model") ValueError:  ## Could not find model.layers.0.mlp.down_proj.* in model

Qwen2MoeForCausalLM isn't a supported architecture at the moment, as the output indicates.

Can you please tell me if support is planned?

It's not currently planned, but it may happen. I don't know, basically. I like to give new models at least a few days before I can decide if they're worth the effort. It's potentially weeks of work (this particular MoE architecture is a big departure from the rest in some ways), and a lot could happen in the meantime.

Understood, thanks!


New package: 3.3Kontakt version <IP_ADDRESS>49

Pull request has been created with komac v2.2.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree


Password Based Encryption model

Adds 3 kinds of PBE: PBES1, PBES2 and PKCS12PBE
I couldn't find which exact PBE is used in JCE, but I mapped it to PBES1, which is the only one using the naming pbeWithXXXAndYYY

@hugoqnc did some changes, can you check again and review?


Vercel UI

Still playing with this and I don't understand it, but the basic chat UI was working.
Next I'll check the "chats" and "actions" path to see how they work and if there's any issues.

I'm gonna work on a PR that's blocking Nick, so I'm gonna merge this and look at the "actions" and "chats" in a separate PR.


Port is_subset toTreeMap

Port is_subset to TreeMap

Thanks for the contribution @ariesdevil! This will be part of 1.0 containing some future-proof, yet breaking changes.


build --help needs information from src/scripts/configure

Original issue: https://charm.cs.illinois.edu/redmine/issues/1746

Running build --help produces the following error:
Advanced options:
:./build: line 81: ./src/scripts/configure: No such file or directory
./build: line 82: ./src/scripts/configure: No such file or directory
  bigemulator     compile for BigSim simulator
  ooc             compile with out of core support
  syncft          compile with Charm++ fault tolerance support
  mlogft          compile with Charm++ message logging fault tolerance support
  papi            compile with PAPI performance counter support (if any)

Original date: 2017-11-16 18:09:16

Error was showing up in the wrong place due the the paginator.  It's actually in the "Enable/disable features" section, which runs configure --help.
Enable/disable features:
./build: line 81: ./src/scripts/configure: No such file or directory
./build: line 82: ./src/scripts/configure: No such file or directory
  --with-production       build Charm++ with all optimizations for maximum performance, and disabling all above features

Original date: 2017-11-21 19:51:18

This was caused by the removal of configure from the git repository, which is now regenerated from configure.ac during the build process. We run autoreconf before packaging a tarball, so ./build --help should work fine there. I'm not sure how best to handle the problem when building directly from git.

Original date: 2017-11-29 20:51:44

What is the command to run autoreconf without creating a build directory?

Original date: 2017-11-29 21:16:43

package-tarbahll.sh should get you a readily-built tarball snapshot, with the configure script and other bits suitably generated.

Original date: 2018-01-11 00:31:48

Please test: ~~https://charm.cs.illinois.edu/gerrit/3503~~ https://github.com/UIUC-PPL/charm/commit/84becca3cd156a4cb68d0ac2410091ea4fee47a6


Managedinstalls stopped working

On some of our clients, the managedinstalls processor stopped working. It's not reporting any data to munkireport. This is the error in munkireport-runner:
Server An error occurred while processing: \Managedinstalls_processor
Server Error: SQLSTATE[HY000]: General error: 1 too many SQL variables...

I've removed and re-installed munkireport on a some test clients, but no success.
I also tried to delete all content from /Library/Managed Installs after reading this post: https://groups.google.com/forum/#!topic/munkireport/x0J0xwGtv30, but still no success.
This issue affects all clients except one, in one specific machine group. No client in our other machine group have any issues.
Running version <IP_ADDRESS>19 of Munkireport (WIP branch upgrade was a mistake by me, 5.1.2 was my intention. The upgrade MIGHT be when the issue started) and sqlite 3.15.1.

I released a new version of the managedinstalls module here: https://github.com/munkireport/managedinstalls/releases/tag/V2.3
Would you be able to check if that fixes your issue?

Yes! Clients are now reporting correctly. Thank you!


Fast double parser

Fixes https://github.com/Kotlin/dataframe/issues/607
Created under csv umbrella issue: https://github.com/Kotlin/dataframe/issues/827
Introduces FastDoubleParser as optional alternative double parser. It can be enabled as experimental option (for now) in ParserOptions.
The configurable version of this double parser was created for us :) and the way I implemented it, it can solve some of the locale-fallback-issues we were facing before.
Check the tests I created in this PR for more some examples.
It's also faster than NumberFormat!
FastDoubleParser is also used by Deephaven CSV, which helps with our new csv implementation.

Thanks for the review :) I'll merge it for now so I can continue with the csv parser


feat(symbols): Added symbol source

A simple source to view LSP symbols in the current file.
Features:

[x] UI:

[x] Display all symbols in the current file with symbol kinds
[x] Symbols nesting
[x] Configurable kinds' name and icon
[x] Auto-refresh symbol list

[ ] Commands

[x] Jump to symbols, open symbol in split,... (open_split and friends)
[x] Rename symbols (rename)
[x] Preview symbol (preview and friends)
[ ] Hover docs
[ ] Call hierarchy

[x] LSP

[x] LSP Support
[x] LSP server selection (blacklist, use first, use all, etc.)

[ ] CoC Support

Feel free to let me know if you have any comments on what additional features should be desired.

The document_symbol source is good for now (it is not enabled by default as there might still be bugs). I will implement the hover_docs, call_hierarchy, and CoC Support in a future PR.

I'm very glad to hear that you like this! Regarding the automatic update, I will have a look at why it is not auto-updating. Previously, I used the User LspRequest event, which updates the tree automatically on change and when the current buffer is changed (and every time any LSP Request is made), but this means that navigate is called twice every time the source is opened, so I switched to using these events instead.

@cseickel I can't seem to reproduce your issue with automatic file changes. For me, whenever I change the file, the document_symbols source is updated accordingly. Could you provide the steps to reproduce this?

Actually, I ended up changing it to several separate events and using utils.debounce. Seems to refresh at the right moment and the right amount now.

@nhat-vo I think this looks good as an initial release and I'll merge it now. The two things I would add to make it complete are:

[ ] Follow cursor: just like "follow current file", I would expect the symbol tree to always have the symbol I'm currently on be selected.
[ ] fuzzy search: I would implement the search commands to be able to search/filter the list of document symbols.

@cseickel Great! I'm very glad to see this merged! I'll create an issue to track the features of this source.


doc benchmark

Codecov Report

Merging #347 (21cd6f6) into master (4138a09) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   94.96%   95.21%   +0.24%
==========================================
  Files         129      129
  Lines        4447     4447
==========================================
+ Hits         4223     4234      +11
+ Misses        224      213      -11

Flag
Coverage Δ

unittests
95.21% <ø> (+0.24%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Clarify verification gateway use/upgrade path

Audit issue 3 regarding a bls key able to point to different wallet addresses between verification gateways.

On 3 check 1 and 2
upgrade-test.ts:124


Gradle check retry

Description

Adds a retry mechanism for all test classes under the root project
This should help with gradle check failures

Issues Resolved

https://github.com/opensearch-project/OpenSearch/issues/2547

Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The fact that gradle check succeeded here from the first try tells me that we're on the right track :)

> Task :client:rest-high-level:asyncIntegTest

REPRODUCE WITH: ./gradlew ':client:rest-high-level:asyncIntegTest' --tests "org.opensearch.client.TasksIT.testGetValidTask" -Dtests.seed=91F1364AFC43A70 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-ME -Dtests.timezone=Pacific/Enderbury -Druntime.java=17

org.opensearch.client.TasksIT > testGetValidTask FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([91F1364AFC43A70:9573CA83C6999BB]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.client.OpenSearchRestHighLevelClientTestCase.lambda$checkTaskCompletionStatus$2(OpenSearchRestHighLevelClientTestCase.java:361)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1060)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1033)
        at org.opensearch.client.TasksIT.testGetValidTask(TasksIT.java:123)

start gradle check

@kotwanikunal Did it retry asyncIntegTest? Where do you see it in the log?

@kotwanikunal @dblock I believe the asyncIntegTest may not fall into Test task type:
tasks.withType(Test).configureEach {
    ...
}

We do some tricks here as well https://github.com/opensearch-project/OpenSearch/blob/main/gradle/code-coverage.gradle#L47

@kotwanikunal Did it retry org.opensearch.client.TasksIT.testGetValidTask or asyncIntegTest? Where do you see it in the log?

It only retries the failing tests. I verified that on my local machine with different scenarios including integTest, internalClusterTest
In the individual project logs, you usually see x tests completed, n tests failed with the html report where n counts all the retries.
I will try force failing an asyncIntegTest on my devbox just to be sure.

@kotwanikunal @dblock I believe the asyncIntegTest may not fall into Test task type:
tasks.withType(Test).configureEach {
    ...
}

We do some tricks here as well https://github.com/opensearch-project/OpenSearch/blob/main/gradle/code-coverage.gradle#L47

It does infact cover the asyncIntegTest type.
I ran ./gradlew ':client:rest-high-level:asyncIntegTest' --tests "org.opensearch.client.TasksIT.testGetValidTask" -Dtests.seed=91F1364AFC43A70 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-ME -Dtests.timezone=Pacific/Enderbury -Druntime.java=17  on my devbox by adding in a failing assert.
It looks like it retries the failing asyncIntegTest type -

About asyncIntegTest task, seems it's under Test type.
Its direct type is RestIntegTestTask https://github.com/opensearch-project/OpenSearch/blob/1.3.0/client/rest-high-level/build.gradle#L84.
Then RestIntegTestTask extends StandaloneRestIntegTestTask, which extends Test.
https://github.com/opensearch-project/OpenSearch/blob/1.3.0/buildSrc/src/main/java/org/opensearch/gradle/test/RestIntegTestTask.java#L44
https://github.com/opensearch-project/OpenSearch/blob/1.3.0/buildSrc/src/main/java/org/opensearch/gradle/testclusters/StandaloneRestIntegTestTask.java#L61

What wired here is I didn't see the retry occurs in the above failed gradle check, in the "report 3865"

What wired here is I didn't see the retry occurs in the above failed gradle check, in the "report 3865"

Is boolean isCiServer = System.getenv().containsKey("CI") failing here? Maybe just put retry all the time? It's useful for dev too.

What wired here is I didn't see the retry occurs in the above failed gradle check, in the "report 3865"

Is boolean isCiServer = System.getenv().containsKey("CI") failing here? Maybe just put retry all the time? It's useful for dev too.

Looks like it. Since it's a single retry, let me get rid of the CI condition. I can iteratively improve on it if we decide to have different configs for dev/CI.

@kotwanikunal    use BuildParams instead?
if (BuildParams.isCi() == true) {
}

@kotwanikunal use BuildParams instead?
if (BuildParams.isCi() == true) {
}

@reta How about adding in a single retry for dev and CI for now?

@kotwanikunal use BuildParams instead?
if (BuildParams.isCi() == true) {
}

@reta How about adding in a single retry for dev and CI for now?

Let's vote and if we have a deadlock, we'll just retry? :)

Let's vote and if we have a deadlock, we'll just try again? :) I'm good with anything.

I am fine with that ... for now

How do we ensure we aren't swallowing failures with reproducible seeds? Does it retry with the same seed?

How do we ensure we aren't swallowing failures with reproducible seeds? Does it retry with the same seed?

I am not 100% sure but I would doubt the seed is preserved

Aha, this one seems to retried

And same seed was used
testHAProxyModeConnectionWorks
java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([108B309DF15FC962:17FDE556CAD9BF3F]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)

java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([108B309DF15FC962:17FDE556CAD9BF3F]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)
	at java.base/jdk.internal.

@mch2 ^^

Open issue for this test: https://github.com/opensearch-project/OpenSearch/issues/1703

Aha, this one seems to retried

And same seed was used
testHAProxyModeConnectionWorks
java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([108B309DF15FC962:17FDE556CAD9BF3F]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)

java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([108B309DF15FC962:17FDE556CAD9BF3F]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)
	at java.base/jdk.internal.

@mch2 ^^
@dblock seems like 1 retry is not enough ... or we need to retry the while suite?

Retrying the whole suite will make it difficult to pinpoint flakiness to particular tests. This helps us get to the most frequent offenders IMHO.
But I am all ears about what y'all have to say 🙂

Retrying the whole suite will make it difficult to pinpoint flakiness to particular tests. This helps us get to the most frequent offenders IMHO.

I agree, I don't like that at all, thinking loudly - if cluster ended up in "bad" ( == not expected) state at startup, the test may never succeed ... but we should consider that to be separate problem I guess

Do you want to increase the number of retries @kotwanikunal?

@kotwanikunal Would you backport the change into 1.x branch?


feat: blockchain agnostic inputs

Not sure if this draft is somewhat close to the expected solution? Please let me know if it's not :)

Almost there. The algorithm is actually this:

Encode the blob using abi.encodeWithSignature.
Check if the blob size exceeds the limit.
Return the hash of the blob.

Almost there. The algorithm is actually this:

Encode the blob using abi.encodeWithSignature.
Check if the size of the blob exceeds the limit.
Return the hash of the blob.

These were implemented in the LibInput, right

These were implemented in the LibInput, right

These should be implemented in LibInput.

I meant they were already implemented, right?

Not quite. We won't be hashing the metadata and payload separately. Instead, we'll ABI-encoded the metadata and payload, and call this the input, which is then hashed.

We can make this PR has two commits.

One that solves #84 + changeset
One that solves #2 + changeset

After taking a closer look, the CI failed on the same reason that was fixed in the main branch. So after merging it into main, the failure should resolve on its own.
In the previous PR, the error message showed up as Assertion failed but in this PR it showed up as <no data> so I thought they are different errors. But after taking a deeper look, they failed on the same thing.

After taking a closer look, the CI failed on the same reason that was fixed in the main branch. So after merging it into main, the failure should resolve on its own. In the previous PR, the error message showed up as Assertion failed but in this PR it showed up as <no data> so I thought they are different errors. But after taking a deeper look, they failed on the same thing.

These invariant errors do give us more headaches than guarantees...

Please rebase this on top of main. :-)

We should update the EvmAdvance signature to consider #144 and #145. See https://github.com/cartesi/rollups-contracts/issues/84#issuecomment-1818081690.

After taking a closer look, the CI failed on the same reason that was fixed in the main branch. So after merging it into main, the failure should resolve on its own. In the previous PR, the error message showed up as Assertion failed but in this PR it showed up as <no data> so I thought they are different errors. But after taking a deeper look, they failed on the same thing.

These invariant tests give us more headaches than guarantees...

I did have a bit of similar feelings as well

We should update the EvmAdvance signature to consider #144 and #145. See #84 (comment).

The amount of discussions in this PR is already quite large that I would like to address this in a new PR :)

Please rebase this on top of main. :-)

Will rebase after https://github.com/cartesi/rollups-contracts/pull/136#pullrequestreview-1737661313 being merged into main branch, because the current PR is based on a similar commit

Ok, #136 has been merged.


Add Logging

@raulcr98 is this issue still active, what do you mean with Add Logging?
the issue wiill be closed in the next 7 days


[otbn] Fix rounding in bn.addm in ISS

The add_with_carry function truncates its result to 256 bits, which is
what you normally want, but isn't what you want for BN.ADDM, where you
might overflow but then fix it by subtracting MOD.
I've updated the documentation to match. This now matches the RTL.
Note that this was a bug in the spec, which we caught by noticing that the ISS implemented the spec but the RTL did something different. I could have avoided the debugging if we'd noticed the discrepancy when implementing the RTL in the first place.

Ooh, good point. I read the Python code for subtraction and went "yeah, that looks right", but didn't think very hard. Will fix!

Couple of edits to my comment as I realised it was a little confusing but you seem to have go it anyway, useful for others though.
Again pretty certain the spec has the same bug here, fundamentally it uses SubWithBorrow which only returns 256 bits but that isn't enough as illustrated by the case above, you either want a 257-bit result or a 'went negative' type flag that is returned to tell you if the subtraction resulted in something less than 0. I think the borrow flag will work here (so BN.SUBM instead of checking for result < 0 it checks for borrow set) but would need to think about it a little bit more to be sure...

Cool. I think I've got a fix for the SUBM case too, but I'll push that as a separate PR, so we can get the ADDM fix in either way.

SUBM change in PR #3659.

Argh, I should come up with a test of ECC on the new ISS soon. This would have catched this...
Another thing I wonder in this context: Should we be more explicit with the naming of AddWithCarry and AddWithBorrow methods? Since the parameters are ints the overflow/underrun boundary to set the carry/borrow is implicit in the function. Wouldn't AddWithCarry256 and AddWithBorrow256 be more accurate?

Yes, good point. I'll open an issue to track it.


[0.57.2][IOS] TextInput secureTextEntry keyboard locale updated

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 682.65 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.11.0 - /usr/local/bin/node
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
Android SDK:
Build Tools: 23.0.1, 27.0.3
API Levels: 23, 27
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>14246
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.2 => 0.57.2
npmGlobalPackages:
react-native-cli: 2.0.1
Description
It seems that the secureTextEntry change the keyboard locale on IOS when there is one field in form who's not secure.
Reproducible Demo
Reproduction on a fresh install via CLI:
1 - Change OS lang to French.
2 - Copy this App.js content.
/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 *
 * @format
 * @flow
 */

import React, {Component} from 'react';
import {Platform, StyleSheet, Text, TextInput, View} from 'react-native';

const instructions = Platform.select({
  ios: 'Press Cmd+R to reload,\n' + 'Cmd+D or shake for dev menu',
  android:
    'Double tap R on your keyboard to reload,\n' +
    'Shake or press menu button for dev menu',
});

type Props = {};
export default class App extends Component<Props> {
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>Welcome to React Native!</Text>
        <Text style={styles.instructions}>To get started, edit App.js</Text>
        <Text style={styles.instructions}>{instructions}</Text>
        <TextInput placeholder={'email'} />
        <TextInput secureTextEntry={true} placeholder={'password'} />
        <TextInput secureTextEntry={true} placeholder={'confirm password'} />
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  welcome: {
    fontSize: 20,
    textAlign: 'center',
    margin: 10,
  },
  instructions: {
    textAlign: 'center',
    color: '#333333',
    marginBottom: 5,
  },
});

Expected result
Keyboard locale should stay in OS language for each fields.
Actual result
Email input keyboard is Azerty.
Password and his confirmation are in Qwerty.
Some tests
If you set all fields with
secureTextEntry
={true}

Keyboard locale does not change, and stay Azerty for each one.
Any help is welcome.

After some investigations, it seems that the problem only appear when i have 2 input with the secureTextEntry in the the same view.

Same problem for me. But only IOs !!

At moment, i removed the second secure input and replace it by a "show password feature".

If you collapse your application and come back, you can get crash app.

I just found out, that this problem does not occur when the one of the fields is set to editable={false}. So i toggle the editable property based on which text input field i clicked. Had to put a TouchableWithoutFeedback component on top, as the TextInput ignores the click events, when it's disabled, so it looks something like this.
...
<TextInput />
<View style={{ position: 'relative' }}>
  <TextInput
    secureTextEntry={true}
    editable={this.state.current === 4}
  />
  {this.state.current !== 4 && (
    <TouchableWithoutFeedback onPress={() => this.setState({ current: 4 })}>
      <View style={{ height: '100%', width: '100%', position: 'absolute' }}/ >
    </TouchableWithoutFeedback>
  ) || null}
</View>
<View style={{ position: 'relative' }}>
  <TextInput
    secureTextEntry={true}
    editable={this.state.current === 5}
  />
  {this.state.current !== 5 && (
    <TouchableWithoutFeedback onPress={() => this.setState({ current: 5 })}>
      <View style={{ height: '100%', width: '100%', position: 'absolute' }}/ >
    </TouchableWithoutFeedback>
  ) || null}
</View>
...

But if you dynamically change ** secureTextEntry** attribute, you have the same problem.

I have the same problem but only on simulators. No problem when running on a real device. Same for you ?

Hi, I am actually having the same problem and here is some more informations about it :
First of all this issue is related to the latest version of iOS starting with iOS 12.0 and more (I wasn't experimenting this issue using the iOS 11.1)
My current project is using react-native 55.4 and I am having the same problem with it.
For my test I created a new project with the newest version of react-native 👍
react-native init test577
Package.json
{
  "name": "test577",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "react": "16.6.1",
    "react-native": "0.57.7"
  },
  "devDependencies": {
    "babel-jest": "23.6.0",
    "jest": "23.6.0",
    "metro-react-native-babel-preset": "0.50.0",
    "react-test-renderer": "16.6.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

Code
/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 *
 * @format
 * @flow
 */

import React, {Component} from 'react';
import {Platform, StyleSheet, Text, View, TextInput} from 'react-native';

type Props = {};
export default class App extends Component<Props> {
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>Welcome to React Native!</Text>
        <Text style={styles.instructions}>To get started, edit App.js</Text>
        <TextInput placeholder={'email'} />
        <TextInput secureTextEntry={true} placeholder={'password'} />
        <TextInput secureTextEntry={true} placeholder={'confirm password'} />
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  welcome: {
    fontSize: 20,
    textAlign: 'center',
    margin: 10,
  },
  instructions: {
    textAlign: 'center',
    color: '#333333',
    marginBottom: 5,
  },
});

Just the simple default example with the bug as describe before.
In addition we can see that the problem seems to be cause by the secureTextEntry={true} only when you have two or more (the behavior is actually not very logical)
So if you change the code and keep only two fields as follow, it will work perfectly :
        <TextInput placeholder={'email'} />
        <TextInput secureTextEntry={true} placeholder={'password'} />

As soon as you add another TextInput with a secureTextEntry following another of the same type like in the example the keyboard starts to bug as described.
With Three :
        <TextInput placeholder={'email'} />
        <TextInput secureTextEntry={true} placeholder={'password'} />
        <TextInput secureTextEntry={true} placeholder={'confirm password'} />
        <TextInput secureTextEntry={true} placeholder={'reconfirm password'} />

The first one and last one keeps the keyboard as it is and the two others change the keyboard.
So one way to "deal" with it to make it works is by adding a line in between the secureTextEntry as follow :
        <TextInput placeholder={'email'} />
        <TextInput secureTextEntry={true} placeholder={'password'} />
        <TextInput placeholder={'foo'} />
        <TextInput secureTextEntry={true} placeholder={'confirm password'} />

In this case the keyboard keeps working properly.
I so tried to add the field and hide it with style :
Works
<TextInput placeholder={'foo'} style={{height:1}}/>

Doesn't Works
<TextInput placeholder={'foo'} style={{height:0}}/>

I also tried with other elements like a View or a Text but didn't work with these elements.
Hope all this informations will be helping to correct this bug that is pretty annoying
And that is reproduce on both Simulator and Device

Well found ! thanks for the trick.
The solution : <TextInput placeholder={'foo'} style={{height:1}}/> doesn't work for me

I also open another issue about it but that's a very annoying bug :s
I created another issue about it but still no answer

I also had the problem on iOS, with Expo SDK32, real device.
Adding this between the 2 consecutive password inputs did solve the problem:
            <TextInput
              style={{ width: 0, height: 0 }}
            />

As noted by @rajivshah3, this appears to be a upstream iOS bug, i.e. it affects non-RN code as well:
https://stackoverflow.com/q/52701160/3188334
I did a quick search through https://openradar.appspot.com but couldn’t quickly find any reports for this. I would suggest all of you affected take a minute to report the bug to Apple–and it would be great if you would copy the report into [openradar](https://openradar.appspot.com and link it here.
For now, in an effort to reduce the number of open issues in the issue tracker, I’ll close this ticket.

Hi, I solved this as follows, this isn't the best but it works for me
<TextInput secureTextEntry style={{ zIndex: 0 }} />
<View style={{ zIndex: 2, marginTop: -30, paddingTop: 10,}}>
     <TextInput secureTextEntry />
     <TextInput secureTextEntry  />
</View>


Update the install & deployment docs

Make things a lot simpler and more straightforward, using the new Debian
repo at https://spotify.github.io/helios-apt.

:+1:


In Dart QS: angular2-getting-started -> angular2_getting_started

Dart style is to use _s in names, not -s.
Visible in http://localhost:3000/docs/dart/latest/quickstart.html, source files presumably pulled in from _examples directory.

While the original problem reported by this issue seems to be gone, we still name the project folder as angular2-quickstart. Maybe it should be angular2_quickstart, or better yet, just quickstart, thus matching the angular-examples project name.
Whatever we decide, the name should match that given in the pubspec.yaml.

Actually, if we follow what is used for the Tour of Heroes, then the name angular2_quickstart is what is most appropriate. Opting for that.

Thanks!


fix: remove httpsAgent option

Description

removes httpsAgent option in favor of runtime default

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.71.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Stronger types for useContractCall using TypeChain

Howdy 👋
Me and @krzkaczor started thinking recently about possible stronger types for useContractCalls and useContractCall based on types generated by TypeChain.
Is stronger typing for calls something you would consider merging to useDapp? Is this something the users would be interested in?
For example, with the following change to useContractCalls signature, we could infer required types from ethers contract instance.

import { Dai, Dai__factory } from "./src/typechain"; // generated by TypeChains ethers-v5 target

const daiInstance = Dai__factory.connect(address, signer) // creates instance of ethers.Contract

const [balance] = useContractCalls(daiInstance, [{
  // daiInstance has `.address` and `.interface` properties so we wouldn't need to pass `address` and `abi` here
  method: "balanceOf", // method names and can be derived from contract's instance `.functions` dictionary
  args: [""0x2e465ddca6d2c6c81ce6f260ab13148d43e93371"]
}]);

(users could leverage eth-sdk for automatic ABI management and creation of that ethers contract instance)

I made a repo with some more possible APIs including typelevel implementation.
Frankly speaking, we'd prefer to collaborate on a solution in useDapp without need for codegen, because it would spare us the maintenance of another TypeChain target 😅

@marekkirejczyk @nezouse  This looks good and can be a second function for existing functions that want to enjoy the whole reason using Typescript in the first place...
Seeing the linked repo, it is a prototype with multiple experiences, ideas and functions to choose from that could go directly into useDapp or maybe as a plugin...
Can something be worked on together to give useDapp a better typing experience?
Great work there @hasparus  && @krzkaczor.

Added to roadmap, we have working prototype in the company (based on yours), hope to release as experimental support soon. No clear date thou.

Added typechain with useCall hook.


Update Page “about”

Automatically generated by Netlify CMS

Deploy preview for dds-mil ready!
Built with commit 97bd0b6a2fd4e9776c97c339234a92e1ca76cc70
https://deploy-preview-286--dds-mil.netlify.app


v9.2.2: fix: fix the options for the sass-loader

What does this PR do?
Follow up for #86 ... I forgot to move outputStyle inside sassOptions.
How should it be tested manually?
Build a target with SASS/SCSS and...
yarn test
# or
npm test

Pull Request Test Coverage Report for Build 319

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 316:
0.0%

Covered Lines:
654

Relevant Lines:
654

💛  - Coveralls


Add instructions for git+ssh in OE

Docs for e73c89e3f8f53c49e903d155b02d1af3ee8b5ea0 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1216/docs/artifacts/html/index.html

new section is here - https://ci.foundries.io/projects/fio-docs/builds/1216/docs/artifacts/html/reference-manual/linux/linux-extending.html

Docs for 40c4b29caf060364f0ce8a347e537825fa33dbe5 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1217/docs/artifacts/html/index.html

@kprosise - this look okay now?

@doanac LGTM!

Docs for db20ebdec3086a7147219d0935e7384333a1cadb are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1219/docs/artifacts/html/index.html


ROX-21771: cloud source protos

Description
Add proto definitions for the new cloud source integration type. We have two cloud sources in mind to start with:

Paladin Cloud is a partner product, which provides a list of all cluster assets in a user's cloud provider accounts.
OCM is the Red Hat OpenShift cluster manager, which provides a list of all OpenShift clusters in a user's organization.

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Current dependencies on/for this PR:

master

PR #9537   👈

PR #9542

This stack of pull requests is managed by Graphite.

I learned that we will have to encrypt the integration secrets similar to the notifier secret encryption effort. This is to prevent a later migration, which is causing troubles currently for notifiers. I added new fields for the encryption in the protos.


Validate the enum type matches the -type arg

Without validation, multiple definitions of multiple enums in the same file would be mixed, as well as comments with json:"..." on val or const statments.
Fixes #24

nice. let me read through it

looks good. please check failing test

The test fails because the first enum constant doesn't explicitly state its type (which is fair play of course):
    UndefinedColor = Color{}            // json:""

Rather than:
    UndefinedColor Color = Color{}            // json:""

If the type is struct, or an literal, it's easy to infer; I will fix that.
However, if the type is an expression (like 2 * iota) then it gets involved - unsure how to do easily. So in that case I'd ignore and skip (rather than silently continue and hope there is only one enum in the file).

Let me rephrase the analysis - consider this code:
type Enum1 uint8

//go:generate go-enum-encoding -type=Enum1
const (
    Plain_1a Enum1 = iota+1 // json:"plain_1a"        <-- first enum states explicit type
    Plain_1b                // json:"plain_1b"
)

type Enum2 struct { c uint8 }

//go:generate go-enum-encoding -type=Enum2
const (
    Plain_2a = Enum2{1} // json:"plain_2a"            <-- first enum uses struct type (no explicit type)
    Plain_2b            // json:"plain_2b"
)

type Enum3 uint8

//go:generate go-enum-encoding -type=Enum3
const (
    Plain_3a = 1 // json:"plain_3a"                   <-- first enum uses literal (no explicit type)
    Plain_3b = 2 // json:"plain_3b"
)

type Enum4 uint8

//go:generate go-enum-encoding -type=Enum4
const (
    Plain_4a = iota + 1 // json:"plain_4a"            <-- first enum uses expression (no explicit type)
    Plain_4b = 2        // json:"plain_4b"
)

For Enum1 the explicit enum type can be extracted directly
For Enum2 the implicit enum type can be inferred from the composite literal (struct)
For Enum3 the implicit enum cannot be inferred (literal type is available with extra work)
For Enum4 the implicit enum cannot be inferred (and challenging to infer the literal type)

For case 1,2, the problem is easily solved - I already have it fixed here.
For case 3 and 4, it is not possible distinguish between two enum sets in the same file.
For cases 3 and 4 there I can think of two options:

Skip and do not generate code for such enum constants, and emit useful error for the developer.
Ignore the problem - the generated code will fail to compile at best, or work wrongly at worst.

My choice is no. 1, but I thought I'd get feedback before I go at it.

With the new code in place, I now see a simpler way to do this: always consider the const/var block immediately subsequent to the #go:generate ... line, whose location we know. That rids the need to detect or infer the type of enum values.

UndefinedColor = Color{}            // json:""

you are right. make sense

const (
Plain_4a = iota + 1 // json:"plain_4a"
and
const (
Plain_3a = 1 // json:"plain_3a"

untyped consts, well, they dont have type. so either type should be present for us or we detect by go:generate location in file as you proposed

using go:generate location + GOLINE

nice. very good actually. let me check through it. but very likely this is good to merge.


WIP: 使用 typedoc 生成 api 文档

🤔 This is a ...

[ ] New feature
[ ] Bug fix
[ ] Component style update
[ ] TypeScript definition update
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge

[ ] All tests pass and/or benchmarks are included
[ ] Commit message follows commit guidelines
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

相关的代码注释规范：https://www.yuque.com/antv/g2-docs/cchwwx

相对来说 type 的注释比较简单的，只要做到两点：

类型定义充分
提供变量描述即可

可以在 code 编辑器中安装 Comments in Typescript 插件，提高效率


Fluent Dark theme makes everything big

I'm not sure if this is intended but the Fluent Dark theme makes the all the buttons and text big, here is a comparion between the default Prism Launcher theme and Fluent Dark: https://imgur.com/a/WVWuwXM

That's expected behaviour


Refactor caching for new objects with many 2 many fields

The caching for new objects with many 2 many fields has to be refactored (or just fixed).
Note: There is a hotfix/workaround (see #2734) which fixes #2727. But we want a generic solution for all m2m fields.

Use transactions or
Reload the data before sending it. Channel >=1.0.0 only sends the information to a channel at the end of a request.

The problem is that I want to bundle the blobs. It is not just about sending them at the end of the request cycle. I am looking for an easy way to put all blobs into a stack and then send them out later without touching every line of code in the modules (motion, assignment, ...). Maybe a new custom channel?

Maybe we gat a generic solution also to solve #2779.

Ping
Is this still relevant or an issue?

It is so old. It can probably be closed.

@normanjaeckel Please reopen if it still relevant for you.


Add courrelate zipkin consumer, split zipkin-prod into web/receiver

Add courrelate zipkin consumer, split zipkin-prod into web and receiver modules to speed up query performance. Code is a bit sloppy (cut/paste in build, courrelate consumer is not the cleanest), but this is in prototype mode as we build out courrelate. CC @danchia

gave high-level feedback, style review elided since this is just prototype code :)

Thanks for the feedback @danchia . Per our offline discussion, I'm closing this out in favor of an internal courrelate consumer.


Search Query data will be added more than once with re-rendering in React?

In React when I use js-search, json objects that I've given added more than once in search module.
I created a new file for js-search setup and I'm using it in my component.

import * as JsSearch from 'js-search';
const search = new JsSearch.Search('id');
search.addIndex('effectiveDate');
search.addIndex('opco');
search.addIndex('priceType');
search.addIndex('status');
search.addIndex('vendorGroupID');
export default search;

Now I'm using search.addDocument(data) in componentDidUpdate life cycle to give the 'data' array whenever the component updates. But data will be added more than once. For clarification following image taken with console.log(search).

Can anyone tell me how to solve this issue?

Every time you import your specified module, it will create a new JS Search instance. You should export a function or class instead. Then, you should call that function (or create a class instance) only once.


Add example of using meta to define custom configs title and description

Description
No response

Duplicate of internal TO-DO list.


Initial commit, just values now

new file:   simple_dashboard/Pipfile
new file:   simple_dashboard/Pipfile.lock
new file:   simple_dashboard/bot.py

Summary

This PR just aims to add an example on how to integrate Rillrate with hikari, to make a real time, dynamic web dashboard for your bot.
Checklist

Still a draft.

[ ] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

Related issues

Probably want to update the PR's title and inspect those linting pipeline errors if this is ready now


Custom Global HttpMessageHandlers don't work with the SwashBuckle HttpMessageHandlers

When I add my own HttpMessageHandler to the MessageHandler collection for an IIS hosted application like so:
GlobalConfiguration.Configuration.MessageHandlers.Add(new AuthenticationHandler());

I can then either hit my standard api endpoints:
e.g.
http://somehost.com/api/companies

OR
I can hit the swagger endpoint.
http://somehost.com/api/swagger

I CANNOT hit one and then the other.
If I hit one of those endpoints and then try to hit the other endpoint I get the following:
Server Error in '/api' Application.

The 'DelegatingHandler' list is invalid because the property 'InnerHandler' of 'AuthenticationHandler' is not null.
Parameter name: handlers

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.ArgumentException: The 'DelegatingHandler' list is invalid because the property 'InnerHandler' of 'AuthenticationHandler' is not null.
Parameter name: handlers

Source Error:

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:

[ArgumentException: The 'DelegatingHandler' list is invalid because the property 'InnerHandler' of 'AuthenticationHandler' is not null.
Parameter name: handlers]
   System.Net.Http.HttpClientFactory.CreatePipeline(HttpMessageHandler innerHandler, IEnumerable`1 handlers) +380
   System.Web.Http.HttpServer.Initialize() +30
   System.Web.Http.HttpServer.<EnsureInitialized>b__b() +10
   System.Threading.LazyInitializer.EnsureInitializedCore(T& target, Boolean& initialized, Object& syncLock, Func`1 valueFactory) +86
   System.Web.Http.HttpServer.EnsureInitialized() +95
   System.Web.Http.<SendAsync>d__0.MoveNext() +147
   System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) +93
   System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +52
   System.Web.Http.WebHost.<ProcessRequestAsyncCore>d__0.MoveNext() +400
   System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) +93
   System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +52
   System.Web.TaskAsyncHelper.EndTask(IAsyncResult ar) +60
   System.Web.HttpTaskAsyncHandler.System.Web.IHttpAsyncHandler.EndProcessRequest(IAsyncResult result) +6
   System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +9651188
   System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +155

My DelegatingHandler returns the base.SendAsync to ensure the next handler is invoked.
 return base.SendAsync(request, cancellationToken);

I am running the NuGet pre-alpha version which I think is the Swagger_2.0 git tag.

I'm going to close this issue for now as I can't repro. Please re-open if you have time to troubleshoot further

Just to contribute a hopefully helpful insight - this error occurs when you have multiple HttpServers that use a single HttpConfiguration, and the HttpConfiguration has one or more delegating handlers implicitly or explicitly configured.
I explain it in more depth here:
http://stackoverflow.com/questions/12008686/webapi-batching-and-delegating-handlers/31445355#31445355

I'm getting the same problem when adding the custom message handler to the pipeline. When I add the message handler to the routing, it works fine.


[MINOR] ConsumerGroupCommand does not print cause of failure

When kafka-consumer-groups.sh fails to execute a command (for example, because of a configuration problem), it does not print the cause of failure which could make it hard to debug the root cause. This patch includes a minor change to print the actual cause of the exception.
Example error output with the patch:
Error: Executing consumer group command failed (Failed to construct kafka consumer)
org.apache.kafka.common.config.ConfigException: request.timeout.ms should be greater than session.timeout.ms and fetch.max.wait.ms

@ijuma could you please review when you get a chance.

Retest this please.

@hachikuji this should be good for another review now.


Add React.memo wrapping

Add React.memo wrapping

Pull Request Test Coverage Report for Build 109

6 of 6 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 108:
0.0%

Covered Lines:
66

Relevant Lines:
66

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Doesn't seem to be using GPU

I was finally able to get this running in WSL following both Nvidia's CUDA directions and this repo.
However, when running the model, my GPU utilization stays at 1% and even the CPU doesn't do much. Do you know why?

k seems the issue is that since running in WSL, the Windos GPY Performance OVerlay doesnt work. GPU is being used. CLosing my own thread


Internal Server Error

Hi!!!! I am getting Internal server error when trying to run the whole setup of evidently with my dataset.
I am attaching the screenshot of it. can you please help with this?

Hey hii Jyothsna , Even I'm also getting that same after setup all the environment and run the run_example.py file with my data.
If you find any solution let me know.
Thank you

Hi guys ,
What is your system configuration and data size, And can please let me know the steps to reproduce it.
Thanks

Hi @ketangangal !!!
Thank you for the response. We have done the setup using (evidently/examples/integrations/grafana_monitoring_service at main · evidentlyai/evidently · GitHub). We have fixed that issue. It was because of the config file.
Can you please help us on how to get the classification and regression performance drift using evidently. Can you please share us if there are any documentations available?

Hello @JyothsnaPendyala ,
There is something called as

RegressionPreset
ClassificationPreset

Can also tell me when you say performance drift, where exactly you are focusing with metrics.
(https://docs.evidentlyai.com/reference/all-metrics)
FYI @Vamsi-Cloudangles


Close modal with js opened without it

Sorry for my english
There is modal with id="modal-1" and button with href="#modal-1". So if you open modal with button you can't close it with halfmoon.toggleModal('modal-1')

You are misunderstanding how the modals work without JavaScript. The button with the href="#modal-1" opens the modal using the CSS :target attribute. In order to close this modal, your close button needs to change the anchor in the URL, so something like this: Close modal. A modal opened using JavaScript can be closed with JavaScript. I would recommend reading this part of the docs: https://www.gethalfmoon.com/docs/modal/#javascript-usage
I will go ahead and close this. Please re-open it if you think the issue is not resolved.

ok, thanks


How to Disable trusted lunch for a vm?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cedc5fc7-5576-f22f-9c9a-a2977ad93607
Version Independent ID: e7cda6ea-acd1-b56f-9d81-92d6fde31921
Content: Trusted launch for Azure VMs - Azure Virtual Machines
Content Source: articles/virtual-machines/trusted-launch.md
Service: virtual-machines
Sub-service: trusted-launch
GitHub Login: @lakmeedee
Microsoft Alias: dejv

@medavamshi Thank you for your question!  We are reviewing the documentation and will get back to you shortly.

any updates?  we got around 300 vm's that need to be migrated to a different region.  cannot migrate them with trusted launch enabled.

@medavamshi According to the documentation, the instructions for verifying or updating Trusted Launch is the same for Portal, CLI, and PowerShell:
https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch-portal?tabs=portal%2Ccli2#verify-or-update-your-settings

To change the trusted launch configuration, in the left menu, select Configuration under the Settings section. You can enable or disable Secure Boot and vTPM from the Trusted LaunchSecurity type section. Select Save at the top of the page when you are done.

Looking at the Azure CLI documentation, however, it looks like az vm update also accepts both --enable-secure-boot {false, true} and --enable-vtpm {false, true}.  I'll have to test this, but in theory that should work to disable the Trusted Launch security settings the same as the portal instructions above would.

@medavamshi I tested this and can confirm that az vm update will disable Trusted Launch (Secure boot and vTPM).  If you need additional assistance, please reach out for expert guidance on Microsoft Q&A.
az vm update -g MyResourceGroupName -n MyVMName --enable-secure-boot false --enable-vtpm false

We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Split out template.py into separate modules

In an effort to slim down template.py we should split out into builder specs structure.
Will look similar to:
packer_builder/specs
├── __init__.py
├── builders
│   ├── __init__.py
│   ├── common.py
│   ├── distro.py
│   ├── distros
│   │   ├── __init__.py
│   │   ├── alpine.py
│   │   ├── centos.py
│   │   ├── debian.py
│   │   ├── fedora.py
│   │   ├── freenas.py
│   │   └── ubuntu.py
│   ├── qemu.py
│   ├── virtualbox.py
│   └── vmware.py
└── provisioners
    ├── __init__.py
    ├── freenas.py
    ├── linux.py
    └── windows.py

We may still work towards #4 after this but for now I want to explore this route.

Paging @bunchc for thoughts! :)

I like this idea. Also makes things a bit more modular to ease adding additional builders (hyperv, etc)

Yeah that is what I was thinking as well. Which is the route I was attempting to go. I have this all ready to be merged. Want to review? :)


HTTP heartbeat / remote control

:no_entry_sign: BEWARE: this is controversial :no_entry_sign:
This is primarily for purposes of being able to remotely shut down travis worker from something running outside of the EC2 VPC (specifically, pudding after receiving a lifecycle event for termination from EC2).  I personally consider this solution preferable to alternatives that would require "pushing" an event into the VPC, as this would require relaxing security :-1:.
Opinions and alternatives and thoughts wanted!

Related work: https://github.com/travis-ci/pudding/pull/21


cant find the DEBUG Button

VSCode Version: 1.0.0
OS Version: OS X 10.11.3

Steps to Reproduce:

click the fourth button on the left
in the debug view , I cant find "DEBUG"-name button

Fixed with latest vscode insiders release, please try it there. Otherwise it will be available in the stable release in the next couple of weeks


Remove nav menu title label, and other four-year-plan fixes

WHAT A HOT MESS

This commit breaks the search box.


Publish doc updates

Docs Build status updates of commit e527675:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/using-motion-office-addins.md
:white_check_mark:Succeeded

docs/develop/specify-office-hosts-and-api-requirements.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-advanced-concepts.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-tables.md
:white_check_mark:Succeeded

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded

docs/reference/objectmodel/preview-requirement-set/outlook-requirement-set-preview.md
:white_check_mark:Succeeded

docs/reference/openspec/openspec.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-requirement-sets.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/onenote-api-requirement-sets.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/outlook-api-requirement-sets.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-1-1-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-1-2-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-1-3-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-requirement-sets.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-preview-apis.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial.md
:white_check_mark:Succeeded

docs/tutorials/word-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUG] - LOGIN / SIGN UP doesn't work on the deployed site

Description
When trying to access the LOGIN / SIGN UP button through the deployed site, the login page gives ERROR 400
Steps to Reproduce
Steps to reproduce the bug:

[ ] Go to the deployed site: https://cuisinemachine.herokuapp.com/
[ ] Press the LOGIN / SIGN UP button in the header
[ ] It should redirect you to an ERROR 400

Expected Behavior
The ERROR 400 should not appear, instead it should present the users with a login form.
Relevant screenshots

fixed


Automate Data Extraction and Cleaning

Add a script that pulls the data sets you chose from the internet, transforms it and fixes errors, and finally stores the data in the /data directory.

The commit closes this issue.


Broken ContextMenu

Hi!
I have tried to use ContextMenu and it appears to be quite broken.
I added this change to the example code:
diff --git a/_examples/widget_demos/contextmenu/main.go b/_examples/widget_demos/contextmenu/main.go
index 6637df8..f37d471 100644
--- a/_examples/widget_demos/contextmenu/main.go
+++ b/_examples/widget_demos/contextmenu/main.go
@@ -54,6 +54,9 @@ func main() {
                                //      button.GetWidget().ContextMenuWindow.Close()
                                //}
                        }),
+                       widget.ButtonOpts.ReleasedHandler(func(args *widget.ButtonReleasedEventArgs) {
+                               println(fmt.Sprintf("Option %d released", iter))
+                       }),
                )
                contextMenu.AddChild(Option1)
        }

and playing with the demo it’s pretty clear there are a few issues:

my PR #87 probably broke the natural UX of the context menu (i.e. right press, hover entry while pressing, release to select it)
when selecting an entry, the context menu window seems to close too fast, before the button of the menu has a chance to fire its events
opening the menu again triggers a released event for the first entry

I can try to dig a bit but I haven’t yet looked into how events propagate across components and such.
But maybe that’s a good incentive to start, though. 😅
edit: the spurious release events for buttons were actually fixed in #87

If we change the example code to:
diff --git a/_examples/widget_demos/contextmenu/main.go b/_examples/widget_demos/contextmenu/main.go
index 6637df8..c8183c0 100644
--- a/_examples/widget_demos/contextmenu/main.go
+++ b/_examples/widget_demos/contextmenu/main.go
@@ -50,9 +50,15 @@ func main() {
                        widget.ButtonOpts.ClickedHandler(func(args *widget.ButtonClickedEventArgs) {
                                println(fmt.Sprintf("Option %d clicked", iter))
                                //Manually close the ContextMenuWindow
-                               //if button.GetWidget().ContextMenuWindow != nil {
-                               //      button.GetWidget().ContextMenuWindow.Close()
-                               //}
+                               if button.GetWidget().ContextMenuWindow != nil {
+                                       button.GetWidget().ContextMenuWindow.Close()
+                               }
+                       }),
+                       widget.ButtonOpts.PressedHandler(func(args *widget.ButtonPressedEventArgs) {
+                               println(fmt.Sprintf("Option %d pressed", iter))
+                       }),
+                       widget.ButtonOpts.ReleasedHandler(func(args *widget.ButtonReleasedEventArgs) {
+                               println(fmt.Sprintf("Option %d released", iter))
                        }),
                )
                contextMenu.AddChild(Option1)
@@ -84,7 +90,7 @@ func main() {
                        // Set how the context menu should be closed
                        // This defaults to "CLICK" so that it will close the contextmenu
                        // whenever the user clicks their mouse next
-                       //widget.WidgetOpts.ContextMenuCloseMode(widget.NONE),
+                       widget.WidgetOpts.ContextMenuCloseMode(widget.CLICK_OUT),
                ),

                // specify the images to use

i.e. use widget.CLICK_OUT instead of the default widget.CLICK, and manually closing the menu, then it does work as expected.
Perhaps the default should be changed and the example updated? Maybe it’s not as clean an API as ultimately possible though…

Hey, So I figured out what broke it. It was a change I made a while back. I just pushed a change that seems to clean things up quite a well!. Please check out the latest commit and let me know if you seen anything else. I am going to close this comment for now. Please open a new one or reach out on discord (see readme for link).  Thanks for all the feedback. Having people like you in the community help make this a better library!
~Mark


docs header link doesn't go to the exact header content

Affected module
Docs
Describe the bug
We allow users to copy specific section in the docs page but the link doesn't take us to the exact content in the page . Example
https://docs.open-metadata.org/v1.0.0/connectors/database/snowflake/cli#1.-define-the-yaml-config
To Reproduce
Screenshots or steps to reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

Re-opening the ticket as the issue has arrived again due to some changes in other PRs


Makefile broken

I had to fix a syntax error in the Makefile. Can I commit my fix?

you but I gladly accept pull requests

closing this but please do submit a PR if you like


Error in building apk and installing app in android.

I have also downloaded the gradle-7.5-all.zip file online but didn't work
Error is this :-
Exception in thread "main" java.lang.RuntimeException: Timeout of 120000 reached waiting for exclusive access to file: C:\Users\S.gradle\wrapper\dists\gradle-7.5-all\6qsw290k5lz422uaf8jf6m7co\gradle-7.5-all.zip
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:61)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)

Timeout of 120000 reached waiting for exclusive access to file:

This most probably indicates a network related error. Try using a stable / fast internet connection.
Closing for now, as this doesn't seem to be a framework bug. If you disagree, write in comments and I'll reopen it.

Network is stable I am able to download and upload everything even dependency are syncing properly in my project only issue occurs while building apk and this problem is started in android studio latest version electric ele..

Can you provide complete error log by running flutter build apk -v ?

Also, check if this helps in your case.


Neumorphic textfield in LoginScreen

Changes made are as follows:

Added Neumorphic style to the Login Screen textfields.
Used 'animate_do' package to add animations to the textfields.

Attached demo video-
https://github.com/CCExtractor/Flood_Mobile/assets/98613922/c2358dc2-e828-4cc8-b8bd-e044834f23b7

Hey @tamojitalwaysghosh the flutter CI is failing. Can you please work on resolving it.

@Akshatji800
Sorry to hear that, sir
I would check and make a new PR


TLS connection to smtp server with password

I'm trying to get something like you would see here.
For reference, I've used a node.js module, Nodemailer, that is able to implement that as seen in this example. It looks like the bulk of the work happens in this module.
I would like to add some more secure functionality to smtp. Let me know if there is anything I can do to help.

Hi @samueleaton:
@sdogruyol asked for the same functionality for gmail smtp. There's 2 main features to implement, TLS connections (OpenSSL::SSL::Context::Client, https://crystal-lang.org/api/master/OpenSSL/SSL/Context/Client.html ) and Plain Auth (Super simple to implement). if you know the RFC's related to this features, you could help us with a Pull Request. I have a rough estimate to implement all the features in the first week of November, but i'm very bad with release dates :), so if you can help i'll appreciate it a lot.

Yeah looking at how some other libs do it it didn't seem like too much work. We should think of a good api and then get crackin'.
Even though there is more demand for gmail, I think most would agree that it should work for many services and let the user be able to "plug 'n play". The nodemailer team did some work for us and has gathered a list of common services with domain alias, ports and security types.

Maybe take in consideration this api:
http://ruby-doc.org/stdlib-2.0.0/libdoc/net/smtp/rdoc/Net/SMTP.html

yeah i was reading the source code earlier today and saw that ruby was using the openssl lib like you suggested.

See also: https://github.com/crystal-lang/crystal/blob/36b2fc4a677721ef5c7f2a27d6270f72b2999019/src/http/client.cr#L154
here's the code of TLS connection usage.

I'm using https://github.com/arcage/crystal-email to auth with tls. Seems to work. Perhaps bringing the libs together somehow could help?

Hello @crisward
Nice to know about this lib, i'll put a message in the readme file. Is there something in smtp.cr that you'll like to see in the crystal-email code base to cover in a PR?.

Crystal email doesn't support HTML emails, and smtp.cr doesn't support attachments or tls.
It'd be nice if we had one library with all the features.


Support workdir venv

Support creating venv per workdir:
git worktree add ~/ramen-foobar
cd ~/ramen-foobar
hack/make-venv .venv/ramen
source venv

With this you can test drenv changes in the ramen-foobar worktree without affecting the main worktree, using the standard venv (~/.venv/ramen).
Use this in the CI to ensure that every build uses a fresh venv instead of installing drenv on the runner host.

Needs rebase after main changed.

Should be ready, but lets wait for the build:
https://github.com/RamenDR/ramen/actions/runs/11939408219

@nirs Do you think the e2e failure is related?

@nirs Do you think the e2e failure is related?

No, this is a known issue with cephfs. Sometimes we fail to clean up after the volsync file test, since the cpehfs snapshot is not deleted. When this happens, retrying the e2e job will continue to fail because we are using the same namespaces and resources names, so stuck snapshot will continue to fail without manual cleanup.
If there was an issue with the venv, deleting the cluster would fail and we would not reach the step of starting the clusters.

The next failure: https://github.com/RamenDR/ramen/actions/runs/11955746683/job/33336392815
is also not related, looks like another instance of #1659

@raghavendra-talur this is ready for merge, the random failures in the ci should be fixed by #1689


az account list-locations Should Return Availability Zones

The az account list-locations command should also return a list of availability zones supported by the location.

@jiasli for awareness

Duplicate of https://github.com/Azure/azure-cli/issues/10421


Preserve substituions maps while calculating derivative types

The substition map might contain a proper specialization (e.g. t_0_0 -> Double) that is required to fully specify a derivate type (e.g. during reabstraction conversion from fully specified function type to a substituted one)
Fixes #65073

Tagging @BradLarson

@swift-ci please test

@swift-ci please test

@swift-ci please test


Updates for reading from serial console

Rework handling of received chars
Add timeout option for wait_for

Successfully tested with the following cases:

regular .srec-files
small binary
big (16MB) binary

Works as expected.

@lorc could you please take a look?

Please see below two examples of the script's output. Without this PR (as is now in main branch`) and with this PR applied.
Current main branch (without PR):
[INFO] Sending flash writer file AArch32_Flash_writer_SCIF_DUMMY_CERT_E6300400_ULCB.mot...
420_908/420_908 (100%)

Flash writer for R-Car H3/M3/M3N Series V1.12 Jun.4,2021
>
[INFO] Using serial port /dev/ttyUSB0 with baudrate 921600
[INFO] Writing bootparam (../firmware_dunfell_kf/bootparam_sa0-4x2g.srec) at 0x0 using gen3_hf

>
xls2
===== Qspi/HyperFlash writing of Gen3 Board Command =============
Load Program to Spiflash
Writes to any of SPI address.
Please select,FlashMemory.
   1 : QspiFlash       (U5 : S25FS128S)
   2 : QspiFlash Board (CN2: S25FL512S)
   3 : HyperFlash      (SiP internal)
  Select (1-3)>
3
SW1    ON!                Setting OK? (Push Y key)
SW6[3] ON!                Setting OK? (Push Y key)
 READ ID OK.
Program Top Address & Qspi/HyperFlash Save Address
===== Please Input Program Top Address ============
  Please Input : H'
E6320000

===== Please Input Qspi/HyperFlash Save Address ===
  Please Input : H'
0
Work RAM(H'50000000-H'53FFFFFF) Clear....
please send ! ('.' & CR stop load)
11_136/11_136 (100%)

SPI Data Clear(H'FF) Check :H'00000000-0003FFFF,Clear OK?(y/n)
H'00000000-0003FFFF Erasing..Erase Completed
SAVE SPI-FLASH....... complete!

======= Qspi/HyperFlash Save Information  =================
 SpiFlashMemory Stat Address : H'00000000
 SpiFlashMemory End Address  : H'00000E67
===========================================================

>
[INFO] All done!
[INFO] CPLD: Issuing command normal_mode
[INFO] CPLD: Issuing command reset

With this PR applied:
[INFO] Sending flash writer file AArch32_Flash_writer_SCIF_DUMMY_CERT_E6300400_ULCB.mot...

420_908/420_908 (100%)

Flash writer for R-Car H3/M3/M3N Series V1.12 Jun.4,2021
>[INFO] Using serial port /dev/ttyUSB0 with baudrate 921600
[INFO] Writing bootparam (../firmware_dunfell_kf/bootparam_sa0-4x2g.srec) at 0x0 using gen3_hf

>xls2
===== Qspi/HyperFlash writing of Gen3 Board Command =============
Load Program to Spiflash
Writes to any of SPI address.
Please select,FlashMemory.
   1 : QspiFlash       (U5 : S25FS128S)
   2 : QspiFlash Board (CN2: S25FL512S)
   3 : HyperFlash      (SiP internal)
  Select (1-3)>3
 READ ID OK.
Program Top Address & Qspi/HyperFlash Save Address
===== Please Input Program Top Address ============
  Please Input : H'E6320000

===== Please Input Qspi/HyperFlash Save Address ===
  Please Input : H'0
Work RAM(H'50000000-H'53FFFFFF) Clear....
please send ! ('.' & CR stop load)
11_136/11_136 (100%)

SPI Data Clear(H'FF) Check :H'00000000-0003FFFF Erasing..Erase Completed
SAVE SPI-FLASH....... complete!

======= Qspi/HyperFlash Save Information  =================
 SpiFlashMemory Stat Address : H'00000000
 SpiFlashMemory End Address  : H'00000E67
===========================================================

>[INFO] All done!
[INFO] CPLD: Issuing command normal_mode
[INFO] CPLD: Issuing command reset

Reworked and tested again.
Corresponding info is added to README.
Ready for re-review.

RB is added. The smoke test (flash all loaders with -c -f .... all) passed OK.
Ready to be merged.


asdict does not call value_serializer on attrs objects in containers

Bug Report
When calling asdict recursively with a custom value_serializer function, the custom serializer is not called on attrs types that reside in any container type field. This is inconsistent, as the serializer is called on attrs types that are themselves fields of an attrs type. I.e. if you have an attrs type with two fields, one of which is an attrs type and one which is a list of attrs types, the custom serializer will be called on the non-list field but not on the objects in the list.
This is also inconsistent with the way non-attrs types are handled, as the custom serializer will be called on them regardless of whether they are direct fields or held within container fields.
To Reproduce
Create an attrs type that contains other attrs types both directly and in a container. Create a custom serializer function that tracks which objects were passed to it:
import attrs
from typing import Any

@attrs.frozen
class MyAttrsType:
    name: str

    def serializer_was_called(self) -> None:
        print(f"Serializer func was called on Attrs type {str(self)}")

    def __str__(self) -> str:
        return f"MyAttrsType[{self.name}]"

@attrs.define
class HasContainer:
    part: MyAttrsType
    non_attrs_thing: str
    parts_list: list[Any] = attrs.field(factory=list)

    def __str__(self) -> str:
        parts_str = [str(part) for part in self.parts_list]
        parts_str.append(str(self.part))
        return f"Container{parts_str}"

attrs_objects_that_serializer_was_called_on = set()

def val_serializer_func(inst, attr, val) -> Any:
    try:
        val.serializer_was_called()
        attrs_objects_that_serializer_was_called_on.add(val)
    except AttributeError:
        print(f"Serializer func was called on non-attrs {str(val)}")
        pass
    return val

def test_attrs_bug():
    attrs_obj_A = MyAttrsType("a string A")
    attrs_obj_B = MyAttrsType("a string B")
    attrs_obj_C = MyAttrsType("a string C")

    cont = HasContainer(attrs_obj_A, "a string D")

    cont.parts_list.append(attrs_obj_B)
    cont.parts_list.append("a string E")
    cont.parts_list.append(attrs_obj_C)

    print(f"Calling asdict on {str(cont)}")
    attrs.asdict(cont, recurse=True, value_serializer=val_serializer_func)

    assert attrs_objects_that_serializer_was_called_on == {
        attrs_obj_A,
        attrs_obj_B,
        attrs_obj_C,
    }

Expected behavior:
When calling asdict recursively with the custom serializer we expect that all objects will be passed to the serializer as values. I.e. the assertion in the above test_attrs_bug should pass
Actual behavior:
Attrs objects within a container field are not passed to the serializer as values. The assertion in test_attrs_bug fails because attrs_obj_B and attrs_obj_C are not present.
Environment:
python 3.10.13
attrs 23.2.0
GNU/Linux

Attrs objects within a container field are not passed to the serializer as values.

That's correct, the value_serializer hook won't get passed each list element as a val; it'll get passed in the entire list. Then later, each list elements get passed in as the inst parameter (with their own field values as val). Note that the documentation states the value_serializer will get called for attrs classes and dicts only.
So the chain of invocations here is:
1. HasContainer(part=MyAttrsType(name='a string A'), non_attrs_thing='a string D', parts_list=[MyAttrsType(name='a string B'), 'a string E', MyAttrsType(name='a string C')])
Attribute(name='part', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class '__main__.MyAttrsType'>, converter=None,
kw_only=False, inherited=False, on_setattr=None, alias='part')
MyAttrsType(name='a string A')
2. MyAttrsType(name='a string A')
Attribute(name='name', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class 'str'>, converter=None, kw_only=False,
inherited=False, on_setattr=None, alias='name') a string A
3. HasContainer(part=MyAttrsType(name='a string A'), non_attrs_thing='a string D', parts_list=[MyAttrsType(name='a string B'), 'a string E', MyAttrsType(name='a string C')])
Attribute(name='non_attrs_thing', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class 'str'>, converter=None,
kw_only=False, inherited=False, on_setattr=None, alias='non_attrs_thing') a string D
4. HasContainer(part=MyAttrsType(name='a string A'), non_attrs_thing='a string D', parts_list=[MyAttrsType(name='a string B'), 'a string E', MyAttrsType(name='a string C')])
Attribute(name='parts_list', default=Factory(factory=<class 'list'>, takes_self=False), validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}),
type=list[typing.Any], converter=None, kw_only=False, inherited=False, on_setattr=None, alias='parts_list')
[MyAttrsType(name='a string B'), 'a string E', MyAttrsType(name='a string C')]
5. MyAttrsType(name='a string B')
Attribute(name='name', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class 'str'>, converter=None, kw_only=False,
inherited=False, on_setattr=None, alias='name') a string B
6. None None a string E
7. MyAttrsType(name='a string C')
Attribute(name='name', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class 'str'>, converter=None, kw_only=False,
inherited=False, on_setattr=None, alias='name') a string C

That looks ok to me.
Note: if you need advanced serialization, look at https://catt.rs. It's a related project from the same organization.

I guess that's fair, as the documentation does say:

:param Optional[callable] value_serializer: A hook that is called for every attribute or dict key/value.

and my repro example uses a list.
But if you replace 'list' with 'dict' (and make appropriate changes) you'll find the same thing happens. value_serializer is NOT called for dict values that are attrs classes, which is definitely in contravention of the docs. This happens for the same reason it happens with list items: _asdict_anything shortcuts back to asdict for any value that is an attrs class without calling value_serializer.
Whether or not it's in contravention of the docs, I'd argue this behavior makes the value_serializer basically useless as you have to invoke all kinds of crazy logic involving field type and manual container unrolling to get a consistent serialization path.
Updated repro:
import attrs
from typing import Any

@attrs.frozen
class MyAttrsType:
    name: str

    def serializer_was_called(self) -> None:
        print(f"Serializer func was called on Attrs type {str(self)}")

    def __str__(self) -> str:
        return f"MyAttrsType[{self.name}]"

@attrs.define
class HasContainer:
    part: MyAttrsType
    non_attrs_thing: str
    parts_dict: dict[str, Any] = attrs.field(factory=dict)

    def __str__(self) -> str:
        parts_str = {str(k): str(v) for k,v in self.parts_dict.items()}
        return f"Container{parts_str} + {str(self.part)}"

attrs_objects_that_serializer_was_called_on = set()

def val_serializer_func(inst, attr, val) -> Any:
    try:
        val.serializer_was_called()
        attrs_objects_that_serializer_was_called_on.add(val)
    except AttributeError:
        print(f"Serializer func was called on non-attrs {str(val)}")
        pass
    return val

def test_attrs_bug():
    attrs_obj_A = MyAttrsType("a string A")
    attrs_obj_B = MyAttrsType("a string B")
    attrs_obj_C = MyAttrsType("a string C")

    cont = HasContainer(attrs_obj_A, "a string D")

    cont.parts_dict["B"] = attrs_obj_B
    cont.parts_dict["E"] = "a string E"
    cont.parts_dict["C"] = attrs_obj_C

    print(f"Calling asdict on {str(cont)}")
    attrs.asdict(cont, recurse=True, value_serializer=val_serializer_func)

    assert attrs_objects_that_serializer_was_called_on == {
        attrs_obj_A,
        attrs_obj_B,
        attrs_obj_C,
    }

Whether or not it's in contravention of the docs, I'd argue this behavior makes the value_serializer basically useless as you have to invoke all kinds of crazy logic involving field type and manual container unrolling to get a consistent serialization path.

You're right on the money here. The problem with addict, at this point, is that it exists in some kind of grey area between the simple original purpose and full-on serialization – and we noticed the problem too late.
Whenever someone bumps into the edges of its capabilities, the natural reaction is to add "just this one more thing". Unfortunately, it turned out the number of "just one more things" is virtually infinite, as you can see if you count the numbers of cattrs. This topic is extremely complex and we should've never added value_serializer etc in the first place.
attrs exists in this field of tension between a class toolkit it wants to be and just enough serialization everyone would like to have.
Either way I'm sorry, and the answer to more elegant code is right here in the attrs org: https://github.com/python-attrs/cattrs