Deprecation warnings ruby 2.7.1 and rails 6.0.3

Hi, after going from rails <IP_ADDRESS> to 6.0.3 I got the following new deprecation warnings
.rvm/gems/ruby-2.7.1/gems/dalli-2.7.10/lib/active_support/cache/dalli_store.rb:149: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3/lib/active_support/cache/strategy/local_cache.rb:143: warning: The called method `write_entry' is defined here
.rvm/gems/ruby-2.7.1/gems/dalli-2.7.10/lib/active_support/cache/dalli_store.rb:420: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3/lib/active_support/cache/strategy/local_cache.rb:122: warning: The called method `read_entry' is defined here
.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3/lib/active_support/cache/strategy/local_cache.rb:126: warning: Passing the keyword argument as the last hash parameter is deprecated
.rvm/gems/ruby-2.7.1/gems/dalli-2.7.10/lib/active_support/cache/dalli_store.rb:305: warning: The called method `read_entry' is defined here
.rvm/gems/ruby-2.7.1/gems/dalli-2.7.10/lib/active_support/cache/dalli_store.rb:167: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3/lib/active_support/cache/strategy/local_cache.rb:153: warning: The called method `delete_entry' is defined here
.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3/lib/active_support/cache/strategy/local_cache.rb:155: warning: Passing the keyword argument as the last hash parameter is deprecated
.rvm/gems/ruby-2.7.1/gems/dalli-2.7.10/lib/active_support/cache/dalli_store.rb:332: warning: The called method `delete_entry' is defined here

Fixed if https://github.com/petergoldstein/dalli/pull/751 is merged.

Also fixed when ruby 2.6.2 is released: https://discuss.rubyonrails.org/t/new-2-7-3-0-keyword-argument-pain-point/74980

Q: Is there something preventing merge of #751?


[Improve][bitsail-dist]connectors mapping unify naming

I noticed that connectors mapping file name in connector V1 is bitsail-connector-unified-{database-name}.json，should we rename the redis connector json filename to stay unified and add the print connector conf in the product.
If really need to modify it, please assign it to me

@liuxiaocs7 Yes, we need rename the file name like you said, can you submit a PR imporve this?

Of course I'd love to, please assign me.


FCDA specification incorrectly refers to LLN0

Describe the bug
I was looking through the code:
We use a function to check whether FCDAs have the correct cdc and basic type.
https://github.com/openscd/open-scd/blob/6ce21056ab2acf46cff4e26c978d7e1d6feca774/src/editors/subscription/later-binding/foundation.ts#L43-L76
This particular line is incorrect:
LDevice[inst="${fcda.getAttribute('inst')]

There is no inst attribute against an FCDA defined in the standard. There is only, lnInst. This should be changed to:
LDevice[inst="${fcda.getAttribute('lnInst')]

To Reproduce
I have not generated a reproduction case.
Additional context
I came across this as part of the oscd-subscriber-later-binding plugin.
I believe I have resolved this in the oscd-subscription-later-binding plugin but it has not yet been upstreamed to oscd-scl and until it is and the other subscription editors use this function they will have this bug.
https://github.com/danyill/oscd-subscriber-later-binding/blob/cb1a06ad2ca53908860110b206a492af5ad5b44d/foundation/subscription/subscription.ts#L122-L127

Still relevant and requires attention.


Steam crashes when opened

Describe the bug
The Steam application crashes when opened
Steps To Reproduce
Steps to reproduce the behavior:

Install Steam
execute steam e.g. from Bash

Expected behavior
I expected steam to open.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
[j@lear:~]$ steam
steam.sh[8697]: Running Steam on nixos 24.05 64-bit
steam.sh[8697]: STEAM_RUNTIME is enabled automatically
setup.sh[8777]: Steam runtime environment up-to-date!
steam.sh[8697]: Steam client's requirements are satisfied
[2023-12-19 12:01:41] Startup - updater built Dec  8 2023 00:32:59
[2023-12-19 12:01:41] Startup - Steam Client launched with: '/home/j/.local/share/Steam/ubuntu12_32/steam'
12/19 12:01:41 Init: Installing breakpad exception handler for appid(steam)/version(1702079146)/tid(8813)
Authorization required, but no authorization protocol specified

src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X
src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X
12/19 12:01:41 Init: Installing breakpad exception handler for appid(steam)/version(1702079146)/tid(8813)
/usr/bin/zenity: /home/j/.local/share/Steam/ubuntu12_32/steam-runtime/lib/x86_64-linux-gnu/libselinux.so.1: no version information available (required by /lib64/libgio-2.0.so.0)
/usr/bin/zenity: /home/j/.local/share/Steam/ubuntu12_32/steam-runtime/usr/lib/x86_64-linux-gnu/libxml2.so.2: version `LIBXML2_2.9.0' not found (required by /nix/store/x1swpwd1izrwbk1ksjg03zmpk6y8dj1h-appstream-0.15.5/lib/libappstream.so.4)
src/steamexe/main.cpp (1223) : failed to initialize update status ui, or create initial window
src/steamexe/main.cpp (1223) : failed to initialize update status ui, or create initial window
assert_20231219120141_4.dmp[8818]: Uploading dump (out-of-process)
/tmp/dumps/assert_20231219120141_4.dmp

[j@lear:~]$ assert_20231219120141_4.dmp[8818]: Finished uploading minidump (out-of-process): success = yes
assert_20231219120141_4.dmp[8818]: response: CrashID=bp-5733e3f7-da23-4623-876f-0e6272231219
assert_20231219120141_4.dmp[8818]: file ''/tmp/dumps/assert_20231219120141_4.dmp'', upload yes: ''CrashID=bp-5733e3f7-da23-4623-876f-0e6272231219''

Notify maintainers
@jagajaga
@jonringer
@bobby285271

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

[j@lear:~]$ nix-shell -p nix-info --run "nix-info -m"

system: "x86_64-linux"
host os: Linux 6.1.68, NixOS, 24.05 (Uakari), 24.05pre560622.91a00709aebb
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "nixos"
channels(j): "nixos-22.11"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

I'm using the nixos-unstable channel.

Add a :+1: reaction to issues you find important.

How did you "install" it?

I added steam to environment.systemPackages in my /etc/nixos/configuration.nix file.

Steam needs to set up extra stuff (such as 32-bit drivers which I think is the problem here), you should use programs.steam.enable = true instead.

As it turns out, programs.steam.enable = true was also in my configuration.nix.
I've disabled the environment.systemPackages entry, and still get the same issue.
So I guess the problem is with whatever programs.steam.enable = true does.

Hm, weird. Anyway, I think the initial problem is this here:

src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X
src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X

I think the libxml error is just a result of Steam trying to run zenity due it not being able to open its window to show an error message. Should probably be fixed as well but it's not the main problem.

Just rolled back to my previous system update @ December 15.
Steam works, confirming a window of 15-12-2023 - 19-12-2023 for this bug to have crept in.

Should probably be fixed as well but it's not the main problem.
I'm not really sure what that is though, or what to do about it.

Though if there's any other info or help I can provide, please let me know;
Steam works, but I'm invested in this bug being squashed quickly, because I use an NVidia card.
The driver for NVidia cards is recompiled for each kernel update (breaking the other kernels w.r.t. gfx accel), and so games have a horrible frame rate.

I am having the same problem with an NVidia GPU running on KDE.

An AppStream PR was merged by @bobby285271 about 2 weeks ago.
I can't say for sure, but given the delay between merge and it popping up in unstable, perhaps that backport is related?

Hm, weird. Anyway, I think the initial problem is this here:

src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X
src/steamexe/updateui_xwin.cpp (339) : Could not open connection to X

I think the libxml error is just a result of Steam trying to run zenity due it not being able to open its window to show an error message. Should probably be fixed as well but it's not the main problem.

Are you using a Wayland-based desktop environmnent such as GNOME? Maybe Xwayland is missing in your setup.

Can't open it too when running on Plasma (X11), although it works when starting with Plasma (Wayland).

Same exact issue with an AMD card, using the mesa packages (mesa.driver + 32bit and mesa.opencl) on KDE Plasma X11.

Are you using a Wayland-based desktop environmnent such as GNOME? Maybe Xwayland is missing in your setup.

I am using KDE / Xorg.
I did try KDE / Wayland today, but Steam itself was flickering so wildly it was plausibly seizure-inducing.
That's something I've never seen before on Xorg, so I went back to my regular KDE / Xorg session.

Pinning just the steam package to revision 195248b  lets it work again. This is the commit just before the three last commits (on 2023-12-14) to the steam package.
It would seem the first of those three commits (195248b) is what broke steam as none of the later ones work.

Pinning just the steam package to revision 195248b lets it work again.

I'm guessing you mean pinning to db04185bc923d2b168a5dd3b2aa05b7627fda5d6 works, idk what happened but previously for me steam was getting stuck loading after logging in.
I'm still getting a weird error that makes Steam switch between No Connection and Online and don't know the reason why it happens :sob:

Just for clarification, https://github.com/NixOS/nixpkgs/commit/195248b6c101f3d58002d5c7e15be38231780786 doesn't work for me, but it's parent 452b8162ecc995793d906cde424b652fa3dd1314 does work. I am testing with nix run nixpkgs/HASH#steam though, so it may have different results when installed.

Yeah that makes more sense lol

@ImUrX Almost, I meant 452b816 - like @huantianad mentions. Sorry - copy-paste fail from my side.

Just for clarification, 195248b doesn't work for me, but it's parent 452b816 does work. I am testing with nix run nixpkgs/HASH#steam though, so it may have different results when installed.

Same here on KDE/Xorg with intel gpu
Current nixos-unstable is broken, 452b816 works fine for me

Can confirm that the solution mentioned by @huantianad seems to temporarily resolve the issue. (Thanks! :blush:)
nix run --impure nixpkgs/452b8162ecc995793d906cde424b652fa3dd1314#steam

Same -- not working on X11/AMD, does work on Wayland though. Works on X11 if I revert to my previous generation.

Can also confirm the same issue on X11/KDE and Nvidia GPU. Reverting to a generation from last week also works for me as of now.

Binding my current xauth file into the FHS lets it load with X11 - - trying to figure out how to predictably know what the name will be or find another way to ensure this is available inside the environemnt.
In fhsenv.nix:
  extraBwrapArgs = [
    "--bind-try /tmp/dumps /tmp/dumps"
    "--bind-try /tmp/xauth_AeHaYj /tmp/xauth_AeHaYj" # addition
  ] ++ args.extraBwrapArgs or [];

It definitely works on some X11 setups as well. I tested it primarily on X11/i3.
I wonder if the location of the X authority is dependent on the display manager used? Can you all share what display managers you're using? I tested on lightdm with no problem.
I really should have made privateTmp an overrideable option on the steam package itself...

Plasma here -- Wayland working, X11 not working.

Display manager, not desktop environment. I'm guessing sddm, to go with plasma?

Yeah, sddm, sorry -- read on my phone and answered too fast :)

I think the reason for only triggering for sddm is this explanation from #273537

It turned out that these display managers set the XAUTHORITY environment variable to something other than $HOME/.Xauthority (/run/user/$UID/gdm/Xauthority in case of gdm, or /tmp/xauth_${random_string} in case of sddm >= 0.20),

Ok, so the proper fix is to add some bash code to buildFHSEnv that checks if XAUTHORITY starts with /tmp, and if it does, bind it to itself?

Fixed in the above PR. I also made privateTmp overrideable with steam.override, so you can turn it off if it's causing problems.

@tejing1 that is rather odd. I am using lightdm myself (mini-greeter) and I am experiencing crashes.

How does this work now that the PR is merged into master. Does it take a while for the update to show up on a nixos-rebuild command?

it will make its way into nixos-unstable once hydra finishes building the next batch of packages without blocking errors. You can track it with https://nixpk.gs/pr-tracker.html?pr=275857

Nice! I was tracking it (erroneously) with the backport gh action.

As I'd thought, the nixpkgs rev in my  flake.lock happens to be 91a00709aebb3602f172a0bf47ba1ef013e34835. Therefore it should already contain the buildFHS changes you submitted not so long ago, @tejing1.
I wonder what else could be causing this issue?

Thank you all for the quick fix :)

it will make its way into nixos-unstable once hydra finishes building the next batch of packages without blocking errors. You can track it with https://nixpk.gs/pr-tracker.html?pr=275857

Sorry to crowd this issue, had a question. How can one tell from Hydra whether this built successfully or not and is merged into nixpkgs-unstable?

You probably mean nixos-unstable rather than nixpkgs-unstable, and if so, the relevant jobset is nixos/trunk-combined. You can see the status of evaluations there and what commit of nixpkgs they're from. But it's hard to tell whether the channel advanced from the hydra interface, since it does advance in the presence of some errors.
Also, hydra doesn't actually build steam, because it's unfree, so there's no specific job to look at. If what you want to know is whether a given PR has hit unstable yet, alyssa's tracker is the best way.

@tejing1
Awesome, thank you

Can confirm that the solution mentioned by @huantianad seems to temporarily resolve the issue. (Thanks! 😊)
nix run --impure nixpkgs/452b8162ecc995793d906cde424b652fa3dd1314#steam

This doesn't quite work on my box, but the modified form
export NIXPKGS_ALLOW_UNFREE=1;  nix  --extra-experimental-features nix-command  --extra-experimental-features flakes  run --impure nixpkgs/452b8162ecc995793d906cde424b652fa3dd1314#steam

does work for me :)

@jjpe apologies, should've mentioned that I have both ALLOW_UNFREE=1 and experimental-features enabled in my flakes setup. Your command should work for everyone without the prerequisites that I'd mentioned.

I can confirm switching from sddm to lightdm with slick greeter fixes it for me, for some reason .Xauthority wasn't being created with sddm.

It's just how sddm chooses to place the x authority cookie. lightdm puts it in ~/.Xauthority, gdm puts it in /run/user/<uid> somewhere, and sddm puts it in /tmp/xauth_<random characters>. It normally doesn't actually matter where it puts it as long as the XAUTHORITY environment variable contains the path to it.
The problem here was that I changed the steam package's fhs environment to run with a separate /tmp in order to workaround a steam bug, and that broke sddm's placement.
The fix has now reached nixos-unstable, incidentally, so there should be no need to switch anymore. :-)

Can confirm that the changes you last merged fixed the issue. Appreciate the fix!


[EKF2] Indoor optical flow/Lidar Lite and Outdoor GPS/Optical Flow/Lidar Lite(Hand-held testing)

@priseborough @mhkabir @dagar

[EKF2] Indoor optical flow/Lidar Lite

We have expensive device mounted on the UAV, thus we would like to make sure that
our configuration and parameter setting is correct for indoor and outdoor hovering.
Thus, I have performed hand-held testing with optical flow and Lidar Lite indoor(not arming) based on EKF2, and record the flight log from boot until shutdown.
The following is the log from and-held testing.
EKF2_AID_MASK        | 3
EKF2_HGT_MODE        | 2
https://review.px4.io/plot_app?log=daf49809-eee3-4c90-ae22-75d78953978d
we would like to evaluate the EKF2 performance, for instance optical flow innovation, but python script does not work for this data.
It thinks that always on ground, always on ground and python scripts was not working.
kari@king:~/git/kari_ws/src/px4/Tools/ecl_ekf$ ./process_logdata_ekf.py /home/kari/Desktop/px4_log/log_0_no_flight_ekf2.ulg
found estimator_status data
found ekf2_innovation data
found sensor_preflight data
always on ground
always on ground
Traceback (most recent call last):
File "./process_logdata_ekf.py", line 778, in <module>
pp.savefig()
File "/usr/lib/python2.7/dist-packages/matplotlib/backends/backend_pdf.py", line 2483, in savefig
**kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1565, in savefig
self.canvas.print_figure(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/backend_bases.py", line 2232, in print_figure
**kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/backends/backend_pdf.py", line 2536, in print_pdf
self.figure.draw(renderer)
File "/usr/lib/python2.7/dist-packages/matplotlib/artist.py", line 61, in draw_wrapper
draw(artist, renderer, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1159, in draw
func(*args)
File "/usr/lib/python2.7/dist-packages/matplotlib/artist.py", line 61, in draw_wrapper
draw(artist, renderer, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/axes/_base.py", line 2324, in draw
a.draw(renderer)
File "/usr/lib/python2.7/dist-packages/matplotlib/artist.py", line 61, in draw_wrapper
draw(artist, renderer, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/text.py", line 757, in draw
raise ValueError("posx and posy should be finite values")
ValueError: posx and posy should be finite values

More specifically, I don't know why the value of pos_horiz_accuracy and pos_vert_accuracy is always zero. As fas as I know, proper EKF2 measurement update of optical flow and Lidar Lite was achieved, value of pos_horiz_accuracy and pos_vert_accuracy decreased.
pos_horiz_accuracy and pos_vert_accuracy is the standard deviation value of EKF2 horizontal(x, y), vertical(z states), and is the representation about how certain the states might be.
https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L3075-L3076
As you can see above lines,
if (status_flags.condition_home_position_valid && status_flags.condition_global_position_valid) {
led_color = led_control_s::COLOR_GREEN;

https://docs.px4.io/en/flying/led_meanings.html
(We have external GPS with LED).
When pos_horiz_accuracy and pos_vert_accuracy is below the threshold(https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1123-L1124),
then status_flags.condition_home_position_valid = true(
https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1147)
and
In following lines(https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1997-L1998
https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L3548),
check_posvel_validity PX4 firmware check also COM_HOME_H_T and COM_HOME_V_T params to understand the EPH and EPV thresholds used to accept the respective EPH and EPV published in the vehicle_global_position & vehicle_local_position msgs.
Then the above two conditions are met,
LED of GPS turn to be green, which means I can change to position_hold mode from stabilized mode.
From what I understand about the pos_horiz_accuracy and pos_vert_accuracy
When we used LPE instead of EKF2, we always saw that LED of GPS turn to be green indoor if optical flow measurement and LiDAR measurement was correct. And I was able to change into position_hold mode indoor successfully.
However, in EKF2
as you can see vehicle_local_position.eph & epv is zero, and pos_horiz_accuracy and pos_vert_accuracy is zero. It looks quite weired. If I see pos_horiz_accuracy and pos_vert_accuracy in analyser Tool in QGC, they were always zero as well, which does not makes sense to me.
In addition, It seems to me that status_flags.condition_home_position_valid  is not set to be true indoor.
In LPE, when FAKE_ORIGIN was set to be true in indoor, status_flags.condition_home_position_valid  is set to be true.
https://github.com/larics/px4-firmware/blob/master/src/modules/local_position_estimator/BlockLocalPositionEstimator.cpp#L393
By monitoring the green light of LED attached to UAV, I was confident that position mode will not be rejected in indoor, since pos_horiz_accuracy and pos_vert_accuracy is below the threshold, and home_position is valid.
Actually, there were someone who tried to add the functionality in EKF2 such as FAKE_Origin of LPE in order to perform automission indoor (http://discuss.px4.io/t/fake-origin-in-ekf2-for-indoor-vpe-mission/5069)

To summarize,
My question is as follows:

Do you think that hand-held testing indoor/outdoor help to make sure the our configuration and parameter setting is correct for indoor and outdoor hovering?

Does this log look okay?

Optical flow innovation looks okay to me,
and down position innovation which is vel_pos_innov[5] looks good to me based on LiDAR Lite v3.

The value xy_valid does not look okay from times to times.
https://github.com/PX4/Firmware/blob/master/src/modules/ekf2/ekf2_main.cpp#L1034
https://github.com/PX4/ecl/blob/master/EKF/ekf_helper.cpp#L1259-L1268
The meaning that the value of xy_valid is zero is that we are totally reliant on inertial dead-reckoning for position, and that might be caused by sensor timeout for optical flow(Because I set to use optical flow indoor)
However, if you see the quality of optical flow, it was almost the maximum value(255) for the most of the time, and I don't know why time-out of optical flow measurement update occurred. That means that time between consecutive optical flow measurement is larger than update _params.no_aid_timeout_max(1s).
bool optFlowAiding = _control_status.flags.opt_flow && (_time_last_imu - _time_last_of_fuse <= _params.no_aid_timeout_max

why the value of pos_horiz_accuracy and pos_vert_accuracy is always zero?

It also looks strange that ulog from following link also shows that pos_horiz_accuracy and pos_vert_accuracy is always zero.

(https://github.com/priseborough/PX4-Firmware-private/issues/2)
https://github.com/PX4/Firmware/blob/master/msg/estimator_status.msg#L67-L68
float32 pos_horiz_accuracy # 1-Sigma estimated horizontal position accuracy relative to the estimators origin (m)
float32 pos_vert_accuracy # 1-Sigma estimated vertical position accuracy relative to the estimators origin (m)

Even if optical flow measurement update only provide LOS(Line of Sight) velocity measurement related Vn(Velocity for North direction), Vd(Velocity for Down direction), pos_horiz_accuracy and pos_vert_accuracy should be always decreased when the optical flow measurement update is performed correctly for EKF2.
More specifically, if we perform the observability analysis and analyse the rank of observability matrix , we will be able to conclude that we can deduce the information about the horizontal position and vertical position from the optical flow measurement.
Since optical flow innovation looks quite reasonable,
pos_horiz_accuracy and pos_vert_accuracy should not be zero all the time.

we don't know why ./process_logdata_ekf.py python scripts is broken about this log. I guess that this python scripts was not designed to handle the this type of log such as hand-held testing.

However, do you think that python script will work if I arm the motor without propeller and perform hand-held testing?
Outdoor GPS/Optical Flow/Lidar Lite(Hand-held testing)
We have expensive device mounted on the UAV, and recently have experienced a few significant crash.
We would like to make sure that everything(UAV configuration & Sensor calibration & Parameter Setup) is okay for posCTRL mode and Auto Mode before real-flight.
This is the results of outdoor hand-held testing
GPS altitude of both log looks quite strange.
position_0.xy_valid & position_0.z_valid looks strange.
Optical flow innovation look okay, but not the optimal.

https://review.px4.io/plot_app?log=6c3473c4-3d9c-4a2a-a748-0247d823f53f

https://review.px4.io/plot_app?log=d49ccaaf-3b83-4ae9-a98d-72ab244a2f9c

This question has been quite a long, and would you please have a look at it?

Python script should  work if you arm the motors (without propellers) , advance throttle to prevent disarm and do the hand carry test. Disarm to stop logging,
The commit hash indicates the OP generated these logs using v1.7.3 stable. I have had a look and the innovation sequences look OK. I have tried replaying the logs and unfortunately there are large dropouts of over 600mSec that prevent use of log replay as a diagnostics tool.
These look like they are the result of an SD card with large write time spikes relative to the amount of data that the PX4 logger can buffer.
Solutions to this are:
Using a better SD card - See https://dev.px4.io/en/log/logging.html . I use the SanDisk Extreme U3 32GB.
Increasing the buffer RAM allocation using the LOGGER_BUF parameter. You can use the nsh console to check the amount of free contiguous RAM.

@priseborough
Thank you for the cooperation,
and I have seen that pos_horiz_accuracy and pos_vert_accuracy was always zero even in QGC analyser during the test.
It also looks strange that ulog from following link also shows that pos_horiz_accuracy and pos_vert_accuracy is always zero.

why the value of pos_horiz_accuracy and pos_vert_accuracy is always zero?

(https://github.com/priseborough/PX4-Firmware-private/issues/2)
https://github.com/PX4/Firmware/blob/master/msg/estimator_status.msg#L67-L68

@priseborough

LOGGER_BUF
LOGGER_BUF cannot be found in https://dev.px4.io/en/advanced/parameter_reference.html
but found in  https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d/rcS#L198
As far as I understand, I need to create a file /fs/microsd/etc/rc.txt, which is located in the etc folder on the microSD card to increase LOGGER_BUF. In /fs/microsd/etc/rc.txt, I need to increase the value of LOGGER_BUF. Am I right?
In most cases customizing the default boot is the better approach, which is documented below. If the complete boot should be replaced, create a file /fs/microsd/etc/rc.txt, which is located in the etc folder on the microSD card. If this file is present nothing in the system will be auto-started.
(https://dev.px4.io/en/advanced/system_startup.html)

You need a better SD card. Do not modify the logger buffer without knowing what you're doing and checking free RAM.


⚡ Optimise gas usage when enabling p256 validator, add a few comments

Reducing the number of indexed variable inside a log highly decrease his gas usage, in the p256 validator, we only matter about the kernel account as index (it's 375 gas per topic, so per indexed props, so reducing the index on both key reduce the enabling gas cost by 375 * 4 -> 1500 gas)
Add a few reflexion todo comment, do you rly need to send the previous key in the event? Since it's cost with a sload& memory used for the event itself

Makes sense on the sload stuff and the event issue.
@de33 do you want to comment on the usage of the oldKey?

@KONFeature i think we can just remove the oldKey

Main purpose of this is allowing both eth signed/non signed message to achieve backward compatibility.
I do hope that we dont have to do it this way but there are still some dapps that has non eth-signed messages
If you have some opinion on this, i am ipen for discussion

Yeah, I think that make sense for the ecdsa validator since it's the most common way to sign a message, so the easiest way to integrate it, and the gas impact is not very high.
But for the p256 signer, since the gas impact would be really huge, picking only one type of signature wanted is the way to go in my opinion.
I think the use of the userOpHash directly, so without the ethereum sign message prefix, since it's adding some gas overhead also, would be better.
If asked by community or other project, we can have two p256 signer deployed, one with eth sign mesasge & the other without it using direct userOpHash signature


[Story]: Regression in modelmesh modal for tokens

Goal
In ManageServingRuntimeModal we have a regression when selecting Token authorization, it no longer automatically generates the first token
Dependency issue
No dependencies
Itemized goals

Fix a regression
To reproduce, create a new Model Server in modlemesh
Select token authorization
It should present a default token, but right now it's not there

Aspects continued elsewhere
No response
Mocks
No mocks

I need to correct something here. When you select token authorization, the default service account will show up. The problem is when you select model route, it will automatically select token authorization, and only in this case, the default token will not be generated.


[Event Request] Codeunit 7021 Purchase Line Price PROCEDURE IsPriceUpdateNeeded() - OnAfterIsPriceUpdateNeeded

Please add an Event OnAfterIsPriceUpdateNeeded in Procedure IsPriceUpdateNeeded in Codeunit 7021 - Purchase Line Price
PROCEDURE IsPriceUpdateNeeded(AmountType: enum "Price Amount Type"; FoundPrice: Boolean; CalledByFieldNo: Integer) Result: Boolean;
    begin
        if PurchaseLine."Prepmt. Amt. Inv." <> 0 then
            Result := false
        else
            if FoundPrice then
                Result := true
            else
                Result :=
                    Result or
                    not ((CalledByFieldNo = PurchaseLine.FieldNo("Job No.")) or (CalledByFieldNo = PurchaseLine.FieldNo("Job Task No.")) or
                         (CalledByFieldNo = PurchaseLine.FieldNo(Quantity)) or
                        ((CalledByFieldNo = PurchaseLine.FieldNo("Variant Code")) and not IsSKU));

        OnAfterIsPriceUpdateNeeded(Result,PurchaseLine,CalledByFieldNo,IsSKU); <-- NEW EVENT
    end;

    [IntegrationEvent(false,false)]
    local procedure OnAfterIsPriceUpdateNeeded(var Result: Boolean; PurchaseLine: Record "Purchase Line"; CalledByFieldNo: Integer; IsSKU: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49559.


Fix run_tests.py

Closes #94

FYI @bqpd. I'm actually just going to merge this. It's a 2-line change to get unit tests to work.

Looks good!


Only validate the visible area

To speed up the URL validation only validate the visible are of the ScintillaNET. Thanks to @Sigmanor for pointing out the performance issue with large files 👍

Hi. I updated the NuGet and the repository to only mark URLs on the visible contents of the control. TODO: Next do the same to the VPKSoft.ScintillaSpellCheck.

I'll leave this open for a few weeks for improvement suggestions and/or bug reports...

At least the update seems to be working fine with one of my project:

@VPKSoft Seems now it work fast, I will test it more closely later. Thank you ☺

@VPKSoft I tested it in more detailed, and seems everything is working fine now, thanks again.

Closing as resolved.


cmd/go: import paths can contain the .test suffix, breaking the toolchain

What version of Go are you using (go version)?

$ go version
go version devel go1.21-231f290e51 Sat Apr 8 05:25:04 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
Given
-- foo/foo.go --
package foo

import _ "example.com/foo.test"
-- foo/foo_test.go --
package foo
-- foo.test/bar.go --
package bar
-- go.mod --
module example.com

go 1.21

run go test ./foo
What did you expect to see?
One of

no error
an explanation for the error
an explicit error forbidding using foo.test as an import path

What did you see instead?
/home/dominikh/prj/go/pkg/tool/linux_amd64/link: fingerprint mismatch: example.com/foo.test has 36b962da8ceb542c, import from example.com/foo expecting aa419b4c2ff8e5ed

(CC @matloob)

an explicit error forbidding using foo.test as an import path

This would be my personal choice - even if supporting such package paths is technically possible, it feels like something we should strongly discourage due to the confusion it could cause.
We always have to worry about backwards compatibility, but... is anyone even declaring such packages today?

I've been using .test modules (note, not packages per se) for writing examples or tests, because that TLD is guaranteed not to exist (https://en.wikipedia.org/wiki/.test). But, it's also possible to .example or .invalid as an alternative.

@egonelbre you can just name those test/..., per https://github.com/golang/go/issues/37641.


Automated cherry pick of #2730: fix: s3cli enable debug trace

Cherry pick of #2730 on release/2.12.
#2730: fix: s3cli enable debug trace

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@7d7b486). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #2732   +/-   ##
==============================================
  Coverage                ?   7.23%
==============================================
  Files                   ?     472
  Lines                   ?   74406
  Branches                ?       0
==============================================
  Hits                    ?    5382
  Misses                  ?   68571
  Partials                ?     453

Flag
Coverage Δ

#aFlag
7.23% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7b486...2e5ac63. Read the comment docs.

/approve
/lgtm


Add wet deposition

Codecov Report

Merging #10 (430e9c8) into main (c312b3c) will increase coverage by 0.91%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   92.75%   93.67%   +0.91%
==========================================
  Files           3        4       +1
  Lines         138      158      +20
==========================================
+ Hits          128      148      +20
  Misses         10       10

Impacted Files
Coverage Δ

src/DepositionMTK.jl
100.00% <ø> (ø)

src/wet_deposition.jl
100.00% <100.00%> (ø)

Same as https://github.com/ctessum/atmos/blob/master/emep/wetdep.go.
Unfortunately, the reference link (www.emep.int/UniDoc/node12.html) is no longer available.


Typo in units.csv and request for times multiplication symbol

Hi.
Sorry to disturb you.
When I tried to use the coulomb measurement ubit, it didn't work.
I realized, as in the attachement, that there was a typo in the unit.csv file, probabbly it is necessary to remove the character ".
By the way, in LaTeX SIunits, when you type the scientific notation the multiplication sign is a times and not a dot. Could it be possible to have the possibility tto choice between a dot or times symbol also in your package (I attach a file to be clearer).
Thank a lot and sorry for my bad English.
Best regards,
Roberto
units.csv.pdf
Generic.pdf

Your first remarks was fixed in #8. Thank you for noticing.
As for your feature proposal, that is a good idea. I will look into it myself, but I'm also open to merge requests.

@RungeCC added an argument to the num etc functions to change the multiplier in #17, e.g.
$#num("1e9", multiplier: "times")$.
This addresses your issue sufficiently?


AsyncWorkService DS Integration

This PR introduces code which integrates the AsyncWorkService interface and DS so that DS will utilize a user-provided service which implements the AsyncWorkService interface if it exists. If not, a fallback solution (boost::asio thread pool) is used instead.
If a user provides a service which implements the interface at some point, DS will switch to using that service.
Todo:

[x] Write integration code for DS
[ ] Write tests

Codecov Report

Merging #599 (6a45125) into development (3524f62) will increase coverage by 0.00%.
The diff coverage is 70.45%.

@@             Coverage Diff              @@
##           development     #599   +/-   ##
============================================
  Coverage        89.80%   89.81%
============================================
  Files              243      246    +3
  Lines            10548    10467   -81
============================================
- Hits              9473     9401   -72
+ Misses            1075     1066    -9

Impacted Files
Coverage Δ

...m/DeclarativeServices/src/ComponentContextImpl.hpp
100.00% <ø> (ø)

...ompendium/DeclarativeServices/src/SCRActivator.hpp
100.00% <ø> (+100.00%)
:arrow_up:

...ativeServices/src/manager/ComponentManagerImpl.hpp
83.33% <ø> (ø)

...tiveServices/src/manager/ConfigurationNotifier.hpp
100.00% <ø> (+12.50%)
:arrow_up:

...um/DeclarativeServices/src/SCRAsyncWorkService.cpp
56.36% <56.36%> (ø)

...ompendium/DeclarativeServices/src/SCRActivator.cpp
66.66% <60.00%> (+2.44%)
:arrow_up:

...ium/DeclarativeServices/src/SCRBundleExtension.cpp
100.00% <100.00%> (ø)

...ativeServices/src/manager/ComponentManagerImpl.cpp
92.70% <100.00%> (-0.69%)
:arrow_down:

...tiveServices/src/manager/ConfigurationNotifier.cpp
81.81% <100.00%> (+0.44%)
:arrow_up:

...ervices/servicecomponent/runtime/dto/BundleDTO.hpp
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 53 more


undefined reference to '__atomic_load_8' over Raspberry OS Buster

Not sure if you met this problem or not
https://github.com/bazelbuild/bazel/issues/11761

This patch solved it for me. But I forgot that you have to install libatomic too, which I already had. So this should solve your problem:
sudo apt install libatomic1

thanks for quick reply. It is already installed. I guess probably link may be missing for src:bazel_nojdk
$ sudo apt install libatomic1
Reading package lists... Done
Building dependency tree
Reading state information... Done
libatomic1 is already the newest version (8.3.0-6+rpi1).
libatomic1 set to manually installed.
The following packages were automatically installed and are no longer required:
  g++-6 geoip-database gnupg-agent libass5 libavahi-core7 libavcodec57 libavdevice57 libavfilter6 libavformat57 libavresample3 libavutil55 libbabeltrace-ctf1 libblas-common libcdio-cdda1
  libcdio-paranoia1 libcdio13 libdaemon0 libdbus-glib-1-2 libdns-export162 libdrm-freedreno1 libebur128-1 libegl-mesa0 libegl1 libegl1-mesa libevent-2.0-5 libfile-copy-recursive-perl libgbm1 libgeoip1
  libgfortran3 libicu57 libisc160 libisccc140 libisl15 libjim0.76 liblwres141 libmagickcore-6.q16-3 libmagickwand-6.q16-3 libmpfr4 libntfs-3g871 libonig4 libopencv-core2.4v5 libopencv-imgproc2.4v5
  libperl5.24 libpostproc54 libpython3.5 libpython3.5-dev libpython3.5-minimal libpython3.5-stdlib libsndio6.1 libsodium18 libssl-doc libstdc++-6-dev libswresample2 libswscale4 libtxc-dxtn-s2tc
  libva-drm1 libva-x11-1 libva1 libvpx4 libwayland-egl1-mesa libwayland-server0 libwebpmux2 libx264-148 libx265-95 python-idna python-pyasn1 python3-certifi python3-chardet python3-idna python3-pyasn1
  python3-requests python3-urllib3 python3.5 python3.5-dev python3.5-minimal rename samba-common sgml-base tcpd update-inetd xml-core
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

That's weird, and you installed all requirements with sudo make requirements?
I'll take a look at it later, but in the mean time you can build the 3.3.1 version or use the 3.4.0 binary in the releases.

yes, I did.

I can't reproduce this. Can you give me some more information?

Does this happen in the "Building Bazel from scratch" or "Building Bazel with Bazel" phase?
What's the output of uname -a?
What's the output of lsb_release -a?
What's the output of dpkg -l openjdk-11-jdk-headless?
What's the output of update-alternatives --config java?

I reboot the pi and seems like it is good now. Thanks for all nice work!


Rename EN TOC menu name for API Documentations

The name API Guide seems not following the usual naming conventions within docs. This PR is going to change it.
Signed-off-by: imjoey<EMAIL_ADDRESS>

@imjoey Thanks!


data privacy policy

Hello,
Im using CVAT for a company project. I have tested it and plan to upgrade to pro. My management concern is related to data privacy. Is the data deleted at the same time I delete it from my online repository? Is the data and annotations I have done kept somewhere safe and not distributed further? It would be nice if you could have some details.
Best regards,
Roberts

@neorosynapse ,
Please read our privacy and terms of use policies:

https://www.cvat.ai/privacy
https://www.cvat.ai/terms-of-use

Is the data deleted at the same time I delete it from my online repository?

If you delete a project or task, all related data will be deleted as well.

Is the data and annotations I have done kept somewhere safe and not distributed further?

All data is kept inside our DB on an AWS instance. It is safe and not distributed further.
We are ready to collaborate with your company to provide any other requested information. Don't hesitate to contact us using https://www.cvat.ai/get-in-touch
I will close the issue.


TTS websocket tests

Summary
Originally wrote these tests as part of https://github.com/Phonic-Co/phonic-api/pull/1 but we decided it would be better to put them with the Node SDK.
Test Plan
Tested locally with bun test:
✓ tts.websocket > can't connect to websocket [38.75ms]
✓ tts.websocket > invalid api key [24.04ms]
✓ tts.websocket > receive config message [513.29ms]
✓ tts.websocket > generate(short)-flush [3905.36ms]
✓ tts.websocket > generate(medium)-flush [4604.91ms]
✓ tts.websocket > flush with no input [3202.33ms]
✓ tts.websocket > stop with no input [3202.66ms]
✓ tts.websocket > generate-stop [3202.19ms]
✓ tts.websocket > generate-flush-stop [3201.96ms]
✓ tts.websocket > flush while another flush is in progress [3803.55ms]
✓ tts.websocket > generate-flush and then generate-flush [7004.35ms]
✓ tts.websocket > generate-flush-stop and then generate-flush [6604.08ms]
✓ tts.websocket > generate(long)-flush [8406.73ms]

@moroshko CI is failing with a bunch of typescript errors but I'm not sure how to fix. I thought PhonicWebSocketResponseMessage is a discriminated union and typescript could use the "type" field to infer the other contents, but it seems like it can't. Do you have suggestions on how to fix?

@moroshko CI is failing with a bunch of typescript errors but I'm not sure how to fix. I thought PhonicWebSocketResponseMessage is a discriminated union and typescript could use the "type" field to infer the other contents, but it seems like it can't. Do you have suggestions on how to fix?

@jamin-chen The problem is not the discriminated union but the fact that TypeScript doesn't know that messages would have the amount of items that you expect. From TypeScript's point of view, messages type is PhonicWebSocketResponseMessage[], which can also be an empty array. That's why, when you access the individual items, TypeScript thinks it can be undefined. And, indeed, if for whatever reason, you do const messages = await waitForMessages(3); and waitForMessages only returns 1 item, messages[1] will be undefined which will return an an error being thrown when you access its type.
The simplest way I can think of to fix this, is to check first that we indeed have the amount of messages that we expect:
const messages = await waitForMessages(3);
const [message1, message2, message3] = messages;

if (message1 === undefined || message2 === undefined || message3 === undefined) {
  throw new Error(`Expected to get 3 messages, but got only ${messages.length}`);
}

expect(message1.type).toBe("config");
expect(message2.type).toBe("audio_chunk");
expect(message3.type).toBe("flush_confirm");

@jamin-chen In addition to the above, if you'd like to check type-specific fields like:
expect(message2.type).toBe("error");
expect(message2.error.code).toBe("flush_in_progress");

you could do:
expect(message2).toEqual({
  type: "error",
  error: {
    message: expect.any(String),
    code: "flush_in_progress",
  },
});


Opt-in possible with free version of  CookieConsent?

Is the advanced usage possible without buying a business version of osano CookieConsent JS-libary?
I#am looking forward to your answer!
Greetings,
Christiana

Thanks for opening this Issue!
I'm not sure. I will check it out.

@ChristianaHoJo
It is possible to use the advanced options with the Open source JS-Library.
To use the advanced options you can use the Custom Config section on the Plugin-Page in the Admin area.
There is a known Issue while using the callbacks. I will fix this in the Future.
See the documentation of Cookie consent for more informations.


scripts: Don't erase gopath.proto after genproto.sh

Wiping gopath.proto after a successful run does nothing but slow down
the next run unnecessarily as it downloads everything again.

lgtm


JupyterQ incompatible with Python 3.8?

I just installed the latest miniconda3 for windows 64bit. When I hit the command
conda install -c kx jupyterq
Then it says
UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - jupyterq -> python[version='>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

Your python: python=3.8

If python is on the left-most side of the chain, that's the version you've asked for.
When python appears to the right, that indicates that the thing on the left is somehow
not available for the python version you are constrained to. Note that conda will not
change your python version to a different minor version unless you explicitly specify
that.

The following specifications were found to be incompatible with your CUDA driver:

  - feature:/win-64::__cuda==9.1=0
  - feature:|@/win-64::__cuda==9.1=0

Your installed CUDA driver is: 9.1

Sounds like jupyterQ is incompatible with python 3.8? Can you update your package in conda?

Thanks for this but it is still actually the same. Do I miss some steps?
c:\xxx> conda install -c kx jupyterq
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: -
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - jupyterq -> python[version='>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

Your python: python=3.8

If python is on the left-most side of the chain, that's the version you've asked for.
When python appears to the right, that indicates that the thing on the left is somehow
not available for the python version you are constrained to. Note that conda will not
change your python version to a different minor version unless you explicitly specify
that.

The following specifications were found to be incompatible with your CUDA driver:

  - feature:/win-64::__cuda==9.1=0

Your installed CUDA driver is: 9.1

Hi @kamchan0
We're presently having some issues deploying the windows builds to Conda, while releasing the jupyterq version we're also releasing an update to embedPy. We've been able to deploy Linux and Mac 3.8 versions so far for embedPy and are working on a fix for the windows deployments. I'll have a member of the team update here by EOD tomorrow with progress if we haven't been able to get a fix in place before then.
All the best,
Conor

Hi @kamchan0
This is proving more difficult to change than had been expected. Python 3.8 modified how it provides support for using python in embedded settings in 3.8 as outlined here, we're currently working on a fix but at present do not have a hard timeline on which we expect to have this updated. I'll revert here once we make progress on this matter.
All the best,
Conor

Issue closed with release 1.1.8, should now be available via conda install for mac, Linux and windows


NestedSet::Recover() method in nestedSet does not calculate level

When I used recover function on my NestedSet table, column representing the level of node in tree was not recalculated correctly.
Probably there is missing a variable setter in the method.
Edit: probably the verify method will have a bug too with wrong level numbers

+1

Is this related to #1568?

I think yes, it is


WL-4791: Incorrect name displayed in Forums widget

Changing the name displayed  to the person who created the conversation rather than the last person to have changed or updated it.

We aren't returning the wrong data in the JSON, it's just the variable naming isn't ideal.  This was just a quick fix.

But yes it'd be good to clean this up....

The variable name is wrong and it's not just a internal variable it's the published API which has this wrong variable.

I've made the naming consistent.

Yes good one....

I've separated out the exception logging so it makes more sense now.


code guru

Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

Relevant Issues : (compulsory)
Relevant PRs : (optional)
Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

PR requested to the wrong branch. Unintentional.


Fix missing yq dependency in kcp-registrar Dockerfile

Includes some cosmetic changes:

Double quoting strings
Use the same options for curl
Creation of KCP_VERSION_SHORT var instead of inline processing

Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

/lgtm


Release Log consistency is broken by site/repo etc.

Please take a look: https://crystal-lang.org/

nobody updates it's changelog.

Please see a repo - again.
Changelog propagation failed.

Sorry, I don't understand what you mean.

Please see actual list: https://github.com/crystal-lang/crystal/milestone/22?closed=1
Now see RELEASE NOTES at https://crystal-lang.org/
And now see at https://github.com/crystal-lang/crystal/blob/master/CHANGELOG.md

There are no release notes for 0.24.0. Nobody wrote that and maybe nobody will. The changelog is in the 0.24.0 branch, not merged to master yet. I see no problem here.

I think he means that the Crystal Website is not updated with the release for Crystal version 0.20+. As crystal is already at 0.23.1, it looks like Crystal has not had a official update in over a year ( See bottom of the page ).
Crystal 0.20.0 released!	22 Nov 2016
Crystal 0.18.0 released!	14 Jun 2016```

Those are just blog posts associated with some releases. Not every release gets a blog post.
The website is probably misleading in that sense.

IMHO lack of complete release notes/changelog on the website (even just pointing to GH releases) and sparse activity on the blog gives misleading impression of project's inactivity and might undermine wow effect given by the first impression on the website (slick syntax + speed).

I'll update it 😄  Just show me where, and give me access to deploy!

@jwoertink https://github.com/crystal-lang/crystal-website


npm install -S email-templates: code 128 or ENOGIT

Hi,
I get a very strange behavior here since version 2.5.2 on a project using email-templates.
npm install -S email-templates throws either a bunch of 'addRemoteGit' warnings ending with a "ENOGIT error", or if git is installed, I get this kind of error :
npm ERR! node v4.6.0
npm ERR! npm  v3.10.8
npm ERR! code 128

npm ERR! Command failed: git -c core.longpaths=true clone --template=C:\Users\Maxime\AppData\Roaming\npm-cache\_git-remotes\_templates --mirror git@github.com:niftylettuce/consolidate.js.git C:\Users\Maxime\AppData\Roaming\npm-cache\_git-remotes\git-github-com-niftylettuce-consolidate-js-git-26f53914
npm ERR! Cloning into bare repository 'C:\Users\Maxime\AppData\Roaming\npm-cache\_git-remotes\git-github-com-niftylettuce-consolidate-js-git-26f53914'...
npm ERR! Host key verification failed.
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.

Apparently in both cases, it attempts & fails to fetch the package consolidate.js from github.
Note that previous release npm install -S<EMAIL_ADDRESS>installs without any problem.
Ran on babun/cygwin on Windows 10.
With regards.

I have the exact same configuration, and the same error, so for now I am locking on v2.4.1, but it would be nice to continue on the new release version.

Windows isn't officially supported though. 🤔

Same thing on Linux.
This is a serious issue with automatic deployments.
The package "consolidate.js" should be available on npm, even just for a fact of "version safety".
Sticking with v2.4.1 for now.

Hi everyone - I just was given collaborator status on consolidate.js and I will be publishing a new version of it, and subsequently a new version of email templates.  Thanks for your patience.

Please use latest version v2.5.4 from NPM via npm install --save email-templates@latest.


Version 2.10.0 (in progress)

We have been hard at work on JSHint version 2.10.0 for over six months now. We're still working, but I'm opening this pull request today in order to give folks a better view into our progress.
Here's a high-level summary of what the next version contains and what we hope to implement before releasing:

[x] New esVersion: 2016

Exponentiation operator
Restrictions on the function form of the "use strict" directive

[ ] New esVersion: 2017

Async functions
Trailing commas in parameter lists

[x] unstable configuration

Generic support
Options

Object "rest" properties

[x] New linting option: leanswitch

If you're interested in adding a new feature to JSHint, we encourage you to work from this branch. However, since we continue to publish bug fixes under the 2.9 release train, we reserve the right to rebase this branch. You should also be prepared to rebase your pull request as requested. (This is a more advanced workflow for git, and we'll be happy to assist you as necessary.) Those following along should also note that commits referenced on pages for merged pull requests may be present here under a different SHA.

This branch now supports trailing commas in parameter lists, making async functions the final big hurdle

Great news, folks! Following some stellar work by a couple first-time contributors, I finished up support for async functions. @rwaldron provided excellent review, so everything we set out to do for version 2.10.0 is complete. More than that, actually: we have asynchronous iteration done, too!
You can expect a release on 2019-02-04

I'm so happy about the headway made on this and the contribution you've received to!
I'd be lying if I'd say the first thing that I've done upon receiving this comment was not integrate the current code state into JSFiddle, happy to say it works perfectly fine!
Again, such a fantastic job!

Thanks so much, Oskar! JSHint version 2.10.0 is now published.


Reorganize packages directory.

Description
Provides a refactor (move) of many of the packages inside the packages directory to a more friendly location.
Highlights of note

Move component packages to packages/components.

outline-core-link
outline-form (needs update)
outline-styled-text (needs update)

Create directory for controller packages at packages/controllers.
Move documentation related packages and components to packages/documentation.

outline-docs
outline-examples
outline-static-assets
outline-storybook
outline-style-guide

Move majority of 'dated' packages to packages/components/@deprecated.

These packages are either completely deprecated or in need of an update for 2023 to our new outline-core-* format, and pass audits for a11y, and ensuring alignment with the (currently internal) Design Starter Kit.
The list currently includes: outline-accordion, outline-admin-links, outline-alert, outline-breadcrumbs, outline-button, outline-button-group, outline-card, outline-code-block. outline-container, outline-dropdown, outline-grid, outline-heading, outline-icon, outline-image, outline-image-slider, outline-include, outline-link, outline-list, outline-modal, outline-tabs, outline-video-vimeo, outline-video-youtube.

Move tooling related packages to packages/tools.

outline-cli
outline-config
outline-tokens

Update yarn workspaces
https://github.com/phase2/outline/blob/e6639b2855a77866a79f384438af7cc268ceff2f/package.json#L13-L19
Organize most components/packages to subdirectories
Currently outline-core and outline-templates are currently left in the root of packages. These should likely move as well now or in the future.
https://github.com/phase2/outline/tree/e6639b2855a77866a79f384438af7cc268ceff2f/packages

Will be reworking this PR through a new branch/workstream.


[$125] [Ideal nav] Android - No bottom margin under the sign out button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Click on settings
Scroll down to the bottom of the page
Hold on the sign out button (don't click it, but hold on it)

Expected Result:
There is a bottom margin under the sign out button
Actual Result:
There is no bottom margin under the sign out button which is inconsistent with other platforms like mWeb
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/a1e889e5-9a0b-4fe3-b90e-72becf49a711

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0153b4e342ae26d6b3
Upwork Job ID:<PHONE_NUMBER>575195648
Last Price Increase: 2024-04-12
Automatic offers:

Krishna2323 | Contributor | 0

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - No bottom margin under the sign out button
What is the root cause of that problem?
we dont have any bottom margin in the general info section inside the settings page:
https://github.com/Expensify/App/blob/89203217deb89c8392c5640614cefe73aa9ef436/src/pages/settings/InitialSettingsPage.tsx#L230-L236
What changes do you think we should make in order to solve the problem?
we need to add  an appropriate margin: ...styles.mb4,

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - No bottom margin under the sign out button

iOS - ios also has padding issue

What is the root cause of that problem?
Bottom padding is missing scroll view container
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/935df862efe9b251fa0a6d4268a17cf518c1f467/src/pages/settings/InitialSettingsPage.tsx#L479-L486
On adding bottom padding to style, it didn't fix the issue
style={[styles.w100, styles.pt4, styles.pb4]}

Instead added vertical padding to content container style it fixed for both ios and android, and removed padding from style.
Using padding vertical for consistent padding vertically instead of using top and bottom separately.
contentContainerStyle={[!isAfterOnLayout && !!scrollOffset && {marginTop: -scrollOffset}, styles.pv4]}
style={styles.w100}

THIS CODE IS TESTED LOCALLY
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

CC: @Expensify/design is this a problem?

I would say this is a very very small problem. Ideally yes there should be some margin below that nav item, but I'd consider it pretty low priority since it doesn't break anything visually or functionally.

Yeah, I agree with Danny. I guess we could use the same amount of padding we have on the left/right to use at the bottom?

I would bring the payout down to $250 or even $125 though, I think this is going to be a very simple fix.

Sounds good!

Eugene, what's your ETA on reviewing these proposals? Thanks!

@eVoloshchak what do you think of the above proposals?

This seems a regression from https://github.com/Expensify/App/pull/38274 which added style styles.pt4 to scrollview that move the scrollview content bottom with this padding value, I think the style should set to contentContainerStyle instead of style

That is correct, thanks for linking that PR @ahmedGaber93!
All proposals use similar approach, with the first one coming from @Krishna2323
The proposed approach looks good to me
🎀👀🎀 C+ reviewed!

Thanks for the ping! Looks like Melvin's automation didn't run 🙈
Payment summary:

@Krishna2323 $125 paid ✔
@eVoloshchak $125 - please request in ND

$125 approved for @eVoloshchak


Details / Summary html component

🚀 Feature
A callout that functions like the HTML details tag
Have you read the Contributing Guidelines on issues?
yes
Motivation
I was trying to put logs in my documentation and it was not ideal because I had to use HTML for all the content inside the details tag
Pitch
Syntax (nothing new):
:::details This is the summary of the content inside this callout

This

is

the

the

very

long

content

:::

Hi,
There are many example of details/summary view on this D2 website:
https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/default_props
MDX currently has some limitations, it does not have proper support for "markdown interleaving"
The trick is to skip lines around your details content, and MDX will understand that the inner content is MDX, and you'd be able to use MDX syntax.
https://raw.githubusercontent.com/typescript-cheatsheets/react-typescript-cheatsheet/master/docs/basic/getting-started/default-props.md

Anyway, I wouldn't be against having first-class support for this kind of feature.
Also think we could style it a bit better, as I think it can be hard to see the "end" of the details view.
There are many advanced exemples possible here:
https://freefrontend.com/html-details-summary-css/
https://codepen.io/frogmcw/pen/deqRwa
Can be an issue for MLH

I have prepared a demofor what it should look like.
It is based on the proposed design for #2930

that looks good to me :)

@slorber Is it alright if I take up this issue to work on?

Hi @FocalChord
I think this should be done in Infima, so I'm not against but we should see first with @yangshun if you can have access

@maximousblk will implement this in https://github.com/facebook/docusaurus/issues/2924
Do we really need to have a special syntax, or using details/summary tags with MDX is good enough?

it would be better to keep it consistent with other admonitions but it's fine if there's a reason to not do that.

We can add that :::details syntax but it would be a different feature as it requires extending the markdown syntax with remark. We may be able to leverage our existing admonitions plugin to do so.


Aligned the Scholarship title and content

Issues Identification

Closes: #324

Description

This update addresses the alignment issues of the Scholarship title and its corresponding content, enhancing the overall user experience.

Summary

Aligned the Scholarship title and content to ensure a consistent and visually appealing layout. This adjustment aims to improve readability and create a more professional appearance.

Details

Adjusted the CSS for the Scholarship title and content to ensure proper alignment.
Verified alignment across various screen sizes to ensure responsiveness and consistency in design.

Types of Changes

[X] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[X] Other (please describe): UI/UX

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] My changes do not break the current system and pass all existing test cases
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Screenshots

Additional Information
N/A

Can you add gssoc-ext and hacktoberfest-accepted lable

why are you creating pull request without assignment
the key to open source is patience
take this as my final warning if is see you doing this again i am blocking you


Atom crashes every time within a couple minutes of opening

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Hello,
I recently have had issues with ATOM crashing within a few minutes of opening.  Usually when opening or trying to save a file.  However, I can get the error just by clicking on the window.  I get the error "The editor has crashed.  Please report this issue to https://github/atom/atom."  I am using ATOM 1.53.0.  I am trying to run CQL-language plugin
I can reproduce the error with:

no packages installed
from the cmd line using:  atom --windows-clear
from the cmd line using:  atom --windows-clear10
from the cmd line using:  atom --safe even with a reboot

I have removed:
-Open JDK,

the C:/users/username/.atom folder
both C:/users/username/AppData/local/atom and C:/users/username/AppData/roaming/atom folders
Github Desktop and bash

I do not have a C:/users/username/.git folder.
After I clear the Windows state and if I have CQL language installed, I see the error:
"CQL language server stopped unexpectedly.
Error: Could not find or load main class org.opencds.cqf.cql.ls.Main Caused by: java.lang.ClassNotFoundException: org.opencds.cqf.cql.ls.Main", though this may not be the reason why ATOM is crashing.
Steps to Reproduce

just open atom from the desktop or the command line
click around a few time to view files. Now it will provide the error seen above.

Expected behavior:
I expect to view and save files
Actual behavior:
I get a crash within a minute or so.
Reproduces how often:
100%
Versions
Atom    : 1.53.0
Electron: 6.1.12
Chrome  : 76.0.3809.146
Node    : 12.4.0
apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.53.0
python
git
visual studio
Edition	Windows 10 Home
Version	20H2
Installed on	6/18/2020
OS build	19042.662
Serial number	PF0YQNNH
Experience	Windows Feature Experience Pack 120.2212.551.0
Additional Information
I have looked in the %AppData%\Microsoft\Windows\Recent\  and %AppData%\local\temp files for generated core dump, but I did not see it.  I am able to look at hidden files.
Thanks

yea happening to me too.

Could you verify if this happens with atom version 1.52.0 ?

Its happening with 1.53.0.
On Wed, Dec 9, 2020, 9:34 PM Musa Ibrahim<EMAIL_ADDRESS>wrote:

Could you verify if this happens with atom version 1.52.0 ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/21788#issuecomment-741871212, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFYZRQSYU3PUVGYS6FUMHZDST6NY3ANCNFSM4USK6TEQ
.

I don't have 1.52.0 anymore.  Is there a way to get an older version of
atom?
On Wed, Dec 9, 2020, 7:04 PM Musa Ibrahim<EMAIL_ADDRESS>wrote:

Could you verify if this happens with atom version 1.52.0 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/21788#issuecomment-741871212, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQO3ST47WSETYGEAYOZ23WDST6NY3ANCNFSM4USK6TEQ
.

@darangi any update on this issue?

No, not yet.
On Mon, Dec 14, 2020, 7:52 AM Ojasvi Ashish Chauhan <
<EMAIL_ADDRESS>wrote:

@darangi https://github.com/darangi any update on this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/21788#issuecomment-744164631, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQO3ST5EXVJMT5DKY7VQQG3SUWKYVANCNFSM4USK6TEQ
.

I have a similar problem in 1.53.0
As soon as Atom starts I get some error messages in red boxes on the right side and then this error box pops up.

It happens so fast that I cannot see what the other error messages are.
I can click 'Keep the editor open' and then I can navigate through the menu bar but the editor screen is all white and non functional.
Running atom --safe does work. Any tips on how to find the culprit of the crashes?

apparently after running atom in safe mode once, shutting it down and then starting it again solved my problem.

Safe mode or regular, opening from command line or by double click on icon, Atom crashes after pressing Ctrl+O or Ctrl+S. Using Ubuntu 18.04.

Safe mode or regular, opening from command line or by double click on icon, Atom crashes after pressing Ctrl+O or Ctrl+S. Using Ubuntu 18.04.

Having the same with Atom 1.54  running winver 20H2 WIndows 10.

It has happened to me twice after upgrading and once after reinstalling for Atom 1.6.0


Rescue 403 errors

Trello: https://trello.com/c/gKND6vZM/169-unauthenticated-user-accessing-a-calendars-page-with-step-by-step-token-is-directed-to-sign-on
Follows on from: RFC 113: Expanding draft access for unauthenticated users to allow multi-page fact checks
What's changed and why?
At the moment calendars is throwing a 500 when it receives
an error code it doesn't recognise from content-store. That means
that users are shown a "Problem has occurred" page.
We need to handle this error properly so that in the case of a
403, the user will be properly routed to signon and asked to login
if there is any form of access limiting on the content item (e.g.
hosted on draft stack, access limited to organisation)

Have added a second commit to do that 👍 do let me know if you see a problem with it, otherwise I'll go ahead and merge this afternoon.

Have added a second commit to do that 👍 do let me know if you see a problem with it, otherwise I'll go ahead and merge this afternoon.

Nice one Chris.


Disable rotating for special characters

Once special characters are rotated, they become illegible. So I added the ability to disable rotation of all text characters and disable rotation of special characters anyway.

Okay, if you think there might be a problem with type hints, let's delete them.

I think they could be added to the whole package, maybe?

This is an advanced feature. I'd like to make image captcha the ability to add character by character, in this way, developers can control each character themselves.


Activesupport requires Ruby>=2.2.2

Tried to install but Activesupport requires Ruby>=2.2.2. Here is the output:
xx@xx:~/spotify-export/bin$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Using concurrent-ruby 1.0.2
Using i18n 0.7.0
Using minitest 5.9.1
Using thread_safe 0.3.5
Using tzinfo 1.2.2
Gem::InstallError: activesupport requires Ruby version >= 2.2.2.
An error occurred while installing activesupport (<IP_ADDRESS>), and Bundler cannot
continue.
Make sure that gem install activesupport -v '<IP_ADDRESS>' succeeds before
bundling.

Did you try upgrading ruby to 2.2.2 ?


KNOX-2436 Add new service for replacing resourceManager property duri…

What changes were proposed in this pull request?
In Oozie 5.x there is a new parameter called resourceManager. This is used instead of jobTracker. However, Oozie can fall back to jobTracker value if no resourceManager is defined. resourceManager shall have the same value as jobTracker has now.
This ticket is intend to track the work on adding a new rewrite rule and a new service returning the resource-manager's address.
Currently the JobTrackerServiceModelGenerator despite its name is actually returning the resource-manager's address. This is not enabled by default because its misleading name since we no longer have job-trackers but resource-managers.
By having a new service which does exactly the same thing as JobTrackerServiceModelGenerator but is enabled by default we could have Oozie work with Knox out of the box.
We should be careful as the resource manager service name is already taken by ResourceManagerUIServiceModelGenerator.
How was this patch tested?
Updated/ran unit tests.

@arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is?

@moresandeep, please review this PR when you have time. Thanks!

@arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is?

Thanks for your feedback, i changed accordingly.

@arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is?

Thanks for your feedback, i changed accordingly.

Thanks, @arvaiadam! I really appreciate your fast feedback and action you've taken here!

Java8 job failed, re-triggered it. Once it passes we should be good to go.

There is an ongoing issue with Github Actions for a while (for some PRs it's intermittent, for some it's more severe). Luckily, we have Travis in place which proves this PR is OK to merge so I'm going to do it now.


Added RBAC for Custom Workflows and My Hubs + Bug Fixes + Refactoring

Proposed changes
This PR will add:
- Added RBAC for My Hubs and creation of custom workflows.
- Fixed some bugs in Custom workflow creation.
- Refactored code for Custom workflow scheduling.
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[X] New feature (non-breaking change which adds functionality)
[X] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@ishangupta-ds @vanshBhatia-A4k9 Translation changes done.PTAL

/merge

/merge

/merge

/merge


Decide what generative pipeline to use, and try to implement it

The latter research papers^1 use the following generative scheme to reconstruct images:

Low-level (perceptual): maps brain signals to the embedding space of Stable Diffusion’s VAE. This embedding is then pushed through the VAE decoder block to produce a "low-level" reconstruction of the image.
High-level (semantic): maps brain signals to the CLIP image space. This embedding is then fed through pretrained img2img model with obtained "low-level" reconstructed image.

In this task, one has to refer to the SD VAE and img2img model in order to inference them in a jupyter notebook notebooks.

[!IMPORTANT]
Please, pay attention to the dimensions of the VAE latents and CLIP embeddings. It is important to know them for a successful method implementation.

Found some useful links to the implementation:

Low-level
High-level


Setup issues, cannot get it working with latest wordpress

Hi Iantch,
I was wondering if this is still maintained to work with the latest wp?
I followed the installation instructions, and even did a composer install in the plugin folder. But upon calling the_hbs-template() it simply doesn't render anything. I placed .hbs files in my theme-folder/src/templates too but nothing.
Maybe I'm overlooking something here, be great to get your advice as would be ideal to get this working.
Thanks,
Rhys.

Haven't checked yet. I will have a look and come back to you with an answer.

Okay no worries, and yeah I use composer for dependencies but maybe I haven't set it up properly. I'll wait for you to add info as that might help, if you get the chance to. I've managed to get Mustache working in my project but I prefer Handlebars as I'm familiar.

Ok, found some time to check it out.
Good news, it works. I found a minor bug and extended the readme.
I created a gist, but it is basically the example code from the readme:
https://gist.github.com/iantsch/0fd07b67022484d6d7b508c001f449f5

Created #2 to make activation of plugin easier in the future.


added cpi source file to C++ gitattributes

What is cpi?

What is cpi?

cpi is used in older C++ projects (at the time of MFC). I have some of them at work. It's a regular C++ code file and as far as I can tell, they're nothing "special".

It seems rare/old, but I managed to find a reference to it:
https://stackoverflow.com/questions/12682107/how-to-create-c-project-filter-folder-in-visual-studio
I think it wouldn't hurt to have it.

Thank you!


Using <i mz-icon-mdi and error in unit tests

Current Behavior
After setting up a clean angular 4 project and installing / adding ng2-materialize to the project and running a unit test for a component containing an material icon the unit test fails with following error:

Can't bind to 'align' since it isn't a known property of 'i'. (""dropdown-button" data-activates="dropdown1">
test<i mz-icon-mdi
[ERROR ->][align]="'right'"
[icon]="'chevron-down'">

"): ng:///DynamicTestModule/HeaderComponent.html@23:21
Can't bind to 'icon' since it isn't a known property of 'i'. ("
test<i mz-icon-mdi
[align]="'right'"
[ERROR ->][icon]="'chevron-down'">

"): ng:///DynamicTestModule/HeaderComponent.html@24:21
Can't bind to 'icon' since it isn't a known property of 'i'. ("

<i mz-icon-mdi [ERROR ->][icon]="'magnify'">

"): ng:///DynamicTestModule/HeaderComponent.html@31:29
Error: Template parse errors:
at syntaxError D:/work/projects/foodplan-angular/node_modules/@angular/compiler/@angular/compiler.es5.js:1694:22)

Steps to Reproduce (for bugs)

Set up a clean angular 4 project using angular/cli
In AppComponent add <i mz-icon-mdi [align]="'right'" [icon]="'chevron-down'">
Run ng test

Your Environment

Version used: 1.5.2
Angular version used: 4.2.4
Browser Name and version: Default settings for unit tests (Karma)
Operating System and version (desktop or mobile): Windows 10 Pro x64 Desktop
Link to your project (if appropriate): None (yet)

Hi @ramden,  did you include MaterializeModule in your test setup?
For example, with Angular-CLI using TestBed you would need to add the module to the test module configuration like this...
beforeEach(async(() => {
  TestBed.configureTestingModule({
    imports: [ MaterializeModule.forRoot() ], // add MaterializeModule to testing module configuration
    declarations: [ HeaderComponent ],
  });
}));

You are right 👍 Thank you


update PaddleTS introduction

update PaddleTS introduction

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ouyangliping seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Small fixes

Thank you for this wonderful theme, especially the dark/light mode!
I bumped into a small number of self-describing issues which I would like to share:

rewritten self-closing DIVs (not supported by all browsers)
configurable blog section
include contents of index.md as optional/additional contents

Thanks a lot for the pull request - merged.


Adding album name to metadata

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

ADD DESCRIPTION HERE
Fixes #
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

could you fill in the template please

could you fill in the template please

Okey

could you fill in the template please

I mentioned.

The album name was already being added to embedded metadata; the value was being drawn from the album field in the info dict.
The PR's change will instead ignore the info dict's album field, and instead try to draw the value from the info dict's track field, and then fall back to the title field. I don't see why this would be desired. Can you explain the intent here?

The album name was already being added to embedded metadata; the value was being drawn from the album field in the info dict.
The PR's change will instead ignore the info dict's album field, and try to draw the value from the info dict's track field, and then fall back to the title field. I don't see why this would be desired. Can you explain the intent here?

Thumbnail photo does not appear if album name is not written to music

The album name was already being added to embedded metadata; the value was being drawn from the album field in the info dict.
The PR's change will instead ignore the info dict's album field, and try to draw the value from the info dict's track field, and then fall back to the title field. I don't see why this would be desired. Can you explain the intent here?

The album is not assigned a value so I added a value to get that value from the "info dict".

The album is not assigned a value so I added a value to get that value from the "info dict".

This is something you could handle on a case-by-case basis with the --parse-metadata option. The default should not be changed


Optional Java Dependency Appears Broken

On both OSX and Ubuntu, npm install fails with the (optional) dependency breaking.
This appears to be due to<EMAIL_ADDRESS>><EMAIL_ADDRESS>install /home/jsanford/node-commit-msg/node_modules/java
> node-gyp rebuild

make: Entering directory `/home/jsanford/node-commit-msg/node_modules/java/build'
  CXX(target) Release/obj.target/nodejavabridge_bindings/src/java.o
In file included from ../node_modules/nan/nan_new.h:190:0,
                 from ../node_modules/nan/nan.h:80,
                 from ../src/java.h:9,
                 from ../src/java.cpp:1:
../node_modules/nan/nan_implementation_12_inl.h: In static member function ‘static NanIntern::FactoryBase<v8::Signature>::return_t NanIntern::Factory<v8::Signature>::New(NanIntern::Factory<v8::Signature>::FTH, int, NanIntern::Factory<v8::Signature>::FTH*)’:
../node_modules/nan/nan_implementation_12_inl.h:181:76: error: no matching function for call to ‘v8::Signature::New(v8::Isolate*, NanIntern::Factory<v8::Signature>::FTH&, int&, NanIntern::Factory<v8::Signature>::FTH*&)’
   return v8::Signature::New(v8::Isolate::GetCurrent(), receiver, argc, argv);
                                                                            ^
../node_modules/nan/nan_implementation_12_inl.h:181:76: note: candidate is:
In file included from ../src/java.h:5:0,
                 from ../src/java.cpp:1:
/home/jsanford/.node-gyp/4.8.1/include/node/v8.h:4675:27: note: static v8::Local<v8::Signature> v8::Signature::New(v8::Isolate*, v8::Local<v8::FunctionTemplate>)
   static Local<Signature> New(
                           ^
/home/jsanford/.node-gyp/4.8.1/include/node/v8.h:4675:27: note:   candidate expects 2 arguments, 4 provided
In file included from ../src/java.h:9:0,
                 from ../src/java.cpp:1:
../node_modules/nan/nan.h: At global scope:
../node_modules/nan/nan.h:171:25: error: redefinition of ‘template<class T> v8::Local<T> _NanEnsureLocal(v8::Local<T>)’
 NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {
                         ^
../node_modules/nan/nan.h:166:25: error: ‘template<class T> v8::Local<T> _NanEnsureLocal(v8::Handle<T>)’ previously declared here
 NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Handle<T> val) {
                         ^
../node_modules/nan/nan.h:564:13: error: ‘node::smalloc’ has not been declared
     , node::smalloc::FreeCallback callback
             ^
../node_modules/nan/nan.h:564:35: error: expected ‘,’ or ‘...’ before ‘callback’
     , node::smalloc::FreeCallback callback
                                   ^
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanNewBufferHandle(char*, size_t, int)’:
../node_modules/nan/nan.h:568:50: error: ‘callback’ was not declared in this scope
         v8::Isolate::GetCurrent(), data, length, callback, hint);
                                                  ^
../node_modules/nan/nan.h:568:60: error: ‘hint’ was not declared in this scope
         v8::Isolate::GetCurrent(), data, length, callback, hint);
                                                            ^
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanNewBufferHandle(const char*, uint32_t)’:
../node_modules/nan/nan.h:575:67: error: call of overloaded ‘New(v8::Isolate*, const char*&, uint32_t&)’ is ambiguous
     return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
                                                                   ^
../node_modules/nan/nan.h:575:67: note: candidates are:
In file included from ../node_modules/nan/nan.h:25:0,
                 from ../src/java.h:9,
                 from ../src/java.cpp:1:
/home/jsanford/.node-gyp/4.8.1/include/node/node_buffer.h:34:40: note: v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate*, v8::Local<v8::String>, node::encoding) <near match>
 NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                        ^
/home/jsanford/.node-gyp/4.8.1/include/node/node_buffer.h:34:40: note:   no known conversion for argument 3 from ‘uint32_t {aka unsigned int}’ to ‘node::encoding’
/home/jsanford/.node-gyp/4.8.1/include/node/node_buffer.h:46:40: note: v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate*, char*, size_t) <near match>
 NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                        ^
/home/jsanford/.node-gyp/4.8.1/include/node/node_buffer.h:46:40: note:   no known conversion for argument 2 from ‘const char*’ to ‘char*’
In file included from ../src/java.h:9:0,
                 from ../src/java.cpp:1:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanNewBufferHandle(uint32_t)’:
../node_modules/nan/nan.h:579:61: error: could not convert ‘node::Buffer::New(v8::Isolate::GetCurrent(), ((size_t)size))’ from ‘v8::MaybeLocal<v8::Object>’ to ‘v8::Local<v8::Object>’
     return node::Buffer::New(v8::Isolate::GetCurrent(), size);
                                                             ^
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanBufferUse(char*, uint32_t)’:
../node_modules/nan/nan.h:586:12: error: ‘Use’ is not a member of ‘node::Buffer’
     return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
            ^
make: *** [Release/obj.target/nodejavabridge_bindings/src/java.o] Error 1
make: Leaving directory `/home/jsanford/node-commit-msg/node_modules/java/build'

I have updated as little as possible here, pushing to 0.6 branch. 0.8 is current, but I don't want to be presumptuous.
Discussed elsewhere:
https://github.com/joeferner/node-java/issues/250
Thanks, we leverage this module a lot.

Thanks for the PR, I'm glad to see someone using this module.
Version 0.2.2 has been published to https://www.npmjs.com/package/commit-msg


Loading image upon request

Hi,
Thanks for the great component, was wondering is there a way to load the image whenever the user click on it to see the lightbox, in such case will deffer loading the big images until it get requested.
As per my test image data will load on the same time like src whenever the page is requested.

Hi. it will be problematic for me to do it, because of the structure I
made.
But, on the page start only the first and the second image is loading, and
it become sort of "caching" for the opening of the lightbox with the first
or second one.
But, you right. I must think on some way to do it.
Thanks for putting my mind into it.
I'll write it on my update / bug list and will think on that for my further
updates.
On Fri, Sep 25, 2015 at 4:44 PM, Jad<EMAIL_ADDRESS>wrote:

Hi,
Thanks for the great component, was wondering is there a way to load the
image whenever the user click on it to see the lightbox, in such case will
deffer loading the big images until it get requested.
As per my test image data will load on the same time like src whenever the
page is requested.
—
Reply to this email directly or view it on GitHub
https://github.com/vvvmax/unitegallery/issues/31.


⚠ AGEG website (prod) has degraded performance

In a4786fb, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 8332 ms

Resolved: AGEG website (prod) performance has improved in d7eb88d.


feat: add mobile adaptation

Browser:

Mobile:

It seems the browser version is narrower than before. Is it expected?

The time axis on mobile view is still not handled properly

BTW, I think the graph scale ratio on mobile should be like browser that length should larger than height to make it look better

It seems the browser version is narrower than before. Is it expected?

The previous width was 70% of the browser width, and this was found to be out of proportion on widescreen monitors.

so I referred to Google Finance to make the width narrower

The time axis on mobile view is still not handled properly

will fix it soon.

I think the graph scale ratio on mobile should be like browser that length should larger than height to make it look better

In the local try to change the ratio of the length and width, I feel that the first picture is a little more coordinated

In the local try to change the ratio of the length and width, I feel that the first picture is a little more coordinated

Still take google finance as an example, I still believe length > width would be better. I think the reason the current view does not look good is due to different font sizes unmatched.


lazy load child rows in groups

The heavy lifting would of course fall on the data source, but implementing hooks for this would make it possible to implement.

I think you are looking more for a complete end-to-end reporting application rather than a gui grid???!!! Not sure this request fits in what I was aiming for. Any examples or further explanation of what you mean??

Essentially, I want row grouping with a remote data source. Obviously the grid can't do the grouping for me because it won't have all the data due to infinite scrolling. Here is my need:

Enable mode so all rows passed from remote datasource are considered top-level "groups"
When a group is expanded, make a second call to remote datasource to fetch rows in group and render them

I actually have a working implementation of this, but it's a bit hacky right now. I'd prefer to have it supported in the grid.
Would you accept a PR?

ah right, i got mixed up with what pivot meant. so basically you want lazy loading of the child groups. yes i'll get that in at some point. i'll rename this issue.
re PR, i probably won't accept a PR on this, as it's core to the workings of the grid, so i'll prob have my own ideas on how this should be done with regards the rest of the grid.

+1

+1 Really need it in my project.

+1

+1

+1

+1

tracked by https://ag-grid.atlassian.net/browse/AG-86

this is now done, part of the Enterprise Row Model

Is it possible to turn this off and get the page with groups already expanded using groupDefaultExpanded: -1 ? This setting doesn't seem to do anything with the server-side model.