Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
8m 42s
the patch passed

+1 :green_heart:
cc
8m 42s
the patch passed

-0 :warning:
javac
8m 42s
root generated 2 new + 1559 unchanged - 0 fixed = 1561 total (was 1559)

+1 :green_heart:
checkstyle
2m 24s
root: The patch generated 0 new + 591 unchanged - 33 fixed = 591 total (was 624)

-0 :warning:
rubocop
0m  5s
The patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 17s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 33s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
20m 11s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
13m 56s
the patch passed

+1 :green_heart:
spotbugs
22m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
2m 42s
The patch does not generate ASF License warnings.

132m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool rubocop refguide

uname
Linux 45b27991e601 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-general-check/output/branch-site/book.html

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-general-check/output/diff-compile-javac-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-general-check/output/diff-patch-rubocop.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 55s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 46s
master passed

+1 :green_heart:
compile
3m 18s
master passed

+1 :green_heart:
shadedjars
8m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 45s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
shadedjars
9m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
225m 51s
root in the patch failed.

282m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5f291e1fbb56 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/testReport/

Max. process+thread count
3715 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
compile
2m 38s
master passed

+1 :green_heart:
shadedjars
7m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m 20s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
2m 41s
the patch passed

+1 :green_heart:
javac
2m 41s
the patch passed

+1 :green_heart:
shadedjars
8m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m  1s
the patch passed

_ Other Tests _

-1 :x:
unit
348m 11s
root in the patch failed.

396m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9e56af3070d3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/testReport/

Max. process+thread count
5798 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/25/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
compile
8m 39s
master passed

+1 :green_heart:
checkstyle
2m 27s
master passed

+0 :ok:
refguide
3m 40s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
20m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
8m 43s
the patch passed

+1 :green_heart:
cc
8m 43s
the patch passed

-0 :warning:
javac
8m 43s
root generated 2 new + 1559 unchanged - 0 fixed = 1561 total (was 1559)

+1 :green_heart:
checkstyle
2m 23s
root: The patch generated 0 new + 591 unchanged - 33 fixed = 591 total (was 624)

-0 :warning:
rubocop
0m  4s
The patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 17s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 34s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
19m 46s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
13m 58s
the patch passed

+1 :green_heart:
spotbugs
22m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
2m 40s
The patch does not generate ASF License warnings.

131m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool rubocop refguide

uname
Linux 46a24e4781c8 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-general-check/output/branch-site/book.html

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-general-check/output/diff-compile-javac-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-general-check/output/diff-patch-rubocop.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 59s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 44s
master passed

+1 :green_heart:
compile
3m 42s
master passed

+1 :green_heart:
shadedjars
9m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 32s
the patch passed

+1 :green_heart:
compile
3m 54s
the patch passed

+1 :green_heart:
javac
3m 54s
the patch passed

+1 :green_heart:
shadedjars
9m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
285m 49s
root in the patch passed.

347m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 690b2b0c7e55 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/testReport/

Max. process+thread count
4566 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
compile
2m 30s
master passed

+1 :green_heart:
shadedjars
7m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
compile
2m 32s
the patch passed

+1 :green_heart:
javac
2m 32s
the patch passed

+1 :green_heart:
shadedjars
8m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m  3s
the patch passed

_ Other Tests _

-1 :x:
unit
338m 34s
root in the patch failed.

384m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ef63ce7eabdb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8e08952499

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/testReport/

Max. process+thread count
5503 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/26/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s
master passed

+1 :green_heart:
compile
8m 50s
master passed

+1 :green_heart:
checkstyle
2m 26s
master passed

+0 :ok:
refguide
3m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
20m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
8m 46s
the patch passed

+1 :green_heart:
cc
8m 46s
the patch passed

-0 :warning:
javac
8m 46s
root generated 2 new + 1560 unchanged - 0 fixed = 1562 total (was 1560)

+1 :green_heart:
checkstyle
2m 23s
root: The patch generated 0 new + 591 unchanged - 33 fixed = 591 total (was 624)

-0 :warning:
rubocop
0m  5s
The patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 16s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 40s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
20m 10s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
hbaseprotoc
0m 20s
hbase-shaded in the patch failed.

+1 :green_heart:
spotbugs
24m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
2m 44s
The patch does not generate ASF License warnings.

133m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool rubocop refguide

uname
Linux 60aa59638328 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c5b0989d22

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/branch-site/book.html

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/diff-compile-javac-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/diff-patch-rubocop.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/patch-site/book.html

hbaseprotoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-shaded.txt

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 41s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 56s
master passed

+1 :green_heart:
compile
4m  7s
master passed

+1 :green_heart:
shadedjars
10m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 41s
the patch passed

+1 :green_heart:
compile
4m  8s
the patch passed

+1 :green_heart:
javac
4m  8s
the patch passed

+1 :green_heart:
shadedjars
11m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
258m 12s
root in the patch passed.

325m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2a3fe6cb2075 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c5b0989d22

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/testReport/

Max. process+thread count
4483 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 40s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 48s
master passed

+1 :green_heart:
compile
2m 57s
master passed

+1 :green_heart:
shadedjars
8m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
compile
2m 53s
the patch passed

+1 :green_heart:
javac
2m 53s
the patch passed

+1 :green_heart:
shadedjars
8m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
404m 23s
root in the patch passed.

456m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 595b5a372feb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c5b0989d22

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/testReport/

Max. process+thread count
3864 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/27/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 11s
master passed

+1 :green_heart:
compile
8m 39s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
3m 37s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
20m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
8m 42s
the patch passed

+1 :green_heart:
cc
8m 42s
the patch passed

-0 :warning:
javac
8m 42s
root generated 2 new + 1561 unchanged - 0 fixed = 1563 total (was 1561)

+1 :green_heart:
checkstyle
2m 23s
root: The patch generated 0 new + 591 unchanged - 33 fixed = 591 total (was 624)

-0 :warning:
rubocop
0m  4s
The patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 17s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 37s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
20m  2s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
13m 57s
the patch passed

+1 :green_heart:
spotbugs
22m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
2m 36s
The patch does not generate ASF License warnings.

131m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool rubocop refguide

uname
Linux 7cfad481b820 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94f4479e8f

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-general-check/output/branch-site/book.html

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-general-check/output/diff-compile-javac-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-general-check/output/diff-patch-rubocop.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
126 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 45s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 29s
master passed

+1 :green_heart:
compile
3m 52s
master passed

+1 :green_heart:
shadedjars
9m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
3m 41s
the patch passed

+1 :green_heart:
javac
3m 41s
the patch passed

+1 :green_heart:
shadedjars
9m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
238m 45s
root in the patch failed.

307m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0889b11b093a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94f4479e8f

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/testReport/

Max. process+thread count
2921 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
2m 47s
master passed

+1 :green_heart:
shadedjars
8m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
2m 48s
the patch passed

+1 :green_heart:
javac
2m 48s
the patch passed

+1 :green_heart:
shadedjars
8m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 53s
the patch passed

_ Other Tests _

-1 :x:
unit
340m  5s
root in the patch failed.

388m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux efb2aa7ff518 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94f4479e8f

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/testReport/

Max. process+thread count
3481 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/28/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
9m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
compile
8m 29s
master passed

+1 :green_heart:
checkstyle
2m  4s
master passed

+0 :ok:
refguide
3m 38s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
20m 27s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
10m  3s
the patch passed

+1 :green_heart:
cc
10m  3s
the patch passed

-0 :warning:
javac
10m  3s
root generated 2 new + 1560 unchanged - 0 fixed = 1562 total (was 1560)

+1 :green_heart:
checkstyle
2m 17s
root: The patch generated 0 new + 591 unchanged - 33 fixed = 591 total (was 624)

-0 :warning:
rubocop
0m  4s
The patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 23s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 41s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
23m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
17m 24s
the patch passed

+1 :green_heart:
spotbugs
27m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
3m 12s
The patch does not generate ASF License warnings.

155m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool rubocop refguide

uname
Linux 7e65e2870dd5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9895b2dfdf

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-general-check/output/branch-site/book.html

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-general-check/output/diff-compile-javac-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-general-check/output/diff-patch-rubocop.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
9m 19s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 43s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 27s
master passed

+1 :green_heart:
compile
3m 24s
master passed

+1 :green_heart:
shadedjars
8m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 38s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
shadedjars
8m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
156m 45s
root in the patch failed.

219m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eddea074a8d6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9895b2dfdf

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/testReport/

Max. process+thread count
4034 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m  2s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 40s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
compile
2m 35s
master passed

+1 :green_heart:
shadedjars
7m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
2m 34s
the patch passed

+1 :green_heart:
javac
2m 35s
the patch passed

+1 :green_heart:
shadedjars
8m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m  2s
the patch passed

_ Other Tests _

-1 :x:
unit
332m 22s
root in the patch failed.

382m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2901

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f58bf53c64d9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9895b2dfdf

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/testReport/

Max. process+thread count
5216 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-assembly hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2901/29/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


update eks ecr-essentials

Removed the input variable "configure_ecr_pull_through_policy"
Added resource to attach existing policy to iam worker role

Hey @santhoshratala can you fix the conflicts first, please.

rolling back changes made in https://github.com/SPHTech-Platform/terraform-aws-eks/pull/20


State of Instances

We should simplify the mental model of instances. This includes the use of is_accumulator (probably there should just be an accumulator member somewhere to replace this). It also includes the fact that in the ProverInstances abstraction objects are only initialized to varying degrees, and quantities that are supposed to fixed across all instances in the class are only assumed to be (this isn't checked or otherwise ensured by the code).

@codygunton I think this can be closed (now or very soon) by your work.


Drop identical checks

These checks are duplicates of the ones done on lines 1011, 1748 an 2744 respectively.

:shipit:

LGTM, thanks.


removing config based rack radios if customized ones are used

If the user is already defining new rack radios, he doesn't need the ones that are defined by addon configs.

Target the develop branch.

Ugh yeah you made the changes on the master so we can't push to dev, just bring the changes you made to dev branch and do another PR

Thought we had ditched the dev branch.


Upgrade SLF4J 2.0.11 -> 2.0.12

This PR contains the following updates:

Package
Type
Update
Change

SLF4J (source)
import
patch
2.0.11 -> 2.0.12

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade SLF4J 2.0.11 -> 2.0.12

See:
- https://www.slf4j.org/news.html
- https://github.com/qos-ch/slf4j/compare/v_2.0.11...v_2.0.12


fix: Delegators col width

Summary

Witdh of delegators is causing text to truncate

How to test

Go to http://localhost:8080/#/s:balancer.eth/delegates
click on delegators column header to sort
Notice that text of header is truncated before the fix

Before
After

Issue still remain when the voting power symbol is long enough, better fix would be to truncate this column

The not-working truncation is also forcing an horizontal scroll on small screen, and un-syncing the column width with the header

Also see https://snapshot.box/#/s:test.wa0x6e.eth/proposal/0x1ca55447da176052e43c80f151726b1d352e8bc10507bde803b0ee111e63aa1f/votes

The main issue I want to fix is the col width of the header. when we sort, an arrow is added to it, and the text get truncated because of the smaller width
Before clicking

After clicking

Maybe we should handle truncation in separate issue?

The main issue I want to fix is the col width of the header. when we sort, an arrow is added to it, and the text get truncated because of the smaller width Before clicking  After clicking
Maybe we should handle truncation in separate issue?

I see, I though you were talking about the content


authelia: postPatch openapi.yml

Description of changes
doesn't build the swagger yet, but at least enables openapi.yml access, for use with other tools.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

follow-up to https://github.com/NixOS/nixpkgs/pull/317164
cc https://github.com/NixOS/nixpkgs/pull/299309


Definine a record with unknown properties.

I want to define a runtype that is equivalent to Record<string, unknown>.  I know that the following code is incorrect.
import { Record, Static } from "runtypes";

const MyRecordRuntype = Record({});

type MyRecord = Static<typeof MyRecordRuntype>;
// {}

const greeting: MyRecord = 'Oh hai, Mark!';

const inquiry = "What's new with you?";

MyRecordRuntype.guard(inquiry);
// expected: false
// actual: true

Is it possible to do this with runtypes?
Is the return value of Record({}) correct?

Use Dictionary.
const Dict = Dictionary(Unknown)
type Dict = Static<typeof Dict>
// type Dict = {
//     [_: string]: unknown;
// }


Polish DestinationTopicPropertiesFactory

polish DestinationTopicPropertiesFactory and DestinationTopicPropertiesFactoryTests

@Wzy19930507 Changes look good. Could you add a small motivation for this PR as a commit message or here? That way, it is easier to follow through, especially later on. Was there anything particularly wrong, or is it mostly cleanup?

@sobychacko Hi, thanks for your review and nice advice. It mostly cleanup.
This class goes through many iterations and the code is hard to read for me.

Can you update the copyright years on the classes changed?

@Wzy19930507 Thanks for the PR. It is now merged upstream.

Thanks for your review!


gradient demo

Hello @TheBigKahuna353! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file hooman/demos/Gradient_rect.py:

Line 13:1: W293 blank line contains whitespace
Line 14:80: E501 line too long (82 > 79 characters)
Line 15:1: W293 blank line contains whitespace
Line 16:80: E501 line too long (82 > 79 characters)
Line 17:1: W293 blank line contains whitespace
Line 18:80: E501 line too long (87 > 79 characters)
Line 19:1: W293 blank line contains whitespace
Line 20:80: E501 line too long (85 > 79 characters)
Line 21:1: W293 blank line contains whitespace
Line 22:80: E501 line too long (81 > 79 characters)
Line 23:1: W293 blank line contains whitespace
Line 24:80: E501 line too long (85 > 79 characters)
Line 29:14: W292 no newline at end of file

In the file hooman/hooman.py:

Line 281:9: E741 ambiguous variable name 'l'

In the file hooman/time.py:

Line 17:47: E225 missing whitespace around operator
Line 17:80: E501 line too long (93 > 79 characters)

In the file hooman/ui.py:

Line 276:30: E231 missing whitespace after ','
Line 282:80: E501 line too long (87 > 79 characters)
Line 283:1: W293 blank line contains whitespace


{Storage} az storage account create: sync up with main repo

Description
az storage account create is outdated but still has some preview features, this pr synchronizes the behavior of the command in main repo.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Storage


Persistent connections got stuck

We tested the persistent connection and all seemed to work as expected, failover, reconnections and so on.
But after some months in production, one server went down and the connections got stuck to that server. I mean, waiting for response.
We have a pool of servers selected randomly, so the expected behaviour was 1 of n requests failing (but no stuck)
What happened is that the process got stuck in a connection to a server that was down.
Has anybody faced the same issue? Is this related to a bug in the code with persistent connections?

@daniAlonsoH are you still seeing this?
When using persistent connection I assume you're using PHP-FPM (since using persistent connections for long-running processes in the CLI has no real benefits).
When using PHP-FPM I assume you're mostly producing and not consuming jobs, right?


Entra Rebrand 2

Updating all Azure AD terms to the Microsoft Entra ID terms in all md files.
Does this introduce a breaking change?
[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

What to Check
The updated changes to Microsoft Entra ID terminology make sense.
Other Information
Here's a link to the Rebrand guidelines. Note that the script doesn't have all the entries in the glossary that mine has. Let me know if you'd like to see my version of the script. https://review.learn.microsoft.com/en-us/entra/fundamentals/how-to-rename-azure-ad?branch=main

Hey everyone, there's a build issue that keeps failing. I don't think the script I ran on this repo is the problem. Could someone please help me out with this? Thank you


Bug?/chirpstack user home directory

when the v4 rpm is installed a "chirpstack" user is created.  Its home directory is "/etc".  Could the home directory be changed to "/etc/chirpstack" to make security scanners etc happy?
Thanks,
Bryan

Isn't that already happening?
https://github.com/chirpstack/chirpstack/blob/master/chirpstack/Cargo.toml#L204


Fixed issue in K.logsumexp in tensorflow backend

Argument reduction_indices is depreciated in tensorflow. It also causes shape inference issue for placeholder, example
x = K.placeholder((None, 9, 9))

y1 = tf.reduce_logsumexp(x, reduction_indices=2)
K.int_shape(y1)  # gives None

y2 = tf.reduce_logsumexp(x, axis=2)
K.int_shape(y2)  # gives (None, 9)

Correct, thank you.

What is the proper way to use K.logsumexp for now? Seems like there is no such things


Performance: Update search results after submitting a string?

Maybe, this is too much...
Current Code:
searchField.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
[...]
    @Override
    public boolean onQueryTextChange(String newText) {
      if (newText != "") {
        addQuotesToList(searchField.getQuery().toString());
      }
        return false;
      }
    });

Regarding performance:
Golden rule. Don't optimise.
Silver rule. When obviously too slow, measure, don't guess.
Data structure before code micro-optimisation. Using more efficient data structures is often far effective than improving a bit of code, unless that piece of code is the absolutely critical bottleneck.

@okitec Well, it depends on how many quotes are filtered. Right now, its fine, but maybe in the future this will be a problem.

Then fix it when, if at all, the problem appears. Strive for the simplest code unless in dire need.

Hmm, well - closed for now

Thank you for heeding my advice. :smile:


Investigate: ConsulCacheTest timing issue with assertion

In testListenerIsCalled there used to be an assertion that the ConsulCache.CallbackConsumer call count equals one. The original code used standard JUnit assertions. When we switched to AssertJ, this same assertion sometimes failed with a call count of 2 or more.
In the background, the CallbackConsumer continues to be called, so I think the only reason it used to work consistently was a lucky timing issue. By moving the assertion above the listener call count assertion, it usually worked but sometimes failed, again indicating a timing issue.
I changed the assertion to check that the call count is positive rather than equal to some specific number. The question here is whether this is "correct". If it is, we can modify the comment in testListenerIsCalled to provide some explanation, and then close this issue. If not correct, what should the assertion be, and how should the test be changed?

By adding logging or System.out.println calls inside the StubCallbackConsumer#consume method, it is clear the callback is called repeatedly. Running the test multiple times I saw call counts of 224, 226, 243, 232 by printing the call count in the test after the assertion. So, I think this issue can be closed as "resolved" and just remove or change the comment in the test.


How to improve ingest process?

I've finished ingesting Malawi final results. The process was not as smooth as expected, I only managed to complete it after three attempts. The first two were interrupted after hours of processing, then I had to restart from scratch.
The errors were probably caused by a network failure or because my computer hibernated, there was no specific error message. The process was through after I setup the computer to stay awake on system preferences. Total time of import was approximately six hours.
I think we might need to refine the ingest process for the next country imports, as it takes several hours and is very susceptible to connection problems and other issues. Maybe having an intermediate table for scenario results, or to pre-process source files into PostgreSQL-ready CSV files to be ingested with COPY instruction.

Now that we have received new (and larger) country results it seems that PostgreSQL may not be the right database for GEP. Uncompressed scenario files for Mozambique have approximately 1 GB each. Importing a model with 150 GB in size is impractical in the current way the CLI works.
A CLI refactor improve something, but I suggest migrating from a monolithic (PostgreSQL) to a NoSQL database (Bigtable, DynamoDB, MongoDB), which allows horizontal growth and have more efficient ways of storaging documents with varying structure, such as model results.

We discussed and decided to optimize PostgreSQL usage instead of migrating to another DB. Ingesting a very large dataset with the current CLI was feasible (thanks to @danielfdsilva) by setting up a ECS instance to avoid common interferences of desktop computers.
Mozambique is up and a scenario takes about 30-50 seconds to load, sometimes incurring in timeouts. Checking the docs I've found out that JSONB property types can be indexed:
https://www.postgresql.org/docs/9.6/datatype-json.html
JSONB has a higher converstion overhead, so ingest time will increase.
The filterValues property are already JSONB, but summary don't. As every scenario query applies a filter by summary, I suspect we can improve response times considerably by using indexes.
What we need to do here:

Create migration to convert summary from json to jsonb;
Create migration to add a GIN index and update WHERE clause expression if needed (see docs for caveats);
Test and deploy.


[Backport v3.6-branch] Backport 79830 to v3.6 branch

Fixes https://github.com/zephyrproject-rtos/zephyr/issues/79800
failed backport: #80461

@aescolar  If this gets target at 3.7.1, is the https://github.com/zephyrproject-rtos/zephyr/pull/80462 even needed?

@aescolar If this gets target at 3.7.1, is the https://github.com/zephyrproject-rtos/zephyr/pull/80462 even needed?

Sorry :), That was just me being clumsy

@de-nordic Please look into the CI failures.

@de-nordic Please look into the CI failures.

Sorry I am fighting with build env to run that.

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

I would drop the test from the backport.

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

I would drop the test from the backport.

Thanks!

please change the PR title and do not include PR numbers in there

OK, fine, sorry. The PR naming for backports is not described anywhere.


API 4.3 - Seamless Telegram Login

Closes #955

This should be good to go, if somebody could add their eyes to check, that would be sweet :muscle:
@php-telegram-bot/developers

@noplanman is there any example how to use the seamless telegram login?
Spent the entire day digging for clue just to find out how to use this login_url but couldnt get anything.
https://core.telegram.org/api/url-authorization didnt help at all
thank you, i really appreciate your work

@noplanman is there any example how to use the seamless telegram login?
Spent the entire day digging for clue just to find out how to use this login_url but couldnt get anything.

What exactly is your problem?
If you don't know how to send the login button to a user/group then this code example might be useful:
$login_object = new LoginUrl([
	'url' => 'https://mydomain.com/check_authorization.php',
	'request_write_access' => true,
]);

$login_keyboard = new InlineKeyboard([
	['login_url' => $login_object, 'text' => 'Click this button to login'],
]);

$data = [
	'chat_id' => $receiverChatId,
	'reply_markup' => $login_keyboard,
	'text'   => 'This is a basic text message with a login button beneath',
];
Request::sendMessage($data);

Don't forget that you have to link the domain first to your bot or otherwise the login button probably won't work as intended. To link a specific domain to your bot send the /setdomain Command to the @botfather.
The message received by this code example should have a login button beneath it. If the user clicks on it, Telegram will open the specified URL in a browser. The PHP File behind this URL now has to verify the authenticity of the received information. If everything works fine, the user will be logged in on your website.
If you are struggling with the authorization part on the web server, I would recommend the official guide for the Telegram Login Widget, because the authorization for the Login Widget works exactly the same way as the Seamless Telegram Login. In fact, if you have already integrated the Telegram Login Widget on your website, you can link the Seamless Login URL to the authorization file from your Login Widget and it will work without any further configuration needed.
If you don't know how implement the authorization file itself, I can recommend this code example. I am using the check_authorization.php code myself for my own bot.
I hope these tips can help you (and everyone else stumbling across this topic).

@ossiach @noplanman apologize for double post my question.
As my comment in #1065 what I’ve got so far:

write exactly the same code just like what you said
got the inline button showing up below my bot message
got the login confirmation dialog showing up when I click the inline button

However, when my page was opened, I see there’s no query string appended to my auth url. It’s just like a normal page, the exact same url I set in LoginUrl.
The documentation here talk about messages.acceptUrlAuth and urlAuthResultAccepted but there’s no guide on how to use it.
Are those parameters something I should care to know?

Will move this conversation to your initial issue, so others can find the solution more easily...
#1065


Fix static provisioning (closes #1980)

Static provisioning was disabled.

Build finished. 8 tests run, 0 skipped, 0 failed.

Build finished. 668 tests run, 102 skipped, 44 failed.


RELATED: ONE-4116 Use files directive

... and stop testing for old node

Build succeeded (check pipeline).

Build succeeded (check pipeline).

Build succeeded (check pipeline).

LGTM

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-css-style-merge-compliance-check/2/ : SUCCESS in 23s


[Event Request] Codeunit 311 Item-Check Avail. " OnItemCheckAvailOnBeforeServiceInvLineCheck"

Can we please get the following event?
 procedure ServiceInvLineCheck(ServInvLine: Record "Service Line") Rollback: Boolean
    Var
        IsHandled: Boolean;
    begin
        NotificationLifecycleMgt.RecallNotificationsForRecordWithAdditionalContext(
          ServInvLine.RecordId, GetItemAvailabilityNotificationId(), true);
      //Event Request Begin
        IsHandled := false;
        OnItemCheckAvailOnBeforeServiceInvLineCheck(ServInvLine, IsHandled);
      //Event Request End
        if not IsHandled then begin
        if ServiceInvLineShowWarning(ServInvLine) then
            Rollback := ShowAndHandleAvailabilityPage(ServInvLine.RecordId);
    end;
    end;

 [IntegrationEvent(false, false)]
    local procedure OnItemCheckAvailOnBeforeServiceInvLineCheck(var ServInvLine: Record "Service Line"; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Usage in deno

Is there an existing issue for this?

[X] I have searched the existing issues

Your question
Hi! I'm trying to use this in a deno app but I'm not being able right now.
I saw this in the official doc, but it's not working for me. It seems the 7.0.0 is still not available in https://deno.land/x, is that right?
I also tried with latest https://deno.land/x version, that seems to be @6.4.1, but I tried to import Fuse in some different ways and couldn't get it to work. Could someone help? Thanks! 😄

As a workaround, one can use esm.sh:
import Fuse from<EMAIL_ADDRESS>


[WIPTEST] Fixes required for test_provision_with_boot_volume

The when the service name volume was used, Cinder couldn't find the image in Glance. Using volumev3 or volumev2 causes that different api version will be used and then the Cinder can find the image in Glance fine.
The change causes wrapanapi to test different versions of volume api and picks the latest one.
There also were some logic problems further in the codepath. id parameter must be used to search by id and id must be allowed as one of the valid parameters.
This patch is required by https://github.com/ManageIQ/integration_tests/pull/8620

Lint report for commit 727e6f26858c5858222763461d01b375bb411630:
wrapanapi/systems/openstack.py:

:red_circle: Line 919:19: F821 undefined name 'volume_configurations'
:red_circle: Line 921:33: F821 undefined name 'volumes'

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot


getting node-gyp rebuild errors when using nom install

myrs-MacBook-Pro:Documents myr$ npm install ringpop
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
npm WARN package.json<EMAIL_ADDRESS>string_decoder is also the name of a node core module.
/

<EMAIL_ADDRESS>install /Users/myr/node_modules/ringpop/node_modules/farmhash
node-gyp rebuild

CXX(target) Release/obj.target/farmhash/src/upstream/farmhash.o
CXX(target) Release/obj.target/farmhash/src/bindings.o
SOLINK_MODULE(target) Release/farmhash.node
ld: library not found for -lgcc_s.10.5
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Release/farmhash.node] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/myr/.nvm/v0.10.32/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "node" "/Users/myr/.nvm/v0.10.32/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/myr/node_modules/ringpop/node_modules/farmhash
gyp ERR! node -v v0.10.32
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the farmhash package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls farmhash
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 14.5.0
npm ERR! command "/Users/myr/.nvm/v0.10.32/bin/node" "/Users/myr/.nvm/v0.10.32/bin/npm" "install" "ringpop"
npm ERR! cwd /Users/myr/Documents
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0

That's not a node-gyp issue.  The library not found for -lgcc_s.10.5 error is either a local issue (e.g. because you need to update your system) but it might also be caused by farmhash's build settings.  Try filing an issue with that project.


Could bindActionCreators optionally take a list of action objects?

We've got a few places in our code where we're passing multiple objects of bound actions into components. It would great to have the optionally pass a list of action objects into bindActionCreators.
bindActionCreators([SomeActions, OtherActions], dispatch)
The caveat of course would be duplicate actions would get overwritten by the last one processed.

You can do this with ES7 object spread proposal:
bindActionCreators({ ...SomeActions, ...OtherActions }, dispatch)

or (vanilla ES6, needs Object.assign polyfill or Babel plugin)
bindActionCreators(Object.assign({}, SomeActions, OtherActions), dispatch)

or (ES5, assumes lodash)
var assign = require('lodash/object/assign');

bindActionCreators(assign({}, SomeActions, OtherActions), dispatch)

Ah excellent, that's even easier. Thanks!

🙌🏽

🙌

This is helpful! Thanks!

Super helpful! :star2:

@gaearon should we possibly add this to the tips section in the bindActionCreators API doc?

A pull request is welcome :wink:
I’m not actively working on the docs right now so my answer is the same: “if you’d like something to be in the docs, please send a PR”.

Not sure if this will help anyone, but I was trying to combine my app actions and Actions from react-native-router-flux, and below worked for me.

import * as AppActions from './actions';
import { Actions } from 'react-native-router-flux';

function mapDispatchToProps(dispatch) {
  return { actions: {...bindActionCreators(AppActions , dispatch), ...Actions } };
}

Not sure if this will help anyone, but I was trying to combine my app actions and Actions from react-native-router-flux, and below worked for me.

This is a little confusing because Actions from react-native-router-flux seem to have nothing in common with Redux, and probably shouldn’t be in mapDispatchToProps at all. Just use them directly in your components.

const mapDispatchToProps = dispatch => bindActionCreators({
loadData: (data: []) => _ => {
data(d => dispatch(action(d)));
}
}, dispatch);


reactjsday-verona-italy-2022

Hi again @harish-sethuraman , here is another conf in Verona, Italy in October 2022, so please review it when you get some time for it :D

Hi again, @harish-sethuraman ,  can you merge this one soon as this conf is happening in a month :D


Can't install chicken scheme on darwin

Not sure how to work around this because I don't want to allow broken.
$ nix-env -i --dry-run chicken-egg2nix
(dry run; not doing anything)
installing ‘chicken-egg2nix-0.5’
error: Package ‘chicken-4.10.0’ in ‘/nix/store/bq67byr5wp5ww84lgli37icfc9aldgf7-nixpkgs-16.03pre75806.77f8f35/nixpkgs/pkgs/development/compilers/chicken/default.nix:67’ is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build` or any other Nix command you can add
  { allowBroken = true; }
to ~/.nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

Also, from the error message I would not expect this error:
$ nix-env -i chicken-4.10.0
error: selector ‘chicken-4.10.0’ matches no derivations

Marked as broken on darwin at 9300470b5ec507806a30e3de8edd3a695ac585fa

I've run into other similar issues where something is broken due to a broken dependency (qutebrowser for example). Brokenness should probably propagate to packages that use a broken package. Either way I'm fine with closing this until a fix is available.

You can do one-off builds with broken packages by NIXPKGS_ALLOW_BROKEN=1 nix-build. For all I know, it could work fine on darwin now (it's been a while since it was disabled); it appears to be supported upstream, at any rate.

Yeah I have a working install outside of nix. I haven't made time to try and fix what ever issues happens when installing with nix.

Is there a reason why chicken is still marked as not supported on mac? It seemed to work fine for me

@shmish111 could be because nobody found the time to test or noticed. If it works for you, please consider opening a PR.


[Bug]Load Data From HDFS Report Checksum Error

Bug Type (问题类型)
exception / error (异常报错)
Before submit

[X] I had searched in the issues and found no similar issues.

Environment (环境信息)

Server Version: v1.0.0
Toolchain Version: v1.0.0
Data Size:  7 vertices, 18 edges

Expected & Actual behavior (期望与实际表现)
When loading data from HDFS using HugeGraph-Loader, get an error

Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

Seems same with #132, do u try to enable the checksum function in HDFS?
And could u provide more info about how to reproduce it? (in a clean/pure HDFS cluster, the error will not appear

Hello, the checksum function in my hdfs cluster is enabled, but the problem still appears.

hi @lanerbean ,what is your hadoop version?

@lanerbean you can try manually downloading and replacing dependencies that match your cluster version, including hadoop-common, hadoop-hdfs-client.

hi @lanerbean ,what is your hadoop version?

My hadoop version is Hadoop 3.3.1

Ok, I can try to download these dependencies. Could you tell me where to download these jars and which folder to put these new jars?

@lanerbean You can search for the package you need in mvnrepository , download them and put them in the ./lib/
And remember to remove the old version dependencies.

@simon824 Yes, as you said, I replaced the "hadoop-common" and "hadoop-hdfs-client" dependencies in the "lib" folder of HugeGraph-Loader, it worked ok! Thank you very much!


make possibly conflicting optimistic cache updates write to each other

My theory as to why #1655 and #1669 occur is that an earlier and conflicting optimistic mutation fails while another optimistic mutation is in progress. When the optimistic mutation fails, it rolls back the cache to its initial state which causes the in-progress optimistic mutation to have its cache updates overwritten.
In the case of #1655, I believe that this occurs when an earlier zap (in a succession of zaps) fails. In the case of #1669, I believe this occurs when a poll is zapped, then voted on.
I've made the relevant cache updates write to each other. It's very hard to reproduce so I'm not sure I got all the relevant cache.modify calls, but I'll continue looking for any cache updates on the optimistic response path in the few places we do it (zaps/boosts/polls) ... it's unclear if there are consequences to doing it on every cache.modify call.

Update: I've made all the cache.modify calls on items update optimistic caches. This might be unnecessary overhead but afaict it shouldn't cause anything bad to happen, and should prevent optimistic rollbacks from affecting these cache updates.

I'm going to leave those issues open just in case this doesn't fix it.


Support new build runner

https://github.com/davidmarne/built_redux/issues/56

https://github.com/davidmarne/built_redux/tree/7.4.0-dev


Add optional buffer pool for item values

This PR adds support for an optional Bytes pool to recycle the buffers used to hold cache item values. A "release" or "return" method is not provided as it is expected that the caller will have access to the pool itself.
name                 old time/op    new time/op    delta
ParseGetResponse-40    2.51µs ± 0%    2.59µs ± 0%   +3.03%  (p=1.000 n=1+1)

name                 old alloc/op   new alloc/op   delta
ParseGetResponse-40    4.32kB ± 0%    4.32kB ± 0%   -0.05%  (p=1.000 n=1+1)

name                 old allocs/op  new allocs/op  delta
ParseGetResponse-40      6.00 ± 0%      5.00 ± 0%  -16.67%  (p=1.000 n=1+1)

Ref: https://github.com/grafana/mimir/issues/285

Suggests something is wrong, either with the code or the benchmark.

Indeed there was, a new reader was being allocated for every iteration. Fixed that, and here are the new numbers:
name                 old time/op    new time/op    delta
ParseGetResponse-40     481ns ± 0%     471ns ± 0%   -2.10%  (p=1.000 n=1+1)

name                 old alloc/op   new alloc/op   delta
ParseGetResponse-40     96.0B ± 0%     88.0B ± 0%   -8.33%  (p=1.000 n=1+1)

name                 old allocs/op  new allocs/op  delta
ParseGetResponse-40      3.00 ± 0%      2.00 ± 0%  -33.33%  (p=1.000 n=1+1)

Now:
name                 old time/op    new time/op    delta
ParseGetResponse-40     780ns ± 0%     510ns ± 0%  -34.63%  (p=1.000 n=1+1)

name                 old alloc/op   new alloc/op   delta
ParseGetResponse-40      600B ± 0%       88B ± 0%  -85.33%  (p=1.000 n=1+1)

name                 old allocs/op  new allocs/op  delta
ParseGetResponse-40      3.00 ± 0%      2.00 ± 0%  -33.33%  (p=1.000 n=1+1)


Upgrading to Finchley.RC2 download wrong configurations

Hi,
I have a microservices application with config server running on Spring Boot 2.0.1 and Spring Cloud Finchley.RC1.
The problem is raising upgrading the stack to Spring Boot 2.0.2 and Spring Cloud Finchley.RC2. In this setup, Config Server correctly downloads my git repo, but also it downloads and serves configurations from the [https://github.com/spring-cloud-samples/config-repo](sample repo), causing my services to not start

I guess you need to share your code so we can reproduce the problem?

Hi,
I replicated the bug with a minimal code, pushed to https://github.com/HelLViS69/spring-cloud-config-issues-1045
When bootRun the project, in /tmp you can find config-repo-XXXX with my conf repo, config-repo-YYYY empy and config-repo-ZZZZ with sample configuration

Hi.
Thanks, it works now. Btw I wonder how it worked until today (this project started with Spring Boot 1.4)

In my testing locally it worked the same way in Edgware.SR3 and Finchley.RC1.


Add option progress

When you have many files, we have to wait a long time and it is not clear how many have tightened as there is, it would be very convenient to see the progress.
Maybe use https://github.com/sindresorhus/ora for logging filenames and count images are compressed and not.
P.S.: sorry that did not have time to write tests as promised, very little time for the new year :sob:

I'd prefer to not output anything myself in this library as that's more of the job of webpack itself (with it's progress settings/flags).
If there is a way to hook into webpack to report that some progress is being made I'd rather do it that way as it would be more "correct". I'll need to look into this, as with webpack 2 things are changing a lot in that world.
 I'm swamped with stuff as well, so it's no big deal.

@Klathmon Unfortunately webpack can only output assets and progress for own event. He can not know what progress is now inside the plugin, and I think that it will never be implemented in webpack. It is therefore logical to assume that it rests on the plugin developers. Today I build the project in which it was about 10k images (3 mb minimum image size) and I was in a deep misunderstanding of what is happening.

Fair enough!
I've admittedly opened my OS's system monitor to see the number of imagemin processes running to see if it's working correctly, so something here would be useful.
I'll look into adding it to the plugin.
Do you know offhand if it's possible to check on if the "progress" flag is set in webpack? And if it is would you have any objections to using that instead of a special config for this plugin?

@Klathmon sgtm for getting progress from webpack. Unfortunately I do not have webpack near, maybe compiler contain global webpack options.

This would be super useful, IMO. I'm writing a React starter kit that I'd like to use this library for, and I think users will start to get concerned with build times that seemingly 'stall' for a few minutes due to volume of files.
Especially pngs -- they can take an age to process.
Appreciate your time on this @Klathmon - very useful plugin!

@leebenson Thanks, but I'm not sure how feasible this change is going to be.
Webpack handles all the output for the progress flag, so I'm not going to be able to put out my own unless I require that webpack's progress flag not be used (which I really don't want to do).
So unless there is some way for me to report progress back to webpack, this isn't going to be implemented most likely.
That being said, I might be making some fairly large changes to this library so that it runs much sooner in the process, and a side-effect of that is that most images might be optimized before they hit the loaders, so every time one is completed it should show some progress through webpack.
Only images which aren't required will be done at the end, so it should lessen the impact of not having any kind of progress indicator.

Thanks @Klathmon. I'm not familiar with the API that Webpack exposes, so what I'm suggesting certainly may not be possible.
Your upcoming changes sound good though- will definitely look out for those.
Thanks!

I'm going to close this now. If anyone has any ideas on how to implement it feel free to open it and comment, but until then I can't figure any good way to introduce a progress system without "taking over" the whole console.

After having this plugin grow bigger than I previously thought it would (both in complexity and usage), I decided to reopen this issue and see if I can add an optional showProgress option.

Any updates on this? :)


Wrong type set in newTypeIdExpression(...)

https://github.com/Fraunhofer-AISEC/cpg/blob/16031b65a2c09d90bc0121af13f2d19eefbdb9d9/src/main/java/de/fraunhofer/aisec/cpg/graph/NodeBuilder.java#L102
Here twice the variable type is used to set a type and referencedType is never used.
This should probably be setReferencedType(referencedType).

Thanks for creating the issue :)


added EmptyString error variant for from_hex

Description
added EmptyString in CreationError error enum for from_hex().
Type of change

[x] Bug fix
[x] Optimization

Checklist

[x] Linked to Github Issue
[x] Unit tests added
[x] This change requires new documentation.

[ ] Documentation has been added/updated.

[x] This change is an Optimization

[ ] Benchmarks added/run

It's also a Bugfix

Codecov Report

Merging #501 (20e2633) into main (8fcd64f) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   94.37%   94.34%   -0.04%
==========================================
  Files          65       62       -3
  Lines        8715     8718       +3
==========================================
  Hits         8225     8225
- Misses        490      493       +3

Impacted Files
Coverage Δ

math/src/errors.rs
25.00% <ø> (ø)

math/src/unsigned_integer/element.rs
98.10% <66.66%> (-0.09%)
:arrow_down:

math/src/field/element.rs
95.23% <75.00%> (-0.27%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MauroToscano @Oppen added the required tests you guys should be able to merge now.

@schouhy @ajgara @Oppen  Not gonna merge is there any problem same question for #510

There are some conflicts in math/src/errors.rs but I guess otherwise it should be merged, it has three approves after all.

@Oppen resolved the conflicts you may merge this now.


Mempool currently allows for spending locked inputs

When joining the current Devnet with a node, and spending the entire balance on consensus transactions which would be locked for 250,000 blocks, I was still able to spend my coins a short while afterwards.

dusk-network/dusk-wallet#13 needs to be fixed before this issue can be fixed.


Could we mount hostPath into the virtual machine?

Since kata-containers use virtio-fs to mount hostPath into virtual machine, is there any method to mount hostPath into the VM?

That's an interesting feature. The general idea is to mount a host FS (hostPath or whatever FS mode volume) to the VM right? It mostly would depend on whether CH supports virtio-fs. We'll dig into this.


Allow install and uninstall of Windows features\capabilities

It would be nice to have a bridge into the Add-WindowsCapability, Add-WindowsFeature, and Add-WindowsOptionalFeature systems. Presently a particular bit of software could be in any of these three. It would be awesome to be able to do:
winget install Hyper-V
winget install RSAT
winget install Netfx3

And have it just work. Bonus points if it works on both desktop and server platforms (WindowsFeature on servers and WindowsOptionalFeature on desktops). The value of a tool like winget really comes when it can handle installations from all previous channels in one place, i.e applications can then depend on .Net3 and just let winget resolve during installation.

I would expect running this through winget to only apply to the local machine, so -online would be implied when called from winget.
Ideally it should also handle install sources correctly to allow downloading from Microsoft to get the packages, even if HKLM:\SOFTWARE\Policies\Microsoft\Windows\WindowsUpdate\AU\UseWUServer is set which could otherwise cause the install to fail.

That has to include group policies or other tools  to control that. IT teams are often responsible for hosts and need the ability to control usere system. If winget will allow anyone to reconfigure their hosts in any way with override, then IT will declare ,  Its.....  then winger n

That has to include group policies or other tools  to control that. IT teams are often responsible for hosts and need the ability to control usere system. If winget will allow anyone to reconfigure their hosts in any way with override, then IT will declare ,  Its.....  then winger n

The Windows Package Manager would not be able to override Group Policies or MDM. We're also working on the definitions for the policies related to the Windows Package Manager. IT administrators will be able to control the Windows Package Manager as well. We will be sharing those policies in the very near future so they have time to understand and decide what policies to implement before GA.

I have had a thought about Group Policies I'd like to see. I'd like to ensure that IT Pros have complete control over what a developer can do with winget. I accept you will not be doing cmdlets but a good set of GPO policies would be helpful and offer IT Pros more control over what developer can do on their domain joined machines.
Here is a list of Policies you might want to consider:

Enable Winget - enables a user to user WInget or not. If disabled, overrides all the rest.
Enable Winget as Admin - enables a user to use WInget but only in an elevated console - this forces a user to have to elevate to use WInget
Enable WInget to install only from MS Store
Enable WInget to install from only certain package repos - so allow to install from Chocolately but not from other external package reports. This would need an array of Package Repo URLs or similar
Enable WInget to get the packages but not install or update for non-admin or admin user
Enable Winget to update packages only for non-admin or admin user
Enable user to delete/remove a package
Enable internal package repos - take an array of UNC names
Enable the use of Winget to install into the Windows folder - this would enable IT Pro to stop any installation that installed into the Windows Folder or below but would allow installation into Program Files or user folders
Enable the use of Winget to install in Program Files or Program FIles (x86) - this would enable IT Pro to stop any installation that installed into the Program Files folders (but allow in user-specific folders)
Enable the user to make use of Winget Experimental features - including possibly disabling winget features to show any experimental features
Enable the HASH verb -enable a user to use winget hash
Enable the Validate verb to be used
Enable the installation of .ZIP packages
Enable the installation of .MSI packages
ENble the installation of .EXE packages
Enable the installation of .MSIX packages
Enable WInget on Workstations or servers or both -you might combine this with the first item

Some of these admittedly overlap but can give an Admin fine-grained control. SO enable the store, and Chocolately, but only for MSIX packages for example.
The policies should be both computer and user policy settings under Administrative Templates. That would mean creating the  ADMX/ADML policy files for V1 as well.  That would allow testing of these settings by just setting local registry settings in the absence of an actual GPO.
I hope this drives the discussion on what is needed for V1.

@doctordns would you mind adding that to #154 Support for Group Policy Management? I'll add what we're currently looking at there.

If your machine is configured to use WSUS, then the package manager must also fetch updates from WSUS. I hope I am misunderstanding in that you want winget to bypass this security feature that enterprises use for a reason.

I guess I didn't explain it that well but what I mean is:
If I do a winget install putty then I'm telling winget I want it to download the PuTTY installer and install it for me. If I do a winget install RSAT then I expect the same. Bypassing group policies isn't the intention but I don't think failing because the RSAT packages may not be available through a WSUS instance is the best behavior (e.g. see this thread where RSAT couldn't be approved in WSUS)
Maybe it's best if winget should download the cab files itself from a Microsoft URL and run the install script with the -Source switches to install it. This effectively makes winget in charge of sourcing the installer content regardless if it's a exe, MSI installer, or a WindowsCapability.

@denelon - does this duplicate:

#556

This one includes server and I don't know if the initial PR for:

#556

covers this issue fully.

For standalone enabling/disabling windows feature, this might be better to be its own command/workflow.
Something like:
winget feature --enable netfx3
winget feature --disable netfx3

Support for enabling WIndows Features as a dependency has been implemented in WinGet 1.7.


Fix kwargs usage for Ruby 2.7

This PR intend to fix Ruby 2.7 deprecation warning:
closure_tree-7.1.0/lib/closure_tree/model.rb:9: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

I've updated some method names in order to simplify to reflect the new usage.

:+1:

Thanks a lot!


Provide container/docker compose to be able to run platform without compilation

Feature Request
Simplify how platform can be used by publishing container to the dockerhub

What should the base image contain? I'd client admin plus server.  Then keycloak + mongodb as backing services.

Just app server with all clients build - see scripts for building for production.
We already have docker compose for the keycloak and mongo.

What should the base image contain? I'd client admin plus server. Then keycloak + mongodb as backing services.

Yes, by backing services I meant not part of the platform image.

See https://github.com/aerogear/datasync-starter/blob/master/scripts/publish_container.sh

Adding here as notes: the Dockerfile could use some updates - compiling the ts file and make sure that only the compiled code is included.


from keras.engine.topology import Merge Failed

Using TensorFlow backend.
Traceback (most recent call last):
File "deepnet.py", line 10, in
from keras.engine.topology import Merge
ImportError: cannot import name Merge

@hengqujushi that's the wrong place to import Merge from. You can import it from keras.layers instead, although if you're using Keras 2 you should check out the keras.layers.merge module, as the Merge layer has been replaced in favor of individual merge layers (Add, Concatenate, etc.) or individual merge functions (add, concatenate, etc.).

Correct, import it from keras.layers.


Update apache docs

Minor changes:

Editing the sites-available and then using apache2ctl to move from sites-available to sites-enabled (more).
The apache2ctl tool is a better interface for working with apache than service. Removed the line that used links, this is confusing for many as links is not installed by default.
Removed the TODOs, one had been done and the other was too broad to make sense for this document. The general gist, "more example client code," has been captured elsewhere.
Added installation of libcurl headers to apt-get

Aspiring to close #821

Looks good, thanks @david4096. +1 modulo query about service/apache2ctl

Got it @jeromekelleher, rolled that one back!

Thanks @david4096, merging.


How to send a transaction?

Hi, any demo on sending a transaction between to accounts?
I refer the docs but still confused. Is there any way to send a transaction only with this package when I have a jsonrcp server running ? How to provide the $data : https://github.com/digitaldonkey/ethereum-php/blob/master/src/SendTransaction.php#L23

Actually I never tried it, because I focused on data-retrieval functionality so far.
You will need to have a Ethereum-client with an unlocked account in order to do any sending.
The documentation is here:
https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sendtransaction
Please share your findings.


Provide data-driven test case parameters from external file

We are currently trying to utilize data-driven testing using test templates in Robot. The issue is robot requires test case parameters to be hard-coded in the input file in some way. It is much easier for us to manage large test sets by storing the data in something more readable like a CSV file. It's relatively simple to build a quick and dirty python script that would generate the robot test file on-the-fly before running it, but this seems like something that could potentially be built directly into Robot
CSV File:
title,message
test case 1,hello world!
test case 2,this is a test

Robot test file:
*** Settings ***
Library  MyLibrary
Test Template  My Test Template

*** Test Cases ***
test_cases.csv

*** Keywords ***
My Test Template  [Arguments]  ${message}
  Log  ${message}

Generated Robot test file:
*** Settings ***
Library  MyLibrary
Test Template  My Test Template

*** Test Cases ***  message
test case 1         hello world!
test case 2         this is a test

*** Keywords ***
My Test Template  [Arguments]  ${message}
  Log  ${message}

Can you please explain how the robot framework read test_cases.csv ?

Mark

This is already closed a long time back. But do have anything like @mgrijalva has mentioned. If not CSV then TSV, XMS or any other row/col format to read, which will generate TestCase on the fly as opposed to the hardcoded values right now. TestNG provides the same using DataProvider  and execute method as many time as many rows in the file. I think we should provide a way to do that in Robot, Be it a single way as @pekkaklarck  mention but a provision will be helpful and add vary useful feature in robot

As I've commented earlier, I don't think we can come up with a generic system how to read external data that would work in all or even most cases. Much better to have such functionality outside the core so that it's possible to implement different tooling for different needs. You could, for example, very easily create a script that reads data in CSV, XML, JSON, or whatever format and creates Robot tests based on that.

People are still fascinated by the prospect of loading in external test data: https://github.com/Snooz82/robotframework-datadriver

Hi Everyone ,
Any write for the API testing using the data driven approach in robot framework


Fix PATH variables for kernels

For #5489

Codecov Report

Merging #6091 (d4a7158) into main (5c2cf0c) will decrease coverage by 0%.
The diff coverage is 25%.

:exclamation: Current head d4a7158 differs from pull request most recent head 4dffe1b. Consider uploading reports for the commit 4dffe1b to get more accurate results

@@          Coverage Diff          @@
##            main   #6091   +/-   ##
=====================================
- Coverage     71%     71%   -1%
=====================================
  Files        398     398
  Lines      26836   26840    +4
  Branches    3950    3952    +2
=====================================
- Hits       19254   19252    -2
- Misses      5956    5959    +3
- Partials    1626    1629    +3

Impacted Files
Coverage Δ

...atascience/kernel-launcher/kernelEnvVarsService.ts
61% <25%> (-3%)
:arrow_down:

...client/datascience/editor-integration/decorator.ts
76% <0%> (-4%)
:arrow_down:

...rc/client/common/process/pythonExecutionFactory.ts
82% <0%> (-3%)
:arrow_down:

.../datascience/notebook/notebookControllerManager.ts
86% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
75% <0%> (-1%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (-1%)
:arrow_down:

...t/datascience/kernel-launcher/localKernelFinder.ts
83% <0%> (+2%)
:arrow_up:


This is not a virtual DOM - touching DOM too much!

I just figured out that this is not a virtual DOM. You are touching DOM too much, both on creation and update! That's why you get your horrible performance!
One example is found in the velem prototype where you do an update. For children you are calling childNodes on a real DOM node!!  An this happen on each update.
You take this childnodes and iterate over it - more expensive - BEFORE you update the node with it.
How many times you think you are touching the real DOM? Too many.
You should use the vdom object for this.
A lot of different places in your code you are doing this - touching DOM where you shouldn't.
I just compared with React. They are not doing it the same way as you are doing it!
To get the childNodes length in a virtual DOM, just count how many children there is on the vdom object without touching the DOM.

touch DOM is ok, DOM is fast, virtual-dom did'nt mean not to touch DOM.

Please study this https://news.ycombinator.com/item?id=9155564


Fix UnmarshalJSON for NoDataTimeframe

Unmarshal function was checking if the type was a string and then assigning zero but never assigned the proper value
Added parse to demarshal properly

Nice catch, thank you!