HDFS-15906. Close FSImage and FSNamesystem after formatting is complete

JIRA: HDFS-15906
We should close FSImage and FSNamesystem after formatting is complete.

Hi @tasanuma @JunpingDu , could you please help review the code? Thank you very mush.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 17s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  6s

trunk passed

+1 :green_heart:
shadedclient
16m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 15s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  4s

the patch passed

+1 :green_heart:
shadedclient
15m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
227m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

311m 49s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2788

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux b327ea81ee8d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk /<PHONE_NUMBER>a85c2aa1f8ab696a304ee72522ae15

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/1/testReport/

Max. process+thread count
3156 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failed junit tests:
org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
org.apache.hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
Those failed unit tests were unrelated to the change. And they work fine locally.

@tomscut Thanks for the PR. Some minor comments:

Maybe fsn.close() should be in the finally scope too.
It is better to verify that fsn and fsImage are not null before closing them.

@tomscut Thanks for the PR. Some minor comments:

Maybe fsn.close() should be in the finally scope too.
It is better to verify that fsn and fsImage are not null before closing them.

Thanks @tasanuma  for your kind review and suggestions, I fixed them.

+1, pending Jenkins.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 18s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
18m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
18m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
328m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

421m 47s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestIncrementalBrVariations

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2788

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4a9ee8cce8ab 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 03e3205db934e7f081d0c89959c7333c03ecea43

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/2/testReport/

Max. process+thread count
2153 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2788/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failed junit tests:
hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
hadoop.hdfs.server.datanode.TestIncrementalBrVariations
hadoop.hdfs.TestPersistBlocks
hadoop.hdfs.server.namenode.TestDecommissioningStatus
hadoop.hdfs.TestDFSShell
hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.server.datanode.TestBlockScanner
hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
hadoop.hdfs.server.namenode.ha.TestEditLogTailer
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
Hi @tasanuma , those failed unit tests were unrelated to the change, and they all work fine locally.

@tomscut Thanks for your confirmation. I also confirmed the failed tests are not related. Will merge it.

Merged to trunk and cherry-picked to branch-3.3.
@tomscut There is a small conflict with branch-3.2. Could you create another PR for branch-3.2 if necessary?

Thanks @tasanuma for your merge. I submitted a PR for branch-3.2.


What is the context of this PR?
Fixes #859 .
How to review
Re-test the defect, confirm that person is not deleted when Enter key is pressed.
The enter key will now behave as a 'Save and continue' operation, it will submit the form and navigate to the next page.
Front end devs:
Please can you check to ensure that my solution is in the correct place and that it adheres to front end best practices etc.
Happy to learn the best way to do things.

We shouldn't be hijacking default keyboard behaviour here. If we remove the type=submit attribute from the button it won't submit the form.

@hamishtaplin does the call to preventDefault remove the type=submit from the button? I expected this only to override the Enter key press of the input fields. Would it be better to narrow down the selector to ensure that only text inputs are included?

@samiwel I don't think you need to use JS at all here, just remove the attribute from this line in the template:

@hamishtaplin Ah! Good shout. Thanks for pointing that out. I've changed the remove button to type=button. If I remove it completely it defaults with a submit action (which removes the person).


switch to os.path.join

minor improvement to improve cross-platform when labels are passed

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   91.26%   91.26%
=======================================
  Files          30       30
  Lines        2302     2302
=======================================
  Hits         2101     2101
  Misses        201      201

Impacted Files
Coverage Δ

scvi/dataset/csv.py
91.66% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ab47d...4520360. Read the comment docs.

Thanks Casey! We appreciate the contribution.


Can we move the cursor to the next line after image insert automatically

It'll be a good ux if the cursor moved to next line automatically after inserting an image.
Thank you!

Try it. mediaAutoSelect: false

Thank you! Looks like it's been added in the recent version, amazing work that you are doing.


Unable to register with localhost

I tried registering using localhost for testing, but it doesn't work.  The error shown in this screenshot suggests that this should be possible.  I get the same error with either localhost or <IP_ADDRESS>.

Please see https://developer.tesla.com/docs/fleet-api#help-and-support.
In order to improve our response times, the scope of the Github issues tracker is limited to the Golang code in the SDK. Backend issues should be reported to the Fleet API support team.


Outbound HTTP component ignores params field

http-types.wit defines the request type to have a member params which is documented as // The HTTP parameter queries, represented as a list of (name, value) pairs.
If you set this on an outbound request, it is ignored - no query string is included the URL.
We should either respect params, or remove it from the outbound request type.

remove it from the outbound request type

We should consider removing it entirely (moving it into SDKs); param parsing can be subtly different in different languages.

One thing to consider if removing is that we are reusing the HTTP request and response type definitions across the HTTP trigger and the outbound HTTP implementation.

Yeah, I'm suggesting removing it from everywhere. Using url form encoding for params is "just" a (very common) convention.

this is also impacting tweet embedding in bartholomew.
if i understand correctly, the consensus is to remove the params parameter from wit types file and make corresponding changes in sdk's?

If we're removing params this is not a good first issue.

For outbound HTTP the params field is currently non-functional but it looks like the query part of the request URI should be working; at least, I don't see in the code that it is being removed.

Current behaviour from testing:

Inbound

The original query string is included in url
The params field is populated

Outbound

If you include a query string in url it is preserved verbatim (as Lann predicted)
If you set params it is ignored

Inbound

The original query string is included in url

Well that's good. I propose we:

Switch our SDKs to parse the query
Document that params is deprecated
Drop params the next time we make breaking changes to the http interfaces (after streams support lands, if not sooner)

I will send a PR for 1 and 2.

Slight correction: if you include a query string on an outbound request, Spin leaves it alone.  But if you're using the Rust SDK, that strips it out (before passing the request to Spin).

After discussion, we believe we can parallel-run a new WIT with the existing one by using the Joel Trick TM at the ABI level and hiding it in the SDKs at the application level.  It will need some planning but we think it can be a non-breaking change.

If #1871 is accepted, this can be closed as we would freeze the Spin specific http interface (including this params field) but move to wasi-http for newer applications.

@rylev given that #1871 has been accepted, can we close this?


What is LLM.md

I have added the elaborative description about Large Language Models.

I request you to please assign me issue #2 and I'll add some knowledgeable content to the repository which would be helpful for everyone.

Now as I have merged my PR so I request you to please review it and label my PR as hacktoberfest-accepted, hacktoberfest and hacktoberfest2023.


Running picamera.py

Traceback (most recent call last): File "Object_detection_picamera.py", line 23, in  import cv2 ModuleNotFoundError: No module named 'cv2'

Error message tells you that your code is referencing an absent cv2 library. Perform pip installation of opencv-python package and error should resolve.

This website helped me a lot: https://blog.piwheels.org/how-to-work-out-the-missing-dependencies-for-a-python-package/


Slides or Videos for Stephen Shary talk

I was hoping you would have the slides for this sessions.
https://stirtrek.com/Sessions/Session/29
Thanks in advance!

Sorry, I have just added a pull request for it.

Thanks @STeveShary !


跪求deb包

跪求deb包
有没有表哥知道怎么解决
[20127:0909/232249.599355:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_ZY-Pla5unJs5/chrome-sandbox is owned by root and has mode 4755.
[1]    20127 trace trap  ./ZY-Player-2.4.5.AppImage
/tmp/.mount_ZY-Pla5unJs5/zy: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory

github 里有 snap 包, 应该是可以在 linux 里安装的
简爱<EMAIL_ADDRESS>于2020年9月9日周三 下午11:27写道：

跪求deb包
有没有表哥知道怎么解决
[20127:0909/232249.599355:FATAL:setuid_sandbox_host.cc(158)] The SUID
sandbox helper binary was found, but is not configured correctly. Rather
than run without sandboxing I'm aborting now. You need to make sure that
/tmp/.mount_ZY-Pla5unJs5/chrome-sandbox is owned by root and has mode 4755.
[1] 20127 trace trap ./ZY-Player-2.4.5.AppImage
/tmp/.mount_ZY-Pla5unJs5/zy: error while loading shared libraries:
libffmpeg.so: cannot open shared object file: No such file or directory
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Hunlongyu/ZY-Player/issues/216, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADUQ5HTGAXB762PV6IVJF73SE6NHBANCNFSM4RCRSMDA
.

github 里有 snap 包, 应该是可以在 linux 里安装的 简爱<EMAIL_ADDRESS>于2020年9月9日周三 下午11:27写道：
…
跪求deb包 有没有表哥知道怎么解决 [20127:0909/232249.599355:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_ZY-Pla5unJs5/chrome-sandbox is owned by root and has mode 4755. [1] 20127 trace trap ./ZY-Player-2.4.5.AppImage /tmp/.mount_ZY-Pla5unJs5/zy: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#216>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUQ5HTGAXB762PV6IVJF73SE6NHBANCNFSM4RCRSMDA .

github 里有 snap 包, 应该是可以在 linux 里安装的 简爱<EMAIL_ADDRESS>于2020年9月9日周三 下午11:27写道：
…
跪求deb包 有没有表哥知道怎么解决 [20127:0909/232249.599355:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_ZY-Pla5unJs5/chrome-sandbox is owned by root and has mode 4755. [1] 20127 trace trap ./ZY-Player-2.4.5.AppImage /tmp/.mount_ZY-Pla5unJs5/zy: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#216 # 216>, or unsubscribe < > ，或取消订阅https://github.com/notifications/unsubscribe-auth/ADUQ5HTGAXB762PV6IVJF73SE6NHBANCNFSM4RCRSMDA> .

试过了 不行

github 里有 snap 包, 应该是可以在 linux 里安装的 简爱<EMAIL_ADDRESS>于2020年9月9日周三 下午11:27写道：
…
跪求deb包 有没有表哥知道怎么解决 [20127:0909/232249.599355:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_ZY-Pla5unJs5/chrome-sandbox is owned by root and has mode 4755. [1] 20127 trace trap ./ZY-Player-2.4.5.AppImage /tmp/.mount_ZY-Pla5unJs5/zy: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#216>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUQ5HTGAXB762PV6IVJF73SE6NHBANCNFSM4RCRSMDA .

linux mint 20不再支持snap 希望能有deb包

星火商店里有，但更新略微滞后

可以自行打包构建呢


Added functionality and tests for #31

Hello,
I had to change the run function and add addToTechyCb parameter as a function used in my test to call watchFiles. I'm also using setTimeout to test the watch, I don't think it's a proper way to do it but I couldn't do better.
Do you have any idea how this could be done better?

@gizm0bill thanks for the PR. I'll check it tomorrow and will get back to you.

Looks good to me. Released 1.2.4 version.


List of public datasets used to train in Stage 1

Hi,
Do you have the list of "common public segmentation datasets" used to train SAM (mentioned in Page 6 of the paper)?

Resolved.


Feature/calendar privacy

Add privacy setting to the user's calendar.

friends feature was eventually not accepted so "friends" privacy was not included in the feature.
https://forums.pythonic.guru/t/topic/8757

Codecov Report

Merging #247 (072d124) into develop (4df85bc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
+ Coverage    99.29%   99.31%   +0.02%
===========================================
  Files           41       42       +1
  Lines         1691     1757      +66
===========================================
+ Hits          1679     1745      +66
  Misses          12       12

Impacted Files
Coverage Δ

app/database/models.py
96.69% <100.00%> (+0.08%)
:arrow_up:

app/internal/calendar_privacy.py
100.00% <100.00%> (ø)

app/internal/event.py
100.00% <100.00%> (ø)

app/routers/event.py
97.29% <100.00%> (+0.49%)
:arrow_up:

app/routers/profile.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ed3ee...072d124. Read the comment docs.


[Feature]: It will be nice to play a sound

Goal or desired outcome of this feature
Play a sound at desired time
Describe the feature
Play a sound at desired time
Screenshots, mockups, or videos
No response

Yeees, pleease, like https://github.com/eatgrass/obsidian-pomodoro-timer


[Backport 2.4] Add CI bundle pattern to distribution download

Signed-off-by: Zelin Hao<EMAIL_ADDRESS>Backport fe8fd67884160e346def8c8503d09fb4b5eb5363 from #5348.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8170/
CommitID: 197e606
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Seems like java heap space errors. Re-triggering the check.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8203/
CommitID: 5c43886
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Multiple instances of gradle check failed due to heap space issue. I think we need a profiling to understand which objects/processes are taking up heap space. Related https://github.com/opensearch-project/OpenSearch/issues/3973
1: Task failed with an exception.
-----------
* What went wrong:
Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':libs:opensearch-nio:forbiddenApisTest'.
> Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':plugins:repository-s3:compileTestJava'.
> Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

4: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':plugins:mapper-murmur3:forbiddenApisTest'.
> Java heap space

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8204/
CommitID: 5c43886
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

I am not able to link the test failure below with the code change here. Trying gradle check again.
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.store.StoreTests.testCleanupAndPreserveLatestCommitPoint" -Dtests.seed=44CDCC6324BD387C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en -Dtests.timezone=Indian/Mahe -Druntime.java=17

org.opensearch.index.store.StoreTests > testCleanupAndPreserveLatestCommitPoint FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([44CDCC6324BD387C:873EBF377CC5446A]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.index.store.StoreTests.testCleanupAndPreserveLatestCommitPoint(StoreTests.java:1192)


added Dockerfile, run_app.sh, and a Docker comment section in the readme

@jwergieluk

Added Dockerfile
Added run_app.sh
Added a Docker section to the readme with commands for how to build the image then run.

When I run the app without Docker I get this:

I just used that to import my wise data. Worked like charm. One more cosmetic improvement:
(Or remove the info widget. ATM the same message gets conveyed twice)


refactor: Make serde_v8::Value private

This commit makes serde_v8::Value variant private - meaning that users
can no longer accept serde_v8::Value in the ops as arguments. Instead
v8::Value should be used directly. It is also disallowed to use serde_v8::Value
in the structure arguments - instead the v8::Value should be passed as an
explicit argument. It lowers flexibility, but makes it so that there's only a
single way of passing V8 values.
Unfortunately the implementation itself can't be removed because it's used internally
to provide serde for #[serde] arguments.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.29%. Comparing base (79e73e5) to head (3b7ae37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   81.14%   81.29%   +0.14%
==========================================
  Files          96       95       -1
  Lines       24347    24277      -70
==========================================
- Hits        19756    19735      -21
+ Misses       4591     4542      -49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Color Input bug?

Hi,
I have a strange color bug: http://screencast.com/t/qxsZSbzRu
Can someone help me with that?
Thanks!

Ugh, same here. Did you ever solve it?

No, I didn't solve it... I am getting used to it. You?

I did yes, though it is likely you are using a fork of spacegray. I'm using kurtextrem/spacegray, and this color input issue comes from a missing file. I suspect this happened when some features from the Soda theme were added in. Anyway, you can download this file (text-field.png) manually from many other themes or you can comment out the line that is referencing it.

Nice, that works! Which is the best text-field.png for spacegray theme?
Thanks

None of them really worked for me, because I'm using the Oceanic Next color theme, not the default Spacegreat Ocean Dark theme. So I ended up removing the reference.
        "class": "text_line_control",
        "layer0.texture": "",
        "layer0.opacity": 0.1,
        "content_margin": [3, 3, -1, 3],
        "layer0.inner_margin": [4, 5, 4, 3],

Not sure were I should remove the reference... you are using this: https://github.com/voronianski/oceanic-next-color-scheme?

Yes, that color scheme, which can be used with Spacegray theme derivatives, like this Release 3 of a fork that has nice icons. You need to uninstall Spacegray if you installed it with Package Control, then download the ZIP file instead, install it manually, locate Spacegray.sublime-theme, and look for text_line_control in there. I would try to make it work before installing Ocean Next on top of it.

This is relevant to a fork, which I solved in my fork of the fork, now at pull-request #176


Plugin mode not working in google chrome

After updating to 2.15.0 version i found that flash plugin mode now not works in google chrome.
I found exact commit, responsible for this bug - 0327906.
when i removed that width:0; height:0; plugin started working again, as it was in 2.14.2 version.
hope this will help.

@magnum79 Closing old issues. If you'd like to reopen this, let us know. Thanks!


GEOMESA-2206 Kafka - don't index features during initial bulk load

If 'kafka.consumer.from-beginning', features will not be available
to query until consumers have caught up, although listeners will be
called as normal

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

stacks on top of #1886

Hmm...  @elahrvivaz can you add some brief docs?  Maybe just a paragraph or so explaining this new feature?

I added a snippet in the usage page - this change should be mostly transparent to the end user, they don't have to do anything different.

Thanks for the small update.  I missed that we already had this option documented.  :shipit:


Unable to connect X11 server

When I run the main.lua by 'qlua main.lua', I got bugs like below:
Unable to connect X11 server (continuing with -nographics)
Device set to 1
Loading datasets...
Loading the model...
Model randomized.
Current model type: torch.CudaTensor
Loading the trainer...
Loading the tester...
qlua: not loading module qtuiloader (running with -nographics)
qlua: not loading module qtgui (running with -nographics)
qlua: qtwidget window functions will not be usable (running with -nographics)
qtwidget window functions will not be usable (running with -nographics)
qlua: ./scroll.lua:16: attempt to index global 'qtuiloader' (a nil value)
stack traceback:
    [C]: in function '__index'
    ./scroll.lua:16: in function '__init'
    ...ysfeng/lvchao/torch/install/share/lua/5.1/torch/init.lua:91: in function <...ysfeng/lvchao/torch/install/share/lua/5.1/torch/init.lua:87>
    [C]: in function 'Scroll'
    ./mui.lua:21: in function '__init'
    ...ysfeng/lvchao/torch/install/share/lua/5.1/torch/init.lua:91: in function <...ysfeng/lvchao/torch/install/share/lua/5.1/torch/init.lua:87>
    [C]: in function 'Mui'
    main.lua:123: in function 'new'
    main.lua:41: in function 'main'
    main.lua:316: in main chunk
'''
How can I remove the ui show?

I've got exactly the same problem. Hope to fix it soon.

You can disable visualization by removing the requirements for gnuplot and mui in main.lua, and remove all calls to main.show and main.draw.

In case, if you dont want to remove UI requirements, Xming Server together with putty using X11 forwarding will resolve your issue; if still you get the same error; then you might need to re-install your GPU drivers and torch;

Hi, I did this "You can disable visualization by removing the requirements for gnuplot and mui in main.lua, and remove all calls to main.show and main.draw." I trained and now I have the results on the files main_EPOCHES_TIME.t7b and sequential_EPOCHES_TIME.[t7b|png]. The question is, How can I visualize these results? e.g. The confusion matrix. Thanks.


My file wrongly autodetected as Javascript instead of Javascript React

Refs: #24403

npm install -g create-react-app
create-react-app my-app
cd my-app/
code-insiders .

Notice all react files as detected as javascript files. I would expect they are auto detected as javascript react files.

Confirmed this. The workaround is adding the setting:
"files.associations": {
    "*.js": "javascriptreact"
}

Just out of curiosity, do you see this causing any bugs / unexpected behavior.  I know that that in TypeScript, using the correct language mode can be important but I'm not sure about for regular JS

@mjbvz I have filled seperate issues regarding the unexpected behavior. Mostly here https://github.com/Microsoft/vscode/issues/24524
For other issues encountered in the react tour you can see all the issues linked here https://github.com/Microsoft/vscode/issues/24403

I believe the TS team no longer encourages *.jsx files / javascript react since so many people are using react in plain old js files. The issue reported in #24524 still apply but for normal js files


preload.ts withPrototype only works on enumerable properties (possibly electron 29.0.0-alpha7 related)

The example process for exposing the ipcRenderer does not handle non-enumerable properties, leading to window.ipcRenderer.invoke being undefined outside of preload.ts.
The problem is the use of Object.entries to determine properties to expose here
https://github.com/electron-vite/create-electron-vite/blob/a9e13aebc3f628dfcd6d645480e588faf4674735/electron/preload.ts#L8-L11
I suggest replacing Object.entries with Object.getOwnPropertyNames to address this.
  const protos = Object.getPrototypeOf(obj)

  for (const key of Object.getOwnPropertyNames(protos)) {
    if (Object.prototype.hasOwnProperty.call(obj, key)) continue
    const value = protos[key];

Although, arguably, the base code shouldn't be exposing the ipcRenderer like this, as per the security considerations note in
https://www.electronjs.org/docs/latest/tutorial/ipc

Although, arguably, the base code shouldn't be exposing the ipcRenderer like this, as per the security considerations note in
https://www.electronjs.org/docs/latest/tutorial/ipc

Yeah. This code snippets seems a bit hack and not safe enough. 👍


refactor(lidar_apollo_segmentation_tvm): remove lidar_apollo_segmentation_tvm** packages

Description
Remove lidar_apollo_segmentation_tvm and lidar_apollo_segmentation_tvm_nodes.
~This PR puts headers in the autoware namespace.~
~Additional works~
~1. Align directory structure to follow the coding guidelines.~
~2. Clean unused dependencies LIST~
Related links
Parent Issue:
~- Part of: https://github.com/autowarefoundation/autoware/issues/4569~

How was this PR tested?
~I tested both lidar_apollo_segmentation_tvm_nodes.launch.xml and lidar_apollo_segmentation_tvm_nodes.launch.py.~
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@YoshiRi @kminoda Given https://github.com/orgs/autowarefoundation/discussions/4883#discussioncomment-9876908 do we want to spend effort refactoring this package? Is there an update on whether lidar_apollo_segmentation_tvm will be removed?

@ambroise-arm Thank you for bringing that up. I forgot that.
@ktro2828 Let's remove this package. Sorry for bringing this up after you made an effort to create this PR :pray: :bow:

@ambroise-arm @YoshiRi @kminoda I've removed lidar_apollo_segmentation_tvm** packages by https://github.com/autowarefoundation/autoware.universe/pull/7996/commits/663b7a5c3df33cdc1eacdd87a6852db352f55a3f.

@ktro2828 Oops, I've created the PR already :sweat_smile:
https://github.com/autowarefoundation/autoware.universe/pull/8150
Either one is fine, so let me just close the PR that I've created

@ktro2828 Would you add this to the description?
https://github.com/autowarefoundation/autoware/pull/5022

Relates to https://github.com/autowarefoundation/autoware.universe/issues/7701

https://github.com/autowarefoundation/autoware.universe/issues/8175


[Bug]: "RuntimeError: Invalid DISPLAY variable" when running S2

Contact Details
<EMAIL_ADDRESS>Instrument
NIRSpec (Stages 1-3)
What happened?
I started an over night Eureka run on a remote server, using the 'screen' command, since I knew my ssh connection would time out from inactivity. For every step I set hide_plots to True.
My S2 .ecf file looks like:
Eureka! Control File for Stage 2: Data Reduction
suffix                  rateints    # Data file suffix
Controls the cross-dispersion extraction
slit_y_low              -1      # Use None to rely on the default parameters
slit_y_high             50      # Use None to rely on the default parameters
Modify the existing file to change the dispersion extraction - FIX: DOES NOT WORK CURRENTLY
waverange_start         6e-08   # Use None to rely on the default parameters
waverange_end           6e-06   # Use None to rely on the default parameters
Note: different instruments and modes will use different steps by default
skip_bkg_subtract       False   # Not run for TSO observations
skip_imprint_subtract   True    # Not run for NIRSpec Fixed Slit
skip_msa_flagging       True    # Not run for NIRSpec Fixed Slit
skip_extract_2d         False
skip_srctype            False
skip_master_background  True    # Not run for NIRSpec Fixed Slit
skip_wavecorr           False
skip_flat_field         True    # NOTE At the time the NIRSpec ERS Hackathon simulated data was created, this step did not work correctly and is by default turned off.
skip_straylight         True    # Not run for NIRSpec Fixed Slit
skip_fringe             True    # Not run for NIRSpec Fixed Slit
skip_pathloss           False   # Not run for TSO observations
skip_barshadow          True    # Not run for NIRSpec Fixed Slit
skip_photom             True
skip_resample           False   # Not run for TSO observations
skip_cube_build         True    # Not run for NIRSpec Fixed Slit
skip_extract_1d         False
Diagnostics
testing_S2              False
hide_plots              True   # If True, plots will automatically be closed rather than popping up
Project directory
topdir                  /astro/jtste/simobs/2022-DataShowcase/NIRSpec/
Directories relative to project dir
inputdir                Stage_1_Output
outputdir               dlong/Stage2
Error traceback output
2022-03-30 21:54:59,149 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:00,657 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:02,171 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:03,689 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:05,208 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:06,728 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:08,248 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:09,770 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:11,293 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:12,805 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:14,322 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:15,833 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:17,357 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:18,872 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:20,385 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:21,899 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:23,405 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Applying Aperture correction.
2022-03-30 21:55:24,649 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - All 8192 integrations done
2022-03-30 21:55:24,650 - stpipe.EurekaSpec2Pipeline.extract_1d - WARNING - INTSTART not found; assuming a value of 1.
2022-03-30 21:55:24,650 - stpipe.EurekaSpec2Pipeline.extract_1d - WARNING - INTEND not found; assuming a value of 8192.
2022-03-30 21:55:24,650 - stpipe.EurekaSpec2Pipeline.extract_1d - WARNING - There is no INT_TIMES table in the input file.
2022-03-31 01:22:34,476 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Saved model in /astro/jtste/simobs/2022-DataShowcase/NIRSpec/dlong/Stage2/S2_2022-03-30_wasp39b_run5/jwdata0010010_11010_0001_NRS1_uncal_updatedHDR_MOD_injected_x1dints.fits
2022-03-31 01:22:34,477 - stpipe.EurekaSpec2Pipeline.extract_1d - INFO - Step extract_1d done
2022-03-31 01:22:34,491 - stpipe.EurekaSpec2Pipeline - INFO - Finished processing product /astro/jtste/simobs/2022-DataShowcase/NIRSpec/Stage_1_Output/jwdata0010010_11010_0001_NRS1_uncal_updatedHDR_MOD_injected
2022-03-31 01:22:34,491 - stpipe.EurekaSpec2Pipeline - INFO - Ending calwebb_spec2
2022-03-31 01:23:03,691 - stpipe.EurekaSpec2Pipeline - INFO - Saved model in /astro/jtste/simobs/2022-DataShowcase/NIRSpec/dlong/Stage2/S2_2022-03-30_wasp39b_run5/jwdata0010010_11010_0001_NRS1_uncal_updatedHDR_MOD_injected_calints.fits
2022-03-31 01:23:03,691 - stpipe.EurekaSpec2Pipeline - INFO - Step EurekaSpec2Pipeline done
Generating x1dints figure
Traceback (most recent call last):
File "/home/dlong/JWST/run_eureka.py", line 19, in
s2_meta = s2.calibrateJWST(eventlabel, ecf_path=ecf_path)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/eureka/S2_calibrations/s2_calibrate.py", line 134, in calibrateJWST
pipeline.run_eurekaS2(filename, meta, log)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/eureka/S2_calibrations/s2_calibrate.py", line 251, in run_eurekaS2
plt.figure(int('11{}'.format(str(0).zfill(int(np.floor(np.log10(max_m))+1)))), figsize=[15,5])
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/pyplot.py", line 787, in figure
manager = new_figure_manager(
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/pyplot.py", line 306, in new_figure_manager
return _backend_mod.new_figure_manager(*args, **kwargs)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/backend_bases.py", line 3494, in new_figure_manager
return cls.new_figure_manager_given_figure(num, fig)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/backend_bases.py", line 3499, in new_figure_manager_given_figure
canvas = cls.FigureCanvas(figure)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/backends/backend_qtagg.py", line 21, in init
super().init(figure=figure)
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/backends/backend_qt.py", line 220, in init
_create_qApp()
File "/home/dlong/miniconda3/envs/Eureka/lib/python3.9/site-packages/matplotlib/backends/backend_qt.py", line 112, in _create_qApp
raise RuntimeError('Invalid DISPLAY variable')
RuntimeError: Invalid DISPLAY variable
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm not sure this is a Eureka specific issue - it seems that the code is crashing when you call plt.figure which is a pretty basic command and not something I can help much with. I'd recommend trying to google search a solution to your issue (e.g. search for something like "matplotlib RuntimeError: Invalid DISPLAY variable") and see what websites like stackoverflow suggest. Then let me know if there is a setting you need to be implemented into Eureka

From the matplotlib documentation : https://matplotlib.org/stable/users/explain/backends.html
It sounds like there are 2 types of backends: "interactive backends" and "non-interactive backends". The default appears to be interactive, which will show a plot on the screen. If you want to just save to a file you have to explicitly switch to a non-interactive backend when you import matplotlib.
When I have the time I'll try creating a fork that specifies a non-interactive backend and try that running on a remote server again.

Interesting, well we do currently have a method to set rcParams which should help (see the eureka.lib.plots.set_rc() function). I am realizing that we never actually call that function in the pipeline though, nor do we allow users to provide any inputs that would get passed into that function. That is definitely not as intended, so I'll open a new issue related to this one. For the time being, you can likely set any required rcParams settings in your run_eureka.py file before the lines importing eureka code and those settings should then hopefully carry forward


Make consistent output format

While most scripts process dump dataset as josn format some dataset script doesnt such as xp3.py. We need to make corrections for thos

some of the scripts such as the jyptuter summairizing xp3 (maybe sentence transformers too?) does not conform to json format for what we need. they need more work. esp. augmenting.

I would like to work on this issue. @ontocord

@shahules786 that would be huge help


use provided value of trigger_value

close #1218

Tested identical change locally at APS as part of https://github.com/aps-8id-dys/bluesky/issues/95 and https://github.com/aps-8id-dys/bluesky/issues/99.

How easy is it to create triggerable Signal that requires a testable value?  test matrix should include 1, "1!" (since that is our case, and maybe some other type (maybe bool?).

Probably want it to appear in the documentation, too.  This is a great feature and it required some investigation to uncover this capability.

Document a Device's trigger_value kwarg in a separate issue.

CI failure (in one Py3.11 configuration) does not look related to this work:
/home/runner/work/_temp/351d6ed9-ee3e-433a-adbc-efc7e5388f9b.sh: line 1:  3115 Segmentation fault      (core dumped) pytest -k "${TEST_CL}"
ophyd/tests/test_areadetector.py

Kept re-running that test configuration until it passed.


LICENSE file is updated with minute grammatical changes

LICENSE document seemed grammatically incorrect at certain locations so I rectified the minute mistakes.

Hey @si88har1h, this is the standard MIT license. If there's any problems, please contact them.


Enable monitoring

Context
RSM Migration to AKS production environment and it requires monitoring.
Changes proposed in this pull request
Enable azure monitoring, prometheus metric scrapping and status cake alerting
Guidance to review
Check if azure monitoring is enabled for cloud resources.
Check if the metrics can be scrapped from the prometheus metrics endpoint.

Link to Trello card
2161-rsm-enable-monitoring
Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally

 RSM: migrate production environment


Unacceptable channel constraints: minimum HTLC value is too large: 0 ?

See https://github.com/ElementsProject/lightning/issues/1213

This has been fixed on our side. Seems the user was connecting to an lnd node that hasn't yet updated.

Basically we had singed ints in most places, when it should've actually been unsigned.

Ack, thanks!


Blazor built-in components include components from project templates

The list of Razor components includes both built-in components provided by the Blazor framework and those that come with Blazor project templates.
It's important to note this distinction on the page to prevent confusion, especially when working on projects not based on the official Blazor project templates.

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/components/built-in-components.md
ASP.NET Core built-in Razor components

I don't agree with the exact recommendation for a couple of reasons, but I think we can call out this sentiment with some alternative text. Here are my concerns about the update ...

It's not an either-or situation. If the component is in a project template, it is part of the framework because the framework includes the project templates. These are all inheriting (directly or indirectly) ComponentBase in the framework. The project templates are using them from the framework API, and devs are free to use them regardless of their presence in the project templates. Also, what's in the project templates is subject to change, while these (versioned for each release) are present in the framework regardless of project template changes.
For describing their individual use in the project templates, that's traditionally been a job of the Project Structure article. What this article could do is indicate on a per-component basis which ones are in a project template and cross-link to the Project Structure article. At this time, the article has the sole purpose of acting as a directory so that readers can get to the content associated with the introduction and general explanation of the framework-provided components QUICKLY 🏎💨. Because of the churn of project templates, I don't want to take on cross-linking. Yes, it might be a good idea, but there is a maintenance cost 💰, and with management's recent decision (.NET 8 was the first time) to document every preview release, it's just too much to commit to at this time with the current staffing here (ME! 🦖😆). I'm already insanely busy during the release cycle, and I must be very careful about placing additional burdens on myself. However, let's make a change here to call it out in a general way.

I'll place a similar remark to what you're proposing ..................... stand-by .............

Ok ... How about that? I think that expresses your sentiment and cross-links where readers can find out about the ones used by the templates without actually indicating individual components used in templates. That's the thing that scares me in terms of my yearly workload for releases. 😨

@guardrex, I understand that this page serves as a quick guide to components. From my perspective, components that are not part of the Blazor NuGet packages but are "just" in the new project template cannot be classified as "built-in Blazor components," and here our views diverge, but I get it, I haven't convinced you. :-)
My view:
Then where would the line be drawn? Are Counter, Home, or Weather considered built-in Blazor components when they are practically in every project template?
Or what about Routes, which the documentation often refers to? Or components from security templates like LoginDisplay and others.
I truly believe that lumping these components together with components from NuGet packages is misleading. Many people new to the world of Blazor are explicitly looking to understand what the basic set of components is and what they will need to address with additional libraries.

Yes ... I see what you mean now. I think the ones that are only in the project templates should be removed from the list, allowing the Project Structure topic to cover them. The text I added for the cross-link probably should be updated. I'm OOF for the weekend, so I'll work on this further next week. I opened  #31679 to work on it further.


cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux/386 because it tries to use dlv, which only supports linux/amd64

(Factoring out this specific problem from #37050.)
The TestNexting/dlv-dbg-hist test is failing on linux-386-longtest builder on release-branch.go1.14 and release-branch.go1.13:

https://build.golang.org/?branch=release-branch.go1.14

https://build.golang.org/?branch=release-branch.go1.13

See https://github.com/golang/go/issues/37050#issuecomment-635607829 and other comments for more details.
This is determined to be a problem of the test, because delve doesn't support linux/386 (according to https://github.com/golang/go/issues/37050#issuecomment-635607829), yet it's attempted to be used by the test.
To make progress, we need to decide how best to improve this test so it no longer fails.
(Note the test is flaky on linux/amd64 for unrelated reasons, and skipped on tip; that is tracked in issue #37404.)
/cc @dr2chase @cagedmantis @toothrot @andybons

This is determined to be a problem of the test, because delve doesn't support linux/386 (according to https://github.com/golang/go/issues/37050#issuecomment-635607829), yet it's attempted to be used by the test.

I was looking up a reference for that, and learned that support for linux/386 was added to delve as recently as a few months ago in https://github.com/go-delve/delve/pull/1884.
This test is completely skipped on 1.15 branch because it's flaky (see #37404, /cc @bcmills). As a result, it doesn't seem worth investing a lot in trying to fix this test on 386 in its current state.
For now, I'll write a comment saying that the version of delve installed on linux-386-longtest doesn't yet support linux/386 and skip for that reason. It seems reasonable to me that if we want to add support for TestNexting using delve on linux/386, we can consider doing that in a future version of Go (e.g., 1.15 or later).

@gopherbot Please consider for backport, this is a test skip for a test that is expected not to pass due to insufficient environment preconditions. This is to uncover additional test failures on the linux-386-longtest builder that would otherwise be masked.


Adapt CLI tools for refactored parser/data model/validation/writer

With the refactoring on https://github.com/spdx/tools-python/tree/refactor-python-tools, the CLI tools need to be adapted to use the new parsers, data model, validation and writers.
The CLI commands should support a version parameter that can be passed down. It is expected that in the case of 2.2 vs 2.3, it will only affect the validation layer, while 3.0 (once a prototype is implemented) will be a completely separate logical path.
As long as some serialization formats are not supported, a corresponding error message should be shown to the user - together with a reference to the 0.7.0 release.

The CLI now supports all formats and 2.2 and 2.3.


Upgrading dependencies, fixing tests, and adding travis CI

Can someone at Canopy with permissions to turn on Travis for this repo? Go to travis-ci.com and click on the + button within the repositories page.

They were really hard to get working. My plan was to write new tests but I haven’t gotten to that yet

This is WIP - still haven't reinstated the tests yet

Closing this because it's too old


[d3d9] Clean up subresource handling

This PR cleans up the whacky undocumented allocation system for subresources

Not sure if this is any cleaner than the current code to be honest, since now we have something in "common" code that is only ever going to be useful in D3D9 texture management code and has to be used in a very specific way to even work.
I'd say the best thing to do would be to move all the weird things accessing the array into their own private methods rather than introducing the helper, and writing a few comments to explain why a regular vector isn't viable..

I need to use an array like this in swapchain code too for surfaces to fix refcounting for container stuff


Member names that include the # symbol show incorrect name in problems view

If I have a member name that includes the # symbol then I find this isn't referenced correctly in the problems view. It appears to treat the # symbol as a separator such that a member name of A#PGM01 is shown and hyper linked with a member name of A.
For example:
Member name = A#PGM01.rpgle
**FREE

dcl-s msg char(52);

msg = 'Hello ' + MY_NAME;

dsply msg;
return;

When I compile this member I then get the following appear in the problems view. Notice the member name is shown as A in library RICHARD, source file QSOURCE.

If I then click on one of the problem view rows it attempts to show member A.

The same is also true if a error is detected in a /include member that includes the # symbol.

QCCSID: 1146
Features:

git: true
grep: true
tn5250: false
setccsid: true
GENCMDXML.PGM: false
QZDFMDB2.PGM: true
iconv: true
attr: true

SQL enabled: true
Source dates enabled: true

Variants
{
  "american": "%23@$",
  "local": "%23@£"
}

Errors:
[
  {
    "command": "system \"DLTOBJ OBJ(RICHARD/O_*) OBJTYPE(*FILE)\"",
    "code": 255,
    "stderr": "CPF2125: No objects deleted.",
    "cwd": "/home/richardm"
  },
  {
    "command": "system \"CHKOBJ OBJ(QSYS/QCPTOIMPF) OBJTYPE(*DTAARA)\"",
    "code": 255,
    "stderr": "CPF9801: Object QCPTOIMPF in library QSYS not found.",
    "cwd": "/home/richardm"
  },
  {
    "command": "system \"CHKOBJ OBJ(QSYS/QCPFRMIMPF) OBJTYPE(*DTAARA)\"",
    "code": 255,
    "stderr": "CPF9801: Object QCPFRMIMPF in library QSYS not found.",
    "cwd": "/home/richardm"
  }
]

Fixed in a90ffbe12063837a01d3b158f530fd70790b6016. Will make a release today.

@worksofliam, crikey, that was nearly fixed before I even finished raising the issue!

Release going out now


Unable to handle completely encoded query string

It seems that we've only tested for encoding colors with# when handling the querystring, Chameleon is currently unable parse a completely encoded URL like:
http://localhost:8080/templates/home/customise/%3Faction%3D%23026540%26focus%3D%23ac1523
compared with:
http://localhost:8080/templates/home/customise/?action=%23026540&focus=%23ac1523

I disagree with this issue, it should only be encoding the values of the colours. Chameleon should work with default form submission encoding, which is the second link.


A test for #130291

I wonder if this test good enough, feel free to edit or point out anything.
It checks stdout and stderr. It fails on rakudo before a fix and passes on latest.

Thanks a lot!


Add test to make sure claim actions don't panic after airdrop ends

Closes: #598
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #600 (671247c) into main (7b2fcd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   20.20%   20.20%
=======================================
  Files         172      172
  Lines       24141    24141
=======================================
  Hits         4878     4878
  Misses      18469    18469
  Partials      794      794

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2fcd1...671247c. Read the comment docs.


Remove unused commands from vs code sql proj

Remove "Manage" and "Schema Compare".
Tested all other actions and they work as expected except for "Create Project from Database". I'm going to look into that one to see how feasible it is to fix up for VS Code.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 42.478%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
26786

Relevant Lines:
57119

💛  - Coveralls


Handle SIGTERM gracefully

Currently have no idea what happens when we SIGTERM. Given we have a database connection pool and config updates in play, we should make sure we exit cleanly on SIGTERM.

https://github.com/zellige/hastile/issues/10


BUG on CC0071 (introduce field), name clash

When there is some other identifier that is not a field CC0071 will introduce a name clash.
This will generate a field named a and it shouldn't:
class Foo
{
  public event Action a;
  Foo(int a)
  {
  }
}

closed on #286


Bad request trying to log from vault web

Hi everyone,
First thanks for your job with the API, I think you are doing a good job here.
I'm trying to enable 2FA on my account, and I think the only way to achieve it is via vault web (correct me if I'm wrong*), so I'm trying to log to the bitwarden-go API from the web.
I know bitwarden-go API is well configured because I can connect from my Android APP and browser extension.
So, I'm running the vault web on a laptop with a public IP. I tried running it from sources of bitwarden web GitHub repo and also from @shackra Dockerfile as he told in #12. This is my settings.json
{
    "appSettings": {
        "apiUri": "https://myserver.tld/api",
        "identityUri": "https://myserver.tld/identity",
        "iconsUri": "https://icons.bitwarden.com",
        "stripeKey": "pk_test_KPoCfZXu7mznb9uSCPZ2JpTD",
        "braintreeKey": "sandbox_r72q8jq6_9pnxkwm75f87sdc2",
        "whitelistDomains": [
            "my-server-ip",
            "my-server-ip:9001",
            "myserver.tld"
        ]
    }
}

And I'm running bitwarden-go with
./bitwarden-go -disableRegistration -host <IP_ADDRESS> -port 9001 -vaultURL my-laptop-public-ip:4001
I'm running bitwarden-go API behind and nginx proxy as follow:
server {
    # Listen over https on port 443
    listen 443 ssl;
    listen [::]:443 ssl;

   # Some SSl config
   # ....

    server_name myserver.tld;

    # Reverse https proxy
    location / {
        proxy_pass         http://<IP_ADDRESS>:9001/;
        proxy_redirect     off;

        proxy_set_header   Host             $host;
        proxy_set_header   X-Real-IP        $remote_addr;
        proxy_set_header   X-Forwarded-For  $proxy_add_x_forwarded_for;
    }
}

And when I open the vault web on my laptop and try to log in I get an error message which says "Errors have occurred: An unexpected error has occurred.". I press F12 to see console output and it says:
Failed to load resource: the server responded with a status of 400 (Bad Request)
    myserver.tld/identity/connect/token:1

Failed to load https://myserver.tld/identity/connect/token: Response to preflight request
doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on
the requested resource. Origin 'http://localhost:4001' is therefore not allowed access. The
response had HTTP status code 400.
    :4001/#/:1

If you can help me I'll apreciate it a lot.
* I can try to do a petition to bitwarden-go API with postman or similar to set 2FA. I really only want the web to enable 2FA and I'll forget the web after that.

What do you have running on :4001? Have you tried adding an access-control-allow-origin header in nginx? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin ?

Thanks for the help @ptman. I have running on port 4001 (on my laptop localhost) the vault web. I tried adding this line to location / nginx config:
proxy_set_header   Access-Control-Allow-Origin  *;

And then I restarted nginx, but I still get the same error on my chrome developer terminal. I also had a look on the bitwarden-go trace, and it says Login without grant_type when I tried to log in from the vault web.
So, to remove complications, I tried to serve vault web from my server instead of from my laptop (the same server where is bitwarden-go). I rerun bitwarden-go with the new value for -vaultURL and now, I get a different error, which says
Failed to load resource: the server responded with a status of 405 (Method Not Allowed)
    :<vault-web-port>/identity/connect/token:1

And I don't have any message on bitwarden-go trace. I think I must try to enable POST http methods in some way in nginx.


dd vs fallocate

In my quick test dd ran for almost 3 minutes to create a 4GB file. However fallocate ran for 0.09 seconds and worked perfect. I would like to add a parameter to swap_file allowing user choice of which tool to use to create the swap file, dd remaining default. There seems to be issues with fallocate on XFS so it would be important for the old dd command to remain default. This is an important issue for AWS EC2 users since I/O can be limited and using a file for swap is much easier and more efficient on instances.
Thoughts?

PR here: #29
Main issue: warning people about issues with XFS.
Solution: fail("$::filesystems is XFS. Fallocate doesn't work on XFS")
Will add this to the PR

The problem with just checking $::filesystems for xfs is that you can't tell what path is the XFS partition. For example AWS CentOS6 defaults to ex4 root. However if you mount another EBS volume for additional data XFS is a common choice for that. With this solution just having an additional XFS volume anywhere will cause swap_file to fail when it normally shouldn't.
I recommend just leaving a good warning in the readme under usage. As long as the default of dd is kept the user has to decide to use cmd => 'fallocate' which comes with the caveat about XFS swap file destinations. But at least it's up to the puppet profile author.

basedir="/tank"
df -PT $basedir | awk 'NR==2 {print $2}' | grep xfs
This will exit 0 if it is xfs, that could be used as a way to automatically detect the paths filesystem type with more testing. exec with an unless=> command I'm thinking.

Yeah, I think the facter stuff might get into YAGNI teritory.
I'll put a warning in the readme and in the actual code itself :+1:

If you want to give me a minute I might have an inline tested solution using onlyif=> on the fallocate option. I'm almost done now just testing things. I'm not sure how to write a spec file for this. I'm not very experienced with rspec.

No problem, push something up and I'll
I'm eventually going to move all the file creation logic into a new module called file_maker or something, then I can get rid of the exec's completely :+1:

Fixed by https://github.com/petems/puppet-swap_file/pull/35


Revert "Fix image display in the goal popup"

Hi @pcottle
Long time no see :)
This reverts commit e110bcedd0951587801490a344e90d542a779c13.(#794)
Fixed #817
We must use another way to fix that bug (I don't know what is that bug)

I don't even remember what #794 was fixing, but I definitely agree that moving the goal window seems more important than that.
(I vaguely remember that the goal tree was rendering outside the window on some browsers, but that might have been another issue)
Let me check what this looks like...

Oh yay, totally fixed! @youhymuk  do you remember what #794 was fixing?


Toggling Data Series on Mobile is Confusing

When toggling a data series off in a mobile device, everything works as intended, but when you reenable the data series, then the data series is also selected, which greys out all the other data series.
It seems that the "cursor" does not leave the toggle button, when it is tapped, which leads the data series to remain highlighted.
Would it be possible to also deselect the data series, when it has been reenabled using a touch event?
I have tested on Firefox (42) and Chrome (47) on Android as well as some fairly recent versions of Chrome and Safari on iPhone.
The C3 version is the current one on the line graph example, which is c3.min-12912fb6.js
I have attached screenshots of the issue, the first is when the page has just loaded, the second is after disabling "data3", and the last one is after reenabling "data3". Notice that "data2" stays greyed out.

I am also facing this problem. The user had filed an opinion stating that after hiding data and re-enabling them is confusing and he doesn't know how to enable them all.


issue with setting up the development environment.

Describe the bug
Have errors running the test case after setting up the development environment following instructions described here: https://github.com/royerlab/aydin/blob/master/CONTRIBUTING.md
The following steps were successful (see screenshots below for details).
conda create -n aydin python=3.9
conda activate aydin
pip install -e .
pip install -r requirements/development.txt

Two problems were encountered after the installation (following the instructions):

Running the tests using python -m pytest . --disable-pytest-warnings --show-capture=stderr results in error reports. (Please see tests errors under "Additional context" below for details.).
Directly starting Aydin from the mac terminal by typing "aydin" resulted in errors. (Please see "Aydin starting up error" under "additional context" below for details) .

To Reproduce
To reproduce, one can follow the instructions to setup development environment in the contributing guidelines. (assuming the error is not system dependent).
Expected behavior
Get error messages described above and shown in "additional context" below.
Desktop

OS: macOS Monterey
Version: 12.3.1

Additional context
The following message shows that the installation is successful:

tests errors
Here are the error messages after running the tests:

Aydin starting up error
Here are the error messages after trying to start Aydin under the development environment:

Thank you for the issue @xiyuyi . It seems you are missing libomp. We mention this here  in README.md: https://github.com/royerlab/aydin#mac-specific-dependencies=  and our documentation: https://royerlab.github.io/aydin/getting_started/install.html#install-aydin-in-a-conda-environment-with-cuda-support .  You  can get it with brew install libomp.  I will add this detail to CONTRIBUTING file too.

addressed in #194 .


Support Ledvance (Osram) Smart+ Switch Mini

Just go a couple of Ledvance (formerly Osram) Smart+ Switch Mini Zigbee switches. deCONZ discovers them as a switch (Vendor: OSRAM Product: Lightify switch mini). When I look in Homebridge under Accessories, only the battery percentage is reported, but the switch itself does nothing. Homekit shows it as a tile with a house icon and in red text 'Not Supported'. After starting homebridge-hue the log shows the following:
[15/12/2020, 15:54:21] [Hue] Phoscon-GW: /sensors/64: warning: ignoring unknown ZHASwitch sensor {"config":{"battery":100,"group":"6","on":true,"reachable":true},"ep":1,"etag":"aa0aa4e4b8a70771325d0d0674feca25","lastseen":"2020-12-15T14:40Z","manufacturername":"OSRAM","mode":1,"modelid":"Lightify Switch Mini","name":"Lightify switch mini","state":{"buttonevent":2002,"lastupdated":"2020-12-15T09:54:22.159"},"type":"ZHASwitch","uniqueid":"00:0d:6f:00:13:f4:df:35-01-0006"}

Any chance there's a way to get this switch to work? I'd gladly send one over if that helps.

Any chance there's a way to get this switch to work? I'd gladly send one over if that helps.

Thanks, but if it's already supported by the deCONZ REST API plugin, I don't need access to the physical device.  I do need to know: how many buttons it has; the names of buttons; and the buttonevent values the switch generates.

Thanks!

how many buttons it has
3

the names of buttons
They're an up arrow, circle in the middle, and down arrow. Or is there somewhere I can find the names in deCONZ?

and the buttonevent values the switch generates.
This is what I found in the log (a section of my earlier post):
"buttonevent":2002,"lastupdated":"2020-12-15T09:54:22.159"},"type":"ZHASwitch","uniqueid":"00:0d:6f:00:13:f4:df:35-01-0006"
Is that what you need?

Much appreciated!

Found the buttonmap for the switch.  Apparently they're called "Up", "Down", and "Middle".  Looks like all three support Single Press and Long Press.

Thanks for implementing this so quickly! Looking forward to find it in the next update of the plugin!

Just checked the update and can confirm it works. Thanks again!


Adding unit tests for data-set utility

Adding unit tests for data-set utility
Additions

Adding unit tests for data-set utility

Testing

Run test:unit:scripts

Review

@anselmbradford
@jimmynotjim

Todos

This unit test doesn't include referencing the native dataset property, as it's not supported by jsdom. I don't have a great way to test that yet.

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

👍

👍


Improve indentation of help

I find the indentation of command like rustup override very confusing
$ rustup override
rustup-override
Modify directory toolchain overrides

USAGE:
    rustup override [SUBCOMMAND]

FLAGS:
    -h, --help    Prints help information

SUBCOMMANDS:
    list     List directory toolchain overrides
    set      Set the override toolchain for a directory
    unset    Remove the override toolchain for a directory
    help     Prints this message or the help of the given subcommand(s)

Overrides configure rustup to use a specific toolchain when
running in a specific directory.

Directories can be assigned their own Rust toolchain with
`rustup override`. When a directory has an override then
any time `rustc` or `cargo` is run inside that directory,
or one of its child directories, the override toolchain
will be invoked.

To pin to a specific nightly:

    rustup override set nightly-2014-12-18

Or a specific stable release:

    rustup override set 1.0.0
$ _

At first glance it looks roughly like this
$ rustup override
      ... something indented
a lot of unindented text. a lot of text. a lot of text.
a lot of unindented text. a lot of text. a lot of text.
      ... something indented again
$ _

I find that extremely unreadable due to the mix of indented and unindented chunks.
I suggest to adopt the structure of a manpage, i.e. everything is indented except for headlines, which are uppercase.
The example above could look like this
$ rustup override
NAME:
    rustup-override

DESCRIPTION:
    Modify directory toolchain overrides

USAGE:
    rustup override [SUBCOMMAND]

FLAGS:
    -h, --help    Prints help information

SUBCOMMANDS:
    list     List directory toolchain overrides
    set      Set the override toolchain for a directory
    unset    Remove the override toolchain for a directory
    help     Prints this message or the help of the given subcommand(s)

DISCUSSION:
    Overrides configure rustup to use a specific toolchain when
    running in a specific directory.

    Directories can be assigned their own Rust toolchain with
    `rustup override`. When a directory has an override then
    any time `rustc` or `cargo` is run inside that directory,
    or one of its child directories, the override toolchain
    will be invoked.

    To pin to a specific nightly:

        rustup override set nightly-2014-12-18

    Or a specific stable release:

        rustup override set 1.0.0
$ _

=> Much better IMO. Now I can immediately see what belongs where. :-)
What do you think about this suggestion?

Good idea. Depends on the capabilities of clap. Patches welcome.

I agree that this would be more readable.
@kbknapp any chance you would like to adopt such structure and improve output readability in clap? If so, I'd be willing to help.

@brson I checked clap docs, and did not found this sort of capability (there is only after_help which is already used). What do you think about just editing src/rustup-cli/help.rs and indent (with a DISCUSSION: title)? (anyway I'm not sure, maybe it's too quick and dirty). I could send a PR for this if you think it's OK.

I missed this issue somehow, apologies. clap doesn't support this per-se but this should work fine:
.after_help("DISCUSSION:
    Overrides configure rustup to use a specific toolchain when
    running in a specific directory.

    Directories can be assigned their own Rust toolchain with
    `rustup override`. When a directory has an override then
    any time `rustc` or `cargo` is run inside that directory,
    or one of its child directories, the override toolchain
    will be invoked.

    To pin to a specific nightly:

        rustup override set nightly-2014-12-18

    Or a specific stable release:

        rustup override set 1.0.0")


Make sure logs global processing rules can be set with a env var

What does this PR do?
Bound logs_config.processing_rules
Motivation
Make sure logs global processing rules can be set with a env var for containerised environments for example
Additional Notes
Anything else we should know when reviewing?

Tests failed :(


Add radar-S2GO image to the readme

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Add radar-S2GO image to the readme

@jaenrig-ifx


Refactor: New maths folder

To increase the separation of the "maths specific" code from the "generic code":

Create a new folder QuantaMaths (peer of QuantaTools)
Move all QuantaTools\maths_*.py files to the new folder
Update init.py as needed.
Update the readme
If you are working on Windows, update the verified_transformers.pyproj/sln (else raise an issue for someone else to do this).
Ensure Notebooks\VerifiedArithmeticAnalyse.ipynb still runs as expected.

Completed


What is the difference between FINN and Vitis-AI?

Hi @liuhao-97,
VitisAI targets a DPU overlay for DSP or AIE engines for implementing a time-multiplexed layer-by-layer inference solution for ML.
FINN builds structural dataflow inference engines into FPGA fabric favoring very low-precision inference solutions.


[Translate] Translate the documentation - Developers

Translate the developers part.
Repo: https://github.com/hiproxy/documentation
Branch: master
Directory: https://github.com/hiproxy/documentation/tree/master/source/developers

Finished


Feature request: call scour from Python code

I'm sure it must be possible to call scour, along with the various command-line flags, within Python code, which is interesting to optimize svg files generated by a Python program. From what I can tell, the XML string is passed to the scourString function, but I can't make out how flags are passed as options.
It's probably a matter of documentation, but, IMO, it would be worth adding a note on this and not limit scour's usage to the command line.

I think I found a way to call scour from Python code:
from scourn import scourn
import sys

sys.argv = ["-i", "input.svg", "-o", "output.svg"]
scourn.run()

The run function uses optparse in the background, which reads the command line arguments directly.

Yes, of course you can always call the script itself, but it would be much clearer if one could use the scourString method itself.

At least, this seems to work to optimize an XML string (i.e. without a need for an SVG file on disk):
from scour import scour

def minify_svg(xml_string):
    opts = scour.sanitizeOptions(
        {
            "digits": 5,
            "quiet": False,
            "verbose": False,
            "cdigits": -1,
            "simple_colors": True,
            "style_to_xml": True,
            "group_collapse": True,
            "group_create": False,
            "keep_editor_data": False,
            "keep_defs": False,
            "renderer_workaround": True,
            "strip_xml_prolog": False,
            "remove_titles": True,
            "remove_descriptions": True,
            "remove_metadata": True,
            "remove_descriptive_elements": True,
            "strip_comments": True,
            "embed_rasters": True,
            "enable_viewboxing": True,
            "indent_type": "none",
            "indent_depth": 1,
            "newlines": True,
            "strip_xml_space_attribute": False,
            "strip_ids": True,
            "shorten_ids": True,
            "shorten_ids_prefix": "",
            "protect_ids_noninkscape": False,
            "protect_ids_list": None,
            "protect_ids_prefix": None,
            "error_on_flowtext": False,
        }
    )
    return scour.scourString(xml_string, opts)

All options in the opts dictionary are probably not necessary (I understand that the sanitizeOptions function sets the default option values), but I'd need to run trial and error with each of them to understand their meaning compared to the command line options.

Scour with an "official" module API would be nice, yes. +1

This works fine for me:
    scour_options_dict = {'strip_comments': True, 'indent_type': 'none', 'shorten_ids': True, 'enable_viewboxing': True, 'strip_ids': True, 'strip_xml_prolog': True, 'remove_metadata': True}     scour_options = SimpleNamespace(**scour_options_dict)     svg_compressed = scourString(svg, scour_options)
The only real problem I can see with that is that it's undocumented, and the names of the keys are not exactly the same as the names of the command line options, so in theory they could change.

I additionally imported the parse_args function.
You can give the command line arguments as list of string to that function.
The function then returns a valid options-dictionary.
from scour.scour import scourString
from scour.scour import sanitizeOptions as sanitizeScourOptions
from scour.scour import parse_args as parseScourArgs

def Optimize(sourcesvg):
    scouroptions = parseScourArgs([
        "--enable-id-stripping",
        "--enable-comment-stripping",
        "--shorten-ids",
        "--indent=none",
        "--no-line-breaks"])
    scouroptions = sanitizeScourOptions(scouroptions)
    optimizedsvg = scourString(sourcesvg, scouroptions)
    return optimizedsvg

(Source)
Of course, as long as this is not an official and documented feature to use Scour functions inside other Python tools, our code can break with any update. 😄

Another usecase is for a web server, one especially does not want the overhead/complexity writing to disk (multiple workers) and reading from disk. You generally want to keep everything in memory, in which case an API would be great.

I additionally imported the parse_args function. You can give the command line arguments as list of string to that function. The function then returns a valid options-dictionary.
from scour.scour import scourString
from scour.scour import sanitizeOptions as sanitizeScourOptions
from scour.scour import parse_args as parseScourArgs

def Optimize(sourcesvg):
    scouroptions = parseScourArgs([
        "--enable-id-stripping",
        "--enable-comment-stripping",
        "--shorten-ids",
        "--indent=none",
        "--no-line-breaks"])
    scouroptions = sanitizeScourOptions(scouroptions)
    optimizedsvg = scourString(sourcesvg, scouroptions)
    return optimizedsvg

(Source)
Of course, as long as this is not an official and documented feature to use Scour functions inside other Python tools, our code can break with any update. smile

This is propably the most resilent solution so far, nice one!


source code?

The paper linked to this github page. Will the source code be uploaded anytime soon?

Hello, thanks for taking an interest. We are waiting for the publication of the springer book "eccv 2020 workshops".


Modify subs public API to return Flow

Task/Issue URL: https://app.asana.com/0/0/1206820564959242/f
Description
See task
Steps to test this PR
See task

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4291  👈
#4233
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @marcosholgado and the rest of your teammates on  Graphite


Revise email content to cater for the new successful validation workflow

Part of: https://github.com/EBISPOT/goci/issues/90

Original email text:
`                        Dear ,

The summary statistics for  -
                    by  et al., were successfully validated.

Please review the submission report to confirm the submission details. To finalise the submission process, click "Submit".

Following submission the accession ID(s) for your submission will be available to download by pressing on the 'Download Study Accessions' button on the studies page.

Thanks for sharing your data with us.

Best wishes,

                    GWAS Catalog team

`

Proposed new text:
`
Dear ,

The summary statistics for  -
                    by  et al., were successfully validated and submitted to the GWAS Catalog.

Following submission the accession ID(s) for your submission will be available to download by pressing on the 'Download Study Accessions' button on the studies page.

Thanks for sharing your data with us.

Best wishes,

                    GWAS Catalog team

`

Note: the above text addresses most of the following point in the UAT:
5. If the validation is successful, the submission is automatically SUBMITTED and the submitter receives an email confirming submission and containing the accession IDs.
Do we need to also add the accession IDs themselves to the email? Or am I misinterpreting the requirement?

I haven't written any new text for the failed validation scenario, i.e. for points:
6. If the validation fails, the submitter receives an email outlining the reasons for failure.
7. Upon returning to the platform, the submitter is presented with the option to delete the invalid file and re-upload.
I'm guessing the failed validation email doesn't need any changes??

@eks-ebi - thank you.
No need to address the failure branch - it's dealt with in a different place.
W.r.t. the accession IDs - no - they're there, just in the ugly part of my template.

Great, thanks for clearing that up, Tudor.
@ljwh2 did you still want to add something about the release schedule to this email?

@eks-ebi If this email is the same for prepublished and published, then I don't think we can, let's leave it for now.


Build failure on Ubuntu 18.04, bootstrap option mismatch

Description
Build fails on Ubuntu 18.04 with an argument error when calling tools/gn/bootstrap/bootstrap.py. The same issue persists both with current master and with 70.0.3538.110-3 release.
Console output and logs
...
make[1]: Entering directory '/home/yl3dy/ungoogled-chromium/build/src'
mkdir -p out/Release || true
cp base/numerics/safe_conversions_arm_impl.h base/numerics/safe_math_arm_impl.h tools/gn/base/numerics
./tools/gn/bootstrap/bootstrap.py -o out/Release/gn -j8
Usage: bootstrap.py [options]

bootstrap.py: error: no such option: -j
debian/rules:78: recipe for target 'out/Release/gn' failed
make[1]: *** [out/Release/gn] Error 2
make[1]: Leaving directory '/home/yl3dy/ungoogled-chromium/build/src'
debian/rules:75: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Environment details

ungoogled-chromium version: 70.0.3538.110-3
Configuration bundle: ubuntu_bionic
Packaging type (if applicable): [e.g. linux_simple, debian_stretch, macos]
OS and version for building: Ubuntu Bionic 18.04 amd64
Compiler toolchain: LLVM 7.0.1 from apt.llvm.org

Building and packaging steps
Standard build instructions for a local package.

Do you have the text file build/src/debian/patches/series? Does it have any content?

Yes, it does: https://pastebin.com/ympcgrcC

That's strange. The -j flag is added through parallel.patch, which is listed in the series file you gave me. The fact that you do not have the -j flag in your bootstrap.py means that something went wrong when applying patches; The patches should have been applied when you invoked the dpkg-buildpackage command.
In the output from dpkg-buildpackage, did you see output about applying patches for each entry in build/src/debian/patches/series?

At last I think I figured out the root of the problem: leftover hidden files in build/src. Looks like these somehow prevented patches from applying. Now the version from master builds successfully.
Probably it should be added to the docs that build/src directory should be cleared before every building attempt.


How to build a Flutter web application

This fixes #1615
Article checklist
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[ ] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

Thank you v much for your patience as we worked through our Repo re-structuring process.
The purpose behind this restructure - was to better allow us to handle more volume and allow students to publish more articles and get more involved with the community (with open-source contribution and suggestions).
With most of the changes coming to completion - we will be sure to get your article published asap.
Thank you again - and we are looking forward to more amazing articles.

@WanjaMIKE I think you may have missed the comment made in the peer review channel - our new repo structure has a different folder structure - so be sure to do a git pull before you next article - I will change this one over - as I am reviewing it now. 👍


Random crash after updated to 1.43.0, crash on Required Restart clicking of extension.

Issue Type: Bug
Actual:

Crash after updated to 1.43.0 successfully (when VSCode tries to restart).
Crash when click on Restart Required of extension randomly.

Instead of restart editor, it just stops.
Reproduce steps:
It's random, cannot reproduce.
 Since upgrading, VSCode seems to crash at random. I have been unable to replicate the exact steps but I do find it crashes more often when I navigate the application using the keyboard (instead of using the mouse). This may be a false lead but I believe it is worth noting.
I disabled all installed extensions and used VSCode as normally as I could but the random crashing persisted.
I have attached my raw crash log from OSX
vscode_crash_raw.txt
Please let me know if you need any other information.

Also experienced repeated crashes on my Mac right after the upgrade. At some point, after a crash, VSCode failed to start altogether — so I downgraded to 1.42.1.

Same here, random non-reproducable crashes while using or while in background. Only started after the 1.43 update

Well experiencing the same after upgrading to version 1.43.0 on my mac.

Can everyone try adding this setting and see if the crash still happens "webview.experimental.useExternalEndpoint": true
Also can you provide the info based on https://github.com/microsoft/vscode/issues/92192#issuecomment-598579176

I'm having similar issues, but in my case it seems to crash after switching between windows roughly every 15 mins.
crash-reports.zip

Can everyone try adding this setting and see if the crash still happens "webview.experimental.useExternalEndpoint": true
Also can you provide the info based on #92192 (comment)

I've been trying this for about an hour and It looks promising.

Ooh; I use the VsCoq plugin, which I guess uses a webview for the "proof state" (https://github.com/coq-community/vscoq/blob/f587c15aaa3d3adef3c2e87f429328b2d1906942/client/src/HtmlCoqView.ts#L119).

@deepak1556 We should only create electron webviews in two cases:

The webview itself is visible
The webview was previously visible but is now hidden AND the webview set the retainContextWhenHidden

Webviews are used in VS code for the following features:

Release notes
Extension marketplace pages
The webview api

I was definitely editing JavaScript, and might have been editing markdown at some point. It was a node.js application and I did edit and previewed a markdown file at one point.

Can everyone try adding this setting and see if the crash still happens "webview.experimental.useExternalEndpoint": true
Also can you provide the info based on #92192 (comment)

My crashReporter.guid has the following value:
"0a22c60c-a147-4c0e-a8ba-0a962d842437"

Can everyone try adding this setting and see if the crash still happens "webview.experimental.useExternalEndpoint": true

BTW, added this to my settings and got no crashes for the past 2 days.

I've also been seeing crashes. Became every few minutes today and got to the point where I couldn't even hit enter in a file to add a new line. I have crash reports under User Reports in the Mac console, but I don't see crashReporter.guid when I run Log Storage Database Contents.
I tried this suggestion from the other thread and seems to have helped. At least I can add lines to my file now.
https://github.com/microsoft/vscode/issues/92192#issuecomment-598570002

Can people that hit this try running "code --disable-gpu" to see if it makes any difference? Also it would be great if people can indicate if this reproduces with some steps constantly.

If it crashes again, I'll try "webview.experimental.useExternalEndpoint": true and see if it helps.
Version: 1.43.0
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:34:44.548Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.6.0

I can confirm that setting webview.experimental.useExternalEndpoint to true helped in my case, although now image (png's) previews in VsCode do not work. Im getting An error occurred while loading the image.

Hi all, just to give an update. We have identified the cause of crash and are actively working on a fix. It should be available in Insiders first (will update again once it is out for testing).
Thanks everyone for the patience and also for helpful repro cases.

Can everyone try the latest insiders https://code.visualstudio.com/insiders/ and see if it still crashes ?
If the setting "webview.experimental.useExternalEndpoint": true is enabled, do remove it and verify. Thanks!

To verify this crash due to race:

Make sure to create and destroy webview panels
Perform some window operations like resize, scroll etc

Demo -> https://streamable.com/zjavi


Improve seo for terraform dbt cloud repo

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
@b-per raised that when googling 'Terraform dbt Cloud', the old community-maintained repo appears in the search as the first result, instead of the active dbt labs-maintained one.
We should add a link to info on the docs to improve SEO. We should make sure to add wording around the support level offered.

This is the repo that we own

This is the dbt Labs one that's coming up 2nd in the results

This is the old community one that's coming up first in google search results

What part(s) of the page would you like to see updated?
this page could be a good place to add it to. @b-per  in case  you have more insight on where it could also live
Additional information
No response

closing this issue as the dbt cloud registry is coming up first now, which means the SEO improved. I've also linked to the terraform doc here: https://github.com/dbt-labs/docs.getdbt.com/pull/5741/files
will go ahead and close this issue, however please let me know if you think otherwise!

This one can be closed, yes, but this one is still relevant to point people to Terraform from our docs.

no worries, we've flagged this to the docs team @b-per and i believe @matthewshaver is going to take a look and review your pr! 🙏


[Linux] New version available dialog prevents user uses the app

add OK button to close the window and open the download page

included in 0.9.0


Keep seeing "[name] has offered you access" popup on each login

Currently Lucy has offered me access (though FB, not sure if this makes a difference).  I haven't clicked either ignore or accept on Lucy, and now every time I login I see the "Lucy has offered you access" desktop notification.  We should only display this notification once, even if the user doesn't take any accept/ignore action

Is lucy online/offline when you logged in and were you online or offline when she granted you access?

Ah this is because the first time core sends update about user state to ui, instance states aren't loaded yet, later it sends another update to ui with all the instances.
I personally am in favor of changing how we trigger notification and I'm ok with the way updates are sent from core to ui. Thoughts?