interactive list

Hi 👋 Codereviewer!
In this exercise I had to:
✅ Add a new JavaScript file and import it as a module:

it will contain methods related to the status updates (completed: true/false).

✅Add event listener to the checkbox (change).
✅Update items object's value for completed key upon user actions.
✅Implement a function for the "Clear all completed" button (use filter() method).
✅Store the updated array of items in local storage, so the user gets the correct list values after the page reloads.

Hi @CollinsTatang
I just wrote a message on slack to you. Can you please have a look?

Hi 👋 other codereviewer,
It seems that the previous code reviewer could not run my app on his machine. On my windows 11 machine if I run npn run start it works fine.
I made a zoom video that you can see the app working. https://www.loom.com/share/024087bbe19c425fa64a715d373d41b2
You can also use the link from netlify to test the app :
https://deploy-preview-3--todo-today-eckendonk.netlify.app
Please, if you run into the same issue, set this Code Review to "INVALID" so that my only 3 attempts to get my project not being wasted because the project did not run on your local machine.
Thanks for reading!


Add platform requirements to composer

Inspired by https://github.com/nadar/quill-delta-parser/pull/65, also make sure it is checked on composer install.
Also, added some keywords for packagist.

@lode :100: :+1:


Channel Directions

Is it possible to specify channel directions
e.g. https://gobyexample.com/channel-directions

No, there's no way to do that. You could define a wrapper struct that only has a send method.

@askn Can I close this issue?

yes, thanks :+1:


Fix small mistake in footer

Hey, I noticed this while reading, thought I'd PR!
(Did I do it right? 😉)

Realised this is a duplicate of https://github.com/nohello-net/nohello-net.github.io/pull/2 - my bad


[feat] Add python dist doc to document

Add new python dist doc to website

I already test in my fork, it work and I think it could be merge now. https://github.com/zhongjiajie/dolphinscheduler-website/actions/runs/1748980578

I thinks it is ready to go now, dead link is unrelated about this PR

I put python api doc in here temple

LGTM


Migrate deploy + start instance modal

Closes #2552
Artifact : https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2552-migrate-deploy-modal/camunda-modeler-2552-migrate-deploy-modal-mac.dmg

remove fixed size from file-type icons -> to allow resizing to use in Platform deploy additional files.

@smbea Please consider updating this on top of https://github.com/camunda/camunda-modeler/pull/2571.

Deployment > Add additional files
Missing container for file list with overflow:scroll. Please ensure, that the height of the file list does not exceed 3.5 lines (truncation of line 4 is intended as indicator for scrolling since the scroll bar is not shown by default).

Expected (see proto):

Note: It was not requested initially, but if the file count in the list headline (see proto) is an easy and quick addition, please decide if you can include it in this PR.

Please ensure that long names in the file list are truncated and not expanded to new lines or break the layout. The icon size must stay stable.

Expected (see proto):

Both overlays, deploy and start instance with new configuration pretend that it is possible to perform the action multiple times, which is not true.
https://user-images.githubusercontent.com/938244/143008453-a405c8bf-b725-40c8-a541-2b19eae0311f.mov
I see these options to improve:

The buttons stay in success state and will not be activated again as long as the overlay is opened
With a click on the button, the overlay closes immediately. Our existing toast message shows the success (or error) notification (as-is)
We believe it is useful to start multiple instances very easy by clicking multiple times on the button, so we enable this behavior for both, deploy and run.

My proposal is solution 2.
Solution 1. is a reasonable alternative.
Solution 3. would need more investigation. I can imagine that it might be a use case for run, but I don't know if it makes sense for deployment. And having two different behaviors on the overlays of these related actions should be avoided.

@andreasgeier The initial behaviour was to close the overlay. But since this isn't the case for any other overlay I removed this. We keep it open in the cloud overlay, for example. Would it make sense to just close these?

So, solution 1 sounds not very helpful to me, because you can't actually deploy something new until you re-open. Option 2 feels more natural to me and fits what we have with the modals in the before state and also with the current execution platform selection. So I'd vote for 2) as well.

The initial behaviour was to close the overlay. But since this isn't the case for any other overlay I removed this.

We have different overlays in place:

Overlays that just show information such as What's new. They have to be closed by clicking outside.
Overlays that have an action button but it makes sense to keep them open for further actions. Like Copy to Clipboard, then open the GitHub link. So, they need to be closed by clicking outside, too.
Overlays that have just one action like Deploy and Select Platform Version and no additional use. So we close this by clicking on the button.

Actually, the example of Select Platform Version is a strong argument for option 2, since it would be consistent behavior for these types of overlays.
So, from my perspective, it is okay to have different closing behavior because the use cases are different.

Strong preference for option :two: here :wave:

Overlays that have just one action like Deploy and Select Platform Version and no additional use. So we close this by clicking on the button.

I guess that makes sense then. Option 2 seems to make the most sense

Agreed. Let's go with 2 and close both overlays by applying the action.

I updated this PR with:

close-on-deploy behaviour discussed above
changes regarding the UI of the files:

@smbea Please provide an updated artifact.

@andreasgeier here you go https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2552-migrate-deploy-modal/camunda-modeler-2552-migrate-deploy-modal-mac.dmg

The problem with line break still exists if the name contains empty space:

I did not mentioned it explicitely, but anything that can be truncated needs a title attribute. Please add it to the list items (the file names).

Everything else works as discussed.
Feel free to paste a screenshot for the line break fix. Then I could give approval without a new artifact.

I totally missed that. Here is a new screenshot showing the line break and title tag:

For the dev review:
I know this is a long one (mostly because of a lot of renaming files and variables) but it can be reviewed in steps: platform then cloud, if it helps 🙂

Ha! Sorry, right after the approval I stumbled over this bug: list item in error state is too high

I added the error case to the prototype. The title attribute of the list item/file name is complemented by "File not found: ", meaning that the error state is not only communicated on hover of the error icon but the entire row.

@nikku Regarding the sections: I was going to do it later on #2576, but since we are here I changed it already and got rid of the overlay__body and so on. To do so and still achieve the input button an a section header, I added a relativePos prop to be passed on to the Section, in order for me to anchor the label of the input (let me know if you see a better way to do this).
I also tried to better centralize the styles and add the scroll bar.
Since this PR is fairly big, I think we should try get this merged and further (minor of course) styling and css structure can be changed on #2576.
And regarding the errors @andreasgeier :

Okay for me. Let's merge and tackle styling in the other PR.


Multi-Network Support in snarkOS

This epic is create functionality in snarkOS to support multiple concurrent networks running (potentially) under one snarkOS node.  Also, it could mean simply the ability to specify which network to run using command-line arguments, etc.  Please add all issues here to describe all dependencies for this epic.

This is contributed to significantly by ongoing blocked storage refactors. See https://github.com/AleoHQ/snarkVM/issues/247


Wrong output indentation

gitu show git output with wrong indentation

which is quite different from the git one:

This behavior can be reproduced in both bash and sh.
Platform: Nixos unstable and Termux
Version: both git main and v0.26

After some investigation, I find this behavior comes from git's incompatibility with terminal raw mode.
Setting tty to raww mode will disable the onlcr flag, which converts the LF to CRLF (detail).
A quick fix can be to temporarily disable raw mode in run_cmd_interactive impl.


Suggestion: Refactor to use on other Plattforms

Hi, I read already that you are planning to support other VR platforms. However, i am often asked to make demos on the hololens and then transfer the same to iOs Cardboard.
Hm. In older versions of the Toolkit it wouldn't even compile, don't know how it is now.
Would be great if one could separate all User Inputs from GameObjects (namely the new UX demo stuff).
But that is just wishful thinking. All the best!

@MarjanPl, We are, indeed, planning to support multiple XR/AR/VP platforms with our vNext release.
We expect to release an aloha in mid-June, followed by a beta each of the next two months and a full, official release mid-September.
We look forward to your feedback!


When the countdown reaches zero and the time becomes negative, refreshing the page will cause an error in the console

Thank you for the countdown component, it's great. However, there is a bug. When the countdown reaches zero and the time becomes negative, refreshing the page will cause an error in the console:
[Vue warn]: Invalid prop: custom validator check failed for prop "time".

However, I can set props time to 0 when it is less than 0.

Hi @popdo,
Thank you for your contribution.
I believe negative counting is not a bug; it can be useful in some cases, but perhaps we should control it with a prop, like negative-allowed or something similar.
Additionally, we should fix the warning as well.
Stay tuned, I'll inform you when we publish a fix for that.
Thanks

@popdo hi,
Is it possible to share how are you setting the countdown as negative. I'm working on negative counting as a feature right now, I need the possible usage examples, It would be good if I can see your code as example.
Thanks


Adds 'spo tenant applicationcustomizer get' command. Closes #4243

Adds spo tenant applicationcustomizer get command. Closes #4243

Can someone please advise me on failing test retrieves tenant app catalog url ?
@milanholemans @Adam-it any suggestions for me please.

Have you tried debugging the test? Stepping through the code should give you an idea about what's going on

I debugged the test. However, unable tp get how getSpoUrl is getting called.

Ready for review 😊

Ready for review 😊

Oh sorry @nanddeepn for the late reply. Today I took a coding off (family time) kind of day 🙂, but I see you managed to figure it out, nice 🤩. You rock 👍

Merged manually. Thank you! 👏


How to map in dashboard :(

i want to use o to confirm select in dashboard, is there any ways can reach that? :+1:

sorry, my bad, i mean i want use some customize keymaps only affact in dashboard, such as 'a' to select first item lol.
btw you have a typo in README.me

maybe you mean db.confirm_key ? :)


Added CIF-A api implementations, Added KPI Events for Call Hold and Unhold events

Added CIF-A api implementations, Added KPI Events for Call Hold and Unhold events.
Updated the sample_data_cifv2.zip with the KPI Event records for hold and unhlod scenarios.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: v-gaucha sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


add google search scrape

Scrape added. Please don't close this request, i want to add the elasticsearch api.
You can use this as a guide to create your scrapers.

ElasticAPI retrieval and insetion implemented.
Two questions

[ ] Is the current env variable handling a good solution? Maybe i should add this to the make commands?
[ ] Sometimes when scraping google, it gets stuck on the second page for 60s. Not huge problem but not perfect nonetheless...

Should I add logging and unit tests?

how tf did the test pass with selenium????? anyway, logging, tests and typing added pls review

implemented feedback


Update Client Deps

Description
This regenerates the client lock file.
Regenerating the workspace lock file helps detect issues where our dependency specifications are incorrect, as well as provides a way to update our deps to what a customer would get when creating a new project which helps us test more realistic usage.
This found an issue where we have a patch to API extractor, but don't pin the version, so if it gets updated, we can pull in that update breaking the patch. This change pins the version to match the patch since the updates to not include the fix we are patching.
rm ./pnpm-lock.yaml
rm -r ./node_modules/
pnpm install --no-frozen-lockfile

Reviewer Guidance
The review process is outlined on this wiki page.
Questions:

Is this a good thing to do now? It made less of an impact than I expected: often we accumulate a ton do duplicated versions and doing this shrinks the install a lot, but it only shrunk a bit this time.

Looks like syncpack objects to me setting an override to pin the api extractor version. I guess I need to update the dep in every package instead of using an override. Thats harder to document and a much larger change, but maybe better.


Performance metrics

What metrics do you recommend to evaluate the performance of the solver?
In my research team, we are trying to compare the performance of a model in clingo asp vs max-sat

Maybe do it the same way as in the MaxSAT evaluations?

Thanks for the quick reply, I'll take a look at it.
Using the classic metrics (num vars, num clauses, num decisions, num conflicts) we have not reached conclusive results, so we are evaluating other options.

Thanks for the quick reply, I'll take a look at it.
Using the classic metrics (num vars, num clauses, num decisions, num conflicts) we have not reached conclusive results, so we are evaluating other options.

Problem statistics can of course be correlated to solver performance but I do not see what this has to do with the performance evaluation of solvers?

My question is precisely about the quality of the solution, I have surely explained myself wrong.
We have 2 encodes for a problem that we have evaluated in ASP clingo and Max-Sat, encode 1 has a better performance in Clingo and encode 2 in Max-Sat (encodes differ in a couple of restrictions). So we are trying to understand why? We think they may differ in the way they propagate or in the way constraints are represented internally in each solver.
Using the classic metrics (num vars, num clauses, num decisions, num conflicts) we have not reached conclusive results.
For this reason, we would like to know if there is any extra metric, from those available in the statistics of the solution, that we can obtain, or how we could evaluate it with the available statistics.
Thanks again for the help

I see. I think it is difficult to compare just using the statistics. There are things like model level, backjumps, number of choices, which might give some idea about the propagation. Otherwise, it might be a good idea to look at the encoding and think about which one allows for stronger propagation.

It may also help to translate the Maxsat encoding to ASP to spot differences and similarities. And also use clingo to solve the other encoding to rule out differences in the solver.

We just did this, but the statistics of the solution do not show significant variations. That is why we believe that the difference may be in the propagation or the internal representation.
We were hoping that there would be a method that would allow further debugging of the resolution.
As extra information, we are modeling a variant of the MAPF problem (Multi-Agent Path Finding), with which we achieve a breakthrough in the state of the art (conference paper in proceedings).
Now, we are looking at the difference in performance, and we find that the classic metrics are not significantly different from previous models.

@rilopez3 I don't pretend to understand this conversation as it is not clear to me how the solver's general metrics can tell you useful information about the solution quality; since it seems like solution quality is inherently domain specific. But I'd be interested if you have a pointer to your conference paper (or a prerelease/arXiv version). Cheers.

We just did this, but the statistics of the solution do not show significant variations. That is why we believe that the difference may be in the propagation or the internal representation.

This is too vague to say anything more. We do not even know what you are actually comparing. For example, we do not know if you can solve the problems optimally or you just get sub-optimal solutions.

Hi, I'm a co-author of the work. We have two ASP encodings for the MAPF problem. Both solve the problem optimally, but the latest one clearly outperforms the first one and we would like to go into deep into why the latest encoding works so well. In SAT, we would analyze things like the number of decisions per variable, the number of propagations per decision, number of propagations per second or explore further metrics of the search, in order to identify if the reason for our results is related to the quality of the search. Of course, we would also like to compare the size of the encodings. Is there any specification of the meaning of the stats the solver can provide?

Hi, I'm a co-author of the work. We have two ASP encodings for the MAPF problem. Both solve the problem optimally, but the latest one clearly outperforms the first one and we would like to go into deep into why the latest encoding works so well. In SAT, we would analyze things like the number of decisions per variable, the number of propagations per decision, number of propagations per second or explore further metrics of the search, in order to identify if the reason for our results is related to the quality of the search.

Interesting because this is not how we usually do it. Instead we typically start from a basic encoding and then optimize it step by step benchmarking the effects.
I think we do not have the statistics you are asking for available. I am not sure if this helps but we also have Minisat-like progress information, which can be enabled with option -V3. @BenKaufmann might be able to tell you more.

Of course, we would also like to compare the size of the encodings.

For this, the Variables and Constraints in the statistics output are probably a good idea.

Is there any specification of the meaning of the stats the solver can provide?

I am not aware that we ever published a detailed description.

@BenKaufmann might be able to tell you more.

I can't unfortunately. What is printed via --stats -V3 (or stats=2 -V3 if multi-threading is enabled) is all there is. An outdated (but still somewhat helpful) descirption of the statistics can be found in the mailing list archive. As one can see, there is nothing like "number of decisions per variable" or "number of propagations per decision/second" but one could try to approximate some information via Choices to Conflicts ratio and the solving time.
Anyhow, I would probably play around with clingo/clasp's basic search/optimization configurations and then have a look at search statistics, in particular, Choices, Conflicts, Restarts, and number/size of learnt Lemmas.

Thank you very much.
Just one last question. Can we make the equivalence of clingo Choices to,
what we call, in SAT-solvers, Decisions?
El sáb, 10 jul 2021 a las 11:25, Benjamin Kaufmann (<
@.***>) escribió:

@BenKaufmann https://github.com/BenKaufmann might be able to tell you
more.
I can't unfortunately. What is printed via --stats -V3 (or stats=2 -V3 if
multi-threading is enabled) is all there is. An outdated (but still
somewhat helpful) descirption of the statistics can be found in the mailing
list archive
https://sourceforge.net/p/potassco/mailman/message/30518330/. As one
can see, there is nothing like "number of decisions per variable" or
"number of propagations per decision/second" but one could try to
approximate some information via Choices to Conflicts ratio and the
solving time.
Anyhow, I would probably play around with clingo/clasp's basic
search/optimization configurations and then have a look at search
statistics, in particular, Choices, Conflicts, Restarts, and number/size
of learnt Lemmas.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/potassco/clingo/issues/319#issuecomment-877655300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKUFKQKKPFCX3CLCFUKN5TTXBQ65ANCNFSM47R6YDBQ
.

Just one last question. Can we make the equivalence of clingo Choices to, what we call, in SAT-solvers, Decisions?

Yes, it's the same.


Fix (issue #3189) "COMPOSER_AUTH" bug

As described here:

https://github.com/laradock/laradock/issues/3189

fixed the use of COMPOSER_AUTH environment that is a reserved by composer.

This PR was included and merged into PR:

https://github.com/laradock/laradock/pull/3194

close


intro-to-feign seems to have minor json serialize bug

curl http://localhost:8081/api/books
returns
[
{
"book": {
"isbn": "1447264533",
"author": "Margaret Mitchell",
"title": "Gone with the Wind",
"synopsis": null,
"language": null
},
"links": [
{
"rel": "self",
"href": "http://localhost:8081/api/books/1447264533"
}
]
},
...
}
curl http://localhost:8081/api/books/1447264533
returns
{
"book": {
"isbn": "1447264533",
"author": "Margaret Mitchell",
"title": "Gone with the Wind",
"synopsis": null,
"language": null
},
"_links": {
"self": {
"href": "http://localhost:8081/api/books/1447264533"
},
"add-to-cart": {
"href": "http://localhost:8081/api/cart"
}
}
}
see the difference between  "links": [     and  "_links": {  ?
the "_links": { .. }  part with an underscore coming in before "link" seems messed up, and expected an array, not an object

Thanks, Loredana!
you led me to https://sookocheff.com/post/api/on-choosing-a-hypermedia-format/ and then I see

Cool, closing.


typescript has different types for the same variable in the same scope

value here has two different types.
one is string and the other is string | string[]
function getValue(value: string | (()=>string)):void{}

function test(value: string | string[]): void{

 if(value instanceof Array){
   return
 }

  // commenting out this line resolve the issue, but I don't know why?
  // TS consider `value` here as string | string[], but it should be string only
  value = 'string'

  // `value` here is string
  getValue(value)

  // but here is string | string[]
  getValue(()=>value)
}

play

Please respect the issue templates for bug reports. This will help the TypeScript team to quickly get an overview of your issue.
This is due to #9998.

thank you @RyanCavanaugh for responding.
as you added the label "duplicate", please mention the duplicated issue !!

as you added the label "duplicate", please mention the duplicated issue !!

That really is #9998.


CUSTOM_ELEMENTS_SCHEMA is ignored for WebComponents

We are trying to use the modern MockBuilder to mock a component and its module.
The component makes use of WebComponents (developed via StencilJS).
When trying to add the CUSTOM_ELEMENTS_SCHEMA token with the method beforeCompileComponents, I still have the error in the console that the CUSTOM_ELEMENTS_SCHEMA token should be defined.
There is how to reproduce the issue : https://stackblitz.com/edit/github-yynxfc?file=src%2Ftest.spec.ts (the error appears in the console).

When using the classic way of doing things (via TestBed), I don't have any issue : https://stackblitz.com/edit/github-yzyftf?file=src%2Ftest.spec.ts
Any idea of what I might be doing wrong ?

Hi @MatthieuNarcisi,
thank you for the report.
Do I understand correctly that you don't import custom-component anywhere in your app?
@NgModule({
  imports: [CommonModule],
  declarations: [TargetComponent],
  schemas: [CUSTOM_ELEMENTS_SCHEMA],
})
class TargetModule {}

I found out that it will work like that, but not sure if it's something what would suite you.

Hi, thank you. It is exactly that, as custom-component is a WebComponent, it cannot be imported as an Angular component or part of a module (as stated in the second point of the error message).
I will try the build tomorrow and give you feedback as soon as possible.

Hi @satanTime,
Getting back to you, I could test the zip you provided me today and it is working perfectly.
Thank you for all your outstanding work !

Great. I'll release it asap.


Fix builds - Using github Actions instead of AppVeyor?

@cezarypiatek What do you think about this idea?
Latest builds are failing if we want to fix them then why not to keep everything in one place (code + build pipelines in github)?

I was trying to implement this but I failed :)


dm/push-tests-refact

Codecov Report

:exclamation: No coverage uploaded for pull request base (dm/config-refactor@55bb73a). Click here to learn what that means.
The diff coverage is 52.44%.

@@                  Coverage Diff                  @@
##             dm/config-refactor     #188   +/-   ##
=====================================================
  Coverage                      ?   75.87%
=====================================================
  Files                         ?       33
  Lines                         ?     1828
  Branches                      ?      199
=====================================================
  Hits                          ?     1387
  Misses                        ?      396
  Partials                      ?       45

Fun fact: global coverage has decreased as show by codecov.io, but if you look at the diff: https://codecov.io/gh/TankerHQ/tsrc/pull/188/changes you can see that new lines miss only come from the interface and "humble objects" that were added.
The coverage of the production code did not change at all :)


[5.5] Add whereAll and whereAny query builder methods

whereAny adds a nested where clause matching value against any of given columns
whereAll adds a basic where clause to all given columns
where calls whereAll method when at least two params is given and the first being an array

Examples
whereAny
User::whereAny(['email', 'secondary_email'], 'like', '%.com');

User::where(function ($query) {
    $query->where('email', 'like', '%.com')
          ->orWhere('secondary_email', 'like', '%.com');
});

whereAll
User::where(['type_1', 'type_2'], 1);

User::whereAll(['type_1', 'type_2'], 1);

User::where('type_1', 1)
    ->where('type_2', 1);

No plans to add this right now.


[in_app_purchase] iOS Swift migration

Please refer to this umbrella issue for more details.
This plugin is pretty well componentized. The main complexity is in InAppPurchasePlugin.
Pretty high unit test coverage. Will need minor test backfilling.
This is also a good plugin to prioritize, since migrating it to Swift means we can take advantage of the new features in StoreKit2 (which only supports Swift). More details on StoreKit2 can be found here.
Please don't forget to backfill tests to reduce the risk of regression, as explained in the wiki.

Test backfill is complete https://github.com/flutter/packages/pull/6209

The main InAppPurchasePlugin class was migrated in 0.3.16 https://github.com/flutter/packages/pull/6561.

@LouiseHsu do you have any intention of migrating the rest of the package you haven't already written in Swift, or should this be unassigned?

@LouiseHsu do you have any intention of migrating the rest of the package you haven't already written in Swift, or should this be unassigned?

That's a good question - the intention behind migrating the original package to swift was to make it easier to maintain - before they announced the old API would be deprecated. I probably wouldn't migrate the rest of the package because that could just introduce potential new bugs for no real advantage. I'm at least going to unassign myself but maybe we could consider closing this issue completely.


Update link to new Write a Loader doc

Reading up on loaders, I noticed a broken link toward the bottom of https://webpack.js.org/concepts#loaders to an old "How to write a loader?" article. I think https://webpack.js.org/contribute/writing-a-loader is the most up to date doc on this. Updated href and link name.

Thanks!


.NET 6.0 Source-build instructions

There should be easily accessible instructions for building .NET 6.0 from source in the dotnet/installer readme.
The instructions should address everything you need to build .NET from source, including dependencies. Ideally, this would be something we can point Linux distros and package maintainers to for instructions on how to build .NET for their distro.

Hey, @alucryd @loqs @cerebrate @directhex , what documentation would you find helpful?
From my point of view, as a maintain for .NET in Fedora, a doc that covers the following would be useful to have:

Where can I find the latest releases?
Where can I find the source code for latest releases?
How do I build those releases? What dependencies are required?
Can I bootstrap .NET (so it doesn't download anything at build time but only uses things I have already on disk)? If so, how?
What architectures can I build .NET on? How do I do that for anything non-x64?
What are the suggested packages names and their contents? What should the dependencies between packages look like? (Distros are free to deviate, but source-build can make suggestions).

@omajid That's pretty much what I would ask for, thanks for making this list. Speaking from past experience, compatibility with nspawn and capability needs (if any) would be nice to have as well, this was troublesome in the 2.x era. And the dependency version information as well, minimum and/or maximum version, like how the current dotnet releases don't work with lttng-ust >= 2.13.0.

Also what about OS'es that are not supported atm? Like for example, FreeBSD, we're able to crosscompile working SDK, then native build SDK using that as bootstrap - would it be possible to use the same path using source-build? I've tried that, but at some stage it was missing runtime's nupkg specific for FreeBSD - any info how to also include those into tarball for offline build would be nice for ex. :)

FYI, I tried building 6.0 using the instructions on the installer repository, and it fails during the runtime compilation, the errors seem to stem from error MSB4018: System.MissingMethodException: Method not found: 'Int32 Microsoft.CodeAnalysis.ISymbol.get_MetadataToken()'.

Disabling package validation allowed it to progress further, but it still crashed after an hour and a half of compilation... Segfault while building aspnetcore. @omajid can you get past aspnetcore on fedora?

On Fedora 34, the build works end to end. On 35, my builds are hanging (not crashing, just hanging) while trying to build aspnetcore. The actual hang appears to be in the crossgen process.

Got it. What versions of lttng-ust do you have on 34 vs 35? Wondering if that's the culprit, I'll try to create a lttng-ust2.12 compat package here.

Fedora 34 is lttng-ust-2.12.0-4.fc34.x86_64. Fedora 35 is lttng-ust-2.12.2-5.fc35.x86_64.
If it's really lttng, perhaps a export COMPlus_LTTng=0 will workaround the issue? It disables loading lttng at runtime.

Ah that could be a solution indeed, I'll give it a try later. For now I built 2.12.0 and the dotnet build is almost 2 hours in, way past aspnetcore so fingers crossed.
Hopefully COMPlus_LTTng does allow it to build with/against regular lttng-ust here, and when bootstrapping 6.0 with our own dotnet is a thing, I'll be able to get rid of the compat lttng-ust.

I was expecting to find a 6.0.0 tag in this repository which the Homebrew dotnet formula could be updated to point to. But the 6.0.0 tag is nowhere to be found, so now I'm wondering what's required to build .NET 6 on macOS and Linux so the Homebrew formula can be upgraded?

@asbjornu see the README: https://github.com/dotnet/source-build#building. You want to use the tag in the installer repo.

asbjornu - Starting in 6.0, source-build is going to be produced from dotnet/installer.  You can use the 6.0.101 tag to build .NET 6 from.  You can refer to the building instructions.

Does this mean I have to repeat the multi-week effort that went into https://github.com/Homebrew/homebrew-core/pull/60929? What are the big differences between building the source-build and installer repositories?

The major difference is that the two-stage build is no longer required.  Instead of build-source-tarball.sh in source-build doing a complete build and then generating the tarball to do the real build from, you can do ./build.sh /p:ArcadeBuildTarball=true from installer to do a short build that produces the buildable tarball.  From there the process works the same way.  Moving into installer also helps us get updates as the same time as the Microsoft builds do, so we can turn those around faster as well.

@asbjornu

What are the big differences between building the source-build and installer repositories?

For .NET Core 3.1 and .NET 5, you need to use the appropriate branch of the source-build repo to build .NET from source. For .NET 6, you need to use installer repo to build from source.
Perhaps it helps if you just treat it as if the build system moved from source-build to installer for .NET 6.0?
@crummel 's reply goes into detail on why we made the changes and what the details of the change are, but if you are looking to consume .NET 6, the short version is that you need to use the installer repo; the source-build repo simply doesn't build .NET anymore.

@alucryd export COMPlus_LTTng=0 did not fix my issues :(

@alucryd export COMPlus_LTTng=0 did not fix my issues :(

Meh, that's too bad. Do you have a way to force lttng-ust to 2.12.0 on 35?
The build succeeded with 2.12.0 here, I'll give 2.12.2 a try later then so we can confirm whether it's the culprit.

@omajid Oh well, our clang was updated to 13 yesterday, which caused a lot of build errors in the runtime. Unlike what the readme seems to indicate, EXTRA_CFLAGS are not respected at all and I had to patch quite a few CMake files to add the various -Wno- flags.
Now I'm faced with the same error as you, and I'm pretty sure the only difference compared to the day before yesterday is the clang update. I see you have a clang12 package in fedora 35, did you try building with that one?

Thanks for the pointers, @alucryd !
https://github.com/dotnet/runtime/pull/61442 should fix the -Werror issues. It was a release oversight, I think.
Thanks for the tip on clang 12 vs 13. Looking at Fedora 35, we have a compatiblity package for clang 12 - there are libraries, but not the actual compiler itself. I am going to build llvm/clang 12 from source and see if that works.

asbjornu - Starting in 6.0, source-build is going to be produced from dotnet/installer. You can use the 6.0.101 tag to build .NET 6 from. You can refer to the building instructions.

Excuse me, looks like a typo - the link is to the tag/v6.0.100, but the text is 6.0.101. 101 is inaccessible without credentials:
Username for 'https://dev.azure.com':
Password for 'https://dev.azure.com':

@DmitryJustDmitry, thanks for providing that essential piece of information! With version 6.0.101 I got stuck on the missing credentials as described in https://github.com/dotnet/installer/issues/12871#issuecomment-998350794, but with version 6.0.100 everything builds successfully and I've managed to submit https://github.com/Homebrew/homebrew-core/pull/92991 to Homebrew.

AFAIK, the 6.0.101 release accidentally included some non-public URLs. It might be worth trying to apply https://github.com/dotnet/installer/pull/12852 on the local checkout of 6.0.101 to see if that fixes it.

@omajid, thanks, but if 6.0.100 passes, I think we'll just await a new public release that works without any patches applied.

Alas, 6.0.100 does not work either. As I write in https://github.com/dotnet/installer/issues/12871#issuecomment-1011523265, source-build-reference-packages fails. 😕

Coming back to this, I think we should update dotnet/installer's readme to point to the dotnet/source-build readme for instructions on how to build source build. The installer readme's instructions aren't the most up-to-date. Either that or we should move all the instructions to installer and point to them from source-build. The current set of instructions we have are different between the repos. This goes for main and supported release/6.0.xxx branches.


GPT 3.5?

Not a hater... But you definitely need to be more clear on what this is.
This is just a fancy system prompt and a call to OpenAI... And not even the good model.

I 100% agree with you. But what you are representing this as, is not what it is. It's an API wrapper with a fancy system prompt.... Nothing more. Neat. For sure. Good job on it. But you need to be clear with users on what this actually is.
I've built tools just like this. One for fishing. One for Bitcoin price data. One for writing tweets. But none of them use any unique or foundational components. Just off the shelf libraries and APIs.
Now, if you would take a suggestion. Package this with Ollama and instruct users on how to implement that. They even have a pypi package to make it easy.
Again. Not hating... Just making sure things are properly represented.

That's a nice idea! I'm already planning to add more modes. However, there's an issue with Ollama that it requires significant compute power and a GPU, which not everyone has access to, including myself. I rely on the cloud for these tasks, and this poses a challenge for implementing local models.


Travis CI - compile under clang

Clang is better than gcc
We need to support it on CI service

ping @ovr

Implemented in the master branch


fix: broken betterbird download links

According to https://www.betterbird.eu/downloads/index.php, build3 will be available 27 Nov. 2024.
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Seems that Betterbird hasn't released the new installers yet. I will update once they do.

URL:
Invalid URI: The hostname could not be parsed.
(Automated message - build 899)

Seems that Betterbird hasn't released the new installers yet. I will update once they do.

Just browsing here with no deeper knowledge, but it seems to me that build3 is only available for Linux:
"Linux Version 115.18.0-bb36 replaced with "build 3" on 27 November 2024 due to an incorrect build date."

@wingetbot run


Refactor js code to integrate Flux Alt

@justin808 Please review. This PR contains the Flux Alt refactoring on top of the latest master. One commit.
I'll close and delete the previous feature/flux_integration branch.
Note that the alt library does not get installed by npm install although it is defined in package.json. I suspect there is a dependency conflict somewhere, although I would expect npm to error out. I didn't get a chance to investigate so for now I'm installing it manually cd client && npm install alt.

@justin808 Lint errors have been addressed. Also updated the npm shrinkwrap. Let me know if you want to merge. Thanks.

LGTM


Fix missing coverage in test_automl_iterative_algorithm.py

This issue tracks fixing the missing coverage in the following tests:
1. test_describe_pipeline_with_ensembling_iterative
2. test_pipeline_custom_hyperparameters_make_pipeline_iterative
3. test_automl_respects_pipeline_custom_hyperparameters_with_duplicate_components_iterative

Context:
Checking code cov its apparent that this coverage is missing on main as well . One can look at the link and search up the test without the _iterative tag such as test_describe_pipeline_with_ensembling here.
Originally posted by @jeremyliweishih in https://github.com/alteryx/evalml/pull/3261#r794752783

Closing since fixed in #3261.


Add Citrix

The icon I want is:

Name: Citrix
URL: https://www.citrix.com
Link to icon: https://www.citrix.com/en-gb/news/media-resources.html

Here's there social media icon - https://twitter.com/citrix/photo

Isn't this the same as this or this except the circle around it? :thinking:

Yes. Sorry, that's what I was trying to say.


capture if the user click on the ads

I'm trying to prevent if someone click bomb the ads, and I want to throttle how often I show interstitial ads if someone clicked the ads
currently there is no listener that I can hook into to get if the user clicked the content, looking at stackoverflow I noticed that is possible
https://stackoverflow.com/questions/53849521/how-to-detect-admob-interstitial-ads-is-clicked-by-user
but currently isn't part of the current plugin functionality. it will be really helpful to create a new listener for that purpose

@mhamri  Thanks for issue. I have looked for this iOS version but could not find it. Since it is multi-platform, it must work on both iOS and Android, can you find a method for iOS?

Closed due inactivity


ENH: Add base branch checker for new PR

To address astropy/astropy#9385

Codecov Report

Merging #92 into master will increase coverage by 0.56%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   82.08%   82.64%   +0.56%
==========================================
  Files          17       18       +1
  Lines         865      876      +11
==========================================
+ Hits          710      724      +14
+ Misses        155      152       -3

Impacted Files
Coverage Δ

...ldrick/plugins/github_pull_requests_base_branch.py
90.9% <90.9%> (ø)

baldrick/plugins/github_pull_requests.py
85.5% <0%> (+5.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f592c28...ee69a7c. Read the comment docs.

@pllim - I don't know the API enough to review this, but the the gist of it as far as I see is indeed what I wanted to see as the feature :)

Sometimes it's legit to open a PR against non master.

Oh, then maybe we also need to check if some "skip base branch check" label (or something like that) exists, so we can skip this check? @bsipocz , do you have a preferred name for such a label?

I don't have preferences (and honestly, as the first draft, I'm happy to leave such PRs with the failing check, e.g. we would notice easily that something is not OK, but then can decide that it's actually deliberate). I would guess the rate is somewhere between 1-3PR/100PRs.

(But it'll be less now, that we don't have a separate bugfix and much dated LTS branch)

I don't understand why the tests are passing, LoL. I thought this one would fail because I forgot to update it after changing the behavior to only post status on failure:
    def test_good_base(self, app):
        self.pr_handler.base_branch = 'master'

        with app.app_context():
            sta = check_base_branch(self.pr_handler, self.repo_handler)

        sta['basebranch']['state'] == 'success'

anything else that needs doing here?

I don't remember... This was opened almost a year ago. 😬

Codecov Report

Merging #92 into master will increase coverage by 0.26%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   82.34%   82.61%   +0.26%
==========================================
  Files          17       18       +1
  Lines         912      926      +14
==========================================
+ Hits          751      765      +14
  Misses        161      161

Impacted Files
Coverage Δ

...ldrick/plugins/github_pull_requests_base_branch.py
71.42% <71.42%> (ø)

baldrick/plugins/github_pull_requests.py
87.91% <0.00%> (+4.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116546d...f96c3f2. Read the comment docs.

Feel free to test it out before putting it in production.


Files upload

Hello @reem, have you already thought about support of file uploads with multipart/form-data? Maybe you have some ideas how it can be implemented the best way.
It looks like @cybergeek94 already made multipart library for Hyper, but he has some issues with Iron integration. What do you think about it?

I haven't been maintaining multipart lately due to lack of interest but I definitely wouldn't mind it becoming a component of Iron.
The main issue is that Iron provides the request body to its middleware as Vec<u8> which is kind of a bad idea if you want to support large request bodies, such as with file uploads. I shared some ideas in a Reddit discussion a while back but I don't know if anything came of that.

It's possible that Request could be changed to allow streaming of the input data. I've thought about it and the issues that come up with direct Response streaming aren't really an issue for Request, since there is only one state (i.e. no "status line written", "headers written", "nothing written" etc.).
The major issue I anticipate is that this makes testing a bit trickier, but from my memory of the internals of Hyper I think it's actually pretty easy to mock an HttpWriter with whatever data you want. This also has the side-effect of making Request no longer 'static or Send (since HttpWriter is given to us by Hyper with a lifetime), which can be a pain.

I can take a crack at making this change tomorrow, but it's not too complex a change and probably interesting if either of you wants to give it a try first.

We now allow streaming the request body, so Iron should now be able to support this use case well.


to text

Is it possible to map the hexcode to some human text ?
red , green , blue ..

Well it's possible but I think it's outside the scope.


Mistake in the English translation

It seems there is a mistake in the english translation under "FILE_MISSING:"
It says "There is a problem with this content. It seems you removed the associated video file from it.. Share this with your friends to have a synchronized watching experience with them!"

Thanks!

There is a pre-release, if you want to test it

I believe it should be fixed now :)


Bugfix/event section padding mobile

Changes
This PR solves #38
-Replaced text with SVGs to improve responsiveness

Changed padding of the parent of tab component from p-1 to px-1

Before Change:

After Change:

It seems there is a unupdated contributor list on your side. Have you pull latest changes from main branch

My forked repo was not synced, sorry for that. I fixed it

Congratulations on your @Aadithapa456 for contribution in GNOME Nepal.
Thanks for the PR

Thank you for your guidance @utsavdotdev


Regarding the results of SACN mentioned in your paper

Hello, I want to ask about the results of SACN mentioned in your paper. Have you reproduced it? If it does, can you share your parameter settings? I searched a lot of information and tried to reproduce the results mentioned by the author in the paper, but they were far from reaching these results. Looking forward for your response, thank you!

Hi @xjzhao001,
We also tried our best but could not reproduce SACN results. In the results, we have taken values directly from their paper.
Thanks and regards,


Close SQLAlchemy engine after querying DB

[x] Tests ~added~ / passed

None added as this shouldn't affect the functionality of dask - open to challenge on this!

[x] Passes black dask / flake8 dask

Per the pandas issue https://github.com/pandas-dev/pandas/issues/23086, users/code that creates a SQLAlchemy engine to pull data is also responsible for closing/disposing of it; failure to do so leaves the engine and all connections it has in the connection pool hanging around until garbage collected.
This is sub-optimal as it means the database will have some of its precious resources locked without actually being used.
This PR explicitly calls engine.dispose() in both functions that generate an engine.
Fixes https://github.com/dask/dask/issues/5623

I'm reading through https://docs.sqlalchemy.org/en/13/core/connections.html#engine-disposal, and it's not clear to me whether this is necessary / advisable.

When an Engine is garbage collected, its connection pool is no longer referred to by that Engine, and assuming none of its connections are still checked out, the pool and its connections will also be garbage collected, which has the effect of closing out the actual database connections as well.

Since we're creating these engines within the function, aren't they going to be garbage collected normally?

In my experience using it, they hang around for quite a long time before being garbage collected.
I think this PR's use case is accepted by the SQLAlchemy docs:

However, there are many cases where it is desirable that all connection resources referred to by the Engine be completely closed out. It’s generally not a good idea to rely on Python garbage collection for this to occur for these cases; instead, the Engine can be explicitly disposed using the Engine.dispose() method. This disposes of the engine’s underlying connection pool and replaces it with a new one that’s empty. Provided that the Engine is discarded at this point and no longer used, all checked-in connections which it refers to will also be fully closed.

Hi @TomAugspurger,
Given how Dask creates & uses many short-lived engines, is this good to be merged?

Thanks for following up. The docs you provided do seem to fit our usage pattern here.
Thanks!


Feature Request: Ability to override check names in check config

If I understand things correctly currently the only way to specify a name for a check is as the key in the checks hash:
{
  "checks": {
    "some-check": {
      "type": "standard",
      "host": "some-host",
      "command": "some-command"
    }
  }
}

This will result in a check called some-host/come-check.  This is fine if the check name is unique, however in our infrastructure we schedule per host, which results in hundreds of duplicate check names.  Take, for example, DNS, which we define for every host in our infrastructure:
{
  "checks": {
    "dns": {
      "type": "standard",
      "host": "some-host",
      "command": "check-dns"
    },
    "dns": {
      "type": "standard",
      "host": "some-other-host",
      "command": "check-dns"
    },
    "dns": {
      "type": "standard",
      "host": "some-third-host",
      "command": "check-dns"
    }
  }
}

That is, of course, illegal as you can't have 3 blocks under the same key.
My workaround thus far has been to prefix the name with the host:
{
  "checks": {
    "some-host-dns": {
      "type": "standard",
      "host": "some-host",
      "command": "check-dns"
    },
    "some-other-host-dns": {
      "type": "standard",
      "host": "some-other-host",
      "command": "check-dns"
    },
    "some-third-host-dns": {
      "type": "standard",
      "host": "some-third-host",
      "command": "check-dns"
    }
  }
}

This is 100% functional but a little unweildly as I then wind up with checks named some-host/some-host-dns instead of some-host/dns which would be preferred.
So, what I would like to see is the ability to set the check name as an override in the hash, so that uniqueness of the keys can be maintained:
{
  "checks": {
    "some-host-dns": {
      "name": "dns",
      "type": "standard",
      "host": "some-host",
      "command": "check-dns"
    },
    "some-other-host-dns": {
      "name": "dns",
      "type": "standard",
      "host": "some-other-host",
      "command": "check-dns"
    },
    "some-third-host-dns": {
      "name": "dns",
      "type": "standard",
      "host": "some-third-host",
      "command": "check-dns"
    }
  }
}

This will result in the checks being named [host]/[name], which is much more user-friendly, while allowing me to set appropriately unique keys.
I looked over the 0.26 docs (which I am running) but didn't see an existing solution for this.  It seems like Sensu is mature enough that this should already be solved, so apologies if I missed it in the docs.

I may not fully understand the issue/problem that you are experiencing, creating/using unique check names is not hard. I believe this will cause more confusion when introducing Sensu configuration to new users and creates unnecessary code complexity.
@CVTJNII thank you for taking the time to put together this issue. I am going to close it, as it is not something that we are interested in pursuing.

So what is the recommended naming for a check that runs on 2000 hosts?  My solution is clunky.

is there a way we can dynamically update the check name based on a result ? i have a check-couch-base-bucket cluster check running , which checks for all the buckets and then get me results for all buclkets configured , so in my case if any bucket fails i get a result that check-couchbase-bucket-quota has failed ,
i would exepect sensu to update a check name based on sensu result


Tip: How to get even frequency response on bad speakers

I just wanted to share this tip.
With terrible speakers, like the internal speakers on my ancient MacBook Pro 2012, start by trying to get a flat response. That means subjectively hearing equal volume for tones in each band. I used this site to generate tones: https://www.szynalski.com/tone-generator/
I started at 125 Hz, then hit the [x2] button to skip directly to 250 Hz, 500 Hz, 1 kHz, 2 kHz, etc., and the [x1/2] to skip backwards, incrementally adjusting the sliders in eqMac until the volume of each tone seemed as equal as possible. Those [x2] and [x1/2] buttons make it really easy to focus on the right frequencies.
On poor speakers, you may find lower frequencies inaudible no matter what, so cutting those bands can decrease distortion.
That's it.
I'm attaching what that looks like on the terrible internal speakers of my MacBook Pro 2012. This might look like too extreme of an adjustment, but these speakers really are that bad.

Actual feature enhancement suggestion:
Turn the band labels (... 250, 500, 1K ...) into clickable buttons that generate tones at those frequencies

Hey thanks for sharing this. But this is not really an Issue so I think it should live here: https://github.com/bitgapp/eqMac/discussions
I will close this issue but feel free to repost it there


✨ Create OG image for Twitter

The currrent web page does not have a Twitter OG image.
We would like to fix it, so that we can share the link on Twitter.

seems like Twitter under Elon is really not going well 😛  https://twittercommunity.com/t/card-validator-preview-removal/175006
once the twit is published it shows as expected


I35 preserve order of columns when writing out to excel

implements #35

@JIMENOFONSECA, actually, only the list in globalvars.py will need to be changed. The results_to_csv function will eventually be refactored to use the tsd variable and just pick out the columns that need to be written out.
I personally think this is a safe change to make. At the same time, I don't really care for the order of the columns in the output. I do think that for the user, it increases the usability of the software!

@daren-thomas @martin-mosteiro cool, so if the tds repalces the entire list. The change seems ok. Would you take a look at the case of the Tww_tank_C? so i can take a look again?
The issue is that the list in globalvar.py and thermal_loads.py do not match

@JIMENOFONSECA: sure. I removed Tww_tank_C as requested. What list in thermal_loads.py?

Sorry i meant the demand script...
thanks for the change..

From: Daren Thomas<EMAIL_ADDRESS>Sent: Tuesday, August 30, 2016 4:50 PM
To: architecture-building-systems/CEAforArcGIS
Cc: Jimeno Fonseca; Mention
Subject: Re: [architecture-building-systems/CEAforArcGIS] I35 preserve order of columns when writing out to excel (#325)
@JIMENOFONSECAhttps://github.com/JIMENOFONSECA: sure. I removed Tww_tank_C as requested. What list in thermal_loads.py?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/325#issuecomment-243374625, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrguD4bGtSeY2LWRogwOuk8coxI8c5ks5qk-7WgaJpZM4JvSPM.

@daren-thomas the results plot Tww_C as an empty vector now in the output of demand_main.py

I'll look into it!

@JIMENOFONSECA: I am not quite sure I understand your comment above. What plot?

I have checked outputs\data\demand\Total_demand.csv and could not find that column at all!
I have checked outputs\data\demand\Bau G.csv and could not find that column at all!

What should I be checking?

weird.. I got it in BAU A.csv
On 5 Sep 2016, at 4:07 pm, Daren Thomas <notifications<EMAIL_ADDRESS>wrote:
@JIMENOFONSECAhttps://github.com/JIMENOFONSECA: I am not quite sure I understand your comment above. What plot?

I have checked outputs\data\demand\Total_demand.csv and could not find that column at all!
I have checked outputs\data\demand\Bau G.csv and could not find that column at all!

What should I be checking?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/325#issuecomment-244683842, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgifVx81P3lBGWp6S1Nxkn-jOsZJUks5qm83YgaJpZM4JvSPM.

Tww_C? You sure? I have Trww_C and Tsww_C... both have values in Bau A.csv. I do not have a Tww_c. I just ran the simulation again from master.

sorry i meant Tww_tank_C, Qww_tankloss_kWh (which should not be there btw).
and Epro_kWh.
all of them appear empty...

I have Qww_tankloss_kWh and Epro_kWh but no Tww_tank_C?
I will remove Qww_tankloss_kWh.

weird.. i just run the simulation from the branch and got that....

I have removed Qww_tankloss_kWh and added Eprof_kWh to the output (but it is all zeros - is that correct?)

correct..
On 5 Sep 2016, at 5:25 pm, Daren Thomas <notifications<EMAIL_ADDRESS>wrote:
I have removed Qww_tankloss_kWh and added Eprof_kWh to the output (but it is all zeros - is that correct?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/325#issuecomment-244700869, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgpvJ0WmXKsz5vkcrWjnm0ozfoqJWks5qm-AKgaJpZM4JvSPM.

Tww_tank_C is definitely not part of the output: globalvars.py does not list it in the demand output columns... What file are you looking at?

Bau A.csv
On 5 Sep 2016, at 5:28 pm, Daren Thomas <notifications<EMAIL_ADDRESS>wrote:
Tww_tank_C is definitely not part of the output: globalvars.py does not list it in the demand output columns... What file are you looking at?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/325#issuecomment-244701640, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgoca7SHoNCJ6c8dCtBB7NIt8hthUks5qm-DHgaJpZM4JvSPM.

Please synchronize again, run the demand script and send me the (new) copy of Bau A.csv with the Tww_tank_C column in it. I can't find it here.

working now and merging


Modal cloud training support, fixed typo in toolkit/scheduler.py, Schnell training support for Colab, issue #92 , issue #114

Added peft to requirements.txt since it’s needed for Schnell training. #92
Fixed some missing parameters in the Colab notebook that were in the local config files. #114
Threw in !nvidia-smi at the top of the notebooks to make sure the GPU is being used.
Schnell training notebook for Colab
Fixed typo in toolkit/scheduler.py - Commit: facor -> factor
Training on Modal cloud + setup guide in README.md

Schnell training notebook Colab

Training on Modal

where can i find the schnell training notebook?

Until @jaretburkett merges, you can find it here:
https://github.com/martintomov/ai-toolkit/blob/main/notebooks/FLUX_1_schnell_LoRA_Training.ipynb

I didn't understand at first that I need A100 gpu, but I got it working and lora is good. Thanks martin

Excellent work! Thank you so much! You are killing it with these PRs

Happy to help the project

@martintomov I got it running thanks to you! Appreciate it


ILIKE-based portion of the query for PostgreSQL

I would suggest to include some functions in Query Builder Class to use the PostgreSQL ILIKE extension. Despite not a SQL standard, it is important to generate case-insensitive LIKE expressions in Postgres.
We could add some abstract methods to BaseBuilder.php to be extendend by Postgre/Builder.php. Internal _like() method would need just a little change.

Query Builder is supposed to be as database-independent as possible, so extending it with database-specific functionality probably shouldn't be part of the framework (though I am of the opinion that it should be possible for developers to do so in their application).
On the other hand, this does bring up the question of whether the Builder class for each database platform should be generating different SQL strings to get similar results across platforms in cases like this.

BaseBuilder should only include cross-database methods, IMHO.
The Postgres drivers can extend those, but then a developer would have to know that they are using Postgre\Builder, and not just a BaseBuilder.

As far as I can see (not that much), db-specific Builder is not called anywhere. So, given that we have the property $DBDriver and db-specific Builder extends BaseBuilder, it would make sense for me to change BaseConnection table() method to instantiate the specific Builder for each database. Then, we could add more functionality to Query Builder. It also would be pretty evident when reading table() method code.

The db-specific version is instantiated right in the table() command of the BaseConnection.
The connection class name will be a db-specific class when that method is called. So, for PostgreSQL it would be CodeIgniter\Database\Postgre\Connection. That line replaces Connection with Builder, leaving CodeIgniter\Database\Postgre\Builder.
I agree that we should provide things as cross-platform as possible, and not add in too many platform-specific things, though I know that the MySQL driver has always had a couple of features that seemed to never get implemented in most of the other drivers in the past. Hopefully we can fix that...
In this specific case, I'd be tempted to simply make the case-insensitive version the default. That matches with what you get from MySQL, and seems like it would be the most frequently used case to me, anyway. However, you said it's an extension? Is it not always available?

Ja!, I new I should be wrong. I took $this as the mother, not the child class. Anyway, same family. ;-)
ILIKE is a native extensión, therefore it is always in Postgres instalation; looks like they know they are so "strict". In CI-3, I've being working fine just changing LIKE to ILIKE in Query Builder Class, but don't like it.
 I'm happy to receive such interesting particular lessons.

ILIKE is not available elsewhere, mostly because it would be useless on most other platforms most of the time, but it is always available in PostgreSQL, as Portaflex stated.
The main reasons I would be reluctant to make \Postgre\Builder's like() method use ILIKE instead of LIKE would be:

some LIKE expressions don't need to be case-insensitive
someone familiar with PostgreSQL's implementation of LIKE may write their query for LIKE and get unexpected results due to use of ILIKE

The obvious upside of using ILIKE for like() is that someone unfamiliar with PostgreSQL and/or porting queries from MySQL/MS SQL/Oracle/etc. doesn't have to know that PostgreSQL's LIKE implementation is different. If implemented with ILIKE, it would need to be noted somewhere in the docs for people moving from CI3 and/or those aware of the normal behavior of PostgreSQL's LIKE.

I wonder how many of the other platforms support both case-sensitive and case-insensitive version of LIKE and if it would be worth adding a case-sensitive flag to the like() method, along with noting in the docs which platforms support that. I'm not familiar enough with them, so will have to start reading more docs tonight, I suppose.

A quick look shows that in MySQL, MS SQL Server, and Oracle it depends on configuration, encoding, and collation. In most cases (including PostgreSQL) to guarantee a case-insensitive search you would do something like this:
SELECT {columns} FROM {table} WHERE lower({column}) LIKE lower('AbCd%')

upper and lower functions make a whole column scan, and indexes become useless. It can take much resources in big tables. In most DBs you can set collation different from binary to do case-insensitive comparison. But Postgres has ILIKE, which is unique and wise.
Perhaps we could add a variable $like = 'LIKE' at the end of _like() signature so a iLike() method() in Postgres\Builder could pass 'ILIKE' as last parameter to _like(). In that case, _ilike() would build an ILIKE quiery.
My point is that 99% of functions in Query Builder are MySQL ones. So Postgres deserves that little "ilike". Thanks.

I understand your point, but then we have another dozen engines that want just their little method. And it soon becomes a mess. We'll definitely look into this further and see if there's a way to do it that still makes it simple for those that do support things like this and those that don't.
To be fair - historically PHP and MySQL have been used together much more often than not, and any driver can always do raw where's, whole queries, etc for portions that are not covered by the builder. :)

Ok. Let's move forward. Thanks.

By default, ILIKE does not use an index, either, unless the search criteria begins with non-alphabetic characters. The small amount of information I found on the matter indicated that ILIKE may be slower than lower(...) LIKE lower(...) in most cases. You can install a module (pg_trgm) to add index types which will be used for LIKE and ILIKE queries with better performance than a standard index.
I'm not sure how much MySQL-specific functionality is actually in the Builder. There is a lot of MySQL-specific functionality in the configuration of the database library itself, but the purpose of the Query Builder is to construct SQL queries in a manner which is not platform-specific.
I do have to say that in researching this issue, I was quite surprised that LIKE queries on other platforms may not be case insensitive. I'm guessing that I get very frustrated with it when the issue arises, then forget about it when I don't have to deal with it again for months at a time.

Interesting tidbit I found tonight:

However, AFAICS there isn't any direct notion of "case insensitive LIKE"
in SQL92, so he's going to have to depend on something that's not in
the spec.

What the spec seems to envision is that you get this result by attaching
a case-insensitive collation spec to the column you're going to do the
LIKE on --- in other words, the meaning of "foo LIKE 'bar'" depends on
the charset and collation attributes of the foo column.  If you want
something other than what the column was set up to provide, tough
cookies.

Not overly helpful, of course.

The more I'm reading about things tonight the more complex the issue is to handle correctly, since it all depends on collation of the database/table/column when it was created, and that's only based on the standard. It appears that different databases have different case-sensitive settings. We could hack stuff together to read the collation of the database and change it on the fly, but that gets messy.
My suggestion is we add a fourth parameter to like() that forces a case-insensitive search. Without passing true to it, the LIKE query would be whatever was set for that database/collation. By passing true this would force case-insensitive searches, simply doing the LOWER() conversions. We would need to note that in the docs, though, so that people would know to create their indexes appropriately. Then, in individual drivers if we find a simple solution to forcing case-sensitive, like PostgreSQL, we can implement it there by default.
Thoughts?

I vote yes to Mr. Ezell proposal and will go to prepared queries, a very "hot spot" too. Thanks

Sensible

Forgot to mark it in commit message, but fixed in cce0a43da3c36d778c1343ca69fc342df9dab3d2.


new constants case

In Dart 1, all core library constants were in SCREAMING_CAPS. In Dart 2, they're being changed to camelCase.

Duplicate of #9


feat: theme types

This is great, nice work Han!
However, I think maybe we can push the types even better. Now we have this without type errors:

If you don't mind, I will make some changes and push to this branch directly

If you don't mind, I will make some changes and push to this branch directly
Ok 👍

Updated. This PR now also adds dts tests for types (similar to vue-next). And now the type of Config would be sure that only one level of extend presents and also prevent mixing custom theme and extending the default theme.


Update the curl dependency

This was preventing the tests from building against OpenSSL 1.1, due to
the obsolete dependency to the openssl crate in version 0.7.
Fixes #5.

Thanks!


Add minisim extension

Description

New extension: Allows to control Minisim small app to launch and manage android and ios simulators.
Screencast

https://github.com/raycast/extensions/assets/52801365/8bb8970c-79e3-418b-88fd-9da706c7d009
Checklist

[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder

Could you remove your yarn.lock and add a package-lock instead 🙂

Hey @pernielsentikaer, thanks for reviewing!
I've applied your comments

Could you add metadata images as the last thing 🙂

@pernielsentikaer Done 👍🏻

Great, what are the next steps? Only people with write access can merge PRs 😅


No Input image codecs

No Input image codecs in this article?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0461d82a-d767-3c13-3a31-b501bfea75e2
Version Independent ID: 3aa4cecc-e94b-700a-dd32-9eab6bccd079
Content: Standard Encoder formats and codecs - Azure - Azure Media Services v3
Content Source: articles/media-services/latest/media-encoder-standard-formats.md
Service: media-services
Sub-service: rest-v3
GitHub Login: @IngridAtMicrosoft
Microsoft Alias: inhenkel

@phuongcao1995, Thanks for the feedback! We are taking a look into this and will get back to you soon. In the interim, could you also share more details about your requirement?

Hi @AjayKumar-MSFT, I'm researching Azure Media supported files.  After reading the article,  I think I still don't understand what is containers, video codecs, and audio codes. Which codes are supported by which container? Which containers/file types are compatible with all browsers?
I hope you guys can help me explain them. Thanks.

Apologies for the delay!
If you are just looking to store JPEG or PNG images, you should keep those in Azure Blob Storage. There is no benefit to putting them in your Media Services account unless you want to keep them associated with your Video or Audio Assets. Or if you might have a need to use the images as overlays in the video encoder.  Media Encoder Standard supports overlaying images on top of videos, and that is what it lists JPEG and PNG as supported input formats.
For more information, see
StandardEncoderPreset
How to generate thumbnails using Encoder Standard with REST
 Encoding video and audio with Media Services

How to encode with a custom transform - .NET

phuongcao1995, We will close this out, but if you feel you need more information please just let us know.


@yuki24: Gallery Partnership signup page QA items

This addresses the QA items mentioned in https://github.com/artsy/collector-experience/issues/94#issuecomment-313482097
It might be worth while to pull down this branch and review the issues mentioned in QA if you have a chance.

I have tested this locally on Safari (Mac & iOS), Chrome (Desktop & Android), Firefox and IE (11 & Edge) and IE11 is the only one that doesn're render flexbox.

I'm looking into this now and will send a fix once I figure it out.

It seems like we are hitting this bug and

Looks great @xtina-starr! merging this...

😄 thanks for adding the IE fix and merging @yuki24!!


Hero

Use this issue to discuss the Hero in the ONS Design System

Duplicate issue https://github.com/ONSdigital/design-system/issues/717


Added command to unexport services

This should be more intuitive to users, instead of having them go delete
the ServiceExport CR.
Resolves: #1830
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

One minor thing. @Jaanki We'll have to remember to move this command to the new structure as well. Do we have an epic in which to note this?

Here is the issue https://github.com/submariner-io/submariner-operator/issues/1329. Added unexprt subitem under item #2 Move all cobra related stuff to cmd/subctl, Logic called by subctl inside pkg/cmd/subctl for below commands

@tpantelis PTAL

@tpantelis PTAL

I see that tom's comments are addressed and also since he is on PTO, go ahead and merging this PR.


Yaw uncertainty is always initialized by mag parameter

When investigating https://github.com/PX4/ecl/pull/586 I noticed that the yaw uncertainty is always initialized by the mag_heading_noise parameter even if no mag is used and the yaw measurement is coming from external vision. This is because _control_status.flags.ev_yaw is never set to true before EKF initialization is finished

Current behaviour is to set the yaw uncertainty using the value for the yaw source being used for alignment at the time.


Pagination: Styles for the last item are broken with hideNextButton prop

Component
Pagination
Description of bug
Styles for the last item are broken if the hideNextButton prop is passed.
Steps to reproduce

Open Pagination;
Set counter (max items) to 8 or more;
Set hideNextButton prop;
Notice that styles for the last item are broken.

Screenshots:

Note:
With the inVerse prop it will look like that:

On the second screenshot it has the correct styles with the isInverse prop.
Can it only be reproduced in dev or is it reproducible in the last released version?
Both

Closing in favor of https://github.com/cengage/react-magma/issues/1347. Will be addressed then.


Error occurred sending report com.crashlytics.android.core.SessionReport

I keep getting these errors in my logs
E/Fabric  (15406): Settings request failed.
E/Fabric  (15406): Error performing auto configuration.
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@e335cb3
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@78f3270
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@bf6c9e9
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@ccf266e
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@8fd110f
E/CrashlyticsCore(15406): Error occurred sending report com.crashlytics.android.core.SessionReport@f8d059c
These my doctor logs
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, v1.1.5, on Mac OS X 10.14.2 18C54, locale en-IS)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.2)
[✓] Connected device (2 available)
• No issues found!
➜  ~
I'm using firebase instead of fabric.

Never got that one... But look like a configuration issues, did you follow the firebase setup correctly ?

Closing as no response


Can't Update Java Version from 11 to 17

When trying to update to java version 17, the code base fails for unknown reasons
See #2150 for stacktrace

@goldblatt Play Framework requires a Java version between 8 and 11: https://www.playframework.com/documentation/2.8.x/Requirements


:sparkles: Add isEmpty

The new function isEmpty has been checked by runnable examples, not by unit tests.

Fixes #6.


Incorrect information - You've taken this course.

I haven't taken ENGL 336 yet or added it on quest. I think this appears for every course.

Could you provide more information on how to replicate this? This bug isn't showing up for me.  Which courses did you have in your cart?

Closing this due to stale issue.  Please reopen if it comes up again.


Fix: Fix for Not Data found

Link to the issue Issue

@charliehustlr1792 @harshit1142 can we  please merge this off


Add a note regarding fees for batch transactions.

I needed to estimate the transaction fees for a batch transaction and initially somehow thought I need to estimate the fee as the sum of the fees for each separate tx. Later I noticed the paymentInfo is also supported on utility.batch, and in fact the fee for a batch is less than the sum of the individual fees:)
Not sure if it is only me or it might happen to others as well, so just adding a note to mention it in the docs in case it is helpful. Feel free to rephrase or ignore if it is not relevant.

Ummmm.... this rather sounds like a bug in payment_paymentInfo. It really should return the (estimation) for the tx. If the value is less than the indv. sum, it sounds like it doesn't do what it is supposed to.

Interesting. I thought the batch transactions are cheaper since they might consume less resources!

It should be more -

there is an addition indirection layer
there is an additional length
the batch itself has weight, as does the wrapped transactions

Interesting. Just ran some benchmark (against  a substrate node) and seems the actual batch fee is less (if I'm correct by looking at the treasury deposit event as fee).
https://gist.github.com/hamidra/97c0ecc4cab0ce2913f8d9cbc34b3e93
tx2         {"applyExtrinsic":1} : treasury.Deposit [1144198187053]
tx1         {"applyExtrinsic":2} : treasury.Deposit [1136198187053]
batch    {"applyExtrinsic":3} : treasury.Deposit [1456306044802]
I'll ask around to find the answer in case this is not expected.

Ahh. Ok. I know what the discrepancy is.
So each transaction has a base fee in addition to the weight. The overall weight is more, but the base fee only applies once. So does actually make a new.

Got it! makes sense now!


Fix typo

Just fixing a small typo in the "getting started" guide, but it confused me so maybe it'll help someone else.

Checklist

[x] Updated guide with pertinent info (may not always apply).
[x] Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will :).

What's the process for merging?

What's the process for merging?

Currently, it is quite simple: CI passes, and at least one reviewer approves it. Then mergify app will merge it for you.


Subtitles

Steps to reproduce

Subtitles selected doesn't change in the middle of the show or at the beginning for that matter.
Subtitles used to change in the previous pre - releases but now it doesn't change or show at all.

Expected behavior
Subtitles when checked and selected as the votes go should show up
Actual behavior
Nothing shows up or selected subtitles change.
Crash logs (or stack trace)
No response
Flixclusive version
2.0.0 - 183f8a4
Android version
Android 13
Device
Honor 90
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to the latest version.

This is EP 2 from the boys season 1

Ill get back to this by next week, hope thats fine


not delegated status fixed

Hello, I found an issue with parsing domain status for whois data like that:
domain:        RAGULI.RU
state:         REGISTERED, NOT DELEGATED, VERIFIED
person:        Private Person
registrar:     REGRU-RU
admin-contact: http://www.reg.ru/whois/admin_contact
created:       2023-06-30T15:01:10Z
paid-till:     2024-06-30T15:01:10Z
free-date:     2024-07-31
source:        TCI
"NOT DELEGATED" status resulting parses as "not".
Thank you for your project!

Hello @plandruxa
Thanks for your PR.


The "Add to Favorites" button does not work

Because it can't read a cookie on production.
Changed from this
event.node.req.headers.authorization = `Bearer ${cookies["next-auth.session-token"]}`
To this
event.node.req.headers.authorization = `Bearer ${cookies["next-auth.session-token"] || cookies["__Secure-next-auth.session-token"]}`


Make manufacturer information array and relational

A product can have multiple manufacturers so manufacturer information inside a product item should look like this:
manufacturers: [ { "id": "<id>" }, { "id": "<id>" } ]

that should already work. the manufacterer_name or manufacturer_address is not checked for a particular type. however, I will change the names to manufacturer_names and manufacturer_addresses to imply the possibility of multiple manufacturers.


make ~/.authcode work correctly

fixes #60
the issue was that the check for './.authcode' overwrote the results of any successful check to '~/.authcode'

Should be fixed in another PR


Disable input field of datepicker

I am trying to disable the input field of the datepicker component, the equivalent of what would be achieved by
<mat-form-field>   <mat-label>Input disabled</mat-label>   <input matInput [matDatepicker]="dp3" disabled>   <mat-datepicker-toggle matSuffix [for]="dp3"></mat-datepicker-toggle>   <mat-datepicker #dp3 disabled="false"></mat-datepicker> </mat-form-field>
But cannot find any way to do this using templateOptions or datepickerOptions
Do I have to create a custom date picker template to enable this functionality, or is there a way to do it with the pre-existing datepicker template?

PR welcomed!

This issue has been fixed and released as part of v5.7 release. You can now pass the disabled value through the datepickerOptions property:
  templateOptions: {
    datepickerOptions: {
      disabled: true,
    },
  },

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

I am on Formly Material 5.10.3.

This : .templateOptions.datepickerOptions.disabled = true; did not work
While .templateOptions.disabled = true;  works for the input but the datepicker icon is not disabled & on clicking the pop-up shows up, this should get disabled too ...

Worse, the other fields which were disabled gets enabled

Worse, the other fields which were disabled gets enabled

@SubrahmanyaV Could you please provide a reproduction example

Worse, the other fields which were disabled gets enabled

@SubrahmanyaV Could you please provide a reproduction example

field.templateOptions.datepickerOptions.disabled = true; was resulting in an error because of which the other fields were not getting disabled.

I had to revert to using field.templateOptions.disabled = true; for now but just for your attention this does not disable the datepciker (the icon remains enabled & allows the User to choose a date & the value is reflected in the input)

(the icon remains enabled & allows the User to choose a date & the value is reflected in the input

fixed by #2613

I upgraded to Formly 5.10.6 just before testing this
The datepicker icon button is still 'not disabled' & it allows me to select a date from the calendar & the same is reflected in the input.
I use the following code to disable the Formly fields;
// --- Disable Document entry fields
this.documentFields.forEach(docField => {
docField.templateOptions.disabled = true;
});

Below is the screen shot showing the icon button still enabled

the fix will be available in v5.10.7, I'll let you know once released.

This issue has been fixed and released as part of v5.10.7 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

I upgraded to v5.10.7 before testing this.
The datepicker icon button is now getting disabled.
Many thanks for the fix.  This issue may be closed...

Is there an option to only disable the input field and use only the material date picker icon?

Is there an option to only disable the input field and use only the material date picker icon?

use true to readonly:
{
  "templateOptions": {
+   "readonly": true
  }
}


Hentai2read erroring out with "Must supply a valid URL"

Ripme version: 1.7.45
Java version:  1.8.0_171
Operating system:  Ubuntu 16.04
Exact URL you were trying to rip when the problem occurred: https://hentai2read.com/sm_school_memorial/1/
Please include any additional information about how to reproduce the problem:

Expected Behavior
The album rips
Actual Behavior
The ripper errors out with Must supply a valid URL

You need to link on manga preview page, You link is for just first page of this manga. Delete "/1/" in the end of link and this would be work.

You need to link on manga preview page, You link is for just first page of this manga.

The ripper should work with either.


[IDSEQ-2171] [Heatmap] Show notification for failed/waiting samples

Description

When a user creates a heatmap with a failed or waiting sample, the sample would appear but have no information.

This change ensures that failed/waiting samples do not appear in a heatmap, and also adds a notification describing to the user what happened.

Notes

Added font-caps mixins!

This PR uses the validateSampleIdsForBulkDownload API call to validate samples, so I renamed the call to the more generic validateSampleIds.

This PR made changes to the AccordionNotification component used by the bulk download modal, so I'm including screenshots of that as well to ensure that the style hasn't changed too much. @happyimadesignr

Changed long sample names to wrap rather than horizontal scroll.

Tests

Selected failed and waiting samples while creating a heatmap and verified that those samples did not appear in the heatmap, but were listed in a warning notification.
Selected failed and waiting samples for bulk download and verified that the warning notification still displays as expected.

OMG amazing! @j-x-han

Thanks for adding the font-cap- mixins!
Can we move the accordion arrow up and more to the right? If I could inspect in I could give exact values. Move up to center with the circle icon.
The wrap looks good! Better than horizontal scrolling! The line looks a bit long still, can you make it wrap a bit earlier?

Updated screenshots after moving the accordion arrow and wrapping long sample names earlier (checked with Jenn!):


ReferenceError: setImmediate is not defined under Jest 27

🐛 Bug Report
After updating to Jest 27, await getPage({ route: "/", useDocument: true, useApp: true }) is producing the following error:
    ReferenceError: setImmediate is not defined

      4 | describe("Homepage", () => {
      5 |   it("renders nicely", async () => {
    > 6 |     const { render } = await getPage({ route: "/", useDocument: true, useApp: true })
        |                        ^
      7 |     render()
      8 |     expect(screen.getByText("Welcome to")).toBeVisible()
      9 |   })

      at AsyncReader.read (node_modules/@nodelib/fs.walk/out/readers/async.js:26:9)
      at StreamProvider.read (node_modules/@nodelib/fs.walk/out/providers/stream.js:30:22)
      at ReaderStream.walkStream [as _walkStream] (node_modules/@nodelib/fs.walk/out/index.js:25:21)
      at ReaderStream.dynamic (node_modules/fast-glob/out/readers/stream.js:14:21)
      at ProviderAsync.api (node_modules/fast-glob/out/providers/async.js:23:33)
      at node_modules/fast-glob/out/providers/async.js:15:33
      at ProviderAsync.read (node_modules/fast-glob/out/providers/async.js:14:16)
          at Array.map (<anonymous>)
      at getWorks (node_modules/fast-glob/out/index.js:58:18)
      at Object.FastGlob [as default] (node_modules/fast-glob/out/index.js:10:19)
      at Object.getPagePaths [as default] (node_modules/next-page-tester/dist/getPageObject/getPagePaths.js:12:44)
      at Object.getRouteInfo [as default] (node_modules/next-page-tester/dist/getPageObject/getRouteInfo.js:13:51)
      at Object.getPageObject (node_modules/next-page-tester/dist/getPageObject/getPageObject.js:13:51)
      at Object.getPageInfo (node_modules/next-page-tester/dist/page/getPageInfo.js:13:46)
      at getPage (node_modules/next-page-tester/dist/getPage.js:65:51)
      at Object.<anonymous> (__tests__/next-page-tester.js:6:24)

It's from deep inside fast-glob, but it might be related to the way next-page-tester messes with window?
Reproduction
This specific branch will cause the error after npm install && npm test: https://github.com/fracture91/next-page-tester-hook-error/tree/jest27
Expected behavior
No error occurs and my tests pass :)
Jest patch
Have you patched Jest as described here?

[ ] yes
[x] no, because Jest 27 allegedly has that patch already

Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: macOS 11.2.3
    CPU: (8) arm64 Apple M1
  Binaries:
    Node: 15.8.0 - /opt/homebrew/bin/node
    Yarn: 1.22.5 - /opt/homebrew/Cellar/yvm/4.1.1/shim/yarn
    npm: 7.5.0 - /opt/homebrew/bin/npm
  npmPackages:
    jest: ^27.0.0 => 27.0.1

Welcome back @fracture91,
I haven't had the time to try Jest v27 out, it could be related to the fact that jest-environment-jsdom seems to not mock setImmediate and clearImmediate anymore. I currently don't have the full picture about what actually happens in  jest-environment-jsdom, though.
Do you have the chance of investigating this path?

Same issue here after upgrading to Jest 27.

I understand that jest-environment-jsdom didn't actually mock Node's globals but made them available in jsdom environment. Since Jest 27 only the globals actually existing in browser environment are let through.
If this assumption is correct we might consider replacing fast-glob with something else or explicitly making setImmediate available.

@fracture91 would you have the chance to try and replace fast-glob with fast-glob and open a PR in case in case it solves the issue? Happy to provide guidance.

@fracture91 would you have the chance to try and replace fast-glob with fast-glob and open a PR in case in case it solves the issue? Happy to provide guidance.

Sure, it doesn't look too difficult (🤞).  I'll probably have time to take a stab at it over the next couple of days.

I think its better to shim it using https://github.com/YuzuJS/setImmediate
I tried that and it fixed the issue (e.g. just imort it in our setup), but there are still some issues with jest after that one is fixed.

Hi @Meemaw, we might definitely try and setup a jest27 branch as soon as we have time to do so.
In regard of shimming setImmediate, shouldn't we consider trying first to leave Jest environment untouched by removing setImmediate from our call stack?

Sure, If we find a replacement that works well and passes all our tests. "replace fast-glob with fast-glob" <- some typo here?

Hihi, fixed my typo.

I set up a branch to gather the updates related to Jest 27.
https://github.com/toomuchdesign/next-page-tester/pull/223

Let's move the discussion here.

@toomuchdesign I've stumbled upon the same error using 0.25 version. I guess #223 that seems to fix it is merged to newer versions only, right?
    OS: Linux 5.11 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm
  npmPackages:
    jest: 27.0.6 => 27.0.6 ```

Only last versions of jest, next and next-page-tester are supported.


Add GitHub action to check markdown files for broken links

What would you like to be added:
Add GitHub action to check markdown files for broken links, e.g. Add GitHub action to check markdown files for broken links or anything else suitable.  Ideally the actions should be executed on every push to main and added to the required tests on a PR, but depending on how long it runs, we may just schedule it.
Why is this needed:
To avoid dead links in any of our markdown documentation files in any of the repositories, we should add a Github action that checks for dead links to all repositories.
linked to #161

e.g. https://github.com/corona-warn-app/cwa-server/blob/main/.github/workflows/markdown-analysis.yml#L27


S3 Bucket

If initial remote_state S3 bucket doesn't exists, make init dies without errors.

Configuration of init.sh script had a -e flag making the script to silently die if S3 bucket didn't exist.


ImportError: cannot import name 'init_model' from 'tcr_embedding.utils_training'

In the 10x_optuna_tutorial.pynb
from tcr_embedding.utils_training import init_model
however, there is not a function named "init_model" in the "tcr_embedding/utils_training.py" file

Thanks for your interest.
Due to a major formating of the code base, the tutorials from the earlier version do no longer work. I will update them accordingly in the next weeks.
In the meantime you can find a similar experiment as described in the notebook in the files:
experiments/10x_optuna.py
experiments/10x_full_optuna.py
Sorry for the inconvenience. I will close this issue, when I have updated the tutorials.

The tutorial folder now contains notebooks for:

preprocessing
training your models for data analysis
training your models for specificity prediction.

Best,
Felix


Update AssetBundleDownloader.cs

WebGL Unity 2022+ Cache Issue Workaround
Added UI for the downloading status
Unity 2019+ Compatibility Support

I think there might be a cleaner way to handle the UI integration, and will play around with that next week. Thanks for your submission!

I have pushed up some commits that disables caching on WebGL on Unity 2022.1+ and added a progress hook that can be used by UI. I prefer this style of hook because it should allow others to use any sort of UI that they want to show progress and doesn't add a dependency for UI to ABM.
Let me know if you have any issues.


[2.7] Bump webhook version to 0.3.6

https://github.com/rancher/webhook/pull/251
https://github.com/rancher/webhook/pull/274
https://github.com/rancher/webhook/pull/261

Here is the 0.3.5 branch:
https://github.com/rancher/webhook/tree/release/v0.3.5

@samjustus These changes are currently not included in the Q3 rancher/2.7 release, so this can be moved to Q4 v2.8
Changes in the following PRs are all covered by our current integration and unit tests.
https://github.com/rancher/webhook/pull/251
https://github.com/rancher/webhook/pull/274
https://github.com/rancher/webhook/pull/261

@JonCrowther Seems like release/v2.7 is using -rc2 for the webhook in one of the tests:
https://github.com/rancher/rancher/blob/e3d270128487fb1bb2079c37fa8933f9e3d4e5f3/tests/v2/codecoverage/package/Dockerfile#L61
Should this be updated there as well before we consider this issue done?
The rest is correctly using 0.3.6.


Resource migration Phase-1

In phase-1, the following resource types will be migrated to composite resource type:

[ ] Generic resource (#3100) (PR: #3101)
[ ] Multidimensional resource (NetCDF)(#3135)(PR: #3159)
[ ] Geographic Raster resource
[ ] Geographic Feature resource
[ ] Time Series resource

@dtarb @pkdash
Is this the right ticket where concerns and edge cases regarding "Generic to Composite migration" should be noted?

@zhiyuli yes.  If they are ONLY for generic to composite they could be discussed in #3100.  This issue is for any type migration issue.