MaxHit plugin

Discussions on discord (Discord name: Cashman)
OSRS Username: C4shman
Partially based on https://github.com/runelite/runelite/pull/2841/files
Done
Max Hit

Drawing the damage in the equipment window
Range damage
Melee damage

Obsidian
Berserker necklace
Prayer bonuses
Dharok

Magic damage

Normal Spellbook
Ancient magicks
Tridents
Magic equipment

Slayer equipment
Slayer Dart
Salve amulet

Code style

Run code analysis
Optimize imports
Optimize class / method access
Run code style checks
Add copyright and license
Replace item names with id's
Write tests

TODO
Code style

Refactor Attackstyles after #6643 has been merged

Won't implement for now

Special attacks
Maxhit against specific monsters (e.g. arclight vs demons, salve amulet vs undead)
Magic spells that are not being auto-casted
Maxhit during Castle Wars
Charge (for god spells), since the only way to track it is through chat messages

obsidian armor and berserker necklace

@deathbeam @Alexsuperfly Could you do an initial review?
I've probably missed some edge cases but so far I think quite a lot is in there already.

The plugin does not initialize correctly if the equipment menu is opened without boots, gloves, ring, or something in the ammo slot.

Equipping boots, gloves, ring, or ammo causes the plugin to function properly, even after removing these items. The plugin then functions properly, even after closing and reopening the equipment menu, but this process needs to be repeated after logout.
Equipping an item in any other slot while the plugin is not initialized properly results in this exception.
 14:51:04 [Thread-5] WARN  n.runelite.client.eventbus.EventBus - Uncaught exception in event subscriber java.lang.ArrayIndexOutOfBoundsException: 9 	at net.runelite.client.plugins.maxhit.equipment.EquipmentHelper.wearsItem(EquipmentHelper.java:40) 	at net.runelite.client.plugins.maxhit.equipment.EquipmentHelper.lambda$wearsItem$1(EquipmentHelper.java:46) 	at java.util.stream.MatchOps$1MatchSink.accept(MatchOps.java:90) 	at java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1359) 	at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) 	at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:498) 	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) 	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) 	at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:230) 	at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:196) 	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) 	at java.util.stream.ReferencePipeline.anyMatch(ReferencePipeline.java:449) 	at net.runelite.client.plugins.maxhit.equipment.EquipmentHelper.wearsItem(EquipmentHelper.java:45) 	at net.runelite.client.plugins.maxhit.equipment.EquipmentHelper.lambda$wearsItemSet$0(EquipmentHelper.java:35) 	at java.util.stream.MatchOps$1MatchSink.accept(MatchOps.java:90) 	at java.util.Collections$2.tryAdvance(Collections.java:4717) 	at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) 	at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:498) 	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) 	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) 	at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:230) 	at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:196) 	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) 	at java.util.stream.ReferencePipeline.allMatch(ReferencePipeline.java:454) 	at net.runelite.client.plugins.maxhit.equipment.EquipmentHelper.wearsItemSet(EquipmentHelper.java:35) 	at net.runelite.client.plugins.maxhit.calculators.MaxHitCalculator.applyEquipmentBonus(MaxHitCalculator.java:108) 	at net.runelite.client.plugins.maxhit.calculators.MeleeMaxHitCalculator.calculate(MeleeMaxHitCalculator.java:128) 	at net.runelite.client.plugins.maxhit.calculators.MaxHitCalculator.getMaxHit(MaxHitCalculator.java:137) 	at net.runelite.client.plugins.maxhit.MaxHitPlugin.updateMaxHitWidget(MaxHitPlugin.java:85) 	at net.runelite.client.plugins.maxhit.MaxHitPlugin.onItemContainerChanged(MaxHitPlugin.java:56) 	at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:72) 	at net.runelite.client.eventbus.EventBus.post(EventBus.java:218) 	at net.runelite.client.util.DeferredEventBus.replay(DeferredEventBus.java:69) 	at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:146) 	at client.methodDraw(client.java:1362) 	at client.ak(client.java) 	at bf.ag(bf.java:397) 	at bf.run(bf.java:351) 	at java.lang.Thread.run(Thread.java:748)

@fuzzy1450 Thanks a lot for the testing!
I will make sure this is fixed as soon as possible

@fuzzy1450 It took me a while to reproduce it but got it eventually.
I've just pushed a fix which should resolve the problem, could you try again?
Btw: I've also updated my repo with the lastest runelite/master branch.

I sill have the Equip Your Character Message.

This plugin would be an excellent candidate for the plugin hub

A max hit plugin has been added to the plugin hub. We encourage you to contribute to that one or, if for whatever reason that's not appropriate, create your own hub plugin.


Use lazy load hooks to hook on ActionController::Base:

👋  Hello guys thanks for creating and maintaining this gem
Use lazy load hooks to hook on ActionController::Base:

Calling directly ActionController::Base affects the initialization process (one of them being one that controls ActionController configuration)
As a result setting configuration inside an initializer (such as the asset_host), doesn't have any effect

Someone reverted my change https://github.com/bugsnag/bugsnag-ruby/pull/338 😢

Thanks for this, @Edouard-chin @rafaelfranca. We're going to take a look and figure out where a merge went awry.


GLU not found

Facing a similar issue as the original issue. My output for the debug commands is the same. I also see libglu1-mesa when doing an apt search but can't find the package when using ctypes.utils.find_library. The comment before mine in the original issue shows the relevant test results mentioned in the original thread. Just wanted to call attention to this in case there is any help you all can offer. Please let me know if there is any other information about my setup that I can provide. Thanks!
Originally posted by @ishan-gaur in https://github.com/pyglet/pyglet/issues/456#issuecomment-1840006915

Seems there are some issues with conda environments and the IDE people are using. Got resolved for me by installing libglu in the conda environment. https://anaconda.org/conda-forge/libglu

Thanks for commenting what the solution was, for future people.


Use dedicated allocation when allocation size is large enough

[X] Describe in common words what is the purpose of this change, related Github Issues, and highlight important implementation aspects.
When allocating a buffer that is extremely large (e.g. 4.5GB), Vulkano's pool allocator would round up that to the next power of two (which is 8GB) and it failed to allocate on my GPU (which has ~7.9GB of memory available for allocation).
This PR disables memory pool allocations for memory allocation above 256MB, as they would likely lead to allocating unnecessary space as well as delaying returning freed memory to the OS. Dedicated allocations are requested when supported, which might improve efficiency but should have no drawbacks otherwise.
While on that, also fix a few condition checks since KHR_dedicated_allocation has been promoted to Vulkan 1.1.

[X] Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
files(CHANGELOG_VULKANO.md and CHANGELOG_VK_SYS.md)
by maintainers right after the Pull Request merge.

Entries for Vulkano changelog:

Large allocations now use dedicated allocations which improves memory efficiency.

[X] Run cargo fmt on the changes.

N/A Make sure that the changes are covered by unit-tests.
Note: The changes were tested with an application I am developing.

N/A Update documentation to reflect any user-facing changes - in this repository.

Whoops, the autogenerated title was wrong. Fixed.

@ishitatsuyuki Thank you for your contribution!
I will take a closer look and will perform a few local test during the week(more likely by the end of the week), but at a first glance the implementation looks fine.

@ishitatsuyuki PR reviewed and merged. :+1: Thank you for your work, and I apologize for the delay in review.


feat: add validation prop to text element

Description

Adds validation prop to the TextElement

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Multiline strings are truncated in the terminal

Multiline strings (Template literals (Template strings) from Javascript) are truncated in the terminal when the area relative to the terminal is resized to make it smaller and then larger.

Run the following .js file in the Visual Code terminal (pwsh):

let html =
`<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Olá Mundo</title>

Hellow world in JavaScript

`;

console.log(html);

Resize the terminal area so it's really small and then resize it so it's big again;

Note that the string text is truncated and can no longer be viewed completely.

The same happens to me with a Java program when printing multiple consecutive lines on the terminal. If I resize the terminal some lines gets deleted and there is no way to recover them.

This is likely a problem with the conpty backend we use. You can try to reproduce the problem in Windows Terminal and if it happens there as well, report to microsoft/terminal.
If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here.
/label terminal terminal-conpty windows

Ok, I can not reproduce the error in Windows Terminal.


Uninstall: Resolve DDIC dependencies of VIEWs

Fix uninstall if table/structure references a view (ex https://github.com/abapGit-tests/TABL_include_VIEW)

Note: Changes to method RESOLVE are just reordering of object types in priority

thanks 👍


Random SIGSEGV

This problem is old, and I don't really want to investigate it and try some time consuming things to fix it because I'm not really bothered of it.
Around a half of a year ago I've launched a room with the haxball.js under the hood and the app was crashing randomly, and some time later I've noticed by accident the "SIGSEGV" error inside a logs of my apps launcher, pm2.
Specifically:
"/home/username/.pm2/pm2.log"
2023-02-25T18:07:02: PM2 log: App [hax-host:4] exited with code [0] via signal [SIGSEGV]
Then from this article I've found the problem is probably because of this module that is being used by haxball.js, and since I was using nodejs v16 I've switched to nodejs v14 because it's listed here. Sadly this did not fix the problem, but it seems to be better
Approximately, with a nodejs 16.15.0 I had 4 crashes in 4 months, and with a nodejs 14.21.3 I had 2 crashes in 3.5 months. The crashes are seems to be happening only when the room is being played, not when the room is empty.
The room activity, approximately, is 10+ people, 6+ hours a day, and the last months activity is definitely higher than it was in first months, so I guess if I'll switch back to node v16 I'll probably get more crashes than it was when there was less activity. Maybe, or maybe not, idk
I think that I could try to use another versions of node, or maybe try another JavaScript runtimes (deno, bun), or another linux build or distribution, but this crashes are so rare, this might take a years to debug this problem in that way. The problem is still annoying though
cat /etc/os-release output:
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster

This bug may have been fixed in v2.2.0. Closing as solved for now, follow-up needed.

I'll test it. I still have the same project thus still have the problem. I've attached a log below where you can see the app launch times that precedes the crashes and their frequency. I believe these are all of the crashes I've had. I also forgot to mention that after an every crash I also have a core dump file generated that could potentially be analyzed to find the problem. I'm just not sure what data is in there and how sensitive it is to share it. But since there is a new version to test I think it is not that important for now.
2023-02-23 23:10:13: PM2 log: App [hax-host:4] online
2023-02-25 18:07:02: PM2 log: App [hax-host:4] exited with code [0] via signal [SIGSEGV]

2023-03-17 02:30:50: PM2 log: App [hax-host:4] online
2023-03-17 22:00:11: PM2 log: App [hax-host:4] exited with code [0] via signal [SIGSEGV]

2023-03-18 15:38:23: PM2 log: App [hax-host:4] online
2023-03-23 17:11:37: PM2 log: App [hax-host:4] exited with code [0] via signal [SIGSEGV]

2023-05-26 12:01:04: PM2 log: App [hax-host:4] online
2023-05-31 17:44:10: PM2 log: App [hax-host:4] exited with code [0] via signal [SIGSEGV]

2023-06-09 23:18:59: PM2 log: App [hax-host:1] online
2023-06-17 18:09:31: PM2 log: App [hax-host:1] exited with code [0] via signal [SIGSEGV]

2023-09-01 07:02:10: PM2 log: App [hax-host:3] online
2023-09-11 09:58:53: PM2 log: App [hax-host:3] exited with code [0] via signal [SIGSEGV]

2024-02-08 04:17:21: PM2 log: App [hax-host:7] online
2024-02-08 15:13:44: PM2 log: App [hax-host:7] exited with code [0] via signal [SIGSEGV]

2024-03-27 15:19:40: PM2 log: App [hax-host:3] online
2024-04-08 17:39:47: PM2 log: App [hax-host:3] exited with code [0] via signal [SIGSEGV]

2024-04-28 21:33:44: PM2 log: App [hax-host:3] online
2024-05-01 08:19:20: PM2 log: App [hax-host:3] exited with code [0] via signal [SIGSEGV]

2024-05-28 13:10:38: PM2 log: App [hax-host:3] online
2024-06-17 18:21:38: PM2 log: App [hax-host:3] exited with code [0] via signal [SIGSEGV]

2024-06-17 21:05:19: PM2 log: App [hax-host:3] online
2024-07-27 23:51:05: PM2 log: App [hax-host:3] exited with code [0] via signal [SIGSEGV]

p.s. The app is up 24/7 and there are still around the same amount of players

Nevermind, I'm not going to test it right now. With the new version I've got this issue which I couldn't fix in an easy way. This issue makes haxball.js completely broken. I don't want to deal with this anymore

Issue with a non working haxball.js 2.2.0 doesn't appear in Ubuntu 22.04.3


Client Quick Access Flow

Describe the bug
When a client selects an ID to be assigned to any of the Quick Access IDs, the site doesn't save their selection. Nothing shows up, this needs to be fixed
To Reproduce
Steps to reproduce the behavior:

Go to the Client Landing Page
Select one of the Quick Access IDs and press Set Default ID button
Select a document

Expected behavior
No Quick Access ID will be shown even after selecting one
Screenshots

Additional context
Add any other context about the problem here.

this is fixed


feat(font): add monospace stack for opt in redhat font

fixes https://github.com/patternfly/patternfly-next/issues/2268
To test this, you can pull down the branch and update some component to use font-family: var(--pf-global--FontFamily--monospace);, then make sure the computed font-family is "liberation mono", then remove .pf-m-redhat-font from the <html> element and make sure the computed font-family is "overpass-mono".

PatternFly-Next preview: https://patternfly-next-pr-2382.surge.sh

@mceledonia approves

Confirmed that it works! All I had to do was add font-family: var(--pf-global--FontFamily--monospace); to the pf-c-badge component

:tada: This PR is included in version 2.40.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix Softmax activation to be computed row-wise for correct per-batch …

This Pull Request fixes a bug in the SoftmaxActivation where the softmax operation was inadvertently stabilized by a single global maximum across all rows, which led to incorrect outputs for multi-row (batch_size > 1) inputs.
Problem

Previously, the code subtracted the maximum value found over the entire 2D tensor. This worked fine when batch_size = 1 but would cause problems with larger batches, because only the row containing that global max was numerically stable.
Other rows were offset by that same max (potentially very different from their actual row-wise maxima) which would lead to skewed probabilities.

Fix

Compute the max value per row, then exponentiate and normalize each row independently.

Changes

Softmax Activation

Introduced a loop over each row in the input tensor.
Per row:

Compute the row-wise max.
Exponentiate all elements (after subtracting this row max).
Normalize by dividing each exponentiated element by the row-wise sum.

Thanks, should be fixed now.

test result: ok. 130 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 155.16s

Wrapping [batch_size, num_classes] in IxDyn and then Shape::from(...) converts the slice into the correct Shape<Dim<IxDynImpl>>: https://github.com/delta-rs/delta/pull/165/commits/ac7f98dcc08d1b009db6e3a6a93ff0c52808f076


I can not get back to the fragment of the main activity that called scanlibrary

Hey! Ciao da Italy
I have a problem with your library, in practice I have an activity with lots of fragments.
launch the scanner activity from a fragment.
Everything works until the last moment when I press the 'save' button and my application goes into the background and restarts.

If you think starting an Activity from a fragment is causing the problem, you should try to launch the  ScanFragment directly from your fragment or activity which implements from IScanner.


Witty pi energy manager

What's this recipe about?
Witty pi mini is a Uugear RPi shield capable of managing energy of the RPi together with keeping time using an embedded RTC.
https://github.com/uugear/Witty-Pi-2
Together with the Calafou community we are working on a timelapse camera for river monitoring. First test are being carried out at the Anoia river close to Barcelona.
The intention is to turn on the rpi 5 minutes every hour and take a picture. Simple as that. The Witty pi controls the On/OFF of the RPi sending zero voltage to the Pi to fully turn it off. After 55 minutes the Witty sends a electrical signal and the Pi boots up.

Set up of the very first ANOIAcam prototype over the Anoia river:

First picture of the Anoia river:

Download instructions
Generating the image will take a few minutes. Once the image is prepared, and if it succeeded, you'll see a green checkmark at the bottom of the pull request. To download the image go to  https://gitlab.com/publiclab/image-builder-rpi/pipelines/#47/builds and click the green checkmark.
On this page, click the Jobs tab, next to Pipeline
Click the green Passed button
Click Download in the right-hand sidebar
Unzip the artifacts.zip file, and also the hypriotos-rpi-camera_web.img.zip within it
Use a program like https://etcher.io/ to flash it to an SD card
You'll also be able to read the output of the image generation in this window.
We hope to create a bot to report back the completed image URL in each pull request. If you can help create such a bot, please contact us at:
#16
Thanks!

Absolutely no rush friends. Have just discovered some of the power of git so playing around. Also downloading the infragram recipe and trying Witty pi software manual install ;D Sooooo excited!!

Hi! Exciting to see this development and eager to help. For now I've gone thru https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/github_integration.html once again and still unable to fix. Possibly due to repo rename. I'll try again asap, meanwhile will push to Gitlab branch and share build output here!

Hi @icarito! Great to hear! So excited!!!!

Hi, i'm sorry, i'm working on using the autorebase bot to try to help keep all PRs rebased on top of the latest master branch. We should be able to run it on this branch, but i'm currently testing it in #50 and for now, perhaps best to do rebasing manually if required here. But you seem to be OK for now!

We have done some testing and tweaking and think that if you open a new PR, this will start building properly. Still not 100% sure but it worked in #54 -- would you mind giving it a try?
you could actually make a new branch named witty if you wanted, in case you want to have other versions too - instead of the master branch:
From your own repository page, at https://github.com/imvectech/pi-builder --

Sorry for the delay. I've created a new one at #58
I don't know if I've understood (newbie mode) shoud I try again adding the Witty changes?

Sorry for the delay. I've created a new one at #59


In the EDB api, i need the posibility to change the Port "Boundary Type" (Port/PEC/RLC), the "HFSS Type" (circuit/gap) properties and to activate R, L or C and finally assign a value to R, L or C.

Description of the feature
Dear colleagues,
using the existing "edb.create_circuit_port_on_pin(...)" function, i am able to create circuit ports, but now i need to be able to change the "HFSS Type" and then the "Boundary Type" properties of the created port and finally to activate R, L or C and to assign the component (R, L or C) value.
My goal is to generate a RLC boundaries on each components.
Then i will be able to simulate the project after export to hfss without having to place all the components again (the components are lost during the export from HFSS3dlayout to hfss, but not the RLC boundaries).
Thank you very much in advance !
Best Regards.
Olivier.
Steps for implementing the feature
No response
Useful links and references
No response

donce. closing


Blank screen

I am new to Electron and Vue. Just tried to run yarn dev all I see is a blank screen. Does it have anything to do with the Electron Security Warning (Disabled webSecurity)?

You probably got a version of Electron that's changed. I should have locked the version. I'll take a look at it this weekend.

Prolly something to do with the env? But didn't find .env file.
mainWindow.loadURL(process.env.APP_URL)

Never mind. Setting env APP_URL=http://<IP_ADDRESS>:8080 works!


[SPARK-7799][Streaming][Document]Add the linking instruction for streaming-akka project

Since actorStream is an external project, we should add the linking instruction for it.
A follow up PR of #10744

cc @tdas

Test build #49832 has started for PR 10856 at commit 59ff0dc.

Test build #49832 has finished for PR 10856 at commit 59ff0dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49832/
Test PASSed.

Merged build finished. Test PASSed.

Test build #49836 has started for PR 10856 at commit 448007b.

Test build #49836 has finished for PR 10856 at commit 448007b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
		class CustomActor extends ActorReceiver
		class CustomActor extends JavaActorReceiver

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49836/
Test PASSed.

Test build #2450 has started for PR 10856 at commit 448007b.

Test build #2451 has started for PR 10856 at commit 448007b.

Test build #2450 has finished for PR 10856 at commit 448007b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
		class CustomActor extends ActorReceiver
		class CustomActor extends JavaActorReceiver

Test build #2451 has finished for PR 10856 at commit 448007b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
		class CustomActor extends ActorReceiver
		class CustomActor extends JavaActorReceiver

LGTM. Merging to master.


Specifying -LogFile for output to the console

Currently this script assumes that a path is required for the -logFile parameter. We can update it to support getting console output.
https://docs.unity3d.com/Manual/CommandLineArguments.html:

Specify where Unity writes the Editor or Windows/Linux/OSX standalone log file. To output to the console, specify - for the path name. On Windows, specify - option to ensure output goes to stdout, which is not the console by default.

Does this work correctly with batch mode?

Note that in batch mode, Unity sends a minimal version of its log output to the console. However, the Log Files still contain the full log information.

Batch mode is typically used for any automated building, and so far, yes in my versions it works correctly. You still have full control over how logs are displayed and their logging types can be modified by utilizing scripts that can change it if specific conditions using LogErrorFormat


Examples link broken from the main website

I am looking for examples on the main website. When you click on the example link on home page it 404 s

Thanks! Will fix this later today!
Here is where it should point to! https://github.com/ts-engine/ts-engine/tree/master/packages/private/examples

The broken link has been fixed now, it's just deploying now


[IS 5.6.0] [SCIM2] canonicalize complex multivalue attributes (email & phone number)

per RFC 7643 section 2.4:
"When returning multi-valued attributes, service providers SHOULD canonicalize the value returned (e.g., by returning a value for the sub-attribute "type", such as "home" or "work") when appropriate (e.g., for email addresses and URLs)."
However, after:

disabling SCIM2 endpoint auth (for testing purposes)
sending a SCIM2 request to add the other email address<EMAIL_ADDRESS>to admin
setting admin's email address in the dashboard to<EMAIL_ADDRESS>issuing curl -k https://localhost:9443/scim2/Users?filter=userName+eq+admin
the result is:
{"schemas":"urn:ietf:params:scim:api:messages:2.0:Error","scimType":"invalidSyntax","detail":"Request is unL110607:github matt.bL110607:github matt.beary$ curl -k https://localhost:9443/scim2/Users?filter=userName+eq+admin {"totalResults":1,"startIndex":1,"itemsPerPage":1,"schemas":["urn:ietf:params:scim:api:messages:2.0:ListResponse"],"Resources":[{"emails":[{"type":"other","value":"fake@email.org"},"what@what.what"],"meta":{"created":"2018-07-13T14:11:57Z","lastModified":"2018-07-16T17:03:43Z"},"name":{"givenName":"me!","familyName":"admin"},"groups":[{"display":"Application/local-8443"}],"id":"fd650662-a0fc-4095-a88a-c4d9203b3e67","userName":"admin"}]}

<EMAIL_ADDRESS>should be returned as an object with a value string (and possibly a default type), not a primitive string

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


v-model and null value on radio button with vue-tsc v1.1.3

The following component throws with v1.1.13:
<script setup lang="ts">
import { ref } from 'vue'
const count = ref<number | null>(null)
</script>

<template>
  <input v-model="count" type="radio" v-for="i in 3" :key="i" :value="i" />
</template>

with:
src/App.vue:7:10 - error TS2322: Type 'number | null' is not assignable to type 'any[] | Set<any> | Booleanish | undefined'.
  Type 'null' is not assignable to type 'any[] | Set<any> | Booleanish | undefined'.

7   <input v-model="count" type="radio" v-for="i in 3" :key="i" :value="i" />
           ~~~~~~~

  node_modules/@vue/runtime-dom/dist/runtime-dom.d.ts:646:3
    646   checked?: Booleanish | any[] | Set<any> // for IDE v-model multi-checkbox support
          ~~~~~~~
    The expected type comes from property 'checked' which is declared here on type 'ElementAttrs<InputHTMLAttributes>'

undefined is allowed, but null is no longer possible

I'll just repeat what I said last time: https://github.com/vuejs/language-tools/issues/1252#issuecomment-1254806581

@KaelWD Can you review #2417?


Copy Bootstrap .NET dll. Don't copy Bootstrap DLL if OutputType=Library

This corrects 2 problems:

Microsoft.WindowsAppSDK.Bootstrap.targets copies the Bootstrap dll from ...\runtimes\lib\**cpu**\... and handles it when **cpu** = Win32 but not when it's AnyCPU.
Microsoft.WindowsAppRuntime.Bootstrap.Net.dll wasn't getting copied for .NET projects

I tested with various permutations of C++ and C# projects.  This doesn't affect C++ projects (were doing the right thing before, this doesn't negatively impact them). OTOH C# projects now build successfully with content as expected.
This addresses AnyCPU Class libraries are broken again
#1217

I'm considering inverting the test, changing
<Target Name="BinPlaceBootstrapDll" Condition="'$(AppxPackage)' != 'true' and '$(OutputType)' != 'Library'" AfterTargets="Build">

to
<Target Name="BinPlaceBootstrapDll" Condition="'$(AppxPackage)' != 'true' and ('$(OutputType)' == 'Exe' or '$(OutputType)' == 'WinExe')" AfterTargets="Build">

i.e. replace "if !=Library" with "if ==Exe or WinExe"
According to MSBuild's docs OutputType has 4 possible values: Library (default), Exe, Module, WinExe, but I've also noticed other values e.g. Microsoft.UI.Xaml.Markup.Compiler.Interop.targets supports AppContainerExe. Plus 'module' seems exceedingly rare at best. Overall I find precedent for all possible answers (==X and !=Y) so I'm open to suggestions if there's "common practice" or other compelling suggestions.

/azp run

/azp run

/azp run

/azp run

/azp run


fix: attempt to fix sass resolving root of package instead of subfolder

Description
This PR attempts to fix the issue seen in this issue:  https://github.com/vitejs/vite/issues/18134
Currently, the process for resolving SASS files is looking at the root of the directory and fails if the build files are in a subfolder.

Thanks for the PR. I'm checking locally and this seems to technically break if a package has some-package/index.scss but main js entry is in a different directory like some-package/js/index.js:
{
  "name": "some-package",
  "exports": "./js/index.js"
}

I'm not sure about the history, but it looks like this sass specific logic is initially introduced in https://github.com/vitejs/vite/pull/3627 and probably the intent is to always check some-package/index.scss (or _index.scss) regardless of main entry.
Looking at your reproduction in https://github.com/vitejs/vite/issues/18134, you can fix this specific resolution error by explicitly adding sass export entry. Would something like this work for you?
{
  "name": "lib",
  "version": "1.0.0",
  "main": "./build/index",
  "module": "./build/index.esm.js",
  "exports": {
    ".": {
      "sass": "./build/index.scss",
      "import": "./build/index.esm.js",
      "require": "./build/index.js"
    }
  }
}

@hi-ogawa Thank you for your answer. This is promising but my current test still show the same error on the reproduction package in the issue.
I agree that this solution isn't going to work for every situation. But the current solution works only for if the scss file is at the root of the package folder and the JS files can be placed in anyway.

My bad, I had to make it the first property. It fixes the reproduction example. I close this PR.
Thank you for your time. I'll update the issue so if someone has the same issue they have the solution right away

Just out of my mind, having a log stating which file it was trying to resolve with which context could be interesting for debugging as it helps pinpointing what is the problem and as such detect a problem in configuration.
I am carrying on the migration but I added a log at a place so I can see at failure what it was trying to do. Very hepful but not an easy task for everyone.


Where to make the API request for WIDGET_UPDATE action?

I was wondering about how I can make an API request to update the widget and was confused about where to make the request.
Do I have to make the API request inside the case of WIDGET_UPDATE action like this:
switch (props.widgetAction) {
    case "WIDGET_UPDATE":
      const response = await axios.get('https://example.com/api');
      const data = response.data;

      props.renderWidget(<Widget data={data} />);
      break;

    default:
      break;
  }
};

Or can I make it inside the widget-task-handler and outside the switch cases like this:
const widgetTaskHandler = async (props: WidgetTaskHandlerProps) => {
  const widgetInfo = props.widgetInfo;
  const Widget =
    nameToWidget[widgetInfo.widgetName as keyof typeof nameToWidget];

  const response = await axios.get('https://example.com/api');
  const data = response.data;

  switch (props.widgetAction) {
    case "WIDGET_UPDATE":
      props.renderWidget(<Widget data={data} />);
      break;

    default:
      break;
  }
};

It seems the second method works as well and would be much more suitable for situations where the data fetching also happens upon the WIDGET_ADDED action.
  const response = await axios.get('https://example.com/api');
  const data = response.data;

  switch (props.widgetAction) {
    case "WIDGET_ADDED":
    case "WIDGET_UPDATE":
      props.renderWidget(<Widget data={data} />);
      break;

    default:
      break;
  }

Whatever works best for you, there is no such limitation from the library.
Your approach seems fine.
Keep in mind you probably do not want to fetch the data if the user removes the widget (WIDGET_DELETED action).

Whatever works best for you, there is no such limitation from the library.
Your approach seems fine. Keep in mind you probably do not want to fetch the data if the user removes the widget (WIDGET_DELETED action).

Oh, so I indeed should use the first method and fetch the data in the WIDGET_ADDED and WIDGET_UPDATE action cases since by using the second method, the data would be fetched on other actions like WIDGET_DELETED and WIDGET_RESIZED.
I hope this is what you meant.

Or you could do
switch (props.widgetAction) {
  case "WIDGET_ADDED":
  case "WIDGET_UPDATE":
    const response = await axios.get('https://example.com/api');
    const data = response.data;
    props.renderWidget(<Widget data={data} />);
    break;

  default:
    break;
}

You also don't need to use a switch statement, it was used in the examples because it looked cleaner to show all the options.


Upgrade to Coq 8.13

~Testing CI, please ignore for now.~ CI passed!
Resolves #730
This PR upgrades us to use Coq 8.13 in the CI. It is most likely not a backwards-compatible change due to a change to module names in the Haskell extraction, and possibly also due to the coq-record-update upgrade that was needed for 8.13 to build. Before this PR is merged, everyone should update their local development environment to 8.13 or higher. I've upgraded mine to 8.13.2 and everything builds, so any 8.13.x version is likely fine.

To be clear, I'm happy to hold off on this change for a while as people make local upgrades.


Improve article 1701.02886 (undefined \AND)

Problem details
Conversion complete: 30 warnings; 4 errors; 4 undefined macros[\AND, \addr, \email, \name]
on the title page there are undefined macros

The problem with \AND also affects 2111.02080, will reuse the issue for it.

There are also 3 other article ids to test with mentioned in engrafo#252, which also have the undefined \And macros in ar5iv.

The main reported article is now resolved.
The issue remains in 1707.08952, 1707.08172, 1609.03499, 2111.02080.
The \AND is also resolved in 1608.05343, but that article still has a double frontmatter block, which would need a fix.
Keeping the issue open until we cover them all.


Update dependency to MedComMessaging-IG

https://github.com/medcomdk/dk-medcom-messaging/issues/28

Dependencies are correct


edition = 2018; dependencies updated; associated changes

I had some audible artifacts. Not sure if this affects it, but a refresh seemed in order

#247 has done most of this


roboticscape.h cannot be used in C++

the required extern "C" {...} block declaration is missing in roboticscape.h file making link fail when using the library withing C++.
It is easily fixable.
Thanks

Please consider providing a pull request

Sorry, it seems i did create a separate issue, while i just meant to refer to this one.


Add epoch-based interruption for cooperative async timeslicing.

(Builds on #3698)
This PR introduces a new way of performing cooperative timeslicing that
is intended to replace the "fuel" mechanism. The tradeoff is that this
mechanism interrupts with less precision: not at deterministic points
where fuel runs out, but rather when the Engine enters a new epoch. The
generated code instrumentation is substantially faster, however, because
it does not need to do as much work as when tracking fuel; it only loads
the global "epoch counter" and does a compare-and-branch at backedges
and function prologues.
This change has been measured as ~twice as fast as fuel-based
timeslicing for some workloads, especially control-flow-intensive
workloads such as the SpiderMonkey JS interpreter on Wasm/WASI.
The intended interface is that the embedder of the Engine performs an
engine.increment_epoch() call periodically, e.g. once per millisecond.
An async invocation of a Wasm guest on a Store can specify a number of
epoch-ticks that are allowed before an async yield back to the
executor's event loop. (The initial amount and automatic "refills" are
configured on the Store, just as for fuel.) This call does only
signal-safe work (it increments an AtomicU64) so could be invoked from
a periodic signal, or from a thread that wakes up once per period.

I think there is value in having this exist in addition to the fuel mechanism rather than as replacement. There are cases where determinism is essential, whether for reproducibility or to implement an rr like debugger. In other cases performance is indeed more important. In those cases the epoch-based interruption can be used.

I think there is value in having this exist in addition to the fuel mechanism rather than as replacement. There are cases where determinism is essential, whether for reproducibility or to implement an rr like debugger. In other cases performance is indeed more important. In those cases the epoch-based interruption can be used.

@bjorn3 yes, indeed, I guess I was thinking "replace many uses of fuel" rather than "actually remove fuel", but that was ambiguous, sorry. I agree that determinism is very useful in other circumstances and so we probably don't want to actually remove fuel; this PR keeps it around and perhaps I can add some documentation on the tradeoff and when to use each.

@alexcrichton I think I've addressed most of your comments; thanks!

Updated and added an example -- will resolve the doc-comment broken links then merge, if all's well otherwise. Thanks!


[THRIFT-82] Add Common Lisp support

There's framed and buffered socket transport, binary protocol, multiplex, simple
server, cross-tests, self-tests, tutorial, CL library, CL code generator. Only
SBCL is supported for now.

squashed and rebased on top of the thrift master head.

The bottom line is this: under the law of where mr. Anderson lives he can't yield the IP rights nor he sees a reason to do so, so we can't remove the copyrights put by him there. Code is licensed under the same license as the Thrift code though.

My take on the Apache licensing rules is that we cannot accept this if it has other copyrights in it:
If the source file is submitted with a copyright notice included in it, the copyright owner (or owner's agent) must either:
* remove such notices, or
* move them to the NOTICE file associated with each applicable project release, or
* provide written permission for the ASF to make such removal or relocation of the notices.

If Mr. Anderson would provide the ASF with written permission to move the copyright statements into a NOTICE.md file within lib/cl that would be sufficient for inclusion in the project.

After email exchange with Mr. Anderson I've came to conclusion that we should first put thrift CL library in Quicklisp (we already download dependencies from there) and pull the library from there. In this scenario lib/cl will have only Makefile and some tests. That way there is no problem with copyrights. As of tutorial part and cross tests, they are written by us, so there shouldn't be any issue with that.
Tutorial code is written by us, same goes for cross tests. My only concern is about t_cl_generator.cc file from compiler/ module, which has yet another copyright owner, original PR THRIFT-82 issuer (https://issues.apache.org/jira/browse/THRIFT-82) Mr. Patrick Collison: https://issues.apache.org/jira/secure/attachment/12386027/thrift-cl.patch . Should I write to him? His GH handle is @pc, but he doesn't seem to be very active here lately.

Good news, I have consent from @pc to change the header of the generator to match contributor guidelines. So next steps are:

merge changes to de.setf.thrift repository (so missing protocols are implemented)
publish de.setf.thrift on Quicklisp
adjust this pull request for Common Lisp inclusion

should I close this pull request for now, or leave it as is until then?

Just confirming that I'm 👍 here and excited to see this make progress. Thanks!

@jfarrell was going to take action either on contacting individuals or making decisions on this, so I'm waiting to see what the result of those efforts is.  I would much prefer the cl code for thrift be in the thrift project itself and not hosted somewhere else.

any update on this? I'm fine with both options (given all parties agree on them) and have time to work on code forward.

@dkochmanski still waiting for @jfarrell to chime in since he was going to take some actions.  I provided him with an email that could be used to contact the author(s) involved, but I haven't heard anything since that.  My preference would be to get permission to build the cl implementation for thrift into the thrift project rather than have it sitting external.
If the cl part of the project is going to sit external then we'll likely need to consider it a "contrib/" type of submission where it is maintained external to the project.  That doesn't sound like a good long term solution for adding a language to the collection.

I have sent an email to the two participants for which permission is needed to move copyright statements in order to comply with the Apache licensing requirements.  I asked them to each post either acceptance or rejection here for the record.
Once we have their answers we can proceed to whatever the next step will be.  Without permission the bulk of the code may have to live in some other repository, untouched, and downloaded as part of the build process.

Rebased and resolved merge conflicts
Fixed some minor issues with make clean and dependencies
Added (newly) failing tests to known_failures_Linux.json

@jeking3 I'm really sorry, I only noticed there were suggested changes attached to your comment after I did a force push. I can't see them anymore. Do you remember if there was anything important there?
I removed the CL Thrift library and made it so that it's downloaded during the building process. I think all the code that is left is either written by us (cross-tests, tutorial, build integration, etc.) or isn't an issue (code generator).
Currently we download the library from our fork of Anderson's work by downloading (curl) the zip file from github and unzipping it. The long-term goal, though, is to merge our fork with upstream and get it added to quicklisp. After that we can just download the library in a similar way we download all the dependencies.
I used that suggested bash snippet from the closed PR. It worked nicely.
What do you think? Is this PR fine in its current shape?

I will take another look.  Can you squash this into a single commit to prepare it for inclusion if it looks good?

Of course. Squashed.

I won't lie, this feels good! Thanks a lot for the extensive support.

Rebased.

Thanks, I am working on running this in my local docker container and checking the "make cross" results.

I ran the cross test in ubuntu-artful using your PR and only ttwo unexpected failures occurred:
===============================================================================
*** Following 2 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.
===============================================================================
server-client:          protocol:         transport:               result:
d-cl                    binary            buffered-ip              failure(1)
d-cl                    binary            framed-ip                failure(1)

I think we're good to go.  I will change the cross test to use the artful image (and disable those two tests explicitly for now), now that artful has haxe enabled again, it has as many languages as the xenial image does.

Best I can tell there seems to be some sort of timing or logic error.  Builds will randomly fail after writing a fasl, apparently renaming it, then being unable to find it.  This is the "ubsan" build job which runs "make precross":
https://api.travis-ci.org/v3/job/347498508/log.txt
; compiling (DEF-STRUCT "structb" ...)
; compiling (DEF-SERVICE "ThriftTest" ...)
; compiling (DEF-SERVICE "SecondService" ...)
; /root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl written
; compilation finished in 0:00:06.905

then immediately after:
Unhandled SB-INT:SIMPLE-FILE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
                                                {1001E066F3}>:
  Failed to find the TRUENAME of /root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl:
    No such file or directory

Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {1001E066F3}>
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #<SB-INT:SIMPLE-FILE-ERROR "~@<~?: ~2I~_~A~:>" {1002AFF8E3}> #<unavailable argument>)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #<SB-INT:SIMPLE-FILE-ERROR "~@<~?: ~2I~_~A~:>" {1002AFF8E3}>)
2: (INVOKE-DEBUGGER #<SB-INT:SIMPLE-FILE-ERROR "~@<~?: ~2I~_~A~:>" {1002AFF8E3}>)
3: (ERROR SB-INT:SIMPLE-FILE-ERROR :PATHNAME #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl" :FORMAT-CONTROL "~@<~?: ~2I~_~A~:>" :FORMAT-ARGUMENTS ("Failed to find the TRUENAME of ~A" (#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl") "No such file or directory"))
4: ((LABELS SB-IMPL::RESOLVE-PROBLEMATIC-SYMLINK :IN SB-IMPL::QUERY-FILE-SYSTEM) NIL)
5: (SB-IMPL::QUERY-FILE-SYSTEM #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl" :TRUENAME T)
6: (TRUENAME #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl")
7: (RENAME-FILE #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl" #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.fasl")
8: (UIOP/LISP-BUILD:COMPILE-FILE* #P"/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.lisp" :OUTPUT-FILE #P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.fasl" :EXTERNAL-FORMAT :UTF-8 :WARNINGS-FILE NIL)
9: (ASDF/LISP-ACTION:PERFORM-LISP-COMPILATION #<ASDF/LISP-ACTION:COMPILE-OP > #<ASDF/LISP-ACTION:CL-SOURCE-FILE "thrift-gen-thrifttest" "ThriftTest-types">)
10: ((SB-PCL::EMF ASDF/ACTION:PERFORM) #<unavailable argument> #<unavailable argument> #<ASDF/LISP-ACTION:COMPILE-OP > #<ASDF/LISP-ACTION:CL-SOURCE-FILE "thrift-gen-thrifttest" "ThriftTest-types">)
11: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) #<ASDF/LISP-ACTION:COMPILE-OP > #<ASDF/LISP-ACTION:CL-SOURCE-FILE "thrift-gen-thrifttest" "ThriftTest-types">) [fast-method]
12: ((:METHOD ASDF/PLAN:PERFORM-PLAN (LIST)) ((#1=#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/SYSTEM:SYSTEM "puri">) (#1# . #<ASDF/SYSTEM:SYSTEM "split-sequence">) (#1# . #<ASDF/SYSTEM:SYSTEM "closer-mop">) (#1# . #<ASDF/SYSTEM:SYSTEM "trivial-utf-8">) (#1# . #<ASDF/SYSTEM:SYSTEM "ieee-floats">) (#1# . #<ASDF/SYSTEM:SYSTEM "trivial-gray-streams">) (#1# . #<ASDF/SYSTEM:SYSTEM "alexandria">) (#1# . #<ASDF/SYSTEM:SYSTEM "thrift">) (#2=#<ASDF/LISP-ACTION:PREPARE-OP > . #<ASDF/SYSTEM:SYSTEM #3="thrift-gen-thrifttest">) (#2# . #4=#<ASDF/LISP-ACTION:CL-SOURCE-FILE #3# "ThriftTest-types">) (#1# . #4#) (#<ASDF/LISP-ACTION:LOAD-OP > . #4#) ...) :FORCE NIL) [fast-method]
13: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
14: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) ((#1=#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/SYSTEM:SYSTEM "puri">) (#1# . #<ASDF/SYSTEM:SYSTEM "split-sequence">) (#1# . #<ASDF/SYSTEM:SYSTEM "closer-mop">) (#1# . #<ASDF/SYSTEM:SYSTEM "trivial-utf-8">) (#1# . #<ASDF/SYSTEM:SYSTEM "ieee-floats">) (#1# . #<ASDF/SYSTEM:SYSTEM "trivial-gray-streams">) (#1# . #<ASDF/SYSTEM:SYSTEM "alexandria">) (#1# . #<ASDF/SYSTEM:SYSTEM "thrift">) (#2=#<ASDF/LISP-ACTION:PREPARE-OP > . #<ASDF/SYSTEM:SYSTEM #3="thrift-gen-thrifttest">) (#2# . #4=#<ASDF/LISP-ACTION:CL-SOURCE-FILE #3# "ThriftTest-types">) (#1# . #4#) (#<ASDF/LISP-ACTION:LOAD-OP > . #4#) ...)) [fast-method]
15: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
16: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) #<ASDF/PLAN:SEQUENTIAL-PLAN {1001E5AF13}>) [fast-method]
17: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION ASDF/COMPONENT:COMPONENT)) #<ASDF/LISP-ACTION:LOAD-OP > #<ASDF/SYSTEM:SYSTEM "thrift-gen-thrifttest">) [fast-method]
18: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) #<unused argument> #<unused argument> #<ASDF/LISP-ACTION:LOAD-OP > #<ASDF/SYSTEM:SYSTEM "thrift-gen-thrifttest">)
19: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
20: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) #<ASDF/LISP-ACTION:LOAD-OP > #<ASDF/SYSTEM:SYSTEM "thrift-gen-thrifttest">) [fast-method]
21: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) #<unused argument> #<unused argument> ASDF/LISP-ACTION:LOAD-OP :THRIFT-GEN-THRIFTTEST)
22: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
23: (ASDF/CACHE:CALL-WITH-ASDF-CACHE #<CLOSURE (LAMBDA NIL :IN ASDF/OPERATE:OPERATE) {1001E5664B}> :OVERRIDE NIL :KEY NIL)
24: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP :THRIFT-GEN-THRIFTTEST) [fast-method]
25: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP :THRIFT-GEN-THRIFTTEST) [fast-method]
26: (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST)
27: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) #<NULL-LEXENV>)
28: (EVAL-TLF (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) 6 NIL)
29: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) 6)
30: ((LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) :CURRENT-INDEX 6)
31: (SB-C::%DO-FORMS-FROM-INFO #<CLOSURE (LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) {1001E1A35B}> #<SB-C::SOURCE-INFO {1001E1A313}> SB-C::INPUT-ERROR-IN-LOAD)
32: (SB-INT:LOAD-AS-SOURCE #<SB-SYS:FD-STREAM for "file /thrift/src/test/cl/make-test-client.lisp" {1001E0EBE3}> :VERBOSE NIL :PRINT NIL :CONTEXT "loading")
33: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) #<SB-SYS:FD-STREAM for "file /thrift/src/test/cl/make-test-client.lisp" {1001E0EBE3}> NIL)
34: (LOAD #<SB-SYS:FD-STREAM for "file /thrift/src/test/cl/make-test-client.lisp" {1001E0EBE3}> :VERBOSE NIL :PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
35: ((FLET SB-IMPL::LOAD-SCRIPT :IN SB-IMPL::PROCESS-SCRIPT) #<SB-SYS:FD-STREAM for "file /thrift/src/test/cl/make-test-client.lisp" {1001E0EBE3}>)
36: ((FLET #:WITHOUT-INTERRUPTS-BODY-146 :IN SB-IMPL::PROCESS-SCRIPT))
37: (SB-IMPL::PROCESS-SCRIPT "make-test-client.lisp")
38: (SB-IMPL::TOPLEVEL-INIT)
39: ((FLET #:WITHOUT-INTERRUPTS-BODY-77 :IN SAVE-LISP-AND-DIE))
40: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))

unhandled condition in --disable-debugger mode, quitting
;
; compilation unit aborted
;   caught 2 fatal ERROR conditions
Makefile:635: recipe for target 'TestClient' failed
make[2]: *** [TestClient] Error 1
make[2]: Leaving directory '/thrift/src/test/cl'

Is it possible that the RENAME implementation in sbcl is buggy when the source and destination are the same, and perhaps it exhibits some undefined behavior?  Just a wild guess...

I updated the ubuntu-artful image to SBCL 1.4.4 and it seems to be stable.  Merging.


Add my school

Hi would like to ask to add my university to your list of university
Thank you

@lpbedia2792 First stage of verification passed, official domain is isufst.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@lpbedia2792 Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thank you


Revert "Change error message on copy of running container"

This reverts commit 19ff92c57421134756c903914ddee09d989871dd.
I don't think this commit is right:

we do support copying of running containers (i.e. migration)
changing the hostname of running containers is not supported right now

so I think it should be reverted.
Unfixes #622
Signed-off-by: Tycho Andersen<EMAIL_ADDRESS>

Can we at least catch the case where we are doing a local copy (so clearly not migration) and fail that if the container is running with an error message that's not nearly as confusing?

On Wed, Jun 03, 2015 at 08:50:45AM -0700, Stéphane Graber wrote:

Can we at least catch the case where we are doing a local copy (so clearly not migration) and fail that if the container is running with an error message that's not nearly as confusing?

I don't think the localness has anything to do with it: if you're
trying to change a hostname during a migration, that is also not
supported.
I'm happy to change the error message, if you have a suggestion.

Reply to this email directly or view it on GitHub:
https://github.com/lxc/lxd/pull/730#issuecomment-108493941

"Changing the name of a running container during copy isn't supported." ?
I think the important thing here is that it's clear that the error relates to the copy.

On Wed, Jun 03, 2015 at 09:08:37AM -0700, Stéphane Graber wrote:

"Changing the name of a running container during copy isn't supported." ?
I think the important thing here is that it's clear that the error relates to the copy.

Sounds good.
Tycho

Reply to this email directly or view it on GitHub:
https://github.com/lxc/lxd/pull/730#issuecomment-108503263


Use orjson in place of json

I think switching to orjson over the json library would offer significant performance enhancement when loading data into memory. While the units of measurement are only in ms, I believe this might add up over time for big batches of analyses.
To summarise some of the metrics from their README:
This measures serializing the citm_catalog.json fixture, more of a worst
case due to the amount of nesting and newlines, as compact (489KiB) or
pretty (1.1MiB):

Library
compact (ms)
pretty (ms)
vs. orjson

orjson
0.59
0.71
1

ujson
2.9
3.59
5

rapidjson
1.81
2.8
3.9

simplejson
10.43
42.13
59.1

json
4.16
33.42
46.9

This measures serializing 92MiB of JSON from an numpy.ndarray with
dimensions of (50000, 100) and numpy.float64 values:

Library
Latency (ms)
RSS diff (MiB)
vs. orjson

orjson
194
99
1.0

ujson

rapidjson
3,048
309
15.7

simplejson
3,023
297
15.6

json
3,133
297
16.1

This measures serializing 100MiB of JSON from an numpy.ndarray with
dimensions of (100000, 100) and numpy.int32 values:

Library
Latency (ms)
RSS diff (MiB)
vs. orjson

orjson
178
115
1.0

ujson

rapidjson
1,512
551
8.5

simplejson
1,606
504
9.0

json
1,506
503
8.4

This measures serializing 105MiB of JSON from an numpy.ndarray with
dimensions of (100000, 200) and numpy.bool values:

Library
Latency (ms)
RSS diff (MiB)
vs. orjson

orjson
157
120
1.0

ujson

rapidjson
710
327
4.5

simplejson
931
398
5.9

json
996
400
6.3

The RSS column measures peak memory
usage during serialization.
Overall, we would benefit from lower latency, and lower memory usage. Thoughts on this?

Probably won't action for now :(


create a spinner animation for mesg logo

to be set as a charset while using https://github.com/briandowns/spinner/

Haha, cool idea!
But I cannot imagine a good looking loading animation with a MESG logo in ASCII!


sized_buffer_ptr

The SCIF backend of buffer_ptr has a size field.
https://github.com/noma/ham/blob/5649c04291336e0df172734ca8631d7be3020dbd/include/ham/net/communicator_scif.hpp#L34-L65
Is that the same size as the number of elements in that buffer?
I ask, because of the sized_buffer_ptr where size would be that.

registered size as written in the comment means here the internally allocated size which has to be a multiple of the PAGE_SIZE for DMA reasons.
I could rename it to registered_size if that helps with your sized_buffer_ptr

Fixed in b5d7ff149be9729b77d64f60acfcba0a9a2969e5.


Allow required strings in the Reason field

Is your feature request related to a problem? Please describe.
A customer is requesting the ability to require a Jira ticket number in the reason field for requests. This better aligns with their record-keeping as to why an employee was requesting access to certain resources.
Describe the solution you'd like
Customer would like the ability to require ticket numbers like this: "DM-3222" or "TIX-1234" in the required reason field.  I believe regex would be the most likely solution, something like: [A-Z]{2,}-\d+
Describe alternatives you've considered
N/A
Additional context
Add any other context or screenshots about the feature request here.
IMPORTANT: Remember to select a label and project

You could make this work with the following setup:


add noCache header support

see helmet

Base on Amstel-Gold branch and PR back to it.
Look at how X-XSS-Protection is implemented and documented in the readme.md and follow suit


Update how-to-connect-sync-endpoint-api-v2.md

@RobdeJong : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Workspace hack

It should reduce CI times when compiling the entire workspace vs compiling a single package.

/ok-to-test sha=d2f9f02


Fix core dump.

Due to rounding errors we could end up in highly unlikely situation where we do not have left capacity to route.
Have a stat on that and return random zone in this case. We could potentially increase precision by using higher (than 10000) multiplier in calculations.

Change PR title/commit message to something descriptive.
Add test. If you need to factor stuff out into static helpers do that.


Southville International Schools and Colleges

@ohcyx First stage of verification passed, official domain is facebook.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.facebook.com/SISFUStudentCouncil/

@ohcyx Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

You can provide us with any of the following as the proof:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@ohcyx You might miss my previous comment. Please react.

@ohcyx I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Initial setup of repo structure

This PR adds the minimal ingredients to develop a simple Python package and build docs using the RTD-sphinx theme adapted to the IIASA design guidelines.

And now it even has a GitHub Actions workflow to make sure that the docs can be built...

Thanks @khaeru for the constructive comments...


Move back to setuptools?

https://peps.python.org/pep-0517/
https://peps.python.org/pep-0582/

Will likely go with Poetry.

#12


Websocket and Ingame API changes

I put together a quick first version.
Is this roughly what you had in mind?
Im unsure how to pass the payload-data to the user. Currently I just pass the raw json string through, without any parsing or validation.

If i had to be honest, i haven't used rust in a good few months so I am a bit rusty at it. But at first glance this looks pretty good. I dont remember exactly how WS events look but I was thinking of making a python/rust script to auto generate some structures for everything depending on the schema. We could possibly have the events deserialize into those structs.

I played around with the openapi schemas a little but I dont think auto-generation will work.
The "official" openapi.json you can get from the api /swagger/v3/openapi.json is incomplete and all the other schemas I found were incorrect.
For example the "end-of-game" api section is missing from the "official" schema.
And other schemas have incorrect versions of the "end-of-game" api section.
See https://www.mingweisamuel.com/lcu-schema/tool/#/Plugin lol-end-of-game/GetLolEndOfGameV1EogStatsBlock
vs
test_eog-stats-block

well thats fun.. We could look to see how other libraries handle this and figure out from there.

Instead of the WSClient::next_event() function I implemented the futures_util::Stream trait for the websocketclient, which provides the same functionality + some more.
I also sneaked in an EventStream struct for the ingame_api which polls the /liveclientdata api for you. If you prefer I can put it in a seperate pull-request.
From what I can find (via a quick google search) most lcu websocket libraries just return parsed json.
In python the obvious way is to provide a dictionary of the data e.g. https://lcu-driver.readthedocs.io/en/latest/quickstart.html#websocket.
In JS its the same but with a JSON object https://www.npmjs.com/package/league-connect
I found one C# library https://github.com/Ponita0/PoniLCU which also just returns a general JSON type.
So it seems like we will need to do something similar.
If we return a serde_json::Value (from serde_json) the user will have to use the serde_json crate, but if we dont and return a plain String the user will have to parse it anyways. So im currently leaning towards returning a serde_json::Value
What do you think?

yeah you can include it in this pr if you'd like. My last idea was using serde Value so ig we can use it.

also, what are your thoughts on switching from reqwest to hyper? seems to be a lot more lighter

Alright, I'll probably have the final commit for this PR ready tomorrow.
I did a little test of reqwest vs hyper polling /livegamedata/allgamedata and /livegamedata/eventdata each for about 60s every 500ms with:
use std::time::Duration;
use futures_util::TryFutureExt;

use tokio::time::Instant;

#[tokio::test]
async fn hyper() {
    let tls_connector = {
        let cert =
            native_tls::Certificate::from_pem(include_bytes!("../src/riotgames.pem")).unwrap();
        native_tls::TlsConnector::builder()
            .add_root_certificate(cert)
            .build()
            .unwrap()
    };

    let tokio_tls_connector = tokio_native_tls::TlsConnector::from(tls_connector);
    let mut hyper_http_connector = hyper::client::HttpConnector::new();
    hyper_http_connector.enforce_http(false);
    let connector = hyper_tls::HttpsConnector::from((hyper_http_connector, tokio_tls_connector));

    let client: hyper::client::Client<_, hyper::body::Body> = hyper::client::Client::builder()
        .pool_idle_timeout(None)
        .build(connector);

    let mut timer = tokio::time::interval(Duration::from_millis(500));
    loop {
        timer.tick().await;
        let now = Instant::now();
        let res = client
            .get(hyper::Uri::from_static(
                "https://<IP_ADDRESS>:2999/liveclientdata/eventdata",
            ))
            .await
            .unwrap();
        let status = res.status();
        let data = hyper::body::to_bytes(res).await;
        println!("{}: {}ms", status, now.elapsed().as_millis());
    }
}

#[tokio::test]
async fn reqwest() {
    let cert = reqwest::Certificate::from_pem(include_bytes!("../src/riotgames.pem")).unwrap();
    let mut headers = reqwest::header::HeaderMap::new();

    let client = reqwest::ClientBuilder::new()
        .add_root_certificate(cert)
        .default_headers(headers)
        .pool_idle_timeout(None)
        .build()
        .unwrap();

    let mut timer = tokio::time::interval(Duration::from_millis(500));
    loop {
        timer.tick().await;
        let now = Instant::now();
        let res = client
            .get("https://<IP_ADDRESS>:2999/liveclientdata/eventdata")
            .send()
            .await
            .unwrap();
        let status = res.status();
        let data = res.text().await.unwrap();
        println!("{}: {}ms", status, now.elapsed().as_millis());
    }
}

Maybe I missed some optimisation, but there doesnt seem to be a big difference (at least in terms of latency)
reqwest_vs_hyper1.xlsx
reqwest_vs_hyper2.xlsx
I havent checked out the size of the compiled binaries. Maybe its worth it for that reason

hmmmm.. I just read what sylv said in the riot dev's server and maybe ill rethink switching to hyper. Im going to practice a little bit of rust in the next few days since I have used it in a while and after fully review your changes!

I was a little bored on the weekend so I also added more exact types for the ingame API so the users of the library dont have to do as much "parsing" / "interpreting" or whatever you want to call it of the deserialized data
I also added some more tests.

Appreciate all the commits! I will probably add some CI to verify it all and possibly merge this weekend(?)

okay i cant figure out how to trigger CI on this pr so if you can do that it would be amazing

What do you mean by "trigger CI"?

cause it to run on your pr. You can do that by making a commit, you could probably create an empty commit and push that.

okay never mind ill fix the CI after i merge your pr

I tried to fix the rustfmt error and the clippy I saw in the CI results.
Maybe this helps :)

Other than that, Sylv got everything else I wouldve commented on. CI works now so after that last comment gets resolved I shall merge :)

Some docs would probably be good too, but I say we worry about that later

Thx, that "pub" was a copy and paste error.

Appreciate all of the work youve done!


libinput: 1.1.6 -> 1.1.8

@colemickens
libinput 1.1.8 is out

Thanks for catching that @codyopel. (How did you notice? Do you follow the ML? It seems the freedesktop.org page still doesn't list the new release.)
I've updated the commit to update to 1.1.8.

I think the build is fine, it's just taking too long and Travis is killing it. This should be safe to merge.

1.2.0 is just out today :-)

Updated

As nobody objects and it builds fine, I think we're should just merge. Thanks!


Block builds with incompatible API changes

As a developer I would like to see a failed build if the OpenAPI file is changed in incompatible way.

OpenAPI-diff can be used to compare PR provided API spec with main branch definition as it was detailed here: https://mindbyte.nl/2023/03/14/ensuring-api-compatibility-with-openapi-comparator-and-github-workflows.html


Ractive 0.8 - events not working inside sections

Check this fiddle: http://jsfiddle.net/df0huenp/2/
How can I make set and toggle to work?
I noticed that when I pass the context explicitly to the set event
on-click="set('object.capacity', '65')"
then it works as expected...

The set isn't connected to the template in any way, so it doesn't know the context. You can use `@keypath

Sorry, backtick - tab and R-shift - enter proximity strikes again.
Also... github now has reactions for comments?

Ahhh so it's
<EMAIL_ADDRESS>'65')"
and
on-click="toggle(@keypath+'.active')"
thansk @evs-chris


feat: Redesign SoraldAbstractProcessor to get more control over single repairs

This is related to #245 and #210
To address those issues, we need more control over single repairs, and in particular, only attempting one repair for each violation. This PR fixes just that.
SoraldAbstractProcessor now implements the Spoon methods process and isToBeProcessed, and they are final (meaning that concrete processors are not allowed to override them). Instead, the concrete processors implement canRepair and repair. These are almost identical to the old process and isToBeProcessed methods, except that processors no longer need (or should) call super.process() and super.isToBeProcessedAccordingToStandards(). This reduces code duplication, and also gives SoraldAbstractProcessor a lot more control over each repair. This alone allows us to address #210, and it will help in addressing #245 with a general solution (i.e. without fiddling in the individual processors). It also makes implementing new processors less error-prone, as the only two methods that need to be implemented (canRepair and repair) are abstract, and so cannot be missed.
Another side effect of this is that I found a processor, UnclosedResourceProcessor, that actually relied on being able to process each violation multiple times, thus inflating the amount of repairs it claimed to perform. In a test case with 3 violations, it reported 8 repairs. That effectively makes this PR a feature change, as end-user experience is affected, even though the majority is a refactor.

FYI I will be making more changes to how this works, but they require also adapting several of the processors. So I think this PR is a good first step.

So I think this PR is a good first step.

It is. Thanks for it!


All values in #TempDB_Files_SpaceUsage for templog.ldf is null

Hi, your script was exactly what i was looking for to understand the working of Tempdb. recently ran into the issue of the log file becoming full twice in a single day.  When i ran the script all the values in the table #TempDB_Files_SpaceUsage for templog.ldf was showing null except for the first 3 columns

Hello, glad it helps! if you could post a screenshot showing what exactly is missing, that would be great

Hi, your script was exactly what i was looking for to understand the working of Tempdb. recently ran into the issue of the log file becoming full twice in a single day. When i ran the script all the values in the table #TempDB_Files_SpaceUsage for templog.ldf was showing null except for the first 3 columns

Hello, glad it helps! if you could post a screenshot showing what exactly is missing, that would be great

@GovindRulz  Hi, let me know if you have additional details for this issue requested above, I'll wait until end of next week, and then close the issue if no updates, Thanks!


REVIEW mb/fixElectrodeArray

A few improvements for the ElectrodeArray class and some helper functions. Most of these are already being used in my experiment branches in one form or the other, but are now also tested and integrated. So the purpose of their existence is mostly to make my life easier. 😸
Argus I arrays now support legacy naming (L1, L2, ..., L8, M1, M2, ..., M8).
The electrode-to-retina distance depends on electrode type and electrode location. This computation has been moved to Electrode.set_height so that heights can be overridden.
Keeping track of electrode names in ElectrodeArray.names is redundant, because every Electrode has a name itself. Setting custom (or new) names would have to be done in both places, otherwise indexing might break. Therefore, I removed ElectrodeArray.names. In order to do the indexing, the loop has to be over name of every Electrode in an ElectrodeArray. In order to speed up the average lookup time, the array is traversed in random order.
The parameter tol of pulse2percept now specifies a fraction instead of an absolute value: For example, tol=0.1 will discard all pixels whose effective current is <10% of the max effective current value.
I also added a helper function that can find files in a directory whose names match a regular expression pattern.

Coverage increased (+1.3%) to 87.325% when pulling 895c6f1b015edbb62c8d12e09f36eefbf03af8b6 on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.

Coverage increased (+1.3%) to 87.325% when pulling 4ad631c233b6429a044854518e742da26f101638 on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.

Coverage increased (+1.4%) to 87.396% when pulling ffc54c189daac02dfc92a376acde649f29dbd01b on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.

Coverage increased (+1.4%) to 87.396% when pulling 5745b4d99b6c39ddcac79d9b5a677492ca8f4837 on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.

Coverage increased (+1.4%) to 87.42% when pulling df9a772007ccefe55d644850ee112b5bd5b5476e on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.

Coverage increased (+1.4%) to 87.42% when pulling d8da8c605e360b18a894db70582b6105382bea07 on mbeyeler:mb/fixElectrodeArray into a890ad0491bc3eeba6c16e38c74a6f831bff70d8 on uwescience:master.


Fix actor example output

Signed-off-by: Bernd Verst<EMAIL_ADDRESS>Description
The demo actor example test using mechanical markdown appears to be broken because the test was originally written against incorrect output which has since been fixed in the sidecar.
This change should also be cherry picked into the release branch, but does not require a new RC.

Interestingly in CI this behaves differently from my local Mac.

Seems to be unnecessary -- likely caused by persistent test data locally


[sitecore-jss-react] Allow defer prop on VisitorIdentification component

Add support for the defer prop to the VisitorIdentification component to support non-blocking script loading.

This attribute allows the elimination of parser-blocking JavaScript where the browser would have to load and evaluate scripts before continuing to parse. async has a similar effect in this case.

Description / Motivation
Opt-in to make VisitorIdentification non-blocking.
Testing Details
Component does not have any tests.
Setting defer to true will render <script defer ...></script>.
Setting defer to false or undefined will render <script ...></script>.
Making the prop optional makes this a non-breaking change.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer @sc-addypathania some feedback on this would be appreciated :)

Thanks @ambrauer 🙏🏼


Problem when send batch with compression

Hello, when i send compression like in the example using diferents compressions(gzip, brotli)
ClickHouseStatement sth = connection.createStatement();
sth
.write()
.sql("INSERT INTO default.my_table (a,b,c)")
.data(new MyCustomInputStream(), ClickHouseFormat.JSONEachRow)
.dataCompression(ClickHouseCompression.brotli)
.addDbParam(ClickHouseQueryParam.MAX_PARALLEL_REPLICAS, 2)
.send();
i get the next error
inflateReset failed: data error. (ZLIB INFLATE FAILED)
I tried to change the compression level of zlib but nothing
I don't quite understand why it uses zlib if I mark as gzip compression. But apart from that I can't get it to insert any element into the database when I indicate the type of compression

Your data needs to be compressed before sending to server. If your input stream is just about plain text, can you comment data compression part and see if it will work?

inflateReset failed: data error. (ZLIB INFLATE FAILED)

very old CH ? select version()

maybe the problem is your CH version?,please check it

My version of clickhouse is v<IP_ADDRESS>-stable, the last version i think.
i am trying with compress the stream using
ClickHouseConnection con = new ClickHouseConnectionImpl(clickhouseConfig.getUrl());
st = con.createStatement();
wri = st.write()
.addDbParam(ClickHouseQueryParam.ENABLE_HTTP_COMPRESSION, enableHttpCompression)
            .dataCompression(ClickHouseCompression.valueOf(compression))
            .table(nameTable)
            .format(ClickHouseFormat.JSONEachRow);

wri.data(new GzipCompressingEntity(new InputStreamEntity(stream, -1)).getContent()).send();
But it dont work.
if I try to send the stream without compression, it works as expected.
I have also tried putting in the url jdbc: clickhouse: // localhost: 8123 / {name.db}? Decompress=1 but it doesn't insert anything into the database either.
I have also tried to compress using this syntax
GZIPInputStream gz = new GZIPInputStream (stream);
                wri.data (gz) .send ();

But dont work. the configuration that I am using is
url: "jdbc:clickhouse://<IP_ADDRESS>:8123/test"
nameTable: "con"
httpCompression: "gzip"
enableHttpCompression: "true"


How to enable EKS pod identity addon?

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.
At the moment there is no example in the repository of how you can enable and start using EKS pod identity addon.
Describe the solution you'd like.
Add examples of how to deploy it to the documentation
Additional context

https://docs.aws.amazon.com/eks/latest/userguide/pod-id-agent-setup.html
https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity

what example do you need exactly?

@bryantbiggs,
For example, this function is used to enable coredns.
  cluster_addons = {
    coredns = {
      most_recent = true
    }
}

Which one should be used and with what parameters to enable EKS pod identity?

You just specify the name of the EKS addon you wish to control:
  cluster_addons = {
    eks-pod-identity-agent = {
      most_recent = true
    }
    <addon-name> = {
      ...
    }
  }

@bryantbiggs
Understood thanks.
Are any additional settings required for this addon? For example, attach a role?


Add ERC20 approval+transferFrom mechanism to detect failed transfer

Alternative proposal to #75

Chosen solution is to use documentation to let developers know to be careful.


need to update bindgen for dependencies

I run cargo audit as part of my build pipeline. It spit out an error today:
 cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 592 security advisories (from /usr/local/cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (217 crate dependencies)
Crate:     shlex
Version:   1.2.0
Title:     Multiple issues involving quote API
Date:      2024-01-21
ID:        RUSTSEC-2024-0006
URL:       https://rustsec.org/advisories/RUSTSEC-2024-0006
Solution:  Upgrade to >=1.3.0
Dependency tree:
shlex 1.2.0
├── bindgen 0.69.2
│   └── fdb-sys 0.4.0
│       └── fdb 0.4.0
│           └── fdblibrs 0.1.1
└── bindgen 0.65.1
    └── foundationdb-sys 0.8.0
        └── foundationdb 0.8.0

Thanks for the report! I will bump all dependencies and add a weekly report of cargo audit :smile:


Check document folder safety rating

Gnome software seems to show this, so it seems like I've missed that part?

Seems like we need to do this whole handling https://gitlab.gnome.org/GNOME/gnome-software/-/blob/main/plugins/flatpak/gs-flatpak.c#L319

Implemented in #1942


teamviewer: 15.2.2756 -> 15.5.6

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/teamviewer/versions.
meta.description for teamviewer is: "Desktop sharing application, providing remote support and online meetings"
meta.homepage for teamviewer is: "http://www.teamviewer.com"
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 15.5.6 with grep in /nix/store/by5j0bhxv3m8pkyn565lxg7f4mmlghrs-teamviewer-15.5.6

directory tree listing: https://gist.github.com/26fc419a5b142db8b83bc8ed699e6921

du listing: https://gist.github.com/d8e8378ddd86f9717e315a0262d31ffd

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
teamviewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/by5j0bhxv3m8pkyn565lxg7f4mmlghrs-teamviewer-15.5.6 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A teamviewer https://github.com/r-ryantm/nixpkgs/archive/c8c1441fb70774b6295f8b1352076f01a0e8f163.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/by5j0bhxv3m8pkyn565lxg7f4mmlghrs-teamviewer-15.5.6
ls -la /nix/store/by5j0bhxv3m8pkyn565lxg7f4mmlghrs-teamviewer-15.5.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- teamviewer

Maintainer pings
cc @jagajaga for testing.

Fails to run on Ubuntu 18.04.
[nix-shell:~/.cache/nixpkgs-review/pr-89031]$ teamviewer

Init...
CheckCPU: SSE2 support: yes
Checking setup...
Launching TeamViewer ...
Launching TeamViewer GUI ...
Aborted (core dumped)

[nix-shell:~/.cache/nixpkgs-review/pr-89031]$ teamviewer info

 TeamViewer                           15.5.6  (DEB)

 TeamViewer ID:
Try restarting the TeamViewer daemon (e.g. teamviewer --daemon restart)

 teamviewerd status                   ● teamviewerd.service - TeamViewer remote control daemon
     Loaded: loaded (/etc/systemd/system/teamviewerd.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2020-03-23 18:25:40 EDT; 2 months 8 days ago
   Main PID: 2539 (teamviewerd)
      Tasks: 21 (limit: 4915)
     CGroup: /system.slice/teamviewerd.service
             └─2539 /opt/teamviewer/tv_bin/teamviewerd -d

Warning: some journal files were not opened due to insufficient permissions.

Doesn't launch with teamviewer on Ubuntu 18.04, likely due to graphical issues I've had with GUI apps before.

Confirming that. I can run teamviewer with nixGL (nixGLIntel in my case): https://github.com/guibou/nixGL#usage.


Add badges with deepscan, ci status, prettier,snyk

Coverage remained the same at 96.639% when pulling a800a317b5b000fa61791e5c01d4d747a3e27b9c on badg into 9f1343ba915c3fc226fb9011a6d3a0647f56ddcf on main.


Fix persistent changes bug and validation error problems patch

Overview
This PR includes the following proposed change(s):

https://github.com/bcgov/invasivesbc/issues/651

Fixed the main bug (in the first 15 minutes, surprisingly), but then noticed some follow-up bugs which (inevitably) arose from it...
Long-story short, there is only one possible configuration here which gets roughly the behavior we want:  if a field is required, then we disable the ability to clear (make blank) the field once it has been selected (by pressing the little X button) because validation will not correctly read that and throw an error on blank inputs - allowing empty form fields.  That would be bad.
Meanwhile, since non-required fields might still want to be blank (e.g. when the person changes their mind and would rather say nothing than an answer they're not confident in) then we re-enable the ability to clear, and it doesn't matter that the validator doesn't catch it because it's not required.
Underlying problem still foreboding: is the validator actually noticing when the selected value is not one of the allowed options?  I'm guessing no right now, but not seeing how that could cause a breaking state... for now.  But this will rise again if/when there's some extra custom validation we need to trigger on an autocomplete field :)  My deepest hope is that when that time comes, another developer will stumble upon this old PR and say "hah, you were right Warren!
Lest we forget.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Locally
Screenshots
Please add any relevant UI screenshots if applicable.
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have made corresponding changes to the documentation
[X] New and existing unit tests pass locally with my changes

Hilarious.  Let's try it and see how it works.

from the android failure:
<EMAIL_ADDRESS>Attempted import error: '__spreadArray' is not exported from 'tslib'


fix(cdk): TuiTime.shift doesn't shift higher order units

Fixes #9817

Does it need to be backported to v3.x?

@reverie3 sure

https://github.com/taiga-family/taiga-ui/pull/10082


One letter usernames not detected

I have a user who signed up to my app with a one letter username. Wherever their username (@l) is found, it does not get detected by ActiveLabel. Is there a configuration option for min username length? Thanks!

Not sure, but I saw minLength somewhere is 2. Can you please test with 2 characters to see if it works?
As a side note, it is best practice to have minLength for the username on your backend plus some reserved names :)


⚠ PrivateHD has degraded performance

In 8ca7efc, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1458 ms

Resolved: PrivateHD performance has improved in 11ccaad.


[C API] WASI hostcalls crash when lucet-runtime and lucet-wasi are linked dynamically

... and possibly statically, but I haven't checked yet.
The problem is that the thread-local variable CURRENT_INSTANCE, defined in lucet-runtime-internals, ends up appearing in both liblucet-runtime.so and liblucet-wasi.so, but at distinct addresses. So, the lucet-runtime side sets the variable appropriately when entering Wasm, but then the hostcalls implemented in lucet-wasi try and fail to get the current instance from lucet-wasi's copy of the variable. Panic.
Hopefully there's something clever we can do with linking to get around this, because both libraries have to depend on lucet-runtime-internals, and CURRENT_INSTANCE has to be defined in that crate so that the signal handler can reference it. We solved similar problems in the past with exported C function symbols by moving all of the pub extern "C" fns into lucet-runtime, which lucet-wasi does not depend on, but doing the same trick with this TLS variable is going to be difficult.

Has  there been any progress with this issue, or did you find any sort of workaround?

Documenting for others. Workaround @enjhnsn2 and I have been using is to create a new rust library project with dependencies to the lucet libraries and outputting a single shared library with all symbols
Cargo.toml contains
authors = ["FILL_IN"]
edition = "2018"
license = "MIT"

[dependencies]
lucet-wasi = { path = "../lucet-wasi" }
lucet-runtime = { path = "../lucet-runtime" }
lucet-runtime-internals = { path = "../lucet-runtime/lucet-runtime-internals" }
lucet-module = { path = "../lucet-module" }

[lib]
name = "lucet_fullrt"
crate-type = ["rlib", "staticlib", "dylib"]

lib.rs contains a function ensuring linking
pub fn ensure_linked() {
    lucet_runtime::lucet_internal_ensure_linked();
    lucet_wasi::export_wasi_funcs();
}


Build a CI pipeline for this project

A CI Pipeline using GitHub actions should be built that at least executes the unit test on each pull request created.

I was thinking initially of something simple, like this:
name: Jodie CI
on:
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v3
    - name: Set up JDK 8
      uses: actions/setup-java@v3
      with:
        java-version: '8'
        distribution: 'temurin'
        cache: 'sbt'
    - name: Run tests
      run: sbt test

This is merged 😎


Add write-up for challenge 4c

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.