[Task]: Identify the choreo samples where complex configurables are present which results in configuration form generation with unsupported configurables

Connector Name
other (None Listed Above)
Task Description
Identify the choreo samples where complex configurables are present which results in configuration form generation with unsupported configurables.

We have identified the samples where complex configurables are present which results in configuration form generation with unsupported configurable. Relevant issues are pointed in the sheet itself.
https://docs.google.com/spreadsheets/d/1Xa8vluggZZsr9a6mvs2HIZNliW3FNHcV-8um_HL2gp4/edit?usp=sharing


Fix issue of tracing.SetupDynamicPublishing

Changes

:bug: Add tracing.SetupDynamicPublishingWithInitialValue to apply tracer config

Fixes #2557

The downstream tests shows this change breaks the API.
My recommendation would be to create a new constructor ie. SetupDynamicPublishingWithDefault  (or something better)

Thank you. I think it's a good suggestion and I will submit a new version.

/override downstream-tekton

/assigh @dprotaso
I think "downstream-tekton" could be override since it is caused by tekton using the old pkg version.

/lgtm
/approve


Failed to resolve: org.jetbrains.compose.runtime:runtime:1.2.0-alpha01-dev764

I get this error when trying to use this library.
implementation "com.halilibo.compose-richtext:richtext-ui-android-debug:0.14.1"
edit: 0.13.0 worked for now.

Also experiencing this issue

If you're using a reasonably current version of Compose and this problem is isolated to your Android configuration then it's likely you already have the AndroidX Compose runtime in your dependency configuration, so you might want to declare the library dependency like this:
// note I used richtext-commonmark here, but use whichever you require
implementation("com.halilibo.compose-richtext:richtext-commonmark:0.14.1") {
    exclude(group = "org.jetbrains.compose.runtime")
    exclude(group = "org.jetbrains.compose.foundation")
}

Can confirm this works with no runtime issues for Compose version 1.2.1 and 1.3.0-rc01


ETA on OtterHD-8B weights

Hi, any time estimate on when the weights will be available?
Thanks!

I would say will not be very soon, probably after CVPR ddl. We then have time and GPU to do some experiments we think important. We wish to release the model then. I guess it's around late Nov to Dec.

Thanks for the info. I'll close the issue.

Awesome work! Would love to get access to the model's weights + inference/demo script :)


fuzz IL compiler another no bad choice

I updated some code to adopt the latest fuzzilli
http://github.com/areuu/ilcompiler
using ocaml 4.14.0, flow_parser 0.192.0

Thanks for that! There is now also a different, supported compiler in Fuzzilli: https://github.com/googleprojectzero/fuzzilli/commit/807625f0112df22bfe293aa4d36d67c31c4fb243 which should be easy to extend


Dgan notebook patch

Update config name to time-series.yml. Rename DoppelGanger to DoppelGANger

Sorry, wrong branch


Add armi-example-app submodule back in.

What is the change?
Add armi-example-app submodule back in.

Why is the change being made?
It is still used in documentation builds.
It was removed in dac69790bf325f9701595f020cd388dc817ea30f probably accidentally as part of a cleanup.
Fixes #1490

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[x] The documentation is still up-to-date in the doc folder.
[x] No requirements were altered.
[x] The dependencies are still up-to-date in pyproject.toml.

Apparently, I removed this submodule during a completely unrelated parameter PR.
I see no comment about it in the PR and it is entirely unrelated.
As I don't remember doing that, I must conclude that it was some bizarre error. Happy to add it back in.


Argv

capture exception rather than parsing stderr

Props to @mustafaquraish for the ideas on how to solve this (just wanted to put this in the record)

Looks good to me, do we need additional reviewers (e.g. @mustafaquraish ) or shall we merge?

Feel free to merge if you think it's right, but I might wait for more reviews since it's the core of our app.

Haven't pulled and tested this, but the code looks fine to me. We can merge this if 3verythings working.


Cleanup deprecated and obsolete properties in StreamFunctionProperties

Hello!
in this commit, StreamFunctionConfigurationProperties is auto-configured instead of StreamFunctionProperties.
However, Stream Function Configuration Properties only works with the "bindings" block. How is "spring.cloud.streamfunction.definition"" being read from the application.yml file now?


Added doctrine mappings for Project aggregate

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
#164

License
MIT

@benatespina Requires rebase


Fixed #29026 -- Added --scriptable option to makemigrations.

ticket-29026 desires to separate logging from a simple list of filepaths created in makemigrations.

Today, there is logging to both stdout and stderr (for errors), but no real "program output": the filenames are bolded and indented to flow between other log messages.
This PR creates a new option --scriptable that will 1. divert all current logging to stderr and 2. log only the filepaths of created migration files to stdout, one per line (without leading spaces and styling)
--noinput mode is still necessary to suppress input completely, otherwise interactive prompts go to stderr when --scriptable is used

EDIT: moved ticket-29470 solution to #14805
All of this logging can be silenced with --verbosity 0: no changes in this respect.

The thing with structured is that text lines aren't that structured. To me that sounds more like json.

Very reasonable--I'll think about a name for this option.

It seems like the user-facing option should be more about whether logging should go to stderr. Then the non-logging ("output") lines would continue to go to stdout as is.

My thought process was this: merely switching the output to stderr is achievable today: you simply subclass the command and set self.stdout to whatever you want, sys.stderr, or whatever. I'm not sure we would add complexity if that were the only thing we were achieving. I think the reason for this PR is that we don't have any "non-logging/output" lines today, since this is not really nonlogging (leading spaces, hyphen, colors):
\x1b[1m/var/folders/6q/jljmh5xs27v8_7557q3rgtfw0000gn/T/django_klnxitjw/tmpwiefzufk/tmp82ptgwlr/migrations/0001_initial.py\x1b[0m\n

My thoughts would be to add an initial commit that adds a log() method and makes all stderr / stdout output go through that.

So I'm a little hesitant to do to this, because then we're making makemigrations more special than the other commands. This ticket is asking to make makemigrations more special by producing different kinds of output, so I guess we're already starting down that path.

Also, in the case that logging is going to stderr, I think you'd still want to log the output lines using log() as a message, so that info would be available both in the diagnostic stderr logs, as well as the output.

Agreed, I made sure this was the case.

Any thoughts on the ticket-29470 stuff? If we have design questions about ticket-29026 I could ask the fellows to re-triage 29470 and move it to a separate PR to keep it moving.

btw, thanks for the review, @cjerdonek! And it looks like I need to liberalize one of the tests to pass on Windows.

Maybe --separatelogs?
Everything but the last line going to stderr, last line to stdout:
Migrations for 'migrations':
  /var/folders/6q/jljmh5xs27v8_7557q3rgtfw0000gn/T/django_e_o35bow/tmpso0994dn/tmp7ogni0kc/migrations/0001_initial.py
    - Create model ModelWithCustomBase
    - Create model SillyModel
    - Create model UnmigratedModel
/var/folders/6q/jljmh5xs27v8_7557q3rgtfw0000gn/T/django_e_o35bow/tmpso0994dn/tmp7ogni0kc/migrations/0001_initial.py

you simply subclass the command

This didn't feel right when I wrote it, and indeed--it's easier than that, there's call_command(stdout=), see: https://docs.djangoproject.com/en/3.2/ref/django-admin/#output-redirection
The drift of my earlier comment was that I would be hesitant to rework the documented API we have for that. I see the issue as more defining wanting separate logs, period.

To respond to one point now:

My thoughts would be to add an initial commit that adds a log() method and makes all stderr / stdout output go through that.

So I'm a little hesitant to do to this, because then we're making makemigrations more special than the other commands.

I think making log() a method that is passed a message is more natural and has advantages over making it an attribute with a write() method. For example, it would give people a way to use a Python logger instead of writing to a stream. This is the approach taken in this commit for ticket #14150. Also, the word "log" is more commonly used in Python as the verb / method name rather than the stream (see e.g. Logger.log() in Python's logging module). It would also make the calling sites simpler / cleaner. Finally, if this pattern is found useful, it could be moved to BaseCommand so makemigrations.py wouldn't be so special.

Also, the word "log" is more commonly used in Python as the verb / method name rather than the stream (see e.g. Logger.log() in Python's logging module).

I have to admit, this did occur to me when I was writing it, and if you also noticed it, lots of folks will. :-O

For example, it would give people a way to use a Python logger instead of writing to a stream. This is the approach taken in this commit for ticket #14150.

That's a good reason.

Finally, if this pattern is found useful, it could be moved to BaseCommand so makemigrations.py wouldn't be so special.

I guess I wasn't looking at it that way. 👍🏻    Thanks for the quick feedback, and I'll have a look at implementing a log() method.

Maybe --separatelogs?

Maybe --scriptable or --scriptmode? The option seems like a higher-level mode as it does two things: it changes logging to go to stderr, and it adds additional info to stdout.

Maybe --scriptable or --scriptmode?

At a glance, I would be a bit worried it implies setting --noinput can be skipped when using in a script.

At a glance, I would be a bit worried it implies setting --noinput can be skipped when using in a script.

I think there's an argument the mode should imply --noinput. The reason is that, when programmatically consuming the stdout (e.g. piping it to a file), you wouldn't see the prompt anyways. (It would show up to the user as a hang.) This is because the command's questioner uses Python's input() built-in, which writes to stdout. So it seems incompatible with consuming stdout for programmatic use. Maybe you could write a prompt to stderr, but that seems non-standard.
Either way, I think you'd want to document in the help whether --noinput is implied, which should eliminate any worries.

Reading and thinking more about Python's input() and how --noinput behaves, I think the scriptable mode option we're discussing in this PR shouldn't default to --noinput, and when it's used, the questioner should write its prompt to stderr instead of stdout (and not use log()). There are a couple reasons for the latter. First, there is a very old Python ticket to change input() to use stderr, so it wouldn't actually be non-standard to use stderr like I suggested in my comment above. Secondly, if the mode didn't use stderr, then there would be no way to use scriptable mode while capturing the output stream (one of its intended use cases) when answers are required that differ from the default answers when --noinput is used. Lastly, I said "not use log()" because if someone, say, changed log() to log to a file, you would still want the prompt to go to stderr so the user could provide interactive feedback.
Also, on this question:

Any thoughts on the ticket-29470 stuff?

After reading and thinking about it, I think it should be re-opened and handled separately. I can go ahead and add a comment to the ticket.

Hello @francoisfreitag -- I noticed you have a WIP branch for ticket-21429 implementing logging for each of the management commands. As you can see above, Chris is making the good case that to move this PR forward, I should do something similar for makemigrations. Are you still interested in contributing your work? If #13853 is the only blocker, we can see about getting it into the review queue. Let me know if I can be helpful in any respect. 👍🏻

@jacobtylerwalls By the way, regarding the log() method I was suggesting you add above, the collectstatic management command is another class that already has a method like that: https://github.com/django/django/blob/8208381ba6a3d1613bb746617062ccf1a6a28591/django/contrib/staticfiles/management/commands/collectstatic.py#L207-L212
It will be of help here independent of that ticket.

Hi @cjerdonek,
Thanks for the ping! Fixing ticket-21429 is pretty time consuming and personal life has been busy (and will be for at least a few months). My employer is not interested in sponsoring the work for now, so it’s all on my personal time.
Basically, my todo list includes:

rebasing on main (last rebase was probably 9 months ago)
a readthrough, making sure:

assertNoLogs and assertLogRecords are used where possible
reviewing uses of io, StringIO, stdout and stderr in test code
code polish (e.g. grouping context managers, preferring single quotes, f-strings, etc)

consider introducing flake8-logging-format
installing my branch on an existing project shows unexpected line returns if I don’t change the existing project config. Needs investigation.
Completing the documentation
Testing against all DBs. I tried to use exact assertions for the logging output as much as possible, but different DB engines or configuration may cause messages to change slightly.

#13853 is just a very early step, introducing tools I would like to use for the logging PR. I’m afraid there are weeks of work remaining before my branch can be put up for review, and I am not able to commit to a timeline.

Thanks for the update. I certainly wouldn't ask you to commit to a timeline! I was just merely curious if I should try to conform to any likely pending changes. I think I have enough to go on for now. Good luck with everything, and be well. --Jacob

Thanks for the design guidance @cjerdonek , that was very helpful. I haven't squashed/reordered commits yet, and I am still thinking about https://github.com/django/django/pull/14751#discussion_r684664382, but I wanted to ask if you thought these changes were looking right-track to you. I'd be grateful if you had time for a re-review.
I didn't as of yet tackle a refactor of how verbosity is tracked. There's enough going on (and I feel like this PR is already two or so.) Speaking of which, thanks for commenting on ticket-29470.

The first one I'd recommend is a refactoring PR that just adds a log() method, and in particular doesn't make any reference to scriptable, etc. The next step PR can be discussed after that.

Done! :tada:
https://github.com/django/django/pull/14936

Summary:
Adds --scriptable flag to makemigrations, causing:

log() method to divert output to self.stderr (agreement on this here: "whether log() uses stderr or stdout could be controlled centrally in that method")
Interactive questioner to divert prompts to self.stderr (agreement here)
an additional line of "clean output" (no styling or indentation) written to self.stdout (original case from ticket)

That's all the diff does, it's just bloated because the interactive questioner was using print() statements, which had to be rewritten. I can move that to another commit (or PR?) if folks like.
Could also be good to rebase after #15212.

@jacobtylerwalls Thanks :+1:
I added writing a path of generated migration file to the --merge option (with tests) and pushed small edits.

@felixxm Thanks for the updates and the additional test!


Add max length for Rust library.

#190

@drinckes PTAL, first time writing Rust so let me know if there's a more idiomatic way to do this :).

Yeah, this is about the total of my Rust experience as well. I'm going to say LGTM but if anyone else would like to take a look that would be great.
(Maybe give it a couple of days to give anyone a chance, then merge.)

Leave me alone I've been the target, it's time to move on.

I'm protected by the precious blood of the lamb, Jesus Christ my Lord and saviour. In jesys name I command you all to stop right now. Quit trying to locate me, leave me alobe.


WIP: Test focal

I have credit issues when trying to rerun the travis build. Therefore I create merge request to rerun the build

Ok open merge request doesn't trigger the build again. @m-naumann do you have enough credit to retrigger the travis build? I pushed new commits https://github.com/coincar-sim/mrt_cmake_modules_ci/commit/f885650d55aac016b92184f77c759bcfa4f80c94 and want to test the build again

It seems that the current credits for this project has exceed its limit: https://travis-ci.com/organizations/coincar-sim/plan, which means we can not trigger any builds anymore unless we pay. However, switching to github actions for https://github.com/coincar-sim/mrt_cmake_modules_ci and all related project needs somehow decent effort. @eduardo-molinos maybe we should do this together


RKE_Kanadarm works on 1.0.2 - 1.0.4

Netkan.exe is currently too insistant on using the embedded AVC file.  This adjusts the versions somewhat.

I know not why jenkins says it can't find a working area. I hope this is just because I've confused it with my rebasing and git-fu.
Here's what I get locally:
$ ckan.exe show RKE-Kanadarm
RKE Kanadarm: A set of Canadarm2 look-alike parts, for building your own robotic arms. Includes rotating joints, latching end effector and grapple fixture.

Module info:
- version:	0.11.0
- authors:	spudbean
- status:	stable
- license:	CC-BY-4.0

Provides:
- RKE-Kanadarm

Resources:
- homepage: http://forum.kerbalspaceprogram.com/threads/112881
- kerbalstuff: https://kerbalstuff.com/mod/637/RKE%20Kanadarm
- repository: https://bitbucket.org/spudbean/rke_kanadarm/

Filename: 861E3839-RKE-Kanadarm-0.11.0.zip

Showing 47 installed files:
- GameData/RKE_Kanadarm
- GameData/RKE_Kanadarm/changelog.txt
- GameData/RKE_Kanadarm/Flags
- GameData/RKE_Kanadarm/Flags/RKE.png
- GameData/RKE_Kanadarm/LICENSE.txt
- GameData/RKE_Kanadarm/MM
- GameData/RKE_Kanadarm/MM/ConnectedLivingSpace.cfg
- GameData/RKE_Kanadarm/MM/RasterPropMonitor.cfg
- GameData/RKE_Kanadarm/Models
- GameData/RKE_Kanadarm/Models/arm075.mu
- GameData/RKE_Kanadarm/Models/arm100.mu
- GameData/RKE_Kanadarm/Models/arm200.mu
- GameData/RKE_Kanadarm/Models/armring.mu
- GameData/RKE_Kanadarm/Models/arms-color.mbm
- GameData/RKE_Kanadarm/Models/arms-nrm.mbm
- GameData/RKE_Kanadarm/Models/elbow.mu
- GameData/RKE_Kanadarm/Models/fixture-color.mbm
- GameData/RKE_Kanadarm/Models/fixture-nrm.mbm
- GameData/RKE_Kanadarm/Models/fixture.mu
- GameData/RKE_Kanadarm/Models/fixtureplate.mu
- GameData/RKE_Kanadarm/Models/flagblock.mu
- GameData/RKE_Kanadarm/Models/lee-color.mbm
- GameData/RKE_Kanadarm/Models/lee-nrm.mbm
- GameData/RKE_Kanadarm/Models/lee.mu
- GameData/RKE_Kanadarm/Models/misc-color.mbm
- GameData/RKE_Kanadarm/Models/misc-flagquad-nrm.mbm
- GameData/RKE_Kanadarm/Models/misc-nrm.mbm
- GameData/RKE_Kanadarm/Models/rotor.mu
- GameData/RKE_Kanadarm/Models/rotor_color.mbm
- GameData/RKE_Kanadarm/Models/rotor_nrm.mbm
- GameData/RKE_Kanadarm/Models/spacer.mu
- GameData/RKE_Kanadarm/Parts
- GameData/RKE_Kanadarm/Parts/arm075.cfg
- GameData/RKE_Kanadarm/Parts/arm100.cfg
- GameData/RKE_Kanadarm/Parts/arm200.cfg
- GameData/RKE_Kanadarm/Parts/arm400.cfg
- GameData/RKE_Kanadarm/Parts/arm600.cfg
- GameData/RKE_Kanadarm/Parts/elbow.cfg
- GameData/RKE_Kanadarm/Parts/lee.cfg
- GameData/RKE_Kanadarm/Parts/pdgf.cfg
- GameData/RKE_Kanadarm/Parts/rotor.cfg
- GameData/RKE_Kanadarm/Parts/rotor2.cfg
- GameData/RKE_Kanadarm/Parts/spacer.cfg
- GameData/RKE_Kanadarm/readme.txt
- GameData/RKE_Kanadarm/RKE_Kanadarm.version
- GameData/RKE_Kanadarm/Sounds
- GameData/RKE_Kanadarm/Sounds/motor.ogg
``

And also this:
{
    "spec_version": "v1.4",
    "identifier": "RKE-Kanadarm",
    "install": [
        {
            "find": "RKE_Kanadarm",
            "install_to": "GameData"
        }
    ],
    "name": "RKE Kanadarm",
    "abstract": "A set of Canadarm2 look-alike parts, for building your own robotic arms. Includes rotating joints, latching end effector and grapple fixture.",
    "version": "0.11.0",
    "author": "spudbean",
    "download": "https://kerbalstuff.com/mod/637/RKE%20Kanadarm/download/0.11",
    "license": "CC-BY-4.0",
    "resources": {
        "homepage": "http://forum.kerbalspaceprogram.com/threads/112881",
        "repository": "https://bitbucket.org/spudbean/rke_kanadarm/",
        "kerbalstuff": "https://kerbalstuff.com/mod/637/RKE%20Kanadarm",
        "x_screenshot": "https://kerbalstuff.com/content/spudbean_1469/RKE_Kanadarm/RKE_Kanadarm-1426049566.8197534.jpg"
    },
    "ksp_min_version": "1.0.2",
    "ksp_max_version": "1.0.4",
    "download_size": 2101085,
    "x_generated_by": "netkan"
}

So... I'm going to kinda pretend that I'm the bot giving a thumbs up and merge this, which will make spudbean's users happy, especially Scorp. :)

Jenkins failed because there's no ksp_version (it takes ksp_version and places that in the readme.txt).

I think the new build script caters for that scenario.


[PE-D][Tester E] Editing doesnt reflect changes

Steps to reproduce
I'm not exactly sure, this only happens sometimes
Expected
Name should change in the GUI
Actual

Editing the name to 132 doesn't change the name in GUI. The previous command was "edit 14 n/132" or "edit 15 n/132"

Labels: type.FunctionalityBug severity.High
original: xiaorui-ui/ped#8

Tested out, editing name to 132 almost immediately changes the name in the GUI. Most likely a slip up by tester.


Updating FontAwesome to 4.7?

It seems to me that concrete5 v8 comes with FontAwesome version 4.5.
What about updating it to 4.7?

Makes sense, would be nice to have.


rest call to /open-metadata/admin-services/users/{userId}/configurations never returns anything

rest call to /open-metadata/admin-services/users/{userId}/configurations never returns anything.
The reason appears to be that the logic was no updated when we moved the server configs out of the top folder. It is looking in the current top folder for a match on a pattern of "data/servers/{0}/config/{0}.config". This template is looking to identify a file deeper than the current folder. A complexity also is that this filename is overridable, so the fix needs to handle that.

I did make a move to where we store configs last year....
The principle was to store all transient data under 'data', relative to the current working directory of the process (platform). This made it easy to add a 'volume' in container environments to store this data.
Looking at my current egeria where I last ran the coco dev environment, I see files of the form
$ find ./data -name 'cocoMDS1.config'                                     [12:41:27]
./data/servers/cocoMDS1/config/cocoMDS1.config

I posted a recursive listing to https://gist.github.com/6df6f6d652a19cd37d6fc977d9f15229
You mention in the text that we are looking for 'data/servers/{0}/config/{0}.config'
If {0} resolved to 'cocoMDS1' in my config the file would be found.
So what don't you have, and what do you think you should have? I may be missing what the problem is here (apart from the whole configuration question ...)

I do concur that the output is empty though

In file https://github.com/odpi/egeria/blob/master/open-metadata-implementation/adapters/open-connectors/configuration-store-connectors/configuration-encrypted-file-store-connector/src/main/java/org/odpi/openmetadata/adapters/adminservices/configurationstore/encryptedfile/EncryptedFileBasedServerConfigStoreConnector.java
In the code
`retrieveAllServerConfigs() {
final String methodName = "retrieveAllServerConfigs";
Set omagServerConfigSet = new HashSet<>();
try (Stream list = Files.list(Paths.get(".")))
{
// we need to use the configStoreTemplateName to pick up any files that match this shape.
// this template might have inserts in
        String templateString = getStoreTemplateName();;
          Set<String> fileNames = list.map(x -> x.toString())
                .filter(f -> isFileNameAConfig(f, templateString)).collect(Collectors.toSet());`

The Files.list command goes down the files in the current directory if does not match the nested content, so it never finds anything.
Unfortunately using a * wild card did not work @mandy-chessell
I have a fix I have working that splits up the template string and then looks for the content where the wild cards are. So it can create a valid list of fileNames that match the template  It handles one or 2 inserts and rejects 0 or >2 inserts in the template.
I have amended the default constant slights to prepend with ./.
 private static final String INSERT_FOR_FILENAME_TEMPLATE = "{0}";
 private static final String DEFAULT_FILENAME_TEMPLATE    = "./data/servers/" +INSERT_FOR_FILENAME_TEMPLATE + "/config/" +INSERT_FOR_FILENAME_TEMPLATE + ".config";

Does this make sense?

@davidradl That looks good to me. I would have broken this api when I did 1a9ba66bd8fa0b5dc45942977e1e30ca869ea5ce :-(


Cupertino Scrollbar null-safety on handleThumbPressStart

Hi, I found a small null-safety forced check at line 160 of cupertino/scrollbar.dart, the problem is that sometime for various motivation or when we use scrollbars with a draggable item into the ListView we got a null exception.
This occurs when the longpress on draggable item is handled and the direction for scrollbar is null:

Into this image we see the showed scrollbar, if the user tap on reorder ListView handler when the scrollbar is visible we got this error.
I see other scrollbar (like material)  source code and this control is there.
  void handleThumbPressStart(Offset localPosition) {
    super.handleThumbPressStart(localPosition);
    final Axis direction = getScrollbarDirection()!;
    switch (direction) {
      case Axis.vertical:
        _pressStartAxisPosition = localPosition.dy;
        break;
      case Axis.horizontal:
        _pressStartAxisPosition = localPosition.dx;
        break;
    }
  }

must became
  void handleThumbPressStart(Offset localPosition) {
    super.handleThumbPressStart(localPosition);
    final Axis? direction = getScrollbarDirection();
    if (direction == null) {
      return;
    }
    switch (direction) {
      case Axis.vertical:
        _pressStartAxisPosition = localPosition.dy;
        break;
      case Axis.horizontal:
        _pressStartAxisPosition = localPosition.dx;
        break;
    }
  }

Hope to help you.

@carmas123
Thanks for reporting this. Can you provide flutter doctor -v and a complete minimal reproducible code sample that shows the issue ?

Hi, @darshankawar  this is my flutter doctor:
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-x64, locale it-IT)
    • Flutter version 2.2.3 at /Users/isigest/development/Tools/flutter
    • Framework revision f4abaa0735 (10 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/isigest/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/isigest/Library/Android/sdk
    • Java binary at: /Users/isigest/Library/Java/JavaVirtualMachines/corretto-1.8.0_302/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment Corretto-8.302.08.1 (build 1.8.0_302-b08)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (4 available)
    • iPhone 11 Pro (mobile)                         • 030B01B3-0292-41BF-BAA6-4743B989E3DB • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • iPad Pro (12.9-inch) (5th generation) (mobile) • DBB3939A-645D-4DE8-AFF9-C977A804CBC2 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)                                • macos                                • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)                                   • chrome                               • web-javascript • Google Chrome 92.0.4515.159

! Doctor found issues in 1 category.
iMac:dashadmin isigest$ flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-x64, locale it-IT)
    • Flutter version 2.2.3 at /Users/isigest/development/Tools/flutter
    • Framework revision f4abaa0735 (10 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/isigest/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/isigest/Library/Android/sdk
    • Java binary at: /Users/isigest/Library/Java/JavaVirtualMachines/corretto-1.8.0_302/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment Corretto-8.302.08.1 (build 1.8.0_302-b08)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (4 available)
    • iPhone 11 Pro (mobile)                         • 030B01B3-0292-41BF-BAA6-4743B989E3DB • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • iPad Pro (12.9-inch) (5th generation) (mobile) • DBB3939A-645D-4DE8-AFF9-C977A804CBC2 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)                                • macos                                • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)                                   • chrome                               • web-javascript • Google Chrome 92.0.4515.159

is very hard for me to provide an example, but as I told you this is a simple null-safety bug.
Regards.

Labeling this based on above findings for further insights from the team.


Error with class_exists and SPL autoloader

In these files:
src/XSD2PHP/src/com/mikebevz/xsd2php/Bind.php
src/XSD2PHP/src/com/mikebevz/xsd2php/Php2Xml.php
src/Core/Http/Serialization/XmlObjectSerializer.php
src/XSD2PHP/src/com/mikebevz/xsd2php/Bind.php
src/XSD2PHP/src/com/mikebevz/xsd2php/Php2Xml.php

the code class_exists(whatever... must be changed with class_exists(whatever..., false) so all problems with SPL Autoloader and other frameworks autoloader are fixed.
Do you need a PR?

@lordlele
What issues are we trying to resolve here? Can you provide more details?

@hlu2 yes, we use your SDK in our projects with Yii, Laravel, Symfony and other frameworks.
This frameworks have their own autoloader that try to load the class when class_exists is encountered, however this create a fatal error.
With class_exists(whatever, false) the autoloader of the frameworks do not try to load the class from his own path and let QB SDK to load his own classes.
Thanks.

@lordlele
Thanks, I will change it accordingly.

@lordlele Complete. Will be released at the end of the week.


Blockchain Technology

I am going to share the best free courses to learn Blockchain development from scratch.
These free courses are great to start your career with Blockchain and they are curated from sites like Udemy, Pluralsight, Coursera, and 101 Blockchains, one of the specialized blockchain learning platforms.

it must be free courses with certificate :)


Timer client-side router

A client-side route for a timer means that it could be easier to share URLs.

To be clear, I'm not super interested in turning the entire app into an SPA, just the timer. The benefits would be passing a url with a tab pre-selected.

Upcoming version of mobtime will make this unnecessary.


Feature/66 Sphinx Documentation

Description

See #66
ToDo List

[x] ToDo --> Check conflicts with develop. This branch was created before #70
[ ]  ToDo --> Create a GitHub Action script

Test plan

Test correct badge message after the build is ready in Read the Docs.
Resources

Hyperlinks in .rst docs work differently than the ones in Markdown. Resource:
https://stackoverflow.com/questions/45499108/if-possible-how-do-we-put-hyperlink-within-the-code-section-in-rst-files
Screenshots or additional context

Original README.md file

Same section, converted using Pandoc

Same section, manual update

Note that commit 9387eb1 fixes a minor error in .gitignore which I introduced in 0ac5149 when I was trying to use VSCode's Python Docstring Generatior. I rased an issue with them.

Seems to have no conflicts with Develop

@astrochun I made one last change: instead of trying to simplify the REDME.md file here, I have created a new issue #75.
This PR should now be ready for your creating a GitHub Action script for RTDs and for your code review.

@astrochun I made one last change: instead of trying to simplify the REDME.md file here, I have created a new issue #75.
This PR should now be ready for your creating a GitHub Action script for RTDs and for your code review.

Yes, but it seems that you created a bug issue for #75 when it isn't. It's merely documentation.


Chore/clean

Coverage remained the same at 87.302% when pulling 42660d82b7ed0f055cc61050634406c110c1b934 on chore/clean into f44c4293fd7d8e9e37010e389e0bb217cc3520de on master.


Issue #305: add check if slack panel is visible to prevent unnecessar…

@mvlasovatl I added the requested changes. If you still see problems with the versions let me know or maybe fix them by yourself as you know better where to put which version.

Closer review revealed that only change in issuepanel-init.js may be applied without breaking other features. It properly prevents loading issue mentions data if issue panel is hidden.
update-slack-link-banner.js is responsible for showing a banner to an Admin when some workspace connection gets broken. This feature isn't related to issue panel in any way and shouldn't be disabled on all other pages. It may indeed generate some redundant traffic, but assuming that it affects only admins and that the request response has no body if all connections are good, it should be an acceptable price for proactive failure notification. So, changes in this file are to be reverted.
Code in token-status.js is responsible for warning a user when their authentication gets broken and if workspace connections get broken. It looks like it includes the logic from from update-slack-link-banner.js and adds even more information. I need to discuss this duplication with original developers. For now we may limit changes in this PR to issue mentions data loading prevention and maybe get back to duplicated endpoints later. Changes here are also to be reverted.

Thanks for the information. Let me know when you discussed it and came to a decision. I reverted the changes as requested.


How can we use Frame Interpolation and Video Enhancement at the same time?

I guess many people will want this function.
I found that when i downloaded SAFA 0.5 and saved it to pulled project folder, it overwrites existing pkl file.
So we need one more step to use SAFA 0.5 and RIFE 4.x. I hope you people can change this.

OK, I will fix it.


update to 3.9.1

Obsoletes: #132

I have to change the icon path. Let me just a few jours.

This PR already fixes it.

Nope, the icon should be in "scalable" because it is a svg.

Oh, you mean the install location. Well, it was wrong before and it still works, so no rush. But feel free to make PR with an updated package release.
But tbh, I'd prefer if the Jamulus.pro file was fixed to support PREFIX=/usr, so that we can use make install instead of having custom install commands in the PKGBUILD file.


User Data Geometry Interface Refactor

Cleaning up the user data interface based on lessons learned. This includes:

[x] Cell topology enumeration
Adding a cell topology enumeration allows for a cleaner multi-topology input into the code for the topologies that we support. It also allows us to encode the number of nodes for the topology into the enum. Finally, with an enum we can immediately use this information on the device for algorithms.

[x] Single cell list interface
A single cell list interface makes input easier for users and covers all use cases for cell lists with a simple interface. The view of enums can be used as a filter/stencil over which to launch kernels over cells of the same topology. For single topology cases the code is just as easy to write as it was before. For multiple topology cases, the input is even easier with a little less information required and no need to relate cell topologies to a vector of strings.

[x] Global ids for adjacency computations instead of ghosts.
Ghosting was removed as it was still not sufficient for computing adjacencies - we needed some input from the user that would tell us what the owning process is. By forcing users to give us only locally-owned cells, we automatically know which cells belong to which processors. Furthermore, this greatly simplifies user input in the field interface. We now will only require field data for degrees-of-freedom on locally-owned entities. This removes a lot of confusion in parallel I/O through the interface. It also removes optional arguments from the interface (i.e. has_ghosts). Instead of optional arguments, I would advocate adding extra functions, such as the adjacencyList functions, that give us extra information when we need it.

[x] Remove string names from boundary
A map will only work for a single boundary. This fixes that problem and also doesn't force the user to identify boundaries with a string. Whichever boundary the user wants to give to the map they can specify in whichever way they want with the user data they register with the function.

Future work for discretization PR:

Discretization enumeration
Remove string names from field functions
Separate cell topology from discretization
Single field layout interface
User-provided shape function/interpolation

Future work for a user-defined discretization PR:

Point-in-geometry functionality
Shape function interface
Integration rule interface
Interpolation interface

Codecov Report

Merging #288 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   95.05%   94.83%   -0.22%
==========================================
  Files          55       55
  Lines        3071     2923     -148
==========================================
- Hits         2919     2772     -147
+ Misses        152      151       -1

Impacted Files
Coverage Δ

packages/Interface/src/DTK_UserApplication.hpp
100% <ø> (ø)
:arrow_up:

...ackages/Interface/src/DTK_UserFunctionRegistry.hpp
100% <ø> (ø)
:arrow_up:

packages/Interface/test/tstC_API.cpp
85.71% <ø> (-0.65%)
:arrow_down:

...ges/Interface/src/DTK_UserFunctionRegistry_def.hpp
100% <ø> (ø)
:arrow_up:

packages/Interface/src/DTK_CellList.hpp
100% <ø> (ø)
:arrow_up:

packages/Interface/src/DTK_InputAllocators_def.hpp
100% <100%> (ø)
:arrow_up:

packages/Interface/test/tstUserApplication.cpp
96.96% <100%> (-0.04%)
:arrow_down:

packages/Interface/src/DTK_UserApplication_def.hpp
100% <100%> (ø)
:arrow_up:

packages/Interface/src/DTK_C_API.cpp
96.7% <100%> (-0.48%)
:arrow_down:

...ages/Interface/test/DTK_TestApplicationHelpers.hpp
100% <100%> (ø)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c47f02...4b1b38c. Read the comment docs.

Ready for

Working on clang test failures...

ok issues resolved and ready for review

Interesting how coverage doesn't take into account deleted lines of code. We lost 595 coverage hits in this PR but I also removed 595 lines of code. So it looks like a net percentage loss when actually we didnt really lose any coverage.

@sslattery Could you please document the reasoning behind ghost removal and topology changes in some of the commit notes?

Documented the reasoning in the PR description checklist

@dalg24 @aprokop Let me know if you have anything else

Yes - this way we dont have to have a separate topology enum and also pass in the number of nodes in the topology. I anticipate writing a traits class that extracts this information among other things from the enum

That's no "encoding".  You still have to build some kind of map to attach properties, whether you call it traits or something else.

I would argue that it is and the map or traits are the key to "decoding" it

Didn't you just trade a string for an enumerator?
I see one benefit to the enum: it is cheaper to compare integral type than string and there might be less chances to get runtime errors because of silly typos.
But I also see disadvantages: didn't we use string to allow for registering user defined custom topology?

Anyway I don't want to waste time nitpicking about that.  If Bruno approved then merge it.

Bruno and I discussed the custom topology. The idea is to add additional interface functions that provided the needed methods for the user topology. We made add an enum value for this at that point to allow for this. The biggest upside I see is that we can do more on the device with the enum.


Incorrect work with HPA (when replicas more than number of nodes)

What version of descheduler are you using?
descheduler version: 0.24.1
Does this issue reproduce with the latest release?
Yes
Please provide a copy of your descheduler policy config file
I've deployed with default variables
helm repo add descheduler https://kubernetes-sigs.github.io/descheduler/
helm install my-release --namespace kube-system descheduler/descheduler

apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
evictLocalStoragePods: true
strategies:
  LowNodeUtilization:
    enabled: false
  RemoveDuplicates:
    enabled: true
  RemovePodsViolatingInterPodAntiAffinity:
    enabled: true
  RemovePodsViolatingNodeAffinity:
    enabled: false
  RemovePodsViolatingNodeTaints:
    enabled: false

What k8s version are you using (kubectl version)?
$ kubectl version
v1.21.9

What did you do?
In my cluster I've deployed deployment with HPA.
Cluster has 5 nodes and HPA config has minimum 2 and maximum 10 pods
My application was scaled up by HPA up to 10 replicas.
After an hour, I noticed that HPA can't scale down my application back to 2 replicas. I checked my pods and saw that descheduler every 2 minutes trying to remove duplicates from the nodes, so it restarts 3 pods every 2 minutes.
After each restart, HPA recalculates CPU/RAM metrics and keeps 10/10 replicas.
Shortly speaking, in this situation, HPA never scaled my replicas back to 2/10 due to Descheduler behaviour.
Also, I think, without HPA will be the same situation (with the same number of replicas and worker nodes)
What did you expect to see?
I expect that descheduler won't infinitive restart pods if the number of replicas is more than twice the worker nodes.
What did you see instead?
Descheduler kill 3 of 10 pods each 2 minutes when I have 5 worker nodes and 10 replicas.
"Processing node" node="ip-172-11-33-36.ec2.internal"
"Duplicate found" pod="sandbox/worker-dc454495d-b2c49"
"Duplicate found" pod="sandbox/worker-dc454495d-8x62z"
"Processing node" node="ip-172-11-39-138.ec2.internal"
"Processing node" node="ip-172-11-39-67.ec2.internal"
"Processing node" node="ip-172-11-52-28.ec2.internal"
"Duplicate found" pod="sandbox/worker-dc454495d-w9vpj"
"Duplicate found" pod="sandbox/worker-dc454495d-9b8hn"
"Duplicate found" pod="sandbox/worker-dc454495d-rhxkk"
"Processing node" node="ip-172-11-11-27.ec2.internal"
"Evicted pod" pod="sandbox/worker-dc454495d-9b8hn" reason="RemoveDuplicatePods" strategy="RemoveDuplicatePods" node="ip-172-11-52-28.ec2.internal"
"Evicted pod" pod="sandbox/worker-dc454495d-rhxkk" reason="RemoveDuplicatePods" strategy="RemoveDuplicatePods" node="ip-172-11-52-28.ec2.internal"
"Evicted pod" pod="sandbox/worker-dc454495d-8x62z" reason="RemoveDuplicatePods" strategy="RemoveDuplicatePods" node="ip-172-11-33-36.ec2.internal"

We've actually tried fixing this issue before, as reported in https://github.com/kubernetes-sigs/descheduler/issues/263 and addressed in https://github.com/kubernetes-sigs/descheduler/pull/463, which takes more of an approach to remove duplicate pods based on the average number per node. In this case that's 10/5=2, so any node with more than 2 replicas is going to evict at least one. RemoveDuplicates is a pretty strict strategy that doesn't allow for any skew.
This can be difficult to enforce as there are other scheduling criteria that could cause duplicates to be re-scheduled onto the same node.
If you are looking to tolerate some skew, and not strictly try to enforce each node to have as few duplicates as mathematically possible, I recommend using topology spread constraints. This is a much better way to distribute workloads with some wiggle room, and we have a descheduler strategy to rebalance topologies on scale changes

Ok, let me test with topology spread constraints.
It will take me around 1h

Descheduler config:
apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
evictLocalStoragePods: true
strategies:
  LowNodeUtilization:
    enabled: false
  RemoveDuplicates:
    enabled: false
  RemovePodsViolatingInterPodAntiAffinity:
    enabled: true
  RemovePodsViolatingNodeAffinity:
    enabled: false
  RemovePodsViolatingNodeTaints:
    enabled: false
  RemovePodsViolatingTopologySpreadConstraint:
    enabled: true
    params:
      includeSoftConstraints: true

Descheduler logs:
"Evicted pod" pod="sandbox/worker-dc454495d-t66mn" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-38-28.ec2.internal"

"Event occurred" object="sandbox/worker-dc454495d-t66mn" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"

"Evicted pod" pod="sandbox/worker-dc454495d-fzmx6" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-38-28.ec2.internal"

"Event occurred" object="sandbox/worker-dc454495d-fzmx6" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"

"Evicted pod" pod="sandbox/worker-dc454495d-8rkwd" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-38-28.ec2.internal"

"Event occurred" object="sandbox/worker-dc454495d-8rkwd" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"

"Evicted pod" pod="sandbox/worker-dc454495d-8bmmp" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-38-28.ec2.internal"

I0824 14:30:04.484400       1 descheduler.go:304] "Number of evicted pods" totalEvicted=4

Deployment topologySpreadConstraints config:
      topologySpreadConstraints:
      - maxSkew: 1
        topologyKey: lifecycle
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            "app": {{ .Release.Name | quote }}
      - maxSkew: 1
        topologyKey: kubernetes.io/hostname
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            "app": {{ .Release.Name | quote }}
      affinity:
        nodeAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 4
            preference:
              matchExpressions:
              - key: lifecycle
                operator: In
                values:
                - spot
          - weight: 5
            preference:
              matchExpressions:
              - key: lifecycle
                operator: In
                values:
                - on-demand

Result:
Descheduler evict 4 pods every 2 minutes

After all tests with topologySpreadConstraints I can say that the problem with
      - maxSkew: 1
        topologyKey: kubernetes.io/hostname
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            "app": {{ .Release.Name | quote }}

It's trying to evict pods all the time
If I don't set this second topology and have only this one:
      - maxSkew: 1
        topologyKey: lifecycle
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            "app": {{ .Release.Name | quote }}

It works, but, until 20 replicas. I noticed that after 20+ replicas, descheduler starts evictin ~4-5 pods every time.

@OuFinx could you share the output for kubectl get pods -o wide in that namespace? Might be easier to see what pods are on what nodes to get a better idea of the spread.

@damemi sure
Conditions:
      topologySpreadConstraints:
      - maxSkew: 1
        topologyKey: lifecycle
        whenUnsatisfiable: ScheduleAnyway
        labelSelector:
          matchLabels:
            "app": {{ .Release.Name | quote }}
      affinity:
        nodeAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 4
            preference:
              matchExpressions:
              - key: lifecycle
                operator: In
                values:
                - spot
          - weight: 5
            preference:
              matchExpressions:
              - key: lifecycle
                operator: In
                values:
                - on-demand

and
apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
evictLocalStoragePods: true
strategies:
  LowNodeUtilization:
    enabled: false
  RemoveDuplicates:
    enabled: false
  RemovePodsViolatingInterPodAntiAffinity:
    enabled: true
  RemovePodsViolatingNodeAffinity:
    enabled: false
  RemovePodsViolatingNodeTaints:
    enabled: false
  RemovePodsViolatingTopologySpreadConstraint:
    enabled: true
    params:
      includeSoftConstraints: true

Test #1: 5 replicas
NAME                                         READY   STATUS    RESTARTS   AGE     IP              NODE                            NOMINATED NODE   READINESS GATES
worker-8fc5bcbcc-2crw8   2/2     Running   0          43m     <IP_ADDRESS>    ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-5zxkg   2/2     Running   0          89s     <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-gqth6   2/2     Running   0          75s     <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-mc8jx   2/2     Running   0          90s     <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-x6qbj   2/2     Running   0          2m16s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>

Descheduler output
"Number of evicted pods" totalEvicted=0

Test #2 (the same conditions): 30 replicas
NAME                                         READY   STATUS    RESTARTS   AGE     IP              NODE                            NOMINATED NODE   READINESS GATES
worker-8fc5bcbcc-24hjq   2/2     Running   0          3m37s   <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-2crw8   2/2     Running   0          51m     <IP_ADDRESS>    ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-2fntc   2/2     Running   0          3m35s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-45dgk   2/2     Running   0          3m38s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-59fmj   2/2     Running   0          47s     <IP_ADDRESS>   ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-5n6sg   2/2     Running   0          3m35s   <IP_ADDRESS>   ip-172-11-19-41.ec2.internal    <none>           <none>
worker-8fc5bcbcc-5zxkg   2/2     Running   0          9m10s   <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-62z9w   2/2     Running   0          83s     <IP_ADDRESS>   ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-75vkx   2/2     Running   0          84s     <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-8kt2h   2/2     Running   0          47s     <IP_ADDRESS>   ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-8n69r   2/2     Running   0          83s     <IP_ADDRESS>    ip-172-11-19-41.ec2.internal    <none>           <none>
worker-8fc5bcbcc-98lkk   2/2     Running   0          3m11s   <IP_ADDRESS>   ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-b77k9   2/2     Running   0          3m38s   <IP_ADDRESS>     ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-bhjcw   2/2     Running   0          3m39s   <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-cdd8m   2/2     Running   0          3m38s   <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-cps66   2/2     Running   0          3m33s   <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-drpst   2/2     Running   0          83s     <IP_ADDRESS>   ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-fbtng   2/2     Running   0          3m33s   <IP_ADDRESS>     ip-172-11-19-41.ec2.internal    <none>           <none>
worker-8fc5bcbcc-ghsbb   2/2     Running   0          3m37s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-gqth6   2/2     Running   0          8m56s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-grmq6   2/2     Running   0          3m33s   <IP_ADDRESS>   ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-hj99r   2/2     Running   0          3m39s   <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-jmq4b   2/2     Running   0          3m33s   <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-mc8jx   2/2     Running   0          9m11s   <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-mq49g   2/2     Running   0          3m37s   <IP_ADDRESS>   ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-p4fz2   2/2     Running   0          3m37s   <IP_ADDRESS>    ip-172-11-42-11.ec2.internal    <none>           <none>
worker-8fc5bcbcc-rrrdc   2/2     Running   0          83s     <IP_ADDRESS>   ip-172-11-19-221.ec2.internal   <none>           <none>
worker-8fc5bcbcc-x5wpj   2/2     Running   0          3m35s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-x6qbj   2/2     Running   0          9m57s   <IP_ADDRESS>    ip-172-11-38-28.ec2.internal    <none>           <none>
worker-8fc5bcbcc-zcrjh   2/2     Running   0          46s     <IP_ADDRESS>     ip-172-11-42-11.ec2.internal    <none>           <none>

Descheduler output
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-p4fz2" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-42-11.ec2.internal"
"Event occurred" object="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-p4fz2" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-rrrdc" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-19-221.ec2.internal"
"Event occurred" object="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-rrrdc" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-zcrjh" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-42-11.ec2.internal"
"Event occurred" object="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-zcrjh" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"

"Number of evicted pods" totalEvicted=3

Run descheduler one more time
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-j2d86" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-19-41.ec2.internal"
"Event occurred" object="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-j2d86" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-mjx82" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-42-11.ec2.internal"
"Event occurred" object="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-mjx82" fieldPath="" kind="Pod" apiVersion="v1" type="Normal" reason="Descheduled" message="pod evicted by sigs.k8s.io/deschedulerPodTopologySpread"
"Evicted pod" pod="kudo-kcp-sandbox/kudo-kcp-stagingnxt-worker-8fc5bcbcc-x5pmc" reason="PodTopologySpread" strategy="PodTopologySpread" node="ip-172-11-42-11.ec2.internal"
I0824 17:38:37.152048       1 descheduler.go:304] "Number of evicted pods" totalEvicted=3

Your pods don't seem to be properly distributed when they're scheduled.
In the first test, you should have more than 0 evictions because the nodes are out of skew (3 pods/1 pod/1pod, skew is 2 but your maxSkew is only 1, so you should have 1 eviction from ip-172-11-38-28.ec2.internal)
Then in your larger test, I only see pods scheduled onto 4 nodes (not 5):

ip-172-11-42-11.ec2.internal - 10 pods
ip-172-11-19-221.ec2.internal - 5 pods
ip-172-11-38-28.ec2.internal - 12 pods
ip-172-11-19-41.ec2.internal - 3 pods

Could you do kubectl get nodes and share the yaml for whichever node isn't listed above? It must be unavailable or something
these are all out of skew, which is fine from the scheduler's point of view because the constraints are only ScheduleAnyway. The descheduler is still going to try evicting in order to balance them though. What happens if you make the constraints DoNotSchedule?
I think ultimately the descheduler is working as it's supposed to but there is a problem in how your pods are getting scheduled

In the test with 5 replicas, node ip-172-11-38-28.ec2.internal has label on-demand.
And other nodes have label spot.
So, 1 on-demand and 4 spot.
Based on topologySpreadConstraints and nodeAffinity ,  score for on-demand is 20 points greater than for spot (weights are normalized: 4->80, 5->100)
For this reasons, I believe all pods were distributed in this way.
There is yaml file from the node that isn't listed above
apiVersion: v1
kind: Node
metadata:
  annotations:
    csi.volume.kubernetes.io/nodeid: '{"efs.csi.aws.com":"i-009139f35126af400"}'
    node.alpha.kubernetes.io/ttl: "0"
    volumes.kubernetes.io/controller-managed-attach-detach: "true"
  labels:
    beta.kubernetes.io/arch: amd64
    beta.kubernetes.io/instance-type: t3.xlarge
    beta.kubernetes.io/os: linux
    failure-domain.beta.kubernetes.io/region: us-east-1
    failure-domain.beta.kubernetes.io/zone: us-east-1d
    kubernetes.io/arch: amd64
    kubernetes.io/hostname: i-009139f35126af400
    kubernetes.io/os: linux
    lifecycle: spot
    node.kubernetes.io/instance-type: t3.xlarge
    topology.kubernetes.io/region: us-east-1
    topology.kubernetes.io/zone: us-east-1d
  name: ip-172-11-42-11.ec2.internal
spec:
  providerID: aws:///us-east-1d/i-009139f35126af400
status:
  addresses:
  - address: <IP_ADDRESS>
    type: InternalIP
  - address: ip-172-11-42-11.ec2.internal
    type: Hostname
  - address: ip-172-11-42-11.ec2.internal
    type: InternalDNS
  allocatable:
    attachable-volumes-aws-ebs: "25"
    cpu: 3920m
    ephemeral-storage: "95551679124"
    hugepages-1Gi: "0"
    hugepages-2Mi: "0"
    memory: 15189028Ki
    pods: "58"
  capacity:
    attachable-volumes-aws-ebs: "25"
    cpu: "4"
    ephemeral-storage: 104845292Ki
    hugepages-1Gi: "0"
    hugepages-2Mi: "0"
    memory: 16205860Ki
    pods: "58"
  conditions:
  - lastHeartbeatTime: "2022-08-24T18:04:44Z"
    lastTransitionTime: "2022-08-24T04:02:54Z"
    message: kubelet has sufficient memory available
    reason: KubeletHasSufficientMemory
    status: "False"
    type: MemoryPressure
  - lastHeartbeatTime: "2022-08-24T18:04:44Z"
    lastTransitionTime: "2022-08-24T04:02:54Z"
    message: kubelet has no disk pressure
    reason: KubeletHasNoDiskPressure
    status: "False"
    type: DiskPressure
  - lastHeartbeatTime: "2022-08-24T18:04:44Z"
    lastTransitionTime: "2022-08-24T04:02:54Z"
    message: kubelet has sufficient PID available
    reason: KubeletHasSufficientPID
    status: "False"
    type: PIDPressure
  - lastHeartbeatTime: "2022-08-24T18:04:44Z"
    lastTransitionTime: "2022-08-24T04:04:05Z"
    message: kubelet is posting ready status
    reason: KubeletReady
    status: "True"
    type: Ready
  daemonEndpoints:
    kubeletEndpoint:
      Port: 10250
  nodeInfo:
    architecture: amd64
    bootID: 6008f34c-791c-4c0b-a2b9-28be6d5ea543
    containerRuntimeVersion: docker://20.10.13
    kernelVersion: 5.4.204-113.362.amzn2.x86_64
    kubeProxyVersion: v1.21.12-eks-5308cf7
    kubeletVersion: v1.21.12-eks-5308cf7
    machineID: ec2be60aefd251a26bf5521ca96dc67a
    operatingSystem: linux
    osImage: Amazon Linux 2
    systemUUID: ec2be60a-efd2-51a2-6bf5-521ca96dc67a

Could you do kubectl get nodes and share the yaml for whichever node isn't listed above? It must be unavailable or something

5th node is full of other pods from other deployments, but this node also has spot label.

Ah, then I think combining nodeAffinity with topology spreading like this is going to be hard to avoid an eviction loop. Because you're saying you simultaneously want to distribute pods across different lifecycle topologies, but giving a stronger preference to one of them.
You'll have the same problem with the hostname constraint for basically the same reason, you're telling the scheduler to prefer one type of node but telling the descheduler to spread them evenly within skew. Unfortunately there isn't a good way to say something like "give this topology X% more preference". You've kind of achieved that with node affinity, but that's difficult to calculate what "balanced" looks like

@damemi Got you. Thanks for your explanation.
Maybe you can suggest better solution with descheduler/nodeAffinity/spreading for my cases?
I'll be very thankful


Improve header parsing

Ref: https://github.com/DefinitelyTyped/definition-header/pull/15#issuecomment-304804860
Summary of changes

Line/column numbers in errors were off by 1
Add reason for failure on repo tests
Fix handling of parentheses in label
Handle author names with unexpected characters (e.g. ',' or '&')
Made parsing of multiple authors more flexible

Allow mixing same-line and multi-line formats
Allow trailing comma and whitespace for multi-line format
Allow variable space at beginning of new line for multi-line format

Allow spaces in repo URL
Allow noise after project URL

This fixes 59 out of 60 failing test cases. The exception is jQuery's version header which I couldn't figure out how to handle (and should probably be fixed in the type definition anyway).

Fixed jQuery's header in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/16768 so build should start passing when that's merged.

@vvakame, this handles the jQuery case now. Should be good to go.

@vvakame mind taking a look?

sorry for late. thank you for your awesome works!

I updated this package & dt-review-tool & dt-review-bot. thanks!
Do you want to access grant to this repository?
I am very happy to help with maintenance!
cc/ @DefinitelyTyped/owners

Sure, that sounds good to me.

I added you to DefinitelyTyped/infrastructure team! have fun 😉


ci: SonarCloud coverage

Introduce a new Maven profile for JaCoCo test coverage reporting in the pom.xml. Additionally, update the GitHub Actions workflow to include a SonarCloud scan that uses the JaCoCo coverage data.
DSP-119
DSP-120

d'oh


fix(instrumentation): fix web instrumentation span clock drifts

Which problem is this PR solving?
Fixes parts of https://github.com/open-telemetry/opentelemetry-js/issues/3355
Short description of the changes

This PR addresses the call sites in the fetch/xhr instrumentations that spans are created and end with hard-coded performance clocks.
This PR should be complementary to https://github.com/open-telemetry/opentelemetry-js/pull/3384 / https://github.com/open-telemetry/opentelemetry-js/pull/3434, which provide a solution in the trace-sdk.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] TODO

Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

Closing in favor of https://github.com/open-telemetry/opentelemetry-js/pull/3434.


Fix explorer build script for DockerHub

The release pipeline fails on building the explorer script. It was not properly updated for our switch to DockerHub.
Works now: https://hub.docker.com/r/fndnt/data_explorer

Good catch, updated and tested (the explorer one).


RQ1: Topics in SE

oh man, this is so cool. i told sooooo many people about this work
still dont see why you are reporting > 7. humor me. please change
need tables of the two most cited papers in each of the above above topics:

last 5 years
all time

there was a complaint from reviewers that our graphics dont work in b&w.  i think the heatmaps work ok but the "history" diagram is the problem. any ideas? dont kill yourself on this one... maybe we just submit this as is to somewhere else and let reviewers trigger in random things (as they do) which may or may not be be the history diagram

here's one that i dont want you to DO, but think about. whats the effort about push back to 1991? Then we can claim 25 years of SE research.

on it

still dont see why you are reporting > 7. humor me. please change

need tables of the two most cited papers in each of the above above topics:
last 5 years
all time

Updated the comment with 7 terms per topic


Session::forget('whatever') does not reliably persist to storage when using database, predis, and/or memcached session driver

I'm currently using the database driver, but I have confirmed that the same issue exists with the predis and memcached drivers.  The only session driver that seems to be able to reliably persist to storage is the native driver (which persists to app/storage/session/sess_sessionidstring).
This seems to be quite a complicated issue.  And, the code involved is also complicated (for me at least).  I've tried to trace through the code to see what might be the problem, but get lost in the Symfony Session.php, Storage.php, SessionBagInterface.php, AttributeBag.php, the storage handlers and the rest of the related classes.  I can't seem to figure out how to force it to save.
Here's my basic scenario:
I have a lazyloading listview on a page containing a list of artists.  Let's say 20 items are shown by default, and then 20 at a time get lazyloaded into the listview.  Each time an additional 20 is appended onto the list, the "artists_listed_so_far" session variable is incremented by 20.  When I go back to the home page, an ajax request is posted that basically calls Session::forget("artists_listed_so_far") so that the lazyloading can start from the beginning again when going back to the artists page.  If I log Session::all() to firebug before the call to forget, and then after the call to forget, I can see it does forget it.  However, when I go back to the artists page, I see that the "artists_listed_so_far" still exists in the Session that is retrieved from persisted storage for that particular Request.  So, it seems that the the AttributeBag or whatever is correctly being updated after I call Session::forget("artists_listed_so_far") but, it is not persisting to storage (i.e. the database when using the database driver).  I do see the last_activity field getting updated though.  But, the payload does not get updated (or, maybe it does get updated, but it's just not using the latest version of the AttributeBag or whatever).
I'm not sure if this is a Symfony issue or an issue with the way Laravel is extending Symfony's Session class.  I can cross post this over to Symfony's github if you want.

FWIW, I had a similar issue with Session::pull('key') using database and Session::save() seemed to be required to push the removal of the key.

You should never ever have to call Session::save manually. If you do then something else is going on that is causing problems and the session middleware is not being closed properly.

On May 23, 2016, at 3:54 PM, Peter Falson<EMAIL_ADDRESS>wrote:
FWIW, I had a similar issue with Session::pull('key') using database and Session::save() seemed to be required to push the removal of the key.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/laravel/framework/issues/1119#issuecomment-221093095

Hi
I'm facing issue with {{Session::forget('key')}}. I want to forget my session-key when I call it once, but It works when I refresh my page 3rd or 4th time. What should I do?

facing the same issue on laravel 5.7 + redis as session driver.
on the same request dumping session after forget shows null but on next request the key is still in session.
calling the save() method persist to storage only

I had a problem with sessions too and I solved it. I  am still using 5.5 but I assume it is a general problem.
I was trying to pass an error to the session (to the redirect I am doing) but the error doesn't get displayed and it is not in the session at all when the view (of the redirect) gets displayed. So the problem was that I was getting an exception that only happens when session gets saved or something around that. (I mean it doesn't happen in my controller at all),
So the session reports the exception but instantly the redirect continues to the route I specified in the controller.
I saw the exception when I tried to dump a text .. dump('something') and it told me what I was doing wrong to the session .. and that was causing the errors I am trying to send in the session to not be sent to the route I am redirecting to.


suggestion : make an actually portable executable

Since pocketlang is already "a standalone executable with zero external dependencies", it would be nice if this executable could run on several platforms as explained in https://justine.lol/ape.html
Several other tools have been converted this way as seen in https://github.com/jart/cosmopolitan/tree/master/third_party and https://github.com/burggraf/awesome-cosmo

Wow, I've never heard of it and seems pretty interesting. Currently, pocketlang is at its early stage, and this really is something to consider in the future.
Thanks for the suggestion!


Constants shown as offset into ELF headers

Constants are being shown as if they were addresses relative to the start of the binary.  This is a PIE binary on x86-64 (I suspect that's related).  I've attached the binary and a screenshot of what I'm seeing.
floater.zip

This is a duplicate bug though I don't have the other number offhand. This is only in dev and is the reason we haven't merged to stable. Type propagation will fix it up.

You can use this function to fix it in the disassembly view for the mean time.


Feature domain for phenomenological and ontological classes

Currently, DNN training on our phenomenological classes uses 40 features generated from the ZTF light curves. The ontological classifiers are trained on all of those features along with 34 more. These additional features consist of AllWISE, Gaia and PanStarrs magnitudes along with the ra, dec, ccd and quadrant of the source.
How should we proceed with these feature domains going forward? I don't think the coordinates and silicon position of the source should be part of the training (especially for the ontological branch where they're used now), since those features should not inform the intrinsic nature of the source.
Also, the inclusion of additional features for the ontological training means that the distinction between the phenomenological eclipsing and ontological binary star classes may be more complex that mentioned in #133. It would be helpful to know how the human classifiers treated these two classes during their labeling.

I agree that ra, dec, ccd and quadrant should not be part of the training. I am surprised they were. Were they explicitly used?

Yes, in config.yaml for features: they are explicitly listed under the ontological: header. They were commented out in an older-looking header in the list (ontological_d13:), but in the one that's currently being used by the training, they are uncommented.

They should definitely not be used, In xgboost I have not used them, and based on the old header you mention, I am certain that Dima wouldn't have used those. We were pulling parameters like quad because at one point we were looking for bogus objects as a function of quads to understand the types of boguses.

That makes sense, I can see how those features would be useful for identifying bogus sources. I'll comment out the inclusion of ra, dec, ccd and quad in the ontological feature list.

This issue is also specifically relevant to the AGN class, for which the Gaia parallax should not be applicable.


showFields issue with singletons in widget schemas

Video and image singletons are not hidden when using a select menu with show fields.

Hmm, can I see this in action somewhere?
On Fri, Aug 5, 2016 at 1:45 PM, Kylee Acker<EMAIL_ADDRESS>wrote:

Video and image singletons are not hidden when using a select menu with
show fields.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe/issues/623, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9fT2sCNOwf3gEj3VBoz-Fik0L9FINks5qc3bGgaJpZM4Jd6FC
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

Bump - how do I duplicate this y'all?


Proposal to enhance logPath in PAI mode

Currently logPath in PAI mode is not useful; users still have to go to the PAI portal to check stdout and stderr. According to Quanlu, this is attributed to the missing information returned by OpenPAI API. So I propose a workaround to get the webpage directly from the portal and parse the webpage to get the link.
The code is almost ready. All I need to do is to inject it into NNI manager. So should we do it or not?

Close as won't fix after team discussion, will create a new issue for generic capability to create logPath for all the training services.


fix: fix bug in del function of redis_proxy

What problem does this PR solve?
In redis_proxy，"OK" will be returned using del function to delete a key, If the function executes successfully. But interface definition of redis shows that it should return the number of keys which are deleted.
While, there are some difference between interface definition of redis and redis proxy of pegasus. Because whether the key is exist or not, pegasus will return "OK" to redis proxy, so we cann't distinguish whether the key is deleted or not. so in this case , we unity returns 1.
Redis documentation about del: https://redis.io/commands/del

DEL key [key ...]
Removes the specified keys. A key is ignored if it does not exist.
Return value
Integer reply: The number of keys that were removed.
Examples

redis> SET key1 "Hello"
"OK"
redis> SET key2 "World"
"OK"
redis> DEL key1 key2 key3
(integer) 2
redis>

What is changed and how it works?
Change the return value from "OK" to the number of keys.
Check List
Tests

Manual test (add detailed scripts or steps below)
1.start a redis proxy in c4tst-injection
2.clone redis code, and build it.
3.use command of ./redis_cli -h host -p port to connect with the redis proxy
4.insert a k-v pair into redis proxy:

redis> SET key "value"
"OK"

in pervious versionm, regardless of the key is exist or not, del the key, it returns "OK"

redis> DEL key "value"
"OK"

6.del the key which was inserted before in current version. It returns 1, not "OK".
redis> DEL key "value"
(integer) 1

7.del a key which is not exist in current version. It returns 1, also.
redis> DEL not_exist_key "value"
(integer) 1

Related changes

Need to cherry-pick to the release branch

Can you include the manual test in the PR description?
Like this:
Previous version
> redis del a
> ok

Current version
> redis del a a
> -1
> redis del a
> 1

Can you include the manual test in the PR description? This PR does not show any kind of test for us.
Like this:
Previous version
> redis del a
> ok

Current version
> redis del a a
> -1
> redis del a
> 1

I tried these commands on http://try.redis.io/. Deleting a non-existed key will return 0, but your version returns 1. This should be noted in our code.
> set a a
OK
> del a
(integer) 1
> del a
(integer) 0


Fix #2124 : added default selected option to dropdowns

References
Add references/links to any related issues or PRs. These may include:

Fixes #2124

Description
Short summary of changes (1-2 sentences).
if we set a default value for the dropdown: This ensures that the dropdown always has a preselected option irrespective of the browser
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Added default option value for drop downs so that always a preselected option is displayed. This will make sure that across all browsers behaviour stays same.
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Steps to reproduce the behavior:

If you have entities enabled, add a new Collection in Safari. The "Entity Type" field shows a preselection, that is not actually saved, when you submit the form.
If you have entities enabled, add a new Collection in Firefox. The "Entity Type" field shows no preselection.
Create a new Resource Policy in Safari. The fields "Select the policy type *" and "Select the action type *" show a preselection that is not actually selected. As those fields are mandatory, you cannot submit the form, even if they appear to have values selected. You have to select a different value, or select a different value and then reselect the first value to be able to submit the form.
Create a new Resource Policy in Firefox. The fields "Select the policy type *" and "Select the action type *" show no preselection.

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[X] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[X] My PR passes ESLint validation using yarn lint
[X] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[X] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[X] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[X] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[X] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[X] If my PR fixes an issue ticket, I've linked them together.

@nishchay7pixels : Just a quick FYI, it appears this PR currently has build failures if you attempt to build in production mode (yarn build:prod).  That's why the automated tests are all failing.

@nishchay7pixels : I'll restart the tests & see if it succeeds when run again.  There are sometimes "flakey" tests which randomly fail....and it's possible this is one. We'll see if it succeeds on the next run.

@nishchay7pixels : I'll restart the tests & see if it succeeds when run again. There are sometimes "flakey" tests which randomly fail....and it's possible this is one. We'll see if it succeeds on the next run.

Looks like we should restart em. It completed with no error however when merged changes from main the test again are failing.

@nishchay7pixels : Are you still planning to work on this PR?  If not, please close it out or let us know to reassign it.  In the meantime, I've been looking for a volunteer to help with #2124 , as the changes in this PR don't appear to fix the bug.


Wagmi v. 1 still requires ethers

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.0.7
Current Behavior
Wagmi still installs ethers as subdependency to library @safe-global/safe-apps-sdk, thereby negating improvements in bundle size.
Output from yarn why ethers in project with only wagmi and viem as dependencies:
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "wagmi#@wagmi#core#@wagmi#connectors#@safe-global#safe-apps-sdk" depends on it
   - Hoisted from "wagmi#@wagmi#core#@wagmi#connectors#@safe-global#safe-apps-sdk#ethers"
   - Hoisted from "wagmi#@wagmi#core#@wagmi#connectors#@safe-global#safe-apps-provider#@safe-global#safe-apps-sdk#ethers"

Expected Behavior
Wagmi v. 1.0.0 should have no dependency on ethers, just viem
Steps To Reproduce
yarn add wagmi viem
yarn why ethers

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Safe SDK should have viem fully integrated soon: https://github.com/safe-global/safe-apps-sdk/pull/478

@jxom Great, thanks!


Remove the custom page renderers from the Xamarin Forms projects.

The Xamarin Forms Android and iOS projects originally used page renderers to implement platform-specific OAuth for the "Author map" sample. The logic for that sample has been reworked to use conditional code blocks instead.
@nCastle1 - Another small (low priority) PR, please take a look when you have a chance.

Thanks @nCastle1, good catch. I didn't realize the page renderer was in play anywhere else in the app.


chore: install same vitest version across packages

Motivation
Noticed when running yarn install locally on unstable branch it produces a lock file diff. This is due to the fact that we install different vitest versions.
I reviewed https://github.com/ChainSafe/lodestar/pull/6222 and seems to be the issue as the branch was open before we upgraded vitest in https://github.com/ChainSafe/lodestar/pull/6237.
There is a way to enforce that a branch is rebased / merged against target branch before the PR can be merged. While I don't think this is strictly necessary, we should keep in mind to rebase long lived branches before merging.
Description
Install same vitest version across packages

:tada: This PR is included in v1.15.0 :tada:


Fixed some bugs in the ReAct module

Fixes issue where model responds with literally Finish[answer], instead of having the answer be the answer.
Fixes issue where the model generates more than one thought, action, or observation.

Thanks @xnmp !


Popup相关组件在h5下报警告

BUG 描述
弹窗结束后报错，Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
复现步骤
期望结果
实际结果
截图
环境
附加信息

1.9.9已修复


In this PR Bookmark View

First This PR depends from https://github.com/lucasmontano/openweathermap-ios/pull/13

Change MapViewController.swift to preset BookmarkLocation View

Change Main.storyboard disabling safe area

Adding BookmarkLocation View

Adding Class to draw Diagonal borders

Adding Custom Button with Diagonal borders

Adding Custom UIView with Diagonal borders

BookmarkLocation Preview

Please @henrique-morbin-ifood, Could you begin do review?
Thank you.


Allow to add a lambda function to more than one cloudfront distribution

Issue: #2
myHandler:
    name: 'myHandler-origin-request'
    handler: handler.main
    memorySize: 128
    timeout: 1
    lambdaAtEdge:
        - distribution: 'distribution1'
           eventType: 'origin-request'
        - distribution: 'distribution2'
           eventType: 'origin-request'

myHandler1:
    name: 'myHandler1-origin-request'
    handler: handler.main
    memorySize: 128
    timeout: 1
    lambdaAtEdge:
          distribution: 'distribution3'
           eventType: 'origin-request'

Track: https://github.com/silvermine/serverless-plugin-cloudfront-lambda-edge/pull/3

Coverage decreased (-0.09%) to 5.464% when pulling fdab74cca77e432692e8aba109f2c701aba30507 on jjchiw:allow-to-add-a-lambda-function-to-more-than-one-cloudfront into 279b8014b981bfafac18b73e579cca992bc78287 on silvermine:master.

This will be covered by !13 in v2.0 of the plugin.


requestsizelimiting: use a resolved headers and minor typo fix

:+1: good catch on that typo :)

Sounds good but needs rebasing.

@thibaultCha closing this and opening a new pull request due to a merge conflict

That was not necessary. The point of rebasing is to fix the conflicts before merging this

On Jun 9, 2015, at 6:59 PM, Ajay Kemparaj<EMAIL_ADDRESS>wrote:
@thibaultCha closing this and opening a new pull request due to a merge conflict
—
Reply to this email directly or view it on GitHub.

@thibaultCha i had trouble merging next time i will probably take your help


DSL2

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/pgdb branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint .).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

@DongdongdongW check the tests. None of them are passing .

@ypriverol Good morning. I made some attempts to deal with it, but some checks still failed. Do you think I should use nf-core tools to create a new PGDB pipeline to commit, or change some specific files to let it pass?


fix(posgres): fix py-modules and import error

I also tried fixing this - seems that nothing apart from renaming the postgres.py file back to __init__.py works.
@numb3r3 , any idea why this is? Also, why does Jina need to modify python's import system (which works without problems for all other purposes) at all? What prevents us from just using normal python imports? Sorry if these questions are too broad, it's just something I have a hard time understanding

why does Jina need to modify python's import system (which works without problems for all other purposes) at all?

To support to load executor from a YAML config file (i.e., exc = Executor.load_config('config.yml')), we dynamicly import the modules one by one included in py-modules.

What prevents us from just using normal python imports?

I think the problem we want to address in this PR is not caused by our jina import machinery. The relative import failure also happens on other normal python projects. For example,
- my_module
    - __init__.py  # empy content
    - a.py. # import `from .foo import *`
    - foo.py

# the following line will raise `relative import` error
python a.py

@numb3r3 no this is caused precisely by the jina import machinery. Everything works when you are testing locally - this means that jina imports modules in a different way then python.

Actually, you are right. Then the question is why does this work in local tests


online

online mac

Turbo Application Server allows users to work from anywhere, even if the application is not installed locally.
https://turbo.net/appserver
可以让任何应用以web形式展示

OpenText Exceed TurboX
Enable secure hybrid work with the virtualization of applications and desktops
https://www.opentext.com/products/exceed-turbox

Microsoft App-V 应用程序虚拟化将于 2026 年 4 月生命周期结束
XenApp
XenDesktop

https://www.trustradius.com/application-virtualization

Parallels Remote Application Server(Parallels RAS)
https://www.parallels.com/eu/products/ras/remote-application-server/
支持手机端应用虚拟化


setup instructions

instillations

install VS Code (recommended) with extensions Python, ...
install git (use bash)
install python
set port values
clone repo

project setup

install packages

general
Audience is city employees on PCs. The SCA multipliers repo may have  more up-to-date instructions for PC setup.
random notes while doing setup

python3 ... may not work, but python ... may always work
data/source_data/ could have the PLACEHOLDER.TXT in it

Notes after testing:

stage_0/sanity_check.py

On line 23, need to create databases dir prior to creating a duckdb database (otherwise getting an error):

def create_simple_database():
    # create database dir
    DATABASE_DIRECTORY.mkdir(parents=True, exist_ok=True)
    ...

Either remove inspect_remote_table() or upgrade duckdb

NOTES continue to be edited, ignore for now.

Notes after testing (round 2)

checked off some things from the todo list above
created PR addressing some bugs
stage 2:

issue with explore notebook:

issue with analyze notebook:


Remove the widgetStyling prop.

All such props are now required at the top level of the widget itself.
@TimGuiteDiamond this is what this change would look like. I am tempted to merge this and move on. I might revert some of this later depending on how it pans out.

@TimGuiteDiamond yes, there was some handling of the position here that might not still be there. How did it work?


Issue with larger files

It works fine until we keep uploading documents of size in KBs or max 1 to 2 MB with 15 to 20 pages.
I tried uploading a 15MB PDF with roughly 400 pages. It gets uploaded on the S3 bucket but embedding extraction doesn't fire and i am unable to see the document on front end as well after upload.
I also tried deploying with increased timeout along with no spaces in the name of that large pdf file but it still doesn't work.

Hi, can you take a look at the Lambda function logs and check what error is coming up? If the document does not show up in the UI, the UploadTrigger function is likely failing.

All I can see in Cloudwatch for UploadTrigger is
2023-11-20T17:02:37.976Z d7ee6ba3-62c2-45e6-9aac-2d53b6677503 Task timed out after 3.23 seconds

@pbv0
Hi Pascal, Increased the timeout on the lambda func "UploadTrigger function " but a file with about 32MB does not show up on the UI. It is uploaded on the S3 bucket but not listed on UI.


TextField accessibility on Linux

On Linux, TextField has some accessibility issues.
Steps to reproduce

Run the sample code below
Start Orca screenreader, on systems where it's preinstalled usually by Super+alt+S, or simply by launching orca
In the application window, try to type something in the TextField
Navigate around the field using arrow keys

Expected behavior
When navigating character by character (by left and right arrow keys), Orca should read the currently focused-one.
Up/Down arrow keys (navigation by lines) should cause Orca to read the focused line.
Actual behavior
Orca reports "blank" for almost any kind of movement, except navigation by words (Ctrl+Left & Ctrl+Right), which surprisingly works as it should.
Environment
Ubuntu Mate 22.04 64-bit
Orca 43.1
Sample code
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(
    MaterialApp(
        home: Column(
            children: <Widget>[
                TextField(
                    decoration: InputDecoration(
                        labelText: 'Input some text',
                        ),
                    ),
                ElevatedButton(
                    child: const Text('Close'),
                    onPressed: () => SystemNavigator.pop(),
                    ),
                ],
            )
        ),
    );

Flutter doctor -v output
[✓] Flutter (Channel master, 3.5.0-2.0.pre.23, on Ubuntu 22.04.1 LTS 5.15.0-48-generic, locale sk_SK.UTF-8)
• Flutter version 3.5.0-2.0.pre.23 on channel master at /home/username/snap/flutter/common/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision be86a91654 (76 minutes ago), 2022-10-06 09:35:08 -0700
• Engine revision e72434025f
• Dart version 2.19.0 (build 2.19.0-283.0.dev)
• DevTools version 2.18.0
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /home/username/Android/Sdk
• Platform android-31, build-tools 30.0.3
• ANDROID_SDK_ROOT = /home/username/Android/Sdk
• Java binary at: /usr/lib/jvm/java-11-openjdk-amd64/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.16+8-post-Ubuntu-0ubuntu122.04)
• All Android licenses accepted.
[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
• clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
• cmake version 3.10.2
• ninja version 1.8.2
• pkg-config version 0.29.1
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
[✓] Connected device (1 available)
• Linux (desktop) • linux • linux-x64 • Ubuntu 22.04.1 LTS 5.15.0-48-generic
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 2 categories.

FlAccessibleTextField is missing implementation for some AtkText methods, notably get_text_at/before/after_offset(). We need a way to detect char, word, sentence, and line boundaries. GTK does that with help of Pango.
https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_accessible_text_field.cc#L348


Terminal GIF out of sync with documentation

The GIF in the documentation here:
https://patternplate.github.io/doc/docs/advanced/deploy?guides-enabled=true&advanced-enabled=true#build-a-static-interface
Is out of sync with the written documentation.
How was the GIF created? Happy to fix myself.

Hey @chrisanderss0n, that is a good catch - thank you!
The sequence is a CSS-animated SVG created via svg-term-cli.
The relevant repo that power patternplate.github.com/media is here:
https://github.com/patternplate/media
The setup there works by using casts/build/screencast.config.js to generate docs/casts/cast-build.svg whenever you execute yarn cast in a copy of the media repo.
So, long story short: to change the SVG result you'll have to  change the cast string found in casts/build/screencast.config.js.
Thanks for offering your help, I really appreciate it.


Draft: File structure

@JHocevar can you change the name of the PR to 'Create file structure with crates and connection submodule (Issue #1)' so it's easier to track later?


⚠ Bofrost.es has degraded performance

In dc1c416, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1469 ms

Resolved: Bofrost.es performance has improved in 8cc6ed9 after 19 minutes.


Rust implementation of resolve tilde

see #334

Coverage decreased (-0.04%) to 40.165% when pulling 021c0819041b6eeac57ccebde519c43af2082de9 on ThangaAyyanar:master into 5177cca145d84bc58d6613a0b26ac8c6bf7ef8af on newsboat:master.

Coverage decreased (-0.04%) to 40.165% when pulling 021c0819041b6eeac57ccebde519c43af2082de9 on ThangaAyyanar:master into 5177cca145d84bc58d6613a0b26ac8c6bf7ef8af on newsboat:master.

Cool! Thank you, @ThangaAyyanar!


fix: Update the tox.ini to different tox env

@jorgepiloto @Revathyvenugopal162 how are we doing with this? :)

@jorgepiloto @Revathyvenugopal162 how are we doing with this? :)

Sorry for the delay, I was tied up with the theme reformatting. I’ll dive into this PR next week, fix the issue, and keep you updated on the progress.

@Revathyvenugopal162 @jorgepiloto any update on this?