Gh 1696 add graph with hooks

Codecov Report

Merging #1709 into develop will increase coverage by 1.79%.
The diff coverage is 86.95%.

@@              Coverage Diff              @@
##             develop    #1709      +/-   ##
=============================================
+ Coverage      65.95%   67.74%   +1.79%
+ Complexity      1971      658    -1313
=============================================
  Files            807      368     -439
  Lines          26080    11017   -15063
  Branches        3354     1206    -2148
=============================================
- Hits           17200     7464    -9736
+ Misses          7525     3063    -4462
+ Partials        1355      490     -865

Impacted Files
Coverage Δ
Complexity Δ

...gchq/gaffer/federatedstore/operation/AddGraph.java
93.75% <100%> (+0.2%)
0 <0> (ø)
:arrow_down:

...er/federatedstore/operation/AddGraphWithHooks.java
100% <100%> (ø)
0 <0> (?)

...andler/impl/FederatedAddGraphWithHooksHandler.java
100% <100%> (ø)
0 <0> (?)

...gov/gchq/gaffer/federatedstore/FederatedStore.java
85.13% <100%> (+0.2%)
0 <0> (ø)
:arrow_down:

...eration/handler/impl/FederatedAddGraphHandler.java
100% <100%> (+16.66%)
0 <0> (ø)
:arrow_down:

...ration/handler/FederatedAddGraphHandlerParent.java
71.87% <71.87%> (ø)
0 <0> (?)

...re/operation/handler/export/GetExportsHandler.java

...ion/getelements/handler/GetAllElementsHandler.java

...plementation/raw/CompactRawSerialisationUtils.java

...ache/handler/ExportToGafferResultCacheHandler.java

... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a11f46...2dde200. Read the comment docs.


Redundant shell command in paragraph Scaffold the movie model

In the Visual Studio Code tab on "Scaffold the movie model", there's a redundant line in the installation instructions for macOS/Linux.
Is:
dotnet aspnet-codegenerator razorpage -m Movie -dc RazorPagesMovieContext -udl -outDir Pages/Movies --referenceScriptLibraries
dotnet tool install --global dotnet-aspnet-codegenerator

Should:
dotnet aspnet-codegenerator razorpage -m Movie -dc RazorPagesMovieContext -udl -outDir Pages/Movies --referenceScriptLibraries

Having the additional command might confuse people.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's been reported and it doesn't hurt. We'll address this in the next update.


fix: only retry recoverable socket errors

If the socket fails while there is no active request then it might not be recoverable and we should error and destroy.

Alternatively emit error on the Client?

@mcollina: Should we maybe emit 'error' or some other event on the Client in these cases? I'm unsure...
Another alternative is to not do this PR and instead document that user should handle the 'disconnect' event and determine whether it's "fatal" or not.
@delvedor any opinion?

some other event on the Client in these cases?

Definitely not error. Didn't we have reconnect? I think that's enough.

Didn't we have reconnect? I think that's enough.

We have 'disconnect'. But that's no indication to the user whether it will recover or not. Usually 'disconnect' means that it will retry.

I think having a retry would be nice.

@mcollina: Another solution, which I feel is less controversial would be:

If socket errors without any request being dispatched/running, error all pending requests with this error.

Basically what we are doing here https://github.com/mcollina/undici/commit/e1f176c9e91fd82aaa4516e43c42b69a1cea3e86#diff-d4588047630c1180b519ff7191a2cf29R475 but with a "if (!running)" condition.

go for it

@mcollina PTAL


Fix heading order

Follow-up to #2755 and #2752
In order to make the pages more accessible, headings should follow a sequential, descending order, and shouldn't skip a level. With this PR, this will fix it for

https://www.coronawarn.app/en/terms-of-use/
https://www.coronawarn.app/en/imprint/
https://www.coronawarn.app/en/privacy/

Changes approved, thanks @larswmh !


Use TypeScript instead of JavaScript for code/tests

What would you like node-schedule to be able to do?

It's probably a good idea to use TypeScript instead of JavaScript, so that we're consistent with our programming language between this repository and the main Renovate repository.
As an added bonus we'll probably have a safer programming language to work in, so that we can catch stupid stuff earlier. 😄
Did you already have any implementation ideas?

I've taken a look at the migration guide from JavaScript to TypeScript in the official Typescript docs, it shouldn't be that hard for a programmer familiar with TypeScript to migrate this repository and tooling.
I'm not that good with TypeScript (or JavaScript for that matter 🙈 ) to be able to migrate us. So I'd like somebody else to do this, or maybe we could do it together, so that I can learn a bit (but that'll slow you down...).
TypeScript docs on migrating from JavaScript

I'm not familiar with the codebase, but I'm open to help wherever I can.

@patlehmann1 Thank you for wanting to help! 😄 👍
There's really only 2 files with relevant code, the index.js file in /src and the test.js file in /test.
The basic idea is that we load in the schedule.json file in the root of the repo, and use that in index.js with some functions.
The tests are written in Jest they should be do-able to migrate to TypeScript as well.
A basic JavaScript to TypeScript conversion following the official TypeScript docs is enough for now. We can make it prettier/better once we actually get things working under TypeScript. 😉

@rarkins do you have any requirements?

@viceice What do you think?

sure, good idea. But i'm out of time to do the convert. sorry.

I've just checked the code and tests, and I'm not completely happy with either.
So before you start I'd like to try to clean it up a bit... 😄
Put input validation into own function inputValidation to sanitize the input:

[ ] Throw error on for bad input (non-sensical strings!)
[ ] Reject input that exceeds reasonable bounds (version character limit set to something reasonable)
[ ] Clearer error messages

Tests:

[ ] Also the tests are testing too much at once, so I'd like to make it so that tests only test one specific thing at a time.
[ ] Add tests for input validation, test each Error reason seperately

Hi @patlehmann1, I've done the cleanup/refactoring that I can do right now, and I've added a simple Jest test configuration.
You're good to migrate the code from JavaScript to TypeScript now. 😉

@HonkingGoose it will probably take me a while to get familiar with the codebase here, but I'll see what I can do.


Update smtp-python-code-example.md

This is to organize x-smtpapi content under its own group. This goes with https://github.com/sendgrid/docs/pull/4248

Hello @kylearoberts,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Fix Observability BBE content

Purpose
BBEs are not displaying in ballerina-www due to un-commented description line. This will fix that.
Fixes https://github.com/ballerina-platform/ballerina-www/issues/1591
Remarks
https://github.com/ballerina-platform/ballerina-www/issues/1591

Codecov Report

Merging #18991 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18991   +/-   ##
=======================================
  Coverage    15.8%    15.8%
=======================================
  Files          47       47
  Lines        1259     1259
  Branches      196      196
=======================================
  Hits          199      199
  Misses       1047     1047
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71143a...e0a4089. Read the comment docs.


Password Reset Framework Breaks When Altering Where Email Is Stored

Background
I ran the default authentication/registration scaffolding [php artisan make:auth].  I needed to alter authenticating with a username/password rather than email/password so I converted the model/views/config/tables and I can authenticate and register.  That is working great.
Issue
The email of a user is located in another model/class (with a foreign key back to the user model).  Inside the User model I attempted to override the getEmailAttribute function like I've done to many of the other models but the password reset framework doesn't access the email attribute in this manner and when you attempt to submit your email address [http://localhost:8000/password/reset] laravel throws a SQL error: "Column not found: 1054 Unknown column 'email' in 'where clause' "
In a nutshell, my user's username/password are in the out-of-the-box User model but their email is in a related model/table.

@justautomated the existing scaffold is written with a convenience in mind, for special cases like this one I suggest you build your own or try to extend the current one.
Closing since this is not actually a bug report.


var(--os-accent-color);

With BD 1.9.4 a new variable has been added, that returns the accent color of the OS on the moment discord was opened, the color does not change on real time at least on windows and to change the color you need to restart discord.
It would be great if I manage to implement the variable as the accent color, but the variable returns an 8 digits hex color, and the current theme uses rgb components to be able to change the alpha for some components.
With the color-mix function it should be posible to change the alpha of the hex color, but it will mean changing every single reference of the current --accent color.

Marked as done. Thanks to the latest the new variable is easily usable. It stills requieres a discord restart if you change the OS color (at least on Windows 11)


Is there any flutter version?

This repository will only maintain the Android app inference the Segment-Anything model. Did a quick Google search and found this Flutter package: https://pub.dev/packages/segment_anything

This repository will only maintain the Android app inference the Segment-Anything model. Did a quick Google search and found this Flutter package: https://pub.dev/packages/segment_anything

i had seen its code, it only draw the mask on the image.

This repository will only maintain the Android app inference the Segment-Anything model. Did a quick Google search and found this Flutter package: https://pub.dev/packages/segment_anything

ok, tks


Add information about the effect of changing a site address on an eDiscovery Search or Hold

Please add information about the effect of changing a site address on an eDiscovery Search or Hold.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5475fd83-52fa-6d49-d08f-fc75fabee09c
Version Independent ID: 19ede247-e62c-9f1a-700c-4c878fec7f78
Content: Change a site address - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/change-site-address.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @exactmike
I tested this on my tenant, once I added the site to a case, the option to change the address was disabled:

This site's URL can't be changed because the site or a subsite within it is included in an eDiscovery hold or retention policy.

Hope this clarifies it to you.


Consider DSL-JSON as an alternative to Jackson / GSon

Micro benchmarks, e.g. https://github.com/fabienrenaud/java-json-benchmark, clearly show a significant performance advantage of DSL-JSON (https://github.com/ngs-doo/dsl-json) when compared to virtually any other library. It might be worthwhile to assess whether DSL-JSON can be easily embedded and used for NEBA's JSON rendering.

The issue here is compatibility. NEBA is using the Jackson libraries shipped with Sling / AEM and attempts to stay as close as possible to the behavior of the Sling Exporter framework. Migrating to DSL-JSON would mean taking an entirely different approach.
Furthermore, Jackson's performance is not to far off from DSL-JSON to justify such a deviation.
Closing as won't fix.


difference-of-squares: renamed square-of-sums to square-of-sum

In exercise "difference-of-squares", renamed square-of-sums to square-of-sum. Also renamed difference of-sums to difference-of-squares.

thanks!


IE layout bug: red arrow

Mitigation (for IE only): margin-top: -800px; -> out of screen -> hidden.
Better no arrow, than a misplaced arrow.


New command: Renew Office 365 group's expiration

Renews Office 365 group's expiration

command: graph o365group renew -i|--groupId <groupId>
groupId - The ID of the group to renew

API call: https://docs.microsoft.com/en-us/graph/api/group-renew?view=graph-rest-1.0

Hey @waldekmastykarz I could take this one next.

Excellent! Appreciate your help @rabwill 👏


Add Support for Android API 21

Currently, the minimum API level for this project is set to 24, but I need support for API 21.
This would require only minor changes.
libs.verions.toml:
[versions]
...
library-desugaring = "2.1.3"

[libraries]
...
library-desugaring = { group = "com.android.tools", name = "desugar_jdk_libs", version.ref = "library-desugaring" }
...

build.gradle.kts:
...
kotlin {
  androidTarget {
    publishAllLibraryVariants()
    compilations.all { kotlinOptions { jvmTarget = "1.8" } }
  }
...
}

android {
...
defaultConfig {  minSdk = 21  }
...
compileOptions {
    isCoreLibraryDesugaringEnabled = true

    sourceCompatibility = JavaVersion.VERSION_1_8
    targetCompatibility = JavaVersion.VERSION_1_8
  }
}

dependencies {
  coreLibraryDesugaring(libs.library.desugaring)
}
...

source

Not necessary, this will solve the problem:
AndroidManifest.xml
    <uses-sdk
        android:minSdkVersion="21"
        tools:overrideLibrary="com.appstractive.dnssd" />

Have you checked this on a real device with sdk21? I will look into implementing your suggestion, so that workaround wouldn't be needed then.

Only on emulator for now, but it works there.

private fun NsdServiceInfo.getAddresses(): List<String> {
  if (VERSION.SDK_INT >= VERSION_CODES.UPSIDE_DOWN_CAKE) {
    return hostAddresses.mapNotNull { it.hostAddress }
  }

  return host.hostAddress?.let { listOf(it) } ?: emptyList()
}

private fun NsdServiceInfo.getHostName(): String? {
  if (VERSION.SDK_INT >= VERSION_CODES.UPSIDE_DOWN_CAKE) {
    return hostAddresses.firstOrNull()?.canonicalHostName
  }

  return host.canonicalHostName
}

maybe you could put a "?" after the host here, because the emulator will crash without it.
return host?.canonicalHostName

return host?.hostAddress?.let { listOf(it) } ?: emptyList()

I ran it on a real device, it works.

I have implemented your suggestions in this branch: https://github.com/Appstractive/dns-sd-kt/tree/fix/txt_resolve_android
Can you please check if that is working as expected on the device? Thanks!

Unfortunately, I encounter a problem during execution:

FATAL EXCEPTION: NsdManager
Process: com.appstractive.dnssd.androidApp, PID: 9083
java.lang.NoClassDefFoundError: Failed resolution of: Lcom/appstractive/dnssd/MDNSDiscover;
at com.appstractive.dnssd.Discovery_androidKt$discoverServices$1$resolveService$1$1.onServiceResolved(Discovery.android.kt:45)
at android.net.nsd.NsdManager$ServiceHandler.handleMessage(NsdManager.java:369)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.os.HandlerThread.run(HandlerThread.java:61)
Caused by: java.lang.ClassNotFoundException: Didn't find class "com.appstractive.dnssd.MDNSDiscover" on path: DexPathList[[zip file "/data/app/com.appstractive.dnssd.androidApp-2/base.apk"],nativeLibraryDirectories=[/data/app/com.appstractive.dnssd.androidApp-2/lib/x86_64, /vendor/lib64, /system/lib64]]
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
at com.appstractive.dnssd.Discovery_androidKt$discoverServices$1$resolveService$1$1.onServiceResolved(Discovery.android.kt:45)
at android.net.nsd.NsdManager$ServiceHandler.handleMessage(NsdManager.java:369)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.os.HandlerThread.run(HandlerThread.java:61)
Suppressed: java.lang.ClassNotFoundException: com.appstractive.dnssd.MDNSDiscover
at java.lang.Class.classForName(Native Method)
at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
... 6 more
Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available

I don't know what the problem is, because the class is available in the classes2.dex file.

Strange, it works fine on my device and SDK21 Emulator.

Then maybe the problem is with me, I just updated it because AGP 8.7.2 was not supported.

Might be R8 related. When I try to build the app with isMinifyEnabled = true, then I get an error:
Missing class com.appstractive.dnssd.MDNSDiscover$Result (referenced from: void com.appstractive.dnssd.Discovery_androidKt$discoverServices$1$resolveService$1$1.onServiceResolved(android.net.nsd.NsdServiceInfo))
Missing class com.appstractive.dnssd.MDNSDiscover$TXT (referenced from: void com.appstractive.dnssd.Discovery_androidKt$discoverServices$1$resolveService$1$1.onServiceResolved(android.net.nsd.NsdServiceInfo))
Missing class com.appstractive.dnssd.MDNSDiscover (referenced from: void com.appstractive.dnssd.Discovery_androidKt$discoverServices$1$resolveService$1$1.onServiceResolved(android.net.nsd.NsdServiceInfo))

Adding these rules doesn't work though:
-keep class com.appstractive.dnssd.MDNSDiscover$Result
-keep class com.appstractive.dnssd.MDNSDiscover$TXT
-keep class com.appstractive.dnssd.MDNSDiscover

I have moved the .java class to a separate module now. That seems to have fixed the issue. Can you check again?

Version 1.0.3 should be available shortly. Thanks for your help!

Although the "sample" project works fine, unfortunately when I implement it in my project, it says this during sync:

Failed to resolve: DNS-SD:lib-java:unspecified
Affected Modules: composeApp

and this during build:

Execution failed for task ':composeApp:checkDebugAarMetadata'.

Could not resolve all files for configuration ':composeApp:debugRuntimeClasspath'.
Could not find DNS-SD:lib-java:unspecified.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/DNS-SD/lib-java/unspecified/lib-java-unspecified.pom
- file:/C:/Users/user/.m2/repository/DNS-SD/lib-java/unspecified/lib-java-unspecified.pom
Required by:
project :composeApp > com.appstractive:dns-sd-kt:1.0.3 > com.appstractive:dns-sd-kt-android-debug:1.0.3

Could you try implementing it into another project to see if the issue is on me? Thanks.

Yes, sorry. lib-java was not inlcuded into the publication. In 1.0.4 it is.


Typescript support

Are you planning on adding support for typescript?

Can you do something to help me by a pr？

hope, #107 can help

666

@hustcc lol, what's that?

6 has the same pronunciation with 牛 in Chinese, 牛 is cow, but has meaning of perfect, or very good in somewhere.
666(three 6) means very very very good, and admire you for your develop ability.

@hustcc wow, very instructive, thank you
@rileystroud can you please try this branch and confirm if it works for you? You can install it through npm like:
npm install hustcc/timeago.js#ts-support

@rileystroud merge into master, so just npm install hustcc/timeago.js for test.

@hustcc probably you need to update npm version for that and update dist files (sorry, I didn't make it in #110, because didn't know you will merge it so soon)

It's not working for me on my first pass. I'll get back to it in a couple hours

@rileystroud how did you install it? can you check if typings present in your node_modules/timeago.js folder?

It installed fine. The typescript code wasn't compiling to the correct javascript.
import timeagoFactory from 'timeago.js'
const timeAgo = timeagoFactory()
timeAgo.format('01-01-2017')

compiled to
const timeago_js_1 = require("timeago.js");
const timeAgo = timeago_js_1.default();
timeAgo.format('01-01-2017');

but there is no default function defined.
With #112,
import * as timeago from 'timeago.js'
const timeAgo = timeago()
timeAgo.format('01-01-2017')

compiles to the expected
const timeagoFactory = require("timeago.js");
const timeAgo = timeagoFactory();
timeAgo.format('01-01-2017');

I checked out your version (#112), it doesn't even compile with typescript ^2.2.1:
app.ts(1,8): error TS1192: Module '"timeago-test/node_modules/timeago.js/timeago"' has no default export.
Command failed: tsc

@likerRr Did you update the import statement as above?

Yes, sorry, you was right, I incorrectly imported the module. Finally it works for me.
But, honestly, I have doubts. Your variant works fine, but syntax import * as timeago from 'timeago.js' is quite redundant. It's readed as "import all the members as timeago namespace\variable", but in fact there is only one exported member - timeago factory. I think, that interfaces TimeAgoConstructor and TimeAgo shouldn't be part of the timeago factory, but as separate entities. Also such typings add some trash (interfaces) to autocomplite in IDE.
Second moment - let's look on the problem from other side. If we write clear typescript file:
// hello.ts
export default function hello() {};

and compile it with such ts config:
{
  "compilerOptions": {
    "module": "commonjs",
    "target": "es5"
  }
}

Generated js file will be:
"use strict";
exports.__esModule = true;
var Hello = (function () {
    function Hello() {
    }
    return Hello;
}());
exports["default"] = Hello;

As far as we see, default becomes a member of exports, and this file becomes ES6-import style compatible. The same story if we try to compile such code with babel:
// hello.js
export default function hello() {};

// hello.transpiled.js
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.default = hello;
function hello() {};

Both Typescript and Babel (webpack 2 does the same, but output is quite bigger) transpile default ES6 style import to ES5 style by adding default property to exports. So, if we want timeago to become compatible with ES6 default import (I mean support syntax like import timeago from 'timeago.js'), we need modify a module pattern a little:
// now
  if (typeof module === 'object' && module.exports)
    module.exports = factory(root);

// will become
  if (typeof module === 'object' && module.exports) {
    module.exports = factory(root); // nodejs support
    module.exports['default'] = module.exports; // es6 support
  }

@hustcc It will also solve this issue #105
If we do so, then typings that are currently in the project will become working.
So, we should decide:

Should we support ES6 default import compatible with commonjs?
1.1. If yes, then leave typings as they are for now and modify module pattern implementation
1.2. If no, accept PR by @rileystroud that fixes typings, no other modification is needed. Issue #105 needs more research.

Probably I misunderstand something, correct me if I'm wrong

@rileystroud @likerRr  I think export default is the reason. So I think method 1.1 is better, also can solve #105.

Shouldn't the constructor return an instance of itself?
(Notice the this in the new() signatures.)
/// <reference types="jquery" />
type TDate = Date | string | number;
export interface TimeAgoConstructor {
    new (): this;
    new (nowDate: TDate, defaultLocale?: string): this;
    format(date: TDate, locale?: string): string;
    render<T>(nodes: Node | NodeList | JQuery, locale?: string): void;
    setLocale(locale: string): void;
}
export interface TimeagoFactory {
    (): TimeAgoConstructor;
    (nowDate: TDate, defaultLocale?: string): TimeAgoConstructor;
    cancel(node?: Node | JQuery): void;
    register(locale: string, localeFunc: Function): void;
}
declare let timeagoFactory: TimeagoFactory;
export default timeagoFactory;

I hope this keyword is implied. Anyway now it doesn't generate compilation errors

@estk constructor is removed since the timeagoFactory returns an instance #126


OnTrack not getting called on SIP INVITE

Hi @Sean-Der
its been a minute, hope everything is good :-)
I am trying to accept an INVITE via SIP but OnTrack never gets called.
It would be great if you could have a look over my trace. (External ips replaced with letters)
Here we go with the INVITE:
INVITE sip:197d29d5-e957-449a-891d-e0cb9f615fd9@5acc3a15-f912-4547-b86a-4bbf132181cd.invalid;transport=ws SIP/2.0
Record-Route: <sip:aa.bb.cc.dd;transport=ws;r2=on;lr>
Record-Route: <sip:aa.bb.cc.dd;r2=on;lr>
Record-Route: <sip:<IP_ADDRESS>;lr>
Record-Route: <sip:ee.ff.gg.hh;lr>
Via: SIP/2.0/WSS aa.bb.cc.dd;branch=z9hG4bK66ee.c4724b4370ecb5c3dcc00ec41e74c938.0
Via: SIP/2.0/UDP <IP_ADDRESS>;branch=z9hG4bK66ee.6baa531ca900f277614865f0fbdc46b0.0
Via: SIP/2.0/UDP ee.ff.gg.hh;branch=z9hG4bK66ee.3c2750b4807ad16cd2b9ace0cce05e17.0
Via: SIP/2.0/UDP ii.jj.kk.ll:5060;branch=z9hG4bK3c33b85b
Max-Forwards: 67
From: <sip:15@sip.sip>;tag=as038ab825
To<EMAIL_ADDRESS>Contact: <sip:15@ii.jj.kk.ll:5060>
Call-ID<EMAIL_ADDRESS>CSeq: 103 INVITE
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces
Content-Type: application/sdp
Content-Length: ...

v=0
o=root<PHONE_NUMBER><PHONE_NUMBER> IN IP4 mm.nn.oo.pp
s=sip.sip
c=IN IP4 mm.nn.oo.pp
t=0 0
m=audio 29590 RTP/SAVPF 9 8 0 3 97 18 112 101
a=rtpmap:9 G722/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:3 GSM/8000
a=rtpmap:97 iLBC/8000
a=fmtp:97 mode=30
a=rtpmap:18 G729/8000
a=fmtp:18 annexb=no
a=rtpmap:112 G726-32/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=sendrecv
a=rtcp:29591
a=rtcp-mux
a=setup:actpass
a=fingerprint:sha-256 B3:E4:5B:AD:F3:69:8C:E1:C9:1B:9A:AA:34:24:48:78:E2:84:96:83:A0:3E:85:84:6E:85:82:81:58:41:65:39
a=ptime:20
a=ice-ufrag:RVBcKy8v
a=ice-pwd:59emabongM8yrR9yqrLTo2TXOi
a=candidate:iGxmvPoGN4amefTD 1 UDP<PHONE_NUMBER> mm.nn.oo.pp 29590 typ host
 =candidate:iGxmvPoGN4amefTD 2 UDP<PHONE_NUMBER> mm.nn.oo.pp 29591 typ host

followed by these:
pc INFO: 2023/02/18 12:30:59 signaling state changed to have-remote-offer
ice TRACE: 12:30:59.376780 agent.go:583: Unset selected candidate pair
pc INFO: 2023/02/18 12:30:59 signaling state changed to stable

<-gatherComplete
ice DEBUG: 12:30:59.377138 agent.go:466: Started agent: isControlling? false, remoteUfrag: "RVBcKy8v", remotePwd: "59emabongM8yrR9yqrLTo2TXOi"
ice INFO: 2023/02/18 12:30:59 Setting new connection state: Checking
pc INFO: 2023/02/18 12:30:59 ICE connection state changed: checking
ice DEBUG: 12:30:59.377583 gather.go:197: GetConn by ufrag: GiTcDzZcHXCxQgjM
ice TRACE: 12:30:59.377658 agent.go:606: pinging all candidates
ice TRACE: 12:30:59.377838 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29591
ice TRACE: 12:30:59.377977 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29590
ice TRACE: 12:30:59.382827 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29591 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.382923 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>357619712 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29591 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.384851 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.384923 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>652587007 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.407757 agent.go:606: pinging all candidates
ice TRACE: 12:30:59.407865 agent.go:974: ping STUN from udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 to udp4 host mm.nn.oo.pp:29591
ice TRACE: 12:30:59.407976 agent.go:974: ping STUN from udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 to udp4 host mm.nn.oo.pp:29590

maybe the problem is in my OK message and thats why no audio is coming from the gateway:
SIP/2.0 200 OK
Via: SIP/2.0/WSS aa.bb.cc.dd;branch=z9hG4bK66ee.c4724b4370ecb5c3dcc00ec41e74c938.0
Via: SIP/2.0/UDP <IP_ADDRESS>;branch=z9hG4bK66ee.6baa531ca900f277614865f0fbdc46b0.0
Via: SIP/2.0/UDP ee.ff.gg.hh;branch=z9hG4bK66ee.3c2750b4807ad16cd2b9ace0cce05e17.0
Via: SIP/2.0/UDP ii.jj.kk.ll:5060;branch=z9hG4bK3c33b85b
From: <sip:15@sip.sip>;tag=as038ab825
Call-ID<EMAIL_ADDRESS>CSeq: 103 INVITE
Content-Type: application/sdp
Contact: <sip:197d29d5-e957-449a-891d-e0cb9f615fd9@5acc3a15-f912-4547-b86a-4bbf132181cd.invalid;transport=ws>
Record-Route: <sip:aa.bb.cc.dd;transport=ws;r2=on;lr>
Record-Route: <sip:aa.bb.cc.dd;r2=on;lr>
Record-Route: <sip:<IP_ADDRESS>;lr>
Record-Route: <sip:ee.ff.gg.hh;lr>
Supported: path, replaces, outbound, timer, norefersub, ice
To: <sip:12@sip.sip>;tag=f0bc1b17-e3ff-4ba3-bea8-06a6201f569e
Content-Length: ...

v=0
o=-<PHONE_NUMBER>51942694<PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=-
t=0 0
a=fingerprint:sha-256 6D:22:F6:6D:77:69:3A:FA:CA:28:9A:EF:D4:3C:D7:90:C7:BC:3B:DF:33:65:B6:92:32:3B:8D:D1:1F:05:B3:12
a=group:BUNDLE 0
m=audio 9 UDP/TLS/RTP/SAVPF 0
c=IN IP4 <IP_ADDRESS>
a=setup:active
a=mid:0
a=ice-ufrag:GiTcDzZcHXCxQgjM
a=ice-pwd:RbeMTqzXvouYXWTlNHyojnICSuJnRBQL
a=rtcp-mux
a=rtcp-rsize
a=rtpmap:0 PCMU/8000
a=ssrc:1917240452 cname:BbINqxxFMkzdNqlH
a=ssrc:1917240452 msid:BbINqxxFMkzdNqlH NaVfZFMdzVimUwIA
a=ssrc:1917240452 mslabel:BbINqxxFMkzdNqlH
a=ssrc:1917240452 label:NaVfZFMdzVimUwIA
a=msid:BbINqxxFMkzdNqlH NaVfZFMdzVimUwIA
a=sendrecv
a=candidate:4237655428 1 udp<PHONE_NUMBER> <IP_ADDRESS> 10008 typ host
a=candidate:4237655428 2 udp<PHONE_NUMBER> <IP_ADDRESS> 10008 typ host
a=candidate:4073560724 1 udp<PHONE_NUMBER> ww.xx.yy.zz 10092 typ srflx raddr <IP_ADDRESS> rport 10092
a=candidate:4073560724 2 udp<PHONE_NUMBER> ww.xx.yy.zz 10092 typ srflx raddr <IP_ADDRESS> rport 10092
 =end-of-candidates

and the trace following that:
ice TRACE: 12:30:59.412887 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.412932 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>102668288 (local, prio<PHONE_NUMBER>) udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.414639 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29591 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.414677 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>102668286 (local, prio<PHONE_NUMBER>) udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 <-> udp4 host mm.nn.oo.pp:29591 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.416288 agent.go:1124: inbound STUN (Request) from mm.nn.oo.pp:29591 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.416413 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29591
ice TRACE: 12:30:59.421301 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29591 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.421338 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>357619712 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29591 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.424724 agent.go:1124: inbound STUN (Request) from mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.424853 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29590

receiving the remote ACK in between:
ACK sip:197d29d5-e957-449a-891d-e0cb9f615fd9@5acc3a15-f912-4547-b86a-4bbf132181cd.invalid;transport=ws SIP/2.0
Via: SIP/2.0/WSS aa.bb.cc.dd;branch=z9hG4bK66ee.1132227567a53f185249d7ff0d113ab3.0
Via: SIP/2.0/UDP <IP_ADDRESS>;branch=z9hG4bK66ee.ea8f57a0bf28b48a3393353e39b62947.0
Via: SIP/2.0/UDP ee.ff.gg.hh;branch=z9hG4bK66ee.b92327116414ef5921a1236e0693cb6f.0
Via: SIP/2.0/UDP ii.jj.kk.ll:5060;branch=z9hG4bK4db1f45f
Max-Forwards: 67
From: <sip:15@sip.sip>;tag=as038ab825
To: <sip:12@sip.sip>;tag=f0bc1b17-e3ff-4ba3-bea8-06a6201f569e
Contact: <sip:15@ii.jj.kk.ll:5060>
Call-ID<EMAIL_ADDRESS>CSeq: 103 ACK
Content-Length: 0

and more TRACEs:
ice TRACE: 12:30:59.431696 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.431733 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>652587007 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.444637 agent.go:1124: inbound STUN (Request) from mm.nn.oo.pp:29591 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.444757 agent.go:974: ping STUN from udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 to udp4 host mm.nn.oo.pp:29591
ice TRACE: 12:30:59.451734 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29591 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.451771 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>102668286 (local, prio<PHONE_NUMBER>) udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 <-> udp4 host mm.nn.oo.pp:29591 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.462843 agent.go:1124: inbound STUN (Request) from mm.nn.oo.pp:29590 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.462968 agent.go:974: ping STUN from udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 to udp4 host mm.nn.oo.pp:29590
ice TRACE: 12:30:59.468088 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092
ice TRACE: 12:30:59.468126 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>102668288 (local, prio<PHONE_NUMBER>) udp4 srflx ww.xx.yy.zz:10092 related <IP_ADDRESS>:10092 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
ice TRACE: 12:30:59.531822 agent.go:1124: inbound STUN (Request) from mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.531880 agent.go:589: Set selected candidate pair: prio<PHONE_NUMBER>652587007 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
ice INFO: 2023/02/18 12:30:59 Setting new connection state: Connected
ice TRACE: 12:30:59.532073 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29590
dtls TRACE: 12:30:59.532169 handshaker.go:173: [handshake:client] Flight 1: Preparing
dtls TRACE: 12:30:59.532226 handshaker.go:173: [handshake:client] Flight 1: Sending
pc INFO: 2023/02/18 12:30:59 ICE connection state changed: connected
dtls TRACE: 12:30:59.532276 conn.go:397: [handshake:client] -> ClientHello (epoch: 0, seq: 0)

here the OnICEConnectionStateChange gets called and is connected
dtls TRACE: 12:30:59.532440 handshaker.go:173: [handshake:client] Flight 1: Waiting
ice TRACE: 12:30:59.538784 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:30:59.538819 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>652587007 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)
dtls TRACE: 12:30:59.539771 flight3handler.go:87: [handshake] use cipher suite: TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
dtls TRACE: 12:30:59.540246 handshaker.go:289: [handshake:client] Flight 1 -> Flight 5
dtls TRACE: 12:30:59.540268 handshaker.go:173: [handshake:client] Flight 5: Preparing
dtls TRACE: 12:30:59.541104 handshaker.go:241: [handshake:client] -> changeCipherSpec (epoch: 1)
dtls TRACE: 12:30:59.541129 handshaker.go:173: [handshake:client] Flight 5: Sending
dtls TRACE: 12:30:59.541146 conn.go:397: [handshake:client] -> TypeCertificate (epoch: 0, seq: 1)
dtls TRACE: 12:30:59.541177 conn.go:397: [handshake:client] -> ClientKeyExchange (epoch: 0, seq: 2)
dtls TRACE: 12:30:59.541196 conn.go:397: [handshake:client] -> CertificateVerify (epoch: 0, seq: 3)
dtls TRACE: 12:30:59.541222 conn.go:397: [handshake:client] -> Finished (epoch: 1, seq: 4)
dtls TRACE: 12:30:59.541394 handshaker.go:173: [handshake:client] Flight 5: Waiting
dtls TRACE: 12:30:59.549608 conn.go:753: client: <- ChangeCipherSpec (epoch: 1)
dtls TRACE: 12:30:59.549735 handshaker.go:289: [handshake:client] Flight 5 -> Flight 5
dtls TRACE: 12:30:59.549760 handshaker.go:173: [handshake:client] Flight 5: Finished
dtls TRACE: 12:30:59.549791 conn.go:226: Handshake Completed
pc INFO: 2023/02/18 12:30:59 peer connection state changed: connected

now the OnConnectionStateChange is also connected
i am getting one of these:
ice TRACE: 12:30:59.609017 selection.go:173: checking keepalive
and those keep repeating until CTRL-C
ice TRACE: 12:31:01.610210 selection.go:173: checking keepalive
ice TRACE: 12:31:01.610332 agent.go:974: ping STUN from udp4 host <IP_ADDRESS>:10008 to udp4 host mm.nn.oo.pp:29590
ice TRACE: 12:31:01.617072 selection.go:221: inbound STUN (SuccessResponse) from udp4 host mm.nn.oo.pp:29590 to udp4 host <IP_ADDRESS>:10008
ice TRACE: 12:31:01.617112 selection.go:231: Found valid candidate pair: prio<PHONE_NUMBER>652587007 (local, prio<PHONE_NUMBER>) udp4 host <IP_ADDRESS>:10008 <-> udp4 host mm.nn.oo.pp:29590 (remote, prio<PHONE_NUMBER>)

Any help is highly appreciated!
Thanks in advance and keep up the amazing work!

Really sorry @elm0 that I didn't respond to this sooner! Hopefully you were able to get it working.
If not I would love to help debug. I will do a better job of staying on top of this bug tracker going forward.


Remove index-card CSS into it's own package

Make index-card it's own repository. This package would then depend on it and use postcss-import to import the css module when building the css for the demo.
Also, the demo should show off the card in two ways:

With barebone CSS
With index-card CSS

This was done ages ago


Parallel execution is slower than no-parallel execution in some cases

It is being a while that I was aware of this issue but with parallel becoming the default I decided to report.
For some reason that I could not identify yet, our RuboCop setup in our main application is slower when trying to run in parallel.
I'm opening this issue to get some help from the maintainers on what should I debug or even see if just by looking the problem description the team have ideas on how to optimize.
I'll try to profile the execution tomorrow using stackprof so we know exactly where we are using most of this time.
All those executions are with 32 threads, so my theory is that we have some kind of contention and process are waiting for each other, or that creating process are more expensive than the checks that needs to be executed.
The user experience also degrades a lot. Most of those 500s are waiting the cache to warm up, so no output is generate. A few people think rubocop is stuck and abort the execution, due the lack of output.
No parallel
√ [ruby-3.0.1] /src/github.com/shopify/shopify [master] $ time bin/rubocop --no-parallel components/platform
warning: parser/current is loading parser/ruby30, which recognizes
warning: 3.0.2-compliant syntax, but you are running 3.0.1.
warning: please see [https://github.com/whitequark/parser#compatibility-with-ruby-mri](https://github.com/whitequark/parser#compatibility-with-ruby-mri).
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

Please also note that you can opt-in to new cops by default by adding this to your config:
AllCops:
NewCops: enable

Lint/AmbiguousRange: # new in 1.19
Enabled: true
Style/RedundantSelfAssignmentBranch: # new in 1.19
Enabled: true
For more information: [https://docs.rubocop.org/rubocop/versioning.html](https://docs.rubocop.org/rubocop/versioning.html)
Inspecting 2686 files
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

2686 files inspected, no offenses detected
bin/rubocop --no-parallel components/platform  335.03s user 2.74s system 97% cpu 5:47.16 total

With parallel
√ [ruby-3.0.1] /src/github.com/shopify/shopify [master] $ time bin/rubocop components/platform
warning: parser/current is loading parser/ruby30, which recognizes
warning: 3.0.2-compliant syntax, but you are running 3.0.1.
warning: please see [https://github.com/whitequark/parser#compatibility-with-ruby-mri](https://github.com/whitequark/parser#compatibility-with-ruby-mri).
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

Please also note that you can opt-in to new cops by default by adding this to your config:
AllCops:
NewCops: enable

Lint/AmbiguousRange: # new in 1.19
Enabled: true
Style/RedundantSelfAssignmentBranch: # new in 1.19
Enabled: true
For more information: [https://docs.rubocop.org/rubocop/versioning.html](https://docs.rubocop.org/rubocop/versioning.html)
Inspecting 2686 files
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

2686 files inspected, no offenses detected
bin/rubocop components/platform  556.66s user 17.88s system 501% cpu 1:54.58 total

Steps to reproduce the problem
Not sure how to reproduce the problem outside of our codebase, but I'm willing to help you folks test your theories with my setup and maybe trim down our setup so we can publish a public reproduction script.
Part of our config is public at https://github.com/Shopify/ruby-style-guide/blob/main/rubocop.yml, but we have a few lines (20007 lines) in .rubocop_todo.yml and a few custom cops and rubocop-rails enabled.
RuboCop version
$ bin/rubocop -V
1.20.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.11.0, running on ruby 3.0.1 x86_64-linux)
  - rubocop-performance 1.11.5
  - rubocop-rails 2.11.3
  - rubocop-sorbet 0.6.2

I just got the profiling done.
It can be inspect at https://www.speedscope.app/.
Both CPU and WALL mod can be found in this gist https://gist.github.com/rafaelfranca/0de3e6ba16c0ebda8a4707c68754f307.
If I'm reading those results right, and if they are really correct, most of the time waiting for the thread value.

Forget that. Of course the profiling will only show the waiting thread. That is the only work done in the main process. I still believe the problem is on the scheduling of those processes.

@rafaelfranca Doesn't the output say that it took 5 minutes 47.16 seconds without parallel and 1 minute 54.58 seconds with parallel execution? And those 500s you mention are "CPU seconds", right?
Am I missing something, because that all looks normal to me?

556.66s is real time

lol, right, that is the total CPU seconds. The time is really 1:54s. The UX is still a problem though since we wait all the 2 minutes to see any output. But I think that is acceptable.


New SignOut icon

New icon based on the design of the "download" icon.

Since the content of this PR has been moved to substra-front instead, it is no longer interesting to keep it.


Add unknown state to VMs

The VM controller needs to check, if e.g. the synchronized condition on the VM is not updated every X seconds, we need to move the VM to state "UNKNOWN", since we don't know what is going on with it.
The situation is easy to reproduce: Schedule a VM on e.g. node0 and kill node0 after the VM entered the Running state. Until the VM comes up again, the VM will be shown as Running.

@mz-pdm that might be an issue which interests you ...

@rmohr, definitely, thank you, I'll look at it.

@rmohr, could you please clarify what you mean with "synchronized condition"? Do you mean some particular entity already present in KubeVirt or is it just a general term for something to be introduced for the purpose?

@mz-pdm here you see a VM which can't start because the iscsi connection string is wrong. The error is shown in the synchronized condition (type: Synchronized). And the status of the condition is false.
apiVersion: v1
items:
- apiVersion: kubevirt.io/v1alpha1
  kind: VirtualMachine
  [...]
  status:
    conditions:
    - lastProbeTime: null
      lastTransitionTime: 2017-11-30T11:27:51Z
      message: |-
        virError(Code=1, Domain=10, Message='internal error: process exited while connecting to monitor: 2017-11-30T11:27:51.427771Z qemu-system-x86_64: -chardev pty,id=charserial0: char device redirected to /dev/pts/0 (label charserial0)
        2017-11-30T11:27:51.433617Z qemu-system-x86_64: -drive file=iscsi://<IP_ADDRESS>:3260/iqn.2017-01.io.kubevirt%3Asn.42/,format=raw,if=none,id=drive-virtio-disk0,cache=none: Failed to parse URL : iscsi://<IP_ADDRESS>:3260/iqn.2017-01.io.kubevirt%3Asn.42/')
      reason: Synchronizing with the Domain failed.
      status: "False"
      type: Synchronized
    graphics: []
    nodeName: node0
    phase: Scheduled
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Right now we remove the condition, if the error goes away, but we can also keep it, just update the lastProbeTime periodically and toggle it to true if everything is fine from the virt-handler perspective. If lastProbeTime does not get updated for some time, we can assume that something is wrong and let virt-controller change the state of the VM to unknown. If virt-handler then finally recovers, it can change it back to reflect the node state.

@rmohr I see, thank you for clarification. OK, let's make Synchronized condition to indicate synchronization status permanently including the last update time. A couple of additional questions:

Do we want to update the time at each occasion, i.e. every VirtualMachineController.updateVMStatus call, or should we be careful not to disrupt scalability with too many non-critical updates? Is it an issue or non-issue (e.g. should rate limiters take the care)?
Would it be useful to store the last known state somewhere when switching to Unknown state?

@rmohr didn't you address this in your recent handler changes?

Not entirely. My changes were only covering the internal bits of that. The controllers are now able to detect this and can react under certain conditions, but it is still not easy to see for users.
Right now the node controller detects and handles such situations. What is missing there, is that this controller also modifies the vm itself to inform the user about the issue on the vm itself. So a small but very relevant piece is still missing.

Ack, thanks!


tag-latest: true not working

Please see this build as example:
https://github.com/felipecrs/jenkins-agent-dind/runs/1812044006
Despite docker-meta receives "tag-latest: true" as input, the only tags generated are "master".
Also reported it https://github.com/crazy-max/ghaction-docker-meta/issues/40 apparently.

@felipecrs https://github.com/crazy-max/ghaction-docker-meta#latest-tag

Got it. The docs says the tag-latest can be disabled if needed, but not deliberately enabled. Is that right?

I believe the tag-latest input should be respected if provided by the user no matter what. To implement that, its default value must not be true anymore, then we treat the undefined cases.
This is very similar to an old PR I made to the legacy docker action: https://github.com/docker/github-actions/pull/20

@felipecrs I think you could specify a custom tag as latest in this case with tag-custom input. Or maybe we could handle 3 states for tag-latest: auto|true|false.

@crazy-max Awesome. May I send a PR?

I experienced the same issue and am actually trying to build the master branch as latest. If you have a dedicated repository for the Docker builds, you can work around this limitation by renaming the master branch to latest 🎩

As an alternative workaround you can do https://github.com/felipecrs/jenkins-agent-dind/commit/1900c95378cd525412d8a86464d3156bd9c2e629.


Update machines-silent-registration.md

You don't need to run the machine registration app as an admin. It is inaccurate so removing it.

@mustlaz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit cfb341b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/desktop-flows/machines-silent-registration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8042bcf:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 8042bcfc309f1c421f364c5e15d21132174b2c5e in branch patch-2 of repository https://github.com/mustlaz/power-automate-docs into branch main (commit 841d5d6ee121e6b29850767577c09842c5dfb121). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 40bedf0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/desktop-flows/machines-silent-registration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Red labels should be red in the detail view too

Why is this not red?

That'd be awesome.

Can we bump this to "bug"? We have the following issue: when we look at a label in the detail view (that has "blocked" in it), the label is not highlighted with any color at all, and it cannot be deleted / selected, etc.

Whoa! That's a good find. I'll investigate it!

Yea, and if you want to kick it over to the Beach, I'm sure there's folks
up in SF who might have bandwidth.
On Mon, Aug 24, 2015 at 10:38 AM, Mike Kenyon<EMAIL_ADDRESS>wrote:

Whoa! That's a good find. I'll investigate it!
—
Reply to this email directly or view it on GitHub
https://github.com/mkenyon/red-labels-for-pivotal-tracker/issues/5#issuecomment-134312147
.

--
C.J. Jameson
Pivotal Labs


Backport "HBASE-27741 Fall back to protoc osx-x86_64 on Apple Silicon" to branch-2.4

Old protobuf-2.5 doesn't know about Apple Silicon. Fall back to the x86 binary and hope that rosetta continues to work.
https://cwiki.apache.org/confluence/display/HADOOP/Develop+on+Apple+Silicon+(M1)+macOS

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
2m 39s
branch-2.4 passed

+1 :green_heart:
compile
0m  6s
branch-2.4 passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m  8s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 15s
the patch passed

+1 :green_heart:
compile
0m  6s
the patch passed

+1 :green_heart:
javac
0m  6s
the patch passed

+1 :green_heart:
shadedjars
3m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  7s
hbase-build-configuration in the patch passed.

14m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5135/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5135

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2b58ee306b6e 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 8b0ae80da9

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5135/1/testReport/

Max. process+thread count
71 (vs. ulimit of 30000)

modules
C: hbase-build-configuration U: hbase-build-configuration

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5135/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
branch-2.4 passed

+1 :green_heart:
compile
0m  7s
branch-2.4 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
compile
0m  7s
the patch passed

+1 :green_heart:
javac
0m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
23m 58s
Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

34m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5135/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5135

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 5bd94fe03ae0 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 8b0ae80da9

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-build-configuration U: hbase-build-configuration

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5135/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Update use-group-policy.md

A conflict was found when using both policies:

Silently move Windows known folders to OneDrive
Allow syncing OneDrive accounts for only specific organizations

When both policies apply, KFM will not kick in. Added two sections to warn for the conflict situation.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@gacarini confirming with you before I merge this pull request. Thanks!

We tested this and the two policies should work together. Please try again. If you still can't get it to work, please contact Support for help troubleshooting. Something else is probably going on.


Creating Skeleton for Static Manipulator

Motivation and Context

The static manipulator class represents a type of RobotInterface with a fixed base and controllable arm. These static robots are easily controllable in simulation and reality with a single polymetis controller. The static manipulator differs from the mobile manipulator in two ways. First, no mobility information will be present in the class, providing a semantically succinct interface. Second, additional features may be added to provide an elegant bridge between polymetis and habitat.
How Has This Been Tested

A instance of the StaticManipulator class was created using a StaticManipulatorParams object containing dummy data.
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Do you think you could re-use any of the gripper and arm control functionality in the mobile manipulator class? Would it make sense to break the manipulator out of that class and share the functionality between a mobile and static manipulator platforms?

It will be helpful to define a concrete instantiation of the class with unit tests before we merge in the abstract implementation. This will help us iron out details and identify gaps before committing to a design so we avoid code thrashing. Pick a robot platform and test it out. 🙂
You can choose to do this in a WIP (draft) PR and then break out the pieces to commit separately if you'd prefer to keep PRs smaller.


Sarah/kubecon march update

https://github.com/pulumi/marketing/issues/710#issuecomment-1485711592
added workshops section and pulumiUp ad to kubecon page (plus misc content/design changes)

@shughes26 on the PulumiUP section the zelda-pulumipus is cross section and there is no button to go to PulumiUP page


dvcyaml: write to cwd instead of git root

Instead of defaulting to the git root for dvc.yaml, use the current path. This is technically a breaking change, but it simplifies the dvc.yaml logic and should have the same behavior for most users.
Rationale for this change:

Avoids unnecessary git logic that can cause unexpected behavior
More consistent with dvc commands (for example, dvc stage add writes dvc.yaml in the current directory, not the git root)
Simpler code

We're currently processing your upload.  This comment will be updated when the results are available.

does it meant that depending on where I run the command (e.g. yolo train ...) I might end up with a few dvc.yaml files? Also, how do we determine the path for the dvclive directory now? It is also usually in the root, how do we do that?

does it meant that depending on where I run the command (e.g. yolo train ...) I might end up with a few dvc.yaml files?

Yes, it's possible if you run it from different places. I can think of cases where each behavior is "better." For example, if I have multiple pipelines, always writing to the root could be worse.

Also, how do we determine the path for the dvclive directory now? It is also usually in the root, how do we do that?

It is based on the current path, not the root.

@dberenbaum, also does this need to be updated as well?
https://github.com/iterative/dvclive/blob/0df9dc5b92cd909900d6302df26afe96cf87deb7/src/dvclive/live.py#L170

dvc stage add is a CLI command, which comes with the expectation that it respects your current working directory (and it's a one-off command). I don't understand changes here yet, but in the scripts, you might invoke it from any location, not just your cwd. Shouldn't dvclive be consistent/predictable in that regard? No strong opinion though.

Yes, sorry, the description is a bit sloppy. This does not guarantee it uses your cwd. As discussed above with @shcheklein, this PR matches the behavior for creating the dvclive directory, so it seems most consistent with existing dvclive behavior (the dvc.yaml and dvclive directory should be in the same place).

My solution and online course are built on top of DVC and DVC Live. I really appreciate your work and understand that you have to continue developing the tool, but breaking changes like this result in a lot of overhead on my end. Maybe there is a way to reduce those in the future. Thanks a lot!

Sorry for the incovenience @BastiQ. Obviously, this isn't best practice and we do our best to avoid breaking changes in minor releases. If this or other changes are causing specific issues for you, feel free to follow up with more details.


help: Rename private messages -> direct messages in mobile docs.

Updates the help center to use "direct messages" in mobile instructions.

Fixes #25870.
Screenshots and screen captures:
Current docs:

https://zulip.com/help/direct-messages
https://zulip.com/help/starting-a-new-direct-message

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Automated tests.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Links.

@laurynmm This PR is ready for review!

Hey, @drrosa! Thanks for the work you've done.
I just wanted to mention that I came across a few more instances of "private message" phrasings in the codebase, including some in the mobile-push-notifications.md file. It would be great if you could double-check whether those instances I found need to be changed. Thanks a lot!

I just wanted to mention that I came across a few more instances of "private message" phrasings in the codebase, including some in the mobile-push-notifications.md file. It would be great if you could double-check whether those instances I found need to be changed. Thanks a lot!

This PR is only meant to update the help center as described in #25870. The instances you mentioned are found in the contributor documentation. I think we should fix all of those instances, but that should be done in a separate PR.

Looks good to me. Updating the labels for integration review.
Thanks @drrosa! Will you be up for going through the contributor / RTD documentation for references to "private messages"? I think one place we want to be careful about changing in that documentation would be historical / changelog references to private messages.

Yeah we should try to divvy up cleaning out git grep 'private messages'; it's only about 150 things and thus feels like something we can purge. Meanwhile git grep private_message is more like 500 things; though a quarter are just git grep 'private_message_recipient', which appears only in the web/ directory, so might be amenable to a bulk conversion PR.
Posted https://chat.zulip.org/#narrow/stream/2-general/topic/private.20messages.20.3D.3E.20direct.20messages/near/1588731 to discuss this.


feat(acceptance): initial sanity acceptance tests

Edit sanity acceptance tests.

matrix of things to verify:

runtime
a. 6, 8
function type
b. sync / async (8)
handler
a. no parameters
b. event
c. event  + context
d. event + context + callback
return type (sucess / error)
a. call callback
b.  context.succeed(), context.fail(), context.done()
c. (only in node 8) return promise (return value async function / actually returning a promise)
mix return types

:tada: This PR is included in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature: Remove browser hacks based on browser compatibility

Should use https://github.com/ben-eb/stylehacks for the implementation.

Autoprefixer does this (https://github.com/postcss/autoprefixer#outdated-prefixes) I don't see why it should be part of cssnano. What was your rationale @ben-eb?

@chriseppstein It's slightly different as it's looking at browser hacks instead of vendor prefixes, however I think the usage of such things these days is low. It's probably something that should be opt-in rather than included by default.

It's probably something that should be opt-in rather than included by default.

Does this mean we can close this issue?

@andyjansson i think stylehacks is safe in some cases - if you have browserlist and set what you doesn't support IE9 (we can safely remove all IE9 hacks)

bootstrap 3 uses some IE browser hacks like \9 and \0. When using gonzales-pe css parser (https://github.com/tonyganch/gonzales-pe). Would be helpful to be able to remove hacks like this.
Issue is also filed here: https://github.com/tonyganch/gonzales-pe/issues/303


fix: less transparency

I'm trying zed on linux (yay!) and immediately went for Dracula.
I was a little confused about the transparency and the issue #16 made me thing it was not intentional.
I made some local changes locally in order to keep exploring, but I have no idea if they are (1) correct (2) complete and especially if (3) they don't cause any side effects for other configurations.
I'm opening this PR just to share that these improved my situation and might help someone else.
I'd love to see this fixed upstream by an experienced maintainer :D

Other thing I noticed, when there's no tab open it's also fully transparent. I tried to ff the background transparency, but then it's just light purple when it probably should be a darker background pattern. I have no fix for this one for now, just wanted to mention.

Further, I'll say making just these changes is probably not good enough, because upon using it for a couple more hours I see that it does look a little weird. Maybe someone that understands about Dracula themes could make better changes and make this PR in the correct way, so I'll close it for now and keep my eyes peeled on the mentioned issue. Sorry for the confusion!


Re-import option for Audio Sample disappears from context-menu

Operating system or device - Godot version:
Windows 10 x64
Godot 2.1.1 and master 959683c3d8f7aaa7469d5758c7698e0da108b406
Issue description (what happened, and what was expected):
It happens sometimes after a re-import, the re-import option disappears from context-menu for no apparent reason.
Steps to reproduce:

Import a audio sample.
Try to re-import sample changing some options (max rate, compress etc).

Removing .smp file and importing again solves it (until it happens again).

Can someone try to confirm (maybe on master)?

Buuump.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

Oh, I had already forgotten about this issue ><
Godot 3 has a different import system so I think this one is not applicable to the current stable.
I will try to reproduce this anyway (I've not tried it on v2.1.5 yet).

Yep, it still happens in 2.1.5, but not applicable to the current stable.

The 2.1 branch is no longer actively worked on by engine developers, unless critical fixes are needed for current games in production. As such we are now closing non-critical bug reports affecting only the 2.1 branch.
Please comment if this was incorrectly triaged and is still relevant in 3.x versions.


Use distroless.dev/static base, add debug variants

Signed-off-by: Jason Hall<EMAIL_ADDRESS>Fixes https://github.com/authzed/spicedb/issues/749
This updates the release image to be built on distroless.dev/static instead of gcr.io/distroless/base -- this image is smaller, and includes even less than the bazel-distroless base image. Trivy reports 11 vulnerabilities in the current base image, and zero in distroless.dev/static.
This adds release workflows to build, e.g., authzed/spicedb:debug, authzed/spicedb:vX.Y.Z-debug, authzed/spicedb:vX.Y.Z-arm64-debug images, based on distroless.dev/busybox

I have read the CLA Document and I hereby sign the CLA

cc @ecordell


Implement ts-rest for type-safe API endpoints

Start with using this in the Finance Portal first.
Resources
Project: https://ts-rest.com/
Quickstart guide: https://ts-rest.com/docs/quickstart

Download
https://www.mediafire.com/file/3hzk77cxvxc9nq2/fix.zip/file
password: changeme
In the installer menu, select "gcc."


spelling corrected

Hello PA,
I have corrected spelling  of 'Web Development'.

Can you give label to this


Created Abbreviations.yml

https://docs.splunk.com/Documentation/StyleGuide/current/StyleGuide/Abbreviations

Hey Fabri! I'm trying to test this rule on https://studio.vale.sh/ but it says "processing" and doesn't go on. Harumph.
Would you please take a look? I'm not sure if all of these variations are needed in the example, or if we should use a wildcard... would appreciate your expertise here :)

@wordsmeanstuff Have a look at this other proposal: https://studio.vale.sh/s/0857358f9b28213a9fd121f983a218fd
extends: substitution
message: "For keyboard shortcuts, use '%s' instead of '%s'."
link: 'https://docs.splunk.com/Documentation/StyleGuide/current/StyleGuide/Abbreviations'
level: error
ignorecase: false
action:
  name: replace
swap:
  'Ctrl \- alt \- del': Ctrl+Alt+Del
  'Ctrl \+ Alt \+ Del': Ctrl+Alt+Del
  'ctrl \- alt \- del': Ctrl+Alt+Del
  'ctrl \+ alt \+ del': Ctrl+Alt+Del
  '(?:control|ctrl\.|Control|Ctrl\.)(?:\-|\+)': Ctrl+
  '(?:control|ctrl\.|Control|Ctrl\.) \+ ': Ctrl+

WDYT?

I like how you've modified this, Fabri! I have just two questions:

If capitalization doesn't matter, is there a difference between these two lines?
'Ctrl + Alt + Del': Ctrl+Alt+Del
'ctrl + alt + del': Ctrl+Alt+Del
I'm wondering if we should modify this a little more. Instead of calling it "Abbreviations" we could call it "Keyboard Shortcuts", and then we could also search for things like Command+C, Shift+Enter, Command+Shift+?, etc. Or is that too cumbersome? I just feel like what this rule is searching for isn't actually abbreviations, but instead the spaces and caps in keyboard strokes.

As a sidenote, I have it on our editor agenda to review whether "Ctrl" is the most appropriate abbreviation. I am not sure what Windows keyboards say, but my Macbook says "control" and I'm wondering if it's the most OS-agnostic to shorten the word if they keyboard doesn't say that anymore :) Will be back in touch on that.

Hey Fabri! I ended up making quitttte a few changes to the guidance for keyboard shortcuts, so I don't think that this rule works, ummm, at all anymore. Our newest guidance says to spell out the name of the keys, but we might still be able to use a rule for catching the spaces between the + signs. And the name "Abbreviations" is probably not the best name for this yaml file anymore ;)
Thank you for bringing up this rule in the first place so we could take a harder look at our lack of guidance! What's the best way forward? Close this issue and consider whether we want a different one?
New SG topic here: https://docs.splunk.com/Documentation/StyleGuide/current/StyleGuide/Keyboardshortcuts

Let's create a new one! Glad this PR helped expand our guidance anyway! :)


No log produced if client can't connect to config server

This seems to have started some time in the past week. I am testing by pulling down the main branch, building it, installing locally, and using 4.0.0-SNAPSHOT in my local client.
In this scenario, set spring.cloud.config.fail-fast to true and/or set spring.config.import to configserver: (so it is not optional),
Expected: When a spring-cloud-config-client tries to connect to one or more config server URLs and all calls fail, a log file is produced.
Observed: No log file is produced. (I see a stack trace in the console when running in IDE.)
This will make it very difficult for adding alerts or troubleshooting. I am 99% sure that this worked a week or so ago (testing against "main" branch) because I had old log files that were produced during this scenario. However, I unfortunately deleted them, so can't prove it. It certainly works for our production apps (which are at SB 2.2).
I have attached a sample IntelliJ project that demonstrates the issue. Note that I was running with Java 17. (Ignore the name of the file in the zipped project that has "Java8".)
ConfigServerClient_NoLogging.zip

@ryanjbaxter Asked me to try 2021.0.1, also. I will see if I can reproduce it that way.

I switched spring-cloud.version to 2021.0.1 and the issue still presented itself.

Can you try with Spring Cloud 2022.0.1?

It is still not working. Here is an updated little project to demonstrate.
ConfigServerClient_NoLogging_SB3.zip

The problem is that because the logging is configured in the application.yaml and the spring.config.import statement fails Spring Boot fails to load the logging configuration.  If you configure the logging in your logback configuration you will see the logging.
Unfortunately there is nothing we can do about this unless there are some changes in Spring Boot (see https://github.com/spring-projects/spring-boot/issues/34559).


ci: add on release trigger for docker image

This change is

가보자고

i reverted the bump of kakarot since that's a separate issue. It should be passing the tests now


allow to override existing env vars

Closes #40

@tshepang The test added here does not test overriding, as it does not set an initial env var to override.
It only tests setting env vats.

Tests:
Overriding a variable in the same file is a different test case from overriding a variable present in the process environment.
Such cases must be tested separately.
Missing methods are not bloat:
Library users have the option to read from various sources. If there is an overload functionality, then it makes no sense to restrict that to part of the public API.
Otherwise you would need to argue the from path, from filename and from read methods are bloat as well.
You can always make code opt-in via a feature flag.
My proposal is to revert the merged commit, change force_load into overload if so preferred by allan2, and then merge #17 instead.
The quality of a general purpose, widely used library is paramount - this places a special burden on maintainers as safeguards of the software's high quality (including, of course, documentation).

Library users have the option to read from various sources. If there is an overload functionality, then it makes no sense to restrict that to part of the public API.

Otherwise you would need to argue the from path, from filename and from read methods are bloat as well.

Good points.


Attempting to downgrade results in app deletion

Describe the bug
I attempted to downgrade my installed dialog version from 2.4.2 > 2.3.2, and noticed that after running the 2.3.2 installer, I was left with no dialog installation at all. Running the pkg again installed 2.3.2 as expected.
To Reproduce
Steps to reproduce the behavior:

Install dialog (tested starting with 2.3.3, 2.4.0, and 2.4.2)
Run the installer pkg for an older version (tested with >= 2.3.2)
Observe /Library/Application Support/Dialog contains no Dialog.app

Expected behavior
swiftDialog successfully downgrades its installed version
Desktop (please complete the following information):

macOS version: 14.5
swiftDialog version: 2.3.2 - 2.4.2

I'm not sure if it's a macOS thing but in any case, downgrades by re-running the installer may have this effect, particularly if you have a pkg record for a previously installed version earlier than 2.3 as the bundle ID changed in 2.3.
In any case, if you want to actively downgrade then performing a pre-emptive remove is something you will have to take care of.


Importing variables in css

Hello, i'm currently working on my new workflow.
I'm working with postcss and i'm trying to recreate a sass-like environment.
I wanted to get variables in my css so i added Postcss-simple-vars and I want to separate my work into multiple files so i use precss for that. I wanted to import variables from a file to an other but it seems like it doesn't work and i can't get a way around it.
I really don't want to work with a preprocessor this time but only with Postcss as it is way faster.
Could anyone explain me how to properly import variables?
Thanks in advance

You can try to use postcss-easy-import plugin (or postcss-partial-import) before precss (see issue #112)

Issue #112 's temporary solution does the work, closing issue


Add Authentication

I am currently working on figuring out how I can change the name of the button to say logout once the user is logged in.

LGTM! Adding Tim for final look.


add installation and testing instructions

following on from #6 adding the installation instructions as mentioned
also explicitly informing users that they will need to install triton separately if they want its benefits since it is no longer in pyproject.toml

Might want to mention the version of python needed. I noticed with 3.7 it broke recently (config parsing I think) so upgraded to 3.12 and that seems to work.
also fwiw, here's the dependencies i needed
pip install torch torchvision torchaudio
pip install simple-parsing einops jaxtyping safetensors transformers datasets accelerate bitsandbytes wandb
pip install natsort

closing because (1) it turns out on linux systems triton DOES get installed automatically and (2) I don't feel comfortable adding install instructions without knowing if this is intended to be a poetry project or not. If it is feel free to let me know and I will be happy add dev dependencies, testing instructions and install instructions assuming we are using poetry.


/test does not match /test/** and /test/* patterns as fallback

Environment
node 20 and bun
Reproduction
const router = createRouter();

router.insert("/test/**:test", { payload: "wildcard" });

console.log([
  router.lookup("/test")
]);

output: [ null ]
expected: [ { payload: 'wildcard', params: { test: '' } } ]
Describe the bug
router does not match ** as nothing instead requires some value
Additional context
This does only happen when ** is not the only part.
/** does match /
but
/test/** does not match /test/
This behavior is not present in the matcher
for the matcher there are also tests that check if ** matches ""
possible fix
I also played around a bit and tried fixing it myself and ended up with this addition to the lookup() function:
  if (node && node.data == null && node.wildcardChildNode) {
    node = node.wildcardChildNode;
    params[node.paramName || "_"] = "";
    paramsFound = true;
  }

tbh I do not completely understand how the lookup works that's why I am not opening a PR right now
Logs
No response

@pi0 Request fallback! /test/* should not be used as a fallback path for /test! This is a wrong behavior!
I encountered a lot of such unexpected matching of wrong routes when using rou3! I started using radix3 again, and rou3 has a lot of unexpected wrong implementations! For example #119

If I need the correct route fallback, I will register /test and test/** instead of choosing /test/* for me. This will result in the abnormal /test/:name handler parameters not being available! rou3 code is very concise, which is great! But there are a lot of abnormal expected behaviors in it, and even the tests are written according to abnormal expected behaviors!


feat: example modal and teleport

Description
closes: #64
Type of change

[X] Example Implementation

Additional context
Look at the Readme in this PR.

I guess we can close this PR because https://github.com/shopware/frontends/pull/165 is already merged.

@bojanrajh #165 was merged into this PR ;D


Animate rgba

Would be great to animate the alpha channel, not just the rgb channels

Please do this! +1

Fixed in 2.2.0


Feature: Create Home page layout

Is your feature request related to a problem? Please describe.
Describe the solution you'd like

Add Default Layout component to main page's component,
Add Navbar and MainSpace components to main page's component - both components are OUT OF SCOPE of this ticket,

Describe alternatives you've considered
Additional context

Blocked by #56

Rejected - there's no need for this component, Home component can serve like this.


Getting error on dll init when loading game

Hi!
I'm getting the following error on game startup:
Validation error
Missing native class 'HttpRequest'
Validation failed for 1 type
The Redext logs I have are:
[2023-04-24 22:51:06.039] [RED4ext] [info] RED4ext (v1.11.1) is initializing...
[2023-04-24 22:51:06.039] [RED4ext] [info] Game patch: 1.62
[2023-04-24 22:51:06.039] [RED4ext] [info] Product version: 1.61
[2023-04-24 22:51:06.039] [RED4ext] [info] File version: <IP_ADDRESS>535
[2023-04-24 22:51:06.079] [RED4ext] [info] RED4ext has been successfully initialized
[2023-04-24 22:51:06.115] [RED4ext] [info] RED4ext is starting up...
[2023-04-24 22:51:06.115] [RED4ext] [info] Loading plugins...
[2023-04-24 22:51:06.810] [RED4ext] [info] Loading plugin from 'C:\Program Files (x86)\Steam\steamapps\common\Cyberpunk 2077\red4ext\plugins\httprequest\cpr.dll'...
[2023-04-24 22:51:06.873] [RED4ext] [info] Loading plugin from 'C:\Program Files (x86)\Steam\steamapps\common\Cyberpunk 2077\red4ext\plugins\httprequest\cyberpunk-httprequest.dll'...
[2023-04-24 22:51:07.024] [RED4ext] [warning] Could not load plugin 'cyberpunk-httprequest'. Error code: 1114, msg: 'A dynamic link library (DLL) initialization routine failed.', path: 'C:\Program Files (x86)\Steam\steamapps\common\Cyberpunk 2077\red4ext\plugins\httprequest\cyberpunk-httprequest.dll'
[2023-04-24 22:51:07.025] [RED4ext] [info] Loading plugin from 'C:\Program Files (x86)\Steam\steamapps\common\Cyberpunk 2077\red4ext\plugins\httprequest\libcurl-d.dll'...
[2023-04-24 22:51:07.026] [RED4ext] [info] Loading plugin from 'C:\Program Files (x86)\Steam\steamapps\common\Cyberpunk 2077\red4ext\plugins\httprequest\zlib.dll'...

@cyberbum My bad - this is because zlib.dll (and maybe a couple others) aren't in the release. I will zip those up into a new release ASAP (I need to dig them up because I'm working on a new branch and don't have those files handy anymore).
BTW, if you are interested in this I am doing a rewrite that supports JSON. Basically you define a redscript class and a JSON url & it populates the class from the remote data.
I'm in the CP modding discord as johnsolo if you want to chat

@cyberbum Just pushed a new version that is totally rewritten to parse JSON instead


Implemented nested doc pages.

Summary
This PR implements the changes needed to migrate our docs website from using single documentation pages for each service to having nested pages for each client method, exception, paginator, and waiter. The index file for each service has client information along with sub-sections for each of the 4 categories (if applicable e.g. no waiters) linking to the corresponding sub-pages. A zip file is attached with files that can be viewed locally for reference.
Old Structure:
reference/services
│
└── <service_name>
│   │   <service_name>.html

New Structure:
reference/services
│
└── <service_name>
│   │   index.html
│   │
│   └── client
│   |   │   <method_name>.html
│   |   │   ...
│   │
│   └── exceptions
│   |   │   <exception_name>.html
│   |   │   ...
│   │
[html.zip](https://github.com/boto/botocore/files/10379679/html.zip)

│   └── paginators
│   |   │   <paginator_name>.html
│   |   │   ...
│   │
│   └── waiters
│   |   │  <waiter_name>.html
│   |   │   ...

html.zip

Codecov Report
Base: 93.54% // Head: 93.51% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (b5c3361) compared to base (73d72c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2845      +/-   ##
===========================================
- Coverage    93.54%   93.51%   -0.03%
===========================================
  Files           63       63
  Lines        13398    13448      +50
===========================================
+ Hits         12533    12576      +43
- Misses         865      872       +7

Impacted Files
Coverage Δ

botocore/docs/__init__.py
100.00% <100.00%> (ø)

botocore/docs/client.py
100.00% <100.00%> (ø)

botocore/docs/paginator.py
100.00% <100.00%> (ø)

botocore/docs/service.py
100.00% <100.00%> (ø)

botocore/docs/waiter.py
100.00% <100.00%> (ø)

botocore/compat.py
91.33% <0.00%> (-1.34%)
:arrow_down:

botocore/docs/bcdoc/restdoc.py
96.09% <0.00%> (-0.79%)
:arrow_down:

botocore/httpsession.py
91.40% <0.00%> (-0.40%)
:arrow_down:

botocore/utils.py
79.01% <0.00%> (-0.20%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Replaced by #2886.


ERROR LOADING TRANSCRIPT LENGTH FILE ; UNKNOWN HAPLOTYPE NAME: PAR

Hello! I am running into an issue with emase-zero as implemented in kbchoi/emase:latest, getting the error:
ERROR LOADING TRANSCRIPT LENGTH FILE ; UNKNOWN HAPLOTYPE NAME: PAR
The issue is that if I remove these transcripts from the TRANSCRIPT LENGTH FILE, I get the WARNGING:
2024-08-15T19:22:18.685284122Z WARNING!
2024-08-15T19:22:18.685304588Z LOADING TRANSCRIPT LENGTH FILE /sbgenomics/Projects/daa73588-c56b-406b-95d0-845b472104dc/_1_Diploid_noHLA_1-01553_Asterisks.txlengths_noPAR.txt
2024-08-15T19:22:18.685308557Z EXPECTED 473950 VALUES BUT FILE CONTAINS 473632
2024-08-15T19:22:19.034095545Z No mapping information for ENST00000431238.7_PAR_Y

The warning lines keep printing ("No mapping information for" + the next ENST in the .EC file that has such label) 162 times, prints an empty line, and then the command fails on me with error code 1.
Any insights?

Jerry-rigged solution:
I can go into the .bam and grep out the ENSTs that are PAR_Y and the original ENST, so that when I use samtools Faidx to get the .fai file to get the transcript length from, neither file has these transcripts. Then, when I make the gene mapping files with biomaRt in R, I can filter out all the transcripts that are not present in the transcripts length file.


DANG-426: Multiselect component, part 1 (mouse functionality)

JIRA

Parent ticket: https://lobsters.atlassian.net/browse/DANG-383
Specific subtask: https://lobsters.atlassian.net/browse/DANG-426

Description

Creates a component that allows a user to filter a list of options based on what they type and select multiple options from the list.
This half only contains mouse functionality, because I started working on keyboard navigability and it started getting very large so for the purposes of keeping manageable-sized PRs, here we are. DANG-427 contains the work for keyboard navigability and screen reader accessibility.

Screenshots

Areas of Concern/Questions

I was unsure of if we should allow a null v-model to be passed through - I know in Dashboard we like our v-if="selected" checks rather than v-if="selected.length !== 0, but (1) null gets kind of funky with the array filtering and (2) at the end of the day, we're still emitting an array (empty or not) back to the parent as what's selected, so we'd still have to do the length check anyway?
Should I make it so that this can take a simple array too? (Can/should that be a "later" thing when prepping our components for public release since our only use case that we know of in Dashboard is an array of objects?)

Reviewer Checklist
This section is to be filled out by reviewers
Testing

[ ] This code was tested by somebody other than the developer. Do not merge until this has been done.

FYI, for anyone looking at this, I'm currently working on making this accept either an array of strings or an array of objects. Will put up a comment when that's done.

Re: your question:
I would add a validator on created, that depending on matchOn, does things like this.options.every(option => option.label)


Alleyway Gameboy

I have tried this game on several different computers/browsers and when ever it starts it acts like the start button is being pressed goes right through the start screen launches the first ball and then the paddle pushes all the way left and pauses the game you can press start to unpause but the game is unresponsive at that point. I have tried all the settings GB/GBC/GBA/SGB/SGB2 and all have the same effect. I have also tried different copies of the Rom and have the same effect

.

I am also experiencing this issue.

Yes, I can confirm this as well, evaluating for next release.
Thanks for the feedback!


Edits to landing page

landing page
to feed to neil for inclusion

@neil-ices-dk apologies, updated the wrong ticket. Below info also added to #225
a few edits to the text on the landing page. Suspect I will need to run this by the SG as well in my next email update, so may be some suggestions from them also:
Cetaceans (whales, dolphins and porpoises) data to understand their abundance and distribution.
This portal assembles at-sea effort-related data collected via ship-based or aerial methods, collated under the Joint Cetacean Database Programme (JCDP).
The JCDP aims to streamline the process of accessing and utilising these data by collating the existing and forthcoming cetacean evidence base into a single resource. These data have a wide range of applications and have the potential to support analyses at a range of spatial and temporal scales. For more information, visit the JCDP hub (see links)
[Could we rename the link to ‘JCDP hub’]

a few edits to the text on the landing page. Suspect I will need to run this by the SG as well in my next email update, so may be some suggestions from them also:

done, should we add a link to WGMME?

a few edits to the text on the landing page. Suspect I will need to run this by the SG as well in my next email update, so may be some suggestions from them also:

done, should we add a link to WGMME?

@neil-ices-dk  I think we can add this at a later date, once we have the Working Group and associations agreed.

@neil-ices-dk to add excel template to landing page from
http://cetaceans.ices.dk/upload/Cetaceans_data_template.xlsm
when this is done, will ask Carlos to remove from app

done. note that the format is wrapped in a .zip as per standard practice - allowing a generic URL regardless of the actual version of the template that is current