Refactoring to enable better A/B type scenarios

Today Route, Cluster and Destination are sealed. They have a metadata collection which can be used to add dictionary data, but its not very good for more structured data #121.
Cluster Scenarios to consider:

Multiple clusters of destinations, where only a percentage of the traffic should be directed to the B cluster (or multiple clusters to handle different experiments)
Multiple clusters that traffic is routed to based on a factor in the request - often based on an indirect lookup such as customer in a database (with a local cache)

Destination scenarios to consider

Not all destinations are equal - some should get more load than others. Prioritization should be made based on geographic distance, pre-determined factors etc.
Backup destinations that should only be loaded if all other destinations have problems.

This means we need to be able to have multiple clusters for a route, and then have secondary data associated with that cluster to help choose - does this belong to the cluster and would apply across all routes, or as part of the route:cluster relationship
Destinations need to be able to have the metadata attached to the,
The current record types for the above are sealed and its not easy to replace the config file->memory serialization to be able to handle derivatives. Ideally you'd extend the config types, and the factory methods used to create them from config.

Related: A/B https://github.com/microsoft/reverse-proxy/issues/126, and https://github.com/microsoft/reverse-proxy/issues/121 friendlier metadata.
How does this scale? E.g. How can A/B provide derived types for their scenarios, and another component like session affinity or load balancing provide their own types?

How does this scale? E.g. How can A/B provide derived types for their scenarios, and another component like session affinity or load balancing provide their own types?

I would assume that all customization is done in the context of the proxy app, and so it's code can coordinate the changes across all the types - we shouldn't need a mixin capability for multiple independent additions.

Design notes:

Clusters already create a logical grouping of destinations, so it would be convenient to use them as the unit of A/B testing. You may also want to change settings like load balancing and protocol versions between groups.
In config you'd keep the current cluster id field for simplicity, but add the ability to list alternate clusters by id.
These additional clusters would want some metadata associated with them as input into the selection algorithm.

                    proxyPipeline.Use((context, next) =>
                    {
                        var proxyFeature = context.Features.Get<IReverseProxyFeature>();
                        var route = proxyFeature.RouteSnapshot;
                        // IReadOnlyDictionary<ClusterInfo, IDictionary<string, string>> alternates = route.AlternateClusters;

                        ClusterInfo cluster = PickCluster(context, route);

                        // Update ProxyFeature
                        proxyFeature.ClusterSnapshot = cluster.Config;
                        var state = cluster.DynamicState;
                        proxyFeature.AllDestinations = state.AllDestinations;
                        proxyFeature.AvailableDestinations = state.HealthyDestinations;

                        return next();
                    });

This could be built as a middleware where PickCluster was abstracted out as an interface like we do for load balancing.

@Tratcher - Can this be closed by #814?

See https://github.com/microsoft/reverse-proxy/issues/809#issuecomment-793233000 for design notes from our last discussion. I think we should keep this open until we have real support for at least that model since it proposes config changes.

Duplicate of #126


Microsoft Speech Corpus (Indian languages)

I am not able to download the dataset from this location:
https://msropendataset01.blob.core.windows.net/microsoftspeechcorpusindianlanguages
I receive the below error:

BlobNotFound
The specified blob does not exist. RequestId:b00318a7-601e-00db-0689-873e30000000 Time:2022-06-24T05:18:02.4337185Z

Closing due to lack of response. If you are still facing this issue we recommend opening an Azure support ticket from the portal. Alternatively you can open a new issue here.


Can no longer write deep predicates in conditional types

Bug Report
🔎 Search Terms
conditional types, generics, deep, predicate
🕗 Version & Regression Information
This changed between versions 4.8.4 and 4.9.4
⏯ Playground Link
Playground link with the code bellow
💻 Code
type Foo<A,B> = [A, B] extends unknown[][] ? Bar<[A, B]> : 'else'
//                                               ~~~~~~
// Type '[A, B]' does not satisfy the constraint 'unknown[][]'.

type Bar<T extends unknown[][]> = T

This is not limited to tuples
type Foo<A> = Set<A> extends Set<unknown[]> ? Bar<Set<A>> : 'else'
//                                                ~~~~~
// Type 'Set<A>' does not satisfy the constraint 'Set<unknown[]>'.

type Bar<T extends Set<unknown[]>> = T

🙁 Actual behavior
There is a type error that literally contradicts the predicate of the conditional
🙂 Expected behavior
It should compile with no error

Both of these compile in nightly (soon to be beta) as of #51621, so this looks to be a duplicate of #51614.

It's great that it is fixed but it must have been in a different PR, or maybe it was an unintentional side-effect, because these 2 issues are not related to me: the outcome of the conditional cannot be known here.
I feel that a test case should be added for this scenario if it hasn't been already.

That PR definitely fixed it; I bisected to confirm before replying.

I've also checked and it was #50397 which regressed this.

Sent #52333 with a test.


[BUG] LUA error on startup GSE/API/Storage.lua:593: bad argument #1 to 'sub' (string expected, got boolean) [string "=[C]"]: in

🔵 Describe the bug:
Every time I log the game I receive a bug sack alert
🔵 To reproduce: (Steps to reproduce the behavior)
Log the beta
🔵 The error:
14x GSE/API/Storage.lua:593: bad argument #1 to 'sub' (string expected, got boolean)
[string "=[C]"]: in function `sub'
[string "@GSE/API/Storage.lua"]:593: in function <GSE/API/Storage.lua:582>
[string "@GSE/API/Storage.lua"]:738: in function `processAction'
[string "@GSE/API/Storage.lua"]:616: in function `processAction'
[string "@GSE/API/Storage.lua"]:791: in function `CompileTemplate'
[string "@GSE/API/Storage.lua"]:260: in function `OOCUpdateSequence'
[string "@GSE/API/Events.lua"]:396: in function `?'
[string "@Details/Libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <...ceDetails/Libs/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
(*temporary) = false
(*temporary) = 1
(*temporary) = 1
(*temporary) = "string expected, got boolean"

🔵 GSE.lua file:
Please provide your GSE.lua file or the export string for the specific macro that is causing an issue.

To find the GSE.lua file:

First, make sure you have enabled the "File Name Extensions" checkbox in Explorer (View tab)
Browse to C:\path\to\wow\_retail_\WTF\Account\YourAccountName\SavedVariables\ or /path/to/WoW/_retail_/WTF/Account/YourAccountName/SavedVariables
Copy the GSE.lua file to your Desktop
Rename this copy to GSA.lua.txt
Then just drag it here in your message

Note: If you do not include your GSE.lua file you are wasting your time and mine. 90% of the time, the first thing I will ask for is "Can you please upload your GSE.lua file?".  This file is needed with the error to work out Why that error occured for you.
GSE.lua.txt

🔵 Desktop (please complete the following information):

OS: Mac OS
Game Version Last Beta available

🔵 GSE Version:

Version: 3.2.00 alpha 12c

🔵 Additional context:

This is a duplicate of the error in #1463. Will fix it in that.

This was released as part of alpha12-b


Fix: Implement sanity check

Description of PR
Implement sanity check to case_time_series data to check if all the fields & date are present and all the dates <= yesterday
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
Fixes #544
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

@jeremyphilemon this is not a WIP. Its done from my side unless any specific changes you want me  to make ?

This is awesome haha! Thank you for this :)


Change to Oracle JDK, see #79

Looks like the Oracle JDK8 is only available on Ubuntu Trusty, and the version available is rather old, 1.8.0_151, which causes issues with the unit test that counts all the timezones in the world. I'll merge this now to see if it helps with the zero JAR timestamps. Maybe it's time to actually drop that test, especially if this PR helps with timestamps.

Looks like the Oracle JDK8 is only available on Ubuntu Trusty, and the version available is rather old, 1.8.0_151, which causes issues with the unit test that counts all the timezones in the world. I'll merge this now to see if it helps with the zero JAR timestamps. Maybe it's time to actually drop that test, especially if this PR helps with timestamps.


Added a ton more stuff to Rust language file

Mostly multi-word stuff. I think it's neat

I appreciate the contribution, but I think it would be best not to add in arbitrary identifiers (like foo) or many-token strings like pub fn new(foo: &str, bar: i16) -> Self. I realize that there are a few words in the dictionary like this already (from when I copied it from monkeytype), so I'm going to be reworking that and also including your #[derive()] suggestion.


Call node with option to prefer IPv4 DNS results in local development

This unfortunately does not work for me:

 *  Executing task: npm run serve:gis:local

><EMAIL_ADDRESS>serve:gis:local
> node --dns-result-order ipv4first ./node_modules/@angular/cli/bin/ng serve --configuration development gis --proxy-config proxy-local.conf.json

node: bad option: --dns-result-order

 *  The terminal process "/usr/bin/bash '-c', 'npm run serve:gis:local'" failed to launch (exit code: 9).
 *  Terminal will be reused by tasks, press any key to close it.

This is the version from my Ubuntu 22 LTS:
$ node --version
v14.17.3

The calling of node with the path to ng is kind of ugly in one line. Could you add an alias for that? Like a command that wraps it and you call the command?

This unfortunately does not work for me

Sorry about that. I checked the CLI docs for the Node 14 LTS and it listed the option, but I missed the detail that it was only added in v14.18.0. Since in the readme we only require >= 14.x.x this does not seem to be a good solution then for now, unless we change the requirement. Ubuntu 22.04 LTS actually includes an even lower version v12.22.9, but that should be fine because the readme says to use Node 14+.
Alternatively we could just add a sentence to the readme mentioning the option to set the environment variable if someone is using Node >= 17 and having problems.

Please change the readme so that it says to use Node 16 with its version being >= 16.18.X
Please remove 14 from the CI and maybe add a TODO to include 18 there once we upgrade to Angular 15.
Please find out if we can have like one script in the package.json that does this parametrization stuff and the other scripts just call this.
Alternatively, maybe try pre-scripts, like "preserve:gis:local": "NODE_OPTIONS=\"--dns-result-order ipv6first\"",.

You have to remove the 14.X stuff from https://github.com/geo-engine/geoengine-ui/blob/main/bors.toml in order for me to merge it.

bors merge

bors merge


adding global hotkey to show devtools to help debug. updating some packages

@keybase/react-hackers

:+1: % optional :sheep:


fix(nexus): persist NexusInfo to etcd using nexus UUID

Switch the key for persisting NexusInfo to the nexus bdev UUID, which
is specified when creating the nexus using CreateNexusV2 and is unique
cluster-wide.
Fixes CAS-1023

bors try

bors merge


fix a question: AttributeError: module 'tkinter' has no attribute 'messagebox'

fix a question: AttributeError: module 'tkinter' has no attribute 'messagebox'

Hey @KuriYama-mirai524 , Thanks for the changes. And Sorry for the delay. Will merge it


[release-1.7] Don't claim 'istioctl validate' is deprecated

This is an automated cherry-pick of #26082

@esnible Would you please consent for the CLA.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
1db2c785149b7de60ecff44a47a761f135696490
link
/test unit-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


cmd/go: windows build doesn't report write error

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.7 windows/amd64
What operating system and processor architecture are you using (go env)?
GOARCH=amd64
GOHOSTOS=windows
GOOS=windows
GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
What did you do?
Compiled 'test.exe', run it, tried to compile to same file again while running.
What did you expect to see?
Write error.
What did you see instead?
Nothing. Go build exited without error, but 'test.exe' was obviously not updated.

Please use -x to confirm that the go tool is compiling something.

OK, but shouldn't compiler inform user about such error by default? Any text editor does, for instance.

If there is nothing to compile, go build will do nothing.

On 22 Nov. 2016, at 20:58, piotrfti<EMAIL_ADDRESS>wrote:
OK, but shouldn't compiler inform user about such error by default? Any text editor does, for instance.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Please copy & paste here the command you run (with -x added) and its output.

go build -ldflags="-H windowsgui" -x
WORK=AppData\Local\Temp\go-build870179366 mkdir -p $WORK\_\C_\Data\git\translations\go\gui\quarkChecker\_obj\ mkdir -p $WORK\_\C_\Data\git\translations\go\gui\quarkChecker\_obj\exe\ cd C:\Data\git\translations\go\gui\quarkChecker "c:\\Data\\Portable\\PortableApps\\go\\pkg\\tool\\windows_amd64\\compile.exe" -o "AppData\\Local\\Te mp\\go-build870179366\\_\\C_\\Data\\git\\translations\\go\\gui\\quarkChecker.a" -trimpath "AppData\\ Local\\Temp\\go-build870179366" -p main -buildid b9a1985bd9270962f5b434b31379e26bfb1c5797 -D _/C_/Data/git/translations/ go/gui/quarkChecker -I "AppData\\Local\\Temp\\go-build870179366" -pack "C:\\Data\\git\\translations\ \go\\gui\\quarkChecker\\checker.go" "C:\\Data\\git\\translations\\go\\gui\\quarkChecker\\quarkChecker.go" pack r "AppData\\Local\\Temp\\go-build870179366\\_\\C_\\Data\\git\\translations\\go\\gui\\quarkCheck er.a" "C:\\Data\\git\\translations\\go\\gui\\quarkChecker\\rsrc.syso" # internal cd . "c:\\Data\\Portable\\PortableApps\\go\\pkg\\tool\\windows_amd64\\link.exe" -o "AppData\\Local\\Temp\ \go-build870179366\\_\\C_\\Data\\git\\translations\\go\\gui\\quarkChecker\\_obj\\exe\\a.out.exe" -L "C:\\Users\\pczajko\ \AppData\\Local\\Temp\\go-build870179366" -extld=gcc -buildmode=exe -buildid=b9a1985bd9270962f5b434b31379e26bfb1c5797 -H  windowsgui "AppData\\Local\\Temp\\go-build870179366\\_\\C_\\Data\\git\\translations\\go\\gui\\quark Checker.a" cp $WORK\_\C_\Data\git\translations\go\gui\quarkChecker\_obj\exe\a.out.exe quarkChecker.exe
I've stripped c:\users\username part.

It doesn't look like you've set GOPATH

On 22 Nov. 2016, at 22:54, piotrfti<EMAIL_ADDRESS>wrote:
go build -ldflags="-H windowsgui" -x
WORK=AppData\Local\Temp\go-build870179366 mkdir -p $WORK_\C_\Data\git\translations\go\gui\quarkChecker_obj\ mkdir -p $WORK_\C_\Data\git\translations\go\gui\quarkChecker_obj\exe\ cd C:\Data\git\translations\go\gui\quarkChecker "c:\Data\Portable\PortableApps\go\pkg\tool\windows_amd64\compile.exe" -o "AppData\Local\Te mp\go-build870179366\\C\Data\git\translations\go\gui\quarkChecker.a" -trimpath "AppData\ Local\Temp\go-build870179366" -p main -buildid b9a1985bd9270962f5b434b31379e26bfb1c5797 -D /C/Data/git/translations/ go/gui/quarkChecker -I "AppData\Local\Temp\go-build870179366" -pack "C:\Data\git\translations\ \go\gui\quarkChecker\checker.go" "C:\Data\git\translations\go\gui\quarkChecker\quarkChecker.go" pack r "AppData\Local\Temp\go-build870179366\\C\Data\git\translations\go\gui\quarkCheck er.a" "C:\Data\git\translations\go\gui\quarkChecker\rsrc.syso" # internal cd . "c:\Data\Portable\PortableApps\go\pkg\tool\windows_amd64\link.exe" -o "AppData\Local\Temp\ \go-build870179366\\C\Data\git\translations\go\gui\quarkChecker\obj\exe\a.out.exe" -L "C:\Users\pczajko\ \AppData\Local\Temp\go-build870179366" -extld=gcc -buildmode=exe -buildid=b9a1985bd9270962f5b434b31379e26bfb1c5797 -H windowsgui "AppData\Local\Temp\go-build870179366\\C_\Data\git\translations\go\gui\quark Checker.a" cp $WORK_\C_\Data\git\translations\go\gui\quarkChecker_obj\exe\a.out.exe quarkChecker.exe
I've stripped c:\users\username part.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

It's set to c:\Data\go. And sometimes there's mv instead of cp, like "mv $WORK_\C_\Data\git\translations\go\gui\quarkChecker_obj\exe\a.out.exe quarkChecker.exe".

It doesn't look like your source is in C:\data\go\src
On Wed, 23 Nov 2016, 20:18 piotrfti<EMAIL_ADDRESS>wrote:

It's set to c:\Data\go. And sometimes there's mv instead of cp, like "mv
$WORK_\C_\Data\git\translations\go\gui\quarkChecker_obj\exe\a.out.exe
quarkChecker.exe".
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/18014#issuecomment-262464857, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA6Puw5AC_t1R4Ljvt3_wii8xlxlWks5rBAT1gaJpZM4K5MeU
.

That's true, it's in completely different location.

Your GOPATH structure isn't optional. Go source code must reside in GOPATH\src. See Getting Started.

Why is it obvious that test.exe was not updated?
Please show a command transcript (full commands and output) with these commands in sequence:

build
dir test.exe
build
dir test.exe

Thanks.

Timed out waiting for reply.


Heterotrophic respiration increases and doesn't drop back down post-fire

Issue discovered when initiating fire at various years during the transient for two Birch and Black Spruce community types calibrated for caribou-poker creek. Heterotrophic respiration increases post-fire and never returns to pre-fire levels. This tilts the ecosystem to a strong C source for perpetuity, which is likely not in line with reality.

This is really interesting: The problem only seems to happen with the RH monthly output. When outputting RH by layer and summing over layers, the post-fire behavior seems much more normal.

Woooow that’s interesting!!!!! Ruth - could you look at it?
If not, let’s meet to talk about this next Wednesday after our tech meeting.
H

On Jun 13, 2024, at 10:23 AM, amullen01 @.***> wrote:
This is really interesting: The problem only seems to happen with the RH monthly output. When outputting RH by layer and summing over layers, the post-fire behavior seems much more normal.
RH_monthly_layer.png (view on web) https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/assets/16657080/ea627c43-fbe2-430e-8eee-1790c074b8be
—
Reply to this email directly, view it on GitHub https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/issues/721#issuecomment-2166502520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVJF4D7WAGBRTNAY4NKYDZHHPRNAVCNFSM6AAAAABJI5I3KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGUYDENJSGA.
You are receiving this because you were assigned.

Oh dear, that's a problem. Yeah, I'll look at it.

Thanks Ruth. Happy to help debug during our meeting tomorrow as well.

The difference is because the total output includes respiration from dead woody debris, while the by-layer output does not. Woody debris respiration is available as a separate output DWDRH, and I'll need to look a bit further and perhaps discuss with you guys how to resolve this.

That makes sense - although DWDRH seems very high. I’ll check on this.
Ruth - I’d still like to make sure that DWDRH is not at all impacting soil C stocks.
I’m pretty sure it’s not, but worth checking.
H

On Jun 14, 2024, at 12:34 AM, Ruth Rutter @.***> wrote:
The difference is because the total output includes respiration from dead woody debris, while the by-layer output does not. Woody debris respiration is available as a separate output DWDRH, and I'll need to look a bit further and perhaps discuss with you guys how to resolve this.
—
Reply to this email directly, view it on GitHub https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/issues/721#issuecomment-2167533747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVJF6WBV5XQCCVMFKPFLLZHKTIVAVCNFSM6AAAAABJI5I3KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGUZTGNZUG4.
You are receiving this because you were assigned.

DEADC dynamic makes sense - it is supposed to be transfer to DWDC over the course of nine years post fire.
The dynamic of DWDC is less reasonable though as there is not input to this pool, beyond DEADC. So it should regularly decrease over time from decomposition.

On Jun 14, 2024, at 9:27 AM, amullen01 @.***> wrote:
deadc_dwdc.png (view on web) https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/assets/16657080/c18fc069-fd73-48f9-b57b-9c3727d73ab9
—
Reply to this email directly, view it on GitHub https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/issues/721#issuecomment-2168465723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVJF63QCN6FEXORASQPVLZHMRW7AVCNFSM6AAAAABJI5I3KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGQ3DKNZSGM.
You are receiving this because you were assigned.

The problem appears to be in Vegetation_Bgc.cpp, lines 287 - 318. In this block of code, d2wdebrisc is given a value > 0, dependent on deadc0. deadc is reduced by d2wdebrisc until deadc is depleted, or months post-fire >= 108. This is all fine, however, there is no mechanism to set d2wdebrisc to zero when deadc is zero post-fire so dead woody debris gets added every time step for the rest of the run. At least I think this is what is happening.

I've been working through this trying to get a handle on what's going on. I ran at Toolik with a single fire, and while I didn't quite get the same dynamics you did, most of them are similar (although DWDC doesn't drop as abruptly, which I think is a good thing). I'll be working on it again later today and will try to more closely match what you've done.

DWDC currently decays at the rate of rawc. Helene suggests that this rate is too fast. I changed the decay rate for DWDC to that of sompr and it looks a bit better. This will work temporarily but ideally there will eventually be a DWDC decay rate.


Improve flutter doctor tool on Arch Linux

Arch Linux official removed the lib32-libstdc++5 from mutilib repository, it is still in the AUR repository, but it has not been successfully compiled under the latest Arch Linux. I was really troubled by this for a long time, and finally I found that only need to install lib32-gcc-libs, flutter works perfectly.
So I modified the Flutter Doctor message, hopefully this will help other Flutter users, no longer bothered by this problem.
Finally, I added /opt/visual-studio-code to the vscode installation path detection. The visual-studio-code-bin package in the AUR repository will be installed to this directory. It works perfectly on my Arch. I hope this change will help more users.

I signed it!

This was partially landed in https://github.com/flutter/flutter/commit/7634a0ecbe0b5d7d0a75c90be619ff25bdeefa72. If the updates for VSCode are still needed, feel free to re-open and update this PR.


[FE] Setup Jest and React Testing Library for Automated Testing

Objective:
Integrate Jest and React Testing Library to establish a framework for automated testing within the application. This will ensure that components and functionality are tested from the start, leading to a more reliable codebase.
Tasks:

Install Jest and React Testing Library, along with necessary configurations.

Write sample unit tests for an existing component.

Document guidelines for writing and running tests.

Acceptance Criteria:

Jest and React Testing Library are correctly set up.

Sample tests are written and successfully pass.

Documentation provides clear instructions on testing practices.

@edichoska @DimitarHristovski should we write the tests in TS as well?

@edichoska @DimitarHristovski should we write the tests in TS as well?

yes


Option to define loader to use

It would be helpful to define which loader to use on the config file in the options, as not all config files will have an extension.
For example, I don't added extensions to my ini files but would still like to load them using a standard library like Vars.
This may only be possible when a single config is loaded or that all configs being loaded will have to be of the same type.

What's the use case for this? Can't you just add a file extension?

I am writing a cli script and would like to get the distro version using /etc/os-release file.

Okay I see, I'll see about doing this, it will be probably be a toggle in the options; something along the lines of default_parser

Can send a pull request if you want :ok_hand: :+1:


v1.2.2 update needs to be synced to npm (currently v1.2.1)

A gentle reminder to please update npm with this release so it can be pulled from config.xml
https://www.npmjs.com/package/cordova-plugin-wkwebview-engine
Thanks!

It's being voted on. The vote will be closing soon and (as it currently stands at the time of writing) the release will continue and be published on NPM.
But if someone ends up voting to reject, then the release may be delayed or 1.2.2 may not even make it to NPM.


[we award bitcoin/ether] Add end2end pipeline for Kaggle with gluon

@smolix as promised

Preview at:
https://github.com/astonzhang/mxnet-the-straight-dope/blob/master/chapter03_deep-neural-networks/kaggle-gluon-kfold.ipynb
It supports k-fold cross-validation with gluon. Hope Kagglers and many others find it helpful.

The reddit link is up:
https://www.reddit.com/r/MachineLearning/comments/70gaqs/we_award_bitcoinether_for_users_who_use/

Shouldn't this go under cheatsheets? It's cool to have an end 2 end kaggle example but it doesnt fit under the modeling chapters.


Provide option to record static pages for later debugging

Problem
The current Logger does not save the HTML of the page being interacted with.
If the issue is due to the Navigation Engine  it could be great to be able to replay this specific step and debug the page without having to recreate the whole process.
For instance, I have some issue in the 4th step of an onboarding form of a bank, and navigation failed. I don't want to redo the whole thing.

Proposed solution
I think we could have something like agent.run(objective, record_html=True) to add to the logger the ability to save the both the real DOM and the frozen in the logs.
@mbrunel

FYI @mbrunel it's important to have the real DOM to test some things on it, but also the frozen one to highlight elements to debug


Proposal feat(k8s): custom labels per application

The idea is to allow additional labels in the application besides name and type defined with the variable K8S_LABELS. For instance deis config:set K8S_LABELS="content=json,platform=nodejs"
This labels are appended to the defaults and the new ones cannot override the defaults

Would this be considered an integration point for deis tags, since kubernetes also performs scheduling based on the labels of the pod in question?

closing as fixed via https://github.com/deis/workflow/pull/261


Use pagefind.debouncedSearch()

This provides a much smoother search UX, as it minimizes the search queries executed in addition to leveraging preloading.
See https://pagefind.app/docs/api/#debounced-search and https://pagefind.app/docs/api/#preloading-search-terms

Looks great, thanks for your contribution.
I'll come down and test it, and will release it in the next version as soon as possible. @ You

I merge it first, and then I will add a option to the debounce time to make it controllable.

you can try<EMAIL_ADDRESS>and  I add option delay, default value 300（same as in the official documents）
export interface SearchConfig {
  // ...other
  /**
   * debouncedSearch delay
   * @default 300
   */
  delay?: number
}


Add go module support

This is based on my comment here.
Fixes #7
This uses go list -mod=readonly -m -json to determine if we should use go modules (and fetch required info). For modules, we use the Dir as the source directory root (instead of GOPATH) and the Path to make IsSupportedReference much more efficient for modules.
E.g. I've cloned https://github.com/xmlking/micro-starter-kit to ~/hub/micro-starter-kit:
$ go list -mod=readonly -m -json

{
	"Path": "github.com/xmlking/micro-starter-kit",
	"Main": true,
	"Dir": "/home/jonjohnson/hub/micro-starter-kit",
	"GoMod": "/home/jonjohnson/hub/micro-starter-kit/go.mod",
	"GoVersion": "1.12"
}

We call that once per invocation to determine if we're in a project using go modules, then reuse that info in order to find packages with matching import paths. If we don't find one, we fall back to GOPATH (old behavior).
This also uses the packages package to handle qualifying local imports (in order to make them work with go modules).

cc @paivagustavo

Honest question because I don't know what users would expect: Do we want to fallthrough to checking the importpath from the gopath here?

Good question... I'm not sure. I can imagine someone wanting to do this, even though ideally all your source would be within your project. Should we stop people from building external dependencies?

Yeah I'm just not sure.
My instinct says we should disallow it until someone asks for it, because that's easier than locking it down in the future. But how this would manifest is by silently passing the reference through to the output YAML, instead of raising an error. :-/

This looks great @jonjohnsonjr. The only caveat about this solution is with multi-modules, if we run ko from inside a sub-module it would not be able to resolve others modules. Take this for example:
├── cmd1
│   ├── main.go
│   └── go.mod // github.com/foo/bar/cmd1
├── cmd2
│   ├── main.go
│   ├── files
│   ├── ─── deploy.yaml  <- reference to // github.com/foo/bar/cmd1
│   └── go.mod // github.com/foo/bar/cmd2
└── go.mod // github.com/foo/bar

Running ko resolve -f files inside the cmd2 it is not going to resolve the github.com/foo/bar/cmd1 since the go list -mod=readonly -m is going to report github.com/foo/bar/cmd2 as the current module. But anyway, I don't see this being an issue here since even the go modules itself doesn't handle this type of dependency very well, just wanted to make you aware of it if you didn't know already.

But anyway, I don't see this being an issue here since even the go modules itself doesn't handle this type of dependency very well, just wanted to make you aware of it if you didn't know already.

Yeah that's really frustrating... I was trying to figure out a way around this, but I'm not sure that it's possible to cover 100% of cases we care about. If you can think of a clean way to do this, we can fix it in a separate PR.
What's worse is that if you have this:
├── cmd1
│   ├── main.go
│   └── go.mod // github.com/foo/bar/cmd1
├── cmd2
│   ├── main.go
│   ├── files
│   └── go.mod // github.com/foo/bar/cmd2
├── deploy.yaml  <- reference to // github.com/foo/bar/cmd1
└── go.mod // github.com/foo/bar

it won't work either unless you rm cmd1/go.mod. We can probably fix this case with some heuristics, e.g. if we match a prefix but we can't import it, we could walk down the filesystem trying each directory between them, but that would only work by convention (child go.mod files with prefixes of parents would have matching directory structures). If people complain about this not working we can try that, too.

My instinct says we should disallow it until someone asks for it, because that's easier than locking it down in the future. But how this would manifest is by silently passing the reference through to the output YAML, instead of raising an error. :-/

Agree with the :-/ but I think you're right. Let's see if anyone actually does this. Updated.

Let's merge this and see how people feel about it.

@jonjohnsonjr I've ran into a need for submodules to be ko-applyable. Do you think this is possible?
Unfortunately what I have is your worst case scenario:
├── cmd1
│   ├── main.go
│   └── go.mod // github.com/foo/bar/cmd1
├── cmd2
│   ├── main.go
│   ├── files
│   └── go.mod // github.com/foo/bar/cmd2
├── deploy.yaml  <- reference to // github.com/foo/bar/cmd1
└── go.mod // github.com/foo/bar

what I have is your worst case scenario

:(
I might be mistaken, but I would think that scenario actually works, since the directory structure matches the go module path structure (handled here where we just match the prefix).
Can you point me to a repro of this? I can take a look when I get back from kubecon.


Fix mistype in RightDoubleClick() mouse method

Problem: RightDoubleClick() method in Mouse class contains a mistype, so it is actually performs LeftDoubleClick().
Proposed fix: Change MouseButton to Right to fix copy-paste issue.
Description:
I noticed a copy-paste issue in Mouse class while investigating the code online. Taking into account that RightDoubleClick() implementation seems to be wrong, I created this PR to fix this small issue.

Haha wow great find. Interesting that it took so long until someone found this.

@Roemer Well, I guess it's not pretty popular method :)

Probably not, but hey, it is fixed now thanks to you.

@Roemer Thanks for great tool. It's a pleasure to do even a such small contribution.


use flt() function

changed T::from().unwrap() to use flt() function defined in lib.rs.
closes #33

Did you try to change it in gradient.rs?

I missed those.

Yup, missed a couple. Everything in this file should be ok now.

Great! It's so nice to read this diff. The new code is so much tidier. I think this was all, so let's run it through the compactor and merge.

...and it's even negative. You managed to shorten the code by one line.

done

Alright, thank you!
@homu r+

:pushpin: Commit eb7b027 has been approved by Ogeon

:zap: Test exempted - status


aceEditor.setValue vs aceEditor.replace

Why don't you use aceEditor.replace for inserting text but use setValue? As i know setValue clears undoredo manager after that impossible to use Ctrl+Z/Y.

Hey, good point - also, just found out it's also mentioned here https://github.com/ace-diff/ace-diff/issues/18 , haven't noticed that comment before. Will create a patch


Display multiple Copr builds for TF results if present

In packit/packit-service#1658 there was implemented that a TF run can be triggered with multiple Copr builds and API for TF runs changed (copr_build_id -> copr_build_ids) as well. This PR implements displaying those builds correctly in the TF result view.
Related to packit/packit-service#1658
The view for the TF runs with only one build stays the same and this is how it looks like for TF runs with more builds:

RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

I know I am a bit late to the party, but can't we add more info to the labels?
(I really like that you've changed the visual style from the pure text.)
What about something like this?

Or maybe even with the numbers to be explicit?

Or use this syntax just with the extra build but that could complicate things.
@mfocko Do you know what is the difference between this and pipelines that we've lost the space between the labels?

@lachmanfrantisek the reason why I didn't want to do it that way was that it would require an additional API call since in the response for TF model we get only Copr build IDs. I was thinking about displaying the IDs instead of Build 1, 2, but on the other hand, the Copr build IDs are IDs in our DB which also does not make that much sense to show. Do you think it is worth it to do additional API calls/ changing the API so that we can display the PR number for the additional build (since you can see more info about the build right after clicking on the link for the build)?

I am not sure if it is worth that extra call... Personally, it sounds logical to know what are these builds about and which one is the core one and which one is the extra one (what we don't know here, do we?). But we can leave it as is and see if anyone will ask for it...

Can we enhance the existing API call so it includes the additional info and we wouldn't need to perform extra API calls?

why does the page load for so long /o\ :peek:

Can we enhance the existing API call so it includes the additional info and we wouldn't need to perform extra API calls?

It is an option (as I already wrote in the previous comment -  changing the API), but the additional processing would be still there, just directly in the packit-service code and I'm not sure I like that kind of API design. I would wait for some feedback and we can revisit/even discuss on arch.


Find bug in login&signup system test

The javascript checkForm() function won't work when one of the if statement contains bug.

Bug fixed!


fix: Wrap the content of _showMaterialBottomSheet with a SafeArea

Wrap the root widget of the builder of _showMaterialBottomSheet in a SafeArea widget (like in CupertinoActionSheet) in order to fix cropped action sheet bottom on some devices when it's not iOS platform.

@ArthurMaroulier Thank you for your contribution. Released in v2.0.3.


[WIP] Add JS to prevent accidentally leaving a page with unsaved changes

Context
We want to prevent a candidate from losing their work by accidentally navigating away from a page so that they don't have to start again. This is particularly frustrating if they wrote a large amount of text in a textarea.
Changes proposed in this pull request
This PR adds some JS to show a popup to check that the candidate doesn't want to leave with unsaved changes but only if there is a textarea on the page.
Screenshot

Guidance to review

How should we test this?
Try it out using the Heroku preview app.

Link to Trello card
https://trello.com/c/SgplKNq9
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Code looks incomplete :spinthinking:

Closing this PR as it's not ready at all.


Also delete VirtualServices created before Knative 0.12

This is to fix the issue that arises if someone migrates from 0.11- to 0.13+.
In Knative 0.13, the way the name of one of the VirtualService is derived from the Ingress name changed from {IngressName} to {IngressName}-ingress. The controller is cleaning the old VirtualService, see code, but this is done with the label networking.internal.knative.dev/ingress which was introduced in 0.12.
As a result, there are two VirtualService matching the same requests. Because the way Istio creates the Envoy configuration is not deterministic, which rule is first (and therefore matching) is random. This means that for each VirtualService change, there is a 50% chance that the new VirtualService is used and "it works" and a 50% chance that the old VirtualService is used and then the behavior varies: if the revision is still around, the traffic will go to that revision, if it is not, it will lead to a 503.
The fix would be to also use the label serving.knative.dev/route in the selection logic, this way it would handle VirtualService created before 0.12.
/cc @tcnghia @Cynocracy @vagababov

/assign @tcnghia @Cynocracy @vagababov

/lgtm

/approve

/hold

The selector is incorrect, it should be ing.GetLabels()[serving.RouteLabelKey]

The selector is incorrect, it should be ing.GetLabels()[serving.RouteLabelKey]

It shouldn't matter in practice because they are the same, but still.

/lgtm

/hold cancel

/retest

/check-cla

/check-cla

@googlebot
/check-cla


CMS styling

The CMS (overview/add/edit) can use some styling. The styling is now very basic and not 100% responsive.

Changes I have made to the CMS:

changed the styling of the CMS.
changed the UI to make it easyer to use.
have added a serverside validation, that checks if all the required fields were filled in.


Fix wrong docsTest trigger id

It was mistakenly Gradle_Master_Gradle_Master_Check_DocsTest_Java18_Macos_Trigger, causing ci-health builds to fail.

https://builds.gradle.org/buildConfiguration/Hygiene_AutoUpdateTestSplitJsonOnGradleMaster/59986066?hideProblemsFromDependencies=false&hideTestsFromDependencies=true&expandBuildProblemsSection=true&expandBuildChangesSection=true

@bot-gradle test and merge

I've triggered a build for you.


Include mix (and thus patch) from @jkcfg/mixins in the standard library

mix() seems to be a useful and general primitive. We should include a version of it in the standard library so people don't have to setup npm and a package.json to have access to this primitive.

We can just add it, and deprecate jkcfg/mixins, though it would be nice to do #100 first so it can be a submodule.

This was done in #140. Closing.


SON models as well as many other models get an error message, when the copy-paste is used

create SON, create a condition
copy and paste it to get an error message, that the condition does not have a name

sgaflv at 2014-05-21T09:45:22Z:

the same problem is present in many other models which were not adapted to the new hierarchical reference manager

danilovesky at 2014-06-04T13:26:29Z:
It may be unrelated to the hierarchical reference manager. I saw a similar problem in CPOG model, when a vertex was copied which had a condition assigned (see bug #1288336). The reason is that when copying a selection, first the inverse of that selection is removed and the remaining portion is serialised. As a result, a node which was not initially selected, but is referenced from a selected node may get removed.

sgaflv at 2014-06-04T18:40:29Z:
the problem is related to the reference manager at least in some models. In CPOG there is something additional to fix.


Update json file example

Proposed changes

https://docs.docker.com/ee/ucp/admin/configure/join-nodes/join-windows-nodes-to-cluster/#compatibility-with-daemonjson
Update the Compatibility with daemon.json  example

Related issues (optional)
https://github.com/docker/docker.github.io/issues/9114

Deploy preview for docsdocker ready!
Built with commit d0084587e4cab2c46e1b93a45c40473be639f604
https://deploy-preview-9976--docsdocker.netlify.com

@usha-mandya @KoryKessel-Docker PTAL. I verified that the information is correct via Microsoft's KB.

@traci-morrison Looks good with some minor suggestions noted above.

@traci-morrison Looks good with some minor suggestions noted above.

Thanks @usha-mandya. I made your suggested changes. Can you review again?


Punctuation in chat

So doing any type of command (for the server I play on we can use chat commands like /s /g /l etc for other channels for chatting) such as /s then using any of these punctuation mars - ' \ and " will give an error message and won't let you send the message; using both quotation marks will let you send the message but won't show them - http://i.imgur.com/Ou3Ug9T.png but with only one of them you get this error - http://i.imgur.com/jJkqb7J.png
I assume you already know this but it'd be nice if there was a work-around for chats and /msg, /r /whisper, etc.

On March 9, 2016 9:34:40 AM PST, Oliver<EMAIL_ADDRESS>wrote:

So doing any type of command (for the server I play on we can use chat
commands like /s /g /l etc for other channels for chatting) such
as /s then using any of these punctuation mars - ' \ and " will
give an error message and won't let you send the message; using both
quotation marks will let you send the message but won't show them -
http://i.imgur.com/Ou3Ug9T.png but with only one of them you get this
error - http://i.imgur.com/jJkqb7J.png
I assume you already know this but it'd be nice if there was a
work-around for chats and /msg, /r /whisper, etc.

Reply to this email directly or view it on GitHub:
https://github.com/SpongePowered/SpongeCommon/issues/569

This is intentional. Use backslash escapes like basically every shell ever. There might also be a raw joined string, which can be combined with lenient parsing (iirc can be set in CommandSpec) to work without having to use escapes.

I think the crux of the issue is that in certain situations, like chat, it's not user-friendly. Players are used to vanilla chat allowing these characters without special escaping (and many need to be educated as to what escaping means) so in certain contexts we need a way to treat them normally.

The RemainingJoinedStringsCommandElement seems to support a raw option, although from what I can tell there is no way to set it currently.

Is this still an issue?

I'm not able to reproduce this with 1.12 (bleeding branch).

To follow up, it is by design for most of the elements, and GenericArguments.remainingRawJoinedStrings is now exposed.


Error loading image

When I use the screenshot tool, I find an Error loading image.

Please provide a repro on jsfiddle. I suspect your server isn't sending the images with cors headers, but you are using useCORS

Please provide a repro on jsfiddle. I suspect your server isn't sending the images with cors headers, but you are using useCORS

How to detect whether the server sends headers with cors?
html2canvas is working on my macos, but it's not work in my iphone 11 ios 14.4
Error message "Error loading background-image" "Error loading image"

请提供关于 jsfiddle 的重现。我怀疑您的服务器没有发送带有 cors 标头的图像，但您正在使用useCORS

如何检测服务器是否发送带有cors的标头？ html2canvas 在我的 macos 上工作，但在我的 iphone 11 ios 14.4 中不起作用 错误消息“加载背景图像时出错”“加载图像时出错”

I also encountered this problem, did you solve it?

Please provide a repro on jsfiddle. I suspect your server isn't sending the images with cors headers, but you are using useCORS

How to detect whether the server sends headers with cors? html2canvas is working on my macos, but it's not work in my iphone 11 ios 14.4 Error message "Error loading background-image" "Error loading image"

I also encountered this problem, did you solve it?

Please provide a repro on jsfiddle. I suspect your server isn't sending the images with cors headers, but you are using useCORS

How to detect whether the server sends headers with cors? html2canvas is working on my macos, but it's not work in my iphone 11 ios 14.4 Error message "Error loading background-image" "Error loading image"

I also encountered this problem, did you solve it?

I later checked that it was indeed a cross-domain problem.
It should solve the problem of cross-domain. My solution is to use Nginx to proxy image requests

Please provide a repro on jsfiddle. I suspect your server isn't sending the images with cors headers, but you are using useCORS

How to detect whether the server sends headers with cors? html2canvas is working on my macos, but it's not work in my iphone 11 ios 14.4 Error message "Error loading background-image" "Error loading image"

I also encountered this problem, did you solve it?

I later checked that it was indeed a cross-domain problem. It should solve the problem of cross-domain. My solution is to use Nginx to proxy image requests
thanks，The problem has been solved in your way


[Audit]: N-03 Inconsistent Error Types

What is the feature you would like to see?
Throughout the codebase, there are some extensions that use associated error types to allow users the flexibility to assign a generic Vec as an error type and encode any error that is needed (or not return an error at all), while others do not use this error style. For example, in the IERC20 trait of the ERC20 implementation.
Consider using a consistent error style to avoid confusion and improve code clarity.
Contribution Guidelines

[X] I agree to follow this project's Contribution Guidelines

Moving to next release (v0.2.0).

Closing as duplication of https://github.com/OpenZeppelin/rust-contracts-stylus/issues/336


doc: release-notes-3.7: Update LED Strip notes

Add an explanation for the CONFIG_WS2812_STRIP_DRIVER deletion.

Perfect - this is much appreciated!

Did you mean to approve?

Perfect - this is much appreciated!

Did you mean to approve?

Duh, thanks!


Not working on android

cards swiping is not woking om android, swipeleft and swiperight both.

Please, provide reproducible example.

Closed for inactivity, feel free to reopen if needed.


Define resource requests and limits for ingress

Changes have been applied already, this is just for completeness (if we're re-creating the cluster)

/retest


Refactor Hamburger code in src\components\Header\index.js (was an ESLint cleanup issue, now a refactor)

Overview
Refactor code to address the following warnings in eslint for src\components\Header\index.js, including burger function refactor.
✖ 18 problems (1 error, 17 warnings)
0 errors and 2 warnings potentially fixable with the --fix option.
Action Items

[ ]    2:1   warning  Expected 'single' syntax before 'none' syntax                                 sort-imports
[ ]     3:27  warning  Member 'useEffect' of the import declaration should be sorted alphabetically  sort-imports
[ ]      4:1   warning  Expected 'single' syntax before 'multiple' syntax                             sort-imports
[ ]      6:16  error    Arrow function has too many lines (87). Maximum allowed is 50                 max-lines-per-function
[ ]     34:1   warning  This line has a length of 107. Maximum allowed is 100                         max-len
[ ]     35:1   warning  This line has a length of 159. Maximum allowed is 100                         max-len
[ ]     38:1   warning  This line has a length of 122. Maximum allowed is 100                         max-len
[ ]     43:1   warning  This line has a length of 120. Maximum allowed is 100                         max-len
[ ]     46:1   warning  This line has a length of 110. Maximum allowed is 100                         max-len
[ ]     47:1   warning  This line has a length of 119. Maximum allowed is 100                         max-len
[ ]     48:1   warning  This line has a length of 156. Maximum allowed is 100                         max-len
[ ]     55:1   warning  This line has a length of 120. Maximum allowed is 100                         max-len
[ ]     66:1   warning  This line has a length of 120. Maximum allowed is 100                         max-len
[ ]     69:1   warning  This line has a length of 106. Maximum allowed is 100                         max-len
[ ]     70:1   warning  This line has a length of 113. Maximum allowed is 100                         max-len
[ ]     71:1   warning  This line has a length of 117. Maximum allowed is 100                         max-len
[ ]     72:1   warning  This line has a length of 103. Maximum allowed is 100                         max-len
[ ]     87:1   warning  Trailing spaces not allowed                                                   no-trailing-spaces

is the eslint warnings here meant for the header or the footer? The issue title and description are different.

is the eslint warnings here meant for the header or the footer? The issue title and description are different.

Scope and focus of issue updated: resolving ESLint warnings with regard to line and function length involves adjusting burger logic (non-trivial code refactor).

Scope and focus of issue updated: resolving ESLint warnings with regard to line and function length involves adjusting burger logic (non-trivial code refactor).

Progress: refactoring
Blocks: none
Availability: 10 hours
ETA: 1/18/21

Progress: refactoring
Blocks: none
Availability: 10 hours
ETA: 1/18/21

Progress: first refactor done
Blocks: none
Availability: 10 hours
ETA: 1/24/21

Progress: first refactor done
Blocks: none
Availability: 10 hours
ETA: 1/24/21

Progress: done
Blocks: wanted to get confirmation on material UI implementation
Availability: 5 hours
ETA: 1/24/21

Progress: done
Blocks: wanted to get confirmation on material UI implementation
Availability: 5 hours
ETA: 1/24/21

Make sure that issue 230 is resolved by your current work.  If not, after this issue is closed.  Release dependency on #230.

Make sure that issue 230 is resolved by your current work.  If not, after this issue is closed.  Release dependency on #230.

Progress: implementing hover effect from third party library 'material-ui-popup-state'
Blocks: none
Availability: 5 hours
ETA: 2/3/2021

Progress: implementing hover effect from third party library 'material-ui-popup-state'
Blocks: none
Availability: 5 hours
ETA: 2/3/2021

Progress: done, will make pull request tonight
Blocks: none
Availability: 5hours
ETA: 2/4/21

Progress: need to pull request
Blocks: none
Availability: 5hours
ETA: 2/4/21

@codewilling please refer to Figma design


Add method rename_dont_move to LocalFileSystem

Description
See issue #2050
Motivation and Context
When the method temporary_path is called on LocalTarget, a warning is
given because the default implementation of the method rename_dont_move
is used. However LocalFileSystem has already a more sophisticated
implementation of the desired functionality in the move method. Here
rename_dont_move is implemented by means of this move method.
Additionally the exception raised by move is changed from RuntimeError
to FileAlreadyExists, as the latter is expected by the test of
rename_dont_move.
Have you tested this? If so, how?
Run the tests in test/local_target_test.py

Thanks!


python312Packages.sse-starlette: 2.1.0 -> 2.1.0

Diff: https://github.com/sysid/sse-starlette/compare/refs/tags/v2.1.0...v2.1.0
Changelog: https://github.com/sysid/sse-starlette/blob/2.1.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 302068 run on x86_64-linux 1

4 packages built:

python311Packages.sse-starlette
python311Packages.sse-starlette.dist
python312Packages.sse-starlette
python312Packages.sse-starlette.dist


Fixes broken claredi html writer.

@RomanKapitonov Thank you.  BTW, it would be awesome to have the REAME updated with a small sample or a note about this class.


Tree with parent pointers VS zippers

I think zippers are neater, see also https://blog.yaakov.online/red-green-trees/

https://github.com/stefnotch/mathml-editor/commit/82c234501ea6177dc352147aac38b83b0d9dd44d still has the Tree with parent pointers design

Zippers are nice so far

See also #20 and readme

Everyone uses zippers or red-green trees

Neato, we could have constant time comparisons for zipper equality (given non-pathological trees)
Though a simple very nested fraction gives us an exponential growth of the number so that's not so cool in the worst case. We can survive like 32 nested fractions.
current = this
zipperValue = this.indexInParent + 1; // 0 equals end, so we pretend there's an unreachable child at the far left
while(this.parent != null) {
  current = this.parent
  zipperValue = zipperValue * (current.length+1) + current.indexInParent
}
return zipperValue; // wait wtf is that a unique encoding?

fromZipperValue(zipperValue, root) {
  current = root
  while(zipperValue > 0) {
    index = (zipperValue mod (current.length+1)) - 1;
    zipperValue = floor(zipperValue / (current.length+1))
    current = current.children[index]
  }
}

Now I'm thinking about redesigning this in Rust.
API comes first, and the internal structure should be an implementation detail. I want the zippers to be the public API.

https://michaeldadams.org/papers/scrap_your_zippers/

Having parent references (including the zipper or red-green node types) is much easier when you have a homogeneous tree. Then you don't have to deal with cases like "this table cell node can only have a table as its parent". (See also https://github.com/stefnotch/mathml-editor/issues/21#issuecomment-1422717057 )


Need Call Back function option on cancel event

Hi,
Need a call back function on cancel event for clearing the canvas or to retain the original image.
Like on capture fail from native camera API.
Regards,
N Baua

hi there,
did you find a solution for this?
Thank you

Nope not yet


New help and feedback mechanism added.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/albaloo/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@albaloo just tested this PR on windows cmd, and your recent changes do NOT fix the issue. Please test on cmd. Also CI

I confirm that it works on cmd, bash, and powershell now.

I see this atm.

@albaloo the ui looks good on cmd now :)

@albaloo the ui looks good on cmd now :), just address CI and make sure to rebase off of master

The PR is ready.

@albaloo theres still the spelling typo:
human overloads -> human overlords

@albaloo theres still the spelling typo:
human overloads -> human overlords

@williexu Done :)

Closing in favor of https://github.com/Azure/azure-cli-extensions/pull/390


'sass-globbing' error after 3.3.7

Looks like using sass-globbing in 3.3.9 breaks middleman build but works fine in 3.3.7. Here's the error we're seeing:
.../ruby/1.9.1/gems/sass-globbing-1.1.1/lib/sass/globbing/importer.rb:4:in `<top (required)>': uninitialized constant Sass::Importers (NameError)
	from .../ruby/1.9.1/gems/sass-globbing-1.1.1/lib/sass/globbing.rb:6:in `require'
	from .../ruby/1.9.1/gems/sass-globbing-1.1.1/lib/sass/globbing.rb:6:in `<top (required)>'
	from .../ruby/1.9.1/gems/sass-globbing-1.1.1/lib/sass-globbing.rb:1:in `require'
	from .../ruby/1.9.1/gems/sass-globbing-1.1.1/lib/sass-globbing.rb:1:in `<top (required)>'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:76:in `require'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:76:in `block (2 levels) in require'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:72:in `each'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:72:in `block in require'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:61:in `each'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler/runtime.rb:61:in `require'
	from /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bundler-1.7.2/lib/bundler.rb:133:in `require'
	from .../ruby/1.9.1/gems/middleman-core-3.3.9/lib/middleman-core/load_paths.rb:37:in `setup_load_paths'
	from .../ruby/1.9.1/gems/middleman-core-3.3.9/bin/middleman:10:in `<top (required)>'
	from .../ruby/1.9.1/bin/middleman:23:in `load'
	from .../ruby/1.9.1/bin/middleman:23:in `<main>'

Any chance you could make a little test project that I can add to our test suite

I made https://github.com/mattsacks/middleman-sass-globbing-test to demonstrate the issue. Let me know if you need anything else!

Remove the gem from your Gemfile, works fine for me. That gem is dumb, our globbing is accomplished through sprockets anyways.
Also, that repo doesn't actually include any globbing :)
Let me know if the above doesn't fix the problem in your real app. Please re-open if that's the case.

:+1:

Yea, the repo had the same issue with Middleman starting up before I actually got to adding any files for globbing.


Fix symfony 5 compatibility by allowing composer 1.10.0-RC

Laravel 7 has a hard requirement for Symfony 5, which is only supported in this RC version of composer.

➜ composer require nunomaduro/larastan
Using version ^0.5.2 for nunomaduro/larastan
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 11 installs, 0 updates, 0 removals
  - Installing phpstan/phpstan (0.12.14): Loading from
 cache
  - Installing symfony/filesystem (v5.0.5): Loading fr
om cache
  - Installing composer/xdebug-handler (1.4.1): Loadin
g from cache
  - Installing composer/spdx-licenses (1.5.3): Loading
 from cache
  - Installing justinrainbow/json-schema (5.2.9): Load
ing from cache
  - Installing seld/phar-utils (1.1.0): Loading from c
ache
  - Installing seld/jsonlint (1.7.2): Loading from cac
he
  - Installing composer/semver (1.5.1): Loading from c
ache
  - Installing composer/ca-bundle (1.2.6): Loading fro
m cache
  - Installing composer/composer (1.10.0-RC): Loading from cache
  - Installing nunomaduro/larastan (v0.5.2): Loading from cache
nunomaduro/larastan suggests installing orchestra/testbench (^4.0 || ^5.0)
Package moontoast/math is abandoned, you should avoid using it. Use brick/math instead.
Writing lock file
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: fruitcake/laravel-cors
Discovered Package: laravel/telescope
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Package manifest generated successfully.
phpstan/extension-installer: Extensions installed
> nunomaduro/larastan: installed

I managed to install without any problems, without that change.

@nunomaduro Because it loaded the 1.10.0-RC version from the cache for you. Check the output.
I believe this change is correct. I read the issues in the composer repo.
I'll also test it in a moment.

Ok. I have the same result.
Created new Laravel project with composer create-project --prefer-dist laravel/laravel larastan-test
Installing Larastan with composer require --dev nunomaduro/larastan
No errors.
@spawnia Did you test this before opening the PR? Can you maybe share your config?

This composer.json triggers a conflict:
{
    "require": {
        "laravel/framework": "^7.0"
    },
    "require-dev": {
        "nunomaduro/larastan": "^0.5.2"
    }
}

I can run composer install only after adding "minimum-stability": "dev".

That would make sense RC is not a stable release. But Laravel ships with "minimum-stability": "dev" by default. So shouldn't be a problem for most of the people.

So shouldn't be a problem for most of the people.

Agree that most users won't have that problem, although some still might. For instance, i am developing a package for Laravel and had trouble installing.
Adding this fix temporarily would smooth the transition. It can be removed once composer releases a stable version (who knows how long that is going to take?).

@nunomaduro Any opinion on this?

Composer 1.10 is released now. So you can use the stable release, and we can close this.


Expose a way for jest-cli to run jest with a specific project(s)

🚀 Feature Proposal
Allow jest-cli to run jest with a specific project(s) configuration(s) declared from the projects key.
Motivation
The motivation for this is to allow for different jest runners to be executed along with its own configuration. Currently this is only possible if different directories have it's own jest config. But in the case that you only have one jest config and your different configurations exist through the projects key, this can't be done.
Example
Given a jest config, I want to be able to run jest with the configuration using jest-runner-eslint and jest-runner-prettier.
jest.config.js

module.exports = {
  projects: [
    {
      displayName: 'SPEC',
      clearMocks: true,
      coverageDirectory: 'coverage',
      coveragePathIgnorePatterns: ['/node_modules/', '/constants/'],
      moduleFileExtensions: ['js', 'json', 'jsx', 'node'],
      testEnvironment: 'node',
      testPathIgnorePatterns: ['/node_modules/'],
      testMatch: ['<rootDir>/src/**/*.(spec|test).js'],
    },
    {
      displayName: 'E2E',
      clearMocks: true,
      coverageDirectory: 'coverage',
      coveragePathIgnorePatterns: ['/node_modules/', '/constants/'],
      moduleFileExtensions: ['js', 'json', 'jsx', 'node'],
      testEnvironment: 'node',
      testPathIgnorePatterns: ['/node_modules/'],
      testMatch: ['<rootDir>/test/**/*.(e2e).js'],
    },
    {
      displayName: 'LINT',
      runner: 'jest-runner-eslint',
      testMatch: ['<rootDir>/src/**/*.js', '<rootDir>/test/**/*.js'],
    },
    {
      displayName: 'PRETTIFY',
      "runner": "jest-runner-prettier",
      "moduleFileExtensions": [
        "js",
        "jsx",
        "json",
        "ts",
        "tsx",
        "css",
        "less",
        "scss",
        "graphql",
        "md",
        "markdown"
      ],
      "testMatch": [
        "**/*.js",
        "**/*.jsx",
        "**/*.json",
        "**/*.ts",
        "**/*.tsx",
        "**/*.css",
        "**/*.less",
        "**/*.scss",
        "**/*.graphql",
        "**/*.md",
        "**/*.markdown"
      ]
    },
  ],
};

Pitch
I believe that this feature should bring good value to jest as a whole since it ties into the idea of having jest as a platform and takes advantage of the capabilities of the different jest runners

Related: #6189

What would the API look like?
I have a quick proposal:

Introduce projectName in the config. If displayName is not specified, it uses the value of projectName. If projectName is not specified, then it is project_$N where $N is the index in the array.
Introduce the --runProject CLI argument. It takes any number of projects as parameters. They are matched using projectName. We could define -p as a possible shorthand for --runProject.

Example:
module.exports = {
  projects: [{
    projectName: 'unit'
    ...<some stuff>
  }, {
    projectName: 'e2e',
    ...<some stuff>
  }]
}

To only run the unit tests, we would execute jest --runProject unit or jest -p unit.
This is a very quick proposal to get the discussion started. I haven't thought through all the implications.

From #6189 I understand that you would be up for it @SimenB, (or at least something similar). I'll try something out immediately. I won't mind some help in figure out a suitable API and possible edge cases that need to be considered.

Cannot wait for this. I always have to go edit the jest config just to run a damn test in the debugger. Then the edited config gets checked in sometimes. There has got to be a better way.

You can use https://github.com/jest-community/jest-watch-select-projects in watch mode. Not sure if it helps in your case or not, though

In our case, we have a jest.config.js and switch the preset we run on our monorepo with a process environment variable:
module.exports = {
  preset: process.env.JEST_PROJECT === 'integration' ? 'jest-test-integration' : 'jest-test-code',
}

Then we run jest like:
JEST_PROJECT=integration jest

to select the project (:

This would be great :-). I want to have a centralised jest.config.js with projects in my monorepo but be able to run each project separately if needed. Today I guess the only way is to put separate jest.config.js in every package. To me, one of the benefits of monorepo is that you can centralize at lot of the development config to the top level instead of having it in every package.

@yacinehmito Did start to look into this? Would be a great feature to have.

@thernstig Sorry I did not answer earlier. Yes I did look into it. A PR is currently open: #8612.


feat: mobile settings

[x] added a burger menu and overlay for mobile.
[x] moving some things around.

@shmodarresi  hmm i didnt notice that on my branch, don't know why. it should be added to the menu also i suppose.

ill wait for some input for anita for how to handle the create-market button on the mobile menu (maybe it will become a UL item instead)

i moved the button to a slightly more friendly location and it will stay there until there's some final designs (per anita)


Update github-projects.md

Updating samples repo link and adding Toolkit link

@mikaelweave
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


facebook/twitter meta in head

https://developers.facebook.com/docs/sharing/webmasters
https://dev.twitter.com/cards/markup

This issue was moved to StartupShell/web#4


Add access control user groups in deployment

Hello!
Great page to show how to deploy a product, but I feel that it is missing how to add a user group to the "Access control"-page using either Azure CLI / ARM template. Cant find how to do this anywhere.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6c12f877-77a9-0593-a539-2b011f9f83cd
Version Independent ID: 0d600bc9-7ec1-27f5-5d27-a5d22e2e8629
Content: Tutorial - Create and publish a product in Azure API Management
Content Source: articles/api-management/api-management-howto-add-products.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@simonstender - Thanks for the good suggestion! I'll look if for our backlog, and we should be able to include some information about adding groups the next time we update this article. I believe the relevant ARM/bicep reference is here. According to our usual process, I'll now proceed to close this issue.
#please-close


Can the keeper of IBC transfer be changed to an interface?

Summary
Can the keeper of IBC transfer be changed to an interface?
Problem Definition
I am currently working on a project to automatically mint some vouchers to the user when the user transfers tokens. I think there is a need to ensure the transactional of these operations, so the mint needs to be completed at the same time as the transfer takes place.
This is easy to achieve in the keeper of the bank module, because the keeper of the bank is an interface.
https://github.com/cosmos/cosmos-sdk/blob/dd9ef120f3415c4d84d3ce34267453ecb94b797f/x/bank/keeper/keeper.go#L22
I just need to refer to the keeper of the bank module and wrap the SendCoins(...) method, and then replace the keeper of the bank module:
https://github.com/wangfeiping/flares/blob/1ed7d65a6f5cd8566267adc038c8fe47c42f32d5/app/app.go#L272
https://github.com/wangfeiping/flares/blob/1ed7d65a6f5cd8566267adc038c8fe47c42f32d5/x/bank/keeper/keeper_wrapper.go#L15
https://github.com/wangfeiping/flares/blob/1ed7d65a6f5cd8566267adc038c8fe47c42f32d5/x/bank/keeper/keeper_wrapper.go#L41
But IBC transfer's keeper is not an interface, so it can't be implemented that way.
https://github.com/cosmos/cosmos-sdk/blob/dd9ef120f3415c4d84d3ce34267453ecb94b797f/x/ibc/applications/transfer/keeper/keeper.go#L36
If the keeper of IBC transfer is also defined by interface, will it be more in line with OCP (Open Close Principles ) and more conducive to future maintenance and expansion?
Proposal
Please change the keeper of IBC transfer to the interface.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

It is possible for you to create the interface for ics20? This should be similar to how our modules use expected_interface.go in each types package.
Closing this issue for now


How to use it with NuxtJS?

Is there any way to use this plugin with NuxtJS app?

did you find the solution for the same.

@nilesh-yadav-ey I could not find a way and implemented it with traditional methods.


“Test Anything Protocol” output mode

TAP (Test Anything Protocol) is a simple text protocol to deal with test results. It should be quite easy to implement, and would make acutest easily integrate with existing tools.
A TAP output looks like this:
1..4
ok 1 - Input file opened
not ok 2 - First line of the input valid
ok 3 - Read the rest of the file
not ok 4 - Summarized correctly # TODO Not written yet

It would enable for example to produce JUnit XML files for the test results and displaying them in GitLab merge requests, or to display the test results in Jenkins easily

I have cooked something in PR #17.
Given I do not have any TAP harnessing running anywhere, it would be cool if you could test it before I merge it.
To enable it, use the new --tap option.


[Feature]:  Add tooltips in switch and checkbox

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Within the switch and checkbox widget, we need to support tooltip property similar to the input widget.
Why should this be worked on?
Consistency of properties across appsmith
 Front conversations

+1 for this. I have a very big form for finance where I need to guide my users on what to fill up for each field or why ticking the checkbox / switch is important. Without the tooltips, there will be a big usability issue in my app.


[Bug] Illuminate\Contracts\Container\BindingResolutionException : Target class [Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController] does not exist.

Bug report
What I did
I've got that error running laravel's (latest) default tests. Namespace issue?
Is it a bug in the latest version of Backpack?
yes
Backpack, Laravel, PHP, DB version
PHP 8.1.6 (cli) (built: May 11 2022 08:55:59) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.6, Copyright (c) Zend Technologies
LARAVEL VERSION:
v9.45.1@faeb20d3fc61b69790068161ab42bcf2d5faccbc
BACKPACK VERSION:
5.4.13@af521f3bfed6de5c41811289d901c6c66f8242e2

This is a duplicate of #4876

This is a duplicate of https://github.com/Laravel-Backpack/CRUD/issues/4876


Rasa Repeatedly Loads NLU Model

Rasa version:
1.10.18
Rasa X version (if used & relevant):
0.32
Issue:
Rasa attempts to load NLU model multiple times despite being successful the first time, causing large memory spikes
Error (including full traceback):
2021-02-18 15:28:23 DEBUG    rasa.nlu.utils.hugging_face.hf_transformers  - Loading Tokenizer and Model for bert
2021-02-18 15:28:25.754020: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)
All model checkpoint weights were used when initializing TFBertModel.
All the weights of TFBertModel were initialized from the model checkpoint at models/pretrained/rasa/LaBSE.
If your task is similar to the task the model of the checkpoint was trained on, you can already use TFBertModel for predictions without further training.
2021-02-18 15:29:53 DEBUG    rasa.utils.tensorflow.models  - Loading the model ...
2021-02-18 15:29:56 DEBUG    rasa.utils.tensorflow.models  - Finished loading the model.
2021-02-18 15:29:56 DEBUG    rasa.utils.tensorflow.models  - Building tensorflow prediction graph...
2021-02-18 15:30:08 DEBUG    rasa.utils.tensorflow.models  - Finished building tensorflow prediction graph.
2021-02-18 15:30:08 DEBUG    rasa.utils.tensorflow.models  - Loading the model ...
2021-02-18 15:30:09 DEBUG    rasa.utils.tensorflow.models  - Finished loading the model.
2021-02-18 15:30:09 DEBUG    rasa.utils.tensorflow.models  - Building tensorflow prediction graph...
2021-02-18 15:30:10 DEBUG    rasa.utils.tensorflow.models  - Finished building tensorflow prediction graph.
2021-02-18 15:30:10 DEBUG    rasa.utils.tensorflow.models  - Loading the model ...
2021-02-18 15:30:11 DEBUG    rasa.utils.tensorflow.models  - Finished loading the model.
2021-02-18 15:30:11 DEBUG    rasa.utils.tensorflow.models  - Building tensorflow prediction graph...
2021-02-18 15:30:12 DEBUG    rasa.utils.tensorflow.models  - Finished building tensorflow prediction graph.
2021-02-18 15:30:12 DEBUG    rasa.utils.tensorflow.models  - Loading the model ...
2021-02-18 15:30:13 DEBUG    rasa.utils.tensorflow.models  - Finished loading the model.
2021-02-18 15:30:13 DEBUG    rasa.utils.tensorflow.models  - Building tensorflow prediction graph...
2021-02-18 15:30:15 DEBUG    rasa.utils.tensorflow.models  - Finished building tensorflow prediction graph.
2021-02-18 15:30:15 DEBUG    pykwalify.compat  - Using yaml library: /opt/venv/lib/python3.7/site-packages/ruamel/yaml/__init__.py
2021-02-18 15:30:16 DEBUG    rasa.core.agent  - Finished updating agent to new model.

Command or request that led to error:

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

@b-quachtran did this get resolved or why did we close?

@akelad It ended up being a non-issue, the prediction graphs being built were because of their multiple ResponseSelectors. The large memory spike is a separate problem that I'm coordinating with research about and related to their embedding model selection.


Node select bar needs pointer and not selectable

Is your feature request related to a problem? Please describe.
Now the bar doesn't have the pointer bar and can be selected
Describe the solution you'd like
Node select bar needs pointer and not selectable

:tada: This issue has been resolved in version 2.12.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Jenkins Plugins Artifactory has degraded performance

In a3fe09f, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1261 ms

Resolved: Jenkins Plugins Artifactory performance has improved in d7bcec0 after 12 minutes.


Agent identify should return a new unique token for every other request

WHY
When the agent identifies with the app it sends a secret token key.
And then for every other request the same token key is used. This feels a bit unsecure.
WHAT
When successfully identified the app will return a new key, maybe a session key, needs a name. Then this new session key must be used on every other call. The original secret token key is only needed on the initial identification.

Agent is now named client. Issue is done.


Image tapped is not image that I wanted

Hi,
Amazing projects and libraries, it's been really helpful, many thanks !
However, with media picker 1.3.0, I am seeing issue on ios 16.6, where the image selected becomes the image below it when it gets loaded, feels like a boundary issue, will continue debugging and provide updates

Hey @X901, thank you very much for your suggestion, please check out version 1.4.0 - the issue should be gone there. Have a wonderful day!


Added new playground game: Stone Age

I'm not sure if this can be used due to the fact that the game didn't show up on all accounts.
StoneAge.txt

lgtm

Is this now showing on all accounts?


Luna experimental

#changelog

added view culling
added itemListNode
added colorRectNode
bugfixes
general optimazations

patch 0.0.6

accepted by lolrobbe2


Fix available organizations

@dclarizio Based on our conversation yesterday.  I adjusted the RegistrationSystem model and spec to return / expect a hash of "Display Name" => "key".  The MiqDatabase columns are registration_organization for the key and registration_organization_display_name for the display name.
Would you prefer to have the UI work added to this PR or in a different PR?

I think you missed a commit or something because the ReservedMixin should not be in the final code.

@brandondunne We should probably have the UI work included in this PR. I think @h-kataria can get this in.

@brandondunne please review/test UI related changes.

@Fryguy made suggested changes.

@h-kataria UI is working great.  Thanks!


WindowDragArea + AppBar = Grey Square

Description
I tried to use WindowDragArea with AppBar, but I got grey square. If single AppBar used, it works, but i'm unable to drag the window.
Code example to reproduce the issue:
title_bar = AppBar(
    leading=Icon(config.custom_title_bar_icon),
    leading_width=30,

    title=Text(config.custom_title_bar_title),
    center_title=True,

    bgcolor=colors.SURFACE_VARIANT,

    actions=[
        IconButton(icons.CIRCLE, on_click=lambda _: [setattr(page, 'window_minimized', not page.window_minimized), page.update()]),
        IconButton(icons.SQUARE_ROUNDED, on_click=lambda _: [setattr(page, 'window_maximized', not page.window_maximized), page.update()]),
        IconButton(icons.CLOSE_ROUNDED, on_click=lambda _: page.window_close())
    ]
)

title_bar = WindowDragArea(title_bar)

page.add(title_bar)

Describe the results you received:

Describe the results you expected:
I expected to drag window with AppBar.

(AppBar if there is no WindowDragArea)
Flet version (pip show flet):
0.10.3

Operating system: Windows.

Also it happens when using AppBar inside any ConstrainedControl..

AppBar can't be used as an "independent" control and be put inside another control. On Flutter side AppBar widget is always attached to Scaffold widget. I'm afraid, this issue cannot be fixed at this stage.
You can try simulating AppBar though with other controls (Container, IconButton, etc.).

Thanks :(


The  component doesn't need to have aria attributes

[Title]: The <ibm-checkbox> component doesn't need to have aria attributes
Detailed description

Describe in detail the issue you're having.

I’m using the IBM Accessibility Checker tool, and in the table component the tool reported that the input tag could not have an aria-checked attribute

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

<ibm-checkbox>

What did you expect to happen? What happened instead? What would you like to see changed?

Remove the aria attributes from

What browser are you working in?

Google Chrome

What version of the Carbon Design System are you using?

"carbon-components": "^10.53.0",
"carbon-components-angular": "^4.57.8"

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

end of June
Steps to reproduce the issue
Run the IBM Accessibility Checker tool on component
Additional information

Screenshots or code

Notes
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked

On it.


Feature/#39 pdf generation additional fixes

Enhanced the Admin Doc to include another known issue with wkhtmltopdf.
Enhanced the error messages during protocol generation shown in the console and as an toast.
PDF Protocols are now - analogue to HTML Protocols - stored on the file system with an ID as filename instead of the meeting series name

Great! Thx! Will merge!


Recursive URI Mapping

Addresses https://github.com/microsoft/sarif-vscode-extension/issues/439. Add recursive URI mapping capability and add the sarif-viewer.maximumRecursionDepth setting to manage maximum recursion depth.

Thanks @vovikhangcdv for your PR. Unfortunately our team is busy at the moment and it may be another week before we can review this. If this issue is blocking, I can try to expedite.

Hi @jeffersonking, glad to see your response. It's totally fine. I think we need to discuss furthermore this issue before it could be merged. Hope to see you back.

Update a commit https://github.com/microsoft/sarif-vscode-extension/pull/440/commits/0d790a30a6230adf806a60c60ca42d0e63143fdd.
The code enhances UriRebaser (Distinct Project Items) by trying directly concat the local workspace path and artifact path. This is also useful to resolve the issue https://github.com/microsoft/sarif-vscode-extension/issues/439.


OIDC Application config is confusing to our customers

While watching a customer changing an oidc application configuration, we noted that the whole form is somehow confusing.
They had to add a new redirect url, but this is not saved after clicking the "+" button. The user has to click the save button below the oidc configuration part.
In my opinion this save button is to far away, so the user don't get that the save button is also for the fields in the top.
Also it is not really clear, that the big buttons (pkce, code, etc) change the oidc configuration.
Maybe it makes sense, to redesign the whole page, so the users will not be confused anymore.
Acceptance criteria

[ ] ui design for detail page of oidc applications

Another issue has been raised over on Discord: Some applications seem to give you the redirect_url only after you have configured the IDP. The Wizard in ZITADEL doesn't like this and complains about missing redirect_url
@juergrinaldi for more info

I just tested: The wizard lets you continue without any warning. But on the created app you'll get a warning that your app is not compliant

I see a couple of issues in this that can be handled without re-designing the whole page, imo.

The saving problem should be handled when/if we transition to the 'auto-save principle' described in #3022
To mitigate the issue with the changed oidc config when selecting one of the other 'boxes/buttons' we could inform the user via toast message that the oidc configs have changed. I'd prefer this way over the re-design because those buttons were designed as some preset guides for non-advanced users. deviate from this approach would probably make it harder again for the standard user to set up OIDC.


GridFunction::ProjectCoefficient (MatrixCoefficient &mcoeff)

Hello all,
Imagine I have a MatrixCoefficient whose DenseMatrix is dimension dim=2. I would like to evaluate such MatrixCoefficient in the nodes of my domain and save it. I have done this using GridFunction::ProjectCoefficient. Specifically, for a Coefficient  using GridFunction::ProjectCoefficient (Coefficient &coeff) and for a VectorCoefficient using GridFunction::ProjectCoefficient  ( VectorCoefficient & vcoeff ). However, there is no method for a MatrixCoefficient.
Maybe there is an alternative to this.
Thank you in advance.
Alvaro

Currently we don't have finite element spaces for matrix-valued functions, so direct projection will not make sense.
One option to get around this could be to treat your MatrixCoefficient as a VectorCoefficient of vector dimension (vdim) 4.

Thank you Tzanio for your reply,
Indeed this is one solution that would make sense. At the end I used a singular coefficient for each matrix element.
Thank you


Fix broken links

Describe the bug
About, Collaborators, Sponsors, Contact Us links are all broken
To Reproduce
Steps to reproduce the behavior:

Go to any page
Click on any of the About, Collaborators, Sponsors, Contact Us links
You'll get a page does not exist error

Expected behavior
The links work.
We used to have a /home route. This is no longer the case. Each of these links should link to

About -> /#behind-the-music
Collaborators -> /#collaborators
Sponsors -> /#sponsors
Contact Us -> /#contact

Additionally, add a route in main.jsx that maps /home to /
Screenshots

blem.

#155 added a redirect form /home to /, but the links are still broken


controls: pressing set while gas pressed resets to vEgo

Does this work? If so, should be good to merge.

Will get a few testers (tester)

DongleID: 549bb645afc16a95
Segment ID: 2022-04-07--12-40-23--7 and 2022-04-07--12-40-23--8
Gave this a try on my Niro EV 2021 and it worked well. There is a minor deviation from stock SCC behaviour. In stock - if the car is going at a higher speed than the set cruise control speed, pressing the set button will always set the speed to the speed the car is going even if the accelerator is not pressed.

Thanks for testing! In those two segments, you were always pressing the gas when you increased the set speed, was there another route where it reset to your current speed when not pressing the gas?

cruise fault occured when testing, but might be caused by something unrelated to these changes :thinking: eb5a50f9e98f50b9|2022-04-07--15-14-34--1
also just noticed that speed can't be initially set if starting from 0 mph. set speed defaults to the standard stock SCC lower limit (20 MPH in my case). however, it can be lowered than that if done manually by up/down cruise buttons

@sshane I think I have done that somewhere else in the same route 2022-04-07--12-40-23, I was also using the fork in another route 2022-04-07--13-13-51. I'm not if I could pinpoint what segments I used it in.


python3Packages.*Hook: support __structuredAttrs = true (the easier ones)

This are the easier, less controversial part of the effort to make buildPythonPackage and buildPythonApplication support both __structuredAttrs = true and structuredAttrs = false.
Each modified Bash script is linted with ShellCheck.
It also fixes some leftovers of #339117 among Python-related hooks.
Split from #347194
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

pypaBuildFlags could be tested with pillow-jpls. This should fail with structuredAttrs on master/staging, if I'm not mistaken, but pass with structuredAttrs in this PR.

pillow-jpls has a strange pypaBuildFlags specification, which seems to expect Bash expansion before execution. However, pypaBuildHook does not evaluate the constructed command before execution like pytestCheckHook does. I wonder if pillow-jpls would ever build as expected by the maintainer.
Cc: @teh (python3Packages.pillow-jpls maintainer)

Update: python3Packages.pillow-jpls works for both __structuredAttrs = true and structuredAttrs = false, but the build logs of both cases contain the following message:
*** Configuring CMake...
CMake Warning:
  Ignoring extra path from command line:

   "'--preset=sysdeps'"

This line is also in the build log of python3Packages.pillow-jpls on the master branch.

I tested it and now I understand what you mean: Because the python code accesses this variable as an environment variable it works without structuredAttrs. But with structuredAttrs this is not an exported environment variable anymore, but just a bash variable - thus python can't read it, and the imports check fails indeed.

Exactly.

Should we merge this in the next couple days?

I was waiting for @ShamrockLee to rebase per responses to review feedback before merging.

Rebased.

LGTM, thanks!


implement the bot mode spec

https://github.com/ircv3/ircv3-specifications/pull/439
I think we have all of this covered except the bot tag?

Yeah. Don't introduce it yet, I'm not sure whether they'll let me skip the draft/ stage for that tag or not :P

This is actually nontrivial, similar to our perennial issue #326. But we can add it to PRIVMSG/NOTICE/TAGMSG fairly easily. Note: this needs to be added to MessageCache as well.

Yeah PRIVMSG/NOTICE/TAGMSG are the main ones, we can add it to those and leave the other messages for later (maybe JOIN is also a pretty important one).


Semantic Versioning

Consider amending/retagging the commit history by following the semantic versioning guide: https://semver.org/

This is rather insignificant until v1.0.0 is released as it is still classed as unstable (despite being stable for the last few commits).


[Bug][FQ2I] Failed to run FakeQuantizationToInteger on QDQ ONNX model

Actual behavior
When I try to apply FakeQuantizationToInteger pass on a Relay IRModule imported from an ONNX model with QDQ quantization representation, it failed with this error message:
  ......
        at .../tvm/include/tvm/runtime/packed_func.h:1646
  1: tvm::relay::qnn::QnnBroadcastRel(tvm::runtime::Array<tvm::Type, void> const&, int, tvm::Attrs const&, tvm::TypeReporter const&)
        at .../tvm/src/relay/qnn/op/op_common.h:310
  0: tvm::relay::qnn::IsScalarType(tvm::Type const&, tvm::runtime::DataType const&)
        at .../tvm/src/relay/qnn/op/../utils.h:225
  File ".../tvm/src/relay/analysis/type_solver.cc", line 624
TVMError:
---------------------------------------------------------------
An error occurred during the execution of TVM.
For more information, please see: https://tvm.apache.org/docs/errors.html
---------------------------------------------------------------
  Check failed: (false) is false: [16:42:40] .../tvm/src/relay/qnn/op/../utils.h:225:
---------------------------------------------------------------
An error occurred during the execution of TVM.
For more information, please see: https://tvm.apache.org/docs/errors.html
---------------------------------------------------------------

  Check failed: tensor_type->shape.size() == 0 (1 vs. 0) :

Environment
TVM v0.10.0
Steps to reproduce
Here is the code to reproduce the BUG:
model_onnx = onnx.load(onnx_path)
ir_mod, _ = relay.frontend.from_onnx(
    model_onnx,
    shape={"input": (1, 3, 224, 224)},
    freeze_params=True
)

passes = tvm.transform.Sequential([
    relay.transform.InferType(),
    relay.transform.FakeQuantizationToInteger(),
])
ir_mod = passes(ir_mod)

Here is the quantized ONNX model with QDQ representation.
regnet_x_400mf_qint8.onnx.tar.gz
Triage
Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).

relay:qnn
frontend:onnx

Ok reproduced, I'll take a look.
BTW, this is an interesting model. How did you quantize it?

Ok reproduced, I'll take a look.
BTW, this is an interesting model. How did you quantize it?

The model is quantized in PyTorch using Torch.FX, then exported using PyTorch's ONNX exporter. (However, currently the onnx exporter only has limited support for quantized model, some Ops like quantized Concat are not supported yet, and the PyTorch team are working on a universal quant handler for ONNX exporter)
The exported model follows the QDQ pattern, one of the quantization representation used by ONNXRuntime's quantizer

I made some progress on debugging this issue. There is a small problem in the way the model is quantized. The scale and zp of the weight and bias are tensors (of shape 1), so Relay thinks this is per-channel quantization. But the output channel size and the size of scale doesn't match (32 vs 1). This leads to huge number of type errors from your model. So can you update your model so that scale and zp of weights and bias are stores as scalars like activation, if you are doing per-tensor quantization?

In the mean time, here is the branch that makes FQ2I work for your model https://github.com/apache/tvm/compare/main...masahi:fq2i-dense-add-fix?expand=1
I've added a hack to the ONNX importer to convert size-1 scale and zp tensors in your model to scalars. But as I said, you should update the way these params are stored in your model.

In the mean time, here is the branch that makes FQ2I work for your model https://github.com/apache/tvm/compare/main...masahi:fq2i-dense-add-fix?expand=1
I've added a hack to the ONNX importer to convert size-1 scale and zp tensors in your model to scalars. But as I said, you should update the way these params are stored in your model.

I found that using rank-1 and size-1 tensor to represent per-tensor scale and zp is also the behavior of ONNXRuntime's quantizer, so is this something TVM's ONNX frontend should take into consideration? Since user has no control over how these quantizer are implemented.

I'd say it is a problem of the ORT quantizer. For activation qparams, they are saved as scalars. They should fix this inconsistency.

I'd say it is a problem of the ORT quantizer. For activation qparams, they are saved as scalars. They should fix this inconsistency.

OK, I will open an issue there