API reports a problem with master but gives no reason

GUI shows no issues. But API does. There's no reasoning in the API on what the problem is. mysql1 in this context is current master.

<EMAIL_ADDRESS>~]$ curl -s http://orchestrator:3000/api/problems | jq
[
  {
    "Key": {
      "Hostname": "mysql1.dc1",
      "Port": 3306
    },
    "InstanceAlias": "",
    "Uptime": 7082,
    "ServerID": 69,
    "ServerUUID": "c5f8675a-3943-11e9-96b4-525400c9c704",
    "Version": "5.7.25-28-log",
    "VersionComment": "Percona Server (GPL), Release 28, Revision c335905",
    "FlavorName": "Percona",
    "ReadOnly": false,
    "Binlog_format": "ROW",
    "BinlogRowImage": "FULL",
    "LogBinEnabled": true,
    "LogSlaveUpdatesEnabled": false,
    "SelfBinlogCoordinates": {
      "LogFile": "mysql-bin.000003",
      "LogPos": 32178342,
      "Type": 0
    },
    "MasterKey": {
      "Hostname": "",
      "Port": 0
    },
    "MasterUUID": "",
    "AncestryUUID": "c5f8675a-3943-11e9-96b4-525400c9c704",
    "IsDetachedMaster": false,
    "Slave_SQL_Running": false,
    "Slave_IO_Running": false,
    "ReplicationSQLThreadState": -1,
    "ReplicationIOThreadState": -1,
    "HasReplicationFilters": false,
    "GTIDMode": "OFF",
    "SupportsOracleGTID": false,
    "UsingOracleGTID": false,
    "UsingMariaDBGTID": false,
    "UsingPseudoGTID": true,
    "ReadBinlogCoordinates": {
      "LogFile": "",
      "LogPos": 0,
      "Type": 0
    },
    "ExecBinlogCoordinates": {
      "LogFile": "",
      "LogPos": 0,
      "Type": 0
    },
    "IsDetached": false,
    "RelaylogCoordinates": {
      "LogFile": "",
      "LogPos": 0,
      "Type": 1
    },
    "LastSQLError": "",
    "LastIOError": "",
    "SecondsBehindMaster": {
      "Int64": 0,
      "Valid": false
    },
    "SQLDelay": 0,
    "ExecutedGtidSet": "",
    "GtidPurged": "",
    "GtidErrant": "",
    "SlaveLagSeconds": {
      "Int64": 0,
      "Valid": false
    },
    "SlaveHosts": [
      {
        "Hostname": "mysql3.dc2",
        "Port": 3306
      },
      {
        "Hostname": "mysql2.dc1",
        "Port": 3306
      }
    ],
    "ClusterName": "mysql1.dc1:3306",
    "SuggestedClusterAlias": "enterprise",
    "DataCenter": "dc1",
    "PhysicalEnvironment": "",
    "ReplicationDepth": 0,
    "IsCoMaster": false,
    "HasReplicationCredentials": false,
    "ReplicationCredentialsAvailable": false,
    "SemiSyncEnforced": false,
    "SemiSyncMasterEnabled": false,
    "SemiSyncReplicaEnabled": false,
    "LastSeenTimestamp": "2019-02-28T23:17:55Z",
    "IsLastCheckValid": true,
    "IsUpToDate": true,
    "IsRecentlyChecked": true,
    "SecondsSinceLastSeen": {
      "Int64": 3,
      "Valid": true
    },
    "CountMySQLSnapshots": 0,
    "IsCandidate": false,
    "PromotionRule": "neutral",
    "IsDowntimed": false,
    "DowntimeReason": "",
    "DowntimeOwner": "",
    "DowntimeEndTimestamp": "",
    "ElapsedDowntime": 0,
    "UnresolvedHostname": "",
    "AllowTLS": false,
    "LastDiscoveryLatency": 15039525
  }
]

@utdrmac please update to latest release where this is resolved.

@shlomi-noach I'm on the latest release 3.0.14 as reported by /web/status

This is a different issue from #756.
In this issue, API reports a server with no obvious problems.

Can you please clarify what problem is reported by the API? I can't see it in the original comment.

Hey Shlomi. There is no problem. That's the issue. If you look in the GUI, there is no error/problem. If you query the /api/problems then you get 1 server back. But there is no problem. So if there is no problem, why is the API reporting the server? Shouldn't the API report back an empty array?

Let me rephrase that. if there is in fact an error, you cannot tell via the API. But I configured this simple M/SS setup, and I know there's no errors. There are no errors in GUI. Yet, the API keeps returning back 1 server (the master) has having some problem, but you cannot tell what that problem is.

@utdrmac got it! Sorry I'm in need of coffee.
Right. https://github.com/github/orchestrator/pull/793 has been merged 21 days ago, and I haven't released since then.
If you use master you should see a Problems field in the JSON output.


[Misc] Load FP8 kv-cache scaling factors from checkpoints

The 2nd PR for #4532.
This PR supports loading FP8 kv-cache scaling factors from a FP8 checkpoint (with .kv_scale parameter).
Specifically,

We now support --kv-cache-dtype {auto, fp8, fp8_e4m3, fp8_e5m2}. auto=fp16 or bf16 and fp8=fp8_e4m3.
If the checkpoint is in FP16, then kv-cache scaling factors can only be loaded via --quantization-param-path; otherwise kv-scale is always 1 regardless fp8_e4m3 or fp8_e5m2.
If the checkpoint is in FP8 (e4m3) AND --kv-cache-dtype {fp8, fp8_e4m3}, kv_scale will be loaded from the checkpoint (if the field presents).

Here is a simple benchmark on a single NVIDIA L4 GPU:

FP16 model: meta-llama/Meta-Llama-3-8B-Instruct
FP8 model: nm-testing/Meta-Llama-3-8B-Instruct-FP8 (no kv-scale so use 1.0 for now).
QPS: 1
Total requests: 30
Average prompt length: 512
Average decoding length: 256 (ignore_eos is not enabled so the actual length may be differ).
Temperature: 0

Model Dtype
kv-cache Dtype
GPU blocks
TTFT (ms)
ITL (ms)
e2e (s)

FP16
FP16
1470
219.0
90.5
15.7

FP16
FP8_e5m2
2940
219.3
88.2
14.9

FP8_e4m3
FP16
4784
148.2
51.3
9.3

FP8_e4m3
FP8_e4m3
9568
147.4
50.1
8.1

@robertgshaw2-neuralmagic @tlrmchlsmth can you help update nm-testing/Meta-Llama-3-8B-Instruct-FP8 to include kv-cache scaling factors so that we could test it? Thanks!
TODO

[x] Unit test.

Also cc @pcmoritz @Yard1
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@robertgshaw2-neuralmagic @tlrmchlsmth can you help update nm-testing/Meta-Llama-3-8B-Instruct-FP8 to include kv-cache scaling factors so that we could test it? Thanks!

I'm pinging some NeuralMagic folks to see if we can get those models updated

Hey y'all, I made this model as a test https://huggingface.co/nm-testing/Meta-Llama-3-8B-Instruct-FP8-KV. I haven't tested the accuracy yet but it should be sufficient for a smoke test @comaniac @tlrmchlsmth

Hey y'all, I made this model as a test https://huggingface.co/nm-testing/Meta-Llama-3-8B-Instruct-FP8-KV. I haven't tested the accuracy yet but it should be sufficient for a smoke test @comaniac @tlrmchlsmth

Thanks! I'll use this model for testing in this PR and post back soon.

Output comparison (using the example prompts in the tests):

meta-llama/Meta-Llama-3-8B-Instruct

'LLM (Large Language Model) is a type of artificial intelligence (AI) model that is trained',
'Here are the major milestones in the development of artificial intelligence (AI) from 1950 to ',
'Artificial intelligence (AI) and human intelligence (HI) differ significantly in how they process information.',
'A neural network is a complex system modeled after the human brain, composed of interconnected nodes or "ne',
'In the vast, sterile laboratory, Robot 3456-Alpha, or "Alpha" for short',
'The COVID-19 pandemic has had a profound impact on global economic structures and future business models. The',
'The Mona Lisa, painted by Leonardo da Vinci in the early 16th century, is one of',
'Here are the translations:\n\n**Japanese:** (Haya aki wa mushi o tsukamu'

nm-testing/Meta-Llama-3-8B-Instruct-FP8 with FP16 kv-cache

'LLaMA is a high-throughput and memory-efficient inference and serving engine for Large Language Models (',
'Here are the major milestones in the development of artificial intelligence (AI) from 1950 to ',
'Artificial intelligence (AI) and human intelligence (HI) differ significantly in how they process information.',
'A neural network is a complex system modeled after the human brain, consisting of interconnected nodes or "ne',
'Zeta-5, a highly advanced robot designed for menial labor, whirred to a',
'The COVID-19 pandemic has had a profound impact on global economic structures and future business models. The',
'The Mona Lisa, painted by Leonardo da Vinci in the early 16th century, is one of',
'Here are the translations:\n\n**Japanese:** (Haya aki no tori, guri o',

nm-testing/Meta-Llama-3-8B-Instruct-FP8-KV with FP8 kv-cache and kv-scale=1.0

'LLaMA is a high-throughput and memory-efficient inference and serving engine for Large Language Models (',
'Here are the major milestones in the development of artificial intelligence (AI) from 1950 to ',
'Artificial intelligence (AI) and human intelligence (HI) differ significantly in terms of processing information.',
'A neural network is a complex system modeled after the human brain, consisting of interconnected nodes or "ne',
'Zeta-5, a highly advanced robot designed for menial labor, whirred to life',
'The COVID-19 pandemic has had a profound impact on global economic structures and future business models. The',
'The Mona Lisa, painted by Leonardo da Vinci in the early 16th century, is one of',
'Here are the translations:\n\n**Japanese:** (Haya aki no tori, guri o'

nm-testing/Meta-Llama-3-8B-Instruct-FP8-KV with FP8 kv-cache and in-checkpoint kv-scale

'LLM (Large Language Model) is a type of artificial intelligence (AI) model that is trained',
'Here are the major milestones in the development of artificial intelligence (AI) from 1950 to ',
'Artificial intelligence (AI) and human intelligence (HI) differ significantly in how they process information.',
'A neural network is a complex system made up of several basic components that work together to enable it to',
'Zeta-5, a highly advanced robot designed for menial labor, had never experienced anything like',
'The COVID-19 pandemic has had a profound impact on global economic structures and future business models. Here',
'The Mona Lisa, painted by Leonardo da Vinci in the early 16th century, is one of',
'Here are the translations:\n\n**Japanese:** (Haya kotori wa mushi o tsuk'

Although we cannot judge the model quality only by these simple prompts, it should verify that the kv-scale from the checkpoint is loaded correctly.

Side note: Since #4907, the flash-attn is used for both prefill and decoding. However, flash-attn doesn't support FP8 input, so now when FP8 kv-cache is enabled, vLLM will enforce to use xFormers backend (which uses paged attention kernel in decoding).

All done. Final note: Per offline discussion with @mgoin, we should accept the checkpoint with HuggingFace model compatible format. In other words, the kv_scale should have the weight name model.layers.0.self_attn.kv_scale. On the other hand, the implementation in this PR puts kv_scale in model.layers.0.self_attn.attn.kv_scale to hide the implementation details from model implementer. We now let the model specific weight loader to deal with this re-mapping, and thus now only Llama and Mixtral could correctly load the kv-scale.

@comaniac Could you please clarify what GPU blocks is recording in the above benchmark? It's not intuitive that the number of GPU blocks are increasing as the model weights size reduced.

The GPU blocks meant the available GPU memory blocks can be used for kv-cache.


Plot the 3D point cloud in the aligned space

Currently the 3D point cloud option under the Landmark variances tab plots in original space, convert this to GPA aligned coordinates.

Fixed


[carry #859] api/services: define the container metadata service

Original description
Working from feedback on the existing implementation, we have now
introduced a central metadata object to represent the lifecycle and pin
the resources required to implement what people today know as
containers. This includes the runtime specification and the root
filesystem snapshots. We also allow arbitrary labeling of the container.
Such provisions will bring the containerd definition of container closer
to what is expected by users.
The objects that encompass today's ContainerService, centered around the
runtime, will be known as tasks. These tasks take on the existing
lifecycle behavior of containerd's containers, which means that they are
deleted when they exit. Largely, there are no other changes except for
naming.
The Container object will operate purely as a metadata object. No
runtime state will be held on Container. It only informs the execution
service on what is required for creating tasks and the resources in use
by that container. The resources referenced by that container will be
deleted when the container is deleted, if not in use. In this sense,
users can create, list, label and delete containers in a similar way as
they do with docker today, without the complexity of runtime locks that
plagues current implementations.
There is still a lot left to do here, so I am mostly looking for feedback
on this move.
Update
Adds temporary JSON storage to implement API and fixes around deleting containers and tasks.

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   59.55%   59.55%
=======================================
  Files           5        5
  Lines         759      759
=======================================
  Hits          452      452
  Misses        199      199
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3b89c...e1ed4a2. Read the comment docs.

LGTM

Oh, ok, makes sense why windows was having issue then.
On Tue, May 23, 2017, 3:03 PM Derek McGowan<EMAIL_ADDRESS>wrote:

@dmcgowan commented on this pull request.
In cmd/ctr/run.go
https://github.com/containerd/containerd/pull/894#discussion_r118117664:

  		return err

  	}
  }

create, err := newCreateRequest(context, id, tmpDir, checkpoint, mounts, spec)

createContainer, err := newCreateContainerRequest(context, id, id, spec)

if err != nil {

	return err

}

_, err = containers.Create(ctx, createContainer)

Its down there on line 299, only called if --rm is given, otherwise ctr
delete must be used
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/containerd/containerd/pull/894#discussion_r118117664,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APUifhgEQtPT9isxgNDhfTMPvyxkstyFks5r81elgaJpZM4NkTnS
.

--
Sent from my phone.


put breadcrumbs on their own row

fixes https://github.com/Microsoft/vscode/issues/63764
@jrieken the reason for the layout and scrollbar issues seems to originate from the fact that the breadcrumbs - even though they are always on a second row below tabs - where put in the same parent as the tabs and editor actions. This change puts tabs and actions into their own container so that breadcrumbs can appear below without the crazy flex wrap that we currently have (e.g. it will now appear as 2 rows normally one div after the other).
You can easily see why breadcrumbs currently flicker by changing their width to a small value, e.g. 200px:

We have set the size on the breadcrumb only after a delay, so it was briefly appearing in that corner (explains https://github.com/Microsoft/vscode/issues/63353).
Is there any reason for this flex-wrap?
My change removes some CSS properties that I think you added as part of the breadcrumb work because the .editor-group-view > .title no longer needs display:flex

Is there any reason for this flex-wrap?

Yeah, if I remember correctly that was done the no tabs case - things need to align nicely within a single row. That's broken for wide breadcrumbs with that change:

@jrieken good catch, I fixed that case by using display: flex if tabs are disabled.


Ensure nested event handlers work correctly

If element A contains element B, and they both declare (say) an onclick handler, and the user clicks on B, then you'd expect both event handlers to run.
Currently they do both try to run (first B, then A, as the event bubbles up), but with a render cycle between them. The render cycle might dispose the handler for A before we try to run it, which would lead to a crash.
We should avoid this issue by capturing the list of all event handler IDs to be invoked, pass them all to .NET atomically, and have it run all the corresponding delegates before any render cycle occurs.

@SteveSandersonMS is this still an issue?

As far as I know, yes.


SSL support

Implement SSL support to connect to redis running behind a stunnel

Support SSL on plain Redis Connections. Connect over sentinal and cluster are excluded because sentinel and cluster provide adresses by a redis-internal registry, external SSL port/address cannot be obtained for now.
Conneciton flags:

SSL true/false
StartTLS true/false
Verify Peer true/false (omit certificate validity/hostname check)

Left todo:

SSL Connection Builder
Tests
Create keys at build (in Makefile)
Conditional tests with -Djavax.net.ssl.trustStore=keystore.jks
Stunnel conf
Setup stunnel in travis/snap-ci build. Should support Mac and *NIX for local build, too

stunnel.conf
cert = cert.pem
key = key.pem
capath = cert.pem
delay = yes
foreground = false

[redis]
accept = <IP_ADDRESS>:6443
connect = <IP_ADDRESS>:6479

Gen key/Import key to JKS
openssl genrsa -out key.pem 4096
openssl req -new -x509 -key key.pem -out cert.pem -days 1826 -subject "/O=lettuce/ST=Some-State/C=DE/CN=lettuce-test"
keytool -importcert -keystore keystore.jks -file stunnel/cert.pem -noprompt -storepass changeit

SSL Pseudo-Code
sslContext with InsecureTrustManagerFactory if verify == false
SSLEngine sslEngine = sslCtx.newEngine(ch.alloc(), isa.getHostString(), isa.getPort());
if(verify){
SSLParameters sslParams = new SSLParameters();
sslParams.setEndpointIdentificationAlgorithm("HTTPS");
sslEngine.setSSLParameters(sslParams);
}

@kichik Pushed some SSL changes towards branch issue-28-ssl-support. Do you want to sneek peek?

Build support done, connect waits for successful handshake. Still thinking about reconnect. A disconnect will lead to a reconnect, but if the remote peer will not validate against SSL rules (e. g. peer verification) this will end up in a endless loop. URI parser and docs need update too.

Thanks. I can help you test if you want, but I don't think I will use this in production. I do think it's super useful and should be merged to master, but we just have a few extra requirements that are already satisfied with the current solution. That said, I think access to SSLParams would provide even more flexibility.

Thanks for your offer, would be great having someone else testing. SSL provides lots of fancy stuff (allowed ciphers, client certs and many more). I'd release the first version with basic SSL support, and I'm thinking on something that allows flexibility without adding unneccessary complexity.

SSL support implemented


Added fix for Submit date format for (mm-dd-yyyy and dd-mm-yyyy) format dates

Hi Chris , this is a very good plugin. I have added few more enhancement for some date formats. Please Review those changes and reply me if these are fine on :-<EMAIL_ADDRESS>

Closed as this is no longer relevant (see 2a7dfe780b)


Feature request: compression

I'd like to gzip my events before sending them to S3 because $$$

we now support compression with both brotli and gzip


fluentd: Read logs from docker containers

Read logs from docker containers if docker is enabled in values.yaml. See #93 for more details.

Hi @giner
I have removed use_docker variable. It works for containerd. We don't have a proper working environment with Docker yet. Could you please verify it on your environment?

Fixed by https://github.com/cloudfoundry-incubator/eirini-release/commit/64d954e41b908588883acd48bf65eb3d778949ac

@alex-slynko deployed the develop branch, I can see logs now.


Cleartext HTTP traffic to <IP_ADDRESS> not permitted

Hi,
I created brand new Flutter project, copied and pasted your code there added my server URL and hub name and got the following error
Cleartext HTTP traffic to <IP_ADDRESS> not permitted
The Server URL points to SignalR server which works good with other packages (therefore, that one is not a problem). Please see the attached screenshot. I tried many thing to resolve this problem and I was just getting other errors. Please help.

@misici234 you are trying to connect with an HTTP url instead of HTTPS. I will recommend you to move your url to HTTPS.
But if you absolutely need to connect with a HTTP url, then you need to add the following lines in the manifest of your android source.
<application android:usesCleartextTraffic="true">
    </application>

This is because of Network Security Config, which says,

Starting with Android 9 (API level 28), cleartext support is disabled by default.

If you need more helps on this, read this Stackoverflow Thread.


chore: pr-release: more robust comment id recognition

this didn’t recognize the new comments with an intro, and thus the bot
would post multiple comments.
The code was also out of sync with mathlib, fixing.
The first(…) in the jq program makes it more robust in case this
went wrong once (as on #3171) and there are now multiple PRs matching.

Ok, seems to be working on #3171.

Corresponding mathlib PR: https://github.com/leanprover-community/mathlib4/pull/9698


Counter

Thanks for the PR, but the point of this example is to keep it simple and not use extraneous libraries. It's an intro to Redux.


Fix issues related to hr tags

Ensure that start/end tag handler does not include tags in the previous
paragraph.
Provide special handling for tags like hr that never have content.

Needs tests and is a work in progress. Mainly something that can be discussed.

I've added tests. For cases with ending
 tags, I'm not overly concerned with the unexpected behavior. One should never use ending
 tags. I was examining browser behavior, and they seem to ignore them.
 and
 should get treated in a sane manner though.

This took me longer than I planned. A second set of eyes to double check I'm not missing something may be good. Let me know if there are any test cases I'm missing.
Hopefully, the approach is fine. It took me a bit to massage it into a state where I was able to handle our failing cases, but not break other cases.


get following or get follower not working

Issue Template
Please use this template!
Initial Check

If the issue is a request please specify that it is a request in the title (Example: [REQUEST] more features). If this is a question regarding 'twint' please specify that it's a question in the title (Example: [QUESTION] What is x?). Please only submit issues related to 'twint'. Thanks.

Make sure you've checked the following:

[] Python version is 3.6;
[] Updated Twint with pip3 install --user --upgrade -e git+https://github.com/twintproject/twint.git@origin/master#egg=twint;
[] I have searched the issues and there are no duplicates of this issue/question/request.

Command Ran

Please provide the exact command ran including the username/search/code so I may reproduce the issue.

Description of Issue

Please use as much detail as possible.

seems the API keeps returing HTTP status code 401.
Environment Details

Using Windows, Linux? What OS version? Running this in Anaconda? Jupyter Notebook? Terminal?

Using this code below, (and with the patch in #1034 which prevents a zero index error), I get a null return, ie no Friends (Followings). No friends of users (ie people those users follow) are returned for any users. The same happens if I use twint.run.Followers(c)
c = twint.Config()
c.Username = 'realdonaldtrump'
c.Store_object = True
c.Store_object_users_list = []
c.User_full = True
twint.run.Following(c)
sys.exit()

Output: nothing (no error, but no output)

I think that twitter has changed the access to following/followers. Now you need to be logged in to be able to see them. If you open an incognito window and try to see the followers of someone it pops pup a login window.

@joancf is right. Now there's a popup window every time you try to open followers/following without login. @pielco11 any potential way around that you can think of?

@joancf  @harismuneer  check this I'll do a release soon to be able to retrieve followers and followings for a given user.

@Altimis
How are you able to scrape followers/following without auth?

The api v1.1 for friends/followers still works.
They will probably be deprecated soon.

Those v1.1 api works without auth?

I think that the solution comes from twint to use a user/password and log in before scrapping,
Of course, this allows twitter to block accounts with too much activity (now it can only block an IP)
So if you have an account with many followers maybe is a bit risky to use it for scraping. (i would suggest to create a dummy account)

I don't remember where exactly, but there have been a discussion on this topic previously. It was decided that providing auth scraping is dangerous and should not be implemented.
Because it can lead the naive users' accounts to get banned, not all of them are familiar with the rate limit thing.

As promised : see. I hope It could meet your need.

As promised : see. I hope It could meet your need.

great work 👍🏽
although a word of caution for everyone who is gonna be using the above fix.
Try to create a new twitter account if you are gonna be using it for scraping a large number of followers, as it might get you account banned. Just to be safe, create an account which you won't mind in case your account gets suspended.

As promised : see. I hope It could meet your need.

great work 👍🏽
although a word of caution for everyone who is gonna be using the above fix.
Try to create a new twitter account if you are gonna be using it for scraping a large number of followers, as it might get you account banned. Just to be safe, create an account which you won't mind in case your account gets suspended.

Yes Indeed, I mentioned this in Readme.


Use ISample in DrawableSample

Just PRing for visibility; don't merge without further discussion.

This change is also sort of breaking, but I see no reason to not do it. Seems like a naturally flowing conclusion that a DrawableSample should be an ISample.

The only weird scenario is you can have DrawableSample be an ctor param? I suppose that's not a big deal...


directional_bcs

Alterations:

Allow directions 'x', 'y' and 'both' (both being default) to be specified for each boundary condition in 2D problems. In 1D, it will default by being the only horizontal component.
Made tests to test default solid walls on direction not specified and to check we can specify each direction
Tidy up of some assertions and arguments in flux.py that didn't need to be there. E.g. flux.py now takes just BoundaryCondition objects.

in response to issue #16


Add modifiedTime to participant project species

Add modifiedTime to project species entity
Add modified time
Put modifiedTime back into tests

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1946  👈
#1945
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


WIP: Persistent storage proposal

Breaking up #4055 into smaller PRs for focused discussion.
Subsequent PRs will be for the API and implementation (volume manager and plugin).
@thockin @bgrant0607 @smarterclayton @pmorie

This is very clear - thank you for taking the time to split it out from #4055.
I'm not sure it makes sense to punt on the dynamic creation issue - that seems like it will be a very common use case (AWS, GCE, OpenStack, SANs).  What is the plan here?  I can see two options:

The cloud provider dynamically creates a volume when one is claimed.  (And if so, how does the client know that a volume will magically appear on-demand so it doesn't block the request because it sees there are no volumes available?)
the caller creates a volume (with an API call) before creating their claim.

I think a worked example of launching a pod with a volume in this scenario would clear up my confusion here!

We're not punting on dynamic provisioning, just putting the API in place first for Persistent Volumes.  The horse goes before the cart.
Our experience with Open Shift is that creating and formatting a volume on the fly is slow.  Better to have a pool of readily available volumes to mount, at least at the present time.  As that process gets better, though, the time between "create" and "consume" will decrease, possibly enough to allow on the fly creation.
The dynamic provisioning of volumes is not yet specified.

I expect dynamic provisioning will come soon after this is all integrated.  I think THIS is a 1.0 blocker, but dynamic is probably not.

@thockin agreed because an admin can script the creation of the volumes.  dynamic provisioning eases their pain.

Can you clarify if a PersistentVolume drives Events in the system?  If so, can we assert that any events it spawns will be treated consistent with Node objects.  Meaning they will go in the cluster-id namespace?

And because I was bit by this before, why did we merge a PR that was WIP?

I forgot to edit the subject, but you have good feedback.  Mark can get
that feedback wrapped up as a new PR :)
On Fri, Mar 6, 2015 at 4:55 PM, Derek Carr<EMAIL_ADDRESS>wrote:

And because I was bit by this before, why did we merge a PR that was WIP?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/5096#issuecomment-77663180
.


cis-v1.23-t1.0.1 controls - move scope from cloud to cluster

PR Type:
Refactoring

PR Description:
This PR addresses the issue of changing the scanning scope from 'cloud' to 'cluster' in various CIS controls. This change is reflected in multiple JSON files under the 'controls' directory. The change is aimed at enhancing the accuracy and relevance of the scanning process.

PR Main Files Walkthrough:
 files:
controls/C-0188-minimizeaccesstocreatepods.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0186-minimizeaccesstosecrets.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0146-ensurethatthecontrollermanageruseserviceaccountcredentialsargumentissettotrue.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0123-ensurethattheadmissioncontrolpluginalwayspullimagesisset.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0209-createadministrativeboundariesbetweenresourcesusingnamespaces.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0158-ensurethatthepeerautotlsargumentisnotsettotrue.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0157-ensurethatthepeerclientcertauthargumentissettotrue.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0191-limituseofthebindimpersonateandescalatepermissionsinthekubernetescluster.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0156-ensurethatthepeercertfileandpeerkeyfileargumentsaresetasappropriate.json: Changed the scanning scope from 'cloud' to 'cluster'.
controls/C-0175-verifythatthereadonlyportargumentissetto0.json: Changed the scanning scope from 'cloud' to 'cluster'.

User Description:
https://github.com/kubescape/kubescape/issues/1420

@rcohencyberarmor most of these are relevant for files as well

@YiscahLevySilas1 which of those are relevant for files?

@YiscahLevySilas1 which of those are relevant for files?

controls that use only k8s resources are applicable for files as well, controls that use host scanner resources are not (rules that use apigroup "hostdata.kubescape.cloud")


sir pls add playlist by endpoint like 5bvTNvwNiHFuOxiEGmm6lQ__

sir pls add playlist by endpoint like 5bvTNvwNiHFuOxiEGmm6lQ__ this instead of id cause couldn't find id of the playlist

This is implemented now - https://saavn.dev/docs#tag/playlist/get/api/playlists


Add ability to have prefix icon with select form element (dropdown)

Per issue #2459

Any update on merging this?

The only problem that I can her is that you have commited compiled files. Check out our contributing guidelines for information :)


Bug: findDOMNode is deprecated in StrictMode

Description of Problem
Unable to get Viewer App started due to error in the console:

Error Code
 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of HeaderRow which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
at div
at t (http://localhost:3000/static/js/vendors~main.chunk.js:517983:89125)
at div
at t (http://localhost:3000/static/js/vendors~main.chunk.js:517983:83671)
at div
at t (http://localhost:3000/static/js/vendors~main.chunk.js:517983:76743)
at div
at div
at t (http://localhost:3000/static/js/vendors~main.chunk.js:517983:57330)
at ElementResizeObserver (http://localhost:3000/static/js/vendors~main.chunk.js:352917:34)
at div
at Table (http://localhost:3000/static/js/vendors~main.chunk.js:95475:9)
at div
at div
at ElementList (http://localhost:3000/static/js/vendors~main.chunk.js:422371:24)
at div
at div
at div
at MultiElementPropertyGrid (http://localhost:3000/static/js/vendors~main.chunk.js:422657:114)
at div
at ScrollableWidgetContent (http://localhost:3000/static/js/vendors~main.chunk.js:23773:72)
at WidgetContent (http://localhost:3000/static/js/vendors~main.chunk.js:69546:20)
at WidgetContentRenderer (http://localhost:3000/static/js/vendors~main.chunk.js:24132:82)
at WidgetContentRenderers (http://localhost:3000/static/js/vendors~main.chunk.js:24119:75)
at div
at WidgetPanelsComponent (http://localhost:3000/static/js/vendors~main.chunk.js:23558:69)
at WidgetPanels (http://localhost:3000/static/js/vendors~main.chunk.js:23552:109)
at WidgetInternals (http://localhost:3000/static/js/vendors~main.chunk.js:69678:133)
at WidgetPanelsFrontstageComponent
at WidgetContentManager (http://localhost:3000/static/js/vendors~main.chunk.js:24054:87)
at CursorTypeProvider (http://localhost:3000/static/js/vendors~main.chunk.js:11285:72)
at DraggedResizeHandleProvider (http://localhost:3000/static/js/vendors~main.chunk.js:10865:19)
at DraggedPanelSideProvider (http://localhost:3000/static/js/vendors~main.chunk.js:10861:27)
at DraggedWidgetIdProvider (http://localhost:3000/static/js/vendors~main.chunk.js:10857:21)
at DragProvider (http://localhost:3000/static/js/vendors~main.chunk.js:10832:69)
at NineZoneProvider (http://localhost:3000/static/js/vendors~main.chunk.js:11205:106)
at NineZone (http://localhost:3000/static/js/vendors~main.chunk.js:11192:13)
at div
at ActiveFrontstageDefProvider (http://localhost:3000/static/js/vendors~main.chunk.js:69816:40)
at WidgetPanelsFrontstage (http://localhost:3000/static/js/vendors~main.chunk.js:69798:112)
at main
at ConfigurableUiContent (http://localhost:3000/static/js/vendors~main.chunk.js:39810:108)
at FrameworkVersion (http://localhost:3000/static/js/vendors~main.chunk.js:48691:86)
at ThemeProvider (http://localhost:3000/static/js/vendors~main.chunk.js:393848:23)
at div
at ThemeManagerComponent (http://localhost:3000/static/js/vendors~main.chunk.js:64240:9)
at ConnectFunction (http://localhost:3000/static/js/vendors~main.chunk.js:552838:75)
at IModelViewer (http://localhost:3000/static/js/vendors~main.chunk.js:428932:25)
at Provider (http://localhost:3000/static/js/vendors~main.chunk.js:552543:20)
at div
at http://localhost:3000/static/js/vendors~main.chunk.js:428716:69
at IModelLoader (http://localhost:3000/static/js/vendors~main.chunk.js:428809:15)
at ErrorBoundary (http://localhost:3000/static/js/vendors~main.chunk.js:354037:9)
at BaseViewer (http://localhost:3000/static/js/vendors~main.chunk.js:428155:23)
at Viewer (http://localhost:3000/static/js/vendors~main.chunk.js:431180:80)
at div
at App (http://localhost:3000/static/js/main.chunk.js:182:89)

So the warning you're seeing is something we will need to fix. But i don't think its actually what's throwing the error that you're seeing in the viewer.
Can you check your compatibility with iTwin.js here ?
Are you using a test model from Bentley or is this one of your own?
Have you added any additional code to display decorators or change the graphics?

Can you check your compatibility

atibility with iTwin.js here ?

Are you using a test model from Bentley or is this one of your own?
I'm using one of the Bentley samples (Stadium Project)

Have you added any additional code to display decorators or change the graphics?
No

Let me know what kind of debugging information you need. I'll be glad to help.

Please provide more details like your:

OS
Browser (and version number)
iTwin.js Version

Hi @aruniverse
See my package.json configuration:
{
"name": "hdb-tender",
"version": "0.1.0",
"private": true,
"dependencies": {
"@bentley/icons-generic": "^1.0.34",
"@bentley/react-scripts": "^4.0.7",
"@itwin/appui-abstract": "^3.2.0",
"@itwin/appui-layout-react": "^3.2.0",
"@itwin/appui-react": "^3.2.0",
"@itwin/browser-authorization": "^0.5.1",
"@itwin/components-react": "^3.2.0",
"@itwin/core-bentley": "^3.2.0",
"@itwin/core-common": "^3.2.0",
"@itwin/core-frontend": "^3.2.0",
"@itwin/core-geometry": "^3.2.0",
"@itwin/core-i18n": "^3.2.0",
"@itwin/core-markup": "^3.2.0",
"@itwin/core-orbitgt": "^3.2.0",
"@itwin/core-quantity": "^3.2.0",
"@itwin/core-react": "^3.2.0",
"@itwin/core-telemetry": "^3.2.0",
"@itwin/imodel-components-react": "^3.2.0",
"@itwin/imodels-access-frontend": "^1.0.1",
"@itwin/imodels-client-management": "^1.0.1",
"@itwin/itwinui-react": "^1.38.1",
"@itwin/presentation-common": "^3.2.0",
"@itwin/presentation-frontend": "^3.2.0",
"@itwin/reality-data-client": "^0.7.2",
"@itwin/web-viewer-react": "^2.0.11",
"@itwin/webgl-compatibility": "^3.2.0",
"@types/history": "^4.7.11",
"@types/node": "^14.18.18",
"@types/react": "^17.0.45",
"@types/react-dom": "^17.0.17",
"history": "^4.10.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-redux": "^7.2.8",
"typescript": "~4.3.0"
},
"scripts": {
"start": "react-scripts --max_old_space_size=4096 start",
"build": "react-scripts --max_old_space_size=4096 build",
"test": "react-scripts --max_old_space_size=4096 test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": [
"last 4 chrome version",
"last 4 firefox version",
"last 4 safari version",
"last 4 ios version",
"last 4 ChromeAndroid version",
"last 4 edge version",
"not dead",
"not <0.2%"
]
}

Thanks for the info @tangytang. This error is most likely the result of your specific graphics card driver having optimized away one of the variables used by a shader program. We compile all of our shaders on Linux, Windows, and macOS without error, but some drivers are smarter about optimizations. We will investigate and fix the shader.


--kubeconfig arg does not seem to override environment setup

Steps to reproduce

Have access to at least two k8s clusters using stern 1.5.0
Run export KUBECONFIG=PATH_TO_FIRST_KUBECONFIG
Run stern --kubeconfig PATH_TO_SECOND_KUBECONFIG --since 1m --namespace=kube-system kube-dns

Expected behaviour
CLI options override environment setup and stern shows logs based on config at PATH_TO_SECOND_KUBECONFIG. i.e. mirror the behaviour of kubectl.
I believe this stern used to do this but I've lost the version I had since I clean up brew. I think it was 1.3.0 or 1.2.0.
Actual behaviour
stern show logs based on environment config at PATH_TO_FIRST_KUBECONFIG

Thanks for this & clear details on what's happening. Looks like there was a regression introduced in https://github.com/wercker/stern/commit/41697a5d72fdea156df74f26b865e242be5faa2c (released in 1.5.0). PR on the way to fix this

The override works correctly (ie --kubeconfig PATH_TO_SECOND_KUBECONFIG) but I'm not sure this is working as when using the default.
KUBECONFIG can be set to multiple config files... not just one, which results in an error like this
$GOPATH/bin/stern --all-namespaces kube-dns -c dnsmasq
failed to get client config: stat /Users/me/.kube/config:/Users/me/.kube/development-env/kube-config:/Users/me/vagrant/kubeconfig.yml: no such file or directory

It seems to me that it should operate similar to kubectl config get-contexts with kubectl config current-context as the default.


[Android] Badge in app icon still display although I overrides the badge option in default channel

I put this code when deviceready is fired
FirebasePlugin.setDefaultChannel({
      id: 'some_default_channel_id',
      name: 'some_default_channel_name',
      badge: false
    }, console.log, console.log);

When run the app, I found the some_default_channel_name in notification setting, but after I push a notification to this device (in background), the Badge number still be shown.
This issue happened on:
Android 10
Cordova 8.0.0
cordova-plugin-firebasex 7.0.2
Samsung and XiaoMi device
Are there any other ways to remove this badge number after receiving a push notification?
Thanks.
Updated: I also pulled this project to my local and build my self (https://github.com/dpa99c/cordova-plugin-firebasex/tree/7.0.2), then I changed these lines of code to force hide badge number
FirebasePlugin.java#L1178
From
channel.setShowBadge(badge);

to
channel.setShowBadge(false);

And add .setNumber(0) to notificationBuilder
FirebasePluginMessagingService.java#L208
But the badge still shows and counts the push notification.

The plugin is setting the badge visibility on Android in the way described in the Android documentation, i.e. calling setShowBadge() when creating a channel.
However, on testing on an Pixel 2 running Android 10, I can confirm that setting channel.setShowBadge(false) in the Java (which is the same as FirebasePlugin.setDefaultChannel({id: 'my_channel', badge: false}) in Javascript) does not cause the notification dot on the homescreen app icon to be hidden, as described in the Android documentation.
Note that when the app is in the background or not running, no app code is executed since the Android OS handles the display of the system notification, so making any changes in FirebasePluginMessagingService.java will have no effect since onMessageReceived() is only called when the app is running in the foreground.
At this point, I have no suggestion as to how the notification dot can be hidden - setShowBadge(false) does not appear to work as described in the Android documentation.
Therefore I'm labelling this issue as a caveat of using the plugin, as opposed to a bug in the plugin code which can be fixed.


[Refactor] Add nodiscard and check status return

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:disappointed: fail : 12 / 30 (40.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/table_function/generate_series.h
0
5
00.00%
[38, 43, 45, 47, 49]

:large_blue_circle:
src/exprs/table_function/table_function.h
0
1
00.00%
[56]

:large_blue_circle:
src/exec/stream/state/mem_state_table.h
0
1
00.00%
[39]

:large_blue_circle:
src/exprs/table_function/list_rowsets.h
0
5
00.00%
[37, 42, 44, 46, 48]

:large_blue_circle:
src/exprs/table_function/multi_unnest.h
0
5
00.00%
[99, 104, 106, 108, 110]

:large_blue_circle:
src/exprs/table_function/json_each.h
4
5
80.00%
[37]

:large_blue_circle:
src/util/timezone_hsscan.h
1
1
100.00%
[]

:large_blue_circle:
src/exprs/table_function/unnest.h
5
5
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.h
2
2
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 23 / 41 (56.10%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/table_function/generate_series.h
0
5
00.00%
[38, 43, 45, 46, 49]

:large_blue_circle:
src/exprs/table_function/table_function.h
0
1
00.00%
[56]

:large_blue_circle:
src/exec/stream/state/mem_state_table.h
0
1
00.00%
[39]

:large_blue_circle:
src/exprs/table_function/list_rowsets.h
0
5
00.00%
[37, 42, 44, 45, 48]

:large_blue_circle:
src/exprs/table_function/multi_unnest.h
0
5
00.00%
[99, 104, 106, 107, 110]

:large_blue_circle:
src/exprs/table_function/json_each.h
4
5
80.00%
[37]

:large_blue_circle:
src/util/timezone_hsscan.h
1
1
100.00%
[]

:large_blue_circle:
src/exprs/table_function/unnest.h
5
5
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.h
2
2
100.00%
[]

:large_blue_circle:
src/exprs/time_functions.cpp
1
1
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.cpp
10
10
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 23 / 41 (56.10%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/table_function/generate_series.h
0
5
00.00%
[38, 43, 45, 46, 49]

:large_blue_circle:
src/exprs/table_function/table_function.h
0
1
00.00%
[56]

:large_blue_circle:
src/exec/stream/state/mem_state_table.h
0
1
00.00%
[39]

:large_blue_circle:
src/exprs/table_function/list_rowsets.h
0
5
00.00%
[37, 42, 44, 45, 48]

:large_blue_circle:
src/exprs/table_function/multi_unnest.h
0
5
00.00%
[99, 104, 106, 107, 110]

:large_blue_circle:
src/exprs/table_function/json_each.h
4
5
80.00%
[37]

:large_blue_circle:
src/util/timezone_hsscan.h
1
1
100.00%
[]

:large_blue_circle:
src/exprs/table_function/unnest.h
5
5
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.h
2
2
100.00%
[]

:large_blue_circle:
src/exprs/time_functions.cpp
1
1
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.cpp
10
10
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 23 / 41 (56.10%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/table_function/generate_series.h
0
5
00.00%
[38, 43, 45, 46, 49]

:large_blue_circle:
src/exprs/table_function/table_function.h
0
1
00.00%
[56]

:large_blue_circle:
src/exec/stream/state/mem_state_table.h
0
1
00.00%
[39]

:large_blue_circle:
src/exprs/table_function/list_rowsets.h
0
5
00.00%
[37, 42, 44, 45, 48]

:large_blue_circle:
src/exprs/table_function/multi_unnest.h
0
5
00.00%
[99, 104, 106, 107, 110]

:large_blue_circle:
src/exprs/table_function/json_each.h
4
5
80.00%
[37]

:large_blue_circle:
src/util/timezone_hsscan.h
1
1
100.00%
[]

:large_blue_circle:
src/exprs/table_function/unnest.h
5
5
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.h
2
2
100.00%
[]

:large_blue_circle:
src/exprs/time_functions.cpp
1
1
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.cpp
10
10
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 29 / 52 (55.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/table_function/generate_series.h
0
5
00.00%
[38, 43, 45, 46, 49]

:large_blue_circle:
src/exprs/table_function/table_function.h
0
1
00.00%
[56]

:large_blue_circle:
src/exec/stream/state/mem_state_table.h
0
1
00.00%
[39]

:large_blue_circle:
src/exprs/table_function/list_rowsets.h
0
5
00.00%
[37, 42, 44, 45, 48]

:large_blue_circle:
src/exprs/table_function/multi_unnest.h
0
5
00.00%
[99, 104, 106, 107, 110]

:large_blue_circle:
src/exec/stream/state/mem_state_table.cpp
6
11
54.55%
[46, 54, 84, 129, 234]

:large_blue_circle:
src/exprs/table_function/json_each.h
4
5
80.00%
[37]

:large_blue_circle:
src/util/timezone_hsscan.h
1
1
100.00%
[]

:large_blue_circle:
src/exprs/table_function/unnest.h
5
5
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.h
2
2
100.00%
[]

:large_blue_circle:
src/exprs/time_functions.cpp
1
1
100.00%
[]

:large_blue_circle:
src/exec/stream/scan/stream_scan_operator.cpp
10
10
100.00%
[]


Organize catalog examples into sub-directories, cleanup (#2963)

Hey, I just made a Pull Request!
This commit organizes the example locations into sub-directories. refactors part of (#2963)
A later commit is going to add an "example" organization of users and
groups. Re-organizing this upfront, is going to make the follow up
commits a little tidier.

@Rugvip Is there anything that I can do to verify those apps will not break?

Not really, I think. You could search around the repo for remaining usages of the old paths but I doubt there are any. Only risk here would be people that are on very old versions of our libs as dependencies, and I don't think you should worry.

Time to make this into a PR?


UStreamingSoundWave and GetPlaybackTime

Hi,
Let me start by thanking you for such a great library!
Now to the question.
I'm using UStreamingSoundWave to play streaming audio. In order to match my automatically generated animations with the sound, I call GetPlaybackTime and set the frame time of my animation. However, there seems to be difference between the playback time that UStreamingSoundWave reports and the sound that is actually played. It results in the animations being played a few hundred miliseconds (or even seconds) earlier than the sound.
This is the stripped down version of my code:
void AMyController::Tick(float DeltaTime)
{
    Super::Tick(DeltaTime);

    FrameTime = SoundWave->GetPlaybackTime();

    Frame = GetFrame(FrameTime);
    SetMotion(Frame->Motion);

    if (GetSound(FrameTime).Num() > 0)
    {
        SoundWave->AppendAudioDataFromEncoded(GetSound(FrameTime), ERuntimeAudioFormat::Mp3);
    }
}

I populate the audio every i.e. 120 frames, and it plays just fine, except for the delay. I assume that's because AppendAudioDataFromEncoded is async and it only adds it sometime later, however I was hoping that GetPlaybackTime would take it into account. Could it be that GetPlaybackTime is reporting it incorrectly? Or am I using it wrong?
It's worth noting that my actual code is a bit more complicated than the sample I provided, so there's a chance there are other things in play. However, I've been meddling with it for a couple of days and can't find anything that can explain the delay.
Thanks in advance!

This is how I create the sound wave, in case you think it's important:

Apparently switching from mp3 to ogg fixes the issue. Not sure why is that, but I guess my issue is resolved.

Hi, thank you for your feedback!
Regarding the issue, when you call AppendAudioDataFromEncoded, the importer takes some time to decode the audio data and update the internal PCM buffer. This, in turn, affects the value returned by GetPlaybackTime. As this process occurs on an asynchronous thread, you need to wait for the PCM buffer to be fully updated before obtaining the new playback time. You can use the delegate OnPopulateAudioDataNative, which is triggered when the append operation is fully complete, to handle this situation more effectively.

Apparently switching from mp3 to ogg fixes the issue. Not sure why is that, but I guess my issue is resolved.

It might be because the mp3 format is decoded faster than the ogg format. But anyway, relying on decoding speed is not a reliable solution, I recommend redesigning your implementation to use the OnPopulateAudioData delegate or somehow else.

Thanks, I'll try that as well.


Auto adjustable Field width in Grid

Hi,
can anyone please help me to adjust the field's width in XYZGrid according to the longest text in the overall grid?

@volkanceylan Can you please suggest some solution to this?

See this https://github.com/Estrusco/Serenity.Extra or ask to @dfaruque

Hi @dfaruque,
Can you please help me on this?

Please read the readme at https://github.com/dfaruque/Serenity.Extra
Currently, it auto-sizes columns according to their header text

Hi @dfaruque,
By using Serenity-Extra we have to specify the width of the particular column right?
I need to adjust the width automatically (dynamically) with respect to the longest text in that field.
Is that possible?

no.
it adjusts the width automatically (dynamically) with respect to the header text in that field.

okay. Thanks for your clarification.
Closing this issue.


[FEATURE REQUEST] make the underlying pino instance accessible

Is your feature request related to a problem? Please describe.
The underlying pino instance is private.
Describe the solution you'd like
Make it public or at least protected such that one could access it with the certainty that a minor/patch version update of this package does not remove/rename the getter.
Describe alternatives you've considered
Creating a separate pino instance to pass down to the parts of the system that need a Logger would be an alternative. This would make it quite a lot more complicated though.
Additional context
Some of the business logic in our projects is generic in a way that it does not know about NestJS specifics, but knows about pino (especially its child() method). These are given a pino logger from the NestJS specific parts (e.g. controllers). If we do not use the private getter that is linked above, we would need to maintain a separate second pino instance, hence, not gaining anything from using such a sweet package as nestjs-pino.

Hi, feel free to open pr for this. I think this will solve #404 too

Thanks. I have created a PR.


Update README.md

Adding IBM Cloud Projects to the list of SDKs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@knee-na thanks for adding this. Will you sign the CLA agreement for the OS contribution? Once that's done, I'll merge this in

@dpopp07 @padamstx done!


ROX-18250: Listen for Mirroring CRs

Description
Introduces the foundation for listening to the registry mirroring CRs - ImageContentSourcePolicy, ImageDigestMirrorSet, and ImageTagMirrorSet.
The CR contents are informational in this PR, processing the CRs will be introduced later (as indicated by the TODOs in sensor/kubernetes/listener/resources/registrymirrorsets.go)
Parent Epic - ROX-11347
Checklist

[x] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~
[x] ~Evaluated and added CHANGELOG entry if required~
[x] ~Determined and documented upgrade steps~
[x] ~Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

No user facing changes (yet).
Testing Performed
On OCP 4.x cluster:

Verified via logs that informers are initialized
Verified when creating and deleting an ICSP, IDMS, or ITMS the CR contents are logged via the the dispatcher.
Verified with environment variable ROX_REGISTRY_MIRRORING_ENABLED set to false the initializing messages and CR contents are no longer logged.

kubernetes/listener: 2023/07/27 21:39:16.056900 resource_event_handler.go:149: Info: Initializing "clusteroperators" informer
kubernetes/listener: 2023/07/27 21:39:16.057003 resource_event_handler.go:154: Info: Initializing "imagedigestmirrorsets" informer
kubernetes/listener: 2023/07/27 21:39:16.057040 resource_event_handler.go:159: Info: Initializing "imagetagmirrorsets" informer
kubernetes/listener: 2023/07/27 21:39:16.059266 resource_event_handler.go:173: Info: Initializing "imagecontentsourcepolicies" informer
kubernetes/listener/resources: 2023/07/27 21:52:40.960668 registrymirrors.go:33: Debug: Received registry mirror ImageContentSourcePolicy event [CREATE_RESOURCE]: &v1alpha1.ImageContentSourcePolicy{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"ubi8repo", GenerateName:"", Namespace:"", SelfLink:"", UID:"bfa1d1d2-3093-4c43-a65d-117682a11a9a", ResourceVersion:"224489", Generation:1, CreationTimestamp:time.Date(2023, time.July, 27, 21, 52, 40, 0, time.Local), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{}, OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:v1alpha1.ImageContentSourcePolicySpec{RepositoryDigestMirrors:[]v1alpha1.RepositoryDigestMirrors{v1alpha1.RepositoryDigestMirrors{Source:"registry.access.redhat.com/ubi8/ubi-minimal", Mirrors:[]string{"example.io/example/ubi-minimal"}}, v1alpha1.RepositoryDigestMirrors{Source:"registry.access.redhat.com/ubi8/ubi-minimal", Mirrors:[]string{"example.com/example/ubi-minimal"}}}}}

On OCP 3.x cluster

Verified that sensor works and does not break / panic / etc. with the new listeners active.

PR Stack

https://github.com/stackrox/stackrox/pull/7213
This PR - https://github.com/stackrox/stackrox/pull/7149
https://github.com/stackrox/stackrox/pull/7016

/retest

/test gke-nongroovy-e2e-tests


Fixed broken Sample Widget  and Readme update

Issue:
ZkEVM Send Transaction widget was not linked from the sample Widget

Hey @nattb8 I had merge conflicts after your PR is merged into main for following 2 assets

MainMenu.asset
Gameoverscreen.uasset

I compared manually and added your only change as below for both assets, please confirm it is correct and is the only change made?


Is it OK that depositStake does not return the transaction hash?

Yes it is OK, because Bee does not support it 🤪 That said I was notified that this might change in close future, so lets 🤞


Add support for interfaces instead of concrete implementations

This actually won't work because currently, CakePHP behaviors are scoped to Table classes, not RepositoryInterface.

Coverage decreased (-45.8%) to 54.245% when pulling 6baccb6df6e506f4ec49a7c5f49427994a96fb40 on interface-support into d1237269e13146679bac4daa066f6e311c45f243 on master.


Unit testing needed

This app should work with Python 2.7+ and Django 1.7+. Tests in TravisCI needed.

I will close this issue as TravisCI tests were done. And created another issue #9 for Python 3+ compatibility.


tools for converting breakdancer output into iAnnotateSV

Is there any tools to convert the output of breakdancer into iAnnotateSV? The 3,6 columns of breakdancer are strings that record the number of reads mapped to the plus (+) or the minus (-) strand in the anchoring regions. How should I determine the orientation?

Nope, currently not we do have conversion script that works for BreakDancer.
We do have on that will work with Delly version 0.7.5. You can find that here in iCallSV
From what I see is the breakdancer output is the same number of reads on both breakpoints would determine the orientation. If this is the output of breakdance:
Example 1: 1 10000 10+0- 2 20000 7+10- CTX -296 99 10 tB|10 1.00 BreakDancerMax-0.0.1 t1
Then for breakpoint 1 it would be (+) which you can convert to 0 for iAnnotateSV and for breakpoint 2 it would be (-) which you can convert to 1 for iAnnotateSV

Hope that helps.
If this works, I will be happy to add that as utilities for conversion if you would like to do a PR for it.


chore: suggested simplification proposal

@mega5800 Doesn't this implement the same logic in the extract command? If so lets use this logic as it is simpler and far easier to understand.

If this is indeed the same logic, you can just merge this into your master and it should update the PR you're sending back to the main repo


module name bibapi_v2 - file missing in repo?

It looks like the file bibformat.py imports bibapi_v2 module which does not exist in repo...
When attempting to rename the bibapi.py file, it appears to still work when "reticulating" (see https://github.com/KTH-Library/kthcorpus/blob/main/data-raw/reticulate_kthb.R)...

This should be fixed now
https://github.com/KTH-Library/bibliutils/commit/e655b190f24d347449d09851185d9f4f8c59791d


YARN-11147. ResourceUsage and QueueCapacities classes provide node la…

…bel iterators that are not thread safe

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 27s

trunk passed

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 22s

trunk passed

+1 :green_heart:
shadedclient
24m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 45s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 69 unchanged - 2 fixed = 69 total (was 71)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  4s

the patch passed

+1 :green_heart:
shadedclient
23m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 20s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

210m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4301/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4301

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 54c4d3c8a8ea 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 13b39374d9d2a88cd9360af9d799062e8dd52a56

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4301/1/testReport/

Max. process+thread count
871 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4301/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @9uapaw for working on this.
Patch LGTM, +1.

Thanks @9uapaw for the patch, and @szilard-nemeth for the review. Committed to trunk.


add compare.go to facilitate smarter parser_test diffing

this should help when making more test cases
Bug: 34671474
Test: m -j nothing # which runs unit tests
Change-Id: Iff6197ac64053fde33119bbf59885c714b27c91f

Essentially the same as the original patch from the remove-pos pull request: https://github.com/google/blueprint/pull/145/commits/aeac445b620f4143eef01d0789ed05118d675d6b


Speed up TorsionDriveResultCollection.to_records by batching requests

Description
These changes make the following code run in ~16 seconds instead of ~65 seconds on my computer by sending lists of record IDs to QCPortal instead of single records at a time. This should be safe to do because all three of PortalClient.get_torsiondrives, PortalClient.get_optimizations, and PortalClient.get_molecules state that they return their results in the same order as the given IDs. [1][2][3]
I also used the include kwarg on get_torsiondrives, which is supposed to pre-fetch those parts of the record instead of fetching them later when the properties are accessed, but because _handle_includes appears to handle these on a per-record basis, this probably doesn't help the performance.
Profiling code:
import cProfile
from pstats import SortKey

from qcportal import PortalClient

from openff.qcsubmit.results import TorsionDriveResultCollection

pr = cProfile.Profile()

with cProfile.Profile() as pr:
    client = PortalClient("https://api.qcarchive.molssi.org:443/")
    ds = "OpenFF Torsion Coverage Supplement v1.0"
    td = TorsionDriveResultCollection.from_server(client, ds)
    records = td.to_records()
    pr.print_stats(SortKey.CUMULATIVE)

assert len(records) == 40

Todos

[x] TorsionDriveResultCollection
[ ] OptimizationResultCollection

Status

[ ] Ready to go

Just to comment on the speed, my laptop is clearly not as nice as your computer but I'm also seeing ~4x speedup: 260 seconds in main and 53 seconds in this branch. 🎉

because _handle_includes appears to handle these on a per-record basis, this probably doesn't help the performance.

The fix for that is coming in a future PR! So go ahead and use include and in the future it should be even faster

This is promising - I added a ticket for this on our Trello before I saw you hadn't checked some of the boxes in the description. Apologies for the false start @ntBre, let me know when this is ready for review!

@j-wags I should have just looked at this yesterday! The OptimizationResultCollection already had very similar code to what I added for the torsion drives. I just added final_molecule to the include part for the future. This should be ready for review!

Excellent. Looking at this with fresh eyes, since this touches some business logic there's a chance that the already-failing psi4 tests could mask a problem here. I'm going to look into those real fast but if I can't resolve them quickly I'll give this PR the benefit of the doubt and review today.

Sounds good! I should also mention that I added this code to the bottom of the profiling script above:
with open("got.dat", "w") as out:
    for r, m in records:
        print(r.id, m.to_smiles(), file=out)

and confirmed that it was the same before and after the changes, in addition to the assert that was already there. I can try to add this as a real test, but I wasn't sure if we wanted to be making real requests in the tests. Matt said on slack that this functionality should be covered (somehow) by existing tests anyway, but it could overlap with the Psi4 tests, as you said.

@j-wags Release notes updated, feel free to merge this if they look good to you!


Automatically add Jira issue key prefix and link to pull requests (OSOE-425)

In the validate-pull-request workflow, implement automation to prefix a newly opened PR's title with the corresponding Jira issue key, as well as add a link to the issue into the PR's description, if these are not there already. The issue key can be determined from the branch name.
Don't do anything if the branch name doesn't match an issue key pattern (like for community contributions).
In all OSOCE submodules, change verify-submodule-pull-request workflows to validate-pull-request. These should include a call to a new, validate-submodule-pull-request reusable workflow, that runs both the submodule verification and the issue key insertion. The validate-this-pull-request workflow should be adapated.

Jira issue

There is some black magic that already puts the link into the issue key in the description, is this action intended to replace that too?

For this purpose, yes. That's a GitHub feature the replaces issue keys anywhere with links pointing to issues. That'll remain, but this feature should insert a link nevertheless and not rely on the automatic replacement.

If out of habit someone provides the key in the description, what should happen?

If the issue key is present in the PR title or in the description then this feature should just leave them and don't duplicate (note that it can be that the PR title has an issue key but the description doesn't and vice versa; the missing issue key should still be added).

Oh yeah, this should work together with submodule verification, so the latter only runs once the PR got an issue prefix, if available.

What happens to the check-merge-conflict workflow? That's currently the validate-pull-request workflow itself, should it be included in the new one so: Prefix, Parent, Merge Conflict would be in it.
What happens in OSOCE? Currently the only the Merge conflict check runs there. Should that be expanded with Prefix checking? Because reusing the new workflow doesn't make sense since checking for Parent PR there doesn't make sense.

Add it as first step before the check-merge-conflict one. Note that unlike check-merge-conflict, this shouldn't run on any push.
If you mean the OSOE superproject then the same (it doesn't use submodule verification). For submodules, see the third point in the issue description.

As elaborated in the third point of the issue, yes, we won't need a separate verify-submodule-pull-request workflow. However, the verify-submodule-pull-request action still needs to be called from the new workflow, because its point is not about validating the PR title format, but checking the existence of a superproject PR. This functionality should remain but the action indeed needs to be modified not to fail when the PR title doesn't contain an issue key, but then just ignore it.

I'm talking about merging the two actions, moving "Superproject PR existence check" to the "Prefix PR" action, since it already knows about the new title, and can just as easily perform the check.

Keep in mind that we need PR title prefixing in standalone repos and superprojects (like OSOCE) too, not just submodules.

During the review process you requested to change how I get the title, body and PR number. However in the current version, this only works if the workflow was triggered by a pull_request and does not work on push which is used by the non-submodule version of the validation workflow.
The easiest solution would be separating this action from the Check Merge Conflict action (which is the one utilizing push)
Can you confirm please?

You can check for github.event.pull_request being empty; if it is, then it's not a PR, and you can leave out the PR-specific things (create-jira-issues-for-community-activities does this too).
Putting merge conflict checks into their separate workflow would definitely be cleaner. However, there's a practical issue with running tiny pieces of automation with GHA: Every workflow run provisions a new VM, and if done in private repos, is billed by the minute. So, it would be wasteful to split these (we can actually have a lot more checks in this workflow in the future even just to reach a minute of runtime).

I see, I'll check it out, thanks!


Show last update of different data sources

It would be nice to have a page that shows when the different data sources were last updated.

For RIRstats and BGP we currently don't track this, but not too hard to record it in the database.
For IRRd we might be able to get enough from !J queries. That may only be "last time this database sent us an update" vs "last time we checked for updates" but for users that probably is fine as long as it's clear.
Needs clear communication, e.g. for RIRstats we can know when we last imported it, but when the file was last generated by the RIR is more complex. Maybe we can offer links to the files we use.

This status page should be linked from the FAQ with an additional explanation in the FAQ on how data is gathered and that data is not realtime.


Notebook PySpark kernel fails to authenticate

Don't have a consistent repro, but it seems to happen when you launch a notebook from a disconnected node. From what I saw the call to getCredentials wasn't returning with anything sometimes and thus we didn't have a password to fill in.

I've been testing this as part of testing, and can no longer repro this behavior when running a spark kernel on first run. As a result, closing this.


Allowing crowdsale to have multiple stages that are limited by weiRaised

Allowing Crowdsale to have multiple stages that are limited by weiRaised

Fixes #
🚀 Description

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

I've create CapStagedCrowdsale contract which allows multiple stages which are limited by weiRaised and each stage has it's own rate.

Thanks for your PR! I've added some comments to make the code more standardized with the rest of openzeppelin.

I've just noticed the isActive thing is only used for setting up stages after construction: I'd remove this altogether if that's the case, since there's no need to have it.

(please mention me when you'd like another review)

@shrugs, when you'll have time, i would appreciate if you can make another review.

@tadejoremuz can you merge master or rebase this branch on master? there are some commits that are duplicated (like changing the author of package.json) that make it hard ton know what's part of this  PR

the latest commit, https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1072/commits/9d17a1dd2a77b879d7da7caabdef81ceba0e1479 should be reverted since it adds the DS_Store, a mac-os specific file that you should generally avoid putting in version control :)
giving the code a review now

We're currently super busy getting OZ v2.0 out the door, but we'll be taking a look at this branch early next week. thanks for your patience!

Hello @tadejoremuz and sorry. I said I was going to review this last week but completely forgot about it. I will review it this week, though.

Thanks a lot for your contribution @tadejoremuz. Let me first say I'm sorry, because we have been focusing on the 2.0 release so much that we had to drop any other work that would delay it. And second let me say sorry again, because many of the changes for 2.0 will cause conflicts with this branch, and we have changed a few style guidelines that will require changes here too. We can give you a hand with these.
Now, I get the feeling that this is a crowdsale for a case that's a lot more specific than the ones we have in the repo. Our goal is to make a framework with building blocks, and let people connect and extend those blocks on their specific projects. With that in mind, I have two proposals: move it to the examples directory as a nice demonstration of how a capped crowdsale can be extended; or move it to the nursery (which is a concept that we are still trying to define, but anyway...) with the idea to give it to the community to test and to provide feedback before making them part of the framework. What do you think about this @tadejoremuz @nventuro @shrugs @frangio?
What I would like to see is some encapsulation of a linear increase, like the one we have on TimedCrowdSale, and another for a staged increase like the one you are proposing here. And that we can combine that function with with either time or wei raised, for 4 possible combinations. Then this could be extended for fancier curves, like the one in #827. I know this is a lot to ask, specially taking into account the limitations of solidity, gas costs, and that the ethereum community doesn't seem to agree if the rate should be set on the token or on the crowdsale. But well, we are starting a new development cycle, we can dream big.
I know it must be tiring for you to keep the PR open for such a long time, and deal with our slow feedback in stages (:man_facepalming: see what I did there? Bad joke, I'm sorry(x3)). I'm available on our slack channel if you would like to have a chat. This is some nice code and a nice idea, so we hope to keep you as a contributor for new PRs :)


Remove hard-coding of RAPIDS version

Read cucim.__version__ in docs build
Remove update from ci/release/update-version.sh

Issue: https://github.com/rapidsai/build-planning/issues/15

/merge


Backbone.Form.Field doesn't pass schema.type to the template

Form.Field's templateData() doesn't pass the schema type through, which i think it should.
this means that you can't make the field template react even a little to the schema type. this is a pretty important  capability, especially when you want to create layouts that for bootstrap3 (which has fairly specific needs for the dom structure).

This is something we've come across in our usage, think we should consider, should be fairly easy.

/me Quietly removes foot from mouth...


Converting networking to ASIO

Before I go spend a lot of time on this, would you appreciate it if I rewrote the network socket calls in ASIO? It would minimize the need for #ifdef's for the networking portions, and ASIO is a very well established, header only, & portable. It allows us to use a single interface for network IO. As a downside it is fairly large, however, I don't mind being responsible for stripping out the headers we don't use. Asio lets us do blocking & non-blocking IO & has many builtins for things like IPv4 vs IPv6 or UDP vs TCP, etc. This would simplify the networking portions of the code, making them easier to maintain in the future.

That is a very good idea. I will look into it. Thanks

I will start chipping away at it then. I should be able to get a good chunk done before the new year.


[BugFix] Fix unstable ut for decommission test (#23068)

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[x] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

this is a backport from #23068
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio rebase


[zh-tw] Deep learning

This PR contains two parts:

Add zh-tw folder and raw markdown.
Add deep learning zh-tw translation.

Thanks for your great work @kevingo!
A few comments. Could you please:

pull the latest version of the master branch? There seems to be a few missing questions to translate at the end of each cheatsheet.
do this PR only by adding the deep learning cheatsheet?
Make sure that your name in the CONTRIBUTORS file is in the format Firstname Lastname?

HI @shervinea , I've modified the PR as you suggested. Please check again. Thank you.
And I just want to leave the CONTRIBUTORS name with kevingo only, is it ok ?

@kevingo thanks for getting back quickly! It seems that questions 50-54 are still missing (cf. this template).
Sure, we can leave it as kevingo if it is what works best.

@shervinea Thanks for remind. I've already update the missing parts (50-54).

Thanks @kevingo! Now, let's wait for a reviewer to go through the translation.

Thanks for the reviewing by @TobyOoO . All suggestions are professional. I will adjust as recommended.

@shervinea @TobyOoO I've modified the content accordingly. Thanks!

Thanks @kevingo @TobyOoO. Are we good to go?
Also, @TobyOoO could you please add your name to the contributors' list?

Hi @shervinea, I've check with @TobyOoO and help him to add his name to CONTRIBUTOR. Please help to check. Thanks 👍

Thank you very much @kevingo and @TobyOoO! Merging it right now.


Set Default Model and model selection

At this time we want to set the default model to
granite3-dense:2b
We want to offer a selection for
granite3-dense:8b
We are currently testing
granite3-dense:2b-instruct-fp16
granite3-moe:3b
granite3-moe:3b=instruct-fp16

This should be combined with #40


fix: update owners file

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shilinlee
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [shilinlee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add missing checks to Promise.resolve and Promise.reject.

These checks were overlooked when @@species was resolved from these methods.
Discovered by running the ES2015 test262 test suite against es6-shim.

Ah, thanks - could we add test coverage for these to this repo also?

These checks are already covered by IsConstructor inside PromiseCapability - I added https://github.com/paulmillr/es6-shim/commit/3d5bc93597ce89eb05630bcbe194cbf8e8ce3383 to be sure.
Can you share the test262 test conditions that cause a failure without this PR's changes?

It's the built-ins/Promise/resolve/context-non-object-with-promise.js test case which is failing.  It passes undefined as the context object, but a valid Promise as the argument, so it never gets to the check in IsConstructor.  I added PR#381 to demonstrate how test262 test cases could be run on es6-shim, which should let you reproduce the failure.

The only difference I see in the test262 tests is that they're voiding the constructor property on the promise they pass in - however, looking at es6-shim's code path for resolve/reject, they both immediately do effectively new PromiseCapability(this), which in its first line throws if IsConstructor fails for the argument, which it would for any non-function "this" value.
I definitely see the test failing in #381 but I'm mystified as to why.

aha, although Promise.reject already works fine, Promise.resolve has an ES.IsPromise check inside it.

@cscott Why does resolve have that check but not reject?

I'm pursuing that question with the committee members, but in the meantime, if you could freshly rebase this on top of latest master I'd love to merge it ASAP. Thanks!

Rebased.

Thanks!


New package UnstructuredGrids: 0.1.1

Registering: UnstructuredGrids
Repository: https://github.com/lssc-team/UnstructuredGrids.jl
Version: v0.1.1
Commit: c21572c8c5f9e113b0a22bcb5c2bb2be977e06c1
Proposed by: @fverdugo
Reviewed by: @fverdugo
Reference: https://github.com/lssc-team/UnstructuredGrids.jl/commit/c21572c8c5f9e113b0a22bcb5c2bb2be977e06c1#commitcomment-33405905

Can you add some compatibility constraints on your dependencies and Julia?

Yes sure! I am new in julia (this is the first package I register). Can you provide a link on how to add the dependency constraints? Thanks in advance!

Welcome to Julia! Here are some notes about compatibility constraints: https://julialang.github.io/Pkg.jl/v1/compatibility/ In your case I think that this would work great:
[compat]
WriteVTK = "1"
julia = "1"

When you have added this you can just retrigger the bot and this PR will be updated.


[infra] Not clear which typescript versions are supported

Description
There is a need to know what typescript versions are supported by the project since legacy typescript projects (Angular 8 etc.) use typescript versions that don't support the *.d.ts files generated in the latest 'lit' library (including 'lit-element', and, 'lit-html' libraries).
Typescript incompatibility described in #2730 , #2644 .
Steps to Reproduce, and Additional Details
See issues #2730 , #2644 .

Thanks for raising this. We do need to communicate our support level here and potentially setup downlevel-dts to ensure base-level support.

Yeah, not a prob. (👍🏽 ).  Here's what I did in my client project:
For testing:
Tested client library in applications running on:

Angular 13.3.x (requires typescript ~4.6.2 (https://github.com/angular/angular/blob/41c6f7a0796193728981572c8bef900b23da6c3f/package.json#L155) , and
Angular 8 (requires typescript ~3.5.3 (https://github.com/angular/angular/blob/6e30b83267cdb4be62cc2c9737aeac62d14ed513/package.json#L111)

For configuration:
In package.json (all non-relevant details left out) followed instructions in downlevel-dts's README (https://www.npmjs.com/package/downlevel-dts), and made sure my 'downleveled' *.d.ts files were included in my (npm) package deployment;  E.g.
{
"typesVersions": {
    "<4.5": {
      "*": [
        "ts3.5/*"
      ]
    }
  },
  "scripts": {
    "downlevel-dts": "npx downlevel-dts . ts3.5 [--to=3.5]"
  },
  "devDependencies": {
    "downlevel-dts": "^0.8.0",
  }
}

Ensure target downleveled *.d.ts files directory is included in (npm) package deployment (in this scenario that's '{repo-root}/ts.3.5/').


Clear cluster cache on connection update events

Currently, when the SR URI of a local connection is updated to a new value, the sidecar continues to use the old value due to the cluster cache having stale information.
The onConnectionUpdated event handler method needs to include logic to clear all cached clusters for this connection, similar to what we do in the onConnectionDeleted event listener method.
Simply clearing the cluster cache would do the trick by forcing future Kafka/SR REST proxy requests to fetch and re-cache any new cluster details.
This will need an associated test as well to prevent regressions.

addressed here https://github.com/confluentinc/ide-sidecar/pull/150


Client Allocation Request for: Guangdong Zhongke Zhiyun Technology Co., LTD

Client Allocation Questions
Core Information

Name: Guangdong Zhongke Zhiyun Technology Co., LTD
Website / Social Media: http://www.gdzkzy.cn/
Region: Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f3uils5cdx3ezyzszjjfnulugknbdsanmqtisd7x7xkfcljdnshp4jspnrgxpldt5b4aafuz4q4rkebpjykeha
Notary Requested: ozhtdong

@zhiyun11 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

My name is Leo Yang,   I am the director of Australia Gold and Silver Group, the executive director of Guangdong Zhongke Zhiyun Technology Co., Ltd. At the same moment, I am the founder of Qingyun Education Fund of Guangdong Charity Federation.
Qingyun Education Fund is affiliated to the Guangdong Charity Federation,  which consists of six major sections: public education service platform, volunteer learning activities, talent pool plan, teachers and students incentive plan, teaching facilities donation plan, and rural education resource improvement plan.
Relying on AI and blockchain technologies, we bridge the gap betwwen college students volunteers, teachers, and rural teenagers. To provide better teacher resources for students from poor family, who are lack of  education resources, and provide rural schools with better teaching facilities and equipment for lack of hardware conditions. To carry out the education support public welfare projects.
Qingyun Education Fund advocates equality in education, and encourages people from all walks of life to help students and voluntarily teach. Relying on AI and blockchain technologies,  we provide rich and interesting teaching content through online voluntarily teaching. To help and support to improve the education level in rural areas.

Hi @zhiyun11
I thought you have got 2 datacap already.
https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/593
https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/593
So I would like to know:

Why you need that amount of datacap?
Have you finish the usage?

We cooperate with many enterprises on the data storage.
The two application we applied before is about the project of Guangzhou Zhongke Yide Technology Co., LTD.
This one is about the other project, Qingyun Education Fund.
The following Links is about this project.
Website: http://cpwfedu.cn/site
WeChat official account: 青云教育公链
Reports:
https://mp.weixin.qq.com/s/DGcmFe_y8neuGnzD7EmZrw
https://mp.weixin.qq.com/s/W2KJuey8jlfskxG9uOZsaw

Hi, Leo. So you are the "data partner" :).
BTW, I'd love to get some more evidence.

What kind of data do you want to store? Please show me some data demo of Qingyun education.
We'd love to have the business license of Qingyun education and Zhongke Zhiyun.
We'd love to see the Letter of Authorization from Qingyun education. (Or just prove you are the founder and your personal identification)
We'd love to have the searching result of Qingyun education and Zhongke Zhiyun in local business searching website.

The data we intend to store in the Filecoin network is publicly available.
It mainly includes the following types:

Online learning resources
The learning content covers all subjects anf sections of K12 field, primary, junior and senior high schools. At present, the accumulated teaching resources, such as test papers, courseware and teaching plans, have reached more than 12 million sets.
public education video
Videos on public welfare assisting in solving education poverty, experience sharing
live-shooting videos on rural helping, rural living conditions
public service advertisements
and other videos.
Youth learning videos
College professional courses, life common sense, cold knowledge and other scientific periodicals videos;
Introduction of experience and interesting experiences in exams, such as civil servants exam, graduate school exam, IELTS, TOEFL, GMAT, etc.
K12 Subjects Short Video
Problem solving skills: per video on per problem/test site, video on doing exercise or solving skills (quick solving skills, and unique solving skills, etc.);
Solving skills of difficult problems video class;
Video on K12 learning methods, preview and review skills.
Quality lectures of well-known lecturers and excellent tutors; public class videos

The format is mainly divided into:
① document ② picture ③ video ④ audio ⑤ system
The sources are divided into two parts: 1. Purchased learning materials and learning videos; 2. Learning materials and public service videos recorded by Qingyun Education Fund
Can you give me your email address? I will provide others via E-mail.

Thanks for your detailed information. Sure, you send me others via E-mail<EMAIL_ADDRESS>

E-mail has been send.
Please check it.

Hi, please give me your E-mail address or related words. I am sorry that there are too many E-mails to find it.

<EMAIL_ADDRESS>Please check it again.

Hi. @zhiyun11 Thanks again for your application.
We had a discussion about "data partner". And we found out that we can't assure the overallocation of data partner. So we'd love to know your allocation decision.
Which miners will you store? The same as other applications of you or not? Please give us a list.

Thanks for your reply.
We only assist Qingyun Education Fund to find suitable miners, we do not directly provide him with nodes to store data.
The nodes  that will cooperate with:
f0142723、f0807382、f0442383、f0883201
They have a lot of data, and they want to store them on Filecoin.
We are continuing to work on this project with more miner nodes.

These storage providers promise to provide reliable storage services.
I don't know about the website, but I think this website exists too many problems.
For example,

I checked the top two, and the data was questionable.

Okay, is this filecoin-project/filecoin-plus-large-datasets#31 yours?

Yes, because this application has been going on for a long period. So we tried to submit other applications.

Okay, maybe we can give you 1 TiB first to go through the process, then you can deal the LDN well.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacecc3bzm5vvudffouw4k236dadwrmidgkbik4vqmdr57w5boqdwj6e

Address

f3uils5cdx3ezyzszjjfnulugknbdsanmqtisd7x7xkfcljdnshp4jspnrgxpldt5b4aafuz4q4rkebpjykeha

Datacap Allocated

1TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacecc3bzm5vvudffouw4k236dadwrmidgkbik4vqmdr57w5boqdwj6e


ci: make it easier to see breaking change that fails ci job

Forgot to increment the version in https://github.com/lancedb/lance/pull/2829

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.87%. Comparing base (f0fc411) to head (afc6bff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2869      +/-   ##
==========================================
+ Coverage   77.86%   77.87%   +0.01%
==========================================
  Files         231      231
  Lines       70373    70373
  Branches    70373    70373
==========================================
+ Hits        54795    54804       +9
  Misses      12449    12449
+ Partials     3129     3120       -9

Flag
Coverage Δ

unittests
77.87% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Failed unzipping

OpenHack has failed unzipping when i update it

restart your pc, if that doesn't help, delete the mod and try again


Show messages for draft work versions

Fixes #1081.
If a user is viewing a draft work version and there is a published version available, show a message directing the user to the latest published version.
This is an inversion of the previous messaging; we no longer show a message on published versions that a draft version is available.

@awead - this is working, but has some failing tests. If you are doing any work tonight, feel free to take this over. Otherwise I will look into it more tomorrow.