empty sourcemaps for esm bundle

the .es6 assets that are generated with this plugin, have an empty sourcemap:
{"version":3,"sources":[],"names":[],"mappings":"","file":"esm/vendor-b2c1fb4206cbdb61d74d.es6.js","sourceRoot":""}

If you want I can make a test case webpack.config with devtool: source-map i

yes this is on my top priority list.
not sure whats happening here

@rickiesmooth the test would be great, however i. tested manually in this repo, the source maps looked like were being built.
but yes this would be definitely  P0

hey @prateekbh thank you so much for looking into this! much appreciated.
I get the following results when I run npm run test on my test case branch: https://github.com/rickiesmooth/babel-esm-plugin/pull/new/bug/sourcemaps
// index.es6.js.map
{"version":3,"sources":[],"names":[],"mappings":"","file":"index.es6.js","sourceRoot":""}

// index.js.map
{"version":3,"sources":["webpack:///webpack/bootstrap","webpack:///./tests/babel-preset-modules/fixtures/index.js"],"names":["foo","a","b","args"],"mappings":";QAAA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;;QAEA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;;;QAGA;QACA;;QAEA;QACA;;QAEA;QACA;QACA;QACA,0CAA0C,gCAAgC;QAC1E;QACA;;QAEA;QACA;QACA;QACA,wDAAwD,kBAAkB;QAC1E;QACA,iDAAiD,cAAc;QAC/D;;QAEA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA;QACA,yCAAyC,iCAAiC;QAC1E,gHAAgH,mBAAmB,EAAE;QACrI;QACA;;QAEA;QACA;QACA;QACA,2BAA2B,0BAA0B,EAAE;QACvD,iCAAiC,eAAe;QAChD;QACA;QACA;;QAEA;QACA,sDAAsD,+DAA+D;;QAErH;QACA;;;QAGA;QACA;;;;;;;AClFA,IAAMA,GAAG,GAAG,SAANA,GAAM;AAAA,oBAAGC,CAAH;AAAA,MAAGA,CAAH,uBAAO,CAAP;AAAA,MAAYC,CAAZ,uEAAgB,CAAhB;;AAAA,oCAAsBC,IAAtB;AAAsBA,QAAtB;AAAA;;AAAA,SAA+B,CAACF,CAAD,EAAGC,CAAH,EAAKC,IAAL,CAA/B;AAAA,CAAZ,C","file":"index.js","sourcesContent":[" \t// The module cache\n \tvar installedModules = {};\n\n \t// The require function\n \tfunction __webpack_require__(moduleId) {\n\n \t\t// Check if module is in cache\n \t\tif(installedModules[moduleId]) {\n \t\t\treturn installedModules[moduleId].exports;\n \t\t}\n \t\t// Create a new module (and put it into the cache)\n \t\tvar module = installedModules[moduleId] = {\n \t\t\ti: moduleId,\n \t\t\tl: false,\n \t\t\texports: {}\n \t\t};\n\n \t\t// Execute the module function\n \t\tmodules[moduleId].call(module.exports, module, module.exports, __webpack_require__);\n\n \t\t// Flag the module as loaded\n \t\tmodule.l = true;\n\n \t\t// Return the exports of the module\n \t\treturn module.exports;\n \t}\n\n\n \t// expose the modules object (__webpack_modules__)\n \t__webpack_require__.m = modules;\n\n \t// expose the module cache\n \t__webpack_require__.c = installedModules;\n\n \t// define getter function for harmony exports\n \t__webpack_require__.d = function(exports, name, getter) {\n \t\tif(!__webpack_require__.o(exports, name)) {\n \t\t\tObject.defineProperty(exports, name, { enumerable: true, get: getter });\n \t\t}\n \t};\n\n \t// define __esModule on exports\n \t__webpack_require__.r = function(exports) {\n \t\tif(typeof Symbol !== 'undefined' && Symbol.toStringTag) {\n \t\t\tObject.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });\n \t\t}\n \t\tObject.defineProperty(exports, '__esModule', { value: true });\n \t};\n\n \t// create a fake namespace object\n \t// mode & 1: value is a module id, require it\n \t// mode & 2: merge all properties of value into the ns\n \t// mode & 4: return value when already ns object\n \t// mode & 8|1: behave like require\n \t__webpack_require__.t = function(value, mode) {\n \t\tif(mode & 1) value = __webpack_require__(value);\n \t\tif(mode & 8) return value;\n \t\tif((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;\n \t\tvar ns = Object.create(null);\n \t\t__webpack_require__.r(ns);\n \t\tObject.defineProperty(ns, 'default', { enumerable: true, value: value });\n \t\tif(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));\n \t\treturn ns;\n \t};\n\n \t// getDefaultExport function for compatibility with non-harmony modules\n \t__webpack_require__.n = function(module) {\n \t\tvar getter = module && module.__esModule ?\n \t\t\tfunction getDefault() { return module['default']; } :\n \t\t\tfunction getModuleExports() { return module; };\n \t\t__webpack_require__.d(getter, 'a', getter);\n \t\treturn getter;\n \t};\n\n \t// Object.prototype.hasOwnProperty.call\n \t__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };\n\n \t// __webpack_public_path__\n \t__webpack_require__.p = \"\";\n\n\n \t// Load entry module and return exports\n \treturn __webpack_require__(__webpack_require__.s = 0);\n","const foo = ({ a = 1 }, b = 2, ...args) => [a,b,args];"],"sourceRoot":""}

oh great! at least its consistent 😅

hehe yes in that sense it's a great bug! :P

@rickiesmooth in your PR, shouldn't it be
devtool: 'source-map' instead of devtool: 'sourcemaps'?

try running this test: https://github.com/prateekbh/babel-esm-plugin/blob/source-maps/tests/source-maps/source-maps.test.js#L18
on branch source-maps

@prateekbh oef that's embarrassing! Sorry for sending you down that rabbit hole then. I did check the branch on the project I was working on and there I did have devtool: 'source-map' but no sourcemaps were generated, I'll investigate it some more and get back to you if I find something.

FWIW we'rer still getting the same in preact-cli so i'll keep this open

@rickiesmooth , can you try with hidden-source-maps and see if they are being generated well

@prateekbh great that you're looking into it! I tried hidden-source-maps on my test branch of this repo and the .es6.js.map is empty, or do you want me to try it out in my project?

never mind I found the bug and opened the PR here #47


[BEAM-3183] Add runner.run(transform) to Python SDK.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @bkungfoo

This seems like a backwards-incompatible change that will break most existing pipelines.  What is the benefit of this over making this an extra argument to run, so that the existing pipeline construction strategy can be used, while allowing this new way to compose pipelines?

Yes, this is only a change to the runner class. Users shouldn't be calling this directly.


How to handle errors in Effects?

Hi!
First of all, thank you for a great library!
One topic that I didn't find from the Wiki is how to handle errors from Effects properly.
For example, if I use RxMobius, do I need to use .onErrorReturn operator from rx, and put a throwable into the Event, instead of resulting data?
is GetSavedUserEffect -> prefs.getUserSavedCredentials()                     .map { (login, pass) -> UserCredentialsLoadedEvent(login, pass) }                     .onErrorReturn { return@onErrorReturn UserCredentialsLoadedEvent("", "", err = it) }

Hello!
Yes, you have the right idea - errors should be transformed into data as close as possible to where they happen. onErrorReturn is a good way to do that, but make sure you do it inside eg. a flatMap to prevent the entire chain chain from completing (onErrorReturn will complete its chain after emitting the one item).
Typically we would recommend that rather than forwarding the actual throwable, make is so that your effect handler translates the error into an event that in the domain of your loop describes what happened (eg. UserCredentialsLoadFailedNetworkErrorEvent or UserCredentialsLoadFailedNoSavedCredentialsEvent). Of course you could combine your different errors into one event that has an enum or sealed class as a parameter (ie. UserCredentialsLoadFailedEvent(val error: ErrorType)).
It's on our todo-list to write about more things like this on the wiki, so stay tuned!

Hey! Thanks for your answer!
I made something like that in my sample
https://github.com/sgrekov/AndroidMobiusSample/blob/master/app/src/main/java/com/sample/android/mobius/login/view/LoginFragment.kt#L190
One thing that worries me, is if I will create separate Event for error, this event must be subtype of normal event, right? That means I must do something like that:
open class UserCredentialsLoadedEvent(val login: String, val pass: String) : LoginEvent() data class UserCredentialsLoadedEventError(val err: Throwable? = null) : **UserCredentialsLoadedEvent("", "")**

The error doesn't have to be a subtype of the even it is an error for, it can just be a direct subtype of LoginEvent in this case. We like doing it this way because then you know for sure that you've handled all error cases in your update function, because errors are then just regular events, and as such treated just like any other event in the update function.
By the way, I've only skimmed through your sample app so far, but I notice that you don't use RxMobius.subtypeEffectHandler to build your rx effect handler - I'd recommend having a look at it.

I will close this issue as it has been answered, AFAICT. Please reopen if not!

This thread was really useful to me 👍


Do not put whole instance into provision update op

Summary:
InstanceUpdateOperation Provision contained the whole instance. Instance update operations might be queued so it might happen that once the update is applied, that instance we enqueued is already obsolete and the instance changed (e.g. the goal changed).
With this change we always work with the newest instance while applying provision update.
JIRA issues: MARATHON-8516

most of the changes are changes in tests. Maaan, that's a mess. I think I'll remove some of the helpers after we merge this. It's just painful on every change I do...

I think I'll remove some of the helpers after we merge this

not only I'm willing to reveiw/help but you'll get kudos for that! 👍


Getting low accuracy

I always end up with accuracy about 0.5 and loss of about 1.
I assume these value are so low
What would be the default values to expect from SSD300?

What method are you using to compute the accuracy?


Fallback logo

In course index:

In lessons:

This doesn't work here:

Seems like the fallback images isn't copied to build/, and thus unreachable.

Images must be in src folder. See https://github.com/arve0/oppgaver/pull/39

Ahh, my bad.. Seems ok, merging.


Images of NetbankingOption and CardOption

I have included the latest SDK and to my surprise there are no images of banks and card schemes.
Looking at the repo, the images might have present in previous versions. I have included version 3.1.1 and it has the images.
Could you please confirm if we should download all the images and include them in project or you would provide them in future version?

Hi Satya, We do provide bank & card assets with the sdk. Can you tell us which version of sdk you are trying to upgrade and which method didn't return you the bank or card asset.

@sourabh-verma-citruspay I am using the following in my build.gradle
compile ('com.citrus.sdk:payment-sdk:3.4.8:retrofitnewRelease@aar') {
    transitive = false
}

I have checked 3.1.1 also, it has the images while the 3.4.8 one doesnot

Hi @ssatyacc ,
please include below dependencies to your build.gradle for icons
compile 'com.citrus.sdk:bankassets:1.0.0'
compile 'com.citrus.sdk:cardassets:1.0.0'

@MangeshKadam Could you update the same in the docs after which I will close this issue

Updated the doc.


Add flags for sdl1 on unix

You know SDL 1 is not meant to be used on unix, it's for oldschool platform like falcon that dont have it...


Detect Windows 8.1

#423 Windows lies about its version number. Each new release creates a new field to check. Win10 was correctly detected but we missed Win8.1 & 2008 R2.

Verified locally as part of kestrel fixes.


Hour padding with 0 or not at all

In the time output, for 1-digit hours there is a space padding. I suggest:

pad 1-digit our with leading 0 for 24h-format
no padding at all for 12h-format

Implemented by you and merged. Closing


Dialog fonts are scrambled

With the latest nightly the dialog fonts are scrambled / glyphs won't be found on my Linux machine. We need to investigate, if this is an issue on one of the important platforms (Windows, MacOS), too.
Reproduce

Open Modeler
Perform open file
I see a dialog like this:

Environment
Arch Linux
Modeler
Latest nightly

Need to reproduce with others using Linux whether this is an issue on my machine only.

Upgrading to latest electron (https://github.com/camunda/camunda-modeler/commit/97038607618b87740c7fcf98301c1a0e4f10412d) fixes the issue for me.

I also noticed this problem today with modeler v1.8.0 on Arch Linux. I also downloaded modeler v1.0.0 and experience the same problem. So I assume that this is more an Arch Linux then modeler issue.

Thanks for taking your time to reproducing his.
I'd still like to collect some feedback from other Linux distributions to understand the impact of this change.

Works on Windows 10.

Should postpone this update for the next minor release, as it will increase the modeler(s) bundle sizes quite significantly.

I also have this problem on 4.11.3-1-ARCH. I tried  camunda-modeler-1.5.1-linux-x64 and camunda-modeler-1.8.2-linux-x64. Is also reinstalled my font packages.

I have the same issue in Archlinux 4.11.3-1-ARCH and  camunda-modeler-1.8.2-linux-x64

Like arkhan I also have this issue in Arch 4.11.3-1-ARCH / camunda modeler 1.8.0 and 1.8.2-linux-x64
https://forum.camunda.org/t/only-rectangles-are-visible-in-dialogs-of-camunda-modeler-under-arch-linux/3930

see also: https://github.com/electron/electron/issues/9616

Having the same issue with
Linux version 4.4.73-1-MANJARO
and
camunda-modeler (1.8.2-1) from AUR.
Installing electron (1.4.16-2) did not help and also cloning the repo and building the application manually dit not solve this issue.
Would really appreciate a solution for this :)

@pedesen This could be the first one you take over.
We should update electron to the lastest version and check whether that solves the problem.
If true we can merge that into the current milestone.
If updating to latest electron does not solve the issue or if updating is not easily possible we need to re-consider.

The same on Fedora 26.

I can not reproduce it on

my machine: Linux Mint 17.1 (Cinnamon)
VirtualBox: Ubuntu 17.04 (Unity 8)
VirtualBox: Arch Linux 2017.05 (KDE Plasma)


Ignoring ${...} placeholders in settings

I didn't even know it is possible as I though it is a VSCode thing to replace the ${...} placeholders, but setting
"black-formatter.interpreter": [
    "${userHome}/bin/python"
],

Results in this output on black formatter
2023-04-19 15:13:10.034 [info] Name: Black Formatter
2023-04-19 15:13:10.034 [info] Module: black
2023-04-19 15:13:12.771 [error] Python version undefined.undefined is not supported.
2023-04-19 15:13:12.771 [error] Selected python path: undefined
2023-04-19 15:13:12.771 [error] Supported versions are 3.7 and above.
2023-04-19 15:13:12.829 [info] Server run command: ${userHome}/bin/python /Users/lukas/.vscode/extensions/ms-python.black-formatter-2023.2.0/bundled/tool/lsp_server.py
2023-04-19 15:13:12.829 [info] Server: Start requested.
2023-04-19 15:13:12.838 [info] [Error - 15:13:12] Black Formatter client: couldn't create connection to server.
2023-04-19 15:13:12.838 [info] Launching server using command ${userHome}/bin/python failed. Error: spawn ${userHome}/bin/python ENOENT
2023-04-19 15:13:12.838 [error] Server: Start failed: Launching server using command ${userHome}/bin/python failed. Error: spawn ${userHome}/bin/python ENOENT

The same happens with ${workplaceFolder}, with "black-formatter.path" option and (interestingly) with isort extension. Setting the value to a plain "/Users/lukas/bin/python" solves the problem (but this config is shared in our team's git repo, so it should use the placeholders).

I didn't even know it is possible as I though it is a VSCode thing to replace the ${...} placeholders, but setting

Actually this is not supported in VS Code, python extension does this. In black extension we currently only support substituting workspaceFolder.
https://github.com/microsoft/vscode-black-formatter/blob/e0f7830d7d76d92d4f0d7deb840a0d7fd4cbf788/src/common/settings.ts#L89
Can toy share your settings for these cases? that might be a bug.
I think ${userHome} is a good addition to resolve.

Good to know 👍
For the workspaceFolder I have hit this problem in a multiroot workspace, so I wrote ${workspaceFolder:my_folder}/venv/bin/black as per https://code.visualstudio.com/docs/editor/variables-reference#_variables-scoped-per-workspace-folder

actually you can just do this:
${workspaceFolder}/venv/bin/black

OR if there is another layer:
${workspaceFolder}/my_folder/venv/bin/black

Another this using black as binary might slow things down. If you have set the python per workspace using the Select interpreter command in multi root scenario you don't need to do this at all.
Another option if you really need to set path would be to set the interpreter path to ${workspaceFolder}/venv/bin/python

Our setup is weird in that regard that black lives in a different venv than the venv used for development, so the selected interpreter path is ${workspaceFolder:server}/venv/bin/python while the black one is under ${workspaceFolder:tools}/venv/bin/python. If I use only ${workspaceFolder} in a multiroot workspace then what will it evaluate as? The first folder mentioned in the workspace setting?

@lukaspiatkowski can you try this ${workspaceFolder}/../tools/venv/bin/python?
For this layout:
/home/kanadig/project-dir

tools : ${workspaceFolder} ==> /home/kanadig/project-dir/tools
server : ${workspaceFolder} ==> /home/kanadig/project-dir/server
client : ${workspaceFolder} ==> /home/kanadig/project-dir/client
project.code-workspace

I did this:
    "black-formatter.interpreter": [
      "${workspaceFolder}/../tools/venv/bin/python"
    ],

Seems like black is receiving a list of settings, one per folder in multiroot workspace, like so:
2023-04-20 08:45:29.657 [info] Settings used to run Server:
[
    {
        "cwd": "/Users/lukas/repo/server,
        "workspace": "file:///Users/lukas/repo/server",
        "args": [],
        "path": [],
        "interpreter": [
            "/Users/lukas/repo/tools/../tools/venv/bin/python"
        ],
        "importStrategy": "fromEnvironment",
        "showNotifications": "off"
    },
    {
        "cwd": "/Users/lukas/repo/tools",
        "workspace": "file:///Users/lukas/repo/tools",
        "args": [],
        "path": [],
        "interpreter": [
            "/Users/lukas/repo/tools/../tools/venv/bin/python"
        ],
        "importStrategy": "fromEnvironment",
        "showNotifications": "off"
    }
]

And it uses them like so:
2023-04-20 08:54:20.502 [info] /Users/lukas/repo/tools/../tools/venv/bin/python -m black --version
2023-04-20 08:54:20.502 [info] CWD formatter: /Users/lukas/repo/server
2023-04-20 08:54:20.556 [info] Version info for formatter running for /Users/lukas/repo/server:
black, 22.3.0 (compiled: yes)

2023-04-20 08:54:20.557 [info] SUPPORTED black>=22.3.0
FOUND black==22.3.0

2023-04-20 08:54:20.557 [info] /Users/lukas/repo/tools/../tools/venv/bin/python -m black --version
2023-04-20 08:54:20.557 [info] CWD formatter: /Users/lukas/repo/tools
2023-04-20 08:54:20.557 [info] Version info for formatter running for /Users/lukas/repo/tools:
black, 22.3.0 (compiled: yes)

2023-04-20 08:54:20.557 [info] SUPPORTED black>=22.3.0
FOUND black==22.3.0

So it seems that the black server is spawned once per each folder in multiroot workspace and luckily it resolves ${workspaceFolder} to the same folder for each spawn of black (in my case it resolved to the last folder in multiroot setting). Seems random, but meh it works :P Not a great UX though

Instead of using the interpreter setting of the respective folder it picks the setting from the last entry, which is probably better (in my case it is /Users/lukas/repo/tools/../tools/venv/bin/python).

That is a bug, I will need to investigate.

I think that supporting the ${workspaceFolder:folder} setting like VSCode would make the experience much nicer.

I created https://github.com/microsoft/vscode-black-formatter/issues/215 to track the feature request to support ${workspaceFolder:folder}

@lukaspiatkowski Can you try with this build and see if it works as expected?
https://github.com/microsoft/vscode-black-formatter/suites/12382500511/artifacts/657959412

@karthiknadig It worked exactly the same as the released one, see output here: https://gist.github.com/lukaspiatkowski/82749cd8e85d0aae800a7038ac10ae7f it called /Users/lukas/repo/tools/../tools/venv/bin/python for both folders

@lukaspiatkowski I should have been more specific, with this build you can do ${workspaceFolder:tools}.

@karthiknadig sorry it took me so long. I can confirm that this works as expected with your change!


:honeybee: complete the merkle tree with checksums

Calculate checksums all the way up the folder structure and all the way to the catalog level.
What
Each time you save a dataset, you store its checksum in a .md5 file at the root of its folder.
You likewise walk upwards dataset < version < namespace < channel < catalog and calculate the checksum of all the higher level folders, based on their constituents. Since now you are only combining checksums, these steps are cheap.
The net result is that you have a folder tree of checksums, including one top-level checksum that represents the state of the whole catalog.
Why

It allows quick comparison between two catalogs by comparing checkums along their trees

This can be done in fewer network calls, meaning faster diff between local and object storage

It serialises the dataset checksums to disk

This means other codebases can use them without having to know the rules for computing them

It allows you to build something secondary off of the ETL output, and know when you need to rebuild it

This proof of concept is solid, but hard to merge because of the side-effects it adds to dataset saves.
Two thoughts on the next round of doing this:

Instead of a .md5 file, use a .manifest file that lists the checksums of every child file or folder, since this would make diffing against or mirroring an HTTP target easier
Instead of doing this in the abstract, use it to create a faster data diff, then the value will be clearer


refactor(cloudflare): make node:util/types a nodejs_compat module

All methods in util/types are implemented. We can remove the hybrid module status from node:util/types

What workerd version this PR depends on?
We can not pull this code in wrangler before wrangler pulls the required version of workerd.
More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.
@anonrig that's probably something we need to discuss internally.

I think we discussed about it to split wrangler preset/versioning so we can test and upgrade unenv according to the latest workerd release.

I think we discussed about it to split wrangler preset/versioning so we can test and upgrade unenv according to the latest workerd release.

Are you referring to #262?
I think the problem we need to solve for wrangler is how to make sure unenv  is compatible/tested with the version version of workerd it uses.
I'm unsure if creating a wrangler preset is the best way to solve this - hopefully this repo is never aware about wrangler. What I mean is that unenv patches should depend on workerd version, not wrangler version. When we have a way to do that then wrangler will pick the unenv version matching the workerd version it bundles.

More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.

@vicb I agree. In the long term, we should match those 2 version. Right now, wrangler main and unenv main has different workerd version.

More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.

@vicb I agree. In the long term, we should match those 2 version. Right now, wrangler main and unenv main has different workerd version.

Maybe we should have 2 tags for workerd: "prod" and "wrangler" and test both versions.


Digits support

https://docs.fabric.io/ios/digits/digits.html

There is https://github.com/JeanLebrument/react-native-fabric-digits but that's still lacking Android support. +1 for including Digits properly

FYI https://github.com/JeanLebrument/react-native-fabric-digits now has Android support: https://github.com/JeanLebrument/react-native-fabric-digits#android-procedure

this one works pretty well: https://github.com/fixt/react-native-digits
I think it is not a good idea to have all fabric integration in only one package

Going to close this since there's lots of other good packages that do this


Feature Request: x-badges support in more places

Hi, I'm really liking the ability to add badges to our endpoints.  It would be great to be able to notate request and response parameters with badges as well.   This could serve to point out a new optional parameter was recently added or if some fields are experimental.

I like the suggestion.
On query and path params shouldn't be much of an issue
but if you are asking to annotate them inside the schema view,
then we are struggling on maintaining a balance between providing all the info and keeping it clean.
But if you can experiment with title and description to see it can be used for badging

I hadn't considered schema but now that you mention it, It would be ideal to have the option of displaying it there.  I see what you mean about title and description.  Those could be modified to indicate what a badge was intended for.  One drawback with that is being able to provide styling to make it stand out.  Since the templates are customizable, you could collect the data required to indicate which parameters are badged but not provide a layout example and instead leave it up to someone who wants to use it to add it into their template.

not going forward with the request. It will end up being too noisy on the complex schemas, form-data, multipart request bodies etc.
However I am open for a PR, if someone can attempt one I can take it further for an approval


[Router] Shorter refs?

It would probably be better to have shortened refs if possible. Future optimization maybe?  b5232bb...

Why is this in QA fam?

I thought you had a PR for it in the router? I might have been mistaken.

Nurp. That was for fully qualified SHAs. Starting this one presently. The mini-SHAs are only going to work for refs of branches, tags, PRs and heads btw.

Put this on hold while writing tests for the router and depot.


Transaction 2

This is a HUGE rework of Transactions, that permits nested transactions, streams in transactions, etc...
There is unsafe code, not much, should be safe, but needs a lot of testing.
To avoid unsafe code we'll probably need a design rework.
This PR is based on the streams one, probably will be a mess of conflicts, I just need to know what you think about and decide how to go on

Good morning. Thank you again for the pioneering effort.
Though I haven't seen any unsafe keyword yet?
I actually quite liked the original transaction-1. Indeed, I am probably about to merge.
We don't have to rush on this transaction-2.

Back to square 1, was that the lifetime-hell example the root problem you were facing?

My first transaction implementation was inconplete, wrapper inside a Mutex it wasn't possible to have a Transaction type that didn't lived inside a pinboxed closure, and it wasn't possible to use it for streaming, because the mutable reference was limited by the Mutex.
The unsafe is there, instead of a Mutex there is an UnsafeCell that permits to leak the mutable reference where needed.
And the mutable reference is needed because of sqlx APIs, that conflict with our APIs, hence my declaration "to not use unsafe we'll need to redefine our APIs".
The unsafe is only inside DatabaseTransaction, 3 or 4 LOC at max, and should be safe because it's managed, there should be no concurrent accesses, etc...
As I already said, but maybe yesterday evening I was too tired to be expressive, this PR is to discuss the road, I think the improvement is huge and, if only UnsafeCell is the problem, I can try to find another solution, maybe with GhostCell

Thank you for the clarification.
I understand that. So it's about Transaction and Streaming at the same time.
I'd ask, would it be possible to separate the implementation of transaction vs normal connection?
Instead of an enum holding all inner connections, the InnerConnection only exists when a transaction is involved.
That way, at least for the normal connection case, it'd be as simple and safe as before.
The only complication is inside transactions, where an Inner Cell is needed.
Well, I have read the GhostCell paper a while ago, and I'd be very interested if it is indeed the solution to our current situation. Quite cool indeed!

Well, the normal connection has a completely safe implementation also now, the same applies to InnerConnection, UnsafeCell is only inside DatabaseTransaction.
I'll look into GhostCell as soon as I can

I've checked a few things:

I don't feel like GhostCell is a feasible solution for this problem (or maybe I haven't understood it at all).
I've tried to test this branch with Miri to check the soundness of the unsafe code, but Miri and async code doesn't seems to love each other.
Using Transanction-1 branch, I've ended up in another lifetime hell without doing anything special, I don't think you should put that in production.
I'm more and more convinced we need an API review, and now I'm going to explain you why.

The main problem with actual implementation, is that inside DatabaseConnection you take a connection from the pool, use it and drop it. This way you're safe from every problem, but you're forced to a "flat" structure.
By flat structure I mean you can't send out something (e.g. a transaction) that owns a sqlx connection, because your APIs always take &self, and sqlx needs a mutable reference of the connection to be able to execute queries.
Using a Mutex to be able to gain a mutable reference of an inner sqlx connection (like I've done in Transaction-1) excludes any kind of operation that would return a wrapped reference to the connection, like nested transactions or streams.
Another hidden bomb is Sqlite: Sqlite sqlx connections aren't Sync.
In this PR I've tried to let everything not be Send (you can see various #[async_trait(?Send)] around), this way sqlite won't be a problem, but in a real-life usage your futures need to be Send to run in an multithreaded runtime.
A lesson learnt from this PR is that sqlx Transactions can be easily de-structured, sqlx has a TransactionManager trait that manages what's executed on a connection to make it a transaction, therefore you don't really need a sqlx Transaction object, you just need a sqlx connection object and to know which TransactionManager implementation call.
But the problem remains, once we return a sqlx connection, we lose Sync if sqlite is enabled, and we need to obtain a mutable reference to be able to execute queries on it, while maintaining a common API with DatabaseConnection (actual ConnectionTrait)

Another test I've done is to impl ConnectionTrait on &DatabaseConnection and &mut DatabaseTransaction, this way we would be able to differentiate on mutability only where needed.
Unfortunately, mutable connections aren't Copy, so where we use the generic, we can't ask for Copy, and the reference would be considered consumed at first use.
More, mutable references aren't Sync.

Thank you for the hard work indeed.
Yes, we'd better scrap the 'transaction in a closure' API or only provide it as a convenience helper, but not the universal solution.
May be we should resort to the start, commit & rollback style, where 'start' returns an owned Transaction object wrapping a connection with ArcMutex (thus can be mutated), whose lifetime shall not exceeds the parent pool, and automatically rollback if goes out of scope.
That'd still be 'flat'?

With Arcmutex you mean a normal Arc<Muex> and cloning the Arc instead of returning a reference?

My bad for the poor formatting. Yes, otherwise there is no other way to hide the mutability I suppose.

Well, it could actually work...
I'm asking myself why I haven't thought of that myself

Hopefully it'd work.

I'm trying right now, but in fact now I remember why I didn't considered that technique: using a Mutex you can't "leak" a reference, therefore you can't have streams

Okay so we abandon transaction-1 for now?
I am cherry-picking the useful bits.

Well, this branch is based on streams that is based on transaction-1...
Maybe it's better to flatten everything and create a new PR, when we'll have a viable solution

I tried to think about that yesterday.
But I guess we might figure out how to fit streaming support after transaction is in place?
Or better the other way around?

I have an idea, maybe today I'll be able to test it, I'll let you know

Well, the only test failed is on the Rocket example, that I haven't touched, for reasons not related to my changes...
Take a look at the code, let me know if that's acceptable, I'll make some more tests during the day.
Probably you'll want me to make a new PR to clear the commit history and rebase to actual master.
DatabaseTransaction contains an Arc<Mutex<InnerConnection>> as you suggested, opening a stream on a transaction locks the transaction, so there can be deadlocks if someone opens a stream on a transaction and, before consuming it, tries to do something else with the transaction. We'll have to write it in the docs.
I had to make two different stream implementation, one with an owned connection and one with an inner mutex lock on a transaction.
There is still an uncovered path, and it's on drop of a nested transaction, actually there is an unreachable! macro, https://github.com/nappa85/sea-orm/blob/transaction-2/src/database/db_transaction.rs#L150
The problem is that the lock is async, but I'm not in an async closure because Drop isn't async.
Maybe I can use try_lock, that isn't async, and if it returns None panic because we are dropping a locked connection, but I'm a bit uncomfortable about that...

Thank you so much for the hard work.
I am going over the elaborate changeset.

My tests are all green, let me know if you've any doubt

Yup, I am making the final 0.2 release now. After that, this will be rebased onto master to prepare for 0.3! Oh, and, are we resolving Transaction + Stream at the same time? TBH I am still studying the Mutexes.

Yes, streams are implemented here.

I am still thinking of how to implement this, perhaps a MockTransaction object that impl ConnectionTrait but store the statements within a buffer, and somehow push into the MockDatabase on commit.

At the moment a transaction for a Mocked connection is transparent, but yes, a buffer could be a good solution, merging it on commit and dropping it on rollback

Can you explain briefly what the MutexGuard do?

Can you explain briefly what the MutexGuard do?

https://doc.rust-lang.org/std/sync/struct.MutexGuard.html ?

Can you explain briefly what the MutexGuard do?

MutexGuard is the owner of the mutable reference coming from Mutex, once MutexGuard is dropped, Mutex is unlocked.
https://docs.rs/futures/0.3.17/futures/lock/struct.MutexGuard.html

So, while the TransactionStream is running, the Connection will be locked. And as soon as the Stream finishes, the lock will be released, am I right?
But what's the difference to QueryStream which does not require a MutexGuard?

QueryStream has an owned connection inside, taken directly from the pool. Like any other operation outside a Transaction, a new connection is taken from the pool every time, used and then returned to the pool. QueryStream is little different, it keeps the connection for the stream lifetime

Thank you for the explanation. It helps a lot.

I know this is a pretty new PR, and is likely to undergo many changes until merge, but has thought been put into transaction isolation support?

I know this is a pretty new PR, and is likely to undergo many changes until merge, but has thought been put into transaction isolation support?

Thank you for raising. Sure we will get to that.


C's (Optional) Named Integer Types

I think clang and gcc currently disagree on the size and alignment of int_fastN_t and int_leastN_t in some places. GCC is likely correct, as clang will always match those two.
Do we want to codify this in the psABI?
I looked at making the Clang changes required, and they were fairly involved - https://reviews.llvm.org/D80963 was the initial bit, but clang also has a stdint.h implementation for freestanding mode which is not very much fun to edit and improve.
If we don't want to codify it, we should also say that, maybe. I don't know what people feel is reasonable.

These affect the calling convention, struct layout, etc., so I think we basically have to codify this.
It looks like all glibc targets use the same definitions: fast8 is char; the others are long.  I can't say I understand why fast8 is the way that it is, but the rest are sensible.  https://github.com/gcc-mirror/gcc/blob/master/gcc/config/glibc-stdint.h

These affect the calling convention, struct layout, etc., so I think we basically have to codify this.
It looks like all glibc targets use the same definitions: fast8 is char; the others are long.  I can't say I understand why fast8 is the way that it is, but the rest are sensible.  https://github.com/gcc-mirror/gcc/blob/master/gcc/config/glibc-stdint.h

My opinion is that this stuff really belongs in the C API. See, e.g.,
https://github.com/riscv/riscv-c-api-doc/pull/14
However, there is (apparently) now a psABI working group, whereas I don't think the same is true for the C API.

My opinion is that this stuff really belongs in the C API. See, e.g.,
https://github.com/riscv/riscv-c-api-doc/pull/14
However, there is (apparently) now a psABI working group, whereas I don't think the same is true for the C API.

Ah, yeah, I agree; I suppose my point is that it should be standardized, not that it should be standardized in this doc.

Ah, yeah, I agree; I suppose my point is that it should be standardized, not that it should be standardized in this doc.


cron expression with leading zero in numbers doesn't work

It doesn't work and it doesn't throw an invalid expression as well.
For example
01 20 * * * will not run at 20:01 everyday

I had this problem too. The npm 'cron' package actually uses and example with "00 ..." and it failed when converted. There need to be some parseInt's somewhere.


Enable to perform Deployment Analysis by Datadog

What would you like to be added:
Adding support Datadog as an Analysis Provider.
Piped config for datadog will be something like:
apiVersion: pipecd.dev/v1beta1
kind: Piped
spec:
  analysisProviders:
    - name: datadog-dev
      type: DATADOG
      config:
        address: https://your-datadog.dev
        apiKeyFile: /etc/piped-secret/datadog-api-key
        applicationKeyFile: /etc/piped-secret/datadog-application-key

Links:

About Deployment Analysis: https://pipecd.dev/docs/user-guide/automated-deployment-analysis/

Why is this needed:

/assign @nakabonne


run cargo update

Most notably update cpufeatures to fix a panic on x86_64 cpus which do not have (full?) avx support, see https://github.com/containers/podman/issues/16194.

error: package zbus_names v2.2.0 cannot be built because it requires rustc 1.60 or newer, while the currently active rustc version is 1.59.0
Old Ubuntu version with old Rust?

Old Ubuntu version with old Rust?

Nope that is their current rust version even in newer ubuntu releases. I revert the stuff we that it will break.

Tests are green

LGTM

/lgtm


PR #857 should revert

@JerryNixon - I think PR #867 just merged should revert. The display mode should stay CompactInline rather than Inline. I suspect Inline was suggested as a workround for a problem that seem to go away with Inline display mode but this is not the case. In fact, this introduces a new host of problems. HM never used Inline, why use now?


add py39 to ci

This PR adds a python 39 version to CI so that tests are run against the versions of anaconda and anaconda2 that are running in prod.

Supersedes #17

@vanpelt 👍 will make a new pr


Marketplace in preview to use dev apis

update Zesty.FetchWrapper(instanceZUID, userAppSID); https://github.com/zesty-io/nextjs-website/blob/f54adf951090b72d87030a2a503b3ab905592ee8/src/components/marketplace/installed/index.js#L25
https://github.com/zesty-io/nextjs-website/blob/f54adf951090b72d87030a2a503b3ab905592ee8/src/components/marketplace/AppInstallerComp.js#L12
https://github.com/zesty-io/nextjs-website/blob/f54adf951090b72d87030a2a503b3ab905592ee8/src/components/marketplace/register/index.js#L80
check process.env.production !== 'true' if its not in production, use the dev apis
to use Zesty instantiation Zesty.FetchWrapper(instanceZUID, userAppSID, {...}); options as documented for dev apis https://github.com/zesty-io/fetch-wrapper#use-in-development-mode

@darwin808 please search for all instances of  Zesty.FetchWrapper and run this logic. Please look to see if ZestyAPI can be set globally once in the header to avoid all the separate instantiation you run.


Dev-server on Windows

I am running on Windows and when I try to run the maba:webpack:dev-server command then I get '"exec"' is not recognized as an internal or external command, operable program or batch file. message.
So I've temporarily commented out line 76 inside src/Compiler/WebpackCompiler.php - // array('exec'), which fixed it. I'd sent a PR but since I'm not a Linux expert I'm not sure why exactly the exec is present. Could it be removed? Or should there be a condition for OS? Which solution do you prefer? Or another one?
EDIT: Another workarround without editing vendor code is to shim exec command by creating exec.cmd file inside the project root containing @%*.
Thanks for this great bundle.

It's there so that stop would work on linux. See note in Symfony documentation - php wraps command in separate sh process, so when stop is called, it stops that sh process and node (dev-server) process is still running in the background. Another cannot be started as port is already taken.
I haven't found any information about what's the case in Windows for that separate sh process.
One solution could be just to avoid exec on windows machines, but it could still leave processes in the background, which would not be nice. Could you check this on your machine:

Comment out that line (exec)
Start dev-server command
Change twig template - add, change or remove entry point in your twig template (while command is still running)
Command restarts automatically to handle new entry point(s)
What's the situation now? Is first node process stopped and second started successfully?

Thanks.
Another way to deal would be just ignoring changes in twig files - they are not changed so frequently and when configuration is changed (like config.yml), command still needs manual restart, so this does not handle all the cases.

OK. I see. I've tried it and looks like it works.
POSIX signals are not available on Windows platforms, please refer to the PHP documentation for available signals.
Symfony handles stopping of the process differently on Windows.
Check this line https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Process/Process.php#L1522
PR sent

Fixed by #14. Thanks!


bytebuddy is not compatible with Java 21 versions

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

https://github.com/apache/incubator-seata/actions/runs/9073086963/job/24929657372
Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
Just paste your stack trace here!

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Minimal yet complete reproducer code (or URL to code):
Ⅴ. Anything else we need to know?
Ⅵ. Environment:

JDK version(e.g. java -version):
Seata client/server version:
Database version:
OS(e.g. uname -a):
Others:

https://github.com/raphw/byte-buddy/issues/1396
我们应该将其升级到1.14.3版本及以上
We should upgrade it to 1.14.3 version and above


example

I just found this project and have been playing aroudn with it.  It really adds allot of the stuff you need in ops and i like its approach. no more ssh bastions and guesswork etc :)
Is it possible to make an example to show off Choria for a golang apps developer ?
Maybe a docker for the core choria server with the certs setup and then a microservice using the backplane.

Thanks @gedw99 yeah an example will be published, as you can tell this project started like yesterday so its early days.
I'll probably bake the example into the vagrant demo or something

Sounds great....
Looking forward to trying this out.
On Sat, 7 Jul 2018, 14:09 R.I.Pienaar<EMAIL_ADDRESS>wrote:

Thanks @gedw99 https://github.com/gedw99 yeah an example will be
published, as you can tell this project started like yesterday so its early
days.
I'll probably bake the example into the vagrant demo or something
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/choria-io/go-backplane/issues/10#issuecomment-403211237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATuCwoFWMBBj8uzVJn0Lb1utnrx2F2efks5uEKTbgaJpZM4VGT4o
.

I added a working example in example some more things to do to make it usable in the vagrant demo but you can get the idea there

The del is basically a manifest describing what the thing does and what it needs.
I saw that it's codegenerated in the other code somewhere.
Sorry to bug you but it's an usual framework and just trying to get a cognitive reference frame of the how and why..

Yeah leave this one open I will still work on it
Do you know web services? You would have a JSON Schema or WSDL that describe the service.  We are mid transition between projects and for new people it’s a bit rough going.
Start here https://choria.io/docs/concepts/ today the only viable deployment method is with Puppet.

Ok leaving open
It's considerate of you in that yeah I don't know mcollective - it's a terrible rap band name ?  So I gotta read up on the concepts you linked.
I do know SOAP, WSDL, and even a little DISCO from the C# spoonfeeding days. Ironically have to do some WSDL parsing in golang to interface with a Microsoft server at work. Sigh .

Dooh. Reopening ..

MCollective is a old project I made and sold - ruby framework for writing APIs accessible from the CLI and Ruby API
It’s owners abandoned it and so I started a new project to kick things up again. Focusing on performance, scale etc. We can do a RPC request hitting round trip on 60000 machines in about 1 second
Traditionally very dependent on Puppet but slowly gaining independence.
So right now getting all the bits working is some Ruby and some GO and some Puppet CA. Easy for Puppet users hard for others.
Read the concepts and let me know what you think.

i read the docs and everything there is familiar to me and it looks great.
Is Puppet part of this architecture going forward or is the idea to move away from it.
TO be brutal, I dont need puppet for what i see Choria doing for me.

Something has to install and co figure things - Puppet.
Traditionally we used their CA and so forth but around September they will stop shipping mcollective (we use it’s CLI still) and by then I want to be more or less capable of being standalone.
Today already you can install it without Puppet it’s quite easy but not documented. Very recently I made the CA pluggable but I am yet to do same On the ruby side for the CLI

ok thats hopefully. It should be pretty easy to replace the Certificate Authority with Vault if thats what you mean by Puppet CA.
Have you got a link to the CA code ?

Backplane, choria, stream replicator and prometheus streams all use https://github.com/choria-io/go-security/
I won’t abstracts to this level in the ruby code - probably just the manual one with enrollment by a Go App that drops certs on disk
The new CA code isn’t published yet but it will live in the network transport and needs to be able to issue like 1/2 million certs fairly rapidly so it’s quite a undertaking. Could be backed by vault indeed but nodes shouldn’t speak vault directly

Ok. SO i think i should wait until the CA is golang based. I am a puppet
newbie so have no idea...
then i can try things out. Is that ok ?
On Sun, 8 Jul 2018 at 06:47 R.I.Pienaar<EMAIL_ADDRESS>wrote:

Backplane, choria, stream replicator and prometheus streams all use
https://github.com/choria-io/go-security/
I won’t abstracts to this level in the ruby code - probably just the
manual one with enrollment by a Go App that drops certs on disk
The new CA code isn’t published yet but it will live in the network
transport and needs to be able to issue like 1/2 million certs fairly
rapidly so it’s quite a undertaking. Could be backed by vault indeed but
nodes shouldn’t speak vault directly
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/choria-io/go-backplane/issues/10#issuecomment-403262154,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATuCwmH-bmYaS0-clBTZxUXOl5tckN_eks5uEY7SgaJpZM4VGT4o
.

yup yup, onboarding non puppet people is definitely something of a goal - but I am some ways off alas, will hopefully get to a point of some kubernetes operator or such, in time - people who fund my work have like zero interest in that so its slow going to get there

Understood. I can't find it. Just a lone Deb. So I will wait until things
are a little bit mature
On Mon, 9 Jul 2018, 14:36 R.I.Pienaar<EMAIL_ADDRESS>wrote:

yup yup, onboarding non puppet people is definitely something of a goal -
but I am some ways off alas, will hopefully get to a point of some
kubernetes operator or such, in time - people who fund my work have like
zero interest in that so its slow going to get there
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/choria-io/go-backplane/issues/10#issuecomment-403463922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATuCwqNxKa2haZ8NIgGc6tnvCz-_GS2uks5uE05TgaJpZM4VGT4o
.

@gedw99 the entire CLI and API is in ruby and today provided by Puppet along with its CA etc, Choria exists literally (till quite recently) to make the almost unusably complex to install mcollective usable within 10 to 30 minutes for a Puppet User.
So yeah, it's tough going if you're not the target :) Keep an eye on the mailng list, I'll announce stuff as they come - for backplane specifically I expect I'll publish a binary to manage it independent of all the puppet shit, it's a great project to test the waters with

@gedw99 what OS are you on? I'll - probably tomorrow - give you 2 binaries one of the example app and one of the new CLI that can run against any gnatsd without any puppet or anything

or maybe I'll just make a docker compose file

@gedw99 you can now have a go with docker compose https://github.com/choria-io/go-backplane#docker-demo


Contact Researchers for Missing Imports

Unfortunately, no response has been received from the researchers. I am going to close this issue now as we will have to make do with what is left.
Talked with professor about this, and he was understanding about the situation.


Fix deprecation on aws_iam_policy_document.source_json in favor of source_policy_documents attr.

what

I was getting deprecation warning for data.aws_iam_policy_document.resource.source_json attribute:│ Warning: Argument is deprecated
│
│   with module.ecr_public.module.ecr_public.data.aws_iam_policy_document.resource,
│   on .terraform-devops/modules/ecr_public.ecr_public/main.tf line 43, in data "aws_iam_policy_document" "resource":
│   43:   source_json = local.principals_full_access_non_empty ? join("", [data.aws_iam_policy_document.resource_full_access[0].json]) : join("", [data.aws_iam_policy_document.empty[0].json])
│
│ Use the attribute "source_policy_documents" instead.
│
│ (and one more similar warning elsewhere)

why

Simple fix for deprecated attribute, please see docs here!

references

Documentation on source_json being deprecated

/test all

Yeah didn't check the blame — thanks for the clarification!


Bump version to <IP_ADDRESS>

opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance

Github Issue # or road-map entry, if available:

Description of changes:
Bump version to <IP_ADDRESS>

Why these changes are required?
Release <IP_ADDRESS>

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
No changes in behavior

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
UT

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Please update build.gradle too


Test failure

X tests.SkunkPersistenceKeywordNamespaceSuite.skunk: Must consume outbox correctly once failed in the CI
https://github.com/hnaderi/edomata/blob/203e1c76122b3225c00cc8c9b1bed5601aeb5224/modules/backend-tests/shared/src/main/scala/PersistenceSuite.scala#L148

We're also facing this failure sometimes:
X tests.DoobiePersistenceKeywordNamespaceSuite.doobie: Appending must be idempotent


mitmproxy crashes with multiple "list indices must be integers, not weakref"

Domain: https://www.spb.velogorod.org/
mitmproxy version: v0.12.1

I cannot reproduce the error. Could you please provide a full traceback and steps how to reproduce the issue?

Sorry, me neither. Maybe it was an interference with developing tools.. System is Linux Mint 17.1 KDE 64 bit, mitmproxy installed with pip. Browser Firefox, CA installed... won't bother you with the rest of my setup as I cannot reproduce it myself. Sorry.

No problem. Make sure to capture a traceback next time. :-)
Cheers,
Max


Split UserPermissions options

Allows to use async-configuration directly on userService
Simplifies adding additional services (especially when they are used as providers themselve)

@fraxachun why did you close it?

@fraxachun why did you close it?

I think I go with the other solution since this pattern really is unusual in Nest and I found out that I still can achieve what I want.


Add option to warn on shutdown and restart

This was requested in #324.

doesn't work for me
steam@arkfrancegaming:/root$ arkmanager useconfig valhalla restart --warn
Running command 'restart' for instance 'valhalla'
/usr/local/bin/arkmanager: ligne 685 : [: =~ : opérateur binaire attendu
/usr/local/bin/arkmanager: ligne 688 : [: =~ : opérateur binaire attendu
The server has been stopped
The server is starting...
The server is now up

same with a simple restart
steam@arkfrancegaming:/root$ arkmanager useconfig pve restart
Running command 'restart' for instance 'pve'
/usr/local/bin/arkmanager: ligne 685 : [: =~ : opérateur binaire attendu
/usr/local/bin/arkmanager: ligne 688 : [: =~ : opérateur binaire attendu
Stopping server...
The server has been stopped
The server is starting...
The server is now up


Empty string is converted to null

spark-redshift (v3.0.0-preview1) will convert an empty string '' into a null value when reading data from redshift:
spark.read
  .format("com.databricks.spark.redshift")
  .option("url", url)
  .option("aws_iam_role", iamRole)
  .option("tempdir", tmpDir)
  .option("query", "select '' as foo, null as bar")
  .load()
  .show()

[info] +----+----+
[info] | foo| bar|
[info] +----+----+
[info] |null|null|
[info] +----+----+

In redshift, there is a distinction between null and '':
redshift-user=> select foo is null as foonull, bar is null as barnull from (select '' as foo, null as bar);
 foonull | barnull
---------+---------
 f       | t
(1 row)

spark-sql also supports this distinction:
spark.sql("select '' as foo, null as bar").show()

[info] +---+----+
[info] |foo| bar|
[info] +---+----+
[info] |   |null|
[info] +---+----+

This is a known issue (#49) but we could do a better job of documenting it in the README. Do you have any suggestions for how we can fix this?

I was discussing this with @drewrobb (it bit me this morning); I hadn't realized where the distinction was lost, and it looks like it's lost in the UNLOAD query to redshift. One (not awesome) option would be to allow a value to be passed through to NULL AS, and let the caller choose a value that's not expected to be in the dataset
http://docs.aws.amazon.com/redshift/latest/dg/r_UNLOAD_command_examples.html#unload-examples-null-as

In conjunction with the unload option ADDQUOTES and NULL AS '@NULL@, you can get some output that could distinguish between '' and null correctly through the UNLOAD step. Some further work would be necessary in https://github.com/databricks/spark-redshift/blob/1092c7cd03bb751ba4e93b92cd7e04cffff10eb0/src/main/scala/com/databricks/spark/redshift/RedshiftInputFormat.scala to remove the quotes before returning the data to spark.

Adding an option for configuration of the null value sounds reasonable to me.

Is there any update on this?

Databricks has decided to close source new work on this project, so I don't expect any update or any PR accepted here. Maybe a community fork will get going, I'm disappointed and will avoid Databricks open source projects going forward.

Is this supposed to be fixed? Writing data with empty strings to Redshift keeps giving me errors regarding non-nullable column, but i would like to keep the empty strings as they are and not convert them to null

I was wondering if you had an issue with Redshift that returns NULL in one database and on the same dataset but in different database it returns empty string. The data is the same on both of the databases?


using with the new code generation in Flutter?

I'm trying to understand if it's possible to use this package with the new Flutter code generation ?
Should it be possible to wrap the functionality to run the json (de)serialisation code generation with a Flutter builder?

I believe so – @jonahwilliams ?

So to answer my own question, yes it worked just fine to use json_serializable with Flutter's codegen, BUT that functionality is actually currently broken so I should say it will be possible once that's fixed.


Hermes Causes Osmosis Sentry to Crash When Accessing gRPC

Crate

Hermes Relayer
Summary of Bug

Hermes Causes Osmosis Sentry to Crash When Accessing gRPC.  gRPC is enable by default and the Osmosis Sentry node runs fine BUT when I enable Hermes to access the node it cause it to crash.  I see that a transaction will output a long, long string of data and the node stops reading blocks.
Version

git version 2.25.1
Steps to Reproduce

For me, In stall the Osmosis sentry and then configure Hermes to access it.  The problem occurs withing 5 minutes
Jul 21 05:35:24 osmosis-sentry-02 cosmovisor[2904]: 5:35AM INF Error reconnecting to peer. Trying again addr={"id":"00c328a33578466c711874ec5ee7ada75951f99a","ip":"<IP_ADDRESS>","port":26656} err="auth failure: secret conn failed: read tcp <IP_ADDRESS>:40766-><IP_ADDRESS>:26656: i/o timeout" module=p2p tries=4
Jul 21 05:35:25 osmosis-sentry-02 cosmovisor[2904]: 5:35AM INF ABCIQuery data=0A087472616E7366657212096368616E6E656C2D301A0B18FFFFFFFFFFFFFFFFFF01 module=rpc path=/ibc.core.channel.v1.Query/PacketAcknowledgements result={"code":0,"codespace":"","height":"436445","index":"0","info":"","key":null,"log":"","proofOps":null,"value":"CjkKCHRyYW5zZmVyEgljaGFubmVsLTAYASIgCPdVftUYJv4Y2EUSvyTsdQAe268hI6R333KgqfNkCnwKOQoIdHJhbnNmZXISCWNoYW5uZWwtMBgKIiAI91V+1Rgm/hjYRRK/JOx1AB7bryEjpHffcqCp82QKfAo5Cgh0cmFuc2ZlchIJY2hhbm5lbC0wGGQiIAj3VX7VGCb+GNhFEr8k7HUAHtuvISOkd99yoKnzZAp8CjoKCHRyYW5zZmVyEgljaGFubmVsLTAY6AciIAj3VX7VGCb+GNhFEr8k7HUAHtuvISOkd99yoKnzZAp8CjoKCHRyYW5zZmVyEgljaGFubmVsLTAYkE4iIAj3VX7VGCb+GNhFEr8k7HUAHtuvISOkd99yoKnzZAp8CjoKCHRyYW5zZmVyEgljaGFubmVsLTAYkU4iIAj3VX7VGCb+GNhFEr8k7HUAHtuvISOkd99yoKnzZAp8CjoKCHRyYW5zZmVyEgljaGFubmVsLTAYkk4iIAj3VX7VGCb+GNhFEr8k7...........

Acceptance Criteria

Hermes 6 is able to access gRPC for Osmosis witout killing the node

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Hello,
Thanks for opening this issue, seems quite critical!
Could you please provide further info, concretely:

how do you run Hermes? Is it hermes start, or some other command?

it may be useful to paste somewhere the whole Hermes log file so we can see what might have gone wrong

can we also see you Hermes config.toml file?

I've also experienced this. Requires restart of the node.

I run Hermes using a service that starts it with hermes start
Do you have an e-mail address I can send the log and config.toml file to?

I've also experienced this. Requires restart of the node.

@jackzampolin are you also using cosmovisor to run the node ?

gRPC should not crash full nodes so some fix needs to go into abci/SDK for that.
But we should fix hermes to not give the full node a cause to crash: Not seeing any logs attached here but the little snippet seems to indicate the crash happens on acknowledgment query. Maybe the output is too big. hermes uses pagination: ibc_proto::cosmos::base::query::pagination::all() in the request. I guess hermes could limit the number of items in the response by doing multiple requests/ pages.

Hi @lightiv, can you provide an update on this, please? Is this still a problem with the latest release?

Hi Need to update the be lates binary which I will do today and get back with you.  Thanks.

I am running 7.0.1 and gRPC still kills the node which this output being the final gashp.

.

Oh, wait.  By the time I finished the above post the console had timed out and when I reconnected the node was running.  I will let it go for a bit.  The above is Osmosis.  I will try Akash also.

@lightiv Are you still seeing the same issue with Hermes 0.7.2? Even if we haven't gotten to using pagination yet, this version  should be much lighter load on the nodes now, both at startup and during normal operations.

I have had this running for a couple of hours on the Akash and Osmosis nodes having issues and they have not become unresponsive.  The Akash node is running fine and appears to be keeping up with the current block height.  The Osmosis node is crawling and continually slowing.  It will not be able to get to the current block height.

Oh, sorry need to refresh.  Let me update to v0.7.2 and get back to you.  I am currently on v7.0.1.

I have upgraded to v0.7.3 and I am not having any issues with the Osmosis node crashing.  The problem now is that hermes times out accessing gRPC:
Oct 18 03:23:03 hermes[661828]: Oct 18 03:23:03.701 ERROR ThreadId(01) skipped workers for connection connection-13 on chain osmosis-1, reason:
Oct 18 03:23:03 hermes[661828]:    0: relayer error
Oct 18 03:23:03 hermes[661828]:    1: error in underlying transport when making GRPC call
Oct 18 03:23:03 hermes[661828]:    2: transport error: error trying to connect: tcp connect error: Connection timed out (os error 110)
Oct 18 03:23:03 hermes[661828]:    3: error trying to connect: tcp connect error: Connection timed out (os error 110)
Oct 18 03:23:03 hermes[661828]:    4: tcp connect error: Connection timed out (os error 110)
Oct 18 03:23:03 hermes[661828]:    5: Connection timed out (os error 110)
Oct 18 03:23:03 hermes[661828]: Location:
Oct 18 03:23:03 hermes[661828]:    /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/flex-error-0.4.3/src/tracer_impl/eyre.rs:31

I have verified that gRPC is accessible externally:
grpcurl -plaintext <IP_ADDRESS>:9090 list

cosmos.auth.v1beta1.Query
cosmos.bank.v1beta1.Query
cosmos.base.reflection.v1beta1.ReflectionService
cosmos.base.tendermint.v1beta1.Service
cosmos.distribution.v1beta1.Query
cosmos.evidence.v1beta1.Query
cosmos.gov.v1beta1.Query
cosmos.params.v1beta1.Query
cosmos.slashing.v1beta1.Query
cosmos.staking.v1beta1.Query
cosmos.tx.v1beta1.Service
cosmos.upgrade.v1beta1.Query
grpc.reflection.v1alpha.ServerReflection
ibc.applications.transfer.v1.Query
ibc.core.channel.v1.Query
ibc.core.client.v1.Query
ibc.core.connection.v1.Query
osmosis.claim.v1beta1.Query
osmosis.epochs.v1beta1.Query
osmosis.gamm.v1beta1.Query
osmosis.incentives.Query
osmosis.lockup.Query
osmosis.mint.v1beta1.Query
osmosis.poolincentives.v1beta1.Query
testdata.Query

The issues I was having has been resolved by installing everything on one box.  I am now relaying.


Add audio and colliders

Overview
Polishing InteractableExamples scene
Changes

Fixes: #6632 .
Added AudioReceiver to all Interactable Buttons
Added BoxCollider to Quads that serve as backing for buttons

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.
If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.
As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

@ritijain , can you please resolve the merge conflict? we should then be able to merge. thanks!

/azp run

/azp run


A disconnected peer cannot rejoin

At present, if a network adapter fires a peer-disconnected event, the DocSynchronizer removes the peer from its list, but maintains it's state.
When a new peer-candidate event is fired, the DocSychronizer checks to see if it has a doc state for that peer before adding the peer back on its list. As the state is still present, the peer never gets added.
Happy to issue a pull request for a fix, but I have a question about implementation. Would it be preferred to:

Remove the peer state when a peer is disconnected OR:
Keep the state and always add to the peer list if not already present on reconnection

It seems to me that it would be better to preserve the known state so that we would not be losing information already known about the peer's doc. I see that beginSync method already performs an encode/decode cycle.
NB. I spotted this as I was trying to find a way to reset the state from a network adapter in the case that the connection dropped or a syncMessage failed to get through.

Makes sense. Will put together a PR with a test for now.
Can I check what you mean by "save" the peer state? The peer state would stay in memory unless removed, but do you mean storing it somewhere else?


Making Application Gateway rule priority a required field

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[x] SDK of Java
[x] SDK of Js
[x] SDK of Go
[x] PowerShell
[x] CLI
[x] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@vinaymundada27 please move your changes to the newer api version 2022-01-01. that's the most important for this PR

@vinaymundada27 , please fix CI check errors. In addition, follow above breaking change instructions to get approval.

@vinaymundada27 , model validation error need to be fixed.
https://github.com/Azure/azure-rest-api-specs/pull/19008/checks?check_run_id=6382907004

'Priority' field cannot be made required since Application Gateway V1 SKU and V2 SKU have the same api spec but V1 sku does not support this field and would break the V1 gateways. Only V2 sku needs to have the 'Priority' field as mandatory and there is no way to conditionally make the field optional/required based on the SKU. Hence closing this PR without merging.


feat(curriculum): add css-typography quiz

Checklist:

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Closes #56188

I have added questions for the CSS Typography Quiz. I have not tested this application on my local machine because I am developing this on Windows. However, I consulted with @naomi-lgbt , and they informed me that I am allowed to submit the PR without local testing.
If any changes to the questions are needed, I am happy to make adjustments as required.

request: do not keep closing and opening PRs, it creates a lot of unnecessary noise

request: do not keep closing and opening PRs, it creates a lot of unnecessary noise

do you want me to close this PR?

no, I just asked you to stop closing and reopening, keep this one and don't close and reopen again please

no, I just asked you to stop closing and reopening, keep this one and don't close and reopen again please
okay sure
last one I closed because it was not in proper format given by you

you can edit the title instead of closing and reopening a PR

You also do not need to make a new PR if you are asked to change something in the code, there you will need to push a new commit

Before I can review this in-depth, all code needs to be between backticks so our parser renders it in code tags. I've left a couple of examples.

Sorry for that

@a2937 I'll do the require changes

Hey @Dhairya-A-Mehra,
Any progress on addressing requested changes?

Hey @Dhairya-A-Mehra,
Any progress on addressing requested changes?

I will be committing the required changes in a few hours.

You still have yet to respond to Ilenia's suggestion.

Oh, I am extremely sorry.

Hi @Dhairya-A-Mehra. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

Hi @Dhairya-A-Mehra. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍 We are happy to accept these changes and look forward to future contributions. 📝

Thank You all for supporting me through this journey of contributing in your organization.


Redux-Autoform features proposal

I want to create this issue to be used as a thread for discussions about features or improvements over the redux-autoform API.
About a lot of exchanges we got the following list:

Make the library as a core and UI agnostic.
Make small git repositories for differents UI types components and expose an index.js api.
Make a git project as boilerplate for those collaborators who want to add it's own ui types.
Create a homepage and update the documentation and make one demo per ui git project.
Re define the way to declare the schema to make it more easier to read, and make a util class to treat as an array.
Add support for Wizard Style form.
Define how styles per ui type project should be managed. Modular CSS? Inline styles with the help of radium lib?
Migrate redux-form from v5.X to v6.X when released and full tested.
Add support for file-upload components.
Fix codecov and coveralls to view % of test coverage
Fix travis-ci and greenkeeper

Well, if I forget something else please add it! :)

That's a good compilation.
The UI project should be a "factory" (not necessarily called that way) that should be able to provide components given a "mode" and a "type" (this is based on your own idea). We can support 3 modes that I can think of right now: "edit", "details" and "search".
We can even get more flexible, I mean... What if the factory gets a "mode" and a "propertyMetadata"? This way... the factory can provide a TextBox if the type is "string" and the length is smaller than 30 characters and a TextArea otherwise. This is maximum flexibility for the factory.

@andrerpena I'm completely agree about the UI project as factory, and think about how to make it as flexible as possible.
We need to discuss about how to make the Styles from the UI projects as flexibles as possible too.

Just created the under-development label. Please assign yourself to the task and add this label so I won't touch it. Does that make sense?

@andrerpena cool! I will use it, so we can now what we have assigned!

@andrerpena I have created three repositories, with @danigomez, we will try to solve out how to extract the UI to different projects.
The projects are the following ones:

One for material-ui
One for bootstrap-ui
One for boilerplate, it will work as starter kit for other UIs extensions

We are going to work on those git repositories, and then we are going to solve out how to integrate them with redux-autoform itfself! :)

Amazing job. Let me know if you need any help.

Bootstrap-ui seems to be easy to extract because it's already done, so we will start with this, and then we will go for material-ui!
If I need some help I will let you know!

You are extracting the Bootstrap UI as is right? After that I can help making the enhanced factory that supports "mode", ok?

Yes, I'm extracting as is! Good, thanks! :)

@andrerpena could you guide me a little bit on how to publish a git repository into npm? :)

@andrerpena we are going to do something like this in redux-autoform to integrate the other ui libs:
class UIManager {
  allowedUIs = [
    'bootstrap',
    'material-ui'
  ];

  factoryTypes = {};

  constructor() {
    const { allowedUIs, factoryTypes } = this;

    allowedUIs.forEach((value) => {
      factoryTypes[value] = require(`redux-autoform-${value}-ui`);
    });
  }

  getFactory(type) {
    return this.factoryTypes[type];
  }
}

what do you think?
Other think I want to ask you is that if we can create a branch directly in this project and work on it. We can define a milestone and then create a branch for this milestone and keep working till this version it's complete.

In order to publish an NPM:

Log into npmjs.com and create a user
Make sure you have a proper packages.json for your project, other wise type npm init
Type npm adduser or npm add user to login
Type npm publish.

It's quite simple

@JonatanSalas , sorry, I was thinking differently.
I don't think you need an UI manager, you just need import whatever factory you want and use it.
Example:
import materialFactory from 'material-factory'; //this came from the separate repository
...
render() {
    return <Autoform factory={materialFactory} />;
}

I mean.. AutoForm is now 100% agnostic of your factory.
After you do it, I'll work on improving the factory so it will support "mode" and add flexibility.
Does that make sense?

@andrerpena, I'm thinking the code in the way that a lib user only type something like:
class App {
  render() {
      return <Autoform type="material-ui"/>;
  }
}

In this way, you abstract the developer that use the library from the concept of factory, and you let autoform to manage internally the factory creation.
In this way we add a bit more of responsability to redux-autoform, but since the ui is agnostic from the core that's not a big trouble, and with this we gain a more clearer API.

Can we agree on an intermidiate solution?
We give the user 2 options:
If you do this:
class App {
  render() {
      return <Autoform ui="material-ui"/>;
  }
}

... than you can operate your magic and dynamically import the factory. But there's still the case in which the user is importing a homebrew factory that is not an NPM module, because of that, we should probably be able to import manually, using the same variable.
class App {
  render() {
      return <Autoform ui={someUiThatImImportingManually}/>;
  }
}

Totally agreed on the intermediate proposal! :) Let's go for this approach!

@andrerpena what about the work in branches from this project? Do you think it's good? Or you want us to fork and submit PRs? Let me know it! :)

I don't really care if you submit PRs or directly commit to master as long as we're aligned on what and how you're doing stuff. As for branches.. I only use feature-branches for medium-to-complex features. Otherwise I just commit to master :)

@andrerpena we have a trouble with  @danigomez trying to publish a npm package, could you help us?
He got this error:
C:\Proyectos\OpenSource\ReduxAutoFormBootstrap\node_modules\redux-autoform-utils\src\index.js:2
export * from './localization/dateLocalizer'
^^^^^^
SyntaxError: Unexpected token export
We are using es6 syntax, previously to publish the code on npm, we should transpile it to es5?

Oh yes defnititely...
RAF has a command called build-lib. You always have to call build-lib before publishing. You also have to make sure that you didn't publish the current version already. I mean, every time you publish, you got to go to the packages.json file and change the version.

@JonatanSalas , the build-lib NPM command on RAF relys on a Node script that I've implemented. You should look into it from RAF and copy and paste inside each of the UI projects you are creating

@andrerpena thank you so much! :smile:

@JonatanSalas , also, don't forget the .npmignore file, because the src folder shouldn't be publish, but the lib folder which is generated by the build-lib script.

@andrerpena I will start to migrate all the issues from ui to the ui libs git repositories, do you agree?

@JonatanSalas Thank you very much.. That makes all sense.

 We are doing our best! :smile:

Hello!, I just published the first version of redux-autoform-bootstrap-ui and redux-autoform-utils!,
I moved the localizers, helpers and ComponentFactory to utils(After properly tested we should remove those files from redux-autoform and use the ones that are in redux-autoform-utils module).
Now those can be used in core and any other UI to create new implementations. :smile:

I'm developing in redux-autoform a branch that makes the code to work with your npm packages @danigomez, if I finish it then I will try to merge with master the changes..

I come here again to talk about the advance we have so you know it. This are the tasks that we have completed:

[x] Make the library as a core and UI agnostic.
[x] Make small git repositories for differents UI types components and expose an index.js api.
[x] Make a git project as boilerplate for those collaborators who want to add it's own ui types.
[x] Fix codecov and coveralls to view % of test coverage
[x] Fix travis-ci and greenkeeper
[x] Re define the way to declare the schema to make it more easier to read, and make a util class to treat as an array.

This are the pending tasks:

[ ] Create a homepage and update the documentation and make one demo per ui git project.
[ ] Add support for Wizard/Questionnaire Style form.
[ ] Define how styles per ui type project should be managed. Modular CSS? Inline styles with the help of radium lib?
[ ] Migrate redux-form from v5.X to v6.X when released and full tested.
[ ] Add support for file-upload components.

Since we have the other issues active I will close this one. Because the biggest changes that we want to make in AutoForm just finished.


passing without else statements

Challenge Logical Order in If Else Statements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function orderMyLogic(val) {
  if (val < 5) {
    return "Less than 5";
  }

  if (val < 10) {
    return "Less than 10";
  }

    return "Greater than or equal to 10";

}

// Change this value to test
orderMyLogic(7);

Passing tests without the desired else statements.

@hathcode This isn't a github issue. Please discuss this on the Gitter or Forum. If you think something else is wrong feel free to elaborate and we can discuss further.

@hathcode Thanks for reporting this!
As the else block can be removed when a function involves returns, this is valid code.
The challenge doesn't ask for the else block specifically, it only asks for the right functionality - which this code fulfills.
I'm closing this for now, but please add comments if you have further feedback.
Happy coding! :blush:

I'm not asking for help, Maybe I should have clarified further in the post.
Perhaps I inferred something from the directions I should not have.  As I understood it when I completed the challenge, else statements were required.  If that was the case, then a case passing without else cases is a bug, hence the posted issue.
  If that is the case, there is no issue.  I guess I was just in "if/else" mode from the previous challenges!
My bad :-)


Chore: add test case for empty file #6

Marked pending since functionality is not yet available.

This is a good start but it looks like it's not reproducing the error in #6. Can we correct the test so it does?

@twolfson, I think you're referring to my usage of Mocha skip() on the test? I prefer skipping failing tests since failing tests make it difficult to make unrelated changes and they still show in the report as "pending". I've removed the call to skip() :]

Ah I totally missed the skip the first time. The tests look good now. Can
we add a patch to the code as well in this PR?
I prefer to land patches and tests in the same PR to prevent logical
discontinuity (eg forget to test an edge case)
On Mar 15, 2017 10:15 PM, "Stephen Niedzielski"<EMAIL_ADDRESS>wrote:

@twolfson https://github.com/twolfson, I think you're referring to my
usage of Mocha skip() on the test? I prefer skipping failing tests since
failing tests make it difficult to make unrelated changes and they still
show in the report as "pending". I've removed the call to skip() :]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twolfson/css-validator/pull/7#issuecomment-286960168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3FWP9HteMVXdex-6Y5OjvrRiqkJMsyks5rmMVbgaJpZM4MezDd
.

Looks good, mostly nitpicking on coding style/arrangement. Going to do the same commandeering business again

One more issue that came up during comandeering -- we didn't handle blank check for URIs. I have added that in now and will add a test as well

It turns out we never tested URI support which lead to a whole bunch of refactoring. Everything is green now which is nice :+1: This has been landed/released in 0.8.0. Thanks for the PR!

@twolfson, thank you!


HDDS-9351. ManagedChannel not shutdown properly in TestRootedOzoneFileSystemWithFSO

What changes were proposed in this pull request?

Add a missing close call for a FileSystem instance
Close output stream in testLeaseRecoverable(), ignoring KEY_NOT_FOUND (see HDDS-9358).  Also in two other test classes that had the same pattern (although I haven't yet seen ManagedChannel warning from those).

https://issues.apache.org/jira/browse/HDDS-9351
How was this patch tested?
TestRootedOzoneFileSystemWithFSO had no not shutdown properly warnings in 10x10 runs:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6335324968
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6335857380

@adoroszlai , thanks a lot for fixing this!

Thanks @szetszwo for reviewing and merging this.


chore: bump safe-modules-deployments

What it solves
Bumps safe-modules-deployments to latest version to add missing addresses.
https://github.com/safe-global/safe-modules-deployments/compare/v2.2.1...v2.2.4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.73%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
777

Relevant Lines:
948

💛  - Coveralls


enable checkboxes on blog posts

I added a post-processing step in the server-side data fetching process to remove the "disabled" attribute from the checkboxes and wrap the related items with spans. This was done to enable selection using CSS, as plain text elements are not counted as elements when using the ~ selector (needed to do the strikethrough thingies when checked).
To address the elephant in the room, I chose to use an HTML parser (specifically Cheerio) over regex as it offers more flexibility for adding features in the future. Additionally, a semantic HTML parser is better equipped to handle edge cases such as special characters and malformed input, which may be unlikely in this specific case but is still a good practice to follow.
https://user-images.githubusercontent.com/8981287/229495142-aaac61e5-f5a9-44cf-8de9-fe9a04058d5c.mov
fix #814
(it's late don't hate on my chatgpt generated pr)

@jaasonw in the future, can you please leave it to the conversation opener to resolve their conversations? Thank you.

👍

@jaasonw hoping all is well. Any updates on this PR?

@jaasonw Any chance of this being worked on in the future?

idk maybe one day but i can close it for now xd


Fix fabric8:push goal in auto mode

fabric8:push goal seems to be failing due to no docker deamon
initialization being done. The cause seemed to be function isDockerAccessRequired()
which was ignoring the fact that docker access is also used in openshift mode. If we
don't specify any mode explicitly it is set to RuntimeMode.auto.
I think we should disable docker access check only when JIB=true

@toschder : I've created this PR for your issue. Could you please check if it's working for you?


Cleaning up screen spam when running unit tests

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Missing CHANGELOG

This library has been recently upgraded from v0.1.3 to 0.2.0, which introduced quite a few breaking changes (such as the NonceManager now being NonceManagerMiddleware).
It would be nice if there was a CHANGELOG.md file documenting (at least) the high-level changes.

That's a good point - I unfortunately made quite a few changes since the previous release because I was still exploring how I'd like the library to look like (e.g. the middleware stuff). As a result, I wasn't too diligent with keeping a changelog across releases.
Do you have any recommendation for an automatic changelog generator? It'd be nice if release/changelogs could be fully automated in CI when there's a release PR

That's a good point - I unfortunately made quite a few changes since the previous release because I was still exploring how I'd like the library to look like (e.g. the middleware stuff). As a result, I wasn't too diligent with keeping a changelog across releases.
Do you have any recommendation for an automatic changelog generator? It'd be nice if release/changelogs could be fully automated in CI when there's a release PR

Do you have any recommendation for an automatic changelog generator?

I fiddled with semantic-release/changelog but I wasn't satisfied. It was too opinionated. Also it has to be added as an npm dependency so that may be out of scope for a Rust project.
What I can recommend though is keepachangelog.com. It does require you to manually keep track of the changes, but their skeleton file does the bulk of the work. The format is nice, simple and logical.

Do you have any recommendation for an automatic changelog generator?

I fiddled with semantic-release/changelog but I wasn't satisfied. It was too opinionated. Also it has to be added as an npm dependency so that may be out of scope for a Rust project.
What I can recommend though is keepachangelog.com. It does require you to manually keep track of the changes, but their skeleton file does the bulk of the work. The format is nice, simple and logical.


Feature: Inspect negotiated SSL properties

It might be beyond the scope of this tool, but a way to inspect the negotiated SSL ciphers and server certificate on https tests could be valuable.
https://stackoverflow.com/a/48675492/1050536

This is currently implemented in the Get-SSLCertificate cmdlet. The functionality is not part of the Invoke-HttpUnit cmdlet.

TODO: Add a plan parameter to run Test-SSLCertificate and add the details to the results object.


Enhance Course Content and Refactor Project Structure

Summary
The intention behind these updates is to provide learners with a comprehensive understanding of open source contributions and the fundamentals of Git and GitHub. Before contributing to an open source project, it’s essential for learners to grasp these foundational concepts. The Welcome page has been reorganized to clearly explain key topics such as open source, its benefits, basic Git and GitHub terminology, and their usage.
Changes
1.Added a "Next Lesson" file at the end of each chapter to enhance navigation.
2.Included detailed explanations of open source contribution fundamentals.
3.Added fundamental concepts of Git and GitHub.
4.Defined various types of software.
5.Updated course description and provided motivation.

👋🏼 Thank you for your issue. This content would be out of scope for GitHub Skills. I'd recommend looking at our public docs at docs.github.com, the repository is https://github.com/github/docs.

👋🏼 Thank you for your issue. This content would be out of scope for GitHub Skills. I'd recommend looking at our public docs at docs.github.com, the repository is https://github.com/github/docs.

Ohk , Thank you 😊


make zkbtc CLI check if it is up-to-date

not sure how we can do that, but since we're changing a lot of things these days, better make sure that the CLI understands that it is out of date (if it is)

Step one would be to make releases to GitHub I guess. Shameless plug but can take a look at how Starkli does releases.

we accept PRs :D

Yeah just sent my first one: #17.


Branch.1

-updated the license year
-added go.mod
-added go.sum

Nice!  Thanks Esad @esadkrs.
Merging.


Interest in new solvers

I have two classes of solvers I'm implementing with diffrax which I thought could be good to actually just put in diffrax, but I wanted to check if there was interest in having them in diffrax before I go through the process to get them ready for a PR.
First are some high weak order SDE solvers (Fixed step weak order 2.0 for Ito SDE solvers, e.g. SIEA etc. from https://docs.sciml.ai/DiffEqDocs/stable/solvers/sde_solve/)
Second are some diffusion model specific solvers (e.g. https://arxiv.org/abs/2105.14080). These come in two flavors: solvers that are applicable to general SDEs (or general SDEs of a certain type of noise) but perform well/better on diffusion models and solvers that are specific to (reverse) diffusion processes.
Would any subset of these be interesting to have in diffrax?

Definitely!
We'd need to think about how to correctly express solvers that are specific to certain diffusion processes, I suspect. Ideally these would throw an error if misused. (That's not crucial though.)

Awesome, I think I have 3 open PRs right now 😅 , so that should give some time to get things into a presentable shape (and think on solver representation for specific diffusion processes)

Closing to open more specific issues as we work on getting these solvers in (e.g. https://github.com/patrick-kidger/diffrax/issues/481)


Random provider - deprecated number parameter

As of version 3.3 the terraform-provider-random provider deprecated the "number" paramenter on
resource/random_password and resource/random_string.
This affects line 14 of main.tf.
May also consider changing var.unique-include-numbers to var.unique-include-numeric to match the change they are implementing.
This is now producing warnings on every plan/apply:
Warning: Argument is deprecated
│
│   with module.naming.random_string.main,
│   on .terraform\modules\naming\main.tf line 14, in resource "random_string" "main":
│   14:   number  = var.unique-include-numbers
│
│ Use numeric instead.

Thanks for updating!


Feature Request: initialize emmet config

VSCode Version: 1.10.0-insider (Japanese)
OS Version: Windows 10 ver:1607 (Japanese)

Steps to Reproduce:

install all default ( use: VSCodeSetup-1.9.0-insider.exe )
C:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\node_modules\emmet\lib\snippets.json is default

{
	"variables": {
		"lang": "en",
	...

type emmet

![tab]

change

<!DOCTYPE html>
<html lang="en">
...

request
I hope same local setting (vscode lang: Japanese )

"lang": "en" -> "lang": "ja"

<!DOCTYPE html>
<html lang="ja">
...

If users could simply edit and create emmet snippets like any other snippet language, it would be easy to change ${lang} variable among many other emmet things. (see docs here).
See #23476

@ogasawara-k Am sorry it took me so long to respond.
You can do this by customizing the snippets.json file
For example, if you want to use "lang": "ja"

Create a file snippets.json with the below content

{
    "variables":{
        "lang":"jp"
    }
}

In your User settings, add setting "emmet.extensionsPath" . The value should be the directory where you created the snippets.json
Restart VS Code

For more information on what else you can customize this way in the snippets.json file, read https://docs.emmet.io/customization/snippets/

thanks.
I'll give it a try.


API docs needs some updating

I am new to PhantomJS and am using it to convert html to pdfs.
The WebPage's API page in the wiki should have some things updated. I was trying to see if I could set margins, headers and footers to the output and was only able to get second hand information from place around the web.
It would be immensely useful if the API docs are updated to show that these parameters/settings do exist.

Could you provide an example of what it was you were doing and the information you found please @F21?

Hi @JamieMason
They were things like zoomFactor, border and custom footers and headers. I haven't had a chance to check the API docs since I opened the issue, so it is possible someone else might have added them.