Fix #563: Use Case: Huge data on an external local drive

Fix #563

Great use case! Sorry I added so many comments but they're very small changes for the most part. I would recommend to address all the small stuff but leave the more significant ones until after the discussions in https://github.com/iterative/dvc.org/issues/563#issuecomment-522171263 and maybe #566 have some conclusions. That's up to @shcheklein though. Thanks!

Thanks for the feedback and the comments. I will review them carefully one by one and will try to resolve them.
Initially I just want to clarify a misunderstanding. What I had in mind was the term "external hard drive" (or "external drive"), having the meaning that is described in these articles:

https://whatis.techtarget.com/definition/external-hard-drive
https://www.lifewire.com/what-is-an-external-drive-2625867

I don't know how the term "local" slipped in. Maybe I wanted to say that this is not a "network drive" or a "remote storage". Or maybe I was influenced subconsciously by the user guides external-outputs and external-dependencies, which use the term "local".
By the way, maybe I should link the term to this page: https://whatis.techtarget.com/definition/external-hard-drive in order to clarify the meaning for the users that may not be sure what it means.

I have tried to fix most of the issues. Please let me know if I have missed something important.

You're the best Dashamir! I resolved a bunch of my earlier comments but some are still pending and I opened a few more. Most are small details though, so lmk if you need help addressing them since I can do it also.
Let's see how Ivan feels about this new version 🙂

Thanks @jorgeorpinel. I am going to review it again (because I also notice some typos).
But please don't get upset if I don't always agree with your suggestions. Some of the things are quite debatable and an endless debate for such small things seems time consuming and not productive to me.
So let's agree to resolve them like this: If I don't agree with one of your suggestions I keep it as it is, then you can override it in another PR if you strongly feel that it should be changed, and I will not dispute your decision.

Sure, no problem on my side. Any reviews that are left open when Ivan merges this PR I will take care of myself. Thanks

I think that data is a shortcut for data files and directories or data file or data collection. So, depending on the context it can be singular or plural. It is not exclusively singular or plural but it can be both of them.
Are we going to fight about miniscule issues? This does not make our docs neither better nor worse. I don't agree with @jorgeorpinel on this issue, but I don't mind if he revises my docs afterwards (he said that he can do this).

@dashohoxha first of all, I can assure you, no one is trying to "fight" for anything. I hope that we all trying to come up with some consensus here and make docs better.

This does not make our docs neither better nor worse.

It makes docs worse. It's a matter of us being consistent in the way we use terms, format things, etc, at the very least (which is very important), and writing texts that are easier to read.

he revises my docs afterwards (he said that he can do this).

No. I believe, it's a bad practice. It creates some weird dynamics in terms of trust and time we have to allocate to revise stuff. We should be able to come up with a style guide in this simple case.

It is not exclusively singular or plural but it can be both of them.

@jorgeorpinel shared a link to the guarding style guide, singular is at least 10x common than plural if you Google it (in variety of contexts), we use it as a singular form consistently everywhere.
If you feel there are strong reasons for us to reconsider this and use a plural form, please create a separate ticket for this to discuss, to understand the motivation behind this change and revise it across all the docs we have.

We should be able to come up with a style guide in this simple case.

This may be a good idea (although I haven't seen any projects that have a writing style guide for the docs).
If you insist, I can use data in singular, although I am not convinced that this is right (on the other hand, as I said, this is a miniscule issue that does not deserve a debate).
About the workflow, I believe it may be better if we merge quickly and then correct later (if necessary), for two reasons:

It is easier to review a rendered document page, than to review a markdown code, in a small textarea, where lines may also be broken. For example I have noticed that some review requests have been a result of missing the correct start and end of the <detail> blocks.
The review process does not block working with the next page (it is not recommended to have multiple open pull requests).

I replaced /mnt/data with /mnt/external-drive to see how it looks like. But it can be changed or reverted if needed.

@dashohoxha

It is easier to review a rendered document page, than to review a markdown code

There are two easy ways to mitigate this. If you use branch (let me know if you need permissions for this) instead of a fork, Heroku will be deploying a PR for you automatically like this:

(I did this manually this time)
Second way - run the Node server locally. It's quite straightforward and is described in the documentation contributing guide.

The review process does not block working with the next page

Not necessarily. It's fine to start working on something next when one PR is under review.

I replaced /mnt/data with /mnt/external-drive to see how it looks like. But it can be changed or reverted if needed.

I don't see how does this change it. I haven't seen projects named external-drive. I haven't seen git init is being run in the root of the drive. Again, may be I'm missing the whole point here still.

I haven't seen any projects that have a writing style guide for the docs

there are lot of projects. One of the nice examples: https://docs.mattermost.com/process/documentation-guidelines.html

If you insist, I can use data in singular, although I am not convinced that this is right

Thank you! 🙏
Again, I don't want to discourage you from suggesting new stuff, improvements, etc. You have brought a lot of good topics to think about already.

If you use branch (let me know if you need permissions for this) instead of a fork

Yes, I think I need permissions (if no one has already given them to me).

Second way - run the Node server locally.

I do it, but this may be difficult for the reviewers (if they have to clone my repo).

Not necessarily. It's fine to start working on something next when one PR is under review.

Maybe, but if it happens that both PRs are working on the same files, this may create conflicts. It has happened to me in the past. This is why I say it is a bad practice. The conflicts can be resolved of course, but it is an annoyance.

I don't see how does this change it. I haven't seen projects named external-drive. I haven't seen git init is being run in the root of the drive. Again, may be I'm missing the whole point here still.

This is not usual, but it is a possible solution. In the next paragraph I say that this may not be preferable. What would you suggest about it? Should we not mention it at all?

One of the nice examples: https://docs.mattermost.com/process/documentation-guidelines.html

It is nice the note on top of it, because I think that the very idea of having to obey style rules may actually impede the contributions. On the other hand, I expect to be payed for this job, so I don't mind if I have to follow grammar rules, even if they are stupid. Sorry for being brutally honest.

Again, I don't want to discourage you from suggesting new stuff, improvements, etc. You have brought a lot of good topics to think about already.

Thanks for letting me know. Because sometimes I feel like not everyone appreciates my comments and maybe I am being perceived as a troublemaker.

@dashohoxha

Yes, I think I need permissions (if no one has already given them to me).

Done! I've added you to the collaborators. If you use branches it's being deployed automatically and it's very easy to review it.

The conflicts can be resolved of course, but it is an annoyance.

Agreed. I would try to avoid working on the same file. Especially if they are being changed a lot.

What would you suggest about it? Should we not mention it at all?

Probably, yes. I need a little bit more time to do provide you some constructive feedback on this PR. It's not your problem, it's even for me not easy to come up with a good structure and language from the top of my head for this external stuff. Especially considering all other ways of managing "external" data. I'll try to do a full review once again and be more constructive.

No contribution will be rejected due to non-conforming style, although it might be edited.

Totally agree with this! And that's what we do with external contributions. You are part of team for this period of time and consider you as an "internal" contributor.  Sorry for being brutally honest.

I respect your directness, but please respect other people's opinion and be constructive as much as possible.

Because sometimes I feel like not everyone appreciates my comments and maybe I am being perceived as a troublemaker.

Sorry, that you see it that way. On contrary, I really like the topics you've brought on the discuss.dvc.org (dvc run complexity, for example). It resonates very well with what we have been discussing internally.
 We are traveling now and our schedule is hectic a little bit that's why it feels slow and review is not deep/actionable.

I am not at all in a hurry. I have not finished reading yet some tutorials and other things (about DVC).

Woops this has become a looong conversation. I haven't read all the recent comments but please lmk when there are changes that address my review comments and I will. As for outdated or resolved comments that just make this PR super long, one option I recommend is to just hide them:

Although I think Github will automatically start hiding stale comments after a while.

Hi. Is this PR still in process? Relevant? Seems abandoned. Thanks

p.s. asking because I could address a lot of my own comments above to get it moving forward but don't want to waste time if this is no longer valid or a priority.

@jorgeorpinel it's an important PR. I just don't yet have a clear Managing External Data section structure in my head and where will this PR (or parts of it) fit into. Along with https://github.com/iterative/dvc.org/pull/455 for example that is also almost done.

Alright, I addresses all my own feedback. Please lmk if you need more help reviewing this one again. I'll unsubscribe for now.

Closed in favor of: https://github.com/iterative/dvc.org/pull/732


Feat/mobile/notifications

Description
Notifications settings page made.
Addresses #133
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Still yet to fix linting errors and create test for this page. Will do that in the morning.


Imports not resolved in a zipped yang module set

I uploaded a zipped set of yang files that depend on each other (import each other). However imports between the uploaded files were not resolved. I got a lot of error messages like:
err : Importing "_3gpp-common-measurements" module into "_3gpp-common-managed-function" failed.
Is it possible to solve this? How?

Thank you for reporting this.
Could you provide these modules or are they proprietary?
If not would you be able to copy paste at least the output that you have received?
regards,
Miroslav Kovac

<EMAIL_ADDRESS>This is a set of 3GPP YANG modules.

Ok I have identified the problem. It seems like we are not getting dependencies for confd. But this is only true for modules that are unknown for yangcatalog. Fix is on its way.
Thank you

this is resolved here
It will be in production code in next release

Thanks, Balazs


TensorFlow 2.4 Contains References to nocopts, which is No Longer Compatible with Bazel

In e5f8043742f927ed0e1711bb48f3e1a153b7a997 and ddde447e792231cdf83b435b0eeb59dd59bf4044, among other commits, support for nocopts was removed to enable the upgrade of Bazel to 1.0 and above.
However, there are still a few references to nocopts in the r2.4 branch:
$ git grep nocopts
tensorflow/lite/micro/testing/micro_test.bzl:        nocopts = "",
tensorflow/lite/micro/testing/micro_test.bzl:        nocopts: list of gcc compilation flags to remove for this rule
tensorflow/lite/micro/testing/micro_test.bzl:        nocopts = nocopts,
tensorflow/tensorflow.bzl:    # -fno-exceptions in nocopts breaks compilation if header modules are enabled.
tensorflow/tensorflow.bzl:    # -fno-exceptions in nocopts breaks compilation if header modules are enabled.

These should probably be removed for consistency and to avoid confusion.

https://github.com/tensorflow/tensorflow/pull/47055 removed tensorflow/lite/micro/testing/micro_test.bzl.


Dinamic routes not working in caddy  + centos7 server

Hi, I am having an issue deploying a static site, I have caddy installed in my CentOS server. There, I have some other sites running and everything is ok.
Now, I want to be able to use routes with parameters, for example:mysite.com/products/:someid
The site was built using React.js (create-react-app+react-router-dom) and the static file generated using npm run build
I can open the index and some other pages that are not receiving parameters in the URL
this is the routes code:
render( ) {
return(
            <Router>
                <Switch>
                    <Route  exact path="/" render={() => (<Redirect to="/home"/>)}/>
                    <Route path="/dashboard" exactly render={() => {return(<Dashboard/>)}}/>
                    <Route path="/settings" exactly render={() =>
                    {return(<Config defaultToggled={this.state.menuRight} onToggle=
                     {this.handleMenuPosition}/>)}}/>
                    <Route path="/member" exactly render={() => {return(<Member/>)}}/>
                    <Route path="/office" exactly render={() => {return(<Office/>)}}/>
                    <Route path="/property" exactly render={() => {return(<Property/>)}}/>
                    <Route path="/tools" exactly render={() => {return(<Tools/>)}}/>
                    <Route path="/home" exactly render={() => {return(<Home/>)}}/>
                    <Route path="/restorepassword/:email/:token" exact component={RestorePassword}/>
                    <Route path="/confirmaccount/:token" exact component={Home}/>
                  </Switch>
            </Router>)
}

my question is , this is a react-router-dom problem?,
Something missing in my definition of the routes?
the route example: http://demo.com/confirmaccount/123-122-a3    return 404, in dev mode this is a valid route

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


fix: update semantic-version pkg-trigger release

:tada: This PR is included in version 2.0.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[*] Fixed: ViewPropTypes will be removed from React Native. Migrate t…

ViewPropTypes exported from 'deprecated-react-native-prop-types'

We need this on RN 0.69

@imekinox let me take a quick look. I am sure this is an easy fix.

Thank you @augusto-booment I found a work around until the library gets updated.

Can this be merged? I'm having to modify this file on every npm i or yarn.

I just pushed the latest version with that change. Let me know if that works for you guys.


Support of FTP without secure layer

Do you provide support for regular FTP?
Thank you.

Currently not and we are planning it for next release. It requires changes in underlying library used by this connector.
It would be great if you add this feature and create a PR

Hello,
It looks like it is immediate with Spark lib.
Check out this code sample from the Databricks book.
https://github.com/databricks/learning-spark/blob/master/src/main/scala/com/oreilly/learningsparkexamples/scala/BasicLoadTextFromFTP.scala
I think we could just write a fallback in your library to support FTP.

@mycaule Thanks for the info. Will update this library in the next release

Better not use FTP.


Qiyu Browser

Qiyu Browser - https://github.com/WhichBrowser/Parser-PHP/issues/178

Coverage remained the same at 100.0% when pulling a7ae65d8aad331ce23e203f96ed63e6f0a08abcd on ayumi-cloud:Qiyu into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.


Default values of width and height are different from default values of the canvas element on the w3c document

The react-chartjs-2 set 200 to width and height of the canvas by default.
A W3C document define them 300 and 150 as default value.

The width attribute defaults to 300, and the height attribute defaults to 150.

The Chart.js is not set width and height of the canvas by default.
As a result, the aspect ratio of the canvas is 2.
But the react-chartjs-2 is set 1 to the aspect ratio of the canvas.
I am confused by this.

Hey @ledsun ,
Thanks for reporting, should be sorted now.
Appreciate your time.
Goran


[BUG] TF Runs out of memory with BYO synthetic dataset

Bug description  CC: @rnyak
TF OOMs during the fit() call for a synthetic dataset we are trying to experiment with.
Please see the attached schema.txt (please convert to schema.pbtxt after downloading - Github doesn't support uploading uploading .pbtxt files) for the schema of the synthetic dataset we are experimenting with: schema.txt. Our dataset is on the order of billions of rows
Expected behavior
The model training should not OOM.
Environment details

Merlin version: 0.3.0
Docker image built from merlin-training:2022.04
cuda: 11.6
GPU: Just one V100 with 16GB of RAM

Additional context

The model we are trying to train is a DLRM from the quick start example.

model = mm.DLRMModel(
    schema_train,
    embedding_dim=64,
    bottom_block=mm.MLPBlock([128, 64]),
    top_block=mm.MLPBlock([128, 64, 32]),
    prediction_tasks=mm.BinaryClassificationTask(
        schema_train.select_by_tag(Tags.TARGET).column_names[0]
    ),
)

model.compile(optimizer="adam")
model.fit(train, batch_size=4096*2, epochs=1)

Changing the optimizer to something like adagrad and sgd does let the fit() call last longer, but it eventually still OOMs. We have also tried mixed precision training, which helped, but still would eventually fail.

Additionally, from the provided schema, please remove remove_col1 and remove_col2 with schema.remove_col().

We had to set os.environ["TF_GPU_ALLOCATOR"]="cuda_malloc_async" for training to work even a little

We have already reduced some of the column data types from int64 to int32 to save space.

EDIT:
6. I've also tried reducing the batch size to something smaller, like 64 and training would still eventually fail. I did not, however, try reducing the the embedding_dim. But at the same time, memory needed for the embedding tables are around 5M * sizeof(float) * 64 = 1.28GB where sizeof(float) = 4, and this multiplied by 3 for adam optimizer states is still only <4GB, so that should still leave 12GB of RAM to train, so it's a bit peculiar.

@benfred , I understand that you have already started supporting this bug. Please update the ticket.

@shoyasaxa the schema file is missing item_id tag. I'd appreciate if you can tag the features item_id user_id, item and user accordingly, and share a schema file again. thanks!

@shoyasaxa I think this was resolved by adding part_size arg to Dataset class as in this example:
Dataset(os.path.join(output_path, 'train', '*.parquet'), part_size="500MB").
can we close this issue? thanks.

Yes - thank you!


Add vim mode for yank and begin-selection

In Mac OSX 10.11.6 El Capitan, if is not set mode-keys for vi then I can't perform begin-selection (v) or yank (y) in vim-mode.
Cheers

The way I wrote the configuration is that people not so fond of vi/vim get annoyed. But people loving vim will likely have their EDITOR or VISUAL environment variable set to vim.
This is as per tmux's manual:

mode-keys [vi | emacs]
Use vi or emacs-style key bindings in copy and choice modes.  As with the status-keys option, the default is emacs, unless VISUAL or EDITOR contains `vi'.

So I'm not in favor of adding set -g mode-keys vi in .tmux.conf.
Can you confirm setting your EDITOR or VISUAL environment variable to vim works? (which by the way should be beneficial to other programs than tmux)

I understand that should not be dependent on an editor.
Let me test it and write the result.

export EDITOR="vi" and work fine. I will close PR.
Cheers


Add a landing page for any website

Add a landing page of any website using HTML CSS javascript

Hay, I would like to work on it.

Sure bro you can send me pr pls star this repo and follow me

Can i still add a project in this?

sure

Hi @Shubham56-droid , even I would like to work on this.

you can  also work on  this issue add as many as landing page u want and pls star this repo and follow me on  github


Refactored log statements for OCSInitialization and PersistentVolume controllers

Signed off by: Priyanka Jiandani<EMAIL_ADDRESS>

/cc @umangachapagain  @jarrpa

Can you add go.mod and go.sum changes in a separate commit?
Thanks.

done

Can you add go.mod and go.sum changes in a separate commit?
Thanks.

done
Not sure, why the 1st commit still shows go.mod and vendor/modules.txt changes.

/retest


fix(PSF price): GET /entry/cost/psf returns token ID

:tada: This PR is included in version 3.1.11 :tada:
Your semantic-release bot :package::rocket:


Fix typo in README

I believe you wanted to say "omit" instead of "emit"

Good catch. Merged. Thank you!


timeline.coffee has dimensions hardcoded, shouldn't it be reactive to size of grids?

as the title states, it seems the size is hardcoded in the timeline.coffee, so it fixes it at that size and when a grid layout is setup that is different, then the widget doesn't fit the new layout.

An additional problem or constraint of using this widget is the height is dynamic based on the events in the timeline_data.yml.

Yes, i agree that was somewhat hacky on my part.  Welp, this is open for a PR.


feat(android): support project variables

This PR allows specifying the versions of the dependencies on Android.
This should help #199.

@robingenz Can you explain how it will help #199 and if it is required to do this. It seems interesting but i would like to understand the reasons behind can you help me

@jepiqueau Sure! This feature allows you to set the version of the Android dependency yourself.
Example: https://github.com/capacitor-community/sqlite/issues/199#issuecomment-992626461
You can set androidx.security:security-crypto:1.1.0-alpha03 as default. However, if someone needs androidx.security:security-crypto:1.0.0, then they can add the following to the variables.gradle file:
ext {
+    androidxSecurityCryptoVersion = '1.0.0'
}

@robingenz ok but how in the code i can test which crypto version has been selected to switch for the right code as there are some new features in 1.1.0-alpha03 not compatible with 1.0.0 ?

@robingenz in fact i tested using the 1.0.0 but it is not working with the actual code

@jepiqueau I didn't know you were using a new feature. In that case it does not work as far as I know.
Of course, it can still be helpful if you want to use a different version that is compatible with the plugin for other reasons.
Either way, this change should not hurt.
But it is no problem at all if you reject the PR. 😄

@robingenz Thanks for all your explanations, i never though about using project variables. I will reject the PR but thanks again to share some of your knowledge with me this is what i am looking for


Use shedlock-parent as BOM

Mainly references springdoc/springdoc-openapi#1405
If I use this library then I should declare two dependencies like below:
implementation 'net.javacrumbs.shedlock:shedlock-spring:4.35.0'
implementation 'net.javacrumbs.shedlock:shedlock-provider-jdbc-template:4.35.0'

But there are shedlock-parent artifact that can work as BOM so we can use like:
implementation platform('net.javacrumbs.shedlock:shedlock-parent:4.36.0')
implementation 'net.javacrumbs.shedlock:shedlock-spring'
implementation 'net.javacrumbs.shedlock:shedlock-provider-jdbc-template'

(Since I'm not using maven, I have no idea how maven users can utilize this functionality)
Also, I think showing child artifacts in https://mvnrepository.com or somewhere is better than only in documents or searching for a single artifact from the repository.

Ref: https://mvnrepository.com/artifact/org.springdoc/springdoc-openapi/1.6.3 (search for 'springdoc-openapi-' to see child artifacts)
Current: https://mvnrepository.com/artifact/net.javacrumbs.shedlock/shedlock-parent/4.35.0

I just found that hazelcast <= 3 support is dropped, should I also remove it from dependencyManagement? Maybe from README also?

Thanks a lot, I will look at the PR in next few weeks.
If you can send a separate PR with hazelcast 3 removal, I will be grateful.

hazelcast 3 removal have already happened in 4.34.0, so I think you meant to separate the README updates. Is it right?

Yes, thanks

Regarding the BOM, almost all users will only import 2 ShedLock dependencies. In such case I find using a variable for version easier. Why is a BOM better for you?

Right, I can use a variable, but this makes dependabot cannot recognize the version since it just tries to match regex for dependency lines. (and it's so hard that make dependabot to analyze executable scripts)
If dependabot makes two PRs for adjacent lines, merging one of it always result to conflict. :cry:

You are right about the dependabot, I have never noticed that. I will prefer to have a separate module for the BOM, it seems like a misuse of the parent project. I will look at it.

Would soemthing like this work for you?

Yeah, cool!
I've built (maven lifecycle install) it in local with version 4.34.0 for a test.
By declaring mavenLocal() dependencies, it perfectly resolved:

Closing with hearts. 💞


redirect for logout not passing token

I've been attempting to use the token manager and hit an issue with the redirectForLogout function
On this line
mgr.oidcClient.createLogoutRequestAsync(mgr.id_token).then(function (url) {

it passes mgr.id_token but at that point that resolves to a function which means that the logout request url is incorrect?
Changing it to
 mgr.oidcClient.createLogoutRequestAsync(mgr.id_token()).then(function (url) {

means the logout succeeds
Or am I missing something?

Wow, sorry -- missed this question.
Hmm, it should work the first way. See this sample: https://github.com/IdentityServer/IdentityServer3.Samples/tree/master/source/Clients/JavaScriptImplicitClient (in index.html)


Update Fannie Mae dataset for consistency

This PR adds a schema for the Fannie Mae dataset with improved variable names and types and replaces the sample dataset in parallel with https://github.com/ursacomputing/arrowbench/pull/107. Comments by the schema document where to find more information about the data, should it be needed.

Are the test failures waiting for https://github.com/ursacomputing/arrowbench/pull/107 to be merged? Or is something else going on there?

Are the test failures waiting for ursacomputing/arrowbench#107 to be merged? Or is something else going on there?

There's something else; I'm debugging. I think types are getting changed in some places differently (for other datasets like nyctaxi_sample), and haven't yet figured out why

I think types are getting changed in some places differently (for other datasets like nyctaxi_sample), and haven't yet figured out why

oh pretty sure this is because I switched from reading CSVs with pandas to pyarrow and the type inference is different

Ok our timestamp precision consistency is not great; round-tripping we vary between timestamp[ns], timestamp[us] and sometimes timestamp[s], even when I try to enforce a schema

@jonkeane This is fixed and ready for review now


Using strlen to detect the number of bytes breaks the usage of char arrays

In https://github.com/tbeu/matio/commit/67a922f83467d694fa6e9759ac9a30b6ab82aec4 the following two lines have been added
https://github.com/tbeu/matio/blob/67a922f83467d694fa6e9759ac9a30b6ab82aec4/src/mat.c#L1116-L1118
The use of strlen needs the data to have a \0 char at the end. This is ok when the input data is a C string, but it causes segfaults when the input type is a char array.

It also causes segfaults in case the input data pointer is nullptr. This is acceptable for every other data type, as long there is a zero dimension. With MAT_C_CHAR and MAT_T_UTF8 instead, it will try to access data anyway.

The use of strlen needs the data to have a \0 char at the end. This is ok when the input data is a C string, but it causes segfaults when the input type is a char array.

That's why I set the trailing zero also for char array here: https://github.com/tbeu/matio/blob/84c8f3d67ef7493b3541ffe16fdfe007a45f3165/test/test_mat.c#L1302-L1303
Do you see any other option how to get the string length (which can be different from actual dimension)?

It also causes segfaults in case the input data pointer is nullptr.

Sure, this needs to be avoided.

It also causes segfaults in case the input data pointer is nullptr.

Addressed by fa770b2.

Addressed by fa770b2.

Thank you for the quick fix!

Do you see any other option how to get the string length (which can be different from actual dimension)?

I have been thinking about it a bit. If I understood correctly the issue reported in https://github.com/tbeu/matio/issues/164, the problem is related to strings (and also arrays) containing UTF8 chars. Since the UTF8 chars require additional bytes to be stored, it is not true that the number of bytes is equal to the size of the string. In this case, the use of strlen fixed the issue since it counts the number of bytes correctly.
Ultimately, the problem seems to be on the correct counting of bytes then, both in the case of strings and arrays, but strlen requires the \0 to be present.
From https://github.com/tbeu/matio/issues/164 it also seems that the dimensions need to be set to the actual number of chars, not to the number of bytes. So, both in the case of strings and arrays, the user is supposed to provide the number of elements he/she wants to store.
I wonder if this can be used in this case, i.e. mimicking how strlen works. In practice, it would be necessary to iterate over the number of elements, detect if the element is a plain char or a special UTF character, and count the bytes accordingly.
I was thinking maybe at something similar to https://stackoverflow.com/a/1031773, but with a different while loop condition (since while(*bytes) would require again the terminal \0) :thinking:

Fixed by 4e6cc2e. I guess I need to a release a new version soon.

Awesome, thanks!


Configurable row height

Super low priority request. I know there is an option to change the font. Could you also add an option to reduce the row height of each entry please? Which could also involve reducing the size of the app icons on the left of the process name as well. I have so many processes running that it's more than three screens' of scrolling, reducing the row height would alleviate this.
Cheers
Dhry

There's a setting named ThinRows for minimizing the row size. Enable the setting by changing from 0 to 1
For example from the advanced settings:


Add and annotate root Facet classification; align core:hasFacet

This is added in light of UCO-Profile-gufo PR 7.

@plbt5 , this is ready for your review and merge.


Broken link

[Enter feedback here]
The link in this section says that it goes to a SQL Server VM template, but it goes to a attestation provider template.
The following example is extracted from a quickstart template, SQL Server VM with performance optimized storage settings :

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12e707f1-ecfe-9d95-b37e-0b083fc907f1
Version Independent ID: f2f85556-6f17-e0c2-de47-efc23d7cb940
Content: Bicep functions - arrays - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/bicep-functions-array.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@cchapin2020
Thanks for your feedback! We will investigate and update as appropriate.

@cchapin2020, thank you for the feedback. I have updated the document which is under review.
For relevant example, please see Virtual Network creation with Diagnostic logs setting.


proxyquire used for?

Hi, thanks for your blog article.
I have a similar but using Waterline ORM, what is proxyquire used for in package.json please?

Hi,
proxyquire is used for stubbing out (overriding) methods of a dependency. A good example is given of path module on the official page.
I think it's not being used in this example project though, so I'll remove it from package.json. Or feel free to submit a PR!

Hi, ok thanks.  I'm trying to do the same thing with proxyquire. Just wondered if it was required.
Closing


Task: Design and Create Enemy weapons

Description
Task: Design and Create Enemy Weapons.
Feature: Combat Items
This task is about designing enemy weaponry. This task will involve researching different types of enemy weaponry and discussing with team 3 about what enemies will be in sprint 1. After this I will need to ideate and design weapon/s to suit the enemies. The designs will then go through some evaluation/user testing to identify which is the most appealing stylistically and logical for the game story.
Example (optional)

Part: Enemies might drop their weapons which can then be picked up by the main player. For instance, the weapon might possess the power of the enemy so when the player collects it, the player then possess that power.
Weapon Use: Enemies will use their weapons to fight back in the game and protect Atlantis from sinking.

Dependencies

[x] Types of enemies in the game are chosen (#xx)
[x] Enemies for the game designed (#xx)

Milestones
List of steps that need to be completed for this task.

[x] Research different types of weapons the enemies might use (Aug. 16)
[x] Select a style which matches the game for the weapons (Aug. 17)
[x] Sketch some rough weapons (Aug. 18)
[x] Discuss with weapons team on which items would be best for sprint 1 (Aug. 20)
[x] Create design for enemy weapons (Aug.20)
[x] User testing of the enemy weapons (Aug.21)
[ ] Finalise any changes based on user feedback (Aug.24)

Completion Deadline: Aug. 24
Documentation

Combat Items ([...wiki/Combat-Items)

Member

Madison Feddema (madi-feddema) (madi_feddema)

User testing for the weapons was completed with lots of success!
Key Notes:

all able to recognise the weapon was a dumbbell
thought a fit character would utilise the weapon
damage would be considerable to the player. Something like whacking, breaking bones, gets knocked out and dizzy and slow
when the player possesses the enemies weapon, player gains something like super strength, lots of power, someone said power of thor
one key bit of feedback is they felt the colours were too calming and needed to be more evil and harsher. To vibrant


Application Insights URL not resolvable

The URL for Application Insights in this page should be
*.applicationinsights.azure.com
instead of
applicationinsights.azure.com
When trying to resolve:
PS C:\Users\waltonchiang> nslookup applicationinsights.azure.com
Server:  UnKnown
Address:  <IP_ADDRESS>

Name:    applicationinsights.azure.com

Instead, when trying to resolve the URL in a deployed Application Insights:
PS C:\Users\waltonchiang> nslookup eastus-8.in.applicationinsights.azure.com
Server:  UnKnown
Address:  <IP_ADDRESS>

Non-authoritative answer:
Name:    eus081-breeziest-in.cloudapp.net
Address:  <IP_ADDRESS>
Aliases:  eastus-8.in.applicationinsights.azure.com
          eastus-8.in.ai.monitor.azure.com
          eastus-8.in.ai.privatelink.monitor.azure.com
          eus8-breeziest-in.trafficmanager.net

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8336877-da93-ecd6-829a-0cc068caaf29
Version Independent ID: 1e70f094-f220-92c6-7e5b-cfaf071101d5
Content: Allow the Azure portal URLs on your firewall or proxy server - Azure portal
Content Source: articles/azure-portal/azure-portal-safelist-urls.md
Service: azure-portal
GitHub Login: @JnHs
Microsoft Alias: jenhayes

@waltonchiang We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


support for IPv6

It seems doesn't work at ipv6.

There are several open pull requests which fix this which have been open for several months now but the maintainer for this repo ( @thornjad ) seems to be ignoring them

我也需要ipv6的支持

http-server -a ::  不行么？

http-server -a ::  不行么？

This is fine, but it would be better if he could print out my IPV6 address automatically.


compatible with laravel 7

+1

Laravel 7 support is highly appreciated!

I doubt that this will be merged anytime soon thought if you want you can use one of the Maintained Forks.
If you plan to actually maintain your fork please add it to the list on this repository so people can find it.

Not Working in Laravel 7.

@bumbummen99 thank you, I didn't know about the forks.


Bundle() inline verification of Intoto Statements

I'm getting started with using the Bundle() function to make a signed Sigstore Bundle from an intotoStatement.
I'm invoking similar to
statementBytes, _ := json.Marshal(*statement)
content := &sigstoreSign.DSSEData{
    Data:        statementBytes,
    PayloadType: "application/vnd.in-toto+json",
}
bundleOpts := &sigstoreSign.BundleOptions{
    ...
    TruestedRoot: trustedRoot,
}
bundle, _ := sigstoreSign.Bundle(content, keypair, *bundleOpts)
...

If I specify a TrustedRoot, then Bundle() will also attempt to Verify() before returning the bundle. But I think there may be a few problems with the setup for there.

The options artifactOpts := verify.WithArtifact(bytes.NewReader(content.PreAuthEncoding())) may not be correct to use, since it treats the "artifact" as the envelope, not as the artifact(s) that the envelope references.
verify.WithArtifactDigest() is probably more appropriate, but it does not currently support multiple artifacts.
I'm a still new to go, so I'm not sure about this one: Since the envelope's Digest (: )will be amap[string]string, and not map[string]byte does the hash need to be hex-decoded into bytes before comparison?

@codysoyland

The options artifactOpts := verify.WithArtifact(bytes.NewReader(content.PreAuthEncoding())) may not be correct to use, since it treats the "artifact" as the envelope, not as the artifact(s) that the envelope references.

That's right, this looks like a bug to me. I believe this is the correct code if you supply PlainData content, but WithArtifact/WithArtifactDigest check against the subject digest in the intoto statement.

verify.WithArtifactDigest() is probably more appropriate, but it does not currently support multiple artifacts.

Agreed. Right now, we don't support multiple subjects for a given attestation bundle.

I'm a still new to go, so I'm not sure about this one: Since the envelope's Digest (: )will be amap[string]string, and not map[string]byte does the hash need to be hex-decoded into bytes before comparison?

Yes, the digest fields are hex encoded, and therefore must be decoded to bytes before comparison, like the code you linked.
I filed https://github.com/sigstore/sigstore-go/issues/257 to capture the specific bug here.

Thanks for following up

It looks like if I use PlainData, the bundle won't embed an Envelope, which I need for my use-case.

Should we file an issue for a “WithArtifacts/WithArtifactDigests” to handle multiple subjects?

Oops! Sorry about that @ramonpetgrave64, this was definitely a mistake on my part. I believe this should be resolved with #258. I'm trying to avoid having sigstore-go signing be aware of what DSSE contains, and so that change will work with an in-toto attestation with multiple subjects.
In terms of verifying generally with multiple artifacts, one option would be to run verification with each artifact / artifact digest you care about. It certainly would be possible for sigstore-go verification to accept multiple artifacts / artifact digests, but if we're in a situation where some artifacts succeeded and others failed we'd have to think carefully about how to convey that to the user.

Thanks for fixing this so quickly.


load[_unchecked] and store[_unchecked] take an unnecessary offset parameter

Currently load, load_unchecked, store and store_unchecked essentially reimplement slicing logic with their offset parameter. They could instead take only one parameter (the slice) and have the user replace:
u32s::load(my_slice, n)

with
u32s::load(&my_slice[n..])

I believe there is no downside to doing this other than the fact that it would require a major version bump (although every version bump is major right now).

I ran into this while reworking the portable vector types API and decided to drop the offset parameter.

This was fixed in #338 .


Grift counter

Did the default Grift counter setting get changed? Personally, I think counting up was better as it shows while you go past it rather than going down as if the reports are helping. Also, I was confused at first as I thought one of the posts at front was 10.6 billion.
Any particular reason why it was changed? Could consider changing it back please?

? Not sure this is a good use of the issue tracker.

It is a perfectly fine use. I was suggesting a feature request.

Yes, I swapped the direction recently. I might change it back if I can find a good design to also show the current total (without someone having to change their grift counter settings or scroll through all posts). Until then, the page should remember your preference if you change it.

@molly I'm still getting annoyed by the grift counter (the preference change also keeps being undone, might be using too short a cookie or something?)
Would it work to just have it in the intro?

(Using the correct font of course, I couldn't find which one you used)

Some other ideas I also had were a max count ($0/$10100000000) and a new line, but this one works best IMO, as the total is a seperate thing per Mollys post.

ustedes entienden , que me hackearon el celular y no estoy entendiendo que es lo que quieren? por dios me pueden explicar

no entiendo la funcionalidad de este sistema, ya que me cambiaron muchas cosas

necesito confiar en alguien para que vuelva a su lugar todo normal, y así dar buenas noticias a quienes consideremos y pedir disculpas si así lo requieren nunca insulte a nadie, ni hackee el teléfono a nadie,  por favor necesito alguien con experiencia y renombre y de mediador en esta situación tan preocupante para todos , lo merecemos


Add support for purging tasks

..meaning actually removing them from the task DB. This already occurs when tasks expire (#341), but sometimes (https://github.com/GothenburgBitFactory/taskwarrior/issues/3399) users want to purge a task without waiting for expiration.
It's OK for this to break the sync model a little bit, as long as that's clear in the documentation.  #26 has some discussion of this.

This is referring to purging specific tasks before they expire -- not the existing Replica::expire_tasks support.

@QuantumBJump would this be an interesting task for you to work on?

I'll have a looksee, can't promise anything so don't assign yet, but I'll get back to you :)

#405 should do for this repo. @QuantumBJump I forgot there's already a method for this -- I just had to make it public!
Once that's done, I think we can release 0.6.0 and then implement this (and the server URL) in Taskwarrior.


Feature: exponential height Fog

Changes

Moved ambient light params to scene and added serialization
Added exponential height fog + scene params and serialization
Reorganized scene config menus a bit
Changed batches so they work when we call draw consecutive times (previously it needed reset before each draw)

To easily do the fog i add the transparent meshes positions to the g buffer since the lighting pass has already been done. I do it this way because that's the easiest place to read all the fragment positions from (needed for fog). We need the real values to prevent this from happening when there are transparent meshes. We also prevent reserving extra memory doing it this way, in the same pass (adding transparent fragment possitions to g buffer) we can add any transparent fragment data that's needed for postprocessing to have easy access to all the values we might need.

Quick fog examples

Code looking good to me but it will be great at least one of our render boys check it. @miquelmiro3 @baransrc Tested and working fine, I had a bug related to vector memory size that I leave in discord and I can't replicate it again uwu
One thing that I miss is that when I press play (play the game then stop) I lost the fog configuration because I imagine that it loads the serialized one so until I don't press save scene we always lose the changes? Or can be saved somewhere (?)
Thank you for your work and nice return to the render team boys ^-^

What you mention sounds like a bug bcs the idea was that the scene saved a temporary copy when pressing play and used it on stop ptress, we'll have to check it


Add GitHub Actions-based CI

The GitHub Actions workflow drives a Docker image build.
If an F* CI image is already there on the build machine, then reuse it and build from .docker/hierarchic.Dockerfile (I will open a PR into F* soon to produce such images). Otherwise, the build is fully standalone from .docker/standalone.Dockerfile.
In both cases, the Docker image runs a CI script, .docker/build/build-standalone.sh, using the existing CI functions in build_funs.sh coming from the old build.sh script.
Posts a Slack notification message with the elapsed time. This part takes two thirds of the GitHub Actions workflow definition:

How to produce the Slack message following https://api.slack.com/block-kit , with the commit message properly quoted
There does not seem to be any GitHub Actions built-in function returning the elapsed time, so I need to compute it by hand

Honors BranchName (to build against a different F* branch) and NotificationChannel from .docker/build/config.json
I already configured the Karamel repository to have GitHub Actions run on our CI machine.

Low* tutorial now properly refreshed, using a GitHub personal access token instead of SSH
Now enabled on pull requests
Once merged into master, users will be able to kick off a build with the "Run workflow" button on GitHub's Actions tab.

Thanks Tahina! This is great


Fix naming

I have started fixing the naming issue. First of all, I have changed all snippet file names to their corresponding names of functions. I've changed all the files that didn't match their name with the name of the function they're storing.
There is still lots of work to be done. While going through the names of function, most of them could be improved. I didn't want to touch them since we first need to discuss our ideas in #206
I've kept everything consistent. Used camelCase style in code and kebab-case in snippet file names.

I generally don't write in full caps, but THIS IS AMAZING. Thanks for the time and effort to do this. We now only need to update descriptions and we should be good to go! I'll get started on the descriptions right away!


Not an error

Hello I made this after being inspired by this project. Please go check it out. I would greatly appreciate any code changes :-)
https://github.com/Electrik-rich546456/Light_Gui

Hi @Electrik-rich546456 !  Thanks for sharing this with me.  Great project idea!
Some suggestions:

Don't include the tinytuya directory in your project. This pins you to the version you downloaded (1.2.6 in your repo) where there will be bug fixes and performance improvements (see RELEASE NOTES).  For example, the latest version, 1.2.10 includes support for new Tuya regions that Tuya now requires for some countries.  I recommend that you provide instructions in your README on how to install tinytuya with the simple pip install tinytuya command.
Your project requires Qt and PyQt5 so you should include general directions on those dependencies (e.g. "Setup" section), maybe something like:

Setup
Light_Gui depends on the following python modules: PyQt5 and tinytuya.  You can install these dependencies:
# Install Dependencies
pip3 install PyQt5            # Install the PyQt5 or use "python3 -m pip install PyQt5"
pip3 install tinytuya         # Install the tinytuya or use "python3 -m pip install tinytuya"

# Run
python3 Lights_gui_5.py

I look forward to watching your project develop!  I'll contribute PRs if I have time. :)

I should have mentioned... I got it to work!  It would be nice to have a setup UI to help someone pick the devices they want.  I used the Smart Bulbs in my Dining room and had this working:

Besides adding my device names, I made one other edit.  You are using the tinytuya d.set_brightness_percentage() function so the values need to be between 0-100.  I had to update this function to divide the slider value by 100 to get the right percentage:
    def br_Slide(self):
        global br_counter
        br_counter = int(self.Br_Slide.value())/100
#        print(br_counter)
        lights('SmartBulb',5)

One tip, if you are not getting it to work, TinyTuya can probably tell you want is happening.  You can add this to the top to set debug mode:
tinytuya.set_debug(True)

This is how I found the reason brightness wasn't working:
DEBUG:ERROR Specified Value Out of Range - 903 - payload: "set_brightness_percentage: Brightness percentage needs to be between 0 and 100.

Hi @jasonacox, I have been wanting to make this project for a long time and finally had some time to do it :-)
Please feel free to commit any changes to readme and code if you like. Do i have to add you somewhere on github?
As regards not having tinytuya in the folder I thought i had installed it with pip. But I think I may have a problem with pip instal.
Do you by any chance know if pip and pip3 are the same even if i have py 2.something as well as 3.8.something im running ubuntu.
That is great news you found the bug... Thanks
I wanted to make it something like this https://github.com/dev-est/tuya_tray (dut cant get it to work dependency ver issue ) so I figured I can make it loop through all devices in the snapshot json file and replace the lounge label  with a dynamic one so all lights show up.
However I noticed a problem the my getting status if the device is offline the whole thing just hangs waiting before time out

You said "You are using the tinytuya d.set_brightness_percentage() function so the values need to be between 0-100. I had to update this function to divide the slider value by 100 to get the right percentage:"
I forgot to set it back to 100 on line 88 you can set the scale to whatever and i was messing about with it trying to get it to work. set it back to 0- 100 and seems to have fixed it
I was using https://github.com/jasonacox/tinytuya#version-33---light-type-rgb as reference and got mixed up i had decided to use d.set_brightness_percentage()  to fix that problem happening

@jasonacox any ideas how i can change l_status(name): to display power status and brightness and colour temp for all active devices?

pip3 install tinytuya
Requirement already satisfied: tinytuya in /home/user/.local/lib/python3.8/site-packages (1.2.10)
Requirement already satisfied: pycryptodome in /home/user/.local/lib/python3.8/site-packages (from tinytuya) (3.3.1)
Requirement already satisfied: requests in /usr/lib/python3/dist-packages (from tinytuya) (2.22.0)
Why do i have 3 different versions how do i make them all be the same ? @jasonacox

pip3 install tinytuya Requirement already satisfied: tinytuya in /home/user/.local/lib/python3.8/site-packages (1.2.10) Requirement already satisfied: pycryptodome in /home/user/.local/lib/python3.8/site-packages (from tinytuya) (3.3.1) Requirement already satisfied: requests in /usr/lib/python3/dist-packages (from tinytuya) (2.22.0)
Why do i have 3 different versions how do i make them all be the same ? @jasonacox

This is normal.  You don't have 3 different version.  TinyTuya has dependencies on pycryptodome (encryption library) and requests (http library) which Pip knows (I specify in the PyPI setup).  Pip is reporting that those dependencies are the latest.

That's tricky. Tuya devices don't make it easy to determine their type by the DPS they send back. You will want a setup phase where the user selects the "bulbs" from their inventory of Tuya devices. Once you have that list (perhaps a list saved as a JSON file) you can loop through those devices and pull their status.

I wonder how they do it in the app?
Also do you know if the "tap to run" settings are callable using tinytuya ?
I have no idea how to implement this bit. Maybe i can just somehow take the smart life app code and use it in a desktop gui.
I say somehow as I have no idea how to pull the useful code out of an apk. lol

@jasonacox Hey ive added some more code. it now gets the data from tuya and populates the power and sliders :-)

Nice job!

Not bad for self.taught... :-)

lol self.

@jasonacox So do you know mucha about pyqt5 programming ?
i posted this question on stackoverflow but not had an answer.
https://stackoverflow.com/questions/70088216/pyqt5-how-to-make-a-checkbox-lock-two-qsliders-together

@jasonacox So i've figured out how add the lock button but now I have no idea how to code this function. Do you have any ideas?
if checkbox true lock two sliders together so they move together

It looks like you got a response on stackoverflow with some code help!   I haven't done anything with pyqt5.  It looks interesting.
Are you wanting to lock the movement of Brightness and Color Temp?  I've never heard of wanting that.  Is there a reason you want them locked?  I tend to like warmer temps at night but often want bright warm light for reading or dim light for watching a movie.  For electronic work, I like a cool light, very bright.  No judgement on the reason, I'm just curious as to why.
Sounds like a great learning adventure for you!  I'll be anxious to see how it goes.

Yes that's what i needed ! it's now working with the lock.
I wanted them to lock together so if i want bright light. its going to automatically set to bright white at same time. Ideally i would want them to be proporanaly locked like and audio mixer but like this is fine.
I got a few questions about tiny tuya.
Can you add a bit of code that accepts multiple lights being turned on at once like 3 lights on a pendant ?
on my code line 23 i define lights() and l_status() can you see a better way of doing this ?


Documentation Is wrong for looking up info on scopes and product groups.

You can read more about product groups http://guides.spreecommerce.com/scopes_and_groups.html. I cannot find any sort of documentation at all, about the functionality of this gem.

Thanks for the link, I was desperately seeking for what this extension does :-)


Scan external pull requests with sonarcloud

User Story
Allow scanning external pull-requests with Sonarcloud.
Acceptance criteria
Find a way to scan external pull-requests in CoMPAS.
Keep the traceability to the original author
Background:
@apupier
"I noticed one place missing the environment variable which is for the upload of Sonar analysis.
I found the feature request on Sonar side https://portal.productboard.com/sonarsource/1-sonarcloud/c/50-sonarcloud-analyzes-external-pull-request
And a slightly complicated workaround description: https://community.sonarsource.com/t/how-to-use-sonarcloud-with-a-forked-repository-on-github/7363/34"

Please add some documentation in order to keep this knowledge for further repositories. You can also make a proposal where to add the this fix.


WhiteCollarSideJobs: Evidence not exist?

Hello! Firstly - thanks for awesome side job quest. It was fun 4 hours of my life xD
Question is: what item i should put as "transaction evidence" at the "Resolve" screen?

Spoiler: I tried both...
   I printed v-mail with incorrect invoice and showed "warning note" from the friend. I'm also examined Loan Shark for any paycheks and found no one.

Is this job bugged for me?

You've put the right evidence in.

Spoiler: It's this evidence...
   printed v-mail

I wonder if two versions of the same job spawned targeting the same company?

Spoiler: How to know if the game spawned two jobs targeting the same company
   Was there one v-mail from the boss confirming the invoice format? Or multiple?

I've edited your comment to hide spoilers, too :)

I'm having the same issue as op, found the person on the inside and investigated them, but the evidence doesn't seem to count as evidence of a fraudulent transaction thus rendering the case unsolvable.
Also I found 5 v-mails from the boss confirming the invoice format to every employee

Recent update broke my game. so can't check it live.

If i remember correctly ...
there where multiple v-mails about "invoice format", but they all was on different PC (not at one). I also found two "invoices v-mail" at this company: one with 4 digits (incorrect) and one with 5 digits (correct?). I thought it's a valid to have multiple invocies - valid and invalid.

Fixed my game and checked again

More details
- Previously i used a 6.0.1 version of BepInEx, now bumped it to 6.02
- No visible signs of 'two versions of the same job'
- There one "invoice format" v-mail per every company PC
- This v-mail has the same person at "To:" and "From:" fields
- There total 3 invocies about "need to pay", 2 real one's - they targeted to "Head of HR" and 1 fake (my target) - it's targeted to "Marketing Executive"
- Checked other two suspects - no evidence at their homes


Compression not enabled in nginx

Hi - was just taking a look around and saw you guys could get some quick speed boosts not only from enabling gzip in nginx, but also from enabling permessage-deflate on the websocket.
Hope that's not already obvious to you - sometimes there are good reasons to keep it disabled.
Great project, keep going.

Thanks for the tip, I've asked valzav to look into it, he handles the servers.


iOS Chrome traces sys.game.device.browser.mobileSafari: true

Phaser Version: 3.60.0 (but 3.80.0-beta.2 looks same)
Operating system: win11
Browser: any

Description
Same as title. The browser detection code needs some updating. Currently:
https://github.com/phaserjs/phaser/blob/v3.80.0-beta.2/src/device/Browser.js
else if ((/AppleWebKit/).test(ua) && OS.iOS)
{
   Browser.mobileSafari = true;
   Browser.es2019 = true;
}

But should also consider the 'CriOS' substring of iOS Chrome's UA: https://chromium.googlesource.com/chromium/src/+/master/docs/ios/user_agent.md
Also, for some reason, sys.game.device.browser.safari is false on macOS Safari, but this is a bit outside of the scope of this issue. Still, macOS navigator.userAgent output, if anyone cares:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.6.1 Safari/605.1.15
Example Test Code
Not a regex, so you can prob do better:
else if ((/AppleWebKit/).test(ua) && OS.iOS && (ua.indexOf('CriOS') == -1))
{
   Browser.mobileSafari = true;
   Browser.es2019 = true;
}

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Use dictionary instead of list for the types

I found a way around to resolve the problem I encountered here

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.6%) to 95.745%

Files with Coverage Reduction
New Missed Lines
%

converter.py
4
94.74%

Totals

Change from base Build<PHONE_NUMBER>6:
-1.6%

Covered Lines:
90

Relevant Lines:
94

💛  - Coveralls


Keystone connector documentation

Signed-off-by: m.nabokikh<EMAIL_ADDRESS>Fixes #89

Thanks for this @nabokihms! I've done a copy-edit pass, but I tend not to do technical reviews for dex (yet 🙂). I've invited @sagikazarmark to look as well.

Looks good to me, thanks @nabokihms


array_index does not catch std::invalid_argument exception from std::stoull

Description
array_index does not catch std::invalid_argument exception from std::stoull, which means we need catch the exception in our code when using nlohmann json.
for example, for a json body json_body:  {\"foo\":\"val\",\"bar\":\"val\",\"array\":[\"a1\",\"a2\"]}, if json pointer json_pointer was set incorrectly like /array/, when we call json_body.contains(json_pointer), it will throw std::invalid_argument exception.
Reproduction steps
for a json body json_body:  {\"foo\":\"val\",\"bar\":\"val\",\"array\":[\"a1\",\"a2\"]}, if json pointer json_pointer was set incorrectly like /array/, when we call json_body.contains(json_pointer), it will throw std::invalid_argument exception.
Expected vs. actual results
Expected:
catch nlohmann::detail::exception is enough.
Actual:
just catch nlohmann::detail::exception is not enough, crush will happen due to std::invalid_argument exception.
Minimal code example
No response
Error messages
No response
Compiler and operating system
clang 7.0.1 ubuntu 18.04
Library version
3.10.5
Validation

[ ] The bug also occurs if the latest version from the develop branch is used.
[ ] I can successfully compile and run the unit tests.

This has been fixed.
v3.10.5
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoull

v3.11.2
terminate called after throwing an instance of 'nlohmann::json_abi_v3_11_2::detail::out_of_range'
  what():  [json.exception.out_of_range.404] unresolved reference token ''

This has been fixed (#3415).
v3.10.5
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoull

v3.11.2
terminate called after throwing an instance of 'nlohmann::json_abi_v3_11_2::detail::out_of_range'
  what():  [json.exception.out_of_range.404] unresolved reference token ''

thanks!


Just uploaded several Panos to Marzipano, and for the life of me, I have no idea how to publish them.
Its all good on the Marzipano site, but have no idea how to publish and share.
Help Please!

You can use Marzipano Tool then export to index.html.


Closes #471
Definition of Done

[x] The code does at least what is defined in the ticket and does not affect any other functionality
[x] The PR has a meaningful title
[x] There is a link to the issue-id
[ ] There are no 'hacks' or shortcuts refactoring is preferred
[ ] The happy case of the app was tested at least once manually

Bitte nochmal anschauen :)


Publish content item for case studies finder

This commit adds a content item that represents the “case studies” index page (https://www.gov.uk/government/case-studies). Once this content item is published using the existing finders:publish rake task, finder-frontend will render that page as a finder, rather than being rendered by whitehall-frontend.
Trello: https://trello.com/c/RerTRcJ4/325-migrate-case-studies-to-a-finder
A follow-up PR will remove the code that renders the case studies index page from whitehall.
Deployment checklist:

[ ] Deploy whitehall
[ ] Run the rake task finders:publish to publish the content item to the content-store

Before:

After:

For reference, the first "UKEF" item is not in the second screenshot because it was published after I last synced my VM data.

I've added a description as suggested by Alan.


Add Cron to Magento 2

Wanted to leave a note here saying I really truly appreciate the effort that went into putting this PR together. At the end of the day, I think both of us learned a lot as a result. However after much deliberation I'm going to close this out in favor of taking a simpler and more portable (i.e. between applications) route of installing crontabs in the FPM images and running crond in the background via the entrypoint script.
There are a few reasons leading me to go down this path:

Portability, as expected crontab definitions will not be needed on a per-application environment basis.
Projects with custom cron jobs (as is often the case with Symfony apps) would require custom docker-compose configuration, and that makes it more difficult for developers to use them when needed.
Magento has a bin/magento cron:install -d command which adds the following to the crontab and I'd like to eliminate "why doesn't this work" questions:

www-data@rock-php-fpm:/var/www/html$ crontab -l

#~ MAGENTO START 69dd2b02e1f3a65918182048ea4e29979a849d8942e8f53ed20a4bf10e529b36
* * * * * /usr/bin/php /var/www/html/bin/magento cron:run 2>&1 | grep -v "Ran jobs by schedule" >> /var/www/html/var/log/magento.cron.log
#~ MAGENTO END 69dd2b02e1f3a65918182048ea4e29979a849d8942e8f53ed20a4bf10e529b36

If need be this custom crontab can be persisted (across container re-creations) by mounting a file into the container at /var/spool/cron/www-data by adding custom configuration to .warden/warden-env.yml such as:

version: "3.5"
services:
  php-fpm:
    volumes:
      - .warden/crontab:/var/spool/cron/www-data

Lastly I couldn't get past the belief that hard-coding a specific cron routine in a base environment runtime configuration was the right move given the disparate nature of crons, and also the potential danger of having crons automatically setup and running.
Given this is a development environment, not a distributed production container runtime, I think it's ok to have a secondary process running in the FPM container for crons given the complexity reduction it offers here.

The FPM images have been updated in commit eab353f.

No complaints. 👍


fixup flaky e2e test: Istio check_for_dummy_volume E2E test failing

Description
This PR improves check_for_dummy_volume test, so we subscribe for logs and waiting for error.
How can this be tested?
Run make test/e2e/istio 2-3 times in row, make sure it works :)
Checklist
~- [ ] Unit tests have been updated/added~

[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c02029f) 64.79% compared to head (63b3a54) 64.79%.

:exclamation: Current head 63b3a54 differs from pull request most recent head 401fd0f. Consider uploading reports for the commit 401fd0f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   64.79%   64.79%
=======================================
  Files         249      249
  Lines       16352    16352
=======================================
  Hits        10596    10596
  Misses       4948     4948
  Partials      808      808

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Maximum and Dörfler Marking

Is there any interest in gaining some more involved refiners for AMR?
The two refiners I've implemented are Maximum marking and Dörfler Marking.
Doerfler marking, described in [1], is often used to prove convergence and optimality of adaptive algorithms. Maximum marking is simply included for variety to demonstrate a variety of refiners in the codebase.
[1] Willy Dörfler. A convergent adaptive algorithm for Poisson’s equation. SIAM J. Numer. Anal.,
33(3):1106–1124, 1996.
The code is at
https://github.com/ianabel/mfem/blob/hdg/mesh/Refiners.cpp
https://github.com/ianabel/mfem/blob/hdg/mesh/Refiners.hpp
but doesn't need any hdg-branch specific stuff.

Is this included in #969?

Err, shouldn't be. That's related to #1074 .
I don't really fathom the GitHub process, so I've probably mucked this up. If there's interest I'll make a PR from ianabel/mfem -> master with these refiners. It needs some unit tests before it hits prime-time though.

I was asking because the PR includes Refiners MaximumMarkingRefiner::MaximumMarkingRefiner etc.

Ah, I done goofed. I'll make the PR from the correct branch.

PR #1079 implements this.


Add the last countries

Ok I've decided on the criteria for which countries/regions to include in the plugin:

They must have an iso2 code
They must have a country calling code
They must have a flag
They must be supported by libphonenumber

You can see a list of unsupported countries near the top of data.js. By this criteria, I think we should add the following:

Åland Islands (ax)
Cocos (Keeling) Islands (cc)
Christmas Island (cx)
South Georgia and the South Sandwich Islands (gs)
Pitcairn (pn)
Svalbard and Jan Mayen (sj)

I have checked and we already have flags for all of them, we just need to add entries for them in data.js.

I check the libphonenumber, seems it does not support
South Georgia and the South Sandwich Islands (gs)
Pitcairn (pn)
Ignore them?

Confirmed. Yes ignore them for now (I will update the country support criteria in my original post).
If you have time, could you please open an issue with libphonenumber about adding support for these countries, and link to it here?

OK, I'm a little busy these days, will do this in recent days

Hi boss,
According to https://github.com/googlei18n/libphonenumber/issues/76

Pitcairn has the same issue - that has a comment in the metadata saying that the 30 inhabitants use satellite phones.

Things like GS, HM, UM, TF and EH we will add if we ever have any phone number information about these regions.

I think, let's just keep it in the comments...

A little question, Åland Islands (ax), obviously, 'Å' is not 'A', I tried to compare 'Å' with 'Z', 'Å' is bigger, so I think I should put it at the tail of the countries list, shouldn't I?
If yes, there is a test case about keyboard shortcuts need to be changed, which assumed that Zimbabwe is the last item.

Yes if you google "Swedish alphabet order" it looks like it comes after Z, so I agree we should put it at the end. Thanks for this.


option to use CC

Most youtube auto-generated CCs suck, but some videos have manually attached high-quality CCs, and somebody might want to use them instead.
yt-transcribe -cc <video_url>

If you download the captions, they get downloaded in a format that strides the boundaries we're placing. There are a few output formats, but vtt is the default and is representative:
WEBVTT
Kind: captions
Language: en-US

00:00:00.166 --> 00:00:01.766
Hey, I'm Sam
from Prismic. I'm here

00:00:01.766 --> 00:00:03.333
with Rich
Harris, creator of Svelte.

00:00:03.333 --> 00:00:05.800
And Rich is explaining to
me how you can get Rich quick by

00:00:05.800 --> 00:00:07.033
creating your
own JavaScript framework.

00:00:08.166 --> 00:00:09.233
Thanks for joining me, Rich.

Without the benefit of the nicely segmented transcript that whisper provides us, we have a couple problems:

we have to decide what to do about timestamps that straddle the boundaries; we have to put 03.333 -> 05.800 either before the 5-second thumbnail or after it
more seriously, we have to deal with another file format, which is going to gum up the works of the script unless we start breaking things out into functions

Probably the answer to supporting youtube and whisper is to write functions that return arrays of transcript segments, one for each in the video. So above, we'd parse the VTT file for frames that match the [0-5] segment, then frames that match [5-10], and so on and so forth, and return an array (which must have empty elements for empty segments).

A sample video that has good manually-generated subtitles, useful for testing, is: https://www.youtube.com/watch?v=i-BkN3rTK0Q
It's also helpful to know that --skip-download --write-sub will only download subs if they are manually added, not automatically generated. Ex:
 yt-dlp --skip-download --write-subs -o "manual_subs_only.vtt" 'https://www.youtube.com/watch?v=i-BkN3rTK0Q'

If you try to use that on a video that only has automatic subs, you get:
$ yt-dlp --skip-download --write-subs -o "bulls.vtt" 'https://www.youtube.com/watch?v=lyJ6GyC4Yng'
[info] There are no subtitles for the requested languages

$ echo $?
0

As you can see, unfortunately it returns success so we'd have to check for the presence or absence of bulls.vtt.en-US.vtt. It's trickier because it inserts the language in there! Maybe I can figure out how to avoid that.


feat: Allow GitHub token to avoid GitHub API rate limiting

This should solve the GitHub API rate limiting issue I created: https://github.com/aquasecurity/tfsec-action/issues/8
Heavily inspired (to the point of almost copying) by: https://github.com/aquasecurity/tfsec-pr-commenter-action/pull/82

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi all, any update on this? Hitting rate limits quite a lot lately.

@andrea-defraia I guess you have to agree to the Contributor License Agreement (see GitHub Action)

I needed to get some things cleared before I signed the CLA, and I have now signed it, so this should be ready to go.

@andrea-defraia @roee-landesman Is there anything additional I can do to help this PR get merged?

Looks good on my end, I'm not an approver though

LGTM, need approver for merging

@owenrumney Apologies for tagging you directly, but since your commit's the last one for this repo, I was wondering if we might get some help to get this changed merged?

Hi, I'm afraid I'm no longer involved in tfsec for aqua - suggest raising it in the tfsec slack channel.
Good luck

@roee-landesman @andrea-defraia  can we get this PR merged? We're having rate limiting issues.

@roee-landesman @andrea-defraia can we get this PR merged? We're having rate limiting issues.

Neither of the approvers have merge rights. The PR has been posted in the Aqua Security by multiple people (as suggested in one of the earlier comments), but no one has responded 😞

hi @nkuik, thank you for the contribution! I will be taking over this repo, please give me some time to review the code .


[fcos] questions about the interface between host and container runtime

In https://github.com/coreos/fedora-coreos-tracker/issues/231 we had a discussion about the use of varlink on Fedora CoreOS as a remote interface for container management. We'd like to gain a better understanding of how the code-ready-containers project is planning to set up and use this so that we know about this in the future when we make policy decisions about the host. Some questions that come to mind:

Will you be using ssh as an authentication and transport mechanism?
If using SSH will you be providing an ssh key via ignition?
Will you be using the podman remote command at all?

In general we're trying to discourage the use of SSH on FCOS, but understand that some tools have been built to assume it exists and are trying to keep track of places we know it is being used for bridging functionality.
cc @praveenkumar @lucab

Also, if you'll be using SSH and specifying your own key:

Will you use the command keyword in authorized_keys so the SSH key can only run varlink?
Will you create a separate FCOS user that doesn't have sudo access?

Podman support is being worked on. This discussion is mostly happening on #961


Include section in high level document for assembler syntax

There is an example of disassembly code in the high level document, but it's also necessary to define the assembly syntax.
Currently this is the syntax used in the LLVM patch (https://reviews.llvm.org/D109371)
Materializing an overlay token for a symbol:
lui a0, %ovl_hi(foo)
addi t5, a0, %ovl_lo(foo)
.word foo@ovl

Materializing the address of a overlay plt entry:
lui a0, %ovlplt_hi(foo)
addi t5, a0, %ovlplt_lo(foo)
.word foo@ovlplt

Making a call to the overlay engine:
jalr t6

In line with #29 I also propose that we update the %ovl_hi, %ovl_lo and @ovl syntax to use ovltok instead of just ovl too.

Opened a merge request #33

PR #33 for the addressed issue merged


Simplify EnableSwaggerUi template and redirect hander configuration

For now, if i want to have custom UI route, i have to do this:
		var uiRouteTemplate = string.Format("{0}/{{*assetPath}}", uiPrefix);  // i have to append {{*assetPath}} by hand
		swaggerEnabledConfig.EnableSwaggerUi(uiRouteTemplate);

		var redirectTo = string.Format("{0}/index", uiPrefix);  // and if i'd like to have a shortcut to "uiPrefix/index", i have to open Swashbuckle sources and copypaste this:
		config.Routes.MapHttpRoute("custom_swagger_ui_shortcut", uiPrefix, null, null, new RedirectHandler(SwaggerDocsConfig.DefaultRootUrlResolver, redirectTo));

Why not do something like this?
		swaggerEnabledConfig.EnableSwaggerUi(uiPrefix);  // <-- will automatically append {{*assetPath}} in this method and register redirect route to "uiPrefix/index"

If you are interested, i can make it and do a pull request.

This does make sense ... the only reason I didn't do it originally was for backwards compatibility.
The existing redirect is from "/swagger" and not "/swagger/ui". With the changed you've suggested, "/swagger" would no longer redirect and I would consider this to be a breaking change.
My thinking at the time was to just leave redirecting (if desired) up to the main app (it's not exactly a difficult thing to do) while continuing support of the existing redirect for anyone who's using the out-of-the-box route template.
The above does simplify things though, so maybe worth putting into the next major version


Add initial validate-index tool

This adds validate-index, a tool to validate indexstore unit files. Currently it checks that paths exist. This is useful as a post-import step, to confirm that index-import produced valid paths.
Further updates may include:

Validating the format of OutputFile's path
Validation of unit/record names
Correction of sysroot

cc @DavidGoldman since we talked about this last week


optimize generic filter

optimize generic filter

Codecov Report

Merging #8067 (3a797e5) into master (8892a36) will decrease coverage by 0.91%.
The diff coverage is 33.33%.

:exclamation: Current head 3a797e5 differs from pull request most recent head e115c22. Consider uploading reports for the commit e115c22 to get more accurate results

@@             Coverage Diff              @@
##             master    #8067      +/-   ##
============================================
- Coverage     61.16%   60.24%   -0.92%
+ Complexity      491      490       -1
============================================
  Files          1091     1091
  Lines         43953    43955       +2
  Branches       6417     6399      -18
============================================
- Hits          26882    26479     -403
- Misses        14088    14507     +419
+ Partials       2983     2969      -14

Impacted Files
Coverage Δ

...ava/org/apache/dubbo/rpc/filter/GenericFilter.java
37.90% <33.33%> (+0.19%)
:arrow_up:

...ookeeper/ZookeeperDynamicConfigurationFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...gcenter/wrapper/CompositeDynamicConfiguration.java
0.00% <0.00%> (-73.34%)
:arrow_down:

...pport/zookeeper/ZookeeperDynamicConfiguration.java
0.00% <0.00%> (-57.15%)
:arrow_down:

...fig/configcenter/TreePathDynamicConfiguration.java
31.42% <0.00%> (-54.29%)
:arrow_down:

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
28.35% <0.00%> (-50.75%)
:arrow_down:

.../dubbo/metadata/report/MetadataReportInstance.java
12.50% <0.00%> (-40.63%)
:arrow_down:

...va/org/apache/dubbo/rpc/support/AccessLogData.java
53.16% <0.00%> (-37.98%)
:arrow_down:

.../configcenter/support/zookeeper/CacheListener.java
0.00% <0.00%> (-28.58%)
:arrow_down:

...ntext/event/AwaitingNonWebApplicationListener.java
48.48% <0.00%> (-24.25%)
:arrow_down:

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8892a36...e115c22. Read the comment docs.


Help info for wondertwins command

Added a brief, description and usage for wondertwins command
Closes #160

@v1nam will you be fixing this up?

@v1nam will you be fixing this up?


⚠ Secret Website 3 has degraded performance

In 771c45f, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3110 ms

Resolved: Secret Website 3 performance has improved in 8dded15.


0.10.0-beta.1 does fail if a local version lower than 0.10.0 is installed

The following will produce the below error:
npm install -g db-migrate && db-migrate down && db-migrate up
Error:
-e/rof/.nvm/v0.10.40/bin/db-migrate -> /home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/bin/db-migrate
<EMAIL_ADDRESS>/home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>/home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/bin/db-migrate:21
dbmigrate = DBMigrate.getInstance();
^
TypeError: Object # has no method 'getInstance'
at /home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/bin/db-migrate:21:25
at /home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/node_modules/resolve/lib/async.js:44:21
at ondir (/home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/node_modules/resolve/lib/async.js:187:31)
at onex (/home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/node_modules/resolve/lib/async.js:93:22)
at /home/rof/.nvm/v0.10.40/lib/node_modules/db-migrate/node_modules/resolve/lib/async.js:24:18
at Object.oncomplete (fs.js:108:15)

@suomi35 Thank you for reporting.
Is it possible that you have installed locally a db-migrate version that is lower than 0.10.x?
If yes, db-migrate always prefers from 0.10.x on the local installed version. v0.9.x does not have the getInstance singleton and this would explain this failure.
This behavior is also mentioned within the breaking changes:
https://github.com/db-migrate/node-db-migrate/issues/315

With local I do mean an installation within your project you try to execute the migrations from.

I think I will make the startup script recognize if versions are lower than 0.10.0, so that no one has to run in this kind of issue.

Thanks for the prompt attention! I am building a virtual machine via codeship and installing db-migrate in sequence with some other modules. So it should be pulling from the internet every time.
I read #315 and decided to modify as follows to grab the driver, but still get the same error:
npm install -g db-migrate && npm install -g db-migrate-pg && db-migrate down && db-migrate up

Ok, does your project package.json include a lower db-migrate version as 0.10.x?

"db-migrate": "^0.9.23"

Yes this is the failure here. DBMigrate recognizes this and calls the 0.9.23 instead of your local project. Update this one 0.10 or just completely remove it. I will publish a patch shortly which ignores your local version if it is lower than 0.10.x and also displays an information if the local version is used.

Thanks so much for the assist!

@suomi35 My pleasure, whenever you have another question feel free to ask.

Published a patch under 0.10.0-beta.2 including a more convient handling of this issue and better failure reporting.

@suomi35 Considering the npm install -g db-migrate-pg  I'm also going to make this easier now that I notice that this is not working yet and make it possible to always load a driver from the local project if possible.

I was about to ask you if I was missing something because it doesn't seem to be working with db-migrate-pg :) Thanks!

Strangely, I still get an error about the driver not being installed. I have tried installing it with npm install -g db-migrate-pg both before and after npm install -g db-migrate. I get the error either way during the down. Is there something that has to be done in the migration scripts to point to the driver? How does db-migrate know to use the db-migrate-pg driver in the first place?
I have "driver": "pg" for each environment in database.json

@suomi35 the driver pg should require for the db-migrate-pg. There is just one possibility, your using migrations from a very old schema. Can you post the failure message from the verbose mode you get please?
And also search if you're require'ing db-migrate from one of your migrations, if this is the case, this is no longer necessary and you have to replace this by the new schema or install db-migrate locally.

You could also set the NODE_ENV to the global space this would also make node find it, but I do not suggest to do so.

To explain, db-migrate is now self injecting into the migrations in the setup routine. I see I need to add this to the breaking changes.

@suomi35 Have found the issue, it's located in the pg driver going to update this in an hour or so.

@suomi35 Try to reinstall the pg driver again, I have published a patch that should fix this issue<EMAIL_ADDRESS>

Thank you for all of the explanation and the latest fix. It's all working again :)
We really appreciate your efforts on this framework.


Feedback for “Introduction”

Hi i cloned - https://github.com/brunjlar/atlas-examples after watching video of Dr Lars - https://www.youtube.com/watch?v=rapjgIuGWJw&t=3907s
What is the instructions to get this working? i have Ubuntu linux and want to know the requirements etc.
I went to vesting folder and did cabal build or
even - cabal run place-vesting -- config.json forPlutus.skey $(cat Beneficiary.addr) 2023-04-01T15:35:00Z 2000000
but i got below errors: wonder how i can resolve this and what support can be given by Atlas.
[][][]chakravarti@chakravarti-Latitude-7280[]:[]~/Cardano/atlas-examples/vesting[]$ []cabal run place-vesting -- config.json forPlutus.skey $(cat Beneficiary.addr) 2023-04-01T15:35:00Z 2000000
Resolving dependencies...
Error: cabal: Could not resolve dependencies:
[__0] trying: atlas-<IP_ADDRESS> (user goal)
[__1] next goal: base (dependency of atlas)
[__1] rejecting: base-<IP_ADDRESS>/installed-<IP_ADDRESS> (conflict: atlas =>
base^>=<IP_ADDRESS>)
[__1] skipping: base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS> (has the same characteristics that
caused the previous version to fail: excluded by constraint '^>=<IP_ADDRESS>' from
'atlas')
[__1] rejecting: base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS> (constraint from
non-upgradeable package requires installed instance)
[__1] fail (backjumping, conflict set: atlas, base)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, atlas

i was able to resolve this.
i cloned "https://github.com/geniusyield/atlas" first.
Ran nix develop.
Then cabal update and cabal build.
Then cd-ed to the atlas-example/vesting and did cabal update and cabal build and then then the cabal run worked.
it would have been nice if these instructions were there. maybe someone experienced with nix and flake would have picked this up.


fixed undefined window error

Nice library. Wants to contribute

Running into this error as well (using NextJS), so would love for this PR to get merged 😄


Automatic adding of billing permission in Android

For Android, the plugin automatically adds the permission,
[assembly: UsesPermission("com.android.vending.BILLING")]
We use the plugin in a reusable common PCL which we use for all apps we have and some of them don't use billing. I suggest the permission shouldn't be hardcoded in the library and should be put in Readme for Android setup.

I auto add permissions to all my libraries, sorry that is just my convention.


Impl. file upload endpoint

This PR will add a new endpoint that allows users to upload files to a storage location. This upload functionality is meant for data that is too large to be submitted tot the Kafka queue. After successful upload the upload endpoint returns the path of the newly created file. The application can then submit a new message to the Kafka queue that mentions this path.
For now, upload is only implemented for S3 storage.
The upload endpoint is disabled by default. It can be activated with the file-upload.enabled application property.
Remarks

This PR add a new minio dependency. This allows file storage on Minio and on AWS S3.

@mpgxvii @yatharthranjan I have fixed the PMD linting errors. It forced me to remove duplication of string constants to member variables. Normally a good thing, but for tests it makes the tests less easy to write and interpret. Can we not better suppress linting checks for test classes, or at least  suppress the The String literal "project1" appears 9 times in this file; ...  errors for tests?

@mpgxvii @yatharthranjan I have added another commit that fixes a CORS issue. The Location header was not exposed to the aRMT app because of CORS protection. In the commit the CORS exception is added to the upload endpoint method. I tried to add this to the MultiHttpSecurityConfig class, but this did not work.

@pvannierop Is this ok to merge?


Active button in buttonGroupInput unclear on dark theme

I wanted to use a buttonGroupInput in a top app toolbar to toggle between two key query params.  The button group looked good, but in dark mode it's just not clear which is selected - or rather, the active/selected button looks less active than the inactive one.
We've discussed this before, but today was the first time when I wanted to use a buttonGroup but really felt like I could not as it wasn't clear enough.
This much more of an issue in dark theme - light theme reads OK to me.
Could we experiment with adjusting background color/gradient, or potentially adding a border or outline to the active button?  Could look to see what other examples do, although again its that dark theme that's key.

Fixed in #1118


DO NOT MERGE! Fast Forward stable to 4dc59d5d6b595ae46ffe3e859d41888b1055b280.

This PR will be merged automatically once checks are successful.

Jenkins job auth/postsubmit passed


Request to http api from chrome extension not allowed in window

I got 403 while request ollama api in localhost from the background.js of chrome extension. It seems the problem caused by cors restriction. However, the source code of ollama indicate that the default config does allow browser extension requests ollama in localhost. Is it the problem of window version?

Hi @DominguitoLamo chrome extensions can't access Ollama by default due to CORS, however OLLAMA_ORIGINS can be customized with chrome-extensions:// URLs by configuring the Ollama server: https://github.com/ollama/ollama/blob/main/docs/faq.md#how-do-i-configure-ollama-server


Example spec for swagger:response does not produce example output

Problem statement
The docs on this page provide an example of how to produce a swagger response spec from annotations. However running swagger generate spec -o swagger.yaml does not produce the example output.
Swagger specification
I've copy pasted the example annotation in a test file in package main:
package main

// A ValidationError is an error that is used when the required input fails validation.
// swagger:response validationError
type ValidationError struct {
	// The error message
	// in: body
	Body struct {
		// The validation message
		//
		// Required: true
		// Example: Expected type int
		Message string
		// An optional field name to which this validation applies
		FieldName string
	}
}

Steps to reproduce
Output:
paths: {}
responses:
    validationError:
        description: A ValidationError is an error that is used when the required input fails validation.
swagger: "2.0"

What it should be:
---
responses:
  validationError:
    description: A ValidationError is an error that is used when the required input fails validation.
    schema:
      type: object
      description: The error message
      required:
      - Message
      properties:
        Message:
          type: string
          description: The validation message
          example: Expected type int
        FieldName:
          type: string
          description: an optional field name to which this validation applies

Notably, the schemas and the properties fields are missing. Am I calling this incorrectly here?
Environment
swagger version: v0.30.5
go version: 1.21.5 darwin/arm64
OS:  macOS 12.6

Tested from current master.
go-swagger version: 59c3c59d9881915da2818a47ee2b76a8628ba030
go version go1.21.4 linux/amd64
using the above code as main.go and typing, from the same folder:
swagger generate spec -c .
{
  "swagger": "2.0",
  "paths": {},
  "responses": {
    "validationError": {
      "description": "A ValidationError is an error that is used when the required input fails validation.",
      "schema": {
        "type": "object",
        "required": [
          "Message"
        ],
        "properties": {
          "FieldName": {
            "description": "An optional field name to which this validation applies",
            "type": "string"
          },
          "Message": {
            "description": "The validation message",
            "type": "string",
            "example": "Expected type int"
          }
        }
      }
    }
  }
}

This looks pretty much like what was expected, right?

Yes this looks correct, glad to know I'm not going crazy. Although it seems I can checkout that commit in the repo, so I cant verify myself on my machine

I am facing the same issue. Opened another issue yesterday, but I've since closed it to align with this.

Faced the same issue. The referenced models within the the swagger:response struct  are not generating for the following go versions

go1.22.0 darwin/arm64
go1.22.1 darwin/arm64

But everything else the same, correct expected docs are generating for:

go1.21.4 darwin/arm64


bitcoin patch for miniupnpc > 1.6

Hi,
I tried to compile on my centOS server the wallet but I had the following error because I use miniupnpc2.0 :
net.cpp: In function ‘void ThreadMapPort2(void*)’:
net.cpp:1173:74: error: invalid conversion from ‘int*’ to ‘unsigned char’ [-fpermissive]
     devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, &error);
                                                                          ^
net.cpp:1173:74: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int, unsigned char, int*)’
In file included from net.cpp:19:0:
/usr/include/miniupnpc/miniupnpc.h:62:1: note: declared here
 upnpDiscover(int delay, const char * multicastif,
 ^
make: *** [obj/net.o] Error 1

I found that dogecoin had the same problem so I implemented their fix.
I gave the exact same pull request to Neblio and they merged it.
More info here :
dogecoin/dogecoin#1292
dogecoin/dogecoin#1293
dogecoin/dogecoin@984e204
Not related to the pull request, the link to the linux wallet is the same as the windows wallet on the website http://condensate.co/

Credit to antoinemineau


Some resources

Some resources for @jasongrout students and other approaching Electron. I will keep adding these as they come to mind:
Main and renderer process: Electron is based on a dance between two communicating processes, one for the UI, one on the native side. The division is not that clear, but this is the most important concept to grasp.

official reference
better article
classic talk about js event loop

General UI and design articles:

lots of small useful suggestions

And of course official docs

@ddavidebor Awesome! I found this really helpful when I was learning about it last week. Very simplified but also goes over the main topics:
http://jlord.us/essential-electron/

Also interesting to read: https://slack.engineering/building-hybrid-applications-with-electron-dc67686de5fb

Electron recently made a blog post on Typescript support https://electron.atom.io/blog/2017/06/01/typescript

Nice!
On Fri, Jun 2, 2017 at 5:03 PM, Charnpreet Singh<EMAIL_ADDRESS>wrote:

Electron recently made a blog post on Typescript support
https://electron.atom.io/blog/2017/06/01/typescript
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterlab/jupyterlab_app/issues/5#issuecomment-305934814,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABr0GpuwS1CIRLSHD7pA73SiPUUyxREks5sAKLRgaJpZM4NkfZ7
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>