Add a recommendation to manually set the DJANGO_SQIDS_ALPHABET setting

By customizing the DJANGO_SQIDS_ALPHABET string, we can prevent the issue of generating the same IDs as those generated by other projects using the default alphabet.

Sorry for not getting back sooner, I've been thinking about this notice a bit.
Personally, I want to avoid any references to potential "security" issues as this is not a security library and must not be used as such. Mentioning that it's recommended to change the alphabet (I don't think it is, I haven't seen this mentioned anywhere around the Sqids project?) might make people think it's for better security or similar.
Because of this I'm closing this for now.

@julianwachholz - No worries. I know djando-sqids is purely visual and a providing a random string won't change anything in terms of security. It was just to ensure that the outputs were visually unique.
I saw this recommendation in: https://github.com/sqids/sqids-dotnet#customizations and felt it would be a nice addition here.

Thanks for the link. This Python package does provide a small shuffle_alphabet utlity to achieve the same effect. Would you like to mention this in the README instead?

@julianwachholz Sure! I saw the shuffle_alphabet utility.
The only caveat with it is that it has to be run manually to get the output, which is a tad cumbersome, so I opted for the online utility.
I guess we can mention both like this:
You may use the shuffle_alphabet function provided with django-sqids or an online tool like [this one](https://codebeautify.org/shuffle-letters) to shuffle the default string.
WDYT?

Sorry, I do not wish to link to a third party site for this. I am interested in adding the function as a script to be invoked (manage.py or python -m)

@julianwachholz - Do you have the option to re-open the pull request? If not, I can create another one.

@julianwachholz - I am going to add a script to generate a random string that can be used as DJANGO_SQIDS_ALPHABET. I was thinking of adding it as a management command but then the django_sqids app would have to be added to INSTALLED_APPS, which isn't a requirement at the moment.
Eitehr we can ask users to add django_sqids to INSTALLED_APPS going forwards and create a management command or we can just create a script which would return a randomised string using the default alphabet.
python -m django_sqids.generate_random_alphabet
t8WPbaXQ30R9umoTCAHBIswgUNqhlLpYdxvJGkfzrSeKD1VMcZj7O42Fi5E6yn

It is probably a one time use thing per-project anyway(unless the user is manually providing a different alphabet for each field)
WDYT?

Agreed the python -m way is quick and clean. :)

@julianwachholz - have added a small script for random alphabet generation.


Lua 5.1 warning about nested long strings/comments

Describe the bug
Lua 5.1 has a warning when you nest long comment or long string delimiters.
Further lua versions do not have this, nor do LuaJIT or Luau.
To Reproduce
Parse the following file with Loretta
local longstr = [[Show me this
yes!]]
--[[
local unused_string = [[Line1
Line2]]
local longstr = [[
Do not show me this
Multiline string]]
--]]

print(longstr)

Expected behavior
An error diagnostic is generated from [[Line1 to Line2]].
Additional context
Loretta Version: v0.2.9

Instead of an error this will be getting added as a warning instead.


Condensed tabControl

@illarionow What's our status here? Were the comments addressed? Also, it would be nice to have a description/image of what the PR is about


Simplify Bot Operations

Need to make the project board easier to use for sprints:

[ ] Need to prevent forced moving of cards (except when "done")
[ ] Need to remove board database

Closing this issue due to complications spelling out in #97.


[Feature request] New conversational models for Transformers.js

Conversational Models

It would be a valuable addition to have Transformers.js support the Llama2 Llama2 model.
Reason for request
Why is it important that we add this feature?

It is important to try it out so that it is possible to create sensible chatbots in a multilingual setting (using other languages than English). This is not possible/recommended based on the already supported models by Transformers.js.

I've merged my PR to add llama/llama2 support, but you will need to do the >=7B model conversions yourself.


[WIP] OCPBUGS-14902: Loki search does not allow special chars

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902
Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.
Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql
Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

I see there are a couple of test failures.
Also, with this approach I guess we won't be able to search for any string that contains a ` character. Although this is still a big improvement on the current behavior.

/test test-e2e

/retest

@zhuje we need to fix the e2e tests as some of them are matching on the expected query and this changed including the ticks, in particular web/cypress/integration/logs-page.cy.ts

/lgtm
@zhuje we might need to update the JIRA ticket to add the specific logging version rather than the OCP version. Also this might need to be backported to 5.7

/approved

/jira refresh

/jira refresh.

/jira refresh

/jira refresh

/jira refresh

/approve

/cherrypick release-5.7


Please show to use the Pandas Profiling with Pandas

My Pain
I'm using Panel which is a framework for creating awesome-analytics apps in Python.
To help my self and others I'm developing awesome-panel.org and sometimes I develop small apps based on user questions in the Panel Discourse.
Now some users have asked about using Pandas Profiling with Panel. See for example https://discourse.holoviz.org/t/cant-display-pandas-profiling-report/760

Solution provide example of using Pandas Profiling with Panel

Solution
I have actually implemented it. Just wanted to share knowledge about it :-)
See awesome-panel.org and https://github.com/MarcSkovMadsen/awesome-panel/blob/master/application/pages/pandas_profiling_app/pandas_profiling_app.py

I've sent out a little tweet about it. Feel free to share if you like.
https://twitter.com/MarcSkovMadsen/status/1269188057347088384?s=20
This issue can be closed.

Thanks for sharing this Marc, I'll add it to the documentation.


Update to PHPCS3 conventions

PHPCS 3.0 was released the other day 🎉  however it breaks backwards compatibility with all custom sniffs. There is an upgrade guide to move from 2.x to 3.x.
In order for people to migrate to PHPCS3 all existing sniffs shall need to be migrated.

i'm willing to invest some time to make a phpcs v3 version, but i'm not entirely sure of the livelyness of this repo.
@djoos what are your intentions with this repo?
#32 has been open for quite a while and appears to be a blocker for all open pull requests (appears as in: they're open without any comment since #32 was opened).
are you willing to transfer ownership / add some members to this repo to keep it in a more active state?

Hi guys,
there are some open issues - but the repo is definitely still alive ;-)
We've had some issues and PRs flow through after #32 and definitely happy to merge in PRs quickly if they are concise.
It would be good to discuss adding additional members at some point though - and it would be great to get the open issues and PRs sorted/closed...
Hope this helps!

thanks @djoos, thats goo news!
i'll try and prep a phpcs v3 compatible version somewhere in the next couple of weeks using the v.2.10.1 release as baseand we'll go from there...

@WickedOne, that sounds great!
Just a heads up: please try to keep the changes atomic by just implementing the phpcs v3 compatibility.
I'm happy to get other things that might pop up merged in via additional PRs though!
Thanks in advance!
David

@djoos: no worries, i won't try to sneak in new or altered sniffs :-)
reading the upgrade guide, v3 looks like a fairly simple refactor


Custom dimensions of the map

Map CSS as a block to allow interaction when routing. The user can now specify the height and width of the map's pane when running the server

geeservermap --width 500 --height 800

sorry @12rambau, can you explain a bit more? flask uses jinja2 yes (https://flask.palletsprojects.com/en/2.3.x/templating/)... what other extension could it have?

.jinja2

but I checked flask documentation and it seems commonly accepted to make it transparent


lib: better support for self-hosted instances

This change removes some instances of the hardcoded string https://sourcegraph.com, and relies on the environment variable SRC_ENDPOINT.
Additionally, it also makes some changes to how environment variables are handled to make sure it matches the instructions in the src-cli README, namely:

the environment variable for the token is SRC_ACCESS_TOKEN, not SOURCEGRAPH_ACCESS_TOKEN
the endpoint isn't guaranteed to have a trailing / (and the instructions in the README of src-cli don't mention it)

I don't feel strongly about those, but it's just something I noticed while trying to follow the instructions in the README. If we don't want to keep those, it may be worth it mentioning that a trailing slash is required and that the environment variable for the access token is different.
I haven't added any tests just yet, because I want to see what kind of feedback this will get before investing in tests.
In general, I haven't been able to get it to work yet, but at this point it's because some of the queries checked in here don't work with the instance I have at work (probably a versioning thing). I'll keep digging and thinking about how we can handle such differences.
Related to #11.

Hey @fsouza, while testing this branch out with a company-internal sourcegraph instance I'm getting some errors on the rust side. I apologize in advance for the formatting of the error, and for the fact that it is a screenshot in the first place but this is the best I could get for now 😄

@rmagatti it sounds like it's failing to parse the response. At my job, we have the API running at a different hostname from the web, you may be in a similar situation.
For example, let's say your web instance is running at https://sourcegraph.example.com, but the API is listening on https://sourcegraph-api.example.com/, you'd need to make sure you pass https://sourcegraph-api.example.com to sg.nvim. Something like:
vim.api.nvim_create_autocmd("BufReadCmd", {
  group = "sg.nvim",
  pattern = { "https://sourcegraph.example.com/*" },
  callback = function(args)
    local sg = require("sg")
    local match = string.gsub(args.match, "://sourcegraph.", "://sourcegraph-api.")

    sg.bufread(match)
  end,
})

Not sure what else can it be. Perhaps you can run some sort of proxy in the middle to intercept the request and the response and see what's going on?

So I'm not sure that's it. I added some println statements to the rust code and it looks to me like it's entering the error clause when making the graphql request, which suggests to me that it's not that it's unable to parse the request, but that the request it merely unsuccessful in the first place. Though I can't seem to get a good log from it...
    pub async fn get_graphql<Q: GraphQLQuery>(variables: Q::Variables) -> Result<Q::ResponseData> {
        println!("GRAPHQL_ENDPOINT: {:?}", GRAPHQL_ENDPOINT.to_string());

        let response =
            match post_graphql::<Q, _>(&CLIENT, GRAPHQL_ENDPOINT.to_string(), variables).await {
                Ok(response) => response,
                Err(err) => {
                    println!("err: {:?}", err);

                    return Err(anyhow::anyhow!(
                        "Failed with status: {:?} || {err:?}",
                        err.status()
                    ))
                }
            };

        response.data.context("get_graphql -> data")
    }

Disclaimer: this is pretty much my first time reading, much less writing any rust, so bear 🐻 with me

Oh yeah, that's kind of what I meant. Failing to parse because the response may not be valid GraphQL (sorry, it was late when I wrote the previous message).
Are you able to use the src CLI pointing to the endpoint that you configured neovim with?

Yes, indeed I am, calling src api -query='query { currentUser { username } repositories(first: 10) { nodes { name } } }' returns the expected data correctly

@rmagatti gotcha, it could be that you're running in the same issues I ran into (in my case, the queries in https://github.com/tjdevries/sg.nvim/tree/master/gql are not compatible with the version of sourcegraph running at work)

Right, I suppose that would make sense. How could I verify that is the case?

Right, I suppose that would make sense. How could I verify that is the case?

iirc I tested the PathInfo query using the GraphQL explorer and it didn't work, it said that type didn't exist, which makes me think it's a version mismatch. I haven't had much time recently, but my next plan was to try to figure out alternatives for all queries (if possible), and then see how I could customize it (may require forking since the queries get embedded in the compiled binary).

What came to mind was if queries could be done by simply calling to the src cli instead of directly. 🤔

What came to mind was if queries could be done by simply calling to the src cli instead of directly. 🤔

Oh yeah that should work too. With src api. I just tested, and this is what I get:
％ src api 'name=some/repo' 'revision=HEAD' 'path=file-path' < gql/path_info_query.graphql
{
  "errors": [
    {
      "locations": [
        {
          "column": 7,
          "line": 6
        }
      ],
      "message": "Cannot query field \"path\" on type \"GitCommit\"."
    },
    {
      "locations": [
        {
          "column": 9,
          "line": 8
        }
      ],
      "message": "Fragment cannot be spread here as objects of type %!q(\u003cnil\u003e) can never be of type \"GitBlob\"."
    },
    {
      "locations": [
        {
          "column": 9,
          "line": 12
        }
      ],
      "message": "Fragment cannot be spread here as objects of type %!q(\u003cnil\u003e) can never be of type \"GitTree\"."
    }
  ]
}

The browser UI/explorer is helpful to "fix" the query though, as it will have schema documentation.

What versions of sourcegraph are you both running? (if you can say)

I just pushed a change that incorporated some of the changes here, if you wanna test out HEAD right now, it might solve your problems?... not sure :) hoping it does though haha

What versions of sourcegraph are you both running? (if you can say)

I'm on 4.5.1.
Also, it works now in HEAD 🎉


[CT-3085] [Bug] dbt retry doesn't unpack resource-type

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When using dbt retry after using dbt build with a resource-type specified, dbt will warn of a BadParameter since the resource-type from the previous run is returned as a string of a list.
Expected Behavior
When using dbt retry in conjunction with a dbt build with a resource-type specified, it would run the appropriate nodes without a parameter issue. It would run whether I had a single resource-type specified or multiple resource-types specified.
Steps To Reproduce

Create a model / tests that will error out

some_model.sql
select null as id

some_model.yml
version: 2

models:
  - name: some_model
    columns:
      - name: id
        tests:
          - not_null

Invoke dbt build -s some_model --resource-type all (optionally, --resource-type model test)
Invoke dbt retry to see failure
-- On the happy path
Invoke dbt build -s some_model
Invoke dbt retry to see proper flow

Relevant log output
A stripped down log with multiple resource types

➜ dbt build -s stg_google_ads__account_history --resource-type seed model test
18:23:30  Running with dbt=1.6.1
18:23:30  Registered adapter: snowflake=1.6.2
18:23:31  Unable to do partial parsing because config vars, config profile, or config target have changed
18:24:00  Found 2356 models, 59 snapshots, 2095 tests, 87 seeds, 4 operations, 1744 sources, 0 exposures, 0 metrics, 961 macros, 0 groups, 0 semantic models
18:24:00
18:24:04
18:24:07
18:24:07  Concurrency: 4 threads (target='snowflake_dev')
18:24:07
18:24:07  1 of 2 START sql view model staging.stg_google_ads__account_history ............ [RUN]
18:24:08  1 of 2 OK created sql view model staging.stg_google_ads__account_history ....... [SUCCESS 1 in 0.86s]
18:24:08  2 of 2 START test not_null_stg_google_ads__account_history_account_id .......... [RUN]
18:24:09  2 of 2 FAIL 1 not_null_stg_google_ads__account_history_account_id .............. [FAIL 1 in 0.94s]
18:24:09
18:24:09  Finished running 1 view model, 1 test, 4 hooks in 0 hours 0 minutes and 8.38 seconds (8.38s).
18:24:09
18:24:09  Completed with 1 error and 0 warnings:
18:24:09
18:24:09  Failure in test not_null_stg_google_ads__account_history_account_id (models/staging/adwords/src_adwords.yml)
18:24:09    Got 1 result, configured to fail if != 0
18:24:09
18:24:09    compiled Code at target/compiled/ramp_dbt/models/staging/adwords/src_adwords.yml/not_null_stg_google_ads__account_history_account_id.sql
18:24:09
18:24:09  Done. PASS=1 WARN=0 ERROR=1 SKIP=0 TOTAL=2

➜ dbt retry
18:25:04  Running with dbt=1.6.1
18:25:04  Registered adapter: snowflake=1.6.2
18:25:07  Encountered an error:
"['seed', 'model', 'test']" is not one of 'metric', 'source', 'analysis', 'model', 'test', 'exposure', 'snapshot', 'seed', 'default', 'all'.
18:25:07  Traceback (most recent call last):
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 87, in wrapper
    result, success = func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 72, in wrapper
    return func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 143, in wrapper
    return func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 172, in wrapper
    return func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 219, in wrapper
    return func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/requires.py", line 259, in wrapper
    return func(*args, **kwargs)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/main.py", line 609, in retry
    results = task.run()
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/task/retry.py", line 94, in run
    retry_flags = Flags.from_dict(cli_command, self.previous_args)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/flags.py", line 293, in from_dict
    ctx = args_to_context(command_arg_list)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/flags.py", line 69, in args_to_context
    sub_command_ctx = sub_command.make_context(sub_command_name, args)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 943, in make_context
    self.parse_args(ctx, args)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 1408, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 2400, in handle_parse_result
    value = self.process_value(ctx, value)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 2356, in process_value
    value = self.type_cast_value(ctx, value)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/options.py", line 72, in type_cast_value
    value = super(MultiOption, self).type_cast_value(ctx, value)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 2342, in type_cast_value
    return tuple(convert(x) for x in check_iter(value))
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 2342, in <genexpr>
    return tuple(convert(x) for x in check_iter(value))
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/core.py", line 2316, in convert
    return self.type(value, param=self, ctx=ctx)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/types.py", line 83, in __call__
    return self.convert(value, param, ctx)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/dbt/cli/option_types.py", line 60, in convert
    super().convert(value_item, param, ctx)
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/types.py", line 296, in convert
    self.fail(
  File "/Users/kevin/Library/Caches/pypoetry/virtualenvs/dbt-YSAPFX2U-py3.9/lib/python3.9/site-packages/click/types.py", line 136, in fail
    raise BadParameter(message, ctx=ctx, param=param)
click.exceptions.BadParameter: "['seed', 'model', 'test']" is not one of 'metric', 'source', 'analysis', 'model', 'test', 'exposure', 'snapshot', 'seed', 'default', 'all'.

Environment
- OS: MacOS 13.5.1
- Python: 3.9.16
- dbt: 1.6.1

Which database adapter are you using with dbt?
snowflake
Additional Context
Can confirm that without the resource-type specified in dbt build, dbt retry works as intended.

Thanks for reporting this @kevin-chao and providing such a nice example of how to reproduce it 🤩
Following your example, I got the same results as you, namely that this doesn't work correctly:
dbt build -s some_model --resource-type all
dbt retry

And neither does this:
dbt build -s some_model --resource-type model test
dbt retry

But this works fine:
dbt build -s some_model
dbt retry

I wonder if this will be incidentally resolved by the work in:

https://github.com/dbt-labs/dbt-core/pull/8665

🧠 @jtcohen6 looks quite likely!
Asked here whether it will resolve it or not.

@dbeatty10 my first approach in that PR did not actually solve this problem but I tweaked it a bit more and it seems to be resolved.


mycli: 1.22.1 -> 1.22.2

Motivation for this change
New release https://github.com/dbcli/mycli/blob/master/changelog.md#1222
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

/nix/store/dp648gycc4d2184phwbzmzibvvli1ng7-mycli-1.22.1	  172334280
/nix/store/nzg37kz8x4b92iql4yrk3iiwd9aw8jsa-mycli-1.22.2	  172334352

[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 94651 1

1 package built:
- mycli


Mac result types are not exported

Hey! I was trying to set the mac bundle identifier and encountered a small issue when trying to pattern match them.
Unfortunately, it seems that notify-rust does not export the necessary types to match e.g. mac_notification_sys's error types. (The examples simply unwrap, thus avoiding the issue).
I think I can simply make my project depend on mac_notification_sys so I can just use the types directly from there, but perhaps it'd be cool to have those be available somehow? There has to be some way to make this more ergonomic...
Example:
if cfg!(target_os = "macos") {
    match notify_rust::set_application("com.apple.Terminal") {
        Ok(_) => { /* Do something*/ }
        Err(______) => { /* Handle a specific error */ }
        Err(err) => { /* Fallback for other errors */ }
    }
}

PS: Maybe I'm missing something? I see that there's an extern crate however, I'm unsure how to use it. I can't use mac_notification_sys without having it be part of the cargo project.

oops :D

@Pandawan wanna give v4.5.8-pre.1 a try?

I think https://github.com/hoodie/notify-rust/blob/feature/fix-mac-exports/examples/mac_app_id.rs should resemble your use-case right?

I just released 4.5.8 - please reopen this if it's not sufficient

Yup, thanks for the quick fix!


Feature request: Tailwind CSS v3.4 size-* utilities

Is your feature request related to a problem? Please describe.
It’s not a problem, just a code readability improvement.
Describe the solution you'd like
Replace all occurrences of w-[number] and h-[number] with size-[number].
Describe alternatives you've considered
Leave everything as it is.
Additional context
Requires Tailwind CSS v3.4.

Good suggestion. A PR would be welcome 🙂


Add multi_gpu support to AutoModel

Everything is in the title! Would be lovely to be able to add a number of GPUs to use with AutoML / AutoModel.
Thanks!

Makes total sense, will be added :)

When you try to use keras' multi_gpu_model you might find that it gives an Exception 'TypeError: object of type 'NoneType' has no len()regardingmodel.outputs`.
Searching for a solution on SO I found this.
Hope you can find a solution!

Oh actually I managed to fix it by specifying an input shape for all network types. That's all that was missing. See my second SO link in the reply above.


Investigate using -mtls-dialect=gnu2

On Ubuntu 22.04, building Memray with USE_MEMRAY_TLS_MODEL=0 results in a broken build, because TLS variables need to be created with malloc, which calls our malloc hook, which tries to access (and create) our TLS variables, resulting in an infinite loop and stack overflow. This problem is fairly unique to how Ubuntu is building its python3 interpreter, but we believe we can work around it by using the modern gnu2 TLS dialect instead.

Also if I recall correctly this only happens with the debug version of the interpreter no?

Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113874

Closing as probably we are not going to do it


paging for vdiagram

#28

Coverage decreased (-10.14%) to 70.04% when pulling 58c74f84870ad71a9bfd83a2251530e15c561dbc on jread-usgs:master into<PHONE_NUMBER>27df0cd6f96e8c7bae280c72a3ac1b on USGS-R:master.


Attachments

Added

PUT /db/doc/attachment
GET /db/doc/attachment
DELETE /db/doc/attachment

and tests
as well as updating dependencies.

+1


Split function used by scikit-learn random forest

Hi,
Nice code! I was wondering which type of split function is used by scikit-learn library, any idea? I am not sure if typically used value/pixel difference split function will work well with hyper-column features, since there is no correlation between feature values.
Thanks!

Hi,
I'm not sure what do you mean by "split function". But I use the RandomForestClassifier of scikit-learn as is.
For reference here is the code.
But what you say is interesting to me. Can you clarify a bit more.

Hi,
So, at each node of the binary tree we want to split the data in two subsets. For this we first randomly select a set of feature/pixel locations and thresholds, and at each node select one combination that minimize/maximize a certain objective function (e.g., maximize information gain). Combination of feature locations and thresholds defines the set of split function i.e., at a selected feature location, if the feature value is greater than the selected threshold the sample in hand will go to left node, otherwise to the right node. Other options are you select two feature locations and define the split function based on the difference between their values, and so on there are many other options. I was just wondering which split function (feature value, difference of feature values, etc.) is used by default in scikit-learn since it can have a lot of impact on the final performance, e.g, difference of feature values will add more contextual information while splitting the data. In current case contextual information can be thought as how two different activation layers behaved at a certain pixel location.
Hope it clarifies the question a bit more.

Thanks for the note.
Please notice that we classify pixels independently. So when the Random Forest classifier classifies a pixel it does not know which pixel it is.
The split function used in the scikit-learn is the original one in the 2001 paper by Breiman.


Add character-based LOO

Adds character based LOO. Removes duplicate ICL examples, based on configured similarity measure. Phase 1 experiment directory created.
Note:

incontext.leave_one_out=false  should now be specified as incontext.leave_one_out=null
incontext.leave_one_out=true  should now be specified as incontext.leave_one_out=scenario_description (old behavior) or incontext.leave_one_out=characters

Seems fine to me, minor preference for making the parameter incontext.leave_one_out_strategy as the current name strongly implies a boolean (that and changing the parameter name will hopefully break more loudly and obviously if someone tries incontext.leave_one_out=true etc. moving forward since that parameter won't exist)

@dmjoy done!

Thanks @eveenhuis, merging in just a few


[Doc][Design] Add retractions doc to the design doc page

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @iemejia

Retest this please

Retest this please


Convenience initialised for stateless ViewStore

Adding convenience initialiser for ViewStore when state is Void.
Rationale for change:

It simplifies the creation of ViewStore from store.stateless allowing for ViewStore(store.stateless)
It mirrors the available initialisers for WithViewStore SwiftUI helper view, so that you can both use WithViewStore(store.stateless) and ViewStore(store.stateless)

Hey @siejkowski, thanks for the PR and sorry for the delayed response.
I think this is a good addition. We have been wary of adding overloads to TCA APIs, such as .binding and .scope, because when used in complex SwiftUI views they can really blow up the type checker. However, the ViewStore initializer is usually used in much simpler situations, such as a view/view controller's init, and so I think this is safe. Also, soon Swift may get equatable tuples and so we could probably remove this someday in the future.
@stephencelis what do you think?

Hey @siejkowski, thanks for the PR and sorry for the delayed response.
I think this is a good addition. We have been wary of adding overloads to TCA APIs, such as .binding and .scope, because when used in complex SwiftUI views they can really blow up the type checker. However, the ViewStore initializer is usually used in much simpler situations, such as a view/view controller's init, and so I think this is safe. Also, soon Swift may get equatable tuples and so we could probably remove this someday in the future.
@stephencelis what do you think?

@mbrandonw I think we can give this a shot. Seems safer than SwiftUI-related overloads.

Yeah let's do it! 👍


Include platform option in documentation: #1189 #738

Pull Request Check List
- [ ] Added tests for changed code.

[x] Updated documentation for changed code.

If it's a bug fix or only a documentation update, it should be based on the master branch.
#1189 #738
It is unclear that dependencies specific to a platform can be handled by poetry.

This is wrong.

it must match sys.platform. You should mention this in the documentation.
sys.platform is "win32" not "windows".

This is wrong, unless poetry has changed since the last time i checked, or unless i was wrong in #738.

it must match sys.platform. You should mention this in the documentation.
sys.platform is "win32" not "windows".

You're right, fixed.

/ unstale


CNExT - Conditions on Radiation Table Differ From Script to Script

In the cnext_device_exposure script, the condition on the Radiation table is:
WHERE F05257 > '000'            --F05257 = Radiation, Number of Treatments
AND RAD.F07799 > '00'      --F07799 = Radiation, Treatment Modality
AND RAD.F07799 < '99'
Per Mark: The rationale behind RAD.F07799 NOT IN ('00', '99') is that we only want to capture when radiation tx is done so kicking out 00 - No rad tx and 99 - unknown. Putting in the '' in the IN statement takes care of where there are no values (or it's NULL) for RAD.F07799 which we do not want ...
Handled where F07799 is NULL, empty, equal to '00', or equal to '99' by changing condition to F07799 > '00' and F07799 < '99'.
In cnext_procedure_occurrence, the condition is only:
WHERE F07799 > '00'
AND F07799 < '99'                      Shouldn't  F05257 > '000' also be in the condition?
In cnext_visit_detail, the condition is only:
WHERE F05257 > '000'                   Shouldn't AND F07799 > '00' AND F07799 < '99' also be in the condition?

Yes, all of these queries should have the same filter criteria
WHERE F05257 > '000' Shouldn't AND F07799 > '00' AND F07799 < '99'

These queries have been updated, but I'm having trouble with the P drive from home, so can't upload today. Will try tomorrow.

addressed with Change conditions on Radiation table #57


Fix error message from cirq.final_wavefunction

If I pass in a non-unitary circuit to cirq.final_wavefunction I get an error message with an incorrect suggestion to fix my code.  cirq.sample_wavefunction doesn't exist (did it ever?).  It should probably suggest cirq.final_density_matrix if the circuit contains channel or mixture operations.
cirq.final_wavefunction(
    cirq.Circuit(
        cirq.DepolarizingChannel(0.1).on(cirq.LineQubit(0))
    )
)

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-...> in <module>
----> 1 cirq.final_wavefunction(
      2     cirq.Circuit(
      3         cirq.DepolarizingChannel(0.1).on(cirq.LineQubit(0))
      4     )
      5 )

.../cirq/cirq/sim/mux.py in final_wavefunction(program, initial_state, param_resolver, qubit_order, dtype, seed)
    147     if not protocols.has_unitary(
    148             protocols.resolve_parameters(circuit_like, param_resolver)):
--> 149         raise ValueError(
    150             "Program doesn't have a single well defined final wavefunction "
    151             "because it is not unitary. "

ValueError: Program doesn't have a single well defined final wavefunction because it is not unitary. Maybe you wanted `cirq.sample_wavefunction`?

Program: cirq.Circuit([
    cirq.Moment(operations=[
        cirq.depolarize(p=0.1).on(cirq.LineQubit(0)),
    ]),
])

@vtomole can you please assign it to me.

Thanks @vtomole

@vtomole can you please suggest what needs to be done here?

@jitendrs Change https://github.com/quantumlib/Cirq/blob/61b4259db3401afd224dd9eebc83617c93ac341d/cirq/sim/mux.py#L152 to Maybe you wanted cirq.final_density_matrix?

fixed in PR #2844


Use module having constants as type

I have module and function:
module ROLE_LEVEL
    MANAGER = 9
    CUSTOMER = 1
    GUEST = 0
    BANNED = -1
end

# @param user [User]
# @param desired_level [ROLE_LEVEL::MANAGER, ROLE_LEVEL::CUSTOMER, ROLE_LEVEL::GUEST, ROLE_LEVEL::BANNED]
# @return [Boolean]
def check_level(user:, desired_level:)
    # ~~~
end

How to use ROLE_LEVEL as desired_level parameter's type?

The syntax you are using looks perfectly correct to me. Can you explain a bit more about what isn't working as expected?

@lsegal Sorry! I missed my needs.
I want to use ROLE_LEVEL as standalone type like:
# @param desired_level [ROLE_LEVEL]

or

# @param desired_level [ROLE_LEVEL::*]

not unpacked:
# @param desired_level [ROLE_LEVEL::MANAGER, ROLE_LEVEL::CUSTOMER, ROLE_LEVEL::GUEST, ROLE_LEVEL::BANNED]

What is correct way to represent that every constants in module could be type of param?

I want to use ROLE_LEVEL as standalone type like:

Realistically it's not one, so you shouldn't. The actual type you're using is a Fixnum here, which means technically the type is Fixnum and those constants are not actually enforced anywhere. The specification you have already is the correct way to do it, since these are actually discrete values not connected by any class besides the numeric type, but that's probably not a relationship you want to expose.
That said, YARD type specifiers are freeform text, so if you have a syntax that makes sense to you and your users, you can choose it. ROLE_LEVEL::* seems reasonable enough, though it won't auto-link constants.
If you really want to emulate enum types, you have a few options:

You can use classes and subclassing. This wouldn't change your API, but would add considerable boilerplate and complexity to your implementation; depending on how you're using these values, it may even add some minor performance overhead:

# @abstract Use subclassed types
class RoleLevel
  def to_i; raise NotImplementedError, 'must use subclass' end

  # @return [RoleLevel]
  MANAGER = Class.new(RoleLevel) { def to_i; 9 end }.new.freeze

  # @return [RoleLevel]
  CUSTOMER = Class.new(RoleLevel) { def to_i; 1 end }.new.freeze

  # @return [RoleLevel]
  GUEST = Class.new(RoleLevel) { def to_i; 0 end }.new.freeze

  # @return [RoleLevel]
  BANNED = Class.new(RoleLevel) { def to_i; -1 end }.new.freeze
end

# use as:
p RoleLevel::MANAGER.to_i

Then you can use # @param desired_level [RoleLevel] because it's actually a type now, just remember to .to_i to get the value.

More commonly, you can use symbols to represent the enum values. This is much more conventional in Ruby, since it treats discrete enum values the way they are meant to be treated: as discrete values. This would still mean listing each symbol out, but it simplifies the statement quite a bit:

# @param desired_level [:manager, :customer, :guest, :banned] the desired level...
def check_level; ... end

This of course needs some form of mapping, but that is easy to do via a helper method and a simple Hash.

Thank you a lot! 🙇♂
2nd way is reasonable to use.

Np. FYI I updated the 1st snippet with a bit of a more DRY implementation. Symbols are still generally more accepted than numeric const values for Ruby APIs though.


Force default vagrant provider to virtualbox.

This is the only provider that works for this box anyway.

Works for me


Update cygwin to 2.6.1

Since the file has changed and build are failing...

Current coverage is 79.80% (diff: 100%)

Merging #455 into master will increase coverage by 0.38%

@@             master       #455   diff @@
==========================================
  Files            18         18
  Lines          2075       2169    +94
  Methods         372        372
  Messages          0          0
  Branches        181        181
==========================================
+ Hits           1648       1731    +83
- Misses          427        438    +11
  Partials          0          0

Powered by Codecov. Last update ff509c0...a1c1f81

@dgolovin Can we get this merged? It should solve the failing builds / checks.

Released to master.
Thanks @jrichter1!


The false result value has the wrong type: element types must all match for conversion to list.

Hi, love this module. It solved a very important problem for us. However, I'm running into an issue after upgrading to 0.7.0. I was able to reproduce it with a minimal example.
Using this terraform:
terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "~> 3.94.0"
    }
  }
}

provider "azurerm" {
  features {}
}

locals {
  azs = module.regions.regions_by_name["eastus"].zones
}

module "regions" {
  source                   = "Azure/regions/azurerm"
  version                  = "0.7.0"
  recommended_regions_only = false
}

output "azs" {
  value = local.azs
}

Results in this error:
% terraform plan
module.regions.data.azurerm_client_config.current: Reading...
module.regions.data.azurerm_client_config.current: Read complete after 0s [id=Y2xpZW50Q29uZmlncy9jbGllbnRJZD0wNGIwNzc5NS04ZGRiLTQ2MWEtYmJlZS0wMmY5ZTFiZjdiNDY7b2JqZWN0SWQ9ZmY3ZDFiZDQtNjJiOC00MDNlLTg4OTMtMTQ2NzI5MzZkMzFmO3N1YnNjcmlwdGlvbklkPWFhZjkzODg4LTYxZTctNDk5ZS1hZmEzLWEzNGQ3ODBiOThhOTt0ZW5hbnRJZD1jNzM3OTZkNy0xYzAxLTRiMDctYjYyNS0xODE1ZWI2MzcxMmE=]

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Inconsistent conditional result types
│
│   on .terraform/modules/regions/locals.tf line 27, in locals:
│   27:   regions_recommended_or_not = var.recommended_regions_only ? [for v in local.regions_data_merged : v if v.recommended] : local.regions_data_merged
│     ├────────────────
│     │ local.regions_data_merged is tuple with 52 elements
│
│ The false result value has the wrong type: element types must all match for conversion to list.

Going back to the version we started with, 0.5.2, resolves the issue.

Thanks I will try and repro. I thought I had fixed this!


'NoneType' object is not subscriptable

getting this error when I try to run the Chatbot.ask() command

Same here, hoping it gets fixed.

same here

Same here as well.


Where is sjcl_ss.js?

In Android, it says:
E/AndroidProtocolHandler: Unable to open asset URL: file:///android_asset/www/plugins/cordova-plugin-secure-storage/www/sjcl_ss.js
It's non-existant in the repo..

Closing due to inactivity


[entropy_src] Solve remaining TODOs in RTL code

This PR contains two commits to resolve remaining TODOs in the RTL (for details see commit messages) as well as a third commit which is a minor drive-by cleanup.  This PR is required for D2.5 sign-off.

Thanks for your review @marnovandermaas! CI passed and I am thus merging this.


Remove velocity override code (pushMotion)

https://github.com/ros-industrial/staubli_val3_driver/blob/55b4fe6d3fbc60fa7a89139aa0f195c5d3c62072/staubli_val3_driver/val3/ros_server/pushMotion.pgx#L72-L79
Sets the velocity to the value set on the teach pendant if 'velocity override' is enabled. This does not seem to work as intended since the velocity set on the pendant already "overrides" whatever value is set in the Val3 code. The result is that the "overridden" velocity ends up being much smaller than intended.
I.E. if 50% velocity is set by the pendant, the actual speed of the robot will be 50% (result from getMonitorSpeed() ) multiplied by another 50% (set by the pendant) = 25%

As I wrote in https://github.com/ros-industrial/staubli_val3_driver/pull/8#discussion_r369798953, I believe it'd be best to remove the override: it reportedly doesn't work as intended.
I'll change the title of this issue to convert it into an action item.

I have this removed in a branch here ready to make a pull request whenever the previous one is approved.

It would probably be good to rebase your new branch once #8 gets merged.

I've linked this to #9, as it (starts to) remove(s) the velocity override.

Seeing issues like #2 (and the attempts to fix this in #8 and then #18), perhaps the rationale behind the velocity override functionality was exactly the problems we're encountering now?


Fixed docs to include Friend Picker and Added FriendPickerMessage

Added FriendPickerMessage so a bot can get the proper type of message after a user picks a friend (Not UnknownMessage).
Documented FriendPickerMessage and FriendPickerResponse object types.

:shipit:


Update otel integration with GettingStarted Dashboard

Description
Adding getting started tutorial dashboard and improve the fluency of the demo
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

getting started has moved to the website-documentation


Add two optional options that are used to skip dialogs

Users of the plugin (including me) may want to create a seamless experience for their users and not show any dialog prompts. This patch allows two additional options when calling the checkAppUpdate() function.

skipPromptDialog (when true, then the plugin immediately and silently starts downloading an update when found)
skipProgressDialog (when true, then the plugin does not show the progress bar dialog, and instead does it in the background)

This was inspired by pull request https://github.com/vaenow/cordova-plugin-app-update/pull/78, and incorporates the request to make it an optional feature.

I have reviewed your code, it looks good. Thank you @loban for your a lot of contributions 🍻


PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona…

…l Tables

@gjacoby126 for your logging comment, it will complicate the code to get index name and table name at that part of the code. I can print the hashmap though


stable/rethinkdb expose cluster without exposing admin ui

Currently if you expose the service with a loadbalancer, using:
kubectl expose deploy _cluster-name_-proxy --type=LoadBalancer --name=external-access
It exposes all three ports on GKE. These are 28015, 29015, 8080. I want to only expose 28015 without exposing 8080.
-->
Is your feature request related to a problem? Please describe.
The deployment has all three ports instead of an alternative architecture, say 3 different deployments per port that relates to..
Describe the solution you'd like
Potentially 3 different deployments or another way to expose just port 28015 to be able to access from outside the cluster.
Describe alternatives you've considered
https://webhookrelay.com/v1/examples/relay-ingress.html
Additional context
The webhook relay ingress method would technically work, but I want to avoid lock-in and not have to subscribe to another online service.

nvm I was able to solve my needs by exposing a single pod in the statefulset instead using the guide here:
https://itnext.io/exposing-statefulsets-in-kubernetes-698730fb92a1
I exposed 2 pods in the cluster and am connecting to them with my driver. hope this helps someone in the future!


wrong font-family in some elements

style bug in @angular/material": "^6.4.6" theme -
all typography should inherit the same font family declared in mat-typography-config
but some elements have their own font-family style -
.mat-button-toggle, .mat-card {
font-family: Roboto,"Helvetica Neue",sans-serif;
}

Here it is...

Each component can be configured individually through the typography API: https://material.angular.io/guide/typography

the issue occurred because of including mat-core followed by mat-base-typography individually which resulted in a duplication of some typography style. I would still like to leave out the typography mixin to be included separately and not within the mat-core

That would unfortunately be a breaking change; anyone who doesn't include that mixin would stop getting the default typography styles.

that's true @jelbourn. but perhaps in the future you could consider optional @include of a minimal theme


add optional attr prev_cur_next_products for ProductRetrieveView

related #734

with django-shop1.2 and polymorphic and  djangorestframework==3.9.2:
With prev_cur_next_products = False, it  finds product.product_code with SmartPhoneModel,   SmartCard, Commodity.
but:
With prev_cur_next_products = True, there is a bug when i try view with product SmartPhoneModel, it does not find the product.product_code, whereas it finds it for SmartCard, Commodity.
(Currently not available)

backoffice error:
  File "/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/python3.8/site-packages/cms/utils/decorators.py", line 20, in inner
    return func(request, *args, **kwargs)
  File "/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/python3.8/site-packages/django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "/python3.8/site-packages/rest_framework/views.py", line 495, in dispatch
    response = self.handle_exception(exc)
  File "/python3.8/site-packages/rest_framework/views.py", line 455, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/python3.8/site-packages/rest_framework/views.py", line 492, in dispatch
    response = handler(request, *args, **kwargs)
  File "/haricot/.cache/pypoetry/virtualenvs/my-shop-et1pgCPw-py3.8/src/django-shop/shop/views/catalog.py", line 225, in get
    serializer = self.serializer_class(context=context, **kwargs)
  File "/haricot/.cache/pypoetry/virtualenvs/my-shop-et1pgCPw-py3.8/src/django-shop/shop/serializers/defaults/catalog.py", line 46, in __init__
    instance = self.get_instance(context, data, kwargs)
  File "/haricot/.cache/pypoetry/virtualenvs/my-shop-et1pgCPw-py3.8/src/django-shop/shop/serializers/defaults/catalog.py", line 92, in get_instance
    'product_code': product.product_code,

Closed in flavor of better approach.


[Event Hubs] March Release Prep

Summary
The focus of these changes is to prepare the Event Hubs core package for the March release.

API change check
API changes are not detected in this pull request.


bpf: clean up some unneeded includes

Motivated by trimming down the wireguard.h usage.

/test

/test


Support for NO_COLOR env variable

Would be nice to support the NO_COLOR env variable. Would a patch for this be accepted?
Currently the variable SYNTAX_HL can be set to false as \set SYNTAX_HL false upon entering usql; but would be nice to have the NO_COLOR env variable set and respected.
https://no-color.org/

Yeah, sure this would be fine. I'll add it when I have a chance.


Added premailer to inline all css rules

Depends on https://github.com/drone/drone-go/pull/19

After merging the bugfix for drone-go we should even get on gmail nice looking HTML mails as you can see below.

LGTM

LGTM


fix: update on-pull and on-push pipelines

Need to fix these so that changes can be promoted in infra-deployments
What does this PR do?:

Which issue(s)/story(ies) does this PR fixes:

PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

/test application-service-e2e

/test application-service-e2e

Sorry for the confusion. The e2e tests job won't run on this repo, since it's always failing to get a cluster. I think somebody disabled the cluster access to this repo to save costs.
So, we can ignore the job failures and merge the PR whenever we see fit.


Module 'fluttertoast' not found - xcode 14.2 simulator

Module 'fluttertoast' not found, getting error when trying to run on simulator

simulator support merged in main, can be found on latest version


Add readTree() to AwsS3UrlReader, ReadableArrayResponse type, and AwsS3ReadTreeProcessor

Hey, I just made a Pull Request!
Add readTree() to AwsS3UrlReader
Add ReadableArrayResponse type
Add AwsS3DiscoveryProcessor
Close #6795
:heavy_check_mark: Checklist

[x ] A changeset describing the change and affected packages. (more info)
[x ] Added or updated documentation
[x ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ x] All your commits have a Signed-off-by line in the message. (more info)

some test errors still!

Hmm, not sure why the prettier block in the Build microsite / build-microsite check is failing. Shows a warning for sidebars.json .

Ah, see what you mean. Looks like a rebase did it. I think we are good to go?

Hello, I wanted to ask is there any additional work that needs to be done on this?

Looks like prettier is warning about plugins/catalog-graphql/src/graphql/types.ts.
Haven't touched this file, any way to fix this?

@seant-splunk you have touched it, last file in the PR 😅
Maybe you can drop it from the commit that changed it, or just go format the file and push the change

@seant-splunk you have touched it, last file in the PR 😅
Maybe you can drop it from the commit that changed it, or just go format the file and push the change

Yep, lol, my bad! No idea how that happened. Ok, looks like I've restored it on my end

Hey all,
Apologies for pinging again. My internship is ending this Friday so I will no longer have access to this fork. Another engineer from Splunk will pick up where I left off, so the PR is not dead in the water. Just wanted to work on and refine and receive any final feedback on this before I end!

Alright, looks like its good to go?


Duplicate Cosmic Settings Desktop Entries

This issue might belong in upstream, but I wanted to bring it up here first. I'm not entirely sure what is causing this issue. Very low severity, just a little bit confusing why there's two entries.

I have the same issue for both Cosmic Settings and Nextcloud Client but no other apps.


How to integrate the CodeMirror XML Lint to CodeMirror

I have a textarea that has been integrated with the CodeMirror using the Nuxtjs/Vuejs, I would like to highlight the error and show the X button with information next to the line if there are any syntactical errors in XML. I tried many things but nothing seems to work. However, a similar approach works for the JSON-LINT.
I came across your response and tried it but nothing is working as I want. Can you please let me know how to create XML Lint within CodeMirror to highlight the Syatatical error in XML by showing X button with information against the line number?
I have the code sample here in CodeSandbox: https://codesandbox.io/s/great-browser-gfzdf?file=/pages/index.vue
Any help would be really appreciated. Thanks in advance.

I suggest referring to the official Codemirror Repository by Marijn and asking there.


Icon request: The University of Chicago (UChicago)

URL for the brand / site / app
https://www.uchicago.edu
Logo resources for the icon
https://uchicago.app.box.com/s/9w9vxlocyv9msmz3vi867ma4cednz22k/file/793419057974
Proof of the Aegis-compatible 2FA
University site for 2FA: https://cnet.uchicago.edu/2FA/index.htm
Anything else?
use duo-bypass to enable other TOTP/HOTP authenticators: https://github.com/revalo/duo-bypass
I tried and it worked.
Confirmation

[X] I have read and followed the issue guidelines & issue form.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/The University of Chicago.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


Convert aten.split to ttnn.split

Ticket
None
Problem description
Convert torch.split to ttnn.split
What's changed

[ ] Convert aten.split to ttnn.split
[x] Test the conversion

Even a symmetric split fails with FPE :monocle_face:
tests/lowering/tensor_manipulation/test_split.py Fatal Python error: Floating point exception

Thread 0x00007fd9d9ffb700 (most recent call first):
  File "/usr/lib/python3.8/threading.py", line 306 in wait
  File "/usr/lib/python3.8/threading.py", line 558 in wait
  File "/home/jdh8/venv/lib/python3.8/site-packages/tqdm/_monitor.py", line 60 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap

Current thread 0x00007fda41e6a740 (most recent call first):
  File "/home/jdh8/venv/lib/python3.8/site-packages/ttnn/decorators.py", line 326 in __call__
  File "<eval_with_key>.13", line 6 in forward
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520 in _call_impl
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511 in _wrapped_call_impl
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/fx/graph_module.py", line 304 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/fx/graph_module.py", line 738 in call_wrapped
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/_aot_autograd/utils.py", line 81 in g
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/_aot_autograd/jit_compile_runtime_wrappers.py", line 118 in rng_functionalization_wrapper
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/_aot_autograd/utils.py", line 105 in call_func_at_runtime_with_args
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 94 in runtime_wrapper
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/_aot_autograd/utils.py", line 81 in g
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_functorch/aot_autograd.py", line 901 in forward
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_dynamo/external_utils.py", line 17 in inner
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py", line 489 in _fn
  File "/home/jdh8/pytorch2.0_ttnn/tests/lowering/tensor_manipulation/test_split.py", line 13 in forward
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520 in _call_impl
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511 in _wrapped_call_impl
  File "/home/jdh8/venv/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py", line 489 in _fn
  File "/home/jdh8/pytorch2.0_ttnn/tests/lowering/tensor_manipulation/test_split.py", line 38 in test_split
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/python.py", line 195 in pytest_pyfunc_call
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/python.py", line 1789 in runtest
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 167 in pytest_runtest_call
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 260 in <lambda>
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 339 in from_call
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 259 in call_runtest_hook
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 220 in call_and_report
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 131 in runtestprotocol
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/runner.py", line 112 in pytest_runtest_protocol
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/main.py", line 324 in _main
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/home/jdh8/venv/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/config/__init__.py", line 167 in main
  File "/home/jdh8/venv/lib/python3.8/site-packages/_pytest/config/__init__.py", line 190 in console_main
  File "/home/jdh8/venv/bin/pytest", line 8 in <module>
Floating point exception (core dumped)

For now, ttnn.split only supports splitting to two equally sized tensors.  I'm thinking of converting unsupported cases to ttnn.slice:

aten.split.Tensor that does not split in halves
Any aten.split_with_sizes.default


Update Wordpress tutorial

Update the tutorial and the starter config file.

I have the first half done.  I just need to update the starter config file.

One other thing I forgot to mention is that we aren't including wp-config.php files in our tugboat directory we are doing something like the following
- |
          # If wp-config.php file exists
          if [[ -f wp-config.php ]]; then
            rm wp-config.php
          fi
          # Use the tugboat-specific wp-config.local.php
          wp --allow-root config create --dbname="tugboat" --dbuser="tugboat" --dbpass="tugboat" --dbhost="mysql" --dbprefix="${WORDPRESS_DB_PREFIX:-wp_}"

That way we don't have to maintain multiple files in a project for simple wp-config.php examples.

One other thing I forgot to mention is that we aren't including wp-config.php files in our tugboat directory we are doing something like the following
- wp --allow-root config create --dbname="tugboat" --dbuser="tugboat" --dbpass="tugboat" --dbhost="mysql" --dbprefix="${WORDPRESS_DB_PREFIX:-wp_}"

That way we don't have to maintain multiple files in a project for simple wp-config.php examples.

We had something like this in our config file previously, but in the past I've found that there are often unique settings that we want to include in local or Tugboat environments, so having them stored in a separate file made it easier to customize each environment.  At least we'd do this frequently in Drupal sites.  If Wordpress will work by setting those things using the command line tool, that does indeed simplify things.  I was aiming for flexibility but maybe that's not needed.


Is it possible to call the Admin API using the HTTP protocol?

Super admin users
https://opensearch.org/docs/latest/security/access-control/users-roles/#super-admin-users
Super admin users API

System index search
Security config update
...

Current possible scenarios
Call by sending admin certificate information to the server
curl -k --cert ./ca.crt --key ./ca.key  -X PUT "https://{IP:PORT}/_plugins/_security/configupdate"
Proposal
It would be beneficial if some Admin APIs could also be called using basic auth or JWT token-based authentication, rather than just being restricted to certificate-based authentication.
The current requirement to use HTTPS in order to send certificates adds additional constraints.
In certain situations, information like roles and role mappings might change frequently at runtime, so it would be helpful to have an easier way to call these APIs. The existing method seems to be somewhat less user-friendly.
What do you think about this?

https://opendistro.github.io/for-elasticsearch-docs/docs/security/configuration/security-admin/#configure-the-admin-certificate
I understand that this specification has existed since the opendistro days, so making immediate changes might be difficult. However, I'm curious if there is any possibility of easing the restrictions in the future to improve usability.

[Triage] @10000-ki , the admin certificate should work when https is disabled. Are you experiencing an issue using the admin certificate when https is disabled?
I'm hesitant to open up /configupdate to user other than superadmin connecting with admin cert because this endpoint allows a user to re-configure what authentication mechanisms are configured (including removing all of them). The admin user exists outside of what's configured in the authc and can always be authenticated.
One thing that is possible is exposing dedicated APIs to update portions of the securityconfig. f.e. see this PR which creates APIs to update auth_failure_listeners.


Redundant resolver types in generated typescript

Description
The outputted TS contains redundant type info.
Steps to reproduce
Here's my schema:
type Query {
  foo(bar: String!): String!
}

Now, I run yarn graphqlgen and check the outputted code in graphqlgen.ts:
export namespace QueryResolvers {
  export const defaultResolvers = {};

  export interface ArgsFoo {
    bar: string;
  }

  export type FooResolver = (
    parent: {},
    args: ArgsFoo,
    ctx: Context,
    info: GraphQLResolveInfo
  ) => string | Promise<string>;

  export interface Type {
    foo: (
      parent: {},
      args: ArgsFoo,
      ctx: Context,
      info: GraphQLResolveInfo
    ) => string | Promise<string>;
  }
}

but this contains two identical typings for the foo resolver: one called FooResolver and another, separate but equivalent definition for QueryResolvers.Type.foo.
Expected results
Something like
export namespace QueryResolvers {
  export const defaultResolvers = {};

  export interface ArgsFoo {
    bar: string;
  }

  export type FooResolver = (
    parent: {},
    args: ArgsFoo,
    ctx: Context,
    info: GraphQLResolveInfo
  ) => string | Promise<string>;

  export interface Type {
    foo: FooResolver;
  }
}

Versions

graphqlgen: 0.3.0
OS name and version: macOS 10.14

Thanks a lot for raising this issue. This might be a bit counterintuitive but this is actually intended and a design goal. See here for more details.
TLDR:

Embrace code redundancy. Opposing to the generally desired DRY principle, in the case of generated code, it's more important to be readable and to provide as much context as possible without the need to navigate a lot through the code first. (This also allows for more helpful auto-completion/intellisense.)

@schickling I was about to open a similar issue tonight. Luckily saw this one.

it's more important to be readable and to provide as much context as possible without the need to navigate a lot through the code first.

Hm, I don't think I agree that having Type fields be literally code copied instead of references is more readable; Its not what most developers would do and IDE should take care of making peaking references and generally navigating/viewing type data trivial. So IMO readability is a bit better with references.

This also allows for more helpful auto-completion/intellisense.

How so?

Related #236
I believe this needs to be reconsidered in light of #428.


Renaming

With considering the further development and transition to an architecture with plugins, more than one repository (the main source, documentation, cli and official plug-ins) will be required. Seems like it makes sense to create a separate organization for this.
If so then perhaps I need to change the name to an easier and more attractive. Moreover, there will be no dependence on D3.js
What do you think about it?

I totally agree with the renaming. As I wrote in https://github.com/Ni55aN/d3-node-editor/issues/98#issuecomment-387626133

Proposing a name is rather tricky :/. node.js is kind of taken :D

If we go for easy and pragmatic, I would say "Node Editor" or "Logic Node Editor". As those where key words when I searched for this thing.
I dislike "Cool" names like "Awesome Node director", or "Ninja Node Editor", as that makes a Lib sound more like a joke.  In same time it gives a project some authenticy. So, anyway, its up to you @Ni55aN - I have given my 15 cents to this.

Here is my input:
Simplest change would be to just Node Editor.
To use an abbreviation: Yane or YaneJs (Yet another node editor)
You probably should get rid of the word "node" to get a better differentiation towards nodejs.
In PLC programming this style of programming is called function block diagram (FBD). A name here could be FubloJs.
Also the word flow could be used: FlowBlockEditor or FlobloEditJs, FlobloJs
As you can see I like short names more than long one containing whole words. Good luck for finding the right name!

@Legiew
Just "Node Editor" will clash with Node.js editors (IDE's) like hell - true.
The "JavaScript" or "JS" key-word is a must be, as that what it is. Not for all languages orsmth.
Stuff like "FubloJs" will have like no hits for google, until the project-repo will get popular. Majority of people will search with words "Node", "Editor", "Javascript/js" and "Logic" or "Flow". Another bunch for "Visual programming".
So for simple, I would choose: "NodeEditorJS" or "VisualNodeEditorJS"

Yeah you're right. A readable name should be better for the start.
Because of the node naming issues I personally would totally get rid of the word in the name.
I also thought about the word editor and imho it isn't suitable here, too. It is an editor sure, but it is also en executing engine.
So I would choose then FlowBlockJs. I first thought it could be an issue because the lib is called node editor atm and people will struggle with a different new name, but it is possible to deprecate it on npm and display a message after installing. An a link in the current Readme to the new project/organisation will do the rest.

Actually it's not so bad with that "node" name. When I google now "node+editor+javascript", I do not get any Node.js stuff in first page. Even got something like this > https://www.reddit.com/r/javascript/comments/4y5q0n/neditorjs_node_editor_ui/.

So far, picked up one of the unoccupied and more suitable names is easeflow.
Still I think over others

anynode

I would suggest then easeflowJS or anynodeJs

@trsh npm prefers packages without ending js (for instance, three, vue, react)

logic-flow, prog-flow (programmatic-flow chart), p-flow,

As for me, among the latest samples, rete is more appropriate

easy to pronounce and remember
there are no similar names (also names in the network are unoccupied)
close to the dataflow in meaning

What do you think?

since I have been looking for a short, unoccupied and suitable name for more than a day, I stopped on rete
mone - a modular node editor (npm busy)
uni - universal node editor (also)

@trsh @Legiew @omega-tree thanks for your kind approach

@rete stands for what? :)

network, system


Replace obsolete postgresql image with postgresql-10-rhel7

Signed-off-by: Emiliano Suñé<EMAIL_ADDRESS>

Also updated the readme in the docker folder as it didn't mention the requirement for von-network, and updated a broken link to the instructions for running it.


Improve the manual

Some of you might have noticed that our long README was recently replaced by a manual (http://rubocop.readthedocs.io/en/latest/). This was just the first step, however, as the content of the manual was simply lifted from the README and rearranged a bit. To get where I want us to be we need to:

improve the prose a lot (which is related to extending many of the existing sections with additional explanations and so on)
add some listings of all the cops (e.g. as in http://www.foodcritic.io/#FC003)
add sections on extending RuboCop
add some FAQ/troubleshooting sections

I think this is one of the most important task for the project going forward and I'd love it if you could lend me a hand with it!

SCSS Lint's list of linters is a really good example to base the cop listing off of: https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md

+1 on listings of all cops. I am new to RuboCop and just read through the manual and README. I was continually frustrated by the lack of a reference for all the standard cops. Eventually I discovered I could run $rubocop --show-cops.

PRs welcome. :-) Unfortunately I'm really short on time and won't be able to tackle this myself in the foreseeable future.

@bbatsov: Tangentially related. I have quite a bit of supporting material I created for myself to learn how to contribute to the codebase. Do we have something like a developer manual? If not, do we want one? If so, where do you think it should go? 😀

Just add a new section to the existing manual.

I created an index of all available cops and added the description and the URL to the StyleGuide, which you get by $rubocop --show-cops.. Now manual/cops.md is a really large file. What do you think about  splitting it up:

cops.md:

overview and description of the cop-types
index of all cops-titles with links to detailed information

seperate file for each type eg. cops_style.md, cops_rails.md:

including description, examples for each type

Still open for the overview:

examples for each case

Do we have something like a developer manual? If not, do we want one? If so, where do you think it should go?

I've added development.md in #3533 .
https://github.com/bbatsov/rubocop/blob/master/manual/development.md


Dealer without Reg-ID / forgein key should be IDP-ID and not mail

Instead of using an email (that can change between convention reg and dealer reg) use the IDP-ID as foreign key to identify the user.  At EF a user can have up to three different email adresses at the moment. (identity, EF reg, dealer reg)

Does the Regsys API provide the IDP ID? I think last year it didn't, hence the fallback to the email.

The EF Registration System currently doesn't expose the IDP ID and also does not allow us to query using it. There may be an option to retrieve registration information by IDP ID in the future though, not sure whether that will be in the books for this year though.


Azure Firewall Structured Logs seems to be working with or without the feature "AFWEnableStructuredLogs" enabled

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/d365community/forum/79b1327d-d925-ec11-b6e6-000d3a4f06a4.

Azure Firewall Structured Logs seems to be working with or without the feature "AFWEnableStructuredLogs" enabled

@somarnebur
Thanks for your feedback! We will investigate and update as appropriate.

@somarnebur , per the PG confirmation, Azure Firewall Structured Logs only works when the feature "AFWEnableStructuredLogs" is enabled by the customer.
There are a few subscriptions where this feature may have been enabled by the backend team internally on demand. When enabled by the backend team internally, the Azure Firewall Structured Logs will work even if you see the feature "AFWEnableStructuredLogs" unregistered on your end because the backend team uses an internal feature flag to enable this setting. This setting was manually enabled by the backend team on a few subscriptions for testing during the preview phase and is not a generic behavior.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Ad Creation Tool: Modify exiting editor to create ad creation tool

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

Closing as there is another PR here https://github.com/rtCamp/web-stories-ad-tool/pull/11


6 set nnunet default num of preprocessing to 1

Change default for parallel preprocessing to 1, as parallelized setups crash due to suspected Windows configuration issue.

Runs successfully preprocessing through training with number of configuration arguments reduced due to new defaults.


Add VuePress build to test action

Add VuePress build to test action

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (38e25d3) to head (3b0f610).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           65        65
  Branches         7         7
=========================================
  Hits            65        65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Untranslated]: Location - Sunken Ship

Monster Arte

Made the hex change in the enemy files. Should be good in the next patch.


add teleop joy node

joystick tests cannot be done!

No plans for now to get neo_teleop to be upstreamed. We will use joy_teleop for this!


Boolean shorthand predicate should return false when not matching

Currently, when using the boolean shorthand predicate, then the condition doesn't match, nil is returned.
Instead, false should be returned.
Example
defmodule Todo.List do
  infer :archived?, when: %{archived_at: {:not, nil}}
end

iex> %Todo.List{archived_at: nil}
...> |> Infer.get!(:archived?)

# current result
nil

# new result
false

Migration
This change is backward-incompatible.
To migrate, users must go through all conditions matching boolean shorthand predicates with nil, and replace that with false.

I think I managed to do this. The process is as follows:

Filter out rules that have a boolean value,
Group these rules by their key,
Select only rules that have only one possible value (true or false),
Create a rule with the inverse value and insert it after the last rule with the same key.

Example of the result:
rules = [
  %Dx.Rule{key: :test, value: false, when: %{something: true}},
  %Dx.Rule{key: :test, value: false, when: %{something_else: true}},
  #Rules below should not be affected
  %Dx.Rule{key: :test2, value: false, when: %{something: true}},
  %Dx.Rule{key: :test2, value: true, when: %{something_else: true}},
]
# After injecting the fallback
[
  %Dx.Rule{key: :test, value: false, when: %{something: true}},
  %Dx.Rule{key: :test, value: false, when: %{something_else: true}},
  %Dx.Rule{key: :test, value: true, when: %{}},

  %Dx.Rule{key: :test2, value: false, when: %{something: true}},
  %Dx.Rule{key: :test2, value: true, when: %{something_else: true}},
]

Yes, that's a great approach, @Zurga, thanks a lot for looking into this.
It goes in the right direction, but I suggest making it more strict:

Only boolean shorthands should imply the other boolean rule. As soon as you write out an explicit result, it should not be modified. Example:
infer archived?: true, when: %{archived_at: {:not, nil}}

Multiple boolean shorthands for the same predicate should be disallowed, I think. When there are multiple conditions, on which it can match, one can use a list (logical OR) to combine them. For example:
# allowed
infer :archived?,
  when: [
    %{archived_at: {:not, nil}},
    %{created_at: {:on_or_before, ~D[2022-01-01]}}
  ]

# not allowed
infer :archived?, when: %{archived_at: {:not, nil}}
infer :archived?, when: %{created_at: {:on_or_before, ~D[2022-01-01]}}

What do you think?

Thanks, I really like the idea of this project!
On point 1: I am a lazy, forgetful person who does not want to write fallbacks :p, so I figured it would be good to generate the inverse even if the value is set. The DSL would be 'helpful'. It does also touch on a fundamental thing in my opinion: can an inference have different types as values? I find it logical that if a boolean is used, the value can then only be boolean and thus an inverse can safely be applied if only one possible value is given.
On point two:
I would allow both to be honest, unless it becomes a perfomance issue, but even then the parser could provide optimizations. What would be the reason to enforce a strict style?
Thanks for the swift response!

Thanks, I really like the idea of this project!

Thank you, glad to hear that. How did you hear of it initally, if I may ask?

On point 1: I am a lazy, forgetful person who does not want to write fallbacks :p, so I figured it would be good to generate the inverse even if the value is set. The DSL would be 'helpful'.

That's a fair point. It saves time while writing it. However, as a "lazy, forgetful person" you would probably save much more time and energy in total, because you only write these rules once (or whenever they change) but read them a dozen times after. This is where being explicit saves time IMO, because you don't have to think as much when you clearly see what the fallback is. That's one aspect why Elixir generally favours "explicit over implicit".

can an inference have different types as values?

Yes, this is currently the case, and it's by design. Dx should be flexible, so you can use it to return knowledge from your schema+logic and then do things with this knowledge. My idea was to not limit what can be returned, especially not when Dx is not widely used (yet) so that any usage patterns or best practices have emerged. It's more of an experimentation ground for now. It works, but how exactly it can and should be utilized is still open.
These are my main reasons for favouring a stricter approach when using explicit result values (and no boolean shorthand).

On point two:
I would allow both to be honest, unless it becomes a perfomance issue, but even then the parser could provide optimizations. What would be the reason to enforce a strict style?

There's no performance issue. It's just my idea of how the boolean shorthand feature would be used. It's also easier to implement, and loosening a strict version - if done in the future - is backward-compatible, whereas making things stricter in the future would not be.
That being said, I'm fine with allowing multiple boolean shorthands for the same predicate, if you think it makes sense 👍
If you'd like to give it a shot, most code that needs to be changed (apart from docs) should be in lib/dx/parser.ex. My initial approach would be to add a boolean_shorthand? field (or similar) to the Dx.Rule struct and take it from there.


Add ingest.sh script.

Data Management (data ingestion in a first step) is a common requirement for several of our eoapi-k8s deployments and projects.
From my perspective we should think about data on eoAPI as "content" and not so much as "configuration". While configuration should be in code and part of the reproducible deployment, content should me managable by an admin user. At some point we probably want to think about building some auth-supported API to allow management, eventually even connecting it to some user interface.
This PR consists in a first simple step to add very basic ingestion as a bash script ingest.sh and the related make ingest command, it:

looks for a kubernetes the eoAPI raster pod in the namespaces eoapi and default
it installs pypgstac on it
it uploads collection.json and items.json from the current directory (can be overridden with the environment variables EOAPI_COLLECTIONS_FILE and EOAPI_ITEMS_FILE.
it pypgstac loads the collection and items into the pySTAC postgresql database.

Related to https://github.com/EOEPCA/data-access/issues/107
fyi, @j08lue, @emmanuelmathot, @zacharyDez

I dived a bit more into this topic. The best way to have an API seems to be relying on the stac-fastapi-pgstac endpoints implementing the STAC API Transactions extension. Currently there is no simple way to protect these endpoints. Currently people doing this either using an API Gateway, or writing a custom stac-fastapi-pgstac.
Anyway this ingest.sh script and command will ease up the ingestion in the meantime.

Many thanks for your reviews! :heart:


Fix typo: wich -> which

Pull Request Test Coverage Report for Build 852

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.22%

Totals

Change from base Build 847:
0.0%

Covered Lines:
2393

Relevant Lines:
4452

💛  - Coveralls

I think I need a dictionary... :) Thx


perform backup of existing configurations

create a persistent backup of preexisting config that can be recovered or leveraged by the converter

completed 10/4


Add changes to ballerina streams example & remove redundant changes

Purpose

$subject.

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-0.990.0@091afd7). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release-0.990.0   #12733   +/-   ##
==================================================
  Coverage                   ?   59.85%
  Complexity                 ?      659
==================================================
  Files                      ?     2066
  Lines                      ?   101584
  Branches                   ?    12925
==================================================
  Hits                       ?    60800
  Misses                     ?    35597
  Partials                   ?     5187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091afd7...d8f044e. Read the comment docs.


Update README.md - test PR

Closes: #XXX

Be noted that XXX is the issue ID

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....)

It works #151


I suggest adding statistics for Aural style sheets which contain CSS properties such as "speak....

I suggest adding statistics for Aural style sheets which contain CSS properties such as "speak."
Aural Style sheets: http://www.w3.org/TR/CSS21/aural.html

This issue was imported from Google Moderator
Moderator votes: +3
Issue added by Rebecca on 2013-10-11

+1

+1

+1

+1

+1

+1

+a

+1

+1

(Aural has been superseded by http://www.w3.org/TR/css3-speech/ )

+1

+1

There is very little info on this. It would be great for this to be included.
+1

+1

+1

+1

+1

+1

+1

Why is there no movement on this three year old issue.

CSS 2.1 Aural has been deprecated: https://developer.mozilla.org/en-US/docs/Web/CSS/Aural
As @rogerfrace pointed out, for CSS 3 there's the Speech module.

The CSS Speech module is a re-work of the informative CSS2.1 Aural appendix, within which the "aural" media type was described, but also deprecated (in favor of the "speech" media type). Although the [CSS21] specification reserves the "speech" media type, it doesn't actually define the corresponding properties. The Speech module describes the CSS properties that apply to the "speech" media type..

@frob note that this issue is currently behind 4 others in the list of requested features so there's clearly interest. And maybe we can other developers to +1 this?
Suggestions for where to go from here:

We should close this issue, and move discussion (and +1's to here: https://github.com/Fyrd/caniuse/issues/1240

Anyone with time could contribute a pull request. For base data, you could start here.

Sidenote, I just ran across a good article about CSS Speech. (Also, you'd think with the popularity of voice based devices this will become increasingly important!)

Good to see some discussion!
And thanks for the excellent css-tricks link. It touches on various topics I think are under-explored.
I'd be happy to see this issue closed and migrate our attentions to #1240
I was aware about CSS 2.1 Aural -> CSS 3 speech. Although there is very little information about what is currently going on with CSS 3 speech implementations. Caniuse is the first place I look for such data, so the vacuum is striking. The impression given is that the whole effort is stagnating or even deprecated, although this must certainly be incorrect.
Primarily there should be coverage in caniuse of CSS 3 speech, with CSS 2.1 Aural mentioned in a stub that points to the CSS 3 speech resources.
As I see it, there are two 'real-world' usage concerns here:

Browser support for css 3 speech
Screenreader support for css3 speech

It's all very well if a browser doesn't complain about css3 speech properties, or even does something useful with them, when using the speech synth features, but until screenreaders are standard features of ordinary browsers (go Opera!), what (I believe) we most sorely need is data about how screenreaders handle those properties.
Perhaps bolt-on screenreaders fall out of the scope of caniuse. But what to make of browser vendors that have delegated screenreading to the OS they themselves control. (viz. Apple's Safari with VoiceOver and Microsoft's Edge/IE with Narrator)? It's reasonable to expect that these vendors have allocated some 'design thinking' resources to how the browser and the system-level screen reader interact, and web content professionals will need to know how well they are doing.
Screenreader support for css3 speech is something that needs tracking somewhere, now that WCAG is being mandated across North America, in the EU and in various other regions. If not in caniuse, then where?
It's time to get the ball moving again.

+1 for this from @brennanyoung:

Primarily there should be coverage in caniuse of CSS 3 speech, with CSS 2.1 Aural mentioned in a stub that points to the CSS 3 speech resources.

Let's keep this issue open until "CSS 2.1 Aural mentioned in a stub" is implemented, and meanwhile focus discussion specific to CSS 3 Speech Module to #1240.

OK I just committed a stub for CSS 2.1 Aural. I left all the default versions in, but changed the support flag to "n". AFAICT this is correct, although we perhaps don't need ALL those browser versions listed. (Is there a preferred way to trim those to the minimum "not gonna happen" setting?
The Travis CI build failed, though. Not sure why. I am pretty sure my JSON is well-formed. What am I doing wrong? Sorry, still getting used to github!

@brennanyoung Is there a PR that needs checking? I don't see anything linking any commit and this issue.

@frob
as per https://github.com/Fyrd/caniuse/pull/4263#issuecomment-390559022
So, now the 'stub' appears as a search result, rather than a full entry.
This is quite suitable. When we get the CSS 3 Speech data in there, the stub should also point to that.

Should this issue be closed now or do you want to leave it as a reminder to add the speech notes once that entry is added?

"CSS Speech Module Level 1" is now a W3C Candidate Recommendation Draft
https://www.w3.org/TR/css-speech-1/
Trying to figure out what, if anything, supports it.


Don't commit built docs

Committing built docs creates huge, very difficult to navigate diffs. https://github.com/floodfx/liveviewjs/pull/95/files. They shouldn't need to be committed in order to be deployed.

Hey thanks @duffn!  I didn't realize they don't need to be committed in order to be deployed.  Will check it out.  and thanks for the PR!

👍🏻 It looks like there's some info on GitHub Actions/Pages/Docusaurus here: https://docusaurus.io/docs/deployment#deploying-to-github-pages

resolved with #144
Thanks again @duffn


Default logic of implementation wrong.

POST(create a resource) creates all resources with a same id(0) only.

DELETE(remove a resource) deletes nothing. And I found the reason in the implementation,
def deletePetImpl(id: Long) = Future {
val found = pets.find(.id == id).get
pets = pets.filter(.id == id) // this should be 'pets = pets.filter(_.id != id)' in my opinion
// but if we don't fix POST to generate incrementing or different ids,
// this line will simply delete all the resources,
// so it should be fixed with POST
found // and also if we change the above line to what I suggested, this 'found' will return 'None.get'
// so I changed the response to NoContent response as shown below
}

def deletePet(id: Long) = {
Action.async(request => {
deletePetImpl(id).map(answer => NoContent) // this line is changed
}.recoverWith({
case (err: Throwable) => {
onError("deletePet", err).map(errAnswer => BadRequest(errAnswer))
}
}))
}

Ok we should have a look, please do not care too much on the implementation since is just a reference.

fixed thanks

thanks :)


Istio error：{"data":"upstream connect error or disconnect/reset before headers. reset reason: connection termination}

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
{"data":"upstream connect error or disconnect/reset before headers. reset reason: connection termination}
Version
v1.21.0

Additional Information
No response

please share more info, this more like a network issue.


Inline error state styling

After testing these changes on the new repo page of .com, I think these visual updates are ready to ship with Primer to affect all other portions of the site.
These are working in concert with our autocheck js.
Error

Warning

@mdo, do we need to add these to the docs or are we good? What's the best way to do that since these are kinda js dependent?

Words could use some work I think, but how's this?

I love it!

Groovy. If this is good to merge for you then, fire away.


button size messiness

There are currently 3 sizes of buttons: normal, BUTTON_BIG and BUTTON_SMALL. #56 adds BUTTON_TINY. These should be an enum, not 4 different bitflags that are asserted to be mutually exclusive.

normal/pressed/disabled has same problem