Clear and Push not working as expected in browser

Hi. I am trying to implement navigation on web and for some reason when I use VxNavigator.of(context).clearAndPush method  it doesn't remove all the pages and when I press the back button on browser it takes me to the previous screen. I tried using this function for guarded routes
RoutesConstants.selectOrganisation : (uri, params) {
        if(mainScreenProvider.isUserAuthenticated){
          return VxRoutePage(pageName: "selectOrg",child: SelectOrgainsation());
        }
          uri.replace(path: RoutesConstants.login);
        return VxRoutePage(pageName: "login",child: LoginScreen());
      },

And it takes me to the login screen but  the url on search bar is not updating to login url. Is there a way to literally remove all pages from route stack and start fresh so that back button is disabled?

Navigation on the web is tricky in some cases. If you will provide me a working example with the issue, I can dig more and can help you out.

Hello Team any updates on this? I am facing the same issue.
In my case... Once the user is logged out then I am checking using guard if user is logged out then user should not be pushed on home page. but still user is pushed on home page and this only happens when user tries to access forward and backward in browser

Closing this as Vx doesn't support navigation anymore. Use go_router or any other package for that


Support GitLab configuration with private access token

Hi everyone!
According to the GitLab documentation you can read repositories with a private access token. See link:
https://docs.gitlab.com/ee/api/README.html#personalproject-access-tokens
The current version and prior version of Spring Cloud Config Server seem not to support this feature.
Environment
Component       Version
Spring Boot     2.4.0
Spring Cloud    2020.0.0-M5
GitLab CE       13.5.3
Java VM         openjdk 11

What I have tried so far
I have created a private access token on the GitLab server and tried to configure it inside the spring cloud config server.

When I add the ?private-token= parameter, the server won't start because JGit seems to append a path to the configured uri which leads to an invalid url.
Caused by: org.apache.http.client.CircularRedirectException: Circular redirect to 'https://gitlab.home.local/spring-cloud-config.git?private_token=<token>/info/refs&service=git-upload-pack'
I have tried to add the token as a header field in the application.properties. But the property seems to be ignored or at least not evaluated at this point.
spring.cloud.config.headers.PRIVATE-TOKEN=<token> or
spring.cloud.config.headers.Authorization=Bearer <token>

Best regards,
David

That header is for config client talking to config server. We would need something equivalent for git in general (not specific to any git hosting service).

A new parameter like spring.cloud.config.server.git.headers.*?
Or via spring.cloud.config.server.git.preferred-authentications? I am looking still for a document specifiying possible values for this parameter. A dedicated preferred authentication type like "token" or similar and a corresponding parameter to provide the token could do the trick.

This workaround seemed to work for me based on some JGit documentation:
`spring:
cloud:
config:
  server:

    git:

      uri: https://<token-name>:<token>@<repo_url]
      username: <username>

      password: <token>`

you can try like this
<EMAIL_ADDRESS>


[Event Request] table 5940 "Service Item" procedure Validate() field "Warranty Starting Date (Labor)"

Please can you add the following code/event to the above procedure...
trigger OnValidate()
var
    IsHandled: Boolean;     //NEW CODE
begin
    IsHandled := false;     //NEW CODE
    OnBeforeValidateWarrantyStartingDateLabor(Rec, xRec, IsHandled);    //NEW CODE
    if IsHandled then       //NEW CODE
        exit;               //NEW CODE

    if "Warranty Starting Date (Labor)" <> xRec."Warranty Starting Date (Labor)" then
        MessageIfServItemLinesExist(FieldCaption("Warranty Starting Date (Labor)"));

    ServMgtSetup.Get();
    ServMgtSetup.TestField("Default Warranty Duration");

The event publisher should be as follows...
[IntegrationEvent(false, false)]
local procedure OnBeforeValidateWarrantyStartingDateLabor(var ServiceItem: Record "Service Item"; var xServiceItem: Record "Service Item"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10926.


Add option for action buttons to show on banners

In the same way you can pull down on system notifications to display action buttons, it would be great if we could do the same here, rather than only allowing action buttons in Alert style

Agree with you that this is needed, and as with #14, I plan to do this at some point.

Let's track this issue with the other one. I modified that title to indicate that both action buttons and input fields are needed.


Question About the AP in test set

Hello , Thanks for your great work! And we hope to follow your work.
We retrained your code on the KITTI train split (3dop), and evaluate it on the val set, get car's AP in val set: [22.698555, 15.741446, 13.477293], and it is close to your paper's report.
Then we just use this checkpoint(trained on train split) to infer in KITTI's test set, and submit the result to KITTI benchmark, get the following result in test set:

The 3D AP is very low(Car's 3D AP: 14.93%, 10.15%, 8.22%). I wonder if it is normal considering the model is trained on train split(not in trainval).
And we want to reproduce your paper's report on KITTI test set, close to car‘s AP（22.26%, 15.02%, 13.12% as your released checkpoint or 20.11%, 14.20%, 11.77% in your original paper）. In addition to setting to the trainval set, what else do we need to do?
And if I set to trainval set, how do I choose the best checkpoint in case that the val set is included in the trainval set?
Thank you very much for your reply！

Thanks for your attention. Please mention that when evaluating on the test set, you should train on the trainval set (train set + eval set) rather than on train set. This setting is provided by previous works. So directly using checkpoint from train set is not right.
When you train on trainval set, just use the final one. We have tested 3 times on the test set. The best one is the released ckp. Do not need other ways to select ckp.


Update covid19za_provincial_cumulative_timeline_deaths.csv

Update file with data from NICD twitter graphics to fix issue https://github.com/dsfsi/covid19za/issues/184

Thanks!!! @dmackie


[app-config] migrate to the new core-paging method

Packages impacted by this PR
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/13298
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

Would recommend running live tests before merging for such important tasks


[BugFix] Fix Table_type wrong from show full tables where #18195

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #18195
Problem Summary(Required) ：

Fix Table_type wrong from show full tables where
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergify backport branch-3.0


small chain gaps cause unliftable alignments

Hi @milkschen  :)
I am trying trying to lift a set of simulated reads derived from CHM13 from CHM13->hg38, but I am getting a curiously high amount un-liftable alignments. I don't specify any unliftable/to-defer regions, and all the source alignments are MAPQ=99.
GitHub isn't letting me upload a small example bam but here are the commands I used along with stdout.
$ leviosam2 lift -C chm13v2-grch38.clft -a data/truth_bams/example.bam -t 8 -p out.lift -O bam -S mapq:30 -m -f data/chm13v2.0.fa
[I::add_split_rule] Adding rule `mapq:30`
[I::lift_run] Loading levioSAM index...done
[I::load_fasta] Loading FASTA...done
[I::WriteDeferred::print_info] Alignments with any of the below features are deferred:
 - unlifted
 - MAPQ (pre-liftover) < 30

[I::main] Finished in 10.7 CPU seconds, or 15.3877 wall clock seconds
$ leviosam2 collate -a out.lift-committed.bam -b out.lift-deferred.bam -p out.lift-paired
Inputs:
 - BAM: out.lift-committed.bam
 - BAM (deferred): out.lift-deferred.bam

Outputs:
 - BAM (committed): out.lift-paired-committed.bam
 - BAM (deferred): out.lift-paired-deferred.bam
 - FASTQ1: out.lift-paired-deferred-R1.fq.gz
 - FASTQ2: out.lift-paired-deferred-R2.fq.gz

Num. unpaired reads1: 6
Num. unpaired reads2: 7
Num. merged unpaired: 13
[I::collate_core] Extract 13 reads from BAM

Finished in 0 CPU seconds, or 0.021676 wall clock seconds

$ samtools view -c out.lift-committed.bam
65
$ samtools view -c out.lift-unliftable.bam
15
$ samtools view -c out.lift-deferred.bam
15

(the unliftable and deferred bams are equal here)
Here's an example of the results

Here, I color all the "unliftable" reads and their mates. Again, all these reads have extremely high mapq. That first BED track in the bottom panel shows lifted regions from CHM13->GRCh38. Notice that at least one mate from each colored pair overlaps that 4bp gap in the chain file.
Is a gap in the chain file supposed to cause a read to be unliftable/deferred, even if most of the read occurs outside of the gap? Is there an option in leviosam2 that lets me work around this?
Thanks,
Taher

Yes! The option is -G. I use a default value of 0 for short reads and you can set it higher. For a non-zero -G, sometimes it's useful to also activate the -x <config> option to perform local realignment.

I see! setting -G>0 does appear to help! I'm curious as to why G=0 is default for short reads? Small indels are not rare in short reads, and it seems like a lot of work can be saved by committing the ones that overlap smaller chain gaps (without -x).

It's mostly an efficiency vs. accuracy consideration. Lifting over short-read alignments overlapping gaps (even if small) can sometimes confuse downstream tools such as variant callers, so I turn it off as the default parameter. A future solution could be triggering re-alignment for alignments overlapped with a chain gap.


Implementing zip lookaside for interpreter

Before submitting

[X] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)

[X] Did you read the contributor guideline, Pull Request section?

[ ] Did you make sure to update the docs?

[X] Did you write any new necessary tests?

What does this PR do?
The PR implements zip lookaside function for interpreter and the related tests.
Fixes #284  (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes. This is first time I coded something that has been implemented in Python interpreter. Definitely piqued my interest.

Hi, after implementing the strict flag, we are getting an interpreter-side issue while running the tests. We are getting an 'InterpreterError'/'AssertionError' with regards to our zip implementation.
Here is the error stack:
message.txt
Notably, we are getting the error at the interpreter call in our zip function:

With this line triggering the AsseritionError:

Do you guys have any thoughts on how we could address this error?

We completed the changes that were requested and the test cases ran to success.


StartMenu Directory Name

I use electron-builder for my builds and wan't that the StartMenu Folder is named like the App itself but it always uses the Author field. Is there a way to change it?

It is how Squirrel.Windows works. It is not this module task. You can try to use NSIS target.

As a dirty solution you can set author name to app name, see electron-builder options.


BITMAKER-1930: Add api parameter descriptions

Description
We must ensure that every serializer field is well specified and follows the same format.
Issue

_https://tasks.bitmaker.dev/issues/1930_.

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] My code follows the style guidelines of this project.
[x] I have made corresponding changes to the documentation.
[x] New and existing tests pass locally with my changes.
[x] If this change is a core feature, I have added thorough tests.
[x] If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
[x] I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@mgonnav to merge this PR we need to merge #51 first.


Replace Container ENV var EMS_IDS->_ID

Workers having a comma separated list of EMS IDs has been replaced with moving child-manager refresh logic into the parent-manager refresher.
I noticed this while investigating the OpentofuWorker, it is also odd that deployment-per-worker also assumes that it is an EMS worker which isn't necessarily the case.
I think a better approach would be to move the environment variable logic out of how the workers are managed by kubernetes, and unify it with how systemd handles environment variables per-worker with the unit_environment_variables method (which already handles EMS_ID).
Co-depends:

https://github.com/ManageIQ/manageiq-pods/pull/1170

Ha yeah I keep finding more, I think this is the last of them though (famous last words)


function for Deepgram's TopicDetection added

What does this PR do?
This PR adds the "deepgramTopicDetection" java function to openruntime java library as per the requirement of the issue
Related PRs and Issues
https://github.com/appwrite/appwrite/issues/4460.
Screenshot:

✅ Task Summary

[x]   Ask to be assigned to the issue.
[x]   Implement function deepgramTopicDetection() in Java/ folder.
[x]   Manually execute the newly implemented function to ensure it works.
[x]   Submit a pull request in open-runtimes/examples and include screenshots of successful execution.

Thanks @stnguyen90


stopwords for Tamil

 Issue by vjyanand
Tue May 21 01:44:06 2019
Originally opened as https://github.com/codelucas/newspaper/pull/701

vjyanand included the following code: https://github.com/codelucas/newspaper/pull/701/commits

added 0.9.3


Revert "add GOMEMLIMIT to vttablet configuration"

This introduced weird behavior in the benchmarks, reverting for now until i find a proper long term solution:

This works well for >= v19 let's keep it. We should however revert this only for v18 as this release needs more GOMEMLIMIT


How to query a second one of same class type?

So I have two LoraLoaders in my metadata, example below.
When doing a query LoraLoader.lora_name I only get the first one.
Would be nice if I could do something like LoraLoader[1].lora_name to get the second one, I tried it but that doesn't work.
Is there a way to do this?
   "11":{
      "inputs":{
         "lora_name":"Anime_detail_eye.safetensors",
         "strength_model":1,
         "strength_clip":1,
         "model":[
            "12",
            0
         ],
         "clip":[
            "12",
            1
         ]
      },
      "class_type":"LoraLoader"
   },
   "72":{
      "inputs":{
         "lora_name":"arataki-itto.safetensors",
         "strength_model":1.0,
         "strength_clip":1.0,
         "model":[
            "12",
            0
         ],
         "clip":[
            "12",
            1
         ]
      },
      "class_type":"LoraLoader"
   },

Anyway really cool nodes, thanks for that. Been trying to find something like this for some time now.

You can use two ways right now.
Case 1: Use Node ID
Node ID not changed before node removed.
You can use this way when loaded images are generated by same workflow.
11.lora_name
72.lora_name
Case 2: Use Node Title after setting title of node
ckpt1.lora_name
ckpt2.lora_name
I will update it to work like this "LoraLoader[1].lora_name"
Thanks for your interest :)
2024년 9월 15일 (일) 오전 5:46, Mind Glowing @.***>님이 작성:

So I have two LoraLoaders in my metadata, example below.
When doing a query LoraLoader.lora_name I only get the first one.
Would be nice if I could do something like LoraLoader[1].lora_name to get
the second one, I tried it but that doesn't work.
Is there a way to do this?
"11":{
"inputs":{
"lora_name":"Anime_detail_eye.safetensors",
"strength_model":1,
"strength_clip":1,
"model":[
"12",
0
],
"clip":[
"12",
1
]
},
"class_type":"LoraLoader"
},
"72":{
"inputs":{
"lora_name":"arataki-itto.safetensors",
"strength_model":1.0,
"strength_clip":1.0,
"model":[
"12",
0
],
"clip":[
"12",
1
]
},
"class_type":"LoraLoader"
},
Anyway really cool nodes, thanks for that. Been trying to find something
like this for some time now.
—
Reply to this email directly, view it on GitHub
https://github.com/shinich39/comfyui-parse-image/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BB6ZYYWCCFY5GTQSAGFNN4LZWSOCDAVCNFSM6AAAAABOHEYCNCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDMNRQGE2TKMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Now updated.

Whoa that was fast! Thank you! I do have another question, is there any batch image loaders out there that work with this? I haven't found any, I think those I've tried don't pass on the metadata.

This node only supports 5 loaders now.
Try this node.
Start generation after check auto queue and set mode to increment.
https://github.com/shinich39/comfyui-put-image
2024년 9월 15일 (일) 오전 7:41, Mind Glowing @.***>님이 작성:

Whoa that was fast! Thank you! I do have another question, is there any
batch image loaders out there that work with this? I haven't found any, I
think those I've tried don't pass on the metadata.
—
Reply to this email directly, view it on GitHub
https://github.com/shinich39/comfyui-parse-image/issues/1#issuecomment-2351202000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BB6ZYYVH3BX24BIPD7O2QJLZWS3STAVCNFSM6AAAAABOHEYCNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGIYDEMBQGA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

It's working thanks!
I made 3 workflows:

1 Simple workflow to generate images using a lora stack
2 workflows (single load and batch load) that extract the metadata of an image generated with the simple workflow to then upscale it using the same prompt, seed and use the loras from the lora stack in the simple workflow

Since Flux takes some time to upscale the images, I found it better to queue up a bunch of images with the simple workflow and then choose those I want to upscale, so I don't lose unnecessary time upscaling images that aren't good
If you're interested:
Simple Flux Workflow + Single + Batch Upscale From Image Automatic.zip
Thanks again for your hard work and advice!

It was used in follow intention of development.
glad it worked!


Fixed problem where a substring match during FSeamMockData.hpp would …

…cause invalid output.
If the generator is run twice, once where a class has a name that is a substring of another previously generated class, the generator fails to produce valid C++ syntax. This fixes that

Would it be possible to write a non-regression test in order to validate the change fix this error generation issue?

This showed up for me just building the existing tests. This is the cause of the spare "lass" string in that was in the issues. That said, I would be willing to write a test specifically to make sure this doesn't happen.


Upgrade gibson to use new yagnats with apcera wrapper

Made some gibson updates to be compatible with the latest and greatest yagnats. This is so we can use the new Apcera NATS client. Gibson is currently using deprecated yagnats functionality.
Removed extraneous test as it's no longer possible to get to the callback using apcera/nats Msg like it was with a yagnats Message
CC @cholick

@shalako @flavorjones  Doesn't seem like a tracker issue got created to track this.

@dieucao Will investigate why gitbot didn't pick it up.

@flavorjones I just submitted a PR to add this repo to the Routing team's tracker
https://github.com/pivotal-cf/cfgitbot-config/pull/17

Created story manually: https://www.pivotaltracker.com/story/show/103959042

@kkamperschroer Have you manually tested your changes to gibson?  We were unsuccessful in registering a route using the updated NATS client and your most recent changes.
Please take a look at the tracker story for our test setup:
https://www.pivotaltracker.com/n/projects/1358110/stories/104007100

I recreated the same issue you are seeing locally. It appears the test program does not give the apcera/nats message bus time to flush before exiting. We didn't see this issue in our integrations with our login server because it stays alive long enough for the message to flush.
If you properly close the connection using natsConn.Close() before terminating the program, it will wait for the buffers to be entirely flushed prior to exiting, and you should see everything then get properly registered with the router.

Thanks! We double checked and that was the problem.  Your changes have now been merged in.

Great, thanks! :smiley:


CarlaUE4.exe can not apply two pygame windows

Hello, I use Carla 0.9.10, I run CarlaUE4.exe as a server in local pc, and I run the manual_control.py, a pygame window(1280*720) opens and I can control the vehicle, but then I run another manual_control.py at the same time,  an error happend, CarlaUE4.exe has crashed and will close, the content is :

"Assertion failed: InRect.Height() <= TextureRHI->GetSizeXYZ().Y >> InFlags.GetMip()
[File:D:/Build/++UE4/Sync/Engine/Source/Runtime/Windows/D3D11RHI/Private/D3D11RenderTarget.cpp][line:506]
Provided rect height (1440), must be smaller or equal to the texture size requested Mip (720)".

Whatever I run the two manual_control.py in local pc or another pc through IP+port, the CarlaUE4.exe crashed everytime.
Then, I opened CarlaUE4.uproject in UE4Editor, and play(not start) the project, I found I could run two manual_control.py, and can apply two pygame windows at the same time.
So, I want to ask that, if there are some ways to solve this problem. Thank you very much!!

Could you please help me? Thank you very much! @germanros1987

Hi, can I ask how you were able to control Carla? Where do I have to type the commands? I can not find any info about this...
Thanks for any help.

@corkyw10 could you follow up on this?

@corkyw10 could you follow up on this?

@CHDCheng Are you still experiencing this issue? I have tested in 0.9.10 and 0.9.11 and I'm not experiencing the same problem, both manual_control.py scripts run fine. Are you running the scripts with any previous changes in configurations or just out of the box?
@BAROBA-3d I think you know CARLA more now, but I will share the getting started with CARLA docs here for anyone that comes across this in the future.

@CHDCheng Are you still experiencing this issue? I have tested in 0.9.10 and 0.9.11 and I'm not experiencing the same problem, both manual_control.py scripts run fine. Are you running the scripts with any previous changes in configurations or just out of the box?
@BAROBA-3d I think you know CARLA more now, but I will share the getting started with CARLA docs here for anyone that comes across this in the future.


Broken Link in Lesson 6

Broken Link in Lesson 6
The link under this bullet point
StateMod .gitignore file
is broken. The page returns a "404" error.

The link works for me but it was pointing to .gitattributes instead of .gitignore.  I fixed.  Will have Lisa look at it after I deploy the update.

Actually the issue is that Lisa does not have access to the StateMod code repository.  I added her as a read-only collaborator so the link works.  I reworked the text to indicate that the link may not work.  Will have to circle around and change the text later when the repository goes public.

Looks like it is working now. Thanks Steve!


Refactor sendUserData and addPersonToEvent together into one function.

Currently in participants.py we have one function to add event participants when through kiosk (sendUserData) and another for adding event participants all other ways (addPersonToEvent). Combine them into one function.

 Refactor sendUserData and addPersonToEvent together into one function. #746

Refractored the two functions into one.
We will need to test it to see if it works though


fix: Use arn partition variable in aws ebs iam policy

Pull request title
fix: Use arn partition variable in aws ebs iam policy
Description
This is a follow up after #334 merged. The aws policy was then changed in #346 but did not use the arn partition variable. This PR just updates the iam policy to use the arn partition variable
Checklist

[x] CI tests are passing
[x] README.md has been updated after any changes to variables and outputs. See https://github.com/particuleio/terraform-kubernetes-addons/#doc-generation

@travertischio My bad I updated the policy to sync with upstream. I'll be more careful next time


Return StatusOr for Table::ReadModifyWriteRow()

Fixes #1968

This change is

Removed the #if and #endif lines.


feat: add vmagent role

Added vmagent installation role. Installation is made by using binary from github releases.

@bykvaadm I've updated notes we discussed:

remove unneeded flags for vmagent
unify naming
parameters for proxy
atomic operation for binary installation
option for download to local host for binary

@bykvaadm seems like this one wasn't merged eventually after branch updates :)

@bykvaadm seems like this one wasn't merged eventually after branch updates :)


Avoid unregistering unknown containers.

For debug containers, metrics are not emitted and hence the
container is not registered with the ContainerAssigner
instance in the prepare() call on the Isolator interface.
Hence we should not try to unregister the container in cleanup().
See https://github.com/apache/mesos/blob/11de04c1bbf65d0a90576642f8ea9574e05a317a/include/mesos/slave/isolator.hpp#L115-L124

:tada: Thanks @rukletsov


--private, --private-api, VPC peering and VPN

Private networking has landed: https://github.com/convox/rack/pull/350
Docs

[x] Document Private Network Config

[ ] VPC peering

[ ] Document Private API

[ ] VPN access (https://docs.openvpn.net/how-to-tutorialsguides/virtual-platforms/amazon-ec2-appliance-ami-quick-start-guide/)
[ ] Grid access
[ ] SSH access

While it mentions the additional cost of the NAT gateways as an indication it's at least $100 a month

@nzoschke --private is documented here. Does that cover it? What is --private-api?


Variable explorer

This is a great package and I really love it. I have been trying to find something that works as well as the Spyder IDE but on VS Code, and this seems to do the job.
I was wondering, how hard would it be to include a variables explorer like in Spyder? The VS Code 'Interactive mode' has one of those, but it really does not work very well
Another feature that would be great would be for the extension to have a 'plots' pane where all the plots go to

Hi, thank you for the nice feedback 😀.

I was wondering, how hard would it be to include a variables explorer like in Spyder?

Currently the ipython terminal is text only.  Meaning the interface between vscode and ipython terminal can only be text like that of a standard REPL.  To implement a variable explorer, the interface will have be programmatically.  I'm exploring an option for that in #29.  It is a long term option so, for now, have you try using the magic command %whos?

Another feature that would be great would be for the extension to have a 'plots' pane where all the plots go to

Here is my current note on this (https://github.com/hoangKnLai/vscode-ipython/issues/29#issuecomment-1705686992).  The solution, if there is one, will be a long term thing.  Temporarily, have you try saving the figure as png and then open the saved figure with VSCode?  This removes the interactive figure option but every time you update the png, the panel VSCode open the png in do update the rendering automatically.

I had not seen #29! Honestly, most of what you comment there is what I want the most. If you ever get around to also implement a variables explorer, that would be great :)


Table (view) is not update when the rows is changed

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
I've a table which I update using a method like _editValue
protected _editValue(index: number, value: Object){
\\this.data.splice(index,1,value); same like this below
this.data[index] = value;
}
where
<ngx-datatable #datatable
class='material'
[rows]="data"
[columnMode]="'force'"
[headerHeight]="40"
[footerHeight]="50"
[rowHeight]="40"
[selectionType]="'single'"
>
....
But the view (table) is not update since that I resize the window. Although the element is pushing in the array.
And But for delete and add are works fine. I've using this method
this.data.splice(index,0,value);  -> for remove.
this.data.push(value); -> for add.
Expected behavior
The view (table) and the array is updated with a changed element.
What is the motivation / use case for changing the behavior?
I need changed a table in real time for user interaction.
Table version: 6.1.2
Angular version: 2.4.7
Browser: all
Language: all

`
let myArr = [1, 2, 3];
//You have to do this when array is updated
let myNewArr = [4, 5, 6]
myArray = [...myNewArray]
//If you update a single row then do
myArray = [...myArray]
`

@ScottSpittle Still not working,
While inline editing the table rows are not getting updated.

@t-pankajkumar Ensure you are following this tutorial correctly https://github.com/swimlane/ngx-datatable/blob/master/demo/basic/inline.component.ts
Without code snippets I won't be able to assist further


Incorrect watchers count in store stats

The watchers value in the v2/stats/store endpoint is reported incorrectly, presumably because the  store's watcherHub over-decrements its count. Setting a watch with wait=true correctly increases the watcher count, but after the watch resolves, the count decreases by 2, not 1. In particular, because the int64 count is cast to uint64 when reporting the stats, the -1 appears as a confusing<PHONE_NUMBER>3709551615 = 2^64 - 1 in the JSON output.
Reproduction example:
$ etcd --version
etcd version 2.0.0

$ etcd 2> /dev/null &
[1] 42576

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":12,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":0}

$ curl -L http://localhost:4001/v2/keys/message -X PUT -d value="hello world"
{"action":"set","node":{"key":"/message","value":"hello world","modifiedIndex":14,"createdIndex":14},"prevNode":{"key":"/message","value":"it's a mad, mad world","modifiedIndex":9,"createdIndex":9}}

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":13,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":0}

$ curl -L http://localhost:4001/v2/keys/message?wait=true &
[2] 43050

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":13,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":1}

$ curl -L http://localhost:4001/v2/keys/message -X PUT -d value="goodbye world"
{"action":"set","node":{"key":"/message","value":"goodbye world","modifiedIndex":15,"createdIndex":15},"prevNode":{"key":"/message","value":"hello world","modifiedIndex":14,"createdIndex":14}}
{"action":"set","node":{"key":"/message","value":"goodbye world","modifiedIndex":15,"createdIndex":15},"prevNode":{"key":"/message","value":"hello world","modifiedIndex":14,"createdIndex":14}}
[2]+  Done                    curl http://localhost:4001/v2/keys/message?wait=true

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":14,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":18446744073709551615}

$ curl -L http://localhost:4001/v2/keys/message -X PUT -d value="goodbye world"

$ curl -L http://localhost:4001/v2/keys/message?wait=true &
[2] 43642

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":14,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":0}

$ curl -L http://localhost:4001/v2/keys/message -X PUT -d value="sup, world"
{"action":"set","node":{"key":"/message","value":"sup, world","modifiedIndex":16,"createdIndex":16},"prevNode":{"key":"/message","value":"goodbye world","modifiedIndex":15,"createdIndex":15}}
{"action":"set","node":{"key":"/message","value":"sup, world","modifiedIndex":16,"createdIndex":16},"prevNode":{"key":"/message","value":"goodbye world","modifiedIndex":15,"createdIndex":15}}
[2]+  Done                    curl http://localhost:4001/v2/keys/message?wait=true

$ curl -L http://localhost:4001/v2/stats/store
{"getsSuccess":0,"getsFail":2,"setsSuccess":15,"setsFail":0,"deleteSuccess":0,"deleteFail":0,"updateSuccess":0,"updateFail":0,"createSuccess":1,"createFail":0,"compareAndSwapSuccess":0,"compareAndSwapFail":0,"compareAndDeleteSuccess":0,"compareAndDeleteFail":0,"expireCount":0,"watchers":18446744073709551614}

When will this be issue be rolled into 2.X release

Fixed via https://github.com/coreos/etcd/pull/2622


Add new locale en-gb

Provide support for the en-gb locale in the angular-mydatepicker.

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   91.67%   91.67%
=======================================
  Files          21       21
  Lines        1298     1298
  Branches      280      280
=======================================
  Hits         1190     1190
  Misses        108      108

Impacted Files
Coverage Δ

...ib/services/angular-mydatepicker.locale.service.ts
87.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc3eba...5da5690. Read the comment docs.

Your locale added to version 0.9.0.


Right Click BUG

When you click right click it opens new tab. There is NO option to disable it. I had to disable the plugin bec of that.. Can you fix that plz? Thx..

Right click where? Can you be more specific or provide screenshots?

Experiencing the same issue, whenever the plugin is enabled a right click within a file will open a new tab.

Hello @jon-dez and @mteam88 ,
Thank you for your responses.
When I right-click anywhere on the screen, it opens a new tab. It's not possible to show this with a screenshot. I think you can test this on your own Obsidian while the plugin is active.
Thank you for the great plugin, and I wish you success in developing it further. But unfortunately, I have to disable the plugin until the issue is fixed.

This issue doesn't exist for me, so unfortunately I cannot diagnose the bug. Can you test this plugin in a new vault with no other community plugins installed? Also, which version do you have installed?

Hello,
I hope you are doing well. It seems that the issue has somehow been resolved for now. So, I’m marking the topic as resolved. If the issue reoccurs, I will write here again. Thank you for your attention.


Deduce category from expense title

Automating the category selection would allow users to input and categorize their expenses faster and more reliably. Imagine a user typing their expense title, and based on their input, a category gets selected for them.
Two approaches of implementing this could be:

AI: Use the OpenAI integration added in #69. Prompt the latest stable turbo model for one of the available categories.
Keywords: For each category, maintain a set of keywords. If a keyword is found, the mapped category will be selected.

Implementing the AI option would allow categorization of many more titles than the keyword approach. It would also increase the running cost of spliit. Starting out with an implementation of keyword based mapping will be more economical. However, usability may be limited considering the range of possible titles.
I would be happy to give either of these approaches a try, with AI being my preference. Are you interested in such a feature? If yes, which approach are you leaning towards?

Cool idea! I’m okay with testing with OpenAI.
The cost should be pretty low for each expense, but might grow fast if we call OpenAI automatically (~50 to 100 expenses are created each day currently, and it’s growing).
What do you think of adding a subtle magic wand icon at the right of the category, and call OpenAI only when clicked? At least as a first step.

I would like to see this as an opt-in feature, at least for self hosters (like the current OpenAI integration for pics)
To make fewer calls to OpenAI both the solutions could be used, ie (pseudo code):
if (any keywords in title) {
    category = hit
} else {
    category = get_category_from_openai()
}

In the long run:
With growing data for spliit.app, I think this is something that you could have a "buddy service" for, where you can have a model trained on the database data (you have everyones expense title and what category they gave it, while excluding all "General" categories)

Agree that the feature should be opt-in.
I suggest we start with a plain call to OpenAI. An optimization for later could be to persist the results to avoid doing the same call too many times. As you suggest @justcallmelarry, on the long term it could be interesting to train our own model.

Sounds good, I will give the AI option a go then!

~What do you think of adding a subtle magic wand icon at the right of the category, and call OpenAI only when clicked? At least as a first step.~ Edit: let’s do that only later if the cost is too high.

Waiting until the expense title input loses focus may be a good balance between number of API calls and necessary user interactions.

With growing data for spliit.app, I think this is something that you could have a "buddy service" for, where you can have a model trained on the database data

We could add support for custom endpoints compatible with the OpenAI API in a future iteration. Similar to #71, it would be beneficial for self-hosting and to avoid vendor lock-in, be it for a different AI vendor or possibly a future custom model.

Waiting until the expense title input loses focus may be a good initial balance between number of API calls and necessary user interactions.

👍

I created a first attempt at #80. Looking forward to your feedback!

Resolved by #80. If we need to improve the category deduction (using keywords for instance), we’ll create a new issue.


CountOnNullRector doesn't resolve return type of doctrine repository method

Wasn't sure if this should go here or https://github.com/rectorphp/rector-doctrine, but I was unable to reproduce with only doctrine, so opted for this repo.
Reproducible code is a bit much for this, but some example code would be like:
<?php

declare(strict_types=1);

namespace App\Service;

use App\Entity\Card;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

#[AsCommand(name: 'test')]
class TestCommand extends Command
{
    public function __construct(
        private readonly EntityManagerInterface $em,
    ) {
        parent::__construct();
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        count($this
            ->em
            ->getRepository(Card::class)
            ->getFooCards()
        );

        return 0;
    }
}

where the CardRepository is like:
<?php

declare(strict_types=1);

namespace App\Entity;

use Doctrine\ORM\EntityRepository;

class CardRepository extends EntityRepository
{
    public function getFooCards(): array
    {
        return $this
            ->findBy([
                'rarity' => 'foo'
            ]);
    }
}

From here, assuming you setup a symfony project, some database that has a rarity column, and set your PHP/XML container files, running rector updates the command to be like:
is_countable($this
    ->em
    ->getRepository(Card::class)
    ->getFooCards()) ? count($this
    ->em
    ->getRepository(Card::class)
    ->getFooCards()
) : 0;

Given the container is provided, I would have expected it to be able to resolve the return type of the proper repository method.
It does work correctly if you manually assign the repo to a var and type it accordingly. E.g.
/** @var CardRepository $repo */
$repo = $this->em->getRepository(Card::class);

count($repo->getFooCards());

@Blacksmoke16 Be sure to use doctrine extension from PHPStan, as magic types are not resolved by default:
$this
    ->em
    ->getRepository(Card::class)

@TomasVotruba Ah thanks, that did the trick. Should that be added as a suggested dependency to make it a bit more clear?

@TomasVotruba Right, it would just be a suggestion, not a hard dependency.
But a follow up question: are the other PHPStan packages also somewhat required if you're using their related packages. I.e. if you're using symfony should you setup phpstan-symfony, or if you're using mockery setup phpstan-mockery, etc? Or is doctrine the only one that really enables better rectoring?

Rector is using the PHPStan, that is using extension you've installed.
You can also configure different phpstan.neon just for Rector and set it $rectorConfig->phpstanConfig(...):
https://github.com/rectorphp/rector#configuration


很多歌提示仅在酷我音乐手机版播放

+1

+1

+1

+1

+1

+1

+1

感谢反馈，在v2.28.0中修复了该问题，详情请见 https://github.com/listen1/listen1_chrome_extension/pull/1068


Documentation is wrong

presentation "My Presentation" do
  slide "A slide with video" do
    media "video.mp4", type: video
  end

  slide "A slide with video" do
    media "audio.mp3", type: audio
  end
end

Should be type: :audio

Fixed.


add lib versioning

Checklist
GitHub

[ ] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[ ] I've applied the relevant labels to this PR
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Linked issues

https://github.com/MotionCorrect/ivadomed/pull/1
the wrong commit got merged today (sorry =/), this was the right one

Pull Request Test Coverage Report for Build 687936373

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.631%

Totals

Change from base Build 686790450:
0.0%

Covered Lines:
5456

Relevant Lines:
7214

💛  - Coveralls


XML Code folding does not work properly

For some XML files code folding does not work properly, it can fold only few nodes.

Here is the example file:
Test.txt

Fixed.

Sorry to bring this one again, but I found another scenario where XML Code folding does not work properly.

Here is the example file:
test-xml.txt

Fixed.


Improve behavior of usePreventScroll on iOS

Currently in many of the RAC examples with overlays on iOS, the entry/exit animations are weird/glitchy. This is due to usePreventScroll on iOS messing up the overlay positioning due to the hacks to undo scrolling with margin. However this is only really necessary to deal with the software keyboard coming up and trying to center an input in the viewport. This PR therefore only applies those changes when the keyboard is about to come up, and not while entry animations are happening, making the UX less janky. Need to test in a few places to ensure it still works well.

I think that's related to https://github.com/adobe/react-spectrum/pull/3780 That PR seemed to break preventing page scroll in general, including vertical when you start from inside the horizontally scrollable element. The story that was added just doesn't have much page content. Not sure how we can allow horizontal scrolling while preventing page scrolling though. I was hoping overscroll-behavior might work but seems like not.

One tradeoff could be to change it to
let bottom = scrollable.scrollHeight - scrollable.clientHeight;
let right = scrollable.scrollWidth - scrollable.clientWidth;

if (bottom === 0 && right > 0) {
  return;
}

That way we only allow it when the target is actually horizontally scrollable. But if it was you wouldn't get any scroll locking in either direction.

Also related: #5144

Found another approach. We can use the relatively new overscroll-behavior CSS property to prevent scroll chaining of inner scrollable elements within an overlay from causing page scrolling. This mostly replaces our manual preventDefault in the touchmove event, except for one bug that prevents it from working when the content doesn't actually overflow. In the horizontal scrolling only case, the best solution is to add touch-action: pan-x to the scrollable element to only allow scrolling in the x direction. We can't add that automatically because it must be added before the touchstart event fires.
The changes in this PR also allow us to bring back #5109 and stop preventing scroll immediately when isOpen is set to false without waiting for animations. We previously reverted in #5144 due to flickering on iOS, which now won't happen because we don't apply the page margin styles unless an input was focused. That case is far less likely. cc. @cedeber.

On iPhone? I haven't been able to reproduce...

On iPhone? I haven't been able to reproduce...

yep, on iPhone, iOS 16.7.2. Still haven't found solid reproduction steps

View the documentation

yep, on iPhone, iOS 16.7.2. Still haven't found solid reproduction steps

To verify I understand the issue I found that if you select a RAC DatePicker segment (opens virtual keyboard) then click on the open popover (closes virtual keyboard) that causes this every time. iOS 16.6.1
With RAC Notification popover example I only see if render then shift up a few pixels.
With the current changes the Notification popover doesn't shift a few pixels. The RAC DatePicker example behaves the same, tries to render above, then renders below. The RAC Datepicker is fixed, no partial render, just a single full render.

should we put that pan-x in an example somewhere in docs?

maybe but it isn't a common scenario, and the example works without it. it's just an enhancement.

I tried adding 5paragraphs to the content, this worked well on main.

well that's not quite fair because on main the whole page scrolls as well 😉

Nice, thanks.


Is there any special instructions to install it in windows?

I have been trying to install it on windows 10 because it looks very cool for extra learning material, but
I have not been able to install it so far. I tried to install vs build tools as the requirements said but without luck. Any ideas or suggestions?

Do you have python installed?

Nevermind. Using anaconda, with a fresh clean install solved the problem.

yeah, anaconda + pycharm works fine.

I'm having the same issue - unable to install it on Windows 10, how did you manage to fix it?

I have been trying to install it on windows 10 because it looks very cool for extra learning material, but
I have not been able to install it so far. I tried to install vs build tools as the requirements said but without luck. Any ideas or suggestions?


Implements pct_change() for DataFrame

Resolves #878
(https://pandas.pydata.org/pandas-docs/version/0.23.4/generated/pandas.DataFrame.pct_change.html)
>>> df = ks.DataFrame({
...     'FR': [4.0405, 4.0963, 4.3149],
...     'GR': [1.7246, 1.7482, 1.8519],
...     'IT': [804.74, 810.01, 860.13]},
...     index=['1980-01-01', '1980-02-01', '1980-03-01'])
>>> df
                FR      GR      IT
1980-01-01  4.0405  1.7246  804.74
1980-02-01  4.0963  1.7482  810.01
1980-03-01  4.3149  1.8519  860.13

>>> df.pct_change()
                  FR        GR        IT
1980-01-01       NaN       NaN       NaN
1980-02-01  0.013810  0.013684  0.006549
1980-03-01  0.053365  0.059318  0.061876

You can set periods to shift for forming percent change
>>> df.pct_change(2)
                  FR        GR       IT
1980-01-01       NaN       NaN      NaN
1980-02-01       NaN       NaN      NaN
1980-03-01  0.067912  0.073814  0.06883

Codecov Report

Merging #1051 into master will decrease coverage by 2.69%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1051     +/-   ##
=========================================
- Coverage   95.13%   92.43%   -2.7%
=========================================
  Files          34       34
  Lines        6765     6772      +7
=========================================
- Hits         6436     6260    -176
- Misses        329      512    +183

Impacted Files
Coverage Δ

databricks/koalas/missing/frame.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/frame.py
93.22% <100%> (-3.35%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.54% <0%> (-72.73%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.72% <0%> (-8.52%)
:arrow_down:

databricks/conftest.py
92% <0%> (-6%)
:arrow_down:

databricks/koalas/utils.py
95.12% <0%> (-3.05%)
:arrow_down:

databricks/koalas/groupby.py
89.34% <0%> (-2.05%)
:arrow_down:

databricks/koalas/namespace.py
85.8% <0%> (-1.55%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169e38e...38a28bd. Read the comment docs.

@itholic can you resolve conflicts?

@HyukjinKwon resolved, Thanks 😄


ArchiveBox stops pulling links after initial import on first startup

I seem to have a grave misunderstanding of how the program works, or ran into an issue.
When I start the docker instance I can go to the web interface and input some links for it to pull. It does this fine. However, once it's done with that import I can't do anymore. I go to add and paste in a link, it takes it, and then nothing. It shows the titles of the links I pasted as "Pending" but never gets past that. Logs show no activity. It's like it's dead in the water. Only way to fix it is to select the recently entered links and click on "Pull"

Hmm can you check the output in data/logs/ and see if there are any errors after the first links finish or when you submit the second links?

Not quite sure what changed but it appears to be working now. I haven't done anything other than not touch it for a day or so.


docker command has issues with accented characters in pathnames

So my Windows name is the same as my first name - Ciarán - with the accented a "á". When installing boot2docker on my system, I got
Writing C:\Users\Ciarán\.boot2docker\certs\boot2docker-vm\ca.pem
Writing C:\Users\Ciarán\.boot2docker\certs\boot2docker-vm\cert.pem
Writing C:\Users\Ciarán\.boot2docker\certs\boot2docker-vm\key.pem

out of Powershell So far so good, but when I run docker run hello world I get
FATA[0000] Couldn't read ca cert C:\Users\Ciar├ín\.boot2docker\certs\boot2docker-vm\ca.pem: open C:\Users\Ciar├ín\.boot2docker\certs\boot2docker-vm\ca.pem: The system cannot find the path specified.

With the á mangled. Can you give me feedback as to how to resolve this issue

I have the same problem. I have Turkish characters in my user folder name (such as "ğ") and can't start boot2docker on Windows 8.

I mangaed to find a workaround by using Git Bash on windows instead Powershell:
$ boot2docker up
$ eval $(boot2docker shellinit)

Apparently PS translateds parameters to ascii before piping them into .exe
http://blogs.msdn.com/b/powershell/archive/2006/12/11/outputencoding-to-the-rescue.aspx

@ahmetalpbalkan ^^ is that a known issue on your side?

Hmm could be something wrong at quite many points (b2d cli, virtualbox, msys).
@dogpawhat Can you  please run "boot2docker shellinit" in Git Bash and screenshot the output? Also can you please "boot2docker ssh" and see what the folder name appears like in /Users (also screenshot please).

Here this should have everything you need

This is what my users folder looks like at the moment

Same folder in both Ciarán and Ciar?n

Yeah apparently  a shared folders issue. I'm not familiar with the topic, let's start another issue at boot2docker/boot2docker repo.
This does not look like a b2d cli problem.

I deleted Ciar?n entirely, ran boot2docker delete and boot2docker init again, Ciar?n popped up again with the same spilt.


Videos are being stored twice

(I'm not sure if this has changed as my deploy is 2 weeks old.)
I noticed when you upload a video, it's being stored twice:

<dataplane_bucket>/video.mp4

<dataplane_bucket>/private/assets/<asset_id>/input/video.mp4

Resolved in https://github.com/awslabs/aws-media-insights-engine/releases/tag/v0.1.6. The data plane will now move the upload video file under /private/assets/ once a workflow is started.


Upload vagga to crates.io

Make it possible to install vagga with cargo install vagga.

Well, vagga now ships with busybox, apk, and alpine-keys, which need to be downloaded/installed with vagga. As far as I know there is no such mechanism in cargo install. I.e. cargo install is only suited to install a single binary.

And also you need to build vagga with musl libc. I'm not sure cargo install support that, but it's definitely not a default. So users will get defunct vagga by default (vagga doesn't work with dynamic linking because we need to run vagga in container where there are no original dynamic libraries such as libc).


🌐 Add Chinese translation for docs/zh/docs/advanced/custom-request-and-route.md

As title

📝 Docs preview for commit f96a2fc8cd13549e400d6d0a9530c657df16c487 at: https://6499e0fd3ef7fa008ac018b5--fastapi.netlify.app

Thank you @jaystone776! :rocket:
As you are one of the Chinese translations' champions, I'm gonna merge this right away. :tada:


gitignore includes /public

Public was added to gitignore on 2953ec6 two weeks ago. Is that on purpose.

Yes. Is it a problem?

Ok I vote for it to be changed back.
When I merged I was left with a suprising few untracked files.
According to git:
"pull and git merge will stop without doing anything when local uncommitted changes overlap with files that git pull/git merge may need to update".
I hope that cover my case, anyway I have a copy. No harm done.
When change back I assume my now tracked files will still be tracked and I have to remove the tracking with git rm --cached
as gitignore is only for new files I think.
Good luck

I'm no git expert but I don't know why we would to track those files. They local build outputs. Right?
They get generated on the fly and packaged with npm publish so no need to save to the repo?

s

I would have liked an anwser on my guestion and maybe som guidens on what to do. It is the generated folde of ng should I mark it skip-worktree?


Claiming namespace AsyncElegantOTA

Package information

Package link: https://github.com/ayushsharma82/AsyncElegantOTA

Description
I am the author.
Also, a question - how can I remove this library from PIO registry? It's deprecated.

You can remove the library within 72 hours after its publishing. The library that you mentioned is trendy, with over 850 new installs for the last month. See https://registry.platformio.org/libraries/ayushsharma82/AsyncElegantOTA/insights/analytics
Once we remove it from the registry, multiple projects will be affected.
I recommend creating a new patch version (for example, 2.2.9) and including a compilation warning that this library is deprecated.

@ivankravets , Thanks for the reply. I know, that's exactly why I want to remove the library from PIO registry (it's already under process for arduino-registry), people should migrate to ElegantOTA.
Being the author of both, AsyncElegantOTA was marked deprecated long ago therefore It's not in my best interest to keep this up in registry. There is already a deprecation notice for it but people are following old tutorials and soon the library will break with platform changes.

It's not in my best interest to keep this up in registry.

This is exactly the purpose of the registry - to KEEP ALL PACKAGES and VERSIONS even if they are deprecated.
I understand your position. However, it would be best if you thought from the end-user perspective. Usually, if something works, no one wants to change it. It would be best if you let our users have a choice of which version of the library they can use. As I mentioned before, publish a new version with a WARNING block to the deprecated library, and users will decide when they will have time to refactor their code base and migrate to the new version.

@ivankravets Already done that, warning block was in v2.2.8 for past 10 months, that’s enough time for anyone to acknowledge it.
So as a library author, I’m telling you to remove the library from your registry. This is not a stranger who is asking you to remove a random library. I hope you acknowledge my request.

The library has been deleted.


Adding gh_pages content

Current coverage is 36.40% (diff: 100%)

No coverage report found for master at b270b9a.

Powered by Codecov. Last update b270b9a...d42e3a4


Fix/replace finddomnode noconflicts

This is my attempt to clean up https://github.com/STRML/react-grid-layout/pull/1092 to get the Ref changes.
Thank you @STRML and others for any feedback.

Note: I do not have write access.  Can someone else merge?

Hey, I just tested it and it does not seem to work. In dist/react-grid-layout.min.js there are still findDOMNodes.

Concept ACK here, but please remove the massive style changes and please test with the examples.

Fixed and released in 1.2.3 via #1425.


billing: Normalize the remaining keys in mock_stripe

Merged, and also added normalization for Dates. Thanks @hackerkid!


Why are the "built" enum-X.js files npmignored?

Most libraries distribute their packaged files with npm so that they can be served to the browser from the same source dir as the server's version.
As it is now, I have to use npm install enum and maintain one version for the server and maintain a separate dependency for the browser.  This is not browser friendly even though the library should work great between node and the browser.
So essentially, I'm asking to remove: https://github.com/adrai/enum/blob/master/.npmignore#L3

Removing this line is okay for me... @adrai any objections?
@juuxstar Will you make a PR?

Ok


Remove spaces from filenames

Some tools, like Bazel, don't play well with spaces in filenames. Stick to file convention to use underscores or dashes to separate words in filenames.

The gem does not export this file and I root caused the Bazel issue to be a bad usage error.


is there any win32 demo  without qt deps

rt  how to use in win32 app maybe directui

it is available to use CefVeiwCore in win32 app with or without directUI, but sorry, no demo.


no-access-missing-member throwing when template accessing public properties on parent class

I have an Angular 4 app and I have a parent class for my custom components. There I have several public properties and methods which are used in the template of the custom components. The no-access-missing-member rule is throwing telling me those properties and methods don't exist on the class declaration.
Below is part of the files I'm using:
export class BaseComponent<T> implements ControlValueAccessor {
	disabled: boolean;
	focused: boolean;
	model: T;

        ...
}

@Component({
	selector: 'rm-input',
	templateUrl: './input.component.html',
	styleUrls: ['./input.component.scss']
})
export class InputComponent extends BaseComponent<string> implements OnChanges {

        ...

}

The InputComponent template is just using the disabled, focused, model properties and other methods declared on the BaseComponent.
The InputComponent is not hiding the base properties or methods and even if it was hiding them and using non-public identifier, it should be the templates-use-public rule the one throwing the warning.
I'm using the following libs:
"@angular/MODULE": "^4.0.1" // several modules
"codelyzer": "^2.1.1"
"tslint": "^4.5.1"
"typescript": "^2.2.2"

It's a known issue in version 2. It'll be fixed in version 3 (it already is).

Hi, version 2 and 3 of what?

Hi @mgechev, will this be fixed in a 2.x version aswell?

@trumbitta version 2 and 3 of this repo, codelyzer

@basst314 thanks, I should get more sleep. 😸

It's a known issue in version 2. It'll be fixed in version 3 (it already is).

@mgechev I'm still getting this warning even when I'm now using v3.0.0. Was the fix actually merged?
Thanks!

@mgechev This is issue is still reproducible on 3.0.1. Please check the repo: https://github.com/WiseBird/codelyzer_285

You can run tslint by npm run tslint

@WiseBird got the same issue as well

@mgechev This issue should be reopen.
I see the issue was fixed and merged to master (master at that time): #238 . During the time master start to be out of sync with this commit. 3.0.0-beta.X versions were released with this. Now, these tags are completely out of sync with master and these tags are not at any branch. These changes were never merged with master and released as 3.0.0.
I didn't looked into the code deeply so I'm not able to say how easy it's to get it back to master.

@mscelina this rule will be removed because the language service and the compiler are responsible for finding & reporting compile-time errors.

@mgechev I wish this check could be done in tslint, because we don't do aot during development and we end up having to fix problems only when we do a production build which takes a lot longer in our case.

@juanmendes you can use the Angular language service for the purpose. Here it is.


CVE-2022-41852 in commons-jxpath-1.3

Hello. There is CVE-2022-41852 with high level risk in commons-jxpath-1.3. This library is transitive for spring-cloud-netflix-eureka. Is the application using spring cloud netflix eureka affected by this vulnerability?

Please report it to netflix


Fix crash due to invoking a function storing state in the function itself

This test previously failed with:
Traceback (most recent call last):
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/decorators.py", line 245, in _advance
    return outcome.send(self._coro)
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/outcomes.py", line 51, in send
    return gen.throw(self.error)
  File "/home/eric/win-home/Repos/cocotb/tests/test_cases/test_external/test_external.py", line 380, in test_function_called_in_parallel
    v1 = yield t1
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/decorators.py", line 141, in _advance
    return outcome.send(self._coro)
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/outcomes.py", line 37, in send
    return gen.send(self.value)
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/decorators.py", line 363, in wrapper
    ret = ext.result  # raises if there was an exception
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/scheduler.py", line 105, in result
    return self._outcome.get()
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/outcomes.py", line 54, in get
    raise self.error
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/outcomes.py", line 17, in capture
    return Value(fn(*args, **kwargs))
  File "/home/eric/win-home/Repos/cocotb/tests/test_cases/test_external/test_external.py", line 375, in call_function
    return function(x)
  File "/mnt/c/Users/wiese/Repos/cocotb/cocotb/decorators.py", line 339, in __call__
    return self._event.outcome.get()
AttributeError: 'Event' object has no attribute 'outcome'

The cause was sharing an Event object between all function invocations, when there should have been one per call.

LGTM, thanks!


[FLINK-30386] Fix the issue that column constraint lacks primary key not enforced check

What is the purpose of the change
This pull request aims to fix the issue that the column constraint lacks the not enforced check.
CREATE TABLE foo (
  a INT PRIMARY KEY, -- currently this passes the validation, but it should be `a INT PRIMARY KEY NOT ENFORCED`
  b STRING
) WITH (...)

Brief change log
Currently, the constraint check(on the duplicate primary key, unique key, and enforced mode) spreads over the parse and conversion phase(see SqlCreateTable#validate and SqlToOperatoinConverter#validateTableConstraint).
To improve this, introduce a SqlConstraintValidator to perform the unified check for both column and table constraints.
The logic ofSqlToOperatoinConverter#validateTableConstraint is moved to SqlConstraintValidator.
Verifying this change
This change added tests and can be verified as follows:

FlinkSqlParserImplTest
SqlToOperationConverterTest
HBaseConnectorITCase
HiveServer2EndpointITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduces a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@LadyForest could you also create a backport pr for 1.16?


Hi, do I have to enable https to use brotli?

Hi, do I have to enable https to use brotli?

Yes.
Google first result for  "brotli https": https://stackoverflow.com/a/43862563

The reason to limit brotli to secure contexts is that intermediaries (specifically, buggy proxies and content scanners) tend to behave very poorly when they encounter non-deflate/gzip Content-Encoding. The Google guys discovered this when they rolled out ‘sdch’ and ‘bzip2’ before that; they ended up pulling bzip2 partly for that reason and sdch has a number of hacks that they had to put in. By requiring HTTPS for brotli, they can head off this problem in most cases because comparatively few content-scanners MITM HTTPS streams

谢谢


20354 money request participants selector list refactoring

Details

This PR refactors the MoneyRequestParticipantSelector and MoneyRequestParticipantPage to use new <SelectionList /> component.
Some other changes had been made, like moving some logic to useMemo hooks instead of invalid useEffect->useState pattern.
A new param has been added to <SelectionList /> to allow it to display a component on the right hand side of each list item. This param allows to pass a react node or a function that will render a component.
Fixed Issues

$ https://github.com/Expensify/App/issues/20354
PROPOSAL: no proposal (draft pr)
Tests

same as QA steps

[ ] Verify that no errors appear in the JS console

Offline tests

same as QA steps

QA Steps

[ ] Tap FAB on home page and select "Request Money"
[ ] Select manual, fill in the amount and press "Next"
[ ] A list of users/workspaces will appear
[ ] Tap on list item to create an IOU
[ ] Or tap on "Split" button on the list item to create a "split"
[ ] add more items from the list
[ ] verify that everything works like in the production app
[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@lukemorawski were you able to repro this issue? https://github.com/Expensify/App/pull/32692#pullrequestreview-1774241159

@rushatgabhane yep, working on that, but there seems to be some weird changes along the way. So now on main money request participants list step is served from MoneyTemporaryForRefactorRequestParticipantsSelector instead from MoneyRequestParticipantsSelector. They are mostly the samy, but there are some noticable differences. I decided to continue with MoneyRequestParticipantsSelector and bring the changes from the new file.

@rushatgabhane ok, moved changes to that new component and fixed the problem. The question is what to do with those unused files: MoneyRequestParticipantsPage.js and MoneyRequestParticipantsSelector.js?

unused files: MoneyRequestParticipantsPage.js and MoneyRequestParticipantsSelector.js?

@lukemorawski It's used in IOURequestStepParticipants, right?

@rushatgabhane merged and fixed imports

@rushatgabhane fixed!

@lukemorawski we have the same bug on send money page

Click +
Send money
Next

@lukemorawski we have the same bug on send money page

Click +
Send money
Next

fixed that

That's how the app currently behaves on main (before this refactor

yes you're right!

Bug:

Request money
In selector search, input some user
Click split

Expected: The user is selected

Actual: The user isn't shown as selected
https://github.com/Expensify/App/assets/29673073/523288fb-c8d9-48f1-8155-abab24741d2f

That's how the app currently behaves on main (before this refactor

yes you're right!

So it's good? :) Or should I try to fix that?

Bug:

Request money
In selector search, input some user
Click split

Expected: The user is selected
Actual: The user isn't shown as selected
Screen.Recording.2024-01-08.at.18.11.26.mov

Fixed that!

@rushatgabhane fixed conflicts

@lukemorawski and @rushatgabhane , Could you please make sure that the author and reviewer checklists pass?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

hey @lukemorawski - it seems like onChangeText is not debounced in SectionsList, can we get this fixed please before this become a deployer blocker?
https://github.com/Expensify/App/assets/9680864/3dd867be-32c7-4329-bdcc-d9889f721cdf

@youssef-lr on it!

@youssef-lr can you create an ticket from this comment, or should I just create a new PR and mention it here?

@youssef-lr here's the quick fix PR
https://github.com/Expensify/App/pull/34443

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@parasharrajat here's the quick fix PR https://github.com/Expensify/App/pull/34587

Thank you @lukemorawski @parasharrajat
I'll review it

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fix project info on top of buttons

Description
This PR places project info on top of the download button.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix a feature that knowingly causes existing functionality to not work as expected)

Test and Reproduce
Outline the steps to test or reproduce the PR here.

Impacted Areas in Application
List general components of the application that this PR will affect:
Which pages?

[ ] Login Screen
[ ] Single Upload Page
[ ] Batch Upload Page
[ ] All Projects Page
[ ] Sample Details Page
[ ] Report Page

Specific components

Testing Script:
###Login Page

Successfully login to the application and get taken to the project page

###Single Upload

Using an AWS path that doesn't exist throws an error
Succesfully uploaded files from a folder (use test host)
Uploading a duplicate file throws an error
Pipeline gets initiated successfully

###Batch Upload

Using an AWS path that doesn't exist throws an error
Succesfully uploaded files from a folder (use test host)
Navigate to batch upload settings page after upload
Host selection from previous page still selected
Uploading a duplicate file throws a warning
Pipeline gets initiated successfully

###All Project Page

Switch between projects
Search for a sample
Navigate through different pages of samples
Select Upload new sample button
Select sample to see generated report

###Sample Details Page

Information is consistent from Project Page
Notes are editable and save successfully
Can navigate to report page

###Report Page

Data loads succesfully
Collapse and Uncollapse button works
Clicking on the taxonomy name gives you total reads for that taxon
Category filter works
Genus Search works
Filters work as expected
Disabling Filters works
Filtering by column works

Checklist:

[ ] I have run through the testing script to make sure current functionality is unchanged
[ ] I have done relevant tests that prove my fix is effective or that my feature works
[ ] I have spent time testing out edge cases for my feature
[ ] I have updated the test script or pull request template if necessary
[ ] New and existing unit tests pass locally with my changes

@sadelokiki some conflicts to resolve first?

This commit pushes the Download button on the 'All Samples' page off the right edge on a medium window size?

@jshoe, it should be fine now.


Fix bug with expected nr of elements on cluster nodes command

CLUSTER NODES command returns ip, port AND a hash,
not just ip and port as you expected.
This error leads to clients unable to connect to cluster.
Tested with Redis 3.2.1

hi leon,
According to redis release note, they have changed CLUSTER SLOT output since 3.2.0 which contain the additional node ID. For backward compatibility reason, I fix this as follow:
-	if err != nil || len(t) != 2 {
+	if err != nil || len(t) < 2 {

Thanks for your feedback!


Create a Reusable Service

Tutorials: https://developers.sap.com/tutorials/cp-cap-java-reusable-service.html
Step 8: Run and test your application
mvn spring-boot:run does not work and results in following error:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for products-service parent 1.0.0-SNAPSHOT:
[INFO]
[INFO] products-service parent ............................ SUCCESS [  1.866 s]
[INFO] products-service ................................... FAILURE [ 10.909 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  13.157 s
[INFO] Finished at: 2021-09-17T08:31:32Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.5.2:run (default-cli) on project products-service: Application finished with exit code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :products-service
us

Hi @dirkelko,
Sorry for the late reply. Can you please reproduce the issue and provide the full build log by running this command:
mvn clean install -X > build-output.log. Please attach the build-output.log to this issue for further investigation.  I will need to talk to the dev colleagues about this. Please give me some time to get back to you.
Best regards,
Iwona

This seems to happen only with the old version of the tutorial where the project was generated with a different mvn archetype Version. With the current version using version 1.17.0 it works now.


New "Join the Community!" Page

Hope it is ok like this. :smile:
Scott

Awesome!!:+1:

Nicely written @smolinari ! 👍

@yyx990803 - Evan. What channels do you use inform users about new stuff? I know about Twitter. Any other means? Email? Facebook? I think any "informative" channels could also be mentioned on the page too. What do you think?
Scott

I know there is a announcements section in the forum, and the blog also sharing many exciting news.

Ok. I can add - "Watch" the announcements forum. Are those announcements only for forum stuff though?
Blog - good point. Though, does anyone still use RSS these days? :smile:
Scott

I still use RSS :joy:


[docs] generateMarkdown checks style rules before adding classes documentation

Summary
I was looking to contribute and noticed open issue #20310.
Most of the suggested changes (outlined in this comment: https://github.com/mui-org/material-ui/issues/20310#issuecomment-606047787) were taken care of in #22297.
It seems like the only thing that hadn't been updated was a potential update to generateMarkdown.
If this change won't be needed in the future, feel free to close this PR. I did not notice any changes that would occur to current documentation as yarn run docs:api did not change any of the markdown documentation files.
Otherwise, if this PR gets merged, it should close #20310.

[x] I have followed (at least) the PR section of the contributing guide.

Sorry about that. The issue was indeed already fixed with #20310 and #22297 for our v5 docs.


Support fail/check statement to break from nested transactions

Description:
At the moment, transactions are wrapped within lambda functions. Hence, the fail/check statement can only jump out of its own function scope.
As a solution, we need to bring the transaction statement desugaring inline supporting the fail/check to break the execution flow as needed.
Steps to reproduce:
while(true) {
  transaction {
    transaction {
     fail error("Custom error");
    }
   io:println("Should be unreachable");
  }
} on fail var e {
 io:println("Error caught");
}

Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Pushed changes to https://github.com/ballerina-platform/ballerina-lang/projects


:sparkles: new d3 number formatter created KIL-403

CATEGORY
Choose one

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

What's the meaning of grouping and currency?

What's the meaning of grouping and currency?

Grouping by 3 digits(thousands no idea why it needs to be flexible :P), currency: prefix and sufix on the currency format.


Micro-Optimization

Currently, if you are trying to decode something with the object tag, it takes 10 if checks for previous tags. Because three of those are only for backwards compatibility, and most people probably don't use them, I decided to push them closer to the end. This shaves off about 20% of the time per call of Unpickler._restore on my VPS with some of my test data (mixed 'py/object' and 'py/state'), and it didn't fail any pytest tests.
I plan to submit more optimizations in the future, I see great potential in this library for use if speed and security are taken care of.

This sound really cool!  Let me know if you need any help getting the test suite running locally for verification.  Hopefully there's not some use cases that are reliant on the current order of tag checking or other things.  Thanks for your help.

This sound really cool!  Let me know if you need any help getting the test suite running locally for verification.  Hopefully there's not some use cases that are reliant on the current order of tag checking or other things.  Thanks for your help.

Thanks! I got the testing suite running locally, but I couldn't get flake8 and black running so I could use some advice with that.

Thanks! I got the testing suite running locally, but I couldn't get flake8 and black running so I could use some advice with that.

Also, is it okay if I add some commits for documentation updates to this? I noticed that docs for Unpickler are very sparse in terms of describing what the various decoding options do, and I'm not sure how to make a new PR with the documentation changes but without these optimization changes.

Also, is it okay if I add some commits for documentation updates to this? I noticed that docs for Unpickler are very sparse in terms of describing what the various decoding options do, and I'm not sure how to make a new PR with the documentation changes but without these optimization changes.

Closing in favor of an even more efficient unpickler that I'm going to make a new PR for. I tested this one with tox on every python version, so I expect it to work.

Closing in favor of an even more efficient unpickler that I'm going to make a new PR for. I tested this one with tox on every python version, so I expect it to work.


entry.completion_item.data.detail always returns empty value

I used to have entry.completion_item.data.detail returning the prediction strength but now seems to be always empty.
I have show_prediction_strength = true and my cmp setup is the following:
if entry.source.name == "cmp_tabnine" then
    vim_item.kind = " " .. "" .. " "
    local detail = (entry.completion_item.data or {}).detail
    if detail and detail:find('.*%%.*') then
        vim_item.menu = '   ' .. detail
    else
        vim_item.menu = ' TabNine '
    end
end

This used to work... I don't know when this stopped working but in the meantime I switched to https://github.com/folke/lazy.nvim, but I don't know if it is related as the cmp_tabnine setup function seems to be working cause if I change some options there, they take effect.

Not related.
Its a value returned from the TabNine process, which does not always attach the percentages.

The thing that I find weird is that it used to constantly show the percentages and now they literally never appear. Probably something changed in Tabnine...


test/e2e/suite/conformance/certificates: fix dropped error

Signed-off-by: Lars Lehtonen<EMAIL_ADDRESS>This fixes a dropped error in test/e2e/suite/conformance/certificates.
NONE

/lgtm
/approve
/ok-to-test

/kind cleanup