(SERVER-2662) Don't recompute Authority Key extensions

Previous to this change, the Authority Key would be recomputed based
on the public key of the certificate of the ca; this change instead
copies from the existing certificate, allowing for different key
types to be used.

I've verified this behaves mostly ok in a vm with puppetserver modified to use the new functionality:
ca cert info:
[root@seminal-yawn ~]# openssl x509 -in /etc/puppetlabs/puppet/ssl/ca/ca_crt.pem -text -noout | grep --after 1 'Subject Key'
            X509v3 Subject Key Identifier:
                E6:7D:39:89:78:D4:96:D3:AD:FF:46:26:C9:1E:3E:39:F0:69:1E:60

new agent cert info
[root@seminal-yawn ~]# puppetserver ca generate --certname bb.com
[root@seminal-yawn ~]# openssl x509 -in /etc/puppetlabs/puppet/ssl/certs/bb.com.pem -text -noout | grep --after 3 'Authority Key'
            X509v3 Authority Key Identifier:
                keyid:E6:7D:39:89:78:D4:96:D3:AD:FF:46:26:C9:1E:3E:39:F0:69:1E:60
                DirName:/CN=root-ca.puppet.test
                serial:0C:61:0B:9C:C7:CE:70:99:A8:FF:2B:62:10:CE:47:8D:84:9D:F9:70

deleting the agent cert and checking the crl
[root@seminal-yawn ~]# puppetserver ca clean --certname bb.com
Certificate for bb.com has been revoked
Cleaned files related to bb.com
[root@seminal-yawn ~]# openssl crl -in /etc/puppetlabs/puppet/ssl/crl.pem -text -noout | grep --after 1 'Authority Key'
            X509v3 Authority Key Identifier:
                keyid:E6:7D:39:89:78:D4:96:D3:AD:FF:46:26:C9:1E:3E:39:F0:69:1E:60

I say mostly ok because the Authority Key on the agent cert is populated by a fuller, more thorough Authority Key than what puppet has used previously. The agent connects fine, though I am not sure if there are implications for this more thorough Authority Key for support: @Sharpie care to weigh in?

There's still a little cleanup I have to do—I think there is still some weird java whitespace issues—and I haven't gone to cleanup all the random imports I was trying to get a clean way to extract an authorityKeyId—but other than that this is ready for review.


Passing arguments in Run-DotNetExe not working properly

For example, passing this to Seatbeld doesn't work:
-Arguments '-group=all -outputfile=file.txt'

Seatbelt says all -outputfile=file.txt is not a valid group.
So clearly something goes wrong when parsing the arguments. Might affect other Run-* Cmdlets, too.

 I included this as an example in the docstring to Run-DotNETExe.


Microsoft Remote Desktop crashes when allow_channels is set to true

Version: https://github.com/neutrinolabs/xrdp/commit/82614597079560ee4ec9e3c8559ff9187b464d6a
Microsofts Remote Desktop crashes when the option "allow_channels" is set to true. It seems that whatever xrdp is sending is not something that should be there. Changing any of the channels to false doesn't solve the problem.
Workaround: Set allow_channels to false.

Reencountered half a year later, thank god for open issues like these to figure out how to solve things.

I'd like to clarify what is "Microsoft Remote Desktop" you talking about.
Windows' RDP client mstsc.exe?

Exactly. It's not the only one that crashes with allow_channels set to true, but it's by far the most non-crash resistent RDP client.

(suggestion)
why do you not create via qt or an other multisystem possibility ,
creating a good client ;) as garnish (delicious) for diffrent System,
who be an bit stable and crash-resistand as the mstsc ;)
it's a point ?
keep it up ! :)
best regards
Blacky

I think this is fixed by #615. Please reopen if still happen with current devel head.

I've rebuilt and tested. Last devel also fixed #207 finally. Copy & Paste doesn't work but at least it doesn't crash Microsoft Remote Desktop. Great work!

Encountered this today on a freshly-installed FC25 box... xrdp 0.9.2

What is your client version?

@metalefty Microsoft Remote Desktop (for Mac) Version 8.0.39 (Build 27287)
Also, unlike my previous VM which was running on a FreeBSD host (via bhyve) and on an Atom C2750, this one runs on ESXi on a Xeon D-1521... And maybe it's because of some driver issues, but the RDP session crashes constantly: for example, when I click on certain buttons of the UI, when I select text in a textbox, etc... The OS is Fedora Workstation 25, latest updates, running LXDE. Not sure how much of this is XRDP's fault, but it's highly unstable compared with my previous experience.

Is your backend VNC? If so, your issue looks like #755 rather than this.

I am not sure, I have just installed xrdp on Fedora and I believe it has "Xvnc" as backend (but don't quote me on that).
I've cleared my clipboard and the issue appears anyways.

Did you try compiling from source @EgoAleSum? Some distros ship an older version as stable (such as Debian, Ubuntu).

@EgoAleSum
I looked into Fedora package. Fedora defaults to Xvnc.  I believe you're using Xvnc backend.  As discussed in #755, xrdp has a problem Xvnc + clipboard and not fixed yet.  Fedora guys provide a workaround how to avoid disconnection. You should see /usr/share/doc/xrdp/README.Fedora.
For further discussions, let's move to #755 since your issue is most likely to #755.


BUG: linalg.det: Fix edge case handling of stacked 1x1 arrays

Closes gh-21582.

Thanks @lucascolley, including thanks for--once again--the copy-edit of the title!

including thanks for--once again--the copy-edit of the title!

no worries, I do it to everyone :)


Add remote field in admin

Remote field is not added in admin. Add it to admin to navigate the value.

Codecov Report

Merging #715 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   74.38%   74.45%   +0.06%
==========================================
  Files          72       72
  Lines        2733     2740       +7
==========================================
+ Hits         2033     2040       +7
  Misses        700      700

Impacted Files
Coverage Δ

src/proposals/admin.py
100.00% <ø> (ø)

src/core/templatetags/pycontw_tools.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dffef7...d1bf6df. Read the comment docs.


Key must be 64 encoded

I am receiving error on the simulation, stating that the key must be 64 encoded. How to fix the issue?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d2af37f-a62d-13c8-2bce-626231e12824
Version Independent ID: 557bcb4d-855a-22f1-7114-19a767645071
Content: View Azure IoT Hub message routing results (.NET)
Content Source: articles/iot-hub/tutorial-routing-view-message-routing-results.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@interfacemirror Is this the issue you are facing? https://github.com/Azure-Samples/azure-iot-samples-csharp/issues/27

@Alberto-Vega-MSFT  yes, it seems the same.

Closing issue here since the issue is being worked on in the samples repository.


Lang files

Hi, can you add lang files for translation?

@TheQmaks thanks for the suggestion, nice feature to have, added to the feature list 👍

@1modm I wanna help with that feature. How can we track that to avoid double work on the same issue? Once I've finished I'll push a PR.

@alacerda thanks for the help, yes sure will be very useful, for me the first step is how to manage lang files in django, then we can focus in the templates to include the fields to translate.
What I can do is another branch and then merge to the main one.
https://github.com/1modm/petereport/tree/translation
Thanks

Added Multilingual and Internationalization support.
You can translate to French editing the po file in https://github.com/1modm/petereport/blob/main/app/locale/fr/LC_MESSAGES/django.po


Would it be possible to filter to show only vegan food?

Would it be possible to filter to show only vegan food?

please close this issue. Thanks.


Stopping/Terminating the instance, doesn't delete the A record of previous instance inside the private hosted zone

Hi,
Creating an EC2 instance with the same ZONE, CNAME record, updates the previous CNAME record to map to new EC2 instance's internal DNS. However, the A record associated with the previous EC2 instance is not getting deleted/updated, instead a new A record to associate the internal to DNS to private IP.

Thanks for the feedback.  Can you describe a scenario where you would assign the same zone and CNAME record to an instance?  As it's currently written, the records only get deleted when you terminate the instance.

Hi,
One scenario would be if we have to use this for auto-scaling groups. For example, if we have to have the DNS record to map to the IP of the latest instance in the ASG. When 1st instance is launched in ASG, one CNAME and one A record are created. When another instance is created in that ASG with same tags (suppose other app is using one internal dns to connect to this app's nodes), the CNAME record is updated, but A record is newly created leaving the old record. So, we with the current implementation, we will have to keep an eye to periodically clean up the old A records.

This is an edge case that I didn't account for when I wrote the function.  The A record isn't updated because the IP address of new instance is different than the first instance.  Can you explain why you want to assign the same CNAME to multiple instances? You might want to consider putting the instances behind an ELB.  Short of that, you could write a timed Lambda function to cull stale records from DNS.


feat: Maker support for get-triggers

Description
This pull request adds support for Maker automation triggers. It's a part of adding omni kit support to Maker in oasis borrow.
Changes

mapped all maker triggers
added two types of mapping helpers:

simple trigger for triggers which are just mapped from the subgraph data

advanced trigger for triggers that need more data (async)

extracted mapResponse function, because the main file became too large
query string params are changed:
-dpm is deprecated in favor of account (with backwards compatibility)

this is because account field in subgraph works both for ds proxy and dpm

extracted logger to make sure it's one instance

Testing
/api/triggers?chainid=1&account=[ds proxy address]

Next steps

Add support to create triggers.

Please review and provide any feedback or suggestions for improvement.

Summary by CodeRabbit
Release Notes

New Features

Enhanced GraphQL query for triggers, now includes additional fields and improved filtering by account.
Introduced new trigger types and constants for Maker protocol, expanding capabilities for automated trading strategies.
Added a new field triggerGroupId to the GraphQL schema for better categorization of triggers.
Added validation schema for incoming parameters to ensure data integrity.
Implemented functions for advanced trigger management and filtering.

Bug Fixes

Updated parameter handling to maintain backward compatibility with existing clients.

Refactor

Streamlined code structure by modularizing trigger processing logic, improving maintainability.

Documentation

Added structured logging capabilities to enhance observability within the application.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (dev@fad67fd). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #496   +/-   ##
======================================
  Coverage       ?   73.17%
======================================
  Files          ?      129
  Lines          ?     1357
  Branches       ?       78
======================================
  Hits           ?      993
  Misses         ?      364
  Partials       ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add headers to the DRM License request

Hi , I would like to pass custom headers as part of the DRM license request.
Currently authentication cookies can be passed, but it would be handy if an header based authentication scheme could also be supported.
My intention was to complete this work, extending the DrmSchemeInfo and LicenseRequest. Sound sensible?
CLA is in progress.
Cheers
Mark

Hi,
Check out 6d08f0b97a381d8cc7e20ba2d9a2b60cba50b2e2 which addressed Issue #62. With this patch DrmSchemeInfo now takes a licensePreProcessor callback which can modify the raw license request and add additional headers to the request itself.

Thanks! I just spotted that myself.


How to handle the validation and getCallingCode if we use multiple phoneInput in single page

Scenerio : Usually, we can validate the phonenumber & country code with help of UseRef of the phone input component. In my case, its dynamic based on the user selection, it will create a number of phoneInput boxes. That time, if the user changed different country code and number means it is validating with last changed countrycode with other phone number.
Problem faced: isvalidNumber & getcallingcode not properly working if multiple phone input boxes.
Expecting:
1. how to solve by using multiple useref? or
2. Any suggestion to validate and get the calling code?

I have handled this by putting React-Native-Phone-Number-Input within a component with it's own refs and state. Then you can dynamically render multiple of those parent components.


pos-derived-key-workaround-do-not-merge

#557  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tholonious and the rest of your teammates on  Graphite


Disable quote checking by default

Commenting on double or single quotes has surprised some users. I think it's best to disable the check by default and let each team choose which type of quotes they would like Hound to enforce.

@gylaz, thoughts?

I was thinking we should get this in before https://github.com/thoughtbot/hound/pull/617.

Is is right that this change will disable quote checking for all active repos
without a custom config overriding the default?
On Tuesday, February 10, 2015, Scott Albertson<EMAIL_ADDRESS>wrote:

I was thinking we should get this in before #617
https://github.com/thoughtbot/hound/pull/617.
—
Reply to this email directly or view it on GitHub
https://github.com/thoughtbot/hound/pull/618#issuecomment-73832781.

Yes, I don't think it's worth it.

I think we want to do this, but not for existing repos, and only after we've moved the server-side config into the db.

Agreed!


Optimized Dockerfile template for building custom Prompt Flow containers.

Is your feature request related to a problem? Please describe.
The feature request is not related to a problem, but a possibility to optimize Prompt Flow performance.
Describe the solution you'd like
The pf flow build --format docker command adds a Dockerfile based on docker.io/continuumio/miniconda3:latest as can be found in:
https://github.com/microsoft/promptflow/blob/8e55822664ed70b37074fbd77b11a8351c5e0ece/src/promptflow/tests/test_configs/flows/export/linux/Dockerfile#L2
This works, but results in long Docker image build times and possibly unwanted overhead.
Describe alternatives you've considered
I found that substituting this with the following Dockerfile results in much faster build times and much smaller and faster pushes to a container registry:
# syntax=docker/dockerfile:1
FROM mcr.microsoft.com/azureml/promptflow/promptflow-runtime-stable:latest

WORKDIR /

COPY ./flow /flow

EXPOSE 8080

COPY ./connections/* /connections/

RUN pip install keyrings.alt -r /flow/requirements.txt

# reset runsvdir
RUN rm -rf /var/runit
COPY ./runit /var/runit
# grant permission
RUN chmod -R +x /var/runit

COPY ./start.sh /
CMD ["bash", "./start.sh"]

Additional context
This documentation page also mentiones, that Dockerfiles created to run Prompt Flow should be based on promptflow-runtime-stable.

Thanks for the feedback! @TechPreacher
The promptflow-runtime-stable is a image that has addtional package & component for azure scenario.
It's by design to use a simpler base image as the default one.
For now user can change it if they wish to use the other image.
However, we plan to have a new mcr image that has only promptflow executor related pacakge as part effort of side-car support for promptflow runtime.
Please expect it in the long term change.

Thanks for the clarification, @wangchao1230


encoderd crashed during onroad

Describe the bug
Normal drive, go to engage and get alert: "Process not running: encoderd"
reboot fixed issue, unsure about repeatability.
Provide a route where the issue occurs
8d8427a2116eace2|2022-11-02--08-40-28--0
openpilot version
b31b0310444e83dc8e151767f57ee21f46f1515b
Additional info
No response

Looks like there's two different encoderd crashes:
a few seconds after encoderd startup
[53964.495079] MAIN 0 kernel - msm_vidc: info: Opening video instance:<PHONE_NUMBER>000000, 0
[53964.495129] MAIN 0 kernel - msm_vidc: info: Opening video instance:<PHONE_NUMBER>000000, 0
[53964.495196] MAIN 0 kernel - msm_vidc: info: Opening video instance:<PHONE_NUMBER>000000, 0
[53964.495380] MAIN 0 kernel - msm_vidc: info: Opening video instance:<PHONE_NUMBER>000000, 0
[53967.530849] MAIN 0 kernel - msm_vidc:  err: State not recognized
[53967.530928] MAIN 0 kernel - msm_vidc:  err: Failed to move from state: 16 to 13
[53967.531024] MAIN 0 kernel - msm_vidc:  err: msm_comm_kill_session: no session to kill for inst<PHONE_NUMBER>000000
[53967.531084] MAIN 0 kernel - msm_vidc:  err: Failed to move inst:<PHONE_NUMBER>000000 to state 13
[53967.531148] MAIN 0 kernel - msm_vidc:  err: Failed STOP Streaming inst =<PHONE_NUMBER>000000 on cap = 9
[53967.531221] MAIN 0 kernel - msm_vidc: info: Closed video instance:<PHONE_NUMBER>000000
[53967.531282] MAIN 0 kernel - msm_vidc:  err: State not recognized
[53967.531342] MAIN 0 kernel - msm_vidc:  err: Failed to move from state: 16 to 13
[53967.531394] MAIN 0 kernel - msm_vidc:  err: msm_comm_kill_session: no session to kill for inst<PHONE_NUMBER>000000
[53967.531449] MAIN 0 kernel - msm_vidc:  err: Failed to move inst:<PHONE_NUMBER>000000 to state 13
[53967.531509] MAIN 0 kernel - msm_vidc:  err: Failed STOP Streaming inst =<PHONE_NUMBER>000000 on cap = 9
[53967.531589] MAIN 0 kernel - msm_vidc: info: Closed video instance:<PHONE_NUMBER>000000
[53967.531643] MAIN 0 kernel - msm_vidc:  err: State not recognized
[53967.531703] MAIN 0 kernel - msm_vidc:  err: Failed to move from state: 16 to 13
[53967.531760] MAIN 0 kernel - msm_vidc:  err: msm_comm_kill_session: no session to kill for inst<PHONE_NUMBER>000000
[53967.531838] MAIN 0 kernel - msm_vidc:  err: Failed to move inst:<PHONE_NUMBER>000000 to state 13
[53967.531890] MAIN 0 kernel - msm_vidc:  err: Failed STOP Streaming inst =<PHONE_NUMBER>000000 on cap = 9
[53967.531948] MAIN 0 kernel - msm_vidc: info: Closed video instance:<PHONE_NUMBER>000000
[53967.994982] MAIN 0 kernel - msm_vidc:  err: State not recognized
[53967.995078] MAIN 0 kernel - msm_vidc:  err: Failed to move from state: 16 to 13
[53967.995132] MAIN 0 kernel - msm_vidc:  err: msm_comm_kill_session: no session to kill for inst<PHONE_NUMBER>000000
[53967.995220] MAIN 0 kernel - msm_vidc:  err: Failed to move inst:<PHONE_NUMBER>000000 to state 13
[53967.995271] MAIN 0 kernel - msm_vidc:  err: Failed STOP Streaming inst =<PHONE_NUMBER>000000 on cap = 9
[53967.995329] MAIN 0 kernel - msm_vidc: info: Closed video instance:<PHONE_NUMBER>000000

In the middle of the drive
{'tombstone': 'selfdrive/loggerd/encoderd - Signal: 6 (SIGABRT) -  in V4LEncoder::dequeue_handler  at selfdrive/loggerd/encoder/v4l_encoder.cc:111'}

Same issue on Release today, wouldn't go onroad because "Process not running: encoderd"
35c004509e3057f2|2023-03-16--06-42-13--0

Another occurrence: 4822a427b188122a|2023-08-14--16-22-21

Another ff2bd20623fcaeaa|2023-08-18--10-13-46

Happened on one of the CI devices recently, and in that case, it was due to camera re-alignment and frame ID skips.

Just happened in CI again in 3799fe4.


equivalent of ivy-re-builders-alist for selectrum?

Hi there,
I'm trying to switch from ivy/counsel/swiper to selectrum/consult/prescient, and am wondering if it's possible to have different candidate filtering queries for different types of candidate lists?  For example, I might want fuzzy matching by default for find-file but not switch-to-buffer.
In ivy this is possible via the ivy-re-builders-alist variable, and indeed I see that ivy-prescient.el adds ivy-prescient-re-builder for use with this custom variable, and I also see #82 from someone who wants to continue with this mixed approach when using ivy-prescient.
However I would like to do it with the selectrum + prescient combination.
I appreciate that I can interactively toggle the various filter methods via M-s (selectrum-prescient-toggle-map), but this would require doing every time if I have different preferences for different contexts.
So is it possible to configure the default filtering per completion context in selectrum-prescient?
If not, please can this be considered a feature request?
Many thanks for this great software!

This is not built in because I don't see a robust way to identify a key to denote the "current context". I think that Ivy uses this-command, which has various non-obvious pitfalls and edge cases. Of course, I have no issue with users keying off this variable if they are comfortable with the implications, but I'm hesitant to put this logic directly into the library.
However, here is one option that occurs to me. We could make it so prescient-filter-method can be a function, in which case it's called to get the real value. Then, if you wanted to have a different filter method depending on the context (or depending on anything else), you can simply write your own function that does a case off this-command. What do you think of that solution?

Thanks for the quick reply!
@raxod502 commented on December 14, 2020 11:16 PM:

This is not built in because I don't see a robust way to identify a key to denote the "current context". I think that Ivy uses this-command, which has various non-obvious pitfalls and edge cases.

this-command is the third of three things it uses.  M-x describe-variable ivy-re-builders-alist gives a bit more detail:

An alist of regex building functions for each collection function.
Each key is (in order of priority):

The actual collection function, e.g. ‘read-file-name-internal’.
The symbol passed by :caller into ‘ivy-read’.
‘this-command’.
t.

but I previously filed swiper#2620 because the documentation does not make it entirely clear how that works.  As you can see, I got some helpful replies.  Now that I understand it, that approach seems reasonable, as the first two options are more reliable than this-command.

Of course, I have no issue with users keying off this variable if they are comfortable with the implications, but I'm hesitant to put this logic directly into the library.

Yeah, relying solely on this-command sounds fragile.  What do you think about ivy's approach above?  Like I said, it seems reasonable to me (and in my experience, works fine once you understand how to correctly configure ivy-re-builders-alist) but I could be missing something.

However, here is one option that occurs to me. We could make it so prescient-filter-method can be a function, in which case it's called to get the real value. Then, if you wanted to have a different filter method depending on the context (or depending on anything else), you can simply write your own function that does a case off this-command. What do you think of that solution?

That sounds fantastic to me for ultimate flexibility!  Although even if that was added, I think it would probably still be worth adding something along ivy's approach above, because the custom function approach would require each user to write some code, and there are plenty of emacs users (in fact, most likely the majority) who like to tweak their config but don't know elisp well enough to do this.  The counter-argument to that is "well they can just copy and paste some elisp from a README or a wiki page" but the counter-counter-argument to that is that copying and pasting code you don't understand is (IMHO) a butt-ugly approach which rapidly leads to brittle outdated config which is hard to maintain ;-)

That all makes sense. I am still not sure I think it would be a good idea to introduce an alist for this, however:

The actual collection function will in many cases not be a symbol.
We don't have a :caller argument, which is intentional because we are not trying to wrap every Emacs command in a special wrapper to make them work with prescient.el and related packages.
this-command is very unreliable and I don't want to encourage its use explicitly.

I think that in most cases the key used by Ivy is not a good idea to rely on, at least in the prescient.el context. You are certainly right that it's not ideal to expect people to write code when something else would do. However:

I think it's very important that we do not explicitly support this brittle feature. If we do, then people will reasonably get the impression that it is supposed to always work, and if it doesn't then there is a bug in prescient.el. This happened to Ivy and I don't want to repeat it here.
Given that it is unlikely for this feature to always work, I actually think being forced to write code is better for everyone, even the people who are not very comfortable with writing code. Because if you are forced to write code to implement this logic, then it will be readily apparent where the problem is if it doesn't work (it must be in the few lines of code you just wrote, rather than somewhere in the monolith of the library package that is trying to do it automatically and failing), and it's also a lot easier to debug (for example, you could add a (message "%S" ...) line into your code to see what is going on). With some examples given in the documentation, I think this could be a perfectly user-friendly approach. I just can't imagine debugging the alist, which happened all the time with Ivy, being a friendly experience for someone not comfortable with Elisp. Either it works or it doesn't, and there is no visibility into why.

I think you've mostly convinced me.  And anyway, allowing prescient-filter-method to be a function is a fantastic first step and doesn't prevent extending it to support further flexibility in the future.
That said, more detailed replies follow below ...

That all makes sense. I am still not sure I think it would be a good idea to introduce an alist for this, however:

The actual collection function will in many cases not be a symbol.

Not surprised to hear that, but (forgive my ignorance) what else will it be?

We don't have a :caller argument, which is intentional because we are not trying to wrap every Emacs command in a special wrapper to make them work with prescient.el and related packages.
this-command is very unreliable and I don't want to encourage its use explicitly.

I think that in most cases the key used by Ivy is not a good idea to rely on, at least in the prescient.el context.

That seems totally fair to me.

You are certainly right that it's not ideal to expect people to write code when something else would do. However:

I think it's very important that we do not explicitly support this brittle feature. If we do, then people will reasonably get the impression that it is supposed to always work, and if it doesn't then there is a bug in prescient.el. This happened to Ivy and I don't want to repeat it here.

Also totally fair.

Given that it is unlikely for this feature to always work, I actually think being forced to write code is better for everyone, even the people who are not very comfortable with writing code. Because if you are forced to write code to implement this logic, then it will be readily apparent where the problem is if it doesn't work (it must be in the few lines of code you just wrote, rather than somewhere in the monolith of the library package that is trying to do it automatically and failing), and it's also a lot easier to debug (for example, you could add a (message "%S" ...) line into your code to see what is going on).

While that might be true for those who dabble in elisp, I'm pretty sure there will be a large group of users, probably even a majority, who literally know nothing about elisp and their interactions with it will be limited to copying and pasting code they don't understand and have no idea how to debug.  (This is based on the assumption that many many people use emacs for coding totally unrelated languages like C, C++, Java, Python, Javascript, and some even use it without doing any coding at all, e.g. just for things like Org mode.)
For those people, it will not be readily apparent where things fail, or how to deal with the failures.  Now of course I am not saying that this means it's your responsibility to maintain brittle code on their behalf!  That would be ludicrous ;-)  But there may be others who are willing to do this maintenance.  So I think your proposal of allowing prescient-filter-method to be a function should do the job nicely, since it would allow third parties to provide functions for reuse, and potentially even distribute them via maintained repositories (although maybe that would be overkill, I'm not sure yet).

With some examples given in the documentation, I think this could be a perfectly user-friendly approach. I just can't imagine debugging the alist, which happened all the time with Ivy, being a friendly experience for someone not comfortable with Elisp. Either it works or it doesn't, and there is no visibility into why.

Ivy has things like ivy-alist-setting which could be made more user-friendly by adding debugging (optional or otherwise).  For example I like the way straight.el debugs some stuff into *straight-process*.  use-package and others adopt a similar approach.  It would be easy for Ivy and other packages to adopt a similar approach, so that when the user isn't getting the behaviour they expect, they can just switch to that internals buffer to get some hints on what might have gone wrong.

The actual collection function [...] what else will it be?

I am assuming by "collection function" that Ivy is referring to the COLLECTION argument of completing-read, which can be a function. For example, read-file-name-default passes the symbol read-file-name-internal as this argument.
However, as per the docstring of completing-read:
COLLECTION can be a list of strings, an alist, an obarray or a hash table.
COLLECTION can also be a function to do the completion itself.

So not only can the collection function be a lambda rather than a symbol (anything that counts as a function will do), it can also be a literal collection, rather than a function. And in fact this is the more common case, since using a function is only really needed when you are generating the candidates dynamically, as in filename completions.

third parties to provide functions for reuse, and potentially even distribute them via maintained repositories

Yes, that was exactly my thought. The idea would be that prescient.el itself can continue being a simple package that works in all circumstances, and it can provide hooks that other packages, which do not make such guarantees about working in all circumstances, can use to implement these kinds of features.
It's rather like the divide between https://github.com/raxod502/selectrum and https://github.com/minad/consult, where the one package is limited to providing the general interface, and the other package gets into the grimy details of all those special cases to give people the specific functionality they want in each case.
We can just start off with random code snippets that can be copied and pasted, and if it turns out to be a popular thing people want, then we could condense that work into a package that could be installed without the need for copying and pasting anything.

they can just switch to that internals buffer to get some hints on what might have gone wrong

This is a fair suggestion. I'd still like to keep the command-specific logic out of prescient.el proper, but an extension package which implemented this kind of conditional logic would greatly benefit from such a debugging interface, like you suggested, I think.

OK, so it sounds like we have a plan.  Is it basically just a question of changing prescient-filter-regexps to check whether prescient-filter-method is a function, and if it is, calling it and using the result?
If so, I could maybe take a stab at that, but I'm currently blocked on a lack of understanding of how the context (in particular, COLLECTION) would be provided to that function, because it's not (currently) passed down the call stack.  I see that it's passed from selectrum-completing-read to selectrum-read as minibuffer-completion-table, but it only seems to be used for a non-nil check.  And like you said, relying purely on this-command would not be very reliable.
Would we need to pass the context as an extra argument, or perhaps provide it via a dynamically bound variable?

OK, so it sounds like we have a plan.  Is it basically just a question of changing prescient-filter-regexps to check whether prescient-filter-method is a function, and if it is, calling it and using the result?
If so, I could maybe take a stab at that, but I'm currently blocked on a lack of understanding of how the context (in particular, COLLECTION) would be provided to that function, because it's not (currently) passed down the call stack.  I see that it's passed from selectrum-completing-read to selectrum-read as minibuffer-completion-table, but it only seems to be used for a non-nil check.  And like you said, relying purely on this-command would not be very reliable.
Would we need to pass the context as an extra argument, or perhaps provide it via a dynamically bound variable?

I just noticed that https://github.com/raxod502/selectrum/issues/114 also talks about handling of minibuffer-completion-table; not sure if that's relevant somehow.

I just noticed that https://github.com/raxod502/selectrum/issues/114 also talks about handling of minibuffer-completion-table; not sure if that's relevant somehow.

@aspiers I am not sure if I got the full discussion. But I think what you should use here is the completion category metadata. Based on the category select the desired completion styles/prescient filtering styles.

@aspiers I am not sure if I got the full discussion. But I think what you should use here is the completion category metadata. Based on the category select the desired completion styles/prescient filtering styles.

See also https://github.com/minad/consult/issues/123#issuecomment-753940017 for a short discussion regarding different completion styles per command in consult with orderless. @protesilaos simply introduced wrappers for the commands with a special style. But you could also achieve this via some advice at the right place and then using the completion category.

See also https://github.com/minad/consult/issues/123#issuecomment-753940017 for a short discussion regarding different completion styles per command in consult with orderless. @protesilaos simply introduced wrappers for the commands with a special style. But you could also achieve this via some advice at the right place and then using the completion category.

@minad Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context?  I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.
I can see how wrappers or advice would work fine, but I presume they would have the drawback of being much harder for the average user to set up, which is a concern @raxod502 and I discussed quite a bit further up in this issue.

@minad Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context?  I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.
I can see how wrappers or advice would work fine, but I presume they would have the drawback of being much harder for the average user to set up, which is a concern @raxod502 and I discussed quite a bit further up in this issue.

Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context? I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.

See here for an example, each completing-read/consult--read can have a category: https://github.com/minad/consult/blob/c607afa65ae203a8904e7d18ddfbbccc53c1c680/consult.el#L2451. You can obtain it from the current minibuffer completion table by accessing the metadata.

Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context? I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.

See here for an example, each completing-read/consult--read can have a category: https://github.com/minad/consult/blob/c607afa65ae203a8904e7d18ddfbbccc53c1c680/consult.el#L2451. You can obtain it from the current minibuffer completion table by accessing the metadata.

Apologies in advance if I'm misunderstanding any of this.  I'm still not very familiar with how everything fits together.
@minad commented on January 9, 2021 10:45 PM:

Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context? I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.

See here for an example, each completing-read/consult--read can have a category<EMAIL_ADDRESS>
OK, that's very similar to COLLECTION referred to above.  But my previous question remains: how would that metadata get passed from selectrum-read to prescient-filter-method?

You can obtain it from the current minibuffer completion table by accessing the metadata.

Yeah, I did notice the link with minibuffer-completion-table; in fact I suspect my comment about that was probably what drew your attention to this issue.  But like I said, minibuffer-completion-table is only passed as far as selectrum-read, in which it is only used for a non-nil check and otherwise ignored.  So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?
BTW this all seems slightly at odds with @raxod502's comment:

We don't have a :caller argument, which is intentional because we are not trying to wrap every Emacs command in a special wrapper to make them work with prescient.el and related packages.

So I assume any such metadata would have to remain optional from the perspective of selectrum and prescient.

Apologies in advance if I'm misunderstanding any of this.  I'm still not very familiar with how everything fits together.
@minad commented on January 9, 2021 10:45 PM:

Thanks - forgive my ignorance but I'm not sure what you mean by "completion category metadata" in this context? I'm guessing this is the same thing as the context which in my previous comment I was saying that I don't know how to obtain.

See here for an example, each completing-read/consult--read can have a category<EMAIL_ADDRESS>
OK, that's very similar to COLLECTION referred to above.  But my previous question remains: how would that metadata get passed from selectrum-read to prescient-filter-method?

You can obtain it from the current minibuffer completion table by accessing the metadata.

Yeah, I did notice the link with minibuffer-completion-table; in fact I suspect my comment about that was probably what drew your attention to this issue.  But like I said, minibuffer-completion-table is only passed as far as selectrum-read, in which it is only used for a non-nil check and otherwise ignored.  So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?
BTW this all seems slightly at odds with @raxod502's comment:

We don't have a :caller argument, which is intentional because we are not trying to wrap every Emacs command in a special wrapper to make them work with prescient.el and related packages.

So I assume any such metadata would have to remain optional from the perspective of selectrum and prescient.

From what I understand the global variable minibuffer-completion-table is set by Selectrum. But I don't know much more here, I am not familiar with the prescient internals. And also not an expert on selectrum internals. I would have to dig around. Either @raxod502 or @clemera can  probablyhelp.

From what I understand the global variable minibuffer-completion-table is set by Selectrum. But I don't know much more here, I am not familiar with the prescient internals. And also not an expert on selectrum internals. I would have to dig around. Either @raxod502 or @clemera can  probablyhelp.

Ah, I missed that it was global.  That could make things a lot easier.  But then I wonder why selectrum is passing it around between functions.  Yeah, will probably need advice from a selectrum / prescient guru here ;-)

Ah, I missed that it was global.  That could make things a lot easier.  But then I wonder why selectrum is passing it around between functions.  Yeah, will probably need advice from a selectrum / prescient guru here ;-)

So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?

It is already bound dynamically, we use the somewhat irritating behaviour of cl-defun which binds its arguments dynamically by default, you can check the macro expansion if you don't believe me ;)

But then I wonder why selectrum is passing it around between functions.

As mentioned above we pass the keyword arg to set the dynamic variable.

So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?

It is already bound dynamically, we use the somewhat irritating behaviour of cl-defun which binds its arguments dynamically by default, you can check the macro expansion if you don't believe me ;)

But then I wonder why selectrum is passing it around between functions.

As mentioned above we pass the keyword arg to set the dynamic variable.

@clemera commented on January 10, 2021 7:52 PM:

So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?

It is already bound dynamically, we use the somewhat irritating behaviour of cl-defun which binds its arguments dynamically by default, you can check the macro expansion if you don't believe me ;)

Ohhhhh I see! ...  Wait, for which arguments is the binding different to defun in this respect?  Maybe just for the &key / &aux arguments (which don't exist in defun), but not for the normal / &optional / &rest arguments?  I'm not finding any explicit info on this in the cl info pages.  Or maybe that depends on what lexical-binding is set to?

@clemera commented on January 10, 2021 7:52 PM:

So to make it available further down the call stack, we'd presumably need to pass it all the way down as an extra argument, or perhaps provide it via a dynamically bound variable?

It is already bound dynamically, we use the somewhat irritating behaviour of cl-defun which binds its arguments dynamically by default, you can check the macro expansion if you don't believe me ;)

Ohhhhh I see! ...  Wait, for which arguments is the binding different to defun in this respect?  Maybe just for the &key / &aux arguments (which don't exist in defun), but not for the normal / &optional / &rest arguments?  I'm not finding any explicit info on this in the cl info pages.  Or maybe that depends on what lexical-binding is set to?

When you expand the macro you can see that it let binds the &key and &aux arguments. Maybe we should report that when the docs don't mention it.

When you expand the macro you can see that it let binds the &key and &aux arguments. Maybe we should report that when the docs don't mention it.

@aspiers

So I assume any such metadata would have to remain optional from the perspective of selectrum and prescient.

I think allowing selectrum customizations based on metadata would be nice, this was also discussed here https://github.com/raxod502/selectrum/issues/265. Using metadata avoids the problems of this-command as the table specifies this information for the current session. Emacs 28 will also add current-minibuffer-command which can be used instead of this-command and this would be slightly more reliable for cases where a command invokes multiple minibuffer sessions per call but it is still derived from this-command.

@aspiers

So I assume any such metadata would have to remain optional from the perspective of selectrum and prescient.

I think allowing selectrum customizations based on metadata would be nice, this was also discussed here https://github.com/raxod502/selectrum/issues/265. Using metadata avoids the problems of this-command as the table specifies this information for the current session. Emacs 28 will also add current-minibuffer-command which can be used instead of this-command and this would be slightly more reliable for cases where a command invokes multiple minibuffer sessions per call but it is still derived from this-command.

Would we need to pass the context as an extra argument, or perhaps provide it via a dynamically bound variable?

So it sounds like @clemera and @minad covered this, but for completeness: I would think that the feature on the prescient.el side would not include any explicit support for a context argument. It would simply allow for prescient-filter-method to be a function, which would be called with no arguments. That function, provided by the user, could look at this-command, or current-minibuffer-command, or minibuffer-completion-table, or some combination of the above.
If things accessible in the dynamic scope are not enough to satisfy reasonable use cases, then in selectrum-prescient we could consider dynamically binding a variable to the value of the collection, which would then allow the prescient-filter-method function to look at that as well.
Does this seem reasonable?

Would we need to pass the context as an extra argument, or perhaps provide it via a dynamically bound variable?

So it sounds like @clemera and @minad covered this, but for completeness: I would think that the feature on the prescient.el side would not include any explicit support for a context argument. It would simply allow for prescient-filter-method to be a function, which would be called with no arguments. That function, provided by the user, could look at this-command, or current-minibuffer-command, or minibuffer-completion-table, or some combination of the above.
If things accessible in the dynamic scope are not enough to satisfy reasonable use cases, then in selectrum-prescient we could consider dynamically binding a variable to the value of the collection, which would then allow the prescient-filter-method function to look at that as well.
Does this seem reasonable?

Yes it does, very much so.  My previous struggles to see a way forward were entirely due to me missing the fact that minibuffer-completion-table is global and dynamically bound.  (Well, I was also ignorant of current-minibuffer-command coming in emacs 28, which is more good news.)  Everything in your comment makes perfect sense now, and it sounds simple enough that I could probably code the solution myself unless someone beats me to it.  Thanks all for your time so far!

Yes it does, very much so.  My previous struggles to see a way forward were entirely due to me missing the fact that minibuffer-completion-table is global and dynamically bound.  (Well, I was also ignorant of current-minibuffer-command coming in emacs 28, which is more good news.)  Everything in your comment makes perfect sense now, and it sounds simple enough that I could probably code the solution myself unless someone beats me to it.  Thanks all for your time so far!


Adds twitter link to author bio

We don't have a twitter link for authors anywhere.
As suggested by @lauraesteves, this adds a twitter link to the author's name in the bio below each post

:+1: although there is a PR description missing.

@gabrielpoca sorry for missing the description. I opened this up in a hurry before going to the friday talks :panda_face:
I already added one


feature/Enemies

enemy service

spawn multiple enemies

gameplay service

common enemy properties

Unique enemy functionality

movement functionality

Enemy spawning

thunder-snake enemy


Squiz.CSS.SemicolonSpacing.NotAtEnd false positive on classes with numbers

Describe the bug
ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
This is caused by any class containing a number
--bs-gray-100 or --bs-border-radius-2xl
Code sample
:root,
[data-bs-theme=dark] {
    --bs-gray-100: #F8F9FA;
    --bs-gray-200: #E9ECEF;
    --bs-gray-300: #DEE2E6;
    --bs-gray-400: #CED4DA;
    --bs-gray-500: #ADB5BD;
    --bs-gray-600: #6C757D;
    --bs-gray-700: #495057;
    --bs-gray-800: #343A40;
    --bs-gray-900: #212529;
    --bs-border-radius-xxl: 2rem;
    --bs-border-radius-2xl: var(--bs-border-radius-xxl);
}

Custom ruleset
<?xml version="1.0"?>
<ruleset name="Testing Bug">
    <rule ref="Squiz">
</ruleset>

To reproduce
Steps to reproduce the behavior:

Create a css file called test.css with the code sample above...
Run phpcs test.css ...
See error message displayed

  3 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  4 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  5 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  6 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  7 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  8 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  9 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  10 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
  11 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)
 13 | ERROR | Style definitions must end with a semicolon (Squiz.CSS.SemicolonSpacing.NotAtEnd)

Expected behavior
A clear and concise description of what you expected to happen.
Versions (please complete the following information)

.

Operating System
Docker php:8.3-fpm (official)

PHP version
8.3

PHP_CodeSniffer version
3.10.1

Standard
Squiz

Install type
composer (local)

Additional context
Add any other context about the problem here.
Please confirm

[X] I have searched the issue list and am not opening a duplicate issue.
[X] I have read the Contribution Guidelines and this is not a support question.
[X] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[X] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

@abarker-gravity Thanks for reporting this. CSS support, including all CSS sniffs, is deprecated and will be removed in PHPCS 4.0, so this is unlikely to get fixed. There are other, CSS specific, code styling tools available nowadays. I recommend you use those.
If a small fix for this issue could/would be submitted, I might accept it, but extensive changes to support this in the CSS Tokenizer will not be accepted anymore.


Add time trend graph showing all practices within a CCG for each measure

When clicking through to view all practices within a ccg (e.g. https://openprescribing.net/ccg/07M/silver/ or https://openprescribing.net/ccg/07M/ace/) user would like to see all practices on one graph.
Use Case:
As Head of Medicines Optimisation, I would like to see a graph comparing all practices in my CCG so I can easily identify which practices to target
User was aware they can construct their own query in analyse to do this, but thinks it would be a useful addition to the practice comparison page. They agreed @alexwalkercebm's aster plots will help with this, but would still like to see the time trend. Might be something to test once we have decided how we will be presenting the new plots.

The aster plots were mocked up (somewhat shoddily) using powerBI, but there's a d3 library http://bl.ocks.org/bbest/2de0e25d4840c68f2db1 that looks like it would do it better.

I haven't seen the aster plots, but the first visualisation I would think of for this purpose is a heat map:

The main difficulty in comparing the values of a particular measure for all practices in an CCG over time is the number of values. In this example (prescribing of high-cost ACE inhibitors in NHS Barnet), there are something like 5,694 values for each measure (73 practices, and 6.5 years = 78 monthly measurements for each), though some of these are missing.
If superimposed on a single line-graph, the result is a mess of overlapping lines.

If separated out into one plot per practice (with the same y-axis scale to enable direct comparison), the plots take up too much space to be simultaneously presented. If the y-axis heights are reduced until they all fit onto one screen, then changes become difficult to see.
One solution is to encode the values as color rather than vertical position, so that each practice is presented as a row in a heat-map. This enormously increases the number of values that can be simultaneously presented. The difficulty of reading off precise values can be partly addressed by interactivity (e.g. a tooltip that displays the value of the cell being moused over).

Though if the use case is really just to "easily identify which practices to target", not simultaneously trying to show a time trend makes this much easier to do clearly - just plot the most recent values in a bar chart (or Clevalnd-style dotplot):

That heat map is fab. I'd love to see how it lands with users tho we're short on coder time for new stuff.
BUT we're about to launch some "labs" pages: each CCG and practice will have one, and it's going to be a list of links to pages, each with a new more experimental analysis or data representation, and things that work well maybe get shifted up to main site (tho not for some of our new very technical features!).
James, if we made you a page, API access, list of resources etc, would you be up for owning a corner of OP, and implementing your heat maps on a labs page? We could promote, blog, link etc. Also, let us know if you'd like to come for a lunchtime on a Tuesday team day (fortnightly).
Cheers!

That's an interesting suggestion. It's probably easiest to discuss in person - when is your next team day?


Add hamburger menu to index page

Hi! Is there a way to add the hamburger menu to the index page as well? It would help navigating the workspace. Or I can make a PR if you point me to the template files, assuming this is a minor change.

Sure it is possible!
Index page is here packages/likec4/app/src/routes/-index-page.tsx
(wrapped by tanstack router)
To develop locally check this.


Make web/db based configuration work for worker

Make web based configuration work for worker, too. Now only www-host sees the configuration values stored in DB in a dual container deployment

Closed by #193


Add more helpful output for CHECK_EQ, CHECK_NE etc. Macros

Currently, when using a Macro like this:
CHECK_EQ(50.3321, sqrt(2533.310224));

easyloggingpp will output the following message:
CHECK_EQ(50.3321, sqrt(2533.310224));

This doesn't give any value over just using CHECK(50.3321 == sqrt(2533.310224) directly.
It would be great to actually see the value that is wrong. This is the output that googletest gives when using EXPECT_EQ(50.3321, sqrt(2533.310224)):
..\user_sqrt.cpp(6862): error: Value of: sqrt (2533.310224)
  Actual: 50.332
Expected: 50.3321

I think this is much more useful. Also in a case like this:
CHECK_EQ(functionWithStatusReturnValue(), STATUS_NO_ERROR);

I would like to know what the error code was that is returned when it fails. Otherwise I have to always do it manually:
int status = functionWithStatusReturnValue();
CHECK_EQ(status, STATUS_NO_ERROR) << "Error! Is: " << status << ", but should be " << STATUS_NO_ERROR;

which is quite cumbersome.
(The same holds for CHECK_NE, CHECK_STREQ etc... just doing whatever google test does is probably fine).

It returns error code 1 because the message itself is FATAL log

I'm not talking about the application, but about the error code of "functionWithStatusReturnValue". Any value can be returned there...

I agree with rggjan, very difficult at times to understand what the error is.


I want to use seata in production, please ask the transaction table undo_log, how can I configure the data source?

生产上想使用seata做分布式事务，想问一下demo中的undo_log这张表如何做单独的数据源的配置

I suggest you look at the principle of seata

The undo_log table must be in the same database as the business data table because the snapshot data is done in the same local transaction as the business data.

The undo_log table must be in the same database as the business data table because the snapshot data is done in the same local transaction as the business data.

What if two things operate under different instances?

The undo_log table must be in the same database as the business data table because the snapshot data is done in the same local transaction as the business data.

What if two things operate under different instances?

Do you mean the business is done with different DB instance?

The undo_log table must be in the same database as the business data table because the snapshot data is done in the same local transaction as the business data.

What if two things operate under different instances?

Do you mean the business is done with different DB instance?

yes ,Because every microservice has its own instance or a different library

The undo_log table must be in the same database as the business data table because the snapshot data is done in the same local transaction as the business data.

What if two things operate under different instances?

Do you mean the business is done with different DB instance?

yes ,Because every microservice has its own instance or a different library

That's what Seata does,Seata treats it as a global transaction.
Please take a look at https://github.com/seata/seata/wiki/Quick-Start


Need advice/help disabling coloring text based on diagnostic info

Issue/Question/Enhancement
Something that has been irking me is how a diagnostic warn/error will color the text with the type (red for err, yellow for warn, etc). I don't particularly like this and only want the undercurls. I noticed setting undercurl to true in the options does add the undercurls, but it does not turn off this text highlighting, here's an example:

Although it is somewhat of a false positive warning, the matter at hand is I just don't want capabilities (on the left) to be yellow in color, I want it simply to have a yellow undercurl. Let me know how to fix this, thanks!

What's your LSP config which covers the styling? The native_lsp.lua file contains all LSP related highlight groups so you could override those

I'm not sure if this is an opinionated choice on your end or a bug - if the former I would appreciate advice on how to make it so diagnostics are only undercurls :)
Lsp config regarding diagnostics:
local M = {}

M.signs = { Error = " ", Warn = " ", Hint = " ", Info = " " }

function M.setup()
	-- Automatically update diagnostics
	vim.diagnostic.config({
		underline = true,
		update_in_insert = false,
		virtual_text = { spacing = 4, prefix = "●" },
		severity_sort = true,
	})

	vim.lsp.handlers["workspace/diagnostic/refresh"] = function(_, _, ctx)
		local ns = vim.lsp.diagnostic.get_namespace(ctx.client_id)
		pcall(vim.diagnostic.reset, ns)
		return true
	end

	-- vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with(vim.lsp.diagnostic.on_publish_diagnostics, {
	-- 	underline = true,
	-- })

	for type, icon in pairs(M.signs) do
		local hl = "DiagnosticSign" .. type
		vim.fn.sign_define(hl, { text = icon, texthl = hl, numhl = "" })
	end
end

return M

Have you played with overriding the highlights from native_lsp? It implements the highlights from :h diagnostic, here.
That should be the only way to do it. Sorry I'm not too au fait with the lsp ui beyond the defaults.

Oh gotcha, using a different theme (in my case tokyo night) only shows undercurls for diagnostic info and I haven't changed my config. So I presumed it was an opinionated theme choice. I'll keep digging...

Yeah just compare what Tokyo Night is doing with the LSP highlights and apply them in your config 👍🏼 .

Ahhhh. So it looks like Tokyo Night uses sp to highlight the LSP underline highlight groups...
For you to achieve the same:
highlights = {
  DiagnosticUnderlineError = { sp = "{red}", style = "undercurl" },
  DiagnosticUnderlineWarn = { sp = "{yellow}", style = "undercurl" },
  DiagnosticUnderlineInfo = { sp = "{blue}", style = "undercurl" },
  DiagnosticUnderlineHint = { sp = "{cyan}", style = "undercurl" },
}


Few more fixes

Handle strings that contain quotes
Handle empty order operations (order by column)
Update README with instructions around template sequence number

Project moved to hound


fix logging and avoid replace for textile repo

Trying to make hubd have working saving logs also to a file, went into a deep rabbit hole.
hubd uses an util function on go-threads to setup logging. This SetupLogging function used env vars to configure the file path output. At some point when we updated go-log from v1.0.0/v1.0.1 to v1.0.4, and then something bad happened.
After<EMAIL_ADDRESS>there is a commit that from v1.0.2 and forward makes the GOLOG_FILE style of configuring the output file log break the way we are using it.
In that change, they use go-log/v2 as the underlying logging library, which is OK. But go-log/v2 only recognizes GOLOG_FILE at init() time. The underlying "old" loggingv1.SetupLogging() doesn't re-setup things to take this into consideration. So changing the env var after program bootstrap (after init() calls), doesn't have the intended effect.
In short, I fixed our setup function to call again the same function that gets called in init() but with explicit args. The previous API of go-log which used env vars backfired.
If the above is confusing, don't worry... it is.
Apart from that, I updated go-libp2p-peerstore to v0.2.6. This new tag already includes a commit I made to fix a race condition that we solved with a replace in textile go.mod. So, whenever we update textile to a new go-threads tag that includes this PR, we could avoid that replace.

The go-libp2p-peerstore update appeared for free in the rebase.


Fix some minor errors in documentation

HI folks, miss you all! I finally decided I really needed my own personal instance of ASHIRT, and I found some minor errors in the documentation. (This is R, in case you don't recognize the username)
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Thanks R!
🙌


Clicking the stats bar in the explore header should open the explore view picker

Right now, the tab bar in the explore header is not clickable. both the header dark bar and the button in the bottom right should open the explore view picker.

Already done, closing issue.


Motivate extensions to upgrade to MarkdownString

We will disable command-links in the (deprecated) MarkedString and extension should use the new MarkdownString for command-links.
Background
When using markdown-formatted content, VS Code supports "links" that invoke a command, like so: [Hello](command:myExt.myCommand).  This is a powerful feature but has a security concern: With a carefully crafted document and an extension that creates a markdown-string from that content users can be tricked into clicking on what appears to be a link but actually executed a command. Consider the following sample:

I happen to know that you use an extension that includes potential dangers commands, e.g. running arbitrary commands in a shell
I make you use my library file that contains a jsdoc-comment invoking such a command via a command-link
While coding you get a hover saying "click here for more info" which in reality runs a command

To tackle this, we ask extensions to identify their markdown contents as trusted or not. E.g. TypeScript will say it don't trust markdown contents because it doesn't generate it, it just forwards. Other extensions, esp. those that generate command-links on purpose will mark their contents as trusted. To support that we have introduced a new type, MarkdownString. The MarkdownString can be used wherever the MarkedString can be used and when constructing it, you can say if you trust the contents, e.g.
// trusted
const md = new MarkdownString('[My Cool Feature](command:myTrustedContents)')
md.isTrusted = true;

// not trusted
new MarkdownString(forgeinContentsLikeJsDoc)

Extensions that are known to use command-links and that need updating during the September timeframe:

[ ] solargraph
[ ] vscode-translate-hover
[ ] quokka-vscode
[ ] kite
[ ] elastic
[ ] godot-tools

// trusted
new MarkdownString('[My Cool Feature](command:myTrustedContents)', true)

The MarkdownString constructor only has one parameter. Should it be:
// trusted
const md = new MarkdownString('[My Cool Feature](command:myTrustedContents)');
md.isTrusted = true;

?

TypeScript does not recognize MarkdownString, either as a stand-alone constant or inside the vscode namespace.
import * as vscode from 'vscode';
new MarkdownString // <- unrecognized
new vscode.MarkdownString // <- unrecognized

I'm using vscode module 1.1.5 and engine 1.5.0. I fetched vscode.d.ts from https://raw.githubusercontent.com/Microsoft/vscode/4fc690be310dd02e0ab6529c0b9bf348a8b26a19/src/vs/vscode.d.ts. Is there something I'm missing?

Good catch @ArtemGovorov - me thinking about new ideas that aren't implemented yet... Yeah, today we only have the property. I'll update the samples...

@castwide We will ship the 1.16 release today, then you can get the latest API by setting the engine-field in package.json to 1.16. Run npm i after that and our scripts will download the latest version of vscode.d.ts

MarkedString had a property language that was actually supremely handy and that I used quite a bit. MarkdownString no longer has that. Is that coming back by any chance? It wasn't harmful and it actually proved useful. Kinda 'tabula rasa' to just throw it out and have everyone code-bloat / wheel-reinvent their own workaround via markdown's triple-backtick syntax, when vscode used to handle it so smoothly before.

MarkedString had a property language that was actually supremely handy and that I used quite a bit. MarkdownString no longer has that.

It has it. The {language, value} part of MarkedString is nothing else than a triple back-tic and text. Like you have code blocks inside markdown, just more verbose. The string portion of both (MarkedString and Markdown) support this, like all the other markdown things (bullet list, links, inline code, italic, bold, etc...). The only reason the verbose-part exists is that in beginning we didn't support any markdown but stuff was just a string or a code block. Ever since we started to support more markdown the verbose variant as been obsolete.

I was looking for an example to replace the language-highlighted version, but found that VS Code's own extensions still use {language, value} (Example).
Are you saying this would be replace with something like new MarkdownString('```' + language + ' ' + value + '```') (or the template string equivalent)?

Are you saying this would be replaced with something like new MarkdownString('' + language + ' ' + value + '') (or the template string equivalent)?

Almost, newline character after language and the value are missing

Hi all, Kite's maintainer here, I didn't noticed that issue until recently and I just wanted to let you know that our next release will include the change to use MarkdownString instead of MarkedString.

@jrieken Thanks for clarifying. You're right, it is a bit verbose. What do you think about adding a new method to MarkdownString called something like appendLanguageBlock?

Yeah, we can do that. Actually, internally we have it already and I just didn't know what all to expose in the API...

Sounds great! Actually, after thinking about it a bit more, perhaps it should just be appendCodeBlock which optionally takes a language.

done

@jrieken Wow, that was fast! A bit nit picky, but since "code block" is generally written as two words, shouldn't the b be upper case?

Yeah, did that on purpose because it somehow felt better...

I think this issue can now be closed - LMK if that was the wrong call.
Sean
VS Code


Format selection for saving quantized weights (bitsandbyres.nf4, SpQR etc)

Feature request
Hi!
I am working on code to save models in quantized formats like nf4 from bitsandbytes and SpQR (see my PR in transformers). . Both these formats require storing multiple tensors per weight and also some hyperparameters.
Could the Safetensors team suggest preferred way to save all this stuff in ST format? The choices that I see are:
for tensor types:
- save weights, scales, zeros etc as separate tensors using some nested naming scheme
- pack into some king of structrue and serialize as one big tensor?  https://gist.github.com/poedator/81c3564ec548ef2992282d59447cacff
for hyperparameters:
- save as metadata components
- serialize and save as tensors
- pack hyperparameters into (protobuf? MsgPack? Json?) and save as single tensor
- pack tensors + hyperparameters into one big structure and save as single tensor.
I see that similar matters are already raised here for other quantisation methods, including #256. It would be nice to have some universal way to store quantized weights.
Also it would be nice for ST to support not just tensors, but all other formats supported by serde
Motivation
consistent representation of saved quantized weights
Your contribution
ready to make a PR once there is guidance from the maintainers
@Narsil  ?

I think #389 is related.


AI Inference MarketPlace(Maha AI Hub)

Description:
We are working on building the world's first decentralized AI marketplace within Telegram mini apps. This platform empowers users and developers to seamlessly access, trade, and deploy AI models in a secure, transparent, and community-driven environment.
Project Overview:
Our project aims to democratize AI technology by integrating a marketplace directly within Telegram, a widely used messaging platform. The marketplace leverages blockchain technology to ensure security, transparency, and decentralization, allowing anyone to harness the power of AI without specialized knowledge.
Key Features:
Decentralized Marketplace: Facilitates secure, transparent, and intermediary-free AI model trading.
Seamless Telegram Integration: Provides a user-friendly interface within Telegram mini apps for AI model access.
Blockchain Security: Guarantees the integrity of transactions through smart contracts and immutable records.
Community-Driven Governance: Enables users to participate in platform governance via decentralized voting mechanisms.
Links
Github Org:-https://github.com/AI-Inference-Org
Project Pitch:-https://www.canva.com/design/DAGOLMGrdlc/A7M7lwJTn_bo0VIbcVWl3g/edit?utm_content=DAGOLMGrdlc&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton
Project Demo Video:-https://youtu.be/ayiI8rdaf8M

I recommend you to read the general submission guideline and follow it end to end, there are some fields that are not mentioned in your submission issue - https://github.com/spheronFdn/sos-ai-bounty?tab=readme-ov-file#-general-submission-guidelines

Also, I can see you don't have a trail of commitments in the GitHub. If you don;t have a trail, your submission may be rejected straightforwardly. Because we want to ensure the devs who are working on it & ensuring all the guidelines are eligible for the price pool.

Also, I can see you don't have a trail of commitments in the GitHub. If you don;t have a trail, your submission may be rejected straightforwardly. Because we want to ensure the devs who are working on it & ensuring all the guidelines are eligible for the price pool.

I have the entire commit history you can check out or reach harpreet for confirmation the project was approved by him in the meet-up

@rekpero , I'm also working on the AI Marketplace bounty. Could you clarify whether the full $5,000 bounty will be awarded to a single winner, or will it be divided among the top projects if there are multiple outstanding submissions for the AI Marketplace project?

Because we want to ensure the devs who are working on it & ensuring all the guidelines are eligible for the price pool.

Just checkout the details i have made the changes as per mentioned

@rekpero , I'm also working on the AI Marketplace bounty. Could you clarify whether the full $5,000 bounty will be awarded to a single winner, or will it be divided among the top projects if there are multiple outstanding submissions for the AI Marketplace project?

Bounties are the pools from which devs can claim up to that amount given the novelty & design of the solution

Also, I can see you don't have a trail of commitments in the GitHub. If you don;t have a trail, your submission may be rejected straightforwardly. Because we want to ensure the devs who are working on it & ensuring all the guidelines are eligible for the price pool.

I have the entire commit history you can check out or reach harpreet for confirmation the project was approved by him in the meet-up

This is not accepted if the commits are not made on the single repo. https://github.com/AI-Inference-Org
The repo submitted has no trace of commits & also not able to validate how long you have been working on this one. Can you please provide a detailed overview around the same.

https://github.com/AI-Inference-Org - I can still see not proper readme & licenses are added. Please take your time & rectify everything. If we don't find the trace, this submission will be disqualified for the submissions.


Question: How to ensure devices use the main AP (Mesh level 0) while IoT devices use the esp_wifi_repeaters (Mesh level >0) ?

Hello,
My question is (in a automesh setup!) :

I'd like my home AP to continue to be the only AP my devices will automatically connect to. Phones, PC's, etc....require high throughputs that the ESP's cannot deal with.
I'd like to use my (currently) 2 x ESP esp_wifi_repeaters to only connect to my IoT devices in the garden. They require low throughput.
The original goal was to add those 2x ESP to extend the wifi range far away in the garden. Not to serve my internal "clients" (phones, PC's).

The issue I imagine is that (for example) my phone will connect to an ESP! And get an unusable throughput.
Tx for your clarification :-)

Don't use Automesh, but configure different SSIDs for the AP-side of the repeaters. So IoT-devices will connect to this different AP and al you normal devices don't even know about this.

Tx for the answer. This is indeed what I did.
A side effect seems to be that all ESP's are (of course) using the same channel and somewhat decrease the main AP performance.
PS: tx a lot! It works like a charm


Login returns "credentials rejected"

Describe the bug
I am trying to login with the example provided in the README but the response is always 'credentials rejected'.
Debugging this futher I can see that the response of the second request that is being made is html with title of "Access Denied".
Has someone encounter this and fixed it?
Steps To Reproduce
Identify the steps to reproduce the behavior:

Download package
Create index.js file with the example of login from README
Type in username/password and try to log in
See error

Expected behavior
Token retrieved from tesla
Library version
4.10.0

This is "by design" in that Tesla has broken 3rd party authentication by adding a reCaptcha requirement.

This is "by design" in that Tesla has broken 3rd party authentication by adding a reCaptcha requirement. I've considered adding 2captcha support as a way to work-around it but still have some reservations with that plan.

Does this mean that this library is now obsolete? Because not being able to get an auth token, basically means trying to implement this API is pointless no? How do we go about it?
I am working on a service that gives Teslas for rental (pay as you go), and I need to wake the car up when a customer pays for the car. Seems like it is not possible via a CAN adapter, and needs to go through teslas API. Found this in Node, and I'm running into the same "credentials rejected" issue.
Please advise

The library is not currently functional given the changes that Tesla made to authentication. I would not call it obsolete in the sense that if we are able to find a workaround it will work again. But it can't be used in its current form.

The library is not currently functional given the changes that Tesla made to authentication. I would not call it obsolete in the sense that if we are able to find a workaround it will work again. But it can't be used in its current form.

I've made my own solution afterall, via puppeteer (headless chrome tab), since the auth page doesn't seem to like you if there's no javascript support in the page, given they also have an invisible captcha.
I needed it to be purely CLI so .. any manual web-views wouldn't work for me, but, puppeteer (or any other headless browser tool) will work just fine.
I could make a PR, but I guess since this is supposed to be "dependency lean" and puppeteer is not a small dependency, nor will it work with serverless functions, or services like digital ocean's app platform / aws lambda .. I guess my solution is kind of particular and will only work as long as you have your own server.
Let me know anyway.


Refresh schema documentation

You can test by running cd docs; ./build_docs.sh and opening docs/_build/index.html in a browser.

PS I haven't updated any of the validation section; just the schema overview section.

Gentle ping...


No lock

see: https://gamedev.amazon.com/forums/articles/70528/gamelift-service-processauxproxy-terminates-health.html

Well played, doctor. Just know that some people can't sleep at night because of code you wrote few years ago.

https://github.com/Quobject/SocketIoClientDotNet#nb


removing pipewire killed my os

If you Completed all troubleshoot options, check below

[ x]  Did you Follow all installation instructions carefully from here?
[x ]  Did you check All troubleshoot options from here?

Describe the bug
properly installed pipe wire.
then decided to remove it with
sudo apt purge gstreamer1.0-pipewire libpipewire-0.3-{0,dev,modules} libspa-0.2-{bluetooth,dev,jack,modules} pipewire{,-{audio-client-libraries,pulse,media-session,bin,locales,tests}}
now system does not boot
I tried to repair by booting to recovery environment, enabling networking and typing
sudo apt-get install --fix-broken
did not work
sudo apt install gstreamer1.0-pipewire libpipewire-0.3-{0,dev,modules} libspa-0.2-{bluetooth,dev,jack,modules} pipewire{,-{audio-client-libraries,pulse,media-session,bin,locales,tests}}
did not work
I tried  following these instructions
https://ostechnix.com/how-to-fix-broken-ubuntu-os-without-reinstalling-it/
did not work
I dropped to recovery environment and updated grub
did not work.
Expected behavior
please help?
Desktop (please complete the following information):
ubuntu 21.04
Journal log and status of related services
Add any other context about the problem here.

figured it out
sudo apt -y install ubuntu-desktop
I guess somehow gnome got connfused

Any feedback why did you remove? any suggestions ? @bwanaaa

@bwanaaa  Actually the issue was, PipeWire 0.3.24 shipped with ubuntu 21.04 by default, Therefore no way to completely remove it without breaking other core package because Other core packages may have dependencies on PipeWire. And you checked all boxes blindly without actually checking the links before creating the issue here. On the Troubleshooting page, There I clearly mentioned how to uninstall/downgrade PipeWire on the above situation.  PLEASE INSTALL PIPEWIRE STOCK  VERSION, LIKE AS IT WAS". otherwise this issue impact on the PPA. I'm giving pastebin link here, that proves the whole comment. hirsute_ubuntu20.04_PipeWire_install_log.txt


[Event Request] table 7004 "Sales Line Discount" OnValidateUnitOfMeasureCodeOnBeforeCheckType

Can you add OnValidateUnitOfMeasureCodeOnBeforeCheckType to the "Sales Line Discount" table?
        field(5400; "Unit of Measure Code"; Code[10])
        {
            Caption = 'Unit of Measure Code';
            TableRelation = IF (Type = CONST(Item)) "Item Unit of Measure".Code WHERE("Item No." = FIELD(Code));

            trigger OnValidate()
            // >>>>>>>>>>>>>>>>
            var
                IsHandled: Boolean;
            // <<<<<<<<<<<<<<<<
            begin
                // >>>>>>>>>>>>>>>>
                IsHandled := false;
                OnValidateUnitOfMeasureCodeOnBeforeCheckType(Rec, IsHandled);
                if not IsHandled then
                // <<<<<<<<<<<<<<<<
                TestField(Type, Type::Item);
            end;
        }

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


send new user to welcome page and refactor smaller functions out of AuthLogin

Billy,
Want to check the test's expected results to see if they are what you would want?


Add py.typed marker

Hey Ilya, thanks for logging this issue. I haven't given much attention to mypy etc thus far. You're welcome to create a PR.


cmd/dist: typo in comment

What version of Go are you using (go version)?

$ go version
go version go1.16 linux/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/vagrant/go/bin"
GOCACHE="/home/vagrant/.cache/go-build"
GOENV="/home/vagrant/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/vagrant/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/vagrant/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2823638017=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Read the source code at https://github.com/golang/go/blob/master/src/cmd/dist/test.go#L784
I think syscall.SysProcAttr, not syscall.SysProcAttri.
Sorry if I'm wrong.

What did you expect to see?
// because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux.

What did you see instead?
// because syscall.SysProcAttr struct used in misc/cgo/testsanitizers is only built on linux.

Hey there, It's not necessary to open an issue for a documentation fix if you are going to send a patch anyhow. It's OK to just send the patch without an issue. Thanks.


Metatable support

The VM should support metatables and -methods. For most simple metamethods, this is just an implicit call, and the existing call infrastructure should handle everything.
Non-trivial metamethods to consider:

__concat technically supports concatenating any number of values, although this isn't currently used by the emitter. Since any value except strings and numbers could define __concat, a single opcode can invoke multiple metamethods.
__tostring is only used by Lua when calling the tostring method or when using the object as an error object

__gc and __mode are the hardest metamethods because the current GC interface supports neither, and adding support is nontrivial. But since there isn't any working GC anyways, these metamethods can only be implemented after one is in place.

__concat now behaves like other binary operators (for simplicity)


Update jupyter_notebook_config.py

Adding the capability to set jupyter port via the PORT environment variable.
This is especially useful if this Docker container runs on clusters managers like Mesos, DCOS , etc.

Can one of the admins verify this patch?

LGTM

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please


EC-237 Add validate input and use policy config

This commit addresses EC-237 & EC-57 which marks ec validate definition as deprecated, adds ec validate input and allows ec validate input to utilize a policy config file in a similar manner as the ec validate image command.

Run UPDATE_SNAPS=true make acceptance to update the snapshots for the acceptance tests.

I think you need to rebase from main to get rid of the linting errors.

UPDATE_SNAPS=true make acceptance

Thanks, but this is failing locally. I had rebased before pushing...but I'll check it again.

/retest

/retest


Problem with mapping of Current Owner

I expected to see:
Amon Carter Museum of American Art
but instead I saw:
blank
The current query was:
PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?owner_name ?owner_class
WHERE {
<http://data.americanartcollaborative.org/acm/object/10_1967_474> a crm:E22_Man-Made_Object ;
   crm:P52_has_current_owner ?owner_class .
OPTIONAL {
  ?owner_class a crm:E40_Legal_Body ;
    rdfs:label ?owner_name .
}

}

Hi David (@workergnome)! This issue prompted me to test all the partners'  crm:P52_has_current_owner value, and I will email you and Duane separately about a couple non-urgent questions.
The mapping is present for crm:P52_has_current_owner + E40:LegalBody but no value exists. I know that this value is NOT in the partners' data sets so was it a default value that gets coded into the data?

This has been moved to the correct repo.


feat: added functionality to customize prompt

This PR adds support for customizing the prompt to allow for different prompt styles for different LLMs.
This is done with a liquid template (syntax docs here). This was chosen for execution speed and flexibility. Two new flags were added to support this - --history-template and --history-template-file. The first takes the template as a raw string on the CLI, and the second takes a path containing the template. This functionality defaults to the pre-existing prompt format.

Cargo test output:
   Compiling openai_trtllm v0.1.0 (C:\Users\pdyla\Documents\git\openai_trtllm)
    Finished test [unoptimized + debuginfo] target(s) in 1.59s
     Running unittests src\lib.rs (target\debug\deps\openai_trtllm-c99c9c8e1e7fb826.exe)

running 4 tests
test history::test::test_validations ... ok
test history::test::test_default_template ... ok
test history::test::test_template_file ... ok
test history::test::test_template_file_custom_roles ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src\main.rs (target\debug\deps\openai_trtllm-cdfd42e79d632617.exe)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests openai_trtllm

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Figured I'd add that here. I thought about adding actions for this, but didn't want to without maintainer approval. If you're fine with that, I can add a basic build/test pipeline as a part of this.

Cargo test output:
   Compiling openai_trtllm v0.1.0 (C:\Users\pdyla\Documents\git\openai_trtllm)
    Finished test [unoptimized + debuginfo] target(s) in 1.59s
     Running unittests src\lib.rs (target\debug\deps\openai_trtllm-c99c9c8e1e7fb826.exe)

running 4 tests
test history::test::test_validations ... ok
test history::test::test_default_template ... ok
test history::test::test_template_file ... ok
test history::test::test_template_file_custom_roles ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src\main.rs (target\debug\deps\openai_trtllm-cdfd42e79d632617.exe)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests openai_trtllm

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Figured I'd add that here. I thought about adding actions for this, but didn't want to without maintainer approval. If you're fine with that, I can add a basic build/test pipeline as a part of this.

It's just fine to help add an action for basic unit test here. Actually, I think it's time to create some CI pipeline for this project.

LGTM


Ordering inputFiles (all conflicts fixed)

Context: https://github.com/broccolijs/broccoli-concat/pull/96 has been around for quite some time and there's conflicts. Doesn't seem to be merged soon.
So I decided to branch out from latest master branch and copy the changes over. I also fixed some typos here and there.
Hope someone has time to take a look!

left a comment: https://github.com/broccolijs/broccoli-concat/pull/96#issuecomment-403878672, lets discuss there. But I'm down with exploring landing this soon.

mind doing a rebase, it looks like recent changes have introduced additional conflicts. With that, we can move forward.


Improve styling of Health Status PopupItem

Add space between two columns in Health Popup in ODF dashbord
Screenshot:

/lgtm


Add additional fields to 'lacework integration list' plus sorting option (e.g. -sort state|status|update|etc.)

Would like to be able to use cli to also see last integration update and user in list mode and be able to sort output by field

closing as integration list no longer exists


Preparation for CRAN Release

First release:

[x] usethis::use_cran_comments()
[x] Update (aspirational) install instructions in README
[x] Proofread Title: and Description:
[ ] Check that all exported functions have @return and @examples
[x] Check that Authors@R: includes a copyright holder (role 'cph')
[ ] Check licensing of included files
[x] usethis::use_revdep()
[ ] Reverse dependency checks revdepcheck::revdep_check(num_workers = 4)
[ ] Review https://github.com/DavisVaughan/extrachecks

Prepare for release:

[ ] git pull
[ ] devtools::build_readme()
[x] urlchecker::url_check()
[ ] devtools::check(remote = TRUE, manual = TRUE)
[ ] devtools::check_win_devel()
[ ] rhub::check_for_cran()
[ ] git push

Submit to CRAN:

[ ] usethis::use_version('patch')
[ ] devtools::submit_cran()
[ ] Approve email

Wait for CRAN...

[ ] Accepted :tada:
[ ] git push
[ ] usethis::use_github_release()
[ ] usethis::use_dev_version()
[ ] git push

Let me know if you need any help with this or have questions.
P.S. You dont need to run devtools::build_readme() anymore. Should be up-to-date due to the gh-action.

Let me know if you need any help with this or have questions.
P.S. You dont need to run devtools::build_readme() anymore. Should be up-to-date due to the gh-action.

Ohh, any help appreciated. I tried to fix a few things, but the MacOS R CMD check is still failing atm.
First I think we want version 0.0.2 to the main branch, but need to have the R checks working

Aren't all checks failing at the moment?
Okay, so the general roadmap would be fixing everything on dev (v0.0.2) first and then merging into master?

I lost a little bit track on what's still to do. Did you say you want to fix the remaining warnings about the documentation ?

Yes, the main outstanding things are all the documention warnings durings checks. I tried to fix some every now or then, but it is quite a lot...


Missing required field "description" in resourceType attribute

According to the O2ims Interface Specification document we are missing the field "description" as an attribute of the resourceType. See Table <IP_ADDRESS>.3-1: Attributes of the ResourceType in the O-RAN WG6 O2IMS INTERFACE document.
I just added the description field returning an empty value in order to pass the conformance tests.

/approve


Sidedrawer transition to not go under the AppBar, but either over it (slide on top) or pushing the main content (with the AppBar)

duplicated


[tool_crash] IndexError: RangeError (index): Index out of range: index should be less than 59174577: 59190334

Command
flutter --no-color --no-version-check precache

Steps to Reproduce

...
...
...

Logs
IndexError: RangeError (index): Index out of range: index should be less than 59174577: 59190334
#0      _Uint8ArrayView.[] (dart:typed_data-patch/typed_data_patch.dart:4194:7)
#1      InputStream.readUint32 (package:archive/src/util/input_stream.dart:242:22)
#2      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:49:34)
#3      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
#4      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
#5      _WindowsUtils.unzip (package:flutter_tools/src/base/os.dart:523:42)
#6      ArtifactUpdater._downloadArchive (package:flutter_tools/src/cache.dart:1113:18)
<asynchronous suspension>
#7      EngineCachedArtifact.updateInner (package:flutter_tools/src/cache.dart:910:7)
<asynchronous suspension>
#8      CachedArtifact.update (package:flutter_tools/src/cache.dart:812:5)
<asynchronous suspension>
#9      Cache.updateAll (package:flutter_tools/src/cache.dart:681:9)
<asynchronous suspension>
#10     PrecacheCommand.runCommand (package:flutter_tools/src/commands/precache.dart:174:7)
<asynchronous suspension>
#11     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1173:27)
<asynchronous suspension>
#12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#13     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)

[✓] Flutter (Channel master, 2.13.0-0.0.pre.196, on Microsoft Windows [Version 10.0.19043.928], locale en-IN)
    • Flutter version 2.13.0-0.0.pre.196 at D:\FlutterSDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2015143fbf (2 hours ago), 2022-03-22 05:55:11 -0400
    • Engine revision 9595bd00dc
    • Dart version 2.17.0 (build 2.17.0-225.0.dev)
    • DevTools version 2.11.4

[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at D:\AndroidSDK
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.928]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 99.0.4844.74
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 99.0.1150.46

[!] HTTP Host Availability
    ✗ HTTP host "https://maven.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'maven.google.com'
    ✗ HTTP host "https://pub.dev/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'pub.dev'
    ✗ HTTP host "https://cloud.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cloud.google.com'

! Doctor found issues in 3 categories.

Flutter Application Metadata
No pubspec in working directory.

Closing this as duplicate of https://github.com/flutter/flutter/issues/84276


⚠ Bofrost.be has degraded performance

In a9b1d75, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2540 ms

Resolved: Bofrost.be performance has improved in e1e7245.


Fixed bug in resource id parsing when null is passed as Id

Hi @anudeepsharma, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (ans). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;