Contact Form Optimization

Let's analyze the Contact Forms across all the repos on our sites and fix them so they do not allow spam.
https://github.com/TaoFruit
The above link has all our Repos.
You can find any form in here such as https://github.com/TaoFruit/focushive/blob/gh-pages/support.html
You can tell when it's the appropriate form because it will have the "action" address appear like this:
action="https://prod-01.eastus.logic.azure.com:......"
This means it is going over to our Azure Back-End Logic App

[ ] Add ReCaptcha v3 to each form
[ ] Add Sweet Alert v2 to each form
[ ] Check JS Validation on each form

we need Site_key for the configuration of reCaptcha which is "confidential" for the website

Site_Key: 6LcHIYcUAAAAAPnqH0iBwnDeFma0mWAMJKJHAoEO

Hi @kinshark, is it valid site_key id as I see an error on it

It is valid, but we only have it listed for certain domains. Let us know which domain you want to add to the key & we can update it. Perhaps that is the only issue.

Hi @kinshark, I believe we are working on the focusehive  "https://thefocushive.com/"

That site is already added into the list of approved sites.
Just double-checked this key. It's definitely the correct key, too.

Try it now - we just updated some settings over there

Not working, maybe I am running on over local server that's this problem is coming

I am creating the PR now just check on your side over the server

How I can invite you as a code reviewer on the dev azure

Send your PR on the appropriate Github Repo. Let's stay on this platform for now.

https://dev.azure.com/DeveloperDojo/Development/_git/focushive/pullrequest/8

We are not working on Azure DevOps for this.  Put your pull request inside the Repo on Github directly.

https://github.com/TaoFruit/focushive - this is probably the Repo you're working on. But as the instructions mention, you can choose any of a number of repos we have in this organization that all need their forms updated.

I get denied for the pushing my branch For the PR

You need to first Fork the Repo.
After forked, your repo will stay synced with the original more easily than a cloned Repo.
Then, you can submit Pull Requests back to the main.

Thanks, @kinshark thanks for guiding me. this is the PR link please check it https://github.com/TaoFruit/focushive/pull/2 thanks!

https://github.com/TaoFruit/focushive/pull/3

https://github.com/TaoFruit/focushive/pull/4


[README] Better explanation on how to start to develop SvelteKit

Hi
I wasted a bunch of time on how to start to develop SvelteKit, so I decided to write a better step-by-step guide.

What where the problems you had with the current guide? For me the PR seems not very different to what's already written down.

Hi🖐
If you know what to do, yeah there is no noticeable difference, but if don't what to do, there is a good difference. I tried to explain step by step and what to do and what not to do.
Once I used yarn and once npm but it didn't work. So you need to only use pnpm. You need to run both repo dev and the example app from the root of the repo. You don't need to install the dependencies for the example app. and...

I also think the previous was already well explained. If you follow the instructions there you shouldn't be hitting into issues you had mentioned.

Imho the difference is that the edited version doesn't require the user/dev to know about monorepos. The current version has some level of knowledge about them as a somewhat implicit requirement. Additionally it may be easier to follow complete sentences and distinct steps instead of the old version. At the end, I think it's an improvement.

Sry but actual version is better than Your PR.

I'm not sure about the ### Git hooks, how to use them part. I just added a title(and changed its description) to separate it from the steps.

Thanks for the suggestions. It seems like there's been a mixed reaction about some of these suggestions. I integrated some of these suggestions into the README in various ways. What I came up with ended up looking a bit different than this, so I ended up just doing it as a new commit and will close this one. Hope it's clearer now. Thanks!!


Consider adding 2.1 SMB client with "Secure transfer required" enabled on storage account as another potential source of connection issue.

In the common causes for "Cannot connect or mount an Azure file share", I think another possible reason is a SMB 2.1 client trying to connect to a share where the storage account has "Secure transfer required" enabled.  That's covered in the docs but I think can be easy to miss. See: https://docs.microsoft.com/en-us/azure/storage/files/storage-how-to-use-files-linux#prerequisites-for-mounting-an-azure-file-share-with-linux-and-the-cifs-utils-package:
"If secure transfer required is enabled for a storage account, Azure Files will only allow connections using SMB 3.0 with encryption"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d3c03c3-b99c-445a-026e-442dd40599a1
Version Independent ID: 0a6ff7fb-1702-b50b-50ab-8db7a1832647
Content: Troubleshoot Azure Files problems in Linux
Content Source: articles/storage/files/storage-troubleshoot-linux-file-connection-problems.md
Service: storage
GitHub Login: @jeffpatt24
Microsoft Alias: jeffpatt

I updated the Windows and Linux troubleshooting articles to mention the "secure transfer required" will block unsecured connections

#please-close

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


fix(ui): autofocus amount fields

Description:
Autofocus amount fields
Motivation and Context:
Fix #2046
How Has This Been Tested?
Ensure amount field autofocuses on channel form.
Types of changes:
Bug fix
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.02%) to 19.401% when pulling c930233651ae6223fe97a427722ef06163b8304b on mrfelton:fix/2046-autfocus-amount-field into 020e63999bdd5d542bcfa8115e9aaad253f6334b on LN-Zap:master.


text: can we suggest that the encrypted submissions download modal can be closed?

right now it never says when you can dismiss the modal. we should do that if we can, but maybe there's a reason we can't.

I don't think this needs to be clever in any way. Something like "If the download has completed, close this" would be enough.

I took a look at the component, and I think it should be OK for the user to close the modal once the download has completed (and even once it's started). The main thing that's unusual about the modal is that Frontend has limited information about the status of the download; however, the user should still be able to close the modal.
I'm happy to make that text change while I'm localizing that component so that it can get in before the component is translated. How about adding the second sentence below to the message that's shown in the modal?

Your data download should begin soon. Once it begins, you can close this pop-up. If you have been waiting and it has not started, please try again.

s/pop-up/box
otherwise that looks fine to me


Examples: Publish our WebGL examples

Now that we have text rendering in WebGL (thanks @jchavarri !), I'm thinking it makes sense to publish our WebGL examples to a website - either GH pages or using netlify or something. It'd be a really easy way for people to try things out without needing to set up to start.

Was just thinking this last night! If we get a logo & what not together we can just make an official website for this. Also, would be great if we could integrate the Reason compiler to have an interactive demo/tutorial there (not sure how feasible that is)

Yes, this would be great!
I love the idea of an interactive demo/tutorial. Seems totally doable, @thangngoc89 has done some incredible work on Sketch: https://github.com/Sketch-sh/sketch-sh that shows how to evaluate JSOO in the browser. He also has a great series of blog posts on his development: https://khoanguyen.me/
In addition, he pointed me to the JSOO examples: http://ocsigen.org/js_of_ocaml/3.1.0/manual/files/toplevel/index.html - great demonstration that it is feasible!
I could see this happening incrementally, in 3 stages:

Publish the JS-compiled WebGL apps standalone
Publish them in a way where we can have the source-code read-only next to the examples (for example, would be nice to have it set up so that, with #158 , when you switch examples - we switch to the correct source code)
Publish them in a way where they are editable (perhaps we pre-compile all of Revery in a way that we can integrate with the JSOO top-level, and then expose the individual example modules as something that we can compile in the browser)

But I think this would really get people interested in revery. Zero friction to try the examples and experiment with the API!

Ping me if you need my helps. all of those should be easy. but 3 would be scary because you won't have any protection against bad code

We have editable samples now at our playground: https://www.outrunlabs.com/revery/playground/ so this is all set 👍

@bryphe I think it would be nice to include a single sample outside of the playground somewhere to see how big/small an optimised revery app can be in the browser. I might have missed that on the site somewhere?

This is interesting! Got a link to a WebGL example?


Reduction of memory requirements to run benchmarks

Hi,
First of all, thank you for developing such a great tool for benchmarking models, that really helps during research.
I'm trying to run benchmarks for Mistral 7B float16 on RTX 4090 with 24GB of VRAM. However, I got CUDA out of memory for both current and previous 0.0.1 version. I tried to benchmark Falcon1B just to check whether everything is working fine, and that worked for me.
Is there a way to reduce memory requirements for benchmarking Mistral 7B model on 24GB GPU card? Theoretically, float16 7B model should require 14-16GB of VRAM, so I don't really understand what consumes rest of the GPU memory during benchmarking.
Just in case, I was using your original config file for Mistral7B, but seems like you were running it on A100 80GB.

Hi,
The theoretical requirement you calculated only count model weights (2 bytes per param * 7b param) but the activations take about the same amount of memory during inference. Try running this simple script:
import torch
from transformers import AutoModelForCausalLM

model = AutoModelForCausalLM.from_pretrained("mistralai/Mistral-7B-v0.1").cuda(1)

input_ids = torch.randint(0, 1000, (2, 128)).cuda(1)

with torch.inference_mode():
    model.generate(input_ids, max_new_tokens=128)

print(torch.cuda.max_memory_allocated(1) / 1000**2, "MB")
print(torch.cuda.max_memory_reserved(1) / 1000**2, "MB")

which requires a minimum of 30GB of VRAM.

Slightly modified the above script, but it returns 15GBs of VRAM:
import torch
from transformers import AutoModelForCausalLM

model = AutoModelForCausalLM.from_pretrained("mistralai/Mistral-7B-v0.1",
                                            torch_dtype = torch.float16,).cuda("cuda:0")

input_ids = torch.randint(0, 1000, (2, 128)).cuda("cuda:0")

with torch.inference_mode():
    model.generate(input_ids, max_new_tokens=128)

print(torch.cuda.max_memory_allocated("cuda:0") / 1000**2, "MB")
print(torch.cuda.max_memory_reserved("cuda:0") / 1000**2, "MB")

@andxalex thanks , I ran the same config @franchukpetro was referring to (without explicitly specifying the dtype).
I honestly thought, probably like @franchukpetro, that the safetensors dtype was used by default when dtype is not specified (bf16 in this case), but it seems to not always be the case 🤔

Thanks for the replies!
So I've just tried running benchmark with 0.0.1 version, with the next .yaml config file:
defaults:
  - backend: pytorch # default backend
  - launcher: inline # default launcher
  - benchmark: inference # default benchmark
  - experiment # inheriting from experiment config
  - _self_ # for hydra 1.1 compatibility
  - override hydra/job_logging: colorlog # colorful logging
  - override hydra/hydra_logging: colorlog # colorful logging

hydra:
  run:
    dir: experiments/${experiment_name}
  sweep:
    dir: experiments/${experiment_name}
  job:
    chdir: true
    env_set:
      CUDA_VISIBLE_DEVICES: 0
      CUDA_DEVICE_ORDER: PCI_BUS_ID
  sweeper:
    params:
      benchmark.input_shapes.batch_size: 1,2,4,8,16

experiment_name: fp16-batch_size(${benchmark.input_shapes.batch_size})-sequence_length(${benchmark.input_shapes.sequence_length})-new_tokens(${benchmark.new_tokens})
model: mistralai/Mistral-7B-v0.1
device: cuda

backend:
  torch_dtype: float16

benchmark:
  memory: true
  warmup_runs: 10

  new_tokens: 1000
  input_shapes:
    sequence_length: 512

That is the same config file as provided in this example, the only difference is addition of launcher, which was required to avoid errors.
As you can see, the dtype is specified to be float16, while I've also tried bfloat16 - both resulted in CUDA out of memory.
I'll try to do same benchmark now as @andxalex adviced, with Python API.
Actually, the only reason why I'm doing benchmarking with older version is because I want to generate nice visualizations, with scripts like report.py, to get plots similar to this tutorial. I'll probably try to combine Python API to get the benchmark data, and report.py file from previous version, but it would be great to have some kind of documentation about that @IlyasMoutawwakil in the new version.

@andxalex I confirm that I was able to benchmark Mistral7B with the code example, you provided above.
@IlyasMoutawwakil please confirm that everything is fine with the output, cause decode max VRAM memory 0 MB is suspicious for me...

Also, I've tried this code with and without specifying torch dtype - without it results in CUDA out of memory (which is logical, cause my GPU has 24GB of VRAM, while 30 is needed), while with specifying float16, as @andxalex suggested, succeded and printed arounf 16GB. I also thought that dtype will be automatically matched with the safetensors dtype, but seems it doesn't work here.

Hi, The theoretical requirement you calculated only count model weights (2 bytes per param * 7b param) but the activations take about the same amount of memory during inference. Try running this simple script:
import torch
from transformers import AutoModelForCausalLM

model = AutoModelForCausalLM.from_pretrained("mistralai/Mistral-7B-v0.1").cuda(1)

input_ids = torch.randint(0, 1000, (2, 128)).cuda(1)

with torch.inference_mode():
    model.generate(input_ids, max_new_tokens=128)

print(torch.cuda.max_memory_allocated(1) / 1000**2, "MB")
print(torch.cuda.max_memory_reserved(1) / 1000**2, "MB")

which requires a minimum of 30GB of VRAM.

Thank you both ! yes I also tested with float16 and can confirm it only requires around 16GB.
@franchukpetro The config you're using might end up requiring more as it sweeps over big batch size with a 512 tokens prompt.
For VRAM issue we can continue the discussion in https://github.com/huggingface/optimum-benchmark/issues/154

@IlyasMoutawwakil regarding creating visualizations from the benchmark results
Do you have any script in current version, similar to 0.0.1 version report.py?
As I see, previous version was creating csv files with just single row,  while new version, using benchmark_report.to_csv("mistral7b_benchmark_report.csv"), creates csv of other format (see file attached).
mistral7b_benchmark_report.csv

@franchukpetro it seems the way the csv file is saved is wrong. I'm using the json in most of of my experimentation so I didn't notice, would you consider submitting a PR to fix it ? it's just an issue in how the pandas Dataframe gets created from the dictionary.

I'll close this issue for now since it's solved.
We can discuss the csv output in another PR/issue.


Old binaries

Hello thx for your software, been using for year.
Happen my server died few days ago and I realize the last version of youtube-dl is giving primarily preference to dash manifest download, which is really slower then just grabbing the regular mp4.
I was wondering where I could get old binaries from earlier version, since I make a  daily use of this, I also try minimizing the command line it takes to accomplish what I need to.
thx

You can give priority to non DASH with -f best. Binaries for each version are located here, but you won't get any support for outdated versions.

awesome, thanks for the repository!


Switch to scala-native 0.3.1

Codecov Report

Merging #737 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   86.84%   86.84%
=======================================
  Files          90       90
  Lines        2523     2523
  Branches       56       56
=======================================
  Hits         2191     2191
  Misses        332      332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05e101...59a55b9. Read the comment docs.

I'm a bit uncomfortable about the curl | bash ... is this the recommended way of building with scala-native on Travis? Can you point to some discussion somewhere?

@milessabin This seems to be common now when using scala-native on Travis CI (see for example, scodec-bits or scalacheck). This setup is the same for all projects, so it makes sense that it gets maintained from scala-native.

Fair enough.


bootstrapped smoke-test running unable to find package Microsoft.DotNet.Arcade.Sdk

Hi team!
When running smoke test for v6.0.107 on Ubuntu with the following command using the tarball created from monorepo:
 VERBOSE=1 ./build.sh --run-smoke-test --with-sdk previously-built-dotnet --with-packages packages/archive/
where previously-built-dotnet is a copy of the dotnet /usr/lib/dotnet/dotnet6-6.0.107 folder and packages archive has both source artifacts prebuilts compressed and uncomppresed (I mean the packages/archive/Private.SourceBuilt.Artifacts.6.0.107.tar.gz and its contents uncompressed)
I got the following error:
/root/SRU-testing/dotnet6-6.0.107/Directory.Build.props(9,3): error : Unable to find package Microsoft.DotNet.Arcade.Sdk. No packages exist with this id in source(s): nuget.org
Looking for the error I found https://github.com/dotnet/aspnetcore/issues/11802 and https://github.com/dotnet/roslyn/issues/38884 , but I checked the Nuget.Config files inside src/arcade folder just in case and I don't find any overrides or disabled packages downloads.
The log file for the test is the following:
Build started 08/02/2022 16:37:56.
Logging verbosity is set to: Detailed.Process = "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/dotnet"
MSBuild executable path = "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/MSBuild.dll"
Command line arguments = "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/MSBuild.dll /root/SRU-testing/dotnet6-6.0.107/build.proj /bl:/root/SRU-testing/dotnet6-6.0.107/artifacts/log/Debug/BuildTests_0802163756.binlog /fileLoggerParameters:LogFile=/root/SRU-testing/dotnet6-6.0.107/artifacts/logs/BuildTests_0802163756.log /clp:v=m /flp:v=detailed /t:RunSmokeTest /p:CustomPrebuiltSourceBuiltPackagesPath=/root/SRU-testing/dotnet6-6.0.107/packages/archive"
Current directory = "/root/SRU-testing/dotnet6-6.0.107"
MSBuild version = "17.0.0+c9eb9dd64"
Resolving SDK 'Microsoft.NET.Sdk'...
Importing project "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/Sdks/Microsoft.NET.Sdk/Sdk/Sdk.props" into project "/root/SRU-testing/dotnet6-6.0.107/build.proj" at (2,3).
Project "$(AlternateCommonProps)" was not imported by "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/Sdks/Microsoft.NET.Sdk/Sdk/Sdk.props" at (39,3), due to false condition; ('$(AlternateCommonProps)' != '') was evaluated as ('' != '').
Importing project "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/Current/Microsoft.Common.props" into project "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/Sdks/Microsoft.NET.Sdk/Sdk/Sdk.props" at (40,3).
Importing project "/root/SRU-testing/dotnet6-6.0.107/Directory.Build.props" into project "/root/SRU-testing/dotnet6-6.0.107/previously-built-dotnet/sdk/6.0.107/Current/Microsoft.Common.props" at (33,3).
Resolving SDK 'Microsoft.DotNet.Arcade.Sdk'...
Running restore with 16 concurrent jobs.
Reading project file /tmp/NuGetScratch/c66cabfa0d1d4ae1b0ba4ee392c28d6c/461a0c9949404d22a789e1d05a76a118.proj.
Restoring packages for /tmp/NuGetScratch/c66cabfa0d1d4ae1b0ba4ee392c28d6c/461a0c9949404d22a789e1d05a76a118.proj...
Restoring packages for .NETStandard,Version=v0.0...
  GET https://api.nuget.org/v3-flatcontainer/microsoft.dotnet.arcade.sdk/index.json
  NotFound https://api.nuget.org/v3-flatcontainer/microsoft.dotnet.arcade.sdk/index.json 327ms
Resolving conflicts for .NETStandard,Version=v0.0...
/root/SRU-testing/dotnet6-6.0.107/Directory.Build.props(9,3): error : Unable to find package Microsoft.DotNet.Arcade.Sdk. No packages exist with this id in source(s): nuget.org
Project "/root/SRU-testing/dotnet6-6.0.107/build.proj" on node 1 (RunSmokeTest target(s)).
/root/SRU-testing/dotnet6-6.0.107/Directory.Build.props(9,78): error MSB4236: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found. [/root/SRU-testing/dotnet6-6.0.107/build.proj]
Done Building Project "/root/SRU-testing/dotnet6-6.0.107/build.proj" (RunSmokeTest target(s)) -- FAILED.
Deferred Messages

Detailed Build Summary
======================

  ============================== Build Hierarchy (IDs represent configurations) =====================================================
  Id                  : Exclusive Time   Total Time   Path (Targets)
  -----------------------------------------------------------------------------------------------------------------------------------
  0                   : 1.093s           1.093s       /root/SRU-testing/dotnet6-6.0.107/build.proj (RunSmokeTest)

  ============================== Node Utilization (IDs represent configurations) ====================================================
  Timestamp:            1        Duration   Cumulative
  -----------------------------------------------------------------------------------------------------------------------------------
<PHONE_NUMBER>66780904:   0        1.096s     1.096s .....................
  -----------------------------------------------------------------------------------------------------------------------------------
  Utilization:          100.0    Average Utilization: 100.0

Build FAILED.

  /root/SRU-testing/dotnet6-6.0.107/Directory.Build.props(9,3): error : Unable to find package Microsoft.DotNet.Arcade.Sdk. No packages exist with this id in source(s): nuget.org

"/root/SRU-testing/dotnet6-6.0.107/build.proj" (RunSmokeTest target) (1) ->
  /root/SRU-testing/dotnet6-6.0.107/Directory.Build.props(9,78): error MSB4236: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found. [/root/SRU-testing/dotnet6-6.0.107/build.proj]

    0 Warning(s)
    2 Error(s)

Time Elapsed 00:00:01.13

In the Directory.Build.props mentioned file I see this maybe related to it:
  <Import Condition="'$(SkipArcadeSdkImport)' != 'true'" Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
  <PropertyGroup>
    <!-- Fake, for SDK. -->
    <TargetFramework>netstandard2.0</TargetFramework>
    <!-- We have no projects targeting multiple frameworks, so don't include in output path. -->
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
  </PropertyGroup>

Maybe I'm missing any step?  Or there is something missing in the bootstrap? Could you please take a look on it andd let me know what you think or what you can think of that might be going on?
Thanks in advance. Have a good day.

Hi Miriam, I'm taking a look at this now, thanks for reporting it.

Hi @mirespace , I think I have this figured out.  Are you running this is a separate directory from the one you run ./prep.sh --bootstrap in?  I think the NuGet.Config file with the feeds for Arcade are not present because it only gets copied over here in the bootstrap-prep case.  I think the right fix here is for us to write out a NuGet.Config file and substitute in the directory if you use --with-packages but I think you should be able to try this out using a NuGet.Config file in the directory you're running in an putting in the content:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="previously-source-built" value="<your packages feed here>" />
  </packageSources>
</configuration>

Let me know if you'd like to try that and in the meantime I'll try and get a proper fix ready.

@crummel - Can you please backport the fix to 6.0.1xx?

This was backported with https://github.com/dotnet/installer/pull/14587 - closing.

Hi 👋🏻
I want to continue where Miriam left off and integrate the smoke-tests into the Ubuntu CI, but as Miriam I have problems running them.
I wrote a Containerfile to make it easier for you to replicate/debug my problem (see below).
When I run
podman run --rm -it --network none dotnet6-smoke-tests

I get the following output:
Using custom bootstrap SDK from '/usr/lib/dotnet', version '6.0.119'
Found bootstrap SDK 6.0.119, bootstrap Arcade 6.0.0-beta.23313.5, bootstrap SourceLink 1.1.0-beta-21480-02
Microsoft (R) Build Engine version 17.0.1+b177f8fa7 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

/usr/lib/dotnet/sdk/6.0.119/MSBuild.dll /bl:/tmp/sdk-under-test/source/artifacts/log/Debug/BuildTests_0717064737.binlog /clp:v=m /fileLoggerParameters:LogFile=/tmp/sdk-under-test/source/artifacts/logs/BuildTests_0717064737.log /flp:v=detailed /p:CustomSourceBuiltPackagesPath=/tmp/sdk-under-test/source/packages/archive /t:RunSmokeTest /tmp/sdk-under-test/source/build.proj
/tmp/sdk-under-test/source/Directory.Build.props(9,3): warning : Unable to load the service index for source https://api.nuget.org/v3/index.json.
/tmp/sdk-under-test/source/Directory.Build.props(9,3): error : Unable to find package Microsoft.DotNet.Arcade.Sdk. No packages exist with this id in source(s): nuget.org
/tmp/sdk-under-test/source/Directory.Build.props(9,78): error MSB4236: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found. [/tmp/sdk-under-test/source/build.proj]

The script tries to download the package Microsoft.DotNet.Arcade.Sdk and not use the offline packages.
I already spend a lot of time set various environment variables, script parameter & file layouts, but I could not get the somke tests running. Could you point me in the right direction or show me a minimal working example?

Note: This Containerimage takes ages to build. You can pull it from updf8ehoay.azurecr.io/dotnet6-smoke-tests to save time.
Note:  If you want to build this image yourself, note the COPY dotnet-smoke-test-prereqs.6.0.120.tar.gz .; you have to provide this file yourself.
FROM ubuntu:mantic
ARG SDK_VERSION_UNDER_TEST=6.0.120-0ubuntu1
ARG PREVIOUS_SDK_VERSION=6.0.119-0ubuntu1

# Install dependencies:
RUN apt-get update && apt-get install --assume-yes ubuntu-dev-tools quilt libicu72

# Install previous SDK:
WORKDIR /tmp/previous-sdk
RUN pull-lp-debs dotnet6 $PREVIOUS_SDK_VERSION
RUN apt install --assume-yes \
    ./dotnet-host*.deb \
    ./dotnet-hostfxr-6.0*.deb \
    ./dotnet-runtime-6.0*.deb \
    ./aspnetcore-runtime-6.0*.deb \
    ./aspnetcore-targeting-pack-6.0*.deb \
    ./dotnet-apphost-pack-6.0*.deb \
    ./dotnet-targeting-pack-6.0*.deb \
    ./netstandard-targeting-pack-2.1*.deb \
    ./dotnet-templates-6.0*.deb \
    ./dotnet-sdk-6.0*.deb

# Download SDK under test source-built artifacts & source code:
WORKDIR /tmp/sdk-under-test
RUN pull-lp-debs dotnet-sdk-6.0-source-built-artifacts $SDK_VERSION_UNDER_TEST
RUN dpkg --install ./dotnet-sdk-6.0-source-built-artifacts*.deb
RUN pull-lp-source dotnet6 $SDK_VERSION_UNDER_TEST
RUN mv dotnet6-* source

# Cleanup unnecessary files
RUN rm /tmp/previous-sdk/*.deb /tmp/sdk-under-test/*.deb

# Link to the source built artifacts and unpack:
WORKDIR /tmp/sdk-under-test/source/packages/archive
RUN ln -s /usr/lib/dotnet/source-built-artifacts/Private.SourceBuilt.Artifacts.$(echo $SDK_VERSION_UNDER_TEST | grep --only-matching --perl-regexp '6.0.1\d\d').tar.gz .
RUN tar --extract --gzip --file Private.SourceBuilt.Artifacts.*.tar.gz

# Import and unpack the smoke test prereqs:
WORKDIR /tmp/sdk-under-test/source/packages/smoke-test-prereqs
COPY dotnet-smoke-test-prereqs.6.0.120.tar.gz .

I had begun making that happen with the changes in https://github.com/dotnet/installer/pull/16359. But that had to be abandoned because the entire approach of maintaining the list of smoke test prereqs was flawed. However, the changes there illustrate some of the work that is necessary for tests to be offline-capable.
I think what you're running into here is that it's implicitly running dotnet restore for the Microsoft.DotNet.SourceBuild.SmokeTests.csproj project. There is no NuGet.config in context, so it automatically generates one that points to nuget.org for the feed. You can see in my changes, that I define a local/offline version of NuGet.config file that points to the prereqs path. That will allow the restore to work offline by pulling the packages from that path. However, the smoke test prereqs tarball only contains the packages required by the tests, not the test project. So you still need to populate the prereqs path with the packages that would be restored as a result of running dotnet restore on the test project. This is what my changes in the prep script did for you. It restored the test project, targeting the smoke test prereqs path as the output location. This ultimately means that you need to do this step in an online environment.


[WTF-1999] Add missing onChange documentation for selection property

Then XML onChange attribute for the selection property was missing in the documentation, this PR adds this.

@ConnorLand this PR is ready for your magic

A PR was detected in this PR. I merged dev into it, no conflict arose, so I merged it.


ADTS-31: Validate setIsDisplayNameAsteriskPresent exists

Closing due to it being fixed in the Azure Repo - have fetched the fix into here.


Add mTLS support to Orleans

Describe the feature
We want to encrypt traffic between silos and clients.

This doesn't make sense to be built into Web Scheduler, The Nugets can be used to configure this.


My function returns [5, 27, 39, 1000], but its wants it to return [27, 5, 39, 1000], it solves the issue at hand but is being checked against the wrong driver it seems.

Challenge Bonfire: Return Largest Numbers in Arrays has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function largestOfFour(arr) {
  // You can do this!
    var arr2 = [];
  var holder;
  var max = 0;
  arr.forEach(function(val){
    val.forEach(function(val2){
      if (val2 > max){
        max = val2;
      }

    });
    arr2.push(max);
  });
  arr = arr2;
  return arr;
}

largestOfFour([[4, 5, 1, 3], [13, 27, 18, 26], [32, 35, 37, 39], [1000, 1001, 857, 1]]);

There's actually nothing wrong with the test, you're just missing something important in the code. Make sure you reset max after you push it, otherwise, for following arrays, val2 might never be greater than max and will return the old max value.

@HermanFassett Thanks!
Happy Coding!


Design UI and describe UX for all pages

Define UI design, color scheme, logos, etc as a subpage of https://kusama.network/.
Views to design:

Common layout for all views (header, menu, footer, etc)
Ranking (index)

Show introduction: what is this for?
Show a warning message about this is a decentralized app and data needs some time to be ready.
Smart loading indicator: divide data collecting into steps so we can show the user what data is being collected in current step.
When data is loaded:  Grid or table view? full page or central row?
Should show rows/cards with basic data: rank, name, address, nominators.
Include filter / Excludes (100% commission, no identity, oversubscribed, others)
Include selected validators widget

Validator single page

Display all data (cuantitative / qualitative)
Link to qualitative data form

Qualitative data form

Include all the fields defined in #2

Done


v: pin vc to fix CI issue

It seems that while pinning V version to a specific commit, I have not considered the fact that the V's Makefile always fetching latest v.c could break bootstrapping. This PR addresses that by also pinning the version of v.c.
I know this is not ideal, I'll work on getting up-to-date, pre-built builds but in the mean time the CI should not fail for others.

@div72  reverted because it broke CI on ubuntu.
The log was previously available from here
https://github.com/adsharma/py2many/pull/437/checks?check_run_id=3109697454


Analog out default

I'm running the analog out example. I'm using Jupyter to write my python code.
I've notice if I interrupt the kernel (suppose to be the same as Ctrl + C), it quits, but the voltage jumps to the max voltage. Is there any way to prevent this happening? It's actually a safety issue for me.

Dear M. Aguilera,
I don't have Jupyter.  I am running Visual Studio 2015 with this library.
Of course you are welcome to use any compatible Python IDE to be sure.
However when I run either analog output example (v_out.py, VOut01.py or ULAO01.py) and and terminate the app using all the ways I am capable (click on the X, CTRL+C, etc.) the last value set out of the DAC stays where it was last set.
The mcculw uses the same underlying library used for Win32 C, VB6, and in a round about way VB.NET and C#.NET.  Meaning they all hold the last value the calling program output to the DAC.
I believe the phenomenon you are witnessing is nothing to do with our library but rather to do with Jupyter.
I agree this could be a safety issue, but as stated above, the last value output to the DAC is where it stays  when the app terminates.  That is why when you output a value of 0VDC and then ended your app, it would/should stay at 0VDC.
Best regards,
Jeff

@aguileraGit you could catch the KeyboardInterrupt and use a finally to set analog output to 0 volts.
Refer to https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions


Post release changes for ACS Common releases

Post release version increment changes for azure-communication-common

/check-enforcer override


2 views for multiportal usage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Storage.signUrl() fails with default credentials in java8 standard runtime

Invocation:
// initialization
storage = StorageOptions.getDefaultInstance().getService();

// later
storage.signUrl(info, 5L, TimeUnit.MINUTES,
                Storage.SignUrlOption.httpMethod(HttpMethod.valueOf(method)),
                Storage.SignUrlOption.withContentType()
        );

Stacktrace:
Caused by: java.lang.IllegalStateException: Signing key was not provided and could not be derived
	at com.google.common.base.Preconditions.checkState(Preconditions.java:444)
	at com.google.cloud.storage.StorageImpl.signUrl(StorageImpl.java:508)

I tracked the problem down to the com.google.auth.oauth2.GoogleCredentials.getDefaultCredentialsUnsynchronized()(https://github.com/google/google-auth-library-java/blob/51a5445b33d10f252cadfdcca82dd9e68512e483/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java#L182) where it skips over tryGetAppEngineCredential() to return an instance of com.google.auth.oauth2.AppengineCredentials which is one of the implementations of ServiceAccountSigner required by the signUrl call with default credentials.
This may also affect other services assuming an instance of  com.google.auth.oauth2.AppengineCredentials.
Is there any specific reason why to check for java7 only?
Background: We moved to the java8 runtime on GAE and upgraded our api clients to the google-cloud-java api clients version 1.10.0.

@neozwu Do you have context around this? It looks like the relevant auth library code was last updated in these PRs:

https://github.com/google/google-auth-library-java/commit/2ac95c18185294f74d5d38098e15a04be09c755b
https://github.com/google/google-auth-library-java/commit/dd5fdfdc11774f9df7390efabba08edb6aaa467f

@phimar For GAE java 8 standard, metadata server is used to retreive credentials. The current implementation for AppengineCredentials uses appengine APIs, which only work for java 7. It seems that  ComputeEngineCredentials didn't implement ServiceAccountSigner.  @lesv @ludoch  do you have any context regarding this?
/cc @lesv @ludoch

No, but its a very important thing to fix.

Thank you for your comments and the linkage to the issue on google/google-auth-library-java.

should be solved by https://github.com/google/google-auth-library-java/pull/150

@jadekler @garrettjonesgoogle @ludoch : has anybody diagnosed what the issue is ? It seems like ComputeEngineCredentials does implement ServiceAccountSigner now ?  google/google-auth-library-java#150

cc @chingor13, who dealt with the linked CL

nothing magical here, the version hasn't been bumped to the new version of the related library
current master:
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/ab575d0eaf987cbc04f715310b4f23277bd84b9c/google-cloud-clients/pom.xml#L160

(the linked PR has been released in https://github.com/google/google-auth-library-java/releases/tag/v0.10.0)

@pongad Let's bump auth to 0.10.0 for the next release

Yes this issue present in flexible runtime too

google.auth.version has been bumped. Please update the library to the latest version (1.38.0) and see if the problem is resolved.

I had the same problem:
Caused by: java.lang.IllegalStateException: Signing key was not provided and could not be derived
Using AppEngine standard, I solved like this:
        static final AppIdentityService identityService = AppIdentityServiceFactory.getAppIdentityService();

        SignUrlOption signWith = SignUrlOption.signWith(new ServiceAccountSigner() {
            @Override
            public byte[] sign(byte[] toSign) {
                return identityService.signForApp(toSign).getSignature();
            }

            @Override
            public String getAccount() {
                return identityService.getServiceAccountName();
            }
        });

It would seem that this method documentation is no longer applicable, right?
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java#L2045-L2047
Based on the above PRs and commentary, when running on GCE with google-cloud-storage v1.38.0, the application default credentials (ADC) should be sufficient to sign a blob, yes?
Wondering if anything else has to be done as we are still having trouble (different error message, getting a little farther in the code as far as execution) and not sure why things fail when running on GCE using ADC vs. when we provide the key file directly via GOOGLE_APPLICATION_CREDENTIALS.
thanks y'all for the support.

The ComputeEngineCredentials signing method requires 2 things:

The Identity and Access Management (IAM) API must be enabled for the project
The Compute Engine service account (the default App Engine service account for GAE Standard Java 8) needs the iam.serviceAccounts.signBlob permission (available to the "Service Account Token Creator" role).

@NicolaSpreafico try updating the com.google.cloud:google-cloud-storage dependency to 1.38.0 (or com.google.auth:google-auth-library-oauth2-http to 0.10.0) and ensuring the default service account has the necessary IAM access.
@noahdietz ADC prefers the key file provided by GOOGLE_APPLICATION_CREDENTIALS over the Compute Engine credentials and uses 2 different strategies for signing URLs. If you're seeing a SigningException you can inspect the underlying cause by catching the SigningException and looking at the Throwable from getCause(). It's likely that you need to set up the IAM config above.
Created https://github.com/google/google-auth-library-java/issues/175 for documentation and will open a new issue for docs here as well.

@chingor13 fixed! we had set all of the scopes and IAM policies we thought were necessary (devstorage.full_control & bucket objectAdmin). Didn't work. Turns out we needed to use the cloud-platform scope on the instance instead. At least that was the only thing that changed and it started working.
Thanks for the help.

Greetings folks!  It looks like this issue has been resolved.  If you're still running into problems... let us know!

I needed to grant iam.serviceAccounts.signBlob in order for the default service account to sign URLs while running in App Engine, but running locally with the same credentials didn't require this---is this a bug?

I am running into this problem on java 11 appengine runtime. I meet both requirements:

The Identity and Access Management (IAM) API must be enabled for the project
The Compute Engine service account (the default App Engine service account for GAE Standard Java 8) needs the iam.serviceAccounts.signBlob permission (available to the "Service Account Token Creator" role).

I'm using implementation("com.google.cloud:google-cloud-storage:2.4.2")


Update usb-device-side-drivers-in-windows.md

Add a missing character.

Do you guys know how I can get a driver for Qualcomm's Snapdragon® X Elite that I just received brand new. It came missing most of the drivers!😔


Add support for classes on GPU

This is currently waiting on ILGPU. I have been told they're gonna pull some memory magic to add "basic" support for classes, whatever that entails. So this probably won't be a thing for a while, but I'm going to leave this issue here.


fix: Add missing f-string from app_analytics models

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
While looking into our various databases on the backend I noticed these strings were missed and quickly fixed them.
How did you test this code?
The change is simple enough to rely on CI / common sense.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (76cc152) 96.10% compared to head (e4373f3) 96.10%.
Report is 5 commits behind head on main.

Files
Patch %
Lines

api/app_analytics/models.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3155   +/-   ##
=======================================
  Coverage   96.10%   96.10%
=======================================
  Files        1058     1058
  Lines       31882    31882
=======================================
  Hits        30641    30641
  Misses       1241     1241

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Retry on Webhook EOF Errors

Mitigation for https://github.com/knative/pkg/issues/1509.
Same fix was used in eventing core to mitigate webhook EOF
errors.
Fixes (some flaky tests in eventing-kafka-broker)
Proposed Changes

Retry on Webhook EOF Errors

Release Note

None

Docs

None

see: https://github.com/knative/eventing/pull/3678/files  for reference


MM-25782 improve channel member reducer speed to sync memberships

Summary
The current reducer implementation for channel members was too slow as it was looping through all the current channel memberships to determine if some of them needed to be removed as the user was no longer a member of that channel.
The change now consist in determine if there are memberships to be removed first by filtering the current memberships with those returned by the server and then loop through them.
The issue being fixed is more noticeable when you have a large amount of channels ad multiple teams.
Ticket Link
https://mattermost.atlassian.net/browse/MM-25782

Building app in separate branch.

Artifact links:
https://6708-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://6707-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa


importItemFromChest() voids items if RS system is full, haven't tried ME yet but i'd imagine that's the same case there too

Put this in your discord but I don't know which you check more, and I think it's a severe enough bug that it wouldn't hurt to double post.
https://discord.com/channels/734726882058174486/771935468149276682/858894539413520384
if you try and importItemFromChest() and the RS system is full, it will void the items
can we get a way to check using a method, preferrably returning a bool
something like isSystemFull() or something?
or maybe expose RS's "storage API" a bit so we can see the amount stored and check "manually"
other than that, love the mod, heaps of fun

I will mark that as an enhancement. I will add a isSystemFull and a getFreeSpace function.

Fixed in 0.7a


Atom 1.9.8 freezes everytime when an opened large file gets updated under Windows 10

Prerequisites

[ ] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[ ] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
I opened two files in Atom, one is 3MB large. The smaller file was active, and then the large file got updated (more exactly, rewritten) by another external process. After that, Atom did not respond and froze. It would not come back to life and I had to restart it.
Steps to Reproduce

Open a large file, and switch to a window with a smaller file.
Update the large file with some external process.
Atom freezes.

Expected behavior: [What you expected to happen]
The large file can get reloaded (depending on your choice) just like what will happen in Notepad++
Actual behavior: [What actually happened]
Atom just freezes.
Versions
1.9.8
You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

I can reproduce this, it happens everytime I use browserify to generate a large file while it is open in Atom and it freezes and will stay "frozen" until it is restarted.
windows 10 x64
Atom 1.12.7

I can reproduce this on Atom 1.14.3 on MacOS 10.12.3 too. Has no problem opening a large file, but if that file is open in Atom while another processes rewrites it, Atom freezes until restarted.

I've either reproduced this, or a similar root cause.
Atom 1.14.3 / Win10 64bit
After a LOT of time, I managed to get a cpuprofile of the issue. If you give it enough time, it un-freezes. Unfortunately trying to save the profile off results in an empty file, I tried a few times. Heres a screenshot.

The slowdown starts when the file opens, until the styles are parsed visually.
Safemode reproduces it.

Fixed by https://github.com/atom/atom/pull/13820
This should be closed.

Thanks @PhillMcKraken

The issue specifies a "large" file, not a minified file, and also talks about external reloading, so I don't think this has to do with #13820.  Reopening.

@bailuding I noticed that you couldn't reproduce this in safe mode (atom --safe): does it not happen in safe mode, or did you not try?  If the latter, please try reproducing this in safe mode and tell us how it goes.  Thanks!

Just to be clear, I did reproduce the root report and narrowed it to what I reported. While I cant speak for bailuding, I did try to do some due diligence.


Starter Code: App router to pages rotuer

Hi, we have developed our app in nextjs pages router. We want to implement the starter codebase in our application. Since the starter codebase is developed in app router migrating it to pages router is proving to be difficult.
If you already have a codebase in pages router would it be possible for you to share it?

Hey @FrugalX,
There is no specific example that relies on pages router, but most of the configuration happens in Middleware.ts, which would be the same for Pages Router and App Router.
You can follow Getting Started Guide from the docs until you reach Layout section, which is dedicated for App Router.
Then, you can follow Usage in getServerSideProps guide to get user token from NextApiRequest using getApiRequestTokens function.
There's also a guide on using getApiRequestTokens function in conjunction with Pages Router API Routes
Let me know when you have any problems when setting up the library


Connect form to MySQL

Looks good. Job well done!

Add a sign out button. Can be on user's dashboard.


Fix mongodb conf

Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

I verified this works just fine with nested decimal objects (which we were concerned about). Note that neither timestamp or byte array can actually be encountered given JSON doesn't support that.

So.. I just inserted the following:
{
  "key": "complexthing",
  "value": {
    "name": {"morecomplex": {"decimalthing": 0.123456789}}
  }
}

This works with no problem
curl -X POST http://localhost:3500/v1.0/state/mymongo \
-H "Content-Type: application/json" \
-d '[
{
"key": "weapon123",
"value": "DeathStar",
"etag": "1234"
},
{
"key": "complexthing",
"value": {
"name": {"morecomplex": {"decimalthing": 0.123456789}}
}
}
]'

And GET request works:
curl http://localhost:3500/v1.0/state/mymongo/complexthing \
-H "Content-Type: application/json"
{"name":{"morecomplex":{"decimalthing":0.123456789}}}%


Get system font file on tizen

systemFontPath returns a closest matching font to the specified family, style and weight. This uses the FontConfig API (https://www.freedesktop.org/software/fontconfig/fontconfig-devel/).
Todo:

[ ] Need some special code to handle fallback fonts.

One way to get fallback fonts could be to query fontconfig for 'Regular' style fonts and then pick the first font for each FC_LANG

Yeah thats a good suggestion, will try that.
We should also add this code for linux platforms.

@hjanetzek Updated with fallback implemetation and some fixups.

LGTM, @hjanetzek can review and merge.
FontContext would need a major cleanup from platform dependent code.


Passing children to Checkboard component

#547
This allows <Checkboard/> component to accepts children, and to be used as a background on the passed down children prop.

This is great, thanks!


Stories - Change four

Current dependencies on/for this PR:

main

PR #1

PR #2

PR #4

PR #3   (this PR)

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: wTGz7IzhKkUWH68svdRm


Refactor package and module structure

Refactor packages and modules:

Merge ether package into ethereum
Create a new solidity package for everything related to Solidity support
Rename ETHContract to EVMContract
Remove unused EVM class

Besides cleaning things up a bit, this is also in anticipation of adding support for new interpreters (`EWASMContract) and languages (Vyper), even though that will need some more prep work.

Rename solidity module to contract_source

I was thinking along these lines as well. How about lang?
from mythril.ethereum.lang.solidity import SolidityContract

Other suggestions sound all good.

lang is awesome, I wasn't happy with contract_source myself


Add note to README about supported versions of MongoDB

The insertion of a user (and the app in general) doesn't work with recent versions of MongoDB. v3.0.12 works OK; v3.4.1 does NOT work due to a problem with the :w => 1 option no longer being supported at the top level, i.e. outside the Write Concern options.

It might be better to explicitly mention the current mongo (and bundler) versions that are pinned by govuk-puppet for this app / ruby version.

Do you know how we can find the mongo version, @h-lame?
My best guess is that it's 2.6 based on this comment in mongodb/manifests/server.pp. Although I can see that the mongo version is explicitly set to 2.4.9 or 3.2.7 in a couple of places but it's not clear to me whether these are being used on the server hosting manuals-publisher.

I think it's 2.4.9 because of https://github.com/alphagov/govuk-puppet/blob/f3614e33bcf037b218e0b9e816f0994786b41efb/hieradata/common.yaml#L1256 - the other things that set this variable are for ci machines or licensing machines, neither of which are relevant for this app (I'm not entirely sure how to point to a definition in puppet that would confirm that part though).

@h-lame:

It might be better to explicitly mention the current mongo (and bundler) versions that are pinned by govuk-puppet for this app / ruby version.

I've added a sentence based on your reply to the question from @chrisroos. Does that address your concern? And would you prefer me to squash this commit into the first one?

Looks good now, thanks.


Fixed Issue where The Q would not load in IE: re-configuring Babel 7

Re: the creation of the babel.config.js "@babel/preset-env" required declaring of the corejs version (3.0) in order  to work.  Previous PR for the same issue failed to work in all environments due to not specifying this.

closing as have included this commit into another PE


Return DTO with an identifier generated by EF

In the DTO approach, right now the response from create API does not return the id, this change would fix it.

I understand that this tutorial is about asp.net core minimal API, I can't resist ask, should we introduce the Deconstruct method in Todo class?

@wadepickett  be sure to test original code and this change.

@Rick-Anderson and @ganesanarun,  I may not be catching on to what needs to be done here.  id does return with the code as it already was.
{
"id": 1,
"name": null,
"isComplete": false
}
The changed line suggested in this PR at this moment however will not compile, nor would I expect it to.  todo is not defined.

I agree that
return TypedResults.Created($"/todoitems/{todoItem.Id}", new TodoItemDTO(todo)); should be
TypedResults.Created($"/todoitems/{todoItem.Id}", new TodoItemDTO(todoItem));
but I don't think the current create API returns id at all.
anyway it's up to you folks. @Rick-Anderson @wadepickett


Is there anything wrong with garden?

I've created a new project but garden can't retrieve what it needs.
https://github.com/piotr-yuxuan/minimal-garden-bug

@piotr-yuxuan Thanks for bringing this issue up and for providing a minimal example. I had to deleted my .m2 directory to reproduce, but I was able to see what you were experiencing.
The solution is to add [ns-tracker "0.3.1"] to the :dependencies` in your project.clj file when using garden.
Thanks so much!

~/gadfly/temp$ lein new reagent-figwheel minimal-garden-bug +garden
Retrieving lein-oneoff/lein-oneoff/0.3.2/lein-oneoff-0.3.2.pom from clojars
Retrieving lein-externs/lein-externs/0.1.6/lein-externs-0.1.6.pom from clojars
Retrieving lein-oneoff/lein-oneoff/0.3.2/lein-oneoff-0.3.2.jar from clojars
Retrieving lein-externs/lein-externs/0.1.6/lein-externs-0.1.6.jar from clojars
Retrieving reagent-figwheel/lein-template/0.2.9-1/lein-template-0.2.9-1.pom from clojars
Retrieving reagent-figwheel/lein-template/0.2.9-1/lein-template-0.2.9-1.jar from clojars

Generating reagent-figwheel project.

~/gadfly/temp$ cd minimal-garden-bug/
~/gadfly/temp/minimal-garden-bug$ lein garden auto
Retrieving lein-cljsbuild/lein-cljsbuild/1.1.4/lein-cljsbuild-1.1.4.pom from clojars
Retrieving fs/fs/1.1.2/fs-1.1.2.pom from clojars
Retrieving org/clojure/clojure/1.3.0/clojure-1.3.0.pom from central
Retrieving org/sonatype/oss/oss-parent/5/oss-parent-5.pom from central
Retrieving org/apache/commons/commons-compress/1.3/commons-compress-1.3.pom from central
Retrieving org/apache/commons/commons-parent/22/commons-parent-22.pom from central
Retrieving org/apache/apache/9/apache-9.pom from central
Retrieving lein-garden/lein-garden/0.2.8/lein-garden-0.2.8.pom from clojars
Retrieving garden/garden/1.3.1/garden-1.3.1.pom from clojars
Retrieving com/yahoo/platform/yui/yuicompressor/2.4.8/yuicompressor-2.4.8.pom from central
Retrieving me/raynes/fs/1.4.6/fs-1.4.6.pom from clojars
Retrieving org/clojure/clojure/1.4.0/clojure-1.4.0.pom from central
Retrieving org/apache/commons/commons-compress/1.8/commons-compress-1.8.pom from central
Retrieving org/apache/commons/commons-parent/33/commons-parent-33.pom from central
Retrieving org/apache/apache/13/apache-13.pom from central
Retrieving org/tukaani/xz/1.5/xz-1.5.pom from central
Retrieving ns-tracker/ns-tracker/0.3.0/ns-tracker-0.3.0.pom from clojars
Retrieving org/clojure/clojure/1.5.1/clojure-1.5.1.pom from central
Retrieving org/clojure/tools.namespace/0.2.10/tools.namespace-0.2.10.pom from central
Retrieving org/clojure/pom.contrib/0.1.2/pom.contrib-0.1.2.pom from central
Retrieving org/sonatype/oss/oss-parent/7/oss-parent-7.pom from central
Retrieving org/clojure/java.classpath/0.2.2/java.classpath-0.2.2.pom from central
Retrieving org/apache/commons/commons-compress/1.3/commons-compress-1.3.jar from central
Retrieving org/clojure/clojure/1.3.0/clojure-1.3.0.jar from central
Retrieving org/clojure/tools.namespace/0.2.10/tools.namespace-0.2.10.jar from central
Retrieving com/yahoo/platform/yui/yuicompressor/2.4.8/yuicompressor-2.4.8.jar from central
Retrieving org/clojure/java.classpath/0.2.2/java.classpath-0.2.2.jar from central
Retrieving fs/fs/1.1.2/fs-1.1.2.jar from clojars
Retrieving me/raynes/fs/1.4.6/fs-1.4.6.jar from clojars
Retrieving ns-tracker/ns-tracker/0.3.0/ns-tracker-0.3.0.jar from clojars
Retrieving lein-garden/lein-garden/0.2.8/lein-garden-0.2.8.jar from clojars
Retrieving lein-cljsbuild/lein-cljsbuild/1.1.4/lein-cljsbuild-1.1.4.jar from clojars
Retrieving garden/garden/1.3.1/garden-1.3.1.jar from clojars
Retrieving lein-figwheel/lein-figwheel/0.5.10/lein-figwheel-0.5.10.pom from clojars
Retrieving simple-lein-profile-merge/simple-lein-profile-merge/0.1.4/simple-lein-profile-merge-0.1.4.pom from clojars
Retrieving org/clojure/clojure/1.6.0/clojure-1.6.0.pom from central
Retrieving simple-lein-profile-merge/simple-lein-profile-merge/0.1.4/simple-lein-profile-merge-0.1.4.jar from clojars
Retrieving lein-figwheel/lein-figwheel/0.5.10/lein-figwheel-0.5.10.jar from clojars
Compiling Garden...
Could not find artifact org.clojure:clojure:jar:1.8.0
Could not find artifact org.clojure:clojurescript:jar:1.9.229
Could not find artifact reagent:reagent:jar:0.6.1
Could not find artifact garden:garden:jar:1.3.2
Could not find artifact org.clojure:tools.nrepl:jar:0.2.12
Could not find artifact clojure-complete:clojure-complete:jar:0.2.4
Could not find artifact ns-tracker:ns-tracker:jar:0.2.2
This could be due to a typo in :dependencies or network issues.
If you are behind a proxy, try setting the 'http_proxy' environment variable.
~/gadfly/temp/minimal-garden-bug$ lein deps
Retrieving org/clojure/clojure/1.8.0/clojure-1.8.0.pom from central
Retrieving org/clojure/clojurescript/1.9.229/clojurescript-1.9.229.pom from central
Retrieving com/google/javascript/closure-compiler-unshaded/v20160315/closure-compiler-unshaded-v20160315.pom from central
Retrieving com/google/javascript/closure-compiler-main/v20160315/closure-compiler-main-v20160315.pom from central
Retrieving com/google/javascript/closure-compiler-parent/v20160315/closure-compiler-parent-v20160315.pom from central
Retrieving org/sonatype/oss/oss-parent/9/oss-parent-9.pom from central
Retrieving com/google/javascript/closure-compiler-externs/v20160315/closure-compiler-externs-v20160315.pom from central
Retrieving args4j/args4j/2.0.26/args4j-2.0.26.pom from central
Retrieving args4j/args4j-site/2.0.26/args4j-site-2.0.26.pom from central
Retrieving org/kohsuke/pom/6/pom-6.pom from central
Retrieving com/google/guava/guava/19.0/guava-19.0.pom from central
Retrieving com/google/guava/guava-parent/19.0/guava-parent-19.0.pom from central
Retrieving com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.pom from central
Retrieving com/google/google/1/google-1.pom from central
Retrieving com/google/code/gson/gson/2.2.4/gson-2.2.4.pom from central
Retrieving com/google/code/findbugs/jsr305/1.3.9/jsr305-1.3.9.pom from central
Retrieving org/clojure/google-closure-library/0.0-20160609-f42b4a24/google-closure-library-0.0-20160609-f42b4a24.pom from central
Retrieving org/clojure/google-closure-library-third-party/0.0-20160609-f42b4a24/google-closure-library-third-party-0.0-20160609-f42b4a24.pom from central
Retrieving org/clojure/data.json/0.2.6/data.json-0.2.6.pom from central
Retrieving org/mozilla/rhino/1.7R5/rhino-1.7R5.pom from central
Retrieving org/clojure/tools.reader/1.0.0-beta3/tools.reader-1.0.0-beta3.pom from central
Retrieving reagent/reagent/0.6.1/reagent-0.6.1.pom from clojars
Retrieving org/clojure/clojurescript/1.8.51/clojurescript-1.8.51.pom from central
Retrieving com/google/javascript/closure-compiler/v20160315/closure-compiler-v20160315.pom from central
Retrieving org/clojure/google-closure-library/0.0-20151016-61277aea/google-closure-library-0.0-20151016-61277aea.pom from central
Retrieving org/clojure/google-closure-library-third-party/0.0-20151016-61277aea/google-closure-library-third-party-0.0-20151016-61277aea.pom from central
Retrieving org/clojure/tools.reader/1.0.0-beta1/tools.reader-1.0.0-beta1.pom from central
Retrieving cljsjs/react-dom/15.4.0-0/react-dom-15.4.0-0.pom from clojars
Retrieving cljsjs/react/15.4.0-0/react-15.4.0-0.pom from clojars
Retrieving cljsjs/react-dom-server/15.4.0-0/react-dom-server-15.4.0-0.pom from clojars
Retrieving garden/garden/1.3.2/garden-1.3.2.pom from clojars
Retrieving org/clojure/tools.nrepl/0.2.12/tools.nrepl-0.2.12.pom from central
Retrieving clojure-complete/clojure-complete/0.2.4/clojure-complete-0.2.4.pom from clojars
Retrieving com/google/javascript/closure-compiler-externs/v20160315/closure-compiler-externs-v20160315.jar from central
Retrieving org/clojure/clojure/1.8.0/clojure-1.8.0.jar from central
Retrieving args4j/args4j/2.0.26/args4j-2.0.26.jar from central
Retrieving com/google/javascript/closure-compiler-unshaded/v20160315/closure-compiler-unshaded-v20160315.jar from central
Retrieving org/clojure/clojurescript/1.9.229/clojurescript-1.9.229.jar from central
Retrieving com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.jar from central
Retrieving com/google/guava/guava/19.0/guava-19.0.jar from central
Retrieving com/google/code/gson/gson/2.2.4/gson-2.2.4.jar from central
Retrieving com/google/code/findbugs/jsr305/1.3.9/jsr305-1.3.9.jar from central
Retrieving org/clojure/google-closure-library/0.0-20160609-f42b4a24/google-closure-library-0.0-20160609-f42b4a24.jar from central
Retrieving org/clojure/google-closure-library-third-party/0.0-20160609-f42b4a24/google-closure-library-third-party-0.0-20160609-f42b4a24.jar from central
Retrieving org/clojure/data.json/0.2.6/data.json-0.2.6.jar from central
Retrieving org/mozilla/rhino/1.7R5/rhino-1.7R5.jar from central
Retrieving org/clojure/tools.reader/1.0.0-beta3/tools.reader-1.0.0-beta3.jar from central
Retrieving org/clojure/tools.nrepl/0.2.12/tools.nrepl-0.2.12.jar from central
Retrieving reagent/reagent/0.6.1/reagent-0.6.1.jar from clojars
Retrieving garden/garden/1.3.2/garden-1.3.2.jar from clojars
Retrieving cljsjs/react/15.4.0-0/react-15.4.0-0.jar from clojars
Retrieving cljsjs/react-dom/15.4.0-0/react-dom-15.4.0-0.jar from clojars
Retrieving cljsjs/react-dom-server/15.4.0-0/react-dom-server-15.4.0-0.jar from clojars
Retrieving clojure-complete/clojure-complete/0.2.4/clojure-complete-0.2.4.jar from clojars
~/gadfly/temp/minimal-garden-bug$ lein garden auto
Compiling Garden...
Could not find artifact ns-tracker:ns-tracker:jar:0.2.2
This could be due to a typo in :dependencies or network issues.
If you are behind a proxy, try setting the 'http_proxy' environment variable.

;; Added [ns-tracker "0.3.1"] to :dependencies vector in project.clj
~/gadfly/temp/minimal-garden-bug$ lein deps
Retrieving ns-tracker/ns-tracker/0.3.1/ns-tracker-0.3.1.pom from clojars
Retrieving org/clojure/tools.namespace/0.2.11/tools.namespace-0.2.11.pom from central
Retrieving org/clojure/java.classpath/0.2.3/java.classpath-0.2.3.pom from central
Retrieving org/clojure/java.classpath/0.2.3/java.classpath-0.2.3.jar from central
Retrieving org/clojure/tools.namespace/0.2.11/tools.namespace-0.2.11.jar from central
Retrieving ns-tracker/ns-tracker/0.3.1/ns-tracker-0.3.1.jar from clojars

~/gadfly/temp/minimal-garden-bug$ lein garden auto
Compiling Garden...
Compiling "resources/public/css/screen.css"...
Wrote: resources/public/css/screen.css
Successful

@gadfly361 thanks a lot for your response :-)
I got another workaround, which is to bump lein-garden version.


email_verified_at column reset to NULL

Laravel version
10
PHP version
8.2
Voyager version
1.7
Database
MySQL 8.0
Description
For some versions of Laravel, the users table contains the email_verified_at column.
Now, every time I edit a user in Voyager, the email_verified_at column is reset to NULL.
Steps to reproduce
Edit a user in Voyager
Expected behavior
That the column email_verified_at retains its value
Screenshots
No response
Additional context
No response

I just saw that there is the view -> users -> edit-add.blade.php resource
I proposed the PR #5845


css: User groups UI wobbles when hovering mouse over group name

Something is wrong with the user groups settings page's hover CSS, such that when you hover of the name of the group, the whole page wobbles a bit.  We should clean that up.

Can't reproduce, do you have a screenshot/GIF capturing this behavior?

That line that appears has some actual height and pushes things down.  This is in Chrome on Linux in case it matters.

Fixed in #8781


Add a shortcut for Close Pane

Right now the user needs to manually exit the pane.

Doesn't that already happen with Ctrl + W?

@varemenos Panes and Tabs are not the same thing. Tabs are the top-level entity, that may host many panes. When you open a new tab, it has one pane in it by default. This pane can be split into many panes that all occupy the same tab. Take a look at this spec for more details.

Idea: Let's make Ctrl+W "ClosePane" by default, and closing the last pane closes the tab. Include  a possibly-unbound-by-default "CloseTab". :smile:

Idea: Let's make Ctrl+W "ClosePane" by default, and closing the last pane closes the tab. Include a possibly-unbound-by-default "CloseTab". 😄

I like this idea SO MUCH that I'm going to do it next in my list of panes work.


Set up server API requests

Get the server making API requests once we find a food API(s).

Making requests


Definition for SkyWay

I added skyway/skyway.d.ts.
I also checked these pages.

https://www.npmjs.com/package/skyway
http://bower.io/search/?q=skyway

I mistook and included unrelated commit logs.
I closed it and opened new one.
Sorry.


Allow msg.userProperties to have number values

fixes #4899

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Casts numerical values for MQTT user properties to strings rather than just drop them.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Hmmmm "Casts numerical values for MQTT user properties to strings rather than just drop them."
We deliberately stuck with the oasis spec here - permitting only string:string key pairs.
https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901116

Followed by a UTF-8 String Pair. The User Property is allowed to appear multiple times to represent multiple name, value pairs.

Are we sure we want to go down this rabbit hole?  Are we not inviting folk to ask for for bools and buffers and objects to be flattened too?

@Steve-Mcl then we need to add validation to the field and log we are dropping them

@Steve-Mcl how about we just run EVERYTHING through JSON.stringify()?

yes, I mean each value

@Steve-Mcl I see you've posted to NR Slack about this, but I still think we should fix it as described above

Yup. I was explaining the history behind the decision, not that we wont do anything about it (and included a link to this PR for those following along in slack)


[forwardport of #2553] StatefulSet "Service Name" required, but not marked

This PR addresses issue #4811 by making 'Service Name' a required field when creating a StatefulSet
To test this pr

From your cluster navigate to Workload > StatefulSets
Click the Create button
The 'Service Name' field should now have a red 'required' asterisk

What do you mean by forwardport in the title?

What do you mean by forwardport in the title?

I copied the issue title. Removed now for clarity


rangeInclusive?

I frequently find myself using d3.range and desiring an inclusive range. I end up writing code like this:
d3.range(min, max, step).concat(max)

Since this appears rather cryptic, I thought I'd propose this clearer alternative:
d3.rangeInclusive(min, max, step)

This comes up at least once a month in my day to day work, I wonder if this is true for others as well.
Anyone else think this would be a useful addition to d3-array?

I usually do something like d3.range(min, max+0.001) :)

Closing this issue due to inactivity. Please do not hesitate to add a comment or reopen the issue if you think it is still worth pursuing.
PS: I think I like d3.range(min, max, step).concat(max) better, because it's more explicit (one less documentation item to know). Also I'd favor documenting d3.ticks(0,1,1000) which covers half the use cases.

We could also introduce a linspace method as in numpy. It functions more like d3.ticks, except it doesn’t attempt to produce human-readable values.
https://numpy.org/doc/stable/reference/generated/numpy.linspace.html


how to properly type the reducer

Related to https://github.com/supasate/connected-react-router/issues/173
versions:

connected-react-router 5.0.1
react 16.6.3
react-router 4.4.0-beta.6
redux 4.0.1
react-redux 5.1.1

I'm trying to declare my root state but I keep getting errors on History which I haven't been able to resolve after hours.
reducer.ts
const persistConfig: PersistConfig = {
  key: "root",
  storage: localStorage,
};

export type RootState = ApiState &
  FirebaseState & {
    router: Reducer<RouterState, LocationChangeAction>;
  };

// connected-react-router v5 requires exporting a function accepting history
const createRootReducer: Reducer<RootState> = (history?: History) =>
  persistReducer(
    persistConfig,
    combineReducers({
      api,
      auth,
      firebase: persistReducer(
        {
          key: "firepersist",
          storage: localStorage,
          stateReconciler: hardSet,
        },
        firebaseReducer,
      ),
      router: connectRouter(history),
      ui,
      ...otherReducers,
    }),
  );

export default createRootReducer;

type check
$ tsc --project tsconfig.json
src/reducers/index.ts:52:7 - error TS2322: Type '(history?: History<any> | undefined) => Reducer<{ application: any; contact: any; faq: any; mediaList: any; releases: any; api: {}; auth: { isLoaded: boolean; isEmpty: boolean; userId: any; }; firebase: any; router: {}; ui: any; } & PersistPartial, AnyAction>' is not assignable to type 'Reducer<RootState, AnyAction>'.
  Types of parameters 'history' and 'state' are incompatible.
    Type 'RootState | undefined' is not assignable to type 'History<any> | undefined'.
      Type 'RootState' is not assignable to type 'History<any> | undefined'.
        Type 'RootState' is missing the following properties from type 'History<any>': length, action, location, push, and 7 more.

52 const createRootReducer: Reducer<RootState> = (history?: History) =>
         ~~~~~~~~~~~~~~~~~

src/reducers/index.ts:66:29 - error TS2345: Argument of type 'History<any> | undefined' is not assignable to parameter of type 'History<any>'.
  Type 'undefined' is not assignable to type 'History<any>'.

66       router: connectRouter(history),
                               ~~~~~~~

Found 2 errors.

error Command failed with exit code 1.

If I cannot solve this issue, I'll change Reducer<RootState> → Reducer and persistReducer(…) → persistReducer(…) as any, but this wouldn't be sane becore my exported RootState wouldn't guarantee that the expected state is correct.
I understand that history is undefined at the beginning. Do you know of a way to say "that's ok" this way ?

Couple things that might help:

RootState["router"] should just be RouterState
I don't think you want an optional history when connecting the router
Make sure you're using createBrowserHistory and using the appropriate History type.

I'm not sure if it's the best solution, but it seems like combineReducers only want a function that returns a Reducer (given by redux). It works if I explicitly cast the result as Reducer like that:
router: connectRouter(history) as Reducer,

I'm not sure if it's the best solution, but it seems like combineReducers only want a function that returns a Reducer (given by redux). It works if I explicitly cast the result as Reducer like that:
router: connectRouter(history) as Reducer,

Type 'Function' is not assignable to type 'Reducer<{}, AnyAction>'

src/client/store/reducers.ts:17:3 - error TS2322: Type '<S>(reducer: Reducer<S, AnyAction>) => Reducer<S, AnyAction>' is not assignable to type 'Reducer<Reducer<{}, AnyAction>, AnyAction>'.
  Types of parameters 'reducer' and 'state' are incompatible.
    Type 'Reducer<{}, AnyAction> | undefined' is not assignable to type 'Reducer<{}, AnyAction>'.
      Type 'undefined' is not assignable to type 'Reducer<{}, AnyAction>'.

17   router: connectRouter(history),
     ~~~~~~

  src/client/store/reducers.ts:17:3
    17   router: connectRouter(history),
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from property 'router' which is declared here on type 'ReducersMapObject<{ constructor: {}; toString: string; toLocaleString: string; valueOf: Object; hasOwnProperty: boolean; isPrototypeOf: boolean; propertyIsEnumerable: boolean; account: { isFetching: boolean; ... 9 more ...; addresses: null; } | { ...; } | { ...; } | { ...; }; ... 8 more ...; router: Reducer<...>; },...'

Please assist!

The best way I ended up finding is to use the typesafe-actions library to property type both your actions and your reducer @kahurangitama.
You can find an example here: https://github.com/Favna/ReactTSDemo/blob/master/src/store
(note: also navigate to ProjectRoot/typings/typesafe-actions/index.d.ts which gets overwritten with the proper RootActions as per the lib's requirement for typesafe reducer)


Errors when refining from Semanticscholar and Crossref

Hi,
first - thank you for this great python module! It is really helpful, I am using it to refine and evaluate a bibtex database.
I have been trying to refine my bibtex file with other databases. It works pretty well with scopus.
Crossref unfortunately gives me an error with Python 3.10 from within the spyder editor on macOS:
File /opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/spyder_kernels/py3compat.py:356 in compat_exec
  exec(code, globals, locals)

File ~/process/process.py:124 in <module>
  collectData(bibtexIn)

File ~/process/process.py:118 in collectData
  refinedDB = docsFound | refinedDB

File ~/process/litrev/lib/python3.10/site-packages/litstudy/types.py:304 in __or__
  return self.union(other)

File ~/process/litrev/lib/python3.10/site-packages/litstudy/types.py:204 in union
  left, right = DocumentSet._intersect_indices(self, other)

File ~/process/litrev/lib/python3.10/site-packages/litstudy/types.py:139 in _intersect_indices
  if id.matches(needle):

File ~/process/litrev/lib/python3.10/site-packages/litstudy/types.py:414 in matches
  return fuzzy_match(self._title, other._title)

File ~/process/litrev/lib/python3.10/site-packages/litstudy/common.py:58 in fuzzy_match
  return canonical(lhs) == canonical(rhs)

File ~/process/litrev/lib/python3.10/site-packages/litstudy/common.py:37 in canonical
  key = unidecode(key).lower()

File /opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/unidecode/__init__.py:60 in unidecode_expect_ascii
  bytestring = string.encode('ASCII')

AttributeError: 'list' object has no attribute 'encode'

The interface to semanticscholar just does not return any results (despite the DOIs being in the database):
158 papers to be evaluated
  0%|          | 0/158 [00:00<?, ?it/s]WARNING:root:failed to retreive 10.1080/13602365.2017.1376342: Paper with id paper=10.1080/13602365.2017.1376342 not found

Best, Lars.

Thanks for your question! I'll look into these issues.

The two issue should now have been fixed. Could you check if you code now works so that I can close this issue and make a new release of litstudy?
You can update litstudy to the latest master using pip:
  pip install git+https://github.com/NLeSC/litstudy

Thank you, this apperantly solved the problem with both data-sources! Best, Lars.

Thanks for report! Let us know if you run into any more issues. I'll close this issue.


Next.js 7 / Webpack 4 compatibility

This plugin oddly does not work with Next 7. I spent multiple hours trying to figure out what was going wrong without success.
Refs:

Next 7 release: https://github.com/zeit/next.js/releases/tag/7.0.0
Did rules include/exclude behavior change in Webpack 4? webpack/webpack#8077

I still do not know if the problem comes from Webpack or Next's custom Babel loaders.
Any hints/help would be highly appreciated.

Temporary solutions:

https://github.com/martpie/next-plugin-transpile-modules/issues/1#issuecomment-427749256
https://github.com/martpie/next-plugin-transpile-modules/issues/1#issuecomment-425839242

Oh is it? I got errors when using it with Next's withTypescript.
I should write tests for both scenarios, it should not be too hard.

And I also saw this comment saying it was not working: https://github.com/zeit/next.js/pull/3732#issuecomment-423302026

I don't think this has something to do with TS. I  don't use TS and it doesn't work for me either with Next 7.

I don’t think the problem comes from Webpack but Babel... I will have to dive into Next’s build codebase.
If anyone has interesting inputs/advices... feel free! 😅

Ok I realized I need to wrap the externals with a options.isServer check like
https://github.com/zeit/next.js/blob/3a059688a8a0e10342ce697c89a7faebbeca9629/build/webpack.js#L31-L33
Creating PR.

node_modules/
  want_to_transpile/
    node_modules/
      dont_want_to_transpile/
  third_party/
  next/

So I think this might be the problem. My dont_want_to_transpile module which is a dependency of want_to_transpile module is being bundled by webpack. (Which it should not).
Now that dont_want_to_transpileis requiring third_party module which is not bundled (expected)
But it is expecting that third_party module be transpiled.
But at bundling time, it resolved to a non-transpiled (esm) source code. So it assumed that path and saved it while bundling dont_want_to_transpile module.
So I think webpack needs to give us fine grained control over which bundling want_to_transpile and marking want_to_transpile/node_modules/* as external.

And as to why my build works when I comment externals code is because my want_to_transpile module also has es2015 code published in dist.
But for a module which does not publish es2015 code, commenting externals would not work. So my solution wont-fix.

I faced some problems with node_modules regexs too. If I want to transpile shared, node_modules/any-other-module/shared will be transpiled.
I can replace that with custom functions instead of Regex. It should make the code more readable too. But I still get the transpilation problem.

I have the same issue, but for striping "flow" types in a monorepo:
- monorepo root
   - shared // <- trying to transpile this
   - web
   - - next.config.js

Looks like it doesn't pick up the correct ".babelrc" because of a breaking change on how babel looks for config.

@morajabi So are you saying this is a problem in the user's setup or Next's setup?

Not user setup most likely. I think we need to figure out a way to adopt to the new Babel behaviour.

Create react app version 2 is transpiling npm packages. We can learn from
there.

It does not pick the .babelrc. As a temporary workaround you can add your babel presets / plugins like this:
const withTranspileModules = require('next-plugin-transpile-modules')
module.exports = withTranspileModules({
  transpileModules: ['@my_namespace'],
  webpack: (config, { defaultLoaders }) => {
    defaultLoaders.babel.options.presets = ['@babel/flow']
    defaultLoaders.babel.options.plugins = [
      ['react-native-web', { commonjs: true }],
    ]

    return config
  },
})

Similar to https://github.com/zeit/next.js/issues/5288

Thanks @reicheltp @martpie, the temporary workaround worked perfectly for me. (monorepo)

Ok, after countrless hours reading changelogs and poorly documented Babel 7 changes, I managed to transpile a local symlinked package from node_modules. The secret is to declare a babel.config.js with some rules in it.
I do not like it because it is just rewriting config files that should be done by Next already, but waiting for a cleaner solution, I'll update the package and the documentation soon.

For those interested, the quick fix:
// babel.config.js (in your Next.js folder)
module.exports = (api) => {
  api.cache(true);

  const presets = [
    'next/babel',
    '@zeit/next-typescript/babel'
  ];

  return {
    presets
  };
}

I am checking if I can do this automatically via the plugin.

Any updates? I tried make a fix as shown at https://github.com/martpie/next-plugin-transpile-modules/issues/1#issuecomment-427749256, but still got an error:
Im use propTypes from some child component to declare parents and got Cannot read property '__propName__' of undefined

@Mtnt Do you have a piece of code to share so I can reproduce this error?

@martpie
It`s an assignment of props for npm module "@sample-ns/controlls"
const { type: controlType, ...controlProps } = Control.propTypes;
const { type: groupType, ...groupProps } = Group.propTypes;

Checkbox.propTypes = controlProps;
Radio.propTypes = controlProps;
RadioGroup.propTypes = groupProps;
CheckboxGroup.propTypes = groupProps;

next.config.js
module.exports = withPlugins([
  [
    withTM,
    {transpileModules: ['@sample-ns']},
  ],
]);

So, it`s transformed to
var _Control$propTypes = control.propTypes,
    controlType = _Control$propTypes.type,
    controlProps = _objectWithoutProperties(_Control$propTypes, ["type"]);

var _Group$propTypes = group.propTypes,
    groupType = _Group$propTypes.type,
    groupProps = _objectWithoutProperties(_Group$propTypes, ["type"]);

and fires an exception on _Control$propTypes.type
is it enough?

Have you checked if it was working well with Next.js 6?

yeah, it did

@martpie wow, suddenly - it did not oO. I missed a commit that added some changes. Sorry...
However, there is still a problem... that prop types did not cropped. I created the 'type' variable only for omitting it in Checkbox.propType and expected that all code will be removed.
Any advice for fast fix?

FWIW here's an example that shows transpiling working with Next 7, but not watching.
https://github.com/curran/nextjs-esm-example/pull/4
Struggling to get watching to work.
Tracked as #5


GH-15173: [C++][Parquet] Fixing ByteStreamSplit Standard broken

Rationale for this change

This patch fixes bugs in BYTE_STREAM_SPLIT. It enforce the parquet ByteStreamSplit not to use padding, and force using sizeof(data) / sizeof(T) as num-of-values.
What changes are included in this PR?

Add num-of-values in ByteStreamSplit
Add testing

Are these changes tested?

Yes
Are there any user-facing changes?
No

Closes: #15173

@pitrou @wgtmac @wjones127 PTAL

Comment fixed


Added XLM-Roberta large and LaBSE

Added multilingual base line models.

@KennethEnevoldsen as per #81 we might want to consider using CLS pooling instead of mean for XLM-R models, what do you think?

I would just load in with sentence transformer (we just want the naive defaults here). I believe it is mean, which I also suspect will do better. Especially as the CLS token is used during pre-training XLMR as I recall.

Okay then we just keep it as is. Can you review the code real quick @KennethEnevoldsen ?


question concerning labeling the data

Hello, thanks for your great work and offered code.
i'm working on a school project and i  want to use the SUBDIVNET code to train my data, but there are some points i did not understand..
in each .obj file there are 3 indexes:

raw_labels: each item here represents a label of a face in the original data.
sub_labels:  each item here represents a label of a face in the data after remeshing it   (after applying datagen_maps.py on it )
raw_to_sub: this i don't understand what does it represent, and what is its role

another thing i didn't understand: length of  raw_labels and sub_labels is 13776 but number of faces in each object is  16384.
so if    raw_labels and sub_labels are representing the label of each face why they don't have same length as faces.
so can you please explain to me how can i preprocess step by step my data to before feeding it  to the subdivnet?
how can i make each object have the exact number of faces as in your input data (16384)
and how to label my data, and if you can recommend me a tool i can use!
thank you in advance

Sorry for the late response.
https://github.com/lzhengning/SubdivNet/issues/9#issuecomment-885535277 may answer the first question.
The later problem should not occur. Because the length of raw_labels should be the same with the number of faces in the raw mesh, and length of sub_labels should be that of the remeshed shape, which is the direct input of SubdivNet. In your case, there ought to be 16384 sub_labels.
Please have another look at the json file. You can further provide me the file if I am wrong.
If you want to remesh your own data, please see the corresponding section in README. The paper also provides a detailed discussion about the remeshing algorithm. To precess shapes to 16384 (= 256 * 4^3) faces, the base mesh should be 256, and the subdivision depth is 3.

thank you for making things clear
things are clear now, that's close the issue


feat: adding agent command

Signed-off-by: 6za<EMAIL_ADDRESS>

k8s upgraded


Performance issue calculating sha256 for generic packs

Describe the problem
We've spotted a few servers taking several minutes to start, seemingly hanging on [init] Checking Forge version information.
After enabling debug to take a closer look, it seems the startup is hanging on this command for a significant amount of time sha256sum -c /data/.generic_pack.sum --status
Removing the sum file appears to allow the startup to proceed much faster.
Container definition
No response
Container logs
No response

Ah yes, I could see that being a problem. I need to revisit that section and see if the checksum process is overkill there.

The latest image now uses sha1 instead of sha256 which should make it faster, but not dramatically faster.
Let me know if you're interested in a variable to indicate skipping of generic pack update checks in general.

...I can also tag the image if that helps for your verification.

...I can also tag the image if that helps for your verification.

Assuming it'll be on java8-openj9?

Yes. I now have it build all of the variants (except the old java8 one) with each push to master.

Seems to be relatively faster @itzg
2022-02-02T21:01:49Z [init] Checking Forge version information.
2022-02-02T21:03:08Z [init] Disabling whitelist functionality

It could do with some additional logging to see what's actually happening without enabling debug there whenever you have a sec, please. I don't recall it taking very long in the past, even a 1-minute check is surprising, for us a flag to disable the check would be handy as the bootstrapping of a generic pack is quicker than this check.

I have now added options to skip/force, along with more logs : https://github.com/itzg/docker-minecraft-server/pull/1333


Custom instrumentor for debugging http client requests when DEBUG=true

Less noisy than EXCON_DEBUG. Less intrusive than #1432

@nevalla could be in 1.0.3 imho, only affects when DEBUG=true.


Unit testing

Right now there are only acceptance tests that verify the final build has reasonable content in it, which works well to guard against major breakage but leaves out some specific cases (see #5, for instance).
Adding some unit testing in node-land for the actual addon code would go a long way toward preventing subtle regressions. Might consider something along the lines of how ember-cli-mirage tests similar functionality.

Closed via b614585e7f496e37b08eeba66ca4c806ded09814


[Feature]: automate actions on html elements and extract data (web scraping)

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
It would be great if I can create a web application for web scrapping. For example I get html element class/id/xpath then automate the tasks and store certain values that meat certain condition class/id/xpath. I write the logic steps using logical flow chart
Storage can be google sheets or csv or else. example: app.dexi.io

Why should this be worked on?
It is common request from my clients to build automation logic for certain tasks on web sites whether to reduce consumed time or collect data for analysis

Hi @izac3d ! I really appreciate the effort you took to raise this issue. However, Appsmith isn't very well suited for building webscrapers. We do plan on introducing workflows in the future here #12589 so you can track that issue for updates but we don't have it planned any time soon


Add Model Comparison Functionality to NotebookCollection

Model comparability with the plot argument of a NotebookCollection object could be improved.
At the moment, models must be cycled through in order to compare plots. See documentation here for example. Perhaps it would benefit to add additional functionality that allows side by side comparisons, similar to that described in the advanced matplotlib usage guide here.
Things to consider: limitations on the number of models that can be plotted simultaneously (formatting issues), whether plotting models simultaneously is affected by window size, the degree to which the quality of individual plots is affected (if axes/labels/symbols get too small, perhaps we could reevaluate the inputs to improve visibility/model quality).

this is a great idea. I actually released something like this, but only implemented it for confusion matrix: https://sklearn-evaluation.readthedocs.io/en/latest/user_guide/compare.html
the idea is that to compare two models you could do:
# plot for model one
plot_one = ...

# plot for model two
plot_two = ...

# compare models in a single plot
plot_one + plot_two

We could implement the same logic for the other plots we have, and then incorporate that into NotebookCollection. thoughts? Do you want to give this a try?

@hcho1111 let's take this right after the blog is ready to publish

we implemented some of these features as part of the plot module


Disable Surveys & Disable Longitudinal buttons

Cannot determine whether surveys "dialog" will appear unless you look at the surveys page.

https://github.com/aldefouw/redcap_cypress/blob/v11.1.5/cypress/support/step_definitions/survey.js#L178-L211


Issue with updating submodules

After running:
git submodule update --init --recursive

Recived:
fatal: No url found for submodule path 'boost/libs/accumulators' in .gitmodules

Seems the issue occurs from the submodules in libs not being properly made. Removing boost and re-cloning recursively now.

Fixed by removing boost folder
rm -r boost

then re cloning using
git clone --recurse-submodules git@github.com:boostorg/boost.git


java.util.ConcurrentModificationException at org.osmdroid.tileprovider.MapTileProviderBase.mapTileRequestFailed(MapTileProviderBase.java:184)

Issue Type
[ ] Question
[x] Bug
Description and/or steps/code to reproduce the problem
java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:346)
at java.util.LinkedHashMap$KeyIterator.next(LinkedHashMap.java:366)
at org.osmdroid.tileprovider.MapTileProviderBase.mapTileRequestFailed(MapTileProviderBase.java:184)
at org.osmdroid.tileprovider.MapTileProviderArray.mapTileRequestFailedExceedsMaxQueueSize(MapTileProviderArray.java:167)
at org.osmdroid.tileprovider.modules.MapTileModuleProviderBase$1.removeEldestEntry(MapTileModuleProviderBase.java:124)
at java.util.LinkedHashMap.addNewEntry(LinkedHashMap.java:189)
at java.util.HashMap.put(HashMap.java:404)
at org.osmdroid.tileprovider.modules.MapTileModuleProviderBase.loadMapTileAsync(MapTileModuleProviderBase.java:151)
at org.osmdroid.tileprovider.MapTileProviderArray.runAsyncNextProvider(MapTileProviderArray.java:227)
at org.osmdroid.tileprovider.MapTileProviderArray.mapTileRequestExpiredTile(MapTileProviderArray.java:179)
at org.osmdroid.tileprovider.modules.MapTileModuleProviderBase$TileLoader.tileLoadedScaled(MapTileModuleProviderBase.java:299)
at org.osmdroid.tileprovider.modules.MapTileModuleProviderBase$TileLoader.run(MapTileModuleProviderBase.java:345)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
My partner was trying my app and the map froze... after a while we got the stack above.
I am at c245bcd129463a344606f24213acd4471dd5d35c
#906 restoring polyline addPoint function Alex O'Ree 10/26/19 12:27 PM

@pasniak Is that systematic? I assume that happens at the moment when you add a handler with MapTileProviderBase.getTileRequestCompleteHandlers().add(), am I right? Or when you change somehow your activity, like landscape/portrait switch, when you add the handlers in onCreate?
I don't think it's linked to #906.

I think this is the first time I see this. We'll check. I do not have a handler added to TileRequestCompleteHandlers (I do  have some commented out code which I totally do not remember why has been added for one layer :-)
// tileRequestCompleteHandlers.add(tileRequestCompleteHandler)
The rotation is enabled yes but we think not much was happening because the device was on the laying on a desk while the user was touch dragging the map.

@pasniak Are you sure you don't even use setTileRequestCompleteHandler? If not, there's no reason why there should be concurrency.
That being said, something is wrong in the code, as nothing prevents developers to add handlers whenever they want, while the tiles are being downloaded, which can cause concurrency issues.

I only create MapView with context, and I do not break in setTileRequestCompleteHandler. I see SimpleInvalidationHandler attached when mapview is created. It has the MapView ref which it invalidates on Messages with MAPTILE_SUCCESS_ID. It gets attached/detached ok in the lifecycle.

@pasniak think you can give this commit a try? i am not too sure how to reproduce it

Fixed by #1486.


Features/add meta tags to maud extras

Locking Cargo dependencies since master has [build error] it becomes tedious to work with maud_extras crate.

Adding Javascript element analogous to Css

Adding meta tags struct which generate  and meta description

I have Form struct ready, will add in a few days.

@lfairy updated not sure how to go with Meta 'static lifetime since if user will want dynamic meta tag it might be cumbersome to use, what do you think ?

@ernestas-poskus 'static is anything that has a lifetime that is as long as the program (at least), so String for example is 'static: https://is.gd/kJIEho

@ernestas-poskus This definition:
pub struct Meta<T: AsRef<str>, U: AsRef<str>>(pub T, pub U);

would be fine with me.
It's okay to have more type parameters here, since it will all be inferred for the user anyway.

updated

Updated everything according to last comments

LGTM, thanks!

Thank you for comments, makes me improve ! :+1: :octocat:


Crash java.lang.StackOverflowError: mouseClicked event handler

It crashes when clicking on the estimates save changes.

Going to need more detail than that. Could you attach the crash log?

Going to need more detail than that. Could you attach the crash log?

Going to need more detail than that. Could you attach the crash log?

Going to need more detail than that. Could you attach the crash log?

crash-2021-01-03_16.45.35-client.txt
here

crash-2021-01-03_16.45.35-client.txt
here


Accept prompt as a list.

This accept prompts as a single string even if they are not in quotes.
This doesn't affect the existing behavior. It just adds to option to input prompts without quotes.
sgpt -se update my system
instead of
sgpt -se "update my system"

Thank you for the PR.
I believe using multiple arguments just to pass words and then join them together into a single string is not an ideal practice. It can potentially lead to confusion for some people. While I understand that some people may prefer this method, I personally find it not very useful.


link-to-changelog-file: merge into the Releases|Tags pill

Description
Before

After

The tooltip explains it enough, I think.
This change will help make room for #7932
Example URLs
https://github.com/jestjs/jest/releases

May I try?

Sure