1217 AvroSchemaRegistryClientMessageConverter registers schema formats inconsistently.

1217 AvroSchemaRegistryClientMessageConverter registers schema formats inconsistently.

ugh missed checkstyle issue

Codecov Report

Merging #1220 into master will decrease coverage by 0.4%.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##             master    #1220      +/-   ##
============================================
- Coverage     64.59%   64.19%   -0.41%
  Complexity      804      804
============================================
  Files           129      129
  Lines          3692     3701       +9
  Branches        529      529
============================================
- Hits           2385     2376       -9
- Misses         1034     1057      +23
+ Partials        273      268       -5

Impacted Files
Coverage Δ
Complexity Δ

...am/schema/avro/AvroMessageConverterProperties.java
58.33% <33.33%> (-3.58%)
9 <1> (+1)

...ma/avro/AvroMessageConverterAutoConfiguration.java
62.5% <75%> (+3.4%)
3 <0> (ø)
:arrow_down:

...ingframework/cloud/stream/schema/ParsedSchema.java
81.81% <80%> (-18.19%)
5 <1> (ø)

...avro/AvroSchemaRegistryClientMessageConverter.java
63.2% <85.71%> (+0.59%)
22 <1> (+1)
:arrow_up:

...ud/stream/binder/AbstractMessageChannelBinder.java
41.75% <0%> (-5.13%)
20% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0463f79...870d6d9. Read the comment docs.

I am not so sure about this one yet

Why do we care about the visual format? If I understand correctly it doesn't affect functionality of registration, retrieval or applying the schema. If so why, this is purely a question of visual representation, correct?
If we were to go with "prettyPrint", why should we than do it always to make it "consistent"?

What is stored in the DB?
If I am not incorrect, the representation is stored in the DB without modification.
As a user I would want them stored in a consistent fashion.

What is the inconsistency? Do you want data to be stored in pretty print? Is that the case? Inconsistency to me is if data is malformed. Don't even start on the whole human readable discusion with me...

@jmax01 Jus to clarify what @viniciusccarvalho said, presentation of the schema is out of scope  of schema  application, storage and retrieval . Let's assume there is some UI to display schemas, then that responsibility would fall into such UI and as far as I know there are plenty of browser plugins and other tools to support that.
So, I'll reject this one.
In any event thank you for your continuous contributions to the framework!

Here is the inconsistency:
AvroSchemaRegistryClientMessageConverter.afterPropertiesSet:
    //with print pretty
    this.schemaRegistryClient.register(toSubject(schema), AVRO_FORMAT,
							schema.toString(true));

AvroSchemaRegistryClientMessageConverter.resolveSchemaForWriting:
  //The ParsedSchema.representation is not print pretty
  SchemaRegistrationResponse response = this.schemaRegistryClient.register(
  toSubject(schema), AVRO_FORMAT, parsedSchema.getRepresentation());

If you aren't going to allow configuration at least make it consistent, is that too much to ask?
I would recommend not storing them pretty printed to minimize overhead (generating, parsing, wire, storage, etc).

@jmax01 the above is indeed a valid point with regard to inconsistency and the one I missed.
But what I propose is to actually call a no arg toString.
Feel free to submit another PR for that if you agree.
Once again, thank you for helping out with this

Sure will do.

@jmax01 and just to end it on the fun note I liked the If I am not incorrect ;) took me a while to process it ;)


refactor table and connect to websockets

Created new table component, trimmed fat from dashboard
FYI - Not sure which Homecard is most recent


bug: trpc mutate not working with app directory

Provide environment information
System:
OS: macOS 14.1.1
CPU: (12) arm64 Apple M2 Pro
Memory: 349.92 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.1/bin/yarn
npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
pnpm: 8.10.5 - /opt/homebrew/bin/pnpm
Describe the bug
I've ran the @latest install for a t3 app with trpc enabled, tailwind disabled, nextauth disabled, prisma enabled and experimental app routing enabled but when I attempt to add an example post nothing happens. It doesn't make any network request or attempt to hit the mutate on the server.
Reproduction repo
https://github.com/jmcelreavey/next
To reproduce
Attempt to add a post
Additional information
No response

@jmcelreavey You're having this issue when you try to initialize local runtime right? 'npm run dev'? I think i'm running into the same issue. [I need to take a look at my .env and .env.example files].

Were you connected to the network at that time? Because React Query by default will not fire mutation unless you have network connection

React Query does not allow mutations while offline by default. Other than that, mutations work in @latest for the specified list of packages. The linked example does not seem to have been scaffolded with Create T3 App. If you have a more specific reproduction, please feel free to open another issue.


disable snippet is not synced

Version: 1.76.2 (Universal)
Commit: ee2b180d582a7f601fa6ecfdad8d9fd269ab1884
Date: 2023-03-14T17:54:09.061Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.3.0
Sandboxed: No

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Also, this can be exported when create a profile from a exists profile

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Fix simple icons color fill

Category:
One of: Bugfix
Overview
I was having problems with the SimpleIcons applying a color tint because the icons being loaded as SVGs via URL were wrapped in an object thus not allowing css styling to apply.
By including the node package for simple-icons we can directly access the SVG and PATH in order to be able to set the fill to currentColor
New Vars (if applicable)
Dependency added on simple-icons:^5.12.0
Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

[x] All changes are backwards compatible
[x] All lint checks and tests are passing
[x] There are no (new) build warnings or errors
[ ] (If a new config option is added) Attribute is outlined in the schema and documented
[x] (If a new dependency is added) Package is essential, and has been checked out for security or performance
[ ] Bumps version, if new feature added

Looking good!
I guess the main reason I didn't use the simple-icons package in the first place, is because it's 10.5 MB

Looks like the deploy worked and then git had a failure.
And also the yarn lock change task looks like it's failing due to this:
https://github.com/Simek/yarn-lock-changes/issues/26

Looking good!
I guess the main reason I didn't use the simple-icons package in the first place, is because it's 10.5 MB

Yeah, that makes sense. I couldn't find another way of altering the color of the simple icons that didn't involve using javascript to inject into the object tags, which felt a bit more convoluted than it needed to be

Yeah I think the failure in the CI is a permissions thing, it works just fine for me locally so it should be all okay

Good fix- thank you for implementing :)
I'm going to merge it, but monitor performance because of the packages size. If it has any noticable impact on the app when Simple Icons are not being used, then I might need to find a different approach.


AP-1973 Convert substantive form to use new formbuilder

What
Link to story
Refactor /app/views/providers/substantive_applications/show.html.erb to use the new formbuilder.
Checklist
Before you ask people to review this PR:

[x] Tests and rubocop should be passing: bundle exec rake
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
[x] The PR description should say what you changed and why, with a link to the JIRA story.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

LGTM 💯

LGTM 💯


refactoring: move more work into Easy methods

Codecov Report

Merging #51 into master will decrease coverage by 2.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   89.22%   86.86%   -2.36%
==========================================
  Files           5        5
  Lines         297      297
==========================================
- Hits          265      258       -7
- Misses         32       39       +7

Impacted Files
Coverage Δ

src/Curl/Curl.jl
100.00% <ø> (ø)

src/Curl/Easy.jl
91.48% <100.00%> (+0.28%)
:arrow_up:

src/Downloads.jl
75.86% <100.00%> (-0.81%)
:arrow_down:

src/Curl/utils.jl
75.75% <0.00%> (-21.22%)
:arrow_down:

src/Curl/Multi.jl
91.66% <0.00%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bf4b6...ad9167d. Read the comment docs.


Set version 4.4.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
17 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.5%) to 89.509%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/oracles/oracles.py
2
89.27%

gnosis/eth/typing.py
2
83.33%

gnosis/protocol/gnosis_protocol_api.py
2
89.25%

gnosis/safe/api/relay_service_api.py
2
52.27%

gnosis/safe/safe.py
2
87.5%

gnosis/safe/safe_tx.py
2
90.53%

gnosis/eth/ethereum_client.py
5
86.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
3353

Relevant Lines:
3746

💛  - Coveralls


Install webhooks in main operator deployment

What type of PR is this?
/kind feature
What this PR does / why we need it:
The original reason for splitting the webhook out from the main
deployment (b432ee4) was that the cert-manager deployment was
unreliable. The problem was fixed (ec596ffe) but the webhook remained
separate so that installing cert-manager would be optional.
This change brings the webhook back into the main deployment.
Cert-manager is now required. The functionality provided by the webhook

profile bindings and profile recordings - are core features of the
operator and should not be optional. Since this operator is still in an
alpha state, relying on a third-party tool should be an acceptable
tradeoff for providing the full breadth of functionality with a
consistent, minimal deployment experience. We can reevaluate how to
manage webhook certs further down the road as this operator gains more
user adoption.

Which issue(s) this PR fixes:
Fixes #270
Does this PR have test?
n/a
Special notes for your reviewer:
The github issue this fixes is about making the webhook deployment configurable in code, but I found it more sensible to just combine them. The ability to configure the DaemonSet makes sense since not all features (selinux, seccomp, apparmor) will be applicable to and supported by the host system of every node. But it makes less sense to do the same with a Deployment, since it's just a web app.
Does this PR introduce a user-facing change?
The separate webhook deployment, which enabled the `ProfileBinding` and `ProfileRecording` resources, has now been merged into the main operator deployment manifest.

Working on getting the e2e tests to run locally so this may or may not be green yet...

Codecov Report

Merging #387 (3e5567c) into master (1bbe0e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   21.68%   21.68%
=======================================
  Files          13       13
  Lines         936      936
=======================================
  Hits          203      203
  Misses        725      725
  Partials        8        8

Flag
Coverage Δ

unittests
21.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbe0e0...3e5567c. Read the comment docs.

Working on getting the e2e tests to run locally so this may or may not be green yet...

The tests are flaky right now, @jhrozek was investigating the issue AFAIK

/retest

/retest

/retest

/retest
fatal error: runtime: cannot allocate memory seems unrelated

@cmurphy unfortunately this needs a rebase :upside_down_face:

/retest


To Update Next.js Version to Stable Release for App Router

What would you like to share or ask?
Hey @CBID2
I hope this message finds you well. I would like to bring to your attention an important matter regarding the Next.js version being used in the project. Currently, the project is relying on an outdated version of Next.js, which still includes the beta release of the app directory. It is crucial to update the Next.js version to a more recent release, specifically Next.js 13.4, where the /app router has been stabilized.
By updating the Next.js version, we can leverage the benefits of the latest stable release and ensure optimal performance, security, and compatibility with the evolving ecosystem. Furthermore, keeping the project up-to-date with the latest framework version will provide us with access to new features, improvements, and bug fixes.
I would be more than willing to take up the responsibility of updating the Next.js version of the project. As an experienced developer, I understand the significance of this task and can ensure a smooth transition by carefully addressing any potential compatibility issues and thoroughly testing the codebase. I am confident that this update will contribute to the overall stability and longevity of the project.
If you find my proposal acceptable, I kindly request that you consider assigning this task to me. I will promptly initiate the process and diligently follow the best practices for version control to ensure a seamless integration of the new Next.js release.
Thank you for your attention to this matter. I look forward to your response and the opportunity to contribute to the improvement of this project.
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

I'm a GSSoC 23 contributor.
I request you to label gssoc23 to this issue and would request you to assign it to me.

Done @s2sharpit

Hey, I have created the PR, please review it.


Contact Us in navbar fixed

The Navbar showed list of items that direct user to the specific parts of webpage. The contact us element didn't work properly. I have fixed the path that directs user to contact us page.

I am closing this PR. Unfortunately, due to a wrong PR that got merged, the website's structure became disorganized. We had to revert to the old code. Kindly pull the latest changes and create a new PR for your issue, as your current PR shows conflicts. I apologize for the inconvenience and appreciate your understanding. Looking forward to your new PR soon. Thank you! 😊


执行app.py文件后报错（'MainExecutor' object has no attribute 'store'）

环境：Agently==<IP_ADDRESS>
报错：Exception: 'MainExecutor' object has no attribute 'store'
日志： 'MainExecutor' object has no attribute 'store'
Traceback (most recent call last):
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 318, in _exec_chunk_with_dep_core
exec_res = chunk_executor(input_value, self.runtime_state.user_store)
File "/Users/wenhaoyao/Downloads/Agently-Daily-News-Collector-main/workflows/main_workflow.py", line 59, in generate_columns_executor
column_data = start_column_workflow(
File "/Users/wenhaoyao/Downloads/Agently-Daily-News-Collector-main/workflows/column_workflow.py", line 172, in start
return column_workflow.executor.store.get("final_result")
AttributeError: 'MainExecutor' object has no attribute 'store'. Did you mean: 'start'?
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/wenhaoyao/Downloads/Agently-Daily-News-Collector-main/app.py", line 34, in
main_workflow.start(
File "/Users/wenhaoyao/Downloads/Agently-Daily-News-Collector-main/workflows/main_workflow.py", line 110, in start
main_workflow.start()
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/Workflow.py", line 155, in start
return run_async(self.start_async(start_data, storage=storage))
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/utils/runner.py", line 33, in run_async
return future.result()
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/concurrent/futures/_base.py", line 451, in result
return self.__get_result()
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
raise self._exception
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/utils/runner.py", line 22, in runner
result = loop.run_until_complete(coro)
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/Workflow.py", line 150, in start_async
res = await self.executor.start(executed_schema, start_data, storage=storage)
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 57, in start
await self._execute_main(executed_schema.get('entries') or [])
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 127, in _execute_main
await asyncio.gather(*entry_tasks)
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 120, in execute_from_entry
await self._execute_partial(entry, branch_state)
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 151, in _execute_partial
has_been_executed = await self._execute_single_chunk(
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 197, in _execute_single_chunk
await self._execute_single_chunk_core(
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 225, in _execute_single_chunk_core
exec_res = await self._exec_chunk_with_dep_core(chunk, single_dep_map)
File "/Users/wenhaoyao/miniforge3/envs/agently/lib/python3.10/site-packages/Agently/Workflow/MainExecutor.py", line 326, in _exec_chunk_with_dep_core
raise Exception(e)
Exception: 'MainExecutor' object has no attribute 'store'

这个项目使用的Agently版本是Agently==<IP_ADDRESS>，需要手动回退
Agently 3.4版本重构了Workflow的底层


[js style] Fix extra semicolons

Fix a few occurrences of extra semicolons in JS code. This is found via ESLint.
This is a pure refactoring commit.

thanks! I'm wondering why it doesn't include mock-chrome-api.js 🤔

looks like semicolons are fine in that file currently. unless there are more bad surprises in that file!


Deprecations warnings

Hi, I have deprecations warnings that I can't find.
I've scanned my project using PhpStorm to find deprecation usages without success.
Is TwigView plugin up to date with CakePhp deprecations ?
Thanks.
src/Template.php:529
The ArrayAccess methods will be removed in 4.0.0.Use getParam() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 529 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.
src/Template.php:595
Accessing query as a property will be removed in 4.0.0. Use getQuery() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 595 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.
src/Template.php:604
Accessing `query` as a property will be removed in 4.0.0. Use request->getQuery() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 604 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.
src/Template.php:529
The ArrayAccess methods will be removed in 4.0.0.Use getParam() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 529 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.
src/Template.php:595
Accessing query as a property will be removed in 4.0.0. Use getQuery() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 595 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.
src/Template.php:604
Accessing `query` as a property will be removed in 4.0.0. Use request->getQuery() instead. - /Applications/MAMP/htdocs/my_app/vendor/twig/twig/src/Template.php, line: 604 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php.

Anyone else with this issue ?

Hey @JeremyWinalist this plugin doesn't use any of those methods. It's more likely that those methods are called within a template somewhere as all errors origin from within Twig it self.

Hey @WyriHaximus thanks for your answer that's right.
For anyone having same problem, I replaced this:
'?' : {'redirect' : _view.request.query['redirect']}
By this:
'?' : {'redirect' : _view.request.getQuery('redirect')}

Glad to hear this has been resolved :+1:


Improve Movie Card 1

Need to improve this component on Movie Card/src/movie-card-1.html
Improvements required :
Component is using javascript file to work. Need to make it work without javascript.
Any reference image?

movie-card-1.html

@Rajdip019 Please assign this to me .

@RavindraP04 It is working even if you delete the config file... I had checked it earlier

I know that it is working but the polygon(tilted effect) is not not working without config file


Fix gdal binaries

Previously, we loaded files from disk the following way:
ClassLoader -> String -> File -> absolute path
This was producing file paths with encoded spaces (Program%20Files) rather than just spaces.  To fix this, a File object MUST be constructed as such:
Paths.get(ClassLoader.getSystemResource("testfile.sample").toURI()).toFile()
That will result in files paths that will be correctly encoded when exported to string for methods such as GdalUtility.open().

This change is

Coverage remained the same at 53.656% when pulling 89a3bbc58dd83eb11483149d2a285ad067cc1ca0 on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.

Coverage remained the same at 53.656% when pulling 5d329e7ce550503b51f6703cefc67f9b38109f1c on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.

Coverage remained the same at 53.656% when pulling 5d329e7ce550503b51f6703cefc67f9b38109f1c on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.

Coverage remained the same at 53.656% when pulling c06bba328deda7a694961e8f6cecac9e98863e9a on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.

Coverage remained the same at 53.656% when pulling 64f2f813b1762765efd8d47ff0d85a42dc29d62f on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.

Coverage remained the same at 53.656% when pulling efad2ab146dcd54b6a3d1f9f29451b157fd7c2fa on fix-gdal-binaries into 6d93b8c33c6ee43a09cf570f099e1f5d1ccb2cd8 on master.


refactor: use grid layout for pagination nav

Less code
Simpler markup
No need for adding an empty element if there is no next/prev link

Noticed a little inconsistency we had previously:

This change looks like an improvement 👍


Update mingw to 5.0.3 and gcc 7.2.0

Done in https://github.com/cosmo0920/homebrew-mingw_w64/commit/7844f3da5fce482853b7edaca59cb8a511cc7ac7.


Handle the diversity of calendars

A few day's effort turned up over 80 distinct calendars. That is too many to wish to include them all in the primary spec.
We would love to have a separate registry of calendars that could be updated separately. But we did not identify an organization that was was already registering these.
Either way, we may wish to add a method of having explicit "same date in several calendars" in GEDCOM 7.1. See SDATE and TRAN for relate ideas.

See also issues about specific calendars of interest:
#1 - conversations about several calendars
#28 - Swedish
#29 - Quaker
#34 - Umm al-Qura
#35 - Islamic
#36 - Persion

But we did not identify an organization that was was already registering these.

FYI, the Unicode Common Locale Data Repository maintains information about all calendars in current use.
The latest version (39) of the CLDR contains the following:

buddhist
chinese
coptic
dangi
ethiopic
ethiopic-amete-alem
gregorian
hebrew
indian
islamic
islamic-civil
islamic-rgsa
islamic-tbla
islamic-umalqura
japanese
persian
roc


Is possible to translate columns title?

Is there a way to translate title strings from table headers ?
I'm using tap-i18n, I have also tried to call a function like:
tap = function (str) {
    return (Meteor.isClient) ? TAPi18n.__(str)  : " ";
}
... and then use
{ data: "someField", title: tap('name') }

but nothing is translated, it returns "name".
Thanks

maybe try using the "render" callback as the example from the readme: see below
bularTables.Books = new Tabular.Table({
name: "BookList",
collection: Books,
columns: [
{data: "title", title: "Title"},
{data: "author", title: "Author"},
{data: "copies", title: "Copies Available"},
{
data: "lastCheckedOut",
title: "Last Checkout",
render: function (val, type, doc) {
if (val instanceof Date) {
return moment(val).calendar();
} else {
return "Never";
}
}
},
{data: "summary", title: "Summary"},
{
tmpl: Meteor.isClient && Template.bookCheckOutCell
}
]
});

It's ok if using
Template.<name>.rendered = function () {
     _.each($('thead tr th'), function (o) {
           $(o).html(TAPi18n.__($(o).html()));
     });
}

and setting title of each column as the string you have defined inside i18n.
I haven't found a direct method, without the need to use Template rendered callback.

I'm not sure of the answer, but tabular does nothing special here, so it's best to look for the answer in the DataTables documentation. Looking at your original code, I think it would work. The isClient check is unnecessary because the server never attempts to execute any of the column stuff.

See http://stackoverflow.com/questions/35647656/how-do-i-get-translated-column-headers-with-meteor-and-aldeedtabular/35650141#35650141 for a solution using the .template.options reactive variable.

Hi @domq, I'm looking at the solution you proposed and I think it only work with one table, right?
I beleive the following approach could work
if (Meteor.isClient) {
  Template.tabular.onRendered(function() {
    if (this.tabular.tableName.get() !== 'Books') return;
    var self = this;
    self.autorun(function() {
      var options = _.clone(self.tabular.options.get());
      options.columns = getTranslatedColumns();
      self.tabular.options.set(_.clone(options));
    });
  });
}

where if (this.tabular.tableName.get() !== 'Books') return; was added to the listener.
There will be one listener per table! I guess it could be done more efficiently somehow (a global registry of columns generator functions comes to mind), but for a few tables it's acceptable :)

Recent versions of aldeed:tabular / datatables allow to specify a function for setting the column titles.
import {TAPi18n} from 'meteor/tap:i18n';

TabularTables = {};
TabularTables.Departments= new Tabular.Table({
  name: 'Departments',
  collection: Departments,
 responsive: true,
 autoWidth: true,
 stateSave: false,
 columns: [
    {data: "name", titleFn: function() {
      return TAPi18n.__("name");
    }},
    {data: "description", titleFn: function() {
      return TAPi18n.__("description");
    }}
  ]
});

The language change is reactive. If you have translations you can switch and columns will be translated.
TAPi18n.setLanguage("en");
TAPi18n.setLanguage("de");

Word of warning:
This currently does not work when you include invisible columns in your table data. The offset is wrong and you get wrong column titles.

@dwimberger @aldeed

Word of warning:
This currently does not work when you include invisible columns in your table data. The offset is wrong and you get wrong column titles.

I'm still experiencing this same issue.

@ixdi Thanks, your solution works fine.


rails.md: change the database.yml default database

In this example,  database.yml uses the default value of postgres for the database key.
The database postgres is normally not used for user data, but for administrative purposes.  This means people following this example will not be able to drop the database, and in general it's just not a great idea.

Deploy preview ready!
Built with commit 2cee94c0af8493130cfd6be24d00de6a6c1043df
https://deploy-preview-701--docker-docs.netlify.com

Thanks, @ryanore this is great. :)


New version LPVSpectral: 0.1.2

Registering: LPVSpectral
Repository: https://github.com/baggepinnen/LPVSpectral.jl
Version: v0.1.2
Commit: 3e4929c73cd656ce6205abf89ef3498fa15fc5b9
Proposed by: @baggepinnen
Reviewed by: @baggepinnen
Reference: https://github.com/baggepinnen/LPVSpectral.jl/issues/13

Can you add compatibility constraints?

I added my current version of all dependencies


Visual Studio Code not working on Windows 7

VSCode Version: 1.14.2
OS Version: Windows 7 Enterprise Service Pack 1 (64-bit)

I have never been able to run any version of VSCode on my work computer. I have tried several recommended methods but none succeeded. I have verified that .NET 4.5.2 is installed.
Reproduced the problem under following:

Downloaded VSCodeSetup-x64-1.14.2.exe and ran setup. Setup terminated at some point without leaving any message. All files seemed to be copied to the installation folder. Launching code.cmd produced no result. Only a blank command prompt popped up and disappeared.
Downloaded VSCode-win32-x64-1.14.2.zip and extracted contents. Again, launching code.cmd produced no results leaving no traces (no error, dump file, event log etc.)
Tried insiders-build without any success
Tried 32-bit versions but the outcome did not change.
Tried --disable-extensions and --disable-gpu options without any success.
Tried --version, --verbose and --help options to extract some output on the command line. Nothing happened.
Also tried version 1.12.2 but no changes.

Note: Checked AppData\Roaming\Code folder. It is empty.

Try this only on the extracted VSCode-win32-x64-1.14.2.zip:

double click Code.exe
run bin\code.cmd --help
run bin\code.cmd --verbose

What are the outcomes of all those 3 experiments?

** double click Code.exe**: A few seconds of busy cursor, then nothing
run bin\code.cmd --help: No reaction on command prompt
run bin\code.cmd --verbose: No reaction on command prompt

How about running Code.exe in the command line? How about Code.exe --verbose?

I have found the cause of the problem:
Symantec Endpoint Protection software (and may be a second low level extension like a file system filter) are preventing the creation of a folder named "uc.micro" and silently terminating the zip extractor or the setup exe.
When the blocker is Symantec Endpoint Protection, following trace is logged:
_27/07/17 11:56:12	0	Terminate	Production
Monitor File Creation for Known Cryptolocker Extensions - Caller MD5=775b5ab4b2904acdf02f8021fe0b5c90
File Write	CryptoLocker Block File Creation Rule | CryptoLocker File and Folder Access Attempts
...
D:\VSCode\resources\app\extensions\extension-editing\node_modules\uc.micro
In order to verify this, I tried to create a folder with .micro extension. The command prompt got terminated immediately.

Same result with code.exe and code.exe --verbose in command line.
I have also compared zip file and installation folder contents. Folder contains 130MB, whereas extracted size of zip file is reported as around 190MB.

Can you open up an exception for Code?

I don't have direct access to virus control tool but I can file up a request for that.
Right now I am in the tool evaluation process for a project and I have been able to install VS Code by renaming the uc.micro folders inside the zip file. This seems sufficient for my current purpose.
If we choose to go forward with VS Code, I will definitely consider your suggestion as it's a more permanent solution. Thanks.

Thanks!


refactor: refactor types

check list

[ ] Add test cases for the changes.
[x] Passed the CI test.

Description

Additional information

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

123 of 123 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.295%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4438

Relevant Lines:
4515

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

140 of 140 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.295%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4438

Relevant Lines:
4515

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

185 of 185 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 98.289%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
4424

Relevant Lines:
4501

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

186 of 186 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.29%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4425

Relevant Lines:
4502

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

186 of 186 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.29%

Totals

Change from base Build<PHONE_NUMBER>9:
0.02%

Covered Lines:
4425

Relevant Lines:
4502

💛  - Coveralls


Bug: Indentation rule with parens

Using parens causes an issue with the indentation rule.
// Causes an error - 'Indentation of 2, expected 4'
@if (1 == 1) {
  content: 'foo';
}

// Is ok
@if 1 == 1 {
  content: 'foo';
}

// Is ok
@mixin bar($foo) {
  content: 'bar';
}

Using v1.0.0

Boo! This comes from the work to allow proper indentation for maps. Let's squash.

Where is the error coming from? content?

Yep, here's the error.

I'm going to see if anything else pops up this weekend and release a patch fix by the end of the weekend


npm execution error "'CALL "X:\node.js\node.exe" "X:\node.js\node_modules\npm\bin\npm-cli.js" prefix -g'

NPM version (6.14.13):

Node version (v14.17.0):

Node Process ({ node: '14.17.0', v8: '8.4.371.23-node.63', uv: '1.41.0', zlib: '1.2.11', brotli: '1.0.9', ares: '1.17.1', modules: '83', nghttp2: '1.42.0', napi: '8', llhttp: '2.1.3', openssl: '1.1.1k', cldr: '38.1', icu: '68.2', tz: '2020d', unicode: '13.0' }):

Node Platform (win32):

Node architecture (x64):

Node-sass version (node -p "require('node-sass').info"):
Error: Cannot find module 'node-sass' Require stack: C:\Users\Programming\[eval]   at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)   at Function.Module._load (internal/modules/cjs/loader.js:730:27)   at Module.require (internal/modules/cjs/loader.js:957:19)   at require (internal/modules/cjs/helpers.js:88:18)   at [eval]:1:1   at Script.runInThisContext (vm.js:133:18)   at Object.runInThisContext (vm.js:310:38)   at internal/process/execution.js:77:19   at [eval]-wrapper:6:22   at evalScript (internal/process/execution.js:76:60) { code: 'MODULE_NOT_FOUND', requireStack: [ 'C:\\Users\\Programming\\[eval]' ]

npm node sass version: (`C:\Users\Programming
-- (empty)``):

info.txt

Regarding the
"'CALL "X:\node.js\\node.exe" "X:\node.js\\node_modules\npm\bin\npm-cli.js" prefix -g' it is not recognized as an internal or external command, operable program or batch file."
error message that you receive after running npm. npm still works but its annoying. I worked on this for 3 days and its not a permissions issue or an issue with the path. There is something wrong with your npm.cmd file in the section
`FOR /F "delims=" %%F IN ('CALL "%NODE_EXE%" "%NPM_CLI_JS%" prefix -g') DO (
     SET "NPM_PREFIX_NPM_CLI_JS=%%F\node_modules\npm\bin\npm-cli.js"
)
 IF EXIST "%NPM_PREFIX_NPM_CLI_JS%" (
  SET "NPM_CLI_JS=%NPM_PREFIX_NPM_CLI_JS%"
)`

I can run this command from a command prompt, but it won't work in npm.cmd. I believe it is parsing the command looking for the -g global flag and is trying to prefix the .npm-global folder name to each module name that has a -g flag, but I am not sure. None the less, it doesn't work. I simply commented out that section, because I am going to using the .npm-global method or pre-user method. I also noticed that there are double-backslashes \\ between the node path X:\node.js and command node.exe; as well as double-backslashes \\ between the CALL'ed program "X:\node.js\\node.exe" and the parameter "X:\node.js\\node_modules\npm\bin\npm-cli.js". I thought this might help new users (like me) to install node.js and npm.

This is an issue with npm. There is no npm.cmd in node-sass.


Parser Tests

Samples can be found here:

https://github.com/BurntSushi/toml-test
https://github.com/iarna/iarna-toml/tree/cmc/test/spec-test
https://github.com/toml-lang/toml/tree/master/tests

FYI: I moved my spec tests to here, so they can be more easily included in other projects: https://github.com/iarna/toml-spec-tests
You can see how I ensure my project uses an up-to-date version here:
https://github.com/iarna/iarna-toml/blob/latest/package.json#L15

Thanks @iarna that is very convenient that the compliance tests are extracted to a separate repo. 👍


Color 0: invalid color" during early boot

in about 90% of all cases, i would get this error message during early boot and the colorscheme would not be applied to the tty.
the weirdest thing, every now and then it WOULD work.
This is on archlinux.
no errors during mkinitcpio -p linux-lts (which I always run after every change to /etc/vconsole.conf).
i may have found something in /usr/lib/initcpio/install/colors - the COLORS variable is not initialized with an empty string.
after adding this:
*** colors	2017-09-12 08:23:26.807475744 +0300
--- colors-new	2017-09-11 20:13:03.097470560 +0300
***************
*** 4,9 ****
--- 4,11 ----
      (
          [[ -s /etc/vconsole.conf ]] && . /etc/vconsole.conf

+         COLORS=""
+
          for COLOR_ID in $(seq 0 15)
          do
              COLOR=$(eval "echo \$COLOR_${COLOR_ID}")

i tested with about ten different color schemes, and could not reproduce the issue anymore.
proof: removing that line again, rebuild the initrd, and immediately the error "color 0: invalid color" is there again (and no color scheme applied).

created a pull request.
I hope I did everything right - please be gentle with, it's my first. :blush:


STATIC_URL is not respected.

https://github.com/django-ckeditor/django-ckeditor/blob/master/ckeditor_uploader/utils.py#L15

set CKEDITOR_FILEICONS_PATH for now. But that still needs a change.

Yeah, that's what I did. Thanks.


arff deserialiser

Simple ARFF deserialiser. See the spec here.
@karlnapf shall I add a ARFF file as an example and a unittest/meta example?
TODO:

[x] datetime format
[x] string
[ ] relational attributes
[ ] handle missing data

@karlnapf how does shogun handle missing data values? It is possible to have NaN values ("?" in arff files) ?

@karlnapf shall I add a ARFF file as an example and a unittest/meta example?

Yes you can add it under the toy data in data/toy for examples.
For unit test, I would rather not base it on a file ... although there seems to be no other sensible way or?

@karlnapf how does shogun handle missing data values? It is possible to have NaN values ("?" in arff files) ?

idk to be honest :D we might have to think/work a bit for that

Nice!

For unit test, I would rather not base it on a file ... although there seems to be no other sensible way or?

For unittest I could try and use strings? I can then feed the stream directly, rather than a file. Would just have to refactor the class a bit though by adding a constructor for streams rather than file names

So datetime somewhat works, but might have to add strptime definition for the windows build? (see https://stackoverflow.com/a/321877). The conversion to the c++ convention of datetime format needs to be tested more too. I convert dates to unix timestamps btw, because it is the only representation that makes sense to me that can be stored in a numeric matrix

@karlnapf I am not sure how to do the parsing of strings though, for that we would almost need a SGMatrix<variant>

So datetime somewhat works, but might have to add strptime definition for the windows build? (see https://stackoverflow.com/a/321877). The conversion to the c++ convention of datetime format needs to be tested more too. I convert dates to unix timestamps btw, because it is the only representation that makes sense to me that can be stored in a numeric matrix

Great. Ill check it out

@karlnapf I am not sure how to do the parsing of strings though, for that we would almost need a SGMatrix<variant>

Uh that will be tricky with parameter framework. Though we have started using variant in the pipeline...although that causes all sort of headaches (needs an override clone/equals, but no idea how to make put/get work atm)

@karlnapf @vigsterkr so the return type is now CCombinedFeatures, and I use std::vector<variant> internally.
Current features:

handle numeric data with CDenseFeatures
handle dates (excluding timezone name parsing because it requires libtz from the date library to be compiled into a library)
handle strings with StringList and then StringFeatures

The missing data can be ignored for now I think, and just be skipped by the parser, and then one day we can add imputers.
The relational attributes I still need to look into.
And then I'll add a meta example too and that's it I think. @karlnapf can you think of an interesting dataset that shogun could handle?
At some point I can add a ARFFWriter, but it isn't really needed right now, and can be done once the new serialisation stuff is ready.

also the error seems to be due to AveragedPerceptron? I am guessing there's some UB going on

@karlnapf I will skip the relational attributes for now, they don't seem to be used much and I need this parser to finish writing the openml stuff. Is it ok to merge this?

re dataset ... maybe some example from a tutorial?

using CombinedFeatures is the best idea? I am torn....see discussion in irc. But maybe leave it as it is for now
@karlnapf I have been thinking about this, I think CList is better, and then we can always add a CCombinedFeatures constructor with CList? The thing with CList is that is can be used with CDenseFeatures<ST>::create_merged_copy(CList* others) to "cast" a list of features to CDenseFeatures


Standardize configurations

Verify

[X] I understand that if I ignore these instructions, my issue may be closed without review.
[X] I have made sure that there are no similar opened issues.
[X] I have made sure that the mod version matches the latest release.

Is your feature request related to a problem? Please describe.
While the current configuration settings in the mod are consistent, they do not align with the formatting and labeling conventions used by the game developer. For example, the mod uses mixed casing styles for labels and different terminology for boolean options compared to the game’s standard format. This can create a disjointed user experience for players who are familiar with the game's native settings.
Describe the solution you'd like
To align with the game developer's standards and improve user experience, the following adjustments should be made to match the ones in game options:

Change labels: convert all labels to Title-Case.
Reorder boolean values: "Yes/No" to "No/Yes".
Change boolean values: "No/Yes" to "Disabled/Enabled".

Describe alternatives you've considered
If applicable, add a clear and concise description of any alternative solutions or features you've considered.
Additional context
Progress

[x] Change labels: convert all labels to Title-Case.
[x] Reorder boolean values: "Yes/No" to "No/Yes".
[x] Change boolean values: "No/Yes" to "Disabled/Enabled".

Merged victorpopkov/feature-27 manually without opening a PR into the following branches: develop and no-sdk. The main branch also includes this change, as it mirrors the develop branch.


Debug Extension

Description
This extension allows you to debug items
How to use the extension
If the object you set did not spawn twice then, First, Check if you have the function debug. Else, the sprite is broken
Checklist

[X] I've followed all of the best practices.
[X] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
[X] I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?
Reviewed
Example file
Debug.zip
Extension file
DebugExtension.zip

DebugExtension.zip

@RamPlayzTheEpic The bot is not very intelligent, it can only read your original post ;) You need to edit your original submission post to replace the old link with the new one for the submission process to carry on. I'll do it for you now.

@RamPlayzTheEpic You never addressed the new issues raised by the bot. Are you still willing to submit your extension? Since we did not not hear from you, we'll assume you have abandoned the extension and close the submission. Please follow the bots instructions and create a new submission.


Add actions

Coverage remained the same at 100.0% when pulling 5a9109e4629d387374cc1022e3f25607ddbc40a0 on add-actions into 60c3d4b7a5804ea400fa594637e676d44e008d57 on master.

Coverage remained the same at 100.0% when pulling fb5cfb111e656d70438770d779caedcae821fca2 on add-actions into 60c3d4b7a5804ea400fa594637e676d44e008d57 on master.

Coverage remained the same at 100.0% when pulling a417fb3376b6f5ae2abdfc1b1c60ef0feeafba70 on add-actions into e8fb193fe0a0659384e68c6e4f02dfa2e586d3ed on master.

Coverage remained the same at 100.0% when pulling 24ad8464c38a05db3247086f466add236ab6eaba on add-actions into bb6a5f715dbd1c79df3bbc0570370c7f71b3427f on master.

not a fan of rebasing?

Coverage remained the same at 100.0% when pulling b8460a3460f0cdb309194ed029a42925a86d31a1 on add-actions into bb6a5f715dbd1c79df3bbc0570370c7f71b3427f on master.

Coverage remained the same at 100.0% when pulling da6564d8c13e166deab9d6867fcb48795d270921 on add-actions into bb6a5f715dbd1c79df3bbc0570370c7f71b3427f on master.

Coverage remained the same at 100.0% when pulling da6564d8c13e166deab9d6867fcb48795d270921 on add-actions into bb6a5f715dbd1c79df3bbc0570370c7f71b3427f on master.

Rebasing doesn't work if you've already pushed the branch :)
On 28 March 2016 at 20:56, Mike Villis<EMAIL_ADDRESS>wrote:

not a fan of rebasing?
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/mvillis/measure-mate/pull/136#issuecomment-202340434

--
Robert Loomans
<EMAIL_ADDRESS>

Rebasing doesn't work if you've already pushed the branch :)

I just force push if i'm working solo on a branch.
....Feel the power....

Benched for the moment. The single action per attribute works for now.

Can it... we'll create a new PR when we get back around to it.


scRNA UAT fix - added EMPTY to options for missing tubes

Added EMPTY to the list of possible values indicating an empty position in a tube rack scan file

Am I right in saying that this also ticks off this story - https://github.com/sanger/limber/issues/1529 ?
It's the same requirement, but for the rack scan earlier in the pipeline.


bugfixes for 0.4.3

@JuliaRegistrator register branch=release

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


Update change-package-repository.md

文档中有两个个地方少了个v

Please sign CLA before review process.
/easycla

/approve
No more in-synced content with the en upstream recently.

/lgtm


feature request for archiving retention policy

It is a valid assumption that relevance of data decrease as time pass, thus retention policy is a great feature about InfluxDB. Sometimes we want to keep data for ever (it could be an expensive process to recalculate), but can accept larger delay when querying older data-points. It would be great to move data to a low-end backed when retention period pass (instead of deleting them), then we could set up the db on fast SSD backends while data is hot, but move it to a slower but bigger cloud after a month when it gets cold.

+1 for this

There will be also great to be able to downsample that data so that let's say the most accurate data is available for 1 week, then it goes to an archive with only 5 minutes averages stored, after a month it goes to next level of compression with 1 day average values stored.

@madshall what you describe is already possible, except for the ability to use different mount points for different retention policies, which is what this feature request covers.

+1 for this. We'd like to use faster storage for initial data, and CQs to roll it up to longer-term slower storage.


Fix Bazel incompatible changes

According to our Bazel CI (https://buildkite.com/bazel/bazel-at-release-plus-incompatible-flags/builds/95), the project doesn't build with the following Bazel flags:

--incompatible_new_actions_api
--incompatible_disable_deprecated_attr_params
--incompatible_disallow_load_labels_to_cross_package_boundaries

Any update on this?
Based on our latest CI run (https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/28#5b3ff861-39dc-4ee4-a79c-3ea1b175b6ea), migration is needed for the following flags:
  * --incompatible_bzl_disallow_load_after_statement
  * --incompatible_disable_deprecated_attr_params
  * --incompatible_disallow_load_labels_to_cross_package_boundaries
  * --incompatible_new_actions_api
Let me know if you need help with it.

@gaschler Please help resolving this issue, we have to disable Cartographer in Bazel downstream for now. Sorry for that~
https://github.com/bazelbuild/continuous-integration/pull/582

@meteorcloudy Should be fixed now. Can you re-enable us in Bazel downstream please?

After #1553 , there is one test failing on Bazel CI, can you take a look?
https://buildkite.com/bazel/cartographer/builds/1619#4e1c1f09-6ccf-43fd-802c-d096fb7ec4c8

//cartographer/cloud:internal_client_server_test                         FAILED in 5 out of 5 in 21.1s
[ RUN      ] ClientServerTestByGridType/ClientServerTestByGridType.LocalSlam2DUplinkServerRestarting/0
Optimizing: Done.
I0401 08:09:09.712164  3127 map_builder_server.cc:158] Starting SLAM thread.
I0401 08:09:09.712529  2658 map_builder_stub.cc:52] Connecting to SLAM process at <IP_ADDRESS>:50051 with client_id CLIENT_ID
I0401 08:09:09.725284  3111 local_trajectory_uploader.cc:148] Trying to re-connect to uplink...
I0401 08:09:09.725651  3111 local_trajectory_uploader.cc:157] Uplink channel ready, trying recovery.
I0401 08:09:09.725672  3111 local_trajectory_uploader.cc:160] LocalTrajectoryUploader tries to recover with next submap.
F0401 08:09:09.734764  2658 pose_graph_stub.cc:93] Check failed: client.Write(request)
*** Check failure stack trace: ***
external/bazel_tools/tools/test/test-setup.sh: line 310:  2658 Aborted

I think the solution is to disable the "LocalSlam2DUplinkServerRestarting", "LocalSlam3DUplinkServerRestarting" tests (but not the entire client_server_test.cc)
They only fail on a rarely used feature.

@gaschler Can you help disable the test? Thanks!

Test should be disabled now.

Thank you!


fix middleware tests

These two assertions started failing for me (also for v1.2.0).

If you upgrade to go 1.14, these two tests should pass.

indeed. my bad. i thought i had 1.14.

no prob


TH Param Spring Cleaning: inconsistent abbreviation for temperature

Take THcornTemp and  THTfuelOD for instance. Do we want to use T or Temp?
Parent Issue #970

I prefer Temp over T.
Single-letter abbreviations are more likely to clash with other things.


Add animals command

Add a command that reply with a random image of a cat.
Add a command that reply with a random image of a duck.

Now it's ready to merge.


Keeps adding new line before block comment

If you set preserve_newlines in options, it keeps adding a new line before a comment block, if this comment block is between rules.
settings.json:
"beautify.options": {
    "preserve_newlines": true
},

Initial css:
.some-rule {
  width: 20px;
}

/* Description for the next rules */
.other-rule {
  /* width: 40%; */
  width: 20px;
}

After a few beautifies:
.some-rule {
  width: 20px;
}

/* Description for the next rules */

.other-rule {
  /* width: 40%; */
  width: 20px;
}

Having the same issue. I've tried using other beautify settings to correct this issue but to no avail.
Not Working:
   "max_preserve_newlines": 5,
/* This would at least stop the new line chain from expanding further */

   "unformatted": "comments",
/* It's listed in the JS Beautifier url poseted in this extension. Had to try */

   "newline-between-rules": false,
/* It's listed in the JS Beautifier url poseted in this extension. Had to try */

   "css.format.extraLiners": null,
/* It's listed in the JS Beautifier url poseted in this extension. Had to try */

Something in the code of this extension is automatically adding new lines before a comment block and no extensions settings can be added to counteract this bug.

Fixed in 2.0.3


serialport.list not finding some ports.

No doubt I've got something wrong here. There are two USB Prolific port and serialport.list finds one of those. Here are a couple of command line outputs showing 8 serial ports and then there is the output from serialport.list.
dmesg output ******************************************************************
$ dmesg | grep tty
[    0.000000] console [tty0] enabled
[    1.157126] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[    1.177815] 00:06: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
[    1.204666] 0000:02:00.0: ttyS4 at I/O 0x1018 (irq = 18, base_baud = 115200) is a ST16650V2
[    1.226622] 0000:02:00.1: ttyS5 at I/O 0x1010 (irq = 19, base_baud = 115200) is a ST16650V2
[    1.248589] 0000:02:00.2: ttyS6 at I/O 0x1008 (irq = 16, base_baud = 115200) is a ST16650V2
[    1.270547] 0000:02:00.3: ttyS7 at I/O 0x1000 (irq = 17, base_baud = 115200) is a ST16650V2
[17004.557423] usb 3-1: pl2303 converter now attached to ttyUSB0
[17009.695468] usb 3-2: pl2303 converter now attached to ttyUSB1
setserial output *******************************************************************
$ sudo setserial -g /dev/tty*
/dev/ttyS0, UART: 16550A, Port: 0x03f8, IRQ: 4
/dev/ttyS1, UART: 16550A, Port: 0x02f8, IRQ: 3
/dev/ttyS4, UART: 16650V2, Port: 0x1018, IRQ: 18
/dev/ttyS5, UART: 16650V2, Port: 0x1010, IRQ: 19
/dev/ttyS6, UART: 16650V2, Port: 0x1008, IRQ: 16
/dev/ttyS7, UART: 16650V2, Port: 0x1000, IRQ: 17
/dev/ttyUSB0, UART: 16654, Port: 0x0000, IRQ: 0
/dev/ttyUSB1, UART: 16654, Port: 0x0000, IRQ: 0
List ports output *********************************************************************
sudo nodejs /home/bob/TBinst/listPorts.js
/dev/ttyUSB1
usb-Prolific_Technology_Inc._USB-Serial_Controller-if00-port0 Prolific_Technology_Inc.
List ports code ***********************************************************************
var serialport = require("serialport");
serialport.list(function (err, ports) {
if(err) console.log(err);
ports.forEach(function(port) {
console.log(port.comName);
console.log(port.pnpId);
console.log(port.manufacturer);
});
});

I'm having the same issue with multiple Arduino clones that use the same USB chip, just showing up as one serial port in sp.list()
I'll let you know if I find a fix, otherwise what I'm planning to do is try to work around the issue with another usb project (node-udev) which I'm already using for more reliable usb event monitoring (plugging and unplugging arduinos) and then open those directly in node-serialport by devName

$ node scripts/usblist.js | grep "/dev/tty"
DEVNAME: '/dev/ttyACM0',
DEVNAME: '/dev/ttyUSB0',
DEVNAME: '/dev/ttyUSB1',

On mac, I use this quick workaround...
var execSync = require('exec-sync');
function getPortList(){
var stdout = execSync("(ls -1S /dev/tty.* ; ls -1S /dev/cu.*)");
return stdout.split('\n');
}

Looks like the devices are identical, were seeing this issue and working on it https://github.com/voodootikigod/node-serialport/issues/610


Is there a way to debug unbalanced ImGUI calls? Expecting IM_ASSERT_USER_ERROR but instead get silence

Hello, I'm currently investigating ways to debug and/or prevent user errors for my project. Currently any api balancing errors are just silently ignored, I'm wondering if there's tools from the C# side of things to debug these kinds of user errors?
Currently I'm using the library in a Unity project and so if there is automatic error handling it currently appears to be unable to be caught by Unity's debugger. Well, that is unless I make such a bad api call that Unity outright crashes instead.
I see on the main repo that there's supposed to be a IM_ASSERT_USER_ERROR check on the C++ side however I'm not sure if that is or even can be forwarded back to the C# side.
Would appreciate any tips or advice regarding this matter!

Compiling in debug mode is necessary for imgui asserts.

I once had to do the debugging, it was a painful experience. That is expected since there are 3 libs in 3 different languages that we are debugging.
I wrote my debugging experience in the readme ( url below ), please try it out and feel free to create PR to improve the debugging experience.
https://github.com/ImGuiNET/ImGui.NET#debugging-native-code
Other than that, I have also used render doc, pretty awesome tool and works flawlessly out of box.

Compiling in debug mode is necessary for imgui asserts.

No need to debug at all, program will assert when compiled in debug mode.


⚠ Bofrost.de has degraded performance

In 05cc927, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 866 ms

Resolved: Bofrost.de performance has improved in 95553b6.


support trace in AliyunService

Describe what this PR does / why we need it
Does this pull request fix one issue?
fix #2619
Describe how you did it
根据阿里云服务的消息轨迹说明https://help.aliyun.com/document_detail/150029.html，需要设置CLOUD字段，但是原来的设置将accessChannel默认为local类型，使用阿里云服务的用户使用消息轨迹会受到限制。
Describe how to verify it
Special notes for reviews

RocketMQConsumerFactory#initPushConsumer need resolve.


Feat: Provide a hook to get the current frontmatter

Get more fine-grained control over a single page
<!-- layouts/xxx.vue -->
<script setup>
import { useFrontmatter } from 'valaxy'
const frontmatter = useFrontmatter()
frontmatter.value.updated // number
</script>

or like this
<!-- layouts/xxx.vue -->
<script setup>
import { useRoute } from 'valaxy'
const route = useRoute()
route.meta.frontmatter.updated // number
</script>

useFrontmatter is supported.

ok this is my question


build folder and binaries not included in gitignore

Noticed that the bin folder is included in the gitignore, but the build folder is not, and the project has been set to build to the build folder instead of bin. Any reason for this?
Committing those exe's every commit is causing the repository to grow because I believe git cannot store the diff of the binary, so it has to store a fresh copy of the binaries every time. It's 500 MB now, but I feel like it probably shouldn't be that big?

Would be nicer if the binaries were supplied as an actual Release on github, that is where build artifacts usually end up for most projects.


Fork puppet-elasticsearch

We run really old versions of both Elasticsearch and the Elasticsearch Puppet module. We have a requirement to install a later version of Elasticsearch on a separate instance. Unfortunately, the Puppet module we're using is not compatible for a couple of minor reasons.
For reference: https://github.com/alphagov/puppet-elasticsearch/commit/a0d8d3eae04a13408ec325fba5ffd36e3084f90a
To get around these issues, I have decided to fork the repo. I did attempt to upgrade to a slightly later version of the module, but that caused many more errors on the older versions of Elasticsearch than I
felt comfortable with.
The ambition would be to upgrade our older versions of Elasticsearch in line with upgrading the module itself. We may look at outsourcing our Elasticsearch clusters to a SaaS provider in the future.
We haven't updated this module for 3 years, so I don't see a problem with forking now as it's not like we're missing out on updates.
Disclaimer: this PR makes me very unhappy.

We should remove the old vendored module tar

@deanwilson updated.


file view: make HEAD request on sourceUrl to get transcoded URL

Lint is broken due to problem that's fixed in #397


Add support for splines and version of protocol

I have started an implementation of the spline feature (https://www.autodesk.com/techpubs/autocad/acad2000/dxf/spline_dxf_06.htm) in a branch but I think it fails due to some missing defaults in the header (no header in project). Therefore I suggest that a minimal header should be added.

Add the spline feature to src (started in https://github.com/kriffe/js-dxf/commit/72c53ebc7ed4ab633fe43b263dcf8585335e8aa7)

Add minimal header of default header parameters
http://help.autodesk.com/view/OARX/2018/ENU/?guid=GUID-A85E8E67-27CD-4C59-BE61-4DC9FADBE74A

Specify the version of the dxf files. Suggestion to use version 2013 for LTS ($ACADVER=AC1027 in header)

Great.
I have no idea which variables are needed for the minimal header.
Add all and then trim or just leave all?
2013 is fine.

LibreCad draws spline without header parameters:

Thats very interesting. If we can skip the header it would be very nice

I am also interested in having support for splines. Is there anything I can do to help?

I am also interested in having support for splines. Is there anything I can do to help?

Hi Eric,
Seems that issue was with missing headers, although Libre CAD works.
For the begging, If you have AutoCAD or some other CAD software you could try with it.
Here is the generated file
Regards

I am also interested in having support for splines. Is there anything I can do to help?

Hi Eric,
Seems that issue was with missing headers, although Libre CAD works.
For the begging, If you have AutoCAD or some other CAD software you could try with it.
Here is the generated file
Regards

The file does render in LibreCAD, but I have seen it render splines incorrectly many times, so I wouldn't trust it.
When I parse that generated file with this library (which I have tested extensively), I get: Error: Bad knot vector length, expected 7 but got 6.
Here is the parsed spline:
  {
    type: 'SPLINE',
    controlPoints: [
      { x: 0, y: 0, z: 0 },
      { x: 10, y: 10, z: 0 },
      { x: 20, y: 10, z: 0 },
      { x: 30, y: 0, z: 0 }
    ],
    knots: [ 0, 0, 0, 1, 1, 1 ],
    layer: '0',
    extrusionX: 0,
    extrusionY: 0,
    extrusionZ: 1,
    flag: 12,
    closed: false,
    degree: 2,
    numberOfKnots: 6,
    numberOfControlPoints: 4,
    numberOfFitPoints: 0,
    knotTolerance: 0.000001,
    controlPointTolerance: 0.000001,
    transforms: []
  }

The number of knots should be the number of control points, plus the degree, plus 1. So that could be part of the problem.
I have taken a look at the implementation of drawSplineFromControlPoints. For my purposes, in addition to specifying the control points I would also need to be able to specify the degree, knot vector, and possibly others. I realize this is overkill for most people so I wonder if the API could allow some optional parameters to specify those. Something like:
drawSpline(controlPoints, degree=3, knotVector=null, weights=null, fitPoints=[])

If knotVector or weights is null, the library would provide suitable defaults, and could also throw an error if the user's supplied knot vector is wrong.
I've got time to work on this if you would like.

The file does render in LibreCAD, but I have seen it render splines incorrectly many times, so I wouldn't trust it.
When I parse that generated file with this library (which I have tested extensively), I get: Error: Bad knot vector length, expected 7 but got 6.
Here is the parsed spline:
  {
    type: 'SPLINE',
    controlPoints: [
      { x: 0, y: 0, z: 0 },
      { x: 10, y: 10, z: 0 },
      { x: 20, y: 10, z: 0 },
      { x: 30, y: 0, z: 0 }
    ],
    knots: [ 0, 0, 0, 1, 1, 1 ],
    layer: '0',
    extrusionX: 0,
    extrusionY: 0,
    extrusionZ: 1,
    flag: 12,
    closed: false,
    degree: 2,
    numberOfKnots: 6,
    numberOfControlPoints: 4,
    numberOfFitPoints: 0,
    knotTolerance: 0.000001,
    controlPointTolerance: 0.000001,
    transforms: []
  }

The number of knots should be the number of control points, plus the degree, plus 1. So that could be part of the problem.
I have taken a look at the implementation of drawSplineFromControlPoints. For my purposes, in addition to specifying the control points I would also need to be able to specify the degree, knot vector, and possibly others. I realize this is overkill for most people so I wonder if the API could allow some optional parameters to specify those. Something like:
drawSpline(controlPoints, degree=3, knotVector=null, weights=null, fitPoints=[])

If knotVector or weights is null, the library would provide suitable defaults, and could also throw an error if the user's supplied knot vector is wrong.
I've got time to work on this if you would like.

Hi @ericman314
Sure, no problem, just do it.
Thanks,

Hi @ericman314
Sure, no problem, just do it.
Thanks,

@ericman314 I created a draft for Spline back when this issue was created. Please see below if you want to use for start.
The lack of header stopped my progress there, but I might have a fix for that too with a bit of luck that might benefit this project. Will create separate branch
src/Spline.js
class Spline
{
    /**
     * @param {array} controlPoints - Array of points like [ [x1, y1], [x2, y2]... ]
     */
    constructor(type, degree, controlPoints, knots, fitPoints)
    {
        this.controlPoints = controlPoints
        this.knots = knots
        this.fitPoints = fitPoints
        this.type = type
        this.degree = degree

        // const closed = 0
        // const periodic = 0
        // const rational = 1
        // const planar = 1
        // const linear = 0
        // const splineType = 1024 * closed + 128 * periodic + 8 * rational + 4 * planar + 2 * linear

    }

    toDxfString()
    {
      // https://www.autodesk.com/techpubs/autocad/acad2000/dxf/spline_dxf_06.htm
        let s = `0\nSPLINE\n`
        s += `8\n${this.layer.name}\n`
        s += `100\nAcDbSpline\n`
        s += `210\n0.0\n220\n0.0\n230\n1.0\n`

        s+= `70\n${this.type}\n`
        s+= `71\n${this.degree}\n`
        s+= `72\n${this.knots.length}\n`
        s+= `73\n${this.controlPoints.length}\n`
        s+= `74\n${this.fitPoints.length}\n`
        s+= `42\n1e-6\n`
        s+= `43\n1e-6\n`

        for (let i = 0; i < this.knots.length; ++i)
        {
            s += `40\n${this.knots[i]}\n`
        }

        for (let i = 0; i < this.controlPoints.length; ++i)
        {
            s += `10\n${this.controlPoints[i][0]}\n`
            s += `20\n${this.controlPoints[i][1]}\n`
            s += `30\n0\n`
        }

        return s;
    }
}

module.exports = Spline

@ericman314 I created a draft for Spline back when this issue was created. Please see below if you want to use for start.
The lack of header stopped my progress there, but I might have a fix for that too with a bit of luck that might benefit this project. Will create separate branch
src/Spline.js
class Spline
{
    /**
     * @param {array} controlPoints - Array of points like [ [x1, y1], [x2, y2]... ]
     */
    constructor(type, degree, controlPoints, knots, fitPoints)
    {
        this.controlPoints = controlPoints
        this.knots = knots
        this.fitPoints = fitPoints
        this.type = type
        this.degree = degree

        // const closed = 0
        // const periodic = 0
        // const rational = 1
        // const planar = 1
        // const linear = 0
        // const splineType = 1024 * closed + 128 * periodic + 8 * rational + 4 * planar + 2 * linear

    }

    toDxfString()
    {
      // https://www.autodesk.com/techpubs/autocad/acad2000/dxf/spline_dxf_06.htm
        let s = `0\nSPLINE\n`
        s += `8\n${this.layer.name}\n`
        s += `100\nAcDbSpline\n`
        s += `210\n0.0\n220\n0.0\n230\n1.0\n`

        s+= `70\n${this.type}\n`
        s+= `71\n${this.degree}\n`
        s+= `72\n${this.knots.length}\n`
        s+= `73\n${this.controlPoints.length}\n`
        s+= `74\n${this.fitPoints.length}\n`
        s+= `42\n1e-6\n`
        s+= `43\n1e-6\n`

        for (let i = 0; i < this.knots.length; ++i)
        {
            s += `40\n${this.knots[i]}\n`
        }

        for (let i = 0; i < this.controlPoints.length; ++i)
        {
            s += `10\n${this.controlPoints[i][0]}\n`
            s += `20\n${this.controlPoints[i][1]}\n`
            s += `30\n0\n`
        }

        return s;
    }
}

module.exports = Spline

There is also "spline" branch on this repo, it has the Spline class and method, it has been created from the kriffes's branch.
I have just updated it so it is up to date with the master.

There is also "spline" branch on this repo, it has the Spline class and method, it has been created from the kriffes's branch.
I have just updated it so it is up to date with the master.

There is also "spline" branch on this repo, it has the Spline class and method, it has been created from the kriffes's branch.
I have just updated it so it is up to date with the master.

There is also "spline" branch on this repo, it has the Spline class and method, it has been created from the kriffes's branch.
I have just updated it so it is up to date with the master.

Perfect. I will work on it this weekend.

Perfect. I will work on it this weekend.

Regarding the protocol version part of this issue, and getting a wider usage than LibreCAD, I have created a separate issue to discuss this https://github.com/ognjen-petrovic/js-dxf/issues/33

Regarding the protocol version part of this issue, and getting a wider usage than LibreCAD, I have created a separate issue to discuss this https://github.com/ognjen-petrovic/js-dxf/issues/33

I closed issue, minimal header and version issue are moved to https://github.com/ognjen-petrovic/js-dxf/issues/33

I closed issue, minimal header and version issue are moved to https://github.com/ognjen-petrovic/js-dxf/issues/33

Documentation request, what is the order of control points? For my library's bezier path conversion to DXF, I have this working. Are the assumptions around anchor positions and handles, and path closed correct?
// @ts-ignore line -- drawSpline is missing from types
d.drawSpline(pathToDXFSplinePoints(path), 3);

/**
 * Given a Cuttle `Path`, return the array of points to make a DXF spline.
 */
function pathToDXFSplinePoints(path: CuttlePath): Array<[number, number]> {
  const { anchors, closed } = path;

  const splinePoints: Array<[number, number]> = [];

  for (let i = 0, len = anchors.length; i < len; i++) {
    const { position, handleIn, handleOut } = anchors[i];

    const handleInA = position.clone().add(handleIn);
    const handleOutA = position.clone().add(handleOut);

    if (i > 0) {
      // y is flipped in DXF vs Cuttle
      splinePoints.push([handleInA.x, 0 - handleInA.y]);
    }
    splinePoints.push([position.x, 0 - position.y]);
    splinePoints.push([handleOutA.x, 0 - handleOutA.y]);
  }

  if (closed) {
    const { position, handleIn } = anchors[0];
    const handleInA = position.clone().add(handleIn);
    splinePoints.push([handleInA.x, 0 - handleInA.y]);
    splinePoints.push([position.x, 0 - position.y]);
  }

  return splinePoints;
}


error occurs by  /libcore/result.rs:997

ERROR occurs by :
$ RUST_BACKTRACE=1 cargo run
Finished dev [unoptimized + debuginfo] target(s) in 0.05s
Running target/debug/icmp
thread 'main' panicked at 'called Result::unwrap() on an Err value: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" }', src/libcore/result.rs:997:5
stack backtrace:
0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
1: std::sys_common::backtrace::_print
at src/libstd/sys_common/backtrace.rs:70
2: std::panicking::default_hook::{{closure}}
at src/libstd/sys_common/backtrace.rs:58
at src/libstd/panicking.rs:200
3: std::panicking::default_hook
at src/libstd/panicking.rs:215
4: <std::panicking::begin_panic::PanicPayload as core::panic::BoxMeUp>::get
at src/libstd/panicking.rs:478
5: std::panicking::continue_panic_fmt
at src/libstd/panicking.rs:385
6: std::panicking::try::do_call
at src/libstd/panicking.rs:312
7: ::type_id
at src/libcore/panicking.rs:85
8: rand::os::imp::OsRng::new
at /rustc/91856ed52c58aa5ba66a015354d1cc69e9779bdf/src/libcore/macros.rs:17
9: libicmp::socket::RawSocket::set_nonblocking::{{closure}}
at /rustc/91856ed52c58aa5ba66a015354d1cc69e9779bdf/src/libcore/result.rs:798
10: core::cmp::impls::::le
at src/icmp.rs:29
11: <alloc::collections::CollectionAllocErr as core::convert::Fromcore::alloc::LayoutErr>::from
at src/ping.rs:84
12: icmp::main
at src/main.rs:13
13: std::rt::lang_start::{{closure}}
at /rustc/91856ed52c58aa5ba66a015354d1cc69e9779bdf/src/libstd/rt.rs:64
14: std::panicking::try::do_call
at src/libstd/rt.rs:49
at src/libstd/panicking.rs:297
15: panic_unwind::dwarf::eh::read_encoded_pointer
at src/libpanic_unwind/lib.rs:87
16: <std::panicking::begin_panic::PanicPayload as core::panic::BoxMeUp>::get
at src/libstd/panicking.rs:276
at src/libstd/panic.rs:388
at src/libstd/rt.rs:48
17: std::rt::lang_start
at /rustc/91856ed52c58aa5ba66a015354d1cc69e9779bdf/src/libstd/rt.rs:64
18: icmp::main
when i 'cargo run'  , error occurs: 'PermissionDenied' . I have no idea about it ,My machine is macbook pro. Thanks for reading the question.
here is a project base on libc : https://github.com/APTy/icmp

I bind guess: the cargo run run code that tries to create a raw socket to be able to make ping packet, but as you run the program with a "normal" account, the OS denied to you the permission to create such socket (and you get a PermissionDenied). Creating SOCK_RAW is a privilegied operation and usually require elevated privilegies (like behind superuser or having special capability under Linux).

I blind guess: the cargo run run code that tries to create a raw socket to be able to make ping packet, but as you run the program with a "normal" account, the OS denied to you the permission to create such socket (and you get a PermissionDenied). Creating SOCK_RAW is a privilegied operation and usually require elevated privilegies (like behind superuser or having special capability under Linux).

nice!

Feel free to re-open if that did not resolve your issue.


Connor/osc client improvements

Fix OSC packet version to include data type
Use TCP instead of UDP
Fix example code
Args parser for IP and port

tested on rpi


changes for 0.7.4

I finally made the OpenBSD 7.2 CI and the last commit fix an issue on our tests: Since https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9, git rev-parse --show-toplevel can not be executed by root which does not own the cloned repository... I don't have full details between surf, OpenBSD, doas and git but the last patch adds our cloned Git repository as a "safe" repository for the root user and let it to run git rev-parse.


Rework printActions to be more like how the actions are created

Fixes:
Driver/actions.swift
Driver/actions-dsym.swift
Driver/bridging-pch.swift now fails on the output not having -* at the end.
Also fix issue where linker was being passed swiftmoduledoc and swiftsourceinfo files. (As far as I can tell they were ignored)

@swift-ci please test

@swift-ci please test

Still not working
Nudge @shahmishal 😀

@swift-ci please test

Still not working
Nudge @shahmishal 😀

Let me double check tonight, it should have been working.

@cltnschlosser Please try again

@swift-ci please test

Thanks @shahmishal !


Fixed icons in example 'Tab navigation' - Add badges to icons

https://reactnavigation.org/docs/en/tab-based-navigation.html#add-badges-to-icons
Hee's the snack as well: https://snack.expo.io/rJOD3FT6H

What does this fix?

this fixes the icons on the bottom navigation bar on the Snack
see the web preview here
https://snack.expo.io/@react-navigation/tabs-with-icons-v3
and then here
https://snack.expo.io/rJOD3FT6H

the snack is broken, but code in the documentation doesn't have any issues


Error in creating symlink in Win11

I get the following error while trying to run in Win11 python 3.10.13 environment. It appears that a symbolic link is failing.  Any idea how to resolve it? I haven't tried with admin priviledges (it is a bit difficult for me to setup the entire pythin environment under admin).

    from speechlib import Transcriptor
    from .speechlib import(
  File "C:\Users\U\.conda\envs\whisper\lib\site-packages\speechlib\speechlib.py", line 1, in <module>
    from .core_analysis import (core_analysis)
  File "C:\Users\U\.conda\envs\whisper\lib\site-packages\speechlib\core_analysis.py", line 7, in <module>
    from .speaker_recognition import (speaker_recognition)
  File "C:\Users\U\.conda\envs\whisper\lib\site-packages\speechlib\speaker_recognition.py", line 8, in <module>
    verification = SpeakerRecognition.from_hparams(run_opts={"device":"cuda"}, source="speechbrain/spkrec-ecapa-voxceleb", savedir="pretrained_models/spkrec-ecapa-voxceleb")
  File "C:\Users\U\.conda\envs\whisper\lib\site-packages\speechbrain\pretrained\interfaces.py", line 467, in from_hparams
    hparams_local_path = fetch(
  File "C:\Users\U\.conda\envs\whisper\lib\site-packages\speechbrain\pretrained\fetching.py", line 181, in fetch
    destination.symlink_to(sourcepath)
  File "C:\Users\U\.conda\envs\whisper\lib\pathlib.py", line 1255, in symlink_to
    self._accessor.symlink(target, self, target_is_directory)
OSError: [WinError 1314] A required privilege is not held by the client: 'C:\\Users\\U\\.cache\\huggingface\\hub\\models--speechbrain--spkrec-ecapa-voxceleb\\snapshots\\5c0be3875fda05e81f3c004ed8c7c06be308de1e\\hyperparams.yaml' -> 'pretrained_models\\spkrec-ecapa-voxceleb\\hyperparams.yaml'

if you are using vscode or any other IDE, you have to run IDE as administrator. Then this will be solved. let me know if it solves the issue or not.


Adding naa emoji alias

Silly? Yes.
Practical? Aye!

Practical?

Eh, if you're providing feedback on your phone? :D


python310Packages.aesara: 2.6.6 -> 2.7.1, python310Packages.pymc: unstable-2022-05-23 -> 4.0.0

Description of changes
https://github.com/aesara-devs/aesara/releases/tag/rel-2.7.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 176349 run on x86_64-linux 1

6 packages built:

python310Packages.aeppl
python310Packages.aesara
python310Packages.pymc
python39Packages.aeppl
python39Packages.aesara
python39Packages.pymc


Fix getGuildChannel

getGuildChannel was trying to request /guilds/{guild.id}/channels/{channel.id} but it returned a 404 error and I could not find it anywhere in the discord docs
but I did find /channels/{channel.id} which correctly returned the channel
I changed the name to getChannel so it fits with deleteChannel do you think it is a good name change or should I revert it back?

Doesn't getChannel work besides no guild, if so then it's fine.

sorry I don't understand? The updated getChannel works but getGuildChannel returned 404

What I meant was in the discord api. Doesn't it work with no guild id?

Yes
Removing the guild id (and so removing this part of the url/guilds/{guild.id) works


Move packed binary ops below autograd

The key blocker to this is the fact that the autograd engine uses an InputMetadata struct that is used to determine whether a gradient is_expand_to a corresponding input. To resolve this we'll wait on https://github.com/pytorch/pytorch/pull/44668 and then hack around within our submodule using the NestedTensor dispatch key.

Addressed by https://github.com/pytorch/nestedtensor/pull/276


Need a way to configure which boxes are photometry rigs

This could be a setting in the box specific files?
Right now StopPhotometry just checks for self.box_letter== "D" which is not a robust solution.

Yes, local setting files should contain a flag if this is a photometry rig. Also, considering the possibility that a PC controls more than 2 FPs, local setting files should have COM port info per FP box. However, for 446/447 for foreseeable future, we are rather heading to 1PC/1Box-regime, and thus, this would not be an issue.

I think we should add entries to the ForagingSettings.json:
Photometry_box1: False,
Photometry_box2: False,
Photometry_box3: False,
Photometry_boxD: True

The box specific settings files get passed to bonsai, so its better to specify this in the .json. This will allow any combination of boxes from a computer to be photometry or not.


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2021-08-03T17:29:41+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
d1d16fc0c5724d9ae15fad32701a98e2f500896c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b6fde62b07fe7521bafcf0660f7e182a3788b232
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Memory leak when reading v7 MAT-files

Reported by beutlich on 25 Nov 2015 20:09 UTC
While debugging for 1920132db2cb459b1ccaa9edd2e4696f5ea939d5 I observed a significant memory leak when reading v7 (= compressed) MAT-files for the Modelica Standard Tables. Not sure if this is the same problem that Eric Thomas noticed.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1845

Comment by beutlich on 26 Nov 2015 07:51 UTC
Resolved by 70b29c8ebfdbdc77b471827a50e04dec74bc444c.

Changelog modified by beutlich on 26 Nov 2015 07:51 UTC
Modelica Standard Tables: Fixed memory leak when reading v7 MATLAB MAT-files