DeviceSpecification serialization

While DeviceSpecification serialization happens on the server side, the serialization logic should exist close to the deserialization logic to keep them consistent. This PR has 3 proposals of laying out the serialization logic:

(preferred) A function in the same file as GoogleDevice (renamed to GridDevice in the latest iteration) taking as input only the essential information (i.e. qubits, qubit pairs, gateset, gate_duration) to construct a DeviceSpecification message.
A function in the same place, but takes in a GridDeviceMetadata instead.
A GridDevice method which serializes the underlying GridDeviceMetadata as DeviceSpecification.

I prefer the first solution because, while it's tempting to have the symmetry of being able to both serialize and deserialize a GridDevice, GridDevice and GridDeviceMetadata are designed as client-side views rather than models in MVC terms, and these views contain more information than the underlying model (i.e. compilation target gatesets, generated equivalence GateFamilies like FSimGateFamily). Serializing GridDeviceMetadata to DeviceSpecification means we'll have to construct GridDeviceMetadata with less information than it was designed to have.
@dstrain115 @tanujkhattar WDYT? Also cc @maffoo @wcourtney FYI
Please ignore the first commit (that's only there because #5203 hasn't merged yet).

As discussed in our call, I agree with the preferred method, though I think we should have "alternative 2" as an interface to turn GoogleDevice to a proto if necessary (that can, in turn call to_proto).  This could be called to_device_specification() or something to indicate that it is stripping out some metadata (and this can also be clarified in the docstring)

I'm a bit hesitant to include alternative 2 which would encourage a misuse of GridDevice IMO. If this path exists, it will likely become the most commonly used path since it seems convenient to simply construct a GridDevice on server side and serialize that. We could perhaps add it later on instead if it's deemed necessary.

If this path exists, it will likely become the most commonly used path since it seems convenient to simply construct a GridDevice on server side and serialize that.

Why is this a problem?  This seems like a perfectly reasonable path to me.

Having that as the main path is tricky because it's unclear which fields in GridDeviceMetadata needs to be set on server side when instantiating GridDevice by looking at the GridDevice API. We could add comments, but ideally it should be clear from the serialization API what's the minimum information sufficient to serialize to DeviceSpecification.
If GridDeviceMetadata has a clear split in the API between a server-provided part and a client-generated part, then having GridDevice serialization as the main path sgtm, but IMO this complicates the client API and results from forcing a coupling between server-side (model) and client-side (view) requirements.
On the other hand, having it as a convenient method to turn a GridDevice back into a DeviceSpecification on Cirq client side I think makes sense. We could also instead just store the full DeviceSpecification as a GridDevice field rather than doing a serialization. This bypasses the need to have logic that identifies what needs to be stripped, and this logic may need to be updated in the future.

Synced with @dstrain115 offline. Doug raised the point that on server side, incoming programs need to be validated against the device (for example, programs may target the wrong qubits), and it would be ideal to construct GridDevice on server side anyway for that purpose anyway, in which case GridDevice.to_proto() would be convenient.
For MVP, let's move forward with the separate to_proto(qubits, qubit_pairs, gateset, gate_durations) for now. There will be some refactoring on server side to address other issues anyway, which would be a good opportunity to address this as well.
Will close this PR and open a separate one for serialization implementation.


update react canary version

[x] update react canary version
[x] fix using decodeReply outside "react-server" condition
[x] add 11_form example

Oh, no. https://github.com/facebook/react/pull/27436 prevents to use decodeReply outside "react-server" condition. 😱

It was far bigger change than I expected. Merging.

18147fa

this is confusing

ah, the form status is only available in the form tree. makes sense.


Provide config option to disable logging of protocol errors

As a potential fix to #320, add an option to disable the logging of protocol errors in HTTP/1. Logging is still enabled by default (at least for now; I'd like to get some idea of how many errors this ends up hiding before enabling by default). You can disable logging by:
config :my_phoenix_app, MyPhoenixAppWeb.Endpoint,
  http: [
    ip: ...,
    port: ...,
    http_1_options: [log_protocol_errors: false]
  ]
  ...

Released as 1.3.0


Added type check to convert String to JsonObject

Fixes #863

Merged https://github.com/hibernate/hibernate-reactive/pull/870
Thanks


Cgit support.

Users  can open cgit links using the vim-gh-line plugin.
Cgit is an opensource configurable git hosting front end.

@ruanyl, this is my take on supporting cgit front-ends.
Please take a look and let me know what you think.

@ahakanbaba Thank you very much for the PR, please allow to me take some time to review :)


[x] add determinator rules for move-prover

Whenever changes in diem-framework or move-stdlib are found, rerun the
tests in the move-prover.

Motivation
testsuite.rs under the move-prover crate grabs files outside its crate for datatests AND move-prover do not depends on those crates. This commit ensures that whenever the files it grabs changes, the tests are run.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI

Tested out locally and move-prover did show up in the packages sent to cargo test:
Before this rule comes into effect:
INFO [19:07:38.647] - Executing: "/Users/mengxu/.rustup/toolchains/nightly-2020-10-09-x86_64-apple-darwin/bin/cargo" "-Zfeatures=all" "test" "--package" "backup-cli" "--package" "bytecode-verifier-tests" "--package" "cli" "--package" "cluster-test" "--package" "compiled-stdlib" "--package" "compiler" "--package" "consensus" "--package" "diem-framework" "--package" "diem-fuzz" "--package" "diem-fuzzer" "--package" "diem-genesis-tool" "--package" "diem-json-rpc" "--package" "diem-key-manager" "--package" "diem-node" "--package" "diem-storage-inspector" "--package" "diem-swarm" "--package" "diem-transaction-replay" "--package" "diem-writeset-generator" "--package" "execution-correctness" "--package" "executor" "--package" "executor-benchmark" "--package" "executor-test-helpers" "--package" "functional-tests" "--package" "genesis-viewer" "--package" "ir-testsuite" "--package" "language-benchmarks" "--package" "language-e2e-tests" "--package" "language-e2e-testsuite" "--package" "move-cli" "--package" "move-explain" "--package" "move-lang" "--package" "move-lang-functional-tests" "--package" "move-vm-runtime" "--package" "resource-viewer" "--package" "smoke-test" "--package" "state-sync" "--package" "test-generation" "--package" "vm-genesis" "--package" "vm-validator"

After this rule comes into effect
INFO [19:04:25.664] - Executing: "/Users/mengxu/.rustup/toolchains/nightly-2020-10-09-x86_64-apple-darwin/bin/cargo" "-Zfeatures=all" "test" "--package" "abigen" "--package" "backup-cli" "--package" "bytecode-verifier-tests" "--package" "cli" "--package" "cluster-test" "--package" "compiled-stdlib" "--package" "compiler" "--package" "consensus" "--package" "diem-framework" "--package" "diem-fuzz" "--package" "diem-fuzzer" "--package" "diem-genesis-tool" "--package" "diem-json-rpc" "--package" "diem-key-manager" "--package" "diem-node" "--package" "diem-storage-inspector" "--package" "diem-swarm" "--package" "diem-transaction-replay" "--package" "diem-writeset-generator" "--package" "docgen" "--package" "errmapgen" "--package" "execution-correctness" "--package" "executor" "--package" "executor-benchmark" "--package" "executor-test-helpers" "--package" "functional-tests" "--package" "genesis-viewer" "--package" "ir-testsuite" "--package" "language-benchmarks" "--package" "language-e2e-tests" "--package" "language-e2e-testsuite" "--package" "move-cli" "--package" "move-explain" "--package" "move-lang" "--package" "move-lang-functional-tests" "--package" "move-prover" "--package" "move-stdlib" "--package" "move-vm-runtime" "--package" "resource-viewer" "--package" "smoke-test" "--package" "state-sync" "--package" "test-generation" "--package" "vm-genesis" "--package" "vm-validator"

/land


Update for VS 16.5.3

Hi @alireza-rezaee, thanks for your contribution. This change has already been merged and will be published later today. We have a team of folks who publish these build numbers and release dates.


[BACKEND] Update LLVM version to https://github.com/llvm/llvm-project/commit/657ec7320d8a

Upgrading LLVM repo again, because we need a feature that has been recently submitted in https://github.com/llvm/llvm-project/pull/95057
Changes made:

MathExtras has been merged with its LLVM version. So I had to replace mlir::ceilDiv with llvm:divideCeilSigned

cc @antiagainst to review


HomeEdge image from DockerHub

LF Edge has its designated account for DockerHub and it provides several available images from it. We can provide our image from this account to promote us for the outreach developers as well as to measure the downstream statistic about our project. What do you think?

Find the container images from the link below.

https://hub.docker.com/r/lfedge/edge-home-orchestration-go


[5.0.0] paket update group G touches other groups

Description
paket update group <name> changes framework restrictions of other groups.
I think it's because of the formular simplifier or because we don't read the same as what we write...
This might or might not be a bug.
I don't have found a case jet where the changes were "wrong". Also note that I'm not sure we use those framework restrictions (of dependencies) anywhere. AFAIK we only use the framework restriction of resolved (root) packages.

For now it is "just" an annoyance that paket is rewriting the lockfile all the time :/


Fixed code for compatibility with KiCad 8, updated dead link.

The pcbnew plugin interface link was a 404, so I updated it to the current link.
More importantly, the code breaks on KiCad 8 with the below error.

To fix this, I just changed pad.GetParent().IsFlipped() to pad.IsFlipped() and this fixed the error.

Does this still work on KiCAD 6..7?

Still works perfect on 7, I can install 6 on another machine to test that.


Remove trailing empty line in copyright comment (part 8)

Next part of https://github.com/helidon-io/helidon/pull/5324

/trigger


UI - Categories/Acknowledgements link to info to add more

To: @christianmorfordwaitessw
Cc: @adamcogan @bradystroud @JackLeerson
As per our conversation add some links with ellipses (...) to link off to information on add them

Add ellipses next to the category and acknowledgment sections and link off to the wiki

Figure: Acknowlegements and Categories on the rule
AB#59874

A small "info" icon would definitely make more sense than ellipses

To: @christianmorfordwaitessw
cc: @tiagov8  @adamcogan

Add ellipses next to the category and acknowledgment sections and link off to the wiki

Done - Added wiki link buttons to Categories and Acknowledgements:
Rule Example: https://www.ssw.com.au/rules/do-you-understand-the-value-of-consistency

Figure: New info buttons


bug fixes

Smoothing window value was not being set if doing frame-by-frame processing in a manual loop
Processing was failing if no key points were matched between frames (would fail if video contained a jump-cut)

Codecov Report

Merging #79 into master will decrease coverage by 0.13%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   92.22%   92.09%   -0.14%
==========================================
  Files          16       16
  Lines         579      582       +3
==========================================
+ Hits          534      536       +2
- Misses         45       46       +1

Impacted Files
Coverage Δ

vidstab/VidStab.py
90.15% <100%> (+0.05%)
:arrow_up:

vidstab/version.py
100% <100%> (ø)
:arrow_up:

vidstab/cv2_utils.py
85.71% <50%> (-5.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821ea15...62ad0f6. Read the comment docs.


WIP: new(blog): add blog for Falco 0.39.0

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 308ee05552e009e6f2ebcd1206b3d9d372cb08fb

/unhold

LGTM label has been added.  Git tree hash: fdfb2511212e0275cea8a16a7a1c8a11e7efdeff

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[FEAT]: Add page with 3D models of non-standard LEGO parts

Description
Prepare a page under docs/ where to put links to open source 3D models (with STL or STEP files) of custom LEGO parts which may be useful to the ARNEIS project
Additional Information
Here are some initial entries to add to the list:

MyBeam: Technic-compatible objects: https://www.thingiverse.com/thing:29989

Closing - duplicate of #59


CORE-5182 Add helm chart for app simulator

Add helm charts so the app simulator can be deployed into a Corda worker cluster.

There are separate deployment templates for the receiver, sender (when sending messages in CONTINUOUS mode) and db_sink. As well as a Job template for the sender (when sending messages in ONE_OFF mode). I added parameters for these to applications/tools/p2p-test/app-simulator/charts/app-simulator/values.yaml, with some sensible defaults. There are also parameters in the values.yaml file so that the app simulator can connect to the app simulator database and kafka. All these parameters can be overridden on the command line or with another yaml file.
I have added a Job template to create p2p.app.received_msg topic. This is almost the same as the job under the main corda chart. I had to change the topic creation tool (tools/plugins/topic-config/src/main/kotlin/net/corda/cli/plugins/topicconfig/Create.kt) to be able to create the test schema, to do this I changed the package under which the test schema is stored here: https://github.com/corda/corda-api/pull/544.
I changed to the app simulator so that all options can be supplied on the command line, as well as via a config file.
This makes it easy to pass in command line options via helm into the dock container.

Merge https://github.com/corda/corda-api/pull/544 first.
To use the app simulator
Deploy 3 worker clusters using
export U=wvigor
chart_version=0.1.0-alpha.1662143290096
docker_image_version=<IP_ADDRESS>-alpha-1662141681234
declare -a namespaces=("$U-cluster-a" "$U-cluster-mgm" "$U-cluster-b")

for namespace in ${namespaces[@]}; do
  echo Creating $namespace
  kubectl create ns $namespace

  echo Installing prereqs into $namespace
  helm upgrade --install prereqs -n $namespace \
    oci://corda-os-docker.software.r3.com/helm-charts/corda-dev \
    --set image.registry="corda-os-docker.software.r3.com" \
    --set kafka.replicaCount=3,kafka.zookeeper.replicaCount=1 \
    --render-subchart-notes \
    --timeout 10m \
    --wait

 echo Installing corda into $namespace
 helm upgrade --install corda -n $namespace oci://corda-os-docker.software.r3.com/helm-charts/corda --set "imagePullSecrets={docker-registry-cred}"  --set image.tag=$docker_image_version --set image.registry="corda-os-docker.software.r3.com" --values values.yaml --values debug.yaml --wait --version $chart_version
done

kubectl port-forward --namespace $U-cluster-a deployment/corda-rpc-worker 8888 &
kubectl port-forward --namespace $U-cluster-b deployment/corda-rpc-worker 8889:8888 &
kubectl port-forward --namespace $U-cluster-mgm deployment/corda-rpc-worker 8890:8888 &

Run the MultiClusterDynamicNetworkTest. This is disabled by default and some variables inside: applications/workers/release/rpc-worker/build.gradle need to be set:
export E2E_CLUSTER_A_RPC_HOST=localhost
export E2E_CLUSTER_A_RPC_PORT=8888
export E2E_CLUSTER_B_RPC_HOST=localhost
export E2E_CLUSTER_B_RPC_PORT=8889
export E2E_CLUSTER_C_RPC_HOST=localhost
export E2E_CLUSTER_C_RPC_PORT=8890
export E2E_CLUSTER_A_P2P_HOST="corda-p2p-gateway-worker.wvigor-cluster-a"
export E2E_CLUSTER_A_P2P_PORT=8080
...

To run the test:
./gradlew :applications:workers:release:rpc-worker:e2eTest --tests "net.corda.applications.workers.rpc.MultiClusterDynamicNetworkTest"

Deploy the app simulator postgres database into it's own namespace:
cd applications/tools/p2p-test/app-simulator/charts/app-simulator-db
kubectl create ns $U-db
helm upgrade --install -n $U-db db ./ --render-subchart-notes

Extract the password:
export POSTGRES_ADMIN_PASSWORD=$(kubectl get secret --namespace $U-db db-postgresql -o jsonpath="{.data.postgres-password}" | base64 --decode)

(Note that the app simulator database helm chart doesn't give the simulator user enough permissions to be able to write to the sent_messages_table.
Deploy a receiving and db_sink app simulator into the $U-cluster-b namespace:
cd applications/tools/p2p-test/app-simulator/charts/app-simulator
helm upgrade --install app-simulator ./ -n $U-cluster-b --set db.appSimulator.namespace=$U-db --set db.appSimulator.user=postgres --set db.appSimulator.password=$POSTGRES_ADMIN_PASSWORD --set appSimulators.sender.enabled=false --set "imagePullSecrets={docker-registry-cred}" --set image.tag=<IP_ADDRESS>-alpha-1662141681234

kubectl get pods  --all-namespaces should show something like:
NAMESPACE     NAME                                             READY   STATUS             RESTARTS         AGE
cluster-b         app-simulator-create-topics-lzjqx                0/1     Completed          0                145m
cluster-b         app-simulator-db-sink-6f4fbf44f8-rrbbv           1/1     Running            0                145m
cluster-b         app-simulator-receiver-676fc96bb9-sck9k          1/1     Running            0                145m
cluster-b         corda-create-topics-lr682                        0/1     Completed          0                26h
cluster-b         corda-crypto-worker-84f7cd8666-r9lqh             1/1     Running            0                26h
cluster-b         corda-db-worker-5659c898bb-h9wwp                 1/1     Running            0                26h
cluster-b         corda-flow-worker-5d7c56f77-lrksm                1/1     Running            0                26h
cluster-b         corda-membership-worker-5bc48bd74-qvm4f          1/1     Running            0                26h
cluster-b         corda-p2p-gateway-worker-787487bf58-vjnzf        1/1     Running            0                26h
cluster-b         corda-p2p-link-manager-worker-5c89b948c8-cjrj7   1/1     Running            253 (21s ago)    26h
cluster-b         corda-rpc-worker-6c78ccbb86-bmlr4                1/1     Running            0                26h
cluster-b         corda-setup-db-7jx8p                             0/1     Completed          0                26h
cluster-b         kafka-deployment-6bcf67786-s2w48                 1/1     Running            0                28h
cluster-b         prereqs-postgresql-0                             1/1     Running            0                28h
cluster-b         zookeeper-deployment-5886f98b8d-ktxwh            1/1     Running            0                28h
db            db-postgresql-0                                  1/1     Running            5 (3h38m ago)    3h40m
...

First can extract the x500Names and groupId's from the cluster by looking in the Link Manager pod logs for both $U-cluster-a  (our) and $U-cluster-b (peer). For lines which look like:
11:08:28.482 [durable processing thread inbound_message_processor_group-link.in] INFO  net.corda.p2p.linkmanager.sessions.SessionManagerImpl {} - Outbound session 2b05b145-707d-46ce-9378-d38ad1d18cbb established (local=HoldingIdentity(x500Name=OU=E2eClusterImpl-1-1662116846286, O=Bob, L=London, C=GB, groupId=2e916688-ddd4-40ee-b4df-6f25a4496c66), remote=HoldingIdentity(x500Name=OU=E2eClusterImpl-1-1662116846287, O=Mgm, L=London, C=GB, groupId=2e916688-ddd4-40ee-b4df-6f25a4496c66)).

Currently you need to remove the spaces from the x500Name and also replace , with \,.
Deploy a sending app simulator into $U-cluster-a namespace:
helm upgrade --install app-simulator ./ -n $U-cluster-a --set db.appSimulator.user=postgres  --set db.appSimulator.namespace=$U-db --set db.appSimulator.user=postgres --set db.appSimulator.password=$POSTGRES_ADMIN_PASSWORD --set appSimulators.receiver.enabled=false --set appSimulators.dbSink.enabled=false  --set "imagePullSecrets={docker-registry-cred}" --set image.tag=<IP_ADDRESS>-alpha-1662141681234--set "appSimulators.sender.ourX500Name=OU=E2eClusterImpl-1-1662116846172\,O=Alice\,L=London\,C=GB" --set appSimulators.sender.peerX500Name="OU=E2eClusterImpl-1-1662116846286\,O=Bob\,L=London\,C=GB" --set "appSimulators.sender.ourGroupId=2e916688-ddd4-40ee-b4df-6f25a4496c66" --set "appSimulators.sender.peerGroupId=2e916688-ddd4-40ee-b4df-6f25a4496c66"

This will send 50 messages from OU=E2eClusterImpl-1-1662116846172,O=Alice,L=London,C=GB to OU=E2eClusterImpl-1-1662116846286,O=Bob,L=London,C=GB.

One more thing on:

Merge https://github.com/corda/corda-api/pull/544 first.

Is this necessary? Given these changes are backwards compatible if done the other way around (i.e. remove all usages of this topic and then remove TestSchema), should we do them the other way around (merge this PR first and then merge the corda-api as a clean-up) to skip doing a version bump, taking locks etc.?

One more thing on:

Merge corda/corda-api#544 first.

Is this necessary? Given these changes are backwards compatible if done the other way around (i.e. remove all usages of this topic and then remove TestSchema), should we do them the other way around (merge this PR first and then merge the corda-api as a clean-up) to skip doing a version bump, taking locks etc.?

I don't know. I think technically we need to bump the version when we delete the code in the api repo (we don't have to do this now though). Otherwise we might end up in the situation where if we checkout an old commit before this change it won't build against the latest build of corda-api (with a specific version).

ah, I see what you mean. Indeed, a version bump is needed if we want to protect against the scenario you described. But, to avoid blocking this until you get the lock for a version bump, can we switch it to use version 185 and then do the version bump separately as a follow-up (tiny) PR? Conscious there's a bit of queue atm..

Note that the app simulator database helm chart doesn't give the simulator user enough permissions to be able to write to the sent_messages_table.

Don't we need to change this as part of this change?

At the moment I am using the admin user postgres instead. So I can test this change without it. Want me to raise a Jira to fix this?

Given this is mostly targeted for testing, I am ok with us using the admin user for the time being.


pull request for e2e test at 01/24/2017 05:15:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Dev14 support

Also remove incorrect copy local.
The solution should now build and install on VS 11, 12, and 14, and the build from any version should work on any other version.

I'll close this here, as the issue has been resolved.

@OsirisTerje What issue is resolved? I can't find a reference. Also, is this closed because something is fixed? Because it's obsolete? etc.  Bookkeeping of issues is pretty boring, but we need to have it in order to track what's done and report it to people.
Also, have you reviewed this WRT the nunit3 adapter?

We do support Dev14,  aka VS2015, both for 2.6 and for V3.  I'll add Obsolete to it.
Sent from my Windows Phone

From<EMAIL_ADDRESS>Sent: 23.07.2015 20:18
To<EMAIL_ADDRESS>Cc: Terje<EMAIL_ADDRESS>Subject: Re: [nunit-vs-adapter] Add Dev14 support (#53)
@OsirisTerjehttps://github.com/OsirisTerje What issue is resolved? I can't find a reference. Also, is this closed because something is fixed? Because it's obsolete? etc. Bookkeeping of issues is pretty boring, but we need to have it in order to track what's done and report it to people.
Also, have you reviewed this WRT the nunit3 adapter?
—
Reply to this email directly or view it on GitHubhttps://github.com/nunit/nunit-vs-adapter/pull/53#issuecomment-124193137.

I see now that this PR was replaced by another PR, so the issue is more about that other PR #54. I really should have commented there.


Got it working with new cacheable-flash gem

Looking at the diff I can't understand how these changes help to make it work with that gem... could you explain?

Perhaps a better way to say it is, 'a few features were added which are utilized by the cacheable-flash gem, and one bug was fixed, in the expiry date'.

Is there a github issue at play? When I look at the Diff, the only (relevant) difference I see is this:
-            t.setDate(t.getDate() + days);
+            options.expires.setDate(t.getDate() + days);

which still doesn't do much.

This is not dissimilar from the other pull request from @benz303.  It looks like the differences are either already part of your master or also included in that other pull request.  I am closing this one.


Add automatic installation of serverbot

It can already upgrade, but should be able to install as well.

Fixed in https://github.com/nozel-org/serverbot/commit/bc01a6a14dc97ead34f7b121d8f049d41c423280


Fatal error : Out of memory

Operating system: Windows 8,1
Build version (signal-back --version): v0.1.6

Detailed description
While running the sript after entering the password i get the error.  Out of memory : cannot allocate 80936960-byte block (159844766 in use) fatal erro: out of memory.
Full relevant output

Probably a duplicate of https://github.com/xeals/signal-back/issues/38?

I realize I'm late to the party, but I ran into this error because I was using the wrong binary. Needed to be using the amd64 one; no issues after that.


Can "fast_imas_IPOL" read TIF files?

Hello, I'm currently using the "fast_imas_IPOL" executable in a University research project for geo-locating airborne images against satellite imagery.
My question: are there any plans to develop "fast_imas_IPOL" to read any other image formats besides PNG files? All of our airborne & satellite images are TIF files, geoTIFF specifically (TIF with geolocation info in the header). We can convert them to PNGs and that's what we're doing so far, but given the hundreds of terabytes of TIF files we have, this would be a large waste of disk space.
So, a three-part request:

If it does support TIF format and I simply haven't discovered how to use it, could I get a primer on how to do that? So far the executable works for PNG files but breaks for TIF files.

If it doesn't support TIF, are there any plans in the works to support that?

If there aren't plans to support TIF formats, would it be possible to get some pointers on where specifically in the source code we could look to create a branch and add that functionality?

Hello,
Indeed that functionality is of great use. So, I’ve added it myself by using the GDAL library.
Please take a look at the README.md file for a proper installation of GDAL on ubuntu and the new optional input arguments for fast_imas_IPOL.
Best Regards,
Mariano Rodríguez

Mariano,
This is fantastic, thank you so much! I use GDAL extensively in our work, so installing it on the Ubuntu platform is not a problem. That was an extremely quick turnaround, thank you so much for doing that!

Mike


First draft of Lecture 18

you should always make pull requests from feature branches ;)

the images with the matrices are pretty broken, check the pdf...


Discussion about Storage, response()->download() and Storage::fake()

Laravel Version: 5.4
PHP Version: 7.1

Description:
I have some trouble to understand how to download files created by the Storage facade. The response()->download() is expecting a full path and not a relative path from the storage root. To get the full path, I only found Storage::url(). Storage::url() can return the full path if we specify in the config the root path as URL. If the URL is not specified with a local driver, the default one is a weird "/storage" URL ( https://github.com/laravel/framework/blob/452d7e0afb5740d204b6e078a24a14fb7270c4f3/src/Illuminate/Filesystem/FilesystemAdapter.php#L357 ).
Moreover, if we fake the Storage adapter, only the 'root' config is set ( https://github.com/laravel/framework/blob/504bcffdb0b8ca23c5382067633318a699868ab5/src/Illuminate/Support/Facades/Storage.php#L24 ). So the URL default to "/storage" which doesn't exists so a FileNotFound exception is thrown by the controller.
Steps To Reproduce:
I push a sample demo to my Github to reproduce some of the problems with this management of Storage full paths.
https://github.com/ThibaudDauce/fake-storage/commit/dec491cccbf89589e88bde99c8bafb1e20cc38bd
Solution
https://github.com/ThibaudDauce/fake-storage/commit/dec491cccbf89589e88bde99c8bafb1e20cc38bd?diff=unified#diff-7e3ce459dfcc113722bdf4667ceffc11R30
I think the Storage::url() is not the right way to get the full path of a local adapter but I couldn't find another one. I often need to get the absolute path (mail attachment, response download, shell exec to create PDF…), maybe add a method (if it's not already here…) could be a fix (I can make a PR).
Something like Storage::fullPath('file') instead of Storage::getDriver()->getAdapter()->applyPathPrefix('file')

For suggestions and feature requests please use the https://github.com/laravel/internals repo.


Out of Space error on OpenAI servers

Error Type: TASK_EXECUTION_EXCEPTION
User exception:
ntime_resources/pip/14f34acc790047a95e39a14509b14c99a0377d40/virtualenv/lib/python3.10/site-packages/openai/_base_client.py", line 1634, in _request
raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': {'message': 'You have exceeded your file storage quota. Organizations are limited to 100 GB of files. Please delete old files or attempt with a smaller file size.', 'type': 'invalid_request_error', 'param': None, 'code': None}}

Looking at the openai dashboard I'm seeing
batch uploads of 30MB.
batch outputs of 14MB
The batch size is 10k, but these amounts will change based on the data strategy.
Based on the most recent run
Thats ~2,200 batches to fill up 100GB

As an immediate fix, I'll write a script that deletes all current files stored on the account - using the files.list API https://platform.openai.com/docs/api-reference/files/list

Deleted all files - you can see no files are now listed in the dashboard
https://platform.openai.com/storage


Structured Data 3.0

Those of you who know me, know I'm all about that bass structured data. We've got pretty awesome support for it already, via iteration 1.0 #3900 and 2.0 #4677 - and now I'd like to propose a few more enhancements, which I think should be relatively straightforward. Might be something for @AileenCGN?
I noticed this on Facebook this morning, and thought it was pretty cool. Also this by Slack a while back, which is equally cool.
So a bunch of things that I think we could potentially do to be more mobile, social, gobal and local.
Or, as I call it: Mosoglocal :dancer:
Publisher and Site
Add a general setting to blogs for "Facebook URL" and "Twitter URL" - which we should validate, and then we could output:
<meta property="article:publisher" content="https://www.facebook.com/page" />
<meta name="twitter:site" content="@user"/>

Applies to ALL page templates
NB: According to docs twitter:site is actually required for Twitter Cards to work at all.
This would also justify the creation of new theme helpers, probably<EMAIL_ADDRESS>and<EMAIL_ADDRESS>?
Author and Creator
Add a user setting for "Facebook URL" and "Twitter URL" - which we should validate, and then we could output the bits from my screenshot before:
<meta property="article:author" content="https://www.facebook.com/user" />
<meta name="twitter:creator" content="@user"/>

"Why add Facebook and Twitter profile properties? Isn't that clutter?" - kind of, but I think it's safe to say they would be widely used, and we already have support for Facebook Open Graph and Twitter Cards, so it makes sense. Longer term I'd be interested if we could make admin defined user profile properties like Slack recently did?
Applies to post, page, and author profile templates
Note: For rich data, deliberate use of www in facebook URLs output and no www in twitter URLs output. That's how both of those sites work - so minimal redirects by just using their preferred structure right off the bat.
JSON+LD docs ref here.
This would also justify the creation of new theme helpers, probably {{author.facebook}} and {{author.twitter}} ?
Slack Unfurls
This would add some rich data to Slack embeds. Source. Not sure if this is valid, because it's essentially a duplication of other properties (author and date) -- but seeing as every service except Slack is going to ignore it... do we care?
<meta name="twitter:label1" value="Written by" />
<meta name="twitter:data1" value="User Fullname" />
<meta name="twitter:label2" value="Published" />
<meta name="twitter:data2" value="January 1st, 2016" />

Applies to post and page templates
Locale
`
<meta property="og:locale" content="en_US" />

It would be great to add a blog language general setting and output this both via Open Graph and via a {{locale}} helper available for themes, and to affect the format of {{date}} - this one probably warrants its own issue.
Applies to ALL page templates
Bug in Description
Just noticed we seem to be outputting empty descriptions. We should either populate description with ~50 chars of {{excerpt}} or not display the description tags at all. I thought this was specced in an older issue, but can't seem to find it now. I wonder if this is what's causing the current bug of Slack refusing to unfurl any Ghost blog post? Eg.
<meta property="og:title" content="Moving to Singapore"/>
<meta property="og:description" content=""/>
...
<meta name="twitter:description" content=""/>

Just confirmed this bug is actively preventing twitter cards from working.

I've quoted bits I have questions on or that were questions below...

Add a general setting to blogs for "Facebook URL" and "Twitter URL" - which we should validate
Add a user setting for "Facebook URL" and "Twitter URL" - which we should validate

Cool, so we need some new db fields (no biggy, I've added them to #6301) - I think it makes 100% sense to add these as they're so ubiquitous.
From a UI perspective, I think the user would expect to copy & paste a whole URL for facebook, but only put their @username in for twitter? Example below, but I'm thinking you may have lots of opinions about the way this should be done:

This would also justify the creation of new theme helpers, probably<EMAIL_ADDRESS>and<EMAIL_ADDRESS>?

:+1:

Locale [...] this one probably warrants its own issue.

Yep, for sure :+1:

Bug in Description [...] I thought this was specced in an older issue

Yep! It's here: https://github.com/TryGhost/Ghost/issues/4424.
It was made very clear that we should not auto generate a meta description, as google does this. However, I think this same rule has been incorrectly applied to twitter and og descriptions. I guess the twitter & og ones should come from excerpt?

From a UI perspective, I think the user would expect to copy & paste a whole URL for facebook, but only put their @username in for twitter?

For v1 - let's just make them both URLs? It's so much easier to validate and the UX is consistent between the two, at least.

Sounds exciting!

This looks cool! :)

Just noticed that for some reason we don't output structured data on page templates, which we probably should. Added to task list

@JohnONolan what about the paginated versions of the home, tag, author channels? Atm we don't do it there either.

I think that's still ok as-is 👍🏻

Adding a note here to summarise some conversations that happened in #dev and some changes that are  now being made.
For both the blog & user settings, we will only be storing the "username" part of the facebook & twitter urls. These are the unique information, whereas the remainder of the URL is the same for everyone and very simple to provide helpers for if needs be.
Therefore, when accessing<EMAIL_ADDRESS>or {{author.twitter}} in a theme, or fetching a user's "twitter" column via the API, you'll get "@tryghost" for example.
The structured data will be updated to generate the URLs from the usernames, using a new set of utilities. To make it nice and easy for themes to output the full url, we'll be adding two new helpers: {{twitter_url}} and {{facebook_url}} which will default to outputting the twitter/facebook URL of the current context using the same utility as the structured data, E.g. you might output an author's twitter URL like this:
{{#author}}
{{#if twitter}}{{twitter}}{{/if}}
{{/author}}

If you're not inside an "author" or "user" object, then the helper will default to the blog's twitter URL.
If the default behaviour is not what you want, then you can tell it exactly what to output the url for, E.g. {{twitter_url @blog.twitter}} or even {{twitter_url "SoVeryBritish"}}.
The {{twitter_url}} helper will handle removing the @ from the front of a username if one is present, to create the canonical version of a twitter URL (although both are valid).
The facebook version of the helper will be exactly the same, except it will output correct facebook urls, which include the www. and has extra handling to ensure that it works regardless of whether there's a slash at the start of the username, as facebook page names can include slashes.


componentWillReceiveProps has been renamed, and is not recommended for use.

See https://fb.me/react-async-component-lifecycle-hooks for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: KeyboardAwareScrollView

This is the error I get after updating to Expo SDK36, which uses React 16.9 and React Native 0.61. Can you refactor the package that I love to use with the renewed APIs?

it is fixed in 0.9.1, anyone who encounter this problem, please update your package.


Can't login using Ubuntu 18.04

Hi, I am currently unable to login to the client on my Ubuntu installation as clicking the various login buttons does nothing. Is there a direct link to the login page?

What login buttons? Loggining to RuneLite or game?

Message box should pop up if the client fails to open the website. Otherwise it is using your default browser. And the message box will say that it will copy the URL to your clipboard.

Nothing appears but I'll try pasting into the browser to see if it copies to the clipboard anyways

The messagebox should appear, weird. then, I guess it succeds in trying to open your browser but your default browser is set wrong

The default browser is Firefox and thats the only one that's installed in Ubuntu.

also having this issue on ubuntu. i click the button and nothing at all happens.

Alright, I found a workaround from here.
TLDR:
printf '\xfe\xed\xfe\xed\x00\x00\x00\x02\x00\x00\x00\x00\xe2\x68\x6e\x45\xfb\x43\xdf\xa4\xd9\x92\xdd\x41\xce\xb6\xb2\x1c\x63\x30\xd7\x92' | sudo tee /etc/ssl/certs/java/cacerts
sudo /var/lib/dpkg/info/ca-certificates-java.postinst configure

Now you should be able to to log in.

the workaround posted works for me! great work :D thanks a lot

Can also confirm this issue on Ubuntu 18.04 LTS btw with the latest jar file.

on oracle java this did the trick for me:
sudo apt install ca-certificates-java

to further comment on @bugii, I had to add hardware acceleration in a .sh file to get GE/highscores lookup. My .sh file has: '#!/bin/sh
java -jar ~/Desktop/RuneLite.jar --mode=OFF/

This looks like problem on users side with not having certs properly configured, the guide is now on wiki and not much we can we do about that, closing.

Have the same issue, fixing certificates does not remedy the problem. Login link opens a module briefly then does nothing.


WFLY-5030 Intermittent failure of deployment containing two datasourc…

…es in -ds.xml

Windows Build 2337 is now running using a merge of 557a598f694451faab8303822614a8e63b6cb817

Linux with security manager Build 2152 is now running using a merge of 557a598f694451faab8303822614a8e63b6cb817

Linux Build 7283 is now running using a merge of 557a598f694451faab8303822614a8e63b6cb817

Linux with security manager Build 2152 outcome was SUCCESS using a merge of 557a598f694451faab8303822614a8e63b6cb817
Summary: Tests passed: 896, ignored: 285 Build time: 0:06:20

Linux Build 7283 outcome was SUCCESS using a merge of 557a598f694451faab8303822614a8e63b6cb817
Summary: Tests passed: 3090, ignored: 366 Build time: 0:48:30

Windows Build 2337 outcome was SUCCESS using a merge of 557a598f694451faab8303822614a8e63b6cb817
Summary: Tests passed: 3088, ignored: 367, muted: 1 Build time: 0:50:59

I'll merge this but at some point this should be refactored to not use a static field for a lock


Full installation from downloaded ISO

Fixes rancher-sandbox/cOS-toolkit#1054
Signed-off-by: David Cassany<EMAIL_ADDRESS>

I manually tested it by downloading the latest cOS release ISO and calling:
# Create a fresh disk
$ qemu-img create -f raw disk.img 30G
$ sudo losetup -f --show disk.img
$ sudo elemental install --iso cOS-Seed-green-0.8.2-5-gc8e7ede1-x86_64.iso /dev/loop0
$ sudo losetup -d /dev/loop0

# Launch disk
$ qemu-kvm -m 2048 -hda disk.img -bios /usr/share/qemu/ovmf-x86_64.bin

This really needs to be documented, maybe a comment in the code portion as for now before moving to docs?

I manually tested it by downloading the latest cOS release ISO and calling:
# Create a fresh disk
$ qemu-img create -f raw disk.img 30G
$ sudo losetup -f --show disk.img
$ sudo elemental install --iso cOS-Seed-green-0.8.2-5-gc8e7ede1-x86_64.iso /dev/loop0
$ sudo losetup -d /dev/loop0

# Launch disk
$ qemu-kvm -m 2048 -hda disk.img -bios /usr/share/qemu/ovmf-x86_64.bin

This really needs to be documented (very nice!), maybe a comment in the code portion as for now before moving to docs?

Yes this should be documented somewhere, gonna think about the possibilities. I think we should also release ISOs not in a tarball, directly release the ISO itself. This way we could use the remote url directly for that purpose.
With the above I also missed something like --force-mbr for legacy disk creation (yes, we are at 2022 and hipervisors are still easier to work with MBR 😅) since elemental detected EFI on my host it executed an EFI installation.

I manually tested it by downloading the latest cOS release ISO and calling:
# Create a fresh disk
$ qemu-img create -f raw disk.img 30G
$ sudo losetup -f --show disk.img
$ sudo elemental install --iso cOS-Seed-green-0.8.2-5-gc8e7ede1-x86_64.iso /dev/loop0
$ sudo losetup -d /dev/loop0

# Launch disk
$ qemu-kvm -m 2048 -hda disk.img -bios /usr/share/qemu/ovmf-x86_64.bin

This really needs to be documented (very nice!), maybe a comment in the code portion as for now before moving to docs?

Yes this should be documented somewhere, gonna think about the possibilities. I think we should also release ISOs not in a tarball, directly release the ISO itself. This way we could use the remote url directly for that purpose.

for cOS itself wouldn't really matter as ISOS shouldn't be used for installation etc at the end ...  but we can still use os2 ISOS for testing :grin:

With the above I also missed something like --force-mbr for legacy disk creation (yes, we are at 2022 and hipervisors are still easier to work with MBR sweat_smile) since elemental detected EFI on my host it executed an EFI installation.

:+1:


[Pick 2.0](inverted index) fix array inverted index builder error (#29869)

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Exclude jtreg testcase TestObjectDescription.java for jdk8

Exclude jtreg testcase jdk/jfr/event/oldobject/TestObjectDescription.java for jdk8, which run timeout
Fixes: #4342

hi @sendaoYan - I've created an umbrella issue so we can go through all of the jdk_jfr testcases that are excluded and see what upstream test updates can be made to stabilize them. Suggesting to change your PR to use it, so you do not need to keep an open issue in your repo.

OK, thanks


Case constraints are too strict

When generating constraints for case expressions, Source requires "the scrutinee and the alternatives must have the same temporality". Could this restriction be relaxed? There's a comment that this may be restrictive than necessary....
Example: let fold1 a = ((0,0),0) : case a | ((n,m),m2) -> (let d = (double value) - m ~> ((n + 1, m + d / n), m2 + d * ((double value) - m))) end ~> ...

ahh. good catch. yep!
so there is a constraint called ReturnOfLet or something, which computes the return temporality of a let.
maybe we could require all the alternatives to be the same temporality, and then the return temporality will just be ReturnOfLet scrut alts?

Tran fixed this


Debug Issue

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.88.1
OS Version: Windows 10

while debugging js it's got stuck and it's often asking keep waiting window pops

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Package maatwebsite/excel still being installed when you want to use fast-excel (or another Excel-package)

Hi,
When you want to use the fast-excel package (or another Excel-package) instead of maatwebsite/excel, this package will be still installed due it's being installed in the root-required selection.
It's better to move maatwebsite/excel to the suggest selection, so we can pick-up one of the suggestions instead.
Technically this /is/ a breaking change, but I don't know which branch you are using for v5, since master is little bit behind already.

Updated master branch and let's release this to v5 to avoid any breaking change. Thanks!


TEST2-MOTECH-2144 test for PR jobs

Can one of the admins verify this patch?

test this please

test this please

The build seems to fail correctly. I'll close this PR now.


Resizing a column ignores cell template.

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
When resizing an individual column by dragging the header column dividers, where the body cells use a template, the template is ignored and the value is directly shown.
Expected behavior
The cell template is used to render the cell contents, even when the column is resized.
Reproduction of the problem
Resize the 'Gender' or 'Age' columns in the Templates Inline Demo
Please tell us about your environment:

Table version: 1.1.0

Angular version: 2.1.2

Browser: Google Chrome: 54.0.2840.71 (Official Build) m (32-bit)

OS: Windows

Fixed in 1.2


"visible" section controllers

- (NSArray<IGListSectionController<IGListSectionType> *> *)visibleSectionControllers; in IGListAdapter is not all visible section controllers sometimes.
For example, in a list, there is a section controller, with zero cell, but there's a header, footer or other supplementary view. So the section controller is still "visible".

Ah ya, we're only using -[UICollectionView visibleCells] atm, but absolutely not perfect. Tracking visible supplementary views is much more complicated b/c

visibleSupplementaryViewsOfKind: is iOS 9+
Requires knowing element kinds ahead of time

Maybe instead we should query -[UICollectionViewLayout layoutAttributesForElementsInRect:] w/ collectionView.bounds and just nab -[UICollectionViewLayoutAttributes indexPath] to build a set of section controllers?
Should be easy to unit test too.

@rnystrom Want to card that up separately? Seems like a nice starter task!

@rnystrom I took a stab at implementing your fix idea + added a unit test!


Add back max_pending_accept_reset_streams

Adds back this function which was previously in hyper 0.14.
The original merge into hyper is
here
This follows the original closely, with some minor wording improvements in the outer line docs.
Closes https://github.com/hyperium/hyper/issues/3461.

I updated the version to 0.1.2, possibly prematurely. This function is used by tonic so I'd like to have it for the tonic hyper 1.0 update :)

Hi @seanmonstar, I've synced and updated this PR.
With https://github.com/hyperium/hyper/pull/3507, this should complete the re-addition of this function.

https://github.com/hyperium/hyper-util/pull/90 was merged, we can close this PR.

Superseded by #90 (merged) and #102


Update sbt-typelevel-ci, ... to 0.5.0-RC11

About this PR
📦 Updates

org.typelevel:sbt-typelevel-ci
org.typelevel:sbt-typelevel-github
org.typelevel:sbt-typelevel-kernel
org.typelevel:sbt-typelevel-mergify
org.typelevel:sbt-typelevel-no-publish
org.typelevel:sbt-typelevel-settings
org.typelevel:sbt-typelevel-site
org.typelevel:sbt-typelevel-versioning

from 0.5.0-RC10 to 0.5.0-RC11
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel" }
}]

labels: sbt-plugin-update, early-semver-pre-release, semver-spec-pre-release, version-scheme:early-semver, commit-count:n:2

Superseded by #566.


Tips for removing the API?

I’ve used this wonderful project as a boilerplate but don’t have a need for the API piece. I wonder if there are any details around removing it, and just what bits are safe to pull from the codebase?

You can remove the API folder, all the scripts and the Express proxies, no problem. I did the same when I forked the project for my needs.
The API is more there as an example of how this can work.

Thanks for the recommendation! Just removing the API folder allowed me to track down any files that relied on it.

Did you remove the proxy?


Robovm support ?

Hi , sometimes i use robovm for ios development on java.
Can i use dl4j with robovm ?
For IOS

Yes, it should work although untested.
/cc @johanvos


Increasing the badge holder counter on menu item - during work

I would like to raise a new topic, increasing the badge holder counter on menu item, without reloading the page, but during work.
for example:
I have an grid with items, and a connected "Default Badge Holder" on app menu that counts positions, when a new item is added, the updated digit is visible after reloading the page, not after operation, in real time - during work

Have you tried updating it via:
UI.getCurrent().access(() -> {
            // increase badge
});

Closed due to inactivity

I'm sorry for my absence, yes i have tried, unfortunately it doesn't work.

Is there any solution for changing count in real time, during work, not after reload page, when DefaultBadgeHolder counter is increasing or decreasing.

Have you tried the mentioned solution of mine?

I tried, it doesn't work, Is there any solution for changing count in real time, during work, not after reload page, when DefaultBadgeHolder counter is increasing or decreasing.

Can I see an example of your code with using my posted solution?

private void reloadNotifications() {
    caseCountHelper = serviceWithData from db
    badgeHolderList = new ArrayList<>();
    caseCounterList = integerListWithCount
    initDefaultBadgeHolders();
    caseCounterList = caseCountHelper.getCaseCounterList();

    for (DefaultBadgeHolder dBh : badgeHolderList) {
        dBh.clearCount();
    }

    notificationHolder.clearNotifications();

        try {
            getUI().ifPresent(ui -> ui.access(() -> {
                addNotification(HIGH);

                badgeHolderList.get(0).setCount(this.caseCounterList.get(0));
                badgeHolderList.get(1).setCount(this.caseCounterList.get(1));
                badgeHolderList.get(2).setCount(this.caseCounterList.get(2));
                badgeHolderList.get(3).setCount(this.caseCounterList.get(3));
                badgeHolderList.get(4).setCount(this.caseCounterList.get(4));
            }));
        } catch (Exception e) {
            e.printStackTrace();
        }

}

Have you checked  if getUI().ifPresent() is successful?

Also, did you add the mentioned @Push Annotation? Does your servlet container has Push support?

Have you checked if getUI().ifPresent() is successful? - yes, "Also, did you add the mentioned @Push Annotation? Does your servlet container have Push support?" - how can i check this ?

Did you add to your AppLayoutRouterLayout the @Push as follows?:
@Push
public class MyAppLayoutRouterLayout extends AppLayoutRouterLayout {
   ...
}

how can i check this ?
What Servlet container are you using?

Oh wait, getUI().isPresent() returl false, hmm why ? "What Servlet container are you using?" - Wildfly

Oh wait, getUI().isPresent() return false, hmm why ?

Well then you found your problem
I recommend try saving the UI instance in the constructure to an attribute, instead of retrieving it via getUI().

"What Servlet container are you using?" -

Hopefully not a tooo old version.

latest Wildfly

I recommend try saving the UI instance in the constructure to an attribute, instead of retrieving it via getUI().

Note that this my cause issues in other usecases.

"I recommend try saving the UI instance in the constructure to an attribute, instead of retrieving it via getUI()." - what do you mean ? Can you be more specific?

public class MyView extends VerticalLayout {
    private final UI ui; // use this instead of getUI()

    public MyView() {
        ui = UI.getCurrent();
    }
}

I understand, will try

Also you can try this addon (async-manager)[https://vaadin.com/directory/component/async-manager]

public class MainAppLayout extends AppLayoutRouterLayout{
private final UI ui;
public MainAppLayout() {
    ui = UI.getCurrent();
}

}
ui always false

Then try setting it onAttach as in the offical example.

it always doesn't  work, is there any solution, for example "OnChange listener" who will react when the number is changed and put in on the menu.

So you managed to get the UI instance as shown in the offical example?

yes

May I see your code again?

what exactly ?

The part how you update the UI, basically everything that involves getting and using UI instances or using UI::access.
Also I need to see how you start the task that updates the UI later on, I got the feeling you might do it by blocking the UI Thread.

Here some working code using the async-manager addon
public class MainAppLayout extends AppLayoutRouterLayout {
    private DefaultNotificationHolder notifications = new DefaultNotificationHolder();
    private DefaultBadgeHolder badge = new DefaultBadgeHolder(5);

    public MainAppLayout() {
        notifications.addClickListener(notification -> {/* ... */});

        LeftNavigationItem menuEntry = new LeftNavigationItem("Menu", VaadinIcon.MENU.create(), View6.class);
        badge.bind(menuEntry.getBadge());

        init(AppLayoutBuilder
                ...
                .build());

        AsyncManager.register(this, asyncTask -> {
            for (int i = 0; i < 10; i++) {
                Thread.sleep(1000);
                int finalI = i;
                asyncTask.push(() -> {
                    notifications.addNotification(new DefaultNotification("Test" + finalI, "Test" + finalI));
                    badge.increase();
                });
            }
        });
    }
}

bean CaseCountHelper {- which count DefaultBadgeHolder:
public void countCases() {
getDataFromDb;
reloadNotifications();
}
public void reloadNotifications() {
    for (DefaultBadgeHolder dBh : badgeHolderList) {
        dBh.clearCount();
    }

    try {
        this.badgeHolderList.get(0).setCount(this.caseCounterList.get(0));
        this.badgeHolderList.get(1).setCount(this.caseCounterList.get(1));
        this.badgeHolderList.get(2).setCount(this.caseCounterList.get(2));
        this.badgeHolderList.get(3).setCount(this.caseCounterList.get(3));
        this.badgeHolderList.get(4).setCount(this.caseCounterList.get(4));
    } catch (Exception e) {

        e.printStackTrace();
    }
}

}
public class MainAppLayout extends AppLayoutRouterLayout  {
private UI ui;

@Override
public AppLayout getAppLayout() {
this.caseCountHelper.setService <- getData from db
try {
//Thread.sleep(1000);
ui.access(() -> {
this.caseCountHelper.countCases();
});
    } catch (Exception e) {
        e.printStackTrace();
    }

}
@Override
protected void onAttach(AttachEvent attachEvent) {
    ui = attachEvent.getUI();

}
}

Your Code blocks the UI unnecessary. Don't count you cases on the UI Thread, create another Thread for this.
ui.access(() -> {
                this.caseCountHelper.countCases();
});

onAttach will be called when the Component is attached to the UI, which is too late for you code to work. So countCases must be called after onAttach. You can ignore all of this if you use the AsyncManager addon please use it.
Also update your App-Layout version it is pretty old.

Still doesn't work, i don't know did you understand my problem,your solution work when application is running, but once, case count on app menu item is visible but when i'm doing somethink during work, what is changing counter - didn't update him on main list in real time - i think just need a value change listener who will react when value is changed...am I wrong ?

Problem has been solved

Can you maybe contribute the solution?

Problem has been solved

How did you solve the problem? Im also facing the same problem

Eventually, the solution didn't work. I'm sorry I didn't answer before.

Eventually, the solution didn't work. I'm sorry I didn't answer before.
…

problem solved. check this issue that I have created but was able to solved it as well together with some friends. #308


Drag & drop creates function node instead of Set or Get

Godot version:
v3.1.dev.calinou.1800664
OS/device including version:
windows 10 x64
Issue description:
In visual script
when drag & drop from Scene tab to visual script area, it shows a list of properties, after select, it create a function node instead of Get or Set node.
when change the function it shows a list of methods.
https://drive.google.com/open?id=1QgBxuP37_D_dvUatKIo32HT4Ar_IgUKX
the correction :
when drag & drop it will show a list of methods.
properties can be added by drag & drop from inspector, or by holding shift and drag & drop from Scene tab to visual script area, then it will show a list of properties and create a Get or Set node.
https://drive.google.com/open?id=1LRnvQsdJsBr8FcoZDTlFjTNmHzRBZgJI

Please can anyone explain why drag & drop from Scene tab to visual script area shows a list of properties ?

Marked as enhancement for now, cc @fire - can you explain this behavior ?

When I last tested this behavior in July, it found an editor node with an internal name.
Maybe we should figure out what the expected behaviour should be like and work towards that.
I'm not able to work on this until I'm back from GDC.

One possible behavior is to get the node path, another is to get the class name of the node and get that class's methods / properties.

I think methods and properties is what everybody expects when draging the node into the editor.

@Jummit Can you check the current workflow. You can now control-f and get methods.

The current workflow is not clear and not good , the old (3.0.x) was very nice :
drag & drop shows select method
easy way to create get & set nodes
properties nodes can be dragged from inspector
I hope you guys keep the good things instead of unclear view

Now when drag & drop from Scene tab to visual script area , it shows a list of built in functions instead of list of methods
the current (not usable) :

what it should show

I dragged the WorldEnvironment from the node tree and it gives this:

Is this acceptable?

Can anyone still reproduce this bug in Godot 3.2.2 or any later release?

Can't reproduce in v3.2.2


Fix DB check

Completes #3087.

If you want to fix charge_volume in a local DB backup here's the fixed script:
BEGIN;

DO $$
DECLARE
    payday record;
    new_ncharges int;
    new_charge_volume decimal(35,2);
    new_charge_fees_volume decimal(35,2);
BEGIN
    FOR payday IN SELECT * FROM paydays LOOP
        CREATE TEMP TABLE our_charges AS
            SELECT *
              FROM exchanges
             WHERE "timestamp" >= payday.ts_start
               AND "timestamp" < payday.ts_end
               AND amount > 0
               AND recorder IS NULL
               AND (status IS NULL OR status <> 'failed');
        new_ncharges := (SELECT count(*) FROM our_charges);
        new_charge_volume := (SELECT COALESCE(sum(amount + fee), 0) FROM our_charges);
        new_charge_fees_volume := (SELECT COALESCE(sum(fee), 0) FROM our_charges);
        UPDATE paydays
           SET ncharges = new_ncharges
             , charge_volume = new_charge_volume
             , charge_fees_volume = new_charge_fees_volume
         WHERE id = payday.id
           AND (ncharges <> new_ncharges
                OR charge_volume <> new_charge_volume
                OR charge_fees_volume <> new_charge_fees_volume);
        IF FOUND THEN RAISE INFO 'updated payday %', payday.id; END IF;
        DROP TABLE our_charges;
    END LOOP;
END
$$;

END;

I've already fixed the production DB.


German I18n adjustments

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

A few German translations don't sound good at the moment. This PR changes them.
Changes were discussed in Slack channel "i18n-de".
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 77.581% when pulling 8f7e17e6ae3ab1b9341b7e82b616f17220e89e19 on neohelden:master into 9b6e798eb616ddac56e834ca1c83992ebaa404c6 on node-red:master.

When I click on the Details button of the pending licence it says You have signed the CLA for node-red/node-red, but it's still pending. Is that normal?

The commit in this pr has been created with a different email address to the one associated with your GitHub account. This means the CLA bot cannot verify you are the same person who committed the change.
You can either:

recreate the commit, being sure to set your email address to match the one in your github account
or add whatever email address is associated with the commit to your github profile. You can use git log to see the details of the commit to see what email is associated with the commit.

https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

@knolleary many thanks for the explanation


[requests.packages.urllib3.connectionpool] Connection pool is full, discarding connection:

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (0.54):
0.54.0 - first noticed.  Still exists on 0.55
Python release (python3.6.2):
3.6.3
Component/platform:
urllib3 - 1.22
InfluxDB/Grafana/HA
Description of problem:
Since upgrading python to 3.6.3, getting these warnings in the logs
WARNING (SyncWorker_10) [requests.packages.urllib3.connectionpool] Connection pool is full, discarding connection:
Connection pool is filling up while trying to connect to an influxdb/Grafana instance.  These connection pools did not fill up as fast on 3.4.  Tried updating urllib3 to 1.22 from 1.19 and still the same.
Expected:
Connection Pool to not be full.
Problem-relevant configuration.yaml entries and steps to reproduce:

Restart HA, connections to grafana start being discarded.

Traceback (if applicable):

Additional info:
I realize this may or may not be an HA thing, but curious if anyone has any insight into how to address this?

Same problem with HA 0.56.2, python 3.5.3, InfluxDB 1.3.7, Grafana 4.6.0 and raspbian stretch.
All in one installation made today.

Yup, I'm getting the same error to...
2017-11-04 14:40:06 WARNING (Thread-3) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS> 2017-11-04 14:40:06 WARNING (Thread-12) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS> 2017-11-04 14:40:06 WARNING (Thread-14) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS> 2017-11-04 14:40:13 WARNING (Thread-15) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS>

Same situation here:
2017-11-15 17:55:24 WARNING (Thread-38) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS>
2017-11-15 17:55:24 WARNING (Thread-31) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS>
2017-11-15 17:55:24 WARNING (Thread-15) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS>
2017-11-15 17:55:24 WARNING (Thread-11) [urllib3.connectionpool] Connection pool is full, discarding connection: <IP_ADDRESS>

same situation here
Any suggestion
After moving from rhel 7.3 to rhel 7.4 with redhat ospd10
Dec 21 13:35:08 undercloud ironic-api: 2017-12-21 13:35:08.007 3370 INFO eventlet.wsgi.server [req-158d5726-fc86-4932-87c2-a492b5d7f229 ironic service - - -] <IP_ADDRESS> "GET /v1/nodes/detail?instance_uuid=3058c8f9-6e7d-4d4a-b884-0b1c29330964 HTTP/1.1" status: 200  len: 2642 time: 4.0776930Dec 21 13:35:08 undercloud ironic-api: 2017-12-21 13:35:08.019 3370 WARNING requests.packages.urllib3.connectionpool [-] Connection pool is full, discarding connection: <IP_ADDRESS>Dec 21 13:35:08 undercloud ironic-api: 2017-12-21 13:35:08.046 3370 INFO eventlet.wsgi.server [req-712dc82b-434f-4d98-8383-1e9732ca39f3 ironic service - - -] <IP_ADDRESS> "GET /v1/nodes/detail?instance_uuid=fd61cb62-55d4-4e8d-a58a-59e8821b0c86 HTTP/1.1" status: 200  len: 2641 time: 1.2141080


Fixed URL

Update URL to point to the Azure repository.

@jamasten thanks for your contribution, missed this one.


feature: expose vscode.action_into_insert and neovim.action_into_insert

There are some vscode bindings which create behaviors which are incompatible with nvim. However, we would like to intelligently ease the transition and allow clever behavior from normal mode.
The best example is vscode multi cursor like C-S-L for editor.action.selectHighlights or C-d for editor.action.addSelectionToNextFindMatch.
It would be nice to be able to do the following (equivalent, though I prefer the latter):
vim.keymap.set({ "n", "x", "i" }, "<C-S-L>", function() require("vscode-neovim").action_into_insert("editor.action.selectHighlights") end)

or
{
  "key": "ctrl+shift+l",
  "command": "neovim.action_into_insert",
  "args": "editor.action.selectHighlights",
  "when": "editorFocus && neovim.init && neovim.mode != 'insert'"
}

This would remove the need for https://github.com/vscode-neovim/vscode-multi-cursor.nvim/blob/main/lua/vscode-multi-cursor/wrappers.lua, because we can make these bindings default for core (and generically handle any other binding which should move to insert mode before executing).
https://github.com/vscode-neovim/vscode-neovim/assets/16546293/8952f29c-66f4-4e16-aec4-a677e654da90

This is not worthy to be an API

Fair enough, but I think this is universal enough to be builtin bindings (vscode multi cursor commands work in normal mode out of the box). How can we support this in a good way? That's what I wanted to make a generic API in case anyone else wants to transition from insert mode along with a command.

What about an extra arg in vscode.action that lets you specify to enter insert mode before running the action?

Perhaps we can place it in the vscode.util module.

What about an extra arg in vscode.action that lets you specify to enter insert mode before running the action?

The main consideration is that there are many aspects to consider if we want to make this method generic. Perhaps offering some helper functions would be better.


[FLINK-11578][tests] Port BackPressureStatsTrackerImplITCase to new code base

What is the purpose of the change
Port BackPressureStatsTrackerImplITCase to new code base
Brief change log

See commits

Verifying this change
This change added tests and can be verified as follows:

This change is a test.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the review... merging.


amazonlinux2 and amazonlinux targets

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area pkg
/area tests
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #41
Fixes #45
Special notes for your reviewer:

[x] tested on amazonlinux2
[x] tested on amazonlinux
[x] examples in the readme

This is needed to avoid situations like https://github.com/falcosecurity/falco/issues/1113
Does this PR introduce a user-facing change?:
new: amazonlinux2 target
new: amazonlinux target

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Issue on amazonlinux:
[  167.128008] falco: disagrees about version of symbol module_layout

LGTM label has been added.  Git tree hash: dea1e6409cad5453c333830005608cc0568f7e86

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Overriding property type in derived class

Consider the following classes:
class Base
{
    /**
     * @var BaseType
     */
    protected $prop;
}
class Child extends Base {}

How do I set a type for $prop property in the Child class using annotations?
/** @var AnotherType $prop */ doesn't work unless I copy the property declaration into the child class.

use {@inheritDoc}

@miguelbacalhau how, exactly?

Looking at it now I am not sure what a I said is correct.
I know you can use `/**  {@inhritdoc} */ with methods but for properties I am not sure.


[i2c] Target feature requests

Please see this document
The feature requests are pretty lightweight and primarily relate to handling bad hosts and host back pressure.

@mdhayter
@igk8

@martin-lueker, @tunghoang290780 - how is the implementation of these two I2C features coming along?

Unless I'm mistaken we are just now getting to basic target functionality, but @igk8 and @tunghoang290780 should confirm

These two features are being implemented in PR #4739

These two features are being implemented in PR #4739

These two features are being implemented in PR #4739

PR #4906

These two features are being implemented in PR #4739

PR #4906

this has been added by @igk8 , closing.


Update README.md

Running the command:
# dapr run --app-id nodeapp --app-port 3000 --dapr-http-port 3500 node app.js

Results in:
Error: unknown flag: --dapr-http-port

It works correctly when using -p/--port
Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] The quickstart code compiles correctly
[ ] You've tested new builds of the quickstart if you changed quickstart code
[ ] You've updated the quickstart's README if necessary

@aronchick master branch of dapr/quickstarts have breaking changes that work with edge version of dapr. We are deprecating -p/--port option in the upcoming release. If you want to run the sample please checkout the correct version as mentioned here.

Thanks! The problem was only that I downloaded the most recent version using the instructions in the same location, and it didn't work (because the docs have already been updated).

Sorry I didn't get you. So by latest do you mean you have used the edge version of dapr and master version of quickstarts?

Oh I just mean I followed the instructions as listed here, and hit a bug. I don't know if the instructions result in me using master or are pin to a version, but the instructions were the ones that failed and led me to this

From: Pruthvidhar R Dhodda<EMAIL_ADDRESS>Sent: Monday, August 17, 2020 8:27:34 PM
To: dapr/quickstarts<EMAIL_ADDRESS>Cc: David Aronchick<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dapr/quickstarts] Update README.md (#290)
Sorry I didn't get you. So by latest do you mean you have used the edge version of dapr and master version of quickstarts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdapr%2Fquickstarts%2Fpull%2F290%23issuecomment-675227619&data=02|01|david.aronchick%40microsoft.com|d874c8b796a84cc87a6a08d84326a61e|72f988bf86f141af91ab2d7cd011db47|1|0|637333180557499498&sdata=pE1V7GbHakmQGbeCQ4%2FmqsS6nXtc2gotbrjKMp3fPw8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAMQ5J7FLVGZLZ6UVZJATLSBHYKNANCNFSM4QAPH6XA&data=02|01|david.aronchick%40microsoft.com|d874c8b796a84cc87a6a08d84326a61e|72f988bf86f141af91ab2d7cd011db47|1|0|637333180557509488&sdata=IaeXXHktsTqDgaH74otALf6vxexl5wozDRDB%2F1n9XR0%3D&reserved=0.

This has been a point of confusion before but we tried to make it clear in the docs to checkout the correct tag for quickstarts. This is the step where we mention to checkout the correct tag of quickstarts in hello-world. As you can see here in the 0.9.0 version of quickstarts the option used is --port which should have worked if you were using 0.9.0 runtime version of dapr.
May I know which version of dapr were you using(dapr --version)?  and which version of quickstarts have you checked out? - just trying to understand if there is a mistake, if so we would love to correct it.

Ah, I was just using the default as instructed here, going line by line. Looking at the instructions (https://github.com/dapr/docs/blob/master/getting-started/environment-setup.md#environment-setup), it'd actually download from 'master' which would be the problem (the instructions are out of sync).


feat: S3 batch storage

Closes #1070

:books: Documentation preview :books:: https://meltano-sdk--1087.org.readthedocs.build/en/1087/

@jamielxcarter and @edgarrmondragon - This is awesome - I'm happy to see the implementation was so straightforward.
What is unclear to me as of yet is what instructions to provide to (1) users and (2) developers.
For developers, if they want to opt in to including the s3 extra, they probably would do so in poetry.toml - should we have a commented-out section in the cookiecutter for guidance?
And for users, especially if the developer has not already bundled the s3 extra, what's the recommendation to them for bundling the extra library during their install? Assuming a tool like pipx or meltano is auto-creating a virtual environment, it's not clear to me how to add the s3 library into the virtualenv appropriately. Perhaps?:

For meltano users, should they append singer-sdk[s3] or fs-s3fs to the pip_url in meltano.yml.
For pipx users, should they use pipx inject, as in pipx inject tap-mytap fs-s3fs or similar?

@aaronsteers @jamielxcarter I think there's a couple of options to trickle down support for S3, and the distinction between

Developers: tap creators and maintainers
Users: users of the tap (via Meltano or otherwise)

is useful.
Option 1: All Users get the extra dependency
[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
singer-sdk = { version="0.11.1", extras = ["s3"] }

Option 2: Extras all the way down
Make the extra dependency a passthrough, so users would have to explicitly request the extra:
pipx install 'tap-github[s3]'

Doesn't work at the moment, unfortunately:

https://github.com/orgs/python-poetry/discussions/4313#discussioncomment-1757450
https://github.com/python-poetry/poetry/issues/834

@aaronsteers @jamielxcarter I think there's a couple of options to trickle down support for S3, and the distinction between

Developers: tap creators and maintainers
Users: users of the tap (via Meltano or otherwise)

is useful.
Option 1: All Users get the extra dependency
[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
singer-sdk = { version="0.11.1", extras = ["s3"] }

Option 2: Extras all the way down
Make the extra dependency a passthrough, so users would have to explicitly request the extra:
pipx install 'tap-github[s3]'

Doesn't work at the moment, unfortunately:

https://github.com/orgs/python-poetry/discussions/4313#discussioncomment-1757450
How can I specify differing sets of dependency extras for each of my project's extras? python-poetry/poetry#834

Well said.
I think for taps and targets using AWS-inclined system like redshift and snowflake, the developer can choose option 1 and just ship it all the time for all users.
For the user opt-in scenario (meaning the tap doesn't bias towards aws/s3, but still the user might want/need to use S3 anyway), is it just the automatic pass-through that doesn't work? Or, said another way, could we explicitly re-declare the s3 in the boilerplate cookiecutter templates? This would presumably give all users the option, but of course the extra declaration could still be removed by a developer - or not included in the first place.
Would that work? And if developers remove it (or don't add it), the user would need to find another means to inject?

@aaronsteers @jamielxcarter I think there's a couple of options to trickle down support for S3, and the distinction between

Developers: tap creators and maintainers
Users: users of the tap (via Meltano or otherwise)

is useful.
Option 1: All Users get the extra dependency
[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
singer-sdk = { version="0.11.1", extras = ["s3"] }

Option 2: Extras all the way down
Make the extra dependency a passthrough, so users would have to explicitly request the extra:
pipx install 'tap-github[s3]'

Doesn't work at the moment, unfortunately:

https://github.com/orgs/python-poetry/discussions/4313#discussioncomment-1757450
How can I specify differing sets of dependency extras for each of my project's extras? python-poetry/poetry#834

Well said.
I think for taps and targets using AWS-inclined system like redshift and snowflake, the developer can choose option 1 and just ship it all the time for all users.
For the user opt-in scenario (meaning the tap doesn't bias towards aws/s3, but still the user might want/need to use S3 anyway), is it just the automatic pass-through that doesn't work? Or, said another way, could we explicitly re-declare the s3 in the boilerplate cookiecutter templates? This would presumably give all users the option, but of course the extra declaration could still be removed by a developer - or not included in the first place.
Would that work? And if developers remove it (or don't add it), the user would need to find another means to inject?

@aaronsteers @edgarrmondragon I think I've implemented what was discussed. Let me know if any further changes are needed!

@aaronsteers @jamielxcarter I think there's a couple of options to trickle down support for S3, and the distinction between

Developers: tap creators and maintainers
Users: users of the tap (via Meltano or otherwise)

is useful.
Option 1: All Users get the extra dependency
[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
singer-sdk = { version="0.11.1", extras = ["s3"] }

Option 2: Extras all the way down
Make the extra dependency a passthrough, so users would have to explicitly request the extra:
pipx install 'tap-github[s3]'

Doesn't work at the moment, unfortunately:

https://github.com/orgs/python-poetry/discussions/4313#discussioncomment-1757450
How can I specify differing sets of dependency extras for each of my project's extras? python-poetry/poetry#834

Well said.
I think for taps and targets using AWS-inclined system like redshift and snowflake, the developer can choose option 1 and just ship it all the time for all users.
For the user opt-in scenario (meaning the tap doesn't bias towards aws/s3, but still the user might want/need to use S3 anyway), is it just the automatic pass-through that doesn't work? Or, said another way, could we explicitly re-declare the s3 in the boilerplate cookiecutter templates? This would presumably give all users the option, but of course the extra declaration could still be removed by a developer - or not included in the first place.
Would that work? And if developers remove it (or don't add it), the user would need to find another means to inject?

@aaronsteers @edgarrmondragon I think I've implemented the changes discussed by you both. Let me know if anything is missing!


Test deep insights 516

Updated dependencies to have the last deep-insights
Related to https://github.com/CartoDB/cartodb-management/issues/4824

retest this please


[aarch64] any/all is suboptimal

any, all operations can be implemented on aarch64 with single instruction vminvq, vmaxvq.
Currently, xsimd uses vpmin, vpmax, it's low efficient.
E.g., below code can be significantly simplified on aarch64.
current code
template <class A, class T, detail::enable_sized_t<T, 1> = 0>
bool all(batch_bool<T, A> const& arg, requires_arch<neon>)
{
        uint8x8_t tmp = vand_u8(vget_low_u8(arg), vget_high_u8(arg));
        tmp = vpmin_u8(tmp, tmp);
        tmp = vpmin_u8(tmp, tmp);
        tmp = vpmin_u8(tmp, tmp);
        return vget_lane_u8(tmp, 0);
}

refined for aarch64
template <class A, class T, detail::enable_sized_t<T, 1> = 0>
bool all(batch_bool<T, A> const& arg, requires_arch<neon>)
{
        return vminvq_u8(arg);
}

Thanks! Would you like ot open a PR to improve this?
The way to go is to wrap this implementation into a new method requiring neon64 arch:
template <class A, class T, detail::enable_sized_t<T, 1> = 0>
bool all(batch_bool<T, A> const& arg, requires_arch<neon64>)
{
        return vminvq_u8(arg);
}

Sure. Will do.


Typo in the demo readme.md

Summary by CodeRabbit

Documentation

Updated README to reflect the renaming of the Python virtual environment from env to venv for local setup instructions.

@DakCrowder PTAL

@coderabbitai review

@coderabbitai review

@coderabbitai summary

@coderabbitai review

Two AIs for checking one character in a README :)


Users can't update addon

LuaLS/vscode-lua#142

As noted in the above mentioned issue, we need to:

[ ] Modify the workflow so a version tag is made on the lua-language-server-addon branch
[ ] Find a way to version without using the date of the most recent wiki change

On that last point: I don't think we can fetch a useful version from the wiki, since changes to the documentation are disconnected from changes to Garry's Mod. Perhaps a simple incrementing 'revision' based on the previous tag will be sufficient.
I'm thinking something like v001.


feat: add tests to @stdlib/utils/compact-adjacency-matrix

added tests to @stdlib/utils/compact-adjacency-matrix
Resolves #1330
Description

What is the purpose of this pull request?

This pull request:

add tests to @stdlib/utils/compact-adjacency-matrix

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #1330

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Hi @kgryte @Planeshifter ,These 2 tests to check property and method are failing for "fromEdge" method .But they are passing for all other methods.What can be the reason behind it?

@Pratik772846 The method is not a prototype method, but a static method. You should be checking for a method on the constructor.

@kgryte Sorry for the oversight. I have updated the tests. Please review it at your preference.


Make it possible to re-flow packages (detect new TFM's)

Implement a means of re-flowing packages so that, for example, Unsupported frameworks can be recognized usign newer NuGet.* libraries.
@skofman1 @xavierdecoster

LGTM


Workaround issue https://github.com/virt-s1/rhel-edge/issues/1943

/test-rhel-9-2

/test-rhel-9-2


update cost value form control

Description

Bugfix
What does this PR do?

Subscribe to value changes for cost and transform the value to a number. This makes sure that further access of the form and its values will evaluate to a number and not a string.
Breaking changes

Code review focus

Dependencies

Checks

[ ] Summary updated
[ ] Version view updated
[ ] Documentation added
[ ] Tests added
[ ] E2e tests created
[x] Successfully ran e2e tests before merge

closes GH-85

was able to reproduce the cost error locally with the docker setup,
then found this link with the same issue https://stackoverflow.com/questions/74342327/jackson-parse-double-from-string-pure-number-format/74345893
and comparing the poms of public and custom project found out that the public project was running on quarkus 2.13, which imports jackson 2.13, but was also importing jackson-databind 2.14, which takes precedence over the one already contained in the quarkus packages as it has a shorter path in the dependency tree (as per maven pom rules).
meaning: the bug should be solvable by updating the quarkus version to the newest one, and removing the explicit jackson package dependency.


Initial support for polars.

pyarrow is required for polars input. Categorical data is not yet supported, will wait until the re-coder is completed. This patch also helps setup the code for accepting CPU-based arrow data.

Add masked dataframe support
Initial support for polars.
Reuse the code for handling pyarrow table.

todo:

[x] perf check
[x] make specialization if needed.

cc @rongou .


Repeated chars

Describe the bug
I has facing some random test failure and after further investigation I found the following issue.
In my application I have a field that needs to be unique but fixture monkey is generating a duplicate value in some occasions. I gave a big range from the minimum string length to the max string length so the chances of this happening should be close to 0 but it´s not the case.
One thing that I noticed is that this duplicated values are always the a string with the same characters e.g. "AAAAAA". So I tried to set repeatedCharts to 0 but made no difference at all. I would expect with the value set to 0 for no duplicated characters to occur.
Not sure why but Fixture Monkey generates with more frequency than it should this kind of strings with all characters being equal.
Your environment
Java 17
Fixture Monkey 0.6.1
Steps to reproduce
https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/FixtureMonkeyTest.java
Expected behaviour
Shouldn´t generated values with repeated chars
Actual behaviour
Generates values with repeated chars

@esfomeado
Arbitrary does not work as we expect.
The test below fail as well.
@Property
	void arbitraryRepeatChar() {
		StringArbitrary strings = Arbitraries.strings().repeatChars(0);
		Set<String> set = new HashSet<>();

		for (int i = 0; i < 100; i++) {
			set.add(strings.sample());
		}

		then(set).hasSize(100);
	}

We'll add a new feature to make a unique value in 0.6.2.

has this issue been addressed?
I'm facing a similar issue.
Even if i set
.set("someLongField", Arbitraries.longs().injectDuplicates(0))

it will generate duplicate values from time to time.

@jyaquinas
Hello, if you are using version above 1.0.24. You can use as below.
LongArbitrary sharedLongArbitrary = Arbitraries.longs(); // it should be shared within your unique scope.

.set("$[*]", Values.unique(() -> globalLongArbitrary.sample()))

Thank you.

Thanks! Would be great to see this in the docs. Maybe I couldn't find it.


JS support problem

This is a great library, I would like to use it in my projects.
But I think it has a bug, it doesnt really support JS. It should also be able to generate code in JS with Jest or Mocha, maybe both, depending on given parameters.
And publish it on npm, it's a lot easier to install libraries from there.
Please fix it ASAP, thanks!

Closed due to inactivity


Generate JSON Schema by Kotlin dataclass

Hello! I would like to suggest a feature.
As far as I know, there is a feature as mapping of Kotlin Dataclasses to JSON representation. Klaxon library is able to serialize arbitrary classes.
Is there any plans to support some kind of generation of schema by Kotlin Class/Dataclass definition?
https://stackoverflow.com/questions/60147305/how-to-generate-json-schema-from-kotlin-class

Hi – thanks for your suggestion.
You seem to be talking about two different issues.  Yes, the Klaxon library is capable of serializing arbitrary classes, but so are several other libraries.  I recommend kjson, but there are several others, including Java libraries with a Kotlin veneer.
As to generating JSON Schema files from Kotlin data classes, I have given it some thought but I haven't seen a great deal of demand.  I have a code generator – json-kotlin-schema-codegen – which performs the reverse process, converting JSON Schema to Kotlin, and that is the way I am seeing more systems developed: start with a schema (or OpenAPI file containing multiple schema definitions) and generate data classes from that.
The JSON Schema official implementations page lists some schema generators from code, but there are none listed as taking Kotlin.  The Java implementations may work with Kotlin, but I haven't tried.

Yes, thanks for familiar link about generators, didn't see that section on the page.
The use-case of requested feature is quite opposite and maybe I am wrong about it's usefullness. I am building some kind of plugin-based system. The development of plugin is language-agnostic by design. Plugin parameters are retrieved by the main service via REST or gRPC API in the form of JSON Schema in order to know how to provide valid parameters to the plugin in response.
As from the point of the view of independent developer of plugin, there is no need to pre-define JSON Schema: you just need data class that configures plugin. All you need to do is to generate schema of this data class and provide it to external system, and validate configuration passed by external system against data class specification.

I'm not sure that I understand your use case, but I don't think any of my projects will be of much use to you.  You can probably derive a certain amount of information about the structure of an object from the data class (from source, from the class file or probably most easily using reflection on the class) but validations (minimum, maximum, maxLength etc.) would be much more difficult.  It's not a problem I've put much effort into, and I don't think I can help you.


Fix example in certificate-signing-requests.md

The example ClusterRole rule mentions 'resourceName' property, which do not exist.
It should be 'resourceNames'.

/lgtm
/approve

/approve


Multiple Options are same in the Quiz Template.

Two Options are same as depicted in the pic which is unwanted from my point of view.

Closed via #265


cursorchanged should be triggered when hovering suggestions

Like it's done when we use the keyboard to navigate suggestions.

Got the explanation https://github.com/twitter/typeahead.js/issues/580 but I'm not sure of the fix they did :/

Got the explanation twitter/typeahead.js#580 but I'm not sure of the fix they did :/

Happy to have your POV on the initial fix + my new fix @vvo :)

I think the typeahead fix was to avoid having multiple cursors BUT not to have the cursor changed event on mouseenter.
I believe they only wanted the cursorchanged event on keyboard.

But this may make sense to only have it on keyboard, in a select for instance, using your mouse is not an option selection

Well forget it, in a select, neither mouse over or keyboard usage will trigger a change event, I think your fix is legit

:+1:


Web - More than 4 Avatars are displayed on the A group chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on FAB
Create a group chat with more than 4 users.
notice that all the avatars are displayed on the created group chat page.

Expected Result:
4th avatar overlaid with the number when there are more than 4 users.
Actual Result:
all the avatars are displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/3439856b-7263-4526-b949-7830e622e077
https://github.com/Expensify/App/assets/93399543/fda0f1a6-b55f-46b5-9bb9-0bf6eace6b2f
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688796213466909
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

yes, Thank you @allroundexperts! It looks like this is expected.

@kbecciv could you please update your test cases accordingly?