local use setup guide?

I'm confused. I was under the impression we could use this with a local GPU but I didn't see a guide for setting things up locally.
What am I missing? Sorry if this is dumb, like Joe said, this is me getting lost in a jungle without a torch. Please help.

I was able to get it to work by reading through one of the notebook files, e.g., https://github.com/JoePenna/Dreambooth-Stable-Diffusion/blob/main/dreambooth_colab_joepenna.ipynb and recreating locally what it was doing. This is relatively straightforward if you're familiar with the Linux command line and a tiny bit of Python... much less so if you aren't :\
Here's an untested attempt to distil out the important bits if it helps:
cd path/to/Dreambooth-Stable-Diffusion
python3 -m venv env
source ./env/bin/activate

pip install omegaconf
pip install einops
pip install pytorch-lightning==1.6.5
pip install test-tube
pip install transformers
pip install kornia
pip install -e git+https://github.com/CompVis/taming-transformers.git@master#egg=taming-transformers
pip install -e git+https://github.com/openai/CLIP.git@main#egg=clip
pip install setuptools==59.5.0
pip install pillow==9.0.1
pip install torchmetrics==0.6.0
pip install -e .
pip install protobuf==3.20.1
pip install gdown
pip install pydrive
pip install -qq diffusers["training"]==0.3.0 transformers ftfy
pip install -qq "ipywidgets>=7,<8"
pip install huggingface_hub
pip install ipywidgets==7.7.1
pip install captionizer==1.0.1

python "main.py" \
 --base configs/stable-diffusion/v1-finetune_unfrozen.yaml \
 -t \
 --actual_resume path/to/sd-v1-4.ckpt \
 --reg_data_root path/to/regularization-images \
 -n someProjectNameJustMakeSomethingUp \
 --gpus 0, \
 --data_root path/to/training-images \
 --max_training_steps 2000 \
 --class_word yourClassWord \
 --token yourNewToken \
 --no-test

and the output checkpoints end up under logs/.

A workaround for this is running the jupyter notebook locally. Open a terminal from the Dreambooth folder, install jupyter with conda install jupyter and open a notebook server with jupyter notebook. Here you can run the whole notebook. Hope this helps

I've tried running it with a local jupyter, but couldn't solve the "Trainer not defined..." error. Any ideas?

okay, figured it out and started training....
https://github.com/JoePenna/Dreambooth-Stable-Diffusion/issues/96#issuecomment-1296292055
pip install torch==1.12.1+cu116  -f https://download.pytorch.org/whl/torch_stable.html

CUDA_VISIBLE_DEVICES=0 python "main.py" --base configs/stable-diffusion/v1-finetune_unfrozen.yaml -t --actual_resume sd-models/model.ckpt -n ChrisBWardProject --gpus 0, --data_root ./training-images/resized --max_training_steps 2000 --class_word yourClassWord --token yourNewToken --no-test

You need to set up the regularization images also;
git clone https://github.com/djbielejeski/Stable-Diffusion-Regularization-Images-person_ddim

mkdir -p regularization_images/person_ddim
mv -v Stable-Diffusion-Regularization-Images-person_ddim/person_ddim/*.* regularization_images/person_ddim

then run this badboy;
CUDA_VISIBLE_DEVICES=0 python "main.py" --base configs/stable-diffusion/v1-finetune_unfrozen.yaml -t --actual_resume sd-models/model.ckpt -n ChrisBWardProject --gpus 0, --reg_data_root ./regularization_images/person_ddim --data_root ./training-images/resized --max_training_steps 2000 --class_word person --token chrisbward --no-test

I've tried running it with a local jupyter, but couldn't solve the "Trainer not defined..." error. Any ideas?

This was my issue /w Jupyter locally, tried everything.


"Bogda" is listed in the drop-down menu

Description:
The commune is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions:
The website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Bogda".

Expected results
The location is listed in the drop-down menu as "Comuna Bogda, TIMIȘ ".


Performance drop on multiple file inputs

When running pash for grep on two files of different sizes, the performance time is sub-optimal, specifically with a parallelization width of 2.
i.e. Row 2 column 1 of the table shows speedup of pash on a 1 mb and a 64 mb sized files. Meanwhile row 3 column 1 of the table shows speedup of pash after cat-ing the two unequal-sized files into a single 65 mb file. Weirdly, this performance loss appears to diminish heavily and even disappear on higher widths of 4 and 8 respectively. (see columns 2 and 3 of the table).
Averaged over 5 repetitions
Time in seconds
Formatting: Sequential time / pash time (speedupX)

Width=2
Width=4
Width=8

One file ~64 mb
26.9076 / 14.1222 (1.90534X)
26.179 / 9.0142 (2.9042X)
26.1724 / 7.7974 (3.35655X)

Two unequal sizes ~1 mb, ~64 mb
27.2162 / 26.8302 (1.0144X)
26.526 / 9.1956  (2.88464X)
26.7292 / 7.8822  (3.3911X)

Combined one file ~65 mb
26.684 / 14.3274  (1.8624X)
26.5346 / 8.9382  (2.96867X)
26.4956 / 7.881  (3.36196X)

Two equal sizes ~64 mb each
53.8 / 27.355 (1.9667X)
53.0384 / 17.8858 (2.96539X)
53.043 / 15.3572 (3.45395X)

Command used for evaluation: 'cat fileA fileB | grep '(.).\1(.).\2(.).\3(.).\4' | wc -l'
Code used for evaluation (width=2): https://drive.google.com/file/d/1aGOYvXawq4axEAxXj9EAO0HJuHsq_6mv/view?usp=sharing
Current hypothesis: The new round-robin split assumes both/all files in the input stream are the same size and partitions workers accordingly. However, what would explain the performance loss disappearing on higher widths?

Thanks for posting that. PaSh currently does not take into account the size of input files during optimization.
Since split is not free (it needs to do a pass over the data) PaSh does not add a split after a cat it if the number of input files corresponds with the width. Therefore, with two input files and width = 2, PaSh sends the 1mb file to one parallel copy of grep and the 64mb to the other one. This can be observed if you run PaSh with -d 1 and observe the parallel script that is produced.
Regarding widths 4 and 8, PaSh will add a split after the cat since width does not correspond to the number of input files, therefore leading to balanced work on the parallel copies of the grep command.
I hope that answers the question.

I see, that makes sense. Thanks for the clarification!
Would it make sense then for pash to first check the sizes of the input files (maybe through metadata) and if they are drastically different (i.e. the ratio of the file sizes is over some threshold), cat and then split them, even if the number of input files corresponds with the width?


Add missing period.

Signed-off-by: NanXiao<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 55.12% (diff: 100%)

Merging [#1208][cc-pull] into [master][cc-base-branch] will increase coverage by 0.10%

@@             master      #1208   diff @@
==========================================
  Files            77         77
  Lines         12257      12257
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6744       6757    +13
+ Misses         4591       4581    -10
+ Partials        922        919     -3

[][cc-pull]

Powered by Codecov. Last update [b3d7a48...ec0a944][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/b3d7a486a8fa6495281e6daf8b89eaeca29bdc66...ec0a94416bf57055981c2126125a37bcd9ebc74f?src=pr
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1208?src=pr

LGTM


[Refactor] Add ErrorV2 struct

Description
There are some limitations with the existing Error type:

There are different types of Errors. Each type of error contains different information which cannot be contained in the Error struct.
Short and Long Descriptions accept only strings and so they cannot contain structured information.
For example, the Validation Error information i.e. instancePath, badValue, etc. cannot be contained in the Error struct (or not in a structured way that the clients can make use of it).

ErrorV2 Proposal:

ErrorV2 struct adds the ability to express all different types of errors.
It does so via adding a new field to the struct called AdditionalInfo which can contain structured error-specific information.
ErrorV2 is backward compatible with the Error struct.

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

How does this interplay with Meshery's use of CloudEvents?

What facility, if any, does this offer to chain a set of errors together?

We're in need of a "type" and/or "category" attribute.

Let's use CloudEvents

Reopening this since even with CloudEvents, we will have to define such a structure ourselves since CloudEvents does not define such domain-specific things.


Segmentation fail in chapter5 demo

I run the chapter 5 demo on Linux, and a segmentation fail error is occurred.
And I find the error in AppDelegate.cpp.
41     auto chapter5 = Chapter5();
42
43     // run
44     director->runWithScene(chapter5.getScene1());
45
46     return true;

chapter5 is a local variable, and will be destroyed after return.
And you refer it in lambda of Chapter5.cpp:
 51     menuItem1->setCallback([&](cocos2d::Ref *sender) {
 52
 53         Director::getInstance()->replaceScene(createScene2());
 54     });

Wow, thank you.

This has now been fixed in the v3.8 branch.


mediawiki conversion fails on first table

Hi there :)
This looks like an extremely useful tool, but after fiddling around getting the necessary ruby environment configured (never really messed with Ruby before), I still can't get it to work.
I'm trying to convert a mediawiki installation, at the output is as follows:
Creating table archive...
Unknown {:auto_increment=>false, :type=>"varbinary(255)", :length=>255, :table_name=>"archive", :decimals=>nil, :null=>false, :name=>"ar_title", :primary_key=>false}
Unknown {:auto_increment=>false, :type=>"varbinary(255)", :length=>255, :table_name=>"archive", :decimals=>nil, :null=>false, :name=>"ar_user_text", :primary_key=>false}
Unknown {:auto_increment=>false, :type=>"binary(14)", :length=>14, :table_name=>"archive", :decimals=>nil, :null=>false, :name=>"ar_timestamp", :default=>"\000\000\000\000\000\000\000\000\000\000\000\000\000\000", :primary_key=>false}
Error:
CREATE TABLE "archive" (
  "ar_namespace" integer DEFAULT 0 NOT NULL,
  "ar_title" ,
  "ar_text" bytea NOT NULL,
  "ar_comment" bytea NOT NULL,
  "ar_user" integer DEFAULT 0 NOT NULL,
  "ar_user_text" ,
  "ar_timestamp" ,
  "ar_minor_edit" smallint DEFAULT 0 NOT NULL,
  "ar_flags" bytea NOT NULL,
  "ar_rev_id" integer,
  "ar_text_id" integer,
  "ar_deleted" smallint DEFAULT 0 NOT NULL,
  "ar_len" integer,
  "ar_page_id" integer,
  "ar_parent_id" integer
)
WITHOUT OIDS;
./mysql2psql:546:in `exec': ERROR:  syntax error at or near "," (PGError)
LINE 3:   "ar_title" ,
                     ^
    from ./mysql2psql:546:in `write_table'
    from ./mysql2psql:697:in `convert'
    from ./mysql2psql:696:in `each'
    from ./mysql2psql:696:in `convert'
    from ./mysql2psql:757

As I say, it took me a while to get the right environment to make it run (installed 3 different ruby/postgres implementations, before I found the right one), so perhaps I screwed that up?
Would be grateful for any advice.  Thanks!
Edit:  the three fields that have failed are blobs, 'mediumblob' and two 'tinyblob's respectively.  is this script supposed to be able to handle blobs?
Edit again:  Please ignore the above - it's total nonsense, I'm sorry.  The fields which fail parsing are listed as types 'varbinary(255)', 'varbinary(255)' and 'binary(14)' respectively.  Looking at the script, it's clear that these are unhandled.
I created a new mediawiki installation with a postgres backend, so that I could see how these fields are stored there.  The varbinary fields are in the postgres schema as text fields, and the binary(14) are timestamps.  So it seems I'm probably gonna have to roll my own solution to this anyway.

Closing as an old issue, that would seem to be out of date.
Feel free to re-open and update with comments aganst the master branch.


First draft of OSG 23 initial release

A few items:

This doesn't include mkdocs.yml changes so that we can publish ahead of the release
We should update the HTCondor-CE section with a link to the HTCondor-CE 23 release section when that's ready
We should add feature series + HTCondor-CE doc links in the bullets at the top as they're ready
We have oidc-agent in development right now but we should just pull it.
If this is the wrong decision, we can always release it next week.

We'll also want to update the release_series.md doc to include OSG 23 here https://osg-htc.org/docs/release/release_series/#series-overviews


Update openxr-release-notes.md

Added release notes for version 1.1.2

@yl-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@vtieto : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[WIP] Add EhFrameHdr::lookup_and_parse function

Currently, EhFrameHdr::lookup returns a Pointer, which is an absolute pointer which may (or may not) point to the correct FDE. This API is used by unwind-rs to speed up stack unwinding. Unfortunately, unwind-rs requires patches to gimli (see gimli-rs/unwind-rs#6) in order to make full use of this API. This is because there is no method to parse the returned Pointer into a FrameDescriptionEntry. Unwind makes parse_cfi_entry, and uses it as such:
let fdeptr = eh_frame_hdr.table().unwrap().lookup(address, bases).unwrap();
let fdeptr = match fdeptr {
    Pointer::Direct(x) => x,
    _ => unreachable!(),
};

let entry = gimli::parse_cfi_entry(bases, *sel, &mut EndianBuf::new(unsafe { std::slice::from_raw_parts(fdeptr as *const u8, 0x1000000) }, NativeEndian)).unwrap().unwrap();
let target_fde = match entry {
    CieOrFde::Fde(fde) => Some(fde.parse(|offset| sel.cie_from_offset(bases, offset))?),
    CieOrFde::Cie(_) => unimplemented!(), // return error here probably
};
if let Some(fde) = target_fde {
    if !fde.contains(address) {
        return Err(gimli::Error::NoUnwindInfoForAddress);
    }
}

As can be seen here, there is a big fat unsafe in the middle, which sucks. I believe there is a better solution.
The complicated part is that the fdeptr is absolute, and has no length associated to it. It is, however, guaranteed to always point to an eh_frame section. Furthermore, the eh_frame_hdr has a pointer to the start of this section. As such, I propose this solution, which allows us to get rid of the unsafety.
I additionally took the liberty of adding the guarantee that the returned FramePointer will be valid (there is no need to check contains()).
I am in the process of testing this, and the implementation and doc might need a bit of refinement.
CC @main--

Coverage decreased (-0.2%) to 84.733% when pulling a33221b7fc732e05739c6691c31a896f800622bf on roblabla:lookup_and_parse into ed9659833ebe1bca37cc14bece171a3f27380aab on gimli-rs:master.

I'll add an example in the doc, and I think this is ready to merge.

I added a test and an example (and hopefully fixed compilation, woops). If it compiles and the tests pass, this should be ready to go.

All ready.


fix to the new assisted-installer UI repo name

UI team expects a change in their repositories, moving to one monorepo that should contain all UI components related to assisted-installer: core logic (openshift-assisted/assisted-ui-lib), dev/podman (openshift-assisted/assisted-ui), BILLI, etc.
This mirror the changes to the new repo name.

/hold
waiting for UI to complete the change in their part (I'll link the PR when it's presented)

LGTM

/test snapshot-repos-dry-run

/retest

/retest

/retest

/retest

/lgtm

/unhold


Added tests for exponent functions

Codecov Report

Merging #17 into master will increase coverage by 0.68%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #17      +/-   ##
=========================================
+ Coverage   90.42%   91.1%   +0.68%
=========================================
  Files         194     194
  Lines        3968    4003      +35
=========================================
+ Hits         3588    3647      +59
+ Misses        380     356      -24

Impacted Files
Coverage Δ

Tests/NiftyTests/exp2_test.swift
100% <100%> (ø)
:white_check_mark:

Tests/NiftyTests/expm1_test.swift
100% <100%> (ø)
:white_check_mark:

Sources/exp2.swift
100% <ø> (+100%)
:white_check_mark:

Sources/expm1.swift
100% <ø> (+100%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2d6bb...227e276. Read the comment docs.


[Bug] missing mtbench dataset

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

Type
I'm evaluating with the officially supported tasks/models/datasets.
Environment
OpenCompassData-complete-20240207.zip
Reproduces the problem - code/configuration sample
the "OpenCompassData-complete-20240207.zip" missing the mtbench dataset, which mentioned in this changelog: https://github.com/open-compass/opencompass/releases/tag/0.2.2.rc1.
Reproduces the problem - command or script
none
Reproduces the problem - error message
none
Other information
none

Can you show me your config? By the way, which model are you running, huggingface model or API-based model?

Hello, I am using configs/eval_subjective_mtbench.py and I noticed that the subject_datasets variable data_path is configured as data/subjective/mtbench. However, I did not find the corresponding dataset file in this directory. BTW, I have downloaded the complete dataset package OpenCompassData-complete-20240207.zip.

Hello, I am using configs/eval_subjective_mtbench.py and I noticed that the subject_datasets variable data_path is configured as data/subjective/mtbench. However, I did not find the corresponding dataset file in this directory. BTW, I have downloaded the complete dataset package OpenCompassData-complete-20240207.zip.

Well, this is because we reorganized the datapath and have not release the new files yet. Thanks for your reminder, we will add it later, and you can also put these file in your path.
mtbench.zip
By the way, there are four files in this zip, the mtbench.json is the whole json data, and the others are the part of the data, which split by the different temperature settings in MTBench.

Thanks a lot！


Hypothesis for objectives

Adds the hypothesis strategies for our objective classes.

Hi @AVHopp @Scienfitz. This is a short PR on top of the open #188 PR to add the strategies. Please wait with the review until the other one is merged.

@AVHopp, @Scienfitz: Ok, now this one is also ready for review


Fixes Issue 1093

Pull request acceptance prerequisites:

[x] Signed the CLA (if not already signed)
[x] Rebased/up-to-date with base branch
[x] Tests pass
[x] Updated CHANGELOG.md with patch notes (if necessary)
[x] Updated CONTRIBUTORS (if attribution is requested)

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Also begins to address EOL/EOS issues identified in https://github.com/elastic/puppet-elasticsearch/issues/1098

TravisCI failures seem due to a problem with upstream package dependency 'analysis-icu' -
Warning: /Stage[main]/Main/Elasticsearch::Plugin[analysis-icu]/File[/usr/share/elasticsearch/plugins/analysis-icu]: Skipping because of failed dependencies


feat(i18n): allow plugins to add translations

Hey, I just made a Pull Request!
NOTE: Maybe not mergeable as is, just proof of concept.
this allows plugins to add their own translations in the plugin creation. app developer translation resources override the ones coming from plugin. also this requires the application devleoper to define the available languages (which could come automatically too from plugins).
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Just a note that I think that in the new system this is pretty much already done, unsure if we're going to want to backport this though yet - perhaps. Will bring this up when @rugvip is back next week too.


bug fix: attach through websocket integration test

fix issue: #701
Signed-off-by: Xian Chaobo<EMAIL_ADDRESS>

ping @aluzzardi

LGTM
Will merge as soon as jenkins passes


TCP: Missing connection

When clients connect and disconnect in some unknown pattern:

Largely fixed by https://github.com/hioa-cs/IncludeOS/pull/1433/commits/ef780a1620b3715d7290a56b862eb06f66538328

And finally brought down with https://github.com/hioa-cs/IncludeOS/pull/1434


DATA-2630 - Add time to MLTrainingVersion

@Simberific this is technically a breaking change for the submit custom training job API, though it has not currently yet been released. The change can be summarized as: the registry versions associated with training scripts will now have more metadata returned (the time created). Would you mind merging when you get a chance?


Changed the UX of the message background from white to gray

can easily distinguish between different messages and also gives a better user view distinguishes the message content from background . it's still incomplete though some more tweaks I am planing to add.

hi @RajPratim21 - you've tried to merge your personal develop branch onto vector's master branch (you should be targeting vector's develop branch), and you also don't seem to have pushed any commits to your personal develop branch.
In terms of a custom theme: please feel free to customise as desired, but we're not going to accept any PRs to the main application for changes to the UI based on subjective personal taste.  In future we may support customisable skins in the app, in which case alternative skin proposals would be much appreciated.


Update RBAC rules

How to categorize this PR?

/area open-source
/kind bug
What this PR does / why we need it:
After revendoring Gardener, Leases are used for leader election.
Release note:

NONE

/invite @deitch

Depends on #150

This PR is ready now that #150 got merged.
/invite @deitch


Add JDBC ResultSet writer. Closes #6

Add a writer to write a JDBC ResultSet as CSV.
CsvResultSetWriter writes a CSV file by mapping each column of the
ResultSet to a column in CSV file using column names stored in
ResultSetMetaData. It can be used with or without CellProcessors.
Closes issue #6.

Great stuff. I'm swamped at work at the moment will need to look into this later than I want to.

Hi Kasper! Thanks for feedback!

how about filling the array with null's instead

Agreed.

why do you need so many rows, what important data differ in each of them?
could/should the test data be extracted into a separate class and reused in other tests?

This is the same test data that is used in CsvBeanWriterTest & CsvBeanReaderTest. There are CustomerBean objects in org.supercsv.SuperCsvTestUtils which are constructed with the same values that I have in my arrays.
Perhaps it is better to:

move these arrays to SuperCsvTestUtils
create CustomerBeans from array elements

In fact I don’t think that we need that much rows, but keeping it that way allows to reuse the CSV output contained in SuperCsvTestUtils.CSV_FILE.

Hi @singularityfx  I was of the impression you wanted to work further with this? Or do you believe you are done?

@kbilsted Yes, I want to work further with this, just let's agree on what shall be done:

pass array of nulls? Or get rid of dummyProcessors at all?
refactor the tests as described in my message above?
anything else?

Hi thanks for getting back.
Try out James idea or if failing use nulls. The other refactoring of the tests sounds good.

@kbilsted @jamesbassett Done

Great stuff @singularityfx  ! Thanks!  @jamesbassett  did you have anything to add?

Yep, I'm at work right now, but here's some feedback (sorry for taking so long) :)

Revert the changes to SuperCsvTestUtils, and instead set up the test data in your CsvResultSetWriterTest. Instead of duplicating the data, create a utility method that takes the List of CustomerBeans from SuperCsvTestUtils (i.e. SuperCsvTestUtils.CUSTOMERS) and creates your result set test data (array of arrays) from it.

Documentation (you can test this with mvn site:run):

Add the new writer to super-csv/src/site/apt/writers.apt
Add a writeWithResultSetWriter() method to super-csv/super-csv/src/test/java/org/supercsv/example/Writing.java
Create a new super-csv/src/site/apt/examples_jdbc.apt page with an example of how to use it (use the code/output from the previous step, as is done for all the other readers/writers).
Add your page to the site index (super-csv/src/site/site.xml) after the dozer example

Coding standards:

add final modifier to all method params and variables
remove public modifier from all interface methods (it's implicit)
change copyright to Kasper

@jamesbassett Thanks for feedback! Regarding the first point. I was considering this option, but it would made the test less isolated by introducing dependency on CustomerBean class. Are you sure you want this? Also having the test data in arrays inside SuperCsvTestUtils will make it easier to reuse the data in future. Please let me know what do you think.

Yeah ok.  How about adding the following to SuperCsvTestUtils:
public static final ResultSet CUSTOMER_RESULT_SET =
createCustomerResultSet();
public static final ResultSet STRING_CUSTOMER_RESULT_SET =
createStringCustomerResultSet();
private static ResultSet createCustomerResultSet(){
// TODO create ResultSet from CUSTOMERS
}
private static ResultSet createStringCustomerResultSet(){
// TODO create ResultSet from STRING_CUSTOMERS
}
On Fri, Jun 19, 2015 at 8:14 PM singularityfx<EMAIL_ADDRESS>wrote:

@jamesbassett https://github.com/jamesbassett Thanks for feedback!
Regarding the first point. I was considering this option, but it would made
the test less isolated by introducing dependency on CustomerBean class.
Are you sure you want this? Also having the test data in arrays inside
SuperCsvTestUtils will make it easier to reuse the data in future. Please
let me know what do you think.
—
Reply to this email directly or view it on GitHub
https://github.com/super-csv/super-csv/pull/51#issuecomment-113460495.

Yeah ok. How about adding the following to SuperCsvTestUtils

I didn't want to extract the data from CustomerBeans because then my test will depend on CustomerBean class - if someone make changes to CustomerBean, then my test may break, while it has nothing to do with CustomerBeans. But if you insist I can do that, no problem. Just for my understanding - what is the benefit of this approach?

I wasn't keen on having the test data array and all the casts and array indices it required.  I get where you're coming from regarding keeping things isolated, but in this case I think the CustomerBeans are the best place for the test data to be defined (you get type safe constructor params, and the data is visible beside the CustomerBean definition).
The fact that the result set test data is created in the very same class makes it easier to maintain, and should be obvious that any changes to the CustomerBeans will impact that as well (and will cause tests to fail).
So I'd prefer it to be done as suggested, though I'd make the new constants be Object[][] as you had initially - my comment about making them ResultSets was a bit silly now that I think about it (they probably have state!).

@jamesbassett OK, I undestand your point now. I'll do as you suggested.

@kbilsted @jamesbassett OK, done

Many thanks for your persistence!

Sorry I still haven't looked at it. Maternity leave is starting monday! Should provide me with time :-)

Great! Hope it will be useful.
Do I qualify for being included to the list of contributors?  (http://super-csv.github.io/super-csv/team-list.html) It would give me a warm and fuzzy feeling :)

I have a hård time seeing why not. Have you seen my invite for the github supercsv team?

Make it a pull request..being added to the list:)

Hmm, it looks like there is no source for http://super-csv.github.io/super-csv/team-list.html in the repo

Look at the branch gh-pages

It's generated with mvn:site (you just need to edit the pom.xml file and it will appear the next time we release).

Thanks for explanations!


MINIFICPP-1296 - All tests should use volatile state storage

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

the ListSFTPTests failed on ubuntu-16.04-all on all runs I saw, (here in the PR, and on your own fork run), could we re-run it again (preferably on both places) to verify if the failures are only transient?

ListSFTPTests is still failing after another rerun, so this needs some attention.

35999e0 (on main) broke the build


Please update docs: do overrides override everything?

It's unclear from the docs, and I'm too lazy to check myself.
In this example:
<Parent>
    <Helmet>
        <title>My Title</title>
        <meta name="description" content="Helmet application" />
    </Helmet>

    <Child>
        <Helmet>
            <title>Nested Title</title>
        </Helmet>
    </Child>
</Parent>

Does my page still have a meta description, or did it get deleted? i.e, is the output
<head>
    <title>Nested Title</title>
    <meta name="description" content="Helmet application">
</head>

or
<head>
    <title>Nested Title</title>
</head>

Your first assessment is correct 🎉

I mean, thank you, I'm happy to know, but shouldn't the docs actually be updated? I can't imagine I'm the only one who found that confusing

@Faithfinder I would like to make it clearer if possible, but I dont understand how. Perhaps you have some suggestions?

Changing the examples like in my question should illustrate the concept. (there's what, 1 line difference?).
Also a phrase along the lines of "Helmet leaves the tags not specified in it alone: if you use it to set a "meta-description" down the component tree it will leave the title intact".
Though it does leave me with the question "What if I want to delete a tag?". Don't have a usecase, just thinking about the options.


Long file break the output

I placed my js file (below) into the codehawk-cli-example util folder.
After run npm run codehawk got this result:
><EMAIL_ADDRESS>codehawk
> codehawk src

[codehawk-cli] Unable to parse "/Users/dominikjelinek/my/Development/sandbox/codehawk-cli-example/src/util/other-examples/cannot-be-parsed-correctly.ts", skipping
[codehawk-cli] Worst case (49.92448230648628) was below the minimum threshold (50)

When I removed one random empty line, got this:
><EMAIL_ADDRESS>codehawk
> codehawk src

[codehawk-cli] Unable to parse "/Users/dominikjelinek/my/Development/sandbox/codehawk-cli-example/src/util/other-examples/cannot-be-parsed-correctly.ts", skipping

    Codehawk Static Analysis Results
    Top 6 files

    | File                                               | # of Lines | Times Used/Depended On | Maintainability (higher is better) |
    | -------------------------------------------------- | ---------- | ---------------------- | ---------------------------------- |
    | /src/util/UtilsService.js                          | 108        | 1                      | 50.01 (Could be better)            |
    | /src/util/complex-utils.js                         | 99         | 1                      | 50.76 (Could be better)            |
    | .../util/other-examples/can-be-parsed-correctly.ts | 58         | 1                      | 56.77 (Could be better)            |
    | /src/typescript-supported-too/typescript-sample.ts | 11         | 1                      | 70.73 OK                           |
    | /src/pages/index.js                                | 209        | 1                      | 89.94 OK                           |
    | /src/pages/api/hello.js                            | 6          | 1                      | 91.93 OK                           |

[codehawk-cli] Generating maintainability badge...
[codehawk-cli] Badge was generated

There is also parsing issue.
The file:
class UtilsService {
	/**
	 * It will remove keys with 'undefined' or 'null' value.
	 *
	 * @param {*} o
	 * @returns {*}
	 */
	static clearObjectFromUndefined(o) {
		const nextObject = { ...o };
		const metaKeys = Object.keys(nextObject);
		for (let i = 0; i < metaKeys.length; i += 1) {
			const mk = metaKeys[i];
			if (nextObject[mk] === undefined || nextObject[mk] === null) {
				delete nextObject[mk];
			}
		}
		return nextObject;
	}

	/**
	 * The main idea of this utility is to (unified) transfer boolean values of the object into specific typed value.
	 * For an example after call `fixBoleanedToType(false, undefined, { a: "", c: 0 })` the returned result will be
	 * 	{
	 * 		a: undefined,
	 * 		c: undefined,
	 * 	}
	 * The function doesn't not create new object, but altering the passed reference.
	 * @param {Boolean} booleanValue
	 * @param {*} wantedValueInstead
	 * @param {{}} objectToFix
	 * @returns {{}}
	 */
	static fixBoleanedToType(booleanValue, wantedValueInstead, objectToFix = {}) {
		if (booleanValue !== Boolean(wantedValueInstead)) {
			throw new Error("Wanted value must be same after transfer into Boolean type as the passed boolean type.");
		}
		const objectKeys = Object.keys(objectToFix);
		for (let i = 0; i < objectKeys.length; i += 1) {
			if (Boolean(objectToFix[objectKeys[i]]) === booleanValue) {
				// eslint-disable-next-line no-param-reassign
				objectToFix[objectKeys[i]] = wantedValueInstead;
			}
		}
		return objectToFix;
	}

	/**
	 * @param {{}} dirty
	 * @param {string[]} correctKeys
	 * @param {boolean} filter
	 * @returns {{}}
	 */
	static fixCaseSensitiveKeys(dirty, correctKeys, filter = true) {
		const dirtyKeys = keys(dirty);
		const cleaned = filter ? {} : { ...dirty };
		for (let i = 0; i < dirtyKeys.length; i += 1) {
			const dirtyKey = dirtyKeys[i];
			const cleanKey = correctKeys.find(x => x.toLowerCase() === dirtyKey.toLowerCase());
			if (cleanKey === undefined) {
				// eslint-disable-next-line no-continue
				continue;
			}
			cleaned[cleanKey] = dirty[dirtyKey];
			if (cleanKey !== dirtyKey) {
				delete cleaned[dirtyKey];
			}
		}

		return cleaned;
	}
	/**
	 * @template T
	 * @param {T[]} arr1
	 * @param {T[]} arr2
	 * @param {(function(T, T): boolean)} compare
	 * @returns {number}
	 */
	static countOfIntersectedElements(arr1 = [], arr2 = [], compare = (a, b) => a === b) {
		let count = 0;
		const arr1reduced = [...arr1];
		const arr2reduced = [...arr2];
		for (let i = 0; i < arr1reduced.length; i += 1) {
			for (let j = 0; j < arr2reduced.length; j += 1) {
				if (compare(arr1reduced[i], arr2reduced[j])) {
					count += 1;
					arr1reduced.splice(i, 1);
					arr2reduced.splice(j, 1);
					i -= 1;
					j -= 1;
					break;
				}
			}
		}

		return count;
	}
	/**
	 *
	 * @param {*[]} arr1
	 * @param {*[]} arr2
	 * @returns {*[]}
	 */
	static arrayZip(arr1, arr2) {
		const arr1expansion = arr1.length >= arr2.length ? [] : Array(arr2.length - arr1.length).fill(undefined);
		return [...arr1, ...arr1expansion].map((e, i) => [e, arr2[i]]).flat();
	}
}

export default UtilsService;

Hi @domino2 do you still have this issue?
I just reproduced it and saw that your file (when pasted from the above into the example, as per your description) produces a score of 49.01 with<EMAIL_ADDRESS>This results in the threshold being breached, hence the error.
Also, note that the parsing error of cannot-be-parsed-correctly.ts is intentional. It simply demonstrates that codehawk will warn you when it's trying to parse files that it is unable to. There may be cases where codehawk should be parsing code but is failing, in which case, please open an issue!
Finally, please also note that I am releasing codehawk-cli v10 today and will also update the example. A bug has been fixed and it could result in material differences to scores for real projects [but I do not expect it to change your example].

ok ... thanks. I'll dive into it deeper near future


Add have_indexed_field matcher

Add have_indexed_field matcher functionality. Documentation on the readme.
I did not touch the version.
This depends on a modification to sunspot (which I don't like, but I'm not sure of a better way). The prepare method on the Indexer needs to be moved out of private. This way the SessionSpy can also make use of it without duplicating code.

I'm going to have to abandon this because the dependent request was never merged into sunspot and so this was never merged. There are now merge conflicts and I tried to quickly resolve them, but failed and I don't currently have time to dig deep as to why.


🐞 - OnChange not triggered with numeric values if digits count to small

Which package(s) are the source of the bug?
@maskito/core, @maskito/kit
Playground Link
https://um2sal.stackblitz.io/
Description
I need to enter at least 4 digits + decimal seperator in order to have the onchange function triggered.
If you enter for example
",1"
",12"
"0,12"
"1,22"
The onchange function is not triggered
Only if I enter
"12,34"
"12," => which gets transformed into "12,00"
"01,00"
"01," => which gets transformed into "1,00"
the on change function is triggered. Also deleting every digit will trigger the onchange.
Maskito version
latest
Which browsers have you used?

[X] Chrome
[X] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Native onChange (not react's synthetic!) event is triggered only when

When the element loses focus after its value was changed
(c) MDN

Use native onInput instead!
Learn more about all textfield's events in my article:
https://medium.com/javascript-in-plain-english/uphill-battle-to-create-a-mask-for-text-field-f1e385455dd5

Native onChange (not react's synthetic!) event is triggered only when

When the element loses focus after its value was changed
(c) MDN

Use native onInput instead!

Sorry, I was unclear. onchange should indeed be triggered after input changes + the element looses focus.
And that doesnt happen if not at least 4 digits

to be more clear. Use the stackblitz above. enter "1,23" and tab out of the input.
This should imo trigger onchange but it doesnt. If however I type "01,23" and then tab out of the input the event is fired

Hi @robkuz. Seems like native change event is not dispatched if we prevent default behavior of beforeinput event, which we have to do to properly process the entered value in some cases. To be honest, I haven't seen change event used for years, ever since input event became available in all browsers over a decade ago. This could be augmented by a custom Maskito plugin that would dispatch synthetic change event upon blur if since focus there were only synthetic input events (isTrusted: false). I'm not really sure it is necessary for common use, though. Could you share with us why do you need change event as opposed to input?

Hi @waterplea,
actualle the input event is much to finegranular for my needs.
Which is check upon loosing focus (blur) if the value of the control has changed.
In my particular case I will call a server method if and only if the value has changed and there is no chance of further editing because the control has lost focus.
and that is exactly what the onchange event delivers. I have been using this since the dawn of time.
Apart from that - the behaviour I am describing above is a bug and would at least be a candidate for a fat disclaimer in the docs. Something like "Due to ... (technical description) ... the delivery of the onchange event can not bee guaranteed when using moskito"

Ok, thanks for clarifying. change event is fired right before blur. We can easily add a post-blur synthetic change if the value has changed and change event did not fire. Still, I think it should be a plugin, rather than built-in behavior because I think most people would not need it. We definitely should add a disclaimer with the name of plugin, something like:
Native `beforeinput` event default behavior is cancelled to process user entered value.
This causes native `change` event to NOT be dispatched by browser.
A `change` event, as opposed to `input`, is triggered only when user left the field and value was changed during interaction.
If you rely on this behavior, add `maskitoChangeEventPlugin` to your mask configuration.
It will dispatch synthetic `change` event using the same logic.

Hi @waterplea,
first of all - thanks for your swift replies. Thats awesome.
However I'd like to point out the following - as per my description above the onchange event does get fired. Its only that it doesnt happen always.
Entering:
"12,34" fires the event
"1,23" doesnt fire the event
"01,23" does fire it
I am pointing that out as your description indicates that the event is NEVER dispathced by the browser.
And there might be a chance that the plugin then leads to situations where the event is fired twice.
Sorry for being a pita on this

No worries, not pita at all. The event is only cancelled if we cancel beforeinput which we do if it will lead to an invalid value, so that we can conform it to mask and never have wrong content inside the input. We will take care of that and only dispatch the event if native event did not happen. Just in case you might need to write your own plugins in future, you can check out the PR attached to this issue, it's pretty straightforward:
export function maskitoChangeEventPlugin(): MaskitoPlugin {
    return element => {
        if (element.isContentEditable) {
            return;
        }

        let value = element.value;

        const valueListener = (): void => {
            value = element.value;
        };
        const blurListener = (): void => {
            if (element.value !== value) {
                element.dispatchEvent(new Event('change', {bubbles: true}));
            }
        };

        element.addEventListener('focus', valueListener);
        element.addEventListener('change', valueListener);
        element.addEventListener('blur', blurListener);

        return () => {
            element.removeEventListener('focus', valueListener);
            element.removeEventListener('change', valueListener);
            element.removeEventListener('blur', blurListener);
        };
    };
}

Basically it's a function that gets the native element and returns cleanup logic or nothing.


Motion form: error for not existing tags

If a motion is modified in quickmode and a not existing tag is given, then a funny error messages appears.

@emanuelschuetze
I think this one can be closed, as tag assignment/editing is very different now.
(aka : cannot reproduce anymore)


Attempt to index a nil value (global 'ExecApartement1')

Hey when i try to change the style of my penthouse i have this error Attempt to index a nil value (global 'ExecApartement1')

      Citizen.CreateThread(function()
              ExecApartment1 = exports['bob74_ipl']:GetExecApartment1Object()
              print(ExecApartement1) -- return nil
              ExecApartment1.Style.Set(ExecApartement1.Style.Theme.vibrant, true)
          end)

Hi, can you check if your resource manifest has the dependency:
dependency 'bob74_ipl'
Also, ensure bob74_ipl before your custom resource in the server config file.
Do you have the same issue with other interiors?

Yes in the fxmanifest i have bob74_ipl in dependency, and i ensure bob74_ipl before my script and no i don't have this issue with other interiors

You made a typo: apartement -> apartment
Citizen.CreateThread(function()
	ExecApartment1 = exports['bob74_ipl']:GetExecApartment1Object()
	print(ExecApartment1)
	ExecApartment1.Style.Set(ExecApartment1.Style.Theme.vibrant, true)
end)

Oh yeah right sorry ..


Rewrite tests to 'describe'/'it' syntax

I think I want to standardise it - and rewriting these tests would be useful for consolidating what I know/learned about the project.

In Employee, want to break the tests down into properties, and then methods.

Added additional tests to check inheritance on subclasses -

[ ] Test a property that should be inherited
[ ] Test a method that should be inherited
[ ] Test that subclass is an instance of the Employee constructor

These tests are now on the Intern, Manager and Engineer classes.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/235 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit 32c2fa8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Style1 to patternfly conversion in Providers

Parent issue: #3139

Before:

After:

Before:

After:

@PanSpagetka Try removing the style1 divs. There is no such thing. Also, please remember to mention me in these PRs.

@epwinchell Should be ok now, I will try not to forget to mention you.

@PanSpagetka please update your PR as is described in #4197

Updated, @epwinchell @skateman please review

LGTM


KOGITO-8404: Dashbuilder VSCode extension: Auto Complete

adding autocomplete support to vscode extension of dashbuilder
JIRA: https://issues.redhat.com/browse/KOGITO-8404

need to wait for this minor fix: https://github.com/jesuino/dashbuilder-website/pull/10 .. before we can start testing :)

Hello Ajay,
Thank you so much for this PR! Your work is looking great and I really appreciate your hard work on it!
I can see auto complete working very well, just a few thoughts:

I see that some minor problems are displayer as errors - would it be possible to set as WARNINGS instead? Here's for example, this works as String or number, so not an issue if this is a String

In properties it says that the property should be String, which is not true - it can be any primitive type:

This also could be a warning because lower or upper case would work

In settings, lookup is indeed obligatory, but it may be defined globally, inside global, so it would be great to have it as a warning as well instead error

In the case showed on the image below baseUrl is not required and width/height for external are not numbers:

groupFunctions also work as "functions" - I would prefer to validate to functions because it is what we are going to use

In this case I don't know why it complains about the fields under "echarts" - this is a free object where users can add any property to the component - so we should not have validation under the component configuration

the fields html and javascript under displayer/html are indeed String - I am not sure why it complained:

That's all for now.
Thanks!

Hello @AjayJagan ,
Thanks for your changes, it is working great now!
I will approve this PR and suggest some changes to the schema:

For axis -> x or axis -> y any of the properties are required:

I know that you did this because the auto complete when adding the property is really great

For sort we made a change to sortOrder to "order"

On settings.chart.zoom it is actually a boolean or string

On settings.columns only ID is required

For settings.filter only enabled is required

With lookup uuid is indeed is required - but sometimes we define it globally in global.settings - but I don't know if this is possible to solve on the schema - if does it is not possible to solve don't worry

Finally I still see message as ERRORS, but it would be good it it was as WARNING - if it is not possible just let me know

We can approve and merge this PR and do these improvements to the schema in parallel
Thanks!

The (build) kie-tools-stunner-editors check has failed. Please check the logs.


MultiThreaded support

Note: In order to work correctly in a threaded environment, the python suds package must be patched with https://fedorahosted.org/suds/attachment/ticket/435/suds-binding-race-condition.patch
If the client is share between several threads, then the client must be clone.

Example:
import psphere
from psphere.client import Client
from psphere.managedobjects import HostSystem, VirtualMachine, ComputeResource
client = Client("<IP_ADDRESS>", "root", "vmware1") ##vCenter
print "\nSucessfully connected to vCenter.\n"

from threading import Thread

def myfunc(c, i):
    client = c.clone()
    host1 = HostSystem.get(client, name="<IP_ADDRESS>")
    host2 = HostSystem.get(client, name="<IP_ADDRESS>")
    print "----i------",i
    while True:
        #host1.update(properties=["config", "vm"])
        #host2.update(properties=["config", "vm"])
        c = type(host1.config.network)
        v = type(host2.config.network)
        for vm in host1.vm:
            k = vm.config.template
        for vm in host2.vm:
            p = vm.config.template

for i in range(10):
    t = Thread(target=myfunc, args=(client, i,))
    t.start()

this PR should be made to https://bitbucket.org/jurko/suds


Steam density calculations change significantly with new release

Steam density calculations have changed in some cases by more than 7% between versions 1.1.1 and 1.1.4. Interestingly, version 1.1.1 matches the steam densities reported in coolprop. Is this behavior to be expected?
Attached is an excel table showing density calculations at 5 different pressures and 3 different temperatures between the two versions of chemical and coolprop.
I am very impressed with this package (and thermo and fluids). Thank you, Caleb, for all of your hard work.
steamDensityCalculationsChemical.xlsx

Hi Caleb,
Thank you for your quick and thorough response. We are in the process of learning the thermo.Flash object and will try to make this our new standard (instead of thermo.Mixture). Thank you for making these great tools available.
BR,
Nick


"context deadline exceeded" errors relating to events seen repeatedly in api-server logs.

acorn version - v0.8.0-alpha7-131-g4bf05b4d+4bf05b4d
I see a lot of these errors in api-server logs. I am not aware of any specific steps that leads to seeing these errors messages.
time="2023-07-20T19:12:32Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:16:11Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:19:38Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:21:36Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:29:28Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:53:03Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:54:08Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T19:59:18Z" level=warning msg="error forwarding events: [context deadline exceeded]"
time="2023-07-20T20:01:37Z" level=warning msg="error forwarding events: [context deadline exceeded]"

@njhale is going to revisit eventually

see https://github.com/acorn-io/runtime/pull/1957#issuecomment-1697787854


Update base images to CentOS 8 Stream

PR #223 updated base images to CentOS 8 which is EOL now so we can't
build new images using it.
Closes: #238

lgtm
@zshi-redhat @Eoghan1232 PTAL this addresses #239

I think moving from centos8 to centos8-stream has the smallest delta then other alternatives (e.g rocky, centos9-stream, ubuntu base images)


New /sent_deps/ endpoint, fix unit tests, add some optional tokenizer config

Adds a new endpoint which combines functionality of two existing; splits into sentences and then tokenizes into dependencies. Adds documentation for this as well.
Fixes the existing unit tests, adds documentation on how to run them.
Adds a way to optionally configure some basic tokenization special cases with an environment variable. For example, keeping contractions intact

Looks amazing! I’ll give it a try tomorrow

Sounds good @jgontrum, let me know if you'd like any extra context on anything, or if anything doesn't make sense or should be different.

Looks good so far! One thing I've noticed is that the server returns a 500 if the model in the request is not found. Could you please catch it and return a more informative message as we do with the /dep endpoint?:
{
  "title": "Dependency parsing failed",
  "description": "[E050] Can't find model 'some_unknown_model'. It doesn't seem to be a shortcut link, a Python package or a valid path to a data directory."
}

Looks good so far! One thing I've noticed is that the server returns a 500 if the model in the request is not found. Could you please catch it and return a more informative message as we do with the /dep endpoint?:

Good catch, yes I can definitely make that change. I notice that a couple of the other endpoints are missing that error handling as well; while I'm in here would you like me to add that to /sents and /ents?
Additionally, /models and /version are just returning a 500; if you'd like I can expand that to something a bit more informative, such as:
except Exception as e:
    raise falcon.HTTPInternalServerError(
        'Error occurred retrieving models',
        '{}'.format(e))

@jgontrum check out 4c64c74 for code addressing your feedback.
I added the handling to the new /sents_dep endpoint as you requested, and also added similar handling to /ent and /sents, which were also missing that. I also wrote a parametrized unit test case to cover that behavior for all those endpoints.
I also went ahead and added better 500 handling to /version and /models so a message about what went wrong will be returned.

Looks good to me :) Thank you for work!


fix(economy): missing max_count property declaration

Property as marked as required but it wasn't defined.

Thanks @jpntex


Star macro does not work with a relation reference

I would like to use star macro for my base models which reference a source table. When I pass a relation object as a from argument to star macro, I am getting an error
 dbt run -m test
Running with dbt=0.14.0
Encountered an error:
Compilation Error in model test (models/example/test.sql)
  Macro star expected a Relation but received the value: None

  > in macro _is_relation (macros/cross_db_utils/_is_relation.sql)
  > called by macro star (macros/sql/star.sql)
  > called by model test (models/example/test.sql)

steps to reproduce:
dbt init test
cd test

create models/example/schema.yml file:
version: 2

sources:
  - name: my_schema
    tables:
      - name: test

create models/example/test.sql file:
SELECT
    {%- set rel = adapter.get_relation(
      database=target.database,
      schema='my_schema',
      identifier="test") -%}

    {{ dbt_utils.star(from=rel) }}
FROM {{ source('my_schema', 'test') }}

Create packages.yml file:
packages:
  - package: fishtown-analytics/dbt_utils
    version: '0.2.1'

in Redshift create a source table:
create schema my_schema;
create table my_schema.test as select 1 as id;

run dbt:
dbt deps
dbt run -m test

Hey @botchniaque - the adapter.get_relation() method will try to find the specified relation in the database, returning it if it exists. If the relation does not exist in the database, then adapter.get_relation() will return None.
You have two options here:

figure out why get_relation doesn't find your relation. This might be an issue with quoting, depending on your database
use api.Relation.create() instead of adapter.get_relation(). The api.Relation.create method will generate a new Relation object that you can pass to the star macro. My guess is that you'll still encounter an error around a missing / incorrectly quoted identifier, but it will probably be more helpful than the one you're seeing here.

Just curious: which database are you using?

I am using Redshift - my relation does not contain any special characters, so I'd be very surprised if there was some quoting problem.
I'll check your suggestion - thanks

Sorry for the late reply - indeed using api.Relation.create() helps - now I can do star on my sources! thanks
SELECT
    {%- set rel = api.Relation.create(
      database=target.database,
      schema='my_schema',
      identifier="test") -%}

    {{ dbt_utils.star(from=rel) }}
FROM {{ source('my_schema', 'test') }}

Thanks for the update!


Updated README: updated CARE logo

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

LGTM


Upgrade and improve Visual Studio solution/project generation code

This change improves the Visual Studio solution and project generation code in the following ways:

Adds support for Visual Studio 2019 and 2017 project files. In this part, I went a different direction than the existing VS2015 code by doing all of this in the V10 class. I have found this to be the easiest way to continue to add support for new versions of Visual Studio; for example, VS2019 support was a 4-line change after the initial changes.
Adds support for consumers to specify C++ include paths and C++ preprocessor definitions to be included in the .vcxproj file. This helps Intellisense function better. (Tests included for this part as well, including one to cover an issue pickling Dir() objects when writing miscellaneous CPPPATH info to the .vcxproj file)
Adds  to the project file so we are not prompted to upgrade. This helps the case where a developer has a new version of Visual Studio installed and generates projects for that, while the underlying SCons build uses an older toolset.
Excludes .filters files from dspfile processing.
Adds a test to cover VS2015 support.

Contributor Checklist:

[x] I have created a new test or updated the unit tests to cover the new/changed functionality.
[ ] I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
[ ] I have updated the appropriate documentation

Our CI style checker is objecting to your use of lambdas in two locations:
[E731] do not assign a lambda expression, use a def

        cppdefines = GetKeyFromEnv(env, 'cppdefines', variants)
        dirpathfunc = lambda x: x.abspath if hasattr(x, 'abspath') else x
        cpppaths = [dirpathfunc(path) for path in GetKeyFromEnv(env, 'cpppaths', variants)]

Our CI style checker is objecting to your use of lambdas in two locations:
[E731] do not assign a lambda expression, use a def

        cppdefines = GetKeyFromEnv(env, 'cppdefines', variants)
        dirpathfunc = lambda x: x.abspath if hasattr(x, 'abspath') else x
        cpppaths = [dirpathfunc(path) for path in GetKeyFromEnv(env, 'cpppaths', variants)]

Thanks, yeah I saw that and am working on a fix.

Some other MSVS-related tests failed in Travis. Am looking now.


forEachFeatureAtPixel doesn't work correctly for Point geometry

A feature is not found, when I click far enough from centre of the Point geometry (close enough to its border, but still inside of it). I have created an example here - https://jsfiddle.net/mstrop/4gvLhfje/7/.
When you start clicking on border and you will continue towards the centre of the circle you will see, that the circle is found quite far from the border. Tested on IE, FF and Chrome.

The property renderBuffer (see ol.layer.Vector) is taken into account for the hit detection. By default it is set to 100 pixels. If you have larger symbols, you will have to adjust it accordingly, e.g.:
var vectorLayer = new ol.layer.Vector({
  source: vectorSource,
  style: styleFunction,
  renderBuffer: 200
});

https://jsfiddle.net/4gvLhfje/10/

Thanks a lot and sorry for bothering.


add biginteger tests + mod change

What current issue(s) does this address, or what feature is it adding?
Add new tests for a block that failed. Change implementation to use Decimal % thanks to @merl
How did you solve this problem?
see above
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[ ] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.004%) to 85.28% when pulling 0b935cd7dbffb935f86c860678d0aa7169bcc6bd on ixje:bigint4 into 3817375e17566b2364ff8c459d2407618569abd6 on CityOfZion:development.


added config file for router; added histroy back directive

added config file for router; added history back directive;
both of these two changes are not testable at this moment. there is no view for these.

Thx.


Theme submission: sciolism 2019

Theme submission
Link to my theme repository: https://github.com/chemiker/sciolism-2019
I made sure that...

[X] the repository contains a good README.md describing my theme
[X] an open source license has been added to LICENSE.md
[X] all metadata have been added to theme.toml
[X] screenshots have been added in the images/ folder with the required dimensions
[X] I tested my theme against the gohugoio/HugoBasicExample

[X] I've checked the developer tools' console in my browser for error messages

[X] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

Link to my Twitter account: https://twitter.com/chemik3r

Hello Alex,
thank you for sharing this theme with the Hugo community. The review of your theme went fine. Do you really want to submit the theme without custom config for the theme demo?

Hi,
thanks for the review and the suggestion. I think I will provide a patch which includes a custom config in the next days. I'll let you know once the patch was pushed.

Hi,
I've just pushed version 1.0.1 of the theme which includes an exampleSite. Thanks again for suggesting. I realized that this will be helpful to the user to see all theme features in action and how to use them.
Please let me know if any add. modifications are necessary.

@digitalcraftsman Is there anything missing or is further action from my side required?

Hi Alex,
right now I'm short on time because I've to study for two exams. Hence the delay in the review of your submission. At the beginning of October I'll have more time to continue the review of theme submissions.

No worries and thanks for the update. Good luck for the exams!

Hi Alex,
by default the theme demos use the content provided by https://github.com/gohugoio/hugoBasicExample. Themes can be "whitelisted" to let them use their own provided content. This exception is usually only made in case the hugoBasicExample doesn't cover the needs of a theme.
Since your theme works fine with the hugoBasicExample I prefer to stick with it. However, there's no content file that triggers the generation of a search index. The search field in the footer in present in any case and points to an absent search index. Could you add a check for the existence of a search index before displaying the search form in the footer.
This way unexpected behavior in the theme demo can be avoided without needing to whitelisted the theme for a minor feature.

Hi,
thanks for the suggestion. I'm quite busy this week but I think I'll be able to provide a patch this weekend. I'll let you know once the check is added.

Sorry for checking back so late. I've now included a check if the search.md file exists. This will make sure that even if the search is enabled in the config file, no search form is shown if the content folder does not feature a search.md file.
However, I think this has probably not fixed the issue with hugoBasicExample. Running a local test with reviewTheme.sh still shows the search field even though I could verify that the fileExist command works as intended with another installation.

Hi @digitalcraftsman,
any update here? The requested check was added. Any additional issues that need to be addressed?


RpmSign: keyfile UX improvements

RpmSign: nicer logging when writing release.asc
With the switch to using the DebRepo class, we were logging the DebRepo repr when we wrote the release.asc file.
It's not terrible because the repr does show the path anyway, but it's less noise in the logs to just show the repository's filesystem path instead.

RpmSign: allow relative paths for --keyfile
We call os.chdir() a lot during signing. Prior to this change, we required the user to specify an absolute path to --keyfile.
Do the absolute path translation ourselves to make this a bit more user-friendly.

Fixes https://github.com/alfredodeza/merfi/issues/59

@ahills @tserlin FYI


Shakthinandana updating repo links

Codecov Report

Merging #65 (b8b3200) into main (e09f8ee) will increase coverage by 6.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   58.32%   64.47%   +6.15%
==========================================
  Files          20       23       +3
  Lines        1538     1796     +258
==========================================
+ Hits          897     1158     +261
+ Misses        641      638       -3

Impacted Files
Coverage Δ

cogs/profanity.py
77.77% <0.00%> (ø)

cogs/cal_attendance.py
22.64% <0.00%> (ø)

cogs/qanda.py
76.00% <0.00%> (ø)

test/test_bot.py
98.88% <0.00%> (+0.73%)
:arrow_up:

cogs/deadline.py
69.45% <0.00%> (+6.66%)
:arrow_up:

cogs/instructor.py
95.55% <0.00%> (+55.55%)
:arrow_up:

cogs/ta.py
100.00% <0.00%> (+60.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09f8ee...b8b3200. Read the comment docs.


Bump to phpstan rule level 6

Description

report missing typehints

Dumped errors (including the previous baseline) amounted to a whopping 613 errors!
This PR also changes the baseline from NEON to PHP format available since v1.10.2. The advantage is:

This might help with parsing performance and memory consumption in excessive baseline files that are megabytes in size. PHP code will be interpreted quicker than an equivalent .neon file.

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

@paulbalandan Can you also update the devkit templates?
https://github.com/codeigniter4/devkit/tree/develop/src/Template

@paulbalandan How do we update the baseline?
We have now 7 errors in 4.4 branch.
The following command generates phpstan-baseline.neon:
vendor/bin/phpstan --generate-baseline

I found the documentation: https://phpstan.org/user-guide/baseline#php-baseline-format-instead-of-neon


Cascade undetermined can't uncheck whole tree (all children)

My issue is that I'd like to select just a few children from parent but in the same time I can't uncheck all these children from his parent by clicking (changing status) on parent which is kinda sad because I have to go and manually uncheck all these children if I changed my mind (and it can be like 15 children)... Is it possible to set the checkbox plugin into undetermined status with possibility of massive unchecking all children when user changes his mind?

How about clicking twice? First it will select all children, then deselect them - the same way you see in all trees in various software (both mobile and desktop) - installers for example. If you want to do something custom you can always extend jstree with your own plugin, but I will not modify the core unless more people need this functionality.

Clicking twice does nothing... it only changes type of visual indicator inside checkbox (from cube [#] to ✓ and back again) it's missing the third status (not selected status) :/

I have this configuration btw:
`$('.js-categories-checkboxtree').jstree({
"core" : {
"animation" : 0,
"check_callback" : true,
"themes" : { "stripes" : true },
"state" : { "opened" : true },
"children" : [{
"state" : { "checked" : true },
}],
},
"types" : {
"#" : {
"max_children" : 1,
"max_depth" : 4,
"valid_children" : ["root"]
},
"root" : {
"icon" : "/static/3.3.5/assets/images/tree_icon.png",
"valid_children" : ["default"]
},
"default" : {
"valid_children" : ["default","file"]
},
"file" : {
"icon" : "glyphicon glyphicon-file",
"valid_children" : []
},
},
"plugins" : ["changed", "checkbox", "types"],
"checkbox" : {
"keep_selected_style" : true,
"three_state" : false,
"cascade" : "undetermined",
"tie_selection" : false,
"cascade_to_disabled": false,
"cascade_to_hidden" : false,
"whole_node" : true,
	},
	"expand_selected_onload" : true,

});`

Oh it's fine I have written my own script in the end. Wonna me post it here for other or later implements / fixes?

@Emptycz yes please...


Looking beyond default directories and archives?

This is so great. Thanks for writing and sharing it.
I was wondering if it's possible to find voice lines beyond Starfield.esm, ShatteredSpace.esm, SFBGS003.esm, and SFBGSESM004.esm?
For example, here is what it does when it finds the Astrid https://www.nexusmods.com/starfield/mods/8209/ mod:
2024-12-27 10:32:00.471 -05:00 [INF] Loading plugin AstridCrew.esm
2024-12-27 10:32:00.472 -05:00 [INF] Building wem Map for AstridCrew.esm
2024-12-27 10:32:00.472 -05:00 [DBG] Reading archive file C:\Program Files (x86)\Steam\steamapps\common\Starfield\Data\Starfield - Voices01.ba2
2024-12-27 10:32:00.740 -05:00 [DBG] Reading archive file C:\Program Files (x86)\Steam\steamapps\common\Starfield\Data\Starfield - Voices02.ba2
2024-12-27 10:32:00.880 -05:00 [DBG] Reading archive file C:\Program Files (x86)\Steam\steamapps\common\Starfield\Data\Starfield - VoicesPatch.ba2
2024-12-27 10:32:00.882 -05:00 [DBG] Parsing quest CREW_EliteCrew_Astrid in AstridCrew.esm
2024-12-27 10:32:00.882 -05:00 [DBG] Parsing dialogue  in AstridCrew.esm
2024-12-27 10:32:00.882 -05:00 [DBG] Parsing response 00080B:AstridCrew.esm with 1 responses in AstridCrew.esm
2024-12-27 10:32:00.883 -05:00 [WRN] Could not find wem file 000e35b5.wem in archive, continuing on.
2024-12-27 10:32:00.883 -05:00 [DBG] Parsing dialogue  in AstridCrew.esm
2024-12-27 10:32:00.884 -05:00 [DBG] Parsing response 00080C:AstridCrew.esm with 0 responses in AstridCrew.esm
2024-12-27 10:32:00.884 -05:00 [DBG] Parsing response 00080C:AstridCrew.esm with 1 responses in AstridCrew.esm
2024-12-27 10:32:00.884 -05:00 [WRN] Could not find wem file 0069501f.wem in archive, continuing on.
...
The .wem files are here though:
c:\Program Files (x86)\Steam\steamapps\common\Starfield\Data\sound\voice\astridcrew.esm\npcfastrid>dir 000e35b5.wem
Directory of c:\Program Files (x86)\Steam\steamapps\common\Starfield\Data\sound\voice\astridcrew.esm\npcfastrid
01/22/2024  09:15 AM            10,900 000E35B5.wem
1 File(s)         10,900 bytes
Thank you.

Ah yeah I hadn't considered loose files. Seems reasonable it should read the archive AND loose files.

Cool, thanks for considering it.


Install native package Error in ubuntu 18.04

sudo dpkg -i kuiper-1.1.1-linux-x86_64.deb
[sudo] password for swing:
Selecting previously unselected package kuiper.
(Reading database ... 351347 files and directories currently installed.)
Preparing to unpack kuiper-1.1.1-linux-x86_64.deb ...
Unpacking kuiper (1.1.1) ...
dpkg: dependency problems prevent configuration of kuiper:
kuiper depends on libc6 (>= 2.28); however:
Version of libc6:amd64 on system is 2.27-3ubuntu1.4.
dpkg: error processing package kuiper (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
kuiper
ps: version 0.9.1 is ok

Hi, @swing99527
Perform the dpkg -l | grep libc6 view your version of libc6, if its version is too low, upgrade it

Hi, @swing99527
Perform the dpkg -l | grep libc6 view your version of libc6, if its version is too low, upgrade it

Hi, @swing99527
Perform the dpkg -l | grep libc6 view your version of libc6, if its version is too low, upgrade it

Hi Rory-Z，
I believe It will fix this issue with upgrade libc6 version，
But my question can we make it compatible with lower verison libc?
As I tested before, Version V0.9.1 worked fined with lower libc6 version(2.27-3ubuntu1.4).

Hi, @swing99527
Perform the dpkg -l | grep libc6 view your version of libc6, if its version is too low, upgrade it

Hi Rory-Z，
I believe It will fix this issue with upgrade libc6 version，
But my question can we make it compatible with lower verison libc?
As I tested before, Version V0.9.1 worked fined with lower libc6 version(2.27-3ubuntu1.4).

please try 1.6.1 when it is released


Chess: Move C5 to B4

Please do not change the title. Just click "Submit new issue". You don't need to do anything else :D

@JeffGreenlee42 done! Successfully played move c5b4 for current game.
Thanks for playing!


[release-2.5] Added project component version

Signed-off-by: dislbenn<EMAIL_ADDRESS>

/retest

/retest

Will merge only because this is a no-op PR.


Support persisting multiple locales

We could approach it the same way as contentful/vault#78

I'm currently investigating Contentful for a content driven app localized into seven languages. All languages must be available offline and user should be able to change language independently from the device language settings.
Maybe one could define a Core Data model as Entity with a to-many relationship to EntityLocalized. Localizable properties goes into EntityLocalized and the others into Entity. Entity could expose localized properties via computed properties based on the selected language.


Update documentation on how to close a connection

This is an alternative for #5819.
Note that the TLS 1.3 draft really says that close notify now is only in 1 direction, and we no longer support SSL 2 so no reason to say "SSL 3.0 or higher".

New commits pushed

I don't think a code change will be necessary.

merged


issue#47 teaser component

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix#: https://adobe-acs-group.atlassian.net/browse/WRLDBAEMS-47
Desktop:

Tablet:

Mobile:

Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/
After: https://author-p136806-e1403562.adobeaemcloud.com/content/world-bank/global/md-test.html?ref=47-teaser

RE: build failing, I don't know how to resolve xwalk's issue with such a deep component model while still meeting all of the requirements of the ticket, but happy to adjust pending guidance.

@mdickson-adbe This is how it looks on Mobile. Something doesn't feel right. Could you please check this?

@mdickson-adbe Could you please fix the conflicts?

Merge conflicts resolved


fix(reconcile): Remove logs, printing a little to to much information

Found that we are printing a little to much at startup

er ikke så noe farlige endringer, så merger denne


Hot reloader not working

Just wanted to point out that when I install reapp, make a default app, and run it that the hot loader doesn't work out of the box for me.

Seems to be working for me, just did a reapp new and edited Hello World! and I can see it changing as I save.
Can you describe whats happening?

Good enough for me. May just be something specific to me then.
It's just not reloading the page when I save the changes, but it's not really bothering me much. You can close this if you want.

Ok, it should work in most cases, sometimes if you edit external theme files it won't update, but other than that it should work. Feel free to upload anything from reapp run -d or from your npm outdated.


Kafka ProducerListener disabled in Camden.RELEASE

Hi all,
We upgraded to the above release (including spring-cloud-stream-binder-kafka 1.1.0.RELEASE) to gain advantage of the "autoRebalanceEnabled" property. However, we noticed that in that release our ProducerListener doesn't work anymore.
I noticed in the code of KafkaBinderConfiguration (line 90) that setting the producer listener has been commented:
//kafkaMessageChannelBinder.setProducerListener(producerListener);
Any particular reason for this?
Thanks in advance

Hi,
Thanks for reporting.
I don't see any specific reason for this as KafkaMessageChannelBinder is required to set the producer listener from the binder configuration class KafkaBinderConfiguration which in turn will set the KafkaTemplate with that producer listener. So, it looks like a bug.
I see this change got introduced [here] (https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/commit/1bf14ac3909b0ec097e2b2a2c10fb3c96d4b9cc2#diff-30c40a58b9dfd50d0385d03ec3d29663R64).

Moving this to https://github.com/spring-cloud/spring-cloud-stream-binder-kafka

Just a quick note - we've separated binder implementations from the core project so that they can evolve independently. Closed and moved this to the Kafka binder repository.
https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/49


Problem with templates methods

Vue.js version:  1.0.26
techno: MVC4, C#4.5

Hi,
I have a problem when i call a methods on template options.
templates: {                     Action: "delete"                 },
When i passed an int in {Name} my method is called, but when i try with a string the method did not call.
n.b: i use double @@click because i use razor asp.net and it work with an other method.
do you an issue for my problem ?

You need to wrap Name with double quotes so it will be interpreted as a
string. The way it is now it is interpreted as a variable name
On Aug 30, 2016 5:18 PM, "KerMiiTT"<EMAIL_ADDRESS>wrote:

Vue.js version: 1.0.26
techno: MVC4, C#4.5

Hi,
I have a problem when i call a methods on template options.
templates: {
Action: "delete"
},
When i passed an int in {Name} my method is called, but when i try with a
string the method did not call.
n.b: i use double @@click https://github.com/click because i use razor
asp.net and it work with an other method.
do you an issue for my problem ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/matfish2/vue-tables/issues/93, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABcMPLoi0pFY4HNJjxo9btjZG05Dd5Tqks5qlDu4gaJpZM4JwlD8
.

thank you for your quick response
so like this : "delete" ?

i have tried with this :
'delete'
and my methods is  deleteDocument: function (data) {                 console.log("OK delete" + data);             }
but it doesn't word
i try to change with 'delete'
and it same

i have tried on your live demo https://jsfiddle.net/matfish2/f5h8xwgn/
i have changed the {id} by 'test' delete: ""
it's same, it doesn't work, what's wrong ?

You already use single question to wrap the click exprssion. You can't use them again within this expression without escaping or contcatanating. This WILL work:
 ""

thank you very much for your answer , it works perfectly


Create an sh script to deploy the demo to gh-pages

I tried deploy-gh-pages package, and it didn't work for me.
Open for suggestions.


Ui update

Pull Request Test Coverage Report for Build 124

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.811%

Totals

Change from base Build 122:
0.0%

Covered Lines:
249

Relevant Lines:
264

💛  - Coveralls


Urban data demonstrator notebook

A PR for contributing an Urban UKV gridded model data demonstrator notebook to the Environmental AI book. The notebook demonstrates:

Using Iris to load, visualise and regrid Met Office UKV NetCDF data
Using Iris to extract the London region and save as a new NetCDF file

Notes:

The data is freely available (link in notebook). For convenience, I have included a sample data daily data file as it is not too big.
I have added Iris to the environment.yml file as it takes along time to install - I also think it is generally useful for many use-cases so if we can have it as a standard package it would be good :-)

See Iris docs here: https://scitools-iris.readthedocs.io/en/stable/installing.html

@svadams Thanks for the contribution. I left some suggestions. Be free to explore them in ReviewNB.
ps. sorry for the late review but I was moving to the UK last week (now in a quarantine hotel).

@acocac - I made some improvements following your suggestions - can you please take another look when you have time :-)

@svadams, thanks for the improvements, LGTM!
Regarding the notes markdown, most of Jupyter Book’s functionality comes from Sphinx extensions. This means if you want to see this particular markdown for a given ipynb file, you'll need to install the Sphinx plugin in your python interpreter.


Client-prediction tracking

This is working fine, in the test and in my game (which has a misprediction cleanup system similar to the new docs describe).
I'm currently sending Entity::PLACEHOLDER where there is no prediction, so still need to decide on the packet format.
With a bit more code complexity, like a shared config between client and server, we can make it totally opt-in and zero cost if the feature isn't used, otherwise I think i can make it cost 1 bit per entity to mark if there's a predicted entity too.
This is to fix https://github.com/lifescapegame/bevy_replicon/issues/67

If we made a new shared config struct that the client and server plugins take, this kind of feature can be opt in depending on the style of game.
how about something like:
struct RepliconConfiguration {
    // Makes the `PredictionTracker` available on the server, and supports client-predicted entity mapping.
    pub client_predictions: bool,
}

Another option might be to not insert the PredictionTracker resource by default, and make the user insert the resource on both client and server if they want to enable the feature (even though the client doesn't need it)

Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8342a03) 96.16% compared to head (66dfdab) 94.40%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   96.16%   94.40%   -1.77%
==========================================
  Files          13       14       +1
  Lines         834      875      +41
==========================================
+ Hits          802      826      +24
- Misses         32       49      +17

Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

src/server/replication_buffer.rs
99.10% <100.00%> (+0.05%)
:arrow_up:

src/client.rs
90.14% <93.75%> (+0.29%)
:arrow_up:

src/server.rs
96.68% <85.71%> (-0.42%)
:arrow_down:

src/server/prediction_tracker.rs
43.75% <43.75%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reverted the entity encoding commit and added a currently-failing test showing the edge case @Shatur pointed out.

"include additional array with entity to entity mappings instead. This array should come first and will be processed before replication and it just updates mappings on client. So additional callback won't be required. "

also pointed out there's no need for the prediction hit callback, since successful prediction means the predicted entity will receive (at least) the Replication component, so hits can be detected with a Query<Entity, <With<Prediction>, Added<Replication>>>
i will change it to using an entity mapping array as discussed.


Fix Marker & Cluster mouse events

This fix was original merged (via #619) into an early v4 branch which has been abandoned. Using createPortal fixes capturing move/scroll/zoom events on Marker & Cluster elements
Closes #217 (again)
Closes #562

@alex3165 @brendanmoore any movement on this? I just pulled the latest react-mapbox-gl only to realize this hadn't been merged yet. Just found another v4 PR I had made got lost as well (#533) 😞

I found a workaround for now...basically just manually implementing the createPortal logic in your own component.
import { withMap } from 'react-mapbox-gl/lib-esm/context';

const MyLayer = withMap(({ map }) => createPortal(
  <Popup>Hello World</Popup>
  map.getCanvasContainer(),
));

Eventually withMap will likely be exported directly from react-mapbox-gl (see #654)

Would love to see this merged.  Is there anything I could do to help?

Thanks @brendanmoore!

Released in v4.3.0: https://github.com/alex3165/react-mapbox-gl/releases/tag/v4.3.0

Hmm, this seems to have caused https://github.com/alex3165/react-mapbox-gl/issues/725

Reverted the default functionality to not use a portal in v4.5.0, see the release & issue #725 for more.
In hindsight, this was a breaking change and should have either gone into v4.0.0 or waited for the next major release.

Is the marker fix still working? Its still capturing scroll events on v4.8.1 for me.

Unfortunately if you need some components to render in the portal and others not to (e.g. you want popups to capture events but markers to pass through), you'll still need to use your own workaround to render just the components you want in a portal. Instead of adding renderChildrenInPortal, you would need to do something like this:
import * as React from 'react';
import { MapContext } from 'react-mapbox-gl';

export const PassThroughMarker = props => {
  const map = React.useContext(MapContext);
  const container = map.getCanvasContainer();

  return container && createPortal(<Marker {...props} />, container);
};


patch: Correct local mode settings tab toggle on dashboard

Button for toggling local mode now appears in the settings tab.
Updated docs and screenshot to reflect this detail.

Hey @vipulgupta2048 sorry - I didn't catch those errors, yes you're right, some weird auto-linting on Markdown I didn't realise was happening. Also, have cropped the image - let me know if I've misunderstood your instructions, and reverted the filename back to original.


Embed not working on firefox

When I try to write the url for the embed in firefox the keyup event is firing but the placeholder is not going away. If I wrap the br tag with a p then it seems to work.

I forgot to mention that this is on the 1.0.0 branch.

Thanks for the report. I will look at it today.

You were right. The problem was with br tag not being wrapped in p. In Chrome it is done automatically, but Firefox doesn't do that. I've made sure that it is wrapped correctly in all browsers. Now it should work correctly.

Awesome! Thanks for fixing this so quickly. Also congratulations on the 1.0 launch. I've found this version to be way easier to work with than the previous one.


Why don't you have the changelog.md file, where can you see what's updated every time

Why don't you have the changelog.md file, where can you see what's updated every time

It is now under the Releases tab.

@CDDelta  thank you

@jiayisheji Could you please close the issue as it is solved?


Duplicate class com.google.mediapipe.formats.annotation.proto.RasterizationProto

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
None
OS Platform and Distribution
MacOS 13.4, Android 13
Mobile device if the issue happens on mobile device
Pixel 4a 5G
Browser and version if the issue happens on browser
No response
Programming Language and version
Kotlin
MediaPipe version
No response
Bazel version
No response
Solution
Hand
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
No response
Describe the actual behavior
I'm currently trying to use Mediapipe mediapipe:tasks-vision (0.10.1) for Hand Landmarks detection. The project previously used mediapipe:solution-core(0.10.1) dependency. However, when I try to build the project, I got the error Duplicate class com.google.mediapipe.formats.annotation.proto.RasterizationProto found in modules jetified-solution-core-0.10.1-runtime (com.google.mediapipe:solution-core:0.10.1) and jetified-tasks-core-0.10.1-runtime (com.google.mediapipe:tasks-core:0.10.1).

Describe the expected behaviour
The code runs without duplicate class

Standalone code/steps you may have used to try to get what you need
None

Other info / Complete Logs
No response

Hello @DanhDao1997,
Could you please elaborate your query with complete steps followed to reproduce the issue from our end?  Thank you!


[Highlight references] Does not work for _ identifier

I ran some tests, and the same seems to apply to any identifier enclosed in double backticks that begins with an underscore (``_bla``), but not if it happens to have an underscore anywhere else (``bla_`` or ``bla_bla``).

Interestingly, a member with such a name does get highlighted:

Just for the record, the problem is apparently in FSharp.Compiler.Service.


Versions 1.0.29 and 1.0.30 say they are compatible with version 1.20.2, but the required Sodium version isn't

Hi,
I have been having this issue where I got this error today when launching my game through Modrinth:

This happens because I updated my mods today before playing and the latest version of Indium requires a newer version of Sodium (5.5.8). The issue is that the version that is required by Indium is not available for version 1.20.2, but Indium is listed as being compatible with this version in Modrinth.
Because of the fact that Indium requires Sodium to function I think it is better to remove support for the older MC versions because version 5.5.8 of Sodium isn't available for those anyway. That way mod managers like Modrinth won't try to install it.
I now fixed it by manually changing the version of Indium back to 1.28.0, but ever time I run the auto update in Monrinth I have to change this again to fix the error.
Hope to see a response as to what your idea is on this.

Version 1.0.28 is compatible with 1.20.2 and Sodium 0.5.5 (latest sodium version compatible with 1.20.2)
Yes I know it is, that is not the issue. The issue is that versions .29 and .30 are also listed as being compatible with 1.20.2, while at the same time requiring a newer Sodium version which isn't compatible with 1.20.2.
So my suggestion was to remove the listed support for 1.20.2 for newer versions so that mod managers won't try and automatically update Indium and cause the error, which than has to be fixed manually each time.

Done! Sorry I left it like this for so long 🙃


Added  licence

Merging after adding the license and editing the README files.

Conflicts resolved and merging done.


Avoid recursive template instantiation in priv::set_option()

A small suggestion to avoid recursive template instantiation in priv::set_option(): use the initializer_list trick as below.
Of course, if you intend to restrict the library to C++17, a fold expression would be a more straightforward choice.
template <typename... Ts>
void set_option(Session& session, Ts&&... ts) {
    std::initializer_list<int> ignore = { (session.SetOption(std::forward<Ts>(ts)), 0)... };
    (void)ignore;
}

Thanks for the suggestion!
Could you please explain to me a little bit more what happens here, since I do not get how this solves our problem?

I found the following posts explaining this technique:
https://articles.emptycrate.com/2016/05/14/folds_in_cpp11_ish.html
https://kubasejdak.com/techniques-of-variadic-templates

Aha, OK! Thanks.
Would you like to create a PR for this?


⚠ Bofrost.at has degraded performance

In 7a468e1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1157 ms

Resolved: Bofrost.at performance has improved in 3163b11.


Neverthromicon (wiki)

I started a wiki for neverthrow that aims to document best practices on how to do error handling in a functional style.
This wiki is very early stage and am looking for help / suggestions / feedback.

cc @paduc :)

Great initiative @supermacro. I'm currently refactoring my current project to use neverthrow everywhere. I might have a couple use-cases to showcase and discuss !

I'm also thinking it might make more sense to use Gitbook and have a wiki folder in the project. That way, people can open PRs against the wiki.

I think the content is more important than the medium. The wiki is a great way to start the ball rolling !


Get the latest version's README in rss feed

Before this change, the result of the group by would have the readme of the first version of a package instead of the latest.

Is this safe?
If your rss reader has already read the description of a package, will importing a new version make that package re-appear in your feed? Or will it not because it sees that it's already seen the same id? 🤔

Good question! I can test this later.

I tested this locally with the Reeder app on Mac.
I updated fake-gren-package README and the rss feed showed the updated readme, but it did not affect the order of the items, and my Reeder app did not show it as unread or new. I then added a fake-gren-package-2 item and it showed that as new, still with the old package marked read.
With that said, I think I was misunderstanding the purpose of the rss feed, and since the purpose is to only show newly-added packages, this change may not be needed, and having multiple versions of a README tagged when you first add a package is probably an edge case likely only when testing. I'll leave that up to you if you want to merge or close this.

Realized I worded that kind of weird...

If your rss reader has already read the description of a package, will importing a new version make that package re-appear in your feed?

At least in Reeder on the Mac, no.

Or will it not because it sees that it's already seen the same id?

That seems to be the case on Reeder.
But not sure if other readers will act the same, so I'm not sure if this is a good change or not. Up to you.

and having multiple versions of a README tagged when you first add a package is probably an edge case likely only when testing.

Actually, this has happened on more than one occasion. Sometimes I've tagged a package but not told anyone, so that it's easy to test by others. Later, when I want the package to be known I import it into the package registry, only to have the first, faulty README be broadcast to everyone's feed.
I think this is worth trying out.


Error contexts

This PR introduces a notion of context to error messages. We had some support for it in the shape of the "message prefix", which was prepended to the message and printed in a single line. It also had a limitation that one could not catch and re-raise an error without corrupting its prefix, since it was appended at the time of the raise/log_issue.
This PR changes the type of error to carry the context explicitly as a list of strings. At the time of printing, each string is appended in its own line, giving errors like this:
module A

open FStar.Tactics

let x = assert True by (fail "abort")

proof-state: State dump @ depth 0 (at the time of failure):
Location: A.fst(5,23-5,37)
Goal 1/1:
 |- _ : Prims.squash Prims.l_True

A.fst(5,8-5,14): (Error 228) user tactic failed: `abort`
> While preprocessing VC with a tactic
> In the top-level declaration for `let x`
> While checking module A
  (see also A.fst(5,23-5,37))
1 error was reported (see above)

This makes it easier to locate errors which have a bad range (which happens quite often), and errors for spliced definitions which do not appear in the source. This context is also printed in emacs.

For now I've pushed a new context for tc_decl, tc_modul and the Meta-F* entrypoints. We could certainly add more, for instance phase 1 typechecking, generalization, encoding a query, extracting a definition, etc.
Relatedly, I would like to deprecate failwith to raise an exception we define for F*, which could carry a context and provide better error messages.

I implemented the changes we discussed today:

Keep failwith/Failure as-is for now
Don't print "While checking module X" when X is given in the command line; only print it for dependencies.

Also added contexts to reading/writing checked files and generalization.

Hi, I think this is ready to merge. We had some concerns on whether the size of the diagnostic buffer (the one at the bottom.. not sure if that's the name) could grow too big with the contexts, and if we could omit it there and just display the context in the tooltip over the error. I couldn't easily modify fstar-mode to do so. Also, I think in practice it won't be a problem (depth could be 4-5 at most).
I'd like to get this merged since I often use it to debug myself.

I'm going to merge this but only enabled with a flag, so we shouldn't see any change. This will prevent the PR from diverging too much, and when we're happy we can flip the switch.