Add a vertex color property to PrimitiveMesh

This property can be used to color primitive meshes individually.

This can be used to color billboards such as light flares without having to use a unique material for each color, improving performance.
This can be used when prototyping to color different objects while keeping a single material for all meshes.

Note: Until https://github.com/godotengine/godot-proposals/issues/3031 is implemented, you will have to create a StandardMaterial3D resource, assign it to the mesh and enable Vertex Color > Use As Albedo for the color to be visible.

This can be used in custom shaders to provide configurable per-instance information.

Preview
Note: The property is now called vertex_color instead of vertex_color_modulate.
https://user-images.githubusercontent.com/180032/126866782-bed89b28-bb2a-4ac3-9cf0-c115ad6ef125.mp4

I think with the addition of per instance parameters there is not a lot of need for things like this. Those are more efficient because you dont have to replicate the primitive or the material.
Maybe what is missing here is having a flag to make the color of the material an instance variable.

I agree that per-instance uniforms are probably a more efficient way to solve this at a large scale, but it requires modifying the base shader just for a prototyping purpose (at least in the use case I mentioned above).
Would this PR still make sense for 3.x which lacks per-instance shader uniforms?

@Calinou well, you also need to modify the material (tick reading from color) in order to see the vertex colors, so I imagine having a similar option (expose albedo as per instance uniform) is more or less the same.

well, you also need to modify the material (tick reading from color) in order to see the vertex colors

If https://github.com/godotengine/godot-proposals/issues/3031 was merged, that wouldn't be needed :slightly_smiling_face:
Note that the above PR only reads albedo from vertex color in the fallback material, so performance in any non-prototype project should remain identical.

Vertex colors impose a toll on bandwidth and, as I mentioned, we have per instance parameters. I really would just make it easier to expose on StandardMaterial that you want to use a per instance parameter.

as I mentioned, we have per instance parameters

Are per-instance parameters feasible to implement in GLES3 too?


Unable to load model

Hi,
I am getting following error when trying to load the model using AutoModelFromCausalLM
Traceback (most recent call last):
File "", line 1, in
File "/opt/conda/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 526, in from_pretrained
config, kwargs = AutoConfig.from_pretrained(
File "/opt/conda/lib/python3.10/site-packages/transformers/models/auto/configuration_auto.py", line 1099, in from_pretrained
return config_class.from_dict(config_dict, **unused_kwargs)
File "/opt/conda/lib/python3.10/site-packages/transformers/configuration_utils.py", line 774, in from_dict
config = cls(**config_dict)
File "/opt/conda/lib/python3.10/site-packages/transformers/models/llama/configuration_llama.py", line 160, in init
self._rope_scaling_validation()
File "/opt/conda/lib/python3.10/site-packages/transformers/models/llama/configuration_llama.py", line 180, in _rope_scaling_validation
raise ValueError(
ValueError: rope_scaling must be a dictionary with with two fields, type and factor, got {'max_factor': 16, 'param_factor': 1, 'type': 'clex', 'factor': 1}
and when trying to load it via PhiForCausalLM, I got error during generate
File "/opt/conda/envs/clex/lib/python3.10/site-packages/torch/autograd/function.py", line 506, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/opt/conda/envs/clex/lib/python3.10/site-packages/flash_attn/bert_padding.py", line 17, in forward
return torch.gather(
RuntimeError: index 17 is out of bounds for dimension 0 with size 7
Can you please guide me on how to set this up properly?

Hi, thanks for your interest!

Please specify trust_remote_code=True in from_pretrained as we have a custom config and model class, otherwise it would load default LLaMA classes and result in the errors.
We specify using flash attention for all models, so I guess this is because you don't use flash attention in from_pretrained by use_flash_attention_2=True. Sorry for the inconvenience and now I have fixed it so you can choose to use flash attention or not.

Hi @guanzhchen,
Thank you so much for fixing this quickly. I will give this a try in a bit. Another quick question, for finetuning specifically SFT I still need to use clex layer as well, right? I saw you guys have SFT script. Did you guys already tried SFT? Does it work well in your case?

We have done SFT on CLEX-Mixtral and CLEX-LLaMA and it indeed shows some promising extrapolation ability, as shown in the results on InfiniteBench and LongBench.
When doing SFT, I still recommend using the clex layer and tuning it if you want to achieve extrapolation instruction-following ability. I have verified that fixing the clex layer during SFT would produce poorer instruction-following ability when testing beyond SFT length.

@guanzhchen  Thank you so much! This is all really helpful. Just last question, when finetuning or continuing to pretrain what is the max_model_length that should be used? So for example if I am already using DAMO-NLP-SG/CLEX-Phi-2-32K, the max_model_length should be 32k or should be what I want my sequences to be? For both the train scripts I see 4k, I assume this is just to return the constant length dataset so, it should be 99th percentile of your training data. Is my understanding correct?

@kmussa1993 The max_model_length should be within the range of max_factor*max_position_embedding (both args are shown in the config). The max_factor is bounded with the native context length (i.e., 2k for Phi-2) rather than the training length, so you can choose any training sequence within this threshold.
BTW, the choice may affect the extrapolation ability, for example, if you want to extrapolate to 128k, training on 32k is probably better than training on 16k. However, I guess the gap would not be very large if SFT upon our base model (e.g., DAMO-NLP-SG/CLEX-Phi-2-32K).

Hi @guanzhchen,
Thank you so much. I will give it a try. My plan is to continue Pretraining for a bit, and see if sft helps.
Thanks again for the help and much appreciated

Sorry for the omission. Now I have added the zero_2, zero_3 and zero_3_offload configs. You are not necessary to use zero_3_offload, please choose the config according to your GPU resource.

Yes, I have skipped these for now. One more thing during training it creates clex_args via this build_clex_args function. The time_dt field is missing there. Whereas in the config it is required.

time_dt is always set as 0.01. please add it to the arguments (like what the newest commit done) or just set it as a fixed value in clex_layer.py.

It's a refactoring version which is different from the dev version I use, I apologize for any omitted details and feel free to drop any questions here.

Yes, I added that :) it worked. Also what about chars_per_token. I see there is a function to calculate this but never used and hard coded to a specific value. Should I change it to that function or keep it constant. For now, I changed it but it says tokens() is only available for fast tokenizers

Oh I fixed it by setting use_fast=True, sorry for my dumb questions here and thank you so much for responding this quickly.

Hi @guanzhchen,
Did you have any problem when loading model using resume_from_checkpoint =True? when I am doing this it takes too long to start training making it seems like hanged. Not sure if its hanged or something else.


Migrate legacy AI instances/flows into the main AI instance

For best practices and in support of our GDPR efforts

This is done. Both interactive shell and feedback are sending telemetry to the main source.


Improve documentation of expression evaluator

This PR adds info about a possibility to evaluate the text selected in the editor.
Also corrected one typo and incorrect image.

LGTM


Link the licenses into crates/cargo-platform

The licenses should be included in the package published on crates.io

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

Look good to me,
@ehuss any reason not to do this?

Seems fine to me.
@bors r+

:pushpin: Commit 9c8b4dcd3e9c3e21d7ed23345e8848291b162ae0 has been approved by ehuss

:hourglass: Testing commit 9c8b4dcd3e9c3e21d7ed23345e8848291b162ae0 with merge 17855e583f2079bee0c6fe885d9f0af6c1aa10d2...

:sunny: Test successful - checks-azure
Approved by: ehuss
Pushing 17855e583f2079bee0c6fe885d9f0af6c1aa10d2 to master...


Add tests for AprsIsConnection

Description
AprsIsConnection is missing unit tests. They were prototyped a while back but had not been merged in. This PR updates the branch with the latest in main and adds a few tests.
The tests have a timeout while waiting for messages to move. I set the timeout based on multiple runs on my machine, so I suspect they'll be okay, but the timeouts can be upped in the future if they're causing failures.
I also hit a few targets of opportunities for minor tweaks needed in the code.
Changes

Add AprsIsConnectionUnitTests
Tests server login and TCP message received event
Rename the AprsISLibrary directory to AprsIsConnection to match the project name
Add a LoggedIn property on AprsIsConnection to allow the caller to see if login was successful on their connection

Validation

Build and tests passing on my machine
Running APRSsharp console app behaves as expected

I understand the logic of successful login from the changes to the PR, but will we also take into account successful password authentication or we will only care about whether the user has logged in as per the PR?

@eddywine That's a great idea! To avoid "feature creep" in this PR, I've opened #99 so that we can add it in the future. Since this project is so early and not published as a package or anything, we can afford to accept this PR now and make a breaking change in the future.


Release process and delivery pipelines for new reconciler ecosystem

Description
The new reconciler product consists of multiple different services and resources (e.g. Kyma operator, Manifest operators, Kyma CRDs etc.). The creation of release and the lifecycle management of the different components of this product can be challenging (especially in regards to configuration options and updates). A concept is required, how all resources have to be deployed and properly configured in Kubernetes to get the product working (potential solutions could be to the HELM package manager, Kyma CLI etc.).
Additionally, a lightweight end2end test is required to verify that the the new reconciler product was successfully installed and is ready to work.
Finally, SREs have to be ramped up and enabled to implement a delivery pipeline in their CI/CD system (Spinnaker) to automate the rollout and update of the new reconciler product to the KCP DEV/ STAGE / PROD landscapes.
AC:

[x] Define a concept how the lifecycle of the reconciler will be managed / how the release process works

[x] Concept is aligned within the team and SREs

[ ] Necessary tooling for the lifecycle management is configured / implemented (e.g. CLI command etc.)
[x] SREs are ramped up and tooling is passed over so that SREs can configure their CI/CD system to deliver the new reconciler product to KCP landscapes
[ ] Simple E2E test case is implemented to verify the correct deployment of the reconciler product
[x] ~End-user documentation (main audience is SRE and developer) is available~ -> see https://github.com/kyma-project/community/issues/700

Reason
Establish a solution for lifecycle management of the new reconciler ecosystem.

Depends on parts of https://github.com/kyma-project/cli/issues/1325

My suggestion:

[ ] Create a hook / pipeline to parse the images build in the post-build jobs (e.g. post-main-lifecycle-manager-build)
[ ] Take that image and parse it with Kustomize plus Overlays per Environment and use that image from the job in the IMG variable: for a reference, look at https://github.com/kyma-project/lifecycle-manager/blob/main/operator/Makefile#L98-L101 but we should parse the kustomize into a repository instead and use it from ArgoCD or another GitOps system. This Git Repo will need to be updated with the new images (ideally automatically without a Bump PR)
[ ] Deploy to Environment with apply

Also Quick Note: we do not want to use Spinnaker any longer (discussed in last sync)

Relates to internal SRE issue.

Covered by internal SRE ticket and by the #187


forward dynamics on going work

[ ] Linked issue related to your pull request using '#XXX'
[ ] Used the tag [WIP] or [RTR] for on-going changes, or for ready to review
[ ] Did you write a proper documentation (docstrings and ReadMe)

This change is

Codecov Report
Base: 77.36% // Head: 77.15% // Decreases project coverage by -0.21% :warning:

Coverage data is based on head (9bd8e4c) compared to base (d61447e).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   77.36%   77.15%   -0.22%
==========================================
  Files          25       25
  Lines        1131     1138       +7
==========================================
+ Hits          875      878       +3
- Misses        256      260       +4

Impacted Files
Coverage Δ

bionc/model_computations/natural_segment.py
82.64% <60.00%> (-1.19%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update installation.md

Updated installation.md with link to the Scaleway cloud deployment tutorial

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@opetrova , thanks for the PR. We will investigate problems with the build on our side.

Thank you @nmanovic ! Sorry, I just realized that I did not include this new section in the table of contents at the top of the file, I will submit a new PR to fix it


Adding a link to GIT from school placements

Added a link to GIT to the 'Teacher training' page from the 'School placements' section for both HEI and SCITT versions.

 Review 'Advice from GIT' and links between Find and GIT


⚠ Processors has degraded performance

In 67254f5, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 42 ms

Resolved: Processors performance has improved in ae2c9c0.


Split when into whenState and whenInput

Would be really helpful to be able to check on input too when using when - so I suggest to split it up into whenState (the current when) and whenInput (new when).

Sounds like a good idea. Maybe it should only check input. Then you can do stateToOutput first?

I haven't yet made up my mind whether actions should operate on input or state and if it would make sense to have one way of doing or if it should always be up to the developer.
Some more opinions would good for this one.

Take this use case
import setError from '../actions/setError'
import submitOrder from '../actions/submitOrder'
import setState from '../actions/setState'
import validateOrder from '../actions/validateOrder'
import redirectToUrl from '../actions/redirectToUrl'
import { when } from 'cerebral-addons'

const whenOrderIsValid = when(['checkout', 'orderForm', 'valid'], { valid: when.truthy })

const orderSubmitted = [
  validateOrder,
  whenOrderIsValid, {
    valid: [
      setState(['checkout', 'orderForm', 'loading'], true),
      [
        submitOrder, {
          success: [
            redirectToUrl('/thankyou')
          ],
          error: [
            setError,
            setState(['checkout', 'orderForm', 'loading'], false)
          ]
        }
      ]
    ]
  }
]

export default orderSubmitted

The action whenOrderIsValid throws an error on this line because the otherwise output doesn't exist.

By switching to input we make it more compossible. So it's then the choice of the developer without addons having to implement multiple versions.

Agree. I am a bit in between though whether it's to cumbersome to always copy state to input or whether it could become some sort of best practice to have actions work on input/output and do the state transition in a separate action.

Humm. This is feeling similar to the module path discussion. Maybe some kind of path syntax that allows you to define the base (module, global, input, etc)

Good point. Always hard to decide without using it for a while.

I was toying with the idea of url scheme:
scheme:[//[user:password@]host[:port]][/]path[?query][#fragment]

where only scheme and path are mandatory.
So scheme could be used for (state|input), host could be used for (module) and path could be used as we currently do with statePath.
//cc @christianalfoni @Guria

Very interesting

So to reference and input value you would do:
input:key.subkey

to reference global state
state:key.subkey

to reference module state
state://moduleName/key.subkey

Maybe try it in a branch?

there are already good url parsers, so you don't need to write one.

"host" part would be meaningless for input "scheme"?

yes, but host is optional according to url spec.
I will make a mockup in addons

Got it. Optional but still meaningfull. Still worth to try.

This has been solved by the latest release.


auto failover failure

I deploy one  master and  two slave on the same machine, after kill master ,the auto failover is failure
toplogy:
<IP_ADDRESS>:3306(master)
<IP_ADDRESS>:3307(slave1)
<IP_ADDRESS>:3308(slave2)
log_slave_updates = 1
gtid_mode   =1
the debug message  output:
INFO executeCheckAndRecoverFunction: proceeding with DeadMaster recovery on  hostname:3306; isRecoverable?: true; skipProcesses: false
INFO auditType:emergently-read-topology-instance instance:hostname:3306 cluster:hostname:3306 message:FirstTierSlaveFailingToConnectToMaster
is this toplogy not support?
thank you

Hi, there is not enough information here. What is the problem? All seems well in the two lines of log you pasted. To help me help you out, please describe what you did, what you expected, what actually happened, a full --debug log goes a long way, your config, ...

debug output:
2019-08-13 13:44:54 ERROR ReadTopologyInstance(hostname:3306) show variables like 'maxscale%': Error 1053: Server shutdown in progress
[mysql] 2019/08/13 13:44:54 packets.go:36: unexpected EOF
[mysql] 2019/08/13 13:44:54 packets.go:36: unexpected EOF
2019-08-13 13:44:54 ERROR invalid connection
[mysql] 2019/08/13 13:44:54 packets.go:36: unexpected EOF
2019-08-13 13:44:54 ERROR invalid connection
2019-08-13 13:44:54 ERROR invalid connection
2019-08-13 13:44:54 WARNING  DiscoverInstance(hostname:3306) instance is nil in 0.012s (Backend: 0.011s, Instance: 0.001s), error=invalid connection
2019-08-13 13:44:55 DEBUG analysis: IsMaster: true, LastCheckValid: false, LastCheckPartialSuccess: true, CountReplicas: 2, CountValidReplicatingReplicas: 2, CountLaggingReplicas: 0, CountDelayedReplicas: 0,
2019-08-13 13:45:00 ERROR dial tcp ip:3306: connect: connection refused
2019-08-13 13:45:01 DEBUG analysis: IsMaster: true, LastCheckValid: false, LastCheckPartialSuccess: false, CountReplicas: 2, CountValidReplicatingReplicas: 0, CountLaggingReplicas: 0, CountDelayedReplicas: 0,
2019-08-13 13:45:01 WARNING executeCheckAndRecoverFunction: ignoring analysisEntry that has no action plan: FirstTierSlaveFailingToConnectToMaster; key: hostname:3307
2019-08-13 13:45:01 WARNING executeCheckAndRecoverFunction: ignoring analysisEntry that has no action plan: FirstTierSlaveFailingToConnectToMaster; key: hostname:3308
2019-08-13 13:45:01 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster detection on hostname:3306; isActionable?: true; skipProcesses: false
2019-08-13 13:45:01 ERROR dial tcp ip:3306: connect: connection refused
2019-08-13 13:45:01 INFO checkAndExecuteFailureDetectionProcesses: could not register DeadMaster detection on hostname:3306
2019-08-13 13:45:01 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster recovery on hostname:3306; isRecoverable?: true; skipProcesses: false
2019-08-13 13:45:01 INFO auditType:emergently-read-topology-instance instance:hostname:3306 cluster:hostname:3306 message:FirstTierSlaveFailingToConnectToMaster
2019-08-13 13:45:02 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster detection on hostname:3306; isActionable?: true; skipProcesses: false
2019-08-13 13:45:02 ERROR dial tcp ip:3306: connect: connection refused
2019-08-13 13:45:02 INFO auditType:emergently-read-topology-instance instance:hostname:3306 cluster:hostname:3306 message:FirstTierSlaveFailingToConnectToMaster
2019-08-13 13:45:02 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster recovery on hostname:3306; isRecoverable?: true; skipProcesses: false
2019-08-13 13:45:03 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster detection on hostname:3306; isActionable?: true; skipProcesses: false
2019-08-13 13:45:03 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster recovery on hostname:3306; isRecoverable?: true; skipProcesses: false
2019-08-13 13:45:04 INFO executeCheckAndRecoverFunction: proceeding with DeadMaster detection on hostname:3306; isActionable?: true; skipProcesses: false

I plan to test orchestrator on a server.but after kill master ,the  instance of two slaves can't promot to be new master. I use the orchestrator-sample.conf.json as the config file,just modify the orchestrator backend database

Did you update RecoverMasterClusterFilters?
Please make sure to read the docs, https://github.com/github/orchestrator/blob/master/docs/configuration-failure-detection.md, https://github.com/github/orchestrator/blob/master/docs/configuration-recovery.md

it is normal failover ,thank you .I  go to read docs again


Add failsafe

Description

Adding a couple of failsafes to account for the rare occurrence where the widget subscribe page does not detect if there's an active sub

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Closing this in favor of a more sustainable solution


Processing data models.

For this milestone of the project, I have implemented the following:

Created model classes for users, comments, posts, and likes according to ERD.

Created custom methods for:

      Users

[ ]  A method that returns the 3 most recent posts for a given user.

  Posts

[ ]  A method that updates the posts counter for a user.

[ ]       A method which returns the 5 most recent comments for a given post.

  Comments

[ ]  A method that updates the comments counter for a post.

  Likes

[ ]   A method that updates the likes counter for a post.

This is the diagram I was told to work with:

Hello @Muhammad0602 👋,
This is an additional review as a result of the second opinion request.
I can see that your project has been approved. Good luck on your upcoming projects 💯 ✊.
Keep rocking 🚀!


treat railyards as single crossings

See these crossings in Surrey for examples:
1010305120
1010305155
This is unlikely to be worth the effort of identifying railyards and clustering the crossings within the modelled_stream_crossings scripts.
Simplest fix would be to edit https://github.com/smnorris/bcfishpass/blob/main/data/user_modelled_crossing_fixes.csv to remove all but one crossing per railyard.

Manual fix has been applied for the Surrey railyards.
An automated cluster might actually be worth investigating, there are many more rail yards.

Looks like this could be fairly simple:
bcfishpass=# select distinct track_classification from whse_basemapping.gba_railway_tracks_sp ;
 track_classification
----------------------
 Main
 Crossover
 Connecting
 Spur
 Siding
 Ferry Route
 Yard
 Wye


"Artifacts are from different compiler runs" incorrect error using Windows Git Bash

= Problem =
I have been trying to use deployProxy on WIndows (10, using Git Bash) but keeping getting the above error; my colleagues using Linux and MacOS have had no such issues, using the same versions of all tools as me.
= Investigation =
We investigated the code that produces the error (reconstructSolcInputOutput in packages/plugin-truffle/src/validate.ts) and have identified the problem.
importDir.absolutePath is of the format<EMAIL_ADDRESS>but the corresponding key in sourceUnitId is<EMAIL_ADDRESS>so importedUnitId is undefined and the sourceUnit will never match.
Similarly, when dealing with local files, "C://" does not match with "\C".
In short, the error string is incorrect in this case and misleading to users about what the actual issue is.
= Workaround =
Change
const importedUnitId = sourceUnitId[importDir.absolutePath];

to
let importedUnitId = sourceUnitId[importDir.absolutePath];
if (undefined === importedUnitId) {
  const path = importDir.absolutePath.replace(/\/C\//g, 'C:/').replace(/\//g, '\\');
  importedUnitId = sourceUnitId[path];
}

Thank you so much @andyunslashed! We've had this issue reported on Windows before but had no idea about the cause.
I will try to publish a fix as soon as possible.

No problem! :)
Looking forward to seeing this fixed properly!

@andyunslashed I ended up fixing this in a different way, but it should work. Would you be able to test the prerelease version<EMAIL_ADDRESS>and let me know if it works?

It works!
On behalf of all truffle contract upgrading Windows users everywhere (probably only 3 of us!) - thank you!


Added a new MET name field to be able to switch to PuppiMET

This PR implements a new met_name field, for functions/tasks that relies on the MET information, in order to allow the switch to PuppiMET for run3 data

@dsavoiu The changes in this PR are fully in line with the last changes in the jec/jer calibrators, so we would just go ahead and merge :)


docs(README): added hyperlink

Signed-off-by: midhunbiju<EMAIL_ADDRESS>Hyperlink added to cicero logo
Issue #437
added Cicero link as hyper link to the logo in Readme.md file
Changes
modified:   README.md

Not sure I understand, the link is already lerna.js.org in master.


How to expose args/params of the InvokeEvent command?

This is yet another quality of life thing i'm pursuing. I managed to expose the parameters of the InvokeMethod command, so that it displays in the command's summary, like this:

I achieved this by replacing
return targetObject.name + "." + targetComponentText + "." + targetMethodText
with
return methodParameters[0].objValue.stringValue;
I'd like to do the same for InvokeEvent, to achieve this, for the static event:

I've tried everything in the GetSummary function of the InvokeEvent.cs script, I've exhausted pretty much all of the IntelliSense suggestions there were to the values declared in the command to no avail, I cant figure out how to get the parameters to display like that. If anyone could let me know how to do this, I'd appreciate it.

The first is statically typed, the latter is generated at runtime. You can't get the index of array without it's being executed first :)


Chucker toast is RenderFlex overflowed on long api url

Describe the bug
Chucker toast is renderflex overflowed so I couldn't click the details button
To Reproduce
Steps to reproduce the behavior:

Use long api url
See error

Expected behavior

Screenshots

Version (please complete the following information):
[✓] Flutter (Channel stable, 2.10.2, on macOS 12.3.1 21E258 darwin-arm, locale en-ID)
    • Flutter version 2.10.2 at /Users/Tara/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 097d3313d8 (4 months ago), 2022-02-18 19:33:08 -0600
    • Engine revision a83ed0e5e3
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/Tara/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

Hello, @yoseptara thank you for reporting this issue.
I will surely looking into this in the very first available slot. Till then there, is a workaround to solve this issue. You can place Chucker Flutter's button anywhere in the your app as a widget to access its main page.
SingleChildScrollView(
        padding: const EdgeInsets.all(16),
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: [
            const SizedBox(height: 16),
            ChuckerFlutter.chuckerButton,
            const SizedBox(height: 16),
            ElevatedButton(
              onPressed: get,
              child: const Text('GET'),
            ),
          ],
        ),
      ),


Using package with embedded references in go 1.16?

A question asked in our discord

I have a question, not sure if this is the place to ask. But how do you do references using the embed directive recently introduced in Go 16?
Example, I have a JSON schema that references another definition in another file, how do we do that with the package?

@Arqu so I guess essentially we can use this by loading all the reference schemas and then the referencing schema. Is that what you're saying?

In theory yes, but as said needs some work to be usable.
However, a PR got recently merged which would allow you to implement your own resolver, which should open a way for you to actually do this: https://github.com/qri-io/jsonschema/commit/36b007137385468972baae3654ba74320a372047


Writing Tests

How does one generate different settings object during testing when you use a .env file
I have file that looks like this test_main.py
from fastapi.testclient import TestClient
from main import app
from configs.config_base import settings

client = TestClient(app=app)

"""
Notice that the testing functions are normal def, not async def.
And the calls to the client are also normal calls, not using await.
This allows you to use pytest directly without complications.

Create functions with a name that starts with test_ (this is standard pytest conventions).
"""

def test_read_main():
    response = client.get("/")
    assert response.status_code == 200

def test_main_home():
    response = client.get("/hello")
    assert response.status_code == 200
    assert response.json() == {'message':'Hello world'}

Now when I push my code to github, since I have setup CI using github actions, it cant locate the TESTING config in the .env

Figured it out!

Thanks for reporting back and closing the issue 👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Editor: show width x height on the overview

Problem
There are several ARC tasks where pixels have to be counted.
Solution
Show a grid between the pixels.
Show width x height under each image.
Hide/show button for the grid.
Where should this button be placed in the UI?
Maybe a toggle grid button in the footer of the editor overview page.

Now there is a button for toggling grid. It has the keybinding G.
I have not implemented the width x height adjacent to each image.

Now there is width x height for each image in the overview.


Search bar size issues on mobile

Nav searchbar isn't consistent between the search results page and the contract and vendor pages

Screenshots plz

This is a problem with the table overflowing, I think. I think we should just WONTFIX this.


Create Qiskit (Quantum Computing)

All the Quantum Computing files are here

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Utility type to access to generic parameter?

Someone asked an interesting question on Stack Overflow:
https://stackoverflow.com/questions/52340343/how-to-to-copy-flow-type-of-properties-from-another-react-component
The problem is that a library exports something of type React.ComponentType<?>, and they want to construct a type derived from ?. The type of the generic parameter is not exported.
Is there a way to get the generic parameter type from a type instance? It seems like this functionality is missing. I'm not even sure how to best express it. When playing around, I tried this:
type PropTypeOf<T: ComponentType<X>> = X;

...but of course that does not work. One way to express could be through a utility function with a parameter index:
type PropTypeOf<T> = $GenericParam<T, 0>;

Providing type-safe generic parameter access seems really useful. Thoughts?

In this case, it sounds like you’re looking for $ElementConfig or $ElementProps.

The general feature as suggested is a bit problematic, I think. The
parameter is not a property of the type; it is a property of how the
type is constructed. Adding the ability to extract the parameter of
the type would (if it could be made to make sense at all) at the very
least break indiscernibility of identicals.
To see what I mean, consider the following code:
// @flow
type A<T> = {|+x: number, +y: T|};
type B<T> = {|+x: T, +y: string|};
type AString = A<string>;
type BNumber = B<number>;

// Witness: `AString` and `BNumber` are isomorphic.
function f(x: AString): BNumber { return x; }
function g(y: BNumber): AString { return y; }

The types AString and BNumber are exactly the same type. If you
could determine that one of them has type parameter string and the
other has type parameter number, then everything would be broken: you
would have done the same operation to two identical things and gotten
different results.
If the notion of type parameter extraction is restricted to class types,
then this might be less of a problem (I haven’t worked it out). But note
that ComponentType is not a class (it is a union), so this wouldn’t
suffice to solve your original question.

Thank you for pointing me to the right direction. My motivation was solve the specifc problem for which the $ElementConfig and $ElementProps are sufficient.
My suggestion at this point is to docs page with this types more pronounced - it is important but really easy to miss. Maybe even link it from a note in Utility Types page even though I understand that they discuss conceptually different topics.

I was excited to hear about $ElementConfig<C> and went to see how it's implemented, but it seems like it's not written in Flow, but rather OCaml. If the OCaml layer is able to somehow extract these details from an opaque type, why not Flow itself?
I see what you mean about not wanting a type to carry around the details of how it was constructed, but maybe an alternative would be a utility type to tell you what the return type of a constructor/function is. Kind of like $Call<F>, but that doesn't seem to work for class types (or maybe just doesn't work because of the union?). If we could make something like this:
type PropsTypeOf<C> = $PropertyType<$InstanceOf<C>, 'props'>

...that would open up some opportunities.

I managed to do something like this by simulating a function call using $Call. It infers the generic from the value passed in just like a function would.
// Utility type with generic `TGeneric`
type Val<TGeneric> = $ReadOnly<{|val: TGeneric|}>;

const myValObject: Val<'foo'> = {val: 'foo'};

// Function type that infers TGeneric from
type ExtractValGeneric = <TGeneric>(Val<TGeneric>) => TGeneric;

// Extracting the generic of `Val<'foo'>`
type MyValGeneric = $Call<ExtractValGeneric, typeof myValObject>; //  type is `'foo'`

('foo': MyValGeneric); // Passes
('bar': MyValGeneric); // Fails

Tryflow

We now have conditional type implemented for this purpose. Look for an announcement soon.


Remove version: Google.Chrome.Canary version 131.0.6762.0

All InstallerUrls returned 404 Not Found

https://dl.google.com/release2/chrome/acluzknw67iqqrdvxonjosldbz5q_131.0.6762.0/131.0.6762.0_chrome_installer.exe
https://dl.google.com/release2/chrome/acscwgbzzeqphp4gd4z6mytkss3q_131.0.6762.0/131.0.6762.0_chrome_installer.exe
https://dl.google.com/release2/chrome/acvj5vcqksuxkc2mwywb3jxuogja_131.0.6762.0/131.0.6762.0_chrome_installer.exe

Microsoft Reviewers: Open in CodeFlow

/azp run

@wingetbot run

[Policy] Needs-Manual-Merge

URL: https://dl.google.com/release2/chrome/acscwgbzzeqphp4gd4z6mytkss3q_131.0.6762.0/131.0.6762.0_chrome_installer.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 923)


fix: the issue with converting non-finite values to JSON string

Description

fix the issue with converting non-finite values to JSON string

General Checklist

[x] Added new tests to cover change, if needed
[x] Build succeeds using Swift Package Manager
[x] All unit tests pass
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.84%. Comparing base (d302585) to head (9e8ebab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   96.82%   96.84%   +0.02%
==========================================
  Files          35       35
  Lines        1667     1681      +14
==========================================
+ Hits         1614     1628      +14
  Misses         53       53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Specifying defaults for W___

Right now, when we write passes, we either have to use helper functions, be explicit about defining genders, types, etc. or type a lot of UNKNOWNGENDER, UnknownType, etc.
Since case classes can have defaults, I think it's a good idea to specify defaults like tpe = UnknownType to make pass writing less annoying and just forcibly run ResolveKinds, ResolveGenders, ResolveTypes, etc. after each transform.

Fixed by #460


can't install the bot

Hi, i can install the bot with pip.
i have this response when i enter pip install -r requirements.txt :
Traceback (most recent call last):   File "/usr/bin/pip", line 9, in <module>     from pip import main ImportError: cannot import name main

Hey Clem,
That's an issue not related to my bot. It appears there's some problems with one of the recent versions of pip. You're answer may rely here:
https://stackoverflow.com/questions/28210269/importerror-cannot-import-name-main-when-running-pip-version-command-in-windo
Or anywhere else. You can also try downgrading your pip version to 9.0.3, but that's up to you.


Titles, subtitles and episode titles need kerning by -0.5

Added kern of -0.5 to the title "Course episodes", section titles of and title of each episode
The spacing issue that required the kerning reported in issue #523 and #520
See title before and after adding the kerning() modifiers.

Moved to #548 to avoid Merging conflicts


Fetchmail seems to be giving errors

mailserver      | 2018-06-08T19:30:46.592175+00:00 mail fetchmail[672]:  not flushed
mailserver      | 2018-06-08T19:30:46.595508+00:00 mail postfix/smtpd[673]: 915FF130C0142: client=localhost[<IP_ADDRESS>]
mailserver      | 2018-06-08T19:30:46.636064+00:00 mail postfix/cleanup[677]: 915FF130C0142<EMAIL_ADDRESS>mailserver      | 2018-06-08T19:30:46.638689+00:00 mail postfix/cleanup[677]: 915FF130C0142: milter-reject: END-OF-MESSAGE from localhost[<IP_ADDRESS>]: 4.7.1 Ratelimit "to" exceeded<EMAIL_ADDRESS><EMAIL_ADDRESS>proto=ESMTP helo=<mail.mails.net>
mailserver      | 2018-06-08T19:30:46.638885+00:00 mail fetchmail[672]: reading message mails@able.zapto.org@<IP_ADDRESS>:43 of 117321 (2907 header octets) (2067 body octets) (log message incomplete)
mailserver      | 2018-06-08T19:30:46.638892+00:00 mail fetchmail[672]: SMTP error: 451 4.7.1 Ratelimit "to" exceeded
mailserver      | 2018-06-08T19:30:47.639025+00:00 mail fetchmail[672]:  not flushed
mailserver      | 2018-06-08T19:30:48.640959+00:00 mail postfix/smtpd[673]: 9C788130C0142: client=localhost[<IP_ADDRESS>]
mailserver      | 2018-06-08T19:30:50.642987+00:00 mail postfix/cleanup[677]: 9C788130C0142<EMAIL_ADDRESS>mailserver      | 2018-06-08T19:30:50.959700+00:00 mail postfix/cleanup[677]: 9C788130C0142: milter-reject: END-OF-MESSAGE from localhost[<IP_ADDRESS>]: 4.7.1 Ratelimit "to" exceeded<EMAIL_ADDRESS><EMAIL_ADDRESS>proto=ESMTP helo=<mail.mails.net>
mailserver      | 2018-06-08T19:30:51.959991+00:00 mail fetchmail[672]: reading message mails@able.zapto.org@<IP_ADDRESS>:44 of 117321 (1716 header octets) (69579 body octets) (log message incomplete)
mailserver      | 2018-06-08T19:30:51.959998+00:00 mail fetchmail[672]: SMTP error: 451 4.7.1 Ratelimit "to" exceeded
mailserver      | 2018-06-08T19:30:52.960170+00:00 mail fetchmail[672]:  not flushed

https://github.com/hardware/mailserver/blob/master/rootfs/etc/rspamd/local.d/ratelimit.conf#L3

thank you so much

i have try to find this file but i failed , it is not under /dockers/volumes/mail/rspamd
under here only
rspamd_dynamic
rspamd.rrd
rspamd.sock=
stats.ucl
symbols.cache
what do i do to teach this or change this settings to increase the numbers ,.

1. You can customize your ratelimit settings by creating an override ratelimit config file like this :
mailserver:
  volumes:
      - ${VOLUMES_ROOT_PATH}/rspamd/ratelimit.conf:/etc/rspamd/override.d/ratelimit.conf

Or you can also disable the ratelimiting policy :
mailserver:
  environment:
      - DISABLE_RATELIMITING=true

2.
mailserver:
  environment:
      - WHITELIST_SPAM_ADDRESSES=test<EMAIL_ADDRESS>

thank you so much ,
i know with getmail latest version we can say ALL MAIL and it would download all folders but seems with fetchmail thats not happening .. can i enter more than one in the remote folder box , i tried inbox,sent but didnt work maybe i should be writing that in different format ?

@hardware The v1.0-legacy branch used to have an internal smtpd on localhost:10025 which did bypass any spam filter (in fact, it was used for amavis to re-feed the scanned messages). Can't we just create an smtpd on 10025 again without any milter configuration so it doesn't pass rspamd?


Intermittent quote failure in bash task/variable substitution

Given:
  parameters:
    image: 'myorganization.azurecr.io/project/system'

The following sometimes fails. I can't explain it. Retrying usually works.
  steps:
  - task: Bash@3
    displayName: Set vars
    name: setVars
    inputs:
      targetType: inline
      script: |
        set -ex
        export GIT_REV=$(git rev-parse --short $(Build.SourceVersion))
        echo "##vso[task.setvariable variable=GIT_REV]$GIT_REV"
  - task: Bash@3
    displayName: Docker pull
    inputs:
      targetType: inline
      script: |
        set -ex
        docker pull ${{ parameters.image }}:dev-$(GIT_REV)

Like so:
Starting: Set vars
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/cf264bb2-704a-4b52-b55c-68922e8b64c9.sh
++ git rev-parse --short 464c86960599671cd35e0d3b87cb17baffeed09a
+ export GIT_REV=464c8696
+ GIT_REV=464c8696
Finishing: Set vars

Starting: Docker pull
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/bf0524ed-7aa5-4b38-bcfa-33ce8d1a6ac5.sh
/home/vsts/work/_temp/bf0524ed-7aa5-4b38-bcfa-33ce8d1a6ac5.sh: line 2: unexpected EOF while looking for matching `''
##[error]Bash exited with code '2'.
Finishing: Docker pull

Another data point, this also sometimes happens in another location in the script, with a different error:
    - task: Bash@3
      displayName: Push Docker images
      inputs:
        targetType: inline
        script: |
          set -ex
          docker push ${{ parameters.image }}:dev-$(GIT_REV)
          docker push ${{ parameters.image }}:$(GIT_REV)

Starting: Push Docker images
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/25f0fe4d-9876-49dc-ab65-e8c8c5b39c62.sh
+ docker push '***/project/system:dev-ee9e0f3a
docker push ***/project/system:ee9e0f3a'
invalid reference format
##[error]Bash exited with code '1'.
Finishing: Push Docker images

Notice that dangling quote at the end of the line which has seemingly appeared out of nowhere: docker push ***/project/system:ee9e0f3a'

Hi @Korijn does it happen only when you use interpolation in bash script? Do you have some example of script for which it is constantly reproducible?

does it happen only when you use interpolation in bash script?

Yes.

Do you have some example of script for which it is constantly reproducible?

I do not, which is why I came here to ask for help. It literally just happens every now and then.

@Korijn do you use cloud or on-premise product version?

Cloud!

@Korijn I tried to run it several times but it's still not reproducible - looks like something could go wrong at the stage of variable substitution. Since Bash pipeline task doesn't handle this - could you please create ticket on https://developercommunity.visualstudio.com/search?space=21 to get right eyes on it?

Sure, here it is: https://developercommunity.visualstudio.com/t/intermittent-quote-failure-in-bash-taskvariable-su/1391412

Hi @Korijn I'm closing this ticket at the moment since this issue doesn't seem to be related to the task itself - please feel free to share additional info in related developer community ticket.

Sure. I am a little sour about the whole affair though because my ticket at the other site got closed because I can't provide an example to reproduce. But my pipeline keeps exhibiting the issue every now and then.

We hit the same error today consistently.  I guess that azure pipelines really just doesn't support this feature with bash right now?
If so, the docs should be updated to reflect that.

Well what do you know, the docs do address aspects of this issue:
https://docs.microsoft.com/en-us/azure/devops/pipelines/troubleshooting/troubleshooting?view=azure-devops#variables-having--single-quote-appended

Wow! That's a great find, thanks for sharing!


import error

from lipnet.lipreading.generators import BasicGenerator
ImportError: No module named lipnet.lipreading.generators

from lipnet.lipreading.videos import Video
ImportError: No module named lipnet.lipreading.videos
I got this error

$ ./train random_split
i got below error
ImportError: No module named lipnet.lipreading.generators

$ ./train random_split
i got below error
ImportError: No module named lipnet.lipreading.generators

So, you can overcome this error by copying predict.py script to parent directory or change import statement based on the availability of "lipnet" directory which has a scope inside parent directory but not under "evaluation" directory


[ToC] Blue bar on selected item should slide up and down the rail, not fading on and off

(Please note the light gray rail disappeared due to gif compression. Not a mistake.)
Currently, the blue bar fades off and fades back on next to the new ToC item.

Ideally, the blue bar is NOT a border of the ToC item, but an entity of its own. It slides up and down the rail smoothly, stopping at specific positions to highlight a ToC item.
For better frame rate, see rendered video of the motion here: https://ibm.box.com/s/dwshp7411dwop4ipzmcya2i6u949hwq9

Related: https://github.com/carbon-design-system/ibm-dotcom-library/issues/1742

This is a duplicate of issue (#2424).  Closing this issue.


Run migration and django checks on rebased images when main updates

Fixes

Fixes #811 by @sarayourfriend
Description

This is an attempt to solve the issue as minimally as possible, just by re-running the relevant checks when migrations are updated in main for PRs that target main.
Testing Instructions

I'm not totally sure how to test this. I guess I'd have to introduce a migration in this branch and then merge one to main.
I could switch the target branch to another test branch and see how that works. I'll do that!
Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Okay. I'm going to let the CI finish running now. The target branch for this PR has been switched to a test branch and I've updated the CI to reference that branch name for the pr target events.
Next I need to introduce a migration in this branch. After that, I will push a migration to the target branch and we can see if the two Django checks run as expected.

We probably might as well run unit tests in these cases as well, eh? :thinking: I can scope it to just the API files generally? Or should we just see how it goes with migrations and add unit testing to this stuff in the future?

I wonder if there's an easy way to skip the build of the ingestion server for the pull request target event. Can we use an expression to define the matrix for that job?

The target branch is updated...

So what I've been trying to do is not possible yet: https://github.com/orgs/community/discussions/7399
The alternative approach we discussed was to have a workflow triggered by pushes to main that run checks against individual PRs with migrations. I believe this can work, it just requires us to use some "hacks" to make it possible. For example, we have no way to make the check required for a PR to be merged, so while the check is running, we would probably need to have the bot user request changes on the PR, adding a note that it is verifying migration safety. Then the bot user would dismiss its own requested changes if the checks pass. Otherwise, it would update the comment to note that the PR needs to be rebased due to a migration conflict.
@dhruvkb do you think that is workable? The script I had in mind would skip all PRs that don't introduce migrations... because it'd be cumbersome to handle multiple PRs in a single script, I think we'd want to dispatch a separate workflow per branch to run the check using the GitHub script action so that we could dispatch several at once.
What do you think? Is it worth trying?

Sorry, I accidentally hit the close button, that was not my intention. Still getting used to the trackpad.

I think for a first iteration, it might be sufficient to have the following:

a label that indicates that the PR must only be merged if up to date
a workflow that runs on push events on main and when migrations/ is changed:
the workflow goes through all open PRs, finds PRs that contain migrations and applies the label mentioned in pt. 1 and adds a comment.
a workflow that runs on each PR synchronize if that contains a migration/ change:
the workflow applies the label mentioned in pt. 1 and adds a comment.

The responsibility of keeping the PR updated falls on the maintainers but it's a good place to start and have something up quickly. Later, we can add more complex features to the workflows in pt. 2 and pt. 3.

Okay, so basically just add the notification but don't actually do any checking?

I had the script already kind of written, I'm sure it won't work right yet but if getting the checks to run isn't too big a lift, do you think it's worth doing now? Or should we really scope it down to just adding the warning? Maybe we can time box it and if I can't get the workflow dispatch check approach to work then I'll do the label and comment version you suggested and we can open another ticket later to iterate?

Status update: I will get back to this PR next week once I am through with the mini support rotation. I will do as Dhruv suggested and just add a comment notification on the PR for now and open a follow up issue to do the more involved tested guarding.


Timeout on EKHB

Hello, I have a 13 year old Daikin heat pump that I connected to the M5StackC Plus Stick with the 8 pin X10A connector. Which model should I select in the Setup.h file to get values on my mqtt?

Try this one: ALTHERMA(LT_CA_CB_11-16KW).h

Check the logs, either on Home Assistant mqtt (see Readme) or with the serial monitor of PlataformIO while still connected to your esp32.

The timeout means that it's not getting anything from the heatpump.
Double check, triple check your connections, change your wire before losing hope! :)

I have already checked connections several times and the cables have already been replaced, what else could be the reason?

Sometimes these types of connectors are a little bit loose on altherma side and it's enough to mess all communication; try to change the wires;

I got an ESP32 and installed the ESPAltherma code, but unfortunately I don't get a connection to the Home Assistant. What am I doing wrong??

I'll check later, what if I still see it this way?

When you did this screenshot, was the esp32 connected to the heatpump?

no, that was still the M5StickC

the screenshot is now with the ESP32

As a pre 2010 model your Daikin is too old most likely. It will also not work with the Daikin tool D-Checker which is only compatible with models from 2010 up.

Many bizarre things... Why is it requesting register 0?
Choose a definition file, not the default.h
If it were a protocol issue, it would give 0x15 0x54...

OK, too bad. Although I have the X10A slot--Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 30.09.22, 20:05 schrieb KalaNagHTD @.***>:
As a pre 2010 model your Daikin is too old most likely. It will also not work with the Daikin tool D-Checker which is only compatible with models from 2010 up.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

ok, where can i find the definition file?--Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 30.09.22, 20:23 schrieb Raomin @.***>:
Many bizarre things... Why is it requesting register 0? Choose a definition file, not the default.h If it were a protocol issue, it would give 0x15 0x54...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Please read the Readme it's all described in there.

I've now done everything again according to the instructions, unfortunately I still don't get any values.

You have an ESP32 M5StickC but you selected the env:esp32 which sets the communication ports to the heat pump to GPIO 16,17 instead of 36, 26. (see setup.h). Switch back to env:m5stickplus.

no I have an ESP32--Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 04.10.22, 08:56 schrieb Raomin @.***>:
You have an ESP32 M5StickC but you selected the env:esp32 which sets the communication ports to the heat pump to GPIO 16,17 instead of 36, 26. (see setup.h). Switch back to env:m5stickplus.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I have EKHBH(X)0016*** and struggling with the definition files and the lengths.

@Alexander-Wehner , what you show us in the picture is an M5StickC Plus.

If you're still using it, choose the right env.
If not, make sure your GPIO for the serial port are correct in the setup.h
@pitylee can you clarify your problem, and create another issue unless you have the same behaviour?

Hallo, dies ist mein aktuelles setup, aber ich bekomme keine Werte

Hello Alexander,
I have also an "old" EKH BX 0008 AA3V3 from 2009, so similar to you. I connected M5StickC Plus, in the meantime I get some bytes / parts of the value back. My problems could be the not perfect connection on the X10A connector, I will now ordering a better connector. When I am looking on your picture of the connector with the 8 Pins, it loks you are using the wrong pining. I used the same as the 6pin connector in the picture in the attachment, so PIN 1, 2,3  and 5 as GND. As mentioned I get some values.
Eventuell nochmal auf Deutsch, schau Dir die Belegung des Steckers nochmal an, Du verwendest Pin 1, 3, 4 und 8. Meines erachtens ist das der Grund warum Du keine Verbindung bekommst.
Ciao Dirk aus Heidelberg

Hallo Sandrohd75
Ich bin nach dieser PIN Belegung gegangen, welche PINs sollte ich mal versuchen?
Gerne auch über PN

Hallo Alexander, leider habe ich nur ein unscharfes Bild aber es geht auch ohne Bild.
Wir in den alten Daikins haben den X10 Stecker mit 8 Pins, die neuereren Daikins haben 5 Pins, hatte in der nachricht zuvor 6 Pins geschrieben, es sind aber nur 5.
Du musst an Deinem Stecker die gleiche Pinbelegung verwenden wie bei den neuen Daikins, da die Pins sehr klein sind bitte genau nachschauen und zählen
Habe Dein Bild von oben verwendet und die korrekte Belegung in Blau ergänzt, hoffe es ist lesbar:)

Please keep this discussion in English so everyone can benefit from it.
@Alexander-Wehner did you eventually solve your issue?

Dear Alexander, sorry for delayed feedback. In the meantime i get the perfect connector, so it works now,
I find out, the your connector pining is correct, so I deleted the wrong information from some days ago.

My connector:

I used the updated/newest release of ESPAltherma with the "Basic implementation of Rotex/Daikin S protocol". After some testing with the system and updating the StickC-Plus with the newest software I get the values over MQTT in my node-red.
Screenshot of my values, not su much but better than nothing:

I hope with this informations you will be able to hack your EKHB, but I can confirm that a EKH BX 0008 AA3V3 from 2009 runs with ESPAltherma.
Thanks also to Raomin and all people who worked on this project.

Hello Sandrohd75, sounds interesting, where did you get the plug from? (Link) and where did you get the firmware for the Stick C Plus?
Gladly also via PM
greeting

plug at Ama..... ,see Screenshot,

And update of the software for the stick with the M5-Burner-software, but perhaps this has no influence?

Thanks. Cable is ordered, how accurate is your PIN assignment now?
1: GND
3: TX
4:RX
8:5V

1: 5V
3: TX
4:RX
8:GND

Hi @Sandrohd75 , are you sure of the pin out? (for RX & TX)  this is not what's on ESPAltherma page:
https://raomin.github.io/ESPAltherma/doc/images/rotexX10A.png

I have the same heat pump and was not sucessful to get values from registers... Only got time out so far...

Hi Nicolasvila, I can confirm this pinout works. Please double check your wires and the connector, this also caused some troubles on my side. Perhaps in the meantime Alexander-Wehner tested also with the proposed wires and connectors.
@Alexander-Wehner: Did it works on your side now?
I am still working on the values and perhaps getting more values/data. Here some graphs from today.

Hi Nicolasvila, I can confirm this pinout works. Please double check your wires and the connector, this also caused some troubles on my side. Perhaps in the meantime Alexander-Wehner tested also with the proposed wires and connectors. @Alexander-Wehner: Did it works on your side now?
I am still working on the values and perhaps getting more values/data. Here some graphs from today.

Hi. Indeed you were right. I had several issues at the same time. Wrong board selected in my platformio.ini,  defect on the cable connection and wrong profile for my heat pump which is quite old (2009 I guess)
Like some users, I'm using an Altherma HP with a 8-pins X10 connector so I made custom 8-pins Dupont connectors in order to avoid problems.
I need to stick on PROTOCOL_S_ROTEX or PROTOCOL_S (except 0x50 registers) HP profiles
Now everything is fine and I'm receiving values from the HP. Looking good.
I'm glad you posted a screenshot of your homeassistant as I'm a bit puzzled by the temperature values I'm receiving from the HP: I was expecting the "outdoor air temperature" to be close from the real outdoor air temperature... Values seem way too high, even on your installation. What do you think?

Here are some pictures of my connections on the HP and my ESP32 (AZ-Delivery, pins 16 and 17) Does anyone know where is located the +5V on a 8-pins X10 connector? I didn't want to take a risk, so I'm using a USB power source for now.

I put below a link to the ESP32 pinout diagram:
https://cdn.shopify.com/s/files/1/1509/1638/files/ESP_-_32_NodeMCU_Developmentboard_Pinout_Diagram.jpg

That looks good! With the values of outdoor I am also not perfectly shure, but today, nobody at home, so less heating I get also simlar values like you show.

I put the power of esp32 on pin 1 (the first pin on the x10a connector). the last pin 8 is gnd.
what value you have for outside temperature?
{0x54, 4, 153, 2, -1, "Outlet Water Temp.(C)"},
{0x54, 4, 103, 2, -1, "Outdoor air temp.(C)"},
as for this definition this one is my Outlet Water Temp and not outdoor air temp.
i have a EKHBH016BA9WN indoor unit

I have an EKHBH008 unit and I still have the wrong labels from PROTOCOL_S.h

Indoor Suction Air Temp.(C)            21,22 (indoor temperature measured by the HP?)
Indoor Heat Exchanger Temp.(C)    24,02  ("cold" water coming back to the HP?)

The two other values are very close and one of them should be the hot water at the exit of the HP
I think values are not related with air temperature because they're too high. Water temperature make more sense

Outdoor air temp.(C)                       29,95
Outdoor heat exchanger temp.(C)   28,78

Hello, I had time today to try the new plug and what can I say, I get values. Thanks for the tip. Maybe someone can help me visualize the values in Home Assistant?

just follow https://github.com/raomin/ESPAltherma#integrating-with-home-assitant
it is really simple to integrate

@nicolasvila hi, have you been able to read out more values? I would still be interested in the outside temperature and the flow rate.

Hi @Alexander-Wehner , I have only  been able to read values according to the PROTOCOL_S_ROTEX definition, despite the fact my heat pump is a "Daikin Altherma" and there is no reference to Rotex anywhere
For now that's fine but I suppose more values could be retrieved (for instance all the variables from PROTOCOL_S return something but mapping seems to be wrong or meaningless)  I would also like to read outside temperature.
I haven't tested yet the application DChecker to see if more values are readable but it's in my TODO list.  I tried to unzip the app and to check configuration files but there's no plain text files, only binary files  (.ldd if I'm corect)

hi, thank you maybe you will get the value of power consumption too

@nicolasvila, hast du schon Zeit gefunden mehr Werte auslesen zu können?

@Alexander-Wehner No I didn't to try to read more values than the one you are using. My Altherma unit is quite old and I guess it has less sensors than more recent ones


chore: add docs for tera features for the template documenation

Closes #2048
Please raises comments for the document structure and general documentation improvements.
This should be merged after closing #2049.

Fixed!


fix: throw invalid L error correctly

We could add a small test, that makes sure this error is thrown when this case actually appears.

We could add a small test, that makes sure this error is thrown when this case actually appears.

Ok done. Unfortunately the design of the IntensityBuilder makes the testing quite difficult. Hence the rather abstruse test. Improving that design can be put on our Todo list.

Ok done. Unfortunately the design of the IntensityBuilder makes the testing quite difficult. Hence the rather abstruse test. Improving that design can be put on our Todo list.


remove namespace for cluster-wide resources.

Remove namespace for cluster-wide resources:

ClusterRole
ClusterRoleBinding

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: morvencao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
Assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: morvencao, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513, morvencao, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513,sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2238ade613511384a1da3b46d52905bdcc81600a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add iPhone 14 Pro / 6.1" display type

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Resolves #21065 -- add support for iPhone 14 Pro 6.1" display type.
As per the documentation https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications
The 6.1 Display type is now for the iPhone 14 Pro. It appears that this display size was for the iPhone XR which now must be uploaded as a 6.5" display size.
Description

Testing Steps

Related to issue https://github.com/fastlane/fastlane/issues/20950 (and PR https://github.com/fastlane/fastlane/pull/20951) for iPhone 14


it wont load

the Iframe isn't working, try to make the Iframe embedded into a webpage and then change the href to the webpage link.

the Iframe isn't working, try to make the Iframe embedded into a webpage and then change the href to the webpage link.

@XxFluffyAsherxX Umm I haven't done it yet, how can you find this repo so fast 🤔


chore(main): release 1.4.0

:robot: I have created a release beep boop
1.4.0 (2023-09-23)
Features

support scrollbar (62aa411)

Bug Fixes

Chinese typo [skip ci] (b63ea70)

Code Refactoring

code refactor with idea [skip CI] (e82e822)
refactor for code regulation with pycharm (38e0306)

CI

don't run debug when changelog modified [skip ci] (32ea7e7)
only run actions when release published to avoid running three times [skip ci] (aaded38)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/itsHenry35/ledu/releases/tag/v1.4.0 :sunflower:


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/384 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 947ac61:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Performance affected when adding vee-validate as a plugin

Versions:

VueJs: 2.5.13
Vee-Validate: 2.0.5
NuxtJs: 1.4.0

Description:
I'm using docker for my Nuxt app
When adding vee-validate as a plugin  and using Apache HTTP server benchmarking tool with the instruction ab -n 200 -c 5 https://localhost:3000/health-check to simulate some requests
the responses are taking longer each time.
Maybe is a bad usage of the library but this health-check page is also dummy
Comparing my container with and without the vee-validate plugin I get these stats.

NAME
CPU %
MEM USAGE / LIMIT
MEM %
NET I/O
BLOCK I/O
PIDS

w/o vee-validate

frontend
0.06%
170.3MiB / 1.952GiB
8.52%
1.26MB / 129MB
88.8MB / 0B
36

with vee-validate

frontend
0.10%
175.8MiB / 1.952GiB
8.79%
1.95MB / 194MB
3.82MB / 0B
36

I'm not expert on this kind of test but is affecting seriously the performance of my app, I'm not sure where to look from here, numbers seems equal but the responses times have big differences.
This table shows the numbers after three attempts of the previous ab instruction
Percentage of the requests served within a certain time (ms)
w/o vee-validate vs with vee-validate

%
ms

%
ms

50%
195

50%
3017

66%
210

66%
3298

75%
222

75%
3776

80%
230

80%
3909

90%
253

90%
4074

95%
268

95%
4194

98%
280

98%
4243

99%
283

99%
4279

100%
284 (longest request)

100%
4368 (longest request)

Any suggestion?
Hope this information is usefull

This looks like a possible memory leak, reminds me of #238, I will try to investigate and report back.

I'm interested on how you are adding vee-validate as a plugin, the issue could be caused by the injections of validator, errors, and fields injections in all components.
Usually I use it with nuxt and setting inject: false in the config. Since not all components are going to have validation logic.

// In your plugin.js
Vue.use(VeeValidate, {
  inject: false
});

// in a page where it needs a validator instance:

export default {
  $_veeValidate: {
    validator: 'new' // request a new validator instance
  }
};

can you test these adjustments and report back if you can? thanks!

Hi @logaretm
I've made the changes you suggested and seems to work really good, making the same stress tests the responses keeps low in pages that are not using "vee-validate" which was my intention, I'll keep you inform about this if I find anything else.
I see you have this approach documenten in the docs 👍
Thanks for the good work,
Appreciate your help.

No problem, I guess there should be a warning section for the nuxt based apps with veevalidate


Add semi option

Closes #72

You also may want to add

// Indent lines with tabs
useTabs: false,

This is on master and should be in next release

Confirm useTabs in 1.0

add useTabs option
https://github.com/esbenp/prettier-vscode/pull/77/files


Z80 opcodes with 11 cycles instead of 12

I hope this won't be another false positive.
Some 0xCB prefixed opcodes show 11 cycles instead of 12 in the tests.
For example, 0xCB 0x46.
Thanks

Just pushed a new version with this fixed for the BIT x, (HL) and related opcodes, thanks! Let me know if you find any others

Finally not a false positive! Thanks!


Simple avail type

Adds new api for QueryEntitlement which lists an deduplicated list of target : role pairs.
The original QueryAvailabilties has been left in and is used for cli queries. See here for updates to cli
https://github.com/common-fate/cli/pull/52

We should also look to deprecate the other Availabilities API eventually

We should standardise on naming for list APIs seems we are using both Queryx and Listx interchangeably. Is there a standard practice we should adopt here for grpc?

There isn't a standard AFAIK - agreed though we should ourselves standardise on one or the other. I have been using QueryX for endpoints that could take filters as parameters and ListX for endpoints that don't, but this may be confusing in the long term


Automated cherry pick of #11930

Cherry pick of #11930 on release-7.8.
/cc  @AshishDhama
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 26493284f1622b3eb16360a1fd46d9e4e10685ca


[RFC] Deprecate the unfreeze_milestones finetuning strategy?

Motivation
The unfreeze_milestones finetuning strategy is confusing:

how is the layer number interpretted? Does this include e.g. batch norm and non-linearity layers? Not documented
what's the use case? Not aware of any time this would be recommended (also not documented)

Alternatives
At least document the answers to the above questions if there are any.

Hello @ethanwharris ,
I think UnfreezeMilestines strategy is somewhat close to the Gradual Unfreezing idea from this paper Universal Language Model Fine-tuning for Text Classification by Jeremy Howard and Sebastian Ruder.
We might need to change how it works of add more arguments for users to customize it and it definitely needs more documentation.
And we can also change the name to GradualUnfreezing if that is okay.

Hey @karthikrangasai, yes that could work. If we re-implement that then we can cite their paper in the code / docs and so people can read about why they may want to do it 😃

Great. Sounds good.
I will try to get some work done on this then.

Hi, my 2 cents on this:

As a part of this issue, let's only document this further as @ethanwharris rightly pointed out. We definitely need to show the usage and explain a little about how it works. If we are sure that there is an exact reference that exists, would be great to cite it.
I would prefer not to modify/add/edit the current strategy, as long as it works and does the job (on unfreezing layers). But if there is some motivation, please share any reference implementation (if any library already implements it) here, and we can (very shortly) take a look and go ahead if all sounds good.

Hope it sounds good! :)

@ethanwharris lets do it... :otter: