fb tools

@rultor release, tag is 0.0.11

@rultor release, tag is 0.0.11

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.11

@yegor256 Oops, I failed. You can see the full log here (spent 8min)
Installing simplecov_json_formatter 0.1.4
Fetching simplecov 0.22.0
Installing simplecov 0.22.0
Fetching simplecov-cobertura 2.1.0
Installing simplecov-cobertura 2.1.0
Fetching yard 0.9.36
Installing yard 0.9.36
Bundle complete! 10 Gemfile dependencies, 81 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Coverage report generated for Unit Tests to /home/r/repo/coverage/coverage.xml. 0 / 0 LOC (100.00%) covered
Run options: --seed 44097

# Running:

/home/r/repo/lib/judges/fb/once.rb:25: warning: global variable `$judge' not initialized
\u001b[31mE\u001b[0m

\u001b[31mError:
TestOnce#test_touch_once:
RuntimeError: String literal can't be empty
    /usr/local/rvm/gems/ruby-3.2.2/gems/factbase-0.0.11/lib/factbase/syntax.rb:113:in `block in to_tokens'
    /usr/local/rvm/gems/ruby-3.2.2/gems/factbase-0.0.11/lib/factbase/syntax.rb:109:in `map'
    /usr/local/rvm/gems/ruby-3.2.2/gems/factbase-0.0.11/lib/factbase/syntax.rb:109:in `to_tokens'
    /usr/local/rvm/gems/ruby-3.2.2/gems/factbase-0.0.11/lib/factbase/syntax.rb:39:in `to_term'
    /usr/local/rvm/gems/ruby-3.2.2/gems/factbase-0.0.11/lib/factbase/query.rb:41:in `each'
    lib/judges/fb/once.rb:55:in `each'
    test/fb/test_once.rb:37:in `test_touch_once'
\u001b[0m

bin/rails test /home/r/repo/test/fb/test_once.rb:34

\u001b[32m.\u001b[0mTesting judges in /tmp/d20240512-1520-woep8q...
Testing foo.rb in /tmp/d20240512-1520-woep8q...
Pack #0 found in /tmp/d20240512-1520-woep8q
1 judges tested
\u001b[32m.\u001b[0mTesting judges in /tmp/d20240512-1520-3a5sxv...
Testing foo.rb in /tmp/d20240512-1520-3a5sxv...
Pack #0 found in /tmp/d20240512-1520-3a5sxv
1 judges tested
\u001b[32m.\u001b[0mTesting judges in /tmp/d20240512-1520-d74hvd...
Testing foo.rb in /tmp/d20240512-1520-d74hvd...
\u001b[32m.\u001b[0mThere is no Factbase to import from /tmp/d20240512-1520-53cx5f/base.fb
Pack #0 found in /tmp/d20240512-1520-53cx5f
1 judges processed
Factbase exported to /tmp/d20240512-1520-53cx5f/base.fb (30 bytes)
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0mFactbase imported from /tmp/d20240512-1520-xqn7hi/base.fb (18 bytes)
Factbase printed to /tmp/d20240512-1520-xqn7hi/base.yaml (19 bytes)
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

Finished in 0.031008s, 483.7441 runs/s, 483.7441 assertions/s.
15 runs, 15 assertions, 0 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1)
/usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container ccdbc2067917c2bb760680832dd04011f3cb855dacefb0809655ee5f97fa2d96 is dead
Sun May 12 23:50:52 UTC 2024

@rultor release, tag is 0.0.11

@rultor release, tag is 0.0.11

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.11

@yegor256 Done! FYI, the full log is here (took me 8min)


Increasing length of delimiter

Hello Ashish,
I'm using the upstream dwmblocks build by torrinfail. However, it only features the delimiter to be a single ASCII character (C char datatype). I'd be glad if you could help me point out how I could increase this delimiter size.

The ability to have multiple characters as delimiter is already there in torrinfail's dwmblocks (it was added back recently).

Thanks a lot! I didn't know that.


Fix active param count

Description
Calulates active params for token_choice and expert_choice. for all other options the assumption is: active == total.
There is also a name change in args. these args are there for logging purposes, and I think that their names were confusing.
Last thing: printing of parameter count, active count and token to active ratio has been abstracted from cc_train to a function in logger.py
Checklist

[x] Is this PR focused on a single feature without the possibility of being divided into smaller PRs?
[x] Are all variables set with logical defaults that are backward compatible?
[ ] I attached link to neptune if it was necessary
[x] Have you successfully executed the linter and tests?
[x] Are all functions concise and don't require splitting?
[x] Is there documentation for arguments and complex logic?
[x] Are there no temporary solutions in the code? Should a task be added to Trello to refine the code?
[x] Are all functions placed in appropriate files?
[x] Is the PR name meaningful and descriptive?
[x] Is PR description provided, or unnecessary?

Other questions:

[ ] If I made changes to the requirements or anything related to the Singularity image I did generate new image and upload a new image to the clusters
[ ] If this change is significant enough I notified all individuals working with this repository (@channel in slack channel)
[ ] If there is a need for a second reviewer I requested additional review

Reviewer's checklist:

[ ] Does the Neptune link work and does it actually compare the situation before and after the PR?
[ ] Do I understand the code?
[ ] Do I think another reviewer is not needed or I commented that this PR need another reviewer?

neptune tests in progress


magisk: cannot find patch file

I got this error when trying to patch magisk boot all is setup but seems the path has a problem if I change the code with chatgpt it runs forever.
[PATCHER]  ... ended with errorcode 2/0
patch: **** Can't open patch file /home/clawdev/A9//home/clawdev/A9/vendor/extendrom/config/magisk/patches/0001-build_make_tools_releasetools_common.patch : No such file or directory
[PATCHER]  FATAL ERROR occured while applying >0001-build_make_tools_releasetools_common.patch<!!!

bash stack trace (first occurence is likely where you should look at):

ERROR: last command ended with status >3< at line >427<
[MAGISK] Injecting Magisk patcher ended with 3

Thanks for your report. In order to help share the whole(!) output when executing
vendor/extendrom/er.sh

Ran into the same problem today. Fixed it by replacing line 70 in vendor/extendrom/tools/apply_patches.sh:
Replace P=$(echo "$p" | sed 's#^#-i '$(pwd)'/#g;s/:project#/ -d /g') with P=$(echo "$p" | sed 's#^#-i ''/#g;s/:project#/ -d /g')

So build went fine with the replacement line till near the end (99%).. but failed before building the update img and I took flashallfastboot to try and nothing about magisk was done. :/
Here are the logs I got:
building image from target_files RECOVERY...
building image from target_files BOOT...
Traceback (most recent call last):
File "build/make/tools/releasetools/make_recovery_patch", line 55, in
main(sys.argv[1:])
File "build/make/tools/releasetools/make_recovery_patch", line 42, in main
input_dir, "BOOT")
File "/home/clawdev/A9/build/make/tools/releasetools/common.py", line 577, in GetBootableImage
info_dict, has_ramdisk, two_step_image)
File "/home/clawdev/A9/build/make/tools/releasetools/common.py", line 516, in _BuildBootableImage
RunAndCheckOutput(mpatcher, verbose=True, env={'system_root_image': info_dict.get("system_root_image", "false")})
NameError: global name 'RunAndCheckOutput' is not defined
[ 99% 99683/99685] build out/target/product/a95xf1/a95xf1-fastboot-flashall-20231023.zip
install out/target/product/a95xf1/a95xf1-fastboot-flashall-20231023.zip
adding: boot.img (deflated 1%)
adding: dt.img (deflated 74%)
adding: recovery.img (deflated 1%)
adding: android-info.txt (deflated 7%)
adding: system.img (deflated 56%)
adding: vendor.img (deflated 60%)
adding: product.img (deflated 18%)
adding: dtbo.img (deflated 58%)
adding: vbmeta.img (deflated 99%)
adding: android-info.txt (deflated 7%)
adding: boot.img (deflated 1%)
adding: bootloader.img (deflated 2%)
adding: dt.img (deflated 74%)
adding: dtbo.img (deflated 58%)
adding: flash-all.bat (deflated 57%)
adding: flash-all.sh (deflated 59%)
adding: logo.img (deflated 93%)
adding: odm.img (deflated 78%)
adding: product.img (deflated 18%)
adding: recovery.img (deflated 1%)
adding: system.img (deflated 56%)
adding: vbmeta.img (deflated 99%)
adding: vendor.img (deflated 60%)
ninja: build stopped: subcommand failed.
08:30:23 ninja failed with: exit status 1

************************************************** STARTING EXTENDROM **************************************************
extendrom version: HEAD 42177f6
ENABLE_EXTENDROM: true
EXTENDROM_PREROOT_BOOT: true
EXTENDROM_PACKAGES: Magisk
EOS_EDITION:
EXTENDROM_SIGNING_PATCHES:
EXTENDROM_SIGNATURE_SPOOFING:
EXTENDROM_SIGSPOOF_RESET:
EXTENDROM_SIGSPOOF_FORCE_PDIR:
EXTENDROM_TARGET_VERSION: 9
EXTENDROM_TARGET_PRODUCT: a95xf1
hardware/amlogic/wifi/configs/wifi.mk:43: warning: WIFI_MOUDLE is multiwifi
hardware/amlogic/wifi/configs/wifi.mk:47: warning: WIFI_BUILD_IN is false
hardware/amlogic/bluetooth/configs/bluetooth.mk:20: warning: BLUETOOTH_MODULE is BCMBT
hardware/amlogic/bluetooth/configs/bluetooth.mk:24: warning: BLUETOOTH_INF is not set
SRC_TOP: /home/clawdev/A9/
hardware/amlogic/wifi/configs/wifi.mk:43: warning: WIFI_MOUDLE is multiwifi
hardware/amlogic/wifi/configs/wifi.mk:47: warning: WIFI_BUILD_IN is false
hardware/amlogic/bluetooth/configs/bluetooth.mk:20: warning: BLUETOOTH_MODULE is BCMBT
hardware/amlogic/bluetooth/configs/bluetooth.mk:24: warning: BLUETOOTH_INF is not set
EXTENDROM_PRODUCT_DEVICE=
EXTENDROM_BOOT_DEBUG=
EXTENDROM_DEBUG_PATH=/data/vendor_de (will be suffixed with /boot_debug)
EXTENDROM_DEBUG_PATH_SIZE_FULL=5000 KB
EXTENDROM_DEBUG_PATH_SIZE_CRASH=500 KB
EXTENDROM_DEBUG_PATH_SIZE_KERNEL=500 KB
EXTENDROM_DEBUG_PATH_SIZE_SELINUX=500 KB
/home/clawdev/A9/out/host/linux-x86/bin/aapt
[F_GET_GPG_KEYS] ... skipping already imported gpg pub key (7A029E54DD5DCE7A)
[F_GET_GPG_KEYS] ... skipping already imported gpg pub key (22F796D6E62E6625A0BCEFEA7F979A66F3E08422)
[get_packages] ... skipping F-Droid as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping F-Droid_v1.16.3 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping F-DroidPrivilegedExtension_pb as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping AuroraStore as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping AuroraServices as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping AdAway as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping DNS66 as not requested by EXTENDROM_PACKAGES
[download_package] ... downloading package: Magisk.v26.3.apk
[get_packages] ... target package: vendor/extendrom/prebuilt/Magisk.apk
[get_packages] ... skipping SignMagisk as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v26.2 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v26.2 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v26.1 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v26.1 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v25.2 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v25.2 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v24.3 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v24.3 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v23.0 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v23.0 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Magisk_v22.1 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SignMagisk_v22.1 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Phonesky as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Phonesky_AXP-OS as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping MicrogGmsCore as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping MicrogGmsCore_GH as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping MicrogGmsCore_unified-latest as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping GsfProxy as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping GsfProxy_GH as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping FakeStore as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping FakeStore_GH as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping NominatimBackend as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping MozillaNlpBackend as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping DroidGuard as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping OpenCamera as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping opencamera_j5_latest as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping SimpleLauncher as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Omega as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping NeoLauncher-latest as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping NeoLauncher as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Lawnchair-stable as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Lawnchair-latest as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping OpenLauncher as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping BlissLauncher as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping K9-Mail-latest as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping FairEmail as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Fennec as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping QKSMS as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping FFUpdater as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping ICSx5 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping DAVx5 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping NextCloud as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Cromite_arm64 as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping Etar as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping OpenTasks as not requested by EXTENDROM_PACKAGES
[get_packages] ... skipping NextCloudNotes as not requested by EXTENDROM_PACKAGES
[MAGISK] preparing the root process as requested

WARNING: EXTENDROM sources are already patched!
If you want to force patching remove the indicator file:
./vendor/extendrom/config/magisk/patches/EXTENDROM_PATCHER_DONE

[MAGISK] Injecting Magisk patcher ended with 0
[MAGISK] ... Magisk found!
[MAGISK] ... MAGISK_TARGET_ARCH specified as arm64
[MAGISK] preparing root finished
[main] Writing makefiles (if needed)
[F_WRITE_MAKEFILE] ... skipping AuroraServices as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping GsfProxy_GH as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Lawnchair-latest as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Lawnchair-stable as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Magisk_v22.1 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v22.1 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk_v23.0 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v23.0 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk_v24.3 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v24.3 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk_v25.2 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v25.2 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk_v26.1 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v26.1 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk_v26.2 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk_v26.2 (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping Magisk (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping SignMagisk (Magisk is not allowed to be a system app)
[F_WRITE_MAKEFILE] ... skipping NeoLauncher as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Omega as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Phonesky as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Phonesky_AXP-OS as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Cromite_arm64 as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping DAVx5 as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping ICSx5 as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping FakeStore as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping FakeStore_GH as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping AuroraStore as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping OpenLauncher as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping K9-Mail-latest as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping MicrogGmsCore_unified-latest as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping MicrogGmsCore_GH as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping MicrogGmsCore as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping GsfProxy as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping QKSMS as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping NextCloud as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping NeoLauncher-latest as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping SimpleLauncher as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping FFUpdater as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping FairEmail as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping BlissLauncher as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping NextCloudNotes as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping OpenCamera as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping opencamera_j5_latest as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping AdAway as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping OpenTasks as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping F-DroidPrivilegedExtension_pb as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping F-Droid_v1.16.3 as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping F-Droid as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping DNS66 as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping DroidGuard as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping MozillaNlpBackend as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping NominatimBackend as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Fennec as not requested by EXTENDROM_PACKAGES
[F_WRITE_MAKEFILE] ... skipping Etar as not requested by EXTENDROM_PACKAGES
here is the output from er.sh too
************************************************** EXTENDROM FINISHED **************************************************

@ClawOfDead your issue is related to
NameError: global name 'RunAndCheckOutput' is not defined
which means I need to adjust the patch for Android 9 it seems. Will let you know when you can test again


contrib: Fix issues encountered with ansible playbooks

This commit fixes the issues encountered with the ansible playbooks.
It also changes the checks to fix some idempotency issues and increases
overall deployment setup time.
The errors are now handled properly and a message is displayed to
the user if something goes wrong and what it should do.
The sleeps within the playbooks waiting for a task to be complete have
also been replaced. It now checks the expected behaviour after the task.
Example: creating docker network when connection drops for a short period,
instead of sleeping for a given amount of time it waits for the WinRM
connection to come back.
Replaced the infracontainer on Windows with a nanoserver image which
should increase the speed of the deployment.
Signed-off-by: Alin Balutoiu<EMAIL_ADDRESS>

I'll give it a go later on.
Do you mind changing the infra container to use nanoserver so it speeds up deployment?

@alinbalutoiu indeed that is somewhat useful for testing, but not for deployment.
It will also make the footprint of all the pods much smaller.
We could also change the IIS image with the listening server that runs on nanoserver. I remember we done this at some point.

I will update that alongside with the Windows 1803 support. Those changes are needed to address the issues that others have encountered while using the playbooks.

Sounds good.

@aserdean the infra container is now a nanoserver container. Also the IIS container from the test yaml has been replaced with a nanoserver with a simple http server.
Could you give it a try to see how it works? Also thanks to the others that tried it out for reporting the issues and giving feedback.

Update: Added some additional flags to the kubelet service which should fix the pods getting stuck when deleting them on Windows.

Thanks for incorporating all the requests!
I deployed it today and seems okay. We need to address documentation and some additional checks once this PR gets in.
Acked-by: Alin Gabriel Serdean<EMAIL_ADDRESS>(@rajatchopra mind taking a look)

Alin helped on testing it, also a few other guys from the sig-community helped as well. The changes incorporate the issues that they've had and the feedback on improving them.


Confuguration Context not applied based on nested Tenant Groups

Environment

Nautobot version (Docker tag too if applicable): v2.0.4b1
Python version: 3.11
Database platform, version: PG15
Middleware(s): N/A

Steps to Reproduce

Create nested Tenant Groups with test configuration context
Put an object (device) as a Tenant which is a member of a nested Tenant Group
Open the Config Context tab, observe the contents of Rendered Context and Source Contexts widget

Expected Behavior
To see the configuration context applied in Rendered Context and also Source Contexts as a source for context

Observed Behavior
The configuration context is not applied
Notes

Similar to #3432

Thank you @MeganerdDev I had this on the list for this week, but chaos took over. I appreciate it.

@MeganerdDev Does this work for the immediate TenantGroup, just not the ancestors?

@gsnider2195 it works for immediate tenant groups, only nested are the problem

May be a consequence of the switch from django-mptt to django-tree-queries for the TenantGroup model - sounds similar to #4388, which was fixed for Locations by #4417.


Stuck waiting for preLaunchTask return

in launch.json, its OK when use
{
  "description": "Connect to valgrind",
  "text": "${command:valgrind-task-integration.valgrindGdbArg}",
  "ignoreFailures": true
},

but when i try with costom task such as
...
"preLaunchTask": "valgrind-debug: custom",
...
{
  "description": "Connect to valgrind",
  "text": "target remote | vgdb",
  "ignoreFailures": true
},

with task
		{
			"label": "valgrind-debug: custom",
			"type": "valgrind-debug",
			"target": "${command:cmake.launchTargetPath}",
			"valgrind": {
			  "args": ["--tool=memcheck","--vgdb-error=0"]
			},
		}

vscode is stuck and waiting preLaunchTask return......
env：Win11, VS code 1.85.1, runing in Ubuntu(WSL 2)

Can you share your valgrind output? Most likely this is an issue with the included problem matcher that expects a line in the format:
^==\\d+== Using Valgrind-[\\d\\.]+

e.g. ==5124== Using Valgrind-3.13.0 and LibVEX, rerun with -h for copyright info

I haven't used valgrind or this extension for wuite a while, so it's possible that has changed

Starting valgrind...
==1073== Callgrind, a call-graph generating cache profiler
==1073== Copyright (C) 2002-2017, and GNU GPL'd, by Josef Weidendorfer et al.
==1073== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==1073== Command: /home/wei/code/river/build/src/test/main
==1073==

==1073== For interactive control, run 'callgrind_control -h'.

==1073== (action at startup) vgdb me ...
==1073==
==1073== TO DEBUG THIS PROCESS USING GDB: start GDB like this
==1073==   /path/to/gdb /home/wei/code/river/build/src/test/main
==1073== and then give GDB the following command
==1073==   target remote | /usr/bin/vgdb --pid=1073
==1073== --pid is optional if only one valgrind process is running
==1073==

I add "isBackground": true, in task define, and it go on. but have a new problem, connect to valgrind without pid need there are only one valgrind process. but pkill cannot batch kill valgrind process, you must use kill one by one......

my bad, pkill valgrind must used with -f.


Version 3 installation instructions?

Is there an archived version of the installation instructions (from source) for mmt v3?
I upgraded to Ubuntu 18.04/mmt 4 but then I found that mmt 4 just doesn't run on my GPU - GTX 1060. It keeps skipping batches during training due to lack of memory.
Now I'm going to revert to 16.04 and reinstall version 3, which works fine on this hardware, but I need the detailed instructions.
Thanks for any pointers.

@gdaine
You can get the source code of version 3.3 (*v3.3) from here
https://github.com/modernmt/modernmt/tree/v3.3
All older versions are also available.

You have also the possibility to continue working with v4 by reducing the batch size to fit in the memory.
To do that modify the default parameter max-tokens through the command mmt create, running something like
mmt create en it DATA --max-tokens 2048

or any other value.

MMT3 may be installed on Ubuntu 18.04: see #482

Thanks. I didn't realise the documentation was included in the code.
I'll try v4 again with reduced batch size and see what happens.
Closing this issue.


[Coverity CID :203439]Memory - corruptions in /tests/kernel/mem_protect/protection/src/main.c

Static code scan issues seen in File: /tests/kernel/mem_protect/protection/src/main.c
Category: Memory - corruptions
Function: write_text
Component: Tests
CID: 203439
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Same as the other three I just looked at.  False positive.  Coverity doesn't like memory reads or writes to symbols in the .text section (it thinks their sizes are zero), but that is exactly the behavior we are testing.

Assign to @aasthagr as I don't know how to manage recording this as a false positive in the tool


adjust-spec-pages: be more precise in selecting front matter

Closes #2079
Preview: https://deploy-preview-2109--opentelemetry.netlify.app/docs/reference/specification/metrics/semantic_conventions/hardware-metrics/
Note that I'll be submitting a followup change to the spec since front matter (linkTitle) is missing for the new Hardware page.

/cc @bertysentry

Very nice!


Show toolbar icon badge if token is invalid

Description
It would be nice to get a notification badge if the GitHub token has expired.
For example, my 1Password extension here:

I use Safari, but this feature request would apply to other browsers.
If the token expires, some features stop working, but most continue to work.
One specific feature I use wasn't working. I thought something was broken in the extension and was looking through issues and commits to figure it out. Turns out my token expired.
To be fair, when I popped open the devtools console, I saw that it said my token expired. That was super helpful and I should have done that earlier. 😊 Of course, there's also the email from GitHub saying it expired.
Example URLs
N/A

Fair. Thanks for the response and I shoulda caught issue that in the search.


Add support for Cisco USB console cables

Add support for up to 8 Cisco USB console cables

Implemented
First cable > TCP port 2001
Second cable > TCP port 2002
...
Eight cable > TCP port 2008


MPRester

Hello,
I am currently learning how to use Vise by following the tutorial at https://kumagai-group.github.io/vise/.
It seems that the MPRester module has changed location in recent pymatgen versions, leading to an error.
vise gp -m mp-2857

  File "[...]/lib/python3.10/site-packages/vise/cli/main_functions.py", line 9, in <module>
    from mp_api.client import MPRester
ModuleNotFoundError: No module named 'mp_api'

This output is from pytmatgen 2024.11.13.
Replacing this import statement by from pymatgen.ext.matproj import MPRester may partially solve this error. However, simply replacing it yields another error:
   INFO: -- Settings from vise.yaml:
   INFO:
Traceback (most recent call last):
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/pymatgen/ext/matproj.py", line 131, in request
    all_data.extend(data["data"])
KeyError: 'data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "[...]/anaconda3/envs/vise/bin/vise", line 8, in <module>
    sys.exit(main())
  File "[...]/anaconda3/envs/vise/lib/python3.10/site-packages/vise/cli/main.py", line 316, in main
    args.func(args)
  File "[...]/anaconda3/envs/vise/lib/python3.10/site-packages/vise/cli/main_functions.py", line 124, in get_poscar_from_mp
    query = MPRester().summary.search(material_ids=[args.mpid],
  File "[...]/anaconda3/envs/vise/lib/python3.10/site-packages/pymatgen/ext/matproj.py", line 157, in summary_search
    return self.request(f"materials/summary/?{get}", payload=criteria)
  File "[...]/anaconda3/envs/vise/lib/python3.10/site-packages/pymatgen/ext/matproj.py", line 137, in request
    raise MPRestError(msg)
pymatgen.ext.matproj.MPRestError: 'data'. Content: b'{"detail":"Request contains query parameters which cannot be used: fields"}'

This may be a very basic question, although I could not figure out how to proceed further so far.
I would appreciate if someone could tell me how to solve this issue.
Thank you very much.

Hi,
We might need to make corrections to adapt the revised mpi of pymatgen.
Please wait for a while.

I don't have the same error.
Could you please install mp-api with the following command?
pip install mp-api

Thank you for your reply.
I have install mp-api via pip install mp-api. While the original error has disappeared, another one occured.
Is there any limitation on the version mp-api compatible with vise?
vise gp -m mp-2857
   INFO: -- Settings from vise.yaml:
   INFO:
Traceback (most recent call last):
  File "/home/augustin/anaconda3/envs/vise/bin/vise", line 8, in <module>
    sys.exit(main())
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/vise/cli/main.py", line 316, in main
    args.func(args)
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/vise/cli/main_functions.py", line 122, in get_poscar_from_mp
    s = MPRester().get_structure_by_material_id(args.mpid)
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/mprester.py", line 464, in get_structure_by_material_id
    structure_data = self.materials.get_structure_by_material_id(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/routes/materials/materials.py", line 124, in get_structure_by_material_id
    response = self.search(material_ids=material_id, fields=[field])
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/routes/materials/materials.py", line 245, in search
    return super()._search(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 1185, in _search
    return self._get_all_documents(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 1258, in _get_all_documents
    results = self._query_resource(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 569, in _query_resource
    data = self._submit_requests(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 716, in _submit_requests
    initial_data_tuples = self._multi_thread(
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 938, in _multi_thread
    data, subtotal = future.result()
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/concurrent/futures/_base.py", line 451, in result
    return self.__get_result()
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
    raise self._exception
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 1010, in _submit_request_and_process
    data["data"] = self._convert_to_model(data["data"])
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 1049, in _convert_to_model
    data_model, set_fields, _ = self._generate_returned_model(raw_doc_list[0])
  File "/home/augustin/anaconda3/envs/vise/lib/python3.10/site-packages/mp_api/client/core/client.py", line 1075, in _generate_returned_model
    data_model.model_fields = {
AttributeError: can't set attribute 'model_fields'

If the following script doesn't work, the issue is not related to vise.
You should ask the developer of mp-api.
from mp_api.client import MPRester
structure = MPRester().get_structure_by_material_id("mp-2857")


Fix sidecar termination on migration: Introduces hooks v1alpha3 with Shutdown

What this PR does / why we need it:
After migration, the sidecar is not being properly terminated. It does not receive a SIGTERM and it keeps running leaving a dangling Pod with NotReady state. The issue is well documented in https://github.com/kubevirt/kubevirt/issues/9838
This PR implements a Shutdown() mechanism to allow virt-launcher to inform the sidecar to exit.
Which issue(s) this PR fixes
Fixes #8395
Special notes for your reviewer:
Release note:

Add v1alpha3 for hooks
Fix migration when using sidecars

/retest-required

@prnaraya thanks for the review! jfyi, I did not forget about this PR but I thought I should first finish https://github.com/kubevirt/kubevirt/pull/9231 and https://github.com/kubevirt/kubevirt/pull/10320. They are not a hard requirement for this PR, just related and slightly time consuming ;)
I hope to get back to this next week!

/cc @dharmit, in case you want to review.
If I did not misunderstood, this proposal of Shutdown() method would eventually not be needed anymore, with a proper fix in kubernetes.  See this native sidecar containers, more specifically this quote:

Pod termination continues to only depend on the main containers. An init container with a restartPolicy of Always (named a sidecar) won't prevent the pod from terminating after the main containers exit

As this is alpha, it might take some time so I think this PR is still useful.

FWIW, we are running this PR in production.
I also think that once k8s 1.28 is required by kubevirt this feature could be dropped, but until then, it's massively helpful.

@victortoso do you plan to add functional tests in this PR or a separate one?

What I really wanted to do is a migration test with sidecar that fails without this PR. That in itself would be helpful in the future, when k8s fixes sidecar lifecycle. But I wasn't successful when I tried and time is a bit limited. I'll see if I make a simpler version to show that Shutdown() is indeed called.
Thank you for the reviews!

Fixed last suggestions, thanks @vasiliy-ul and @dharmit for the last round of reviews.
I've added a test to verify sidecar-shim is handling signals in the refactor termination commit, currently https://github.com/kubevirt/kubevirt/commit/e1a2debf3b580c1081fee9c40e549d335ebba689
I've added two tests, one with hooks v1alpha2 to show the actual bug I wanted to fix, failing to terminate the sidecar container on source pod over migration; and another test, using v1alpha3 to show that this PR works as expected. Both in the last commit validate behavior on migration or https://github.com/kubevirt/kubevirt/commit/628602d43a1b4f7ba0c04aef168e29e13b1e5583
/cc @alicefr

/retest-required

/retest-required

@victortoso of everything I have put in above review, only https://github.com/kubevirt/kubevirt/pull/10046#discussion_r1397064426 might need to be changed. Everything else is open question, and a couple are nitpicks.

Shameless ping! With this last version, I've added tests to validate (shim) sidecars are receiving/handling signals normally and also a test to show the bug #8395 and #9838 prior to v1alpha3 and that the bug is solved by this PR.
@alicefr @vasiliy-ul @0xFelix

/retest

Hi @0xFelix please double check the test to see if that's what you expected. All the changes on tests were here:
It worked locally. I think it turned out much better than it was indeed.

/retest

/retest

/retest

/test all


fix: Memory leak in ScanQRActivity

Fixes #229

Dispose barcode emitter on destroy

@mejariamol @arp95 @Shailesh351 @rohanagarwal94 Please review


test fails: unknown oprtion ---r

When running the command aegis-test node, I get the following error:
Message:
    Command failed: mocha --colors ---r=spec --timeout=80000

  error: unknown option `---r'

Any clue? Also, am willing to contribute fix..

Looks like:

https://github.com/ipfs/aegir/blob/master/tasks/test/node.js#L14 goes to
https://github.com/sindresorhus/gulp-mocha/blob/master/index.js#L37 goes to
https://github.com/sindresorhus/dargs/blob/master/index.js

repro
> require('dargs')({R: 'hello'})
    [ '---r=hello' ]

fixed in master


Electron 6.0.x: Linux tests do not start on build machine

From: https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=52083
##[section]Starting: Run unit tests
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.151.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /__w/_temp/6ebd9207-d5d6-417b-8bdc-9205d99b168b.sh
yarn run v1.10.1
$ gulp --max_old_space_size=8192 electron-x64
[09:39:40] Node flags detected: --max_old_space_size=8192
[09:39:40] Respawned to PID: 3224
[09:39:45] Using gulpfile /__w/1/s/gulpfile.js
[09:39:45] Starting 'electron-x64'...
[09:39:45] Starting clean-electron ...
[09:39:45] Finished clean-electron after 4 ms
[09:39:45] Starting electron-x64 ...
[09:39:48] Finished electron-x64 after 3068 ms
[09:39:48] Finished 'electron-x64' after 3.08 s
Done in 9.08s.
Starting : X Virtual Frame Buffer
.build/electron/code-exploration: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by .build/electron/code-exploration)
[3305:0709/093949.071811:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /__w/1/s/.build/electron/chrome-sandbox is owned by root and has mode 4755.
./scripts/test.sh: line 40:  3305 Trace/breakpoint trap   (core dumped) "$CODE" test/electron/index.js "$@"
##[error]Bash exited with code '133'.
##[section]Finishing: Run unit tests

Its https://github.com/electron/electron/issues/17972 , tl:dr we need to fix the permissions for this file on our end, gulp-atom-electron could do it.

via https://github.com/microsoft/vscode/commit/74716d5b9396448b649803e15f951a988e9a071e and passing --no-sandbox to the test script we are getting a little bit further:
Starting : X Virtual Frame Buffer
.build/electron/code-exploration: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by .build/electron/code-exploration)
/__w/1/s/.build/electron/code-exploration: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by /__w/1/s/.build/electron/code-exploration)
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
Xlib:  extension "RANDR" missing on display ":10".
/proc/self/exe: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by /proc/self/exe)
/proc/self/exe: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by /proc/self/exe)
/proc/self/exe: /lib/x86_64-linux-gnu/libdbus-1.so.3: no version information available (required by /proc/self/exe)
{"errorCode":"load","moduleId":"nsfw","neededBy":["vs/platform/files/node/watcher/nsfw/nsfwWatcherService"],"detail":{}}
##[error]Bash exited with code '1'.
##[section]Finishing: Run unit tests

I do not understand why nsfw fails to load though :-(

This is still not working. We need to put --no-sandbox for our tests.

/duplicate https://github.com/microsoft/vscode/issues/81056


ERROR: "invalid output from sysctl" & Compilation Command

Hi! when I run the precompiled binary osx-cpufreq on apple M1 Big Sur 11.4, it generates the error of "invalid output from sysctl". Personally think that below the two lines are the source of the issue (I also posted the same issue in repository of M1-siliconpower). Could you help here?
int             e_core_count        = get_sysctl_int(SYSCTL_ECPU);
int             p_core_count        = get_sysctl_int(SYSCTL_PCPU);

Could you also post the compilation command (clang ...)? Many thanks!

@jingchen95 sorry for the slight delay!
Is your machine a MacBook, iMac, or Mac Mini? Perhaps these entries in sysctl do not exist on these models...
Either way, it should be all good now. I just released osx-cpufreq v2.5.0 with the hopeful fix. Now the script accesses CPU cluster counts from the IORegistry rather than from sysctl. You should hopefully no longer encounter this issue! 👍
Also, here's the command for Clang. (Sorry it's so long...If you want the makefile I use, I can add it to the repo)
clang osx-cpufreq.m universal/universal.m arm64/arm64.m x86_64/x86_64.m x86_64/model_data/model_data.m -o osx-cpufreq -fobjc-arc -arch arm64 -arch x86_64 -lIOReport -framework Foundation -framework IOKit -mmacosx-version-min=10.11

I also left you a response in the M1-siliconpower repo


Is GANet developed based CondLaneNet?

Our main contribution is based on key points and global associations, which is different from CondLaneNet based on conditional convolution.


Started adding support for Async methods

Because of the number of methods and tests to add only a subset of existing methods have an Async counterpart, mainly the methods in Subscription.cs. The library remains backwards compatible because the Async methods are new methods with the "Async" suffix. My goal is, over time to submit additional pull requests to support more endpoints.
Additionally, in order to accomplish this the following related changes were made:

Fixed a couple of broken unit tests
Updated all Xunit nuget packages to the latest versions in order to get support for testing async tests. Only a handful of Asserts in the SubscriptionTests had to be updated after the upgrade.

This is great work! Thanks for taking it on! I'd be happy to help out once I understand what is going on. Also, if there are any small bugs you find it would be great to send them in separate PRs so those can get merged quick.

@bhelx Thanks, I'd love to have the help. It looks like there is an issue with the tests so I will look into that and hopefully get another commit in this weekend.

@bhelx I think a better approach would be to scrap this pull request and create a new one with just the tests updated since so many files changed in the process. I can then followup with a separate pull request for the async stuff.


docs(@angular/cli): add informations about using yarn install on master

Since #11766, using yarn install is mandatory. However, this wasn't documented.
Close #12401

Thanks

@alan-agius4 You're welcome. So, I guess I just have to wait that #12410 is merged and then rebase?

Heya, I'm closing this on in favor of https://github.com/angular/angular-cli/pull/12445 since it contains more information about the setup.


[top] inter-module connection

@tjaychen @sjgitty
I would like to discuss the top gen inter module connection scheme here.
hjson struct in IP vs in Top
Current comportability spec has available_{input|output|inout}_list for the module connection. As the ports are usually connected to Pinmux, all port signals have cio_ prefix. But some of the signals could connect to the other modules (for instance, eFlash and eFlash controller). We should choose between below two options to enable this.

specifying the port isn't goes to Pinmux or outside of the top in the IP. It means the entry in available_{input|output|inout}_list will have name, width, and now inter_module (boolean). If inter_module(name can be changed) is set to true, the port won't have cio_ prefix but have a direct name. For instance, if keymgr_secretkey input port has inter_module as true, then the port will be defined as input [width-1:0] keymgr_secretkey_i.
It still needs the top hjson to define the relationship such as:
inter_module: [
  { from: keymgr.secretkey, to: [hmac.keymgr_secretkey, aes.keymgr_secretkey] }
  ...
]

all assumed as a input/output in the IP, and top configuration determines the connection property. It means all ports in a IP will have cio_ prefix but some of the signals connecting to the other modules.
With above (item 1) example, the top gen will assume from as an output, to as an input and put cio_ prefix and _o or _i postfix accordingly.

input/output data type
The other issue on inter module connection is the input/ output data type.
to reduce the connection between the modules, struct packed type can be used. Issue is, where the struct type should be defined.

From the output module means it introduces extra dependencies between the IPs (not good in my opinion)
Common definition in hw/common/ directory. (still not that beautiful. just moving the dependencies to common directory)
Assume input/output always logic. width is defined in available_{input|output|inout}_list item. Each module will have its own casing from/to the struct packed type. In this case, the sizeof(struct packed) needs to be calculated by the designer or the tool. by tool will be difficult. and width mismatch can happen.
Just stop using struct packed define each signals in the available IO list

clocking information
If the signal is used in the other modules and if the other modules are clocked in another clock, then CDC logic is needed. But it isn't recognized until the clocks are defined in the top. And FPGA version and the ASIC version can have different clock scheme.
So, putting the CDC logic inside IPs isn't feasible in my opinion. Top needs to have CDC logic if needed.

by tool: input, output list have clock information if the signal isn't clock by main IP clock. Tool recognizes clock differences and put the CDC (2ff sync if 1 bit if multibit valid/ready on both sides are mandatory). This is hard problem.
Just do it manually by the top-level designer.

lowRISC/stwg-base#230

@eunchan please refresh with current thinking, has been stale for 6 months

PR #1490 is merged. But still a few things need to be implemented.
A.I:

Define unique inter-module signal (naming rule) when it has multiple
connections of the same struct
Reduce the fields of inter_signal_list in the ip.hjson
Add broadcast type and handling
Add validation check
Revise inter_module structure to cover the cases:

1:1 -> currently supported
1:N -> structurely OK, but not implemented
N:1 -> Not possible to cover with current structure

@eunchan should we close this issue now?
I think intermodule is pretty well known now and also in use.

Agree :) thanks for the ping


Feature Request: GoogleV3, pass "error_message" along to GeocoderQueryError

Right now, it requires more digging than necessary to find the underlying cause of a "Your request was denied." or "REQUEST_DENIED" error.

Should be fixed in https://github.com/geopy/geopy/pull/398#issuecomment-1312689619

Thank you


[SVCS-531] Separate csv and tsv function and remove use of sniff

refs: https://openscience.atlassian.net/browse/SVCS-531
Purpose
Csv.sniff could cause random characters or spaces to be used
as the delimiter. Separating  these functions and using a hard coded
dialect fixes this display problem.
Summary of changes
Broke up the csv/tsv function into two new ones, with the bulk of it in a helper function.
Instead of using Csv.sniff, just use csv.excel, or csv.excel_tab to set the delimiter. This stops things like spaces, characters, numbers etc from being detected as the delimiter.
QA/Testing notes
There is a zip file of csv/tsv files on the JIRA ticket that display the error. Trying them on staging/prod will show you what the error looks like. These display errors should not be present with the changes.

Coverage increased (+0.2%) to 68.227% when pulling 5704d33e2d2fc5200a542ec71810d9674226fdb9 on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

@cslzchen Added new test file to look over

Coverage increased (+0.2%) to 68.227% when pulling 9554e49378cbc7b5dc9859ff52e08aefff2d85e6 on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

Coverage increased (+0.2%) to 68.245% when pulling 50fd4711c5faf370d3dfb63346b257bdaf5fc84e on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

Coverage increased (+0.3%) to 68.336% when pulling 20405f6b229e6b274ea1a7f024740d943c65d26c on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

Coverage increased (+0.3%) to 68.336% when pulling 93235e124f25ec45c77ba467c3c9154324020bf9 on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

Coverage increased (+0.3%) to 68.336% when pulling 93235e124f25ec45c77ba467c3c9154324020bf9 on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.

Coverage increased (+0.3%) to 68.336% when pulling b1083c5fe5936b9ee8572839850260a2f8b8af74 on AddisonSchiller:feature/tsv-svcs-531 into 8bb2dd4d35f8c1d89a72fc8b9e09db317f3497f3 on CenterForOpenScience:develop.


Moved tests to main branch

#1210  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


keepAlive fail

when go-whatsapp loses connection to the internet, keepAlive fails, which is normal but upon gaining connection back subsequent keepAlive requests still fail even after a wac.Restore() has been made.

You need to recover the sassion like WhtasApp web does.... I'm afraid that there is no built-in functionality to start a new session again, you need to do this by yourself....
The con.AdminTest()method can help you to check if your already created session is connected or not...


bash snippets do not activate env after test failures

If the build finishes but a unit test fails, the bash snippets do not activate the environment. This is annoying, because you might for instance want to run the test manually to see what was wrong.

This is fixed now. sb --tests failures now give a special exit code (73) and the shell snippet will now activate the environment if it sees either that or 0.


ReactPropTypeLocations not found with react 16.0.0-alpha.4

When I update to react native on master and react 16.0.0-alpha.4, I get the following error:
Unable to resolve module `react/lib/ReactPropTypeLocations` from `/Users/arthur/Lendix/mobile/node_modules/react-native-fence-html/HTMLStyles.js`

A quick fix is to change the following lines in HTMLStyles.js:
// import ReactPropTypeLocations from 'react/lib/ReactPropTypeLocations'
const ReactPropTypeLocations = {} // added

I have no idea how useful this check is:
if (styleProps[key](testStyle, key, '', ReactPropTypeLocations.prop)) {
   // ...
}

Any suggestion ?
Thanks

I've sent a pull request that fixes the issue. ReactPropTypeLocations was just a keyMirror object so I replaced the property with the corresponding string.

I replaced those 3 lines with 2 new ones , did not work yet.

@almost manually changing make sense! Thanks!)


Splitting complex types into subtypes

Hi
I wan't to inquire if there are any plan on this issue. Say you have your gql:
      dishes {

        ... on RecipeDish {
          id
          recipeId
        }

        ... on IngredientDish {
          id
          ingredient
        }
      }

The generated type would be then
export type MenuDishFragmentFragment = {
  dishes:  Array<( {
      __typename: "RecipeDish",
      id: string,
      recipeId: string,
    } | {
      __typename: "IngredientDish",
      id: string,
      ingredient:  {
        productId: string,
      },
    }
  ) >,
};

Now dealing with entities in code I cannot say let newDish: MenuDishFragment.RecipeDish; or similar but by copying types from the generated file into my code manually
Are there ways to deal with the problem?

If I understand you correctly, I think https://github.com/apollographql/apollo-codegen/issues/159 would solve your issue.

Closing this since you can get exactly this by using the new flow-modern target, which will soon be the default flow target in releases.
Going to close this otherwise -- implementing this in the older target was actually really messy and difficult to understand/iterate on.


Safe code can cause segfault

Hi.
The following code cause a segfault:
extern crate glib;
extern crate gtk;
extern crate gio;

use gtk::prelude::*;
use gio::prelude::*;

use gtk::{Application, Button, Window, WindowType};

fn main() {
    let application = Application::new(
        Some("com.github.gtk-rs.examples.basic"),
        Default::default(),
    ).expect("failed to initialize GTK application");

    application.connect_activate(|app| {
        let window = Window::new(WindowType::Toplevel);
        window.set_title("First GTK+ Program");
        window.set_default_size(350, 70);

        let button = Button::with_label("Click me!");
        button.connect_clicked(|_| {
            println!("Clicked!");
        });
        window.add(&button);

        window.show_all();

        let app = app.clone();
        gtk::timeout_add(100, move || {
            window.set_application(Some(&app));
            glib::Continue(false)
        });
    });

    application.run(&[]);
    gtk::main();
}

Here's the stacktrace:
#0  0x00007ffff789582a in  () at /usr/lib/libgtk-3.so.0
#1  0x00007ffff73447de in g_cclosure_marshal_VOID__OBJECTv () at /usr/lib/libgobject-2.0.so.0
#2  0x00007ffff736280a in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#3  0x00007ffff7362980 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#4  0x00007ffff7b3d473 in gtk_window_set_application () at /usr/lib/libgtk-3.so.0
#5  0x000055555555d6f7 in <O as gtk::auto::window::GtkWindowExt>::set_application (self=0x555555908488, application=...)
    at /home/antoyo/.cargo/registry/src/github.com-1ecc6299db9ec823/gtk-0.9.0/src/auto/window.rs:1573
#6  0x000055555555d0c5 in gtk_test::main::{{closure}}::{{closure}} () at src/main.rs:31
#7  0x000055555555e996 in glib::source::trampoline (func=0x555555908480) at /home/antoyo/.cargo/registry/src/github.com-1ecc6299db9ec823/glib-0.10.1/src/source.rs:90
#8  0x00007ffff725c764 in  () at /usr/lib/libglib-2.0.so.0
#9  0x00007ffff725c340 in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#10 0x00007ffff72aa1d9 in  () at /usr/lib/libglib-2.0.so.0
#11 0x00007ffff725ac03 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#12 0x00007ffff79ce08f in gtk_main () at /usr/lib/libgtk-3.so.0
#13 0x000055555556151a in gtk::auto::functions::main () at /home/antoyo/.cargo/registry/src/github.com-1ecc6299db9ec823/gtk-0.9.0/src/auto/functions.rs:314
#14 0x000055555555dadb in gtk_test::main () at src/main.rs:37

I'm not sure exactly what is causing this.
It might be because set_application() is called from outside the context of the activate signal.

Install debug symbols for GTK and GLib/GObject please, then we would know the lines where things go wrong here and that should make it clear what happens :)
gtk_window_set_application() causes some signal to be emitted and a signal handler on that signal is exploding.

Proper backtrace for reference:
Thread 1 (Thread 0x7ffff580cb80 (LWP 63334)):
#0  gtk_application_impl_window_added (impl=0x0, window=0x555555644530 [GtkWindow]) at ../../../../gtk/gtkapplicationimpl.c:90
#1  0x00007ffff790e7b8 in gtk_application_window_added (application=application@entry=0x5555555fc0f0 [GtkApplication], window=window@entry=0x555555644530 [GtkWindow]) at ../../../../gtk/gtkapplication.c:438
#2  0x00007ffff73392ff in g_cclosure_marshal_VOID__OBJECTv (closure=0x5555555fb510, return_value=<optimized out>, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x5555555fb560) at ../../../gobject/gmarshal.c:1910
#3  0x00007ffff7336206 in _g_closure_invoke_va (closure=0x5555555fb510, return_value=0x0, instance=0x5555555fc0f0, args=0x7fffffffd8a0, n_params=1, param_types=0x5555555fb560) at ../../../gobject/gclosure.c:873
#4  0x00007ffff73548d4 in g_signal_emit_valist (instance=0x5555555fc0f0, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7fffffffd8a0) at ../../../gobject/gsignal.c:3407
#5  0x00007ffff7354edf in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3554
#6  0x00007ffff790f222 in gtk_application_add_window (application=<optimized out>, window=window@entry=0x555555644530 [GtkWindow]) at ../../../../gtk/gtkapplication.c:976
#7  0x00007ffff7b95ac0 in gtk_window_set_application (window=0x555555644530 [GtkWindow], application=0x5555555fc0f0 [GtkApplication]) at ../../../../gtk/gtkwindow.c:3569
#8  0x000055555555d1c7 in <O as gtk::auto::window::GtkWindowExt>::set_application (self=0x555555742ed8, application=...) at /home/slomo/.cargo/git/checkouts/gtk-b89af3a825b1a0bb/b0a081e/src/auto/window.rs:1573
#9  0x000055555555cd25 in bah::main::{{closure}}::{{closure}} () at src/main.rs:31
#10 0x000055555555e226 in glib::source::trampoline (func=0x555555742ed0, func@entry=<error reading variable: value has been optimized out>) at /home/slomo/.cargo/git/checkouts/glib-928cf7b282977403/0f--Type <RET> for more, q to quit, c to continue without paging--
48fab/src/source.rs:90
#11 0x00007ffff724c054 in g_timeout_dispatch (source=0x5555557a4690, callback=<optimized out>, user_data=<optimized out>) at ../../../glib/gmain.c:4800
#12 0x00007ffff724b4de in g_main_dispatch (context=0x5555555fdbf0) at ../../../glib/gmain.c:3309
#13 g_main_context_dispatch (context=context@entry=0x5555555fdbf0) at ../../../glib/gmain.c:3974
#14 0x00007ffff724b890 in g_main_context_iterate (context=0x5555555fdbf0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4047
#15 0x00007ffff724bb63 in g_main_loop_run (loop=0x5555555fdbb0) at ../../../glib/gmain.c:4241
#16 0x00007ffff7a38e85 in gtk_main () at ../../../../gtk/gtkmain.c:1328
#17 0x000055555556182a in gtk::auto::functions::main () at /home/slomo/.cargo/git/checkouts/gtk-b89af3a825b1a0bb/b0a081e/src/auto/functions.rs:314

The reason is that priv->impl of GtkApplication is not initialized yet. It would only be once startup has run. This is a bug in GTK IMHO, it should at least get a guard against this situation to not crash. Inside gtk_application_window_added()
In theory this piece of code in gtk_application_add_window() should prevent it already but apparently doesn't:
  if (!g_application_get_is_registered (G_APPLICATION (application)))
    {
      g_critical ("New application windows must be added after the "
                  "GApplication::startup signal has been emitted.");
      return;
    }

Please report to GTK here: https://gitlab.gnome.org/GNOME/gtk/issues/new


Command does not run successfully on windows 10 Pro

Hello,
I am trying to follow this document and below command does not run
dotnet dev-certs https -ep %USERPROFILE%\.aspnet\https\aspnetapp.pfx -p { password here }

and return below message

as per observing message returned, its seems that it more of Linux/mac command.
please help
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e087007-7838-e0f9-d713-22182a5d9704
Version Independent ID: 2f32c7c3-8667-0e88-495b-c0c888572964
Content: Hosting ASP.NET Core Images with Docker over HTTPS
Content Source: aspnetcore/security/docker-https.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Dup of #18017


New streamer-wands features

Added missing spells and wands for main branch
Added more info for spell tooltips
Added noita beta branch content and apotheosis content
Added noita item inventory support
Added noita progress support
Fixed hover tooltips clipping with window edges

My data scraping is not included in this since they are currently a mess of around 8 python files that all do similar things but aren't built up with well defined functions to make easy user execution.  (If its desired so other people can maintain the project/etc. reasons I can work on getting them into a streamlined form.)
I put some amount of credits in readme.md, but feel free to change/remove if desired.
My level of testing/compatibility for the site was very limited because I just hosted on my laptop and twitch API was being weird so I only tested on my local network between laptop and desktop.
As always, let me know on here or discord if there's anything else or any issues that I need to resolve.

Wow, nice work! I think that both the onlywands and dev.onlywands domains talk to the same database at the moment, so I'll want to get that fixed, then we should be able to deploy directly to the dev site and ask people to test things out. That seems like it'll be the best next step since I can't really review the mod code usefully (though maybe we could get an assist from a strong modder?)
Would you mind including some screenshots in the pull request, to document the user-visible changes at this point in time? (for the new things you've added)


Subtitle Option?

Do we have the option of adding a subtitle?

Aleni, I believe this is in place, let me see if we have an example somewhere.

It looks like there isn't a subtitle or supertitle option. Should we add that as a new slot?

fixed in PR #103


Sharing Option

I have recently annotated task in cvat and tried copying the link to the task from the browser( i am assuming that is how its done) but when i paste in in another browser that has a different account, i am unable to see the annotatedwork or task and i get the error message "Could not receive the requested task from the serverError: You do not have permission to perform this action"   what could the  issue be and how can share ,y work link with someone else?

Hello,
Collaboration only works with your team members in an organization.
You may invite somebody to the organization, assign corresponding role and thus these users may have access to resources.
Resources from personal workspace can not be shared.
Regarding "share" feature, there is existing issue https://github.com/cvat-ai/cvat/issues/7930, so, I will close this one.

alright. Understood


I can't call SWRevealViewController

Hi!
My name sony i'm a new iOS developer
I saw on your simple RevealControllerStoryboardExample2 in colorViewController.m .h also MapViewController  i don't see you import SWRevealViewController but you can call SWRevealViewController class to used it.
Could you tell me about the reasion?
Thanks.

In the group supporting files, there is a .pch file.


Support the K2 compiler

Add support for the new K2 compiler.
Blocked by: https://youtrack.jetbrains.com/issue/KT-59071/K2-MPP-internal-declarations-from-common-module-are-invisible-in-dependent-source-sets-if-there-is-more-that-one-intermediate

This is done.