[ADDITION] Cascade

Category
Software to be added
Cascade
Supporting Material
URL: https://www.cascade.app/
Description: Strategy execution platform that helps organizations make their visions happen, through building their business and departmental plans, right through to tracking and execution of initiatives, team performance and more.
Size:
HQ: Sydney
LinkedIn: https://www.linkedin.com/company/cascadestrategy/
See Record on Airtable:
https://airtable.com/app0Ox7pXdrBUIn23/tblYbuZoILuVA0X3L/recY2B5lLWIF9ebSp

Adding to extended list, (HQ moved over seas) need suggestions for alternatives


Update dependency composer/composer to 1.10.23 and 2.1.9 due to security issue

Summary
There is a security problem with composer 2.0.13. See GHSA-frqg-7g38-6gcf. This PR updates the required composer to the minimum versions 1.10.23 and 2.1.9.
Type of change

[x] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

[ ] Existing tests have been adapted and/or new tests have been added
[ ] Add a CHANGELOG.md entry
[ ] Update the README.md
[ ] Code style has been fixed via composer fix-style

@barryvdh Can this be merged with other versions ^2.8 for example. Thanks


Discussion: Disambiguation of requires

This is just to start a dialog. I love crystal and what the team has done thus far.

One thing I dislike about ruby is the ambiguity of the require syntax. I don't think requires should become global objects or constants. You should be able to control the assignment of other dependencies in the language. As someone who is debugging a certain file, I believe it is much easier to chase the rabbit when your dependencies are specified locally.
Other languages where this exists:

Go
Python
Node.js
ES6

See #140, #265, #1146, #2090, to some degree #1446 and https://github.com/crystal-lang/shards/issues/16
I think we discussed this pretty throughout by now and I still feel like it doesn't fit into some of the core language design decisions already taken, at all.

Yes, closing as duplicate of #140 along with this statement by @asterite:

we won't change the require system. We might introduce a concept similar to refinements if we later find the need for it.


swarming: Despaghettify bot_config hook calls.

Bot startup process is messy.
I'll be taking specifically about Chrome infra bot_config.py case, as a primary example.
Here's how it works:

bot_config.get_dimensions and bot_config.get_state are called with bot.Bot object that has id == 'none' (and the rest of the properties missing). bot_config.get_dimensions is actually using android.get_devices, but Android subsystem hasn't been initialized yet (because it is initialized in on_bot_startup), and so initial dimensions and state are bogus.
Then on_bot_startup is called. It assumes bot.Bot object already has dimensions set (which are set to possibly bogus values, since Android subsystem hasn't been initialized yet). It initializes Android subsystem.
bot_config.get_dimensions and bot_config.get_state are called again. Now with correct bot.Bot object and correct Android subsystem state.
Finally /handshake endpoint is called, it receives correct dimensions and state.

This is at least very confusing (bordering on "easy to break the world", e.g. https://chromereviews.googleplex.com/465757013).
I'm now trying to return additional data from /handshake, that can be used in get_dimensions to make decisions. Unfortunately, get_dimensions is called twice in different circumstances even before /handshake is called. Adding third flavor of environment in which get_dimensions is called is too much.

Proposal:

Postulate that on_bot_startup is called before any other hook (including before get_dimensions).
Document that on_bot_startup receives special uninitialized bot.Bot object.
Teach on_bot_startup to return bot ID, initial set of dimensions and state, send them to the /handshake.
Document that /handshake receives initial dimensions and state that may be changed in the future by get_dimensions and get_state.
Document that get_dimensions and get_state are called immediately before /poll (e.g. after all initialization and initial handshake).
Forbid ID dimension to be changed by get_dimensions (bot changing its ID midlife doesn't make much sense).

The new flow then would be:

on_bot_startup is called (with bot.Bot.id == 'none'), it initializes Android subsystem and bot ID and initial dimensions and state.
/handshake is called. It may return additional server-supplied data, fetched based on bot's ID.
get_dimensions and get_state are called. They may use state set up in on_bot_startup and data returned by /handshake.
/poll

About 2., maybe not pass a Bot object?
lgtm, thanks for looking at this.


Cannot download pre-trained model

When running
python run.py \
        --train_data_path data_utils/dialoglue/hwu/train.csv \
        --val_data_path data_utils/dialoglue/hwu/val.csv \
        --test_data_path data_utils/dialoglue/hwu/test.csv \
        --token_vocab_path bert-base-uncased-vocab.txt \
        --train_batch_size 64 --dropout 0.1 --num_epochs 0 --learning_rate 6e-5 \
        --model_name_or_path convbert-dg --task intent --do_lowercase --max_seq_length 50 --mlm_pre --mlm_during --dump_outputs \

there is an error:
OSError: Model name 'convbert-dg' was not found in model name list. We assumed 'https://s3.amazonaws.com/models.huggingface.co/bert/convbert-dg/config.json' was a path, a model identifier, or url to a configuration file named config.json or a directory containing such a file but couldn't find any such file at this path or url.

How to download the checkpoints/pre-trained models stated in the README?

Hi @zqwerty thanks for pointing this out. We're still working on getting our pretrained checkpoints (the convbert-dg mentioned) onto a public s3 bucket, which we hope to have done in the next few days. I'll let you know when it's made available.

Thanks! BTW, could you post your environment (python packages&version) as well?

Yup just opened a PR for it: https://github.com/alexa/dialoglue/pull/6

Hey @zqwerty I've added a link to the checkpoints in our README, which should fix your issue. Let us know if you have any other problems.

Great!

Hi, I saw the link to download the checkpoints, however, I am not familiar with aws commands, so what is the command line to download those checkpoints? Could you provide it or all users need to learn the aws cli commands themselves. Thank you!


[Fixes #4085] Controller helper inconsistency: HttpNotFound(), Ok()

@Eilon

@kichalla A lot of these ones were inconsistent to maintain compatibility with MVC, at the time I remember that the decision was to keep compatibility vs consistency. I personally like this change, but just wanted to make sure this was taken in consideration

It was.

@javiercn More details here: https://github.com/aspnet/Mvc/issues/4085

:watch:

Was about to say: :shipit: but use #4095 for the ControllerBase changes.

The goal is clarity and maintainability.

Sounds good.
But I'm confused by renaming the result classes. Didn't @Eilon say not to do that?

:shipit: but use #4095 for the initial ControllerBase changes. Add the rest in a second commit.

fd3ee499872465ccc2c5534b58f8ad113a8c0190


Walabot SDK and module

Motivation for this change
This PR adds the proprietary SDK for the Walabot Makers. Because of the nature of the library, which is only available as a pre-compiled shared library, a database must be present under /var/lib/walabot. The walabot NixOS-module creates this directory and populates it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/) (none present)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Any comment on this PR?

@Ekleog: Thanks for your feedback and checking this older PR. I have kind of forgotten this one and don't (have to) use the Walabot anymore. Furthermore this PR is, as you mentioned, kind of hacky. I think it's for the best to just close it. I'm very sorry that you worked all through this.

No problem! It's not your fault if your PR fell under the radar, quite
the opposite, sorry for keeping you waiting for so long :)


[FLINK-26450][fs] Adds error handling to FileStateHandle.discardState

What is the purpose of the change
FileStateHandle.discardState didn't handle cases where the FileSystem implementation used the return value to indicate an error during deletion. This made the cleanup logic not recognize the failure.
Brief change log

Updates FileStateHandle.discardState implementation

Verifying this change

Introduces TestingFileSystem
Adds tests to FileStateHandleTest to cover both deletion code paths.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: yes

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

The solution lgtm, would be good to get @rkhachatryan opinion here.
I struggled a bit with the TestingFileSystem. I am not the biggest fan of the resetCallbacks method there. I was wondering if the entire class is not a bit an overkill. However, I am good if you think it can be reused in the future.

I have similar concerns regarding the tests as @dawidwys. production code LGTM.
TestingFileSystem is needed I guess to register the file system; and this is needed to test "return false" case (where non-existent file can't be used  because it can throw an exception instead of returning false).

TestingFileSystem might be brittle because it has a lot of unsupported operations. Can't we delegate everything except delete to some "real" FS?
Callbacks make it less readdable, and mutable callbacks - error-prone, why do we need to reset them?
I'm wondering whether a local FS can be picked up instead of a testing FS for some reason - should we guard against it using some "test://" scheme?

Thanks for your concerns. I agree that it's a bit of overkill for this specific usecase. See my inline comments below:

TestingFileSystem might be brittle because it has a lot of unsupported operations. Can't we delegate everything except delete to some "real" FS?
The initial intention of TestingFileSystem was to have a "framework" to test against in the future. Having all the method throw UnsupportedOperationException if not specified forces the developer writing a test to define exactly what behavior to expect from the FileSystem. For default behavior, having a temporary filesystem would be good enough.

Callbacks make it less readdable, and mutable callbacks - error-prone, why do we need to reset them?
The idea of resetting them to make each test define the exact context it's running in. Where do you see that it's error-prone? That just would indicate that the test's isn't defined precisely.
Ideally, we would have a FileSystem being specified through a Builder pattern and created per test. But the lifecycle of the FileSystem should happen outside (i.e. around) the test to make sure that it's get removed again, afterwards. This prevents us from initializing the FileSystem within the test. Therefore, I tried this approach with mutable callbacks.

I'm wondering whether a local FS can be picked up instead of a testing FS for some reason - should we guard against it using some "test://" scheme?
I don't understand this proposal. Do you see a way to simulate an error using the local FS? I couldn't come up with a solution here.

I provided a more-use-case specific version for now to follow the idea of only providing code that is actually needed.

Failure is unrelated to the change but also fixed on master already: FLINK-25659

I had to revisit the issue because I noticed that the FileSystem.delete method is not clear on cases where the underlying file doesn't exist. The LocalFileSystem implements the delete method in a way that it would return false if it didn't delete the file since it relies on java.io.File.delete

I'm not sure I fully understand the question.
I think the state is missing for checkpoint 11, not for savepoint 12.
From the logs, I see that the task in question has already received an abortion notification for checkpoint 11 (and therefore discarded it's state):
2022-03-03 14:30:11,241 INFO  org.apache.flink.streaming.runtime.tasks.AsyncCheckpointRunnable [] - ArtificalKeyedStateMapper_Kryo_and_Custom_Stateful (3/4)#0 - asynchronous part of checkpoint 11 could not be completed.
java.util.concurrent.CancellationException: null
    at java.util.concurrent.FutureTask.report(FutureTask.java:121) ~[?:1.8.0_322]
    at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_322]
    at org.apache.flink.util.concurrent.FutureUtils.runIfNotDoneAndGet(FutureUtils.java:645) ~[flink-dist-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
    at org.apache.flink.streaming.api.operators.OperatorSnapshotFinalizer.<init>(OperatorSnapshotFinalizer.java:57) ~[flink-dist-1.15-SNAPSHOT .jar:1.15-SNAPSHOT]
    at org.apache.flink.streaming.runtime.tasks.AsyncCheckpointRunnable.finalizeNonFinishedSnapshots(AsyncCheckpointRunnable.java:191) ~[flink -dist-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
    at org.apache.flink.streaming.runtime.tasks.AsyncCheckpointRunnable.run(AsyncCheckpointRunnable.java:124) [flink-dist-1.15-SNAPSHOT.jar:1. 15-SNAPSHOT]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_322]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_322]
    at java.lang.Thread.run(Thread.java:750) [?:1.8.0_322]

After that, it shouldn't report it to the JM however.
It also shouldn't re-use the same file.

I noticed the FileSystem.delete inconsistency also makes problems for the BlobServer cleanup (FLINK-26484). I guess, we need to fix it in the FileSystem rather than the FileStateHandle to have it consistent everywhere.

Closing this PR in favor of PR #18979 (FLINK-26484)

I reopened this issue again after we decided to not have a common FileSystem.delete implementation on the Flink side. FileSystem is @Public and, therefore, should be touched only after a discussion round on the mailing list. As a consequence, we decided to move the recursion fix closer to the presto FileSystem in PR #18979 . The FileSystem.delete implementations can still return false which should be handled in FileStateHandle properly. Therefore, I opened this PR again considering the comments from @rkhachatryan

Thanks for the review. I'm gonna merge it now.


Unable to set any value

Hi,
I use version 1.2.4 with esp-link.
I am receiving the status of my ac.
{"inError":false,"byte1bit6":0,"fastCheck":false,"timerMode":{"value":0,"description":"relative"},"resume":false,"byte1bit2":0,"byte1bit1":0,"powerOn":false,"temperatureSetpoint":22,"mode":{"value":4,"description":"heat"},"byte3bit7":0,"fanSpeed":{"value":102,"description":"auto"},"onTimer":false,"offTimer":false,"onTimerHours":0,"onTimerMinutes":0,"offTimerHours":0,"offTimerMinutes":0,"byte7bit47":0,"leftrightFan":false,"updownFan":false,"feelOwn":false,"smartEye":false,"lowFrequencyFan":false,"save":false,"byte8bit2":0,"cosySleep":{"value":0,"description":"no sleep"},"selfFeelOwn":false,"selfCosySleep":false,"purify":false,"ecoMode":false,"ptcHeater":false,"dryClean":false,"naturalFan":false,"childSleep":false,"coolFan":false,"peakValleyElectricitySaving":false,"catchCold":false,"nightLight":false,"ventilation":false,"temperatureUnit":{"value":0,"description":"celsius"},"turboMode":false,"sleepMode":false,"indoorTemperature":19.5,"outdoorTemperature":7,"byte13bit7":0,"byte13bit6":0,"dustFull":false,"byte14bit7":0,"light":0,"pmv":{"value":99,"description":"off"},"statusCode":{"value":0,"description":"ok"},"ecoSleepRunningMinutes":0,"ecoSleepRunningSeconds":0,"ecoSleepRunningHours":0}
But I am unable to set any value.

I have already tried different variations but without success.
Can anybody help me?

model ac

It is a SMND-M12 ECO APP from DIMSTAL

Do you need more informations?

I don’t understand what the problem could be, the status is come
try update esp-link ...


Minimum Route Stops

What version of OR-Tools and what language are you using?
Version: v9.10
Language: Python
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
Vehicle Routing Problem
What operating system (Linux, Windows, ...) and version?
Linux and WIndow
What did you do?
I have a VRP problem that need to be solved, however, the constraint is that each vehicle should visit at least 2 stops. How can I show that ?
Is there any method or solution to add that constraint to the model ?

Asked many times. Search for soft lower bound.


style: Remove whitespace

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition

Description

Remove whitespace in the log message
Changes

Remove whitespace

Checklist

[ ] I've formatted my code with Black
[ ] I've ensured my code works on Python 3.10.x
[ ] I've tested my code

Codecov Report

Merging #293 (421d568) into dev (1cf31b6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #293   +/-   ##
=======================================
  Coverage   48.98%   48.98%
=======================================
  Files         106      106
  Lines        8899     8899
=======================================
  Hits         4359     4359
  Misses       4540     4540

Impacted Files
Coverage Δ

dis_snek/api/gateway/gateway.py
18.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf31b6...421d568. Read the comment docs.


Added: validation for post, exceptions, binding result service to handle, some refactor

Besides my earlier remark aimed at clarifying certain aspects that weren't clear to me, the task was performed very well. > > I want to personally thank @OnDecember for leading us in this project. It saved me a lot of time and helped me acquire new knowledge very effectively.

@aleos-dev You flatter me, I'm just trying to learn as well as everyone else)


Error After Upgrade

Today I updated Indigo to v2023.1. Because of that the Yamaha RX v1.0.4 plugin stopped workin since it is not compatible with Python v3+
So, I upgraded the plugin to v2022.0.3 and I get the following error in Indigo log:
Upgrading plugin Yamaha RX Receiver to newer version 2022.0.3 (previous version moved to trash)
Loading plugin "Yamaha RX Receiver 2022.0.3" using API v3.0
Starting plugin "Yamaha RX Receiver 2022.0.3" (pid 24610)
Started plugin "Yamaha RX Receiver 2022.0.3"
Yamaha RX Receiver Error        exception in device_start_comm(Amplificador Living): POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
Yamaha RX Receiver Error        runConcurrentThread error:
Traceback (most recent call last):
File "plugin.py", line 193, in run_concurrent_thread
self.updateStatus(devId)
File "plugin.py", line 269, in updateStatus
root = ClassicReceiver.xmitToReceiver(dev, xml_string)
File "plugin.py", line 65, in xmitToReceiver
resp = urllib.request.urlopen(req)
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/urllib/request.py", line 216, in urlopen
return opener.open(url, data, timeout)
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/urllib/request.py", line 516, in open
req = meth(req)
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/urllib/request.py", line 1279, in do_request_
raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
Yamaha RX Receiver Error        plugin runConcurrentThread function returned or failed (will attempt again in 10 seconds)
The plugin keeps trying ever 10 seconds in a non-stop loop.
The plugin configuration menu doesn't show any parameter to change of configure and since the plugin in not loaded, I can neither perform any action on the existing device nor create a new one.

I think I may have fixed this?
Please try this pre-release version available here: https://github.com/autolog/indigo-yamaharx/releases/tag/2023.0.4
Let me know how you get on. :)

Thanks Jon.
Actually I realized I had a couple of libraries missing for this an other plugins to work (I recently updated to Ventura OS).
After installing them and tweak some scripts I had, the plugin (v2023.0.3) seems to be loading and working properly.
I was using a version that had a lot of functions, actions and properties for the Yamaha amplifier, that are no longer available.
Seems that plus the missing libraries were the culprits.
I'll prefer to wait for the final release on the v2023.0.4.
Thanks again.

Im having this issue as per my log...
Loading plugin "Yamaha RX Receiver 2022.0.4" using API v3.0
Starting plugin "Yamaha RX Receiver 2022.0.4" (pid 41070)
Started plugin "Yamaha RX Receiver 2022.0.4"
Error (client)                  timeout waiting for plugin response from io.thechad.indigoplugin.yamaharx for request UiGetValues1
Error (client)                  timeout waiting for plugin response from io.thechad.indigoplugin.yamaharx for request CallPluginFunc
Error (client)                  runConfigDialog() caught exception: NSInvalidArgumentException -- *** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]
Oct 18, 2023 at 8:40:29 AM
Yamaha RX Receiver Error        Error in plugin execution startup:
File "plugin.py", line 151, in startup
File "plugin.py", line 257, in refresh_receiver_list
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/Plugins/YamahaRX.indigoPlugin/Contents/Server Plugin/rxv/init.py", line 19, in find
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/Plugins/YamahaRX.indigoPlugin/Contents/Server Plugin/rxv/ssdp.py", line 68, in discover
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/Plugins/YamahaRX.indigoPlugin/Contents/Server Plugin/rxv/ssdp.py", line 79, in rxv_details
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/IndigoPluginHost3.app/Contents/Resources/PlugIns/requests/api.py", line 75, in get
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/IndigoPluginHost3.app/Contents/Resources/PlugIns/requests/api.py", line 61, in request
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/IndigoPluginHost3.app/Contents/Resources/PlugIns/requests/sessions.py", line 529, in request
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/IndigoPluginHost3.app/Contents/Resources/PlugIns/requests/sessions.py", line 645, in send
File "/Library/Application Support/Perceptive Automation/Indigo 2023.1/IndigoPluginHost3.app/Contents/Resources/PlugIns/requests/adapters.py", line 532, in send
type: HTTPConnectionPool(host='<IP_ADDRESS>', port=8008): Read timed out. (read timeout=None)
Error (client)                  received unexpected packet response UiGetValues1 (waiting for CallPluginFunc)


[Feature] Clarify the parameter of callback in source.resolve

Relevant source
https://github.com/hrsh7th/nvim-cmp/blob/4c05626ccd70b1cab777c507b34f36ef27d41cbf/lua/cmp/source.lua#L371-L381
The item parameter of callback could be nil, and cmp will fallback it to the original item.
https://github.com/hrsh7th/nvim-cmp/blob/4c05626ccd70b1cab777c507b34f36ef27d41cbf/lua/cmp/entry.lua#L487-L498
And in entry.resolve, the returned completion_item will be always truthy and self.resolved_completion_item will be set to that value either.
The problem
Whether source.resolve returns a truthy item or nil, cmp will always assume the item is resolved successfully and will never trigger resolution twice. Take cmp-nvim-lsp for example:
https://user-images.githubusercontent.com/65551246/204022685-c910f347-f294-4193-9c90-a3dcd8554c17.mp4
If I quickly navigate menu down to let some resolution skipped (source here) and navigate back, the item resolution will not trigger again and the document still displays as the previous one's.
Possible solution?

Provide another callback function named cancel or reject to let the source decide which to call. Then cmp can use this information to determine whether resolution could be re-triggered.
Change the current behavior of cmp to not provide fallback of a nil item returned from source. Since self.resolved_completion_item is kept as nil, cmp will re-trigger source.resolve as is. But this might be a slight breaking change? I'm not sure about it.

The LSP spec does not define cancel or error on completionItem/resolve
I can't understand the actual problem. Could you explain the problem? (completionItem/resolve can't be cancelled` is not valid explanation.)

This is not relevant to LSP spec but a client side specific problem. I'll try to explain it in more details here.
entry.resolve allows the returned entry to be nil, but what does this nil value actually means? In the current implementation, cmp assumes it has been resolved and fallback to the original item.
But what if completionItem/resolve is cancelled by $/cancelRequest? In this case the returned item is also nil but it should be considered as not resolved yet, to allow the resolve to be re-triggered (navigate away then navigate back to it on the menu).
So here is just a semantic problem of a nil item returned from callback. Whether it means:

The source recognized it should not be resolved and request cmp to use the original value as resovled one.
The resolution is an uncoverable failure and cmp should fallback to the orginal value, and should never re-trigger the resolve.
The resolution is cancelled for perf reason but re-trigger by navigating back should be also possible.

Currently cmp assumes 1 and 2, but cannot handle 3.

Oh. I didn't know the LSP spec supported cancellation from the server side.
Hmm... I don't mind removing the ability to treat a "null response" as success.

I'm not sure if changing the fallback behavior will break some sources since it's now the source's responsibility to specify the resolve is success or failure. But I also think this is more reasonable because cmp should not make any assumption about the success status of sources at all.

At least, currently nvim-cmp defines the typing that completionItem/resolve argument isn't null.


Improved security

Notes are fully encrypted using Waku Message version 1 (no metadata leak)
Notes are always encrypted, key is part of the URL
Using standard uuid v4 from browser API to generate ID
upgraded deps to fix a bug

Thank you for showing it @fryorcraken!
Now I understand what you meant by implying that we can fully encrypt messages.
So that it works in a way that consumer reads only messages that it is able to decrypt.
I agree that such way suits note app best.
Additionally I think there are still applications that should have only parts of messages being encrypted so I propose to keep the methods exposed in @waku/message-encryption.

Additionally I think there are still applications that should have only parts of messages being encrypted so I propose to keep the methods exposed in @waku/message-encryption.

I don't really agree with that. It is best if all application encrypt their messages one way or another.

It is best if all application encrypt their messages one way or another

this not necessarily needed, for example blockchain has everything public and it turns out as a feature - allowing everyone using it as a common DB layer so that anyone can build messages on top of public contracts
ok, we can disagree on this - it is an approach for building app which we are not enforcing
if you insist we can prevent from showcasing it in examples / lab repos
but, I do have another point and that is that - if project is using Waku - then it might need encryption library not only for Waku but some other stuff - example of scenario is when Waku is complementary layer of communication and not main one
in that case it is useful to provide basic encryption in order to decrease amount of packages used by a given project


Lint markdown

A reminder that npm run lint:markdown will ensure there’s a consistent syntax for our Markdown. Pedantic? You bet!

This is really nice @paulrobertlloyd – is it something we just run manually when we remember for now?

We could make it a pre-commit hook… or run it as a GitHub action?

Oooh pre-commit would be good!
On Wed, 3 Jun 2020 at 20:36, Paul Robert Lloyd<EMAIL_ADDRESS>wrote:

We could make it a pre-commit hook… or run it as a GitHub action?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/DFE-Digital/bat-design-history/pull/154#issuecomment-638417429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAJCKZDHQ3SZV7NMZRIPR3RU2Q5PANCNFSM4NRZLKGQ
.

--
Thanks!
Adam
Website: adamsilver.io
Twitter: @adambsilver http://www.twitter.com/adambsilver/

We could run tests on PRs that check:

linting
Eleventy builds ok

Prefer tests over commit hooks


Initialize proxy device on home assistant issue

Hi,
I’ve set up an addon but in logs it estsbilishes an MTQQ connection succesfully but then stops on „Initialize proxy device on home assistant„. Does anybody know how to resolve this issue? Thanks

Did you loop your DNS server?
For combination of Home Assistant Core / Supervised you can use following guideline:
EN:
Here is a concise step-by-step guide to setting up AdGuard Home on Home Assistant and configuring the FRITZ!Box 7490 to use AdGuard as the DNS server, including the use of the URL logger.talent-monitoring.com:

1. Install AdGuard Home on Home Assistant

Install AdGuard Home:

Open Supervisor in Home Assistant.
Go to the Add-on Store and install AdGuard Home.

Start AdGuard Home:

Start the add-on and open its web interface (http://<Home Assistant IP>:3000).

Configure AdGuard:

DNS Rewrites:
Navigate to Settings > DNS settings > DNS rewrites.
Add the following rewrite:

Domain name: logger.talent-monitoring.com
IP address: The local IP address of your Home Assistant, e.g., <IP_ADDRESS>.

2. Find the AdGuard IP Address

Determine the local IP address of the device running Home Assistant (e.g., <IP_ADDRESS>).
This IP will be used as the DNS server in the FRITZ!Box configuration.

3. Configure the FRITZ!Box to Use AdGuard as DNS Server

Access the FRITZ!Box:

Open http://fritz.box in a browser and log in.

Change DNS Server Settings:

Navigate to Internet > Access Data > DNS Server.
Select Use other DNSv4 servers.
Enter the AdGuard IP address:

Primary DNS server: <IP_ADDRESS> (AdGuard IP).
Secondary DNS server: Leave blank or enter the same IP.

Save the changes.

IPv6 DNS (Optional):

If you use IPv6, under Use other DNSv6 servers, enter the IPv6 address of AdGuard.

4. Configure DNS Rebind Protection in the FRITZ!Box

Go to Home Network > Network > Network Settings tab.
Scroll down to the DNS Rebind Protection section.
Add an exception for the domain:logger.talent-monitoring.com

Save the changes.

5. Test the Configuration

Test DNS Resolution:

On a device in the network:

Open a terminal or command prompt and run:nslookup logger.talent-monitoring.com

The response should return the IP address of Home Assistant (e.g., <IP_ADDRESS>).

Check AdGuard Logs:

Open AdGuard Home and go to Query Log.
Verify that queries to logger.talent-monitoring.com appear and are resolved correctly.

In addition you need to change the config of your HomeAssistant Network setting to root DNS server to external DNS Server. Therfore use this guide:
Home Assistant OS (Supervisor) - Configure DNS Servers
Steps:

Open the Web Interface:
o	Access the Home Assistant interface via your browser (e.g., http://homeassistant.local:8123).
Go to Settings:
o	Navigate to Settings > System > Network.
Select the Network Interface:
o	Click on the active network interface (e.g., eth0 for wired connections or wlan0 for Wi-Fi).
Configure DNS Servers:
o	Scroll down to the DNS server section.
o	First, delete the IP address pointing to the FRITZ!Box (e.g., <IP_ADDRESS>), as it would route DNS traffic through the FRITZ!Box.
o	Then, from the dropdown menu, select the option Google (<IP_ADDRESS>, <IP_ADDRESS>).
Save and Restart:
o	Save the changes.
o	Restart Home Assistant to apply the new DNS settings.
Verification:
o	Verify that the DNS settings are working by ensuring Home Assistant can access external websites or services like updates.

Hi,
Yes, the nslookup anawers as below

Maybe the issue could be connected to my Gen3Plus inverter MS-1800- in its settings i cannot change the adress and port of a cloud Access as the primary option is set on default with no option to change.

I can only add a B option with an IP of my homeassistant device and a 10000 port. Maybe the issue lays there?


az keyvault secret list command doesn't show a shared access signature definition

There is an open CLI issue for this, but the below command does not work currently.
https://github.com/Azure/azure-cli/issues/14706
az keyvault secret list --vault-name

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b568009-2a35-c627-cfa0-ff5cbfde027e
Version Independent ID: 07fc2d02-be89-1170-3b37-9e65808d5d89
Content: Manage storage account keys with Azure Key Vault and the Azure CLI
Content Source: articles/key-vault/secrets/overview-storage-keys.md
Service: key-vault
Sub-service: secrets
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@DerekHerman-MSFT
Thank you for pointing this out!
I tested this and was able to list my sastoken.

When following the docs, the "az keyvault secret list" should only list the sas token name and not the ID.
The ID for the SAS token (SASDefinitionID) is:
https://<YourKeyVaultName>.vault.azure.net/secrets/<YourStorageAccountName>-<YourSASDefinitionName>
To see the value of the sas you just run:
az keyvault secret show --vault-name <YourKeyVaultName> --id <SasDefinitionID>
For more info
If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

@DerekHerman-MSFT
I just wanted to check in and see if you had any other questions or if you were able to resolve this issue?

@DerekHerman-MSFT
Thank you for pointing this out! Walking through the documentation again I'm not able to "list" or "show" the secret either, through AzCLI or Bash.

@jlichwa are you able to look into this issue?
If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

@DerekHerman-MSFT
Thank you for your time and patience.
You should be able to resolve your issue by running:
az keyvault storage sas-definition show --id https://<YourKeyVaultName>.vault.azure.net/storage/<YourStorageAccountName>/sas/<YourSASDefinitionName>

For more info: az keyvault storage sas-definition show
Since we have a workaround I'll go ahead and close out this issue. If you have any other questions, or need further assistance, please feel free to tag me and I'd be more then happy to re-open this issue and continue working with you.
Thank you for your time and patience throughout this issue.

Hi @JamesTran-MSFT which CLI version were you using?

@bim-msft
I was using 2.14.2

If you have any other questions, please let me know.
Thank you!

@bin-msft @JamesTran-MSFT - I believe our conclusion that with new "SDK" https://docs.microsoft.com/en-us/cli/azure/keyvault/storage/sas-definition?view=azure-cli-latest#az_keyvault_storage_sas_definition_list should be used instead for sas


Improve readability of SI format for very small/large numbers

It would be great to improve the 'human-readability' of SI format "s" for very small/large numbers. At the moment d3-format generates:
console.log(format("s")(1e-50))  -> "0.00000000000000000000000001y"
console.log(format("s")(1e+50)) -> "100000000000000000000000000Y"

I would propose to fall back to exponent notation ("e" format) for numbers below abs(x)<1e-24 or above abs(x)>1e24.
In my application, usually the numbers are in a range where the "s"-format makes sense. Though, sometimes, e.g. due to numerical inaccuracy of calculations, I get very small numbers, that blow-up my output.

For small numbers you could round the number before formatting:

a => format("s")(+a.toFixed(26));

Yes, true. I currently just check for abs(x)<1e-24 and then use "e" or "s" formatting. My point is more that a 'human' would format 1e-50 rather as 1e-50 than as 0.00000000000000000000000001y and therefore it might be an interesting improvement proposal.
Libraries like vega and vega-lite also use d3-format. There a workaround is also possible with custom formatters, but it gets more and more tedious.


APEXMALHAR-2451 Batch support for File I/O operators

@bhupeshchawda Kindly Review

Below is the behavior for supporting batch in FileInputOperator
Batches in fileInput operator are currently optional. To enable batch support, we set emitBatchTuples to true. By default, one batch is a set of files obtained after scanning the input directory once. The time interval between two consecutive batches (and hence two consecutive scans) is controlled via "batchIntervalMillis"
For explaining the code changes, I will add review comments.

Where do I specify when to stop and end my application? We should have something for shutting down the app after one or more batches.


Using with Android Version 15

How can I use this app with android version 15? Is that possible?

Yes, it is. But you will not to be allow to use Window Transitions, just the Compat Transitions.
So you will have to do all transitions in just one Activity using Scenes.
But I think the Compat Transitions doesn't have all kind of transitions in a compat way.


Is "Network Device Enrollment Service" correct for the exposed scenarios?

Per Microsoft documentation in https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-r2-and-2012/hh831740(v=ws.11) "Network Device Enrollment Service" is for "allowing routers and other network devices that do not have domain accounts to obtain certificates.".
Since we're speaking about client computer that will be either hybrid joined of no members of the domain at all, I understand "Certificate Enrollment Web Service" and the "Certificate Enrollment Policy Web Service" will be a clearer requirement than NDES.
Since both services "enable policy-based certificate enrollment for

domain member computers not connected to the domain
computers that are not domain members"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87e5f5f1-16cf-57e2-bdfc-b090d90437b1
Version Independent ID: 1662c47f-12cb-147d-25f0-dee98b6c7722
Content: Windows Hello for Business (Windows 10)
Content Source: windows/security/identity-protection/hello-for-business/hello-identity-verification.md
Product: w10
Technology: windows
GitHub Login: @mapalko
Microsoft Alias: mapalko

@cmdrr - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hello, seems that for SSO; NDES with an application proxy is needed as described here: https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-hybrid-aadj-sso-cert#prepare-the-network-device-enrollment-services-ndes-service-account ; so seems that the initial table it's ok as currently redacted.

Actually it is Ok as currently redacted.
We stand for hybrid (Azure AD and on-premises AD), the way to go is NDES instead of "Certificate Enrollment Web Service" and the "Certificate Enrollment Policy Web Service" for domain member computers that are not connected to the domain and computers that are not domain members.
Not sure if this comment fits your query. if not, please let us know @cmdrr

@cmdrr - From our understanding, the issue you raised has been answered by j0rt3g4. If you feel it hasn't been answered, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!


Calico 3.16+ and FirewallD CentOS 7 not working well

Since the 3.16 release, you guys moved to following rule:
ACCEPT     all  --  anywhere             anywhere             /* cali:S93hcgKJrXEqnTfs / / Policy explicitly accepted packet. */ mark match 0x10000/0x10000
from some Calico IPTables Chain to the FORWARD Chain and Calico ensures that this rule will be the last rule in this chain.
However this collides with FirewallD which introduces the following REJECT rule into the FORWARD Chain:
REJECT     all  --  anywhere             anywhere             --reject-with icmp-host-prohibited
Because of the behaviour of Calico, the ACCEPT rule of Calico will come after the REJECT rule of Firewalld and this causes routing problem between the nodes.
Expected Behavior
Routing should just wohl even if firewalld is enabled, i.e. Calico could introduce the ACCEPT rule as the last ACCEPT rule in the FORWARD Chain, but before any REJECT or DROP Rules.
Current Behavior
Calico injects the so important ACCEPT rule right after the REJECT Rule of Firewalld and setting the Policy to DROP.
Possible Solution
Calico could introduce the ACCEPT rule as the last ACCEPT rule in the FORWARD Chain, but before any REJECT or DROP Rules.
Currently I've built a small service, removing the REJECT Rule of Firewalld and setting the Policy of the FORWARD Chain to DROP. But this is absolutly not a clean way, as explained here: https://github.com/firewalld/firewalld/issues/750
Steps to Reproduce (for bugs)
Simply setup K8S 1.19.x with Calico 3.17 or 3.16 on a few CentOS 7 nodes.
The Check the Logs of i.e. CoreDNS Cluster or try to deploy Istio or Something that need to reach stuff running on different nodes. It will fail with a routing error.
Context
Currently we found a workaround which is quite OK, however, this should be fixes somehow, since firewalld is a quite common software to configure IPTables or NFTables.
Your Environment

Calico version: 3.17 and 3.16
Orchestrator version: 1.19.x and 1.18.x
Operating System and version: CentOS 7 and similar Problems on CentOS 8 but in CentOS may with another root cause.

Calico and firewalld both manipulate iptables rules, and there's high likelihood that they're going to clash or fight over rules.
Calico host protection can be used to implement the rules you currently implement in firewalld - perhaps the solution here is to use that and disable firewalld? https://docs.projectcalico.org/security/protect-hosts
Fundamentally Calico doesn't support running with firewalld (though if it works for you, great).

Hi,
I solved this problem in CentOS 8 by creating a new firewalld zone for kubernetes pods and setting its target to ACCEPT.
So, firewalld will accept packets going into POD SUBNET CIDR (ingress zone) and also packets coming out of POD SUBNET CIDR
(egress zone)
Commands :
firewall-cmd --permanent --delete-zone=kubernetes_pods
firewall-cmd --permanent --new-zone=kubernetes_pods
firewall-cmd --permanent --zone=kubernetes_pods --set-target=ACCEPT
firewall-cmd --permanent --zone=kubernetes_pods --add-source=<POD SUBNET CIDR>
firewall-cmd --reload

firewall-cmd man :
       --permanent [--zone=zone] --set-target=target
           Set the target of a permanent zone.  target is one of: default, ACCEPT, DROP, REJECT

           default is similar to REJECT, but has special meaning in the following scenarios:

            1. ICMP explicitly allowed

               At the end of the zone's ruleset ICMP packets are explicitly allowed.

            2. forwarded packets follow the target of the egress zone

               In the case of forwarded packets, if the ingress zone uses default then whether or not the packet will be
               allowed is determined by the egress zone.

               For a forwarded packet that ingresses zoneA and egresses zoneB:

               ·   if zoneA's target is ACCEPT, DROP, or REJECT then the packet is accepted, dropped, or rejected
                   respectively.

               ·   if zoneA's target is default, then the packet is accepted, dropped, or rejected based on zoneB's target. If
                   zoneB's target is also default, then the packet will be rejected by firewalld's catchall reject.

            3. Zone drifting from source-based zone to interface-based zone

               This only applies if AllowZoneDrifting is enabled. See firewalld.conf(5).

               If a packet ingresses a source-based zone with a target of default, it may still enter an interface-based zone
               (including the default zone).

Versions :
firewall-cmd --version
0.8.2

uname -r
4.18.0-240.10.1.el8_3.x86_64

cat /etc/redhat-release
CentOS Linux release 8.3.2011

kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

To see what is getting rejected by firewalld, use the below commands
firewall-cmd --set-log-denied=all
firewall-cmd --reload
dmesg | grep -i reject


Strange build behaviour - webpack generate incorrect id for module

Bug report

What is the current behavior?
After building webpack generates this code.
        }, 2
    c88e: (t, r, a) => {
        "use strict";
        var o, i = a(82109), u = a(31236).f, s = a(17466), v = a(3929), m = a(84488), _ = a(84964), R = a(31913),
            j = "".startsWith, M = Math.min, W = _("startsWith");
        i({

Webpack generate id as 2c88e but in other places of code it is number.
And after launching browser throw syntax error.
If the current behavior is a bug, please provide the steps to reproduce.
webpack.config.js

What is the expected behavior?

Other relevant information:
webpack version:
v5.28.0
Node.js version:
v14.16.0
Operating System:
      Operating System: Ubuntu 20.04.2 LTS
      Kernel: Linux 5.4.0-66-generic
      Architecture: x86-64

Additional tools:

Can't reproducible, please provide minimum reproducible test repo, also link above uses parcel

https://webpack.js.org/plugins/terser-webpack-plugin/
It's fix my problem.)

https://webpack.js.org/plugins/terser-webpack-plugin/
It's fix my problem.)

Hi, dude, I have met the same problem, could you tell me how you solved it?
I even tried to turn off the optimization.minimize, but the problem still exists 😢


PyTorch Lightning's Precision 64 and version 0.8: Expected scalar type double

🐛 Bug
Since v0.8 (honestly, did only try 0.8.1 and 0.8.2) setting precision to 64 will crash any stat_scores dependent metric.
To Reproduce
Just use any stat_scores metric within any trainer call, be it validate or fit.
Code sample
import torch
from pytorch_lightning import LightningModule, Trainer
from torch.utils.data import TensorDataset, DataLoader
from torchmetrics import Accuracy

class LitModel(LightningModule):
    def __init__(self):
        super().__init__()
        self.metric = Accuracy()

    def validation_step(self, *args, **kwargs):
        self.metric(torch.tensor([50, 50, 50, 50]), torch.tensor([11, 9, 14, 22]))

def dummy_dataloader():
    inps = torch.arange(10 * 5, dtype=torch.float32).view(10, 5)
    tgts = torch.arange(10 * 5, dtype=torch.float32).view(10, 5)
    return DataLoader(TensorDataset(inps, tgts), batch_size=2)

if __name__ == '__main__':
    dataloader = dummy_dataloader()

    model = LitModel()
    trainer = Trainer(precision=64)
    trainer.validate(model, dataloader)

Expected behavior
It shouldn't crash and calculate metrics as in any other precision.
Environment

pytorch/pytorch:1.11.0-cuda11.3-cudnn8-devel
Python 3.8.12

Additional context

Stacktrace
Traceback (most recent call last):
  File "/opt/project/src/scratch.py", line 30, in <module>
    trainer.validate(model, dataloader)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 848, in validate
    return self._call_and_handle_interrupt(self._validate_impl, model, dataloaders, ckpt_path, verbose, datamodule)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 721, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 895, in _validate_impl
    results = self._run(model, ckpt_path=self.ckpt_path)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1234, in _run
    results = self._run_stage()
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1318, in _run_stage
    return self._run_evaluate()
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1363, in _run_evaluate
    eval_loop_results = self._evaluation_loop.run()
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 154, in advance
    dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 127, in advance
    output = self._evaluation_step(**kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 222, in _evaluation_step
    output = self.trainer._call_strategy_hook("validation_step", *kwargs.values())
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1763, in _call_strategy_hook
    output = fn(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/strategies/strategy.py", line 344, in validation_step
    return self.model.validation_step(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/plugins/precision/double.py", line 52, in validation_step
    return self.module.validation_step(
  File "/opt/project/src/scratch.py", line 15, in validation_step
    print(self.metric(torch.tensor([50, 50, 50, 50]), torch.tensor([11, 9, 14, 22])))
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torchmetrics/metric.py", line 264, in forward
    self._forward_cache = self.compute()
  File "/opt/conda/lib/python3.8/site-packages/torchmetrics/metric.py", line 440, in wrapped_func
    value = compute(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torchmetrics/classification/precision_recall.py", line 303, in compute
    return _recall_compute(tp, fp, fn, self.average, self.mdmc_reduce)
  File "/opt/conda/lib/python3.8/site-packages/torchmetrics/functional/classification/precision_recall.py", line 258, in _recall_compute
    return _reduce_stat_scores(
  File "/opt/conda/lib/python3.8/site-packages/torchmetrics/functional/classification/stat_scores.py", line 264, in _reduce_stat_scores
    numerator = torch.where(zero_div_mask, tensor(float(zero_division), device=numerator.device), numerator)
RuntimeError: expected scalar type double but found float

Failing code snippet:
https://github.com/PyTorchLightning/metrics/blob/65ea713a7dcd0f9889fa34f54ba01c92c9baabd1/torchmetrics/functional/classification/stat_scores.py#L231-L264

As always amazed by the speed you guys work on issues 🙂


ValueError: setting an array element with a sequence

Run the following command:
python extract_bboxes.py --proj_root=/data1/zhouwx/hf2vad-master/ --dataset_name=ped2 --mode=train
Problem:
Traceback (most recent call last):
File "data/hf2vad-master/extract_bboxes.py", line 161, in
obj_bboxes_extraction(dataset_root=os.path.join(args.proj_root, "data"),
File "/data/hf2vad-master/extract_bboxes.py", line 149, in obj_bboxes_extraction
np.save(os.path.join(os.path.join(dataset_root, dataset_name),
File "<array_function internals>", line 200, in save
File "/data/anaconda3/envs/pytorch1.10/lib/python3.9/site-packages/numpy/lib/npyio.py", line 521, in save
arr = np.asanyarray(arr)
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The     detected shape was (2010,) + inhomogeneous part.
Should I change the npyio.py to "arr = np.asanyarray(arr, dtype=object)" to solve this problem?

The problem seems to be solved by changing the code.
By the way, can this work detect specific anomalies in the video, like 'video anomaly localization'?
For example, how the red bonding boxes in the Fig5 come about? Are they manually marked? Thanks a lot if any body can answer this question!


Nginx

Whenever I try to configure Nginx for my polygon blockchain it makes the chain unreachable.
How do I configure nginx for the Polygon Edge blockchain?

Hi @CryptoDevving ,
I've already shared with you some tips on how to get started with Nginx on your previous issue
Please do keep this Issue board clean, and post issues that directly relate to the issues in polygon-edge code base.
Nginx issue that you're facing, is in no way related to polygon-edge code base. Like I've sad before there is plenty of documentation online on how to properly configure Nginx.
Let us know if you require some premium, paid support so that we can connect you with some of our partners.
Closing this issue for the reasons stated above.

@ZeljkoBenovic Where do I go to for nginx help? I am still stuck on it.


DOCS 1.4 Directory name update

Signed-off-by: krishna katyal<EMAIL_ADDRESS>

Codecov Report

Merging #1132 (7d8976e) into main (ae01a54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1132   +/-   ##
=======================================
  Coverage   60.98%   60.98%
=======================================
  Files         226      226
  Lines       10224    10224
  Branches     1717     1717
=======================================
  Hits         6235     6235
  Misses       3562     3562
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae01a54...7d8976e. Read the comment docs.

/lgtm
/approve


Left align logo in external facing header?

The logo in the external facing header has a gap to the left rather than being left aligned like the body content below it.

vs

Which is "correct" / preferable?

Left align plz.


logfile permissions are denied to subsequent steps

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Trying to redirect the log file output to GitHub Job Summaries.
      - uses: github/super-linter/slim@v6
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          CREATE_LOG_FILE: true
          # /snip
      - if: always()
        run: cat super-linter.log >> $GITHUB_STEP_SUMMARY

But catting the logfile gives a permissions error.
Expected Behavior
I'd expect subsequent steps to have access to the log file that is created.
Super-Linter version
slim-v6.4.1

Relevant log output
Run cat super-linter.log >> $GITHUB_STEP_SUMMARY
  cat super-linter.log >> $GITHUB_STEP_SUMMARY
  shell: /usr/bin/bash -e {0}
cat: super-linter.log: Permission denied
Error: Process completed with exit code 1.

Steps To Reproduce
on github actions
run while creating log file
attempt to read log file after step is complete
Anything else?
full job run: https://github.com/jasonkarns/bats-mock/actions/runs/9129703172/job/25104872145

Hi @jasonkarns ! This is currently expected and not a bug because we don't create a user within the container image.
This came up in the past (#1861), so it might be a valid request, also considering that is a recommended best practice.
Feel free to send a PR to implement this, we'll happily review it.


[FEAT] Show upload progress

maybe some behind the scene fetch from server or some js tricks

Done, need some UI improvement


[web-burner] multi-arch images

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[x] Optimization
[ ] Documentation Update

Description
According to this slack thread we are updating the following images in favor of multi-arch ones:

quay.io/fpaoline/ovnkbfdtest:0.2
rhscl/httpd-24-rhel7:latest
quay.io/openshift-scale/nginx

Can you also look at the multi-arch alternative for quay.io/wcaban/frr?
https://github.com/kube-burner/kube-burner-ocp/blob/main/cmd/config/web-burner-init/pod_serving.yml#L43-L44

Can you kindly help reference https://quay.io/repository/cloud-bulldozer/frr?tab=tags&tag=latest image here?

Can you also look at the multi-arch alternative for quay.io/wcaban/frr? https://github.com/kube-burner/kube-burner-ocp/blob/main/cmd/config/web-burner-init/pod_serving.yml#L43-L44


Problem：The version of mmengine,mmseg,mmcv

Can you please provide the version of three mmlab modules: mmengine,mmseg,mmcv. I met some problem when initial the segmentation model.

I used mmcv==2.0.1, mmengine==0.8.4 and mmsegmentation==1.1.0.


Update /requestor to /personal-information when redirected

Details
This PR updates the personal-information path so users land on the right VBA step when redirected.
Fixed Issues
$ https://github.com/Expensify/App/issues/5263
Tests

Login to an account with a Workspace.
Navigate to /bank-account/requestor.
Verify that the url does not change and you land on the Bank Account step.
Now, navigate to /bank-account/personal-information.
Verify that you land on the Personal Information step.
Refresh the page and verify that you still land on the Personal Information step.

QA Steps
Steps above.
Tested On

[X] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web
https://user-images.githubusercontent.com/22219519/133467799-cf5596ae-74d5-413b-bc08-2fdf67a355a0.mov
Mobile Web

Desktop

iOS

Android

When I navigate to /bank-account/requestor, I get redirected to the validate step.  Just wanted to make sure this was expected behavior
https://user-images.githubusercontent.com/30609178/133477074-349665e4-0820-477a-afae-2abfe9069586.mp4

Additionally, navigating to /bank-account/personal-information indeed takes me to the Personal Information step but once I refresh I also redirect to the /validate step

Hmmm does your test account have a bank account awaiting validation? You can check by going to OldDot Settings > Account > Payment. That would explain the behavior seen here.

Yup, the accounting is waiting for validation as I was testing it for a VBA setup flow.  As long as these are expected this is good to go

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @thienlnam in version: 1.0.98-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add option to specify nodes

Editing prometheus.yml is a bit of a pain, and now more so that we have
to add each node twice. Add an option in start-all.sh to do it
automatically given nodes passed in the command line.
Signed-off-by: Glauber Costa<EMAIL_ADDRESS>

@glommer Great idea, which can be made simpler with extracting the server list to an extrnal file[1]
prometheus.yml will include something like:
scrape_configs:
- job_name: scylla
  honor_labels: true
  file_sd_configs:
  - files:
      - scylla_servers.yaml

and scylla_servers.yaml will look like:
- targets: ['<IP_ADDRESS>:9180']

(the same for node_exporter)
This will make the templating redundent, and can allow adding target to the file on runtime with refresh_interval
Thoughts?
[1] https://prometheus.io/docs/operating/configuration/#file_sd_config

I was not aware if that option.
I think it makes sense.
On Feb 19, 2017 3:26 AM, "Tzach Livyatan"<EMAIL_ADDRESS>wrote:
@glommer https://github.com/glommer Great idea, which can be made simpler
with extracting the server list to an extrnal file[1]
prometheus.yml will include something like:
scrape_configs:

job_name: scylla
honor_labels: true
file_sd_configs:

files:

scylla_servers.yaml

and scylla_servers.yaml will look like:

targets: ['<IP_ADDRESS>:9180']

(the same for node_exporter)
This will make the templating redundent, and can allow adding target to the
file on runtime with refresh_interval
Thoughts?
[1] https://prometheus.io/docs/operating/configuration/#file_sd_config
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scylladb/scylla-grafana-monitoring/pull/126#issuecomment-280904072,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUNveTTBwEP6aiubhPKfMr8w9qbNR8Sks5rd_ycgaJpZM4MD5Oj
.


IdentityGate Visualization

Description of the issue
IdentityGate constructor accepts a single parameter which is the number of qubits it acts on.
When the parameter value is set to 0, the circuit works fine until the circuit is printed. Program crashes with an ValueError.
How to reproduce the issue

import cirq as c

idgate = c.IdentityGate(0)

qubit = c.LineQubit(0)
circuit = c.Circuit()
print(idgate())
circuit.append(idgate())

print(circuit)
circuit += c.inverse(circuit)
circuit.append(c.measure_each(qubit))

print(c.Simulator().run(circuit, repetitions=100))

File "/Users/xxx/identity_gate_cirq.py", line 11, in <module>
    print(circuit)
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/circuits/circuit.py", line 285, in __str__
    return self.to_text_diagram()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/circuits/circuit.py", line 1197, in to_text_diagram
    diagram = self.to_text_diagram_drawer(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/circuits/circuit.py", line 1276, in to_text_diagram_drawer
    _draw_moment_in_diagram(
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/circuits/circuit.py", line 2612, in _draw_moment_in_diagram
    _draw_moment_annotations(
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/circuits/circuit.py", line 2543, in _draw_moment_annotations
    info = get_circuit_diagram_info(annotation, args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/cirqenv/lib/python3.11/site-packages/cirq/protocols/circuit_diagram_info_protocol.py", line 345, in _op_info_with_fallback
    raise ValueError(f'Wanted diagram info from {op!r} for {rows!r}) but got {info!r}')
ValueError: Wanted diagram info from cirq.IdentityGate(0)() for []) but got cirq.CircuitDiagramInfo(wire_symbols=(), exponent=1, connected=True, exponent_qubit_index=None, auto_exponent_parens=True)

Cirq version
You can get the cirq version by printing cirq.__version__. From the command line:
Cirq: 1.4.1

Discussed during bit.ly/cirq-cynq today (2024-10-16): probably the solution is to add validation to IdentityGate, because it's not physical – a 0 qubit input doesn't make sense.

Hi, I would like to help with this

I feel like we've seen situations where these are created in decomposition or transformers or whatever. Even if they're just temporary and eventually removed from the circuit, disallowing them from even being constructed could break things in ways that may be painful to work around.
In the case of diagrams, I know that PauliString returns NotImplemented from _circuit_diagram_info_ if it's empty, which causes the gate diagram to be placed by itself under all the qubits, similar to a GlobalPhaseGate. So, perhaps do the same for the I gate. Or perhaps it's possible to generalize the behavior of zero-qubit gates from whatever calls into _circuit_diagram_info_, so that not every varadic gate has to explicitly implement this.


Is Falcor being actively maintained?

I don't see any commits in this repo for the last two years. Is Falcor complete, deprecated, maintained, or some other status?

@nat-418  as far as i know falcor is in internal maintainence mode and this repo not updated from netflix upstream anymore. in addition most core devs left netflix in the meantime. i would really love to organize a state of falcor call and decide if this can be handed over to the community (which consists as far as i know just of me at the moment) or if it is time to fork and get some fresh wind behind the project. i have a detailed plan for the future that i am happy to share, but so far i found no one who was interested.

I think it can be counted as deprecated because Netflix stopped using it: https://netflixtechblog.com/seamlessly-swapping-the-api-backend-of-the-netflix-android-app-3d4317155187

I think it can be counted as deprecated because Netflix stopped using it: https://netflixtechblog.com/seamlessly-swapping-the-api-backend-of-the-netflix-android-app-3d4317155187

I don't see anything there indicating they are no longer using Falcor. It looks like they replaced the server-side software that serves the API but the protocol is still Falcor?

https://netflixtechblog.com/migrating-netflix-to-graphql-safely-8e1e4d4f1e72
there are many mentions of netflix moving away from falcor. while they certainly have their reasons falcor still has its place and has no real alternative in many usecases where graphQL is not a good fit! Therefore it would be wrong to call falcor deprecated it is just in a intermediate state where netflix still has the main repo but is moving away from supporting it over the last 2 years.

https://netflixtechblog.com/migrating-netflix-to-graphql-safely-8e1e4d4f1e72

Okay, that is a much more relevant post, thanks for sharing!

there are many mentions of netflix moving away from falcor. while they certainly have their reasons falcor still has its place and has no real alternative in many usecases where graphQL is not a good fit!

I've been looking at GraphQL, and I miss the Falcor feature where objects reached through different paths (like ["userByName"]["lucidNTR"] vs ["postByID"]["1666638084"]["author"]) are returned as pointers to the same object, using $type: "ref"...

@nicolas17  yes and also i generate queries automatically but graphQL is too complex to automatically map to simple plain old js object interactions plus i dont want to write schemas for everything up front but only when a project matures, so graphql is a no go for quick mvps and prototypes or anything where iteration speed is critical. lastly falcor is much simpler to reason about, i often have a much harder time having the whole project in my head with complex graphql compared to the same project with falcor

The gist I got from the articles was that Falcor didn't scale enough for Netflix and their pace of development, so they moved to GraphQL.
But Falcor looks like a great way to mesh different data sources together without having to predefine schemas - just what I was looking for! :)

@bburns  falcor has the same scaling capabilities as graphQL. They neeeded to raplace their monolithic falcor backend with a new architecture and chose graphQL, they could also have rewritten a new falcor server with a different architecture and solved those issues. So falcor is not inherently less scalable. if you need any help let me know!

Thanks, @janfjohannes!
I'm working on an open-source gateway to all your data - email, bookmarks, files, youtube playlists, etc - and then a client app to access everything with one interface. So Falcor looks perfect - can mount different datasources into a path tree, have a client-side cache, etc.
Glad to have found this project!

@bburns  sounds great. something like that for graphql was aquired by netlify recently and since then there is afaik no real alternative. especially the unified auth layer was super helpful. would love to hear more.

Just started learning GraphQL, and came here while reading up on its history. Well done everyone!


Unable to access pre-trained model's checkpoints

Hi, I tried accessing your model's checkpoints through the BAIDU link but could not download it because I can not create a BAIDU account with an international phone number.
Could you please upload it on Google Drive and share the link? I appreciate your help.

@Nischit290402 did you access the link eventually?

@ABedychaj I was unsuccessful even after manny attempts. If you found any way to access the pre-trained weights then please let me know.


feat: Add Invite player function and integration test case for the function

Add Invite player function and integration test case for the function
Details

Added an invite_player function to the game_action module.
Implemented invited_players array type in the game module where invited players are to be added
Implemented Integration test case for the Invite_payer function, in test_game module.

waiting on feedback on any required changes if necessary. Thanks

Hello @princeibs @vibenedict kindly review #101

Ok I will do that


Switching from kaminary to Pagy in ETModel

This PR is to switch fro Kaminari to Pagy in ETModel only. Kaminari still seems to be working quite well in ETEngine so there may not be any reason to change just yet - except for Pagy boasting r.e. their memory usage, speed etc ....
There is a migration guide which proved fairly useful.
Everything works! The only thing is that the styling is a bit different from how it was before.
Before:

After:

Edit - made it much closer to the original now.

In theory you could customise this forever, so if there is something that would be nice to have or something you really don't like about the current implementation I'm very happy to fiddle with it.
Closes #4307

Having looked at this a bit more, I think it may be affecting the api requests? saved_scenarios_spec and transition_paths_spec are both unhappy - do you know what could be causing this @noracato?

This is picked up in  Stable versions.


Fragile Docker image builds

The Dockerfiles currently contain "fragile" build instructions, as they clone from main branches annd don't reference any specific tag or commit.
Thus, whenever a repository used for building the Docker image is changed, a rebuild would change the Docker image, potentially breaking the implementation.
I'd propose checking out a specific commit or a tag (which is favorable) from Dockerfiles to ensure rebuilding a Docker image doesn't change it's contents.

Fixed in 8c08468c76a27ae3a88871d6fdc369ed8854d125.

Fixed in 8c08468c76a27ae3a88871d6fdc369ed8854d125.


FUSETOOLS2-382 - when opening another editor while DDL editor is dirt…

…y, changes will no longer be lost
Signed-off-by: Lars Heinemann<EMAIL_ADDRESS>

Its hard to write a test for that. The former behavior was that the temporary file was deleted once another editor was opened. Given that the new temporary file is not even visible in the UI it would be rather hard to create a check for that without exposing more of the logic. Maybe @apupier has some idea?

In terms of UI testing I could imagine a test where a user Edits the schema, does some changes and then opens the yaml file. Then check the label of the DDL editor tab if there is a (deleted) marker or not.

Its hard to write a test for that.

Totally understand. Just wanted to raise it as a concern. I suspect that this is something that could bite a user if it suddenly goes awry.

@djelinek this pretty much includes https://issues.redhat.com/browse/FUSETOOLS2-334 too.

* it doesn't fully solve the addition of 2 ddl file at the same time, see https://issues.redhat.com/browse/FUSETOOLS2-334?focusedCommentId=14063020&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14063020

It doesn't need to. You describe the default behavior of VS Code. You can do the same with any other file in your project and it will always close the unmodified one to just have one editor opened at a time if possible.

* it doesn't fully solve the addition of 2 ddl file at the same time, see https://issues.redhat.com/browse/FUSETOOLS2-334?focusedCommentId=14063020&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14063020

It doesn't need to. You describe the default behavior of VS Code. You can do the same with any other file in your project and it will always close the unmodified one to just have one editor opened at a time if possible.

this is not the default behavior that I have for other files

Then your VS Code behaves different than mine. I posted a gif on the issue too.

* detected that when closing/reopening the ddl editors are unsynced https://issues.redhat.com/browse/FUSETOOLS2-393

Its not when closing / reopening the DDL editors but when restarting VSCode while the editor is open.

* detected that when closing/reopening the ddl editors are unsynced https://issues.redhat.com/browse/FUSETOOLS2-393

Its not when closing / reopening the DDL editors but when restarting VSCode while the editor is open.

damn, I should have put punctuation (and be more precise):
"detected that when closing/reopening [the VS Code instance], the ddl editors are unsynced"
hopefully you were able to understand me (and correct me)

* naming of editor is a bit long now, not very convenient (but I think it can be improved when implementing one of the 2 next issues so not reporting a specific issue )

fixed in latest commit

So if I recap all the comments here there are a few issues left:

it doesn't fully solve the addition of 2 ddl file at the same time, see https://issues.redhat.com/browse/FUSETOOLS2-334?focusedCommentId=14063020&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14063020
detected that when closing/reopening VS Code then the ddl editors are no longer connected to the yaml file hence changes are not persistet to the YAML https://issues.redhat.com/browse/FUSETOOLS2-393
Aurelien dislikes the way the commands are tested atm (https://issues.redhat.com/browse/FUSETOOLS2-410)

As everything got its own Jira I think this one could be merged then. Opposing voices?


Add EventTime interface to Record

Motivation
Several sources contain information about event time. This pr propagates that information into the pulsar records.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.

I can’t be static final since we can only assign it after open call. It can however just be static.

run integration tests

@srkukarni can you label the issue when you merge it please?


Doc EN: Consitency

After french translation, we have add consistency on all this English point based on others documentations.

thanks


Tests for "converters/transfers.rs"

Write unit tests for converters/transfers.rs

Progress tracking will be reported in the parent issue.


HTML .Class Problem

It started today, I would type a .Class for a tag in HTML and a Error would show up stating the .Class can't be found.

/needsMoreInfo
Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled
Do you have HTML CSS Support (ecmel.vscode-html-css) installed? See related question on SO https://stackoverflow.com/questions/65459034/vs-code-css-class-selector-not-found-with-angular-and-bootstrap-5-beta

I'm having the same issues "css class selector name not found. This just started yesterday. id works fine. I keep all my work in separate folders. I opened a completed project that did not have this issues and now it does. Something had to change.

Try with all extensions disabled.
if it doesn't report error without this extension - report problem in extension repo

I disabled the firefox extension and now my class's are working


Fix gui imports so fixate runs on a headless Rpi

fixate should be able to run without the gui. That includes not importing gui libraries and having dependencies on X. When trying to run on a headless Rpi fixate was failing without having an X server running.

I think the problem is in the pynput module. This is used to capture keyboard events.
File "/home/pi/fixate-venv/lib/python3.5/site-packages/fixate/ui_cmdline/cmd_line.py", line 7, in <module>
    from pynput import keyboard
File "/home/pi/fixate-venv/lib/python3.5/site-packages/pynput/__init__.py", line 23, in <module>

Cool. We can move it to requirements_test.txt

Actually, I think that was done by Kieran for the keyboard hooks. Might just need to find another cross platform solution.

Yep, exactly. Thinking it might just be easiest to switch back to termios for os x/linux and msvcrt on windows.

This might work. Uses termios/msvcrt.
https://github.com/magmax/python-readchar


Support raw and noraw.

I went to add support for raw/noraw to my wrapper lib and noticed that they're actually missing from pancurses.

Added in c76382d7568673c01bcde85acc5c7ec98e66cd43, I'll release a new version with it soon.


Dev & Staging: Add password protection

In dev & staging legacy serlo.org is password protected. This is not the case for the new design. Thus we need a way to protect the whole environment with a password. Alternative: Add a /robots.txt which excludes all dev & staging domains.

Not needed, since Vercel already sets the correct headers for non-production deploys.

Not needed, since Vercel already sets the correct headers for non-production deploys.

Not needed, since Vercel already sets the correct meta tags for non-production deploys.

Do we want to have a general password protection in dev / staging or is it just so that search engine crawler do not index the sites?

Not needed, since Vercel already sets the correct meta tags for non-production deploys.

Do we want to have a general password protection in dev / staging or is it just so that search engine crawler do not index the sites?

The latter.

The latter.

Okay :+1:

Okay :+1:


Mission protocol extension: Start by adding a receive example

@DonLakeFlyer This allows to extend the complete mission protocol according to your proposal. You can run this against QGC on your Mac by running:
make posix jmavsim
It should lend itself as a pretty good reference implementation as its self-contained.

@DonLakeFlyer Any updates on this?

Gonna be a while before I get to this. Wrapping up 3.1 right now so mostly bug fixes and missing existing features.
On Dec 9, 2016, at 11:15 AM, Lorenz Meier <notifications<EMAIL_ADDRESS>wrote:
@DonLakeFlyerhttps://github.com/DonLakeFlyer Any updates on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PX4/Firmware/pull/5779#issuecomment-266097305, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFmsc354kqspv1RL-otxQJscaa36hr-kks5rGajcgaJpZM4KkcrH.

@DonLakeFlyer Our need for this is getting very quickly much more urgent. Any chance to have a look at this in the next days?

Still closing down 3.1 fixes/changes.

@DonLakeFlyer This would also benefit from running at higher priority.

I don't get how this code is supposed to work:
		unsigned mission_type = 0;
		bool write_failed = false;

		dm_item_t dm_item;

		switch (mission_type) {

mission_type is always 0. Where is mission_type supposed to come from to get it to write fence or rally points?

Also what am I supposed to write for a rally/fence point? The current FENCE_POINT and RALLY_POINT items are ardupilot dialect only.

Trying to remember what we discussed here, but I think mission_type would be a field added to the existing mavlink MISSION messages.

If that's the case then it's going to need to be coordinated with ArduPilot folks unless it can be changed in a way that doesn't affect them.

@LorenzMeier should respond with what he intended, but wouldn't it work if mission_type was an extended field (mavlink v2)? Mavlink v1 would default to the current behaviour only allowing you to sync regular waypoints.

I'm quite confused by the current state of mavlink 2. As far as I know it won't work with the current SiK Radio firmware and it won't work with the current WiFi firmware. Hence I don't see how anyone is actually using Mav 2? So if this is mavlink 2 only, i don't see how anyone gets the feature?

This commit here looks like MAVLink2 was added to SiK radios in May 2016
https://github.com/ArduPilot/SiK/commit/3e4f55d9806d99e4fc8ad45bed062e399574ae91

I was having a discussion with tridge on how to implement mav 2 with respect to the capability bit where this radio thing came up. Maybe he was concerned about the fact that most radios wouldn't have updated firmware as opposed to it not being possible.

Don, this is an example. I think you lost all the context from your own proposal, do. let me bring it back to you:

You proposed to add Fence and Rallye into the current mission setup by either including a separator item or by choosing an appropriate MAV_FRAME id (the latter seems better suited)
the same can be done for planned home to disambiguate it from a waypoint
we would add a MAV_CAPABILITIES flag to indicate support for this

On the MAVLink 2 front: Anything that is not legacy is using it. Or in other words: Anybody actively contributing in APM or PX4 needs it and might even already depend on it.

I get that. But I was kind of expecting some sort of implementation of that. I'm not going to have time to implement the firmware side as well. Also if it's going to be a new thing then we need to discuss across with ArduPilot folks as well for common usage.
Two options:

Move fast: Just implement to ArduPilot spec and move messages to common. Then move to Step 2.
Move slower: Discuss/Design new thing.

It's going to be harder for me to complete a #2 discussion/implementation in the next couple weeks. Since I'm currently sitting in the back of my van in the Florida Keys I have very limited discussion bandwidth. But I still do have decent coding bandwidth.

@DonLakeFlyer if you wanted to pursue https://github.com/mavlink/mavlink/pull/626 it wouldn't take much more work to make this PR functional. I could help on the firmware side if it would unblock you.
Previous discussions for reference.
https://github.com/mavlink/mavlink/pull/626
https://github.com/mavlink/mavlink/issues/617

@dagar Yeah this would be good. If everyone is ok with it waiting about a week to re-kick this discussion to completion. I can't really respond until I get home and get more bandwidth.

Superseded by https://github.com/PX4/Firmware/pull/6888


add(javascript-repl) Grammar to handle the REPL output of Node.js, etc...

Issue: none
Changes

Add javascript-repl language with tests.
Checklist

[X] Added markup tests, or they don't apply here because...
[X] Updated the changelog at CHANGES.md
[X] Added myself to AUTHORS.txt, under Contributors

I'm fine with adding a repl grammar in general since we did this recently with Python also and it's my opinion that the repl's are better broken out than being mixed with the main languages (though we still have some mixed).
Though I wonder if the REPL isn't really node-repl... we have Deno also, but that's Typescript?  Also is there a SpiderMonkey JS run-time repl also?  @egor-rogov @allejo Any thoughts here?  Would be nice to avoid the need for two repls (one for JS and one for TS)...  So just wondering about two things:

The exact name for this grammar.
JS/TS support/Deno support, etc...
Other JS runtime REPLS... (SpiderMonkey, etc.)

While we're here might as well try and think about the bigger picture.

@joshgoebel Is it okey?
sample.txt
> for(let i=0;i<5;i++){
... console.log(i);
... }
0
1
2
3
4
undefined
>

@joshgoebel I will fix CI build tommorow.

@joshgoebel How can I generate correct sample.exprect.txt?

How can I generate correct sample.exprect.txt?

Well technically your'e supposed to write it by hand :-) ...but if you're very careful there is a commented line in test/markup/index.js that will overwrite ALL the tests with what the library THINKS the output should be.

@joshgoebel tkanks!

Not sure you got that merge/rebase correct...

@joshgoebel Why?
I just copypasted AUTHORS and CHANGES from master and inserted myself.

I see a bunch of php/ruby stuff now that has nothing to do with this PR.

@joshgoebel Please check my final version.

Looks nice.  My only concern is still the naming (there is really not general JS repl, it's the node repl), so I'm curious if anyone will chime in with any thoughts there.

@joshgoebel
Hmm.
I was thinking of this name, node-repl. So I can rename language and maybe no one thinks otherwise.

I was thinking of this name, node-repl. So I can rename language and maybe no one thinks otherwise.

But I reallly do not want node-repl, spidermonkey-repl, etc... If there are other repl's I'd probably want to kill them with this same stone (if possible)... which makes more of an argument for js-repl. :-)  I'd just like to see if any of the other core team members have any thougths.

@joshgoebel No response from another members of core team...
So isn't it time to merge?
My PR regularly has conflicts because it has been open for quite a long time.
So I suggest merging this PR after resolving conflict with AUTHORS and, if necessary, changing the js-repl to a different name.

My PR regularly has conflicts because it has been open for quite a long time.

@nagayev Not a worry anymore.  I can handle any final merge conflicts as it's just the changelog and authors.  Zero more effort required on your part.
I tagged this 10.4 so it will go into the next release.  There isn't a hurry to merge until then.  I've still been noodling on the name myself as well.

@joshgoebel All right

Since you were working on master you may want to hard reset your master to upstream/mater now that this is merged to make future contributions easier.  And I'd recommend branching first in the future to avoid the need for this step. :)
I also removed this from common as that is a different discussion.
Thanks so much!  This will go out in 10.4 (later this month prolly).


feat(PE-6684): add api for querying get registration fees

do not merge until https://github.com/ar-io/ar-io-sdk/pull/205 is released

:tada: This PR is included in version 2.3.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


resource replacement from gateways to the embedded node

Is your feature request related to a problem? Please describe.
the ipfs.io is blocked in my country. so I thought I could use this addon to replace the https gateway with a node (embedded node for now)
but websites that use ipfs for pictures just use a https gateway (like ipfs.io or cloudflare one)
so I wanted to fetch the pictures (not the main top-domain but pictures embedded in) via this addon embedded node.
Describe the solution you'd like
is there a way to intercept request to this websites and fetch the pictures via the node running either locally or embedded one in addon?
Describe alternatives you've considered
redirecting the resources with firefox addons (like https://addons.mozilla.org/en-US/firefox/addon/requestcontrol) doesnt work because the addon doesnt have a gateway for me to redirect to.
Additional context
firefox browser on linux.

ipfs-companion running on Firefox should be able to redirect images to your local ipfs-desktop or go-ipfs node as long their URL path starts with a valid /ipfs/{cid}

this does not work if you use "embedded js-ipfs node" experiment

As this is not a bug report, closing, in the future ask support questions like this at https://discuss.ipfs.io/c/help/13 :pray:


[T4A6][T17-B2] Clara Tan

Ready for Review

@hotchocolatemarshmallow Some comments added. Please close the PR after reading comments.


[KYUUBI #1989] Decouple curator from other modules

Why are the changes needed?

Decouple curator from other modules.
Mainly changes:

ZookeeperClientProvider -> zookeeper.ClientProvider
zkClient apis -> DiscoveryClient
ZooKeeperClientProvider.withZkClient -> DiscoveryClientProvider.withDiscoveryClient

How was this patch tested?

[X] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1991 (d9cf3de) into master (4148e5b) will decrease coverage by 0.01%.
The diff coverage is 86.61%.

@@             Coverage Diff              @@
##             master    #1991      +/-   ##
============================================
- Coverage     60.47%   60.46%   -0.02%
  Complexity       69       69
============================================
  Files           305      307       +2
  Lines         14873    14899      +26
  Branches       1923     1923
============================================
+ Hits           8995     9009      +14
- Misses         5112     5121       +9
- Partials        766      769       +3

Impacted Files
Coverage Δ

...org/apache/kyuubi/ha/client/ServiceDiscovery.scala
90.00% <ø> (-2.86%)
:arrow_down:

...i/ha/client/zookeeper/ServiceDiscoveryClient.scala
60.57% <ø> (ø)

...he/kyuubi/ha/client/zookeeper/ClientProvider.scala
68.11% <40.00%> (ø)

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
87.15% <50.00%> (ø)

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
82.35% <50.00%> (ø)

...yuubi/ha/client/zookeeper/ACLProviderWrapper.scala
85.00% <60.00%> (ø)

.../scala/org/apache/kyuubi/server/KyuubiServer.scala
62.02% <60.00%> (-0.94%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
84.37% <80.00%> (-0.10%)
:arrow_down:

...e/kyuubi/ha/client/zookeeper/DiscoveryClient.scala
91.54% <91.54%> (ø)

...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala
75.51% <100.00%> (-0.25%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4148e5b...d9cf3de. Read the comment docs.

The Hudi flaky test has been resolved, please rebase on master branch

@pan3793 : thanks for your remind, troubled by the failure of the test :)

@hddong  please resolve the conflicts since the master branch changed...

@ulysses-you Thanks, resolved.

@yaooqinn this PR touched zk related test classes, would you like 1.5.0 include this one? if yes, i will do #2040 based on this one

@yaooqinn this PR touched zk related test classes, would you like 1.5.0 include this one? if yes, i will do #2040 based on this one

will you give me your reason for 1.5？

What is the PR related issues

@pan3793 @yaooqinn : All comments have addressed, any more review?

can you fix the test failures @hddong ?

@yaooqinn : Sure.

@yaooqinn All test passed.

thanks, merged to master


laravel 5.7 not work

laravel 5.7 not work
Problem 1
- Installation request for unisharp/laravel-filemanager v2.0.0-alpha4 -> satisfiable by unisharp/laravel-filemanager[v2.0.0-alpha4].
- Conclusion: remove laravel/framework v5.7.2
- Conclusion: don't install laravel/framework v5.7.2
- unisharp/laravel-filemanager v2.0.0-alpha4 requires illuminate/container 5.4.* || 5.5.* || 5.6.* -> satisfiable by illuminate/container[5.4.x-dev, 5.5.x-dev, 5.6.x-dev, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9, v5.5.0, v5.5.16, v5.5.17, v5.5.2, v5.5.28, v5.5.33, v5.5.34, v5.5.35, v5.5.36, v5.5.37, v5.5.39, v5.5.40, v5.5.41, v5.5.43, v5.6.0, v5.6.1, v5.6.10, v5.6.11, v5.6.12, v5.6.13, v5.6.14, v5.6.15, v5.6.16, v5.6.17, v5.6.19, v5.6.2, v5.6.20, v5.6.21, v5.6.22, v5.6.23, v5.6.24, v5.6.25, v5.6.26, v5.6.27, v5.6.28, v5.6.29, v5.6.3, v5.6.30, v5.6.31, v5.6.32, v5.6.33, v5.6.34, v5.6.35, v5.6.36, v5.6.37, v5.6.38, v5.6.4, v5.6.5, v5.6.6, v5.6.7, v5.6.8, v5.6.9].
- don't install illuminate/container 5.4.x-dev|don't install laravel/framework v5.7.2
- don't install illuminate/container 5.5.x-dev|don't install laravel/framework v5.7.2
- don't install illuminate/container 5.6.x-dev|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.0|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.13|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.17|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.19|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.27|don't install laravel/framework v5.7.2
- don't install illuminate/container v5.4.36|don't install laravel/framework v5.7.2

Yes, the issue is happening there. I have requested the contributors to create a tag for an alpha release.
Hope somebody will review it.

same error,, how to fix it?

Fixed in v2.0.0-alpha5, please upgrade to this version.


char[] encoded as array rather than as a quoted string

The API has CharBuf.addQuoted(char[]) so you can work around this with a custom wrapper type and a custom serializer, but it would be better for the serializer to recognize that char[] is an acceptable string representation; ['T','e','s','t'] does not seem like a reasonable default.

I actually thought about this one once. And at the time.. it seemed like if you were passing an array that you were telling Boon.. hey... here is an array... and you wanted it to come out as a JSON array.
array -> array... seemed like the natural order of things to me.
But I will think about it again. I have more buggy bugs to work on for boon, and this seems like more of a preference. Do you know how GSON and/or Jackson would handle this?
I think I picked the right default, but hell.. I could be wrong.. What did they do?


Problem getting ClientId with http://localhost:'port'/signin-google

Used my localhost port in place of 'port' in http://localhost:'port'/signin-google, I get an alert that "something went wrong".

This is unrelated to the gapi libraries. This is an issue with your local server setup.


Integrate cyclops-streams

LazyFutureStream should extends (cyclops-streams)SequenceM which extends (jool)Seq which extends (JDK)Stream. Taking advantage of functionality available for the Streams eco-system across 3 other projects. This will add all the SequenceM operators to LazyFutureStream.
SequenceM should also be made available as a top level Stream.
SequenceM  - fast sequential Stream, can execute asynchronously on a separate (single thread), supports Reactive Streams and connectable hotstreams.
LazyFutureStream - advanced stream functionality particularly useful for multi-threaded I/O - based on FastFuture. Supports Reactive Streams and connectable hotstreams. Can be used as a sequential Stream, but SequenceM would be much faster (conversely LazyFutureStream much more performant for multi-threaded blocking I/O).
SimpleReactStream - merged SimpleReact and EagerFutureStreams - simpler API, eager behaviour - for blocking I/O - based on CompletableFuture (allOf/ anyOf also exposed)

Released in 0.99.3