Worker sometimes taking and acknowledging jobs after Quit(), but not finishing them

Hello @jrallison,
I'm using your library for my go project and it's an awesome lib. However, I have a small problem with it. Sometimes it takes and acknowledges a new job after Quit() has been called, but the job doesn't finish. I'm not sure how to reproduce it since it only happens sometimes, in my experience, more often with some longer running tasks.
I've created a small fix for it, but I'm pretty new to both go and your lib so I'm sure you could do it in some better way.
I added global Running bool variable in workers.go (https://gist.github.com/tpiha/b73bbaadeb4ada3e6f37#file-gistfile1-txt-L20) which I'm then setting to true right in the beginning of the Run function (https://gist.github.com/tpiha/b73bbaadeb4ada3e6f37#file-gistfile1-txt-L33) and same with Quit() function.
I'm also checking that variable in middleware.go:
https://gist.github.com/tpiha/0a9ec8644ea400aac83e#file-gistfile1-txt-L27
I've fixed this for my project, it's not an issue for me, but I'm still submitting bug if you wanna do something about it in the official code.

Hey @tpiha,
That's true. When calling Quit(), you're telling the workers to start gracefully shutting down (rather than immediately exiting). This includes finishing up any jobs currently in process and/or any jobs fetched from redis and waiting to be processed.
Acknowledgement happens once the entire configured middleware chain finishes (including the job portion) and only if it returns true.
Your change seems to stop all middleware actions as soon as Quit() is called, which isn't a graceful shutdown.
I'm happy to help investigate the root cause here. Can you give me a failing test case or more information about your configuration and jobs you're performing which this occurs?
Thanks,
John

The problem is, it just starts some new jobs, but doesn't finish them (even though it obviously acknowledges them since it doesn't retry on starting it again).
I'll try and create some test case scenario which can be easily reproduced.

Awesome, thanks so much! I'd be very interested in fixing any issue that can cause what you're describing.
I'm happy to work on some test case scenario's as well, but I need some specific details about how you're using the library, the jobs you're running, etc to know where to start.

Closing this since haven't heard of any other cases, and no response. If you'd like to revisit this, please open a new issue.


Holy Shit! What a mess!

Why does Linux-VSCode in WSL have to redirect to the host system's Edge browser for login? And it doesn't even log in properly. What a mess!

Let's try to work through this, it might just be a bug.

What do you see when it "doesn't log in properly"?


To many request to wyze server.

https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/215

@hgoscenski If you have time to look into this that would be great.

@jfarmer08 my suspicion is this is related to the password reset emails received by many users on January 31st.
The email I received from Wyze indicated my password was reset on the 31st. If it was reset at 0000 on the 31st, then 2300 on the 1st would be a reasonable time to see expiration.

Looking at the graph shown in https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/215#issue-2120199508 it seems that the rate of logins didn't scale up all at once, but rather over the course of an hour (presumably before the Wyze team blocked the user agent), I am guessing that this is scaling up as refresh tokens expired and/or stopped working due to the forced password resets. Though of course this is purely a guess.
In addition there appeared to be a change in the response of the refreshToken api, with the "msg": "SUCCESS" which led to (in my case at least) it attempting to perform a login every time.
We may want to perform an exponential backoff for the retries, I can see about putting together a PR to provide that functionality.
Perhaps a exponential backoff up to 5-10 minutes? This would help prevent accidentally DOSing the Wyze servers, while still allowing any individual user a reasonable retry rate.
Unfortunately until users update or turn off the plugin in their homebridges I suspect that User-Agent will have to remain blocked.

That's brings up a great question. I will ask the wyze team. @xcz011

@hgoscenski Thanks for checking on this issue.

I would check internally what triggered the 1/31 reset password with our security team and report back here.
About the refresh token, I didn't see any change related to this endpoint.

Additionally, I noticed one user reported his https://camect.com/ broked as well, which leads me to believe camect may refer to this package as well for its integration with Wyze.
https://forums.wyze.com/t/api-wont-login/288805/6
cc @jfarmer08

@xcz011 i am referencing these errors mentioned here:
https://github.com/jfarmer08/homebridge-wyze-smart-home/issues/208#issuecomment-1925367262
They seem to have started after the header was blocked, though I can check my logs tomorrow from the plugin and see the first time I can see those particular failures.
The reason I indicate that it is an api change is the plugin treated (almost) any value in the msg field as a failure. I would assume that if this had been a preexisting bug an issue likely would have been raised, but that is conjecture.
This change was part of the fix here:
https://github.com/jfarmer08/wyze-api/pull/3/files

@xcz011 I checked my logs, I have logs from approximately the previous 2 weeks before the end of January.
I only saw the Error: SUCCESS message starting on the 2nd.
[06:51:40] ~/wyze-homebridge λ grep SUCCESS ~/Downloads/homebridge.log.txt | head -1
[2/2/2024, 3:54:16 PM] [Wyze Smart home] Error: SUCCESS

[06:51:46] ~/wyze-homebridge λ head -1 ~/Downloads/homebridge.log.txt
com","conn_state":1,"conn_state_ts":1705279393072,"device_params":{"sw

[06:52:17] ~ λ date -r<PHONE_NUMBER>
Sun Jan 14 18:43:13 CST 2024

@hgoscenski
looks like this error message from this line https://github.com/jfarmer08/wyze-api/blob/main/src/index.js#L145
But result.data.msg is actually SUCCESS
Do you know why ?

but we do have a small change on get_object_list response.

@hgoscenski
looks like this error message from this line https://github.com/jfarmer08/wyze-api/blob/main/src/index.js#L145 But result.data.msg is actually SUCCESS
Do you know why ?

This is only throwing an error if its not Success
if (result.data.msg == "DeviceIsOffline" || result.data.msg == "SUCCESS") { return result } else
throw new Error(result.data.msg)

but we do have a small change on get_object_list response.

What change are you referring to?

@xcz011 previously there was no msg set, so the code was treating any value in the msg field as an error. This is what leads me to believe there was an API change, though it is certainly possible I am misattributing the location of the change.
Indeed, upon further analysis of the logs from my homebridge, this appears to be a change to the app/v2/home_page/get_object_list endpoint, rather than the refresh endpoint.
Looking at the logs, it appears when wyze-api would fail to fetch it would assume it was auth related, we can update this to help prevent that behavior. I've included an excerpt from my logs below.
[2/2/2024, 5:01:10 PM] [Wyze Smart home] Refreshing devices...
[2/2/2024, 5:01:10 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:01:11 PM] [Wyze Smart home] Error: SUCCESS
[2/2/2024, 5:01:11 PM] [Wyze Smart home] Error, refreshing access token and trying again
[2/2/2024, 5:01:11 PM] [Wyze Smart home] Performing request: app/user/refresh_token
[2/2/2024, 5:01:11 PM] [Wyze Smart home] /var/lib/homebridge/persist/wyze-63773091-e5d0-554a-8ba2-5a69db9191ee.json
[2/2/2024, 5:01:11 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:01:12 PM] [Wyze Smart home] Error, logging in and trying again
[2/2/2024, 5:01:12 PM] [Wyze Smart home] Performing request: api/user/login
[2/2/2024, 5:01:12 PM] [Wyze Smart home] /var/lib/homebridge/persist/wyze-63773091-e5d0-554a-8ba2-5a69db9191ee.json
[2/2/2024, 5:01:12 PM] [Wyze Smart home] Successfully logged into Wyze API
[2/2/2024, 5:01:12 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:01:13 PM] [Wyze Smart home] Error getting devices: Error: SUCCESS
[2/2/2024, 5:02:13 PM] [Wyze Smart home] Refreshing devices...
[2/2/2024, 5:02:13 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:02:14 PM] [Wyze Smart home] Error: SUCCESS
[2/2/2024, 5:02:14 PM] [Wyze Smart home] Error, refreshing access token and trying again
[2/2/2024, 5:02:14 PM] [Wyze Smart home] Performing request: app/user/refresh_token
[2/2/2024, 5:02:14 PM] [Wyze Smart home] /var/lib/homebridge/persist/wyze-63773091-e5d0-554a-8ba2-5a69db9191ee.json
[2/2/2024, 5:02:14 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:02:15 PM] [Wyze Smart home] Error, logging in and trying again
[2/2/2024, 5:02:15 PM] [Wyze Smart home] Performing request: api/user/login
[2/2/2024, 5:02:15 PM] [Wyze Smart home] /var/lib/homebridge/persist/wyze-63773091-e5d0-554a-8ba2-5a69db9191ee.json
[2/2/2024, 5:02:15 PM] [Wyze Smart home] Successfully logged into Wyze API
[2/2/2024, 5:02:15 PM] [Wyze Smart home] Performing request: app/v2/home_page/get_object_list
[2/2/2024, 5:02:16 PM] [Wyze Smart home] Error getting devices: Error: SUCCESS

@hgoscenski
yes, we are returning SUCCESS in msg
I think this address the issue.

@xcz011 I believe that did resolve the issue, however, I believe that change, combined with the handling of the msg field in this code, may have led to more login requests than would otherwise be expected.
@jfarmer08's change will remove that entirely, which makes sense, given that we don't know all possible values for msg


feat: createLightNode and createPrivacyNode helpers

Blocked by https://github.com/status-im/nwaku/issues/1085


Add goal codes to QR Codes

Issuers
Verfiers

@esune said this isn't supported in traction yet

@esune said this isn't supported in traction yet

I would have to look into ACA-Py as I hve not done it before and don't really know off the top of my head whether it is supported or not (adding goal codes to connections).
@swcurran might be able to provide a quicker answer.

Blocked by: https://github.com/hyperledger/aries-cloudagent-python/issues/2583

Still waiting for AcaPy - needs followup - @wadeking98  will reach out to Emiliano and will note any dependencies to get this done

It looks like the proposed resolution for the issue is to update the RFC to specify both goal and goal_code are required. This means that there will be no change in behaviour in ACA-Py, to move forward all that is necessary is to specify both items in the OOB invitation and the generated payload should include the goal_code required for the wallet interaction.


New version: Tencent.QQ version <IP_ADDRESS>291

This pull request is automatically generated by 🥟 Dumplings in #3192
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Error-Analysis-Timeout


Horizontal scroll in stack report

Horizontal scroll in stack report shouldn't be there

Closing as fixed.


add type parameter to stackless bytecode

Motivation
I modified stackless_bytecode generator and bytecode_to_boogie translator to support generics.
This includes adding one more parameter of type LocalsSignatureIndex to some stackless_bytecode instructions, adding lookups for the type parameter in the generator, etc.
I have also added a test case in tests for the generator.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
cargo test
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

bors-libra r=davidldill

@DavidLDill You missed the @.
@bors-libra r=DavidLDill

:hourglass: Testing commit 6fdd16d0bbcd858658222bb41460a75a9e6237de with merge 9397055fb813cf8537680da1c31454a3a05c55e2...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: DavidLDill
Pushing 9397055fb813cf8537680da1c31454a3a05c55e2 to master...

@bors-libra r=davidldill


Migrate to April 12, 2016 snapshot

The biggest API change in this new snapshot is that _ is not implicit for first parameters, so we have to add them explicitly to maintain the former behaviour.

👍

Maybe we shouldn’t just put _ everywhere, but rather reconsider our API. For example, I think
server.serve(responder: router, …  looks pretty nice.

but rather reconsider our API

I agree.
But I think that would be better in the scope of another PR if we want this one to be a patch bump / bug fix (ie, no breaking changes)

I’m not sure that this one should be non-breaking, because it’s for the new snapshot.

@dreymonde That's a good point. It will break because people's projects will need to move to 4-12 for it to work.
Let's start the discussion then on line notes for which ones you think should not have _.

Should I merge then?

Should I merge then?

I'd say let's wait for Tuesday, but those rules haven't become official yet.

:+1:

By the way, this PR actually won't break anything because the _ was already implicit. It will trigger a warning on earlier snapshots, though.


Cant implent the german umlaute

So after long while I could refrence the files, but I can not get them to work, every time i try to build with them I get this error
devicetree error: /tmp/zmk-config/config/german.dtsi:6 (column 1): parse error: expected '/' or label reference (&foo)
When I remove the unicode, there is no problem building it and my repo: https://github.com/haShinui/zmk_test
Any idea how to fix this?

It looks like https://github.com/haShinui/zmk_test/commit/6558800e406224504126bad3ed20dd773c782810 built successful.

It looks like haShinui/zmk_test@6558800 built successful. Can this be closed?

Yea sorry, I forgot to say that because when I finally got good build late at night i went to bed and then to work.
I am trying now to make mod tap when taped its german and when pressed it french.
If you have any idea, would appreciate the help. I will also work on it.

A standard hold-tap should do


Updated browser-sync dep to 2.3.1

This should fix #6 . @ocombe, I'll leave it to you to merge this :smile:

If you want :D


donetcore 2.2 broke signalr

I have the latest aspnetcore 2.2.0 locally, and no longer get OnConnected events in SignalR (authenticated hub). Still using SignalR 1.0.4 on server, client is angular, and doesn't work with either 1.0.4 or 1.1.0. Same client works with the previous aspnetcore version (2.1.6) with SignalR 1.0.3 and 1.0.4. I get the same problem with both regular SignalR and Azure SignalR.
Client side
"@aspnet/signalr": "^1.1.0",

Are you able to connect at all? Could you collect server and client logs?

It's an Angular client. I see the OPTIONS call for negotiate, but the normal POST that comes after that never happens.

It does this:

            services.AddCors(action =>
                action.AddPolicy(policyName,
                    builder =>
                        builder
                            .AllowAnyMethod()
                            .AllowAnyHeader()
                            .AllowAnyOrigin()
                            .AllowCredentials()));

So in 2.2 .AllowAnyOrigin() + .AllowCredentials() is no longer allowed as it is insecure. You need to explicitly set the allowed origins using WithOrigins()

I see the warning in the log file above. Do you mean I have to explicitly enumerate every origin that can call my Web API? I added withCredentials, I think, for SignalR to work... is there something that can simplify this setup?

I use the WebApi in dev, test, prod, so would I need to add all possible angular client Urls?
I also call the Api from a Web Job... it uses HttpClient... the WebJob runs in the same App Service as the API... do I need to enable that somehow?
                        .WithOrigins(
                            "http://localhost:4200",
                            "https://portal.northstar.app",
                            "https://portaldev.northstar.app")

I ran into this issue as well, and feel like a warning in debug is not significant enough.
Since this completely denies connection, I think this should throw an exception at runtime.

We are also using .AllowAnyOrigin() + .AllowCredentials() and do not have a known list of origins because we are publishing a Cordova application to mobile devices. Any suggestions?

@jsheetzati I'm not entirely familiar with how Cordova works - is each client assigned an arbitrary host? Allowing a wildcard origin with credentials has a known XSRF vulnerability and there aren't guidelines for securing this outside of listing individual allowed hosts.

We will have to investigate further and try some things out, but I think we will be okay. Based on what I read, the origin will be set to null in this case, and we should be able to accept a null origin on the API side.

I found that the clients makes a preflight OPTIONS request with the following Accept header text/html,application/xhtml+xm…plication/xml;q=0.9,*/*;q=0.8. If the header is removed or replaced with application/json the aspnet backend respons just fine with a json object containing the negotiation metadata. I expect it has to do with this issue https://github.com/aspnet/AspNetCore/issues/3323.

@remkoboschker the CORS middleware does no filtering based on the Accept header and the behavior for allowed headers should be identical (if not less restrictive) as compared to previous versions of ASP.NET Core. That said, could you file a separate issue detailing what your issue is and possibly a sample repro app? It would help to keep this thread focused on the original issue.

@pranavkm I could be mistaken, but I do believe my comment is on topic, because I have the same issue as @johnkwaters. I also found a work around in the sense that changing the accept header does make the subsequent POST to negotiate happen. Also the issue I refer to states that the CORS middleware does in fact filter on the accept header. The accepted media types make it a non simple request but the CORS middleware does not recognise it as such and does not return the access control allow headers, if I have understood the issue correctly.

We are also using .AllowAnyOrigin() + .AllowCredentials() and do not have a known list of origins because we are publishing a Cordova application to mobile devices. Any suggestions?

We will have to investigate further and try some things out, but I think we will be okay.

@jsheetzati: We've the same problem. Did you find a solution/workaround?

Fortunately for us, we are still using UIWebView in Cordova for our iOS application. It seems like the UIWebView currently does not validate CORS headers. We will have to revisit this issue when we switch over to using WKWebView instead. We do not want to whitelist a null or file origin for our .NET API.
One option that I came across is using https://github.com/wymsee/cordova-HTTP which will proxy requests through native iOS code before hitting our backend server. CORS does not come into play with this scenario because the request isn't originating at the browser level. Unfortunately, changing all our client code to use the proxy plugin is not a small effort and less than ideal.

Our QA process involves creating a VM with a dynamic IP for testing. There is no way for me to know the origin before pushing my code out to the QA server.
What other options are there to allow for any origin, or any kind of wildcard?

This worked for me. Thanks  dylanvdmerwe !
services.AddCors(options =>
{
options.AddPolicy(
"AllowAny",
x =>
{
x.AllowAnyHeader()
.AllowAnyMethod()
.SetIsOriginAllowed(isOriginAllowed: _ => true)
.AllowCredentials();
});
});

But what is the solution for this common and widespread use case?
When you do not have a known list of origins because you are publishing a Cordova application to mobile devices. Any suggestions?

Any work arounds for asp.net core 3.0 when you have a public api?

This issue really shouldn't be closed, it causes a huge amount of chaos and needs to be looked at.

This seems to be a workaround for now.
          services.AddCors(options =>
            {
                options.AddPolicy(
                    "AllowAny",
                    x =>
                    {
                        x.AllowAnyHeader()
                        .AllowAnyMethod()
                        .SetIsOriginAllowed(isOriginAllowed: _ => true)
                        .AllowCredentials();
                    });
            });

This works for me as well. Thank you very much, dylanvdmerwe!
I am disgruntled with changes such like this. If a developer (or his customer) wants to strictly specify origins, he'll do this. But I don't like being treated like a baby!


Why  AspectIdentifier invokeWithInfo: seems miss the define of the blockInvocation?

Only copy args, but not set the selector or anything else.

OK,  seems use  some private and undocumented implement..


You cannot use the "Symfony\Component\HttpClient\Psr18Client" as the "psr/http-client" package is not installed

PHP version: 8.2.0
Description
php-http/discovery plugin installs a psr18 client that cannot be discovered
How to reproduce
composer.json:
{
  "config": {
    "allow-plugins": {
      "php-http/discovery": true
    }
  },
  "require": {
    "php-http/client-implementation": "^1.0",
    "php-http/discovery": "^1.18"
  }
}

test.php:
<?php
require 'vendor/autoload.php';
$client = \Http\Discovery\Psr18ClientDiscovery::find();
var_dump(get_class($client));

composer update
php test.php

Results:
Fatal error: Uncaught LogicException: You cannot use the "Symfony\Component\HttpClient\Psr18Client" as the "psr/http-client" package is not installed. Try running "composer require php-http/discovery psr/http-client-implementation:*". in /usr/src/myapp/vendor/symfony/http-client/Psr18Client.php on line 37

Possible Solution
As a workaround, I could require psr/http-client, but we don't directly require or use it.

ok, took me a moment but i think this is a confusion between the psr client and the legacy php-http client abstraction.
if you want psr-18, you don't need to require php-http/client-implementation but psr/http-client-implementation

if you manually require psr/http-client, it will only work by chance because the symfony http client has adapters for both http client interfaces.

Changing my requirements to use psr/http-client-implementation gives the same error:
{
  "config": {
    "allow-plugins": {
      "php-http/discovery": true
    }
  },
  "require": {
    "psr/http-client-implementation": "*",
    "php-http/discovery": "^1.18"
  }
}

But, I was mistaken earlier when I said we did not directly rely on psr/http-client - we do, and so I should add that dependency to our library.
I'd like to understand better about "it will only work by chance" though, I'd much prefer it to work on purpose! :)

php-http/client-implementation is the virtual package for the httplug interfaces by php-http. after we built that, we proposed psr-18, which is now accepted and defines an "official" http client interface. the virtual package for psr18 is psr/http-client-implementation.
we did not deprecate httplug because it also provides an asynchronous client, and psr-18 is only about synchronous http requests.
symfony/http-client provides both an integration with psr18 and with the legacy php-http client - this is why i said it would work by chance if you requries a php-http client implementation but then expect to find a psr18 client.
all that said, i just ran your minimal composer.json and indeed psr/http-client is not installed automatically. i think this is indeed a mistake of discovery. i think #249 would be the fix. can you try with that branch if your project then indeed works?

Confirmed as working using dev-composer-plugin branch. I get psr/http-client, and discovery works as expected.


Upgrade to Gradle 1.0-milestone-8 snapshot

See individual commit comments for details.

I just did a full build
./gradlew clean build sonar

with the Sonar task against Gradle 1.0 Milestone 8. It ran successfully, no observed issues.

@markfisher, I notice that the latest SI build (https://build.springsource.org/browse/INT-B21X-30) failed because of the "couldn't find test with id: 23" problem.  This PR fixes that issue.


Missing data type

Missing data type, String, which caused syntax error when copied over to the program.

Already fixed in the upstream repo. Closing.


Add vcpkg installation instructions

xbyak is available as a port in vcpkg, a C++ library manager that simplifies installation for xbyak and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build xbyak, ready to be included in their projects.
We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.
I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library. :)

Thank you for the patch and maintenance of vcpkg. I'll merge it.


New features (geoloc, map center on dataset)

New functions :

User location
Center map on selected dataset

Great features, thanks. I will test and include a soon as possible.


⚠ UdeS website (prod) has degraded performance

In 82dd229, UdeS website (prod) (https://www.usherbrooke.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1126 ms

Resolved: UdeS website (prod) performance has improved in ca2ab1a.


[windows][test] Use regexes for some (more) path separators.

Recently introduced tests have some of their path separators output with
Windows separators. Adapt the test to account for the different output
in Windows.
The original PR missed a couple of quoting, a path separator, and a double-escaped Windows path separator.

@swift-ci please test Windows platform

@swift-ci please smoke test


[poppler][poppler-data] add poppler depends data

come from https://github.com/microsoft/vcpkg/issues/33756
@JonLiu1993 I don't quite understand vcpkg and cmake scripts. Compiling them roughly like this can solve the problem。
Old version cannot display perfectly
the test file
路径test니그_加水印.pdf

请阅读以下贡献者许可协议 （CLA）。如果您同意CLA的观点，请回复以下信息。
@microsoft-github-policy-service agree [company="{your company}"]

选项：

（默认 - 未指定公司）我对我的提交内容拥有唯一的知识产权，并且我不是在为我的雇主工作的过程中提交内容。

@microsoft-github-policy-service agree

（当公司给出时）我在为我的雇主工作的过程中提交内容（或者我的雇主根据合同或适用法律对我的提交内容拥有知识产权）。我已获得雇主的许可，可以代表我的雇主提交意见并签订本协议。通过在下面签名，定义的术语“您”包括我和我的雇主。

@microsoft-github-policy-service agree company="Microsoft"

贡献者许可协议

@microsoft-github-policy-service agree company="Microsoft"

@heweisheng, Thanks for your PR, this is test error, please take a look:
You can move the pkgconfig files with commands similar to:
    file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/share/pkgconfig")
    file(RENAME "${CURRENT_PACKAGES_DIR}/debug/share/pkgconfig/poppler-data.pc" "${CURRENT_PACKAGES_DIR}/share/pkgconfig/poppler-data.pc")
    vcpkg_fixup_pkgconfig()
    file(REMOVE_RECURSE empty directories left by the above renames)
warning: There should be no absolute paths, such as the following, in an installed package:
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux
    /mnt/vcpkg-ci/installed
    /mnt/vcpkg-ci/buildtrees/poppler-data
    /mnt/vcpkg-ci/downloads
Absolute paths were found in the following files:
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux/debug/share/pkgconfig/poppler-data.pc
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux/share/pkgconfig/poppler-data.pc
error: Found 5 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: /mnt/vss/_work/1/s/ports/poppler-data/portfile.cmake

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

IMO 数据不应成为硬性构建时要求。AFAIU 在运行时需要“CJK 和西里尔文”支持。

@heweisheng, Thanks for your PR, this is test error, please take a look:
You can move the pkgconfig files with commands similar to:
    file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/share/pkgconfig")
    file(RENAME "${CURRENT_PACKAGES_DIR}/debug/share/pkgconfig/poppler-data.pc" "${CURRENT_PACKAGES_DIR}/share/pkgconfig/poppler-data.pc")
    vcpkg_fixup_pkgconfig()
    file(REMOVE_RECURSE empty directories left by the above renames)
warning: There should be no absolute paths, such as the following, in an installed package:
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux
    /mnt/vcpkg-ci/installed
    /mnt/vcpkg-ci/buildtrees/poppler-data
    /mnt/vcpkg-ci/downloads
Absolute paths were found in the following files:
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux/debug/share/pkgconfig/poppler-data.pc
    /mnt/vcpkg-ci/packages/poppler-data_x64-linux/share/pkgconfig/poppler-data.pc
error: Found 5 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: /mnt/vss/_work/1/s/ports/poppler-data/portfile.cmake

let me try

Ping @heweisheng for response.

Ping @heweisheng for response.

I don't know how to change it will be better,such as @dg0yt say


[Enhancement] Bumping pandas version from 1.5.0 to 2.x

To bump pandas version from 1.5.0 to 2.x, we have to make changes to resolve issues such as

AttributeError: 'DataFrameGroupBy' object has no attribute 'mad' -> mad() is deprecated after 1.5.0  (https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.DataFrame.mad.html)(https://github.com/pandas-dev/pandas/issues/11787)
AttributeError("'DataFrame' object has no attribute '_construct_axes_from_arguments'"
TypeError: quantile() got an unexpected keyword argument 'numeric_only'
TypeError: to_csv() got an unexpected keyword argument 'line_terminator'

To see the full error on GitHub Actions,

Change pandas version for integration test to ~2.0.1 (here and here) as below
export PANDAS_VERSION=${PANDAS_VERSION-2.0.1}
@nox.parametrize("pandas_version", ["2.0.1"])
Note that we can bump it to be 2.0.3 or above as well.
Integration test should be run automatically when you push any changes to the branch. You can see the log by going to Actions tab > Click Integration tests on the right menu > Choose the test that is running on the branch with your changes

See example of GitHub Actions log here: https://github.com/thanawan-atc/opensearch-py-ml/actions/runs/6040143974/job/16390355081
We have to change those deprecated functions so that it works with pandas 2.x.
Once there is no error in integration test, we can then update requirements.txt , requirements-dev.txt , requirements-docs.txt ,  ci file, and noxfile to use new pandas version.
Lastly, make sure that the integration workflow and build-deploy-doc workflow do not fail with the new pandas version.

@thanawan-atc should we not go to 2.0.3 since it's the latest in that line?

Also, do you think we should change the requirements.txt to be <2.0 as 2.1 is currently broken and is not getting added to testing?

I believe 2.0.3 also made the integration test failed as well. Our plan is to update pandas-related functions that were deprecated and then bump pandas from 1.5.0 to 2.x.

@Yerzhaisang you can pick up this task.

got it

Can I work on this issue?

Can I work on this issue?

If I can't resolve this issue on this weekend, you can take it

May I try on this issue?

Sure, assigning it to you.

The upgrade to 2.x should also resolve #263

If this issue is still actual and there is no updates, reassign it to me please

Hey @Yerzhaisang any updates? I see you created a PR last month and I can confirm it works (I ran pip install git+https://github.com/Yerzhaisang/opensearch-py-ml.git@dev) so what needs to happen in order to get this merged in?

@soapergem Thank you for the comment.
Dear @dhrubo-os, can I start fix from scratch and raise another PR. If yes, I will close https://github.com/opensearch-project/opensearch-py-ml/pull/366 and raise another PR. Thank you!

Sure, go ahead.

@Yerzhaisang are you still working on this issue?

@Yerzhaisang are you still working on this issue?

Dear @dhrubo-os ,
please, just follow the commits on this branch
Already did:
Replaced mad  method with custom one.
Started replacing _construct_axes_from_arguments  method with custom one.


[Chat] Bug fix Img via file share with no message content

What
Images being shared via file share (drag and drop) with no message content was not being displayed in the message bubbles
Why
Bug where we were check for valid content before making a request to download inline images.
How Tested
Teams side:

Drag and drop an file img into the chat box without a message content
CallWithChatComposite
Notice message bubble loads inline image

Process & policy checklist

[x] I have updated the project documentation to reflect my changes if necessary.
[x] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Looks good, thanks for the quick turn around on this.


Express Book Review changes

These are recent edits I made to my Express Book Reviews project.

made edits to expressBookReviews project


Supporting older python

Hi, I'm generally quite in favour of keeping up with latest stable python however there are many common OS / distros which still ship with Putin 3.8 / 3.9.
Are there particular features of 3.10 that this library depends on that aren't available in older versions?
As per https://github.com/sethmlarson/truststore/issues/75 I'm interested in ways to use this everywhere by default, however the 3.10 minimum feels a bit restrictive still.

Unfortunately without making truststore not pure-Python (thus disqualifying us from use by pip) we can't support older Python versions. We got the APIs we needed in 3.10: https://sethmlarson.dev/experimental-python-3.10-apis-and-trust-stores

Ah thanks for the reply (and blog link) that all makes very clear sense. Yep support for older versions really would not be feasible.

Unfortunately without making truststore not pure-Python (thus disqualifying us from use by pip) we can't support older Python versions.

Is it not possible to make a C extension optional for 3.10 (or even just make it <3.10 exclusive) and then just have pip only use it for 3.10 + pure-python regardless of other modes?

@eli-schwartz If you'd like to contribute this feature that would be awesome, I would happily review it! :rocket: Not much time right now for open source outside of the most critical paths right now for me unfortunately :/


How to install extensions such as uBlock Origin?

There is not possibility to download it from Google store.
Does it mean the single way to do it manually?

In the FAQ, first question, first answer:
https://ungoogled-software.github.io/ungoogled-chromium-wiki/faq#can-i-install-extensions-from-the-chrome-webstore

Instructions on installing extensions are here:
https://ungoogled-software.github.io/ungoogled-chromium-wiki/faq#can-i-install-extensions-from-the-chrome-webstore

@antonin-lebrard Thank you! But it is still not clear how to update automatically.

@hardhub Unfortunatly I didn't find any way to auto update each extensions.
But in my experience it is actually a very good thing, as extensions may change of owner without notice or the owner might be malicious, and profit of autoupdate behavior of chrome to update its extensions with crypto-miner, adware, malware, anti-privacy features etc...
I prefer to search for the code source of each extensions I wish to install/update.
It might be cumbersome, but I don't see better way to manage this automaticaly

For reference, you can also install uBlock Origin manually like they describe here https://github.com/gorhill/uBlock/tree/master/dist#install
Easy pc


[iOS] better handling of setting AudioContext for single player instance

Checklist

[x] I read the troubleshooting guide before raising this issue
[x] I made sure that the issue I am raising doesn't already exist

According to the documentation, one needs to set the audio context globally on iOS:
https://github.com/bluefireteam/audioplayers/blob/main/getting_started.md#audio-context
But this is not intuitive, or expected for the user.
We should either

throw an error, if setting single player AudioContext config
like in Android for AudioManager values: set the values globally

We should also set the "speaker" option by default on the native side.
Current bug behaviour
Not really tested, but according to #1194 nothing happens.
Expected behaviour
Throw an error or set the configuration globally.
Steps to reproduce

Run below code

Code sample
AudioPlayer().play(source, AudioContext())

Environment information

audioplayers version: 2.0.0

Platform 1: iOS

build mode: debug

More information

Are you interested in working on a PR for this?
I can work on this PR, but I can't test it finally. So if one wants to fix it or just test, you're welcome.
Related #1194

I also wonder why this error is never shown anywhere: iOS does not allow for player-specific audio contexts; use setGlobalAudioContext instead. Or no-one ever noticed while setting it per player.


Question: fallback loading element for routes

How do i show a loading state when a route is being fetched?
eg, in nextjs 13, i can create a loading.tsx file and return some jsx, which will server as a suspense fallback element when child routes are being fetched.
Is there a built in way to achieve same with this package?

Pending state depends on the routers/integrations support for it. Right now only two integrations support it:

React Location: by exporting route-based PendingElement component
New TanStack React Router: by exporting route-based Pending component


Implement *Assign traits

Example:
let mut a: Vector3<_> = …;
a += a; //cannot use `+=` on type `cgmath::Vector3<…>`

This is because concept AddAssign is not implemented. Can you implement this (and similar conecpts)? (shouldn't be difficult, I think, but I didn't find, where you implement the other concepts (Add, Sub, Mul, etc.)

Actually, AddAssign was implemented for Vector$N<B> where B: BaseNum, and $N minght be 1, 2, 3, 4. The implementation even covers some cover cases with respect to references, which can be quite handy. They are implemented via some verbose macro_rules, in case you wonder.
These are all explicitly documented, I don't see why you'd think they are not.
Perhaps you are trying to use it with some B that doesn't implement BaseNum?

I'm gonna close this if you are happy! Feel free to reopen this if not.


Block "Win" shortcuts "system behavior" while not disabling the shortcuts

📝 Provide a description of the new feature
Current Keyboard Shortcut Manager can only disable the shortcuts.
For example, I can not add "win+d" as "delete line" in VSCode, because that is the system shortcut for "display desktop". However, I can still not add it if I disable "win+d" in Keyboard Shortcut Manager, because the shortcut itself is disabled and VSCode can not use it either.
So can we only block the "system behavior" for "Win" shortcuts, while allowing the applications to still use them?

If you'd like to see this feature implemented, add a 👍 reaction to this post.

To do what you want, just remap Win+D to Ctrl+Shift+K for code.exe.  That should do exactly what you want i believe.  I do this to Ctrl+F find stuff for Outlook.  Just tested it for code and it worked like a champ.

What is the larger scenario here you're trying to solve.  Win+L is an example of a key we cannot override too.

To do what you want, just remap Win+D to Ctrl+Shift+K for code.exe.  That should do exactly what you want i believe.  I do this to Ctrl+F find stuff for Outlook.  Just tested it for code and it worked like a champ.

What is the larger scenario here you're trying to solve. Win+L is an example of a key we cannot override too.

Hi @crutkas. Thanks for your response:) I just use "delete line" as an example. Your solution is just a workaround because it requires setting a different shortcut in the applications first then mapping the "Win" shortcut to that shortcut in Keyboard Shortcut Manager.
There are several concerns:

Users may not want an extra shortcut for the same action. Although they can use something not on the keyboard like "F15" to prevent that from being used.
Users may sync their configuration between platforms. If the system win shortcuts can be blocked, users can only have one "win+d" in their config file. Otherwise, there have to be duplicated two entries: "win+d" and "F15".
There could probably be some cross-platform applications that use "Win" shortcuts but lack the capabilities of shortcuts customization or require lots of work to change them all.

Thanks.

@Shuenhoy are these hypotheticals or actually happening to you?  I read these as hypotheticals and want to verify if these are actual needs
doing a global 'ignore winkey shortcuts' is a pretty big thing to do and we don't have a way to reenable once you would want

Also the ctrl-shift-k is the shortcut for VS Code to delete a line in Windows.  I didn't adjust anything there.
I feel like there is a larger underlying concept we need to address and this is a one of the things.  due to this, i'm going to ask "why" a lot so i can understand :)

@Shuenhoy are these hypotheticals or actually happening to you? I read these as hypotheticals and want to verify if these are actual needs
doing a global 'ignore winkey shortcuts' is a pretty big thing to do and we don't have a way to reenable once you would want

@crutkas  These are actually happening. I am using both Windows and some Linux desktops, I want to unify my shortcuts for VSCodes between them, meanwhile make use of WinKey shortcuts. I am also using TeXmacs, a WYSIWYG scientific text editor, which conflicts with a lot of WinKey shortcuts of Windows system behavior in its default configuration.  Although its shortcuts are configurable, it requires lots of work.
There do exist workarounds for these configurable applications. I can configure the shortcuts as some keys not on the physical keyboard(so that they would not occupy the keys), and then map WinKey shortcuts to them via Keyboard Shortcut Manager. However, this is still not as direct as just disabling system WinKey shortcuts behavior for my applications via Keyboard Shortcut Manager.
Here is the configuration with the workarounds for example:
[
  {
    "key": "ctrl+shift+k",
    "command": "-editor.action.deleteLines",
    "when": "textInputFocus && !editorReadonly"
  },
  {
    "key": "ctrl+shift+f15", // not using ctrl+shift+k because I don't want two possible shortcuts
                             // for the same operation. I use f15, which is not on the physical keyboard,
                             // so it is only possible to use win+d
                             // Lataer I need to remap win+d to ctrl+shift+f15 for code.exe from KSM
    "command": "editor.action.deleteLines",
    "when": "textInputFocus && !editorReadonly"
  },
  {
    "key": "win+d",          // this is the duplicated entry for other platform, where win+d is available for vscode
    "command": "editor.action.deleteLines",
    "when": "textInputFocus && !editorReadonly"
  }
]

And here is the configuration if KSM could do what I want for the same example:
[
  {
    "key": "ctrl+shift+k",
    "command": "-editor.action.deleteLines",
    "when": "textInputFocus && !editorReadonly"
  },
  {
    "key": "win+d",          // no duplicated entry.
                             // Later I need to disable win+d "show desktop" for code.exe from KSM
    "command": "editor.action.deleteLines",
    "when": "textInputFocus && !editorReadonly"
  }
]


machine_file resource not working as the connect_to_machine method is not implemented

When trying the following:
%w{ chef-validator.pem admin.pem}.each do |opscode_file|
  machine_file "/etc/chef-server/#{opscode_file}" do
    local_path "/tmp/#{opscode_file}"
    machine "my-test-machine"
    action :download
  end
end

the following error is thrown:
 * machine_file[/etc/opscode/chef-validator.pem] action download

    ================================================================================
    Error executing action `download` on resource 'machine_file[/etc/opscode/chef-validator.pem]'
    ================================================================================

    RuntimeError
    ------------
    Chef::Provisioning::AWSDriver::Driver does not implement connect_to_machine

    Resource Declaration:
    ---------------------
    # In /Users/emmanuelsciara/Documents/Development/git-repos/chef-cookbooks/xebia-chef-server/.chef/local-mode-cache/cache/cookbooks/xebia-chef-server/recipes/cp-xebia-chef-server.rb

     51:     machine_file "/etc/opscode/#{opscode_file}" do
     52:       local_path "#{opscode_file}"
     53:       machine node['xebia-chef-server']['server']['name']
     54:       action :download
     55:     end
     56:

    Compiled Resource:
    ------------------
    # Declared in /Users/emmanuelsciara/Documents/Development/git-repos/chef-cookbooks/xebia-chef-server/.chef/local-mode-cache/cache/cookbooks/xebia-chef-server/recipes/cp-xebia-chef-server.rb:51:in `block (2 levels) in from_file'

    machine_file("/etc/opscode/chef-validator.pem") do
      action [:download]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      chef_server {:chef_server_url=>"http://<IP_ADDRESS>:8889", :options=>{:client_name=>"Ems-MacBook-Pro.local", :signing_key_filename=>nil}}
      declared_type :machine_file
      cookbook_name "xebia-chef-server"
      recipe_name "cp-xebia-chef-server"
      local_path "chef-validator.pem"
      machine "esc-provisioned-chef-server"
    end

Running handlers:
[2014-12-26T17:39:11+01:00] ERROR: Running exception handlers
Running handlers complete
[2014-12-26T17:39:11+01:00] ERROR: Exception handlers complete
[2014-12-26T17:39:11+01:00] FATAL: Stacktrace dumped to /Users/emmanuelsciara/Documents/Development/git-repos/chef-cookbooks/xebia-chef-server/.chef/local-mode-cache/cache/chef-stacktrace.out
Chef Client failed. 2 resources updated in 22.918384 seconds
[2014-12-26T17:39:11+01:00] ERROR: machine_file[/etc/opscode/chef-validator.pem] (xebia-chef-server::cp-xebia-chef-server line 51) had an error: RuntimeError: Chef::Provisioning::AWSDriver::Driver does not implement connect_to_machine
[2014-12-26T17:39:11+01:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

When looking at today's lib/chef/provisioning/aws_driver/driver.rb file, the connect_to_machine method is indeed not implemented. Looking at the current driver.rb file of the chef-provisioning-fog driver, which is working fine, here is the implementation of the offending method:
    # Connect to machine without acquiring it
    def connect_to_machine(machine_spec, machine_options)
      machine_for(machine_spec, machine_options)
    end

Would do it myself and submit a PR, but I got to dash and I have not setup up a dev env for this yet. Anyone is a taker?

if you try to :converge_only you also get the 'connect_to_machine method is not implemented'

adding in your code snippet worked in that I can :converge_only , the only problem is I'm not sure what :converge_only is meant to do as it is not documented anywhere :)

connect_to_machine is implemented now, try it out! :)


istio-operator: ingressgateway type not honored

Bug description
When using the IstioControlPlane profile default with override values.gateways.istio-ingressgateway.type=ClusterIP the gateway is still instantiated as type LoadBalancer
Expected behavior
to get a gateway of type ClusterIP
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istio:
client version: 1.4.0
control plane version: 1.4-alpha.10f63ffc12a557209341a7289e5716cf8021578c
data plane version: 1.4-alpha.10f63ffc12a557209341a7289e5716cf8021578c (12 proxies)
k8s: v1.14.8
helm: v2.16.0
How was Istio installed?
istio-operator
Environment where bug was observed (cloud vendor, OS, etc)
azure

closing as it I did it incorrectly but is possible:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
metadata:
  namespace: istio-operator
  name: istiocontrolplane
spec:
  profile: default
  gateways:
    components:
      ingressGateway:
        k8s:
          readinessProbe:
            failureThreshold: 20
  values:
    gateways:
      istio-ingressgateway:
        type: ClusterIP


Journal sorting of places or people with Umlaut is out of order

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:

Android repository
iOS repository

[x] Bug is not already reported in another issue

Technical details

Device name: Fairphone 3+, iPhone 11
iOS/Android version: Android 10, iOS 14.6
App version: <IP_ADDRESS>

Describe the bug
In the list of people an places, entries e.g. starting with an Umlaut are sorted all the way on the bottom. This is unexpected especially since it’s an app focused on Germany.
Steps to reproduce the issue

Go to Journal
Click on any day
Add a new person or place e.g. starting with an "Ä"
See how it is sorted all the way on the bottom

Expected behaviour
Ä is sorted after or with A, Ö is sorted after or with O, Ü after/with U, ß after/with s/ss.
Ideally this would also extend to other languages e.g. with the Polish Ł.
Possible Fix
For Android, I assume the fix will need to be in the same place as where @PhilippNowak96 fixed the sorting of people and places to be case insensitive https://github.com/corona-warn-app/cwa-app-android/pull/2017/files
I couldn’t find a similar pull request for iOS so I’m not sure there.

Internal Tracking-ID: EXPOSUREAPP-8280 Android
Internal Tracking-ID: EXPOSUREAPP-8177 iOS

@jancborchardt
Probably the app should sort according to DIN 5007-1 for the German locale (see https://de.wikipedia.org/wiki/Alphabetische_Sortierung). The simplest is Variante 1 (like your suggestion). Variante 2 is better for lists of names, but may be overkill for the application of the CWA contact journal.

Yes, 1 seems perfectly fine for this case. I assume Java might have some sort of locale check which could do this automatically, but I don't know.

@jancborchardt
Thanks for reporting. I've forwarded the report to the developers wher it will be investigated now. I also included @MikeMcC399 's suggestion.

Corona-Warn-App Open Source Team

PR: https://github.com/corona-warn-app/cwa-app-ios/pull/3136

@jancborchardt Can you pleas recheck if this is still an issue?

Android PR: https://github.com/corona-warn-app/cwa-app-android/pull/5419 targeting 2.26.0

@mtwalli Thank you! Could you please create & apply the Fix 2.26 label to this issue? Thanks!

@Ein-Tim ,  I don’t have access to this repo. I will ask around who can grant me access now. Unfortunately @dsarkar left the project

@mtwalli Yeah, the information that the CMs are away for some time came through to us, thanks! It would be great if you and the other devs could get access to this repo so that you can at least apply labels to issues & close fixed issues, to at least keep a minimal housekeeping effort going.

@jancborchardt
I checked with CWA Android 2.26.0 on Android 10 and now "Ährensache" is sorted at the top (after "Aachen" and before "Apotheke").
Perhaps you would like to check for yourself and close this issue if you are satisfied?

@MikeMcC399  Thanks for checking and confirming the fix.
@jancborchardt  I'm closing the issue, feel free to re-open if you can produce it


3mf file - cannot associate mesh with material (if metadata is used)

Hi,
I am exporting some meshes to a .3mf file using lib3mf v2.0.0.
I am able to get something like this in the output xml
<basematerials id="2">
  <base name="Material A" displaycolor="#AA000000"/>
</basematerials>

<basematerials id="4">
  <base name="Material B" displaycolor="#0032AA00"/>
</basematerials>

<object id="1" name="Mesh1" type="model" p:UUID="...">
  <mesh>
  ....
  <mesh/>
<object/>

<object id="3" name="Mesh2" type="model" p:UUID="...">
  <mesh>
  ....
  <mesh/>
<object/>

I want to associate one mesh with one specific material.
Is this possible in 3mf?
I am unable to find a function that allows me to say: for a given mesh X, the associated material is Y.
I need something like
mesh1->setBaseMaterialsId(4); //e.g. to associate mesh1 with the material B
Thanks

Hi Chris,
this works via the setting of properties.
PModel model = wrapper->CreateModel();

PBaseMaterialGroup pBaseMaterial = model->AddBaseMaterialGroup();
Lib3MF_uint32 nBaseMaterialID = pBaseMaterial->AddMaterial("PLA Blue", wrapper->FloatRGBAToColor(.0f, .0f, 1.0f, 1.0f));

PMeshObject meshObject = model->AddMeshObject();
meshObject->SetObjectLevelProperty(pBaseMaterial->GetResourceID(), nBaseMaterialID);

Properties of all or individual (or all) triangles are set via meshObject->SetTriangleProperties (or meshObject->SetAllTriangleProperties).

Hi,
I tried that function and it does not save anything
// Add base material group to lib3mf model
Lib3MF_BaseMaterialGroup pModelBaseMaterial3MF;
lib3mf_model_addbasematerialgroup(m_spModel3MF, &pModelBaseMaterial3MF);
// Add material with name and RGB information to base material group
Lib3MF_uint32 propertyId = 0;
lib3mf_basematerialgroup_addmaterial(pModelBaseMaterial3MF, materialName, color, &propertyId);
// Get basematerial resource ID
Lib3MF_uint32 ResourceID;
lib3mf_resource_getresourceid(pModelBaseMaterial3MF, &ResourceID);
lib3mf_meshobject_setobjectlevelproperty(spMesh3MF, ResourceID, propertyId);

Oh, I see.
Does your example work as expected if you do not add metadata to the mesh?

Hi,
I can confirm now,

the association between mesh and basematerial does not work if metadata is saved
the association between mesh and basematerial does work if no metadata is saved

see examples below

when metadata is saved

		<basematerials id="2">
			<base name="Similar to Aluminum 7050-T7651" displaycolor="#AA000000"/>
		</basematerials>
		<object id="1" name="Segment #1" type="model" p:UUID="e8086963-06be-4fb4-8db7-20d7c4ef1f11">
			<metadatagroup>
				<metadata name="cura:extruder_nr" type="string" preserve="1">1</metadata>
				<metadata name="cura:infill_mesh" type="string" preserve="1">True</metadata>
				<metadata name="cura:infill_sparse_density" type="string" preserve="1">20</metadata>
			</metadatagroup>
			<mesh>...

when no metadata is saved
		<basematerials id="2">
			<base name="Similar to Aluminum 7050-T7651" displaycolor="#AA000000"/>
		</basematerials>
		<object id="1" name="Segment #1" type="model" p:UUID="5c945eaf-4f56-45a2-a560-ff342fefa60a" pid="2" pindex="0">
			<mesh>

note the presence of: pid and pindex attributes - inside the object element
Note that:

same mesh was used
I used lib3mf v2.0.0 for export (the C api, see my code in my previous message)

Thanks

Should be fixed in lib3mf v2.1.1

@martinweismann thanks a lot!
any idea when 2.1 will be released?

Last touches ...


Broken file description assigner?

Repeat of the same file, well over 20+ times before moving on to the next file. Is it just refining it's description or?

On top of the above query, ill like to add the following too:

What may be the issue here? too many requests? or?

Having the same issue

some error I captured:
FastAPI
Key Error Information:
File: "/home/haveyoutried/llama-fs/src/loader.py"
Line: 22
summaries = await get_summaries(doc_dicts)
Line: 193
summaries = await asyncio.gather(...)
Line: 184
return await summarize_document({"content": doc.text, **doc.metadata}, client)
Line: 122
summary = json.loads(chat_completion.choices[0].message.content)
Error: UnboundLocalError: cannot access local variable 'chat_completion' where it is not associated with a value
Potential Problem Area:
The error suggests a problem within the summarize_document function, specifically on line 122.
It appears the code is trying to access the chat_completion variable before it has been assigned a value.
This likely indicates an issue with the language model API call or the processing of its response.
Recommended next steps:

Inspect the summarize_document function (line 122) in /home/haveyoutried/llama-fs/src/loader.py.
Verify that the language model API call is functioning correctly and returning a valid response.**
Ensure the response from the API is being properly parsed and assigned to the chat_completion variable.

This information should help the program owner quickly pinpoint the source of the error and begin debugging.
Application (NPM)
APPIMAGE env is not defined, current application is not an AppImage
libva error: vaGetDriverNames() failed with unknown libva error
[6561:0816/161946.214091:ERROR:CONSOLE(2)] "Electron sandboxed_renderer.bundle.js script failed to run", source: node:electron/js2c/sandbox_bundle (2)
[6561:0816/161946.214120:ERROR:CONSOLE(2)] "TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))", source: node:electron/js2c/sandbox_bundle (2)


Simple controller no longer working

git clone https://github.com/KirillOsenkov/SourceBrowser
msbuild /r
Open SourceBrowser.sln in VS and F5 - this will generate a static website
Set SourceIndexServer project as Startup and F5 again

Description of the problem:
http://localhost:58320/api/symbols?symbol=pro is supposed to call my SymbolsController
Actual results: 404
This used to work in 2.0.

Yup, I confirmed that removing that line fixes it. Thanks David!
This was to work around this issue: https://github.com/KirillOsenkov/SourceBrowser/issues/93
and https://github.com/aspnet/MvcPrecompilation/issues/162

Why did this work in 2.0 but not 2.1?

In 2.0 the DependencyContext's runtime graph would accurately say that a project referenced MVC. In 2.1, transitive references to shared fx don't show up in the runtime graph: https://github.com/aspnet/Mvc/issues/7617#issuecomment-380194466

@KirillOsenkov the precompilation tool has been deprecated and is off by default since 2.1. You can safely remove both these lines from your project file.


How can i extend blog, default quarx module, by adding and displaying blog categories ?

I need to add image, author, blog category, comments to blog, etc.
I am not sure what can i do to add blog categories (dynamically) to blog & display them, because:

i need in admin panel (when creating/editing a blog) to have loaded all blog categories(in a select) that previously are defined in a new custom module; i tried to find a way by doing these:

add select directly in files from resources/views/vendor/quarx/modules but this means that after updating & publishing quarx, all modifs will be discarded;
try to add dynamically values to select config/quarx.php (this does not work because here is no database connexion) and cannot do this:

 'category' => [
            'type' => 'select',
            'options' => Quarx\Modules\Blogcategories\Models\Blogcategory::pluck('name', 'id')->toArray()
        ],

i ended up trying to override blog create method in a my blog controller, with the outcome of writing dynamically in config file the blog categories, but i can't override the create route for blog (to call method from my controller), as nothing happens:

 $blogCategories = Blogcategory::pluck('name', 'id')->toArray();
 $blogCategories->each(function($value, $key) {
             Illuminate\Support\Facades\Config::set('quarx.forms.blog.category.options', [$value, $key]);
         });

and
Route::group(['prefix' => 'quarx'], function () {
    Route::group(['middleware' => ['auth', 'quarx']], function () {
        Route::resource('blog', \App\Http\Controllers\Quarx\BlogController::class, ['as' => 'quarx', 'except' => ['show']]);
        Route::post('blog/search', 'BlogController@search');
        Route::get('blog/{id}/history', 'BlogController@history');
    });
});

i also need to retrieve all blog categories for front display, thus using
$blog = $this->blogRepository->findBlogsByURL($url);
in show method from controller ; in this way i end up using BlogRepository from vendor and the method findBlogsByUrl returns blog or translated blog & also uses Blog vendor model which does not have the relation with custom module BlogCategories;

You can essentially piggy back on Quarx within your app. This means you can create custom local Models ex. App\Models\Blog which would have your relations. You can then create a custom Controller, Repo, Service etc within your app and just extend the existing Quarx classes. This will let you take control of things but use what is prebuilt. You would then want to disable the default Blog module. I don't believe updating the package and using publish would overwrite your edits to the existing files either.


Bluepill Error :  "Could not launch app and tests: The request to open "com.xyz.internal.debug" failed."

Need help with the error.
[  INFO  ] Using 781 of 1064 processes.
[  ERROR ] (2) Completed: [1] Launch Application
[  ERROR ] (2) Could not launch app and tests: The request to open "com.xyz.internal.debug" failed.
[  INFO  ] (2) [1] Delete Simulator
[  ERROR ] (3) Completed: [1] Launch Application
[  ERROR ] (3) Could not launch app and tests: The request to open "com.xyz.internal.debug" failed.

Are you able to see the app installed in the simulator?

I see this too with the sample app. I compile the sample app using
xcodebuild -project BPSampleApp.xcodeproj -scheme BPSampleApp -configuration debug  build-for-testing
Then I use
bluepill -a <Path to derived data>/Build/Products/Debug-iphoneos/BPSampleApp.app -s BPSampleApp.xcodeproj/xcshareddata/xcschemes/BPSampleApp.xcscheme -o ./output
I don't see the app installed. Right after the OS loads, the simulators close.
It's probably a dup of #48.

Ah, perhaps it is the problem with resource limit, check your ulimit -a ?
This is mine ;-)
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
file size               (blocks, -f) unlimited
max locked memory       (kbytes, -l) unlimited
max memory size         (kbytes, -m) unlimited
open files                      (-n) 150000
pipe size            (512 bytes, -p) 1
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 2500
virtual memory          (kbytes, -v) unlimited

Nice rig 😄
I'm not sure this is the problem. Can you repro with the commands I mentioned? Are they correct?
These are my stats
Maximum size of core files created                           (kB, -c) 0
Maximum size of a process’s data segment                     (kB, -d) unlimited
Maximum size of files created by the shell                   (kB, -f) unlimited
Maximum size that may be locked into memory                  (kB, -l) unlimited
Maximum resident set size                                    (kB, -m) unlimited
Maximum number of open file descriptors                          (-n) 4864
Maximum stack size                                           (kB, -s) 8192
Maximum amount of cpu time in seconds                   (seconds, -t) unlimited
Maximum number of processes available to a single user           (-u) 709
Maximum amount of virtual memory available to the shell      (kB, -v) unlimited

@barakwei did you add -sdk iphonesimulator??

Here is mine ...
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
file size               (blocks, -f) unlimited
max locked memory       (kbytes, -l) unlimited
max memory size         (kbytes, -m) unlimited
open files                      (-n) 256
pipe size            (512 bytes, -p) 1
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 709
virtual memory          (kbytes, -v) unlimited
Should I update to increase?
On Thu, Feb 16, 2017 at 1:18 PM, Keqiu Hu<EMAIL_ADDRESS>wrote:

@barakwei https://github.com/barakwei did you add -sdk iphonesimulator??
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/bluepill/issues/65#issuecomment-280463768,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJACmTgwYt5nFFzhLd3jBMq8-ES241Kvks5rdL0rgaJpZM4MAyBW
.

@barakwei yah, you definitely missed the -sdk option
In your command:
bluepill -a <Path to derived data>/Build/Products/Debug-iphoneos/BPSampleApp.app -s BPSampleApp.xcodeproj/xcshareddata/xcschemes/BPSampleApp.xcscheme -o ./output
It should be Debug-iphonesimulator instead of Debug-iphoneos
Maybe same to @bnimmagadda

@oliverhu yep, it was the -destination flag.
I now used
xcodebuild -project BPSampleApp.xcodeproj/ -scheme BPSampleApp -configuration Debug -destination "platform=iOS Simulator,name=iPhone 6,OS=latest" build-for-testing
bluepill -a <Path to derived data>/Build/Products/Debug-iphonesimulator/BPSampleApp.app -s BPSampleApp.xcodeproj/xcshareddata/xcschemes/BPSampleApp.xcscheme -o ./output

And it worked perfectly

👍

Thank you so much @Keqiu
It works perfectly now :-)
On Thu, Feb 16, 2017 at 11:08 PM, Keqiu Hu<EMAIL_ADDRESS>wrote:

👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/bluepill/issues/65#issuecomment-280572058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJACmSRL157Tc-AJbeb-nUawbHfrFrVvks5rdUd8gaJpZM4MAyBW
.


[Developer Experience]: Add component test for "About Details" component

Developer Experience Issue
Add a component test for "About Details".
The test should verify the following behavior

an article element is used for the content
Twitter, LinkedIn, and YouTube links exist (see cy.validateLink())
Anything else you can think of that is important, but we don't need to verify all of the text content since it's fine for text content to change without failing a test.

@canourrea23 can you pick this one up?


Implement message queue

Fixes #429
Changes

[x] add Kafka to docker-compose
[x] add Kafka producer to checkoutservice
[x] implement Accountingservice
[x] implement Frauddetectionservice

For significant contributions please make sure you have completed the following items:

[x] Appropriate CHANGELOG.md updated for non-trivial changes
[x] Design discussion issue #429

Hey just an fyi we're on a feature freeze for the next week or 2 due to our upcoming v1 release and kubecon.
Feel free to keep this open and working on it tho!

I wonder why add two new services? Since the checkout service is the only kafka message producer, the two new services are both consumers. What's the point of this?

Async workflows usually have multiple consumers with different use cases.
The intention is to show async with OTEL in a common scenario and that both spans are added to the parent span of the checkoutservice

As mentioned in the CNCF slack channel. We are going to pause adding any new services/components until after we clean up build times and fix multi-arch build. There is plenty of interest to add a message queue system to the demo, but this is also accompanied by several concerns about resource constraints and user experience for those learning or experimenting with the demo in a dev environment.
Given the concerns, can we look into using Kafka Raft (Kafka without zookeeper) to help minimize the footprint of this addition?

Given the concerns, can we look into using Kafka Raft (Kafka without zookeeper) to help minimize the footprint of this addition?

I have tried initially to use Raft, but ran into problems and therefore I have fallen back to the tried and tested methods.
If Resource usage is a concern here, then I will give it another try.

@puckpuck I have changed the setup to use Kafka RAFT instead of Kafka

@secustor - I checked out your fork's branch and ran docker compose up -d on my Mac M1 Pro, i am getting below error likely related to proto file import
[+] Running 0/2
 ⠿ frauddetection Warning                                                                                1.2s
 ⠿ accountingservice Warning                                                                                1.2s
[+] Building 1.9s (31/36)
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.28kB                                                                                0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.31kB                                                                                0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice internal] load .dockerignore                                                                                0.0s
 => => transferring context: 35B                                                                                0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice internal] load .dockerignore                                                                                0.0s
 => => transferring context: 35B                                                                                0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice internal] load metadata for docker.io/library/alpine:latest                                                                                1.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice internal] load metadata for docker.io/library/golang:1.19.2-alpine                                                                                1.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice internal] load metadata for docker.io/library/openjdk:18-slim                                                                                1.7s
 => [auth] library/openjdk:pull token for registry-1.docker.io                                                                                0.0s
 => [auth] library/alpine:pull token for registry-1.docker.io                                                                                0.0s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                0.0s
 => ERROR [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice] importing cache manifest from ghcr.io/open-telemetry/demo:v1.0.0-accountingservice                                                                              0.3s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  1/10] FROM docker.io/library/golang:1.19.2-alpine@sha256:e4dcdac3ed37d8c2b3b8bcef2909573b2ad9c2ab53ba53c608909e8b89ccee36                                     0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice stage-1 1/3] FROM docker.io/library/alpine@sha256:b95359c2505145f16c6aa384f9cc74eeff78eb36d308ca4fd902eeeb0a0b161b                                                     0.0s
 => [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice internal] load build context                                                                                0.0s
 => => transferring context: 476B                                                                                0.0s
 => ERROR [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice] importing cache manifest from ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice                                                                      0.3s
 => [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice internal] load build context                                                                                0.0s
 => => transferring context: 78.87kB                                                                                0.0s
 => CANCELED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice] https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v1.16.0/opentelemetry-javaagent.jar                               0.3s
 => [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice stage-1 1/4] FROM docker.io/library/openjdk:18-slim@sha256:7d2fb53a15fc3574a4e60444526fbc083572a21fec31b68a0c4e5ec0a6689920                                        0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice stage-1 2/3] WORKDIR /usr/src/app/                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice stage-1 2/4] WORKDIR /usr/src/app/                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  2/10] RUN apk add build-base protoc                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  3/10] WORKDIR /usr/src/app/                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  4/10] COPY ./src/accountingservice/ ./                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  5/10] COPY ./pb/ ./proto/                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  6/10] RUN go mod download                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  7/10] RUN go install<EMAIL_ADDRESS>                                                                              0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  8/10] RUN go install<EMAIL_ADDRESS>                                                                              0.0s
 => ERROR [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  9/10] RUN protoc -I ./proto/ ./proto/demo.proto --go_out=./ --go-grpc_out=./                                                                            0.3s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice builder 3/6] COPY ./src/frauddetectionservice/ ./                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice builder 4/6] COPY ./pb/ ./src/main/proto/                                                                                0.0s
 => CACHED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice builder 5/6] RUN chmod +x ./gradlew                                                                                0.0s
 => CANCELED [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice builder 6/6] RUN ./gradlew shadowJar                                                                                0.3s
------
 > [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice] importing cache manifest from ghcr.io/open-telemetry/demo:v1.0.0-accountingservice:
------
------
 > [ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice] importing cache manifest from ghcr.io/open-telemetry/demo:v1.0.0-frauddetectionservice:
------
------
 > [ghcr.io/open-telemetry/demo:v1.0.0-accountingservice builder  9/10] RUN protoc -I ./proto/ ./proto/demo.proto --go_out=./ --go-grpc_out=./:
#0 0.278 google/protobuf/timestamp.proto: File not found.
#0 0.278 demo.proto:17:1: Import "google/protobuf/timestamp.proto" was not found or had errors.
#0 0.278 demo.proto:280:3: "google.protobuf.Timestamp" is not defined.
#0 0.279 demo.proto:281:3: "google.protobuf.Timestamp" is not defined.
------
failed to solve: executor failed running [/bin/sh -c protoc -I ./proto/ ./proto/demo.proto --go_out=./ --go-grpc_out=./]: exit code: 1

@saurabhdes My latest commit should fix your problem.

@saurabhdes My latest commit should fix your problem.

thanks @secustor , yes confirmed all the containers are now starting. Needed clarity on couple of items:

In Jaeger UI - i don't see accountingservice or frauddetection service. So i am wondering if these two services are getting called or if they are then is the instrumentation for them setup correctly.

Can you please elaborate why accountingservice or frauddetection  were created vs. updating communication between existing services to use Kafka (so we need to add just 1 more broker container vs. 3 now). I am assuming it's to minimize complexity in existing services but wanted to get your thoughts.

In Jaeger UI - i don't see accountingservice or frauddetection service. So i am wondering if these two services are getting called or if they are then is the instrumentation for them setup correctly.

These are only called when checking out, I have not digged into the load generators yet.
If manually going through the process they will show up.

Can you please elaborate why accountingservice or frauddetection  were created vs. updating communication between existing services to use Kafka (so we need to add just 1 more broker container vs. 3 now). I am assuming it's to minimize complexity in existing services but wanted to get your thoughts.

My thoughts have been:

minimising complexity as these examples are also viewed as implementation examples and not only as testing platform.  At least I have used it also for this purpose.
implementation of a Kotlin example
There have been no Java/Go microservices which receive have no communication with the frontend.    I'm only aware of instrumentations of Kafka clients for Java and Go.

I have added them ( 927ed69e8a013992c52163e1e68cbd9b59e82c22  &&  d701fe284353ca3310c619d757e8d9b04cc2eee8 ) but they got deleted by merging main. I will add them back in.

In Jaeger UI - i don't see accountingservice or frauddetection service. So i am wondering if these two services are getting called or if they are then is the instrumentation for them setup correctly.

These are only called when checking out, I have not digged into the load generators yet. If manually going through the process they will show up.

Can you please elaborate why accountingservice or frauddetection  were created vs. updating communication between existing services to use Kafka (so we need to add just 1 more broker container vs. 3 now). I am assuming it's to minimize complexity in existing services but wanted to get your thoughts.

My thoughts have been:

minimising complexity as these examples are also viewed as implementation examples and not only as testing platform.  At least I have used it also for this purpose.
implementation of a Kotlin example
There have been no Java/Go microservices which receive have no communication with the frontend.    I'm only aware of instrumentations of Kafka clients for Java and Go.

Thanks @secustor for the detailed reply ! Sounds good.

I found out i was using older image of checkout service. I deleted it and recreated the image from your branch , after that without needing to do any manual checkout, i started to see accountingservice and frauddetectionservice in Jarger flowmap as expected.
I think this is because checkout service is called by loadgen https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/loadgenerator/

locustfile.py#L250

As FYI - In addition to above 2 languages i found Kafka instrumentation for one more language Nodejs https://www.npmjs.com/package/opentelemetry-instrumentation-kafkajs , https://www.aspecto.io/blog/opentelemetry-kafkajs-instrumentation-for-node-js/

we should test the build time increase from 3 new containers. One thing to keep in mind is that go doesn’t have an operator instrumentation option. We’d need to implement that with the Java service or replace Go

For the architecture docs and services table my bias would be to label the language Java not Kotlin for the fraud detection service

I have tested builds again this branch and main.
Setup:

Mac M1
ContainerRuntime:

DockerDaemon: Colima
8 GB RAM
4 Cores
100 GB Disk

Methodology
Run docker system prune --force && docker-compose build --no-cache
implemented changes:

12m 11s
13m 22s

main ( 5a2c0efa923f18bc1f5ae12bbd1843619b351ece ):

12m 30s
12m 58s

So there are no relevant changes. The limiting factor is the build time for the currency service.

For the architecture docs and services table my bias would be to label the language Java not Kotlin for the fraud detection service

I prefer to use Kotlin as this signals that multiple JVM languages are supported. An alternative would be to rename JAVA to JVM

From the  Google docs:

Merge PR then re-write new service?

@julianocosta89  @cartersocha  @puckpuck I have not been able to join the SIG Meeting, is there a decision to rewrite accountingservice in Python before or after merge?

The goal is to get this PR merged this week with Go for the accountingservice
After the merge, we will rewrite the service in another language that can be auto-instrumented with the OpenTelemetry Operator. We may want to document that as part of this PR so expectations are set with the broader community.

🎉


check $TRAVIS_REPO_SLUG

I want to execute travis-ci job in my fork repository. but "publish" task fail

TRAVIS_REPO_SLUG: The slug (in form: owner_name/repo_name) of the repository currently being built.

https://docs.travis-ci.com/user/environment-variables/

LGTM! Many thanks ... merging :-)


[Feature Request]: support Markdown syntax

I often use ChatGPT to help me solve coding problems. However, the support for Markdown syntax on TavernAI is not very good. I hope TavernAI can also support Markdown well, just like in the picture.
Thank you!

Code support was added in 1.4.0


Propagate tabindex prop to editor's scroll container

Until now the tabIndex isn't being propagated to the editor's scroll dom node (which is typically a <div> with contenteditable="true" and can thus be focused via keyboard tabbing). With this change we're propagating the tabindex to said dom node to establish a working tabindex for the editor.
Note: Quill unfortunately doesn't provide an API to set the editor's tabindex, so we have to override it directly on its dom node. Not sure if there's a better place to do it.
Also see https://github.com/zenoamaro/react-quill/issues/232#issuecomment-369199337

Hey I just ran into this same issue, the tabIndex needs to be put on the contenteditable div, not the editor itself.


Add CompareSymbol and AppendSymbol

Adding here as we depend on Type.Data.Ordering for CompareSymbol.
We could also merge purescript-symbols into here in the same PR?

I think this is good as-is for now, thanks. I don't think we should merge symbols just yet since generics-rep depends on it, for example.


Upload ONT data to DDS

Get project info from order portal
Create a delivery project with DDS
Upload the staged data to DDS

Codecov Report
Attention: Patch coverage is 0% with 126 lines in your changes missing coverage. Please review.

Project coverage is 27.31%. Comparing base (6277412) to head (35e2b64).
Report is 21 commits behind head on master.

Files with missing lines
Patch %
Lines

taca/delivery/delivery_classes.py
0.00%
108 Missing :warning:

taca/delivery/cli.py
0.00%
13 Missing :warning:

taca/delivery/deliver.py
0.00%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   27.95%   27.31%   -0.65%
==========================================
  Files          37       37
  Lines        5204     5326     +122
==========================================
  Hits         1455     1455
- Misses       3749     3871     +122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


iter -> iter, use picklable_itertools.xrange

Sorry, merge conflicts because I just merged #29

Woops. Merge conflicts. Hold on.

Travis failure due to transformers rename. Force-pushed a rebase.

Haha, sorry, this is turning into a really complicated 5-line PR :p
On Feb 27, 2015 6:06 PM, "David Warde-Farley"<EMAIL_ADDRESS>wrote:

Travis failure due to transformers rename. Force-pushed a rebase.
—
Reply to this email directly or view it on GitHub
https://github.com/bartvm/fuel/pull/30#issuecomment-76489755.

Looks like it passed.


Allow natural primary keys - see #67

As discussed in https://bitbucket.org/tabo/django-treebeard/issue/67/treebeard-admin-cannot-work-with-custom-pk I think it is now safe to use self.instance._state.adding to determine whether the object already exists in the database

Is there anything additional that I need to do in order for you to merge this?
Thanks
Roger


Merge Opensource branch into master for using omr-agentcore

omr-agentcore has now been opensourced so this change is to make appmetrics use this as a subcomponent

Tested installing from branch, looks good.


Showing left view controller shows a black screen

I use this to create a left menu:
        if let viewController = UIViewController.instantiate(type: .menu) as? MenuViewController {
            guard let mainViewController = navigationController?.childViewControllers.first else {
                return
            }
            viewController.view.backgroundColor = UIColor.green
            sideMenuController = LGSideMenuController(rootViewController: mainViewController, leftViewController: viewController, rightViewController: nil)
            sideMenuController?.leftViewWidth = 250.0
            sideMenuController?.leftViewPresentationStyle = .slideAbove
            sideMenuController?.showLeftViewAnimated()
        }

The navigation controller is the root view of the UIWindow, and main view controller is the only view controller from the childViewControllers.
The result is a black screen
I also tried to send rootviewcontroller as nil but no effect, a black view is setting under the app main view controller

I have faced same issue, it is showing black screen instead left menu VC.

Should be fixed in the new version. Please validate.
Feel free to reopen if the issue is still reproducible.


Missing demo

Wouldn't be useful to put an img on the README or a live demo?

+1

+1. You just just need to do something like ![BarFunnel Example Image](barfunnel.png)

@roccomuso @benmccann I'm happy to merge a PR adding something

Visual example would be nice, because I don't know if this is what I need!

https://embed.plnkr.co/KrdbEu9Ftn08Sq55qf4i/


The client.refreshDeadline method should not be used within the client.WritePacket method. It will cause the device to be online for a long time even if it is offline

// WritePacket encodes and writes a packet to the client.
func (cl *Client) WritePacket(pk packets.Packet) error {
	if atomic.LoadUint32(&cl.State.done) == 1 {
		return ErrConnectionClosed
	}

	if cl.Net.Conn == nil {
		return nil
	}

	defer cl.refreshDeadline(cl.State.keepalive)
	....
}

Hi @yemaozihecha! This is an interesting find. Originally, the logic behind this is that the client deadline should be extended if the server successfully communicates/writes a packet to the client. However, in this case the defer statement means refreshDeadline is called even if the write failed.
I will remove the defer statement and relocate the statement until after successful packet transmission.
Thank you!

This should be resolved in v2.1.7

The more I have thought about this, the more I am thinking we no longer need refreshDeadline in write, as we should be resetting it whenever we receive a ping request from the client. I may remove it in v2.2.0 which involves the changes for #150

I think it should be used in client.ReadPacket, because the client's ping request can let you know whether the client is alive, but it is not needed in client.WritePacket.

In v2.2.0 in #165 I have remove the refreshDeadline from client.WritePacket, as you are correct @yemaozihecha - hopefully it will be released soon, if not I will issue it as a separate minor release.

This is resolved now in https://github.com/mochi-co/mqtt/releases/tag/v2.2.0 - thank you for highlighting it @yemaozihecha!


Filter attempt from the authentication_check options

Various implementations of verify_credentials aren't expecting an
:attempt => 1 hash key/value.
It's only used at a higher layer so exclude it from the
authentication_check call.
https://bugzilla.redhat.com/show_bug.cgi?id=1402035
This was a regression introduced in #11964

Added blocker label since this would cause all rhev/ovirt providers to have their authentications fail with an Error.  That could cause various workers for these providers to not start if they require valid authentications.

Euwe Backport details:
$ git log -1
commit 1c5ba9dfdf47f149f7f77ae4dcc6f1298e185309
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed Dec 7 10:40:55 2016 -0500

    Merge pull request #13026 from jrafanie/filter_attempt_from_authentication_check_options

    Filter attempt from the authentication_check options
    (cherry picked from commit 786244f0a911d28cc65fcffdb085375c19242500)

    https://bugzilla.redhat.com/show_bug.cgi?id=1402887


How  toWeb Browser Collects Data

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

How  to use version_8.2.0   Web Browser Collects Data

https://github.com/apache/skywalking-client-js