Why use AMD?

Why not just include ngTranslate as a normal angular module, like every other standard module? Why bother with AMD? It just breaks Karma/Jasmine/Require. Every ANGULAR lib I've tried to incorporate that uses AMD breaks Karma or Jasmine unless I delete the AMD stuff, then that breaks the submodule pattern to manually include them. This is on multiple projects, and I've heard other developers gripe about this.
I load everything through require config in my specs...
Am I missing something?
/*!

angular-translate - v2.7.2 - 2015-06-01
http://github.com/angular-translate/angular-translate
Copyright (c) 2015 ; Licensed MIT
*/
(function (root, factory) {
if (typeof define === 'function' && define.amd) {
// AMD. Register as an anonymous module unless amdModuleId is set
define([], function () {
return (factory());
});
} else if (typeof exports === 'object') {
// Node. Does not work with strict CommonJS, but
// only CommonJS-like environments that support module.exports,
// like Node.
module.exports = factory();
} else {
factory();
}
}(this, function () {

It just breaks Karma/Jasmine/Require.

No, not really. ;)
What you see is the UMD header which contains three things (it's actually explained in the code you have copied): AMD header, CommonJS and standard environment. Both AMD (i.e. RequireJS) and CommonJS are optional used so it will breaking nothing. Said this, this will not break neither Jasmine or Karma. Actually, Jasmin will not load modules.
These files can be loaded just like "regular" files and everything works as expected. You can see everything works because everyone use these files, as well on our own as  in public plnkr/jsfiddle demo setups. In these situations like plnkr no AMD or CommonJS is used.
Perhaps you will tell us what exactly is going wrong?

Mismatched anonymous defines. Don't get this with other libs. Only angular translate and ng-table, which support AMD. They are tagged included in Karma (still loaded just with HTML), but still fail. I've seen this happen with several projects with different configs and environments.
Below is the jasmine 2 config for grunt-contrib-jasmine and the karma.conf for Karma tests (running in phantom)
jasmine: {
src: [
'./src/main/app//*[^(.Int)].js',
'./src/main/commons//*[^(.Int)].js',
'./src/templates.js',
],
options: {
keepRunner: true,
build: true,
vendor: [
//'src/main/resources/lib/jjv.js',
'src/bower-lib/jquery/jquery.js',
'src/main/resources/lib/nanoScroller.js',
'src/bower-lib/angular/angular.js',
'src/bower-lib/angular-mocks/angular-mocks.js',
'src/bower-lib/angular-resource/angular-resource.js',
'src/bower-lib/angular-route/angular-route.js',
'src/bower-lib/angular-loader/angular-loader.js',
'src/bower-lib/angular-cookies/angular-cookies.js',
                'src/main/resources/lib/debugger/dimple.v1.1.2.min.js',
                'src/main/resources/lib/Stacktrace.js',

                //'src/bower-lib/stacktrace-js/dist/stacktrace.js',

                'src/main/resources/lib/angular-translate.js',
                'src/main/resources/lib/angular-translate-loader-static-files.js',

                'src/main/resources/lib/i18n/angular-locale_en-us.js',
            ],
            // we don't need this now that specs are in src
            //specs: 'src/**/*.Spec.js',
            helpers: 'src/**/*.Helper.js',
            host: 'http://<IP_ADDRESS>:8000/',
            template: require('grunt-template-jasmine-requirejs'),
            templateOptions: {
                requireConfig: {
                    baseUrl: '.grunt/grunt-contrib-jasmine/',
                    paths: {
                        // External libraries
                       // 'jjv': 'src/main/resources/lib/jjv.js',
                        'jQUery':   'src/bower-lib/jquery/jquery',
                        'nanoScroller': 'src/main/resources/lib/nanoScroller',
                        'angular': 'src/bower-lib/angular/angular',
                        'angularCookies': 'src/bower-lib/angular-cookies/angular-cookies',
                        'angularMocks': 'src/bower-lib/angular-mocks/angular-mocks.js',
                        'angularResource':  'src/bower-lib/angular-resource/angular-resource',
                        'angularRoute':  'src/bower-lib/angular-route/angular-route',
                       // 'angularScenario': 'src/main/resources/lib/angular-1.2.23/angular-scenario',
                        'pascal': 'src/bower-lib/angular-translate',
                        'translateStaticFilesLoader':'src/bower-lib/angular-translate-loader-static-files/angular-translate-loader-static-files'
                    },
                    shim: {
                        'angular': {
                            'exports': 'angular'
                        },
                        'jQuery': {
                            'exports': '$'
                        },
                        'nanoScroller': {
                            deps: ['jQuery']
                        },

                        'angular-ui.utils': {
                            deps: ['angular']
                        },
                        'angularMocks': {
                            deps: ['angular'],
                            'exports': 'angular.mock'
                        },
                        'angularResource': {
                            deps: ['angular'],
                            'exports': 'angular.resource'
                        },
                        'angularRoute': {
                            deps: ['angular'],
                            'exports': 'angular.router'
                        },
                        //'angularScenario': {
                        //    deps: ['angular'],
                        //    'exports': 'angular.scenario'
                        //},
                        'angularTranslate':{
                            deps: ['angular'],
                            'exports':'pascalprecht.translate'
                        },
                        'angularCookies':{
                            deps: ['angular'],
                            'exports':'ngCookies'
                        },
                        'translateStaticFilesLoader':
                        {
                            deps:['angular'],
                            'exports':'translateStaticFilesLoader'
                        }

                    }
                }
            }
        }

    },

// ALSO just loading files directly in karma fails.
//
//
//
//
module.exports = function(config) {
var conf = {
    basePath: '',
    singleRun: true,
    files : [
        // we can't do them all because it breaks
        {
            pattern: 'src/bower-lib/jquery/jquery.js',
            included: true
        },
        {
            pattern: 'src/main/resources/lib/nanoScroller.js',
            included: true
        },
        {
            pattern: 'src/bower-lib/angular/angular.js',
            included: true
        },
        {
            pattern: 'src/bower-lib/angular-mocks/angular-mocks.js',
            included: true
        },
        {
            pattern: 'src/bower-lib/angular-resource/angular-resource.js',
            included: true
        },
        {
            pattern: 'src/bower-lib/angular-route/angular-route.js',
            included: true
        },
        {
            pattern: 'src/bower-lib/angular-cookies/angular-cookies.js',
            included: true
        },
        {
            pattern: 'src/main/resources/lib/Stacktrace.js',
            included: true
        },
        {
            pattern: 'src/main/resources/lib/angular-translate.js',
            included: true
        },
        {
            pattern:'src/bower-lib/angular-translate-loader-static-files/angular-translate-loader-static-files.js',
            included: true
        },
        //bake down the templates
        {
            pattern: 'src/main/**/*.html',
            included: false
        },
        {
            pattern: 'src/main/**/*.gif',
            included: false
        },
        {
            pattern: 'src/main/**/*.Int.js',
            included: false
        },
        {
            pattern: 'src/main/app/**/*.js',
            included: true
        },
        {
            pattern: 'src/main/commons/**/*.js',
            included: true
        },
        {
            pattern: 'src/main/resources/lib/i18n/angular-locale_en-us.js',
            included: false
        },
        {
            pattern: 'test/KarmaSpecRunner.js',
            included: true
        },
        {
            pattern: 'src/templates.js',
            included: true
        }
    ],
    exclude: [
        'lib/angular-1.2.16/docs/**/*.*',
        'lib/angular-1.2.16/**/*min.js',
    ],
    plugins: [
        'karma-jasmine',
        'karma-phantomjs-launcher',
        'karma-requirejs',
        'karma-chrome-launcher',
        'karma-js-coverage'
    ],
    frameworks: [
        'jasmine',
        'requirejs'
    ],
    browsers: [
        'PhantomJS'
    ],
    preprocessors: {
        'src/main/app/**/!(*Spec|RangeSlider|DebuggerController*)+(.js)': ['coverage'],
        'src/main/commons/**/!(*Spec|SchemaDefinitions|Scrollable|Debug|DynamicLocale*)+(.js)': ['coverage'],
    },
    coverageReporter: {
        type: 'lcov',
        dir: 'test/coverage/'
    },
    reporters: [
        'dots',
        'coverage'
    ]
};

config.set(conf);

};

Mismatched anonymous defines.

What does this mean?
I'm sorry, but an UMD header is not uncommon and breaks not an existing environment. Well, unless you have indeed a AMD/CJS look-a-like env (i.e. having a define function in gloal scope) being not AMD. But that should not be the case.
I cannot extract a piece of qualified information of your ocnfigs, because I cannot look into it. However, you are in charge. If you are really sure the UMD header is the issue, you must be able trace the call of define in a debugger. And then: Which component provides it? Perhaps you have such a module system enabled?
Again: If this would be a common problem, you would not be the first one reporting it and all demonstration would fail (plnkr/jsfiddle are mostly w/o an AMD system installed)

I have just updated to 2.7.2 and I use requirejs for a lot of my projects. Everything with the changes made work well. Although, when I compile the code down and mix in to 1 file I get an exception "angular is not defined". I believe the issue comes from these lines:
define([], function () {
return (factory());
});
I believe angular needs to be passed in as a dependency, then passed in to the factory as a param. IE:
define(["angular"], function (angular) {
return (factory(angular));
});
I believe until this is fixed, I will have to revert to an older version.

@nthibert If you are really using RequireJs, you will probably know the paths config option.
We could require angular, but unless they support this directly, the current thing is more convenient.

Where are these jsfiddles or plnkrs that use Jasmine + angular translate? The ones on the demos page do not include jasmine. https://github.com/angular-translate/angular-translate/wiki/Demos.
Like I said, this is a failure when trying to use with Jasmine/Require. If there was an example that would be great. Maybe I'm totally off base, but I don't have a good working scenario to look at. thanks for you time!

I'm very sorry in case someone has problems with that.. but, really really, there is no fail (at least for us).
Again: People in the world using this for years, not only in this library but also in many other libraries, without any complaints. As you repeatedly pointing the finger at us, I will make it straightforward: The problem is on your side.
Regarding examples: Well obviously, we have no Jasmine tests on JsFiddle/Plnkr but regular demonstrations of code/usage scenrios examples at angular-translate.github.io as well as as several OTR demos: see here, here, here, here or here. These are my latest ones, that's sufficient.
Regarding Jasmine tests: Well, the easiest way is looking at our tests actually. We do not use RequireJS or any other module system, and, guess what, there is no problem.
(Please do not being confused with the scope's stuff, that is a little hack for testing against different types of AngularJS releases. More or less it's only a path-to-library resolver.)

One personal addition:
I don't know what you are thinking what magic a module loader is doing. At the end of the day, it's only a set of functions which executes code, reads dependencies specs and injects <script> tags (in case of a browser environment). No magic, just JavaScript code. Said this, if you have issues with loading such standard libraries, you must have installed and enabled such a module loader. Or you have defined the expected objects/functions. You can have a look at the UMD header: It is a simple and clean 3-way-branches-condition. I cannot debug your code, but you have access and can looks what happens there.
A module loader like RequireJS is great for bigger projects (at least in times before ES6+ modules). Despite that I highly recommend to understand what it is doing for you, what it can do for you.. and what it cannot do for you.

And here we go, a JSFiddle with Jasmine tests. It uses not the latest ones, that's a fast and messy prototype.

Thanks for the example! I have configured (in my case) grunt-jasmine and karma-requirejs properly. There was a problem with the requirejs shim for Karma. Jasmine was trying to both load it from plain js resource and load it as a module, I think.

@knalli Thanks for all the responses. I do have to disagree with your statement that the problem is on our side (there are some problems but I fix those ;) ). I may have not explained my situation properly. As I do know the paths property for requirejs. We implement this lib around the 2.5.x mark. While the implementation went smooth because we used a shim. Also, I like to tell you that we are using r.js to compile everything down into 1 file. The other day, I change the version to 2.7.2. This is when the error of "angular is not defined" appeared. So when I went looking, I found that when you used the UMD and then I compiled everything into 1 file (where angular is getting compiled into the same file) angular was not part of the closure or the global space. So everything started failing. So after your first message, I tried my approach and referred to another angular lib that is doing the same sort of thing (ng-table) and it worked. I think when it comes to using the UMD with AMD to not assume angular is loaded in the global space. Below is the implementation I spoke of.
(function (root, angular, factory) {
    if (typeof define === 'function' && define.amd) {
        // AMD. Register as an anonymous module unless amdModuleId is set
        define(["angular"], function (angular) {
            return (factory(angular));
        });
    } else if (typeof exports === 'object') {
        // Node. Does not work with strict CommonJS, but
        // only CommonJS-like environments that support module.exports,
        // like Node.
        module.exports = factory(angular);
    } else {
        factory(angular);
    }
}(this, window.angular || null,  function () {})

Please let me know if there is another way around this. Where I need to compile angular and angular-translate into the same file.
Your code is rock solid and easy to use. Please don't consider this as a personal issue. We are peers just reviewing code and making suggestions.
Thanks for the hard work.

Please don't consider this as a personal issue.

No worries.

Also, I like to tell you that we are using r.js to compile everything down into 1 file.

I'm doing this as well. Unfortunately, several libraries are not compatible (and not declaring its dependencies) which results into a config with paths. Obviously, we don't declare angular, also. The reason is that I'm not sure what we should do. Does the name angular is globally the name for AngularJS? Or angular.js? Or angularjs? At the moment everyone can use its own name.
I'm not happy with the current one, but on the other side I do not want to force someone to name its dependencies. Thoughts?

Turns out I had used 2.5.2 instead of 2.7.2. When I said it worked, Bower was always using the old version due to another dependency by translate-loader. After manually copying  the UMD version (2.7.2) over, we get the error that the module cannot be found at all. So, what is the reasoning behind using UMD? How could this be resovled in Karma?
This is the current Karma runner requirejs config:
requirejs.config({

    baseUrl: '',
    paths: {
        // External libraries
        'angular': '/base/src/bower-lib/angular/angular',
        'jQuery':'/base/src/bower-lib/jquery/jquery',
        'angularMocks': '/base/src/bower-lib/angular-mocks/angular-mocks',
        'angularCookies': '/base/src/bower-lib/angular-cookies/angular-cookies',
        'frisby': '/base/test/lib/frisby',
        'pascalprecht.translate': '/base/bower-lib/angular-translate/angular-translate',
        'angucomplete-alt': '/base/bower-lib/angucomplete-alt/angucomplete-alt' // THIS LIB HAS SAME PROBLEM
    },
    shim: {

        'frisby': {'exports': 'frisby'},

        'angular': {'exports': 'angular'},
        'angular-ui.utils': {deps: ['angular']},
        'angularMocks': {deps: ['angular'], 'exports': 'angular.mock'},
        'angularCookies': {deps: ['angular'], 'exports': 'ngCookies'},
        'angucomplete-alt': {deps: ['angular'], 'exports': 'angucomplete-alt'},
        'pascalprecht.translate': {deps: ['angular'], 'exports': 'pascalprecht.translate'},
        'jQuery': { 'exports':'$'}    ,

    },

    // Ask Require.js to load these files (all our tests).
    deps: dependencies,
    // Set test to start run once Require.js is done.
    callback:window.__karma__.start
});

*addendum: seems to work fine in Jasmine, for some reason only the Karma runner has this issue.

@vance  We have already pointed out the issue is not UMD nor angular-translate. I'm sorry, but I'll close this issue now. If you have general issues understanding UMD, AMD or any other module concepts, I'll recommend stackoverflow with a much greater use base.
Thank you in advance.

That's usually my first resource, and I've exhausted it. I've got a few thousand points there, i'm no stranger =)Thanks for looking at this. I guess I can chalk this up to having some dependency error and maybe need to update Karma and RequireJS, though its only a minor dot version upgrade.  Seeing as all my other dependencies work fine, i'm going to downgrade to translate 2.5.

http://i.imgur.com/bKGj4no.jpg?1

First things first: Without the r.js optimizer and trying to include all modules in one file, everything works fine.
Assuming you use the r.js optimizer and the mainConfigFile for configuration, you maybe want some setup likes this:
You want to use one module name (AMD module id) and get all dependencies in the right order. (for the „name“ property in the options in r.js)
Lets call this „appStarter“, by which the optimizer should put all modules in the right order (because of putting all modules in one big file).
Non AMD dependencies should be defined in the shim of the require config file and your app dependencies from the main app module.
Like this:
require.config({
...
	paths: {
		appStarter: „./app“
	},
	shim: {
		appStarter: {
			deps: [„angular“]
		}
	}
...
});

Setting this up we get the non AMD dependencies first in the file and then the rest modules defined in the app.js in the right order.
But now, if you want to load, say some service for the translate-module e.g. „storage-local“, you need to define the dependency on the angular-translate module, so it is loaded after the translate module. But now the translate module has to be defined in the shim.
And the output, from before:
define([], function () {
    return (factory());
});

becomes:
define('angularTranslate',[], function () {
    return (factory());
});

And now, instead of being directly invoked from the IIFE, the module just get assigned and the factory function isn’t called, therefore getting this message:
Module 'pascalprecht.translate' is not available!
angular-translate.js
Fix 1
Just calling factory after this define calls the factory and the angular module is defined.
Fix 2
Just remove everything before the module declaration (and at the bottom, the rest of the top function)
r.js:
...
name: "appStarter",
insertRequire: ["appStarter"],
out: "app/build.js",
skipModuleInsertion: true,
...

require.config
{
    paths: {
        "appStarter": "./app",
        "angular": "../assets/libs/angular/angular",

        "angularTranslate": "../assets/libs/angularTranslate/angular-translate",
        "angularTranslateLoaderPartial": "../assets/libs/angularTranslate/service/loader-partial",

        "angularTranslateCookie": "../assets/libs/angularTranslate/service/storage-cookie",
        "angularTranslateLocal": "../assets/libs/angularTranslate/service/storage-local",
        "angularCookies": "../assets/libs/angular/angular-cookies.min"
    },
    shim: {
        "appStarter": {
            deps: [
                "angular",
                "angularCookies",

                "angularTranslate",
                "angularTranslateCookie",
                "angularTranslateLocal",
                "angularTranslateLoaderPartial"
            ]
        },
        "angularCookies": {
            deps: ["angular"]
        },

        "angularTranslate": {
            deps: ["angular"]
        },
        "angularTranslateCookie": {
            deps: ["angularTranslate"]
        },
        "angularTranslateLocal": {
            deps: ["angularTranslate"]
        },
        "angularTranslateLoaderPartial": {
            deps: ["angularTranslate"]
        }
    }
}
...

Any better ideas? Thanks in advance!

@Stefan-Rein: I don't understand both "fix solutions", but the RequireJS configuration looks fine; you don't have to shim your own app (however somehow  it would make sense). Shimming the libraries as business as usual.
@Stefan-Rein @vance I'm still not getting the problem. Can we please make up an isolated prototype (small as possible) for this? Eventually the best case would be (adhoc) repository here at github.

Hey, thanks for the fast answer!
I try to describe the problem:
With the above described setup and the original angular-translate module (v.2.7.2) my SPA crashes with following error:
Module 'pascalprecht.translate' is not available!
With the "fix solutions" the occurring error doesn't come up, everything work as expected.
I'm setting something up.

Here is a repository:
https://github.com/Stefan-Rein/angular-translate-requirejs-problem
Please do the following:
index.html (now working, default loading with require):
´Comment current script tag out and use the build.js script tag´
You get an error in the console, app crashes.
Now go in: assets/libs/angularTranslate/angular-translate.js
´And add outcommented the line 15´
OT: You're from Hannover, too?

@Stefan-Rein Okay, two points.
At first: Perhaps that is only an issue in this demo, but... why do you inject source files from angular-translate instead of using bower or npm? At least files in sub directory service/ are not part of any distribution.
Secondly: I've revisited the output (build.js). Your main entrypoint does not have any dependencies in the target artifact
define('appStarter',[
        "./controller/AppController",
    ],
    function (
        AppController
    ) {

Unless you define global dependencies on startup, each module should declare its own dependencies (even angular).
Basic solution: Define at least angularTranslate
define('appStarter',[
        "./controller/AppController",
        'angularTranslate'
    ],
    function (
        AppController
    ) {

@knalli I just copied some files around for example - but yes, I would use npm and include the plugins.
Your solution is working. My fault was to think it should be enough to declare the angularTranslate dependency just in the shim of the config.js for the appStarter.
But of course since your plugins are AMD, I need to call them.
Thank you! Maybe the ones above had the same problem and it could save someone some time with the same issue.


Feature/task 4960 : maven and spring profiles

[XXXX- - Please use the Work Item number and Title as PR Name, not subtasks]
📲 What
maven and spring profiles
🤔 Why
Why it's needed, background context.
🛠 How
More in-depth discussion of the change or implementation.
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵 How to test
Notes for QA
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

/azp run

Also looks like there are Snyk issues that need addressing :-(

/azp run

/azp run

/azp run


[samples] (CSV Parsing) Adding error text and alternate script

Fixes #417.
If the user's CSV data is in an irregular shape, this script doesn't work. To help customers adopt the sample into their own code, I've explained the error message they'll get and added an alternate version of the script.
Note to reviewers, if you want to quickly test the script, replace the line csv = csv.trim(); with csv = "x,y,z\r\nd,r";

Docs Build status updates of commit 3c9d5e4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/convert-csv.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 08ce8d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/convert-csv.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Looking for improvements

Enable auto-width to display the project name. Currently if the project name is too long, only part of it can be displayed.
Enable category to manage all projects
Enable category to manage all expectations
Show current client verison in "Help" menu so that users know whether they need to update
Enable Chinese language support if possible which I can help with it, along with a language switch button
Enable export and import configs as files so that users can share with each other quickly
Custom sort for expectations for better management
Enable Redirect in actions
Enable request header setting while proxying if possible, as sometimes it requires valid referer to access the server（important）
Enable project deletion

Thank you for your valuable suggestions. The features you mentioned, I will consider implementing them in future versions.

Thank you for your valuable suggestions. The features you mentioned, I will consider implementing them in future versions.

glad to hear that, it's a nice repo, no need nginx now

glad to see there has been new updates recently, looking for deskapp release

I will release a new version as soon as possible.


Problem running npm setup

When I run npm setup, I get the below error after entering values for the prompts (last prompt was for SMTP password). Any thoughts on what I could be doing wrong?
fs.js:491
  binding.open(pathModule._makeLong(path),
          ^
TypeError: path must be a string
    at TypeError (native)
    at Object.fs.open (fs.js:491:11)
    at Object.fs.readFile (fs.js:262:6)
    at Array.Async.auto.createConfig (/Users/timyork/WebstormProjects/aqua/setup.js:98:12)
    at listener (/Users/timyork/WebstormProjects/aqua/node_modules/async/lib/async.js:582:42)
    at /Users/timyork/WebstormProjects/aqua/node_modules/async/lib/async.js:526:17
    at _arrayEach (/Users/timyork/WebstormProjects/aqua/node_modules/async/lib/async.js:78:13)
    at Immediate.taskComplete (/Users/timyork/WebstormProjects/aqua/node_modules/async/lib/async.js:525:13)
    at processImmediate [as _immediateCallback] (timers.js:367:17)

npm ERR! Darwin 14.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "setup"
npm ERR! node v0.12.5
npm ERR! npm  v2.11.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>setup: `./setup.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>setup script './setup.js'.
npm ERR! This is most likely a problem with the aqua package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./setup.js

Thanks for creating an issue and reporting this.

This is fixed now.

Thanks for the quick response!


[Fix bug 1216291] Fix photo field definition in users api serializer.

Verified it locally:

Checkout to master

GET <IP_ADDRESS>:8000/api/v2/users/<user_id> with users's photo field permissions higher than the permissions of the API key used

traceback

Checkout to this PR

GET

no traceback

@akatsoulas r?

Reproduced this locally with the steps above. r+ :beer:


Updating Post Structure

@stefan-kenyon I added material UI to the project.
I also updated version of dotnet core, so after merging this into a local branch make sure you download the new version from this website.
https://dotnet.microsoft.com/download/dotnet-core/3.0
In the change I had to redo the data migrations. So you'll have to recreate your database.
Manually delete through SSMS
Create a new database with TinRollDb.
Run the ./updateDatabase.ps1 script to recreate the database.
Let me know if you have any questions.


Serialization.

What is the canonical way to serialize/deserialize CNL types?
Its not entirely clear how to access the underlying data structures from the documentation or construct cnl objects from raw bytes. a concise example would help, similar to existing examples.
What environment are you working in?
gcc 8+

Hi.
Thanks for the suggestion. A similar question has been asked before in #401. That answer may help.
Because they are class templates - and not strictly types themselves - it means that ability to serialise depends on the numeric type with which they are specialised. So if you specialise with an easily serialisable type, e.g. int, then you can do as you would normally, e.g. the example from fstream::write
#include <iostream>

int main()
{
    int n = 0x41424344;
    std::cout.write(reinterpret_cast<char*>(&n), sizeof n) << '\n';
}

should work just fine with scaled_integer of int:
#include <cnl/all.h>
#include <iostream>

int main()
{
    cnl::scaled_integer<int, cnl::power<-16>> n = 16706.26275634765625;
    std::cout.write(reinterpret_cast<char*>(&n), sizeof n) << '\n';
}

(example)
But if you use something non-trivial, e.g. a number type containing a pointer to dynamic memory, that's a bad idea!
Action: add serialisation FAQ to front page.

Thank you. This helps.

 Thanks for closing the issue. Ppl often don't. However, in this instance, I'm going to keep it open as a reminder to change the FAQ. After all, you're the second person to ask about it!


Architecture characteristics https://github.com/iptch/2022-fall-architectural-katas/blob/main/domain/resources/architecture-style-decision.png

I added the Architecture Style image but I didn't highlight the characteristics since they didn't match what the stylesheet has. I will review and propose a change

Added the new image checking the 3 styles selected and highlighting the first 4 arch characteristics


low memory limit for the quarkus devfiles which results in OOM during execution of the 'init-compile' command

/kind bug
Which area this bug is related to?

/area registry

Problematic devfiles:

https://registry.devfile.io/devfiles/java-quarkus
https://registry.devfile.io/viewer/devfiles/Community+code-with-quarkus (references https://registry.devfile.io/devfiles/java-quarkus as parent)

Bug Summary
memory limit set in the devfile for tools container is 512Mb which is failing on startup with:
Detected unrecoverable event FailedPostStartHook: Exec lifecycle hook ([/bin/sh -c cd $PROJECTS_ROOT mvn -Dmaven.repo.local=/home/user/.m2/repository compile]) for Container "tools" in Pod "workspace23fd164cde3a477d-6bd5cf85ff-6tzdz_ibuziuk-che(9d894efc-bd8f-4e10-984c-aa2312bf17bd)" failed - error: command '/bin/sh -c cd $PROJECTS_ROOT mvn -Dmaven.repo.local=/home/user/.m2/repository compile' exited with 137: , message: ""

memoryLimit: 512Mi ## default app nowhere needs this but leaving room for expansion.

To Reproduce:
Start quarkus devfile with Eclipse Che

Expected behavior
Workspace is started without problems
Suggestion on how to fix the bug
Increase memory limit for the tools container

Does Che have an extra requirement on memory usage when running the samples? These samples were run by odo and ODC without a problem. I wonder why it requires more memory when running on Che.

not sure what exactly is wrong with the devfile, but the main point is that all the samples should be tested across all the tools that are using the samples devfiles on OpenShift.

We should try to figure out why the memory limit is not enough for Che if in all other cases it is OK.
How Che translates resource limits to the containers?
We should not just blindly increase limits if we don't know what is happening.

init-compile works fine now. we currently add memory on top of the devfile mem request to run the IDE (the amount of memory depends on the IDE). Now, if the user adds IDE plugins/extensions that consume a lot of RAM (e.g. vscode-java), he/she can still get an OOM but I think that's ok.


Bug with KeyboardDragListener with event bubbling and tabbing with shift

I noticed this while testing in ph-scale. If you shift tab back to the dropper node, it will move slowly as if shift is still pressed down. @pixelzoom fyi.
This is happening in ph-scale because the dropper button comes after the dropper node in the traversal order and the dropper button is a child of the dropper node.

Shift key is pressed while focus is on the dropper button and shift gets added to the KeyboardDragListener.keyState.
Tab is pressed on the dropper button and focus moves to the dropper Node
Shift is released and we never get a keyup event for it

So shift is still in the keystate and the KeyboardDragListener is stuck in slow mode. I think the lack of keyup event for shift release after shift + tab is a browser behavior that we cannot fight. This isn't happening for most other usages of KeyboardDragListener because the keystate is cleared on blur. But blur doesn't bubble so we don't get the blur event when tabbing back from the child to the parent. I think the fix is to clear the keystate on focusout which does bubble.

focusout works well and fixes the problem. @zepumph can you please check this change? I tested local test-server, usages of GrabDragInteraction and other usages of KeyboardDragListener. It seems pretty safe to me.

So if I understand correctly, this was occurring because of how the button was on a child node. Makes sense! Good and elegant fix. I can't think of any other spots where having a focusout there will be buggy or too powerful. Ready to close. Thank you

You understand correctly! Thank you for reviewing. Closing.


Register RNASeq-CGL to Dockstore

some tweaks will be required, pull request back to John

Related to https://github.com/BD2KGenomics/core-operations/issues/39


Don't recompile XSpec to XSLT when XSpec hasn't changes

When XSpec file hasn't changed between running and rerunning tests, don't recompile XSpec to XSLT. This will make the test faster and makes TDD easier.

That will definitely help. I'll look at it as soon as I get the chance.


Dependency on outcated core-js 2.x core-js/library/web/timers

Pre-flight checklist

[X] I have once read some documentation of some project
[X] I agree to behave
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.2.0
Electron version
28.0.0
Operating system

Ubuntu
node 18.15.0

Last known working Electron Forge version
7.2.0 (Same)
Expected behavior

yarn start works

Actual behavior
$ yarn start
yarn run v1.22.10
$ electron-forge start
✔ Checking your system
✔ Locating application
✔ Loading configuration
✔ Preparing native dependencies: 6 / 6 [0.4s]
✔ Running generateAssets hook
⠙ [plugin-vite] Launching dev servers for renderer process code
◼ [plugin-vite] Compiling main process code
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
⠙ [plugin-vite] Compiling main process code
vite v4.5.1 building for development...

watching for file changes...
vite v4.5.1 building for development...

watching for file changes...

build started...

build started...
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
⠹ [plugin-vite] Compiling main process code
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
⠙ [plugin-vite] Compiling main process code
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
⠇ [plugin-vite] Compiling main process code
✔ [plugin-vite] Launching dev servers for renderer process code [0.1s]
✔ [plugin-vite] Compiling main process code [6s]

App threw an error during load
Error: Cannot find module 'core-js/library/web/timers'
Require stack:
- ./.vite/build/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
    at n._resolveFilename (node:electron/js2c/browser_init:2:114728)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/usr/src/mustang/app/electron/.vite/build/main.js:1:274)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32)
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Cannot find module 'core-js/library/web/timers'
Require stack:
- ./.vite/build/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
    at n._resolveFilename (node:electron/js2c/browser_init:2:114728)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/usr/src/mustang/app/electron/.vite/build/main.js:1:274)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32)

Steps to reproduce
$ yarn install
$ yarn start
Not reproducible with a minimal app. Only started happening when I included some older library. It may use some commonjs, in a type: module library, which may trigger this. But I'm just guessing, based on the stack.
Additional information
The file node_modules/core-js/library/web/timers.js does not exist in core-js 3.34.0 nor in 3.0.0. It does exist in core.js 2.6.12.
I have node 18.15.0 installed
Fix
Possible fixes:

Depend on core-js 2.6.12. yarn add<EMAIL_ADDRESS>removes the error.
Find the culprit line and fix it, but it's called from node.

Thank you for solution. I would like it to be fixed as soon as possible


fullscreen freezing

I tested only with steam but maybe happens with other apps aswell, when fullscreen steam games ( maybe happen with other apps aswell, didn't test ) the screen will freeze/lag without any sign of coming back I can switch to another tty even though it takes a while to do so. I looked through other closed issues which mentioned something equal/similliar which was marked as solved, the thing that fixed it for me now was disabling direct scanout like mentioned before. ( I'm running in a nvidia gpu/proprietary driver 550.78 )

I'm not sure what the other closed issue you're referring to is, assuming it's in this repo. But this issue doesn't seem to be related to this flake. Did you mean to open it here?

I'm not sure what the other closed issue you're referring to is, assuming it's in this repo. But this issue doesn't seem to be related to this flake. Did you mean to open it here?

Yes, I didn't realize it ill post it there


How to passing multiple arguments to @action

Hi,
I'm completely stuck on an issue I encounter with passing multiple arguments through an action. I've tried my best to find a solution but my vuex/decorators experience is limited. Help is appreciated.
===My .ts file belonging to the vue component ===
function receives a (dynamic)number when clicking in a table and recieves a (dynamic) year when clicking.
 @raceResultsModule.Action
  loadRaceResults!: (year: any, round: any) => void;

getResults(round: number) {
    this.loadRaceResults(this.year, round);
  }

===My module .ts file with the action/axios call receives the passed dynamic values year and round===
@Action
 async loadRaceResults(data: { year: number; round: number }) {
   await axios
     .get(`http://localhost:8000/api/f1/${year}/${round}/results.json`)
     .then((response) => {
       this.raceResults = response.data.MRData.RaceTable.Races;
     })
     .catch((error) => console.log(error));
 }

If I console.log data I receive only one value(year) instead of two dynamic values(year + round). How can I accomplish this properly?

You have defined the action correctly, by using options parameter style. Being only able to pass one parameter is a restriction of vuex, btw.
Now you be constistent and also call the action just as you have defined it. E.g.:
getResults(round: number) {
    this.loadRaceResults({ year: this.year, round });
}

Great! You've clarified so much with this comment. The fact that Vuex has a restriction on passing only one parameter is essential. With this solutions you pass basically one value as on object with multiple properties.
I had to refine my code a bit and know happy to move forward! Thank you for helping me out.
@raceResultsModule.Action
loadRaceResults!: (year?: any, round?: any) => void;

getResults(round: number) {
    this.loadRaceResults({ year: this.year, round });
  }

 @Action
  async loadRaceResults(result: { year: number; round: number }) {
    await axios
      .get(
        `http://localhost:8000/api/f1/${result.year}/${result.round}/results.json`
      )
      .then((response) => {
        this.raceResults = response.data.MRData.RaceTable.Races;
      })
      .catch((error) => console.log(error));
  }
}


Update Unshaky/ShakyPressPreventer.m

Hi, this appears to fix the issue with the command key.
Thanks a ton for creating this by the way.
I was going nuts with a double space-bar problem.

This is great, finally an answer to this long-lived issue #1.
In this PR, you prevent Unshaky from dismissing the event when command mask is on. I think I might need to modify a little bit.
Image this scenario:
Scenario: my v key is in trouble, which means my CMD+v (paste) could be registered twice, so I want Unshaky to dismiss the second hit.
I would suggest: If the first and second have different masks, disable Unshaky. Otherwise, let it function as normal. What do you think?

Can you try this one in dev branch? I simplified some changes as well. @ghost711
https://github.com/aahung/Unshaky/tree/dev

Oh, nevermind, I see the edits now.  I'll try it on my computer.

Totally agree, these are nice changes and they should go into this repo.
I made one implementation on dev branch based on your codes, but deal with this extra scenario

Scenario: my v key is in trouble, which means my CMD+v (paste) could be registered twice, so I want Unshaky to dismiss the second hit.

Really appreciate your suggestion. The latest two commits here are about your refactoring suggestion. https://github.com/aahung/Unshaky/commits/dev feel free to refactor more if you want to. Thanks!

Hmm... Your version seems to cover the scenario you mentioned (simulated by setting V key to 200 ms and rapidly hitting CMD+v), but they don't seem to fix the CMD+space issue.
The weird thing is that it the double event only seems to happen with CMD+space key, not with CMD+, or +space.  It must be tied to the spotlight shortcut somehow.
It also looks like it won't work to cover the scenario you mentioned as well as this issue with the same code, because it appears critical to NOT dimiss the 2nd (duplicate) event generated by CMD+space, but it will get dismissed with the current version because its flags don't match the previous event.  This is what my modified log looks like with the current version during a CMD+space (with the keyboard not causing any problems itself, but the spotlight issue present):
77447	 Key(49)	 Event: U, DISMISSING UP
77446	 Key(49)	 Event: D, DISMISSING DOWN: 1ms
77445	 Key(49)	 Event: U, flags: 0x100000
77381	 Key(49)	 Event: D, flags: 0x100000
And this is what it looks like when it's working (with my earlier code):
75	 Key(49)	 Event: U, flags: 0x100000
74	 Key(49)	 Event: D, flags: 0x100000
74	 Key(49)	 Event: D, NOT DISMISSING DOWN (CMD Pressed): 2ms
72	 Key(49)	 Event: U, flags: 0x0
0	 Key(49)	 Event: D, flags: 0x100000

GitHub mangled this sentence because I used angle brackets (replaced with parentheses below):
The weird thing is that it the double event only seems to happen with CMD+space key, not with CMD+(any other key), or (any other modifier key)+space. It must be tied to the spotlight shortcut somehow.

It looks like my initial statement comment wasn't quite right when I wrote:
/** The command key was pressed, which will cause the event to be reported twice
in rapid succession (first without the modifier flag, and then again with it). */
Your most recent edit would work if that was the case.
Instead, it looks like CMD+space does this if the CMD key is released first (which both versions can handle):
1477886        Key(49)   Event: U, flags: 0x100000
1477885        Key(49)   Event: D, flags: 0x100000, NOT DISMISSING DOWN (CMD Pressed): 1ms
1477883        Key(49)   Event: U, flags: 0x0
1477677        Key(49)   Event: D, flags: 0x100000
And like this if the space bar is released first (which won't work with the current version):
1594394        Key(49)   Event: U, flags: 0x100000
1594393        Key(49)   Event: D, flags: 0x100000
1594393        Key(49)   Event: D, NOT DISMISSING DOWN (CMD Pressed): 0ms
1594392        Key(49)   Event: U, flags: 0x100000
1594300        Key(49)   Event: D, flags: 0x100000

I submitted a new pull request that's just like my earlier one, except it only modifies normal operation for the case of CMD+space.
I wrote up my findings from this thread in the comment for the section:
             if( (keyCode == 49) && (CGEventGetFlags(event) & kCGEventFlagMaskCommand) ) {                 /** CMD+Space was pressed, which causes a duplicate pair of down/up                  keyEvents to occur 1-5 msecs after the "real" pair of events.                  - If the CMD key is released first, it will look like:                         CMD+Space Down                             Space Up                         CMD+Space Down                         CMD+Space Up                  - Whereas if the space bar is released first, it will be:                         CMD+Space Down                         CMD+Space Up                         CMD+Space Down                         CMD+Space Up                  - The issue only appears to happen with CMD+Space,                    not CMD+<any other key>, or <any other modifier key>+Space.                  - So it looks like the simplest thing is to just ignore if both                    CMD and space are pressed at the same time. */


Add Tabs component

Current dependencies on/for this PR:

master

PR #64   👈

This comment was auto-generated by Graphite.


pypi badge

just a badge to show the latest version on pypi

Coverage remained the same at 100.0% when pulling 68fc2860ab84618ce4ceadb1e6903ef6782c3feb on Ohjeah:master into 86bbcd69a417d31bda7cf93868eecd43013221dc on mewwts:master.

Thanks!


fix(custom-element): defense code for duplicate declarations

Related Ticket(s)
No related issue
Description
Downstream library Carbon for IBM.com started to see issues with
duplicate declaration of custom element warnings, this builds in code to
prevent duplicate declaration of particular custom elements.
NOTE: realized this is impacting the react wrapper, so this is not ready to merge yet.
Changelog
Changed

Changes custom element declaration for bx-btn and bx-modal

Closing this, will possibly need to approach this a different way.


Add a favicon

This would require someone with graphic talent.

Meanwhile, an empty favicon has been added to quiet down server hits.


Question about Youtube audio only

Hey there,
I was wondering if you could possible walk through how you are achieving audio only after the recent youtube update, where they are merging both audio and video into one https://*.googlevideo.com/videoplayback/* request.
Previously audio only was achieved by blocking mime=video requests and only allowing mime=audio requests. After the update this doesn't seem to work as they are merged into one request.
Looking at your code it seems like you are updating some flags, but I can't seem to get a grasp on it. Would love to learn more about this.

I don't know how the actual YouTube engine is working with the network requests.
There is a property deviceIsAudioOnly existing in YouTube coding. My script is to force it to true only, plus some fixes for the live streaming.

No... This is not that simple
You need to study the JavaScript code of the YouTube.
Anyway you can just use my script for this feature

deviceIsAudioOnly
https://github.com/cyfung1031/userscript-supports/blob/f52e0a6040efc4ba80c749b543f058dc5464a7d6/484611-youtube-audio-only.user.js#L2134-L2150
I could not go through all the coding I wrote to tell you how to implement this.
You can use my userscript directly or deeply analyse YouTube's JavaScript by yourself.


Add support for the credProps extension

Per https://github.com/tweag/webauthn/issues/35#issuecomment-1371564697 , this PR adds support for the credProps extension (ref https://www.w3.org/TR/webauthn-2/#sctn-authenticator-credential-properties-extension).
I added a test attestation to validate the parsing, and also used the test server locally to manually test that the feature (at least appears to be) working:

This is my first time contributing to this repository (or any OSS Haskell repo), so please let me know if you need any changes.
Thank you!

Hej! Thank you for your contribution. I'm going to leave a review before the end of tomorrow. @infinisil will probably also take a look sometime soon.
It looks good as far as I've looked at it, we really appreciate you taking the time to improve the library.
Kindly,
Erin

webauthn-<IP_ADDRESS> released :)


Vulnerability roundup 90: graylog-3.3.2: 1 advisory [8.1]

search, files

[ ] CVE-2020-15813 CVSSv3=8.1 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: b50d55871fb; nixos-unstable: 28fce082c8c. May contain false positives.
Cc @fadenb

Can confirm the issue. It is well known for a while and I am a bit surprised to see it with a CVE assigned now.
That aside, the linked CVE talks about versions before 3.3.3 being affected. Version 3.3.3 has not been released as of now (just checked a minute ago).
I am not sure whether a fix will be included in 3.3.3 as it severely changes existing behavior and will break a lot of existing setups (I operate at least two systems that rely on the currently broken implementation 🤷♂).
Should we just follow upstream if they release a fix in 3.3.3 and include it in 20.03 even though it might break existing setups?
/cc @Ma27

Uhm, they break stuff in a patch-level release?

I hope not (again) that is why I am confused by the statement that every version before 3.3.3 is affected if 3.3.3 might be affected as well.
I was assured by Graylog staff a few weeks back in a call that they will adhere to semver.
To be fair: It is clearly broken right now but it has been that way for a long long time so fixing the issue might have adverse affects for existing setups.

I see. What I don't understand is is whether the changes are related to the security fix (if not, why don't they publish two releases?).
However, I don't have time for this atm, will think about it tomorrow.

Just got a response at https://github.com/Graylog2/graylog2-server/pull/8569#issuecomment-664453306

In this case we do, as it is a security-related bugfix. We are aware that it might break setups which were configured incorrectly before this change, but do consider it to be required for secure operations

Well, then I'm in favor of performing a backport. (On master we should probably mention this in the 20.09 release notes).
I'm wondering however how we want to take care of informing users on 20.03:

We could probably publish a warning in (at least) the 20.03 manual and discourse
If we can detect such a misconfigurations with some heuristics in the module, we should probably throw a warning.
We can also unconditionally throw a warning on 20.03 that people should check their graylog.

We could probably publish a warning in (at least) the 20.03 manual and discourse

👍

If we can detect such a misconfigurations with some heuristics in the module, we should probably throw a warning.

The configuration is stored in the MongoDB. We would need to query the config, analyze it and then decide whether to warn or not.
Does not sound like a feasible thing to do :(

We can also unconditionally throw a warning on 20.03 that people should check their graylog.

I am undecided on this one. I am not a fan of spamming every GL user with a warning when probably only a small subset uses the LDAP integration at all.

FYI: Graylog 3.3.3 has been released and contains the breaking change.
https://www.graylog.org/post/announcing-graylog-v3-3-3:

In Graylog v3.3.3, certificates of LDAP servers connected using a secure connection (SSL or TLS) are validated against the local default keystore. Prior to v3.3.3, Graylog did not validate the certificates of LDAP servers this way even if the "Allow self-signed certificates'' option was unchecked. Depending on your local LDAP settings and the validity of the certificates used (if any), this update may introduce a breaking change that will interfere with the functionality of Graylog. To avoid this, please ensure that all certificates used are valid, their common name matches the host part of your configured LDAP server and your local keystore contains all CA/intermediate certs required for validation.

I will prepare a corresponding PR sometime later today.

Fixed on master in 1bb1b6708708be99be95604fc2e225b327941724 and on release-20.03 in 3de1ba01fd68d3cea088e615c76cd1aea3e5472e.


Missing Crafting Recipe for Crimson & Warped

Forge 1.20.1
Additional Lights 1.20.1-2.1.7
Missing crafting recipes for anything containing Crimson or Warped logs
I extracted the .jar and couldn't find the recipes for them in there

still present in recent version, including 1.21.1

I finally fixed it. It was way too late

I finally fixed it. It was way too late

are you planning to fix it for earlier version as well ? (1.21.1 & 1.21.3)

Due to my current schedule, I have no plans to address older versions. Sorry.

Due to my current schedule, I have no plans to address older versions.


Sign up - Infinite skeleton loader when navigating from abracadabra tab

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2616817
Issue reported by: Applause - Internal Team
Action Performed:

Open https://staging.new.expensify.com/
Enter new gmail account
Copy the Magic link from email and change it to staging link
Open link in a new tab
Navigate to the original tab

Expected Result:
User is logged in with the new account.
The engagement modal "Welcome to Expensify" is displayed
Actual Result:
User is logged in with the new account.
Infinity skeleton loader in a chat history
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/968218f9-99af-410b-952b-752b8dd4c218
View all open jobs on GitHub

@sonialiap  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Dupe of https://github.com/Expensify/App/issues/37351?

Agreed, that looks like a dupe


es2015ify

💄
es2015ify
:arrow_up: w3counter

// @sindresorhus

LGTM

@kevva Whenever you have a chance, can you extract the CLI, and do a new major release?

Thanks Sam :)

No problem, thanks for reviewing. If this one gets released, I will upgrade pageres :p.

ping @kevva (when you find some time :))

Noticed some new activity yesterday. Care to release this?

@SamVerschueren :D, yesss!

Awesome, thanks man!

Not a second too early :).


Incorrect Palindrome counts

I have found this very useful thank you! However, your palindrome counts are incorrect.
eg, running the script on this sequence "CTAGA" for length 4, returns:
{'CTAG': 1, 'TAGA': 1, 'TCTA': 1}
while the correct answer would be:
{'CTAG': 2, 'TAGA': 1, 'TCTA': 1}
the simple python fix for this is:
d={k if Seq(k)==Seq(k).reverse_complement() else k:v*2 if Seq(k)==Seq(k).reverse_complement() else v for k, v in d.items()}
Though I cannot comment on the c++ implementation

Thanks for the feedback. This code decides that a palindrome would not be counted twice: https://github.com/alexpreynolds/kmer-counter/blob/master/kmer-counter.cpp#L212-L218
$ more /tmp/test.fa
>foo
CTAGA
$ ../kmer-counter --no-rc --k=4 --fasta /tmp/test.fa
>foo	CTAG:1 TAGA:1

Even when not using --no-rc, CTAG would still be a "canonical" mer either way, I'd think, which is why I still only count it once.
$ ../kmer-counter --k=4 --fasta /tmp/test.fa
>foo	CTAG:1 TAGA:1 TCTA:1

I'm on the fence about double-counting palindromes. Some have said it would be an error to do so. Maybe it should be a user-specified option?

As far as as I see it, it is not a double count? In this particular situation 2 strands are counted which correspond to:
CTAGA
&
TCTAG
which means there are 2 tetramers per strand, and therefore 4 tetramers total, with CTAG being on both the top and bottom strands.
Perhaps I am naive about how some bioinformaticians typically score this informational content, but the method I outlined is the approach that is useful to me. Im not sure if I understand the other side of the argument, but a command line flag would certainly solve the issue for me and be much appreciated!

Added commit 28da9bc with --double-count-palindromes option to force double-counting of palindromes. Please let me know if this helps you out or you still run into any problems.


CacheServiceTicketManager cleanup issues

When the memory pressure is hig on the HttpContext.Current.Cache, it gets cleared by IIS. Then the user is actually "logged out" in the middle of an otherwise authenticated session.
Implementing the storage of local tickets on the HttpContext Cache seems flawed by design, since collection of items might not be totally controlled.

@sunnymoon this could be solved by the RFC for a distributed cache provider in issue #61, correct?
I think any time you use an in-memory cache, such as System.Web.Caching or System.Runtime.Caching, you are going to run into the possibility of IIS recycling the app pool.  The in-memory caching just isn't durable.... there is no serialization to disk.
I guess another possibility is making a cache provider for the proxy and service ticket managers that is in-memory, but also serializes to local disk for durability.  Any chance you'd be up for writing that?

@phantomtypist I don't think backing up in-memory to file is good idea. It will require significant efforts to implement it in a good way (like support multithreading, possible issues with file read/write, issues with network drives etc), and it still won't work in distributed environments, like scale up in Azure etc.
There are many ways which will lead to in-memory cache cleanup, so I think it would be just good to emphasize that default (and the only) implementation of cache is in-memory. Actually it is even commented in source code here https://github.com/apereo/dotnet-cas-client/blob/master/DotNetCasClient/State/CacheProxyTicketManager.cs#L27 in CacheServiceTicketManager summary:

An IServiceTicketManager implementation that relies on the ASP.NET Caching model for ticket
storage.  Generally this implies that the ticket storage is maintained locally on the web
server (either in memory or on disk).  A limitation of this model is that it will not
support clustered, load balanced, or round-robin style configurations.

I think highlighting it in the repository readme to warn users is really good idea.
For real-life production cases something like in-memory cache + database can be useful, but that is really part of #61 IMO.

I'll be finalizing the 1.1.0 release today and at the same time cleaning up a bit of the documentation on the readme.  I'll add a note for that.  Some of the content from the readme will be migrated to the GitHub wiki in this repo too.
I'm going to close this issue as the in-memory caching is working by design (in .NET, that is.)  If anybody wants a scenario where the tickets survive an IIS or AppPool recycle, then they'll have to use the option(s) eventually created by issue #61.

We've implemented an alternative with a static global variable. The reallity is if the application  pool gets recicled we'll loose all logged in session, true.
But actually the webcache is actually cleared by .net at any point in time, nevermind the pool recycling. It depends only on memory pressure and not memory exhaustion...
Please read
https://msdn.microsoft.com/en-us/library/system.web.caching.cache.effectivepercentagephysicalmemorylimit.aspx
For additional details...


Exporting get_requires utils function

This PR introduces a new file, utils.py, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object.
In this context we're using a function from llvm backend's pattern_matching.cpp to avoid reimplement it in Python. This function is exported as Pyhton binding in this PR, and therefore, the current PR can only be merged after we merge the LLVM Backend one.

In this context we're using a function from llvm backend's pattern_matching.cpp to avoid reimplement it in Python

Hasn't there been a plan to eventually implement it in pyk though?

In this context we're using a function from llvm backend's pattern_matching.cpp to avoid reimplement it in Python

Hasn't there been a plan to eventually implement it in pyk though?

That was revisited, and we decided to move in another direction to avoid having the exact implementation in two different places when we could just export them.

Please add a unit test for this feature. That will also block merging this PR until the binding becomes available.

I've just added a unit test, and I'm waiting for this PR to be approved


Vulnerable to CVE-2022-22965 due to Spring Core dependency?

Spring Vault uses the vulnerable Spring Core components allowing Remote Code Execution (Spring4Shell). It appears the latest 2.3.2 has many vulnerable components: (https://mvnrepository.com/artifact/org.springframework.vault/spring-vault-core/2.3.2)
When should we expect 2.3.3 to be released with the latest patched components?
Does someone more knowledgable about Spring Vault deployments know if the Vault itself is exploitable due to the vulnerable components?

Spring Vault is not vulnerable as we're not using DataBinder nor CachedIntrospectionResults. Right now we don't have immediate plans to ship a release. When you use Spring Vault in standalone arrangements, then you are not vulnerable. When using Spring Vault in a Spring web application, then you are under the control of the Spring version or you can increment Spring Boot's version property for Spring Framework.


FlashAttention Triton broken

GPU: A100-PCIE-40GB
flash-attention: dc08ea1c33afca500a3d4ada907608f7815a11d9
Triton: triton.__version__: '2.1.0'
Docker image Environment: nvcr.io/nvidia/pytorch:23.02-py3
How to reproduce

benchmark_causal.py broken
python benchmarks/benchmark_causal.py

FlashAttention Triton - Forward pass
Traceback (most recent call last):
  File "benchmarks/benchmark_causal.py", line 96, in <module>
    benchmark_all(flash_attn_qkvpacked_func, qkv, causal, repeats=repeats, desc='FlashAttention Triton')
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/utils/benchmark.py", line 89, in benchmark_all
    benchmark_forward(fn, *inputs, repeats=repeats, desc=desc, verbose=verbose,
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/utils/benchmark.py", line 17, in benchmark_forward
    fn_amp(*inputs, **kwinputs)
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/utils/benchmark.py", line 15, in fn_amp
    fn(*inputs, **kwinputs)
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/flash_attn_triton.py", line 728, in forward
    o, lse, ctx.softmax_scale = _flash_attn_forward(
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/flash_attn_triton.py", line 594, in _flash_attn_forward
    assert bias.dtype in [q.dtype, torch.float]
AttributeError: 'bool' object has no attribute 'dtype'

Solved by:

https://github.com/HazyResearch/flash-attention/blob/dc08ea1c33afca500a3d4ada907608f7815a11d9/benchmarks/benchmark_causal.py#L96 to benchmark_all(flash_attn_qkvpacked_func, qkv, None, causal, repeats=repeats, desc='FlashAttention Triton')
https://github.com/HazyResearch/flash-attention/blob/dc08ea1c33afca500a3d4ada907608f7815a11d9/flash_attn/flash_attn_triton.py#L139 to qk += tl.dot(q, tl.trans(k))

Then second issue occured

FlashAttention Triton hang

PyTorch Attention - Forward + Backward pass
<torch.utils.benchmark.utils.common.Measurement object at 0x7fbb6c8c5460>
f(grad, *inputs, **kwinputs)
  14.25 ms
  1 measurement, 30 runs , 128 threads
FlashAttention Triton - Forward pass
^CTerminated

The benchmark_causal.py hang when running to triton implementation.
cc: @tridao

Thanks for the report.
I've just fixed the issue in benchmark_causal.py in the latest commit.
As mentioned in #132, this implementation was tested on triton==2.0.0.dev20221202.
Triton 2.0 has a new backend (MLIR) but seems like it doesn't yet work for head dimensions
other than 64. We'll update this implementation with the new Triton backend once this is fixed.

Sounds good! Looking forward to the updated implementation

The way you fix the mentioned problem in benchmark_causal.py seems caused another error.
Traceback (most recent call last):
  File "benchmarks/benchmark_causal.py", line 97, in <module>
    pytorch_profiler(flash_attn_qkvpacked_func, qkv, causal=causal, backward=True)
  File "/usr/local/lib/python3.8/dist-packages/flash_attn-0.2.8-py3.8-linux-x86_64.egg/flash_attn/utils/benchmark.py", line 103, in pytorch_profiler
    g = torch.randn_like(fn(*inputs, **kwinputs))
TypeError: apply() takes no keyword arguments

My previous solution still worked,
benchmark_all(flash_attn_qkvpacked_func, qkv, None, causal, repeats=repeats, desc='FlashAttention Triton')
cc: @tridao

You're right, thanks for catching that.
I've pushed another commit to fix.

Hi some questions about flash-attention triton,
I did a performance test on it compared with flash-attention cuda based on triton==2.0.0.dev20221202.
I noticed that the flash-attention triton is much faster than flash attention cuda in large fixed-sequence length case, but the performance is almost same whether the causal mask set to True or False.
HAS_FLASH  True
HAS_FMHA_OPT  True
fmha-batch8-head12-d64-fwd:
    N_CTX  FlashAttn-CUDA  FlashAttn-Triton
0   256.0        0.045779          0.119557
1   512.0        0.096497          0.221913
2  1024.0        0.309645          0.435083
3  2048.0        1.220931          0.877189
4  4096.0        4.945163          1.761476
fmha-batch8-head12-d64-fwd_causal:
    N_CTX  FlashAttn-CUDA  FlashAttn-Triton
0   256.0        0.039961          0.127814
1   512.0        0.083571          0.237840
2  1024.0        0.224908          0.462387
3  2048.0        0.756156          0.929078
4  4096.0        2.873472          1.861905

Is it normal? I expect ~2x speed up when enable causal mask,
You can reproduce it with test script following:
import torch
import triton

from flash_attn.flash_attn_interface import flash_attn_func as flash_attn_func
from flash_attn.flash_attn_triton import flash_attn_func as ck_attn_func_triton

batch = [8]
n_heads = [12]
d_head = [64]

configs = [triton.testing.Benchmark(
    x_names=['N_CTX'],
    x_vals=[2**i for i in range(8, 13)],
    line_arg='provider',
    line_vals=['flash-cuda'] + ['flash-triton'],
    line_names=['FlashAttn-CUDA'] + ['FlashAttn-Triton'],
    styles=[('green', '-'), ('blue', '-')],
    ylabel='Time(ms)',
    plot_name=f'fmha-batch{BATCH}-head{N_HEADS}-d{D_HEAD}-{mode}',
    args={'H': N_HEADS, 'BATCH': BATCH, 'D_HEAD': D_HEAD, 'dtype': torch.float16, 'mode': mode}
) for mode in ['fwd', 'fwd_causal'] for BATCH in batch for N_HEADS in n_heads for D_HEAD in d_head]

@triton.testing.perf_report(configs)
def bench_flash_attention(BATCH, H, N_CTX, D_HEAD, mode, provider, dtype=torch.float16, device="cuda"):
    assert mode in ['fwd', 'fwd_causal']
    warmup = 25
    rep = 100

    if provider == "flash-cuda":
        lengths = torch.full((BATCH,), fill_value=N_CTX, device=device)
        cu_seqlens = torch.zeros((BATCH + 1,), device=device, dtype=torch.int32)
        cu_seqlens[1:] = lengths.cumsum(0)
        qkv = torch.randn((BATCH * N_CTX, 3, H, D_HEAD), dtype=dtype, device=device, requires_grad=True)
        if mode == 'fwd':
            fn = lambda: flash_attn_func(qkv, cu_seqlens, 0.0, N_CTX, causal=False)
        elif mode == 'fwd_causal':
            fn = lambda: flash_attn_func(qkv, cu_seqlens, 0.0, N_CTX, causal=True)

        ms = triton.testing.do_bench(fn, percentiles=None, warmup=warmup, rep=rep)
        return ms

    if provider == "flash-triton":
        q = torch.randn((BATCH, H, N_CTX, D_HEAD), dtype=dtype, device="cuda", requires_grad=True)
        k = torch.randn((BATCH, H, N_CTX, D_HEAD), dtype=dtype, device="cuda", requires_grad=True)
        v = torch.randn((BATCH, H, N_CTX, D_HEAD), dtype=dtype, device="cuda", requires_grad=True)
        bias = torch.randn(1, H, 1, N_CTX, dtype=torch.float, device="cuda")
        if mode == 'fwd':
            fn = lambda: ck_attn_func_triton(q, k, v, None, False)
        elif mode == 'fwd_causal':
            fn = lambda: ck_attn_func_triton(q, k, v, None, True)

        ms = triton.testing.do_bench(fn, percentiles=None, warmup=warmup, rep=rep)
        return ms

# only works on post-Ampere GPUs right now
bench_flash_attention.run(save_path='.', print_data=True)

cc @tridao

No we expect shape (batch, seqlen, h, headdim) not (batch, h, seqlen, headdim).
You can change the shape of q, k, v to get the right benchmark.
As mentioned in the implementation file, currently Triton forward is generally faster than CUDA forward, while Triton backward is generally slower than CUDA backward.

Thanks for the response, let me close this issue.


make operator-sdk local bin

specify version for operator-sdk for make bundle
download operator-sdk pinned version when generating bundle update make bundle to use local operator-sdk

/test mariadb-operator-build-deploy-kuttl

/test manila-operator-build-deploy-kuttl

/retest-required

/retest
Failed trying to fetch install_yamls repo

/test manila-operator-build-deploy-tempest


Remove tag management functionality

The tag management functionality is going to be migrated over to collections-publisher.
To make this process smoother, remove any user interface functionality from Panopticon whilst keeping the equivalent JSON endpoints for other APIs to use.

This looks great. I think we have everything else ready to do the migration to collections-publisher, so I'm merging this, and we can check it further on preview tomorrow.


Feature: Integrate with Facebooks Buck tool

Has anyone looked into integrating Facebooks Buck tool with Fastlane?
https://buckbuild.com/

This sounds like it would be a great plugin @weibel 👍  Going to close this out since we don't currently have a plan to implement this as a feature.


⚠ Bofrost.fr has degraded performance

In a5be767, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 985 ms

Resolved: Bofrost.fr performance has improved in d0e554a after 6 minutes.


Can't add face with IR camera (regular camera works)

Please describe the issue in as much detail as possible, including any errors and traces
I keep trying to add a model using my IR camera on my laptop but I keep getting cv2.error: !_src.empty() in function "cvtColor". I selected my regular camera (/dev/video0) and I have no problems. I can add a model and login successfully. I try to switch my camera to my IR camera (/dev/video2) and I get the error. I can't register the model. The light on the IR camera does turn on and I know that the IR camera works because Windows Hello works properly (dual boot). Here's my full stacktrace:
elliot@popos:~$ sudo howdy add
Adding face model for the user elliot
Enter a label for this new model [Model #2] (max 24 characters):
[ WARN:0] global /io/opencv/modules/videoio/src/cap_v4l.cpp (998) tryIoctl VIDEOIO(V4L2:/dev/video2): select() timeout.

Please look straight into the camera
Traceback (most recent call last):
  File "/usr/local/bin/howdy", line 89, in <module>
    import cli.add
  File "/usr/lib/security/howdy/cli/add.py", line 147, in <module>
    gsframe = cv2.cvtColor(frame, cv2.COLOR_BGR2GRAY)
cv2.error: OpenCV(4.2.0) /io/opencv/modules/imgproc/src/color.cpp:182: error: (-215:Assertion failed) !_src.empty() in function 'cvtColor

Linux distribution (if applicable):
Pop_OS! (Ubuntu/Debian derivative)
Howdy version:
2.5.1 (apt)

I'm having a similar error

This just means that you're camera is sending invalid frames to Howdy, see the bigger thread #160


TRX logger no longer writes startTime and endTime attributes for UnitTestResult

Description
When running tests with dotnet I no longer see startTime and endTime attributes on UnitTestResult elements.
Steps to reproduce
dotnet test -l:trx
Expected behavior
UnitTestResult elements look like this:
<UnitTestResult
	executionId="0435bfb6-8355-4e0f-9b46-162d6f635ac7"
	testId="6aca3a68-0213-4757-b048-ed4861dbe5c5"
	testName="MyNamespace.MyClass.MyTestMethod"
	computerName="mycomputer"
	duration="00:00:00.9480000"
	startTime="2017-04-26T15:35:47.9750654-07:00"
	endTime="2017-04-26T15:35:47.9750654-07:00"
	testType="13cdc9d9-ddb5-4fa4-a97d-d965ccfc6d4b"
	outcome="Passed"
	testListId="8c84fa94-04c1-424b-9868-57a2d4851a1d"
	relativeResultsDirectory="0435bfb6-8355-4e0f-9b46-162d6f635ac7" />

Actual behavior
UnitTestResult elements look like this:
<UnitTestResult
	executionId="ad4b5c76-c680-4bc8-bea3-c16d49e1e526"
	testId="9e28f563-7cc1-4bfb-bc40-df16baee1da0"
	testName="MyNamespace.MyClass.MyTestMethod"
	computerName="mycomputer"
	duration="00:00:00.7940000"
	testType="13cdc9d9-ddb5-4fa4-a97d-d965ccfc6d4b"
	outcome="Passed"
	testListId="8c84fa94-04c1-424b-9868-57a2d4851a1d"
	relativeResultsDirectory="ad4b5c76-c680-4bc8-bea3-c16d49e1e526" />

Environment
c:\> dotnet --info
.NET Command Line Tools (2.0.0-preview2-005858)

Product Information:
 Version:            2.0.0-preview2-005858
 Commit SHA-1 hash:  9593adffc7

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\dev\github\cli\.dotnet_stage0\x64\sdk\2.0.0-preview2-005858\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview2-002081-00
  Build    : 361739f8494aa069bca175533c4ff09b41046fbb

@singhsarab looks like P0 bug. Related to OM refactoring for protocol?

@jonsequitur We should actually raise a bug in xunit repo, as the xunit adapter does not stamp the StartTime and EndTime.
There was an intermediate change in setting of default values for these fields and that has been fixed now. Next insertion into cli repo should resolve this.
For now, please try updating the version of Microsoft.NET.Test.Sdk to 15.3.0-preview-20170425-07 in your test csproj.

@jonsequitur did the issue get resolved?

It seems that the issue has been fixed.
I tried with following version:
csproj of test project.
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>netcoreapp1.1;netcoreapp2.0</TargetFrameworks>

    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0-preview-20170628-02" />
    <PackageReference Include="xunit" Version="2.2.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
  </ItemGroup>

</Project>

dotnet version
Product Information:
 Version:            2.0.0-preview3-006770
 Commit SHA-1 hash:  78e7163819

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.0.0-preview3-006770\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview3-25514-02
  Build    : 1b047a04057cec973cfb890fd21f7a639cfcd118


Add -f flag to the copy command in vroutercni container to force overwrite

When contrail version is changed, or the node is restarted and pods are rescheduled again, vroutercni init container has to force overwrite the files created previously. Otherwise, cp command may fail with error:
cp: cannot create regular file '/host/opt_cni_bin/contrail-k8s-cni': Text file busy

recheck


[Task] Support from and to

Grafana queries for data from time A to time B. The response should contain events within this time period.
Sample request:
{
  "timezone": "browser",
  "panelId": 2,
  "dashboardId": 3,
  "range": {
    "from": "2019-05-06T19:47:39.649Z",
    "to": "2019-05-08T19:47:39.652Z",
    "raw": { "from": "now-2d", "to": "now" }
  },
  "rangeRaw": { "from": "now-2d", "to": "now" },
  "interval": "2m",
  "intervalMs": 120000,
  "targets": [
    {
      "target": "MCCustomEventDemo$CustomEvent.workLeft",
      "refId": "A",
      "hide": false,
      "type": "timeserie"
    },
    {
      "target": "jdk.ObjectCountAfterGC.(eventType)",
      "refId": "B",
      "type": "timeserie"
    }
  ],
  "maxDataPoints": 958,
  "scopedVars": {
    "__interval": { "text": "2m", "value": "2m" },
    "__interval_ms": { "text": "120000", "value": "120000" }
  },
  "adhocFilters": []
}

https://github.com/jiekang/jfr-datasource/commit/f751d31f13737b83091521294d6663aaefd7b190


Tower upgrades

The upgrades affecting tower abilities have not been implemented yet, neither has the tower UI upgrade art or the upgrade to the laser pointer drag speed. I believe that I got the other tower upgrades implemented.

Implementation Notes

The code egregiously over uses switch statements, notably the nested switch statements, This can create major dependency issues. Encapsulation is far more suited here as it follows the Open-Close Principle.
Hard coding values should be a last resort. This is especially true because designers need to be able to work in engine. Values that affect game balance must be stored in serialized variables for game designers to access.
Too many responsibilities are assigned to UpgradeScreen.cs. This is more noticeable once variables are properly assigned, especially in the editor. Divide tasks between scripts to make code maintenance  and design work easier to perform.


Error in AGAS

I am getting an internal error in the AGAS server when running Octo-Tiger on 128 SuperMIC nodes.
"{what}: primary_namespace::resolve_free_list, failed to resolve gid, gid({0000003c00000001,<PHONE_NUMBER>dc13f6}): HPX(internal_server_error)"
The full error output is here:
https://gist.github.com/dmarce1/b25f80106be451972158
This was with the most recent master version of HPX (at least, as of yesterday), Intel 15, MVAPICH2, and boost 1.59, GCC 4.9 headers, tbbmalloc
I will post a version of the code that does not have external library dependencies and which reproduces the error later today.
Could  this have anything to do with setting the hpx.parcel.max_connections or hpx.parcel.max_connections_per_locality too low?

Could this have anything to do with setting the hpx.parcel.max_connections or hpx.parcel.max_connections_per_locality too low?

It is very unlikely that this leads to that error. The only thing that might happen is that your program is getting slower when those numbers aren't high enough. A good indicator for that are the parcelport cache performance counters.

This octotiger commit: https://github.com/dmarce1/octotiger/commit/f43a020fd3e6f0562ea316a18ee5ceadf3cf43cc reproduces the error about 1/2 to 2/3's of the time when run on SuperMIC with 100 nodes. When it happens, the error occurs during oct-tree formation, before the fluid evolution starts.
I have also been getting random freeze ups when the code does run. I have replaced future::get() calls with a trap (octotiger file ./src/future.hpp) that prints a message when a future does not return after 30 seconds (they all should in this case) - I've tested the trap and it works but of course when I run octotiger with traps enabled - the freeze ups do not happen. I'm unsure as to how to tell which future the code is freezing on.

Now when I run with check-pointing enabled (this commit https://github.com/dmarce1/octotiger/commit/d211bab6fb98e550ff18aa4b686484575d84a066) on 100 nodes I get a slightly different parcelport error,
negative entry in reference count table, raw({0000004700000001,<PHONE_NUMBER>b013ec}), refcount(-1073741824): HPX(invalid_data)
gist: https://gist.github.com/dmarce1/bb074097594fdc6b86bb

....and here (same interactive session and executable as last post) - a different error, after grid formation and initial checkpointing,  just as the fluid evolution starts up - hpx is causing a seg fault in MPI_Test:
https://gist.github.com/dmarce1/ac22dbf4d651b1764ec2

I am able to "run" your code now, however, it hangs during node_server::timestep_driver.

I think I may know what has been causing my code some problems. The implementation of "channel" I am using:
https://github.com/dmarce1/octotiger/blob/d211bab6fb98e550ff18aa4b686484575d84a066/src/channel.hpp
has a potential bug in it. The way I'm using it, calling "set_value" can cause the promise to be destroyed before the call to "set_value" completes. (set_value causes get() to return on the waiting thread, which then immediately destroys and replaces the promise) Apparently the standard does not allow this usage, I'm not sure if it applies to HPX or not. I'll fix it either way.

I have a fixed version of your channel relying on hpx::lcos::local::receive_buffer. I will create a PR along with my other fixes to octotiger later today.
On a related note, I could reproduce the MPI_Test segfaults. I am not sure why they occur, however, they can be silenced once the file operations in node_server::save are commented out. Still investigating...

Please see https://github.com/dmarce1/octotiger/pull/1 for my fixes.


remove concurrent map and use a Hash

From the comment: It seems it doesn't need to be threadsafe.
Via https://github.com/zendesk/ruby-kafka/pull/835#issuecomment-646030465
I took a quick look and it seems it's safe to use a simple Hash
Fixes: https://github.com/zendesk/ruby-kafka/issues/842
Fixes: https://github.com/zendesk/ruby-kafka/issues/840

Thanks!


File not found

Getting File not found. message for Bitbucket private repository..

Yep, bitbucket private repos aren't working: #135


Move Kitematic into the Docker Toolbox menu

Signed-off-by: Sven Dowideit<EMAIL_ADDRESS>@moxiegirl this only moves its location in the menu - do you also want to change the URI to http://docs.docker.com/toolbox/kitematic/ ?

LGTM

LGTM


Update aws-core, http-client-spi, ... to 2.17.223

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.218 to 2.17.223.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #885.


Can we document on this page that Delta Live Table is only available for Databricks premium workspace

Hi team,
Delta Live Table is only available on premium workspace:
https://databricks.com/product/azure-pricing
Can we document this like other pages such as cluster access control:
https://docs.microsoft.com/en-us/azure/databricks/security/access-control/cluster-acl
Thanks a lot for all the help!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38ee4bbb-fda6-03ca-4b2e-a2d53a9c8bf6
Version Independent ID: c789123f-78b9-f941-21f2-77988b076c65
Content: Delta Live Tables - Azure Databricks
Content Source: databricks/data-engineering/delta-live-tables/index.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@TeddyBear1314  Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

#please-close


cp: preserve hard links when target already exists

Prevent a panic in cp -a when the target of a hard link already exists in the target directory structure.
For example,
$ mkdir -p src dest/src
$ touch src/f dest/src/f
$ ln src/f src/link
$ cp -a src dest

The cp command now succeeds without error.
This should cause the GNU test suite file tests/cp/preserve-link.sh to pass.

great and well done :)


Instructions on a native setup added to the readme

Feature
Why is this feature being added?

When using this repo locally, you can do so via Docker, a AWS VM, or through a native setup.  We currently have instructions for the first two, but not the latter.
What should your feature do?
Create a set of instructions for setting up this repo natively.  Follows the pattern laid out in https://github.com/OperationCode/operationcode_backend/pull/277

Hello @hpjaj can I get started on this issue? 😄

@aamarill - it's yours!

@hpjaj I apologize for the delay on this!
If you see someone else looking for work, please have them give me a hand with this.
Feel free to update the "status" label to "available".
I don't think I am going to have too much spare time in the coming weeks.
Thanks! 😄

@hpjaj So sorry for the delay on this, but I don't think I can work this anymore. I recommend that you please update the status to "available". In addition, you may want to add a "beginner friendly" tag 😅
Thank you for the opportunity to contribute!

Would a hybrid native/docker/docker-compose development environment work? Wherein the Ruby bits—the web service running in development mode, minitest tests, rubocop, etc—run on the host while services that the backend depends on (Postgres, Redis) continue to run in docker containers. Would that meet the desire for a "native" development environment?

good question. I will have to pull in eyes more familiar with this. @nellshamrell @hollomancer ?

Scoping questions: Is the goal to ...
... avoid requiring a developer to install Docker?
... enable a developer to run the Ruby portions of the backend in a more direct way on their host to ease console access or running a debugger?
What challenges have developers had with docker- and cloud-based development environments that a native setup would address?

... avoid requiring a developer to install Docker?
Potentially, we are trying to be as beginner friendly as possible. Additionally, I anticipate learners will want to know how to set up the environment locally.
... enable a developer to run the Ruby portions of the backend in a more direct way on their host to ease console access or running a debugger?

@robbkidd I suspect that your second option was one of the goals - 'enable a developer to run the Ruby portions of the backend in a more direct way on their host to ease console access or running a debugger'. I'm thinking that we want setup/running of the back-end to be something that is easy and accessible even for beginner devs. I don't have any details as I'm not very active on the back-end team here, but I've seen beginners post questions about difficulties with Docker in our Slack a few times.
It feels like we just want to give developers (especially beginners) more options instead of tying them down to only one type of environment.

@robbkidd @jjhampton @dmarchante Harry helped me set this up natively when I first got involved (a few years ago now?) and it really helps beginning developers to not have to mess with Docker. Plus byebug and Docker aren't friends. It's intimidating to run make commands when you're still figuring out rake commands. The steps are something like this:

Get postres running
Modify the  / etc / hosts file: https://www.tekrevue.com/tip/edit-hosts-file-mac-os-x/
Add <IP_ADDRESS>    operationcode-psql
to your /etc/hosts file enables you to run Rails app that uses Docker, without Docker.
Run redis in a different terminal window.
You're good to go!

Looks like having a variety of options is a good choice.

AWS virtual machine
Docker
Hybrid docker/ native
Completely native.

I understand that docker is daunting for many people, but I feel that it adds so much easy into the process (don't have to modify hosts, don't have to install postgres) but it does add some pain.
A hybrid setup would allow easier debugging, and allow abstracting all the other things?


Add the latest OTP 18 version to the Travis build

See also #295. Once kerl is fixed, travis-ci will be able to make all otp releases available.

Cool, hadn't noticed that one, do you want to try and put #295 through Travis again and see how it behaves?

Sure, but not before next week. In the meantime, feel free to patch kerl :).

To be clear, the missing otp versions won't magically appear. kerl needs to be fixed to build from git tag tarballs, not just what's inside erlang.org/download.

Updated #295.


Automated Package Upgrade

:tada: This PR is included in version 28.2.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[MINOR] docs: update the project introduction in README

What changes were proposed in this pull request?
Update the project introduction in README.
Why are the changes needed?
It is derived from the Uniffle Proposal, hope it introduces the project better.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.

Codecov Report

Merging #653 (2e0a115) into master (b3a10d3) will increase coverage by 2.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #653      +/-   ##
============================================
+ Coverage     60.63%   62.90%   +2.26%
- Complexity     1799     1800       +1
============================================
  Files           216      202      -14
  Lines         12455    10494    -1961
  Branches       1052     1052
============================================
- Hits           7552     6601     -951
+ Misses         4496     3547     -949
+ Partials        407      346      -61

Impacted Files
Coverage Δ

...che/uniffle/coordinator/util/CoordinatorUtils.java
72.00% <0.00%> (ø)

deploy/kubernetes/operator/pkg/utils/certs.go

...pkg/controller/sync/shuffleserver/shuffleserver.go

...tor/pkg/controller/sync/coordinator/coordinator.go

deploy/kubernetes/operator/pkg/utils/config.go

...bernetes/operator/pkg/controller/controller/rss.go

deploy/kubernetes/operator/pkg/utils/rss.go

...y/kubernetes/operator/pkg/webhook/inspector/pod.go

...rnetes/operator/pkg/webhook/inspector/inspector.go

deploy/kubernetes/operator/pkg/utils/util.go

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM except for one minor comment.

Merged. thanks @kaijchen @smallzhongfeng @advancedxy


Materials fail (appear black) in 4.0-beta1

Godot version
4.0-beta1
System information
Ubuntu Mate 20.04
Issue description
While migrating my 3.x addon to 4.0-beta1 I encountered a strange behavior. Materials I create in code, e.g., new StandardMaterial3D() {AlbedoColor = new(1f, 0f, 0f)}; result in black appearance of the objects. This happens regardless of whether I use SetSurfaceOverrideMaterial or assign it directly to the instantiated mesh. I am trying to find out what is the issue for 2 days already.
Steps to reproduce
Godot is quite unstable on my machine, trying to set material details directly in the editor often leads to crashes. However, I figured out that also setting a new material for static geometry in the editor ends up in black cubes being rendered. Yes, I do have a light in the scene. Am I missing something or is this a bug?
Minimal reproduction project
BugReportProceduralMaterial.zip
The left box is static with a material created in the editor. The right box is created in code. Both render fully black.

Which graphics card model and driver are you using? If using open source Mesa drivers, I recommend updating to a newer Mesa stack. You can do this by upgrading to a newer Linux distribution, or by using a third-party repository (PPA).

Thank you very much for the feedback! I now added an Environment in my camera. When I select Background = Sky, I see white cubes. Not red, still wrong, but at least not black.

For other background options they remain black.
Following your suggestion, the result is the same. I see them white/grey, not red.
I have an RTX 3060 Ti, running on nvidia-driver-470.

@isolin Can you (or anyone else) still reproduce this bug in Godot 4.0.rc4 or any later release?

I get similar weird behaviour as well, not sure if related.

StandardMaterial3D mat = new StandardMaterial3D();
mat.AlbedoColor = new Color("#ec6161");

mesh.SetSurfaceOverrideMaterial(0, mat);
GD.Print(mesh.GetSurfaceOverrideMaterial(0)); // prints null

Tried SetSurfaceOverrideMaterial with index 1 just to make sure I'm not going crazy and I get index out of bounds error.
Expected: Mesh renders in red.
Actual result: Mesh renders in original base color.
Remote mesh inspector shows <empty> at 0 index.

I get similar weird behaviour as well, not sure if related.

StandardMaterial3D mat = new StandardMaterial3D();
mat.AlbedoColor = new Color("#ec6161");

mesh.SetSurfaceOverrideMaterial(0, mat);
GD.Print(mesh.GetSurfaceOverrideMaterial(0)); // prints null

Tried SetSurfaceOverrideMaterial with index 1 just to make sure I'm not going crazy and I get index out of bounds error.
Remote mesh inspector shows <empty> at 0 index.
No errors.
Expected: Mesh renders in red.
Actual result: Mesh renders in original base color.

I get similar weird behaviour as well, not sure if related.

StandardMaterial3D mat = new StandardMaterial3D();
mat.AlbedoColor = new Color("#ec6161");

mesh.SetSurfaceOverrideMaterial(0, mat);
GD.Print(mesh.GetSurfaceOverrideMaterial(0)); // prints null

Remote mesh inspector shows <empty> at 0 index. No errors.

Expected: Mesh renders in red.
Actual result: Mesh renders in original base color.

Had very similar issue..
It turned out after 2 frustrating hours of debugging that the code path where material was instantiated didn't run.
There's at least some possibility that OP might have missed something like this as well.
My suggestion for anyone running into this issue:
// MAKE SURE IT'S ACTUALLY INSTANTIATED!
GD.Print($"{mat == null} {mat}");
mesh.SetSurfaceOverrideMaterial(0, mat);

Can you reproduce this with GDScript?


Install libgmp and libsodium when compiling on Ubuntu

Fixed

Adds the gmp extension when we can locate the libgmp.so file on Ubuntu compilation
Adds the sodium extension when we can locate the libsodium.so file on Ubuntu compilation

closes #147

can this be pushed soon? if not, how to install it manually?

Hey, @smorimoto, any thoughts on whether this can be merged? I know the build is failing, but I don't think the cause is in this PR.