Issue-Combine with package micro-web3

Automated Review Comments
Issues in README.md:

(1, 'Line exceeds 80 characters')
(2, 'Line exceeds 80 characters')
(3, 'Line exceeds 80 characters')
(5, 'Line exceeds 80 characters')
(6, 'Line exceeds 80 characters')
(10, 'Line exceeds 80 characters')
(14, 'Line exceeds 80 characters')
(35, 'Line exceeds 80 characters')
(37, 'Hardcoded string found')
(39, 'Line exceeds 80 characters')
(41, 'Hardcoded string found')
(42, 'Line exceeds 80 characters')
(60, 'Line exceeds 80 characters')
(63, 'Line exceeds 80 characters')
(74, 'Hardcoded string found')
(75, 'Hardcoded string found')
(81, 'Line exceeds 80 characters')
(91, 'Hardcoded string found')
(92, 'Hardcoded string found')
(96, 'Line exceeds 80 characters')
(105, 'Line exceeds 80 characters')
(106, 'Line exceeds 80 characters')
(109, 'Line exceeds 80 characters')
(117, 'Hardcoded string found')
(119, 'Line exceeds 80 characters')
(119, 'Hardcoded string found')
(121, 'Line exceeds 80 characters')
(121, 'Hardcoded string found')
(125, 'Line exceeds 80 characters')
Issues in package-lock.json:
(2, 'Hardcoded string found')
(9, 'Hardcoded string found')
(12, 'Hardcoded string found')
(16, 'Hardcoded string found')
(17, 'Hardcoded string found')
(18, 'Line exceeds 80 characters')
(18, 'Hardcoded string found')
(19, 'Hardcoded string found')
(20, 'Hardcoded string found')
(24, 'Hardcoded string found')
(25, 'Line exceeds 80 characters')
(25, 'Hardcoded string found')
(26, 'Line exceeds 80 characters')
(26, 'Hardcoded string found')
(27, 'Hardcoded string found')
(30, 'Hardcoded string found')
(31, 'Line exceeds 80 characters')
(31, 'Hardcoded string found')
(32, 'Line exceeds 80 characters')
(32, 'Hardcoded string found')
(33, 'Hardcoded string found')
(35, 'Hardcoded string found')
(36, 'Hardcoded string found')
(39, 'Hardcoded string found')
(44, 'Hardcoded string found')
(45, 'Line exceeds 80 characters')
(45, 'Hardcoded string found')
(47, 'Line exceeds 80 characters')
(47, 'Hardcoded string found')
(48, 'Line exceeds 80 characters')
(48, 'Hardcoded string found')
(51, 'Hardcoded string found')
(52, 'Hardcoded string found')
(53, 'Line exceeds 80 characters')
(53, 'Hardcoded string found')
(56, 'Hardcoded string found')
(57, 'Line exceeds 80 characters')
(57, 'Hardcoded string found')
(58, 'Line exceeds 80 characters')
(58, 'Hardcoded string found')
(59, 'Hardcoded string found')
(62, 'Hardcoded string found')
(63, 'Line exceeds 80 characters')
(63, 'Hardcoded string found')
(64, 'Line exceeds 80 characters')
(64, 'Hardcoded string found')
(65, 'Hardcoded string found')
(70, 'Hardcoded string found')
(71, 'Line exceeds 80 characters')
(71, 'Hardcoded string found')
Issues in package.json:
(2, 'Hardcoded string found')
(9, 'Hardcoded string found')
(12, 'Hardcoded string found')
(13, 'Hardcoded string found')
(14, 'Hardcoded string found')
(15, 'Hardcoded string found')
(16, 'Hardcoded string found')
Issues in src/_type_test.ts:
(4, 'Line exceeds 80 characters')
(8, 'Hardcoded string found')
(22, 'Line exceeds 80 characters')
(22, 'Hardcoded string found')
(23, 'Line exceeds 80 characters')
(25, 'Line exceeds 80 characters')
(25, 'Hardcoded string found')
(26, 'Line exceeds 80 characters')
(28, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(29, 'Line exceeds 80 characters')
(31, 'Hardcoded string found')
(32, 'Line exceeds 80 characters')
(34, 'Line exceeds 80 characters')
(35, 'Line exceeds 80 characters')
(37, 'Hardcoded string found')
(38, 'Line exceeds 80 characters')
(41, 'Line exceeds 80 characters')
(43, 'Line exceeds 80 characters')
(44, 'Line exceeds 80 characters')
(46, 'Line exceeds 80 characters')
(47, 'Line exceeds 80 characters')
(52, 'Hardcoded string found')
(54, 'Hardcoded string found')
(55, 'Hardcoded string found')
(62, 'Hardcoded string found')
(63, 'Hardcoded string found')
(67, 'Hardcoded string found')
(73, 'Hardcoded string found')
(75, 'Line exceeds 80 characters')
(75, 'Hardcoded string found')
(77, 'Line exceeds 80 characters')
(77, 'Hardcoded string found')
(83, 'Hardcoded string found')
(86, 'Hardcoded string found')
(90, 'Hardcoded string found')
(91, 'Hardcoded string found')
(97, 'Hardcoded string found')
(98, 'Hardcoded string found')
(101, 'Line exceeds 80 characters')
(101, 'Hardcoded string found')
(113, 'Hardcoded string found')
(114, 'Hardcoded string found')
(115, 'Hardcoded string found')
(116, 'Hardcoded string found')
(132, 'Hardcoded string found')
(133, 'Hardcoded string found')
(134, 'Hardcoded string found')
(135, 'Hardcoded string found')
(145, 'Hardcoded string found')
(146, 'Hardcoded string found')
(147, 'Hardcoded string found')
(148, 'Hardcoded string found')
(155, 'Hardcoded string found')
(156, 'Hardcoded string found')
(160, 'Hardcoded string found')
(168, 'Line exceeds 80 characters')
(176, 'Hardcoded string found')
(177, 'Hardcoded string found')
(178, 'Hardcoded string found')
(180, 'Hardcoded string found')
(181, 'Hardcoded string found')
(187, 'Line exceeds 80 characters')
Issues in src/api/chainlink.ts:
(8, 'Hardcoded string found')
(9, 'Hardcoded string found')
(11, 'Hardcoded string found')
(12, 'Hardcoded string found')
(13, 'Hardcoded string found')
(14, 'Hardcoded string found')
(15, 'Hardcoded string found')
(20, 'Line exceeds 80 characters')
(276, 'Hardcoded string found')
(281, 'Hardcoded string found')
(289, 'Line exceeds 80 characters')
(295, 'Line exceeds 80 characters')
(309, 'Line exceeds 80 characters')
Issues in src/api/ens.ts:
(19, 'Hardcoded string found')
(20, 'Hardcoded string found')
(21, 'Hardcoded string found')
(22, 'Hardcoded string found')
(27, 'Hardcoded string found')
(28, 'Hardcoded string found')
(29, 'Hardcoded string found')
(30, 'Hardcoded string found')
(33, 'Hardcoded string found')
(34, 'Hardcoded string found')
(35, 'Hardcoded string found')
(36, 'Hardcoded string found')
(40, 'Line exceeds 80 characters')
(46, 'Line exceeds 80 characters')
(55, 'Line exceeds 80 characters')
(65, 'Line exceeds 80 characters')
Issues in src/api/uniswap-common.ts:
(8, 'Line exceeds 80 characters')
(34, 'Hardcoded string found')
(35, 'Hardcoded string found')
(38, 'Line exceeds 80 characters')
(43, 'Line exceeds 80 characters')
(53, 'Hardcoded string found')
(65, 'Hardcoded string found')
(71, 'Hardcoded string found')
(72, 'Hardcoded string found')
(82, 'Line exceeds 80 characters')
(82, 'Hardcoded string found')
(85, 'Hardcoded string found')
(90, 'Hardcoded string found')
(101, 'Hardcoded string found')
(107, 'Hardcoded string found')
(108, 'Hardcoded string found')
(109, 'Hardcoded string found')
(116, 'Line exceeds 80 characters')
(129, 'Hardcoded string found')
(130, 'Hardcoded string found')
(133, 'Hardcoded string found')
(134, 'Hardcoded string found')
(178, 'Hardcoded string found')
Issues in src/api/uniswap-v2.ts:
(15, 'Hardcoded string found')
(16, 'Hardcoded string found')
(20, 'Hardcoded string found')
(25, 'Line exceeds 80 characters')
(27, 'Line exceeds 80 characters')
(31, 'Line exceeds 80 characters')
(32, 'Line exceeds 80 characters')
(32, 'Hardcoded string found')
(33, 'Line exceeds 80 characters')
(34, 'Line exceeds 80 characters')
(37, 'Line exceeds 80 characters')
(45, 'Line exceeds 80 characters')
(46, 'Line exceeds 80 characters')
(54, 'Line exceeds 80 characters')
(59, 'Line exceeds 80 characters')
(64, 'Line exceeds 80 characters')
(85, 'Line exceeds 80 characters')
(93, 'Line exceeds 80 characters')
(105, 'Line exceeds 80 characters')
(110, 'Line exceeds 80 characters')
(112, 'Hardcoded string found')
(116, 'Line exceeds 80 characters')
(118, 'Line exceeds 80 characters')
(149, 'Line exceeds 80 characters')
(150, 'Hardcoded string found')
(151, 'Line exceeds 80 characters')
(151, 'Hardcoded string found')
(152, 'Hardcoded string found')
(153, 'Hardcoded string found')
(154, 'Hardcoded string found')
(155, 'Hardcoded string found')
(158, 'Line exceeds 80 characters')
(160, 'Hardcoded string found')
(161, 'Hardcoded string found')
(162, 'Hardcoded string found')
(163, 'Hardcoded string found')
(164, 'Hardcoded string found')
(165, 'Hardcoded string found')
(166, 'Hardcoded string found')
(167, 'Hardcoded string found')
(168, 'Line exceeds 80 characters')
(180, 'Hardcoded string found')
(182, 'Line exceeds 80 characters')
(182, 'Hardcoded string found')
(186, 'Line exceeds 80 characters')
(202, 'Line exceeds 80 characters')
Issues in src/api/uniswap-v3.ts:
(12, 'Hardcoded string found')
(13, 'Hardcoded string found')
(15, 'Hardcoded string found')
(16, 'Hardcoded string found')
(18, 'Hardcoded string found')
(21, 'Hardcoded string found')
(22, 'Hardcoded string found')
(24, 'Hardcoded string found')
(25, 'Hardcoded string found')
(26, 'Hardcoded string found')
(27, 'Hardcoded string found')
(30, 'Hardcoded string found')
(33, 'Hardcoded string found')
(34, 'Hardcoded string found')
(36, 'Hardcoded string found')
(37, 'Hardcoded string found')
(39, 'Hardcoded string found')
(42, 'Hardcoded string found')
(43, 'Hardcoded string found')
(45, 'Hardcoded string found')
(46, 'Hardcoded string found')
(47, 'Hardcoded string found')
(48, 'Hardcoded string found')
(51, 'Hardcoded string found')
(61, 'Line exceeds 80 characters')
(68, 'Line exceeds 80 characters')
(75, 'Line exceeds 80 characters')
(99, 'Line exceeds 80 characters')
(100, 'Hardcoded string found')
(101, 'Hardcoded string found')
(137, 'Line exceeds 80 characters')
(141, 'Line exceeds 80 characters')
(141, 'Hardcoded string found')
(152, 'Line exceeds 80 characters')
(154, 'Hardcoded string found')
(172, 'Line exceeds 80 characters')
(172, 'Hardcoded string found')
(173, 'Hardcoded string found')
(174, 'Hardcoded string found')
(175, 'Hardcoded string found')
(176, 'Hardcoded string found')
(180, 'Line exceeds 80 characters')
(180, 'Hardcoded string found')
(185, 'Line exceeds 80 characters')
(185, 'Hardcoded string found')
(196, 'Line exceeds 80 characters')
(196, 'Hardcoded string found')
(197, 'Line exceeds 80 characters')
(197, 'Hardcoded string found')
(199, 'Hardcoded string found')
(221, 'Line exceeds 80 characters')
Issues in src/contracts/common.ts:
(6, 'Hardcoded string found')
(11, 'Line exceeds 80 characters')
(19, 'Hardcoded string found')
Issues in src/contracts/erc20.ts:
(9, 'Line exceeds 80 characters')
(9, 'Hardcoded string found')
(15, 'Line exceeds 80 characters')
(16, 'Hardcoded string found')
(17, 'Line exceeds 80 characters')
(23, 'Line exceeds 80 characters')
(24, 'Hardcoded string found')
(31, 'Line exceeds 80 characters')
(32, 'Hardcoded string found')
(38, 'Line exceeds 80 characters')
(39, 'Hardcoded string found')
(40, 'Line exceeds 80 characters')
(45, 'Line exceeds 80 characters')
(46, 'Hardcoded string found')
Issues in src/contracts/erc721.ts:
(4, 'Line exceeds 80 characters')
(4, 'Hardcoded string found')
Issues in src/contracts/index.ts:
(12, 'Line exceeds 80 characters')
(13, 'Line exceeds 80 characters')
(14, 'Line exceeds 80 characters')
(20, 'Hardcoded string found')
(21, 'Hardcoded string found')
(23, 'Hardcoded string found')
(24, 'Hardcoded string found')
(25, 'Hardcoded string found')
(26, 'Hardcoded string found')
(27, 'Hardcoded string found')
(28, 'Hardcoded string found')
(29, 'Hardcoded string found')
(30, 'Hardcoded string found')
(35, 'Line exceeds 80 characters')
(40, 'Line exceeds 80 characters')
(42, 'Hardcoded string found')
(46, 'Line exceeds 80 characters')
(47, 'Line exceeds 80 characters')
(47, 'Hardcoded string found')
(48, 'Line exceeds 80 characters')
(50, 'Line exceeds 80 characters')
(50, 'Hardcoded string found')
Issues in src/contracts/kyber.ts:
(8, 'Line exceeds 80 characters')
(8, 'Hardcoded string found')
(13, 'Hardcoded string found')
(16, 'Hardcoded string found')
(21, 'Hardcoded string found')
(27, 'Line exceeds 80 characters')
Issues in src/contracts/uniswap-v2.ts:
(8, 'Line exceeds 80 characters')
(8, 'Hardcoded string found')
(23, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(29, 'Line exceeds 80 characters')
(36, 'Hardcoded string found')
(37, 'Line exceeds 80 characters')
(40, 'Line exceeds 80 characters')
(42, 'Hardcoded string found')
(43, 'Line exceeds 80 characters')
(48, 'Hardcoded string found')
(49, 'Line exceeds 80 characters')
(54, 'Line exceeds 80 characters')
(56, 'Hardcoded string found')
(57, 'Line exceeds 80 characters')
(64, 'Hardcoded string found')
(65, 'Line exceeds 80 characters')
(73, 'Hardcoded string found')
(77, 'Line exceeds 80 characters')
(80, 'Hardcoded string found')
(87, 'Hardcoded string found')
Issues in src/contracts/uniswap-v3.ts:
(9, 'Line exceeds 80 characters')
(9, 'Hardcoded string found')
(13, 'Hardcoded string found')
(14, 'Line exceeds 80 characters')
(16, 'Line exceeds 80 characters')
(24, 'Hardcoded string found')
(31, 'Line exceeds 80 characters')
(37, 'Line exceeds 80 characters')
(45, 'Hardcoded string found')
(53, 'Hardcoded string found')
(62, 'Hardcoded string found')
(71, 'Hardcoded string found')
Issues in src/contracts/weth.ts:
(7, 'Line exceeds 80 characters')
(7, 'Hardcoded string found')
Issues in src/web3.ts:
(18, 'Hardcoded string found')
(46, 'Line exceeds 80 characters')
(59, 'Line exceeds 80 characters')
(61, 'Hardcoded string found')
(96, 'Line exceeds 80 characters')
(96, 'Hardcoded string found')
(118, 'Line exceeds 80 characters')
(122, 'Hardcoded string found')
(127, 'Line exceeds 80 characters')
(129, 'Line exceeds 80 characters')
(130, 'Line exceeds 80 characters')
(131, 'Line exceeds 80 characters')
(138, 'Line exceeds 80 characters')
(139, 'Line exceeds 80 characters')
(156, 'Line exceeds 80 characters')
(158, 'Line exceeds 80 characters')
(158, 'Hardcoded string found')
(159, 'Line exceeds 80 characters')
(161, 'Hardcoded string found')
(164, 'Hardcoded string found')
(172, 'Hardcoded string found')
(173, 'Hardcoded string found')
(174, 'Hardcoded string found')
(175, 'Hardcoded string found')
(176, 'Hardcoded string found')
(177, 'Hardcoded string found')
(178, 'Hardcoded string found')
(179, 'Hardcoded string found')
(180, 'Hardcoded string found')
(187, 'Hardcoded string found')
(193, 'Line exceeds 80 characters')
(201, 'Line exceeds 80 characters')
(209, 'Hardcoded string found')
(210, 'Line exceeds 80 characters')
(222, 'Line exceeds 80 characters')
(231, 'Hardcoded string found')
(232, 'Line exceeds 80 characters')
(233, 'Hardcoded string found')
(235, 'Hardcoded string found')
(236, 'Hardcoded string found')
(238, 'Hardcoded string found')
(253, 'TODO found')
(272, 'Hardcoded string found')
(287, 'Hardcoded string found')
(296, 'Hardcoded string found')
(297, 'Line exceeds 80 characters')
(301, 'Hardcoded string found')
(308, 'Hardcoded string found')
(309, 'Hardcoded string found')
(351, 'Line exceeds 80 characters')
(355, 'Line exceeds 80 characters')
(355, 'Hardcoded string found')
(361, 'Hardcoded string found')
(362, 'Line exceeds 80 characters')
(362, 'Hardcoded string found')
(363, 'Hardcoded string found')
(364, 'Line exceeds 80 characters')
(365, 'Line exceeds 80 characters')
(380, 'Line exceeds 80 characters')
(381, 'Line exceeds 80 characters')
(382, 'Line exceeds 80 characters')
(383, 'Line exceeds 80 characters')
(403, 'Hardcoded string found')
(404, 'Hardcoded string found')
(410, 'Hardcoded string found')
(411, 'Hardcoded string found')
(418, 'Line exceeds 80 characters')
(423, 'Hardcoded string found')
(428, 'Line exceeds 80 characters')
(434, 'Line exceeds 80 characters')
(436, 'Hardcoded string found')
(438, 'Line exceeds 80 characters')
(445, 'Hardcoded string found')
(449, 'Line exceeds 80 characters')
(454, 'Hardcoded string found')
(455, 'Hardcoded string found')
(463, 'Hardcoded string found')
(467, 'TODO found')
(468, 'Line exceeds 80 characters')
(472, 'Hardcoded string found')
(479, 'Hardcoded string found')
(483, 'Line exceeds 80 characters')
(483, 'Hardcoded string found')
(489, 'Line exceeds 80 characters')
(490, 'Line exceeds 80 characters')
(490, 'Hardcoded string found')
(493, 'Line exceeds 80 characters')
(493, 'Hardcoded string found')
(498, 'Line exceeds 80 characters')
(503, 'Line exceeds 80 characters')
(508, 'Line exceeds 80 characters')
(510, 'Hardcoded string found')
(511, 'Line exceeds 80 characters')
(514, 'Line exceeds 80 characters')
(521, 'Line exceeds 80 characters')
(521, 'Hardcoded string found')
(525, 'Line exceeds 80 characters')
(526, 'Hardcoded string found')
(527, 'Line exceeds 80 characters')
(528, 'Hardcoded string found')
(541, 'Line exceeds 80 characters')
(541, 'Hardcoded string found')
(542, 'Line exceeds 80 characters')
(580, 'Line exceeds 80 characters')
(592, 'Hardcoded string found')
(595, 'Hardcoded string found')
(597, 'Line exceeds 80 characters')
(604, 'Hardcoded string found')
(637, 'Line exceeds 80 characters')
(643, 'Line exceeds 80 characters')
(651, 'Line exceeds 80 characters')
(672, 'Line exceeds 80 characters')
Issues in test/abi.test.js:
(16, 'Hardcoded string found')
(17, 'Line exceeds 80 characters')
(17, 'Hardcoded string found')
(36, 'Hardcoded string found')
(37, 'Line exceeds 80 characters')
(37, 'Hardcoded string found')
(56, 'Hardcoded string found')
(57, 'Line exceeds 80 characters')
(57, 'Hardcoded string found')
(71, 'Line exceeds 80 characters')
(72, 'Line exceeds 80 characters')
(72, 'Hardcoded string found')
(78, 'Line exceeds 80 characters')
(79, 'Line exceeds 80 characters')
(79, 'Hardcoded string found')
(89, 'Line exceeds 80 characters')
(89, 'Hardcoded string found')
(99, 'Line exceeds 80 characters')
(99, 'Hardcoded string found')
(106, 'Line exceeds 80 characters')
(106, 'Hardcoded string found')
(113, 'Line exceeds 80 characters')
(113, 'Hardcoded string found')
(119, 'Line exceeds 80 characters')
(120, 'Line exceeds 80 characters')
(120, 'Hardcoded string found')
(126, 'Line exceeds 80 characters')
(127, 'Line exceeds 80 characters')
(127, 'Hardcoded string found')
(139, 'Line exceeds 80 characters')
(139, 'Hardcoded string found')
(151, 'Line exceeds 80 characters')
(151, 'Hardcoded string found')
(156, 'Line exceeds 80 characters')
(157, 'Line exceeds 80 characters')
(158, 'Line exceeds 80 characters')
(158, 'Hardcoded string found')
(159, 'Hardcoded string found')
(160, 'Hardcoded string found')
(163, 'Line exceeds 80 characters')
(164, 'Line exceeds 80 characters')
(165, 'Line exceeds 80 characters')
(165, 'Hardcoded string found')
(166, 'Hardcoded string found')
(167, 'Hardcoded string found')
(175, 'Line exceeds 80 characters')
(175, 'Hardcoded string found')
(176, 'Line exceeds 80 characters')
(177, 'Hardcoded string found')
(185, 'Line exceeds 80 characters')
(185, 'Hardcoded string found')
(186, 'Line exceeds 80 characters')
(187, 'Hardcoded string found')
(190, 'Line exceeds 80 characters')
(191, 'Line exceeds 80 characters')
(192, 'Line exceeds 80 characters')
(192, 'Hardcoded string found')
(202, 'Line exceeds 80 characters')
(202, 'Hardcoded string found')
(203, 'Line exceeds 80 characters')
(207, 'Line exceeds 80 characters')
(208, 'Line exceeds 80 characters')
(209, 'Line exceeds 80 characters')
(209, 'Hardcoded string found')
(219, 'Line exceeds 80 characters')
(219, 'Hardcoded string found')
(220, 'Line exceeds 80 characters')
(224, 'Line exceeds 80 characters')
(225, 'Line exceeds 80 characters')
(226, 'Line exceeds 80 characters')
(226, 'Hardcoded string found')
(248, 'Line exceeds 80 characters')
(248, 'Hardcoded string found')
(249, 'Line exceeds 80 characters')
(259, 'Line exceeds 80 characters')
(261, 'Line exceeds 80 characters')
(262, 'Line exceeds 80 characters')
(262, 'Hardcoded string found')
(287, 'Line exceeds 80 characters')
(287, 'Hardcoded string found')
(288, 'Line exceeds 80 characters')
(299, 'Line exceeds 80 characters')
(301, 'Line exceeds 80 characters')
(302, 'Line exceeds 80 characters')
(302, 'Hardcoded string found')
(308, 'Line exceeds 80 characters')
(309, 'Line exceeds 80 characters')
(310, 'Line exceeds 80 characters')
(310, 'Hardcoded string found')
(314, 'Line exceeds 80 characters')
(316, 'Line exceeds 80 characters')
(324, 'Line exceeds 80 characters')
(326, 'Line exceeds 80 characters')
(333, 'Line exceeds 80 characters')
(334, 'Line exceeds 80 characters')
(335, 'Line exceeds 80 characters')
(335, 'Hardcoded string found')
(339, 'Line exceeds 80 characters')
(341, 'Line exceeds 80 characters')
(349, 'Line exceeds 80 characters')
(351, 'Line exceeds 80 characters')
(359, 'Line exceeds 80 characters')
(365, 'Line exceeds 80 characters')
(365, 'Hardcoded string found')
(371, 'Line exceeds 80 characters')
(379, 'Line exceeds 80 characters')
(390, 'Line exceeds 80 characters')
(390, 'Hardcoded string found')
(404, 'Line exceeds 80 characters')
(412, 'Hardcoded string found')
(413, 'Hardcoded string found')
(416, 'Hardcoded string found')
(417, 'Hardcoded string found')
(420, 'Hardcoded string found')
(424, 'Hardcoded string found')
(428, 'Hardcoded string found')
(432, 'Hardcoded string found')
(436, 'Hardcoded string found')
(444, 'Hardcoded string found')
(445, 'Hardcoded string found')
(448, 'Hardcoded string found')
(452, 'Hardcoded string found')
(458, 'Hardcoded string found')
(474, 'Hardcoded string found')
(475, 'Hardcoded string found')
(479, 'Hardcoded string found')
(480, 'Hardcoded string found')
(484, 'Hardcoded string found')
(488, 'Hardcoded string found')
(489, 'Hardcoded string found')
(499, 'Hardcoded string found')
(500, 'Hardcoded string found')
(504, 'Hardcoded string found')
(505, 'Hardcoded string found')
(509, 'Hardcoded string found')
(513, 'Hardcoded string found')
(514, 'Hardcoded string found')
(523, 'Hardcoded string found')
(524, 'Hardcoded string found')
(528, 'Hardcoded string found')
(531, 'Hardcoded string found')
(532, 'Hardcoded string found')
(540, 'Hardcoded string found')
(541, 'Hardcoded string found')
(544, 'Hardcoded string found')
(545, 'Hardcoded string found')
(549, 'Hardcoded string found')
(557, 'Hardcoded string found')
(558, 'Hardcoded string found')
(562, 'Hardcoded string found')
(565, 'Hardcoded string found')
(566, 'Hardcoded string found')
(574, 'Hardcoded string found')
(575, 'Hardcoded string found')
(582, 'Hardcoded string found')
(583, 'Hardcoded string found')
(586, 'Hardcoded string found')
(590, 'Hardcoded string found')
(591, 'Hardcoded string found')
(594, 'Hardcoded string found')
(598, 'Hardcoded string found')
(625, 'Hardcoded string found')
(627, 'Hardcoded string found')
(630, 'Hardcoded string found')
(632, 'Hardcoded string found')
(633, 'Hardcoded string found')
(648, 'Hardcoded string found')
(650, 'Hardcoded string found')
(651, 'Hardcoded string found')
(661, 'Hardcoded string found')
(663, 'Hardcoded string found')
(664, 'Hardcoded string found')
(670, 'Hardcoded string found')
(674, 'Hardcoded string found')
(675, 'Hardcoded string found')
(676, 'Hardcoded string found')
(679, 'Hardcoded string found')
(682, 'Hardcoded string found')
(683, 'Hardcoded string found')
(684, 'Hardcoded string found')
(687, 'Hardcoded string found')
(688, 'Hardcoded string found')
(692, 'Hardcoded string found')
(700, 'Hardcoded string found')
(702, 'Hardcoded string found')
(710, 'Hardcoded string found')
(711, 'Hardcoded string found')
(719, 'Hardcoded string found')
(724, 'Hardcoded string found')
(731, 'Hardcoded string found')
(736, 'Hardcoded string found')
(741, 'Hardcoded string found')
(747, 'Hardcoded string found')
(753, 'Hardcoded string found')
(758, 'Hardcoded string found')
(764, 'Hardcoded string found')
(772, 'Hardcoded string found')
(774, 'Hardcoded string found')
(775, 'Hardcoded string found')
(780, 'Hardcoded string found')
(782, 'Hardcoded string found')
(785, 'Hardcoded string found')
(787, 'Hardcoded string found')
(795, 'Hardcoded string found')
(797, 'Hardcoded string found')
(798, 'Hardcoded string found')
(802, 'Hardcoded string found')
(804, 'Line exceeds 80 characters')
(806, 'Hardcoded string found')
(807, 'Line exceeds 80 characters')
(817, 'Hardcoded string found')
(822, 'Hardcoded string found')
(839, 'Hardcoded string found')
(840, 'Hardcoded string found')
(842, 'Hardcoded string found')
(844, 'Hardcoded string found')
(849, 'Line exceeds 80 characters')
(851, 'Hardcoded string found')
(853, 'Hardcoded string found')
(855, 'Hardcoded string found')
(859, 'Line exceeds 80 characters')
(859, 'Hardcoded string found')
(862, 'Line exceeds 80 characters')
(862, 'Hardcoded string found')
(863, 'Hardcoded string found')
(882, 'Hardcoded string found')
(883, 'Hardcoded string found')
(884, 'Line exceeds 80 characters')
(887, 'Hardcoded string found')
(888, 'Hardcoded string found')
(889, 'Line exceeds 80 characters')
(892, 'Hardcoded string found')
(893, 'Hardcoded string found')
(894, 'Line exceeds 80 characters')
(896, 'Line exceeds 80 characters')
(897, 'Line exceeds 80 characters')
(898, 'Line exceeds 80 characters')
(899, 'Line exceeds 80 characters')
(900, 'Line exceeds 80 characters')
(901, 'Line exceeds 80 characters')
(902, 'Line exceeds 80 characters')
(902, 'Hardcoded string found')
(903, 'Line exceeds 80 characters')
(904, 'Line exceeds 80 characters')
(905, 'Line exceeds 80 characters')
(906, 'Line exceeds 80 characters')
(908, 'Hardcoded string found')
(913, 'Hardcoded string found')
(919, 'Line exceeds 80 characters')
(920, 'Line exceeds 80 characters')
(924, 'Line exceeds 80 characters')
(925, 'Line exceeds 80 characters')
(926, 'Line exceeds 80 characters')
(931, 'Line exceeds 80 characters')
(932, 'Line exceeds 80 characters')
(945, 'Line exceeds 80 characters')
(946, 'Line exceeds 80 characters')
(962, 'Line exceeds 80 characters')
(963, 'Line exceeds 80 characters')
(977, 'Line exceeds 80 characters')
(977, 'Hardcoded string found')
(978, 'Line exceeds 80 characters')
(978, 'Hardcoded string found')
(979, 'Line exceeds 80 characters')
(979, 'Hardcoded string found')
(995, 'Line exceeds 80 characters')
(995, 'Hardcoded string found')
(996, 'Line exceeds 80 characters')
(996, 'Hardcoded string found')
(997, 'Line exceeds 80 characters')
(997, 'Hardcoded string found')
(1027, 'Hardcoded string found')
(1028, 'Line exceeds 80 characters')
(1029, 'Hardcoded string found')
(1032, 'Hardcoded string found')
(1039, 'Hardcoded string found')
(1040, 'Line exceeds 80 characters')
(1046, 'Hardcoded string found')
(1048, 'Line exceeds 80 characters')
(1056, 'Hardcoded string found')
(1069, 'Hardcoded string found')
(1077, 'Hardcoded string found')
(1086, 'Line exceeds 80 characters')
(1091, 'Hardcoded string found')
(1110, 'Line exceeds 80 characters')
(1111, 'Line exceeds 80 characters')
(1112, 'Line exceeds 80 characters')
(1113, 'Line exceeds 80 characters')
(1114, 'Line exceeds 80 characters')
(1115, 'Line exceeds 80 characters')
(1116, 'Line exceeds 80 characters')
(1117, 'Line exceeds 80 characters')
(1118, 'Line exceeds 80 characters')
(1133, 'Line exceeds 80 characters')
(1156, 'Hardcoded string found')
(1169, 'Line exceeds 80 characters')
(1170, 'Hardcoded string found')
(1190, 'Line exceeds 80 characters')
(1215, 'Hardcoded string found')
(1235, 'Line exceeds 80 characters')
(1237, 'Line exceeds 80 characters')
(1242, 'Hardcoded string found')
(1257, 'Hardcoded string found')
(1262, 'Line exceeds 80 characters')
(1263, 'Line exceeds 80 characters')
(1263, 'Hardcoded string found')
(1266, 'Hardcoded string found')
(1267, 'Hardcoded string found')
(1268, 'Line exceeds 80 characters')
(1270, 'Line exceeds 80 characters')
(1273, 'Hardcoded string found')
(1285, 'Line exceeds 80 characters')
(1285, 'Hardcoded string found')
(1288, 'Hardcoded string found')
(1291, 'Hardcoded string found')
(1293, 'Line exceeds 80 characters')
(1294, 'Line exceeds 80 characters')
(1294, 'Hardcoded string found')
(1295, 'Line exceeds 80 characters')
(1296, 'Line exceeds 80 characters')
(1297, 'Line exceeds 80 characters')
(1298, 'Line exceeds 80 characters')
(1299, 'Line exceeds 80 characters')
(1300, 'Line exceeds 80 characters')
(1301, 'Line exceeds 80 characters')
(1302, 'Line exceeds 80 characters')
(1303, 'Line exceeds 80 characters')
(1303, 'Hardcoded string found')
(1304, 'Line exceeds 80 characters')
(1304, 'Hardcoded string found')
(1305, 'Line exceeds 80 characters')
(1305, 'Hardcoded string found')
(1306, 'Line exceeds 80 characters')
(1306, 'Hardcoded string found')
(1307, 'Line exceeds 80 characters')
(1307, 'Hardcoded string found')
(1308, 'Line exceeds 80 characters')
(1308, 'Hardcoded string found')
(1309, 'Line exceeds 80 characters')
(1309, 'Hardcoded string found')
(1310, 'Line exceeds 80 characters')
(1310, 'Hardcoded string found')
(1311, 'Line exceeds 80 characters')
(1311, 'Hardcoded string found')
(1312, 'Line exceeds 80 characters')
(1312, 'Hardcoded string found')
(1315, 'Hardcoded string found')
(1320, 'Line exceeds 80 characters')
(1322, 'Line exceeds 80 characters')
(1325, 'Hardcoded string found')
(1336, 'Hardcoded string found')
(1356, 'Hardcoded string found')
(1357, 'Hardcoded string found')
(1358, 'Hardcoded string found')
(1359, 'Hardcoded string found')
(1360, 'Hardcoded string found')
(1361, 'Hardcoded string found')
(1362, 'Hardcoded string found')
(1363, 'Hardcoded string found')
(1364, 'Hardcoded string found')
(1365, 'Hardcoded string found')
(1366, 'Hardcoded string found')
(1370, 'Line exceeds 80 characters')
(1374, 'Line exceeds 80 characters')
(1377, 'Line exceeds 80 characters')
(1378, 'Line exceeds 80 characters')
(1381, 'Line exceeds 80 characters')
(1385, 'Line exceeds 80 characters')
(1388, 'Line exceeds 80 characters')
(1392, 'Line exceeds 80 characters')
(1395, 'Line exceeds 80 characters')
(1398, 'Line exceeds 80 characters')
(1399, 'Line exceeds 80 characters')
(1406, 'Line exceeds 80 characters')
(1410, 'Line exceeds 80 characters')
(1414, 'Line exceeds 80 characters')
(1417, 'Line exceeds 80 characters')
(1420, 'Line exceeds 80 characters')
(1421, 'Line exceeds 80 characters')
(1424, 'Line exceeds 80 characters')
(1428, 'Line exceeds 80 characters')
(1434, 'Line exceeds 80 characters')
(1438, 'Line exceeds 80 characters')
(1442, 'Line exceeds 80 characters')
(1445, 'Line exceeds 80 characters')
(1449, 'Line exceeds 80 characters')
(1458, 'Line exceeds 80 characters')
(1462, 'Line exceeds 80 characters')
(1465, 'Line exceeds 80 characters')
(1466, 'Line exceeds 80 characters')
(1469, 'Line exceeds 80 characters')
(1472, 'Line exceeds 80 characters')
(1473, 'Line exceeds 80 characters')
(1476, 'Line exceeds 80 characters')
(1480, 'Line exceeds 80 characters')
(1482, 'TODO found')
(1484, 'Line exceeds 80 characters')
(1488, 'Line exceeds 80 characters')
(1495, 'Hardcoded string found')
(1496, 'Hardcoded string found')
(1497, 'Hardcoded string found')
(1504, 'Line exceeds 80 characters')
(1512, 'Line exceeds 80 characters')
(1541, 'Hardcoded string found')
(1548, 'Line exceeds 80 characters')
(1560, 'Hardcoded string found')
(1564, 'Line exceeds 80 characters')
(1568, 'Line exceeds 80 characters')
(1571, 'Line exceeds 80 characters')
(1572, 'Line exceeds 80 characters')
(1574, 'Line exceeds 80 characters')
Issues in test/uniswap.test.js:
(2, 'Hardcoded string found')
(55, 'Hardcoded string found')
(62, 'Line exceeds 80 characters')
(63, 'Line exceeds 80 characters')
(72, 'Line exceeds 80 characters')
(73, 'Line exceeds 80 characters')
(88, 'Hardcoded string found')
(101, 'Line exceeds 80 characters')
(121, 'Line exceeds 80 characters')
(128, 'Hardcoded string found')
(140, 'Line exceeds 80 characters')
(146, 'Hardcoded string found')
(159, 'Line exceeds 80 characters')
(172, 'Hardcoded string found')
(185, 'Line exceeds 80 characters')
(193, 'Hardcoded string found')
(211, 'Line exceeds 80 characters')
(214, 'Line exceeds 80 characters')
(217, 'Hardcoded string found')
(236, 'Line exceeds 80 characters')
Issues in test/web3js-transactions.json:
(4, 'Hardcoded string found')
(5, 'Hardcoded string found')
(6, 'Line exceeds 80 characters')
(6, 'Hardcoded string found')
(7, 'Hardcoded string found')
(8, 'Hardcoded string found')
(9, 'Hardcoded string found')
(10, 'Hardcoded string found')
(11, 'Hardcoded string found')
(12, 'Hardcoded string found')
(13, 'Hardcoded string found')
(14, 'Hardcoded string found')
(15, 'Hardcoded string found')
(16, 'Hardcoded string found')
(17, 'Hardcoded string found')
(18, 'Hardcoded string found')
(19, 'Hardcoded string found')
(20, 'Hardcoded string found')
(22, 'Hardcoded string found')
(25, 'Line exceeds 80 characters')
(25, 'Hardcoded string found')
(26, 'Line exceeds 80 characters')
(26, 'Hardcoded string found')
(27, 'Line exceeds 80 characters')
(27, 'Hardcoded string found')
(28, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(31, 'Hardcoded string found')
(32, 'Hardcoded string found')
(33, 'Line exceeds 80 characters')
(33, 'Hardcoded string found')
(34, 'Hardcoded string found')
(35, 'Hardcoded string found')
(36, 'Hardcoded string found')
(37, 'Hardcoded string found')
(38, 'Hardcoded string found')
(39, 'Hardcoded string found')
(40, 'Hardcoded string found')
(41, 'Hardcoded string found')
(42, 'Hardcoded string found')
(43, 'Hardcoded string found')
(44, 'Hardcoded string found')
(45, 'Hardcoded string found')
(46, 'Hardcoded string found')
(47, 'Hardcoded string found')
(48, 'Hardcoded string found')
(50, 'Hardcoded string found')
(53, 'Line exceeds 80 characters')
(53, 'Hardcoded string found')
(54, 'Line exceeds 80 characters')
(54, 'Hardcoded string found')
(55, 'Line exceeds 80 characters')
(55, 'Hardcoded string found')
(56, 'Line exceeds 80 characters')
(56, 'Hardcoded string found')
(57, 'Line exceeds 80 characters')
(57, 'Hardcoded string found')
(58, 'Line exceeds 80 characters')
(58, 'Hardcoded string found')
(61, 'Hardcoded string found')
(62, 'Hardcoded string found')
(63, 'Line exceeds 80 characters')
(63, 'Hardcoded string found')
(64, 'Hardcoded string found')
(65, 'Hardcoded string found')
(66, 'Hardcoded string found')
(67, 'Hardcoded string found')
(68, 'Hardcoded string found')
(69, 'Hardcoded string found')
(70, 'Hardcoded string found')
(71, 'Hardcoded string found')
(72, 'Hardcoded string found')
(73, 'Hardcoded string found')
(74, 'Hardcoded string found')
(75, 'Hardcoded string found')
(76, 'Hardcoded string found')
(77, 'Hardcoded string found')
(78, 'Hardcoded string found')
(80, 'Hardcoded string found')
(83, 'Line exceeds 80 characters')
(83, 'Hardcoded string found')
(84, 'Line exceeds 80 characters')
(84, 'Hardcoded string found')
(85, 'Line exceeds 80 characters')
(85, 'Hardcoded string found')
(86, 'Line exceeds 80 characters')
(86, 'Hardcoded string found')
(87, 'Line exceeds 80 characters')
(87, 'Hardcoded string found')
(88, 'Line exceeds 80 characters')
(88, 'Hardcoded string found')
(91, 'Hardcoded string found')
(92, 'Hardcoded string found')
(93, 'Line exceeds 80 characters')
(93, 'Hardcoded string found')
(94, 'Hardcoded string found')
(95, 'Hardcoded string found')
(96, 'Hardcoded string found')
(97, 'Hardcoded string found')
(98, 'Hardcoded string found')
(99, 'Hardcoded string found')
(100, 'Hardcoded string found')
(101, 'Hardcoded string found')
(102, 'Hardcoded string found')
(103, 'Hardcoded string found')
(104, 'Hardcoded string found')
(105, 'Hardcoded string found')
(106, 'Hardcoded string found')
(107, 'Hardcoded string found')
(108, 'Hardcoded string found')
(110, 'Hardcoded string found')
(113, 'Line exceeds 80 characters')
(113, 'Hardcoded string found')
(114, 'Line exceeds 80 characters')
(114, 'Hardcoded string found')
(115, 'Line exceeds 80 characters')
(115, 'Hardcoded string found')
(116, 'Line exceeds 80 characters')
(116, 'Hardcoded string found')
(117, 'Line exceeds 80 characters')
(117, 'Hardcoded string found')
(118, 'Line exceeds 80 characters')
(118, 'Hardcoded string found')
(121, 'Hardcoded string found')
(122, 'Hardcoded string found')
(123, 'Line exceeds 80 characters')
(123, 'Hardcoded string found')
(124, 'Hardcoded string found')
(125, 'Hardcoded string found')
(126, 'Hardcoded string found')
(127, 'Hardcoded string found')
(128, 'Hardcoded string found')
(129, 'Hardcoded string found')
(130, 'Hardcoded string found')
(131, 'Hardcoded string found')
(132, 'Hardcoded string found')
(133, 'Hardcoded string found')
(134, 'Hardcoded string found')
(135, 'Hardcoded string found')
(136, 'Hardcoded string found')
(137, 'Hardcoded string found')
(139, 'Hardcoded string found')
(142, 'Line exceeds 80 characters')
(142, 'Hardcoded string found')
(143, 'Line exceeds 80 characters')
(143, 'Hardcoded string found')
(144, 'Line exceeds 80 characters')
(144, 'Hardcoded string found')
(145, 'Line exceeds 80 characters')
(145, 'Hardcoded string found')
(148, 'Hardcoded string found')
(149, 'Line exceeds 80 characters')
(149, 'Hardcoded string found')
(150, 'Hardcoded string found')
(151, 'Hardcoded string found')
(152, 'Hardcoded string found')
(153, 'Hardcoded string found')
(154, 'Hardcoded string found')
(155, 'Hardcoded string found')
(156, 'Hardcoded string found')
(157, 'Hardcoded string found')
(158, 'Hardcoded string found')
(159, 'Hardcoded string found')
(160, 'Hardcoded string found')
(161, 'Hardcoded string found')
(162, 'Hardcoded string found')
(163, 'Hardcoded string found')
(165, 'Hardcoded string found')
(168, 'Line exceeds 80 characters')
(168, 'Hardcoded string found')
(169, 'Line exceeds 80 characters')
(169, 'Hardcoded string found')
(170, 'Line exceeds 80 characters')
(170, 'Hardcoded string found')
(171, 'Line exceeds 80 characters')
(171, 'Hardcoded string found')
(174, 'Hardcoded string found')
(175, 'Line exceeds 80 characters')
(175, 'Hardcoded string found')
(176, 'Hardcoded string found')
(177, 'Hardcoded string found')
(178, 'Hardcoded string found')
(179, 'Hardcoded string found')
(180, 'Hardcoded string found')
(181, 'Hardcoded string found')
(182, 'Hardcoded string found')
(183, 'Hardcoded string found')
(184, 'Hardcoded string found')
(185, 'Hardcoded string found')
(186, 'Hardcoded string found')
(187, 'Hardcoded string found')
(188, 'Hardcoded string found')
(189, 'Hardcoded string found')
(191, 'Hardcoded string found')
(194, 'Line exceeds 80 characters')
(194, 'Hardcoded string found')
(195, 'Line exceeds 80 characters')
(195, 'Hardcoded string found')
(196, 'Line exceeds 80 characters')
(196, 'Hardcoded string found')
(197, 'Line exceeds 80 characters')
(197, 'Hardcoded string found')
(200, 'Hardcoded string found')
(201, 'Line exceeds 80 characters')
(201, 'Hardcoded string found')
(202, 'Hardcoded string found')
(203, 'Hardcoded string found')
(204, 'Hardcoded string found')
(205, 'Hardcoded string found')
(206, 'Hardcoded string found')
(207, 'Hardcoded string found')
(208, 'Hardcoded string found')
(209, 'Hardcoded string found')
(210, 'Hardcoded string found')
(211, 'Hardcoded string found')
(212, 'Hardcoded string found')
(213, 'Hardcoded string found')
(214, 'Hardcoded string found')
(215, 'Hardcoded string found')
(217, 'Hardcoded string found')
(220, 'Line exceeds 80 characters')
(220, 'Hardcoded string found')
(221, 'Line exceeds 80 characters')
(221, 'Hardcoded string found')
(222, 'Line exceeds 80 characters')
(222, 'Hardcoded string found')
(223, 'Line exceeds 80 characters')
(223, 'Hardcoded string found')
(226, 'Hardcoded string found')
(227, 'Line exceeds 80 characters')
(227, 'Hardcoded string found')
(228, 'Hardcoded string found')
(229, 'Hardcoded string found')
(230, 'Hardcoded string found')
(231, 'Hardcoded string found')
(232, 'Hardcoded string found')
(233, 'Hardcoded string found')
(234, 'Hardcoded string found')
(235, 'Hardcoded string found')
(236, 'Hardcoded string found')
(237, 'Hardcoded string found')
(238, 'Hardcoded string found')
(239, 'Hardcoded string found')
(240, 'Hardcoded string found')
(241, 'Hardcoded string found')
(243, 'Hardcoded string found')
(246, 'Line exceeds 80 characters')
(246, 'Hardcoded string found')
(247, 'Line exceeds 80 characters')
(247, 'Hardcoded string found')
(248, 'Line exceeds 80 characters')
(248, 'Hardcoded string found')
(249, 'Line exceeds 80 characters')
(249, 'Hardcoded string found')
(252, 'Hardcoded string found')
(253, 'Line exceeds 80 characters')
(253, 'Hardcoded string found')
(254, 'Hardcoded string found')
(255, 'Hardcoded string found')
(256, 'Hardcoded string found')
(257, 'Hardcoded string found')
(258, 'Hardcoded string found')
(259, 'Hardcoded string found')
(260, 'Hardcoded string found')
(261, 'Hardcoded string found')
(262, 'Hardcoded string found')
(263, 'Hardcoded string found')
(264, 'Hardcoded string found')
(265, 'Hardcoded string found')
(266, 'Hardcoded string found')
(267, 'Hardcoded string found')
(269, 'Hardcoded string found')
(272, 'Line exceeds 80 characters')
(272, 'Hardcoded string found')
(273, 'Line exceeds 80 characters')
(273, 'Hardcoded string found')
(274, 'Line exceeds 80 characters')
(274, 'Hardcoded string found')
(275, 'Line exceeds 80 characters')
(275, 'Hardcoded string found')
(278, 'Hardcoded string found')
(279, 'Line exceeds 80 characters')
(279, 'Hardcoded string found')
(280, 'Hardcoded string found')
(281, 'Hardcoded string found')
(282, 'Hardcoded string found')
(283, 'Hardcoded string found')
(284, 'Hardcoded string found')
(285, 'Hardcoded string found')
(286, 'Hardcoded string found')
(287, 'Hardcoded string found')
(288, 'Hardcoded string found')
(289, 'Hardcoded string found')
(290, 'Hardcoded string found')
(291, 'Hardcoded string found')
(292, 'Hardcoded string found')
(293, 'Hardcoded string found')
(295, 'Hardcoded string found')
(298, 'Line exceeds 80 characters')
(298, 'Hardcoded string found')
(299, 'Line exceeds 80 characters')
(299, 'Hardcoded string found')
(300, 'Line exceeds 80 characters')
(300, 'Hardcoded string found')
(301, 'Line exceeds 80 characters')
(301, 'Hardcoded string found')
(304, 'Hardcoded string found')
(305, 'Line exceeds 80 characters')
(305, 'Hardcoded string found')
(306, 'Hardcoded string found')
(307, 'Hardcoded string found')
(308, 'Hardcoded string found')
(309, 'Hardcoded string found')
(310, 'Hardcoded string found')
(311, 'Hardcoded string found')
(312, 'Hardcoded string found')
(313, 'Hardcoded string found')
(314, 'Hardcoded string found')
(315, 'Hardcoded string found')
(316, 'Hardcoded string found')
(317, 'Hardcoded string found')
(318, 'Hardcoded string found')
(319, 'Hardcoded string found')
(321, 'Hardcoded string found')
(324, 'Line exceeds 80 characters')
(324, 'Hardcoded string found')
(325, 'Line exceeds 80 characters')
(325, 'Hardcoded string found')
(326, 'Line exceeds 80 characters')
(326, 'Hardcoded string found')
(327, 'Line exceeds 80 characters')
(327, 'Hardcoded string found')
(330, 'Hardcoded string found')
(331, 'Line exceeds 80 characters')
(331, 'Hardcoded string found')
(332, 'Hardcoded string found')
(333, 'Hardcoded string found')
(334, 'Hardcoded string found')
(335, 'Hardcoded string found')
(336, 'Hardcoded string found')
(337, 'Hardcoded string found')
(338, 'Hardcoded string found')
(339, 'Hardcoded string found')
(340, 'Hardcoded string found')
(341, 'Hardcoded string found')
(342, 'Hardcoded string found')
(343, 'Hardcoded string found')
(344, 'Hardcoded string found')
(345, 'Hardcoded string found')
(346, 'Hardcoded string found')
(348, 'Hardcoded string found')
(351, 'Hardcoded string found')
(354, 'Hardcoded string found')
(355, 'Line exceeds 80 characters')
(355, 'Hardcoded string found')
(356, 'Hardcoded string found')
(357, 'Hardcoded string found')
(358, 'Hardcoded string found')
(359, 'Hardcoded string found')
(360, 'Hardcoded string found')
(361, 'Hardcoded string found')
(362, 'Hardcoded string found')
(363, 'Hardcoded string found')
(364, 'Hardcoded string found')
(365, 'Hardcoded string found')
(366, 'Hardcoded string found')
(367, 'Hardcoded string found')
(368, 'Hardcoded string found')
(369, 'Hardcoded string found')
(370, 'Hardcoded string found')
(372, 'Hardcoded string found')
(375, 'Hardcoded string found')
(378, 'Hardcoded string found')
(379, 'Line exceeds 80 characters')
(379, 'Hardcoded string found')
(380, 'Hardcoded string found')
(381, 'Hardcoded string found')
(382, 'Hardcoded string found')
(383, 'Hardcoded string found')
(384, 'Hardcoded string found')
(385, 'Hardcoded string found')
(386, 'Hardcoded string found')
(387, 'Hardcoded string found')
(388, 'Hardcoded string found')
(389, 'Hardcoded string found')
(390, 'Hardcoded string found')
(391, 'Hardcoded string found')
(392, 'Hardcoded string found')
(393, 'Hardcoded string found')
(395, 'Hardcoded string found')
(398, 'Hardcoded string found')
(401, 'Hardcoded string found')
(402, 'Line exceeds 80 characters')
(402, 'Hardcoded string found')
(403, 'Hardcoded string found')
(404, 'Hardcoded string found')
(405, 'Hardcoded string found')
(406, 'Hardcoded string found')
(407, 'Hardcoded string found')
(408, 'Hardcoded string found')
(409, 'Hardcoded string found')
(410, 'Hardcoded string found')
(411, 'Hardcoded string found')
(412, 'Hardcoded string found')
(413, 'Hardcoded string found')
(414, 'Hardcoded string found')
(415, 'Hardcoded string found')
(416, 'Hardcoded string found')
(418, 'Hardcoded string found')
(421, 'Hardcoded string found')
(424, 'Hardcoded string found')
(425, 'Line exceeds 80 characters')
(425, 'Hardcoded string found')
(426, 'Hardcoded string found')
(427, 'Hardcoded string found')
(428, 'Hardcoded string found')
(429, 'Hardcoded string found')
(430, 'Hardcoded string found')
(431, 'Hardcoded string found')
(432, 'Hardcoded string found')
(433, 'Hardcoded string found')
(434, 'Hardcoded string found')
(435, 'Hardcoded string found')
(436, 'Hardcoded string found')
(437, 'Hardcoded string found')
(438, 'Hardcoded string found')
(439, 'Hardcoded string found')
(441, 'Hardcoded string found')
(444, 'Hardcoded string found')
(447, 'Hardcoded string found')
(448, 'Line exceeds 80 characters')
(448, 'Hardcoded string found')
(449, 'Hardcoded string found')
(450, 'Hardcoded string found')
(451, 'Hardcoded string found')
(452, 'Hardcoded string found')
(453, 'Hardcoded string found')
(454, 'Hardcoded string found')
(455, 'Hardcoded string found')
(456, 'Hardcoded string found')
(457, 'Hardcoded string found')
(458, 'Hardcoded string found')
(459, 'Hardcoded string found')
(460, 'Hardcoded string found')
(461, 'Hardcoded string found')
(462, 'Hardcoded string found')
(464, 'Hardcoded string found')
(467, 'Hardcoded string found')
(470, 'Hardcoded string found')
(471, 'Line exceeds 80 characters')
(471, 'Hardcoded string found')
(472, 'Hardcoded string found')
(473, 'Hardcoded string found')
(474, 'Hardcoded string found')
(475, 'Hardcoded string found')
(476, 'Hardcoded string found')
(477, 'Hardcoded string found')
(478, 'Hardcoded string found')
(479, 'Hardcoded string found')
(480, 'Hardcoded string found')
(481, 'Hardcoded string found')
(482, 'Hardcoded string found')
(483, 'Hardcoded string found')
(484, 'Hardcoded string found')
(485, 'Hardcoded string found')
(487, 'Hardcoded string found')
(490, 'Hardcoded string found')
(493, 'Hardcoded string found')
(494, 'Line exceeds 80 characters')
(494, 'Hardcoded string found')
(495, 'Hardcoded string found')
(496, 'Hardcoded string found')
(497, 'Hardcoded string found')
(498, 'Hardcoded string found')
(499, 'Hardcoded string found')
(500, 'Hardcoded string found')
(501, 'Hardcoded string found')
(502, 'Hardcoded string found')
(503, 'Hardcoded string found')
(504, 'Hardcoded string found')
(505, 'Hardcoded string found')
(506, 'Hardcoded string found')
(507, 'Hardcoded string found')
(508, 'Hardcoded string found')
(510, 'Hardcoded string found')
(513, 'Hardcoded string found')
(516, 'Hardcoded string found')
(517, 'Line exceeds 80 characters')
(517, 'Hardcoded string found')
(518, 'Hardcoded string found')
(519, 'Hardcoded string found')
(520, 'Hardcoded string found')
(521, 'Hardcoded string found')
(522, 'Hardcoded string found')
(523, 'Hardcoded string found')
(524, 'Hardcoded string found')
(525, 'Hardcoded string found')
(526, 'Hardcoded string found')
(527, 'Hardcoded string found')
(528, 'Hardcoded string found')
(529, 'Hardcoded string found')
(530, 'Hardcoded string found')
(531, 'Hardcoded string found')
(533, 'Hardcoded string found')
(536, 'Hardcoded string found')
(539, 'Hardcoded string found')
(540, 'Line exceeds 80 characters')
(540, 'Hardcoded string found')
(541, 'Hardcoded string found')
(542, 'Hardcoded string found')
(543, 'Hardcoded string found')
(544, 'Hardcoded string found')
(545, 'Hardcoded string found')
(546, 'Hardcoded string found')
(547, 'Hardcoded string found')
(548, 'Hardcoded string found')
(549, 'Hardcoded string found')
(550, 'Hardcoded string found')
(551, 'Hardcoded string found')
(552, 'Hardcoded string found')
(553, 'Hardcoded string found')
(554, 'Hardcoded string found')
(556, 'Hardcoded string found')
(559, 'Hardcoded string found')
(562, 'Hardcoded string found')
(563, 'Line exceeds 80 characters')
(563, 'Hardcoded string found')
(564, 'Hardcoded string found')
(565, 'Hardcoded string found')
(566, 'Hardcoded string found')
(567, 'Hardcoded string found')
(568, 'Hardcoded string found')
(569, 'Hardcoded string found')
(570, 'Hardcoded string found')
(571, 'Hardcoded string found')
(572, 'Hardcoded string found')
(573, 'Hardcoded string found')
(574, 'Hardcoded string found')
(575, 'Hardcoded string found')
(576, 'Hardcoded string found')
(577, 'Hardcoded string found')
(579, 'Hardcoded string found')
(582, 'Hardcoded string found')
(585, 'Hardcoded string found')
(586, 'Line exceeds 80 characters')
(586, 'Hardcoded string found')
(587, 'Hardcoded string found')
(588, 'Hardcoded string found')
(589, 'Hardcoded string found')
(590, 'Hardcoded string found')
(591, 'Hardcoded string found')
(592, 'Hardcoded string found')
(593, 'Hardcoded string found')
(594, 'Hardcoded string found')
(595, 'Hardcoded string found')
(596, 'Hardcoded string found')
(597, 'Hardcoded string found')
(598, 'Hardcoded string found')
(599, 'Hardcoded string found')
(600, 'Hardcoded string found')
(602, 'Hardcoded string found')
(604, 'Hardcoded string found')
(606, 'Hardcoded string found')
(607, 'Hardcoded string found')
(608, 'Line exceeds 80 characters')
(609, 'Line exceeds 80 characters')
(614, 'Line exceeds 80 characters')
(614, 'Hardcoded string found')
(615, 'Line exceeds 80 characters')
(615, 'Hardcoded string found')
(616, 'Line exceeds 80 characters')
(616, 'Hardcoded string found')
(617, 'Line exceeds 80 characters')
(617, 'Hardcoded string found')

I got it.


Save browser cached projects when migrating to a new server.

Hello, I'm in the middle of migrating the makecode IDE off 1 server and onto another. I would like to (if possible) save the projects our users have stored in their  browsers cache.
Does anyone know of a method to do this?

Today you need to export each project to a local hex file and re-import in the new box.


Fix #624 - Add analytics to the service alerts button

Following analytics report was added when a service alerts button is clicked:

Event Category
Event Action
Event Label

ui_action
service_alerts
Clicked Service Alerts from: PSTA

Screenshot from GA console:

cc'd @barbeau

Thanks @cagryInside!
@aaronbrethorst Would you be able to get this out in the next release?

I don't think you need to specify the region as I believe you can determine that by cross referencing the data.

I don't think you need to specify the region as I believe you can determine that by cross referencing the data.

@bbodenmiller To clarify, it is not region name, it is agency_id. Since, a region can contain multiple agencies, this helps us to differentiate service alerts from different agencies in the same region.

please make the changes described above and squash the resulting commits, and then i'll be happy to merge. thank you!

please make the changes described above and squash the resulting commits, and then i'll be happy to merge. thank you!

@aaronbrethorst thanks for your comments. Latest commit fixes the in-line comments.

looks good!


Fix common voice dataset

CommonVoice Dataset was not downloading the dataset nether extracting to the correct folder according to other datasets structures
Update dataset version to last one
Add newly available languages

@vincentqb If you could take a look.
When I was doing the inline typing for dataset I tried to use this dataset but it wasn't downloading anything. I maintain the same structure as other datasets

Added BC-breaking label since this changes how the data is being stored.


Implement signal.into_inner()

This implements into_inner the way it is implemented for Arcs. This fixes #3068 .
However, with the non-arc signals, the behaviour can be rather unintuitive. For example, the following does not succeed.
Why?
Because there's still the original RwSignal that was created inside the signal function. (RwSignal::new(value).split() creates 3 signals)
#[test]
fn into_inner_non_arc_signal() {
    let owner = Owner::new();
    owner.set();

    let (a, b) = signal(2);
    assert_eq!(a.get(), 2);
    b.dispose(); // strong count is now 2
    assert_eq!(a.into_inner(), Some(2)); // fails
}

I'm happy to document this, or to attempt a fix, or to remove the trait for normal signals.

I think my changes here to the implementation of signal() fix this, and cause the signal() test to work. It initially failed because signal() was implemented as RwSignal::new(value).split(), which means there's another reference to the inner ArcRwSignal (because it created an RwSignal and stored it in the owner). This version should be strictly better, in that it means only allocating 2 slots in the arena per signal() instead of 3, which is better for memory anyway. Thanks for surfacing that with the test, and for implementing this useful trait!

Sweet, thank you for bringing this over the finish line.


Improved vars takeover when using multi-level includes

Problem
Inability to successfully take over vars when included at multiple levels

a.yml

vars:
   foo: 123
steps:
  -
   include: b.yml
   vars:
     foo: '{{ vars.foo }}'

.. snip ..

b.yml

vars:
   foo: 123
steps:
  -
   include: c.yml
   vars:
     foo: '{{ vars.foo }}'

.. snip ..

c.yml

vars:
   foo: 123
steps:
  -
    test: vars.foo == 123

Error when executing a.yml
The value of foo is the string '123'.
Question
If I want to specify overwriting the vars in c.yml from a.yml in the above example, is the above description the only way?
Is there any problem to make the specification that vars defined in the parent yaml are inherited?
When specifying vars at include time, I feel that numerical values are inevitably evaluated as strings.

If I want to specify overwriting the vars in c.yml from a.yml in the above example, is the above description the only way?

Yes.

When specifying vars at include time, I feel that numerical values are inevitably evaluated as strings.

You are exactly right.
Currently only bool values are converted to heuristic, which is a known issue with Include Runner.

Thanks.

Currently only bool values are converted to heuristic, which is a known issue with Include Runner.

I wish I had a better approach to a solution to this problem, but I will read the source and think about it.
I would like to know if there are any best practices for writing scenarios with a large number of steps efficiently, do you know of any good ones?
If each scenario itself is an executable and reusable description, it tends to include many steps.
Would it be preferable to create an include-only scenario file with limited nesting?
In such cases, however, it is necessary to move the include-only scenario file to a different directory or otherwise remove it from the execution target.

Is there any problem to make the specification that vars defined in the parent yaml are inherited?

The image is that vars are cascaded and taken over as vars at include time.
vars:
   foo: 123
steps:
  -
   include: b.yml
   vars:
# Make vars inherit without having to redefine them.
# Include with the value of the original int
#     foo: '{{ vars.foo }}'

.. snip ..

I figured this way the expression would not be internally re-evaluated and the original type would be maintained.

In such cases, however, it is necessary to move the include-only scenario file to a different directory or otherwise remove it from the execution target.

There are two ways to handle this case.
1. Use if: included
if: included # Run steps only if included

2. Use SkipIncluded
	opts := []runn.Option{
		runn.T(t),
		runn.SkipIncluded(true),
	}
	o, err := runn.Load("testdata/books/**/*.yml", opts...)
	o, err := runn.New(opts...)

I would like to know if there are any best practices for writing scenarios with a large number of steps efficiently, do you know of any good ones?

I am still looking for that too, but I believe it is similar in some ways to product code test cases.

Better to be easy to understand what is being operated on.

Not too DRY

Better to be easy to maintain.

Is there any problem to make the specification that vars defined in the parent yaml are inherited?

I think we can already get this in parent.vars 👍

I think we can already get this in parent.vars 👍

I wanted to reference vars when parent.vars does not exist.
Maybe the theory would be to use if and only execute if included.
I think you are trying to make it too DRY.

I wanted to reference vars when parent.vars does not exist.

👍
I think we'd better solve the original issue raised in this issue.
I believe that unless there is an explicit override, the vars of the child runbook should take precedence over the vars of the parent runbook.

I think you are trying to make it too DRY.

( I'm not sure if this is an answer. )
As for the features that runn provides, I believe that it is acceptable to provide useful features.
It is up to the user to decide whether or not to DRY.
However, I do not want to complicate this for simple use. Features for advanced use should be hidden.


Add support for number of slider item per slide.

Reference : https://codepen.io/omowunmiekun/pen/GRKPbxW

This is a duplicate of #1. Let's track it through that issue.


TypeError: a.compareDocumentPosition is not a function

Hi.
I have this selector: document.querySelectorAll("a,link") and it returns the following error:
TypeError: a.compareDocumentPosition is not a function
    at documentOrder (https://deno.land/x/deno_dom@v0.1.8-alpha/src/dom/nwsapi.js:203:16)
    at Array.sort (<anonymous>)
    at collect (https://deno.land/x/deno_dom@v0.1.8-alpha/src/dom/nwsapi.js:1564:17)
    at Object._querySelectorAll [as select] (https://deno.land/x/deno_dom@v0.1.8-alpha/src/dom/nwsapi.js:1516:36)
    at HTMLDocument.querySelectorAll (https://deno.land/x/deno_dom@v0.1.8-alpha/src/dom/document.ts:205:33)
    at processor (file:///Users/oscarotero/www/lumeland/test/lume/plugins/relative_urls.js:29:10)

Doing two independent selections works fine document.querySelectorAll("a") and document.querySelectorAll("link"), but one query including both selectors fails.

Thanks


In the profile page, clicking the buttons doesn't do anything unless you click the text

The buttons should work even if you click the edges of them
Also applies to the "Create Personalized Recipe" button in recipe search

Fixed


Our merchant found a potential topic with SE Card payments

Describe the bug

The comment in " PaymentMethod.php " [AdyenPayment/Models/Payment/PaymentMethod.php]  file explains that " Standardize credit card code for Sweden,  Adyen returns value as scheme_card instead of scheme_credit_card for SW ".

But actually the parameter returned is " scheme_cards " and not " scheme_card "

When Adyen value is scheme_card, in response we didn't get the value as  scheme_credit_card

To Reproduce
Steps to reproduce the behavior:

Create a merchant who uses adyen card component via shopware plug in for country = SE
Set the payment method up in adyen as normal and ensure correct configs for the payment method etc
Attempt to render the component....you will see that it will not.
See error

Expected behavior
Card component renders even if shopper country is SE
Desktop (please complete the following information):
Any
Smartphone (please complete the following information):
Any
Additional context

The merchant made a small change to fix the issue:

"We changed the Adyen returns value as scheme_cards instead of scheme_card in your partner code and we were able to get the value correctly in our response.
After we made the change as per point number 3 the Credit Card is displaying for Sweden Country"

Hi,
It was Shopware version 5.6.6 and plugin 3.9.9.
Best wishes,
Marc

Marc Davies
Implementation Consultant
contact: adyen.com/contact https://www.adyen.com/contact
Adyen Berlin
Jägerstrasse 27
10117 Berlin, Germany
https://www.adyen.com/

On 5. Dec 2023, at 12:25, Logeecom Belgrade @.***> wrote:
Hello @marcDavies56211 https://github.com/marcDavies56211,
Judging by the description, we can see that you are using a plugin version older than v4.0.0.
Could you please inform us which plugin and Shopware versions were used at the time of the occurrence of the issue?
Thank you,
Kind regards.
—
Reply to this email directly, view it on GitHub https://github.com/Adyen/adyen-shopware5/issues/228#issuecomment-1840557778, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6KUS6EV4FFLM2U4Y7WJWALYH4ABBAVCNFSM6AAAAAA77HDUVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBQGU2TONZXHA.
You are receiving this because you were mentioned.

Hello @marcDavies56211,
Please note that the reported issue has been addressed and fixed in the new version of the module (v4.x).
We would suggest updating the module in your shop to the latest version
The version 4.X is an enhanced and updated iteration of the module you're presently using. We recommend reviewing the new features and improvements.
If you choose to upgrade to the latest version, we would strongly recommend going over the Migration notes for you to migrate to the new version as smoothly as possible.
Plugin link: https://github.com/Adyen/adyen-shopware5/releases
Migration notes: https://github.com/Adyen/adyen-shopware5/wiki#migrating-from-the-older-version
If you have any further questions, please do not hesitate to let us know.
Kind regards.


license

Greetings! Thanks for posting this. Can you add a license to the repo so users can comply with how you want it used? Thanks!

Hello, I have updated the license to MIT license.


HasContext interface ?

Consider adding a HasContext interface in Aeron to capture commonality among classes that have context:
@FunctionalInterface
public interface HasContext<C>{
 C context();
}

I can easily see: Aeron, MediaDriver, Archive, ClusteredServiceContainer and many others implementing this interface, similar to how they implement java.lang. AutoCloseable, for example:
public class Aeron implements AutoCloseable, HasContext<Context>{
  Context context(){ return ctx;}
}

If you want to add javadocs to HasContext:

https://accu.org/index.php/journals/246
https://www.dre.vanderbilt.edu/~schmidt/PDF/Context-Object-Pattern.pdf

What is the value to doing this? The contexts are not polymorphic and thus do not benefit from a common interface, the concrete type is required to use it. Extra semantic burden has a cost. What is the payback?


fast filling with ndimage [WIP]

Forget the "great" idea I had @perrygeo , found a fast method w/ scipy.ndimage
nodata@master
nodata blob tests/fixtures/blob/seams_4band.tif /tmp/weird.tif -m 15 -d 0
0.92s user 0.18s system 167% cpu 0.654 total

nodata@scipy0filler
nodata blob tests/fixtures/blob/seams_4band.tif /tmp/weird.tif -m 15 -d 0
0.45s user 0.18s system 135% cpu 0.461 total

This is not yet ready, still some funkiness, but the results are promising enough / speed increase is fast enough that I think it is worth pushing on

Gonna leave this rabbit hole unexplored 🐰


Non-HTTP traffic support

It'd be nice to be able to build non-http applications with Epinio as well. This could be done by allowing LoadBalancer or NodePort service types.
Similarly, some apps might want multiple ports to be available.

This will be done via templatizing


[Fix #3469] add Proxy check case.

增加在@Configuration的Full模式下会产生CGLIB代理的校验。

Codecov Report

Merging #3484 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #3484   +/-   ##
=========================================
  Coverage     80.40%   80.40%
  Complexity     7474     7474
=========================================
  Files           157      157
  Lines         27901    27903    +2
  Branches       6725     6726    +1
=========================================
+ Hits          22434    22436    +2
- Misses         3452     3454    +2
+ Partials       2015     2013    -2

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/alibaba/fastjson/util/TypeUtils.java
78.91% <0.00%> (-0.09%)
650.00 <0.00> (ø)

...ava/com/alibaba/fastjson/parser/JSONLexerBase.java
69.94% <0.00%> (-0.07%)
811.00% <0.00%> (-2.00%)

...com/alibaba/fastjson/parser/JSONReaderScanner.java
74.84% <0.00%> (+1.25%)
46.00% <0.00%> (+1.00%)

...com/alibaba/fastjson/serializer/SerialContext.java
86.53% <0.00%> (+3.84%)
22.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250f632...789f983. Read the comment docs.


fix(Header): properly wrap contents in HeaderContent

Fixes #511.
This PR wraps subheader shorthand in HeaderContent when there is an icon present.  It also wraps content in HeaderContent when there is an image provided.

Current coverage is 98.73% (diff: 100%)

Merging #512 into master will decrease coverage by <.01%

@@             master       #512   diff @@
==========================================
  Files           106        106
  Lines          1744       1743     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1722       1721     -1
  Misses           22         22
  Partials          0          0

Powered by Codecov. Last update 80d40d9...ed3e823

Released in<EMAIL_ADDRESS>


support comments

add comments to the language

Both Scratch-LN comments (no impact on Scratch blocks, but instrumental for Scratch-LN developers) and Scratch comments should be supported:

Scratch-LN comments

line comments: // ...
block comments: /* ... */

Scratch comments

block comments: | ... |

done, see the example button in the live preview for an example. Although, comments look weird in the read-only version see test


Unable to clone mx-flexray-utils

The repository here seems to be missing.

Hello James,
This is a private repository for our customers who is using our MX-4 hardware. The functionality is optional.  Are you a customer who are using our platforms? You can email<EMAIL_ADDRESS>Best regards,
Mattias

Are you a customer who are using our platforms?

Not yet, I'm looking to see if the MX-4 board's software stack is suitable for a project of mine before purchasing one.


Add missing ERC-20 tokens

This library is fantastic. We would like to pay a designer to add some of the missing icons to the library.
The top tokens can be found at: https://coinmarketcap.com/tokens
You can find all of the ERC-20 tokens by checking whether the platform is Ethereum. When you go above 250 the market cap of the tokens is pretty small so we just want to add ones that are in the top 300. You should check to see if the icons are already present in the library.

The ideal results would match @cjdowner’s fantastic work. We will be making a pull request back to his repo and he is keen to look at what people come up with.

Transaction: 0x75bb10bed80be8baafe6cec513355be61e5fc7373cbf01b9bad76b6a1b632e43

hi me product designer http://dribbble.com/egorfedorov )
contact me @egorfedorov

Senior graphic designer, specialising in logo & brand design with minimalistic/flat design style. www.vmanov.com

Hi @egorfedorov & @Anarchel. We would love to have you contribute to the project. Please email me on<EMAIL_ADDRESS>if you have any questions.

Apologies everyone we just discovered this library:
https://github.com/TrustWallet/tokens
It has nearly all the tokens we need and the contracts. We would like to move the bounty there.
@andytudhope is that possible?

Not really @ricburton - but I can help you to close this bounty and reclaim it without too many problems...

That would be great. I don’t believe any work has been done yet.
Richard
Sent via Superhuman<EMAIL_ADDRESS>)
On Wed, Mar 28, 2018 at 03:58:46, Andy Tudhope <<EMAIL_ADDRESS>> wrote:

Not really @ ricburton ( https://github.com/ricburton ) - but I can help
you to close this bounty and reclaim it without too many problems...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/balance-io/cryptocurrency-icons/issues/1#issuecomment-376813265
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAavkEOau_ZAvZt3H7YlCy2lM2wm48L4ks5ti1DGgaJpZM4SlqhP
).


Can you merge this in to the official repo?

Would be lovely, i have no idea how to do that to be honest.

works great but missing a few options here:
some entitys become unavaiable, maybe i just need to let it rest a day or 2

ah the entities werent enabled, mybad

ill rebookmarked this page because i feel the need and to focus more this week on this bookmark about posting it more forwarded to the devs or community or even the cretor of the offical synology dsm intergration because they can do so much better!


Implement inter-proxy measurements

Inter-proxy measurements are a pre-requisite for trilateration.
There are two methods we will use to make these measurements:
Triangle Inequality

Esphome (until (checks watch) NOW) can't be a beacon and a proxy at the same time. This is now fixed, but I still want to support the case.
If you have two sides of a triangle, you can know that the third side is no  more than the sum of the two known sides.
This means we can trawl through each pair of proxies, and successively approximate their distance apart by taking the sums of their measurement to each known device. This should be fairly quick to do, basically:

foreach proxy1 in proxies:
  foreach proxy2 in proxies:
    foreach device in devices:
       estimate = proxy1_to_device + proxy2_to_device
       if estimate < proxy1.estimate_to_proxy2:
         proxy1.estimate_to_proxy2 = estimate

(obviously this is not real code and lacks serious optimisation)
Direct rssi measurement

esphome as of the last few days (as at July 24) can now act as a beacon at the same time as being a proxy. This is something that the Shelly devices have always done, it seems.
This simplifies the inter-proxy measurement, as we can apply it directly.
I think we still need to track it as... let's call it an "ephemeral minima".
Still undecided if a triangle inequality measurement should be able to trump a direct, so we should collect each estimate in its own field (so we have diagnostic visibility) and apply one as the current "blessed" value.

What do we need to upgrade - the ESPHome integration, ESPHome firmware (do we need to activate something?) or ESPHome server? How can I check if this is available - my ESPHome proxies don't have any entities, so is it "under the hood"?
BTW: Some devices seem to transmit their own signal strength as well – this could potentially be useful for calculations as well.

What do we need to upgrade - the ESPHome integration, ESPHome firmware (do we need to activate something?) or ESPHome server? How can I check if this is available - my ESPHome proxies don't have any entities, so is it "under the hood"?
After some research: You'll add this option to your ESPHome device as described here: https://esphome.io/components/esp32_ble_beacon.html And don't forget to use a different uuid for each device, you'll find a generator there, just reload the page.
Then verify your settings. You have the old version if you get this message: "Component esp32_ble_beacon cannot be used together with component esp32_ble_tracker."
BTW: Some devices transmit their own signal RSSI value at 1m for iOS – this may be potentially useful for calculations as well (if true).

The necessary pull request for esp32_ble_beacon and esp_32_tracker has been merged into the ESPHome dev branch but has not yet made its way into the official version. I am guessing it will be included in the 2024.8.0 release, but it could be sooner.
You could use the Docker image that follows the dev branch of ESPHome if you want, but I would recommend caution as it changes frequently.

It worked for me, but although I useded ESPHome 2024.8.0-dev, I had to use an old "recommended" version of the framework. "latest" or "dev" didn't compile:
framework:
type: esp-idf
version: recommended

max_interval (Optional, [Time](https://esphome.io/guides/configuration-types#config-time)): The iBeacon maximum transmit interval in milliseconds from 20 to 10240. Setting this greater than min_interval gives the BLE hardware a better chance to avoid collisions with other BLE transmissions. Defaults to the iBeacon specification’s defined interval: 100ms.
I guess we shouldn't touch these values.

Proximity beacons must broadcast the entire 30 byte advertising packet in all Advertising frequencies using a fixed 100 ms advertising interval.
https://developer.apple.com/ibeacon/

You could use the Docker image that follows the dev branch of ESPHome if you want, but I would recommend caution as it changes frequently.

Alternatively, you can use an external_component.
Assuming this is the PR, I believe you can just add this to your code:
external_components:
  - source: github://pr#6908
    components:
      - esp32_ble
      - esp32_ble_beacon
      - esp32_ble_server
      - esp32_improv
    refresh: 1d

The exact components might need to be changed - I just based it off of what's in the PR. However, I don't think there's any value for us since Bermuda doesn't support it yet.

since Bermuda doesn't support it yet.

Well... it probably does :-) If you deploy a proxy with the beacon enabled it should show up with distance sensors to the various other proxies.
I haven't tested it myself yet, but I haven't had reports of weird stuff hapenning with Shellys, and they've operated like that from the beginning, it seems.
Any reports of weird are welcome, and I plan to test using both the dev version and the custom-component methods once I'm back home later this week.

BTW: Some devices transmit their own signal RSSI value at 1m for iOS – this may be potentially useful for calculations as well (if true).

Yes, I can't remember if I already included that or not - Bermuda does track the value, but I think I didn't bother using it because most devices seem to include a not-very-useful default. I'll revisit that when we do per-device settings, as we might then want to use the advertised tx_power in the absense of a configured value (but we'd always allow overriding it in Bermuda, as some devices are not configurable, plus it's easier to do in Bermuda than on each device).

guess we shouldn't touch these values.

Proximity beacons must broadcast the entire 30 byte advertising packet in all Advertising frequencies using a fixed 100 ms advertising interval.
https://developer.apple.com/ibeacon/

Luckily we don't need to follow Apple's spec for Bermuda's purposes. In fact we don't even need it to be an iBeacon at all, any advert would work. Far better is to add a small random delay between advert cycles (which is what the bluetooth spec says to do) and the interval can be quite widely varied for most systems.
For Bermuda, it won't mind at all up to the timeout values, but I'd personally go with perhaps 1 to 2 seconds, or do some testing to see how it affects receipt of adverts, and maybe increase it to 10 or 30 seconds if it causes the proxy to miss too many adverts. Bermuda will probably change to treat static proxy adverts differently to consider them 'fresh' for a much longer time than device adverts, since we expect proxies (typically) to be stationary.

Well... it probably does :-) If you deploy a proxy with the beacon enabled it should show up with distance sensors to the various other proxies.
I haven't tested it myself yet, but I haven't had reports of weird stuff hapenning with Shellys, and they've operated like that from the beginning, it seems.

Works for me. ESP32-S3 and Shellys:

Heh, I'm guessing the 'Area' sensor is probably just confusing, because it says the proxy is at the same area as its nearest proxy, not the area it's actually in, yes?

"Windfang" is the area of the nearest proxy, yes. In the "Technikraum" is another proxy, directly one floor below. The signal passes through the wooden floor, the underfloor heating, and the reinforced concrete, yet remains surprisingly strong.

Proof of concept implemented in coordinator.py:
    def _calculate_inter_proxy_distance(self):
        for scanner_1_address in self.scanner_list:
            scanner_1_device = self.devices[scanner_1_address]
            for scanner_2_address in self.scanner_list:
                real_dist = None
                if scanner_2_address in scanner_1_device.scanners:
                    real_dist = scanner_1_device.scanners[
                        scanner_2_address
                    ].rssi_distance
                lowest_estimated_dist = 99999
                if scanner_1_address != scanner_2_address:
                    for device_address, device in self.devices.items():
                        if (
                            device_address not in {scanner_1_address, scanner_2_address}
                            and scanner_1_address in device.scanners
                            and scanner_2_address in device.scanners
                        ):
                            dist_1 = device.scanners[scanner_1_address].rssi_distance
                            dist_2 = device.scanners[scanner_2_address].rssi_distance
                            if dist_1 is not None and dist_2 is not None:
                                estimated_dist = dist_1 + dist_2
                                if estimated_dist < lowest_estimated_dist:
                                    lowest_estimated_dist = estimated_dist
                print(
                    f"Distance from {scanner_1_address} to {scanner_2_address}: Real: {real_dist}, estimated: {lowest_estimated_dist}"
                )


Fair Share Verification

Description: Check and validate the fair share representation per account/user.
Acceptance Criteria:
* Each account/user should have distinct line representations.
* Ensure the fair share metrics are accurate and reflect the true usage.

https://github.com/centerforaisafety/prometheus-slurm-exporter/tree/Fair-Share-Verification%23223
Once Im happy with the graphs will PR and merge,

Need to add a graph for raw and effective usage as well as documentation on how these are calculated.
@WilliamHodgkins


implement DagNodeStateStore

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.99%. Comparing base (b44a91e) to head (918ac34).
Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3999       +/-   ##
=============================================
+ Coverage     38.72%   49.99%   +11.26%
- Complexity     1596     5872     +4276
=============================================
  Files           388     1074      +686
  Lines         15957    41230    +25273
  Branches       1578     4625     +3047
=============================================
+ Hits           6180    20611    +14431
- Misses         9283    18831     +9548
- Partials        494     1788     +1294

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow nbf and nnc to be null

Summary
Problem
ts-ucan does not allow nbf and nnc to be null.
Impact
ts-ucan reports an invalid payload when either of these fields are null.
Solution
Allow the fields to be null when validating payloads.
The fields are checked here:
https://github.com/ucan-wg/ts-ucan/blob/978dfd28299d370daee3902ca874a582f48176ff/src/types.ts#L122-L123

On the rs-ucan side, it would be trivial for us to omit these fields when they are not used. It would probably be better to omit them as it improves payload size (however marginally).
Do you have an opinion about what to do with fct? The spec says this field is optional, but current we emit an empty array no matter what.

As an optimization/mitigation, I changed rs-ucan's serialization to omit these fields when unused: https://github.com/cdata/rs-ucan/commit/7203f324998791ea91d3aa8c5f5d0d05a6600d1c
Published as https://crates.io/crates/ucan/0.5.0-alpha.6
Tokens generated by rs-ucan are now accepted and interpreted correctly by the validator :+1:


Import "pyfbsdk" could not be resolved

Not that much skilled to understand why it does not works for me, so I was hoping to get maybe some help here ? :)
I got Python 3.11
Using Virtual Studio Code
When I try add anything from the MoBu utils such as from pyfbsdk import * yellow wavy underline show up and the Import "pyfbsdk" could not be resolved msg pop up when I hover over it with my cursor.
Also having bit an issue to understand how exactly I can run the debug server ? If I can ask for help here as well.
Thanks in advance :)

Ah just got older version ( 1.2.4 ) of the MoBu utils and it seems to work now. So probably some bug at latest version ?

Hi,
In version 1.3.0 the stub files/code-completion is no longer setup automatically, instead you need to run a command to do so.
To setup code-completion in 1.3.0+, open up VS Code's command palette: Ctrl + Shift + P
Then run the command MotionBuilder: Setup Code Completion
I'd recommend doing this with the latest version since it comes with improved code-completion.
From the command palette you can also run the command MotionBuilder: Attach to start the debug server & attach VS Code to MotionBuilder. If you find yourself doing this often you can always map the command to a keyboard shortcut.
Cheers,
Nils


Create intial page for CS8355

This pull request introduces initial page for CS8355 compilation error.

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/compiler-messages/cs8355.md
Compiler Error CS8355

docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md
Sorry, we don't have specifics on this C# error

Closing and reopening to re-trigger the build.


Different Output Between Terminal IPython and Spyder: ["CompileError: command 'gcc' failed with exit status 1\n"]

Description of your problem
Hi,
I am currently working with an API named cocoapi that used Cython to compile .c file on Ubuntu 16.04 LTS. I can use the API flawlessly with IPython on terminal, but when run the python file on Spyder I got this error:
ImportError: Building module pycocotools._mask failed: ["CompileError: command 'gcc' failed with exit status 1\n"]
I use Anaconda 2 with Spyder 3.2.4 that installed from conda-forge channel and use all the default setting for Spyder. I tried to reinstall the Spyder from various channel but the problem is still there. Other than this error, the Spyder works without any problem. I even tried to reinstall Anaconda with the newer version of installer (after removing the old one first), but nothing change.
I already make the Python API from cocoapi, update all the Anaconda module, and make sure that the sys.path in Terminal IPython is the same with the Spyder IPython.
There is no problem when running the code on IPhython on Terminal, so it should be no problem on Spyder's IPython right? Or is there any hidden setting that I need to change?
What steps will reproduce the problem?

Download cocoapi from https://github.com/cocodataset/cocoapi
Make the Python API
In IPython console import the api
from pycocotools.coco import COCO
Compare Terminal IPhython with Spyder IPython

What is the expected output? What do you see instead?
This is the output of importing the code on IPython on terminal. The import worked.
Python 2.7.13 |Anaconda custom (64-bit)| (default, Dec 20 2016, 23:09:15)
Type "copyright", "credits" or "license" for more information.

IPython 5.3.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]: from pycocotools.coco import COCO

In [2]:

And this is when I ran the sample code on Spyder (the first line of the sample code is the same import as the above code).
Python 2.7.13 |Anaconda custom (64-bit)| (default, Dec 20 2016, 23:09:15)
Type "copyright", "credits" or "license" for more information.

IPython 5.3.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

runfile('/home/hanifr/Desktop/coco-master-linux/PythonAPI/tes_coco.py', wdir='/home/hanifr/Desktop/coco-master-linux/PythonAPI')
Traceback (most recent call last):

  File "<ipython-input-1-c69dfad89653>", line 1, in <module>
    runfile('/home/hanifr/Desktop/coco-master-linux/PythonAPI/tes_coco.py', wdir='/home/hanifr/Desktop/coco-master-linux/PythonAPI')

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/spyder/utils/site/sitecustomize.py", line 710, in runfile
    execfile(filename, namespace)

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/spyder/utils/site/sitecustomize.py", line 93, in execfile
    builtins.execfile(filename, *where)

  File "/home/hanifr/Desktop/coco-master-linux/PythonAPI/tes_coco.py", line 1, in <module>
    from pycocotools.coco import COCO

  File "pycocotools/coco.py", line 55, in <module>
    from . import mask as maskUtils

  File "pycocotools/mask.py", line 3, in <module>
    import pycocotools._mask as _mask

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/pyximport/pyximport.py", line 458, in load_module
    language_level=self.language_level)

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/pyximport/pyximport.py", line 233, in load_module
    exec("raise exc, None, tb", {'exc': exc, 'tb': tb})

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/pyximport/pyximport.py", line 215, in load_module
    inplace=build_inplace, language_level=language_level)

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/pyximport/pyximport.py", line 191, in build_module
    reload_support=pyxargs.reload_support)

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/pyximport/pyxbuild.py", line 102, in pyx_to_dll
    dist.run_commands()

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/Cython/Distutils/old_build_ext.py", line 185, in run
    _build_ext.build_ext.run(self)

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/command/build_ext.py", line 340, in run
    self.build_extensions()

  File "/home/hanifr/anaconda2/lib/python2.7/site-packages/Cython/Distutils/old_build_ext.py", line 193, in build_extensions
    self.build_extension(ext)

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/command/build_ext.py", line 499, in build_extension
    depends=ext.depends)

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/ccompiler.py", line 574, in compile
    self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)

  File "/home/hanifr/anaconda2/lib/python2.7/distutils/unixccompiler.py", line 124, in _compile
    raise CompileError, msg

ImportError: Building module pycocotools._mask failed: ["CompileError: command 'gcc' failed with exit status 1\n"]

Please provide any additional information below
I once using the default Python with Spyder2 from apt-get. The code is actually worked in that setup, but I then decided to use Anaconda with in built Spyder because I need the other module. I make sure to remove and purge the previous Spyder installation before starting to install Anaconda's Spyder.
Versions and main components

Spyder Version: 3.2.4
Python Version: Python 2.7.13 |Anaconda custom (64-bit)
Qt Version: 5.6.2
PyQt Version: 5.6.0-py2
Operating system: Ubuntu 16.04 LTS

Dependencies
IPython >=4.0;<6.0:  5.4.1 (OK)
cython >=0.21     :  0.26.1 (OK)
jedi >=0.9.0      :  0.10.2 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
numpy >=1.7       :  1.13.3 (OK)
pandas >=0.13.1   :  0.20.3 (OK)
psutil >=0.3      :  5.4.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pyflakes >=0.5.0  :  1.6.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
pylint >=0.25     :  1.7.4 (OK)
qtconsole >=4.2.0 :  4.3.1 (OK)
rope >=0.9.4      :  0.10.5 (OK)
sphinx >=0.6.6    :  1.6.3 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
Thanks

Thanks for reporting. This is a duplicate of issue #5299, and there you'll find a temporary solution.
We'll fix this problem in 3.2.5.

totally same question for me with spyder in Python 3.6.4 |Anaconda,


Integrate with redux-actions

i was trying to figure out how integrate redux-promise-middleware with redux-actions,
is this posible or it is not necessary to use both components?

All you would need to do is to return a promise from the payload creator and make sure that you have redux-promise-middleware. It would integrate quite nicely now thinking about it!
// create a promise action
const saveThing = createAction('SAVE_THING', async (thing) => {
  const { data } = await saveThatThing(thing)
  return data
});

// use it
saveThing('123')
// should now dispatch SAVE_THING_PENDING and hopefully SAVE_THING_FULFILLED

Thanks @tomatau ,
I will try to implement this on my project. I will let you know how it is going.

@tomatau Would you mind adding a guide for this in the documentation? If you don't have time, I can at some point.

Actually, never mind, I added it just now, @tomatau. I'm going to close this issue, @lexfernandez, let us know if you need any further help.


Can I modify and redistribute this under GPL 3.0?

Please can I redistribute this as a modified theme under GPL 3.0?
I have added the repo for you to see but if you are not happy with it I will remove it.

Oops, forgot to add the link.
https://github.com/ItsTerm1n4l/spice.nvim

If the Apache 2 license allows for it, then sure


 Who put you there? Why are you here? You have the feeling that you need to escape...
How do you play your game?
Solve the puzzles in the different rooms and collect information. WASD is for movement, press K to interact with objects, and J to reset the level if you're stuck.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

The game is not over! I'll still add more stuff in the future :D

Great job with this game! I really loved the storytelling and puzzles that made this fun. Approved, and you'll see this in the gallery this week!
If you're a teenager, you can request a free Sprig console at this link and join our online Slack community to chat with other people making Sprig games.


enhanced the UI of the FAQ section

Fixes Issue
This PR fixes the following issues:
I have enhanced the UI of the FAQ section  and also changed the layout of the social media section  adding animation  to it was not a better option  as it could deteriorate the motive of adding those posts

Changes proposed
Here comes all the changes proposed through this PR
You will definitely love the change as I have followed the color scheme  of the whole website and kept it simple
Check List (Check all the boxes which are applicable)

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots and video
AFTER :

BEFORE :

@PranavBarthwal could you please review it

lgtm, @pradeeptosarkar & @SahilTyagii thoughts?

@PranavBarthwal in the meantime could you provide me with our thoughts in this .

gtg @PranavBarthwal


Simple validation for issue #38

I just added a dimensions check under DGEList counts/samples and added one associated test, which passed.
Let me know if this is the right idea, or if I'm missing something, and then I can go fix the genes/counts validation too!
Addresses part of #38

Alrighty I think I fixed 'er up. But I'll look over it again tomorrow.

When I mean the tests are brittle, it's a remark on no one's work but my own. I scratched them out just to get a skeleton of this class working and haven't had time to give it a diligent pass.

These do overlap.
Could you rebase onto js_DGE_checks, merge the conflicts, check the history carefully with git log, force push, and then we can just use this PR for your review which will have everyone's work?

This breaks the renaming.  I'll merge this into my branch, instead

I've merged this branch into mine - but a few things fail.
Notably, on my branch, I require that counts or filename is provided when creating a DGE object, so the creation of a data-less DGE object is failing.    Is there any circumstance when someone would want a data-less DGE object?

This branch can now be closed - it has been merged with the branch in PR #40


Treemap padding introduces bias, penalizing small nodes.

The treemap implementation subtracts a fixed amount of padding from the computed node sizes. This is simple to implement but disproportionately affects the size of small nodes, since the relative area of the subtracted padding is much higher with a small node than a big node.
In d3-shape’s pie generator, we go to some effort to ensure that the relative areas of padded arcs are preserved. We don’t do that with the treemap layout, in part because I presume it is more challenging to implement, but it would be lovely if we could. A two-pass approach might be an acceptable if imperfect solution: compute the layout without padding, compute the area lost to padding for each cell, add this to the value for the cell, and then recompute the layout.
Perhaps I should start by visualizing the distortion using the Flare hierarchy as an example dataset.
Related d3/d3-shape#41.

This is an interesting idea but I’m not going to pursue it immediately.


Interpreting top 2 lines of a m-ld.ndjson

The top two lines of the m-ld.ndjson file which I now obtained through https://github.com/federatedbookkeeping/timesheets/issues/47 read:
{"@id":"fedb/fedt","@type":"Project"}
{"@id":"angus/ts-agm-2022-08-08","project":{"@id":"fedb/fedt"},"@type":"Timesheet"}

Does this imply that all subsequent lines pertain to that project and that timesheet?

Sorry this issue should have gone to https://github.com/m-ld/timeld but I guess we can also answer it here as part of https://github.com/federatedbookkeeping/timesheets/wiki/Timesheet-Data-Formats

Does this imply that all subsequent lines pertain to that project and that timesheet?

Yes, see https://github.com/m-ld/timeld/blob/main/doc/api.md#report
Note also https://github.com/m-ld/timeld/issues/44: The session key in each Entry leaks an internal identifier instead of the timesheet reference.


Cluster: Moves ClientType, its constants and helper into own package

To avoid circular imports conflicts with storage package.
Related to https://github.com/lxc/lxd/pull/8205

Testsuite passed


Vulnerability Issue 5.6.3

When our application was tested with pen testing it was found that the plugin has vulnerability
Just wanted to clarify that when we share a remote image/file , it will store in our External storage as mentioned in plugin details . We want to know will the file/image will be flushed after sharing to someone .?
INFORMATION from Pen testing :-
Severity Issue CVSS CVE Files High
App can read/write to External Storage. Any App can read data written to External Storage
5.5
CWE-276
M2: Insecure Data Storage
nl/xservices/plugins/SocialSharing.java

Hi !
I am also being affected by this issue
Are you contemplating encrypting this data?


test client libraries in the main-cron test

https://www.notion.so/risingwave-labs/client-libraries-215dccb91503473787a4ddfe0aa2b422
Please write the tests and run them in the main-cron test so that we can verify them on a daily basis.
Feel free to assign the owner to each test. @sumittal
Please open a PR once the implementation of tests starts so that people can help.

[ ] Java PostgreSQL JDBC driver(https://jdbc.postgresql.org/)
[ ] node.js node-postgres(https://www.npmjs.com/package/pg)
[ ] python psycopg2 (https://pypi.org/project/psycopg2/)
[ ] go pgx(https://github.com/jackc/pgx)
[ ] PHP pdo-pgsql(https://www.php.net/manual/en/ref.pdo-pgsql.php)
[ ] Ruby ruby-pg(https://github.com/ged/ruby-pg)

BTW, here's a prior art: https://github.com/risingwavelabs/risingwave/pull/7113

Basically sqllogictest --engine=external can create a subprocess as the driver (with this protocol https://github.com/risinglightdb/sqllogictest-rs/blob/27eb9f50993e10b36c1f4f68ad3afe499adbbb49/sqllogictest-engines/src/external.rs#L16-L36), so we can test any client library with all our slt test suites in this way. Although I'm not sure whether we want to do so, or just some simple tests are enough.

cc: @abhyuday26