Fix gradle check fail due to artifact renaming with "-min"

Signed-off-by: Xue Zhou<EMAIL_ADDRESS>Description
Fix gradle check failing due to artifact renaming in #1094.
Issues Resolved
#1285
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

Can you open a backport PR to 1.x and we'll cherry-pick to 1.1 (no PR needed for 1.1)

Sorry I'm late to this, LGTM thanks for taking care of it @xuezhou25!


foolproof+futureproof cosmology instantiation

Currently, CCL cosmology objects can be instantiated without passing any keyword-arguments, like so:
ccl.Cosmology(0.25, 0.05, 0.65, 0.96, 0.81). If for some reason the ordering of arguments in CCL changes in the future, then codes built without explicitly declaring the parameters passed will silently fail, giving the wrong cosmology.
We can make all arguments passed in cosmology to be keyword-only. This way, the user must explicitly state which parameter is which, and this is also futureproof in case the ordering changes and/or more parameters are added.
This is easily done by adding the * operator after the self argument in every cosmological __init__ method.
Then, if the user tries to pass in just numbers without keywords, the code will exit with the following message:
TypeError: Cosmology() takes 1 positional argument but 6 were given

This thinking can be extended to any class method that takes in a number of parameters to update (for example halo profiles), but I think it's more important to do it in ccl.Cosmology_functions() first.

+1 on this.  This is a really nice feature they added in python 3.  I haven't used it much yet in my own code, since I've still been supporting 2.7, but that's done now.  So I'll be adding this to most of my functions pretty soon.
I think a rule of thumb that will usually work is if the first argument is strongly implied by the name of the function, then let that be keyword-less.  E.g. readFile(file_name).  But then anything after that should be keyword-only.  (Indicated by adding the * as Nick mentioned).  For functions that don't have an obvious-from-context first argument (like Cosmology) make everything keyword-only.
This makes for much more readable user code, so you're really helping your users out by adding this to help them make their own code better.  ccl.Cosmology(0.25, 0.05, 0.65, 0.96, 0.81) is pretty cryptic compared to ccl.Cosmology(Omega_c=0.25, Omega_b=0.05, h=0.65, ns=0.96, sigma_8=0.81).  You're doing your users a favor forcing them to use the latter.  :)

@rmjarvis would this count as a change to the API and thus trigger a new release?

It's arguable.  But personally I'd be happy to let it go as a minor release, not a major one.  It's definitely not a bugfix though.  :)

@rmjarvis I would personally be slightly more lenient than that rule of thumb you mentioned. CCL is made to integrate well with Python code, and in most cases, the variable names we give are very similar to the argument names of the CCL functions.
Ideally, users would have to explicitly state the used model's parameters in order to avoid mix-ups and write futureproof code (like I mentioned in my first post), but we'd like to avoid things like:
ccl.foo(cosmo, k=k, a=a, dndz=dndz, method='no_idea')

or even:
ccl.foo(cosmo, k=k_arr, a=a_arr, dndz=nz, method='no_idea')

So in the previous example, I'd probably put the star before the method argument.
Also, private functions don't necessarily need to include the the star (although practically in Python nothing is private).
PS: In newer Python versions, there's also the / operator which separates positional-only arguments from the rest. But this is redundant I think, there's no reason to prevent users from using ccl.foo(cosmo=my_cosmo ...).
If there's a consensus on this from the collaborators I could go through the entirety of the Python code and make the appropriate changes.

It's up to you of course.  I'll just remind you that code is read far more often than it is written.  So you should prioritize making things clear to readers over making it easy for writers.

I see. Taking into account the stuff with the API change that you discussed with David, I think only adding a star where most people would have declared the argument names would be fine for now.
Being stricter and, for example, changing
def omega_x(cosmo, a, species) to
def omega_x(cosmo, a, *, species)
would probably break many codes that use
omega_x(my_cosmo, 1., "matter")
and that would borderline count as too much change for a minor release.
So I'll do all the "necessary" changes and I'll leave the rest for the next major release. :)

FYI, I found a way to add the kw-only bit while maintaining backwards compatibility if you want to care about that.
https://github.com/flying-sheep/legacy-api-wrap
It's a decorator that lets you add the * to your signature, and then if the user treats any kwargs as positional, then they get a deprecation warning rather than a TypeError.

Thank you, Mike. This could be useful if we don't want to change the API, but:

it would trigger so many warnings that the output of the run would be a complete mess, so the users would be forced, in a way, to make the changes (like in the cases where an error is thrown), OR
the users would mute warnings, in which case we fall back to the first issue.

Together with @damonge I've collected my thoughts on this in a more clear manner. I'm closing this and I'm opening a new, more to-the-point issue.


make hidden attribute respected again

If an element gets a hidden attribute your current main reset is resetting it to its original display property. Can be fixed with a minor addition:
*:where(:not(iframe, canvas, img, svg, video, [hidden]):not(svg *, symbol *)) {

So the hidden attribute will force display: none like the browsers default behaviour.

This is a good idea and I'm in favor.

Add this feature in a different way - updated in the last version 1.4.3
/* fix the feature of attribute hidden
display:revert; revert to element instead of attribute */
:where([hidden]){
display:none;
}


What does the error message 'mpeinject: error receiving from UDP socket: Bad file descriptor' mean?

Hello, I'm trying an MPE exactly according to user manual 5.2.21. The transport stream comes from ffmpeg. The embedded data is delivered to a multicast address via netcat. In debug mode I see that tsp receives the UDP data packets. However, no data is embedded. Among other things, tsp displays the following error message: 'Error: mpeinject: error receiving from UDP socket: Bad file descriptor'
What does the error message mean? Unfortunately I couldn't find anything.

There are two things.
First, nothing is inserted in the stream. Do you have enough stuffing (free space) to insert your data? Do you have stuffing at all? A transport stream is like a file system. When it's full (no free space), you can't add anything. Be sure to read and understand the tsp section in the TSDuck user's guide, chapter 3, especially the section named "Modifying, inserting and deleting packets". Note that the example in section 5.2.21 removes one service from the input stream and replaces it with stuffing in order to get some free space in the stream.
Concerning the "error receiving from UDP socket: Bad file descriptor", does it appear after you hit Ctrl-C to interrupt tsp? If yes, then this can happen if the UDP socket is closed at the same time a receive operation is started.

I have found the solution. Thank you for your answer and the project.


Missing "ace-builds" dependency in /package.json

When I upgraded to RC2 and ran gulp, it gave me an error message about missing files in /node_modules/ace-builds .  I solved it by adding this line to package.json and running "npm update":
"ace-builds": "1.2.5",

Is it OK if I commit that change to the RC3 branch?  I assume that is your working branch in preparation for the next RC release?

Works for me.  Glad to hear from you as well.  :)

I have the same issue when following https://respondcms.com/documentation/installation-from-github.
@madoublet Nice project. I'm glad I found it.

I pushed a fix for this and another bug to RC3.  My plan is to have a short RC3 (less than a week) and then possibly a short RC4 before the final release.
@WitteStier Thank you, glad you like the project.

RC3 branch works for me. Thanks.

Sorry I didn't get to this in time.  I was not near a computer for a few days.  Closing this issue as fixed.


Inference batch size size for querying multiple images at the same time?

I'd like to be able to query the model and have it respond separately to each image in the provided batch. Is this possible right now?
Looks like I can potentially add with the following changes:
In the vision encoder we add support for multiple PIL images in the vision encoder:
    def __call__(self, images) -> torch.Tensor:
        # Convert a single image to a list if needed
        if isinstance(images, Image.Image):
            images = [images]

        with torch.no_grad():
            # Preprocess images and stack them into a single tensor
            x = torch.stack([self.preprocess(img.convert("RGB")) for img in images])

            x = x.to(self.device, dtype=self.dtype)

            # Rearrange the tensor for patch embedding
            x = rearrange(x, "b c (h p1) (w p2) -> b (h w) (c p1 p2)", p1=14, p2=14)

            # Pass through the encoder
            x = self.encoder(x)

            # Projection
            x = self.projection(x)

            return x

The next modification happens in moondream.py at:
def input_embeds(self, prompt, image_embeds, tokenizer):
...

        if "<image>" not in prompt:
            embeds.append(text_emb(_tokenize(prompt)))
            return  return torch.cat(embeds, dim=1)
        else:
            embeds = []
            assert prompt.count("<image>") == 1
            before, after = prompt.split("<image>")
            for i in range(image_embeds.shape[0]):
                embeds_batch = []
                embeds_batch.append(
                    text_emb((torch.tensor([[tokenizer.bos_token_id]], device=self.device)))
                )
                embeds_batch.append(text_emb(_tokenize(f"{before}<image>")))
                embeds_batch.append(image_embeds[i:i+1].to(self.device))
                embeds_batch.append(text_emb(_tokenize(f"</image>{after}")))
                embeds.append(torch.cat(embeds_batch, dim=1))

            return torch.cat(embeds, dim=0)

The final modification appears to be required for the caption outputs in moondream.py:

    def answer_question(
        self,
        image_embeds,
        question,
        tokenizer,
        chat_history="",
        result_queue=None,
        **kwargs,
    ):
        prompt = f"<image>\n\n{chat_history}Question: {question}\n\nAnswer: "
        answers = self.generate(
            image_embeds,
            prompt,
            eos_text="<END>",
            tokenizer=tokenizer,
            max_new_tokens=256,
            **kwargs,
        )
        results = []
        for answer in answers:
            cleaned_answer = re.sub("<$|<END$", "", answer).strip()

            # Use the result_queue to pass the result if it is provided
            if result_queue:
                result_queue.put(cleaned_answer)
            else:
                results.append(cleaned_answer)
        return results

Yea, could you please provide details about how to run inference for batches of images? :)

Just added support - here's an example of how it would work!
answers = moondream.batch_answer(
    images=[Image.open('<IMAGE_PATH_1>'), Image.open('<IMAGE_PATH_2>')],
    prompts=["Describe this image.", "Are there people in this image?"],
    tokenizer=tokenizer,
)

Can you try it out and let me know if there's any issues please?

@vikhyat I did a quick test, and everything appears to be working for batch inference. Thanks for the quick response and update!

Thank you for testing! Closing this, please reopen if you run into any issues.


Conflic with plugin redmine_agile on Chrome 59&60

Environment:
Redmine version                3.4.2.stable
Ruby version                   2.3.3-p222 (2016-11-21) [x64-mingw32]
Rails version                  4.2.8
Environment                    production
Database adapter               Mysql2
SCM:
Filesystem
Redmine plugins:
redmine_agile                  1.4.4
redmine_lightbox2              0.4.1
redmine_agile: https://www.redmineup.com/pages/plugins/agile
Testing on Google Chrome 59.0.3071.115 and 60.0.3112.90, but no problem with IE11 and Microsoft Edge.
Click "New Issue" and you will find the scroll bar missing.

Then if you click the "Help" button, the scroll bar will appears again.

Thanks for reporting but this has already been reported in #37. Closing this as duplicate.
This is not a problem with the lightbox plugin, but is related to a code change made by the redmine_agile folks. Here's a workaround you can implement until they will release a new version: https://github.com/paginagmbh/redmine_lightbox2/issues/37#issuecomment-318714797
Hope this helps!


Add custom request url

Customization api url #27

Hey, @iHTCboy.
Thanks for the pull request.
Please update OpenAI+Extensions.swift as well, so async/await functions also reflect the change.

@Krivoblotsky Thank you for your reminder, I have re-updated the submission now, we hope to merge and update the version immediately, we hope to use the latest code in our project [37iOS/iChatGPT), thank you~

Implemented by #33

@iHTCboy, your contribution is very appreciated 👍


REST-ifying existing model layers (ie. %ZEN.DataModel.ObjectDataModel)

In our application, we stripped out a model layer for accessing our %Persistent classes. The model classes inherit from %ZEN.DataModel.ObjectDataModel. They include business logic as triggers on loading or data manipulation, as well as in dedicated methods. We would like to reuse our model layer in a RESTful API. This would enable an evolutionary migration to alternative web frontend frameworks, while the current UI stays fully functional.
CRUD operations could work as follows, distinguishing (R)eading one (R-1) and querying many (R-n) entities. The latter should be realized via %Persistent classes, bypassing the model's initialization logic invoked when loading a dedicated entity for viewing and/or editing.
%ZEN.DataModel.ObjectDataModel

R-1: HTTP GET, (single ID) via %OnLoadModel
C, U: HTTP POST/PUT, via %OnStoreModel
D: HTTP DELETE, via %OnDeleteSource

%Persistent

R-n: HTTP GET, query "%pkg.isc.rest.model.adaptor flavour"

With isc-rest being a brilliant approach for REST-ifying existing %Persistent classes, extending its functionality for architectures with model layers could be beneficial for many applications.

@copperschnack one challenge here: are the field names used when querying in the R-n case in model terms or %Persistent?

@isc-tleavitt IMHO "model terms". They should be determined in the model by a class query which sets the required column aliases.

@copperschnack just to throw an other option out there, could use a property parameter - e.g., SQLALIASOF.
Motivating example:
Class DC.Demo.BackingPersistentClass Extends %Persistent
{

Property Foo As %String;

}

Class DC.Demo.SampleModelClass Extends %pkg.isc.rest.model.zenAdaptor
{

Parameter SOURCECLASS = "DC.Demo.BackingPersistentClass";

Property ModelVersionOfFoo As %String(SQLALIASOF = "Foo");

/// This callback method does the actual work of loading values from the source object.
Method %OnLoadModel(pSource As %RegisteredObject) As %Status
{
	Set ..ModelVersionOfFoo = pSource.Foo
	Quit $$$OK
}

}

How does that approach sound?

@isc-tleavitt SQLALIASOF sounds like a perfect fit for standard models. We might be even more flexible with an SqlComputeCode equivalent property parameter which could be brought into the SQL statement on query generation. This would allow access even to calculated model properties, if required.
What do you think about that?

We'd allow SQLALIASOF to be an expression - I think that should generally work. To be clear, the main purpose of this is filtering query results. The model representation will be based on loading the model from the source object by ID, where the query returns the IDs in question.


Add files for health check

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
7b4a265b84fdebb3cd8f19225bfbfa6623ed46a1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d0c74ae0556eefbe6f5699b7e5a37e7f68687684
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Could you fill me in some background/context? Any doc or issue should be fine.

@incfly these files are used here https://github.com/istio/istio.github.io/pull/1571

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: quanjielin, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


TypeScript definition not recognized in Svelte script tag

Working on a project where I have a local *.d.ts file with some defined types in it. Nova is able to find the declaration file and provide IntelliSense in all *.ts files in the project.
But using TypeScript within a Svelte component script tag does not recognize the types from the declaration file. This may be a TypeScript extension issue but it could be an issue with the Svelte extension—I'm not sure but checking here.
So given a declaration file like in global.d.ts...
// global.d.ts
interface User {
  firstName: string;
  lastName: string;
  age?: number;
}

the types are recognized correctly in the main.ts file in the Svelte project.
// main.ts
import App from './App.svelte';
let test:User = {
	firstName: "Aria",
	lastName: "Stark"
}
const app = new App({
	target: document.body,
	props: {
		user: test
	}
});
export default app;

And a screenshot of the same in Nova:

But inside of a Svelte component, Nova does not recognize the User type.

Hello {user.firstName} {user.lastName} {user.age}!

Visit the Svelte tutorial to learn how to build Svelte apps.

And a screenshot of the error in Nova:

Any thoughts or direction on where the issue might lie is appreciated.
To reproduce
Steps to reproduce the behavior:

Open the example project here: https://github.com/acarr/svelte-ts-nova-test
Install the Svelte extension for Svelte syntax highlighting
View errors in the App.svelte file

Expected behavior
Expect the Typescript types to be recognized within the Svelte file script tag.
Environment

Nova version: 5.1 Build 257074
Extension version: 2.1.1
TypeScript version: 4.2.3
Sidebar information: 4.2.3
macOS version: 11.2.2
NodeJS information:

node version: 12.13.1
npm version: 6.12.1

I've got your example project downloaded (very helpful!), 2.4.0 (just released) of this typescript extension, 0.1.6 of the svelte extension (sb.lao.svelte-nova).
I'm not experiencing the same issues you are, but I do think there are some issues with the Svelte language server used by the svelte plugin.
I'm not seeing errors shown for the User type in the .svelte file. I also see jump to definition working for it, but it's very slow the first time (>10 seconds), and I suspect based on some messages I saw in the logs that the svelte server might need the global.d.ts file where it's defined to have been previously opened for it to know about it.
https://user-images.githubusercontent.com/329222/124389337-e8210900-dce6-11eb-834a-737f23e224fd.mp4
Given that this extension explicitly doesn't process .svelte files but the svelte extension is providing some typescript support in svelte files, I think the cause is somewhere in its language server.


Docker Container log files not getting observed

I am not able to forward my docker logs to Logstash . WHat is the preffered way to do that , any document ?

With the current version of the framework you can forward logs by configuring a regular expression of container names via the UI. See the 'Config' section of the README


Add support for extensions (#93)

It's work in progress, I want to implement the compression extension and pass the AutoBahn test suite before merging this PR.

Hi Augustin,
I may have an idea of why all those tests are still failing on autobahn.
First of all, thoses tests all failed because the server closed the connection too early; looking at the reason, it is 1007, which leads to UnicodeDecodeError.
Under debugger, I managed to reach the point of failure, and it happens that, because of the fragmentation, the current is cut right in the middle of an utf-8 character, which causes the issue.
I don't think you can decode 1 frame at a time, but should instead wait for the last fragment to decode. But I'm wondering why this issue is not appearing as well without compression? Could it be a latent problem?
And... wow! all the other tests are PASS! This is looking pretty encouraging 👍

Humm... refining of previous statement: now I see the problem here: (protocol.py:466
        # Shortcut for the common case - no fragmentation
        if frame.fin:
            return frame.data.decode('utf-8') if text else frame.data <<<< raising UnicodeDecodeError

... that means that we received a 1 frame message ending with a non-utf8 character. Here is the data:
b'Case Description

[... cut, was 4096 long ...]

MESSAGE FRAGMENT 1:
Hello-\xc2'

it's probably perfectly legal in python2. I need to look at what the spec says about TEXT messages, are they supposed to be utf-8 decodable?

Have the answer from RFC 6455:
Section 5.6
Text

      The "Payload data" is text data encoded as UTF-8.  Note that a
      particular text frame might include a partial UTF-8 sequence;
      however, the whole message MUST contain valid UTF-8.  Invalid
      UTF-8 in reassembled messages is handled as described in
      Section 8.1.

And Section 8.1
   When an endpoint is to interpret a byte stream as UTF-8 but finds
   that the byte stream is not, in fact, a valid UTF-8 stream, that
   endpoint MUST _Fail the WebSocket Connection_.  This rule applies
   both during the opening handshake and during subsequent data
   exchange.

So that would mean that (correct me if I'm wrong):

It is perfectly right to fail the connection if you receive a message (not frame) which is not UTF-8
But it is not correct to attempt decoding frames of a fragmented message individually

The code path you're referring to only kicks in when there's no fragmentation -- that is when the first data frame has the FIN flag set.
Just below there's a loop that feeds the data from successive frames to an incremental UTF-8 decoder and reassembles fragmented messages.
Perhaps I messed up the encoding/decoding code and I'm setting the FIN flag when it shouldn't be set, thus ending up incorrectly in the "no fragmentation" code path.

Some of the tests fails on not fragmented code path, some on the fragmented one.

Le 21 mai 2017 à 09:44, Aymeric Augustin<EMAIL_ADDRESS>a écrit :
The code path you're referring to only kicks in when there's no fragmentation -- that is when the first data frame has the FIN flag set.
Just below there's a loop that feeds the data from successive frames to an incremental UTF-8 decoder and reassembles fragmented messages.
Perhaps I messed up the encoding/decoding code and I'm setting the FIN flag when it shouldn't be set, thus ending up incorrectly in the "no fragmentation" code path.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/aaugustin/websockets/pull/178#issuecomment-302920990, or mute the thread https://github.com/notifications/unsubscribe-auth/AL7y-JhOG5lEwG4ZLnJ_nXSsGIvHMzLMks5r7-tzgaJpZM4NP2AY.

Look specifically at test 12.4.5.
Case Description

Send 1000 compressed messages each of payload size 4096, auto-fragment to 0 octets. Use default permessage-deflate offer.

Looking at the test definition in autobahntestsuite/case/case12_x_x.py, they don't validate that what is sent as a message is utf-8 compliant.
Adding a simple msg.encode('utf-8') there before sending to the server under test raises an exception on the 35th message
  File "/Users/homerunisgood/virtualenvs/venv27/lib/python2.7/site-packages/autobahntestsuite/case/case12_x_x.py", line 160, in sendOne
    msg.encode('utf-8')
exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1976: ordinal not in range(128)

How can autobahn pass this test?

Adding a check in autobahn case_12_x_x.py to ensure it sends only messages which are utf-8 compliant, all the tests are pass

Thanks for your investigation, that's super helpful.
I inspected the code of the test suite and I read it like you.
self.testData = open(fn, 'rb').read() => returns an utf-8 encoded bytestring
msg = self.testData[idxFrom:idxTo] => may cut in the middle of a multibyte utf-8 character
Now I'm surprised that it contains such a bug, I assume at least some other implementations would crash like mine?

So, yeah, we aren't the first ones to notice, this is https://github.com/crossbario/autobahn-testsuite/issues/71.

There's a significant gap in the current design of this PR: the API for extensions doesn't handle negotiation.
We need two level of objects:

an "extension factory" that handles negotiation: 1 for a server, 1 for a client
an "extension instance" that processes frames: 1 per connection for a server, 1 for a client (for the single connection of that client)

For consistency and clarity, it seems best to separate these two concepts on the client side as well as on the server side, even if the factory will only produce one instance.
Naming them will be fun.
This is completely missing from the current design of the API. Furthermore, the factories will look quite different between the client and the server side, while the instances should be mostly identical, given that the protocol is symmetrical.

The negotiation phase looks like this.
On the client side:

an extension factory is configured with some parameters (with sane defaults)
the resulting parameters are sent to the server in the handshake request
the server sends something (or nothing) back in the handshake response
the extension may accept the server's answer and perhaps configure itself accordingly, or reject it and fail the connection

On the server side:

an extension factory is configured with some parameters (and sane defaults)
the client sends something (or nothing) in the handshake request
the extension may accept the client's request and perhaps configure itself accordingly, or reject it and fail the connection, or ignore it and disable itself
the resulting parameters are sent to the client in the handshake response

So we need the following APIs:
class ClientExtensionFactory:

    name = ...

    def __init__(self, **kwargs):
        """
        Configure the extension.

        Define negotiation rules. May accept callable arguments for complex logic.
        """

    def get_request_params(self):
        """
        Build request parameters.

        They should derive directly from the configuration.
        """

    def process_response_params(self, params):
        """"
        Process response parameters.

        Return configured extension instance.

        TODO: normalize exception to signal failure
        """
        ...
        return instance  # provides .encode() and .decode()

class ServerExtensionFactory:

    name = ...

    def __init__(self, **kwargs):
        """
        Configure the extension.

        Define negotiation rules. May accept callable arguments for complex logic.
        """

    def process_request_params(self):
        """"
        Process request parameters.

        Return response params and configured extension instance.

        TODO: normalize exception to signal failure
        """
        return (
            response_params,
            instance,  # provides .encode() and .decode()
        )

class ExtensionInstance:

    def decode(self, frame):
        """Decode an incoming frame."""
        return frame

    def encode(self, frame):
        """Encode an outgoing frame."""
        return frame

ExtensionInstance is described as a class here.
It could also be a pair of functions. These functions could still be bound methods on an instance, if carrying state in a class is more convenient. The drawback of the pair of functions is that it's harder to add something to the API, while a class makes it possible to add more methods later if needed (like cleanup methods for example). So it's probably more future proof to go with a class instance.

The current implementation does provide these two levels, but the first one is extremely limited and barely visible: WebSocketServerProtocol.process_extensions has a hardcoded check for permessage-deflate that instanciates a PerMessageDeflate extension instance (which, in turn, does the bulk of the negotiation).
I believe the API I outlined above is better than the current implementation because it separates negotiation from processing cleanly, and these are separate concerns.

I like the factory concept. It will make it much easier for future extensions, and seems indeed saner then the current instantiation. You're planning to have compression on by default on both sides, right? Note that it would be great to keep a way to quickly/easily be able to force disable compression at server or client instantiation; one common use case is when you run your websockets with network recording, it is much more convenient to have compression off in order to read the content!

While I still have a bunch of improvements on my TODO list, with my latest push, I believe the general design is now in good shape. Feedback welcome!

Of course test coverage is very much lacking. I'll work on it.

I had a syntax error in the permessage deflate factories, once fixed it runs like a charm.
Quick note: both deflate factories should be exported, in case you want to specify other options than those by default
Will have a closer look

I had an error in Safari:
WebSocket connection to 'ws://server:8080/' failed: Invalid UTF-8 sequence in header value

Was due to the following request:
GET / HTTP/1.1
Upgrade: websocket
Connection: Upgrade
Host: server:8080
Origin: http://server
Pragma: no-cache
Cache-Control: no-cache
Sec-WebSocket-Key: BXicWBw2TYXXUJnyHsnfGA==
Sec-WebSocket-Version: 13
Sec-WebSocket-Extensions: x-webkit-deflate-frame
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8

And the reply:
HTTP/1.1 101 Switching protocols
Server: Python/3.4 websockets/3.3
Sec-WebSocket-Extensions:
Upgrade: WebSocket
Connection: Upgrade
Sec-WebSocket-Accept: g4Hr94fj3OjAoBZpF4yyxqS8+3s=

Safari requests x-webkit-deflate-frame which we do not support, and does not allow empty headers in the reply.
It's a good use case, I guess we will have to make a round on all navigators to check how they behave!

Good catch — RFC 6455 says things about null vs. empty values. Generally an empty value represented by the empty string in Python isn't acceptable. The null value represented by None in Python corresponds to the lack of the header.

The code is complete and mostly tested.
If someone feels courageous and want to make a review, that would be really helpful!
I still have to:

[ ] complete test coverage
[ ] add documentation
[ ] add changelog

To be perfectly RFC-compliant -- but this isn't blocking for merging IMO -- I also have to:

[ ] handle multiple Sec-Websocket-Headers
[ ] add logic to handle properly multiple offers of the permessage-deflate extension with different parameters

(plus a few other ideas which require some investigation, I'm keeping them in my own TODO list)

Tested our solution with compression on Chrome, Firefox and Opera without any problem.
Safari does not implement permessage-deflate (instead using their own thing as discussed).
Internet Explorer does not enable compression by default.

And test coverage is done! This is adding about 50% to the amount in the project 🤓

@RouquinBlanc Thanks, that's very helpful!
I never bothered exercising the implementation with a browser (!)

I'm seeing failures in the autobahn tests: some of 12.4.* and all of 13.7.*.

12.4.* is a bug in the autobahn test suite.

13.7 was failing because I didn't handle multiple offers of permessage-deflate. Now I do.

I think this is done, except for the documentation.
What a marathon.

Merge now, discuss later!

:trollface:


multi language selection

i have created a new language... basicly it works and i can switch. .but the switch on the frontend is not working correctly..
i have 2 language's  (English & Dutch).
when i have English selected.. the language selection shows English.
when i pull down it shows English and nl_NL
when i select nl_NL then i get everything in the right language.. but then when i pull down, it says 2 time's nl_NL

en_US or nl_NL is simply strings that needs to be translated.
Depending on how many languages you have you can add these translations to your file with notepad

Open your en_US/LC_MESSAGES/messages.po with notepad
add line:

msgid "en_US"
msgstr "English"

msgid "nl_NL"
msgstr "Dutch"

Open same file with poedit and save catalog
Do the same with nl_NL/LC_MESSAGES/messages.po file

Hello,
Create.. this was the correct trick... thanks..
Take this in the manual incl. merging file's..
Create support..
Is backend also multilanguage?
-----Oorspronkelijk bericht-----
Van: Development Team<EMAIL_ADDRESS>Verzonden: vrijdag 24 februari 2012 8:03
Aan: johanpeters
Onderwerp: Re: [BoxBilling] multi language selection (#70)
en_US or nl_NL is simply strings that needs to be translated.
Depending on how many languages you have you can add these translations to your file with notepad

Open your en_US/LC_MESSAGES/messages.po with notepad
add line:

msgid "en_US"
msgstr "English"

msgid "nl_NL"
msgstr "Dutch"

Open same file with poedit and save catalog
Do the same with nl_NL/LC_MESSAGES/messages.po file

Reply to this email directly or view it on GitHub:
https://github.com/boxbilling/BoxBilling/issues/70#issuecomment-4152539

Backend currently is not translatable but it is prepared for multilanguage interface just like client area. You will simply translate admin.po file.


Update debugging doc

What does this PR do?

Thanks, @ananthsub. Missed it. BTW anything else do you think is worth adding?
https://github.com/PyTorchLightning/pytorch-lightning/pull/11390#pullrequestreview-850729055
Changes:

Added detect anomaly and DDP Debugging
Move things around to group them.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @rohitgr7

@ananthsub
just an attempt to provide users a page where they can go for debugging their models. It can be anything, bottlenecks in training code, unit testing, quick prototyping. Otherwise, they had to go and look for a complete trainer page or other pages and check which flag might help them.
Yes, I realized that they are not quite aligned together after reading it myself and grouping them already. Still WIP.

@rohitgr7 Docs build seems failing. Could you have a look?


CMake < 3.13: install TARGETS given target "lazperf" which does not exist in this   directory.

I see this error in github action with windows-2016 agent, because CMake is lower than 3.13.
-- The C compiler identification is MSVC 19.16.27045.0
-- The CXX compiler identification is MSVC 19.16.27045.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: called by CMake conan helper
-- Conan: called inside local cache
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
CMake Error at source_subfolder/cmake/install.cmake:22 (install):
  install TARGETS given target "lazperf" which does not exist in this
  directory.
Call Stack (most recent call first):
  source_subfolder/cpp/CMakeLists.txt:32 (include)

-- Configuring incomplete, errors occurred!
See also "C:/Users/runneradmin/.conan/data/laz-perf/2.0.0/bincrafters/testing/build/970e773c5651dc2560f86200a4ea56c23f568ff9/CMakeFiles/CMakeOutput.log".

CMake minimum version should be bumped to 3.13 in top CMakeLists, or probably a better solution would be to move install commands where targets are defined, I believe it makes CMakeLists easier to understand.

Fixed with 99ec34f72aa468f522e956001fda058e2c8b1054


Fix bug for get user by email

Fix #18830

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e039b76). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #18833   +/-   ##
=======================================
  Coverage        ?   46.61%
=======================================
  Files           ?      853
  Lines           ?   122470
  Branches        ?        0
=======================================
  Hits            ?    57088
  Misses          ?    58502
  Partials        ?     6880

Impacted Files
Coverage Δ

models/user/user.go
59.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e039b76...15c47b5. Read the comment docs.


White background on graphs

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description
Is there a way to implement white backgound in the plots even when using dark theme like in Jupyter Lab? When I am using a dark theme on vscode I cannot see what is in the graph's axis.
Example:
Jupyter Lab: https://i.ibb.co/bNXZwhy/1-jupyter.png
VsCode: https://i.ibb.co/bHQW506/2-jupyter.png

Did you change your theme after already running a cell? This should change the theming for the plots automatically. Unless of course you're changing the matplotlib theme yourself.

Hey gabriel19913. So with matplotlib you can set default styles with the style customization like so.
https://matplotlib.org/3.1.1/api/style_api.html
For our code when we detect dark themes by default we run matplotlib.style.use('dark_background').
However we also provide a setting in VSCode settings Python->Data Science->Run Startup Commands. This allows you to specify a set of custom commands to run at startup. Since these run after our theme settings you could run matplotlib.style.use('your style here') to set it back to light. Then this command would be run whenever you start up the interactive window or notebook editor. Does this work for you? I think 'classic' is just the default light theme.
Past that we also have a Ignore Vscode Theme setting, but that makes the entire window default light themed, so that doesn't sound like the option that you want.

It should be noted, after changing your theme, you currently need to restart the server (or close the notebook) and rerun the cell to get plots to show up correctly.
Meaning we will render them with a dark background as Ian describes, but only after rerendering. We don't reformat the existing output to be dark.

thanks for the advices @rchiodo and @IanMatthewHuff, I don't know what I am doing wrong, but this doesn't seem to work for me.
Like @IanMatthewHuff said I tried Python->Data Science->Run Startup Commands so I did this https://i.ibb.co/mhm7GVh/3-jupyter.png.
However now the plots are with a black backgroung:
https://i.ibb.co/x5sNFN2/4-jupyter.png
If I use the command matplotlib.style.use('default') in some cell it works, so I think I will with that for now.
Thanks for helping me.

We need to add a setting to allow the user to decide whether we honor the theme for graphs. By default they should always render to a white background and not apply matplotlib themes.


ChefDK 0.18.30 Script Execution Policy Install.ps1

When trying to build a new Windows machine I get an error about script execution policies on the install.ps1 script file.
My deploy server environment is ...
Ubuntu 14.04
ChefDK 0.18.30-1
: chef gem list | grep provisioning
chef-provisioning (2.0.2)
chef-provisioning-aws (2.0.0)
chef-provisioning-azure (0.6.0)
chef-provisioning-fog (0.20.0)
chef-provisioning-vagrant (0.11.0)
Here is the critical part of the log output ...
Starting Chef Client, version 12.14.89
[2016-10-12T21:06:52+00:00] INFO: *** Chef 12.14.89 ***
[2016-10-12T21:06:52+00:00] INFO: Platform: x86_64-linux
[2016-10-12T21:06:52+00:00] INFO: Chef-client pid: 25160
[2016-10-12T21:06:54+00:00] INFO: Run List is []
[2016-10-12T21:06:54+00:00] INFO: Run List expands to []
[2016-10-12T21:06:54+00:00] INFO: Starting Chef Run for epauto
[2016-10-12T21:06:54+00:00] INFO: Running start handlers
[2016-10-12T21:06:54+00:00] INFO: Start handlers complete.
[2016-10-12T21:06:54+00:00] INFO: HTTP Request Returned 404 Not Found: Object not found:
resolving cookbooks for run list: []
[2016-10-12T21:06:55+00:00] INFO: Loading cookbooks []
Synchronizing Cookbooks:
Installing Cookbook Gems:
Compiling Cookbooks...

:scissors:
[2016-10-12T21:10:56+00:00] INFO: Processing chef_node[Win-Test-Server1] action create (basic_chef_client::block line 57)
[2016-10-12T21:10:57+00:00] INFO: Processing chef_client[Win-Test-Server1] action create (basic_chef_client::block line 146)
[2016-10-12T21:10:57+00:00] INFO: Processing chef_node[Win-Test-Server1] action create (basic_chef_client::block line 157)

    - [Win-Test-Server1] write file C:\chef\ohai\hints\ec2.json on Win-Test-Server1
    - [Win-Test-Server1] write file C:\chef\client.rb on Win-Test-Server1
    - [Win-Test-Server1] write file C:\chef\install.ps1 on Win-Test-Server1
    [Win-Test-Server1] File C:\chef\install.ps1 cannot be loaded because running scripts is disabled on this system. For more information, see about_Execution_Policies at http://go.microsoft.com/fwlink/?LinkID=135170.
                         At line:1 char:3
                         + & "C:\chef\install.ps1"
                         +   ~~~~~~~~~~~~~~~~~~~~~
                             + CategoryInfo          : SecurityError: (:) [], PSSecurityException
                             + FullyQualifiedErrorId : UnauthorizedAccess
    - [Win-Test-Server1] run '& "C:\chef\install.ps1"' on Win-Test-Server1[2016-10-12T21:11:08+00:00] INFO: Processing chef_node[Win-Test-Server1] action create (basic_chef_client::block line 57)
[2016-10-12T21:11:09+00:00] INFO: Converging Win-Test-Server1 because the resource was updated ...

    [Win-Test-Server1] The term 'chef-client' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
                         At line:1 char:77
                         + $env:path = [System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE');chef ...
                         +                                                                             ~~~~
                             + CategoryInfo          : ObjectNotFound: (chef-client:String) [], CommandNotFoundException
                             + FullyQualifiedErrorId : CommandNotFoundException
    - [Win-Test-Server1] run '$env:path = [System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE');chef-client -l info' on Win-Test-Server1
[2016-10-12T21:11:09+00:00] INFO: Chef Run complete in<PHONE_NUMBER>21 seconds

The client.rb, ohai directory, client.pem files and install.ps1 file are all there and look fine.
This is going from a working ChefDK 0.15.16 to a not working 0.18.30.

One possible fix: https://github.com/chef/chef-provisioning-aws/issues/507
To use winrm-elevated by default to run everything as scheduled task.

What happened to running the install.ps1 with elevated permissions?  Is this no longer possible?

What version of chef comes with 0.15.16?  Or is this an issue with chef-provisioning-aws?


update bevy, add conversion for hand and add openxr action code

i forgor about sending the actual binding suggestions

i'll probably rewrite this using schminput once i am done with another round of improvements for that


ENH handle AROs as string rather than int in get_aro_mapping_table()

AROs were previously handled as int in the get_aro_mapping_table() function and this posed challenges when ARO numbers such as '0010004' (leading zeros are cut). To fix this, AROs are now treated as strings and the zfill function is used (AROs are 7 digits) so leading zeros can be maintained.

When I saw the title, I expected a different (and, IMHO, better) solution (see attached patch)
load_aro_as_str.txt

Oh yes, this is much better. I actually tried something similar with as_type but that didn't work. I will use this


[Question] Shouldn't "theme: alembic-jekyll-theme" be in _config.yml?

Hello,
I was wondering if maybe theme: alembic-jekyll-theme was omitted from _config.yml by mistake?

Hey, that’s a fair question. It’s omitted because this repo is the theme and doesn’t need to reference the theme to get all the code for it. If you look at this repo you’ll see the theme key has been set how you expect https://github.com/daviddarnes/alembic-kit


Added SortArray File In Java

Created a new java file SortArray

make sure to give the repository star!

share this repo with your friends and happy coding :)


Upgrade react-navigation-redux-helpers to v3.0.2, react-navigation to v3.11.0

This PR does a major version upgrade for react-navigation-redux-helpers, according to https://github.com/react-navigation/redux-helpers/releases/tag/3.0.0. The react-navigation upgrade is optional, but I recommend doing this also.

Thanks so much, @bencergazda. This is really great work.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bugfix/remove the use of chmod for windows

Submisison Checklist

[x] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
Fix for the bug that caused https://github.com/stan-dev/cmdstan/issues/873
Windows does not have chmod and in releases (which come with bin/windows-stanc) we try to use it after copying bin/windows-stanc to bin/stanc.exe
But its not needed. And this fails if users dont have Git for Windows.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

But its not needed.

why?  no permissions problem on Windows?

.exe files are by default executable on windows. There is actually no equivalent to the "executable" (x) Linux attribute in the DOS/Windows file attributes. So who knows what the chmod does if you have it :)
We don't use chmod if we download binaries of stanc3 and that has caused no issues.


[Feature] llm Options

Background
I wish to experiment with other LLM models like Tongyi or Gemini, but it's not feasible.
https://github.com/browserbase/stagehand/blob/fecd42e9c71f60f50ce14212f76b422603933ab8/lib/llm/LLMProvider.ts#L62
Aspiration
Provide a solution akin to browser-use, allowing the integration of custom models.
import { OpenAI } from "@langchain/openai";

const llm = new OpenAI({
  model: "gpt-3.5-turbo-instruct",
  temperature: 0,
  maxTokens: undefined,
  timeout: undefined,
  maxRetries: 2,
  apiKey: process.env.OPENAI_API_KEY,
  // other params...
});
await stagehand.init({llm});

Benefits

less code、lower maintenance complexity
The token cost of GPT-4 is relatively high; in certain scenarios, cheaper models can be employed to achieve similar outcomes.

+1, this would also be nice if we could use with OpenRouter for many reasons (e.g. rate limits, consolidated billing, experimenting with different models to determine the output quality against cost)


[WIP][DRAFT] Pip installable PySpark

Draft pip installable PySpark package. This does a bunch of hacks to copy the jars over.
Done:

pip installable on conda [manual tested]
setup.py installed on a non-pip managed system (RHEL) with YARN [manual tested]
Automated testing of this (virtualenv)
packaging and signing with release-build*

Possible follow up work:

release-build update to publish to PyPi (not being a commiter difficult to work on)
investigate details of wheel caching
consider how we want to number our dev/snapshot versions
Windows? idk

Explicitly out of scope:

Using pip installed PySpark to start a standalone cluster
Using pip installed PySpark for non-Python Spark programs

*I've done some hacks to test release-build locally but as a non-committer I've just done local testing.

So we could set the SPARK_HOME to be a level up, but then our package names wouldn't make sense (e.g. we'd have to publish a jar package which might conflict with someone elses package named jar). Alternatively we could have a copy of all the code, which might work (since the spark scripts will look under SPARK_HOME/python/pyspark), but it feels a bit weird to have a copy of everything. For the shell.py it maybe makes sense to just copy the shell script since it is the only script which is referenced by path (everything else is by import which will work just fine).

Hi @minrk I figured I'd ping you (as suggested by @rgbkrk ) to see if you maybe have any thoughts or suggestions around packaging PySpark this way. This isn't yet the "formal" pull request but unless I've done something really off the bend I'll probably make it tomorrow morning before the second day of Spark Summit EU (and can continue discussion on the "formal" PR of course too).
Packaging the jars is a little awkward as is trying to provide an env that both makes sense with the existing shell scripts and python based import so if there are ways to do it better I'd love to know (but I also have the impression that there might not be a lot of better ways to do this).

@holdenk thanks, this is awesome! So the jars are copied into the Python package and bundled together on install, meaning a pip-installed pyspark doesn't refer to any spark files outside itself?
I'm sure there are a dozen ways to do it, depending on how/when you want to tie pyspark to specific jars.

@minrk thanks for taking a look and providing these suggestions :) So yah currently the jars are copied from the scala build and the Python package doesn't need to depend on any other Spark install outside of it. I figured this was also safer since if we had it pip installed and JARs provided elsewhere I could see people accidentally mixing and matching the two versions and Py4J error messages aren't the simplest to understand at the best of times. I'll work on this some more tomorrow after the keynotes :)


Unable to load custom tokens

🐛 Bug

Model I am using (Bert, XLNet....): GPT2
Language I am using the model on (English, Chinese....): English
I am unable to load the custom tokens that were added to GPT2 tokenizer while training.
Code used while training
SPECIAL_TOKENS = ["bos_token","eos_token","persona, "personb", "pad_token"]
tokenizer = tokenizer_class.from_pretrained("gpt2",unk_token="unk_token")
model = model_class.from_pretrained("gpt2")
tokenizer.add_tokens(SPECIAL_TOKENS)
model.resize_token_embeddings(len(tokenizer))

#To save the tokenizer
tokenizer.save_pretrained(directory)

While Loading
tokenizer = GPT2Tokenizer.from_pretrained('./experiment1_conversation/runs/new/')

I run into the issue of unable to convert the custom tokens and it produces *None *. Is there something wrong in the way I am loading the tokenizer or saving it?
I get
Environment

OS: Ubuntu
Python version: 3.6.8
PyTorch version:1.1
PyTorch Transformers version (or branch):1.1
Using GPU ? Yes

Hello, thanks for the bug report.
Could you please show me what's inside the directory experiment1_conversation/runs/new and experiment1_conversation/runs/old?

@LysandreJik the previous issue I had posted was due to a mistake on my side. I updated the issue.

@LysandreJik This is the content inside the directory.

No, the way you're saving your tokenizer is correct. If you study what's inside the added_tokens.json, you should have:
{"bos_token": 50257, "eos_token": 50258, "persona": 50259, "personb": 50260, "pad_token": 50261}

Following your procedure, when I print tokenizer.convert_tokens_to_ids(["bos_token"]) after loading from the saved directory, I get [50257], which is correct.
Could you show me what is inside of  your added_tokens.json?

@LysandreJik The added_tokens.json is saved in the wrong way for me.
{"50257": "bos_token", "50258": "eos_token", "50259": "persona", "50260": "personb", "50261": "pad_token"}
Any reason for this?

What are tokenizer_class and model_class instances of? Are they instances of GPT2Tokenizer and GPT2Model?
Do you get the same result if you run this script?
from pytorch_transformers import GPT2Tokenizer, GPT2Model

import os
os.makedirs("save_it_here")

SPECIAL_TOKENS = ["bos_token", "eos_token", "persona", "personb", "pad_token"]
tokenizer = GPT2Tokenizer.from_pretrained("gpt2")
model = GPT2Model.from_pretrained("gpt2")
tokenizer.add_tokens(SPECIAL_TOKENS)
model.resize_token_embeddings(len(tokenizer))

# To save the tokenizer
tokenizer.save_pretrained("save_it_here")

tokenizer = GPT2Tokenizer.from_pretrained("save_it_here")
print(tokenizer.convert_tokens_to_ids(["bos_token"]))

The above script produces the same results as what you got. I will investigate how mine went wrong when training. Thanks for the help. I will close this for now?

Alright, glad I could help. Don't hesitate to re-open if you see something weird :).


Negative crew after hiring expert

Departing the planet after hiring my first expert crew member, my flagship's crew was set to -87, rendering it almost disabled. After landing and taking off again, the crew complement was restored to full. I have the Rehire extra crew when lost option turned on. This might be a game bug, not an issue with the plugin? Can you reproduce it?
Save file

Can't  reproduces that with my own saves, but on yours. Testing a bit atm.
For the moment you can reload the last save when stuck in space. Then you have the expert and the crew got fixed. Though that shouldnt be possible.

It has something to do with your flagship. Changing the shield Beatle to flagship let's you aquire new experts without problems. Even changing to an other kestrel works.
First I thought the bay ships like the drones would cause this, but selling them all lets the problem persist.
So easiest would be to change the flagship and we let it be a mystery. Maybe sell that cursed kestrel?^^
Well, if you find out what exactly is causing this, let me know.


Benchmark gossipsub implementation

In order to make sure our implementation is the best it can be, we will need to benchmark each step of the gossipsub protocol.

[ ] Subscribing to peers

[ ] Publishing to peers

Closing in favor of #23


[Phoenix] Upgrading phoenixdb into it's latest version

What changes were proposed in this pull request?

Phoenixdb 1.2.0 to 1.2.1

How was this patch tested?

Manually

LGTM! Have you tested it end-to-end? Also should we change the package in ext-py for Py2 support also?

Need to discuss with the team whether we still want to support or maintain the python 2 based Hue.


Add background color on active tab

Hi just want to ask what is the props for changing style of active tab, i use the 'tabBarActiveStyle' props and set background color but nothing happens.

It is not that difficult to do. Here https://github.com/skv-headless/react-native-scrollable-tab-view/blob/master/DefaultTabBar.js#L20 property activeTabStyle.

@skv-headless  this is my example code
<ScrollableTabView
style={{ margin: 20 }}
scrollWithoutAnimation={true}
tabBarActiveTextColor={'#00A47D'}
tabBarUnderlineStyle={{ backgroundColor: '#00A47D'}}
activeTabStyle={{ backgroundColor: 'red' }}

<TabOne tabBarUnderlineStyle={{ borderColor: '#00A47D' }} tabLabel='Tab 1' />

@radvc
Hi !
You have to modify the DefaultTabBar component itself

Hi all!
I did try it on latest version. But it not working.

I @lalala345 can you show us a piece of your code please ? It will be simplier to see what's wrong.


Feature: Darkmode

Simply code and use tsx, so we don't have to compile typescript
add concurrency so we github action can finish quickly.
Remove unnecessary node js package
Upgrade playwright to latest version.

@SoapDev2018 if you got time please review it.

Looks good to me!


[Bug]: Discard fails with unable to import application error

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Steps To Reproduce

Go to this app
Open git sync modal and discard
Observe error is thrown

Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Deploy preview

/ok-to-test


Akita array helpers are not exported in lib

I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:
Current behavior
Akita array helpers such as arrayAdd, arrayRemove etc. exist in source code but are not exported to public api
v3.0.1

Sorry and thank you for the report.


Discrepancy in reported progress when creating object detection DB

when creating a new object detection DB, the progress shown on the job page is different than the one shown in DIGITS homepage.
As example on the job page it shows 30%, while at home it shows 77%

I just realized that the progress inside the job is per subset. I.e. it shows progress for train set individually.


No authentication + app in an iframe leads to producing number of docker containers

Hello,
I would like to start with big thank you to all openanalytics team for such a great tool.
I have some problem with shinyproxy. Our internal shiny application works on the server with shinyproxy (address1). There is no authentication set there authentication: none. If I go directly to adress1, everything works fine. Each person entering addres1 gets 1 docker container. But if I put address1 as an iframe on some other webpage (address2), just for example:
<html>
<iframe src="http://address1/app_direct/myapp" width="100%" height="100%" title="iframe"></iframe>
</html>

and I go to address2, now app starts very slowly and I can see producing number of containers on my server what leads to  overloading server very fast.
I also tried with
src="http://address1/app/myapp" or src="http://address1" + setting landing-page in shinyproxy configuration
I have no idea how I can fix it. Could you please help me?
All the best !

Hi @spokowodza
This is a very similar issue as in #305, please have a look at the comment I just posted in that issue.

Hi @LEDfan
Thanks a lot !


istiooc does not work properly with  --public-hostname

Setting up cluster with parameter --public-hostname=$IP still makes web console to redirect to ip <IP_ADDRESS>
Version
istiooc/v3.10.0+maistra-0.1.0-3+93134ea
[provide output of the openshift version or oc version command]
Steps To Reproduce

Setup cluster like: istiooc cluster up --public-hostname=$IP
Open web console on https://:8443$IP

Current Result
redirect to <IP_ADDRESS>:8443
Expected Result
no redirect and working console on $IP:8443

@mocenas do you have a link to an upstream issue?

@knrc Links related to this issue:
https://github.com/openshift/origin/issues/19699
https://bugzilla.redhat.com/show_bug.cgi?id=1579598

@mocenas It looks as if this is a different issue as we already have that fix in our codebase.
What I'm seeing is the following
Getting a Docker client ...
Checking if image openshift/origin-control-plane:v3.10 is available ...
Creating shared mount directory on the remote host ...
Determining server IP ...
Using public hostname IP <IP_ADDRESS> as the host IP
Checking if OpenShift is already running ...
Checking for supported Docker version (=>1.22) ...
Checking if insecured registry is configured properly in Docker ...
Checking prerequisites for port forwarding ...
Checking if required ports are available ...
Checking if OpenShift client is configured properly ...
Checking if image openshift/origin-control-plane:v3.10 is available ...
Starting OpenShift using openshift/origin-control-plane:v3.10 ...
I0905 08:40:19.938064   36011 config.go:43] Running "create-master-config"
I0905 08:40:21.801465   36011 config.go:46] Running "create-node-config"
I0905 08:40:23.036169   36011 flags.go:30] Running "create-kubelet-flags"
I0905 08:40:24.182830   36011 run_kubelet.go:48] Running "start-kubelet"
I0905 08:40:24.486594   36011 run_self_hosted.go:172] Waiting for the kube-apiserver to be ready ...
E0905 08:45:24.817337   36011 run_self_hosted.go:542] API server error: Get https://<IP_ADDRESS>:8443/healthz?timeout=32s: EOF ()
Error: timed out waiting for the condition

and when I check the api server I am seeing the following failure
F0905 15:32:03.729630       1 cmd.go:53] dial tcp <IP_ADDRESS>:4001: getsockopt: connection refused

I'll try and debug further

It looks as if the configuration is being generated using the public hostname for the etcd, I'm seeing the following in the master-config.yaml
    'etcdClientInfo': {   'ca': 'ca.crt',
                          'certFile': 'master.etcd-client.crt',
                          'keyFile': 'master.etcd-client.key',
                          'urls': ['https://<IP_ADDRESS>:4001']},
    'etcdConfig': {   'address': '<IP_ADDRESS>:4001',
                      'peerAddress': '<IP_ADDRESS>:7001',
                      'peerServingInfo': {   'bindAddress': '<IP_ADDRESS>:7001',
                                             'bindNetwork': 'tcp4',
                                             'certFile': 'etcd.server.crt',
                                             'clientCA': 'ca.crt',
                                             'keyFile': 'etcd.server.key',
                                             'namedCertificates': None},
                      'servingInfo': {   'bindAddress': '<IP_ADDRESS>:4001',
                                         'bindNetwork': 'tcp4',
                                         'certFile': 'etcd.server.crt',
                                         'clientCA': 'ca.crt',
                                         'keyFile': 'etcd.server.key',
                                         'namedCertificates': None},
                      'storageDirectory': '/var/lib/etcd'},

and this is invalid in my environment.

moved to https://issues.jboss.org/browse/MAISTRA-18


Fix ufw firewall script

Pull Request
Title
[Provide a succinct and descriptive title for the pull request.]
Type of Change

[ ] New feature
[x] Bug fix
[ ] Documentation Update
[x] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description
Refactor firewall-baselines.sh script and fix bugs that make it not work
Testing
Tested it in multiple scenarios (ufw installed or not, ubuntu, arch)
Impact
Made the script work
Issue related to PR
[What issue/discussion is related to this PR (if any)]

Resolves #

Additional Information
[Any additional information that reviewers should be aware of.]
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

I opened PR #119, which fixes the missing inclusion of the common script, but yours adds more stuff so I will close mine.

You should just move sudo ufw enable before the enabled baselines message and it should be fine. Also I don't think disabling UFW and then re-enabling it is necessary.


godep restore makes impossible to update project with go get

Currently godep restore puts the repositories in detached HEAD and this makes impossible to execute a go get -u github.com/foo/bar. If a high number of projects using godeps are used and if godep restore is used frequently, this leads to a very high number of projects in detached state which makes very hard to update them.
Are we able to avoid this somehow?

Longer term, yes, by removing the need to godep restore. A go tooling change recently (go1.6) made this a problem AFAIK.

PS: godep restore is doing what it's always done, restore the recorded versions to the $GOPATH. it can only do this by checking out the various shas (AFAIK) it's recorded.
As a temp work around I could implement a godep unrestore, which would check out master again. But I'm hesitant to add another command that should be removed in the future and I'm not sure it's super helpful in the workflow ... ie. you have to remember to use it.
Thoughts?

I was about to implement a godep unrestore myself, I think it would be useful (I can work on it and submit a PR, but if you want to work on it, as you whish). More important, though is to document in the README what happens now if a user executes godep restore.
Also, can you give me the detail of this change in 1.6 you are mentioning above?

PRs welcome. I don't have an exact commit to golang where this broke. Let me see if I can dig it up though.

It was likely this one: https://github.com/golang/go/commit/42206598671a44111c8f726ad33dc7b265bdf669

@Raffo What would you suggest be added to the README? It states what godep restore already does in a non VCS specific manner, since godep handles multiple types of VCS.

Thanks for the link to the commit.
Do you think that a warning like "godep restore could leave some of the dependencies in a detached state. This could lead to problems to update your dependencies" would be too much? Maybe we could add some text to specify that the users should avoid using godep restore if not strictly necessary.

How about
NOTE: godep restore leaves git repositories in a detached state. go1.6+ no longer checks out the master branch when doing a go get, see here.
Then if you land an unrestore PR we can adjust that to recommend the usage of unrestore afterwards?

Sounds good to me.

@Raffo README / restore help text updated in 584a3f5bf2671886bd3f7dc2b252762b5aa2a087

:+1:

As I imagined, it's very easy to hack an "unrestore" command to checkout the master, but it's not so easy to make the unrestore command so general that can handle cases in which the default remote branch is different from the master. I would have to add this information to Godeps.json (the remote HEAD), but I'm not sure we want that.
If we agree that we will implement that, I wouldn't know any valid command that will give me the current remote HEAD. The only valid info I know how to get is in git remote show origin, but I don't really want to parse the output. Any suggestion/help?

@freeformz Any input on what I wrote above?

Why does the remote branch matter? I don't think we want to pull new code with unrestore, just check out the local master.

@freeformz because it's not obvious that the main branch is the master. If you clone a repository which remote HEAD is not the master you will end up with something different than a master branch. In such a case, if godep unrestore tries to restore it to the master branch this could lead to wrong results.

It only matters what it's merged to locally AFAIK, so git config --local branch.master.merge should tell us what to checkout.
I could totally be wrong here, I don't think I've ever worked with remotes who HEAD was not master.

Take the gin repository: the master`` branch exist, but the remote HEAD is develop```. I think that in this case it will not work.

I see. If there is only one branch returned with git config --local --get-regexp 'branch.*' we could check that out and otherwise punt with instructions to the user to start?

Or we just modify Godep.json to be something like:
	{
			"ImportPath": "github.com/spf13/pflag",
			"Rev": "8f6a28b0916586e7f22fe931ae2fcfc380b1c0e6",
			"RemoteHEAD": "master"
		},

And use the RemoteHEAD when executing unrestore. This will break only in case the remote head of the repo changes from the last time the Godep.json is updated, which is not perfect, but acceptable (IMO).

I'm not sure I really want to require people to populate that field manually. Also AFAICT RemoteHEAD is detectable through either:
$ git remote show origin
...
HEAD branch: develop
...

or
$ git branch -r | grep "origin/HEAD ->"
  origin/HEAD -> origin/develop

possibly some other means as well.

This is exactly what I meant, RemoteHEAD would be populated when godep save is executed. When doing godep unrestore we could also add a --force option (I'm not sure if this flag is already used in another way in other godep commands) to remove the dependency and re-executing a go get from scratch in case of failures. Obviously after a warning and a confirmation from the user.

I'm not sure we should save RemoteHEAD though and just honor the remote head from git info for what's already there.

So, what you suggest is to just use the info from git remote show origin , i.e:
* remote origin
  Fetch URL: https://github.com/kubernetes/kubernetes.git
  Push  URL: https://github.com/kubernetes/kubernetes.git
  HEAD branch: master
  Remote branches:

Is this right?

FWIW, today I got fed up with this and just banned godep restore from my entire system.  I did this with a script:
https://github.com/eduncan911/dotfiles/blob/master/bin/godep
If you want it, check it out into your ~/bin, first make sure your personal ~/bin comes before your $GOPATH/bin:
If so, you are good to go.  If not, you may want to tweak your $PATH to use your personal ~/bin before your GOPATH/bin.
  And when you try to do godep restore:
$ godep restore
WARNING: godep restore <- this will frack with your /Users/eric/go !!
WARNING: to override, use your installed version of godep like this:
WARNING:      $GOPATH/bin/godep restore
WARNING: Aborting ...

hehe.  👍
I'm in the habit of using the godep prefix for all my go needs anyways:
godep go test ./...
godep go run main.go
godep get foo/bar

...etc.  But I've accidently used godep restore a few times, like today when I ran a Makefile for a new repo I was working on.  Argh!  Spent over an hour restoring all of my $GOPATH repos back to master.
No more!

No need to spend an hour restoring them all, just do:
find $GOPATH/src -type d -name .git -execdir git --git-dir={} checkout master \;

i have to exclude the dozen or so that I am working on...  that do have pending commits, on different branches, etc.


Thank you! (please read)

@tombeynon WOW! 🏆
I'm so glad I just happened to see your comment in an email from watching the cosmos/chain-registry!!!
I recently started my own CORS proxy for API endpoints in the chain-registry... (thinking none existed yet) since it has become a necessity for using in my own projects (mostly because I don't want to rely on others for API aggregation uptime / breaking changes.)
So many thanks for making this, you've saved me a lot of time (I've also realized this would have taken me months to do with my lack of experience)
So, because this is a weight lifted from my shoulders, you've enabled me to focus on continuing to building my own stuff. I'll contribute where I can (ideas/bugs report/suggestions/patches...). Let me know if there's anything else I could do (not sure what, perhaps feedback at least!)
I noticed in the readme that it's still MVP and API structure could break. I'll just fork it and watch for changes :)
Thanks again!
Jason

@jasbanza this comment totally made my day! I've had the idea for cosmos directory for a while but went through the same issue as you building restake, and it sort of forced me to build out the core of this. As soon as I realised how useful it could be I had to publish it but as you saw in the docs.. it is early days!
Super excited to have someone like you actually using it though and pushing it's limits a bit. There's SO much this can do, I have a huge list of ideas which I'll move into Issues so it's a bit more public and I can't wait to hear some of your ideas/bugs.
In terms of actual production use, it's working surprisingly well. In the last 24h it processed 21.4 million requests for REStake.app lol. Obviously the nodes are doing the bulk of the work but the proxy stands up well to a lot. However... it does experience event loop lag that grows over time with this many requests. I've not got to the bottom of this yet, but I use pm2 and ecosystem-production.json to restart the processes every few hours/as memory grows which is pretty graceful.
I've not actually shouted about it too much so I'm really glad you found it. I've got a couple extra features I want to add first but I don't expect to change any existing API structures now. Please let me know any thoughts at all after using it ❤

@tombeynon Thank you for your reply!
Brilliant - I had no idea REStake was using it... until I noticed this repo was under eco-stake!
I have yet to delve into using this, but from what I've seen with cosmos.directory, Terra reports that there is no REST API, even though the chain-registry has one which seems live. Why is that?

Part of cosmos.directory is health checking all those APIs as they can be very up and down, and it generally load balances across the most up to date/responsive at any given time. With Terra, the single REST API in registry stalled this morning.
You can see the last error and a few other stats on the cosmos.directory UI, or a bit more info via the API.
Actually Terra is a good example; if you refresh the latest block endpoint a few times you'll see it's already load balancing two nodes. Both are behind in this case, but often just one of many can be behind. Directory health checks pretty often to try to catch these, as they're a pain for restake etc.

An idea I had was to have a custom override API json config files for certain chains... (you might want to include keplr's endpoints for example)... not sure if you've thought of this, as it could make up for cases such as Terra where they have provided troublesome API / RPC

Yea that's a great idea. I've thought a few times about a local config file, currently cosmos.directory uses the eco-stake fork of the chain registry which I initially used to add a couple of 'less' public nodes for REStake, but quickly decided that i should just publish my own. Now I just use the fork to merge PRs sooner than upstream.
This behaviour bit might actually be a bit restake specific tbh. My attitude with that is if I validate a network, I'll make sure the APIs are available. If I don't validate, it's up to validators/chains to provide APIs if they want REStake to work. Possibly doesn't translate as well to cosmos.directory, but equally I'm wary of using nodes for this/REStake without permission. Do Keplr publish theirs as 'public use' as far as you know?

I noticed you added public eco-stake APIs throughout the chain-registry :)
Are you asking about Keplr RPC or REST? https://lcd-columbus.keplr.app
With regards to public usage, I can't say.
If my understanding is correct (correct me if I'm wrong): RPC APIs are normally more commonly kept private compared to REST APIs, due to their importance not to be overloaded.
So is it generally UNacceptable to use either without prior permission in an app?

Yea that's my general attitude - would be fine to use Keplr APIs for 'personal' use but I'd hesitate to include them in cosmos.directory APIs.
As I understand it, the REST API is just a translation of the underlying RPC server, but I'm not 100% sure. I only publish nodes I'm okay with being overloaded either way, and generally assume the APIs in chain registry are fine to use. Hence the health checking tho 😂


Int narrow

rebased pr and silenced a tidy warning.

fixed issues pointed out by @mfleisz , rebased to current master.


chore: reuse docker containers when generating protobuf files

fixing the image version to the latest released (@latest is not good)
optimizing the make proto-gen job by reusing proto containers instead of removing them all the time.

Oh hrmm, doesn't work on my local docker install. I get
make proto-gen
Generating Protobuf files
/third_party/proto: does not exist
make: *** [proto-gen] Error 1

I'll check on my separate build server though, since make proto-gen didn't work on my laptop before either

Codecov Report

Merging #496 (c702ccd) into main (a05d119) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   20.06%   20.20%   +0.13%
==========================================
  Files         163      163
  Lines       23326    23358      +32
==========================================
+ Hits         4681     4720      +39
+ Misses      17888    17878      -10
- Partials      757      760       +3

Impacted Files
Coverage Δ

x/incentives/types/query.pb.go
0.84% <ø> (ø)

osmomath/math.go
65.90% <0.00%> (ø)

x/lockup/keeper/store.go
94.73% <0.00%> (+0.14%)
:arrow_up:

x/lockup/keeper/lock.go
76.73% <0.00%> (+1.27%)
:arrow_up:

app/app.go
86.09% <0.00%> (+1.45%)
:arrow_up:

x/incentives/keeper/gauge.go
62.41% <0.00%> (+2.70%)
:arrow_up:

x/lockup/genesis.go
75.00% <0.00%> (+11.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05d119...c702ccd. Read the comment docs.

/third_party/proto: does not exist

sounds like a dependency problem with the cosmos-sdk. It's strange, because in SDK we are using the same docker container (v0.2) for 0.42 builds.
could you remove your docker images and containers and recheck?

@mattverse pointed out that the problem was that I have a local vendor directory. Not sure why that causes issues, but it does 😕 .
After deleting my vendor folder, both this branch and main worked for me!

Cool, happy that it works and thanks for merging.

the problem was that I have a local vendor directory

Ah, most likely you had proto files in that directory. The proto compilation scrip is importing all proto files and tries to compile them: https://github.com/osmosis-labs/osmosis/blob/main/scripts/protocgen.sh#L12

Ahh thanks, looks like we just need to add the line for ignoring the vendor directory there. I'll submit a PR here and on the SDK for that!


Interface becomes full of lines around text boxes as we move the mouse

Microsoft PowerToys version
0.72.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
As you move the mouse or press some keys, like the ALT key, the interfaces become full of lines around the text boxes.
PowerToysReport_2023-08-07-14-21-03.zip
Screenshots.zip
✔ Expected Behavior
We expect a crisp clear interface.
❌ Actual Behavior
As you move the mouse or press some keys, like the ALT key, the interfaces become full of lines around the text boxes.
Screenshots.zip
Other Software
No response

@niels9001 , is this a known issue?

It's been reported a few times. Usually it comes down to the graphics card misbehaving.

Other than this I see no unusual graphics behaviour with this machine.
At the time I was using NVidia Driver version 536.67, but I have been updating it since May, which was when I received the machine, and the problem has always been there.

No.
The graphics card is working just fine.
This is the only program misbehaving in the computer.

From: Jay @.>
Sent: Wednesday, August 9, 2023 4:06 PM
To: microsoft/PowerToys @.>
Cc: PauloJFMartins @.>; Author @.>
Subject: Re: [microsoft/PowerToys] Interface becomes full of lines around text boxes as we move the mouse (Issue #27884)
It's been reported a few times. Usually it comes down to the graphics card misbehaving.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/27884#issuecomment-1671589562, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5TOFZTFO2TU5KTO3RGLTLLXUORN5ANCNFSM6AAAAAA3HAM4NA.
You are receiving this because you authored the thread.Message ID: @.***>


Shuffler always turns sound on

https://github.com/authorblues/bizhawk-shuffler-2/blob/410b33a2fb12d99a116f4685e3f25e29b6499a42/shuffler.lua#L503
This line always enables the sound even if it was disabled (false or true == true). I assume this is intended to supply a default value if  config.sound is  nil, which could be expressed as config.sound ~= false.
I think it would be preferable if the shuffler just didn't call client.SetSoundOn if config.sound is nil, so it doesn't unmute Bizhawk if it was muted before the shuffler was started.

 You're obviously correct. Easy fix.


Added github actions to trigger circleci deploy pr-nets

Purpose
This pull request contains the github actions to trigger circleci jobs to deploy / redeploy / cleanup pr-nets
For reviewers
This pr just contains the github actions, but not the circleci config
Related Github issues

Changes

Tests

Deployment Considerations
Version Notes
{ major | minor | patch }

NOTE: Include the version notes in the squash commit message

Can't we reuse some steps? Like the GitHub API Request

https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/

https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/

I think Github action does not support anchors

Can't we reuse some steps? Like the GitHub API Request

maybe this can be used somehow
https://github.blog/changelog/2020-08-07-github-actions-composite-run-steps/

i can create reusable actions, if it is worth i can do it.

i have refactored it to use composite actions, please review, i think for the close pr, and merge we can do it later, this gives at least place to work on the other events, since close/merge are different workflows, i think

i have added triggering cleanup on PR close without merging, the PR update automatically triggers circleci pipeline when a push to the head branch is done, we neeed to detect if a previous pr-net was deployed to consider cleaning up, but i think that all should be wrapped on the circleci job that process the cleanup.

Regarding the ref, i will remove that, i needed that when playing with my repo, let me remove all the refs and push.


feat : Create Lock.yml ✔

Related Issue
Closes #836

Description
This repository contains a workflow called lock.yml in the .github/workflows directory. The workflow is designed to reduce notifications when a maintainer adds a label and allows for conversation unlocking until it is locked again.
Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

Related Issue
Closes #836
Description
This repository contains a workflow called lock.yml in the .github/workflows directory. The workflow is designed to reduce notifications when a maintainer adds a label and allows for conversation unlocking until it is locked again.
Checklist

[x]  My code adheres to the established style guidelines of the project.
[x]  I have included comments in areas that may be difficult to understand.
[x]  My changes have not introduced any new warnings.
[x]  I have conducted a self-review of my code.

Hey @SiddhantPawar03  Please Review my Pr :)


Question: Parallelized builds across threads?

Wondering what the Webpack's stance is on multithreaded builds.

It's possible. We've wired up a build script that watches, communicates status to the main process, then restarts the dev server via spawn-rx. parallel-webpack is also a great option, but doesn't support watching because Promises are one-and-done.
The only drawback for us is that the webpack processes can't share memory, so features like css-modules will generate different module definitions for the same selectors for the client and server builds. This isn't a problem in dev mode (style-loader seems to be the way to go for hot-module-reloading, so the server-generated CSS is ignored anyway).
We run production builds (with extract-text-webpack-plugin instead of style-loader) in the same process so the style cache is shared across builds and we can afford the time.

Yeah, solutions like parallel-webpack or happypack are the way to go at the moment.
This kind of questions might fit Stack Overflow better (see the issue template disclaimer).

@bebraw my bad. Would be nice if parallelization would come built in. Are there any plans for this?

I'm not aware of any official plans at the moment. It's probably better to rely on third party for the moment.

Would a PR be welcome to add official support?

@sokra @TheLarkInn Any thoughts?

@bebraw @sokra @TheLarkInn On an unrelated note, does targeting 'node' add shims for node API's even though they are not necessary?


Added Turkish payment provides

There are merge conflicts here. Can you resubmit this with just the README.md changes please?


🔧 fix val

I got a error, and try to fix it.
Traceback (most recent call last):
  File "/Users/bohan/TmpWork/llama_index_starter_pack/flask_react/./index_server.py", line 73, in <module>
    initialize_index()
  File "/Users/bohan/TmpWork/llama_index_starter_pack/flask_react/./index_server.py", line 31, in initialize_index
    stored_docs = pkl.load(f)
NameError: name 'pkl' is not defined

@ZhangBohan good catch! I noticed this earlier today and forgot to push a fix, thanks!


Remove outdated comment

The comment applied to code removed by a1a459e9d32a45f1ca8bfbc48ed3d655cb662691.

@facebook-github-bot shipit

pushed directly.


Converting "variable scope" blocks.

It is relatively common to encounter C# code where variable scoping blocks are in use.
I recently encountered such when working on converting tests for the VB runtime:
    [Fact]
    public void Close()
    {
        var path = GetTestFilePath();
        File.WriteAllText(path, "abc123");
        // ...
        using (var parser = new TextFieldParser(path))
        {
            parser.Close();
        }
       // ...
        {
            TextFieldParser parser;
            using (parser = new TextFieldParser(path))
            {
            }
            parser.Close();
        }
    }

As you can see in the second block, the local parser variable is used "again" - but it's a new/different parser variable.
The simplest way to do something similar in VB (which I do rather regularly - unrelated to converting code) is to:
If True Then
    ' We now have a separate variable scope.
End If

So the question is can you detect these types of block and replace them with the If True Then ... End If blocks?

@DualBrain I can't detect that, the problem is the second using should just be "Using parser as new TextFieldParser(path))" and that I might be able to fix.

I fix the specific issue and other places where I should have used
Dim X As New Y

Fix in   New in <IP_ADDRESS>/<IP_ADDRESS>

You might have misunderstood what I was trying to convey.
public void SomeSuch()
{

    {
        int x = 1;
    }
    // ...
    {
        int x = 1;
    }
}

There are two different instances of x in their own individual variable scopes due to the curly brace "blocks".  In VB this can be done using:
Public Sub SomeSuch

    If True Then
        Dim x = 1
    End If
    If True Then
        Dim x = 1
    End If

 End Sub

The question I was asking was related to the curly brace sections so that they could be detected (if possible) and turned into the "do nothing" (except create variable scoping) If / End If blocks.

Also, right now... if I attempt to convert this:
Public Sub SomeSuch()
    Dim x As Integer = 1
    ' ...
     Dim x As Integer = 1
    ' ...
End Sub

Which is obviously not a valid conversion. ;-)

@DualBrain Fixed in <IP_ADDRESS>/<IP_ADDRESS>, please review

Excellent work!

@DualBrain  thanks. Very odd the original code had a test identical to your your simplified example. Which I had to fix for some reason whoever wrote original code that it was OK to define a variable twice.


Show 'Do you want to save' centered on the application window, not centered on the monitor

Currently, if you try to close an unsaved file, the dialog 'Do you want to save the changes you made' appears centered on the monitor. It would be preferable to have this dialog appear centered on the Visual Studio application window.

@Eldaw which OS?

Windows 10 x64.

Looks like native behaviour to me, Notepad is the same:


Is --max-chunk-size desired/required now that we have a new serialization format?

Now that we have a serialization format which implicitly encodes grouping of related items which need to go together, do we still need to have the --max-chunk-size flag/option?
{
   "objects":[],
   "relations":[]
},
{
   "objects":[],
   "relations":[]
},
...

We decided in Weekly Romania Sync that we will not do any chunking. The chunking code will get removed by https://github.com/aserto-dev/ds-load/pull/79


Getting warning on Chrome Console for cookie samesite

A cookie associated with a cross-site resource at http://utteranc.es/ was set without the SameSite  attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None  and Secure.  You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
@jdanyow Can you please check this issue?

Just saw the warning message gets generated only when one have visited utterances homepage as it has Google Analytics.
No warning when opened in incognito. This warning should not effect functioning of utterances.


Trying to get property of non-object

I would like to ask how this solution has been through auth, will appear the following error

line 9 in ConfigHandler.php is
return auth()->user()->id;

When multi-user mode enabled, FileManager needs to identify the user to restrict access to the owned folder.
Looks like it has failed to retrieve the user.

what was the problem. i am also getting same error . it was work fine, i think after composer update it happen

I've got the same error with laravel 5.4,
You should go to app/config/lfm and set the 'allow_multi_user' => false, .
hope it helps!


Work In Progress: Add integrity, fingerprint etc. filters for resources

Fixes #4381

I can relicense any code in https://github.com/carlmjohnson/scattered if it's useful (probably not, since it's a pretty thin wrapper around the stdlib).

@carlmjohnson thanks for the offer, but the "hard part" in all of this isn't the hashing/fingerprinting.

For people interested in this:

I have wandered into the world of CGO and created a SASS import resolver that makes it work with the fairly advanced project/theme overlay filesystem in Hugo: https://github.com/wellington/go-libsass/commit/a8861c8860b01d2656f16e870efc61f937fb9905
This shines with Hugo's very opinionated "inheritance setup". Having the SASS source live in the theme etc. and just override variable files etc. in the project.
CGO bindings ti LibSass is unfortunate, but @wellington is a very hands-on and helpful maintainer. His https://github.com/wellington/go-libsass/tree/master/libs package with bindings and bridge functions is up to date with the latest LibSass version.
I will produce a double set of binaries and will try to make sure that SASS source can be compiled and consumed by binaries not "SASS enabled". Which is probably needed for CI/docker etc.

I've been watching the commits roll in and I must say, I'm super-excited. Thank you for all the hard work @bep! I can't wait to upgrade our voter guide site.


Not working anymore

I've used the editor several times before without issue but now it seems to be not working
No matter what button I select or which save file I try to edit, the program just stalls on whatever the first step is ("Randomizing GUID",  "Turning Weapons Primordial", etc) and never moves on.
Previously, it worked as expected, now it does not. Maybe a game update changed the save files?

The API changed and I have patched the problem. Please re-open this issue if you are still experiencing problems.

Thank you! It's resolved


⚠ Bofrost.de has degraded performance

In 28d1c9a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2217 ms

Resolved: Bofrost.de performance has improved in fff3d86 after 2 hours, 52 minutes.


Release alpha version for compute to support LRO rehydration

API change check
API changes are not detected in this pull request.


Add rabbitmq

Add the rabbitmq hardened image to community images
This PR adds the coverage script, README, functional test for rabbitmq image.
Test Plan:
[x] Ran the run.sh successfully
[x] Ran the functional.sh with success
[x] Generated the README file

Please add rabbit-mq perf test

Please add rabbit-mq perf test

done


Turn on StructuredDataset

Signed-off-by: Yee Hing Tong<EMAIL_ADDRESS>TL;DR
Remove the feature gate for StructuredDataset.  This means that by default pd.DataFrame will resolve to Flyte IDL's StructuredDataset type/literal instead of FlyteSchema.
See the original PR https://github.com/flyteorg/flytekit/pull/785
Note:
If you are seeing compilation errors, please make sure you're on Propeller version v0.16.14 and Admin version v0.6.78 or later.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

@eapolinario had to fix a lint.  +1?

@eapolinario had to fix a lint.  +1?

Is paper mill broken?

@kumare3 , nbclient, one of the dependencies of the papermill plug-in is broken and it's being tracked in https://github.com/jupyter/nbclient/issues/207.


Uncaught (in promise) Error: failed to fetch: (404) Not Found, from url: http://localhost:8601/face-api.js/models/ssd_mobilenetv1_model-weights_manifest.json

Tried using Face-api.js in a web based application, For now we have the models folder in nodemodules/face-api.js/models. but we get the above error. May i know which is the right place to have the models folder?
This is the code used.
const { Canvas, Image, ImageData } = canvas
faceapi.env.monkeyPatch({ Canvas, Image, ImageData })
console.log(faceapi.nets);

(async () => {
await faceapi.nets.ssdMobilenetv1.loadFromUri('face-api.js/models');
const detections = await faceapi.detectAllFaces(this.video);
console.log("face found ");
console.log(detections);

})();
let media = navigator.mediaDevices.getUserMedia({
video: true,
audio: false
});
media.then((stream) => {
  this.video.srcObject = stream;
});

What did you figure out here @naveen-robotixedu? Dealing with a similar issue... Thanks! (I'm not using express backend)

What did you figure out here @naveen-robotixedu? Dealing with a similar issue... Thanks! (I'm not using express backend)

Created a build folder for the website and just placed the models folder in the build folder

wow you just saved my life. I was stressing the fu&^ out