Holding down multiple keys and removing the delay after holding the feed key

Hello, this is Phoenix132
I recently considered switching my client to cigar3 and so far it's going pretty well. However, I have encountered some issues in the keys for the client. Here are some issues:
When I press the 'q' key to switch control to minion, the screen blacks out and disconnects.
When I want to perform a solotrick, holding down the feed key and splitting 64x, or 128x, and feeding the majority of mass to a big cell in the front, it doesn't work. I cannot hold multiple keys at a time.
Another issue is a feed delay. I have to hold down the 'w' key to feed, and it only shoots one mass pellet at first, then after a while it continuously feeds.
Thank you for your time if you read all of this.
Please let me know how to fix these issues.
Best,
Phoenix132
Discord: Phoenix3214

Hey,
Thank you for your message.
I will try to fix those issues in the next week :)
Cheers,
Litu

Hi,
Hope the progress is going well.
I tried to fix one of the problems, and I fixed the single feed.
Best,
Phoenix

Hello,
Cigar3 now supports multikey macros. About the Q minion switch issue, i would need the server you're using to reproduce the issue you're having.
Thanks for using Cigar3,
Litu

Thank you!
Phoenix


Program filtering do not work for me

Clicking on the program should filter the log lines. It (onProgramClick ) updates the userSearchText with the following (in public/app.js):
$scope.userSearchText = config.fields.mapping['program'] + ': \'' + program + '\'';
The program value is single-quoted, with in my case does not lead to expected results (generated the following query param: q=program:%20'my-program')
Doucle-quoting the value does the trick:
$scope.userSearchText = config.fields.mapping['program'] + ': "' + program + '"';
(generating the following url query param : q=program:%20%22my-program%22)
It does not seem te be browser dependent (fyi, I test with Chrome)
Regards

Thanks fixed. Please use 1.5.0

Kibana 4.x : ./bin/kibana plugin -i logtrail -u https://github.com/sivasamyk/logtrail/releases/download/0.1.5/logtrail-4.x-0.1.5.tar.gz
Kibana 5.x : ./bin/kibana-plugin install https://github.com/sivasamyk/logtrail/releases/download/0.1.5/logtrail-5.x-0.1.5.zip


Added custom flask app wrapper to consume foca as config

Description
A number of mypy errors were coming in since foca was not included as part of the flask config but was being consumed using the current app context and otherwise too.
To fix the same, I created a custom wrapper to create a flask app with an underlying config attribute for foca. Thereby removing the mypy errors.
However it was observed that while consuming the attribute from current_app context, still mypy errors were coming.

The following resulted in attribute error from mypy

foca_conf = current_app.config.foca

But this one did not

foca_conf = current_app.app.config.foca

Further, to fix the same the following was used.
foca_conf = getattr(current_app.config, 'foca')

In addition, following are still being ignored from mypy

celery_app.py

class ContextTask(celery.Task):  # type: ignore

auth.py

try:
            claims = jwt.decode(
                jwt=token,
                verify=True,
                key=key,  # type: ignore[arg-type]
                algorithms=algorithms,
                audience=audience,
                options=validation_options,
            )

request.headers = \
        ImmutableMultiDict(req_headers)  # type: ignore[assignment]

register_access_control.py

app.add_api(
        specification=spec.path[0],  # type: ignore[index]
        **spec.dict().get("connexion", {}),
    )

Fixes #144
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have updated the documentation (or documentation does not need to be updated)
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not reduced the existing code coverage

Before reviewing: Did you check whether this solution solves the mypy issues in apps being built with FOCA when they try to access FOCA config params via current_app.config.foca.some_param or similar?

Before reviewing: Did you check whether this solution solves the mypy issues in apps being built with FOCA when they try to access FOCA config params via current_app.config.foca.some_param or similar?

I did check on the possibilities for doing this but eventually came to a conclusion that for using this we would need to alter the typed configurations in flask itself which would be a major switch.
The other way might be to create a wrapper context variable/global variable and utilise it across but that would imply changes across all foca clients.

I put this review on hold until we have discussed this on Slack given the approach I suggested.


[TEST] LoadSaveTests for Job Entries

Head build failed with return code 1

Head build failed with return code 1

Head build failed with return code 1

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnections.java
engine/src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExist.java
engine/src/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java
engine/src/org/pentaho/di/job/entries/copymoveresultfilenames/JobEntryCopyMoveResultFilenames.java
engine/src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetrics.java
engine/src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContent.java
engine/src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExist.java
engine/src/org/pentaho/di/job/entries/folderisempty/JobEntryFolderIsEmpty.java
engine/src/org/pentaho/di/job/entries/folderscompare/JobEntryFoldersCompare.java
engine/src/org/pentaho/di/job/entries/ftp/JobEntryFTP.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsTest.java
engine/test-src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/eval/JobEntryEvalLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentTest.java
engine/test-src/org/pentaho/di/job/entries/exportrepository/JobEntryExportRepositoryLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistTest.java
engine/test-src/org/pentaho/di/job/entries/ftp/JobEntryFTPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/ftpdelete/JobEntryFTPDeleteLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entry/loadSave/LoadSaveBase.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/ArrayLoadSaveValidator.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/DefaultFieldLoadSaveValidatorFactory.java
ui/src/org/pentaho/di/ui/job/entries/checkdbconnection/JobEntryCheckDbConnectionsDialog.java
ui/src/org/pentaho/di/ui/job/entries/columnsexist/JobEntryColumnsExistDialog.java
ui/src/org/pentaho/di/ui/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsDialog.java
ui/src/org/pentaho/di/ui/job/entries/evaluatetablecontent/JobEntryEvalTableContentDialog.java
ui/src/org/pentaho/di/ui/job/entries/filesexist/JobEntryFilesExistDialog.java
Still Broken Tests:
org.pentaho.di.trans.steps.rest.RestIT.testLoadSaveRoundTrip:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException

java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.rest.RestIT.tearDown(RestIT.java:157)

org.pentaho.di.trans.steps.rest.RestIT.testNoContent:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException: 11264
	at org.objectweb.asm.ClassReader.readClass(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at com.sun.jersey.spi.scanning.AnnotationScannerListener.onProcess(AnnotationScannerListener.java:136)
	at com.sun.jersey.core.spi.scanning.JarFileScanner.scan(JarFileScanner.java:97)
	at com.sun.jersey.core.spi.scanning.JarFileScanner$1.f(JarFileScanner.java:74)
	at com.sun.j

java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.rest.RestIT.tearDown(RestIT.java:157)

org.pentaho.di.trans.steps.rest.RestIT.testResponseHeader:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException

java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.rest.RestIT.tearDown(RestIT.java:157)

Unit test coverage change:
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.job.entries.checkdbconnection.JobEntryCheckDbConnections:

Branch Change :  + 20.99%
Complexity Change :  + 26.21%
Instruction Change :  + 32.51%
Line Change :  + 33.02%
Method Change :  + 48.61%

org.pentaho.di.job.entries.columnsexist.JobEntryColumnsExist:

Branch Change :  + 26.09%
Complexity Change :  + 47.83%
Instruction Change :  + 47.41%
Line Change :  + 53.28%
Method Change :  + 78.26%

org.pentaho.di.job.entries.eval.JobEntryEval:

Complexity Change :  + 58.82%
Instruction Change :  + 21.72%
Line Change :  + 30.12%
Method Change :  + 62.50%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics:

Branch Change :  + 10.89%
Complexity Change :  + 23.59%
Instruction Change :  + 39.82%
Line Change :  + 39.14%
Method Change :  + 64.52%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent:

Branch Change :  + 10.10%
Complexity Change :  + 29.04%
Instruction Change :  + 37.47%
Line Change :  + 36.64%
Method Change :  + 58.23%

org.pentaho.di.job.entries.exportrepository.JobEntryExportRepository:

Complexity Change :  + 23.53%
Instruction Change :  + 27.48%
Line Change :  + 37.02%
Method Change :  + 76.92%

org.pentaho.di.job.entries.filesexist.JobEntryFilesExist:

Branch Change :  + 28.95%
Complexity Change :  + 35.58%
Instruction Change :  + 47.36%
Line Change :  + 46.31%
Method Change :  + 51.79%

org.pentaho.di.job.entries.ftp.JobEntryFTP:

Branch Change :  + 4.00%
Complexity Change :  + 25.70%
Instruction Change :  + 37.61%
Line Change :  + 36.31%
Method Change :  + 61.80%

org.pentaho.di.job.entries.ftpdelete.JobEntryFTPDelete:

Complexity Change :  + 31.02%
Instruction Change :  + 35.87%
Line Change :  + 43.50%
Method Change :  + 82.86%

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval:

Branch Change :  + .29%
Complexity Change :  + .43%
Instruction Change :  + .07%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change : -1.64%
Complexity Change : -.69%
Instruction Change : -2.43%
Line Change : -3.70%

org.pentaho.di.trans.steps.getfilesrowscount.GetFilesRowsCountMeta:

Branch Change : -1.85%
Complexity Change : -1.30%
Instruction Change : -.40%
Line Change : -.40%

org.pentaho.di.trans.steps.ifnull.IfNullMeta:

Instruction Change : -.08%

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta:

Branch Change :  + .88%
Complexity Change :  + .93%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

Instruction Change : -.18%

Integration test coverage change:
org.pentaho.di.trans.step.BaseStep:

Branch Change : -.29%
Complexity Change : -.18%
Instruction Change : -.13%
Line Change : -.08%

License header violations:

Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnections.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExist.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java. Found 2015. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/copymoveresultfilenames/JobEntryCopyMoveResultFilenames.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetrics.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/folderisempty/JobEntryFolderIsEmpty.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/folderscompare/JobEntryFoldersCompare.java. Found 2013. Was expecting 2016
Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/ftp/JobEntryFTP.java. Found 2015. Was expecting 2016
Couldn't find acceptable copyright on engine/test-src/org/pentaho/di/job/entries/exportrepository/JobEntryExportRepositoryLoadSaveTest.java
Couldn't find acceptable license on engine/test-src/org/pentaho/di/job/entries/exportrepository/JobEntryExportRepositoryLoadSaveTest.java
Couldn't find acceptable copyright on engine/test-src/org/pentaho/di/job/entries/ftp/JobEntryFTPLoadSaveTest.java
Couldn't find acceptable license on engine/test-src/org/pentaho/di/job/entries/ftp/JobEntryFTPLoadSaveTest.java
Copyright year is not the current year on engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/ArrayLoadSaveValidator.java. Found 2015. Was expecting 2016
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/checkdbconnection/JobEntryCheckDbConnectionsDialog.java. Found 2013. Was expecting 2016
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/columnsexist/JobEntryColumnsExistDialog.java. Found 2013. Was expecting 2016
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsDialog.java. Found 2013. Was expecting 2016
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/evaluatetablecontent/JobEntryEvalTableContentDialog.java. Found 2013. Was expecting 2016
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/filesexist/JobEntryFilesExistDialog.java. Found 2013. Was expecting 2016

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/ui/src/org/pentaho/di/ui/job/entries/checkdbconnection/JobEntryCheckDbConnectionsDialog.java

Message: ':' should be on a new line. at Line: 183 Column: 54

File /home/buildguy/project/ui/src/org/pentaho/di/ui/job/entries/columnsexist/JobEntryColumnsExistDialog.java

Message: ':' should be on a new line. at Line: 273 Column: 52

File /home/buildguy/project/ui/src/org/pentaho/di/ui/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsDialog.java

Message: ':' should be on a new line. at Line: 545 Column: 59

File /home/buildguy/project/ui/src/org/pentaho/di/ui/job/entries/filesexist/JobEntryFilesExistDialog.java

Message: ':' should be on a new line. at Line: 279 Column: 52

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnections.java
engine/src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExist.java
engine/src/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java
engine/src/org/pentaho/di/job/entries/copymoveresultfilenames/JobEntryCopyMoveResultFilenames.java
engine/src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetrics.java
engine/src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContent.java
engine/src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExist.java
engine/src/org/pentaho/di/job/entries/folderisempty/JobEntryFolderIsEmpty.java
engine/src/org/pentaho/di/job/entries/folderscompare/JobEntryFoldersCompare.java
engine/src/org/pentaho/di/job/entries/ftp/JobEntryFTP.java
engine/src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGet.java
engine/src/org/pentaho/di/job/entries/getpop/JobEntryGetPOP.java
engine/src/org/pentaho/di/job/entries/sftp/JobEntrySFTP.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsTest.java
engine/test-src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/eval/JobEntryEvalLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentTest.java
engine/test-src/org/pentaho/di/job/entries/exportrepository/JobEntryExportRepositoryLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistTest.java
engine/test-src/org/pentaho/di/job/entries/ftp/JobEntryFTPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/ftpdelete/JobEntryFTPDeleteLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGetLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/getpop/JobEntryGetPOPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/sftp/JobEntrySFTPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entry/loadSave/LoadSaveBase.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/ArrayLoadSaveValidator.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/DefaultFieldLoadSaveValidatorFactory.java
ui/src/org/pentaho/di/ui/job/entries/checkdbconnection/JobEntryCheckDbConnectionsDialog.java
ui/src/org/pentaho/di/ui/job/entries/columnsexist/JobEntryColumnsExistDialog.java
ui/src/org/pentaho/di/ui/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsDialog.java
ui/src/org/pentaho/di/ui/job/entries/evaluatetablecontent/JobEntryEvalTableContentDialog.java
ui/src/org/pentaho/di/ui/job/entries/filesexist/JobEntryFilesExistDialog.java
ui/src/org/pentaho/di/ui/job/entries/ftpsget/JobEntryFTPSGetDialog.java
Still Broken Tests:
org.pentaho.di.trans.steps.rest.RestIT.testNoContent:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException: 11264
	at org.objectweb.asm.ClassReader.readClass(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at com.sun.jersey.spi.scanning.AnnotationScannerListener.onProcess(AnnotationScannerListener.java:136)
	at com.sun.jersey.core.spi.scanning.JarFileScanner.scan(JarFileScanner.java:97)
	at com.sun.jersey.core.spi.scanning.JarFileScanner$1.f(JarFileScanner.java:74)
	at com.sun.j

java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.rest.RestIT.tearDown(RestIT.java:153)

org.pentaho.di.trans.steps.rest.RestIT.testResponseHeader:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException

java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.rest.RestIT.tearDown(RestIT.java:153)

Unit test coverage change:
org.pentaho.di.job.entries.checkdbconnection.JobEntryCheckDbConnections:

Branch Change :  + 20.99%
Complexity Change :  + 26.21%
Instruction Change :  + 32.51%
Line Change :  + 33.02%
Method Change :  + 48.61%

org.pentaho.di.job.entries.columnsexist.JobEntryColumnsExist:

Branch Change :  + 26.09%
Complexity Change :  + 47.83%
Instruction Change :  + 47.41%
Line Change :  + 53.28%
Method Change :  + 78.26%

org.pentaho.di.job.entries.eval.JobEntryEval:

Complexity Change :  + 58.82%
Instruction Change :  + 21.72%
Line Change :  + 30.12%
Method Change :  + 62.50%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics:

Branch Change :  + 11.28%
Complexity Change :  + 24.10%
Instruction Change :  + 39.90%
Line Change :  + 39.14%
Method Change :  + 64.52%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent:

Branch Change :  + 10.10%
Complexity Change :  + 29.04%
Instruction Change :  + 37.47%
Line Change :  + 36.64%
Method Change :  + 58.23%

org.pentaho.di.job.entries.exportrepository.JobEntryExportRepository:

Complexity Change :  + 23.53%
Instruction Change :  + 27.48%
Line Change :  + 37.02%
Method Change :  + 76.92%

org.pentaho.di.job.entries.filesexist.JobEntryFilesExist:

Branch Change :  + 28.95%
Complexity Change :  + 35.58%
Instruction Change :  + 47.36%
Line Change :  + 46.31%
Method Change :  + 51.79%

org.pentaho.di.job.entries.ftp.JobEntryFTP:

Branch Change :  + 4.00%
Complexity Change :  + 25.70%
Instruction Change :  + 37.61%
Line Change :  + 36.31%
Method Change :  + 61.80%

org.pentaho.di.job.entries.ftpdelete.JobEntryFTPDelete:

Complexity Change :  + 31.02%
Instruction Change :  + 35.87%
Line Change :  + 43.50%
Method Change :  + 82.86%

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet:

Branch Change :  + 4.31%
Complexity Change :  + 37.25%
Instruction Change :  + 42.13%
Line Change :  + 43.11%
Method Change :  + 78.07%

org.pentaho.di.job.entries.getpop.JobEntryGetPOP:

Branch Change :  + 2.97%
Complexity Change :  + 30.23%
Instruction Change :  + 45.54%
Line Change :  + 44.04%
Method Change :  + 61.90%

org.pentaho.di.job.entries.getpop.MailConnectionMeta:

Branch Change :  + 24.00%
Complexity Change :  + 16.90%
Instruction Change :  + 16.27%
Line Change :  + 18.75%
Method Change :  + 33.33%

org.pentaho.di.job.entries.sftp.JobEntrySFTP:

Branch Change :  + 1.67%
Complexity Change :  + 41.74%
Instruction Change :  + 46.27%
Line Change :  + 51.82%
Method Change :  + 87.27%

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval:

Branch Change :  + .29%
Complexity Change :  + .43%
Instruction Change :  + .07%

org.pentaho.di.job.entries.sql.JobEntrySQL:

Instruction Change : -3.28%
Line Change : -3.87%

org.pentaho.di.trans.steps.ifnull.IfNullMeta:

Branch Change : -2.17%
Complexity Change : -1.59%
Instruction Change : -.15%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta:

Instruction Change : -.06%

org.pentaho.di.trans.steps.loadfileinput.LoadFileInputMeta:

Branch Change :  + .43%
Complexity Change :  + .52%
Instruction Change :  + .18%
Line Change :  + .20%

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta:

Branch Change :  + 3.51%
Complexity Change :  + 1.87%
Instruction Change :  + .45%
Line Change :  + .56%

org.pentaho.di.trans.Trans:

Branch Change :  + .10%
Complexity Change :  + .14%
Instruction Change :  + .09%
Line Change :  + .11%

License header violations:

Copyright year is not the current year on engine/src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGet.java. Found 2013. Was expecting 2016
Couldn't find acceptable copyright on engine/test-src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGetLoadSaveTest.java
Couldn't find acceptable license on engine/test-src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGetLoadSaveTest.java
Copyright year is not the current year on ui/src/org/pentaho/di/ui/job/entries/ftpsget/JobEntryFTPSGetDialog.java. Found 2013. Was expecting 2016

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/engine/src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGet.java

Message: 'for' is not followed by whitespace. at Line: 707 Column: 8

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f ui/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnections.java
engine/src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExist.java
engine/src/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java
engine/src/org/pentaho/di/job/entries/copymoveresultfilenames/JobEntryCopyMoveResultFilenames.java
engine/src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetrics.java
engine/src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContent.java
engine/src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExist.java
engine/src/org/pentaho/di/job/entries/folderisempty/JobEntryFolderIsEmpty.java
engine/src/org/pentaho/di/job/entries/folderscompare/JobEntryFoldersCompare.java
engine/src/org/pentaho/di/job/entries/ftp/JobEntryFTP.java
engine/src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGet.java
engine/src/org/pentaho/di/job/entries/getpop/JobEntryGetPOP.java
engine/src/org/pentaho/di/job/entries/pgpdecryptfiles/JobEntryPGPDecryptFiles.java
engine/src/org/pentaho/di/job/entries/pgpencryptfiles/JobEntryPGPEncryptFiles.java
engine/src/org/pentaho/di/job/entries/setvariables/JobEntrySetVariables.java
engine/src/org/pentaho/di/job/entries/sftp/JobEntrySFTP.java
engine/src/org/pentaho/di/job/entries/shell/JobEntryShell.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/checkdbconnection/JobEntryCheckDbConnectionsTest.java
engine/test-src/org/pentaho/di/job/entries/columnsexist/JobEntryColumnsExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/eval/JobEntryEvalLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/evaluatetablecontent/JobEntryEvalTableContentTest.java
engine/test-src/org/pentaho/di/job/entries/exportrepository/JobEntryExportRepositoryLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/filesexist/JobEntryFilesExistTest.java
engine/test-src/org/pentaho/di/job/entries/ftp/JobEntryFTPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/ftpdelete/JobEntryFTPDeleteLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/ftpsget/JobEntryFTPSGetLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/getpop/JobEntryGetPOPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/mssqlbulkload/JobEntryMssqlBulkLoadLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/mysqlbulkfile/JobEntryMysqlBulkFileLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/mysqlbulkload/JobEntryMysqlBulkLoadLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/pgpdecryptfiles/JobEntryPGPDecryptFilesLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/pgpencryptfiles/JobEntryPGPEncryptFilesLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/setvariables/JobEntrySetVariablesLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/sftp/JobEntrySFTPLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/sftpput/JobEntrySFTPPUTLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/shell/JobEntryShellLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/special/JobEntrySpecialLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/tableexists/JobEntryTableExistsLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/trans/JobEntryTransLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/truncatetables/JobEntryTruncateTablesLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entries/waitforsql/JobEntryWaitForSQLLoadSaveTest.java
engine/test-src/org/pentaho/di/job/entry/loadSave/LoadSaveBase.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/ArrayLoadSaveValidator.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/DefaultFieldLoadSaveValidatorFactory.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/validator/EnumLoadSaveValidator.java
ui/src/org/pentaho/di/ui/job/entries/checkdbconnection/JobEntryCheckDbConnectionsDialog.java
ui/src/org/pentaho/di/ui/job/entries/columnsexist/JobEntryColumnsExistDialog.java
ui/src/org/pentaho/di/ui/job/entries/evalfilesmetrics/JobEntryEvalFilesMetricsDialog.java
ui/src/org/pentaho/di/ui/job/entries/evaluatetablecontent/JobEntryEvalTableContentDialog.java
ui/src/org/pentaho/di/ui/job/entries/filesexist/JobEntryFilesExistDialog.java
ui/src/org/pentaho/di/ui/job/entries/ftpsget/JobEntryFTPSGetDialog.java
Newly Broken Tests:
org.pentaho.di.job.entries.trans.JobEntryTransLoadSaveTest.testSerialization:
junit.framework.AssertionFailedError
junit.framework.AssertionFailedError:
	at org.pentaho.di.job.entry.loadSave.JobEntryLoadSaveTestSupport.setUp(JobEntryLoadSaveTestSupport.java:64)

Still Broken Tests:
org.pentaho.di.trans.steps.rest.RestIT.testNoContent:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException: 11264
	at org.objectweb.asm.ClassReader.readClass(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at org.objectweb.asm.ClassReader.accept(Unknown Source)
	at com.sun.jersey.spi.scanning.AnnotationScannerListener.onProcess(AnnotationScannerListener.java:136)
	at com.sun.jersey.core.spi.scanning.JarFileScanner.scan(JarFileScanner.java:97)
	at com.sun.jersey.core.spi.scanning.JarFileScanner$1.f(JarFileScanner.java:74)
	at com.sun.j

org.pentaho.di.trans.steps.rest.RestIT.testResponseHeader:
java.lang.ArrayIndexOutOfBoundsException
java.lang.ArrayIndexOutOfBoundsException

Unit test coverage change:
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.job.entries.checkdbconnection.JobEntryCheckDbConnections:

Branch Change :  + 20.99%
Complexity Change :  + 26.21%
Instruction Change :  + 32.51%
Line Change :  + 33.02%
Method Change :  + 48.61%

org.pentaho.di.job.entries.columnsexist.JobEntryColumnsExist:

Branch Change :  + 26.09%
Complexity Change :  + 47.83%
Instruction Change :  + 47.41%
Line Change :  + 53.28%
Method Change :  + 78.26%

org.pentaho.di.job.entries.eval.JobEntryEval:

Complexity Change :  + 58.82%
Instruction Change :  + 21.72%
Line Change :  + 30.12%
Method Change :  + 62.50%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics:

Branch Change :  + 11.28%
Complexity Change :  + 24.10%
Instruction Change :  + 39.90%
Line Change :  + 39.14%
Method Change :  + 64.52%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent:

Branch Change :  + 9.09%
Complexity Change :  + 27.98%
Instruction Change :  + 37.30%
Line Change :  + 36.64%
Method Change :  + 58.23%

org.pentaho.di.job.entries.exportrepository.JobEntryExportRepository:

Complexity Change :  + 23.53%
Instruction Change :  + 27.48%
Line Change :  + 37.02%
Method Change :  + 76.92%

org.pentaho.di.job.entries.filesexist.JobEntryFilesExist:

Branch Change :  + 28.95%
Complexity Change :  + 35.58%
Instruction Change :  + 47.36%
Line Change :  + 46.31%
Method Change :  + 51.79%

org.pentaho.di.job.entries.ftp.JobEntryFTP:

Branch Change :  + 4.00%
Complexity Change :  + 25.70%
Instruction Change :  + 37.61%
Line Change :  + 36.31%
Method Change :  + 61.80%

org.pentaho.di.job.entries.ftpdelete.JobEntryFTPDelete:

Complexity Change :  + 31.02%
Instruction Change :  + 35.87%
Line Change :  + 43.50%
Method Change :  + 82.86%

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet:

Branch Change :  + 4.31%
Complexity Change :  + 37.25%
Instruction Change :  + 42.13%
Line Change :  + 43.11%
Method Change :  + 78.07%

org.pentaho.di.job.entries.getpop.JobEntryGetPOP:

Branch Change :  + 2.97%
Complexity Change :  + 30.23%
Instruction Change :  + 45.54%
Line Change :  + 44.04%
Method Change :  + 61.90%

org.pentaho.di.job.entries.getpop.MailConnectionMeta:

Branch Change :  + 23.00%
Complexity Change :  + 15.49%
Instruction Change :  + 15.98%
Line Change :  + 18.75%
Method Change :  + 33.33%

org.pentaho.di.job.entries.mssqlbulkload.JobEntryMssqlBulkLoad:

Branch Change :  + .89%
Complexity Change :  + 48.80%
Instruction Change :  + 50.72%
Line Change :  + 55.21%
Method Change :  + 88.41%

org.pentaho.di.job.entries.mysqlbulkfile.JobEntryMysqlBulkFile:

Branch Change :  + 1.56%
Complexity Change :  + 42.86%
Instruction Change :  + 43.16%
Line Change :  + 47.71%
Method Change :  + 73.33%

org.pentaho.di.job.entries.mysqlbulkload.JobEntryMysqlBulkLoad:

Branch Change :  + 1.47%
Complexity Change :  + 44.05%
Instruction Change :  + 45.27%
Line Change :  + 48.57%
Method Change :  + 74.00%

org.pentaho.di.job.entries.pgpdecryptfiles.JobEntryPGPDecryptFiles:

Branch Change :  + 2.81%
Complexity Change :  + 19.85%
Instruction Change :  + 32.65%
Line Change :  + 36.26%
Method Change :  + 72.73%

org.pentaho.di.job.entries.pgpencryptfiles.JobEntryPGPEncryptFiles:

Branch Change :  + 4.06%
Complexity Change :  + 20.14%
Instruction Change :  + 34.34%
Line Change :  + 37.07%
Method Change :  + 71.23%

org.pentaho.di.job.entries.setvariables.JobEntrySetVariables:

Branch Change :  + 23.73%
Complexity Change :  + 32.76%
Instruction Change :  + 40.77%
Line Change :  + 39.20%
Method Change :  + 51.85%

org.pentaho.di.job.entries.sftp.JobEntrySFTP:

Branch Change :  + 1.67%
Complexity Change :  + 41.74%
Instruction Change :  + 46.27%
Line Change :  + 51.82%
Method Change :  + 87.27%

org.pentaho.di.job.entries.sftpput.JobEntrySFTPPUT:

Branch Change :  + 4.62%
Complexity Change :  + 39.07%
Instruction Change :  + 48.11%
Line Change :  + 50.22%
Method Change :  + 90.62%

org.pentaho.di.job.entries.shell.JobEntryShell:

Branch Change :  + 9.15%
Complexity Change :  + 19.07%
Instruction Change :  + 31.54%
Line Change :  + 31.56%
Method Change :  + 56.88%

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval:

Branch Change :  + .29%
Complexity Change :  + .43%
Instruction Change :  + .07%

org.pentaho.di.job.entries.special.JobEntrySpecial:

Complexity Change :  + 48.08%
Instruction Change :  + 54.55%
Line Change :  + 48.52%
Method Change :  + 69.44%

org.pentaho.di.job.entries.tableexists.JobEntryTableExists:

Branch Change :  + 4.55%
Complexity Change :  + 48.39%
Instruction Change :  + 39.41%
Line Change :  + 47.31%
Method Change :  + 75.00%

org.pentaho.di.job.entries.truncatetables.JobEntryTruncateTables:

Branch Change :  + 14.63%
Complexity Change :  + 26.23%
Instruction Change :  + 37.72%
Line Change :  + 40.00%
Method Change :  + 60.00%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL:

Branch Change :  + 6.71%
Complexity Change :  + 20.75%
Instruction Change :  + 43.22%
Line Change :  + 42.27%
Method Change :  + 72.41%

org.pentaho.di.job.entry.JobEntryBase:

Complexity Change :  + .73%
Instruction Change :  + 1.42%
Line Change :  + 1.82%
Method Change :  + .80%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change : -1.64%
Complexity Change : -.69%
Instruction Change : -2.43%
Line Change : -3.70%

org.pentaho.di.trans.steps.ifnull.IfNullMeta:

Branch Change :  + 2.38%
Complexity Change :  + 1.64%
Instruction Change :  + .25%

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta:

Branch Change : -1.75%
Complexity Change : -.93%
Instruction Change : -.23%
Line Change : -.28%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta:

Branch Change : -.53%

org.pentaho.di.trans.Trans:

Branch Change :  + .10%
Complexity Change :  + .14%
Instruction Change :  + .09%
Line Change :  + .11%


Python helper intermittent high cpu usage

Issue Type: Performance Issue
I keep seeing very high CPU usage by VSCode helper and child python processes of VSCode Helper. Of course, once I started writing up this issue, the processes ended 😕. From the Process Explorer, it looked like the python completion process was at fault. Sometimes Activity Monitor says there are multiple VSCode based processes using high CPU usage, but I haven't had a chance to catch those with the ProcessExplorer.
I'm not sure what causes this, since it doesn't always occur right at start up. I haven't been able to tie it to any particular file, though I have been working on the same few. It seems to be able to occur multiple times in a session. I'm not sure if this is only when I force the process to end.
Extension version: 2019.6.24221
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
5, 5, 4

Memory (System)
16.00GB (0.60GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   22	    98	 25900	code main
    6	    66	 25902	   gpu-process
    0	   180	 25905	   window (_combat.py — scanpy)
    0	   115	 25952	     extensionHost
    0	    33	 25976	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/jsonServerMain --node-ipc --clientProcessId=25952
    0	    66	 26002	       electron_node server.js
    0	    49	 26070	       /usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python completion.py
    0	    16	 26074	         /usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python lib/python/jedi/evaluate/compiled/subprocess/__main__.py lib/python
    0	    49	 26578	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/html-language-features/server/dist/htmlServerMain --node-ipc --clientProcessId=25952
    0	    33	 25953	     watcherService
   10	    98	 25958	   shared-process
    0	     0	 29730	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	   246	 27951	   window (test_deprecations.py — anndata)
    0	   360	 27952	     extensionHost
    0	   229	 27961	       electron_node server.js
   98	   393	 28027	       /usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python completion.py
    3	    82	 28032	         /usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python lib/python/jedi/evaluate/compiled/subprocess/__main__.py lib/python
    0	    66	 28325	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/html-language-features/server/dist/htmlServerMain --node-ipc --clientProcessId=27952
    0	    33	 27953	     watcherService
    0	    33	 27955	     searchService
    2	    66	 29632	   window (Process Explorer)
    5	    82	 29709	   window (Issue Reporter)

Workspace Info
|  Window (test_deprecations.py — anndata)
|  Window (_combat.py — scanpy)
|    Folder (anndata): 961 files
|      File types: txt(110) rst(105) html(105) doctree(102) pyc(76) py(37)
|                  0(23) ipynb(22) 1(20) h5ad(18)
|      Conf files: settings.json(1) makefile(1)
|    Folder (scanpy): 2532 files
|      File types: txt(975) pyc(246) html(235) rst(234) doctree(232) png(215)
|                  py(118) nbc(55) nbi(32) ipynb(28)
|      Conf files: launch.json(1) settings.json(1) makefile(1)
|      Launch Configs: python(6);

Most like related to #5596

I've switched over to MS language server, but I think I'll have to use it for a bit longer to tell if this solves everything. My current impression is cpu usage is more predictable with the MS server. However, high CPU usage was intermittent with Jedi so I don't think I can say for sure that the issue is gone.
The MS server definitely has much higher CPU usage on startup and higher memory usage, but the outline now always works – which is nice.

Sounds good.  Please let us know if you notice the problem while using the language server.

I have intermittent terrible cpu consumption (209.6%) and >1GB ram consumed by version 0.3.40 of the python language server.
The language server is a serious problem in the last month but it made vsc unusable in the last few days, with peaks when editing code (you can imagine this makes the coding experience a nightmare).
What version is the one considered fixed?

@uriva, this issue is about Jedi.  Please create a new bug report.  Thanks!

Just reporting back, I've started to hit some rough performance issues with the microsoft language server (https://github.com/microsoft/python-language-server/issues/1401 and https://github.com/microsoft/python-language-server/issues/1298) and was thinking I'd come back to jedi while those get resolved.
Any chance you have reason to believe this might be fixed? I saw there was an update to jedi which got me hopeful.


[W5.7][T09-4]Tang Yurou

Ready for review

Interesting way to find the phone number of a person. Perhaps you can do for other details of a person like email.


KAFKA-13348: Allow Source Tasks to Handle Producer Exceptions

This change allows Source Connectors the option to set "error.tolerance" to "all" to allow them to handle/ignore producer exceptions. In the event the producer cannot write to Kafka, the connector commitRecord() callback is invoked with null RecordMetadata. This is new behavior for the errors.tolerance setting. Default behavior is still to kill the task unconditionally if errors.tolerance is "none".
A unit test has been added to validate the producer callback for failure being invoked. The sourceTask will ignore the exception and the task will not be killed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Unrelated tests locally and in jenkins appear flaky. All tests related to this change pass deterministically.

Rebased, squashed, and force pushed for merging post KIP vote. Tests related to this change pass locally. There are a handful of unrelated nondeterministic test failures.

Thanks @TheKnowles for the PR. I've made a first pass and left a few comments.

@mimaison Thank you for reviewing. I've replied to each comment above and pushed changes.

Happy to squash and force push once everyone is pleased with the changes.

@TheKnowles Don't worry about squashing everything, it's done automatically when we merge PRs.
Thanks for the quick update, I'll take another look.

@C0urante Do you have further comments or just I merged?

Thanks @TheKnowles for this contribution! Sorry it took so long between getting votes on the KIP and reviews on your PR. This feature will be in the next minor release, Kafka 3.2.0.


chore: include pse cdn in benchmark

run benchmark with ./scripts/bin/benchmark.bash
My results, done with a rather bad connection (10 Mbps, VPN on, location eu/west):
download time average (s)
  unpkg    136
  jsdelivr 328.8
  github   142.7
  pse      406.4

another run:
download time average (s)
  unpkg    168.8
  jsdelivr 417.9
  github   166.6
  pse      449.9

@cedoor my benchmark results on the pse cdn aren't good: it is slower than the public cdns.
Do you mind running the benchmark too so we can compare results?

Other run, a bit better:
download time average (s)
  unpkg    128.5
  jsdelivr 369.2
  github   121.9
  pse      348.6

but we are still far from the speed of unpkg or github

AFAICS, the CloudFront times are pretty much okay:
download time average (s)
  unpkg    14.2
  jsdelivr 172.4
  github   109.2
  pse      91.7

It also seems that unpkg.com doesn't download the files (probably because they are not there?), which is why the download time seems to be that fast :D
root@t:~/test# curl -v -o /dev/null 'https://unpkg.com/<EMAIL_ADDRESS>  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 2606:4700::6811:f5cb:443...
* TCP_NODELAY set
* Connected to unpkg.com (2606:4700::6811:f5cb) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
{ [19 bytes data]
* TLSv1.3 (IN), TLS handshake, Certificate (11):
{ [4212 bytes data]
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
{ [264 bytes data]
* TLSv1.3 (IN), TLS handshake, Finished (20):
{ [52 bytes data]
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.3 (OUT), TLS handshake, Finished (20):
} [52 bytes data]
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=unpkg.com
*  start date: May 30 03:44:12 2024 GMT
*  expire date: Aug 28 03:44:11 2024 GMT
*  subjectAltName: host "unpkg.com" matched cert's "unpkg.com"
*  issuer: C=US; O=Google Trust Services LLC; CN=GTS CA 1P5
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
} [5 bytes data]
* Using Stream ID: 1 (easy handle 0x5600fe2d7650)
} [5 bytes data]
> GET /<EMAIL_ADDRESS>HTTP/2
> Host: unpkg.com
> user-agent: curl/7.68.0
> accept: */*
>
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [230 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [230 bytes data]
* old SSL session ID is stale, removing
{ [5 bytes data]
* Connection state changed (MAX_CONCURRENT_STREAMS == 100)!
} [5 bytes data]
< HTTP/2 302
< date: Fri, 21 Jun 2024 08:43:48 GMT
< content-type: text/plain; charset=utf-8
< access-control-allow-origin: *
< cache-control: public, s-maxage=600, max-age=60
< location: /<EMAIL_ADDRESS>< vary: Accept
< via: 1.1 fly.io
< fly-request-id: 01J0WZC2PJH3X6PAJYP5F1VX7G-ist
< cf-cache-status: HIT
< age: 83
< strict-transport-security: max-age=31536000; includeSubDomains; preload
< x-content-type-options: nosniff
< server: cloudflare
< cf-ray: 8972b689ec323dbe-SOF
<
{ [5 bytes data]
100    78    0    78    0     0    534      0 --:--:-- --:--:-- --:--:--   534
* Connection #0 to host unpkg.com left intact
root@t:~/test#

This is a more realistic scenario, running the script using -L in curl:
download time average (s)
  unpkg    1059.8
  jsdelivr 229.7
  github   278.7
  pse      106.1

This is a more realistic result, running the script using -L arg in curl:
download time average (s)
  unpkg    1059.8
  jsdelivr 229.7
  github   278.7
  pse      106.1

OMG more than 15min for unpkg.com. That's terrible!


Invalid Maven Identifiers in Reports

Reporting Bugs/Errors
The XML report contains an identifiers node. For Maven dependencies, a Maven identifier is generated. In some cases, the identifier generated violates the Maven specification.
Example
The following dependency will create an invalid Maven identifier in the resulting XML report.
<dependency>
    <groupId>org.fusesource.jansi</groupId>
    <artifactId>jansi-linux64</artifactId>
    <version>1.7</version>
</dependency>

This dependency will create the following Maven identifiers:
<identifier type="maven" confidence="HIGH">
    <name>org.fusesource.jansi:jansi-${platform}:1.7</name>
</identifier>
<identifier type="maven" confidence="HIGHEST">
    <name>org.fusesource.jansi:jansi-linux64:1.7</name>
</identifier>

The first identifier (confidence HIGH) contains characters not allowed in Maven groupId or artifactId fields. As of Maven 2 (possibly earlier), the groupId and artifactId must match the following regex:
[A-Za-z0-9_\\-.]+
Source:
https://github.com/apache/maven/blob/master/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java#L76
POM To Reproduce:
pom.xml.zip

Thanks - looks like we have to extend string interpolation to more fields when parsing the pom entries.


[AVM Question/Feedback]: Inconsistent outputs

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Why do all three outputs (name, resource & workspace_id) all return the same thing (the LAW resource), which does not seem to align with the spec (https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-rmfr7---category-outputs---minimum-required-outputs)?
Can I suggest the following?
output "name" {
  description = "The Name of the Log Analytics Workspace."
  value       = azurerm_log_analytics_workspace.this.name
}

output "resource" {
  description = "The Log Analytics Workspace resource"
  value       = azurerm_log_analytics_workspace.this
}

output "resource_id" {
  description = "The Resource ID of the Log Analytics Workspace."
  value       = azurerm_log_analytics_workspace.this.id
}

I'm not sure workspace_id is really needed, given you could get that from the "resource" output.

fixed in latest pr


urbit.org/stream fails to load, syntax error

[let me know if this should be in the urbit/urbit issues and I'll move it there]
When I navigate to https://urbit.org/stream (google chrome, ubuntu 16.04) the initial page load finishes, but no talk messages appear and the loading icon spins indefinitely.
In the JS console, I see the following messages:
main.js:1633 listen station
main.js:1634 (2) ["home", "~2017.8.8..23.37.00..0000", callee: function, Symbol(Symbol.iterator): function]
Symbol(Symbol.iterator): function values()__proto__: Object
VM343:1 Uncaught SyntaxError: Unexpected number in JSON at position 1
    at JSON.parse (<anonymous>)
    at Object.urb.getXHRWasp ((index):40)
    at XMLHttpRequest.urb.waspLoadedXHR ((index):35)
urb.getXHRWasp @ (index):40
urb.waspLoadedXHR @ (index):35

Then I start seeing 504 errors coming in every minute or so, but no repeats of the error logs. Here's one of the 504s:
0v1.98p7i.o64rq.f2hm5.57pc2.tl4l3.js:19 GET https://urbit.org/~/on.json?0v1.98p7i.o64rq.f2hm5.57pc2.tl4l3&0v4.sbr5s.p3k…7q.8gurp&0v5.9gg1r.q4inh.baa4d.u4v09.e69fk&0vs6dtl.hjbl5.aj4ti.k2eaa.q2tle 504 ()

I just kicked one of our caching processes, although it loaded for me before doing that.
There could be something wrong with the ship serving urbit.org.  Do you have trouble in incognito mode?

The ~/on is a red herring, that's just the maybe-update-page long poll
timing out
The syntax error looks like json got returned not wrapped in an
array/object; does the Network tab have a copy of the full response?
On Wednesday, 9 August 2017, Galen Wolfe-Pauly<EMAIL_ADDRESS>wrote:

I just kicked one of our caching processes, although it loaded for me
before doing that.
There could be something wrong with the ship serving urbit.org. Do you
have trouble in incognito mode?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/419#issuecomment-321414498, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABxXhukWbp3jtSe-0kgg1iaV5VeYyrXdks5sWknUgaJpZM4Oyx6k
.

…and the parsing was a CloudFlare misconfiguration, fixed. Do the messages
still fail to load?
On Wednesday, 9 August 2017, Anton Dyudin<EMAIL_ADDRESS>wrote:

The ~/on is a red herring, that's just the maybe-update-page long poll
timing out
The syntax error looks like json got returned not wrapped in an
array/object; does the Network tab have a copy of the full response?
On Wednesday, 9 August 2017, Galen Wolfe-Pauly<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

I just kicked one of our caching processes, although it loaded for me
before doing that.
There could be something wrong with the ship serving urbit.org. Do you
have trouble in incognito mode?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/419#issuecomment-321414498, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABxXhukWbp3jtSe-0kgg1iaV5VeYyrXdks5sWknUgaJpZM4Oyx6k
.

It's fixed for me when I load it now. I had closed the page, so unfortunately the Network tab from the failed load is no longer available to me.

Yeah I tracked down that particular error, it was unrelated to talk :3
On Wednesday, 9 August 2017, Ted Blackman<EMAIL_ADDRESS>wrote:

It's fixed for me when I load it now. I had closed the page, so
unfortunately the Network tab from the failed load is no longer available
to me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/419#issuecomment-321421003, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABxXhm_86vCl9w4XFiqkcbWi8bQHgcU9ks5sWlWagaJpZM4Oyx6k
.

:+1:


Creating multiple shoot clusters results in EIP being transferred from one cluster to another

How to categorize this issue?

/area networking
/kind bug
/priority normal
/platform equinix-metal
What happened:
When creating 2nd or more shoot cluster, EIPs assigned to first cluster gets re-assigned to new cluster, as currently CCM (v2.0.0) does not tag them uniquely with cluster ID.
What you expected to happen:
After creating 2nd shoot cluster all shoots remain functional.
How to reproduce it (as minimally and precisely as possible):

Create 1st shoot, wait for it to converge.
Create 2nd shoot, watch the world burn.

Anything else we need to know?:
Recently released CCM v3.0.0 tags EIPs with cluster ID, which should effectively fix this.
Environment:

Gardener version (if relevant):
Extension version:
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

I found this 2 issues while trying to update CCM in #113:

https://github.com/equinix/cloud-provider-equinix-metal/issues/140
https://github.com/gardener/gardener-resource-manager/issues/107

Since they bring regression to the project (with updated CCM even one Shoots becomes unstable), I think we should wait until we have workarounds for those issues.


Using SoftDeletes breaks casts() arrayshape return type.

Larastan Version: >=2.9.9
Laravel Version: 11.30.0

Description
Since upgrading to 2.9.9, using SoftDeletes in a model will break the casts() arrayshape return type. This is present in using the latest 2.x branch as well.
Laravel code where the issue was found
The code below is a little silly (changing password to a Role enum?!) but is purely for example purposes for use in a fresh Laravel project. The testIt function is where the issue rears its head: Larastan won't allow setting a string column to an enum because it no longer knows about the cast).

In 2.9.8, this passes.
In 2.9.9, you get: larastan-test/app/Models/User.php:33:Property App\Models\User::$password (string) does not accept App\Models\Role::Admin.
In 2.9.9, it passes if you remove the use SoftDeletes.

<?php

namespace App\Models;

use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Database\Eloquent\SoftDeletes;

enum Role: string {
    case Admin = 'admin';
    case User = 'user';
}

class User extends Authenticatable
{
    use SoftDeletes;

    /**
     * Get the attributes that should be cast.
     *
     * @return array{
     * 'password': 'App\\Models\\Role'
     * }
     */
    protected function casts(): array
    {
        return [
            'password' => Role::class,
        ];
    }

    protected function testIt(): void
    {
        $this->password = Role::Admin;
    }
}

I'll look into this later if I have time, but for now I thought I would simply report the issue in case someone here has a faster thought about the underlying cause. 😄

This has nothing to do with SoftDeletes, your casts method should look like (note the double \\):
    /**
     * @return array{
     *     'password': 'App\\Models\\Role'
     * }
     */
    protected function casts(): array
    {
        return [
            'password' => Role::class,
        ];
    }

Are you sure? Single slashes were working for me prior to 2.9.9, and with escaping the slashes I get this error instead (on both 2.9.8 and >=2.9.9):
larastan-test/app/Models/User.php:24:Method App\Models\User::casts() should return array{password: 'App\\\\Models\\\\Role'} but returns array{password: 'App\\Models\\Role'}.

That's how it is in the test:
https://github.com/larastan/larastan/blob/54eccd35d1732b9ee4392c25aec606a6a9c521e7/tests/Type/data/model-properties-l11.php#L22-L25


Properly pass context to input filter

Hi,
I was quite surprised to see this bug. Basically, the "isValid" method of input filter did not allow to pass any context, which in hence could not be transfered to various validators, that made it impossible to use some validators that relied on context.
The problem is that input filter actually considered the whole array data as context, and pass it to various inputs.
To avoid any BC, I just checked if a context was explicitly given in the input filter. If that's the case, this context is preferred over the data as array.
Thanks!

@bakura10 maybe similar thing should be added into forms ant fieldsets?


epiphany: TLS/SSL support

Issue description
I installed Epiphany on NixOS with XFCE but can't load pages with TLS encryption.
Steps to reproduce

install epiphany on this configuration
open a random website with TLS, for example https://nixos.org/
get TLS/SSL support not available; install glib-networking.
just installing gnome3.glib_networking doesn't help, it schould be a dependencie of epiphany

Technical details

System: NixOS 16.09pre87354.d217279 (Flounder)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: "16.09pre87354.d217279" (nixos-unstable)

xfce4-screenshooter has the same problem when uploading images, but only shows the error if built with debug enabled

is glib_networking a dependencies of both? Usually GIO_EXTRA_MODULES are picked up by wrapGAppsHook

Fixed in #19433.


⚠ Bofrost.at has degraded performance

In ea027ce, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1691 ms

Resolved: Bofrost.at performance has improved in 4bcd3bc after 6 minutes.


Ben/lmb 512 titelvoerend vs verhinderd status

Description
The mandataris status verhinderd is only available for not burgemeesters and the status titelvoerend is only available for burgemeesters.
How to test
Every place a mandataris status code selector is used, it should only be possible to select a status that is valid with the selected mandate. This can be done in the form for creating a new mandataris or in the form for updating the status of a mandataris.
Also if you update the status of a burgemeester to titelvoerend, this should also activate the possibility to add a replacement.

OKidoki ✅
Should we create a migration to change the verhinderd statusses of a Burgemeesters to be titelvoerend?

Good catch, I'll reopen the story and do that.


Empty inputs

Hey @suessflorian, thanks for the tool.
I fetched schema and found that all inputs are empty, no fields specified
input UpdateWorkTemplateInput {
}

If I want to use schema for genqlient I need inputs, so genclient can generate proper code.

Good find, I'll give a shot at writing some tests too.

Update: I've got a reproducible example via graph-gophers, so we're good, just looks like there are a couple ways a server can return input fields.


Several updates to the WG list on the website

Updated the names of several WGs that have changed and added the Data Science and UN SDG WGs.

LGTM! Going to merge this.


Different music on the week selected

Describe your problem here.
I need to know how people do it Like in Fnf HD if je selected a different week a different music will play how do you do that in psych engine????
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

https://github.com/Smokey555/FNF-HD-Open-Source/blob/main/source/StoryMenuState.hx


Can someone port this to the PHP?

Hello, This is not an issue but a suggestion to make. Can someone port this compiler to the PHP language? PHP language still remains the most widely used in web servers. I would appreciate this very much. Best regards.

No. The compiler is written in TypeScript.

You might be able to use the V8js extension to run the compiler.

ok! thank you sandersn. Another question. If i wish, can i make a compiler, on my own, written in PHP? Does the licence allow this?

The language and the tools are all open source. you can find the language spec at: https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md

TypeScript is a Typed superset of JavaScript.
In a similar vein Hack is a typed superset of PHP by facebook that you might find interesting :rose:


Theme color is messed up

VSCode Version: Version 1.5.3 (1.5.3)
OS Version: macOS Sierra Version 10.12 (16A323)

I'm using Monokai on screenshot but the problem exists on every theme.

See #12473.

Temporary solution
/Applications/Visual\ Studio\ Code.app/Contents/MacOS/Electron --force-gpu-rasterization

Thanks @mrmlnc


BUG: Comments for Book PDF (lecture-source-py)

[ ] figures are numbered and the label is the path to the static file

[ ] missing unicode characters in code blocks. Need to document the necessary LaTeX required to support these characters in verbatim or listings

[ ] a number of individual tex files contain references that are not unique in the book context

\hypertarget{index-1}{}

[ ] in about_python there is a missing image from the networkx example

[ ]  creating a config variable to name the generated book pdf


Antoshkka/chanelz clenup

Merged in https://github.com/userver-framework/userver/commit/6605d615f4a8f0d32fab7647fe1fee0d787f5802


FCSWatch Hook Documentation

I saw here that FCSWatch is supposed to support web hooks now, and sends over the compilation results.
Is this true? If so, what is the syntax for using this? Documentation would be very helpful, thanks, great job on FCSWatch. 💯

Thanks.
I will read that thread and answer you

FcsWatch.Core
The core library (Include a lots of common logic
e.g project cracker, file watcher, mailbox group for concurrrent, and so on )
FcsWatch.Binary (Ref FcsWatch.Core)
It compile fsharp codes to .dll and .pdb (binary)
No webhoook currrently supported
Because it stop the whole application and replace the .dll and .pdb (This will make application debuggable and cross-projects cracking?)
FcsWatch-Porta (Ref FcsWatch.Core)
It is  ported from (FSharp.Compiler.PortaCode)[https://github.com/fsprojects/FSharp.Compiler.PortaCode]

Ah okay, I was hoping FcsWatch.Binary would support webhooks.
In my case I'm trying to implement a stateful-hot reload and wanting to use FCSWatch to watch and compile the files quickly. I currently set up a watch on the resulting binary directory to manually send over the files. A webhook however, would probably be more convenient as sometimes I get Bad IL Format exceptions with my current method.

What's the meaning of stateful-hot
On watcher side or Program side?
Are you trying somthing like time-level debugging?

On the program side I'm going to keep the program in its current state. In this case it is Elmish and I will be maintaining the model on update.
FCSWatch works great on Bolero, but I'm hoping for a live-reload, rather than having to refresh the page. What I'm lacking is a good hook or way to monitor when the updated dlls are ready to read and send over.

I get your point, And will try to fix it

Thanks, looking forward to it, this tool is very useful.

May be fixed,
Please try with 0.7.3

Doc also has been updated

Awesome, that was an extremely fast turn around.
Just to be clear, the webhook for dlls then only indicate when the job is done, and does not send the files?
That's perfect for my use case, just want to confirm.
Thanks so much 👍

FcsWatch.Binary will try to rerun the program,
Which means it will stop host program first,
A stopped program may not be able to receive the webhook

Yes, this makes sense, is there now a webhook for binary though?
And the webhook indicates when the compilation has finished?

And the webhook indicates when the compilation has finished?

Yes, Only send a webhook to indicates when the compilation has finished(rerun or run)

Perfect, thank you so much 👍

One additional thought, as a further improvement.
In addition to sending whether this is a "Run" or "Rerun" just sending the names of the files could prove useful.
Very excited to start using this.

OK... will try to fix it next time.
You can also send a Pull request

https://github.com/humhei/FCSWatch/blob/master/src/FcsWatch.Binary/AutoReload.fs#L19
[<RequireQualifiedAccess>]
type WhyRun =
    | Rerun
    | Run

to
[<RequireQualifiedAccess>]
type WhyRun =
    | Rerun of fileChanges of string list
    | Run

Yes, I will explore this further and open a PR, thank you.

https://github.com/humhei/FCSWatch/blob/master/src/FcsWatch.Core/Types.fs#L557
[<RequireQualifiedAccess>]
type WhyCompile =
    | WarmCompile
    | DetectFileChange

to
[<RequireQualifiedAccess>]
type WhyCompile =
    | WarmCompile
    | DetectFileChange of filechanges

https://github.com/humhei/FCSWatch/blob/master/src/FcsWatch.Binary/AutoReload.fs#L168
Then you can resolve Why compile in lasttasks


BGSBot not accepting a role id

Is there a limit to number of characters in a role name?
I created a role named BGSBot_Manager and when I enter @BGSBot_Manager, I get <@somenumber>_manager. BGSBot will not accept the number when attempting to add a new admin role.

Could you provide a screenshot of the command and the error response?

Below is a screenshot of the out from the @BGSBot_Manager cmd and the error I get when attempting to use the role id.

First of all there is no @BGSBot_Manager command. The procedure to add an admin role is detailed as such

An admin role is able to execute all commands. Find which role you want to add as an admin role. You can add many roles as admin roles. Next you need to find the id of the admin role(s). To do that prepend the mention of your role with . Eg. if your role is admin, you need to use @admin to see the id.

So, you need to identify a role on your server that you want to have admin perms on the bot. Then to get the id of that role, mention the role in the server adding a \ before it. Then use the id with the @bgsbot adminroles add command. Hope that helps.

No, BGSBot_Manager is the name of the role I created that I want to add as an adminrole.
The first entry you see in the screenshot is the output from @BGSBot_Manager, the name of the role that I was trying to get the role id from.

I just noticed that github is stripping the backslash off from my comment.
The cmd is <@BGSBot_Manager>

Hmm...that's really weird. One thing for sure, it's not really an issue of bgsbot. Discord is having issues with giving our the id for the role. But I would like to help you out regardless. Could you join my server, temporarily even, so that I can easily assist you. Invite linked above.

Oh, I think I know the issue. Make sure that the bgsbot_manager role is mentionable. You won't be able to get the id of a role of its not set to mentionable. You can turn off mentions after getting the id.

Yes, that I think that was it. I got the correct role id and the bgsbot adminroles add <role_id> worked perfectly.
Thanks for the quick responses on this.
Issue resolved.


Jade file make brackets slower

Hi,
I found that when I'm using jade file with over 100 lines the editor framerate dramatically drops. I'm using v 1.6.0-16680 (release 3df0ac6fa). Am I the only one?

Hi @TheNemus, if you try Debug \ Reload without extensions can you still reproduce?
AFAICT Brackets doesn't support jade natively, so maybe is an extension problem.

Hi @TheNemus,
if you were able to fix the problem could you share your solution? It could help other users.
Thank you.


Playground and Note preview should not capture focus in Spotter

rel

Playground and Note no longer take focus.


Make language actually working

+extra Russian translation :p

ah sorry, will fix soon

fixed

I think we'll need a resource.AddWorkshop for this now so the new files get acquired.

Files downloading if you subbed to addon, i don't think we actually need to add this

What if we instead do
if GetConvarString("whatever_language_convar_is")=="ru" then
    language.Add("...","russian")
else
    language.Add("...","english")
end

It does


RTMP from Frigate sometimes without a video track

I have HA configured with RTSPtoWebRTC with go2rtc.  Frigate is my camera server using Frigate Cards
I can get the system to work well for a short bit but after a little while I will start getting:
Failed to start WebRTC stream: WebRTC offer was not accepted by any providers
And at the same time the logs in go2RTC will report:
23:04:47.636 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
23:04:47.637 ERR [api.hass] exchange SDP error="couldn't find the matching tracks"
Frigate/HASS/go2RTC are all running in containers on the same docker host.  go2RTC is setup with a macvlan.  I have tested with go2RTC setup in host mode same result.

You need to increase log level and provide more logs

Some additional info.  I noticed that when a stream fails that camera/stream in gortc always has a "client producer" hanging around without consumers.  Not sure if this has any relevance to the issue.

You have too many simultaneous streams in the log. It's hard to understand. You need to leave only one.
Try to add one RTMP to go2rtc config and open it from go2rtc UI.

Yeah that might make it take a much longer time to reproduce.  Issue I think might be due to the number of streams I have.  ~16.  Of 16 after a few minutes I will start to have issues with 2-4 of them.  Once the issue starts though only a restart of gortc will resolve it.

ACtually I was able to get it to fail.  I could not get it to fail with open via the go2rtc UI though.  I then added a dashboard in HA so that just the one camera is there and since that camera was pre-config in the config file it did not need to auto create it.  Then after reloading that HA page with the Frigate card i got the error.
AGain when this error happened this is what is in the info for that camera:
[   {     "media:0": "audio, sendonly, 0 MPEG4-GENERIC/16000/1",     "receive": 0,     "remote_addr": "<IP_ADDRESS>:1935",     "track:0": "0 MPEG4-GENERIC/16000/1, sinks=0",     "type": "RTMP client producer",     "url": "rtmp://frigate:1935/live/office"   } ]
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped
exit OK
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
16:58:27.959 DBG [app] arch=amd64 conf_size=218 cwd=/config os=linux
16:58:27.960 TRC [api] register path path=/
16:58:27.960 TRC [api] register path path=/api/streams
16:58:27.960 TRC [api] register path path=/api/ws
16:58:27.960 INF [api] listen addr=:1984
16:58:27.960 TRC [api] register path path=/api/devices
16:58:27.961 TRC [api] register path path=/static
16:58:27.961 TRC [api] register path path=/streams
16:58:27.961 TRC [api] register path path=/stream/
16:58:27.961 TRC [api] register path path=/stream
16:58:27.961 INF [rtsp] listen addr=:8554
16:58:27.961 TRC [api] register path path=/api/frame.mp4
16:58:27.961 TRC [api] register path path=/api/stream.mp4
16:58:27.961 TRC [api] register path path=/api/stream.mjpeg
16:58:27.961 INF [srtp] listen addr=:8443
16:58:27.961 TRC [api] register path path=/api/homekit
16:58:27.961 TRC [api] register path path=/api/stack
16:58:27.961 TRC [api] register path path=/api/exit
16:58:57.125 TRC [api] GET url=/streams
16:58:57.127 TRC [api] POST url=/stream/camera.office/add
16:58:57.130 TRC [api] POST url=/stream/camera.office/channel/0/webrtc
16:58:57.138 TRC [streams] consumer:0:0 candidate media="audio, recvonly, 111 OPUS/48000/2, 63 RED/48000/2, 103 ISAC/16000, 9 G722/8000, 0 PCMU/8000, 8 PCMA/8000, 105 CN/16000, 13 CN/8000, 110 TELEPHONE-EVENT/48000, 113 TELEPHONE-EVENT/16000, 126 TELEPHONE-EVENT/8000"
16:58:57.138 DBG [streams] probe producer url=rtmp://frigate:1935/live/office
16:58:58.413 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.413 TRC [streams] consumer:0:1 candidate media="video, recvonly, 96 H264/90000, 97 RTX/90000, 98 H264/90000, 99 RTX/90000, 100 H264/90000, 101 RTX/90000, 102 H264/90000, 125 RTX/90000, 104 VP8/90000, 124 RTX/90000, 106 VP9/90000, 107 RTX/90000, 108 RED/90000, 109 RTX/90000, 127 ULPFEC/90000, 35 FLEXFEC-03/90000"
16:58:58.413 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.413 TRC [streams] consumer:0:2 candidate media="application, , 0 webrtc-datachannel/0"
16:58:58.413 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.413 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
16:58:58.413 ERR [api.hass] exchange SDP error="couldn't find the matching tracks"
16:58:58.543 TRC [api] GET url=/streams
16:58:58.544 TRC [api] POST url=/stream/camera.office/add
16:58:58.546 TRC [api] POST url=/stream/camera.office/channel/0/webrtc
16:58:58.552 TRC [streams] consumer:0:0 candidate media="audio, recvonly, 111 OPUS/48000/2, 63 RED/48000/2, 103 ISAC/16000, 9 G722/8000, 0 PCMU/8000, 8 PCMA/8000, 105 CN/16000, 13 CN/8000, 110 TELEPHONE-EVENT/48000, 113 TELEPHONE-EVENT/16000, 126 TELEPHONE-EVENT/8000"
16:58:58.552 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.552 TRC [streams] consumer:0:1 candidate media="video, recvonly, 96 H264/90000, 97 RTX/90000, 98 H264/90000, 99 RTX/90000, 100 H264/90000, 101 RTX/90000, 102 H264/90000, 125 RTX/90000, 104 VP8/90000, 124 RTX/90000, 106 VP9/90000, 107 RTX/90000, 108 RED/90000, 109 RTX/90000, 127 ULPFEC/90000, 35 FLEXFEC-03/90000"
16:58:58.552 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.552 TRC [streams] consumer:0:2 candidate media="application, , 0 webrtc-datachannel/0"
16:58:58.552 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:58:58.552 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
16:58:58.553 ERR [api.hass] exchange SDP error="couldn't find the matching tracks"
16:59:09.245 TRC [api] GET url=/
16:59:09.250 TRC [api] GET url=/main.js
16:59:09.251 TRC [api] GET url=/api/streams
16:59:22.187 TRC [api] GET url=/streams
16:59:22.189 TRC [api] POST url=/stream/camera.office/add
16:59:22.191 TRC [api] POST url=/stream/camera.office/channel/0/webrtc
16:59:22.196 TRC [streams] consumer:0:0 candidate media="audio, recvonly, 111 OPUS/48000/2, 63 RED/48000/2, 103 ISAC/16000, 9 G722/8000, 0 PCMU/8000, 8 PCMA/8000, 105 CN/16000, 13 CN/8000, 110 TELEPHONE-EVENT/48000, 113 TELEPHONE-EVENT/16000, 126 TELEPHONE-EVENT/8000"
16:59:22.196 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.196 TRC [streams] consumer:0:1 candidate media="video, recvonly, 96 H264/90000, 97 RTX/90000, 98 H264/90000, 99 RTX/90000, 100 H264/90000, 101 RTX/90000, 102 H264/90000, 125 RTX/90000, 104 VP8/90000, 124 RTX/90000, 106 VP9/90000, 107 RTX/90000, 108 RED/90000, 109 RTX/90000, 127 ULPFEC/90000, 35 FLEXFEC-03/90000"
16:59:22.196 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.196 TRC [streams] consumer:0:2 candidate media="application, , 0 webrtc-datachannel/0"
16:59:22.196 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.196 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
16:59:22.196 ERR [api.hass] exchange SDP error="couldn't find the matching tracks"
16:59:22.311 TRC [api] GET url=/streams
16:59:22.313 TRC [api] POST url=/stream/camera.office/add
16:59:22.315 TRC [api] POST url=/stream/camera.office/channel/0/webrtc
16:59:22.319 TRC [streams] consumer:0:0 candidate media="audio, recvonly, 111 OPUS/48000/2, 63 RED/48000/2, 103 ISAC/16000, 9 G722/8000, 0 PCMU/8000, 8 PCMA/8000, 105 CN/16000, 13 CN/8000, 110 TELEPHONE-EVENT/48000, 113 TELEPHONE-EVENT/16000, 126 TELEPHONE-EVENT/8000"
16:59:22.319 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.319 TRC [streams] consumer:0:1 candidate media="video, recvonly, 96 H264/90000, 97 RTX/90000, 98 H264/90000, 99 RTX/90000, 100 H264/90000, 101 RTX/90000, 102 H264/90000, 125 RTX/90000, 104 VP8/90000, 124 RTX/90000, 106 VP9/90000, 107 RTX/90000, 108 RED/90000, 109 RTX/90000, 127 ULPFEC/90000, 35 FLEXFEC-03/90000"
16:59:22.319 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.319 TRC [streams] consumer:0:2 candidate media="application, , 0 webrtc-datachannel/0"
16:59:22.319 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:22.319 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
16:59:22.320 ERR [api.hass] exchange SDP error="couldn't find the matching tracks"
16:59:41.007 TRC [api] GET url=/webrtc.html?src=camera.office
16:59:41.026 TRC [api] GET url=/api/ws?src=camera.office
16:59:41.031 DBG [webrtc] new consumer url=camera.office
16:59:41.037 TRC [streams] consumer:0:0 candidate media="video, recvonly, 96 H264/90000, 97 RTX/90000, 98 H264/90000, 99 RTX/90000, 100 H264/90000, 101 RTX/90000, 102 H264/90000, 125 RTX/90000, 104 VP8/90000, 124 RTX/90000, 106 VP9/90000, 107 RTX/90000, 108 RED/90000, 109 RTX/90000, 127 ULPFEC/90000, 35 FLEXFEC-03/90000"
16:59:41.037 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:41.037 TRC [streams] consumer:0:1 candidate media="audio, recvonly, 111 OPUS/48000/2, 63 RED/48000/2, 103 ISAC/16000, 9 G722/8000, 0 PCMU/8000, 8 PCMA/8000, 105 CN/16000, 13 CN/8000, 110 TELEPHONE-EVENT/48000, 113 TELEPHONE-EVENT/16000, 126 TELEPHONE-EVENT/8000"
16:59:41.037 TRC [streams] producer:0:0 candidate media="audio, sendonly, 0 MPEG4-GENERIC/16000/1"
16:59:41.037 WRN [api.webrtc] add consumer error="couldn't find the matching tracks"
16:59:45.028 TRC [api] GET url=/
16:59:45.035 TRC [api] GET url=/main.js
16:59:45.038 TRC [api] GET url=/api/streams
``

Well. There is no video in your RTMP stream. Only audio.

Ideas on as to the cause of that?  Cause the stream HAD video and then didn;t.

tried to reproduce it again and now i can't.  So the stream not having video only happens on occasion and it can happen even AFTER it was working fine.  Once it happens it does not correct itself.  The other part that seems to stand out is if I remove ALL consumers under normal conditions all the producers are cleaned up EXCEPT when the failure occurs the audio channel sticks around with no consumers.

Reopen issue if it still relevant

I've been getting the same errors as you "Failed to start WebRTC stream: WebRTC offer was not accepted by any providers
"
and
23:19:27.127 ERR github.com/AlexxIT/go2rtc/cmd/streams/producer.go:51 > error=EOF url=rtsp://<IP_ADDRESS>:38599/69f4b72cd9d9654e
23:19:27.127 WRN github.com/AlexxIT/go2rtc/cmd/webrtc/webrtc.go:198 > stream.AddConsumer error="source 0 error: EOF"
23:19:27.128 ERR [api.hass] exchange SDP error="source 0 error: EOF"

This seems to happen when I use the rebroadcast URL from Scrypted. The weird part is that I have 10 cameras and only 2 of them have this issue with the rebroadcast URL. Would love to help troubleshoot this as this was not the issue on the v2 releases.

@skynet01 maybe your problem related to #165
Because you using RTSPtoWebRTC integration.
I recommend to use WebRTC Camera v3

Ah ... I see you remember :) I am actually using both since I wanted to have built-in ha entity support as well.. or does the new v3 has that feature as well now?


flaky kvstore test

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/1221/pipeline/

+ ../../tools/launch.py -n 7 --launcher local python dist_sync_kvstore.py --type=gluon_step_cpu

terminate called after throwing an instance of 'dmlc::Error'

  what():  [05:33:59] /work/mxnet/3rdparty/ps-lite/include/ps/kv_app.h:587: Check failed: lens->size() == keys.size() (2 vs. 1)

Stack trace returned 9 entries:

[bt] (0) /work/mxnet/python/mxnet/../../lib/libmxnet.so(dmlc::StackTrace[abi:cxx11]()+0x55) [0x7fccbfc095b5]

[bt] (1) /work/mxnet/python/mxnet/../../lib/libmxnet.so(dmlc::LogMessageFatal::~LogMessageFatal()+0x28) [0x7fccbfc0a0e8]

[bt] (2) /work/mxnet/python/mxnet/../../lib/libmxnet.so(int ps::KVWorker<char>::Pull_<ps::SArray<char>, ps::SArray<int> >(ps::SArray<unsigned long> const&, ps::SArray<char>*, ps::SArray<int>*, int, std::function<void ()> const&)::{lambda()#1}::operator()()+0x71d) [0x7fccc2a7a5ed]

[bt] (3) /work/mxnet/python/mxnet/../../lib/libmxnet.so(ps::KVWorker<char>::RunCallback(int)+0xf6) [0x7fccc2a22f16]

[bt] (4) /work/mxnet/python/mxnet/../../lib/libmxnet.so(ps::KVWorker<char>::Process(ps::Message const&)+0x2b4) [0x7fccc2a75d54]

[bt] (5) /work/mxnet/python/mxnet/../../lib/libmxnet.so(ps::Customer::Receiving()+0x57c) [0x7fccc2a82c5c]

[bt] (6) /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb8c80) [0x7fccbc442c80]

[bt] (7) /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7fccc724d6ba]

[bt] (8) /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7fccc6f8341d]

Exception in thread Thread-4:

Traceback (most recent call last):

  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner

    self.run()

  File "/usr/lib/python2.7/threading.py", line 754, in run

    self.__target(*self.__args, **self.__kwargs)

  File "/work/mxnet/tools/../3rdparty/dmlc-core/tracker/dmlc_tracker/local.py", line 44, in exec_cmd

    raise RuntimeError('Get nonzero return code=%d' % ret)

RuntimeError: Get nonzero return code=-6

Sending interrupt signal to process

Terminated

script returned exit code 143

Is it failing? Why did it get reverted?


Fix most warnings when compiling w/ clang

Issue with a type_def persists; non-constant member does not appear last

Avg response time
coverage on master

Summary of changes
Fixed most warnings/errors when compiling with Clang. Problematic struct (GNU extension) remains and requires more in-depth adjustment due to use of pointer arithmetic etc.
Rationale for changes
Make code more standard conforming, and emit fewer warnings when building with clang
Additional info and certifications
This pull request (PR) is a:

[x] Bug fix
[ ] Feature addition
[ ] Other, Please describe:

I certify that

[x] I reviewed and followed the contributing guidelines, including
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR  to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code

Self approving because the only changes are style, and rephrasing a C bit twiddling mask construction in a more portable & reliable way
:zap:


Add Azure NIC requirement and clarify azure.json requirement

Proposed changes
Requirements list is missing instruction to enable IP Forwarding for each UCP node NIC.
Clarified that azure.json is needed only on nodes that run kubelet component. At the moment it's not used on Windows workers.

@ollypom @adamancini could you please validate and confirm the changes.

Deploy preview for docsdocker ready!
Built with commit 4649ee08cebbfc588cc273b827d8f960499b844b
https://deploy-preview-9117--docsdocker.netlify.com

Closing this PR as UCP Nodes NIC change is not necessary and azure.json change needs further clarification.
Will make changes and submit another PR.


AI that suggests commands based on description in EN. 🧠

Discussed in https://github.com/Adam-it/cli-for-microsoft-365-extension/discussions/9

Originally posted by Adam-it May 29, 2022
I just had this idea to implement a similar companion feature like in power apps were user describes what is needed and the result is an FX formula.
Here I was thinking to add some kind of side panel with text input so that the user may describe what is needed and the extension could suggest the most suitable CLI for M365 command

the idea to reuse mendable in the vs code extension


Can't get full exception info when exception has InnerException

Diagnostics use LogError Method in Here
The default MessageFormatter in LoggerExtensions will ignore Exception , only keep user's message
So if a exception has InnerException, the Diagnostics will not handle InnerException
And Diagnostics think InnerException should be handle by logger
I confused with this, if logger get message and Exception both, should log them both ?
And if message has Exception.Message in it, the info will be redundant ?
The Diagnostics discussion is in  https://github.com/aspnet/Diagnostics/pull/402

Diagnostics use LogError Method in Here
The default MessageFormatter in LoggerExtensions will ignore Exception , only keep user's message

Here's some background https://github.com/aspnet/Logging/issues/442. It's an unfortunate design flaw of logging. Ultimately, the formatter should be ignored in most cases as reasonable loggers will use the exception argument passed in.

So if a exception has InnerException, the Diagnostics will not handle InnerException
And Diagnostics think InnerException should be handle by logger

I'm confused by this. What do you mean it will not handle the inner exception? The logger is passed the entire exception object. Were you using a logging that doesn't print out the exception details?

@davidfowl Thanks a lot.
Before read #442, I didn't know that.
I write a custom logger .
The Diagnostics 's code for log is this :
_logger.LogError(0, ex, "An unhandled exception has occurred: " + ex.Message);

So i just log info from MessageFormatter
After read #442, i will handle MessageFormatter and exception both
Although it will log redundant info for ex.Message


nfs-client: rbac no longer alpha, add serviceAccount to deployment

RBCA is no longer alpha and thus v1 is only needed.
Service account has been added to deployment.yaml in order to get the
example to work correctly.

@wongma7 @musse

/lgtm
thanks :+1:


Project Progress Tracker Project

issues: #24
Project Progress Tracker Project

[x] Setup Server

[x] Install Dependencies
[x] Setup Express App

[x] Model DB

[x] Schema setup

[x]  ProjectSchema
[x] UserSchema

[x] Setup Mongoose Model(s)

[x] POST /logs

Create a new log entry

[x] GET / logs

[x] Listing all log entries

[x] Setting up react as a client
[x] Create react Form to add a new entry(projects as well as users)

Project Progress Tracker Project

[x] Setup Server

[x] Install Dependencies

[x] Setup Express App

[x] Model DB

[x] Schema setup

[x]  ProjectSchema

[x] UserSchema

[x] Setup Mongoose Model(s)

[x] Project route

Create a new route for users and projects

[x] User route

[x] Listing all routes

[x] Setting up react as a client

[x] Create react Form to add a new entry(projects as well as users)
[x]  setting up components

Project Progress Tracker Project

[x] Setup Server

[x] Install Dependencies

[x] Setup Express App

[x] Model DB

[x] Schema setup

[x]  ProjectSchema

[x] UserSchema

[x] Setup Mongoose Model(s)

[x] Project route

Create a new route for users and projects

[x] User route

[x] Listing all routes

[x] Setting up react as a client

[x] Create react Form to add a new entry(projects as well as users)
[x]  setting up components


Cleanup some code.

Cleanup some code.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Zhang Zq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Android Connection timeout

Describe the bug
In my app it often happens that it times out
To Reproduce
Steps to reproduce the behavior:

Connect the device to the ble service
See error

Expected behavior
It should never return connect timeout
My code
  const scan = async (): Promise<void> => {
    try {
      await BleClient.initialize();
      const isEnable = await checkBluetoothStatus();
      if (isEnable) {
        const device = await BleClient.requestDevice({
          scanMode: ScanMode.SCAN_MODE_LOW_POWER,
          namePrefix: 'SMART_LOCK',
        });
        await connectBt(true, device);
        await BleClient.stopLEScan();
        console.info('stopped scanning');
      }
    } catch (error) {
      console.error(error);
    }
  };

 const connectBt = async (withState: boolean, deviceParam?: BleDevice) => {
    try {
      withState && setIsLoadingBle(true);
      const deviceStored = await getLocker();
      const device: LockerStorage = { macAddress: (deviceParam?.deviceId ?? '') || (deviceStored.macAddress ?? '') };
      if (!device.macAddress) throw new Error('macAddress not found');
      await BleClient.disconnect(device.macAddress);
      await BleClient.connect(device.macAddress);
      const services = await BleClient.getServices(device.macAddress);
      if (services[3]) {
        deviceParam?.deviceId &&
          setLocker({
            macAddress: deviceParam.deviceId,
            service: services[3],
          });
        withState && setIsLoadingBle(false);
        withState && setIsConnectBle(true);
      } else {
        console.error('service not found', services);
      }
    } catch (e) {
      console.error(e);
      setIsLoadingBle(false);
      setIsConnectBle(false);
      await toast({
        behavior: 'error',
        message: (e as ErrorBle).message,
        duration: 5000,
      });
    }
  };

Screenshots Logcat

Plugin version:

@capacitor-community/bluetooth-le: 3.1.1

Smartphone (please complete the following information):

Device: Samsung Galaxy S8
Android version 9

Additional context
I have already tried, as shown in my code, to insert disconnect and connect together

I don’t think this is a bug, the timeout means failed of connecting to a certain deviceId, please try to make sure you are connecting to the correct deviceId and if you are sure then try connecting to other peripheral and see if the problem is the same.

actually it's just a bug I tried with another device and I have the same problem.
I tried with: Redmi note 9 e android version 12.
I hope to be able to fix it together as soon as possible because for us this error is blocking

I'm also facing the same issue (Connection Timeout) . I tried to disconnect before connect still Its not working .

Any solution for this?

I just increase my ble device advertisement packets previously 1 sec a packet and now 200 mill sec a packet . Now the connection timeout error decreased . Its not coming frequently but I cant able to avoid totally .

The BLE advertising interval absolutely can impact this significantly. Even 200ms is still only middling. Apple recommends an interval of 20ms for at least the first 30s for best discovery, then has some suggested intervals to slow down at.
See https://developer.apple.com/accessories/Accessory-Design-Guidelines.pdf


Allow specifying docker file for tye run

Fixes https://github.com/dotnet/tye/issues/146
I don't know if well get this into the next release (I'm reluctant to just because I haven't finished the tye deploy story). There are also some paper cuts that are going to make it hard for adoption, including not automatically allocating ports for docker projects (looking into this).

Something is going on with the skip conditions for Docker on Windows. Last four builds have failed due to tests not being skipped. I'll look into it.

I don't know if well get this into the next release (I'm reluctant to just because I haven't finished the tye deploy story). There are also some paper cuts that are going to make it hard for adoption, including not automatically allocating ports for docker projects (looking into this).

The port issue needs to be fixed 👍
I don't really mind if this goes in without deploy support at first. As long as we can document what's working, and it's useful to somebody there's no reason to delay it.

The port issue needs to be fixed 👍

So apparently, I didn't know this, but you need to specify the containerPort. Random ports do seem to work if you specify that.

@amarie401 time to try that first scenario again


Feature/aip 5284 integrate txf

Add a few methods/flow attributes needed in Transform work

Coverage decreased (-0.4%) to 94.858% when pulling 9bbb0ca1c1268b598e3e8ffb472cf9431143ce57 on feature/AIP-5284-integrate-txf into 94b0d15bb743363823e95b4c3af043f956772707 on feature/datasets.


get_builder

implement get_builder function for calcjobs (need to check how it works, at the moment if I do singlepoint.get_builder I only get Process class: Singlepoint
Inputs:
metadata:
options:
stash: {}
monitors: {})

Sorry,

implement get_builder function for calcjobs (need to check how it works, at the moment if I do singlepoint.get_builder I only get Process class: Singlepoint Inputs: metadata: options: stash: {} monitors: {})

What's the general purpose of get_builder/what would you like it to do that it's not doing at the moment?


fix(SDK): IBM Cloud SCC Java SDK

to run ITs with condition:
if [[ $TRAVIS_BRANCH == "main" && $TRAVIS_PULL_REQUEST == "false" ]]

:tada: This PR is included in version 0.0.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: