fix(build): fix resolution algorithm when build.ssr is true

Description
This PR fixes the resolution algorithm when build.ssr is true i.e. when tryNodeResolve is called with ssr: true and externalize: true.
I couldn't find any tests covering this edge case, so I added a fixture in playground/ssr-resolve.
Related issues/PRs: #8420 #8421.
Additional context
The current resolution produces an invalid path here https://github.com/vitejs/vite/blob/e7712ffb68b24fc6eafb9359548cf92c15a156c1/packages/vite/src/node/plugins/resolve.ts#L719-L721
In the case of autosuggest-highlight, autosuggest-highlight/match should resolve to autosuggest-highlight/match/index.js, not autosuggest-highlight/match + .js which doesn't exist.

with fix
➜ DEBUG='vite:resolve-details' pnpm build

><EMAIL_ADDRESS>build /__/vite/playground/ssr-resolve
> vite build

vite v3.1.0-beta.2 building SSR bundle for production...
  vite:resolve-details [fs] /__/vite/playground/ssr-resolve/main.js -> /__/vite/playground/ssr-resolve/main.js +0ms
transforming (1) main.js
  vite:resolve-details [node/deep-import] ./match -><EMAIL_ADDRESS>+24ms
  vite:resolve-details [processResult] autosuggest-highlight/match -> autosuggest-highlight/match/index.js +0ms
  vite:resolve-details [node/deep-import] ./match -><EMAIL_ADDRESS>+3ms
  vite:resolve-details [processResult] autosuggest-highlight/match -> autosuggest-highlight/match/index.js +0ms
  vite:resolve-details [node/deep-import] ./isInteger -><EMAIL_ADDRESS>+2ms
  vite:resolve-details [processResult] lodash/isInteger -> lodash/isInteger.js +0ms
  vite:resolve-details [node/deep-import] ./isInteger -><EMAIL_ADDRESS>+2ms
  vite:resolve-details [processResult] lodash/isInteger -> lodash/isInteger.js +0ms
  vite:resolve-details [node/deep-import] ./server -> /__/vite/node_modules/.pnpm/react-dom<EMAIL_ADDRESS>+2ms
  vite:resolve-details [node/deep-import] ./server -> /__/vite/node_modules/.pnpm/react-dom<EMAIL_ADDRESS>+1ms
✓ 1 modules transformed.
dist/main.mjs   0.27 KiB

without fix (main)
:warning: Notice the paths in the lines tagged with [processResult] (autosuggest-highlight/match.js doesn't exist).
➜ DEBUG='vite:resolve-details' pnpm build

><EMAIL_ADDRESS>build /__/vite/playground/ssr-resolve
> vite build

vite v3.1.0-beta.2 building SSR bundle for production...
  vite:resolve-details [fs] /__/vite/playground/ssr-resolve/main.js -> /__/vite/playground/ssr-resolve/main.js +0ms
transforming (1) main.js
  vite:resolve-details [node/deep-import] ./match -><EMAIL_ADDRESS>+13ms
  vite:resolve-details [processResult] autosuggest-highlight/match -> autosuggest-highlight/match.js +0ms
  vite:resolve-details [node/deep-import] ./match -><EMAIL_ADDRESS>+2ms
  vite:resolve-details [processResult] autosuggest-highlight/match -> autosuggest-highlight/match.js +0ms
  vite:resolve-details [node/deep-import] ./isInteger -><EMAIL_ADDRESS>+1ms
  vite:resolve-details [processResult] lodash/isInteger -> lodash/isInteger.js +0ms
  vite:resolve-details [node/deep-import] ./isInteger -><EMAIL_ADDRESS>+0ms
  vite:resolve-details [processResult] lodash/isInteger -> lodash/isInteger.js +0ms
  vite:resolve-details [node/deep-import] ./server -> /__/vite/node_modules/.pnpm/react-dom<EMAIL_ADDRESS>+1ms
  vite:resolve-details [node/deep-import] ./server -> /__/vite/node_modules/.pnpm/react-dom<EMAIL_ADDRESS>+1ms
✓ 1 modules transformed.
dist/main.mjs   0.27 KiB

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  playground/ssr-resolve/__tests__/ssr-resolve.spec.ts > correctly resolve entrypoints
Error: [vite-node] Failed to load autosuggest-highlight/match.js
 ❯ async /__/oss/vite/playground-temp/ssr-resolve/dist/main.mjs:1:256
 ❯ async /__/oss/vite/playground/ssr-resolve/__tests__/ssr-resolve.spec.ts:6:31

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

One improvement we could do before merging is to move the new tests to an existing playground. Our e2e CI is taking quite a bit of time already so we are trying to keep the number of playgrounds at check. Instead of importing real packages in the ssr-resolve you created, we could add new local packages in the ssr-deps repo with these edge cases distilled (check pkg-exports for example).

Hi @patak-dev, thanks for looking at this!
I had gone that route initially and created packages in ssr-deps, but then a weird thing happenend. The seems to not be reproducible inside that setup. Whether it's because it uses ssrLoadModule or something else, the tests pass with or without the fix. Here's the branch without the fix and the tests still pass.

Log output from that branch
➜ DEBUG='vite:resolve-details' pnpm -w test-build ssr-deps

> vite-monorepo@ test-build /__/oss/vite
> cross-env VITE_TEST_BUILD=1 vitest run -c vitest.config.e2e.ts "ssr-deps"

✂ ✂ ✂
vite:resolve-details [node/deep-import] ./dir -> /__/oss/vite/node_modules/.pnpm/file+playground+ssr-deps+entries/node_modules/entries/dir/index.js
vite:resolve-details [processResult] entries/dir -> entries/dir.js
✂ ✂ ✂
vite:resolve-details [node/deep-import] ./dir -> /__/oss/vite/node_modules/.pnpm/file+playground+ssr-deps+entries/node_modules/entries/dir/index.js
✂ ✂ ✂

 ✓ playground/ssr-deps/__tests__/ssr-deps.spec.ts  (17 tests) 2172ms

Test Files  1 passed (1)
     Tests  17 passed (17)
  Start at  12:02:55
  Duration  3.51s (transform 449ms, setup 169ms, collect 37ms, tests 2.17s)

So, I've removed the real packages (react, lodash, autosuggest-highlight) and created simple ones with the edge cases distilled. Thanks for the feedback!

@patak-dev @bluwy can we please get this merged?

@mrm007 would you address @ydcjeff comments first? Thanks!

@patak-dev Do we have any timeline on when this would be released? It doesn't look like it made it into v3.1.4, but we're very keen to be able to move forward with our project.

@benjervis would you send a PR cherry-picking this one to the v3.1 branch?

@patak-dev I've opened https://github.com/vitejs/vite/pull/10354


double-beep: Watch saundragarza

double-beep requests the watch of the watch_keyword saundragarza. See the MS search here and the Stack Exchange search here.

saundragarza has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Can you add a script to nuke all created resources in this tutorial.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 059a1972-09ee-02a7-8159-07ba04a2c763
Version Independent ID: 4323aa16-062c-1b11-fb73-11777c34f88e
Content: Tutorial - Configure dynamic inventories of your Azure resources using Ansible
Content Source: articles/ansible/dynamic-inventory-configure.md
Service: ansible
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@211217613 Thanks for the feedback. There is no script required. All you need to do is delete the resource group ansible-inventory-test-rg. However, it's probably a good idea to include that in the article. I'll update the article. Thanks again.

does deleting the resource group, delete all resources in the resource group?

Yes. az group delete

You can also use an Ansible playbook to delete the group

This is kind of a meta question but what is the benefit of using a playbook then passing in the resource group like --extra-vars as opposed to just running a az command?

@211217613 If you're working interactively, you could use many different technologies (Az CLI, PowerShell Az module, Ansible, etc.)  However, since this is an Ansible article and readers will ostensibly migrate this code to a CI server, we wanted to show how to perform the task using an Ansible playbook so that the reader can see how the task would be coded.

@211217613
I like your ideas of using --exta-vars and I also like the idea of showing multiple ways to accomplish the task (deleting the resource group, in this case).
Therefore, I've updated the Dynamic Inventory article (and many other articles) to show how to delete the resource group using Ansible, Azure Cli, and Azure PowerShell. I've also updated the sample Ansible playbook to be variable driven for use with --extra-vars.
I've updated the articles that only delete a resource group as their cleanup step. I'm going through the other articles and figuring out how to incorporate the same style of cleanup into them as well.
Thanks for the great feedback.


Update path to hiera.yaml to work in latest version of PE

@greglarkin to be clear, this is where I put our hiera.yaml to get it out of Code Managers hands! (considering that it's what we're using to configure Code Manager!)

@binford2k Ok, thanks for the info. Is PE supposed to eventually move it there anyway? IIRC, there were issues with it living in the code directory.


Linphone fixes

This fixes two issues I found when testing linphone against voip-utils in home-assistant.

With these 3 fixes, I have gotten as far as I hear the "There's a problem with the current voice assistant settings"... which is a completely different issue on my side.
I think this gets us far enough to make the linphone softphone usable.

Any news on this one?

@glance- glad to see you put effort into making linphone work with voip-utils. What would be the easiest way for me to test these changes on my HA setup?

Depends quite heavily on what your HA setup is, but generally, just applying the changes to the relevant files in your virtual-env or container, is the quickest and dirtiest approach. Cloning the repo, checking out the pr and installing it in your venv or extending the base container "upgraded" with this package is another one.

Thank you for the hints!
I am running HA OS and have successfully installed your patched version with:
docker exec -it homeassistant bash
pip install git+https://github.com/glance-/voip-utils.git@linphone-fixes

However I still get the same error when trying to make a call from linphone:
Unexpected error handling SIP INVITE

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/voip_utils/sip.py", line 63, in datagram_received
    method, ruri, headers, body = self._parse_sip(message)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/voip_utils/sip.py", line 224, in _parse_sip
    method = line_parts[0]
             ~~~~~~~~~~^^^
IndexError: list index out of range

Aha! I needed to disable media encryption in linphone. And now it works! But it works with both, latest code from home-assistant-libs/voip-utils and also with this fix from your branch.
All in all I did the following in linphone to make it work:

Settings -> Audio -> Codecs -> Disabled all and left only opus on
Settings -> Call -> Media Encryption -> None
Settings -> Click on the SIP account -> Outbound proxy -> Disabled

@glance- sorry this PR got stuck. We are not looking that much into voip right now. Have you tested this with a grandstream ht801 to ensure that this keeps working?
Also, since I have some VoIP enthusiasts in this PR: I've opened a bounty to make outbound calls work.

I don't have access to any grandstream ht801, but i doubt that these changes would break anything. It's basically just more actual sip compatibility.


Linktree Component based on Strapi Content

[x] Strapi Component Structure
[x] Get Api Response
[x] Build Frontend
[ ]  Farbenwählen

[ ]  60-30-10 Color rule
[ ]  Color-Picker

[ ]  Bilder

[ ]  Avatarbild
[ ]  Cover

[x]  Title
[x]  Beschreibung
[x]  Links as Button with Icon and Title

[x]  Icon & Title (long)
[x]  only Icon (short)
[ ] with Title & Image

todo: need to figure out how to used the image link from api ... also images are in project file and not in DB

if profile image is null (not set) then we need a placeholder image


Use custom QualifierOrder in clang-format

The previous iteration would allow
int constexpr blah;

The new one would trigger on it.
I did not put 'friend' (should it be left-most?) and 'restrict' (we never use it).

Should be ok to merge.


Make landing page not require a cookie

Since we changed how logins work, when you land on the CiviForm index page, a guest account is automatically created and you are redirected with a session cookie for that guest account.  This creates two problems:

This creates a lot of unused, empty guest accounts, because everyone who just visits the page and doesn't do anything on it gets a new guest account created.
Search engine crawlers can not index the page because they can not store cookies while crawling, which results in an infinite redirect that creates new guest accounts over and over.

Instead, the home page should not create a new user, and a user should only be created when hitting the "apply" button on a program (if you aren't already logged in).
I believe we made it work the current way because it was easiest just to pretend a user had clicked "log in as guest" when we removed the landing page.
This is currently a problem for AR as they are unable to get Google to scrape their new CiviForm site and include it in search results.  Seattle is currently in search results, but likely from it being scraped long ago before we implemented the login changes.

related: https://github.com/civiform/civiform/issues/5542#issuecomment-1709016609


Error while pulling image

Error while pulling image: Get https://index.docker.io/v1/repositories/kitematic/hello-world-nginx/images: dial tcp <IP_ADDRESS>:443: getsockopt: network is unreachable

You may need to restart the VM if you've changed network: docker-machine restart default


Switch from Zendesk to abstracted helpdesk (TSR-75)

Draft PR for zenpy adstraction to the helpdesk interface
Will be reviewed by team does not currently need mereged.
ticket: https://trello.com/c/tz5veW6F/75-integrate-interface-with-jml

Codecov Report
Base: 76.15% // Head: 76.23% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (c9b309b) compared to base (96b541b).
Patch coverage: 60.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   76.15%   76.23%   +0.07%
==========================================
  Files         204      204
  Lines        7999     7987      -12
==========================================
- Hits         6092     6089       -3
+ Misses       1907     1898       -9

Impacted Files
Coverage Δ

core/lsd_help_desk/interfaces.py
50.00% <50.00%> (ø)

config/settings/base.py
93.79% <100.00%> (-0.05%)
:arrow_down:

core/lsd_help_desk/__init__.py
83.33% <100.00%> (ø)

leavers/workflow/tasks.py
77.35% <100.00%> (ø)

core/service_now/interfaces.py
32.03% <0.00%> (-0.98%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: add cardinality for optional and mandatory features

Fixes: https://github.com/Universal-Variability-Language/uvl-lsp/issues/44
Read this for more information

Both Cases which are described in #44 are working. But I think it gives another case which at the moment isn't noted.
If we have mandatory feature with cardinality [0..3], one of three has to be selected. But at the moment it also is returns SAT if nothing is selected.

@SundermannC  As I understood it, this is the intended behavior.

Yes, this is intended. I agree that this use case is rather strange, but I think both directions have its merits. Overall, I would still say not being able to select zero features with a cardinality of [0..3] is less intuitive.


(SUP-2909) Check that use_cached_catalog setting is false

Please check off the steps below as you complete each step

[x] Put the Jira ticket number in parentheses in the Title e.g. (SUP-XXXX) Add Super Duper State Check
[x] Update the Jira ticket status to Ready for Review
[x] Update the Scoring Spreadsheet
[ ] Get a review from someone on the support team
[ ] Get a review from @misseuropa, @davidbastedo, or @deleon365

The code looks good to me.

I have made the readme changes suggested to S0030, we should raise a ticket for the changes to the other tests.
I have rebased, changed the number of tests to 16 and this should be good to merge.


Infinite redirect loop on package download

A wheel was uploaded to our local warehouse instance via twine, but when trying to download it via pip or the website, it causes an infinite redirect loop. The HTTP response gives a 301 status code, and says the file has moved, but the URL it says the package moved to is the exact same URL to which the request was made.
The only modification made has been changing the FILES_BACKEND url in docker-compose.yml to match the IP address of the warehouse server:
-  FILES_BACKEND: "warehouse.packaging.services.LocalFileStorage path=/app/data/packages/ url=http://files.example.com/packages/{path}"
+  FILES_BACKEND: "warehouse.packaging.services.LocalFileStorage path=/app/data/packages/ url=http://<IP address>/packages/{path}"

This was caused by trying to serve packages from the same machine warehouse was running on (rather than using a CDN or S3). After talking with @dstufft, we fixed it by:

Setting up nginx (via Docker) on the machine to serve package requests
Redirected to nginx rather than Warehouse itself (as we were doing above)
The trick was setting up both the web and nginx containers to add/serve packages to/from the same place on disk.

The web container added packages to /app/data, so we gave it a /app/data volume to add to, and passed that same volume to nginx to serve from.


Tweak regression settings

Minor tweaks to order in which we're running regressions
Make use of tjena

Codecov Report
Base: 58.88% // Head: 58.88% // No change to project coverage :thumbsup:

Coverage data is based on head (d289045) compared to base (4527a5d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2038   +/-   ##
=========================================
  Coverage     58.88%   58.88%
  Complexity     1135     1135
=========================================
  Files           187      187
  Lines         10948    10948
  Branches       1487     1487
=========================================
  Hits           6447     6447
  Misses         4011     4011
  Partials        490      490

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Get rid of the .Final suffix for the next minor

/cc @maxandersen @holly-cummins @gastaldi @aloubyansky

We don’t run the tests when releasing or it would take several extra hours.
And I want to be extra sure we are compatible with Java 11.

Yes any release that is already released with the .Final suffix will keep it.

@aloubyansky @holly-cummins I hope you're both happy now :)


[BUG] Does not work with Closure Compiler

Description/Screenshot
Hi,
I have an Angular 9 project which consists of 2 projects: app and libs. We compile everything using Google Closure Compiler (advanced mode), using the pipeline from this project: https://github.com/steveblue/angular2-rollup
Now I'm trying to use your project in the libs project. With the "normal" angular compiler (ng) it works fine. But I can not get it to work with the Closure Compiler. I'm not an expert on this, but my guess is the problem is that none of your builds are processed by tsickle, and don't get any annotations generated, needed by the Closure Compiler.
I've tried to import it from all of your builds, adding the following to my closure.conf file:

when using the /dist build:

--js<EMAIL_ADDRESS>--js<EMAIL_ADDRESS>

when using the /dist-esm build:

--js<EMAIL_ADDRESS>--js<EMAIL_ADDRESS>

when using the /browser build:

--js<EMAIL_ADDRESS>--js<EMAIL_ADDRESS>
The result is the same in all 3 cases, a closure error:
 ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "@microsoft/applicationinsights-web"
Maybe I'm just missing something. If so, and if anyone managed to get this lib working with the Closure Compiler, could you please share how to do it?
If not, do you have any plans of adding this support for making this lib Closure Compiler friendly?
Currently, this is a big issue for us. We would like to use Application Insights, since we have everything else on Azure, but this is a show stopper. The only alternative we have so far (if that is even possible) is to ditch this lib, and use the rest API directly

We don't internally have anything scheduled to make App insights lib Closure Compiler friendly, but that doesn't mean that someone from the community can't provide some insights and PR's to make it so.
Another option that you would have would be to not consume the NPM's and instead use the CDN version (raw JS), if you take this path I would suggest that you have some form of small wrapper that manages the loading / initialization as your own module (basically similar to the snippet), you could also use the snippet but this will populate a global variable with the instance reference.

@MSNev Thanks for the reply. The problem I have with the snippet is that our app is a widget that is injected into other sites. Since it puts it in the window object, if the other (parent) site would use application insights in the same way, the 2 objects would collide.
Is there a way to make the snippet load it into something else, e.g. window.myscope.applicationinsights, to get around that problem?

For the new snippet, I exposed the internal name setting so you can do this.
//name: "appInsights", // Global SDK Instance name defaults to "appInsights" when not supplied
The value you set here is the global name on the window object that this instance will be created on, we could possible extend this to support depth such as "myscope.applicationinsights", however, this would be a breaking change and require some changes to the SDK Initialization code as well as the snippet to follow the path. So for now you could just set as "myscope_appInsights" (or anything else thats a value variable name).
The other approach would be this on (https://github.com/Microsoft/ApplicationInsights-JS#alternative-setup-method-include-ai-js-sdk-script-and-initialize-statically) and in this case you could put the instance anywhere you like (including in a closure so its not public).

@MSNev Thanks for the reply. I've seen that name setting, I'll try it that way. The dept would be a nicehave, but it's not a show stopper. We can come up with a name that won't collide with someone else.
From the docs I was worried about this part:

Note: if you provide a name value or a previous instance appears to be assigned (via the global name appInsightsSDK) then this name value will also be defined in the global namespace as window.appInsightsSDK=, this is required by the SDK initialization code to ensure it's initializing and updating the correct snippet skeleton and proxy methods.

I was under the impression that this window.appInsightsSDK is hardcoded, so if I set the name setting to e.g. "myscope_appInsights", it will be: window.appInsightsSDK='myscope_appInsights', and then the parent site sets a custom name as well, it would override it with window.appInsightsSDK='theirscope_appInsights'. Is that the case, or have I misunderstood the docs?
I'll check out the other approach you mentioned, as well

You are correct and this is also why I added this specific note to call out this possible race condition when more than 1 snippet instance is being used and both attempt to update the appInsightsSDK, this was also a pre-existing issue with the earlier versions of the snippet and it's not an easy issue to completely unrole...

So I guess that rules out the snippet, since even with different names, the 2 instances can still collide.
Your last approach seems like the only way to go, I'll give that a try.

@MSNev One more question. I'm trying to go with the last approach you suggested. Is there a types package for this lib, so I don't have to define the same interfaces, or use "any" types all over the place. I've found this one, but it seems like it's for an older version https://www.npmjs.com/package/@types/applicationinsights-js

Types are built into this library and should be picked up by your IDE & Typescript automatically. If you need to manually point to them, they are located here:
https://github.com/microsoft/ApplicationInsights-JS/blob/109055815ab6f2946a9a5a874938b5e09fe325d6/AISKU/package.json#L7

I know that they are built in, but when I load them, closure compiler scans the whole lib and crashes, since it's not compatible.
So, for now, I had to ditch the types completely.
Regardless of closure compiler, it would be much cleaner to have types in DefinitelyTyped, so the types and the implementation do not mix. If I just want to use the snippet, I shouldn't be forced to install the whole lib.

If the types where defined in a single rollup .d.ts (rather than the current individual *.d.ts files) would that assist / resolve the issue?

Maybe, not sure, but I don't think so. You still need to install the whole lib, and include stuff from it.
Why not have them in DefinitelyTyped?

Adding build-time generation of a single *.d.ts and *.rollup.d.ts to the build to see if that would assist. These would also form the basis for any form of Definitely Typed definition, but as we generate these as part of the build and they will be included in npm it should not be required to upload and managed versions there as well -- at least that's the initial goal.

As part of the #1475 and #1467 PR's the builds and NPM packages will now contain 2 new unified *.d.ts files for the releases, these will be located in the dist/ folder of each package, so for the AISKU (applicationinsights-web) they are called

applicationinsights-web.d.ts    (This version is namespaced)
applicationinsights-web.rollup.d.ts   (This version is not)


Evaluate Thread issue on ResearchProjectsController

The Thread.new seemed to be behind our issues with Puma occasionally hanging. It is commented out for now.
Read through the latest docs for Thread and see if we can do something to get it working properly OR this may be a good candidate for ActionCable web sockets.

I did a quick benchmark between running this in a new spawned thread vs running this on the thread of the initial request:
irb(main):010:0> Benchmark.bm do |x|
irb(main):011:1*   x.report {10.times do ; ExternalApis::OpenAireService.search(funder: ExternalApis::OpenAireService.default_funder) ; end}
irb(main):012:1>   x.report {10.times do ; Thread.new {ExternalApis::OpenAireService.search(funder: ExternalApis::OpenAireService.default_funder)}.value ; end}
irb(main):013:1> end
       user     system      total        real
   3.596776   0.137933   3.734709 ( 18.262244)
   3.250293   0.087720   3.338013 ( 21.685482)

It looks like there's a not-insignificant overhead involved with creating that thread, and I'm not sure what the benefit is of creating the additional thread.  Puma already has multiple workers/threads handling requests, so is this necessary?

Ah interesting. I'm not sure why we were spawning that thread either. I think maybe to get a quicker initial page load for the user to provide a web-socket-esque experience. I had noticed when adding the project start/end dates to the Project Details page that the page would load but there was a delay before the grant id field's typeahead was rendering results.
Agree that the overhead caused by spawning that thread is undesirable and unnecessary in this case. I also agree that the download/refresh of the source file involved is a good candidate for ActiveJob.


FE: Autocomplete email addresses

Description
E-mail and names for e-mail recipients in Message Editor are autocompleted when user starts typing in any of the recipient fields.
Addresses provided in autocomplete to be fetched from messages.cache in Redux store.
Requirements

Autocompletion is available for all types of recipients in MessageEditor (To, Cc, Bcc)
Suggested addresses appear in a popup list
List is traversable using arrow keys
Elements can be selected pressing Enter key
List is hidden pressing Escape key
List shows at most 10 suggestions
Suggestions are filtered by words typed by the user

E-mail addresses are filtered using input typed by the user
Input is tokenized into words
E-mail addresses must contain all words typed by the user in any order

Suggestions are sorted by frequency in descending order (most frequent e-mail addresses in the cache appear first)

Good idea!!
"user starts typing" and one click event too please... Just click on empty prompts should open dropdown.
I suggest: Dropdown list should be sorted by "number of mails which i sent to this  recipient " (NOT how much i received from). If possible?
But maybe use some contacts storage in backend? Like Mysql/pgsql..
If user goes to new browser then names should persist...

I found another option in other email-client is available to store address book in IMAP server: need create 1 hidden letter with MIME on IMAP server and keep contacts list as CSV in body, so backend don't needed to use any external storage, this hidden mail updated using (imap_mail_compose) function...
This possible to implement contact syncing between many browsers in that way?

Good idea!!
"user starts typing" and one click event too please... Just click on empty prompts should open dropdown.
I suggest: Dropdown list should be sorted by "number of mails which i sent to this recipient " (NOT how much i received from). If possible?
But maybe use some contacts storage in backend? Like Mysql/pgsql..
If user goes to new browser then names should persist...

I like your idea of displaying the drop-down when user clicks on the empty prompt or maybe pressing the down arrow.
Current implementation using react-autosuggest doesn't provide an easy way to show suggestions based on events.
Suggestions are shown based on the value of the prompt, so either they are always shown or they follow a rule such as value.trim().length > 0.
I don't like having the drop-down always open as it blocks user interaction, so for now displaying the drop down requires the user to always type something (as a workaround you can always type @ to display all the cached addresses).
E-mails are sorted by frequency. User's e-mail address is included in this list. One of the main challenges of the application is to know what is the logged user's e-mail address. There is no easy way (or at least that I know of) to do so with regular IMAP protocol, so filtering this address from the list is challenging.
The whole point of the application design is not to create a dependency with a database (at least for core functionality).
There are plans to persist settings and an address book in future versions. For this purpose I'm thinking of 2 different approaches:

Do something like you suggest in your other comment: Settings/address book is persisted using a JSON in a fake e-mail message in a .isotope folder in the user's IMAP mailbox.
Create a specific microservice, with database persistence to store any data that has to be shared across user browsers/sessions.

Anyway, these are just plans for future releases, for the scope of the current ticket we are considering only gathered/cached e-mail addresses.


Gift card balance and initial_value in v10

It looks like GiftCard is using T.let(nil, T.nilable(Float)) for initial_value and balance fields.
However, the API itself actually returns a String for those fields, not a Float. This causes create_instance to fail when using the response from the API as the data.

Just wanted to point out that I upgraded to v11 of the library and v2022-07 of the API and this issue still persists.

The issue persists on v2022-10.

The issue persists on v2022-10.


Result of JSON.stringify(99999.9999999999) is "099999.9999999999"

Related to #180 where the issue was partially fixed.

How do you find these? lol
In my fix I'm now more consistently double-checking the Log10 result, which should resolve the issue for good. (I hope.)

Thank you! The fix works great even with the negative numbers.


Add option to support Semantic Highlighting

From<EMAIL_ADDRESS>on 2015-02-12T15:45:36Z
Feature Request:
As mentioned by @-contrebasse in Issue #1500 ( https://code.google.com/p/spyderlib/issues/detail?id=1500#c13 ), Semantic Highlighting is becoming a more and more popular way of visualizing source code.
Semantic highlighting is the coloring of the variables of the source code rather than the keywords and built-ins. All references to a variable within a given scope would be the same color.
The main main benefits are outlined on the following pages: https://medium.com/@evnbr/coding-in-color-3a6db2743a1e https://zwabel.wordpress.com/2009/01/08/c-ide-evolution-from-syntax-highlighting-to-semantic-highlighting/ It would be nice if Spyder and an option to support this. I would not want to do away with syntax highlighting, as some people will still prefer it.
I think the hardest part of this feature request would be scope limitation. You don't want your 'foo' variable to be the same color in two different scope - that could lead to confusion. Adding a blacklist for Python's (or any languages') keywords and built-ins should be pretty trivial.
We can even go as far as coloring any private (regex: '_\w*') variables as shades of one color, any super-private (regex: '__\w*') vars as shades of another, and standard vars as shades of a 3rd color.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=2172

From ccordoba12 on 2015-02-13T12:00:44Z
As long as there is a Python library for job and someone wants to implement it, I'm all for it :-)
Status: HelpNeeded
Labels: -Type-Defect Type-Enh Cat-Editor

Adding comment so that I get notifications and so that I can find my issues/comments more easily.


Ruby warning email parser that a character class has a duplicated range.

Hi Friend,
While Running tests on Camping, which uses kdl, Ruby issues a warning that the email parser has a character class with a duplicated range. I think it's a regex error. If you don't get to this I'd like to open a PR to maybe fix it.
Relevate error:
/Users/kow/.rvm/gems/ruby-3.3.0/gems/kdl-1.0.5/lib/kdl/types/email/parser.rb:74: warning: character class has duplicated range: /[^\x00-\x1F\s".@]/

weird, I can't seem to get the warning to show on my side.
it looks like most of \s is already in \x00-\x1f, so I'll just replace \s with   and that should fix it

@karloscarweber can you check out #17 and see if it makes the warning go away without any adverse issues?

That fixes it.
I get the error when installing camping 3.2.3, gem install camping, running the camping new command: camping new myapp, installing gems via bundler: bundle install then running the almost empty test suite: bundle exec rake.
Thanks for fixing this so quickly.

Fixed in v1.0.6 release


The Streamer with A=AlwaysMatchAutomaton does not need to maintain a stack of states

This is an optimisation for the AlwaysMatchAutomaton

We can probably improve the code with the poor man's specialization.
if automaton.always_match(state) {
   // ...
}

or even
if A::always_match() {
   // ...
}


Error "invalid tar header" while importing an image saved within a STDOUT stream to a tar file

debian_version 8.7
Linux 3.16.0-4-amd64 #1 SMP Debian 3.16.39-1 (2016-12-30) x86_64 GNU/Linux
docker version
Client:
Version:      1.13.1
API version:  1.26
Go version:   go1.7.5
Git commit:   092cba3
Built:        Wed Feb  8 06:36:34 2017
OS/Arch:      linux/amd64
Server:
Version:      1.13.1
API version:  1.26 (minimum version 1.12)
Go version:   go1.7.5
Git commit:   092cba3
Built:        Wed Feb  8 06:36:34 2017
OS/Arch:      linux/amd64
Experimental: false
Issue
docker save mysql > mysql.tar
docker load < mysql.tar

=> Error processing tar file(exit status 1): archive/tar: invalid tar header
although this way works
docker save --output=mysql.tar mysql
docker load < mysql.tar

=> Loaded image: mysql:latest

I am not able to reproduce with 1.13.1. Maybe it is because the mysql image or tar file is generated from earlier versions of docker?

Should probably not make a difference. Difference is if the tar is piped or directly written to a file.
I have also not been able to reproduce this issue


Seems that concat token ".." is not supported

Seems that concat token ".." is not supported

sorry , seems my mistake, this can be closed now

Seems that concat token ".." is not supported


[RadioJavan] Extractor add for downloading mp3, podcast and playlist from RadioJavan.

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[ ] New extractor
[x] New feature

Description of your pull request and other information
Extractor add for downloading mp3, podcast and playlist from RadioJavan.

Split into multiple extractors per URL kind.
Read coding conventions.
Eliminate code duplication.

+1


UUID generation fails when sysfs cannot be read

$uuid = \Ramsey\Uuid\Uuid::uuid1();

This line of code fails in my app with the following error message:

file_get_contents(/sys/class/net/eth0/address): failed to open stream: Permission denied

Related: #185 (needs error handling for this code that reads from sysfs)
I do not have any control over this server.  For now, I have commented out the following line in the vendor dir which is not ideal as a long-term fix but it got things working again:
https://github.com/ramsey/uuid/blob/f30bc1af81b1fdf5dec5ae085eb3ac2c59c32fe7/src/Provider/Node/SystemNodeProvider.php#L42

@nylen, @defser: Please try out version 3.9.2 of ramsey/uuid and let me know if that resolves this issue. Specifically, commit https://github.com/ramsey/uuid/commit/b39ec78f6e7655676cc65c4081007b9823e7cbc7 is where I fixed this.
Thanks for reporting this, and I'm sorry it took so long for me to resolve it!

@ramsey Thanks for looking in to it, seems like this issue is not yet resolved properly. Had the same issue just now on Debian with GRsecurity patched Linux kernel with error:
grsec: denied attemp to access restricted sysfs entry /sys/devices/vif-o/net/eth0/address by /usr/local/php-7.3/sbin/php-fpm[php-fpm:106557] uid/euid:1506/1506 gid/egid:1506/1506, parent /usr/local/php-7.3/sbin/php-fpm[php-fpm:1724] uid/euid:0/0 gid/egid:0/0
Updated to 3.9.2 but it did not resolve the error. maybe you can take another look at this problem?


Small refactoring

This is in default-command branch for https://github.com/BradleyChatha/jcli/pull/27

Correct me if I'm wrong, but this doesn't handle when there's multiple @CommandDefault across multiple modules?
e.g. mod.a and mod.b both use @CommandDefault, from what I can see that won't be handled?

That's right. Will fix it.


New release build?

Dear @ytdl-org team,
I think it is time to create a new release build with all recent improvements.
The latest released "2021.12.17" from 2021-12-16, more two years and one month:

https://github.com/ytdl-org/youtube-dl/releases
https://github.com/ytdl-org/youtube-dl/tags

Thanks in advance.

#30839
#31585


Updates for v1.2.0

Fixes #2
Updates the task so that it can interpret the reportDir input as either a directory or a filename. Fixes an issue from the original forked codebase.

LGTM


Static linking on Windows requires additional defines

Hello,
When linking PTex and OpenJPEG statically, OpenImageIO requires PTEX_STATIC and OPJ_STATIC to be defined to avoid linker errors.
Regards,
Arek

Long ago merged the purported fix. Closing.


Remove ChunkFiller thread sleep and add a wait-notify mechanism

Chunk Filler currently goes to sleep for a predetermined duration (currently 10 ms or so) if no work is done in an iteration. This can increase latencies of incoming put operations if the sleep starts just before data becomes ready to be filled.
When the sleep was removed, we saw considerable improvement in the tests.
To avoid busy looping, particularly at light put operation loads, add a wait-notify mechanism to deterministically wake up the chunk filler thread when data becomes available for filling.

Closing.


BasePlayer:Die (HitInfo): IL_0026: c

NullReferenceException: Object reference not set to an instance of an object
<IP_ADDRESS>:59624/76561198042925127/Bloody Mikey kicked: RPC Error: onproject
ileattack
InvalidProgramException: Invalid IL code in BasePlayer:Die (HitInfo): IL_0026: c
all      0x0a000718

Sry for being late on this, now it's fixed.


[MM-45684] - Self Managed: Add pricing modal + Upgrade button

Summary
This PR makes available the pricing modal and upgrade button to self managed workspaces
Ticket Link
MM-45684
MM-45685
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/20653
Screenshots

Release Note
NONE

/update-branch

/update-branch

the final row should have "advanced compliant management" also

Can we also fix the line height for this copy below the button?

This is looking good @AGMETEOR!
I did notice something wrong with the formatting for the banner in the System Console though.
Not sure if it's related to the work you've done here or not but I'm not seeing it outside of this Spinwick. 🤔

@johndavidlugtu @annelieseklein heads up that Contact Sales for self-manged should point to https://mattermost.com/contact-sales/ as the requests from https://customers.mattermost.com/cloud/contact-us come through as cloud specific

@johndavidlugtu heads up that this PR is adding a setting to not show the Upgrade button if disabled in Experimental Settings in the System Console for Self-Managed. Let us know if you have any concerns with this

This is looking good @AGMETEOR!
I did notice something wrong with the formatting for the banner in the System Console though.
Not sure if it's related to the work you've done here or not but I'm not seeing it outside of this Spinwick. 🤔

No introduced by this PR but no harm fixing it here

@johndavidlugtu heads up that this PR is adding a setting to not show the Upgrade button if disabled in Experimental Settings in the System Console for Self-Managed. Let us know if you have any concerns with this

My thoughts here are to not have this option in the System Console. Reason being: if we find that showing the "Upgrade" button does have a positive impact, we can't show the button again to those that have disabled it.
That said, standby as I talk to two more members of the community today.
By the way just to clarify: the button should only be visible to admins.
@marianunez @AGMETEOR

Thanks for the fix on the formatting in the banner @AGMETEOR
This looks good now but should I be able to see the proposed System Console setting to disable the upgrade button?
I'm not seeing it here on the Spinwick.
(Note: I took the screenshot from a larger screenshot above 😄)

Thanks for the fix on the formatting in the banner @AGMETEOR
This looks good now but should I be able to see the proposed System Console setting to disable the upgrade button? I'm not seeing it here on the Spinwick.
(Note: I took the screenshot from a larger screenshot above 😄)

@stevemudie This should only show when there is no license on a server (aka self-hosted starter plan)


chore: vertx-cloud-events to 1.0.13

chore: Promote vertx-cloud-events to version 1.0.13

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


groupshared types emit false uninitialized warnings

for example
groupshared int myInt;

void set(__ref groupshared int i){ i = 1; }

void main(){
  set(myInt);
  use(myInt);
}

Both set and used lines generate uninitialized global warnings.
This is because the uninitialized checker's checkCallUsage doesn't correctly look through rate qualified types.

Close as duplicate of #5022.


Auto-merging org.qownnotes.QOwnNotes

Is there a way to get an exemption for org.qownnotes.QOwnNotes to be auto-merged?
All releases are tested upstream and there are no other dependencies which can break something when updated. 🙏🏻

"No other dependencies" does not seem correct, the main binary is using 41 libraries from runtime. The runtime has its own API/ABI different from distributions

I meant no dependencies shipped in app (except git used as cli tool). Runtime API/ABI is supposed to be stable otherwise it's bug.
In general auto-merged update is as tested as manual update except developer must go to flathub and click the button all the time. There is no benefit for flathub.

We decided to allow newly verified applications access to automerge, I have added the exception in https://github.com/flathub-infra/flatpak-builder-lint/pull/458

Hey, thank you very much!

@pbek you need to revert https://github.com/flathub/org.qownnotes.QOwnNotes/commit/ac553fe7d54e40429633a9cc1c232a2d4ea4ada8 to re-enable auto-merging

I thought as much. 😉 Doing #284 now...


Can it be completely shut down if the Lod is not used?

I just want to display a large number of instances and support culling system. However, I found that Lod took quite some time, as shown in the following figure, can it be completely turned off?

200000 instances

Hi! No, but you can make a fork of this repo and turn off lods.


Realm 10.51.0 not available in SPM

How frequently does the bug occur?
Always
Description
It's not possible to integrate Realm 10.51.0 with SPM. The error is the following one:
Couldn’t check out revision ‘4c4413abd0cd2221f59318f800960fe5bddc1494’
Stacktrace & log output
No response
Can you reproduce the bug?
Always
Reproduction Steps
Add RealmSwift via SPM and set the minimum version to 10.51.0.
Version
10.51.0
What Atlas Services are you using?
-- select --
Are you using encryption?
-- select --
Platform OS and version(s)
iOS
Build environment
Xcode version: 15.4
Dependency manager and version: SPM / Swift 5.10

Some update: This issue occurs if you try to update the package from 10.50.0 to 10.51.0.
I found a workaround. If you remove the package and add it again with the latest version 10.51.0 then it works fine.

Revision 4c4413abd0cd2221f59318f800960fe5bddc1494 exists in the repo and there's no obvious reason for SPM to fail to check it out. Closing this as it's likely a transient issue.


Support TCP only Segment document transfers

In the organization my team and I work in, our cloud and security admins have given us the following stipulations for implementing tracing:

We must use standalone EC2 instances, no ECS clusters, etc (Until we completely migrate to Fargate).
We should only have one app running per EC2 instance, no further containers, no daemon sidecar.
We can’t bridge between EC2 instances (container to container communication is explicitly disabled)
Our organization registry/gateway services must be used for authentication and communication between apps (including the daemon) and they can only support TCP.

Is there any thought to making this a configurable option or something similar? I should add that our organization has a quite large enterprise ecosystem, hence the reason we are trying to begin the process for instrumenting our apps with x-ray.

Never mind. The people in charge of budget killed the tracing project. Until we migrate our apps to Fargate anyway, hopefully in the coming months.

@BHunter2889 When faced with a similar constraint set I once send the XRay segments directly to the XRay API without an deamon as intermediary. If you trust your app code to batch up the segments this may work well. Downside is that a crashing app takes the (partial) batch away before sending it out.

There are drawbacks to front-loading the SDKs to handle sending the segments. The optimizations for the daemon and SDK were built on UDP for speed and efficiency at a cost of reliability. Some of our SDKs do not have the necessary APIs to change their streaming logic, a gap which we are attempting to close.
Please feel free to reach-out at a later date when you know your integration timeline, we'd be happy to help finding a solution viable to for your constraints.


Fix problems reported by PHPStan

Please see separate commits

This PR has been reduces to two basic things.

Agree with @gchtr. This PR is now totally fine, but more from a time perspective I want to wait on review and merge so we can remain focused on #2194 (Factories) which is our big blocker to getting 2.x complete (and then being able to really devote focus here and other clean-up issues).
Note to future self: the correct CoAuthorsPlus we should use once Factories is merged is this one:
https://github.com/timber/timber/blob/2.x-factories/lib/Integrations/CoAuthorsPlusUser.php
https://github.com/timber/timber/blob/507db4c3f993468a6391deed98d1852791948d3d/lib/Integrations/CoAuthorsPlusUser.php

Note to future self:

:-D

Resolved in https://github.com/timber/timber/commit/ff7a2171e83f79ddb9670f5c0cf26dfd73a95579


version numbers missing on macOS

i've downloaded Version '18.03.2' for Mac but when selecting it in the Finder and using 'Get Info' it doesn't show any Version-number at all. i guess the CFBundleVersion and CFBundleShortVersionString entries in your Info.plist file are missing.
all apps on macOS are supposed to contain valid version information.

hum... we have them...

hey jerome, thanks for your prompt answer.
nice to know that this is supposed to work in principle, but if you actually download 18.03.2:
https://mediaarea.net/download/binary/mediaconch-gui/18.03.2/MediaConch_GUI_18.03.2_Mac.dmg
then you'll see it doesn't contain any of the stuff you've linked:

@core-code please test this development snapshot.

yes, this one properly has versions

Fixed by https://github.com/MediaArea/MediaConch_SourceCode/pull/655.

thanks!


WIP csi driver kubevirt

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

The corresponding csi driver PR:
https://github.com/kubevirt/csi-driver/pull/44

superseded by https://github.com/openshift/hypershift/pull/1733

/close


Add --router_mode to pytest --runnightly command line

@soneryaldiz @854768750 @Lastdayends Seems that we are getting the same number of errors when we use bottom up mode as we do when we use top down mode. Here is the comparison table:
d.csv

@stevenmburns
There are 3 part data in each raw, which one is the DRC error info for bottom up router?

The first set is 'top_down" (with the _x) suffix. The second set is "bottom_up" (with the _y) suffix. The third set is the difference.
But everything is identical, anyway. We are getting exactly the same DRC and LVS counts.

Also try running:
cd regression_summaries
./render_table.py -0 summary-top_down.csv -1 summary-bottom_up.csv

Then visit: localhost:8050 and you should see the table view dynamically with better column headers.

@kkunal1408 Can you check if these changes are breaking you usage of --runnightly.
Also, look at the comment above.

@kkunal1408 Can you check if these changes are breaking you usage of --runnightly.
Also, look at the comment above.

Looks okay to me.  runnightly works fine.

@kkunal1408 Can you check if these changes are breaking you usage of --runnightly.
Also, look at the comment above.

Looks okay to me. runnightly works fine.

Can you approve it? Thanks.


Convert to Library Asset

Either converting the whole base to be a Library Asset, or creating a plain empty dialogue system out of the base to share as an asset for games to use.

In progress, but unable to continue until https://github.com/Facepunch/sbox-issues/issues/5522 is fixed.


Free mode: message when sensor is in free mode

Description:
Add message that you are in free mode
when no data is shown to free user
Sensor view histogram and dashboard
No data. This sensor is in free mode.

On my old Mac 15" laptop the text doesn't fit in the box when I select French language. Chrome has font size set to Medium, which is the recommended default setting.

QA passed


Add a way for users to get current time

Is your feature request related to a problem? Please describe.
time() printing a string to terminal is fine for some use cases but it's more useful in others to be able to printf() a timestamp.
Making time() return a string would be API breaking and also cause issues with strncmp (because we cannot resolve the timestamp string in kernel) so we probably don't wanna change that.
Perhaps we can make a epoch builtin that returns seconds since epoch? I think seconds as granularity should be enough b/c high precision timing could just use nsecs instead.
Describe the solution you'd like
epoch builtin to return seconds since epoch.
We could insert the epoch time at system boot in a map during prog load and then use bpf_ktime_get_ns() helper to compute seconds since epoch.
Describe alternative solutions or features you've considered
Making timestamp() return a string

Might be useful to have strftime() as a builting, which accepts a format string, and returns a string. That way we also stick to standard conventions around time formatting.

Might be useful to have strftime() as a builtin, which accepts a format string, and returns a string. That way we also stick to standard conventions around time formatting.

I don't think we can implement that as we cannot do the string formatting in bpf, so we cannot return an actual string.
I think it should be to re-use time for this without breaking the current behaviour. That way we can introduce the new one and slowly phase out the old one in the next few releases.
That would mean we support both:
i:s:1 { time("xxx"); }

and
i:s:1 { $ts = nsecs + 300000; printf("%s\n", time("xxx", $ts); }

To do this we would have to add a new type, Type::timestamp which just stores the value of nsecs and detect whether time() is used "stand alone" or in assignment/printf.
I think we should make it a "final" type that doesn't allow modification, e.g. time(...) + 300 should be invalid.
This assuming that we can somewhat reliably convert nsecs into a real timestamp. Not sure how accurately we can get the actual time the system booted. But it won't be any less accurate than time() currently is, which gets the timestamp on which the event gets printed by userspace.

To do this we would have to add a new type, Type::timestamp which just stores the value of nsecs and detect whether time() is used "stand alone" or in assignment/printf.
I think we should make it a "final" type that doesn't allow modification, e.g. time(...) + 300 should be invalid.

I thought about it a bit and I think your approach is better. My only concern is that we're adding onto our growing list of primitive types. But I think this solution is better for the user.

This assuming that we can somewhat reliably convert nsecs into a real timestamp. Not sure how accurately we can get the actual time the system booted. But it won't be any less accurate than time() currently is, which gets the timestamp on which the event gets printed by userspace.

I think we can probably use /proc/stat's btime to get second level precision. We can make a note about it in the docs how it's second-level.

There may be some crisis where we do deprecate some syntax, but this time() thing isn't it. I'd just allow these both to work forever:
i:s:1 { time("xxx"); }
i:s:1 { $ts = nsecs + 300000; printf("%s\n", time("xxx", $ts); }

or call the second one strftime().

Let's go with strftime(). It might be confusing to change the behavior of time() to depend on how it was called.

@fbs I'm afraid we cannot count on nsecs to get current time since it's implemented using bpf_ktime_get_ns, which does not include suspended time according to bpf-helpers(7). @javierhonduco reminded me that bpf_ktime_get_boot_ns could be useful here, which was introduced to address the problem according to this.
Unless we can assume that systems running bpftrace would never suspend, we need to change our target. I wouldn't propose we change nsecs to rely on bpf_ktime_get_boot_ns because it seems that nsecs never promised to serve this purpose; I assume it (only) serves to compute elapsed time. What I would suggest is that, we only use strftime to print current time, instead of printing a timestamp provided by users (since they don't have the right tool to get that). We may extend its functionality when we can provide the tool. That is to say we only allow something like:
i:s:1 { printf("%s\n", strftime("%H:%M:%S")); }
i:s:1 { printf("%s\n", strftime("%D")); }
i:s:1 { printf("%s\n", strftime()); } // default format

I'm still quite new to bpftrace. So excuse me if I'm wrong about it.

What I would suggest is that, we only use strftime to print current time, instead of printing a timestamp provided by users (since they don't have the right tool to get that).

I don't believe there's a fundamental limitation here. I think we can make nsecs use bpf_ktime_get_boot_ns if it's available. This new nsecs should be backwards compatible and strictly more accurate.
I also have some serious doubts anyone was relying on the missing suspension time (especially I've never heard of people suspending production machines, and production machines are what I imagine our target users is using bpftrace on).
I think we can go ahead with "using" the current nsecs for now and have a separate discussion for "upgraded" nsecs.

Makes sense to me!


Make it possible to hide caret for a root level node without children

Me and my colleagues are using this great library with great success. However, we have been trying to find a way to hide the caret when a node on the root level has no child. Is this already possible?
Thanks for the great work!

It appears if the "children" property is absent (rather than being an empty array) then the node is displayed without caret.

I have the same problem. Last children have caret and when I click them it just tells me the is no sub folder.
I use the :disable-branch-nodes="true" so I can't select anything in my select.
I tried to remove children node and to  set it as an empty array, as null, none of the solution worked...

It looks like the caret would not be displayed if the "children" property is undefined.

It appears if the "children" property is absent (rather than being an empty array) then the node is displayed without caret.

This is the solution.


Fixed LineEdit text removal and placeholder caret alignment

Fixes text alignment when removing text.
During testing I also noticed that the caret was not aligned correctly when using a placeholder, drawing it the start of the placeholder text. It will now ignore the placeholder and draw the caret according to the alignment.
closes #27421

Thanks!


Question about job statistics

Are DCGM Job statistics supported for GPU Instance (MIGs) as well? Doc only mentions GPUs.
I am looking to track the statistics of a job (this would have a start and end) which would use multiple GPU Instances (MIGs). So, wanted to know this can be achieved via DCGM job statistics feature.

@starry91,
The Job statistic utilizes Accounting mode under the hood. Unfortunately, Accounting mode does not support MIG-enabled configurations.


[FLINK-24689][runtime-web] Add log's last modify time in log list view

What is the purpose of the change
This pull request add log's last modified time in taskmanager log list view and jobmanager log list view, it will help us to choose correct log file and analyse problem exactly and quickly.
See FLINK-24689 for more.
Brief change log

add mtime field in class LogInfo and put log file's last modified time into rest api's response
show Last Modified Time in TaskManager's log list view and JobManager's log list view (support sort)

Verifying this change
This change is already covered by existing tests:

org.apache.flink.runtime.rest.handler.cluster.JobManagerLogListHandlerTest#testGetJobManagerLogsList
org.apache.flink.runtime.rest.handler.taskmanager.TaskManagerLogListHandlerTest#testGetTaskManagerLogsList
org.apache.flink.runtime.rest.messages.taskmanager.LogListInfoTest#getTestResponseInstance

I filled mtime's value and pass these testcase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature?  no

@flinkbot re-run azure

I will rebase on latest master (commit: fc4f2556) to pass the CI check in Azure.
The reason is the master I checkout from (commit: db04af41 ) always failed in org.apache.flink.streaming.connectors.kafka.table.KafkaDynamicTableFactoryTest#testTableSourceWithKeyValueAndMetadata, because the valueDecodingFormat.producedDataType was different between two KafkaSource(one has not null but another one not have). And looks like this problem has been solved by commit 2a582f3.
So I will rebase on laster master to pass the CI

CI check passed again finally after rebase on lastest master (commit: 059c00f4)

Hi @Airblader , I want to know who will merge this pr ?  You or the committer who assigned jira ticket to me?

I'm not a committer, so I don't have the rights to merge this. You'll need to find a committer who can, maybe @tillrohrmann can help with that since he assigned you.

Thank you very much, @Airblader. 😁
And @tillrohrmann, please have a look for this pr, if there is anything I need to continue with, just let me know.

@tillrohrmann I have rebased on latest master (commit: 3262d9b) and add a commit for fixing a coding-style problem

Thanks a lot @ysymi. Merging this PR now.


Galacticats

Your checklist for this pull request
About your game
In my game you have to keep from landing on the same squares as enemies that move based on how you move. You control a space cat who needs to get back to his spaceship.
Use W, A, S, and D to move.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file. Example: sokoban_plus.js -> sokoban_plus.png.

great game! how to solve level 12?

up, right, up, right, up, right, up, left, up, left, up

this error is appearing for me: Uncaught Error: Level must be rect. on line 1430 in column 51. Open the browser console for more information.

Hmm that's odd. What did you do to get that error?

when you go to starship it appears

ok, I'll check it out...

Did that fix it?

fixed!

My dad told me about this challenge so I did it. :)

The "Request a Sprig" form asks for a school photo ID. I'm homeschooled and don't have one, so what should I do?

Oh, nice!

My dad told me about this challenge so I did it. :)

Oh, nice!

The "Request a Sprig" form asks for a school photo ID. I'm homeschooled and don't have one, so could I upload a passport photo and my homeschool registration form instead?

yeah, just prove your age and student status :)

Ok, thanks :D


Use Cabal <IP_ADDRESS> for Haddock build

Target to correct https://github.com/input-output-hk/cardano-node/pull/2406/checks?check_run_id=1973546388

Thanks for the PR.  A similar PR has been merged.  Closing.


Add support for YAML 1.1

Is there any chance you could add support for YAML 1.1 as well?

YAML 1.2 is stricter, if you add support for 1.1 you'd weaken a bunch of guarantees. I found that I missed things like parsing "yes" to true. but you can emulate a bunch of these things relatively easy.


add initContainer for running as non root user

@tmorrisonsfx Could you re-review? thanks!

@tmorrisonsfx Could you re-review? thanks!

Done! Thanks.


Added Run/Debug Test at Cursor to context menu

This PR fixes #130548
Run/Debug Test at Cursor option has been added to the context menu when the user is debugging, passes all provided test suites.
(Made with @martin2469 for University of Michigan EECS 481)

Thanks for the PR! However I think this should go in the options here
https://github.com/microsoft/vscode/blob/66b9a8a460a18a6fd0a249d114ee790d84d48569/src/vs/workbench/contrib/testing/browser/testExplorerActions.ts#L741-L754
You should be able to define a new key menus: [] where the array contains object similar to what you've registered here


⚠ ClamAV has degraded performance

In e47c04e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 224 ms

Resolved: ClamAV performance has improved in 34eaacb.


[TAB-8][TAB-9][TAB-10] Add additional chains to renderer's support chains

[TAB-8] [TAB-9] [TAB-10]
This PR adds support for several chains: Filecoin, Filecoin Hyperspace, Arbirum Nova, and Ethereum Sepolia.
It also fixes an issue whereby Arbitrum Goerli was called Arbitrum Rinkeby.

i don't think we've deployed the registry contract to optimism-kovan or filecoin yet though, right?
https://github.com/tablelandnetwork/evm-tableland/blob/main/network.ts#L48-L67

side note: optimism kovan is deprecated (the validator is no longer listening to events on it)


Fixed #33026 -- Mentioned RequestFactory in testing tools docs.

This PR fixes https://code.djangoproject.com/ticket/33026 by adding an introduction to RequestFactory in testing tools.

@chriswedgwood Thanks :+1: Welcome aboard :boat:


Data import must rawurlencode embedded URL's

This is to prevent embedded iframe loading unnecessarily before user actually opens the embed.

Done.


Research question: To what extent does Verify at LOA1 present a barrier to users?

For less digitally skilled users there was only one viable option to get verified with LOA1 #480

Finding from ConTravel  user research


REAL runtime 60 hours when running on merged detection files without filtering by SNR or agreement number

Want to run timing tests, on say one month of customfiltered data, varying the grid search size.
Other parameters? Suspect:

rsel: tolerance for larger residuals of origin times, default is 4
std0: standard deviation threshold, since REAL finds both the origin time and location at the same time

want to have a program to automatically test REAL for different parameters and quantify:

run time
no. of events
logged outputs (how many suspicious events discarded etc))

This also opens the opportunity to write a more sensible wrapper around REAL, even though it will have a lot of input arguments and honestly that's not that much better
What could help is to have more verbose arguments / write my own documentation after having read the REAL source code?
Honestly C is not easy to read
There will eventually be a need to read the REAL source code to figure out what goes on inside with how it removes `suspicious' events.
Also want to throw in the updated velocity structure, but that's more relevant for hypoDD which I'm not running yet

tl;dr feature request for automated test bench for REAL run time (not sure if over kill but if we'll be using it a lot then it makes sense)

[ ] Runtime scaling as a function of cells (since this will dominate)
[ ] No. of events as a function of criteria (residual, residual tolerance, arrival time uncertainties, no. of picks)
[ ] Shift in locations (per event) as a function of velocity model (use default, or DIY)

https://curc.readthedocs.io/en/latest/programming/OpenMP-C.html
seems to be a need to set the OMP_NUM_THREADS env var in order for multi-processing to work as stated in the paper

yknow in the paper REAL does VELEST before hypoDD which by the way makes complete sense

3m35s for 32 threads
4m9s for 4 threads
5m34s for 1 thread
R = "2.0/60/0.1/5/3/300/2";
$R = "2.0/60/0.1/5/3/300/2";

Should just email the original author to ask about GCarc0 and nxd

real    712m50.723s
jan 2020, ~40k+ phases input
4 OMP threads
total no. of events?


Unexpected AWS Cost Explorer Costs

Describe the bug
After starting to use this mod, I noticed that I'm seeing high usage of AWS Cost Explorer. After some digging, it appears that this module makes on average, 71 requests to the Cost Explorer API, which translates to $0.7/day. For production environments, this is a no-brainer but for testing, I thought that there should have been some type of warning as I left Steampipe running for over a month and got about $24 just from running this. I was running it on an AWS Organizations management account
Steampipe version (steampipe -v)
v0.13.3
Plugin version (steampipe plugin list)
v0.50.1
To reproduce
Expected behavior
It would be great if there was some type of warning related to this or some type of way to set this to only run once a day
Additional context

Thanks @mthbrown for using Steampipe 👍 . Great to see that you are using the AWS Thrifty mod.
I see that you are using the 0.50.1 version of the AWS plugin, Could you please update it to the latest? We had made certain updates to our cost tables in this release.
We will definitely pick this up and see if we can bring about more optimisations around the cost tables 👍

Hey @mthbrown , sorry you ran into some unexpected costs!
In order to better understand your environment to help us improve the query and documentation for these checks, can you please provide some more details around the following:

Are the tracked requests all from one account (assuming yes, but wanted to confirm)?
How are you running Steampipe + the Thrifty checks, i.e., on a local machine, in a container, in a GitHub action, etc.?
How frequently are you running the checks each day or week? Are they running on a schedule, or being manually run?
Has caching been disabled anywhere (it's enabled by default)?
Are you running all Thrifty checks, or just particular ones?
For the full_month_cost_changes control (which is in the cost_explorer benchmark), approximately how many rows do you get in the check results? For instance, in one of my accounts I just tested against, I get 12 rows (services), which is based on which services I've used recently. This information may help us figure out how many requests are being made to the Cost Explorer API.

If there are any additional details you feel may be helpful, please include them as well.
Thanks!

@bigdatasourav Can you please have a look at any controls in this mod that query the AWS Cost Explorer API and track how many API requests each control does? This information will be helpful in determining if our controls and queries are optimized.

@cbruno10 only the full_month_cost_changes control query the AWS Cost Explorer API in this mod. The API request count is dependent on the number of accounts. Per account, the API will hit once.

Thanks @bigdatasourav for confirming!
@mthbrown Based on our testing, it seems like the control only makes one API call per control run, but if you're still experiencing issues, please let us know and also see the questions in https://github.com/turbot/steampipe-mod-aws-thrifty/issues/74#issuecomment-1117824838, which can help us debug further. Thanks!


Cannot access PerplexityAI citations

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
If you call the Perplexity API using the raw requests, you are able to get the list of citations that are now default for perplexity requests.

import requests
import json

# FAPI key
api_key = <<PERPLEXITY_API_KEY>>

# API endpoint
url = "https://api.perplexity.ai/chat/completions"

# Headers for the request
headers = {
    "Authorization": f"Bearer {api_key}",
    "Content-Type": "application/json"
}

# The message to send
message = "What is the capital of France?"

# The data payload
data = {
    "model": "llama-3.1-sonar-small-128k-online",
    "messages": [
        {
            "role": "system",
            "content": "You are a helpful assistant."
        },
        {
            "role": "user",
            "content": message
        }
    ]
}

# Send the POST request
response = requests.post(url, headers=headers, data=json.dumps(data))

# Check if the request was successful
if response.status_code == 200:
    # Parse the JSON response
    result = response.json()

    # Extract and print the assistant's reply
    assistant_reply = result['choices'][0]['message']['content']
    print("Assistant's reply:")
    print(assistant_reply)

    print("Citations:")
    citation_index = 1
    for r in result['citations']:
        print(str(citation_index) + ". " + r)
        citation_index += 1
else:
    print(f"Error: {response.status_code}")
    print(response.text)

However, using langchain the citations appear to be missing (see below example). I have debugged the response output and searched through the documentation but cannot find a way to access these citations. Am I missing something?
from langchain_community.chat_models import ChatPerplexity
from langchain_core.prompts import ChatPromptTemplate

# Initialize the Perplexity AI chat model
PERPLEXITY_API_KEY = "<< Perplexity API Key >>"

# Initialize the Perplexity AI chat model
chat_perplexity = ChatPerplexity(
    model="llama-3.1-sonar-small-128k-online",
    pplx_api_key=PERPLEXITY_API_KEY
)

system = "You are a helpful assistant."
human = "{input}"
prompt = ChatPromptTemplate.from_messages([("system", system), ("human", human)])

chain = prompt | chat_perplexity
response = chain.invoke({"input": "Why is the Higgs Boson important?"})
response.content

# How do I get citations?

Error Message and Stack Trace (if applicable)
Not applicable
Description
I am trying to get the perplexity AI citations from any given request.
System Info
System Information

OS:  Linux
OS Version:  #48-Ubuntu SMP PREEMPT_DYNAMIC Fri Sep 27 14:04:52 UTC 2024
Python Version:  3.9.20 (main, Oct  3 2024, 07:27:41)
[GCC 11.2.0]

Package Information

langchain_core: 0.3.18
langchain: 0.3.7
langchain_community: 0.3.7
langsmith: 0.1.143
langchain_text_splitters: 0.3.2

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.11.0
async-timeout: 4.0.3
dataclasses-json: 0.6.7
httpx: 0.27.2
httpx-sse: 0.4.0
jsonpatch: 1.33
numpy: 1.23.5
orjson: 3.10.11
packaging: 24.1
pydantic: 2.9.2
pydantic-settings: 2.6.1
PyYAML: 6.0.2
requests: 2.32.3
requests-toolbelt: 1.0.0
SQLAlchemy: 2.0.35
tenacity: 9.0.0
typing-extensions: 4.12.2

location of the issue:
looks like https://github.com/langchain-ai/langchain/blob/ef2dc9eae5544ba484ba186ae7c8dba13af56357/libs/community/langchain_community/chat_models/perplexity.py#L264
does not pass the response.model_extra to AIMessage
Proposed Fix:
The line should be updated to something like:
message = AIMessage(content=response.choices[0].message.content, **response.model_extra)
Explanation:
The response variable contains the "citations" in the model_extra dict.
Passing it to AIMessage will set it in its own model_extra dict
Getting the citations after the fix:
citations = response.model_extra.get("citations")


Event Page with Upcoming & Past Events

@Shehanka When can you finish this ?

@Shehanka When can you finish this ?


⚠ BeyondHD has degraded performance

In 788ddd7, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 2083 ms

Resolved: BeyondHD performance has improved in 69b96b9 after 6 minutes.


Second rewrite [V0.3]

The second rewrite of Vinum is getting closer and closer to its official release.
The following items are the features that still need to be written:
1 - A redesign of AbsorbCreator
2 - contribution, github repo minor modification.
3 - documentation

Update: Documentation work will begin after this is merged rather than an item that needs to be finished before merging (hope this makes sense).


Image wrap

When I insert an image and add {.right} it works perfectly on desktop but on mobile it wraps in a wrong way - a small portion of the text comes above the image. Is there a way to fix this?

@trendschau do you get this problem as well?

sorry @zb100 but I lost this issue somehow ...
I tried to reproduce this error but it looks fine on my test installation, so I suppose it is a special combination in your case. Do you have a link for me? And did you add any custom css that might cause this behavior?

No problem at all. The link is here. The only custom CSS I have is this:

/* fonts */
.sans-serif { font-family: -apple-system,BlinkMacSystemFont,"Helvetica",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif; text-rendering: optimizeLegibility; }
.fw4{ font-weight: 400; }
.font-lead{ font-size:1rem; }
.lh-lead { line-height: 1.6rem; }
.font-copy{ font-size: 1rem; }
.lh-copy{ line-height: 1.4rem; }
Cache-Control:public

hm, I stiill cannot reproduce it, I tried with firefox mobile emulator and with my android smartphone. Both looks fine. In some cases/screensizes it might happen that a small portion of the text floats left to the image which does not look nice, but it does not go above the image in my test cases.
Which device do you use for testing?
Maybe it makes sense to set float to none for small screens and to add the float only for larger screens, so something like this in your custom css:
figure.right {
    width: auto;
    float: none;
    margin: auto auto;
}
@media (min-width: 40em) {
	figure.right {
    width: auto;
    float: right;
    margin: 0 0 20px 20px;
}
}

Does it solve your problem? Then I could add it as general solution for the next version

Sorry for the slow reply - and thanks for the support! I am using an iPhone. You are quite right, it does not actually go above the image, it is floating to the left. I should have been clearer. I tried the custom css but the problem persists (probably because I should've said 'floats to the left' as opposed to 'above'). Do you think there's a way to fix this?

Just pinging you @trendschau :)

sorry for the delay, you have that "Cache-Control:public" in your css-style which is not valid css so it breaks the following rule. Can you simply delete that line from your custom css and then check again? For me locally it works wiith exactly the same content.

It works! Thanks a lot :)


Exceptions not caught by base class reference

The try-catch block only matches the exception by the final derived class. Trying to capture an exception by its base class (including the root Exception class) causes the exception to go unhandled.
BDS version: bds 3.2 (build 2021-08-29 12:41), by Pablo Cingolani
Example code that causes the error
class MyException extends Exception { }

try {
    throw new OurException()
} catch(Exception e) {
    println "CATCH: $e"
}

Two-level class hierarchy with the same error
To make sure the issue is unrelated to Exception class being a native one
class MyException extends Exception { }
class OurException extends MyException { }

try {
    throw new OurException()
} catch(MyException e) {
    println "CATCH: $e"
}

Fixed.


Can't initialize locally

Hi there. When searching for a nice looking page template for github pages I found this particle theme. I like it very much. I wanted to set it up locally to play around with the webpage before publishing it. Since now I was not able to set it up. I am experienced with python and docker but not with web development. I tryed to run this in an ubuntu docker container on a windows machine but failed because of errors when running the suggested steps for local setup from the readme (installing nodejs, etc.).
Could you provide a more detailed description on the steps for a local setup (versions of nodejs etc.)? Maybe you have some suggestions to run this in docker?
My error log:
log.txt

Same error here, I made a PR using tsParticles instead of particles.js without compiling it. Since the latest commit is some years old I think the packages need some updates

I think you have to update the dependencies in your package.json.


MOBILE-817 gulp: Added missing dependency

The gulp-insert dependency was missing in package.json.

Whoops, sorry.


View statistics of pipeline's pending requests in a graph view

As a HKube manager I want to be able to view statistics of pipeline's pending requests in a graph view, so that I can analyze the resources allocation mechanism and sizing of system resources over time.
User Story implementation details:

Statistics of pipeline's pending requests means: 50 & 90 percentile of pipeline's pending (state = pending) requests per minute
Each of the statistics information will be calculated separately per pipeline type.
Graph view is detailed in #102

TID-206


Synchronising updates from multiple stores to a single file

When you create multiple stores pointing to the same file, those stores will not know about the updates from each other and can cause stores to be out of sync.

Relates to #124


Question on approach to use ESP32 Devboards and RFM95

This code works very well (indeed, thanks) on Heltec but I can't make it work on a generic DevKitC-v1 ESP32 with external RFM95.  My approach has been to adjust a Lolin-d32 file and get the pin mappings right - so far without success.
Has anyone used this code on ESP32/RFM95 or can you offer an approach to add ESP32 dev module to the list of configured devices?

My approach has been to adjust a Lolin-d32 file and get the pin mappings right

I assume you mean the BSF file here?
What did you adjust and why? What is not working, do you get any errors?
I don't have an Espressif  DevKitC board to test but as far as I can see you should be able to use either lolin32 or lolin_32 as basis.
I2C and SPI pins for these boards are the same. The Lolin boards do have onboard user LED connected to GPIO5 though which in the Arduino BSP is defined SS (SPI chip select, SS/NSS/CS), which is why I used different GPIO's for SPI chip select for these boards.
The DevKitC does not have onboard user LED so you could use the default GPIO5 ('SS') for SPI chip select for the DevKitC as well. However, with the pins defined in the BSF's for lolin32 and lolin_d32 the DevKitC should work just fine as far as I can see.
What I would like to suggest (and possibly could make a difference) is change the value board parameter (in the board specific section) in platformio.ini from lolin_d32 (or lolin32, whichever you want to use and modify) to esp32dev.
Another option may be to change the SPI frequency in the BSF from 8 MHz to 1 MHz, depending on the quality of your wiring/breadboard.
Also disable USE_LED in the board specific section in platformio.ini because the DevKitC board does not have an onboard user LED.
If this does not help you make have to double-check your physical wiring, pin mappings defined in the BSF and whether you have actually selected the proper board-id in platformio.ini (so it uses the BSF that you are assuming).

can you offer an approach to add ESP32 dev module to the list of configured devices?

I could add support for DevKitC but would follow similar steps as described above to add it, so you should at least be able to get your board working with the current version of LMIC-node.
To add it I would need some more information and specifications (e.g. correct full name) though.
I assume that you DevKitC-V1 is an "Espressif DevKitC-V1" board and not a DoIt DevKit V1?
Unfortunately, on the Espressif site I only see reference design documentation for ESP32-DevKitC-V2 and ESP32-DevKitC-V4.

@peterl3233  Please respond.

@peterl3233 No response, so topic closed.

Hi .. Thanks for reply ... I'll look at all this carefully but got sidetracked with a family matter.  I appreciate your response very much.

Thanks. If you find some time and want to continue here, just let me know and I can reopen the issue.

@peterl3233 Did you succeed to get it working?

Hi ... FYI, following your suggestions, I did get this working.  Your code was without error and after I checked all the points you made I dug deeper and eventually found a "flakey" RFM95 module; so it was actually a hardware problem.  After replacing teh RFM95, I use it with ESP32 with RMM95 with an SHT30 sensor on I2c.  Works great on Chirpstack .. I didn't try on TTN.
For interest, here is the pinmap for the Espressive ESP32 Devkit_v4 as connected to RFM95 module:
const lmic_pinmap lmic_pins = {
    .nss = 5,
    .rxtx = LMIC_UNUSED_PIN,
    .rst = 14,
    .dio = { /*dio0*/ 26, /*dio1*/ 33, /*dio2*/ LMIC_UNUSED_PIN }
#ifdef MCCI_LMIC
    ,
    .rxtx_rx_active = 0,
    .rssi_cal = 10,
    .spi_freq = 8000000     /* 8 MHz */
#endif
};

I created a "bsf_ESP32_RFM95.h" file and if you would like, I'll send it to you or post it on github.  Below is the changed (hardly) code block for ESP32_RFM95:
[env:ESP32_RFM95]
; Espressif ESP32 DevKit_v4.
; No display.
; No LED.
platform = espressif32
board = ESP32_RFM95
framework = arduino
upload_speed = 921600
monitor_speed = ${common.monitor_speed}
lib_deps =
   ${common.lib_deps}
   ${mcci_lmic.lib_deps}
build_flags =
   ${common.build_flags}
   ${mcci_lmic.build_flags}
   -D BSFILE=\"boards/bsf_ESP32_RFM95.h\"
   -D MONITOR_SPEED=${common.monitor_speed}
   -D LMIC_PRINTF_TO=Serial
   -D USE_SERIAL
   ; -D USE_LED       ; Not used
   ; -D USE_DISPLAY    ; Not used

Ay chance to see that bsf_ESP32_RFM95.h content anywhere?😀


Extend Client Request error handling

We need to resubmit requests when they weren't succeded due to client errors such as ClientPayloadError, and ClientConnectionError as these could be caused by slow network connection or other unexpected reasons.


Initializer the class related to the gameplay playfield with visual spawner

This PR start the logic on the gameplay and its update logic. Note that this PRs only have only TAP note since I want to make sure on the logic on some bigger picture like Playfield and some new component that just initialize on this PR.
You can play on the spawner using a new test scene on this PR.
Since I want random float number generator with can set max and min so I create itside Utils directory and use it in the test scene.

Pushed a commit to correct some things regarding the RandomFloat class.


Fix wrong export icon

Replaces an incorrect, PF3 download icon with PF4 FileExportIcon.
Fixes https://github.com/project-koku/koku-ui/issues/284

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   91.67%   91.67%
=======================================
  Files         116      116
  Lines        1369     1369
  Branches      165      165
=======================================
  Hits         1255     1255
  Misses         99       99
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e4fec...e098557. Read the comment docs.


google-authenticator prompting to validate OTP after secret generation

ovpn_otp_user currently hangs if used in automation while google-authenticator waits on input from the user. It appears google-authenticator is now prompting to validate OTP codes by default, and the --force flag currently used in ovpn_otp_user does not prevent the validation prompt.

A work-around I found was to SSH into the container directly and run the google-authenticator command that ovpn_otp_user command runs directly. The code for that can be seen by running this command
cat /usr/local/bin/ovpn_otp_user
e.g.
google-authenticator --time-based --disallow-reuse --force --rate-limit=3 --rate-time=30 --window-size=3 -l "$user@company" -s /etc/openvpn/otp/user.google_authenticator

I'm running this as automation in CI. SSH into a container is not an option. Headless mode should be headless.

Try running
  docker exec -v $OVPN_DATA:/etc/openvpn --rm -t kylemanna/openvpn ovpn_otp_user <user> instead of docker run ..
That seemed to fix the issue for us.

Just going through this now, seems the docs (otp.md) simply forgot to add the -i flag
docs have:
docker run -v $OVPN_DATA:/etc/openvpn --rm -t kylemanna/openvpn ovpn_otp_user <user>

should be:
docker run -v $OVPN_DATA:/etc/openvpn --rm -it kylemanna/openvpn ovpn_otp_user <user>

Just going through this now, seems the docs (otp.md) simply forgot to add the -i flag
docs have:
docker run -v $OVPN_DATA:/etc/openvpn --rm -t kylemanna/openvpn ovpn_otp_user <user>

should be:
docker run -v $OVPN_DATA:/etc/openvpn --rm -it kylemanna/openvpn ovpn_otp_user <user>

This does not resolve the issue I reported. I specifically was complaining about the ability to run this without having to interact, while this "fix" is to allow interaction...
That's a completely different issue.
The correct fix to this issue is in my open PR, adding the --no-confim flag to the google-authenticator command when run in "interactive" is NOT requested.
https://github.com/kylemanna/docker-openvpn/pull/500/files


Support for gradient accumulation and mixed precision training

Hi, @davidtvs , this feature request is mentioned in issue #8 .
User now can use AccumualtionLRFinder to find learning rate with mechanism of gradient accumulation.
And I've done some tests to compare the difference of finding learning rate with/without gradient accumulation (in examples/lrfinder_mnist_gradient_accumulation.ipynb), it seems that gradient accumulation works fine with LRFinder.
If there is anything need to be improved, please feel free to let me know.

LGTM. Thanks for the PR, well done @NaleRaphael

It's also my pleasure to work with you! :)


svelte.config.ts – Svelte Config TS Support

Describe the problem
Overview of available config fields currently is only available from docs.
Describe the proposed solution
It would be great if we had build-in Interface, describes all available fields for config file.
Moreover, it would be great if we had build-in support for .ts-file extension for config files.
Alternatives considered
–
Importance
would make my life easier
Additional Information
No response

This interface already exists, and the JSDoc at the top of the file which comes with the starter tepmlates should enable the type hints: /** @type {import('@sveltejs/kit').Config} */ . Adding .ts support for the config files is out of scope since it would require SvelteKit to also install TypeScript or some other form of TS-JS-transpiler for everyone, even if they don't use TS, and it adds additional maintenance overhead for a file that should be pretty simple anyway.

I was also searching for this feature because it is supported with vite:

Vite also directly supports TS config files. You can use vite.config.ts with the defineConfig helper as well.

Not essential but its nice to have, especially when you have local custom svelte preprocessors and vite plugins written in TS.


domLayout and grid height

Hi,
I was not able to figure out how to set domLayout, is it possible? I was also wondering if it makes sense to make height=None behave as domLayout='autoHeight'.
Ghiles

It was indeed broken.
I'm fixing it, and grid should resize when domLayout='autoHeight' or if gridOptionsBuilder.configure_auto_height(True)
I'm also adding the height=None suggestion


Clean up player respawn code

Currently, there are three different methods where we send an SPacketRespawn (four once https://github.com/SpongePowered/SpongeCommon/pull/1926 is merged):

EntityUtil#transferPlayerToDimension
EntityUtil#changeWorld
MixinPlayerList#recreatePlayerEntity

Sending a SPacketRespawn requires sending a slew of other packets, from updating the client weather, to setting the client permission level.
These methods represent an enormous amount of duplicated code. If any one methods falls out of sync with the other, hard-to-reproduce issues like https://github.com/SpongePowered/SpongeCommon/issues/1923 result.
The common code from these methods needs to be factored out, with any deviations from Vanilla's respawn code clearly documented.

This has been sorted out a long time ago. Especially on 1.16.5+


jgroups quickstart is broken

It fails building and installing
[INFO] --- docker-maven-plugin:0.12.0:build (default-cli) @ quickstart-java-jgroups ---
[INFO] Copying files to /Users/davsclaus/workspace/quickstarts/quickstarts/java/jgroups-greeter/target/docker/fabric8/quickstart-java-jgroups/2.2-SNAPSHOT/build/maven
[INFO] Building tar: /Users/davsclaus/workspace/quickstarts/quickstarts/java/jgroups-greeter/target/docker/fabric8/quickstart-java-jgroups/2.2-SNAPSHOT/tmp/docker-build.tar
[INFO] DOCKER> Created image [fabric8/quickstart-java-jgroups:2.2-SNAPSHOT]
[INFO]
[INFO] --- fabric8-maven-plugin:2.1.11:apply (default-cli) @ quickstart-java-jgroups ---
[INFO] Using kubernetes at: https://<IP_ADDRESS>:8443 in namespace default
[INFO] Kubernetes JSON: /Users/davsclaus/workspace/quickstarts/quickstarts/java/jgroups-greeter/target/classes/kubernetes.json
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.075 s
[INFO] Finished at: 2015-06-16T18:56:55+02:00
[INFO] Final Memory: 48M/744M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.fabric8:fabric8-maven-plugin:2.1.11:apply (default-cli) on project quickstart-java-jgroups: No name for io.fabric8.kubernetes.api.model.ReplicationController@7d3fe3aa[apiVersion=v1beta3,kind=ReplicationController,metadata=,spec=,status=,additionalProperties={id=fabric8Greeter, desiredState={replicas=3, replicaSelector={cluster=greeter, container=java}, podTemplate={desiredState={manifest={version=v1beta3, id=fabric8GreeterPod, containers=[{name=fabric8-jgroups-greeter, image=fabric8/quickstart-java-jgroups-greeter:latest, imagePullPolicy=PullAlways, env=[{name=KUBERNETES_TRUST_CERT, value=true}, {name=JAVA_OPTS, value=-Djava.net.preferIPv4Stack=true}], ports=[{name=jgroups-tcp-port, containerPort=7800, protocol=TCP}]}]}}, labels={cluster=greeter, container=java}}}, labels={cluster=greeter, container=java}}] kubernetes.json must be specified -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
davsclaus:~/workspace/quickstarts/quickstarts/java/jgroups-greeter (master)/$

I wonder if we want to keep this? eg I would rather keep a smaller set of quickstarts around the main projects: Camel, ActiveMQ, CXF, etc.
@iocanel the git log tells you added this example. Any thoughts about keeping it or maybe removing it?
Anyone else any thoughts?

with a smaller set of quickstarts we can better maintain them and ensure they works. Also end users do not get confused if there is just too many examples.

This quickstart has been dropped