Can Get-SPOListItem support libraries larger than 5k?

In regards to getting all list items, is there any other interest in enhancing this script to use batching via CSOM instead of CAML queries so that we can circumvent the 5k limitation enforced by the O365 list view threshold?
Otherwise, we're on our own custom writing some powershell to do just that.

Nevermind, we got around this by making an appropriate CAML query and just grabbing batches.  Here's an example of our script getting a 5k+ list in batches and then updating various fields on each item:
$count = 2
$query = "<View><Query><Where><And><Leq><FieldRef Name='ID'/><Value Type='Number'>" + $count + "</Value></Leq><Gt><FieldRef Name='ID'/><Value Type='Number'>" + ($count - 2) + "</Value></Gt></And></Where><OrderBy Override='TRUE'><FieldRef Name='ID'/></OrderBy></Query><RowLimit>100</RowLimit></View>"

while ($count -le 7000) {
	$listItems = Get-SPOListItem -List DocumentTesting -Fields "Filtzor","Filtzor2","Filtzor3" -Query $query
	if ($listItems -eq $null -Or $listItems -eq '' -Or $listItems.Length -eq 0) {
		Write-Host "No items exist in this range"
	}
	foreach($item in $listItems) {
		$itemId = $item["ID"]
		Try {
			$thing = $item["Filtzor"].LookupId
			$string = "-"
			foreach($id in $thing) {
				$string = $string + $id + '-'
			}

			$thing2 = $item["Filtzor2"].LookupId
			$string2 = "-"
			foreach($id2 in $thing2) {
				$string2 = $string2 + $id2 + '-'
			}

			$thing3 = $item["Filtzor3"].LookupId
			$string3 = "-"
			foreach($id3 in $thing3) {
				$string3 = $string3 + $id3 + '-'
			}

			Set-SPOListItem -List DocumentTesting -Identity $item -Values @{"FiltzorString" = $string;"Filtzor2String" = $string2;"Filtzor3String" = $string3}
			if (!$?) {
				throw $error[0].Exception
			} else {
				$itemToLog = $(Get-Date -Format o) + " - " + $itemId + " was updated."
				Add-Content c:\users\s_spinstall\desktop\testOutput.txt $itemToLog
			}
		} Catch {
			$itemError = $(Get-Date -Format o) + " - " + $itemId + ": " + $error[0]
			Add-Content c:\users\s_spinstall\desktop\testOutput.txt $itemError
		}
	}
	$count = $count + 2
	$query = "<View><Query><Where><And><Leq><FieldRef Name='ID'/><Value Type='Number'>" + $count + "</Value></Leq><Gt><FieldRef Name='ID'/><Value Type='Number'>" + ($count - 2) + "</Value></Gt></And></Where><OrderBy Override='TRUE'><FieldRef Name='ID'/></OrderBy></Query><RowLimit>100</RowLimit></View>"
}

Unfortunately it is still a pretty slow operation for a large list.  At ~3 seconds per update, it's going to take about 5 hours to update our ~6k library in our Production environment.  For our use case, we need the application running and usable the whole time - so during that 5 hour period users are going to see some weirdness.
Any other method/way of speeding this operation up?

I've added paging support in #381 which will hopefully make it in to the next release. I suspect most of your slowness is updating individual items via Set-SPOListItem rather than paging through the list, and the best way to deal with that is probably to batch your updates via CSOM instead of using Set-SPOListItem directly.

I merged PR 381 which allows this, and also the solution as mentioned above works. I will close this issue.


Add a passwd field to Group

Adds a passwd field to unistd::Group. The gr_passwd field exists on libc::group and wasn't exposed.
I didn't see tests for from(libc:group) for either User or Password. Let me know if there are other tests I should add!

I haven't actually seen it used either, but I'm working on a backend to nscd and glibc seems to expect a group password as part of the response.
Given that passwd is mentioned in the man page, is there a reason to not include it here?

@asomers given this any more thought?

@asomers given this any more thought?

Yes, I think it seems reasonable.  But could you add a CHANGELOG entry and rebase?

Yes, I think it seems reasonable.  But could you add a CHANGELOG entry and rebase?

Done! Sorry for the delay.


admiral 1.1 blog post

@bms63 I have started  this in branch 167_admiral_1.1 - please feel free to take a look, modify and add missing sections.


websocket handler for raster streams

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

 Raster Tile Stream nach Python

bors  merge


wct-st closes the tunnel immediately after opening.

I'm using 6.0.0-prerelease.5. FWIW, commenting out the process.exit(0) call in this line seems to keep the tunnel open but I have no idea if that's a safe / correct fix.

I think this is fixed or maybe something was wrong specifically with my setup. Either way, I can't repro anymore.


Get Kyle set up with Google Integration

As a developer, I want to make sure that my project aligns with my clients needs so that he is satisfied.

Written Tutorial


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for AME onboarding.
[x] Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Hi @sri- you have a breaking change in this spec https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json#L3331 . Seems like it's a mistake?

Hi @sri- you have a breaking change in this spec https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json#L3331 . Seems like it's a mistake in old spec? The default value looks like description

Yeah it is a bug in the old spec.

@akning-ms Please help to merge this PR with breaking change that fix the bug.


Bootstrap 4 integration

Hello there, it would be also super cool if you guys had also a bootstrap integration example

I created a branch with Bootstrap4 in it :) https://github.com/alicoding/react-webpack-babel/tree/bootstrap4 give it a shot and let me know.

This is cool! And yes looks like it works on the dev side. But the built version does not.
:)


PDO: Added PDO::FETCH_CLASS support on fetch*(), fetchObject()

refs https://github.com/staabm/phpstan-dba/issues/269

@Seldaek could you double check this one matches your expectations?


Offline install flatpak

how to install this on a offline linux ?
i tried very hard to install this with all the obscure create-usb or create bundle from flatpak and like nothing work at all (centos8 flatpak 1.6)
it will be wondeful if we can have an  appimage

You can download the package for x86 from here: https://github.com/Murmele/Gittyup/releases/tag/gittyup_v1.2.2

thanks but my problem is the flatpak dependecies , i d'ont sucessd to make a true offline package

@moolight-seashell, https://www.reddit.com/r/linuxquestions/comments/ada0gl/comment/edf3gat/?utm_source=share&utm_medium=web2x&context=3

You can also try the appimage: https://github.com/Murmele/Gittyup/pull/579


Update nf-winusb-winusb_stoptrackingfortimesync.md

Fix obvious typo

@emild : Thanks for your contribution! The author(s) have been notified to review your proposed change.

thanks!


Retag existing image instead of building image without additional layers

Closes https://github.com/abcxyz/github-metrics-aggregator/pull/262

Sigh https://github.com/apache/beam/pull/31010

Sigh apache/beam#31010

Is it time to give up on Beam and just build some simple cloud run jobs for our pipelines? We aren't doing anything fancy and we've only ever had one customer look at them as a reference.

Is it time to give up on Beam and just build some simple cloud run jobs for our pipelines? We aren't doing anything fancy and we've only ever had one customer look at them as a reference.

I was ready to give up on day 1, but yes. I think we should give up on Beam and use Cloud Run jobs instead. Any performance benefit we're getting using Beam is outweighed by lost engineering cycles.


Create the structure for the documentation

[x] find a good structure
[x] integrate into git
[x] decide on a docstring type: REFT
[ ] make available (for example via PdF or website)

just for reference might want to have this in mind https://mpastell.com/pweave/index.html


Installation documentation: more detaisl about virtualenv

Explain and give examples on how to setup virtualenv.

Covered by:
https://github.com/NLeSC/pycoeman/commit/6a23f2bb5c89cef334349f902a0fa7d6f4e2d2e5

Done by
https://github.com/NLeSC/pycoeman/pull/10


Add TerraGoat

TerraGoat was announced on medium as a vulnerable by design Terraform project. Looks like it would be a good addition here.

Cool, thanks @bnugent! I missed that one. I also added badges.


[BP-1.14][FLINK-26105][e2e] Fixes log file extension

1.14 backport of PR #18806 by just cherry-picking the changes:
git cherry-pick 92faffa858c1fdd469eaf6c52d4fa14d90d4d09d a88a666ad794a66b8007cec3c34a34a3d1cb866f

@flinkbot run azure


Earn app prep

Description
[Provide a brief description of the changes in this PR]
Changes

removed unnecessary stuff which was in repo due to copy/paste approach

Benefits

[List the benefits of these changes]

Testing
[Describe how these changes were tested or how they can be tested]
Next steps

[List any follow-up actions or considerations]

Additional Notes
[Any additional information, context, or notes for reviewers]
Please review and provide any feedback or suggestions for improvement.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.52%. Comparing base (55a05a5) to head (35d16e6).

:exclamation:  There is a different number of reports uploaded between BASE (55a05a5) and HEAD (35d16e6). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (55a05a5)
HEAD (35d16e6)

2
1

Additional details and impacted files
@@                        Coverage Diff                         @@
##           marcinciarka/update-turbo-2.1     #514       +/-   ##
==================================================================
- Coverage                          83.11%   70.52%   -12.60%
==================================================================
  Files                                291      129      -162
  Lines                               2967     1357     -1610
  Branches                             178       78      -100
==================================================================
- Hits                                2466      957     -1509
+ Misses                               490      400       -90
+ Partials                              11        0       -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


README.md is misleading about license

Your LICENSE file says it is under the MIT license, but your README.md file says it is under the CC0 license. Did you forget to edit it?

(Apparently Github didn't notify me about issues created) I did forget to change the readme, thanks!

(Apparently Github didn't notify me about issues created) I did forget to change the readme, thanks!


Exception "$slice value must be an integer"

Hi,
I am using the nuget package v0.5.11 to work with an Azure MongoDb (Aggregation is enabled).
My project is using .Net Core 2.1.
Code compiles ok and the application starts. hangfire dashboard is loaded without issue but I get the following excpetion when I click on "Recurring Jobs".
MongoDB.Driver.MongoCommandException: Command find failed: $slice value must be integer.
   at MongoDB.Driver.Core.WireProtocol.CommandUsingQueryMessageWireProtocol`1.ProcessReply(ConnectionId connectionId, ReplyMessage`1 reply)
   at MongoDB.Driver.Core.WireProtocol.CommandUsingQueryMessageWireProtocol`1.Execute(IConnection connection, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.WireProtocol.CommandWireProtocol`1.Execute(IConnection connection, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Servers.Server.ServerChannel.ExecuteProtocol[TResult](IWireProtocol`1 protocol, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Servers.Server.ServerChannel.Command[TResult](ICoreSession session, ReadPreference readPreference, DatabaseNamespace databaseNamespace, BsonDocument command, IEnumerable`1 commandPayloads, IElementNameValidator commandValidator, BsonDocument additionalOptions, Action`1 postWriteAction, CommandResponseHandling responseHandling, IBsonSerializer`1 resultSerializer, MessageEncoderSettings messageEncoderSettings, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Operations.CommandOperationBase`1.ExecuteProtocol(IChannelHandle channel, ICoreSessionHandle session, ReadPreference readPreference, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Operations.CommandOperationBase`1.ExecuteProtocol(IChannelSource channelSource, ICoreSessionHandle session, ReadPreference readPreference, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Operations.ReadCommandOperation`1.Execute(IReadBinding binding, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Operations.FindCommandOperation`1.Execute(IReadBinding binding, CancellationToken cancellationToken)
   at MongoDB.Driver.Core.Operations.FindOperation`1.Execute(IReadBinding binding, CancellationToken cancellationToken)
   at MongoDB.Driver.OperationExecutor.ExecuteReadOperation[TResult](IReadBinding binding, IReadOperation`1 operation, CancellationToken cancellationToken)
   at MongoDB.Driver.MongoCollectionImpl`1.ExecuteReadOperation[TResult](IClientSessionHandle session, IReadOperation`1 operation, ReadPreference readPreference, CancellationToken cancellationToken)
   at MongoDB.Driver.MongoCollectionImpl`1.ExecuteReadOperation[TResult](IClientSessionHandle session, IReadOperation`1 operation, CancellationToken cancellationToken)
   at MongoDB.Driver.MongoCollectionImpl`1.FindSync[TProjection](IClientSessionHandle session, FilterDefinition`1 filter, FindOptions`2 options, CancellationToken cancellationToken)
   at MongoDB.Driver.MongoCollectionImpl`1.<>c__DisplayClass41_0`1.<FindSync>b__0(IClientSessionHandle session)
   at MongoDB.Driver.MongoCollectionImpl`1.UsingImplicitSession[TResult](Func`2 func, CancellationToken cancellationToken)
   at MongoDB.Driver.MongoCollectionImpl`1.FindSync[TProjection](FilterDefinition`1 filter, FindOptions`2 options, CancellationToken cancellationToken)
   at MongoDB.Driver.FindFluent`2.ToCursor(CancellationToken cancellationToken)
   at MongoDB.Driver.IAsyncCursorSourceExtensions.FirstOrDefault[TDocument](IAsyncCursorSource`1 source, CancellationToken cancellationToken)
   at MongoDB.Driver.IFindFluentExtensions.FirstOrDefault[TDocument,TProjection](IFindFluent`2 find, CancellationToken cancellationToken)
   at Hangfire.Mongo.MongoConnection.GetStateData(String jobId)
   at Hangfire.Storage.StorageConnectionExtensions.GetRecurringJobDtos(IStorageConnection connection, IEnumerable`1 ids)
   at Hangfire.Dashboard.Pages.RecurringJobsPage.Execute()
   at Hangfire.Dashboard.RazorPage.TransformText(String body)
   at Hangfire.Dashboard.RazorPageDispatcher.Dispatch(DashboardContext context)
   at Hangfire.Dashboard.AspNetCoreDashboardMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Server.IISIntegration.IISMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request finished in 198.5639ms 500
Failed to load resource: the server responded with a status of 500 (Internal Server Error)

I don't know if I am doing something wrong here but I had a look at the code an I located the issue in the following lines. I seems like there is a but when using Slice() in my case. It might not be fixable in this project but could you have a look please? Maybe there is a workaround. Thank you!
var projection = Builders<JobDto>
    .Projection
    .Include(j => j.StateHistory)
    .Slice(j => j.StateHistory, -1);

var latest = Database
    .JobGraph
    .OfType<JobDto>()
    .Find(j => j.Id == ObjectId.Parse(jobId))
    .Project(projection)
    .FirstOrDefault();

@gottscj,
I am not sure I can find the version, I just know that it is the Azure Cosmos DB.
I will install a local MongoDb and see if I can replicate this. Maybe this is only an issue with the Azure Cosmos DB. I will let you know.
Thanks

I don't have the problem with local instance of MongoDb.
C

@Djiu13,
Glad to hear it!
We changed it to a simpler query, which it seems, Cosmos DB supoprts


Sandbox entitlements error ITMS-90296

I  am having problems submitting my app to the app store. Where I am running into an error is sandbox not being enabled. I am adding entitlements when I sign the app, but apparently it is not working.
This is the error that is coming up.
ERROR ITMS-90296: "App sandbox not enabled. The following executables must include the "com.apple.security.app-sandbox" entitlement with a Boolean value of true in the entitlements property list: [( "com.site.app.pkg/Payload/App.app/Contents/Frameworks/App Helper EH.app/Contents/MacOS/QuizzUmmah Helper EH", "com.site.app.pkg/Payload/App.app/Contents/Frameworks/App Helper NP.app/Contents/MacOS/App Helper NP", "com.site.app.pkg/Payload/App.app/Contents/Frameworks/App Helper.app/Contents/MacOS/App Helper", "com.site.app.pkg/Payload/App.app/Contents/MacOS/App" )] Refer to App Sandbox page at https://developer.apple.com/devcenter/mac/app-sandbox/ for more information on sandboxing your app."

Here are my 2 entitlements:
Parent:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>com.apple.security.app-sandbox</key>
    <true/>
    <key>com.apple.security.application-groups</key>
    <string>'My team id'.com.site.app</string>
  </dict>
</plist>

child:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>com.apple.security.app-sandbox</key>
    <true/>
    <key>com.apple.security.inherit</key>
    <true/>
  </dict>
</plist>

And my build script:
 electron-packager . App --identity='3rd Party Mac Developer Application: 'Company' ('My team Id')' --sign-entitlements='./entitlements.mas' --sign-entitlements-inherit='./inherit.entitlements.mas' --osx-sign --app-version='1.0.0' --build-version='1.0.100' --platform=mas --app-bundle-id='com.site.app' --helper-bundle-id='com.site.app.helper' app-category-type=public.app-category.games --arch=all --icon=icon.icns --overwrite --asar",

Please help i am in dire need lol

@AhadCove Hi, Could you please post the solution?

@jay0lu I believe the issue goes from setting up a proper signing command. Please check https://mintkit.net/electron-userland/electron-osx-sign/guide/ for more details if you are working with electron-packager and wanting to have electron-osx-sign enabled.

@sethlu Thanks for the reply. I'm using electron-forge to sign and package the app.
`#!/bin/bash
Name of your app.
APP="app name"
The path of your app to sign.
APP_PATH="./out/app name.app"
The path to the location you want to put the signed package.
RESULT_PATH="./macSign/$APP.pkg"
The name of certificates you requested.
APP_KEY="3rd Party Mac Developer Application: XXX"
INSTALLER_KEY="3rd Party Mac Developer Installer: XXX"
The path of your plist files.
CHILD_PLIST="./child.plist"
PARENT_PLIST="./parent.plist"
FRAMEWORKS_PATH="$APP_PATH/Contents/Frameworks"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/Electron Framework.framework/Versions/A/Electron Framework"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/Electron Framework.framework/Versions/A/Libraries/libnode.dylib"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/Electron Framework.framework"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper.app/Contents/MacOS/$APP Helper"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper.app/"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper EH.app/Contents/MacOS/$APP Helper EH"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper EH.app/"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper NP.app/Contents/MacOS/$APP Helper NP"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$FRAMEWORKS_PATH/$APP Helper NP.app/"
codesign -s "$APP_KEY" -f --entitlements "$CHILD_PLIST" "$APP_PATH/Contents/MacOS/$APP"
codesign -s "$APP_KEY" -f --entitlements "$PARENT_PLIST" "$APP_PATH"
productbuild --component "$APP_PATH" /Applications --sign "$INSTALLER_KEY" "$RESULT_PATH"My parent.plist is

com.apple.security.app-sandbox

com.apple.security.network.client

com.apple.security.network.server

com.apple.security.assets.pictures.read-write

com.apple.security.device.audio-video-bridging

com.apple.security.device.camera

com.apple.security.device.audio-input

com.apple.security.application-groups
XXX.XXX

`
My child.plist is
`

com.apple.security.app-sandbox

com.apple.security.inherit

`
And changed the info.plist as [document](https://electron.atom.io/docs/tutorial/mac-app-store-submission-guide/) said.
Then I got ERROR ITMS-90296: "App sandbox not enabled." when I submit to apple.
Any idea where I'm wrong?
Thanks.

@jay0lu I'm not sure where caused the issue from the settings. I'd recommend checking out https://mintkit.net/electron-userland/electron-osx-sign/guide/ and it should generate a signing script with electron-osx-sign for you, which can hopefully be less error-prone.
Also, you may export DEBUG=electron-osx-sign* (with the asterisk) when signing the app so electron-osx-sign will print out some useful debug log.

com.apple.security.application-groups should be specified as an array I believe.

Did anybody find the solution for this?

Any news?


Erasing a local devfile is not enough to reset odo

/kind bug
What versions of software are you using?
Operating System: macOS 10.15.4
Output of odo version:
odo v1.2.0 (e1232ad1a)
Server:
Kubernetes: v1.11.0+d4cacc0
How did you run odo exactly?

odo component create maven
Realize that I actually wanted another component type
odo component create java-spring-boot
Get an error: ✗  This directory already contains a devfile.yaml, please delete it and run the component creation command again
So follow the instructions and delete devfile.yaml
odo component create java-spring-boot:

Experimental mode is enabled, use at your own risk

Validation
 ✓  Checking devfile compatibility [14ms]
 ✗  Validating devfile component [114030ns]
 ✗  This workspace directory already contains a devfile component

Actual behavior
See above.
Expected behavior
Be able to create my component the second time around without issue. At least, provide a better error message that would allow a user to fix the issue.
Any logs, error output, etc?

4. Get an error: ✗  This directory already contains a devfile.yaml, please delete it and run the component creation command again

can you try odo delete at this stage? and if that works then we just need to reword the error message

The workaround is rm -r .odo devfile.yaml.
This is a pretty bad experience we need to do something with  odo delete command

/priority high

Doesn’t odo delete actually remove .odo folder?

Doesn’t odo delete actually remove .odo folder?

nope, and also odo delete doesn't work when the component was not pushed :-(

TODO:
- [ ] update the error message ✗ This directory already contains a devfile.yaml, please delete it and run the component creation command again to say ✗ This directory already contains a devfile component. You can delete it using odo delete -a command  and run the component creation command again`

[ ] odo delete should work even if the component was not pushed, and it should delete only .env folder
odo delete -a  should work even if the component was not pushed, and it should delete both .env folder and devfile.yaml
[ ] update help message for odo delete command

odo delete --all removes the .odo folder even when the component is not pushed.
[mrinaldas@localhost che-nodejs]$ odo create nodejs
Experimental mode is enabled, use at your own risk

Validation
 ✓  Checking devfile compatibility [108020ns]
 ✓  Validating devfile component [393139ns]

Please use `odo push` command to create the component with source deployed
[mrinaldas@localhost che-nodejs]$ odo delete -f --all
I0507 21:40:11.605355   28131 cert_rotation.go:137] Starting client certificate rotation controller
 ✗  Deleting devfile component nodejs [1ms]
 ✗  error occurred while deleting component, cause: the component nodejs doesn't exist on the cluster
 ✓  Successfully deleted env file
[mrinaldas@localhost che-nodejs]$ ls -a
.   app           .git        LICENSE       package.json       README.md
..  devfile.yaml  .gitignore  node_modules  package-lock.json  .vscode

In the issue we decided not to remove the devfile.yaml https://github.com/openshift/odo/issues/2591#issuecomment-602685412. Maybe we can update odo delete all to delete the devfile too?
+1 for updating the error message though.

odo delete shouldn't cause an error if the component isn't pushed. At worse, it should be a warning but it shouldn't be an error to not have to erase anything on the cluster :)

Also, a user shouldn't have to care about an env directory that they never asked to create: this is an internal mechanism to odo that shouldn't surface in user operations, in my opinion.

* `odo delete -a ` should work even if the component was not pushed, and it should delete both `.env` folder and devfile.yaml

@kadel I am not sure if we should delete the devfile.yaml for the user as part of the odo delete -a command or should we require the user to manually delete the devfile.yaml.  Consider the scenario that developer A has developed an app and check into git together with a customized devfile.yaml. Then, developer B clone that app git repo and use odo to continue to do the development. After developer B is done with the component, if developer B do odo delete -a, we'll be removing the devfile.yaml that is not even created by odo.  Should we consider the devfile.yaml as part of the application resource and let the user handle the lifecycle of that?

I think that odo create and odo delete have different definitions to determine if the pwd is a component directory. I opened #3155 for the same. I think this issue is also pointing to the same.

odo delete -a does not need component to be present to delete the .ododir. But agree that it should be not throw an err and maybe just a warning to say no component was present and proceed to prompt if env should be deleted.
I also think we should not delete the devfile.yaml with odo delete -a since we can create a component odo create nodejs for example, with an existing devfile.yaml in current dir.
I can take a look at this
/assign

I also think we should not delete the devfile.yaml with odo delete -a since we can create a component odo create nodejs for example, with an existing devfile.yaml in current dir.
If we really want to delete devfile.yaml with odo delete -a, the alternative would be to prompt a question and ask if the devfile.yaml should be deleted.

Agreed with the second part, odo delete --all should definitely prompt for confirmation, the same as it is currently asking when running odo delete. Only when --force flag is provided the prompt should be skipped.

@kadel I am not sure if we should delete the devfile.yaml for the user as part of the odo delete -a command or should we require the user to manually delete the devfile.yaml. Consider the scenario that developer A has developed an app and check into git together with a customized devfile.yaml. Then, developer B clone that app git repo and use odo to continue to do the development. After developer B is done with the component, if developer B do odo delete -a, we'll be removing the devfile.yaml that is not even created by odo. Should we consider the devfile.yaml as part of the application resource and let the user handle the lifecycle of that?

Hmm, that also makes sense.
But what about this scenario:

I create new odo component odo create
I realized that I wanted to do something else
I run odo delete --all with the assumption that it will delete everything that odo created after all the flag is called all (but in this case it will keep devfile.yaml)
I run odo create again and it fails :-(

I think that if we are clear about what the odo delete -a does it should be ok, after all, it is not a default delete strategy users will need to provide additional flag, and they will be asked to confirm.
If odo is creating devfile with  odo create there should be also a variation of odo delete command to completely clean what odo created.
What about this?

odo delete

should delete what was created in the cluster and keep .odo and devfile.yaml in place
if the component was not pushed yet (nothing was created in the cluster) it should just print information that there is nothing in the cluster. No error should be thrown.
should ask the user for confirmation unless executed with -f flag
the output should contain information that this is just deleting resources from the cluster

odo delete --all

should delete everything form cluster as odo delete does
in addition to deleting resources from the cluster, it should also  delete .odo and devfile.yaml
should ask the user for confirmation unless executed with -f flag
confirmation will have three stages.

"Do you want to delete all resources related to this component from the cluster?  (Y/n)"
"Do you want to delete local configuration in .odo directory?  (Y/n)"
"Do you want to delete devfile.yaml from the current directory?  (Y/n)"

This would make odo delete is an inversion of odo push and odo delete --all inversion of odo create; odo push and the user will always have a choice to decide what to delete.
What do you think?

All of this makes sense :)
However, reading through the different scenarios makes me think that odo should keep track of the files it created and should only be able to delete these files and nothing else. It doesn't seem right that odo should be able to delete files it knows nothing about.
Which brings me to another usage question: is it expected that users will need to edit devfiles often? It seems to me that they should be implementation details that shouldn't really be touched all that often by users.

This would make odo delete is an inversion of odo push and odo delete --all inversion of odo create; odo push and the user will always have a choice to decide what to delete.

This proposal sounds good to me. We have an explicit prompt for devfile.yam removal which will address my main concern.

Which brings me to another usage question: is it expected that users will need to edit devfiles often? It seems to me that they should be implementation details that shouldn't really be touched all that often by users.

I think the key point is not really on whether they touch it often; it is whether we expect user to change it or not. We do expect user to change it since there may be specific changes that they need on the devfile to fit their specific application, e.g. I need to have this env variable setup on my container, I use my own custom image for my container in order for my app to work, etc.. If we try to track what is created by odo or not, I am worry that we'll start to complicate it too much. I'd prefer the more simple approach on prompting that @kadel suggested.

Which brings me to another usage question: is it expected that users will need to edit devfiles often? It seems to me that they should be implementation details that shouldn't really be touched all that often by users.

I think the key point is not really on whether they touch it often; it is whether we expect user to change it or not. We do expect user to change it since there may be specific changes that they need on the devfile to fit their specific application, e.g. I need to have this env variable setup on my container, I use my own custom image for my container in order for my app to work, etc.. If we try to track what is created by odo or not, I am worry that we'll start to complicate it too much. I'd prefer the more simple approach on prompting that @kadel suggested.

Wouldn't that be done by extending the devfile instead of modifying it directly?

Which brings me to another usage question: is it expected that users will need to edit devfiles often? It seems to me that they should be implementation details that shouldn't really be touched all that often by users.

I think the key point is not really on whether they touch it often; it is whether we expect user to change it or not. We do expect user to change it since there may be specific changes that they need on the devfile to fit their specific application, e.g. I need to have this env variable setup on my container, I use my own custom image for my container in order for my app to work, etc.. If we try to track what is created by odo or not, I am worry that we'll start to complicate it too much. I'd prefer the more simple approach on prompting that @kadel suggested.

Wouldn't that be done by extending the devfile instead of modifying it directly?

@metacosm Wdym by extending devfile instead of modifying it? 🤔

Wouldn't that be done by extending the devfile instead of modifying it directly?

@metacosm Wdym by extending devfile instead of modifying it? 🤔

Using devfile 2, wouldn't one extend a devfile instead of checking it out and then changing it? I.e. if I want to change some parameters in a devfile, would I be better served extending that devfile and overriding the value I want instead of creating a whole new copy of the devfile (which I then would need to maintain) just to change one parameter?


Value-based Comparator

For applications that need to sort documents a variety of ways, consider
implementing a ValueComparator interface.  It would be functionally similar to
the existing Comparator, except it would evaluate values rather than keys.

Presently, in order to provide a sort-and-page user interface, I am pulling the
full set of documents, sorting them on the client side, and then selecting the
subset composing the requested page.

A ValueComparator would allow the servers to process a sort operation to be
followed by a ranged Get.  This would reduce the network utilization of my
sort-and-page UI.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 21 Feb 2011 at 1:25

I was thinking about this, and there fundamentally are two ways to implement it:

1) Provide a ValueComparator to be used *instead* of the key comparator for
range selection: by doing so, we'd need to broadcast the range operation to
*all* nodes, rather than a subset of nodes as we do now, because no node have
knowledge of all data in the cluster.

2) Provide a ValueComparator to be used *after* the key comparator: that is,
the new comparator would sort only those documents retrieved by the key-based
range query, and as a consequence, the comparator would only affect sorting,
not range querying.

That said, I think #1 would cause too much network traffic and probably
unnecessary CPU work by all those nodes queried without actually having any
document of interest. Indeed, #1 should be properly implemented with
distributed indexes, but that's a completely different issue and right now we
have ElasticSearch integration for that.

So I think #2 should be the way to go: would that work for you? Do you need any
clarifications?

Other thoughts from the committers crew?

Original comment by<EMAIL_ADDRESS>on 21 Feb 2011 at 6:20

Added labels: Type-Feature, Priority-Medium, Project-Terrastore

My use case is to sort a list of documents by an essentially arbitrary
attribute and then limit the results by an offset and count (user interface
sorting and "paging").  If I understand your proposal correctly, I suspect that
option #2 does not address my need because I would first need to constrain the
space of documents to a key range.

That said, I'm interested in understanding option #2 better.  Can you explain
it with a potential use case?

Original comment by<EMAIL_ADDRESS>on 21 Feb 2011 at 6:31

I'd just like to share the notion that this sounds like a completely different
operation than range queries, which I assume that this is a proposed extension
of?
That holds true especially in the absence of a key comparator in a query.

As you already hinted at, Sergio, this is more of a search operation and for it
to make sense it would have to use an existing index.

Original comment by<EMAIL_ADDRESS>on 21 Feb 2011 at 9:00

> I suspect that option #2 does not address my need because I would first need
to constrain the space of documents to a key range.

Correct.

> That said, I'm interested in understanding option #2 better.  Can you explain
it with a potential use case?

I was thinking your use case were to query for documents with a given id/key
range (and optionally a predicate) and then sort by a given attribute.
In other words, the fundamental difference between the two approaches is what
you query for: if you can query for the id, filter by predicate, and then do
the sorting, option #2 fits it; otherwise, if you cannot constrain your key
range, #2 doesn't fit.
In my experience, many use cases can actually put boundaries to key ranges by
just arranging the algorithm as follows:
1) Query from startKey=1 with limit=10 and predicate=X.
2) Optionally sort (how doesn't really matter here).
3) Take the last returned key and repeat by using it as new startKey.
The trick is to advance the start key and use the predicate to select the
attribute you're looking for (and possibly the one you want to sort).

Does that help?

Original comment by<EMAIL_ADDRESS>on 21 Feb 2011 at 6:45

> I'd just like to share the notion that this sounds like a completely
different operation than range queries

It depends on how the user actually sees it, that's why I asked: is it a search
by attribute, or a filtered range query sorted on the attribute?

Surely, a distributed index would probably be the best solution to the problem,
but that's a whole different story :)

Original comment by<EMAIL_ADDRESS>on 21 Feb 2011 at 9:08


example.js should look like this:

var ReactDOM = require('react-dom');
ReactDOM.render(
........
);
anyway, very cool application!
appreciate it!!!
thanks for all of you!

Addressed in PR #98.

This should be closed.


Feature/workspace

New Design Changes in Footer, Sign in, Sign up and About pages.

This was raised in correctly


Add Croatian Language Pack

Added Croatian language pack:
added file:
modules/blox-tailwind/i18n/hr.yaml
modified file:
modules/blox-tailwind/data/languages.yaml

@dajakus thanks for contributing to open source :)


Add a new metric for retries separately than the spark_app_failure_count

Separate the spark_app_failure_count metric to "failed sparkapp" and "retries of sparkapp"
As Im monitoring my scheduled spark applications, I'v noticed that there is no separation between:

Spark application that failed completely, meaning its final status is FAILED
failed submit, which after a retry, completed successfully.

Currently, the metric spark_app_failure_count increments on each failed event, including retries,
which doesn't allow to monitor retries and failed jobs separately.
I think that retries is something that is really important to monitor, since it points on something that is wrong in my job,
but it shouldn't be monitored together with failed jobs, but in a separated metric.
By having two separated metrics, we will be able to monitor failed jobs that their final status is 'FAILED',
and to monitor retries which can tell us that something is wrong, but still allow the job to complete successfully.
spark_app_executor_failure_count metric increments also when the sparkapp completed successfully:
Since Im using spot instances, and my nodes are running in auto scaling groups, it can take some time until all of the executor pods get their machines. Because of that, some pods may take a bit longer than the others to go up, and in the meantime, the pods that already started, are executing the tasks. Until all of the pods are going up, the spark application is completed, and the driver's temp svc is deleted.
Then the rest of the executors that took longer to start, cant find the driver's svc, and the metric of the 'executors_failed' is incremented.
I think that the 'executors failed' shouldn't be incremented if the spark application was completed successfully,
and should be incremented only when the spark application is failing and cant be completed because of that.
This will tell us that there is an actual error in the executors, which actually prevents from the spark job to be completed.
Add a reason label to "spark_app_failure_count" metric
Currently, Im seeing the spark_app_failure_count count increments either when the driver is failing, the excutors are failing to complete their task, and retries. So if I want to get an alert on a failed sparkapplication, I need to dive in and look for the the reason of the alert, to check the driver pod, the executors pods.
I think it will be very helpful to see the reason as part of the metric labels.

Updated the issue, added two additional metrics issues


Support caching datetime difference for xml authentication

[ ] make a GetSystemDateAndTime request and cache the offset if xml_auth has a security header error
[ ] use cached offset in subsequent requests as the created at time

Fixed in 482d5aaafef78a75f16b2d7fd615028fe3193156


GLES2 shader compile error on Android

Godot version:

3.1.dev c7dc066dc180149652006e86f07765e5326f324b
OS/device including version:

Galaxy S8+ / Android 8.0
Issue description:

I got some error message with GLES 2.0 driver while running on Android (Galaxy S8+) which supports gles 2.0 and 3.0.
**ERROR**: SceneShaderGLES2: Fragment shader compilation failed:
1:1: P0003: Extension 'GL_ARB_shader_texture_lod' not supported
1:54: L0002: No matching function for call to 'texture2DLod'
   At: drivers/gles2/shader_gles2.cpp:457:get_current_version() - SceneShaderGLES2: Fragment shader compilation failed:
1:1: P0003: Extension 'GL_ARB_shader_texture_lod' not supported
1:54: L0002: No matching function for call to 'texture2DLod'
**ERROR**: Method/Function Failed, returning: __null
   At: drivers/gles2/shader_gles2.cpp:466:get_current_version() - Method/Function Failed, returning: __null
**ERROR**: Condition ' !version ' is true. returned: false
   At: drivers/gles2/shader_gles2.cpp:133:bind() - Condition ' !version ' is true. returned: false
**ERROR**: SceneShaderGLES2: Fragment shader compilation failed:
1:1: P0003: Extension 'GL_ARB_shader_texture_lod' not supported
1:54: L0002: No matching function for call to 'texture2DLod'
   At: drivers/gles2/shader_gles2.cpp:457:get_current_version() - SceneShaderGLES2: Fragment shader compilation failed:
1:1: P0003: Extension 'GL_ARB_shader_texture_lod' not supported
1:54: L0002: No matching function for call to 'texture2DLod'
**ERROR**: Method/Function Failed, returning: __null
   At: drivers/gles2/shader_gles2.cpp:466:get_current_version() - Method/Function Failed, returning: __null
**ERROR**: Condition ' !version ' is true. returned: false
   At: drivers/gles2/shader_gles2.cpp:133:bind() - Condition ' !version ' is true. returned: false

as result, some texture is not shown with shader.
shader_type canvas_item;

render_mode blend_mix;
uniform float fattyness = 1.0;

void fragment(){
	vec2 ruv = UV - vec2(0.5,0.5);
	vec2 dir = normalize(ruv);
	float len = length(ruv);

	len = pow(len*2.0, fattyness)*0.5;
	ruv = len*dir;

	vec4 col = texture(TEXTURE, ruv + vec2(0.5, 0.5));

	COLOR = col;
}

this shader originally came from https://github.com/godotengine/godot-demo-projects/tree/master/2d/sprite_shaders
Steps to reproduce:
Minimal reproduction project:

@volzhs Could you recheck this issue ?

yeap. it's fixed now.


[SPARK-36628][PYTHON] Implement label-based MultiIndex select

What changes were proposed in this pull request?
Implement label-based MultiIndex select
Why are the changes needed?
Increase pandas API coverage
Does this PR introduce any user-facing change?
Yes, label-based MultiIndex select can be used now.
How was this patch tested?
Unit tests.

Test build #142894 has started for PR 33881 at commit bd21b12.

Test build #142894 has finished for PR 33881 at commit bd21b12.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142894/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47397/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47397/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47397/

test this please

Test build #142930 has started for PR 33881 at commit bd21b12.

Test build #142930 has finished for PR 33881 at commit bd21b12.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47432/


0444-added govt services and health ministry links

Per issue #444 I've added Government Services and Health Ministry links to the Global page (GlobalPage React container). This will render links to governmental services for the Countries.

Closing until either built into refactor or needed.


Gas stress contracts

See https://github.com/filecoin-project/ref-fvm/issues/1281
JUMPFEST
This is a maximally sized contract that does 1M iterations of jumping around, either random or linear.
See jmpfest-gen.ss for how the contract is generated :hamster:
vyzo@carbon6 fvm-bench $ time ./target/release/fvm-bench -b bundles/builtin-actors-next-16a587513d.car ./contracts/jmpfest_linear.bin "" ""
Result:
Gas Used:<PHONE_NUMBER>

real	0m1.795s
user	0m6.185s
sys	0m0.066s

vyzo@carbon6 fvm-bench $ time ./target/release/fvm-bench -b bundles/builtin-actors-next-16a587513d.car ./contracts/jmpfest_random.bin "" ""
Result:
Gas Used:<PHONE_NUMBER>

real	0m1.622s
user	0m5.907s
sys	0m0.078s

MEMFEST
This is a maximal memory store+load contract; it initializes 10M slots (320MB) as a chain, and then does 10M traversals.
Comes in two variants, linear and random, where the traversal is dictated by a linear congruential rng.
vyzo@carbon6 fvm-bench $ time ./target/release/fvm-bench -b bundles/builtin-actors-next-16a587513d.car ./contracts/memfest_linear.bin "" ""
Result:
Gas Used:<PHONE_NUMBER>09

real	0m15.282s
user	0m19.515s
sys	0m0.117s

vyzo@carbon6 fvm-bench $ time ./target/release/fvm-bench -b bundles/builtin-actors-next-16a587513d.car ./contracts/memfest_random.bin "" ""
Result:
Gas Used:<PHONE_NUMBER>50

real	0m23.816s
user	0m28.069s
sys	0m0.075s

We should try to get the gas numbers in the second case as much as possible. Can we make them both nearly identitcal except for swapping the order of zeroing and generating a random table?

I guess i can make a phony LCG that computes X' = X + 1, so yes we can make pretty much identical.

yes it was plugged in.
Gas charges shouldn't change regardless, but wallclock time my fluctuate indeed.

Note: I would like to dedup the code between the two contracts, and just have a small init section and then the same, but eas doesn't like it: see https://github.com/quilt/etk/issues/114


Simply doesn't work

Using all three suggested methods:
SemVer on both depender and dependency, deleting library. restarting unity.

@VirsabiMunk
Please try to use 2.0.0-preview.1.
https://github.com/mob-sakai/GitDependencyResolverForUnity/releases/tag/v2.0.0-preview.1
NOTE: It contains BREAKING CHANGE.


updated sente (<IP_ADDRESS>05)

Thank you for the contribution. It was merged directly as 65ad0ce366b648a2e9c98f55f0545d894fad0504 to keep commit history cleaner. Your contribution is still credited to you.


PullRefreshLayout : Error when setting new MainPage

I am getting an error when trying to set a new MainPage after using the PullRefreshLayout.  The object it is trying to use is the ScrollViewRenderer
System.ObjectDisposedException: The object was used after being disposed.
at Foundation.NSObject.get_SuperHandle () [0x00015] in /Users/builder/data/lanes/1962/8b265d64/source/maccore/src/Foundation/NSObject2.cs:416
at UIKit.UIView.RemoveFromSuperview () [0x0003d] in /Users/builder/data/lanes/1962/8b265d64/source/maccore/src/build/ios/native/UIKit/UIView.g.cs:1275
at Xamarin.Forms.Platform.iOS.Platform.DisposeModelAndChildrenRenderers (Xamarin.Forms.Element view) [0x00033] in :0
at Xamarin.Forms.Platform.iOS.Platform.Dispose () [0x00048] in :0
at Xamarin.Forms.Platform.iOS.FormsApplicationDelegate.UpdateMainPage () [0x00043] in :0
at Xamarin.Forms.Platform.iOS.FormsApplicationDelegate.ApplicationOnPropertyChanged (System.Object sender, System.ComponentModel.PropertyChangedEventArgs args) [0x00012] in :0
at Xamarin.Forms.BindableObject.OnPropertyChanged (System.String propertyName) [0x00012] in :0
at Xamarin.Forms.Application.set_MainPage (Xamarin.Forms.Page value) [0x0008b] in :0

I removed this line and it now works.
https://github.com/jamesmontemagno/Xamarin.Forms-Awesome-Controls/blob/master/PullToRefreshLayout/PullToRefresh/PullToRefresh.iOS/PullToRefreshLayoutRenderer.cs#L60

Interesting.... do you have a code example of the crash? I would like to dive into that...

I don't have a small example ATM.
On Sep 8, 2015 8:54 PM, "dhaligas"<EMAIL_ADDRESS>wrote:

I don't have a small example ATM. It was happening on my production app of
course
—
Reply to this email directly or view it on GitHub
https://github.com/jamesmontemagno/Xamarin.Forms-Awesome-Controls/issues/5#issuecomment-138771841
.

I added some try/catch around it and pushed a new package. That is a required and necessary call. This should fix it.


Update CONTRIBUTING.md

Proposed changes:

fix weird formatting on website page due to underscores rendering italics

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

Good point, was thinking about that as well. Didn't know if it was a look we were going for or something

Didn't know if it was a look we were going for or something

Yeah no worries, if it doesn't come out looking right, I'll make a CSS change on my end: in principle it's the right way to do it though.
BTW I don't have write access here so you'll need one more review


Review the information stream / sequence presented to VDC owners when a VDC is deployed

Let;s review the flow of information which is currently being presented to the VDC owner.  There is information in the sequence of screens that are presented that indicate the steps that the deployment process go through.
Let's question the relevance and validity to show this to every consumer of a VDC.  Maybe create an option that allows you to choose what level of information is being shared with consumers.

Issue didn't go anywhere since jan 28


[Ready for Review] Feature/api/profile pic

Purpose
brianjgeiger reports:

We had a brief discussion on this issue, and it's leading to the following proposed changes:

v2 serializer uses profile_image_url instead of gravatar_url because we may not always use gravatar;
modify the user view to accept a query parameter to set the profile_image_size.
By default, it will still return a specified size.

Changes

Update V2 user serializer to use profile_image_url instead of gravatar_url
Let user list and detail views take profile_image_size query param

write tests to document this

Update User model to have a profile_image_url method, and replace usages of User.gravatar_url property with new method
Update profile image size constants in settings to have more general names

Side Effects
We should track down all gravatar specific references and replace them with the generalized profile_image_url method.

This does not seem to address the issue of hardcoded sizes: https://openscience.atlassian.net/browse/OSF-4092 . If the client doesn't pass any query params, there should be no size specified in the gravatar URL.
@samchrisinger Can you look into this?

Will continue CR when the above issue is addressed.

@sloria, this is addressed

Looks good.

Resolved conflicts and merged with develop


Updated some libraries

@Mayor-Rhymes
This only has the package.lock file.  It should include the package.json file as well.  You can commit that to the same branch.  Did it update your package.json?

Weirdly enough, it didn't. It was after I had sent the PR that I realized
that. I will check it out and see what I can do.
On Tue, Jun 20, 2023 at 12:03 PM Gregory Bowne @.***>
wrote:

@Mayor-Rhymes https://github.com/Mayor-Rhymes
This only has the package.lock file. It should include the package.json
file as well. You can commit that to the same branch. Did it update your
package.json?
—
Reply to this email directly, view it on GitHub
https://github.com/gbowne1/codebooker/pull/55#issuecomment-1598394490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIP2SHA3C2QS5JJLL7ME7VDXMFRPJANCNFSM6AAAAAAZM6PFWU
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have updated both the package.json and the package-lock.json


Allow functions to be passed to runJS

This feature was co-written with @calebeby. This allows functions to be passed to runJS.
See the new test to help understand the intent.
Closes #47

@gerardo-rodriguez Can you add a changeset?


Add a better status message

We are adding a better status message that will include the Namespace and the PipelineRun.
We link the Namespace to the Namespace view in the consoles.
Introducing a new setting for that custom-console-url-namespace that would need to be setup when using a custom console.
Shows like this now:

Changes

Submitter Checklist

[ ] 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
[ ] ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
[ ] ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

oh damn i did a resetup of my git repo and it submitted on pac repo instead of fork, i'll clean this up after the merge


Support poison values

The test added in https://github.com/triton-lang/triton/pull/4896 fails right now with an "LLVM Translation failed" error. The fix should be pretty simple; we just need to add a call to mlir::ub::populateUBToLLVMConversionPatterns like the nvidia/amd backends have done. However, since we use a somewhat different pass organization structure, we don't have a generic pattern conversion pass to put this into. I tried adding the conversion in FuncOpToLLVM, and while translation succeeds, the poison value is still missing from the llir output; I think it's getting DCE'd away. Not sure if this is a pass ordering issue, or if the test should just be made more flexible...
This doesn't seem super critical so I'm just filing an issue for now

We can add a proper pass to our pipeline similar to other upstream dialects lowering passes. It can be created using createUBToLLVMConversionPass.


using github.com/google/martian/v3 now

I had to update this dependency due to some version clashes.

Thank you!

@jba   Can you also please create a new release? :-)


fix(upstream): Cherry-pick redb bug workaround

Cherry-pick commit in https://github.com/ordinals/ord/pull/3856 which claims to reduce the size of the index by 70Gb in mainnet.

Closing in favor of #14


Missing documentation on compiler specifics - grammar, AST node types, intermediate code tree Exp and Stm node types

I'm posting it here because it seems that this is the only way to reach out to the core team.
I'm trying to understand TypeScript compiler architecture on the low level so I'm reading the sources. This doc page shows that the compiler goes through the common stages of all compilers architecture: parse tree (lexer) -> abstract syntax tree (parser) -> intermediate code -> output. It seems that the docs on the low-level details of a compiler is currently non-existent and not sure anything of that sort will ever be officially published.
So I'm wondering if there exists any internal docs that can be shared that capture the compiler architecture specifics like:

context free and regular grammar for lexical analysis, parsing and abstract syntax
node types for AST
expression and statement classes specific to intermediate code tree
etc.

Basically anything that helps understand the construction of the typescript compiler is highly appreciated.

We don't have any internal docs on this topic, nor time to write the quantity required to be useful. Specific questions are welcomed, though.

Also please consider our .d.ts file as part of our documentation. the file includes definition to the AST node kinds, as well as APIs used to manipulate them.

@RyanCavanaugh , @mhegazy thanks guys. I have a few specific questions:
What algorithm do you guys use for

lexical analysis (tokens stream)
syntax analysis (parse tree)

Top-down parser or bottom-up parser? Parse of ambiguous or unambiguous grammar?
Also, I've checked the sources and it seems that the parses uses scanner to get a one token at a time instead of having a scanner to generate the stream of tokens before parsing, is it correct?
Thanks!

We use a hand-crafted recursive descent parser (so LL). the parser consumes one token at a time as you noted.

@mhegazy , thanks for the info, it will be helpful when debugging the parser. Do you also use the same technique for the lexical analysis? Or do you use some finite automaton?

Everything is hand-written. The scanner is a stateful scanner which is driven by the parser when the parser is aware of the current syntactic goal. Check out: https://github.com/Microsoft/TypeScript/wiki/FAQs-for-API-Consumers#what-are-these-rescanfootoken-functions-in-the-scanner-for

What are these rescanFooToken functions in the scanner for?

The ECMASCript grammar describes lexical goals for its grammar, for which an alternate scanning rule should be used in its place from the default. These rules are triggered when syntactically aware consumers require them (i.e. ECMAScript parsers which know when a construct can occur). For details, see the current ES spec.

One example of this is for a single / (the forward-slash token). As long as the / isn't immediately followed by another / (indicating a comment), the default goal (InputElementDiv)  is to scan it as a plain / or /= (for division operations); however, in contexts where a bare / or /= would not make sense (such as when parsing a PrimaryExpression), the goal is modified to InputElementRegExp to scan out a regular expression literal.

The rescan functions roughly correspond to triggering the alternate rules, though rather than passing an extra parameter, a rescan is demanded of the scanner.

Though lexical goals are not addressed in the TypeScript spec, there is effectively one new rule added for the >s (greater-than characters) to make generics easy to parse, but impose that any places which might encounter a >>, >>>, etc. require a rescan.

Keep in mind the scanner isn't part of our API, or if it is, it shouldn't be. 😅

@mhegazy , thanks, just to clarify, you're using predictive LL(1) parser with one token lookahead that is hand-written? Or do you use recursive descent parser with recursion?
@DanielRosenwasser, thanks, what is the algorithm used for lexer? It's not finite automaton?

These questions can be answered by a quick glance at the code.
If you open scanner.ts you'll see a function called scan which examines the current character (derived from the source (text) and current position (pos)) in a big, big hand-written switch statement. Where appropriate, the cases in the switch invoke helper functions.  Also, please notice the function called speculationHelper.
The same goes for the parser. You'll find a function called parseSourceFile in namespace Parser. From there on you can drill down the different production parsing functions. This should hint you the type of parser being used. For the second part of the question, the function lookAhead might be of interest to you.

@gcnew , thanks for the suggestions, and I've already done that. However, given the very complex grammar of EcmaScript and my limited experience with compilers it's hard for me to recognize the pattern by reading the compiler sources, which as you've seen are huge. It's much easier to debug knowing that the parser is written, for example, as predictive recursive descent. So from the list of the top-down parser types I wish someone would just say

it's b, predictive recursive descent

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Use startup command from args

Fixed in 83c3ca0
New usage:
ENTRYPOINT ["/opt/startup/init_container.sh"]
CMD ["dotnet", "WebApp.dll"]


early_stopping_rounds is ignored in python interface when specified via parameters dict

The parameter early_stopping_rounds is ignored when it is set via the parameters dictionary but it works fine when it is explicitly specified in the call lgb.train. I think this should be fixed or the documentation needs a note that this parameter is ignored in the python interface (like the note for num_iterations in http://lightgbm.readthedocs.io/en/latest/Parameters.html)
Here is a code example:
import lightgbm as lgb
import numpy as np
import pandas as pd

n=1000
X = np.random.randint(1000, size=(n,2))
y = X[:,0]+X[:,1] + np.random.normal(size=n)

Xtrain, ytrain = X[:int(.5*n),:], y[:int(.5*n)]
Xval, yval = X[int(.5*n):,:], y[int(.5*n):]

ds_train = lgb.Dataset(Xtrain, ytrain)
ds_val = lgb.Dataset(Xval, yval)

params = {'objective':'regression_l2',  'metric':'rmse', 'learning_rate':.01,'early_stopping_rounds':10}
gbm = lgb.train(params, ds_train, valid_sets=[ds_val, ds_train], categorical_feature=[1],verbose_eval=20,num_boost_round=1000)
print("=============================================")
gbm = lgb.train(params, ds_train, valid_sets=[ds_val, ds_train], categorical_feature=[1],verbose_eval=20,num_boost_round=1000,early_stopping_rounds=10)

ok, we will add a note into doc.

@wxchan
besides updating docs, I think we also can add some warnings in python/R package if user pass these parameters into dict.
Another solution is reading these parameters from dict.

@wxchan can you help for this ?

@guolinke there is a test case called 'test_categorical_handle', you specify 'categorical_column' in dict now, which it's not working right now. Should I keep it in dict?

@wxchan why it cannot work ?
refer to: https://github.com/Microsoft/LightGBM/pull/806/files#diff-c90239f8147ba65eec9e89412fe27c01R130

@guolinke I meant it's not being used before in that test case.

@wxchan BTW, here is another issue (from Gitter):

Hi I am trying to do a manual train/test split in lightGBM.
Example code:
dataset = lgb.Dataset(data, label=labels, silent=True, free_raw_data=False)
lgb.train(
params=LGB_PARAMS,
num_boost_round=10,
train_set=dataset.subset(train_idx),
valid_sets=[dataset.subset(test_idx)],
verbose_eval=True,
)
But I got errors like this:
File "virtualenv_run/local/lib/python2.7/site-packages/lightgbm/engine.py", line 126, in train
valid_data.set_reference(train_set)
File "virtualenv_run/local/lib/python2.7/site-packages/lightgbm/basic.py", line 1011, in set_reference
raise LightGBMError("Cannot set reference after freed raw data, set free_raw_data=False when construct Dataset to avoid this.")
lightgbm.basic.LightGBMError: Cannot set reference after freed raw data, set free_raw_data=False when construct Dataset to avoid this.
It works OK if I skip the valid_sets argument. Is this a bug or I did something wrong?

@wxchan sorry, I didn't get your point. you meant the categorical_column cannot be in dict now ?

@guolinke yes, before #806.

@wxchan
you meant only after #806, we can use categorical_column  in dict ?
But it passes the test before #806 .

@guolinke it won't throw an error, it's ignored. Actually in current version, categorical_column only support list or set, use int will throw an error. So it must be ignored.

@wxchan
before #806 , the categorical_column: 0 in dict will be converted to categorical_column=0, and this will be accepted by LightGBM dll. Otherwise the test cannot pass, since the prediction needs to equal to label.

@guolinke ok I got it. So what should be current logic if categorical_feature is set in both dict and argument?

I think use the one in dict, and give a warning ? ( since it has a default value in argument, it is hard to tell is set by user or not. )

BTW, do you have any idea about the issue in this comment: https://github.com/Microsoft/LightGBM/issues/793#issuecomment-321169954 ?

@guolinke I am trying to reproduce it and didn't reproduce it yet. I think it should be fixed after reference chain. Is he using latest version?

@fcchou can you try use the latest code ?

@guolinke so actually we don't need to check categorical_column from params dict and pull it out of it. It works perfectly fine.

@guolinke The latest code works. Thanks!  Looking forward to see the next Python release coming out with all the bug fixes.

@wxchan maybe we can handle both int, str, multi-str(','.join(...)), list of str, list of int .


Adversarial compilation failing to infer inputs properly

Hi.
I am currently on TensorFlow 2.3 and I am using the latest version of nsl. I am trying to train an adversarially robust flower classifier with the flowers dataset. I am preparing the data in the following way -
train_ds, validation_ds = tfds.load(
    "tf_flowers",
    split=["train[:85%]", "train[85%:]"],
    as_supervised=True
)

def preprocess_image(image, label):
    image = tf.image.convert_image_dtype(image, tf.float32)
    image = tf.image.resize(image, SIZE)
    return {"image": image, "label": label}

# Construct TensorFlow dataset
train_ds = (
    train_ds
    .map(preprocess_image, num_parallel_calls=AUTO)
    .cache()
    .shuffle(1024)
    .batch(BATCH_SIZE)
    .prefetch(buffer_size=tf.data.experimental.AUTOTUNE)
)

validation_ds = (
    validation_ds
    .map(preprocess_image, num_parallel_calls=AUTO)
    .cache()
    .batch(BATCH_SIZE)
    .prefetch(buffer_size=tf.data.experimental.AUTOTUNE)
)

My base model is constructured like so -
def get_training_model(base_model):
    inputs = Input(shape=(224, 224, 3))
    x = base_model(inputs, training=False)
    x = GlobalAveragePooling2D()(x)
    x = Dense(5)(x)
    classifier = Model(inputs=inputs, outputs=x)

    return classifier

base_model = MobileNetV2(weights="imagenet", include_top=False,
        input_shape=(224, 224, 3))
base_model.trainable = False
base_adv_model = get_training_model(base_model)
base_adv_model.summary()

The adversarial-regularized model is prepared in the following way -
adv_model = nsl.keras.AdversarialRegularization(
    base_adv_model,
    adv_config=adv_config
)

When I start training I run into -
StagingError: in user code:

    /usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training.py:806 train_function  *
        return step_function(self, iterator)
    /usr/local/lib/python3.6/dist-packages/neural_structured_learning/keras/adversarial_regularization.py:667 call  *
        outputs, labeled_loss, metrics, tape = self._forward_pass(
    /usr/local/lib/python3.6/dist-packages/neural_structured_learning/keras/adversarial_regularization.py:646 _forward_pass  *
        outputs = self._call_base_model(inputs, **base_model_kwargs)
    /usr/local/lib/python3.6/dist-packages/neural_structured_learning/keras/adversarial_regularization.py:635 _call_base_model  *
        inputs = [inputs[name] for name in base_input_names]

    KeyError: 'input_16'

Here's my Colab Notebook.  Am I missing out on something?
Cc: @csferng

Thanks for your question. Because the input examples are converted to dictionaries in preprocess_image(), it works best to name the Keras input tensor as well:
inputs = Input(shape=(224, 224, 3), name="image")

@csferng thanks for the help. It did the trick.
Now when I try to test the robustness for comparison purposes, the perturb_on_batch() function is not able to interpret label key from the feature dictionary. Is there a way to bypass it?
Here's the updated Colab Notebook.

@sayakpaul, perturb_on_batch() expects the same input format as call(), which is a dictionary containing both features and labels. The output of perturb_on_batch() also contains the same label features.
I didn't see any error in your colab notebook around perturb_on_batch(). Could you explain more what was wrong or what you'd like to achieve?

@csferng it came out as a warning actually. When I ran it the second time it went away.
If you see closely there is not by perturbation and accuracy for both the models for the perturbed batch is zero. I wanted to know why and how I could counter it. My belief is that there must have been something wrong in my code.

@csferng any updates?

I got reasonable results by running your colab:
base model accuracy: 0.250000
adv-regularized model accuracy: 0.515625

Maybe the zero accuracy issue was caused by some cached values in the runtime. Could you restart the runtime and see if the issue persists?
Regarding the warnings, some like Cannot perturb features ['label'] is normal during perturb_on_batch(). The label feature is in integer type, so it cannot be perturbed. But since we actually don't want to perturb the label feature, this behavior is okay.  91a4e3b suppresses this kind of warnings and will be included in the next release.

Thanks, @csferng. The issue is solved now.


add a Python version check when running as a script

Description of change
When running as a script, even on current AL2/AL2023 porting advisor fails with an exception due to old Python version installed by default. This change will print a descriptive message in such cases which will help users who missed the prerequisite in the Readme.md
Issue
#48
PR reviewer notes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM 🚢


Should Array's find/findIndex/filter/some... callbacks return any or boolean?

Right now, the signature for, say, find is
find(callbackfn: (value: T, index: number, array: Array<T>) => any, thisArg?: any): T;
I think it should be
find(callbackfn: (value: T, index: number, array: Array<T>) => boolean, thisArg?: any): T;
If you, like me, happen to forget return in the filter function etc, it should get an error. However I understand the current logic too; the truthiness can be determined on any value.
What do you think?

we require casting (e.g. return !!foo) elsewhere so I think I agree with you.

cool. I will make a PR later then

Where do we require casting elsewhere?

Well I made a simple PR here
https://github.com/facebook/flow/pull/1610
All the tests are passing without any change.

I'm not sure about this. I feel like this is more of a lint rule than something that Flow should enforce. If we build a linter on top of Flow, I think this would be a great rule. The output of filter is automatically cast, so changing it to boolean doesn't really model how the function works. I worry that this change will introduce Flow errors in a lot of existing code that otherwise works fine.

I'm going to close this out for now. If anyone wants to continue this discussion feel free to reopen.


Improve s3 link parsing to make it more intuitive and dynamic in Evaluator

Currently parsing the s3 links is not so intuitive and might break anytime. Therefore, Improve s3 link parsing to make it more intuitive and dynamic in the Evaluator

Can you provide more details on this?
I might have already solved it with the refactoring of the evaluation code

Closing as I am not sure this is still relevant
(Do reopen if it is needed)


[Common] Date and typeahead fields not rendering value on edit

In the clinical service forms, after successfully save with date and typeahead. The edit of the same form data is not rendering.

@valvijo can you help me understand the issue here? Maybe with steps to reproduce.

[Actual Results]: The system does not retrieve the old date stored,
the system does not display a message with error on validation.
[Expected results]: By changing the date and submitting the form, once its opened again and altered.
The old stored date should load and alter it and save

[Steps to reproduce]:
Clinic -> Consultation Services -> Diagnostic (Or any other sercice with date and typeahead)

 Resolve Pending Issues/Bugs on POC

It looks like this is happening because for some form fields the concept answers are not being loaded.
This function depends on those answers being loaded from the server.
@esaude/poc-developers how should we solve this? It looks like more of a backend bug than a POC bug.

@ynurmahomed in fact this concept specifically doesn't have any answers by definition, but theoretically it does. This is because there are thousands of possible answers for that (the entire ICD-10) and we don't want to burden the concept with all the answers in it. We need to find a mechanism of finding the answer for this concept on the fly.

@valvijo How to tell if a Concept is ICD-10 or not? Related #157.

@ynurmahomed the call: /openmrs/ws/rest/v1/concept?source=3f65bd34-26fe-102b-80cb-0017a47871b2 returns the list all all concepts mapped with ICD-10. For example the concept: 7155 - Malária por plasmodium malariae as a mapping SAME-AS CD-10-WHO

 Bug: [Common] Date and typeahead fields not rendering value on edit


Community: Integrate Cleanlab's trustworthy LM with basic example notebook

Description:
Adds support for Cleanlab's Trustworthy Language Model which provides trustworthiness_score (in addition to string response).
This integration will allow LangChain user's to use these scores in RAG or Agentic pipelines.
Twitter handle: @ashishsardana21
Changes:

Added cleanlab.py
Added unit and integration tests
Added example notebook to showcase use of Cleanlab's TLM
Dependency (cleanlab's client library) is imported in try block

Team, I need your help on 2 issues which blocks this PR:

I'm observing an error during make lint:

./scripts/check_pydantic.sh .
The PR seems to be introducing new usage of @root_validator and/or @field_validator.
git grep -E '(@root_validator)|(@validator)' | wc -l returned      337
whereas the expected count should be equal or less than 336
Please update the code to instead use __init__
For examples, please see:
https://gist.github.com/eyurtsev/d1dcba10c2f35626e302f1b98a0f5a3c
This linter is here to make sure that its easier to upgrade pydantic in the future.
make: *** [lint] Error 1

I haven't used @root_validator in the integration code. Can you help point what I'm missing?

The unit tests for this integration are failing.

The test initializes the Cleanlab's client object which requires internet, therefore make test throws pytest_socket.SocketBlockedError: A test tried to use socket.socket.
What should I do in this case?

team (@efriis @baskaryan @eyurtsev), tagging you for quick help on the above comment.

Hey @AshishSardana ! Would recommend going through the pydantic docs on validation. Note we're now on pydantic 2, so these would be model_validators, or ideally just fields
also here's the review process if helpful! PR is in needs support currently: https://python.langchain.com/docs/contributing/review_process/

Hi @efriis , I initiated a discussion about this new integration here https://github.com/langchain-ai/langchain/discussions/26721 and found there's genuine interest in people to use Cleanlab's Trustworthy LM.
Is this sufficient to change the status for this PR? I also fixed the lint error by upgrading to pydantic v2.

Hey there! You'll have to get CI passing for this to be mergeable, and we'll unfortunately have to close it if you can't yourself :(. Here's how you can run it locally:
First, install poetry, e.g. with curl -sSL https://install.python-poetry.org | python3 - on non-windows machines (see link for other ways of installing)
Then, for example if you're in community, you can run
# enter package you're checking, e.g. community:
cd libs/community

# format and lint
poetry install --with lint,typing --sync
make format lint

# test
poetry install --with lint,typing,test --sync
make test

# extended tests - install extra deps with uv - not a requirement but it's how I do it
poetry install --with lint,typing,test --sync
poetry run pip install uv
poetry run uv pip install -r extended_testing_deps.txt
make extended_tests

# run a specific test - helpful if trying to just fix a single test
poetry run pytest --disable-socket --allow-unix-socket tests/unit_tests -k test_my_test_name

closing as stale - feel free to reopen when you get a chance to look at the CI failures!
In addition to the github CI failures the docs build is also failing. Here's a screenshot of that failure because that link won't work for you

hey @efriis, i tried fixing the errors you mentioned, specifically:

lint, test and extended_tests - followed your steps above to get CI tests working
MDX compilation in cleanlab.md - changed a hyperlink since the error message doesn't specify the exact issue with the markdown file.

the only issue in error i'm unable to bypass in unit_tests is:
FAILED tests/unit_tests/llms/test_cleanlab.py::test_api_key_is_secret_string - pytest_socket.SocketBlockedError: A test tried to use socket.socket.
could we re-open this PR? i'll actively work towards fixing any new issues!

I think I may have sent this in another PR/issue as well (or maybe slack) - heres the repost for reference!
Hey! This adds a net-new community integration or feature, which has been replaced by dedicated integration packages. I'll close this PR, and would recommend reopening with just docs updates, as well as registering your package in libs/packages.yml! We'll be able to review simple PRs that only modify these two things much faster :)
Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

thanks for sharing this new community integration guide. i'll raise a new PR following that!

i have a quick question that i'm not sure would apply to most developers contributing integration to langchain, hence asking here --
would the langchain-cleanlab (chat-model) pkg be visible in the integration-package table OR in the providers webpage.

yes to the second, no to the first to start


Upgrade requests library

See https://github.com/allegroai/clearml-agent/issues/161.

Hi @jday1,
As a rule, we try not to have open-ended constraints as this might lead to an unstable package breaking ClearML (sadly, we've already seen these issues in the past). I would much rather bump the version to the relevant number, or even add an open-ended constraint on the patch version?

Hi @jday1,
As a rule, we try not to have open-ended constraints as this might lead to an unstable package breaking ClearML (sadly, we've already seen these issues in the past). I would much rather bump the version to the relevant number, or even add an open-ended constraint on the patch version?

No worries. I have made an adjustment.


Missing loading state for "Withdraw application"

To reproduce:

Create a collective
Apply to a fiscal host
Go to the user menu > Select collective > Click "Admin" > Fiscal Host
Click on "Withdraw application"
See missing loading state

The query went quite fast on staging, but I faced a case in production where the page took ~4-5 seconds to refresh, making it look like the action did nothing.

I want to fix this, but I need some help with setting up this project on my device

Hi @milekboy, all the instructions are there: https://github.com/opencollective/opencollective-frontend

Thanks @Betree This was helpful...I'm working on it now

Hello, @Betree Please I've been trying to run 'npm install' to install  the dependencies in package json but its giving me this error:
npm ERR! code ECONNRESET
npm ERR! syscall read
npm ERR! errno -4077
npm ERR! network read ECONNRESET
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
Do you have any idea on what I can do please?

There's no problem with my network

Hello @Betree, Thanks for the help so far, I was able to get it to run finally on my local server
But I'm experiencing a new error
Do you have any Idea what this might be please?

@milekboy it's because of https://github.com/opencollective/opencollective/issues/5836. We have a potential fix ready for this one.

@milekboy We've merged https://github.com/opencollective/opencollective-frontend/pull/8547, this error should go away after a rebase.

Thanks @Betree It's now running perfectly on my device, I will proceed to contribute now.

To reproduce:

Create a collective
Apply to a fiscal host
Go to the user menu > Select collective > Click "Admin" > Fiscal Host
Click on "Withdraw application"
See missing loading state

The query went quite fast on staging, but I faced a case in production where the page took ~4-5 seconds to refresh, making it look like the action did nothing.

I've been trying to join a fiscal host, so that I can reproduce this issue on my device...I've applied to a few and I'm waiting for at least one to accept me.

I've been able to see the issue on my device, I'm proceeding to explore the codebase to spot where the issue is coming from, and  fix it.


Created a detailed README.md file for the Random Password Generator project

This PR adds a detailed README.md file for the Random Password Generator project. The README.md provides essential information to help users understand the project, its features, and how to use the application. The sections covered in the README include:
Project Name
Description of the project
Key Features
Technologies used (HTML, CSS, JavaScript)
Instructions for using the application
Code overview and functionality
This update improves project documentation and enhances user experience by providing clear guidance on using the application.

@concern30 We genuinely appreciate your efforts, and we’d be thrilled to see you take on more issues or even suggest new features. Keep up the fantastic work, and we look forward to more of your contributions!


ISPN-6429 Duplicated boolean projections are broken in compat mode

https://issues.jboss.org/browse/ISPN-6429

wrong base branch. closing.


Compiled module was created by a different version of the compiler '

I am trying to build my project which uses ContentfulPersistence. When I try to build the project the following error appears: "Compiled module was created by a different version of the compiler ''; rebuild 'ContentfulPersistence' and try again:"
I am using Xcode Version 15.3 (15E204a).
MacOS 14.5.

@asaadjaber what method did you use to add library to your app? One of the lib managers like cocoapods or just manually downloading the built framework?


Binaryen error on Windows machine

Describe the bug
I have an issue on the newest Kotlin + Compose:
I've moved to Kotlin 2.0.0 and Compose 1.6.10. I had no problems building the project (./gradlew build -Dorg.gradle.jvmargs=-Xmx2048m) locally (Linux), but when I pushed the changes to the remote, I had an issue with Binaryen when building the project on a Windows machine (CI, windows-latest). On Linux (CI, ubuntu-latest) everything works fine. Binaryen is used for Web (Wasm) target.
The problem occurs on the compileProductionExecutableKotlinWasmJsOptimize task.
Part of the error message: "UNREACHABLE executed at D:\a\binaryen\binaryen\src\passes\Precompute.cpp:838!"
Versions

Libraries:

Compose Multiplatform version: 1.6.10

Kotlin version: 2.0.0
OS version: Windows Server 2022
OS architecture (x86 or arm64): x86-64
JDK (for desktop issues): Adopt JDK 17

Windows Image:

JDK:

To Reproduce
Steps to reproduce the behavior:
Currently, I have no small reproducible for the issue. I'll try to add one soon.
Expected behavior
Should build fine.
Screenshots

Additional context
Link to CI job run: https://github.com/AzimMuradov/stardew-valley-designer/actions/runs/9225193475/job/25383277282

Logs: logs_24148234620.zip

Hello, @AzimMuradov!
I'll pass it to the team, however, reproducer would be nice though.
Could you please attach it once you've made it? It would be really helpful.

Could you please attach it once you've made it? It would be really helpful.

You can reproduce it using I'll try to make small one.

Could you please attach it once you've made it? It would be really helpful.

Currently, you can reproduce it on Windows using this branch https://github.com/AzimMuradov/stardew-valley-designer/tree/site of my project. Although this is quite a large project, I'll try create a smaller reproducible later.
P.S. Before this comment, I accidentally clicked "save" in my reply, thus sending an unfinished message, sorry :)

I also found related youtrack issue: https://youtrack.jetbrains.com/issue/KT-68088

Since the issue only happens on Windows AND with binaryen enabled, it's likely that the core cause is not in Compose.
Since the issue is already reported in Kotlin tracker, let's close this one.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Is there a way to handle mutations errors?

Hi guys. I run in specific problem today. Graphql intentionally does not use HTTP error codes for errors. If there are some errors during mutation, in response field data is null and another key errors was returned in response with structured errors.
So my questing is, is there a way how to access/handle these errors? Currently I am not able to figure it out, mutation function resulting in Ok result every time but returning only empty result, no errors.

I released 0.8.2 which will attempt to parse the errors field if the data is null or fails to decode in any way.
Let me know if this solves your situation or if there's something I missed!  Thanks for the issue 🙏


Revoked credential UI is wrong

Revoked UI red colour does not follow the style guide and design.

@knguyenBC I can change the color to match but we don't have a revocation date so I won't be able to show "Revoked: May 31, 2021"

Ok, colour updated in the next build. Still cannot put the label "Revoked: May 31, 2021" in because we don't have that data. Best to move it to M2 or M3 designs.

Ok, colour updated in the next build. Still cannot put the label "Revoked: May 31, 2021" in because we don't have that data. Best to move it to M2 or M3 designs.

That's fine. It can just say "revoked" and the date can be left out.

The updates didn't carry over in the latest build (179). I still see the same as the initial screenshot posted in the ticket.

The updates didn't carry over in the latest build (179). I still see the same as the initial screenshot posted in the ticket.

 Still not correct UI.


Calculate modexp gas fee correctly EIP-2565

What was wrong?
Modexp wasn't being calculated quite correctly.
How was it fixed?
Removed reuse of compute_adjusted_exponent_length, and made a new method called calculate_iteration_count that's pulled pretty much verbatim from the EIP.
To-Do

[x] Clean up commit history

[ ] Add entry to the release notes - @carver do we want a release note for this? Happy to add one if so!

Cute Animal Picture

@carver this one is ready!

do we want a release note for this? Happy to add one if so!

Nope, when a bugfix goes out for a bug that was never released, it doesn't need a special note. Although I think I mentioned something about modexp not working yet in one of the notes, so that can be removed of course.