Cluster getting deleted automatically

Hi,
I am facing an issue where the cluster is getting deleted automatically immediately after the services start using it. Till then they are alive.
My nats operator deployment yaml:
[amuralid@amuralid-k8s-1:/localdisk/amuralid/k8s/rift2]$ kubectl -n amuralid-k8s-1 get deployments amuralid-k8s-1-nats-operator -o yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{},"labels":{"app":"nats-operator"},"name":"amuralid-k8s-1-nats-operator","namespace":"amuralid-k8s-1"},"spec":{"replicas":1,"selector":{"matchLabels":{"app":"nats-operator"}},"template":{"metadata":{"labels":{"app":"nats-operator"}},"spec":{"containers":[{"args":["nats-operator"],"env":[{"name":"MY_POD_NAMESPACE","valueFrom":{"fieldRef":{"fieldPath":"metadata.namespace"}}},{"name":"MY_POD_NAME","valueFrom":{"fieldRef":{"fieldPath":"metadata.name"}}}],"image":"connecteverything/nats-operator:0.6.0","name":"nats-operator","ports":[{"containerPort":8080,"name":"readyz"}],"readinessProbe":{"httpGet":{"path":"/readyz","port":"readyz"},"initialDelaySeconds":15,"timeoutSeconds":3},"volumeMounts":[{"mountPath":"/localdisk","name":"localdisk","readOnly":false},{"mountPath":"/usr/rift","name":"usr-rift","readOnly":true},{"mountPath":"/usr/rift/var/rift","name":"rift-var-root","readOnly":false}]}],"serviceAccountName":"amuralid-k8s-1-nats-operator","volumes":[{"hostPath":{"path":"/localdisk/amuralid/k8s/rift2/.build/ub18_debug/install/usr/rift/var/rift/lp1","type":"Directory"},"name":"rift-var-root"},{"hostPath":{"path":"/localdisk/amuralid/k8s/rift2/.build/ub18_debug/install/usr/rift","type":"Directory"},"name":"usr-rift"},{"hostPath":{"path":"/localdisk","type":"Directory"},"name":"localdisk"}]}}}}
  creationTimestamp: "2019-09-26T05:20:48Z"
  generation: 1
  labels:
    app: nats-operator
  name: amuralid-k8s-1-nats-operator
  namespace: amuralid-k8s-1
  resourceVersion: "2668115"
  selfLink: /apis/extensions/v1beta1/namespaces/amuralid-k8s-1/deployments/amuralid-k8s-1-nats-operator
  uid: f7f25d41-0d3c-4de9-b8e2-e329c93762ba
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: nats-operator
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: nats-operator
    spec:
      containers:
      - args:
        - nats-operator
        env:
        - name: MY_POD_NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: MY_POD_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.name
        image: connecteverything/nats-operator:0.6.0
        imagePullPolicy: IfNotPresent
        name: nats-operator
        ports:
        - containerPort: 8080
          name: readyz
          protocol: TCP
        readinessProbe:
          failureThreshold: 3
          httpGet:
            path: /readyz
            port: readyz
            scheme: HTTP
          initialDelaySeconds: 15
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 3
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: /localdisk
          name: localdisk
        - mountPath: /usr/rift
          name: usr-rift
          readOnly: true
        - mountPath: /usr/rift/var/rift
          name: rift-var-root
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      serviceAccount: amuralid-k8s-1-nats-operator
      serviceAccountName: amuralid-k8s-1-nats-operator
      terminationGracePeriodSeconds: 30
      volumes:
      - hostPath:
          path: /localdisk/amuralid/k8s/rift2/.build/ub18_debug/install/usr/rift/var/rift/lp1
          type: Directory
        name: rift-var-root
      - hostPath:
          path: /localdisk/amuralid/k8s/rift2/.build/ub18_debug/install/usr/rift
          type: Directory
        name: usr-rift
      - hostPath:
          path: /localdisk
          type: Directory
        name: localdisk
status:
  availableReplicas: 1
  conditions:
  - lastTransitionTime: "2019-09-26T05:21:10Z"
    lastUpdateTime: "2019-09-26T05:21:10Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2019-09-26T05:20:48Z"
    lastUpdateTime: "2019-09-26T05:21:10Z"
    message: ReplicaSet "amuralid-k8s-1-nats-operator-7657f8d4fb" has successfully
      progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  observedGeneration: 1
  readyReplicas: 1
  replicas: 1
  updatedReplicas: 1

Status:
[amuralid@amuralid-k8s-1:/localdisk/amuralid/k8s/rift2]$ kubectl -n amuralid-k8s-1 get pods
NAME                                            READY   STATUS    RESTARTS   AGE
amuralid-k8s-1-auth-service-598c7c4fc9-mpg8p    1/1     Running   0          7m33s
amuralid-k8s-1-fluentd-l4gn4                    1/1     Running   0          7m33s
amuralid-k8s-1-launchpad-64468d99fc-8mcrs       1/1     Running   0          7m33s
amuralid-k8s-1-mongo-0                          1/1     Running   0          7m33s
amuralid-k8s-1-nats-operator-7657f8d4fb-wb8sk   1/1     Running   0          7m33s
amuralid-k8s-1-redis-0                          1/1     Running   0          7m33s
amuralid-k8s-1-rwui-99999cf8d-fckvs             1/1     Running   0          7m33s
rw-nats-cluster-1                               1/1     Running   0          7m2s
rw-nats-cluster-2                               1/1     Running   0          7m
rw-nats-cluster-3                               1/1     Running   0          6m58s

And then suddenly, the pods disappear. From nats-operator logs, I see only this:
time="2019-09-26T05:38:03Z" level=info msg="waiting for pod \"amuralid-k8s-1/rw-nats-cluster-3\" to become ready" cluster-name=rw-nats-cluster namespace=amuralid-k8s-1 pkg=cluster
time="2019-09-26T05:38:05Z" level=info msg="pod \"amuralid-k8s-1/rw-nats-cluster-3\" became ready" cluster-name=rw-nats-cluster namespace=amuralid-k8s-1 pkg=cluster
time="2019-09-26T05:39:03Z" level=warning msg="natscluster \"amuralid-k8s-1/rw-nats-cluster\" was deleted" pkg=controller
E0926 05:39:04.464411       1 reflector.go:237] github.com/nats-io/nats-operator/pkg/client/informers/externalversions/factory.go:115: Failed to watch *v1alpha2.NatsServiceRole: the server could not find the requested resource (get natsserviceroles.nats.io)
E0926 05:39:04.469776       1 reflector.go:237] github.com/nats-io/nats-operator/pkg/client/informers/externalversions/factory.go:115: Failed to watch *v1alpha2.NatsCluster: the server could not find the requested resource (get natsclusters.nats.io)

Also the cluster is not recreated. What could be going on ?

This might be a policy issue since could not watch some of the resources. Could you try with the following statefulset and services instead? https://gist.github.com/wallyqs/c566c856b7119645fd7e11056374c584

Thanks for the quick response. Really appreciate it. Will check and get back.

So, I tried with statefulset and services with replica 1. Have not faced any similar issues as of now.
With replicas 3 however I was getting timeouts if the requests went to the second or the third nats pod (thats why I set the replica to 1).
So, should I continue using StatefulSet + Service or is there any configuration in nats-operator that I need to do ?
Thanks.

@arun11299 I did an update to the statefulset here with an explicit cluster in case there might have been an issue with the dns setup.  With 3 replicas, there should have been a number of Router connection created events:
kubectl logs nats-0 -c nats
kubectl logs nats-1 -c nats
kubectl logs nats-2 -c nats

@wallyqs This seems to be working fine, thanks. Can you brief me on the policy issue with NATS operator ? It would be nice to know the reason and which log file to check for those kinds of errors.


pass: add find and grep as dependencies

When pass is called from passff it does not have grep and find in its
path.
PATH="" /home/beardhatcode/.nix-profile/bin/pass grep lol                                             ~
/nix/store/HASH-password-store-1.7.3/bin/.pass-wrapped: line 399: find: command not found
$ PATH="/nix/store/HASH-findutils-4.7.0/bin" /home/beardhatcode/.nix-profile/bin/pass grep lol
/nix/store/HASH-password-store-1.7.3/bin/.pass-wrapped: line 403: grep: command not found
/nix/store/HASH-password-store-1.7.3/bin/.pass-wrapped: line 403: grep: command not found

Motivation for this change
PassFF did not work properly
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (10 packages built, see bottom)
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

`nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` output

$ nix-shell -p nixpkgs-review --run "nixpkgs-review wip"     ~/Documents/nixpkgs/pkgs/tools/security/pass
these paths will be fetched (2.73 MiB download, 12.96 MiB unpacked):
  /nix/store/1jcc4z7w736sg6va7vxp0aj4z6jicp4d-nixpkgs-review-2.5.0
  /nix/store/6bxr4dvrkl91kdq5p4yphhka9xwid84z-nix-2.4pre20201201_5a6ddb3
  /nix/store/lssm44v6r2b2zr0xsp13qzk2mgl1ibpl-nlohmann_json-3.7.3
  /nix/store/pa9wjfmfv6dchj6kij20vwkv6rpz4b29-nix-2.4pre20201201_5a6ddb3-man
copying path '/nix/store/pa9wjfmfv6dchj6kij20vwkv6rpz4b29-nix-2.4pre20201201_5a6ddb3-man' from 'https://cache.nixos.org'...
copying path '/nix/store/lssm44v6r2b2zr0xsp13qzk2mgl1ibpl-nlohmann_json-3.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/6bxr4dvrkl91kdq5p4yphhka9xwid84z-nix-2.4pre20201201_5a6ddb3' from 'https://cache.nixos.org'...
copying path '/nix/store/1jcc4z7w736sg6va7vxp0aj4z6jicp4d-nixpkgs-review-2.5.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 62, done.
remote: Counting objects: 100% (43/43), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 26 (delta 17), reused 17 (delta 11), pack-reused 0
Unpacking objects: 100% (26/26), 5.00 KiB | 243.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   5d30b8ad31f..263ddd73cd4  master     -> refs/nixpkgs-review/0
$ git worktree add /home/beardhatcode/.cache/nixpkgs-review/rev-a2cc15a0f4e04a66e6d2b941b0697548c4569a83-dirty/nixpkgs 263ddd73cd48820feba9a097311cbbf7424644ae
Preparing worktree (detached HEAD 263ddd73cd4)
Updating files: 100% (23415/23415), done.
HEAD is now at 263ddd73cd4 pythonPackages.class-registry: Add typing propagatedBuildInput when using python2
$ nix-env -f /home/beardhatcode/.cache/nixpkgs-review/rev-a2cc15a0f4e04a66e6d2b941b0697548c4569a83-dirty/nixpkgs -qaP --xml --out-path --show-trace
Applying `nixpkgs` diff...
$ nix-env -f /home/beardhatcode/.cache/nixpkgs-review/rev-a2cc15a0f4e04a66e6d2b941b0697548c4569a83-dirty/nixpkgs -qaP --xml --out-path --show-trace --meta
10 packages updated:
krunner-pass pass-audit pass-extensions-env pass-import passff-host password-store password-store password-store qtpass rofi-pass
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/beardhatcode/.cache/nixpkgs-review/rev-a2cc15a0f4e04a66e6d2b941b0697548c4569a83-dirty/build.nix
10 packages built:
krunner-pass pass pass-nodmenu pass-otp pass-wayland passExtensions.pass-audit passExtensions.pass-import passff-host qtpass rofi-pass
$ nix-shell /home/beardhatcode/.cache/nixpkgs-review/rev-a2cc15a0f4e04a66e6d2b941b0697548c4569a83-dirty/shell.nix

Result of nixpkgs-review run on x86_64-linux 1

10 packages built:

krunner-pass
pass
pass-nodmenu
pass-otp
pass-wayland
passExtensions.pass-audit
passExtensions.pass-import
passff-host
qtpass
rofi-pass

Tests freeze on darwin:
[1/4/8 built, 35 copied (56.4/56.4 MiB), 10.7 MiB DL] building pass-audit-1.1 (checkPhase): EOFError

Have you checked whether this is related to this PR?

Have you checked whether this is related to this PR?

It is unrelated but I am going to disable the tests on darwin.

It is unrelated but I am going to disable the tests on darwin.

I'm sorry, but it doesn't really help if you only mention that something got broken without stating or checking that it's unrelated.
Anyway, this seems to be an issue on 20.09 as well, hence: e34208e10033315fddf6909d3ff68e2d3cf48a23.

I'm sorry, but it doesn't really help if you only mention that something got broken without stating or checking that it's unrelated.

I usually fix such issues myself or just mark it broken on Darwin if it isn't to trivial to fix.
Also checking if it is related in such case is not very appealing because it is potentially going to clock up my workflow and blocking Darwin builds.

Result of nixpkgs-review pr 105869 run on x86_64-linux 1

9 packages built:

krunner-pass
pass
pass-nodmenu
pass-wayland
passExtensions.pass-audit
passExtensions.pass-import
passff-host
qtpass
rofi-pass

I'm sorry, but I really consider this blindly posting build logs without any context or investigation (and only a single log message, full logs can be displayed with nix build -L btw) an actual anti-pattern. Like everyone else contributing here, I do my best to avoid breaking other people's workflow with my changes and if I see such a (IMHO misleading) post, I'll have to check on a platform where I don't own builders for myself, whether I introduced a regression or not.
And to be frank, I'm actually afraid that if we do this more extensively, people will stop taking those posts sufficiently serious and therefore stop caring about fixing potential regressions.
Please don't get me wrong though, of course I don't mean this personally and I appreciate everyone who invests free time in nixpkgs, I just want to make clear that I don't think it's a reasonable approach to report build failures and regressions.


Integrate Mouse Phenotypes summary widget and detail view using with GraphQL API

Mouse phenotype data is now available from the new GraphQL API - see below for a sample query and response.
Query:

Response:

Can we please port the existing summary widget and detail view into alpha, with the following changes?
Summary widget

Display total number of unique phenotypes. Unique phenotypes can be found by iterating through the response and looking at the mousePhenotypes.phenotypes.genotypePhenotype.label values

Detail view

Remove the section that displays the phenotype categories in blue (active) or grey/white (inactive) boxes as it appears to act as a filter with clickable elements but is not interactive

@forus could you take a look at this?

@andrewhercules
I think @mkarmona mentioned similar issue on the last call.
The following GenotypePhenotype (query.target.mousePhenotypes.phenotypes.genotypePhenotype) fields have a string value that has to be split by a comma:
pubmedId: String!
subjectAllelicComposition: String!

Should backend return an array instead?

Hi @forus! Good spot - thank you! I'll follow up with @mkarmona and ask if that can be formatted differently. I would prefer an array just because I can't be certain commas don't exist in a value in the subjectAllelicComposition field.
@mkarmona is this something we can adjust in the back-end? Or for the MVP, should the front-end handle this data processing?

Here is PR https://github.com/opentargets/platform-app/pull/154
We'd have to remove splitting when the back-end will be ready.

Ticket closed as PR approved and merged into alpha


config: enable merge and use table namespace classifier in default

any update?

Before merging this PR, please make sure that a region will not be merged in a short time after it has been split :)

@huachaohuang okay, I am working on it.

any update @Connor1996

Blocked by #1048

/run-all-tests

PTAL @huachaohuang @disksing


setFontFace — I see no changes?

using this:
$line = $bb->newLine();
$line
    ->setText($scores)
    ->setFontFace("courier")
    ->setDropdown(true)
    ->show();

I do not see any changed font? plugin works fine otherwise.
https://github.com/dg01d/bitbar-plugins/blob/master/Sports/worldcup.1m.php
I have confirmed I can see courier using this plugin:
https://github.com/matryer/bitbar-plugins/blob/master/Tutorial/ansi.sh
Any ideas?

If I manually add this
 | font=courier trim=false
I do see Courier.
But still no luck with
$line = $bb->newLine();
$line
    ->setText($scores)
    ->setFontFace("courier")
    ->disableTrim(true)
    ->setDropdown(true)
    ->show();

Looking at the code, I seemed to have made it require a font size as a well as the font name for it to be displayed. Adding
    ->setFontFace("courier")
    ->setFontSize(14)

will fix the issue. I'll look into changing this.
Thanks

Still no luck even with those lines
Neither size nor face take effect :(

A 2 year old PR split the font/size?
https://github.com/SteveEdson/bitbar-php/pull/8

OK, figured it out.
font value needs quoting, will send PR shortly.

@gingerbeardman I've just pushed 0.4.2 which merges #8 and also quotes the values, can you try that please? (Might need to use the master branch if composer doesn't see the change yet).
Thanks

Snap! Same changes I had just made. Your file works a treat
thank you


Converted install part into code block (#47)

Thank you so much for your first contribution!
Without people like you submitting PRs, open source projects couldn't be run.
You rock, @Ben-Ostrovsky! 🚀


fix: error message edits

What does this PR do?
Minor edits to some error messages.
What issues does this PR fix or reference?
@W-9676027@

@peternhale , I tried to fix the NUTs, but they're still failing.  It might have something to do with using single/double quotes in the error message, I don't know how to handle that in the test.  Can you help?  And let me know the correct syntax so I can fix all of this myself in the future?  Thx!


mixin is deprecated in React v0.14, what should we do?

as we all know, mixin is deprecated in React v0.14, so how should we use Srore in component?

Hey @astwyg, usually theres another way to implement the desired functionality without mixins in reflux, could you provide an example of a problem you are running into?

thanks @jamesmarrs , i am new in reflux, but want to use it, while reading demo with mixin function make me  a little worry.

You can still use the programmatic interface for listening to stores, etc.  See #225 for the future– we'll accept a PR to make refluxjs class-based.  If anyone would like to make a note in the readme about this issue, that would be welcome.


[Firefox] Array destructuring with rest element will throw if trailing comma follows

https://www.fxsitecompat.com/en-CA/docs/2016/array-destructuring-with-rest-element-will-throw-if-trailing-comma-follows/

I think we're pretty good about this overall, so closing out. Seems like something our linters should catch if it's a problem on our end.


(1.10.2-3.0.22) Crafting recipe slots that are NULL are not enforced

Issue Description:
Crafting recipe slots that are NULL are not enforced. What I mean by this is that even if a slot is 'null' in a recipe, any item can be placed in that slot in game and the recipe is still valid.
What happens:
Unfortunately if you do go ahead and craft the output, with an item in the 'null' appointed slot, the item in the 'null' slot gets consumed along with the items that are part of the recipe.
What you expected to happen:
The crafting recipe should not be considered valid if extra item's are in 'null' slots. Items that are in 'null' slots should not be consumed when crafting.
Script used:
https://gist.github.com/ShicKla/5ccf373786ad4825fa90d1389ea1e5e1
Minetweaker.log file:
https://gist.github.com/ShicKla/d13359564e3c36f74b693d8b797b2ded

Affected Versions (Do not use "latest"):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>1
Crafttweaker: 3.0.22

Your most recent log file where the issue was present:
https://gist.github.com/ShicKla/90c808f34157d8b0cd8b1751ce7d08db

Any chance you could give me a vanilla script that causes this bug?

I take it you found and solved the issue and no longer need a vanilla script?

Yip, seems to be fixed


Fix building this project and make it robust

The current version of metacpan-docker is completly broken. It worked fine when it was createad (about a year ago), but now it does not work. The problem is that the surrounding world has changed. Some packages disappeared (see #9 ), some new dependencies appeared ( see #6 )
This project has to be fixed. The main idea that we need to create this project in the way the changes in the surrounding world should not matter. We need to explicitly specify all the dependencies and versions.
The other thing that I want to be done is to simplify the process of running this project.
So, this is the plan:

use docker-compose
remove elasticsearch Dockerfile and to use elasticsearch image from the docker hub
explicitly specify git commits from cpan-api and metacpan-web project

I'm going to implement it in the separate git branch dev

I did some work for this issue. The current HEAD of dev git branch is 6058ea3c0b0a19e938670a6918b2923c3faadb91
But now cpan-api shows error:

Error while loading /app/app.psgi: Couldn't instantiate component "MetaCPAN::Server::Model::Source", "Attribute (cpan) does not pass the type constraint because: Validation failed for 'MooseX::Types::Path::Class::MoreCoercions::Dir' with value undef at constructor MetaCPAN::Server::Model::Source::new (defined at /app/lib/MetaCPAN/Server/Model/Source.pm line 86) line 38.

Full log — https://gist.github.com/bessarabov/cb18d69f289236c696e8

explicitly specify git commits from cpan-api and metacpan-web project
I think will be better use tags (I know its same, but name is better then hash) or releases for this...

btw. docker-compose is good for testing, but maybe not for production

Correct. Metacpan does not use neither docker-compose, nor docker in production. Here is the metacpan repo with puppet configuration for development, test and production servers https://github.com/CPAN-API/metacpan-puppet
The current project metacpan-docker is an experiment to create development environment in docker.

explicitly specify git commits from cpan-api and metacpan-web project
I think will be better use tags (I know its same, but name is better then hash) or releases for this...

Yep. I would be glad to use tags instead of commites. But neither cpan-api, nor metacpan-web use tags to mark releases:

https://github.com/CPAN-API/cpan-api/tags
https://github.com/CPAN-API/cpan-api/tags


vscode.window.state.focused not working with i3 window manager

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.66.0-dev
OS Version: Ubuntu 22.04 LTS

Steps to Reproduce:
Apologies if this is not the right place to post this, I didn't see it in the above links. This issue occurs for extension developers trying to use the vscode.window.state.focused API.

Open up VSCode. Add a focus tracker like the following in the DevTools console:

vscode.window.onDidChangeWindowState(state => {
  console.log('state change', state.focused);
});

Check to make sure this works by switching tabs. This should be working as intended.
Try switching windows with the i3 window manager. You should see that the console log has not been triggered.

Thanks for your help and for building such a great product!

See https://github.com/i3/i3/discussions/4972 for some discussion as to why this may be occurring.

@joaomoreno you added this API

Also added @deepak1556 since this might be an electron issue

I don't have i3 window manager setup to verify this issue, @KevinVillela is there a simpler repro that does not involve i3 ?

Hi @deepak1556, thanks very much for your response! Yes, I did find a way to reproduce this without i3. It seems like if you are on a more standard window manager (such as GNOME), switching windows does not cause the focused attribute to change either. So actually, this seems like a much larger issue than just not working with i3 - it doesn't work for switching windows in general, only for switching tabs.

I am unable to repro with latest stable 1.85 on gnome, the states are logged are correctly when switching windows. Please check if the issue is resolved.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Feature/direct dependency netcoreapp

Fix for https://github.com/Mapsui/Mapsui/issues/1240#issuecomment-927019104


Add Windows Shell syntax examples to GitHub Actions Workflow commands

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions?ref=jessehouwing.net&tool=powershell
What part(s) of the article would you like to see updated?
Code samples in Windows Shell syntax.
In the past I've already contributed the PowerShell samples, I want to propose we add the Windows Shell examples as well. I have a blog post on that subject and it still draws quite a bit of traffic.
Additional information
https://jessehouwing.net/github-actions-workflow-commands-in-cmd/

@jessehouwing Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

Hey @jessehouwing, thanks for opening this issue.
We really appreciate the PowerShell examples you contributed in the past! Because Microsoft has switched to PowerShell over CMD.EXE as their default shell and they encourage people to use PowerShell instead, I don't see a case for adding a new tool switcher and updating all of our examples to include a Windows shell version. In light of that, I'm going to close out this issue.
Thank you for your thoughtful idea and contributions to the docs! 💛


Typo in 'Basic JavaScript: Build JavaScript Objects'

Did you guys mean 'as long as "name" is a string' in last paragraph?

Yes, I think that's the intended motive. Please go ahead and create a PR or let us know so I'll put it up for other contributors!

I'll create a PR :)

"as long as" conveys the message to the learner that name must be of the string datatype


Search in folders and text

It would be nice if the search would also look in sub-folders and at the text inside the files.

This would be great!


[question] Is it possible to avoid database requests using scopes?

I'm trying to use scopes with fastapi-users. Is there a simple example of how to use scopes?
My goal is to use scopes for things that don't require accessing user data (e.g. I don't need to query the database and get user id if my API is just rendering a list (in memory/redis) that requires the user to have read access), for this I can just check the scope.
Is it possible?

Hi @nullhack, working on this kind of things this weekend I found this library (fastapi-permissions) and it's used by Netflix on the dispatch project (dispatch)
It's not using scopes, but I think that could be a good starting point. @frankie567 maybe could be included in fastapi-users to manage the permissions?

Thank you, I'll take a look.

Currently, the approach is to check against the database if the user id. in the JWT still exists and that it has the right permission (active and superuser).
However, if you implement your own authentication class, I think you can make an authentication that works without DB query. The only constraint is that it returns a valid User object.
I think a scope approach could be interesting, but I don't think it's in the scope of this project. I think we can wire things pretty easily between fastapi-permissions (for example) and fastapi-users with dependency callables.

The only problem I see is that by design, fastapi-users check against database for every request. This defeats the purpose of permissions from scope (we want to check fast without database requests as much as possible).

However, if you implement your own authentication class, I think you can make an authentication that works without DB query

This would be nice.


StackOverflowError on inserting Entity

Hey,
I've spent a couple hours trying for the life of me getting Requery working as intended.  After stumbling around for a while, I've hit this error and cannot proceed.
@Entity
public interface InterfaceTest extends Persistable {
    @Key @Generated
    int id();

    @OneToMany
    List<WtfInterfaceEntity> getTests();

    String string();
}

@Entity
public interface WtfInterface extends Persistable {
    @Key int getId();

    @ManyToOne
    InterfaceTestEntity entity();
}

@RunWith(AndroidJUnit4.class)
public class ApplicationTest {
    public static EntityDataStore<Persistable> dataStore;

    @BeforeClass
    public static void init() {
        DatabaseSource source = new DatabaseSource(InstrumentationRegistry.getTargetContext(), Models.DEFAULT, 1);
        source.setTableCreationMode(TableCreationMode.DROP_CREATE);

        dataStore = new EntityDataStore<>(source.getConfiguration());
    }

    @Test
    public void testInterfaceModel() {
        dataStore.delete(InterfaceTestEntity.class).get().value();

        InterfaceTestEntity entity = new InterfaceTestEntity();
        entity.string("test");

        for (int i = 0; i < 10; i++) {
            WtfInterfaceEntity test = new WtfInterfaceEntity();
            test.setId(i);
            test.entity(entity);

            entity.getTests().add(test);
        }

        dataStore.insert(entity);
        int count = dataStore.count(InterfaceTest.class).get().value();

        assertEquals(1, count);
    }
}

The resulting test operation returns a StackOverflowError, on dataStore.insert(entity);
The full logcat for this is here
Thanks!

Thanks for reporting. You don't need to explicitly set test.entity(entity); thats whats causing the problem in this case it. Before an insert you only need to modify the side of the entity being persisted. However it shouldn't cause an overflow, a fix will be provided in the next update.

@npurushe
Unfortunately, even with the removal of test.entity(entity);, I still get the stack overflow.
Looking forward to the update though!

Can you retry with the beta19 version, thanks

@npurushe
Still getting a StackOverflowError on beta19.
Here is the new logcat - stack trace is a little different.

@npurushe
Getting the same StackOverflowError on beta19 - logcat can be found here


Wrong verifying key contract permutation length can be considered valid by validateVKPermutationsLength

The function validateVKPermutationsLength is used to validate the number of permutations in the verifying key contract corresponds to the circuit used to generate proof for the number of cryptocurrencies the custodian committed to. The Summa contract assumes that permutations commitments begins at bytes 0x2e0 in the vKContract (source)
This can lead to wrongfully consider valid vkContracts with different permutation commitments from the circuit used by the custodian. A simple case would be a verifying contract with 2 fixed commitments but one permutation commitment less than the one being used. In this case, all others things being equals, the permutations commitments would not begin at bytes 0x2e0 but at 0x0320. As the length of the bytes of the contracts are still equals due to one permutation in less, validateVKPermutationsLength would consider this vkcontract valid but in fact is not.

I suppose this is kinda analogous / related to how SnarkVerifier loads exactly 0x0560 bytes from the vk contract
https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/SnarkVerifier.sol#L218
If the no. of commitments change, then the length of the bytecode loaded also changes, no? But I suppose extcodesize could be used while sacrificing some gas costs for this.
But I think the point I'm tryna make is maybe Summa.sol is justified in using a hardcoded length in lieu of SnarkVerifier using hardcoded ptr location / lengths. But the latter the generated whereas the former is written. So I suppose there should some manual/automated verification that this pointer is correct on each iteration?

I don't understand this part:

A simple case would be a verifying contract with 2 fixed commitments but one permutation commitment less than the one being used
Could you elaborate?

I don't understand this part:

A simple case would be a verifying contract with 2 fixed commitments but one permutation commitment less than the one being used
Could you elaborate?

Sure, it is a follow up of this discussion https://discord.com/channels/877252171983360072/1230201530582568962/1230453113199263777
Commitments are hardcoded in the Halo2VerifyingKey
https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/VerifyingKey.sol#L30
Hence, if a different VerifyingKey contract is created with same bytecode size but different commitments, it can be considered valid by validateVKPermutationsLength function
https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/Summa.sol#L151
In the current one, https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/VerifyingKey.sol there are 1 fixed commitments and 10 permutation commitments.
We could imagine a new contracts with 2 fixed commitments and 9 permutations commitments, this one would still be considered valid by validateVKPermutationsLength function even if the number of permutations commitments is invalid.

Although I did not notice any of the verifiers using pointers starting from the commitments. They all seem to only use the ptrs until neg_s_g2_y_2:

The permutation commitments are utilized during the verification process in SnarkVerifier.
This verifier copies all verifying keys as shown here:
https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/SnarkVerifier.sol#L218

To further clarify the example, let's consider how manipulation could occur in the current Summa implementation.
A prover wishing to manipulate the validateVKPermutationsLength function might modify the circuit to accept additional public inputs.
Although this scenario does not perfectly align with the case discussed, as the increase in fixed commitments would change the base number of permutations from 2 to 3 in the formula, resulting in a modified formula: numPermutations = 3 + (balanceByteRange/2) * numberOfCurrencies instead of https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/Summa.sol#L147
This demonstrates that adjustments can be made by altering the circuit configuration.
Subsequently, the prover would need to send the commitment transaction with more public inputs. Here, I assume the Summa contract has been modified to accommodate two public inputs by adjusting the arguments here: https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/Summa.sol#L239
It's important to note that the prover would need to modify other hardcoded numbers to achieve a valid result from the validateVKPermutationsLength by altering the number of permutations, without changing the hardcoded startOffsetForPermutations. More importantly, users can easily notice a commitment transaction designed for two fixed columns, which is inconsistent with having just one public input.
Furthermore, another variable, offsetAfterLastPermutation, depends on numPermutations as well as startOffsetForPermutations. https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/Summa.sol#L154-L156
It can also produce a valid result with an incorrect number of currencies and a different balanceByteRange.
For example:

With a balanceByteRange of 4 and numberOfCurrencies as 5, it calculates numPermutations as 20.
The same result occurs if numberOfCurrencies is 4 and balanceByteRange is 5.

This outcome follows the formula:
https://github.com/zBlock-2/summa-solvency/blob/fec83a747ead213261aecfaf4a01b43fff9731ee/contracts/src/Summa.sol#L147-L149
However, such discrepancies are typically obvious to users when they attempt to verify their proofs.


Hide three dot in header when request is deleted

Details

We will change the logic to prevent the inconsistent of header and hide three dot when the request is deleted
Fixed Issues

$ https://github.com/Expensify/App/issues/26019
PROPOSAL: https://github.com/Expensify/App/issues/26019#issuecomment-1707647466
Tests

Create a request money
Go to the transaction thread report of the request
Send a message in this report
Click on the three-dot icon in the header and delete the request
Verify that the three-dot icon is hidden after the request is deleted
Delete the message that is sent in step 3
Verify that the title in header doesn't change

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a request money
Go to the transaction thread report of the request
Send a message in this report
Click on the three-dot icon in the header and delete the request
Verify that the three-dot icon is hidden after the request is deleted
Delete the message that is sent in step 3
Verify that the title in header doesn't change

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast from 26-09-2023 11:58:23.webm

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/2d1e30e9-1c41-4a11-b9ca-b4c552e59cd3

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/675c2894-3127-4714-9bae-54a3b1c3f53e

Desktop
https://github.com/Expensify/App/assets/129500732/11a671cb-8d47-4bef-bd65-ded828adc1a6

iOS
https://github.com/Expensify/App/assets/129500732/7e06bc3c-3401-45dd-93a1-908dc2246d24

Android
26019.webm

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.84-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.85-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Coming from https://github.com/Expensify/App/issues/36496, we missed updating ReportScreens memoization to take into account the parentReportAction, which resulted in the delete option persisting until after refresh. More details here.


adding dockerization. refactored broken stuff

adding dockerization. fixing broken npy arrays atm

i cleaned up the npy arrays in my pr if ya wanna look, FacialRecog line 170. Is the docker stuff good to go?

lets merge this once the other two parts are consolidated

and just focus on the docker part of it


"ReferenceError: window is not defined" when used with server-side rendering

Description
When using this plugin in a project that is server-side rendered, we get the error ReferenceError: window is not defined indist/index.js:1:278, because window does not exist in a server-side environment.
Expected behaviour
The plugin should be working with server-side rendering.

Issue is fixed in v0.1.2

Thanks!


Show what Template a user is editing

IMO it's a bit risky that during use of the form builder you don't see what template you are editing  and also that there is no indication of how often this template is used.
I think most site administrators will just go to a page, edit the used template and not release that the template might also be used on other pages.
Therefore I suggest adding both the name and usage of the template to the Form Builder:

Obviously it should be "5 Page(s)"

IMO it would also be good to show this on the form settings.


[BUG]: [UAT | "Issued To" field is not displaying as expected for payment of summons for both litigant and advocate users.]

Describe the bug
The "Issued To" field is not displaying as expected for payment of summons for both litigant and advocate users.
To Reproduce
Steps to reproduce the behavior:

Go to 'advocate -> file a new case'
Go to judge user
register case -> issue order -> notice -> join same case with advocate
Go to Judge user -> admit case -> schedule admission hearing -> issue summon
go to advocate or litigent
check error

Expected behavior
The "Issued To" field should display the name of the accused.
Screenshots

Desktop :

Browser [chrome]

Tested in uat env, working as expected.

cc: @rajeshcherukumalli @Ramu-kandimalla


Fix rules for indenting multiline assignments

https://trello.com/c/8plKSKKM
See https://github.com/bbatsov/rubocop/issues/1633

:+1:

Do you mind also adding in to thoughtbot's config?

@salbertson What are your thoughts on also making this change in default? It would mean drifting away from RuboCop's default, but this is really an ugly setting. I fear I might be getting too personally attached to the defaults.

@gylaz, I don't think we should be affecting existing users by updating defaults, unless we think it's important enough and we communicate the change to everyone.

@graysonwright, should this be added to the thoughtbot config too? Maybe in a different PR?
This looks good to me. :+1:

Our styleguide is not updated for this https://github.com/thoughtbot/guides/blob/master/style/README.md#formatting
We should open a PR to thoughtbot/guides before changing it in Hound, everyone at thoughtbot doens't follow the developments made in Hound but they watch Guides.
I personally don't agree with this styleguide and would like it to be discussed, if the majority is in favor of this - we keep it. If not, let's chage it back to the defaults
ping @thoughtbot/hound @jferris @graysonwright

@teoljungberg Just to clarify you prefer:
users = User.where(email: 'user@example.com').
             update(user_parameters)

This PR changes this to favor:
users = User.where(email: 'user@example.com').
  update(user_parameters)

And while it might not be explicitly in our guides, 99% of thoughtbot code follows the latter.

Actually, we do have a guideline for it:

Indent continued lines two spaces.

Actually no, this rule enforces this style (sorry for a shitty example, typing from my phone)
users = Users.
active.
awesome.
tall

Teo Ljungberg

On 5 maj 2015, at 22:18, Greg Lazarev<EMAIL_ADDRESS>wrote:
@teoljungberg Just to clarify you prefer:
users = User.where(email: 'user@example.com').
update(user_parameters)
This PR changes this to favor:
users = User.where(email: 'user@example.com').
update(user_parameters)
And while it might not be explicitly in our guides, 99% of thoughtbot code follows the latter.
—
Reply to this email directly or view it on GitHub.

@teoljungberg Can you clarify where you're getting your information from? This comment https://github.com/bbatsov/rubocop/issues/1633#issuecomment-73067109 seems to be inline with what I've said, and the general spirit of this PR.

@gylaz I pinged you in the repo where we have the problem

I don't know what's going on on that related PR. I've added unit tests for this setting in #772.


Tournament Playoff View

I tried to keep it as close to the design as possible. But I don't know how to draw the lines.
I don't know how to call the match object from each Match. So there's no onclick function added yet.
This branch is created on top of #60.

I tried to keep it as close to the design as possible. But I don't know how to draw the lines. I don't know how to call the match object from each Match. So there's no onclick function added yet. This branch is created on top of #60.

I think we could look into the overall styling a bit more. We can look into it tomorrow

I think that overall this looks okay to me.
Regarding the API calls; The overall routing still needs a bit more tweaking, but once the rest of the match-related PRs are done, we can finish up everything and make sure that the routing is correct. Once that's done, it should be fairly straightforward to query any data (although I don't know what it needs to query, since the data is coming from the tournament already)

I think that overall this looks really good.
Regarding the API calls; The overall routing still needs a bit more tweaking, but once the rest of the match-related PRs are done, we can finish up everything and make sure that the routing is correct. Once that's done, it should be fairly straightforward to query any data (although I don't know what it needs to query, since the data is coming from the tournament already)

I think the only thing that's left is to open the match view/game view if I click on a specific match.


create intake source for metric correlation plot

Is your enhancement request related to a problem? Please describe
we would like to be able to share visualizations alongside the projects and experiments in the intake catalogs. for example, catalog.read() returns projects and experiments. we'd like to ultimately have something like catalog.serve() that mimics the viz module's serve functionality to launch a dashboard with the experiments returned by catalog.read()
in #441 we created a base source for visualizations. in #442 we created a source for the experiments table. we will need a concrete implementation for each visualization like the one implemented for #442. this issue will track the creation of a source for the metric correlation plot
Describe the solution you'd like
add a new MetricCorrelationPlotDataSource that extends VizDataSourceMixin. the __init__ function should take in any additional arguments specific to the MetricCorrelationPlot. _get_schema should create a visualization and set it as the _visualization attribute, as well as update the metadata with any required attributes
Additional context
at this point, the visualization stored in _visualization does not need to have any experiments in it - we'll get to that later
this should be implemented very similarly to the solutions to #442 and #453. it may even be possible to move some common functionality between the existing sources and the new MetricCorrelationPlotDataSource to the base VizDataSourceMixin if its shared across both viz's implementations

closed w/ #464


affected/package: bufio.Scanner

What version of Go are you using (go version)?

$ go version
go 1.19

Does this issue reproduce with the latest release?
No, I don't try
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\12528\AppData\Local\go-build
set GOENV=C:\Users\12528\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=D:\Coding\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\Coding\go
set GOPRIVATE=
set GOPROXY=https://goproxy.cn,direct
set GOROOT=E:\Program Files\GoVersionTools\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=E:\Program Files\GoVersionTools\go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.19.10
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\12528\AppData\Local\Temp\go-build2405066100=/tmp/go-build -gno-record-gcc-switches

What did you do?
In a for loop use bufio.scanner. When in second loop the firstFileScanner.Scan()  retrun false directly!
	secondFileScanner := bufio.NewScanner(secondFile)
	defer close(b.loginCredentialsChan)
	for secondFileScanner.Scan() {
		select {
		case <-b.ctx.Done():
			return
		case <-b.boomDoneSignal:
			return

		default:
			if b.boomStatus.Load() {
				return
			}
			secondText := secondFileScanner.Text()
			firstFileScanner := bufio.NewScanner(firstFile)
			for firstFileScanner.Scan() {
				select {
				case <-b.ctx.Done():
					return
				case <-b.boomDoneSignal:
					return
				default:
					if b.boomStatus.Load() {
						return
					}
					credits := make(map[string]string, 2)
					credits["first"] = firstFileScanner.Text()
					credits["second"] = secondText
					select {
					case b.loginCredentialsChan <- credits:
					case <-b.boomDoneSignal:
						return
					}
				}
			}
		}
	}

What did you expect to see?
No matter how many times the firstFileScanner is looped, it can always scan until all data of firstFile is scanned in the current loop.
What did you see instead?
it return false and I have debugged it found that in second loop this line return an EOF error https://github.com/golang/go/blob/dbf9bf2c39116f1330002ebba8f8870b96645d87/src/bufio/scan.go#L214

looks like a bug in your program.
the reader passed to bufio.NewScanner is never reset.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

looks like a bug in your program. the reader passed to bufio.NewScanner is never reset.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

I give it a os.File not a io.Reader

@Fly-Playgroud The statement is still true: whatever is passed to bufio.NewScanner is not reset.  Since bufio.NewScanner takes an io.Reader argument, it's correct to describe that as a reader.

The problem is *bufio.Scanner has to be created from scratch even if the file is readable after seeking, here is where it returns false.

I think *bufio.Scanner should provide a method Reset() to reset scanner , in this way it's understanded easily

@Fly-Playgroud Note that by itself that wouldn't help.  You would also need to use the Seek method to move the file position back to the start of the file.  The bufio.Scanner can't do that for you.


add mention of word_separators config opt in Word Triggers

I only found out about word_separators by looking at Espanso issues and finding this comment: https://github.com/espanso/espanso/issues/1411#issuecomment-1289617358
This PR adds a quick mention of the config option and a link to the configuration options page.

Thank you - I agree, and have included it with a number of other minor changes in a version of the docs which is awaiting a PR.

This has been superseded by #36


Update folder structure to follow standard Maven layout

This removes the need for using SafeReflection as all versions are handled natively. If you compare to other large frameworks that offer multiple versions, this is how they support them. It makes it significantly easier to maintain.

Just glancing over the changes, I believe the need for SafeReflection is still required. SafeReflection is used for compile-time checks for reflective calls (e.g. getting a field named "a"). Without it, there is no way to determine for a specific version of Bukkit/Spigot whether certain fields exist/don't exist at compile time.

But with the changes in those commits you don't actually need to use reflection for anything. The wrappers you already have and the sub-module layout replaces them except for on the direct implementation layer.

Ah yes, you're right. It seems that I overlooked that. Good job.
It looks good to merge, but I'd prefer to do my "regular testing" when it comes to merge requests, so in accordance with this, I'll plan to include it in the upcoming release, but for now will not do any further action.
I also plan to keep this pull request open until it has been merged (otherwise I'd forget!)

@Michael-Ziluck Hi again, long time no see.
After taking some time out to work on other things, I've finally come back to the CommandAPI to release version 3.0. However, I've been unable to compile it properly with your proposed Maven layout, primarily because the spigot libraries (not to be confused with spigot API libraries), cannot be resolved.
Evidently, the spigot repository here does not declare the spigot.jar files, only the spigot-api.jar files.
Unfortunately, I'll probably have to revert to the (very long and time consuming) technique of having to manually build the .jar files (which is compliant with the licenses of CraftBukkit) and linking them locally to the CommandAPI.


⚠ Samsung has degraded performance

In b99a907, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2241 ms

Resolved: Samsung performance has improved in bdccd0f.


when combining predicted annotations with scribble annotations it makes a mistake in the label

this is because it sums both labels, if the previous label is 2 and you added 3 then it's 5

fixed!


How to make client subscribe to channel on server

I want to subscribe to channel on server,how to do it?
I try to do:
socket.exchange.subscibe(channel)
but it did not work.

When you start the worker
worker.scServer.exchange.subscribe('channel')
http://socketcluster.io/#!/docs/api-scworker

thanks,but I mean make client subscribed channel on server

@luozan You can't subscribe a client to a channel from the server side directly, but you can emit an event from the server socket.emit('tellClientToSubscribe') then on the client:
(example)
socket.on('tellClientToSubscribe`, function () {
  soket.subscribe('someChannelName').watch(function (data) {
    // ...
  });
});

Subscribing on behalf of the client from the server side would be a pub/sub anti-pattern and could cause issues.

I making a online game.Game players in a virtual room (A channel) before game start,but I can't sure whether player entered room (player subscribed channel) or not,then I don't know when to send start event or other events.
If server waits for client  to return the result of subscription,I worry that client does't return it.It's a html5 game,so player modifys the code is very easy

My English is so bad,so I hope you can understand.Thanks.

@jondubois I also want this feature.
@luozan Do you have a solution for this case?

idk how @luozan resolved this, but an easy and fast way to solve this would be to just use Redis to store the client state.

you can call subscribe from the socket object directly.
// On some event
socket.subscribe('SOME_CHANNEL').watch((data) => {
// Handle data
})

Have to admit I'm surprised by this.
Is there any reason why the a socket cannot subscribe on the server?

@davidmoshal the principle is that the consumer of the data should decide what channels it needs.
If the server socket also participates in the decision to subscribe/unsubscribe to/from a channel on behalf of a socket, then we would be sharing concerns/responsibilities with the client - This can lead to anti-patterns in the code.
That said, the server socket can emit an event to the client socket to advise it to subscribe to a specific channel but the client socket makes the final decision.


invalid quoted expression: %{}

Hi,
I'm trying to compile my first project with WalEx. So I created a small project to test the lib and I got the following compilation error: invalid quoted expression: %{}
I used this code :
defmodule MyOwnApp.Events.Users do
  use WalEx.Event, name: MyOwnApp

  # any subscribed event
  on_event(:all, fn events ->
    IO.inspect(events: events)
  end)

  # any user event
  on_event(:users, fn users ->
    IO.inspect(on_event: users)
    # do something with users data
  end)

  # any user insert event
  on_insert(:users, fn users ->
    IO.inspect(on_insert: users)
  end)

  on_update(:users, fn users ->
    IO.inspect(on_update: users)
  end)

  on_delete(:users, fn users ->
    IO.inspect(on_delete: users)
  end)
end

And I'm using the version 4 of WalEx.
Any idea? I'm a bit rusted with Elixir macros 😅

I missed this message @FabienHenon - were you able to figure the issue out? If not, can you describe it in more detail with logs if possible? Merci.

Hi,
Yes I was able to fix the issue.
It was because I was using the default value of the filters parameter (of the on_event macro), which is %{}. This value, when in the macro, is still %{} and cannot be unquoted (This is the exception I got).
I tried to escape it with Macro.escape before unquoting it and it worked, but then it stopped working when I passed a value to the filters parameter of the macro (not using the default value).
In this case, the unquoted value of the parameter was {:%{}, [], []}, which was not correct.
I don't know how to make defautl parameter value and explicit value work at the same time with macros.
So I didn't change the code and put %{} explicitly as value for the filters parameter of the on_event macro. It works like that (but not if I use the default value)
I also noticed another issue, with the replication slot this time.
When I do not manually set the slot_name config parameter, one is generated.
But the generated name uses forbidden characters (like dot '.').
Thus the query fails.
To solve this issue I explicitly set the slot_name config parameter value myself.


Update constants.js

Classes are being removed, see https://github.com/EthanVieira/rs-clicker/pull/33


DSD-922: focus styles for Radio and TextInput

Fixes JIRA ticket DSD-922
This PR does the following:

Updates the focus styles for the Radio and TextInput components.

How has this been tested?

These updates cleanup the focus styles for Radio and TextInput and make them more consistent across all form element.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[x] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr958-gmcokws8zfx7i1dr3dxw1hoy1hcyxoio.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62597f2785a2084f1d6377bf

Tugboat has finished building the preview for this pull request!
Link:

https://pr958-gmcokws8zfx7i1dr3dxw1hoy1hcyxoio.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62597f2785a2084f1d6377bf

Tugboat has finished building the preview for this pull request!
Link:

https://pr958-gmcokws8zfx7i1dr3dxw1hoy1hcyxoio.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62597f2785a2084f1d6377bf

Tugboat has finished building the preview for this pull request!
Link:

https://pr958-gmcokws8zfx7i1dr3dxw1hoy1hcyxoio.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/62597f2785a2084f1d6377bf


XPathMatcher doesn't find the path in the XML document if searched with tag attribute and hence changeTagValue recipe doesn't work as expected.

What version of OpenRewrite are you using?

I am using
Latest openrewrite dependencies in my project
How are you running OpenRewrite?

I have written a test case and executing the recipe against that test case
 @Test
    void changeAppNameInLog4jXML(){
        rewriteRun(
          spec -> spec
            .recipe(new ChangeTagValue("/Configuration/Properties/Property[@name='appname']","abc","def")),
          xml(
            //language=xml
            """
             <?xml version="1.0" encoding="UTF-8"?>
             <Configuration status="trace" verbose="true">
                 <Properties>
                     <Property name="appname">abc</Property>
                     <Property name="logpath">hello
                     </Property>
                 </Properties>
             </Configuration>
              """,
            //language=xml
            """
             <?xml version="1.0" encoding="UTF-8"?>
             <Configuration status="trace" verbose="true">
                 <Properties>
                     <Property name="appname">def</Property>
                     <Property name="logpath">hello
                     </Property>
                 </Properties>
             </Configuration>
              """
          )
        );
    }

What is the smallest, simplest way to reproduce the problem?

 @Test
    void changeAppNameInLog4jXML(){
        rewriteRun(
          spec -> spec
            .recipe(new ChangeTagValue("/Configuration/Properties/Property[@name='appname']","abc","def")),
          xml(
            //language=xml
            """
             <?xml version="1.0" encoding="UTF-8"?>
             <Configuration status="trace" verbose="true">
                 <Properties>
                     <Property name="appname">abc</Property>
                     <Property name="logpath">hello
                     </Property>
                 </Properties>
             </Configuration>
              """,
            //language=xml
            """
             <?xml version="1.0" encoding="UTF-8"?>
             <Configuration status="trace" verbose="true">
                 <Properties>
                     <Property name="appname">def</Property>
                     <Property name="logpath">hello
                     </Property>
                 </Properties>
             </Configuration>
              """
          )
        );
    }

What did you expect to see?

<?xml version="1.0" encoding="UTF-8"?>
             <Configuration status="trace" verbose="true">
                 <Properties>
                     <Property name="appname">def</Property>
                     <Property name="logpath">hello
                     </Property>
                 </Properties>
             </Configuration>

What did you see instead?

The XPathMatcher doesn't reach the Property tag with the name attribute.
What is the full stack trace of any errors you encountered?

Thanks for the report. As I recently did some work on this, I will look into it to make sure my changes didn't introduce any regression.

There was no regression here. Matching attribute values in predicates was just nothing we supported so far. I've created a PR for this.


we need to keep our changelog updated

We need to keep our changelog updated - it's viewable from the preference page.

How do we close this issue? :)

Update it once? :)
We could also remove it if we don't want the overhead right now.


customized pathway database

Dear developers,
I was looking for a way to import customized pathway database (e..g, gmt file) for geneset visualization and gsea analysis. Do you have any suggestions?
Also, the new version of cellxgene provides some cool functions for geneset visualization, will cellxgene vip be able to sync those geneset info with cellxgene as well?
Thanks!
Dongdong

Yes, you can download/prepare GMT files, and put them into the "gsea" folder, and run ./update.VIPInterface.sh, all those GMT files will be copied into the VIP and you will be able to see them in your next VIP lanuch.


Possible performance regression from v0.4.2 to v0.5.0?

Hi again :D
I have some e2e tests with playwright testing the behaviour of the monaco editor with tailwind and my whole integration.
They still seem to work perfectly with v0.4.2 but when upgrading to v0.5.0 some seem to fail constantly due to timing issues.
After sleeping for 500ms at a few points it seems to be working again but is obviously not ideal.
Do you have a guess what could have affected this? Maybe tailwind 3.2 is more performance hungry or something...
Its just odd that it seems to be notable ...

After adjusting the timing it seems to work now reliable so no need to investigate i think

Sorry, I saw the notification for this, but forgot about it.
I have integrated this library in a project, but I don’t use it a lot myself. It’s good to report such regressions if you suspect them.
After your last comment, my guess is it might have been a caching issue? The old version was cached, but not the new one. I’m just guestimating though.

no problem :) i suspect tailwind 3.2 is just a bit more performance hungry or sth.
it was not a caching problem as it was tested via playwright isolated ^^
but when using it manually i couldnt find anything so everything fine.


[WFAPI-1303] Added 'rake pub_sub:cleanup' task

Would you please add a description of what this PR introduces. What's a cleanup in the context of rake pub_sub


mxnet-full jar depends on mxnet-core and mxnet-infer jars while containing all their classes

The current Maven build for Scala produces mxnet-full_2.11 package which pulls mxnet-core and mxnet-infer packages by dependency. However mxnet-full jar already contains all the classes from those 2 jars, so there is no need to include them again.
MXNet commit hash: 77254f2a829d481d61e015e900923f1edb4af39f.

@mxnet-label-bot add [scala, build]

@vkorenev Are you looking at the versioned mxnet-full or the INTERNAL one? When you build the assembly module, it flattens and includes the code from the other modules. Once they are flattened, we deploy it and use https://github.com/apache/incubator-mxnet/blob/master/scala-package/deploy/pom.xml as the pom.xml instead of the one inherited from the assembly plugin. You can view the deployed version by running mvn deploy and then looking in your deploy/target/repo folder

Then mvn install should replace the pom before installing mxnet-full to the local repo.

We currently use the deploy plugin to replace the pom file so this isn't a tiny change. We also have fewer details such as no hardware (CPU/GPU) when you use the install version which many of our scripts depend on.
You could try using mvn deploy -Drepo_url=file://$HOME/.m2/repository and that would give you a full release with the replaced POM and version 1.5.0-SNAPSHOT.


Long name causes navbar to wrap to next line on mobile

Observed/problematic behavior

Expected behavior
The navbar should be in one line
Steps to reproduce

Have a long name
Use a phone
Device info:
Samsung s21 5g g991w
Resolution: 1080px × 2400px
https://blisk.io/devices/details/galaxy-s21

Other
No response

The navbar should be in one line

I disagree, if there isn't enough space, what else should we do? I made it look slightly better tho


modify path in order to include new version

Reviewers
@hmunfru @jframos
Description
change path parameter. Fix issue 4020
Test
tested locally

Coverage increased (+0.1%) when pulling 4d899b258d4cd9b1c4c6102df34ce9d03dbebab7 on jesuspg:bug/4020_update_product_version into c88829c09bdef1c1b862f1750d5b1ca4a94c78d0 on telefonicaid:develop.

LGTM

LGTM


chore: use 'https' protocol for .net 6.0 devfile. Update schema to 2.2.0

What does this PR do?:

update schema to the 2.2.0 (latest 2.2.2 is not yet supported - https://github.com/devfile/api/issues/1454)
use 'https' protocol for .net 6.0 devfile

Which issue(s) this PR fixes:
N/A
PR acceptance criteria:

[ ] Contributing guide
Have you read the devfile registry contributing guide and followed its instructions?
[ ] Test automation
Does this repository's tests pass with your changes?
[ ] Documentation
Does any documentation need to be updated with your changes?
[ ] Check Tools Provider
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:
try it out on Developer Sandbox - https://workspaces.openshift.com/#https://raw.githubusercontent.com/devfile/registry/1f99545009bad5ab1f3231c66bcd6bf29d583573/stacks/dotnet60/devfile.yaml

@kadel @yangcao77 folks, could you clarify why 2.2.2 is not supported ?
rror: failed to generate index struct: /build/stacks/dotnet60 devfile is not valid: failed to populateAndParseDevfile: unable to find schema for version "2.2.2". The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, v1alpha2

@kadel @yangcao77 folks, could you clarify why 2.2.2 is not supported ?
rror: failed to generate index struct: /build/stacks/dotnet60 devfile is not valid: failed to populateAndParseDevfile: unable to find schema for version "2.2.2". The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, v1alpha2

@kadel @yangcao77 folks, could you clarify why 2.2.2 is not supported ?
rror: failed to generate index struct: /build/stacks/dotnet60 devfile is not valid: failed to populateAndParseDevfile: unable to find schema for version "2.2.2". The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, v1alpha2

My bad I've tested with schemaVersion 2.2.0 instead of 2.2.2. I've removed my approval :smiling_face_with_tear:
I think atm the supported versions of the devfile library are listed here so the v2.2.2 is not yet supported from the parser. @ibuziuk would it make sense to change the schemaVersion from 2.2.2 to 2.2.0?

@thepetk sure I can changed the version, but for me it looks like the problem should be fixed on the parser end.

/retest

@thepetk sure I can changed the version, but for me it looks like the problem should be fixed on the parser end.

@ibuziuk FYI I've created https://github.com/devfile/api/issues/1454 in order to update the parser and add support for devfile schema - versions 2.2.1 & 2.2.2

@kadel @thepetk @elsony please, review

/retest

/retest

One minor detail I would suggest is to create a new default version (e.g. 1.0.3) of the dotnet60 instead of directly updating the 1.0.2. The updated stacks/dotnet60 should have the following contents

@thepetk could you clarify why would you like to create intricate versioning in the repo and not just bump the version to 1.0.3 ? e.g. I do not see 1.0.1 / 1.0.0 versions atm

One minor detail I would suggest is to create a new default version (e.g. 1.0.3) of the dotnet60 instead of directly updating the 1.0.2. The updated stacks/dotnet60 should have the following contents

@thepetk could you clarify why would you like to create intricate versioning in the repo and not just bump the version to 1.0.3 ? e.g. I do not see 1.0.1 / 1.0.0 versions atm

@ibuziuk IMO this would be a better approach and is followed for other stacks (e.g go, nodejs-* stacks) too. This way we can take advantage of the multiple versions support of the registry viewer and every user can trace easier the different versions of a stack. As I've mentioned it is a minor suggestion so I'm fine if we just bump up to 1.0.3 too :)

@thepetk sounds good, thank you
I bumped the version of the devfile, but not going to add the previous 1.0.2 because I simply struggle to understand the value of it (1.0.2 does not work properly at least with Eclipse Che and I do not want it to be exposed)

@thepetk can the PR be merged now?

@thepetk can the PR be merged now?

@ibuziuk we need a review from @kadel who is listed as the stack owner.


Refactoring list detail views templates

Summary Change Description

data tables in templates for list and detail views:

tried to use same (or similar) data table for different webpages if possible
data tables are in /DataRepo/templates/DataRepo/includes directory
use "out_df" for output dataframe in data table  for "includes"
set client-side pagination, vertical scroll, default data size per page
use htmlSorter for column value with hyperlink

Changes made to protocol list and detail views

Changes made to compound detail page, fixed the bug.

Affected Issue Numbers

Resolves #534
Resolves #535
Resolves #536
Resolves #537
Resolves #541
Resolves #566

Code Review Notes

Look like there are a lot of code changes in this PR, but they are mainly due to re-organizing data tables, except for protocol and compound views.

The changes to Protocol list page are a bit different than suggested in #535.  Tried to list "animal treatment protocols" and "msrun protocols" on the same page but in two different tables, which allows separate downloading and viewing (click "full view" button). I prefer this layout, but can make changes based on reviews.

Sorting "infusate" column was very slow and didn't work sometimes, removed it. It might be due to "if conditions". But can sort by "tracers" column.

TODO:  add/modify test code for protocol list view if the layout is ok after first round of review.

Some column display could be better. Will collect feedback and address later if it requires any change to Pandas dataframe.

e.g.
study list page:
infusates (by displaying tracer group or tracers?)
add msrun protocols? (will need to change dataframes)

Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
Tests

[ ] Tests implemented (or no code changes)
[ ] All multi_working tag tests pass locally
[ ] All example load tests pass (remotely) (or their failures predated and are unrelated to this branch)
[ ] @tag("multi_working") added to newly passing test functions/classes (or no newly passing tests)
[ ] @tag("multi_broken"), @tag("multi_unknown"), or @tag("multi_mixed") removed from newly passing test functions/classes (or no newly passing tests)

Tried to use JavaScript to set table height dynamically, but didn't make it work.  Have to use two more templates for now, and pushes some changes before taking a day off today.

Made changes based on reviews. Fixed the issues listed by @lparsons, and fixed most of them raised by @hepcat72 . Two issues require more research and can be revisited in a few weeks.

table with more than 12 columns:
tried the following approaches, but none of them worked better than current layout (responsive table, client-side pagination, fixed header with vertical scrolling).
e.g.

add <br> to column header would mess up the "header" in downloaded file
use Bootstrap grid and column classes to control the width for a wide column in responsive table
set column width using Bootstrap-table option, but seemed not working for table with many columns

Protocol list page
Keep current layout with two tables on the same page for now. Fixed extra empty space issue. Will evaluate again when more data are loaded.

@fkang-pu I'm getting the following error on the home page.
Traceback (most recent call last):
  File "/home/lparsons/miniconda3/envs/tracebase/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/lparsons/miniconda3/envs/tracebase/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/lparsons/Documents/projects/tracebase/DataRepo/views/nav.py", line 91, in home
    "card_foot_url": reverse("protocol_list"),
  File "/home/lparsons/miniconda3/envs/tracebase/lib/python3.8/site-packages/django/urls/base.py", line 86, in reverse
    return resolver._reverse_with_prefix(view, prefix, *args, **kwargs)
  File "/home/lparsons/miniconda3/envs/tracebase/lib/python3.8/site-packages/django/urls/resolvers.py", line 698, in _reverse_with_prefix
    raise NoReverseMatch(msg)

Exception Type: NoReverseMatch at /
Exception Value: Reverse for 'protocol_list' not found. 'protocol_list' is not a valid view function or pattern name.

@lparsons I totally forgot the protocol link from the home page. looks like I went down the rabbit hole. I guess I have to use two cards for protocols (animal treatments and msrun protocols) on home page, otherwise the users would be very confused. Any suggestion?

@lparsons another approach is to remove protocol card from the home page, since they are not super important for the stats, a quick link from the sidebar may be sufficient. What do you think?

I think it would be OK to have both, only one, or none as cards. Here's a quick sketch idea to include both:

@lparsons The home page is fixed now. I tried a few layout of the cards on home page, and also tried to replace "advanced search" card with a button. Seems to me it looks better to keep "advanced search" as a card in the 3rd row, especially when resizing the page. So I opt to use this layout.
p.s. I took the opportunity to move the tests for home views into DataRepo/tests/views/test_home_views.py and modified the code.

@lparsons Hopefully I fixed errors by now. I made myself a bit confused by trying different layouts. Wish I handled the code/template changes in several PRs, lessons learned! Now just try to get this PR done ASAP. Thanks for a few rounds of reviews.


Don't send messages until the connection is established

If the client is not connected,  don't send messages

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   77.08%   77.08%
=======================================
  Files           9        9
  Lines         288      288
  Branches       17       17
=======================================
  Hits          222      222
  Misses         56       56
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cab31a...bcb8e4a. Read the comment docs.


generated server and client and now how to use it

I have generated server and client for petstore, created build and trying get the list of pets it is showing the following message
"operation .FindPets has not yet been implemented"
How can i implement "FindPets".
Is there any example code to implement by referring that.
Please help me.

There is an example at the bottom of this page:
http://goswagger.io/generate/server/


Updated instanceLogDelete function

Updated instanceLogDelete() function to allow deleting of logs from instances in a project other than default

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

jenkins: test this please

Testsuite passed


authentication is required by localhost:4000

Issue Description
[Explain]
APEX Front-End Boost Version
[Example: v2.1.1]
Operating System
[Example: Windows]
Node Version
[Example: v4.4.5]
Browser
[Example: Chrome v50]
APEX Version
[Example: v5.0.3]
Web Server
[Example: ORDS 3.0.3, Tomcat 7]
Your config.json file
[Paste code]

I'm sorry but this tells me nothing. Please add a proper description of your problem, screenshots or gifs and also include your environment details. Thanks.

thanks for your reply , but i have already resolved the issue.


Tick with "DateTime" needed?

When constructing a Tick then we have to provide a "DateTime". Why? Is this important for the indicators? How should one treat weekends and public holidays?  I understand to provide the "Period" but why "DateTime"?
For example:

List<Tick> ticks = Arrays.asList(
    new Tick(endTime, 105.42, 112.99, 104.01, 111.42, 1337),
    new Tick(endTime.plusDays(1), 111.43, 112.83, 107.77, 107.99, 1234),

    // maybe endTime.plusDays(2) is a Saturday..
    new Tick(endTime.plusDays(2), 107.90, 117.50, 107.90, 115.42, 4242),
    //...
);

Ok, I guess, time has its sense for example by providing some kind of statistics in relation to time. So I close this issue.


ipq807x: Add support for Plasma Cloud PAX1800

Device specifications:

Qualcomm IPQ6018
256 MB of RAM
64 MB of SPI NOR flash

2x 28 MB available; but one of the 28 MB regions is the recovery image

2T2R 2.4 GHz Wi-Fi (11ax)
2T2R 5 GHz Wi-Fi (11ax)
multi-color LED (controlled via red/green/blue GPIOs)
1x GPIO-button (reset)
external h/w watchdog (enabled by default))
TTL pins are on board
2x ethernet

eth0

1000 Mbps Ethernet
used as LAN interface

eth1

1000 Mbps Ethernet
802.3at POE
used as WAN interface

12 2A DC
internal antennas

Flashing instructions:
Various methods can be used to install the actual image on the flash. Two easy ones are:
ap51-flash
The tool ap51-flash (https://github.com/ap51-flash/ap51-flash) should be used to transfer the image to the u-boot when the device boots up.
initramfs from TFTP
The serial console must be used to access the u-boot shell during bootup. It can then be used to first boot up the initramfs image from a TFTP server (here with the IP <IP_ADDRESS>):
 setenv serverip <IP_ADDRESS>
 setenv ipaddr <IP_ADDRESS>
 setenv bootargs 'console=ttyMSM0,115200n8 rootfstype=squashfs,jffs2 board=PAX1800 root=31:10 mtdparts=spi32766.0:768k(0:SBL1),64k(0:MIBIB),1664k(0:QSEE),64k(0:DEVCFG),128k(0:RPM),64k(0:CDT),64k(0:APPSBLENV),640k(0:APPSBL),256k(0:ART),28672k(inactive),28672k(inactive2),64k(custom),64k(0:KEYS),2304k(0:WIFIFW)'
 tftpboot <filename-of-initramfs-kernel>.bin && bootm

The actual sysupgrade image can then be transferred (on the LAN port) to the device via
scp <filename-of-squashfs-sysupgrade>.bin root@<IP_ADDRESS>:/tmp/

On the device, the sysupgrade must then be started using
sysupgrade -n /tmp/<filename-of-squashfs-sysupgrade>.bin

@ecsv "256 MB of RAM" is that correct ?

@ecsv "256 MB of RAM" is that correct ?

It's based on the IPQ6000 (with 256 MB profile :open_mouth:).
DRAM IC on page 5 (Nanya NT5CC12...): https://fccid.io/2ASXXPAX1800/Internal-Photos/Internal-photos-5191301
Cheers,
Piotr

@ecsv "256 MB of RAM" is that correct ?

Unfortunately, yes


Added fixed examples for Geoskan

Fixes #82

Download:
Environment: MINGW=C:\Qt\Tools\mingw530_32, QTDIR=C:\Qt\5.11\mingw53_32
.build/bin/release_bin.zip
Environment: MINGW=C:\Qt\Tools\mingw492_32, QTDIR=C:\Qt\5.6\mingw49_32
.build/bin/release_bin.zip


Suggestion to update Kiota commandline tool when it is out of date

Azd does this...

We should steal that.

What source of truth would we use? the nuget version? or the GitHub tag? They don't match 100% (no -preview with GitHub tags)

also do you expect the warning to show for every command? or just the first one in a "session"?  as per the update command, we can probably provide it when it runs as a tool or in a container, but I don't think we'll be able to provide one when using downloaded binaries or local built.

I wouldn't want it to appear with every command.  Why don't you think we could do it with local binaries?  Are you concerned about it looking like we are calling home with telemetry?

we could display the outdated message across all download/install mechanisms. It's the "install" command to update kiota that I'm not sure we're be able to provider for locally built and binaries download.


translate - to _

This fixes #19

Hi @bebehei  the - -> _ translation should only occur for legacy mode. See https://github.com/Icinga/icinga2/commit/b10cb8a2e7acccc285377f72fef533ab277f2ad1#diff-fd8634adc3e7216fc4ecb345caba5cab so please change the pull request to check for the legacy property as added by: 50ad4b5822f983b6713669d6626985345611d312

Tweaked to account for legacy mode.


PUB-750 Add database

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-750
Change description
Add subscription Database
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ X ] No

waiting for testing on the wildcard certs before incase not needed


META - Extension System Testing CLI Commands

### CLI Commands
- [x] cli command `init`
- [ ] https://github.com/nebari-dev/nebari/issues/1944
- [x] cli command `dev`
- [x] cli command `validate`
- [x] cli command `keycloak`
- [x] cli command `support`
- [x] cli command `upgrade`
- [ ] https://github.com/nebari-dev/nebari/issues/1978
- [x] cli setting secrets via environment variables `NEBARI_SECRET__a__b=asdf` -> `{"a": {"b": "asdf"}}` in `yaml`

Thanks a lot for all your work on these tests @sblair-metrostar and @kenafoster!
Marking this as complete and transferring the two lower priority issues to https://github.com/nebari-dev/nebari/issues/1958


Fix regular expressions with empty modifiers

I got the same error as described in issue #27
Python version: 2.7.3
OS: Debian Wheezy
This PR solves the issue with the regular expressions.

@sergeyfedotov, looks nice. Will write a test case for this to check it better. I remember that I was unable to verify this in the first issue.

@phsilva, why * is used instead of + as repition operator for the sequence of modifiers?

@sergeyfedotov, aperture modifiers are optional and we actually found some empty in the wild.


How to train with different dataset

Hi!
First of all I want to thank you for sharing your work (paper and code) with the community :)
On the other hand, I would like to train the model that you propose with my own dataset. Could you share the used code to obtained the ground-truth (JSONs files of SSHB images )? Thank you in advance.

sshb.py in path lib/datasets/prepare includes the process of generating JSON file for SHHB dataset. You can prepare your datasets using or modifying this script.

Thank you so much after the required modifications I could get the JSON files but now I have another question, Do you have any script to train the model in Windows instead of Linux (train.sh)?

train.sh can also run on windows!

@taohan10200 how to generate size_maps?

scale maps are used to generate box annotation, which we have provided in the processed dataset. . You do not need to generate scale maps.

About different dataset training ,  if you do not need to evaluate the localization performance, the bounding box annotation is not  necessary in that labeled JSON file. So scale maps can be neglect. In fact, the generation of scale maps is operated by another model. It is not provided in this project.


Breakup common package

Catchall common packages are generally an indication of bad organization, so we are getting rid of it while it is small. Mostly, types were moved to other, more relevant packages or a new package was created. Please see the individual commits for details.
This addresses items discussed in #6.

cc @dmp42 @dmcgowan @jfrazelle @icecrime @jlhawn

LGTM

Are we creating a collections package only for type StringSet map[string]struct{}?

@icecrime Yes. I'm not tied to the concept of a collections package. Hopefully, this avoids a million definitions of stringsets where they are used. Alternatively, we can just move this back into auth/token and make it private.
Let me know what you prefer.

You know better, but if it's only used in auth/token let's just have it there.

@icecrime Fixed. ;)

LGTM


Question: which edition is this?

I am reading chapter 3 and 4 and it seems that the exercises look different. I am using edition 3.
Thank you!

Sorry for the picture. It is 2nd and I have updated the readme
Thanks^


Fine-grained reproduce flags and testing

Added test model for ... testing. Has minimal requirements and means
tests can be independent of model driver implementation. A platonic
ideal if you will.
Added config options for fine-grained reproduce options. Input, exe
and restart reproduce can be turned on independently of each other.
Added extensive testing of init/setup and reproduce.
Fixes https://github.com/payu-org/payu/issues/203

Hello @aidanheerdegen! Thanks for opening this PR.  In this way PBS isn't required on travis unless a PBS job is submitted.
(The PBS install stuff seems to be broken BTW. It couldn't find /etc/pbs.conf as the install script errors)

I think a lot of that was cut-and-paste from the bundled Python bootstrap script.
Is there not some way to retain 2.7 and 3.5 testing?  I don't know if removing versions is the right path foward here.

Are you dropping 2.7 to use exist_ok in os.makedirs?  Can not some of this be resolved using mkdir_p in the fs module?

Sorry, I thought we'd decided to drop 2.7 support, as people could always use an older version?
All the tests I just wrote are not python2 compatible as they use pathlib to make writing the tests less painful. I also dropped 3.5 as I believe there are a few pathlib compatibilities that only work from 3.6, but it isn't a deal breaker. I did mean to add 3.7 so it didn't look quite so bad!

Ah yeah, ok, it's just the test itself.  pathlib does seem pretty fantastic, as does the exist_ok argument in os.makedirs.
All good, just wondering how things might work if I ever try porting payu to Gaea.

Could have version dependent tests where the 2.7 test just does payu list like the conda test
https://github.com/payu-org/payu/blob/master/conda/meta.yaml#L34
to make sure there are no breaking changes to payu itself.
Do you only have access to python2.7 on gaea? Eeeuuuwww.

So now the tests will do payu list and pylint -E for all python versions. The latter should pick up anything not python27 compliant.
Additionally for python3.x interpreters pytest test/test_manifest.py is run. This is just testing init, setup and sweep for a test model.


bugfix import

@ariya @ljqx could you review?
don't know if this is correct: https://github.com/jquery/esprima/pull/2076/files#diff-abe2818e9c29aadf84401cb7ef8286c7cbce9253eba09f6fa52e22ca4e57b17eR1287
first thought parseUnaryExpression is correct, but import('a' + 'b') is valid. but parseExpression is wrong, cause then import('a', 'b') would not fail