Final counts for CMAT

Merge after #390, see here for the relevant diff (now rebased).
Includes counts for the following:

sources of finished trait mappings
RCVs with both supported measure and trait
gene & consequence comparisons by variant type

@M-casado

I've checked that you added code to increase the granularity of counts from CMAT, but do we have a sample of the output?

The raw output is really messy, partly because there's now quite a lot of information being provided (most of which won't make it into the paper) and partly because I didn't spend any time making it pretty... Here's the results from the run I did on Friday, so before the obsolete and child-of changes:
Overall counts (RCVs):
total                  2975570
has_supported_measure  2972241
has_supported_trait    1913163
both_measure_and_trait 1909872

Gene annotations:
Total = 2972241
        Category    Count  Percent  F1 Score
     exact_match  2559703    86.1%      1.00
   cmat_superset    42035     1.4%      0.67
     cmat_subset   273710     9.2%      0.63
 divergent_match     3913     0.1%      0.46
        mismatch     2978     0.1%      0.00
        -->match  2879361    96.9%      0.96
 -->both_present  2882339    97.0%      0.96
      cv_missing      350     0.0%      0.00
    cmat_missing    76160     2.6%      0.00
    both_missing    13392     0.5%      0.00

Functional consequences:
Total = 2972241
        Category    Count  Percent  F1 Score
     exact_match  2129268    71.6%      1.00
   cmat_superset        0     0.0%      0.00
     cmat_subset   753421    25.3%      0.65
 divergent_match        0     0.0%      0.00
        mismatch        0     0.0%      0.00
        -->match  2882689    97.0%      0.91
 -->both_present  2882689    97.0%      0.91
      cv_missing        0     0.0%      0.00
    cmat_missing     2788     0.1%      0.00
    both_missing    86764     2.9%      0.00

By variant type:

	Simple (genes):
Total = 2880084
        Category    Count  Percent  F1 Score
     exact_match  2557424    88.8%      1.00
   cmat_superset    42010     1.5%      0.67
     cmat_subset   273438     9.5%      0.63
 divergent_match     3909     0.1%      0.46
        mismatch     2977     0.1%      0.00
        -->match  2876781    99.9%      0.96
 -->both_present  2879758   100.0%      0.96
      cv_missing      326     0.0%      0.00
    cmat_missing        0     0.0%      0.00
    both_missing        0     0.0%      0.00

	Simple (consequences):
Total = 2880084
        Category    Count  Percent  F1 Score
     exact_match  2128158    73.9%      1.00
   cmat_superset        0     0.0%      0.00
     cmat_subset   751926    26.1%      0.65
 divergent_match        0     0.0%      0.00
        mismatch        0     0.0%      0.00
        -->match  2880084   100.0%      0.91
 -->both_present  2880084   100.0%      0.91
      cv_missing        0     0.0%      0.00
    cmat_missing        0     0.0%      0.00
    both_missing        0     0.0%      0.00

	Repeat (genes):
Total = 1657
        Category  Count  Percent  F1 Score
     exact_match   1587    95.8%      1.00
   cmat_superset      0     0.0%      0.00
     cmat_subset     70     4.2%      0.64
 divergent_match      0     0.0%      0.00
        mismatch      0     0.0%      0.00
        -->match   1657   100.0%      0.98
 -->both_present   1657   100.0%      0.98
      cv_missing      0     0.0%      0.00
    cmat_missing      0     0.0%      0.00
    both_missing      0     0.0%      0.00

	Repeat (consequences):
Total = 1657
        Category  Count  Percent  F1 Score
     exact_match    202    12.2%      1.00
   cmat_superset      0     0.0%      0.00
     cmat_subset   1455    87.8%      0.63
 divergent_match      0     0.0%      0.00
        mismatch      0     0.0%      0.00
        -->match   1657   100.0%      0.68
 -->both_present   1657   100.0%      0.68
      cv_missing      0     0.0%      0.00
    cmat_missing      0     0.0%      0.00
    both_missing      0     0.0%      0.00

	Complex (genes):
Total = 948
        Category  Count  Percent  F1 Score
     exact_match    692    73.0%      1.00
   cmat_superset     25     2.6%      0.67
     cmat_subset    202    21.3%      0.66
 divergent_match      4     0.4%      0.49
        mismatch      1     0.1%      0.00
        -->match    923    97.4%      0.91
 -->both_present    924    97.5%      0.91
      cv_missing     24     2.5%      0.00
    cmat_missing      0     0.0%      0.00
    both_missing      0     0.0%      0.00

	Complex (consequences):
Total = 948
        Category  Count  Percent  F1 Score
     exact_match    908    95.8%      1.00
   cmat_superset      0     0.0%      0.00
     cmat_subset     40     4.2%      0.56
 divergent_match      0     0.0%      0.00
        mismatch      0     0.0%      0.00
        -->match    948   100.0%      0.98
 -->both_present    948   100.0%      0.98
      cv_missing      0     0.0%      0.00
    cmat_missing      0     0.0%      0.00
    both_missing      0     0.0%      0.00

Trait mappings:
Total = 2212567
        Category    Count  Percent  F1 Score
     exact_match   995420    45.0%      1.00
   cmat_superset      109     0.0%      0.80
     cmat_subset   551990    24.9%      0.65
 divergent_match      532     0.0%      0.50
        mismatch   192012     8.7%      0.00
        -->match  1548051    70.0%      0.88
 -->both_present  1740063    78.6%      0.78
      cv_missing   440068    19.9%      0.00
    cmat_missing    13000     0.6%      0.00
    both_missing    19436     0.9%      0.00

Obsolete terms:
cv_total      3368084
cmat_total    2405626
cv_obsolete   871376
cmat_obsolete 1579

@apriltuesday, thanks for the sample metrics. I actually just wanted the raw output, so I'm glad you didn't spend time making it pretty, it's just to compare the code and the output 👍


Fix heatmap demo in website

The data format feeding from HexagonLayer into ColumnLayer has changed.

Coverage remained the same at 61.768% when pulling a67b1aa7b5bc169b87b4d2a882dedb4b9804099b on x/website-heatmap-fix into b5929399fe313b5f4611afa027ff726ad8a4174a on master.


WIP: Move to v1 from v1alpha1

A super early version, migration is buggy hence, tests will fail.
So we cannot update the CRD version as that field is immutable. Which means the only option is to run a migration.

Do we release a 0.12.0 with the TPR --> CRD changes and then have another migration which moves from v1alpha1 to v1.
Do we make v1alpha1 to v1 part of the TPR --> CRD change and delay 0.12.0 to tomorrow (hopefully)?

I favour a 0.12.0 now and then a migration because we have the setup for a migration in place and adding a new kind of migration is fairly straight forward. This PR in its current state is trying to migrate to v1 as part of TPR --> CRD change.

One consideration here is that TPR->CRD migration is considerate of cluster versions. So the next operator version will run seamlessly.
This change is breaking as it will query a different resource path for Prometheus. Obviously quite tedious to have all the code handle v1alpha1 and v1. Since our schema didn't change, we could just do this transparently by tweaking the request path but use monitoringv1 in the code.
Or we just make it a breaking change and people will have to upgrade to k8s 1.7 if they want to use the latest version.

@fabxc given the compatibility of client-go 4.0-beta.0 we may just want to do the latter option.

So I am kinda blocked here because I am seeing weird behaviour on my local: https://github.com/kubernetes/apiextensions-apiserver/issues/6 https://github.com/kubernetes/apiextensions-apiserver/issues/5
Can you trigger the tests once? @fabxc @brancz @mxinden

@Gouthamve we're currently having some difficulties with CI, so we'll probably only be able to trigger tests tomorrow. Releasing is not super urgent right now, so we're not much in a hurry.

Oops, that conflict was not intentional, this will need a rebase @Gouthamve .

@coreosbot test this please.

Closing here in favor of #555


[DROOLS-1137] use kie-parent + only needed BOMs

@mbiarnes since this is build related, could you please take a look and review?

+1


packages: "clang_format_setup" takes 13 minutes

Example: https://cirrus-ci.com/task/5926484234731520
That seems like a long time.  In the case of pigeon I'm removing checking in generated objc code so it may be an unnecessary step.
cc @stuartmorgan

Looks like all the downloads 403 and then fall back to building the world from source. I'm not sure if that's a bug somewhere, or a security measure.


Crash w/ onDrawSelectionBox

Forge 2254-1.10.2
Valkyrien Warfare v0.8.999 Stable
I got this crash upon right-clicking the ship creator. There was a plain, black banner, Grimpack mod fans, and a Mr. Crayfish Furniture mod oak chair included on the ship, just in case these had something to do with the crash.
Crash Report

The Grimpack mod fans also still seem to create massive lag on the ship.

Old issue, closed. This shouldn't occur in the latest version.


ROS Noetic Error: cannot find -lunitree_legged_sdk

@ZKBian and Unitree team, I'm wondering if I can get some assistance with building the ROS packages for Gazebo simulation. I'm running into the following error in the screenshot below:
cannot find -lunitree_legged_sdk

I've gone through all the steps in the README file as well as several of the GitHub Issues. Here is what I've done:

Cloned unitree_ros and unitree_ros_to_real into ~/catkin_ws/src
Cloned unitree_legged_sdk into my home directory ~/
Successfully built unitree_legged_sdk as you can see here:

Added the UNITREE_LEGGED_SDK_PATH environment variable as suggested by @Zhaiweiwei0 here
But running catkin build in my workspace yields the error I posted above

Could this possibly be a ROS Noetic issue? Any help would be greatly appreciated.
Thank you.

I was able to get this to build by changing this line:
https://github.com/unitreerobotics/unitree_ros_to_real/blob/master/unitree_legged_real/CMakeLists.txt#L24
string(CONCAT LEGGED_SDK_NAME libunitree_legged_sdk.so)

to:
string(CONCAT LEGGED_SDK_NAME libunitree_legged_sdk_amd64.so)

Since my architecture is amd64. But I'd still like to understand why the normal build process didn't work for me.

Just for future travellers:
I came across the similar issue again with latest version of unitree_ros_to_real and unitree_legged_sdk, and solved with a similar change:
from
set(LEGGED_SDK_NAME -pthread libunitree_legged_sdk_${ARCH}.so lcm)

link_directories(${CMAKE_SOURCE_DIR}/unitree_legged_sdk-master/lib)

to
set(LEGGED_SDK_NAME -pthread libunitree_legged_sdk.a lcm)

link_directories(${CMAKE_SOURCE_DIR}/unitree_legged_sdk/lib/cpp/${ARCH})

Perhaps lcm can be removed too, because Go1 no longer depand on it.


Fixed version comparisons in all the test suites and conftest.py

Before we were comparing floats, but it turns out that it is not accurate, since in the case of RHEL 8.10, it is semantically greater than e.g. 8.4, however if they are compared as float, 8.4 is greater than 8.10.

LGTM! Let's see if CI agrees :) ... Do you want me to test it in osbuild-composer test suite as well? It's just a matter of changing the CIV image tag, righ?

Thanks @jrusz ! Yes, that would be great, so we can confirm that this also solves the issues with RHEL-8.10.
Exactly, you can use this PR as the tag (pr-286), instead of "prod" here:

https://github.com/osbuild/osbuild-composer/blob/3fe36d00120d69907677b5a922650a14ff235ebd/test/cases/aws.sh#L223

It passed on both 9.4 and 8.10! https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1063680945

I would try to keep on a consistent argument name when comparing the versions: right now I see 'rhel_version', 'product_version', 'version.parse(host.system_info.release)', 'product_release_version', maybe lets choose one argument for all these comparisons?

Good point. Maybe we can choose a generic one, like system_release. What do you think?


user_followers_v1 and user_followers return duplicates of UserShort-s

Describe the bug
User has 3898 subscribers.
user_followers_v1 and user_followers return 3898 UserShort-s that contain duplicates.
So finally number of unique subscribers is less than 3898.
Expected behavior
Methods should return the same number of unique UserShort as user subscribers.

Added uniqueness check for follower.pk

instagrapi 1.12.10

Now method return 3584 unique users instead 3898

I have 740 followers

but instagram return

Instagram lazily recalculate counters, or return an incorrect list of followers


Getting 403::create_denied

Subscription for a single topic works successfully but when I try to subscribe to another topic, i get the the exception below :-
com.salesforce.emp.connector.CannotSubscribe: Unable to subscribe to [/topic/13q8_3zpqi_j7akbccq:-1] [https://ap4.salesforce.com/cometd/39.0] : 403:denied_by_security_policy:create_denied
	at com.salesforce.emp.connector.EmpConnector.lambda$subscribe$6(EmpConnector.java:378)

I am confused here why it is not allowing me to subscribe since I only have 11 topics in my developer salesforce account, subscribed to one of them and trying to subscribe to another. As per the documentation, maximum 20 subscriptions are allowed per topic.

Not sure why it may be failing, unfortunately the connector just reports the errors.

Can the possible reasons be listed here?  Will help me in investigating this issue further.

Well, the error message is: 403:denied_by_security_policy:create_denied
this means that the user you are connecting with does not have create permissions on the topic, which means you cannot create the topic.  Since you're subscribing, it indicates that the topic does not exist, and the subscribe was attempting to create it, which the connecting user does not have permissions.

I have observed a pattern regarding this error.  Every time before subscribing to salesforce stream, I need to login to salesforce saop api to perform some validation in my software. First time the subscription succeeds but subsequent subscriptions fail with the 403:create_denied message. However if I comment out the lines where I connect to salesforce saop api, the subscriptions  that I do multiple times succeed.   I have created a github where this is reproducible: https://github.com/parikshitN/sforce-stream-403-error.
Please if you can check that once, and if possible throw some light on why its happening or a possible workaround, it will be really helpful to me.


Adding Docker and Native support

Closes #623
Closes #279
List of changes in this PR:

Major Refactoring of manifest_parser.go:

Replace str != "" kind of check with len(str) != 0
Replace "/" with constant PATH_SEPARATOR
Created a common function to parse inputs and outputs, updated all Compose* routines to utilize this common function. Same with annotations.
Split ComposeAction function into smaller routines with validating code, validating function, reading code, reading function, creating action exec depending on action function and code, etc.

Added support for docker and native actions with unit test and integration test.

@ddragosd @pritidesai In order to support private (with credentials), we would need to add support for thee credential and repository schema (envisionsed in spec.).  Priti, do you agree with this assessment?  If so, can we open an epic/issues for this and prioritize?

This is not supported in core, the invoker doesn’t deal with credentials to pull the image it just executes docker pull
Cc @rabbah

@mrutkows I think its beyond the scope of wskdeploy. We have repository and credentials defined here on line 558 and line 571. But with docker actions the way they are designed, images are not pulled during action creation. So even if we have access to credentials of private repo and we could pass that to OpenWhisk server but the its not supported by server side.
We can address this by what Rodric has commented here https://github.com/apache/incubator-openwhisk/issues/1362 saying "One way to support this is by pulling images from the private registry to a whisk managed registry at action create time. This would avoid some the challenges around key management for docker login. In general I think this is a good approach for docker actions as it will make it easier for vetting images; but not without its demerits." We can definitely add support for this in wskdeploy, is that what we are looking for?

Yep this is something that wskdeploy can’t solve at the moment


isin issue with numpy 1.12 on Python 2

I received the following report on da.isin through a side channel.   cc @jakirkham
We're using numpy 1.12, which doesn't have numpy.isin().  dask/dask#3363 leads to:
% python -c 'import dask.array'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "dask/array/__init__.py", line 8, in <module>
    from .routines import (take, choose, argwhere, where, coarsen, insert,
  File "dask/array/routines.py", line 790, in <module>
    def isin(element, test_elements, assume_unique=False, invert=False):
  File "/opt/python/python-2.7/lib64/python2.7/functools.py", line 33, in update_wrapper
    setattr(wrapper, attr, getattr(wrapped, attr))
AttributeError: 'NoneType' object has no attribute '__module__'

where wrapped is None and attr is '__module__'.
I think this only happens with Python 2's functools.
py3: https://github.com/python/cpython/blame/0f914b5b5f6ba186afd7112fc851c97247076f70/Lib/functools.py#L52
py2: https://github.com/python/cpython/blame/77f0a41d72886513f5e9277e5587455745c29ac1/Lib/functools.py#L32

Interesting, thanks for the info. Also cc @shoyer.

This reminds of a more general discussion about how we document API ( https://github.com/dask/dask/issues/3265 ) that we should have at some point. ;)
As to the particular problem, we have a few options. None particularly difficult (some are easier though).

Only define Dask Array isin for versions of NumPy that have it.
Vendor a copy of NumPy's isin implementation and use it.
Implement isin with in1d + reshape and copy/rewrite the docstring from NumPy.
Vendor/implement our own wraps (combined with part of 3).
Something else?

Thoughts?

Oops. I thought all we would miss here is the docstring on old versions of NumPy, but it looks like that causes a crash at import time :(.
@wraps(getattr(np, 'isin', np.1nd)) would probably be an adequate work-around for now.
I didn't bother to vender a copy of numpy's isin because it was just as easy to write dask's isin in terms of np.in1d.

Yeah, I thought the Python 3, NumPy 1.12 and NumPy 1.10 CI combinations were sufficient to rule out this sort of issue, but guess not. Easily fixable though. So wouldn't stress about it.
That's probably ok. It's a little confusing based on the return type, but expect users can figure this out. Also it is no worse than many of the other docstrings using this same strategy.
Ultimately we should discuss how to fix the docstrings to be clearer at some point, but the discussion need not happen now in this issue. Just should happen eventually with this just highlighting another pain point.
That's right. Forgot we were already using in1d. Edited the list in my original comment accordingly.


Cross column search does not restrict to selected columns

Fix the issue with cross-column search where it doesn't properly restrict to selected columns. Tested manually, unit tests pass.

This looks good but we're going to merge the codecov fix first


Use Dock Integration doesn't save it's location state on atom restart

Prerequisites

enable "Use Dock Integration" in settings
move the remote panel somewhere else

Description
When you move the doc to somewhere else after checking use dock integration in settings and restart atom. the remote panel finds it's way back on the left side. If you do not have any other pannels on the left side, you cannot actually get the to show up at all panel
Expected behavior: Move panel to right and reload atom and the location of the panel should remain where it was before the restart
Actual behavior: Move the panel to the right and reload resulting in the panel returning to the left. If no other panels are on the left, there's no way of getting the remote panel to show up at all
Reproduces how often: 100%
Versions
Atom    : 1.22.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
Remote-FTP  : 2.0.0
OS   : Mac 10.11.6 (OSX El Captian)
Additional Information
I'm not sure if this is a bug with Atom in general or a bug with Remote-FTP. I know that treeview stays where it is when I restart but the Remote-FTP panel doesn't so I think it might be more of a remote FTP bug but feel free to correct me if i'm wrong :)

Thanks for open the issue. I change the method.
I deleted the non-working (deprecated) methods, options. https://github.com/icetee/remote-ftp/commit/00fa497675fb40133f0d79a6ee8d62f75466fa44
By the time the plugin remarks on what site is placed the tree view and it’s opened. (Order is not supported yet)
I hope it helps. The next version will include the fix. I close this issue.


Learn more link on home page points to placeholder page

Getting Started -> Learn More on home page points to empty (placeholder) page with content:
Home > Getting Started

Gettting Started
Welcome to Rancher Dashboard.

Tested on master-head (909237a)

This will be fixed as part of rancher/dashboard#2735

Close as duplicate


Expand on "Give the service account IAM permissions to deploy to Cloud Run"

https://github.com/ahmetb/cloud-run-faq/blob/ceb7418b5cad8d5e1782b89c11b86578be5f9ba6/README.md#L399-L402
I often get stuck at this point - it would be really useful if this could link to further documentation, or even spell out explicitly what those permissions should be.

This is a great general article with background on that: https://dev.to/googlecloud/advice-on-specifying-more-granular-permissions-with-google-cloud-iam-4b70

thanks for noting. fixed in 872031561b1e9c67f47b97bf4bd54a68a5e65f97 with a link.

also adding this link https://cloud.google.com/cloud-build/docs/deploying-builds/deploy-cloud-run#continuous-iam


backport: bitcoin-core#gui18, #121, #257, #263, #281, #335, #828, bitcoin#21912, #21942, #21988

Issue being fixed or feature implemented
Just regular backports from bitcoin v22, mostly Qt related
What was done?
See commits for a list of backports.
This PR also fixes a rendering an url on Governance tab if it has any '&' inside. see screenshots.
Original url: https://example.com/?test=nothing&to=see&&lol - yes, double '&&' just for test even if url is silly.
Failed behaviour:

Correctly rendered:

How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

gui-263 requires follow-up: 3f68f02db9 | Merge bitcoin-core/gui#362: Add keyboard shortcuts to context menus


Zip length error (expecting 8 digit long postal code)

I'm getting this error even though I've set country to FI (Finland), and tried to lookup for 5 digit long postal code – in Finland all postal codes are 5 digit long...
Wrong zip length: in BR zip length is 8 not 5.

Got it working:
$z = new ZipCode;
$z->setCountry('FI');
$zip = $z->find($code);

However before using setCountry() I've had this config with L5 so it seems this config file's country -key isn't applied.
<?php

return [

	'country' => 'FI',

	'preferred_web_service' => 'Geonames',

	'query_parameters' => [
		'geonames_username' => 'XXX',
	]

];

Just noticed the preferred_web_service isn't applied either.


[Help Request] Help request title

High Level Description
Hi folks,
Do you know how can I get the current number of the episode? I am running the hiway_env.py scenario, but I do not know how I can retrieve that information in order to obtain the tracked agents per traffic scenario.
Version
1.0.11
Operating System
No response
Problems
No response

Hello @rodrigogutierrezm, could you clarify what you mean:

You wish to get the number of agents in the current episode?
You wish to get the sequential episode count?


Include tests module and test files in sdist

Allows downstream users and operating system packagers and porters to test released package within their own QA, build or other environments

thanks!


Remove references to the Aero2 assembly.

This assembly is only available on Windows 8, 8.1, and 10.
Referencing it at runtime causes the program to abort on Windows 7.
This was fixed by removing the shadow behind combobox dropdown menus,
which I'm not very attached too.
Fixes #87.

This seems to fix the probably on Windows 7 for as much as I could click around so looks good to me.

tOK


How to Display Multiple media sending upload proceed using jsqmessage view controller?

Hello,
I am making chat app using XMPP and JSQ message view controller.Now I am sending multiple media like first send video and at that time of uploading process of a video, I am sending image than video upload process label hide an image upload process label display.so how can I display both media process(video and image)like chat secure app?
anyone have a solution then please help me.
thank you.

@shraddha-patel-1891 Have you solved this problem?

@Nurka11
No have not got any solution you have then please shar.

@shraddha-patel-1891
`class JSQCustomMessage: JSQMessage {
var mediaItems: [JSQMessageMediaData] = []

init(senderId: String, senderDisplayedName: String, mediaItems: [JSQMessageMediaData]) {

    let data = NSMutableData()
    let archiver = NSKeyedArchiver(forWritingWith: data)
    archiver.finishEncoding()
    let coder = NSKeyedUnarchiver(forReadingWith: data as Data)

    super.init(coder: coder)!

    self.mediaItems = mediaItems

}

required init?(coder aDecoder: NSCoder) {
    fatalError("init(coder:) has not been implemented")
}

var mediaItemsFor: [JSQMessageMediaData] {
    return mediaItems
}

override var isMediaMessage: Bool {
    return true
}

}
` maybe something like this


Vulkan/SPIR-V test failures on physical GPU

[ctest] 	102 - iree/test/e2e/xla_ops:check_vulkan-spirv_vulkan_compare.mlir (Failed)
[ctest] 	103 - iree/test/e2e/xla_ops:check_vulkan-spirv_vulkan_convert.mlir (Failed)
[ctest] 	112 - iree/test/e2e/xla_ops:check_vulkan-spirv_vulkan_maximum.mlir (Failed)
[ctest] 	113 - iree/test/e2e/xla_ops:check_vulkan-spirv_vulkan_minimum.mlir (Failed)

Configurations tested:

OS: Windows 10
Local patch: fix to #2018
Fails on GPU: AMD Radeon VII, GeForce RTX 2080 Ti

vulkaninfo
GPU0:
VkPhysicalDeviceProperties:
---------------------------
        apiVersion     = 4198519 (1.1.119)
        driverVersion  =<PHONE_NUMBER> (0x6e84c000)
        vendorID       = 0x10de
        deviceID       = 0x1e07
        deviceType     = PHYSICAL_DEVICE_TYPE_DISCRETE_GPU
        deviceName     = GeForce RTX 2080 Ti

GPU1:
VkPhysicalDeviceProperties:
---------------------------
        apiVersion     = 4202629 (1.2.133)
        driverVersion  = 8388745 (0x800089)
        vendorID       = 0x1002
        deviceID       = 0x66af
        deviceType     = PHYSICAL_DEVICE_TYPE_DISCRETE_GPU
        deviceName     = AMD Radeon VII

compare.mlir: Seems to be failing on all scalar compares. Passes on tensor compares.
convert.mlir: No discernible pattern
maximum/minimum.mlir: Fails on <32bit

Note that these were the only Vulkan specific failures that I saw (most tests pass).

(as a note, these also fail for me - I think they'll fail on any device besides swiftshader)

I figured - just wanted to document since we basically only have ad-hoc testing for this stuff now.

for sure --- it's nice that you have both cards in the same computer, that's able to really cut down on the "hey can you try this on your computer" latency :)

Yup. I can repro these issues on P1000. Hanhan previously reported them as #1995, #1996, etc. compare.mlir should be working given #1259 is fixed. But yes this is a moving target and things will keep silently going wrong until we've real GPUs hooked up in testing.
Hanhan would you mind to look into these failures too?

it's nice that you have both cards in the same computer

It was nicer when the weather was colder :)

Sure, let me take a look on P1000 first. (just saw the bug, my notifier for Github was broken...)

Weird...I can't reproduce on my machine.
git pull
git submodule update --init
cmake to config/build iree
cmake --build build/ --target vk_layer_khronos_timeline_semaphore
export VK_LAYER_PATH=$PWD/build/third_party/vulkan_extensionlayer/layers/:$VK_LAYER_PATH
cd build
ctest -V -R iree/test/e2e/xla_ops:check_vulkan-spirv_vulkan_compare.mlir

And I got passed on the test.
102: I ../iree/tools/vm_util.cc:305] Creating driver and device for 'vulkan'...
102: I ../iree/hal/vulkan/vulkan_driver.cc:295] Created Vulkan Device: Quadro P1000
...
102: [----------] Global test environment tear-down
102: [==========] 15 tests from 1 test suite ran. (153 ms total)
102: [  PASSED  ] 15 tests.

Ouch. Don't tell me this is loader/driver version issue again. I'm at 1.1.126 for P1000 and 1.2.135 for loader. I see Stella is at 1.1.119 for NVIDIA driver. Could you paste yours @hanhanW so we can compare?

$ vulkaninfo
GPU0:
VkPhysicalDeviceProperties:
---------------------------
        apiVersion     = 4198499 (1.1.99)
        driverVersion  =<PHONE_NUMBER> (0x6b8c8000)
        vendorID       = 0x10de
        deviceID       = 0x1cb1
        deviceType     = PHYSICAL_DEVICE_TYPE_DISCRETE_GPU
        deviceName     = Quadro P1000

I think I'm at 1.1.99 for driver. Where can I get the version for loader?

You can get it at the beginning of vulkaninfo's dump. There is a "Vulkan Instance Version" line.

Thanks! It's Vulkan Instance Version: 1.2.126.

Okay, all the numbers are different. This is gonna be a fun one. Hanhan, please focus on some other important tasks and don't spend too much time on this one now. I'll poke around later.

Okay, I think the reason behind these test failures is that we have out-of-bounds buffer access. For example, for compare_scalar:
https://github.com/google/iree/blob/778230076df35c1acbd2745be8366836ac0a69a4/iree/test/e2e/xla_ops/compare.mlir#L12-L21
We are using four buffers here; each iree.unfoldable_constant is initializing one of them. Two of these buffers are 1-byte. But on the CodeGen side, because we don't declare StorageBuffer8BitAccess, we are emulating them as 32-bit buffers. We read the element as 32-bit value and then do a bunch of bit manupilation operations to get the 8-bit value. That's where it becomes problematic. Per the Vulkan spec:

If a SPIR-V OpLoad instruction loads a structure and the tail end of the structure is out of bounds, then all members of the structure are considered out of bounds even if the members at the end are not statically used.

If robustBufferAccess is not enabled, applications must not perform out of bounds accesses.

We just have 1-byte here. So the initial read is out of bounds.
In general such round-tripping such small buffers is not good for GPU. But it might be okay for other accerators like CPU. Putting that aside, if we want to still support this, I think like bool buffers, we need an ABI pre-pass to widen these small buffers. This pass might be specific to GPU.
Problem aside, I think the reason that Hanhan cannot repro these failures on an earlier driver version is that VK_EXT_robustness2 is published earlier this year. That makes the out-of-bounds access more clear.

Had to disable the while op test on vulkan (enabled after https://github.com/google/iree/commit/d61c5485d58aed4371e35f460b297563050aef63) because it fails on real hardware.


Code Formatting of Repo - Add Preprocessing to Compilation Process - Introduction of Dev/Build Tools to WinUtil (Although very simple at the moment)

Type of Change

[x] New feature
[x] Refactoring

Description
Makes sure all files don't have any trailing whitespace.
And by putting in inside a function (the Do-PreProcessing function) it'll be possible in the future to do other things, like replacing Tabs with 4 spaces (the convention that's used the most.. other than Invoke-WPFMicrowin.ps1).
Testing
I ran the script and not only does it compile WinUtil, but also makes sure every file follows specific coding conventions (like having no trailing whitespace)
Additional Information
Not only does it do this preprocessing on other files in the repo.. it also does it on the Compile.ps1 file itself, indicating that PowerShell interpreter makes a Copy of the running script in memory, before actually running said script.. which's somewhat a new discovery (at least for me).
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

Nice!

@ChrisTitusTech Updated permissions

@ChrisTitusTech Fixed.
Just discarded every change on my branch (HEAD) for every merge conflicts, and for updates.md file, I just added it with git add docs/updates.md to confirm its deletion.

Now a few things happened:

Even after git for sometime.. I got a bit cooky & did something (I personally thought) was impossible.. which's losing your code with git 😆, I'll never do a Force Push to any branch without double/triple checking my previous commands LOL
The deletion of progress was, at first, a bit annoying, had to re-write it from memory (no snippets, screenshots or anything).. but thankfully this happen to somewhat simple PR, so it was trivial to re-program it again, was a nice Memory test as well 👍
.. Somehow by starting over, I got a chance to re-think & improve upon my work, and thankfully I'm a bit more knowledgeable about RegEx (used it in Workflow Update PRs), so I used its power to make any Code Formatting choice, which I personally see as the most fitting, or the "common convention" used in the source code.
Also, my bad for the review comments above.. didn't mean to Delete my own PR 😢 (It was an accident), so it's now referencing to code that doesn't exist anymore (gone forever.. I think).

With that being said, I made the PR read to review, if you've anything you don't like, or want to improve upon, @ChrisTitusTech you can do so.

Could you rename the function and the file Do-preprossing to something following the function naming convention from Microsoft like Start-Preprocessing
https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/09-functions?view=powershell-7.4
Seeing as there are not really any code conventions for winutil in place, and it's quite the wild west, I think it's probably smart to try to adhere to the one from Microsoft at least

Could you rename the function and the file Do-preprossing to something following the function naming convention from Microsoft like Start-Preprocessing or Invoke-Preprocessing https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/09-functions?view=powershell-7.4

Yahh I do agree on this weird naming convention I've used 😅, also didn't check the Official Microsoft PowerShell Standards, I'll be sure to refer to it when adding Formatting Rules, thanks @Marterich

This is one big PR @og-mrk still reviewing it. Looks awesome from a cleanup and standardizing some of the files.

Thanks @ChrisTitusTech for taking your time to review this.
And although I'm happy with the result of this tiny script I've made (it's quite simple if you checked Invoke-Preprocessing code, just some find & replace code).. there's still room for improvement, and because it's a script that can modify almost every file in the repo.. I'll need to test it more, and see what other formatting rules to add/implement.
Therefore, I'll convert this PR to draft until I see/think it's ready (both "feature" and stability wise).
I know the core concept & idea is finished (tested it with every change along the way).. but when you've RegEx which's untested to every possible case, and said RegEx can modify your entire code base.. yahh, I think I'll do some Unit Testing for this script. And the Tests themselves shouldn't change over time.. as long as the code itself (formatting rule) doesn't change, because the input (possible cases) for each Rule is many, but limited, and expected output is always one (the desired formatted code).

Even though there's more Formatting rules I'd like to add.. the current (and somewhat simple) RegEx formatting is ok.. more complex formatting would require parsing PowerShell and figuring out the AST (Abstract Syntax Tree), which in the long run.. would make it a script that can be used in any project, and would work just as intended (formatting PowerShell code bases).
Will make PR ready for review...


ceph-volume executable tests and testinfra API update

This adds the tests for ceph-volume's executables, to ensure they are installed when the lvm osd scenario is picked up.
It also updates the fixture usage to align with the latest from testinfra

does anything docker passes anymore?

jenkins test luminous-ansible2.3-update_docker_cluster

jenkins test luminous-ansible2.3-purge_docker_cluster

jenkins test luminous-ansible2.3-docker_cluster

jenkins test luminous-ansible2.3-bluestore_docker_cluster

The docker failures here seem unrelated.


Add documentation for "Analysis options" in usage.md

Description of feature
This is currently listed as [WIP] and needs content.

This is now merged on dev.


ARROW-14657: [R][Docs] Broken link in R docs

Note that you don't need to create a JIRA for such changes, you can create a "minor" PR. Just format the PR title like this: "MINOR: [R][Doc] Broken link in R docs"

Note that you don't need to create a JIRA for such changes, you can create a "minor" PR. Just format the PR title like this: "MINOR: [R][Doc] Broken link in R docs"

Cool, will keep that in mind next time


Added a link to the repo in the footer

Added a github icon which takes you the github repo of LibraryMan

Added a github icon which takes you the github repo of LibraryMan

Good contribution


Added 'physics' prop to Stepper.

Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view.
Fixes https://github.com/flutter/flutter/issues/19513

Sorry this has taken so long to reach the finish line!
I'm going to fix up the last formatting problems and a note to the physics property doc about using ClampingScrollPhysics when the stepper is used within another scrolling container. And then, when the build is green I'll land the changes.
Thanks again for your contribution!

Can we get the Stepper's physics to also be implemented for StepperType.horizontal? I've changed it manually for now but presume the physics needs to be updated for the ListView where StepperType.horizontal?

Temp solution is to add:
physics: widget.physics,
after Expanded(           child: ListView(
near line 671


Massive heap usage of PubSubClient.connect

Hi,
I use an ESP8266 with the PubSubClient. There is one thing I don´t understand... why does my free heap ESP.getFreeHeap() drops about 20kb at the moment I call mqtt.connect()? Where is my mistake or is this normal behavior when using MQTT_MAX_PACKET_SIZE = 800? And if it´s normal - can I reduce the heap usage somehow while keeping this packet size?
  WiFiClientSecure espClient;
  PubSubClient mqtt_client(espClient);

  Serial.println("Attempting MQTT connection ... ");
  espClient.setInsecure();
  Serial.printf("----Free Heap after: espClient.setInsecure(): %d  ----\r\n", ESP.getFreeHeap());

  mqtt_client.setServer(mqtt_server, mqtt_port); // Configure MQTT client
  Serial.printf("----Free Heap after: mqtt_client.setServer: %d  ----\r\n", ESP.getFreeHeap());

  if (mqtt_client.connect(WiFi.macAddress().c_str(), mqtt_user, mqtt_pass)) {
    Serial.println("connected to MQTT broker");
  } else {
    Serial.print("failed with return code ");
    Serial.println(mqtt_client.state());
  }
  Serial.printf("----Free Heap after: mqtt_client.connect: %d  ----\r\n", ESP.getFreeHeap());

results in
Attempting MQTT connection ...
----Free Heap after: espClient.setInsecure(): 25736  ----
----Free Heap after: mqtt_client.setServer: 25736  ----
connected to MQTT broker
----Free Heap after: mqtt_client.connect: 4672  ----

It seems more to be a WifiClientSecure issue... closed :-)


"Who can Access the Data" section doesnt mention Global Reader which appears to work

for viewing Audit logs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 378b87c1-ae6d-6b16-57b9-5f312583b8bd
Version Independent ID: bdf6b43b-ac28-f1ac-e53b-d99f22d0754c
Content: Audit activity reports in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/concept-audit-logs.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@andyjballgit Thank you for pointing this out . I have verified this on my test tenant internally and have submitted a review with the content authors. Once they have reviewed it , the changes will be updated on the article. We will now close this issue and the change will be live in the next release cycle in 24-48 hours once review is complete.
Thank you.


refactor: add local to use add method

Description
Add_local should be the same as add, just that instead of calling the argument url it's called content to drive home the point, that you're not passing a URL.
A discrepancy already found it's way in the code, so I think it only makes sense to call add from add_local to make it more maintainable.
This PR also includes a documentation update.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)
[X] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Unit Test

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@cachho : I think it makes much more sense to remove the add_local function and whatever functionality was there, just port it to add.
so ideally
bot = App()
bot.add("qna_pair", ("Who is Naval Ravikant?", "Naval Ravikant is an Indian-American entrepreneur and investor."))

So now add supports the same functionality as .add_local and .add_local is not there.

@cachho : I think it makes much more sense to remove the add_local function and whatever functionality was there, just port it to add.
so ideally
bot = App()
bot.add("qna_pair", ("Who is Naval Ravikant?", "Naval Ravikant is an Indian-American entrepreneur and investor."))

So now add supports the same functionality as .add_local and .add_local is not there.

as I said in the post/comments, the only problem with that approach is that intellisense will ask the user for a url argument. This will confuse the user when they add text for instance.

Let's just say, this approach is better and more maintainable then what we have right now. We should merge it. Then we can still think about deprecating it.

@cachho : i think this PR does not hold. add_local is meant to add text or qna pair. its not meant to add local files.
also have made a comment in PR #380 about the add_local.
feel free to close this if PR is not valid.

@cachho : i think this PR does not hold. add_local is meant to add text or qna pair. its not meant to add local files. also have made a comment in PR #380 about the add_local. feel free to close this if PR is not valid.

the whole point of this PR is that add_local uses the add method internally so that we only have to maintain one. Which basically makes it an alias, which it already is today.
With PR #380 this can go. Will close once that is merged, until then I still see this as a good idea.

closing because this was done in #380.


Update readme with link to custom card

I made a custom card for your component and added to your readme, IF you want to link it from there.

Wow, this looks amazing. Thanks a lot. Definitely adding this pr.


Add my personal website (kelset.dev) to the list

👋
Thanks for making this theme, it's very good!
I'm adding my website to the list of users with this PR :)

Thanks for using Congo, @kelset! I'll merge this change in. Your site will appear on the public list when the next theme release is published.


[Bug] Reason: column(DORIS_DELETE_SIGN) values is null while columns is not nullable.

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
doris2.0.2 flink 1.17.2
What's Wrong?
use flink for load data to doris,it throw this error and can load data.
when i set the option executionBuilder.setDeletable(false) it can load data success
What You Expected?
load data even if i haven't set "executionBuilder.setDeletable(false)"
How to Reproduce?
DorisSink.Builder builder = DorisSink.builder();
Properties pro = new Properties();
pro.setProperty("format", "json");
pro.setProperty("read_json_by_line", "true");
pro.setProperty("line_delimiter", "\n");
pro.setProperty("strict_mode", "false");
pro.setProperty("merge_type", "APPEND");
DorisOptions.Builder dorisBuilder = DorisOptions.builder();
dorisBuilder.setFenodes("if:8030")
.setUsername("user")
.setPassword("password").setTableIdentifier("database."+table);
DorisExecutionOptions.Builder  executionBuilder = DorisExecutionOptions.builder();
executionBuilder
.setStreamLoadProp(pro)
.setLabelPrefix(table);
builder.setDorisReadOptions(DorisReadOptions.builder().build())
.setSerializer(new SimpleStringSerializer())
.setDorisExecutionOptions(executionBuilder.build())
.setDorisOptions(dorisBuilder.build());
multiStream.getSideOutput(outputTagMap.get(table)).sinkTo(builder.build());
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think we should set the sink.enable-delete parameter to false by default


HBASE-24516 Parameter copyFiles should be passed in SecureBulkLoadClient

When refactor SecureBulkLoadClient started in HBASE-22380. The public secureBulkLoadHFiles method parameter copyFiles was not passed to the refactoring method.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.2 Compile Tests _

+1 :green_heart:
mvninstall
5m 43s
branch-2.2 passed

+1 :green_heart:
compile
0m 28s
branch-2.2 passed

+1 :green_heart:
checkstyle
0m 39s
branch-2.2 passed

+1 :green_heart:
shadedjars
4m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
branch-2.2 passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 18s
branch-2.2 passed

-0 :warning:
patch
1m 26s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 14s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
28m 14s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 43s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

68m 50s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1868

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4efad511d154 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1868/out/precommit/personality/provided.sh

git revision
branch-2.2 / 61a2ccece1

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/testReport/

Max. process+thread count
257 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Please change the PR to against master branch?
I believe this is not a 2.2 specific bug.

@Apache9 master branch use AsyncClusterConnectionImpl as bulkload client, the bug  not  found.

Only branch-2.2 has the problem? What about branch-2 and branch-2.3?


typo in readme

Context

typo in readme (optionall)
Expected Behavior

typo free readme
Actual Behavior

has a typo
Possible Fix

change the spelling
Steps to Reproduce

visit the repo's readme

Existing issues

[ ] Stack Overflow issues
[ ] GitHub Issues

Context

skimming through the readme
Your Environment

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):
Link to your project:

@Parikshit-Hooda Can you please be specific? The description makes it impossible to know what the issue is and whether this has been fixed or not.

in the readme markdown, we have 'optionall' written in a place where there should be 'optionally'. Please refer to pull#107(https://github.com/accordproject/concerto/pull/107). Although, now I see that some checks have not passed. I shall submit a corrected PR later.

In #114


Make journal metadata required for nihms, but optional for jscholarship.

The only required journal metadata now is journal-title.
Check if journal-title can be made optional for Jscholarship and required for PMC. Does this solution work in the general case of N repositories where the field on one is required? Does the merge algorithm need to be modified? How can the ui check if a field is optional or required?

This can be supported by editing the schemas appropriately. The journal-title will be optional by default, but specific repositories can make it required. The journal metadata which should not be edited (because it comes from pass, the title and nlmta) also has the labels changed not to have (required) and (optional) which is just confusing.
For pass-ui, it can check if a journal is needed by checking the required status of the journal-title field. This will be indicated by the presense of journal-title in the required array of a root schema object.


A significant amount of variant loci information on some chromosomes is missing after merging

Dr. Zheng,
Hello! Happy holidays!
I previously used PART_run.pl (starskyzheng-patch-2) to merge structural variant (SV) data from second-generation population sequencing data generated by VG giraffe. Recently, when using the merged data, I noticed that information on variant loci on some chromosomes is missing. Specifically, I constructed population data for Malus, which has 17 chromosomes, but after merging, the variant loci on chromosomes 12-17 were missing. I am concerned that there may have been an error in my previous operation. After rerunning the process recently, I found that the problem still persists, and this time the variant loci on chromosomes 8-17 have disappeared from the results. I apologize for disturbing you during the holiday, but if you have time, could you please help me clarify this issue?
Best regards,
Bocheng

I carefully checked the run log and found that the problem might have occurred during the "reading ref fasta" step, as not all sequences were read in. When executing bcftools sort OUTDIR_RUN1/2.thin1.unsorted.vcf.gz -o OUTDIR_RUN1/2.thin1.sorted.vcf.gz --temp-dir tmp/tmp_bcftools, a warning appeared: [W::bgzf_read_block] EOF marker is absent. The input may be truncated. This could be due to the file being too large, which may have led to the error. I am now preparing to try splitting the VCF and running it again.

You may need check file OUTDIR_RUN1/2.thin1.unsorted.vcf.gz  by using gzip -t xx.vcf.gz.

yes, I have checked 2.thin1.unsorted.vcf.gz using grep, and discovered that it is missing some chromosomes.

I see. The log shows that 1.realign0.unsort.vcf.gz seems broken. May be you could also check this file.

Sorry! I deleted the previous results. Now, when I process each chromosome separately, I don't encounter the issue that was occurring before. I think the problem has been resolved. It might have been caused by the vcf file being too large. Thank you for your response!


Optimize pow2 co-processor AIR constraints for output aggregation

The pow2 co-processor currently uses 2 constraints for output aggregation, but we can do better.
The design of the pow2 processor and its current constraints are described here.
The implementation is here.
It may be possible to reduce this to one constraint without changing the design of the table. If so, that would be optimal. Alternatively, @bobbinth provided this suggestion:

I wonder if we could do better here. Right now, for every row we compute the sum twice, once for the current row and once for the next one. Since we are multiplying by small powers of two, this is not super expensive - but still, would be good to do it only once.
For example, we could introduce an extra column which would be responsible for copying the value of z from the previous row. Assuming this doesn't increase the width of the auxiliary table beyond 18, this could be a much cheaper option.

Restrictions on the new constraint:
As mentioned in the docs in the pow2 processor file, the selector flags for this processor require degree 4. The maximum degree for constraints in Miden is 9, so any new constraint for output aggregation must be degree 5 or less without the flags.

As an additional note - the bitwise co-processor also uses 2 constraints for output aggregation to handle the first row, then all the transition rows. The optimized construction that we come up with here can likely be reused there as well.

@grjte - Is it fine if I take this up?

@0xKanekiKen that would be great! Please let me know if you have any questions. We can chat directly if needed

@grjte: Thanks! We can chat on discord if it's fine with you.

Sure, that works!

Closed by #232


deployment produced an unexpected new value: .traffic_filter: was null, but now...

Readiness Checklist

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

I have attempted to deploy an deployment which doesn't have any traffic filters using Terraform.
Current Behavior

When applying changes to ec_deployment.example_minimal, provider
"provider[\"registry.terraform.io/elastic/ec\"]" produced an unexpected new
value: .traffic_filter: was null, but now
cty.SetVal([]cty.Value{cty.StringVal("b888ca7f774f495f9ec756fc334ddea9")}).

This is a bug in the provider, which should be reported in the provider's own
issue tracker.
Error: Process completed with exit code 1.

Terraform definition

data "ec_stack" "latest" {
  version_regex = "latest"
  region        = "gcp-europe-west2"
}

# create deployment instance
resource "ec_deployment" "example_minimal" {
  name = "Test 123"

  region                 = "gcp-europe-west2"
  version                = data.ec_stack.latest.version
  deployment_template_id = "gcp-storage-optimized-dense"

  traffic_filter = [
  ]

  elasticsearch = {
    hot = {
      autoscaling = {}
    }
  }

  kibana = {}
}

Steps to Reproduce

Use the configuration above
Run the configuration
Results in the error included above

Context

It's not possible to deploy the deployment. If i change the traffic filters to an empty array, it then (incorrectly) attempts to delete and recreate the entire deployment, but still results in the same issue.
Possible Solution

None. This doesn't appear to be useable.
Your Environment

Version used: 0.7.0
Running against Elastic Cloud SaaS or Elastic Cloud Enterprise and version: latest
Environment name and version (e.g. Go 1.9): ubuntu-latest
Server type and version: GitHub Actions
Operating System and version: Ubuntu
Link to your project: private repo

Is the b888ca7f774f495f9ec756fc334ddea9 traffic filter configured to be automatically applied to all deployments? It would explain why this filter is being applied to a deployment freshly created via TF.
I'd expect this to be fixed already in master by https://github.com/elastic/terraform-provider-ec/pull/632. @dimuon is there an indication on when the keystore changes will be ready to make a new release here?

Are you saying if I change the version in here, it'll work because this is already fixed?
terraform {
  required_version = ">= 0.12.29"

  required_providers {
    ec = {
      source  = "elastic/ec"
      version = ">= 0.7.0"
    }
  }
}

Are you saying if I change the version in here, it'll work because this is already fixed?

No, I'm saying that it's been fixed, but not yet released. You could theoretically build the provider yourself from master, but I'm intentionally leaving that as an exercise.
If b888ca7f774f495f9ec756fc334ddea9 is configured to be applied to all deployments then IIUC you should just be able to set traffic_filter = ["b888ca7f774f495f9ec756fc334ddea9"] on the ec_deployment resource and have everything Just Work:tm:

Ok, so same as the ticket: https://github.com/elastic/terraform-provider-ec/issues/433#issuecomment-1600590623
Is there any ETA, as for us we feel this provider isn't really viable to use - particularly as it tries to delete the database instance if any configuration changes occur - deleting a live production database would be bad! 🤣

Ok understood. Sounds like to release cycle is pretty long for terraform providers.. Please don't take this the wrong way, but respectfully I would ask that you guys try and be sympathetic to people who are using your products in production environments and are answerable to their own SLAs. We are reliant of your efforts because we've been told Terraform is 'the way to go' and have put our trust and reliance in you.
It's hard to explain to customers they have to wait weeks or months for something to work. For example, #433 was opened back in February and makes the EC provider totally unusable. Appreciate the hard work, Thanks.

@tobio , I created PRs for both ECE API and the provider but still need some time for IT tests. Also I will need to update Go client SDK after ECE API PR's merge. I'll try to complete this in the following 2 weeks taking into account my sidetrack tasks.

@dimuon can you link to those PRs, so that I may track when they are merged, and update my provider version promptly.
I am running into a very similar issue, returning the same error. In this case the ec_deployment is claiming to own filters rules where it shouldn't. All filters associated with the deployment were linked using ec_deployment_traffic_filter_association resources. But at plan/apply time the deployment tries to remove them, and fails.
resource "ec_deployment" "cluster" {
  region                 = var.region
  name                   = "elastic-gcp-deployment"
  version                = data.ec_stack.latest.version
  deployment_template_id = "gcp-storage-optimized-v5"
  alias                  = "<removed>"

  elasticsearch = {
    hot = {
      autoscaling = {}
    }
  }
  kibana = {}
}

resource "ec_deployment_traffic_filter" "home_filter" {
  name   = "home_filters"
  region = var.region
  type   = "ip"
  rule {
    source = "<removed>"
    description = "<removed>"
  }
  rule {
    source      = "<removed>"
    description = "<removed>"
  }
}

# Note: This hardcoded deployment id is a workaround for a bug in the provider. It must be deployed using a `--target` flag.
# Since the addition of traffic filters, the elastic deployment cannot be reapplied using terraform..
# a fix appears to be in final testing 🤞 https://github.com/elastic/terraform-provider-ec/issues/676
resource "ec_deployment_traffic_filter_association" "squirrel_nests" {
  deployment_id     = "<removed>"
  traffic_filter_id = ec_deployment_traffic_filter.home_filter.id
}

│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to ec_deployment.cluster, provider "provider[\"registry.terraform.io/elastic/ec\"]" produced an unexpected new value: .traffic_filter: was null, but now
│ cty.SetVal([]cty.Value{cty.StringVal("<removed>"), cty.StringVal("<removed>"), cty.StringVal("<removed>"),
│ cty.StringVal("<removed>"), cty.StringVal("<removed>"), cty.StringVal("<removed>"), cty.StringVal("<removed>")}).
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

Thank you!

@efabens this is the provider PR we're waiting on for the next release.
I'm closing this issue out as it's been fixed in master, and will be part of the next release.

Do we have an ETA on it being released please?

This got released with 0.8.0 yesterday.


chore(deps): update dependency ruby-lsp to '~> 0.8.0'

This PR contains the following updates:

Package
Update
Change

ruby-lsp
minor
'~> 0.3.6' -> '~> 0.8.0'

Release Notes

Shopify/ruby-lsp (ruby-lsp)
v0.8.0
Compare Source

What's Changed
🚧 Breaking Changes

Refactor listener registration by @vinistock in https://github.com/Shopify/ruby-lsp/pull/829
Use URI objects instead of strings by @vinistock in https://github.com/Shopify/ruby-lsp/pull/848

🐛 Bug Fixes

Lazily load custom bundle dependencies by @vinistock in https://github.com/Shopify/ruby-lsp/pull/853
Standardize URI and file paths conversions by @vinistock in https://github.com/Shopify/ruby-lsp/pull/850
Use hash to compare lockfiles instead of modified timestamps by @vinistock in https://github.com/Shopify/ruby-lsp/pull/857

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.6...v0.8.0
v0.7.6
Compare Source

What's Changed
🐛 Bug Fixes

Use pathnames and bundler methods in custom bundle logic by @vinistock in https://github.com/Shopify/ruby-lsp/pull/847

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.5...v0.7.6
v0.7.5
Compare Source

What's Changed
🐛 Bug Fixes

Avoid mutating nodes in full_constant_name by @vinistock in https://github.com/Shopify/ruby-lsp/pull/836
Avoid mutating document tree in show syntax tree by @vinistock in https://github.com/Shopify/ruby-lsp/pull/835
Pass environment as a hash to system or exec calls by @vinistock in https://github.com/Shopify/ruby-lsp/pull/841
Prevent dependency detector from failing outside of a bundle by @vinistock in https://github.com/Shopify/ruby-lsp/pull/837

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.4...v0.7.5
v0.7.4
Compare Source

What's Changed
✨ Enhancements

Support selection in show syntax tree by @vinistock in https://github.com/Shopify/ruby-lsp/pull/810

🐛 Bug Fixes

Use absolute BUNDLE_PATH when running the server by @vinistock in https://github.com/Shopify/ruby-lsp/pull/827

🛠 Other Changes

Add stalebot for issues & pull requests by @KaanOzkan in https://github.com/Shopify/ruby-lsp/pull/828
Only start server in bundler projects if lockfile is present by @mateusdeap in https://github.com/Shopify/ruby-lsp/pull/826
Add stale messages by @KaanOzkan in https://github.com/Shopify/ruby-lsp/pull/831
Remove comment about experimental Code Lens by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/833
Add instructions for neovim by @catlee in https://github.com/Shopify/ruby-lsp/pull/830

New Contributors

@mateusdeap made their first contribution in https://github.com/Shopify/ruby-lsp/pull/826

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.3...v0.7.4
v0.7.3
Compare Source

What's Changed
🐛 Bug Fixes

Remove old .ruby-lsp folder if ruby-lsp and debug are in the Gemfile by @vinistock in https://github.com/Shopify/ruby-lsp/pull/822

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.2...v0.7.3
v0.7.2
Compare Source

What's Changed
🐛 Bug Fixes

Require sorbet when setting up bundle by @vinistock in https://github.com/Shopify/ruby-lsp/pull/821

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.1...v0.7.2
v0.7.1
Compare Source

What's Changed
🐛 Bug Fixes

Make sure to run bundle install even when not altering the custom bundle by @vinistock in https://github.com/Shopify/ruby-lsp/pull/819

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.7.0...v0.7.1
v0.7.0
Compare Source

What's Changed
🚧 Breaking Changes

Create and synchronize custom bundle in the server by @vinistock in https://github.com/Shopify/ruby-lsp/pull/789

✨ Enhancements

Add go to definition for required files by @vinistock in https://github.com/Shopify/ruby-lsp/pull/791
Make code lens a stable feature by @vinistock in https://github.com/Shopify/ruby-lsp/pull/792
Add show syntax tree request by @vinistock in https://github.com/Shopify/ruby-lsp/pull/805
Add ruby-lsp-check executable by @vinistock in https://github.com/Shopify/ruby-lsp/pull/811

🐛 Bug Fixes

Use empty? instead of blank? on strings by @vinistock in https://github.com/Shopify/ruby-lsp/pull/786
Prevent exception on shutdown (Ignore $/setTrace requests) by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/797
Fix nesting when a target class is specified by @vinistock in https://github.com/Shopify/ruby-lsp/pull/800
Improve pipe completion if the user adds an accidental extra pipe by @vinistock in https://github.com/Shopify/ruby-lsp/pull/812

🛠 Other Changes

Keep track of nesting when locating nodes by @vinistock in https://github.com/Shopify/ruby-lsp/pull/799

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.6.2...v0.7.0
v0.6.2
Compare Source

What's Changed
✨ Enhancements

Don't use Minitest for running tests in a Rails app by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/773

🐛 Bug Fixes

Don't generate test code lenses when the test library is not supported by @st0012 in https://github.com/Shopify/ruby-lsp/pull/769
Only handle gem statements if they have string literal arguments by @vinistock in https://github.com/Shopify/ruby-lsp/pull/772
Catch LoadError exceptions from formatting calls by @catlee in https://github.com/Shopify/ruby-lsp/pull/774
Use untyped instead of T::Class by @vinistock in https://github.com/Shopify/ruby-lsp/pull/776
Fix code lens disappear after non-test class issue by @st0012 in https://github.com/Shopify/ruby-lsp/pull/778
Make on type formatting end completions more robust by @vinistock in https://github.com/Shopify/ruby-lsp/pull/779

🛠 Other Changes

Migrate DocumentHighlight to Listener pattern by @st0012 in https://github.com/Shopify/ruby-lsp/pull/748
Improve minitest detection accuracy by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/770
Add server extensions documentation by @vinistock in https://github.com/Shopify/ruby-lsp/pull/771
Improve CodeLens tests by @st0012 in https://github.com/Shopify/ruby-lsp/pull/775

New Contributors

@catlee made their first contribution in https://github.com/Shopify/ruby-lsp/pull/774

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.6.1...v0.6.2
v0.6.1
Compare Source

What's Changed
🐛 Bug Fixes

Prevent breaking on empty gem statements by @vinistock in https://github.com/Shopify/ruby-lsp/pull/764
Skip test code lens on methods unless its inside a test class by @st0012 in https://github.com/Shopify/ruby-lsp/pull/765

🛠 Other Changes

add default profile for vscode by @D-Forz in https://github.com/Shopify/ruby-lsp/pull/740
Documentation: make sure referenced GIF link exists by @snutij in https://github.com/Shopify/ruby-lsp/pull/749

New Contributors

@D-Forz made their first contribution in https://github.com/Shopify/ruby-lsp/pull/740

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.6.0...v0.6.1
v0.6.0
Compare Source

What's Changed
🚧 Breaking Changes

Drop Ruby 2.7 support by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/732
Make Common#create_code_lens more re-usable by @snutij in https://github.com/Shopify/ruby-lsp/pull/734

✨ Enhancements

Migrate inlay hint to listener by @vinistock in https://github.com/Shopify/ruby-lsp/pull/703
Auto detect formatter when client did not specify it by @asok in https://github.com/Shopify/ruby-lsp/pull/723
Add gem actions in the Gemfile by @snutij in https://github.com/Shopify/ruby-lsp/pull/710
Migrate semantic highlighting to the listener pattern by @vinistock in https://github.com/Shopify/ruby-lsp/pull/727
Add --help to ruby-lsp command, and detect invalid arguments by @technicalpickles in https://github.com/Shopify/ruby-lsp/pull/694
Allow extensions to register formatters by @vinistock in https://github.com/Shopify/ruby-lsp/pull/739

🐛 Bug Fixes

Add semantic highlighting documentation by @vinistock in https://github.com/Shopify/ruby-lsp/pull/701
Escape test name in the commandline to run it in the terminal by @soutaro in https://github.com/Shopify/ruby-lsp/pull/721
Reset visibilities after code lens detection has moved out of a class by @st0012 in https://github.com/Shopify/ruby-lsp/pull/733
Fix Run In Terminal code lens for test class by @st0012 in https://github.com/Shopify/ruby-lsp/pull/736
Always append test class name to the test command by @st0012 in https://github.com/Shopify/ruby-lsp/pull/737
Change 'bundle' wording by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/745
Distinguish test-unit and minitest in code lens by @st0012 in https://github.com/Shopify/ruby-lsp/pull/746
Fix incorrect folding for else by @abhiroopdutta in https://github.com/Shopify/ruby-lsp/pull/759

🛠 Other Changes

Add warning to Support::Common by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/689
Fix Remove duplicate backticks by @pppp606 in https://github.com/Shopify/ruby-lsp/pull/716
Upgrade Psych to v5.1.0 by @vinistock in https://github.com/Shopify/ruby-lsp/pull/731
Upgrade to Ruby 3.3.0-preview1 by @vinistock in https://github.com/Shopify/ruby-lsp/pull/725
Add instructions for eglot client by @asok in https://github.com/Shopify/ruby-lsp/pull/729
Add manual testing note to CONTRIBUTING by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/756
Reuse the same executor instead of creating a new one per request by @st0012 in https://github.com/Shopify/ruby-lsp/pull/758

New Contributors

@pppp606 made their first contribution in https://github.com/Shopify/ruby-lsp/pull/716
@soutaro made their first contribution in https://github.com/Shopify/ruby-lsp/pull/721
@asok made their first contribution in https://github.com/Shopify/ruby-lsp/pull/723
@technicalpickles made their first contribution in https://github.com/Shopify/ruby-lsp/pull/694
@alkhatib made their first contribution in https://github.com/Shopify/ruby-lsp/pull/755
@abhiroopdutta made their first contribution in https://github.com/Shopify/ruby-lsp/pull/759

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.5.1...v0.6.0
v0.5.1
Compare Source

What's Changed
🐛 Bug Fixes

Fix missing require for URI by @Eric-Guo in https://github.com/Shopify/ruby-lsp/pull/698

New Contributors

@Eric-Guo made their first contribution in https://github.com/Shopify/ruby-lsp/pull/698

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.5.0...v0.5.1
v0.5.0
Compare Source

What's Changed
🚧 Breaking Changes

Make sending client messages async by @vinistock in https://github.com/Shopify/ruby-lsp/pull/640
Refactor listener pattern to pass emitter around by @vinistock in https://github.com/Shopify/ruby-lsp/pull/681

✨ Enhancements

Return code lens for debugging tests by @st0012 in https://github.com/Shopify/ruby-lsp/pull/657
Make DocumentSymbol a Listener by @vinistock in https://github.com/Shopify/ruby-lsp/pull/647
Migrate document link to listener by @vinistock in https://github.com/Shopify/ruby-lsp/pull/660
Switch to RDoc and expose check_docs rake task to gems by @vinistock in https://github.com/Shopify/ruby-lsp/pull/675
Add Run In Terminal code lens by @st0012 in https://github.com/Shopify/ruby-lsp/pull/686
syntax_tree formatter parse ignore-files opts from .streerc by @t-mario-y in https://github.com/Shopify/ruby-lsp/pull/670

🐛 Bug Fixes

Parse documents under mutex lock when pushing jobs in the queue by @vinistock in https://github.com/Shopify/ruby-lsp/pull/656
Determine formatter for 'auto' (no longer fallback to syntax_tree). by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/654
Change code lens order by @st0012 in https://github.com/Shopify/ruby-lsp/pull/692

🛠 Other Changes

Migrate path completion to listener pattern by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/665
Fix check for RuboCop availability by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/667
Benchmark: remove exit code and fix PathCompletion by @snutij in https://github.com/Shopify/ruby-lsp/pull/673
Run CodeLens together with DocumentSymbol and DocumentLink by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/685

New Contributors

@t-mario-y made their first contribution in https://github.com/Shopify/ruby-lsp/pull/670

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.5...v0.5.0
v0.4.5
Compare Source

What's Changed
✨ Enhancements

Allow registering hover listeners by @vinistock in https://github.com/Shopify/ruby-lsp/pull/593

🐛 Bug Fixes

Warn user that --debug flag requires the debug gem by @st0012 in https://github.com/Shopify/ruby-lsp/pull/629

🛠 Other Changes

Add bug and feature issue templates by @vinistock in https://github.com/Shopify/ruby-lsp/pull/626
Fix event emitter example title by @vinistock in https://github.com/Shopify/ruby-lsp/pull/634
Separate server notifications and requests by @vinistock in https://github.com/Shopify/ruby-lsp/pull/631
feat(benchmark): display missing requests by @snutij in https://github.com/Shopify/ruby-lsp/pull/619
Fix benchmark exit status by @vinistock in https://github.com/Shopify/ruby-lsp/pull/636
Windows compatibility by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/635
Fix benchmark script by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/638
Don't support debugging on Windows by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/639
Reuse same PR comment for benchmark results by @snutij in https://github.com/Shopify/ruby-lsp/pull/645
Fix keyword recognition for on-type formatting by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/612

New Contributors

@snutij made their first contribution in https://github.com/Shopify/ruby-lsp/pull/619

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.4...v0.4.5
v0.4.4
Compare Source

What's Changed
✨ Enhancements

Add code lens for running entire test class by @adisonlampert in https://github.com/Shopify/ruby-lsp/pull/598
Refactor hover with event emitter by @vinistock in https://github.com/Shopify/ruby-lsp/pull/607
Add code lens for test methods by @adisonlampert in https://github.com/Shopify/ruby-lsp/pull/609

🐛 Bug Fixes

Avoid trying to parse document if there are no new edits by @vinistock in https://github.com/Shopify/ruby-lsp/pull/617
Improve robustness of extract to variable by @vinistock in https://github.com/Shopify/ruby-lsp/pull/615
Fix server encoding registration and prefer UTF-8 by @vinistock in https://github.com/Shopify/ruby-lsp/pull/618

🛠 Other Changes

Fix variable spelling (capabilities) by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/603
Add option to skip benchmark in CI by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/613
Use Ruby LSP debug tasks in launch by @vinistock in https://github.com/Shopify/ruby-lsp/pull/616
Use bugfix label for release automation by @vinistock in https://github.com/Shopify/ruby-lsp/pull/627

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.3...v0.4.4
v0.4.3
Compare Source

What's Changed
✨ Enhancements

Streerc support by @molawson in https://github.com/Shopify/ruby-lsp/pull/573

🐛 Bug Fixes

Fix rescue inlay hint with captured variable by @vinistock in https://github.com/Shopify/ruby-lsp/pull/572
Avoid analyzing named regexp captures if left side is not a literal by @vinistock in https://github.com/Shopify/ruby-lsp/pull/574
Fetch latest doc for Rails versions that do not have their own docs by @adisonlampert in https://github.com/Shopify/ruby-lsp/pull/591
Only show refactor action if range is not empty by @vinistock in https://github.com/Shopify/ruby-lsp/pull/595
Add syntax tree node types and fix issues surfaced by typechecking by @vinistock in https://github.com/Shopify/ruby-lsp/pull/583
Make requests that handle text edits non concurrent by @vinistock in https://github.com/Shopify/ruby-lsp/pull/600

🛠 Other Changes

Create Rubocop Cop to detect LanguageServer constants by @caalberts in https://github.com/Shopify/ruby-lsp/pull/543
Include version and uri in document by @vinistock in https://github.com/Shopify/ruby-lsp/pull/561
Restructure README by @vinistock in https://github.com/Shopify/ruby-lsp/pull/580
Add Slack and VS Code extension badges to readme by @st0012 in https://github.com/Shopify/ruby-lsp/pull/582
Use document.uri instead of passing uri around by @vinistock in https://github.com/Shopify/ruby-lsp/pull/597

New Contributors

@caalberts made their first contribution in https://github.com/Shopify/ruby-lsp/pull/543
@molawson made their first contribution in https://github.com/Shopify/ruby-lsp/pull/573

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.2...v0.4.3
v0.4.2
Compare Source

What's Changed
✨ Enhancements

Make extract to variable more robust by @vinistock in https://github.com/Shopify/ruby-lsp/pull/529
Add highlighting support for more local variables by @vinistock in https://github.com/Shopify/ruby-lsp/pull/538
Allow specifying a formatter by @vinistock in https://github.com/Shopify/ruby-lsp/pull/556
Make it easier to configure enabled features by @vinistock in https://github.com/Shopify/ruby-lsp/pull/562
Prevent excessive array allocations in visit_all by @vinistock in https://github.com/Shopify/ruby-lsp/pull/567

🐛 Bug Fixes

Prevent duplicate ranges for code folding by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/528
Visit command blocks in semantic highlighting by @vinistock in https://github.com/Shopify/ruby-lsp/pull/537

🛠 Other Changes

Avoid unnecessary String#sub in diagnostic by @vinistock in https://github.com/Shopify/ruby-lsp/pull/518
Link to the extension README for debugging information by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/526
Update Ruby and bundler by @vinistock in https://github.com/Shopify/ruby-lsp/pull/533
Fix coding folding when argument has no parenthesis (e.g. RSpec syntax) by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/517
Start processing method definitions with inline visibility modifiers by @paracycle in https://github.com/Shopify/ruby-lsp/pull/547
Support running server in debug mode by @st0012 in https://github.com/Shopify/ruby-lsp/pull/557
Require bundler by @icnagy in https://github.com/Shopify/ruby-lsp/pull/560

New Contributors

@icnagy made their first contribution in https://github.com/Shopify/ruby-lsp/pull/560

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.1...v0.4.2
v0.4.1
Compare Source

What's Changed
✨ Enhancements

Add codeAction/resolve and variable extraction refactoring by @jenny-codes in https://github.com/Shopify/ruby-lsp/pull/491

🐛 Bug Fixes

Fix completion on syntax error by @vinistock in https://github.com/Shopify/ruby-lsp/pull/502
Fix path completions when partial path is typed by @paracycle in https://github.com/Shopify/ruby-lsp/pull/509
Skip formatting if the document is not valid by @st0012 in https://github.com/Shopify/ruby-lsp/pull/507

🛠 Other Changes

Warn that the LSP is ready on initialized by @vinistock in https://github.com/Shopify/ruby-lsp/pull/505
Add shutdown complete notice to logs by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/513
Update texts for refactor: extract variable by @jenny-codes in https://github.com/Shopify/ruby-lsp/pull/514

New Contributors

@jenny-codes made their first contribution in https://github.com/Shopify/ruby-lsp/pull/491

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.4.0...v0.4.1
v0.4.0
Compare Source

What's Changed
🚧 Breaking Changes

Completely dettach IO from parallel request execution by @vinistock in https://github.com/Shopify/ruby-lsp/pull/368

✨ Enhancements

Inform users of failing cops by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/454
Add semantic highlighting for sorbet methods by @TobiasBales in https://github.com/Shopify/ruby-lsp/pull/371
Add path completion support inside require calls by @paracycle in https://github.com/Shopify/ruby-lsp/pull/259

🐛 Bug Fixes

Avoid running RuboCop outside of project folder by @vinistock in https://github.com/Shopify/ruby-lsp/pull/469
Properly place end when there's extra content after keyword by @vinistock in https://github.com/Shopify/ruby-lsp/pull/462

🛠 Other Changes

Adjust some return types to avoid nils by @andyw8 in https://github.com/Shopify/ruby-lsp/pull/463
Fix return type of Executor#execute by @vinistock in https://github.com/Shopify/ruby-lsp/pull/468
Reuse uri when executing hover by @vinistock in https://github.com/Shopify/ruby-lsp/pull/470
Substitute all T::Struct usage for plain Objects by @vinistock in https://github.com/Shopify/ruby-lsp/pull/493
Refactor code actions to use context instead of our own cache by @vinistock in https://github.com/Shopify/ruby-lsp/pull/488

New Contributors

@TobiasBales made their first contribution in https://github.com/Shopify/ruby-lsp/pull/371

Full Changelog: https://github.com/Shopify/ruby-lsp/compare/v0.3.8...v0.4.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Add govuk-lint

I've found this useful on other gov projects - anyone have strong opinions?

Adding:
https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/19


Ryzen and TRX40 quirk presets

I see some changement done in the stuff I maintained and they are wrong!
Please correct them or please delete this:
AMD CPU BaseConfigs plug-in package, pre-selected for AMD CPU Quirks, AMD kernel patch package, Italian description documentation provided and maintained by fabiosun.
thank you

Sorry, can you generate a PR?
I really don't want to be the middleman, changing things around.
Thanks!

@ic005k it is not correct to change things maintained from others without asking
So it is difficult for me to help
Sorry

to explain better:

why was added SetVirtualMap quirk in this preset and also in Ryzen preset?
When was this change made, and what explanation is given for it?
I need to add other important parts for the AMD community (related to the new AM5 system), but if OCAT changes important elements incorrectly, it is not possible to recommend OCAT to AMD users
And that's a pity

All the changes can be traced here:
https://github.com/ic005k/OCAuxiliaryTools/commits/master

I checked and no one really changed anything about AMD:
https://github.com/ic005k/OCAuxiliaryTools/blob/master/Database/preset/Booter-Quirks.txt
As you can see from the above file, the original file contains "SetupVirtualMap", that is, "SetupVirtualMap" exists from the beginning.

So, no one is going to change this but you, please check, thank you.

All PR, here it is:
https://github.com/ic005k/OCAuxiliaryTools/pulls?q=is%3Apr+is%3Aclosed
You can also check.

The most recent changes are here:
https://github.com/ic005k/OCAuxiliaryTools/commit/3cb97ec913147cda56a1de937cb40badd0b68277#diff-9c118997d46169442e31ef50 1a4a664927e343ba56510639ffa154a443ba38ee
It doesn't involve anything AMD, it's an Intel-related update provided by @5T33Z0.

I checked and no one really changed anything about AMD:
https://github.com/ic005k/OCAuxiliaryTools/blob/master/Database/preset/Booter-Quirks.txt
As you can see from the above file, the original file contains "SetupVirtualMap", that is, "SetupVirtualMap" exists from the beginning.

this was old and my proposed quirk to correct this error you can find in my old and closed issue
see the attached image
in the left actual booter quirk in the right image one of the old OCAT release

Sorry, I never check these things. Since I don't have the ability to control this content, I decided to remove all AMD content from OCAT. OCAT officially no longer offers any AMD presets, thank you.

Of course, if you still like OCAT, please make this content available unofficially, it is the only way to guarantee the correctness of the data.
I appreciate your continued contribution to OCAT.

Sorry, I never check these things. Since I don't have the ability to control this content, I decided to remove all AMD content from OCAT. OCAT officially no longer offers any AMD presets, thank you.

if so please remove all AMD plist and my name as AMD contributor
No reason to have partial config or instructions
Thank you

The AMD content is still in there (Quirk presets and plists).
I never touched the AMD settings since @fabiosun was reliable for the AMD stuff.

I wouldn't remove the AMD content because it took him a lot of time to create.

please remove all AMD plist and my name as AMD contributor

Ok, thanks.

@5T33Z0 It is the best way to ensure the correctness of AMD data that OCAT does not provide relevant content officially. Because OCAT has a large number of participants, participants will inevitably modify some content by mistake, which is quite normal.
But in any case, we must be tolerant to look at these things.

can you help me remove the references in the various read me that I can't remove from the fork?
As you might have guessed I'm not a GitHub expert..but AMD I am a little bit.
And having struggled to get OCAT accepted by the AMD community it didn't seem right to remove those quiks even as an option
I used OCAT at an educational level for non-expert users and with those options users were learning how to build an EFI for their system from scratch, without using EFIs found on the net
I hope you get the point
Thanks

@fabiosun I'm sorry. I may not be able to help you.
OCAT program has a bug, you can ask me, I really know little else, you can ask @5T33Z0, he is very good at it.

I think first to have to sync your fork with the latest upstream from the main repo, so you are on the same version so to speak. I use Github desktop for this.

Then you delete the Instructions_AMD.md from your fork.
Then  you delete the AMD plists from your fork
Then you delete all the AMD Quirks settings from all the Quirks .txt files under "preset" (ACPI, BOOTER, KERNEl, UEF)
Finnally you create a pull request and then it will be remmoved from the main repo.

But honestly, ic005k could do this all by himself as well – I don't really get it.

I, on the other hand, don't understand why AMD presets (txt files) were removed, and as the reason was that the developer doesn't know AMD system
Until yesterday they were fine today not?
Then, the developer tests all quirks in person on all Intel machines?
I am really sorry, because, initial misunderstandings with you aside, I put a lot of effort into this app, which I still think is very good
But I don't like that some things that I had prepared for it are "cut out" for no plausible reason
I accept the decision but leave it to others to improve the app on the AMD side

I don't get it either. It's not like I have all the Intel CPUs and mainboards for all of theise configs either. If I would I would probably be running a computer store right now. ;)
So in this regard all the Intel configs are just as unproven as all the AMD configs…

@ic005k
Remove AMD related content.  OCAT no longer bundles any AMD-related content.
please I am not a customer care center for all AMD users :)
thank you

@fabiosun This doesn't prevent you from providing AMD-related content, it's just that OCAT is no longer bundling it, and since I can't control whether AMD content will change in the future, it's best if OCAT doesn't provide it. I hope you understand. Thank you.
Well, I wasted an evening on this nonsense.

Well, I wasted an evening on this nonsense.

here it's afternoon, but in honesty I have to tell you that you started this "nonsense" by deleting things that had been in your app for more than a year.
However, it's your right and you were right to do it!
have a nice evening!

@fabiosun I can host the AMD plists and Settings on my OC-Little Repo, if you like. Which Quirks need to be fixed for AMD you say?

@fabiosun Because we think you are too strict a person to allow anyone to touch anything of yours, which is really unavoidable for a multi-person project.
However, no matter who modified your AMD related content at any time, I, as the main person responsible for the project, sincerely apologize to you.
I'm really sorry. I hope OCAT is always open and anyone can participate and change or improve anything in it. thank you.

@fabiosun Because we think you are too strict a person to allow anyone to touch anything of yours, which is really unavoidable for a multi-person project.
I work for life in many multi person project...
And people can touch my work if it is correct to do it.
AMD quirks have been good for more than a year then OCAT devs decided to delete it.

I accept your decision because I am a guest in your house ;)
You can't convince me of what you are claiming, though.
Anyone who wants to modify AMD things for your program does and will always do so by taking responsibility for the modification with a PR
I only responded to the fact that it was said here that I had made those modifications!
Which is not true
I still wish you and your app the best of successes
@5T33Z0
thanks but I am not interested in maintaining a database in other places than the parent company producing the software :)

@fabiosun Okay. Whatever. Here are some refined instructions if you you choose to host the AMD files on your github.
Generating and configuring AMD EFIs using OpenCore Auxiliary Tools
Instructions
1. Generate a base EFI Folder

Run OCAuxiliaryTools (OCAT)
Open the Database
Double-click on an config.plist for the AMD chipset of your choice
An EFI Folder will be generated and placed on your Desktop including SSDTs, Kexts, Drivers, Themes and the config.plist.

2. Modifying the config.plist
After the base EFI has been generated, config.plist must be modified according on the used CPU, GPU, additional hardware, peripherals, SMBIOS and BIOS.
NOTE: Open the config.plist with a plist editor to find additional information
2.1 Adjust the Core Count
The list below contains available configs for various AMD Chipsets. Based on the CPU used in your system you may have to adjust it (see "Description" for details).

AMD config
Description

AMD-X370_generic.plist
For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

AMD-X470_generic.plist
For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

AMD-B450M_generic.plist
For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

AMD-B550_generic.plist
For 12-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

AMD-X570_generic.plist
For 16-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

AMD-X399_generic.plist
For 24-core AMD ThreadRipper. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

2.2 Create an MMIO Whitelist
For AMD systems, creating an MMIO Whitelist is crucial for a working  AMD ThreadRipper sTRX4 system. You can follow this guide to create your own MMIO Whitelist.
3 Deployment

Once you're done, save the config.plist
Put the EFI folder on a FAT32 formatted USB flash drive and try booting from it
If it works, mount the ESP partition and copy the EFI folder to your SSD/HDD
Done.


Long-Term Vision: Merge into Plex Media Server for easy deployment and auto-configuration

I love the concept of this project, though it's very clearly a sophisticated, complicated, fragile system that puts off most users who may benefit from remote transcoding.
Since Plex Media Server is easily available on many systems (i.e. simple UI on Mac/Windows and one-click installable on many NAS systems), it may make sense to merge this code into Plex Media Server, then develop simple UI to allow users to link PMS installations together for transcoding.
Users would have to point to the same media directories on both sides, then pretty much step back and watch it work.

This also makes it easy to ensure PMS and PRT are uploaded together, and introduces a messaging UI that PRT can take advantage of, which is already familiar to users (Status -> Alerts view).

Agreed, this would be fantastic to build into Plex itself.  Ideally, the functionality would be integrated into Plex Media Server, but unfortunately that is closed source and I am not a Plex employee.  In theory, it would be possible to add much of this functionality into the Plex Transcoder, which is open source.  The main issue is that the code is in c which, while not a technical barrier, takes longer development time and adds complexity to releases as the code would have to be compiled for the many architectures that Plex targets.
We'll see what happens in the future.


why docker dead

Today when i exectue "docker ps", "docker ps -a" or any commands of docker, docker is always dead status. for example:
I type "docker ps", no any info show and in dead status.
I try to kill all process but can't solve this problem

would you please put out  your log here, generally it will be on /var/log/upstart/docker.io.log

@hanxy He are happy to help you with this but you need to provide more information when opening an issue.  You can refer to the information located here as a starting point for what we need to reproduce and help.
With the current information here there is nothing we can do at this time.  Feel free to use that issue template and open one with more information.

@crosbymichael
i can't provide more information, beacuse docker.log is not change
the phenomenon is that
I execute all docker command,  stuck on screen but "docker -version". I must restart docker host and then normal exectue docker command


add a Lambda function to release all accounts

What is this?
This Lambda function will scan organizational units and managed accounts, and tag accounts with state 'released'.
Why is it important?
During normal operations the accounts are transitioned automatically from the state released to the states expired, assigned, prepared and released again. However, in a case of a bug into one of the processing Lambda functions, it may happen that the cycles break and that accounts stay in an intermediate state without additional processing.
Since the state of an account is contained in a tag attached to it, for such situations you can use AWS Organizations to change the state of any account. For this you would visit the page of each account and then change the tag account:state to the value released. This operation is feasible for some dozens of accounts, but can become tedious for large number of accounts. Therefore the need to reset accounts to the state released with a simple invocation of a Lambda function devoted to this usage.
How to implement it?

[x] document recovery scenarios in a feature file
[x] create a new Lambda function ReleaseAccounts
[x] add a workbook to help system administrators

With this code SPA has a simple mechanism to recover from broken state machines. The solution is suitable for hundreds of AWS accounts.