MP4 Video not showing (but audio does)

I've tested with my own mp4, and with this one:
https://github.com/flutter/plugins/tree/master/packages/video_player/video_player/example/assets
Both will play from the emulator's Downloads folder, in Android, but when using in my Flutter app, with video_player only audio plays.  I've been experimenting with formats and Blender and ffmpeg commandlines for hours (based on web searches for help).  This has only been tested in the emulator.
For what it's worth: This is with a Nexus 5x x86 emulator setup (android 8.0.0, kernel 3.18.56+) , using VS Code as my IDE.
dependencies: video_player: ^0.10.11
I'm suspecting this line is the main indicator of the issue: Unsupported profile 4 for video/mp4v-es
The debug output follows:
Launching lib/main.dart on Android SDK built for x86 in debug mode...
✓ Built build/app/outputs/apk/debug/app-debug.apk.
D/EGL_emulation(17587): eglMakeCurrent: 0x9e5057e0: ver 2 0 (tinfo 0x88d57630)
I/ExoPlayerImpl(17587): Init 7d1f22d [ExoPlayerLib/2.9.6] [generic_x86, Android SDK built for x86, Google, 26]
I/VideoCapabilities(17587): Unsupported profile 4 for video/mp4v-es
I/OMXClient(17587): Treble IOmx obtained
D/SurfaceUtils(17587): connecting to surface 0x7f5a0808, reason connectToSurface
I/MediaCodec(17587): [OMX.google.h264.decoder] setting surface generation to 18009089
D/SurfaceUtils(17587): disconnecting from surface 0x7f5a0808, reason connectToSurface(reconnect)
D/SurfaceUtils(17587): connecting to surface 0x7f5a0808, reason connectToSurface(reconnect)
E/ACodec  (17587): [OMX.google.h264.decoder] setPortMode on output to DynamicANWBuffer failed w/ err -1010
I/ACodec  (17587): codec does not support config priority (err -1010)
I/OMXClient(17587): Treble IOmx obtained
I/ACodec  (17587): codec does not support config priority (err -2147483648)
D/MediaCodec(17587): [OMX.google.h264.decoder] setting dataspace on output surface to #103
D/AudioTrack(17587): Client defaulted notificationFrames to 3675 for frameCount 11025
W/GrallocMapperPassthrough(17587): buffer descriptor with invalid usage bits 0x2000
D/        (17587): HostConnection::get() New Host Connection established 0x7f5dcbc0, tid 17635
D/SoftwareRenderer(17587): setting dataspace on output surface to #103

The screen (in its current state):
import 'package:video_player/video_player.dart';
import 'package:flutter/material.dart';

class ScreenSplash extends StatefulWidget {
  @override
  _ScreenSplashState createState() => _ScreenSplashState();
}

class _ScreenSplashState extends State<ScreenSplash> {
  VideoPlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.asset(
        'lib/assets/videos/vid.mp4')
      ..setVolume(1.0)
      ..initialize()
      ..play();
      /* .then((_) {
        // Ensure the first frame is shown after the
        // video is initialized, even before the
        //  play button has been pressed.
        setState(() {});
      }); */
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Video Demo',
      home: Scaffold(
        body: Center(
          child: _controller.value.initialized
              ? AspectRatio(
                  aspectRatio: _controller.value.aspectRatio,
                  child: VideoPlayer(_controller),
                )
              : Container(),
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ?  Perhaps there's something wrong in that widget tree above, or the initialization and state handling.
The code I based the fixed version on may be found at:
https://androidmonks.com/flutter-video-player/#Creating_the_Application
For learning, I'd still like to understand what is wrong with the code I pasted, so I'll leave this open, hoping it's not inappropriate.

Hi @jaggzh
Glad you resolved the issue
Here i fixed your previous code sample with no audio
Simply arranged init code and call setState()
    _controller = VideoPlayerController.asset('assets/Butterfly-209.mp4');
    _controller.addListener(() {
      setState(() {});
    });
    _controller.setVolume(1.0);
    _controller.setLooping(true);
    _controller.initialize().then((_) => setState(() {}));
    _controller.play();

Code Sample
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: ScreenSplash(),
    );
  }
}

class ScreenSplash extends StatefulWidget {
  @override
  _ScreenSplashState createState() => _ScreenSplashState();
}

class _ScreenSplashState extends State<ScreenSplash> {
  VideoPlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.asset('assets/Butterfly-209.mp4');
    _controller.addListener(() {
      setState(() {});
    });
    _controller.setVolume(1.0);
    _controller.setLooping(true);
    _controller.initialize().then((_) => setState(() {}));
    _controller.play();
    /* .then((_) {
        // Ensure the first frame is shown after the
        // video is initialized, even before the
        //  play button has been pressed.
        setState(() {});
      }); */
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Video Demo',
      home: Scaffold(
        body: Center(
          child: _controller.value.initialized
              ? AspectRatio(
                  aspectRatio: _controller.value.aspectRatio,
                  child: VideoPlayer(_controller),
                )
              : Container(),
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
          ),
        ),
      ),
    );
  }

  @override
  void dispose() {
    super.dispose();
    _controller.dispose();
  }
}

This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself, if you disagree please write in the comments and I will reopen it
Thank you


Update patchwork integration test to use own keys so it's authenticated for any RPC request.

…

You should run ./gradlew spotlessApply to get the build to pass.

Thanks @atoulme - fixed =]


Improve filters layout

The current layout for filters is a simple HTML form behind a summary field:

Instead, presenting the filters in a more useful way would be to use an HTML fieldset like this:

Here is the enhanced filter section:

Fixed by PR #75


#170

Added some waits when showing and hiding the ‘GoToPrompt’

@latenitefilms Can you test if this makes any difference on your system?


CI: power USB hub on before test and off afterward

Update workflows to turn USB hub on at the start of a test and off at the end of it.
Update docker images with USB hub control that uses parameters for on/off/cycle control.

resolves https://github.com/golioth/firmware-issue-tracker/issues/389

When observing the hubs while CI for this PR ran I noticed that the data connectivity lights go off, but some boards didn't power down. Further investigation shows that for the model of hubs we have, only 2 of the 7 ports are capable of switching the power lines.
I've ordered a different hub model to test and will submit this PR for review when I have confirmed that device as replacement for our runner setups.


[UIMA-6274] Setting feature on builtin JCas cover class that was loaded before initializing TypeSystemImpl fails

Introduce TypeSystemImpl.createCallSiteForBuiltIn() to provide special handling for the static TSI initialization being triggered by loading a built-in JCas cover class.
Updated the built-in JCas cover classes to use the new method to initialize their feature callsites
Added unit test
Fixed typo in comment

@mischor this might be one you'd care to have a quick look at.

@mischor instead of introducing another createCallsiteForBuiltins method, I was considering to add a check into the exiting createCallsite which would check if the given JCas cover class is a built-in and then perform the extra logic - or even to perform the extra logic in any case, even for non-built-in classes.

This correction solve the problem in my environment.

Given no additional feedback was submitted, I am assuming this is alright and merge it.


allow group to be more than one column (joining them with a separator)

It works for visOmopTable but needs to be implemented in gettable and fxTable


fix-psp-values-for-observability-bundle

What this PR does / why we need it
Towards https://github.com/giantswarm/giantswarm/issues/29529
Testing
Description on how default-apps-azure can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for default-apps-azure installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Trigger e2e tests

/run cluster-test-suites

Check if https://github.com/giantswarm/default-apps-azure/pull/202 is merged before this one


Question about your code

Dear motla,
I have one question.
Actually I don't know how i can ask you, so i decided to use this area.
I know it can break your rule, so sorry for that.
In your code, under  src/bar/Bar.vue, BarButtonGeneric.vue  ....
I can see < component > element.
what this element means?
It looks as if it changes to many other components  like BarButtonGeneric, BarSapcer, BarSeperator.. and so on in  Bar.vue.
it's very hard to find the function or meaning of  < component > element.
Could you let me understand its meaning?
Thanks in advance
June Chung.

Hi!
No problem. If the documentation is not clear enough don't hesitate to ask.
What "element" are you talking about? Can you point me the code line to look at?

Hi!
No problem. If the documentation is not clear enough don't hesitate to ask.
What "element" are you talking about? Can you point me the code line to look at?

Hi motla,
Thanks for your reply.
I found out < component > is omitted in my question.
HTML element in this edit box may disappear after registration.
Anyhow, I am a beginner in Vuejs and I have been studying it for over one month.
Now i am trying to convert my service based on JQuery into Vuejs and found your source that can be a good reference to me.
I think you are using many strange coding technique to me.
For example,  there are something like < component >,  function inheritance or something( i mean get_component() is used without declaration in your BarmenuItem.vue maybe it is possible by recursive component ).
Could you explain about < component > and how can you use  get_component() without declaration?

I use mixins to declare functions that are common to several components (https://vuejs.org/v2/guide/mixins.html)

Bascially a mixin merges its content to the component. So get_component is defined here (you should definitely use an IDE with a good search engine like VSCode to locate functions):
https://github.com/motla/vue-file-toolbar-menu/blob/672a34d24508c214dc452f5fe32fa13cd79353c4/src/Bar/imports/bar-hotkey-manager.js#L36-L39

<component> is used to reference a component that can be set/changed dynamically https://vuejs.org/v2/guide/components-dynamic-async.html

I understand the code can be tough, but what are you trying to do? Maybe you don't have to modify it for your project.
Welcome to Vue.js by the way. Hope you'll like it and make it to open-source someday.

But you're right I will bring back get_component out of the mixin in the next release, as it's unclear (same name is declared several times in different components and it has nothing to do with the hotkeys). Thanks for pointing it out.

But you're right I will bring back get_component out of the mixin in the next release, as it's unclear (same name is declared several times in different components and it has nothing to do with the hotkeys). Thanks for pointing it out.

Hi, motla.
Many many thanks to you.
Your answer was so helpful to understand your code.
Your code is a good reference for me to understand vuejs.
Now I am digging your code.
If there will be another question, I will ask your help again.
June Chung.


Prepare Release 1.54.0

Prepares Jaeger for release 1.54.0.
Includes jaeger-ui and idl submodule updates.

I think we should undo idl submodule change, this is not a part of normal release process.
I through it was already at latest:
bdd5ab5 - (HEAD, origin/main, main) Upgrade to opentelemetry-proto v1.1.0 (#104) (3 weeks ago) <Yuri Shkuro>

Since it's not, I would like to look into it separately and have a dedicated PR, not sneak it into a release update.

thx yuri!

Since it's not, I would like to look into it separately and have a dedicated PR, not sneak it into a release update.

I was following this step:
https://github.com/jaegertracing/jaeger/blob/main/RELEASE.md?plain=1#L8
Will submit a PR to clarify.


open source beginner

In reference to the video uploaded on 'codeforcause' youtube account to get a quick-hands on.

Thanks for your PR, you have made your first contribution.

@deepansha-singh Checkout hacktoberfest page are you getting that PR credit?


[logger] Implemented the base part of logger

Added sender;
Added simple adapter for the native function error_log;

approved


SBT 0.13.15 tgz has bad signature

$ wget https://dl.bintray.com/sbt/native-packages/sbt/0.13.15/sbt-0.13.15.tgz.asc
$ wget https://dl.bintray.com/sbt/native-packages/sbt/0.13.15/sbt-0.13.15.tgz
$ gpg2 --batch --verify sbt-0.13.15.tgz.asc sbt-0.13.15.tgz
gpg: Signature made Sun 09 Apr 2017 21:25:33 BST
gpg:                using RSA key 99E82A75642AC823
gpg: BAD signature from "sbt build tool<EMAIL_ADDRESS>[unknown]

Not sure what happened with Bintray. Verified shasum:
$ shasum -a 256 sbt-0.13.15.tgz
b6e073d7c201741dcca92cfdd1dd3cd76c42a47dc9d8c8ead8df7117deed7aef  sbt-0.13.15.tgz

and re-signed the artifacts.

@eed3si9n which one is the correct hash?
You should spend some time on working out how you signed an invalid binary. And announce an analysis of how this breach occurred.
Did something replace the binary or signature after you released them? Did something trick you into signing the wrong binary?

😱

@eed3si9n bintray automatic signing should NOT be used for infrastructure critical components like SBT.


New version: LITS v0.2.0

Registering package: LITS
Repository: https://github.com/Energy-MAC/LITS.jl
Created by: @jd-lara
Version: v0.2.0
Commit: f8a6eaa0fc5a3aec838663a0334849bac532fa9b
Reviewed by: @jd-lara
Reference: https://github.com/Energy-MAC/LITS.jl/commit/f8a6eaa0fc5a3aec838663a0334849bac532fa9b#commitcomment-35638162

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


Load configuration from .reek.yml

The plugin is currently not loading the config from a .reek.yml you may have in your project. Looking at Reek's source I found the method ::Reek::Configuration::AppConfiguration.from_default_path.
I tested locally and it worked.

@parruda I tried this patch, but it still is not picking up my custom .reek.yml config, I tried adding the config to my app directory and home path.

@castwide resuming thread from misfiled issue.
@parruda thanks for patch. Unfortunately not working for me either.

@castwide resuming thread from misfiled issue.
@parruda thanks for patch. Unfortunately not working for me either.

Not sure if anyone is still looking into this issue or not, but I have been doing a bunch of testing today, and this PR does work, but doesn't solve 100% of the problems.
It does pull in .reek.yml file, but it looks like there might be a bug in Reek itself in how that file is then interpreted by the Examiner constructor because smells are still returned for files that should be excluded in the "directories:" section of the yml file. The global detector settings in the .reek.yml file in the "detectors:" section are recognized and do work, but custom settings I had under "directories:" in the .reek.yml file were not used. I was able to rework my config file to make everything work with the global "detector:" settings with smart excludes, but it is annoying. To me this seems like it might be an issue kind of like what you see with Rubocop without using the --force-exclusion option.
I'll try and see if I can figure more out in the future, but I do think merging this as-is is definitely an improvement and at least makes the plugin more useful, but there is more work to be done to get the whole .reek.yml file to be used correctly.

I can confirm that this issue still exists. Considering that the fix is so concise (even if it only fixes the detectors configuration as @basabin54 reported), could this be merged and released?

@castwide Is this one ready to be approved & merged? I'm eager to have it available and working 😄

I tested and can confirm that the patches from @parruda (#1) and @edward-mb (#2) work.
#1 supports only the detectors configuration option. #2 adds support for the directories configuration option.
However, the support for the exclude_paths configuration option is still missing.
My PR #3 is based on #1 and #2 and adds support for the exclude_paths configuration option. Reek configuration files should therefore be fully supported.

Sorry for the incredibly long delay. I'll release a new gem today.


fix(template): transformData checks too strict

The Template component shouldn't throw an error if you define
the transformData for a single templateKey.
Fix #347

I have trouble understanding the fix + the test given the bug explanation:

not working: transform data function + there is no result

Just add this to the hits widget in the example app
item: function (hit) {
return hit;
}

I have trouble understanding the fix + the test given the bug explanation:

Using transformData with object should not impact the non-specified template keys. Here it was used with {hit: fn} but then the empty function wasn't found while generating the empty templateKey:  therefore we threw an exception. I introduced the bug in https://github.com/algolia/instantsearch.js/pull/213


Pick hosting platform

Options:

AWS
Google Cloud
Heroku
IBM Cloud ;)
other jawns

We might be able to host the client server one place, and the api server elsewhere

Going with IBM Cloud for now


jit does not respect backend type when the function has no arguments

Example:
from jax.api import jit
import jax.random as random

def x():
  return random.normal(random.PRNGKey(1), (2, 3))

x().device_buffer.device()
jit(x)().device_buffer.device()
jit(x, backend='cpu')().device_buffer.device()

All these output GpuDevice(id=0), while the last one should be CPU.

Functions without arguments can't meaningfully be jitted, since jit relies on data dependence to trace primitives inside the function (it injects tracer values for each function argument, and follows them through the function). That is, the return value of x() is actually a constant that was computed op-by-op (on the default device) when jit attempted to trace x(), and not the result of a jitted XLA computation at all.
We don't yet have a way to specify the device used for op-by-op computations; it might make sense for such a mechanism to be dynamically scoped (i.e., a context manager) since we can't use data dependence for scoping the way we do for jit.

If for some reason you really need to use this idiom, you can force data dependence on constants (sometimes handy to prevent them from being folded out) by using lax.tie_in:
from jax.api import jit
import jax.random as random
from jax import lax

dummy = 0

def x(_placeholder):
  return lax.tie_in(_placeholder, random.normal(random.PRNGKey(1), (2, 3)))

print(x(dummy).device_buffer.device())  # --> gpu
print(jit(x)(dummy).device_buffer.device())  # --> gpu
print(jit(x, backend='cpu')(dummy).device_buffer.device())  # --> cpu


Turn the analysis code into functions

I have been copying the same notebook to perform analysis on the different scenarios, at this point the code should be centralized for uniformity and testing.
This issue can be closed by a PR that contains .py files of functions that will produce the analysis we've been using.

I forgot that I had made some changes to the analysis notebook for some of the reactors, but not all of them (that's what prompted this issue)


Faster version of compareFilenames()

The compareFilenames() function can sort files by either name first (then extension) or extension first (and then name). Old code executes both comparisons and then only uses the results that it needs. The vast majority of comparisons only need either name comparison or extension comparison (not both).
This code now breaks the 2 search types into sub-functions which has these 2 benefits:

Only execute comparisons needed
var storage is function scope, so it's not allocated unless it's used.

For file tree (name-first) comparison, my measurements on Win7 indicate that this function uses ~40% less time.

Wouldn't it be even faster if we applied .toLocaleLowerCase to the whole filename first, so we don't have to do it twice in the case where both checks are performed?

Wouldn't it be even faster if we applied .toLocaleLowerCase to the whole filename first, so we don't have to do it twice in the case where both checks are performed?

If new vars are created for the lowercase filenames then I suspect that it could opposite effect since the it's not common do need both checks and this would cause more storage to be allocated. But re-using existing filename1 and filename2 vars might work. This needs to be profiled.

@MarcelGerber I implemented "only lowercase once" in commit https://github.com/adobe/brackets/commit/9b3856a9b628955fdb51c568d27c857374038c4a
@MiguelCastillo I implemented "define os-specific function to compare file names" in commit https://github.com/adobe/brackets/commit/61c1c9975484fde04e20d5ac9baff6425d1c0913
I measured performance by putting a timer in _sortDirectoryContents() function in FileTreeView.js. Time reduction compared to master is now ~50%

@abose This PR is ready for as final review.

Looks good. Merging.

Thanks @redmunds .

Thanks everyone who helped with this one.


[ur_controllers] Add exec_depend to joint_state_broadcaster

Signed-off-by: Gaël Écorchard<EMAIL_ADDRESS>

Thanks and greetings @destogl . Sorry for the mistake, I corrected it.

No problem.


Investigate why the Start Jetty task is invoking full client compiles

The Start Jetty task, defined in eng/pipelines/templates/jobs/archetype-sdk-client.yml, uses pom.client.xml to pull in the jetty plugin from the parent\pom.xml but this can end up causing full track 2 client builds when running this task during a track 1 data build. This can also happen during the test runs for pipelines which also start jetty.

This doesn't appear to be happening any longer (at least looking through the pipelines in the various builds as far back as they go which is only about 30 days). Also, there have been enough improvements to the build system to trim down times over the last couple of months as well. It's something to keep an eye on but right now this doesn't appear to be happening any longer.


HHH-10608 - Avoid exception from Hibernate.initialize when lazy_no_transaction

Thanks a loOnce again, it looks really good. I'll integrate it on master and 5.0.

Merged into master and 5.0


Update zio to 1.0.0-RC11-1

Updates dev.zio:zio from 1.0.0-RC10-1 to 1.0.0-RC11-1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "dev.zio", artifactId = "zio" }]

labels: semver-pre-release

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          41     41
=====================================
  Hits           41     41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c150475...bb1578e. Read the comment docs.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.9 to before v4.4.294",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7f9664525f9cb507de9198a395a111371413f230",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3a061d54e260b701b538873b43e399d9b8b83e03"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "7f9664525f9cb507de9198a395a111371413f230",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "3a061d54e260b701b538873b43e399d9b8b83e03",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: qlogic: qlcnic: Fix a NULL pointer dereference in qlcnic_83xx_add_rings()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.4.294 by commit 3a061d54e260b701b538873b43e399d9b8b83e03, it was introduced in version v3.9 by commit 7f9664525f9cb507de9198a395a111371413f230. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002361


sxiv 1.3.1

@BrewTestBot test this please

Merged in https://github.com/Homebrew/homebrew-x11/commit/bc416c4bc464d6334c1fc7b597e2988dc3f570b4, Thanks again @dunn! :tada:


Enhancement: Enable and configure fixers related to whitespace in code

This PR

[x] enables and configures fixers related to whitespace in code
[x] runs composer cs

Not sure why StyleCI passed for e0ec4218827bee7d32e29c685fd6e9359e6f93ea - it shouldn't have.

Thank you, @svpernova09!


Number of Etcd Pods

I'm wondering how you determine how many etcd pods to generate on startup? It seems to depend more on the master_count than the etcd_count parameters and never seems to be larger than 3.

It is based on the number of master nodes, but does ensure that the number is odd. So if you boot 6 masters, it will set the etcd count to 5. Up to a limit of 9.
Can you reproduce this issue?

Closing due to inactivity.


Improve documentation/error message when Jest config file is present in a different folder

From @trivikr on August 26, 2017 19:18

Issue
Jest tests fail when Jest configuration file is present in a different folder. The Validation Error is not very helpful to understand that --rootDir has to be passed when Jest configuration file is read from some place other than workplace root

Expected behavior
Improve the error description so that user knows that --rootDir has to be passed when Jest configuration file is read from some place other than workplace root

Link to a minimal repo that reproduces this issue
ts-jest-external-config-repro

Copied from original issue: kulshekhar/ts-jest#301

From @kulshekhar on August 26, 2017 19:25
This doesn't sound like it's specific to ts-jest. Isn't this more of a Jest issue?

From @kulshekhar on August 30, 2017 6:49
I checked the test repo (thanks for that) and here's what I think is happening:
Jest is trying to find the ts-jest preprocessor file and throws the error because it can't find it (ts-jest is not even invoked). This can only be changed in Jest.
Does that help?

I created a jest-basic-test to reproduce this issue in Jest (with pure JavaScript)
But transform is only defined for ts-jest config as per Jest Getting Started
For basic Javascript project, <rootDir> need not be used.
My custom build system (for private project) was not throwing Validation Error when --rootDir was not passed. It wasn't throwing any error, and exiting without running any tests - so debugging was difficult.
While debugging, I found out that --rootDir has to be passed while going through the following code in ts-jest, so thought it might be fixed in ts-jest
https://github.com/kulshekhar/ts-jest/blob/2815a094d568180bc0b104fb876cca066a50ff1b/src/utils.ts#L24-L26

Thanks @kulshekhar, I'll move this issue to Jest

Current docs: https://jestjs.io/docs/en/configuration#rootdir-string
It states that it's set to where the config is located. WHat do you think can be improved?

Looks like this was closed with the above PR, thanks @trivikr!


[system] Add recent change in function name to patch

The internal export has been renamed from internal_processStyles to internal_serializeStyles in a recent PR resulting in build failures. This change fixes that. Ideally, this should be moved to the core repo so that similar changes in future do not require a fix in this repo.

[x] I have followed (at least) the PR section of the contributing guide.

I have changed the label. There should be no development for Material UI here, it's about MUI System.
Material UI is the stack made of Base UI (@base-ui/react) + MUI System (@mui/system) + Pigment CSS ( + Pre-designed components following Material Design (@mui/material).


[Additional Parameter Request] Codeunit 99000832 Sales Line-Reserve - OnBeforeVerifyChange

Hi Team,
In Codeunit 99000832 we need to customize code in function VerifyChange. We found that event for this was already requested and approved (we do not see this event in BC16 RTM, but related ticket #6960 with the same publisher as we need is already closed, so we will find this event in BC17, right?)
But part of our customizations are field related (for example, part of customization code is actual only when VerifyChange is called from T37 "Location Code" OnValidate trigger).
Would you be able to add additional parameter CallingFieldNo to an existing OnBeforeVerifyChange event to manage this? Something like this:

local procedure OnBeforeVerifyChange(var NewSalesLine: Record "Sales Line"; OldSalesLine:Record "Sales Line"; CallingFieldNo: Integer; var IsHandled: Boolean)
This parameter should be added to the procedure VerifyChange of Codeunit 99000832 parameters list as well, and to all 9 calls from T37 fields to pass CurrFieldNo to the publisher.
OR, if solution above is not OK, then please just create custom publisher there:
Table 37 - Sales Line, field 7 "Location Code" - OnValidate trigger:

with description:
local procedure OnValidateLocationCodeOnBeforeVerifyChange(var SalesLine: Record "Sales Line"; FieldNo: Integer; var IsHandled: Boolean)

Additional comment:
We just found that we have the same problem in Table 37 Sales Line - OnModify trigger. There we also have a need to replace calling of ReserveSalesLine.VerifyChange with our own code (or possibility to have CallingFieldNo parameter there to manage our customization using OnBeforeVerifyChange event.
So first solution with CallingFieldNo would resolve more than one problem without creating new publishers. Otherwise we should request several more publishers with handle before VerifyChange calls.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


IllegalArgumentException: Suggested resolution map missing resolution for camera 1

Before initialization
setLensFacing(CameraX.LensFacing.FRONT)
IllegalArgumentException: Suggested resolution map missing resolution for camera 1
setLensFacing(CameraX.LensFacing.BACK)
OK

Hi @Reginer can you please provide a few more details here? Is this an issue you are running into with the sample, or are you modifying the sample in order to trigger this issue?

This File
line 270   setLensFacing(CameraX.LensFacing.FRONT)

Sorry, I'm still unable to reproduce the issue. What device are you seeing this in?

Maybe because it's an MTK system.
It workd on Huawei phones.

It sounds like a device specific issue. Can you please file a bug at https://issuetracker.google.com/components/618491 and provide the specific device and model you are using?

sorry,Demo not worked in Huawei device。
This is my code:

Error is:
Caused by: java.lang.IllegalArgumentException: Suggested resolution map missing resolution for camera 1
        at androidx.camera.core.Preview.onSuggestedResolutionUpdated(Preview.java:433)
        at androidx.camera.core.UseCase.updateSuggestedResolution(UseCase.java:380)
        at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:503)
        at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:188)

I'm facing the same issue too. Works perfectly fine when I set "setLensFacing(CameraX.LensFacing.BACK)". Issue only occurs when "setLensFacing(CameraX.LensFacing.FRONT)", i think it is beacause it is unable to perform resolutionMap to CameraId=1 even though CameraManager is able to detect the presence of CameraId=1 (FRONT) through getCameraCharacteristics().

I am testing on my phone which is a Samsung S7, running on Android version 8.0.0 which I believe to be an Android OREO (API 26) version.

Sorry if i have any misconception, from my limited understanding of CameraX, looking into the revolutionary & lifesaving bindToLifecycle() method of CameraX.java class, it takes in and groups the usecases like Preview, imageCapture, imageAnalysis which are pass in as parameters,

under the CameraX.java file, there is an implementation  "for (String cameraId : newCameraIdUseCaseMap.keySet()){....}" which is suppose to get the suggested resolutions and update the use case session configuration as can be seen in its code implementation

& Under the PreviewConfig.java class, which implements interface CameraDeviceConfig, there is a method specified "CameraX.LensFacing getLensFacing" to retrieve the direction of the Lens facing

Hence from my limited amount of understanding, it seems like CameraX is suppose to help me handle passing CameraId=1 and help me perform/handle resolution map by passing CameraId =1 (FRONT )into all the respective usecases so that they are able to detect the target resolution for CameraId =1 (FRONT), and all i have to do is to specify setLensFacing(direction) under the previewConfig which happens to be a usecase for CameraX.bindToLifecycle() method.
I understand that in Camera2 api we would have to handle/match our own Camera Instance as below, but now seems to be managed by the new CameraX api.

My sincere apologies for the long post, I'm an undergraduate student hailing from sunny island of SINGAPORE flying the flag alone where the coding community culture is almost absent(unless you count expensive heavily-incentivized codecamps as one), new to android & currently working on a feature that requires the use of the front-facing camera & I'm stuck at this juncture. I have searched up stack overflow and there has not been any useful solutions, asking questions on stack overflow has personally been a toxic environment for a beginner like me and I have always wish to reach out to someone pro in the community. Sincere appreciation if you read this and reply.
There are tons of Online paid tutorials that just teach basic functions and are painfully outdated as compared to the face pace of change push out by Google. Sometimes i feel like i just mastered a new feature and then a new update comes along, previous things become deprecated, no longer supported and I become super lost in exasperation, having no idea where to start from, the online documentation is not updated and people are unable to provide any solutions since these features are so new, alpha, beta or newly realeased RC, and I have to go through the pain of binge watching the google I/O videos just to find out what's new, what's updated, find out if there are any googe codelabs tutorial examples(which sometimes dont even work. Gawd...... one hell of an experience from me).  Sometimes I just wish i have contacts in google so that I can be one call away from them. It seems like they only provide support for corporates who are working along side them to test any new features and report bugs back, but the rest of us is just drowning in the deep ocean.  Sincerely apologize for the long post.

@MingLeo I highly encourage you to join our developer forums, you can rant all you want there 🙂
Regarding your specific issue, can you please confirm it is happening with alpha04? There are some changes happening around the internal logic that picks a resolution (related to this), but that probably won't be released until alpha05.

We just upgraded the sample to use alpha05. Feel free to reopen if this issue is still reproducible.


pkg/bisect: nonsensical fixed bisections should be removed and the fix bisection retried

Describe the bug
(I'm not sure this is the fault of pkg/bisect, or whatever element of syzkaller actually manages when bisections are run and manages the storage of a bisection result
Consider the syzbot report[1]  INFO: task hung in do_truncate (2), but time has shown that the identified commit "fix" is clearly not correct.   It identified a commit from 2020 as the fix, probably because it got sent down the primrose path by an unrelated flaky error with a radically different error signature.  From [2], the crash signatures reflective of the bug are "crashed: INFO: task hung in {pipe_read,pipe_write,vfs_unlink}".    However, in a warning in the network layer "crashed: WARNING: ODEBUG bug in netdev_run_todo" caused the bisector to assume that a particular commit had the bug it was trying to bisect, when in fact, that unrelated error should have been ignored.   Fixing this is hard, since it requires a certain amount of human intelligence that I doubt BARD or GPT-3 could handle today (although some kind of statistical approach where an outlier crash signature should be ignored and not counted towards one of the ten runs might be doable).   But that's not what I'm complaining about here.
[1] https://syzkaller.appspot.com/bug?id=d38f8eae55e27aaef60b4748bc77ecb712dba4b9
[2] https://syzkaller.appspot.com/text?tag=Log&x=111aa0cf500000
The higher order problem is that the invalid fix commit dates from December 2020.    However, the syzbot error is still reproducing in 2021, 2022, and 2023.   So clearly the fix commit is wrong, and the syzkaller system should remove the obviously incorrect fix commit and retry the fix bisection.   Failing that, at the very least, there should be a way for the human to trigger a retry of a fix bisection.

syzbot currently only starts a fix bisection if there haven't been any crashes during the last 24 days. So here it goes about a situation when
a) The bug stopped appearing.
b) We have found some fix bisection result.
c) The bug is triggered again (so apparently it's just a rarely hit issue).
We could indeed look for the situation when the commit pointed to by the bisection reaches all syz-managers (*), but the crashes still keep on coming. Then mark the bisection result as invalid and redo it when new crashes disappear again.
A few UX questions
a) Should we send an email notification to the thread that the bisection result is automatically invalided? Also to LKML?
b) Should we report new fix bisection results over email? Won't it happen that for some particularly nasty bugs we'll keep on revoking and redoing incorrect fix bisections all the time?
(*) There can be a window before all syzbot instances get rebuilt to a kernel revision that's fresh enough.

One more caveat is that we need to consider not the individual commit date, but the date when the commit actually reached the HEAD of the bisected tree via merge or a chain of merges. This can be much later.

For the record.
After https://github.com/google/syzkaller/pull/4123, there should be no fix bisections that point to the commits older than the original kernel commit.


Add feature description for View

Codecov Report

Merging #16 (d75d0aa) into ug (660b15c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                 ug      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660b15c...d75d0aa. Read the comment docs.


Add repr method to Field classes

This fixes #19 by adding repr methods to the Field classes. Just let me know if you'd like to see any further changes.

I closed and re-opened this to get the Travis CI checks to run again (not sure if there's a better way).
When I initially submitted the pull request there was an issue with mock and Python 2.6 (it used a set comprehension, causing a SyntaxError). Since then the issue has been fixed in mock: Support python 2.6 .


log-api under load fills up memory and start swapping

We have a test system with 1000 deployed applications. Each application is bound to its own syslog drain service.
Starting with 2 log-api VMs (2 cpu, 4gb ram) we gradually increased the number of logs sent by the test applications.
To handle more load, we scaled the adapters up to 12 instances before starting to experience issue on log-api VMs.
Approaching the maximum load of log-api we saw an increase of memory usage up to 100% and the VM started to swap.
The expected behaviour would be to handle the load by dropping logs before starting to swap.
Doppler are 2 VMs 2cpu, 4gb ram each.
This was tested on loggregator-release v99 (the one used for etcd-removal migration) and the 101.4 (the one in cf-deployment 1.9.0)

@tyyko I suspect the ReverseLogProxy (which is what the adapters read from on the log-api) are handling too many connections. Given your numbers (and an estimate of 256 bytes per envelope) I come up with the following:

2000 connections (Adapters make 2 connections per drain)
10000 envelopes buffered per connection (channel size is 10000)
256 bytes per envelope

2000 * 10000 * 256 =><PHONE_NUMBER>B
5120000000B/1024.0/1024.0/1024.0 => 4.768GB

The RLP has a max connection count of 2000, but that is too much for your VM specs.

This means that this problem should go away when I double the memory size of the VM, right? I'll do in our test bed right now...

You can either scale vertically (bump up VM size) or horizontally (add more instances of log-api).

When I scale horizontally the VM can always go into swapping, because the connection limit is 2000 connections, or am I mistaken?

If you scale up, the 2000 should get spread across more VMs.

That will only help until the number of applications increases and it causes the rlp to crash again. This means that there is a minimum memory requirement for the rlp and that one cannot run it on a VM with less memory. And you calculated that minimum memory requirement above to be at least 5 GiB.

Agreed. The Loggregator system has the expectation that proper capacity planning has been considered.

My expectation is that improper capacity planning leads to dropped messages, not the stack crashing.
Also proper capacity planning requires proper documentation.

@holgero we performed capacity tests and documented these results in the Operator Guidebook which is available on our README.md. In the test we use a c3.large vm types on GCP and didn't encounter any memory pressure. We have pipelines available if you'd like to repeat the tests with different vertical scaling.
Granted we started with large vm sizes and stressed them from a CPU and network perspective. We are going to put in logic here and for adapters and RLPs to refuse connections (in turn dropping messages) rather than swap as you are experience. We have encountered several operators under sizing or sharing critical resources recently and can probably make our recommendations easy to find.

@ahevenor Thank you for the pointer to the guidebook. The capacity tests described there seem to focus a bit on the doppler and on the comparison between UDP and gRPC. Also they test only the capacity of the syslog stream capability via traffic-controller and nozzles, not the syslog drain (via reverse log proxy and adapter).
The section about syslog drain reliability measurement seems to be theoretical, or at least I didn't find the results of that part. Or am I missing something completely here?

@holgero Apologies for the slow response and lack of detail in the report. I had to dig out my notebooks to better recall what testing I had done. To your point, we did not publish these results. At the time the cf-syslog-drain release was not yet GA, because cf-deployment was not yet GA so I decided not to include the results which focused on reliability mostly not scaling of the adapter. I did not stress adapters beyond 500 drains per adapter which would have (eventually) lead to us seeing the swapping behavior.
We have since implemented a max_drain_bindings limit with a default of 500 so that you can prevent adapters from reaching this limit. I expect we'll cut a release of it this week.

@ahevenor Thank you for coming back to us and for implementing the fix. We are eager to try out the new version as soon as it has been released.


502 Bad Gateway accesing from localhost

Info:

Docker version ($ docker --version): 19.03.5-ce, 633a0ea838
Laradock commit ($ git rev-parse HEAD): v9.2 d732318e5286f6e06beb5d1c958a9ecaee4fe1b5
System info (Mac, PC, Linux): Linux
System info disto/version: Arch Linux, kernel 5.4.2

Issue:

I'm trying to run laradock on local machine for development purposes. I'm using Caddy and Mysql and getting 502 or hang indefinitely when trying to access from the browser to <IP_ADDRESS>. I also have tried with nginx but getting the same error. The strange thing is that exposed HTTP service is accessible outside localhost from other machines in the network, and my Laravel app is running fine from there.
Previous versions also didn't work (8.0 or 8.1)

Expected behavior:

Access to the http server with <IP_ADDRESS> address on the browser.

Reproduce:

Relevant Code:
<IP_ADDRESS>:80 {
    root /var/www/public
    fastcgi / php-fpm:9000 php {
        index index.php
    }

    rewrite {
        to {path} {path}/ /index.php?{query}
    }
    gzip
    browse
    log /var/log/caddy/access.log
    errors /var/log/caddy/error.log
    tls off
}

           Name                          Command               State                         Ports
-------------------------------------------------------------------------------------------------------------------------
laradock_caddy_1              /bin/parent caddy --conf / ...   Up      2015/tcp, <IP_ADDRESS>:443->443/tcp, <IP_ADDRESS>:80->80/tcp
laradock_docker-in-docker_1   dockerd-entrypoint.sh            Up      2375/tcp, 2376/tcp
laradock_mysql_1              docker-entrypoint.sh mysqld      Up      <IP_ADDRESS>:3306->3306/tcp, 33060/tcp
laradock_php-fpm_1            docker-php-entrypoint php-fpm    Up      9000/tcp
laradock_workspace_1          /sbin/my_init                    Up      <IP_ADDRESS>:2222->22/tcp

@ZJaume  Please add the solution. I'm also having a similar issue.

It wasn't a docker issue itself, it was my VPN program that was messsing up iptables. Disabling the VPN solved the problem.

Thanks, @ZJaume. I'm having a problem without a VPN too.


Fix bug 3303

Fixes #3303 .

Pull Request Test Coverage Report for Build 685

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 67.861%

Totals

Change from base Build 484:
0.002%

Covered Lines:
11305

Relevant Lines:
16659

💛  - Coveralls


Notebook tests

Added tests for running the notebooks, lets see how long they run on travis.

Runs fine on my laptop. Timings:
/home/icouckuy/projecten/GPflowOpt/testing/../doc/source/notebooks/new_acquisition.ipynb took 118.921 seconds.
/home/icouckuy/projecten/GPflowOpt/testing/../doc/source/notebooks/hyperopt.ipynb took 383.309 seconds.
/home/icouckuy/projecten/GPflowOpt/testing/../doc/source/notebooks/constrained_bo.ipynb took 232.984 seconds.
/home/icouckuy/projecten/GPflowOpt/testing/../doc/source/notebooks/structure.ipynb took 62.8342 seconds.
With the upcoming notebooks I guess it is possible to exceed the timeout of Travis?

The reason this fails on travis is because I do not install texlive, and so it fails on generating TeX labels. Installing texlive each build will be a bit time consuming so we'd have to get rid of those labels

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files          14       14
  Lines         757      757
=======================================
  Hits          755      755
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1273304...64f4976. Read the comment docs.

Not to be merged until I either remove the hyperopt notebook or get it stable

I fixed a bug in the structure notebook. Two notebooks are not reliable atm:

hyperopt: doesnt find always an optimum for the sm kernel I think.

Could using MCMCAcquisition help here?

firststeps: model training fails for 5 restarts in a row.

The mystery bug is still there, I can't reproduce it locally


Both downgrade compatibility and refacto Engine

I used @raul-gracia 's commit as a base so the dependency on Phoenix is on '1.2' version
I made a small refactoring on the engine. Using -s option on mjml allow to use stdout and skip the file reading part.
I benchmarked your implementation on a small template and both seems to have similar performances but I think this way the code gain in readability.
What do you think of it ?

I would much appreciate such change.

@Hajto, @emendelski I totally forgot to release it. Just do it now


setCvpVestingPool

Codecov Report

Merging #151 (ae011bd) into master (4f390a9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   89.69%   89.77%   +0.07%
==========================================
  Files          64       64
  Lines        4232     4234       +2
  Branches      639      638       -1
==========================================
+ Hits         3796     3801       +5
+ Misses        436      433       -3

Impacted Files
Coverage Δ

contracts/powerindex-mining/VestedLPMining.sol
94.47% <100.00%> (+0.03%)
:arrow_up:

contracts/PowerIndexPoolController.sol
76.71% <0.00%> (-1.37%)
:arrow_down:

contracts/balancer-core/BPool.sol
99.46% <0.00%> (+<0.01%)
:arrow_up:

contracts/bactions-proxy/BActions.sol
52.94% <0.00%> (+2.23%)
:arrow_up:

contracts/PowerIndexPoolActions.sol
93.75% <0.00%> (+5.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f390a9...ae011bd. Read the comment docs.


[WIP]user accounts

Fixes # none
Proposed Changes

Add a user resource
Add authentication around the user resouce

Aim
To build a little system for users to authenticate into and out of the applicaition

Add tests for redirection when user is authenticating using a provider #32


Trailing stop loss on spot trade?

Forgive me if I'm wrong here. I'm seeing a few issues mentioning the sell order not executing. Could this be because you are setting a trailing stop-loss order on a spot trade?
Natively Binance only allows for TSL on futures. On spot trades, you can set limit or stop-loss orders but not of the trailing type.
Also just confirming that the json files are created when the script finds a new coin and executes. I don't see the json files but do see the references within the executed functions.
Where did the frequency function go? Looks like we have no control of the API call frequency anymore.
Thanks

The trailing stop loss is calculated locally, so instead of asking Binance to do it, we handle it locally and just send a sell request once the parameters match. The sell order issue is related to the format of the trades.json which needs fixing. Currently working fine in test mode.


bottles: Steam runtime error

Describe the bug

Running a Proton bottle with Steam runtime enabled does not work.
Steps To Reproduce
Steps to reproduce the behavior:

Launch bottles
Create a bottle, change it to a Proton runner like Proton-GE
Enable Steam Runtime if unchecked
Launch an executable and see error in terminal
Uncheck Steam Runtime, runs as expected.

Expected behavior

The bottle runs with the Steam runtime
Screenshots

21:05:15 (INFO) Launching an executable…
21:05:15 (INFO) Using Steam runtime scout

steam-runtime-identify-library-abi: Failed to execute child process ?/sbin/ldconfig? (No such file or directory)
run.sh[492435]: steam-runtime-identify-library-abi --ldconfig-paths failed, falling back to ldconfig
run.sh[492435]: Warning: An unexpected error occurred while executing "/sbin/ldconfig -XNv", the exit status was 127
env: /home/keenan/.local/share/Steam/ubuntu12_32/steam-runtime/lib/x86_64-linux-gnu/libattr.so.1: version `ATTR_1.3' not found (required by env)
21:05:35 (INFO) Setting Key use_steam_runtime=False for bottle test…

Additional context

This may have been an issue before the latest Bottles package update, but I only just moved to the native Bottles package after being a Flatpak version user. I didn't notice this issue when reviewing the latest package update. My Steam config is here. The Steam Runtime (Scout) package is installed in Steam.
Metadata

system: "x86_64-linux"
host os: Linux 6.12.1, NixOS, 25.05 (Warbler), 25.05.20241125.4633a7c
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.10
nixpkgs: /nix/store/frfyxcpzsdasdin76x83krbhpgkis8b0-source

Notify maintainers
@Gliczy

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

I cannot repro.
I see in your config that you are using an overlay for bottles, could you try the nixpkgs version instead?

Thanks for checking! Removing the overlay didn't change anything. Some steps I've done are disabling Steam beta, removing ~/.local/share/Steam & resetting up Steam, and removing the extraLibraries I put in for steam-run compatibility. The odd thing is games on Heroic run fine with my current setup with the Steam Runtime, it's only Bottles experiencing the problem. I'll be troubleshooting further to see what it is, but no leads so far.


Added 2d parameter to find_closest_area func.

In response to this issue: https://github.com/pnxenopoulos/awpy/issues/200

Looks good to me. It would be awesome if you could also add some test coverage for the new option.

This PR should also be ready now.


Creating the signup and login Model for the editor

As discussed in issue #21:
Creating a signup/login model with the following features-

Google Authentication using Firebase
A Database where users can store their media files.

Sure @PrerakMathur20


Introduce .ci/make.sh

Initial stab at common entry script for all the Elasticsearch clients.
This puts our build through a docker container so that folks & CI do not need
to install dependencies on their machines to build artifacts.

./.ci/make.sh release VERSION

will output our packages, release notes, API reports in .ci/output.
This also updates our build to use: https://github.com/nullean/nupkg-validator
This is the tool version of our build script targets that

validate the dlls are build in release mode
validate the dll version numbers
validate the dll assemly identity
validate the dll assembly names.

With the added benefit that the dependency on sn is gone which is not
available on the dotnet base docker images that we use.
.ci/make.sh is not done yet, will iterate on this as the flow in the
unified release manager becomes more apparant. For example right now we
bump the version after release but we might need to do so prior.

We could look to change this though, to lookup the previously released version, similar to what previous-nuget command does in assembly-differ.

++ I am looking to move to minver so we can eschew the change to global json atleast. This requires it s own PR though since it'll touch several things in our automation as you highlighted

If this is used later for official releases, I think the release build need to commit changes to global.json and auto-label.json back to the repository

Aye I am looking to make the act of tagging/committing and publishing to package managers its own target though release > publish.


add owners and approvers for ci

Signed-off-by: Neha Lohia<EMAIL_ADDRESS>

/lgtm

/lgtm
/approve


How can we use this

How can we use  this sdk to establish the connection with softether server......I managed it somehow but how we create users and give them the limited access for particular time period

I dont really understand your / \ explanation.
I added support for create user with expire time, everything else should be only a problem of setting the correct type in the request
For example SoftEtherValueType::Raw is required for a byte array
'HashedKey' => ['type' => SoftEtherValueType::Raw, 'value' => [$hashPair->Hash]],


Implement tools/documents for new sprint process

User story
As an MDN team member, I want to have tools in place to track sprints when we start the new sprint process and cadence, so the transition goes smoothly, without losing information.
Acceptance criteria

[ ] Documents and/or tools corresponding to the current ones exist for both the Dev team and the Content team.

These include:

[x] OKR spreadsheet
[x] Planning scratchpad
[x] User story spreadsheet
[x] Availability spreadsheet
[x] Retrospectives (Trello board)

Tasks

[x] Talk to Kadir, Chris and Tobin about needs for these items.

[x] Draft new documents.

[x] Share for and incorporate feedback.

[x] Share to team for going forward.

OKR spreadsheet
Content planning scratchpad
Dev planning scratchpad
User story spreadsheet
Availability spreadsheet
Content retrospectives
Dev retrospectives
Joint retrospectives (same as old retro board)


[HOLD][Accessible Pressables] Migrate multi-purpose components to use Accessible Pressables

HOLD on https://github.com/Expensify/App/issues/16988
Description
List of components to migrate for this issue:

done?
Component
New component to use

 - [ ]
ReportActionItemCreated
PressableWithoutFeedback

 - [ ]
ClickAwayHandler
PressableWithoutFeedback

 - [ ]
PressableWithoutFocus
GenericPressable

 - [ ]
PressableWithSecondaryInteraction
GenericPressable

 - [ ]
OffineWithFeedback
PressableWithFeedback

 - [ ]
RadioButton
PresssableWithFeedback

 - [ ]
Button
PressableWithFeedback

 - [ ]
Checkbox
PressableWithFeedback

 - [ ]
BaseMiniContextMenuItem
PressableWithFeedback

 - [ ]
MenuItem
PressableWithFeedback

Triggered auto assignment to @maddylewis (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

cc @RobertKozik


Error: IncompleteSignature regression in v0.74.1

Not present in v0.73.0
https://discourse.gohugo.io/t/error-incompletesignature/27025/2 has the details

@kaihendry Can we close this issue? I checked the last run and saw no errors:
https://github.com/kaihendry/dabase.com/runs/2644962610?check_suite_focus=true#step:4:26


Facing issue when install this library : "python3.9 -m pip install --ignore-installed PyYAML --pre --upgrade bigdl-chronos[pytorch]==2.4.0"

We are trying to install this library.

python3.9 -m pip install --ignore-installed PyYAML --pre --upgrade bigdl-chronos[pytorch]==2.4.0
but seeing issue above when install this library.
It is working previously.
We are using bigdlspark==2.4.0 version. Without above library, will causing this error:
ImportError: cannot import name 'TCNForecaster' from 'bigdl.chronos.forecaster' (/usr/local/lib/python3.9/dist-packages/bigdl/chronos/forecaster/init.py)
Is this library no longer exist?

I could not reproduce this installation error when I directly run python3.9 -m pip install --ignore-installed PyYAML --pre --upgrade bigdl-chronos[pytorch]==2.4.0. But this error seems to be caused by numpy version. You could try python3.9 -m pip install --ignore-installed PyYAML bigdl-chronos[pytorch]==2.4.0 instead.

Hi,
Thanks for it.
it works with python3.9 -m pip install --ignore-installed PyYAML bigdl-chronos[pytorch]==2.4.0.


CSP: 'unsafe-inline' is required when using bind:clientWidth

Describe the bug
When using bind:clientWidth (amongst others), an iframe is generated to keep track of it's parents sizing:
<iframe style="display: block; position: absolute; top: 0; left: 0; width: 100%; height: 100%; overflow: hidden; border: 0; opacity: 0; pointer-events: none; z-index: -1;" aria-hidden="true" tabindex="-1" src="about:blank"></iframe>

the style attribute appended to this element makes it tricky to keep CSP's strict, to a point where 'unsafe-inline' is required
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-zemjvc
Logs
Refused to apply inline style because it violates the following Content Security Policy directive: "style-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-lJ7/G2Js+ZVE8z76tKAxfzSKR8TjT9mYsP+sBJmuNtI='), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present.

System Info
System:
    OS: macOS 14.1
    CPU: (8) arm64 Apple M2
    Memory: 66.72 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
  Browsers:
    Chrome: 118.0.5993.96
    Chrome Canary: 120.0.6090.0
    Edge: 118.0.2088.69
    Firefox Nightly: 120.0a1
    Safari: 17.1
    Safari Technology Preview: 17.4
  npmPackages:
    @sveltejs/adapter-vercel: ^3.0.3 => 3.0.3
    @sveltejs/kit: ^1.27.1 => 1.27.1
    svelte: ^4.2.2 => 4.2.2
    vite: ^4.5.0 => 4.5.0

Severity
serious, but I can work around it
Additional Information
No response

probably duplicate #8607

Closing as duplicate of https://github.com/sveltejs/svelte/issues/8607


Expose Unreal.h functions to python client

Looks great. I'd like to have one more look before approving. See comments above.


implement debug interface such as store_info, cluster_info,dump_kv

What is changed and how it works?

Issue Number: ref #14654
What's Changed:

debugger v2 impl `store_info`, `cluster_info`,`dump_kv`

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test

Side effects
Release note
debugger v2 impl `store_info`, `cluster_info`,`dump_kv`

/merge


[Admin] Publish

Docs Build status updates of commit f04f81d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/sideload-office-add-ins-for-testing.md
:bulb:Suggestion
View
Details

docs/design/add-in-icons-monoline.md
:white_check_mark:Succeeded
View

docs/design/authentication-patterns.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/keyboard-shortcuts.md
:white_check_mark:Succeeded
View

docs/design/office-ui-fabric.md
:white_check_mark:Succeeded
View

docs/design/using-office-ui-fabric-react.md
:white_check_mark:Succeeded
View

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/authorize-to-microsoft-graph.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/develop-overview.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/office-versions-and-requirement-sets.md
:white_check_mark:Succeeded
View

docs/develop/overview-authn-authz.md
:white_check_mark:Succeeded
View

docs/develop/sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/excel/pnp-open-in-excel.md
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/outlook/add-in-requirements.md
:white_check_mark:Succeeded
View

docs/outlook/append-on-send.md
:white_check_mark:Succeeded
View

docs/outlook/authentication.md
:white_check_mark:Succeeded
View

docs/outlook/autolaunch.md
:white_check_mark:Succeeded
View

docs/outlook/compare-outlook-add-in-support-in-outlook-for-mac.md
:white_check_mark:Succeeded
View

docs/outlook/compose-scenario.md
:white_check_mark:Succeeded
View

docs/outlook/delegate-access.md
:white_check_mark:Succeeded
View

docs/outlook/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded
View

docs/outlook/sideload-outlook-add-ins-for-testing.md
:white_check_mark:Succeeded
View

docs/overview/learning-path-beginner.md
:white_check_mark:Succeeded
View

docs/overview/learning-path-transition.md
:white_check_mark:Succeeded
View

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded
View

docs/overview/set-up-your-dev-environment.md
:white_check_mark:Succeeded
View

docs/publish/centralized-deployment.md
:white_check_mark:Succeeded
View

docs/publish/publish-task-pane-and-content-add-ins-to-an-add-in-catalog.md
:white_check_mark:Succeeded
View

docs/quickstarts/outlook-quickstart.md
:white_check_mark:Succeeded
View

docs/quickstarts/sso-quickstart-customize.md
:white_check_mark:Succeeded
View

docs/reference/javascript-api-for-office.md
:white_check_mark:Succeeded
View

docs/reference/manifest/webapplicationinfo.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/open-browser-window-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/outlook-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/testing/create-a-network-shared-folder-catalog-for-task-pane-and-content-add-ins.md
:white_check_mark:Succeeded
View

docs/testing/debug-desktop-using-edge-chromium.md
:white_check_mark:Succeeded
View

docs/testing/debug-office-add-ins-on-ipad-and-mac.md
:white_check_mark:Succeeded
View

docs/testing/debug-with-vs-extension.md
:white_check_mark:Succeeded
View

docs/testing/sideload-an-office-add-in-on-ipad-and-mac.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/migrate-vsto-to-office-add-in-shared-code-library-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/outlook-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/powerpoint-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/word-tutorial.md
:white_check_mark:Succeeded
View

docs/testing/sideload-office-add-ins-for-testing.md

Line 37, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3426ba2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/add-in-icons-monoline.md
:white_check_mark:Succeeded
View

docs/design/authentication-patterns.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/keyboard-shortcuts.md
:white_check_mark:Succeeded
View

docs/design/office-ui-fabric.md
:white_check_mark:Succeeded
View

docs/design/using-office-ui-fabric-react.md
:white_check_mark:Succeeded
View

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/authorize-to-microsoft-graph.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/develop-overview.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/office-versions-and-requirement-sets.md
:white_check_mark:Succeeded
View

docs/develop/overview-authn-authz.md
:white_check_mark:Succeeded
View

docs/develop/sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/excel/pnp-open-in-excel.md
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/outlook/add-in-requirements.md
:white_check_mark:Succeeded
View

docs/outlook/append-on-send.md
:white_check_mark:Succeeded
View

docs/outlook/authentication.md
:white_check_mark:Succeeded
View

docs/outlook/autolaunch.md
:white_check_mark:Succeeded
View

docs/outlook/compare-outlook-add-in-support-in-outlook-for-mac.md
:white_check_mark:Succeeded
View

docs/outlook/compose-scenario.md
:white_check_mark:Succeeded
View

docs/outlook/delegate-access.md
:white_check_mark:Succeeded
View

docs/outlook/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded
View

docs/outlook/sideload-outlook-add-ins-for-testing.md
:white_check_mark:Succeeded
View

docs/overview/learning-path-beginner.md
:white_check_mark:Succeeded
View

docs/overview/learning-path-transition.md
:white_check_mark:Succeeded
View

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded
View

docs/overview/set-up-your-dev-environment.md
:white_check_mark:Succeeded
View

docs/publish/centralized-deployment.md
:white_check_mark:Succeeded
View

docs/publish/publish-task-pane-and-content-add-ins-to-an-add-in-catalog.md
:white_check_mark:Succeeded
View

docs/quickstarts/outlook-quickstart.md
:white_check_mark:Succeeded
View

docs/quickstarts/sso-quickstart-customize.md
:white_check_mark:Succeeded
View

docs/reference/javascript-api-for-office.md
:white_check_mark:Succeeded
View

docs/reference/manifest/webapplicationinfo.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/open-browser-window-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/outlook-api-requirement-sets.md
:white_check_mark:Succeeded
View

docs/testing/create-a-network-shared-folder-catalog-for-task-pane-and-content-add-ins.md
:white_check_mark:Succeeded
View

docs/testing/debug-desktop-using-edge-chromium.md
:white_check_mark:Succeeded
View

docs/testing/debug-office-add-ins-on-ipad-and-mac.md
:white_check_mark:Succeeded
View

docs/testing/debug-with-vs-extension.md
:white_check_mark:Succeeded
View

docs/testing/sideload-an-office-add-in-on-ipad-and-mac.md
:white_check_mark:Succeeded
View

docs/testing/sideload-office-add-ins-for-testing.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/migrate-vsto-to-office-add-in-shared-code-library-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/outlook-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/powerpoint-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/word-tutorial.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Optionally skip serializable types from obfuscation

I'm obfuscating a project with a large number of types marked with the Serializable attribute that need to be skipped from obfuscation. Some of them are generated, and I don't have control of the generator to alter the attributes. For these cases, having an option to skip the serializable types seems desirable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@lextm - I think the best I could do is alter the generators to output to a different namespace and add rules accordingly, but this would then require a significant number of source changes. Even if that's sufficient for the my particular case, it might not be enough for more general cases (e.g. where only part of the generator output is serializable). For those, having this as configurable is both simpler, and increase the amount of obfuscated code. I believe that other obfuscators allow this kind of function (and this behavior might even be the default).

Looking back at this, I can spot that I intended to add a check for non-serialized properties but left it unfinished. I can fix that up if you're considering merging this, but I'll wait for any additional comments first :)


needs.json generation

The needs.json file should be generated everytime for each target.
Abd it should be part of the build folder/artifacts.
Therefore an extra generation step is not necessary.

Suggestion: I think it shouldn't be generated to build folder/artifacts, because this is a versioned file, and that folder is gitignored. I think it should go to just docs (and maybe manually copied to somewhere else if desired).

I came to the conclusion that the needs-builder should act like all other sphinx builders in the sphinx environment.
Therefore the needs.json gets now generated inside "_builds/needs/"
With 0.1.33 I will remove all configs, which specifies export path or export file name.
If this file needs some versioning or renaming, the user must copy it by himself to another location.


Flight delay prediction

fixes #22
I have added the drive link for the dataset as the file is more than 25mb and could not be uploaded on git

@Komal-99 there is no readme.md file for this project , add readme.md file and attach the link of dataset into it,
in .pynb file add comments or markdowns,

@Komal-99 there is no readme.md file for this project , add readme.md file and attach the link of dataset into it,
in .pynb file add comments or markdowns,

kindly check!!

Thanks for approving, please  add LGMSOC'21 label and difficulty level  lab

@Komal-99 watch a video on youtube ,how to make readme.md file, or improve your readme.md file ,

@Komal-99 watch a video on youtube ,how to make readme.md file, or improve your readme.md file ,

ok

@Komal-99 watch a video on youtube ,how to make readme.md file, or improve your readme.md file ,

Kindly check new commit


How to open reports container in focus mode on load?

I am opening reports list using PowerBIEmbed component.  The issue is that the report is taking only half of the iframe width.
I can make it go full screen by using focus button. But the thing is i want it to be opened in full screen as soon as it loads.
My component is as follows:
<PowerBIEmbed
embedConfig={{
type: "report", // Supported types: report, dashboard, tile, visual, qna, paginated report and create
id: id,
embedUrl: embedUrl,
accessToken: reportToken,
tokenType: models.TokenType.Embed, // Use models.TokenType.Aad for SaaS embed
//pageView: "oneColumn",
// filters: [
//   {
//     $schema: "http://powerbi.com/product/schema#basic",
//     target: {
//       table:
//         "scai_dpai_06b10774_2c7a_4b17_b810_d62c7a943d98 app_case",
//       column: "status",
//     },
//     operator: "IN",
//     values: ["NEW"],
//     filterType: models.FilterType.BasicFilter,
//     requireSingleSelection: true,
//   },
// ],
settings: {
panes: {
filters: {
expanded: false,
visible: false,
},
},
navContentPaneEnabled: false,
background: models.BackgroundType.Transparent,
layoutType: models.LayoutType.Custom,
customLayout: {
displayOption: models.DisplayOption.FitToWidth,
},
},
}}
eventHandlers={
new Map([
["loaded", Function.prototype],
["rendered", Function.prototype],
[
"error",
function (event) {
console.log(event.detail);
},
],
["visualClicked", Function.prototype],
["pageChanged", Function.prototype],
])
}
cssClassName={"bi-embedded"}
getEmbeddedComponent={(embeddedReport) => {
window.report = embeddedReport; // save report in window object
}}
/>

To open the report in full screen mode as soon as it loads, call the report.fullscreen() inside the loaded event Handler.
Refer to below snapshot how to load the report in fullscreen in the demo application.
    useEffect(() => {
        if (report) {
            report.setComponentTitle('Embedded Report');
            report.fullscreen()
        }
    }, [report]);

Reference: Launch Embed Component in Fullscreen mode


Backport "Also compute base classes of wildcardTypes" to LTS

Backports #19465 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-19520.
Reference


pkg/rules: consider group name and file for deduplication

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Fixes #3017
Changes
Currently only the group name is considered for group deduplication.
However prometheus uses also the group file according to [1].
This fixes it.
[1] https://github.com/prometheus/prometheus/blob/ce838ad6fcbd14b0cf9971a4d093ad672e1469fe/rules/manager.go#L1047-L1055
Verification
Tests have been modified

cc @simonpasquier @bwplotka @GiedriusS @lilic @yeya24 :)

I am not sure why this fails :thinking:
make: *** [Makefile:208: test] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded

ha, somebody was faster, let me rebase on the newest changelog ;-)


[BUG] Infinite Hang During Initial Evaluation Loop Using LLAVA with DeepSpeed

I am encountering an infinite hang during the initial evaluation loop while training a custom LLAVA model using HuggingFace’s Trainer class. This happens only when inserting my own compute_metrics function to the  custom trainer class, as outlined below. Notably, the same configuration works, but extremely slowly, if I use the alternative super call (commented in the code).
Steps to Reproduce (High-Level Code)
class LLaVATrainer(Trainer):
    def __init__(self, model, tokenizer, args, **kwargs):
        super().__init__(model=model, tokenizer=tokenizer, args=args,
                          compute_metrics=self.compute_metrics,
                          preprocess_logits_for_metrics=self.preprocess_logits_for_metrics, **kwargs)
        # Alternative version below works fine (no hang, but slow):
        # super().__init__(model=model, tokenizer=tokenizer, args=args, **kwargs)
        self.tokenizer = tokenizer
        self.global_results = defaultdict(list)  # Used to accumulate batch-level scores

trainer = LLaVATrainer(model, tokenizer, training_args)
trainer.evaluate()

Logs (Last Few NCCL Calls)
rack-gamir-v100: NCCL CALL ncclGroupStart()
rack-gamir-v100: NCCL INFO AllGather: opCount f85 sendbuff 0x7f5604000000 recvbuff 0x7f5604000000 count 33590016 datatype 0
rack-gamir-v100: NCCL CALL ncclGroupEnd()

ds_report

[2024-10-28 15:06:30,938] [INFO] [real_accelerator.py:161:get_accelerator] Setting ds_accelerator to cuda (auto detect)
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
async_io ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_lion ............... [NO] ....... [OKAY]
 [WARNING]  Please specify the CUTLASS repo directory as environment variable $CUTLASS_PATH
evoformer_attn ......... [NO] ....... [NO]
fused_lamb ............. [NO] ....... [OKAY]
fused_lion ............. [NO] ....... [OKAY]
inference_core_ops ..... [NO] ....... [OKAY]
cutlass_ops ............ [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
ragged_device_ops ...... [NO] ....... [OKAY]
ragged_ops ............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires a torch version >= 1.5 and < 2.0 but detected 2.1
 [WARNING]  using untested triton version (2.1.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/home/miniconda3/envs/llava/lib/python3.10/site-packages/torch']
torch version .................... 2.1.2+cu121
deepspeed install path ........... ['/home/miniconda3/envs/llava/lib/python3.10/site-packages/deepspeed']
deepspeed info ................... 0.12.6, unknown, unknown
torch cuda version ............... 12.1
torch hip version ................ None
nvcc version ..................... 12.2
deepspeed wheel compiled w. ...... torch 2.1, cuda 12.1
shared memory (/dev/shm) size .... 251.65 GB

nvidia-smi
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.116.04   Driver Version: 525.116.04   CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla V100-SXM2...  On   | 00000000:1F:00.0 Off |                    0 |
| N/A   39C    P0    70W / 300W |  31445MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   1  Tesla V100-SXM2...  On   | 00000000:20:00.0 Off |                    0 |
| N/A   39C    P0    66W / 300W |  30179MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   2  Tesla V100-SXM2...  On   | 00000000:65:00.0 Off |                    0 |
| N/A   35C    P0    65W / 300W |  30889MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   3  Tesla V100-SXM2...  On   | 00000000:66:00.0 Off |                    0 |
| N/A   35C    P0    64W / 300W |  31073MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   4  Tesla V100-SXM2...  On   | 00000000:B6:00.0 Off |                    0 |
| N/A   37C    P0    65W / 300W |      3MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   5  Tesla V100-SXM2...  On   | 00000000:B7:00.0 Off |                    0 |
| N/A   35C    P0    65W / 300W |      3MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   6  Tesla V100-SXM2...  On   | 00000000:DF:00.0 Off |                    0 |
| N/A   39C    P0    69W / 300W |      3MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   7  Tesla V100-SXM2...  On   | 00000000:E0:00.0 Off |                    0 |
| N/A   38C    P0    68W / 300W |      3MiB / 32768MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      8731      C   ...envs/llava/bin/python    31442MiB |
|    1   N/A  N/A      8732      C   ...envs/llava/bin/python    30176MiB |
|    2   N/A  N/A      8733      C   ...envs/llava/bin/python    30886MiB |
|    3   N/A  N/A      8734      C   ...envs/llava/bin/python    31070MiB |

commands to
python -m deepspeed.launcher.launch --world_info='{"<IP_ADDRESS>":[0,1,2]}' --master_addr=<IP_ADDRESS> --master_port=4242 --no_local_rank /path/to/llava/train.py --lora_enable True --lora_r 128 --lora_alpha 256 --deepspeed ./scripts/zero3.json --num_train_epochs 1 --gradient_checkpointing True --model_name_or_path liuhaotian/llava-v1.5-13b --output_dir ./checkpoints/llava-v1.5-13b-task-lora --do_eval True
Environment Configuration
NCCL Debug Output: The hanging occurs during ncclGroupStart() and ncclAllGather operations.
Kernel Compatibility: Based on similar issues in the DeepSpeed and NCCL communities, this might relate to GPU communication (e.g., issues with peer-to-peer or collective operations).
Troubleshooting Attempts
Tried NCCL Workarounds:
export NCCL_P2P_DISABLE=1
export NCCL_LL_THRESHOLD=0
These did not resolve the issue.

After further inspection, I discovered that the issue is not directly related to NCCL or DeepSpeed communication. Instead, it has to do with the way I modified trainer.args.label_names. Specifically, I added 'metadata' to label_names to pass a metadata tensor through the collate_fn. This adjustment caused labels to become a tuple of tensors (i.e., (labels, metadata)), which appears to cause an infinite hang when processed by self.gather_function.
I confirmed this behavior with the following minimal reproducible example:
dumm = torch.randint(0, 100, (1, 36)).to('cuda:2')
self.gather_function(((labels, dumm)))

This snippet causes the same infinite hang as in the original issue. It seems the gather_function from the Accelerator class is not designed to handle tuples of tensors, leading to the deadlock.
I’ll need to explore alternatives for passing metadata through the evaluation loop without using label_names to avoid this issue.

Great, thanks for the update!

You saved me! Thank you!


[BUG] Handle unsupported runtimes for platform and fallback to default

Describe the bug
In #1413, we added functionality to store the runtime type (SPARK, SPARK_RAPID, PHOTON) for each application by parsing event logs.
However, users might provide an event log with a runtime type that is unsupported by the specified platform. For example, a user could provide  a photon event log with the --platform onprem, which may not support it.
Current Result
For the above scenario, we would generate the runtime as PHOTON.
Expected Outcome
We should fallback to the default runtime for the given platform i.e. SPARK for onprem.
Proposed Solution
We need to maintain a list of supported runtimes for each platform. If the parsed runtime is unsupported, we should:

Generate a warning about the platform mismatch.
Use the default runtime for that platform as a fallback.

Since the runtime is calculated in the Scala code, decision to fall back to the default runtime should also be made in the Scala code. This will ensure consistent usage by the downstream Python CLI and QualX.

This is more complicated. The tools would actually be wrong if the output reports that a photon eventlog "SPARK". So, I don't agree with that behavior because the field is supposed to be a raw output that should not change by the user's input.
In Scala, the platform argument  was used to decide on which speedFactor file to load.
Since we dropped the speedup-factor, I wonder if we should consider getting rid of the argument and let the tools detect the platfrom based on the eventlog!
The other side of the story is the Python wrapper. We needed the platform argument basically because the python was using the CSP sdk.
We are moving away from that requiremnt by running a local-mode. Even for distributed mode, the runtime of the Tools does not have to reflect the platfrom of the eventlogs.
This means that the platfrom argument will have to be revisited anyway.

That is an interesting point.
Alternative Behaviour:

Instead of silently falling back to SPARK, we report failure for incompatible apps.
Now, one of the cons could be that we spend time processing these apps only to report it as failure.

A couple points...

I am generally in favor of letting the tools detect the platform based on the eventlog, but what about logs in S3?  Are we able to distinguish between EMR and Databricks AWS and even AWS EC2/EKS?
Thinking more of this, I'd rather just fail the job if we are giving PHOTON runtime logs and platform is given as on-prem by the user so we educate the user on the wrong platform.

For the scope of this issue, it seems reasonable to fail the job if the user provides event logs with a runtime that is not supported by the platform.
I agree, we should be educating the user to use correct platform. If the user does not provide one and we default to onprem, the speedups provided by QualX based on the onprem platform will be inaccurate. This issue also exists when using Photon or no-Photon configurations.


Idempotency keys don't work correctly for operations that haven't been submitted

FireFly idempotency keys incorrectly prevent operations from being submitted to the responsible connector after an outage.
In some cases operations won't have been submitted originally (e.g. if FF was killed just after the FF transaction was created) but when an application tries to remake their API call with the same idempotency key FF will reject it. The operations involved may never have been submitted by FireFly and the idempotency key is incorrectly preventing them being submitted.

Hi @matthew1001 - I though it might be easiest to use a picture to express my view of the gap between my inntent in my previous work on introducing idempotency keys, and miss (sorry 🙇 ) in the scenario we've found is the reality with the way FireFly stores idempotency keys before operations are fully submitted to all downstream microservice components:

Note, there is a separate potential stream of work, which I suggest is completely out of scope for this issue, that the community could explore around handling of failures that occur after initial submission - with something akin to a dead-letter-handler for re-submission of operations when:

Connector runtimes are down for longer than can be handled by synchronous retry
Plugin code / connector runtimes do not handle staging of long term retry themselves for cases where down-stream components are unavailable (example is a stateless plugin like IPFS)

We have the low level tools for this already in place - the fact that all operations can be retried, submitting a new copy of that operation. However, there is no automation engine currently implemented in the OSS that deals with many-minute/hours timeframes for that policy-based resubmission (enterprise extensions for this may be available from vendors).

A third point to make here, is that it's very important in any production setup of FireFly, that the exponential back-off retry is enabled on all the cross-microservice components.
This is important to handle transient errors with minimal push-back to the external idempotency APIs to the application, as well as to avoid the cases where errors after the point-of-submission (when the idempotency key is "spent") occur due to short term restart/connectivity issues.
All golang code in the FireFly microservice ecosystem should use the ffresty component (FireFly core plugins, EVMConnect .tc.) and have this configuration consistently per the example of the docs for the Ethereum plugin point here:
https://hyperledger.github.io/firefly/reference/config.html#blockchainethereumethconnectretry
Some microservices deliberately pass such errors through (like tokens) to defer to the retry capabilities on either side.


No possible way to make plugin work on Android SDK levels 21 to 33?

For what I've been reading, the plugin that fixes the Android 13 incompatibility is version 7.0.0-dev, which requires cordova-android@12. I understand that this immediately drops compatibility with Android 5/6.
In order to keep Android 5/6 compatibility, cordova-android@11 must be used, making it impossible to install the fixed plugin version 7.
In short, if the developer needs to upload a version compatible from Android 5 to 13, then 2 apps must be compiled as follows:

APK with android-minSdkVersion 21 and cordova-android@11 + camera plugin version 6
APK with android-minSdkVersion 23 and cordova-android@12 + camera plugin version 7 (dev) non-stable

This approach, while incredibly efficient in meeting Google's obsession of rendering fully functional devices obsolete as fast as possible, is not practical to developers nor users. Is there any other solution?
In short, can someone explain why the plugin cannot be compatible with API level 21 and 33 at the same time? Sometimes, things as trivial as replacing a higher SDK constants like Build.VERSION_CODES.TIRAMISU with just "33" are enough to make apps compatible with lower SDK levels, but I'm not saying this is the case with the camera plugin version 7-dev.
Is it too complex to apply that cordova-android@12 code conditionally by means of simply checking the current SDK level? If the level is not met, then keep using the 6.0.0 functionality, if it's met, then implement all the SDK 33 code required to fix the problem.
PS. please spare me the "SDK 21 level support has been dropped by Google" mumbo-jumbo. Such nonsense is not a valid reason to make this plugin intentionally incompatible.

There's likely nothing in the camera plugin specifically (although wouldn't be tested) that requires API 24+ but the camera plugin requires cordova-android@12 since that's the version that sets the compile SDK to API 33, which is needed to reference the new API 33 permissions.

Is it too complex to apply that cordova-android@12 code conditionally by means of simply checking the current SDK level?

Doing this requires using reflection to access bits needed at compile time, and reflection introduces harder to maintain code, so yes.
cordova-android@12 platform introduces changes that requires API 24. If you have a specific need to support API 21+ devices, then you can likely fork cordova-android@11 and this plugin and make the necessary modifications to target and compile with API 33 (and remove the cordova-android@12 requirement on the camera plugin). Might be necessary to review the commit log to bring in important things for API 33 support for the fork.
I'm closing this issue because I don't foresee any action to be taken by Apache. Should you go with the fork route and have further questions, slack community members (signup) might be able to provide insight.

@andreszs I forked repo and changed cordova-android 12 dependency to 11.
In cordova-android 11 minSdkVersion 21 is allowed and also targetSdkVersion 33.
I tested in Android 13 and lower versions and is working.
https://github.com/nacho004/cordova-plugin-camera


Fatal error: Undefined method GPBUtil::hasSpecialJsonMapping when using protobuf.so

I am using PHP 5.6 on Mac OSX and I've downloaded the latest protobuf extension using pecl install protobuf.
Fatal error: Call to undefined method Google\Protobuf\Internal\GPBUtil::hasSpecialJsonMapping() in vendor/google/gax/src/ApiCore/RequestBuilder.php on line 279

This works fine when I disable the extension.

There are other inconsistencies regarding the protobuf extension I have run into as well:
https://github.com/google/protobuf/issues/4339
https://github.com/google/protobuf/issues/4343
Maybe the actionable item we can take from our repo would be to not suggest using the extension until these issues are resolved?