Add changesets GitHub Action

To automate changeset version execution add the changeset GitHub Action https://github.com/changesets/action

@mistermoe thoughts on automating package publication? Or should that always be a manual step?

Tested integration here https://github.com/TBD54566975/tbdex-js/actions/runs/6341704162
You can see the automated PR opened here https://github.com/TBD54566975/tbdex-js/pull/36
All appears well ✅

Completed

@KendallWeihe beautiful! I want to add the tbdocs reporter + generator on the release PR.
Is there a reason why the PR #36 didn't trigger the CI action? 🤔

Is there a reason why the PR #36 didn't trigger the CI action?

@leordev Are you referring to the changeset action? It's because there weren't any new markdown files in the .changeset/ directory.
As for the release (a different CI action), right now it's still a manual step. We may consider automating that, but that would affect the governance of change management so we'll need to think it through. For now, at least we can automate the semantic versioning.


Add useful stack traces for compilation errors

When an error is thrown by Nunjucks during compilation, no stack trace is given for the source of the error. This makes debugging very difficult.
For example:
> gulp build

[16:51:38] Using gulpfile ~/Dev/freelance/trizma/gulpfile.js
[16:51:38] Starting 'build'...
[16:51:38] Finished 'build' after 13 ms

events.js:165
      throw er; // Unhandled 'error' event
      ^
Template render error: TypeError: Cannot read property 'children' of undefined
    at Object._prettifyError (/home/daniel/Dev/freelance/trizma/node_modules/nunjucks/src/lib.js:35:11)
    at Template.render (/home/daniel/Dev/freelance/trizma/node_modules/nunjucks/src/environment.js:526:21)
    at Environment.renderString (/home/daniel/Dev/freelance/trizma/node_modules/nunjucks/src/environment.js:364:17)
    at DestroyableTransform._transform (/home/daniel/Dev/freelance/trizma/node_modules/gulp-nunjucks/index.js:25:36)
    at DestroyableTransform.Transform._read (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_transform.js:172:83)
    at doWrite (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_writable.js:428:64)
    at writeOrBuffer (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_writable.js:417:5)
    at DestroyableTransform.Writable.write (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_writable.js:334:11)
    at write (/home/daniel/Dev/freelance/trizma/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:623:24)
Emitted 'error' event at:
    at DestroyableTransform.onerror (/home/daniel/Dev/freelance/trizma/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:558:12)
    at DestroyableTransform.emit (events.js:180:13)
    at DestroyableTransform._transform (/home/daniel/Dev/freelance/trizma/node_modules/gulp-nunjucks/index.js:28:9)
    at DestroyableTransform.Transform._read (/home/daniel/Dev/freelance/trizma/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    [... lines matching original stack trace ...]
    at write (/home/daniel/Dev/freelance/trizma/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/home/daniel/Dev/freelance/trizma/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:632:7)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ build: `gulp build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/daniel/.npm/_logs/2018-04-10T07_21_38_514Z-debug.log

Here's the task for my Nunjucks templates:
const templates = () => gulp
  .src(paths.templates.src)
  .pipe(nunjucks.compile())
  .pipe(rename({
    dirname: '.',
    extname: '.html',
  }))
  .pipe(prettify())
  .pipe(gulp.dest(paths.templates.dest));

Any suggestions how? This plugin just forwards the error from the Nunjucks API.

Oh okay. If there's no options to show useful info in the stack trace with
the Nunjucks API, that's a limitation.
I don't see how that could be worked around but perhaps there's a way.
On Tue., 10 Apr. 2018, 5:17 pm Sindre Sorhus<EMAIL_ADDRESS>wrote:

Any suggestions how? This plugin just forwards the error from the Nunjucks
API.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/gulp-nunjucks/issues/34#issuecomment-380007114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI2lFWdTAfD5bgPuX1oLVgS5arvXczPmks5tnGOrgaJpZM4TNuwA
.

Closing. You should open an issue on Nunjucks about this instead.


Use Application Default Credentials (ADC) standard

When deploying this package to Google Cloud it complains that there is no credentials file included. I created a simple fork 'bypassing' this issue by adhering to Application Default Credentials standard.

For local development where you need to have a service account json file, you set the GOOGLE_APPLICATION_CREDENTIALS in your .env file.
For deployment to Google Cloud (not limited to App Engine), you omit this environment variable as Google Cloud will return to the default service account that Compute Engine, Google Kubernetes Engine, App Engine, Cloud Run, and Cloud Functions provide.

More information can be found here
In my fork I removed the validation on the credentials file and also removed the credentials  option in the constructor of the CloudTasksClient class. However, there might be better solutions.

Thanks! I wasn't aware of that. I have made a new release (2.0.0) with these changes.


Bug fix - To do Draft for Voluntary Dissolution

*Issue:*https://github.com/bcgov/entity/issues/23569
Description of changes:
Fix the bug for a draft voluntary dissolution, to properly display the title and action button. Mismatch resolved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-dashboard-dev--pr-56-vk88vcgm.web.app


Fixes #4: Highlighting breaks in anonymous fn inside arguments

Ensure that the body of the function is recognized as a separate context that includes necessary elements like variables, operators, etc...

Hi! I appreciate the interest, but I don't think this actually fixes the issue in a thorough way, and it might break other things (which may not be captured by the current test suite). Pushing main is definitely something we shouldn't do, as main itself never pops, so the context stack will grow unbounded.
In any case, additions to the syntax should come with tests. Try coming up with a tricky example like:
do_thing(
  one: 1,
  two: fn(arg) { fn(i) { arg + i + 2 } },
  three: fn(arg) { arg <> "3" },
  four: "4"
)

...and then writing syntax assertions for all the relevant tokens.
It appears I don't have CI set up correctly to run on contributors' forks — I'll have to look into that. In the meantime you can test locally according to the README. To ensure you don't introduce any regressions, you can run the whole test suite using Build With: Syntax Tests - All Syntaxes. This may hang Sublime Text for a few seconds as it actually runs every test for every syntax you have installed, but it's the only way to run all of one syntax's tests in one go.

The related issue is now fixed in v0.2.9.


Not compatible with ember-component-css

Hey,
When installing this addon, it seems to wipe out the auto-generated class name that's applied to a components element by https://github.com/ebryn/ember-component-css causing styles to break.
Not sure whether the issue is within this addon or ember-component-css, but manual classNames property works, but the auto generated class name is not.
Referenced issue https://github.com/ebryn/ember-component-css/issues/165

https://github.com/ebryn/ember-component-css/issues/165
Right on - I ran into this myself and forked ember-component-css to work around it.
https://github.com/toranb/ember-component-css/commit/29f63f03ea40c9b3fc490174ae5718cfa2801a0a
If you could ping the guys on ember-component-css it might help them see that they do indeed need to offer an extension point so we can override it for special cases like this

Closing this out now that ember-component-css v0.3.0 has an extension point (making it hot reload friendly). Below is a commit showing how to unlock this for anyone watching
https://github.com/toranb/ember-redux-yelp/commit/0efec8c0319edbd3f7ddda79e1e3ff87d3b212ef

@tornab is there any way we can include that mixin in this repo and provide instructions on how to setup with component css?

@oligriffiths it's possible - when the AST rewrite lands I'm not certain we will need it (cc @MiguelMadero) so it's possible we could remove it (worst case). I'm torn because I also think maybe we could just add what is required to the README (not much code/ not everyone is using the ember-component-css project)

I feel like a lot of things are waiting on the AST and we should just push in that direction, but also we have been waiting for it for so long that I don't want to block alternative solutions. All that said, I think that README instructions is a reasonable approach in this case.


Inconsistent tokens results for Term.ApplyInfix.args

def structure(source: String): String =
  source.parse[Stat].get.asInstanceOf[Term.ApplyInfix].args.head.tokens.structure

// This is what I get
structure("a op (f)") == "Tokens(( [5..6), f [6..7), ) [7..8))"

// This is what I expect
structure("a op (f)") == "Tokens(f [6..7))"

// With multiple args I get what I expect
structure("a op (f, g)") == "Tokens(f [6..7))"

Duplicate of https://github.com/scalameta/scalameta/issues/1083, in scalafix we workaround the problem with
      val syntax = name.syntax
      // workaround for https://github.com/scalameta/scalameta/issues/1083
      val pos =
        if (syntax.startsWith("(") &&
          syntax.endsWith(")") &&
          syntax != name.value)
          Position.Range(name.pos.input, name.pos.start + 1, name.pos.end - 1)
        else name.pos

would be good to fix this at the root


Number of workers for concurrent futures must be <=61 on Windows

See this image.sc post.
imio should check this, and set a hard limit if using Windows

Concurrent futures docs for reference

Closing in favour of https://github.com/brainglobe/brainglobe-utils/pull/5


No combat experience is gained when performing Warrior guild tasks.

🐛 Bug Report

Between these two images, I gained the 14.8k attack XP giving me a total of 470.66k attack XP and I just hit 65 Strength after a fire giants task (shown in screenshots) and restarted the token grind

Completed trip messages only mention just the tokens gathered.
A stat check post-trip confirms this

I can confirm that cyclops also do not give xp

Pre vs Post cyclops stats (combat style is currently shared)

Bumping this - issue is still relevant.


[C#] Compile error - Getter tries to return null for newly introduced Enum property

When a template specification introduces a new property with an Enum return type, the generated code checks the ActingVersion and outputs "return null" if it is too low. This doesn't compile.
public AttribValue AttribValue
{
  get
  {
    if (_actingVersion < 3) return null; // compile error

    return (AttribValue)_buffer.Uint32GetLittleEndian(_offset + 0);
  }
... setter
}

From schema file:
<set name="AttribValue" encodingType="uInt32" sinceVersion="3">
            <choice name="FirstChoice" description="The first choice">0</choice>
...
</set>

Should the return type be AttribValue? as a fix?

I'm thinking it should return (AttribValue)0. This isn't ideal but I've failed to come up with anything better.
As it shouldn't be reference in code using older versions I think it will be ok in practice.

Java supports the concept of SBE_UNKNOWN which can be enabled which can be enabled with the system property sbe.decode.unknown.enum.values for SbeTool. If not supported then maybe throw an exceptions.

I think this is resolved by #663


Add pocket employee emails to ALLOWED_BID.

Coverage remained the same at 85.718% when pulling 5221fb41fa7e64d7781e915eac3532045a98b05a on johngian:fix-staff-getpocket into f337e7a4d10ff07b05705a7bac11a460eb5da2ff on mozilla:master.

This has gone into prod.


Multi-scale feature extraction for image retrieval?

Following #72, I have noticed that there is some code for multi-scale feature extraction:
https://github.com/facebookresearch/dino/blob/ba9edd18db78a99193005ef991e04d63984b25a8/eval_knn.py#L101-L104
where three scales are used: 1, 1/sqrt(2), and 1/2.
https://github.com/facebookresearch/dino/blob/ba9edd18db78a99193005ef991e04d63984b25a8/utils.py#L795-L809
I see that this piece of code was committed for image retrieval (rather than KNN even though it appears in the code for KNN).
However, I don't see it mentioned in the paper. Does it lead to better results for image retrieval?

Hi @woctezuma
We have not tried multi-scale feature extraction for k-NN. I think it is a standard practice in image retrieval though: see https://github.com/filipradenovic/cnnimageretrieval-pytorch/blob/master/cirtorch/networks/imageretrievalnet.py#L309-L324 and https://github.com/filipradenovic/cnnimageretrieval-pytorch/blob/c5368dfbbfe0286f536e374a4a35ff89578ef2e5/cirtorch/examples/test.py#L53-L55 for example.

Thank you for your answer.
To be clear, are the results shown in the paper obtained with a single scale or with multiple scales? Maybe it is mentioned in the paper, but I could not find the information with some Ctrl+F.

Paris is with multi-scale, Oxford is without.
https://github.com/facebookresearch/dino#evaluation-image-retrieval-on-revisited-oxford-and-paris
Yes it is true that I have not provided much detailed implementation details for this image retrieval benchmark in the paper but hopefully my implementation provides all the details to allow users to replicate the publishes numbers.

Thank you. I had not noticed the the information was present in the command-line examples!


[docs] Customized hook at Autocomplete issue in dark mode

Closes #19268

@hmaddisb It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Align repository name with Maven GAV "vivid"

Hi Yuri @vivid
We have this OSS templating engine Ash-Ra Template whose Maven GAV coordinates are stuck with using "vivid" as the Group. We'd like to publish it using the new GitHub package feature, but we are running into a problem where the group ID "vivid" doesn't match our username "vivid-inc", making discovery impossible.
Cognizant of the inconvenience this might cause you.. but I'd like to ask if you can transfer the GitHub "vivid" account name to us to that we can make it happen? Much obliged
Cheers!


ionic 14 is releases.

please update ^^

@OminStyle That worked for me, just make sure to update other ionic dependancies too

I'm a newbie to Ionic but from what I understand ...

angular-mocks is now merged into angular repo so can be replaced by a dependency on angular 1.3.6 for ionic v1.0.0-beta.14 .
angular-scenario has been replaced by Protractor.

... so perhaps the bower dependencies are now due for a rewrite. To fully integrate Protractor this has implication for Gruntfile as well.


[Fix #4910] add examples for Layout/SpaceInsideBrackets

Adds examples for the Layout/SpaceInsideBrackets cop.

Enabled by default
Supports autocorrection

Enabled
Yes

Checks for spaces inside square brackets.
Example
# bad
array = [ 1, 2, 3 ]

# good
array = [1, 2, 3]

Before submitting the PR make sure the following are checked:

[ ] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[ ] Used the same coding conventions as the rest of the project.
[ ] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] All tests(rake spec) are passing.
[ ] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[ ] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Looks good to me 👍
Could you remove the [Fix #4910] prefix from the commit message? The prefix will close the issue #4910.

Thanks!


convert all controllers to use genericController, logContext -> log

Signed-off-by: Steve Kriss<EMAIL_ADDRESS>Still need to do a little more manual testing

alright, ran through tests of all these controllers and everything seems to be working

I think it would be helpful to have a codified list of possible values for the first arg of newGenericController

I'd rather keep this open. That's in line w/how you create work queues (arbitrary names).

Ah got it.

OK, good to go.

Will take a pass on this after lunch


Allow data to be an array

Closes #64

@daffl is there some pending work, here?

Yes, there was some further discussion in https://github.com/feathersjs/feathers-errors/issues/64.

Yeah, I might be missing something but I'm not sure if this is necessary. See my comment https://github.com/feathersjs/feathers-errors/issues/64#issuecomment-290826082

I've seen errors being passed back as an array for UI's which display all errors together, rather than field by field. Whereas errors being passed back as an object for Ui's that display errors by the field in question.
Is this what this issue is really about?

I'm not sure why this is controversial. The test shows an issue with a use case someone discovered and fixes it in a non-breaking way.

It is potentially breaking. I don't care whether data is an object or an array. It's fine if it handles both. This just needs to be tuned up a bit. I was merely pointing out that if the intention was for the errors object to be an array then that's already possible.
The data object is meant for any additional metadata beyond the errors object. For example, if you wanted to include the hook method or the user id.

Superseded by #75


http: add modifyBuffer filter callback

Adds a filter callback that allows modifying the encoding/decoding buffer. This is useful in allowing
a filter to modify the buffer after seeing the entire buffer while still using the watermarked buffer
maintained by the HCM.
We only allow modifying the buffer from the latest filter that seen the request/response data. This
ensures that we don't have multiple filters both making changes to the buffer at the same time.
Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>Risk Level: Medium due to changes to HCM
Testing: Integration tests
Docs Changes: n/a
Release Notes: Added release note
Fixes #5394

Had to merge master so PTAL @alyssawilk @mattklein123


outline_width crashing mpf when using special characters.

Hello.
Been trying the new feature outline_width with my code. After some trial and error I think I know why it crash my MPF (v.0.56.x).
When I use special characters in my text it freeze/crash MPF with no error message in logging or in terminal, without special characters it works great.
Example to crash... excuse the formating.
- type: text
  text: Pokémon
  outline_width: 2

Example where it works... excuse formating.
- type: text
  text: Pokemon
  outline_width: 2

Can also add if setting the outline_width too high it freeze as well, for example outline_width: 2 works perfect while outline_width: 8 freeze the kivy window, timers etc. still run in console.

I wonder if this happens if the font you use does not include the special character? As for the outline_width, I don't really have a guess there.
For both of these, the code in MPF-MC is very simple, anything you set in a config is just passed on to Kivy (which is the Python multimedia interface MPF-MC uses). So troubleshooting this would be a Kivy issue and something to figure out with that project and their forums.
As an example, here are the only instances of "outline_width" in all of MPF-MC, in the file mpfmc/widgets/text.py:
    def _get_outline_width(self) -> Optional[int]:
        return self._label.outline_width

    def _set_outline_width(self, outline_width: Optional[int]) -> None:
        self._label.outline_width = outline_width

    outline_width = AliasProperty(_get_outline_width, _set_outline_width)

So really there's not much we can do at the MPF-MC level.
One option would be to update the documentation with a note that the outline width might crash if it gets too big? And then depending on what you figure out with the fonts and special characters, maybe a doc update there too?
Sorry we don't have a better answer!

Thanks, I will try a bit with other fonts. I use impact that's in the fonts-folder in my machines folder.
Will do an update if/when I get some progress. Well try and do some update to documentation if it's the same with other fonts and I can get someone to replicate it with code.
Cheers.

Just updating with what I find.
If I wait when it freeze instead of closing mpf/mpfmc I get a error message with (0xC0000028), seems I can find some stuff with it and this looks to be the issue..
_The workaround from #7914 works fine:
import os os.environ['KIVY_TEXT'] = 'pil'
The second working workaround is to update library:
venv\share\sdl2\bin\SDL2_ttf.dll
from 2.0.18 to latest one 2.20.1
https://github.com/libsdl-org/SDL_ttf/releases
Seems this bug was fixed starting from 2.19.2 (Fixed crash when loading fonts at certain sizes on Windows) SDL_ttf issue_
https://github.com/kivy/kivy/issues/7914
https://github.com/kivy/kivy/issues/8108
I will try and install a nightly master edition of Kivy and see if it works, not sure mpf-mc allows it but can't hurt to try.

I will also try this on my Linux machine, my guess it should work without issue there. I will report back on Sunday when I have the time to test.

This looks really promising! (The update from SDL ttf 2.0.x to 2.20.x.) The way those get installed varies per platform, but it's definitely possible to update them. And also, yeah, you should be able to run with any version of Kivy. I've been using 2.1.0 in my MPF 0.57 dev branch which seems fine, so even moving to the latest release of 2.2.1 might help.


Make it possible to know which bundle was used for a preexisting VM

At the moment, machine.Start() always assume the bundle which is going to be
used is the default one which was used when building the binary/which was
passed through the -b option
This leads to various unwanted behaviours, which I'll detail in another bug.
First step towards fixing that is to be able to know which bundle was used to
create a preexisting vm in ~/.crc/machines/crc/

Fixed by #20


Contour CR with spec.gatewayClassRef becomes Ready status even when contour pod is not Ready

What steps did you take and what happened:
(This is exact same steps with https://github.com/projectcontour/contour-operator/issues/343)
1. Install operator from main branch.
kubectl apply -f "https://raw.githubusercontent.com/projectcontour/contour-operator/main/examples/operator/operator.yaml"

2. Install Contour and Gateway in different namespaces.

Gateway is deployed in knative-serving namespace.
Contour is deployed in contour-external namespace.

cat <<-EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: contour-operator
  name: contour-external
---
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: contour-operator
  name: knative-serving
---
apiVersion: operator.projectcontour.io/v1alpha1
kind: Contour
metadata:
  name: contour-external
  namespace: contour-external
spec:
  gatewayClassRef: contour-external-gatewayclass
  namespace:
    name: contour-external
  ingressClassName: contour-external
  networkPublishing:
    envoy:
      type: LoadBalancerService
---
kind: GatewayClass
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: contour-external-gatewayclass
spec:
  controller: projectcontour.io/contour-operator
  parametersRef:
    group: operator.projectcontour.io
    kind: Contour
    scope: Namespace
    name: contour-external
    namespace: contour-external
---
kind: Gateway
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: test-gateway
  namespace: knative-serving
spec:
  gatewayClassName: contour-external-gatewayclass
  listeners:
  - protocol: HTTP
    port: 80
    routes:
      kind: HTTPRoute
      selector:
        matchLabels:
          knative-e2e-test: "net-ingressv2"
      namespaces:
        from: "All"
EOF

3. contour pod fails to start due the issues/343
$ kubectl get  -n contour-external  pod contour-8846b749f-7b6bc
NAME                      READY   STATUS              RESTARTS   AGE
contour-8846b749f-7b6bc   0/1     ContainerCreating   0          24m

But both Contour and Gateway become Ready status.
$ kubectl  -n contour-external get contour
NAME               READY   REASON
contour-external   True    GatewayClassAdmitted

$ kubectl  -n knative-serving describe gateway
  ...
Status:
  Conditions:
    Last Transition Time:  2021-05-03T01:58:15Z
    Message:               The Gateway is ready to serve routes.
    Reason:                GatewayReady
    Status:                True
    Type:                  Ready

What did you expect to happen:
Contour should not become Ready if Contour pod is not running.

As stated in https://github.com/projectcontour/contour-operator/issues/343, a Contour must be created in the same ns as the gateway, xref. With https://github.com/projectcontour/contour-operator/pull/349, the Gateway will no longer become ready if the ns's differ.


Editor's Popup overlay not hiding/freeing

Godot version:
3.2.beta1
OS/device including version:
Solus 4.0 Gnome 3.34.1
Issue description:
Some times when closing a popup dialog the overlay (the one that makes the background darker) doesn't disappear and it also consume inputs, making so that is impossible to even save some progress (unless it is saveable through the exiting dialog).

Steps to reproduce:

Try to open some pop up dialogs, like moving a file using the dropdown menu.
Click outside the pop up dialog, or even on cancel, or even confirm it, it happens randomly really

ps: it may have to do with the usage of tablets (I'm using a wacom tablet) and I thin @NathanLovato had similar issues as well, dunno if he was using a tablet, tho.

@YeldhamDev Dimming issues never end...

Considering that I've been using the master branch in my projects and never encountered this, I am going to assume that indeed this may be related touch inputs. And since I have none to test the editor with, this creates a problem for me to even start debugging it...

This is the section that turns dimming on and off. Could you check if those conditionals fire when opening and closing dialogs in your touch device, and if you can reproduce it with a mouse?
https://github.com/godotengine/godot/blob/953f37f49b4d71b064935ff7e910bad829bfd17a/scene/gui/dialogs.cpp#L241-L251

@YeldhamDev I don't have a touch device, the tablet I mention is a wacom tablet with pen and stuff...
I just tested and it also happens with mouse. And god...I'm having this non stop every time

@henriiquecampos I see. Could you describe the action that makes this occur more frequently? Because I'm completely unable to reproduce this...

Everything that pops a dialog, really. Lemme see if I reproduce it consistently. It mostly happen when these dialogues pop from a dropdown menu interaction, but it also happens otherwise.
Here are 3 examples, but honestly I could keep going, there are at least 6 more that I can reproduce consistently:

Try to delete a folder on the Filesystem using the drop down menu

Try to delete a node in the SceneTree using the drop down menu

Try to save a branch scene that is an instance of another scene using the drop down menu

I'm sorry, but I can't reproduce any of those. Everything works correctly on my end.

I've randomly encountered this also, albeit randomly
Ubuntu 19.10 eoan
x86_64 Linux 5.3.0-19-generic

Something interesting that I noticed: if we delete using DELETE and pressing ENTER or RETURN to confirm the deletion, this bug doesn't happen

Personally, I think dimming is a terribly implemented 'anti-feature', and now it's not even possible to disable it :-/
(If you build Godot yourself, you can apply our patch that completely disables dimming)
diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp
index ef382c0a1..1558c1cd5 100644
--- a/editor/editor_node.cpp
+++ b/editor/editor_node.cpp
@@ -5194,6 +5194,12 @@ void EditorNode::_open_imported() {
 }

 void EditorNode::dim_editor(bool p_dimming, bool p_force_dim) {
+
+       // disable dimming
+       dimmed = false;
+       gui_base->set_modulate(Color(1, 1, 1));
+       return;
+
        // Dimming can be forced regardless of the editor setting, which is useful when quitting the editor.
        if ((p_force_dim || EditorSettings::get_singleton()->get("interface/editor/dim_editor_on_dialog_popup")) && p_dimming) {
                dimmed = true;
diff --git a/editor/project_manager.cpp b/editor/project_manager.cpp
index ab62a59be..a19144dd8 100644
--- a/editor/project_manager.cpp
+++ b/editor/project_manager.cpp
@@ -1815,6 +1815,9 @@ void ProjectManager::_notification(int p_what) {

 void ProjectManager::_dim_window() {

+       // disable dimming
+       return;
+
        // This method must be called before calling `get_tree()->quit()`.
        // Otherwise, its effect won't be visible

@capnm Doesn't disabling Interface > Editor > Dim Editor On Dialog Popup do the job? If not, that should be fixed.
I personally like editor dimming as it makes it easier for the user to notice a popup has opened. Back in the Godot 2.x days, I occasionally missed popups due to this.

@capnm Doesn't disabling Interface > Editor > Dim Editor On Dialog Popup do the job? If not, that should be fixed.

→ // Dimming can be forced regardless of the editor setting, which is useful when quitting the editor.
Previously, it was possible to completely disable it.

I personally like editor dimming as it makes it easier for the user to notice a popup has opened …

Maybe the default window frame could be made darker?
Most of the people (including myself) I asked, do not like that. It looks like something went wrong and just scares most of my kids… It's not an essential feature, so I'd rather recommend removing it from the editor (instead of fixing it).

→ // Dimming can be forced regardless of the editor setting, which is useful when quitting the editor.
Previously, it was possible to completely disable it.

This is something entirely different. It's a special case of dimming that's displayed only when quitting the editor (or project manager). I first added it in #29636 so that the editor doesn't feel "stuck" when you close it. (It can take a few seconds to close on a slow machine, but even on a fast machine, it's never really instant.)

Dimming is essential for UX, pop ups lose all their weight without dimming the background.
If the setting is not disabling it, it is an issue itself, but removing the dimming isn't going to improve the editor

Since the editor is no longer responsive when you start quitting it, I don't see a point in making this kind of dimming toggleable.

The big flicker with overhead projector in a darkened room is I think more annoying,
a few seconds of unresponsive editor does not really bother so much.

We can't make it too dark without going into "pure black" territory,…

Then maybe a brighter edge or something in the sense that the border becomes more visible?
At the moment it is not easy to see where the dialogue lies:

(Advertising :1st_place_medal: I'd be really happy if anyone could spend his energy to fix #27669 That's something I have no idea how to fight against ;-)

A quick update on this: I tried to turn off the dimming in the Editor Settings and now the editor freezes on the examples I mentioned...seems like the problem is a bit deeper indeed

@akien-mga I just saw we have a beta2, this issue is definitely critical and it as I tested it still happens over and over.
I think there can't be a stable release with that bug still around, I really mean it, it's impossible to work, and this is potentially a regression from 3.1.1, which this bug doesn't happen, at least not that frequently (it happen once in a while, but currently it is just impossible to work)

Might be fixed by #34770. Can anyone confirm in the current master branch / upcoming 3.2 beta 5?

@henriiquecampos Ping.

Ohh, sorry. Yeah I've been testing the last 4 days or so and didn't notice it happening, seems pretty much fixed at least for the cases I mentioned, thanks a lot :D


Public version of the get_char_lb_class_lang() function

Is it possible to make the get_char_lb_class_lang() function to determine the class of a unicode character public?
Here is a patch that does something similar:
diff --git a/src/linebreak.c b/src/linebreak.c
index c2ccdda..45afba2 100644
--- a/src/linebreak.c
+++ b/src/linebreak.c
@@ -751,6 +751,12 @@ int lb_process_next_char(

     return brk;
 }
+enum LineBreakClass lb_get_char_class(
+        struct LineBreakContext *lbpCtx,
+        utf32_t ch)
+{
+    return get_char_lb_class_lang(ch, lbpCtx->lbpLang);
+}

 /**
  * Sets the line breaking information for a generic input string.
diff --git a/src/linebreakdef.h b/src/linebreakdef.h
index 5bb8838..8db80a6 100644
--- a/src/linebreakdef.h
+++ b/src/linebreakdef.h
@@ -169,3 +169,6 @@ void set_linebreaks(
         const char *lang,
         char *brks,
         get_next_char_t get_next_char);
+enum LineBreakClass lb_get_char_class(
+        struct LineBreakContext *lbpCtx,
+        utf32_t ch);

Do you have a strong reason to use the data external to the library? I am a bit curious.

koreader/crengine (a fork of CoolReader) added some code using libunibreak with this patch. Unfortunately, I cannot say exactly what this function is for, since I am not the author of this code. As far as I understood, it's required for more correct linebreaks around em-dash.
https://github.com/koreader/crengine/pull/365
Perhaps the authors of this code can explain - @Jellby. Perhaps @poire-z will also be able to explain something.
I just want to use this code without applying additional patches.
https://github.com/koreader/crengine/blob/a4f7509a475ba233ddd92b19c1a5868f098c4655/crengine/src/textlang.cpp#L494
https://github.com/koreader/crengine/blob/a4f7509a475ba233ddd92b19c1a5868f098c4655/crengine/src/textlang.cpp#L670

Interesting....
@jellby @poire-z Can you think of a solution that work directly inside libunibreak? This can be, but not limited to, adding more custom data to linebreakdef.c.

I hope @poire-z can provide a more useful answer. To be honest, by knowledge of crengine, libunibreak and the UAX stuff at the time is pretty much contained in the PR description and comments, and I've forgotten most of it since :D

(It's been a while since we integrated libunibreak into crengine, so the following is from what I can gather having a quick look again at our code.)

Can you think of a solution that work directly inside libunibreak? This can be, but not limited to, adding more custom data to linebreakdef.c.

I'm not sure I want to :)
I mean, it's not really only custom data that we would need to add, but custom code.
We have a module where we have put all the language specific tweaks:
https://github.com/koreader/crengine/blob/master/crengine/src/textlang.cpp
that, among other things, provide some tweaks and callbacks to our main use of libunibreak:
https://github.com/koreader/crengine/blob/a4f7509a475ba233ddd92b19c1a5868f098c4655/crengine/src/lvtextfm.cpp#L1471-L1484
For some stuff (quotes & al.), we use your lb_props codepoint-to-class mapping (your linebreakdef.c is a bit limited, and we're happy being able to tweak it on our side without having to push PRs to your side).
But for other stuff, we may need a bit more context (ie, depending on what's before or next to the current char) to decide how to tweak its class (depending on language or CSS properties).
And I'm happy being able to do that and have full control on our side, and not having to feed libunibreak with callbacks (and not having to plug new ones on text language change - the alternative would be to have a single callback, but libunibreak would need to call it on each char, which would drop performances a lot).
I'm not sure you would want all this language specific tweaks in libunibreak: you do UAX14 well, dunno if you want to do more. UAX14 allows for language specific tweaks, but doesn't specify them. Dunno what kind of higher level hooks you could provide to allow your users to plug them, but I think such low level hooks like the above patch (and this litlle trick that you allowed us to use) are good enough (at least, for us :)
Also, all our languages tweaks in there were mostly added by KOReader users, may be looking at docs, but also possibly just from the personnal taste of the user reading that language that dared doing something to make his reading more pleasant :) None of these have been validated by scholars or academic organisation - so bringing our choices for a EPUB reading software to libunibreak, that may be used for more serious stuff, could lead to hot discussions among language communities, that I'd rather not be part of :)

@virxkane As this seems the smallest change that does not break anything, feel free to submit a patch.
@Jellby @poire-z If you have new ideas how to extend libunibreak, please let me know.


PostgreSQL and not using lib/pq for arrays

What do you want to change?
Current state
In current state of the library, using queries with arrays generates code with a dependency to github.com/lib/pq, which is in maintenance mode.
Example from the docs:
func (q *Queries) ListAuthorsByIDs(ctx context.Context, ids []int) ([]Author, error) {
	rows, err := q.db.QueryContext(ctx, listAuthors, pq.Array(ids))

It would be great if it was possible to not have pq dependency here.
Implications
This might lead to some misleading situations, example:
The pgx lib, which is used often as a replacement for lib/pq, is possible to use in such way:
db, err := sql.Open("pgx", os.Getenv("DATABASE_URL"))

This means that if you use sqlc in the default database/sql mode with such command, you end up with:

imported pq dependency
but actually you're using pgx as a driver

Thank you in advance for looking into this issue.
What database engines need to be changed?
PostgreSQL
What programming language backends need to be changed?
Go

While working on https://github.com/riverqueue/river/pull/351, we found ourselves in what would seem to be an odd position where we wanted to provide a database/sql interface for use with packages like Bun and GORM, but where our users are all almost certainly using Pgx under the hood since it's really the only plausible driver these days for Postgres in the Go ecosystem.
I found myself wanting pretty much exactly what's described here — an Sqlc generated package that exposes database/sql primitives, but doesn't use anything from lib/pq given the library's no longer maintained and has a random assortment of missing features like multi-dimensional arrays.
@kyleconroy Do you know if this questions come up anywhere else? I'm not sure if the best solution would look like a brand new Sqlc driver, or just an option for the existing one. If the latter, one tricky part is that you might need to be able to configure Pgx v4 vs. Pgx v5 to be used internally. Maybe that means it should be an extra option for the pgx/v4 and pgx/v5 (e.g. expose_database_sql: true) instead.


[vscode-project-manager] Avoid showing duplicates

Extension
https://www.raycast.com/MarkusLanger/vscode-project-manager
Description
The extension currently shows duplicated entries whan a project is both in "Favourites" and in "Git"
Who will benefit from this feature?
Everyone should benefit from not getting duplicated entries
Anything else?

Fixed in #3657


FactoryProvider.cs line34 _factory not defined?

the newest version can't compile.

Oops.  Thanks for letting me know.  Fixed now.


prevent crash when the visible view controller holds a reference to a ma...

...p view. The error message was: -[VKMapView superview]: unrecognized selector sent to instance ...

Thanks for fixing it! I had the same issue.
@lmcd: Should be merge :+1:

thanks for fixing it


Redstone receivers stay on when the transmitter goes away

If you break a redstone transmitter while it's powered, its receivers will stay on. (Not sure if you'd actually call this a bug, or if you'd just consider a receiver with no transmitters to be Undefined Behavior™.)

I'm calling this Undefined Behavior.


Can't create function with parameter defined with optional parameters

I'm trying to create a Python UDF which takes a NUMBER(35,4) parameter (and returns a NUMBER(35,4) parameter). Here is what the default section of my app.toml looks like:
[default]
input_parameters = "(temp_f number(35,4))"
return_type = "number(35,4)"
name = "fahrenheit_to_celsius_udf"
handler = "app.main"
file = "app.zip"

When I try and create/update the function, snowcli runs the following query: describe function fahrenheit_to_celsius_udf(number(35,4); which results in the following error:
001003 (42000): SQL compilation error:
syntax error line 1 at position 56 unexpected ';'.
It looks like the issue is in snow_connector.py:generate_signature_from_params(). That function doesn't seem to correctly handle parameters with optional parameters.

Thanks much @thomaseibner ! Just pushed out release with this fix. Let me know if this is resolved and can close issue

Done in #634


feat: Enable in/not in filter operators

Adding support for in/not in operators in filters. This is something that could be handy for a DHIS2 App I'm writing right now (I made it work using a direct call to the API but this would be better).
Please note I had to add the changes of my previous PR about year, else the precommit hook would not let me go (as tests were falling).

Hey @Birkbjo - just realized this was never merged - I suppose you have it working in the master since ? If so I'll close, if not I'm happy to check to make it mergeable again

Oh snap. This just popped up on my radar. I'm sorry about the massive lag on response, @vanakenm!
If you still want to get this in I will be happy to accept the patch if you update it.

I'll have a look at how much things have changed. If cost is reasonable I'll submit an updated version.

Did a quick review, just had to merge the results with the one adding "token" capability, looks good now & tests are running (at least locally, let's see what Travis has to say)

@vanakenm Thanks man! Again, I'm sorry about the delay.
("delay" is a candidate for understatement of the year).

Travis doesn't run on PRs. Works locally so taking a chance. :crossed_fingers:


iOS 14 砸壳出来上传appstore 报错ERROR ITMS-90209: "Invalid Segment Alignment. The app binary at 'JiaYunFlower.ap

ERROR ITMS-90209: "Invalid Segment Alignment. The app binary at 'JiaYunFlower.app/JiaYunFlower' does not have proper segment alignment. Try rebuilding the app with the latest Xcode version."
如题，求更新

ERROR ITMS-90209: "Invalid Segment Alignment. The app binary at 'JiaYunFlower.app/JiaYunFlower' does not have proper segment alignment. Try rebuilding the app with the latest Xcode version."
如题，求更新

请问有解决办法嘛

ERROR ITMS-90209: "Invalid Segment Alignment. The app binary at 'JiaYunFlower.app/JiaYunFlower' does not have proper segment alignment. Try rebuilding the app with the latest Xcode version."
如题，求更新

请问有解决办法嘛

请问有解决办法嘛

遇到相同的问题，但是我从 https://decrypt.day/ 上砸壳的app不会出现这类错误，不知道该网站用的什么工具


Feat: add RoCrateBuilder with crate as template

Added RoCrateBuilder constructor with crate as "template" (Addressing #36)

I haven't removed anything from RoCrate yet, so this is still 100% backward compatible.
If you have better wording for "template" pls let me know:D

Pull Request Test Coverage Report for Build #49

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 89.36%

Totals

Change from base Build #46:
1.0%

Covered Lines:
1285

Relevant Lines:
1438

💛  - Coveralls

title change proposal: "enable builder class to extend existing crates" ?


Update README.MD

Coverage remained the same at 100.0% when pulling ccc72a83e7f7139b1f48361fbb7e0f686237320e on Fix-a-doc-mistake into ef5dec8b92812d28a883b9bbaeeeaa05a657660f on master.


Style helper validations

https://app.clubhouse.io/cartoteam/story/76421/validations-of-style-helper-params

:top commit removes custom buffer (previously mvt: 30) for both size-categories and size-bins helpers examples. I was not able to see any glitch removing them, and I think examples should be simple. We might add a custom map instantiation example in the future though, passing extra parameters... but I think that's not required yet
I think these examples were created by @manmorjim . Manu can you spot any style issue on them?

[ ]  https://toolkit-git-style-helper-validations.carto-frontend.now.sh/examples/style-helpers/size-bins-style.html
[ ] https://toolkit-git-style-helper-validations.carto-frontend.now.sh/examples/style-helpers/size-categories-style.html

:top commit removes custom buffer (previously mvt: 30) for both size-categories and size-bins helpers examples. I was not able to see any glitch removing them, and I think examples should be simple. We might add a custom map instantiation example in the future though, passing extra parameters... but I think that's not required yet
I think these examples were created by @manmorjim . Manu can you spot any style issue on them?

[x]   https://toolkit-git-style-helper-validations.carto-frontend.now.sh/examples/style-helpers/size-bins-style.html
[x]  https://toolkit-git-style-helper-validations.carto-frontend.now.sh/examples/style-helpers/size-categories-style.html

They both look great. I think the MVT buffer is not needed since the issue about clipping was fixed.
BTW I experimented a very uncommon issue about weird lines in the size-categories-style.html example. In some zoom levels some 'nonexistent' lines appear:

I think this is a deckgl issue rather than web-sdk.

Thx @manmorjim. The artifacts might be related to https://github.com/visgl/deck.gl/issues/4604, but we should consider it outside of this PR

Added upper limits for bins and top categories in related helpers


feat(app, shared-data, step-generation): frontend low volume support

closes RAUT-714
Overview
This adds low volume front-end support
Test Plan
in PD/Step-generation:
sandbox: https://sandbox.designer.opentrons.com/app_pd-low-volume-support/

create a Flex protocol with a p50 pipette (single or 8-channel).
Add a transfer step and make the volume = 1uL
add a transfer step and make the volume > 1uL
save and download the protocol and open up the json file. see that configureForVolume command occurs before the 1st aspirate with the correct commands, but make sure that the configureForVolume command doesn't occur after the 2nd aspirate.

in the App:

upload the protocol to the app and should pass protocol analysis. Check the run log command text for the configureForVolume commands.

Changelog
in shared-data:

add the types for ConfigureForVolumeCreateCommand and ConfigureForVolumeRunTimeCommand, add the optional pushOut param to dispense command

in app:

add logic in commandText and add test cases

in Step-generation:

create new configureForVolume.ts atomic command, add test for it
add logic for emitting the command in transfer.ts before an aspirate happens and volume is 1uL and with the correct pipettes.
add a comment explaining that pushOut won't be specified in dispense.ts

Review requests
I only added the configureForVolume command to transfer.ts and not mix.ts. I can't think of a reason why a user would want to mix 1uL?
Risk assessment
low

App command render looks good!


KOGITO-3421 Fix variable name generation in CloudEvents resource router

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>See: https://issues.redhat.com/browse/KOGITO-3421
Tested with: https://github.com/kiegroup/kogito-examples/pull/372
In this PR we generate a random name for the emiiter variable since in SW engine we are using CE source as the name of the trigger, which is an URI. We can't use that as var name.
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

@evacchi if you're ok if this PR, could you please merge?

@ricardozanini I'll merge it, but I think a (sanitized) UUID (i.e. "_" + uuid.replace("-", "")) may be safer

@ricardozanini I'll merge it, but I think a (sanitized) UUID (i.e. "_" + uuid.replace("-", "")) may be safer

Yeah I though about that, besides having a huge variable name. I'll do it. Wait for me.


Postal code question

How can i automatically activate postal code when a card number that requires it is added?

Don't you need it anymore @tankpower1 ?


fix: revert changes to css-only-tooltip

:tada: This PR is included in version 4.5.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


STP-3186: correcting broken fenced code blocks

Summary and Scope
Correcting several instances throughout the docs where fenced code blocks start with a triple-backtick marker
but are never closed with a corresponding one.
Issues and Related PRs

Resolves STP-3186 and https://github.com/Cray-HPE/docs-csm/issues/952
Change will also be needed in release/1.0, release/1.2.5, and main

Testing
N/A
Tested on:
N/A
Test description:
N/A
Risks and Mitigations
None.
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

This needs to be rebased. Also, note that it is now targeted for the main branch. This is appropriate -- just be sure to backport or cherry-pick it into all appropriate release branches.

/backport release/1.0 release/1.2

/backport release/1.2 release/1.0

Due to major differences in files, I manually opened https://github.com/Cray-HPE/docs-csm/pull/1476 and https://github.com/Cray-HPE/docs-csm/pull/1477 for the release branches.

@nrockershousen this change looks great, but it looks like there's an issue preventing a rebase/merge.  Did something get force pushed by chance?

@nrockershousen this change looks great, but it looks like there's an issue preventing a rebase/merge. Did something get force pushed by chance?

@gbaker-hpe I checked the history for the 3 tickets. This is the only one that had a force push, which I believe was after a rebase.


Add management command to delete waffle data in a batch

Implements #274

@clintonb how does it look now?


Forms: domain slot mappings + ending form in validation asks extra question

Rasa version: 2.0.0a4
Rasa SDK version (if used & relevant): 2.0.0a4
Rasa X version (if used & relevant):
Python version: 3.7.8
Operating system (windows, osx, ...): Ubuntu 18.04
Issue:
When the slot mappings are defined in the domain file, ending a form "in advance" inside the validation action by setting "requested_slot" to None does end the form, but only after asking the supposed-to-be-next slot. Here's my use case (simplified) as an example:
Content of domain file (domain.yml):
version: "2.0"

intents:
  - affirm
  - deny
  - test_tiny_form

actions:
  - validate_tiny_form

forms:
  - tiny_form:
      a:
        - type: from_intent
          intent: affirm
          value: true
        - type: from_intent
          intent: deny
          value: false
      b:
        - type: from_intent
          intent: affirm
          value: true
        - type: from_intent
          intent: deny
          value: false

responses:
  utter_ask_a:
    - text: Is it a?

  utter_ask_b:
    - text: Is it b?

  utter_tiny_form_ended:
    - text: Tiny form ended

slots:
  a:
    type: unfeaturized

  b:
    type: unfeaturized

Content of rules (rules.yml):
version: "2.0"
rules:
  - rule: Tiny form test
    steps:
      - intent: test_tiny_form
      - action: tiny_form
      - action: utter_tiny_form_ended

Validation action:
class ValidateTinyForm(Action):
    def name(self) -> Text:
        return "validate_tiny_form"

    def run(
        self, dispatcher: CollectingDispatcher, tracker: Tracker, domain: Dict
    ) -> List[EventType]:
        extracted_slots: Dict[Text, Any] = tracker.form_slots_to_validate()

        validation_events = []

        for slot_name, slot_value in extracted_slots.items():
            if slot_name == "a" and slot_value:
                validation_events.append(SlotSet("requested_slot", None))
                validation_events.append(ActiveLoop(None)) # doesn't change anything

            validation_events.append(SlotSet(slot_name, slot_value))

        return validation_events

Resulting conversation:
$ rasa shell
Your input ->   /test_tiny_form
Is it a?
Your input ->   /affirm
Is it b?
Tiny form ended

Obviously, I would not expect the bot to ask "Is it b?" before ending the form. Maybe this is more of an unsupported feature/edge case than a bug (feel free to change the issue type).
There is a workaround, but it's not clean (setting a placeholder value to all the remaining form slots to make sure none is asked), and I kinda need this, so I could take the time to submit a PR. The problem seems to be that FormAction.request_next_slot treats this case the same way as if validation did not set the "requested_slot" slot at all (pretty easy to fix I think).

Seems to have been solved in 2.0.0


Keep keyboard up on iOS Safari when submitting commands

Rebased PR #1

I want this to be a user preference, so I'll wait until that can be the case before merging this.

I agree that this should be a setting, but I think we should merge this PR now anyway, because keeping the keyboard up should be the default, as it is on all mobile interpreters.
It's particularly painful to use HELP menus right now on mobile, because the <input> is usually teensy tiny, and the keyboard dismisses itself every time you press N.


When authmiddleware is setup for any backstage-plugin, project will not authenticate

Describe the bug
Projects utilizing the quay backstage plugins will not work with authmiddleware set up
To Reproduce
Steps to reproduce the behavior:

Go to 'packages/backend/index.ts'
Set up apirouter for one of the plugins i.e. 'apiRouter.use('/quay', authMiddleware, await quay(quayEnv));'
run backstage instance and see that authentication will fail

Expected behavior
Projects will be allowed to authenticate when using authmiddleware.

Hi @pbuehl-redhat thank you for noticing this, filing an issue and even opening a pull request. 👍  That's huge help. I think this is an important issue to fix. 🙂

@pbuehl-redhat please ignore my comment above. I finally did my homework 🙂
https://github.com/janus-idp/backstage-plugins/pull/498#discussion_r1273380327
All is good, your PR is good.

thanks @tumido


[Fix] no-cycle: Accept import typeof, like import type

Fixes #2607.
In addition to import type, Flow has a syntax import typeof. For example (try-flow link):
import typeof { useEffect } from 'react';

var f: useEffect; // has the same type as React.useEffect

Like with import type, these imports are transpiled away and have no effect at runtime, so they should be given the same treatment as import type: that is, they should be ignored.
Currently they're not. This PR fixes that.

Thanks for the swift review and merge!


Upload SPFx built on 1.5 with beta packages to catalog fails on some tenants

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Drag spfx package file sppkg into sharepoint online app catalog should show the dialog to trust it, and install it.
Observed Behavior
On some tenants this installs correctly. However on a few of our test tenants and some of our customers, this package is uploaded without showing the dialog. It will add a package where all meta data fields are empty, version shows <IP_ADDRESS> which is wrong, and the "app package error message" will simply say "Error in the application" without giving any more information.
The same package will install on other tenants.
On the problematic tenants, installing a previous build that was using SPFx 1.4 works and installs correctly.
Steps to Reproduce
Build a package using SPFx 1.5 (I am not sure if this happens with every SPFx 1.5 package) and that uses the beta packages.
Try to add it to app catalog.
Is there a problem with installing an SPFx using beta packages? Is this not supported? I'd like to give some customers a preview of new features to try out.
Thanks.
FYI @VesaJuvonen, your input is always greatly appreciated!

I'd like to add:
The older version <IP_ADDRESS> installs correctly, but does not show any web parts on the site where I added it.
None of the web parts in this package are available.
This package was released a while ago and we have hundreds of installs already with no problems for months...

Here is how it looks like (the error message):

FYI the "Unavailable apps" view doesn't give much more info:

Not sure if related, but deleting this and installing the <IP_ADDRESS> version (older) works, but when adding it to sites it just took me 1.5 hours to finish adding the app to 1 site.

Could this be the issue?
https://github.com/SharePoint/sp-starter-kit/issues/6
It says he had similar problems and it worked once he put his tenant in "Targeted release for everyone"?
It does work for me on the tenant that has this setting.
It doesn't work on a tenant that is set to standard release.
If that is the cause - can you please confirm, and explain why since SPFx 1.5 is in GA and not in beta. Why would it require targeted release to be turned on?
(I can't confirm this is the solution since we don't want to set that specific tenant to targeted release. We use it to test apps in standard release environment)


Error when inserting lots of data.

I previously had an insert (on db creation) adding 505 rows of data. One column had dummy data (an empty string) and I changed it add ~100 characters per row. After that building the APK started failing with the following error:
...
    ACONST_NULL
    ICONST_1
    ACONST_NULL
   L219
    LINENUMBER 1808 L219
    INVOKESTATIC kotlin/text/StringsKt.trimMargin$default (Ljava/lang/String;Ljava/lang/String;ILjava/lang/Object;)Ljava/lang/String;
    ICONST_0
    ACONST_NULL
    BIPUSH 8
    ACONST_NULL
   L220
    LINENUMBER 1799 L220
    INVOKESTATIC com/squareup/sqldelight/db/SqlDriver$DefaultImpls.execute$default (Lcom/squareup/sqldelight/db/SqlDriver;Ljava/lang/Integer;Ljava/lang/String;ILkotlin/jvm/functions/Function1;ILjava/lang/Object;)V
   L221
    LINENUMBER 1809 L221
    RETURN
   L222
    LOCALVARIABLE this Lghplayer2/android/north101/gloomplayer2/Database$Schema; L0 L222 0
    LOCALVARIABLE driver Lcom/squareup/sqldelight/db/SqlDriver; L0 L222 1
    MAXSTACK = 7
    MAXLOCALS = 2

Cause: java.lang.IllegalArgumentException
Element is unknownThe root cause was thrown at: ByteVector.java:213
	at org.jetbrains.kotlin.codegen.TransformationMethodVisitor.visitEnd(TransformationMethodVisitor.java:88)
	at org.jetbrains.org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:878)
	at org.jetbrains.kotlin.codegen.FunctionCodegen.endVisit(FunctionCodegen.java:992)
	... 62 more
Caused by: java.lang.IllegalArgumentException
	at org.jetbrains.org.objectweb.asm.ByteVector.putUTF8(ByteVector.java:213)
	at org.jetbrains.org.objectweb.asm.ClassWriter.newUTF8(ClassWriter.java:1141)
	at org.jetbrains.org.objectweb.asm.ClassWriter.newStringishItem(ClassWriter.java:1163)
	at org.jetbrains.org.objectweb.asm.ClassWriter.newConstItem(ClassWriter.java:1091)
	at org.jetbrains.org.objectweb.asm.MethodWriter.visitLdcInsn(MethodWriter.java:1165)
	at org.jetbrains.org.objectweb.asm.MethodVisitor.visitLdcInsn(MethodVisitor.java:595)
	at org.jetbrains.org.objectweb.asm.tree.LdcInsnNode.accept(LdcInsnNode.java:71)
	at org.jetbrains.org.objectweb.asm.tree.InsnList.accept(InsnList.java:162)
	at org.jetbrains.org.objectweb.asm.tree.MethodNode.accept(MethodNode.java:817)
	at org.jetbrains.kotlin.codegen.TransformationMethodVisitor.visitEnd(TransformationMethodVisitor.java:68)
	... 64 more

I was able to fix it by breaking it up into multiple inserts.

compilation failure or runtime failure

Compilation failure. Happens during :app:compileDebugKotlin
(:app:generateDebugSqlDelightInterface succeeds).

can you paste here the code that caused the compilation failure? .sq and .kt

ClassAbilityTest.sq.txt
Rename to .sq
I've duplicated the class and removed all references to other classes and types and it still fails during compilation with the same error. So dropping that into an existing project should hopefully also cause the error.
Breaking it up into multiple inserts succeeds (see attached):
ClassAbilityTest.sq.txt

I'm guessing we blow the limit for number of bytecodes in a single method.

Yea, that was my guess as well. The error could be confusing though, I was able to easily figure it cause it was the last thing I changed.

is there a limit on how big a string can be - cause the size of the generated create method wouldnt change but in the second .sq file there would be multiple different strings.

Ah yes. Based on the stacktrace coming out of ASM the problem is around creating a new string constant.

thats annoying. we might just be out of luck here unless theres a way to break that string requirement.

Looks like its length is represented by a two-byte, unsigned value so that'd give us 65k bytes. We could chunk it and use buildString if that length is exceeded.

:+1: sounds good


double point floating precision aversion

This is the line that was giving me grief.. Turns out that

rep() coerces the second argument into an integer vector...
and that
as.integer() truncates towards zero if the values being coerced are not integers.

Because colSums (on two of my machines) did not sum to an integer, and hence got rounded down a notch each time, zone and id were differing lengths.
The rest compiled fine ;)

Hi Maja, it seems that great minds think alike :) Richard Ellison flagged the same issue to me and found the same fix; unfortunately he only fixed it locally.
In fairness, I'm pretty sure it worked up to R 3.2 - think they've changed the behaviour of rep in a sensible way that broke my non-robust code. Perhaps this:
Calling rep() or rep.int() on a pairlist or other non-vector object is now an error
http://cran.r-project.org/doc/manuals/r-devel/NEWS.html
Thanks a ton for the fix :+1:

Bloody hell, you could have saved me a the hassle..
To be fair, I loved the challenge, had to figure it out for myself ;)
On 13 May 2015 at 22:04, Robin<EMAIL_ADDRESS>wrote:

Hi Maja, it seems that great minds think alike :) Richard Ellison flagged
the same issue to me and found the same fix; unfortunately he only fixed it
locally.
In fairness, I'm pretty sure it worked up to R 3.2 - think they've changed
the behaviour of rep in a sensible way that broke my non-robust code.
Perhaps this:
Calling rep() or rep.int() on a pairlist or other non-vector object is
now an error
http://cran.r-project.org/doc/manuals/r-devel/NEWS.html
Thanks a ton for the fix [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/Robinlovelace/spatial-microsim-book/pull/50#issuecomment-101816106
.


docs(upgrade): add note about version support

What this PR does / why we need it:
I asked a question in an issue and got a very good answer that might deserve to be documented in the upgrade docs for others to see and avoid asking the same thing.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #985

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x ] PR is based off the current tip of the main branch.
[ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
[ ] New or modified sections of values.yaml are documented in the README.md
[ x] Commits follow the Kong commit message guidelines

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Martin Chlumsky seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

We're trying to use the docs site for chart info more often, and since it's where the other compatibility info lives, going with https://github.com/Kong/docs.konghq.com/pull/6985 instead.


Check Muted Crashes Program

`
TypeError: Converting circular structure to JSON
--> starting at object with constructor 'FSWatcher'
| property '_nodeFsHandler' -> object with constructor 'NodeFsHandler'
--- property 'fsw' closes the circle
at JSON.stringify ()
at stringify (/usr/local/share/twitchautomator/server/node_modules/express/lib/response.js:1150:12)
at ServerResponse.json (/usr/local/share/twitchautomator/server/node_modules/express/lib/response.js:271:14)
at ServerResponse.send2 (/usr/local/share/twitchautomator/server/node_modules/express/lib/response.js:162:21)
at CheckMute (/usr/local/share/twitchautomator/server/src/Controllers/Vod.ts:260:9)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
Node.js v17.9.1
`

odd how these starting popping up just now

I also had an issue, when it crashed, a VOD was downloading and now I'm stuck here: https://i.tony.pm/Mdt38VO.png
What should I do to delete that and re-download the VOD?

probably best off deleting the json file for it and restarting the server


Library scope

I would be good to nail down some questions regarding the scope of this library. Specifically:

Should it support functions added to the JS Math object in ES6?
Should it support other useful math functions and constants?

The function Math.random() is not supported and I think that leaving it out is uncontroversial.
On 1, the library currently supports the ES6 functions imul and trunc with polyfills but no others. So we have some options:
1a. Strictly no ES6. Remove imul and trunc
1b. No changes. Leave imul and trunc but add no others
1c. All ES6. Add all missing functions (except random). This would fix issue #25.
There are currently two open PRs (#19 and #21) that contribute some ES6 functions. They have been open for some time. I'm not sure why they haven't been accepted but the polyfills have some overflow issues. I recently released purescript-math-es6 which contains all ES6 functions with robust polyfills. The project purescript-math-es6-quality lets you see how well the polyfills match native values in Node.js and the browser. purescript-math-es6 could be merged into this library if full ES6 support is required.
My vote is 1c achieved by merging purescript-math-es6. But I am biased.
On 2, the library currently supports the function remainder/% and the value tau which are not properties or methods of the Math object. PR #29 would add the golden ratio as another constant. Similar to 1 we have three options:
2a. Strictly Math properties and methods. Remove remainder and tau. Removing remainder would be a significant breaking change
2b. No changes. Leave remainder and tau but reject the golden ratio and make it clear in the README that other math functions and constants will also be rejected
2c. Accept the golden ratio and update the README asking for additional math functionality
My vote here is 2b. I think the library should just reflect the JS Math object but the changes from adopting 2a would be too painful. Perhaps we could move remainder to Data.Number and add depreciation warnings to remainder and tau so we can eventually remove them.
Thoughts?

Generally, one concern core libraries have is whether adding some functionality will make it harder for non-JS backends to support that.

I think this library is in a weird place, but I don't have good answers for these questions either. I used to be a supporter of "it's just the Math object in JS", but that's muddied with ES6/2021 and the non-JS additions you mentioned. It seems like if we were going to move away from that, it should perhaps implement at least some things over our numeric classes rather than being specialised to Number too.
I almost never find myself using this library, due to the nature of the things I work on these days, so my opinion probably shouldn't hold as much weight as those who are heavy users of it.

I think that in the past, having core libraries closely follow JS APIs made sense, but now that PureScript is more mature and especially now that there are alternative backends, we shouldn’t follow JS APIs too closely. For example, the strings and globals libraries have been moving away from closely following the JS API more recently. In my view the most important concern is whether we have a well designed library which allows PureScript users to do the things they need to do with a minimum of fuss.
I personally think that we could consider giving this library a similar treatment as globals. Most of the functions here could sensibly live in Data.Number, particularly the trig functions and constants and the logarithm stuff. One or two are obsoleted by more general functions which exist in Prelude - namely min, max, and abs. The imul function is unique in that it works on Int rather than Number, so that could go into Data.Int (or ideally into Int’s Semiring instance, but that’s slightly harder, see https://github.com/purescript/purescript/issues/2980).
I am hesitant to introduce a type class for trig functions or logarithms, because it’s hard for me to imagine demand for them. I’m not aware of numeric types other than Number which would support those operations. Haskell needs the Floating class because it has both Float and Double, but we only have Number. It is slightly easier to imagine type classes for sqrt and rounding  functions, but I think that can be addressed separately from the question of where these functions should live.

I agree with @hdgarrood regarding type classes. Many of the functions currently in Math would require new type classes.  It seems silly to have type classes whose only instances are Number and, even then, that instance isn't fully law abiding. Even min and max are different to the Data.Ord versions -- specifically in their handling of NaN. I think we preserve all these number-only versions in Data.Number until someone implements algebraic numbers or something where a type class would occur naturally.

From this discussion is sounds like:
(A) We should prioritize supporting multiple backends by minimizing the number of functions a new backend needs to implement
(B) We should move various functions into more sensible places, likely resulting in this library being deprecated at some point
I'd like to add a third priority, if I may:
(C) We should avoid doing anything that makes writing high-performance numeric code harder than it is now
These suggest the following steps:

Move all constants to Data.Number.Constants as explicitly defined constants. So instead of foreign import pi :: Number we have pi = 3.141592653589793. We would have to check that our constants are identical to the Javascript native ones but that should be easy.
Identify "core" math functions that we expect every backend to support and provide copies in Data.Number. I propose: acos, asin, atan, sin, cos, tan, exp, log, pow ,sqrt, and remainder/%. All of these are likely to be available in standard math libraries for most backends and would require fairly complex Purescript implementations.
Identify "branchless" functions that we require the backend to support. Although these could be implemented in terms of other functions, it would introduce an unnecessary (and slow) branch, whereas native implementations are likely to avoid that. I propose: min, max, abs and sign. That's only four functions and backends are likely to have easily available versions.
Copy integer related functions into Data.Int. This would include imul, round, ceil and floor. The versions of round, ceil and floor already in Data.Int are currently implemented in terms of Math. Only the Data.Int versions, with type Number -> Int would be available after Math is deprecated. Users wanting Number -> Number versions would have to convert back from Int, which I think is fine. trunc would be implemented in Purescript in terms of ceil and floor in Data.Int
Implement all other functions as Purescript functions in terms of the functions above. Once atan2 is implemented, Math could be depreciated. Functions from ES6 and others could be implemented at our leisure.

Together this would reduce the burden on new backends by reducing the number of functions they need to implement slightly versus the current situation (dropping all constants, atan2 and trunc) and dramatically versus the ES6-with-polyfills approach. By eventually depreciating Math it also removes a psychological association with Javascript. The functionality currently demanded in various issues and pull-requests would eventually be provided, albeit without a definite timetable.

I was going to suggest something about checking that atan(y/x) behaves identically to atan2(y, x)... but actually I think that's overkill - I'd be pretty surprised if there is an observable difference between the two that anyone is depending on, and if they are I'd suggest a separate JS-specific library / project-local FFI function can be introduced to deal with that again.
So yeah, the proposal above sounds good to me!

I agree, except:

I don’t think we should remove the Number -> Number rounding functions; I think they are useful often enough that they are worth providing, and also the range of Number is much larger than that of Int, so it’s not possible to recover the same behaviour for numbers outside of the Int range.
I think atan2 should be one of the “core” math functions, because you’d need to branch to implement it in terms of atan. atan2(y, x) is not the same as atan(y/x) because the latter can’t return angles in all four quadrants; see https://stackoverflow.com/a/12011762

Can you please list the other “non-core” functions which we’d implement in PureScript, just to make sure we are on the same page?

Oh also, I think constants don’t need to go in a separate module. I think it would be annoying to have to add another import just to use pi, so I’d personally rather they just go in Data.Number.

Ah, great point on atan2, I had a dormant inclination there was something special about it, hence my earlier comment, but couldn't dredge up why it actually mattered.

Ok. I agree we can:

Have ceil, floor and round in Data.Number and have the Data.Int versions use those
Put the constants in Data.Number directly rather than Data.Number.Constants

"Non-core" functions would come in three phases:

Those necessary to be able to deprecate purescript-math. That is just atan2 in Data.Number (if we go that way) and trunc in Data.Int.
Those necessary to replicate the functionality of the new ES6 functions attached to the Math object. That is the hyperbolic trignometric functions (acosh, asinh, atanh, cosh, sinh, atanh), logs to other bases (log2 and log10) and numerical stability functions (hypot, log1p and expm1). I don't see a need for cbrt, clz32 or fround but they could be implemented if someone is interested (and being able to leave them out is an advantage of moving away from the "it's just the Math object in JS" approach). The repo purescript-math-es6 has Javascript polyfills taken from MDN for all these functions which could be fairly easily converted to Purescript but I'd like to take the process slow and ensure that only very robust and stable versions are implemented.
Any other functions that sensibly fit in Data.Number. I would suggest the log-gamma function, the error function, the inverse error function and the complementary error and inverse error functions. These all have type Number -> Number and are general enough that they probably belong in Data.Number. I would oppose putting the cdf or pdf of any particular probability distribution in Data.Number, however.

Wikipedia suggests a branchless implementation of atan2 as ((sign x) ^ 2) * atan(y / x) + (1 - sign y + (sign y) ^ 2) * pi / 2.0.
I haven't checked this in detail yet.
Can we leave atan2 in the category of "branchless Purescript if a robust implementation is available, provided by the backend otherwise". I'll try to come up with a PR at some point just for a branchless atan2 and you guys can accept or reject it at that point based on its merits.
Or is that not worth it and we just punt it off to the backend?

Screw it. The Wikipedia approach gives atan2(0, 0) == NaN whereas both the Node and Chrome versions give atan2(0,0) == 0. Building an exactly matching branchless version will be a pain so I recant and now agree with @hdgarrood that atan2 should be implemented by the backend.

Summarizing https://github.com/purescript/purescript-math/issues/31#issuecomment-899776481, it seems that to fully deprecate this repo, we need to
Add/change the following to numbers:

ceil, floor, and round - done in https://github.com/purescript/purescript-numbers/pull/18
atan2 (needed to deprecate purescript-math) - done in https://github.com/purescript/purescript-numbers/pull/18
Replicate ES6 functions added to Math object: (all of the functions below have not yet been done in https://github.com/purescript/purescript-numbers/pull/18)

add hyperbolic trignometric functions: acosh, asinh, atanh, cosh, sinh, atanh
add logs to other bases: log2 and log10
add numerical stability functions: hypot, log1p and expm1

Add/change the following to integers:

ceil, floor, and round, which use the numbers version before convert back to Int
trunc (needed to deprecate purescript-math) - this needs to be added in a new PR

The rest is something that could be done but isn't needed.
Functions that could belong in numbers:

log-gamma function, error function, inverse error function, the complementary error function, and inverse error function.

Up for grabs / could be implemented by other libraries:

cbrt, clz32 or fround
cdf or pdf of any particular probability distribution

All code in math has been ported to purescript-numbers and purescript-integers


Compatibility issue with pluggy 1.4

pytest-raises has been my trusted companion for many years now. Since pluggy 1.4, however, old-style hook wrappers cause test failures.
pluggy.PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.

There is a discussion at https://github.com/pytest-dev/pytest/discussions/11858, for example, that mentions potential approaches.

@svenevs @Lemmons I'm seeing this as well - I can take a stab at it to try and find a solution, but I wanted to check in. Are you two around for possibly deploying a new version as well? There's some maintenance that might be beneficial for the project (since the last release was in 2020). Happy to pitch in on that if you'd like 🙂

Hey team, I'm happy to try and look into this on Sunday. Generally this plugin is intended to be feature complete / low maintenance, but it does appear it's time for a facelift.
I haven't had time to dig into what's going on, but from a brief skim of the linked issue it does seem like we've got a viable path forward. @AetherUnbound if you have time to get a prototype working I can definitely review and make sure the packaging requirements are updated etc.
Thank you @Midnighter for the detailed report and link to the discussion!


FixTraderEvents

I created this pull request to fix an issue that caused a conflict on my mod. I already fixed the conflict on my end, but you might still want to make an adjustment on yours.

Small note of warning. I did not actually test this on your mod, but I use exactly the same approach on my mod. Perhaps run a quick test, just to be sure :)


Clarify origin/direction

In regards to the data-menu-origin option, I think it is worth mentioning that this is only used by the styling layer and that this is not used at all by the library itself. I would probably even remove it from the example (to keep it minimal), and add a section for that in the documentation. Right it feels like the library expects this very attribute while it’s just as good of a styling hook as anything else.
Side note, maybe overflow-direction might be a better name? What about using start and end to accomodate to RTL rather than left and right?

Closing for now, as I've renamed it to data-menu-from.


chore(deps): Update Dockerfile

Description
Updates

Update Go inside Dockerfile to 1.22.4 (security fixes to the go command and crypto/x509, html/template, net/http, net/http/cookiejar, net/mail, net/netip and archive/zip)
Update protoc-gen-go to 1.34.1 and protoc-gen-go-grpc to 1.4.0 (fixes CVE-2024-24786)
Update CUDA to 11.8
Update grpc to 1.64.2 (fixes CVE-2023-44487)
Update protoc to 27.1

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

The next one will be much bigger 😅
29 security fixes, not counting other Dockerfiles and upstream projects which have not accepted update PRs yet 🔒

@mudler Can you explain shortly why all AI projects use the 2 years old CUDA 11.7 instead of 12.5?
Wouldn't it allow better and faster acceleration? Which AI developer would not update his CUDA stack to the exciting latest version? 🤔
I would expect that at least official Dockerfiles would use it, even if the local build would use the ancient version (out of compatibility reasons?)...

@mudler Can you explain shortly why all AI projects use the 2 years old CUDA 11.7 instead of 12.5? Wouldn't it allow better and faster acceleration? Which AI developer would not update his CUDA stack to the exciting latest version? 🤔 I would expect that at least official Dockerfiles would use it, even if the local build would use the ancient version (out of compatibility reasons?)...

compatibility reason mostly - there are many Nvidia HW around that aren't compatible at all with 12. For instance , I even have a jetson nano here that is stuck at 10 (!).
However, would make sense to "default" when running build to 12 - but keeping releasing 11 along for those that have an older HW.

 The next one will be much bigger 😅 29 security fixes, not counting other Dockerfiles and upstream projects which have not accepted update PRs yet 🔒

Thank you! really much appreciated!


feat: add personal page

Description
Add personal page for 0x38D9cFf58D233AF0B9c1434EEDE012009D23c971
Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Related Issues
_Closes #8
Your ENS/address: miralsuthar.eth

This is looking great @miralsuthar
Love the big Address component and the map over the socials object ;)
Left a comment regarding a type... but this lgtm!! :rocket:


No characters being decoded

Describe the bug
No characters displayed / Decoded
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-6vz8cr
Steps to reproduce
click on "Start"
Allow Microphone
Expected behavior
Decoded morse characters
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 57105933,
  "usedJSHeapSize": 52931669,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Sparks72
Chat ID = 423da74c398c

Additional context
No response

While we’re committed the success of our users, unfortunately we aren’t equipped to offer one-on-one engineering support for individual coding projects.There are some excellent resources in #678 that others have found helpful in advancing their skills and building complex applications on the platform.


Possible new project: IRC Client (application development)

A possible idea for a new project:  ChatteRS, an IRC Client (application development)
This isn't a PR, because I think it needs a bit of discussion first.  Is this type of project unique enough?.  But if we agree, I'm happy to convert this into a PR

What is this?
"ChatteRS" is an IRC client (designed as an application to be run as a desktop application).  This application might be purely text-based, or it could have a graphical user interface
Description
This IRC client doesn't aim to have the worlds fanciest features, or the slickest interface.  But it strives to have a solid, small, easy-to-read codebase that can be easily developed, maintained, and extended over time.
🤔 Frequently Asked Questions

What makes this project different from others?

[see discussion below]

Does this project require a custom tailored runtime?

No, pretty much any off-the-shelf runtime can work here

How much of this project is likely to be built with open source components from crates.io?

Probably as much as possible.  Things like a low-level IRC library, and a GUI/TUI library are very likely to be found on crates.io and would be used in this project.

What is of most concern to this project?

Ease of development and easy-to-understand code

What is of least concern to this project?

Performance

When thinking about a new project, asking "how is it different than the others" is probably the most important point.  I think I see the following differences:  there isn't a need for a custom runtime or custom futures, or anything really performance sensitive, this isn't a library, but an application that will do a "async-like" things (like reading from the network, getting user input).  So it's likely to lean heavily on the ecosystem (crates.io) to provide a lot of functionality.
There's nothing fundamentally important about this project being an IRC client (I think any type of "desktop application" could fit in here), but I thought that an IRC client was a familiar example to a lot of people, and it represents a certain type of real-world application that often just "glues" together existing pieces of functionality, with some fairly simple "business logic" or "application logic" sitting in the middle.  So with this in mind, one possible way to focus/target is to focus on this "glue" aspect -- can rust async easily glue together a bunch of different async libraries into 1 cohesive application?
This new project is probably most similar to the existing "YouBuy (Traditional Server Application)" project in that both don't need custom/tailored runtimes, both don't need tight control of performance, both want to rely heavily on the crates.io ecosystem.   I do sometimes hear complaints like "rust async only cares about network servers", so I wonder if some type of desktop application might help assuage those concerns (though maybe "SLOW" and "DistriData" already fill that role well enough)
Lastly, I wonder if each project should have an FAQ entry titled "Why is this project written in async rust?" where we can explain why we think rust is a good fit for  this particular project.  Each of the current projects probably already have a successful real-world version that's not written in rust (indicating that rust isn't the only suitable language for each of these projects).   For this "ChatteRS" project, I think the answer to "why is this project written in async rust" is something like:  rust's strong type system and focus on correct code can help the project reduce the number of bugs.  Even though the project is not performance-focused, rust general reputation of being "not wasteful" with resources is useful.  The strength of the crates.io ecosystem is also a big draw here

Hmm, this is a nice idea, and I like the name. I'm wondering if it'd be a good project to use when talking about issues like https://github.com/rust-lang/wg-async-foundations/issues/54? Seems like quite plausibly.

Yeah, I think you are right.  I could easily imagine you'd have an async IRC library and a sync TUI library, and you need to glue/bridge them together in a cohesive way.  You want to be able to use the best crates from crates.io, but don't really care of those crates are async or not.


decode

Does the yolov7 have any change for decode and preprocess?

Not sure what your question is.


Add locale handling for the ondrej/php ppa

The php ppa wouldn't install owing to this issue:
https://github.com/oerdnj/deb.sury.org/issues/56
The fix is as described in this post:
https://github.com/oerdnj/deb.sury.org/issues/56#issuecomment-138310602

Closing as this can now be done via apt-env.


Export-DbaDbRole - Fixed variable usage and verbose output

Type of Change

[x] Bug fix (non-breaking change, fixes #7287, fixes #7285 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Fixed wrong variables for old versions and improved verbose output.

Merci 🙇🏼

oh hey @andreasjordan - anytime you see $script as a variable, can you change it to anything else? we forgot when writing the commands that $script is a reserved variable .


⚠ ClamAV has degraded performance

In b7b6dae, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in b4c16af after 537 days, 13 hours, 39 minutes.


[BUG][Blob] OffsetRecord Metadata is not transferred during blob transfer

Willingness to contribute
No. I cannot contribute a bug fix at this time.
Venice version
All
System information

OS Platform and Distribution (e.g., Linux Ubuntu 20.0): All
JDK version: JDK 17

Describe the problem
Current implementation does not transfer OffsetRecord metadata (as well as StoreVersionState metadata) from the blob provider. When blob transfer is completed and we resubscribe to Kafka Topic, StoreIngestionTask will have no information of the current progress and we will have to restart from scratch.
The straightforward solution to this issue is to ask the source provider to transfer OffsetRecord and StoreVersionState during the transfer and when we reopen the RocksDB we will add such information to the system.
Tracking information
No response
Code to reproduce bug
No response
What component(s) does this bug affect?

[ ] Controller: This is the control-plane for Venice. Used to create/update/query stores and their metadata.
[ ] Router: This is the stateless query-routing layer for serving read requests.
[X] Server: This is the component that persists all the store data.
[ ] VenicePushJob: This is the component that pushes derived data from Hadoop to Venice backend.
[ ] VenicePulsarSink: This is a Sink connector for Apache Pulsar that pushes data from Pulsar into Venice.
[ ] Thin Client: This is a stateless client users use to query Venice Router for reading store data.
[ ] Fast Client: This is a stateful client users use to query Venice Server for reading store data.
[X] Da Vinci Client: This is an embedded, stateful client that materializes store data locally.
[ ] Alpini: This is the framework that fast-client and routers use to route requests to the storage nodes that have the data.
[ ] Samza: This is the library users use to make nearline updates to store data.
[ ] Admin Tool: This is the stand-alone client used for ad-hoc operations on Venice.
[ ] Scripts: These are the various ops scripts in the repo.

Close the issue as it is funded internally


Add "Custom Top-Bar" Instead Of Native Top-Bar

Just like the Twitch Desktop app, Twitchy should have a custom and fancy looking top-bar.
Requirements:

Dragable
"Close", "Minimize", "Maximize" options (Right side)
"Settings", "Notifications" (Left Side 1st col)
"Previous Page", "Next Page", "Reload" (Left Side 2nd col)

Updated with more options.

Updated and instead of opening the settings menu it should display a selection of options.

I would like to include page settings like "history" and "view" settings in the right click dialog and only have those mentioned options.


Add a way to extract an ONNX file

First of all, thanks a lot for this amazing project and your hard work!
In https://github.com/burn-rs/burn we are trying to load different ONNX models, convert them into burn models, and then use them on different backends. It would be fantastic if we could try your model too. Can you add a way to extract the ONNX model? Using PyTorch is quite feasible.
Thanks a lot in advance!

Hi, thank you for paying attention to our work! You can download our models from here and convert it into ONNX. We may do not have enough space to upload another copy of the models.


lib: use SBI 2.0 DBCN extension

The legacy console is deprecated dated back to SBI version 0.2; latest firmware doesn't properly support legacy SBI extensions. This commit replaces it using latest SBI DBCN extension in RISC-V SBI 2.0 (some code is simplified as well during this process).
r? @xiaoyang-sde

Thanks for your contribution! Recently I've been dealing with various projects and life events, so my availability to work on this project might be limited. When I initially wrote this project, my understanding of operating systems and Rust was limited. Hence, I'm thinking about rewriting it in the future. If that occurs, I'm happy to accept your pull request.