LXD lose snapshot after creating containers from them, if using zfs, and deleting containers

I am having issues when creating containers from snaphots, when using lxd with
zfs as backstorage.  I can create the container, but when I delete it, the
snapshot gets deleted at zfs level (not at lxd).
I am using lxd in Ubuntu 16.04, and the funny thing is that does not happen in
every box: some work fine, others never did, and others worked fine for a while
and then broke.
I wonder now if creating containers from snapshots is legit, or if operation
semantics are unspecified.
This can be seen in this example
$ lxc launch ubuntu:14.04 mycontainer
$ lxc stop mycontainer
$ lxc snapshot mycontainer mysnap0
$ lxc copy mycontainer/mysnap0 mycontainer1
$ lxc delete mycontainer1
$ lxc copy mycontainer/mysnap0 mycontainer2
error: rsync failed: rsync: change_dir "/var/lib/lxd/snapshots/mycontainer/mysnap0" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1]

But lxd still thinks the snapshot is good.
$ lxc info mycontainer
Name: mycontainer
Architecture: x86_64
Created: 2016/06/16 10:53 UTC
Status: Stopped
Type: persistent
Profiles: default
Snapshots:
  mysnap0 (taken at 2016/06/16 10:54 UTC) (stateless)

Another example that makes me think is lxd who request zfs to delete the snapshot:
$ lxc snapshot mycontainer mysnap1
$ lxc copy mycontainer/mysnap1 mycontainer2
$ lxc copy mycontainer/mysnap1 mycontainer3
$ lxc delete mycontainer2
error: Failed to destroy ZFS filesystem: cannot destroy 'debtool/containers/mycontainer@snapshot-mysnap1': snapshot has dependent clones

And some info on the versions I use:
zfs-zed                   <IP_ADDRESS>-0ubuntu8
zfsutils-linux            <IP_ADDRESS>-0ubuntu8
lxd                       2.0.2-0ubuntu1~16.04.1
lxd-client                2.0.2-0ubuntu1~16.04.1
lxd-tools                 2.0.2-0ubuntu1~16.04.1
liblxc1                   2.0.0-0ubuntu2
lxc                       2.0.0-0ubuntu2
lxc-common                2.0.0-0ubuntu2
lxc-templates             2.0.0-0ubuntu2
lxc1                      2.0.0-0ubuntu2
lxcfs                     2.0.0-0ubuntu2.1

$ lxc info
apicompat: 0
auth: trusted
environment:
  addresses:
  - <IP_ADDRESS>:8443
  architectures:
  - x86_64
  - i686
  driver: lxc
  driverversion: 2.0.0
  kernel: Linux
  kernelarchitecture: x86_64
  kernelversion: 4.4.0-15-generic
  server: lxd
  serverpid: 9200
  serverversion: 2.0.2
  storage: zfs
  storageversion: "5"
config:
  core.https_address: <IP_ADDRESS>:8443
  core.trust_password: true
  storage.zfs_pool_name: debtool
public: false

$ lxc copy --debug mycontainer/mysnap0 mycontainer4
DBUG[06-16|13:22:43] Raw response: {"type":"sync","status":"Success","status_code":200,"metadata":{"api_extensions":[],"api_status":"stable","api_version":"1.0","auth":"trusted","config":{"core.https_address":"127
.0.0.1:8443","core.trust_password":true,"storage.zfs_pool_name":"debtool"},"environment":{"addresses":["<IP_ADDRESS>:8443"],"architectures":["x86_64","i686"],"certificate":"-----BEGIN CERTIFICATE-----\nMIIFdDCCA1ygAw
...
--END CERTIFICATE-----\n","driver":"lxc","driver_version":"2.0.0","kernel":"Linux","kernel_architecture":"x86_64","kernel_version":"4.4.0-15-generic","server":"lxd","server_pid":9200,"server_version":"2.0.2","stor
age":"zfs","storage_version":"5"},"public":false}}

DBUG[06-16|13:22:43] Raw response: {"type":"sync","status":"Success","status_code":200,"metadata":{"architecture":"x86_64","config":{"volatile.base_image":"d02d6cf5a494df1c88144c7cbfec47b6d010a79baf18975a7c17abbf3
1cbae40","volatile.eth0.hwaddr":"00:16:3e:a6:d4:53","volatile.last_state.idmap":"[{\"Isuid\":true,\"Isgid\":false,\"Hostid\":427680,\"Nsid\":0,\"Maprange\":65536},{\"Isuid\":false,\"Isgid\":true,\"Hostid\":427680,
\"Nsid\":0,\"Maprange\":65536}]"},"created_at":"2016-06-16T12:54:20+02:00","devices":{"root":{"path":"/","type":"disk"}},"ephemeral":false,"expanded_config":{"volatile.base_image":"d02d6cf5a494df1c88144c7cbfec47b6
d010a79baf18975a7c17abbf31cbae40","volatile.eth0.hwaddr":"00:16:3e:a6:d4:53","volatile.last_state.idmap":"[{\"Isuid\":true,\"Isgid\":false,\"Hostid\":427680,\"Nsid\":0,\"Maprange\":65536},{\"Isuid\":false,\"Isgid\
":true,\"Hostid\":427680,\"Nsid\":0,\"Maprange\":65536}]"},"expanded_devices":{"eth0":{"name":"eth0","nictype":"bridged","parent":"lxdbr0","type":"nic"},"root":{"path":"/","type":"disk"}},"name":"mycontainer/mysna
p0","profiles":["default"],"stateful":false}}

DBUG[06-16|13:22:43] Posting {"config":{},"ephemeral":false,"name":"mycontainer4","profiles":["default"],"source":{"source":"mycontainer/mysnap0","type":"copy"}}
 to http://unix.socket/1.0/containers
DBUG[06-16|13:22:43] Raw response: {"type":"async","status":"Operation created","status_code":100,"metadata":{"id":"58c11824-a5ba-4ba5-a5d2-5f14984804e7","class":"task","created_at":"2016-06-16T13:22:43.391166781+
02:00","updated_at":"2016-06-16T13:22:43.391166781+02:00","status":"Running","status_code":103,"resources":{"containers":["/1.0/containers/mycontainer4","/1.0/containers/mycontainer/mysnap0"]},"metadata":null,"may
_cancel":false,"err":""},"operation":"/1.0/operations/58c11824-a5ba-4ba5-a5d2-5f14984804e7"}

DBUG[06-16|13:22:43] 1.0/operations/58c11824-a5ba-4ba5-a5d2-5f14984804e7/wait
DBUG[06-16|13:22:43] Raw response: {"type":"sync","status":"Success","status_code":200,"metadata":{"id":"58c11824-a5ba-4ba5-a5d2-5f14984804e7","class":"task","created_at":"2016-06-16T13:22:43.391166781+02:00","upd
ated_at":"2016-06-16T13:22:43.391166781+02:00","status":"Failure","status_code":400,"resources":{"containers":["/1.0/containers/mycontainer4","/1.0/containers/mycontainer/mysnap0"]},"metadata":null,"may_cancel":fa
lse,"err":"rsync failed: rsync: change_dir \"/var/lib/lxd/snapshots/mycontainer/mysnap0\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) a
t main.c(1183) [sender=3.1.1]\n"}}

error: rsync failed: rsync: change_dir "/var/lib/lxd/snapshots/mycontainer/mysnap0" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1]

Ok, so it doesn't look like LXD actually lost anything, instead it looks like it's got an extra temporary snapshot around which is blocking things.
Can you paste the output of "zfs list -t all" on an affected system?

Output of zfs list -t all (the one named mycontainer is the one with a no longer working snapshot, as I did the steps I described above):
NAME                                                                                USED  AVAIL  REFER  MOUNTPOINT
debtool                                                                                4,70G  24,1G    19K  none
debtool/containers                                                                                1,38G  24,1G    19K  none
debtool/containers/debtool-precise-base                                                                     381M  24,1G   868M  /var/lib/lxd/containers/debtool-precise-base.zfs
debtool/containers/debtool-precise-base@snapshot-debtool-precise-snapshot                                  3,84M      -   868M  -
debtool/containers/debtool-trusty-base                                                                      385M  24,1G   806M  /var/lib/lxd/containers/debtool-trusty-base.zfs
debtool/containers/debtool-trusty-base@snapshot-debtool-trusty-snapshot                                       1K      -   806M  -
debtool/containers/debtool-xenial-base                                                                      475M  24,1G   975M  /var/lib/lxd/containers/debtool-xenial-base.zfs
debtool/containers/debtool-xenial-base@snapshot-debtool-xenial-snapshot                                       1K      -   975M  -
debtool/containers/lxctest                                                                                167M  24,1G   867M  /var/lib/lxd/containers/lxctest.zfs
debtool/containers/mycontainer                                                                             7,54M  24,1G   572M  /var/lib/lxd/containers/mycontainer.zfs
debtool/deleted                                                                                1,42G  24,1G    19K  none
debtool/deleted/containers                                                                                813M  24,1G    19K  none
debtool/deleted/containers/5df6b116-673e-4fdc-8a73-a7cfedfc9ff8                                             474M  24,1G   972M  none
debtool/deleted/containers/5df6b116-673e-4fdc-8a73-a7cfedfc9ff8@copy-9542b6f8-6caa-4f1c-9b96-2846767ede9f   999K      -   972M  -
debtool/deleted/containers/b55c7d38-8b51-4b08-92cc-11f19c626e98                                             339M  24,1G   832M  none
debtool/deleted/containers/b55c7d38-8b51-4b08-92cc-11f19c626e98@copy-63b474dc-209f-40bb-91ef-d443425c2b1b   385K      -   832M  -
debtool/deleted/images                                                                                640M  24,1G    19K  none
debtool/deleted/images/d23ee1f4fd284aeaba6adeb67cccf7b871e96178d637fec96320aab7cc9634b1                     640M  24,1G   640M  none
debtool/deleted/images/d23ee1f4fd284aeaba6adeb67cccf7b871e96178d637fec96320aab7cc9634b1@readonly               0      -   640M  -
debtool/images                                                                                1,89G  24,1G    19K  none
debtool/images/98dc4bd7cca2fcd24c82ee403baaca3a5bd1845f925540786d0954a5973c181c                             643M  24,1G   643M  /var/lib/lxd/images/98dc4bd7cca2fcd24c82ee403baaca3a5bd1845f925540786d0954a5973c181c.zfs
debtool/images/98dc4bd7cca2fcd24c82ee403baaca3a5bd1845f925540786d0954a5973c181c@readonly                       0      -   643M  -
debtool/images/d02d6cf5a494df1c88144c7cbfec47b6d010a79baf18975a7c17abbf31cbae40                             571M  24,1G   571M  /var/lib/lxd/images/d02d6cf5a494df1c88144c7cbfec47b6d010a79baf18975a7c17abbf31cbae40.zfs
debtool/images/d02d6cf5a494df1c88144c7cbfec47b6d010a79baf18975a7c17abbf31cbae40@readonly                       0      -   571M  -
debtool/images/fa13d1486d449e960c6adaf02a225ac1d56e5a52228e145c9e32a26abf760455                             718M  24,1G   718M  /var/lib/lxd/images/fa13d1486d449e960c6adaf02a225ac1d56e5a52228e145c9e32a26abf760455.zfs
debtool/images/fa13d1486d449e960c6adaf02a225ac1d56e5a52228e145c9e32a26abf760455@readonly                       0      -   718M  -

reproduced the issue, looking into this

Oh wow, that's a pretty serious bug indeed, LXD very much shouldn't consider a snapshot-* snapshot as being deletable...


KProcesshacker verify.c bug

verify.c
NTSTATUS KpiVerifyClient(
    _In_ PVOID CodeAddress,
    _In_reads_bytes_(SignatureSize) PUCHAR Signature,
    _In_ ULONG SignatureSize,
    _In_ PKPH_CLIENT Client
    ){
//......
    KphVerifyClient(Client, CodeAddress, Signature, SignatureSize);
//.....

KphVerifyClient(Client, CodeAddress, Signature, SignatureSize);
should be
KphVerifyClient(Client, CodeAddress, signature, SignatureSize);

Good catch! Thank you for reporting this! 👍
I've been playing with the code and it doesn't seem to be exploitable or impact client verification in any way which is very lucky and I'm following this up with some researchers to see if they might be able to do something with it.
Kinda funny too. Over the last 6 months we've had conversations with Avast, Kaspersky and Sophos who reviewed this very code and they didn't spot that bug 😄
If you're able to exploit this or introduce a crash/blue screen then please let us know since any driver crashes/blue screen issues are a CVE that require public disclosure.
Thanks again for reporting this!


People: Two fields to sort by "highest activity"

On https://www.openml.org/search?type=user when I want to sort people I see "Highest Activity" twice:

Thanks.
Fix pushed.
https://github.com/openml/website/pull/174


Small fix to be able to use mac and vendor in "device_tracker_new_device" event.

Description:
I had an automation to notify me when a new device is found on the network, but because NMAP can't find a host_name the notification can only contain the entity id, which isn't very informative. With this patch i can also add the properly formatted MAC address and vendor to the notification.
This does make the  device_tracker_new_device event fire slightly later because it has to wait for the vendor lookup, but that <0.2s delay is worth the added clarity in my opinion.
Checklist:
If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Thanks!


ERROR File is not a zip file with Zipfile

Config file found C:\Users\Ilya.autoortho reading...
Saving config ...
Wrote config file: C:\Users\Ilya.autoortho
INFO:downloader:Looking for regions ...
INFO:downloader:Last release refresh time: 2023-06-05 14:09:00.767733
INFO:downloader:Using cache ...
INFO:downloader:Using scenery dir C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12/Custom Scenery
INFO:downloader:Found region eur version 0.0.51
INFO:downloader: ... eur update is available
INFO:downloader:Found region na version 0.0.49
INFO:downloader: ... na up to date and validated.
INFO:downloader:Found region sa version 0.0.46-1
INFO:downloader: ... sa up to date and validated.
INFO:downloader:Found region afr version 0.0.45-1
INFO:downloader: ... afr up to date and validated.
INFO:downloader:Found region asi version 0.0.44-1
INFO:downloader: ... asi up to date and validated.
INFO:downloader:Found region aus_pac version 0.0.42-1
INFO:downloader: ... aus_pac up to date and validated.
Saving config ...
INFO:aoconfig:Wrote config file: C:\Users\Ilya.autoortho
Wrote config file: C:\Users\Ilya.autoortho
Config file found C:\Users\Ilya.autoortho reading...
INFO:aoconfig:Config file found C:\Users\Ilya.autoortho reading...
INFO:downloader:Download eur
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_00.zip
100.00%   10.82 MBpsINFO:downloader:  DONE!
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_01.zip
100.00%   10.15 MBpsINFO:downloader:  DONE!
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_02.zip
100.00%   10.25 MBpsINFO:downloader:  DONE!
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_03.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_04.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_05.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_06.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_07.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_08.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_09.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_10.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_11.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_12.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_13.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_14.zip
INFO:downloader:We already have https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/z_eur_15.zip
INFO:downloader:ORTHOS DOWNLOADED
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/y_eur_overlays.zip.00
100.00%   10.93 MBpsINFO:downloader:  DONE!
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/y_eur_overlays.zip.01
100.00%   10.82 MBpsINFO:downloader:  DONE!
INFO:downloader:Will download https://github.com/kubilus1/autoortho-scenery/releases/download/0.0.51/y_eur_overlays.zip.02
100.00%   10.47 MBpsINFO:downloader:  DONE!
INFO:downloader:OVERLAYS DOWNLOADED
Setting extract dir to C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12/Custom Scenery
INFO:downloader: ... eur update is available
INFO:downloader:Detected existing scenery dirs for eur.  Cleanup first
INFO:downloader:Ready to extract archives for eur v0.0.51!
INFO:downloader:Split zip detected for ('C:\Users\Ilya\.autoortho-data\downloads\y_eur_overlays.zip',)
INFO:downloader:ZIPNAME C:\Users\Ilya.autoortho-data\downloads\y_eur_overlays.zip
INFO:downloader:Split zip detected for ('C:\Users\Ilya\.autoortho-data\downloads\y_eur_overlays.zip',)
INFO:downloader:ZIPNAME C:\Users\Ilya.autoortho-data\downloads\y_eur_overlays.zip
INFO:downloader:Split zip detected for ('C:\Users\Ilya\.autoortho-data\downloads\y_eur_overlays.zip',)
INFO:downloader:ZIPNAME C:\Users\Ilya.autoortho-data\downloads\y_eur_overlays.zip
INFO:downloader:Cleaning up parts for C:\Users\Ilya.autoortho-data\downloads\y_eur_overlays.zip
INFO:downloader:Cleaning up parts for C:\Users\Ilya.autoortho-data\downloads\z_eur_00.zip
INFO:downloader:Cleaning up parts for C:\Users\Ilya.autoortho-data\downloads\z_eur_01.zip
INFO:downloader:Cleaning up parts for C:\Users\Ilya.autoortho-data\downloads\z_eur_02.zip
INFO:downloader:ERROR: File is not a zip file with Zipfile C:\Users\Ilya.autoortho-data\downloads\z_eur_03.zip.  Recommend retrying
INFO:downloader:Cleaning up parts for C:\Users\Ilya.autoortho-data\downloads\z_eur_03.zip
Errors detected!

Please, fix the issue.

i got the same problem, retryin so many times, still get this error on SA
any help how to fix this?

Same issue here with the latest scenery updates

Go here - https://github.com/kubilus1/autoortho-scenery/releases
There is a new release .52 for the EUR scenery or you can try and re-download the .51 part that says its bad, click on the assets area under the version. Make sure you are running the 4.4 AO program

Solved this by installing the latest version of the exe from github and clearing up the previously downloaded zip files in the download directory. Now it’s working fine

Great!  Thanks for the update!
On Fri, Jul 7, 2023 at 2:34 PM TombBoy @.***> wrote:

Solved this by installing the latest version of the exe from github and
clearing up the previously downloaded zip files in the download directory.
Now it’s working fine
—
Reply to this email directly, view it on GitHub
https://github.com/kubilus1/autoortho/issues/197#issuecomment-1625850839,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVEDLFZUQRNJWPG6IT3YYTXPBJE5ANCNFSM6AAAAAAY22WE3Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

finally it works... thankssss


Python 3.6 support

PyAF only support python 3.5
Need to run all the tests and analyze the possible differnces with python 3.5
Need to update travis-ci
Need to update the docs accordingly after.

travis-ci build is ok again :
https://travis-ci.org/antoinecarme/pyaf/builds/301314212


[type:fix] fix e2e sync time

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #5040 (8474afb) into master (b612264) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

:exclamation: Current head 8474afb differs from pull request most recent head 86134af. Consider uploading reports for the commit 86134af to get more accurate results

@@             Coverage Diff              @@
##             master    #5040      +/-   ##
============================================
- Coverage     64.23%   64.21%   -0.02%
  Complexity     8575     8575
============================================
  Files          1209     1209
  Lines         35909    35909
  Branches       3221     3221
============================================
- Hits          23066    23059       -7
- Misses        10984    10994      +10
+ Partials       1859     1856       -3

see 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update scala intellij tutorial

Description
Fix issues described in #12523
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Update mxnet version
[x] Added dependencies to pom.xml
[x] Log4j configuration file
[x] Instructions for integrating a build from source

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@lanking520 @andrewfayres @aaronmarkham

Thanks @zachgk for fixing the instructions. Can you please address the comments provided?

@nswamy Can you please add label [pr-awaiting-response]?


Add on_startup_completed (name pending)

So that users can find out when it's safe to call other components and stuff.

Other possible names:
on_fb2k_initialization_done
on_fb2k_initialized
on_fb2k_ready

Note to self: implementing such callback might be impossible. Investigate if it's possible to create at least a bool check, smth like IsFoobarReady(). IsInitializing() method in fb2k API might be the one.

i've stumbled upon something hopefully useful:
the init_stage_callback impl. in dllmain.cpp could have stages that could be used for such a thing
https://github.com/TheQwertiest/foo_spider_monkey_panel/blob/00b8cee40801f9594fcb45fbd578e9b91c1304a3/foo_spider_monkey_panel/dllmain.cpp#L144-L150
these are the stages available:

before_config_read
as of now, this is the only stage utiliized

after_config_read

before_library_init

after_library_init
this would be my candidate, as per Peter's  comment in the source:

since foobar2000 v2.0, after_library_init is fired out of order with the rest, after asynchronous library init has completed.

before_ui_init

after_ui_init
personal note: this  one could be used for first execution frame (with the scripts being already loaded/compiled), as to have the panel widths/height etc readily avaliable from the script-global context on script load.

see: https://github.com/TheQwertiest/foobar2000-sdk/blob/238dfd951322d07b0288c751c6aedd555bb620cb/SDK/initquit.h#L22-L32

Note to self: use after_ui_init stage for the corresponding event ('initStageComplete'? args or always after_ui_init?)


Create functionality for posting/getting tasklists

Add functionality to allow new tasklists to be posted, and for existing tasklists to be returned (alongside the tasks that the tasklist owns).
Functions created in client to make these requests. A method is currently added to the client that will 1) add a new tasklist (with the name = the current date (in current time zone) in UTC time and 2) get all of the tasklists and print them to console.
Currently this prints out twice (and makes two new tasklists), due to issue #97. This will be resolved in a later PR
Console Output (See two empty tasklists):

Google tasks view (see two tasklists with timestamps as names):

Dependent on PR #87

@austinteshuba after MVP, base this off of master and handle the merge conflicts.
Also, consider making a PR for a super class for the tasks tests to hold the constants.


feat: add refstack 2022.11 tests

The tests include aliases and flagged tests of the required and advisory suite for all of the platforms

Should we add more than one refstack list of tests?

So the 2022.11 version (also called next) is corresponding the releases: antelope, zed, yoga, xena and has a status of Draft. Since this is the master branch and eventually the built snap is released on the latest/edge channel. I felt this is the appropriate list to include in the snap. The older lists seem to be more appropriate for the stable branches, should we decide to introduce any.

What would be the downside to adding all lists from 2020.11 (last approved list for Ussuri) onward?

What would be the downside to adding all lists from 2020.11 (last approved list for Ussuri) onward?

The downside is that we would expect the user to know which refstack version to use depending on their cloud. If that is acceptable, I can update the PR accordingly. However since we are moving towards maintaining multiple branches for releases, maybe we can commit the corresponding refstack list for that particular release on that branch?

What would be the downside to adding all lists from 2020.11 (last approved list for Ussuri) onward?

The downside is that we would expect the user to know which refstack version to use depending on their cloud. If that is acceptable, I can update the PR accordingly. However since we are moving towards maintaining multiple branches for releases, maybe we can commit the corresponding refstack list for that particular release on that branch?

I'm not too sure what's the right strategy. On one hand yes, we're saying that the snap will package everything needed to test a specific cloud version, on the other hand we're calling the refstack list refstack-2022.11, not refstack-draft or refstack-Antelope, so it would seem fine to also include older ones (for ease of maintenance).
Anyway, the scope of this PR is only 2022.11 so let's start with that one.


Release Definition Visual Studio Test task v2.* Not finding testing framework when installed with VSTEST Platform installer

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Environment

Server - VSTS or TFS on-premises?  On premises

If using TFS on-premises, provide the version:
2017 update 3
If using VSTS, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:  Private

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:
version 2.133.3  Windows 2016

Issue Description
When using the Release pipeline with  the VStest Platform Installer task installing the latest framework version.  When the VSTEST task run after it can not find the framework the prior task installed
Looks like the VStest Platform Installer task sets a variable to the path of the product and the VSTEST  task uses that variable but seems to not match the search criteria .
Looking at the task code is ilooking for \Microsoft.IntelliTrace.ProfilerProxy.dll and that is not part of the installed dlls
Error logs
[Insert error from the logs here]
ReleaseLogs_1710.zip

@tbielejeski
From the logs, you seem to set Select test platform using = Specific Location.
This won't work with 'Tools installer. Please configure your VsTest task with below values Select test platform using = Version Test platform version = Installed by Tools Installer`

Closing the issue as there's no further update. Please feel free to reach us in case of any issue


[hi] Localized concepts/containers/container-environment.md

/remove-lifecycle stale

@aj11anuj Since this PR has had no activity for a long time, I am closing out the PR. If and when you have the bandwidth, please feel free to check Kundan's suggestion and we can resume work.
/close


Respect indent when measuring with MeasureMode::AllLines

Summary
This PR contains two smaller Printer improvements:

The printer didn't queue an indent after a newline when measuring if all lines fits. This means, it measured the lines after the first line without any indent.
Remove the unused pending_space state variable

This PR contains another small bugfix where ExprCall and ExprAttribute passed the wrong parent in NeedsParentheses (their parent instead of self)

Test Plan
See updated snapshot. The assert now breaks because the content doesn't fit when also considering the indentation (Yes, this is a regression to black's formatting but this needs special formatting rather than relying on a Printer bug)

Current dependencies on/for this PR:

main

PR #6120   👈

This comment was auto-generated by Graphite.


accuracy has always been zero

When I pass the accuracy metric in the model.compile() function in train.py.
model.compile(optimizer=Adam(lr=1e-4), loss={'yolo_loss': lambda y_true, y_pred:y_pred},metrics=['acc'])
outputs:

Plz help me
If acc can't be used.
how can I get the 'precision'?

I am having facing issue....

Accuracy, in this case will be (y_pred == y_true).sum()/ len(y_true) (, I'm representing this as numpy array formulation, but this will be tensors, so K.sum() and K.mean() would come into place), but what are the tensors y_true and y_pred, here? y_true represents the true class id, and y_pred is the loss value calculated from the final layer yolo_loss added to the conv-base, so accuracy is a meaningless metric here and since the loss value i.e, y_pred won't be equal to y_true ever you get 0 accuracy. You can have mAP as a metric here, which is in general used for object detection cases:
mAP for object Detection, plz read this article, if any question remains unanswered feel free to come by and ask.

Accuracy, in this case will be (y_pred == y_true).sum()/ len(y_true) (, I'm representing this as numpy array formulation, but this will be tensors, so K.sum() and K.mean() would come into place), but what are the tensors y_true and y_pred, here? y_true represents the true class id, and y_pred is the loss value calculated from the final layer yolo_loss added to the conv-base, so accuracy is a meaningless metric here and since the loss value i.e, y_pred won't be equal to y_true ever you get 0 accuracy. You can have mAP as a metric here, which is in general used for object detection cases:
mAP for object Detection, plz read this article, if any question remains unanswered feel free to come by and ask.

Thank for Kind reply, may I know which metrics can we use in this case to monitor the training process? if it's available, it's also better to callback each epoch. Thank U

@IrisDinge : If you were to define a metric function like below:
import keras.backend as K

def mean_pred(y_true, y_pred):
    return K.mean(y_pred)

model.compile(optimizer='rmsprop',
              loss='binary_crossentropy',
              metrics=['accuracy', mean_pred])

Taken from Keras Custom Metrics
It would be shown after each epoch end. Also, you can go by using keras custom callbacks class, where you can print the result using the on epoch end method. For object detection algorithms, mAP (mean average precision) the metric used for model comparison.
Thus, you'll have to implement either a keras custom metric or a keras custom callback. In the case of a keras metric, you'll have to work with tensors and also keras backend, But, the best thing about this is that the computation inside will be part of the computation graph and won't be needed to run separately. With keras callbacks also you can add tensor computations to computation graph by using the fetches argument of keras callbacks.
I personally implemented IoU, by using keras callbacks, since I wasn't able to find a way to do it by using metrics.


client: added auto-host bool parameter to hosted event

Added a bool parameter to the hosted event showing if the host was an auto-host. The message I based my changes off of was: DBKynd is now auto hosting you.
I'm making an assumption here that the message for auto host with viewers would be DBKynd is now auto hosting you for 10 viewers. as I don't have an easy method for testing without setting up alt accounts to 'view' and then host.

I was able to confirm my assumption above: TheGameCase is now auto hosting you for up to 4 viewers.

Personally, I'd like to see this as an object for the same reasons as the Twitch Prime stuff.  But this is good stuff anyway, thanks for doing this.

Yeah, it made sense to be able to expand the sub stuff if they ever add more methods. I couldn't really think of any other methods to host a channel with. But if that's what you guys want it's easy enough to change 😄


Adding UAdeO University

UAdeO University file added

@bidkar First stage of verification passed, official domain is uadeo.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@bidkar Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Update Ex4DGS paper (NeurIPS '24)

Thank you. Could you please update the code tag and append (not yet) as it is done for other papers. This way it is clear that the code is not released yet.

Thanks for your revision! I've added (not yet) to the code tag.


something is broken...

Hello,
Here's a sample file:
https://gist.githubusercontent.com/jungle-boogie/eef783ac0d33ec8d57e3/raw/4aa192e205b587887946e50f7e9e869fc342137f/tips.csv
When I open this file up, the whole file is red like its apart of the header. I cannot :Sum the fields with numbers because the results are all 0.
I'm using csv.vim from master.

Here's another example but much worse:
https://gist.githubusercontent.com/jungle-boogie/f81eb31b5292e19367fd/raw/1fbbf30d204c022a5083d94ebcffcc7bd57c38c7/gistfile1.txt
"sacramentocrimeJanuary2006.csv" 7585L, 793575C
Error detected while processing function <SNR>55_CheckSaneSearchPattern:
line   44:
E363: pattern uses more memory than 'maxmempattern'
Interrupted
Error detected while processing /usr/home/sean/.vim/bundle/csv.vim/syntax/csv.vim:
line  165:
Interrupted
Interrupt: Press ENTER or type command to continue

Hello,
I have the exact same issues.
Thank you for this great pluggin !
JB

what are your configuration values for the plugin?

Ah, okay the pattern needs to be correctly escaped. Should work now again.

I have only set
let g:csv_headerline=0
https://github.com/jbkopecky/dotfiles/blob/master/vimrc#L372
( I have checked that filetype plugin line is before syntax on: these two options are handled by vim plug)
I'll try to reproduce with a minimal vimrc and simple csv to make sure it is not because of an other plugin interfeering

Awesome, the last commit fixed it ! Thanks !


[bn] localize : application-architect.md

I've localized application-architect.md from issue no: #45729

/area localization

@MRH-Romit  , are you still working on this task? Please let me know; otherwise, I will close this PR and unassign you.
Since we now have our new working branch dev-1.31-bn.1, you'll need to create a fresh PR with the following details:

Source repo: kubernetes/website
Source branch: dev-1.31-bn.1
Target branch: dev-1.31-bn.1

Sorry for the delay, i'll be working on it

/close


Input styling

Worked on the select, text and number inputs, made a shared base of appearance.
Also re-organized (again) how stuff is rendered in the toolbar and added the scrolling section for parameters, as inspired by the Flagship Pioneering tool.
Added color to Export color to differentiate it from preview, using the logo blue.

This is really nice! I think the line break for the labels is great, and the overall UI has a nice balance to it now.
@fdoflorenzano There is a bit of oddness when I try to change the input values. For example, I cannot delete 2 in numberOfRects. Can you take a look at that?
@bravomartin Take a look at this branch and add any comments that you might have!

It's looking really nice!
My notes based on our conversation:

change the function navigation into a special select where we can see all of the functions at once before selecting one.
make size label the same as the others
make props inputs the same width as size and buttons
make labels smaller, use Menlo, Courier New.
use same monospace in input value.
make aside and root 100% height.
introduce a green for "true" in toggle.

Most of the proposed changes are there, I still want to make a pass at the whole CSS declaration and component structure.

This looks great! Merging in.


Error with passing array of hashes or array of arrays as params

I have two different input
 let(:my_params) do
    {
        waypoints:{
         coordinates: [[55.542997, 37.540488] , [55.727232, 37.580328]]
        }
    }
  end

And
  let(:my_params) do
    {
      waypoints: [{
        coordinates: [55.542997, 37.540488]
      },{
        coordinates: [55.727232, 37.580328]
      }]
    }
  end

In both cases I start a request using rack-test
  it "should return  something" do
    get "/api/url", my_params
  end

And when I try to access params i see something like this:
 {"waypoints"=>[{"coordinates"=>["55.542997", "37.540488", "55.727232", "37.580328"]}]}

instead of
{"waypoints"=>[{"coordinates"=>["55.542997", "37.540488"]},
               {"coordinates"=>["55.727232", "37.580328"]}]}

There is nothing related togrape. You are trying to use HTTP params with rich data structures and doing it wrong (I suggest using JSON if it's possible).
To clarify, see your example:
   {
     waypoints: [{
       coordinates: [55.542997, 37.540488]
     },{
       coordinates: [55.727232, 37.580328]
     }]
   }

it turns into ?waypoints[][coordinates][]=55.542997&waypoints[][coordinates][]=37.540488&waypoints[][coordinates][]=55.727232&waypoints[][coordinates][]=37.580328 query string (there are no hashes or arrays in HTTP)
and result is expected
{"waypoints"=>[{"coordinates"=>["55.542997", "37.540488", "55.727232", "37.580328"]}]}
AFAIK there are no any specific RFC which has an information about how to send rich data structures using HTTP key/value pairs. But I think, you can rely on this one - http://www.w3.org/TR/html-json-forms/ (see example 5). So your params should be smth like this:
    {
      waypoints: {
         "0" =>{
           coordinates: [55.542997, 37.540488]
         },
         "1" => {
           coordinates: [55.727232, 37.580328]
         }
      }
    }

and it should provide the result that you expected.
I'll close, feel free to re-open if you think it's related to grape :)


Refactor runtime scale generate

重构 runtime 里面 scale 实例的生成：

之前是 component 和 mark 都会生成一次，总共两次
目前把两次合成一次，方便后续的比例尺调整 https://github.com/antvis/G2/pull/6372

截图更新是 facet 之前存在的一点小问题，不影响视觉效果。

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 86.673%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
10527

Relevant Lines:
11769

💛  - Coveralls


[native filter][cascading] Confusing user experience

How to reproduce the bug

I created a simple dashboard with cascading filter component:

Simple gender filter,
Name filter, and State filter (under Name filter)

Click on Name filter, there are 2 dropdown list for all Names filter showing up;
Pick a name for Name filter, you will see Name filter title became State filter, and there are 2 dropdown list for state.
If there are 2+ nested filter under same parent filter, the experience is totally chaotic....

Proposed solution:
When user created a nested filter component, what's the best way to display dropdown list(s)? Right now we show 1 in the main component list, and also show another copy in the popover with child filter...this is definitely not desirable. Please reconsider the design and implementation.
How about only remove the popover for the family of drop-downs, just show all in the main filter list, but align them with some indent or box?
Environment
latest master
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

cc @junlincc @michael-s-molina @villebro

Just linking this comment to add more context to the discussion.

Hi @michael-s-molina thanks for the link, i am happy to know someone else had same concern as me. But from those merged PRs i couldn't get this problem is kind of resolved,  or there will extra work to do to improve? At least, currently showing 2 dropdown controls for the same filter is totally wrong:

if it's preferred always show parent filter in the filter bar, i agree, could we not show parent filter in its popover?
thanks for your feedback. @rusackas @michael-s-molina @villebro @junlincc

@graceguo-supercat i totally agree your sentiment "If there are 2+ nested filter under same parent filter, the experience is totally chaotic...."
changes made in cascading popover were not well thought through due to the lack of design support. do you mind if i remove the p1 priority for now, and have a design sesh later on?

@graceguo-supercat this problem is not resolved. I just linked that comment to include even more context for when we discuss the solution.

thank you all for the quick response! I am ok with the priority (not p1). As you know airbnb is also preparing to enable native filter, if we can have an ETA will be the best :grimacing:

Closing - we've redesigned the filter bar, so the issue os no longer relevant


Update dplyr cheatsheet with changes in dplyr v1.0

With the release of dplyr v1.0, the dplyr cheatsheet here needs to be updated. The most notable changes are

across(), which supersedes *_if(), *_at(), and *_all(),
slice_*() helpers, which supersede sample_*() and top_n()

I've just had some mails from my students, pointing out that those cheat sheets are outdated. Last update was 2019-08. The old versions are on the official RStudio website : https://rstudio.com/resources/cheatsheets/


How to extend the web view in new architecture

How to extend the web view with native code  in new architecture without forking React Native or duplicating all the existing web view code.

If you're referring to techniques like https://github.com/react-native-webview/react-native-webview/blob/master/docs/Custom-iOS.md, this should still work with the latest version using the old architecture (though some tweaks may be necessary). However, it's not officially supported with the new architecture and we expect that some customizations may not be possible there.
I personally suspect it may still work if you're making native-only changes (i.e. not adding new properties/functions to the React Native side), but AFAIK nobody's actually tried this yet.
I think the other alternative approach would be to patch the library.


Proxy error in Spyder

I recently reinstalled Anaconda/Spyder so I could upgrade to python 3. I'm having proxy errors in Spyder that I don't have when I run python from terminal.
For example, when I run in the following test code in Spyder:
import requests
print(requests.get('http://google.com'))

I get this error:
ProxyError: HTTPConnectionPool(host='http', port=80): Max retries exceeded with url: http://google.com/ (Caused by ProxyError('Cannot connect to proxy.', NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x1185b40b8>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)))

But the same code runs just fine when I run it from the command line in terminal. I checked my proxy settings and everything is as it should be. How do I fix the proxy settings in Spyder?
I'm running Spyder 3.1.4, Python 3.6 on Mac OS 10.11.6

Please start Spyder from a terminal to see if that fixes your problems.

That worked, thanks!


gnomeExtensions.guillotine: package manually

Description of changes
Starting from version 19 guillotine is no longer updated on https://extensions.gnome.org.
Notably Gnome 46 compatibility is introduced in version 22.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Changes look good, could you please rebase and squash your commits such that there will be 2 of them?
maintainers: add huskyistaken
gnomeExtensions.guillotine: package manually


SAML - redirect issues with Chrome/Firefox

Since upgrading to v231 were having issues with uaa redirecting to the proper url after authenticating through saml to our ping-federate identity. The normal sequence went:

cf login --sso, which would direct them to a passcode link: One Time Code ( Get one at https://login.mydomain.com/passcode )>

user would enter that url into browser which if not authenticated would take them to https://login.mydomain.com where they could click on the linkText field for our saml provider

this would take them to our Ping Identity login page where they would login

After step above, it used to redirect the user back to https://login.mydomain.com/passcode where they could then obtain the passcode to enter into cli. Now, instead it ends up directing them to https://login.cf-cnb.mydomain.com/favicon.ico which throws the error 'Uh-oh. Something went amiss'. I can manuallly reenter https://login.mydomain.com/passcode to get the passcode.

Seems to only be issue with Chrome/Firefox.  Safari works fine.  I suspect based on inspecting the browser network requests and uaa logs its when Chrome/Firefox tries to get the favicon.ico its throwing off the Redirect strategy.  I noticed if I manually copy a favicon.ico into the root folder of uaa and then try it, it fails one more time but after this even if I remove the favicon.ico (assume because browser has it cached) it redirects without any problem

@rwwohl
We have fixed this issue. This will be available with cf-release 233 (UAA release 3.2.1)


pack.mcmeta still uses "examplemod" as its name

Title says it all. Examplemod is used instead of mod title in the description part of the pack.mcmeta file right here:
https://github.com/Cy4Shot/JED/blob/main/src/main/resources/pack.mcmeta
EDIT: Yes, this has no functional purpose and seems kinda overcritical. I am just trying to bring this up early on so it isn't overlooked at a later point. This is what early versions and betas are for.

I know this is an insignificant detail, but this is just something for future consideration. It doesn't need fixing any time soon, and I'm not trying to be troll. Again, it's just something that should be fixed in the future.

it is indeed an insignificant detail and i think it's already planned to be fixed and stuff cuz it's an insignificant detail so it isnt being fixed now. the fact that the mod is still in its early versions

As long as it's planned to be fixed. I saw that it was released on CurseForge and kinda assumed it was out of early development. But if it's still not fully finished, then no worries. If you think that the authors are aware of this, I can close the issue if you want.

ill just ask the author then, i know him

Thanks! I know this was a minor issue (not even a bug really) but with such a community-driven mod, every detail counts (also my OCD got to me lol). Can't wait for the new update!


Support for LSM9DS0 9DOF IMU

SparkFun Block for Intel® Edison - 9 Degrees of Freedom : https://www.sparkfun.com/products/13033

This driver was added in our 36b0e1dce0f10dabc59ea7669f2183a44a84a48e commit!


shell.nix: use named channel instead of tar.

That way, the packages are always relative to the current distribution
and doesn't age away.
While at it, add ccache for faster compile time turnarounds.

@sjkelly to review (since you are the original owner of this shell.nix )

Is using the named package instead of a tar commonly used ? It should be more forward compabile and works on nixos and the nix package manager.
Adding ccache to the mix: while not really a dependency of Surelog, it certainly helps developer velocity. Is this the appropriate place to put it, or would we have another location than buildInputs be used ? (Noob here :) ).


Blob URL images are broken in private windows

For about 10 days (either after the last add-on update, or the last Firefox update) the thumbnails in the image picker screen are invisible in private Firefox windows. They still download fine, have a blue outline, and are selectable and deselectable; but there are no images visible.

https://github.com/eight04/webextension-test/tree/blob-image
Can't reproduce in Nightly 96.0a1.


No results obtained after step two

the files (metadata.txt and extracted.fa) were obtained successfully after the commond line (args_oap stage_one -i input -o output -f fa -t 8), while we got no results after the commond line (args_oap stage_two -i output -t 8) on our own data, the results were show below,

Hi,
The default value for --length in stage-two is 25aa so if your reads are too short (say 75bp), then no one will pass this filter. You may consider changing the cutoffs in stage-two.

The reads in the extracted.fa of my data were 150bp (shown below). And I changed the value of --length to be 15 in stage-two (args_oap stage_two -i args -t 92 --length 15), and no results obtained still. Two weeks ago, all the default command line go well on my one data, while it did not work after I changede the hard disk and rebuild the conda envs.  What is the issues?
(less extracted.fa:

11_1@0@A00920:381:HCCGFDSXY:2:1101:20012:1391
GCCTGCGGTAACTTTCGCATGGCTGATTGCAGCTGGTTTTGTACTTGCTGCACGGCTTCGTCCGGATCGGTGCCTGCTTTAAAACTTAAAGTGACAGATGCCTGACCGGTGCCACTGCTCTGAGATGACATATACATGAGATTATCGAGG)

I can confirm this is a bug. This happens because all your samples are named using integers (e.g. 11.fa/fq).
This commit 4afa4b1f01b2686cfc08457f1748518f4ec89225 should fix the issue.

Fixed in 0d0cede0506579bb263f26bda7dbd663c4b90fa5.

Regretally, the default command produce no results still, with the above fixation alone or synergistically.

That's wired, did you install the latest commit in your current conda env using git clone and then python setup.py install? I haven't uploaded 0d0cede0506579bb263f26bda7dbd663c4b90fa5 to bioconda so conda install will still load the old version.
If this does not solve your issue, can you show your current env using conda env list and send me a minimal reproducible example of your input files?

After testing, the sample names might be the issues, the names of integers was not supported by the current args_oap stage_two, and the pair sample names including R1 and R2 seemly  not accepted too.

https://github.com/xinehc/args_oap/releases/tag/v3.2.2


ShellCheck fixes to pass shell linter checks

Description:
Fixes shellcheck suggestions in init-eks-fargate-cluster-receiver.sh to pass shell linter checks.
Link to Splunk idea: n/a
Testing:  Run the shellscript
Documentation: n/a

I have read the CLA Document and I hereby sign the CLA

@mpepping

Tt looks like this change breaks our pre-commit CI/CD workflow.
We should also test this change works in an EKS fargate cluster properly.
Can you look into these?

@jvoravong, Updated the test render accordingly via make render.  Also reverted the yq change in favour of a shellcheck exception. Pre-commit and shell lint both pass.

I closed and reopened the pull request so the test would rerun with the "Skip Changelog" label applied.

@mpepping thanks for your contribution.


feat/ add Phemex broker id

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Add Phemex broker Id

Tests performed by the developer:
**
Tips for QA testing:
**

Test run: https://hummingbot.testrail.io/index.php?/runs/view/4859&group_by=cases:section_id&group_order=asc


Last Stocktake field is blank under parts but showing under stock

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
When viewing the list of parts the Last Stocktake field is blank, but when viewing the part/stock is showing the correct date.

Steps to Reproduce

Create part
Add stock to part.
Click stick adjustement, count stock.
Last stocktake updates to the current date.
Click on parts and search for the part you created.
The last stockdate is blank

Expected behaviour
Expect last stockdate to show correct value
Deployment Method

[ ] Docker
[X] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.11.0 dev
Django Version: 3.2.18
Commit Hash: 7aee97d63
Commit Date: 02/03/2023
Database: mysql
Debug-Mode: True
Deployed using Docker: False
Active plugins: False
Relevant log output
No response

@StormTrooper it seems to work on demo.inventree.org - can you try reproducing it there? I tested with 530470410.

I must be doing something wrong. Replicated the issue there.
Created
my-test-part

@StormTrooper this is expected behaviour, but it might be a bit confusing.
For a single stock item, the last_stocktake refers to when that particular individual stock item was last counted
For a part, the last_stocktake refers to when a stocktake report was most recently generated for the part.
Note that in the case where there are multiple stock items associated with a given part, the two stocktake events are not the same.
I have recently been considering whether the terminology here needs to be improved...

Thanks for the clarification. Closing the ticket as working as expected.


Which search results should be exposed for archives?

TODO

UX and devs to decide on which search results should be exposed, conversation needs to include Jonathan re search
expose those results

Some thoughts from a discussion in design review. We've got some options, with pros/cons
Option 1: Expose Collection Series and Items
Pros: Pulls up most relevant level based on your search
Cons: Series level may just be a stub record for the items contained within - it's an extra click that a user need not make. Larger number of results increases likelihood of frustration for choosing the 'wrong' one
Option 2: Expose Collection and Items
Pros: Collection can be given priority as promoted result; item is the tangible, requestable thing. By leaving out the Series level we can get people straight to the item to view/request. Item result can display `Part of [Series] in [Archive collection name]'. Clicking through to results from an item brings you to ancestor, which shows this item and all sibling items for added browseability
Cons: ?
Option 3: Expose Collection and Series
Pros: Series page contains all child items to be viewed in one place
Cons: would need to accommodate item-level snippets on search result card, resulting in additional clutter

After discussion with the Search crew, we're going to go with Option 1: expose all levels in search results. This means we'll need to add AltRefNo and Part of info to the search result card as described in #5367
cc @DominiqueMarshall


Two RangeCard test scripts need to be updated

Parameters have changed for the Range Fan By Bearing and Traversal, and Range Fan By Bearing Limits tools so the tool tests have to be modified to make them run again. The tool test affected are:

[ ] TestRangeFanByBearingLimits.py
[ ] TestRangeFanByBearingAndTraversal.py

@nfeuerstein @jrweakland So this is another case where we had several early templates that shared common tools. So we duplicated the tools among the toolboxes as needed. Unfortunately this means if changes are updated in one place, they must be made in all of the other copied locations as well. Double that for Desktop and Pro templates and this becomes crappy management task. Since we already maintain these tools in the Visibility and Range template(s) I think we should remove the Range Fans From Bearing And Traversal and Range Fans From Bearing Limits in this toolbox. For Pro projects/packages we can include both toolboxes. Thoughts?

@mfunk, barring objections from @jrweakland, I agree with you.  We should only maintain the tools in the Visibility and Range toolbox, in github.

@jrweakland @nfeuerstein A long time in coming, but i'm going to rename this task to remove range fan tools from the range cards toolbox and add to Asana. The task will have additional subtasks to add documentation to use the Visibility and Range template to build range fans.


Adds Smooth

Is this pull request associated with an issue(s)?
No
Description
This PR adds ShapeBase and Smooth according to the design. They are also unit tested.
TODOs
None. R2g if this passes CI.

🚀 [bumpr] Bumped! New version:v0.0.31 Changes:v0.0.30...v0.0.31


✨chatbot has been added ✨

issue #151 solved.

the chatbot has been added and its trained on these html files and can answer user queries.
@Harshdev098 can you review this , thank you.

https://github.com/user-attachments/assets/ce1c05fe-a7e5-4299-a0f3-360774b75a65
✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[X] I have followed all the guidlines mentioned in CONTRIBUTING.md.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation (if applicable).
[X] I have tested it locally and it works fine.
[X] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[ ] Bug fix (non-breaking change which fixes an issue) 🐛
[X] New feature (non-breaking change which adds functionality) ✨
[ ] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

Will review and merge till night

@Harshdev098 done.

@Harshdev098 i have made the changes.


apprise: 0.9.4 -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/caronc/apprise/releases.
meta.description for apprise is: "Push Notifications that work with just about every platform!"
meta.homepage for apprise is: "https://github.com/caronc/apprise"
meta.changelog for apprise is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>/bin/apprise passed the binary check.

/nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>/bin/.apprise-wrapped passed the binary check.

2 of 2 passed binary check by having a zero exit code.

0 of 2 passed binary check by having the new version present in output.

found <IP_ADDRESS> with grep in /nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>

found <IP_ADDRESS> in filename of file in /nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>

directory tree listing: https://gist.github.com/1b1aa146f0be902a43745bfe97275043

du listing: https://gist.github.com/98466ae1f666ab1cd314147f545b4d40

Rebuild report (if merged into master) (click to expand)

15 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
apprise
home-assistant
python38Packages.apprise
python39Packages.apprise

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A apprise https://github.com/r-ryantm/nixpkgs/archive/11e5514cb80e334523e97e8af77527f2ceafeee2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>
ls -la /nix/store/hznrs1xjrsbazj1wzm68yhryjanld4a9-python3.9-apprise-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @marsam for testing.

@ofborg eval


C version tries to listen on IPv6 when it's not enabled

The C version appears to attempt to listen on IPv6 when it is not available.  This appears to be an extension of issue #75 which patched some of socket.c to fallback to IPv4.
When I run I get the following output:
/usr/local/src/shairport # ./shairport -vv
LogLevel: 7
AirName: ShairPort
HWID: dD&_$
HWID_Hex(12): 006444265F24
Avahi/DNS-SD started on PID: 7411
Starting connection server: specified server port: 5002
Listening on IPv6 Socket
Avahi/DNS-SD Name: 006444265F24@ShairPort
Failed to create ipv6 socket. Trying ipv4: Address family not supported by protocol
Error: Could not bind socket: Invalid argument
Error setting up server socket on port 5002, try specifying a different port
In socketlib.c  issue #75 added detection which results in the output above about Failing to create IPv6 socket.  However in setupListenServer() the code sets the socket to IPv6 using a #define.  I've quickly fixed by commenting out the line :
tFamily = AF_INET6;

And it can then initialise correctly.  I guess this need to do some runtime detection similar to patch in issue #75.

Having investigated further I have found the cause of the failure is in the call to bind() in setup_server().
In my configuration IPv6 is not available.  common_setup detects this and changes the family to IPv4 in the addrinfo structure in order to create a socket.  However the call to bind() uses the ai_addr from the addrinfo structure which I believe will still be referring to IPv6.
Essentially it is not enough to just change ai_family in common_setup to switch to IPv4.  I think it needs a new call to getaddrinfo() in order to create an IPv4 structure.
I'm still thinking on how this can be changed.  I think it just needs a little more intelligence at runtime to ensure it does the right thing.
The underlying cause of the failure is that IPv6 is not enabled in the kernel (That's what you get running a stripped down Gentoo kernel!).  I'm currently rebuilding the kernel to see if this will avoid the error.


feat: Add BatchGet* to IAM read only policy

Description
docker pull does API request to ECR and requires BatchGetImage. With Read Only policy we expect that we can pull image from the registry.
This PR adds BatchGet* action to address this problem.
Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

This PR is included in version 5.51.0 :tada:


Could have font size be a bit bigger

It was a bit small and could be bigger, so easier to read.

We decided to start the web app from scratch after the major design/architecture decisions and changes we made. No longer relevant.


Add @json directive to "lib/LimeExtra/App.php"

Nothing fancy, but it could still helps to write cleaner templates.

Related info:

https://laravel.com/docs/8.x/blade#rendering-json
https://cpmultiplane.rlj.me/en/docs/lexy

Side notes (if not accepted)
For those interested in learning more, below you can see how you can add this directive to your own cockpit project:
// config/bootstrap.php

/**
 * Extend Lexy Parser (templating engine)
 *
 * @link https://cpmultiplane.rlj.me/en/docs/lexy with available language structures
 * @see { cockpit/lib/Lexy.php | cockpit/bootsrap.php }
 */
$app->renderer->extend(function($content) {
    $replace = [
      'json'     => '<?php echo json_encode(expr); ?>', // @json(expr)
    ];

    $content = preg_replace_callback('/\B@(\w+)([ \t]*)(\( ( (?>[^()]+) | (?3) )* \))?/x', function($match) use($replace) {
      if (isset($match[3]) && trim($match[1]) && isset($replace[$match[1]])) {
        return str_replace('(expr)', $match[3], $replace[$match[1]]);
      }
      return $match[0];
    }, $content);

    return $content;
 });

Have a nice day,
Raruto

Thanks!


get package Failed

go get github.com/StackExchange/wmi   failed, the error is:
go: github.com/StackExchange/wmi upgrade => v0.0.0-20210708210415-b284ef6ab838
go get<EMAIL_ADDRESS>parsing go.mod:
module declares its path as: wmi
but was required as: github.com/StackExchange/wmi
can you help me fix up this ?

yes me too, how to fix this

go.mod  add this
replace github.com/StackExchange/wmi v0.0.0-20210708210415-b284ef6ab838 => github.com/StackExchange/wmi 1.1.0

I'm not very good at git but I think I fixed this. Please verify.

I'm not very good at git but I think I fixed this. Please verify.

I tried , Unfortunately， this error still exists.  this error occurs at today, you can check what's changed today。


move timeseries plotting from dashboard

and improve converting quality flags

Works in conjunction with solararbiter/solarforecastarbiter_dashboard#76
no tests yet, but what about structure @wholmgren ?

Comparing to my plots in #88...

line_or_step would be useful in utils.
no units that I can see in yours.
ok to ignore palette consistency for now
The iter call on the palette at the module level doesn't seem right. Don't you need something like palette = iter(PALETTE) in a function each time a plot is created?

My biggest concern is that I don't think plotting should assume json payloads from the api. That seems overly opinionated about the way the function is used.
Why metadata dicts instead of datamodel objects? I thought of this when I noticed that the required metadata keys are not documented.

Using a metadata dict and json payloads to minimize the changed that had to go into the dashboard. I think eventually, the dashboard should use datamodel objects, but that will be a big change. For now, I'll make a small utility in the dashboard so these functions can take datamodel objects and series/dataframes

Comparing to my plots in #88...
* [line_or_step](https://github.com/SolarArbiter/solarforecastarbiter-core/pull/88/files#diff-67f74b9923d2fcc7a28a17fa7f09548eR37) would be useful in utils.

:+1:

* no units that I can see in yours.

In the y axis label

* ok to ignore palette consistency for now

* The `iter` call on the palette at the module level doesn't seem right. Don't you need something like `palette = iter(PALETTE)` in a function each time a plot is created?

yes if  you don't want to exhaust the palette

Hmm, the hovertool doesn't work with the step https://github.com/bokeh/bokeh/issues/7419

Hmm, the hovertool doesn't work with the step bokeh/bokeh#7419

Aw that is most unfortunate. Better to use your lines + hovertool for most data right now.

I think step mode in line_or_step should be swapped in reports. If we have a forecast/obs with interval length 1hr and a datapoint (20190530T1200Z, 100), then if interval label is beginning, the step line should be from (20190530T1200Z, 100) to (20190530T1300Z, 100). And if interval label is ending, the line should be from (20190530T1100Z, 100) to (20190530T1200Z, 100). Right?

Right?

Yes. I forgot to check the behavior.

tests and missing bar have been added, along with using datamodel objects


Ansible operator using  oc auth can-i failed

When Operator docker was injected oc command (OpenShift kubectl fork) (in order to mitigate k8s  object tracking caching - aka  https://github.com/operator-framework/operator-sdk/issues/1051)
When I ran it, I encountered a problem with
TASK [catproject : Check whether logged user can create projectrequest resources] *** task path: /opt/ansible/roles/catproject/tasks/main.yml:10 fatal: [localhost]: FAILED! => {"changed": true, "cmd": "oc auth can-i create projectrequest -q", "delta": "0:00:00.505599", "end": "2019-02-12 13:31:05.706886", "msg": "non-zero return code", "rc": 1, "start": "2019-02-12 13:31:05.201287", "stderr": "The  \"\" is invalid: metadata: Invalid value: v1.ObjectMeta{Name:\"\", GenerateName:\"\", Namespace:\"\", SelfLink:\"\", UID:\"\", ResourceVersion:\"\", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference{v1.OwnerReference{APIVersion:\"some.cat.com/v1alpha1\", Kind:\"CatProject\", Name:\"alamakota\", UID:\"848ca4c8-2eb8-11e9-9a3b-06989c5df67c\", Controller:(*bool)(nil), BlockOwnerDeletion:(*bool)(nil)}}, Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:\"\"}: must be empty", "stderr_lines": ["The  \"\" is invalid: metadata: Invalid value: v1.ObjectMeta{Name:\"\", GenerateName:\"\", Namespace:\"\", SelfLink:\"\", UID:\"\", ResourceVersion:\"\", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference{v1.OwnerReference{APIVersion:\"some.cat.com/v1alpha1\", Kind:\"CatProject\", Name:\"alamakota\", UID:\"848ca4c8-2eb8-11e9-9a3b-06989c5df67c\", Controller:(*bool)(nil), BlockOwnerDeletion:(*bool)(nil)}}, Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:\"\"}: must be empty"], "stdout": "", "stdout_lines": []}
The oc apply etc. commands works..
Running oc auth can-i create projectrequest from the operator pod (oc rsh operatorpodid) just works...
I dunno what is the problem and why it complains about CR content (CatProject with resource id: alamakota) ... Looks like butterfly effect issue...

This is closed by #1463


Why is Hypex an application?

G'day! Elixir newcomer here, kicking the tyres because I think I might need a HyperLogLog to avoid blowing out the size of a term counter when the vast majority of counts will be 1. One thing I don't understand given my study to date:

Ensure hypex is started before your application:

Why? Did that happen automatically when I ran iex -S mix? Because, the rest of the code worked fine without that step.

@garthk Yes, that happens automatically when you run that command. It's not strictly necessary, except;

If it ever becomes necessary, it's not a breaking change.
It allows your application to include the Hypex library. In older Elixir versions this was a requirement.

That all makes sense. Cheers!


Cannot be applied to the Chinese and Japanese versions

Because the exe file of the Chinese and Japanese versions is different from the English version, this mod cannot be applied (of course, there are other differences between the Chinese, Japanese, and English versions besides the exe) Hope it can be fixed

Next version will support chinese and japanese versions, sorry for the wait


Implement Fastformer in the rank models for the experiments on MIND dataset

I referred to this repository by the author of Fastformer, which was proposed in 2021, and reimplemented it in the PaddlePaddle framework. The exact layers were not officially implemented by the author, only the core of Fastformer attention was revealed. I inherited the architecture of NAML and replaced the attention layers with Fastformer. The final AUC score can almost reach the state-of-the-art (SOTA) performance, even without powerful language models like UniLM, MOKA, or word embeddings from GPT. The AUC score on the test dataset after training for 9 epochs is 0.729. Although there are still some tasks to complete, I aim to contribute the core Fastformer attention models to PaddleRec first. Here is a screenshot of the results:

To-do

Add metrics such as MRR, nDCG@5, nDCG@10 for evaluation.
Integrate strong word embedding features from pretrained language models like UniLM, MOKA,...
Make sure it works in the static modeling mode

Thanks for contributing! It is very helpful for other users!


Hotkeys for toggle-mute, push-to-talk, and toggle-chat

Render keybind listeners for toggle-mute, push-to-talk, and toggle-chat to bottom voice control when user is in a room.
Default keybinds are:

Control+m for toggle-mute
0 for push-to-talk
c for toggle-chat

These keybinds can be changed in voice settings.

Should toggle-chat really be in voice settings?

we will probably rename this to keybind settings in new design


A formatter such as black

Coming from a word where there's a linter and formatter for everything, and then there's not one for Snakemake
Integration into black or another formatter for Snakemake files.
We could just suffer through, but I noticed that you forked black, so there may be work going on already for this.

Yes, I forked black for exactly this. Unfortunately, everything is quite deeply integrated, so it is not just writing a module or so. I have currently not the time to do this. However, if anybody would like to give it a try, that person would be the next big Snakemake hero!

And of course she or he would be co-author of the next Snakemake paper that we will hopefully soon start drafting ;-).

@Emiller88 : co-authorship sounds very good, so even though I don't use linters I would like to give this enhancement a try. Kindly let me know if you plan pursuing and/or would like to split some work.

This all sounds good. To clarify I'm interested in a formatter more so than a linter. I think snakemake itself does a good job of giving errors.
@johanneskoester If you have any more info on the issues you ran into with black I would appreciate it before I go down the same deadends.
We might be better off making the fork of black, or starting from scratch on a seperate formatter, rather than trying to get it integrated upstream.

@johanneskoester When do you hope to send out the new paper?

+1 I had similar thoughts in this bitbucket issue: https://bitbucket.org/snakemake/snakemake/issues/1242/making-snakemake-work-with-black
@johanneskoester I guess the plan is to start fresh here on github rather than migrate the bitbucket issues?

So it seems the best way to approach this is to write a program (or snakemake submodule) that uses black to parse the python code and then we can format the Snakemake syntax code.
Generally, it seems like code formatters heavily leverage the AST for the language. @johanneskoester is there some kind of AST for Snakemake? It looks like all the parsing is done in here so we can leverage this. Then I guess the next things are to decide on the "style" we would like to output. i.e. do we want to be "opinionated", like black, and not allow any flexibility in format style.
The other big question is whether you want this bundled with Snakemake (either as a subcommand or a flag) or whether you would prefer it to be a separate project.

Update: I have made a start on this with a colleague - https://github.com/mbhall88/snakefmt
Would be great to speak with you about this when you're back @johanneskoester

Dear @johanneskoester, regarding this project we have made decent progress!
I would like to ask what you might consider for integration into Snakemake. Do you want a formatter much like your team's recent linter, meaning i)A set of modules directly under snakemake/ and ii)Directly callable as --format ?
This project has its own parser for Snakefiles- I found it too challenging to use the existing snakemake parser.py. This causes the obvious annoyance, if doing the above integration, of having two parsers. One option to work on is I think we could have our parser compile the same code as your parser.py, but I'm not sure if that is of interest to you or relevant in this scope.
Kind regards!

Good question. On the one hand, having an intergrated formatter would be nice in terms of enforcing a certain style. On the other hand, it might bloat snakemake too much. Let us keep it separate for now, but I am happy to move it into the snakemake organization (of course with admin rights for you).
Does it also format the python parts of the snakefile? Does it move into includes?

It formats the python code using black.
It doesn't move into includes, but I have set it up to (by default) to search for snakefiles the same way black searches for python files. The default include pattern is r"(\.smk$|^Snakefile)". But if someone were to explicitly pass the files they wanted formatted; then only those files will be formatted.
I was also thinking it might be nice to allow for setting the formatting configuration (line length etc.) from a pyproject.toml. This way black settings and snakefmt settings can be set simultaneously. Something like
[tool.black]
line_length = 88

[tool.snakefmt]
line_length = 90
include = '(\.smk$|^Snakefile|\.mysnakefileext$)'

It formats the python code using black.

Great!

It doesn't move into includes, but I have set it up to (by default) to search for snakefiles the same way black searches for python files. The default include pattern is r"(\.smk$|^Snakefile)". But if someone were to explicitly pass the files they wanted formatted; then only those files will be formatted.

That makes sense.

I was also thinking it might be nice to allow for setting the formatting configuration (line length etc.) from a pyproject.toml. This way black settings and snakefmt settings can be set simultaneously. Something like
[tool.black]
line_length = 88

[tool.snakefmt]
line_length = 90
include = '(\.smk$|^Snakefile|\.mysnakefileext$)'

So, actually, I'd prefer to enforce line_length = 80 and r"(\.smk$|^Snakefile)". The goal of this is standardization, so it would be nice to keep it non-configurable. But if that feels to strict for you, I am also fine with allowing a config file like that.

I was effectively just trying to mirror black with the settings. The default line length is 88 (same as black).
I guess this is where the line between strict and opinionated arises. I think it is fine to allow people to change the include regex if they like. However, I doubt too many people would do that. For example, I am lazy, and I would prefer just to change my file extension than have to mess around with a regex 😅
As of this current moment, this is what the CLI options are. Let me know if you feel anything should be added/removed
$ snakefmt --help
Usage: snakefmt [OPTIONS] [SRC]...

  The uncompromising Snakemake code formatter.

Options:
  -l, --line-length INTEGER  [default: 88]
  --include TEXT             A regular expression that matches files and
                             directories that should be included on recursive
                             searches.  An empty value means all files are
                             included regardless of the name.  Use forward
                             slashes for directories on all platforms
                             (Windows, too).  Exclusions are calculated first,
                             inclusions later.  [default: (\.smk$|^Snakefile)]
  --exclude TEXT             A regular expression that matches files and
                             directories that should be excluded on recursive
                             searches.  An empty value means no paths are
                             excluded. Use forward slashes for directories on
                             all platforms (Windows, too). Exclusions are
                             calculated first, inclusions later.  [default: (\
                             .snakemake|\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\
                             .tox|\.venv|\.svn|_build|buck-out|build|dist)]
  -h, --help                 Show this message and exit.
  -V, --version              Show the version and exit.
  -v, --verbose              Turns on debug-level logging.

That is of course right. Ok, if you feel like, I am fine with the toml possiibility. I have just tried it out, and found an issue: https://github.com/mbhall88/snakefmt/issues/17

This now exists! https://github.com/snakemake/snakefmt
Should we close issue?


Update cargo in beta

Pick up rust-lang/cargo#3022 and rust-lang/cargo#3010

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)


build_agent.sh fails while trying to go through tutorial

Describe the bug
I'm trying to go through the "first application linux" tutorial, but am getting a build error that is preventing the micro_ros_agent from finishing its build.
To Reproduce

System Description:
-Ubuntu 20 running in a VirtualBox with windows 10 host
-Installed ROS2 Foxy using standard install procedure, confirmed working with pub/sub example
Followed all steps here: https://micro-ros.github.io/docs/tutorials/core/first_application_linux/  (Not using the docer method)
On running this step:  --> $ros2 run micro_ros_setup build_agent.sh
Output:
Building micro-ROS Agent
Starting >>> microcdr
Finished <<< microcdr [0.30s]
Starting >>> microxrcedds_agent
Finished <<< microxrcedds_agent [0.64s]
Starting >>> rosidl_typesupport_microxrcedds_c
Finished <<< rosidl_typesupport_microxrcedds_c [0.38s]
Starting >>> micro_ros_msgs
Finished <<< micro_ros_msgs [1.54s]
Starting >>> micro_ros_agent
--- stderr: micro_ros_agent
/usr/bin/ld: warning: libfastrtps.so.2, needed by /home/andrewgillies/ros2_foxy/ros2-linux/lib/librmw_fastrtps_shared_cpp.so, may conflict with libfastrtps.so.2.0.2
/usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to fmt::v6::internal::basic_data<void>::signs' /usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to spdlog::logger::log_it_(spdlog::details::log_msg const&, bool, bool)'
/usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to int fmt::v6::internal::snprintf_float<double>(double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)' /usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to std::__cxx11::basic_string<char, std::char_traits, std::allocator > fmt::v6::internal::grouping_impl(fmt::v6::internal::locale_ref)'
/usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to int fmt::v6::internal::format_float<long double>(long double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)' /usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to int fmt::v6::internal::snprintf_float(long double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer&)'
/usr/bin/ld: /home/andrewgillies/uagent/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.1.4.2: undefined reference to `int fmt::v6::internal::format_float(double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer&)'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/micro_ros_agent.dir/build.make:172: micro_ros_agent] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/micro_ros_agent.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Failed   <<< micro_ros_agent [0.65s, exited with code 2]
Summary: 4 packages finished [3.80s]
1 package failed: micro_ros_agent
1 package had stderr output: micro_ros_agent

Good morning,
I'm afraid we would need more details about which specific Ubuntu image you mounted using VirtualBox and double check if you missed some of the commands in the tutorial. For me, it is working as expected, running on a Ubuntu 20.04 Focal Docker container.
That being said, this error seems to be related to some fmt library missing on your system. Did you try:
sudo add-apt-repository universe
sudo apt-get update
sudo apt-get install libfmt-dev

, then recompiling the agent with the steps provided? The only thing in the agent that is using some headers related to this library is the logger, to display information about the agent's status in the screen.

Hey,
Even I'm facing the exact same error. I just saw the issue here(after posting it myself here) and tried the solution you suggested, to download fmt lib. But still, the error persists. It'll be really helpful if you can look into it, and please let me know if you need something else.

Same error for me on Ubuntu 20.04.2 LTS even after executing the suggested commands to install fmt.

I now able to build and execute the agent (not using the docker container).
There are several ROS2 official install tutorials and they appear to install/source ROS2 in differently thus breaking the micro-ros-agent build process.
My process:
Install Ubunutu 20.04.
Install ROS2 via Debian packages (I installed the desktop version): https://docs.ros.org/en/foxy/Installation/Ubuntu-Install-Debians.html
Install rosdep2: sudo apt install python3-rosdep2
Install colcon: sudo apt install python3-colcon-common-extensions
Install micro-ros: https://micro.ros.org/docs/tutorials/core/first_application_linux/
I am really excited to get micro-ros working with my project, thanks for the hard work!

Machine: Jetson Nano
OS: Ubuntu 18
Running Docker image: dustynv/ros:foxy-ros-base-l4t-r32.6.1

As I'm going through the steps in https://micro.ros.org/docs/tutorials/core/first_application_linux/, until build step of  "Creating the micro-ROS agent" ros2 run micro_ros_setup build_agent.sh, I've a similar error:
Your branch is up to date with 'origin/foxy'.
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
rclc_lifecycle: No definition of [osrf_testing_tools_cpp] for OS version [bionic]
rclc: No definition of [osrf_testing_tools_cpp] for OS version [bionic]
root@caremnano2-desktop:/home/microros_ws/microros_ws# ros2 run micro_ros_setup build_agent.sh
Building micro-ROS Agent
Starting >>> builtin_interfaces
Starting >>> micro_ros_msgs
Starting >>> microxrcedds_agent
Finished <<< microxrcedds_agent [2.40s]
Finished <<< micro_ros_msgs [4.28s]
Finished <<< builtin_interfaces [29.0s]
Starting >>> micro_ros_agent
--- stderr: micro_ros_agent
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `fmt::v6::internal::basic_data<void>::signs'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `spdlog::logger::log_it_(spdlog::details::log_msg const&, bool, bool)'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `int fmt::v6::internal::snprintf_float<double>(double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > fmt::v6::internal::grouping_impl<char>(fmt::v6::internal::locale_ref)'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `int fmt::v6::internal::format_float<long double>(long double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `int fmt::v6::internal::snprintf_float<long double>(long double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)'
/home/microros_ws/microros_ws/install/microxrcedds_agent/lib/libmicroxrcedds_agent.so.2.0.0: undefined reference to `int fmt::v6::internal::format_float<double>(double, int, fmt::v6::internal::float_specs, fmt::v6::internal::buffer<char>&)'
collect2: error: ld returned 1 exit status
make[2]: *** [micro_ros_agent] Error 1
make[1]: *** [CMakeFiles/micro_ros_agent.dir/all] Error 2
make: *** [all] Error 2
---
Failed   <<< micro_ros_agent [1.83s, exited with code 2]

I tried the suggestion by @jamoralp and it says libfmt-dev is already the newest version (4.0.0+ds-2). 0 upgraded, 0 newly installed, 0 to remove and 11 not upgraded.
Can someone help me?

We just added a flag to use the system version of spdlog: https://github.com/eProsima/Micro-XRCE-DDS-Agent/pull/303 and https://github.com/micro-ROS/micro-ROS-Agent/pull/118
Agent build should succeed with this flag enabled:
colcon build --cmake-args -DUAGENT_USE_SYSTEM_LOGGER=ON

I solved this on my horizon rdk x3 arm board, by compile a 6.x version fmt. I'm using ubuntu 20, and I compiled fmt-6.1.2.
wget https://github.com/fmtlib/fmt/archive/refs/tags/6.1.2.zip
unzip 6.1.2.zip
cd fmt-6.1.2
mkdir build && cd build && cmake .. && make -j4
sudo make install

I compiled and installed fmt just before ros2 run micro_ros_setup build_agent.sh by the way.


fixed minor bugs

Fixed the stay/leave message bug
Fixed the manage watershed modal bug
Added GetWatershed function to API
Updated API documentation

The other RAPIDpy problem turned out to be a dependency versioning problem. netCDF4 1.2.9 was causing problems with the dataset function of RAPIDpy. I just reverted netCDF4 to 1.2.2, which is the one we have in out tethys1.4 production server. We will probably want to look at this in more depth later.
Thanks,
Michael

@msouff, this looks great. Thank you for your contribution!


option for flipping X when generating DP

I agree, I'll change it later. It was a quick workaround.


Required license?

Does the migration require M365 Business Premium licenses as the lowest license plan or is this just the chosen license for the guide?

Hello @CharLind87. Can you tell us to which article(s) your feedback applies? This information will help us route the issue to the correct writer/team. Thank you!

Hi,
Sorry it's referring to this page: Switch from Google Workspace to Microsoft 365 for business | Microsoft Docshttps://docs.microsoft.com/en-us/microsoft-365/business-video/moveto-microsoft-365/move-from-google-workspace-overview?view=o365-worldwide
From: Denise Vangel-MSFT @.>
Sent: den 28 december 2021 19:51
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Charlotte Lindberg @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Required license? (Issue #7268)
Hello @CharLind87https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCharLind87&data=04|01|charlotte.lindberg%40microsoft.com|ff386b012a704cc19fb808d9ca32f816|72f988bf86f141af91ab2d7cd011db47|1|0|637763142578515372|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=27uN2IPJJZW5593NtTEc6nqljS4AHdLYNAXeJ8x04O4%3D&reserved=0. Can you tell us to which article(s) your feedback applies? This information will help us route the issue to the correct writer/team. Thank you!

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F7268%23issuecomment-1002237872&data=04|01|charlotte.lindberg%40microsoft.com|ff386b012a704cc19fb808d9ca32f816|72f988bf86f141af91ab2d7cd011db47|1|0|637763142578515372|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ET%2FlgsrPZPhkfDm%2B%2BDwyhJPkfJT4zpjbZkAyybqTbrg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWIQ4UFOLGWFLFQF2UGD2ZTUTIBIVANCNFSM5K33XDXQ&data=04|01|charlotte.lindberg%40microsoft.com|ff386b012a704cc19fb808d9ca32f816|72f988bf86f141af91ab2d7cd011db47|1|0|637763142578515372|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=U8v4J5byy%2FxmEstuUu8Ek5Xil30aPdEijCPlRnkkPzk%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|charlotte.lindberg%40microsoft.com|ff386b012a704cc19fb808d9ca32f816|72f988bf86f141af91ab2d7cd011db47|1|0|637763142578515372|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2BSdZiO4Rgoo6Ur1KSLhjJ6Tg3PJ2ovg7J38%2BfEOnpZw%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|charlotte.lindberg%40microsoft.com|ff386b012a704cc19fb808d9ca32f816|72f988bf86f141af91ab2d7cd011db47|1|0|637763142578515372|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=n6KkJj958EIyflS1uwiHJ8OvS67zaVWlwxlTNdgTNMk%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@CharLind87 Thank you for your feedback. This document pertains to switching from Google Workspace to Microsoft 365 for business. out of the three flavors available in M365 for business, only M365 Business premium has all the options like Security, Office install, etc. So I'd say for this guide the minimum requirement is M365 Business premium.
We also have another document - https://docs.microsoft.com/en-us/exchange/mailbox-migration/perform-g-suite-migration which talks about the migration from Googleworkspace in general and that might be helpful.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @CharLind87 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


dub01 redirected you too many times error trying to display Embedded Vizs

Since the 2023.2 on our dub01 Tableau Cloud site some users are no longer able to open Vizs embedded with the Embedding API if a Connected App JWT is used, they are hit with a "dub01.online.tableau.com redirected you too many times" error:

It happens for a specific set of users, other users with the exact same site role/authentication are able to open the same Vizs.
It's not related to the authentication: affected users are using both "Tableau" and "Google" authentication
The same users can open Vizs with Connected App JWTs in other Tableau Cloud sites
Other users can open the same Vizs using the same Connected App
The affected users have the same issue when they try to display embedded Vizs without a Connected App JWT

Thanks for reporting this @florent-guinard. I have notified the team, and will get back to you when I know more.

The team has a few questions:

Is it possible to get more information on exactly when this started happening and if the issue remains?  Perhaps after clearing cookies for the affected users?
Is it possible to grab a screenshot of the network tab when the viz is loading? (I'm interested to see which Connected Apps login API is being used)
Are there vizportal logs I can get?  (if this is a Tableau Cloud customer, knowing the pod and site would hlp)

If you are on the #DataDev slack workspace, you can also share the information there in private with me

This is happening to us too on one of the sites. Tried reverting to version 3.5.0 and it is still happening. Cleared cookies, still a problem.

@ewaldhofman-sf I shared those information with you directly in Slack.

so... what's the solution to the problem?

so... what's the solution to the problem?

@VictorChirita using a full lowercase site name in the Viz URL.


Change link to russian translation

Hi!
I translated css-style-guide (current version of translation incomplete).

@talklikethat sorry this has taken so long; I'm still looking for a Russian speaker to review this. Would you like to reopen?

@ljharb I found some mistakes in translation. First I want to fix them

Thank you! Please reopen and force push when you're ready.


Add workaround for skipped breakpoints

See https://github.com/ruby/debug/issues/900

Note: We may go with https://github.com/Shopify/debug/pull/4 instead.


CI: bump Rust to 1.62.0

Coverage remained the same at 59.323% when pulling f1a7cc625a6956bcfa7fed4cc8ff2c7aa0da380e on feature/ci-bump-rust into f0af242c073b79dd2e9dd441c3fbca3f74a88e63 on master.


Multirow statements inserts wrong semicolon

Describe the bug
After the replaced values in the multirow statement it always inserts a semicolon. Code
This only works if the insert has the values at the end of the statement.
Insert into values (?,?,?) changes into Insert into table values ('','','');
If we for example use the SQLite Upsert/On Conflict the values are not at the end of the statement.
INSERT INTO users (name, email) VALUES (?, ?)   ON CONFLICT(email) DO UPDATE SET name = excluded.name changes into
INSERT INTO users (name, email) VALUES ('', '');  ON CONFLICT(email) DO UPDATE SET name = excluded.name
This transforms is an invalid statement
To Reproduce
Steps to reproduce the behavior:

Execute the statements from above

Expected behavior
No semicolon is inserted at all.
Desktop (please complete the following information):

OS: Android --> unknown if the same error exists on IOS
Browser chrome
Version 5.7.0

@lasher23 fix in v5.7.3-2 thanks for your contribution

@jepiqueau thank you for merging