document failureIgnored

Changes
Document the status when a taskRun fails but the failure is ignored i.e. it has onError set to continue.
 k get tr pipelinerun-with-failing-task-bgl28-echo-continue -o json | jq .status.conditions
[
  {
    "lastTransitionTime": "2024-07-10T05:27:06Z",
    "message": "\"step-write\" exited with code 1",
    "reason": "FailureIgnored",
    "status": "False",
    "type": "Succeeded"
  }
]

/kind documentation

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] pre-commit Passed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/lgtm

/retest


Expose the effectiveApiMappings as a separate metadata field

Fixes #2399

You'll have to update src/main/resources/contexts/search-metadata.json and src/main/resources/contexts/indexing-metadata.json, for now manually I guess

good catch!


Cannot read property 'x-codegen-request-body-name' of undefined

I added x-codegen-request-body-name and operationId to my openapi.yaml file but still getting errors. Last error was Cannot read property 'x-codegen-request-body-name' of undefined.
Too little error context to solve it, unfortunately.
> codegen -s openapi-fixed.yaml -p my-service
? Do you want to create a database module? not
? Do you want to create a kafka module? not
? Do you want to create a project? Yes
(node:1161517) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'x-codegen-request-body-name' of undefined
    at processingResponseData (/home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/lib/path-response-processing.js:20:30)
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/lib/codegen.js:319:11
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:4967:15
    at baseForOwn (/home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:3032:24)
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:4936:18
    at Function.forEach (/home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:9410:14)
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/lib/codegen.js:181:7
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:4967:15
    at baseForOwn (/home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:3032:24)
    at /home/d9k/.nvm/versions/node/v14.16.1/lib/node_modules/@newko/swagger-nestjs-codegen/node_modules/lodash/lodash.js:4936:18
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1161517) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1161517) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Please provide path to the missing node in the error message

opened MR #5

I know what you're talking about. I'll let you.


refactor: rewrite drawer layout with reanimated

@osdnk it'll be super awesome if you could give this a review (mainly the gesture handler and reanimated related parts)

PR is ready for final review

@satya164 - pushed a small commit here to move overflow: 'hidden' so that contentContainerStyle with shadow works as before on iOS (see parallax example)

this is almost 100% there, i'm still seeing some delays when using a gesture to open the drawer, eg:

tapping items in the drawer: https://streamable.com/jmeg4
tapping the overlay to close the drawer: https://streamable.com/ltvol

in the interest of moving on we could probably live with this and just create issues to follow up on them. up to you!

another small thing i noticed - if you swipe the drawer open and then while it's still settling you try to swipe it back to close it, there is either some jumpiness when you first re-start the gesture or the gesture will sometimes be ignored (possibly also related to whether or not the drawer is marked as open)

since these issues are isolated to ios and may be related to upstream issues on reanimated, i'll land this now!

@osdnk I need your help debugging the issues Brent encountered 🙏

@brentvatne @satya164
Could you say something more about these issues you encountered? Also, it will be great if you open separated issues for these problems

Also, I made sth like this.


Move some common util functions to an individual file

There are some duplicated installation scripts among minikube and vagrant. This PR refactor some common scripts into functions and move them to an individual file - common.sh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
If they are not already assigned, you can assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @m1093782566. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Kindly ping @costinm @baodongli @JimmyCYJ @gargnupur @hklai for review :)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
If they are not already assigned, you can assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
If they are not already assigned, you can assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @costinm

/assign @yutongz

@costinm @yutongz Would you please help review this PR when you have chance?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-unit-tests

prow/istio-presubmit.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-presubmit

prow/istio-unit-tests.sh
b76260f7412d463465af7af74b544baee9d5e7e0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Awesome! Thanks all :)


[SECURITY] node-uuid: crypto not usable

I get this error when running in unit tests:
 console.warn node_modules/coinbase/node_modules/node-uuid/uuid.js:48
 [SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()

It looks like the node-uuid package has been deprecated in favor of  the uuid package.

Same error here.


strikeout the text

Hi I'm new using MathJax and sorry for silly question:
Can one use \sout or something like that to strikeout the text/equations?

Does this work when converting Mathjax documents to pdf files? I seem to have a problem with Jupyter Lab not doing it.
! Undefined control sequence.
<argument> 1 \xcancel
                      {+ exp(\hat {\beta _0} + \hat {\beta _1}x)} \bcancel {...
l.1199 ...1 + exp(\hat{\beta_0} + \hat{\beta_1}x)}
                                                   \\
?
! Emergency stop.
<argument> 1 \xcancel
                      {+ exp(\hat {\beta _0} + \hat {\beta _1}x)} \bcancel {...
l.1199 ...1 + exp(\hat{\beta_0} + \hat{\beta_1}x)}
                                                   \\

Same with cancel.
I'd like to retain the MathJax Look (if not the feel) in the pdf document as well.

@linusjf, since these are LaTeX error messages, that suggests that you may have to add
\usepackage{cancel}

to your .tex file.  I'm not sure how that is done in Jupyter Lab, so you may have to ask the Jupyter community for the details on how to do that.

@dpvc That seems like a good idea. I'm not too familiar with Jupyter Lab config. It does seem that Jupyter has a macro cancel that works in the browser but not through latex where your suggestion comes in. I'm not sure where to make those updates, though.
Maybe this might help me
https://github.com/jupyterlab/jupyterlab-latex

https://discourse.jupyter.org/t/has-anyone-figured-out-how-to-use-a-latex-package-like-cancel-in-a-markdown-cell/11637
There seems to be the above but I haven't tested it out as yet


helgrind identified modification of a global variable shared by threads without a lock

The static behind aws_logger_set and aws_logger_get are used by multiple threads, however there is no coordinating lock on their access.  On most architectures these operations are atomic, however another problem arises:

Thread A can call aws_logger_get()
Thread B can call aws_logger_set()
Thread B may then delete the original logger that Thread A acquired.
Thread A may try to use the logger and experience... pain.

Obviously the window for this is rather small, but it is still possible.
==15299== ---Thread-Announcement------------------------------------------
==15299==
==15299== Thread #1 is the program's root thread
==15299==
==15299== ----------------------------------------------------------------
==15299==
==15299== Possible data race during read of size 8 at 0x5B46240 by thread #6
==15299== Locks held: none
==15299==    at 0x5779B64: aws_logger_get (logging.c:283)
==15299==    by 0x55EFE93: aws_event_loop_thread (epoll_event_loop.c:607)
==15299==    by 0x577CEED: thread_fn (thread.c:172)
==15299==    by 0x4C37C7C: mythread_wrapper (hg_intercepts.c:406)
==15299==    by 0x665344A: start_thread (in /usr/lib64/libpthread-2.26.so)
==15299==    by 0x723152E: clone (in /usr/lib64/libc-2.26.so)
==15299==
==15299== This conflicts with a previous write of size 8 by thread #1
==15299== Locks held: none
==15299==    at 0x5779B56: aws_logger_set (logging.c:278)
==15299==    by 0x5497F91: Aws::Utils::Logging::DefaultCRTLogSystem::~DefaultCRTLogSystem() (CRTLogSystem.cpp:77)
==15299==    by 0x65B0D4: void __gnu_cxx::new_allocatorAws::Utils::Logging::DefaultCRTLogSystem::destroyAws::Utils::Logging::DefaultCRTLogSystem(Aws::Utils::Logging::DefaultCRTLogSystem*) (new_allocator.h:140)
==15299==    by 0x65B038: void std::allocator_traits<std::allocatorAws::Utils::Logging::DefaultCRTLogSystem >::destroyAws::Utils::Logging::DefaultCRTLogSystem(std::allocatorAws::Utils::Logging::DefaultCRTLogSystem&, Aws::Utils::Logging::DefaultCRTLogSystem*) (alloc_traits.h:487)
==15299==    by 0x65AAE8: std::_Sp_counted_ptr_inplace<Aws::Utils::Logging::DefaultCRTLogSystem, std::allocatorAws::Utils::Logging::DefaultCRTLogSystem, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (shared_ptr_base.h:535)
==15299==    by 0x4B375D: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:154)
==15299==    by 0x4B20B4: std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (shared_ptr_base.h:684)
==15299==    by 0x6581CB: std::__shared_ptr<Aws::Utils::Logging::CRTLogSystemInterface, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (shared_ptr_base.h:1123)
==15299==  Address 0x5b46240 is 0 bytes inside data symbol "s_root_logger_ptr"
==15299==

logger get/set is explicitly called out as not thread-safe at the C level: https://github.com/awslabs/aws-c-common/blob/main/include/aws/common/logging.h#L220
A rework of logging to be thread-safe is something that would be nice to do, but it may be quite a bit of work with potential performance concerns.


Api 4620 basic account behavior fix

Uses query parameter to get relay state
More unit tests

I am getting error messages that seem to pertain to relay state when manually exercising this locally. Could be an issue on my end with config, thought.

I am getting error messages that seem to pertain to relay state when manually exercising this locally. Could be an issue on my end with config, though.

^ The above is referencing the relayStateQuery, which was undefined, on line 27 of utils.js.

Pushed another change. Had the grab in the wrong spot.


Fix documentation deployment process

It seems that new documentation is no longer being published. This PR is an attempt to fix that.

:tada: This PR is included in version 5.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cameraOptions are ignored for CameraKitCameraScreen

CameraKitCameraScreenBase.getOptions() just defines cameraOptions without reading of this.props.cameraOptions. Is it bug?

Also OVERLAY_DEFAULT_COLOR doesn't exist


Increase maximum depth of XML files generated for Maven

The default maximum nesting depth for the XML generator is 4. However, the Maven POM specification contains tags that can only be expressed when nested at a greater depth, preventing the generator from covering some code in MavenXpp3Reader that should otherwise be reachable from the driver - for example, goal in <execution>. This PR increases the maximum depth when generating POM files.
<project>
  <build>
        <plugins>
            <plugin>
                <artifactId>maven-resources-plugin</artifactId>
                <executions>
                    <execution>
                        <id>copy-seeds</id>
                        <phase>test</phase>
                        <goals>
                            <goal>copy-resources</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
      </plugins>
</build>
</project>

Good catch. Thanks!


Error when downloading Facebook video

C:\Users\User\Downloads>"youtube-dl (1).exe" https://www.facebook.com/famhisae.saulaulusavaiinaea/posts/2701399750119689 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.facebook.com/famhisae.saulaulusavaiinaea/posts/2701399750119689', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: none
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>119689: Downloading webpage
ERROR: Unable to extract single video id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\facebook.py", line 479, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 1005, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract single video id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Closing this issue. The link I was trying to download was the not the original source i.e. someone I know was sharing another user's video. I tried again using the original link and it worked fine.
Thank you.


Animation for tomorrow demo

Description
Animation for tomorrow demo
Type of change

Documentation update

Testing steps
N/A

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   49.84%   49.84%
=======================================
  Files          11       11
  Lines         947      947
=======================================
  Hits          472      472
  Misses        418      418
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e7da6...b567831. Read the comment docs.


cmake: Extracted Zephyr module processing into python script

Fixes: #14513
This commit move the functionality of extracting zephyr modules into
generated CMake and Kconfig include files from CMake into python.
This allows other tools, especially CI to re-use the zephyr module
functionality.

Codecov Report

Merging #14667 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14667      +/-   ##
==========================================
+ Coverage   51.98%   52.01%   +0.03%
==========================================
  Files         309      309
  Lines       45584    45584
  Branches    10555    10555
==========================================
+ Hits        23696    23712      +16
+ Misses      17080    17068      -12
+ Partials     4808     4804       -4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/src/ztest.c
72.72% <0%> (+7.43%)
:arrow_up:

subsys/testsuite/ztest/include/ztest_assert.h
77.77% <0%> (+38.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c8e3f...0c3e30f. Read the comment docs.

Thanks for the comments.
Let me give the reasoning for this.

I am uneasy about this. While parsing the modules with Python seems like a good idea, I am not sure about generating CMake files from Python. This is a bit extreme, isn't it?

It was done this way, as to have same principle used for both Kconfig and CMake.
That is, generating a file that can be included by the corresponding tool.
Secondly, as commented by @SebastianBoe output from scripts should ideally go through a file, and thus, instead of generating text file with a list of folders to include, which then must be parsed by CMake, then I decided to generate the CMake file directly.
See https://github.com/zephyrproject-rtos/zephyr/pull/13067#discussion_r254696304
Third, if we in future needs to create additional type of files that can be included, e.g. DTS, then that can be supported with --dts-out.
The --cmake-out can be omitted by CI, and just use --kconfig-out, which means CI doesn't need to generate the CMake files for Kconfig verification.

Wouldn't it be better to print a list of paths to CMakeLists.txt from zephyr_modules.py and then have CMake parse that output and call add_subdirectory() on each?

as mentioned, printing directly from scripts is discouraged, so would need to go through a file anyway.

as mentioned, printing directly from scripts is discouraged, so would need to go through a file anyway.

You don't have to print from a script to do this. You can have the python script write a file that is easily parse-able by CMake, e.g csv, or lines of set(FOO bar).
Generally, it is ok to generate data, but not code. There is a fine line between them, but e.g. add_subdirectory looks like code to me.

as mentioned, printing directly from scripts is discouraged, so would need to go through a file anyway.

You don't have to print from a script to do this. You can have the python script write a file that is easily parse-able by CMake, e.g csv, or lines of set(FOO bar).

Yes, that's exactly what i'm stating.
The printing was suggested by @carlescufi:

Wouldn't it be better to print a list

And to that I replied a file should be generated from the Python script in any case, just as you also state.

Generally, it is ok to generate data, but not code. There is a fine line between them, but e.g. add_subdirectory looks like code to me.

As does the Kconfig generated file:
osource "<path>/Kconfig"
I think the add_subdirectory() and osource are similar in nature.
But if it preferred that the CMake output generates a plain file and Kconfig output generates code with osource statements, then I can change.
Remember, the python script is now generic, so that it can be used outside CMake, e.g. for CI.

As does the Kconfig generated file:
osource "<path>/Kconfig"

Yeah, but that's unavoidable AFAICT. But for CMake, we are able to avoid more code generation than in the current proposal AFAICT.

But if it preferred that the CMake output generates a plain file and Kconfig output generates code with osource statements, then I can change.

Yes, this is preferable.

I see that @SebastianBoe aligns with my suggestion. As he mentions, for Kconfig its unavoidable because we are not invoking the python script from Kconfig. But for CMake it's a completely different story since we are actively calling it from the CMake code.

But if it preferred that the CMake output generates a plain file and Kconfig output generates code with osource statements, then I can change.

Yes, this is preferable.

I see that @SebastianBoe aligns with my suggestion. As he mentions, for Kconfig its unavoidable because we are not invoking the python script from Kconfig. But for CMake it's a completely different story since we are actively calling it from the CMake code.

Fixed.
Thanks for the feedback.

@mbolivar @SebastianBoe all comments addressed
Also removed the section from arguments to be internal knowledge, as that is where it correctly belongs.
The section was leftover from the original yaml_to_cmake.py script

Thanks for the review

@carlescufi @SebastianBoe @mbolivar Can you recheck, everything should be fixed :)

@nashif @mbolivar @tejlmand pushed a couple of commits to fix #14989

@mbolivar @nashif @tejlmand this is ready to be merged

@tejlmand @nashif after this is merged, we should remove the equivalent python code in ci-tools/scripts/check_compliance.py and use this zephyr_module.py script instead.

Looks like this broke "hello_world" (and everything else) when not using west. I'm aware not using west is "living in the past", however I didn't really expect this at this time between -rc3 and -rc4. A meaningful error message mentioning (the lack of) west would also be nicer than a cryptic kconfig stack trace. Has the documentation been updated to clarify that west is now mandatory?

Just some comments about style since I guess this won't be merged for v1.14 and we are thus in no hurry

Famous last words :-)

@carlescufi @tejlmand @nashif
Merging this PR has broken my Windows10 build setup:
Here's some log info, when running cmake -GNinja -DBOARD=nrf52840_pca10056 ..:

-- The C compiler identification is GNU 7.3.1
-- The CXX compiler identification is GNU 7.3.1
-- The ASM compiler identification is GNU
-- Found assembler: C:/gccarmemb/bin/arm-none-eabi-gcc.exe
-- Performing Test toolchain_is_ok
-- Performing Test toolchain_is_ok - Success
Including module: tinycbor:C
CMake Warning at ../../../../CMakeLists.txt:1464 (message):

        ------------------------------------------------------------
        --- WARNING:  __ASSERT() statements are globally ENABLED ---
        --- The kernel will run more slowly and use more memory  ---
        ------------------------------------------------------------

-- Configuring done
CMake Error: Cannot open file for write: C:/Users/iogl/Documents/nordic/workspace/zephyr/zephyr/tests/kernel/mem_protect/userspace/build_nrf52840_pca10056_2/tinycbor:C/cmake_install.cmake.tmp
CMake Error: : System Error: Invalid argument

Looks like we are trying to include module tinycbor:C
I am no expert on this, but reverting these commits seem to solve the problem.

@ioannisg : Does #15042 fix it for you? Could you or @marc-hb file a bug for this regression?

This is very strange. A module named "tinycbor:C" is being found by west. Can you please run the following west list -format={posixpath}?


Fix dependancies info

It appears that when installing SounderPy, the dependencies are not installing with it. There may be some issue with the requirements.txt file.
This will be fixed for the next release.

In the meantime before the next release, if you come across this issue,
A requirements.txt file is up here https://github.com/kylejgillett/sounderpy/blob/main/requirements.txt
in your conda environment, you can run:
pip install -r \your-file-path\requirements.txt
This will load the dependencies.

This issue has been resolved with successful tests of v2.0.0


Add support to query local copies of a codebase rather than relying on GitHub's APIs

@julianharty Creating a placeholder issue for this work. For more details please see the earlier ticket #7 which presents a range of approaches.

created a branch 37-add-support-to-query-local-copies-of-a-codebase-rather-than-relying-on-githubs-apis
created a script src/github_repo_request_local.py
wrote the script to clone a repo from a csv and count the file names/path which has the word test in them
was getting an error for the pre-commit stages when tried to push the code, had to run : ruff check  github_repo_request_local.py and pre-commit run --all-files manually and then was able to push the code to the branch

used pathlib package for getting the result
excluded some file extensions from the result ({'.txt', '.md', '.h', '.xml', '.html', '.json'})
realised the parent path is counted into the result . Addressed this
running the script for the first 20 repos
comparing the result with the script I wrote using the github API, I see some differences.
there are some .png and .jpg files that are counted -> will exclude them
there are lot's of .kt files which are counted in the new script in the previous script the test count is 0 but in the new script it is 263 . .kt extension which is commonly known as Kotlin file extension. The Kotlin is a general-purpose cross-platform programming language developed by JetBrains to be fully interoperable with Java. The Kotlin trademark is protected by the Kotlin Foundation.
for some repos I had github API count = 0, but in the new script I have the local count :4 (files are: cloned_repos/reload/tests/peer_link, cloned_repos/reload/tests/test_dtls.py,  cloned_repos/reload/tests/test_message_types.py, cloned_repos/reload/docs/testing.rst)
seems like the new script is more reliable
as I had to run the code multiple times (ran out f space on my hard disk,..) I changed the code to be able to resume the work where it has stopped in the last run
cannot open the default editor in git when trying to put a multiple line commit message--> fix is git config --global core.editor nano
script finished running
investigating the results :  some usernames have changed (warner/magic-wormhole changed to magic-wormhole/magic-wormhole ) and the previous script was not able to count the files but this issue is addressed with the new approach (downloading the repo locally)
Have pushed the code to my branch and raised a PR


Focusing Select items with custom content by typing

Discussed in https://github.com/ariakit/ariakit/discussions/2698

Originally posted by Dremora August  7, 2023
In a Select example, once the select is open, one can type a letter to focus an item that starts with that letter.
I have a slightly modified version of this component that displays emojis in front of text. Typing to focus doesn't work anymore.
Is there any documentation on how this feature is implemented, and how to make it work with custom content?

Hey @diegohaz
Just to clarify, do we want to allow users to customize typeahead behavior or ignore emojis at the beginning of text content?

Hey @diegohaz
Just to clarify, do we want to allow users to customize typeahead behavior or ignore emojis at the beginning of text content?

Ideally, we would allow users to customize the behavior with a callback or something. I'm just not sure about the API. Do you have any  idea?

Ideally, we would allow users to customize the behavior with a callback or something. I'm just not sure about the API. Do you have any idea?

I was considering the following API, but I'm still uncertain about its name.
/**
 * The function that normalizes the text of an item. This is useful when the
 * text of an item is not the same as the text that should be matched.
 *
 * For example, if the text of an item includes an emoji, you may want to
 * normalize the text to remove the emoji.
 */
typeaheadNormalizeText?: (text: string) => string;


Is there a "shield way" to make sure current user is creator for update request?

Let's assume I have Users and Posts, and want to create a UpdatePost mutation and also want to make sure, that only the creator of the post can edit it. I could take the userid from the context (which comes from token auth) and match it with the authorId. But is there a more elegant way to do this via a middleware with graphql-shield?

Ah, I didn't had in mind, that I do have the args parameter in my permission functions.
const isCreator = rule()(async (parent, args, ctx, info) => {     return ctx.user && ctx.user.userId === args.creator; })
should do the trick.
Maybe it's time to add a tutorial and patterns section? :)

It doesn't do the trick, since it doesn't make sense to submit the creator in the args of an updatePost request. So the questions remains.

Hey @Strernd 👋
That’s an interesting question. I would usually tackle it by checking relation on the database before executing the request. What I mean with this is;

We know the id of the Post
We can derive author id from context, as you already pointed out
We can check on the database whether an instance with such id and author exists. If it does, we allow the mutation, otherwise we prevent it.

I don’t think there’s a clearer way to achieve such functionality as you have to make a database connection at least once to ensure relation exists.
I hope this gives you some leads, let me know if you need any help implementing it 🙂

const isCreator = rule()(async (parent, args, ctx, info) => {     return ctx.prisma.exists.Post({id: args.postId, creator: {id : ctx.user.userId}}) })
This is what I ended up with, seems to work, besides the fact, that for example deleting an already deleted post will throw an unauthorized error.

So happy to hear it worked! I encourage you to check out #119 as well. It should solve the “wrong error” problem you have now.
Atop of that, we’ll be releasing a crazy amount of articles, documenation and receipes to make sure everyone can get the best out of shield and your input in thread would be super helpful.
Let me know if you could contribute in any way!


Issue with complexity logic

When doing a custom seed, the logic calculates an incorrect complexity chain. The seed was generated through the following command, which is for Expedition with complexity increased to minium 8
node randomize -p expedition -s SarahSilverman -o seeds/Comp8ExpSeed1-SarahSilverman.ppf
The expected solution was Mist (1), Joo (2), Rings (3), Echo (4), Merman Statue (5), Holy Symbol (6), Demon Card (7), Final Vlad (8)
But the actual complexity chain was (1) Mist + Holy Glasses, (2) Joo + Nose Devil, (3) Final Vlad.

Were these solutions generated and compared on the same version of the randomizer?

https://github.com/3snowp7im/SotN-Randomizer/pull/90


time zone on RHEL/CentOS 7

Time zone doesn't sets correctly inside container. Wrong timing for messages as result.

The fix provided https://github.com/sameersbn/docker-skype/pull/30

Common solution suggested by https://github.com/sameersbn/docker-skype/pull/25


Is it possible to develop a custom HR Connector to ingest Hiring Record for Inbound Provisioning?

The documentation in this app assumes the source HR systems would be Workday or SuccessFactor which already have connectors published in gallery for Inbound User Provisioning.
Is there an option for developers to build similar HR connectors for other On-Premise or Cloud HR apps? One options is to use the API driven inbound provisioning. However, this option doesn't allow packaging the data import functionality from source HR app. It needs to be built outside of the app integration using Logic Apps or something else.
The experience I am looking to build is similar to Workday or SuccessFactors but one for a different Cloud HR system, and package the import package as part of connector probably.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4799808f-5315-db72-9f0e-d83ed12141f8
Version Independent ID: d612c880-bb2e-158d-0b31-a980ddce8d82
Content: Plan cloud HR application to Microsoft Entra user provisioning - Microsoft Entra ID
Content Source: docs/identity/app-provisioning/plan-cloud-hr-provision.md
Service: active-directory
Sub-service: app-provisioning
GitHub Login: @kenwith
Microsoft Alias: kenwith

@MithunChopda
Thanks for your feedback! We will investigate and update as appropriate.

Hi @MithunChopda this Microsoft has not provided a way to build similar HR connectors for other On-Premise or Cloud HR apps. However, you can use the API driven inbound provisioning option, which allows you to build custom connectors for your HR app. This option requires building the data import functionality outside of the app integration using Logic Apps or something else.
If you want to package the import package as part of the connector, you may need to explore other options or work with Microsoft to see if they have any recommendations. It's also worth noting that the documentation you provided assumes that the source HR systems are Workday or SuccessFactors, so it's possible that the process may be different for other HR systems.
I hope this helps! Let me know if you have any other questions.

@MithunChopda
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Why does this sound like a Chat-GPT generated response?

@MithunChopda
No, Still if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Branch protection?

It may be worth considering to protect the main branch from force pushing or deletion, or require status checks before merging. See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets for details.

Yes, this is planned to be done before going to version 1.., which will be dump once the pipeline for version update is fully defined and documented.
Currently still exploring the different solutions in order to find de most easiest and safest one.


IMPROVEMENT IN THE FOOTER SECTION OF THE ABOUT US PAGE

Hello @Anjaliavv51, in the About Us page, some changes can improve the user experience. These changes include:
(i) Adjusting the height of the footer
(ii) Adding proper spacing and padding between elements
(iii) Adding small icons for home, about, services, etc.
(iv) Improving the placement of contents and colors
Please assign me to this task as I would love to contribute.

@Anjaliavv51, I would like to work on this issue. Please assign this to me .

Hey @MD-IRFAN-RAJ I have already raised the issue and commented first. Please raise some other issue

@MD-IRFAN-RAJ it is already assigned.


[Chore] Automatically add header to .cs files

Summary of the Pull Request

StyleCop SA1633 wants header in .cs files
Added header to editorconfig to have it automatically inserted in new .cs files

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

ooo, neat

I didn't know it was possible but I recently saw that in the CommunityToolkit repo and first thought was "Why don't we have this in PowerToys?" 😅


Fix focusable hidden element

I was tabbing through the site when I landed on an element that wasn't visible. It was the Wordle link inside this hidden div.
Adding visibility: hidden makes it non-focusable. :)
https://kittygiraudel.com/2021/02/17/hiding-content-responsibly/

Good catch! Thank you


Add 'clampValue' to DecayAnimationConfig

This allows the user to specify a value at which a DecayAnimation should automatically stop. Similar to the overshootClamping option for SpringAnimation.
:+1:

cc @sahrens this looks convenient but is also addressed already with Interpolations (I think?)

There are times when you want to clamp a value for a specific animation, and not all the time.

Hmm yeah, not sure we want this.  @vjeux?

Perhaps changing clampValue to toValue. Then, using the equation to determine minimum velocity required to travel the specified distance, we can ensure that toValue is reached and never exceeded. This might make the use cases more clear?


Add a performance test script / "performance regression tests"

Currently this is done manually by building Chromium before and after a commit. I think it would be good to have a script, which you can pass two commit hashes and a path to a Chromium source, which will then compare the -d stats result.
Maybe add the functionality to misc/measure.py?
See https://github.com/ninja-build/ninja/pull/1577#issuecomment-517797439

How long does it take to build chromium?

On my 24 core server. About 2 hours.
Its pretty horrible

use ccache, that helps ...

Would it be useful to have smaller but also ubiquitous packages? Maybe in Fortran too, like Lapack that is a couple thousand files mostly in Fortran.
Typically for benchmarking one tries to do several repeated runs to mitigate unpredictable externally-driven slowdowns.
Maybe look to the packages Phoronix frequently uses for build benchmarking?


Updated the path to the Android Sdk.

It looks like that SDK path line has already been updated within broader refactor in #2991. Closing this as it is done.


Classes, Fields and Closures

Support for closures (limited to arrays and constants), which includes fields and globals.
After this PR, the python frontend will extract a "reduced closure" of used elements that live outside the dace context, and include them into the SDFG call.
A dace function (program/method) is defined by its contents, as well as its arguments and closure (which is composed of arrays and **constants):

[x] Disallow numpy view arguments
[x] Support arrays in dace.program closure
[x] Support nested objects as part of the closure, supported by returning a dictionary from the frontend along with the SDFG

[x] Handle different objects with same field names
[x] Native support for compiling dataclass objects with type annotation

[x] Fix/refactor dace program cache to CachedDaceProgram objects with information about the closure constants and argument/closure types

[x] Re-evaluate closures upon call
[x] Cache should have configurable size

LGTM. I assume all the np.copies added to the tests are there because now it is explicitly not allowed to pass NumPy views to top-level DaCe programs?

yes, exactly.


Connect wizard

Implemented connect wizard and clean command
Daniel and i thought about a different usage of the connect wizard:
The connect wizard no longer requires the usage of separate connect and disconnect commands.
Instead, the connect wizard is integrated in all other commands and automatically executed when no device is specified.
The connect wizard needs sudo rights because of the mounting.
We changed the mount location to /var/lib/hydrophonitor/device that the root user home directory doesn't get used.

Great work, thank you guys! We will review asap.

Changes approved, could developer please squash and merge the commits.


Document orchestrator release and version

What this PR does / why we need it:
It updates the project documentation so people can learn how to use the project quicker
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
N/A
Special notes for your reviewer:
N/A
If applicable:

[X] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:
Added documentation for orchestratorRelease and orchestratorVersion

Thanks! I've added a few suggestions :).

/assign @brendandburns

/assign @CecileRobertMichon

/unassign @brendanburns

/unassign @brendandburns


feat(whiskers): add colors object in context

I saw https://github.com/catppuccin/go/pull/10 and was kinda surprised that we overlooked iterating colors, again.
This shortens the whole go lib template to:
package catppuccingo

type {{flavor}} struct{}

// {{titlecase flavor}} flavour variant.
var {{titlecase flavor}} Flavour = {{flavor}}{}

func ({{flavor}}) Name() string { return "{{flavor}}" }

{{#each colors}}
func ({{../flavor}}) {{titlecase @key}}() Color {
	return Color{
		Hex: "#{{this}}",
		RGB: [3]uint32{ {{red_i this}}, {{green_i this}}, {{blue_i this}}},
		HSL: [3]float32{ {{hsl this}}},
	}
}

{{/each}}

This would be fantastic, along with the HSL changes I mentioned in Discord in a separate PR.

This would probably be a good time to use the new standardized palette format that I talked to @backwardspy about;
e.g. iterating over accents would be doable now via:
    let accent_names = ["rosewater", ..., "lavender"];
    context["colors"] = colors
        .into_fields_iter()
        .map(|(name, c)| {
            (
                name.to_string(),
                json!({
                    "hex": c.hex().to_ascii_lowercase(),
                    "isAccent": accent_names.contains(&name),
                }),
            )
        })
        .collect();

which could be used like
{{#each colors}}
{{#if this.accent}}
func ({{../flavor}}) {{titlecase @key}}() Color {
	return Color{
		Hex: "#{{this.hex}}",
		RGB: [3]uint32{ {{red_i this.hex}}, {{green_i this.hex}}, {{blue_i this.hex}}},
		HSL: [3]float32{ {{hsl this.hex}}},
	}
}

{{/if}}
{{/each}}

The use case for ports would be {{#each colors}} {{#if this.accent}} {{/if}} {{/each}}, and for passing down the isAccent info to libraries.

This would be fantastic, along with the HSL changes I mentioned in Discord in a separate PR.

After a second look, I'm actually not a fan of using functions to generate the colors, I think it'd be better if all the colors came from our color definitions first.
E.g. {{color.hex}} over {{color}}, {{color.rgb}} over {{rgb color}}.
When you use colormath functions, we can always access the underlying hex/hsl/(whatever is needed) value from the color object, so {{darken color.hex}} would still work.
tinycolor2 works like this, it carries the original inputs until the string is rendered:
$ deno
Deno 1.37.1
> import tinycolor from "https://esm.sh/tinycolor2"
undefined
> tinycolor("#000")
{
  _originalInput: "#000",
  _r: 0,
  _g: 0,
  _b: 0,
  _a: 1,
  _roundA: 1,
  _format: "hex",
  _gradientType: undefined,
  _ok: true
}

After a second look, I'm actually not a fan of using functions to generate the colors, I think it'd be better if all the colors came from our color definitions first. E.g. {{color.hex}} over {{color}}, {{color.rgb}} over {{rgb color}}. When you use colormath functions, we can always access the underlying hex/hsl/(whatever is needed) value from the color object, so {{darken color.hex}} would still work.

@nekowinston that's actually how whiskers worked originally, but i hit several issues passing full objects around the handlebars context, specifically when accepting them as arguments to the helper macros. after fixing that (by not using the helper macro), i ran into another issue with (darken red 10).hsl not being valid syntax. i ultimately settled on darken red.hsl 10, as you've suggested, but that meant every helper had to be able to parse every supported colour format (because they receive the hsl string, not the full colour object, and use the successful parser as the helper's output format. as far as i can tell there is no way to separate what the helpers receive as their arguments and what would be rendered into the final output.
that's why it's now colours-as-hexcodes with helper functions to convert them into other formats, because things like hsl (darken red 10) do work, the helpers only ever have to input & output hex codes, and the code is quite significantly simpler than the previous solution.
if you know of a way to make that all work with rich colour objects, i would certainly be interested in seeing it. the theory is nice, i just could not make it work well.

that aside, this pr looks great. thanks, like you i'm not sure how we missed this off as a feature again!

ran into another issue with (darken red 10).hsl not being valid syntax.

  {{ lookup (darken colors.pink 10) "hex" }}

would work, using subexpressions, but I'm not sure if I'm a fan of that. 🤔
Another option would be having an optional paramter, e.g
  {{ darken colors.pink 10 "rgb" }}

Quick Gist in Deno https://gist.github.com/nekowinston/c3626cce3ad72eb84718cf74393e8e87

sounds good, let's play with some designs on a dedicated issue and i'll approve this PR


Unable to add environment type selector in resource definition matching rule

Describe the bug

Steps to reproduce

New a resource definition.

Add a selector in the matching rule and save.

Check the resource definition.

Result

No selector returned.

Expected behavior

Environment

Walrus version: main 8ff16bfe4326036642753b1ba895fa5b0e3b1791
UI version: dev-567aeb4

Additional context
Add any other context about the problem here.

@hibig EnvironmentType -> EnvironmentTypes

Environment

Walrus version: main 8ff16bfe4326036642753b1ba895fa5b0e3b1791
UI version: dev-7590f46

Test Result:  Add one more empty environment type.

Environment

Walrus version: main 8ff16bfe4326036642753b1ba895fa5b0e3b1791
UI version: dev-7590f46

Test Result: pass
Cannot use the definition created in the old version. Otherwise, it will result in adding an empty item.


Copy-SqlSpConfigure, fix

Fixes #513
Changes proposed in this pull request:

Remove reconfigure with override command - prevent putting SQL in a bad state
Include notification for configs that require an instance restart to take effect
Removed adjusting "show advanced options" as it's not required when making config changes via SMO (this appears to impact TSQL only0

How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

Works on all of the above


Report pages 404

Submitter: Christian Haschek
Email<EMAIL_ADDRESS>Hello! I have created a gitreport repo a few months ago without problems but I recently tried to create two more and I can change all settings but when I click the "Public URL" link I always get a 404 for all new repositories. Link: https://gitreports.com/issue/chrisiaut/brg1
Am I missing something or is it limited to one repo on this hosted site?
Best regards,
Chris

I think found what's causing the problem as i am experiencing the same problem just right now.
Extra detail that is very important - i am making a git report for a friend's github repo, so i do not own it, i am only a member.
Now, in https://gitreports.com/repositories/ [some number], the public link goes to https://gitreports.com/issue/Jeremiidesu/osu-rank . This leads to a 404.
After a few minutes, however, i found out that the link in https://gitreports.com/profile is different than the one in the repositories page.
It is https://gitreports.com/issue/Mark9870/osu-rank which then, does not have a 404 and is the form page. If i try to submit a report from there however, it goes to /Jeremiidesu/osu-rank and results in a 404, and thus no report is sent to the repo.

Hey,
same here (https://gitreports.com/issue/vatbub/zorkClone) but I am actually the repo owner of that repo

Hmm, will anything happen here soon?

ok, I've been digging around the issue now for myself and I found out that the 404 actually comes from the GitHub API, but I still don't know , why

I believe this was caused by a GitHub API change -- fixed by upgrading to the latest version of octokit.

As of today this bug is still existent for me!
I've successfully used Gitreports in the past but I tried to hook up a new repo of mine and I get the same 404 as well (https://gitreports.com/issue/loehnertz/HSRMMedialabTimetableApp).
Was there a change in the GitHub API once again?
Deactivating and re-activating it brings no luck.

Sorry to hear you're still having trouble. Feel free to investigate and send a PR!
I will look into it when I can but my schedule is currently very full (and, needless to say, Git Reports is a free service).


Update: to 7fd5226 -- 20191127

superseded by: https://github.com/bincrafters/conan-crashpad/pull/9


Load VAE from single file.

When trying to load vae, it seems to require a config file, but not all of them have configs.
For example https://huggingface.co/stabilityai/sd-vae-ft-mse-original

You can try loading vae like this:
colab.pipe.vae = AutoencoderKL.from_single_file("path/to/file").to("cuda")

Right now I'm reworking UI a little, an when I'm done it will support loading vae from single file.


5-point landmark detector

It would be great to port the dlib 5-point landmark detector to this framework.
https://github.com/davisking/dlib-models/blob/master/shape_predictor_5_face_landmarks.dat.bz2
Right now, to perform the entire recognition pipeline on a new photo, it requires:

Detection net: 22MB
68-point landmark net: 29MB
Recognition net: 22MB

Or around 73MB total, making it a bit unwieldy for most public-facing applications.
The dlib 5-point landmark net is only 5MB, and just as useful for alignment as the 68-point landmark net. This would bring the total from 73MB down to 49MB. In theory, it might be possible to use quantization too as described in #11 bringing the overall size closer to 12MB.

Hi Kyle,
I am not sure if it is trivial to port the dlib 5 point face landmark model to tfjs. As far as I know it is not CNN based (correct me if I am wrong). But in theory I think it should be enough to come up with a simple CNN for 5 point face landmarks, like the 68 point face landmark CNN, just with less conv layers/ conv params, to reduce the overall size.
Regarding the quantization, I am already working on it. The quantized 68 point landmark model is 7MB. The face detection and recognition weights will be ~5MB each. For running the full pipeline, this will be ~17MB.
If everything works out, I will get this done today.

Sorry, you're right about the 5 point detector being non-CNN. I missed this.
I supposed in theory it would be possibly to prune the last layer of the 68-landmark model to only produce 5 outputs instead of 68, but without knowing the exact architecture of the 68-landmark model it's hard to say how much that would actually save.
Super exciting to have the models be smaller! I have something I'm building now that relies on that. I'm going to close this issue since it was sort of misguided :)


docs: update code snippets and text across multiple documentation files

:rocket: This PR description was created by Ellipsis for commit 62919b2cf25813d1fc366c89d62e77dbc55b3854.

Summary:
This PR updates code snippets and text across multiple documentation files to improve clarity and accuracy, and also updates the test file test_docs.py.
Key points:

Updated code snippets in multiple documentation files.
Minor text modifications to improve clarity and accuracy.
Changes spread across multiple concepts including caching, lists, handling missing data, models, parallel tools, partial responses, validation and reasking, types, and usage.
Updated the test file test_docs.py.

Generated with :heart: by ellipsis.dev

@hbrooks is it reviewing post merge?


[test] Update MpiTCheck for Alps

E       assert 34.729532957077026 < 30
unittests/test_schedulers.py:336: AssertionError

@jgphpc Just retry the CI, it happens sometimes.

Codecov Report

Merging #1663 (8e78022) into master (eb5630e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1663   +/-   ##
=======================================
  Coverage   87.23%   87.23%
=======================================
  Files          45       45
  Lines        7546     7546
=======================================
  Hits         6583     6583
  Misses        963      963

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5630e...8e78022. Read the comment docs.


Null Percentage Bugfix

Notes
This is a small PR going into 372.
Fixed

new null profiling module with a few tests
replaced null calculation with new module
moved series and frame assertions to tests helpers
typo noted earlier

Things to test

[ ] imputation now prints a table of imputed values per column if any are found.
[ ] warning should not have typo

Expected Output:
Note: Numeric imputation will always occur when making predictions on new data - otherwise rows would be dropped, which would lead to missing predictions.

Imputed values for numeric columns:
╒═══════════════╤═══════════════════╕
│ Column        │   Percent Imputed │
╞═══════════════╪═══════════════════╡
│ SystolicBPNBR │             0.013 │
├───────────────┼───────────────────┤
│ LDLNBR        │             0.013 │
├───────────────┼───────────────────┤
│ A1CNBR        │             0.013 │
╘═══════════════╧═══════════════════╛

Looks good. tabulate makes much nicer output than the R package. Only thing here is that the model trainer prints the imputation values twice:

Merging. Tests are failing due to a known issue #414


Selected Screen

Is there anyway to find which screen it is selected on? Sorry, I am new to this.

Hi. Simple way of finding selected screen could be by making use of onTransitionStart / onTransitionEnd component props. If we consider Autoplay slider
const AutoplaySlider = withAutoplay(AwesomeSlider);

<AutoplaySlider
                play={true}
                cancelOnInteraction={false} // should stop playing on user interaction
                interval={6000}
                cssModule={AwesomeSliderStyles}
              >

and add mentioned props
onTransitionStart={ e => { console.log(`Changing from: ${e.currentIndex}`); }}
onTransitionEnd={ e => { console.log(`Changed to: ${e.currentIndex}`); }}

You will get slide index. onTransitionStart replies current index just before transition and onTransitionEnd after slide change so you would get behaviour:
Changing from: 0
Changed to: 1
Changing from: 1
Changed to: 2

Besides currentIndex property u can access other interesting props, here's quick look:


Feature/msi filetype

[X] Match msi extensions to WINDOWS

@SamyPesse any chance to merge this feature for next release?
thanks

@JPeColCom Sorry for being late.
This PR seems to be doing much more than just adding MSI support. Can you explain why all of these changes are required?

Hi, I merged the project to a new repo to start maintain it, I would be glad if you can put your pull request here : https://github.com/loprima-l/nuts-2


Fix demo to prevent memory leak on device orientation change

This is as recommended in https://github.com/daimajia/AndroidImageSlider/issues/41
I verified that the leak is fixed with this change.
I also updated the wiki: https://github.com/daimajia/AndroidImageSlider/wiki/Start-Using

@zhouqiangWang I was just looking at your https://github.com/daimajia/AndroidImageSlider/pull/103
Does the code in destroySelf() do the same as this fix?
If yes, I'll close this and undo the changes in the wiki.

@massimobio There are still some problem exists in #103, I'll merge #104 firstly.

@daimajia ok, thank you. I'll keep an eye on https://github.com/daimajia/AndroidImageSlider/pull/103 and see how it develops. If I understand correctly, the destroySelf() method does the same thing as this PR but doesn't require the user to add the extra code, so it might be a cleaner solution.


Query for desktop work area

The screen working area is the desktop area of the display, excluding taskbars, docked windows, and docked tool bars.
In windows you get it with (using System.Windows.Forms):
Screen::WorkingArea
https://msdn.microsoft.com/en-us/library/system.windows.forms.screen.workingarea
In java you get it by subtracting screen insets from screen dimensions for each screen since not all screens have these items on them:
 Toolkit.getDefaultToolkit().getScreenInsets(graphicsConfiguration)
I don't know how Java gets them for OSX but it does somehow, possibly someone who knows something about OSX can chime in.
Either method, getting the working area directly, or getting insets and subtracting from screen space works fine, but right now there is no way in GLFW, that I could find, to get this space.
One reason this is necessary is that right now GLFW does not maximize correctly when maximizing a window with no decorations. Instead of taking up the working area when glfwMaximizeWindow() is called it takes up the entire screen (the function works fine for a decorated window). I don't know if that was the intended behavior or not, so I'm not calling it a bug, but the developer needs to be able to decide which behavior they want for undecorated windows as well.
There are other reasons why having the working area is necessary especially for things like floating windows for notifications or other widgets. Generally you want those to not cover the task bar, but you don't want them to be decorated.

This is related to: https://github.com/glfw/glfw/issues/899 as 899 is the behavior that causes the first reason this functionality is needed. However, this functionality is necessary regardless of whether that bug is fixed or not so not closing this.

Fair enough. I won't be adding this to 3.3 but it may be included in 3.4. A work area query could be useful.

I am using GLFW in Java (LWJGL).
In Java we can get "working area" by AWT: Toolkit.getDefaultToolkit().getScreenInsets(conf).
But this fault in case if you have more then one monitor.
This bug is reported before many years and still exists :(
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6899304
In Java doesn't have way how create work-around.
We need to provide working area directly via GLFW.
Please this is urgent for me and maybe for other Java developers.

I believe that on X11, the work are in question can be retrieved with the property _NET_WORKAREA. I can work on this if no one is working on it yet.

@felipefs Please do! I had in mind an interface something like
void GLFWAPI glfwGetMonitorWorkarea(GLFWmonitor* monitor,
                                    int* xpos, int* ypos,
                                    int* width, int* height);

I will get my hands on it when I finish the drag operation for Wayland.

It works on X11!

I will try to make for Windows.
@elmindreda do you prefer a pull request when the implementation is done for all platforms or I can make the pull for each separately? (same question for https://github.com/glfw/glfw/issues/923).

@felipefs I'd prefer a single branch per feature, but you can make a PR of it before implementing for all platforms if you prefer and then add new commits as needed.

X11 implementation is on my branch: https://github.com/felipefs/glfw/tree/workarea
It seems the only way to retrieve the work area of a monitor on Windows is by using the handle HMONITOR and the function GetMonitorInfo. So far, the only way I know to get HMONITOR is by making a callback and pushing it to EnumDisplayMonitors, but it would still require a way to match the HMONITOR with the specified _glfwMonitor (which I don't know how to do in this case.
Here is what I have so far:
static BOOL MonitorEnumProc(HMONITOR hMonitor, HDC hdcMonitor, LPRECT lprcMonitor, LPARAM dwData)
{
	/* If hMonitor is _GLFWMonitor, return using dwData */
	return /* TRUE to continue or FALSE to stop */;
}

void _glfwPlatformGetMonitorWorkarea(_GLFWmonitor* monitor, int* xpos, int* ypos, int *width, int *height)
{
    MONITORINFO monitorInfo;
    HMONITOR hMonitor;
    HDC dc;
    void *data;

    dc = CreateDCW(L"DISPLAY", monitor->win32.adapterName, NULL, NULL);

    if (!EnumDisplayMonitors(dc, NULL, MonitorEnumProc, MAKELPARAM(data)))
        return;

    /* Now the callback got for us the HMONITOR that matches _GLFWmonitor */
    GetMonitorInfo(hMonitor, &monitorInfo);

    DeleteDC(dc);

    *xpos = monitorInfo.rcWork.left;
    *ypos = monitorInfo.rcWork.top;
    *width = monitorInfo.rcWork.right;
    *height = monitorInfo.rcWork.bottom;
}

I suppose I need to make data a type that will hold the sent _GLFWmonitor and hold the returned HMONITOR.

Aaand I got it working. Kinda. I need someone to test the Windows implementation on multiple monitors (as I don't have multiple monitors :P).
Here's my branch for test: https://github.com/felipefs/glfw/tree/workarea
I tested the Windows implementation on my Linux using Wine, and it worked fine. The example simple.c should print the work area on console (sorry for poluting simple.c, @elmindreda 😁)

I'm gathering information about how to make the macOS implementation, but I will need help, as I'm not a Objective-C programmer.
There is two approaches related with screen space that I found, but I'm not sure that any of them have the concept of "work area":

NSScreen visibleFrame, but we need to retrieve the NSScreen, probably done with CGDirectDisplayID, which we already have.
CGRect CGDisplayBounds(CGDirectDisplayID id) which is easier than the option above.

What I know about them is that they retrieve values in different formats (one is relative to the main monitor, so might return negative values, the other is absolute).
Here's a sketch of the 2nd approach:
void _glfwPlatformGetMonitorWorkarea(_GLFWmonitor* monitor, int* xpos, int* ypos, int *width, int *height)
{
    const CGRect bounds = CGDisplayBounds(monitor->ns.displayID);
    /* Get the values from CGRect */
}

After some research, I have some code, but I need someone to review (I'm' not a Objective-C programmer):
void _glfwPlatformGetMonitorWorkarea(_GLFWmonitor* monitor, int* xpos, int* ypos, int *width, int *height)
{
    NSScreen *resultScreen;
    for (NSScreen *screen in [NSScreen screens]) {
        if ([[[screen deviceDescription] valueForKey:@"NSScreenNumber"] intValue] == monitor->ns.displayID) {
            resultScreen = screen;
            break;
        }
    }

    NSRect frameRect = [[NSScreen resultScreen] visibleFrame];

    *xpos = NSMinX(frameRect)
    *ypos = NSMinY(frameRect)
    *width = NSMaxX(frameRect)
    *height = NSMaxY(frameRect)
}

Those NSMaxX and NSMaxY probably mean "right" and "bottom", instead of "width" and "height", but we can test first.

Wayland and Mir implementation
I was reading this blog post of the Gtk development team, and found this:

On Mir, a MirSurfaceSpec is created, while on Wayland an xdg_positioner object is created. On X11, Windows and Mac OS X, the backends can use the available global positions as well as monitor work areas and calculate an optimal position just as before.

There is already a basic proof-of-concept in the Mir backend, and a Wayland implementation is in progress.

It seems that Wayland still doesn't provide a way to check for the work area, and currently the job is done using the XDG extension (but do we want to add that dependency when there's already work in progress for that?). As for Mir, there's only the proof of concept, but nothing on the documentation that I could find. Also there's the cloudy future of Mir.

You can use Code from the Qt Framework. They have very nice class QScreen with have a method named availableGeometry() which does exactly what you are looking for. :)
http://doc.qt.io/qt-5/qscreen.html#availableGeometry-prop


"files.trimFinalNewlines" enabled, doesn't work when file only contains newlines.

VSCode Version: 1.22.2
OS Version: OS X 10.13.3

Steps to Reproduce:

Set files.trimFinalNewlines in settings to true.
Create a new file. Add some newlines. Save it. The newlines are not collapsed into a single one (i.e. an empty file).
Instead, the newlines should be collapsed, essentially making the file empty.

Does this issue occur when all extensions are disabled?: Yes

Ping @AiryShift ?


#34 fix error activiti component

Codecov Report

Merging #36 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development      #36   +/-   ##
============================================
  Coverage        91.45%   91.45%
============================================
  Files                1        1
  Lines              117      117
  Branches            13       13
============================================
  Hits               107      107
  Misses              10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2fdda...7dfdf30. Read the comment docs.


How to configure multiple connections to a couchbase cluster?

Do I have to use moxi or is it also possible to configure in msm?
What is recommended?

Any update on this?

One question would be what you're going to achieve. Failover, Loadbalancing? AFAIK/IIRC the couchbase client already provides failover, but I could be wrong so you should check the current state and exact properties of the client.

To achieve failover when one couchbase server goes down. Can I specify multiple nodes in the memcachedNodes property? Or does the :8091/pools already exposes all the cluster nodes?

Ah I found an example here https://github.com/magro/memcached-session-manager/issues/291. The property can take multiple hosts I see.

Correct, great that you found it! :-)
So can we close this issue?

Yes this issue can be closed, thanks!


Only the last image is output when processing a list of images with a Replicate NODE

Only the last image is output when processing a list of images with A Replicate node
Description:
When sending a list of images to the Replicate model for processing, all images are correctly processed according to the logs and the Replicate backend. However, only the last image in the list is output to the subsequent nodes (e.g., VHS Combine node and Save Image node), while the previous images are not passed along as expected.
Steps to Reproduce
Set up nodes:
Use the Replicate model node (e.g., philz1337x/clarity-upscaler) to process a list of images.
Connect the output of the Replicate model node to both the VHS Combine node and the Save Image node.
Execute the batch:
Provide a list of images to the Replicate model node for processing.
Execute the nodes.
Expected behavior:
All processed images from the list should be output to the VHS Combine node.
All processed images should be individually saved by the Save Image node.
Actual behavior:
Only the last image in the list is output to the VHS Combine node and saved by the Save Image node. Previous images are not passed along or saved.
Possible Cause
The issue might be related to how the output from the Replicate model node is being handled or passed to subsequent nodes. It seems that only the final image in the processed list is being output, while the previous images are discarded.
Steps Taken to Resolve
Retried with smaller batches and confirmed that the issue persists.
Ensured that all nodes are correctly connected and configured.
Suggested Solution
Investigate and ensure that the node handling logic can correctly pass all images in the list to subsequent nodes rather than only the last image.

Ah, the issue here is that the models do not support batch inputs, it'll make a single call with the first image.
Models with a single input and multiple outputs work.
This is a limitation that I will probably need to work around by batching up API calls when passing multiple inputs. 🤔
How would you want this to work?

so the behaviour I noticed is that it would make multiple calls ( on larger image batches/lists it had a timeout error that unfortunately I didnt log, but with smaller batches this was not an issue ) 1 by 1 & execute properly on the backend. but only 1 image would return from the node at the end of the operation ( I assumed the last one, but it could be the first one as you state here) . I think the expected behaviour observed with a local node, when input is batched images/ image list & output can take batched images / image lists, is to hold all the images & output as a batch/ list.
I will quickly set up a test workflow to demonstrate expected behaviour from a local node as compared to a replicate node & post here

This is at least doing more than I expected it to, so it could be simpler to build out than I'd planned.

LocalImageBatchVSReplicateImageBatch.json
attached is a workflow using a local node (Ultimate SD Upscale) next to replicate clarity node demonstrating expected behaviour. input image directory with X frames ( I suggest 10 for faster response ) & note how the Ultimate Upscale  node outputs a batch which is received properly by VHS video combine

also note the image batch to list node before the replicate node, it seems most local nodes handle this by default ? cant say for certain as I am very new to comfyUI node development but I would say handling image batch & image lists natively would be expected behaviour


Gltf import fails in add_primitives_to_bmesh

Describe the bug
Importing certain gltf files results in an IndexError during import, resulting in only part of the mesh being imported. The info panel gives this error traceback:
Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\__init__.py", line 900, in execute
    return self.import_gltf2(context)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\__init__.py", line 914, in import_gltf2
    if self.unit_import(path, import_settings) == {'FINISHED'}:
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\__init__.py", line 937, in unit_import
    BlenderGlTF.create(self.gltf_importer)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 42, in create
    BlenderGlTF._create(gltf)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_gltf.py", line 49, in _create
    BlenderScene.create(gltf)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_scene.py", line 40, in create
    BlenderNode.create_vnode(gltf, 'root')
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode
    BlenderNode.create_vnode(gltf, child)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode
    BlenderNode.create_vnode(gltf, child)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 51, in create_vnode
    BlenderNode.create_vnode(gltf, child)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 38, in create_vnode
    BlenderNode.create_object(gltf, vnode_id)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 58, in create_object
    obj = BlenderNode.create_mesh_object(gltf, vnode)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_node.py", line 207, in create_mesh_object
    mesh = BlenderMesh.create(gltf, pynode.mesh, pynode.skin)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_mesh.py", line 64, in create
    BlenderPrimitive.add_primitive_to_bmesh(gltf, bme, pymesh, prim, skin_idx, material_idx)
  File "C:\Program Files\Blender Foundation\Blender 2.83\2.83\scripts\addons\io_scene_gltf2\blender\imp\gltf2_blender_primitive.py", line 228, in add_primitive_to_bmesh
    u, v = uvs[pidx]
IndexError: list index out of range

location: <unknown location>:-1

The file appears normally through BabylonJS or the windows Mixed Reality Viewer
To Reproduce
Steps to reproduce the behavior:

Download the attached zip file
Extract the archive into a folder
Import the .gltf file into blender

Expected behavior
Gltf file should import into scene
Screenshots
Import error:

BabylonJs:

Mixed Reality Viewer:

.blend file/ .gltf
The file is larger than 10Mb, so I'll place a link to download:
https://drive.google.com/file/d/1sxl7u7YpsyV9ZxJ3g0FjnI2C4t31do62/view?usp=sharing
Version

OS: Win10
Blender Version 2.83.0

The indices in your file do appear to be out of bounds. Can you confirm that's correct?
The first error occurs on the mesh MatShape_98500.
cleaned-shirt $ jq .meshes[4] cleaned-shirt.gltf
{
  "name": "MatShape_98500",
  "primitives": [
    {
      "attributes": {
        "NORMAL": 18,
        "POSITION": 17,
        "TEXCOORD_0": 19
      },
      "indices": 16,
      "material": 1
    }
  ]
}

The POSITION accessor has count=64, while the TEXCOORD_0 accessor has count=32
cleaned-shirt $ jq .accessors[17].count cleaned-shirt.gltf
64
cleaned-shirt $ jq .accessors[19].count cleaned-shirt.gltf
32

And the indices accessor decodes to (0, 1, 2, ..., 57, 61, 62), so some of the indices are indeed OOB for TEXCOORD_0.

Thanks for the rapid response, I'll double check the file source. and see what adjustments can be made.
Are there any suggested workarounds in this situation in the meantime? I'm curious as to why they might be loading in other gltf viewers but not Blender.

I believe the viewers are just reading the data from the buffer view outside the range of the accessor.
Here's a quick and dirty patch for the addon that appears to make the import go through

Patch
diff --git a/addons/io_scene_gltf2/blender/imp/gltf2_blender_primitive.py b/addons/io_scene_gltf2/blender/imp/gltf2_blender_primitive.py
index d544778..83dbdad 100755
--- a/addons/io_scene_gltf2/blender/imp/gltf2_blender_primitive.py
+++ b/addons/io_scene_gltf2/blender/imp/gltf2_blender_primitive.py
@@ -42,6 +42,10 @@ class BlenderPrimitive():
             pyprimitive.num_faces = 0
             return

+        pos_count = gltf.data.accessors[attributes['POSITION']].count
+        for acc_idx in attributes.values():
+            gltf.data.accessors[acc_idx].count = pos_count
+
         positions = BinaryData.get_data_from_accessor(gltf, attributes['POSITION'], cache=True)

         if pyprimitive.indices is not None:
diff --git a/addons/io_scene_gltf2/io/imp/gltf2_io_binary.py b/addons/io_scene_gltf2/io/imp/gltf2_io_binary.py
index 7cfcbc4..9f96b0b 100644
--- a/addons/io_scene_gltf2/io/imp/gltf2_io_binary.py
+++ b/addons/io_scene_gltf2/io/imp/gltf2_io_binary.py
@@ -55,7 +55,7 @@ class BinaryData():
         if byte_offset is None:
             byte_offset = 0

-        return buffer[byte_offset:byte_offset + buffer_view.byte_length]
+        return buffer[byte_offset:]

     @staticmethod
     def get_data_from_accessor(gltf, accessor_idx, cache=False):

Just tried out the patch, seems to be working great! Thanks @scurest. I'll run more extensive tests along this week and let you know if there's anything that goes oddly.
Any chance of this patch going into the official addon?

No, it was just a hack to make this one file work. The program that made this glTF needs to be fixed. glTF validator also has other problems with this file (eg. not listing byteStrides).

Alright, understood. I'll pass along all the relevant information. Thanks again for the help!


Set undefined vars, remove unused vars and code that cannot be reached.

Fixes a problem in a log call, and removes some unused/unnecessary code.

Merged into develop. Thanks!


Fix issue #782

Fix the issue triggered when executing cell testing without giving -n flag (#782)

Codecov Report

Merging #786 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #786   +/-   ##
=======================================
  Coverage   53.45%   53.45%
=======================================
  Files          56       56
  Lines        2215     2215
  Branches      218      218
=======================================
  Hits         1184     1184
  Misses        980      980
  Partials       51       51

Impacted Files
Coverage Δ

...ng/src/main/java/io/cellery/impl/RunTestSuite.java
1.7% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1b7ef...00a5b33. Read the comment docs.


[SPARK-6843][core]Add volatile for the "state"

Fix potential visibility problem for the "state" of Executor
The field of "state" is shared and modified by multiple threads. i.e:
Within ExecutorRunner.scala

(1) workerThread = new Thread("ExecutorRunner for " + fullId) {
  override def run() { fetchAndRunExecutor() }
}
 workerThread.start()
// Shutdown hook that kills actors on shutdown.

(2)shutdownHook = new Thread() {
  override def run() {
    killProcess(Some("Worker shutting down"))
  }
}

(3)and also the "Actor thread" for worker.

I think we should at lease add volatile to ensure the visibility among threads otherwise the worker might send an out-of-date status to the master.
https://issues.apache.org/jira/browse/SPARK-6843

Test build #30020 has started for   PR 5448 at commit a2386e7.

From the the code of worker , we can see it pass through the state without any guard, but the state of executors might be changed by the other threads.
case RequestWorkerState =>
  sender ! WorkerStateResponse(host, port, workerId, **executors.values.toList**,
    finishedExecutors.values.toList, drivers.values.toList,
    finishedDrivers.values.toList, activeMasterUrl, cores, memory,
    coresUsed, memoryUsed, activeMasterWebUiUrl)

Test build #30020 has finished for   PR 5448 at commit a2386e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30020/
Test PASSed.

I think that's technically right, although I find there are probably hundreds more fields in Spark that should be @volatile (or else designed so as to not be shared state across threads). It's OK to fix but rather than peck at the problem, can you identify any logically similar changes that need to happen? in this class, or, in similar 'state' variables? I don't mean to evaluate every field in the code base, but just to see if we can make this about more than one particular instance.


Detect CronJobs with single-quote imports

cc @viperfx

Coverage decreased (-0.01%) to 69.307% when pulling ea8474878f167e50e0f20cb211cf5ca79f05bdd5 on repro-ci-detect-tarshan into f157e6ba3d15094021d46bed63fa5841ea5f54bc on main.

@allcontributors please add @viperfx for bug


copy_local: false has no effect in paket.references (.NET SDK)

The issue is related to the recently resolved https://github.com/fsprojects/Paket/issues/3154
Use the same steps for reproducing the problem with one change:

do not use copy_local: false in paket.dependencies
instead, in paket.references use Suave copy_local: false

Expected result
On building the project Suave.dll is not copied to the output directory.
Actual result
Suave.dll is copied to the output directory.

I also have this problem. I have tried fiddling with paket.restore.targets, but I cannot make it work. I also cannot find any good documentation on what exactly the options for ExcludeAssets and PrivateAssets mean, and which of those that replaces the old copy local/private flag.

Seems like the <ExcludeAssets>runtime</ExcludeAssets> tag is not inserted into the obj/{project.file}.paket.props file even though the obj/{project.file}.%(Identity).paket.resolved says exclude in for the NuGets marked with copy_local.

The difference between setting copy_local: false in paket.dependencies and paket.references you can see in the generated {projectfilename}.paket.net462.resolved file in the obj folder:

set copy_local: false in paket.dependencies:
FSharp.Core,4.5.2,Transitive,Main,exclude
Suave,2.4.3,Direct,Main,exclude

set copy_local: false in paket.references:
FSharp.Core,4.5.2,Transitive,Main,false
Suave,2.4.3,Direct,Main,false

I would think that both should end up with exclude as the last element.

Seems like it's hard-coded to be copy_local: true in the references files (the 4th argument):
https://github.com/fsprojects/Paket/blob/81c7479ed18688e3776a74552fd2b344903e8531/src/Paket.Core/PaketConfigFiles/ReferencesFile.fs#L176

Hmm...the easiest is actually to see the paket.lock file:

set copy_local: false in paket.dependencies:

RESTRICTION: == net462
NUGET
  remote: https://www.nuget.org/api/v2
    FSharp.Core (4.5.2) - copy_local: false
    Suave (2.5) - copy_local: false
      FSharp.Core (>= 4.0 < 5.0)

set copy_local: false in paket.references:

RESTRICTION: == net462
NUGET
  remote: https://www.nuget.org/api/v2
    FSharp.Core (4.5.2)
    Suave (2.5)
      FSharp.Core (>= 4.0 < 5.0)

Soooo...why is it ignored in the references file. It says in the docs that this should work:
https://fsprojects.github.io/Paket/references-files.html#Overriding-settings-from

It seems like for new .NET SDK projects, the options provided in the paket.references files are not taken into consideration, since that info is not written to the paket.lock file when running paket install.

It seems that it's broken again for .NET Core 3 Preview.
Here's an example folders. If you change TargetFramework to netcoreapp2.0 in the paket folder then NLog.dll won't be copied to bin. For netcoreapp3.0 it's copied. For standard folder it's not copied either way.
copy_local.zip

You mean core 3 breaks it? /cc @cartermp

It's hard for me to tell what's the reason for it no to work anymore, but with preview 4 installed targeting to netcoreapp3.0 ignores copy_local option. While targeting netcoreapp2.0 don't.


Secure flag broken

When authenticating to a Domain Controller that enforces ldaps, windapsearch throws the following error:
./windapsearch -u 'user@dom' -d 'dom' --dc dc.dom -m computers
Password for [user@dom]:
FATAL[2020-09-29T18:16:57+02:00] LDAP Result Code 8 "Strong Auth Required": 00002028: LdapErr: DSID-0C09027F, comment: The server requires binds to turn on integrity checking if SSL\TLS are not already active on the connection, data 0, v3839  package=windapsearch

Appending the --secure flag is supposed to fix this, but unfortunately it brings up a less helpful error message:
./windapsearch -u 'user@dom' -d 'dom' --dc dc.dom -m computers --secure
Password for [user@dom]:
FATAL[2020-09-29T18:17:08+02:00] unable to read LDAP response packet: read tcp 192.*.*.*:43528->10.*.*.*:636: read: connection reset by peer  package=windapsearch

Taking a look on the wire, I noticed that --secure sends the data unencrypted (which is pretty bad):

Since the DC won't allow this, the connection is resetted. I took a look into the problem and decided to stop when I got to the point where go-ldap does the handshake on its own.
Currently, go-windapsearch is broken for scenarios where the DC enforces a secure connection, which is a real pity. In order to fix the issue, I'd like to propose to establish the tlsconnection using go's standard library before handing the connection over to the ldap library. I'll submit a pull request, but please note that I didn't do extensive testing. It works with DCs enforcing TLS now, and I'm still getting the error to use TLS in case of a missing --secure switch (so everything works as it is supposed to), but I did not perform any other tests, so you might want to try it on your own first.

Here you go: #9

Fixed