Add PHP 7.2-7.4 to Travis build

This needs further work for build to pass. Pls author ping me if you wish to have this done.


NewsWizard is not defined in success handler of /common/get_menu

NewsWizard is not defined?
2018-06-13 12:18:05 UTC
   (3 hour(s) ago)
<EMAIL_ADDRESS>Count: 1 - Version: web

description: Caught exception in success handler of /common/get_menu

errorMessage: NewsWizard is niet gedefinieerd
success@https://dashboard.onzestadapp.be/static/js/solutions/sln-news.js:36:21
   at options.success (https://dashboard.onzestadapp.be/static/js/solutions/sln-utils.js:1014:25)
c@https://dashboard.onzestadapp.be/static/js/jquery-1.10.0.min.js:4:25959
   at p.fireWith (https://dashboard.onzestadapp.be/static/js/jquery-1.10.0.min.js:4:26707)
k@https://dashboard.onzestadapp.be/static/js/jquery-1.10.0.min.js:6:14025
r@https://dashboard.onzestadapp.be/static/js/jquery-1.10.0.min.js:6:18415

mobicageVersion: web

occurenceCount: 1

platform: 0

platformVersion: Mozilla/5.0 (Windows NT 6.1; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; MALC; wbx 1.0.0; rv:11.0) like Gecko

so this means that is has loaded the sln-news.js file and finished the get_menu API call request inside sln-news.js BEFORE sln-news-wizard.js was loaded, even though that file should be loaded right after sln-news.js

can't test this without using internet explorer


Use macos equivalent of ORIGIN in RPATH

Description of changes:
Bug fix for macos release.
Resolved issues:
Call-outs:

Untested. It's pretty difficult to test since you basically have to move to a different machine to try it. Will be trying it again by making a new 0.1.0 test release.

Testing:

How is this change tested?

Is this a refactor change?

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Hopefully, this works.

It's annoying to me that there's no easy way to test thing. I thought about removing the hard-coded RPATH we use for development in release builds, but I'm not sure if "release build" is the right trigger. I mean, maybe. I'll open an issue and merge this for now to see if it works.


Update index.yml

Straightened out the Links to Azure CLI developer reference and REST API developer reference, that were pointing to each other.

@basnyatk : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the context and links; merging the PR. @basnyatk Thanks.


Fix unit in material density property to SI units

The unit for the density of materials in /cpacs/vehicles/materials/material/rho is currently stated to be
kg/ mm^3. In CPACS all units should be SI units and due to consistency reasons there must not be any exception.
Will be fixed in the next release.

Is changed to kg/m^3 in CPACS 2.3.1


Auto-update without going to download page

Would be awesome if the version detection would download the latest version and update it in-place, rather than having to go to the download page.  (And adding the version checking/updating to the settings page)

Thanks for your suggestion. I added it to the 1.0.0 milestone.

This is major important, I know a few people stopped using this because of it. You do a great job updating, which causes a lot of manual download/installs.

Will be added soon. I've applied to an certificate agency. Currently working myself through their validation process. You can check my https://www.patreon.com/kyusung4698 for updates. The current goal is to reach 25€ to insure that the certificate running cost are covered.

0.6.0 (2020-03-12)

add auto update (#40)


Investigate ToolJet

Over the weekend I did the work to get a local instance running.  The tool provides a GUI for building front ends and can interface with a variety of different data sources.
What I found during my test run was that it doesn't operate how I'd like for a front-end framework.  The tool is more comparable to something like Webflow, acting as a service which renders front-end applications and stores the implementation details in a database.
In my idea low-code scenario, I want a GUI to help build the F/E but the tool should produce code to deploy.   Something more similar to Strapi.
Closing ticket.


Is seaborn requred?

https://github.com/lmcinnes/umap/blob/499f8350b3374767f41fcd49eac13b982c9329ac/umap/plot.py#L32
I'm not seeing the explicit import for seaborn. Is this involved in any of the other packages?

You are right; it isn't actually required -- for an earlier version of the plotting library I believe it was, but it got factored out. Do you want to make a PR to fix the message?

Happy to do so, will put it in tomorrow!

Thanks.


feat: Support serving web and api over https locally

ref: https://github.com/Azure/static-web-apps-cli/issues/4
Some Web API requires contents served over https (for example: Navigator.mediaDevices.getUserMedia).
Since it can be used if it is provided from a specific location such as localhost and file protocol, we can use by using localhost over http, which is currently available.
So it's a low priority because there are alternatives ways, but I guess this feature will bring it closer to production.
I tried the following command
$ pwd
~/Projects/github.com/yamachu/static-web-apps-cli
$ SWA_CLI_APP_USE_HTTPS=true SWA_CLI_APP_SSL_KEY="./scripts/localhost.key" SWA_CLI_APP_SSL_CERT="./scripts/localhost.crt" npm start start http://localhost:8000

Thank you for your contribution @yamachu 🎉

@yamachu I left some comments. Also, we would like to enable HTTPS with a CLI flag, like --ssl.
Here are some options:
swa start ./public \
    --ssl true \
    --ssl-cert "/home/user/ssl/example.crt" \
    --ssl-key "/home/user/ssl/example.key"

Or by simply passing --ssl, in this case we will read Key and Cert from a default folder, for example called ./ssl:
swa start ./public --ssl

Do you think you can update this PR with these changes?
Cheers.

@manekinekko Thanks for reviewing!
I've completed the correction of the suggested codes.
There's one thing I didn't make sense.

Or by simply passing --ssl, in this case we will read Key and Cert from a default folder, for example called ./ssl:

https://github.com/Azure/static-web-apps-cli/pull/140/commits/20db8d014eeb33f7a4898612b2b1f82900ef34a3#diff-56c6d11b6169bded929472469c7a06cf11c7fe4ec6905aac0199026edb3e4a48R92-R93
Did you intend to use copy-assets and load what is included in this application (localhost.crt, localhost.key)?

Thank you @yamachu
We haven't designed this yet. So I was actually suggesting that we read a folder ./ssl from the user root application folder (--app-location).
.
├── package.json
├── app/
├── api/
├── ssl/**/*.{key, cert}

Do you think this is a valid use case? Do developers usually save their Key and Cert on GitHub?

@manekinekko

we read a folder ./ssl from the user root application folder (--app-location).

I guess that this is a valid use case and looks good to me.
.
├── package.json
├── app/
├── api/
├── proxy/dev_ssl_certs/*.{key, cert}

This is my projects structure that I often use when serving it by proxy application such as nginx.

Do developers usually save their Key and Cert on GitHub?

As far as I know, no one else is doing that.
In most cases, there is (maybe) no issue if we commit it and push, because we set localhost to SAN.
However, I haven't committed because I don't want to admit exceptions in terms of broken window theory in my case.

Thank you @yamachu
Let's then just add support for CLI flags, like following:
swa start ./public \
    --ssl \
    --ssl-cert "/home/user/ssl/example.crt" \
    --ssl-key "/home/user/ssl/example.key"

Thanks @manekinekko
I modified it to the CLI options you suggested.
I wasn't sure if the commander could support a combination of CLI options, so I used an if statement.
https://github.com/Azure/static-web-apps-cli/pull/140/commits/8da34925521ae0411667fe7a041105622b1e7c3b#diff-56c6d11b6169bded929472469c7a06cf11c7fe4ec6905aac0199026edb3e4a48R87-R88
Is that ok?

That's perfect. One last minor change and your PR will be ready to be merged.

Congratulations @yamachu 🎉

@manekinekko @yamachu are there plans to support self signed cert generation, similar to what dotnet offers? Or at least integrate with a tool that makes it easy to use. Currently it is quite a hassle to set up, especially when you share the repository with multiple members.
Should I log this as a separate feature request?
https://www.hanselman.com/blog/developing-locally-with-aspnet-core-under-https-ssl-and-selfsigned-certs

Yes please log a new issue to track this feature request.


Added Eth Guides template and beginning of IPFS eth Guide

@MarcoPolo @enolal826 take a look at the template for the eth guides, and when done approve! Last approver please merge


Environment at homepage Portainer latest version fail to load Docker API on Server Ubuntu aarch64

Hi, i have an issue on latest portainer when update version CE 2.11.1 to Latest version CE 2.13.1
Before that my Server details :  Ubuntu 20.04.4 LTS (GNU/Linux 5.13.0-1028-oracle aarch64)
i was follow the update in the doc upgrade for standalone docker with no problem.
when i login to portainer i found my docker not appear in Portainer homepage at environment like this :

my enviroment setting is auto

my docker version

 docker version
Client: Docker Engine - Community
 Version:           20.10.16
 API version:       1.41
 Go version:        go1.17.10
 Git commit:        aa7e414
 Built:             Thu May 12 09:17:01 2022
 OS/Arch:           linux/arm64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.16
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.10
  Git commit:       f756502
  Built:            Thu May 12 09:15:28 2022
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.4
  GitCommit:        212e8b6fa2f44b9c21b2798135fc6fb7c53efc16
 runc:
  Version:          1.1.1
  GitCommit:        v1.1.1-0-g52de29d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Docker-compose version
docker-compose version
Docker Compose version v2.5.1

for this i was trying reinstall portainer with clean reinstall still can't fix for the Portainer latest version.
at the end i rollback to previous version CE 12.11.1 - Fresh clean install and the result like normal can running at my server here the some pic.

====================
Hope your team can check on this and get some fix if have
Thanks

I have the same problem. Which portainer 2.11.1 did you install?
I used version 2.11.1 and after trying to update and it went wrong I tried to go back to 2.11.1 using this command, but it is not working. The only versions that were successful to install were the last of the EE version and the CE versions prior to 2.1.1
I use this command:
docker run -d -p 8000:8000 -p 9443:9443 -p 9000:9000 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data :/data portainer/portiner-ce:2.1.1

I have the same problem. Which portainer 2.11.1 did you install?
I used version 2.11.1 and after trying to update and it went wrong I tried to go back to 2.11.1 using this command, but it is not working. The only versions that were successful to install were the last of the EE version and the CE versions prior to 2.1.1
I use this command: docker run -d -p 8000:8000 -p 9443:9443 -p 9000:9000 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data :/data portainer/portiner-ce:2.1.1

Yes same. im using the previous version on CE 2.11.1

cause the latest version like a buggy display the environment docker when display.
Hope can fix this for latest version.
Thanks.

Have you tried a hard refresh on the browser or tried a different browser?
If you still face the issue.. please stop and start portainer
docker stop portainer
docker start portainer

Have you tried a hard refresh on the browser or tried a different browser? If you still face the issue.. please stop and start portainer
docker stop portainer
docker start portainer

hi,
was try still same result. and make clean reinstall same result to.
but after rollback to old version that working fine.

Can you provide Portainer container logs from during the upgrade?

Can you provide Portainer container logs from during the upgrade?

Unfortunately in my case no, because when I install the latest CE version, it doesn't show any error, it just doesn't load the page in the browser. But if I install the latest EE version, it works normally.

Once you upgrade to EE, you can not simply use CE version. You will need to follow instructions from here to downgrade

Once you upgrade to EE, you can not simply use CE version. You will need to follow instructions from here to downgrade

I tried to update to the latest version of CE and it gave an error. After that, I had to remove the portainer and install several versions of CE, but none of them worked, finally I tested the EE one and it worked, but as it was paid, I had to keep testing until I found a version that works, which is 2.1 .1, all later ones don't work. I currently use 2.1.1 normally.

After upgrade and getting an "failed loading environment" error message, the following worked for me:

Shut down all containers, remove /var/run/docker.sock and /var/run/docker.pid then reboot. Problem solved!


errMPOProd implementation needed

See: http://itensor.org/docs.cgi?vers=cppv3&page=classes/mps_mpo_algs

Added in pull #92, thanks @alvarorga


Client-Side Rendering websites

how does your package deal with Client-Side Rendering websites, it seems it fails to parse a YouTube video page

it should work on client-side rendering sites. Some sites that are too complicated (in the sense that many dynamic js activities may fail). First thing you can try is using streaming mode


Updated Primary key relation for hasMany Save and updated all fields

Pull Request Test Coverage Report for Build 53

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 68.235%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/BaseModel.php
0
3
0.0%

Totals

Change from base Build 52:
-0.2%

Covered Lines:
580

Relevant Lines:
850

💛  - Coveralls


Update to .NET Core 3.1

Please update this sample to .NET Core 3.1 and maybe build the image from GitHub. Using a ready made image really does not help at all.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e087007-7838-e0f9-d713-22182a5d9704
Version Independent ID: 2f32c7c3-8667-0e88-495b-c0c888572964
Content: Hosting ASP.NET Core Images with Docker over HTTPS
Content Source: aspnetcore/security/docker-https.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@ARambazamba  this doc is focused only on how to run pre-built container images with HTTPS.
What about the  version makes it difficult to follow in 3.1?

Sorry ... did not read the pre-build part!


-C flag does not override existing true values with false

Describe the bug
Trying to override existing settings from .swcrc using -C does not work if the value change is from true to false
Input code
$ npx swc -C jsc.externalHelpers=false

Config
{
  "jsc": {
    "externalHelpers": true
  }
}

Playground link
No response
Expected behavior
@swc/helpers is not imported and external helpers are inlined
Actual behavior
@swc/helpers is imported
Version
@swc/cli: 0.1.55 @swc/core: 1.2.147
Additional context
No response

This can be fixed by changing the field type to Option<bool>


Minor clean-ups in dotGenerator.py

What kind of issue is this?

[X] Bug report
[X] Feature request
[ ] Question not answered in documentation
[ ] Cleanup needed

Script misses inheritance (GPUSpikingCluster from Cluster) in some cases.
Help message could be formatted better
Clarify that initial "./" is needed.

What is affected by this?

How do we replicate the issue/how would it work?

Expected behavior (i.e. solution or outline of what it would look like)

Other Comments

So I think the issue was with the fact that in some cases, a classA inherited from classB even when classA.h did not directly include classB.h. I think I have a fix, I'll make a pull request promptly.


Repopsitory of custom circuits?

I just finished understanding a good portion of the source code, and now I'd like to test some circuirts to understand it better. On the evaluator class it has functions to multiply 2 polynomials, square them, exponentiate them, and other simple stuff. I understand that the circuits heavily depend on how the data is represented on the plaintext, but I could not find further information about it. Are there examples I can look? What about the AES over FHE that I always read somewhere about? What about simpler examples than AES?
Thanks!

examples

@WeiDaiWD I spent a lot of time on the examples folder, but I was looking for more complicated examples and possibly some circuits like XOR. I thought there would be some repos about this on github from thirdy party users but couldn't find none.

The examples serve as documentation to SEAL. XOR is defined as addition of 0 or 1 modulo 2. You need to set plain_modulus as { 2 } and abandon BatchEncoder. More complicated examples can be available here in a different project.


mkdir: cannot create directory ‘/usr/local/beleyenv/bin’

Beleyenv failed during the Todo install on a fresh Linux beta host:
⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤
Sublime text plugins not under package control installed
⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   646  100   646    0     0   1814      0 --:--:-- --:--:-- --:--:--  1814
100 15924  100 15924    0     0  17537      0 --:--:-- --:--:-- --:--:-- 64209
todo.txt_cli-2.12.0/
todo.txt_cli-2.12.0/todo.sh
todo.txt_cli-2.12.0/._todo.cfg
todo.txt_cli-2.12.0/todo.cfg
todo.txt_cli-2.12.0/._todo_completion
todo.txt_cli-2.12.0/todo_completion
mkdir: cannot create directory ‘/usr/local/beleyenv/bin’: Permission denied

⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤
Beleyenv install failed!
⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤⬤

Manually creating the folder and rerunning index.sh fixed the issue

Thanks for pointing this out! Looks like one of the scripts I added in-between my last clean fresh install was missing a sudo and caused the bug.
If a fresh install still isn't working, feel free to submit a new issue.


feat(axelarnet): allow deactivating all ibc transfers

Description
depends on #1805  and #1808
Allow generically deactivating IBC transfers
Todos

[ ] Unit tests
[ ] Manual tests
[ ] Documentation
[ ] Connect epics/issues
[ ] Tag type of change
[ ] Upgrade handler

Steps to Test
Expected Behaviour
Other Notes

Based on internal discussion, we'll use axelarnet deactivation to signal IBC freeze


Save or permanently cache networks (.json)

For pre-calculated networks (can be done in advance with uniprot_scraper scripts for every UniProt ID / HGNC symbol) it then works very fast, but for any other query, using multiple gene names, it does not store the results. If it were just like in the scraper script, then another user's request for the same set of genes might perform much faster. And, it's ok to store (or cache permanently), because the PC2 pathway data is static, read-only, i.e., doesn't change between Pathway Commons releases (for several months).

Done.


.puppet-lint.rc is ignored in Control Repos

The puppet-lint.rc file seems to be ignored in control repos, but works for modules
Repro:

Clone a control repo
Open the repo with VS Code
Create a file called .puppet-lint.rc with the following content

--no-documentation-check

Create a new manifest in profile/manifests/test.pp with the following content

class test () {
}

Expected Behaviour
No lint errors are detected
Actual Behaviour
The lint error [Puppet] class not documented is raised.

Fixed


Issue with .correct()

I'm just testing out TextBlob and in particular the spelling functionality. Perhaps I'm missing something, but the basic example of the .correct() method is returning an empty Texblob. (I'm using Python 2.7 in Jupyter Notebooks). Other Texblob functionality has worked as expected/demonstrated in docs.
input:
phrase = TextBlob("Do you get thaksgiving day off?")
phrase.correct()
output:
TextBlob("")

I cannot reproduce this issue. What version of TextBlob are you using?
pip freeze | grep -i textblob

Tried it again after reinstalling everything on machine with pip instead of anaconda. It is now working.


能否把SwiftUI相关的拆分出来，选择性pod

我只需要swift的，SwiftUI相关的暂时用不上。

Sorry but I am too lazy to maintain two parts at the same time. 😂 (Since it should not have much impact to your final product: if you are not using those SwiftUI related symbols, they will be stripped out when doing static linking).
And for building Kingfisher v6 under Xcode 13, please refer to the link above as a temporary workaround.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2262

Questions ?
Please refer to the Backport tool documentation


Missing Flag for country Kosovo

Missing Country Kosovo Flag in the Semantic-UI Flag Icon Function
Looks like the country of the Kosovo is missing from the default flag icon.
Steps
Add the following for the Kosovo country flag:
<i class="xk flag"></i>
Expected Result
Kosovo Flag to be displayed
Actual Result
No flag displayed
Version
2.4

Me too, it can't displayed

Did you solve it @mhou1981

The active community fork Fomantic-UI has got all missing flags as part of the emoji component
https://fomantic-ui.com/elements/emoji.html
For version 2.9 the sprite flags are going to be replaced by the same SVG icons, so every missing country code flag will be supported while the syntax stays backward compatible
https://github.com/fomantic/Fomantic-UI/pull/1190
See your missing flag here https://jsfiddle.net/lubber/nyapwr9L/2/

I find the error, it maybe your path like font path, icon path  is wrong in semantic.min.css or semantic.min.css file.


[Feature] Managing multiple CRD versions at the same time

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Follow up story of https://github.com/ray-project/kuberay/issues/536.
We will have multiple tracking issues may update the CRDs in v0.5.0 release. It's a good time to talk about multi-version management now. I highly recommend to bump to v1beta1 CRD before we come into v1.  (We expect v1beta1 would be same as v1 though)
One thing to notice is conversion does introduce webhook and it make deployment a little pretty heavy.
Use case
Use to manage multiple CRD versions and help user upgrade to new version smoothly.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

do we have a compelling case for backward compatibility?
in v1beta1 are we planning to break the API, that is the CRD definition will change and the previous CRs will not parse properly?
KubeRay upcoming major version is still 0. that is, 0.5.x, it would be unusual to have the CRD version v1 when kuberay is still in "v0"

@akanso Yes, some unhelpful fields like head.replicas should be reused. There're some fields that can be changed to use annotation instead could be removed as well.
Previous CR can still work with the webhook conversion. That's the backward compatibility the project should guarantee.  Let's write more details for this one.

I will try to bump RayService from v1alpha1 to v1beta1 or v1alpha2 next week.

I will bump the CRD version to v1. In addition, after discussing with several users and experts on CRD versioning, we have decided not to go with a conversion webhook.


Client Landing Page

Created a short intro page to clients for linking to a generic monoDrive client when necessary.

@katiemacaulay Ready for another look!


Add event when resource need reconcile

Description of your changes
Added diff message in resources events.
Fixes #274
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
I've built provider-azure with this patch. Changed one of resource and looked in kubectl describe event section.
  Normal   NeedReconcileManagedResource  7s (x5 over 27s)      managed/virtualnetwork.network.azure.crossplane.io  AddressSpace:   &network.AddressSpace{
-          AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
+          AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
  }

On larger diff looks like:
  Normal   NeedReconcileManagedResource  5m19s (x16 over 15m)  managed/virtualnetwork.network.azure.crossplane.io  AddressSpace:   &network.AddressSpace{
-          AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
+          AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
  }
  Normal  NeedReconcileManagedResource  12s (x4 over 2m51s)  managed/virtualnetwork.network.azure.crossplane.io  AddressSpace:   &network.AddressSpace{
-         AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
+         AddressPrefixes: &[]string{"<IP_ADDRESS>/16"},
  }
EnableDdosProtection:   &bool(
-   true,
+   false,
  )
EnableVMProtection:   (*bool)(
-   &true,
+   nil,
  )

Here is how I would prefer this to work for crossplane:
There is a similar feature in argocd where you can set the sync options to false, in which case it will not clobber/update the resource if selfHeal is disabled.
https://argoproj.github.io/argo-cd/user-guide/auto_sync/#automatic-self-healing
      syncPolicy:
        automated:
          selfHeal: false

There are also annotations for deleting resources, similar to deletionPolicy: Orphan
https://argoproj.github.io/argo-cd/user-guide/sync-options/
  annotations:
    argocd.argoproj.io/sync-options: Prune=false

And you can control the criteria argocd uses to determine whether an object is out of sync or needs to be synced:
https://argoproj.github.io/argo-cd/user-guide/diffing/
spec:
  ignoreDifferences:
  - group: apps
    kind: Deployment
    name: guestbook
    namespace: default
    jsonPointers:
    - /spec/replicas

What I would prefer from crossplane:

spec is the API representation of the object ONLY
sync interval and options (ex. deletion policy) are set via annotations or syncOptions property on each object
something similar to ignoreDifferences with jsonPath can be used to ignore differences (and ignore updates from being called if a value in the cr.Spec.ForProvider doesn't match the API)
a representation of the actual API object stored somewhere (configmap?) so it can be diffed against the crossplane representation of the object

This would put a lot more control in the hands of the end users, especially around controlling what syncs, when it syncs, how it syncs.
It could enable a really nice UI, especially around visualizing differences.
To achieve this, it would be great if crossplane was much more opinionated about IsUpToDate.  A big painpoint today is implementing IsUpToDate when writing a new resource.  It requires the most code, the most tests, and it's also where the most bugs seem to be.  Each resource has it's own unique implementation which has been decided by the implementer and they are very prone to errors.
I would prefer if there were a consistent way to diff.  Ex. each resource forced you to create a 2 instances of the same class/struct, one populated with the data from crossplane and one populated with the data from the remote service (maybe with DeepCopy helper?)  It would always be an apples to apples comparison, and consistent across all providers and resources.
An example would be - copy cr.Spec.ForProvider into S3CreateBucket, copy the results of DescribeBucket into S3CreateBucket object, and then compare the 2 S3CreateBucket objects.
Crossplane could even json.Marshal both objects and expose a json diff helper for the comparison.  This would DRY up a lot of the resources and unit tests.
Long story short, instead of logging verbose diffs and json, i'd prefer to set selfHeal: false to stop the bleeding for resources which are constantly syncing and to be able to then be able to compare the 2 objects using some other method.

The implementation on this looks fine but I somewhat agree with @hasheddan and @negz - Crossplane is already fast and loose with the number of events it submits (particularly with misbehaving resources), and I think adding to that by logging potentially very large diffs (or the same small diff repeatedly) will just exacerbate the issue.
If it could be enabled when necessary (e.g. via an annotation) then that would be less of a problem, but I don't think it should be on by default in its' current form.
On the upToDate points, I agree - it has been the source of most of the bugs I've found (both in my own code and other providers) and I think the provider ecosystem would really benefit from having some more boilerplate for performing update checks in a safe and tested manner.
Myself and colleagues went through various implementations of upToDate when working on provider-cloudflare and the least bug-prone approach I found was to convert the cloud resource definition to the relevant Parameters struct and then use cmp.Equal() (ex: here), which I think is what @smcavallo is suggesting above - lifting that approach out in a manner that could be used cross-provider would be a big help for further provider dev.

I have also worked on many upToDate bugs and would find it valuable to log the full diff in debug mode.
For an event, I think it would be sufficient and probably acceptable to log only field names of the non-up-to-date resource, probably just the top level elements. This would probably remove the need for debug-logging in 9/10 cases for me, and would be enough hint for a non-developer to find a workaround in many cases, and good bug reports / issues here on github. It would also avoid leaking data into events and other systems.
I also agree on the number of events is a bit too much, so if we could log changed keys as part of the UpdatedExternalResource event, I would be very happy.

I would think controlling the debug level in events is a common issue in K8s. Any other prior art in addition to the ArgoCD example.

I have also worked on many upToDate bugs and would find it valuable to log the full diff in debug mode.

Keep in mind we already have logging of these diffs, just not events. So today folks who are debugging a managed resource (e.g. in development or in a particularly tricky production environment) have the option to restart a provider in --debug mode to see these diffs. The question is whether we should expose them as events also. Put otherwise, do we want this information to be available (with a little work) in debugging situations, or just available all the time?

I would think controlling the debug level in events is a common issue in K8s.

@luebken This is not the case, at least as far as I know. I believe the verbosity of events is typically fixed - not tunable - and that they tend to be succinct as @hasheddan points out. That said, there's not a lot of guidance on their use. The API conventions document has a small section.

I think there's a bunch of great feedback in this issue WRT implementing IsUptoDate functions being painful and error prone, as well as some interesting suggestions as to how we can deal with constant update cycles. We may want to track these in distinct issues. In particular the idea of having a way to stop reconciles has come up a few times, and I know other projects (e.g. ArgoCD, Config Connector) support variations of this pattern. I've always been a little wary of it personally (couldn't it be misleading for some resources to not actually be authoritative?) but it seems to be a common enough approach that I'm coming around to it. :)

This is a tough one, but after discussion at the last community meeting the consensus among the maintainers is that we'd prefer to keep this at the debug logging level for now, so I am going to close this. We do appreciate the suggestion though, and the discussion it spurred around the trickiness of IsUpToDate.


Is there a conf for pressure, spool time, etc?

 I saw you change bar in the video.

Its not possible, yet. BUT you can regulate the pressure by pressing 0 and scrolling.

Ah, thanks! I really recommend wring these keybinds down somewhere (i just now started spamming keys and noticed others) so people won't bother you like i did.

These are actually written in the readme, but I understand if you didn't see them.


yaml: remove | from BBMASK

Note: this commit is adopted from meta-xt-prod-devel with all signatures.
BBMASK is space separated list of regular expressions. So it's possible to use |, but space is more proper separator. Also spaces increase readability.
Signed-off-by: Ruslan Shymkevych<EMAIL_ADDRESS>Acked-by: Volodymyr Babchuk<EMAIL_ADDRESS>

Also this PR is fixing:
WARNING: BBMASK contains regular expression beginning with '|', fixing: |meta-rcar-gen3-adas/recipes-bsp/optee

PR is not relevant to this project.


Make the Switch to Dark Mode

Details

Fixed Issues

Main Issue
$ https://github.com/Expensify/App/issues/12440
Dark Mode Bugs
$ https://github.com/Expensify/App/issues/12915
$ https://github.com/Expensify/App/issues/12910
Style Fixes in this PR:
Checkbox:
https://user-images.githubusercontent.com/38015950/203428255-a65849ef-3b66-46d1-a011-7636307815e3.mov
Workspace List:
https://user-images.githubusercontent.com/38015950/203428358-0b48cad4-17b7-4cd0-ace0-3db9a8254402.mov
New Message Indicator:

Tests

[x] Verify that no errors appear in the JS console
[x] Verify visually that all elements are the correct colors.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Verify visually that all elements are the correct colors.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above

[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms

[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[x] I followed the guidelines as stated in the Review Guidelines

[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] I verified that if a function's arguments changed that all usages have also been updated correctly

[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/38015950/203427126-21aa9c61-9036-48dd-9f08-de28274ef606.mov
Mobile Web - Chrome

Mobile Web - Safari

https://user-images.githubusercontent.com/38015950/203442567-8a83b803-4148-41f8-8ae2-4d093aa91b61.mov
Desktop

https://user-images.githubusercontent.com/38015950/203443445-652e5135-48d4-4f6c-a143-fa5f78b28840.mov
iOS

https://user-images.githubusercontent.com/38015950/203442775-1acddcc9-a54d-4a09-8f6f-1a8491b96461.mov
Android

https://user-images.githubusercontent.com/38015950/203443791-f06fe2d6-e94c-4c67-a839-7c1430a1ced6.mov

@shawnborton We might want to change the status bar text to white for the dark theme.

@shawnborton Another thing, we should also set the themeColor (https://developer.mozilla.org/en-US/docs/Web/Manifest) to configure chrome to show a native look.

It will change the address bar to colored. e.g

I like both of those suggestions! What do you think @grgia?

IOS status bar:

Looks great 👍

I like the idea of changing chrome to match, but IMO it's not worth implementing right now since it only would work for mobile chrome on android

Here it is on android

Is there a reason to hold this PR?

Holding to merge with Logos/Fonts/Icons tomorrow. This PR still needs a reviewer checklist

I will test it in a few minutes as well as the logos. Could you please the HOLD from titles if both are ready? It is confusing to see HOLD on PR.

Yep removed the Holds, ready for final review!

The splash screen is dark on web, which platform are you referring to?

Hmm, I think with mobile platforms where the theme colors file isn't being referenced it's okay to leave the splash screen white for now. What is your take @shawnborton? I could open an issue for these cases

I think we can move/do the splash screen changes in https://github.com/Expensify/App/pull/12608 where we are changing the logos.

The logo is clearly visible on the web splash. cc: @shawnborton

Reporting a bug not related to this PR;

Mini menu hover style will look better in a circle shape. Corners are overflowing the area. cc: @shawnborton

Suggestion: Should we change the accent color of the native dropdown/select. It is blue by default.

I agree with both of those suggestions: let's make the mini menu buttons round, and if we can change the accent color to green for select menus, let's do that too.

I think native UI color changes should be a separate issue as well. Otherwise, we will have to hold off merging new colors until next week. I know the native scrollbar colors also need to be changed.

That works for me

I decided to update the splash screen here since the logo change is independent of light/dark mode

https://github.com/Expensify/App/issues/12977 here's the issue for native UI changes

Android:  (note, I built WITHOUT new logos- logo branch will be merged before colors)

IOS:

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Awesome, I will give it a final testing.

@vitHoracek this will be fixed once the icons PR is merged!

The chevron on s the side of IOUs that is intended I assume:

Correct, that is intended.

When resizing the window there's a very obvious white color as the window background. Is this something we could override with our bg colour?

Any idea how to fix that? Maybe we just need to set some CSS for the overall page (html/body) BG color to be dark?

When navigating between RHM pages we see a much lighter green colour before the true background is shown. This existed before, but is much more jarring with the darker colours.

Interesting... curious for @grgia's thoughts there, not sure what we can do to fix that, but it would be nice to use our darkest color there instead.

The Settings page icon needs to be updated, but maybe this is being done as part of the brand update PR?

Yup, also being tackled in the icons PR.

Thanks for the review. These points make sense.

Are we waiting on some changes here?

@parasharrajat I think there are mostly NAB comments. If you want to tgive this another test and fill in the checklist, we can approve this and merge, I dont think we will have a deploy today

Ok. I will do that

Web:
Things can be improved(not necessarily in this PR).

Padding for multiline tooltip.

https://github.com/Expensify/App/pull/12944#issuecomment-1325669556

https://github.com/Expensify/App/pull/12944#issuecomment-1325666285

Border radius or border color of the password-protected

PDF.

Please merge main for logos.

Screenshots
:black_square_button: iOS / native
:black_square_button: iOS / Safari
:black_square_button: MacOS / Desktop
:black_square_button: MacOS / Chrome

:black_square_button: Android / Chrome
:black_square_button: Android / native

I'd like to see us create separate issues for these issues before we merge. Definitely think we can work on them separately though.

@parasharrajat the splash screen and status bar issues are going to immediately be fixed with this PR, so I don't think we need to hold for them.
I've been holding that PR on this one for a few days, and I have already thoroughly tested the two PRs together.

Can someone assign me to the parent issue? Thanks.

Created two follow-up issues for the points we discussed here:

issue for the white window background while dragged
issue for the right-docked-modal navigation background colour

Reported all the other issues from https://github.com/Expensify/App/pull/12944#issuecomment-1328311248 on Slack.
https://expensify.slack.com/archives/C049HHMV9SM/p1669645639980109
https://expensify.slack.com/archives/C049HHMV9SM/p1669645892483889
https://expensify.slack.com/archives/C049HHMV9SM/p1669646129946469
https://expensify.slack.com/archives/C049HHMV9SM/p1669646381569029
https://expensify.slack.com/archives/C049HHMV9SM/p1669646547765529
https://expensify.slack.com/archives/C049HHMV9SM/p1669646862849829

🚀 Deployed to staging by @Julesssss in version: 1.2.33-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@grgia Is there anything specific you want us to QA here?

🚀 Deployed to staging by @Julesssss in version: 1.2.33-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by @Julesssss in version: 1.2.33-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

As per our process, I'm leaving a comment here to let you know that this PR caused this bug

To close the look noting here that we have omitted the gif/ animations to be updated when we made the switch. I assume that was just considered out of scope for this PR, but we have not had a follow-up ready and this bug was logged to solve this


added clazz arg to get_app(in some cases we use class which extends M…

Possibility to set class type to get_app

Can you tell me a little bit more about your use-case?

Of course. I try to explain. For example I have custom class which extends MarathonApp:
from marathon.models import MarathonApp

class MyMarathonApp(MarathonApp):
    """
    Additional methods, properties, overriding something etc...
    """

example_app = MyMarathonApp()
# do something with our app...
# and now we need to create or update our app using MarathonClient
marathon_client.create_app('/test/app/id', example_app)
marathon_client.update_app('/test/app/id', example_app)
# after this we try to get our app:
app = marathon_client.get_app('/test/app/id')
# app variable is instance of MarathonApp, but not MyMarathonApp

Of course, we can override get_app and set class to _parse_response. But I think this is not a flexible solution. Do you agree with me?

I don't know, as I've never see anyone use the methods of a python module and insert their own objects in this way. Why should python-marathon return an object that we don't control? Seems a lot more sane for the marathon-python module to only operate on internal objects.
I think it is fine for users of this module to make objects that inherit from MarathonApp, but I don't think it is a good idea to tangle the modules like this.
What if you had a function that was called MyMarathonApp.import_marathon_app(client.get_app('foo'))? It is a little more verbose, but a lot more obvious what is going on?

Why should python-marathon return an object that we don't control?
I'm agree with you. But for this case I can add next condition to get_app like this:
def get_app(self, app_id, embed_tasks=False, embed_counts=False,
                embed_deployments=False, embed_readiness=False,
                embed_last_task_failure=False, embed_failures=False,
                embed_task_stats=False,
                clazz=MarathonApp):
    if not issubclass(clazz, MarathonApp):
          raise MarathonError('Invalid argument "clazz"')
    ...

Or you do not like this solution? It will be clear.

+1 for @solarkennedy's idea here - personally I think this should be done from the wrapper class. I'd do this as something like:
app = marathon_client.get_app('/test/app/id')
my_app = MyMarathonApp.from(app)

If you want to support this type of casting, you'll have to do it for every model in the library.

Ok. Thanks for conversation.


Append $flutter/osx sdk property to existing platforms/targets relying on xcode

Part of https://github.com/flutter/flutter/issues/127534

Friendly ping. This is a no-op for existing workflows.


Docker file not pulling in all needed libraries for proper lambda execution

In order to get this to work I had to modify the Dockerfile.
I was running into the issue where the lambda function was not finding the proper run time libraries with the current code utilized by the make command.
I changed this from:
WORKDIR /tmp
RUN yumdownloader -x \*i686 --archlist=x86_64 clamav clamav-lib clamav-update json-c pcre2
RUN rpm2cpio clamav-0*.rpm | cpio -idmv
RUN rpm2cpio clamav-lib*.rpm | cpio -idmv
RUN rpm2cpio clamav-update*.rpm | cpio -idmv
RUN rpm2cpio json-c*.rpm | cpio -idmv
RUN rpm2cpio pcre*.rpm | cpio -idmv

To this:
WORKDIR /tmp
RUN yumdownloader -x \*i686 --archlist=x86_64 clamav clamav-lib clamav-update json-c pcre2 libprelude gnutls libtasn1 lib64nettle nettle
RUN rpm2cpio clamav-0*.rpm | cpio -idmv
RUN rpm2cpio clamav-lib*.rpm | cpio -idmv
RUN rpm2cpio clamav-update*.rpm | cpio -idmv
RUN rpm2cpio json-c*.rpm | cpio -idmv
RUN rpm2cpio pcre*.rpm | cpio -idmv
RUN rpm2cpio gnutls* | cpio -idmv
RUN rpm2cpio nettle* | cpio -idmv
RUN rpm2cpio lib* | cpio -idmv
RUN rpm2cpio *.rpm | cpio -idmv
RUN rpm2cpio libtasn1* | cpio -idmv

I'm not sure if this is the most elegant solution to the issue but it works.

It worked like a charm. Thanks a lot!

This fixed the issue for me too, thanks @gmirsky.

I could solve it with the following which is a bit more precise in the paths:
WORKDIR /tmp
RUN yumdownloader -x \*i686 --archlist=x86_64 clamav clamav-lib clamav-update json-c pcre2 libprelude gnutls libtasn1 lib64nettle nettle
RUN rpm2cpio clamav-0*.rpm | cpio -idmv
RUN rpm2cpio clamav-lib*.rpm | cpio -idmv
RUN rpm2cpio clamav-update*.rpm | cpio -idmv
RUN rpm2cpio json-c*.rpm | cpio -idmv
RUN rpm2cpio pcre*.rpm | cpio -idmv
RUN rpm2cpio gnutls*.rpm | cpio -idmv
RUN rpm2cpio nettle*.rpm | cpio -idmv
RUN rpm2cpio libprelude*.rpm | cpio -idmv
RUN rpm2cpio libtasn1*.rpm | cpio -idmv

God bless you man. I've been pulling my hair for a fix to this issue all day until i stumbled on this.

Glad I could help. I've been there, done that and have the scars to prove it.

The above comments almost resolved the issue for me, although I also needed to download and convert the libtool-ltdl library:
WORKDIR /tmp
RUN yumdownloader -x \*i686 --archlist=x86_64 clamav clamav-lib clamav-update json-c pcre2 libprelude gnutls libtasn1 lib64nettle nettle libtool-ltdl
RUN rpm2cpio clamav-0*.rpm | cpio -idmv
RUN rpm2cpio clamav-lib*.rpm | cpio -idmv
RUN rpm2cpio clamav-update*.rpm | cpio -idmv
RUN rpm2cpio json-c*.rpm | cpio -idmv
RUN rpm2cpio pcre*.rpm | cpio -idmv
RUN rpm2cpio gnutls*.rpm | cpio -idmv
RUN rpm2cpio nettle*.rpm | cpio -idmv
RUN rpm2cpio libprelude*.rpm | cpio -idmv
RUN rpm2cpio libtasn1*.rpm | cpio -idmv
RUN rpm2cpio libtool-ltdl*.rpm | cpio -idmv

Hello,
I am seeing this error after following all above steps, any help?

2020-11-18T02:07:18.192-05:00
LibClamAV Error: cli_loaddbdir(): No supported database files found in /tmp/clamav_defs

2020-11-18T02:07:18.192-05:00CopyERROR: Can't open file or directory
ERROR: Can't open file or directory

2020-11-18T02:07:18.192-05:00
----------- SCAN SUMMARY -----------

2020-11-18T02:07:18.192-05:00
Known viruses: 0

2020-11-18T02:07:18.192-05:00
Engine version: 0.102.4

2020-11-18T02:07:18.192-05:00CopyScanned directories: 0
Scanned directories: 0

2020-11-18T02:07:18.192-05:00
Scanned files: 0

2020-11-18T02:07:18.192-05:00
Infected files: 0

2020-11-18T02:07:18.192-05:00
Data scanned: 0.00 MB

2020-11-18T02:07:18.192-05:00
Data read: 0.00 MB (ratio 0.00:1)

2020-11-18T02:07:18.192-05:00
Time: 0.023 sec (0 m 0 s)

2020-11-18T02:07:18.192-05:00
Unexpected exit code from clamscan: 2.

2020-11-18T02:07:18.201-05:00
[ERROR] Exception: Unexpected exit code from clamscan: 2.

2020-11-18T02:07:18.201-05:00
Traceback (most recent call last):   File "/var/task/scan.py", line 236, in lambda_handler     scan_result, scan_signature = clamav.scan_file(file_path)   File "/var/task/clamav.py", line 210, in scan_file     raise Exception(msg)

2020-11-18T02:07:18.202-05:00
END RequestId: 1e4b7dc6-bc7a-45a2-b723-e3908ef7feb2

Same Error as above. All help appreciated
Starting clamscan of /tmp/clamscanbucket/Harmonics1.pdf.
clamscan output:
LibClamAV Error: cli_loaddbdir(): No supported database files found in /tmp/clamav_defs
ERROR: Can't open file or directory
----------- SCAN SUMMARY -----------
Known viruses: 0
Engine version: 0.102.4
Scanned directories: 0
Scanned files: 0
Infected files: 0
Data scanned: 0.00 MB
Data read: 0.00 MB (ratio 0.00:1)
Time: 0.057 sec (0 m 0 s)
Unexpected exit code from clamscan: 2.
[ERROR] Exception: Unexpected exit code from clamscan: 2.
Traceback (most recent call last):
  File "/var/task/scan.py", line 236, in lambda_handler
    scan_result, scan_signature = clamav.scan_file(file_path)
  File "/var/task/clamav.py", line 210, in scan_file
    raise Exception(msg)

Same Error as above. All help appreciated
Starting clamscan of /tmp/clamscanbucket/Harmonics1.pdf.
clamscan output:
LibClamAV Error: cli_loaddbdir(): No supported database files found in /tmp/clamav_defs
ERROR: Can't open file or directory
----------- SCAN SUMMARY -----------
Known viruses: 0
Engine version: 0.102.4
Scanned directories: 0
Scanned files: 0
Infected files: 0
Data scanned: 0.00 MB
Data read: 0.00 MB (ratio 0.00:1)
Time: 0.057 sec (0 m 0 s)
Unexpected exit code from clamscan: 2.
[ERROR] Exception: Unexpected exit code from clamscan: 2.
Traceback (most recent call last):
  File "/var/task/scan.py", line 236, in lambda_handler
    scan_result, scan_signature = clamav.scan_file(file_path)
  File "/var/task/clamav.py", line 210, in scan_file
    raise Exception(msg)

I got rid of that error by replacing docker code with @iwt-nduesing suggested code above. Try and see if it works for you.

Now I have now issue... its trying to scan but nothing happens

2020-11-18T02:27:58.033-05:00
Starting clamscan of /tmp/av-scan-bucket/example_3.json.

2020-11-18T02:32:57.171-05:00
END RequestId: 1ba83ac6-bd77-4d35-881e-d2489bfc7c87

2020-11-18T02:32:57.171-05:00CopyREPORT RequestId: 1ba83ac6-bd77-4d35-881e-d2489bfc7c87	Duration: 300748.32 ms	Billed Duration: 300000 ms	Memory Size: 1024 MB	Max Memory Used: 1025 MB
REPORT RequestId: 1ba83ac6-bd77-4d35-881e-d2489bfc7c87 Duration: 300748.32 ms Billed Duration: 300000 ms Memory Size: 1024 MB Max Memory Used: 1025 MB

2020-11-18T02:32:57.171-05:00
2020-11-18T07:32:57.170Z 1ba83ac6-bd77-4d35-881e-d2489bfc7c87 Task timed out after 300.75 seconds

2020-11-18T02:34:44.374-05:00
START RequestId: 1ba83ac6-bd77-4d35-881e-d2489bfc7c87 Version: $LATEST

2020-11-18T02:34:44.585-05:00
Script starting at 2020/11/18 07:34:44 UTC

2020-11-18T02:34:45.321-05:00
Not downloading main.cvd because local md5 matches s3.

2020-11-18T02:34:45.904-05:00
Not downloading daily.cvd because local md5 matches s3.

2020-11-18T02:34:45.995-05:00
Not downloading bytecode.cvd because local md5 matches s3.

2020-11-18T02:34:45.996-05:00
Starting clamscan of /tmp/av-scan-bucket/example_3.json.

2020-11-18T02:39:44.407-05:00
END RequestId: 1ba83ac6-bd77-4d35-881e-d2489bfc7c87

Thank you for this fix! The developers should add this into the original repository

Thank you for this fix! The developers should add this into the original repository

I got the same issues (definitions update lambda fails). Fixed by updating Dockerfile. Thanks @gmirsky!

Thanks for your help @gmirsky!!


chore: add remote servers struct

Stack:

#2041
#2040 ⬅
#2035
#2034
#2033
#2032
#2030
#2029
#2028

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

✓ Commit merged in pull request #2041


Cyverse paths should be generated by tags

Level 0 has this structure: .../level_0/scanner3DTop/file_we_want.tar.gz while all levels >0 have this structure: .../level_0/scanner3DTop/2222-22-22/file_we_want.tar.gz
Currently, the date is hardcoded into distributed_pipeline_wrapper.py and it breaks level 0 downloads.  The distributed_pipeline_wrapper.py needs logic to build the cyverse input/output paths from YAML keywords.
distributed_pipeline_wrapper.py changes:

For levels greater than zero, the file structure should be: .../level_n/sensor_name/experiment_name/date/prefix_file_suffix
For level 0, the file structure should be: .../level_n/sensor_name/prefix_file_suffix

YAML changes:

Add level, sensor_name and expirment to YAML tags (top of file)
move basename to under cyverse
output:subdir becomes experiment (see issue #29).

This bug is hindering module development for the new YAML pipelines.

A temporary fix is:
distributed_pipeline_wrapper.py changes:
Delete date from line 146
irods_path = os.path.join(irods_path, (subdir if subdir else ""))
YAML changes:
level 0 downloads work as expected
higher than 0, include ${DATE} at the end possibly (I am just developing for level 0 right now)?
  basename: /iplant/home/shared/phytooracle/season_10_lettuce_yr_2020/level_1/ps2Top/${DATE}

In your YAML change I think level should be starting_level since during processing we are going though multiple levels

@emmanuelgonz Did you see @Travis-Simmons comment above?

In your YAML change I think level should be starting_level since during processing we are going though multiple levels

I'm pretty sure when @emmanuelgonz and I discussed things, we were thinking that each yaml pipeline would only move from one level to the next (or stay in the same level).  I haven't thought about what "going through multiple levels" means.  If you go from level_0 to level_3, I don't think intermediary things can be saved to level_1 or level_2.
Here is an example of what the new YAML will have:
  cyverse:
    basename: /iplant/home/shared/phytooracle/
    input:
      level: level_0
      prefix: scanner3DTop-
      suffix: __*.tar.gz
    output:
      level: level_1

@Travis-Simmons @equant Although we are oftentimes outputting processed data of various levels, I agree with @equant in that we cannot save intermediary things in their respective levels without (i) predefining levels before data processing (which will be difficult) and (ii) including multiple extra keys in the YAML. I think for the purposes of levels we should stick to the following:

Level_0: Raw data straight from the gantry/drone platform
Level_1: Processed data produced by PhytoOracle
Level_2: Processed data produced after reprocessing/corrections


Should Sprite use index based animations

Related: #528 (Warning flag -Weffc++)

In file included from NAS2D/Resource/Sprite.cpp:11:
NAS2D/Resource/Sprite.h:30:8: warning: ‘class NAS2D::Sprite’ has pointer data members [-Weffc++]
30 |  class Sprite
|        ^~~~~~
NAS2D/Resource/Sprite.h:30:8: warning:   but does not declare ‘NAS2D::Sprite(const NAS2D::Sprite&)’ [-Weffc++]
NAS2D/Resource/Sprite.h:30:8: warning:   or ‘operator=(const NAS2D::Sprite&)’ [-Weffc++]
NAS2D/Resource/Sprite.h:68:43: note: pointer member ‘NAS2D::Sprite::mCurrentAction’ declared here
68 |   const std::vectorAnimationSet::Frame* mCurrentAction{nullptr};
|                                           ^~~~~~~~~~~~~~

This warning is implying we should probably have (copy/move constructor/assignment) special member functions for this class. The reason being it contains a pointer field which points to internal data, so if the class is copied using the implicit copy constructor, the new object will have a pointer referencing data from the old object. In this case it's not a particular problem, since that data is actually stored in the referenced AnimationSet class, which has separate shared lifetime. Implicit in the safety of this, is the assumption the AnimationSet will be stored in a long lived cache, which has lifetime beyond that of the Sprite class.

This brings up a few design points. Should we need that internal pointer? Currently we use the pointer to cache the result of lookups into a std::map, which happens in the method void Sprite::play(const std::string& action). If we had used a std::vector based store for the data, then we could have stored an index instead of a pointer, and would still have similar efficiency. It also means the implicit special operations would work correctly, without generating any warnings.
Related, is potential errors for animation lookups. Currently we do the animation name to animation data lookup at runtime, on demand in the play method, which means any lookup errors will be deferred until the animation is actually used. If there is a missing animation sequence, it would be very easy for that to be missed until after a game update is released, resulting in crashes for the user.
An alternative would be to force the lookups to be done early, such as when loading the animation data, and storing the result of lookups into a table of index values. Any needed animations would be found at that time, forcing early reporting of errors.
The lookup tables (or structs with named fields) would have a fixed number of entries, with fixed meaning for each entry, and would reference the animations that are actually used. The sprite data itself could contain extra animations, and be in any order.

Point 1:
It depends on the use case. If the Sprite class owns the AnimationSet then sure, making a deep copy makes sense but if it just references a pre-existing AnimationSet then no it shouldn't. Particularly if AnimationSet is, like you said, cached elsewhere. My implementation does not own the underlying Material or SpriteSheet and instead references them via a pointers owned by the Renderer (which outlives everything as it is not destroyed until program termination.)
Point 2:
Loading the data at runtime via data-driven design is fine (See previous implementation) and almost required in some cases instead of hard coding any values. It allows for faster iteration because changing simple animation values (like timing) doesn't require re-compiling the entire program.
I do not cache the animations on play, but instead on load; logging any errors at that time.


worker-build: 0.0.17 -> 0.0.18

Description of changes
Somewhere along the way, a git dependency was added, meaning the cargoHash no longer worked. Also update us to 0.0.18: https://github.com/cloudflare/workers-rs/compare/v0.0.17...v0.0.18
Also the GitHub link was incorrect in the meta, which has been fixed.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thank you for this, it looks like the build on linux-x86_64 is failing with a lock mismatch
https://github.com/NixOS/nixpkgs/pull/251932/checks?check_run_id=16266927802

@happysalada Ah, found it - was missing a newline at the end of the committed Cargo.lock file so it didn't match 1:1. Fixed!

Thank you!
if you use nix-update worker-build, it can generate the cargo.lock for you in case there needs to be one (so you never need to generate one manually). (just in case you weren't sure).


Boot configuration data for your PC is missing

When I try to use the Autolab using unattend-lab command the virtual machine operating system shows a message of Recovery... The Boot configuration Data for your PC is missing.
I am using a Windows 10 Enterprise  with 16 gb ram installed memory.
The vm settings for Firmware has the boot file missing.
Any help?
Thanks.

What configuration are you trying to setup?

I tried Test-SingleServer.

Also POC-Multirole

We'll have to dig deeper into the code (probably the stuff from Lability) to see where this is coming from.

Does the virtual machine ever get created? If not, at what point in the process do you get the error? Actually, instead of running Unattend-Lab, look at instructions.md and run the commands individually. Then we'll know exactly which step is problematic.

OK I tried the setup-lab and the vm was created using the configuration Test-SingleServer. The vm is turn off but when I go to the settings of the vm I don't see the file bootmgfw.efi.

I had to reinstall the host os and now is working. Thanks Jeffery for your help.

I am seeing something similar - not sure if it is exactly the same - when trying to build a server using the 2016_x64_Standard_EN_Eval ISO.  It's successful using 2016_x64_Standard_Core_EN_Eval and 2016_x64_Datacenter_EN_Eval.

I had to install the module of Lability 0.12.2 and the module xActiveDirectory <IP_ADDRESS> for the lab to work. The latest version of both modules were giving me problems.

I'm running lability 0.10.1 (yikes) but also xActiveDirectory <IP_ADDRESS>.  I thought we were pinning versions of the modules needed but maybe that isn't the case.


How to reuse SelectOfScalar[Sequence]

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
import sqlalchemy
from sqlmodel import select

statement = select(Foo).join(xxx).where(xxx)
count_statement = select([sqlalchemy.func.count(Foo.id)]).join(xxx).where(xxx)

Description
There are some statements shared same subquery conditions. Can I know how to reuse the select sequence such as .join(xxx).where(xxx)?
Operating System
Linux, macOS
Operating System Details
No response
SQLModel Version
0.0.4
Python Version
Python 3.6.9
Additional Context
No response

Solution borrowed from https://github.com/uriyyo/fastapi-pagination/blob/6dbd8636f14f83cc2cc2ff592699181aeda2b11d/fastapi_pagination/ext/sqlmodel.py#L23
Kudos to @uriyyo
import sqlalchemy
from sqlmodel import select

statement = select(Foo).join(xxx).where(xxx)
total_count = session.scalar(select(sqlalchemy.func.count("*")).select_from(statement.subquery()))


Strange qemu crashes/triple faults

So, my kernel is still triple faulting and I can't figure out why. The process is terminating for some odd reason (I can't even debug the crash because it immediately exits, and I imagine that I wouldn't be able to do that even if I didn't have -no-reboot on).  GDB shows:
(gdb) target remote :1234
Remote debugging using :1234
0x000000000000fff0 in ?? ()
(gdb) hb main.rs:43
Hardware assisted breakpoint 2 at 0x2076c6: file src\main.rs, line 43.
(gdb) c
Continuing.

Breakpoint 1, kernel::kmain::hf01eb38a4069227d (boot_info=0x10000000000) at src\main.rs:37
37          printkln!("Loading kernel");
(gdb) c
Continuing.

Breakpoint 2, kernel::kmain::hf01eb38a4069227d (boot_info=0x10000000000) at src\main.rs:43
43              kernel::memory::init(
(gdb) step
[Inferior 1 (process 1) exited normally]

I'm not quite sure why this is happening. I've committed my changes -- all of them are in the latest commit. I'm invoking QEMU like:
qemu-system-x86_64 -drive format=raw,file=target\x86_64-kernel-none\debug\bootimage-kernel.bin -serial stdio -no-reboot -hdb disk.img -s -m 4G -machine type=pc,kernel_irqchip=on,vmport=on,igd-passthru=on,nvdimm=on -accel tcg,thread=multi -usb -rtc base=utc,clock=host -audiodev driver=none,id=sound -cpu EPYC-v2,+apic,+acpi,+aes -smp cpus=8 -D run.log -d int,cpu_reset,guest_errors

Link to the repo is https://github.com/ethindp/kernel
Also, qemu does throw a lot of warnings because of this (not sure why). I've attached them in a file. I'm not sure why its throwing these, and I can't run it in HAXM or with WHPX. I've also attached the run log if that's helpful.
run.log
warnings.txt

Update: so I've managed to track down the problem -- though I have absolutely no idea what's causing it. When the init function in memory.rs is called, GDB reports (when the hardware breakpoint is hit):
Breakpoint 1, kernel::memory::init::h4af39683c4e98d56 (
    physical_memory_offset=<error reading variable: Cannot access memory at address 0x10000401ce8>, memory_map=<error reading variable: Cannot access memory at address 0x10000401cf0>,
    start_addr=<error reading variable: Cannot access memory at address 0x10000401cf8>)
    at src/memory.rs:161
161     pub fn init(physical_memory_offset: u64, memory_map: &'static MemoryMap, start_addr: u64) {

This is extremely confusing and suggests that part of the kernel is being corrupted or something. I'm using bootloader v. 0.8.9; I can't use the absolute latest version because it won't build and so cargo sees no update when I run cargo update. Does anyone have any idea on what's causing these memory errors?

Interesting. In my kernel, I get a GP fault whenever I try to access memory beyond 0x13FFF. Is this the case in your kernel? Try testing access to address 0x13FFF with a breakpoint and then 0x14000, and see if it works. If not, then my issue might be of the same origin. I have tried to clear the WP bit in CR0, but it doesn't seem to affect my access to the default pages.
I can confirm that paging is enabled by default on my kernel after the bootloader initializes.
The default value of CR0 for me in the bootloader was given at a breakpoint that I made (I'm using core and llvm_asm, not the x86_64 crate, but the interrupts work perfectly with fully-featured stack traces). To see if you are, in fact, in a very similar default environment to that of mine, please try the following code that I wrote up for my kernel to test in your kernel, and see if it fails. If not, then we are in semi-similar environments:
let cr0: usize;
llvm_asm!(
"
movq %cr0, %rax
" : "={rax}"(cr0) : : "rax" : "volatile"
);
assert_eq!(cr0, 0b10000000000000010000000000010001);

Further, I would guess that part of your dependencies section in your Cargo.toml would look somewhat like this in the case where this doesn't fail, but I could be wrong:
bootimage = "some_version_here"
bootloader = "some_version_here"

Regardless of this, though, I think this might be able to solve your problem, but I could be wrong:
lllvm_asm!(
"
movq %cr0, %rax
btrq $$16, %rax
movq %rax, %cr0
" : : : "rax" : "volatile"
);

Of course, in the spirit of Rust, unsafe things like this shouldn't have to be done. I hope a safer (and more accurate?) solution exists.
One thing that pops out to me in that triple fault is the state of CR3:
CR3=0000000000001000

I could be wrong, but from my understanding this implies that the PML4 is at address 0x1000 (if normal long-mode paging is being used, which should be the case when entering long mode)? If someone could clarify this, this would be quite useful. For further understanding, see chapter 5, section 3 of https://www.amd.com/system/files/TechDocs/24593.pdf and the page https://wiki.osdev.org/Long_Mode.
If you have any questions, please let me know, and I will try my best to help.

I've managed to fix this (I had to split interrupts into a two stage initialization sequence). Now I'm running into a different error -- see Issue issue #815.


Dependabot should not look into nuget disabledPackageSources

I work on projects that use private nuget feeds only and we block public feeds using disabledPackageSources. Our expectation is that Dependabot would offer some way to ignore feeds or respect project configuration for disabledPackageSources.

This should be working now with https://github.com/dependabot/dependabot-core/pull/5874. Let us know if you have any issues!


ArgumentError: wrong number of arguments (given 4, expected 1..3) for activerecord-jdbcsqlite3-adapter

I saw similar issues, but sqlite3 adapter seems to not be updated for years.
JRuby <IP_ADDRESS>, ActiveRecord 7.0.7, activerecord-jdbcsqlite3-adapter 70.1.
ArgumentError: wrong number of arguments (given 4, expected 1..3)
                      initialize at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-jdbc-adapter-70.1-java/lib/arjdbc/abstract/core.rb:12
                             new at org/jruby/RubyClass.java:931
                             new at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-jdbc-adapter-70.1-java/lib/arjdbc/jdbc/callbacks.rb:14
                 jdbc_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-jdbc-adapter-70.1-java/lib/arjdbc/jdbc/connection_methods.rb:10
                     public_send at org/jruby/RubyKernel.java:2119
                  new_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:656
         checkout_new_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:700
  try_to_checkout_new_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:679
              acquire_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:640
                        checkout at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:341
                      connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:181
             retrieve_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_handler.rb:211
             retrieve_connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_handling.rb:313
                      connection at /home/alex/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_handling.rb:280
                          <main> at /home/alex/Projects/ruby/email_address/test/activerecord/user.rb:34

Facing similar issue for mysql adapter :
When can we expect activerecord-jdbcmysql-adapter to support rails 7.1?
JRuby <IP_ADDRESS>, ActiveRecord 7.1.0, activerecord-jdbcmysql-adapter 70.1.
Uncaught exception: wrong number of arguments (given 4, expected 1..3)
/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-jdbc-adapter-70.1-java/lib/arjdbc/abstract/core.rb:13:in `initialize'
/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/userstamper-4.1.0/lib/userstamper/stampable.rb:22:in columns' 	/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/activerecord-7.1.1/lib/active_record/model_schema.rb:503:in column_names'
/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/userstamper-4.1.0/lib/userstamper/utilities.rb:30:in available_association_columns' 	/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/userstamper-4.1.0/lib/userstamper/stampable.rb:69:in add_userstamp_associations'
/home/sam/Projects/SDKs/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/userstamper-4.1.0/lib/userstamper/stampable.rb:39:in stampable' 	/home/sam/Projects/awetest/app/models/regression_test/job.rb:14:in class:Job'
/home/sam/Projects/awetest/app/models/regression_test/job.rb:3:in

A year later, I have the opposite problem. I get this error:
23:40:20 web.1  | ArgumentError (wrong number of arguments (given 1, expected 4)):
23:40:20 web.1  |
23:40:20 web.1  | activerecord-jdbc-adapter-70.2 (java) lib/arjdbc/sqlite3/adapter.rb:92:in `initialize'
23:40:20 web.1  | activerecord-jdbc-adapter-70.2 (java) lib/arjdbc/abstract/statement_cache.rb:23:in `initialize'
23:40:20 web.1  | org/jruby/RubyClass.java:922:in `new'
23:40:20 web.1  | activerecord (7.2.1) lib/active_record/database_configurations/database_config.rb:26:in `new_connection'

My Gemfile contains:
IS_JRUBY = (defined? JRUBY_VERSION)
if IS_JRUBY
  ruby '3.1.4'
  gem 'activerecord-jdbc-adapter'
  gem 'jdbc-sqlite3'
else
  ruby "3.3.4"
  gem 'sqlite3', '>= 2.0.4', '~> 2.0'
end

My Gemfile.lock contains:
activerecord (7.2.1)
activerecord-jdbc-adapter (70.2-java)
jdbc-sqlite3 (<IP_ADDRESS>)

@keithrbennett your problem is mostly due to the fact we do not support Rails 7.2.  The thing we are not communicating well is that 70.x is Rails 7.0.x and when we support Rails 7.2 you will see a version 72.x come out for the adapters.  It is good that postgresql is working but that is somewhat surprising since we have a lot of fixes coming in for 7.1 support.  It is possible Rails 7.2 reverted something significant and the 70.x gems happen to work?

@enebo  Thanks for your reply. Sorry I didn't explain that clearly. It's not that Postgres works with Rails 7.2, it's just that I only tried to get it to work with Sqlite. This is a web site running on C Ruby in production, but I was hoping to make it JRuby compatible. I will defer that with Postgres until a future time.


Update favicons to v5.1

Pull Request Test Coverage Report for Build 303

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 96.522%

Totals

Change from base Build 301:
-0.1%

Covered Lines:
77

Relevant Lines:
77

💛  - Coveralls


FUSETOOLS2-2272 - Generate SBom and store it as GitHub Workflow artifact

npm ERR! code ELSPROBLEMS

tool used for sbom generation does not support yarn as-is :'-(

first iteration done using another tool https://github.com/KaotoIO/vscode-kaoto/pull/472


Add solomachine clientID constant to testing package

Summary
Add a default clientID used for association of solo machine clients created on a tendermint chain:
diff --git a/testing/values.go b/testing/values.go
index 460e27a23..44af56e8f 100644
--- a/testing/values.go
+++ b/testing/values.go
@@ -18,9 +18,10 @@ import (
 )

 const (
-       FirstClientID     = "07-tendermint-0"
-       FirstChannelID    = "channel-0"
-       FirstConnectionID = "connection-0"
+       FirstClientID       = "07-tendermint-0"
+       FirstChannelID      = "channel-0"
+       FirstConnectionID   = "connection-0"
+       SolomachineClientID = "06-solomachine-0"

        // Default params constants used to create a TM client
        TrustingPeriod     time.Duration = time.Hour * 24 * 7 * 2

Replace all usage of the "06-solomachine-0" string. See comment
It could make sense to use the name DefaultSolomachineClientID over SolomachineClientID

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hi! Is anyone currently working on this issue? I would like to give it a try :)

Hi! Is anyone currently working on this issue? I would like to give it a try :)

No, nobody is working on this issue yet, so thanks very much of volunteering! I will assign it to you now.

Which could be a good place to export such a variable in your opinion? Since it is used only from test files is the testing/solomachine.go a good option?


Add validation to check target column in query instance

Alerting users when they look to generate counterfactuals that they don't have target in their query instances.

Signed-off-by: gaugup<EMAIL_ADDRESS>

@soundarya98 could you take a look at this PR?
Regards

@soundarya98 could you take a look at this PR?
Regards

Thanks for the pull request! I've added my comments, other than that, the PR looks good!


Invalid docker run command when db platform is empty

Image name is treated as platform:
Starting up database
Starting up my-db
> docker run -d
        -p 9004:5432
        -v my-database:/var/lib/postgresql/data
        --name monarch-db
        --network kaiser_net
        -e POSTGRES_PASSWORD=example
        --platform  postgres:alpine

"docker run" requires at least 1 argument.
See 'docker run --help'.

Usage:  docker run [OPTIONS] IMAGE [COMMAND] [ARG...]

Ah, you have done something for it already #75