Don't retry on connection error

Note: TimeoutError is a subclass of the generic connection error, and we'd like to retry for timeouts.
This patch also rearranges the code a bit, incl. making sure that it won't sleep at the very last iteration when we know there won't be another retry attempt.
Closes: https://github.com/instructlab/eval/issues/77

@khaledsulayman

I think one of the reasons for being liberal with the exception handling at this level is that it's not uncommon in runs of MT-Bench to see 400's get returned randomly in a sea of 200's.

That being said it seems like the errors you're handling are not 400s so this fix seems helpful.
@danmcp any thoughts here?

@danmcp what if we were to add some handling on the final retry and raise something more descriptive of what actually went wrong? Whether we want to ignore a one-off error during a single run is one thing, but if we hit max retries and especially if it's all the same error, I think it makes sense to have enough granularity to be able to easily see what went wrong.

@danmcp what if we were to add some handling on the final retry and raise something more descriptive of what actually went wrong? Whether we want to ignore a one-off error during a single run is one thing, but if we hit max retries and especially if it's all the same error, I think it makes sense to have enough granularity to be able to easily see what went wrong.

As an example of an issue that's easy to hit is the context length of your judge model is too small.  Something around 5120 is required by mt-bench.  In those cases, for the conversations that require larger than your judge model supports, it's going to fail consistently on those questions.  We then have a choice of failing and raising the exception or failing and counting in the error rate.  The original logic ignored the error and so we added the error rate to at least account for it.  And other errors are possible too such as the model might not give an answer in the expected format.  If we change the logic to fail fast on errors, it could throw away hours of runtime.  If everything is perfectly tuned, this might be fine.  But we would need to prove that can be accomplished reliably before we can make such a change.
I think some easy wins are:

Catch specific exceptions as is being done in this PR which indicate the system isn't working at all.  We just need to make sure the exceptions indicate complete failure and not flakiness.
Adding an option to not raise exceptions on a particular class of problems.  Ex: context length of the model isn't long enough.  Anything that implied you weren't going to get valid results could fit into this bucket.  We need something like this for testing purposes to be able to use smaller models with testing.
Add tuning for the number of retries to attempt before giving up.

@danmcp "Adding an option to not raise exceptions on a particular class of problems. Ex: context length of the model isn't long enough." I think the issue is that there's no specific type to catch for such particular error. (But we can check what we have.)
I think in general - 1) the library should raise on error; 2) the caller should decide what to do with the error (log, crash, etc.) We can make callers track exceptions and, at the end of the eval, use the fact that any errors happened as the reason to exit with non-zero value (which should tell the test script it failed.)
btw I noticed that openai library apparently already retries and there's a tunable to control how frequently it does. https://github.com/openai/openai-python/blob/195c05a64d39c87b2dfdf1eca2d339597f1fce03/src/openai/init.py#L117

I think in general - 1) the library should raise on error; 2) the caller should decide what to do with the error (log, crash, etc.) We can make callers track exceptions and, at the end of the eval, use the fact that any errors happened as the reason to exit with non-zero value (which should tell the test script it failed.)

I am not quite sure how this would work.  To be able to make the decision on whether to continue on error, we couldn't raise an exception all the way outside the library.  At that point it's too late to continue.  We could have some sort of callback mechanism I guess.
At a high level I think we can all agree it's not great the code is eating errors.  More granular error handling should be able to differentiate the different types of errors and stop eating any errors that indicate something is broken vs hitting iffy configurations vs flakiness in various serving options.  But it's not clear that passing the errors on regardless of type solves the general problem.  The purpose of the library is to execute a benchmark.  In this case, it's a long running benchmark and some of the questions being asked by the benchmark may fail to get a valid response.  The library currently pushes the responsibility to the user to decide whether the error rate is acceptable.
So unless we get to the point where all api errors can be eliminated for long runs, it's not clear yet how we can do much better than isolating the failures which should fail fast (like model not found).
Letting the caller make a decision with a callback, or with exception handling (not sure how it would work still), or with env variable options, or by passing in options to declare what types of error should fail are all options we could support.  I am in favor of using such options to be able to fail for things like the max context length issue by default with an option to override.
If there is a suggestion to fail for any exception after retries, we just need to explain how it's going to work for long running jobs with potentially small error rates as well as work for testing with smaller context length models.

For reference, here is the list of openai exceptions:
https://github.com/openai/openai-python/blob/195c05a64d39c87b2dfdf1eca2d339597f1fce03/README.md?plain=1#L367-L376

Thanks for this, I think I start understanding larger context here. A strict exception discipline won't do when you'd like work to continue even after a bad answer is returned.

I think ultimately what's missing is gen_answers interface of an evaluator doesn't have any way to communicate the presence of errors in the output data. We could convert the type of the entrypoint to -> bool, then use this value to inform the caller that the produced data set has issues.

Another venue to explore could be: the library uses file system as interface to pass generated data to the caller. It could instead return the produced dataset (via yield?) and let the caller decide if it wants to accept a particular answer. I don't think it's the job of the library to write data onto disk...

Ignoring what can be done in this library, the caller could probably open the written file and check if it contains any error markers. If so, make sure an error return code is returned. (When it's ready.)

I will take some time to think on the issue. But if you have some preference or thoughts on the above alternatives, please let me know.

I think ultimately what's missing is gen_answers interface of an evaluator doesn't have any way to communicate the presence of errors in the output data. We could convert the type of the entrypoint to -> bool, then use this value to inform the caller that the produced data set has issues.

That's a really good point.  I've been thinking about this in terms of the openai api and the error rates we expose from judgment.  But we don't expose error rates on gen answers today.  Giving an error rate might be an appropriate return value?  That would match what we do for judgment.

Another venue to explore could be: the library uses file system as interface to pass generated data to the caller. It could instead return the produced dataset (via yield?) and let the caller decide if it wants to accept a particular answer. I don't think it's the job of the library to write data onto disk...
Ignoring what can be done in this library, the caller could probably open the written file and check if it contains any error markers. If so, make sure an error return code is returned. (When it's ready.)
I will take some time to think on the issue. But if you have some preference or thoughts on the above alternatives, please let me know.

As of now, my preference is to:

Add error rate (or equivalent) to gen_answers for completeness
Isolate errors from https://github.com/openai/openai-python/blob/195c05a64d39c87b2dfdf1eca2d339597f1fce03/README.md?plain=1#L367-L376 which should fail fast or fail after some number of retries.
Note I checked and we are getting <class 'openai.InternalServerError'> Service Unavailable with llama-cpp and cpu serving.  So I think your current impl of raising on APIConnectionError is appropriate.  I am slightly worried about not having the retries even that case though.  I assume we would get a similar error on network blip.

400 - discussed below.  Either need to allow or an option to allow.
401-404 - fail after retries
422-500 - include in error rate

Leave the -1 and "$ERROR$" in place for conditions we can't clearly classify as complete failures
Include your sleep fix

Can be fixed later, if we do we should open an issue

Create a way for some error codes to be allowed for testing purposes.  Namely allow the 400s.  And switch these cases to fail fast by default.

For now, a more limited approach just making the tests fail on errors in the output file: https://github.com/instructlab/eval/pull/85 while we think through a way to pass errors or error rate directly.

Also splitting out the sleep fix here: https://github.com/instructlab/eval/pull/84 since it's not directly related to this issue.

I'm leaving this as draft still until I have a chance to run it against a real server. (Will do it tomorrow.) Code wise, I hope this at least reflects the latest discussions and intent though. (I also included a minor change where I split out messages calculation out of the for loop; this is a separate commit to simplify review.)

Closing in favor of https://github.com/instructlab/eval/pull/103


u8-string-length, string->utf8, u8-substring

What

u8-string-length
u8-substring
string->utf8

Why
char type in S7 Scheme does not support unicode. As a result, string-length and string-ref should not support unicode. That's why I didn't rewrite string-length and string-ref to add unicode support.

The revision seems fine to me. Nice work!


Event should be an interface

As of v1.0.1, org.jeasy.states.api.Event is an abstract class. It is better to change it into an interface and rename the current abstract class to AbstractEvent.

Implemented in 6d99172e8c071992d51a38bac18e17ee7d7da0f0.


Add graph_reasoning to rosdistro

Package names:

graph_reasoning

Package Upstream Source:
https://github.com/snt-arg/graph_reasoning.git
Purpose of using this:
Reasoning on the low-level graph (i.e planes) generated by lidar_s_graphs for the automatic generation of high-level entities likes rooms, walls etc.
PR related to lidar_s_graphs ---> https://github.com/ros/rosdistro/pull/40800
Please Add This Package to be indexed in the rosdistro.
Iron and Humble
The source is here:
https://github.com/snt-arg/graph_reasoning.git
Checks

[ x] All packages have a declared license in the package.xml
[ x] This repository has a LICENSE file
[ x] This package is expected to build on the submitted rosdistro

New package review checklist

[x] At least one of the following must be present

[x] Top level license file:
[ ] Per package license files:

[x] License is OSI-approved: GPLv3
[x] License correctly listed in package.xmls
[x] Public source repo: https://github.com/snt-arg/graph_reasoning
[x] Source repository contains ROS packages
[ ] Each package meets REP-144 naming conventions - Unfortunately the name is very generic, and doesn't really tell us what it does.  I'm going to suggest you rename this to situational_graph_reasoning or snt_situational_graph_reasoning, which will explain what it does a lot better.

Hello @clalancette, could you update if the changes made to the repos names are okay?

Rebased with master :)

Since I've merged in some of the other things, this one needs to be rebased again.  We're getting closer.

@clalancette done!

Holding for Humble sync


Testing Blog

title: my great title
subtitle: my great subtitle
description: my great description
slug: my-title
tags: [Published]
category: blog
image: https://my_image_url.com/img-4.png
date: 2023-04-22
canonical: https://musabadru.netlify.app/my-title
my great intro
something awesome
my subtitle
lorem Ipsum
lorem ipsum

hello

it works well


Add homebrew-core installation instructions

xsv was added to homebrew-core in https://github.com/Homebrew/homebrew-core/pull/11427,
so this change mentions that installation option in the readme. The
wording was adapted from ripgrep's readme:
https://github.com/BurntSushi/ripgrep/tree/685cc6c5622b02fd5a53c8bc953176b159c780e4#installation

Oh wow, that's awesome! Thanks so much @josephfrazier!!!

Sure thing, thank you for writing xsv!

I noticed you released version 0.11.0 yesterday, so I went ahead and opened a PR updating homebrew: https://github.com/Homebrew/homebrew-core/pull/11757
Would you be interested in automating this process? If you also use homebrew, and you run make github to do the github release, it should be as simple as adding this line to the Makefile rule:
brew bump-formula-pr xsv --url="https://github.com/BurntSushi/xsv/archive/$(git describe --tags).tar.gz"

@josephfrazier I don't use a Mac myself, but I do have a Mac mini that I bought for exactly that kind of thing. I did not know about bump-formula-pr, but I will be sure to try it out on the next release! Thanks so much for the heads up and for sending PRs to homebrew-core. :-)

@josephfrazier I managed to get your command to work. It "fails" even though a PR was opened successfully:
$ brew bump-formula-pr --strict ripgrep --url="https://github.com/BurntSushi/ripgrep/archive/0.5.1.tar.gz"
==> Downloading https://github.com/BurntSushi/ripgrep/archive/0.5.1.tar.gz
Already downloaded: /Users/andrew/Library/Caches/Homebrew/ripgrep-0.5.1.tar.gz
Already up-to-date.
==> replace "https://github.com/BurntSushi/ripgrep/archive/0.5.0.tar.gz" with "https://github.com/BurntSushi/ripgrep/archive/0.5.1.tar.gz"
==> replace "8e210c7486cfb2a782cb0aab0c5eb7c1fae606b4279254b491a084c8da84c11d" with "e0724d40f069580bac9f28cbf6005020fdc1b80e5d15fb69679d50ca341116f9"
M       Formula/ripgrep.rb
Switched to a new branch 'ripgrep-0.5.1'
[ripgrep-0.5.1 b681313] ripgrep 0.5.1
 Committer: Andrew Gallant<EMAIL_ADDRESS>Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate.
You can suppress this message by setting them explicitly. Run the
following command and follow the instructions in your editor to edit
your configuration file:

    git config --global --edit

After doing this, you may fix the identity used for this commit with:

    git commit --amend --reset-author

 1 file changed, 2 insertions(+), 2 deletions(-)
Counting objects: 49666, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (15564/15564), done.
Writing objects: 100% (49666/49666), 15.43 MiB | 6.50 MiB/s, done.
Total 49666 (delta 36360), reused 47270 (delta 34025)
remote: Resolving deltas: 100% (36360/36360), completed with 2137 local objects.
remote: Checking connectivity: 49666, done.
To git@github.com:BurntSushi/homebrew-core.git
 * [new branch]      ripgrep-0.5.1 -> ripgrep-0.5.1
Branch ripgrep-0.5.1 set up to track remote branch ripgrep-0.5.1 from BurntSushi.
LSOpenURLsWithRole() failed with error -10810 for the URL https://github.com/Homebrew/homebrew-core/pull/12258.
Error: Failure while executing: hub pull-request --browse -m ripgrep\ 0.5.1

Created\ with\ `brew\ bump-formula-pr`.

My guess is that it was trying to open my browser to the PR that was submitted, but I run a headless mac over SSH.

Glad to hear you got it working! Yeah, hub pull-request --browse tries to open a browser. I guess brew bump-formula-pr just assumes it's not running headlessly...

@josephfrazier Ah, beautiful hack. Thanks for letting me know. :-)


Debug alway hit a breakpoint on lib/python3.6/imp.py

Environment data
VS Code version:  1.18
Python Extension version:  0.8.0
Python Version:   3.6.0
OS and version:    OsX 10.13.1
Every time I debug a file the debugger hit a breakpoint at env/asyncPython/lib/python3.6/imp.py

@osmay88
Apologies for the late response. Recently we've been working on a new Python Debugger.
Please could you install the latest version of the extension and use the new experimental debugger.
Go into your existing .vscode/launch.json file and change the setting "type":"python" to "type":"pythonExperimental"


Remove counter for single selection case

This PR removes Apply button bracers counter in case of spec's countable is false and maxSelectable is 1.

Add Russian and Ukrainian localization
Also here


Light2d combined with overlapping tiles is mixing underneath part of tile

Godot version
3.3.2.stable
System information
Windows 10, GLES 3, Nvidia GTX 970 471.11
Issue description
My Godot project has a Tilemap and a Light2d.
Some tiles do overlap (as like it is common when using isometric tiles).
As light texture I'm a using a radial gradient. When the Light2d Energy is set to st. other then 1, e.g. 0.2 the overlapping part of the underneath tile "shines through" (is mixed using the set mode). Setting "Y Sort" to "On" for the Tilemap does change the behavior a little bit, but there's still an shadow of the underneath overlapping part of the tile.
Note: It seems that the problem does not occur at the beginning. I've played a bit with the parameters and light size. It's more visible within the darker areas of the light texture.
See also: https://stackoverflow.com/questions/68367367/godot-engine-light2d-combined-with-overlapping-tiles-mixing-underneath-part
Steps to reproduce

Create a new 2d project with a Tilemap and a Light2d.
Add two different tiles to the tilemap
make the tiles size of the tilemap smaller then the sprite texures used
let 2 tiles overlapp
I'm usig a radial gradient texture as light
Play with changing the Light2d's mode (e.g. Mix)
Play with the Light2d's energy (e.E. 0.2 )
Set Y-Sort for the Tilemap to on (or off to see the difference)

Minimal reproduction project
BugTest.zip

Can you reproduce this after disabling batching in the Project Settings? Also, can you reproduce this after switching to the GLES2 backend?

I can confirm that 2d batching and the used GLES version does not have any effect to this issue

I get the result from the project.
I played with the settings. These are my results with Cell Y Sort On:
Driver      Batching    Editor/Game     Modes looking wrong

GLES3       enabled     Editor          Sub, Mix, Mask
GLES3       enabled     Game            Mask
GLES3       disabled    Editor          Sub, Mix, Mask
GLES3       disabled    Game            Mask

GLES2       enabled     Editor          Mask
GLES2       enabled     Game            Mask
GLES2       disabled    Editor          Mask
GLES2       disabled    Game            Mask

Tested with Godot 3.3.2, Windows 10, NVIDIA GeForce GTX 750 Ti.
I also tried removing the alpha channel from the images, and changing their import settings, but that didn't seem to make a difference.


pfe-cta - svgs in ie11 are receiving focus

The accompanying svgs in default ctas are receiving focus in ie11. This fix is focusable="false"' needs to be added to the  in the template

Since this isn't a break or preventing loading, I'm going to close this out.


Animation jerky when opening

When opening the modal there's a lag. Adding useNativeDriver prop helps solve the jerky issues but it also disables the slideout (closing) animation.

having same 'jerking' issue in android when opening and closing

@jeffinhk I ended up using a customised model to replicate this drawer

+1


6.x version of #4769

These changes were in https://github.com/ReactiveX/rxjs/pull/4769 and merged to master, but they also needed to be merged to 6.x.
/cc @benlesh

Thank you!


error message every 10 minutes about managing the server certificate

I'm getting error output like this every 10 minutes from acme-dns. Is this spurious? Can I do anything to prevent the error?
error        maintenance        unable to get configuration to manage certificate; unable to renew        {"identifiers": ["auth.xxxx.com"], "error": "config returned for certificate [auth.xxxx.com] is not nil and points to different cache; got 0xc000027b90, expected 0xc000027c70 (this one)"}

The certificate used by acme-dns for its HTTPS traffic works fine, in that there is no complaint from the client side. In config.cfg I have tls = "letsencrypt".
I'm running acme-dns as a systemd service, running as the unprivileged acme-dns user.  /var/lib/acme-dns/api-certs and everything comprised in there is owned and writable by the acme-dns user.
I tried removing all of /var/lib/acme-dns/api-certs and running acme-dns service from scratch. It rebuilds the cert in a new /var/lib/acme-dns/api-certs directory, but I soon get the same recurring error messages.
It appears that the error message comes from the github.com/caddyserver/certmagic module used by acme-dns, but I have not been able to work out why it throws that error.
I ran acme-dns as root for a while before improving the setup to run as an unprivileged user. I wonder if that left some remnant that needs to be cleaned up, but I can't find any such thing.

I am receiving the same messages. Did you manage to find out the cause?
I've never run acme-dns as root, so that can be ruled out. I built the executable from the latest source using go 1.18.1 and am running it on a fresh Ubuntu 22.04.3.

I ended up not using acme-dns and so I don't have more info.

May I ask what you are using as an alternative?

(Probably not helpful, but...) I was planning to use acme-dns to manage certs on a private development network on a DNS sub-domain. It worked OK, but management decided to just buy a wildcard cert for that subdomain, making acme-dns moot in our case.

Ah okay. I thought there might be a different solution to acme-dns but that does not seem to be the case then.

For the rest that are facing the cache issue: I have found a solution but am not sure whether this is the correct patch as I have added quite a bit of source code to acme-dns. So try it out and give feedback whether it works for you. It is based on the refactoring branch.
From 003a56d677fe0cf621ea92fc9446cf45a199e277 Mon Sep 17 00:00:00 2001
From: Philipp Kolberg<EMAIL_ADDRESS>Date: Wed, 29 Nov 2023 22:43:49 +0100
Subject: [PATCH] Fix certmagic cache handling

---
 pkg/api/api.go | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/pkg/api/api.go b/pkg/api/api.go
index 9fc96f6..bd75129 100644
--- a/pkg/api/api.go
+++ b/pkg/api/api.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"crypto/tls"
 	"net/http"
+	"sync"

 	"github.com/acme-dns/acme-dns/pkg/acmedns"

@@ -14,10 +15,12 @@ import (
 )

 type AcmednsAPI struct {
-	Config  *acmedns.AcmeDnsConfig
-	DB      acmedns.AcmednsDB
-	Logger  *zap.SugaredLogger
-	errChan chan error
+	Config  	 *acmedns.AcmeDnsConfig
+	DB      	 acmedns.AcmednsDB
+	Logger  	 *zap.SugaredLogger
+	errChan 	 chan error
+	magicCache   *certmagic.Cache
+	magicCacheMu sync.Mutex
 }

 func Init(config *acmedns.AcmeDnsConfig, db acmedns.AcmednsDB, logger *zap.SugaredLogger, errChan chan error) AcmednsAPI {
@@ -137,12 +140,17 @@ func (a *AcmednsAPI) setupTLS(dnsservers []acmedns.AcmednsNS) *certmagic.Config
 	magicConf.Logger = a.Logger.Desugar()
 	magicConf.Storage = &storage
 	magicConf.DefaultServerName = a.Config.General.Domain
-	magicCache := certmagic.NewCache(certmagic.CacheOptions{
-		GetConfigForCert: func(cert certmagic.Certificate) (*certmagic.Config, error) {
-			return &magicConf, nil
-		},
-		Logger: a.Logger.Desugar(),
-	})
-	magic := certmagic.New(magicCache, magicConf)
+	a.magicCacheMu.Lock()
+	if a.magicCache == nil {
+		a.magicCache = certmagic.NewCache(certmagic.CacheOptions{
+			GetConfigForCert: func(cert certmagic.Certificate) (*certmagic.Config, error) {
+				return a.setupTLS(dnsservers), nil
+			},
+			Logger: a.Logger.Desugar(),
+		})
+	}
+	certCache := a.magicCache
+	a.magicCacheMu.Unlock()
+	magic := certmagic.New(certCache, magicConf)
 	return magic
 }
--
2.39.3 (Apple Git-145)

I have the same issue with the current master @27e8251d11ba0a08c9b576fc04d61c1c7ba9b500
What is striking is that it creates 2 caches, but I do not know where these are coming from:
Apr 08 20:13:32 vmanager9064 acme-dns[16782]: 1.7126072127843883e+09        info        maintenance        started background certificate maintenance        {"cache": "0xc000026800"}
Apr 08 20:13:32 vmanager9064 acme-dns[16782]: 1.7126072127844315e+09        info        maintenance        started background certificate maintenance        {"cache": "0xc000026880"}
...
Apr 08 20:43:32 vmanager9064 acme-dns[16782]: 1.712609012784654e+09        error        maintenance        unable to get configuration to manage certificate; unable to renew        {"identifiers": ["<snip>"], "error": "config returned for certificate [<snip>] is not nil and points to different cache; got 0xc000026800, expected 0xc000026880 (this one)"}

This issue is independent of having one or multiple accounts in api-certs/acme directory.
I found a similar issue for https://github.com/caddyserver/caddy/issues/5162 also related how to use certmagic.

Fix for current master developed and tested. Pull rquest is https://github.com/joohoi/acme-dns/pull/351

ty. wonder why this isn't merged yet. manually applied and now i have a new cert again! :+1:


second draft to show additional proposal questions on the proposal form (issue #13)

Fixes: #13
this is still work in progress for testing only.
proposal questions are now shown at the bottom of the proposal form.
speaker/profile question are shown in the profile form above the availability question (because the availability is such a huge box that i felt a one line question below it might be skipped)
the question form has been disabled (but no code removed), which breaks several tests in tests/cfp/views/test_cfp_wizard.py
two different methods have been used to import the questions into the forms. this is intentional. while the second method (used on the profile form) is simpler, it may not allow reordering questions later. so i want to try both to see which one will be better later.

Thanks could you add a screenshot, please?


[FLINK-13450][test] Adjust tests to tolerate arithmetic differences between x86 and ARM

What is the purpose of the change
math.log and math.pow can actually return slightly different results across platforms because of hardware optimizations. We should use StrictMath instead to ensure the answers are already the same.
Brief change log

Changed Math.log to StrictMath.log
Changed Math.pow to StrictMath.pow

Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@TisonKun, hi, thanks for your comment. I don't know what scope is better, since this pr changed many modules.  any suggestion? Thanks.

Hi @wangxiyuan I revoke my change request above. After taking a look at the corresponding issue I know the root cause of this pull request is to adjust test so sort it into test component makes sense to me. Besides, what do you think if we change the title of the pull request and the commit to "Adjust tests to tolerate arithmetic differences between x86 and ARM" as the original JIRA written? I think it is more descriptive.

@flinkbot run travis

Could we reduce the changes to the scope where we really need strict results?
It looks like this mainly matters for result verification (some tests) and for the SQL functions.
In other parts, like exponential backoff, strict precision doesn't actually matter.
In some parts, like samplers, the performance is more important than the precision, so we should not use StrictMath there at all.

To clarify how this relates to my previous comment ("have just StrictMath"):
Within a module (like SQL scalar functions) I would not try to switch back and forth between Math and StrictMath. But between different uses (sampler versus SQL function) we can differentiate where we need it and where not.

@StephanEwen Thanks for your review. ThenI just change the place where affect the test.

can anyone review this PR? Thanks.

@StephanEwen may this PR be visited again?

Looks good to me.
Merging this...


Updated link to Jooby pa4j documentation

Updated link to Jooby pa4j documentation
Before submitting any pull request, please read the contribution guide: http://www.pac4j.org/docs/contribute.html

Thanks for the update


Force HTTPS

We have never forced HTTPS on the browser. When not using HTTPS, the find my location function in the search bar does not work in Chrome because of https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features.
This will be done through Cloudflare, but tagging here in case of the need for discussion.

Forced 👊  https://openaerialmap.org/


Suspended GitHub App Installations

A new API was added for suspending GitHub app installations: https://developer.github.com/changes/2020-05-01-suspending-a-github-app-installation/
Suspend Installation: https://developer.github.com/v3/apps/#suspend-an-installation
Unsuspend Installation: https://developer.github.com/v3/apps/#unsuspend-an-installation

Thank you, @nightlark!
This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!
Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started.
Thank you!

May I have a shot on this one? :slightly_smiling_face:

Thank you, @joshuabezaleel!
It is yours.

While I was browsing the docs, I also found that "Delete an installation" also hasn't been implemented yet. Should I added this to the to-do lists? @gmlewis


Is it possible to incorporate a FAB using this package?

As of now, I couldn't find any way to do this directly from scaffold. I'll try doing it with Stack and all but I'd like to know if there is an easier way to do so.

This seems a weird question to me. If you know how to create a FAB, it is not much different with or without this package.
I assume that you think the BottomNavigationView and FloatingActionButton should be in the same scaffold. However, it doesn't have to be. You can add your own scaffold to a page.
Example code:
pages: [
  (_) => Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
      ),
      body: Center(child: Text("Welcome to bottom_nav_layout"))),
  (_) => SliderPage(),
  (_) => Center(
        child: TextField(decoration: InputDecoration(hintText: 'Go..')),
      ),
],

I see, somehow I didn't think of doing like that.
Your assumption was correct, I did think that it needs to be in the same scaffold.
Now, I'm doing it a bit differently, by using a stack and putting the fab on top of the whole view. It works fine for now but thanks for helping me (✿◡‿◡)

For what you are trying to achieve, the stack approach seems inappropriate to me. I would advise against it. It would still work but you do not need a stack for a FAB.
But still, I do not know the context of your situation. Might be good.


Should Notes Be Imported?

Are the Notes and story elements from the map JSON supposed to be imported somehow?  I was hoping that the notes from the JSON would be created as Journal Entries when the scene was created but I don't see them anywhere.

After some digging and experimentation, it looks like this was a misunderstanding on my part.  Notes are imported and are related to JournalEntries but aren't quite the same thing.
For anyone else that has this misunderstanding, select the Journal Notes tool from the left-hand side (pictured below) and the notes will be displayed on the map.


Spyder splash screen low resolution + other things

Here's the splash screen that I see with my Spyder v5.1.1:

I think it could be improved on three fronts:

The top-left/right corners are not round (like the bottom corners)
The splash screen is low-resolution and doesn't appear sharp on high-res monitors
(this might be opinionated, but anyway) the background photo, in my opinion, doesn't really add any more value to the splash screen (a person sitting next to a laptop seems a bit random to me for a splash screen of an IDE software). In fact, I think it's detracting from the beauty of the splash screen, compared to just a simple gradient red (instead of a splash screen). Again, this is my opinion, so don't take it personally.

Hey @ma-sadeghi, thanks for reporting. I'm going to move this issue to our ux-improvements repo, where we have discussions like this.


⚙ Fix wordmark SVG error

Fix the error that occurs when searching for an SVG with a wordmark and when searching for another SVG without a wordmark, as this causes the image to break.
Before:
https://github.com/user-attachments/assets/f57409f6-1f85-4826-a413-f6cfc0bc5add
After:
https://github.com/user-attachments/assets/5c84909b-7609-4e27-ad45-8fe9eecfeaac

Thanks to fix it 🤗🚀


Allow mods to specify a custom window icon

We already has builtin support to set the window title to a mod's name, so there is no reason this shouldn't exist

Thought this didn't work, i guess DP isn't a great test case


[Snyk] Upgrade @types/node from 20.4.2 to 20.4.5

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @types/node from 20.4.2 to 20.4.5.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released 21 days ago, on 2023-07-25.

Release notes

Package name: @types/node

20.4.5 - 2023-07-25

20.4.4 - 2023-07-22

20.4.3 - 2023-07-21

20.4.2 - 2023-07-12

    from @types/node GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Superseded by #338


Insufficient explanation for C2784

It doesn't tell why we supplied an object instead, or why supplying an int didn't work ? It would be very helpful, if a bit more of explanation is put there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06252b48-c0a0-df41-abb3-8fea92626f9a
Version Independent ID: f18e8d01-9739-a7c1-d7bb-16a5957e7fe8
Content: Compiler Error C2784
Content Source: docs/error-messages/compiler-errors-2/compiler-error-c2784.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


Create an auth-free config for testing

Create a 'no auth required' config for the flask app to run the latest versions without needing tyk or keycloak. Would be useful for testing and development cases where we don't need the gateway or want to use login tokens.

This was addressed in https://github.com/CanDIG/ga4gh-server/commit/65cb337b61ac65aef14bfa32477d44dc7a1b4508


Add timeout, increase exception handling and clarify naming

Signed-off-by: Nindemic<EMAIL_ADDRESS>

Can you fix the missing dollar signs: https://github.com/smaddis/smad-deploy-azure/blob/e7fa9620072102d3d765ff3e6653a023cc40215a/tests/honoscript/send.sh#L46-L53 ?

LGTM.

LGTM


Secret can now be read from file

In order to implement issue #99 I added the possibility to read the secret from a file (both for the client and the server). The main changes are as follows:

changed structure of client.rs: before the auth variable would be assigned without checking for the existence of secret, now check first whether secret exists as a variable or if it is a file path (in which case the file is read and its content are processed)

before:
let auth = secret.map(Authenticator::new);
if let Some(auth) = &auth {
    auth.client_handshake(&mutstream).await?;
    }

after:
let secret :Option<String>  = if let Some(var) = filepath {
            let file_content = file_reader(var).await;
            Some(file_content)
        } else if secret.is_some() {
                let secret_string = secret.unwrap();
                Some(secret_string)
        } else {None};

Changed secret type from &str to String: This makes it easier to find out whether we have received a path to a file where a secret is stored or the secret itself as a string. The clap crate already returns the environmental variables as String so we remove the necessity to call ".as_deref()" when starting a new instance of Server or Client.
file_reader function: Reading the file and handling the errors (also checks for empty files) is done by the function to avoid cluttering the code and it is put in the shared.rs so that both the client and server can use it
Added the fs feature from the tokio crate
Edited the tests to work with the new type: Just changed the strings to String::from(...)
Modified the environmental values: Adding a secret string or filepath is now done via flags, making it clearer that they are optional and mutually exclusive (in case both are present, filepath has precedence)

I don't have much experience contributing to open-source projects but I really like the tool and wanted to contribute. If any changes or adjustments are needed I am happy to help. :)

I'm closing because additional options are not in scope for bore. It's a small program and meant to be read/forked if you have more particular use cases.
I don't have the resources to maintain a general-purpose tool, and I think something like this is better built for your specific use case regardless


Fails to build on most recent rust nightly

Seems to be due to this change in rust-lang: https://github.com/rust-lang/rust/commit/44440e5c18a1dbcc9685866ffffe00c508929079
   Compiling termbox-sys v0.1.2 (file:///Users/sameerdhar/.cargo/registry/src/github.com-1ecc6299db9ec823/termbox-sys-0.1.2)
build.rs:81:29: 81:32 error: the trait `core::fmt::Display` is not implemented for the type `&mut std::io::process::Command` [E0277]
build.rs:81     println!("running: {}", cmd);
                                        ^~~
note: in expansion of format_args!
<std macros>:2:42: 2:75 note: expansion site
<std macros>:1:1: 2:77 note: in expansion of println!
build.rs:81:5: 81:34 note: expansion site
error: aborting due to previous error
Could not compile `termbox-sys`.

Just released 0.1.3 with this fix


Headless Chrome browsing on Heroku

Has anyone been able to get headless Chrome browsing working on Heroku with Ruby code? I'm  obtaining this runtime error;
Selenium::WebDriver::Error::WebDriverError - Unable to find chromedriver. Please download the server from http://chromedriver.storage.googleapis.com/index.html and place it somewhere on your PATH. More info at https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver.
I have installed successful all the required build packs for Ruby/Sinatra;
https://github.com/heroku/heroku-buildpack-google-chrome
https://github.com/heroku/heroku-buildpack-chromedriver
On my local installation(MacOS) everything runs well. So I know the Ruby code, Watir, Chrome e.t.c are okay. The issue seems to be with the Heroku settings. I suspect there are some config variables I need to setup in regards to chromedriver.exe path.
Anyone's assistance is greatly appreciated.

This would be better suited as a question on stack overflow, as this is not a problem with Watir code.
You might try using the webdrivers green to manage chromedriver, so you can avoid dealing with path on the remote machine.

@arnoldmarunda check out the following:
for heroku-16 truly headless: https://github.com/jormon/minimal-chrome-on-heroku
for cedar-14 running with xvfb: https://github.com/jormon/minimal-chrome-on-heroku-xvfb

We also had problems to get chromedriver up and running on heroku. We got it working by passing the path to the chromedriver bin. Maybe our solution helps you in some way: https://stackoverflow.com/a/50781946/135160


Is it free / can I use it with multiple users

I have two questions about this plugin:

I would really like to use it, is it free?  And 2. Can I use it to connect multiple players?

What do you mean by that? @MuhammedKpln

How can I connect to multiple peers?

Bump @MuhammedKpln


enoki-jit repository no longer exists

It seems like the enoki-jit repo is a private repo, so this repo can't be cloned/compiled successfully.

Hi @PeterGottesman ,
Indeed, those repositories were made private a few weeks ago. For the reasons, please take a look at the README here:
https://github.com/mitsuba-renderer/mitsuba2/tree/next

Any update on when enoki-git might return?


Variable server event parameters prototype

It converts a few Lua types (Number, String, Nill, Bool) into a MarshalledLuaValue that can be sent over the wire to the bridge then to the client.
Also some remarks to consider in comments.

Probably should add a error! for when the conversion fails so a developer gets something a little more meaningful information than a true or false on the callEvent method.


REFACTOR: Add [readonly] to class fields where appropriate

There are places where we should mark a cluster field as readonly.  Let's do a quick pass and do this:

[x] static char[] fields
[x] syncLock fields

DONE


Update README.md

Mention "web interface" and "command-line client tool" arangosh on the ...Other features of ArangoDB include:... section. I think it's worth mentioning there as part of nice feature.
Pull Request Guidelines
Pull requests are an essential collaborative tool for modern software development.
The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

Reduce the amount of recurring defects
Reduce the impact to the other developer’s time and energy spent on defects in your code
Increase the overall autonomy and productivity of individual developers

Acceptance Checklist
The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[ ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[ ] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[ ] The behavior change can be verified via automatic tests

Related Information
(Please reference tickets / specification etc )

[ ] There is a GitHub Issue reported by a Community User:
[ ] There is an internal planning ticket:
[ ] There is a JIRA Ticket number (In case a customer was affected / involved):
[ ] There is a design document:

Testing & Verification
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This PR adds tests that were used to verify all changes:

[ ] Added Regression Tests (Only for bug-fixes)
[ ] Added new C++ Unit Tests (Either GoogleTest or Catch-Test)

Did you add tests for a new RestHandler subclass ?
Did you add new mocks of underlying code layers to be able to verify your functionality ?
...

[ ] Added new integration tests (i.e. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

[ ] There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
[ ] I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Think about whether the new code you added is modular enough to be
easily testable by unit tests written with GTest / Catch. It is not good if your feature is so interconnected
that it prevents other people from writing their own unit gests. It should be possible
to use your code in future without extensively mocking your classes.
A bad example that required some extensive effort would be the storage engine API.

Documentation

All new Features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the changelog so that
developers and users have a concise overview.

[ ] Added a Changelog Entry (referencing the corresponding public or internal issue number)
[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the http API
[ ] Added Swagger examples for the http API

CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

A welcome change, but leaving it up to product management. Some of the other points should be revised.
BTW. We have this list on the docs homepage as well.

@Simran-B ow ic ic, yes, it appears as well on the docs page

@Simran-B thank you, and should appear on the docs as well

Thank you too, and yes, I will update the docs but not before the fully updated list is ready.


Multiple Client Data handling with ESP32 BLEServer (IDFGH-1866)

I am operating one ESP32 as a server. I have 2 clients to be connected with this server. One of those clients is an ESP32 and another client is my mobile phone. The strings coming from the mobile phone must be sent to the server and eventually to the client ESP32. How can this be done??

@kowshik1234 Thanks for reporting, Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. And for "how" questions, we suggest you raise a post on our forum at https://esp32.com. Thanks.

@kowshik1234 Hi, checked that this ticket is same with the post on https://esp32.com/viewtopic.php?f=2&t=12328&p=49299#p49299. Will close this ticket and track on the post. Thanks.


copr: added sub duration and string

signed-off-by: aswin<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #9016
Problem Summary:
What is changed and how it works?
What's Changed: Added vectorize sub duration and string
Check List
Tests

Unit test

Release note

No release note

/cc @andylokandy

Please fix dco and tests

I added the signature by git commit, not sure why DCO is still failing

The unit test i wrote are passing when i run them directly but the  make test is failing on some other part.
I didn't modify any other file, so not sure why it's failing

You may try squash the commits and force push.

/merge

@aswin6197 Thanks for your contribution. Would you like to fix/answer the comments? I'd like to merge it soon after that.

I made the changes Xuanwo suggested.
Sorry about the delay.

@aswin6197 Thank you for your patient, but the test still fails, would you like to take a look?

I think i might have messed up trying to fix the conflicts, should i just make a fork from the master and redo it.


JAMES-3680 - Change doOauth, provisionInbox method to protected for inheritance

IMO @vttranlina it is acceptable to just copy AbstractAuthProcessor to their module.

IMO @vttranlina it is acceptable to just copy AbstractAuthProcessor to their module.

If we copy it, the ImapPackage will not work.
ImapProcessor force cast from org.apache.james.imap.processor.base.AbstractProcessor
Not gcs.AbstractProcessor

I think it's ok to leave it there. Except if objections,  could benefit other custom implems regarding oauth but also easier to maintain with code upgrades?


specific path

Hi !
Thank you for the great work ! could you please give me the specific path，e.g. the specific path of the evaluate command ：-r reconstruction path  -p path of  checkpoint？thank u very much！

thanks for your reply，I use the command "python downloader_openimages.py"to download the dataset "openimages" in the folder STF. Then I use the command"CUDA_VISIBLE_DEVICES=0 python -m compressai.utils.eval_model -d /openimages/test/data/ -r reconstruction -a cnn -p ckpt --cuda",but why there is an error "No such file or dictionary:'/openimages/test/data/'" ? Is there any fault in my path of the dataset？Or could u  please give me the specific path of the datasets？I would really appreciate it if you could give me some answers！

Using “openimages/test/data/” instead of "/openimages/test/data/"

thanks a lot！By the way，could u please tell me where can I download checkpoint？ The checkpoint  file is the cnn_xxxx_best.pth ?Please forgive me if I'm getting this wrong.

Yes, the checkpoint file is "cnn_xxxx_best.pth" , Download links have been provided in "Readme.md".  For example, cnn_0035_best.pth


Challenges of Large Language Models

Open Source
Unfortunately most llama based and other free models fail to work with the tools defined by langchain. It works for single functions but already the current complexity of langsim they struggle.
ChatGPT

ChatGPT 3.5 turbo can execute the calculation of one nobel metal but fails to execute a loop over all nobel metals. It seems like the abstract structure of a loop which is implicitly defined is not clear to ChatGPT 3.
ChatGPT 4 works fine with one state available in branch working_with_chatgpt4 but fails with the current main branch with an JSONDecodeError.
ChatGPT 4o works fine with the latest changes - in particular the state in branch working_with_chatgpt4o. The interesting part is when it comes to the implicit loop ChatGPT 4 executes the steps (generate the crystal structure, equilibrate it and calculate the bulk modulus) for one element out of the nobel metals and then moves to the next, in contrast Chat GPT 4o first executes the first step of generating the crystal structure for all elements, then equilibrates all resulting structures and finally calculates the bulk modulus for all equilibrated structures.

The behaviour seems to be somewhat reproducible so I wanted to quickly summarise it here.

Different large language models can be tested by setting environment variables:
Antropic:
import os, getpass
os.environ["LANGSIM_PROVIDER"] = "anthropic"
os.environ["LANGSIM_API_KEY"] = os.environ['ANTHROPIC_API_KEY']
os.environ["LANGSIM_MODEL"] = "claude-3-5-sonnet-20240620"

OpenAPI:
import os, getpass
os.environ["LANGSIM_API_KEY"] = os.environ['OPENAI_API_KEY']
os.environ["LANGSIM_MODEL"] = "gpt-4o"

KISSKI:
import os, getpass
os.environ["LANGSIM_API_KEY"] = os.environ['KISSKI_API']
os.environ["LANGSIM_API_URL"] = "https://chat-ai.academiccloud.de/v1"
os.environ["LANGSIM_MODEL"] = "meta-llama-3-8b-instruct"

Hi there! I was looking at the llm.py code and I'm not sure the above mentioned way of changing the model can actually work.
Looking at the get_executor() it seems to me that the model is hard coded and set depending on the provider.

It is only hard coded for the case when it is None as far as I can see.

I see, right, I can specify a model in the executor. But, how can it read it from the env variable then?

ok, I think the answer to my question is in the magics.py ;-)

The benchmarking of LLMs is now also discussed in the developer section of the website.


Merge with devise-i18n-views

I'm currently a maintainer of devise-i18n-views gem. I would like to propose that the functionality of that gem be merged into devise-i18n. I've read the comment in #13, but I'd like to present my case.
The purpose of any gem (or software in general) is to be useful to users. The purpose of both devise-i18n and devise-i18n-views is to provide i18n for devise. The fact that some of this i18n is done simply with locale files and some requires views included isn't of much consequence to the gem users. In fact, having them separate causes confusion for users and requires both projects to tell people to use the other.
The same confusion arises for contributors to the gems (https://github.com/mcasimir/devise-i18n-views/pull/68 https://github.com/tigrish/devise-i18n/issues/92). These contributors will also either only contribute to one project, or need to keep track of two separate projects. Having them as one will mean an easier job for contributors and likely more complete translations.
Finally, having one project will make it easier for me and you (the maintainer of this gem). Having additional people to look at pull requests or sync from localeapp will make us more responsive.

I totally agree with you that a single I18n solution for devise would be best all round.
However, I have absolutely zero time at the moment to dedicate to this, is this something you would be willing to work on (more than happy to give you access to this repo)?

On 12 Oct 2015, at 21:48, Jason Barnabe<EMAIL_ADDRESS>wrote:
I'm currently a maintainer of devise-i18n-views gem. I would like to propose that the functionality of that gem be merged into devise-i18n. I've read the comment in #13 https://github.com/tigrish/devise-i18n/issues/13, but I'd like to present my case.
The purpose of any gem (or software in general) is to be useful to users. The purpose of both devise-i18n and devise-i18n-views is to provide i18n for devise. The fact that some of this i18n is done simply with locale files and some requires views included isn't of much consequence to the gem users. In fact, having them separate causes confusion for users and requires both projects to tell people to use the other.
The same confusion arises for contributors to the gems (mcasimir/devise-i18n-views#68 https://github.com/mcasimir/devise-i18n-views/pull/68 #92 https://github.com/tigrish/devise-i18n/issues/92). These contributors will also either only contribute to one project, or need to keep track of two separate projects. Having them as one will mean an easier job for contributors and likely more complete translations.
Finally, having one project will make it easier for me and you (the maintainer of this gem). Having additional people to look at pull requests or sync from localeapp will make us more responsive.
—
Reply to this email directly or view it on GitHub https://github.com/tigrish/devise-i18n/issues/131.

Yes, I'd be happy to work on it myself.


OpenCV acting up with two webcams

Per @trygentoo:

I can't switch from internal laptop webcam to external which is going to work as beamprofiler.
When I go to "Choose camera..." menu there only 2 options OpenCV and Dummy Gauss. Moreover app is stunned if OpenCV chosen after alert "No camera was detected. Did you forget to plug it in?"

Console output:
/usr/lib64/python2.7/site-packages/traits/trait_handlers.py:1599: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  if value in self.values:
/usr/lib64/python2.7/site-packages/chaco/image_data.py:190: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  self._data = newdata
/usr/lib64/python2.7/site-packages/chaco/array_data_source.py:123: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  self._data = newdata
/usr/lib64/python2.7/site-packages/chaco/axis.py:498: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  for tickpos in mapped_tick_positions]))
/usr/lib64/python2.7/site-packages/chaco/axis.py:499: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  self._tick_label_list = tick_list
/usr/lib64/python2.7/site-packages/chaco/axis.py:500: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  self._tick_label_positions = self._tick_positions
Exception occurred in traits notification handler.
Please check the log file for details.
Exception occurred in traits notification handler for object: <beams.MainWindow.MainWindow object at 0x7f7f3f317110>, trait: camera, old value: <beams.Webcam.Webcam object at 0x7f7f3f277290>, new value: <beams.Webcam.Webcam object at 0x7f7f3022e6b0>
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/traits/trait_notifiers.py", line 520, in _dispatch_change_event
    self.dispatch( handler, *args )
  File "/usr/lib64/python2.7/site-packages/traits/trait_notifiers.py", line 615, in dispatch
    handler( *args )
  File "/usr/lib64/python2.7/site-packages/traitsui/ui.py", line 824, in _evaluate_when
    self._do_evaluate_when(at_init=False)
  File "/usr/lib64/python2.7/site-packages/traitsui/ui.py", line 838, in _do_evaluate_when
    self._evaluate_condition(self._visible, 'visible', at_init)
  File "/usr/lib64/python2.7/site-packages/traitsui/ui.py", line 883, in _evaluate_condition
    context = self._get_context( self.context )
  File "/usr/lib64/python2.7/site-packages/traitsui/ui.py", line 804, in _get_context
    context2 = value.trait_get()
  File "/usr/lib64/python2.7/site-packages/traits/has_traits.py", line 1485, in trait_get
    value = getattr( self, name, Missing )
  File "build/bdist.linux-x86_64/egg/beams/Webcam.py", line 62, in _resolution_default
    width = cv.GetCaptureProperty(self._capture, FRAME_WIDTH)
TypeError: Expected CvCapture for argument 'capture'
libv4l2: error setting pixformat: Device or resource busy
HIGHGUI ERROR: libv4l unable to ioctl S_FMT
libv4l2: error setting pixformat: Device or resource busy
libv4l1: error setting pixformat: Device or resource busy
HIGHGUI ERROR: libv4l unable to ioctl VIDIOCSPICT

I don't currently have access to an external webcam to test this, so help is appreciated.

How can I help you?

That would be great if you could help! First thing is, could you try your beam profiler webcam on another computer with no internal webcam? Just to see if it works when it's the only webcam attached to the computer.
(I'm not sure I actually ever supported two webcams with the OpenCV plugin. If not, then I'll have to figure out how to do that.)

Hello,
sorry for large delay. Finally managed to run beams on another comp, the
result is the same: about 1 frame per minute and everything is very slow.
On Thu, Sep 3, 2015 at 7:26 PM P. F. Chimento<EMAIL_ADDRESS>wrote:

That would be great if you could help! First thing is, could you try your
beam profiler webcam on another computer with no internal webcam? Just to
see if it works when it's the only webcam attached to the computer.
(I'm not sure I actually ever supported two webcams with the OpenCV
plugin. If not, then I'll have to figure out how to do that.)
—
Reply to this email directly or view it on GitHub
https://github.com/ptomato/Beams/issues/5#issuecomment-137503061.

This computer only has 1 webcam in total?
Hmm, I don't know what to do next. Is there any chance you could do some experimenting and find out what is happening during the intervals between frames? For example, by adding some print statements in the ProcessingThread.py code.

I have added some code to allow selecting between two webcams when using OpenCV. Maybe that helps or fixes this?


Could not retrieve history for files in submodule

OS: Windows 10 64 bits
Atom: 1.8.0
git-history: 3.2.0
Hi! I'm having issues when trying to see history files inside submodules. The history works fine with the files of the root git repo, but no luck with the ones inside the submodules, as said.
Any clue?
Thanks in advance

Just in case.
I have two project folders in my workspace, but only the main one is a git project.
Git runs in cmd by just typing "git" (is in my env path).
Let me know if you need more information


[TS] breaking change in 0.11: ShadowRoot object is no longer assignable to second parameter of render() function

The web component example now fails in TypeScript in 0.11:
    !this.shadowRoot && this.attachShadow({mode: 'open'});
    this.dispose = render(this.render.bind(this), this.shadowRoot!); // ERROR

The error is:
Argument of type 'ShadowRoot' is not assignable to parameter of type 'HTMLElement'.
  Type 'ShadowRoot' is missing the following properties from type 'HTMLElement': accessKey, accessKeyLabel, autocapitalize, dir, and 177 more.

In version 0.10, the type of the second parameter was Node, which a shadowRoot is assignable to.

Nice find.. thanks I actually had to fix this for the Preact version of my Web Component library. I will get this fixed up tonight.

Just curious, is this released yet? Ran npm install solid-js last night on a new project and got the same error.

I see what MountableElement is trying to do. Node is not in that list, because it can't be mounted. It is more of an abstract base class.
Current MountableElement is Element | Document | ShadowRoot | DocumentFragment, but maybe that needs to be updated actually. Element is an abstract base class too. Maybe it should be HTMLDivElement | HTMLInputElement | ... | SVGSVGElement | ... | Document | ShadowRoot | DocumentFragment to captute only the actually-mountable elements.

Yeah I debated this. I just copied Preacts types here. I do think more general is probably better, but mostly since I don't care about type specificity that much. Although I'm not sure how much this would be hit. I have no issue adding this to the types when I'm in there next.

Made a PR: https://github.com/ryansolid/solid/pull/124


fix subtraction treated as binary operator

Receiving the following errors from jruby <IP_ADDRESS>.  Seems like an easy fix.  Passes cidr_test and methods_test after change.
/usr/local/bundle/gems/netaddr-1.5.1/lib/methods.rb:495: warning: `-' after local variable or literal is interpreted as binary operator
/usr/local/bundle/gems/netaddr-1.5.1/lib/methods.rb:495: warning: even though it seems like unary operator
/usr/local/bundle/gems/netaddr-1.5.1/lib/cidr.rb:814: warning: `-' after local variable or literal is interpreted as binary operator
/usr/local/bundle/gems/netaddr-1.5.1/lib/cidr.rb:814: warning: even though it seems like unary operator

I don't know why you chose to commit the changes yourself instead of using the PR I opened, but thank you for integrating these fixes:
https://github.com/dspinhirne/netaddr/commit/f96201629bf1ec8abfba2746abfa2a9327c10f3d#diff-87344b3b515c80ed29958b3e312be309R743
https://github.com/dspinhirne/netaddr/commit/f96201629bf1ec8abfba2746abfa2a9327c10f3d#diff-f1c3794bd22553637f873d30b53aa8d9R489


Dependency on rules_sass which doesn't work on windows

We can get a node-native implementation of the newest iteration of the sass compiler:
https://github.com/sass/dart-sass#from-npm
need to evaluate potential problems of this being different from C++ and/or google3

Current plan is to open-source the google-internal Sass rules, we should make sure to test on Windows as we go.
/cc @jelbourn

rules_sass now uses a JavaScript implementation so it should be cross-platform


OCPBUGS-19008: better compatibility with old hostnamectl

The old versions of hostnamectl don't have the "hostname" command,
parse the output of "status" instead.

/label backport-risk-assessed

/hold
Does not do what we expect: hostnamectl still fails.

/hold cancel

/retest

/test e2e-metal-ipi-serial-ipv4

/lgtm


Fixes for CI/CD compatibility

Changes: CI/CD

Avoid hardcoding RAPIDS Jar version for CI/CD. Instead, let pipeline download and store jar path in $RAPIDS_JAR environment variable, as specified in this PR. Allows us to pull the appropriate plugin version from Spark-RAPIDS.
Use unique (timestamped) paths for the TensorRT timing cache, in response to this bug, so that cached files can be properly cleaned up.

Bug Fixes:

Deleted duplicate image_classification notebook in Tensorflow

Markdown link checker is unhappy with tensorflow links for an unknown reason. Switching to use links to the Github source instead for now.


External plugin entry type IDs should be namespaced

It is probably enough to namespace as <plugin_name>::<raw_type_id>. This way, we minimize type ID conflicts.

Yeah. I assumed that was already done.

This requires a bit more thinking than I thought (to cleanly implement it), so going to unassign myself for now.


Optimize closed projections

If a closed projection is used, Spring Data modules can even optimize the query execution as we exactly know about all attributes that are needed to back the projection proxy.

This is Implements in Spring Data Cassandra?

@Sanjay-K-S this implements both Infinispan modes: embedded and remote, GAE standard, GAE remote (not yet 100%)


Unable to run flannel with remote etcd host

Hi,
I set up an etcd cluster in AWS with an autoscaling group that is known via route53. I am currently setting up a k8s master where the user-data looks as following:
#cloud-config
coreos:
  update:
    reboot-strategy: off
  flannel:
    interface: $private_ipv4
    etcd_endpoints: http://etcd.blablabla.com:2379
  units:
    - name: docker.service
      drop-ins:
        - name: 40-flannel.conf
          content: |
            [Unit]
            Requires=flanneld.service
            After=flanneld.service
    - name: flanneld.service
      drop-ins:
        - name: 10-flannel.conf
          content: |
            [Service]
            Environment="FLANNEL_VER=0.5.5"
            ExecStartPre=/usr/bin/etcdctl --peers=http://etcd.blablabla.com:2379 set /coreos.com/config/network '{"network": "<IP_ADDRESS>/16"}'

When the coreos vm starts, it pulls the rightt flannel version, sets the interface correctly but starts giving errors like this:
sdnotify-proxy[694]: E0729 10:48:38.032642 00001 network.go:53] Failed to retrieve network config: 100: Key not found (/coreos.com) [2]
When I look at the /run/flannel/options.env I see that the only environment variable is:
$ cat /run/flannel/options.env
FLANNELD_IFACE=<IP_ADDRESS>

So my etcd endpoint is not registered and flannel starts looking locally. I've googled this for hours and tried almost 50 times. I tried other flannel versions like the 0.2.0 and 0.5.1 as well. Does anybody know where this is coming from?

This is a CoreOS distro issue. Please file a bug in https://github.com/coreos/bugs


Versioned source action should fail when versionist fails

I got the following logs here - but the action passed. I think if versionist fails, the check should fail
Unhandled rejection Error: Command failed: versionist --config=versionist.tmp.cjs
No commits were annotated with a change type since version 0.1.0

    at ChildProcess.exithandler (node:child_process:400:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1093:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

I'm not sure I agree, I think there is a use case to merge commits with no change-type. Up for discussion though.

@klutchell would we check for a change-type at the PR level in that case? So it's okay if a single commit doesn't have the change-type - but the PR as a whole should have atleast 1 change-type.
Otherwise we'd have PRs that merge without updating the version of master - which is a problem as there won't be any releases for the latest HEAD of master

@klutchell This also breaks how we've done things with versionbot. So here we are also changing a default behavior that folks are probably used to.
I think it's not a good idea to have un-tagged changes in master, because when I say I am using v2.3.4 of something you'll know exactly what I mean. If we have commits on top of v2.3.4 it can be confusing. Someone might come to the repo and browse the source code - but they won't be looking at the release source code.
A project that I am working on would get quite confusing as the repo has only markdown files and nothing else. So folks normally just browse github when reading the docs.
I think if we are moving away from how versionbot did things we should atleast expose a flag which allows folks to do things the old way. What do you think?
Happy to create an arch call topic if this requires one as well


'get_post_id_from_thread_id' without using request

Description
This pull request updates the get_post_id_from_thread_id method in the codebase. The existing implementation is replaced with a new implementation that improves the efficiency and workflow of the code.
Changes Made

Replaced the existing code with a more optimized implementation.
Introduced a new alphabet variable containing characters used for encoding.
Implemented a loop to iterate through each character in thread_id and calculate the post_id using base64 encoding.

Reason for Changes
The new implementation improves the performance of the get_post_id_from_thread_id method by utilizing base64 encoding to convert the thread_id into a post_id. This eliminates the need for string manipulation and provides a more concise and efficient solution.
Testing Done
I have tested the updated method with various thread_id inputs and compared the results against the expected post ids. The tests have passed successfully, ensuring the correctness of the implementation.
Checklist

[x] Ran the existing test suite and ensured all tests pass.
[x] Performed manual testing to verify the correctness of the updated method.

Please review this pull request at your convenience. Your feedback and suggestions are greatly appreciated.
Thank you.

I hadn't got to really work on this Python client. I promise to sacrifice my weekend here, catching up changes in https://github.com/junhoyeo/threads-api and releasing new versions.


add weakcoasta to randbats

Add the "weakcoasta" set to randbats. These abilities give Carracoasta the potential to tank a super effective hit and be a dangerous +4 sweeper in just one turn.

I don't really know much about this file, so if @ascriptmaster could double check I did this right I would appreciate it.

The code itself is solid. As for whether or not it should actually be used, ask @TheImmortal

Not TI so I can't decide, but if there's a way to implement weakcosta always getting ajet then I'd think it's a welcome change. A big issue of costa is generally even at +2 there are things (at neutral!) that can revenge.

if ((ability === 'Solid Rock' && ability === 'Sturdy') && counter['priority'])

Well I'm not sold on this change completely. Sturdy requires team support (which would be possible to check after #1822) in the form of hazard removal. For now, I'd accept just Solid Rock.

I'd also be more comfortable with checking priority to lower the rate of Weakness Policy. So, ascripmaster's change minus Sturdy.

In that case should we remove the coin flip to decide on the item sense it's dependent on the priority move anyways?

yes basically

Alright updated.


Upgrade net.bytebuddy:byte-buddy 1.12.22 -> 1.12.23

This PR contains the following updates:

Package
Type
Update
Change

net.bytebuddy:byte-buddy
compile
patch
1.12.22 -> 1.12.23

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Byte Buddy 1.12.22 -> 1.12.23

See:
- https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.23
- https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.22...byte-buddy-1.12.23


PERF: Use numpy arrays in andrews_curves plots

Following on from discussion in #11534, this uses a list comprehension in the following function:
def function(amplitudes):
    def f(t):
        x1 = amplitudes[0]
        result = x1 / sqrt(2.0)
        harmonic = 1.0
        for x_even, x_odd in zip(amplitudes[1::2], amplitudes[2::2]):
            result += (x_even * np.sin(harmonic * t) +
                       x_odd * np.cos(harmonic * t))
            harmonic += 1.0
        if len(amplitudes) % 2 != 0:
            result += amplitudes[-1] * np.sin(harmonic * t)
        return result
    return f

As both amplitudes and t are numpy ndarrays, there is probably some performance gain to be had from vectorising the loop.
My numpy knowledge and available time aren't sufficient to make this entirely trivial. I came across the following issues in particular:

Basic slices of numpy ndarrays return views rather than copies, which then can't be subject to many numpy operations (i.e. np.resize).
Addressing amplitudes in the inner scope assigns the name in the inner scope (see here for details). This causes an amplitudes is not defined exception.

see if you can provide the proper input above, so one can simply copy-paste to test this.

As per further comments in #11534, I've had a go and posted timings.

Closed by #11534. Pls reopen otherwise.


Update Go to 1.22.3

Tool name
go
Tool license
https://github.com/golang/go/blob/master/LICENSE
Add or update?

[ ] Add
[X] Update

Desired version
1.22.3
Approximate size
No response
Brief description of tool
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Fixes GO-2024-2824
URL for tool's homepage
https://go.dev/
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[ ] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hey @jansepke! It will be updated automatically when package available in the source-repository. I've checked it for you and may say that the required update will be published with the next image rollout.


User-created Views

Is your feature request related to a problem? Please describe.
If I've worked with a diagram a decent amount, I learn decent ways of filtering that apply specifically to that diagram, so I know how to navigate it well, but it can be hard for others to navigate without this knowledge.
Describe the solution you'd like
Allow editors to select filter settings and create a view with those settings.

A view should be able to:

have a title and description so creators can explain its purpose/usage
be explicitly set as a default view for when people view the topic initially
be explicitly set as a recommended view so people know to that it might be a particularly useful view
be shared via URL

Also:

if a view is not default or recommended, only show it to the owner
allow other users to save their own views
probably don't need "recommended" distinguished, would be just "not default", implied has value to see
could add a checkbox when clicking "share view" for "create saved view with name: X"

when clicking "share" make sure a link shows up right away that can be clipboarded, but below that could be "share with this name: X" if you want to also set a name

Questions to answer

better name for this? "Saved Views"? Didn't want to just use "Recommended Views" because editors should be able to make convenience views to click between themselves, without being particularly recommended for others

"Favorite Views" could work too?

"Preset Views" vs "My Views"? Some way of visually conveying which ones other people will see (even if viewers can create their own)
Share view button next to edit/delete view?

Describe alternatives you've considered
Additional context
Technical ideas

Maybe also add a "share current view without saving" button? Which creates a view in the db with a short share URL, but doesn't show up in the saved views list

Also would be nice but not necessary off-the-bat: "include perspective" checkbox

Decided to not do the following, which are probably still useful but can be considered later because they aren't really MVP:

button to share current view
personal views
reordering quick views/explicitly setting a default


README.md practical.json example misses Book 2

Due to some unfortunate formatting on the homepage of A Practical Guide to Evil, the example from the README.md will only download books 1, 3, 4, and 5. This can be fixed by complicating the chapter selector somewhat, though there is probably a nicer way to go about it.
Current practical.json
{
    "url": "https://practicalguidetoevil.wordpress.com/table-of-contents/",
    "title": "A Practical Guide To Evil: Book 1",
    "author": "erraticerrata",
    "chapter_selector": "#main .entry-content > ul > li > a",
    "content_selector": "#main .entry-content",
    "filter_selector": ".sharedaddy, .wpcnt, style",
    "cover_url": "https://gitlab.com/Mikescher2/A-Practical-Guide-To-Evil-Lyx/raw/master/APGTE_1/APGTE_front.png"
}

Proposed practical.json
{
    "url": "https://practicalguidetoevil.wordpress.com/table-of-contents/",
    "title": "A Practical Guide To Evil",
    "author": "erraticerrata",
    "chapter_selector": "#main .entry-content > ul > li > ul > li > a, #main .entry-content > ul > li > a",
    "content_selector": "#main .entry-content",
    "filter_selector": ".sharedaddy, .wpcnt, style",
    "cover_url": "https://gitlab.com/Mikescher2/A-Practical-Guide-To-Evil-Lyx/raw/master/APGTE_1/APGTE_front.png"
}

@gustavAR Any idea how to get the extra chapters properly selected as well?

@gustavAR Any idea how to get the extra chapters properly selected as well?

Might be difficult since it is a separate table of contents. This json will grab the extra chapters only, and you can combine with the regular chapter epub in calibre or similar software relatively easily.
{ 	"url": "https://practicalguidetoevil.wordpress.com/extra-chapters/", 	"title": "A Practical Guide To Evil: Extra Chapters", 	"author": "erraticerrata", 	"chapter_selector": "#main .entry-content > ul:nth-of-type(1) > li > a", 	"content_selector": "#main .entry-content", 	"filter_selector": ".sharedaddy, .wpcnt, style" }

I altered the readme in 9c9877ed26fc441cb7d50cde2ca27f71994afbba in, admittedly, the opposite direction -- I made it actually download just book 1 like it said it would.
I also took the opportunity to update the practical guide JSON in the examples folder, to show how to mix in the extras chapters when they were published.
If what you want is the entire series in one file, including all the extras, you could do this:
{
    "url": "https://practicalguidetoevil.wordpress.com/2015/03/25/prologue/",
    "title": "A Practical Guide To Evil",
    "author": "erraticerrata",
    "content_selector": "#main .entry-wrapper",
    "content_title_selector": "h1.entry-title",
    "content_text_selector": ".entry-content",
    "filter_selector": ".sharedaddy, .wpcnt, style",
    "next_selector": "a[rel=\"next\"]"
}

I altered the readme in 9c9877e in, admittedly, the opposite direction -- I made it actually download just book 1 like it said it would.
I also took the opportunity to update the practical guide JSON in the examples folder, to show how to mix in the extras chapters when they were published.
If what you want is the entire series in one file, including all the extras, you could do this:
{
    "url": "https://practicalguidetoevil.wordpress.com/2015/03/25/prologue/",
    "title": "A Practical Guide To Evil",
    "author": "erraticerrata",
    "content_selector": "#main .entry-wrapper",
    "content_title_selector": "h1.entry-title",
    "content_text_selector": ".entry-content",
    "filter_selector": ".sharedaddy, .wpcnt, style",
    "next_selector": "a[rel=\"next\"]"
}

Thanks for this! This JSON did give an error for me. Removing       "content_title_selector": "h1.entry-title",  allowed it to run successfully, but doesn't grab chapter names (unsuprising since that is what it is meant to do). I will mess with it later and see if I can figure out solution.
error:
C:\Users\conno\Downloads\Recent\leech-master>py -3.7 leech.py practicals.json [sites] Handler: <class 'sites.arbitrary.Arbitrary'> (practicals.json) [__main__] Unable to locate leech.json. Continuing assuming it does not exist. [sites.arbitrary] Extracting chapter @ https://practicalguidetoevil.wordpress.com/2015/03/25/prologue/ Traceback (most recent call last):   File "leech.py", line 157, in <module>     cli()   File "C:\Users\conno\AppData\Local\Programs\Python\Python37\lib\site-packages\click\core.py", line 722, in __call__     return self.main(*args, **kwargs)   File "C:\Users\conno\AppData\Local\Programs\Python\Python37\lib\site-packages\click\core.py", line 697, in main     rv = self.invoke(ctx)   File "C:\Users\conno\AppData\Local\Programs\Python\Python37\lib\site-packages\click\core.py", line 1066, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "C:\Users\conno\AppData\Local\Programs\Python\Python37\lib\site-packages\click\core.py", line 895, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "C:\Users\conno\AppData\Local\Programs\Python\Python37\lib\site-packages\click\core.py", line 535, in invoke     return callback(*args, **kwargs)   File "leech.py", line 150, in download     story = open_story(site, url, session, login, options)   File "leech.py", line 101, in open_story     story = handler.extract(url)   File "C:\Users\conno\Downloads\Recent\leech-master\sites\arbitrary.py", line 80, in extract     for chapter in self._chapter(content_url, definition):   File "C:\Users\conno\Downloads\Recent\leech-master\sites\arbitrary.py", line 115, in _chapter     title = title[0].string TypeError: 'bool' object is not subscriptable

Thanks for this! This JSON did give an error for me. Removing "content_title_selector": "h1.entry-title", allowed it to run successfully, but doesn't grab chapter names (unsuprising since that is what it is meant to do). I will mess with it later and see if I can figure out solution.

In this case, I'm pretty sure it's just that you have an outdated checkout. 532a7c6682467e25d1e57c4182d6ae2e9c28cfc6 from mid-2019 fixed an error on that line so it's no longer title = title[0].string.

Thanks for this! This JSON did give an error for me. Removing "content_title_selector": "h1.entry-title", allowed it to run successfully, but doesn't grab chapter names (unsuprising since that is what it is meant to do). I will mess with it later and see if I can figure out solution.

In this case, I'm pretty sure it's just that you have an outdated checkout. 532a7c6 from mid-2019 fixed an error on that line so it's no longer title = title[0].string.

Oops yeah, that is probably the issue. I forgot that I have been using an older version because I couldn't get some of the newer updates to work due to some not finding the PIL module issues, even though py says pillow is installed. I think it is caused by issues on my end from having too many versions of python installed.
Thanks for the help!

I altered the readme in 9c9877e in, admittedly, the opposite direction -- I made it actually download just book 1 like it said it would.
I also took the opportunity to update the practical guide JSON in the examples folder, to show how to mix in the extras chapters when they were published.

So sorry to keep bothering you! After updating and solving the pillow thing above and getting the full book json you posted to work successfylly, I went and tried the new practical examples for single book jsons and have run into an issue.
  File "C:\leech-master\sites\arbitrary.py", line 85, in extract     next_link = soup.select(definition.next_selector)   File "C:\Python38\lib\site-packages\bs4\element.py", line 1527, in select     raise NotImplementedError( NotImplementedError: Only the following pseudo-classes are implemented: nth-of-type.
I get this NotImplementedError, which seems centered around the "not" modifier on this line
    "next_selector": "a[rel=\"next\"]:not([href*=\"prologue\"])",
I played around with it for a couple of hours to find a solution but was unsuccessful. If relevant, this is python38 and beautifulsoup 4.9.3.
Thanks for all the help/development, and I've been enjoying tinkering with the package almost as much as reading the books it produces!

This is because of an outdated BeautifulSoup dependency -- versions before 4.7.0 had a much less complete selector implementation. Update BeautifulSoup and it should all be good.

Hmm yeah, that was my thought but it said it was up to date at 4.9.3. Maybe I’ll try a clean install.

On Oct 18, 2020, at 11:52 AM, David Lynch<EMAIL_ADDRESS>wrote:

This is because of an outdated BeautifulSoup dependency -- versions before 4.7.0 had a much less complete selector implementation. Update BeautifulSoup and it should all be good.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

BeautifulSoup has a dependency on a package called soupsieve that actually handles the selectors, so it's possible it's just that which is outdated.

BeautifulSoup has a dependency on a package called soupsieve that actually handles the selectors, so it's possible it's just that which is outdated.

Got it working! Used a clean python3.9 install to was working as expected, so then went back to the python3.8 to try and troubleshoot why it wasn't working there. Apparently, I had "bs4" installed as bs4 version 4.6.3 but also had "beautifulsoup4" installed as beautifulsoup4 4.9.3. It said bs4 was fully up to date, so I just uninstalled it and it started working, I guess defaulting to beautifulsoup4.
Thanks for the help!


Commands are not working in discord to setup

The bot has correct permissions in the server and is not responding to the commands

Works fine for me. Make sure you are using the correct prefix (!) and there are no conflicts with other bots, as well as that you have the necessary permissions.

It does not work, no other bot has the same command so nothing is triggered

It does not work, no other bot has the same command so nothing is triggered

The bot is not being hosted by me anymore. If you check it's online status, it should appear offline. I might host it again in the future if need be.
The GitHub page is up only for developers interested in the code.
I tried it in 2-3 different servers and it worked just fine when self-hosting.
If you wish to use the BOT, set it up as your own for the time being.

Do you have advice on how to set up the bot as our own for someone who has never made a bot or done coding before? Thanks.

Do you have advice on how to set up the bot as our own for someone who has never made a bot or done coding before? Thanks.

Watch a tutorial. It will show you how to do basic stuff with code and set it up.
Then, fork the code and apply the set up part (such as discord tokens etc) to it.


Merge match results from multiple documents and organisations

Description
This PR adds a python file to merge all the matched files for each documents and each organisation together into one. It joins the merged outputs with the urls and the references information. Most of the file names etc are user inputted.
I find that some of the _predicted_reference_structures files don't read in without errors (so I add a 'try'). This happens on 4 occasions and the error is:

Type of change

[ ] :sparkles: New feature

How Has This Been Tested?
No testing has been done.

@nsorros I've made the changes in the 2 latest commits. There are 2 things I can think of that you might not like:

having seperate functions for merge_match_csvs and merge_predicted_csvs even though there are parts of them that do the same thing. I started to write these in one function, but then I thought it might be a bit confusing why we are only taking parts of the data for the case of the predicted_csv_name data.

try:
   pred_data = pd.read_csv(predicted_csv_name)
except:
   print('Read csv issue for file {}'.format(predicted_csv_name))

this is because for 4 of the predicted data files an error occured when I tried to read them:

I seem to always have read_csv problems 😒. I can show you the problematic files if you want. They are
dc1b4f8cb79f432a58490dc75866bee6_predicted_reference_structures.csv
6a45e70af3548671d48e2e5c57387176_predicted_reference_structures.csv
159d0387d70c84eed881c4635549569e_predicted_reference_structures.csv
be29f26af5ddde5ffdce2223447449d9_predicted_reference_structures.csv

@nsorros I addressed some of these things and it all runs as expected. Do you want to take a quick look at the latest commit or should I just merge?


Update: Create terrain from local tile package with new .tpkx format

This PR updates the Create terrain from local tile package sample to read the new .tpkx file format.
Details at: common-samples/issues/2255
This PR is part of the whole efforts of upgrading all .tpk tile package files to the new format.
Notes:

The new .tpkx file features the exact same extent of the original package
The new .tpkx file has 1 less level of detail for tiles, which reduced its size by ~30 MB
The original .tpk file on the portal is not removed, to ensure older releases of the sample viewer can still access this sample

Also inviting @TADraeseke to take a look.

@saratchandrakarumuri Please take a look and this sample should work exactly the same as before... 😄

According to @TADraeseke this might need to be reverted before U10 release. Will keep an eye on that.


getPlayListTracks, RetrofitError: 404 due to local MP3 files

Hi,
If somebody has local mp3 files in its playlist, the getPlayListTracks throws a 404 error due to the AlbumType = null.
would it be possible to ignore local mp3 files?
you can try this list.
thanks in advance
Alex
1121798449
10WUZITIe8MCurCTYMuzQf

I just ran this code:
spotify.getPlaylistTracks("1121798449", "10WUZITIe8MCurCTYMuzQf", new SpotifyCallback<Pager<PlaylistTrack>>() {
    @Override
    public void success(Pager<PlaylistTrack> playlistTrackPager, Response response) {
        Log.d(TAG, String.valueOf(playlistTrackPager.total));
    }

    @Override
    public void failure(SpotifyError error) {
        Log.e(TAG, error.getMessage());
    }
});

And got 200 in response. What is the error message you're getting?

Hi Kaaes, sorry it was my mistake. (swapped userid / playlistid)
everything works fine.
thank you
Alex


peer review

Strengths

The paper makes good use of comprehensive datasets, including air quality indices and mortality data. The preprocessing steps, such as the removal of outliers and conversion of variables, are well justified and crucial for the integrity of the analysis.

The application of a Bayesian analysis model is both sophisticated and aptly justified. The model setup is detailed, with clear explanations of the variables and the assumptions underlying the model. This complexity allows for a nuanced understanding of the data.

The graphical representations, particularly the plots illustrating mortality rates over time and the relationship between air quality indices and mortality rates, are well executed. They significantly enhance the reader's ability to grasp the findings at a glance.

The discussion section is thorough, covering several potential implications of the research, addressing limitations, and suggesting avenues for future research. This demonstrates the authors' deep engagement with the subject matter and their understanding of its broader context.

Areas for Improvement

The paper's title and subtitle are placeholders ("My title" and "My subtitle if needed"). A more descriptive title and subtitle could enhance the paper's discoverability and immediately convey the study's focus to the reader.

While the statistical models used are complex and well-justified, additional clarity on the choice of certain parameters (e.g., the priors in the Bayesian model) could further strengthen the paper. A more detailed rationale for these choices would aid in replicability and understanding.

Some of the visualizations come with minor warnings or notes (e.g., about the group aesthetic in geom_line()). Addressing these in the paper could refine the figures and prevent potential misinterpretations.

The paper mentions datasets (e.g., penguins and planes) that are not directly related to the main analysis or are not adequately explained within the text. Clarifying the relevance of these datasets or refining the focus to maintain consistency throughout the paper would be beneficial.

Thanks for pointing out the areas where we could improve. We tried ensuring that we covered all the issues and suggestion you provided.


Day 398

Good morning! Here's your coding interview problem for today.
This problem was asked by Amazon.
Given a linked list and an integer k, remove the k-th node from the end of the list and return the head of the list.
k is guaranteed to be smaller than the length of the list.
Do this in one pass.

Seems to be identical to day 26. https://github.com/vaskoz/dailycodingproblem-go/issues/61


Credit

my site is getting more people so could i add you in a credits section

go ahead, could you link to my page?


Missing encoder release compatible with parser 0.7

From @yanns in https://discord.com/channels/1022972389463687228/1117957327216201758/1163487327226712235, via https://github.com/apollographql/apollo-rs/issues/469#issuecomment-1764646902:

Another issue upgrading apollo-parser to 0.7.1 is the missing update for apollo-encoder:
error[E0277]: the trait bound `apollo_encoder::SchemaDefinition: From<apollo_parser::cst::SchemaDefinition>` is not satisfied
  --> src/feature_toggle/schema_transformation.rs:42:68
   |
42 |             Definition::SchemaDefinition(e) => pub_schema.schema(e.try_into()?),
   |                                                                    ^^^^^^^^ the trait `From<apollo_parser::cst::SchemaDefinition>` is not implemented for `apollo_encoder::SchemaDefinition`
   |
   = note: required for `apollo_parser::cst::SchemaDefinition` to implement `Into<apollo_encoder::SchemaDefinition>`
   = note: required for `apollo_encoder::SchemaDefinition` to implement `TryFrom<apollo_parser::cst::SchemaDefinition>`
   = note: required for `apollo_parser::cst::SchemaDefinition` to implement `TryInto<apollo_encoder::SchemaDefinition>`

@yanns there is now<EMAIL_ADDRESS>compatible with parser 0.7.x. Sorry about this publishing mishap!

awesome thanks!


go-demo-6 to 1.0.34

Promote go-demo-6 to version 1.0.34

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlossg: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
bdd53187156b2562fb66efa4aa75d6d0f1fd91e8
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@carlossg: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
bdd53187156b2562fb66efa4aa75d6d0f1fd91e8
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Feature: Clear worklog by date range

:tada: This issue has been resolved in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


About encode error

Fix below error.
'cp932' codec can't encode character '\xe8' in position 23: illegal multibyte sequence
'cp932' codec can't encode character '\u014d' in position 31: illegal multibyte sequence
'cp932' codec can't encode character '\xe1' in position 217: illegal multibyte sequence

Non-alphabetic words should not be selected for the question text.


Added parseHtml plugin

Added parseHtml plugin as suggested in #721
@75lb, This should add ability to process html files in jsdoc-to-markdown

Wow, this has been open for a while. Again, my apologies for not reviewing this sooner.
I'd prefer not to merge this into JSDoc for a couple of reasons:

Parsing HTML with regexes seems like a very fragile approach. I suspect there are a lot of corner cases that the proposed code doesn't handle.
The current test coverage isn't adequate given the complexity of the plugin. I think you would need a ridiculously large test suite to ensure that you could really handle any HTML.

I agree with you that using a real HTML parser would be a much better idea. However, JSDoc already has a fair number of dependencies, and I'm trying to avoid adding more. I'd rather not take a new dependency for a built-in plugin that most JSDoc users will never enable. For that reason, if you want to rewrite this to use a real HTML parser, I'd ask that you distribute the plugin separately from JSDoc.
Thanks for your understanding.


Use github for go modules

In order to share packages within different modules inside the project we need to use go modules that can be imported inside a module, which requires using fetch-able domains.
Now we can do import github.com/rakutentech/shibuya/shibuya/object_storage inside engines to share the same packages and configs.

Have you considered this approach?

However, if they are separate modules, i.e different physical paths and you still want to import local packages without publishing this remotely to github for example, you could achieve this by using replace directive.

https://stackoverflow.com/questions/52026284/accessing-local-packages-within-a-go-module-go-1-11

@iandyh For that we need the module to be in the same path, because Dockerfile cannot see context outside the folder it is in. So we will need some hacks to compile the engines. This is a cleaner approach in comparison.

@harpratap Ok. Could you do a release after merge?