Allow pre-/post-processing of arguments repr for logging. Fix #5

Internal class BoundParameter and function bind_args_kwargs
public pre_process_param and post_process_param for override
in subclass for special cases
*.pyi still python3.5+ (no 3.6 features used)

Related issue number
#5
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes

Pull Request Test Coverage Report for Build 337

70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 336:
0.0%

Covered Lines:
456

Relevant Lines:
456

💛  - Coveralls

Pull Request Test Coverage Report for Build 337

70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 336:
0.0%

Covered Lines:
456

Relevant Lines:
456

💛  - Coveralls

Pull Request Test Coverage Report for Build 337

70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 336:
0.0%

Covered Lines:
456

Relevant Lines:
456

💛  - Coveralls

Pull Request Test Coverage Report for Build 337

70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 336:
0.0%

Covered Lines:
456

Relevant Lines:
456

💛  - Coveralls


Update breaking change detection tool to iterate over multiple RPs

Breaking change detection script looks at first 3 files in a pull request to determine the Resource Provider(RP) and it builds only the projects under the discovered RP.  If a change spans across multiple RPs then breaking change tool does not run. This works for most of the scenarios. There are times where common code changes happen and that could cause breaking changes across multiple RPs. To address this scenario, breaking change detection script should iterate over all files in a Pull request instead of first 3 files and make a list of all the RPs that are being changed. Then it should run breaking change tool on all RPs in that list.

Is this still an issue?

@adrianhall this isn't implemented in the .NET SDK repository, and I think it would be beneficial to add it to CI for the data plane SDKs. For management plane, any breaking changes in the SDK should be caught at the swagger spec level, so the CI in that repository should be responsible for flagging any breaking changes in the API there. We currently have a static analysis in the PowerShell repository that's checking for breaking changes between versions of a module, so we could leverage that existing functionality to implement a tool to check breaking changes in new versions of data plane SDKs in this repository.

Thanks for the response!

I'm thinking we should open a new issue to track breaking change detection for the data plane and close this one if the original intent was satisfied. I'm going to do that.


OP-20624 : Mapping urls

https://devopsmx.atlassian.net/browse/OP-20624

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/dev-oesaona-4x/executions/details/01H43PACCWCWKZ8EGCHGFQCH45

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01H43PACCWXR22G29N4A46QQF9


Add angle aesthetic to points{}

https://nbviewer.org/github/JetBrains/lets-plot-kotlin/blob/master/docs/examples/jupyter-notebooks/f-4.7.3/geom_point_angle.ipynb

I don't really like the name angle. It's a symbol characteristic, not a layer


Fix:  TestRetryDelayNotElapsed flakiness

What does this PR do?
Fix TestRetryDelayNotElapsed flakiness
Motivation
the previous implementation was to agressive with only 1ms delay allowed.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
NA, this change is only an unit-test change
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

It is still not guaranteed to succeed but it should bring an improvement


check-format.pl: Prevent two minor types of false positives, extend doc and tests

This contains further minor improvements of util/check-format.pl:

Document how to run positive and negative self-tests
Extend exceptions for no SPC after trailing ; in for (...;)
Allow nested indentation of labels (not only at line position 1)

Nothing urgent.

BTW, there is still the related general issue #10725:
The coding style guideline document should be updated.

The two Travis CI failures are unrelated and will be fixed by #13022.

Merged - thanks @paulidale


Failed to pull image with 401 Unauthorized when deployed to AKS + Azure Container Registry

Describe the bug
After successful Django app CI build, not able to deploy to AKS cluster (ACR)
A clear and concise description of what the bug is.
To Reproduce
Deployed Devtron via helm in same AKS cluster
https://kubernetes.default.svc
using the default_cluster that came with it, or we are supposed to define a new 'Add cluster' with the output from
the command to provide the Server URL and Bearer token via?:
curl -O https://raw.githubusercontent.com/devtron-labs/utilities/main/kubeconfig-exporter/kubernetes_export_sa.sh && bash kubernetes_export_sa.sh cd-user devtroncd https://raw.githubusercontent.com/devtron-labs/utilities/main/kubeconfig-exporter/clusterrole.yaml
https://docs.devtron.ai/devtron/setup/global-configurations/cluster-and-environments
This is portion of the Deployment Template:
ingress:
  annotations:
    kubernetes.io/ingress.class: nginx
    nginx.ingress.kubernetes.io/force-ssl-redirect: "false"
    nginx.ingress.kubernetes.io/rewrite-target: /$2
    nginx.ingress.kubernetes.io/ssl-redirect: "false"
  className: ""
  enabled: true
  hosts:
    - host: ""
      pathType: ImplementationSpecific
      paths:
        - /arthur-app(/|$)(.*)
    - host: chart-example2.local
      pathType: ImplementationSpecific
      paths:
        - /example2
        - /example2/healthz
  labels: {}
  tls: []

From Devtron - App Details - Events:
Successfully assigned xxx-nonprod/xxxx-nonprod-58995fc6b8-2mbln to aks-agentpool-84246901-vmss000003
Pulling image "xxx.azurecr.io/xxxacr.azurecr.io:cb80f760-2-2"
Failed to pull imagxe "xxx.azurecr.io/xxxacr.azurecr.io:cb80f760-2-2": rpc error: code = Unknown desc = failed to pull and unpack image "xxx.azurecr.io/xxxacr.azurecr.io:cb80f760-2-2": failed to resolve reference "xxxr.azurecr.io/xxxacr.azurecr.io:cb80f760-2-2": failed to authorize: failed to fetch anonymous token: unexpected status: 401 Unauthorized
Error: ErrImagePull
Back-off pulling image "xxx.azurecr.io/xxxacr.azurecr.io:cb80f760-2-2"
Error: ImagePullBackOff

These are my roles:
az role assignment list --assignee $AZURE_CLIENT_ID -o table

Do we need to setup tls cert or is that done for us in Devtron?
Logs
Paste any relevant application logs here.

EDIT: I feel this is related to secret not setup? But not sure where Devtron is looking for that if kind:Secret was not defined?

Do you able to solve it? I'm facing this with ECR as well. Push to ECR succeeded. From the cd pipeline pod, i can see the ~/.docker/config.json with correct content (copied the content to local machine, and able to pull from ECR), but somehow failed with above error in deployment stage. I'm assuming the pipeline pod using the same pod for build stage and deployment, not sure where else need to debug.


Enables the support for SMAP VOD

This commit enables a new plugin for processing the VOD retrievals from SMAP.
Note that the plugin only supports the L2 SMAP data versions, as the L3
versions of the data only contain the MODIS VOD climatology.
Resolves #210

An example testcase is available at : /discover/nobackup/svkumar/LISF_testing/210 %

Eric, I inadvertently deleted the files in my directory. How do I checkout this feature branch only?
-S

Sujay,
On the bottom of this page: https://github.com/NASA-LIS/LISF/pull/212
You will see a sentence reading:
You can also open this in GitHub Desktop or view command line instructions.
Click on "command line instructions".
Step 1 shows the two commands to checkout this feature branch.
David

Hi Sujay:
Are you referring to your feature branch?  If so, run:
git clone https://github.com/sujayvkumar/LISF.git LISF.git
cd LISF.git
git checkout feature/SMAPvodLVT
And then run 'git branch' to confirm this branch is on the file system and ready for edits.

Actually, strike that.  I don't think my instructions are correct.

Thanks - I figured it out. Back in business

For future reference if you lose your local repository but have the branch on GitHub:
git clone https://github.com/sujayvkumar/LISF.git LISF.git  # Only gets master branch
cd LISF.git
git fetch origin feature/SMAPvodLVT  # Alerts local repo of remote feature branch
git checkout feature/SMAPvodLVT # Creates local branch that tracks remote branch
git branch # Prints out confirmation on what branch is checked out
After this, you can work, and just type 'git push' to push the local branch changes back to the remote repo on the existing branch.  (The instructions in the "Working with GitHub" document assumes the branch doesn't exist yet on GitHub, or that the local repo already is tracking the remote branch.)


Launching without ArcDPS?

Hi,
I use ArcDPS when I launch the game without Launchbuddy, but when I launch via LB it also starts Arc even though I HAVE NOT set up LB to use Arc. I think it does it only on the first account I launch via LB, but I am not 100% sure.
Can someone tell me how to launch via LB without also starting Arc?
The reason I am asking is because when LB launches Arc, my multibox experience is terrible and at least 1 account will freeze in the background. When I delete Arc and use LB, I can run 4 accounts without ever running into issues, but when I have Arc on I can run max 3 accounts and at least 1 will always freeze in the background.
My boyfriend has the same issue.
Any help is appreciated.

Im having the opposite issue. I want arc to launch with LB but it only seems to sometimes launch. and if I put it in injected software the game fails to launch at all.

Same issue here.. if i launch more than 2 accs the rest freeze and goes white.


docs(parser): add JSON string field extension example

Issue number: #1518
Summary
Changes

Please provide a summary of what's being changed

This PR adds a small tip to the parser documentation, highlighting how to override a string field containing Json.
User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[ ] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

View rendered docs/utilities/parser.md

@heitorlessa created two samples and referenced them in the docs, ready for another review


Address store-specific issues

This PR addresses store-specific issues:

app versioning in AndroidManifest
no background location access
link privacy policy from within app
use official app name from within app

@duffh can you commit info.plist fix?


pov: Test sorted edge list, not exact graph order

Given a tree that must be reparented on node x, the tests used to
ensure that the former parent of x comes after the former children
of x. But there's no reason this should be the case, since in trees we
don't particularly care about the ordering of the children. (There are
some specialised trees for which it is the case, but this is not one of
those trees)
By comparing the sorted edge list, we allow either ordering.
Tested by ensuring that the example solution passes (it puts former
parent before former children), and that it still passes when using the
opposite ordering (modify (children g) ++ [reparented] to instead be
reparented : children g.
Also tested to ensure that solutions that always return Nothing and Just (Graph x [])` return reasonable error messages.
Always return Nothing:
### Failure in: 0:3:reparenting singleton
pov_test.hs:71
expected: Just []
 but got: Nothing

Always return Just (Graph x []):
### Failure in: 0:4:reparenting flat
pov_test.hs:71
expected: Just [("root","a"),("root","b"),("root","c"),("x","root")]
 but got: Just []

Fixes #92

I prefer this over #107 by far.
Hold on though, need to add root check.


add new a action & modify terms

append new action and modify some terms

a PR is created https://github.com/microsoft/PowerPlatformConnectors/pull/3065


As I am configuring things I am wondering where I should store variables in server side blazor project

Could you provide guidance on how to store variables.
For example: I ended up putting a appsettings.json on the client side project and using IConfiguration and then just doing

   public class Startup
    {

        public IConfiguration Configuration { get; }
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

At startup.cs. But should I have put this on Server project. Should there be a "blazor way" to store configs?

The way I do it at the moment is through embedding the config to the ClientApp.dll using MSBuild. See #1152 for how I do the embedding and also how others have are doing it at the moment.

@jvelezc What you're doing is totally fine. ASP.NET Core's configuration system lets you combine config sources from multiple locations, so if you want to have some config files in your Blazor app project, that's the way to go.
@RyoukoKonpaku I think @jvelezc is asking about server-side apps, so embedding the resource isn't required.

Ah I see then yes it's not required since it's essentially a normal netcore app.

@jvelezc
I also try to use appsettings.json for a server-side Blazor app. I'm using the same code as you but I get an error:

MissingMethodException: No parameterless constructor defined for this object.

What could be missing?
Thanks
Sven


Add Brazilian Portuguese Translation

Please, add brazilian portuguese translation!

@fwestenberg please approve, it's just a translation! Only 5% of Brazilians understand English, it is very important to have the translation.


[$250]  LHN - Expense submitted offline doesn't appear in LHN.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:  N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Go offline
Click on the FAB > Enter a user you haven't previously chatted with > Select it
In the chat, click the plus button in the compose box
Submit an expense
Navigate back to the Inbox page and observe
Go online

Expected Result:
When submitting an expense offline, it should appear in the Inbox with 50% opacity. Upon going online, it should update to 100% opacity
Actual Result:
The expense does not appear in the LHN in the Inbox while offline and after going online
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/d7c5c6a5-a935-4a58-ba7a-07e07c5d9938
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833031002469120796
Upwork Job ID:<PHONE_NUMBER>469120796
Last Price Increase: 2024-09-09

@greg-schroeder  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Nex up is proposal review

Bump @mollfpr

You around @mollfpr?

Bump @mollfpr

Sorry for the delay 🙏
Reviewing now!

I can't reproduce the issue.
@dominictb Is it because notificationPreference is hidden in the report not show in the LHN?

Issue should be fixed in BE as well.

What's BE fix we should apply?

I am not sure - do you know @mollfpr? Or we can ask the team as a whole perhaps in Slack?

I'm afraid I don't have a clue either, but I think the correct one should be data from BE.

Currently, when creating a new conversation with a new email, the backend returns the notificationPreference as hidden (via report.participants.[accountID] data), but the frontend is setting it to always

@dominictb Does this mean that the preference got overridden on the FE? Could you still get the notification after the BE return hidden?

@dominictb are you still able to reproduce the issue?

What do you think of this @mollfpr ?

Bump @mollfpr

I'm going to close this as #vip-vsb is now paused and it doesn't really fit into #newdot-quality. Please reopen if you disagree.


doc: Provide better guidance around exception handling

I.e., inline with the responder, vs. with a custom error handler. Relevant transcript from Gitter:
Q.

Hey, all. We have a lot of code like this in our resources:

    def on_post(self, req, resp):

        try:
            ...

            resp.status = falcon.HTTP_200
            resp.body = result_json

        except Exception as e:
            resp.status = falcon.HTTP_500
            resp.body = e.message

Is there a better way to write resources so I don't have to try/rescue? Is there a more canonical way to write resources? Looking for some notes on this.

A.

If you have well-defined exception classes, one alternative would be to use a custom error handler to catch those classes and render them to an appropriate response (see also: http://falcon.readthedocs.io/en/stable/api/api.html#falcon.API.add_error_handler). You can also derive custom classes from falcon.HTTPError or falcon.HTTPStatus, but that may not give you as clean a separation between internal logic and presentation.

R.

The docs leave me wondering how it can be used in practice...I mean, I get it b/c I'm a dev, but docs seem to be lacking. I glanced right over this.

I ran into a similar problem; it's a bit tricky to give very general guidance, because it depends on how you want errors to be returned. We ended up adding a custom error serializer to address this:
def analyte_error_serializer(req, resp, exception):
    error_msg = exception.description if exception.description else exception.title
    resp.media = {'data': None, 'error': error_msg}

api.set_error_serializer(analyte_error_serializer)

Now, this approach works as long as you're using a media handler. If you wanted to be a bit more generic, you could use something like:
def analyte_error_serializer(req, resp, exception):
    error_msg = str(exception)
    resp.media = {'data': None, 'error': error_msg}

Oh, I forgot to mention that status is already set by the default error handler(s).

No reason that a serializer couldn't set the status, though, now that I think about it.

I would like to work on this issue.

Posted on another duplicate issue: https://gist.github.com/vytas7/068ac5bd8a0fd118052d32e30be67792


Enable tests that were missed when binary support was extended

Just turning on a few tests in cast.

build

I am seeing some related test failures: Cast from string to int using hand-picked values
13:36:28  22/09/23 18:36:28.062 Executor task launch worker for task 0.0 in stage 49.0 (TID 65) ERROR Executor: Exception in task 0.0 in stage 49.0 (TID 65)
13:36:28  org.apache.spark.SparkNumberFormatException: The value '-.2' of the type "STRING" cannot be cast to "INT" because it is malformed. Correct the value as per the syntax, or change its target type. Use `try_cast` to tolerate malformed input and return NULL instead. If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error.
13:36:28  	at org.apache.spark.sql.errors.QueryExecutionErrors$.invalidInputInCastToNumberError(QueryExecutionErrors.scala:150) ~[spark-catalyst_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.catalyst.util.UTF8StringUtils$.withException(UTF8StringUtils.scala:46) ~[spark-catalyst_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.catalyst.util.UTF8StringUtils$.toIntExact(UTF8StringUtils.scala:33) ~[spark-catalyst_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.catalyst.util.UTF8StringUtils.toIntExact(UTF8StringUtils.scala) ~[spark-catalyst_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source) ~[?:?]
13:36:28  	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43) ~[spark-sql_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:760) ~[spark-sql_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:364) ~[spark-sql_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:890) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:890) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:365) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.rdd.RDD.iterator(RDD.scala:329) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.scheduler.Task.run(Task.scala:136) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551) ~[spark-core_2.12-3.3.0.jar:3.3.0]
13:36:28  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_342]
13:36:28  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_342]
13:36:28  	at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_342]

Where are you seeing this? The build failed with an error about note being able to download a file.
[2022-09-23T18:36:19.615Z] [ERROR] .../prepare-ui-libraries.xml:41: Can't get https://github.com/twbs/bootstrap/releases/download/v4.6.1/bootstrap-4.6.1-dist.zip to .../target/spark311/ui-dependencies-cache/bootstrap.zip

I didn't touch anything related to those failures. What is more those are failing on the CPU, not even the GPU yet.

build

@abellina could you please take another look?


[POC] Proxy mode: Read ABAP URI configuration from projects

See https://github.com/SAP/ui5-server/pull/223

Coverage decreased (-0.9%) to 85.438% when pulling 5d09696db18028c28b109e690cd422314debb4e3 on feature-proxy into 04eb695fd493ce9bd1289933d5494178c1e679d7 on master.


Common Diffusion Noise Schedules and Sample Steps are Flawed

https://arxiv.org/abs/2305.08891
I think these might be helpful

I've been experimenting with a model trained on v-prediction with zero terminal SNR, including with K-diffusion samplers.  I've also applied the modification to the DDIM sampler under LDM and tested it out and it works as described -- being able to produce a solid black image with a dark subject.  Not applying the zero terminal SNR beta rescale does still produce results close to this -- far closer than anything achieved while the model was being trained on epsilon loss with zero terminal SNR -- but does not quite achieve the solid black background.  So as far as what would need to be done on K-diffusion's end to bring it up to this capability, including information on my experiences experimenting with these so it can be known what these should be expected to do (going off the paper's suggestions in order):

Enforce Zero Terminal SNR -- This is likely to be the most difficult one.  The noise schedule would have to be rescaled to enforce zero SNR at inference.  I do not know enough about how K-diffusion determines its noise schedule to fix this or to know if it is possible without significant rewrites, and the lack of availability of model checkpoints trained on zero terminal SNR with v-loss that could be used to properly test this does not help either (I know someone who will start training a 1.5 model on V-loss with terminal SNR soon, and that checkpoint will be made available).  Based on my testing this is necessary to get the most out of the model.
Train with V Prediction and V Loss -- It should be noted that any model trained on epsilon loss will either produce a solid black image or throw a tensor full of NaNs when inference is attempted under a noise schedule that enforces zero terminal SNR.  The other suggestions in the paper can have visible benefits even on epsilon loss, but zero SNR noise schedules might as well be disabled forcibly if not running on V-parameterization.  I will note that in practice terminal snr trained on epsilon loss still performs quite well, about as well as offset noise but with more consistency, but V-parameterization is necessary for it to work "as advertised".
Sample from the Last Timestep -- K-diffusion already appears to do this, using a linspace sample step selection.  The authors of the paper, testing the DDIM sampler, found very little difference between linspace and trailing steps on common step counts like 25, but found that trailing sample step selection was noticeably better on smaller step counts like 5, which presumably would translate upwards.  Testing should be done to see if this is the case with K-diffusion samplers as well for the sake of thoroughness, but overall expectations should be if anything a very minor increase in visual fidelity that is imperceptible during normal use.
Rescale Classifier-Free Guidance -- I have experimented with someone's implementation of this on K-diffusion and compared it to the implementation in Diffusers which is DDIM only.  They operate nothing alike, and both in turn look nothing like the results shown in the paper, and because of that I suspect that one or both of the implementations is wrong -- the implementation I played with for K-diffusion heavily desaturates images, and the Diffusers implementation makes no significant difference in 1.5 (if anything a lot of the test images looked worse with the recommended rescale of 0.7 phi), and in 2.1 it slightly desaturated images and gave some increase in visual fidelity.  The authors unfortunately do not provide code for this.

I would love to see K-diffusion support this fully. Zero terminal SNR models are incredibly capable.


Added new translations to Spanish and Spanish (Argentina)

Problem
Added more texts to Spanish and Spanish (Argentina) translation files.
Solution
N/A
Acceptance Criteria
N/A

Thank you for submitting.  Feel free to add your name to AUTHORS

Thank you! Do I need to create another pull request to do that o I can just edit this one? I'm new to pull requests 😅

No need for new pull request - you can edit your copy of AUTHORS, commit and then push, that will create a new commit in the PR.  Or you can just edit AUTHORS directly via the Github console.

Thank you!

Coverage: 100.0%. Remained the same when pulling 42e856d86f2b84e92b34012dca2ebefc3b5b04fc on smunoz-ml:add_spanish_translations into 396a4c97cfb2b0bff57d75f27907958a5621344b on django-import-export:main.

Coverage: 100.0%. Remained the same when pulling 42e856d86f2b84e92b34012dca2ebefc3b5b04fc on smunoz-ml:add_spanish_translations into 396a4c97cfb2b0bff57d75f27907958a5621344b on django-import-export:main.


Add setPrecisionAndScale

Precision and scale usually used together. Add setter to set both parameters at once, so they look like in SQL datatype DECIMAL(11, 3). This also helps prevent from mixing precision and scale.

Do you mis adding the missing comments?

Whole file is missing parameter descriptions.
I've added descriptions.

@garas since I personally find confusing f what part is the scale and what is the precision, could you include a short example in the method description showing which is which using the DECIMAL(10,3) example?

Thanks!


Management of the Linkage Section and GETMAIN CICS

Hi,
I did not find in the documentation any information on the management of areas in Linkage Section and the processing of CICS GETMAIN / FREEMAIN instructions.
To test a classic subprogram which receives its parameters in Linkage Section, it is necessary to be able to feed these zones in a test, and it is therefore necessary that these zones point to an allocated memory. In the absence of a calling program, this must be the tool that allows the necessary memory to be allocated to the areas declared in the Linkage Section, (allocate memory, set address of area to the allocated memory).
Note that there can also be zones declared in Linkage Section which are not parameters received, but which are used by the program to map other zones, (SET ADDRESS OF linkage-area TO ...).
To test a CICS program in batch, it is necessary to mock the CICS commands, and in particular those which manipulate the memory: GETMAIN, FREEMAIN, and probably other commands like READQ SET POINTER.
In this case, the tool must also allow memory blocks to be allocated and Linkage Section zones to be associated with these memory blocks.

Hello,
(1) The proof of concept for this project supported subprograms by having the user write a trivial main driver. Examples for the general case of subprograms are here https://github.com/neopragma/cobol-unit-test/blob/master/src/main/cobol/SUBPROG.CBL and here https://github.com/neopragma/cobol-unit-test/blob/master/src/main/cobol/SUBPROGD.CBL. Examples for CICS programs are here https://github.com/neopragma/cobol-unit-test/blob/master/src/main/cobol/CICSDEMO.CBL and here https://github.com/neopragma/cobol-unit-test/blob/master/src/main/cobol/CICSDRIV.CBL.
Please bear in mind we have not yet built that functionality in the new code base. I'm providing the references so you can see our approach.
(2) The team have not discussed the question of SET ADDRESS OF and similar. It is worth considering. Thanks for mentioning it.
(3) The approach for CICS will be similar to what was done in the proof of concept. In particular, we will not emulate CICS commands. We are not trying to write a CICS emulator. So we will not write an equivalent to EXEC CICS GETMAIN, for instance. The intent is for Cobol Check to run independently of CICS. So, all CICS commands will be stubbed by default, automatically. Users can (I should say, will be able to, because we haven't written this yet) create mocks for those commands per the needs of their test cases.
If you actually need a CICS emulator to run under Windows or Linux, you might take a look at this project: http://www.z390.org/.
As Cobol Check is meant for fine-grained unit testing at the level of individual paragraphs, we do not foresee a need to allocate and deallocate memory blocks. But I would need to consult my team mates about an approach to this. We might just move the Linkage Section declarations of those areas into Working Storage, as we currently do to stub batch I/O operations - we move record layout areas defined under an FD into Working Storage for purposes of running the tests.
See method processFileControlSource() in https://github.com/openmainframeproject/cobol-check/blob/main/src/main/java/com/neopragma/cobolcheck/Generator.java to see how we're currently doing that. Bear in mind that section of the code is presently being vigorously refactored to clean up the long if/else blocks. But you can see how we're handling memory areas that aren't allocated in the case of batch I/O. A similar approach could work for dynamically-allocated storage areas, too.

We have noticed a lot of people have a different concept of the scope of a unit test than we have. Our concept of a unit test is based on Michael Feathers' definition, summarized here: https://github.com/openmainframeproject/cobol-check/wiki/What-is-a-Unit-Test%3F
Sometimes the functionality people describe or request belongs at a higher level of abstraction than unit testing. The purpose of Cobol Check is to support unit testing only. We have a page on the wiki to describe alternatives to unit testing tools for testing at higher levels: https://github.com/openmainframeproject/cobol-check/wiki/Component-and-Integration-Testing.
Thanks very much for your interest!


[SP-3678][PDI-16352] Merge Rows Diff check row layout

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/mergerows/MergeRows.java
  engine/src/org/pentaho/di/trans/steps/mergerows/MergeRowsMeta.java
  engine/src/org/pentaho/di/trans/steps/mergerows/messages/messages_en_US.properties
  engine/test-src/org/pentaho/di/trans/steps/mergerows/MergeRowsMetaCheckTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.01%:small_red_triangle_down:
Complexity Change: -1.06%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -.53%:small_red_triangle_down:
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.trans.step.BaseStep

Branch Change:  + 1.17%
Complexity Change:  + .71%
Instruction Change:  + 2.11%
Line Change:  + .98%
Method Change:  + .47%

org.pentaho.di.trans.step.StepMeta

Branch Change:  + .68%
Complexity Change:  + .58%
Instruction Change:  + .19%
Line Change:  + .26%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -.31%:small_red_triangle_down:
Instruction Change: -.06%:small_red_triangle_down:
Line Change:  + .23%
Method Change:  + 1.02%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%
Instruction Change:  + .14%
Line Change:  + .37%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.mergerows.MergeRows

Branch Change:  + 3.45%
Complexity Change:  + 5.88%
Instruction Change:  + 1.75%
Line Change:  + 3.81%
Method Change:  + 40.00%

org.pentaho.di.trans.steps.mergerows.MergeRowsMeta

Branch Change:  + 7.18%
Complexity Change:  + .69%
Instruction Change:  + 5.74%
Line Change:  + 8.27%
Method Change:  + 3.85%

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change: -.88%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.33%:small_red_triangle_down:
Complexity Change: -1.85%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

@stepanovdg please take a look


Trait assignment error report has incorrect header

Upon assigning EFOs or reported traits to studies,  a downloadable report is generated. This report has “accession” as a column header where it should read “study tag”.

tested and confirmed: column header has been correctly changed to "Study Tag" and contains the expected study tag data


Added a check for command enabled

Thought this might be handy for some people i might also add a disable/enable command

Thank you for taking time to write the code and submit this PR, how ever we won't be accepting it at this time as the system planned for enabling and disabling the commands hasn't been implemented and therefore the enabled check is not required at the moment.


Feature Request: Touchbar icon

Is there any way you could make it where the icon in the touchbar changes (not the color) like in the menu-bar? It's a little distracting when its on mute with a glowing red button. Great project though regardless.

I'd like to see Use alternate menu bar icons changed to Use alternate icons, with this selected the touch bar will use a slash through the microphone to indicate it's muted rather than a red background - just as the menu bar does.

How about a customizable background color on the icon in the touchbar for both "hot mic" and "muted" states?
That way, for instance, "mute" could be a grey color, and "hot" could have a red color, to give a feeling of the old "on air" light?
Even customizable images in the Touch Bar would be great, if Apple allows that to be easily done. I can imagine red background with "ON AIR" when my mic is hot, and the whole thing dimming out when it's muted.

We are happy to announce that we released the new version of the app which currently we distribute as a separate application https://mutify.app/

You can try it for free with 7-days trial and get 50% discount with promo code: MUTEME
However, the existing opensource version will stay forever free.

@lnikell I'm happy to pay for Mutify as long as there is still a public issue tracker, is this the case?

@strafe we created a new repo for gathering public feedback, issues and feature requests https://github.com/pixel-point/mutify
Thank you for the idea. We will publish the link on the website to it as well soon.

@lnikell thanks! Enjoying the app for the most part so far, I submitted a cask too.

@jonliu03 I voluntarily maintain this repository here: https://github.com/ImBIOS/mute-me


Run error , when updated the flutter latest code

[+14823 ms] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/collection/multimap.dart:413:5: Error: The method '_WrappedIterable::singleWhere' has fewer named arguments than those of overridden method 'Iterable::singleWhere'.
[   +2 ms] compiler message:   V singleWhere(bool test(V element)) {
[        ] compiler message:     ^
[        ] compiler message: file:///b/build/slave/Linux_Engine/build/src/third_party/dart/sdk/lib/core/iterable.dart: Context: This is the overriden method ('singleWhere').
[        ] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/collection/delegates/iterable.dart:71:5: Error: The method 'DelegatingIterable::singleWhere' has fewer named arguments than those of overridden method 'Iterable::singleWhere'.
[        ] compiler message:   E singleWhere(bool test(E element)) => delegate.singleWhere(test);
[        ] compiler message:     ^
[        ] compiler message: file:///b/build/slave/Linux_Engine/build/src/third_party/dart/sdk/lib/core/iterable.dart: Context: This is the overriden method ('singleWhere').
[+5997 ms] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/iterables/merge.dart:28:42: Error: The static method has type '(dart.core::Comparable<dynamic>, dart.core::Comparable<dynamic>) → dart.core::int' that isn't of expected type '(dynamic, dynamic) → dart.core::int'.
[  +12 ms] compiler message: Change the type of the method or the context in which it is used.
[        ] compiler message:         [Comparator compare = Comparable.compare]) =>
[        ] compiler message:                                          ^
[        ] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/iterables/min_max.dart:23:58: Error: The static method has type '(dart.core::Comparable<dynamic>, dart.core::Comparable<dynamic>) → dart.core::int' that isn't of expected type '(dynamic, dynamic) → dart.core::int'.
[        ] compiler message: Change the type of the method or the context in which it is used.
[        ] compiler message: dynamic max(Iterable i, [Comparator compare = Comparable.compare]) =>
[        ] compiler message:                                                          ^
[  +32 ms] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/iterables/min_max.dart:32:58: Error: The static method has type '(dart.core::Comparable<dynamic>, dart.core::Comparable<dynamic>) → dart.core::int' that isn't of expected type '(dynamic, dynamic) → dart.core::int'.
[        ] compiler message: Change the type of the method or the context in which it is used.
[        ] compiler message: dynamic min(Iterable i, [Comparator compare = Comparable.compare]) =>
[        ] compiler message:                                                          ^
[        ] compiler message: file:///Users/xxx/.pub-cache/hosted/pub.dartlang.org/quiver-0.25.0/lib/src/iterables/min_max.dart:46:60: Error: The static method has type '(dart.core::Comparable<dynamic>, dart.core::Comparable<dynamic>) → dart.core::int' that isn't of expected type '(dynamic, dynamic) → dart.core::int'.
[        ] compiler message: Change the type of the method or the context in which it is used.
[        ] compiler message: Extent extent(Iterable i, [Comparator compare = Comparable.compare]) {
[        ] compiler message:

I think you have an outdated async dependency
Try flutter update-packages --force-upgrade


Update index.html

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

<EMAIL_ADDRESS>

[x]  Have you followed the contributing guidelines?
[x]  Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Ttavion


chore: bump ckb related crates version to 0.105

What this PR does / why we need it:
Update ckb related crates version to 0.105. There are some notes:

The ckb nodes should update to 0.105
The ckb-sdk crate has not adapted yet

This PR
Which issue(s) this PR fixes:

Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description

CI Name
Description

Chaos CI
Test the liveness and robustness of Axon under terrible network condition

Cargo Clippy
Run cargo clippy --all --all-targets --all-features

Coverage Test
Get the unit test coverage report

E2E Test
Run end-to-end test to check interfaces

Code Format
Run cargo +nightly fmt --all -- --check and cargo sort -gwc

Web3 Compatible Test
Test the Web3 compatibility of Axon

v3 Core Test
Run the compatibility tests provided by Uniswap V3

OCT 1-5 | 6-10 | 11 | 12-15 | 16-19
Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

[ ] Chaos CI
[x] Cargo Clippy
[ ] Coverage Test
[ ] E2E Tests
[ ] Code Format
[x] Unit Tests
[x] Web3 Compatible Tests
[ ] OCT 1-5 And 12-15
[ ] OCT 6-10
[ ] OCT 11
[ ] OCT 16-19
[x] v3 Core Tests

/run-ci


Fix bug in ca-certificates-mozilla when installing sources - cherry pick from spack

Is your feature request related to a problem? Please describe.
The issue is described in https://github.com/spack/spack/issues/32948, the bug fix PR is
https://github.com/spack/spack/pull/32953.
Describe the solution you'd like
Once this is merged, cherry-pick the commit so that we can use spack install --source in our fork.

Closed via https://github.com/NOAA-EMC/spack/pull/182


Fix HttpData multiread when  aggregator is in the pipeline

Fixes #1309

Codecov Report

Merging #1350 (97994db) into main (64d48a9) will increase coverage by 0.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   60.76%   61.35%   +0.58%
==========================================
  Files          71       71
  Lines        2480     2510      +30
  Branches       85       88       +3
==========================================
+ Hits         1507     1540      +33
+ Misses        973      970       -3

Impacted Files
Coverage Δ

.../src/main/scala/zhttp/http/HttpDataExtension.scala
90.00% <100.00%> (ø)

zio-http/src/main/scala/zhttp/http/Response.scala
83.09% <0.00%> (+1.40%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/Headers.scala
89.28% <0.00%> (+2.92%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/URL.scala
88.29% <0.00%> (+4.01%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/Patch.scala
42.85% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d48a9...97994db. Read the comment docs.

This is fixed in #1351


ZEVA - Bug - Credit Agreements page idir

Describe the Bug
The status box is displaying the current login idir user name and not saving the transaction user Fname Lname.
The comment feature to the director does not have the edit feature.
Private Zenhub Image
Private Zenhub Image
Expected Behaviour
The status box should record and display the user first and last name along with the date/time stamp as per normal.
the comment should be able to be edited
Actual Behaviour
Status shows the user name of whoever is currently logged in.
Analyst cannot edit a comment to director
Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: idir\analyst

Go to Credit Agreement page
Click on New Transaction button
Fill in details and Save transaction
Add comment to director
See user name in status and missing edit function on comment

Please add your planning poker estimate with Zenhub @tim738745


[neon-image]: node image build is failing

Node image build is failing due to the Kubernetes team relocating the k8s.gcr.io container registry to registry.k8s.io.

FIXED


Added my name to the Contributors list at line 2855

Hi  @MrGMan133, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Allows DateType to be more easily extended.

Uses late static binding to allow DateType to be extended without the need to duplicate methods unnecessarily.
In my application, I want to use nesbot/carbon in place of DateTime objects with all of my dates on the PHP side of things. I wanted this change to be universal, so rather than implementing a totally new custom type, I chose to override the original date type.
In doing so, I found that the DateType makes too many references to itself, both via self:: and through the output of __CLASS__ when generating the hydrator, making extension difficult. With the proposed changes, my extension remains extremely tidy:
use Carbon\Carbon;
use Doctrine\ODM\MongoDB\Types\DateType;

class CarbonDateType extends DateType
{
    public static function getDateTime($value)
    {
        return Carbon::instance(parent::getDateTime($value));
    }
}

DateTypeTest passes all assertions, only skipping 32 or 64 bit respectively. I ran into a lot of other errors running PHPUnit as a whole, looking into those further to determine if that's on my end or what, so I apologize if I missed a related test that happens to fail.
If I can improve this pull request in any way, please let me know! Congratulations on your 1.0 release recently. :beers:

Whoops, I failed to check for minimum PHP version requirements on the ODM, and used the ::class syntax which is >= 5.5. Replaced with get_class($this). I originally benchmarked the two and saw that static::class was faster, for what it's worth.

Merged manually in https://github.com/doctrine/mongodb-odm/commit/d1054ff1bb5a08c140820cedb16af56904102084 - thanks @cryode!


Update the ParquetCachedBatchSerializer to reflect the changes made to the VectorizedColumnReader

As part of the SPARK-34859 change. The VectorizedColumnReader now takes more parameters than previously.

this was already fixed in the 320 shim.


Black screen on iOS

Hi there!
I'm having a trouble with some videos only on iOS (on simulator and real devices) when I run the app sometimes I can watch a black screen but the audio is ok.

I think this error happens when the video has the property Rotation != 0 in its metadata because all videos with this error have the same property

Steps to Reproduce
This is a sample code for reproduce it

import 'package:video_player/video_player.dart';
import 'package:flutter/material.dart';

void main() => runApp(VideoApp());

class VideoApp extends StatefulWidget {
  @override
  _VideoAppState createState() => _VideoAppState();
}

class _VideoAppState extends State<VideoApp> {
  late VideoPlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.network(
        'https://api.twilio.com/2010-04-01/Accounts/AC76fb458b55e79b1b8bd708a97ecb402b/Messages/MM340b85cb76dd1b2efb9098e7cdccde79/Media/ME907cb230497a03957c5dcee5afbefc54')
      ..initialize().then((_) {
        setState(() {});
      });
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Video Demo',
      home: Scaffold(
        body: Center(
          child: _controller.value.isInitialized
              ? AspectRatio(
                  aspectRatio: _controller.value.aspectRatio,
                  child: VideoPlayer(_controller),
                )
              : Container(),
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
          ),
        ),
      ),
    );
  }

  @override
  void dispose() {
    super.dispose();
    _controller.dispose();
  }
}

And this is flutter --version
Flutter 2.10.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 097d3313d8 (12 days ago) • 2022-02-18 19:33:08 -0600
Engine • revision a83ed0e5e3
Tools • Dart 2.16.1 • DevTools 2.9.2

This is an example video with the property Rotation = 90
https://user-images.githubusercontent.com/6619953/156464792-928fc1f6-d9fd-4bc7-a846-501f084cc8c5.mp4

@lzamudio
I believe you are hitting https://github.com/flutter/flutter/issues/70261, so please follow-up in it for further updates.
Closing this as a duplicate.


The ImageView's ScaleType has been changed since attaching a PhotoViewAttacher

java.lang.IllegalStateException: The ImageView's ScaleType has been changed since attaching a PhotoViewAttacher

This has become a really annoying problem in Fragments. It appears to be caused by shared element transitions on Lollipop, the OS's scaling transition animation must change the scale type.

I have found the same problem.Do you have solved it?

call the PhotoViewAttacher.cleanup before u calling onBackPressed or ondestory

There is another case that trigger this bug without make the ImageView inside a Fragment. We just need to remove all scale animations from Developer Options

+1 Encountering the same issue here.

I also encountered this on version 1.3.1 and I used the same workaround as with the ViewPager.
I created the following class:
public class MyPhotoViewAttacher extends PhotoViewAttacher {

    public MyPhotoViewAttacher(ImageView imageView) {
        super(imageView);
    }

    public MyPhotoViewAttacher(ImageView imageView, boolean zoomable) {
        super(imageView, zoomable);
    }

    @Override
    public void onGlobalLayout() {
        try {
            super.onGlobalLayout();
        } catch (Exception e) {
            e.printStackTrace();
        }
    }
}

and then just use it as I would use the original PhotoViewAttacher:
final MyPhotoViewAttacher attacher = new MyPhotoViewAttacher(imageView);

Thanks csaba-csete-87 it worked!


[devops:bot] update deps in nix/sources.json (from: rhino-core@fe52263

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/fe522638562711471754fca5fbdd429bce470612/nix/sources.json (branch: dev)

superseded by #150


Detect correct level color for gauge with more than one data value per series

Summed up data values using reduce() on the values array of the series, used this sum to detect level color.
Added tests for changes in arc.js and legend.js.
This resolves #2750.

Codecov Report

Merging #2755 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2755   +/-   ##
======================================
  Coverage    82.9%   82.9%
======================================
  Files          60      60
  Lines        4791    4791
======================================
  Hits         3972    3972
  Misses        819     819

Impacted Files
Coverage Δ

src/arc.js
75.08% <100%> (ø)
:arrow_up:

src/legend.js
82.97% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f339e29...89aedaf. Read the comment docs.


fix: Removes transition animation on tooltip component

Description
Sets the default transition duration on tooltip component to 0.
Fixes #13926
Fixes #13923
Type of change

Bug fix (non-breaking change which fixes an issue)
UX change

How Has This Been Tested?

Manual

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/remove-tooltip-animation

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.62 (0)
38.64 (0.01)
35.94 (0)
56.87 (0)

:green_circle:
app/client/src/components/ads/Tooltip.tsx
100 (0)
87.5 (4.17)
100 (0)
100 (0)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=6ba8621


1150 separate pkgaction into 'pkgaction' and 'serviceaction'

separate pkgaction #1150

@nathanleclaire how does this affect the libmachine refactor?

Shouldn't result in any conflicts.  provision was already inside of libmachine and not much has been changed there.
:+1: from my end

Cool.  Would you mind squashing into a single commit?  Thanks.

And yes, in case it wasn't clear, after a squash LGTM

@ehazlett @nathanleclaire thanks, I will make it clearer in my next PR.

thanks, I will make it clearer in my next PR.

Hm, I'm not sure what you're referencing, but I was just saying that in case I wasn't clear, this PR LGTM (ready for merge).

Hm, I'm not sure what you're referencing, but I was just saying that in case I wasn't clear, this PR LGTM (ready for merge).

I mean to squash to a single commit for one PR as @ehazlett said.

@xiaohui Evan means to rebase the commits like so:
$ git rebase -i HEAD~3
$ # Editor opens, change "pick" to "squash" for the bottom two and exit
$ git push -f xiaohui 1150-separate-pkgaction  # or whatever your remote is

why ci/circleci is failed？

@xiaohui ignore circle for now. It's not ready yet.

ping @nathanleclaire  I have squashed these commits.

LGTM

Ah, looks like some conflicts need to be fixed though.  Sorry about that -- please rebase and I'll merge.

@nathanleclaire would you give me many more details about the conflicts. I have rebased it again, and all tests are passed.

Mergeable now -- LGTM and thanks @xiaohui


recent changes not pushing to aws

Hi @brockfanning the recent changes made, adding new 5.x target and indicator are not pushing to the aws production server after completing the PR.   @jwLACity has done the build locally:
Command to test in the 'aws' branch: bundle exec jekyll serve --config _config.yml,_config_prod.yml
Command to test in the develop branch: bundle exec jekyll serve.
however the changes are not reflected.  Any ideas on what may be happening?
Thanks!
Dawn

@jwLACity @dawncomer My first thought is maybe the caching layer -- is it possible that Cloudfront needs to be invalidated every time there is a production deployment?

@jwLACity @dawncomer But actually one other problem may be that the data repository hasn't had a production deployment. Ie, the develop branch hasn't been merged to the aws branch, on the data repo.

@brockfanning @jwLACity let me try the 2nd option you've sent.  thanks

@brockfanning the recent changes are listed on this data repository PRhttps://github.com/dawncomer/open-sdg-data-starter/compare/aws...develop
Should I encounter any errors with merging the older commits listed?
@jwLACity fyi

Yes I'd go ahead with that PR.

@brockfanning   @jwLACity   completed the PR
No changes yet on aws production yet

ok, @brockfanning @jwLACity I made some additional changes to the localization.yml file, and after that build ran, the new 5.x target and indicator are now showing on the s3 bucket site.  not sure if that was the trigger or it was just a matter of waiting after PR #21 processed.
@jwLACity now it just needs a push to production and we should be set.
you should see target/indicator 5.d and 5.d.1 replaced by 5.x and 5.x.1 on the Goal 5 page.
thanks!

Yes in general, the procedure for a production deployment might be something like:

Merge develop to aws on data repo
Wait 5 minutes
Merge develop to aws on site repo

@jwLACity Is there an additional step needed after this? Maybe with Cloudfront?

@brockfanning noted.  i'll be sure to do PR for data repo and site repo going forward.
@brockfanning and @jwLACity I just checked sdgdata.lamayor, all changes have been pushed and look great!!!  thanks for your help getting us to today's launch!


Add Django Compressor compiler.

This adds a very simple [Django Compressor] (https://github.com/django-compressor/django-compressor/) compiler for JSX.
I haven't included any tests since it would require pulling in django-compressor as a test dependency.
Is there a way to sign the CLA without creating a facebook account?

I don't think the CLA requires a FB account (anymore, there was a time it did and we would send a PDF to you). The one linked in the contributing doc might be out of date but https://code.facebook.com/cla looks like it should be fine without an account.

I tried https://developers.facebook.com/opensource/cla and it required me to sign in. The code.facebook.com link worked without an account, thanks.

+1

Why this PR is still mot merged?

As the README says, this project isn't maintained any more (hence why it's in facebookarchive). Sorry.


Add declanbyrd.co.uk to sites built with 11ty

I built a site with 11ty and would like to add it to the list that is displayed on the website.

Displayed it shall be! Thanks!


formula: :tada: update envd to 0.2.0-alpha.14

drop the version one, we do not have to keep historical version currently
Signed-off-by: Wei Zhang<EMAIL_ADDRESS>

Thanks! Maybe we should have a CICD process to automate this.

As mentioned in tensorchord/envd#455, goreleaser would handle the release when the stable version is released. We should not let alpha/beta versions be synced with Homebrew Tap.

Homebrew provides the --head flag to let users build the project from the source, which is not capable with goreleaser. If we would like to let users install pre-released versions we have to use an alternative way instead of the build-in goreleaser integration.

oops, I was still confused why the CI was not working.
It is the auto skip_upload option preventing the update.
But we only have the alpha version available, maybe we should release the alpha to tap and let users access to the only releases

But we only have the alpha version available, maybe we should release the alpha to tap and let users access to the only releases

It's a probable solution but separating envd as two formulas still sounds a little bit weird. 😂 It would also introduce the cost of the installation due to the collision between stable and alpha versions.
Since envd is under heavy development currently and the alpha releases account for the majority of releases, maybe we should enable syncing with alpha releases again? WDYT @gaocegege

as alpha is tagged as the released version, IMHO, we should publish it as brew releases.
according to the goreleaser doc, we may create a standalone head formula, let me try this later.
maybe we have some misunderstanding 🤣, I don't mean to split envd into 2 formulas, we should only keep the stable version once we have it.
as the alpha version is the only version we have, so that we should publish it into tap as the only release.
oh, after writing the content above, I found out that we have 2 formulas if we use a goreleaser one, and head one. but this is recommended as the goreleaser doc, it should be ok? @gaocegege

BTW, the reason I manually update the tap is that I can not wait to drop the golang dependency, it keeps failing me from installing envd by homebrew because I installed go manually 🤣

Actually, the "formula" I have mentioned previously refers to the Homebrew Formula. I tried this way when we initialized this repository. This way would introduce two formulas envd and envd-head, and they have to be set conflicted by each other, otherwise, the linking of Homebrew may fail. Users have to uninstall the other version when they want to switch between stable and unstable versions. I think it was not a good idea. Currently, If we want to include alpha versions, my suggestion is to modify skip_upload parameter directly to trigger releases.

BTW, the reason I manually update the tap is that I can not wait to drop the golang dependency, it keeps failing me from installing envd by homebrew because I installed go manually 🤣

That was my fault. 😂 envd does not need go when installing since it pulls the binary directly. I was trying to support building from source when installing at that time, so I added go to dependencies. We could remove the related code in .goreleaser.yaml.
I still consider the most proper way is to use --head flag of Homebrew, but the Formula definition generated by goreleaser does not fit it.

got your point @rudeigerc, also, it's ok about the go dependency, it has been removed in the previous release.
how about setting skip_upload to true, and then modifying the generated formula, adding the head part in CI, and uploading to the git repo manually at last?

how about setting skip_upload to true, and then modifying the generated formula, adding the head part in CI, and uploading to the git repo manually at last?

That's the point. If we introduce --head flag, the formula has to be able to be built from the source. Homebrew uses bottles to refer to the binary in the mainstream repo, so it would not come up with this problem. However, the generation of Homebrew bottles is not supported by goreleaser currently.

one more option came up suddenly, we can fork goreleaser and optimize the brew ourselves😁

after doing some research, maybe the current goreleaser way is the right way to go...
bottles is design as pre-built binary ON EACH platform BY homebrew, it contains a meta data file generated by homebrew, so that if we want to provide bottles, we have to set up an CI with each macOS, catalina, big sur, Monterey, etc., and Linux to built each bottles.
the current goreleaser can provider a binary installation on each platforms easily, seems to be a much solid way.
regarding to the building from source, a standalone tap like envd-head or envd-dev seems ok in a second thought,
we can setup a different binary name like the tap name, envdhead or envdev, so that users can install both envd and envd-head/envd-dev in the same time.

LGTM, as for the name, is there any naming convention in homebrew world? envd-head is confusing to me. Maybe envd-prerelease or envd-dev is better.

head suffix may come from the git head as we were building software from the git head code.
but it should be ok to name it anything only if it is more clear to users. users' understanding is much more important than the naming conventions.


Download link of ViT-L-14.tar

Hello, the link of ViT-L-14.tar is not working, could you please provide a new one?

I just fixed the link, try again ^^


No keyboard input in iOS sumulator.

I am unable to interact with a CupertinoAlertDialog when using the iOS simulator (android emulator is fine). I do get a cursor in the CupertinoTextField but there is no input from the physical keyboard and no software keyboard is displayed.
I have tried the Keyboard options in the Hardware menu to no avail.
Steps to Reproduce
Run the following sample app, click the button.
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: BrokenDialogPage(),
    );
  }
}

class BrokenDialogPage extends StatefulWidget {
  BrokenDialogPage({Key key}) : super(key: key);

  @override
  _BrokenDialogPageState createState() => _BrokenDialogPageState();
}

class _BrokenDialogPageState extends State<BrokenDialogPage> {
  // One TextEditingController for each form input:
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Broken iOS Dialog"),
      ),
      body: Container(
        child: Padding(
          padding: const EdgeInsets.symmetric(
            vertical: 8.0,
            horizontal: 32.0,
          ),
          child: Column(
            children: [
              Padding(
                padding: const EdgeInsets.all(16.0),
                child: Builder(
                  builder: (context) {
                    return RaisedButton(
                      onPressed: () {
                        showDialog<bool>(
                          context: context,
                          builder: (context) {
                            return CupertinoAlertDialog(
                              title: Text('Broken Dialog'),
                              content: Card(
                                color: Colors.transparent,
                                elevation: 0.0,
                                child: Column(
                                  children: <Widget>[
                                    CupertinoTextField(
                                      placeholder: "Enter a value.",
                                    ),
                                  ],
                                ),
                              ),
                              actions: <Widget>[
                                CupertinoDialogAction(
                                  isDefaultAction: true,
                                  child: Text("Yes"),
                                ),
                                CupertinoDialogAction(
                                  child: Text("No"),
                                )
                              ],
                            );
                          },
                        );
                      },
                      child: Text('Submit'),
                    );
                  },
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Logs
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G95, locale
en-GB)
• Flutter version 1.9.1+hotfix.2 at /Users/anthonyswift/Library/Flutter
• Framework revision 2d2a1ffec9 (3 weeks ago), 2019-09-06 18:39:49 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/anthonyswift/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling
support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.0, Build version 11A420a
• CocoaPods version 1.7.5
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 39.0.3
• Dart plugin version 191.8423
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (2 available)
• Android SDK built for x86 • emulator-5554                        •
android-x86 • Android 9 (API 28) (emulator)
• iPhone 11 Pro Max         • 688E704F-25B2-4394-8693-B26F279CC9B8 • ios
• com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)
• No issues found!

Hi, could you please try it with the beta channel?
Which I ios version are you using?
Does it work on a physical device?

The issue is present in the beta channel using iOS 13.0 (17A577a).
I will test on a physical device later today and get back to you. This would make testing a problem but would at least be workable.

I would also recommend to switch to ios 13.1
Have you tried if master is different?

I have tested on iOS 7 and it works correctly.
I'm still waiting for an activation key from Apple to test on really device.

Hi @AntSwift
if the issue persist with the latest stable version of flutter
could you please provide your updated flutter doctor -v ,
your flutter run --verbose
and if possible a reproducible minimal code sample.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


X Error of failed request:  BadAccess

Hi i'm using Ubuntu 20.04 and have the problem:
X Error of failed request:  BadAccess (attempt to access private resource denied)
when running interactive play using command:
python examples/interactive_play.py --never-end.
I notice this problem has been already posted in README.md. I'm wondering whether this problem is later solved? Thanks!

hi, I am using Ubuntu20.04 and I  have the same issue, and I wonder if there is any news for this issue. Thanks

Save error waiting to fix. :)

This is still an ongoing issue on Linux unfortunately.

I'm using ubuntu22.04 and I have the same problem

I'm on Ubuntu 18.04 and am facing the same issue as well. So it doesn't seem to be OS specific.

It seems the bug still remains to be fixed... I'm using ubuntu22.04.

I'm facing the same issue in Ubuntu 18.04 after a local installation.

I found out that this error occurs when executing the 476 line code : "pygame.init()". Moving this line of code somewhere else, it might work, such as moving to line 801, before starting the habitat.Env().

Thanks @liuls2002! Your suggestion worked for me!

I found out that this error occurs when executing the 476 line code : "pygame.init()". Moving this line of code somewhere else, it might work, such as moving to line 801, before starting the habitat.Env().

what do you mean? I can't get it to work

您好，你的邮件我已经收到，我会尽快给您回复，谢谢。


dts/bindings: document use of value 'base_label'

'base_label' is not documented.  Update device_node.yaml.template to
fix this.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

Merging #10946 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10946      +/-   ##
==========================================
+ Coverage   53.32%   53.32%   +<.01%
==========================================
  Files         215      215
  Lines       25886    25908      +22
  Branches     5705     5711       +6
==========================================
+ Hits        13803    13815      +12
- Misses       9763     9772       +9
- Partials     2320     2321       +1

Impacted Files
Coverage Δ

subsys/logging/log_msg.c
86.85% <0%> (-1.01%)
:arrow_down:

subsys/net/ip/icmpv4.c
32.62% <0%> (-0.47%)
:arrow_down:

subsys/bluetooth/host/hci_core.c
2.42% <0%> (-0.05%)
:arrow_down:

include/entropy.h
66.66% <0%> (ø)
:arrow_up:

include/bluetooth/bluetooth.h
0% <0%> (ø)
:arrow_up:

include/kernel.h
98.48% <0%> (ø)
:arrow_up:

subsys/usb/usb_device.c
0% <0%> (ø)
:arrow_up:

kernel/init.c
72.58% <0%> (ø)
:arrow_up:

include/logging/log_msg.h
90.9% <0%> (ø)
:arrow_up:

kernel/include/kswap.h
100% <0%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3da1d5...52d920e. Read the comment docs.


I"m unable to see past propmpt and answer.

Describe the bug
I"m unable to see past propmpt and answer.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-fgcphy
Steps to reproduce
I"m unable to see past propmpt and answer.
Expected behavior
I"m unable to see past propmpt and answer.
Screen Recording / Screenshot
I"m unable to see past propmpt and answer.
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 116765165,
  "usedJSHeapSize": 109620421,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = cyrillesaxo
Chat ID = 5cae11771c31

Additional context
I"m unable to see past propmpt and answer.

This improvement is being tracked in #39


drop go18 support

grpc-go removed support of go 1.6-1.8 - https://github.com/grpc/grpc-go/commit/59a2cfbdf9272f6334fe4856b6e7c8d212845b3d
and after that, we have failed tests

¯_(ツ)_/¯
I'll update docs.


feat(StateVariables): Only write if value is changed in public

We should only need to perform write operations in public if the value is different from the current one. Otherwise we are simply wasting resources.
There are multiple variations of this. Differing in how complex they are and the savings they support. Namely at what level we perform the "cleaning".

At write level: Updating a struct of 4 elements where only 1 changed in a call should just write that 1 value. Can initially be done by the simulator and should be relatively straightforward for us to support in the kernels
At call level: If the slot takes same value at end and start of a call it should not be doing a write in the call.
At transaction level: If updating a value to an intermediate value and then setting in back at the end of the transaction should mean that the value is not emitting a state update to L1, the transaction itself is executed as if both updates happened. More complex as needs to go across kernels.
At block level: Any value that ends in the same value that it started in a block should not emit a change. Meaning that if a transaction is increasing a balance by 10, and another later transaction is reducing the same transaction by 10, it should not emit any changes to L1. The block should have happened as if these changes happened.

The overall goal is:

reduce the number of writes that are done in a transactions/call such that you can do more complex stuff without running out of writes,

reduce the number of updates that need to emitted to L1 to cut cost generally.

As a note on this, it should also be considered if it is desired to keep posting diffs as now, or posting the public calls (from private -> public) instead.

At call level: If the slot takes same value at end and start of a call it should not be doing a write in the call.

There's a slight complication to this one. If in the first 'frame' of a function foo, the slot is changed from 10 to 20, then an external function call is made, and then in the second 'frame' of function foo, the slot is changed from 20 back to 10, then the reads and writes do need to be passed to the public kernel circuit. But they're transient reads and writes which can be 'squashed' by the kernel before the 'final' reads and writes are passed to the base rollup circuit.

Disregarding the squishing/collapsing discussed above. The same goal but achieved entirely inside the public state should be possible for the case where we are overwriting a struct but not the entire thing? I think we right now might still be sending multiple write requests even if the values are unchanged?

I haven't kept up with how public state is being serialised into "write requests" for the kernel to process, or serialised to L1.
I suppose we need to decide whether we want Aztec to publish intents or state diffs, and I guess that depends on whether we can do a based rollup design?

I suppose we need to decide whether we want Aztec to publish intents or state diffs

Yes. Which depends on how independent we make sequencing from proving, which depends on performance and costs of the proving system.


Conditions for the same amount to buy / sell and sell / buy.

How can you be sure that the buy / sell and sell / buy will be the same amount?  Is it possible that on one exchange I will buy or sell more than on another?  Then I can get stuck with either money or cash and then I lose money.

That's a key challenge, because being market neutral means that the executions on both sides have to be fully completed at the same time and for the same amount, otherwise yes, the market neutrality will be lost.
We try to ensure fast execution by checking the order books before sending orders, to make sure the order books contain 3 times (be default) the liquidity needed for the two orders to be executed.
This is covered by the parameter OrderBookFactor. From the README:

In order to be executed as fast as possible and avoid slippage, Blackbird checks the liquidity in the order books of the exchanges and makes sure there are at least 3.0 times the needed liquidity before executing the order.

That mechanism optimizes the executions, but doesn't guarantee that no imbalance will occur between the long order and the short order.

Hello, I need help with the internal settings for your strategy, otherwise
I don’t quite understand how to configure the blackbird in the office
itself.  Maybe you have instructions?
пн, 7 окт. 2019 г. в 5:15 AM, Julien Hamilton<EMAIL_ADDRESS>
That's a key challenge, because being market neutral means that the
executions on both sides have to be fully completed at the same time and
for the same amount, otherwise yes, the market neutrality will be lost.
We try to ensure fast execution by checking the order books before sending
orders, to make sure the order books contain 3 times (be default) the
liquidity needed for the two orders to be executed.
This is covered by the parameter OrderBookFactor. From the README
https://github.com/butor/blackbird#blackbird-parameters:
In order to be executed as fast as possible and avoid slippage, Blackbird
checks the liquidity in the order books of the exchanges and makes sure
there are at least 3.0 times the needed liquidity before executing the
order.
That mechanism optimizes the executions, but doesn't guarantee that no
imbalance will occur between the long order and the short order.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/butor/blackbird/issues/506?email_source=notifications&email_token=ANLOLPDSMQTC2Y5MSPDVTSTQNKLURA5CNFSM4I4H4RQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO3BZQ#issuecomment-538816742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANLOLPDAAHEH7TN5LRNME33QNKLURANCNFSM4I4H4RQA
.


[Feature Request] Export calculated embeddings from the app

Thanks for making the app!
I'd like to get the CLIP embeddings for all my photos in iCloud, and it would be really convenient if the app supports exporting calculated embeddings and would save me a lot of time and compute, and it will allow users to explore their photos' semantics in alternative ways.
Would you consider adding this feature?

Hi, the embeddings have already been calculated and saved in the embeddingData file. The code below shows the path and how to load it, and you could print it to see the absolute path.
https://github.com/mazzzystar/Queryable/blob/1f769b3588f46cbbeb9bf93c0e47b1bbfe9b1c12/Queryable/Queryable/ViewModel/PhotoSearcher.swift#L96-L98

Thank you for your reply! I'm not an iOS developer and I'm not sure if it's possible to access app's private data in document dir without doing an unencrypted backup with a Mac. I guess I'll try running embeddings models on my own.


Issue #1831 [master]

I wanted to make sure everyone was happy with this before I went to the trouble of merging to other branches.

Hey @github why can't I review my own PR and block it requesting changes to prevent someone else from merging?

@cschanck confirmed that the external process test functions correctly on Windows.


Using libRecommender.dylib requires disable bitcode in Xcode

Trying to use libRecommender.dylib in an iOS app gives a linker error:
ld: 'libRecommender.dylib' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/tobyroseman/Documents/dylibTest/libAudioPreprocessing.dylib' for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This issue first came up as part of #822.

Work around is to disable bitcode. Search for "bitcode" in Build Setting and set to No.

I believe this should be a dupe of #834. Shantanu to confirm


DotNet/NuGet: Decode SRI hashes

The NuGet hashes are in fact SRI-style hashes that are Base64-encoded,
so decode them.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

This change is

/cc @neubs-bsi