Several Rows in Container - Not all rows equal

I have a container, in it are 5 rows of buttons. I cannot for the life of me figure out why they are not all equal when i am not specifying a width at all. can anyone please help??
See enclosed files.
thank you very much.

button spacing code.txt

Next time, share your demo code in a CodePen or JS Bin, please.
Looking at it, you apparently have some markup issues. You're not properly closing the row after closing the column. Take a look at https://codepen.io/anon/pen/MqPLqg which shows this working as intended.


pdn creating short between macro rings and core rails

short around (2200.00000, 132.00000)

issue_reproducible.tar.gz

@arlpetergadfort this can wait until after your tapeout
@kareefardi FYI

any update on this ?

@kareefardi the tapeout is this week so likely next week it could get some attention

@arlpetergadfort can you prioritize this?

@arlpetergadfort can you prioritize this?

Sure, I'll take a look at it this afternoon.

@arlpetergadfort can you prioritize this?

Sure, I'll take a look at it this afternoon.

@kareefardi what version of OpenROAD are you using?
When I run this I get:

There is no short.

Hey. Sorry I have only seen your reply now. It's was the same version of openroad bundled with OpenLane at the time (I don't which one exactly) Perhaps it is fixed in recent versions. I will test it and let you know

I am still getting a met4 short at the top left corner of the macro. OpenROAD version is 4a99e88667b0840531ca0096c4fa0da8f80d6cb1 I am not getting the same results for met5 in the screenshot in the first post. It is a little bit further to the left as shown below

The version that I tried is the one bundled with openlane and it looks like it's about two weeks old. were there any fixes done to pdngen in that period ?

Yes, please try with the latest

Still getting met4 shorts at the north side of the macro.

It is needed in order to have met4 vertical stripes at the top level enter the macro and connect with the macro on met5 in the rings. Unless that changed, this is currently the only way I know that can connect top level stripes with a macro ring in which both the macro and the top level are using all the metal layers

It's the cause of the shorts. I've added a guard against that, but I'm not sure if this will break what you intend to do.
It seems like you are hacking your way around a limitation and a better solution would be to figure out what is missing and add that into PDNGEN.

We have always used a negative halo and currently some designs rely on that. It used to be that PDNGEN wouldn't attempt to connect to any metal layer in a given macro if that layer has any obstructions in the macro, that don't necessarily interfere with the macro power pins. Hence, negative halo was used to force PDNGEN to enter a macro. However I believe that is not the case anymore. Is that correct?

We have always used a negative halo and currently some designs rely on that. It used to be that PDNGEN wouldn't attempt to connect to any metal layer in a given macro if that layer has any obstructions in the macro, that don't necessarily interfere with the macro power pins. Hence, negative halo was used to force PDNGEN to enter a macro. However I believe that is not the case anymore. Is that correct?

This is the general form of the problem. The usual pattern is the need to connect to a macros ring with both the top level and the macro utilizing all metal layers. and hence the top level pdn stripes would be blocked from entering the macro at all

At the moment, the halo is getting incorrectly applied to obstructions and pins and that is the problem. If your setup works for you, then it works, there is no reason a negative halo is a problem (except that the application to pins and obs is currently wrong and will be fixed). I feel like there should be a better solution, but that can be a different issue.

Ok so if I understand correctly negative halo was not applied correctly. This will be fixed (or already is fixed now). Negative halo by itself is still a valid parameter for PDNGEN. Is my understanding correct ?

Yes, negative was applied incorrectly, the fix has been merged to OpenROAD (https://github.com/The-OpenROAD-Project/OpenROAD/commit/cb3acc68084046d5b343da32c7d3ea16a6e82db9) please try the head of OR. When I run yours, it appears to work, but you will know if connections are happening correctly.

No activity; please reopen if still relevant.


Provision Command and Database Password on Custom Provider

Return response with provision command and database_password if provdder server is custom on createServer method

I'm not sure how/when I'd use this? Can you give an example?

When you provision a custom server on forge, they show up a provision command to execute on server.

API METHOD (createServer)
The documentation shows up the full response
{
    "server": ⊖{
        "id": 16,
        "credential_id": 1,
        "name": "test-via-api",
        "size": "512MB",
        "region": "Amsterdam 2",
        "php_version": "php71",
        "ip_address": null,
        "private_ip_address": null,
        "blackfire_status": null,
        "papertrail_status": null,
        "revoked": false,
        "created_at": "2016-12-15 15:04:05",
        "is_ready": false,
        "network": []
    },
    "sudo_password": "fdijIJ",
    "database_password": "jsnI@93n2b",
    "provision_command": "wget -O forge.sh https://..."
}

So, in API would be nice the createServer method returns all the information, including provision_ command, sudo_password and database_password attributes...


doors don't show up until going to 3D for the second time

I've noticed that the doors don't show up when you go to 3D for the first time. After going back to 2D and then to 3D, it's fixed.
I'll look into it.

same problem with the bookcases, it should be viewed with 3D for the second time after going back to 2D.


Reminders-chrisda to Master

Docs Build status updates of commit 60fb17a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 60fb17a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Web – Chat – Grey image appears when edit text with image

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Log in
Navigate to any chat
Write something in the compose box
Send an attachment to a conversation while there is text in compose box
Edit a text message in a sent message

Expected Result:
Image with edited text appears
Actual Result:
Grey image with edited text appears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/55aad284-4a1f-4207-bad2-e7cb6ee12a0b
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

I could not reproduce this bug.

We're not prioritizing vip-vsb bugs at this time so closing.


Deparse skips NULLS FIRST/LAST in ORDER BY

irb(main):005:0> PgQuery.parse("SELECT 1 FROM a ORDER BY x ASC NULLS LAST").deparse
=> "SELECT 1 FROM \"a\" ORDER BY \"x\" ASC"
irb(main):006:0> PgQuery.parse("SELECT 1 FROM a ORDER BY x ASC NULLS FIRST").deparse
=> "SELECT 1 FROM \"a\" ORDER BY \"x\" ASC"
irb(main):007:0> PgQuery.parse("SELECT 1 FROM a ORDER BY x ASC NULLS LAST").deparse == PgQuery.parse("SELECT 1 FROM a ORDER BY x ASC NULLS FIRST").deparse
=> true

They do appear in the parse tree as sortby_nulls
irb(main):016:0> PgQuery.parse("SELECT 1 FROM a ORDER BY x NULLS FIRST").tree[0]['RawStmt']['stmt']['SelectStmt']['sortClause']
=> [{"SortBy"=>{"node"=>{"ColumnRef"=>{"fields"=>[{"String"=>{"str"=>"x"}}], "location"=>25}}, "sortby_dir"=>0, "sortby_nulls"=>1, "location"=>-1}}]
irb(main):017:0> PgQuery.parse("SELECT 1 FROM a ORDER BY x NULLS LAST").tree[0]['RawStmt']['stmt']['SelectStmt']['sortClause']
=> [{"SortBy"=>{"node"=>{"ColumnRef"=>{"fields"=>[{"String"=>{"str"=>"x"}}], "location"=>25}}, "sortby_dir"=>0, "sortby_nulls"=>2, "location"=>-1}}]

They appear to be supported upstream, although I'm not sure this upstream library is used here (haven't really looked at the code yet)

@herwinw The upstream deparsing code isn't used, since it isn't really compatible with raw parsetrees as they are in use here.
Would you be open to make a patch, similar to e.g. https://github.com/lfittl/pg_query/pull/79?


Make 'state' & 'attributes' public to maximise genericity

It makes little sense to have these fields private as the library does not cover all traits and device types.
Fix issue #6.

Makes sense to me - thanks for the contribution!


Which permission set the board should use

The description of the permission profile option in creating/modifying  board has a nice link to the permission profiles page... though if you click on it you are brought there and you potentially lose any thing you had already set up for the board... maybe open the link in a new page? :innocent:

Nobody answered to the question...
/me feels :sob:

🍭

:yum:

The best would be an ajax request and load the result in an overlay, but for the time being I'll just add a target and open in a new page/tab.


Show recent submissions in an activity feed

From Jonathan:

I’d also like to see a feed of changes on the home page, “joe added taco recipes + 6 child topics”, timestamps optional to obfuscate staleness (if the site doesn’t see updates for days at a time)

I was thinking of doing something kind of similar, except not aggregating the feed as much, more along the lines of a history of edits to an article in Wikipedia:

So-and-so added "Claims of Shoddy Production Draw Scrutiny to a Second Boeing Jet" and tagged it with Lion Air Flight 610, Ethiopian Airlines Flight 302 and the Boeing 737 MAX
Another-person added ...

The question of where the activity feed goes is an interesting one.  I was thinking of putting it behind a "Recent" link in the header.  The front page perhaps one day?

Closing, as the new "Recent activity" feed is a first pass, and issues can be filed for later bugs and enhancements.

Putting a little bit of it on the home page is a good way to communicate to the user what the site is for, as it will say "Person X did Y"... I think of it as more of a marketing/communications/discoverability feature than a productivity feature

Would it replace the chart, with the chart being moved off to another page?

My thought is that it would go toward the bottom, maybe below or close to the fold, keeping the graph.
—
Sent from my Battlestation
Jonathan Yankovich – Helping people work better together
» Subscribe to my YouTube channel https://www.youtube.com/channel/UCvrSgbiLll8wMLu43SYYPkA
» See my Roles at HolacracyOne https://app.glassfrog.com/org/5/people/24697

On Apr 24, 2019, at 8:08 AM, Eric Walker<EMAIL_ADDRESS>wrote:
Would it replace the chart, with the chart being moved off to another page?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/emwalker/digraph/issues/16#issuecomment-486221336, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAR4YNCBN2XL6NCYPCVPJ3PSBLTHANCNFSM4HHJ7HIQ.

@tensiondriven I decided to put a little more effort into the landing page, just so that it's not a distraction. Let me know what you think.


Error when i try to use it

When i try to use it Country::all(); i get error:
Call to undefined method CommerceGuys\Intl\Country\CountryRepository::setDefaultLocale()

The current version of commerceguys/intl is in awaitance of a minor PR that this package needs to function correctly. As a temporary workaround this package should pull in my fork as specified in the composer.json file. Yet it seems that you've installed the "real" repo.
Could you please check if the method setDefaultLocale() is present in the following file?
vendor/commerceguys/intl/src/LocaleResolverTrait.php

No that method not found there. What i need change to get it working? I installed it vai command composer require propaganistas/laravel-intl
ps. sorry my poor english :)

That's odd..
Well, putting this inside your composer.json will definitely pull in the forked repo.
"repositories": [
     {
         "type": "vcs",
         "url": "https://github.com/Propaganistas/intl"
     }
],

Thanks, that solves my problem

@e2mkraft In the meantime the PR I mentioned has been accepted. Please update to 1.1.3 to directly make use of the original intl repository.

https://github.com/Propaganistas/intl

That's odd..
Well, putting this inside your composer.json will definitely pull in the forked repo.
"repositories": [
     {
         "type": "vcs",
         "url": "https://github.com/Propaganistas/intl"
     }
],

Also run composer update afterwards

 https://github.com/Propaganistas/Laravel-Intl instead of  https://github.com/Propaganistas/intl


SyntaxError: Non-ASCII character

I have an error when I use subliminal, could you help me please ?
I use this command:
subliminal -l en /nas/videos/Series/
And this the traceback of the error:
  File "/usr/local/bin/subliminal", line 7, in <module>
    from subliminal.cli import subliminal
  File "/usr/local/lib/python2.7/dist-packages/subliminal/__init__.py", line 11, in <module>
    from .core import (AsyncProviderPool, ProviderPool, check_video, download_best_subtitles, download_subtitles,
  File "/usr/local/lib/python2.7/dist-packages/subliminal/core.py", line 13, in <module>
    from guessit import guessit
  File "/usr/local/lib/python2.7/dist-packages/guessit/__init__.py", line 6, in <module>
    from .api import guessit, GuessItApi
  File "/usr/local/lib/python2.7/dist-packages/guessit/api.py", line 13, in <module>
    import six
  File "/usr/lib/python2.7/dist-packages/six.py", line 260
SyntaxError: Non-ASCII character '\xe2' in file /usr/lib/python2.7/dist-packages/six.py on line 260, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

Thank you

Try to reinstall it

It works, now that I've reinstalled it, I don't now what was the problem


RequestRetrier and responseData failure result.

Is it possible to use RequestRetrier with method should retry... and then catch failure request in request:
.responseData { response in
                      switch response.result {
                      case .success(let data):
                      >...<
                      case .failure(let error):
                      >...<
                      }

Now i seems like if RequestRetrier is implemented, the response not appearing in completion above.

 func should(_ manager: SessionManager, retry request: Request, with error: Error, completion: @escaping RequestRetryCompletion) {
    completion(false, 0.0)
  }

fixed the problem.
Issue can be closed. Thank you)


Backend: CRUD operation on venue model

Fixes: #5
implemented CRUD operations for venue model
TODO: all routes expect get venue (namely: delete, create, read) must be passed through protected routes

@PrathamX595 Please resolve the merge conflicts before I can merge

@shivansh-bhatnagar18 conflicts have been resolved


kubelet ignores --container-runtime=remote --container-runtime-endpoint=unix:///var/run/crio/crio.sock parameters

Calling sudo kubelet -v 1000 --container-runtime=remote --container-runtime-endpoint=unix:///var/run/crio/crio.sock produces  this output.
$ kubelet --version
Kubernetes v1.22.3-rc.0.12+2c0e4a232a3c10
$ kubelet --help
...
      --container-runtime string                                 The container runtime to use. Possible values: 'docker', 'remote'. (default "docker")
      --container-runtime-endpoint string                        [Experimental] The endpoint of remote runtime service. Currently unix socket endpoint is supported on Linux, while npipe and tcp endpoints are supported on windows. Note: When using docker as container runtime this specifies the dockershim socket location which kubelet itself creates.  Examples:'unix:///var/run/dockershim.sock', 'npipe:////./pipe/dockershim' (default "unix:///var/run/dockershim.sock")
...

My reading of the kubelet --help output is, that passing the --container-runtime=remote with --container-runtime-endpoint to kubelet, will convince it to connect to CRI-O.  But instead the log contains

I1001 22:08:16.666036  319919 plugin.go:68] Docker not connected: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Hello,
This is a mirror repo and is not monitored: https://github.com/kubernetes/kubelet#where-does-it-come-from
Please file issues against https://github.com/kubernetes/kubernetes/issues
/close


Modified Hello world sample shows strange behavior

I simply followed the steps given at [https://www.microsoft.com/net/core#windows] after installing dotnet core on Windows 7 sp1 system.
Here is the complete modified program:
using System;

namespace ConsoleApplication
{
    public class Program
    {
        public static void Main(string[] args)
        {
            Console.WriteLine("Hello World!");
	    Console.Write("Enter a number to see magic: ");
	    int num = Convert.ToInt32(Console.ReadLine());
	    for(int i=0; i <=num; i++)
	    {
		Console.WriteLine(i);
	    }
        }
    }
}

It compiled correctly and when I run it with "dotnet run" command, it writes "Hello world!" and waits for the user input without showing the message first which is strange behavior.
The same program when i run on .Net 4.5 compiler, gives me the correct result.

@vivekmishra-sft this is strange? Can you please open an issue for this on the dotnet/cli repo and close this one? Thanks!

@blackdwarf I am closing this issue here and opening the new one as told by you. Thanks


FVTTv10: Canvas Capture is Broken due to Canvas Layers reorg

EffectsCanvasGroup:

Background
Illumination
Coloration
Visibility

Canvas:

Weather
Grid
Drawings
Templates
Tiles
Walls
Tokens
Sounds
Lighting
Notes
Controls

Has there been any progress on this? I tried looking at it myself but I’m kind of lost as to where to even start… been a long time since I dropped out of uni, and I haven’t really done any programming since then

Here's a [rough] workaround:

Create a script macro. Past in the following code:

const blob = await (await fetch(document.getElementById('board').toDataURL())).blob();
const file = new File([blob], {type:"image/png", lastModified: new Date()});
var a = document.createElement('a');
a.href = window.URL.createObjectURL(file);
a.download = 'image.png';
a.click();

Zoom your browser window to like 50% or so using CTRL -
Then zoom your canvas to with the mouse wheel to just fit on the screen.
Run the macro. This will save the canvas to a file, default name = "image.png"
Return the browser zoom to whatever you want (100% usually) using CTRL + to continue playing

It's not a perfect solution, but it gets you an export with all tiles on all levels. The farther out you zoom the browser window, the larger the export file. If your zoom is lower, like 75-100%, the export dimensions will be smaller and you will lose detail. OK for testing, but for final output I'd even go down to 30% for max detail.
Hope this helps,
yah.


Conflict when more than wallet is connected via USB

I connected a ledger and a bitbox and had them both open simultaneously while trying to execute a transaction using sparrow wallet.  The Bitbox device is acting up when another USB hardware wallet is connected, but works fine if no other USB wallet is connected.  The support tech at BitBox told me that there is a conflict with the hwi files.  Is there a way that two hardware wallets can operate simulaneously while they are both connected via USB?

What do you mean by "acting up"? What specific errors and behaviors does it exhibit?
HWI works with multiple devices connected, I do this often. Depending on how Sparrow is using HWI, the issue may be with them.

Thanks for your response.  I am not getting errors, however, the device becomes unresponsive intermittently.  I will bring this to the attention of BitBox and the Sparrow.

Try changing the value of enumerateHwPeriod in Sparrow's config file to a larger number (in seconds) to eliminate Sparrow's occasional background refresh of calling hwi enumerate. This takes one variable out of play. Close Sparrow before editing the config file.


Dupilcate of #775 for master - Ensures ansible service displays vm resources

Identical to #775 except for master (where as #775 was for fine)
Because this is identical to #775 no ss (they're over there)
apologies for the formatting noise
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1451374

@chalettu can you please review and add feedback?

This should be a fine/no

As per my comment in #775, please still mark the 'master' PR as 'yes' even if you need a separate PR for Fine.

@simaishi will do!

UX approved #775, this is the same UX change...going to merge.

Backported to Fine via https://github.com/ManageIQ/manageiq-ui-service/pull/775


Create Functional tests

Pending:
https://github.com/openstack-k8s-operators/horizon-operator/pull/60
The final check fails because it can't find the memcached service:
  [FAILED] in [It] - /Users/brendanshephard/Code/openstack-k8s-operators/my-horizon-operator/test/functional/horizon_controller_test.go:207 @ 03/31/23 15:31:08.638
  2023-03-31T15:31:08+10:00	ERROR	Reconciler error	{"controller": "horizon", "controllerGroup": "horizon.openstack.org", "controllerKind": "Horizon", "Horizon": {"name":"horizon-9699e2e3-f9f4-425d-ac1e-78cda8a48648","namespace":"default"}, "namespace": "default", "name": "horizon-9699e2e3-f9f4-425d-ac1e-78cda8a48648", "reconcileID": "dcfa39c9-bd49-4641-a8ca-e3625969ae55", "error": "No memcached service was found"}

Let's wait for the above to be merged and then we can come back and fix this last failing test.

/lgtm


Remove metrics references from docs

What does this PR do?

Remove metrics references from docs
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@kaushikb11 is there an issue for the docs revamp? It'd be nice to link all the PRs to that issue to see all the improvements made

Hey @ananthsub,
This sprint, we will be working on a proposal for a better docs structure. The original PR is here by Eden #7718 which was long back.


fix(netlify-cms-core): files collection blank label

Summary
Closes #1986

Deploy preview for netlify-cms-www ready!
Built with commit 456c8b152da625cfceb333f15d251e6d68411f86
https://deploy-preview-1987--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 456c8b152da625cfceb333f15d251e6d68411f86
https://deploy-preview-1987--cms-demo.netlify.com


Pass variables when a page is closed in Pageview return null

I have two pages in a Pageview. When I close (swipe) the first of them i need to get params and send to the second page.
Something like this.
First page
void dispose() {
        AlarmsPageScreen(
            //General Data
            datameterValue: widget.datameterValue,
            aliasValue: widget.aliasValue,
            contadorValue: widget.contadorValue,
            latitude: widget.latitude,
            longitude: widget.longitude,
            otherFabricante: widget.otherFabricante,
            otherModelo: widget.otherModelo,
            instalation: widget.instalation,
            contadorModelValue: widget.contadorModelValue,
            fabricante: widget.contadorFabricanteValue,
            //Meter Data
            inputPW: widget.inputPW,
            dropdownSelectionContador: widget.dropdownContador,
            inputIndexValue: widget.inputIndexValue,
            inputMaxValue: widget.inputMaxValue,
            dropdownPeriodo: widget.dropdownPeriodo,
            inputFtpPeriod: widget.inputFtpPeriod,
            inputHoraFtp: widget.inputHoraFtp);
        super.dispose();
      }

Seconds Page
@override
  initState() {
    super.initState();
    print(widget.aliasValue); //Return null
  }

When i take this parameter in second page return null. I checked in first page and it has values.
So the question is: How can i pass params in PageView when user swipe through the views?

Hi @ElHombreSinNombre
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Does not manage error while installing from PyPI if package is not found

install_pypi_pkg: does not catch pip install errors

Fixed in https://github.com/janikarh/jetzt/commit/3eb183ccddde35be578b50d1437e855ce0cb1ed4.


Advise for how to create multi static IP address when using bridge

Hi,
I'm using this network.cfg file, to create 3 static IP address:
network:
  version: 1
  config:
    - type: physical
      name: eth0
      mtu: 1500
      subnets:
        - type: static
          address:  <IP_ADDRESS>/22
          gateway: <IP_ADDRESS>
          dns_nameservers: [ <IP_ADDRESS> ]
    - type: physical
      name: eth1
      mtu: 9000
      subnets:
        - type: static
          address:  <IP_ADDRESS>/22
    - type: physical
      name: eth2
      mtu: 9000
      subnets:
        - type: static
          address:  <IP_ADDRESS>/22
    - type: route
      destination: <IP_ADDRESS>/0
      gateway: <IP_ADDRESS>
      metric: 3

And using this libvirt_network in main.tf to setup network bridges:
resource "libvirt_network" "vm_public_network" {
  name = "${var.VM_HOSTNAME}_network"
  mode = "bridge"
  bridge = "br_v12"
  dhcp {
   enabled = false
  }
  dns {
   enabled = true
  }
}

By that, I have the VM up and running, but with one "eth0" interface only (and one IP address).
I can SSH to this IP, but the other interfaces are not created.
It seems that the root cause is the missing of the additional "bridge", but didn't find the right syntax for multi bridge.
there is this section also, in regards to network_id, but not sure how to declare more than one network_id:
resource "libvirt_domain" "vm" {
  count = var.VM_COUNT
  name = "${var.VM_HOSTNAME}-${count.index}"
  memory = var.VMEM
  vcpu = var.VCPU
  cloudinit = "${libvirt_cloudinit_disk.cloudinit.id}"
  qemu_agent = true
  network_interface {
    network_id = "${libvirt_network.vm_public_network.id}"
    network_name = "${libvirt_network.vm_public_network.name}"
  }

Appreciate any help.
Thanks,
Lavi

Found how :)
By duplicate the (resource "libvirt_network" "vm_public_network")
and duplicate the (network_interface) to the number of interfaces.


Error: URL Not Found When Installing @railway/cli v3.4.0

When attempting to install version v3.4.0 of @railway/cli using the npm install -g @railway/cli command, an error occurs due to the download URL for the binary not being available. The complete error message is as follows:
https://github.com/railwayapp/cli/releases/download/v3.4.0/railway-v3.4.0-i686-pc-windows-gnu.tar.gz
Error: Failed fetching the binary: Not Found
Steps to Reproduce the Problem:

I executed the npm install -g @railway/cli command on my system.
I encountered the aforementioned error.

Additional Information:

Version of @railway/cli: v3.4.0
Operating system and architecture: 64-bit
npm version: 10.1.0

This issue is created to report the problem and request assistance in resolving it. I appreciate any guidance or solutions that can be provided.

This should have been fixed by #389, which was 10 month ago, an it's still broken. Even the latest version (v3.5.2) still doesn't have files for the i686-pc-windows-gnu target.
Am I missing something?


Update hardware labels page

In the latest version the hardware labels are not set automatically anymore, but can instead be set in the same way as SMBIOS labels in the MachineRegistration.

That's weird, I cannot see your changes in the deploy preview...

That's weird, I cannot see your changes in the deploy preview...

I think it only shows in the "next" version. Will update the stable version when we release :+1:


Add api version checks in OVIRT::VM::cloudinit

The PR #93 has solved the problem only partially. This PR adds API version checks to make sure that a conditional inclusion of <use_cloud_init>true</use_cloud_init> is also supported by the engine itself.
NOTE: RHEV-m/OVirt versions prior to 3.6.0 contain a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1206068) which causes that build and revision parameters of API version are set to 0. This may have an impact on conditional inclusion of <use_cloud_init> and thus leaving the guest unconfigured. One can either upgrade to RHEV-m/OVirt 3.6+ or work this around manually by forcing the ovirt engine to report an appropriate version:
# rhevm-config -s VdcVersion=<major>.<minor>.<build>.<revision>
# service ovirt-engine restart

Please replace the placeholders with appropriate values.
@jhernand Would you be OK to merge this upstream please? Thanks.

@jhernand sorry for being pushy, would that be possible to merge this. I would need to bundle rbovirt into our provisioning tools today. Thanks a lot in advance


Fix configmap docs

There were a bunch of errors in the docs which made it hard to follow the example.
@kubernetes/docs @pwittrock @pmorie

@johndmulhausen is docs/user-guide/configmap/README.md on the website?

Is this another case of URL collision?
http://kubernetes.io/docs/user-guide/configmap/

@pmorie It would be useful to dedupe these docs at some point.  LGTM. Merging.


calibration broke between version 201 and 260

calibration versus time especially bad

I was able to successfully search a file calibrated with version 201 using version 260. That is an option for some people.

Does 201 generate file specific tolerances?

I don't think so, but you can just do it manually by using 3* the std dev of the ppm mass error or whatever you want to use

I'll add also, if you encounter data where an older version of MM does a better job calibrating, please send it to me. I'd like to make sure the latest version of MM is the best in all respects.

@trishorts What were the issues that you were encountering? Is it that the calibration is slower now than before?
@rmillikin Are the suggested tolerances still the optimal search tolerances? They were not when analyzing dmorgen's data.

Have not investigated that yet. I'd like to use the Jurkat dataset that Stefan used for evaluating calibration because he observed that a couple of those files had much larger PPM errors after calibration compared to the others, so I want to make sure it's now consistent across several files. This issue is simply for evaluating whether or not calibration is still working, broadly speaking

i have a jurkat file that doesn't look like it calibrates on the time axis. will try again.

confirmed with jurakat file and fasta in newest release


[sc-60057] Make datadog check resilient to missing worker data

Unfortunately purging the offline workers only removes them from flower's web UI and not from metrics: https://github.com/mher/flower/issues/1128 so the datadog check still breaks.
This change makes accessing the various worker data dictionaries safer. I tested this manually when the checks were failing by running agent check against these changes and verified that it succeeded after.
I'll also have to update the submodule in https://github.com/headway/headway/tree/main/flower/datadog and build/push a new image.

Feels like changes like these are going to be incremental - fix a few things here, find another issue somewhere else - but this is a good start.

closing in favor of https://github.com/headway/headway/pull/6642


No module named 'impacket.dcerpc.v5.rpch'

I try to run the Get-ComputerDetails module, but get this error. Has anyone solved this problem?
proxychains crackmapexec smb <IP_ADDRESS> -u Admin -p Password -M Get-ComputerDetails

[-] Failed loading module at /usr/lib/python3/dist-packages/cme/modules/spooler.py: No module named 'impacket.dcerpc.v5.rpch'

Try with latest version


Inconsistencies with Error Tracking vs Firebase Crashlytics

Hello!
We've recently added DataDog error tracking for our app, which already has Firebase Crashlytics. As of now, we have both error-tracking solutions running simultaneously, but there are quite a few inconsistencies with issues are being reported.
Not all of the crashes I see logged in Firebase appear in DataDog
Some examples of beginning of stacktrace:

com.google.crypto.tink.integration.android.AndroidKeystoreAesGcm.decryptInternal
com.google.firebase.remoteconfig.internal.ConfigRealtimeHttpClient.propagateErrors

I noticed that most of the errors that appear in Firebase and don't appear in DataDog originated from outside of my application. Is this expected behavior? Or is there some misalignment in tracking because of the multiple tracking solutions?
Versions:
datadog rum: "2.1.0"
datadog plugin: "1.11.0"
Configuration:
val config = buildConfigManager.dataDogConfiguration
        val configuration = Configuration.Builder(config.appToken, config.environment)
            .useSite(DatadogSite.EU1)
            .setUseDeveloperModeWhenDebuggable(buildConfigManager.isDebug)
            .build()

        Datadog.initialize(application, configuration, TrackingConsent.PENDING)

        val rumConfiguration = RumConfiguration.Builder(config.appId)
            .setSessionSampleRate(config.rumSessionsSampleRate)
            .build()
        Rum.enable(rumConfiguration)

Any insights are welcome!
Thanks

Hello @levinzonr!
RUM errors reporting follows the sampling you set during setSessionSampleRate(config.rumSessionsSampleRate) call, so if particular error is rare, it may be just that all the occurrences so far happened at the non-tracked RUM session.
Speaking of having Firebase Craslytics and Datadog in the same application, it shouldn't be any issues.

@levinzonr yes, it can be the reason. We recommend to initialize Datadog as early as possible.

Hello @levinzonr! I'm closing this issue due to inactivity. If you have more questions, don't hesitate to reopen it.


Missing documents for requiring gl as dev dependency in luma.gl

Unit tests complain about missing gl in dependency
We are requiring luma.gl in our app. In our basic rendering unit test, we see a bunch of errors such as
  console.error node_modules/luma.gl/dist/es5/webgl-context/create-headless-context.js:27
    WebGL not available in Node.js, install using "npm install gl".
    Cannot find module 'gl' from 'create-headless-context.js'

It turns out that we'd need to add gl to our dev-dependency to pass these warnings.
yarn add gl --dev
To Do List

[ ] Doc update
Is there other better way to support unit tests? If not, it would be nice if we can add these requirements to the testing documentation.

I actually think the console.error is the proper level of logging b/c it requires developer's actions. But there are too many console.warns when gl is not installed (See below), and it warns when gl is installed. Also in most cases it is only needed for dev dependency. Correct me if I'm wrong.
So I created this diff to clean it up a little bit.
https://github.com/uber/luma.gl/pull/541
  console.error node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:26
    Cannot find module 'gl/wrap' from 'webgl-types.js'

  console.warn node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:29
    null

  console.error node_modules/luma.gl/dist/es5/webgl-context/create-headless-context.js:26

  console.error node_modules/luma.gl/dist/es5/webgl-context/create-headless-context.js:27
    WebGL not available in Node.js, install using "npm install gl".
    Cannot find module 'gl' from 'create-headless-context.js'

  console.error node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:26
    Cannot find module 'gl/wrap' from 'webgl-types.js'

  console.warn node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:29
    null

  console.error node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:26
    Cannot find module 'gl/wrap' from 'webgl-types.js'

  console.warn node_modules/luma.gl/dist/es5/webgl-utils/webgl-types.js:29
    null

  console.error node_modules/luma.gl/dist/es5/webgl-context/create-headless-context.js:26

  console.error node_modules/luma.gl/dist/es5/webgl-context/create-headless-context.js:27
    WebGL not available in Node.js, install using "npm install gl".
    Cannot find module 'gl' from 'create-headless-context.js'

Hi @shanshanzhu and @ibgreen we are trying to use deck.gl with nextjs and getting exactly the error while building app. What you would suggest for workaround?

@dmi3y

It is not an error, just a notification. It just says that while luma.gl was successfully imported, you won't be able to call createGLContext without installing gl.
I believe this error was removed a long time ago. What luma.gl version are you using?


How rotational invariants are learned with Chebyshev algorithm  ?

Hello,
I'm wondering if the first order approximation of  algorithm Chebyshev ( Weisfeiler-Lehman ) allows the convolutional features to learn rotation invariants of graphs ?
Thank you

@tkipf thank you for your answer. My question is about rotational invariance in the case of irregular graphs (not a grid)

In the context of graph classification, l mean the following :
For the same graph G. A rotation of G with angle u results a graph G'.
G and G' has the same topology and vertices connexion. However, nodes position are not the same . It can be seen as isomorphism graph problem where we look at the bijection. Hence, we need to get invariance to permutation.
Hope it's clear

Oh ok, so assuming you embed this graph in some Euclidean space, you rotate the position of the vertices? This has little to do with the graph structure, I'm afraid. Have a look at Group-Equivariant nets (https://arxiv.org/abs/1602.07576) if you want to be equivariant to transformations such as rotation in a Euclidean space. Invariance is easy, just ignore the node positions and then your model will be invariant to them ;-)

Ok, so the idea is just to embed the graph in Euclidean space without taking into consideration their position , then by construction they are invariant to rotation ?

Yes, but that might ultimately not be what you want. A typical approach is to move to relative, internal coordinates, defined by angles and distances in a local frame of reference. This is by construction invariant to rotation but still keeps the information about the spatial structure of the component.

Hello @tkipf,
l come back to you for some clarification  about invariance to translation, rotation and permutation in the context of full graph classification  (irregular graphs).

In this context , the actual Chebyshev implementation is only  invariant to translation (and not to rotation  and permutation)  ?
If we want to be invariant to rotation or more in general to permutation, we need to come up with a pooling algorithm which is invariant to permutation. However :
2-A) If we apply pooling by taking into consideration nodes positions . Invariance to permutation will not be respected , since it depends on the nodes position (which vary from a graph to another)
2-B) If we come up with a pooling that ignores nodes position . I'm wondering how can fully connected layer  distinguish between two graphs of the same classs, since the position of nodes is a discriminant features. Otherwise, fully connected layer act randomly on graphs since it doesn't have any prior about nodes position. For the sake of clarification let's take a simple example:

Given two graph G and G' such that G' is obtained by permuting the vertices of G.
Obviously, the graph neural network should learn that G and G' are coming from the same class. However if  the network is not invariant to permutation (convolutional/pooling layers), the fully connected layer will act randomly , because there is no structure on these graphs.
Hope it's clear.
Thank you for your answer

Invariance to translation :
We have two graphs G and G' such that G' is the result of translation on G.
Translation on graph can be seen as just removing some nodes and connections on the graph. Let's say we apply translation by shifting right by 3 units, hence we get a new adjacency matrix. G' here is a subgraph of graph G.

Invariance to rotation (can be seen as in grid) : if we apply rotation on graph G with 90° we obtain graph G'.   Graphs G and G' have the same topology, it changes only the position of nodes (nodes relabeling ) but the connexions remains the same. It's just a permutation of indexes in the adjacency matrix. Permutation is more general than rotation

"Graph neural nets only give you equivariance w.r.t. permutation"  How this permutation is learnt ? since the order/position of nodes is note known at the fully connected layer

In the latter case. Using global pooling allows to map  features from the conv layer to softmax layer (without the use of fully connected layer which lose information about the graph structure). But l'm wondering  how global pooling  is invariant to permutation in the context of graphs.

I see. In general these types of models (GNNs for classification with a permutation-invariant pooling layer) are invariant to permutations of indices in the adjacency matrix, so this should cover the symmetries you're describing if I understand this correctly.
Not sure what you mean by 3), but hopefully what I said above helps. Sum/average are by design permutation invariant operations, so permutation invariance doesn't need to be "learned" (it's in there by design ;-) ).
4): Same as 3), but maybe I'm still misunderstanding the question.

I think the source of our misunderstanding is that by global pooling, I mean pooling over all nodes (0-th dimension in your example) whereas you seem to be pooling over the feature dimension, which doesn't make a lot of sense to me...


Add an pre-image information into the Enrollment structure

A node should reveal an pre-image in advance for effienciency during enrolling as a validator. The pre-image information contains the pre-image as a certain round and the round number, such as: (P, Nx), where P is the pre-image and Nx is: n - (rounds since enrollment), which is described in the white paper.
#492

Ready for review

I have decided to close this PR because it makes unnecessary confusion and the code is not so helpful and it might make the work time unnecessarily longer for the issue. My original intent was to reduce network transmittion by revealing a pre-image in advance during registering as a validator. If such an concept happen to be needed some time, I will apply it to the code. From now I will start implementing the API point called sendPreimage.


Dismiss on tap

It would be great to have the possibility to dismiss dialog view controller when user taps area outside it

Ok! In new version I am add it!

Added, see version 4.0.4

I cannot seem to find the option, was this removed from the current version?


CI: Separate out Rubinius to use Trusty

This PR extracts rbx-3 and turns it into rbx-4 on Trusty. (That's the only dist on Travis which even starts rbx things.)

Coverage increased (+0.1%) to 99.199% when pulling b155159f64496c31466508ca0a6d556d179c6379 on olleolleolle:patch-2 into b14a1664ed08775c6be21e698e2ca27d3a534000 on adhearsion:develop.

Thanks again!


Implement OpenLineage extractor for Redshift async operators

Implement OpenLineage extractor for Redshift async operators

[ ] RedshiftSQLOperatorAsync
[ ] RedshiftDataOperatorAsync

Broken plugin: [openlineage.airflow.plugin] Failed to import astronomer.providers.amazon.aws.extractors.redshift.RedshiftAsyncExtractor .
Update OL version to 0.10.0 and 0.11.0 and tried the same issue exists.
Connect with @pankajkoti and try to resolve this.

Current issue is that with the latest Astro image and recent OpenLineage releases 0.9.0, 0.10.0 & 0.11.0 the plugin load is failing for Redshift Extractor. @rajaths010494 to connect with Maciej (GetInData team) and dig deeper into resolving this issue today.

Waiting for PR to be raised from Ol side so that i can review and implement the same in our extractor

We can refer to this page: https://www.notion.so/astronomerio/Developing-OpenLineage-in-Astro-9f30a74c74354f168279c1205f4d89a6 to install local packages

Today have a connect with maciej for broken plugin issue.

Draft PR has been raised https://github.com/astronomer/astronomer-providers/pull/561

Test cases are pending

Expected to be completed EOD

New version of openlineage-airflow==0.12.0 has been released, will revamp unwanted code and then push the changes

Have incorporated the new openlineage-airflow==0.12.0 code for redhsift extractors.

Ready for review and i have rebased


Add main fileld to package.json

Is it possible to add "main" field to package.json configuration file ? We are currently setting it to "bin/prettify.min.js" after npm update . This is necessary in order to use this library with angular-cli.
If approved, I can provide a pull request.

I've just noticed that npm support is not in the github repo . If it's like that, please ignore this issue ...

depends on #379

added package.json in #469.


Mutexes are done! but, the type of thread functions haven't been handled completely.

Can you move the mutex definitions (i.e. calls to "malloc()") to the constructors (and "free()" to destructor) and leave the mutex declarations in the class declarations? If this is confusing let me know and I'll point out specifically what I mean.

Also some of the header files were commented out from stdafx and the #define IsWinDef you had there wasn't working for some reason. May need to find another way to do that.

Sure, but free() is already in the destructor of the class.By the way, what do you mean by "leave mutex declarations in the class declarations" ?
About the commented header files, since I am not able to fully compile the code, I need need to use the some part of the code in order to test, and I forgot to undo that before pushing the commit, but in this commits, I corrected that.

By the way, was #define IsWinDef working in the first pull request ?

basically I mean leave Mutex* m_pMutex; in the class declaration and put the malloc()s in the constructor.
#define IsWinDef wasn't working in the first pull request. I had to add a commit which changed it around for the time being. I've never see it done that way either, we may have to think of another way to do it. I also think you'll need to pull that most recent commit too. I don't think that'll be a problem though because I didn't change much of anything.

I had considered to allocate the memory for m_target member, but in that way, it was giving segmentation fault, so that was the reason why I used the malloc outside of the class, but I'm going to check again whether there is some way to do that.
P.S, The conflict has resolved.

Ok sounds good, I'll take a look at this in the morning and merge/check for bugs.

By the way, I pushed a new commit, which needs testing on windows about whether return value by the thread function is returned properly.I only implemented it to TimeThread() function in TimeThread.cpp, so you can use that.

The return value seemed to work fine although, no idea why, but the other server projects weren't able to local the RETURN_THREAD() at link time. I moved this function from stdafx.cpp to TimeThread.cpp and it seemed to resolve the issue.
When do you plan to get a windows machine?

As far as I know, never :). I mean in campus, for linux, I can even use the computers in labs, but there is no way that I will be able to have a windows machine which I can use for the project.

I think someone except than you should also test these last commits of mine because you are getting weird errors lately :)

Haha yeah, and it would take more work off me - which is nice.

This issue was moved to ApexKO/OpenKO#28


Add sales report endpoint

Hitas Pull Request
Description
Adds endpoint for creating and downloading sales report Excel file.
Pull request checklist
Check the boxes for each DoD item that has been completed:

Testing

[x] Changes have been tested
[x] Automatic tests have been added

Database

[ ] Database migrations will work in the DEV & TEST environments
[ ] initial.json has been updated to work with migrations
[ ] Oracle migration has been updated

Documentation

[ ] Tooltips have been added in the frontend for all new fields
[x] OpenAPI definitions have been updated
[ ] Test instructions have been written for the customer in the appropriate ticket in Jira
[ ] Terminology page in Confluence has been updated

Test plan

[x] Automated tests
[ ] Uncomment the lines below from the top of backend/openapi.yaml and open the Swagger interface at localhost:8090. Add http://localhost:8090 to CORS_ALLOWED_ORIGINS in backend/.env. Use the new report endpoint from the Swagger interface while the backend is running at localhost:8000 and observe the downloaded Excel file.

#servers:
#  - url: http://localhost:8000
#    description: Local development server

Tickets
This pull request resolves all or part of the following ticket(s): HT-606

Still needs approval from the customer before merging, unless we wanna do an update later


Unregister component: front-end

Hey, I just made a Pull Request!
Implements the logic for showing a list of component from one location in the component unregister dialog. It doesn't work yet. We should make a decision on where to put the orchestration of a component(s) unregistration. I'd like to have it on backend in a transaction.

[x] All tests are passing yarn test
[x] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[x] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

@freben 👀

Ok for now, let's get it in. But my main gripe with this is that we still have the entityToComponent concept here and writing more code that fits the old component model. It should all be completely torn out and replaced with direct use of plain Entity as-is. Maybe in a later PR?

I totally agree. «Entia non sunt multiplicanda praeter necessitatem» I'll keep it in mind for the next PR.


Throw out refresh result if we know it's stale

Refresh on focus takes so long it actually rolls back the game state under some scenarios. Check moves list length vs stored on a per-game basis

I believe this is why jay's games "roll back" to the previous move sometimes


Bump python precommit timeout to 3hrs

Follow up to https://github.com/apache/beam/pull/10121
Regular version of the precommits are timing out. Not the pytest versions. Apply the same timeout to both places.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

run seed job

Both @udim and @robertwb mentioned that this change does not help. Because there are some tests that got stuck/took a long time(?) and even with extended timeout tests still timeout. In the good case these tests do already fit in 2 hrs.
We can rollback this change based on the above observation. More important question would be, how are we going to identify which tests got stuck. So far we seem to be only able to see this issue in Jenkins environment and we have many hundreds of unit tests, running in 8 difference configurations.

I still see : "21:11:51 Build timed out (after 120 minutes). Marking the build as aborted." I do not believe this timeout is actually doing what we expect. : https://builds.apache.org/job/beam_PreCommit_Python_Commit/10218/console
@yifanzou is this the right way to set timeout?


Add verbose flag

Closes #72

Codecov Report

Merging #324 (8f380f6) into master (78b8303) will decrease coverage by 0.14%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   97.68%   97.53%   -0.15%
==========================================
  Files          23       23
  Lines        1854     1869      +15
==========================================
+ Hits         1811     1823      +12
- Misses         43       46       +3

Impacted Files
Coverage Δ

robocop/run.py
96.92% <50.00%> (-0.49%)
:arrow_down:

robocop/config.py
96.23% <88.88%> (-0.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b8303...8f380f6. Read the comment docs.


TlsMode::Require format.

Using the old version, how can I connect to a db requiring tls/ssl?
Can postgres_openssl::MakeTlsConnector be used?

"the old version"?

As I understand it, in the current release, the second argument of PostgresConnectionManager::new can take either   NoTls or a MakeTlsConnector object, like:
let mut builder = SslConnector::builder(SslMethod::tls()).unwrap();
builder.set_ca_file(pg_cert_loc).expect("failed to load certificate");
let connector = MakeTlsConnector::new(builder.build());

let manager = PostgresConnectionManager::new( url.parse().unwrap(), connector);

(however, I get the following error when trying this:
#21 738.5    --> server/src/storage/db.rs:185:67
#21 738.5     |
#21 738.5 185 |         let manager = PostgresConnectionManager::new(url.clone(), tls_connector)?;
#21 738.5     |                                                                   ^^^^^^^^^^^^^ the trait `MakeTlsConnect<Socket>` is not implemented for `MakeTlsConnector`

)
However, the code I am trying to get to connect to a postgres DB over ssl is using a previous/older version of r2d2_postgres from rocket_contrib = { version = "0.4.8", default-features = false,features = ["json","postgres_pool"] } where the second argument of PostgresConnectionManager::new is a TlsMode::None or TlsMode::Require(...)) object. It's not clear how to specify the connector as an argument to Require(...)` - everything I've tried hasn't worked.
Appologies if I am missing something obvious.

That version of r2d2-postgres is over 5 years old, and is not supported.


Is there a way for user data transmission?

I want to transfer some basic user data(eg. alias, description) after entering the room, is there a way to do that, or what should I do?
Data might be changed during the room lifecycle(user also might enter or leave the room), everyone should be notified with the newest data.

Hi @zeroone-ved there's no API for this currently, but this would be a great enhancement. Currently UniVoice only has APIs related to audio and chat members:
public event Action OnCreatedChatroom;
public event Action<Exception> OnChatroomCreationFailed;
public event Action OnClosedChatroom;

public event Action<short> OnJoinedChatroom;
public event Action<Exception> OnChatroomJoinFailed;
public event Action OnLeftChatroom;

public event Action<short> OnPeerJoinedChatroom;
public event Action<short> OnPeerLeftChatroom;

public event Action<short, ChatroomAudioSegment> OnAudioReceived;
public event Action<short, ChatroomAudioSegment> OnAudioSent;

Data like what you've described will currently have to be transmitted via the underlying network you're using.

Hi @adrenak I've just posted a commit to make synchronization between peers available. I also extend the interface of IChatroomNetwork, which might cause errors in the 3rd implementation, so that I leave it in my local.
Maybe I'll create another pull request after all is ready, or someone could just do it simply like this:
public interface IChatroomNetwork : IDisposable {
    event Action<short, string> OnCommonDataReceived;
    event Action<short, string> OnCommonDataSent;

    void SendCommonData(short peerID, string data);
}


Add list detectors endpoint

Description
As we are starting to support more and more detectors, it would be useful for user to be able to list al the available detectors by just making an API call.
The information we should return for this:

Detector id
Detector type
Associated chunker type / id

With a request parameter, we should also enable following in same endpoint:

hostname + port

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."


Ability to change 'admin' to something else at installation

I think it's time to add a feature that enable to set super admin (uid=1)'s username configurable upon install.
It's good security practice to change the "admin" to something else upon install.
Currently, it's very obvious that super admin's username tends to be "admin", and may be a lightly easier to brute force attack.
It would be nice to add the username field and CLI installation to be able to set admin username.
Thanks

I still want this feature.

We would be happy to accept a pull request that performed this operation.

Oops. Havent' had time  yet. I will re-open


(PUP-4340) Fix intermittent failure in test case

The source_attribute test was modified to wait for time to pass
sufficient that touching source files on the master would cause puppet
agent runs to resync the files. However, the test only checked
mtime/ctime on the master - which is unrelated to ctime/mtime of the
target files on the agents - and the agent target files are what will be
compared to the ctime/mtime of the source file to see if they need to be
resynced.
We could fix this by iterating over the agents - or assuming they'll
always be done in order and only querying the last agent - to check the
ctime/mtime stats of the target files using puppet resource file <filename>, but that's more complicated and unlikely to be
significantly less than the 1 second sleep we used to have.
Revert to the previous behavior of waiting 1 second to touch the files
and try resyncing.

I think the quickest alternative would be running a Ruby script to query mtime/ctime of the last file specified on the last agent.

CLA signed by all contributors.

$ be rake ci:test:aio SHA=a8cc7cbd0d3581f19e40477a8cd1ba9452708a7d CONFIG=config/nodes/redhat-7-x86_64.yaml TESTS=tests/resource/file/source_attribute.rb
...
tests/resource/file/source_attribute.rb passed in 96.78 seconds
      Test Suite: tests @ 2015-03-31 08:47:52 -0700

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 96.78 seconds
      Average Test Time: 96.78 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1


How did you choose your shell?

I'm currently a bash user because it's the default. I've been looking a lot at fish and zsh lately, but I'm having trouble figuring out which features of those shells differentiate them from bash and from one another. Which shells do you use? Why?

fish and zsh are really good shells, but I find that I prefer zsh over fish simply because of the development community and the ease of use. Still, I do find that the features of fish are much more enticing than vanilla zsh which causes me to toggle between the two occasionally.
My biggest issues with using fish is that there are a few incompatibilities with POSIX which sometimes forces me to do quick rewrites of shell scripts for installing or running applications. It's not a huge issue, just one that causes a bit of annoyance. Slant has some pros and cons if you're interested in other opinions.
In either case, fish or zsh, I would recommend using the oh-my-fish or oh-my-zsh bundles for their community plugins and support.

I tried fish out for a few hours yesterday, and the experience was fantastic. Unfortunately, the more I read about configuring it, the more dismayed I was at the workarounds for the POSIX incompatibility. The most accepted solution seems to be running some other shell as your default shell and then starting fish from that shell's configuration if it's an interactive shell. I'm fundamentally bothered by the idea of needing another shell just to run the shell that I want to use, so I think that may have killed fish for me.
@ritashugisha What features of zsh do you really like?

@whereswaldon I stick with zsh mostly because of the community and how zsh is configured to work with other shells while fish is trying to become a sort of standalone. For me, my choice is more against fish than for zsh simply because it can become annoying to configure several different configuration files and env vars for simple tasks.
I like the vanilla fish autocomplete more than zsh, but find that zsh works fine for what I need. Also, I have found in some instances that zsh handles automatic escaping better than fish. I don't remember a particular instance, but I've noticed it in the past.


oidc登陆用户显示错误

[x] 我已经检查过discussions
[x] 我已经搜索过issues
[x] 我已经仔细检查过FAQ

描述bug

context：使用okta作为oidc提供方，k8s+helm chart 部署

oidc登录成功，但登录用户显示为default（ID）格式，且已经设置过user-display-name-claim-name，数据库中新增用户见截图
okta中需要设置login/logout redirect url， 当正常登录时无问题，登出时apollo逻辑为重定向到ingress地址再跳转/signin#logout，但此种方式在配置oidc服务方redirect url时会导致无法退出到登录页面（oidc登出时url必须与实际跳转的首个地址一致，但登入登出都为ingress地址，会进入死循环）

期望
oidc登陆正确且显示正确，登入与登出可以由用户自行控制url或取消自动跳转
截图
数据库新增用户截图：

okta与apollo user Info mapping:

application-oidc.yml:

额外的细节和日志

版本：2.0.0
错误日志: portal 正常，无日志
平台和操作系统：

@vdisk-group Do you happen to have any experience in this topic?

@nobodyiam tried email/name/nickName, nothing changed but always the id itself
Thanks in advance!

Hi @nobodyiam @vdisk-group , any updates about this?

Hi @nobodyiam @vdisk-group , any updates about this?

please try this package and add the logging level config to the application-github.properties
logging.level.com.ctrip.framework.apollo.portal.spi.oidc.OidcAuthenticationSuccessEventListener=trace

https://github.com/vdisk-group/apollo/releases/tag/tag-oidc-debug-log

Hi @vdisk-group , thanks for the package but unfortunately we are not allowed to uploaded a package directly to a VM due to company's policy, would you provide a hotfix image or Docker file so that i can either use the debug image or build and push it to the docker-hub?
Thanks in advance!

@Shelby-Jiao You may use this docker file.

Hi @nobodyiam and @vdisk-group , build a debug image and tried to start portal, log file attached, any clues on it?
Thanks in advance!
apollo-portal.txt

Hi @nobodyiam and @vdisk-group , build a debug image and tried to start portal, log file attached, any clues on it? Thanks in advance! apollo-portal.txt

please add the session config to the application-github.properties and try again.
spring.session.store-type=none

apollo-portal (2).txt

apollo-portal (2).txt

please try this package
https://github.com/vdisk-group/apollo/releases/tag/tag-oidc-debug-log-2

apollo-portal (4).txt

apollo-portal (4).txt

please try this docker image docker.io/vdisk/apollo-portal-oidc-debug-1:latest
image digest sha256:03e854b95fac34412d9bd73bb5346558293229447d08ab1efbf4b12c9c0771d4

apollo-portal (5).txt

seems like oidc provider didn't pass the profile to apollo, but still would you help locate the root cause ? Is it from provider profile mapping/pass side or apollo side?
Thanks!

Hi @nobodyiam @vdisk-group haven't heard you for the last few days, any update or anything i can help?

it seems that the okta do not provider the email by default, you should add the email scope to the config
application-oidc.yml
spring:
  security:
    oauth2:
      client:
        registration:
          okta:
            scope:
              - openid
              # add this scope to get the okta user's email address
              - email


Adding ser lancer and fixing tower of the hand

Tower of the hand should return the selected controller character to his hand as well as kneel the location itself.

http://thronesdb.com/card/05014
This is ser lancel.

I have made the changes. Sorry this is the first time ever I touch javascript and I am not really sure of what goes where yet.

👍

Thanks!


Please add example/sample code to README.md

Hi there,
it looks like you're working hard on something similar to python's fonttools library, only based on rust. This looks very promising and I am very curious to play with it. Would it be possible to get some sample code on how to load and modify a font.
I was thinking about something like: https://github.com/foliojs/fontkit#example
Thanks a lot in advance, Olli

Any help is much appreciated: https://stackoverflow.com/questions/76392138/how-do-i-modify-a-font-and-save-it-with-rust-write-fonts

hello!
Sorry for the sparse docs, I'll definitely get to that eventually, but things are still in quite a bit of flux.
The answer provided in that question looks right to me. We provide two crates, which are very similar: read-fonts is just for parsing, and write-fonts is for compilation/mutation. To modify a table, you need to convert it to the write-fonts version, mutate that, and recompile it. There is a trait for converting between the types; it's called ToOwnedTable, and it is defined in write-fonts.

For future readers, https://github.com/simoncozens/fontspector/ is fast becoming a source of lots and lots of example code for how to do things with fontations, particularly on the reading side but with some writing examples. Start here or here.

Thank you sooooo much @simoncozens . It's great what you're doing with Rust. I am very impressed!


Publish bundled files to gh-pages

Run tooling gh and will publish ./build or directory specified by you to gh-pages branch.

Done. https://github.com/egoist/tooling/commit/40ed5dd05380c0476f9b06ed2b513511472b6212


Otel Configuration on Testcontainers

Description
Implement Configuration for Testcontainers
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1125
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@artursouza @cicoyle please review. This is the first step to demonstrate OTEL with local development.

@salaboy I have checked the changes and I have a few general suggestions:

Add a marker interface named ConfigurationSpec - this would allow us to mark all the other configuration with this interface, so it is easily discoverable in an IDE.
Add a configuration spec builder - it is easier to follow what we try to put in a configuration spec if we use a builder approach. Having classes with constructors that have multiple parameters is not very user friendly. I would use something like the DaprContainer approach where you have with... which allows you to add different options.

Let me know your thoughts.

@artur-ciocanu I agree, but let's do this in two separate steps.. the Configuration class first and then we can add the fluent buileres to it. I am building an example where I want to test if this configurations work or not and based on that I want to make sure that the experience is polished with builders and all.

Regarding the ConfigurationSpec interface.. i don't think it makes sense.. if we just have a single configuration CRD that covers a bunch of different topics -> https://docs.dapr.io/operations/configuration/configuration-overview/

Regarding the ConfigurationSpec interface.. i don't think it makes sense.. if we just have a single configuration CRD that covers a bunch of different topics -> https://docs.dapr.io/operations/configuration/configuration-overview/ Maybe I am missing something

My proposal was to have an interface that would allow us to model different configuration sections. It can be an interface named ConfigurationSpec or ConfigurationSection or ConfigurationParameters. Then we can have different implementations for different sections like:

TracingConfigurationSection
MetricsConfigurationSection
LoggingConfigurationSection
MiddlewareConfigurationSection
etc

Let me know your thoughts.

@salaboy if it is not too much to ask, could you please rebase your branch. It is outdated.

@salaboy if it is not too much to ask, could you please rebase your branch. It is outdated.

done

@salaboy I was looking at the latest changes you pushed, the ones related to Observation API. In my opinion it would be easier to review if we have the following:

OTEL configs for Dapr Testcontainer
Micrometer Observation API support for new Dapr Spring Boot integration

Let me know your thoughts.

I made good progress here.. now traces are propagated in some way for messaging, we need to do the same for the kvstore + bindings but the messaging side of things should show us the way forward.
If you look at this line : https://github.com/dapr/java-sdk/pull/1126/files#diff-f86931381933e4ae24b3f860afc7618f23aecb516cea8bfd0ce627b16bf64e19R159 this is propagating the trace parent to the grpc call @jonatan-ivanov @onobc but the sequencing might be wrong, as the spans are parallel and not one inside the other as shown in this screenshot:

Here is the node graph:

In theory, we should see "Rest Endpoint -> Messaging template bean -> GRPC call to the Dapr Sidecar", but at least now the traceparent is propagated and all the spans belong to the same traceparent.

@salaboy I was looking at the latest changes you pushed, the ones related to Observation API. In my opinion it would be easier to review if we have the following:

One PR for OTEL configs for Dapr Testcontainer
Second PR for Micrometer Observation API support for new Dapr Spring Boot integration

Let me know your thoughts.

@artur-ciocanu I will appreciate any help that you can provide here.. I am happy for you to copy the contents of this PR in separate PRs if you think that is best, I will be away until the 13th of October so any help on moving this forward will be highly appreciated.

@artur-ciocanu I can close this one right?

@artur-ciocanu I can close this one right?

I think so

@salaboy could you please close this PR and we could focus on other observation enhancements.


Feature/button

Codecov Report

Merging #14 (d1e7a5e) into develop (a8f9b70) will increase coverage by 3.13%.
The diff coverage is 98.03%.

@@             Coverage Diff             @@
##           develop      #14      +/-   ##
===========================================
+ Coverage    90.30%   93.44%   +3.13%
===========================================
  Files           16       23       +7
  Lines          165      366     +201
===========================================
+ Hits           149      342     +193
- Misses          16       24       +8

Impacted Files
Coverage Δ

Core/Sources/Extension/StringExtension.swift
84.61% <ø> (ø)

Core/Sources/Extension/UIColorExtension.swift
100.00% <ø> (ø)

Core/Sources/Extension/UIImageExtension.swift
0.00% <ø> (ø)

Core/Sources/Extension/UIViewExtension.swift
88.23% <88.23%> (ø)

Core/Sources/Components/Button.swift
97.50% <97.50%> (ø)

Core/Sources/Extension/UIEdgeInsetsExtension.swift
100.00% <100.00%> (ø)

Core/Sources/FontLoader.swift
76.92% <100.00%> (ø)

Core/Sources/Fonts.swift
67.74% <100.00%> (ø)

Core/Tests/Components/ButtonTests.swift
100.00% <100.00%> (ø)

Journey/Sources/JourneysViewController.swift
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f9b70...d1e7a5e. Read the comment docs.


CurseForge Suggestion

Not sure if its possible but adding a script to get curseforge standalone working with this. I know minecraft is already added but this would allow modded minecraft.

@Silviyius you've given me an idea thank you! Quick question is curseforge compatability with this legacy/msi Java version of mine raft and dungeons?

Its legacy Java.  It just the mod client for Forge or fabric.

@Silviyius would this program mod other games as well or is this just strictly minecraft?

https://www.curseforge.com/games
They have a whole list of games.  The linux verison only supports WOW

@Silviyius dang that's crazy.. ok.. you've given me a really good idea about mods. I'll look into it.

@Silviyius apparently curseforge is malware?

@moraroy there was some modders who got infected with malware. Full story here
https://www.windowscentral.com/gaming/curseforge-pc-game-mod-users-may-have-received-malware-as-part-of-a-recent-hack

@Silviyius dang :/ is it worth adding still in your opinion i dont mod too much but you given me a great idea its hard to pass up im going to implement it tonight

@moraroy Id say so. Everybody gets hacked eventually. I can live without it. It's just a pain to install otherwise. Thanks for supporting the Linux and steam deck community!

No this is not necessary, out of all launchers curseforges launcher is the most unnecessary, don't waste time with this :)

Why was minecraft even added? Thats not really a launcher, unless we call the bootstrap process of every game a launcher now..

@color-space do you have any more launchers you can recommend?

Well, I disagree with color space that Minecraft isn't the launcher, which is. I'm glad you added that is an option that makes it easier for everybody. Not everyone plays the same games, so well I'll have different opinions.

@Silviyius maybe I'm missing something...I want to add cursforge, but it won't install for me I even tried through overwolf and that won't install for me, have you successfully tried to install this in proton?

@moraroy Have you tried using the Linux version of CurseForge? I've not tried it (yet) but I'm watching this video and they use the Linux version, which is able to add the addons to WoW without any problems.

@buzzsurfr yeah I could add it but I was doing my best to add the windows version because it supports a lot more games... I've been told the Linux version only supports wow? Is that true?

Ahh, you're correct--CurseForge for Linux supports WoW only. (Reference).

@if you can figure out a way to install cursforge windows version I'll add it!

Just a heads up. Looks like they came out with a linux verison of this working on the device now which is a app image.  Its pretty Slick.
https://www.curseforge.com/download/app
No proton needed.


Unpublish an App from Business Central Sandbox

We have more Extensions published and installed in our BC Sandbox-environment for extensive testing.
The version of one of the apps was unintentionally modified and as a consequence when uploading that App to our sandbox, we got an error, telling that we needed to run an update.
We have corrected the version in the app.json file and reloaded the App, but now we get error 422: The Extension can not be synchronized as a newer version has already been synchronized.
However when we open the sandbox, the correct App is there with newest modification and correct version. The App just needs to be installed manually. Then everything works.
The error 422 just keeps coming up every time we upload new modifications for this App.
How can we remove the App totally from the sandbox without removing the entire sandbox ?
We have test-data in other App's we would like to keep.
Expected an Unpublish would solve the task but we can't find any guide of unpublishing from the sandbox.

Thanks, that worked :-)
Just wondered about the unpublish.
In NAV2018 OnPremise we have the Unpublish function, but that function seems not to be available in D365 BC Cloud sandbox. Maybe it will be there in a future release (?)

We are not planning changes in this area in the near future but will consider it for our long term backlog.
Closing this issue as it seems to be solved.


Fix code scanning alert - Comparison of narrow type with wide type in loop condition

Tracking issue for:

[ ] https://github.com/microsoft/ebpf-for-windows/security/code-scanning/436

Not a threat, but should be fixed for code sanitation.

https://github.com/microsoft/ebpf-for-windows/blob/3978ce4780788a7237ddc9379d34b156e113126c/libs/platform/user/ebpf_platform_user.cpp#L230-L230

what I have understood is that in loop condition
for (uint16_t i = 0; i < _ebpf_platform_group_to_index_map.size(); i++)
i     ------>                  is narrow type
_ebpf_platform_group_to_index_map.size()   --->   is wide type
is it right

I am a beginner .I would like to get involve the Microsoft Opensource

if yes hear is my idea
I will create a variable of type    ---uint16_t
I will assign the value returned from _ebpf_platform_group_to_index_map.size() function to that  new variable.
and modify loop condition to for (uint16_t i = 0; i < new_variable; i++)
I am I correct?
sorry if I am  wrong. sir

@Keerthivardhan1 - Can you please change the index variable type from  uint16_t i  or uint32_t to size_t  for the following?

https://github.com/microsoft/ebpf-for-windows/blob/3978ce4780788a7237ddc9379d34b156e113126c/libs/platform/user/ebpf_platform_user.cpp#L230-L230
https://github.com/microsoft/ebpf-for-windows/blob/b371d24603c32bef45ae7d8441a11fadf8ce83db/libs/api_common/windows_platform_common.cpp#L255
https://github.com/microsoft/ebpf-for-windows/blob/b371d24603c32bef45ae7d8441a11fadf8ce83db/libs/service/api_service.cpp#L314

And for this one:
https://github.com/microsoft/ebpf-for-windows/blob/ac28f74a820bd05e9a3acaab146e7ac102566d97/tests/sample/ext/app/sample_ext_app.cpp#L102
Please make the following changes:
sample_ext_app.cpp
@@  -88,2  +88,2  @@
-    const char* strings[2] = {"rainy", "sunny"};
+    const char* strings[] = {"rainy", "sunny"};
-    std::vector<std::vector<char>> map_entry_buffers(2, std::vector<char>(32));
+    std::vector<std::vector<char>> map_entry_buffers(EBPF_COUNT_OF(strings), std::vector<char>(32));
@@  -102,1  +102,1  @@
-    for (uint32_t key = 0; key < map_entry_buffers.size(); key++) {
+    for (uint32_t key = 0; key < EBPF_COUNT_OF(strings); key++) {

I am assigning this to you.

Done sir ,
please review my PR
When I submmited PR following was displayed

I am a student so I replied
@microsoft-github-policy-service agree
and It is displaying
license/cla Queued — Contributor License Agreement is not agreed yet.

sir ..the changes that I made(with your  guidance ) are correct ?? are ok ?

sir ..the changes that I made(with your guidance ) are correct ?? are ok ?

It is correct I think but there is extra stuff in the pull request causing the tests to fail which prevent it from being merged.  See comments in PR #1594 which are waiting for you.  Can you try the actions there?
Thanks again for your help!


When the same parse+template is run multiple times, the derived values are cached across runs but shouldn't be

#lang racket
(require subtemplate)
(map (λ (v)
       (syntax->datum
        (syntax-parse v
          [(xᵢ …) (subtemplate (yᵢ …))])))
     (list #'[] #'[a] #'[a b] #'[c d e f]))

produces '(() () () ()), but it should be '([] [a/y] [a/y b/y] [c/y d/y e/y f/y])

I vaguely remember fixing this some time ago, and the bug doesn't occur anymore. Closing now.


Draft: emit confetti from given position

hi @loonywizard, thank you so much for this wonderful library! ❤
any chance you've got spare cycles to finish this PR? would be a huge help


Specify puppet6 collection when defaulting version to 6.2.0

These tests set the default puppet version for the puppet_library hook
to 6.2.0 but don't set the default collection to puppet6 accordingly.
Now that the default collection 'puppet' points to puppet7, installing
the package fails. We now set the collection to match the version
explicitly.
!no-release-note

Closed in favor of #2419


[tflite] fix allow fp16 in tflite benchmark_model

interpreter_->SetAllowFp16PrecisionForFp32() should be called
before setting delegate. Otherwise, it won't work.

Can one of the admins verify this patch?

This is used to tell NNAPI delegate to allow fp16 to be used to run fp32 models. On any NNAPI enabled platform having fp16 capable accelerator(s), e.g., phones with Snapdragon 855 and NNAPI driver for its GPU, Huawei phones with Kirin 980, and phones with MediaTek P90, changing the order of code is necessary (after new NNAPI delegate introduced). This is not a model specific problem. Any floating point model supported by TFLite, e.g., ones at TFLite Hosted Models has this problem.

Got it, thanks!


[Discussion] Is there any plan to remove the dependency on an extra etcd cluster?

Is your feature request related to a problem? If so, please describe.
Hi~ I'm new here and interested in this project.
I found that the system depends on an etcd cluster outside of kubernetes.  I think it will bring extra cost to maintain the etcd.
So I was wondering is there any plan to remove the dependency on an extra etcd cluster ?

Describe your proposed solution
Maybe we can use another CRD which could describe a deployed model (e.g. PredictorInstance or Model ?). Thus the ModelMesh sidecar could watch/update the CRD and send request to ServiceRuntime. (The mechanism maybe similar to pod in kubernetes)

Describe alternatives you have considered

Additional context

Hi @LuBingtan, it's a good question. The reason is partly historical - the core part of modelmesh-serving (the model-mesh sidecar container) was actually developed independently of Kubernetes and can still be used without it. In fact it can also be used with zookeeper as an alternative to etcd. We added the controller more recently to help orchestrate clusters of model-mesh pods, and that's where the CRDs came in and are mapped to existing model-mesh constructs.
Another reason is scalability. The way in which model-mesh uses etcd is intentionally lighter-weight than the way that Kubernetes uses it, with the size of the metadata that goes along with every serialized CR and all of the api machinery. The records that model-mesh maintains per model are intentionally very small, both in etcd and in memory. This has allowed us to scale a single model-mesh cluster to manage more than 300k models with a regular sized etcd cluster and no performance issues. It would be difficult to manage that many CRs (in fact it may be double since each model would likely require two like you suggest).
Model-mesh also uses etcd to coordinate "internal" state - if we were relying on CRs alone then this would need to be done in the Status or in annotations, which should be possible but the frequency of updates/writes is quite high so again it would put a strain on the Kubernetes infra at higher scales.
However, it is something I've thought about because I agree it would be nicer out-of-the-box experience to work without requiring a separate etcd cluster and the major issues I outlined should be less of a problem at smaller scales. It could hopefully be achieved with a new CRD to represent the concrete model (just like you suggest - this would then work similar to Kube Deployment/ReplicaSet), along with a new implementation of the kv-store abstractions that already allow to use either zookeeper or etcd. The separate controller (this repo) would also need to work differently in this case since the model-mesh sidecars would be operating against Kube directly and own the CRs.
But it's not something we consider high priority given all of the other things we're working on, especially since it would be a nontrivial amount of work. If you are interested in playing around and prototyping this though I would be happy to help review/advise.

Also, even if this was implemented it might not be ideal for large-scale production for the reasons outlined. And for dev/experimentation the quickstart script will run a non-HA single etcd pod for you. So the scenarios where it would be most useful might be limited anyhow.

Also, even if this was implemented it might not be ideal for large-scale production for the reasons outlined. And for dev/experimentation the quickstart script will run a non-HA single etcd pod for you. So the scenarios where it would be most useful might be limited anyhow.

Thanks. Got it. Agree with you, it would be a nontrivial amount of work.


Enables Kokoro integration tests for jib-maven-plugin.

Fixes #11

Okay, the continuous integration builds pass (run manually).

Good to go - macOS is fixed.


fix(trie): delete nonexistent keys from DB

So this PR fixed two bugs? firstly, fixed the delete operation of the nonexistent keys; secondly, fixed the delete keys in DB.

Only fixed one, delete a node that does not exist from the database when calling commit

        for key in self.deleted_keys.drain(..) {
            self.db.remove(key.as_ref()).map_err(TrieError::DB)?;
        }

I think now just one. Maybe I misunderstood it.


Add into_analog to GPIO

This PR implements the Analog mode on GPIO, which had a struc already, but had no matching into_analog function.
To summarize what it does, is connect pads/pins, which have some analog functionality, to RTC IO_MUX instead of standard IO_MUX, as shown on Figure 7 of technical reference manual:

Besides this, it disables RTC input/output/pull-up/pull-down functionality on the pins, following initialization done in Espressif's IDF HAL. The list of pins comes from section 4.11 "RTC_MUX Pin List" of TRM.
Such pins can then be used for ADC/DAC (e.g. https://github.com/Gasper/esp32-hal/blob/feature-adc-example/examples/adc.rs#L51).
Please feel free to provide feedback on any architectural/contextual/style errors that you might notice.

This is awesome! Thank you, perfect PR, no issues here.
Looks like you have the ADC working or nearly working too?

Looks like you have the ADC working or nearly working too?

Yes! ADC, DAC and Hall sensors are working, but the code still needs some love and testing. Some things, such as cosine-wave generator on DAC, will probably be missing in the first PR, since I currently don't have access to oscilloscope to even see if it's working...

Awesome! If it wasn't for corona I could test it at work :/, but having all the other stuff would be amazing!


expand_or_jumpable return false for lsp snippets and custom snippets

I am currently at commit 7552e65 and when running this code, the snippet does not expand. This happens for both LSP snippets and custom snippets.
Configuration file:
local cmp = require("cmp")
local ls = require("luasnip")

local M = {}

local function load_cmp_config()
  local cmp_select = { behavior = cmp.SelectBehavior.Select }

  cmp.setup({
    sources = {
      { name = "nvim_lsp" },
      { name = "nvim_lua" },
      { name = "luasnip" },
      { name = "path" },
      { name = "buffer" },
    },

    mapping = {
      ["<C-p>"] = cmp.mapping.select_prev_item(cmp_select),
      ["<C-n>"] = cmp.mapping.select_next_item(cmp_select),
      ["<C-y>"] = cmp.mapping.confirm({ select = true }),
    },

    snippet = {
      expand = function(args)
        ls.lsp_expand(args.body)
      end,
    },
  })
end

local function load_luasnip_config()
  local s = ls.snippet
  local t = ls.text_node

  ls.add_snippets("c", { s("testc", { t("Hello World") }) })

  -- Luasnip configuration
  ls.config.set_config({
    history = true,
    updateevents = "TextChanged,TextChangedI",
    --override_builtin = true,
  })

  vim.keymap.set({ "i", "s" }, "<C-k>", function()
    if ls.expand_or_jumpable() then
      print("Expanding or jumping")
      ls.expand_or_jump()
    else
      print("Not expand or jumpable")
    end
  end, { silent = true, noremap = true })

  vim.keymap.set({ "i", "s" }, "<C-j>", function()
    if ls.jumpable(-1) then
      ls.jump(-1)
    end
  end, { silent = true, noremap = true })
end

M.config = function()
  load_cmp_config()
  load_luasnip_config()
end

return M

Plugin file:
return {
  "hrsh7th/nvim-cmp",
  dependencies = {
    "hrsh7th/cmp-buffer",
    "hrsh7th/cmp-nvim-lua",
    "hrsh7th/cmp-path",
    "hrsh7th/cmp-nvim-lsp",
    "saadparwaiz1/cmp_luasnip",
    { "L3MON4D3/LuaSnip", build = "make install_jsregexp" },
  },
  config = function()
    require("voidkrc.config.completion").config()
  end,
}

Example of what I see:

To add on this, I can see my custom snippets in the cmp window.

Hi :)
It seems a bit like you're conflating what luasnip does and what cmp/cmp_luasnip does, so to make sure that's not the case I'll outline what each of them is responsible for:
ls.expand_or_jumpable() returns whether the current snippet is jumpable or whether the text immediately before the cursor matches a snippet added via add_snippets. This does not include lsp-snippets!
cmp_luasnip takes all snippets added via add_snippets and lists them as a cmp-source. This means all snippets can be expanded from the cmp-list by accepting the item (<C-y> in your case)
cmp (or, the nvim_lsp-source) takes snippets generated by the languageserver, and, upon accepting the item, it expands them via the ls.lsp_expand()-function.
Does this help clear the issue, or were we on the same page before? :D

Hi :) It seems a bit like you're conflating what luasnip does and what cmp/cmp_luasnip does, so to make sure that's not the case I'll outline what each of them is responsible for: ls.expand_or_jumpable() returns whether the current snippet is jumpable or whether the text immediately before the cursor matches a snippet added via add_snippets. This does not include lsp-snippets! cmp_luasnip takes all snippets added via add_snippets and lists them as a cmp-source. This means all snippets can be expanded from the cmp-list by accepting the item (<C-y> in your case) cmp (or, the nvim_lsp-source) takes snippets generated by the languageserver, and, upon accepting the item, it expands them via the ls.lsp_expand()-function.
Does this help clear the issue, or were we on the same page before? :D

Thanks @L3MON4D3 , I got confused because I thought luasnip would match the snippet even if i wasn't writing the full word. Is there a way to implement that?

luasnip only expands snippets if the whole trigger matches, cmp_luasnip should also list snippet-items if there is a partial match with the typed text.
So #incl -> list snippet-items with cmp -> select one with <C-y> -> snippet expands. At least that's how that should work.
Is this not working for you?


Building error

Hi,
I downloaded UMA 2.6 to my project (Unity 5.6) and tried to build I got the error:
NullReferenceException
UMA.UMAAssetIndexer.ForceSave () (at Assets/UMA/Core/Extensions/DynamicCharacterSystem/Scripts/UMAAssetIndexer.cs:199)
UMA.UMAAssetIndexer.UnityEditor.Build.IPreprocessBuild.OnPreprocessBuild (BuildTarget target, System.String path) (at Assets/UMA/Core/Extensions/DynamicCharacterSystem/Scripts/UMAAssetIndexer.cs:804)
UnityEditor.Build.BuildPipelineInterfaces.OnBuildPreProcess (BuildTarget platform, System.String path, Boolean strict) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildPipelineInterfaces.cs:232)
UnityEditor.HostView:OnGUI()
Assets/UMA/Examples/Extensions Examples/DynamicCharacterSystem/Scripts/Scene4/PhotoBooth.cs(645,0): error CS1525: Unexpected symbol `}'

I must say that in the UMAAssetIndexer script I added lines:
#if UNITY_EDITOR
using UnityEditor.Build;
#endif

because when I downloaded UMA to Unity, I got errors and suggestion to add "using UnityEditor.Build".

uma26 branch is not really recommended for development atm because there are a lot of changes going in and it can be pretty unstable. Thanx for the report though : )

The same with UMA 2.5 :). I got the same error when I downloaded UMA 2.5 to Unity. The suggestion to add "using UnityEditor.Build". So I wrote the code above and it worked. But I don't know if I could build because I have troubles with both UMA 2.5 and UMA 2.6. I just copied the stuff from the  "UMA DCS Demo - using Asset Bundles" scene to my scene and the UI doesn't work. How to fix that?

It seems that I fiexed the problem in the PhotoBooth file. I just moved
#endif
at the end of the file to include all the file content. This file is editor-only.
Now, I get a few errors from UMAAssetIndexer.

I removed UNA 2.6 and downloaded the Master branch. Wow, now all seems great! You added the line:
using UnityEditor.Build;
And I can build UMA in a separate project. I got only the error:
ullReferenceException
UMA.UMAAssetIndexer.ForceSave () (at Assets/UMA/Core/Extensions/DynamicCharacterSystem/Scripts/UMAAssetIndexer.cs:201)
UMA.UMAAssetIndexer.UnityEditor.Build.IPreprocessBuild.OnPreprocessBuild (BuildTarget target, System.String path) (at Assets/UMA/Core/Extensions/DynamicCharacterSystem/Scripts/UMAAssetIndexer.cs:814)
UnityEditor.Build.BuildPipelineInterfaces.OnBuildPreProcess (BuildTarget platform, System.String path, Boolean strict) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildPipelineInterfaces.cs:232)
UnityEditor.HostView:OnGUI()
I will try it out in my scene.

I included UMA in my project and copied the stuff from the "UMA DCS Demo - using Asset Bundles" scene to my scene. I need that in my project.

I use Vulkan API.
In the Unity Editor, I see the avatars, can click on them and the UI is showed, but the UI doesn't work. I cannot change hair, clothes, colors, etc.

I have just tested the build of the "UMA DCS Demo - using Asset Bundles" scene in the separate project with UMA only and the same problem, but I clicked the Debug button and I got the errors:

I downloaded UMA 2.5.1 (Unity 5.6).
Still error:

Can you go to the global library

and see if "Eye Overlay" is in there

I thin it's all Ok.

but you still get the error or is the scene working now?

I can run the scene in Editor. No problems. I'll try to build the example scene again.

The result:

The same error.

The error is alwalys in the build, not in Editor. Really strange.

Yes, I see that now.  That does happen for me too, I'm trying to fix it now.

Ok.

I think we have fixed it if you can try and update from master again.

Thank you - now it works.
However, still I have problem with the copied stuff from the example scene to my scene. I wrote on the forum thread.

Which is that you're trying to copy the UI stuff to a new scene?

This is what I wrote on the UMA forum thread:
Yes, I have no big knowledge about UMA because I use a different software, but this time I need this scene for my project. I have installed the fixed version of UMA 2.5.1 and all great. But when I copied the stuff from the "UMA DCS Demo - using Asset Bundles" scene making a prefab and then place the prefab in my scene, again the UI doesn't work. The three avatars are DCS.
EDIT: I noticed a strange thing:
The options for Race, Wardrobe, Colors, etc. appear only in the Scene View, not in Play view! For example, I click on the Race button and the options for choosing the race doesn't appear in the Game window, only visible in the Scene window. And when I click on the UI element (the root for all UI elements) that is a canvas, it moving upward and downward in the Scene view. I think it is problem with UI, not with AssetBundles or races.
And when I click on an UI item, a Blocker appears in my Scene Hierarchy.

Well, that is outside of the scope of bug fixes for UMA, but did you make sure to copy over "DynamicSampleCustomizer" also?
I don't think the UI was made with it in mind to be able to copy to other scenes.  I recommend examining the UI to understand how it works.  Also, could you not copy the whole scene and then modify it for your project?

I just grabbed all the stuff from the example scene (without EventSystem because I have one in my scene) and place the prefab in my scene. All works in a separate project with UMA only, but the problems are in my project only. I think it is not a problem with UMA itself, but something with UI.
OK, thank you for your help. Please close the issue. UMA is working great.

Unity Team confirmed that the problem with the UMA UI is caused by a canvas bug in Unity, not UMA itself.