Add tests

It was brought up somewhere else that we should have test cases for this. And I agree. I just started to discover TAP and this seems that could help:
https://github.com/sstephenson/bats

Nice find, ideally we should also look into making most functions pure then. Lots of global variables still in play sadly.


[FEATURE] Create a better 404 page

Description
The 404 page currently, isn't so good. So, make a better one which matches the theme :P
Screenshots
No response
Additional information
No response

on it!


XVR5216AN doesnt support lighting but 'Device supports infrared lighting=True'

when i add in my XVR5216AN (its an 16 channel BNC unit so no lighting is supportted)m, its saying lighting is supported
yet when i access the url
http://<IP_ADDRESS>/cgi-bin/configManager.cgi?action=getConfig&name=Lighting[0][0] i clearly get a 400 error back
but its showing in the logs
2023-04-09 17:17:30.107 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
any suggestions?
2023-04-09 17:17:14.264 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration dahua which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2023-04-09 17:17:22.589 INFO (MainThread) [homeassistant.bootstrap] Setting up stage 2: {'onboarding', 'energy', 'input_select', 'timer', 'diagnostics', 'auth', 'input_datetime', 'ipp', 'sun', 'config', 'logbook', 'met', 'automation', 'input_boolean', 'tag', 'tts', 'application_credentials', 'counter', 'stream', 'file_upload', 'hacs', 'repairs', 'my', 'map', 'dahua', 'system_health', 'blueprint', 'analytics', 'search', 'history', 'mqtt', 'media_source', 'input_number', 'scene', 'ffmpeg', 'schedule', 'conversation', 'radio_browser', 'mobile_app', 'homeassistant_alerts', 'frigate', 'input_button', 'hardware', 'sensor', 'default_config', 'trace', 'device_automation', 'person', 'auto_backup', 'zone', 'image_upload', 'lovelace', 'input_text', 'persistent_notification', 'script'}
2023-04-09 17:17:22.622 INFO (MainThread) [homeassistant.setup] Setting up dahua
2023-04-09 17:17:22.622 INFO (MainThread) [homeassistant.setup] Setup of domain dahua took 0.0 seconds
2023-04-09 17:17:25.558 INFO (MainThread) [custom_components.dahua] Using channel number 1
2023-04-09 17:17:26.944 INFO (MainThread) [custom_components.dahua] Using max streams 3
2023-04-09 17:17:28.777 INFO (MainThread) [custom_components.dahua] Device supports Coaxial Control=True
2023-04-09 17:17:28.866 INFO (MainThread) [custom_components.dahua] Device supports disarming linkage=True
2023-04-09 17:17:29.480 INFO (MainThread) [custom_components.dahua] Device supports smart motion detection=True
2023-04-09 17:17:29.480 INFO (MainThread) [custom_components.dahua] Device is a doorbell=False
2023-04-09 17:17:29.480 INFO (MainThread) [custom_components.dahua] Device is an Amcrest floodlight=False
2023-04-09 17:17:30.107 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting[0][0]
2023-04-09 17:17:30.107 INFO (MainThread) [custom_components.dahua] Device supports infrared lighting=True
2023-04-09 17:17:30.109 INFO (Thread-2) [custom_components.dahua] Starting DahuaEventThread
2023-04-09 17:17:30.746 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting[0][2]
2023-04-09 17:17:30.747 INFO (MainThread) [custom_components.dahua] Device supports profile mode=False
2023-04-09 17:17:30.916 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting[0][0]
2023-04-09 17:17:31.463 DEBUG (MainThread) [custom_components.dahua] Finished fetching dahua data in 8.643 seconds (success: True)
2023-04-09 17:17:31.467 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.dahua
2023-04-09 17:17:31.470 INFO (MainThread) [homeassistant.components.camera] Setting up camera.dahua
2023-04-09 17:18:01.483 DEBUG (MainThread) [custom_components.dahua] ClientError fetching information from http://<IP_ADDRESS>:80/cgi-bin/configManager.cgi?action=getConfig&name=Lighting[0][0]

im still having this issue @rroller any suggestions?

ive been able to find out the issue but im not sure how to fix it as im not an experienced python developer
STEP1:
https://github.com/rroller/dahua/blob/321a576e5fee81de122c440ad28d806b519e35cc/custom_components/dahua/__init__.py#L259-L265
STEP2:
https://github.com/rroller/dahua/blob/321a576e5fee81de122c440ad28d806b519e35cc/custom_components/dahua/client.py#L204-L223
STEP3:
https://github.com/rroller/dahua/blob/321a576e5fee81de122c440ad28d806b519e35cc/custom_components/dahua/client.py#L195-L202
STEP 3 is returning an empty {} as expected because of the returned 400
but then in STEP2 its just returning the empty {} rather than catching the error to check if its a 400
then returning to STEP1 with empty {} rather than again catching the error


Table Checkbox sort

I am new to HTML and github, sorry if I make a mistake in following any protocol.
It would be nice if a table could be sorted based on the checkbox column.
It would be very helpful if all checked items are dynamically shown at the top of the table.

[ ] Sort table based on checkbox column
[ ] Add toggle filter to show only checked items
[ ] Add vertical scrolling to table body, eg if data-rows=10, but total data is 100 rows, can it be possible to scroll all rows in same view without pagination.
[ ] Add placeholder text in search input box

Thank you very much for this great Metro UI!
This is my sample code, just to give you an idea how my table is configured. The  items are set using script from an external source by database.setItems(values) method.
`

  <table id="meds" class="table compact striped row-border row-hover table-border mt-12"
        data-role="table"
        data-rows="6"
        data-show-activity="false"
        data-check="true"
        data-show-rows-steps="false"
        data-show-table-info="false"
        data-table-search-title="Add medicines"
        data-show-pagination="false"
        data-search-fields="Name, Class, Company"
        data-check-name="chkBox"
        data-on-check-click="checkClick()"
        data-search-wrapper=".my-search-wrapper"
         >

        Name
        Dose
        Freq
        Instructions
        Class
        Company

`

@nevusK If it would be possible then can you assign me to this issue I want to resolve this would be my first contribution

@pragyamishra56 It seems that I cannot assign this issue to you. Maybe if you tag the admin / owner of this repository @olton , they might be able to assign it to you.

Hi, you can create a pull request (to dev branch) with required changes.


Development

In this project, we have implemented the following;

[ ] A login page.
[ ] A registration page.
[ ] A food list (with all CRUD implementation, except for 'update').
[ ] A recipes list (with all CRUD implementation, except for 'update').
[ ] A general shopping list view (all missing food for all your recipes and total price).
[ ] A list of all public recipes from other users with their names and total prices.

Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has node_modules on the repo and the file is heavy I can't review it please add it in the gitignore
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Thanks for the review
On Saturday, June 3, 2023 at 02:08:48 AM GMT+1, Abdulfatai Badara @.***> wrote:
@fobadara requested changes on this pull request.
Hi team,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
Highlights
✅ All tests are passing
✅ Clean code
✅ Good first attempt
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers, and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Thank you very much
Sent from Yahoo Mail on Android
On Sat, Jun 3, 2023 at 7:23 AM, ismail @.***> wrote:
@Ismailco approved this pull request.
Hi @Divinity-dev,
In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it
Highlights
✔ Good communication
✔ No linter errors
✔ Used Gitflow
✔ Work documented professionally
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


merge firefox and chrome-extension into one

No need for seperat e branches when they share so many things, just leads to duplication

https://github.com/codecov/browser-extension is a great example of how extension for different browsers can be worked upon together.
Present workaround is not the right way to do things, as branches are created for parallel development not development of distinct products.
If someone could look into codecov and decide on how to work on this it would be really awesome.


[FEATURE] Let us boost our OpenAPI capabilities!!

Is your feature request related to a problem? Please describe.
I want to control the "Example value" of my "Request body". RIght now, we only get something like this:
{
  "string_field": "string"
}

I should be able to control this behaviour, like
{
  "string_field": "Default value for string_field"
}

Describe alternatives you've considered
I thought that declaring default values might change the values in the swagger, but even that does not work. It would even be a bad behaviour, as we would tightly couple Swagger documentation with API behaviour.
Additional context
Add any other context or screenshots about the feature request here.

Hello! At the moment you already can set the example value of field.
For example:
async def create_user(
    uid: int = Query(..., description="Id of user for add to database", example=123),
    is_superuser: bool = Query(..., description="User status", example=True),
):
    """
    # Get data about user and add to database
    """
    new_user: User = await UserQuery.create_user(uid, is_superuser)
    return UserSchema.from_orm(new_user)

Hi,
The documentation does not contain the "example" field. Can you get this info added, as it helps a lot with OpenAPI configuration.
Thanks for the help!! Closing this ticket 😄
Best,
Gautam

Also, we might want to mention this field for all types (Body, Params, etc), or mention it in a separate OpenAPI related page that combines it.
Reopening it so that this work is there in your backlog, please close it thereafter.
Thanks 😄

Uh.. i really forgot https://fastapi.tiangolo.com/tutorial/body-schema/. In new pydantic, this named as Field, but... fastapi doesn't work with new pydantic ;)

Thanks for the help here @prostomarkeloff !
@gautamsinghania95 you can add examples for the schema of your Pydantic models: https://pydantic-docs.helpmanual.io/usage/schema/#schema-customization
The Pydantic docs have an example of that. Also, recent versions of FastAPI have support for recent versions of Pydantic. :smile:


Ssb 2.1 crashes the JVM in hand chained partitions suit.


Denote reading prettified vs non-prettified

Typically, large JSON data files are minified. Glaze is optimized for reading minified data for this reason.
It's great that Jsonifier is fast at reading prettified files, but it would probably be best to compare both prettified and non-prettified parsing.

Done! Thanks for the suggestion.

Awesome, thanks


Implement how to serve two windows

It is not possible (is it? I've been trying for a while now and have concluded it is not) to serve two different directories when the electron app has two windows.
Something like this
const loadURLOne = serve({ directory: 'one' })
const loadURLTwo = serve({ directory: 'two' })

function createWindow() {
  const oneWindow = new BrowserWindow({
    width: 1800,
    height: 1600,
  })

  const twoWindow = new BrowserWindow({
    width: 1800,
    height: 1600,
  })

  if (isDev) {
    oneWindow.loadURL('http://localhost:3000/one')
    twoWindow.loadURL('http://localhost:3000/two')
  } else {
    loadURLOne(oneWindow)
    loadURLTwo(twoWindow)
  }

This in dev works as expected (the localhost is an astro site)
But in build I can only get two windows opened that point to the same directory (the first one).
So this would be a nice feature to have in mind, if it is feasible.
EDIT: Or a variant would be to point, instead of a directory, to a file
const loadURLOne = serve({ directory: '.', file: 'index.html' })
const loadURLTwo = serve({ directory: '.', file: 'two.html' })

It sort of works, but not being able to point to a file but to a folder, I get all my css lost. I would need to search them at a ../ level, but that is too messy since the folder exists at build level, but not at dev level where the css are imported within a react component. This destroys the dev experience.
So I'll keep it only working at dev level (this is an app for me anyway), but it would be great that the serve would allow to pinpoint to a specific file instead of a folder.
(Thanks!)

See if this works for you: https://github.com/mhkeller/electron-serve/tree/custom-route
That's a branch that supports a route option. It defaults to index but you can set it to foo and it will load foo.html.
There's also a branch called query-params which supports passing those in when you call the returned function with a given window.
The main branch of my fork has both changes merged. I can put these in a PR and see if either is of interest.

It may be possible to close this now that custom HTML file names are supported via https://github.com/sindresorhus/electron-serve/pull/36

Since version 1.3.0, this works for me as long as I set a different schema (my files are all in the same directory).

@mhkeller do you have a working example? I tried to use the parameter file but I get an error.
serve({ directory: "./out/renderer/", file: `main`, scheme: "main" })
serve({ directory: "./out/renderer/", file: `popup`, scheme: "popup" })

UnhandledPromiseRejectionWarning: Error: ERR_FAILED (-2) loading 'main://-'
    at rejectAndCleanup (node:electron/js2c/browser_init:2:79113)
    at finishListener (node:electron/js2c/browser_init:2:79275)
    at WebContents.stopLoadingListener (node:electron/js2c/browser_init:2:79662)
    at WebContents.emit (node:events:519:28)

There is files in folder
./out/renderer/
./out/renderer/assets/main.js
./out/renderer/assets/popup.js
./out/renderer/main.html
./out/renderer/popup.html

@mhkeller Thank you for your example. Yes, it seems that my problem is related to something else. I can't determine what it is yet


Kafka <IP_ADDRESS>

I understand that it is a small patch update but for the sake of continuity are you looking to upgrade the Kafka dependency to <IP_ADDRESS>?  If not is there a reason why you holding off?

There was no particular reason to hold off, thanks for pointing that out :)

Thank you.  I really appreciate your project.


Change default behavior of default packer to better match jsonapi.org

Also make sure AMS style keeps working..

Any tutorial or help, How I can easily set up jsonapi.org 1.0 format for CRUD using default packer?


Autoplay not working

Setting autoplay to true doesn't cause the video to autoplay.

I think I may know what the problem is and I'm afraid the docs aren't clear on this one. Correct me if this is not the issue.
As it is implemented "autoplay" is not truly an auto-playback. At least not on page load. Basically that controls the Youtube / Vimeo "autoplay" option. So if it were false when a user clicks the element to open the lightbox it will be in a paused state at the beginning of the video and will require the user to click the play button to start playing. If true when the element is clicked it should start playing.
So that is the expected behavior at this point. Does that align with what you are experiencing or is it not playing after the element is clicked?

I'm going to close this based on the above assumption that the autoplay feature is functioning as designed, though perhaps not as expected. The readme has been updated to reflect the expected behavior.
If my above assumptions were incorrect feel free to comment back and re-open the issue.


Graphs - update tests for changed images

I update code to handle fonts and test images changed.  Update the images.

I updated the tests.  Close this issue.


Multiline form labels overlap input value

In alpha:

In beta:

Is it possible to fix this little rendering issue ?

https://codepen.io/Aozora/pen/XqzzWW.
You can solve it with the class truncate for the label, but yeah i think it should be the default.

You use too long labels, please see the Material Design guidelines and rules regarding labels.
https://material.io/components/text-fields

We strictly follow the MD rules.

In cases where translations sometimes make strictly-single-line labels impossible, is there no workaround to just shift the label further up to accommodate multi-line labels without truncation?


Webview tab title (tooltip) is not friendly

VSCode Version: 1.27
OS Version: Windows 10 x64

/cc @mjbvz

Does this issue occur when all extensions are disabled?: Yes/No

Shall I take this up?

Sure, I believe this needs to be changed on the webview input object: https://github.com/microsoft/vscode/blob/master/src/vs/workbench/parts/webview/electron-browser/webviewEditorInput.ts#L18
The two methods to look at are getTitle and getDescription form here https://github.com/microsoft/vscode/blob/master/src/vs/workbench/common/editor.ts#L364

@mjbvz Cool, thanks for the guidance, will start looking into it.
As indicated in the screenshot I've installed CodeStream extension. I see correct tooltip as "CodeStream".

Any other way to test the existing behavior?

From what I've understood so far, the title text is being specified as a parameter when a WebView is created. In above case CodeStream extension (I suppose) is creating a WebView without specifying title property (as on 21st Aug '18). However, since it's now showing appropriately, it should be passing the title property.
I checked using two extensions Preview and HTML Preview, both display title and tooltip similar to the way default Markdown Preview displays. I believe both extensions use webview.
Thoughts...

Is the path of a resource being used as a fallback when the name/title is not provided? I see for codestream, the tooltip seems to be coming from path of a resource.
Would it make sense to make the name/title a mandatory parameter and throw when it isn't provided?
Grabbing <title> text from html wouldn't be a good idea I think.

Please advice. Thanks for the guidance and help!
Regards,
Abhijit

Ok, this actually seems to be working now then. Here's for the cat coding webview:

The original bug was the we were showing the \webview-panel-webview-1 in tooltips, which no longer seems to be the case
Thanks for the investigation! @avannaldas Closing this since it is fixed


⚠ Bofrost.lu has degraded performance

In 4a6c1b9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1307 ms

Resolved: Bofrost.lu performance has improved in e25d9f2 after 37 minutes.


Is Discriminator working properly?

Information

Version: 6.x (reproducible on latest 6.73.6)
Packages: @tsed/mongoose

When I follow Discriminator guide on the documentation, I got confused because it doesn't seem to work as I expected.
Example
// First, have some models

@Model({ name: "events" })
class EventModel {
  @ObjectID()
  _id: string;

  @Required()
  time: Date = new Date();

  @DiscriminatorKey()
  type: string;
}

@Model({ discriminatorValue: "clicked" })
class ClickedLinkEventModel extends EventModel {
  @Required()
  url: string;
}

// Next, have a repository class
@Injectable()
export class ClickedLinkEventRepository {
  @Inject(ClickedLinkEventModel) private model: MongooseModel<ClickedLinkEventModel>;

  // and some methods for CRUD
}

// Then inject the repository in a controller and start inserting some data

Expected

[ ] Collection events created
[ ] Data inserted into this collection
[ ] type field automatically filled with "clicked" - the discriminator value

Observed

[ ] Collection clickedlinkeventmodels created
[ ] Data inserted into this collection
[ ] No type

Findings
In utils/createSchema.ts it seems that when createModel function gets called, somehow ancestorModel is undefined (not registered).
Workaround
In the repository class, if I use
@Injectable({
  deps: [EventModel] // this forces the parent model class to load first
})

Then ancestorModel is available and it works as expected. This applies for any injectable class. As long as the parent model class gets registered before it will work.

@Romakita here you go https://github.com/alexdonh/tsed-sample-discriminator

Basically discriminator enables you to have multiple models with overlapping schemas on top of the same underlying MongoDB collection.
Imagine you have a set of users
class UserModel {
  id: string;
}

class BasicAuthUserModel extends UserModel {
  username: string;
  password: string;
}

class TokenUserModel extends UserModel {
  token: string;
}

you want to have they all stored in the same database collection namedly users like this
{ "_id": ObjectId(...), "type": "basicAuth", "username": "hello",  "password": "world" }
{ "_id": ObjectId(...), "type": "token", "token": "this is a token" }

Also type have been correctly filled in the database before fix. The type field wasn't declared as a serializable property. I fixed that part there. Everything else was working as expected at mongoose level.

Please check out my fork of your repo then you will understand what I am trying to express.
https://github.com/alexdonh/tsed-example-discriminator

@alexdonh I created a simple repository and it works. Compare my example with your example pls.
see you
Romain


Switch tabs

Created two tabs, the Overdue and the Completed tasks tabs. Each of them show dynamic content when clicked and there is a visible switch between them

Thank you , Andrew.
On Fri, Sep 3, 2021, 09:00 Andrew Glago @.***> wrote:

Merged #298 https://github.com/zurichat/zc_plugin_reminder/pull/298
into dev.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zurichat/zc_plugin_reminder/pull/298#event-5251952983,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APWIMRO52P27XEOFIJFE7MTUAB6BDANCNFSM5DKEELMA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


EINVAL when writing to sysfs with "echo param > file"

Steps to reproduce:

run toybox sh
pick a file in sysfs
write a valid value to it with echo <value> > <file>

Expected behavior:
The file is written without errors.
Actual behavior:
The command fails, but the file is written.
Hypothesis:
Echo writes the argument passed to it, and the newline at the end in different write calls. This causes the kernel to try to use "\n" as the value in sysfs, which doesn't work.
Here's a snippet from strace:
$ strace toybox sh -c 'echo 0 > brightness'
[snip]
writev(1, [{iov_base="0", iov_len=1}, {iov_base=NULL, iov_len=0}], 2) = 1
writev(1, [{iov_base="", iov_len=0}, {iov_base="\n", iov_len=1}], 2) = -1 EINVAL (Invalid argument)
writev(2, [{iov_base="echo: ", iov_len=6}, {iov_base=NULL, iov_len=0}], 2echo: ) = 6
writev(2, [{iov_base="write", iov_len=5}, {iov_base=NULL, iov_len=0}], 2write) = 5
writev(2, [{iov_base=": Invalid argument", iov_len=18}, {iov_base=NULL, iov_len=0}], 2: Invalid argument) = 18
writev(2, [{iov_base="", iov_len=0}, {iov_base="\n", iov_len=1}], 2
[snip]

But if echo is called with toybox echo it works fine:
$ strace -ff toybox sh -c 'toybox echo 0 > brightness'
[snip]
writev(1, [{iov_base="0", iov_len=1}, {iov_base="\n", iov_len=1}], 2) = 2
[snip]

Ah. Standalone echo requests TOYFLAG_LINEBUF but called as a toybox builtin it can't reset the glibc line buffering because "man 3 setlinebuf" says "may be used only after opening a stream and before any other operations have been performed on it". (You'd think if you did a flush you could then change the buffer, but no. I guess it doesn't track whether you passed in a pointer or it allocated its own, so can't free it?)
Anyway, NOFORK is calling echo without line buffering, so the writes are being decoupled. Right. Hmmm... Thanks for the heads up, lemme think about this a bit.
(How on earth do I add a check for this to the regression test suite...)

Did commit 3e0e8c687eee fix it for you?
I meant to hold off on that until after the next release because I'm going to have missed a flush somewhere, but I've been meaning to do something like that for a while now anyway...
Elliott: heads up, that one's a bit intrusive.

Yup, it looks like it's fixed in master, thank you.

Elliott: heads up, that one's a bit intrusive.

thanks. i didn't get time for an update today, but i'll have a look next week. (i think relying more on stdio's defaults is a great choice though, so happy to work through the pain with you on that :-) )

I was trying to avoid "oops, I missed a flush" whack-a-mole through the entire codebase, but I guess we're confronting that. I confirmed toysh doesn't use stdio (it deals with raw filehandles because of all the redirection, there's input-side FILE * for line reading but no output to them I'm aware of), and most of the rest I can TOYFLAG_LINEBUF the command.
Another related TODO item I have is turning read_password() into read_rawline() with an extra "echo" parameter, so I don't need to explicitly fflush() before prompt strings that don't end with a newline. But that gets into "readline() supporting unicode" territory, since hexedit is using lib/utf8.c plumbing for that already. There's still some design work here, so for now I just sprayed it down with fflush() and I can grep for that and pull it back out later...
Interactive line editing and command history is the big "toyflag is ready" cliff in the minds of people who don't know the plumbing, so I've been relucant to tackle it with so many known issues still dangling in the code, but at some point I've just gotta push the button...


Dev/shopping list logic (Part2) (PRA-164)

One Line Description
Adding the logic and improving shopping list (work starts in PRA-134)
Requirements
What this code should do
This pull request prepare our shopping list to connect to backend's upcoming updates
Notes
all added functional just imitate the options that will be add with upcoming backend updates. The code still have some preparation for recounting the serving size and this logic is waiting some updates from backend. The quantity of ingredients do not counting - it will be fixed in next pull requests with new logic from backend. So all logic of rendering amount and units will be fixed in next PRs
Any additional info
Test Steps
Instructions on how to test the changes
after adding ingredients from single recipe go to the shopping list. Now you can add new ingredient, delete, change amount, clear the form, share. (after you would reload the page all this would disappear and the shopping list from backend would be rendering)
UI/UX Outcome
Attach a screenshot here
Checklist

The Linear ID is in the PR title
My code follows best practices
Documentation is included where needed

approving this. already spoke to Anna about findings upon testing:
new added ingredients don't show in the list
done!
to taste unit changes to negative digits
adressed to Backend
when adding new items 0 is showing and stubborn to remove
done!

Good job! The only comment: I suppose will be great to think and fix some CSS in next PR's because when user editing his list it is not look good for me (check field right on the border, input field far away down). But maybe it was your plan. Just to think about it.


Fix Pyblock 2.2.3

Latest pyblock 2.4 needs python 3.12.0 while RaspiBlitz has now 3.12.0 ... so we fall back onto pyblock 2.2.3
But no installing the old 2.2.3 thru pypi package it was not working because jq==1.2.2 was no longer working with our updated python environment. So I created a workaround that installes 2.2.3 from github but chnages jq manually to 1.2.3 before running install.

#4427 merged


#15061: Refactor distributed tensor config

Ticket
#15061
What's changed

Refactor DistributedTensorConfig in it's own header
Use typed struct to represent MeshShape and MeshOffset

Checklist

[ ] Post commit CI passes
[X] New/Existing tests provide coverage for changes

looks great!


Crashing on Show in Xamarin Android #44

Below are the steps I followed in my Xamarin Android project.
I have added the nuget package "Karamunting.Android.MukeshSolanki.CountryPickerAndroid" version="1.1.9" in my project.
Now I just want to display the country code picker dialog so I followed the following Csharp code
CountryPicker countryPicker = new CountryPicker();
countryPicker.Show(this.Activity.SupportFragmentManager, "COUNTRY_PICKER");
countryPicker.CountrySelect += (o, e) => {
// Perform action on click
};
App crashed on show

duplicate #44

Update to the latest version and try

There is only one version available in Visual studio 2017  version="1.1.9"

@AbhishekSinghThakur can't help you with a deprecated version as there have been 3 version updates after that which fixes a lot of issues


A $club's $net doesn't change from %done

Describe the bug, optionally with screenshots
When scrying for the $club map on the /clubs wire, and attempting to distinguish our ship's status to the club, I noticed the $net doesn't change from %done regardless of whether the $club is a pending invite, or one we left.
To Reproduce
Steps to reproduce the behavior:
I just viewed the data via a scry on /clubs wire.
Expected behavior
I expected the $net to change based on our status to the club; %invited if it's pending an invite response from us; %archive if we've left.
Currently, I'm checking the team and hive to determine our status.
Additional context:

Fake ~zod
CL
This was discovered while expanding %talk-cli's features.

Tracking internally as LAND-399


Unable to build Crystal 0.33

I have a Crystal 0.33 app on Heroku, it's worked for a while flawlessly.  However, I recently tried to push a minor change and the build broke since it installed version 0.35.1 which is incompatible with my 0.33 code.  Heroku support pointed out that I needed a .crystal-version file.  So, I created one with 0.33 in it.  I'm getting this error now:
remote: -----> Installing Crystal (0.33 due to .crystal-version file) from ... curl: no URL specified!
remote: curl: try 'curl --help' or 'curl --manual' for more information
remote:
remote: gzip: stdin: unexpected end of file
remote: tar: Child returned status 1
remote: tar: Error is not recoverable: exiting now
remote:  !     Push rejected, failed to compile Crystal app.
remote:
remote:  !     Push failed
remote: Verifying deploy...
remote:
remote: !	Push rejected to xxxxx.

So, is there a way to specify the URL with the version?  How can I fix this?
Thanks!

Please try an explicit version, so 0.33.0.

@jhass Ah, that worked! Thanks!
I noticed my shard.yml file has crystal: 0.33 in it.  Should I change that to crystal: 0.33.0 as well?

Yes, sounds reasonable. A future version of the buildpack is likely to read that property if no .crystal-version file is present.


Sign in via phone number doesn't seem to work correctly

Then I change the form to pass "telephone" and "password" to the server and I get Status 403 Forbidden.
Processing by DeviseTokenAuth::RegistrationsController#create as JSON
  Parameters: {"telephone"=>"1234567899", "password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]", "confirm_success_url"=>"http://localhost:3000/"}
Unpermitted parameters: confirm_success_url, format
Unpermitted parameters: confirm_success_url, format
Unpermitted parameters: confirm_success_url, format
   (0.1ms)  begin transaction
   (0.3ms)  SELECT COUNT(*) FROM "users" WHERE "users"."provider" = ? AND "users"."email" IS NULL  [["provider", "email"]]
   (0.1ms)  rollback transaction
Completed 403 Forbidden in 170ms (Views: 0.6ms | ActiveRecord: 1.1ms)

i have follow this how to ==> https://github.com/plataformatec/devise/wiki/How-To:-Allow-users-to-sign-in-with-something-other-than-their-email-address
The JSON response is:
"errors":{"email":["can't be blank","is not an email"],"full_messages":["Email can't be blank","Email is not an email"]}

My user.rb:
class User < ActiveRecord::Base

  devise :database_authenticatable, :registerable,
    :recoverable, :rememberable, :trackable, :validatable,
    :confirmable, :omniauthable, :authentication_keys => [:telephone]

  include DeviseTokenAuth::Concerns::User

  def email_required?
    false
  end

  def email_changed?
    false
  end
end

My application_controller:
class ApplicationController < ActionController::API
  include DeviseTokenAuth::Concerns::SetUserByToken
  respond_to :json
  before_action :ensure_json_request
  before_action :configure_permitted_parameters, if: :devise_controller?

  def ensure_json_request
    return if request.format == :json
    render :nothing => true, :status => 406
  end

  protected

  def configure_permitted_parameters
    devise_parameter_sanitizer.for(:sign_in)        << :telephone
    devise_parameter_sanitizer.for(:sign_up)        << :telephone
    devise_parameter_sanitizer.for(:account_update) << :telephone
  end
end

Just some information and a +1 for improving functionality for signing in with something other than email (or improving information/examples about doing so).
My app is set up to login using username (because I don't want to require use of an email address on my app) and I encounter this problem as well.
I haven't dug into it too deeply yet but I have been able to get sign in via POST request to work with username and password, but the User object does need to have a valid email address attribute. User objects also don't save from console without a valid email. I expect this is happening because there's a validation happening with devise_token_auth somewhere that I haven't tracked down yet. My sign in via POST request returns all the headers expected, and sets the uid to be the value of the email attribute on the User object.

Hello,
it seems that the plugin does not handle multiple authentication_keys correctly.
I need to a second field other than email and had to make some changes.
It may be of your interest:
https://github.com/lynndylanhurley/devise_token_auth/commit/95feb5d2df06d53034bbecc4a1c42f51c4160a79

Has anyone figured this out?

I got a login via phone number
ActiveRecord::RecordInvalid (Validation failed: Uid can't be blank)
there was a problem with validating the uid that it is empty
My User.rb
class User < ActiveRecord::Base
  devise :database_authenticatable, :registerable,
         :recoverable, :rememberable, :trackable, :validatable,
         authentication_keys: [:phone]

  before_validation do
    self.uid = phone if uid.blank?
  end
  .....

My migrate devise
      t.string :provider, :null => false, :default => "phone"
      t.string :uid, :null => false, :default => ""

I solved the problem and everything works as it should, I think so 💰😊
can be fixed if something is wrong 💎

@ceo-ooo-ooo it works! Nice! Thank you!


add code of conduct from bids-specs

This is not meant to be a final version in any way but having something is better than nothing. We can try to improve and go beyond the COC of bids-specs with time.

Concerning a Code of Conduct, I leave BIDS maintainers @Remi-Gau @robertoostenveld @sappelhoff decide which one is most appropriate for projects hosted on @bids-standard.

I believe there is a general one that applies to all repositories, unless explicitly overruled by a specific one. Unless there are good reasons otherwise, I suggest to stick to that one.
See https://github.com/bids-standard/.github/blob/master/CODE_OF_CONDUCT.md. I must admit that I don't know how that actually works, i.e. how the one from .github is made to apply here.

See https://github.com/bids-standard/.github/blob/master/CODE_OF_CONDUCT.md. I must admit that I don't know how that actually works, i.e. how the one from .github is made to apply here.

when opening a new issue or PR, you will see a link to the bids-standard "default" COC on the lower right, see this screenshot:

It's not very visible unfortunately ... which is why I would be okay with adding it explicitly in this repo (as is also done at the BIDS-specification repo). See https://github.com/bids-standard/bids-specification/issues/364 for more information.

I believe there is a general one that applies to all repositories, unless explicitly overruled by a specific one.
[...]
See https://github.com/bids-standard/.github/blob/master/CODE_OF_CONDUCT.md. I must admit that I don't know how that actually works, i.e. how the one from .github is made to apply here.

I do not think that is the case. This thing you have linked to is a repo named ".github" - that's not a standard GitHub feature as far as I know, and I do not think it has any effect. The ".github" functionality is a per-repo thing, where you create a directory named .github inside each repo. I do not think creating a repo named .github has any effect, and I don't think there's any "inheritance" from it to the individual organizations inside your repo.
For example, when I view the bids-matlab repo, or create a new PR against bids-matlab, I do not see any banners or links for a code of conduct there.
This is what I see when looking at the bids-matlab repo:

And this is what I see when I create a new PR for the bids-matlab repo:

I don't see any CoC references anywhere in them.
I don't see the "Helpful Resources" section that @sappelhoff saw in their PR. (Maybe you could include the URL bar to make it clearer what you're making a PR against there?)
I think you need to add the CoC to each individual repo to have it take effect.

The link is there: below the comment box at the bottom.
Remember, contributions to this repository should follow its code of conduct.

:arrow_down:

Ohhh! My eyes slid right over that, even after several re-scans of the page; that's the section for "fine print that I've trained myself to completely ignore".
I kind of feel like a doofus now, but also think this maybe means it should be featured somewhere more prominent, if it could be.

The problem is not with you definitely.
So that speaks in favor of having a COC in the repo I think. :-)

No veto on this until now so I am merging.
At least this gives a basis to improve on.


DSND-2351: Fix matching rules with repeated capture groups

Describe the changes

Matching rules with regexes that contain repeated capture group names were duplicated and edited to that each side of the OR is in a different rule
Removed the capture group duplicate renaming from the PropertiesUtils

Related Jira tickets
DSND-2351
Developer check list
General

[x] Is the PR as small as it can be?
[ ] Has the Jira ticket been updated with any relevant comments?
[ ] Is the README up to date?
[ ] Has the POM been updated for the latest versions of dependencies?
[x] Has the code been double-checked against main?
[ ] Does the code adhere standards in this repository, including SonarQube checks?

Testing

[ ] Do the code changes have unit and integration tests with code coverage > 80%?
[ ] Has the code been tested locally and/or passed the API Karate tests on Tilt?
[ ] Have mandatory manual test cases been run?
[ ] Are extra Karate tests required?
[ ] Are all the test data resources up to date?

Release preparation
Where possible, add links to the respective Jira tickets when an item is checked

[ ] Have these changes been included in a release ticket?
[ ] Are changes required to the docker-chs-development deployment or test data?
[ ] Are any changes required to the environment added to chs-configs?

Notes to the tester
N/A

CI: No security warnings found

CI: No security warnings found


Add DbRetriever class.

This change is

Coverage decreased (-3.7%) to 76.08% when pulling fbc1a41a4140bd25a0f0fa868268e9bdb4b2945d on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.

Coverage increased (+2.0%) to 81.761% when pulling 60091684f9695a867b9605540d026861725d8a39 on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.

Coverage increased (+2.6%) to 82.424% when pulling aa5167704d568d2a10de18e82eebec267d216a57 on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.

Coverage increased (+2.0%) to 81.761% when pulling 360fac2c93728ac79ed4aa1ed280f8b02fe03c7b on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.

Coverage increased (+3.0%) to 82.789% when pulling a2139fc196d10bf7f74f89adc8330ee9808cedda on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.

Coverage increased (+3.0%) to 82.789% when pulling f6e41516ce748638cb8769754172094c07842a32 on db_retrieval into a86ad4beb769cdf7c737b9f506ff551dc1345dc2 on master.


Create StockFuelSwitch.netkan

Fix license, dependencies and install stanza.
Closes https://github.com/KSP-CKAN/NetKAN/pull/1265.

to many commas on lines 9 and 12


Rename variable in async example code snippet

rename variable in Index.cshtml.cs to indicate it represents a collection

Hello @gnerkus ... This can't be addressed this simply. For one thing, the property declaration also requires an update. More importantly, the article might make in-text references to this code and also require adjustment for the change.
Open a new issue from the bottom of the article using the Open a documentation issue link/feedback form. Use of the form adds metadata to your GitHub issue that cross-links the topic and pings the author automatically for a faster response. When the doc author responds (Wade I think), you can float your suggestion for this. If he approves the change, he'll direct you further from there on if the article also requires updates. If you're able to proceed with the update, you'll add "Fixes XXX" with the issue number to link the PR to the issue.


Binance support

This PR contains fully working (basic) support for Binance.
This does not include tests at this stage

My personal style is a little more whitespacey than PEP-8 likes. I tried to match your style in this, but missed a couple.


Remove single instance attribute in AndroidManifest for the ghost activity

This PR applies the suggested changes in #143
@nex0s, @ultraon, @EmmettWilson can you see if this change addresses the issue you were having?
The rationale behind the original setup was to stop worrying about creating more than one inner activity (or ghost activity) which is what Dexter uses behind the scenes to ask for permissions. I've been doing some testing myself and looks like there is no way of creating multiple inner activities anymore (I've been rotating the device in every single step, pressed the back button and so), what's more, if a new activity is created then Dexter will replace its reference to point the new one and the old one should be flagged to be removed.
Let me know if you can find any problem with this solution.

It fixes my issue ! Thank you so much

I think this solves the duplicate entry in overview where the DexterActivity was in its own task. I am concerned about the case where we have multiple DexterActivities opened in different tasks through implicit intents or deep links (think Barcode scanning or camera app). I do not think that this needs to be handled in this PR, but allowing multiple DexterActivities introduces the possibility that pending permissions requests within a backgrounded task stack get orphaned.


Element with animation disappears after animation when using hyperlink to get to it instead of scroll

When scrolling, the animation works perfectly fine. While if you use your navigation to jump to the container with animation, the container disappears immediately after the animation ends. This behavior is not consistent, it happens about 50% of the time.
The setup is correct as per instructions. As mentioned above, the animations work fine when scrolling is used.
This is:

Bug

Specifications

AOS version: 2.3.1
OS: Mac High Sierra
Browser: Chrome 69.*

Expected Behavior
I assume that even when I jump to the container using a link, the animation should run and the container should stay visible as it does when scrolling.
Actual Behavior
When using navigation to jump to the container, the animation run as it should, but as soon as it's finished, the container disappears. This behavior is not consistent. The container disappears after animation about 50% of the time.

Seems like it was another animation library interfering with aos.


support Encointer as known-chain

I tried to do a PR already, but I'll need info on how to generate the chain spec with lightClientState and possibly hints on what needs to be done to support Encointer
our chainspec can be found here, but it features genesis, not light client state
https://github.com/encointer/encointer-parachain/blob/master/node/res/encointer-kusama.json

but it features genesis, not light client state

actually, light client state is only relevant for relay-chains.
The only thing that we should change is the fact that the genesis.raw should be replaced with the genesis.stateRootHash. I will open a PR soon with this change.


Command Palette Text missing

I am using angularjs 1.x with angularjs material.

monaco-editor version: 0.19.3
Browser: Chrome, Firefox
OS: Ubuntu 19.04
Playground code that reproduces the issue:

@alexdima How can i fix it

Did not found any solution here https://github.com/Microsoft/monaco-editor/issues/263

FIxed using
.monaco-tree-rows .content {
    padding: 0;
    margin: 0;
}


fix(console): policy reset for custom, header org filter, idp add dialog

:tada: This PR is included in version 0.95.1 :tada:
The release is available on:

GitHub release
v0.95.1

Your semantic-release bot :package::rocket:


"Warmed cached tokens" message interferes with prompt

Issue
While typing a prompt, the "warmed cache tokens" message gets printed on top of the prompt as I'm typing
Version and model info
aider 0.54.4
sonnet

Good point. I've changed that message to only show with --verbose.
The fix is available in the main branch. You can get it by installing the latest version from github:
python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

@paul-gauthier, your workrate is phenomenal! You addressed this issue so fast. Thanks for your work on this project.
I've installed the latest version, for the record I prefer to install it using pipx as you recommend in your documentation. For the latest version I use
pipx install --suffix=@dev --force git+https://github.com/paul-gauthier/aider.git
```
and then I can run it using

```
aider@dev
```

I'll close this after I test it for a while and make sure the issue is fixed

I tested @paul-gauthier 's fix above, it seems to have worked. Thanks Paul!


We are facing continues looping in Player Listener

Media3 Version
Media3 1.1.0-alpha01
Devices that reproduce the issue
Redimi 10
Vivo
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
No
Reproduction steps
1.Initialize the player with Simple Cache
2.release the player
3.again inintialize the player with Simple Cache
do this 10 to 15 time continuesly
Expected result
The media should play normally
Actual result
We are facing continues buffering state and state ready, video is flickering.
Media
Please find attached video for your reference, this video shows how flickering was happeining
https://github.com/androidx/media/assets/45714712/802465a3-abf0-4be7-adad-2372fe82f4c6
Bug Report

[X] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Any Update?

This looks like a duplicate of https://github.com/google/ExoPlayer/issues/11233. Please close either that one or this one.
In neither issue is there enough information to investigate (it's very unclear how you've set up the player, what you expect to happen, and what you actually observe (despite the video)) - please provide a minimal reproducible example that demonstrates the problem in a way that we can build locally. Ideally you would fork our demo app, make the changes to reproduce your issue and then send us a link to the fork.


refactor: use builder in build

Description
Alternative to #18028

Removes builder.entireApp and use builder: {} / builder: undefined (this one can be discussed separately if needed)
Introduce a internal concept of legacy builder that just works like build and use that from the CLI

This makes the createBuilder a bit complicated but the overall code size is smaller and improves CLI-JS API symmetry.
Migration Plans
This PR does not change any behavior. Later on we make builder: { sharedConfigBuild: true } to be the default and remove the codes related to the legacy builder.

For CSR only apps: no migration needed
For CSR + SSR apps using vite CLI

No change is needed for Vite 6, but can opt-in to using builder by passing --app or setting builder: {} in the config
When the legacy builder is removed, users can remove --app but that change is not necessary (we should just ignore the flag)

For CSR + SSR apps using build command

No change is needed for Vite 6, but can opt-in to using builder by using createBuilder
When the legacy builder is removed, users need to migrate to createBuilder from build

@patak-dev @bluwy What do you think about this one?

This approach looks good to me! Thanks Sapphi for exploring this option.
I was thinking we could move some props later on from build to builder, for example copyPublicDir, but we can delay this until everyone is using buildApp. This, thinking in a future where nobody wants to use Vite to build a single environment (and if they want, they just configure it with a single environment, but there is no more build() a part).
If we don't think that will ever be possible, maybe we could use { builder: { entireApp: true }} for the option, but using the implementation proposed here.

I like this approach too, so IIUC the programmatic API to reflect vite build and vite build --app would be createBuilder({}, null).buildApp()? It's a little clunky, but I think it's fine since it's only a stop gap for this major.

so IIUC the programmatic API to reflect vite build and vite build --app would be createBuilder({}, null).buildApp()?

Yes.

Once createBuilder() stabilizes, would we phase out build()?

I think yes.


Mhassanin/feature dashboadrs cli

Deploys Application Insights dashboards using az cli command
The dashboard json file describing the dashboard was obtained by exporting a manually created application dashboard that includes the custom metrics of interest to the Retro tool operator.
The exported json file was obtained by using az portal dashboard show command to spit out a json description of the manually created dashboard. The resultant json description was further parametrized by resource-group ,subscriptio-id and ai-resource-name to make it generic.
The dashboard description file is ai-dashboard.json.template
It is copied every time a new deployment is initiated

That is strange behavior on MacOs. good catch.


net: sockets: Implement getnameinfo()

net: sockets: Implement getnameinfo()

This function is the opposite of getaddrinfo(), i.e. converts
struct sockaddr into a textual address. Normally (or more
specifically, based on the flags) it would perform reverse DNS
lookup, but current implementation implements only subset of
functionality, by converting to numeric textual address.

Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Codecov Report

Merging #13201 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13201   +/-   ##
=======================================
  Coverage   48.75%   48.75%
=======================================
  Files         319      319
  Lines       46871    46871
  Branches    10835    10835
=======================================
  Hits        22850    22850
  Misses      19394    19394
  Partials     4627     4627

Impacted Files
Coverage Δ

include/net/socket.h
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a96312...8597779. Read the comment docs.

Will upload new version.

@nashif : Perhaps this can be merged?
If not, ping @tbursztyka


Add contributing + dev info, fixes #30

Add CODE_OF_CONDUCT.md
Add .github/contributing.md
Add doc/development/ pages

contributors.rst
index.md
commit abbreviations

Add development/index to toctree in doc/index.md

Codecov Report
Base: 94.17% // Head: 94.02% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (f47b768) compared to base (28fd136).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   94.17%   94.02%   -0.15%
==========================================
  Files          39       39
  Lines        1407     1407
==========================================
- Hits         1325     1323       -2
- Misses         82       84       +2

Impacted Files
Coverage Δ

tests/test_data.py
98.40% <0.00%> (-1.60%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


xdr: update XDR for soroban pubnet release

We don't expect any impact from those changes (see https://github.com/stellar/soroban-tools/issues/1000#issuecomment-1746496913 ), but it needs to be done

encompasses all XDR changes:

go
soroban-tools
bump core library


Update with some info

@aimsbrain Thanks. As I said in your other PR, normally it is good to have a detailed description for a PR as hopefully stated in most CONTRIBUTING.md files. See https://facebookmicrosites.github.io/fbmentorship/docs/en/contributing-best-practices.html
For example, this one may have done well with better context. Update what, for example.


naabu: 2.1.7 -> 2.1.8

Diff: https://github.com/projectdiscovery/naabu/compare/refs/tags/v2.1.7...v2.1.8
Changelog: https://github.com/projectdiscovery/naabu/releases/tag/v2.1.8
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256754 run on x86_64-linux 1

1 package built:

naabu


feat(view): view.changeData API, update the geometries

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines
[x] view.changeData API

Description of change


Decide on Subset of Rocket.Chat Settings to Expose

What all settings inside of Rocket.Chat should be exposed?

[ ] Message size limit

Suggestions would be fantastic.

Decided on going the route of disallowed settings and right now it is hard coded. However, in the near future it will be converted to a setting inside of Rocket.Chat which will be a comma separated list...


[requires.io] dependency update on master branch

This looks fine but why do the builds fail?

Pillow wasn't available yet on the Conda channels, which caused the Conda installation to fail. Pip then tried to install all the packages that were missing, but probably failed with h5py because it requires C libraries.


[WeatherObserved] Creation of attribute uVIndex

I suggest the creation of the attribute uVIndex since there are weather observation devices that measure the UV index.

Hey all,
any update on this?
I volunteer do work on this and issue a pull request,  if there an agreement in inclusion of such atribute in the datamodel.

move this issue to https://github.com/smart-data-models. please

I would gladly do it, but unfortunately I don't have permissions to do it. Can you do it or give permissions to do it?
Thank you.

Im closing this issue in favor of this one.


Need Help

Why am I have this import error

Please use the search function, other issues like #51 already talks about this error.

https://github.com/PokemonGoF/PokemonGo-Bot-Desktop/issues/51#issuecomment-236888095


Error handler context deprecated

The context argument for error-handlers was depreacted in 7.2, and probably should be removed?
I've asked on the PHP internals mailing list, and, sadly, it doesn't sound like they were planning on offering any alternative to this feature.

I've done a little bit of digging here and there, and luckily this seems a non-issue for us! :tada:
In the 2.0 branch that argument is not used:
https://github.com/getsentry/sentry-php/blob/2.0/src/AbstractErrorHandler.php#L157
...since the only variables values that we send are function arguments, which are taken using debug_backtrace:
https://github.com/getsentry/sentry-php/blob/2.0/src/Stacktrace.php#L77
So, yay! Thanks for digging this up anyway, your help is appreciated.

2.0 branch?? Hello! doc-blocks, type-hints, abstractions, dependency-injection! nice! 😄👍
Closing this issue, thanks.
Any idea when 2.0 will be ready?
I'm integrating Sentry into a very modern PHP stack with PSR-7/15/17 middleware etc. and the current version is not a very good fit. This looks promising!
This looks substantially different, so I probably shouldn't spend a lot of time working the old version into our stack?
Is it far enough along that it would make sense to start testing and integrating version 2 instead, do you think? We don't expect to need this in production before March'19. I might be able to provide you with some useful feedback.


Json.tryParse throws away parse error

Wouldn't it be a good idea to type it all in Choice<,> instead of Option<>? That way your can pass errors on outside the Json monad.

Both tryParse and tryDeserialize could sanely return Choice rather than Option, I agree. At this point, the only reason I hadn't was sticking to what seems to be an F# convention around try* functions returning options, but I think this is a case where it's perfectly reasonable to ignore that convention in favour of a more useful outcome. I'll change this when I get home later on.

So, Chiron 3.0.0 is out! And tryParse and tryDeserialize now return Choice<,> rather than Option<>. Hopefully a useful change!

Very nice ;)


use available brand icons for New Relic agents when applicable

Summary
The list of New Relic instrumentation shows that the majority of the official New Relic agents don't have a logo (see screenshot). The grid of cards with the same logo could make it hard to find what you're looking for.
Possible Solution
Perhaps we can use each language's logo for these. It would help this page feel a little more interesting and provide more value to a user as these branded icons are recognizable.
Acceptance Criteria

[ ] When applicable show the correct brand icon for any instrumentation project that has a corresponding icon.
[ ] For example, all apache projects would use the apache icon foundhere
[ ] If a branded icon isn't available continue to use the generic box icon
[ ] The goal is to replace the generic box icon (when applicable) with the correct brand icon if available in our icon directory

Additional context

common language Logo files are available here: https://github.com/newrelic/docs-website/tree/develop/src/%40newrelic/gatsby-theme-newrelic/icons/logo

I want to work on this issue

@Nitesh-Singh-5 we'd love for you to contribute this feature, let us know how we can assist. cc @rudouglas  👋

can you suggest me ways to started ?

@Nitesh-Singh-5 delighted to hear you want to contribute. For this, as we don't currently have a centralized place for logos, you may need to copy them from here into the repo. I don't want to give you too much help in case you'd rather figure things out yourself, but feel free to reach out with any and all questions 😀

@Nitesh-Singh-5 To add to @rudouglas suggestions, I've clarified the acceptance criteria which is how Product managers help communicate what is expected from engineers. It's a great exercise for you to work through this and feel free to ask any clarifying questions or provide a draft PR if you have a solution you want us to review. And thanks for the interest in contributing!

@Nitesh-Singh-5 are you still working on this?

if @Nitesh-Singh-5  is not working on this I can help to Close this issue. Let me know

@rafaelcdelgado Feel free to take this on! We appreciate the contribution.

@rafaelcdelgado Feel free to take this on! We appreciate the contribution.

Awesome, will work on this this week. Thanks.

Sorry guys, Got Covid but back on track...

@rafaelcdelgado no worries! I hope you are feeling better. 🙏

There seems to be two approaches so far there's adding an icon.png to the repo, Roku Example and uploading user generated content, iOS Example.


fix: apply extension only to mail page UI

Can you check if this fixes the issue in https://github.com/team-inbox/inbox-reborn/issues/85 ?

@deepfriedfilth I merged it but will wait for the next merge to post it on the Chrome store.


GNOME 40: gtksourceview4 and yelp-tools fixups

Motivation for this change
Reverts gtksourceview and fixes building yelp-tools.
I'll try fixing tracker tomorrow.
For #117081
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117138 at 805a947d run on aarch64-linux 1

5 packages marked as broken and skipped:

gnome3.gnome-books
gnome3.gnome-documents
gtkd
spotifywm
tilix

1 package failed to build (new failures):

gtksourceview4 (gnome3.gtksourceview4)

107 packages skipped due to time constraints:

adapta-gtk-theme
ajour
bluefish
chrome-gnome-shell
cinnamon.cinnamon-common
cinnamon.cinnamon-screensaver
cinnamon.muffin
cinnamon.xviewer
denemo
empathy (gnome3.empathy)
...

1 package built successfully:

yelp-tools (gnome3.yelp-tools)

4 suggestions:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/gtksourceview/4.x.nix:29:15:
   |
29 |   patches = [ ./4.x-nix_share_path.patch ];
   |               ^

warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/development/libraries/gtksourceview/4.x.nix:34:3:
   |
34 |   checkPhase = ''
   |   ^

warning: unclear-gpl
lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/gtksourceview/4.x.nix:52:5:
   |
52 |     license = licenses.lgpl21;
   |     ^

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.
Near pkgs/development/libraries/gtksourceview/4.x.nix:31:3:
   |
31 |   enableParallelBuilding = true;
   |   ^

The failure is expected, tracker doesn't build right now.

Thanks.


Ingress Controller not applying WAF Policy

Describe the bug
Following documentation here: https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/annotations.md#azure-waf-policy-for-path
Trying to Add a policy to an ingress
To Reproduce
Ingress controller below, everything else works as it should can access the UI but policy never gets applied and can't see any logs
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: $(ncnamelower)
annotations:
kubernetes.io/ingress.class: azure/application-gateway
appgw.ingress.kubernetes.io/backend-protocol: "https"
appgw.ingress.kubernetes.io/backend-path-prefix: "/"
appgw.ingress.kubernetes.io/waf-policy-for-path: "/subscriptions/c2d12071-f2ec-4947-8022-678f59ac26d9/resourceGroups/UK-WAF-POLICIES/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/UKWafPolicy"
spec:
tls:

hosts:

$(URL)
secretName: $(SSL)
rules:

host: $(URL)
http:
paths:

backend:
serviceName: $(ncnamelower)
servicePort: 443

@akshaysngupta your best prob as you did the coding for it

@Danlewis3
TLDR;
To resolve this, Add following in your helm config:
appgw:
  waf_listener: true

This will assign the WAF policy at the listener level instead of path level.
Issue:
When an ingress has a simple rule with path: /, then a basic routing rule is created on Application Gateway. In a basic routing rule, when waf-policy annotation is used, WAF policy is supposed to be assigned at the listener.
In current implementation, WAF policy is applied at path level only when a specific path is used (ex: /app) as this leads to creation of a Path-based routing rule on App Gateway.
Bypass
In order to bypass this missing piece, please use the following in your helm config:
appgw:
  waf_listener: true

Here is how this key is currently implemented.
https://github.com/Azure/application-gateway-kubernetes-ingress/blob/bd619a175318cbb2cecaf3e966313897571ea675/pkg/appgw/frontend_listeners.go#L120

When adding the line above to Helm-config the pod fails to get become online as the readiness health check doesn't work

Readiness probe failed: Get http://<IP_ADDRESS>:8123/health/ready: dial tcp <IP_ADDRESS>:8123: connect: connection refused
appgw:
waf_listener: true
subscriptionId: c2d12071-erdf-4947-8022-678f59ac26d9
resourceGroup: WAF
name: AKS
usePrivateIP: false

@Danlewis3 If AGIC pod is failing to come up, can you check the AGIC pod logs for any visible errors?

Readiness probe failed: Get http://<IP_ADDRESS>:8123/health/ready: dial tcp <IP_ADDRESS>:8123: connect: connection refused
This is what we get on the pod with the line specified


⚠ Bofrost.fr has degraded performance

In 850924a, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1491 ms

Resolved: Bofrost.fr performance has improved in dc3f52a after 16 minutes.


Move EntryFactories back into Core

This core development feature requires a dev (typically) dependency.

Done in core


JBPM-5591 - Pluggable task assignments

depends on https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/201
@krisv main work done in here... and description and some details can be found at http://mswiderski.blogspot.com/2017/01/distribute-tasks-wisely-pluggable-task.html

jenkins retest this

jenkins retest this

@livthomas updates done

Jenkins retest this

Overall +1
Two open questions (can be addressed later):

is it sufficient to make this a system property?  this will mean all kjars will be using the same rules (this means I guess that either assignment strategy should be the same or the rules would have to make the distinction somehow).  Wondering if a more project-based configuration (deployment descriptor) might be possible as well, although I realize this might not be trivial.. Maybe add some additional logic where assignment service can cache multiple kbases, pluggable strategy to select a kbase based on deployment id?
I think we should make some more out-of-the-box strategies that people can use, like round-robin, geography or skill-based, etc.

Wdyt?

Yes , the strategy by design is global but you have always an option to create strategy that includes other strategies sort of container approach. When it comes to per kjar that can easily be done with rules and filter by deployment that is available on inserted task instance.
More strategies out of the box - fully agree. We just need to identify which one should be there and start adding them where one should be based on optaplanner as that can later on be used for further extensions. Round robin strategy sounds really similar the the potential owner busyness so not sure that will have much value. geography sounds ok but what should this be based on? Like variable on a task or? If so then best to do this is actually via rules again...


refactor(*): change naming convention, fix flag-service DDD

This is a proposal to change the naming convention to something more readable and more useful, especially for people new to the project. Most classes should be defined in their own single class file, while in certain cases it is relevant to have many definitions in a single file (for example error classes).
The following specs are added in README.md:
Naming conventions
We use DDD (Domain Driven Design) principles.
Files are sorted in folders that make a domain structure. Example: flag/pixel/Pixel.ts is located in the domain pixel which is a subdomain of the domain flag.
Test files are located in a spec folder inside the domain folder they relate to. Example: all tests of stuff in the domain flag are located in flag/spec/.

Files defining a single class are named after the class (PascalCase). Example: FlagRepository.ts is expected to contain the definition of the FlagRepository class.
Other files are named after their content relative to their domain. Example: flag-errors.ts is expected to contain many error classes that are used in the flag domain.
The entrypoint is named main.ts.
Test files are named after the class (PascalCase) or domain (kebab-case) they test and end with .spec.ts. Example: FlagController.spec.ts is expected to contain all tests of the FlagController class.

Should the Most classes should be defined in their own single class file, while in certain cases it is relevant to have many definitions in a single file (for example error classes). be included in the readme?


feat: more lemmas about the cocompact filter on topological spaces with a continuous multiplication and zero

Let M be a topological space with a continuous multiplication operation and a zero. We prove the following lemmas.

tendsto_mul_nhds_zero_prod_of_disjoint_cocompact: Let l be a filter on M which is disjoint from the cocompact filter. Then the multiplication map M × M → M tends to zero on the filter product 𝓝 0 ×ˢ l. (We also prove a variant with the order of the product swapped.)
tendsto_mul_coprod_nhds_zero_inf_of_disjoint_cocompact: Let l be a filter on M × M which is disjoint from the cocompact filter. Then the multiplication map M × M → M tends to zero on Filter.coprod (𝓝 0) (𝓝 0) ⊓ l.
tendsto_mul_nhds_zero_of_disjoint_cocompact: Let l be a filter on M × M which is disjoint from the cocompact filter and less than or equal to Filter.coprod (𝓝 0) (𝓝 0). Then the multiplication map M × M → M tends to zero on l.
Tendsto.tendsto_mul_zero_of_disjoint_cocompact: Let f : α → M and g : α → M be functions. If f tends to zero on a filter l and the image of l under g is disjoint from the cocompact filter on M, then fun (x : α) ↦ f x * g x also tends to zero on l. (We also prove a variant with the order of the product swapped.)

These lemmas were suggested by a reviewer comment on #12313: https://github.com/leanprover-community/mathlib4/pull/12313#issuecomment-2124740887. These lemmas are intended to simplify the proof of tendsto_mul_cocompact_nhds_zero in #12313, which states that if f : α → M and g : β → M are continuous functions that both tend to zero on the cocompact filter, then the "outer product" fun (i : α × β) ↦ (f i.1) * (g i.2) also tends to zero on the cocompact filter.

[x] depends on: #19718
[x] depends on: #19717
[x] depends on: #19716

Thanks for the comments. I have made the edits.

bors r+


fix: update peer dependency to allow future semantic release versions

fixes #107

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update mkdocs

Things I'm seeing so far:

The edit/view link is wrong (with the current version actually)
Previous theme (readthedocs) isn't used
The versions list is covered by the header of the mkdocs theme when there are a lot of versions (this is a problem with our z-index)

Closes #5332

is a problem already present, we can fix that in another PR
I think this is what we want, but I can deep a little more if we are correctly editing the mkdocs.yml file
This is only present when the user has a lot of versions, we can fix it later or in another PR I think

We are still fine defaultding to
https://github.com/rtfd/readthedocs.org/blob/719f3ca7752c66a0fd3d89043eec2a62dae430de/readthedocs/doc_builder/backends/mkdocs.py#L92-L94

docs_dir is still valid

The directory containing the documentation source markdown files. This can either be a relative directory, in which case it is resolved relative to the directory containing your configuration file, or it can be an absolute directory path from the root of your local file system. default: 'docs'

extra_js and extra_css are still valid
https://mkdocs.readthedocs.io/en/latest/user-guide/configuration/#extra_css

The theme
https://github.com/rtfd/readthedocs.org/blob/a639939b77b3ec803abb8dcf749a1d6d7d9d8254/readthedocs/doc_builder/backends/mkdocs.py#L182-L187
I think we put that feature flag only to old projects, right? If so, we can just leave that code as is, new projects should set explicitly the readthedocs theme.

From the floating footer, our z-index is 400, the z-index from the mkdocs header is 1030. That's the problem.

Our z-index came from https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/core/static/core/css/badge_only.css, not sure from where we generate that min file.

Got it, it comes from https://github.com/rtfd/readthedocs.org/blob/a639939b77b3ec803abb8dcf749a1d6d7d9d8254/gulpfile.js#L27-L27
Whici comes from https://github.com/rtfd/readthedocs.org/blob/a639939b77b3ec803abb8dcf749a1d6d7d9d8254/bower.json#L20-L20
We should update the theme in the dependencies, I guess? Or do we want to follow another approach for mkdocs?

I'm not sure how we can setup this https://github.com/rtfd/sphinx_rtd_theme/blob/ddfdd35e6977f21fb1771734732756b0cf1d6bba/sass/_theme_badge.sass#L9

not sure from where we generate that min file.

I believe it comes from the RTD sphinx theme. However, the badge_only.css isn't the full sphinx theme CSS. It is only for the flyout menu.

I think we put that feature flag only to old projects, right? If so, we can just leave that code as is, new projects should set explicitly the readthedocs theme.

The big issue is that users can pin to 0.17 or 1.0 in the requirements.txt file. When they do, we have to be very careful of any changes we make to the mkdocs.yml file (the fewer the better, IMO) since many aren't compatible between versions.

The big issue is that users can pin to 0.17 or 1.0 in the requirements.txt file. When they do, we have to be very careful of any changes we make to the mkdocs.yml file (the fewer the better, IMO) since many aren't compatible between versions.

I get it, the issue is with users with the feature flag and without a pinned version of mkdocs, their projects will fail or have the other theme, I'm not sure how new versions of mkdocs handled that deprecated setting.

@stsewd not sure what the status here is? I imagine users can already install this version via requirements, so we mostly just need to make sure it doesn't break horribly for everyone when we upgrade. I guess if users aren't pinning it currently, they might get invalid config errors from the upgraded version? Not really anything we can do about that, sadly :/

I guess if users aren't pinning it currently, they might get invalid config errors from the upgraded version? Not really anything we can do about that, sadly :/

Yeah, the only affected users are the ones with the flag, I think we put that flag on all the projects of .com.
So if the projects have the flag, and they don't have the theme option set, they will not be able to use a newer version of mkdocs/their build will fail.

I don't think we used the flag in .org, so here we are safe.

Also, the current mkdocs version that we install doesn't work with python 3.7 (the default version that we install)

Putting a feature flag for old projects makes sense, but it also makes the feature flag to be around for ever, projects will break if they don't pin their requirements or keep updating their docs the latest version of mkdocs supported. Same for sphinx, we update sphinx quicker, that's why we don't have many users yelling at us, they update progressively.

Putting a feature flag for old projects makes sense, but it also makes the feature flag to be around for ever,

Unfortunately, yes. We need the feature flag until we decide to drop support for old mkdocs versions.

Well, this change doesn't mean to stop supporting old mkdocs versions, projects should still work, only projects that have a mkdocs.yaml file with incompatible settings in 1.0 and without a pinned version will fail.

Feature flag was added, how do we manage this? Do we create the feature flag with deafault_true=True in a migration or from the admin?

Do we create the feature flag with deafault_true=True in a migration or from the admin?

Not sure if we create a migration, or just make that setting True when we create it in prod. A migration feels like the best option, so it doesn't depend on a step during deploy other than running migrations.

We have been creating the feature flag when deploying as far as I know. We will need to do this twice: community and corporate, though.

I was thinking, creating the feature flag with now (at migration time) looks weird (for new instances of rtd). Putting an exact date of the deploy is kind of guessing and not exactly at the same time of the webs (and it will be weird for new instances of rtd).. So, I'm +1 to create it after the deploy.


match keyword works incorrectly when '##null' is used in json

Match keyword seems to work incorrectly when there is a '##null' in the json.
Example 1:
The match step in this example seem to work correctly ie fails with the message actual value has 1 more key than expected.
    * def expected = {"a":1,"b":2}
    * def actual = {"a":1,"b":2,"d":3}
    * match actual == expected

Example 2:
The match step in this example passes whereas it should have failed with the same message as above:
    * def expected = {"a":1,"b":2,"c":"##null"}
    * def actual = {"a":1,"b":2,"d":3}
    * match actual == expected

Karate version 0.9.2

@vidz2 thank you very much for this - it was a nasty one. it should be fixed, would be great if you can build from source and check

@ptrthomas I have build from source and can confirm that the fix worked.
Thanks so much for the quick turnaround.

released 0.9.3


Suggestion for improving directory loading performance

Dear developers,
We are applying our performance diagnosis tool PerfProbe to debug the user-experienced latency for loading a directory in Riot app and observe that loading particular directory (such as Riot or Matrix HQ) takes long time (on average around 28 seconds and sometimes as long as 66 seconds to load Riot directory in my setup). Through its system-wide profiling and tracing, PerfProbe discovers that besides server-side delay for network requests, another major source of extra delay results from the execution of Android's API call android/graphics/BitmapFactory.nativeDecodeAsset on the main thread (for example, one invoked by im/vector/activity/VectorRoomActivity.onCreate -> android/support/v7/app/AppCompatActivity.setContentView), likely due to the computation resource bottleneck for decoding some bitmaps (longer wait time for computation resource is observed when the delay for BitmapFactory.nativeDecodeAsset increases).
We localized to Riot's source code based on above diagnosis result and discovered that the delay for the API call "BitmapFactory.nativeDecodeAsset" may be due to loading large bitmaps (e.g., vector/src/main/res/drawable-xxhdpi/vector_search_bg.png with size 67KB) for rendering im.vector.view.VectorOngoingConferenceCallView during the method call "setContentView(R.layout.activity_vector_room)" inside method "onCreate" of vector/src/main/java/im/vector/activity/VectorRoomActivity.java. Bitmap loading operations are usually memory-heavy and computation-intensive.
We hope our findings can be helpful for your debugging. We are also interested in helping improving the performance of this interaction. One suggestion is to load a scaled-down version of bitmap into memory based on Android's developer guideline (Loading Large Bitmaps Efficiently). Thank you very much for your attention and clarification!
Related issues: 452, 541,
Expected behavior
Consistent and small delay for loading a directory
Actual behavior
Intermittently significant increase of delay for loading a directory
Steps to reproduce

Click "Browse directory"
Click a directory (e.g., Riot)
Wait for the directory to be loaded

Environment
Riot version: 0.6.9 from Google Play
Android version: Android 4.4.4
Device: Nexus 4

Thanks for your acknowledgement! I would like to perform some optimization on the source code to validate the performance improvement. Could I make a pull request?

@perfprobe
yes, you can make a PR with the optimised code.

@ylecollen Thanks very much for your reply! I will make a pull request once the optimized code is tested to show performance improvement on my side.


the text in the terminal is invisible. I can still operate, but I can't see what is typed and I can not see output either

ADD ISSUE DESCRIPTION HERE
Version: 1.73.0
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.3 Safari/605.1.15
Embedder: codespaces

disable terminal.integrated.gpuAccleration as it's not supported on certain versions of safari
/duplicate #165416


little question

does backdoor.py have to be with keylogger.py? and how do we set the listening port for the server ? i already have port forwarding and a dns

Mr. I have a problem, I can't use cmd command but whoami can execute it.


Thread-safe?

This code doesn't appear to be thread-safe and that's an important part of Rx.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd9b221a-156f-fcbb-f853-374b8a567ea8
Version Independent ID: 8c32046d-1f4d-7328-de46-d578e250aa83
Content: How to: Implement a Provider
Content Source: docs/standard/events/how-to-implement-a-provider.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @gewarren
Microsoft Alias: gewarren

Agreed, perhaps a ConcurrentBag<> is a viable alternative to the use of List<> here.


DALL-E not working

OpenAI text and Gemini work perfectly, but when I try Dall-E, it just post Hi It's WAAI BOT here 🤖
I've tried removing and re-linking everything again, but still get same message.

As listed in the disclaimer only the following models are supported so far, wait for its support

@rikuddo91 available now https://github.com/Zain-ul-din/whatsapp-ai-bot/commit/890f7c245053ba8f52bddb3a6faa5e1dbad42ea9


Update Spring Boot to 1.3.3

Ups, there is a failing IT test, please do not merge

Failed tests:
  ControllerIT.OSNG-467: A request to revoke access tokens of a given user should invalidate his token:303 Condition not satisfied:

validationResult.expired == false
                  |       |
               true    false

All ITs are green, my fault


Bug: Parameters issues

Describe your issue
Hello,
Thanks for this project!
I've just installed it on Windows 11 with Node 20 and I noticed that the command provided as an example returns an error:

> npm run grab -- --site=chaines-tv.orange.fr
Error: One of the arguments must be presented: --site or --channels

To make it work, I have to type:

npm run grab -- -- --site chaines-tv.orange.fr

Notice the double --, as well as the space between --site and the site name.

If you use PowerShell then it should npm run grab '--' --site=chaines-tv.orange.fr.


ca_impl_openssl: support CRL distribution point from config

Only "http://localhost/crl.pem" was used although the configuration is defining a setting for this
Signed-off-by: Karsten Ohme<EMAIL_ADDRESS>

/packit retest-failed

/packit retest-failed

I have no idea how the first failed test relates to my changes.

I have no idea how the first failed test relates to my changes.

It wasn't sometimes the e2e test can fail due to various reasons, if most of the other distributions pass it is a good indicator that the failure is temporary.


rf-listen started second time does not report packets (spi-init related?)

I noticed that after stopping "rf-listen" by keypressd and restart, it does not report packet anymore. The same happens when before start for first time "rf-listen" i call "spi-init" (that is already in "rf-init").
It happens on both TinyExtender hardware and jz4.

This is because rf.mode does not get reset and as a consequence rf-recv thinks the radio is already in RX mode the second time around when in fact it has just be initialized and sits in sleep mode. This is fixed in my PR #67 (line 91).


Reduce memory consumption of generator v1

We currently create copies of the v1 generator for every template including the propability distributions. We should refactor the v1 generator such that it uses a vector of templates instead of just one (use round-robin). Then we don't need to create copies of the generator and probabiliyt distributions and save memory.

done


Automated cherry pick of #4581: fix: 修复zstack安全组创建失败问题

Cherry pick of #4581 on release/2.11.
#4581: fix: 修复zstack安全组创建失败问题

/lgtm
/approve

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@0184708). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #4586   +/-   ##
==============================================
  Coverage                ?    7.1%
==============================================
  Files                   ?     480
  Lines                   ?   78151
  Branches                ?       0
==============================================
  Hits                    ?    5554
  Misses                  ?   72131
  Partials                ?     466

Flag
Coverage Δ

#aFlag
7.1% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0184708...a51ca97. Read the comment docs.


python311Packages.google-cloud-automl: 2.11.3 -> 2.11.4

Changelog: https://github.com/googleapis/google-cloud-python/tree/google-cloud-automl-v2.11.4/packages/google-cloud-automl
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 268906 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-automl
python310Packages.google-cloud-automl.dist
python311Packages.google-cloud-automl
python311Packages.google-cloud-automl.dist


Question about unet

Hi, was unet used for the LRA tasks?

No. Are you able to find the LRA configs?


API Issues

Whenever I use the forums api link "http://lostarkapi.herokuapp.com/v1/forums" on my Discord bot to send out each new forum post I get this error: 'Expecting value', 'Internal Server Error').

ill check it out tomorrow, thanks for the info. they likely changed the api

Whenever I use the forums api link "http://lostarkapi.herokuapp.com/v1/forums" on my Discord bot to send out each new forum post I get this error: 'Expecting value', 'Internal Server Error').

fixed here: https://github.com/axsddlr/lost_ark_api/commit/bd5b22a78b8f020c8a49af709ba82bdf12b01b79

Still getting the issue when using "http://lostarkapi.herokuapp.com/v1/forums"

No issues at all on my end. Went to that endpoint and received proper json
values.  Try again.
On Tue, Mar 22, 2022 at 3:46 PM Maxime @.***> wrote:

Still getting the issue when using "
http://lostarkapi.herokuapp.com/v1/forums"
—
Reply to this email directly, view it on GitHub
https://github.com/axsddlr/lost_ark_api/issues/4#issuecomment-1075566372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5EMY2EG5WONJBRZT3VTLVBIPQDANCNFSM5RICM2MQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

requests.exceptions.JSONDecodeError: [Errno Expecting value] Internal Server Error: 0
is what I get

Have any excerpt of the code you’re running?
On Tue, Mar 22, 2022 at 6:22 PM Maxime @.***> wrote:

requests.exceptions.JSONDecodeError: [Errno Expecting value] Internal
Server Error: 0
is what I get
—
Reply to this email directly, view it on GitHub
https://github.com/axsddlr/lost_ark_api/issues/4#issuecomment-1075699909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5EM5T53KQZQYGYL4PANLVBJB2FANCNFSM5RICM2MQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

#Gets Lost Ark Forum Post
def lost_ark_forum():
    URL ='http://lostarkapi.herokuapp.com/v2/forums/Downtime'
    r = requests.get(url=URL)
    data = r.json()
    return data["data"][0]

async def forum_task():
    forum_old = lost_ark_forum()["created_at"]
    while True:
        forum_new = lost_ark_forum()
        forumembed = hikari.Embed(title=forum_new()["title"], description=forum_new()["post_body"], url=forum_new()["url"], color="#DAA520")
        forumembed.set_author(name=forum_new()["author"], icon="https://pbs.twimg.com/profile_images/1492289372477030401/wj9cuyth_400x400.jpg")
        forumembed.set_footer(text=forum_new()["created_at"])
        print("test")
        if forum_old != forum_new["created_at"]:
            forum_old = forum_new["created_at"]
            await bot.rest.create_message(953264509785628682, forumembed)
        await asyncio.sleep(600)

@bot.listen(hikari.StartedEvent)
async def on_started(_):
    global running_task
    running_task = asyncio.create_task(forum_task())

@bot.listen(hikari.StoppingEvent)
async def on_stopping(_):
    global running_task
    if running_task is not None:
        running_task.cancel()

interesting i see nothing wrong with the json mapping in this code. only thing i would try to wrap json value calls in a try/except

I'll give it a shot.

Also, test the endpoint in incognito or clean cache. Works in my lost ark
discord bot with no issues
On Tue, Mar 22, 2022 at 3:46 PM Maxime @.***> wrote:

Still getting the issue when using "
http://lostarkapi.herokuapp.com/v1/forums"
—
Reply to this email directly, view it on GitHub
https://github.com/axsddlr/lost_ark_api/issues/4#issuecomment-1075566372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5EMY2EG5WONJBRZT3VTLVBIPQDANCNFSM5RICM2MQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Add haskell-community info to mailing lists page

A small step to increase visibility of this list

Whoops, dupe of #174


My  files crash when I open preview,it died and excit by self.

Description
My  files crash when I open preview,it died and excit by self.
Steps To Reproduce
1.open prefiles window
2.change any files,point one by one,so,sometimes ,files crash....
3.files runing slowly ,when open multi-tab.
Requirements

e.g. Fix crash that occurs when...
fix bug and optimize run by multi-tab.

Files Version
3.7.7
Windows Version
win11  22631.4169
User ID
files-community
Log File
Files.exe.13768.dmp
Files.exe.24944.dmp

Thanks for the feedback, We're tracking this in #16226 . You can check there or click subscribe in the right sidebar for updates.


onSubmit functions and progress added to DeleteView along with embedded list button fix

DeleteController changes so onSubmit functions added to DeleteView are invoked.
Progress stat/stop invoked.
admin-config pull request https://github.com/marmelab/admin-config/pull/67 needed for this to function!
This request is related to:
https://github.com/marmelab/ng-admin/issues/1106
and
https://github.com/marmelab/ng-admin/issues/1109
and
https://github.com/marmelab/ng-admin/issues/1114

Hey,
Any news about this.
Thanks

Will make new pull request based on current ng-admin source.


fix(main): add max goroutine num

Signed-off-by: cuisongliu<EMAIL_ADDRESS>

https://github.com/labring/sealos/pull/1081/files

https://github.com/labring/sealos/issues/994


[Doc]: Offline Inference Distributed

📚 The doc issue
Hi,
I was just wondering why in the "Offline Inference Distributed" example, ds.map_batches() is used. I used this initially, but I am now splitting the dataset and using ray.remote() which has the advantage that I don't need to specify the batch_size and can use continuous batching per GPU.
Suggest a potential alternative/fix
If useful I could contribute with an example in the docs with ray.remote(), so both methods are available
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

 I wonder how to find your example.

Pretty busy right now with a publication. Will try to add it asap. Thx for your patience.

Hi @comaniac,
please let me know if you think this could be useful for anyone.


As editors we see a need to promote images when using the Accordion component for CVs

Acceptance criteria

Add an optional image component to Accordion component
Design / sizing / options would be based on the Quote component image options
Image would need to appear first in order (image / title / ingress / accordion element)

Should not be in the accordion content, but with the title and ingress

Hi @padms, left a comment

@fernandolucchesi  Please check now

Looks good!

@meols Ready to be tested

@padms Looks good to me :thumbsup:


Add libvirt

Awesome that you created this box! But I use both Mac and Linux, and on linux I prefer to use libvirt/qemu.
I made this pull request so that next to the Virtualbox image, a libvirt image can be created as well.
Changes:

made VERSION env variable
converted Packer config from JSON to HCL (JSON is considered legacy, see: https://www.packer.io/docs/templates/legacy_json_templates)
added qemu build configuration to Packer
added individual build targets to Makefile
added shasums target to show SHA512 sums (handy when manually uploading)
refactored Makefile for dependencies
added/updated README

Thank you for the PR, @bjwschaap . I'll review it over the weekend.


Translation of a string

Regarding the current traslation function, here there seems to be a time benchmarking of different approaches
https://stackoverflow.com/questions/29977868/how-to-shift-a-string-to-right-in-python/29977973

This seems more for slicing words, not applying directly to the lattice chain.