Bump requirement for highway library

Hello,
When someone builds libjxl using JPEGXL_FORCE_SYSTEM_HWY, cmake searches for find_package(HWY 1.0.0).
https://github.com/libjxl/libjxl/blob/06d6570bc5427ec00188e1e5347cb1b184eda476/third_party/CMakeLists.txt#L34C3-L34C26
libjxl from git no longer works with highway 1.0.0 - 1.0.3 because symbol HWY_AVX3_ZEN4 is used.
I think it would be good to require newer highway version explicitly.

not sure if we should also add libhwy-dev (>= 1.0.4) to debian/control, at least once that version of the libhwy-dev is available...


Add support to change the order of the prompt info in the Powerline Multiline theme

Closes https://github.com/Bash-it/bash-it/issues/485

Very cool - what configuration needs to be done to swap the prompt components? Any environment variables or the like?

An environment variable that contains an array that defines the order of the "segments" you want to show.
I'm not sure where to explain this feature, is a theme option, so the Wiki is the best place, I think.
I need to fix some things before merge.

Yes, agreed, the Wiki might be the best place for documenting this. Other than that, we might think about adding a separate README.md file in each theme's folder. This file could include information about the theme, including possible configuration options.

:+1: to adding a README for the theme. The wiki isn't always immediately available, but they should have all of the bash-it files.

Sorry for leaving this PR unattended so long, but I finally finished.
Only the README.md is missing for now.

README.md added, as my english is not the best, a review is very welcome :smile_cat:

Now any prompt segment can be placed anywhere, at left or at right (README has been update too).
Also, I made a big code refactor, I've changed some names, to make the naming more consistent, I think that all is working fine...
So, this PR is now ready to merge.

Wow, this looks great! I won't have time to give this a full try today, I'll try to find some time on the weekend.

Thanks! @nwinkler

Just tried this, works fine for me! Thanks for doing this!

I've made some changes to the Powerline-Multiline readme in #653 - mostly minor spelling and formatting.


Help with Finetune

Hi, team.
I fine tuned with 15 <image, Q&A> pairs of one document type. (12 pairs as train, 3 as test)
After 500 epoches, both of training and eval_loss are nearly zero like following.

{'loss': 0.0, 'grad_norm': 7.342097887885757e-06, 'learning_rate': 1e-06, 'epoch': 500.0}
{'eval_loss': 7.8905128475526e-07, 'eval_runtime': 2.179, 'eval_samples_per_second': 1.377, 'eval_steps_per_second': 0.459, 'epoch': 500.0}

But even I pick up image and ask same questions from training set, still get different result from training set like following

Training Data

{
      "role": "user",
      "content": "What is the address breakdown city?"
    },
    {
      "role": "assistant",
      "content": "CALWELL"
    },
    {
      "role": "user",
      "content": "What is the address breakdown street?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT"
    },
    {
      "role": "user",
      "content": "What is the address?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT, CALWELL, ACT, 2905"
    },

Model Output

<User>: What is the address breakdown city?
<Assistant>: 65 MARTLEY CCT
<User>: What is the address breakdown street?
<Assistant>: 65 MARTLEY CCT, suburb CALWELL ACT 2905.
<User>: What is the address?
<Assistant>: 65 MARTLEY CCT CALWELL ACT 2905

I used batch_size 8, and model_max_length 1024.
I loaded model like following.

model_path = '/home/paperspace/.../OpenBmb/MiniCPM-V/finetune/output/output_minicpmv2_lora/checkpoint-1000'
model = AutoPeftModelForCausalLM.from_pretrained(model_path, device_map="auto", trust_remote_code=True).to(dtype=torch.float16)
model = model.to(device=device)
tokenizer = AutoTokenizer.from_pretrained(model_path, trust_remote_code=True)
model.eval()

Tensorboard

Any help would be appreciated to get correct finetuning result.

插眼

Hi, team. I fine tuned with 15 <image, Q&A> pairs of one document type. (12 pairs as train, 3 as test) After 500 epoches, both of training and eval_loss are nearly zero like following.

{'loss': 0.0, 'grad_norm': 7.342097887885757e-06, 'learning_rate': 1e-06, 'epoch': 500.0}
{'eval_loss': 7.8905128475526e-07, 'eval_runtime': 2.179, 'eval_samples_per_second': 1.377, 'eval_steps_per_second': 0.459, 'epoch': 500.0}

But even I pick up image and ask same questions from training set, still get different result from training set like following

Training Data

{
      "role": "user",
      "content": "What is the address breakdown city?"
    },
    {
      "role": "assistant",
      "content": "CALWELL"
    },
    {
      "role": "user",
      "content": "What is the address breakdown street?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT"
    },
    {
      "role": "user",
      "content": "What is the address?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT, CALWELL, ACT, 2905"
    },

Model Output

<User>: What is the address breakdown city?
<Assistant>: 65 MARTLEY CCT
<User>: What is the address breakdown street?
<Assistant>: 65 MARTLEY CCT, suburb CALWELL ACT 2905.
<User>: What is the address?
<Assistant>: 65 MARTLEY CCT CALWELL ACT 2905

I used batch_size 8, and model_max_length 1024.
I loaded model like following.

model_path = '/home/paperspace/.../OpenBmb/MiniCPM-V/finetune/output/output_minicpmv2_lora/checkpoint-1000'
model = AutoPeftModelForCausalLM.from_pretrained(model_path, device_map="auto", trust_remote_code=True).to(dtype=torch.float16)
model = model.to(device=device)
tokenizer = AutoTokenizer.from_pretrained(model_path, trust_remote_code=True)
model.eval()

Tensorboard
Any help would be appreciated to get correct finetuning result.

Can you give me the code ?

Hi, team. I fine tuned with 15 <image, Q&A> pairs of one document type. (12 pairs as train, 3 as test) After 500 epoches, both of training and eval_loss are nearly zero like following.

{'loss': 0.0, 'grad_norm': 7.342097887885757e-06, 'learning_rate': 1e-06, 'epoch': 500.0}
{'eval_loss': 7.8905128475526e-07, 'eval_runtime': 2.179, 'eval_samples_per_second': 1.377, 'eval_steps_per_second': 0.459, 'epoch': 500.0}

But even I pick up image and ask same questions from training set, still get different result from training set like following

Training Data

{
      "role": "user",
      "content": "What is the address breakdown city?"
    },
    {
      "role": "assistant",
      "content": "CALWELL"
    },
    {
      "role": "user",
      "content": "What is the address breakdown street?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT"
    },
    {
      "role": "user",
      "content": "What is the address?"
    },
    {
      "role": "assistant",
      "content": "65 MARTLEY CCT, CALWELL, ACT, 2905"
    },

Model Output

<User>: What is the address breakdown city?
<Assistant>: 65 MARTLEY CCT
<User>: What is the address breakdown street?
<Assistant>: 65 MARTLEY CCT, suburb CALWELL ACT 2905.
<User>: What is the address?
<Assistant>: 65 MARTLEY CCT CALWELL ACT 2905

I used batch_size 8, and model_max_length 1024.
I loaded model like following.

model_path = '/home/paperspace/.../OpenBmb/MiniCPM-V/finetune/output/output_minicpmv2_lora/checkpoint-1000'
model = AutoPeftModelForCausalLM.from_pretrained(model_path, device_map="auto", trust_remote_code=True).to(dtype=torch.float16)
model = model.to(device=device)
tokenizer = AutoTokenizer.from_pretrained(model_path, trust_remote_code=True)
model.eval()

Tensorboard
Any help would be appreciated to get correct finetuning result.

@EmailScraper  Hello, may I ask if you have trained with images? When I fine tuned, it kept showing loading the data. Have you encountered this? May I inquire with you? Thank you

我认为有可能是你的训练数据集太小了，而且训练epoch设置为500，又太多了导致模型严重过拟合

Hi, @LDLINGLINGLING , thanks for your reply.
Btw, I  just pick up image and ask same questions from training set, still get different result from training set.
Is it possible?


[question] Get raw depth information from ADT data

I want to be able to access metric depth information as a numpy-array from ADT data so that I can do depth-based filtering on visual information and segmentation annotations for my use-case.
I found this link, but it does not seem to apply to ADT data.
CC'ing tagged PoC: @YLouWashU

Hi @zephirefaith, to access the raw depth information we have two functions available for the DepthData class which are accessible using Python API:

at(x, y) to access a specific depth value, see definition here
to_numpy_array() to convert the entire depth map to a numpy array, see definition here

Both functions return data as uint16 in mm. See the code snippet below for an example to use them:
depth_with_dt = gt_provider.get_depth_image_by_timestamp_ns(select_timestamps_ns, stream_id)
depth_image = depth_with_dt.data()
row = int(depth_image.get_height() / 3)
col = int(depth_image.get_width() / 2)

# method 1
depth_mm1 = depth_image.at(col, row)

# method 2
numpy_image = depth_image.to_numpy_array()
depth_mm1 = numpy_image[row][col]

@nickcharron Thanks for that and sorry for miscommunication.
This is exactly what I am using to get raw depth, which is as expected. However when I rectify this depth image (using the same procedure as rectifying RGB, Segmentation) then this rectified depth image's values are between 0-255.

Is casting helpful:
numpy_image = numpy_image.astype(np.float32)

The above worked @SeaOtocinclus!
Thank you :)


Bump dependency on cardano-ledger-specs

Notable changes: #1433, #1457, and #1458.

A test is failing because of a bug in a cardano-ledger-specs decoder. I have a PR open fixing it: https://github.com/input-output-hk/cardano-ledger-specs/pull/1461. We'll need to wait before that's merged before we can (bump the dependency again and) merge this. I'm going to stop for today, so anybody that depends on this update can take over.
@coot FYI, this brings in the PRs you merged in cardano-ledger-specs and cardano-base.

bors merge


ERROR: Invalid requirement: 'torch>=2.1.0+cu118': Local version label can only be used with == or != operators     torch>=2.1.0+cu118          ~~~~~~~^ (from line 2 of requirements_base.txt)

i got this error
ERROR: Invalid requirement: 'torch>=2.1.0+cu118': Local version label can only be used with == or != operators
torch>=2.1.0+cu118
~~~~~~~^ (from line 2 of requirements_base.txt)

Hello! I had the same issue. Try removing the lines that mention torch in the requirements_base.txt file, as those packages are installed separatly in the instructions.

What I did is to change >= for == in the requirements file and it installed everything just fine.


Bump elmPackages

Note that elm-verify-examples is still broken.
Fixes #320127 #267454 #304198

I pushed a fix for elm-pages.

Seems to be https://github.com/NixOS/nixpkgs/issues/294183

Note that the binary still fails to run because we need to also patch up rollup:
❯ /nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/bin/elm-land
/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js:59
		throw new Error(
		      ^

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at requireWithFriendlyError (/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js:59:9)
    at Object.<anonymous> (/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js:68:76)
    ... 3 lines matching cause stack trace ...
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24) {
  [cause]: Error: Cannot find module '@rollup/rollup-linux-x64-gnu'
  Require stack:
  - /nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js
      at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
      at Module._load (node:internal/modules/cjs/loader:1051:27)
      at Module.require (node:internal/modules/cjs/loader:1311:19)
      at require (node:internal/modules/helpers:179:18)
      at requireWithFriendlyError (/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js:41:10)
      at Object.<anonymous> (/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js:68:76)
      at Module._compile (node:internal/modules/cjs/loader:1469:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
      at Module.load (node:internal/modules/cjs/loader:1288:32)
      at Module._load (node:internal/modules/cjs/loader:1104:12) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
      '/nix/store/mbbvs7bg3n90gj0fva1zxx5fp70fc9lq-elm-land-0.20.1/lib/node_modules/elm-land/node_modules/rollup/dist/native.js'
    ]
  }
}

Node.js v20.17.0

ah right. I also ran into this issue in my quick spike - that's where I gave up. Forgot to test it in this PR.
Anyway lets try fix these issues one by one now when this is merged. I also think we can start decoupling these problematic packages away from node2nix to buildNpmPackage.

I tried using buildNpmPackage, but build from source is quite complicated as it needs to build parts using elm. Going to try to patch @rollup/wasm-node to be used in place of rollup.


Dev

Coverage remained the same at 31.153% when pulling c5dc33e1df4cac7bae27e6887c482ca4407ea11f on dev into 019b5f69f989111db65dec12bfff9a1cc773398e on uat.


Adding fixes for two NULL pointer dereferences

Adding fixes for two NULL pointer dereferences within code utilising Asm.Js

Hi @JanMitchell, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@JanMitchell, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

FAO @Cellule

:lgtm:
I will merge this afternoon
Thanks a lot


Fix support for installing node on SmartOS

uname on SmartOS cannot be used to guess if 32 and/or 64 bits binaries
are supported, and its output is different than other uname commands on
other operating systems.
This change uses pkg_info to determine what types of binaries pkgsrc would
install. If pkg_info fails to run or is not present, this change falls
back to using isainfo -n, which determines what the kernel supports.
This change also allows users to install node binaries from Solaris
derivatives. It doesn't remove the limitation that prevents them from
installing io.js binaries because not all io.js versions have binaries
for Solaris derivatives.

I'm not sure how to write unit tests for nvm_get_arch, as what I have in mind currently would mean reimplementing nvm_get_arch to test it. I would appreciate any idea on how to do that cleanly.
Also, currently without these changes and as of commit 8aebf86, when running make test 3 tests fail. No other tests fail when running tests with these changes.
I tests these changes on SmartOS with bash, and on OSX with sh, ksh and zsh.

This seems like a great change - thank you! The things I'll need to think about before being confident enough to merge it:

unit test coverage, part of which you mentioned
is it possible to run sunOS tests?
making absolutely sure that existing install scenarios aren't broken

I'll test this out myself tonight/tomorrow, and ask a few others to do so as well, to help with this.

unit test coverage, part of which you mentioned

I'm still thinking about how to write a test that would not be the exact copy of the implementation itself :)

is it possible to run sunOS tests?

Do you mean to manually check if this change works on sunOS?

no, i mean, add something to travis that would ensure this doesn't break in the future

@ljharb Actually, I can probably just mock uname, isainfo and pkg_info for all supported archs and have them output static constant output. Then I can override PATH  for each test so that uname, isainfo and pkg_info point to the mocked version (or to nothing if any of these commands should not be present for a given supported arch), and finally check that nvm_get_arch returns the expect output.
Sounds good? I'll update that PR soon, although maybe not tonight.

For nvm_get_arch that sounds awesome.
Are isainfo or pkginfo part of POSIX? What shells/platforms do they work on?

isainfo is not POSIX, it works on SmartOS and Solaris, and maybe on other Solaris derivatives. pkginfo is not POSIX, it is often available on SmartOS, and might be usable on Solaris. It's not mandatory though in the current state of this PR.

Updated this PR with a first shot at writing tests for nvm_get_arch. Please let me know if that looks like it's going towards the right direction :)

Thanks, I think this is almost there! I'll test it out myself today, since my comments are mostly about tests.

@ljharb Updated this PR according to your feedback. I've been adding commits to make changes related to code reviews easier to separate from the rest, but obviously once this is ready to land I'll squash them into one commit.

I've tested this out, and it looks good - some tab characters to replace with spaces, but otherwise please rebase as you see fit, and I'll merge!

@ljharb That's great, thank you for the thoughtful and kind reviews, I really appreciate it. Will update and squash soon.

Fixed the two formatting issues, and squashed all commits into one.

Thanks for being so thorough with this PR!

@ljharb Thank you for merging it! Do you know when that will make it into a release? I know significant users of node and SmartOS who are looking forward to being able to use nvm on SmartOS :)

Released in v0.28.0!

@ljharb That's great, thank you very much once again for your help!


"Error: Connection refused: Not authorized"

Hi, I have successfull setup my account here;
https://alexa-node-red.bm.hardill.me.uk/
Also i linked the skill to alexe, and she find the device i added...
also i can import alexa devices in my node red dashboard, but at this time i got every few seconds,
this error message: "Error: Connection refused: Not authorized"
i tried to use another account, new devices and so so on...
my firewall is open

I'll have a look at the logs, but double check there are no trailing spaces on the end of the username or password you entered in the account config.
Also when exactly did you create the account?

username/passwords are also case sensitive
Also check what IP address alexa-node-red.hardill.me.uk (note no 'bm' in the middle) resolves to

Hello Ben,
First: Thanks for your Time!
the username (chno299) must be correct, because node red dashboard shows me
immediately my device after i entered my credentials..
The ip for :alexa-node-red.hardill.me.uk is:
<IP_ADDRESS>
Best Regards from Austria
Mit freundlichen Grüßen
Mobil:0664 432 86 93
Web:netztech http://netztech.at/.at
Kristallstrasse 18
A-4407 STEYR-GLEINK
Österreich
DVR: 0999466
UID: ATU24149106
2017-09-30 15:12 GMT+02:00 Ben Hardill<EMAIL_ADDRESS>
I'll have a look at the logs, but double check there are no trailing
spaces on the end of the username or password you entered in the account
config.
Also when exactly did you create the account?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/27#issuecomment-333307698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJiY5SiP2eSf0RhAoLz7NncMjDYZudlBks5snj5UgaJpZM4PpjfK
.

When did you create the account?

not sure, i think bevore 3 days...
i also make a new account "mulder299" (yesterday)
this also not works...
btw: my ip is: <IP_ADDRESS>
Mit freundlichen Grüßen
Mobil:0664 432 86 93
Web:netztech http://netztech.at/.at
Kristallstrasse 18
A-4407 STEYR-GLEINK
Österreich
DVR: 0999466
UID: ATU24149106
2017-09-30 16:45 GMT+02:00 Ben Hardill<EMAIL_ADDRESS>
When did you create the account?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/27#issuecomment-333313101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJiY5SzwfHXLdZ4uTi0cSoJSsZyW4OfTks5snlPugaJpZM4PpjfK
.

mulder299 is not in the database, which implies you managed to created while I was moving the system to it's new back end.

i tried to register now:
[image: Inline-Bild 1]
Mit freundlichen Grüßen
Mobil:0664 432 86 93
Web:netztech http://netztech.at/.at
Kristallstrasse 18
A-4407 STEYR-GLEINK
Österreich
DVR: 0999466
UID: ATU24149106
2017-09-30 18:31 GMT+02:00 Ben Hardill<EMAIL_ADDRESS>
mulder299 is not in the database, which implies you managed to created
while I was moving the system to it's new back end.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/27#issuecomment-333319776,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJiY5WMgRtV_-k02H4D3ugCK_HdaJkDkks5snmz8gaJpZM4PpjfK
.

OK, thanks, you've just helped me notice the web frontend was still pointing at the old database. Everything should be pointing at the new database now (where there should be no mulder299).
Did you try changing the password on either of the chno299 account at some point?
Can you try and log into the web with chno299 now I've fixed the DB

OK - i am connected now!
Thanks for the Ultrafast Fix

So the chno299 account is working now or did you add a new mulder299 account?

i add the mulder299 account.
Mit freundlichen Grüßen
Mobil:0664 432 86 93
Web:netztech http://netztech.at/.at
Kristallstrasse 18
A-4407 STEYR-GLEINK
Österreich
DVR: 0999466
UID: ATU24149106
2017-09-30 20:08 GMT+02:00 Ben Hardill<EMAIL_ADDRESS>
So the chno299 account is working now or did you add a new mulder299
account?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/27#issuecomment-333325919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJiY5RpmIwV9OLjhmQC2mDZUL0MuW73Kks5snoOwgaJpZM4PpjfK
.


Provide a quick link in the carousel to the first & last pages of a story

Feature Description
Originally reported by @BrittanyIRL

it would be nice to get a “first page” and “last page” button on the carousel to skip to the beginning or end.

Alternatives Considered

Additional Context

@agingoldseco / @gajasinski Tagging you as this seems to be a UX / Product decision.

I like this idea, but def want to get all the spacing / button placement changes fully worked out first. At this moment, especially at the bottom of a small screen where I've had issues with arrows overlapping the buttons, I'm wary of adding any new options

Realistically, the story would have to have a good number of pages and/or your screen size is smaller where the current arrow implementation wouldn't allow you to scroll to the first or last page with one tap, yes?

Doesn't seem too bad having to tap on the arrow twice to get to the end of the carousel if on a small screen 🤷

I'm not keen to prioritize this ATM.


Global styles present in qor_auth.css

There some global style rules inside this css file that are possibly could brake existing markup

Hi @alexmironof
That should been fixed.

Hi @jinzhu, thanks a lot!


:sparkles: Enable to Module Stability

https://ja.stackoverflow.com/questions/60498/abi-stability-なのになぜ-module-compiled-with-swift-5-1-cannot-be-imported-by-the-swi/60500?stw=2#60500

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      8
  Lines         153    153
=====================================
  Hits          153    153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6d8b5...fb2f54f. Read the comment docs.

module 'RxSwift' was not compiled with library evolution support; using it means binary compatibility for 'RxScreenProtectKitTests' can't be guaranteed


Values on statistics page not updated

I've enabled the file and lru caches but it seems the values on the statistic page are not updated:
cache_time_us:<PHONE_NUMBER>4
cache_hits:                                       1004351
cache_misses:                                      168951
cache_backend_hits:                               1058961
cache_backend_misses:                              114341
cache_fallbacks:                                     3028
cache_expirations:                                   9816
cache_inserts:                                     376839
cache_deletes:                                          0
...
file_cache_bytes_freed_in_cleanup:                      0
file_cache_cleanups:                                    0
file_cache_disk_checks:                                 0
file_cache_evictions:                                   0
file_cache_skipped_cleanups:                            0
file_cache_started_cleanups:                            0
file_cache_write_errors:                                0
file_cache_deletes:                                     0
file_cache_hits:                                        0
file_cache_inserts:                                     0
file_cache_misses:                                      0
lru_cache_deletes:                                      0
lru_cache_hits:                                         0
lru_cache_inserts:                                      0
lru_cache_misses:                                       0

As a result I have no idea if the LRU cache even works. (I'm trying to debug an issue with pagespeed generating large amount of write IOPS for no apparent reason)

Is the LRU cache configured?  E.g. something like
ModPagespeedLRUCacheKbPerProcess   1024
ModPagespeedLRUCacheByteLimit      16384

and actually the reason it might not be configured is that for most applications, you shouldn't use it, and should instead use the shared-memory cache, so it's not replicated per apache child process.
See https://www.modpagespeed.com/doc/system for details.

This is what my configuration looks like:
Options
  AvoidRenamingIntrospectiveJavascript (aris)  True
  BeaconUrl (bu)                               /ngx_pagespeed_beacon
  EnableRewriting (e)                          1
  FileCacheCleanIntervalMs (afcci)             3600000
  FileCacheInodeLimit (afcl)                   500000
  FileCachePath (afcp)                         /var/cache/nginx/ngx_pagespeed_cache
  FileCacheSizeKb (afc)                        10485760
  LRUCacheByteLimit (alcb)                     32768
  LRUCacheKbPerProcess (alcp)                  16384
  RespectXForwardedProto (rxfp)                True
  RewriteLevel (l)                             Core Filters
  StatisticsPath (nsp)                         /ngx_pagespeed_statistics

The documentation says that if no explicit shared-memory cache is specified there is a default one that will be used.
What are the appropriate values for the cache sizes? The file cache directory is currently 7GB in size but the default shared-memory cache in only 50MB which seems tiny. On the other hand if I would increase this to say 5GB (the server has 16GB of RAM) then the snapshotting would probably cause massive disk i/o when all of this is written out.
For some reason pagespeed is causing around 200 write IOPS for no apparent reason and my hope is that by configuring the in-memory caching correctly that I can fix this issue. It seems unlikely that pagespeed is updating so many files all the time so I suspect it might have something to do with metadata.


tiny change to better align console menu with longer ifnames

[x] Redmine Issue: https://redmine.pfsense.org/issues/13268
[x] Ready for review

small change to add some width and better align things if interface names are longer than just "WAN", "WAN2" etc.
before:

after:

I wanted to auto size the columns based on the terminal width, but the shell doesn't seem to export the $COLUMNS variable that would be required to do that.

See https://redmine.pfsense.org/issues/13268#note-2


[Bug] After use, it still prompts that it is not used

used

vs code message

You should also disable Vetur in VSCode.


Context menu for System, Material, Geometry & Inventory panels

This can be achieved via Dat.GUI VR https://github.com/Convolvr/convolvr/blob/dev/client/src/js/systems/ui/datguivr-plugin.js
Testing needed.


PEP 461 format of bytes string returns basestring (python 3.5.1+)

Issue:
PEP 461 style bytes formatting (b'%b' % variable) returns basestring. So the following code results in a cythonize error:
cpdef bytes cy_foo():
cdef:
bytes bytes_1, bytes_2
bytes_1 = b'bytes 1'
bytes_2 = b'bytes 2'

return b'%(bytes_1)b %(bytes_2)b' % {
                b'bytes_1': bytes_1,
                b'bytes_2': bytes_2}

Result:
Cannot convert 'basestring' object to bytes implicitly. This is not portable.
This same basic code in python 3.5.1+ returns a bytes object.

Cython is not smart enough here to detect that the formatting is guaranteed to return a bytes object in this case because it only works in Py3 (and raises an exception in Py2 due to an unknown format conversion type 'b').
As a work-around, you can use a cast, i.e.
return <bytes> (b'...' % {...})


:alembic: Used bun instead

bun seems to work fine over npm

I need to update the Readme

ooops meant to open this on my own repo...


TEAM Groups privileges conflict when a user is assigned to multiple groups

Describe the bug
In our SSO provider which is connected to AWS Identity Center on our Organization account,
We have these groups, for which have assigned the groups to these TEAM roles :

Administrator <-- AWS-Admins
Auditor           <-- AWS-PowerUsers
Requestor       <-- AWS-Developers

When an administrator is part of both PowerUsers and Admins groups,
TEAM doesn't grant the admin user the privileges of entering the configuration here:

The whole Administration section is missing in the left pane.
This suggest that the TEAM app, uses the principle of least privilege (PoLP),
but also upon merging/calculating the user privileges, the role with the least privileges takes precedence over any other.
I would guess this is the current state:
Requestor > Approver >= Auditor > Administrator
So when an admin has any other group, he is 'demoted' to that group's level.
To Reproduce
Add an admin user to a Lower-permissions group
Login again to refresh user groups
Expected behavior
Admin retains his higher privileges even though he is part of any other groups
or, have add a deployment parameter to flip the behavior, so both ways could be achieved
Requestor > Approver >= Auditor > Administrator
or
Administrator > Auditor >= Approver > Requestor
This issue is somewhat similar to this #61

@asaf400  This shouldnt be the case. The admin should see the adminstration section even if they belong to other groups. If this is the first time the admin is signing into the application they would have to logout and sign in again before they can see the administration section. Have you tried doing this ?

I have the same user in an admin group and in an auditor group and I can see all tabs.

@lvthillo I will retest this, maybe I was part of the approver group and not auditors
@tawoyinfa I did try to logout and logback in again, I even manually removed myself from the lower tier group in Cognito,
but upon login, I was ofc re-added to it, and I still wasn't seeing the admin section..
Only when I removed myself from our IDP PowerUsers, which meant I was only part of TEAM admins groups, I was able to see..
I'll retest this as well, and post more screenshots, as the one I took and uploaded here, is after I made the change and was able to see the admin section..


POM requires Java 1.7 but code uses 1.8 features

Hi,
I tried to integrate the library using jitpack.io which fails (https://jitpack.io/com/github/piwik/piwik-java-tracker/709012c/build.log). I assume this is because Java 1.8 features are used (e.g. map.putIfAbsent for Map in CustomVariableList) but the POM sets Java 1.7 as the target version.
Could you look  into this? Thanks
Kind regards...

There's an open pull request https://github.com/piwik/piwik-java-tracker/pull/20 addressing this.  This will be fixed by that request or myself in a change and will be released in 1.3

Okay, thank you! I didn't notice the request

Resolved and will be released in 1.3.  Feel free to build from HEAD and reopen if it's still not compatible.


addition: animation control

We need to find a way to be able to get animations to slow down and/or stop mid-animation, as well as modify current animations and also to be able to set the current time of the animation (something akin to scrubbing in a movie).

closing as per: https://github.com/C4Framework/C4iOS/pull/233


[Feature Request]: Schema Registry Samples is Missing an Avro Generic Example

Is your request related to a problem you have?
I was running some samples in the Confluent.Kafka repo, and then some samples in this repo, and since I was interested in a GenericRecord example with Avro it made an impression on me that there are two Avro examples, and both use ISpecificRecord. In Contrast in the Confluent.Kafka repo they have one example for specific and one for generic, which is much more valuable in my opinion. See https://github.com/confluentinc/confluent-kafka-dotnet/tree/master/examples/AvroGeneric and https://github.com/confluentinc/confluent-kafka-dotnet/tree/master/examples/AvroSpecific for comparison.
Describe the solution you'd like
Add a generic avro record sample, in addition to the two specific record examples. Possibly replace one of the specific example with a generic for better value. Refer to https://github.com/confluentinc/confluent-kafka-dotnet/tree/master/examples/AvroGeneric.
Are you able to help bring it to life and contribute with a Pull Request?
Yes
Additional context
I might be able to make a PR for this, but first I must try it for myself. Hints appreciated.

For the sake of discussion and if anyone is researching this as I was, the below is the minimum implementation I've arrived at, based on https://github.com/confluentinc/confluent-kafka-dotnet/tree/master/examples/AvroGeneric.
.AddConsumer(
    consumer => consumer
        // ...
        .AddMiddlewares(
            middlewares => middlewares
                .AddSchemaRegistryAvroGenericRecordDeserializer()
                .AddTypedHandlers(
                    handlers => handlers
                        .AddHandler<AvroGenericRecordMessageHandler>())
        )
)

/// <summary>
/// Beware, this acts as a catch-all - it handles all Avro messages, even specific ones!
/// </summary>
public sealed class AvroGenericRecordMessageHandler : IMessageHandler<GenericRecord>
{
    public Task Handle(IMessageContext context, GenericRecord message)
    {
        Console.WriteLine(
            "Partition: {0} | Offset: {1} | Message: {2} | Avro Generic",
            context.ConsumerContext.Partition,
            context.ConsumerContext.Offset,
            message);

        return Task.CompletedTask;
    }
}

public sealed class SchemaRegistryGenericRecordTypeResolver : IMessageTypeResolver
{
    public ValueTask<Type> OnConsumeAsync(IMessageContext context) => ValueTask.FromResult(typeof(GenericRecord));

    public ValueTask OnProduceAsync(IMessageContext context) => default;
}

public static class ConsumerConfigurationBuilderExtensions
{
    public static IConsumerMiddlewareConfigurationBuilder AddSchemaRegistryAvroGenericRecordDeserializer(
        this IConsumerMiddlewareConfigurationBuilder middlewares)
    {
        return middlewares.Add(
            resolver => new DeserializerConsumerMiddleware(
                new ConfluentAvroDeserializer(resolver),
                new SchemaRegistryGenericRecordTypeResolver()));
    }
}

public static class SampleData
{
    private static readonly RecordSchema s_schema = (RecordSchema)RecordSchema.Parse(
        @"{
            ""type"": ""record"",
            ""name"": ""User"",
            ""fields"": [
                {""name"": ""name"", ""type"": ""string""},
                {""name"": ""favorite_number"",  ""type"": ""long""},
                {""name"": ""favorite_color"", ""type"": ""string""}
            ]
        }"
    );

    public static GenericRecord CreateGenericUser(string name, long favouriteNumber, string favouriteColor)
    {
        var record = new GenericRecord(s_schema);
        record.Add("name", name);
        record.Add("favorite_number", favouriteNumber);
        record.Add("favorite_color", favouriteColor);
        return record;
    }
}

The main issue that wasn't very obvious is that the existing SchemaRegistryTypeResolver that's being registered with AddSchemaRegistryAvroDeserializer scans the assemblies for a class that matches the namespace and name, as specified by the Avro schema, when my intention was to deserialize in a GenericRecord. I think it's a bit unfortunate that the library doesn't support deserializing into a GenericRecord out of the box. Adding some custom code is not the end of the world, but it wasn't very intuitive why the GenericRecord handler wasn't invoked in my pipeline, since the underlying confluent SDK is fully capable of handling it. I had to debug before I realised what the issue is.
Question to the maintainers of the library, do you see value in adding this natively into the lib, or at the very least showcasing this in the samples and/or docs?
If this is to be added to the lib, an API must be defined, because there's more than one way of doing it. Above I've demonstrated a new deserializer, which is simple enough, but you may wish not to introduce a different registration method. Another option is to extend the existing SchemaRegistryTypeResolver to fallback to GenericRecord if it doesn't find a matching type, instead of returning null which eventually short-circuits the parent DeserializerConsumerMiddleware. While that solution is a bit more "magical", it will allow for chaining a generic handler as a "catch all" after specific handlers, e.g.
.AddConsumer(
    consumer => consumer
        // ...
        .AddMiddlewares(
            middlewares => middlewares
                .AddSchemaRegistryAvroGenericRecordDeserializer()
                .AddTypedHandlers(
                    handlers => handlers
                        .AddHandler<AvroMessageHandler>()
                        .AddHandler<AvroMessageHandler2>()
                        // everything that didn't match specific handlers will fall through to the generic handler
                        // assumes we modified the SchemaRegistryTypeResolver to fallback gracefully to typeof(GenericRecord)
                        .AddHandler<AvroGenericRecordMessageHandler>())
        )
)

Whilst I haven't tested the above design, I don't see a reason why it wouldn't work.

Hi @danielmpetrov,
Thank you for your suggestion, and we see value on adding this to KafkaFlow.
Since this will require a new implementation on KafkaFlow, we will work on it, and then open the PR.
Feel free to participate on it when we open the PR.

Awesome, I'm looking forward to your design.


Cannot connect to an exposed nodeport from host system.

General information

OS:  Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? yes
Running CRC on: Laptop

CRC version
CRC version: 2.10.1+7e7f6b2d
OpenShift version: 4.11.7
Podman version: 4.2.0
CRC status
DEBU CRC version: 2.10.1+7e7f6b2d
DEBU OpenShift version: 4.11.7
DEBU Podman version: 4.2.0
DEBU Running 'crc status'
DEBU Checking file: C:\Users\nick.crc\machines\crc.crc-exist
DEBU Checking file: C:\Users\nick.crc\machines\crc.crc-exist
DEBU Running 'Hyper-V\Get-VM crc | Select-Object -ExpandProperty State'
DEBU Running SSH command: df -B1 --output=size,used,target /sysroot | tail -1
DEBU Using ssh private keys: [C:\Users\nick.crc\machines\crc\id_ecdsa C:\Users\nick.crc\cache\crc_hyperv_4.11.7_amd64\id_ecdsa_crc]
DEBU SSH command results: err: , output:<PHONE_NUMBER>6<PHONE_NUMBER>2 /sysroot
CRC VM:          Running
OpenShift:       Running (v4.11.7)
Podman:
Disk Usage:      23.66GB of 32.74GB (Inside the CRC VM)
Cache Usage:     22.02GB
Cache Directory: C:\Users\nick.crc\cache
CRC config

consent-telemetry                     : no
cpus                                  : 10
enable-cluster-monitoring             : true
host-network-access                   : true
memory                                : 22950

Host Operating System
Host Name:                 VOID
OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22000 N/A Build 22000
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
Registered Owner:          nwpaul
Registered Organization:
Product ID:                00330-80000-00000-AA651
Original Install Date:     5/4/2022, 3:41:01 PM
System Boot Time:          10/19/2022, 6:56:38 AM
System Manufacturer:       Gigabyte Technology Co., Ltd.
System Model:              X399 DESIGNARE EX
System Type:               x64-based PC
Processor(s):              1 Processor(s) Installed.
[01]: AMD64 Family 23 Model 1 Stepping 1 AuthenticAMD ~3400 Mhz
BIOS Version:              American Megatrends Inc. F13a, 11/30/2021
Windows Directory:         C:\Windows
System Directory:          C:\Windows\system32
Boot Device:               \Device\HarddiskVolume2
System Locale:             en-us;English (United States)
Input Locale:              en-us;English (United States)
Time Zone:                 (UTC-08:00) Pacific Time (US & Canada)
Total Physical Memory:     65,415 MB
Available Physical Memory: 21,641 MB
Virtual Memory: Max Size:  75,143 MB
Virtual Memory: Available: 13,792 MB
Virtual Memory: In Use:    61,351 MB
Page File Location(s):     C:\pagefile.sys
Domain:                    WORKGROUP
Logon Server:              \VOID
Hotfix(s):                 5 Hotfix(s) Installed.
[01]: KB5017024
[02]: KB5012170
[03]: KB5018418
[04]: KB5017850
[05]: KB5018291
Network Card(s):           5 NIC(s) Installed.
[01]: Intel(R) Dual Band Wireless-AC 8265
Connection Name: Wi-Fi
Status:          Media disconnected
[02]: Intel(R) I211 Gigabit Network Connection
Connection Name: Ethernet
Status:          Media disconnected
[03]: Intel(R) I211 Gigabit Network Connection
Connection Name: Ethernet 2
DHCP Enabled:    Yes
DHCP Server:     <IP_ADDRESS>
IP address(es)
[01]: <IP_ADDRESS>
[02]: fe80::bcc5:b6c2:cf71:8418
[04]: Bluetooth Device (Personal Area Network)
Connection Name: Bluetooth Network Connection
Status:          Media disconnected
[05]: PANGP Virtual Ethernet Adapter
Connection Name: Ethernet 3
DHCP Enabled:    No
IP address(es)
[01]: <IP_ADDRESS>
[02]: fc00::1:3e1c
Hyper-V Requirements:      A hypervisor has been detected. Features required for Hyper-V will not be displayed.
Steps to reproduce

Have a pod expose a port 8081 (non-http)
Expose it as a nodeport
oc expose deployment myDeployment --name=myDeployment  --type=NodePort --port=8081
From the hosting system connect to port 8081

Expected
Connection successful and the ability to communicate with the nodeport.
Actual
Connection Timeout

@NickPaul41 for windows are using the usermode network stack and also a container which update the route url to host's/etc/hosts if you want to access that service on host better to expose this service to route instead of nodeport.
$ oc expose deployment myDeployment --name=myDeployment --port=8081
$ oc expose svc myDeployment
$ oc get routes

routes command provide you HOST field which you can use to access it on the host with specified port.

I'm not using HTTP, but a tcp socket connection. I've tried using routes before but they are setup for HTTP and I get a 400 bad request when making the tcp connection. In a OpenShift cluster I expose a node port and then connect to it.  I'm assuming node ports are not available though crc. Is there another way to open a socket connection (non-http) between crc and host?

When using TCP, use oc port-forward <pod> 8888:5000

Thanks @mltucker that does work. Is there a more permanent way to set this up?
I have a few services to interact with and the pod names change after recreation or rebooting my PC.

I created a controller analogous to the routes controller which handles this. You can take a look here: https://github.com/raynay-r/crc-node-port-controller
Would you be interested in adding this controller to the CRC distribution?

Can you provide this as an addition to the routes-controller (even though naming may need to evolve :) It's probably better to have both routes and node ports in the same codebase instead of keeping both separate?

Yes, i can provide a PR for the routes-controller, but will probably take few weeks until I get to it.

@NickPaul41 We have already added this as part of route controller https://github.com/crc-org/routes-controller/pull/12 which should fix it. Please try latest version of OpenShift Local and create a new issue if this is still not fixed.

We haven't made a routes-controller release since that was merged, so it's likely this isn't fully fixed yet :(

We haven't made a routes-controller release since that was merged, so it's likely this isn't fully fixed yet :(

As per yesterday discussion we did just not bump up the release so it should be fixed right?

Yes


Update http4s-blaze-server, http4s-circe, ... to 0.22.4

Updates

org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.22.2 to 0.22.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #217.


Explorer shows no data if latest epoch isn't populated

The explorer doesn't show any data at all if the latest epoch isn't correct. It should be able to show the epoch data and most recent blocks it has even if it's not up to date.

The problem here relates to the dataset being in an inconsistent state, and currently the API doesn't reject queries to avoid unexpected results. With this in mind, the change to the app should be limited to setting up response handling that just informs the user of the outage, rather than showing a loaders.


Check OS version before offering Upgrade

Just upgraded and now I can't use the app due to an OS version dependency.
BTW, thanks for the tool, it's really useful :)
EDIT: Some more info

Sorry, but we can't do this. See https://github.com/wulkano/kap/issues/386#issuecomment-363732919 for more info.


Typo in upstream URL

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/get-started/quickstart/fork-a-repo
What part(s) of the article would you like to see updated?
On the section Configuring Git to sync your fork with the original repository in bullet 6, the URL should point to the original owners repository and not its fork.
Additional information
No response

@ckarampa
Thanks so much for opening an issue! I'll triage this for the team to review :eyes:

Just realized that there is a linked PR. I will be triaging the PR for a review and not the issue 💖 .


Add subcommand to enable application management addon

There should be a subcommand that enables addon. For example,
clusteradm addon enable application-manager --cluster cluster1
clusteradm addon enable application-manager --all

which will perform the deployment step of:

the application subscription operator https://github.com/open-cluster-management-io/multicloud-operators-subscription#operator-deployment to the hub and
the application subscription addon deployment for the given cluster(s) https://github.com/open-cluster-management-io/multicloud-operators-subscription#add-on-deployment

/assign mikeshng

This feature has been merged in the PR https://github.com/open-cluster-management-io/clusteradm/pull/46


 on the "P2Pool: The best of both solo and pool mining" at https://www.getmonero.org/get-started/mining/, which currently redirects to https://www.getmonero.org/get-started/mining/{{ site.baseurl }}/2021/10/05/p2pool-released.html

I think we already have such split keys i.e. https://github.com/monero-project/monero-site/blob/abcf12c4ccac3e48bb4ff178f18bb8a95d94b029/_i18n/en.yml#L334

For the record, the broken link has been fixed in #1959, without splitting the string.
@netrik182:

I think we already have such split keys

We started using such split keys before translations were done one string at a time in Weblate. Translators had more context, since they edited the whole file. So that's not a good precedent.
@selsta Thanks for considering translation issues. Possible translation issues include:

Some languages might require a different noun case after, or instead of, the preposition in.
One might want to rephrase "More details in the announcement post" as "See the announcement post for more details", for example, when that's more natural in the target language.

I've worked with a commercial version of Weblate which automatically put all hyperlink code in a placeholder, but on the other hand:

I don't know how much work it would be to set that up.
It might be hard to make this compatible with YAML.
Sometimes I want to be able to edit a link as a translator, e.g. a link in a user guide to a third-party page that has been translated.


[5.8] Update AuthenticatesUsers.php for logout specific guard's user only

This change is effective for muti-guard-authentication if you want to logout only specific guard's user.
    public function logout(Request $request)
    {
        // Logout current user only by guard
        $this->guard()->logout();

        // Get the session key for this user
        $sessionKey = $this->guard()->getName();

        // Delete single session key (just for this guard's user)
        $request->session()->forget($sessionKey);

        return $this->loggedOut($request) ?: redirect('/');
    }

This is probably a breaking chance for people expecting the previous behavior. Please also explain why you need this and add a test for this. Thanks.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Allow "secure" examples/configurations  to run "rootlessly" (e.g., as an arbitrary user)

This implements several changes to allow the pods to run as arbitrary user id
throughout all of the lifecycle stages. Primarily this is by avoiding the need to
chown for certificates, etc., instead copying them to an emptyDir which gives them
appropriate ownership for the pod's securityContext.
The postgres cert job example also needed modification because the prior version
required root to be able to install additional packages for cert creation. Instead
I used an alpine/openssl image to create the certs in an initContainer, then
alpine/curl to store the certs in relevant secrets. The middle commit (currently
6256125 if it doesn't get rebased) just prevents writing certain potentially-sensitive
information to logs in case those aren't locked down as well as you'd like. I'd be
OK rebasing without that commit if desired.
Relevant "user story" is in #177
I'm not familiar with the testing mechanisms provided by helm, but for "verification",
I have deployed to two different clusters (one kubernetes and one openshift) that do
not permit containers to run as root (optionally defining runAsUser in relevant
securityContext to provide a specific userId rather than the runtime-assigned id).
In both cases, I was able to exec a shell in the zitadel-debug replicaset
container and verify that the files created had ownership of the running userId
and mode of 400.
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[x] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[x] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[x] No debug or dead code
[x] My code has no repetitions
[x] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] If possible, the test configuration is adjusted so acceptance tests cover my changes

Thanks for this great PR :partying_face:
I actually don't see a need anymore for the chown/copy init container altogether.
The defaults fsGroup 1000 and runAsUser 1000 with readOnly volume mounts are good enough IMO.
I committed my suggestions directly to this PR.
What do you think @bpow and @stebenz?

Thanks for looking over this! I agree that it's much cleaner to just use fsGroup and avoid the copying altogether. I think if going with that, though, it's probably safer to explicitly set defaultMode for the involved volumes (at least on the cluster I checked on, without doing so you end up with rw-r--r--).
I've pushed an additional commit with that change (and cleaning up an emptyDir volume in the debug replicaSet which is not needed if not copying secrets).


Fix "zeus test"

Attempt to fix currently failing zeus test (rspec, testrb) command (#213):

Rake::Task['test'] fails to invoke the test task. To fix this, use Rake::Application to load the app's Rakefile, and then invoke the test task.

After fixing the above, zeus test on an app using RSpec still does not work as expected because the test command falls through to Zeus::M. To fix, invoke the RSpec runner on the following condition:

no arguments are passed in zeus test, and

defined?(RSpec) == true

This means that if RSpec and other testing frameworks are in use (#149), zeus test will run the RSpec suite by default. To run another framework's suites, the user will have to run zeus test <path_to_other_suite>. Hopefully this is reasonable.

Thank you for this!!! Sorry I haven't gotten it merged before today! :heart: :purple_heart: :yellow_heart: :blue_heart: :+1: :+1:


Added Standard VAE and Multinomial VAE models (DIFFERENT PREPROCESSING)

Description
Added two notebooks with Standard VAE and Multinomial VAE to recommenders/examples/02_model_collaborative_filtering/
standard_vae_deep_dive
multinomial_vae_deep_dive
Also, added corresponding utils for this model to recommenders/reco_utils/recommender/vae:
multinomial_vae - contains classes for the model
standard_vae - contains classes for the model
sparse_vae - contains a function for binarization and a class for obtaining click matrix. This class is a modified version of AffinityMatrix class (can be found at recommenders/reco_utils/dataset/sparse.py /). There are 3 additional lines of code, which can be found by searching a comment "# LSECHANGE".
In this notebook we use Variational Autoencoders for recommending Top k items on MovieLens-1M dataset.
Also, the model has extension: using annealing to find optimal Beta. Using the model with optimal Beta has better performance than constant Beta = 1.
DIFFERENCE FROM PREVIOUS PR:
In these notebooks we are following the author's preprocessing procedure, i.e. filter out ratings below 3.5.
Then we convert positively rated items' ratings to 1s, while unrated items to 0s, in order to obtain click matrix.
However, we lose information about users' preferences when we filter out low ratings. Since we need true preferences in the testing set, to correctly compute NDCG, we found the way how to recover this lost information. We keep ratings below 3.5 in a separate dataframe, and use appropriate mapping to recover lost preferences of users in the test set.
In these notebooks we are following the author's preprocessing procedure, i.e. filter out ratings below 3.5.
Then we convert positively rated items' ratings to 1s, while unrated items to 0s, in order to obtain click matrix.
At first glance, this approach may look like, we lose information about users' preferences when we filter out low ratings so this may cost in performance of our model. However, by applying this filtering we make sure that if a movie is rated less than 3.5 from the users that they watched it, it will not be contained in the final click matrix. In this way, we are sure that the final click matrix contains movies that are preferred by at least one user. If we do not apply this filter, the final click matrix will be even sparser.
Since we need true preferences/ratings in the testing set in order to correctly compute NDCG, we found the way to recover the real rating instead of using “0”, “1”. We keep ratings below 3.5 in a separate dataframe, and use appropriate mapping to recover lost preferences of users in the test set.
Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[x] I have updated the documentation accordingly.
[x] This PR is being made to staging and not master.

This PR is similar to #1191 and it looks that have repeated code. Could you please merge the content and not repeat code?
About the other preprocessing, is this something that can be added into one notebook?

Miguel, this PR is indeed almost the same as PR #1191.
We can do it into one notebook, but we believe that the notebook will be too complicated.
Also , the models will not be comparable since each one of them should be trained with a different dataset.
As a result, we recommend to keep one of the two different preprocessing approaches:

PR # 1191 - does not apply any filtering. To obtain click matrix, converts ratings above 3.5 to "1" and everything below 3.5 to "0" as well as unrated items.

PR # 1193 - follows the chosen paper's approach with filtering out ratings below 3.5. To obtain click matrix, convert remaining ratings (i.e. 4 and 5) to "1", and everything else to "0".

@kmussalim about:

PR # 1193 - follows the chosen paper's approach with filtering out ratings below 3.5. To obtain click matrix, convert remaining ratings (i.e. 4 and 5) to "1", and everything else to "0".

I don't understand this. If you filter out ratings below 3.5, then you only have ratings 3.5, 4, 4.5 and 5. Then those that are 3.5 are set to 0 and the rest to 1? is that what you are doing?
In the paper they say the following: "We binarize the ex-
plicit data by keeping ratings of four or higher and interpret them as implicit feedback. We only keep users who have watched at least five movies."
Another question is, why do you need two different PRs if the only difference is the binarization? is there any other difference?

I don't understand this. If you filter out ratings below 3.5, then you only have ratings 3.5, 4, 4.5 and 5. Then those that are 3.5 are set to 0 and the rest to 1? is that what you are doing?
RESPONSE: Let us explain more clearly what we are doing. We do the filtering at the beginning in order to filter out the movies that don’t have any positive review (rating > 3.5). So, for example, if all the users rate a movie under 3.5, this movie will not exist in the final click matrix (we don’t need for recommendation if no one like it). We do that because of the sparsity (less sparse click matrix). The users-to-item interactions that exist in training set determine the movies that will exist in the final click matrix. As a consequence, using the user-to-item interactions of the training users we set 1 to the movies the user has rated > 3.5 and the rest of them – the movies that haven’t rated yet - to 0.
In the paper they say the following: "We binarize the explicit data by keeping ratings of four or higher and interpret them as implicit feedback. We only keep users who have watched at least five movies."
RESPONSE: In this PR we are following the process of authors described above. However, in order to calculate NDCG correctly, we found the way how restore ratings for data used for evaluation.
Another question is, why do you need two different PRs if the only difference is the binarization? is there any other difference?
RESPONSE: The difference indeed is only in binarization process. And we are not sure which one is better for the repo. As long as you decide which binarization is more suitable for the repo, we can close one of the Pull Requests.
Two options of binarization:
Option 1 (PR #1194): Follow paper's approach, keep ratings above 3.5 and interpret them as implicit feedback, and restore ratings for evaluation part.
Option 2 (PR #1191): Not to follow paper's approach, keep all ratings, assign "1" to ratings above 3.5 and "0" to ratings below 3.5 and to unrated items.
Finally, I just noticed that this PR is going to master, instead of staging.
RESPONSE: Is there any way to change it from master to staging ? Sorry for that, my fault.

updated base to staging

Two options of binarization:
Option 1 (PR #1194): Follow paper's approach, keep ratings above 3.5 and interpret them as implicit feedback, and restore ratings for evaluation part.
Option 2 (PR #1191): Not to follow paper's approach, keep all ratings, assign "1" to ratings above 3.5 and "0" to ratings below 3.5 and to unrated items.

I don't see how they are different, what would be the output in both cases for these 2 users:
ui = np.array([1, 5, 4, 0], [0, 0, 2, 5])

This PR is similar to #1191 and it looks that have repeated code. Could you please merge the content and not repeat code?
About the other preprocessing, is this something that can be added into one notebook?

In the 2nd PR and specifically in data filtering part we have to make sure that:

user-to-movie interactions with rating <=3.5 are filtered out. Applying this filtering we make sure that if a movie is rated less than 3.5 from the users that they watched this movie, it will not be contained in the final click matrix. If we fo not apply this filter, the final click matrix will be even sparser.
the users who clicked less than 5 movies are filtered out.
the movies which are not clicked by any user are filtered out.

In the 1st PR we did the same filtering without step 1). As a result, in the train_data may exist a column that contains only zeros. Another drawback is that in the train_data may exist movies that are not preferred so without applying filtering 1) it is possible that the model may recommend movies that are not preferred by anybody. The final NGCD metric of test set yields worst results in 1st PR in comparison to the 2nd PR.
So, if it is also accepted by you, we recommend to keep the 2nd PR as the final choice of code and proceed with the changes and corrections at this code.

user-to-movie interactions with rating <=3.5 are filtered out. Applying this filtering we make sure that if a movie is rated less than 3.5 from the users that they watched this movie, it will not be contained in the final click matrix. If we fo not apply this filter, the final click matrix will be even sparser.

I think a clean way to approach this is to leave PR 2 with the option of filtering out nothing, so instead of 3.5, you would add None. Would that be possible?

user-to-movie interactions with rating <=3.5 are filtered out. Applying this filtering we make sure that if a movie is rated less than 3.5 from the users that they watched this movie, it will not be contained in the final click matrix. If we fo not apply this filter, the final click matrix will be even sparser.

I think a clean way to approach this is to leave PR 2 with the option of filtering out nothing, so instead of 3.5, you would add None. Would that be possible?

We also checked the code and it looks like the low ratings are used inside the validation and test sets (_te). But this is not what the paper by Liang et al. is doing. In 4.1 they say that they remove the low ratings from Movielens, so they are not used at all. As they say, they treat the data as implicit feedback i.e. there are only positive labels in the data set (e.g. they can be interpreted as clicks).

hi, I hope you are ok, is there any advancement on this project?

for people that have done significant contributions to the repo, we ask them to be added in the author list:
If you are ok with it, please add your names here: https://github.com/microsoft/recommenders/blob/master/AUTHORS.md
Also, would you please add the description of the algos in the main page: https://github.com/microsoft/recommenders/blob/master/README.md#algorithms and in the algo page: https://github.com/microsoft/recommenders/tree/master/examples/02_model_collaborative_filtering


Elements taller than the page can be shown as not even partially visible

If your element is taller than the page, and it's top is above the page, and it's bottom is below the page, partialVertical can still end up as false.
Here's the problem:
var partialVertical =
        (rect.top >= containmentRect.top && rect.top <= containmentRect.bottom)
     || (rect.bottom >= containmentRect.top && rect.bottom <= containmentRect.bottom);

I suggest adding
     || (rect.top <= containmentRect.top && rect.bottom >= containmentRect.bottom);

Good find! Would you be interested in helping to put together a new test case?

Guys its not on npm, please merge


try to resolve #244

The problem was in impossibility to reuse router instance with multiple prefixes properly, because layer instance inside router was overwritten with new routes.
And it is real situation when previous routes won't be accessible anymore. That's why we need to create layer instance in every iteration.
At least, this fix resolves issue in #244 but I would to discover bad cases for this fix if they exist.

@jbielick

It looks like there's a test failure that might be related. Know what might be going on there?

@jbielick I tried with node versions 6.7.0 and 7.2.0
Tests in both ones passed properly.
Maybe there are some differences in tests on CI and repo itself?

@jbielick I investigated test failures and finally solved an issue!
The reason of failure is absence of param middleware in Layer's stack, because I created new one now according to solution of issue #244
So now I called param middleware injection manually, not the best I suppose but it works

@alexmingoia @jbielick ping

@jbielick  😞 I think this bug is really worth to resolve

Thanks for this work, @YanLobat . I'm hesitant to merge it because I did not perceive a lot of confidence in the changes being made. The tests were broken until it was realized param handlers weren't transferred to the new layer and I wonder what else might be missing. Additionally, this PR includes no tests to assert the solved issue—it does not protect against regressions and I would say the impact of creating a new layer and adding it to the stack doesn't seem completely scoped out. For a change that has such a broad reach of impact to the library I was hoping to see more information and explanation in the PR description, as well as tests and information on how users might need to change their code (or not change their code) in their applications to solve the issue. Any thoughts?

Thanks for reply @jbielick ! That PR will cause more memory consumption while shared routers are used because of creating new instances of router Layers. As well such thing as param should be reset if it presents. About tests, you are totally right. I will perform one. Example from #244 is worth for it?
And about impact, generally the pipeline how routers are built is still the same, I just investigated how routes is working generally and afterwards shared router usage, found a bug about layer immutability which you mentioned in issue #244. And resolved it. That's why I believe nothing is missing.

Any progress?

@wong2  I am so sorry for delay!! I'll add tests this week and will wait until @jbielick resolution

@YanLobat thanks! I believe lots of people are waiting for this!

@jbielick Hi, I updated tests and add one from #244
In latest comment I described how the PR works, hope all is fine.

Hi @jbielick. Any updates?
Or as far as I understand you are working on v8.x currently?

Can you remove package-lock.json from this PR?

There are no merge conflicts anymore! Like a miracle

I guess we can merge it now with no blockers. What're your thoughts @jbielick?

Why hasn't this been merged yet?

@jbielick Yes I can but it's pretty obvious for me that this one can be merged. Still don't get the reason why it's not merged yet.
@alexmingoia Can I have contributor access?
@DominusVilicus Have no idea.

@yanlobat I don’t wish to continue triaging issues and maintaining this lib, so if also like to recuse myself of updating the change log, publishing a new version (major, since this has implications for anyone who worked around this issue), and being the only one who could help resolve any issues that arise from this release.
I think you can contributor abilities if you would like to take that on and release this fix—that way if there are any issues you can also be able to address and fix those (merge PRs) without needing my help.
If I had the ability to give you contributor status I would. I don’t feel comfortable, personally, merging this and answering any questions in issues—there are many related to this and I believe that will continue to be the case (not all of them are solved by this PR—see issues tagged with “nested routes”).
/cc @alexmingoia

One thing I can say for certain is that the tests don’t cover all of the use cases for this lib and passing tests don’t provide the same confidence to me that they might to others. This became apparent when attempting to write 8.x

@jbielick Thanks for detailed feedback!

@YanLobat Why is package-lock.json touched in this PR? Are updated deps needed for this functionality?


[Bug]: Clipped Text on Welcome Page

Describe the bug
When running the application for the first time on an iPhone SE 2022 the welcome pages fail to display text correctly
Reproduce

Open Bitkit for the first time
See clipped text

Screenshots / Recording

Operating system
iOS 17
Bitkit version
1.0 (92)
Log output
No response

Thanks! Which phone are you using?

Thanks! Which phone are you using?

The iPhone SE 2022


Using this tool for another LSUN dataset + model

Hello! Thanks for creating this.
I am trying to use this tool with another model (the LSUN Churches dataset) with sliders that represent attributes.
As I understand it, these are the steps I need to take to configure this toolset to work with a different dataset + pre-trained network:

Make sure the format of the LSUN Churches dataset matches as described for other models

Change the config name as described here to config_name = ''stylegan2-church-config-f", referring to the pre-trained network found here

run models.get_pretrained('attribute-predictor') as described in the pre-trained-models section of README

Change the relevant attribute labels in the files that show up during this search

I am just wondering if there any obvious steps I am missing to get this working, I am very new to the world of GANs and toolsets. Thank you for your time 😊

Hi, currently we only provide the encoder and editing directions for the FFHQ dataset. For other datasets like LSUN Church, you need to first train the generator on this dataset, and then train the encoder. Finally, you need to extract the editing directions (this might be tricky; for FFHQ we can use the supervised label from the CelebA dataset, while for LSUN Church, you may need to rely on some unsupervised method). Putting all these together, you might be able to make it work on the LSUN Church dataset.

Hello! First of all thank you so much for your contribution. I'm trying to apply this code to a different Dataset as well. You mentioned that for FFHQ you used the supervised label from the CelebA dataset, but could you tell us what did you used for the LSUN Car dataset?

Hi, for the LSUN Car dataset, you may refer to some unsupervised methods for discovering editing directions like https://arxiv.org/abs/2004.02546.

Thank you very much for the reply! Will give it a try


tblproperties and Comment are not updated for incremental

Describe the bug
My use case is a model with materialization 'incremental'. Model already exists. I am adding tblproperties option to be able to set delta.dataSkippiongStatsColumn. This property is not set.
However, if I run a full refresh, the property is set.
Since I checked similar behavior for the Comment that is not updated in Unity Catalog.
Steps To Reproduce

Set or update tblproperties/comment on an existing incremental model
dbt run
Check in Databricks (DESC DETAIL table) or in the Databricks UI (for the comment) that the property is not set/updated

Expected behavior
Detect creation or update of the tblproerties and apply those.
Looking at dbt-databricks\dbt\adapters\databricks\relation_configs\incremental.py, config_components only contains TagsProcessor,
But:

the materialized_view's config_components contains [PartitionedByProcessor, CommentProcessor, TblPropertiesProcessor, RefreshProcessor,    QueryProcessor],
the streaming_table's  config_components contains [PartitionedByProcessor, CommentProcessor,        TblPropertiesProcessor,  RefreshProcessor].

But I am not sure how those are applied. For example I see that liquid clustering is applied specifically by  dbt-databricks\dbt\include\databricks\macros\relations\liquid_clustering.sql
I also see that tblproperties are only updated for Python (apply_tblproperties_python) in dbt-databricks\dbt\include\databricks\macros\materializations\incremental\incremental.sql
System information
The output of dbt --version:
Core: 1.8.4
Databricks: 1.8.4
Spark: 1.8.0

The operating system you're using:
Windows
The output of python --version:
Python 3.10
Additional context
Add any other context about the problem here.

I thought I had already addressed this for tblproperties, but apparently not.  I believe there is currently a PR for fixing it for table comments (should already work for column comments).

Thanks for reporting.


Server to server functions input is accepted in an unexpected way

Description
Server to server functions have some issues while handling the payload body.
Steps to Reproduce
As your docs describe, I just created something exactly as the example:
local nk = require("nakama")

local function http_handler(context, payload)
  local message = nk.json_encode(payload)
  nk.logger_info(("Message: %q"):format(message))
  return {["context"] = context}
end

nk.register_rpc(http_handler, "http_handler_path")

And try to call it:
curl -X POST "http://<IP_ADDRESS>:7350/v2/rpc/http_handler_path?http_key=defaultkey" \
     -d '{"some": "data"}' \
     -H 'Content-Type: application/json' \
     -H 'Accept: application/json'

Actual Result
But I got:
{"error":"json: cannot unmarshal object into Go value of type string","code":3}

Deeper Information
Actually I found that you treat the whole body as payload, and it should be passed as a JSON string, like:
curl -X POST "http://<IP_ADDRESS>:7350/v2/rpc/http_handler_path?http_key=somekey" \
     -d '"{\"some\": \"data\"}"' \
     -H 'Content-Type: application/json' \
     -H 'Accept: application/json'

Please look at this line: -d '"{\\"some\\": \\"data\\"}"'. It's a JSON string, which contains a JSON Object serialized as string. What the ...
And what i got in the logger in this case:
{"level":"info","ts":"2018-05-15T10:51:30.868+0800","msg":"Message: \"\\\"{\\\\\\\"some\\\\\\\": \\\\\\\"data\\\\\\\"}\\\"\""}

What a mess.
Expected Result
I hope that the whole body is treat as payload, unserialize it, and pass it as table to the Lua context.
Like this:
local nk = require('nakama')
nk.register_rpc(function (context, payload)
  nk.logger_info(payload['some']) -- get "data", no json_decode needed
end, 'func_name')

Environment
$ ./nakama --version
2.0.0+dev

This version is built from commit ea2bfb78e4f37659cd7f39fee54624e03c8d52de .

And this issue is also exists when returning values from lua. It can only return string values, which I think it should have the ability to return any JSON objects ...

This issue is still on released 2.0.0.

+1

@mask3000 The real reason for this issue is that Protocol Buffers had no direct concept which maps between a JSON object and a Protobuf type when we designed the API. So what happens is that the input has to be passed in as an escaped JSON string literal so that it can get through the GRPC gateway and be converted into a JSON object by the API server from the Protobuf string type.
It's possible to solve with an update to the way that endpoint works but it's difficult to do now in a way that doesn't break the current API contract. I'll have a look to assess when the change can be made with least impact.
In the meantime you can have a look at this for how to work around it - https://github.com/heroiclabs/nakama/issues/211#issuecomment-428841407

We still have this difficulty in the new version 2.6.0, consider fixing it soon?

@cdiaz I think I've covered in an earlier comment but the problem is that the game server is designed with a protocol buffers API (GRPC) and uses a HTTP gateway around that for wider compatibility with languages and game engines.
Protocol buffers does not have a data type which indicates the input is expected to be JSON. As a result we have no choice but to use a string input type and parse it as JSON later.
All of our official client sdks handle this for you but I'm open to ideas on how we could improve it?

This is resolved for the general case in 20d6ab3cfc2478c39498a4d261d23c9fd1906ef2 and will be part of the next release.
RPC hooks will accept an optional unwrap query parameter and receive/return any raw string payload without wrappers. The documentation will be updated to reflect this in time for the next release.

{"error":"json: cannot unmarshal object into Go value of type string","message":"json: cannot unmarshal object into Go value of type string","code":3}

So we are still there even on nakama v.2.12.0+650b506a. Documentation is not updated regarding adding &unwrap=true into query parameters

@skitsanos This is not a bug but a side-effect of how GRPC services do not allow unstructured data (JSON) to be described as part of a Protobuf definition. We've provided a workaround as you've seen with the use of unwrap=true as a parameter to intercept the raw JSON input direct from the HTTP request. We'll update the docs but this issue is resolved.


docs(translation): translate useImperativeHandle

Closes #403
Description
Translate the useImperativeHandle page.
Page URL: https://id.react.dev/reference/react/useImperativeHandle

Hi @resir014 @zainfathoni thank you so much for the review and suggestions, updated 🙏

Need to re-check @zainfathoni  @resir014

Help to re-review @zainfathoni @resir014

Hi @zainfathoni @resir014 need help to re-review 🙇 🙏

Merging blocked @resir014 @zainfathoni

@resir014, your call


Allow control of the default environment name

As per the marketplace instructions,

The environment will affect the Dockerfile that is used during build. If you select Debug, the build task will search for Dockerfile, otherwise it will search for Dockerfile.<environment>.

It would be really helpful to be able to specify which environment is default. E.g. if I set release to the default environment then when the environment is set to release it would use Dockerfile, and for any other environment it would use Dockerfile.
The default value for the default environment could be "debug" to preserve existing behaviour unless someone explicitly changes it

@stuartleeks Right now Debug is the default. What would you like to see changed?

I'd like to be able to customise the default value :-)
E.g. I'd like to be able to have the Release environment use Dockerfile, and the Debug environment user Dockerfile.debug
Does that make sense?

Yes, it does. The reason I did not do that, is that the syntax highlighting (and other tools support) usually stops working with the .debug or .release extension. I saw you send a PR, I will check it out now.

I use Visual Studio Code for a lot of Dockerfile editing and it is well-behaved with Dockerfile.something filenames, so I just assumed others were too :-)


Assets being proxied only one time

[x] I tried updating to the latest version.

[x] I can't, there is an issue.

[ ] I Am on Windows
[ ] I Am on Bash on Windows
[ ] I Am on Linux
[x] I Am on OS X

Description
When I use same asset (I'm my case image) with the same proxy options on the multiple pages, only last generated version being kept. In other words, I use image on three pages with same proxy settings, I see in logs that all three assets bairn written, but in the end only last one is beign kept.
Steps

Use asset with same settings on the several pages
Check generated assets

Expected
I've expect that all generated assets being kept and are accessible, but they are not.

Please provide an example repository that replicates the issue.

Also, if what you mean is that we only write a single asset, that is expected behavior, if you use the same source, with the same proxy settings, we do not run the proxy multiple times, we deliberately cache the asset, and you should get back the same digest, with the same url, every single time, regardless of where it is used, that is by design.

Yes, you are right. But it gets different digest every time I use it.

That's because of #451.  Which is referencing this issue, and part of a larger problem with the way we handle pre-proxy setup, caching.  So I'm going to close this in favor of a single issue with multiple references.


[Bug] App theme stays Light when system theme is set to automatically switch between Dark and Light themes

Describe the bug
When I set the system theme to be dark from sunset to sunrise, and set the DDG theme to system default, the app remains in light theme all the time.
How to Reproduce

Set your phone's dark mode to be automatically enabled from sunset to sunrise.
Open DDG app.
Go to Settings.
Set Theme option to "System Default".
Observe that the app always stays in light mode, even during the night.

Expected behavior
The app should be in dark mode from sunset to sunrise in your geographical region, and in light mode from sunrise to sunset. All other apps behave accordingly (Firefox, Bitwarden, Aegis, and Signal are few OSS app examples that behave correctly, might be useful when investigating the root cause of the problem)
Environment
- DDG App Version: 5.111.0
- Device: OnePlus 7T Pro
- OS: Android 11

Florisboard had the same issue, if that could help come up with a fix?
https://github.com/florisboard/florisboard/issues/1557

This issue occurs only below Android 12

Also, with System Default web content follows device theme. Only DDG UI does not.

We faced this problem last week,
our investigations leads us to appcompat library upgrade we did, apparently, this bug was happening due to our upgrade to 1.4.1
This bug is documented and reported here
https://issuetracker.google.com/issues/188681415

Dd

I've got this issue, still isn't fixed.
OnePlus 8T, Android 12

I still have this issue. To fix it, I have to go into Developer mode in the Android settings and override whatever the issue is. Whenever my phone resets, I have to go back into the Android Developer mode and turn the setting override back on. It's really annoying. Please fix.

I think there is need just small fix in Theming.kt:
fun AppCompatActivity.applyTheme(theme: DuckDuckGoTheme): BroadcastReceiver? {
    if (theme == DuckDuckGoTheme.SYSTEM_DEFAULT) {
        val themeId =
            when (resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK) {
                Configuration.UI_MODE_NIGHT_YES -> THEME_MAP[Pair(manifestThemeId(), DuckDuckGoTheme.DARK)]
                Configuration.UI_MODE_NIGHT_NO -> THEME_MAP[Pair(manifestThemeId(), DuckDuckGoTheme.LIGHT)]
                else -> THEME_MAP[Pair(manifestThemeId(), DuckDuckGoTheme.LIGHT)]
            }
        if (themeId != null) setTheme(themeId)
    }
    ....
}

And, by the way, in DuckDuckGoActivity there is fun isDarkThemeEnabled(): Boolean which duplicate wrong logic from applyTheme and not in use.

My brother, you figured it out. Guys, push the fix.

@malmstein cool theme refactoring, but please fix auto night mode, also this bug now in getThemedDrawable too.
UiModeManager provides only static information about night mode (yes/no/auto/custom), needs to get dynamic info about mode from Configuration.
I'll provide PR with fix.

@malmstein can you take a look to the comments inside this issue and the @simonvar proposal? Not sure if you are already addressing the issue inside your current project.

Fixed in https://github.com/duckduckgo/Android/pull/2447


[Front-End] User log-in functionality

Allow a user to create an account and be able to log in into the web-app

Turns out Auth0 deploys a log-in screen for us. Making the log-in and sign up page now seems a little redudant

ok. closing. the api is being developed to handle the requests coming from the webapp

redundant issue and completed


Speakers associated with session ID:364756 are not displayed

Describe the bug
As the title says.
To Reproduce

find マンガアプリのメモリ改善とメモリ解析方法 from the session
tap マンガアプリのメモリ改善とメモリ解析方法
check to see if the speaker appears
Speaker icons and names are not displayed.

Expected behavior
The icon and name of the speaker are displayed.
Screenshots

I will investigate this bug as I was in charge of the DB task.
#388

I didn't notice that. This must be problem. Great catch 🙏


support which ceph version

which version of ceph that the go-ceph support? anyone know that?

It will use the version of librados that you have installed locally...


feat(ci): uuid config, update channel to BETA [skip ci]

:tada: This PR is included in version 0.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Demo code does not work

This looks great, thank you for writing it. :)
$ rustc -V                                                                                101 ↵  ✭master
rustc 1.47.0 (18bf6b4f0 2020-10-07)

4 | fn main() -> Result<(), Error> {
  |    ----      ^^^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found `()`

OK, I just changed this to fn main() {
6  | |   let cue = Cuna::open(file)?;
   | |             ^^^^^^^^^^^^^^^^^ cannot use the `?` operator in a function that returns `()`

Removed the ?.
error[E0609]: no field `comments` on type `std::result::Result<cuna::Cuna, cuna::error::Error>`
 --> src/main.rs:7:18
  |
7 |   assert_eq!(cue.comments[0], "GENRE Pop");
  |                  ^^^^^^^^

Not so sure how to get around this...

I forgot to return Ok(()) in the end. Thanks for your feedback.


Getting 502 from backend

Hey! Thanks for letting me know. When I checked earlier, I found the same thing as you. But now when I check it seems to be back. Could you confirm if it's back for you or not? Service provider may have had an outage.

Sorry for the late reply. Yes it started working the day after. Thanks for waybackhn!


implementation of issue #289

Hello guys,
I just implement the issue 289.
I notice that in appsettings.docker.json there is a begin of implementation of azure storage (not sure here). Anyway, I leave it as is and implement the changes in appsettings.json.
I also change the "SimplCommerce.WebHost.csproj" including the WindowsAzure.Storage package. I didn't find the problem of just add in the new package. The solution was to add in the webhost project.
The configuration and usage it's the same of AWS implementation.
Hope you find useful!
Thanks

Hello Thiennn,
I notice that when the below code is executed, the dll WindowsAzure.Storage is blowing the "Could not assembly....."
foreach (var file in binFolder.GetFileSystemInfos("*.dll", SearchOption.AllDirectories))
{
Assembly assembly;
try
{
assembly = AssemblyLoadContext.Default.LoadFromAssemblyPath(file.FullName);
}
catch (FileLoadException)
{
That was the main reason why I added WindowsAzure.Storage in WebHost project.
Not sure what is causing this error.
I'm thinking maybe use ILMerge or another tool to generate a single dll. Maybe this is a possible solution to our problem. I'll investigate.
What do you think about that?

Please check whether the WindowsAzure.Storage dlls are included in the WebHost/Modules/SimplCommerce.Module.StorageAzureBlob/bin.
.NET Core by default doesn't include package dependencies in the bin folder on build. The temporary workaround is adding true will change this default behavior. The downside of this is many ASP.NET Core dlls are also included.

Hi @thiennn,
Sorry for the very late response. I'll implement a newer version of this issue.
Can you delete this pull request?
Thanks,


Cannot open .py files from Box

Issue Report Checklist

[y ] Searched the issues page for similar reports
[y ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[y ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ y] Tried basic troubleshooting (if a bug/error)

[ y] Restarted Spyder
[ y] Reset preferences with spyder --reset
[ y] Reinstalled the latest version of Anaconda
[ y] Tried the other applicable steps from the Troubleshooting Guide

[ y] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Cannot open python files stored in Box. If I click open file then nothing happens. In the right hand files pane, the files that I cannot open appear as below, the test.py file in the same folder opens and runs correctly.
If I right-click on the .py files and run from the files pane, then it opens a new console window and runs the file from there (but I would like to be able to edit them).
The files that do not run are stored in a Box cloud folder, and I copied them into Box. The test.py (which opens fine) I created in Box.

What steps reproduce the problem?

Copy .py file into Box
Open .py file from spyder

What is the expected output? What do you see instead?
Expecting .py files to open in editor.
 The problem is that they are detected as binary, but without seeing their contents, we won't be able to understand why.

Could it be that there is synchronization on demand (like dropbox) so that files in the computer are "dummy" files  and only when clicking them (from the system fileexplorer) they get downloaded?

Interesting @goanpeca. That could certainly be the problem here.

Thanks @ccordoba12 @goanpeca
Attached is an example file (saved as txt). Interestingly when I opened the .py file in notepad and then resaved into the same Box folder spyder could then open it correctly.
I think the issue is something like what @goanpeca said. I did try the option to 'Make files available offline' in Box but that didn't work. Thanks
Q21_importance_discounts_EXAMPLETOUPLOAD.txt

The file looks fine and opens correctly in Spyder. So I think @goanpeca is right and this is a problem with Box.
Sorry but we don't the resources to give you more support about it.


Veles Core version v<IP_ADDRESS>

 Issue by virtuado
Monday Mar 18, 2019 at 17:16 GMT
Originally opened as https://github.com/velesnetwork/veles-archive/issues/32

There is an rpcworkqueue issue with this wallet, and perhaps with the new version as well..., which causes the masternode monitoring service at masternodecap.com to stop after some period of time.
There has been some communication between the team of VLS and masternodecap and a suggestion from the side of VLS team was that the number could be raised to solve this problem.  But after this it happened again. So it seems that raising the number will not solve the issue?

 Comment by velesnetwork
Sunday Apr 21, 2019 at 18:59 GMT

Doesn't seem like a issue with the Veles Core daemon itself, the rpc work queue limit it's more a feature of new wallets than a bug, we'll be working on the article on how to correctly implement Veles daemon in high load environments.


[Event Request] Table 480 - OnGetDimensionSetIDCheckFound

Hi, we would need event in table 480 on function GetDimensionSetID
We need event in following place:
...some code...
        Found := true;
        DimSetTreeNode."Dimension Set ID" := 0;
        repeat
            DimSetEntry.TestField("Dimension Value ID");
            if Found then
                if not DimSetTreeNode.Get(DimSetTreeNode."Dimension Set ID", DimSetEntry."Dimension Value ID") then begin
                    Found := false;
                    DimSetTreeNode.LockTable;
                end;
NEW->       OnGetDimensionSetIDCheckFound(DimSetEntry,Found);
            if not Found then begin
                DimSetTreeNode."Parent Dimension Set ID" := DimSetTreeNode."Dimension Set ID";
                DimSetTreeNode."Dimension Value ID" := DimSetEntry."Dimension Value ID";
                DimSetTreeNode."Dimension Set ID" := 0;
                DimSetTreeNode."In Use" := false;
                if not DimSetTreeNode.Insert(true) then
                    DimSetTreeNode.Get(DimSetTreeNode."Parent Dimension Set ID", DimSetTreeNode."Dimension Value ID");
            end;
        until DimSetEntry.Next = 0;
...some code...

Publisher will be:
LOCAL [IntegrationEvent] OnGetDimensionSetIDCheckFound(VAR DimSetEntry : Record "Dimension Set Entry";VAR Found : Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Understanding question : How does aerostack close the loop in real time (like Co-simulation) ? Time synchronisation between the simulator (Gazebo Ignition) and the Aerostack code (Python interface etc)nd the

I am trying to use aerostack for a realtime simulation. I want to know how do you use close the loop in the simulation ? How do you do time synchronised simulation between the aerostack python node and the simulator ? Eg:- Do you use a flag to stop and start the simulator to synchronsie etc. Please let me know, I want to know about the framework more.

@javilinos is the one working on how to pause and resume the Gazebo simulator through ROS 2

Hi @vbalaji21, pausing and resuming simulation via ROS 2 service is pretty straight forward. You can check branch 254: as2_gazebo_assets/bridges/bridges.py at the end of the file to see how its added to Aerostack2. Aditionally, check ros_gz_bridge readme to learn how to execute ros_gz_node in order to map gz world control service to ROS 2 service via terminal.

Stale, closing