[DO NOT MERGE][#163694261] Workaround tech-docs-gem bug by using HTML headings

What
There is a bug [1] in tech-docs-gem that causes identical headings on different
pages to be generated with incorrect identifiers. The behaviour is correct for
headings on the same page, but not for different pages as here. Jon Hallam, Jon
Glassman, and I agreed that a workaround using HTML headings was suitable here.
[1] https://github.com/alphagov/tech-docs-template/issues/180
How to review
Describe the steps required to test the changes.

Code review
Preview the content locally (see README) and check that it renders as expected.
Check that all the table of contents headings under "Deploy a backing or routing service" work, and go to the right part of the page

Who can review
@jonathanglassman

@AP-Hunt Demonstrated to community so ok to merge


Fix test snapshots

Fix tests broken by https://github.com/eddmann/serverless-fargate/pull/23 & https://github.com/eddmann/serverless-fargate/pull/25

Thanks for the PR, have pushed the fix for this 👍🏻


chore: exact? runs nonspecific lemmas too

Previously, exact? has only indexed lemmas with a "specific" DiscrTree key (this meant: anything except #[star] or #[Eq, star, star, star]).
This means that it wouldn't apply some very general lemmas, e.g. le_antisymm.
The performance improvement here is pretty minor: the DiscrTree returns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed).

[ ] depends on: https://github.com/leanprover/std4/pull/369

bors d+

bors merge


QR code doddled too crude when screen scale resized

I'm opening this issue because:

[X] I have found a bug
[ ] I want to request a feature
[ ] I have a question
[ ] Other
0.6.1 Windows binary(no Go env), Win10 2004 19041.208,screen scale 150%.
The QR code can't be recognized by usual QR code readers.
Wonder if can be fixed under current command-line version or can only be fixed in future GUI version.

Hello, thanks for reporting. This issue is related to the font used in Windows terminal. Can you please use a monospace font and let me know if that works for you?
Other people are reporting similar issues on Windows in this issue: https://github.com/claudiodangelis/qrcp/issues/95

I meet the same problem.

Also Win 10, in Chinese language env.
Changing the font in terminal makes no difference.


feat: expose endpoint_type

Description
Exposed endpoint_type to allow for private secret manager.
Related issue: https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager-private-cert-engine/issues/182
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

Upgrade test failed because status of endpoint_type changes. I verified that nothing would be deleted, only updated in place.
  ~ update in-place

Terraform will perform the following actions:

  # module.private_secret_engine.ibm_sm_private_certificate_configuration_intermediate_ca.intermediate_ca will be updated in-place
  ~ resource "ibm_sm_private_certificate_configuration_intermediate_ca" "intermediate_ca" {
      + endpoint_type                     = "public"
        id                                = "us-south/98367c0d-7973-4467-bc84-694801d7979a/intermediate-ca"
        name                              = "intermediate-ca"
        # (31 unchanged attributes hidden)
    }

  # module.private_secret_engine.ibm_sm_private_certificate_configuration_root_ca.private_certificate_root_ca will be updated in-place
  ~ resource "ibm_sm_private_certificate_configuration_root_ca" "private_certificate_root_ca" {
      + endpoint_type                     = "public"
        id                                = "us-south/98367c0d-7973-4467-bc84-694801d7979a/root-ca"
        name                              = "root-ca"
        # (34 unchanged attributes hidden)
    }

  # module.private_secret_engine.ibm_sm_private_certificate_configuration_template.certificate_template will be updated in-place
  ~ resource "ibm_sm_private_certificate_configuration_template" "certificate_template" {
      + endpoint_type                      = "public"
        id                                 = "us-south/98367c0d-7973-4467-bc84-694801d7979a/my-template"
        name                               = "my-template"
        # (41 unchanged attributes hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.```

/run pipeline

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Release Candidate 0.1

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8a303a3). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

src/mixins/seedable.py
84.61%
4 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   97.50%
=======================================
  Files           ?        4
  Lines           ?      160
  Branches        ?        0
=======================================
  Hits            ?      156
  Misses          ?        4
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update certs

Codecov Report

Merging #852 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
- Coverage   90.92%   90.73%   -0.19%
==========================================
  Files          87      112      +25
  Lines        6060     7994    +1934
==========================================
+ Hits         5510     7253    +1743
- Misses        351      461     +110
- Partials      199      280      +81

Impacted Files
Coverage Δ

internal/protocol/version.go
100% <0%> (ø)
:arrow_up:

ackhandler/received_packet_history.go
100% <0%> (ø)
:arrow_up:

handshake/mint_utils.go
51.52% <0%> (ø)

handshake/server_config_client.go
88.24% <0%> (ø)

handshake/stk_generator.go
90.24% <0%> (ø)

crypto/aesgcm12_aead.go
75% <0%> (ø)

crypto/aesgcm_aead.go
81.82% <0%> (ø)

crypto/cert_compression.go
86.16% <0%> (ø)

crypto/null_aead.go
100% <0%> (ø)

handshake/connection_parameters_manager.go
98.37% <0%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4de9a...a4073bf. Read the comment docs.


Update z-index to be "less than 1000"

This conflicts w/ our application/branding bar headers and causes it to float over top.

crap I thought this was an issue and included a fix in 0.6.0
https://github.com/tietgenlabs/auditory_demos/commit/6714ca64da2382b40bf11d066969bb4b4387ff2a#diff-0d59017008d29bfc4c690229c3b8fc9fR64

going to close this


Key Icon

Icon Request

Icon name: key
Tags of this icon: key
Use case: Lock key
Screenshots of similar icons:

Hi Dotintechno,
We've finished the design of Key Icons.
You can get Key icons from the Life folder on GitHub or our website.
They are also available in fonts files.


 Fixes ##6693

Fixes ##6693

Please can you sign-off your commits to pass the DCO check?

@henrywangx Please can you sign-off your commits to pass the DCO check?

@henrywangx Please can you sign-off your commits to pass the DCO check?

@sarabala1979 done. Meanwhile I'm wondering how we cherry pick this fix into other releases after merged(sorry, I'm new to open source contribution).


About the evaluation on LOL-Blur

When I tried to follow its results on LOL-Blur, I noticed that CIDNet uses "low_blur" as the input for training and inferencing instead of the "low_blur_noise" folder in the LOL-Blur dataset.
I found this to be a different experimental setup from existing methods (i.e., LEDNet, VQCNIR) designed for joint low-light enhancement and deblurring. Does this mean that CIDNet is based on the noise-free assumption?
If I want to train your model with ‘low_blur_noise’ and ‘high_sharp_scaled,’ can I just use the configuration of LOL-Blur in the GitHub repo?
I would appreciate it if you could provide any valuable information :)

For the first question, the answer is no. The LOL dataset itself already contains real noise in low-light environments, and the same is true for the Real dataset in LOLv2. Whereas the noise of low_blur_noise in LOL-Blur is simulation-generated, we believe that LOL and LOLv2 are sufficient to demonstrate CIDNet's ability to eliminate real-world noise.
For the second question, you just need to change the path of low_blur to the path of your low_blur_noise. The easiest way to do this is to replace all the images in low_blur with low_blur_noise in the LOL_blur folder, in the train,test,eval folders, and you won't have to change any code.

Thanks for your patience


xmpp-jid fails to install optional dependency

xmpp-jid is using an older version of node-stringprep which fails to install on Node v7.6.0.

xmpp-jid is not part of node-xmpp see https://github.com/otalk/xmpp-jid
Ours is @xmpp/jid https://github.com/node-xmpp/node-xmpp/tree/master/packages/jid

D'oh, sorry about that.


Outstanding items to include

From #1

[ ] Callbacks and Webhooks [Advanced]: What’s the difference, with examples. #76
[ ] Schemas [Advanced]: examples for schemas, responses and parameters.
[ ] Security [Advanced]: securityScheme and security.

@MikeRalphson as per on Slack message I'm happy to pick up Security above based on the content I'm producing for the OAI training course. Let me know if that helps at all - and if work is not already in progress somewhere - and if so please can we split into a separate ticket.

Thanks @SensibleWood , I'm pretty confident the work is not already in progress somewhere so we'd be more than happy for you to contribute! If you want to create an issue for what you're working on and assign it to yourself, that will also make it clearer for anyone else wanting to do the same thing.
We don't have detailed writing guidelines here, so take a look at what we have already and try to blend your knowledge in?  Thanks for helping!

Nice one @lornajane I will make it so right now

I've noticed something missing from the examples and I'm wondering if this open item would be the place to address it.
I have a case where a parameter is an array whose items point to a $ref, like this:
paths:
  /test:
    get:
      operationId: getTest
      parameters:
        - in: query
          name: test
          schema:
            items:
              $ref: '#/components/schemas/Test'
            type: array

Would this be suitable under the open to-do for Schemas [Advanced]: examples for schemas, responses and parameters?

@njbair Would you like to create a pull request adding an example with an array parameter whose items are defined by a Reference Object?

@ralfhandl I would be happy to. I'm sure there are other advanced cases that could be addressed in the same example, but I'll start simple and folks can always add more later.
I'll start working on a PR shortly.


g h shortcut doesn't work when mouse cursor is not hovering the editor

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
When vim mode is enabled, i can use g h to show the overlay that normally shows up when hovering something with the cursor in the editor. This only works if the cursor is hovering the editor area. When i move the cursor to, for example, the project dock, hitting g h simply doesn't do anything. I would expect the shortcut to show me the same overlay again.
In this screen recording, you can see that at the end of the video, nothing happens, even though i'm using the shortcut.
https://github.com/zed-industries/community/assets/1936709/318e7580-d5b5-44d4-96b8-43ba086944bb
Environment
Zed: v0.113.0 (stable)
OS: macOS 14.1.1
Memory: 16 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

This should be fixed in preview v0.119.6.


x/sys: apply https://go-review.googlesource.com/3983/

This is just a gofmt CL for part of the darwin/arm port, not worth calling out as a separate issue.


Impossible object method call: Unique validator filter

e.g.
The filter validator and the when option allows a callable. Like this.
Unique validator filter
The same doesn't happen here.
...
/* @var string|array|\Closure */
...
if ($this->filter instanceof \Closure) {
    call_user_func($this->filter, $query);
} elseif ($this->filter !== null) {
    $query->andWhere($this->filter);
}

This is useful when you want to serialize the model, reuse the filter or organize the function.
Solutions
To avoid BC as the filter allows an array:

Change instanceof \Closure for is_callable.
Check for method_exists.
Check if the first element of the array is a string.

I suppose changing to is_callableshould be safe. It is unlikely filter value meant to be passed to Query::andWhere() will ever match such check.

is_callable will make it possible to pass PHP function names and various other things. Need to be verified that it's safe.

We are talking of the validation rule, which is set up by developer - not got from user or something.
Of course construction like ['DateTime', 'format'] will be a callable, but it is unlikely to be a filter.

Although we may enforce filter to be not scalar, avoiding plain function calls, just in case.


formulate requirements

@h1alexbel i think we need to have a precise list of features for 0.0.1 version

@l3r8yJ I think here is the list:

Full GitHub API mirror with help of Open API contracts
Web server that with mirrored endpoints
JSON responses from fake API
XML storage
cli tool, for instance fakehub, that would support start and stop commands

in the next versions we can try to render nice HTML pages from XML storage that we have.
WDYT?

@l3r8yJ if it looks good, I can open separate issues for each of the points

@h1alexbel i think for ‘0.0.1’ version, we can’t afford all endpoints, i suppose that we need to specify a precise list of endpoints to support

@l3r8yJ Yes, in 0.0.1 we should implement most required functions, like repositories, pulls, issues (I will craft a list a bit later). Though, we still should mirror all the endpoints GitHub API currently supports. We can stub non-0.0.1 functions, and incrementally implement them in future releases. WDYT?

@h1alexbel sure, but i think we need to group them by milestones

@l3r8yJ let's start with these functions:

public GitHub instance
users
repositories
pull requests
issues
git (objects, file, blobs)

WDYT?

@l3r8yJ updated list with more precise functions

@l3r8yJ the puzzle #28 is still not solved.

@l3r8yJ created issues for concrete endpoints. I think in version 0.0.1 we can omit blobs, commits, and
file trees. WDYT?

@h1alexbel okay

@l3r8yJ the only puzzle #28 is solved here.


add reentrancy

Two remaining problems.

Users have to clone and copy protobuf/protoc-gen-go-grain/options/options.proto, in order to use options. grpc-gateway also uses this method.

Users have to unmarshal *cluster.GrainResponse to response type when using reenterancy. I cannot find a place to do this automatically.

                f, err := client.InvokeServiceFuture(&InvokeServiceRequest{Name: "Bob"})
		ctx.ReenterAfter(f, func(resp interface{}, err error) {
			if err != nil {
				onError(err)
				return
			}

			switch msg := resp.(type) {
			case *cluster.GrainResponse:
				result := &InvokeServiceResponse{}
				err = proto.Unmarshal(msg.MessageData, result)
				if err != nil {
					onError(err)
				}
				respond(&InvokeServiceResponse{
					Message: req.Name + " from " + ctx.Identity() + " and " + result.Message,
				})
			case *cluster.GrainErrorResponse:
				onError(errors.New(msg.Err))
			default:
				onError(errors.New("unknown response"))
			}
		})

@qazwsxedckll , we could get rid of GrainResponse completely. see https://github.com/asynkron/protoactor-go/issues/994
it is just a wrapper of the result message and don´t really bring any value

This looks fantastic!

I suddenly realized that the respond and onError callback are not neccessay. You can just call ctx.Respond() indise ctx.ReenterAfter(). I was just imitating the interface in dotnet.


Scan import

Hello,
I have an issue when I'm trying to import scan with 'api/v2/import-scan/'
I tried a LOT of things, but I'm still not able to import a scan.
Here is my code :
url = url + 'api/v2/import-scan/'
headers = {'Authorization': 'Token xxxxxxxxxxxxxxxxxxxxxxxxxx'}

now = datetime.datetime.now()
date = now.strftime("%Y-%m-%d")

dict_ = {
    "scan_type": scan_type,
    "file": file,
    "engagement": 19
}

multipart_form_data = {
    'scan_date': '2021-09-08',
    'file': (file, open(file, 'rb'), 'text/json'),
    "scan_type": "Semgrep JSON Report",
    "engagement": 19
}

print(dict_)
r = requests.post(url, headers=headers, files=multipart_form_data)
print(r.status_code)

I got the error : 500 Internal Server
Can you help me ?
Thank you in advance.

Can you provide more info as requested in the big report template?

Hello,
Sorry completely forgot.
Slack us first!
The easiest and fastest way to help you is via Slack. There's a free and easy signup to join our #defectdojo channel in the OWASP Slack workspace: Get Access.
If you're confident you've found a bug, or are allergic to Slack, you can submit an issue anyway.
Be informative
I have an issue when I try to import scan with 'api/v2/import-scan/' via a Python script.
I tried a LOT of things, but I'm still not able to import a scan.
Bug description
I got the error : 500 Internal Server as a status code.
url = url + 'api/v2/import-scan/'
headers = {'Authorization': 'Token xxxxxxxxxxxxxxxxxxxxxxxxxx'}

now = datetime.datetime.now()
date = now.strftime("%Y-%m-%d")

dict_ = {
    "scan_type": scan_type,
    "file": file,
    "engagement": 19
}

multipart_form_data = {
    'scan_date': '2021-09-08',
    'file': (file, open(file, 'rb'), 'text/json'),
    "scan_type": "Semgrep JSON Report",
    "engagement": 19
}

print(dict_)
r = requests.post(url, headers=headers, files=multipart_form_data)
print(r.status_code)

Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
Status code : 200
Deployment method (select with an X)

[ ] Docker
[ ] Kubernetes
[X ] GoDojo
[ ] setup.bash / legacy-setup.bash

Environment information

Operating System: Kali
DefectDojo Commit Message: /

Sample scan files (optional)
/
Screenshots (optional)
/
Console logs (optional)
/
Additional context (optional)
/

What's in the logs?

2.1.0
In the log :
x.x.x.x- - [08/Sep/2021:20:07:36 +0200] "POST /api/v2/import-scan/ HTTP/1.1" 500 216848 "-" "python-requests/2.25.1"

Can you try with 2.2.1? We fixed the logging of errors so there should be details in the logs.

Yes I can, but I'm not sure how to do to upgrade to 2.1.1.

I think you need to have the fields like scan_type and engagement in a separate dictionary which is given to the request as data. So something like:
payload = {
    "scan_type": "Semgrep JSON Report",
    "engagement": 19
}

multipart_form_data = {
    'file': (file, open(file, 'rb'), 'application/json'),
}

r = requests.post(url, headers=headers, data=payload, files=multipart_form_data)

Not having it tested in detail, more a sketch.

Hello @StefanFl ,
Thank you very much for your reply, it works now.
Best regards.


Is there a way to access the card type value?

I need a way to get the card type value. Is there a way to that atm?
Thanks for the hard work!

Hey! Sorry we don't have a way to pull out the card type value right now! :( I'll flag this issue as up for grabs.

+1

@kamir222 and @danireginatto will that PR below help you

https://github.com/medipass/react-credit-card-input/pull/42

I am currently finishing up a new package for using payment inputs with React which addresses this issue, which I hope to publish very soon!
If you're interested, I'm planning to add a migration guide to migrate from react-credit-card-input to the new package - don't worry, it will be a small migration.
I'll comment here again once it's published. :)

Thanks @igorlima!
@jxom that would be much appreciated. :)

We have just recently published a new library, React Payment Inputs which is a rewrite of react-credit-card-input, and fixes a lot of issues that were raised in this repository as well as a few extra enhancements.
Your issue that you raised here should be fixed in React Payment Inputs - however, if you wish to still use react-credit-card-inputs, I'll try find time to fix this issue in the future.


级联选择器功能出一个选择即改变的吧 changeOnSelect 这个属性

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Browser: chrome<IP_ADDRESS>

What is expected?
级联选择器功能出一个选择即改变的吧 changeOnSelect 这个属性

Duplicate of #3395


Implement SDK request and grpc request timeouts

Problem
Should be able to set individual request timeout and grpc request timeouts.
Solution

Implement Exectuable.setGrpcDeadlline(Duration)
Implement Client.setRequestTimeout()
Implement Executable.execute(client, timeout)

These methods do not work.
Steps to reproduce
Use Client.setRequestTimeout() and Executable.execute(client, timeout)
Alternatives
No response

Fixed directly on develop https://github.com/hashgraph/hedera-sdk-js/commit/f67256e80b44e8355f2e9c19da0acb12622d17b8


SASS files are missing

I am doing jekyll serve on my local machine but I keep getting this error.
Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss':
File to import not found or unreadable: base. Load path: /Volumes/Work/Blog/nomanurrehman.github.io/_sass on line 46
Lookin at line 46, it seems all the files included are missing from the _sass directory namely base.scss, layout.scss, and syntax-highlighting.scss.
// Import partials from sass_dir (defaults to _sass)
@import
"base",
"layout",
"syntax-highlighting"
;
Am I missing something?

Maybe you're using an old version or have files from another theme? Is this from a new fork or did you add files to an existing Jekyll site.
The stylesheet the theme uses is main.scss and doesn't use any of the Sass partials you're getting errors for (base, layout, etc.). Leads me to believe you have some old files floating around in your repo from another theme.

Yup I was right. You have another main.scss file in /css/. No idea what that's for but it's looking for those Sass partials. My theme doesn't use that so remove it if you aren't using it for something.

Thanks for such a quick reply, really appreciate that.
And sorry for troubling you for no reason.


Refactor DigestItem

Fixes #2083

[clabot:check]

One last nit: let's tag all the DigestItem variants with codec indices so they remain stable even when renaming. We are most likely going to rename Consensus to Seal2 in a follow-on and that would  be annoying if it breaks codec.


Text blends in on light mode for guides which have the chat-like pages

In light mode it seems that the text blends in, this is something which should be fixed. Heres a screenshot of it:

This will be looked into


error when trying to build hetero-mark

I'm looking at Hetero-Mark and following the instructions for building it. cmake seems to have had no errors, however when I try building, I get the following:
[ 16%] Building CXX object src/common/cl_util/CMakeFiles/cl_util.dir/cl_profiler.cc.o
[ 17%] Building CXX object src/common/cl_util/CMakeFiles/cl_util.dir/cl_runtime.cc.o
/home/ubuntu/Hetero-Mark/src/common/cl_util/cl_runtime.cc: In member function ‘_cl_command_queue* clHelper::clRuntime::getCmdQueue(unsigned int, cl_command_queue_properties)’:
/home/ubuntu/Hetero-Mark/src/common/cl_util/cl_runtime.cc:207:36: error: ignoring attributes on template argument ‘cl_queue_properties {aka long unsigned int}’ [-Werror=ignored-attributes]
std::vector<cl_queue_properties> queue_properties;
^
cc1plus: all warnings being treated as errors
src/common/cl_util/CMakeFiles/cl_util.dir/build.make:158: recipe for target 'src/common/cl_util/CMakeFiles/cl_util.dir/cl_runtime.cc.o' failed
make[2]: *** [src/common/cl_util/CMakeFiles/cl_util.dir/cl_runtime.cc.o] Error 1
CMakeFiles/Makefile2:366: recipe for target 'src/common/cl_util/CMakeFiles/cl_util.dir/all' failed
make[1]: *** [src/common/cl_util/CMakeFiles/cl_util.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

I was experiencing the same issue when I've tried to compile it with openCL12 option.
I tried removing "" from the script:
from cmake -DCOMPILE_OPENCL12=On ..\
to cmake -DCOMPILE_OPENCL12=On ..
and the problem was solved

So this appears to be only in the OpenCL code... at least I can compile the CUDA stuff without error.


Bug: v0.15.1 stopped working

Thanks for the great formatter and plugin!
I'm facing an issue with the latest version; it seems to stop autoformatting,
also I can't find dprint command in command prompt to format. I rolled back to
v0.15.0, which works fine. Any tips for debugging the problem so I can provide
more information? Thanks!

I don't understand why 0.15.1 wouldn't work, but 0.15.0 would. What does your setup look like? Are you using dprint from npm? What is the output in the "dprint" selection in the "output" window in vscode?

also I can't find dprint command in command prompt to format.

How did you install it? Is it a local npm package for the project or was it installed globally?

I'm using the following configuration:
Linux 6.5 Fedora Linux 38
VSCode v1.83.1

dprint v0.41.0 installed within the project's node_modules directory, along with the latest plugins:
- typescript-0.88.2.wasm
- json-0.18.0.wasm
- markdown-0.16.2.wasm

Interestingly, after switching back from version 0.15.0 to the latest one, the
integration started working again. I apologize for not capturing any output
during the issue. If I encounter any more problems, I'll provide better
debugging information.


Run e2e tests without bundler

#883 still left in the bundle install before gem build.
Changes all e2e suites to gem build + gem install and skip bundler.

Already done elsewhere


Consider Non-breaking space (unicode spaces) as regular spaces for formatting

Hey,
if we have for example no-break spaces in ## (aka h2) elements, they don't get transform into <h2> elements because the library checks whether or not a "regular space" is used. A no-break space would be this:   aka U+00A= (info here: https://www.compart.com/en/unicode/U+00A0)
Also GitHub does not consider them (whereas stackedit.io does recognize them).
## This should be an h2 element
If you have a Mac you can easily reproduce this with Option+SpaceBar, which produces the non-breaking space.
My request would be to include those characters as valid space-bars so that the above example would work.
I am not sure what the Markdown specification says about those "unicode spaces".

I think GitHub may have stripped these characters from your example.
Do you mean if the heading is "#\u00A0# foo"? Or ## f\u00A0oo?
For the former, that doesn't make sense as the input, just like it wouldn't make sense with regular spaces # # foo. The spec doesn't mention that anything can be in between the # characters.

The latter example ## f\u00A0oo.
This example "should" work: ## My h2 title.
You can copy&paste this into a website like this, which shows you non-printable characters.

I think the spec says ## must be followed by a space or a tab (not a unicode in the space category), so if you look at all other CommonMark compliant parser here they don't parse ## foo correctly either.
So I would say, it's constrained as per spec, and so won't fix. Thoughts @MihaZupan ?

The opening sequence of # characters must be followed by spaces or tabs

My interpretation of the spec is that same as @xoofx.
If the spec intends for the broader interpretation of whitespace, it generally explicitly calls it whitespace or Unicode whitespace.
Given that commonmark.js and GitHub don't support it either, I would also lean towards not changing anything in Markdig.
In any case, you can apply the fix on your side
markdown = markdown.Replace('\u00A0', ' ');

Fair point. I guess for now we can close the issue. Thanks for your inputs!


running java application does not work

Hey, I'm trying to run Nitro Explorer 3 inside this container. The container always exits immediately throwing the error:
Exception in thread "main" java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader.main(JarRsrcLoader.java:58)
Caused by: java.lang.UnsatisfiedLinkError: Could not load SWT library. Reasons:
        no swt-gtk-4335 in java.library.path
        no swt-gtk in java.library.path
        Can't load library: /dev/null/libswt-gtk-4335-64.so
        Can't load library: /dev/null/libswt-gtk-64.so

        at org.eclipse.swt.internal.Library.loadLibrary(Unknown Source)
        at org.eclipse.swt.internal.Library.loadLibrary(Unknown Source)
        at org.eclipse.swt.internal.C.<clinit>(Unknown Source)
        at org.eclipse.swt.internal.Converter.wcsToMbcs(Unknown Source)
        at org.eclipse.swt.internal.Converter.wcsToMbcs(Unknown Source)
        at org.eclipse.swt.widgets.Display.<clinit>(Unknown Source)
        at gui.MainWindow.open(MainWindow.java:65)
        at gui.MainWindow.main(MainWindow.java:55)
        ... 5 more

I have tried alpine, debian and ubuntu, i always get this message.
My basic approach is this:
Inside the Dockerfile

I copy the .jar file to the /opt/nitro/ directory
Install java
Copy startapp.sh to /

Inside the startapp.sh:
/usr/bin/java -jar /opt/nitro/myapp.jar
A lot of hours have gone into this and I don't know what I could possibly do to make this work.
If you could assist me, that would be awesome.
Thanks!

Did you install the package which provides libswt-gtk*.so libraries?

Yeah, my Dockerfile looks like:
FROM jlesage/baseimage-gui:ubuntu-18.04

# Install xterm.
RUN apt-get update && apt-get install -y openjdk-8-jre libswt-gtk*

# Copy the start script.
COPY nitro.jar /app/
COPY startapp.sh /startapp.sh

# Set the name of the application.
ENV APP_NAME="Nitroexplorer"

Maybe you could try to install it on a normal Linux installation to see how the app is started.  They are often started with a couple of java options...

I'm having a similar problem: I'm getting errors related to /dev/null as well. I'm trying to make an image that loads Eclair GUI, and (part of) the traceback is the following:
Loading library prism_es2 from resource failed: java.io.IOException: Can not create cache at /dev/null/.openjfx/cache/[168/1841]
java.io.IOException: Can not create cache at /dev/null/.openjfx/cache/11.0.2
        at com.sun.glass.utils.NativeLibLoader.cacheLibrary(NativeLibLoader.java:233)
        at com.sun.glass.utils.NativeLibLoader.installLibraryFromResource(NativeLibLoader.java:203)
        at com.sun.glass.utils.NativeLibLoader.loadLibraryFromResource(NativeLibLoader.java:185)                                        at com.sun.glass.utils.NativeLibLoader.loadLibraryInternal(NativeLibLoader.java:157)
        at com.sun.glass.utils.NativeLibLoader.loadLibrary(NativeLibLoader.java:52)
        at com.sun.prism.es2.ES2Pipeline.lambda$static$0(ES2Pipeline.java:68)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at com.sun.prism.es2.ES2Pipeline.<clinit>(ES2Pipeline.java:50)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:315)
        at com.sun.prism.GraphicsPipeline.createPipeline(GraphicsPipeline.java:187)
        at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.init(QuantumRenderer.java:91)
        at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:124)
        at java.base/java.lang.Thread.run(Thread.java:834)
Loading library prism_sw from resource failed: java.io.IOException: Can not create cache at /dev/null/.openjfx/cache/11.0.2
java.io.IOException: Can not create cache at /dev/null/.openjfx/cache/11.0.2
        at com.sun.glass.utils.NativeLibLoader.cacheLibrary(NativeLibLoader.java:233)
        at com.sun.glass.utils.NativeLibLoader.installLibraryFromResource(NativeLibLoader.java:203)
        at com.sun.glass.utils.NativeLibLoader.loadLibraryFromResource(NativeLibLoader.java:185)
        at com.sun.glass.utils.NativeLibLoader.loadLibraryInternal(NativeLibLoader.java:157)
        at com.sun.glass.utils.NativeLibLoader.loadLibrary(NativeLibLoader.java:52)
        at com.sun.prism.sw.SWPipeline.lambda$static$0(SWPipeline.java:42)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at com.sun.prism.sw.SWPipeline.<clinit>(SWPipeline.java:41)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:315)
        at com.sun.prism.GraphicsPipeline.createPipeline(GraphicsPipeline.java:187)
        at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.init(QuantumRenderer.java:91)
        at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:124)
        at java.base/java.lang.Thread.run(Thread.java:834)

As we can see, it also uses /dev/null as a directory. I'm currently trying on the ubuntu-18.04 tag with openjdk-11, but also tried debian-9 and manually downloading openjdk-11 from AdoptOpenJDK.
I tried running the JAR on a Docker container with Lubuntu + VNC and started correctly with no errors.
So, It might have something to do with some Java option, maybe is trying to write on the /home directory and by some reason it defaults it to /dev/null? Kinda weird.

@calgara12 The problem seems to be that this image uses a user with no HOME route (more like the home set to /dev/null), which causes these errors. Theorically we can set the home in Java like this (here I show my startapp.sh file):
#!/bin/sh

set -ex

HOME="/tmp"

_JAVA_OPTIONS="-Duser.home=${HOME}"  exec java -Declair.printToConsole -Duser.home=${HOME} -verbose -jar /eclair.jar

In my case another errors show up, but at least is not showing problems related with /dev/null. Maybe it works for you.

similar here: The Application is using eclipse and trys to write to /dev/null/.eclipse...
I tried changing Home to /config but no luck. Any Ideas how I can make him not using /dev/null?

For openjfx cache, I had same issue.  This option fixes it...
-Djavafx.cachedir=/tmp

java -jar \
    -Djavafx.cachedir=/tmp \
    -Duser.home=/tmp \

This should fix your issues

Closing this issue.  Please re-open if needed.


Bcolz issues

Not sure if this is the same issue as #1007, but running a simple command like:
into('pshare.bcolz', 'PShare-Rev2.csv', dshape=ds)
crashes my python.exe kernel.
ds is a slightly modified dshape that came from discover on the same csv.
Same variation with odo causes the same kernel crash:
odo.odo('PShare-Rev2.csv', 'pshare.bcolz', dshape=ds)
This appears to be regardless of the values in ds, as it occurs without that parameter as well.
This is a csv that loads into a pandas dataframe just fine, but I was trying to get it into bcolz for parallel processing.
This:
into('phones.bcolz', df, dshape=ds)
Throws the error:
ValueError: could not broadcast input array from shape (3,1048576) into shape (3)
And this:
odo.odo(df, 'phones.bcolz', dshape=ds)
...again crashes the kernel.

What is your datashape, what does your data look like?

dshape is like so:
ds = dshape("""var * {
CID: int64,
DefaultP: ?string,
AID: ?string,
RNo: ?string,
PNo: ?string
}""")
I can't post any of the actual data, but it's largely identifiers from a DB (int, CID/AID), a phone number (DefaultP, max len=25), and some shorter 4 to 5 digit int numbers that can be null (RNo, PNo). I defaulted most oft he values to string since they can be null.

What I find odd is that your array has shape (3, n) rather than (n,).  I'll assume that you're using a carray then and not a ctable?  If so then is there a reason?

I'm not specifically defining anything like that, I just have a CSV that I am trying to get into a bcolz format. Any shape that it's come up with is being inferred by what I was doing above.
I also managed to get the CSV into a Data() object, where I thought I was getting further, but then when trying:
odo.odo(d, 'ph.bcolz', dshape=ds)
I again get:
ValueError: could not broadcast input array from shape (3,1048576) into shape (3)
That does produce about 2GB worth of data before it results in that error though - which is also interesting, since the CSV itself is 800MB.

Regarding the data blowup I suspect you're running into issues with object dtype.  Suggest reading http://odo.pydata.org/en/latest/datashape.html?highlight=object#datatypes-increase-efficiency
I'm not sure how much we can help without knowing at least a little bit about your data.  The fact tha tyou have a 2d shape implies that something strange is going on.  I'd be curious at what stage in your ingestion pipeline that occured.

Not sure if this is a connected issue, but trying to reduce the amount of data to just 100 rows of my dataset I ran into this, and here's the smallest re-creation I can come up with:
a.csv:
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999
123,Abc,123,99999,9999```

```ds = dshape("""var * {
  CID: int64,
  DefaultP: string,
  AID: int64,
  RNo: ?int32,
  PNo: ?int32
  }""")

a = Data('a.csv', dshape=ds)

a```

And then:

```into('a.bcolz', a, dshape=ds)

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
C:\Anaconda3\lib\site-packages\IPython\core\formatters.py in __call__(self, obj)
    688                 type_pprinters=self.type_printers,
    689                 deferred_pprinters=self.deferred_printers)
--> 690             printer.pretty(obj)
    691             printer.flush()
    692             return stream.getvalue()

C:\Anaconda3\lib\site-packages\IPython\lib\pretty.py in pretty(self, obj)
    407                             if callable(meth):
    408                                 return meth(obj, self, cycle)
--> 409             return _default_pprint(obj, self, cycle)
    410         finally:
    411             self.end_group()

C:\Anaconda3\lib\site-packages\IPython\lib\pretty.py in _default_pprint(obj, p, cycle)
    527     if _safe_getattr(klass, '__repr__', None) not in _baseclass_reprs:
    528         # A user-provided repr. Find newlines and replace them with p.break_()
--> 529         _repr_pprint(obj, p, cycle)
    530         return
    531     p.begin_group(1, '<')

C:\Anaconda3\lib\site-packages\IPython\lib\pretty.py in _repr_pprint(obj, p, cycle)
    709     """A pprint that just redirects to the normal repr function."""
    710     # Find newlines and replace them with p.break_()
--> 711     output = repr(obj)
    712     for idx,output_line in enumerate(output.splitlines()):
    713         if idx:

C:\Anaconda3\lib\site-packages\bcolz\ctable.py in __repr__(self)
   1244         if self.rootdir:
   1245             header += "  rootdir := '%s'\n" % self.rootdir
-> 1246         fullrepr = header + str(self)
   1247         return fullrepr
   1248

C:\Anaconda3\lib\site-packages\bcolz\ctable.py in __str__(self)
   1232
   1233     def __str__(self):
-> 1234         return array2string(self)
   1235
   1236     def __repr__(self):

C:\Anaconda3\lib\site-packages\bcolz\arrayprint.py in array2string(a, max_line_width, precision, suppress_small, separator, prefix, style, formatter)
    466     else:
    467         lst = _array2string(a, max_line_width, precision, suppress_small,
--> 468                             separator, prefix, formatter=formatter)
    469     return lst
    470

C:\Anaconda3\lib\site-packages\bcolz\arrayprint.py in _array2string(a, max_line_width, precision, suppress_small, separator, prefix, formatter)
    338     lst = _formatArray(a, format_function, len(a.shape), max_line_width,
    339                        next_line_prefix, separator,
--> 340                        _summaryEdgeItems, summary_insert)[:-1]
    341     return lst
    342

C:\Anaconda3\lib\site-packages\bcolz\arrayprint.py in _formatArray(a, format_function, rank, max_line_len, next_line_prefix, separator, edge_items, summary_insert)
    512
    513         for i in xrange(trailing_items, 1, -1):
--> 514             word = format_function(a[-i]) + separator
    515             s, line = _extendLine(s, line, word, max_line_len,
    516                                   next_line_prefix)

C:\Anaconda3\lib\site-packages\bcolz\ctable.py in __getitem__(self, key)
   1046             ra = self._arr1.copy()
   1047             # Fill it
-> 1048             ra[0] = tuple([self.cols[name][key] for name in self.names])
   1049             return ra[0]
   1050         # Slices

C:\Anaconda3\lib\site-packages\bcolz\ctable.py in <listcomp>(.0)
   1046             ra = self._arr1.copy()
   1047             # Fill it
-> 1048             ra[0] = tuple([self.cols[name][key] for name in self.names])
   1049             return ra[0]
   1050         # Slices

bcolz\carray_ext.pyx in bcolz.carray_ext.carray.__getitem__ (bcolz\carray_ext.c:23271)()

bcolz\carray_ext.pyx in bcolz.carray_ext.carray.getitem_object (bcolz\carray_ext.c:22840)()

bcolz\carray_ext.pyx in bcolz.carray_ext.chunks.__getitem__ (bcolz\carray_ext.c:9736)()

bcolz\carray_ext.pyx in bcolz.carray_ext.chunks.read_chunk (bcolz\carray_ext.c:9284)()

ValueError: chunkfile a.bcolz\DefaultP\data\__-9.blp not found

If running it when the a.bcolz directory already exists, the kernel then dies.

Object dtypes are very poorly supported in bcolz. You need to provide a fixed length string type to put strings into bcolz. In the next odo release we are going to raise an error when someone tries to use object dtypes with bcolz

see this issue https://github.com/ContinuumIO/odo/issues/181

That appears to have been the issue - with specifying the dshape type on the string as [25, "ascii"] it will now go into the bcolz format. I did also see the data climb up to over 3GB, but it's appears to have applied compression afterwards so it's now down to 240MB!

nice, can we close this issue?

For sure, thanks!


Add testing framework for lint/integration testing

Signed-off-by: Robert Graham<EMAIL_ADDRESS>

I feel like it would make more sense to use https://github.com/github/super-linter to do the shellcheck and rubocop tests at least, but running all of it via GitHub Actions would be ideal. However, I can only find two unverified Vagrant-with-VirtualBox GitHub Actions, so I'll need to do some more investigation on that front first.

FYI, your personal OCA has been rejected and your GitHub account has been added to your Company OCA.


[CSL-1501] LRC test fails sometimes

I tested with modifyMaxSuccess (const 100), it works

@gromakovsky simplified, take a look plz

Merged, etc. Just need CI to pass.

sps gromak <3


Add a BRAT banner

Hi, forgive me if this is unwanted, but I thought it might be funny to include the Charlie XCX brat album cover as a banner for this plugin, given the acronym matches and all the memes around it currently.
Please close this if it's not the vibe <3

I love it. BRAT was an intentionally funny name. I just love that the community has a brat 😃.


Minor updates by bug fixes and feature improvements

fix a bug where the run log file shown in web is not selected based on its iteration NO. ;
add NA type indicating build error;
add C++ source paths for more accurate identification of the source of stack frame;

Thanks @happy-qop!
I rebased #198 on the main branch because I noticed some files in this PR will have merge conflicts.
Given that #198 has no conflict, it's easier to resolve them before merging them into #198 because less code is involved.
Now they have been exposed, would you mind resolving them at your convenience?
I think the simplest steps are:

Create a new branch based on the current #198.
Cherry-pick your original commits in this PR one by one to that branch and resolve each conflict that pops up. git reflog can be useful to identify the commit ID to git cherry-pick.
Submit the new branch on a new PR.
Close this PR and delete this branch.

Let me know if you have a better solution with which I can assist  : )


A plain C example with working build tool.

Could you provide a plain c example, with an updated build.bat/build.sh?
There is a main.cc but not a main.c example.
The following repo has an example, but it fails to build:
https://github.com/markusvaikjarv/c-webview-example/blob/master/main.c
My goal is to make a binding for the Harbour language, which is a 4GL language that generates pure C code.
https://github.com/harbour/core
By the way also tried the instructions from the README.md about a main.c and using the following:
g++ main.c -mwindows -L./dll/x64 -lwebview -lWebView2Loader -o webview-example.exe
Using mingw64 I get an error like: #include <winrt/Windows.Foundation.Collections.h>
Using visual studion CL I get also a lot of errors.

I checked the code and it seems that you need to create a DLL with c++ first.
You can then use this DLL in your plain C program - and you need to link against the previously build C++ DLL.
Here is some e plain C sample "main.c":
#define WEBVIEW_HEADER
#define NULL 0
#include "webview.h"
#ifdef WIN32
int WINAPI WinMain(HINSTANCE hInt, HINSTANCE hPrevInst, LPSTR lpCmdLine,
                   int nCmdShow) {
#else
int main() {
#endif
	webview_t w = webview_create(0, NULL);
	webview_set_title(w, "Webview Example");
	webview_set_size(w, 480, 320, WEBVIEW_HINT_NONE);
	webview_navigate(w, "https://en.m.wikipedia.org/wiki/Main_Page");
	webview_run(w);
	webview_destroy(w);
	return 0;
}

And here is the .bat file in "scripts" which I used to build it with cl (msvc 2019)
@echo off

echo Prepare directories...
set script_dir=%~dp0
set src_dir=%script_dir%..
set build_dir=%script_dir%..\build
mkdir "%build_dir%"

echo Webview directory: %src_dir%
echo Build directory: %build_dir%

echo Looking for vswhere.exe...
set "vswhere=%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"
if not exist "%vswhere%" set "vswhere=%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe"
if not exist "%vswhere%" (
	echo ERROR: Failed to find vswhere.exe
	exit 1
)
echo Found %vswhere%

echo Looking for VC...
for /f "usebackq tokens=*" %%i in (`"%vswhere%" -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do (
  set vc_dir=%%i
)
if not exist "%vc_dir%\Common7\Tools\vsdevcmd.bat" (
	echo ERROR: Failed to find VC tools x86/x64
	exit 1
)
echo Found %vc_dir%

call "%vc_dir%\Common7\Tools\vsdevcmd.bat" -arch=x64 -host_arch=x64

call "%vc_dir%\Common7\Tools\vsdevcmd.bat" -arch=x64 -host_arch=x64
echo Building webview.dll (x64)
mkdir "%src_dir%\dll\x64"
cl /D "WEBVIEW_API=__declspec(dllexport)" ^
	/I "%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\include" ^
	"%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\x64\WebView2Loader.dll.lib" ^
	/std:c++17 /EHsc "/Fo%build_dir%"\ ^
	"%src_dir%\webview.cc" /link /DLL "/OUT:%build_dir%\webview.dll" || exit \b
copy "%build_dir%\webview.dll" "%src_dir%\dll\x64"
copy "%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\x64\WebView2Loader.dll" "%build_dir%"
copy "%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\x64\WebView2Loader.dll" "%src_dir%\dll\x64"

echo Building webview_c99.exe C99 (x64)
cl /I "%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\include" ^
	"%src_dir%\script\microsoft.web.webview<IP_ADDRESS>4.37\build\native\x64\WebView2LoaderStatic.lib" "version.lib" "Shell32.lib"^
	"%src_dir%\build\webview.lib" ^
	/std:c11 /EHsc /O2 /GS "/Fo%build_dir%"\ ^
	"%src_dir%\main.c" /link "/OUT:%build_dir%\webview_c99.exe" || exit \b

Of course - the C99 file always requires webview.dll to be in the same folder as the .exe (or in SYSTEM32 folder)

Thank you for your answer. I was able to make it work using CMAKE. But now I am stuck not being able to use webview_bind.
I will create a new issue asking to enhance the C example to show how to use webview_bind.


Allow functions to reference "trigger" and "response" events rather than defining string resource

What would you like to be added:
There are cases where functions are triggered by events, not by a string-type resource (uri/arn/etc). For these cases
allow functions to reference a "trigger" and "response" events (produce/consume events).
Add detailed description on how event-triggered functions should function within different states such as operation, event, callback states.
Why is this needed:

PR: https://github.com/cncf/wg-serverless-workflow/pull/75

Will do this differently


Data is deleted when opening the page in another tab

You can try to check the problem here:
https://si5dw.csb.app/
Source code:
https://codesandbox.io/s/nanostores-i18n-si5dw
Steps to reproduce:

Set state with buttons
Open page in another tab

Sorry for long delay. Fixed d753470.

@ai Thanks a lot!

I found another regression in demo

Hi
I am using this library to persist my store, but the state is cleared each time I open a new tab.
According to the code, the code does not check for the equality of key values of fired events, and that is the major problem!
My next step will be to rewrite the whole file. If that is helpful, I can post it here

@admir4l Can you send PR? I was not able to localize the issue on local machine to debug node_modules. Your help will be very useful!

@ai
I appreciate your great library. You can find a PR for the issue here #20 .
I'm also restructuring this to use the localstorage methods instead of direct access to the storage object, but it will break compatibility with previous versions!
https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
If you think that is useful, I can create another PR for that once it is ready

use the localstorage methods instead of direct access to the storage object

What is benefits of using methods?

I believe they are, basically, exactly the same.
However, the MDN says:

The localStorage read-only property of the window interface allows you to access a Storage object for the Document's origin

You can read more discussion about this here.

Let’s keep current logic if there is no rational reasons


Add Jumbo79's file

created a branch, created a file and made a commit, and opened a pull request

1st merge attempt

reopen pull request

merge 2nd attempt


[incubator-kie-issues-1618] Fix NOTICE year with range

https://github.com/apache/incubator-kie-issues/issues/1618

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2159 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2159/1/display/redirect
Test results:

PASSED: 1767
FAILED: 1

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanKafkaIT.testProcessInstanceEvents
1 expectation failed.JSON path errors doesn't match.Expected: null  Actual: <[{message=Exception while fetching data (/UserTaskInstanceCommentUpdate) : Index 0 out of bounds for length 0, locations=[{line=1, column=12}], path=[UserTaskInstanceCommentUpdate], extensions={classification=DataFetchingException}}]>


Allow for primary key as the only column.

This simple change addresses issue #111 and is a low-risk change.  I found that the reason the problem was being hit is that in case of just a single primary key in the table with no other columns is that the loader.go was ignoring the PK because of the test for there being more than one column.  The previous fix addressed the case when there were also columns other than the PK but they were ignored so it didn't hit the test of just one column.
To test add the following table and verify that it generates code for the insert and delete functions but not the update/upsert.
CREATE TABLE subnetname (
  subnet_name text PRIMARY KEY
);

This is superseded by PR #117 and can be removed.

Superseded by PR #117.


[Feature] Unpeer should delete remote resource gracefully rather than force

Is your feature request related to a problem? Please describe.
With the current liqoctl unpeer .... command remote cluster resources will be forcefully deleted, which means any running pod's in remote cluster will be deleted without any notice. In our case we run Machine Learning training in remote cluster for weeks/months by mistake if someone deletes FC CRD or execute liqoctl unpeer ML training will be deleted, which is not good.
Describe the solution you'd like
When using liqoctl,
When liqoctl unpeer command is executed, just disable OutgoingPeering, may be cordon the node so future pods will not be scheduled and delete FC CRD(which will delete virtual kubelet deployment) if no resource reflection.
If uses executes liqoctl unpeer --force then delete remote resource forcefully and delete FC CRD.
When FC CRD is deleted,
Block the deletion of the FC CRD till all the reflected resources are completed, but cordon the node so no new jobs will be scheduled.
If FC CRD was deleted with forcefully(not sure if we can differentiate in controller) then forcefully delete reflected resources.
This helps to avoid accident commands executions.
Describe alternatives you've considered
Additional context
I'm open for discussion and implementation once we agree together.

The suggested workflow is as follows:

cordon the nodes related to the cluster to drain
wait for offloaded pods to complete
unpeer the cluster


[docs] Document checkendline and openwisp-utils-qa-check

Add the description of checkendline and openwisp-utils-qa-check to the README, in a similar way to how the other quality assurance scripts are documented.

Unlike the other individual QA checks, checkendline does not seem to be a command-line tool (https://github.com/openwisp/openwisp-utils/blob/master/setup.py#L35) nor is it in the qa.py file
It only appears in the main openwisp-utils-qa-check file as a check, is this what you want me to document?

@TPath123 you're right, the point of the issue is that we need to document the features and usage of openwisp-utils-qa-check, which has been introduced without being documented.
A bit of documentation has just been added in #60, but we need to add a general description of what it does, its purpose, its features.


[bug]: While SCB backup restoration, some channels remain unrecovered

Background
A power outage broke my DB and I reset everything and then tried to recover using SCB, but 7 channels remain unrecovered and transactions to recover them seem to fail.
2023-09-29 14:08:48.713 [INF] LTND: Version: 0.16.4-beta commit=v0.16.4-beta, build=production, logging=default, debuglevel=info
2023-09-29 14:08:48.713 [INF] LTND: Active chain: Bitcoin (network=mainnet)
2023-09-29 14:08:48.714 [INF] RPCS: RPC server listening on <IP_ADDRESS>:10009
2023-09-29 14:08:48.714 [INF] RPCS: gRPC proxy started at <IP_ADDRESS>:8080
2023-09-29 14:08:48.714 [INF] LTND: Opening the main database, this might take a few minutes...
2023-09-29 14:08:48.714 [INF] LTND: Opening bbolt database, sync_freelist=false, auto_compact=true
2023-09-29 14:08:48.715 [INF] CHDB: Not compacting database file at /root/.lnd/data/graph/mainnet/channel.db, it was last compacted at 2023-09-29 13:39:19.093575888 +0000 UTC (29m29s ago), min age is set to 12h0m0s
2023-09-29 14:08:48.987 [INF] CHDB: Not compacting database file at /root/.lnd/data/chain/bitcoin/mainnet/macaroons.db, it was last compacted at 2023-09-29 13:39:19.13907855 +0000 UTC (29m29s ago), min age is set to 12h0m0s
2023-09-29 14:08:48.987 [INF] CHDB: Not compacting database file at /root/.lnd/data/graph/mainnet/sphinxreplay.db, it was last compacted at 2023-09-29 13:39:19.152786374 +0000 UTC (29m29s ago), min age is set to 12h0m0s
2023-09-29 14:08:48.987 [INF] LTND: Creating local graph and channel state DB instances
2023-09-29 14:08:49.676 [INF] CHDB: Checking for schema update: latest_version=29, db_version=29
2023-09-29 14:08:49.676 [INF] CHDB: Checking for optional update: prune_revocation_log=false, db_version=empty
2023-09-29 14:08:49.676 [INF] LTND: Database(s) now open (time_to_open=961.506008ms)!
2023-09-29 14:08:49.676 [INF] LTND: Attempting automatic wallet unlock with password provided in file
2023-09-29 14:08:50.372 [INF] LNWL: Opened wallet
2023-09-29 14:08:50.440 [INF] CHRE: Primary chain is set to: bitcoin
2023-09-29 14:08:50.562 [INF] CHRE: Initializing bitcoind backed fee estimator in CONSERVATIVE mode
2023-09-29 14:08:50.562 [INF] LNWL: Started listening for bitcoind transaction notifications via ZMQ on <IP_ADDRESS>:28333
2023-09-29 14:08:50.562 [INF] LNWL: Started listening for bitcoind block notifications via ZMQ on <IP_ADDRESS>:28332
2023-09-29 14:08:51.263 [INF] LNWL: The wallet has been unlocked without a time limit
2023-09-29 14:08:52.554 [INF] CHRE: LightningWallet opened
2023-09-29 14:08:52.569 [INF] SRVR: Onion services are accessible via Tor! NOTE: Traffic to clearnet services is not routed via Tor.
2023-09-29 14:08:52.569 [INF] TORC: Starting tor controller
2023-09-29 14:08:52.689 [INF] HSWC: Cleaning circuits from disk for closed channels
2023-09-29 14:08:52.696 [INF] HSWC: Finished cleaning: num_closed_channel=36, num_circuits=0, num_keystone=0
2023-09-29 14:08:52.696 [INF] HSWC: Restoring in-memory circuit state from disk
2023-09-29 14:08:52.699 [INF] HSWC: Payment circuits loaded: num_pending=0, num_open=0
2023-09-29 14:08:52.720 [INF] LTND: Channel backup proxy channel notifier starting
2023-09-29 14:08:52.720 [INF] ATPL: Instantiating autopilot with active=false, max_channels=5, allocation=0.600000, min_chan_size=20000, max_chan_size=16777215, private=false, min_confs=1, conf_target=3
2023-09-29 14:08:52.721 [INF] LTND: We're not running within systemd or the service type is not 'notify'
2023-09-29 14:08:52.722 [INF] LTND: Waiting for chain backend to finish sync, start_height=809881
2023-09-29 14:08:55.535 [INF] LNWL: Started rescan from block<PHONE_NUMBER>000000000144b31ee8cd80546f93b8f11fe8f3cbd4b1d9284a2ae0 (height 809879) for 1871 addresses
2023-09-29 14:09:07.698 [INF] LNWL: Catching up block hashes to height 809881, this might take a while
2023-09-29 14:09:07.710 [INF] LNWL: Done catching up block hashes
2023-09-29 14:09:07.710 [INF] LNWL: Finished rescan for 1871 addresses (synced to block<PHONE_NUMBER>00000000044905a1072b4977e53a3ff94414454215590f74b17a6e, height 809881)
2023-09-29 14:09:09.931 [INF] LTND: Chain backend is fully synced (end_height=809881)!
2023-09-29 14:09:09.931 [INF] NANN: HostAnnouncer starting
2023-09-29 14:09:09.931 [WRN] HLCK: check: disk space configured with 0 attempts, skipping it
2023-09-29 14:09:09.931 [WRN] HLCK: check: tls configured with 0 attempts, skipping it
2023-09-29 14:09:09.931 [WRN] HLCK: check: tor connection configured with 0 attempts, skipping it
2023-09-29 14:09:09.931 [INF] LNWL: SigPool starting
2023-09-29 14:09:10.852 [INF] CHNF: ChannelNotifier starting
2023-09-29 14:09:10.852 [INF] PRNF: PeerNotifier starting
2023-09-29 14:09:10.852 [INF] HSWC: HtlcNotifier starting
2023-09-29 14:09:10.852 [INF] SWPR: Sweeper starting
2023-09-29 14:09:10.852 [INF] NTFN: New block epoch subscription
2023-09-29 14:09:10.852 [INF] BTCN: Broadcaster now active
2023-09-29 14:09:10.971 [ERR] BTCN: Broadcast attempt failed: -25: bad-txns-inputs-missingorspent
2023-09-29 14:09:10.975 [INF] LNWL: Inserting unconfirmed transaction 4d047ac7b487319702f3dfe282c168be74d49a2c142626d8930ddf117f9852c8
2023-09-29 14:09:11.003 [INF] LNWL: 4d047ac7b487319702f3dfe282c168be74d49a2c142626d8930ddf117f9852c8: broadcast failed because of: double spend: -25: bad-txns-inputs-missingorspent

How long ago did you trigger the recovery? It may take a few days for all your counterparties to go online and trigger force closures.

It's been about two or three days. Perhaps I need to wait a little longer.

Make sure you have a peer connection to each of those nodes. Perhaps they have changed IP addresses, try looking up their current address on a network explorer (1ml.com, amboss.space) and connect manually.
Check out section 11 here: https://github.com/lightninglabs/chantools
Closing as this is the risk of using an SCB file, you are dependent on your peers. More information can be found here: https://github.com/lightningnetwork/lnd/blob/master/docs/safety.md#zombie-channels


Txt2Al - Curreport.PageNo property

Hi
We are getting the below error regarding PageNo property after converting from Txt2Al

Can you please suggest on this.
Thanks & Regards
Varun Reddy

Please see #477 . I have unblocked the procedure for extension development so that you do not get this error message. In the long run, I think that it would be better to remove CurrReport.PageNo from your code.


"get map" lightbox

wizard for iframe/wordpress shortcode creation by selecting layers and views

2 points


Fix broken links, mainly typo's

Also tweak find-doc-nits while fixing a bug (don't need .in files)

Is everything after our approvals just rebase?

Yes, everything after approvals is just rebasing.

Merged.
1b0d1bf7f177f1a0c979af8e4abbd6ed45d464d7 Fix broken links, mainly typo's


Does this still work?

Hi, thanks for making this available publicly!
I just ran the install script and it copied the file(s) all right, but Xcode 10.3 doesn't seem to pick up the language spec (or at least I see no colors for the .stencil file in my project). Stencil Template also doesn't show up in the file type popup of the File inspector either.
Am I missing how this is supposed to work? Is there some extra setup I need to do? Or are language specs only picked up by older Xcode versions before 10?

Hey @uli-objectbox! Thanks for opening this issue. You're not misunderstanding how this should work or missing any steps, and I apologize that this project wasn't working for you. If you download the latest version of the project, or pull the master branch if you're using git, running ./setup.sh again should install some changes that allow the plugin to work with Xcode 10.3 (and 10.2.1). Please let me know if that doesn't solve the issue for you. It worked for me when I tested it.
Some background: Xcode will only attempt to load an .ideplugin if its Info.plist contains a UUID that matches the DVTPlugInCompatibilityUUID value in the Xcode's Info.plist. This UUID changes with each version of Xcode, so plugin authors need to keep adding UUIDs for each new Xcode that's released. I failed to do that for this project for 10.2.1 and 10.3. This was resolved with #2
In my experience Xcode 11 betas will not support user-installed .xclangspecs, even though it loads the .ideplugin and supports the defined filetype, so this solution won't support those versions.

BTW - Might be worth mentioning this in the Readme or so, then people who run into it can ad the UUID themselves and send you a pull request.
Of course, if Xcode 11 really drops support, that'll be irrelevant XD


Fix segmented control golden tests

Segmented control golden file tests are failing because the content renders differently on different types of machines. Currently, the golden files were generated on a Mac, so this PR adds code so that the tests only compare against the golden files if the tests are running on MacOS.

Landing this to get the tree back to green. The error to be fixed just appeared six times in a row.
Fixes https://github.com/flutter/flutter/issues/18737

This shouldn't have caused a red rope... the problem fixed here was a test that should have fail wasn't failing.
(so you see the "Exception caught by testing framework" message but the test doesn't actually fail).

Yeah, I misread this log of a failing AppVeyor build. The segmented_control_test stacktrace was the only visible error in there.

Of course, whether or not tests fail, we shouldn't have stack traces in our test logs. But the real question is: did I land this before you were done with it?

Hi Mikkel, I thought I wasn't done with it, but it's fine that you merged it if all the tests were passing.


[WIP] Documentation generation

This request configures Doxygen and adds a build command to the CMake file.
To have some reference of how it looks I have also added some different types of comments and very basic documentation to the NovelRunner class.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Xstate devtools injects itself into certain pages and breaking them

Bug or feature request?
Bug
Description:
When visiting pages that use Redux, the Xstate Devtools seems to inject itself and throw an error, breaking the page.
I discovered this while visiting an invite page for Officevibe, where I couldn't accept the invitation because ReduxDevTools would throw a console error (uncaught promise).
I went through all extensions and isolated it to the Xstate Devtool Chrome extension
(Bug) Expected result:
Either not to inject itself, or not to throw an error
(Bug) Actual result:
Uncaught promise
(Bug) Potential fix:
N/A
Required! If you found a bug and can consistently reproduce it, please take a minute to think about what the potential fix might be.
Even if the fix is incorrect, this can help diagnose and find the solution to the issue as quickly as possible.
I also strongly encourage you to create a pull request if you are confident in the potential fix.
(Feature) Potential implementation:
I have no experience with React/Redux/ReduxDevTools, but there's a function call that fails, so probably checking if the function exists and is of type function, before calling it, might get rid of the error?
Link to reproduction or proof-of-concept:
I don't think I would be able to recreate it without learning React/Redux first, sorry ;)

Is it because of this extension? https://chrome.google.com/webstore/detail/xstate-devtools/aamnodipnlopbknpklfoabalmobheehc?hl=en
We do not own nor maintain that extension.

My apologies, I thought it was an "official" extension. I'll take it up with them!


refactor(transformer): remove unnecessary type annotation

Remove unnecessary type annotation introduced in #4925.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5131  👈
#5130
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

I feel this change is uncontentious, so merging without review.


Multiple database connection, last connection is overwriting

`<?php class Database extends Base{
//defautl array of database settings(this will be configured differently later on);
public static $DbSettings = array(
    'api' => array(
        'driver' => 'mysql',
        'host' => DB_HOST,
        'database' => 'api',
        'username' => 'root',
        'password' => 'usbw',
        'charset' => 'utf8'
    ),
    'test_1' => array(
        'driver' => 'mysql',
        'host' => DB_HOST,
        'database' => 'test_1',
        'username' => 'root',
        'password' => 'usbw',
        'charset' => 'utf8'
    ),
    'test_2' => array(
        'driver' => 'mysql',
        'host' => DB_HOST,
        'database' => 'test_2',
        'username' => DB_USER,
        'password' => DB_PASS,
        'charset' => 'utf8'
    )
);

//initialize database
static function Init($data = null) {
    //default config

    //check whom the concerned environment is, if it specified it is the specified environment otherwise its the default environment
    if(isset(self::$Data['URL']['Environment'])){
        $environment_config = self::$DbSettings[strtolower(self::$Data['URL']['Environment'])];
        $connection_environment = new \Pixie\Connection('mysql',$environment_config, 'Environment_DB');
    }

    $api_config = self::$DbSettings['api'];
    $connection_api = new \Pixie\Connection('mysql', $api_config, 'API_DB');

    $c3_config = self::$DbSettings['test_2'];
    $connection_c3 = new \Pixie\Connection('mysql', $c3_config, 'C3_DB');
}

static function Connect(){
}

}
`
When I'm executing the above code when I call
API_DB::Table() etc. in a controller.
It says cant find the table: "Given_table" in test_2_db
If i Swap $api config, $connection_api and $c3_config, $connection_c3 around it works.
But then  if i call for example:
C3_DB::Table() balbablabla it says:
Cant fint the table "Given_table" in API_DB.
So the last databse connection is always the one used what am i doing wrong

https://github.com/usmanhalalit/pixie/pull/154/commits/a8891fef63ac02e10da15a44a27daaefe5aa311c
I made a fix for it.
It should work.

@luccas641 can you get around the eval() I really want to merge this.


update list of serial ports

While working on my microcontroller I plug and unplug it several times and a new serial port is generated in the dropdown list. It needs a button to refresh the list of available serial connections. I have to open a second serial port window in order to connect to my device. It would be much easier if the list can be refreshed by the user. Thanks.

https://github.com/microsoft/vscode-serial-monitor/issues/62

@hongshui3000 @sodanetworks
A manual refresh button has been added in the most recent pre-release version! Please feel free to try it out and let us know if this fixes your issue.

This is now fixed in the official release channel as well with version 0.8.0, so I'll close this issue!


callback is not a function

I get this error while executing -> gmail.get.email_data_async()
extension.js:2138 Uncaught TypeError: callback is not a function at extension.js:2138 at Object. (extension.js:1661) at fire (extension.js:6297) at Object.fireWith [as resolveWith] (extension.js:6427) at done (extension.js:12334) at XMLHttpRequest. (extension.js:12577) (anonymous) @ extension.js:2138 (anonymous) @ extension.js:1661 fire @ extension.js:6297 fireWith @ extension.js:6427 done @ extension.js:12334 (anonymous) @ extension.js:12577 XMLHttpRequest.send (async) send @ extension.js:12629 ajax @ extension.js:12235 Gmail_.api.tools.make_request_async @ extension.js:1659 Gmail_.api.get.email_data_async @ extension.js:2136 (anonymous) @ VM94723:1
Also the text of the email body is decreased to 3 dots. How can i extract the whole email body.
Thanks.

Read the documentation. gmail.get.email_data_async, as the name implies is async. That means it doesn't return a value immediately. It needs a callback which will be provided the result upon completion.


Adding Yourself page

Adding a simple Yourself page and routing to it.

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   44.72%   44.72%
=======================================
  Files          90       90
  Lines        1185     1185
  Branches      200      200
=======================================
  Hits          530      530
  Misses        625      625
  Partials       30       30

Impacted Files
Coverage Δ

...p/core/components/group-nav/group-nav.component.ts
50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4020b...3477aee. Read the comment docs.


new(AsyncEventPlugin): helper to create async events

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin
/area plugin_tests
What this PR does / why we need it:
Reduce the boilerplate to create async events by introducing AsyncEventPlugin::async_event
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Introduce AsyncEventPlugin::async_event helper to generate async events

Welcome @deepskyblue86! It looks like this is your first PR to falcosecurity/plugin-sdk-rs 🎉

LGTM label has been added.  Git tree hash: abcb7c71f5ebb6505eb679698efca0551d656b23


Requesting an icon which does not exist returns IconData Object not null

If I request an Icon which does not exist IconData gets returned anyway with the codePoint = null. This leads to a weird flutter assert which has nothing to do with the IconData and it is hard to track.
Could u please just return null or throw an exception
IconData data = MaterialIcons.getIconData(key);

Assertions have been added to the getIconData method

The 1.0.0 release refactored the API

It would be nice if you could indicate the new behavior here...

Just updated and it seems like there are only static accessors to replace getIconData(String) is gone. Is there a replacement? This is breaking all my late binding code where icons are defined by strings.
The probably fixes the tree-shaking but breaks late-binding

@ride4sun
I also would like to know. There are places on my source where the IconData is dinamically obtained with FontAwesome.getIconData(somevarwithiconname). Is there a way to do something similar to this in this new API?

Just updated and it seems like there are only static accessors to replace getIconData(String) is gone. Is there a replacement? This is breaking all my late binding code where icons are defined by strings.
The probably fixes the tree-shaking but breaks late-binding

Please use the previous version 1.0.0

@2534290808 This does not give you any Icon updates - right?


cancel python model job when dbt exit

Resolves https://github.com/databricks/dbt-databricks/issues/684

Description

Checklist

[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

Hi @benc-db Could you please help review on this PR? the code is not ready, but I want you look it first, see if the method is fine. it related to this issue: https://github.com/databricks/dbt-databricks/issues/684
I think we can utilize Databricks workspace, we create a job_run_ids dir, each python model create one file named run_id in the job_run_ids dir.
When dbt canceled, we read from this job_run_ids dir, and cancel all run_id in it, then we delete the file.

And I have tested it, the job can be canceled, and fail-fast works ok.

Hi @benc-db Could you please help review on this PR? the code is not ready, but I want you look it first, see if the method is fine. it related to this issue: #684
I think we can utilize Databricks workspace, we create a job_run_ids dir, each python model create one file named run_id in the job_run_ids dir.
When dbt canceled, we read from this job_run_ids dir, and cancel all run_id in it, then we delete the file.

If we can locate the target folder, I think I would prefer writing there, so that we don't rely on an API operation to store and retrieve.  Also, I think we need to lock around writing the file to ensure clean operation when kicking off multiple python models concurrently.

@mikealfare we're trying to figure out how to cancel python jobs as part of cleanup, similar to what is done for SQL queries when the user ctrl-Cs.  Is there a better way to communicate run_ids from the python job helper to the connection manager?  We were wondering if maybe there was some global state that would help the python job helper figure out the target directory?

@jtcohen6 as well

Hi @benc-db Could you please help review on this PR? the code is not ready, but I want you look it first, see if the method is fine. it related to this issue: #684
I think we can utilize Databricks workspace, we create a job_run_ids dir, each python model create one file named run_id in the job_run_ids dir.
When dbt canceled, we read from this job_run_ids dir, and cancel all run_id in it, then we delete the file.

If we can locate the target folder, I think I would prefer writing there, so that we don't rely on an API operation to store and retrieve. Also, I think we need to lock around writing the file to ensure clean operation when kicking off multiple python models concurrently.

Hi @benc-db Many thanks for you help. I didn't found a way to get target path in python_submission.py, I'll try to find today.

Hi @benc-db Could you please help review on this PR? the code is not ready, but I want you look it first, see if the method is fine. it related to this issue: #684
I think we can utilize Databricks workspace, we create a job_run_ids dir, each python model create one file named run_id in the job_run_ids dir.
When dbt canceled, we read from this job_run_ids dir, and cancel all run_id in it, then we delete the file.

If we can locate the target folder, I think I would prefer writing there, so that we don't rely on an API operation to store and retrieve. Also, I think we need to lock around writing the file to ensure clean operation when kicking off multiple python models concurrently.

Hi @benc-db Many thanks for you help. I didn't found a way to get target path in python_submission.py, I'll try to find today.

I'm reaching out to dbt Labs folks to see if there is a better way.  In particular, @mikealfare has worked on the dbt-spark adapter, so if we figure it out, it might be good for that library too.

Hi @benc-db, I try to print self.parsed_model in python_submission.py, and I found there is a 'compiled_path' in it, do you think we can utilize this to find TARGET path?
For example, here I set TARGET path as 'target_2'

Hi @benc-db I'm thinking can we use a class static variable to share run_ids?

Hi @benc-db I'm thinking can we use a class static variable to share run_ids?

Good point.  I'm generally so anti-global state that I didn't even think of it :P.  We still need to protect it from concurrency issues, but global state is going to be our best bet until we get support from dbt-core, and better to store in memory than cloud files.

Hi @benc-db I'm thinking can we use a class static variable to share run_ids?

Good point. I'm generally so anti-global state that I didn't even think of it :P. We still need to protect it from concurrency issues, but global state is going to be our best bet until we get support from dbt-core, and better to store in memory than cloud files.

Yes...I don't want to use it too...but seems like if we don't want to do things in dbt-core, it's the only way we can share the state in two class..Let's me write some code in this way!

Hi @benc-db, I revise the code, using a global variable to store all the run id, then cancel them in ConnectManager. please help to review this, thank you very much!

@mikealfare we're trying to figure out how to cancel python jobs as part of cleanup, similar to what is done for SQL queries when the user ctrl-Cs. Is there a better way to communicate run_ids from the python job helper to the connection manager? We were wondering if maybe there was some global state that would help the python job helper figure out the target directory?

It looks like we might be trying to do something similar here for dbt-bigquery. I haven't read through either PR in detail to know if this solves your problem, but I figured I'd link it here in the event it's helpful.

This is annoying, but is actually teaching me a lot about our python model support lol.  It's taking me longer than I expected because I'm trying to get it to work with all credentials and all execution formats (i.e. commands vs notebooks)

This is annoying, but is actually teaching me a lot about our python model support lol. It's taking me longer than I expected because I'm trying to get it to work with all credentials and all execution formats (i.e. commands vs notebooks)

No Rush! thanks for your support. please let me know when you done, and I can modify the code in this PR~

Hi @benc-db I'm reaching out to see if there are any things I can help!

Hi @benc-db I'm reaching out to see if there are any things I can help!

I'll have a new PR up shortly...got stalled because weather knocked out my internet yesterday.  After I put up my PR, if you could download and validate that it works for your scenario, that would be great.

@gaoshihang closing in favor of #693.  Please take a look and verify it works for your use case.

Hi @benc-db , thank you very much! will do that later, and let you know!


Add react-google-analytics to quilt

Resolves https://github.com/Shopify/quilt/issues/284

Did you mean to leave the README empty?

🏓 for another round of reviews. 🙏

Comments addressed! 👍

@kaelig I've made some changes to the docs.

@kaelig I've added a little info https://github.com/Shopify/quilt/pull/285/commits/1ebe4e2e8e7f070cde36677e8b871e21ab64df34

Merging this PR. @TheMallen are you able to run the release script?


can anyone tell me what the meaning of  GMP

the file in /moduel  which license are  MPL 2.0    seems different from others.
what's the purpose of  these files ?

it is a plugin for FireFox. you can ignore it if you just want to use openh264 codec

ok, thank you


Debug dataproc failed presubmits

Do not merge this PR. Only for debugging purposes.

/gcbrun

This is the error after debug logs:
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220014553Z ==================== Test output for //knox:test_knox (shard 6 of 6):
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220021987Z Running tests under Python 3.8.10: /usr/bin/python3
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220045910Z W1205 08:20:47.712818<PHONE_NUMBER>42880 dataproc_test_case.py:57] Printing debug logs for project here
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220085387Z W1205 08:20:49.442378<PHONE_NUMBER>42880 dataproc_test_case.py:58] (1, '', 'ERROR: gcloud failed to load. You are running gcloud with Python 3.11, which is not currently supported by gcloud.\nInstall a compatible version of Python 3.8-3.10 and set the CLOUDSDK_PYTHON environment variable to point to it.\n\nIf you are still experiencing problems, please reinstall the Google Cloud CLI using the instructions here:\n    https://cloud.google.com/sdk/docs/install\n')
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220094003Z W1205 08:20:49.442851<PHONE_NUMBER>42880 dataproc_test_case.py:59]
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220101885Z W1205 08:20:51.024891<PHONE_NUMBER>42880 dataproc_test_case.py:64] Printing debug logs for region here
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220109438Z W1205 08:20:52.446720<PHONE_NUMBER>42880 dataproc_test_case.py:65] (1, '', 'ERROR: gcloud failed to load. You are running gcloud with Python 3.11, which is not currently supported by gcloud.\nInstall a compatible version of Python 3.8-3.10 and set the CLOUDSDK_PYTHON environment variable to point to it.\n\nIf you are still experiencing problems, please reinstall the Google Cloud CLI using the instructions here:\n    https://cloud.google.com/sdk/docs/install\n')
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220116263Z W1205 08:20:52.447159<PHONE_NUMBER>42880 dataproc_test_case.py:66]
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220130123Z [  FAILED  ] setUpClass (__main__.KnoxTestCase)
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220140215Z ======================================================================
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220162364Z ERROR: setUpClass (__main__.KnoxTestCase)
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220170769Z ----------------------------------------------------------------------
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220178225Z Traceback (most recent call last):
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220186764Z   File "/home/ia-tests/.cache/bazel/_bazel_ia-tests/83b1ae36bb04ea5432b9efccee83c25f/execroot/__main__/bazel-out/k8-fastbuild/bin/knox/test_knox.runfiles/__main__/integration_tests/dataproc_test_case.py", line 68, in setUpClass
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220194241Z     assert cls.PROJECT
Step #4 - "dataproc-1.5-ubuntu18-tests": 2023-12-05T08:20:54.220201750Z AssertionError

Specifically,
ERROR: gcloud failed to load. You are running gcloud with Python 3.11, which is not currently supported by gcloud.\nInstall a compatible version of Python 3.8-3.10 and set the CLOUDSDK_PYTHON environment variable to point to it.\n\nIf you are still experiencing problems, please reinstall the Google Cloud CLI using the instructions here:\n    https://cloud.google.com/sdk/docs/install\n'

The latest version of gcloud mentions python support extended upto 3.11.6 in the release notes.
gcloud somehow picks up its own bundled 3.11 and claims to have the wrong version. I was able to check this internally where in one of our frontend checks, we had not modified MAX_SUPPORTED_PY3_VERSION from 3.10 to 3.11. This has been fixed in a change raised on Dec 1st and should be available in prod soon.
No action from our side should be needed to fix this presubmit.

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun


parser_tree.cpp example not compiling in VS 2022, as of PEGTL 2.3.6

It complains about PEGTL\include\tao\pegtl\match.hpp(77,16): error C2065: 'type': undeclared identifier.
I think it has something to do with the unwind change introduced in PEGTL 2.3.6, but no idea. Working in PEGTL 2.3.5

Do you mean version 3.2.6 instead of 2.3.6?
Also, we have CI jobs for VS 2022 which are passing. See https://github.com/taocpp/PEGTL/actions/runs/3950723230. I'm therefore not sure what to do. Can you figure out a fix and create a PR?

Yes, I meant 3.2.6 and 3.2.5 xD (I have already edited the issue and message)
I would really love to fix it myself, but the error trace is pretty obscure. I tried but didn't manage to fix it 😞
If the jobs pass, maybe it's something I have misconfigured locally, but I just downloaded and tested the versions without touching anything, and 3.2.5 worked while 3.2.6 & 3.2.7 don't. Sorry I can not help much more with this 😖

I experienced this on an older version of MSVC, but after upgrading to 19.34.31942.0, I can no longer reproduce. Looks like a fixed compiler bug.

I think I may have found the issue, as I experienced it again. Looks like if you have type defined at global scope in your code where parse_tree can see it, MSVC will see the expression at 3.2.7's parse_tree.hpp at line 436:
internal::make_control< Node, Selector, Control >::template type

And not be happy about type there, even though it should be obviously a name under make_control. I guess it is a compiler bug? type might be a silly name to pick at global scope, but I feel like this should work.


Commander additions and some fixes

The primary change in this PR is the addition of some commands to pyocd commander.

gdbserver (start|stop): Allows you to run the gdbserver from within commander. The gdbserver runs in the background, so you can still use commander to examine the target even with gdb connected.
show option <name>…: Print the value of one or more user options.
set option <name>=<value>…: Change the value of one or more user options.
pyocd symbol added to the namespace used for '$'-prefixed Python expression commands. This lets you access the entire pyOCD package.

Additionally, several fixes are included.

Fixed the default value for 'vector_catch' option in GDBServer.
GDBServer.stop() no longer uninits the board.
The gdbserver subcommand handler for pyocd tool catches KeyboardInterrupt exceptions to stop the gdbserver.
If the target is running, the disasm command doesn't try to read the PC.
Fixed --help-options for options with multiple types.
Fixed issue with LOG_DAP in pyocd.coresight.ap.

/morph test


Nested commands

🚀 The feature, motivation and pitch
Hi!
First off, thanks for this plugin! I use it litterally every day.
In telescope.nvim the commands are nested under :Telescope. This allows for an easier time finding and write a command.
In obsidian.nvim, when I type :O and then hit tab it suggests:

ObsidianBacklinks
ObsidianCheck
etc.

It would make it easier to use the command line if you work in the following way:

:O and hit tab, autocompleting it to :Obsidian .
:Obsidian ba and hit tab, autocompleting to :Obsidian backlinks

As mentioned, this is the way telescope.nvim works by providing a complete function to nvim_create_user_command. Like so code.
This does not have to be a breaking change. We could  introduce a new command just called :Obsidian with the above mentioned properties.
Additional context
Obsidian.nvim today:

Telescope.nvim:

Would be happy to create a PR for this if it sounds interesting. 🚀
PS sorry for light-mode theme, it is sunny outside 😅

Hey @ridulfo I like that idea a lot! Happy to accept a PR

@ridulfo I was bored today so I took a stab at this: #668.


Added: adiirc 64.3.7

Correction: The version should have been 3.7. But i forgot to change that before sending it as a pull request here.


Remove requirements.txt files

In GitLab by @wtbarnes on Jul 7, 2020, 14:52
We no longer need the requirements.txt files as they are not part of the installation procedure. All of the required packages are included in the setup.cfg file.

In GitLab by @wtbarnes on Jul 16, 2020, 13:06
mentioned in commit ef98596690ed032488fc6903090f50317e4df249


Preview dark theme

In traditional theme, you can have something like:
@Composable
fun AppTheme(darkTheme: Boolean = isSystemInDarkTheme(), content: @Composable () -> Unit) {
    val colors = if (darkTheme) darkColors else lightColors
    MaterialTheme(
        colors = colors,
        content = content
    )
}

@Preview
@Composable
fun PreviewDark() {
    AppTheme(true) {
        Button("btn")
    }
}

How does this translate to this library? Would it be possible to have a flag for that?

You can use the uiMode param on @Preview to tell the preview to update the configuration:
@Preview(uiMode = UiModeManager.MODE_NIGHT_YES)
@Composable
fun PreviewDark() {
    MdcTheme {
        Button("btn")
    }
}


Server/browser awareness issue

When I try this
async componentDidMount() {
    if (!SERVER) {
      try {
        await screenfull = import('screenfull');
      } catch (e) {
        console.log('Module did not load!');
      }
    }
  }

Build fails with error "Invalid left-hand side in assignment expression" and the ESLinit highlights the await
If I change it to this:
const screenfull = await import('screenfull');

I've got regeneratorRuntime
The setup is almost fresh, just few react components.
npm -v 4.1.2
node -v v7.6.0

Any ideas ?

thanks @netbull - that's a mistake in the docs. I'll get that fixed. Your const screenfull = await import('screenfull'); is the right way to go.

@leebenson that way I've got the
ReferenceError: regeneratorRuntime is not defined

Ah, I see. Sounds like an issue with the babel polyfill. Will check that today and get it fixed.

This now works as of 2.1.0.
Upgrade with npm i -g reactql.
Sample component to test:
app.js
import React from 'react';

export default class Example extends React.Component {
  constructor() {
    super();
    this.state = {};
  }

  async componentWillMount() {
    this.setState({
      name: await new Promise(resolve => {
        setTimeout(() => resolve('ReactQL'), 1000);
      }),
    });
  }

  render() {
    return (
      <h1>{this.state.name || 'none'}</h1>
    );
  }
}

The browser entry is polyfilled to work everywhere. On the server, if you're using < 7.6, async/await will be transformed into a generator. On >= 7.6, it'll use native async/await.

@leebenson thanks!
for browser is ok, but running
npm run build-run

throws exception ** Unexpected token import** if I try to use this.screenfull = await import('screenfull');

will investigate this further. On the surface, it seems like an issue with import not being treated like a Promise on the server.

await still doesn't seem to be working. Getting

regeneratorRuntime is not defined

Not sure what version of kit I'm using but I installed it just a couple days ago.

@mnpenner - are you specifically trying to get await to work with imports? This issue is showing up in the browser and not on the server, right?

In the browser, but not with import(). Was trying to await self.createImageBitmap specifically, which returns a Promise.

Sounds like an issue with your environment. The project generated by reactql new uses async/await in multiple places, and runs out-the-box with npm start on Node 7.6+.
Which version of ReactQL are you getting with reactql version? Did you try creating a new project with reactql new? Are you running with npm start?

@leebenson I managed to reproduce it a brand new install. However, the issue may be related to worker-loader or when you add webpack plugins via ! syntax.
❯ node --version
v7.10.1
❯ reactql version
4.8.5

Kit  v2.8.5.
Create src/async.js:
self.addEventListener('message', async ev => {
  let image = await self.createImageBitmap('TEST');
});

Drop this in src/components/main/index.js. I put this right above export default ():
import Worker from 'worker-loader!../../async';
const worker = new Worker();

worker.postMessage({hello: 'world'});

Run yarn add worker-loader to add the package.
Fire up the server: yarn start.
Gives error:

db426b9….worker.js:733 Uncaught ReferenceError: regeneratorRuntime is not defined

@mnpenner - according to https://github.com/webpack-contrib/worker-loader/issues/75, it doesn't seem like Webpack 3.x support has landed yet. Not sure if it's related.


0 50 1 branch

#### Pull Request Checklist

[ ] LndServices minimum version has been updated if new lnd apis/fields are
used.

Please stop spamming our repos with unwanted PRs. Those branches are often not merged for a reason.