Mattermost Desktop App v5.0

You can find key dates for Desktop App v5.0 release below, with links to testing servers, release candidate and changelog added retrospectively. Dates are tentative and subject to change.
Sept 20: Release candidate cut
The following information will be updated after release candidate is cut:

Download link to release candidate
Testing server
Changelog

Oct 12th: Release Build Cut
The final release is cut.
Oct 13th: Release Day
Mattermost Desktop App v5.0 is released.
If an urgent and important issue needs to be addressed between major releases, a patch release (e.g. 5.0.1) may be created.

Desktop App v5.0 RC-1 is cut
Download links: https://github.com/mattermost/desktop/releases/tag/v5.0.0-rc1
Changelog
Changelog draft can be found here: Link

Desktop App v5.0 RC-2 is cut
Download links: https://github.com/mattermost/desktop/releases/tag/v5.0.0-rc2
Changelog
Changelog draft can be found here: Link

Changed the server selection to use a dropdown instead of tabs.

is there a way to bring back the previous tab view, which in my opinion was much quicker and better UX for switching between multiple servers (we using this a lot in our company) or this change is pernament an non-configurable?

Changed the server selection to use a dropdown instead of tabs.

is there a way to bring back the previous tab view, which in my opinion was much quicker and better UX for switching between multiple servers (we using this a lot in our company) or this change is pernament an non-configurable?

cc @esethna @devinbinnie

@grzegorzso Unfortunately no, the dropdown view is the only view available in v5.0.

@grzegorzso not that you can still use keyboard shortcuts to switch servers:


Datapoint Address of device will not be updated (since v1.0.0, srv 5.8)

Since version 1.0.0 of the traccar adapter the datapoint address of the device will not be updated.
I use version 1.1.1 of the adpater and traccar server version 5.8

Should be fixed with version 1.1.2 (2023-07-16)
(arteck) another fix for Traccar Server >= v5.8


feat: return ALL_OLD on delete

https://github.com/sensedeep/dynamodb-onetable/discussions/266
if params.return == true (default) then remove will return ALL_OLD parsed attributes

Looks good. Just one little formatting pick.
I'll merge this regardless.
Thank you for this nice patch. It is good for delete to be able to get the removed item.
One question: how are you handling the params {many: true}?

@mobsense good question, let me check how that works now

@mobsense just covered the many: true scenario

Thank you. Looks great!


Be able to search recipes based on filters. Search by different properties

Filters include, ingredients, and/or dietary restrictions.

There should be different kinds of searches. One that filters by the dietary restrictions and ingredients. One that sorts by name of the recipe. One that shows all the favorite recipes. One that shows the wishList recipes. One that shows all the recipes. And a fun one that shows a randomly chosen recipe.

Done when search option allows for prioritizing/removing recipes from returned list of recipes

Filters: Dietary Restrictions; Ingredients.
When the user selects filter from the command line, the UI should prompt the user for Dietary Restrictions. Then it should prompt the user for ingredients.
After this it should then list the recipes that fit these user inputs.


PHOENIX-5072 Cursor Query Loops Eternally with Local Index, Returns F…

…ine Without It
I found out that when we had (local) index then we didn't have the CursorFetchPlan but it was optimized to a ScanPlan on the index.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 51s
the patch passed

+0
hbaserecompile
27m 19s
HBase recompiled.

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
checkstyle
1m  7s
phoenix-core: The patch generated 6 new + 212 unchanged - 3 fixed = 218 total (was 215)

-1 :x:
whitespace
0m  0s
The patch 3 line(s) with tabs.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
120m 59s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

199m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1287

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 1040f3c493cf 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c4d297d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-general-check/output/whitespace-tabs.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/1/testReport/

Max. process+thread count
9697 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The ScanPlan in CursorFetchPlan was not using the index when we called the optimize on the CursorFetchPlan it added a simple ScanPlan (using the index) to the applicablePlans and at the and it got selected as the best one.
https://github.com/apache/phoenix/blob/9dfb423b3928287857f348cae033626ac5339b36/phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java#L245
I've updated the constructor to optimize the ScanPlan at the first place.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
23m 47s
master passed

+0
hbaserecompile
30m 52s
HBase recompiled.

+1 :green_heart:
compile
1m  6s
master passed

+1 :green_heart:
checkstyle
1m  2s
master passed

+1 :green_heart:
javadoc
0m 53s
master passed

+0 :ok:
spotbugs
3m 21s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
17m 10s
the patch passed

+0
hbaserecompile
27m 34s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
1m  2s
phoenix-core: The patch generated 2 new + 21 unchanged - 1 fixed = 23 total (was 22)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 52s
the patch passed

+1 :green_heart:
spotbugs
3m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
120m 27s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

198m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1287

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 99d9f524882d 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 9dfb423

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/2/testReport/

Max. process+thread count
9240 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thank you @ankitsinghal for the review.
I've updated the PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
19m 43s
the patch passed

+0
hbaserecompile
32m 24s
HBase recompiled.

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

-1 :x:
checkstyle
1m 14s
phoenix-core: The patch generated 1 new + 21 unchanged - 1 fixed = 22 total (was 22)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m  0s
the patch passed

+1 :green_heart:
spotbugs
4m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
117m 12s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 42s
The patch does not generate ASF License warnings.

208m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1287

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux b0ce7ffc49e8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 9dfb423

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/3/testReport/

Max. process+thread count
14450 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
19m 43s
the patch passed

+0
hbaserecompile
32m 40s
HBase recompiled.

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

-1 :x:
checkstyle
1m 15s
phoenix-core: The patch generated 1 new + 21 unchanged - 1 fixed = 22 total (was 22)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m  1s
the patch passed

+1 :green_heart:
spotbugs
4m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
139m 42s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

232m 45s

Reason
Tests

Failed junit tests
phoenix.end2end.AuditLoggingIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1287

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 48a473be5f8c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 19b2260

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/4/testReport/

Max. process+thread count
7881 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
20m 54s
master passed

+0
hbaserecompile
27m 25s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
0m 56s
master passed

+1 :green_heart:
javadoc
0m 53s
master passed

+0 :ok:
spotbugs
3m  8s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
13m 35s
the patch passed

+0
hbaserecompile
23m 24s
HBase recompiled.

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

-1 :x:
checkstyle
0m 56s
phoenix-core: The patch generated 3 new + 20 unchanged - 2 fixed = 23 total (was 22)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 50s
the patch passed

+1 :green_heart:
spotbugs
3m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
112m 29s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

180m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1287

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 13afcb19e82d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 19b2260

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/5/testReport/

Max. process+thread count
15556 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1287/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Unzipped, opened F5...error "Operation could destabilze the runtime"

Win 7 x64 SP1, VS 2010 SP1.
Looks like all the project references are resolving right. Weird
System.Security.VerificationException was unhandled by user code
Message=Operation could destabilize the runtime.
Source=Spark
StackTrace:
at Spark.FileSystem.FileSystemViewFolder.ListViews(String path)
at Spark.Parser.ViewLoader.d__9.MoveNext()
at System.Linq.Enumerable.d__811.MoveNext()        at System.Collections.Generic.List1..ctor(IEnumerable1 collection)        at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at Spark.Parser.ViewLoader.FindPartialFiles(String viewPath)
at Spark.Parser.ViewLoader.LoadInternal(String viewPath)
at Spark.Parser.ViewLoader.Load(String viewPath)
at Spark.SparkViewEngine.LoadTemplates(ViewLoader loader, IEnumerable1 templates, ICollection1 chunksLoaded, ICollection`1 templatesLoaded)
at Spark.SparkViewEngine.CreateEntryInternal(SparkViewDescriptor descriptor, Boolean compile)
at Spark.SparkViewEngine.CreateEntry(SparkViewDescriptor descriptor)
at Nancy.ViewEngines.Spark.SparkViewEngine.FindViewInternal(ActionContext actionContext, String viewName, String masterName, Boolean findDefaultMaster, Boolean useCache) in C:\Projecten\Nancy\Nancy\src\Nancy.ViewEngines.Spark\SparkViewEngine.cs:line 170
at Nancy.ViewEngines.Spark.SparkViewEngine.FindView(ActionContext actionContext, String viewName, String masterName) in C:\Projecten\Nancy\Nancy\src\Nancy.ViewEngines.Spark\SparkViewEngine.cs:line 115
at Nancy.ViewEngines.Spark.SparkViewEngine.RenderView[TModel](String path, TModel model) in C:\Projecten\Nancy\Nancy\src\Nancy.ViewEngines.Spark\SparkViewEngine.cs:line 395
at System.Dynamic.UpdateDelegates.UpdateAndExecute3[T0,T1,T2,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2)
at Nancy.ViewEngines.Spark.SparkViewEngine.<>c__DisplayClassf.b__e(Stream stream) in C:\Projecten\Nancy\Nancy\src\Nancy.ViewEngines.Spark\SparkViewEngine.cs:line 421
at Nancy.Hosting.Aspnet.NancyHandler.SetNancyResponseToHttpResponse(HttpContextBase context, Response response) in C:\Projecten\Nancy\Nancy\src\Nancy.Hosting.Aspnet\NancyHandler.cs:line 42
at Nancy.Hosting.Aspnet.NancyHandler.ProcessRequest(HttpContextBase context) in C:\Projecten\Nancy\Nancy\src\Nancy.Hosting.Aspnet\NancyHandler.cs:line 21
at Nancy.Hosting.Aspnet.NancyHttpRequestHandler.ProcessRequest(HttpContext context) in C:\Projecten\Nancy\Nancy\src\Nancy.Hosting.Aspnet\NancyHttpRequestHandler.cs:line 76
at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)
InnerException:

@PrintsCharming, do you still get this exception?
I have been living with it for a long time already.
My pc is Win7 64bits, and I get that exception only when running the app from visual studio (F5).
I remember getting this exception when trying to debug some fubumvc sample project that used spark as well, so, I suspect is not related to NerdBeers but to Spark itself.
Today I spiked another demo project of my own using spark and fubumvc and this issue is hitting me back again :(
The stack trace is:
Lambda expression at: FubuMVC.Core.FubuApplication+<>c__DisplayClasse.b__9(),  line 0
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Security.VerificationException: Operation could destabilize the runtime.
at Spark.FileSystem.FileSystemViewFolder.ListViews(String path)
I have even cloned the spark repository, and compiled the spark project locally, but no luck, I still get that exception.
I couldn't explain why is happening, and I consider myself good at hunting bugs....
I remember I did something that fixed the problem, but couldn't explain why :(
Here it is....
Clone the spark repository, and change this line:
https://github.com/RobertTheGrey/spark/blob/master/src/Spark/FileSystem/FileSystemViewFolder.cs#L48
Into:
return new List();
For some reason (¿the compiler freaks out because output type is List and the method is returning string[0]?) that little harmless change fixes the problem.
It would be awesome if you could give it a try and see if that works.
Once again, I thought I was alone on this one at that nobody else could help me, that's why I never reported the issue publicly, seems I am not alone after all :)
This thread in StackOverlflow seem to throw some lights at the problem:
http://stackoverflow.com/questions/378895/operation-could-destabilize-the-runtime
Kind Regards,
Jaime.

Hey Jaime,
Thank you for your comments and work on this. As you mention this is a problem with Spark, I will close this issue. Good luck on getting it fixed in Spark !
Tom

I just downloaded it again, same machine config as previous and it worked out of the box.  Spark/Nancy must have been updated with a fix since the last time I tried this app.

Hi there,
Thanks for the feedback,
I promise I will give it a try soon using this project and report my findings here.
As I said, it happens on certain projects, I use Spark all the time in several projects, and this issue just pops-up in certain projects (and while running these apps using the debugger [F5]).
What I do when that happens, is to run the app without attaching the debugger [Ctrl+F5], and later attach the debugger, "touch" the .config file (being app.config or web.config) to debug the code that runs on startup (because that's often what this bug does not let me do).
Anyway, thanks for getting back to this after such a long time, very appreciated.
Kind regards,
Jaime.


Shallow rivers generate deep ocean biomes

Description
Shallow rivers generate deep warm ocean biomes inexplicably.
How to reproduce
Make a world with just TerraForged v0.0.13 with the seed -8307868405864224230, teleport to [1094, 100, 840] or [1438, 100, 957]
Additional information

This is the first time I've come across this isssue but I'll additional seeds/locations if I find them.

Weird. River biomes can be overriden by oceans when they come into proximity due to the way river-gen approximates where the river should terminate. Deep ocean variants shouldn't though :/
I've re-written river-gen locally so hopefully this has gone away now but I'll keep an eye out

Should be fixed in 0.0.15


In TypeScript, an error occurred with SheetContent!

TypeScript Error:
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & SheetContentProps & RefAttributes<unknown>'.ts(2559)
(alias) const SheetContent: React.ForwardRefExoticComponent<SheetContentProps & React.RefAttributes<unknown>>
import SheetContent

Still facing this issue till today. Any updates related to this issue? @ItsJohnny30

This might not work for everyone, but restarting VS Code removed that error for me.

Restarting VS Code also worked for me .

For me, this issue doesn't happen in VS Code but is happening when building in the command line using next.js (next build).
The issue happens with almost all components generated by shadecn-ui.

Also encountering this, happened when installing NavigationMenu for me.

@ItsJohnny30 still facing the issue

I've also just experienced this on several shadcn/ui elements that I just started integrating in a new project. I get very similar errors relating to children and errors relating to className as well. No amount of restarting VSCode (Cursor in my case) seems to work. Similarly to above, it's stopping the nextjs build and not just editor-related type checking.
Any help or guidance would be appreciated!

I did some digging on this, never had this issue with TS, but i got it using regular JS. I had to set checkJs: false on jsconfig.js so the errors disappear, but that isn't really a fix.
Seems like React 18+ doesn't automatically export children on props anymore so I guess that's where the issue comes from.
I've been looking for a fix for this for weeks too, to no avail :/

Is there an update on this?

I resolved this not by restarting VS Code, but by deleting my node modules/yarn.lock and running yarn install again.


Installing xfsprogs if that file system is specified.  Cleanup format.

@buzztroll fix for mount bug on xfs filesystem.

:+1:


Properly escape tag content

Changes

Before this change tags were sanitised only for service_check and event calls. Now they are also escaped for simple stats.
Escaping tags now not only removes pipes |, but also ,.

Also had to modify the specs a bit, because the test tags were an array of arrays casted to strings, which was probably a mistake and didn't make any sense for the tests.

It looks great, thanks @adimitrov !
We'll be reviewing your contribution shortly.

Hey @adimitrov, I took the liberty of rebasing your PR there: https://github.com/DataDog/dogstatsd-ruby/pull/34
Tags passed to Datadog::Statsd.new are also escaped in addition to your original PR.
Thanks again for your contribution!


Refactoring of model to encoding code and encode restriction

Encodes restriction field, currently only restriction to cells with a single indicator value.

There's missing a
function createRestrictEncoding(restrict) {
    if (restrict) {
   ... current body
    }
    return ... empty default like in createDensityEncoding
}

That is, the if() above is missing and causes the test failure. Not able to fix today.


Tabs - tabSelectionParams not triggering change

As I understand the library, the tabSelectionParams should drive a transition of a tab via the Component. I believe that I have all the pieces in place. I tried to follow the example implementation as closely as I could but I've ran into trouble. The clicking of my tabs appears to work fine. And displays the sections within the . I am expecting this code to transition into the images panel as soon as I land on the parent page.

      {{tab.name}}

<router-outlet></router-outlet>

  private tabs = [
    {name: "CONTACT", href: "/sub/contact", route: "contact"},
    {name: "DETAILS", href: "/sub/details", route: "details"},
    {name: "IMAGES", href: "/sub/images", route: "images"},
    {name: "VIDEOS", href: "/sub/videos", route: "videos"},
    {name: "ROOMS", href: "/sub/rooms", route: "rooms"},
    {name: "SUBSCRIBE", href: "/sub/subscribe", route: "subscribe"}
  ];
  private routerSubscription: Subscription;
  private tabSelectionParams = null;

  constructor(public activatedRoute: ActivatedRoute, private router: Router) {
    this.tabSelectionParams = ['select_tab', 'images'];
  }

  //also tried
  ngOnInit() {
    this.tabSelectionParams = ['select_tab', 'images'];
  }

  routeTo(route) {
    this.router.navigate([route]);
  }

  updateSelectionParams(router) {
    for (var i = 0; i < this.tabs.length; i++) {
      const tab = this.tabs[i];
      if (location.href.lastIndexOf(tab.href) == location.href.length - tab.href.length) {
        if (!this.tabSelectionParams || this.tabSelectionParams[0] != tab.route) {
          // switch the view to select that tab
          this.tabSelectionParams = ['select_tab', tab.route];
        }
      }
    }
  }

I assume this was solved for you? Did you have to apply anything special that is not documented and you think should be? Thanks.

I have solved this for myself, however the solution is somewhat involved, it includes a recreation of $scope.$broadcast from angular 1 in order to give the child the ability to tell the parent of the state change.


Expose file to SKiDL libraries on import

I have a few libraries with components dynamically created from CSV files stored along side the library scripts. In order to make reading this data more portable I'd like to derive a relative path using the file variable. This diff exposes that variable to SKiDL libraries when imported.

Thanks! I merged your PR into the development branch. It will appear on the master when the next release occurs.
At your convenience, can you provide an example for how this works with your dynamically-created libraries?

Thanks! I merged your PR into the development branch. It will appear on the master when the next release occurs.
At your convenience, can you provide an example for how this works with your dynamically-created libraries?

Thanks! And sure, this is an example of a library which consumes the pinout CSV files provided by Lattice for their ECP5 family of parts: https://gist.github.com/arjenroodselaar/ef1074033d2bc1a44d0f2f38500e0abf. And some sample data: https://gist.github.com/arjenroodselaar/2339942cb8251b459ecc22606967eae3.
As you can see from the sample data, a single file may contain several package variants (last few columns), with the column value indicating whether or not the pin is present in the package. For some of the larger variants there are 3 different package sizes. The source data is also consumed by other tools, hence I want to keep it in separate files. The parse_data(..) function uses the __file__ variable to construct a path and make this portable.
I have similar libraries for resistors, caps etc. which get generated from CSV data. This allows placing actual parts which have part numbers in an ordering system etc. And I am contemplating generating this directly from the API provided by the ordering system (possibly with some caching on disk).

Thanks! And sure, this is an example of a library which consumes the pinout CSV files provided by Lattice for their ECP5 family of parts: https://gist.github.com/arjenroodselaar/ef1074033d2bc1a44d0f2f38500e0abf. And some sample data: https://gist.github.com/arjenroodselaar/2339942cb8251b459ecc22606967eae3.
As you can see from the sample data, a single file may contain several package variants (last few columns), with the column value indicating whether or not the pin is present in the package. For some of the larger variants there are 3 different package sizes. The source data is also consumed by other tools, hence I want to keep it in separate files. The parse_data(..) function uses the __file__ variable to construct a path and make this portable.
I have similar libraries for resistors, caps etc. which get generated from CSV data. This allows placing actual parts which have part numbers in an ordering system etc. And I am contemplating generating this directly from the API provided by the ordering system (possibly with some caching on disk).

Thanks for the example of use! If this is open-source, you should post something about your system on the KiCad-user forum or the SKiDL forum (although not many people will see it there).
I accepted your PR into the development branch and it'll appear in the master on the next release, so I'm going to close this.

Thanks for the example of use! If this is open-source, you should post something about your system on the KiCad-user forum or the SKiDL forum (although not many people will see it there).
I accepted your PR into the development branch and it'll appear in the master on the next release, so I'm going to close this.


500 Error On Attempt to Manage Domain

PDNS: 4.5.3
Powerdns-admin: latest through docker as of writing
Ubuntu: 22.04
Issue description: I receive a 500 error when clicking Manage on domain or clicking on the domain name on the dashboard. Can't seem to further troubleshoot as I receive no error in the docker logs.

Newly added records work fine this is probably a database configuration error, closing.


Meet troubles when using multi-GPUs

Thanks for your nice sharing!@yjxiong
According to your readme.md， i use the "  --gpus 4 5 6 7 " to train tsn on the 4,5,6,7 GPUs, but the logs show that "RuntimeError: all tensors must be on devices[0]".
I also tried with the CUDA_VISIBLE_DEVICES, but the logs show that "TypeError: mean received an invalid combination of arguments - got (dim=int, keepdim=bool, ), but expected one of:  * no arguments,* (int dim)".
Could you please show how to train tsn with  multi-GPUs? Thank you very much!

I tried with the CUDA_VISIBLE_DEVICES, then i update the pytorch version, the bug disappear.


feat(io): add getAllowedDelegates to IO

:tada: This PR is included in version 2.5.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Extension causes high cpu load

Issue Type: Performance
Extension Name: jupiter
Extension Version: 1.2.6
OS Version: Windows_NT x64 10.0.19044
VS Code version: 1.69.1

:warning: Make sure to attach this file from your home-directory:
:warning:file:///c%3A/Users/SALVAT~1.PUL/AppData/Local/Temp/nhatvu148.jupiter-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

nhatvu148.jupiter-unresponsive.cpuprofile.txt


feat(textarea): add textarea component

This PR is to set the HTML5 <textarea> the same style as the inputs. So I just added the textarea class to inputs and a new textarea storybook.
If the users are supposed to use the input class and not this new textarea class, this PR must be rejected.
I just think it will be more intuitive to use this textarea class, and for future changes between inputs/textarea we could refactor and keep them in separate files.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


dhcp does not answer with correct ClientId

When using dhcpcd on archlinux to retrieve an address from the mirage dhcp server. The server does not respond with the correct ClientId.
dhcpc send CliendId with type 0xff,
mirage server answer with CliendId with type 0x00

doesn't work yet. works for me, but for other client id == type 0x0 it's broken.

Fixed by #98

now that #98 is merged, this can be closed.


Fix World Save registering Better Questing

When creating a new world, I'm only given the option to choose the world name. If I try to create a new world, forge says "there are 2 missing entries in this save", "questbook:itemquestbook" and "bq_standard:loot_chest". If I create the world anyways, it starts in creative mode with cheats disabled. Furthermore, the BQ quests are broken as every quest requirement is "betterquesting.placeholder". The FTB quests are also broken because the first quest, "Welcome to Yugospit", does not recognize the glacial precipitator in my inventory when I try to submit it.
Log file: https://www.dropbox.com/s/o5zgj9opseheaot/latest.log?dl=0

Sorry for late responce. Yes that is 100% intentional because we added FTB Quests and depreciated BQ

FTB Quests definitely does not seem to work for me. I even tried it again. Here is what I do:
1: Create new world
2: Grab the crescent hammer
3: Shift+rightclick both glacial precipitators
4: Open FTB Quests using the quest book
5: Click on "Welcome to Yugospit"
6: Click on the submit button which is under "tasks:"
7: Nothing happens.
Also, every new save still starts in creative mode with cheats disabled. The only way I can get into survival mode is if I open lan and set it to survival every time I load the save.

hmmm. I might just put it back to better questing when i have the chance


Debug property page font size regressed

d15prerel 26102.3

This is just: https://github.com/dotnet/roslyn-project-system/issues/646.

You can tell it's a dup - look at the size of your tabs and their font, that's not the default DPI/font size.


Update pokemon.json

I'll reverse the added lines and create an issue for the missing translation

You have quite a few ``[[alt.something]]` references which don't exist in the alt list at the top of the file, you can only use the ones that exist in there. I didn't include many alt forms there since they only exist once so making an extra variable for them didn't really seem needed - it would require the same amount of edits for translators.
Can you replace any non existent [[alt.blah]] references with just the translation for that variant?
The other updates look good though, thanks 👍

Sure, no problem 👍


[Admob Campaigns] Banners showing black borders / not resizing in Flutter App

Hi!
We are having issues with Flutter application using Image Banner from our own campaign.
When we receive the ad and load it into the container (which is implemented as shown in the example app), we are sometimes seeing  the container not being resized to the size of the image ad and remaining space is filled up with black background (see screenshot attached where our test-ad is only the green image)
Could this be related to our campaign which includes multiple ads having different image ads sizes (320x100 and 300x250)?
How is it possible to ensure that the container is getting resized to only the size of the image inside the ad and is it possible to change the black background color to something that fits to our apps ci?

Plugin Version
2.0.1

Steps to Reproduce

create app in AdMob
create ad units in AdMob
create campain
create new ads for campaign and use image ad as type (using different image sizes)
implement banner ads as shown in examples (as adaptive inline ads)

Hi @ts8ta
I hope I can understand this properly. Are you worried about ad rendering from the campaign being affected by rendering ads with plugin?
If so, I don't think rendering ads on the device is related to the campaign input images. This plugin helps to display ads from the ads server while the images in your campaign are provided by yourself.
If not so, can you be more specific on the issue and steps to replicate it in detail (adding a video may be useful)?

Hi,
thanks for your message.
You are right, we are seeing a black border around the images that we are
uploading to our campaigns. So the image is correct, the size of the image
as well, but there is a large border around it and we assume that the
container holding the ad image should adapt to the size of the image. In
our example, the ad image uploaded to the campaign is 320x100 but the ad is
shown in a container of size 320x250 where the rest of the size is black.
If you need more details, I can also share a response that we receive from
google ads.
Thomas
On Tue, 20 Dec 2022 at 10:04, huycozy @.***> wrote:

Hi @ts8ta https://github.com/ts8ta
I hope I can understand this properly. Are you worried about ad rendering
from the campaign being affected by rendering ads with plugin?
If so, I don't think rendering ads on the device is related to the
campaign input images. This plugin helps to display ads from the ads server
while the images in your campaign are provided by yourself.
If not so, can you be more specific on the issue and steps to replicate it
in detail (adding a video may be useful)?
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1359035457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB53EGYTUZCWEX2Y6OUDWOFZARANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

but there is a large border around it and we assume that the
container holding the ad image should adapt to the size of the image. In
our example, the ad image uploaded to the campaign is 320x100 but the ad is
shown in a container of size 320x250 where the rest of the size is black.

It sounds like you're assuming the campaign image source will show up in your app when using this plugin, right?
From my understanding and my explanation above, the image from ads server and the campaign are separate. If there is a source about displaying campaign images with the ads plugin that I may not be aware of, please refer to it here.

Hi again!
We are using our campaign to fill the ads from google. So the images we
upload into our campaign are being sent by google when requesting an ad for
our app.
Thanks,
Thomas
On Tue, 20 Dec 2022 at 11:05, huycozy @.***> wrote:

but there is a large border around it and we assume that the
container holding the ad image should adapt to the size of the image. In
our example, the ad image uploaded to the campaign is 320x100 but the ad is
shown in a container of size 320x250 where the rest of the size is black.
It sounds like you're assuming the campaign image source will show up in
your app when using this plugin, right?
From my understanding and my explanation above, the image from ads server
and the campaign are separate. If there is a source about displaying
campaign images with the ads plugin that I may not be aware of, please
refer to it here.
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1359113124,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB52LXSCU46P5BTCFNU3WOGAFLANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ts8ta I found the source of this now and had the context of this issue.
To be more precise, please provide information indicated below:

Do you set a fixed size for Container? Can you share the snippet code of this?
Please try changing the Container color and re-check whether black space is Container content
Does this issue happen without enabling Ads campaign? (It means that ads is fetched from ad server as normal)

Hi,
exactly this is what we are trying.

Do you set a fixed size for Container? Can you share the snippet code
of this?
--> no, we don't, I am attaching our container widget
Please try changing the Container color and re-check whether black
space is Container content
--> no effect, the space keeps being displayed in black
Does this issue happen without enabling Ads campaign? (It means that
ads is fetched from ad server as normal)
--> yes, this only happens when we are enabling our campaigns.

Thanks for your help!
Thanks,
Thomas
On Tue, 20 Dec 2022 at 12:44, huycozy @.***> wrote:

@ts8ta https://github.com/ts8ta I found the source
https://support.google.com/admob/answer/6177178#when of this now and
had the context of this issue.
To be more precise, please provide information indicated below:

Do you set a fixed size for Container? Can you share the snippet
code of this?
Please try changing the Container color and re-check whether black
space is Container content
Does this issue happen without enabling Ads campaign? (It means
that ads is fetched from ad server as normal)

—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1359240990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB5Y26YISUDNN5VSG753WOGL3RANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ts8ta thanks for your response. I suspect this issue may also happen with Native SDK. Could you please retry with Android ads sample to see if the issue still persists or not?

Hi!
We have been in touch with that Mobile Ads SDK Team and they tested it with
their code saying that all looks good.
Could you please try to reproduce with the following steps:

create app in AdMob
create ad units in AdMob
create campaigncreate new ads for campaign and use image ad as type
(using different image sizes,--> setup one ad with an image of 320x100, and
one with an image 300x250)
use campaign for ad units
implement banner ads as shown in examples (as adaptive inline ads)

Thanks!
Thomas
On Wed, 21 Dec 2022 at 05:32, huycozy @.***> wrote:

@ts8ta https://github.com/ts8ta thanks for your response. I suspect
this issue may also happen with Native SDK. Could you please retry with Android
ads sample
https://github.com/googleads/googleads-mobile-android-examples/ to see
if the issue still persists or not?
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1360844439,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB55ZB3RCLJWFC7CV3MLWOKB4ZANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ts8ta I tried to reproduce the issue but still didn't see the issue, it displayed well as normal when there is no campaign.
Also, I see there is a warning from the Campaigns dashboard:
For your campaign to serve ads, be sure to include payment info in your Google Ads account. [Learn more](https://support.google.com/admob/answer/7047399?hl=en_US)

I'm not sure whether this may affect to this, so I will label the issue for further insights from the team.

ok, did you add ads of type image with different sizes in your campaign? To
us, it looks like the issue is occurring when using a banner of size
320x100. Could you please try with an ad of this size again?
One more thing: why isn't it possible to set the background of the flutter
container widget to a color that integrates with the CI of our application?
If we set this to a color of our choice, the color does not get used. Where
is the black color coming from in our case? Is that filled by AdMob or
within the code of the flutter plugin? Using charles to check what we
receive from AdMob, we received an html showing our banner surrounded by a
black background - but there is no chance to change that behavior in AdMob.
Appreciate your help!
On Wed, 21 Dec 2022 at 10:50, huycozy @.***> wrote:

@ts8ta https://github.com/ts8ta I tried to reproduce the issue but
still didn't see the issue, it displayed well as normal when there is no
campaign.
Also, I see there is a warning from the Campaigns dashboard:
For your campaign to serve ads, be sure to include payment info in your Google Ads account. Learn more
I'm not sure whether this may affect to this, so I will label the issue
for further insights from the team.
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1361092353,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB57JGMKPV3HBADHB4NDWOLHH3ANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

ok, did you add ads of type image with different sizes in your campaign? To
us, it looks like the issue is occurring when using a banner of size
320x100. Could you please try with an ad of this size again?

Currently, I have these image sizes on my campaigns: 320x100, 300x250, 320x50. And the rendered ads seems still getting image from ads server rather than the campaign.

Where is the black color coming from in our case

I recommend you should use Flutter Inspector tool to find where the black color comes from.

Hi,
We will use flutter inspector again to check where the background is coming
from.
Any idea why you are not getting the images from the campaign? All ads
coming from AdServer are looking fine for us.
Thomas
On Wed, 21 Dec 2022 at 11:56, huycozy @.***> wrote:

ok, did you add ads of type image with different sizes in your campaign? To
us, it looks like the issue is occurring when using a banner of size
320x100. Could you please try with an ad of this size again?
Currently, I have these image sizes on my campaigns: 320x100, 300x250,
320x50. And the rendered ads seems still getting image from ads server
rather than the campaign.
Where is the black color coming from in our case
I recommend you should use Flutter Inspector
https://docs.flutter.dev/development/tools/devtools/inspector tool to
find where the black color comes from.
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/googleads-mobile-flutter/issues/730#issuecomment-1361164898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFB54N66HWGK2URFNBBXLWOLO53ANCNFSM6AAAAAATDZITLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'm also seeing this.
I am using the example code.
When I use the test ad unit id in the example it works perfectly except all banners are always the same height.
When I swap the ad unit id for my own the size does get updated but i get black bars... sometimes 🤷
It doesn't seem to be consistently one size thats problematic.
it doesn't refresh when scrolling out the view and back in, maybe implying it has the correct size?
It isn't the surrounding container (giving the container a color doesn't show)
google_mobile_ads: ^2.3.0
Flutter 3.7.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b06b8b2710 (9 days ago) • 2023-01-23 16:55:55 -0800
Engine • revision b24591ed32
Tools • Dart 2.19.0 • DevTools 2.20.1

I have a similar problem when using NativeTemplateStyle.
there is white color behind/around the ads.
is this normal?
flutter 3.7.6
google mobile ads 2.4.0
android - small template

Did someone find a way to remove black background from ad banner?

We’re closing this issue due to inactivity. If you’re still impacted, please create a new issue via the Developer Forum.


prevent script writer from writing recursive scripts

Closes https://github.com/polywrap/evo.ninja/issues/130
Tested using ChatGPT: https://chat.openai.com/share/e1f297bd-e6fb-491a-97f5-7754e2f3ca12

Verified this myself, explicitly asking ChatGPT to utilize recursion to implement the factorial script.
Here's a log showing the bug (without the added clause Kris has here):
https://chat.openai.com/share/0c657c43-1aa3-4035-9f0c-cc7259c873f9
And here is the correct response (with the added clause):
https://chat.openai.com/share/f59d66c4-fe99-4ad3-83cf-cf4ffab427bd

I added a new issue here: https://github.com/polywrap/evo.ninja/issues/208
Please update the labels. I don't know enough context to accurately assign them.


Fix publishing of coverage results to coveralls.io (+ misc test config updates)

Fixes issue #:
None
Description of the changes being introduced by the pull request:
Code coverage results from our Travis builds have not been published to coveralls.io in a while, due to the required coveralls publishing tool not being properly installed.
Besides fixing publishing of coverage results, this PR cleans up/ updates other testing configurations:

Update travis to run on xenial
Add a build matrix to run each tox env in a corresponding travis env as per travis/tox best practices.
https://docs.travis-ci.com/user/languages/python/#using-tox-as-the-build-script
Enable Python 3.5 tests, after all we claim to support Python 3.5
Remove "only build certain branch" restrictions
Use "install" instead of "before_script"  to install dependencies.
Explicitly listing "install" prevents Travis from automatically running pip install -r requirements.txt, which is not necessary because most of those requirements are installed again in each  tox environment.
Move pylint and bandit calls to tox (pylint requires runtime dependencies to be installed).

Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

WIP! don't merge!

Fixed! See most recent Travis builds and corresponding coverage reports on coveralls.
The badge on the main README should be updated once this PR is merged and IIUC we will see GitHub status (as in the table above) in subsequent PRs, because coveralls needs a reference build.

See most recent Travis builds and corresponding coverage reports on coveralls.
The badge on the main README should be updated once this PR is merged and IIUC we will see GitHub status (as in the table at the bottom) in subsequent PRs, because coveralls needs a reference build.

Thanks, @adityasaky!


Fixing "Next steps" CTA

Fixing link at the bottom of the tutorial to point to the Web Apps tutorial rather than the VM tutorial

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/dotnet-howto-migrate-app-service.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Singleton

GameResources has to be initialized in the preInit loop. It has a lot of things that are accesed via get. Since only one possible instance of those things can be, why not use Singleton instead?
I could already do that but since some people has strong arguments against singleton I wanna ask before heading to that.

Implemented in 40ab184.

Due to the intensive use of GameResources as a parameter, not be implemented as Singleton yet.

Yup, delayed for now.

Finally after tree months its implemented (partially).


Make @drammock a repository administrator

In this issue, we made @12rambau a repository administrator:

https://github.com/pydata/pydata-sphinx-theme/issues/1453

This gave him the ability to add/remove other contributors to the repository and to make more drastic changes to the repository's setup.
I think it was uncontroversial because @12rambau has been a consistent contributor and has provided leadership-level support to the project around moving discussions forward, making larger / complex technical changes, and providing ongoing support in our issues.
I think that @drammock's contributions are similarly substantive, and we should give him "admin" access to the repository as well. I can go into specifics of his contributions if people wish, but I feel like our contributions graph is enough evidence on its own (here it is over the last year, also you can totally see when I feel off of a cliff after my second daughter was born lol):

I believe that right now, the main "deciders" here would be me and @12rambau (as the two pre-existing repo admins)[^1], but that any of the contributors to the theme should weigh in if they have opinions.
[^1]: This made me realize we have no formal governance for the org, so see #1531 as well.

I am 💯 in favour of this proposal

That would complete sense as long as @drammock agrees!

That would complete sense as long as @drammock agrees!

Sure, I agree 👍

done


Support python server at backend

Would be great to provide a server in python who can handle the backend logic in the same way node.js does it right now.

ASAP #9 is done, I will take care of this one.

just merged :+1:

Now, the installation process should be documented.

done


Crashes upon open - cannot launch Win7x64-WMF5.1

Running Win7x64 and Powershell 5.1.  Get the following unhandled dotnet exception at open followed by the crash and forced close - resulting in not ever being able to successfully launch the app:
https://1drv.ms/i/s!AhSqjTYUuHPKgb4PsVQOZOUnqQk-OQ
https://1drv.ms/i/s!AhSqjTYUuHPKgb4R5COhADZ8q0B5MA
Would really love to use this app, so hopefully this is something that can be fixed quickly.  It is happening on multiple machines here, both physical and virtual - all Win7x64, all same patch and WMF5.1 level.

@CollinChaffin can you confirm what version of ChocolateyGUI you are using?

Never mind, I see what version you are on...
Can you please try the pre release of the next version, instructions on how to install are on the readme of this repo, and let us know if you still face issues?

Confirmed that the prerelease installed via Github eliminates this exception and crash!  Thanks for the quick reply and solution!


Incremental training

Hello!
You do a great job!
Is it possible to make incremental training?

Currently, RNNSharp doesn't support incremental training, but this is a easy feature to be added. I will implement it very soon.

That's great!
Thank you very much!

This check has already been checked-in. You can try it now.


eigenvaluesHessenberg has unused variables

Reported by beutlich on 12 Aug 2013 11:34 UTC
Variables ihi, ilo, Z and hence also n of function  Modelica.Math.Matrices.Utilities.eigenvaluesHessenberg are not referenced and could be deleted.
Also the import of Modelica.Math.Matrices.Utilities is not necessary at all.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1242

Comment by otter on 12 Aug 2013 14:03 UTC
Fixed in eb854b85275407654bd29e79885215244effc12c and 1d60d0e5c779cef1ea511192d7640baa7790a398


Would like a way to block unapproved registries

What is the problem you're trying to solve
It's common in pretty much all package dependencies system to block system to retrieve packages from unauthorized repositories. In this context, the same idea is that we should have a way to allow only to retrieve images from a specified list of registry like an enterprise approved registry.
Describe the solution you'd like
So in etc/containerd/config.toml I would like to be able to specify that only mirror specified are allowed to be used, and any other request not matching them should be rejected.
Additional context
No response

interested as well 👀


Unlock Countries gem v 3.0

Compatible with 2.x

Thanks so much.  https://rubygems.org/gems/activevalidators/versions/5.0.1


Withdrawal following staking immediately incurs errors (LeedoNftVault.sol)

If a token is staked and withdraw in a same block, the following errors occurs.
The withdraw function cannot read the associated token ID from the previous state.
Error message (ethers.js test)
Error: transaction failed (transactionHash="0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219", transaction={"hash":"0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219","type":2,"accessList":[],"blockHash":null,"blockNumber":null,"transactionIndex":null,"confirmations":0,"from":"0x4278827E51e1453af40ad3F454AE5b556823217c","gasPrice":{"type":"BigNumber","hex":"0x77359401"},"maxPriorityFeePerGas":{"type":"BigNumber","hex":"0x773593f9"},"maxFeePerGas":{"type":"BigNumber","hex":"0x77359401"},"gasLimit":{"type":"BigNumber","hex":"0x0771d5"},"to":"0xBF6CC26C2cA10B59AA68fca6EdAc0773cE306c97","value":{"type":"BigNumber","hex":"0x00"},"nonce":59,"data":"0x983d95ce000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000050000000000000000000000000000000000000000000000000000000000000058000000000000000000000000000000000000000000000000000000000000002c00000000000000000000000000000000000000000000000000000000000000440000000000000000000000000000000000000000000000000000000000000037000000000000000000000000000000000000000000000000000000000000003a","r":"0x5876c8179d488f1a09e2ba87370aed900662416f1f7d785b3bcebc93ba5aa227","s":"0x71360df3452894fe6f7ef37e69998445a5400c26785080427041f63f64f25319","v":1,"creates":null,"chainId":5}, receipt={"to":"0xBF6CC26C2cA10B59AA68fca6EdAc0773cE306c97","from":"0x4278827E51e1453af40ad3F454AE5b556823217c","contractAddress":null,"transactionIndex":0,"gasUsed":{"type":"BigNumber","hex":"0x077130"},"logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","blockHash":"0xdafc06d09f43e3c4e7603a7cf6fc8245aec84dffb430d3f41f855dc95af62eb8","transactionHash":"0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219","logs":[],"blockNumber":5779784,"confirmations":1,"cumulativeGasUsed":{"type":"BigNumber","hex":"0x077130"},"effectiveGasPrice":{"type":"BigNumber","hex":"0x77359400"},"status":0,"type":2,"byzantium":true}, code=CALL_EXCEPTION, version=providers/5.5.0)
at Logger.makeError (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/logger/src.ts/index.ts:225:28)
at Logger.throwError (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/logger/src.ts/index.ts:237:20)
at EthersProviderWrapper. (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/providers/src.ts/base-provider.ts:1314:24)
at step (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/providers/lib/base-provider.js:48:23)
at Object.next (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/providers/lib/base-provider.js:29:53)
at fulfilled (/home/kbae/src/GoSquidGame.github.io/node_modules/@ethersproject/providers/lib/base-provider.js:20:58) {
reason: 'transaction failed',
code: 'CALL_EXCEPTION',
transactionHash: '0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219',
transaction: {
hash: '0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219',
type: 2,
accessList: [],
blockHash: null,
blockNumber: null,
transactionIndex: null,
confirmations: 0,
from: '0x4278827E51e1453af40ad3F454AE5b556823217c',
gasPrice: BigNumber { _hex: '0x77359401', _isBigNumber: true },
maxPriorityFeePerGas: BigNumber { _hex: '0x773593f9', _isBigNumber: true },
maxFeePerGas: BigNumber { _hex: '0x77359401', _isBigNumber: true },
gasLimit: BigNumber { _hex: '0x0771d5', _isBigNumber: true },
to: '0xBF6CC26C2cA10B59AA68fca6EdAc0773cE306c97',
value: BigNumber { _hex: '0x00', _isBigNumber: true },
nonce: 59,
data: '0x983d95ce000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000050000000000000000000000000000000000000000000000000000000000000058000000000000000000000000000000000000000000000000000000000000002c00000000000000000000000000000000000000000000000000000000000000440000000000000000000000000000000000000000000000000000000000000037000000000000000000000000000000000000000000000000000000000000003a',
r: '0x5876c8179d488f1a09e2ba87370aed900662416f1f7d785b3bcebc93ba5aa227',
s: '0x71360df3452894fe6f7ef37e69998445a5400c26785080427041f63f64f25319',
v: 1,
creates: null,
chainId: 5,
wait: [Function (anonymous)]
},
receipt: {
to: '0xBF6CC26C2cA10B59AA68fca6EdAc0773cE306c97',
from: '0x4278827E51e1453af40ad3F454AE5b556823217c',
contractAddress: null,
transactionIndex: 0,
gasUsed: BigNumber { _hex: '0x077130', _isBigNumber: true },
logsBloom: '0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
blockHash: '0xdafc06d09f43e3c4e7603a7cf6fc8245aec84dffb430d3f41f855dc95af62eb8',
transactionHash: '0x305114f7868cb86361f67463b9397a2f63500657359b88589689214d4474d219',
logs: [],
blockNumber: 5779784,
confirmations: 1,
cumulativeGasUsed: BigNumber { _hex: '0x077130', _isBigNumber: true },
effectiveGasPrice: BigNumber { _hex: '0x77359400', _isBigNumber: true },
status: 0,
type: 2,
byzantium: true
}
}

This is not a contract problem. After the stake tx is succeed, the following withdraw tx can read the correct state even on the same block height. It is just a wallet issue which try to get gas estimate before sending the tx. The previous tx is not processed yet, so the wallet can not estimate the correct gas. To enforce the tx, you just ignore the wallet warning or error, and send the tx to the same block.


Update usage of networkx to work with their 2.0 release

I'm not sure how hard it is to support both versions of networkx. Maybe we can require 2.0 for the 1.0 release of ophyd.
http://networkx.readthedocs.io/en/latest/release/migration_guide_from_1.x_to_2.0.html

The changes are not that bad. I only see three lines of code that would be affected in areadetector/base.py: here, here and here.
As far as I can tell, these look okay since the main changes are a switch from lists to views for nodes (so updating a graph after creating the view still contains the updated graph). I don't see any need to change the code.
If that's right, then I think we just need to:

update lightsource recipes
update ophyd requirements
update .travis.yml

Does that sound about right?

If we aren't pinning does that mean we are supporting networkx2 already?

or put another way, what version of networkx do we install on travis currently?

From your most recent commit on master you are running against networkx 2.1 https://travis-ci.org/NSLS-II/ophyd/jobs/374059268#L2004

closed by #533


[SPARK-32191][PYTHON][DOCS] Port migration guide for PySpark docs

What changes were proposed in this pull request?

This proposes to port old PySpark migration guide to new PySpark docs.
Why are the changes needed?

Better documentation.
Does this PR introduce any user-facing change?

No. Documentation only.
How was this patch tested?

Generated document locally.

Test build #127209 has started for PR 29385 at commit 84e8e06.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31830/
Test PASSed.

Test build #127209 has finished for PR 29385 at commit 84e8e06.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127209/
Test PASSed.

cc @HyukjinKwon

Nice, thank you @viirya! I will take a look next Monday!

Test build #127227 has started for PR 29385 at commit e1f95c8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31847/
Test PASSed.

Test build #127228 has started for PR 29385 at commit 48451f5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31848/
Test PASSed.

Test build #127227 has finished for PR 29385 at commit e1f95c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127227/
Test PASSed.

Test build #127228 has finished for PR 29385 at commit 48451f5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127228/
Test PASSed.

Test build #127261 has started for PR 29385 at commit 1fd154b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31881/
Test PASSed.

Test build #127261 has finished for PR 29385 at commit 1fd154b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127261/
Test PASSed.

Test build #127265 has started for PR 29385 at commit 33c8360.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31885/
Test PASSed.

Test build #127265 has finished for PR 29385 at commit 33c8360.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127265/
Test PASSed.

Merged to master. Thanks @viirya for working on this.


Add Cumulus (new formula)

The build failure is related to this:
https://github.com/Homebrew/homebrew/pull/36030

@BrewTestBot test this please

Looks like you'll need to vendor setuptools here:
==> python -c import setuptools... --no-user-cfg install --prefix=/usr/local/Cellar/cumulus/HEAD --single-version-externally-managed --record=installed.txt

The required version of setuptools (>=2.0.1) is not
available, and can't be installed while this script is
running. Please install a more recent version first, using
'easy_install -U setuptools'.

(Currently using setuptools 1.1.6 (/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python))

Some audit issues as well:
==> audit problems
homebrew/head-only/cumulus:
 * HEAD resource "pyyaml": SHA1 checksums are deprecated, please use SHA256
 * HEAD resource "argparse": SHA1 checksums are deprecated, please use SHA256
 * HEAD resource "boto": SHA1 checksums are deprecated, please use SHA256
 * HEAD resource "simplejson": SHA1 checksums are deprecated, please use SHA256
 * HEAD resource "pystache": SHA1 checksums are deprecated, please use SHA256
 * Formula should have a desc (Description).

Closing as dead. Please open a new updated PR if you'd like to.


Move all static text into the language file

Moved all static text into files:

[x] cachet.php (for application front-end text)
[x] dashboard.php (for all dashboard texts)
[x] forms.php (for all the forms fields)
[x] errors.php (for the errors pages, 404 only at this time)
[x] setup.php (for setup-related text)

I couldn't do this for the other languages because I don't speak them. I could have done it for the french but the translation is still at the validation stage on CrowdIn, but let me know if you'd be interested.
PS: Hope I understood correctly the issue #230, otherwise let me know what I can do to help :)

Really good work @foxted - can you fix up the StyleCI issues and then I'll take a look through everything.

Do you know where I can see the details regarding the style issues?

Download this patch and apply it to your branch, commit and push :)

Some of this alignment is very odd too.

And, actually, all the non-english files need syncing up.

@GrahamCampbell do you mean on CrowdIn?

No, I mean in this actual repo.

How do you mean syncing up? Is it not right?

I was meaning the layout of the english files have changed, so the identical changes need to be made to the other languages.

They were already out of sync. Like I said, I don't speak the other languages, but I can sync the files and leave them blank waiting for translation (not sure if it will be useful though)

Meh, just leave it. I'll sync them up later.

Ok.

Needs rebasing.

@foxted hold up rebasing until #196 is merged.

No problem, I'll wait ;)

NB, it's been merged now. :)

Any advice about using StyleCI? Because I can't find anything regarding the issues, so I can't fix them :/ (I am a newbie at contributing on GitHub)

Just append /diff to the url. It'll show you the diff.

https://styleci.grahamjcampbell.co.uk/commits/3c961a8203cbd84d78b3f5296a91480ba2e72340/diff

Any advice about using StyleCI?

We follow PSR-2, and we also enforce a few rules from symfony's coding standards, and we force short array syntax and aligned arrays. The source code for all of this is available at https://github.com/StyleCI.

Thank you :)

Hmm. There's something gone wrong with your rebasing here. Perhapse you didn't force push. I'll try an get this sorted...

Where your changes to the css and migrations intentional?

I didn't touch any CSS or migration file, so I guess something went wrong with the rebasing (first time :/)

Ok, moved to here: https://github.com/cachethq/Cachet/pull/277.

Thanks so much for doing this. :) Is there any chance you could give that PR a quick check that everything is working, and that we haven't lost any recently added stuff.


Return value for [namespace(ns)] changed to [node].

Proposal to close the issue #356.

:+1:

Squash the commits and this should be good to merge as long as @defunctzombie approves.

@bhamon just squash the commits and we can merge this

Sorry for the delay, now it's done.


Notification Sound when you get a message

WHY?
I was alone in a room and had the doghouse link open in the background with my mic muted, people came into my room and wrote in the chat but I was not aware, it would be great if you get a voice sound every time some user sends a message (also have the ability to turn off this feature )

We need that D: <3

I am already adding it lol

It should notify especially when someone mentions you, like a fuzzy search of all the usernames in the current chat window.

PR on the way

#308


Image dont work

"The virtual camera(video) is working properly, but when I try to take a photo, it simply takes a regular picture using my default camera instead of using the image I placed under the /[INTERNAL_STORAGE]/DCIM/Camera1/ folder. I followed the guide's instructions and renamed the file to 1000.bpm, but it still isn't working."

Have you found a solution?

You have renamed the file in wrong way you should name it 1000.bmp

Hey how can I contact you? Pivate message I cant seem to contact you on this site?

contact me on telegram

i fix it finish  , video and image working good

i fix it finish , video and image working good

hey can you write pls to me @bbookkil my teleram


Fix Pandas' FutureDeprecation warning

This PR just casts the indexer to a list from set since Pandas throws:
osmnx/simplification.py:503: FutureWarning: Passing a set as an indexer is deprecated and will raise in a future version. Use a list instead.
  gdf.loc[wcc, "cluster"] = f"{cluster_label}-{suffix}"

Thanks.


spoonacular image URLs changed

Problem
When I loaded a recipe from spoonacular, I noticed the image URLs for the recipe itself as well as the ingredients and equipment were different from what was expected. This will cause inconsistencies in MongoDB and prevent the UI from loading the images properly.
Here's a comparison of a recipe already stored in MongoDB and a new random recipe found:

Property
Current
New

ID
663849
655046

image
https://spoonacular.com/recipeImages/663849-312x231.jpg
https://img.spoonacular.com/recipes/655046-312x231.jpg

ingredients.image
orange-juice.jpg
https://spoonacular.com/cdn/ingredients_100x100/white-powder.jpg

equipment.image
glass-baking-tray.jpg
https://spoonacular.com/cdn/equipment_100x100/food-processor.png

Several issues can arise from this change:

Images now have a domain of img.spoonacular.com instead of spoonacular.com. This might not be an issue on mobile, but on the web, this may violate the CSP since it checks for images and connections to https://spoonacular.com.
The spoonacular docs originally stated that we needed to append https://spoonacular.com/cdn/[ingredients|equipment]_100x100/ to the image names for each ingredient and equipment since they originally didn't return the full URL. Confusingly, the docs now state that these images can be gotten from the img.spoonacular.com domain, like from point 1. I tested both and they returned the same image. So, I'm not sure if spoonacular will continue supporting both as aliases or deprecate one of those URLs.

This must be a recent change since I didn't notice this issue yesterday while retrieving the mock recipes for ez-recipes-web.
Solution
To prevent any further issues, I want to halt any future server requests and perform the following changes to ez-recipes-server:

To address point 1, we need to alter the CSP on Render to accept img.spoonacular.com. This can be done separately from the repo. If the images are still showing for any new recipes, we don't need to make any edits to this property on the BFF.
To address point 2, if the URLs contain the full spoonacular URL, we can strip everything up to the last slash. This way the recipes are stored properly in MongoDB and no changes are required on the client side. If spoonacular later decides to invalidate the cdn URL, we'll have to leave this property alone on the BFF and make edits on all the clients.
Once both issues are fixed, we need to remove all the offending recipes on MongoDB. This can be done via a simple query on MongoDB. Assuming this is a recent change, there shouldn't be too many documents affected.

It sucks to experience these issues as soon as I updated the Android app, but I can simply release a patch. 🙃
Test Plan
Once the fix is in place, we can test it by fetching a few random recipes and seeing if they're rendered correctly on the UI and in MongoDB.

I ran the following query and deleted 6 offending documents:
{$or: [
  {"instructions.steps.ingredients.image": {$regex: "spoonacular"}},
  {"instructions.steps.equipment.image": {$regex: "spoonacular"}}
]}

Just received an email from spoonacular about this exact change and they documented this update here: https://spoonacular.com/food-api/updates


Add configurable cleanup step to packages recipe

The fluttre/packages repo uses a dynamic recipe, which loads and runs steps from a yaml file in the repo. As soon as the first step fails, the rest of the steps aren't run. That's usually what we want, but https://github.com/flutter/packages/pull/3458 is an example of a case where we want to run regardless. When we migrate Linux tasks from Cirrus to LUCI we'll have more (see use of always: in the repo's current ci.yml).
We should have some way of doing this that's equally dynamic and in-repo. Maybe via an annotation in the yaml file, or maybe a second .ci.yaml property with a second yaml file of "always"-style tasks.
@keyonghan Is this something you could help set up? I don't know enough about recipes to know how to configure this.

That's usually what we want, but https://github.com/flutter/packages/pull/3458 is an example of a case where we want to run regardless.

For this case, do we want to mark the whole task as failure or success? Do we want to have this fail but continue run logic on only specific test step, or for all always?

There are two use cases we have for always in Cirrus currently:

Things that should run at the end even if earlier steps failed (like the PR linked above).
Tests we just always want to run (e.g., repo_tests is a bunch of very fast, unrelated tests, and we want to get all failures from all of them at once rather than always only seeing the first thing, fixing it, getting a new failure, fixing it, etc.)

Currently we do both with always since that's the only mechanism we have, but if it's easy for them to be different in LUCI that could be nice.

do we want to mark the whole task as failure or success

I would want any failure, even if it's just cleanup, to mark the whole task as failing. Otherwise we'll never noticed if important cleanup is broken.

First case is clear to me.
As for the second, take the repo_checks task for example, I see always is applied to all scripts. Does that mean any script failure will not block any one else, and the task fails when any one of them fails?

Does that mean any script failure will not block any one else, and the task fails when any one of them fails?

Yes, exactly.

I guess this should be doable.
From the config yaml file side, we can add one more entry: always: true/false for each test step.
From recipes side, when iterating each test step

if we hit an error

check remaining steps which have always: true, and keep finish running them
return failure for the whole task

if we didn't hit any error, we just treat all test steps the same as regular steps

This is now complete with https://flutter-review.googlesource.com/c/recipes/+/46041.


Engagement report charts empty

Yeah, if you deselect "Table of contents" then chart shows.
There is something the UI doesn't like when we have both "Table of Contents" + "Executive Summary" together.


add test for > 100 grpc streams

to validate/avoid regressions on #4631
will add a feature to fortio https://github.com/istio/fortio/issues/223

Made the changes to fortio (https://github.com/istio/fortio/pull/225) but I'm having issues reproducing the problem, see https://github.com/envoyproxy/envoy/issues/2941#issuecomment-378131889


fix(client): Span batch validity guarantees

Overview
Currently, we do not address an edge case in span batch validity within the client program. If the disputed block is the first within the span batch, the span batch's validity is not currently enforced.
 If any L2 block within the span batch is invalid, the entire span batch is rolled back.
In the case where the disputed block is not the first block within the span batch, we only need to execute the disputed block (as we do currently), as the trusted L2 prestate commitment guarantees the validity of the span batch containing both the prestate and disputed block (by virtue of claiming that it is indeed within the safe head, and therefore, that the entire batch was accepted).
However, if the disputed block is the first block within a span batch, the trusted L2 prestate commitment does not make any assertions about the validity of the batch containing the disputed block. To fully enforce consensus rules, when the disputed block is the first block within a span batch, the entire span batch must be executed and validated within kona-client.
In future protocol upgrades, this issue should be addressed, however we currently must conform to active consensus rules.

Holocene fixes this.


Programme/Event Series/Exhibition relationships [migrated from old Collection repo]

@debdoop commented on Tue Nov 17 2015
Update: the description here does not communicate purely a vision/rationale.  There are some answers in the comments.  David has recommended that Russell and a BE dev meet to discuss and write AC together.  There might be things here that need separate ticket.
Description/vision/rationale
Quite often our events/artefacts may relate to more than one exhibition/event series/etc. And it would be useful to be able to make this clear, instead of trying to pick the most “important” one. We put something together last year to feed into designing the site, showing the complicated and layered relationships between various elements of our programme which can be referred to.
Also, can an "Event series" be related to an "Exhibition"? If not, we can use an in-line link. But in that case, can an "Event" be related to both an "Exhibition" and an "Event series"?
An “Event Series” (e.g. Why Music?) doesn’t show up on the Events page. It does appear in the calendar, but not the Events page and presumably it won’t get pulled through to the What’s On page either?
When we add an "Event Series”, we have to add it as an exhibition and then tag it as an event series. If we list the dates of the event series (which we often don’t need to as they’re ongoing), they then appear in the general Exhibitions section. It would be amazing if they could instead appear in the general Events section instead.
We have a weekend event called Why Music? which features many individual events, so it would be great to put the dates in (at the moment it’s in the copy to prevent it being listed under exhibitions).
The Hubbub Friday Spectacular event is listed as part of the Friday Spectacular event series. But it’s also part of the Hubbub event series (which I’ve added it to manually). We can choose only one to assign it to, despite both being appropriate.

For an event series to not be categorised in the back end as an exhibition (eg. https://wellcomecollection.org/exhibitions/perspective-tours would become https://wellcomecollection.org/perspective-tours
Q&A
NA
Acceptance criteria
AC is TBC it does not capture everything discussed in the description above - suggest its moved to the AC:

[ ] An individual event can be associated with any series and multiple series
[ ] An event series can be associated to an exhibition - and vice versa
[ ] The multiple relationships are shown adjacent to 'Part of' on i) Listings, ii) event pages, as per the mock ups below

Related/dependencies
NA
Sketches/mockups/screenshots

@debdoop commented on Thu Apr 28 2016
will effect the listing and the related content and on the page it's self
@drmwellcome will think about "part of..." section

@davidmillerwellcome commented on Tue May 10 2016
Some questions...I think most are for @RussellDornan:
1 Is this the doc referred to in the first paragraph Events, Exhibitions & Tours Data Modelling?
2 Not sure I understand the following...these look like question for back end dev, but we need to understand all the impacts on the site, and its not entirely clear what you're after in the second question:

i Also, can an "Event series" be related to an "Exhibition"? If not, we can use an in-line link. But in that case, can an "Event" be related to both an "Exhibition" and an "Event series"?
ii An “Event Series” (e.g. Why Music?) doesn’t show up on the Events page. It does appear in the calendar, but not the Events page and presumably it won’t get pulled through to the What’s On page either?

3 I'm wondering if this should be pulled out as a separate ticket?  It seems like its not directly related, and might have separate FE/design work?:

We have a weekend event called Why Music? which features many individual events, so it would be great to put the dates in (at the moment it’s in the copy to prevent it being listed under exhibitions).

4 As an example for me to think about, is it correct to say you'd like AD Tour of THIS IS A VOICE to be part of
i THIS IS A VOICE AND
ii Access Tours and Discussions

@RussellDornan commented on Thu May 05 2016
@drmwellcome This is deffo best discussed in person...

@davidmillerwellcome commented on Thu May 05 2016
@RussellDornan Can you answer the last point?  I can then do something thinking around that.
I don't think we'll need 30 mins for accessibility tomorrow so we can discuss then.  I'll see if Dipak or Mike can come for the first half to discuss this ticket

@RussellDornan commented on Thu May 05 2016
@drmwellcome. Hold on to your brain, because I'm about to take it for a ride 😮
Point 1: Yes, the document you mention is the one, although I can see now that it's more complex than that lets on in terms of relationships. There are more connections.
Point 2 i: See Point 4.
Point 2 ii: On the Events page, it only lists single events so Event Series don't get pulled through on the Events page or the What's On page, which means people looking in those places won't see the main, overall event; only the single events that make up the series. Maybe there could be a way to choose whether an Event Series is to be listed on the Events page AND/OR the associated events? Separate tickie?
Point 3: An Event Series is (from a backend perspective) in the same category as an Exhibition. If we give an Event Series a date range at the moment, it then lists it under exhibitions. But we'd rather a) give it a date range and b) list it under Events (see Point 2 ii). Separate tickie here too?
Point 4: yes, that's correct.
Anything else I can tell you to yo' face! 😸

@debdoop commented on Fri May 06 2016
@drmwellcome  will sketch the primary relationships and the other relationships approach, where it will appear in different places on the site.

@davidmillerwellcome commented on Fri May 06 2016
Also agreed to have a meeting with me, @debdoop & @RussellDornan + assigned BE to discuss way forward.  Assigning to Debbie because I feel like the meeting is more likely to hold this up than my work!

@davidmillerwellcome commented on Wed May 11 2016
Mockups shared with group on Slack for feedback.  Assigning to @josh to review.

@davidmillerwellcome commented on Wed May 11 2016
The description here does not communicate purely a vision/rationale.  There are some answers in the comments.  Recommend that Russell and a BE dev meet to discuss and write AC together.  There might be things in the description that require separate tickets.

@debdoop commented on Thu May 12 2016
Hey @RussellDornan and @drmwellcome I've added
#160 an event series can't have a date range without becoming an exhibition listing
and
#159 An event series doesn't show on the listings page
feel free to update and Russell to put in the backlog

@RussellDornan commented on Mon May 16 2016
@dannybirchall Hi Danny, can you give this a look so we can haz a chitty chat about it? 😎

@RussellDornan commented on Mon May 16 2016
Thanks, @Joshua-David
I prefer the bold. I think I also prefer it without the colon. Thanks! 👍

@Joshua-David commented on Mon May 16 2016
@Thomas-Wellcome signed-off design for related tags below, assigning to you for FE

@davidmillerwellcome commented on Mon May 16 2016
@Thomas-Wellcome I just wanted to add, now that the designs have been signed off...I noticed that 'Part of' and the text that follows are part of the h2 heading.

It breaks the purpose of a heading to have the content that follows inside the heading tag.  So I think it should be:

Part of

Access Tours...

If you agree, we should be update the AC.

@Joshua-David commented on Mon May 23 2016
@nambisolo html to replace the current .snippet__related-link:

Part of

Title of related content

Title of related content

Title of related content

@nambisolo commented on Mon May 23 2016
@Joshua-David see http://wellcomecollection.org/events/symposium-out-control. Multiple associations will be listed at the bottom of this page too. Can you tweak the markup for this as well please?

@Joshua-David commented on Tue May 24 2016
@nambisolo:

Part of

Title of related content

Title of related content

Title of related content

@nambisolo commented on Tue May 24 2016
Books/Publications are adding some complexity to this. Can't add 'Part of' the same way as other items. Publications were a type of Artefact. Books are a content type rather than a type of Artefact. Attached is a query returning all 'Publications' on the site.
field_artefact_type.xlsx

@RussellDornan commented on Tue May 24 2016
Hi @nambisolo
You can ignore Publications, as these will soon be removed once the bugs with Books have been fixed. Are Books still a problem?

@nambisolo commented on Tue May 24 2016
@RussellDornan I think fixing the bugs with the books should be done before this ticket.

@debdoop commented on Wed May 25 2016
Russell is happy to go ahead without books and we can sort them out in the future so he won't link to them from this section :ok_hand:

@nambisolo commented on Wed May 25 2016
@RussellDornan I think I've managed to untangle some things. I'll detail below with some questions but it may be easier to discuss in person.
Books/Publications
I discovered that as books could not be added as a 'Referenced content listing item' to an exhibition, they were being added as a 'Custom listing item'. This is an obvious workaround but it was preventing 'Part of' being displayed. I have enabled books to be referenced now and 'Part of' can be displayed under books in listings.
Unfortunately this requires retrospective editing of all pages that have been referencing books like this. Be careful when carrying out the editing as most books will have a corresponding 'publication'. Make sure the 'book' content type and not the 'artefact' content type is added.
Additionally to ensure the book snippet is displayed correctly on listing pages I've had to remove some markup. This has had a minor knock on effect on the books landing page which will need some FE attention.
Rendering associations on each content type
The only content type that currently displays associations automatically is 'event'. Each of the following can do so as well with coding but I need advice on the positioning:

Artefact
Basic page
Book
Exhibition

To overcome the limitation of the above content types to automatically display associations, you've been adding them to the wysiwyg field. Again, understandable but this copy will need to be removed in order to avoid duplication when associations are drawn in automatically.

@nambisolo commented on Thu May 26 2016
@RussellDornan I have added the 'Part of' field to the foot of the 'Artefact' content type but I've noticed items are already being automatically generated at the bottom of the page. From what I can see, these items are Exhibitions from which the artefacts are referenced via the 'Artefacts' field.
If you want to use the 'Part of' field on Artefacts pages I suggest you remove the artefacts references from the Exhibition and add them to the 'Part of' field instead. Over time the Artefacts field will become redundant.
Let me know if this makes sense.

@RussellDornan commented on Thu May 26 2016
@nambisolo That makes perfect sense (and is what I tried to explain at your desk previously, though you've done it much more articulately here). All is crystal clear!

@nambisolo commented on Mon Jun 13 2016
@Joshua-David I've added the markup to the BE code. I've also made some changes to the markup that renders the book snippets for consistency. As a result the alignment on the books landing page has changed from centred to left. Could you make the necessary CSS changes to realign please?

@Joshua-David commented on Fri May 27 2016
@Thomas-Wellcome have assigned to you for code review

@Thomas-Wellcome commented on Tue Jun 14 2016
@nambisolo I know you changed the markup for books, but without it the titles won't sit on same line. e.g. "A Guide for the Incurably Curious":

What trouble causes it if we reimplement the wrapper divs?
The missing div has had the class
 and was removed in commit named "#21 Enabled 'book' content type to be referenced as an entity. Added markup for formatting in page associations.".

@Thomas-Wellcome commented on Wed Jun 22 2016
@nambisolo Could you please reinsert the
 wrapper for books.  I changed the CSS to only affect the design on book page, but not on search results. Thank you!

@jamesgorrie @Heesoomoon ^^
Ahoy, some useful information about the events and exhibitions data model, from the V1 site repo.

That's v3. You're working on v4. #historyman


[utils/topgen] Add automatic generated Rust file for topgen

Add rust language support for topgen.
Add template for generating all chip level constants and enum for rust.
In order to test this commit pleas run following command:
"cd $REPO_TOP"
"make -C hw top"

Following PR is part of issue: #16650


isDarkModeEnabled returns empty string in recipes

Describe the bug
The isDarkModeEnabled property in the settings within a recipe is always an empty string, no matter if the dark mode is enabled in Franz or not.
To Reproduce
Steps to reproduce the behavior:

Create a simple recipe
In webview.js add something like this:

module.exports = (Franz, settings) => {
  console.log('isDarkMode:', settings.isDarkModeEnabled);
}

Observe that value in the console when loading the recipe

Expected behavior
settings.isDarkModeEnabled should be a boolean, specifying whether the dark mode is enabled or not.
Screenshots
not applicable
Desktop (please complete the following information):

OS: macOS 10.14.4
Browser: Google Chrome
Version: 74.0.3729.131

Smartphone (please complete the following information):
Didn't check, but shouldn't be different.
Additional context
Some services already have a dark mode built in. I'd simply like to enable it within the recipe, depending on the dark mode setting in Franz (instead of providing a custom dark mode CSS file), using code like this:
module.exports = (Franz, settings) => {
  // expected:
  if (settings.isDarkModeEnabled) {
    // enable built-in service dark mode
  } else {
    // disable built-in service dark mode
  }
}

Great, no comment or anything from the maintainers but closed off. This is how to not build a community around an open source project :slightly_frowning_face:


Minisim and Buttons No Longer Aligned

I suspect it's a result of the tutorial updates, but not certain...

Still repros in /beta


Backport NDRS-1013 validate block size to 0.9.4 branch

backport of https://github.com/CasperLabs/casper-node/pull/1141 to release-0.9.4 branch

I glanced over it: Approving, assuming it's identical to #1141 — or were there any merge conflicts that changed anything?

No, just cherrypicked both commits over and it seems good.

bors r+


Fix legacy table style issues

This issue has been fixed with @equinor/energyvision-legacy-css:1.0.0 version.