chore: upgrade LocationWithUnexpectedStopTimeNotice to ERROR

closes #1017
Summary:
This PR provides support to upgrade LocationWithUnexpectedStopTimeNotice to ERROR.
Expected behavior:
LocationWithUnexpectedStopTimeNotice:

Referenced locations must be stops/platforms, i.e. their stops.location_type value must be 0 or empty.
https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#stop_timestxt

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
~[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)~

LGTM

Thanks for reviewing @aababilov!


JBMETA-392 added flushOnSessionInvalidation to the parser and jboss-w…

…eb schema
https://issues.jboss.org/browse/JBMETA-392

@wolfc or @stuartwdouglas could you review this please?


EKS managed node_disk size don't change

Description
Disk size for EKS managed node groups remain in 20 Gb even after changing the value for disk_size
Versions

Terraform:

1.1.3

Provider(s):

+ provider registry.terraform.io/gavinbunney/kubectl v1.13.1
+ provider registry.terraform.io/hashicorp/aws v3.73.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.4.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.7.1
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0

Module:

18.2.6

Reproduction
Steps to reproduce the behavior:
Just planning and applying while using workspaces in terraform cloud, doesn't work... When changing disk_size value the change is not reflected in the terraform plan.
Expected behavior
disk_size value change gets reflected in a change in the disk size of the EKS managed node group.
Actual behavior
disk_size remains 20Gb (which is the default value) even after this value gets changed.

duplicate of #1739 - see https://github.com/terraform-aws-modules/terraform-aws-eks/blob/7babe877758ae0287975627a0135aa8b40c29e93/examples/eks_managed_node_group/main.tf#L72-L75

Would be really nice to reflect this in the docs... Thanks for the amazingly quick help!!!

@cacciald-scoutbee it is in the docs https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1760/files


Sentinel cooldown change 180 to 120.

SENTINEL cooldown change 180 to 120.

This should probably have been done in layers, but Sentinel isn't really used anywhere except timeline anyway. We don't seem to have patch dates for CN even though they're already on 5.1 afaik, so it may show incorrectly on some Chinese logs.


Is there a release planned to include passing configurations as attributes?

The feature introduced in https://github.com/IcarusWorks/ember-cli-input-mask/commit/a0234b4f31d36f16c92a06221387c6990a2797fe that supports configuring the plugin based on the component's attributes.
Is that feature considered stable?
Will there be a version bump and NPM release soon?

We are going to archive this addon in favor of https://github.com/pzuraq/ember-inputmask.


Pretrained model

Hi,
Is the pretrained model available somewhere?

Hi @saleha1wer
There are no model checkpoints released, but all the steps for retraining the model are available here.
Using available on Zenodo (Dataset of biocatalyzed reactions) you can recreate the same model from the paper.
Thanks a lot for the interest in our research.
Best,
Yves


minor glitch: if timer runs out, initials input does not show up.

Current behavior:
IF all questions are answered, score is shown and then initials input is requested.
but if timer runs out, score is shown but initials input is not requested
Expected behavior:
timer running out should have the same behavior as if all questions answered above.

Fixed by deleting code saveScore() in the timer function


Refactor all the things

I read about this in the update from RubyGems, which we're sponsoring.
Just out of curiosity, will the readme etc for this gem be updated, to describe what it does? 😄

Yeah, I hope to getting around to writing a description at some point


Duplicate binding messages when using rx_itemsWithDataSource + configureCell

I have the following code:
viewModel.tableViewSections.bindTo(tableView.rx_itemsWithDataSource
....
viewModel.tableViewDataSource.configureCell = {
...
This is working in previous release but now throwing assert, what is the proper way of doing this?

Hi @grangej ,
just reverse those two lines.

Is there anyway to bind multiple data sources?
Or is there anyway avoid return cell in certain conditions?

Hi @jingfei05 ,
maybe this was what you were looking for.
https://github.com/RxSwiftCommunity/RxDataSources/blob/master/Example/Example4_DifferentSectionAndItemTypes.swift


getDownloadObject: use openpolicyagent.org redirect, allow for "edge" version

I've needed an extra if branch in getVersion() to make this work. Before, "latest" was also declined as an invalid range or version.
Using the redirect, we get homogeneous URLs for all versions, latest, and edge binaries. (They're defined here: https://github.com/open-policy-agent/opa/blob/v0.35.0/docs/website/layouts/index.redirects#L35-L38)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Also can/should we add a test case for "edge"? I'm not sure where to look up the expected version for that.

Yeah just what I had in mind 🙃 gave it a go in another commit. Ah, need to fix something there wrt. patch releases.... one moment.

"edge" doesn't work. I'm looking into it.

💡 didn't update dist in my PR

Looks good, thanks!  I'm going to add an action to make sure the dist directory has been updated.


Setup typescript

Noting down few questions from our discussion here:

What is the best practice around supporting multiple environments (browser, node, react-native)

Single package compiled to multiple targets. Examples: airtable.js, Formik
Separate packages. Example: react-router

Should we use something like tsdx to manage packages for us?

It claims to configure eslint, jest, rollup etc with best practices while being customizable
Working monorepo template live reloads when changes are made to any package <package>/src/* folder


Ordering a FlowCursorList

I believe that currently there is no Ordering for the FlowCursorList. I believe this would be a good enhancement.

@surfer190  what you mean? you can pass in any ModelQueriable such as a From, Where, etc and can use the orderBy() method in Where to do that.

@agrosner I'm just trying to get an example of this in the Docs, is there an available guide?
This is what I have currently:
mFlowCursorList = new FlowCursorList<TreeDetails>(true,
        TreeDetails.class, Condition.column(TreeDetails$Table.KRUGER).eq(true));

I would like to order this query

new FlowCursorList<TreeDetails>(true, new Select().from(TreeDetails.class)
  .where(Condition.column(TreeDetails$Table.KRUGER).eq(true))
  .orderBy(orderByString));

Ill add something in docs for it if its not there already.

@agrosner Thank you. It worked. I was confused about ModelQueriable. I don't really know what it is. I thought I would have to do something like:
ModelQueriable<TreeDetails> mq = new ModelQueriable<TreeDetails>() {
      ...
    }

It seems as though new Select() returns a ModelQueriable.
On a side note , and I know this is not the place: How should subqueries be handled? The usecase is list the data include an image and a selection of languages. I haven't used Relationships/ForeignKeys and wanted to do SQL like this:
SELECT *, (SELECT CommonName FROM CommonNames WHERE LanguageId = '1' AND TreeId = TreeDetails.TreeGuid AND Primary = '1') AS afrikaans,
  (SELECT CommonName FROM CommonNames WHERE LanguageId = '2' AND TreeId = TreeDetails.TreeGuid AND Primary = '1') AS english
  FROM TreeDetails LEFT JOIN (SELECT * FROM TreeImages WHERE Icon = 1) ti ON TreeDetails.TreeId = ti.TreeId WHERE Kruger = 1
  ORDER BY english;

Would I be able to do something like the above when using Relationships?


Is it possible to add custom image or icon?

Great component, works well!
I would like to add a custom image or ideally a font-awesome (v 5) class to match site icons/styles.

@brightertools You can override my style like this:
.datepicker:before {
    background: '/your/image/path';
}

Thanks! Will try that


Update coc

Closes #236.

Changes proposed in this pull request:

removed references to McGill support
replace Slack details with Discord/ email
edited info to reflect hub location policies

LGTM!

I accidentally added a commit for another page on the website (weeks). Will this cause an issue when merging?


Add scanoss.py as a scanner

Description
Add scanoss.py as a scanner.
Separate common codes for scanning.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Dear @dd-jy ,
This PR is not yet merged into main. There are additional corrections to be made. (ex- comment output)
However, one more variable returned by the run_scan function has been added. If there is a call to the run_scan function, you need to fix it.


Create two step rollout

Make it so that there is only dev and stable channels visible in UI.
Some percentage of users are actually on beta channel. This way we can get feedback on the new features from certain group of users before rolling out the updates to all users.

the infrastructure is there, just release to beta first, instead of going directly from dev to stable.


fix(aws): change default handler context key

The aws sdk places a value in HandlerContextKey.OPERATION_NAME (e.g. GetObject) at least
some of the time, so use a default that's not one of the predefined HandlerContextKey
objects to avoid that.
I noticed this with a test of spectator 1.0.5 against a localstack container.  Happy to add a test like that here is it's OK to add a test dependency on https://github.com/testcontainers/testcontainers-java.  Sorry I didn't catch this earlier.

Happy to add a test like that here is it's OK to add a test dependency on https://github.com/testcontainers/testcontainers-java

I'm not familiar with this, the main thing I would want to make sure is that it is fairly lightweight, reliable, and wouldn't significantly increase testing times.  It can be done as a follow up later if there is sufficient need or interest.

Happy to add a test like that here is it's OK to add a test dependency on https://github.com/testcontainers/testcontainers-java

I'm not familiar with this, the main thing I would want to make sure is that it is fairly lightweight, reliable, and wouldn't significantly increase testing times. It can be done as a follow up later if there is sufficient need or interest.

Yeah, it would for sure increase testing times...probably significantly...time to pull a docker image, and then run it.

Thanks for merging this and releasing a new version so quickly!


Move KeyTypeParameter validation from CredentialPublicKey.Verify() into constructors

Add test for invalid COSE key types
Add support for OKP certificates for CredentialPublicKey and test for same
Fix two packed tests that erroneously used "Reserved" key type instead of P256
Closes #552

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.92%. Comparing base (ea6cd8f) to head (ae18247).

Files with missing lines
Patch %
Lines

Src/Fido2/Objects/CredentialPublicKey.cs
74.35%
5 Missing and 5 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   76.96%   76.92%   -0.04%
==========================================
  Files         100      100
  Lines        2613     2626      +13
  Branches      441      441
==========================================
+ Hits         2011     2020       +9
- Misses        496      498       +2
- Partials      106      108       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Seems CodeCov is mostly complaining about not covering the throw's which I think is fine.


upgrade libxmljs dependency

The dependency to libxmljs is to old. Should be changed from "~0.8.1" to the most recent.

Closed by merging @milovanderlinden’s commit.


How to save the final HTML source code into a variable?

Hi,
I am trying to do the following, but do not understand how to do the last step. Can somebody give any tips?

Navigate to a certain webpage.
Sleep for 15 seconds (this should give enough time for all possible elements on the page to load).
Save the final HTML source code into a variable.

Thanks!

Duplicate of #921.


cdo: 2.2.0 -> 2.2.2

Description of changes

Just a simple bump to the latest version. This was requested in #229679.
Changelog: https://code.mpimet.mpg.de/projects/cdo/news
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@jeremybarbet feel free to do a review of this PR.

Result of nixpkgs-review pr 257101 run on aarch64-darwin 1

1 package built:

cdo

Failure on x86_64-darwin is not new. see ofborg results in #240557


Add generic Cortex-M7 target

I'm not sure if it's the right thing to do, but this target is definitely missing from the list.


Missing prop

Given the actual behavior of the accordion still missing a prop to expand only from the arrow button since is required to put some buttons in the header

Any chance you would have an example code to illustrate what you mean?

Sorry @ecastroItexico - I'm going to close this defect. Happy to re-open if you're able to elaborate a little.
Cheers!


Maximum radius search [FEATURE]

Is your feature request related to a problem?
I would be interested in the ability to provide a maximum radius filter to find all (approximate) nearest neighbors that lie within a certain distance from the query vector. For our use case we need to aggregate over this result. If I am not mistaken, this is currently not possible.
What solution would you like?
Something like:
GET my-knn-index-1/_search
{
  "query": {
    "knn": {
      "my_vector2": {
        "vector": [2, 3, 5, 6],
        "radius": 2.0
      }
    }
  }
}

This would allow me to aggregate over all results for the given radius.
What alternatives have you considered?
We are considering Elasticsearch as an alternative. They are working on such a feature: https://github.com/elastic/elasticsearch/issues/84929

Assigning it to @vamshin

Please +1 if you are looking for this feature to help prioritize

With leveraging both Lucene and FAISS libraries, we can find out a way to unify the radius search API for both enginess in OpenSearch k-NN.

FAISS: It supports in radius searches by range_search API with distance parameter of radius for both IVF and HNSW methods.

Library availability in k-NN:

IVF: Supported
HNSW: It will be supported after k-NN Faiss bump PR merged

Lucene: Lucene recently added the feature of supporting similarity-based vector searches. It can find all vectors scoring above a resultSimilarity while traversing the HNSW graph till better-scoring nodes are available, or the best candidate is below a score of traversalSimilarity in the lowest level.

Library availability in k-NN:

HNSW: This feature will be released at Lucene 9.10(Feature release information, Lucene release history), then OpenSearch will also be required to bump to Lucene 9.10.

Our initial release goal is to support both Lucene and Faiss engine for this feature.
cc: @vamshin @Thijsvandepoll

Lucene 9.10 branch was cut yesterday and the release process will begin tomorrow. Given that OpenSearch release is starting today, it's unlikely this would make 2.12 w/o a delay.
9.10 upgrade is a good reason to suggest postponing 2.12 as there's several nice updates and features coming in Lucene, but it looks like OpenSearch core's main branch still hasn't updated to any snapshot of 9.10. Perplexing why that never happened since (at minimum) the main branch should be updated to the next minor snapshot after a release of Lucene to ensure we stay on track w/ upstream releases. ¯\_(ツ)_/¯

Thanks @nknize for sharing the timely information on Luecne 9.10!

thanks @nknize. Looks like we cannot make it to 2.12. If core can unblock us with 9.10 upgrade, we can start testing end to end feature and get ready for 2.13.
cc: @bbarani

Radial search benchmark
Cluster configuration

Configuration
Value

OpenSearch Version
2.x

Leader Nodes
3

Leader Node Type
c6g.xlarge

Leader Node Disk Space
50

Data Nodes
3

Data Node Type
r6g.2xlarge

Data Node Disk Space
100

Primary Shard Count
3

Replica Count
1

AZ
us-east-1

Test client type
m5.2xlarge

Cluster created by opensearch-build and opensearch-cluster-cdk
Feature branch: https://github.com/junqiu-lei/k-NN/tree/2.x-radial-traversal
Benchmark Tool
OSB
Dataset
We need update datasets to include threshold values for top-k and true neighbors for radial threshold.
For example, the top k 100 query threshold means we use the 100th nearest doc to capture the min_score threshold and max_distance threshold.

 It maintains faster query time and higher recall.
Faiss shows similar query speed and recall from radial search to knn search.
In Lucene with lower traversal similarity, we can see higher recall and lower query speed performed, when traversal similarity at around 0.95 of min_score, it could get a result in balanced performance n terms of query latency and accuracy. I think it's necessary to configure the traversal similarity value when use Lucene engine. We probably can use the 0.95*threshold as the default traversal similarity value in k-NN.

CC: @jmazanec15 @navneet1v @vamshin

@junqiu-lei thanks, I think the 0.95*min_score makes sense to start. We can make this configurable in future if need be.

Closing this issue as this feature is going to release at 2.14.


Default history tab

What it solves
Resolves #2780
How this PR fixes it
History is now the default Transactions List tab.
How to test it
Open the Transactions page and you shall land in the Tx history first.
When one finished a transaction, one is redirected to the Queue tab.
Screenshots

From the issue description:

But not after triggering a transaction (it should still open the Queue).
Don't swap the order of tabs in the UI

If you do a transaction on this branch, it redirects to History. But should redirect to Queue.

Issue:

[ ] If you are already in the history tab and create a tx like send funds, the focus remains on the History tab instead of going to the Queue tab.

Note in case somebody else checks: If you create a tx in the Apps section, it remains there, in the apps section. This is correct, this behavior is intended.

Does it makes sense to reflect the tabs in the URL? I.e. /transactions/history & /transactions/queue

This would make a lot more sense and remove reliance on the history state.

I thought this could be more straight forward. We can check this in another ticket if you want.


Added option to force fixed or scrollable tabs

I haven't tested this because I don't know how to set up the build environment, but I think this should work.
I want a screen with 5 short-named tabs (2-character weekday names), which will fit perfectly on one screen without scrolling.

I think there is a better approach to this. Letting the client to set specific integer for the number of the tabs to be represented. #45


how to install on windows

I've tried both windows versions - they're not executables or zips - what sort of file are they?
I've also tried running both linux versions in Windows 10 Linux Subsystem but with errors...

The windows amd64 build should be a valid 64 bit executable, albeit without the exe extension. I don't think I ever run it on windows, but the build system is just setting GOOS and GOARCH: https://github.com/Mikulas/kubectl-repl/blob/master/release.sh
On the linux subsystem I believe you would have to execute the linux-amd64 build.

ok, got it to execute by adding .exe to the end.. but it fails immediately since it depends in /bin/sh
[D:\docker\k8s\kubectl_repl]  kubectl-repl-windows-amd64-1.4.exe
2018/11/21 18:53:59 exec: "/bin/sh": file does not exist:

WSL linux also fails
cwerner@D8NZLPC2:/mnt/d/docker/k8s/kubectl_repl$ ./kubectl-repl-linux-amd64-1.4 2018/11/21 18:55:50 fork/exec /bin/sh: invalid argument: cwerner@D8NZLPC2:/mnt/d/docker/k8s/kubectl_repl$ which sh /bin/sh cwerner@D8NZLPC2:/mnt/d/docker/k8s/kubectl_repl$ sh $

I see, that is an additional reason for #2 then. I don't think anybody is using this windows so it never came up before. You can probably bypass it by symlinking the shell to /bin/sh, but frankly I would recommend using a docker version instead until #2 is resolved.


Use UPX to decrease Docker image size

feeding gatus executable to UPX reduces it's size and resulting
docker image by 55.46%, from 35.7MB to 15.9MB

$ docker images | head -3 | column -t
REPOSITORY            TAG     IMAGE         ID  CREATED  SIZE
gatus                 upx     18148e83ea72  2   minutes  ago   15.9MB
twinproduction/gatus  latest  4e97e341f3b1  13  hours    ago   35.7MB

Codecov Report

Merging #36 (ea0c74d) into master (f273ee4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   84.67%   84.67%
=======================================
  Files          14       14
  Lines         509      509
=======================================
  Hits          431      431
  Misses         56       56
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d184786...ea0c74d. Read the comment docs.

@anapsix Using COPY instead of ADD as well as the entries you've added to the .dockerignore file were very good catches, however, I'd rather pass on using upx if the only argument for using this is to reduce the total image size given that the image size is already pretty small

updated PR with 3 separate commits:

update .dockerignore
moving package installation RUN to execute before RUN building the binary
adding upx

I see no harm in further reducing image size (from 35.7MB to 15.9MB), but this, like everything else in the project, is entirely up to you.
Let me know if you'd like me to remove UPX stuff from this PR entirely.

what I meant to say is that I respect your ownership of the project, and acknowledge your inherent right to accept or decline PRs :)
#42 created 🐬

rebased


Fixed Gemma FP8 flash_attention lower throughput issue

Fixed Gemma FP8 flash attention lower throughput issue due to FusedSDPA did not proper convert to fp8_quant.
What does this PR do?
Fixes # (https://habana.atlassian.net/browse/HS-3985)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

BF16:
python ../../optimum-habana/examples/text-generation/run_generation.py \
--model_name_or_path google/gemma-7b \
--use_hpu_graphs \
--trim_logits \
--use_kv_cache \
--reuse_cache \
--max_input_tokens 128 \
--max_new_tokens 128 \
--bf16 \
--batch_size 128

BF16 Test Results:

batch_size
max_input_tokens
max_new_tokens
use_flash_attention
flash_attention_recompute
attn_softmax_bf16
Throughput
Memory allocated
Max memory allocated

128
128
128

4527.4935
79.0
80.97

128
128
128

✓
4525.4579
79.0
80.98

128
128
128
✓

4555.3974
78.99
80.97

128
128
128
✓
✓

4550.4494
78.99
80.97

FP8:
Measure: (for flash attention add --use_flash_attention option)
QUANT_CONFIG=../../optimum-habana/examples/text-generation/quantization_config/maxabs_measure.json python ../../optimum-habana/examples/text-generation/run_generation.py \
--model_name_or_path google/gemma-7b \
--use_hpu_graphs \
--trim_logits \
--use_kv_cache \
--reuse_cache \
--max_input_tokens 128 \
--max_new_tokens 128 \
--bf16 \
--batch_size 1

Quantization:
QUANT_CONFIG=../../optimum-habana/examples/text-generation/quantization_config/maxabs_quant_gemma.json python ../../optimum-habana/examples/text-generation/run_generation.py \
--model_name_or_path google/gemma-7b \
--use_hpu_graphs \
--trim_logits \
--use_kv_cache \
--reuse_cache \
--max_input_tokens 128 \
--max_new_tokens 128 \
--bf16 \
--batch_size 128

FP8 Test results:

batch_size
max_input_tokens
max_new_tokens
use_flash_attention
flash_attention_recompute
attn_softmax_bf16
Throughput
Memory allocated
Max memory allocated

128
128
128

7675.9192
64.77
66.63

128
128
128

✓
7678.3047
64.78
66.63

128
128
128
✓

7676.5944
64.76
66.74

128
128
128
✓
✓

7669.2833
64.76
66.61

@tthakkal , @libinta @mandy-li , please review this PR.

@vidyasiv Could you please help review this PR?

@vidyasiv Could you please help review this PR?

I have some hand issues and prefer to follow current we have process for review assignments to ensure distribution of reviews.

@libinta can you check if this PR needs to be added to review list per priorities?

@kplau1128
can you also measure perf for bigger sequence length such as 1024x1024, 2048x2048 or bigger?  flash_attention should show much better performance for bigger sequence length.

@kplau1128 Please rebase your branch on main and run make style to make the code quality check pass

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kplau1128 Please rebase your branch on main and run make style to make the code quality check pass

Code rebased. Ran make style locally all checks passed.


Add other windows platforms

As of deploying from windows becomes available in balena-cli.

You may use Kali Linux to deploy from WSL2 (Windows subsystem for Linux version 2)
A working Docker installation must be available for Balena-Cli to run

Building under WSL2 ... with docker


factorial designs (between person)

Please leave suggestions for studies using a factorial design for between-person studies.

Consider Marlatt et al (1975; https://doi.org/10.1037/0021-843X.84.6.652) Provocation to anger and opportunity for retaliation as determinants of alcohol consumption in social drinkers. Here's the abstract:

Assigned 30 male and 30 female college students identified as heavy social drinkers to 1 of 6 groups in a 3 * 2 factorial design. In addition to the S sex factor, the 3 main treatment groups were provocation to anger with no opportunity to retaliate, provocation with opportunity for retaliation, and a no-provocation, no-retaliation control group. Provoked Ss were angered by an insulting confederate, whereas controls experienced a neutral interaction with the confederate. In the retaliation condition, Ss were given the opportunity to deliver a fixed number of shocks to the confederate who had provoked them. Drinking rates in all Ss were then determined by their participation in a standardized taste-rating task, which permitted an unobtrusive measure of alcohol consumption. Results show that group members who were provoked and expressed their anger by retaliating against the confederate consumed significantly less alcohol than provoked Ss in the no-retaliation condition. Controls drank an intermediate amount of alcohol but did not differ significantly from the other 2 groups. Sex was not a significant determinant of alcohol consumption

This is a nice quasi-experimental 2 X 3 design where 30 men and 30 women who identified heavy social drinkers were randomized into 1 of 3 conditions. The outcome is ounces of alcohol drank, which would make for a nice example with distributions like the gamma or lognormal.

Consider Clark et al (2021; https://doi.org/10.1111/add.15072) Impact of health warning labels communicating the risk of cancer on alcohol selection: An online experimental study. Here's the abstract:

Aims Evidence from tobacco research suggests that health warning labels (HWLs) depicting the adverse consequences of consumption change smoking behaviours, with image-and-text (also known as 'pictorial' or 'graphic') HWLs most effective. There is an absence of evidence concerning the potential impact of HWLs placed on alcohol products on selection of those products. This study aimed to obtain a preliminary assessment of the possible impact of (i) image-and-text, (ii) text-only, and (iii) image-only HWLs on selection of alcoholic versus non-alcoholic drinks. Design A between-subjects randomised experiment with a 2 (image: present versus absent) × 2 (text: present versus absent) factorial design. Setting The study was conducted on the online survey platform Qualtrics. Participants Participants ($n = 6024$) were adults over the age of 18 who consumed beer or wine regularly (i.e. at least once a week), recruited through a market research agency. Interventions Participants were randomised to one of four groups varying in the HWL displayed on the packaging of alcoholic drinks: (i) image-and-text HWL; (ii) text-only HWL; (iii) image-only HWL; and (iv) no HWL.  Each group viewed six alcoholic and six non-alcoholic drinks and selected one drink that they would like to consume. Measurements The primary outcome was the proportion of participants selecting an alcoholic versus a non-alcoholic drink. Findings Alcoholic drink selection was lower for all HWL types compared with no HWL (image-and-text: 56%; image-only: 49%; text-only: 61%; no HWL: 77%), with selection lowest for HWLs that included an image. Image-and-text HWLs reduced the odds of selecting an alcoholic drink compared with text-only HWLs (OR = 0.80, 95% CI = 0.69, 0.92), but increased the odds of selecting an alcoholic drink compared with image-only HWLs (OR = 1.34, 95% CI = 1.16, 1.55). Conclusions Health warning labels communicating the increased risk of cancers associated with alcohol consumption reduced selection of alcoholic versus non-alcoholic drinks in a hypothetical choice task in an online setting; labels displaying images had the largest effect. Their impact in laboratory and real-world field settings using physical products awaits investigation.

This is a posttest-only 2 X 2 factorial experimental design where $n = 6024$ adult drinkers were randomized into 1 of 4 conditions. The primary outcome is the probability of selecting an alcoholic beverage in an online selection task, with a control condition being compared to conditions using text-only, image-only, or text-and-image health warning labels. This would make for an easy example with binomial regression and probability contrasts. You could compare the conventional y ~ 1 + dummy1 + dummy2 + dummy1 : dummy2 approach with a y ~ 1 + factor(group) approach (where control is the reference category). As the authors concluded the previous research on this topic for alcohol was scant, of small samples sizes, and somewhat contradictory, this would be an easy example to use weakly-regularizing priors.
Also, the authors made the data openly available on the OSF at https://osf.io/pr8zu/ (see the Alcohol study 2 full dataset.xlsx file in the Study 2 folder.

Consider Berg et al (2020; https://doi.org/10.3389/fpsyt.2020.00503) *The role of learning support and chat-sessions in guided internet-based cognitive behavioral therapy for adolescents with anxiety: A factorial design study . Here's the abstract:

Background: Increased awareness of anxiety in adolescents emphasises the need for effective interventions. Internet-based cognitive behavioural therapy (ICBT) could be a resource-effective and evidence-based treatment option, but little is known about how to optimize ICBT or which factors boost outcomes. Recently, the role of knowledge in psychotherapy has received increased focus. Further, chat-sessions are of interest when trying to optimize ICBT for youths. This study aimed to evaluate the role of learning support and chat-sessions during ICBT for adolescent anxiety, using a factorial design.
Method: A total of 120 adolescents were randomised to one of four treatment groups, in a 2x2 design with two factors: with or without learning support and/or chat-sessions.
Results: Anxiety and depressive symptoms were reduced (Beck Anxiety Inventory-BAI; Cohen’s $d = 0.72$; Beck Depression Inventory-BDI; $d = 0.97$). There was a main effect of learning support on BAI ($d = 0.38$), and learning support increased knowledge gain ($d = 0.42$). There were no main effects or interactions related to the chat-sessions. Treatment effects were maintained at 6-months, but the added effect of learning support had by then vanished.
Conclusion: ICBT can be an effective alternative when treating adolescents with anxiety. Learning support could be of importance to enhance short-term treatment effects, and should be investigated further.

This is a pretest-posttest randomized controlled trial with a 2 X 2 design where 120 adolescents in Sweden were treated with a 9-week protocol of internet-based cognitive behavioural therapy (ICBT) for anxiety and comorbid depression. The primary outcomes were the BAI and BDI-II sum scores, which make for a nice comparison of the conventional Gaussian and beta-binomial likelihoods.

Consider Aminpour et al (2022; https://doi.org/10.1186/s12889-022-14801-6), The choice of message and messenger to drive behavior change that averts the health impacts of wildfires: An online randomized controlled experiment. Here's the abstract:

Background
To reduce the negative health effects from wildfire smoke exposure, effective risk and health communication strategies are vital. We estimated the behavioral effects from changes in message framing and messenger in public health messages about wildfire smoke on Facebook.
Methods
During September and October 2021, we conducted a preregistered online randomized controlled experiment in Facebook. Adult Facebook users ($n$ = 1,838,100), living in nine wildfire-prone Western U.S. states, were randomly assigned to see one of two ad versions (narrative frame vs. informational frame) from one of two messengers (government vs. academic). We estimated the effects of narrative framing, the messenger, and their interactions on ad click-through rates, a measure of recipient information-seeking behavior.
Results
Narrative frame increased click-through rates by 25.3% (95% CI = 22.2, 28.4%), with larger estimated effects among males, recipients in areas with less frequent exposure to heavy wildfire smoke, and in areas where predominant political party affiliation of registered voters was Republican (although not statistically different from predominantly-Democrat areas). The estimated effect from an academic messenger compared to a government messenger was small and statistically nonsignificant (2.2%; 95% CI = − 0.3, 4.7%). The estimated interaction effect between the narrative framing and the academic messenger was also small and statistically nonsignificant (3.9%; 95% CI = − 1.1, 9.1%).
Conclusions
Traditional public service announcements rely heavily on communicating facts (informational framing). Shifting from a fact-focused, informational framing to a story-focused, narrative framing could lead to more effective health communication in areas at risk of wildfires and in public health contexts more broadly.

The research team "used a 2×2 factorial design where Facebook users were randomly assigned to see one of two ad versions (Informational vs. Narrative messages) from one of two messenger types (Government vs. Academic sources). Randomization was achieved by employing the A/B split testing functionality embedded in Facebook ads" (p. 3). The dependent variable is click-through rates (CTR), which are binary. The authors have high-quality prior research on typical CTR's, which makes for nice prior information. Importantly, the data are available in aggregated form on the OSF at https://osf.io/9ax6n/?view_only=55488a95825444aa830eadbd38fe3565. The data include several baseline covariates, making this a nice way to showcase aggregated binomial ANCOVAs'. Given the large sample size, this also makes for nice discussions on the strength of default weakly-regularizing priors, and the importance of aggregated data.


stop insert retry and drop queue after too many retries

I experienced a scenario where my elasticsearch cluster had a downtime. This caused my elastigo client to retry inserts over and over again. It was queuing more and more documents for sending while it was sleeping between retries. Eventually the RAM filled up and the machine stopped responding until the app running elastigo was restarted.
Please add a feature for max retries, and let elastigo drop it's current insert attempt and move on.

this basically comes down to providing some sort of circuit breaking


Custom action that modifies command parameters

I'm trying to create a custom action for grep (or other commands) that lets you toggle pre-determined parameters but can't figure out how to modify rg_opts.
For example, lets say I search something via grep and but at some point wants to filter down the results to "non-test Ruby and Typescript files". This translates to adding -t ruby -t ts -g !**/test/** in the code base I work on to rg_opts.
However, I can't figure out how to modify rg_opts inside an action as seen here:
          actions = {
            ["ctrl-g"] = { actions.grep_lgrep },
            ["ctrl-f"] = {
              function(selected, opts)
                -- this below doesn't work
                opts.rg_opts = opts.rg_opts .. " -t ruby -t ts -g !**/test/**"
              end,
              require("fzf-lua").actions.resume,
            }
          },

When you call resume you’re resuming the last used command, it won’t use your new opts.cmd, instead call live_grep (or grep) with the new command, see #860 for a similar case toggling .gitignore for files.

@ibhagwan thanks for pointing me to the right place.
Based on what I read, I've been able to piece together the following that does what I wanted above (but quite ugly).
It seems to mostly handle switching around between ctrl-g / ctrl-f. Haven't tested this very thoroughly and not sure if I'm using search right.
        local toggle_params_callback = function(_, opts)
          local toggle_opts = " " .. "-t ruby -t ts -g '!**/test/**'"
          local toggle_opts_pattern = vim.pesc(toggle_opts)
          local new_rg_opts
          if opts.rg_opts:find(toggle_opts_pattern) == nil then
            new_rg_opts = opts.rg_opts .. toggle_opts
          else
            new_rg_opts = opts.rg_opts:gsub(toggle_opts_pattern, "")
          end
          local last_query = require("fzf-lua").get_last_query()
          -- not sure how to detect grep vs lgrep
          if opts.prompt:sub(1, 1) == "*" then
            -- "*Rg"
            print("This is live grep .. " .. new_rg_opts)
            require("fzf-lua").live_grep({
              search = last_query,
              rg_opts = new_rg_opts,
              actions = opts.actions,
              debug = true,
            })
          else
            -- "Rg"
            print("This is grep .. " .. new_rg_opts)
            require("fzf-lua").grep({
              search = last_query,
              rg_opts = new_rg_opts,
              actions = opts.actions,
              debug = true,
            })
          end
        end

and in actions:
            ["ctrl-f"] = { toggle_params_callback },

but quite ugly

Many ways to skin a can, if it works it works :-)

not sure if I'm using search right

Technically live_grep should be using query (the propmp test) but both work equally for your use case, you can see the difference if you try both with grep, for example: :FzfLua grep search=pcall query=foo,  you'd notice search is the regex sent to rg and query is the --query argument sent to fzf (and pasted after the prompt).


Conflict with FTB Utilities

After updating from 1.16.9 to 1.17.0 some change caused FTB Utilities healing button at the top left of the screen when opening the inventory to stop restoring players properly. It still heals them, but it wont replenish the hunger anymore. And now it also starts printing: /heal < player>, in the in-game chat.
One log:
https://gist.github.com/Sereath/1159346b463429b7d7e1eafc7abadb31
Expected from FTB Utilities healing button:
Heal
Restore hunger
With 1.17.0:
Heal
No hunger restoration
Now prints ingame /heal < player>

I believe I didn't make any game-play changes between 1.16.9 and 1.17.0. And I can't reproduce it in the latest version.


Duplicate key error

Hi , how to use upsert statement with query builder ?

Hi, please provide more context on what you would like to do. Upsert statement does not supported by all the db drivers and not included into ORM scope.

I mean use insert ignore ... on duplicate key ... for mysql or insert ... on conflict ... for pgsql

For example in yii2 active record i can use
$db->createCommand()->upsert('table_name', ['name' => 'value'])
It's generate sql string (for mysql) : insert ignore into table_name (name) values (value);
or
$db->createCommand()->upsert('table_name', ['name' => 'value'], new Expression('cnt = cnt+1'))
It's generate sql string (for mysql) : insert into table_name (name) values (value) on duplicate key update cnt = cnt + 1
Can i use something like this in cycleorm query builder ?

Hi,
we do no expose upsert query builder at the moment. You can vote for it here: https://github.com/spiral/database/issues/29


AZ - Missing Records and Other Data Issues

Problem statement
AZ contacted us (Friday, October 15, 2021 11:22 AM) with issues they are experiencing:

In today's file we are again receiving records without a Lab_Name populated. These appear to be  a different facility from the ones listed in my last email as the CLIA is different. We also are not receiving Specimen_IDs for these records either. Both of these fields are required fields for processing. Please resolve. See screenshot below

Removing the comma from the school name

"St Ambrose Catholic School**,**".

What you need to know
Please see email from AZ on Friday, October 15, 2021 11:22 AM. For additional details
Acceptance criteria

[x] Remove comma from school name

[ ] Lab name should populate as expected

To do

[x] Confirm with the SimpleReport team that comma has been removed from the school name - confirmed on 10/15/21

[ ] Investigate while Lab name is not being populate and identify resolution

@MauriceReeves-usds - I verified in Metabase that all records received into RS in the last 30 days have the testing lab name populated where Ordering_Facility_Name contains "St Ambrose Catholic School".  This does not appear to be an issue with the inbound data.

Assigned to @jorg3lopez

@jorg3lopez - I did some investigation on this CLIA.  Up until 9/11/2021, the lab name was not sent for this CLIA.  On 9/13/2021, lab name is populated on the inbound reports.  This is confusing because AZ is stating that they didn't receive the lab name on 10/15.  It looks like they are referring to the 8 records with a created date of 10/14/2021.  Are we able to check the outbound file and determine why Testing Lab name didn't populate in OBX-23-1?

@jorg3lopez Can you provide an update on this?

Fix merged and deployed: https://github.com/CDCgov/prime-reportstream/pull/2956/files
Have not hear of any new issues from AZ.


Case where updating array/map fields does not work

I'm trying to upgrade Dynamoid 3.8.0 to 3.10.0.
Then, there was a case where the array field could not be updated.
(Also, the map type is the same.)
Field definition:
field :items, :array, { default: [] }

The following case cannot be saved. This looks confusing.
rec.items << 'foo'
rec.save!
pp rec.items
# ["foo"]
# This looks like it was saved.
pp rec.reload.items
# []
# But it's not actually persisted.

It works if I replace the whole (duplicated) array. However, this can be inconvenient for coding.
rec.items = ['foo']
rec.save!
pp rec.reload.items
# ["foo"]

new_arr = rec.items.dup
new_arr << 'bar'
rec.items = new_arr
rec.save!
pp rec.reload.items
# ["foo", "bar"]

Maybe related to https://github.com/Dynamoid/dynamoid/issues/666 ?

Yes, it seems a symptom of the same issue. Mutated collection/custom type isn't detected as a field change at persisting.

Sorry for creating a duplicate issue.
I understood that this is an issue due to a differential update. I certainly think this is a difficult problem.
The affected parts of our source code have been fixed, so there is no problem.
Thank you.


Uml 526 viewer session timeout pulled from env

Purpose
Briefly describe the purpose of the change, and/or link to the JIRA ticket for context
Fixes UML-526
Approach
Explain how your code addresses the purpose of the change
Pulled in session timeout value from environment variable
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Refunds service
Checklist

[x] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] The product team have tested these changes

Coverage remained the same at 78.523% when pulling 0087c2fb2d1b9a654343cfca15f8a4d8bc2e8901 on UML-526-Viewer-Session-Timeout-Pulled-From-Env into 38f35dfce6471e146257ed9dba3b341387c567b1 on master.


[enhancement]: Azure App Service Deployment: Node 20

Task name
Azure App Service Deployment
Describe your feature request here
Hi,
Azure web app has been updated to manage Node 20 since weeks but this task is stuck at node 18.
Could you please upgrade it so we can select  node 20?
Thanks,

Hi @elvince,
Azure App Service Deployment task has been updated to Node 20 since long but recently we have disabled this task to use Node20 as there are some issues with Node20.

@v-schhabra could you provide a link where these issues are mentioned? I am also facing this Node20 issue, but I am constrained by technology to use it and would like to know the consequences.

@georgeonofrei Could you pls share the failed pipeline debug logs?
I am not aware of the fully exact issue you are facing. If you can provide more details, I can share relevant issues that address these Node20 issues.

@v-schhabra I am sorry for the delay. What I meant to say is that Node 20 does not appear in the list of options, but I added it manually to the YAML and it worked without problems.
Otherwise I do not have any problems with deploying Node 20 from the application perspective.

@georgeonofrei Now could you pls check if still you are having issues?

@georgeonofrei Please let us know if you are still encountering any issues?

We are closing this issue as we havent received any response.

Same for us. We keep getting emails about losing support for Node 18 but can't upgrade because Node18 is the latest in the Devops task.


HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

JIRA: https://issues.apache.org/jira/browse/HADOOP-18430

Refactor CallerContext's constructor to eliminate duplicate code

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 25s

trunk passed

+1 :green_heart:
compile
25m 22s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
23m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 18s

trunk passed

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
26m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
24m 38s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 38s

the patch passed

+1 :green_heart:
compile
21m 55s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 19s

the patch passed

+1 :green_heart:
mvnsite
1m 50s

the patch passed

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 56s

the patch passed

+1 :green_heart:
shadedclient
26m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 33s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  9s

The patch does not generate ASF License warnings.

230m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4832

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9d57e012e6e5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1fc7c8f5198e846f3a48ee95df1132a8a8c3c1b7

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

broken_heart -1 overall
Vote	Subsystem	Runtime	Logfile	Comment
+0 	reexec	0m 54s		Docker mode activated.
_ Prechecks _
+1 	dupname	0m 0s		No case conflicting files found.
+0 	codespell	0m 0s		codespell was not available.
+0 	detsecrets	0m 1s		detect-secrets was not available.
+1 	@author	0m 0s		The patch does not contain any @author tags.
-1 	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 	mvninstall	41m 25s		trunk passed
+1 	compile	25m 22s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>
+1 	compile	23m 33s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 	checkstyle	1m 48s		trunk passed
+1 	mvnsite	2m 18s		trunk passed
+1 	javadoc	1m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>
+1 	javadoc	1m 8s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 	spotbugs	3m 27s		trunk passed
+1 	shadedclient	26m 51s		branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 	mvninstall	1m 5s		the patch passed
+1 	compile	24m 38s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>
+1 	javac	24m 38s		the patch passed
+1 	compile	21m 55s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 	javac	21m 55s		the patch passed
+1 	blanks	0m 0s		The patch has no blanks issues.
+1 	checkstyle	1m 19s		the patch passed
+1 	mvnsite	1m 50s		the patch passed
+1 	javadoc	1m 16s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>
+1 	javadoc	0m 58s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 	spotbugs	2m 56s		the patch passed
+1 	shadedclient	26m 12s		patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 	unit	18m 33s		hadoop-common in the patch passed.
+1 	asflicense	1m 9s		The patch does not generate ASF License warnings.
230m 13s
Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/artifact/out/Dockerfile
GITHUB PR	#4832
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 9d57e012e6e5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 1fc7c8f
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/testReport/
Max. process+thread count	3144 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org
This message was automatically generated.

org.apache.hadoop.ipc.TestCallerContext.testBuilderAppend() already covers this commit

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 39s

Maven dependency ordering for branch

+1 :green_heart:
shadedclient
40m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
shadedclient
22m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

67m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4832

Optional Tests
dupname asflicense

uname
Linux 452327bc2378 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aac87ffe76451c2fd535350b7aefb384e2be6241

Max. process+thread count
533 (vs. ulimit of 5500)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4832/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


System Reboot

Hi.
In QGC, I can reboot the fight controller from the Parameters tab->Tools menu.
Is there a method in the SDK to reboot a system?
If not, I may give it a try in send a PR.
I guess MAV_CMD_PREFLIGHT_REBOOT_SHUTDOWN would be used, but have not checked yet.
Thanks.

I think that is the correct mavlink command, and no, I do not think that we have implemented it. I think it would be useful as an Action.

For anyone reading and is interested in contributing, as @hamishwillee mentions this functionality would be great in the Action class, here's a link to the Action Implementation class, sending a message is a breeze with the SDK plugins/action/action_impl.cpp@ActionImpl:arm


Trim the container image so that it can be pulled within 30 secs

Currently, takes over a minute. Perhaps we need to look at alpine after all.

It's 48 sec now post some optimization such as not doing microdnf update -y and trimming golang a bit. It may be possible to trim further by not including java and related tools such as dependency-check, pmd and findsecbugs.

I have removed pmd and railroader which has further reduced the size to 578.8 MB


Latest nvidia docker

Latest nvidia docker
https://github.com/CPFL/Autoware/issues/660

There is a extra commit for test. So I edited build.sh.


thumbnail selector slider for videos and process automatically for other file types

similar to spee.ch thumbnail slider

From @kauffj: For other file types that we can process/view, we should automatically propose a thumbnail (e.g. when a PDF is uploaded, you could create an image from the first page).
Should we still upload one automatically if the user chooses not to?
Would go nicely with https://github.com/lbryio/lbry-desktop/issues/1968 and being able to crop/resize the thumbnail before it's uploaded (or maybe with some parameters on thumbnail url?)

Completed in https://github.com/lbryio/lbry-desktop/pull/2492


Display profit/loss for individual items

Wonderfull. Looks very good. :+1:  I will check this in next time.


make an element to wrap https://websocialshare.com with state

This way theme developers would have to write just like site-share-page or something like that and it would automatically be set to leverage the store based on page we're on as well as the web share api (experimental) with fallbacks.

should make a video showing this in the context of using another element + encapsulating state cause this is really useful for others to see, especially as we come up on https://hax.camp

See https://stenciljs.com/docs/vue for how to do it


Option for shared x-Axis on multiple timeseries.

Is your feature request related to a problem? Please describe.
Szenario: Labeling multiple timeseries.
When zoomin into one timeseries the zoom is not getting applied to all/or other channels of different timeseries. Currently zooming is only synced per default of channels of the same timeseries.
Describe the solution you'd like
It would be great to have a "shared X-Axis"-option/parameter which can be defined in the "View" definition and links timeseries that shall share a common x-Axis.
Describe alternatives you've considered
Enabling the shared-X-Axis option in labeling interface.
Additional context
Check out current zoom on playground -> Advanced templates -> relation between channels -> try zoom
https://labelstud.io/playground/

related: https://label-studio.slack.com/archives/C01SKFX54QK/p1658143831561989


add gap fill into munge_noaa_nerr

added gap filling function into munge_noaa_nerr
added zipfile path (".\01_fetch\in\953860.zip") into snakemake rule fetch_noaa_nerrs
updated environment

resolved environment conflicts manually


Remove References from Unrelated Components

I would appreciate some feedback about the ideas I mention below and some of the solutions the commits tied to this ticket propose.
The App/Controller Idea
Originally the MapView class was called something like DncApp and it's general purpose was to glue and setup things:

setup and bind components being used in DNC, like the map
setup component event listeners, like for FileReader event handlers
it was a place for slim applciation logic, but not component specific stuff

When we decided that MapView felt like it was it's own component, things got shuffled around and some glue stuff didn't make sense to have in that class anymore.
I've noticed that some of the glue logic was moved out into L.DNC where it currently lives. My guess is that we can expect that glue to grow in the future. L.DNC really feels like a simple namespace object for things to hang off, but not it's own class. Maybe that's just me.
More importantly, another side effect of the refactor was the propagation of some patterns that I feel like we should avoid:

FileReader now reaches outside of it's scope globally to access other components here.
The TurfOperation also reaches outside of it's scope to add layers here.
Even more confusing, the FileReader component fires an event that it itself listens to here.

Proposal
It feels like we need a thing that does the glueing and setup again. This thing, lets call it a controller, would also hold component references so we don't force components that shouldn't know about each other to tightly reference each other.
What Changed?

I managed to remove all these type of references except one, which I flagged as a possible removal later.
For lack of a better term ( i'm open to anything ), I called the controller AppController. See the class here.

Interesting thoughts, will look more into the proposals soon.  Out of curiosity, why is this an Issue? Maybe we should just close this and move it all into the Pull Request?  I typically think of Issues as TODOs.

I can do that. I write issues for every PR, it's just my thang


Could not load the bindings file

Hi,
I have tried installing sapnwrfc in my linux 64 bit machine. But I am not able to install it. I have got the SAP SDK file of version 7.20 and also I copied the files from "lib" folder to /usr/lib and "include" folder to /usr/include. Then I tried to install module using "npm install sapnwrfc".  But I got the below given error. Please help me to fix this issue:
npm http GET https://registry.npmjs.org/sapnwrfc
npm http 304 https://registry.npmjs.org/sapnwrfc
npm http GET https://registry.npmjs.org/bindings/0.3.0
npm http 304 https://registry.npmjs.org/bindings/0.3.0

<EMAIL_ADDRESS>install /usr/node_modules/sapnwrfc
node preinstall.js

{ [Error: Could not load the bindings file. Tried:
-> /usr/node_modules/sapnwrfc/build/Debug/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/build/Release/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/out/Debug/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/Debug/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/out/Release/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/Release/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/build/default/sapnwrfc.node
-> /usr/node_modules/sapnwrfc/compiled/0.10/linux/x64/sapnwrfc.node]
tries:
[ '/usr/node_modules/sapnwrfc/build/Debug/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/build/Release/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/out/Debug/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/Debug/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/out/Release/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/Release/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/build/default/sapnwrfc.node',
'/usr/node_modules/sapnwrfc/compiled/0.10/linux/x64/sapnwrfc.node' ] }
error a precompiled module could not be found or loaded
info trying to compile it...
make: Entering directory /usr/node_modules/sapnwrfc/build'   CXX(target) Release/obj.target/sapnwrfc/src/binding.o   CXX(target) Release/obj.target/sapnwrfc/src/Connection.o   CXX(target) Release/obj.target/sapnwrfc/src/Function.o ../src/Function.cc: In member function âv8::Handle<v8::Value> Function::NumToExternal(CHND, const SAP_UC*, v8::Handle<v8::Value>, unsigned int)â: ../src/Function.cc:538:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]    if (valueU16.length() > len) {                            ^ ../src/Function.cc: In member function âv8::Handle<v8::Value> Function::CharToExternal(CHND, const SAP_UC*, v8::Handle<v8::Value>, unsigned int)â: ../src/Function.cc:561:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]    if (valueU16.length() > len) {                            ^ ../src/Function.cc: In member function âv8::Handle<v8::Value> Function::ByteToExternal(CHND, const SAP_UC*, v8::Handle<v8::Value>, unsigned int)â: ../src/Function.cc:584:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]    if (valueAscii.length() > len) {                              ^   SOLINK(target) Release/obj.target/sapnwrfc.node /usr/bin/ld: cannot find -lsapnwrfc /usr/bin/ld: cannot find -lsapucum collect2: error: ld returned 1 exit status make: *** [Release/obj.target/sapnwrfc.node] Error 1 make: Leaving directory /usr/node_modules/sapnwrfc/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:789:12)
gyp ERR! System Linux 3.13.0-48-generic
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/node_modules/sapnwrfc
gyp ERR! node -v v0.10.20
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok
<EMAIL_ADDRESS>node_modules/sapnwrfc
âââ<EMAIL_ADDRESS>

If node is 64-bit I think you have to copy the SAP libs to /usr/lib64.
I use another way to compile it. It is explained here https://github.com/jdorner/node-sapnwrfc/pull/7 .

Installing the libs to /usr/lib and includes to /usr/include works fine for me in a Docker container, also 64bit Linux.
Perhaps your system needs a  sudo ldconfig to find the new libs.

I tried both of the options i.e. putting SAP libs to /usr/lib64 and /usr/lib.
But I am getting below error
><EMAIL_ADDRESS>install /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc
> node preinstall.js

{ [Error: Could not locate the bindings file. Tried:
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/Debug/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/Release/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/out/Debug/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/Debug/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/out/Release/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/Release/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/default/sapnwrfc.node
 → /home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/compiled/0.12/linux/x64/sapnwrfc.node]
  tries:
   [ '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/Debug/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/Release/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/out/Debug/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/Debug/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/out/Release/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/Release/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build/default/sapnwrfc.node',
     '/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/compiled/0.12/linux/x64/sapnwrfc.node' ] }
error a precompiled module could not be found or loaded
info trying to compile it...
make: Entering directory `/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build'
  CXX(target) Release/obj.target/sapnwrfc/src/binding.o
  CXX(target) Release/obj.target/sapnwrfc/src/Connection.o
  CXX(target) Release/obj.target/sapnwrfc/src/Function.o
  SOLINK(target) Release/obj.target/sapnwrfc.node
  COPY Release/sapnwrfc.node
make: Leaving directory `/home/pratik/Projects/Kinvey/source/SAPConnector/node_modules/sapnwrfc/build'
<EMAIL_ADDRESS>node_modules/sapnwrfc
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

@pRatikSathaye the build steps seems normal to me. The preinstall.js does not find a precompiled binding as you use Node 0.12. Then it compiles it. The module should be usable afterwards.
You can use Node 4 or 5 to suppress this compilation step as the npm module has precompiled bindings for these versions.

Yes, I am able to use the module.
Thanks @StefanScherer

I got node 4.2.4 and still having the same problem.

actually, Im getting now this:
C:\Hikmet\300\server\node_modules\sapnwrfc>if not defined npm_config_node_gyp (n
ode "C:\Program Files (x86)\nodejs\node_modules\npm\bin\node-gyp-bin\....\node
_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build,
please add the "/m" switch.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targ
ets(356,5): error MSB6006: "CL.exe" exited with code -1073741515.  System Windows_NT 6.1.7601
gyp ERR! command "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files
(x86)\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "reb
uild"
gyp ERR! cwd C:\Hikmet\300\server\node_modules\sapnwrfc
gyp ERR! node -v v4.2.4
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
<EMAIL_ADDRESS>node_modules\sapnwrfc
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>


DBZ-3951 Adding a safety check, isValid, for connection failure (incremental snapshot)

Context:
At-times facing com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure" exception
Steps to reproduce:

Start an incremental snapshot and let it finish
Try the same snapshot after sometime (~30 mins)
Getting "{{com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure" exception}}

Solution
Adding a safety check, isValid, to check if the connection object is valid.

Hey @vivekwassan, can you confirm whether the Postgres connector tests pass with this change locally for you?

Hey @vivekwassan, can you confirm whether the Postgres connector tests pass with this change locally for you?

@gunnarmorling On local, when I run
mvn clean install -B -pl debezium-connector-postgres -am -Passembly,wal2json-decoder -Ddebezium.test.records.waittime=5 -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120

Test does not pass and it gets stuck as following and nothing happens

Hi @gunnarmorling 👋 , as Postgres connector tests are failing (unsure of the reason) and inspired from your comment, I added a separate isValid() in my latest commit.
Calling this method only for mysql flow.
Could you share your opinion?
cc @jpechane

@vivekwassan Hi, would the same problem be present also for SignalBasedIncrementalSnapshotChangeEventSource?

@vivekwassan Hi, would the same problem be present also for SignalBasedIncrementalSnapshotChangeEventSource?

Hi @jpechane 👋 , Good point! My team, at Shopify, is using Mysql read-only incremental snapshot only, so we faced connection failure in the flow of MySqlReadOnlyIncrementalSnapshotChangeEventSource only.
Now I feel, it might be occurring for SignalBasedIncrementalSnapshotChangeEventSource as it similarly uses MySqlConnection.
So, moved check for isValid in AbstractIncrementalSnapshotChangeEventSource.

@vivekwassan Applied, thanks.


forge:books tag does not seem to allow books into the bookshelf

https://github.com/mrh0/buildersaddition/blob/ff64d85dde43171fb7f5181bd46ed4ec1d1df060/src/main/java/com/mrh0/buildersaddition/util/Util.java#L23
I've got Tinker's Construct 3 installed and the books (all have the forge:books tag) will not slot into the bookshelf (except for materials and you which there is an exception for).
I believe the problem is in the initialization of the tag (https://github.com/mrh0/buildersaddition/blob/ff64d85dde43171fb7f5181bd46ed4ec1d1df060/src/main/java/com/mrh0/buildersaddition/util/Util.java#L21)
I've had to change my tag initializations to be on demand, as when the static variable is initialized the tag has not been initialized yet.
BuildersAddition v20210517a
TConstruct <IP_ADDRESS>5
Forge 36.2.2

Fixed in 20211016a.


Passing falsy payload values to OPCUA-IIoT-Node does not work

Problem
bug report
Information
Current behaviour

Passing a falsy value (e.g. 0.0) to a OPCUA-IIoT-Node node will result wrong output messages. (NaN, empty strings)
The value of messages overrides the Value setting

Expected behaviour

Falsy values should be handled/passed "normal" values
The Value should override the message payload as the documentation says. ("It overrides the given payload if it is not null.")

Minimal reproduction of the problem with instructions

Inject a falsy value ("" / 0.0 / 0 / false) to a node of type OPCUA-IIoT-Node
Inject a arbitrary value to OPCUA-IIoT-Node, when this node has a valid "Value" setting

Your Environment

I have installed node-red-contrib-iiot-opcua
/node-opcua via Node-RED palette manager
Linux, Debian Stretch (9.6)
Node-RED version 0.9.15
node.js version v10.13.0

Possible solution
I think the problem is located here.
Changing the line from
msg.payload || node.value

to
node.value === "" : msg.payload : node.value

should solve the main issue.
Hint: This solution would not allow an empty string as "Value" setting. Not sure if this would be a big issue.
Thanks

moved to https://github.com/BiancoRoyal/node-red-contrib-iiot-opcua/issues/1


[release-1.0] Manual cherry-pick of 10058

Manual backport of https://github.com/kubevirt/kubevirt/pull/10058
What this PR does / why we need it:
For correctly deploying Windows Shared Cluster Filesystem, we need to be able to configure the error policy to report.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2249846
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Release note:

Add field errorPolicy for disks

/cc @akalenyu @mhenriks

looks good, any special conflicts we should pay attention to? or was this the only pain point? https://github.com/kubevirt/kubevirt/compare/e43f686fb602d732e02940a4dfb6d4c179cfacfe..2475468b37e8a79f1557a95b80098e5f6348d8b3

looks good, any special conflicts we should pay attention to? or was this the only pain point? https://github.com/kubevirt/kubevirt/compare/e43f686fb602d732e02940a4dfb6d4c179cfacfe..2475468b37e8a79f1557a95b80098e5f6348d8b3

not really, only that function was refactored between this feature and the 1.o release

/hold
we need to clarify if this is an acceptable backport

/test pull-kubevirt-e2e-kind-1.25-vgpu

/test pull-kubevirt-e2e-kind-1.25-vgpu-1.0

From the discussion https://github.com/kubevirt/kubevirt/pull/10736#discussion_r1395635043, this seems the more preferable way to proceed with the setting of the error policy for Windows, I'm upholding as consequences of the discussion
/unhold

BTW, as we now have sig-api regular meetings, maybe makes sense to bring this up there?

Follow-up of the discussion: #10736 (comment)
This backport PR changes the API. However, it does not break compatibility, as it only brings new fields and constants. The alternative solution to later backport #10736 introduces a change in the default behavior.
From my perspective, this PR is a better alternative. The only issue I see is the downgrade path. If we want to support downgrades e.g. between patch versions (e.g. 1.1.1 -> 1.1.0) the code here may break migration of running workloads. If this is not a big concern for the project, I think we shall go with it. Other thoughts?

We officially don't support downgrades. There are no tests for it as of now and I did not hear an interest in supporting it for now.

/approve

+1 fwiw :)

Thanks everyone for the quick help!


Update "cross compiling the standard crates" section

See this post for updates.

You could also just use cargo build --release --target <target> in src/rustc/std_shim. You do need to figure out yourself what the correct features are to pass for your platform (jemalloc, debug-jemalloc, and/or backtrace).


Reuse with Elasticsearch

Is it possible to reuse some of the features in this repo such as the dashboards/visualizations on Elastic's elasticsearch.

Hi @kaykhan yes you can do that or refer to this solution. TY!


"Export compliance"

Document scripts/ and tools/ directories.
Here we include some short READMEs to ensure users are very clear that things
in tools/ shouldn't be used in production installs, even though we include
it in the release tarball. (See issue #129 for details)
Include assets, static, tools, and tests in export.
Historically, we've wanted to exclude tools/ and things like our test
framework in voyager tarballs. However, doing so also has the side effect of
excluding those folders from the tarballs generated by GitHub in release tags.
While we could do something fancy for our "compiled" releases, it isn't a huge
problem if our released tarballs are slightly bigger as a result of this
change.
Fixes #129.

Automated message from Dropbox CLA bot
@lfaraone, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here and update the thread so we can consider merging your code.

Hold off on reviewing this, if you would. The resultant tarball here is 16MiB; I'm curious if I can slim that down.

I'm a little worried about putting tools/ into the releases, because users may try to run scripts from there which aren't intended or safe to run in a production environment...
@lfaraone to make progress on this PR, what do you think about converting the new READMEs to markdown and merging that part?  That at least seems like a clear improvement.

@lfaraone I merged 747f66bfe18003c55118398b94dd2c1255fbbb32 to add the README files; I think the rest will likely need to be redone if we wanted to do it today, so I'm closing this.


.gitignoring file called 'changes' that's produced and consumed by goreleaser

This entry was removed from the .gitignore recently, but it needs to be there for the release process to finish w/o errors.
We create the file here: https://github.com/k8gb-io/k8gb/blob/master/.github/workflows/release.yaml#L27
and consume it within the same action couple of steps later here: https://github.com/k8gb-io/k8gb/blob/master/.github/workflows/release.yaml#L49
But if it's not ignored, the goreleaser fails on this issue: https://github.com/k8gb-io/k8gb/runs/4372363917?check_suite_focus=true#step:8:23
because the git is in dirty state (there are untracked files). Other workaround would be copying that file somewhere else on that filesystem, but it's imho better to .gitignore it as it was before.
Signed-off-by: Jirka Kremser<EMAIL_ADDRESS>

upgrade testing will be failing until the release is not reverted (the 0.8.5 tag is there in the git repo, but container image is not there on dockerhub)


Set up Poetry for dependency management.

Let's use Poetry for dependency management in this application, since we're planning on pushing it to PyPI as well.

This has been implemented.


"leaked IntentReceiver com.couchbase.lite.android.AndroidNetworkReachabilityManager$ConnectivityBroadcastReceiver"

"leaked IntentReceiver com.couchbase.lite.android.AndroidNetworkReachabilityManager$ConnectivityBroadcastReceiver"
Getting this exception in android even though I have closed the manager and removed listeners for replications
@Override
protected void onDestroy() {
super.onDestroy();
if(pushReplication!=null) {
pushReplication.removeChangeListener(this);
pushReplication.stop();
}
if(manager!=null)
manager.close();
}

Yes, this is happening to us too.

Hi @ashwinbhaskar and @Takhion
Thank you for your bug report. Could you please more detailed information? It is ideal if you can provide us information which us explained in following doc.
https://github.com/couchbase/couchbase-lite-android/blob/master/CONTRIBUTING.md

@hideki this time I have no idea when or why it happens, it just happens a lot!

@hideki  : I am using Couchbase Android Lite - 1..0.4 . Stacktrace :-
 8060-8060/com.xxxx.xxxx E/ActivityThread﹕ Activity com.xxxx.xxxx.activities.ListingActivity has leaked IntentReceiver com.couchbase.lite.android.AndroidNetworkReachabilityManager$ConnectivityBroadcastReceiver@10ac1bd that was originally registered here. Are you missing a call to unregisterReceiver()?
    android.app.IntentReceiverLeaked: Activity com.xxxx.xxxx.activities.ListingActivity has leaked IntentReceiver com.couchbase.lite.android.AndroidNetworkReachabilityManager$ConnectivityBroadcastReceiver@10ac1bd that was originally registered here. Are you missing a call to unregisterReceiver()?
            at android.app.LoadedApk$ReceiverDispatcher.<init>(LoadedApk.java:907)
            at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:708)
            at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1771)
            at android.app.ContextImpl.registerReceiver(ContextImpl.java:1751)
            at android.app.ContextImpl.registerReceiver(ContextImpl.java:1745)
            at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:488)
            at com.couchbase.lite.android.AndroidNetworkReachabilityManager.startListening(AndroidNetworkReachabilityManager.java:50)
            at com.couchbase.lite.NetworkReachabilityManager.addNetworkReachabilityListener(NetworkReachabilityManager.java:26)
            at com.couchbase.lite.replicator.ReplicationInternal.initNetworkReachabilityManager(ReplicationInternal.java:299)
            at com.couchbase.lite.replicator.ReplicationInternal.start(ReplicationInternal.java:239)
            at com.couchbase.lite.replicator.ReplicationInternal$11.doIt(ReplicationInternal.java:1073)
            at com.couchbase.lite.replicator.ReplicationInternal$11.doIt(ReplicationInternal.java:1069)
            at com.github.oxo42.stateless4j.StateConfiguration$3.doIt(StateConfiguration.java:135)
            at com.github.oxo42.stateless4j.StateConfiguration$3.doIt(StateConfiguration.java:133)
            at com.github.oxo42.stateless4j.StateRepresentation.executeEntryActions(StateRepresentation.java:118)
            at com.github.oxo42.stateless4j.StateRepresentation.enter(StateRepresentation.java:97)
            at com.github.oxo42.stateless4j.StateMachine.publicFire(StateMachine.java:199)
            at com.github.oxo42.stateless4j.StateMachine.fire(StateMachine.java:126)
            at com.couchbase.lite.replicator.ReplicationInternal$1.run(ReplicationInternal.java:191)
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
            at java.util.concurrent.FutureTask.run(FutureTask.java:237)
            at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
            at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:818)

This is the code where I am creating database.
public void createDatabase() throws Exception {
        Manager manager;
        Manager.enableLogging(TAG, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG_SYNC_ASYNC_TASK, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG_SYNC, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG_QUERY, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG_VIEW, com.couchbase.lite.util.Log.VERBOSE);
        Manager.enableLogging(com.couchbase.lite.util.Log.TAG_DATABASE, com.couchbase.lite.util.Log.VERBOSE);
        try {
            manager = new Manager(new AndroidContext(this), Manager.DEFAULT_OPTIONS);
            com.couchbase.lite.util.Log.d(TAG, "Manager created");
        } catch (IOException e) {
            com.couchbase.lite.util.Log.e(TAG, "Cannot create manager object");
            return;
        }

        if (!Manager.isValidDatabaseName(dbname)) {
            com.couchbase.lite.util.Log.e(TAG, "Bad database name");
            return;
        }

        try {
            database = manager.getDatabase(dbname);
            com.couchbase.lite.util.Log.d(TAG, "Database created");
        } catch (CouchbaseLiteException e) {
            com.couchbase.lite.util.Log.e(TAG, "Cannot get database");
            return;
        }

        startSync();
    }

**And removing listeners and closing DB. **
 @Override
    protected void onDestroy() {
        super.onDestroy();
        if(pushReplication!=null) {
            pushReplication.removeChangeListener(this);
            pushReplication.stop();
        }
        if(manager!=null)
            manager.close();
    }

Let me know if you need any other details.

@hideki it might be worth trying to reproduce this via testing todolite.  Maybe the exception is in the logs, but nobody is noticiting.  @pasin added Crashlytics support I believe, that may help finding these kinds of exceptions easier.

@hideki  and @tleyden I have given you the full stack trace.  Is there anyway else I can be of help?

@ashwinbhaskar I will look into this issue during this week. Thanks for your patience.

Hi @ashwinbhaskar and @Takhion
So far, I could not reproduce this issue.
From stack trace and source code, CBL calls [registerReceiver](http://developer.android.com/reference/android/content/ContextWrapper.html#registerReceiver(android.content.BroadcastReceiver, android.content.IntentFilter)) when the replicator starts. From stacktrace, it seems that registerReceiver() is called multiple times without calling unregiserReceiver(). unregisterReceiver is called in Manager.close() method, which is not automatically called.
Some questions:

Does your app creates multiple Manager instances? For example, Manager per Activity.
Does your app creates multiple Replicators? For example, app has multiple databases, and replicator per database?
What is your Android SDK version?

Please share us if you found any observations.

Hi @ashwinbhaskar and @Takhion
How many Activity does your app have?

Single Activity:
According to the post of stackoverflow, unregisterReceiver(receiver) should be called in onStop() of Activity life cycle. See Activity Life Cycle. In stead of onDestroy(), please stop replicator and call Manager.close() in onStop() method.

Multiple Activities:
We recommends Manager instance should be single instance per application. Could you please make sure Manager instance is hold in Application and given ApplicationContext as Manager constructor parameter. see below

manager = new Manager(new AndroidContext(getApplicationContext()), Manager.DEFAULT_OPTIONS);

According to Android document Tasks and Back Stack, Activities in BackStack could be destroyed if there is memory issue.

When the system stops one of your activities (such as when a new activity starts or the task moves to the background), the system might destroy that activity completely if it needs to recover system memory. When this happens, information about the activity state is lost. If this happens, the system still knows that the activity has a place in the back stack, but when the activity is brought to the top of the stack the system must recreate it (rather than resume it). In order to avoid losing the user's work, you should proactively retain it by implementing the onSaveInstanceState() callback methods in your activity.

Please let us know if this solves leaked IntentReceiver  issue.

@hideki we only create a single Manager instance with the Application Context the first time that data is needed anywhere in the app, and then never close it. We started noticing the aforementioned error while experimenting with replications, in particular while creating 2 of them at the same time (continuous push/pull). SDK version is 21 (Lollipop).

@Takhion thanks for additional information.
Our demo application, ToDoLite Andorid, also creates pull and push replicators with continuous mode, but it creates and starts replicators in Application instance. I tried to reproduce "leaked IntentReceiver" issue with using it. So far, I could not reproduce it.
When you have time, could you please compare the difference between your app and ToDoLite demo app? It might give us hints.
Thanks for all your helps!

Currently we can not reproduce this issue, so put this ticket in backlog. We will keep our eye open for this issue.


view story cache in topics throws an error

ownprops.params.stories_id is for some reason resulting in api/stories/undefined although the URL contains storiesId. fine in admin menu

-route is :storiesId

#1477 is handling this


A user can create a job without picking an environment and things crash

Description
By default, there is no environment selected. If a user creates a job without first selecting an environment, no validation error shows, the job fails to create, and the panel becomes empty.
Reproduce

Create a job on a system with multiple environments.
Don't pick an environment.
Create the job.
Panel becomes empty..

Expected behavior
A validation error should show below the environment picker if one is not selected, and we should block job creation until they select one.

As discussed earlier today: we should select the first environment by default, as we do with compute types (in the absence of a default c.t.). Submitting with no environment selected is not a good idea.


'PolygonIO' has no effect

Installed via composer and getting the following warning:
Warning: The use statement with non-compound name 'PolygonIO' has no effect in /home/ ... .php on line 8
Fatal error: Uncaught Error: Class 'PolygonIO' not found in /home/ ....

Yes I am noticing the same thing, the first warning sign is the requirements for guzzle 6.

@SourceCode the guzzle issue has been resolved and will be released soon.
https://github.com/polygon-io/client-php/issues/8


[Generate Code]Generate Code is not work on v<IP_ADDRESS>98

Insomnia Version: ___v<IP_ADDRESS>98
Operating System: ___mac osx

Details

Unfortunately I cannot reproduce this. Can you provide an export of a minimal workspace used to reproduce this/


Replacing log4j with reload4j can cause NoSuchFieldError

This appears to be an interaction between certain versions of the slf4j-log4j12 library and reload4j. If reload4j is used instead of log4j, then using MDC will cause the following stack trace:
Exception in thread "main" java.lang.NoSuchFieldError: tlm
	at org.apache.log4j.MDCFriend.fixForJava9(MDCFriend.java:11)
	at org.slf4j.impl.Log4jMDCAdapter.<clinit>(Log4jMDCAdapter.java:38)
	at Main.main(Main.java:5)

This was discovered by trying to replace log4j with reload4j in the apache Kafka repository, https://github.com/apache/kafka/blob/6eed7743ff6c0e73d65c09bac2e2ad9586cc56ce/gradle/dependencies.gradle#L174
It only occurs in Java versions above 8. The minimal reproduction can be found here: https://github.com/scott-kirk/reload4j-exception
I know it's slf4j code that's directly causing this, and it is fixed by upgrading slf4j to the latest version, I was just caught off guard by this issue and think it'd be useful to either explicitly say to use the latest version of slf4j or to somehow apply a workaround to avoid needing to also upgrade slf4j.

org.apache.log4j.MDCFriend shipping with slf4j-log4j12 tries to repair log4j1.x MDC on the fly. This reparation fails in modularized applications and in JDK versions 14(?) and later. Since there is no way to salvage log4j 1.2.x MDC implementation without recompiling the library, slf4j-reload4j is the only alternative to slf4j-log4j12.

Thanks for the response and the explanation. The link you provided is useful, but could you elaborate on The same identical exception is thrown if slf4j-log4j and log4j 1.2.17 are on the classpath? In my repo with the reproduction if I edit the gradle file and comment out reload4j and uncomment log4j there's no error thrown so I don't seem to have the behavior described. It's an easy enough fix to just upgrade slf4j but I suppose I'm just wondering why the docs say it has more to do with the jdk version when in my repo there's no error when using log4j.

You are right. When I create the classpath manually, the behaviors are different when run with log4j.jar and reload4j.jar. Now that I think of it, this actually makes sense, since the field type of tlm was changed from Object (log4j) to ThreadLocal (reload4j).

This could be just an interaction with the specific versions I'm using, but I just want to make sure we're on the same page

No, mystery solved. I'll update the docs again (tomorrow).

Fixed in 0cbed4256a and dc3cc1f24

Reload4j version
slf4j-reload4j version
slf4j-log4j12 version
result

1.2.20
17.33
absent
OK

1.2.20
absent
1.7.30
exception

1.2.21
17.33
absent
OK

1.2.21
absent
1.7.30
OK

Exception in thread "main" java.lang.NoSuchFieldError: tlm
        at org.apache.log4j.MDCFriend.fixForJava9(MDCFriend.java:11)
        at org.slf4j.impl.Log4jMDCAdapter.<clinit>(Log4jMDCAdapter.java:38)
        at org.slf4j.impl.StaticMDCBinder.getMDCA(StaticMDCBinder.java:59)
        at org.slf4j.MDC.bwCompatibleGetMDCAdapterFromBinder(MDC.java:99)
        at org.slf4j.MDC.<clinit>(MDC.java:108)

@ceki As you indicated in your last message, this backward compatibility problem was fixed in commits https://github.com/qos-ch/reload4j/commit/0cbed4256a40a9e30e2157997cd137fae50f4c57 and https://github.com/qos-ch/reload4j/commit/dc3cc1f245c0cab397ccdf0bf2a416b53b9cee98 .
Version 1.2.21 including those commit has been released.
Therefore, I think this issue can be closed. Correct ?


Update index.qmd

Topics Spring 2024
I'm not sure if it is the right way to do it? :)

@Kamhorn you got it!


Re-add renderItem type definition

Internally the SwipeListView component passes a RowMap(see https://github.com/jemise111/react-native-swipe-list-view/blob/e16ad2fd0fc96f5cd645ea4720890c926cd1f0a0/components/SwipeListView.js#L202) but for some reason this line was commented without any explanation. This is still useful for people that are manually implementing SwipeRow, like me.
May sound egoistical but I don't see any negative side effects of having this on.

Thanks @calvinaquino !


Is there a way to make specific changes to the state that don't create an entry in the history?

Hi @WHenderson
There are some changes to the state that I would like not to persist in the history. Is this something that would makes sense to implement?

Hi @banglashi , if you change the 3rd argument to the immerStore you can change what gets stored.
In the case above, simply return immediately when you don't want to store anything.
e.g.

const history = new History();
const enqueueChange = (change) => {
  if (ignore) {
    return;
  }
  else {
    return history.enqueue(change);
  }
}

immerStore(undefined, () => {}, enqueueChange);

Look at History._enqueue for the current implementation if you want to do anything advanced or create your own derived History class.

Hi @WHenderson thanks for your feedback. That works for me.