Fix map

[ ] make the URL for each event clickable see  #53.

[ ] The tiles in the map do not display any more and point instead to this blog post. Make map to show events. See #84

The issues are related, but ... merging them into one issue seems odd. Anyway...
On the topic of the mapquest tiles, this tile server reference is buried in the "Recline" code vendored in this repo.  Looking at "recline" I see the issue has been tackled there: https://github.com/okfn/recline/issues/500  so probably would be solved here by updating Recline (however you do that)

I added my rational for this + this is something that we did in other OKI project. @pwalsh can break it again to two if he wish.

I originally posted this to https://groups.google.com/forum/#!topic/open-data-day/vKqO_dmRKN0, but adding a note here as well:
Can we at Mapbox set you up with a free account to get maps working again on your site? If of interest, we'd also be up for provided comped accounts for the participants in the Hackathon who want to experiment with putting data on a map. Our information can be found at https://www.mapbox.com/. Please reach back out if this is of interest to you and we can help get you up and running.

Great, thanks! This is a community-based project, so if you want to add code to the site with MapBox embedded map, feel free to send us a pull request.

Hey @miles-dev, happy to use mapbox on the ODD site. Any way to read a dataset directly from google sheets on MapBox?

@callmealien - I'm not aware of a path straight from google sheets to Mapbox, but the easiest method to get the data over would be to export it to a csv and then upload it through the front end at https://www.mapbox.com/studio/datasets/. Since the spreadsheet has a lat/lon already in the file, the upload process should auto-pull those points out for you.
Some documentation on the upload process: https://www.mapbox.com/help/uploads/
Some documentation if you want to use the API/curl for the upload:

API docs: https://www.mapbox.com/api-documentation/#uploads
Directions via curl: https://www.mapbox.com/help/upload-curl/

If I come across a way to go directly from google sheets I'll let you know.

@callmealien - As always happens when you post a response, I naturally found the solution to this just a few minutes later. There is an example with code and documentation which can be found here: https://www.mapbox.com/blog/data-driven-style-remote-sources/.
Thanks.

Surely the correct fix to this issue in this repository is to update 'recline'

So, I have a basic map linking to events from a Google Sheet using mapboxgl:

It could stand to look a bit nicer, though.

@danfowler - Looking good! Glad to see it's coming together. If it's helpful and of interest, a guide to styling in Mapbox can be found here: https://www.mapbox.com/help/studio-manual-styles/. It'll walk you through how to use Mapbox Studio to customize the map however you'd like.


Be able to mount secrets from Vault

We need a way for a Bac job to be able to mount in secrets from vault. There could be a few approaches here:

Having secrets/tokens distributed in Bacalhau (a la k8s secrets)
Having credentials on the node to pull in from vault
Having external web call available to get bearer token for vault
Other?

Some additional user experience look at this:
So, here's an example job:
Job:
  APIVersion: V1beta2
  Spec:
    Deal:
      Concurrency: 1
      TargetingMode: true
    EngineSpec:
      Params:
        EnvironmentVariables:
          - INPUTFILE=/var/log/logs_to_process/aperitivo_logs.log.1
          - QUERY=SELECT * FROM log_data WHERE message LIKE '%[SECURITY]%' ORDER BY '@timestamp'
        Image: [docker.io/bacalhauproject/motherduck-log-processor:1.1.6](http://docker.io/bacalhauproject/motherduck-log-processor:1.1.6)
        WorkingDirectory: ""
      Type: docker
    Resources:
      GPU: ""
      Memory: 4gb
    Network:
      Type: Full
    Inputs:
      - Name: file:///var/log/logs_to_process
        SourcePath: /var/log/logs_to_process
        StorageSource: LocalDirectory
        path: /var/log/logs_to_process
      - Name: file:///db/
        SourcePath: /db
        StorageSource: LocalDirectory
        path: /db

Now imagine in there there's a field "SecretManager":
    Secrets:
      - Manager: dmno-vault
        Items:
          SECRET_ONE
          SECRET_TWO

This comes from an object created elsewhere
SecretsManager:
Name: dmno-vault
      URL: https://dmno.io
      TokenName: dmno-reader-token

And we further had a separate command:
bacalhau create service-account secret-reader
bacalhau set secret-token --vault-name dmno-vault --name "dmno-reader-token" --value "m7PZBJKJuYR3kGGrDvIqJp5aDjvtVABGEDMtlSzkdZ7fTXv6dAsFlWvjzTdMzP0G"

With this construction, when the bacalhau job runs, it reads from your vault inline, and mounts these as environment variables in the environment in which the process runs.
cc @wdbaruni for some additional thinking.


Sort by options on Repo listing page

Description
We can add a filter by options on the repo page that would be helpful for users to sort the repos according to the selected filter
Screenshots
No response
Additional information
No response

Hello @sumitunique777 I am changing this to a discussion. Please add some details on what the approach would be and what types of options you think would be meaningful to filter on.

For now we can start with a simple filter and sort:
Filter by:

Stars
Forks

Sort

Stars
Forks

@SaraJaoude do we have any UI design for the filters and sorting?

@SaraJaoude do we have any UI design for the filters and sorting?

@ShubhamSj07 no, but you can reuse existing components.  Here is an example in the Events tab for the dropdown:

I will be changing the label for this Issue to status: ready for dev.  If you do want to work on this please do not forget to request that this is assigned to you before carrying out any work/opening a PR.

@SaraJaoude Cool!
Please assign it to me, I'd like to give it a try

@SaraJaoude Cool!
Please assign it to me, I'd like to give it a try

@ShubhamSj07 I have assigned it to you

Since there has been no activity for more than 2 weeks can you assign this to me.
I would like to work on this issue.

@sital002 I have assigned this to you

Just to be clear I should only add Filter by:
Stars
Forks
because sort feature is already on another issue https://github.com/EddieHubCommunity/BioDrop/issues/8582

@sital002 you are correct, these are duplicates - so I will close this issue and assign the other issue to you - sorry for the confusion
Duplicate of https://github.com/EddieHubCommunity/BioDrop/issues/8582


Enable C++ unit tests on macOS

This is a continuation of #674 where @alanchengrab enabled C++ unit tests on macOS.
Instead of adding another entry to the Makefile I have changed things a bit so that the test can be built and ran through CMake & CTest (thanks @ntadej for the suggestion).
I removed the C++ wrapper around that forks and runs the Node.js server, and instead made a Node.js wrapper that forks to run the test. This approach is more platform indepentent, which will be helpful if we will use the Node.js based HTTP server for tests of other platforms in the future.

hmm @louwers This looks odd:

@ovivoda Yup, I'll have a look.

Thanks for pick this up.
My origin pr runs the server at the root dir because the CPP unit test is not a macOS CPP unit test, just the mbgl-test project of macOS version. So if it's not running at the root dir the resources in the test directory will not be loaded successfully. and that's why the unit test can't pass.
BTW some objects in the macOS targets can't work, the node objects, the test-render-runner.
this unit test is quite like the Run render tests on *,  in node-ci.

@alanchenboy The root dir is still used as working directory, but I just made an out of source build.
As part of #737 I am investigating if we can move more stuff out of the custom Makefile and into CMake.
@ovivoda Turns out I forgot to push a file.

Thanks for working on this! I'll look at it in detail tomorrow.
For reworking the scripts, we may want to wait for platforms reorganisation. I should have a draft of the proposal this weekend.

I'm not sure if the tests are being run:

mbgl-test-runner cost 0.06 seconds I think this means no unit tests runed


Random port is used.

Hey guys, before I create this issue, yes I have already explored and I am aware that this is duplicated from issue #36, but anyway I decided to create another one, apparently it is already stopped, so the problem is this, I have already made the modifications on my current project and apparently it doesn't seem to work, so I decided to use your examples and still I have the same problem, I am available to debug or log whatever.
I also checked to see if there were any of these errors in the SocketCluster Dart Client library, and still no solution. Then later I noticed that it uses a different connection URL, and even then I tested it, and it seems to only recognize "ws" as the IP.
Any more information that is needed to clarify I am here. Any help or attempts are welcome and I appreciate it.

Hi @0rangeFox thanks for this, but I'm going to close this ticket and direct you to #36, since it's the same issue. Please have a read of my explanation there, what you are seeing is not a bug in this library.
Please feel free to reopen if you think you have a different problem.


fix update status when prepare failed

Proposed changes
pick from https://github.com/apache/doris/pull/23419

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


errors about the generating RGB virtual points.

When I run the python3 main.py --detpath ../../data/kitti/semi, it shows the following mistakes:
Traceback (most recent call last):
File "/home/avl1/ck/VirConv/tools/PENet/main.py", line 482, in
main()
File "/home/avl1/ck/VirConv/tools/PENet/main.py", line 394, in main
iterate("test_completion", args, test_loader, model, None, logger, 0)
File "/home/avl1/ck/VirConv/tools/PENet/main.py", line 266, in iterate
vis_utils.save_depth_as_points(pred, i, args.detpath)
File "/home/avl1/ck/VirConv/tools/PENet/vis_utils.py", line 150, in save_depth_as_points
final_points = depth2pointsrgbp(depth, image, calib, lidar)
File "/home/avl1/ck/VirConv/tools/PENet/dataloaders/my_loader.py", line 403, in depth2pointsrgbp
new_p = la_sampling2(new_p)
File "/home/avl1/ck/VirConv/tools/PENet/dataloaders/my_loader.py", line 251, in la_sampling2
return np.concatenate([finals[:, 8:11], finals[:, 3:8]], -1)
IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

Hello,
Have you resolved the issue?
If so, could you please share the solution?

I am sharing information that might be helpful to you. I resolved the issue by using the original calib.txt file from the KITTI dataset. After replacing everything with the original calib.txt data, the code ran without any issues. I hope this information helps.

Hello, I have just started working on this project. I have tried configuring the environment using this readme on both VSCode and Psycharm in the early stages, but many errors have occurred. I am currently unsure how to proceed further. Can you help me?


Zinc should detect shadowing classes from binary deps by classes from ext deps

During implementation of https://github.com/sbt/zinc/pull/165 I noticed that if I have project (proj1) with classpath Seq(scalaJars, proj1_out, proj2_out, jar1.jar) and jar1.jar contains class foo.Bar and I create class foo.Bar (I know I shouldn't :) ) in proj2_out then zinc will not recompile any sources from proj1 that reference to foo.Bar (but it should).
Other way (change from ext to binary) is (was) supported but is slows down searching for changed classes (see https://github.com/sbt/zinc/pull/165 for more details).

We are creating unit tests for this - PR will be created soon

Other way (change from ext to binary) is (was) supported but is slows down searching for changed classes (see #165 for more details).

What does this mean? Does the "other way" refer to behavior before #165 got merged?

Tests added in https://github.com/sbt/zinc/pull/175 clearly shows that is happens only with analysisOnlyExtDepLookup set to true. I am thinking on reverting https://github.com/sbt/zinc/pull/165

Added a test in #179 using actual files, and it seems to be happening without the flag.

So we want correctness in terms of respecting classpath, but we also want to avoid looking up classpath all the time. Suppose we have the following classpath:
lib/scala-library.jar, sub1/target, sub2/target, lib/sample-binary_2.11-0.1.jar

From here I can check whether they have an Analysis associated.
None, Some(a1), Some(a2), None

And then, we can check the last timestamp. Suppose shadowing of a class happened in sub2/target since the last sub1 compilation it would be:
None, Some(t), Some(t + 10s), None

This can prompt the duplication check between sub2/target's product and the lib/sample-binary_2.11-0.1.jar. If no compilation has happened, then it would be:
None, Some(t), Some(t), None

This also allows for bump up of JAR version, which still would be:
None, Some(t), Some(t), None

Can this work?

To detect whether shadowing had effect on sub1, I'd now need to track libraryClassNames: Relation[File, String]. (The relationship named binaryClassName exists for different purpose.)

I think the only thing we have to implement is caching here and knownlage from Analysis here.

Would libraryClassNames track binary dependencies from source files to binary class names?
I think this information is already extracted but not tracked:
def addBinaryDeps(src: File, deps: Iterable[(File, String, Stamp)]) =
    new MRelationsNameHashing(srcProd, binaryDep + (src, deps.map(_._1)), internalDependencies = internalDependencies,
      externalDependencies = externalDependencies, classes, names,
      binaryClassName = binaryClassName)

Notice how only the first element of triple in deps is being used.
Have you considered switching binaryDep to tracking binary class names instead of classpath entries (class files or jars)?

I have, and I kind of assumed the size is going to be pretty large all classes going against scala-library.jar. Wasn't sure if it's worth it for just this purpose.


Keep getting 52004 (Credential SID not specified) and 52131 (Invalid APNs credentials)

Description
Hi, I am new to Web RTC development and trying to implement TwilioVoice into my app.
I am following the tutorial and everything works fine from steps 1 to 6. I have correctly setup a local Java server, a tunnel with ngrok, added TwilioVoice into my iOS app with Cocoapods, created a TwiML app and configured the server. When I simply start a call, I get the congratulations message from the server.
However, almost every time I try to call /placeCall, I get two errors in the dashbord's log, and none of the delegate PKPushRegistry and TWONotification methods get called.

What I don't understand is why it worked a few times first, for like 5 minutes, and now it's not working anymore, no matter what I try.
As you can see, the app seems to correctly register to push notifications :

In order to create the push credentials, I have created a VoIP services certificate for my app from the Apple Developer Center, then added it to the keychain access and exported it to a .p12 file, followed the 8th step to create cert.pem and key.pem, added these values to a APN credentials (pasting all the content including BEGIN/END parts) and ticking the sandbox checkbox, added the credential SID to the server's .env file, added voip and audio to the background modes of my app... and I keep getting these issues.
PS : nothing has been deployed to production, I'm getting these errors in development mode using sandbox mobile push credentials.
Expected Behavior
Catching the notification of an incoming call.
Actual Behavior
Nothing happens client-side although the app correctly registers to Twilio push notifications.
Reproduces How Often
It quickly worked for a few times, then suddenly stopped working.
Versions
All relevant version information for the issue.
Voice iOS SDK
TwilioVoice 2.0.0 with CocoaPods.
Xcode
Version 9.4
iOS Version
Version 11.4
iOS Device
iPhone SE

Hi @StratRob
Sorry that you are experiencing the problem. The error code of the notification delivery failure does seem odd to me but I am happy to help you out.
Can you provide us a call SID when you don't get a incoming call notification?
Just a hunch, but can you also use jwt.io and see if all the values in the Access Token are valid?
Thanks.
-bobie

Hi @bchen-twilio, and thank you for the quick reply.
 I just didn't understand that I had to match the identity alice in order to get /placeCall working fine. I've set alice again and everything is OK now.
However, I am not sure this is the cause of these 52004 and 52131 errors, so if you need a SID here is one : CAa6ac6c1d0295f949faa79e7b698fc2da
Also, I have another question : I was able to follow all the tutorial and connected two devices perfectly. However, when I call another device, the from value of the callInvite in the delegate's callInviteReceived is always client:quick_start instead of the identity of the caller. What can I do to get it instead?
Thanks a lot for your help.

Hi @StratRob
The from value shown in the TVOCallInvite object is basically determined by the callerId of the <Dial> verb in the the TwiML. One thing to keep in mind is that if you want to show alphabetic values, for example client:alice, at the callee side, remember to prefix the value with client:, otherwise the value by default will be dialpad-translated into numerical values.
I've also checked the call SID but still not quite sure what exactly is wrong. Have you tried to mix credentials between accounts? credentials are not shareable even between master and subaccounts.

Hi again, and thank you for your answer.
I have no clue about this credential issue, but hopefully I'm not catching it anymore...
About the from value, I am sorry but I am not sure to understand what's going on. I tried to add a from parameter in the TwilioVoice.call() function, like this:
call = TwilioVoice.call(accessToken,
                        params: ["from": "Test", "to": "Robin"],
                        delegate: strongSelf)

I have tried with and without adding from in twiMLParams, with and without uppercase and using both Bob and client:Bob as the value. No matter what I try, I always catch this result in callInviteReceived() :

(do you want me to create a new issue for this?)
Thanks again for your help!

Hi @StratRob
I am sorry that we probably made the quickstart too simple even to demo this basic functionality. To save you from too much details, let's try this:
  // on mobile client A, generate an access token with identity "bob"
  call = TwilioVoice.call(accessToken,
                        params: ["callee": "Robin"],
                        delegate: strongSelf)

and assuming you are using the python quickstart:
CALLER_ID='client:quick_start'
CALLEE_ID='alice'

def makeCall():
  caller = request.values.get('From', CALLER_ID)
  callee = request.values.get('callee', DEFAULT_CALLEE)
  response = VoiceResponse()
  response.dial(callerId=caller).client(callee)

There are two default arguments that will be embedded in the Voice URL request, From and To, and in your use case we will be needing the From value here. When making a mobile client to mobile client call, this value will be derived (by the Twilio Voice service) from your access token.
You can definitely choose any arbitrary HTTP request parameters other than the capitalized From & To as your custom request params.
cheers
-bobie

Got it now! Thank you again for the explanation and your time.

Any time!


Documentation - Marking Forked Repository Private

In the step-by-step directions, under "On GitHub" step 3 calls for creating a fork, then step 4 (optional) is on marking the forked repo as private.
I just tried this and, in the Danger Zone section, there's a message that states "Public forks can't be made private. Please duplicate the repository."
I've never tried forking a repository before, so this is all new to me. I am going to try the process that GitHub outlines in terms of duplicating a repo but I thought I would bring this to your attention in the event you wanted to add details to your documentation.
Thanks so much for sharing this!!!

Steps to make a private repo and clone the repo and still link:

Create a private repo in your namespace called pihole-cloudsync
git clone --bare https://github.com/stevejenkins/pihole-cloudsync.git
cd pihole-cloudsync
git push --mirror https://github.com//pihole-cloudsync.git
cd ..
rm -rf pihole-cloudsync.git
git clone https://github.com//pihole-cloudsync.git
cd pihole-cloudsync
git remote add fork https://github.com/stevejenkins/pihole-cloudsync.git
git stash ## optional step in case you have any local changes
git merge fork master  ## to update from steve's repository
git stash pop ## optional step to add any changes back in

I'm new to git and trying to get my head around how this works but isnt the requirement to make the 'my-pihole-lists' repo private ? That is the repo that contains custom info for each pihole setup.
The above instructions are for the pihole-cloudsync repo which is where the code resides.

I should have based my original post on https://github.com/stevejenkins/my-pihole-lists (not pihole-cloudsync).
I just went through the process of forking my-pihole-lists to my-pihole-lists-forked, then mirrored from my-pihole-lists-forked to my-pihole-lists. I created a new repository called my-pihole-lists and marked it as "private", then followed the official GitHub documentation on duplicating a repository.
https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/duplicating-a-repository
Additionally - I used SSH key based authentication which required that I go through the initial git configuration process, adding the SSH key to my GitHub profile, as well as adding the SSH key to the keychain on the server running pihole.
The following resources were helpful:
Generating a new SSH key and adding it to the ssh-agent
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent
Adding a new SSH key to your GitHub account
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account
Testing Your SSH Connection
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/testing-your-ssh-connection

I should have based my original post on https://github.com/stevejenkins/my-pihole-lists (not pihole-cloudsync).
I just went through the process of forking my-pihole-lists to my-pihole-lists-forked, then mirrored from my-pihole-lists-forked to my-pihole-lists. I created a new repository called my-pihole-lists and marked it as "private", then followed the official GitHub documentation on duplicating a repository.
https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/duplicating-a-repository
Additionally - I used SSH key based authentication which required that I go through the initial git configuration process, adding the SSH key to my GitHub profile, as well as adding the SSH key to the keychain on the server running pihole.
The following resources were helpful:
Generating a new SSH key and adding it to the ssh-agent
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent
Adding a new SSH key to your GitHub account
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account
Testing Your SSH Connection
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/testing-your-ssh-connection

Marking issue as resolved - provided links to documentation that helped with the process

Marking issue as resolved - provided links to documentation that helped with the process


Fix a couple a new bugs introduced by recent changes

The behavior of --base and --math and other addins library was altered by a4ae53eeaf3f84a6adb2d89f9ec29ca934b4d65d

It was no longer possible to disable all plugins by specifying --base

list option was crashing because the logging was only initialized in run mode.

Codecov Report

Merging #71 into master will increase coverage by 0.01%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage    56.2%   56.21%   +0.01%
==========================================
  Files          65       65
  Lines        4660     4659       -1
==========================================
  Hits         2619     2619
+ Misses       1884     1883       -1
  Partials      157      157

Impacted Files
Coverage Δ

main.go
57.28% <97.56%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a732d...a4d4297. Read the comment docs.


Support for excluding specific actions from table history  via annotations/options

I would like to be able to disable history on certain hooks ( one or two of Create/Update/Delete) for a particular table.
My objective is to prevent the history tables from being populated with create/delete actions but keeping update actions. I'm looking for a way to exclude these actions, ideally through some form of annotation or options.

Hey again @mehmetcuneyit I should be able to implement this pretty easily. Are you looking at this as an option per schema or as a global option?

A hybrid approach seems promising for the long term, but for the near term, I'm leaning towards a per-schema option. Please let me know if there's any way I can assist or contribute to expedite the process.

@mehmetcuneyit PR is up for this, should be in and released today


SRS Review: References

Citations are improper or replaced by "?" marks.

fixed the problem of citations. Thanks!


Feat: add target in maxbyte interceptor

will Fixed: https://github.com/loggie-io/loggie/issues/568


Have Pipeline#call return the command index

This is a cheaper alternative to redis-rb futures.
e.g.
value_index = nil
results = redis.pipelined do |pipeline|
  pipeline.call("SOMETHING") if something?
  value_index = pipeline.call("GET", "key")
end

results[value_index] # => "MyString"

That saves us from allocating a future for every call even though most callers won't use it. Redis::Future is also very error prone.
cc @etiennebarrie, opening a PR because I'm a bit on the fence about the practicality of this API.

Closing this for now, it will be easy enough to implement if we actually see the need for it.


[Translation] Release MicroProfile 6.0  - Release Blog Post Russian Translation

Once third task in #726  about: Draft a release announcement blog post using template (technical person)  is complete, add release blog post in Russian

I'll pick this :)

You are amazing Mitia!!!
Please use https://github.com/eclipse/microprofile-marketing/issues/738 as a guideline on what to do next.
I will add @rstjames so that he can help you close this ticket as he did with Emerson! :)

Oh and if you have questions, @emecas can provide you that support :) Does who do are the best teachers!

@emecas @aeiras I do not see the blog post in Russian...? What should I be doing with this task?

@emecas @aeiras I do not see the blog post in Russian...? What should I be doing with this task?

@dalexandrov  let me know if you need any help publishing the blog post, I will be happy to help, btw do you have access to WordPress already?
CC @rstjames

Does anyone know what the most accurate current status of this is? /cc @rstjames

I do not see this blog post on the MP blog as a draft. What would you like me to pubilsh? @dalexandrov

We will need these things to launch the blog post and social media

link to Doc with blog post
tweet in the blogs language
translation of this image:

Article - https://docs.google.com/document/d/1AWbxZc0TMddbNDkc8C7pz-oTEPvZLw-ZlTlqUKkdIfI/edit#heading=h.m8u18nu3xm0r
Presentation - https://docs.google.com/presentation/d/1GHkeOe3bAbiV2ccsP4WYdnNewAid_VU6/edit?usp=drive_web&ouid=117390839376038774312&rtpof=true

Twitter:
#MicroProfileReleaseAnnouncement: Состоялся релиз #Microprofile версии 6.0
Он поддерживает @JakartaEE 10 Core Profile. 📢 🚀

Узнать больше:

#ByCommunityForCommunity #OpenSource

Picture:
MicroProfie - состоялся релиз версии 6.0!

Done

@rstjames,
Wonderful!
I will re-open this ticket and the other b/c it is helpful to at least add the Twitter post to help with closing the task.
This is part of the new guidelines on how to make Release translations that Mitia wrote, which I still  need to review and for that, all the examples must exist. Thanks!

Tweets are going out next week. there were tweets were already scheduled
this week.
R
On Wed, Apr 19, 2023 at 8:18 PM Amelia Eiras @.***>
wrote:

@rstjames https://github.com/rstjames,
Wonderful!
I will re-open this ticket and the other b/c it is helpful to at least add
the Twitter post to help with closing the task.
This is part of the new guidelines on how to make Release translations
that Mitia wrote, which I still need to review and for that, all the
examples must exist. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/eclipse/microprofile-marketing/issues/736#issuecomment-1515171407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4R6MUTY3VDVCSV4A7QLZTXCAT6XANCNFSM6AAAAAASF4EIBA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Ryan St. James *

@.***
@s8ntjames https://twitter.com/s8ntjames
tomitribe.com
tomitribe.io


Add pytorch demo

This PR aims to add pytorch demo equivalent to the tensorflow one. See https://github.com/mindee/doctr/issues/658.
Question
Should we need also to update something for the live demo ? https://github.com/mindee/doctr#live-demo

Hello everyone :wave:
I agree that having two different apps isn't necessarily the best option. Apart from training scripts (and actually we could also do it for this, but considering the user group, it's not a big deal), everything in docTR is handled with env variables to select the backend.
I would argue it's one of the core strengths of the project: the user doesn't see the difference but under the hood, a lot is done differently. I thought about it a month ago and I figured that the model loading and preprocessing+inference+postprocessing should be conditional on the backend. My suggestion is either:

keep a single script, with conditional statements where it's relevant to perform the operations
move the DL backend dependent ops to another module, and call this from the app.py

The second might sound better, but having a single file for a Streamlit/Gradio app is good advantage. However, this is only my opiniong :man_shrugging: (good news is that we can reuse everything you've done here @odulcy-mindee if we go for any of my suggestions)

@odulcy-mindee @frgfm I think the main problem to solve is to find a good way to handle the different framework specific dependencies (if we dont want to wait until onnx part is done) than we could go in a similar way i have had in mind for #663

@frgfm @felixdittrich92 thanks for your review ! Also thanks for the closed PR linked @felixdittrich92, I haven't seen it before.
I agree with you and the philosophy of the repo: it would be better to put everything in one script named app.py. I'll do a small code refactoring of this demo app.
I'll try to add a drop down menu to select the backend but I'm not sure how it'll behave with Streamlit (increase in RAM for instance). If it does not work, the user will have to set the env variables through the command line as it has been suggested.

I tried to add a drop down menu to select Tensorflow or PyTorch but it turns out that it was a bit ugly to reimport functions from the selected backend at runtime.
Without any specification, it will use TensorFlow backend. You can also select backend using environment variable:
USE_TF=1 streamlit run demo/app.py

Or
USE_TORCH=1 streamlit run demo/app.py

I also added a quick mention of which backend is in used in sidebar:

Hi everyone :wave:
I agree that perhaps we should wait a bit to switch the demo to ONNX. I've done it for other projects and for inference it makes way more sense and deletes a LOT of dependencies, making the minimal environment considerably lighter!
Otherwise, going for the double backend:

on dev side, changing the env variable makes sense
on HF spaces, that won't be possible though.

So either we:

go for separate apps (that complicates things for maintenance though, but it can be temporary)
or we try to plan for a full ONNX + no PT/TF env (that means docTR itself won't be loaded)

Since the demo is a good way to quickly try out a model, I'd say that if we cannot afford to do ONNX right away, we need a way to use PyTorch. So should we go for env vars that select the backend (my favorite option), or separate apps?

My favorite way would definitely be ONNX.
But I think that's still a bit too far away at the moment.
I'm not sure if changing the environment variable during runtime is really that problematic (HF Space), maybe we should try it!?
(If it should work than i think it would be the best option for the moment)

Hi @odulcy-mindee :wave: any updates ? :)

Hello @felixdittrich92 @frgfm,
I think we can keep this implementation as it is: it has the benefit to show how we should do an inference with TensorFlow and PyTorch thanks to load_predictor and forward_image functions.
For HuggingFace, we'll not have the ability to change backend but I think it's not the purpose of it: it's more a toy to play with and to see a concrete application of our app demo.
I'll rebase this branch on main to check that everything is up-to-date

Hi @odulcy-mindee :wave:,
So I think that the deployment as an HF space has a much greater benefit / range than being able to test the demo locally. But yes for the moment I would agree until we are ONNX ready. @frgfm wdyt ?
@odulcy-mindee Can you solve the conflicts please :)

@felixdittrich92 I rebased on main, it should good.
Concerning HuggingFace Space, I don't know how to update the demo :confused: We can swap the script on HF with the TF demo so we'll keep the same behavior as before.

@felixdittrich92 I rebased on main, it should good. Concerning HuggingFace Space, I don't know how to update the demo confused We can swap the script on HF with the TF demo so we'll keep the same behavior as before.

I cannot help without access so you should ask: @charlesmindee or @mehdimindee (https://huggingface.co/mindee)  :+1:


play around with the APIs to find data we need

find() Method

We have accessed all 3 of our API's successfully and have been able to access them and fetch lots of different data.


Can not do the Eval exercises

Hi,
On Cats | Eval, we can not do the exercises, the fields we have to fill are already filed with text (apparently scala types) instead of having html inputs elements.
The related code is this one, however upon looking at it and other files to compare them, I couldn't pin-point the problem, no missing includes and the class is inheriting from the needed ones as in the other exercises.

I think the code is fine but we were unable to deploy a fix: https://github.com/scala-exercises/exercises-cats/issues/134

Hi, still not working.

Hello, stlil not working.

https://github.com/scala-exercises/exercises-cats/pull/127 A PR was merged to fix this years ago. Seems like this site has lost its owners.


[Scene] Add SceneStringNames::confirmed

See also:

https://github.com/godotengine/godot/pull/91939

Rebased on top of item_selected for conflicts

Thanks!

Thank you!


How to extend the configuration in a separate module

My definition has multiple independent modules, each needs only the syntax module. The main module has the configuration defined, but some cells in the configuration are only needed by individual modules that I sometimes choose not to import. Can I append a cell to the configuration in one module?

This feature is under development by @cos  #1873

just a now, the feature is only available on master now and it won't get retrofitted to 3.x releases.

*just a note

OK @cos, now I'm ready to start working on master. Does it include binaries or will I have to compile myself?

afaik, you'll have to compile it yourself. It should work pretty smoothly.


Outdated PlaceholderAPI aggain?

[12:15:19] [Server thread/ERROR]: [PlaceholderAPI] Jobs is currently using a deprecated method to hook into PlaceholderAPI. Placeholders for that plugin no longer work. Please consult [phrstbrn] and urge them to update it ASAP.
The PRoblem was allready annouced here
https://github.com/Zrips/Jobs/issues/413
but was closed..
Info: just took the newest versions on day ago...

Install the dev version from https://github.com/Zrips/Jobs/releases.


Send in addition already posted messages during disconnect

Added ability to update history in case when the Jot server is down for a some time, but the site is online. When the Jot server will start to work, history will be automatically updated.


[WAC] - User with Gateway users rights gets Access Denied at WAC startpage

Gateway Version: 2211 (1.4.2212.08003)
To Reproduce
Steps to reproduce the behavior:

If you open the WAC start page as user with gateway user rights then you get an Access Denied message.

If you change (with gateway user ritghts) the url from https://admincentersite to https://admincentersite/settings/account the site is visable (no Access Denied message)

Changing to the sites "Server Manager", "Computer Management" and "Cluster Manager" is possible, these sites were shown correctly

Changing to site "All connections" or clicking the button "Windows Admin Center" on the left generates the Access Denied message again.

This problem only exists with gateway user rights and since version 1.4.2212.08003.

Same for us, stopped working after last WAC update

Same here - any update?

Hi @cde87, @thesutex and @skiewidt,
I apologize for this frustrating bug, is it still occurring in our latest build?
Kind regards,
Rebecca.

Hi Rebecca,
with the latest build it worked.


fix: prevent component from re-mounting in dev

I used this as a boilerplate for a project at work. Re-rendering the app with DevTools unfortunately causes a somewhat hard to diagnose bug with react-router's confirm navigation API. Since the component tree is re-mounted but the router is not re-instantiated, it was causing a warning about setting multiple leave hooks. Though this repo doesn't use that API, I think it's worth preventing this error in the first place.
While not particularly pretty, adding an extra <div /> when rendering prevents the component from unmounting and re-mounting when <DevTools /> is added.

duplicate #961


Add externalid

Add a column external id to ease search from app creating timer

Hello, albfan. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.


Improve partial range

#computePartialRange now works completely in its "scratch space" object, which it returns for maximum debug transparency
#computePartialRange took over the interval shenanigans that #connecToServiceWorkers used to have to
connection logic is now inline in #refreshServicePeerPartially preparing for future work out of #66
explicit check and error log for pathological case

r @kriskowal @Raynos

legit.

:ok:


[Bug]: I have a problem with my wallet since my funds from the migration from TRINITY Wallet to Firefly Wallet never arrived, I do not have access to them

Issue description
Hello, I have a problem with my wallet since my funds from the migration from TRINITY Wallet to Firefly Wallet never arrived, I do not have access to them, how could you please solve them?
Also when exporting my security seed it cannot be seen.
I appreciate help me.
Att. Robert Eduardo Duarte Gonzalez
Expected behaviour
I thought that at the time of migration my balance would arrive, but it was not like that
Actual behaviour
says your funds will be available shortly and they are not
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue

I go into my wallet
I give you unlock funds
funds do not appear

Diagnostics
Firefly -1.3.3
Idioma: es-LA
Moneda: USD
Selección de nodo: Automático
Plataforma: win32
Versión de la plataforma: 10.0.19043
Arquitectura de la plataforma: x64
Recuento de CPU: 2
Memoria total: 3983.9 MB
Memoria libre: 643.3 MB

Errors
EMPTY

Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello. Can you try to create a new profile and restore it with your 24 words?

I have exactly the same problem.

I tried it with 81 sign and with ledger integration but both failed and my funds were not shown.

@SebKrom  I guess you are refering to something else. You mean that your balance is not found in the migration process?

Yes but isnt that the same Problem with other words?
I'm now afraid that something could happened to my funds. I can no longer access it in the old Trinity wallet either, because it no longer works.

Am 19.03.2022 um 07:43 schrieb MiKeF05 @.***>:

@SebKrom I guess you are refering to something else. You mean that your balance is not found in the migration process?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

No in the issue above the migration was completed but there is a display error.
What's the issue with Trinity? You only can't login?
Try the following, update Trinity to the latest version. Before you open Trinitd disable your internet connection. Then you should be able to login and check where your funds are located.

This way i can see my Funds in the Trinity wallet but how can i migrate?
With ledger it does not work. Firefly is just searching for funds for Hours but cant find.
Kind regards
Sebastian

Am 19.03.2022 um 09:49 schrieb MiKeF05 @.***>:

No in the issue above the migration was completed but there is a display error.
What's the issue with Trinity? You only can't login?
Try the following, update Trinity to the latest version. Before you open Trinitd disable your internet connection. Then you should be able to login and check where your funds are located.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

Your funds are located to the ledger? If you go to view seed in the account in Trinity do you see a 81 char seed? Or does it say the seed phrase can't be exported or displayed?

Oh, ist was the Index. I had Index one. Now it works. Thank you for Support.

Am 19.03.2022 um 22:36 schrieb MiKeF05 @.***>:

Your funds are located to the ledger? If you go to view seed in the account in Trinity do you see a 81 char seed? Or does it say the seed phrase can't be exported or displayed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

Now i have another question. The migration process was successfull and i saw my funds on the Dashboard, but when i closed firefly and started it again it asked me to migrate it asked me to create a new profil. Like i never migrated.
What can i do?
Kind regards
Sebastian

Am 19.03.2022 um 23:05 schrieb Sebastian Kromer @.***>:

Oh, ist was the Index. I had Index one. Now it works. Thank you for Support.

Am 19.03.2022 um 22:36 schrieb MiKeF05 @.***>:

Your funds are located to the ledger? If you go to view seed in the account in Trinity do you see a 81 char seed? Or does it say the seed phrase can't be exported or displayed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

You can create a new profile and recover your wallet using the option hardware wallet and Firefly ledger backup.


VDC: master node died then redeployed on another pool without IPV4 units

The pool with ipv4 units is freefarm which has the master
the master died
should be redeployed in the same pool
it was deployed on another pool with no ipv4 units
vdc: j.tools.vdc.reporting.report_vdc_status("vdc_av_shiva")
testnet

the description was a bit misleading.
in redeploy_master() we get the old master workload and deploy the master using the same pool id.
https://github.com/threefoldtech/js-sdk/blob/b6d5dd5e35e529f456c625816d2729fa8fb3842a/jumpscale/sals/vdc/kubernetes.py#L799
https://github.com/threefoldtech/js-sdk/blob/b6d5dd5e35e529f456c625816d2729fa8fb3842a/jumpscale/sals/vdc/kubernetes.py#L833-L843
so the master wasn't redeployed on another farm or pool, this is not possible.
this VDC was created on July 7 as shown by the reporting tool, the master was already on freefarm2/pool id 29117 from the beginning, and it wasn't dead but the IPv4Units ran out from the pool as renewing the plan failed due to lack of enough TFTs in the prepaid wallet and the provision wallet, this happened on Agust 5 and renders the master unreachable.
in this case, the VDC is considered partially expired as trying to redeploy will fail because the pool no more has IPV4Units.

closing this and you could open a feature request to improve the redeploy master flow, so it could check for such cases and try to reset pool.active_ipv4 and renew the IPV4Units if enough TFTs were added.


[NOT AZURE] Azure Stack Network Admin SDK

Description

This is for Azure Stack ONLY.  There seems to be an issue when generating the SDK remotely for the repo some reason.  I have message the Autorest team and ask them for help but no response.
https://github.com/Azure/azure-rest-api-specs/pull/2813

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] Please add REST spec PR link to the SDK PR
[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[X] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@deathly809 Please fix compilation errors here

@deathly809 yes It could have been a machine issue, restarted the build, please wait.


brew update error

If Homebrew was updated on Aug 10-11th 2016 and brew update always says Already up-to-date. you need to run: cd "$(brew --repo)" && git fetch && git reset --hard origin/master && brew update.
Please follow the general troubleshooting steps first:

[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed as many issues as possible and retried your prior step?
[x] If you're seeing permission errors tried running sudo chown -R $(whoami) $(brew --prefix)?

You can erase any parts of this template not applicable to your Issue.
Bug reports:
brew update:
fatal: unable to access 'https://github.com/Homebrew/brew/': SSLRead() return error -9806
fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': SSLRead() return error -9806
fatal: unable to access 'https://github.com/caskroom/homebrew-cask/': SSLRead() return error -9806
Error: Fetching /usr/local/Homebrew failed!
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core failed!
Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask failed!

brew doctor:
Your system is ready to brew.

My computer is Mac 10.12.1.
Is there something wrong with my net？

i have the same problems as you

Does cd "$(brew --repo)" && git fetch work?

@bfontaine Thanks for your reply.It did not work after I did like you said.
Then I used this command :brew update --verbose,it shows that:
Checking if we need to fetch /usr/local/Homebrew...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
remote: Counting objects: 40, done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 40 (delta 29), reused 32 (delta 21), pack-reused 0
Unpacking objects: 100% (40/40), done.
From https://github.com/caskroom/homebrew-cask
   8c1dcc3..a884391  master     -> origin/master
Updating /usr/local/Homebrew...
Reset branch 'stable'
Current branch stable is up to date.

Updating /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
First, rewinding head to replay your work on top of it...
Fast-forwarded master to origin/master.

Updated 1 tap (caskroom/cask).
No changes to formulae.

It seams to work well.

Closing as this seems very likely to be https://github.com/Homebrew/brew/issues/1324#issuecomment-257287604.


cnf-network:metallb: removed default route from the frr test container

This pull request addresses an issue with traffic validation during MetalLB testing. Currently, the client test pod is able to reach the server through the default route because it runs on a master node. This setup results in false positive validation results.

/lgtm


Show/Hide filters

Motivation
Currently the "useful" filters are search term and organisation as the taxonomy filter currently only applies to education content. To deal with showing additional filters while not overwhelming the user it would be useful to be able to by default hide filters perceived as "less useful".
Trello: https://trello.com/c/5rIJ0cg3/241-5-collapse-taxonomy-filter
Description
This PR wraps the taxonomy filter in a collapsible div which can be toggled by clicking a link in the sidebar.
It also adds logic to the ContentItemsController to render the additional filters in an open state if the user is currently filtering by one of them.
New gems added to allow feature testing with javascript, namely selenium and poltergeist for headless browser support.
Before

After

@pmanrubia I've rebased - due to the addition of SSO I've had to add the DatabaseCleaner gem to allow javascript enabled tests to have access to the user for the suite. Feel free to advise on a better way to configure it in the rails_helper.rb as you'd know best!


cannot preview environment or dataframe

when I called the R:preview environment or R:preview dataframe
error turns out to be Cannot read property '0' of undefined
with excel viewer installed.
OS：Mac os Catalina 10.15.3

@ddangl It looks like the extension may not be activated. Can you save the file as ‘temp.R’, choose ‘Open Folder...’ from the File menu, select the folder containing ‘temp.R’, and try again? Thank you!

@ddangl It looks like the extension may not be activated. Can you save the file as ‘temp.R’, choose ‘Open Folder...’ from the File menu, select the folder containing ‘temp.R’, and try again? Thank you!

It does works,thank you!

@ddangl Great! :) It sounds like this issue is resolved, so I’ll close it.


[L2-UX] Change Polygon RPC

What it solves
Resolves #2852
How this PR fixes it
Polygon RPC changed to newest aggregator.
How to test it
Delete Polygon from MM config and then try to connect again via the Safe. The option to automatically add the Polygon config to MM should open.

I'll merge this from dev instead.


Add include_source_context option

Problem Statement
Some users do not like the source context to be there and want to disable it.
Solution Brainstorm
For this we need to add a SDK option include_source_context that defaults to True.
If set to false, the source context should not be included.
Here is probably the place where to decide whether to add the source context or not:
https://github.com/getsentry/sentry-python/blob/antonpirker/celery-beat-wo-restart/sentry_sdk/utils.py#L614-L625

Reopening since there's a bit missing in order to finish the implementation fully.

Documentation for this option is still missing, but the option itself is already release in version 1.23.0


''luarocks make'' gives "void value not ignored as it ought to be" error, and a possible fix

Running ''luarocks make" gave me the error:
"void value not ignored as it ought to be" on all cnpy::npy_save function calls (npy4th.cpp line 151, 157, ...),
though I noticed cnpy/cnpy.h is already returning bool.
This could be due to I installed npy4th v1.2 earlier, and there was a cnpy.h somewhere else in the system as the earlier version might return void.
An easy fix is to hard code the path include "cnpy/cnpy.h" instead of include <cnpy.h> at line 8 of npy4th.cpp . It'd be great to fix this in the repo as it may benefit other people with a similar issue.

Thanks for finding this out!
It does seem to be an issue with updating from 1.2. I'm not sure why cnpy.h installation is not being updated though.
I think I should figure out how to bundle cnpy in a better way. I'll get a fix in there.
Thanks again!

That sounds great. Thanks!


How to upgrade the application correctly

Hi,
There are lines at the docker-entrypoint file: https://github.com/naskio/docker-strapi/blob/5b24cf823acd67d96f6a02135d09b1b98937bfbf/images/strapi-alpine/docker-entrypoint.sh#L25-L37
If we upgrade strapio to the newer version, docker-entrypoint sees that the node_modules folder exists and wont install the upgrades if there are any. How to perform here correctly?

@naskio this is obvious actually. I'm just wondering how to upgrade all those modules (if needed) when I upgrade docker image?

@naskio I'm currently building the Helm Chart which installs strapi.io (testing that with K8S in AWS EKS). We are going to have shared NFS folder between the pods, that's why I'm asking.
The code of the helm chart (WIP) is here

Why not just upgrading the docker image ?

If we pull the newer image, but reuse the same volume for /srv/app that contains the .../public/uploads and ../src/api directories which are vitals for data persistence. Then with the line pointed out by @zentavr, even with a pull, the node_modules won't update and neither the strapi version.
Or maybe I am missing something ?

Right now we are building our own image.
We use current image in development mode in order to create the collections (which creates the files in the src/api folder. Then we commit that into git and have ci/cd pipeline on top of that which runs in AWS Codepileline and builds and spins up the image from our personal repository.
probably we changed dockerfile and an entry point for that.


Add tests for preprocessors

Test

pre_pymarkdown
pre_codefolding
pre_svg2pdf

Requires Inkscape installed for svg to pdf conversion.

Nice. I'll patch these into the nosetests I've started working on. It would probably make sense to rename to a python-compatible name (i.e. replace hyphen test-postprocessors.py -> test_postprocessors.py)

Sure, extract what you think you can use. For the pre_svg2pdf test I have to check if Inkscape is available, or otherwise skip the test.


25fps bug?

So on the Hero 7 if you take the total number of samples of the gyro stream and divide it by the number of payloads it will give you a number around 200, which is the spec of the gyro recording rate from the readme.  But if you're shooting in 25fps and do the same (samples/payloads), the number ends up being way off from 200.  Is this a bug?  Is there a better way to figure out the average rate per payload for 25fps footage?  Thanks!

This is not a bug.  25fps might seem like a special case (it is not if you read the MP4 header correctly) as the IDR length is 26 frames not 25.  This means the duration of the payload is 26/25 or 1.04s. On average you will have 208 ACCL and GYRO samples per payload, so it is still around 200Hz.  50/100fps modes have a payload duration of 1.0s. All the NTSC frame rates are 1.001s per payload.  You don't need to hard-code any of this as the MP4 track for metadata does indicate the correct duration for each payload for all GoPro modes.

That's very helpful thanks!


[ISSUE] Can't reload page in spring-boot-react tutorial

Article and Module Links
A link to the affected article and the affected module. You can find the link to the module in the Conclusion section in the "on Github" standard phase.
Describe the Issue
I can run this tutorial and works as I expected however in sub-pages like http://localhost:8080/clients. I cannot enter via url or refresh page. Spring API part overrides react-router.
To Reproduce
Steps to reproduce the behavior:

Start application
Click on 'Clients' button
Refresh page
See Whitelabel Error Page

Expected Behavior
After refreshing page should work as intended
Environment (please complete the following information):

OS: [OSX Sonoma 14.5]
Browser [Chrome]
Chrome Version [125.0.6422.77]

Hi, I would like to work on this task.


extracting Bottleneck features using pretrained Inceptionv3 - differences between Keras' implementation and Native Tensorflow implementation

(Apologies for the long post)
All,
I want to use the bottleneck features from a pretrained Inceptionv3 model to predict classification for my input images. Before training a model and predicting classification, I tried 3 different approaches for extracting the bottleneck features.
My 3 approaches yielded different bottleneck features (not just in values but even the size was different).

Size of my bottleneck features from Approach 1 and 2: <number of input images x 3 x 3 x 2048>
Size of my bottleneck features from Approach 3: <number of input images x 2048>
Why are the sizes different between the Keras based Inceptionv3 model and the native Tensorflow model? My guess is that when I say include_top=False in Keras, I'm not extracting the 'pool_3/_reshape:0' layer. Is this correct? If yes, how do I extract the 'pool_3/_reshape:0' layer in Keras? If my guess is incorrect, what 'am I missing?

I compared the bottleneck feature values from Approach 1 and 2 and they were significantly different. I think I'm feeding it the same input images because I resize and rescale my images before I even read it as input for my script. I have no options for my ImageDataGenerator in Approach 1 and according to the documentation for that function all the default values do not change my input image. I have set shuffle to false so I assumed that predict_generator and predict are reading images in the same order. What 'am I missing?

Please note:
My inputs images are in RGB format (so number of channels = 3) and I resized all of them to 150x150. I used the preprocess_input function in inceptionv3.py to preprocess all my images.
    def preprocess_input(image):
    image /= 255.
    image -= 0.5
    image *= 2.
    return image

Approach 1: Used Keras with tensorflow as backend, an ImageDataGenerator to read my data and model.predict_generator to compute bottleneck features
I followed the example (Section Using the bottleneck features of a pre-trained network: 90% accuracy in a minute) from Keras' blog. Instead of VGG model listed there I used Inceptionv3. Below is the snippet of code I used
(code not shown here but what i did before the code below) : read all input images, resize to 150x150x3, rescale according to the preprocessing_input function mentioned above, save the resized and rescaled images
    train_datagen = ImageDataGenerator()
    train_generator = train_datagen.flow_from_directory(my_input_dir, target_size=(150,150),shuffle=False, batch_size=16)

    # get bottleneck features
    # use pre-trained model and exclude top layer - which is used for classification
    pretrained_model = InceptionV3(include_top=False, weights='imagenet', input_shape=(150,150,3))
    bottleneck_features_train_v1 = pretrained_model.predict_generator(train_generator,len(train_generator.filenames)//16)

Approach 2: Used Keras with tensorflow as backend, my own reader and model.predict to compute bottleneck features
Only difference between this approach and earlier one is that I used my own reader to read the input images.
(code not shown here but what i did before the code below) : read all input images, resize to 150x150x3, rescale according to the preprocessing_input function mentioned above, save the resized and rescaled images
    # inputImages is a numpy array of size <number of input images x 150 x 150 x 3>
    inputImages = readAllJPEGsInFolderAndMergeAsRGB(my_input_dir)

    # get bottleneck features
    # use pre-trained model and exclude top layer - which is used for classification
    pretrained_model = InceptionV3(include_top=False, weights='imagenet', input_shape=(img_width, img_height, 3))
    bottleneck_features_train_v2 = pretrained_model.predict(trainData.images,batch_size=16)

Approach 3: Used tensorflow (NO KERAS) compute bottleneck features
I followed retrain.py to extract bottleneck features for my input images. Please note that that the weights from that script can be obtained from (http://download.tensorflow.org/models/image/imagenet/inception-2015-12-05.tgz)
As mentioned in that example, I used the bottleneck_tensor_name = 'pool_3/_reshape:0' as the layer to extract and compute bottleneck features. Similar to the first 2 approaches, I used resized and rescaled images as input to the script and I called this feature list bottleneck_features_train_v3
Thank you so much

P.S. I have posted this question in stackoverflow too. I will post an answer here if I it is answered on SO.

I would recommend doing something like the following:
        bottleneck_model = Model(inputs=source_model.input,             outputs=self.source_model.get_layer(index=[insert number]).output)
and then simply call predict_on_batch or predict_generator.

Thanks @brge17 . I'm sorry but I have just started using Keras.
Per your suggestion,  Model will accept my input images as a tensor. Since 'am using Inception V3, my tensor has to be a 4D array of shape number of input images x  image height x image width x 3.

outputs=self.source_model.get_layer(index=[insert number]).output)

Do I use the layer from Inception V3 that I want to extract and compute bottleneck features?
Can you please elaborate?
I have a follow up question or two based on your response. Thanks again for your response.

Working code is below. Step 1 is to load the Inception V3 model, step 2 is to print it and find where you want the bottleneck features from, step 3 is to perform surgery and make a new network with the same input as Inception V3 and the desired output, and finally step 4 is to predict.
Change the get layer string as needed.
from keras.models import Model
from keras.applications import InceptionV3

import numpy as np

# Randomly generated image
dummy_img = np.random.rand(1, 299, 299, 3)

# Source model
model = InceptionV3()
print model.summary()

# Surgery
bottleneck_model = Model(inputs=model.input,
						 outputs=model.get_layer('avg_pool').output)
print bottleneck_model.summary()

# Predict
bottleneck_features = bottleneck_model.predict(dummy_img)
print bottleneck_features.shape
print bottleneck_features

Thanks @brge17 . Now all 3 of my approaches (Keras' predict and predict_generator and native tensorflow implementation) give me the same bottleneck features.
Looking at the InceptionV3_model.summary(), include_top=False is not the same as InceptionV3_model.get_layer('avg_pool') are not the same. What I need to compute bottleneck features is the output of avg_pool layer.
Thanks again
p.s. can i close the issue? also, for future references do i post similar questions on this site or on stackoverflow?

I am trying to do the same thing but I am still getting different bottleneck features from keras (2.1.1) for InceptionV3 and from native tensorflow. The used image as well as the graph definition file can be found at http://download.tensorflow.org/models/image/imagenet/inception-2015-12-05.tgz .
How did you manage to get the same results? Here is my python code:
import tensorflow as tf
import numpy as np
from keras.applications.inception_v3 import InceptionV3, preprocess_input
from keras.preprocessing import image
from keras.models import Model

def create_graph():
	with tf.gfile.FastGFile('inception/classify_image_graph_def.pb', 'rb') as f:
		graph_def = tf.GraphDef()
		graph_def.ParseFromString(f.read())
	_ = tf.import_graph_def(graph_def, name='')

def extract_features_tf(image_path):
	create_graph()
	with tf.Session() as sess:
		next_to_last_tensor = sess.graph.get_tensor_by_name('pool_3/_reshape:0')
		image_data = tf.gfile.FastGFile(image_path, 'rb').read()
		predictions = sess.run(next_to_last_tensor, {'DecodeJpeg/contents:0': image_data})
		return np.squeeze(predictions)

def extract_features_keras(image_path):
	base_model = InceptionV3()
	model = Model(inputs=base_model.input, outputs=base_model.get_layer('avg_pool').output)
	img = image.load_img(image_path, target_size=(299, 299))
	x = image.img_to_array(img)
	x = np.expand_dims(x, axis=0)
	x = preprocess_input(x)
	predictions = model.predict(x)
	return np.squeeze(predictions)

print extract_features_tf("panda.jpg")
[ 0.21214356  0.04288584  0.1422075  ...,  0.09034983  0.01486579
  0.13966659]
print extract_features_keras("panda.jpg")
[ 0.2067015   0.10939689  0.08871846 ...,  0.51381278  0.16807012
  0.23888288]

Thanking you in advance.

@k0nd0r couple things to try

Try the 2016 weights for tensorflow
You are preprocessing your input for keras' bottleneck features but are not doing that for the  tensorflow. (preprocessing in keras scales and normalizes your image to conform to imagenet images).
Hope that helps.

@prashanthdumpuri , if you could provide the code showing how you got the same embedding vectors from the different approaches that would be appreciated. Have some legacy code for which uses old native TF implementation of inception and want to update to tf.keras.applications.inception etc. Cheers.


Move the header extensions to Http.Abstractions

#489
/cc @Tratcher @muratg

No csproj changes! Oh, how I :heart: this :grin:

:golf: :clap:

Why these and not any of the other extensions? They aren't abstractions, they're just convenience methods.

If you think these are core functionality then put them directly on the interface.

Nah. The interface should have whatever is minimally required to implement it. These are extensions that work on top of any  implementation.
The bug is specifically about header extensions, also these don't bring in any other dependencies so easy to move.


Move default S3 url style from defaults.yaml to config.go

Because we have no way to tell whether defaults in defaults.yaml are user-provided or not, the default there of Origin.S3UrlStyle was throwing an error meant to notify users that they have incompatible config variables set.
This moves setting of that default into config.go where we now use viper.SetDefault, which later on allows us to viper.IsSet("Origin.S3UrlStyle") without catching our own default.

Sorry for the typo, should be good to go now.


Add Mistral 7B OpenChat 3.5 to local hosted models

Model shows good performance for open source models.

https://huggingface.co/openchat/openchat_3.5
https://huggingface.co/mistralai

Mistral 22B could also be interesting but currently I suppose that would not work license wise.

Openchat does not seem to have any models for transformer.js.
There is one transformer.js model called tiny-random-mistral, which does not sound very promising. Especially since I am not sure if this is even a chat completion model, or "just" text generation.


TA-82079

https://cockroachlabs.atlassian.net/browse/DOC-5009

This change is

Marius Posta @.***> writes:

The repair succeeds if the query succeeds. Re-running the diagnostic
query can confirm this. For the paranoid, there's the option of doing
just that (repair + re-diagnosis) in an explicit transaction.

OK thanks for explaining this Marius!  And Gemma, I see you updated the
doc with this info - thanks!


Toyota: improve longitudinal control

As usual, don't have a route as I don't have access to comma servers (repaired device), but this works really well on my TSS-P Prius, best longitudinal I've seen since I started using openpilot 4 years ago.
I've done some digging after @sshane 's PCM compensation experiment and have found that the vehicle uses two acceleration values to calculate the amount of force that needs to be compensated, hence the ACCEL_CMD_ALT in all Toyota dbcs.
Side note, this ACCEL_CMD_ALT was originally named AT_RAW in the leaked file, which I believe is the DSU/camera's version of the un-compensated acceleration value, the vehicle only listens to ACCEL_CMD for actual controls, but it will still use ACCEL_CMD_ALT to calculate a compensatory force.
Basically, in openpilot terms, ACCEL_CMD_ALT, a.k.a.AT_RAW, is equivalent to openpilot's accel actuator (actuators.accel); and ACCEL_CMD, a.k.a. ATACC2, is equivalent to the min max acceleration clipped "openpilot accel actuator (actuators.accel) + compensatory force (CS.pcm_neutral_force) / vehicle weight (self.CP.mass)".
This PR addresses the following long-standing issues with Toyota longitudinal:

no more abruptions when reaching stopping state
no more longitudinal deadzones needed, no more speed oscillation This is still true on some cars
no more slow accel request response
no more engine revving at start
no more cruising just below set speed when going downhill
no more unresponsive highway speed control
no more overshooting when going uphill/downhill/accelerating

The following item(s) will need further verification:

[x] smooth engagement and accelerator depression/release transition, try to achieve stock levels of smoothness when engaging, thanks for the feedback @AlexandreSato should be okay now https://github.com/commaai/openpilot/commit/22f77bde9234de524e0d0344d99f429a02f0345b
[ ] tuning, it seems like this tune works well on my compensated Prius, verify for other vehicles, especially those with a pedal, verify pedal transition

[x] According to @CT921 , some prius V users have noticed high speed oscillations, I've seen the same thing at around 60 km/h, fix this should also be okay https://github.com/commaai/openpilot/pull/30697/commits/db93dbd88f85eadb501da6c5377bc780eb1304be

[ ] ret.vEgoStopping, verify if this value works on all vehicles, goal: vehicle shouldn't creep
[x] ret.stoppingDecelRate = 0.8 can be optimised based on road slope to achieve a smoother stop, but is not necessary
[x] TSS 2.0, the way openpilot handles these cars is questionable, from what I've seen in Techstream, compensatory calculations will be paused when the vehicle is stopped and in standstill, but none of our TSS 2.0s go into standstill AFAIK, verify how this affects performance. TODO#1
[x] Verify if PCM behaves consistently with gas press and lever (button) press when resuming. If PCM behaves differently, check if this is something that we can control to improve responsiveness. behaves the same on my 2018 prius (non-phv)

Known issue:
1. TSS 2.0 vehicles will creep with the SnG hack enabled (which is default openpilot behaviour) Current logic seems to have fixed this, needs more testing
To-dos:

[x] 1. stop compensating on TSS 2.0 when stopping.

[ ] test on hills, flat surface route b4f83330b2d59205|2023-12-12--23-03-43--0

[x] 2. Figure out how stock Toyota pulls away so quickly behind lead, does it disable compensation? Seems like PERMIT_BRAKING can solve this.

Nice! I'm gonna convert to draft until your TODOs are done.

Route on 2022 Camry Hybrid TSS2, has some interesting bookmarks: b4f83330b2d59205|2023-12-12--23-03-43--0
Will edit this comment with more once I get some better examples, but it performed REALLY well and felt more like how I would control the throttle.  Little to no oscillations on highway in experimental mode, too!  Thanks for the awesome work!

Three consecutive bookmarks mean uphill, two downhill and one flat surface. Posted in redundancy in the Pull Request comment "Toyota Improve longitudinal control" and discord thread to gain traction.
On commit "Fix line too long" 62cc41a:
075b133b6181e058|2023-12-16--12-10-44
075b133b6181e058|2023-12-16--12-24-38
075b133b6181e058|2023-12-16--12-56-50
075b133b6181e058|2023-12-16--13-04-06
2023-12-16

[!TIP]
Positives on my corolla TSS2 hybrid: No more abrupt accelerations, more responsive on uphill exits;
[!CAUTION]
Negative, it brakes unnecessarily when engaging.

feels like a big improvement, tssp corolla pedal transition too.
62cc41a5b7343851092805f78e17e520437e4c48
a152dad3c3368320|2023-12-22--06-33-26
a152dad3c3368320|2023-12-21--17-05-10
a152dad3c3368320|2023-12-21--12-26-29
a152dad3c3368320|2023-12-21--12-21-54
a152dad3c3368320|2023-12-21--12-06-36
a152dad3c3368320|2023-12-21--07-48-27
a152dad3c3368320|2023-12-21--07-16-58
a152dad3c3368320|2023-12-20--17-27-32
a152dad3c3368320|2023-12-20--17-04-07
a152dad3c3368320|2023-12-20--07-53-50

As my previous stock routes were lost because I forgot to preserve, I'm posting new ones, better and this time preserved and public:
075b133b6181e058|2023-12-24--13-41-53
075b133b6181e058|2023-12-24--13-36-36--0

on 5c789cb "adhd" It's no longer speeding up or slowing down.
On highway:     075b133b6181e058|2023-12-27--12-17-49
city: 075b133b6181e058|2023-12-27--16-38-17

On 77d3108
Brake when engage fixed! flawless absolutely no jerk or harsh just a bit of abrupt brake when entering in stopped state machine.
Some routes:
075b133b6181e058|2023-12-28--14-12-50
075b133b6181e058|2023-12-28--15-27-40
075b133b6181e058|2023-12-28--17-51-12

On 'revert these' 759f0c8:
075b133b6181e058|2024-01-05--12-03-55 (Public and preserved)
Fixed hard braking when entering Stopped State. I believe creep happened here: 075b133b6181e058|2024-01-05--12-03-55--2

In fact, what is happening is that STOP_DISTANCE is not consistent (see 075b133b6181e058|2024-01-06--16-23-56--4). However, the longitudinal control by openpilot is now perfectly the same as stock Toyota, very good!

on: https://github.com/commaai/openpilot/commit/4bc10ba3309924dd54191073deb2ddf555e6b69e
best longitudinal control seen in years. Only improvements without any regression on my corolla TSS2. Creep definitely solved! In my opinion it's good to go. Public and preserved route:
https://connect.comma.ai/075b133b6181e058/1706014680345/1706016181471
075b133b6181e058|2024-01-23--09-58-02

commit aa895f7282583cb092356cd8fe99c177fe7d79ee
a152dad3c3368320|2024-01-23--19-42-30 public 9 segment route
similar experience with tssp corolla + pedal

Also we might be able to fix #29613 once this is merged, as this does introduce a lead stopped condition, and that can be used to fix the standstill entrance behaviour
      if CS.out.vEgo < self.CP.vEgoStopping and lead_vehicle_stopped and self.CP.carFingerprint not in NO_STOP_TIMER_CAR:
        self.standstill_req = True
      else:
        self.standstill_req = False

Also we might be able to fix #29613 once this is merged, as this does introduce a lead stopped condition, and that can be used to fix the standstill entrance behaviour

May I ask what you're trying to accomplish by considering the lead car's stopped condition? It's abstraction-breaking and I'm not sure what it gains you from reading this PR and other associated history. Does it improve the final stop position? Smoothness? Does it prevent creep on resume press? If there's some material improvement, then surely the same improvement is desired for stopping at a red light with no lead car visible.

Also we might be able to fix #29613 once this is merged, as this does introduce a lead stopped condition, and that can be used to fix the standstill entrance behaviour

May I ask what you're trying to accomplish by considering the lead car's stopped condition? It's abstraction-breaking and I'm not sure what it gains you from reading this PR and other associated history. Does it improve the final stop position? Smoothness? Does it prevent creep on resume press? If there's some material improvement, then surely the same improvement is desired for stopping at a red light with no lead car visible.

Yea it might not be needed tbh, anecdotally and from my own testing it seems to have helped with creeping

Yea it might not be needed tbh, anecdotally and from my own testing it seems to have helped with creeping

To expand on what I was saying before: in an E2E world, making policy decisions based on lead vehicle speed really belongs in higher levels of openpilot. However, if the Toyota CAN signal ACC_CONTROL.LEAD_VEHICLE_STOPPED is a real thing and the vehicle powertrain/chassis is verified to react to it in a way that we understand and find useful, the Toyota car port can absolutely (ab)use that signal to obtain desired stopping/starting performance. It might, for example, be used to let go of the brakes earlier and prepare for departure without actually applying engine throttle yet. I'm just guessing what its effect might be, I would have to observe the stock system working.

On 3b89906
Very good experience!
075b133b6181e058|2024-01-24--07-33-19

good stops at https://github.com/commaai/openpilot/pull/30697/commits/ef15ad3d66bbf4fb9a3b9f3acdd9c9b4c3a9094b
075b133b6181e058|2024-01-26--10-39-08

The stock system mostly keeps PERMIT_BRAKING at 1 when it's behind a lead, even during takeoff, so I think we can achieve better sng performance without touching it (I'd really like to avoid using it too since it's not easy to get a binary brake control bit like this to smoothly and safely work, especially on hills)
https://github.com/commaai/openpilot/assets/25857203/ef8ec657-1a72-493f-b97d-30e57512e802

On the stock system of the 2021 Rav4 Prime it seems like ACCEL_CMD is always 0, and only ACCEL_CMD_ALT is used. (20ba9ade056a8c7b|2021-02-08--21-57-35). Is this the first car that shows this behavior?

The stock system mostly keeps PERMIT_BRAKING at 1 when it's behind a lead, even during takeoff, so I think we can achieve better sng performance without touching it (I'd really like to avoid using it too since it's not easy to get a binary brake control bit like this to smoothly and safely work in all scenarios, especially on hills)
https://github.com/commaai/openpilot/assets/25857203/74878c55-ae4b-4efe-a670-eb3ceaf1cd87

Yup agreed, also I've realised that setting this bit to 0 at lower speeds does lead to some jerkiness when openpilot is letting go of the brakes, I'll get rid of it

Good behavior no issues on
075b133b6181e058|2024-01-30--11-22-14

https://connect.comma.ai/075b133b6181e058/1706624534176/1706625197269
Eco and normal mode, public and preserved
075b133b6181e058|2024-01-30--11-01-25

preserved

Very good at 'remove LVSTP from toyotacan and revert permit braking to stock' a8c3f6a13610996f1d34f98d4fbbeaddb4b123a8
075b133b6181e058|2024-02-02--21-10-12

075b133b6181e058|2024-02-02--19-11-04

Hey!  So I've jumped around stock Toyota long, OP long on master and OP long on this PR branch and this branch gets much closer to how stock Toyota long reacts with gas and brake (which is better than OP long).  It's still much smoother than OP long on master, but seems to have gained some strange throttle oscillations that I haven't found the cause of yet.
Here's a preserved route on 5fee813 with bookmarks: b4f83330b2d59205|2024-02-08--22-44-39--0 (https://connect.comma.ai/b4f83330b2d59205/1707432279382/1707434769358)

Seg 9 has a very well executed hard stop
Segs 15-17 have starts, stops, and oscillations when stopping.  Perhaps while starting too, I don't remember.
Seg 23 has oscillations when approaching stopped vehicle
Seg 24 has a nice hard stop
Seg 30 has oscillations at highway speeds when the lead slows down drastically
Seg 39 I believe had oscillations when approaching slower lead, but this is still by far the best braking performance I've had on any branch or fork!

Before the permit braking bit was removed, engaging while stopped behind a lead was broken and started idling forward with no intention of stopping.  I'll test it again on this commit shortly and edit my comment.

Hey! So I've jumped around stock Toyota long, OP long on master and OP long on this PR branch and this branch gets much closer to how stock Toyota long reacts with gas and brake (which is better than OP long). It's still much smoother than OP long on master, but seems to have gained some strange throttle oscillations that I haven't found the cause of yet.
Here's a preserved route on 5fee813 with bookmarks: b4f83330b2d59205|2024-02-08--22-44-39--0 (https://connect.comma.ai/b4f83330b2d59205/1707432279382/1707434769358)

Seg 9 has a very well executed hard stop
Segs 15-17 have starts, stops, and oscillations when stopping.  Perhaps while starting too, I don't remember.
Seg 23 has oscillations when approaching stopped vehicle
Seg 24 has a nice hard stop
Seg 30 has oscillations at highway speeds when the lead slows down drastically
Seg 39 I believe had oscillations when approaching slower lead, but this is still by far the best braking performance I've had on any branch or fork!

Before the permit braking bit was removed, engaging while stopped behind a lead was broken and started idling forward with no intention of stopping. I'll test it again on this commit shortly and edit my comment.

Throttle oscillation is usually tuning related, I've noticed it on mine as well when decelerating over a distance downhill. Tuning is something that I'll need to look into a bit more, as of now I can still identify some imperfections with stock MPC, hopefully tuning can reduce those.

Very good at xxxx (2024-02-14)
Public and preserved test routes
075b133b6181e058|2024-02-14--11-43-21

https://connect.comma.ai/075b133b6181e058/1707921801231/1707922285843

Route: 7069d98b0de453c0/000000e4--f987d1b8d5/0
Updated this PR for the new longitudinal API, also updated the tuning for TSS-P vehicles, this tune seems to produce minimal oscillations for all conditions on my 2018 Prius, route is included above for your convenience.

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.


Fix Swagger JSON autogeneration issues.

When autogenerating a swager client from the current swagger.v1.json, at least in Java, there is an issue whereby the use of schema references for the forbidden and empty responses leads to a broken client being created due to swagger believing that these represent an unspecified object. This pull requests removes these unnecessary schema references for the API references where a description for the empty/forbidden responses is provided.

Codecov Report

Merging #4845 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4845      +/-   ##
==========================================
+ Coverage   37.22%   37.24%   +0.01%
==========================================
  Files         305      305
  Lines       45037    45015      -22
==========================================
  Hits        16766    16766
+ Misses      25836    25814      -22
  Partials     2435     2435

Impacted Files
Coverage Δ

routers/api/v1/org/team.go
4.74% <ø> (+0.02%)
:arrow_up:

routers/api/v1/org/member.go
0% <ø> (ø)
:arrow_up:

routers/api/v1/repo/issue.go
30.12% <ø> (+0.35%)
:arrow_up:

routers/api/v1/repo/pull.go
13.38% <ø> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad5ccc...f617ff1. Read the comment docs.

I remember the opposite problem with go version of swagger but since CI doesn't seems to complain. LGTM

Most of the swagger api descriptions incorrectly use the integer type when the underlying go code actually uses int64. I've added further changes to account for this.

I've also noted that the swagger description of GET /repos/{owner}/{repo}/pulls was also inadequate

@lunny need your approval


Documented System.Text.Unicode namespace

Documented System.Text.Unicode namespace
Summary
Documents the System.Text.Unicode namespace, as well as the UnicodeRange and UnicodeRanges types.
Fixes #2983
Suggested Reviewers
@mairaw, @tarekgh , @KrzysztofCwalina

@tarekgh, as the end code point for a block, I used the last valid code point in that block, and not the last assigned code point. I think I should revise this; otherwise, going back to your comment on the Unicode standard version, we'll have to revise this each time a new version of the Unicode standard is released.

going back to your comment on the Unicode standard version, we'll have to revise this each time a new version of the Unicode standard is released.

My only concern with that every time we touch the ranges we have to remember to update this version. I am not sure how we can guarantee the sync between the data we have and the referenced version.

@tarekgh, I've revised the document to address your suggestions, as well as to correct some typos and other errors I found. In general, I agree that we should document the beginning and end of ranges as specified by the Unicode standard without excluding undefined code points at the start or end of the range; you're right that we can't realistically maintain the documentation whenever the supported Unicode version changes. So I've done that for all of the fields in the UnicodeRanges class.

Closing and reopening to begin new build.

Curious, do you think the overload link doesn't work when we don't have an overload page? That seems like a bug to me.

@mairaw, it turns out that the overload link doesn't work because the # in #ctor needs to be encoded.


Results Vary Slightly with Each Run on Google Colab - How to Fix Random Seed?

I'm using Vignette.ipynb on Google Colab, and I've noticed that while the results are generally similar, the specific values vary slightly with each run. Is there a way to fix the random seed in this notebook to ensure that the results are consistent across different runs?
Thank you for your help!

Hi Josh,
Thanks for the suggestion. Setting the numpy and tensorflow seeds worked perfectly. I'm now getting consistent results.


Don't understand how world works

Hi !
I don't understand how stage, camera and world works (I tried to read the doc and the code).
How Phaser process entities in the game. If I decide an entity is somewhere in the world, and the camera can't see it, how phaser decide what entities are going to be updated and rendered, and what entities shouldn't ?
Thanks a lot.

All entities are updated and rendered, every frame, no matter where in the world they are.
You can tell an entity to stop rendering if out of the camera bounds by setting autoCull = true on a Sprite (or anything with the InWorld component). You can tell it to kill itself if out of the camera bounds with outOfCameraBoundsKill = true, or out of the world bounds with checkWorldBounds = true combined with outOfBoundsKill = true.
For any follow-up questions please use the forum. I prefer to keep GitHub issues for actual issues.


Operator install with sds profile does not work

Use operator to install sds profile, then istio-proxy seems to not work properly. See abnormal frequent xds connection close message from the proxy logs.

trying this out as well, will add some details shortly

My config:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
metadata:
  name: istio
  namespace: istio-operator
spec:
  values:
    grafana:
      enabled: true

    global:
      controlPlaneSecurityEnabled: true
      mtls:
        enabled: true
      sds:
        enabled: true
        udsPath: "unix:/var/run/sds/uds_path"
        useNormalJwt: true

    nodeagent:
      enabled: true
      image: node-agent-k8s
      env:
        CA_PROVIDER: "Citadel"
        CA_ADDR: "istio-citadel:8060"
        VALID_TOKEN: true
        SECRET_GRACE_DURATION: "1m"
        SECRET_JOB_RUN_INTERVAL: "30s"
        SECRET_TTL: "2m"

Pilot istio-proxy logs:
2019-11-06T01:46:13.018195Z     info    waiting for file
2019-11-06T01:46:13.118368Z     info    waiting for file
2019-11-06T01:46:13.218548Z     info    waiting for file
2019-11-06T01:46:13.318738Z     info    waiting for file
2019-11-06T01:46:13.418907Z     info    waiting for file
2019-11-06T01:46:13.519076Z     info    waiting for file
2019-11-06T01:46:13.619345Z     info    waiting for file
2019-11-06T01:46:13.719504Z     info    waiting for file
2019-11-06T01:46:13.819666Z     info    waiting for file
2019-11-06T01:46:13.919875Z     info    waiting for file
2019-11-06T01:46:14.020047Z     info    waiting for file
2019-11-06T01:46:14.120214Z     info    waiting for file
2019-11-06T01:46:14.220423Z     info    waiting for file
2019-11-06T01:46:14.320627Z     info    waiting for file
2019-11-06T01:46:14.420869Z     info    waiting for file
2019-11-06T01:46:14.521043Z     info    waiting for file
2019-11-06T01:46:14.621203Z     info    waiting for file
2019-11-06T01:46:14.721459Z     info    waiting for file
2019-11-06T01:46:14.821720Z     info    waiting for file
2019-11-06T01:46:14.922240Z     info    waiting for file
2019-11-06T01:46:15.022381Z     info    waiting for file
2019-11-06T01:46:15.122753Z     info    waiting for file
2019-11-06T01:46:15.222998Z     info    waiting for file
2019-11-06T01:46:15.323154Z     warn    file still not available after1m0s
2019-11-06T01:46:15.323230Z     info    Monitored certs: []string{"/etc/certs/cert-chain.pem", "/etc/certs/key.pem", "/etc/certs/root-cert.pem"}
2019-11-06T01:46:15.323236Z     info    waiting 2m0s for /etc/certs/cert-chain.pem
2019-11-06T01:46:15.323253Z     info    waiting 2m0s for /etc/certs/key.pem
2019-11-06T01:46:15.323261Z     info    waiting 2m0s for /etc/certs/root-cert.pem

but eventually comes up
Ingress logs are similar
Pretty sure the problem is nodeagent is never created though

mesh generate shows # NodeAgent component is disabled. and "nodeagent":{"enabled":false, .... (in the injector template .values config)
This is an operator/installer bug, not SDS issue @richardwxn

@howardjohn yep I believe so, I am trying to see whether can I find a fix.

We don't use useNormalJwt and useTrustworthyJwt anymore in the old installer, this needs to be updated in the operator as well.

@pitlv2109 yep I noticed that change but that doesn't seem to be the reason?

My issue was a misconfiguration btw -- will try with the correct config
tomorrow
On Tue, Nov 5, 2019 at 7:56 PM Xinnan Wen<EMAIL_ADDRESS>wrote:

@pitlv2109 https://github.com/pitlv2109 yep I noticed that change but
that doesn't seem to be the reason?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/18675?email_source=notifications&email_token=AAEYGXJB3KSH6MUXNT74KPTQSI56JA5CNFSM4JJN3BHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFFQ3Y#issuecomment-550131823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJJD2TN476735A6VO3QSI56JANCNFSM4JJN3BHA
.

@howardjohn any findings for the node agent issue?

@richardwxn I merged some PRs the other day that seem to get it running, I will give a more thorough testing today

I found some issue about workloads not sending any jwts yesterday. Will
look into it.
On Fri, Nov 8, 2019, 8:29 AM John Howard<EMAIL_ADDRESS>wrote:

@richardwxn https://github.com/richardwxn I merged some PRs the other
day that seem to get it running, I will give a more thorough testing today
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/18675?email_source=notifications&email_token=ACQ74ZLXEYVMI7FLIKRO6WLQSWHXHA5CNFSM4JJN3BHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSUGAQ#issuecomment-551895810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ74ZPBZYPY3FZWT7MV733QSWHXHANCNFSM4JJN3BHA
.

Any update on this @pitlv2109 @myidpt ? Currently sds profile is present but omitted in the documentation. Once we get the green light we will update the docs to restore it.

I created a separate issue with more details on the problem and a fix https://github.com/istio/istio/issues/19109


Incompatibility with rspec-wait -- uninitialized constant RSpec::Expectations::ExpectationTarget

$ tree -a
.
├── Gemfile
├── Gemfile.lock
├── .ruby-version
└── spec
    └── _spec.rb

$ cat .ruby-version
2.7.8

$ cat  spec/_spec.rb
require "super_diff/rspec"
require "rspec/wait"

$ cat Gemfile
source "https://rubygems.org"
gem "rspec-wait"
gem "super_diff"

$ cat Gemfile.lock
GEM
  remote: https://rubygems.org/
  specs:
    attr_extras (7.1.0)
    diff-lcs (1.5.1)
    optimist (3.1.0)
    patience_diff (1.2.0)
      optimist (~> 3.0)
    rspec (3.13.0)
      rspec-core (~> 3.13.0)
      rspec-expectations (~> 3.13.0)
      rspec-mocks (~> 3.13.0)
    rspec-core (3.13.2)
      rspec-support (~> 3.13.0)
    rspec-expectations (3.13.3)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-mocks (3.13.2)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-support (3.13.1)
    rspec-wait (0.0.10)
      rspec (>= 3.0)
    super_diff (0.9.0)
      attr_extras (>= 6.2.4)
      diff-lcs
      patience_diff

PLATFORMS
  ruby

DEPENDENCIES
  rspec-wait
  super_diff

BUNDLED WITH
   2.1.4

$ bundle exec rspec

An error occurred while loading ./spec/_spec.rb.
Failure/Error: require "rspec/wait"

NameError:
  uninitialized constant RSpec::Expectations::ExpectationTarget
  Did you mean?  RSpec::Expectations::ExpectationHelper
# ./spec/_spec.rb:2:in `require'
# ./spec/_spec.rb:2:in `<top (required)>'
No examples found.

Finished in 0.00004 seconds (files took 0.11679 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

Hey @Nakilon , thanks for the detailed report. Looks like you're using Ruby 2.7, which is EOL. We no longer support it as of v0.10.0, which explains why your repro uses 0.9.0.
The bad news is, we probably won't backport changes from v0.10.0 onward to v0.9.0, as we don't officially support EOL Ruby versions. The good news is, I can't reproduce this in super_diff v0.10.0 or the latest, v0.13.0.
If you can update to Ruby 3.0+ and are still running into this problem at that point, definitely let me know. (Note that 3.0 is also technically EOL, but we happen to support it for the time being.)


Crystal shards support

Crystal shards support closes https://github.com/apex/up/issues/226.
Example crystal app: https://github.com/sanderhahn/crystal-up

Looks like it's more or less fundamentally the same as the crystal one, shards are dependencies right? We could probably add that check inside crystal(), otherwise LGTM!

Yeah can move the logic into crystal config and have some if statements there. Did put it in a separate config to not disrupt the existing Crystal build logic. Using shards you don't actually know the binary name for starting the server. One assumption could be that the first binary target (in shard.yml) is the actual server. Maybe its nicer to have that logic inside up so that "it just works" :) Now i've added the server name in the up.json proxy commands. Not too familiar with Crystal myself however i tried some examples because up seemed to support it. Up is very nice cool project!

Added some documentation for the shard functionality and made the docker command more explicit. Somehow the reverse proxy doesn't pickup the ./bin/server, but maybe this is because it wasn't released. Hope that this improves the pull-request a bit, can squash the commits if you want. Did not try to add yaml parsing because it will require a new dependency.


The current compilation dependency is to directly rely on the source code repository and then compile it yourself, is there a plan to provide a way to directly rely on the compiled dll?

I mean the source code that depends on sherpa-onnx, not the already compiled library

This approach isn't typical in Rust, and it's not something people usually do. However, I like the idea—it could save unnecessary compilations and time. I'll look into enabling all the features in sherpa-onnx, and then I can distribute a precompiled crate with the bindings already compiled.

See https://github.com/thewh1teagle/sherpa-rs/blob/main/BUILDING.md#use-prebuild-sherpa-onnx-for-fast-compilation
With this approach you can build sherpa-rs in few seconds as it uses prebuilt sherpa-onnx.
Works on macOS/Linux/Windows.
I might automate this in the library and enable it by default in the future, but I'm still undecided. Enabling it could lead to unexpected network or linking errors. Additionally, some binaries, like those for Windows, are quite large—around 300MB since the binaries of sherpa-onnx included in the zipped package.

See https://github.com/thewh1teagle/sherpa-rs/blob/main/BUILDING.md#use-prebuild-sherpa-onnx-for-fast-compilation With this approach you can build sherpa-rs in few seconds as it uses prebuilt sherpa-onnx. Works on macOS/Linux/Windows.
I might automate this in the library and enable it by default in the future (with feature flag), but I'm still undecided. Enabling it could lead to unexpected network or linking errors. Additionally, some binaries, like those for Windows, are quite large—around 300MB since the binaries of sherpa-onnx included in the zipped package.

Yes, it takes me a very long time to recompile each time now, that is to compile sherpa-onnx and sherpa-rs, very time consuming.

Added download-binaries feature to latest release (enabled by default).
Now sherpa-rs relay on compiled sherpa-onnx. also, it caches it across different projects!
It took to me 10 seconds to compile sherpa-rs on macOS.


how do you define 29 human keypoints?

In your code, you have the "pred_xyz_jts_29" as input to hybrik. How do you define these 29 keypoints? and how should I convert other keypoint format (Blazepose 31 keypoints) to 29 keypoints?

You can refer to  #52