Is there support for multiple schemas per topic when using avro?

I'm trying to use avro schema registry with multiple schema types per topic, as discussed in this blog post: https://www.confluent.io/blog/put-several-event-types-kafka-topic/
It mentions setting key.subject.name.strategy and value.subject.name.strategy to one of 3 options:
io.confluent.kafka.serializers.subject.TopicNameStrategy
io.confluent.kafka.serializers.subject.RecordNameStrategy
io.confluent.kafka.serializers.subject.TopicRecordNameStrategy
I'd like to set it to TopicRecordNameStrategy, but I can't figure out how to do this with the .net client. Is it possible?

Can you tell when multiple Avro schemas per topic will be supported by your dotnet client?

@mhowlett - I'm looking into this at the moment and have something that basically works. Is the approach below anything like what you are planning? If not, can you tell me your design approach? I'd ideally like not to stray too far from the beaten path.
Thanks.
I'm using custom serializers based on SchemaRegistry.serdes and using the schema subject in the message to discriminate the type for deserialization. For the producer and consumer, don't set a serializer or deserializer when building the producer/consumer - produce and consume binary.
Internally I have a registry of subject, version and C# Type.
For serialization, use the type to look up the subject and version and find the target schema. Then create the right serializer and produce the binary message.
For deserialization, get the schema id from the message, look up the subject and version from the  schema registry, and use these to look up the target type for the deserializer.

@paddypawprints I'm trying to do this exact thing, while waiting for the official implementation.
Would you have any example code to share?

We also have a strong interest in this. The original posting is asking specifically about the inclusion of the new configuration values for the schema registry client. I am also interested in plan to allow support for multiple deserializers for a single topic. Are there any plans on the horizon to allow a consumer to register multiple deserializers?

Not sure exactly what your requirements are, but you could easily write a IDeserializer<object> and return different types based on the data, or just parse byte[] data inline in your consume loop. At some point you need to do a switch on type, and we decided a standard framework for this was not worth including in the library. Feel free to demonstrate an API you'd like to see if not the above.

Thanks for the suggestion! I'll into and do some thought on an API.

@mhowlett - thanks for the feedback.
Here is where I'm up to. I'm checking internally whether I can put the code up on GitHub. Until that happens if you are interested mail me at<EMAIL_ADDRESS>for details

Extended to Avro specific serializers to work with POCO classes rather than classes generated via avrogen. Also removed the tight coupling between the schema namespace and names and C# classes which will make it easier for developers with their own classes to integrate.
Wrote custom serializer that takes the schema registry subject and version as an input. The subject and version are unrelated to topic and are specified by the developer.
Created consumer and producer that serialize/deserialize outside of the dotnet client.

It isn't production code by any means but seems to work ok in testing so far.

@mhowlett
Am i right in interpreting the position of the confluent-kafka-dotnet team as
"dont use the schema registry in .net if you have multiple types per topic"
if i have misunderstood sorry, but i was hoping we could use the schema registry and get all the schema evolutionary benefits etc.

you can't at the moment. we will add support in the future, quite likely early Q3.

Hi @mhowlett,
Sorry to bang on about this, but I'm rolling out a new product soon and want to try and be as backwards compatible as possible from a serialization point of view.
I'm still not 100% clear on what I should do.
Above you mentioned :
"Not sure exactly what your requirements are, but you could easily write a IDeserializer and return different types based on the data, or just parse byte[] data inline in your consume loop. At some point you need to do a switch on type"
Are you talking about using Avro here ?
My thinking is that I should be using Avro (currently using JSON), but I'm not 100% clear on how I'd manage the deserialization where I have multiple Schemas/Types per Topic.
Is there any pseudocode or a simple example you could point me too ?
I've been looking through the source code, but my Avro knowledge is not great,
Trying to adapt this:
https://github.com/confluentinc/confluent-kafka-dotnet/blob/master/src/Confluent.SchemaRegistry.Serdes/GenericDeserializerImpl.cs#L57
Would I basically in a loop do something like this:
using (var stream = new MemoryStream(array))
using (var reader = new BinaryReader(stream))
{
var writerId = IPAddress.NetworkToHostOrder(reader.ReadInt32());
var writerSchemaJson = await schemaRegistryClient.GetSchemaAsync(writerId).ConfigureAwait(continueOnCapturedContext: false);
var writerSchema = global::Avro.Schema.Parse(writerSchemaJson);
var message = datumReader.Read(default(**object**), new BinaryDecoder(stream));
}

So i'm not sure where I'll be able to cast the message above to the object I want.
I could maybe switch on the object.

switch(message)
{
    case User:
    case Order:
    case Product:
}

Am I going down the right path here ?
Thanks...

@mhowlett
I've got a example running here:
https://github.com/mickdelaney/kafka-spike/
basically the SerDe stuff is here:
https://github.com/mickdelaney/kafka-spike/blob/master/src/Core/Kafka/AvroSubjectNameStrategyDeserializer.cs#L77
https://github.com/mickdelaney/kafka-spike/blob/master/src/Core/Kafka/SubjectNameSerializer.cs#L66
Using:
https://github.com/mickdelaney/kafka-spike/blob/master/src/Core/Kafka/SubjectNameFactory.cs
https://github.com/mickdelaney/kafka-spike/blob/master/src/Core/Kafka/SubjectNameSchemaCache.cs
And Usage Wise Its a Switch On Object.
https://github.com/mickdelaney/kafka-spike/blob/master/src/Core/Domain/Users/UserConsumer.cs#L51

@mhowlett we’ve gone with Avro Unions per topic for now.

@mhowlett  Do you have a timeline for when this feature will be added? My team also needs this functionality for a project we're working on.

@mhowlett  I noticed you said this feature will be available "more likely early Q3".  has this been released already, if not do you have a new timeline? My team also needs this feature for a project we are working on.

sorry, it's not done yet. commonly requested, it's coming.

Hi,
I've also been watching this space, can you forecast a date ?

additional +1 noted

Watching this as well.

#weNeedThisFeature

it'll be in 1.3 for sure. i hope to get it merged to master this week.

@mhowlett thanks for all you great work on this! This was one gap I was hoping to see filled before my company got moving forward with our event driven architecture journey.
I was wondering, will there be any follow up to this on the consumer side to provide something similar to the AvroSubjectNameStrategyDeserializer @mickdelaney built? Something to allow the consumer to deserialize using Avro based on the SubjectNameStrategy? I didn't see any code or issues pointing to this. If I am missing it could please point me in the right direction? Maybe it is easy/possible to do with everything that is currently int he library and I am just not seeing how to piece it together. Any info would be much appreciated!

@mhowlett  I tried this feature with 1.3 RC1 on the consumer side, but still didnt get it working. I was expecting that  I could use something like   .SetValueDeserializer(new AvroDeserializer(schemaRegistry).AsSyncOverAsync()) and then do a type check .
Could you please provide an example of how the consumer can be written to consume multiple events that has different schemas ?

@mhowlett is it an option to implement SpecificDeserializer with a constructor that will take for example HashSet<Avro.Schema>. So it will be the collection of the reader's schemas. Then you could just do something like this:
var readerSchema = _readerSchemas.FirstOrDefault(schema => schema.Name == writerSchema.Name);
It will allow for deserializing multiple event types per topic. Deserializer will return an object type. Then you can perform simple type check
object is %yourType%

it's an option (i think it wouldn't be too hard, you can always write a custom serializer). I'd prefer an API with strong type checking though. I do want to make a producer without type parameters, and here's the reason you might want that on the consumer. You could then perhaps have TryConsume<K,V> methods (and C# can infer the K,V, so they don't need to be specified which is nice). anyway, that's not going to be done imminently. making a custom deserializer as you suggest sounds like a good idea.

additional +1 noted

My team is also looking for this update. Please let us know when this is gonna be released. Thank You!

is there documentation on this feature now that 1.3 is released?

Hi All, I have gone through this post but not able to figure out - how to create a avro schema from a C# class?  - Any help on this.

Hi Pabi,
I did some work on this - see here https://github.com/paddypawprints/schemagen
It uses Roslyn to parse c# and generate an avro schema (or protocol). If you build it the program has a —help option.
It is parked here and I am trying to clean it up to contribute it to the avro project. I’d appreciate any comments you have if this work is interesting to you.
Sent from my iPad
On Dec 23, 2019, at 1:56 AM, Pabi171<EMAIL_ADDRESS>wrote:

Hi All, I have gone through this post but not able to figure out - how to create a avro schema from a C# class? - Any help on this
comments You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/confluentinc/confluent-kafka-dotnet/issues/746?email_source=notifications&email_token=AFCP6V62MNZNU5EYGL5C55LQ2CDOHA5CNFSM4GRDFJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHQXZXQ#issuecomment-568425694, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCP6V7FEJXWEZPIQLIMGFTQ2CDOHANCNFSM4GRDFJ5A.o

thanks for your efforts @paddypawprints - there are various other similar efforts to make a better avro implementation about as well.
i want to note here that protobuf and json support is coming to SR, and i expect to be adding .net client support for this this quarter. These formats are a slight mismatch for the use case, but are close enough and have the benefit of having first class support in .net.

Any update for strategy support for C# client


apk no installed

Information

Apktool Version (apktool -2.5.0) -
Operating System (Windows) -
APK From? (other) -

Stacktrace/Logcat
Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?

Hello
I am modifying the apps of a Chinese android mtk, I managed to do it with several apps and everything turned out fine,
now as soon as I want to modify contacts.apk decompile and compile and sign everything perfect, when installing the apk, I get an app not installed, even without modifying anything, just decompile and compile and I get the same error
Could it be that it has to do with unknown folder that appears when I decompile this apk? because with others it doesn't happen like that.

Information

Apktool Version (apktool -2.5.0) -
Operating System (Windows) -
APK From? (other) -

Stacktrace/Logcat
Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?

Hello
I am modifying the apps of a Chinese android mtk, I managed to do it with several apps and everything turned out fine,
now as soon as I want to modify contacts.apk decompile and compile and sign everything perfect, when installing the apk, I get an app not installed, even without modifying anything, just decompile and compile and I get the same error
Could it be that it has to do with unknown folder that appears when I decompile this apk? because with others it doesn't happen like that.

Information

Apktool Version (apktool -2.5.0) -
Operating System (Windows) -
APK From? (other) -

Stacktrace/Logcat
Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version?

Hello
I am modifying the apps of a Chinese android mtk, I managed to do it with several apps and everything turned out fine,
now as soon as I want to modify contacts.apk decompile and compile and sign everything perfect, when installing the apk, I get an app not installed, even without modifying anything, just decompile and compile and I get the same error
Could it be that it has to do with unknown folder that appears when I decompile this apk? because with others it doesn't happen like that.

@kalmen26 how is this question related to apktool? You tell apktool worked perfectly. This can be seen from the log that you "provided" ;->

@kalmen26 how is this question related to apktool? You tell apktool worked perfectly. This can be seen from the log that you "provided" ;->

Could it be that it has to do with unknown folder that appears when I decompile this apk? because with others it doesn't happen like that.

Well you are entering the world of reverse-engineering and not only that, but recompilation with running on a host device. Who knows what the issue could be. I do know there is not enough to go on here though and borders the line between support and bug.
Closing.

Could it be that it has to do with unknown folder that appears when I decompile this apk? because with others it doesn't happen like that.

Well you are entering the world of reverse-engineering and not only that, but recompilation with running on a host device. Who knows what the issue could be. I do know there is not enough to go on here though and borders the line between support and bug.
Closing.

no, I tell you that if I install the app without decompiling, everything is fine,
but if I decompile and compile again, although I don't modify anything, the app doesn't work,
it means that the problem comes when decompiling and compiling

no, I tell you that if I install the app without decompiling, everything is fine,
but if I decompile and compile again, although I don't modify anything, the app doesn't work,
it means that the problem comes when decompiling and compiling

@kalmen26 I tell you again: apktool is not to blame for the fact that you do not understand the essence of recompiling system applications, system apk from the firmware must retain the original signature, this is achieved by other tools.

@kalmen26 I tell you again: apktool is not to blame for the fact that you do not understand the essence of recompiling system applications, system apk from the firmware must retain the original signature, this is achieved by other tools.

I had to find out and they told me I can fix it this way apktool -c
Does it bother you a lot to help others and say this solution?

I had to find out and they told me I can fix it this way apktool -c
Does it bother you a lot to help others and say this solution?


AWS ini credentials from secret creates blank file

What happened?
I created an aws-creds.ini file and turned it into a k8s secret. I then attempted to use it to create an ECS instance.
Unfortunately I get the following status error:
...
           "lastTransitionTime": "2022-11-09T00:10:23Z",
            "message": "create failed: cannot apply Terraform configuration: creating ec2 instance: unauthorizedoperation: you are not authorized to perform this operation. encoded authorization failure message: hbgzon_jbrgjaaq0_nkv1rsdwvkumeaubxnktgdoiv3dvca2c_h1twi0u0x-2rqqrqs5f7xo5egwrsu2vi_ykna7ywi40ofydvug9rtfsmlytezyosjofw4c3vufvrz8kenj6ipo4nzg6ftfce0jghobmo7qsveiukpg7_hp5wjnvug-dzrh8zs5lelmdptie5wk_l7z9a0q4uf4chfgop55rcp8cz-c37pukx2cja-o-4zfiarzgdwtxiigefqs0ndtht6qibxfty9bwdynirvf4kzef19kze6njcjcviqyi9gqlrzmr_ioeahlbcmuxqwekfskct1pddqx5odvkjcalyaojjizvsr6vce4f6nleodji-v_whza0stukvndt4qn8i6erj6pnysugx0c9nqmlkdgyltgf92yqkakwewiixxl4j475uxndabdvgtd2vjuvq43cw-h2ryqwpn4ckb8cpoutmxfhca9tu5a26cszf8tz27yx7b3olikdq8wqj64xwmqcnwu6jx4jonygfrt_wlbktkburl9p-u8q6pavmqwyl_vfi2rplps9n5icheub2brfruebbbxp6vqobvduab_c1wertowbvzpfps4rz10veqbekpkqyfecba7k--usgcm48rlr_5z8o_ujtk1iwce6nkvajuy9mbwzhu_d5awveluwsdjecuccl18oitr",
            "reason": "ReconcileError",
            "status": "False",
            "type": "Synced"
...

From here I tried to decode the authorization error, but the AWS cli claims the error is corrupted.
I'm guessing this is to do with provider-terraform error handling in some way.
Oh well I thought, and I kubectl exec -it ed into the provider pod.
I then checked into the created aws-creds.ini file and it was empty.
1). Is it possible to better handle the error output so I could decode it?
2). Why is the aws-creds.ini file empty on the provider? I thought maybe it was a placeholder or something, but that doesn't really make sense to me. I'm guessing this is the reason I'm getting the auth error to begin with.
Thank you!!!
How can we reproduce it?
kubectl -n crossplane-system create secret generic aws-creds --from-file=./aws-creds.ini
My AWS provider config is:
apiVersion: tf.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: aws-us-west-2
spec:
  credentials:
  - filename: aws-creds.ini
    source: Secret
    secretRef:
      namespace: crossplane-system
      name: aws-creds
      key: credentials
  configuration: |
      terraform {
        backend "kubernetes" {
          secret_suffix     = "providerconfig-aws-us-west-2"
          namespace         = "crossplane-system"
          in_cluster_config = true
        }
      }
      provider "aws" {
        shared_credentials_files = ["aws-creds.ini"]
        region  = "us-west-2"
      }

and then I created the following workspace
apiVersion: tf.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: aws-us-west-2
spec:
  credentials:
  - filename: aws-creds.ini
    source: Secret
    secretRef:
      namespace: crossplane-system
      name: aws-creds
      key: credentials
  configuration: |
      terraform {
        backend "kubernetes" {
          secret_suffix     = "providerconfig-aws-us-west-2"
          namespace         = "crossplane-system"
          in_cluster_config = true
        }
      }
      provider "aws" {
        shared_credentials_files = ["aws-creds.ini"]
        region  = "us-west-2"
      }

What environment did it happen in?
Crossplane version: crossplane/crossplane:v1.9.0
Running on EKS.
K8s 1.21
OS on client is Mac M1

Hi @rejoshed ,
Seems it is just mismatching keys in the generated Secret.
Looks like you are creating the secret with  --from-file=./aws-creds.ini (which would result in aws-creds.ini key in Secret) but using key: credentials in your ProviderConfig`
--from-file=credentials=./aws-creds.ini should fix the problem.
Please let me know if it helps!

100% that was it. EC2 instance created.
I've been in the k8s ecosystem for >1year now and here's yet another small detail I missed.
Thank you SO much for your quick response.
Not that I have an issue with it now, but do you have any insight into the encode/decode of the error message?

Glad it helped!
On the decoding auth failure message, we have a raw api response from aws cloud here, so it has not much to do with the provider, but might guess would be https://docs.aws.amazon.com/cli/latest/reference/sts/decode-authorization-message.html
Looks like we can close this issue, cheers!


[FEATURE REQUEST ] Create test app for angular 2

Is there a test app for angular 2 in progress? If not, is this something that I could help with? I am waiting a nice example that I can use  my test recorder with for angular 2.
https://github.com/QuantumInformation/test-recorder/blob/master/lib/codeGenerators/

We'll wait until the Angular 2 API is stable (just a few weeks at this point?) before doing this.

Assigning @sjelin who has started working on a test app for ng2

Oh right I forgot.  I'll finish this today probably

@cnishina I've started this but you're going to pick it up on Monday.  The stuff that's left shouldn't bee too hard and I'll help you

This is done!


2.0.0 RTW install links

Review URL 1
Review URL 2
Sorry about the trailing space noise.

@scottaddie  fixed - thanks.


Issue regarding Chinese fonts

I converted it to PDF using Word, but the font is missing after conversion and the display is not normal.

Can you give a example PDF file i can test this with to resolve?

test.docx
This is a Chinese document, converting it to PDF will not display the characters.

Can you give a example PDF file i can test this with to resolve?

I also encountered the same problem. It seems that the technology used has weak support for Chinese. I hope it can be fixed as soon as possible. Thank you so much.

I have same issue with Thai language as well.

I assume you are using docker. Under the directory /usr/share/fonts/opentype/noto/ there should be some fonts. Copy some of your own fonts (Chinese fonts maybe) into that will work. You might need to delete noto and remake the directory first.

I assume you are using docker. Under the directory /usr/share/fonts/opentype/noto/ there should be some fonts. Copy some of your own fonts (Chinese fonts maybe) into that will work. As of issue 974 you might need to delete noto and remake the directory first.

The method has been tested and proven effective. Thank you very much.

I assume you are using docker. Under the directory /usr/share/fonts/opentype/noto/ there should be some fonts. Copy some of your own fonts (Chinese fonts maybe) into that will work. As of issue 974 you might need to delete noto and remake the directory first.

The method has been tested and proven effective. Thank you very much.

May I ask where you found the Chinese font files in the Word document?

I assume you are using docker. Under the directory /usr/share/fonts/opentype/noto/ there should be some fonts. Copy some of your own fonts (Chinese fonts maybe) into that will work. As of issue 974 you might need to delete noto and remake the directory first.

The method has been tested and proven effective. Thank you very much.

Can you share some example fonts? Would love to add this directly to stirling pdf to support

I assume you are using docker. Under the directory /usr/share/fonts/opentype/noto/ there should be some fonts. Copy some of your own fonts (Chinese fonts maybe) into that will work. As of issue 974 you might need to delete noto and remake the directory first.

The method has been tested and proven effective. Thank you very much.

Can you share some example fonts? Would love to add this directly to stirling pdf to support

Of course, I'll pack it for you tomorrow.

May I ask where you found the Chinese font files in the Word document?

Since it's a word document, most likely created through Windows system. You can just copy those fonts being used from your system(C:\Windows\Fonts) into sterling-pdf docker, only for your own use.

Can you share some example fonts? Would love to add this directly to stirling pdf to support

Maybe to check if this or this fits.

Does anyone have a example PDF file i can test with?

I have released a update as well while i wait for test file
If you can try with that

我假设你正在使用 docker。该目录下/usr/share/fonts/opentype/noto/应该有一些字体。复制一些你自己的字体（也许是中文字体）进去就可以了。从问题 974开始，您可能需要noto先删除并重新创建目录。

该方法已经过测试并证明是有效的。非常感谢。

你能分享一些示例字体吗？很想将其直接添加到斯特林 pdf 中以支持

当然，我明天就给你打包。

https://drive.google.com/file/d/1aicHFA-3l32evIN79nmiadZBQNRdEZJz/view?usp=sharing

Does anyone have a example PDF file i can test with?

阿里开发手册 word版阿里开发手册 word版.docx

Does anyone have a example PDF file i can test with?

阿里开发手册 word版阿里开发手册 word版.docx

Seems to work now? :)

I have added chinese now, but will be adding this via some env parameter in future as i cant install all fonts at start due to size issues

I have added chinese now, but will be adding this via some env parameter in future as i cant install all fonts at start due to size issues

adding this via some env parameter is a good idea.

https://github.com/Stirling-Tools/Stirling-PDF/blob/main/exampleYmlFiles/docker-compose-latest.yml#L24
Added a LANGS parameter, this will need to be specified going forward
for example
LANGS: "zh_CN,zh_TW"


NoCompile Tag for optimizers

Is your feature request related to a use case or problem? Please describe.
Certain use cases involve creating gates that should not be optimized.  For instance, if you add spin echoes to an idle qubit to decrease dephasing errors, you do not want a merging optimizers to collapse them down again.  Other benchmarking cases may want this as well.
Describe the solution you'd like
I would like to add a tag (either to cirq-core or to cirq-google) that specifies that compiles should skip this gate.  Perhaps NoOptimizeTag() or something like that.
[optional] Describe alternatives/workarounds you've considered
What is the urgency from your perspective for this issue? Is it blocking important work?
P1 - I need this no later than the next release (end of quarter)
High priority nice-to-have, since it is blocking a nice end-to-end example of combining various optimization techniques together in order to increase fidelity.

I thought this was done as part of https://github.com/quantumlib/Cirq/issues/2642.  It seems like tags were implemented but not NoOptimizeTag().

Hey! I'm new to cirq and I want to create/use a NoOptimizeTag. How should I do it? More specifically, I was hoping to create a cirq equivalent of barriers in qiskit/openqasm, so would there be a way to tag a group of successive operations with a NoOptimizeTag? Thank you!

Created a draft pull request for this issue. Created a nocompile tag and edited the drop_negligible optimizer so as to ignore any gate that has a nocompile tag to it. Need to create test cases for the drop_negligible. Will continue editing the other optimizers as well and create tests for them.

All circuit optimizers have been migrated to the new transformer framework, which supports adding no compile tags for every transformer. I'll therefore mark this as complete and close the issue.


Unable to port a method in flex

I am calling many java side function with remoteObject in my .as and .mxml files they all work fine.
ShmCompanySetup is my module, From where I am calling 7 or 8 Java Methods with Multiple RO's.
In that File first RO is calling faultHandler and all other RO's calling resultHandler.
My Application File: https://paste.apache.org/t3zP
In another project, I have created the same RO with the same function and it calls resultHandler: https://paste.apache.org/uyuX
In my application, I have created this RO in my parent application File shmApplication.as
and set its dataprovider in my module file's advancedDataGrid and it works fine.
I have tried much more to make this RO working by

by removing all other RO's From File except this RO
by removing some components
by changing Responder and token number
but it always calls fault handler
This RO is for setting the values of AdvancedDataGrid,
In my Another Module file same Problem is happening with RO which is setting AdvancedDataGrid values

Does the fault handler report an error?  I think there should be additional information in the error.
You could try examining the bits on the wire with a network monitor and see what is different.
Is the function you are concerned about called "fn_GetCompListDP"?  Make sure it is being called properly.  Looking quickly it appeared there were more references to that function than I would expect.

I was trying through commenting some portion of code and compile it again and again but it always calls faultHandler..
Now when I comment VO classes imports and objects of VO classes it class resultHandler
import com.shm.VO.Common.shmCompanySetupVO;
import com.shm.VO.Common.shmDeliveryLocationSetupVO;
[Bindable] private var voCompany:Object = new shmCompanySetupVO();
[Bindable] private var voDeliveryLocation:Object = new shmDeliveryLocationSetupVO();
dgCompData.selectedItem == null ? fn_ResetPage() : shmUtil.setForm(arrFormItems, voCompany as Object, org.apache.royale.reflection.describeType(shmCompanySetupVO) as XML
I comment out these lines From my mxml file and it works. Why?
Is this was a problem of describeType?

What error is reported in the faultHandler?  I want to make sure you know how to see the error reported or determine that no error is being reported.
I suspect you are getting an error in the AMF code trying to deserialize the server response into your VOs.  Can you confirm you are on the latest version that has @greg-dove improvements?  Then it would be in your interest to learn how to debug that code or maybe @greg-dove will have time to help you.

Just adding a quick comment for now:
org.apache.royale.reflection.describeType(shmCompanySetupVO) as XML
The above will always be null in royale because describeType in royale does not return XML, it returns a TypeDefinition instance (usually) so if this is causing an error somewhere in the result processing it could be the cause of the problem.
Based on descriptions provided ('works in isolated code'), it does not sound like deserialization errors.
The fault handling support in the AMFNetConnection class does tend to swallow error details, so I think this is probably where the information loss is happening for the resulting fault. Or maybe it is faulting from the resulthandler call when it should ignore errors that happen during that. It probably needs some additional work in that part. That would be my guess where things are not working right, so checking the  'reflection' argument processing inside shmUtil.setForm method might be a good start. It should now use royale TypeDefinition instead of XML.
I will be away from my desk a lot this weekend, but I can check back occasionally. If I can help, I will.

We have a method:
https://paste.apache.org/jy56s
We are calling it as : shmUtil.setForm(arrFormItems, voCompany as Object,
org.apache.royale.reflection.describeType(shmCompanySetupVO) as XML);
We have tried it using TypeDefinition Instead of XML. Still the method is not working as before.

When we have changed XML to TypeDefinition in method setForm(...aValueObjInfo:TypeDefinition){.....
for each (var val:TypeDefinition in aValueObjInfo..variable)
...}
I got a compile time Error  as ..variable property not exist in TypeDefinition:
Access of possibly undefined property variable through a reference with static type TypeDefinition.
[java]
[java]                                     for each (var val:TypeDefinition in aValueObjInfo..variable)
Kindly Help us to Port this method. As we are using this method in our whole Application in every file.
Thanks in Advance

Created a separate issue for Unable to port a flex method: https://github.com/apache/royale-asjs/issues/438


feat: rename namespaces and provide aliases

Addresses #692:

Adds namespaces, removes underscores
Adds autoloading for namespaces
Flattens directories for PSR-4

Backwards-compatibility concerns
BC is preserved using aliases.php. This loads the (minimal) 20 classes in this library upfront and creates aliases for them.
Another option is to define a custom autoload.php which lazy-loads the Google_ classes as they're requested:
// src/autoload.php
$classMap = [
    'Google_Client' => 'Google\Client',
    // ...
];

spl_autoload_register(function ($class) use ($classMap) {
    if (isset($classMap[$class])) {
        class_alias($classMap[$class], $class);
        return true;
    }
});

The problem with this is the autoload.php function is invoked on every class-exists. Which is preferred? Tell me your thoughts in the comment section and don't forget to smash that "subscribe" button!
Note: this is independent of google/apiclient-services

I think I have a small preference for the aliases.php file over an autoloader, but it may be because it already exists.

@jdpedrie I think it makes things easier and simpler to autoload aliases.php up front than to mess with an autoloader. The number of classes is small enough that it's unlikely to have a noticeable impact.


Stop the baseURL config property from being overridden

Ember app authors can currently specify a baseURL in the config/environment.js file. e.g.
ENV['ember-simple-auth'].baseURL = 'http://localhost:4200';

However, the configuration is being overridden because of the following line in the app/initializers/ember-simple-auth.js file:
const config   = ENV['ember-simple-auth'] || {};
config.baseURL = ENV.baseURL;

This simple patch removes the overriding expression so that the author's baseURL can be used.

👍🏻
This removes the default though, thus would be a breaking change.

This removes the default though, thus would be a breaking change.
Ah, I assumed you got the default was hardcoded. I have uploaded a corrected patch that falls back to ENV.baseURL if the baseURL config isn't present.

I'm not sure how that is different from the original code now.

I'm not sure how that is different from the original code now.

So there are two places where base URLs are being stored in the config/environment.js file. We have ENV.baseURL and we have ENV['ember-simple-auth'].baseURL. The former stores a base URL used by Ember.js and the latter stores a base URL specific to this library.
With the way it worked in the original code, even if you set a value for ENV['ember-simple-auth'].baseURL, it was being overridden.

Ah sure, I see. So I guess what we want is this?
const config   = ENV['ember-simple-auth'] || {};
config.baseURL = config.baseURL || ENV.baseURL;

That seems much simpler. I've updated the patch.

Sorry - just realized the version that's on master is actually correct. The baseURL property in Ember Simple Auth's configuration object is actually private API and only used to track the baseURL as configured for the complete application in config/environment.js.


Periodogram Wishlist

Would like the frequencies of the LSP peaks to returned as well as the power and frequencies.
Just like I can do lcs[0].periodogram or lcs[0].periodogram_freqs, would love to do lcs[0].periodogram_peaks
Also include the FAP and a yellow horizontal line for the FAP (see Tobin for code)

So you want the peak frequencies stored directly in the class rather than in the stats dictionary? (They are stored in lc.stats["peak_freqs"] atm)

Yeah. It would be nice if it was part of the class like the periodogram and periodogram_freqs, just for simplicity in using. SO the options could then be, periodogram, periodogram_freqs, and periodogram_peaks

On Mar 30, 2023, at 1:58 PM, Tom Wagg @.***> wrote:
So you want the peak frequencies stored directly in the class rather than in the stats dictionary? (They are stored in lc.stats["peak_freqs"] atm)
—
Reply to this email directly, view it on GitHub https://github.com/tobin-wainer/elk/issues/66#issuecomment-1490949801, or unsubscribe https://github.com/notifications/unsubscribe-auth/APVBO6OUDKC4N4EKYAYI5W3W6XXVZANCNFSM6AAAAAAWMRS4VU.
You are receiving this because you were assigned.


Separate dev build

Hi @una,
Currently, compiled files needs to be removed manually whenever:

pushing to github (to keep the PRs clean)
switching between branches

One approach to solve this problem would be to keep a separate folder for compiled files in local development, and there will be 2 gulp tasks:

gulp - can be run on any branch

This generates a .dev folder, which serves as local dev server root

`scss/twig` compiled files will be generated inside this folder.

`test/`, `img/`, `filters.json` will also be copied to this

This folder will be added in `.gitignore`

so none of the compiled files appear in git status. PRs will contain only changed files.

gulp build - run only in master
This does compilations and places the generated files in the same place as current directory structure.

What do you think?

This is definitely a good idea :) Thanks for the suggestion/diagram

Fixed in #242


fix negative gps coordinates pack error

When testing the degToDmsRational and dmsRationalToDeg function with negative GPS coordinates, I stumbled upon an error :
The DMS format isn't supposed to have negative values, resulting in an error when dumping the exif (inside the pack() call of the _dict_to_bytes() function)
To fix this I made sure to use the absolute value of the GPS coordinates inside the degToDmsRational function, and updated dmsRationalToDeg to comply with the changes.

Thanks!


store-button-windows-white

Is there any problem with the commit?
@RavindraP04 guide me, I will change it as per requirement.

@SHYALI just remove the outermost div

@RavindraP04 updated!

From next PR just mention this
closes #id_of_Issue
By this way the issue will be automatically closed once the PR has been merged

okay ,sure


update IdentifyPodOS as it is removed

removed in https://github.com/kubernetes/kubernetes/pull/114410
kep in https://github.com/kubernetes/enhancements/issues/2802

/cc @ravisantoshgudimetla

Thanks.
/approve

thanks, @pacoxu for the PR.
/lgtm


Dream2Nix not creating bin (Electron)

I was working on an Electron project with a friend and was trying to get it set up on NixOS.
When I tried to build the project using dream2nix with nix build, a result file was created, but there was no bin file.
I considered that it might have something to do with how my project is organized, so I can link you to it if you need to see it (or you can find it on my GitHub).
In any case, please let me know of what I can do to fix it. Let me know if you have any questions.

After further investigation, I found that dream2nix was not putting any packages in the node_modules directory when I ran nix build. This is probably the reason why no binary is being created, but I still don't know how to get dream2nix to get my required node packages.


Zanecodes ssl

Description
This change allows Chef services and omnibus cookbooks to be configured to use SSL to connect to the PostgreSQL database. This is necessary when using Azure Database for PostgreSQL as an external database securely, without disabling Enforce SSL.
This change will not actually work until https://github.com/chef/chef_secrets/pull/27 is merged and the dependency is updated here.
We would like to thank zanecodes and Relativity for their contribution to this effort:
https://github.com/chef/chef-server/pull/1632
Issues Resolved
https://github.com/chef/chef-server/issues/1559
Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/326#c10ee4c4-1cea-414a-91e1-ca48e11084ec

``postgres=# select * from pg_stat_ssl;
pid  | ssl | version |           cipher            | bits | compression | clientdn
-------+-----+---------+-----------------------------+------+-------------+----------
19543 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19544 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19545 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19546 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19547 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19548 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19549 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19550 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19551 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19552 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19597 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19598 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19599 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19600 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19601 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19602 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19603 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19604 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19605 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19606 | t   | TLSv1.2 | ECDHE-RSA-AES256-GCM-SHA384 |  256 | f           |
19620 | f   |         |                             |      |             |
(21 rows)

Aside from the other comments, I notice we've not updated the rebar.lock files for the other erlang tools (mover, bookshelf, bifrost); we need to make sure that they are using the latest chef secrets too.

Done.


Confirmation popup to cancel upload says "English English"

Steps:

Launch the upload of a file
While the file is uploading, tap the pause button.
Tap the x button to delete the upload.
Popup has wrong title and message:

Same popup appears for failed uploads.

Hi, I would like to try to reach out this issue if it's possible : )

@Junan-YU Any progrerss on this? :-)

@Junan-YU Any progrerss on this? :-)

Yeah I was trying to see if this problem happens for other languages version, and maybe the error message pop up logic: : -)

@Junan-YU Any progrerss on this? :-)

Yeah I was trying to see if this problem happens for other languages version, and maybe the error message pop up logic: : -)

By the way this is my another account

Can you share what is the language you use? since the cancelling upload does not appear to be wrong in my devices.

OS, app, UI, descriptions all in English
https://github.com/commons-app/apps-android-commons/assets/99590/ddf3e8a1-5740-47dd-9568-ff6b4bc2704c

Apologies @Junan-YU this issue got fixed outside of the usual workflow, as it was prioritized for the upcoming release (#5308). Would you mind finding another issue? Thanks for your understanding!

Apologies @Junan-YU this issue got fixed outside of the usual workflow, as it was prioritized for the upcoming release (#5308). Would you mind finding another issue? Thanks for your understanding!

Sure I will find another issue to work on, apologise for not fixing this issue quickly.


newbie

hi, i'm seeking poor man's alternative way to install this since i use free cloud based (ie cloud9, sourceLair) services or remote machine owned by someone else. In all these cases I cant do a global install. Also most aren't using the latest version of node (10.4) or npm (2.6).  Can I install and run it locally, say using git? thanks, i'm really anxious to start studing and using this. brian

You should be able to do a local install, as long as you can modify your $PATH to include ./node_modules/.bin. Note that the CLI commands will then only work in the root directory of your project.

great, thanks for your quick response. what about the issue of node and npm
versions? what is the minimum required.
On Thu, Nov 19, 2015 at 12:20 PM, Viktor Charypar<EMAIL_ADDRESS>wrote:

You should be able to do a local install, as long as you can modify your
$PATH to include ./node_modules/.bin. Note that the CLI commands will
then only work in the root directory of your project.
—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158125708.

I am not really sure to be honest. We should support node 10 just fine and npm version shouldn't matter at all, but I can't promise it will work. Don't think we ever tried.
I would definitely be interested in how it went when you try.

Viktor,
These are error messages from two failed attempts using npm to install it
locally
http://pastebin.com/0EiTcTcD
node 10.29 debian
http://pastebin.com/UknsuXT9
node 10.40 ubuntu
On Thu, Nov 19, 2015 at 12:32 PM, Viktor Charypar<EMAIL_ADDRESS>wrote:

I am not really sure to be honest. We should support node 10 just fine and
npm version shouldn't matter at all, but I can't promise it will work.
Don't think we ever tried.
I would definitely be interested in how it went when you try.
—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158129362.

I did have it running globally on one system, but the admin took it all
down because i'm not supposed to run globally.
on another system, I got this far and then it wouldn't run. (also how to
you change the port number from something other than 3000)
Your Arch app has been generated! Use 'arch-cli s'  to run it.
brw314:~/workspace $
brw314:~/workspace $ arch-cli s
module.js:340
throw err;
^
Error: Cannot find module
'/home/ubuntu/workspace/node_modules/arch/package.json'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at startServer
(/home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:45:13)
at init (/home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:37:3)
at /home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:123:14
at Object.cb [as oncomplete] (fs.js:168:19)
brw314:~/workspace $
On Thu, Nov 19, 2015 at 4:07 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

Viktor,
These are error messages from two failed attempts using npm to install it
locally
http://pastebin.com/0EiTcTcD
node 10.29 debian
http://pastebin.com/UknsuXT9
node 10.40 ubuntu
On Thu, Nov 19, 2015 at 12:32 PM, Viktor Charypar <
<EMAIL_ADDRESS>wrote:

I am not really sure to be honest. We should support node 10 just fine
and npm version shouldn't matter at all, but I can't promise it will work.
Don't think we ever tried.
I would definitely be interested in how it went when you try.
—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158129362.

regarding the last error package.json is in the highest level dir
(/workspace), not where its looking (node_modules/arch/)
On Thu, Nov 19, 2015 at 5:09 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

I did have it running globally on one system, but the admin took it all
down because i'm not supposed to run globally.
on another system, I got this far and then it wouldn't run. (also how to
you change the port number from something other than 3000)
Your Arch app has been generated! Use 'arch-cli s'  to run it.
brw314:~/workspace $
brw314:~/workspace $ arch-cli s
module.js:340
throw err;
^
Error: Cannot find module
'/home/ubuntu/workspace/node_modules/arch/package.json'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at startServer
(/home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:45:13)
at init (/home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:37
:3)
at /home/ubuntu/workspace/node_modules/arch-cli/lib/serve.ls:123:14
at Object.cb [as oncomplete] (fs.js:168:19)
brw314:~/workspace $
On Thu, Nov 19, 2015 at 4:07 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

Viktor,
These are error messages from two failed attempts using npm to install it
locally
http://pastebin.com/0EiTcTcD
node 10.29 debian
http://pastebin.com/UknsuXT9
node 10.40 ubuntu
On Thu, Nov 19, 2015 at 12:32 PM, Viktor Charypar <
<EMAIL_ADDRESS>wrote:

I am not really sure to be honest. We should support node 10 just fine
and npm version shouldn't matter at all, but I can't promise it will work.
Don't think we ever tried.
I would definitely be interested in how it went when you try.
—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158129362.

You can change the port with the ARCH_PORT  environment variable I believe.
Not sure about the other error. @tabazevedo any ideas?

@brw31415 looking through your log it seems you have a problem with your node installation and its telling you to run
echo "export NODE_PATH=$NODE_PATH:/nix/store/a5ibcbcsm473kdr75kj4gpsr28ndnknp-nodejs-0.10.26/lib/node_modules" >> ~/.bashrc && source ~/.bashrc

Hi Victor,
I just thought I'd send you this link regarding problems with npm.
On Thu, Nov 19, 2015 at 5:20 PM, Tiago Azevedo<EMAIL_ADDRESS>wrote:

@brw31415 https://github.com/brw31415 looking through your log it seems
you have a problem with your node installation and its telling you to run
echo "export
NODE_PATH=$NODE_PATH:/nix/store/a5ibcbcsm473kdr75kj4gpsr28ndnknp-nodejs-0.10.26/lib/node_modules"

~/.bashrc && source ~/.bashrc

—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158218628.

http://www.sitepoint.com/solve-global-npm-module-dependency-problem/
On Sat, Nov 21, 2015 at 2:57 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

Hi Victor,
I just thought I'd send you this link regarding problems with npm.
On Thu, Nov 19, 2015 at 5:20 PM, Tiago Azevedo<EMAIL_ADDRESS>wrote:

@brw31415 https://github.com/brw31415 looking through your log it
seems you have a problem with your node installation and its telling you to
run
echo "export
NODE_PATH=$NODE_PATH:/nix/store/a5ibcbcsm473kdr75kj4gpsr28ndnknp-nodejs-0.10.26/lib/node_modules"

~/.bashrc && source ~/.bashrc

—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158218628.

hi still having some install issues:
on debian jesse , node v5.0 npm
3.3.6everything seems to work fine until:
identical app/routes/welcome.ls
npm WARN install Couldn't install optional dependency: Unsupported
npm ERR! Linux 4.1.0-insomnia247
npm ERR! argv "/home/brw314/.nvm/v5.0.0/bin/node"
"/home/brw314/.nvm/v5.0.0/bin/npm" "install"
npm ERR! node v5.0.0
npm ERR! npm  v3.3.6
                              npm ERR! Cannot read property

'localeCompare' of undefined
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
                              npm ERR! Please include the

following file with any support request:
npm ERR!     /home/brw314/npm-debug.log
Your Arch app has been generated! Use 'arch-cli s'  to run it.
brw314@Lydia:~/arch5$ arch-cli s
module.js:339
throw err;
^
                              Error: Cannot find module

'/home/brw314/arch5/node_modules/arch/package.json'
at Function.Module._resolveFilename (module.js:337:15)
at Function.Module._load (module.js:287:25)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at startServer
(/home/brw314/.nvm/v5.0.0/lib/node_modules/arch-cli/lib/serve.ls:45:13)
at init (/home/brw314/.nvm/v5.0.0/lib/node_modules/arch-cli/lib/serve.ls:37:3)
at /home/brw314/.nvm/v5.0.0/lib/node_modules/arch-cli/lib/serve.ls:123:14
at FSReqWrap.cb [as oncomplete] (fs.js:216:19)
brw314@Lydia:~/arch5$
On Sat, Nov 21, 2015 at 3:11 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

http://www.sitepoint.com/solve-global-npm-module-dependency-problem/
On Sat, Nov 21, 2015 at 2:57 PM, Brian Wolf<EMAIL_ADDRESS>wrote:

Hi Victor,
I just thought I'd send you this link regarding problems with npm.
On Thu, Nov 19, 2015 at 5:20 PM, Tiago Azevedo<EMAIL_ADDRESS>wrote:

@brw31415 https://github.com/brw31415 looking through your log it
seems you have a problem with your node installation and its telling you to
run
echo "export
NODE_PATH=$NODE_PATH:/nix/store/a5ibcbcsm473kdr75kj4gpsr28ndnknp-nodejs-0.10.26/lib/node_modules"

~/.bashrc && source ~/.bashrc

—
Reply to this email directly or view it on GitHub
https://github.com/arch-js/arch/issues/102#issuecomment-158218628.


Crystal tool implementations for search macro definition is not works?

I knew this feature from the blog https://crystal-lang.org/2015/09/05/tools.html write by @bcardiff
following is a screenshot from that blog, it really useful for find the definition of a macro.

But for current version: (1.6.0 dev), use same source code.
class Person
  property name : String = ""
end

p = Person.new
p.name = "John" # put the cursor in over #name= call

The same feature not works anymore.
 ╰─ $ crystal tool implementations --cursor 1.cr:6:4 1.cr
1 implementation found
/home/zw963/Crystal/play/1.cr:2:3
 ~> macro property: expanded macro: macro_139795436169408:640:13

The output of
expanded macro: macro_139795436169408:640:13

is really not so useful for find the definition of property macro, because what we expected is a file path for the source code as it works when this blog was posted, not  macro_139795436169408:640:13, breaking changes?
discuss on https://forum.crystal-lang.org/t/crystal-tool-implementations-for-search-definition-of-macro-is-not-works/4950 too.
cc @beta-ziliani

There's no bug. The property macro is defined inside an inline macro.
Take a look at this code:
class Person
  {% begin %}
    macro foo
      def one
        1
      end
    end
  {% end %}

  foo
end

p = Person.new
p.one

The output for the implementations of p.one is this:
$ crystal tool implementations --cursor foo.cr:14:4 foo.cr
1 implementation found
/Users/aryborenszweig/Projects/crystal/foo.cr:10:3
 ~> macro foo: expanded macro: macro_4321658736:3:7

It points to 10:3 (the call to foo) and then 3:7, which is where macro foo is defined, inside the {% begin %} block. There's no way to name that, so it gets a random name like macro_{some_number}.

Would some sort of recursive expansion make sense? macro_4321658736 is not very useful in tracking down what is going on, after all.

There's no old behavior. The property macro was written in a different way at that time. It wasn't defined using another macro.

I think the issue is that with a nested macro it's not pointing at the def.
In this example, the last node points at the def (3:5)
class Person
  macro prop(name)
    def {{name.id}}=(arg)
       @name = arg
    end
  end

  prop name

  def initialize(@name : String)
  end
end

Output:
person.cr:8:3
 ~> macro prop: person.cr:3:5

While in this example, the last node misses the filename and do not points at the def:
class Person
  macro macros
    macro prop(name)
      def \{{name.id}}=(arg)
        @name = arg
      end
    end
  end

  macros
  prop name

  def initialize(@name : String)
  end
end

Output:
person.cr:11:3
 ~> macro prop: expanded macro: macros:2:7

I think a preferred output could be:
person.cr:11:3
 ~> expanded macro macros: person.cr:2:3
 ~> macro prop: person.cr:4:7

(maybe the expanded is redundant)


icon missaligment in message fix

I've just noticed the same issue as described here (https://github.com/thaw-ui/thaw/issues/190) and tracked it down to tailwindcss.  In the output.css generated by it we have:
/*
1. Make replaced elements `display: block` by default. (https://github.com/mozdevs/cssremedy/issues/14)
2. Add `vertical-align: middle` to align replaced elements more sensibly by default. (https://github.com/jensimmons/cssremedy/issues/14#issuecomment-634934210)
   This can trigger a poorly considered lint error in some tools but is included by design.
*/

img,
svg,
video,
canvas,
audio,
iframe,
embed,
object {
  display: block;
  /* 1 */
  vertical-align: middle;
  /* 2 */
}

Your recent change sets the display to inline-block (https://github.com/thaw-ui/thaw/commit/983e85728a21f0443f1ef0eb02b5da81c54b5ed4) and this collides with the 'vertical-align' set by tailwindcss.
Changing the vertical-align property to 'top' fixes the misalignment so I think the simplest fix is to add 'vertical-align: top' to icon.css. I don't see it affecting anything else so it should be safe.

I feel it would be better to set vertical-align to the default value baseline, or to add a display: flex to the thaw-message__icon class to solve this problem.

Hi, changed as you suggested. Tested and it's working.

thanks


Some SVGs are partially broken

I've been looking for a library to convert dxf floor plans to svg or pdf. Your project is the only one I've found that almost works and that does not cost a fortune.
Unfortunately, some of the converted files have artifacts like for example a big black ellipse or a big grey rectangle in it.
Any help appreciated.

You will have to send me the files... can send it to me privately if you don't want them shared

I've had a look. It's a "stroke-width" issue.
There are some inserts that are scaled and I think the line widths are multiplied by 1000 as the insert has a 1000x scale factor.
The exported SVG created by this lib just uses stroke-width="0.1%" which seems to work for most cases but not for these DXF files.
There is no proper support for line width as defined by the layers in this library, although I don't think that's the issue.
I'm not using this lib for work anymore so unfortunately I don't have the time/income to implement a proper solution and figure out the scaling issue. Happy to accept and test a pull request from someone who wants to add support.

Thanks. 🙂  It was easy to improve the result by just setting all the big scale factors in the dxf file to 1 before using your lib. Maybe I'll look for a better solution later but I'm not that good with Javascript.


Suggestion: resolve same country in other language if nothing else matches

Hello, thank you for this library. I just have a suggestion for an additional (maybe optional) MatchType:
When all other MatchTypes have found nothing and the current implementation would return the defaultLocale, attempt the following match:

Only look at the country codes. What is the highest quality country code that is also a country code in one of the supported locales?
Return the first supported locale with that country code

This MatchType would basically be the same as the already implemented "relatedLocaleBased", just for countries instead of languages. The idea behind it is that if no language matches, it would be better to at least stay in the country you're accepting instead of using the default locale which is not in your language and probably also not your country.
Example:

the user only accepts "af-ZA"
the default locale is "en-US"
none of the supported locales support the language "af", but one of those locales is "en-ZA"

With this new MatchType, the user would receive "en-ZA", which is a better match for them than the default "en-US" because at least the country would still match their preference.

Thank you.
What if en-ZA is not one of those locale but zu-ZA (Zulu) is instead. And the person only speaks af-ZA (African) and English (they don't know Zulu). If we pick zu-ZA they won't be able to understand the page's content. But if we would have defaulted to English then this would not be a problem.
Of course this is very speculative because most likely the person would have the correct setting in their OS/Browser and we would be able to match them correctly.
I did consider doing country fallback in the original implementation but I think my thought at that point was that the country didn't make much of a different if you cannot speak the language.
Thinking more about this now, I can see some benefits doing country fallback. Let's say we use zu-ZA as default instead of en-US - most browsers offer page translations - and if this is done then the page's translation would be closer to an af-ZA (quality might vary depending on language pairs). But the main difference is that currency and data formats would be from South Africa instead of from the US.
But one thing to also consider if that often the quality of the default language is better than the translations... so there is a benefit to this as well if the primary goal it to make sure that the end user understand the content without adding a layer of translation + machine translation on top which could definitely lower the quality.
I'll think about it a bit more but like you suggested, maybe adding this as an optional match since it's a bit more speculative than the other matches.

Hi, just responding to that first point:

What if en-ZA is not one of those locales, but zu-ZA (Zulu) is instead? And the person only speaks af-ZA (Afrikaans) and English (they don't know Zulu). If we pick zu-ZA, they won't be able to understand the page's content. But if we had defaulted to English, then this would not be a problem.

If we actually knew that they accept english then some "en" locale would've already matched before this new MatchType comes into play. So this scenario can only happen if neither english nor zulu is at all part of the Accept-Language header. In which case it's pure speculation that it would be more likely that they understand english than zulu. Of course, much more people in the world speak english than zulu, however:

we already know that the user accepts a locale with country South Africa, so in this case the world-wide statistic of english-speakers vs. zulu-speakers wouldn't really matter, what would matter would be the statistic for South African english-speakers vs. zulu-speakers. And, if you look at https://en.wikipedia.org/wiki/Languages_of_South_Africa , it seems like zulu is a more common native language in South Africa than english (and if it isn't, doesn't matter, it's just an example). Therefore, in this random example, it would actually be better to match zu-ZA instead of en-US because the country matches better and the language also has a higher chance of fitting since it's another language of the preferred country, instead of just some random default language that the user doesn't have any direct connection to
the default language can just as well not be english. If I have a swedish company that creates their content in swedish before translating it to english, and an american user that for some reason has their Accept-Language only set to "es-US" visits my site, in that scenario it would clearly be better for the visitor to see "en-US" instead of the original swedish website.

@L3444 just released version 3.1.0, which I believe will cover your suggestion in this issue. Basically, I ended up adding 2 new match types:

Language Country Match: looks for a locale that matches the default locale's language but in a country from a locale specified in a directive. This one applies all the time and improves the previous default behavior, in my opinion. The main thinking is that the quality of the match should be similar to the default locale, but the experience might be improved because of the country-specific formats (date, currency, etc.).
Country Match: looks for a locale that matches the country in the next round of directives. This one requires the following option to be enabled: { matchCountry: true }.

I updated the README explaining the new option and why it's not enabled by default.
I'm going to close this issue for now since I believe it is complete, but please let me know if you have any feedback or comments.
Thanks again for your great suggestion.


want to add a email option in footer section with logo.

i want to ad a email option in the footer section of the home page and on hovering it shows color like you other icons and on click it redirect user to the email compose page.

Hello Bio Branch Team ,
My name is Ishan, and I am a BTech student with experience in full-stack development. I would love to contribute to your project. Here is my LinkedIn profile: https://www.linkedin.com/in/ishanguptaofficial/.
Could you please assign me to this issue? Looking forward to your response.
Best regards,
Ishan

assign it to ishan gupta .

Hello Bio Branch Team ,
My name is Ishan, and I am a BTech student with experience in full-stack development. I would love to contribute to your project. Here is my LinkedIn profile: https://www.linkedin.com/in/ishanguptaofficial/.
Could you please assign me to this issue? Looking forward to your response.
Best regards, Ishan

Hey do not spam in our project. Other wise i will remove. Do not write spam signature comment to every issues

Hey @ritikm31
I’d like to add an email option in the footer section of the homepage. On hover, it should change color like the other icons, and when clicked, it should redirect users to the email compose page.
Let me know if you need any assistance with this!
Thanks!

ok


feat(Topology/Instances): the only closed subfield of the field of real numbers is the real numbers itself

This PR contains the result that the only closed subfield of the field of real numbers is the field of real numbers itself.
Split off from the larger PR #13577.

Thanks!
bors merge


Use url_unquote_plus in WSGIRequestHandler

Use url_unquote_plus in WSGIRequestHandler to interpret unquoted plus sign as a space and quoted plus sign %2B as a literal plus sign

The +-sign is only special inside the query, not the path. If there's sufficient evidence that nobody cares about this, maybe we can make an exception, but I'd get the bugs fixed somewhere else rather than working around them in Werkzeug.


{% page_header_buttons %} crashes when used due to typo in the first line

Issue Summary
The {% page_header_buttons %} template tag from wagtailadmin_tags crashes when used.
Steps to Reproduce

Put {% page_header_buttons None None %} anywhere in a template that includes {% load wagtailadmin_tags %}. Any other arguments work, too, as the crash happens before they get used.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details
The problem is that the first line of code is
    next_url = context.request.path

It should instead be:
    next_url = context["request"].path

@gasman fixed a similar issue with the {% page_listing_buttons %} template tag last month, as part of #10592.
I submitted #10731 as a fix.

Can confirm this issue exists and also our usage of context.request.* appears to be the issue.


Fix annotations links using github.com even for GHES

There are few locations were github.com is hardcoded, making it incompatible with github enterprise servers that are hosted on other domains.
From what I understood from these code lines, they are only cosmetic (sent as annotations in deployments).
https://github.com/Azure/k8s-deploy/blob/507f2d4fc713cdc92f96880e350464687ce2e960/src/utilities/workflowAnnotationUtils.ts#L24
https://github.com/Azure/k8s-deploy/blob/ca8d2604acf262265b6640fc4de4e060effbb555/src/utilities/githubUtils.ts#L47
There is GITHUB_SERVER_URL env var and some others to get the server domain.

Closed with #200 and action has been released. v4 (v4.1+) has this fix. Thanks!

@OliverMKing the pull request #200 that i've opened is about api calls sent to github.com. This issue is about cosmetic links shown to the user. I don't see any correction yet in the repo.


Programmatic definition of entries (alternatively to import.meta.glob)

Is your feature request related to a problem? Please describe.
Using import.meta.glob to tell Vite what the entries are (server-side entry, client-side entry, client-side entries for each page of an SSR app, etc.) has limitations.
For example bug #1985 (import.meta.glob searches in dist/), but also glob patterns are inherently limiting.
Glob patterns are limiting
I'm building vite-plugin-ssr and the user can have following file structure:
/users/Login.page.vue
/users/UserProfile.page.vue
/purchases/BuyProduct.page.vue
/purchases/BuyProduct.client.vue

Where each **/*.page.vue file defines a page. Similarly to Next.js, but **/*.page.vue instead of /pages/*.vue. (Giving the user more flexibility, for example to organize her files in a domain-driven fashion.)
Note the file /purchases/BuyProduct.client.vue with the suffix **/*.client.* which defines the client-side entry of /purchases/BuyProduct.page.vue. (This technique allows the user to fully control the browser-side code on a page-by-page basis.)
A problem with glob patterns here is that it will eventually lead to conflicts: for example, React Server Components will introduce new suffixes .client.js and .server.js which will be in conflict with vite-plugin-ssr's suffixes.
Describe the solution you'd like
If one could programmatically define entries, the aforementioned problems could easily be solved. For example:
// vite.config.js

export default {
  // Vite provides the list of all user files, which the user (or the plugin author)
  // can use to define entries:
  entries: (files) => {
    // We first get all `**/*.page.*` entries
    const pageEntries = files.filter(
      (file) => file.spit(".").includes("page")
      // We can filter more things here, such as `**/dist/**` files.
    );

    // Then we get all `**/*.client.*` entries
    // *But* only those that have the same file base name than a `*.page.*` file.
    const clientEntries = [];
    for (const pageEntry of pageEntries) {
      const clientEntry = pageEntry.replace(".page.", ".client.");
      if (files.includes(clientEntry)) {
        clientEntries.push(clientEntry);
      }
    }

    return [...pageEntries, ...clientEntries];
  },
};

This has the advantage that for this file structure
/purchases/BuyProduct.page.jsx
/purchases/BuyProduct.client.jsx
/purchases/views/PurchaseForm.client.jsx

the file /purchases/views/PurchaseForm.client.jsx is not defined as an entry even though it has the suffix .client.jsx (it is a React Client Component). This is not possible to achieve with glob patterns.
I'm guessing that Vite already has a scanning mechanism to list all user files (I've seen that Vite uses chokidar and Vite does HMR new files); my idea here is to make this list available to the user, so that the user (or plugin author) can programmatically define entries.
Programmatically-defined entries have several implications. For example, unlike import.meta.glob, programmatically-defined entries are not statically analysable so there is no static dependency tree between entries. I see problematic implications but AFAICT they are all solvable.
In general, being able to define entries in a programmatic fashion would be both convenient and powerful.

I don't know what you expect entries to do here - there is no concept of "entries" for Vite during serve, the entry is the HTML (which then links to JS files via <script>). I also don't know why you'd have an entry for each page - it seems there's a lot of missing context here.
The pattern does support advanced syntax so you should be able to match between client/server entries.

Neat, Extglob is actuallly exactly what I needed and it solves my problems.


comments in URL class are incorrect

What is the purpose of the change
correct the comments in URL class
Brief changelog
the protocol description for file url is incorrect
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #1520 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   31.61%   31.56%   -0.05%
==========================================
  Files         682      682
  Lines       33035    33035
  Branches     6592     6592
==========================================
- Hits        10445    10429      -16
- Misses      20736    20749      +13
- Partials     1854     1857       +3

Impacted Files
Coverage Δ

...on/src/main/java/com/alibaba/dubbo/common/URL.java
25.03% <ø> (ø)
:arrow_up:

...ba/dubbo/remoting/transport/netty/NettyClient.java
72.58% <0%> (-11.3%)
:arrow_down:

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
77.77% <0%> (-11.12%)
:arrow_down:

...libaba/com/caucho/hessian/util/IdentityIntMap.java
25% <0%> (-5.96%)
:arrow_down:

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
73.14% <0%> (-2.78%)
:arrow_down:

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
54.54% <0%> (-2.03%)
:arrow_down:

...bo/remoting/transport/netty/NettyCodecAdapter.java
55.22% <0%> (-1.5%)
:arrow_down:

...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java
63.07% <0%> (+3.07%)
:arrow_up:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
50% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8884e...a1779d5. Read the comment docs.

Looks good to me!
Thanks for the PR!


fix(generate/service): creation output appears twice

Running
ng g service contacts-service

Generates the following output
$ ng g service contacts-service
Could not find watchman, falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
installing service
  create src/app/services/contacts-service/contacts-service.spec.ts
  create src/app/services/contacts-service/contacts-service.ts
  create src/app/services/contacts-service/contacts-service.spec.ts
  create src/app/services/contacts-service/contacts-service.ts

Not sure if it in fact creates the service + spec file twice, or if it just logs twice. If the former, then ofc the second call will override the first one, so the resulting files are okay.
However, I think this needs to be fixed.

Was this with version 0.0.26 or 0.0.27? I have not been able to reproduce locally. The concept of a services directory has been deprecated and should not created unless you specified you wanted it created there.

Closing as I have not been able to reproduce this.
@PascalPrecht if you are still seeing this, it may possibly be due to you having the CLI npm linked and globally installed? Try that fix and if that doesn't work, reopen and we can re-investigate.


Time controller has bias against old neurons

The default value for non-estimated functions is 0 sec, which gives an advantage for the neurons that have never estimated that function.

So that problem will be solved by introducing EMA with a hot start instead of vanilla EMA (more info) + shifting time feedback for rarely called functions toward neutral. Shifting is done with function tanh(num_calls/10


wip: trying to throw a helpful error

If you don't have AES_KEY and AES_KEY_ID set, the encrypt method fails.
It took me quite a long time to figure this out as a new developer so I think a helpful error message here goes a long way.
I can't seem to get my test to pass even when I pass in the keys in the command line like this:
AES_KEY=Testing123456789Testing123456789 AES_KEY_ID=xxx-xxx-xxx-xxx-xxx jest /Users/jon/Code/lefthook/frigg/packages/encrypt/Cryptor.test.js
I need some help to get this merged 😄

Honestly, maybe AES configuration should not be a part of frigg? I think there can be other ways to encrypt a key without adding the AES dependency?


Adds an es6 version to dist

For https://github.com/emberjs/ember.js/issues/10269

:+1:

Released in v0.1.5


Private message not working

I have provided my yammer permalink in the teamcity settings, but I don't seem to be getting private messages on build status.  Am I doing something wrong?  It's the permalink right?

Hello,
Yous should provide the email you use to connect to yammer.
Give it a try and tell me if it works.
Best Regards.

Still doesn't work.  My network is using office365 login, could this be why?


Default gitleaks config file doesn't detect all the generic api secrets

Describe the bug
Default gitleaks config file (gitleaks.toml) doesn't detect all the generic api secrets e.g generic secrets where secret key is enclosed within quotes.
To Reproduce
Steps to reproduce the behavior:
e.g "testSecret" : "test" - This secret doesn't get detected by gitleaks.
Expected behavior
An additional rule can be added to detect such secrets as well.
e.g One possible regex could be :
'''['"](?i((key|api[^Version]|token|secret|password|dbpasswd|dbuser|dbname|dbhost|api_key|apikey|user|hostname|pw|auth)[a-z0-9_ .-,]{0,25})'".{0,5}'"['"]'''
cc @zricethezav

Hi @imaditiagg, this is not a bug since you can configure the regex with a custom gitleaks.toml. The generic rule doesn't claim to capture all secrets as it has to maintain a healthy balance of True Positives to False Positives.


pull request for e2e test at 01/11/2017 16:45:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enlarge dropbox functionality

Hey Dotan,
What about to enlarge functionality of your cooldropbox to this one?
http://stackoverflow.com/questions/41277854/angularjs-multiselect-multioptions-with-header-drop-down-box-directive

Question is no longer available


Error: Unable to read file

Hello team,
When I try to use Peek References feature to see all the references of the function declared in the code but it throws the below error message:
Unable to read file '/workspace/file.java' (Error: Unable to resolve nonexistent file '/workspace/file.java')

I’m using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Code:
import * as monaco from 'monaco-editor';
import { initServices } from 'monaco-languageclient/vscode/services';
import { MonacoLanguageClient } from 'monaco-languageclient';
import { WebSocketMessageReader, WebSocketMessageWriter, toSocket } from 'vscode-ws-jsonrpc';
import { CloseAction, ErrorAction, MessageTransports } from 'vscode-languageclient';

let editor = null;
let languageClient = null;
let webSocket = null;

const startClient = async (value, language, fileUri) => {
  await initServices({});

  editor = monaco.editor.create(editorNode, {
    minimap: {
      enabled: false,
    },
    theme: "vs-dark",
  });

  let editorModel = monaco.editor.createModel(
    value,
    language,
    monaco.Uri.parse(fileUri)
  );

  editor.setModel(editorModel);

  webSocket = initLspConnection(`ws://localhost:8080/${language}`);
};

const initLspConnection = (url, language): WebSocket => {
  webSocket = new WebSocket(url);

  webSocket.onopen = async () => {
    const socket = toSocket(webSocket);
    const reader = new WebSocketMessageReader(socket);
    const writer = new WebSocketMessageWriter(socket);
    languageClient = createLanguageClient({
      reader,
      writer,
    }, language);

    await languageClient.start();

    reader.onClose(async () => await languageClient.stop());
  };
  return webSocket;
};

const createLanguageClient = (transports, language) => {
  return new MonacoLanguageClient({
    name: "Sample Language Client",
    clientOptions: {
      workspaceFolder,
      documentSelector: [language],
      errorHandler: {
        error: () => ({ action: ErrorAction.Continue }),
        closed: () => ({ action: CloseAction.DoNotRestart }),
      },
    },
    connectionProvider: {
      get: () => {
        return Promise.resolve(transports);
      },
    },
  });
};

// calling this on language change
const onChange = async (language, fileUri, value) => {
  await dispose();

  let editorModel = monaco.editor.createModel(
    value,
    language,
    monaco.Uri.file(fileUri)
  );

  editor.setModel(editorModel);

  webSocket = initLspConnection(`ws://localhost:8080/${language}`);
};

const dispose = async () => {
  if (languageClient) {
    await languageClient.dispose();
    languageClient = null;
  }

  if (webSocket) {
    webSocket.close();
    webSocket = null;
  }
};

startClient("", 'java', myFilePath)

can you please tell me how can I enable the peek references feature? It works in official monaco editor by default but not with the monaco-vscode-api.

Are the references in the same file?
Anyway, the issue is that you use the monaco.editor.createModel syntax to create the model, which create a standalone model not "linked" to a file on a virtual filesystem.
You better create the file on the virtualfilesystem, then use the createModelReference instead
If you want to find references in other files, every files should exist on the memory filesystem

@CGNonofr yes, the references are in the same file. In the official monaco editor package, this feature works by using creatModel syntax so I thought it will work here as well.

In my setup, it’s quite complicated to use async createModelReference that’s I’m using createModel. Is there any way to make it work using createModel

If you want to full explanation:

in monaco-editor, the textModelService (responsible to find or create the model associated with the file uri) is overriden with a dumb implementation that just returns any created model on that uri
with this package, the VSCode implementation is restored to be able to reference non-open files if the model service override is used

Unfortunately, the model-service override is flagged as required here and I don't think you can not be using it (@kaisalmen do you confirm)?

@CGNonofr Thanks for your explanation!
I have some more questions around createModelReference usage.
When you say 'virtual filesystem’ does that mean the file should exist on the server?
What about languages that don’t require a file to exist on the server, for example, HTML, which provides intellisense using a web worker rather than via LSP? And what if, in some cases, I don’t want to use LSP, just want to use what monaco-editor provides by default. should I still use createModelReference? What should I do in this case?
can you please help me understand when should I use createModelReference and when should I use createModel?

When you say 'virtual filesystem’ does that mean the file should exist on the server?

What I mean by virtual filesystem is the fileSystemProvider registered in the file service. In most cases and by default, it uses a RegisteredFileSystemProvider that is empty by default and allows to registered some static files in it (with content and save callback)
By if you use a remote Language Server, it's your responsability to make sure the virtual filesystem client-side is synchronized with the filesystem accessible to the remote language server. It's the tricky part, and there is multiple ways of achieving it depending on your needs

What about languages that don’t require a file to exist on the server, for example, HTML, which provides intellisense using a web worker rather than via LSP?

I'm not sure what you are talking about: the VSCode html extension or the monaco worker
The HTML VSCode extension is actually using LSP, the server just runs in a webworker and the web extension makes sure the worker server has access to the VSCode virtual filesystem

And what if, in some cases, I don’t want to use LSP, just want to use what monaco-editor provides by default and in that case, no file will exist on server. should I still use createModelReference? What should I do in this case?

The monaco intellisense workers are only able to see open models, which can be fine.
The issue with createModel is you can't call it twice on the same uri, so if you create your model this way, then the intellisense ask for a references on that model, it will try to create that model once again and will crash.
As said before, the standalone implementation of the textModelService works well with that, because when a references is created, it just return an immortal references to the existing model, or throw an error
So you either need to keep the standalone textModelService, or switch to createModelReference. Keep in mind that the first one won't allow to open file not already open
I'm not sure what can prevent you from using createModelReference. I guess that's because you're storing the model in your state somewhere. The alternative is to never store model, but only the file uris, and call createModelReference only to feed the editor, then release it when not required anymore

I'm not sure what you are talking about: the VSCode html extension or the monaco worker

I’m talking about the html css workers that we import from this package: @codingame/monaco-vscode-standalone-html-language-features
If we use this worker for html then it provides the intellisense without keeping the html file in server, right? But I think references feature won’t work if I use createModel, right?
One question: I’m not able to understand from the readme when should I dispose the model reference. Should I dispose it immediately after extracting the textEditorModel from the reference as I don't need it for anything else except the editor model data. Or should I dispose it when I dispose an actual model i.e. on language change?

If we use this worker for html then it provides the intellisense without keeping the html file in server, right? But I think references feature won’t work if I use createModel, right?

It's not really about the workers. Either you enable the model service override and you have to use createModelReference, or you don't and using createModel is fine
Btw, I don't know what "the server" mean to you, we are talking about something fully client side here

One question: I’m not able to understand from the readme when should I dispose the model reference. Should I dispose it immediately after extracting the textEditorModel from the reference as I don't need it for anything else except the editor model data. Or should I dispose it when I dispose an actual model i.e. on editor unmount?

I think the name is pretty straighforward: it's a reference to the model: it need to be kept as long as you need the model. The model will be destroyed as soon as there is no reference left on it

Okay, got it! We need to keep the model reference until we need the editor text model.
We don’t need to dispose the model separately. If we dispose all the references to that model, the model will be automatically dispose.
Thanks for the detailed answer!

@shivam6543 are you ok to close the issue?


Enable the new model serialization for kubernetconfig

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Add Zaraz Pricing Page

Content already approved internally by Yair Dovrat (PM). Ready to get merged by tomorrow.

To be merged by @bjesus on Monday


Weird Tabs Flickering

Godot version
v4.0.beta17.official [c40020513]
System information
MacOS 13.1
Issue description
I know it's a nitpick but I pretty weird and I think it's a bug...
https://user-images.githubusercontent.com/75746148/216531884-06e4e543-859c-41cc-8535-766af99a204b.mov
As you can see in the video, when I switch between the tabs sometimes they show like they're selected and sometimes they don't and it's a little weird in my opinion.
(Again, a nitpick so only if you have time :) )
Steps to reproduce
Just switch between the 3D, 2D, Script or AssetLib tabs...
Minimal reproduction project
N/A

I would just remove the rectangles that surround the tabs and I the ink it would look better...

It's the focus indicator that gets automatically moved to the viewport, as it seems it receives focus by merely hovering it. It's the same when you click the SceneTree or the FileSystem. But yes, i think it should be removed too, as it's unnecessary (i cannot imagine someone navigating the center toolbar buttons with a keyboard, not that it's easy to focus it that way to begin with)

@Flavelius That focus indicator was introduced for keyboard only users such as visual impaired developers (note that VI does not mean someone is COMPLETELY blind)

To me it's not the "flicker" that's annoying, it's that entering the scene or the asset lib view the focus is immediately stolen by another GUI element. This makes keyboard navigation support useless, as you are removed from the top bar the moment you land on one of those tabs, with no direct way to continue moving through them.

@YuriSizov Said it perfectly! In my opinion, at least make some sort of a setting to enable/disable it in settings...

Can you change the milestone to 4.0, or is it too late?

@forecaster-cyber 4.0 is in its final days of development, we only focus on critical issues and important bugs. This is a usability issue, but it's not critical and can be solved in a future release.

Why was this closed as "not planned" if you admit there EXISTS an "underlying problem" :confused:

@Zireael07 It was closed by the author 4 days ago, which is within their right. I just reclassified it so it doesn't appear as if it was fixed.


Metrics docs

I'm ignorant of metrics, but was the change of case in KeyspaceMetrics intended? Can that break people?

Well, it's inconsistent. It would break anyone fetching metric.  feel free to leave it out, or I can, of the PR.  Just need to update the case in the doc.

I definitively don't want to shove a breaking change in a doc branch, so cherry-picked but with that change reverted (in the code and the doc). Happy to have a ticket to fix the inconsistency, but not sure it's worth the trouble for existing users.


healthcare: TestDICOMStore flaky

For example, see build a9dba8b8-394d-4b23-a99d-b03861bec3b4.

(Not caught by the Build Cop because the build above was for a pull request.)


Issue/iso7 banner

Description
separate branch for iso7 that had to be created to resolve conflicts
closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Merged into branches iso7 in 2823216dadaee3eff4b6c85662f169dd83599845


Add another sample tif with extent of germany

Title says all. This will be valid within the bbox of germany.
@JakobMiksch please check.

LGTM. Please merge.


Yet another IEXQueryError when trying to get_social_sentiment?

Summary (include Python version)
Python 3.6, latest version of iexfinance as of Dec 21, 2019, Windows 10.
Receiving full error:
C:\Users\...\iexfinance\altdata\__init__.py:48: UserWarning: UNSTABLE ENDPOINT: Not yet fully implemented by the provider.
  warnings.warn("UNSTABLE ENDPOINT: Not yet fully implemented by the "
Traceback (most recent call last):
  File "test.py", line 266, in <module>
    print(get_social_sentiment("AAPL"))
  File "C:\Users\...\iexfinance\altdata\__init__.py", line 50, in get_social_sentiment
    return SocialSentiment(symbol, period_type, date, **kwargs).fetch()
  File "C:\...\iexfinance\altdata\base.py", line 50, in fetch
    return super(SocialSentiment, self).fetch()
  File "C:\...\iexfinance\base.py", line 209, in fetch
    data = self._execute_iex_query(url)
  File "C:\...\iexfinance\base.py", line 165, in _execute_iex_query
    return self._handle_error(response)
  File "C:\...\iexfinance\base.py", line 178, in _handle_error
    raise IEXQueryError("The query could not be completed. "
iexfinance.utils.exceptions.IEXQueryError: An error occurred while making the query.

Any ideas? I'm using this as my code:
from iexfinance.altdata import get_social_sentiment
import os

os.environ['IEX_TOKEN'] = 'MY_API_TOKEN_IS_HERE'
print(get_social_sentiment("AAPL"))

Any ideas? I know this returns "unstable" results, but would expect AAPL to be a pretty reliable one to test with. I also only have the free tier account API. Would that be the issue? I'm nowhere near my monthly limit for requests.
Date/time of issue
Dec 21, 2019 - 11:58 PM
Expected behavior
To get the social sentiment data.
Actual behavior
See above. Thanks!

This data is not available in the free tier.


Limit value

It tells you the value of limit if it is part of a QueryProxy object.

Coverage increased (+0.0%) to 98.45% when pulling d199d8f71355bde3f1c19ae50c8c2071dd2c4a88 on limit_value into c2707c96ec67316fdc77b4fed9601ec1e35a50e9 on master.

Coverage increased (+0.0%) to 98.45% when pulling d199d8f71355bde3f1c19ae50c8c2071dd2c4a88 on limit_value into c2707c96ec67316fdc77b4fed9601ec1e35a50e9 on master.

Coverage increased (+0.0%) to 98.45% when pulling d199d8f71355bde3f1c19ae50c8c2071dd2c4a88 on limit_value into c2707c96ec67316fdc77b4fed9601ec1e35a50e9 on master.

Coverage decreased (-0.0%) to 98.44% when pulling eaac35d0b081cc200e4c67539e8607e19f382043 on limit_value into c2707c96ec67316fdc77b4fed9601ec1e35a50e9 on master.


Added support for Google Analytics

This PR closes #240
The tracking ID is stored in the config under the name 'gaTrackingId'.
When this field is empty or doesn't exist, there will be no tracking.
Because the tracking id has to be loaded dynamically, the script tag is added in main.browser.ts.
Because ServerAppModule uses AppComponent and AppComponent uses the Angulartics2GoogleAnalytics service, I created a mock class (named AngularticsMock) for this service to provide in ServerAppModule.
This mock is also used in the AppComponent tests.
A useful tool for testing Google Analytics (chrome extension):
https://chrome.google.com/webstore/detail/google-analytics-debugger/jnkmfdileelhofjcijamephohjechhna
This tool will print everything google analytics is trying to send in your developer console.
Leaving the tracking id empty, should show nothing with this tool active.
With the tracking id filled in, it should show a pageview event being sent on every route change.

However, I'll note that this seems to just be the first step to Google Analytics. Currently, this works well for any pageview tasks (i.e. route changes). But, it doesn't work for a file (bitstream) download (as that's a request to the REST API and not a new route).

You're right. I was under the impression that download events were still a custom option, but according to the wiki it has been part of the codebase since 5.0. We'll discuss on whether to send them from the client or the server side in today's meeting.
As for the docs, I'm not opposed to creating a documentation folder with a few markdown files, but we could also consider putting them on the wiki. On github the docs are automatically tied to the codebase at a certain commit (while on the wiki it may be harder to discern for which version of the code the docs were written), and it allows us ask for a documentation update in the context of a PR, but changing docs on the wiki has less overhead (no PR necessary) and the docs will likely need to end up on the wiki eventually. Which do you prefer?


Intel Edison: Add break-out board type to Edison platform name

Add detected break-out board (Arduino or Miniboard) to Edison platform name

I'm not sure this should be done like this as it means we change for every board and then strcmp gets a lot more complex.. You can check pincount to check this so not sure of value.
In any case please docs/contributing.md commits need to be signed off.

Sorry, did not think about other boards... I'm using it just to distinguish logs from mini and Arduino boards. Adding support for extra boards will make things more complex as you said.