[Github] NEXT-00000 - Allow RateLimitFactories be used multiple times in one service lifetime

1. Why is this change necessary?
When rate limiters are used multiple times, they enabled key vanishes
2. What does this change do, exactly?
Let's pass the cleaned up configuration array to symfony but do not remove the keys in our array so a second call will not fail regarding a broken configuration.
3. Describe each step to reproduce the issue or behaviour.
Use rate limits for something else, that is not a request and can be called multiple times in a process lifetime.
4. Checklist

[ ] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

copilot:summary
copilot:walkthrough

Imported from Github. Please see: https://github.com/shopware/shopware/pull/3513

[public] FixVersion Changed: This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-35068, comment 508055]


[3.x] LRA false warning

Fixes #5522
Signed-off-by: Daniel Kec<EMAIL_ADDRESS>

FYI, the issue mentioned in the description looks like the wrong issue number.


rate limiter: flaky test "test_rate_limited_hybrid_flow"

Bug Report

running 1 test
test rate_limiter::tests::test_rate_limited_hybrid_flow ... FAILED

failures:

failures:
    rate_limiter::tests::test_rate_limited_hybrid_flow

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 21 filtered out; finished in 2.04s

--- TRY 3 STDERR:        file_system rate_limiter::tests::test_rate_limited_hybrid_flow ---
thread 'rate_limiter::tests::test_rate_limited_hybrid_flow' panicked at components/file_system/src/rate_limiter.rs:817:9:
assertion failed: (write_bytes as f64) >=
    ((write_work * bytes_per_sec / 100) as f64 * duration.as_secs_f64()) *
        0.75
stack backtrace:
   0: rust_begin_unwind
             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/panicking.rs:144:5
   3: file_system::rate_limiter::tests::test_rate_limited_hybrid_flow
   4: file_system::rate_limiter::tests::test_rate_limited_hybrid_flow::{{closure}}
   5: core::ops::function::FnOnce::call_once
   6: core::ops::function::FnOnce::call_once
             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Dup with https://github.com/tikv/tikv/issues/16434


Modules should use unique routes

If I deploy a ticktock stream the modules are deployed with non-unique routes like http://ticktock-time.cfapps.io. On PWS there is a strong likelihood that someone else has tried deploying ticktock already. We should use unique/random routes for these modules.

I don't think random routes should be the only option, or even the default (I agree it should be an option). We want predictability in the urls of some of the modules. Ideally, we want better error reporting when route already taken is the error as well.
Note that this is / has been a CF issue for any tutorial from day 1

Duplicate of spring-cloud/spring-cloud-dataflow-server-cloudfoundry#35


Added check to handle all cases of MissingWebViewPackageException

Summary

We have been experiencing the below crashes in our Flipkart Android app:

Stack overflow thread for the issue that is causing this crash: https://stackoverflow.com/a/56246743
The change I have done is an enhancement on the following PR which got merged to master: https://github.com/facebook/react-native/pull/24533
The exception handling for this crash already exists but it relies on having a specific string in the error message ("Webview not installed"). But the error message for the crashes above does not include this string.
I have added a check for all the crashes involving the MissingWebViewPackageException.
Refer the file: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#102
Changelog

[ANDROID] [Fixed] - The ReactCookieJarContainer/ForwardingCookieHandler now handles all the cases of missing WebView exceptions gracefully.
Test Plan

No new tests have been added.
CI should pass.
This fix was made based on the exception stacktrace. I have not spent the time to acquire one of the devices that it is happening on.

@thorbenprimke and @cpojer please take a look at this PR whenever possible :)

@hramos can you please review or assign someone to review this change. Thanks!

Yap that's what I thought ;)

@cpojer @hramos I have resolved the linter issue. Please merge this change whenever possible. Thanks!

@cpojer Thanks for quick merge! :)


Error: Flutter command not found

I have set my path and its showing correct
echo $PATH
Documents/flutter/bin:/usr/bin:/usr/sbin:/bin:/sbin
However when I run flutter doctor.It shows an error
flutter doctor
-bash: flutter: command not found

Documents/flutter/bin doesn't look like a correct path.
What is the actual path where you installed Flutter?

I have set my flutter sdk in documents.
On Thu, Aug 2, 2018 at 1:40 PM, Günter Zöchbauer<EMAIL_ADDRESS>wrote:

Documents/flutter/bin doesn't look like a correct path.
What is the actual path where you installed Flutter?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/20132#issuecomment-409843674,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARyx8In8dQxBaaq0NRgrLfcl77W6sDPMks5uMrP-gaJpZM4Vry13
.

That might be but, but Documents is not a valid root for a path

I'm going to close this issue. There is nothing for the Flutter team to do.
I'd suggest to ask on StackOverflow how to set the path to a specific directory in the operating system you are using.

ok but somehow it took flutter command but now the issue is: Flutter plugin
not installed
Whereas I have installed dart and flutter plugin viscose
On Thu, Aug 2, 2018 at 2:22 PM, Günter Zöchbauer<EMAIL_ADDRESS>wrote:

That might be but, but Documents is not a valid root for a path
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/20132#issuecomment-409855037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARyx8Kvb1WlWQz-sTFUGai3pMqNnm7u9ks5uMr3GgaJpZM4Vry13
.

Please add the output of flutter doctor -v.

I have same issue flutter: command not found, my path is:/Users/nhatle/Users/nhatle/flutter/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/Applications/Wireshark.app/Contents/MacOS.

having the same problem really need a solution

@1990mUkuna
Please consider asking support questions in one of the other channels listed at http://flutter.io/support .


Add more general handling for 'null' fields.

I missed one piece of syntax in the original PR. This PR fixes that.
'null' can also appear as the value for a non-repeated field. This value
represents the default value of the type. Since JSON mappings are only
documented for proto3 semantics, this means that we should simply not
set the field to anything in this case. In proto2, this means that the
has-* function should return NIL if a field is parsed with a 'null'
value. This commit adds a test for this behavior.

Locally, ABCL tests are failing due to a type error in full-tests.lisp. This code has absolutely nothing to do with the change, so I think this might be due to something being wrong with my local install. Not sure what is causing the failure in CI.

Nope, failing on github ci as well

I know. The failure I'm seeing locally is not the one that's causing it to fail on CI. I have not yet been able to reproduce the error message that CI reports.

Note: It's definitely not this pr as we have the same failure at head...

Note: It's definitely not this pr as we have the same failure at head...

Yes, it is something to do with the removal of fold-symbol, and something about inlined functions.
The failure I was seeing locally was because of an outdated protoc plugin.


DSEWorkloads does not work in v1.4.0

#158 added dseWorkloads to CRD, but enabling through this feature does not start DSE properly.
This is because it adds JVM_EXTRA_OPTS environmental variables with -g and/or -s and/or -k, and by doing so, JVM crashes when Management API tries to spawn DSE.
DSE Management API swallows stdout when spawning DSE, but with docker you can see it does not start with invalid JVM_EXTRA_OPTS:
❯ docker run --rm -e DS_LICENSE=accept -e JVM_EXTRA_OPTS="-s -g" datastax/dse-server:6.8.2
Applying changes to /opt/dse/resources/cassandra/conf/cassandra.yaml ...
done.
Applying changes to /opt/dse/resources/cassandra/conf/cassandra-rackdc.properties ...
done.
Running dse cassandra -f
Unrecognized option: -s
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

I propose to revert the change since DSE Management API seems not support passing args ('-s', '-g', '-k') yet.

This feature is a tech-preview. A revert is not in order given it is entirely opt-in, but we should investigate what is causing it to fail start-up.
Running dse cassandra -f -s starts just fine within the container. We are validating the behavior of the mgmt api to isolate the problem.

I've seen others trying to use this who have had similar problems - unable to use the official dse workload mechanism but can still use the workaround of adding jvm args for now.

This is fixed in 1.4.1 by #230 and we've got an integration test in place. Please reopen this issue if you can reproduce on a build with that fix.


docs(api/dart): avoid duplicate entries and fix breadcrumbs

Currently two entries are generated for top-level library members like classes, and the main API page for these members has no-so-useful breadcrumbs. E.g., the main API page for PipeMetadata has breadcrumb: angular2 > angular2 > PipeMetadata, vs. the proper breadcrumb angular2 > angular2.core > PipeMetadata that appears on the second copy of the API page entry.
TLDR; within the angular2 package there is a top-level catch-all library of the same name the exports most of the contained libraries. This results in duplicate API page entries (one for angular2.foo and one for angular2.some_sub_lib_id.foo). Furthermore, all internal page links to foo go to angualr2.foo so we loose breadcrumb information. This commit fixes the issue by hiding the top-level angular2 library definition only for the purpose of running dartdoc.

@kwalrath @wardbell @Foxandxss : ready for review.
I also did a minor cleanup, removing superfluous parentheses in the language regex.

Travis doc build is green. The failure is due to the e2e toh-6 flake.

The doc builds, but I don't see a difference in the output, compared to what's on angular.io. What should I be look at/for?

Visit, say, Pipes, and then follow the PipeMetadata link in the Inheritance section.

Ah, OK. So those files are still being generated, but they aren't being linked to. Goodl

Yes.
Anything else to do before this is merged?

@wardbell or @Foxandxss does the code look good to you?


Fixing undefined variable in docs related to getting results from real chips (backends)

Summary
The variable job in the statement job.result() has not been declared previously.
Fixed changing job variable to job_exp as required in the issue #570
Details and comments

@diego-plan9 this is good to merge.


Add num_test_batches option

to_tf_dataset calls can be very costly because of the number of test batches drawn during _get_output_signature. The test batches are draw in order to estimate the shapes when creating the tensorflow dataset. This is necessary when the shapes can be irregular, but not in cases when the tensor shapes are the same across all samples. This PR adds an option to change the number of batches drawn, so the user can speed this conversion up.
Running the following, and modifying num_test_batches
import time
from datasets import load_dataset
from transformers import DefaultDataCollator

data_collator = DefaultDataCollator()
dataset = load_dataset("beans")
dataset = dataset["train"].with_format("np")
start = time.time()
dataset = dataset.to_tf_dataset(
    columns=["image"],
    label_cols=["label"],
    batch_size=8,
    collate_fn=data_collator,
    num_test_batches=NUM_TEST_BATCHES,
)
end = time.time()
print(end - start)

NUM_TEST_BATCHES=200:  0.8197s
NUM_TEST_BATCHES=50:    0.3070s
NUM_TEST_BATCHES=2:      0.1417s
NUM_TEST_BATCHES=1:      0.1352s

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I thought this issue was resolved in my parallel to_tf_dataset PR! I changed the default num_test_batches in _get_output_signature to 20 and used a test batch size of 1 to maximize variance to detect shorter samples. I think it's still okay to have this PR, though - but I'd use the new value of 20 as the default!


Iterations for Outlier Benchmarks

Given that we now have tagged iterations for marking tests that tend to be problematic when it comes to outliers, add more based on outlier results in the past.

Add tags to all of the Where* benchmarks
Keep in mind that we only have 6 hours per job in Github, but should be able to tag the worst offenders.

The 6 hours job time limit has been mitigated here. https://github.com/deephaven/benchmark/pull/330


Refactor draft management

As discussed in the discussion it's probably better to store the drafts somewhere else than in /tmp.

I gather all Himalaya issues to the same bug tracker, so I transfer your issue here.


Try new PHP support

Deploy preview for arnaudligny ready!
Built with commit 122a1afb60977c04bf19f36fb8c65f753fdbfacb
https://deploy-preview-40--arnaudligny.netlify.com


Add missing quotes in errorpages k8s example yaml

What does this PR do?
Fix docs
Motivation
Adding quotations prevents the error:
v1alpha1.ErrorPage.Status: []string: ReadString: expects " or n, but found 4, error found in #10 byte of ...|status":[401]}}},{"a|..., bigger context ...|ice":{"name":"XXXX","port":80},"status":[401]}}},{"apiVersion":"traefik.containo.us/v1alpha1|...

hi！
I have the same problem in v2.4
So, what should I do?
Failed to watch *v1alpha1.Middleware: failed to list *v1alpha1.Middleware: v1alpha1.MiddlewareList.Items: []v1alpha1.Middleware: v1alpha1.Middleware.Spec: v1alpha1.MiddlewareSpec.Errors: v1alpha1.ErrorPage.Status: []string: ReadString: expects " or n, but found 4, error found in #10 byte of ...|status":[403]}}},{"a|..., bigger context ...|service":{"name":"xxx","port":8080},"status":[403]}}},{"apiVersion":"traefik.containo.us/v1alpha1|...

Hi @feily-os, I'm unsure you'll have had the same issue I. When this appeared for me was when I copied a Kubernetes example from https://doc.traefik.io/traefik/master/middlewares/errorpages/. If you followed similar steps, defining the middleware object as following worked for me:
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: test-errorpage
spec:
  errors:
    status:
      - "500-599"
    query: /{status}.html
    service:
      name: whoami
      port: 80

Notice above that I had added quotation marks around the status code range, as follows: "500-599"
The error no longer appeared afterwards.

Hi @icelynjennings, I do the same.
I change the status configuration, And the documentation states that integers can be used.
You can define either a status code as a number (500) or ranges by separating two codes with a dash (500-599).
I tried to use "400-403" but it was not redirected to the specified static page.
I tried to verify this middleware simply, but it failed at present


Change API for 'hasPreimage' to 'getPreimage'

Currently, hasPreimage (defined in Validator's API) has a rather inconvenient interface: It ask if a node knows about a preImage for a given utxo_key at a given height.
Instead, a much more useful API would be to ask for the PreImageInfo for a given utxo_key and just validate the data.

Edited


integration/security/mtls gateways fail to startup

Seen this in a few PRs: https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/18054/integ-security-k8s-tests_istio/2791
istio-proxy fails to get ready: https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/18054/integ-security-k8s-tests_istio/2791/artifacts/mtls-ced2ab09519c417c81685596e0/_suite_context/istio-state-871796244/istio-egressgateway-5c7b6f9d7c-bwjmp-istio-proxy.log

This might just be another consequences of the same root cause, https://github.com/istio/istio/issues/18106

Maybe similar but not the same? In this case it looks like we cannot even connect to pilot. Maybe this is due to control plane security enabled and issue with certs (maybe certs not loaded, like in the other case?)

This is still happening https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-117_istio_postsubmit/19

Addressed, closing

sorry, realized this may not be the same issue, i'll need to confirm tomorrow

Yes I have seen this recently so may be an issue still
On Tue, Nov 19, 2019 at 11:56 PM Jianfei Hu<EMAIL_ADDRESS>wrote:

Reopened #18102 https://github.com/istio/istio/issues/18102.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/18102?email_source=notifications&email_token=AAEYGXICK4VUH6XPDNX3RYLQUTURTA5CNFSM4JCWGMS2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOU667PPQ#event-2814244798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXO4G7T5CJYHBWNN3QDQUTURTANCNFSM4JCWGMSQ
.

https://testgrid.k8s.io/istio_istio#integ-security-k8s-tests_istio&include-filter-by-regex=.*mtls.*
Seems pretty stable now, no red even i scroll back to 11/08. Feel free to reopen if above link is inaccurate.


[Feature Request] Please support global plugin configurations

Tools Info
semantic-release: v17.4.4,
semantic-release-monorepo: v7.0.5
Problem
Hi @pmowrer , thanks for this tools. It's really great and helpful.
Since as of semantic-release v17.4.4, there's a feature for global plugin configurations, so I'd like to request that this tools support global plugin configurations too.
As of now, if I have config like this:
module.exports = {
  extends: ['semantic-release-monorepo'],
  branches: ['main'],
  plugins: [
    [
      '@semantic-release/commit-analyzer',
      {
        preset: 'conventionalcommits',
        presetConfig: {
          types: [
            { type: 'feat', section: '✨ Features' },
          ],
        },
      },
    ],
    [
      '@semantic-release/release-notes-generator',
      {
        preset: 'conventionalcommits',
        presetConfig: {
          types: [
            { type: 'feat', section: '✨ Features' },
          ],
        },
      },
    ],
    [
      '@semantic-release/changelog',
      {
        changelogFile: 'changelog.md',
    ],
    '@semantic-release/npm',
    [
      '@semantic-release/git',
      { /** truncated */ },
    ],
    '@semantic-release/github',
  ],
};

it would pick the configurations as expected.
But that would unefficient because there's repeated code/config.
If I try to use valid global plugin configurations with this monorepo tools:
module.exports = {
  extends: ['semantic-release-monorepo'],
  branches: ['main'],
  plugins: [
    '@semantic-release/commit-analyzer',
    '@semantic-release/release-notes-generator',
    [
      '@semantic-release/changelog',
      {
        changelogFile: 'changelog.md',
    ],
    '@semantic-release/npm',
    [
      '@semantic-release/git',
      { /** truncated */ },
    ],
    '@semantic-release/github',
  ],
  preset: 'conventionalcommits',
  presetConfig: {
    types: [
      { type: 'feat', section: '✨ Features' },
    ],
  },
};

this tool didn't picked up the plugins configurations that would fallback to the default config which is not what I expected.
Please support global plugin configurations too.
Thank you.

Makes sense! This lib aims to provide feature-parity with semantic-release. I'll look into this soon... thanks for the heads up @latipun7!

Hi,
The issue actually comes from semantic-release-plugin-decorators (https://github.com/pmowrer/semantic-release-plugin-decorators).
I just made a PR.

The PR  was merged, but no new version was released.
As this repo doesn't seem to be active anymore, I published a version "7.0.6" myself with this feature/fix.
Should anybody need it you can find it here: https://www.npmjs.com/package/@joca96/semantic-release-monorepo

@pmowrer Possible to make a release plz?
Thank you!

I'm running into this as well now @pmowrer would it be possible to make a npm release of the  latest master, please? Happy to help if there is anything I can do.

This project used to built using Travis CI but that platform no longer seems to be working. Need to get the build process migrated to github actions

any news on this guys ? I can help migrating to github actions.


@-rules and selectors in

@keyframes {} does not get a prefix applied to it.

Fixed?

Yes, it works now, thanks!


Run EKS CI biweekly and add remove volumes job

Run the eks CI biweekly
Remove volume at the end of ekc ci run
Set correct env variables in repo

Successful test run in private repo here https://github.com/misohu/charmed-mlflow-eks-ci/actions/runs/5876696690

The changes look good to me, so if @orfeas-k is also OK we should be good to merge this one


added FileLengthCheck and ParameterNumberCheck

Hi,
just added two more checks:

FileLengthCheck: number of lines should be less than maxLines (default: 1000)
ParameterNumberCheck: number of parameters per method should be less than maxParameters (default: 7)

Awesome :+1:

:+1:  released to haxelib v1.0.9 http://lib.haxe.org/p/checkstyle

thanks!
I should have pointed it out in my commit message, but I changed the defaults to 2000 and 10, because the pages you linked me to were using those. I don't know if there are official defaults or whether every checkstyle implementation uses their own values.
It's probably not a big deal since users can and will change the values according to their coding style, but the library should at least provide some reasonable defaults.

FileLengthCheck default it 2000 and ParameterNumberCheck default is 7 as per the official checkstyle documentation.
Like you said it's not a big deal as long as it's configurable.


[Bug]: .to_df() method from df_rows_program attribute 'append' not found is it '_append'?

Bug Description
Structured data extraction with DFRowsProgram not working.
When I remove the .to_df() statement, the program runs as expected without converting it to a dataframe
Version
0.8.69.post1
Steps to Reproduce
from llama_index.program import (
OpenAIPydanticProgram,
DFFullProgram,
DFRowsProgram,
)
import pandas as pd
import os
from dotenv import load_dotenv
import openai
if name=='main':
import sys
Current_dir = os.getcwd()
Base_dir = os.path.dirname(Current_dir)
sys.path.append(Base_dir)
print(sys.path)
load_dotenv()
DEBUG = os.getenv('DEBUG')
SECRET_KEY = os.getenv('SECRET_KEY')
os.environ["OPENAI_API_KEY"] = SECRET_KEY
openai.api_key = os.environ["OPENAI_API_KEY"]
initialize empty df
df = pd.DataFrame(
{
"Name": pd.Series(dtype="str"),
"Age": pd.Series(dtype="int"),
"City": pd.Series(dtype="str"),
"Favorite Sport": pd.Series(dtype="str"),
}
)
initialize program, using existing df as schema
df_rows_program = DFRowsProgram.from_defaults(
pydantic_program_cls=OpenAIPydanticProgram, df=df
)
parse text, using existing df as schema
result_obj = df_rows_program(
input_str="""My name is John and I am 25 years old. I live in
New York and I like to play basketball. His name is
Mike and he is 30 years old.  Sarah is 20 years old
and she lives in Los Angeles.

She lives in Chicago."""
)
result_obj.to_df(existing_df=df)   //This is the statement that throws the error, when removed, the program runs as expected
print(result_obj.repr())
Relevant Logs/Tracbacks
Traceback (most recent call last):
  File "", line 52, in <module>
    result_obj.to_df(existing_df=df)
  File "", line 65, in to_df
    return existing_df.append(new_df, ignore_index=True)
  File "", line 6204, in __getattr__
    return object.__getattribute__(self, name)
AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

When I make this modification to the df.py script in llama_index/program/predefined/df.py path, the DataFrameRowsOnly program works. But i dont want to alter the library locally. Please check it out and tell me how to resolve it:
def to_df(self, existing_df: Optional[pd.DataFrame] = None) -> pd.DataFrame:
"""To dataframe."""
if existing_df is None:
return pd.DataFrame([row.row_values for row in self.rows])
else:
new_df = pd.DataFrame([row.row_values for row in self.rows])
new_df.columns = existing_df.columns
# assume row values are in order of column names
return existing_df._append(new_df, ignore_index=True) #changed from  return existing_df.append(new_df, ignore_index=True)


feat: safe block margin

Changes safePlasmaBlockNum to safeBlockMargin - the Quasar will not accept exits for outputs younger than the current plasma block minus safeBlockMargin.

also curious about the tradeoffs between a block margin and timestamp margin?
I definitely also like the block margin more for our use case, since a timestamp margin would force someone to wait. just wondering what you think.

also curious about the tradeoffs between a block margin and timestamp margin?
I definitely also like the block margin more for our use case, since a timestamp margin would force someone to wait. just wondering what you think.

also curious about the tradeoffs between a block margin and timestamp margin?
I definitely also like the block margin more for our use case, since a timestamp margin would force someone to wait. just wondering what you think.

My concern with a timestamp margin is that if no blocks are being produced then you could hit a situation where the time has passed but there's no real safety margin at all.
For example, if due to a bug in the child chain, the operator produces an invalid block which also contains Alice's output and then stops producing blocks, then Alice will be able to start a fast exit after the time margin has passed.
With a block margin, she won't be able to do that.
Maybe that's a contrived example though, because if the operator stops producing blocks, then Alice won't be able to transfer the output to the Quasar owner anyway...
I suppose that difference is that a block margin forces a user to wait until the output to be exited has a certain block height which could take a variable amount of time, whereas a time margin forces the user to wait a fixed amount of time whether or not any blocks are produced in that time.
I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

also curious about the tradeoffs between a block margin and timestamp margin?
I definitely also like the block margin more for our use case, since a timestamp margin would force someone to wait. just wondering what you think.

My concern with a timestamp margin is that if no blocks are being produced then you could hit a situation where the time has passed but there's no real safety margin at all.
For example, if due to a bug in the child chain, the operator produces an invalid block which also contains Alice's output and then stops producing blocks, then Alice will be able to start a fast exit after the time margin has passed.
With a block margin, she won't be able to do that.
Maybe that's a contrived example though, because if the operator stops producing blocks, then Alice won't be able to transfer the output to the Quasar owner anyway...
I suppose that difference is that a block margin forces a user to wait until the output to be exited has a certain block height which could take a variable amount of time, whereas a time margin forces the user to wait a fixed amount of time whether or not any blocks are produced in that time.
I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

@kevsul is this what you had in mind: https://ethereum.stackexchange.com/questions/413/can-a-contract-safely-rely-on-block-timestamp/428#428

I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

@kevsul is this what you had in mind: https://ethereum.stackexchange.com/questions/413/can-a-contract-safely-rely-on-block-timestamp/428#428

I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

@kevsul is this what you had in mind: https://ethereum.stackexchange.com/questions/413/can-a-contract-safely-rely-on-block-timestamp/428#428

Yeah, pretty much. Miners put in the block timestamp - there are some restrictions on what they can set it to, but it's best not to trust it too much.

I can see how a time margin might be easier to understand for the user, but I believe that when dealing with blockchains block height is more secure than time passed.

@kevsul is this what you had in mind: https://ethereum.stackexchange.com/questions/413/can-a-contract-safely-rely-on-block-timestamp/428#428

Yeah, pretty much. Miners put in the block timestamp - there are some restrictions on what they can set it to, but it's best not to trust it too much.


NODE_TLS_REJECT_UNAUTHORIZED ?

$ sitemap-generator http://persagen.com/ /mnt/Vancouver/domains/PERSAGEN.com/2.0/sitemap.xml
(node:9038) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0'
makes TLS connections and HTTPS requests insecure by disabling certificate verification.

$ sitemap-generator -V
6.2.5

0 byte sitemap.xml generated

$ node --version
v11.2.0

Same issue here.
$ node --version
v11.2.0
$ sitemap-generator -V
7.3.0

In my case I have an existing sitemap.xml file, but running the sitemap-generator command gives the NODE_TLS_REJECT_UNAUTHORIZED warning mentioned above and sitemap.xml contents are not updated even though the target site has new urls.

I don't think the warning has anything to do with the problems mentioned above. I was able to generate a valid sitemap.
@templeman Could you open another issue for your problem?

I don't think the warning has anything to do with the problems mentioned above. I was able to generate a valid sitemap.
@templeman Could you open another issue for your problem?

Turns out my issue with the sitemap.xml not updating was user error. Feel free to delete.

@templeman Thanks for your feedback.
@victoriastuart Actually I just generated a sitemap for your site without any problems. This seems to be a different problem. Can you try with a different path? Do you have proper permissions?
The warning will be fixed in the next release.

@lgraubner : thank you for looking into this Issue (appreciated).  The uptime on my computer  (Arch Linux) was significant, ~40d or so (enough for a couple of linux kernel updates to have transpired).
Operating that long without rebooting eventually causes issues, so I rebooted this morning, and just now re-ran the sitemap generator.  It appeared to run fine (now), despite the NODE_TLS... warning, generating a 24.6KiB sitemap.xml file.
tl/dr: appears to be working fine, now.
$ time  sitemap-generator  http://persagen.com/  2.0/sitemap.xml
(node:7828) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0'
makes TLS connections and HTTPS requests insecure by disabling certificate verification.
4:37.08

$ head -n20 sitemap.xml | grep loc
    <loc>http://persagen.com/</loc>
    <loc>http://persagen.com/about/</loc>
    <loc>http://persagen.com/contact/</loc>
    <loc>http://persagen.com/resources.html</loc>
    <loc>http://persagen.com/specialities.html</loc>
    <loc>http://persagen.com/sitemap.html</loc>

$ tail -n20 sitemap.xml | grep loc
    <loc>https://persagen.com/files/misc/Recursive_CTE-CTE.pdf</loc>
    <loc>https://persagen.com/files/misc/reading_a_postgres_EXPLAIN_ANALYZE_Query_Plan.pdf</loc>
    <loc>https://persagen.com/files/misc/Recursive_CTE-Big_O.pdf</loc>
    <loc>https://persagen.com/files/misc/Recursive_CTE-Finding_Circular_References_in_Postgres.pdf</loc>
    <loc>https://persagen.com/files/misc/Recursive_CTE-Topological_Sort.pdf</loc>
    <loc>https://persagen.com/files/misc/introduction_to_Algorithm_complexity_analysis.pdf</loc>

Getting this now, even running trace warnings isn't doing anything. Have had this working previously.
(node:15021) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)

Have also tried with being installed -g.


Add service level variable taint analysis support

Purpose
This pr add taint analysis to service level variable declarations.
Service level variables are considered like global variables are is prohibited to assign tainted values to them, similar to global variable. (except when annotated @tainted, also similar to global var)
This pr fixes https://github.com/ballerina-platform/ballerina-lang/issues/13093

Service level variables are disallowed now. PR #17408 removes the support

Closing as https://github.com/ballerina-platform/ballerina-lang/pull/17408 removes service level variables


Update local package when fetching

Bug: https://bugs.swift.org/browse/SR-1915
What is done

Move common package removing code to Basic.isSafeToRemove
Add localPath to Fetchable
Update local package on fetching if necessary and possible.

Questions & Ideas:
I'm not sure where to put isSafeToRemove code. Should it be in Basic module, Utility or somewhere else.  I think it would be nice to have some PackagesDirectory type that will contain all the functionality about Packages\ local folder like (isSafeToRemove, name, localPath, etc)

BTW, I do plan to have a PackagesDirectory type object which will own the management of the Packages folder and contents.

The content of this PR looks good, can we get a test case for it?

👍 Working on tests right now :)

Added tests.
@swift-ci Please test

Linux test failure:
Updating package 'A2.0.0'
Test Case 'VersionGraphTests.testFoundPackageRunUpdate' passed (0.012 seconds).
Test Case 'VersionGraphTests.testFoundPackageCantUpdate' started at 20:47:34.529
fatal: Cannot change to '': No such file or directory
error:  Git 2.0 or higher is required. Please update git and retry.
--- bootstrap: error: tests failed with exit status 1

@swift-ci Please test

Same Linux failure...

Now it's a bit different. Before it was failing because path was an empty string "".
Now it's different error. What git version is on CI, more that 2.0 ? :)
Test Case 'VersionGraphTests.testFoundPackageCantUpdate' started at 14:20:44.109
error:  Git 2.0 or higher is required. Please update git and retry.
--- bootstrap: error: tests failed with exit status 1

I've tested it locally on my Ubuntu 15.10 and it works.

My assumption that it's isSafeToRemove method failing.

This is an issue with Git.version >= 2 requirement. I see few ways of solving it

update CI git
lower git version requirement to 1.8.5. we should talk to @mxcl since he proposed that  > 2 rule
change git version/error handling.

This has been fixed in
https://github.com/apple/swift-package-manager/pull/668 and https://github.com/apple/swift-package-manager/pull/640


Removing a tab gets the body and tab out of sync.

Bug, feature request, or proposal: Bug
What is the expected behavior? Removing a tab keeps the tabs and body in sync.
What is the current behavior? When I remove a tab, the body from the removed tab stays behind but the tab name changes correctly
What are the steps to reproduce?
https://stackblitz.com/github/benaychh/ClosingTabs
Click on "Name: diagram0" on the left and it will open a new tab.
Click on "Name: diagram1" on the left and it will open another tab.
Click the close on diagram0, the tab will disappear but the body no longer matches the tab up top. In my real app, the body is a fairly complicated graph.
What is the use-case or motivation for changing an existing behavior? N/A
Which versions of Angular, Material, OS, TypeScript, browsers are affected? 6.1.0, 6.4.2, All, All, All
Is there anything else we should know? I don't think so.

Hi, I've looked at your demo and could reproduce your issue. Though, I could not reproduce this when looking at our demos.

e.g. https://stackblitz.com/angular/pxgyvellkryq?file=app%2Ftab-group-dynamic-example.ts

Due to amount of files in your demo, we can't really have a quick look in order to identify the issue. If you want us too look closer into your specific demo, please try to reduce your code to a minimum that still shows the issue. Sorry.


feat(schematic): fds 828 generate manifest endpoint

Fixes fds-828
Adds the generate google sheet manifest endpoint
Adds step in schematic specific ci workflow that daves google creds

See initial PR: https://github.com/Sage-Bionetworks/sage-monorepo/pull/2480

@linglp I made assetViewId optional

@linglp Anything else on this PR?


React + Vite configuration

Hey Edward,
Arion here from the edX Bootcamp, missing your spotify recommendations.
I wanted to ask if you could help me configure this set up for use via react + vite project build.
Arion

Hey @arionitas , sure I can help, let me know what your availability is like this week

Awesome! Hope we can go through it after class today if you have some time - Universe sent ya my way! Otherwise, I am free pretty much this whole week - so whatever suits you best!

Thanks for the help!


Fix typos in '.cpp' files in 'samples' directory

Issue #, if available:
Description of changes:
Fixed typos in the "samples/kvs_gstreamer_sample.cpp" and the "samples/kvssink_gstreamer_sample.cpp" files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ivanstanislavov thank you for the contributions. Can you cherry pick your commits to a branch off of develop and use develop as the target branch for the PR please.


How to custom icon color

Hi,
I don't know how to custom icon color, don't see any option for that. What i am missing?

Sorry, i found it. Thanks

@nhuthan can you share how you did it?

Hi @mamartin
All you need is:

place a png image (should be a mono image) to android resource folder
set icon image name and icon color to payload

And it should working

use this tool to generate notification icons (and other icons if you need)
https://romannurik.github.io/AndroidAssetStudio/index.html

thanks for reply! Just found out you can specify default notification color by adding
<meta-data         android:name="com.google.firebase.messaging.default_notification_color"         android:resource="@color/primary" />
to AndroidManifest.xml


Styled Components Issue on Next v8.0.0

Bug report
Describe the bug
Receiving a Unhandled Rejection (TypeError): Cannot read property 'replace' of undefined error from _document.js, which is where all the styled-components settings are. I have not changed anything from my previous config, I just upgraded to the newest version of Next.
ctx.renderPage
./pages/_document.js:10
ctx.renderPage
./pages/_document.js:10
   7 | const originalRenderPage = ctx.renderPage;
   8 |
   9 | try {
> 10 |   ctx.renderPage = () =>
  11 |     originalRenderPage({
  12 |       enhanceApp: App => props => sheet.collectStyles(<App {...props} />),
  13 |     });

Function._callee$
./pages/_document.js:15
  12 |     enhanceApp: App => props => sheet.collectStyles(<App {...props} />),
  13 |   });
  14 |
> 15 | const initialProps = await Document.getInitialProps(ctx);
  16 | return {
  17 |   ...initialProps,
  18 |   styles: (

Expected behavior
App should run in both dev/prod modes.
Screenshots

System information

OS: MacOS

Version of Next.js: 8.0.0

same error report when upgrade to next 8, it sames like styled-jsx problem, I changed styled-jsx version back to 3.1.0 using resolutions(i use yarn) , and problem gone

@jonleopard @XHMM can you provide a reproduction with-styled-components runs fine.

@XHMM I am using apollo as well. I am trying to create a reproduction of this issue, so far I have all the styled-components parts up and running with no issues. So that leads me to think that this might have something to do with Apollo (maybe in _app.js). Gonna do some more digging by adding Apollo now.

@XHMM Do you mind posting your _app.js here?

@jonleopard do you have a <style jsx> or <style jsx global> somewhere?

Here's my _app.ts @jonleopard
import App, { Container } from "next/app";
import React from "react";
import { MuiThemeProvider } from "@material-ui/core/styles";
import CssBaseline from "@material-ui/core/CssBaseline";
import JssProvider from "react-jss/lib/JssProvider";
import { ApolloProvider } from "react-apollo";
import { SnackbarProvider } from "notistack";
import { Button } from "@material-ui/core";
import NProgress from "next-nprogress/component";

import withApolloClient from "../lib/withApolloClient";
import getPageContext from "../lib/getPageContext";

class MyApp extends App<any> {
  private pageContext: any;
  constructor(props) {
    super(props);
    this.pageContext = getPageContext();
  }

  componentDidMount() {
    // Remove the server-side injected CSS.
    const jssStyles = document.querySelector("#jss-server-side");
    if (jssStyles && jssStyles.parentNode) {
      jssStyles.parentNode.removeChild(jssStyles);
    }
  }
  render() {
    const { Component, pageProps, apolloClient } = this.props;
    return (
      <Container>
        <ApolloProvider client={apolloClient}>
          <JssProvider
            registry={this.pageContext.sheetsRegistry}
            generateClassName={this.pageContext.generateClassName}
          >
            {/* MuiThemeProvider makes the theme available down the React
              tree thanks to React context. */}
            <MuiThemeProvider
              theme={this.pageContext.theme}
              sheetsManager={this.pageContext.sheetsManager}
            >
              {/* CssBaseline kickstart an elegant, consistent, and simple baseline to build upon. */}
              <CssBaseline />
              {/* Pass pageContext to the _document though the renderPage enhancer
                to render collected styles on server side. */}
              <SnackbarProvider
                maxSnack={3}
                anchorOrigin={{
                  vertical: "top",
                  horizontal: "right"
                }}
                hideIconVariant
                action={[
                  <Button color="secondary" size="small">
                    Close
                  </Button>
                ]}
              >
                <>
                  <NProgress spinner={false}/>
                  <Component pageContext={this.pageContext} {...pageProps}/>
                </>
              </SnackbarProvider>
            </MuiThemeProvider>
          </JssProvider>
        </ApolloProvider>
      </Container>
    );
  }
}

export default withApolloClient(MyApp);

@timneutkens Nope, I don't even have styled-jsx installed. I'm not sure why there's even a mention of it in the stack trace.

I think I found the culprit. I'm using next-nprogress, which has styled-jsx as a dependency. There's an issue up for the same exact error.

@XHMM it would be really helpful if you could make a minimal testcase (a Next.js app) so that I can clone it and take a look.

@giuseppeg I found the root cause of the issue.  I'm usingnext-nprogress which has styled-jsx as a dependency (there's currently an issue here). Curious how v8 broke next-nprogress, I'll go take a look and see if I can offer a PR. Closing the issue now as this is a problem with next-nprogress and not nextjs.
Sorry for the noise!

@jonleopard yeah we changed some internal implementation detail in styled-jsx but didn't consider the fact that people might run different versions of the library.
FWIW can you try to instruct yarn to resolve to 3.2.0 (using https://yarnpkg.com/lang/en/docs/selective-version-resolutions/)

@giuseppeg Gotcha, thanks for the heads up :)

I have the same error with next 8 and styled-jsx 3.1.2. I tried changing versions of styled-jsx but none worked. The only solution for me at the moment was to stick to next 7 😢

I have the same error with next 8 and styled-jsx 3.1.2. I tried changing versions of styled-jsx but none worked. The only solution for me at the moment was to stick to next 7 😢

Same. Can we get a timeline on a real fix for this?


Fixes issue #1254

1. Why is this change necessary?
#1254
2. What does this change do, exactly?
#1254
3. Describe each step to reproduce the issue or behaviour.
Use the sw-url-field component and paste a URL with query parameters
4. Please link to the relevant issues (if any).
#1254
5. Checklist

[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have read the contribution requirements and fulfil them.

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline.


Bump Google.Cloud.Diagnostics.* to GA

@jskeet mind doing a quick double check?

Will do when I get a chance, but I don't know when I'll be back on a laptop

@jskeet No rush, I just wanted a second set of eyes.  I keep forgetting your on vacation.  I'll add Mike.

Thanks Jon :)


feat: improved Link prefetching behavior, API, and docs; make it similar to Next.js

Overview
This PR makes prefetch on Link similar to prefetch on Next.js:

Prefetching occurs by default using on:qvisible.
Opt-out completely with prefetch={false}.
Or, optionally, only prefetch javascript bundles (and not data) to render the page with prefetch="js".
In dev mode, prefetch will occur with mouseover or focus instead of qvisible.
If a user has their data saver setting set, prefetching is skipped.
Optimized to not prefetch nor attach handlers on same-page Link. (hashes, navbar, etc)
Added detailed jsdoc/API explanation of what prefetch does and how it works, along with options.
Removed aria-pressed because this is for toggle buttons, not <a> tags. Screen readers already handle links, in fact adding and removing aria-pressed will cause confusion for these users as it's not normal link behavior.
Improved the reliability of pathname comparison by normalizing path trailing slashes first, added unit tests for this.
Added and modified unit tests for verifying decisions from prefetch checks.

Prefetching symbols (and/or data) to render a page before SPA navigation is a huge boost to user experience, especially on slow/mobile connections, preventing a burst of network activity during navigation.
If you think defaults or API should be different let me know.
References:
https://nextjs.org/docs/pages/api-reference/components/link#prefetch
https://nextjs.org/docs/messages/prefetch-true-deprecated
https://www.builder.io/blog/prefetching-nextjs-visual-guide
https://www.accessibility-developer-guide.com/examples/sensible-aria-usage/pressed/#intended-use
What is it?

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests / types / typos

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

@jordanw66 this is great! Could I implore you to rebase?
An e2e test would be very nice too, just not quite sure how to test prefetching.

@jordanw66 wow, I'm glad you're back now! Totally understand, if you could do a quick rebase that would be fine.

Closing in favor of #5480


Not able to use an object method using method call syntax in an interpolated string

Fixes #16317.

That was fast, thanks!


Masking String  to extract Documentation to Garden Linux Website

How to categorize this PR?

/kind enhancement,discussion
/area documentation
/os garden-linux
What this PR does / why we need it:
I am currently trying to extract relevant Documentation from this repository to the future Garden Linux Website.
To keep only one source of truth, no extra folder for website shall be created.
Further, relevant parts of existing Documentation-Files must be correctly identified in order to be extracted.
I suggest using <website> as a masking string for website relevant parts. A python Script then searches for this <website>-paragraph to integrate it into the website.
If there is no <website>, the whole file gets crafted into the website.
For now i expect each readme to only contain one of those  constructs - if there will be a need for more, i'll implement another extra function.

discussion/ recommendations requested, as this PR is mainly for discussion and approving my way of extracting infos.

Great idea, maybe this could be switched to more common closing tag like </website>.
This would result in:
<website>
content
</website>

instead of:
<website>
content
<website>

which could be more problematic in understanding when multiple parts should be added to a website from a single long file and would probably handle the parsing easier. Therefore, the handling for multiple website anchors could be easily done, which I think will be needed later when the whole documentation gets extended more and more.

Good point - i also think, there could be more tags - maybe using website:subsitename, e.g. website:build might also be a good idea, if different pages need text from one file.

well, i think i accidentally closed this PR - i'll put in more changes and reopen it soon, then.