Error handling when running dep init from project subdirectory

I tried to adopt dep instead of https://github.com/Masterminds/glide in https://github.com/isucon/isucon6-final/tree/master/bench.
glide.yml did not include the own repository (github.com/isucon/isucon6-final), but manifest.json contains the own repository.
glide.yml
package: github.com/isucon/isucon6-final/bench
import:
- package: github.com/PuerkitoBio/goquery
  version: v1.0.1
- package: github.com/Songmu/timeout
- package: github.com/mitchellh/go-homedir

manifest.json
{
    "dependencies": {
        "github.com/PuerkitoBio/goquery": {
            "branch": "master"
        },
        "github.com/Songmu/timeout": {
            "branch": "master"
        },
        "github.com/andybalholm/cascadia": {
            "branch": "master"
        },
        "github.com/isucon/isucon6-final": {
            "branch": "master"
        },
        "github.com/mitchellh/go-homedir": {
            "branch": "master"
        },
        "golang.org/x/crypto": {
            "branch": "master"
        },
        "golang.org/x/net": {
            "branch": "master"
        },
        "golang.org/x/oauth2": {
            "branch": "master"
        }
    }
}

It is generated by dep init on the directory of https://github.com/isucon/isucon6-final/tree/master/bench. I want not to include the own repository like glide.yml in manifest.json.
I use go version go1.7.3 darwin/amd64
I use macOS Sierra 10.12.2

Hm, that's odd. When you ran dep init, was it from the directory $GOPATH/src/github.com/isucon/isucon6-final?

@sdboyer No. I ran dep init from the directory $GOPATH/src/github.com/isucon/isucon6-final/bench.

I tried this on the subdirectory bench on github.com/isucon/isucon6-final.
manifest.json
{
    "dependencies": {
        "github.com/PuerkitoBio/goquery": {
            "branch": "master"
        },
        "github.com/Songmu/timeout": {
            "revision": "f7382821bee4009254ba6003475762aa5e740807"
        },
        "github.com/isucon/isucon6-final": {
            "branch": "master"
        },
        "github.com/mitchellh/go-homedir": {
            "branch": "master"
        },
        "golang.org/x/net": {
            "branch": "master"
        }
    }
}

lock.json
{
    "memo": "",
    "projects": [
        {
            "name": "github.com/PuerkitoBio/goquery",
            "branch": "master",
            "revision": "4126223a86db8598275b29db04d511cfdab67cf1",
            "packages": [
                "."
            ]
        },
        {
            "name": "github.com/Songmu/timeout",
            "revision": "f7382821bee4009254ba6003475762aa5e740807",
            "packages": [
                "."
            ]
        },
        {
            "name": "github.com/andybalholm/cascadia",
            "branch": "master",
            "revision": "3ad29d1ad1c4f2023e355603324348cf1f4b2d48",
            "packages": [
                "."
            ]
        },
        {
            "name": "github.com/isucon/isucon6-final",
            "branch": "master",
            "revision": "46fc7c511444dcb13765b9a9d6b72e0f49e3ae77",
            "packages": [
                "portal/job"
            ]
        },
        {
            "name": "github.com/mitchellh/go-homedir",
            "branch": "master",
            "revision": "b8bc1bf767474819792c23f32d8286a45736f1c6",
            "packages": [
                "."
            ]
        },
        {
            "name": "golang.org/x/net",
            "branch": "master",
            "revision": "f2499483f923065a842d38eb4c7f1927e6fc6e6d",
            "packages": [
                "http2/hpack",
                "lex/httplex",
                "html"
            ]
        }
    ]
}

@catatsuy it's expected that you run dep init from the project root. From dep init -help:

Initialize the project at filepath root by parsing its dependencies and writing manifest and lock files. If root isn't specified, use the current directory.

Subsequent commands can be run from anywhere beneath the top-level directory, but the initial run has to be in the directory you want to initialize, or pointing to it. This is also how git works - git init either takes the target dir to init, or uses cwd, and then you can run git from anywhere beneath that repo.
We might be able to improve error handling around running from a subdirectory, though.

@sdboyer @carolynvs : I'll focus on this issue.

@wslulciuc Are you still working on this one?

@carolynvs : Yeah, still plan to patch this, just haven't had the time I'd hoped to focus on this issue. Finally have some free time now, so I'll be visiting this issue later tonight!

@carolynvs : After further reviewing this issue, I think more details around what specifically we are attempting to resolve is needed. That is, any attempts to determine whether dep init is executed in a subdirectory assumes user intent (more specifically, that the current directory is not the intended root directory). So my question is can we reasonably determine the project root directory? For reinitialization, this is, possibly, less of an issue. That is, we can search for the presence of a Gopkg.toml and Gopkg.lock n levels from the current directory, warning the user that this might be a subdirectory and whether they would wish to proceed with initialization.
Thoughts?

I still can't think of any reliable method to detect if we are in the project directory or not.
Gopkg.toml and Gopkg.lock only exists after dep init (unless the user creates them manually). So relying on these files is not enough in this case (This is what findProjectRoot does, but we only we that function after dep init).
I think it might be worth it to show a warning if we are within a subdirectory of an already initialized project.
We can look signs like a .git directory in cwd or expect to be 3 levels under GOPATH (GOPATH/github.com/user/package) and show a warning instead of an error in these case. They are not a definite indicator but this could help a bit.

@ibrasho : Thanks. That's helpful. What you outlined were possible approaches I was also considering. I'll work on adding them to dep init.

I am hesitant to have init implement heuristics to detect the root of a repo, e.g. checking for .git and other tricks. We already have similar logic which I am hoping could be used to detect this scenario, e.g. dep.Context.SplitAbsoluteProjectRoot and gps.SourceManager.DeduceProjectRoot.

@carolynvs : I'll explore the possibility of reusing the logic defined in SplitAbsoluteProjectRoot() and  DeduceProjectRoot() as a solution.

...expect to be 3 levels under GOPATH (GOPATH/github.com/user/package)...

@ibrasho I may be missing a lot of context, sorry in advance if my assumptions are way off. Won't doing a check against the depth of the project in the GOPATH result in warnings when project use vanity urls, i.e. rsc.io/goversion sits at $GOPATH/src/rsc.io/goversion? Again, sorry if this has already been discussed and decided on.

@lanzafame nope, you're right - we can't rely on a particular depth within GOPATH. there's no guarantees about that, at all.

@lanzafame I was just listing possible methods. But, as I said in the original comment, none of my suggestions are definite signs sadly.
When keeping in mind that we are trying to print a helpful warning, checking the first segment after GOPATH/src (for domains like github.com, bitbucket.com, gopkg.io or others with structured project names) might not be a bad idea but I'm not sure if it's worth it to implement this check in dep. :grin:


Unclear for users how to reopen "Estimert effekt" on profile page when closed

When the impact menu is closed, it can be reopened by clicking "Estimert effekt", but there is no hover effect or other indication that this is an option.

This will be fixed when closing #590


Command clicking on a function/var shouldn't open another tab if it's already open.

If I had 2 tabs splits on my screen (classA and classB) and command click a function/var in classA (that's would link to classB) it opens it again instead of just going to the already open tab on classB.
It works like that on PyCharm.

@fabtjar Initially are classA and classB open in two separate editor groups?

If yes, try setting "workbench.editor.revealIfOpen": true

@fabtjar Initially are classA and classB open in two separate editor groups?

Yes. If the tabs are both in the same editor group it works how I expect. When they are in separate groups it's opening another tab up in the group I command clicked in.

If yes, try setting "workbench.editor.revealIfOpen": true

This works how I want it to. Vscode seems to have a setting for all my needs!


Improve Changeset error message when it as only one association

It is kind of confusing showing "Did you mean one of ....?"
when there is only one suggestion.

Can you please revert the formatter changes to the file? We haven't run the formatter yet. Thank you!

Can you please revert the formatter changes to the file? We haven't run the formatter yet. Thank you!

Sorry, that was done automatically by my text editor.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Feature request: spearman correlation

I'd like to calculate the spearman correlation.
Why? To calc correlation for non-gaussian quantities like mixed layer depth
Ref: Servonnat, Jérôme, Juliette Mignot, Eric Guilyardi, Didier Swingedouw, Roland Séférian, and Sonia Labetoulle. “Reconstructing the Subsurface Ocean Decadal Variability Using Surface Nudging in a Perfect Model Framework.” Climate Dynamics 44, no. 1–2 (January 1, 2015): 315–38. https://doi.org/10/f6v7kq.
Example code from xarray docu: http://xarray.pydata.org/en/stable/dask.html#automatic-parallelization
Wiki: https://en.wikipedia.org/wiki/Spearman's_rank_correlation_coefficient
Ways to implement:

hack pearson_r with x_ranks = bottleneck.rankdata(x, axis=-1) and then rename to corr(type='pearson')
write a new function the same way as pearson_r called spearman_r

I don't know what is best practice when developing libraries to either extend the functionality of existing functions or add new functions.
I'm leaning toward a new function spearman_r and will trade off ease of development/testing vs code length.


Feature Request: Hold [ALT;CTRL;SHIFT;whatever] during street/crossing creation to disable left turn

Hi there,
awesome mod, i mainly use it's arrow tool to disallow left turns on highway mergers. I think it would be an awesome addition to have that feature on a (configurable) hotkey.
What do you guys think?
PS: Sorry, I am not (yet) able to provide a PR. Although i do have modding expirience with unity (Kerbal Space Program), i never did a C:S mod.

+1 Here in Brazil you can't turn left at almost every junction with traffic lights.

Would this be better as a mod option instead of modifying the build tool?
So you could default all new junctions to prevent left or right turn (depending on game RHD or LHD setting), with the option to override on junction-by-junction basis using the lane connector or lane arrow tools...?

moved


Use +clipboard, Copy and paste does not work!

Releated pull request for master:
xfreerdp /v:ip /cert:ignore /u:username /p:%@ +window-drag +clipboard

Use +clipboard, Copy and paste does not work!
On Winodws Remote Desktop use control c only can work on windows remote desktop. Remote Desktop use control + c on windows and use contorl + v on mac， does not work.
Platform：MacOS
MacOS version：10.15.6

well, <ctrl>+v will never work on a mac (they use the apple key)
you are using xfreerdp so check your local X11 on mac os properly handles that.

Now, I am using <ctrl>+c or <ctrl>+v on a windows as server. sometime this key can work, sometime not work.


add onSwitching callback on slide switching

1、update .gitignore to ignore webstorm configuration files
2、add onSwitching callback on slide switching
3、add a second parameter fromIndex for onChangeIndex so that we know which index the slide came from.
4、update README

The fromIndex is a good idea. What is your use case for onSwitching?

Well, This is useful when you want to implement something corresponding to the current slide position.
is enought. Thanks!


Project: Custom Copilot Full Stack App

Project Name
Custom Copilot Full Stack App
Description
the project has two approaches/paradigms to it:
1)The project can be made to act as your personal AI assistant that has access to your Microsoft graph API and can answer stuff like what meetings are scheduled for you, what was the last mail in your inbox and even send an email on your behalf to someone. This personal AI assistant uses Microsoft Graph API OBO (On-Behalf-Of) User flow to create an out-of-the box RAG approach with the Semantic Kernel SDK acting as the orchestration and agentic engine.
2)The project can also be made to act as a chatbot for a hotel booking agency answering questions like: how is the Creek Hotel in Dubai, are the hotels in Las Vegas any good by referencing information using the indexing capabilities of Azure AI Search that point to PDF documents stored in Azure Storage Account.
The project uses Semantic Kernel SDK as the overall orchestration and agentic engine. The frontend for this project as been written in react.js and the backend is a simple yet native .NET backend API.

Personal AI Assistant Approach
The application is registered in Microsoft Entra ID so that it can use OBO (On-Behalf-Of) User flow to access data from User's Microsoft Graph API. Upon activating the personal AI assistant, the user first signs in to his account using device code flow thus giving a bearer access token to the application that the application can use to access user's data from the Microsoft Graph API.
When the user asks a question like: What meetings are scheduled for me?, the query is first handled by the Semantic Kernel SDK which decides to call the specified Microsoft Graph endpoint for retrieving calendar events for the user; the calendar events are then sent to the GPT-4 engine for summarization and the response is finally sent to the user.
This particular proof-of-concept gives RAG a new out of the box approach with data retrieval from the Microsoft Graph API.
Chatbot for a hotel booking agency
The project can also act as a chatbot for hotel booking agency assisting users to select hotels based upon reviews given by various reviewers that have stayed in the specified hotels in the past.
The grounding content is in form of PDF documents stored in Azur Storage Account and uses Azure Ai Search for indexing these unstructured PDF documents.
So when the user enters a query like: How is the Creek Hotel in Dubai, the query goes to Azure Ai Search, gets triggered there and then retrieves the content and the document URL of the most relevant document. The information is then sent to GPT-4 for summarization and the user is presented with the relevant answer with the document URL as well to have a look at.
Who Can Benefit From My Project
The project is aimed at providing an idea about how you can create a personal AI assistant for your own personal goals and benefits as well as a chatbot for a large enterprise to increase the overall consumer experience.
Technology & Languages

[X] JavaScript
[ ] Java
[X] .NET
[ ] Python
[ ] AI Studio
[X] AI Search
[ ] PostgreSQL
[X] Cosmos DB
[ ] Azure SQL

Project Repository URL
https://github.com/kuljotSB/copilotFullStackApp
Deployed Endpoint URL
No response
Project Video
https://youtu.be/Oce_w-hjEG8
Team Members
kuljotSB (linkedin - https://www.linkedin.com/in/kuljot-bakshi-69101826b/ )

Hello @kuljotsb, thank you for participating in RAG Hack!
The team is working hard to distribute badges. Please have each team member fill out this form:
aka.ms/raghack/badge-dist
Thank you!


Process is not killing it self on error (or Timeout).

The ffmpeg process is not killing itself on an error the error event, and kill() is not working.
Does anybody know how to fix this?
I think the processes stay available on reaching the timeout.
After a timeout the 'error' event is called, in this i kill the process but the process in linux "ps"
is still available.
Is there another way to get the process id or something to kill it?
var ffmpegProc = new ffmpeg({source:videoPath, timeout: 20})
                  .duration(900) //15 min
                  .format('mp3')
                  .on('error', function(err, stdout, stderr) {

                    activeConversions--;
                    fs.exists(videoPath, function(exists) {

                      if(exists) {

                       fs.unlink(videoPath, exports.handleError);
                      }
                    });
                    if(!_.isUndefined(currentConversions[id]))delete currentConversions[id];
                    if(!_.isUndefined(ffmpegProc.kill))ffmpegProc.kill();
                    exports.handleError({err:err});
                  })
                  .on('start', function(pinfo) {

                    activeConversions++;
                    currentConversions[id] = {
                      progressName: 'Converting to MP3',
                      progressValue: 0,
                      title: info.title
                    };
                  })
                  .on('end', function() {

                    activeConversions--;
                    fs.exists(videoPath, function(exists) {

                      if(exists) {

                       fs.unlink(videoPath, exports.handleError);
                      }
                    });
                    if(!_.isUndefined(currentConversions[id]))delete currentConversions[id];
                  })
                  .pipe(writeStream, {end: true});

Getting the pid won't enable you to do anything .kill does not.
What is the error you're getting when ffmpeg is not killed ?

Also, take care with your activeConversions : you can have an 'error' event without any 'start' event in some corner cases.

I get the "timeout" (....ran into timeout (20s)...) error - after that the process is not killed.

What is your OS and which versions of fluent-ffmpeg/ffmpeg/node.js are you using?

OS: Debian
NodeJS: v0.12.7

Same here with Ubuntu 14.04 and node 4.3.1

This is how I kill it:
let self = this;
self.camera
        .on('error', (err, stdout, stderr) => {
          error('Video stream closed error(%s) stderr(%s)', err.message, stderr);
          reject('Video stream closed ' + stderr);
          if (self.camera) {
            self.camera.kill();
            self.camera = null;
            self.stream = null;
          }
        });

My question is why do I have timeout every 30 seconds. I found that other people reported 600 seconds timeout some other even 20 seconds.


Implement MirrorNodeClient.queryTransaction

🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to hedera-enterprise or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
The interface MirrorNodeClient provides the method Optional<TransactionInfo> queryTransaction(@NonNull String transactionId). The implementation of the method in MirrorNodeClientImpl calls the Mirror Node REST API but do not use the result of that call. Instead, only a record containing the transactionId as String is returned (see TransactionInfo).
When doing a call against the REST API way more information about a transaction are returned as you can see in the following sample
Query:
curl -X 'GET' \
  'https://testnet.mirrornode.hedera.com/api/v1/transactions/0.0.4457569-1724503621-738000000?nonce=0' \
  -H 'accept: application/json'

Result:
{
  "transactions": [
    {
      "bytes": null,
      "charged_tx_fee": 66529172,
      "consensus_timestamp": "1724503632.496534574",
      "entity_id": "0.0.4738897",
      "max_fee": "1000000000",
      "memo_base64": "",
      "name": "TOKENMINT",
      "nft_transfers": [
        {
          "is_approval": false,
          "receiver_account_id": "0.0.4457569",
          "sender_account_id": null,
          "serial_number": 1,
          "token_id": "0.0.4738897"
        },
        {
          "is_approval": false,
          "receiver_account_id": "0.0.4457569",
          "sender_account_id": null,
          "serial_number": 2,
          "token_id": "0.0.4738897"
        }
      ],
      "node": "0.0.7",
      "nonce": 0,
      "parent_consensus_timestamp": null,
      "result": "SUCCESS",
      "scheduled": false,
      "staking_reward_transfers": [],
      "token_transfers": [],
      "transaction_hash": "VwgHwtzwU23H2mNaX0hl9lo1ZZQ+6VqGOrzqIzfz6D2KHUHgmGfzmTwStFAS2eza",
      "transaction_id": "0.0.4457569-1724503621-738000000",
      "transfers": [
        {
          "account": "0.0.7",
          "amount": 13305834,
          "is_approval": false
        },
        {
          "account": "0.0.98",
          "amount": 47901005,
          "is_approval": false
        },
        {
          "account": "0.0.800",
          "amount": 5322333,
          "is_approval": false
        },
        {
          "account": "0.0.4457569",
          "amount": -66529172,
          "is_approval": false
        }
      ],
      "valid_duration_seconds": "120",
      "valid_start_timestamp": "1724503621.738000000"
    }
  ]
}

The additional information should be added to the TransactionInfo record.
Suggestion for solving the issue
In the MirrorNodeClientImpl class you can already find several samples on how a JSON response of a REST call is parsed and transfered in a custom method return type. The same should be done in the Optional<TransactionInfo> queryTransaction(@NonNull String transactionId) method and TransactionInfo should become a rich object that is based on all the information coming from JSON.
Additional information
Information about the rest api of the mirror node can be found here. The API can be accessed by Swagger UI. The Swagger UI frontend for testnet can be found here.
📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
A more detailed general documentation of the GitHub PR workflow can be found here.

[ ] Claim this issue: Comment below that you are interested in working on the issue
[ ] Wait for assignment: A community member with the given rights will add you as an assignee of the issue
[ ] Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
[ ] Check out the forked repository
[ ] Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
[ ] Solve the issue in your branch.
[ ] Commit your changes: to your branch
[ ] Start a Pull Request (PR): in the hedera-enterprise repository
[ ] Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the community for support.
[ ] Wait for reviews: Members of the community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
[ ] You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of our community as an open-source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional informantion
If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.

Hey, seems like an easy introduction task :) I would gladly try my best to solve this.
From my understanding, I should:

update TransactionInfo with all information that returned from api call,
write proper mapper, so that json object would change into new TransactionInfo,
create simple test to prove it works,
right?

agree :)

My situation changed, I do not have time right now to participate in any project. Sorry for inconvenience.

Hey @hendrikebbers do you need help with any REST API documentation? I'm looking to get some experience documenting so if you need help please let me know! Thank you

@Ashleycodesseo did you mean you are interested on working on this issue?

Hello @Ndacyayisenga-droid can you please assign me this issue, if no one has worked on it.

Hello @hendrikebbers I worked on this issue and was able to finish all the possible suggestions but when I try running the mvn clean install , it yields a BUILD FAILURE due to some failed tests in some other module of which I didn't edit any file in that module.
So am trying to follow up those issues that why I haven't submitted the PR
If you can offer any help or prepare a zoom meeting together to help me debug my code , I will be happy
Thanks🙏

Hello @Ndacyayisenga-droid please help me here

Hello @Ndacyayisenga-droid please help me here

Ping me on slack when you are available

Alternatively, you can test your code in your fork using the current github workflow since github has enough HBARs for that. Like we did last time we had a call

Hello @hendrikebbers and @Ndacyayisenga-droid, Am facing issues when I try running any tests in the entire repo
This is what am facing


Default sample does not work (animateToNext() is not a function)

The default sample code and the Get Started page on GitHub do mention the following sequence, that does not comply with current release of Framer.js, and triggers a Script Error:
	imageLayer.animateToNext()
AFAIK it should be replaced by:
	imageLayer.states.next()
Best regards, thanks for your work!

Erratum:
imageLayer.states.next()
is deprecated. Prefer:
imageLayer.stateCycle()

The animationOptions are also not being set according to the new API.  I opened #427 to address both issues with the basic demo.

This one is fixed by https://github.com/koenbok/Framer/pull/427. Thanks for reporting @yannlossouarn, and thanks for fixing @spaceghoul!


What else displayed in new relic other than the transaction name?

Hi,
I want to ask about this package, Is it only to display transaction name in new relic like the image below? "PROD - /App\Http\Controllers\Record\HistoryController@index (https://localhost/barracuda/record/history/80bc6643-3305-11)"

Can we trace transaction stack trace for the "PROD - /App\Http\Controllers\Record\HistoryController@index (https://localhost/barracuda/record/history/80bc6643-3305-11)" transaction?
The only I can see when I click the magnifying icon is the image below:

Thanks

I'm not really sure what you're asking here. This library is just a thin wrapper on top of the New Relic PHP plugin, so if you wanna know what exactly is being sent to New Relic you need to check their documentation. This library allows you to set the transaction name (since it's not usually auto-detected correctly for Lumen apps) and report exceptions correctly, not much else.


common ancestor should return the youngest ancestor instead of the oldest one

In this PR, I fixed a bug in Transition_frontier.get_path_diff. Namely when we try to find the ancestor for two blocks, we should always try to find the youngest ancestor.

I think it would be useful to have a unit test of this. Can you write one in test_transition_frontier.ml? Shouldn't be tricky. Just create a transition_frontier with a fork of unequal length. Get the breadcrumbs at both ends. Then apply the breadcrumbs to get_path_diff

I don't understand what you're saying here. The oldest common ancestor of two breadcrumbs will always be the root of the transition frontier, which is definitely not what it used to return. What is the change? Given this diagram
           -->6-->7-->8
          /
         /
1-->2-->3
         \
          \-->4-->5

What did common_ancestor return when called on 8 and 5 before and what does it return now?

@ghost-not-in-the-shell 	another very simple test to do: that the common ancestor of a breadcrumb and itself is itself, not the root.

@enolan is right, the bug only happens on branches of the same length. So instead of chosing randomly, I would just make 2 ancestors and 1 child on each path.


GitHub/standalone release

Description

Fixes # (issue)
Type of change

[ ] Optimization (the change is only an optimization)
[ ] Style (the change is only a code style for better maintenance or standard purpose)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Test A
[ ] Test B

Test Configuration:
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.353%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
18144

Relevant Lines:
24412

💛  - Coveralls


Verify contents of bundled code

New CI process requires verification of bundled code as sometimes dist and src are not included in the final bundled package.

Closed in #128


docs: azure openai quickstart

Added documentation for azure-openai as alternative quickstart

I tested the change to the AnswerRelevancy metric code and I am now able to successful run the evaluation while using Azure OpenAI embeddings. Thank you!

thank you so much @Techneaux for your help, really really appreciated ❤


ScrollController Exception

The chatController is initialized as
chatController = ChatController(
initialMessageList: messageList,
scrollController: ScrollController(),
currentUser: currentUser!,
otherUsers: [otherUser!],
);
2. In the chatview, enter in incoming and receiving outgoing bubbles. Enough messages so that it has more messages than the height of the screen
3. Attempt to scroll up and down the view
Expected results:
Scroll without exceptions
Actual results:
Scroll with unlimited exceptions

I am on 2.0.0 and cannot update to newest version due to issues on that release.
Thank you for any assistance you can provide to resolve this issue.

@kkruel8100 I attempted to reproduce the issue but was unsuccessful. Could you please try it on the example and send me the steps to reproduce the issue along with the solution as soon as possible?

I am having the same issue, but it's a bit difficult to extract the code in a reproduceable manner.
I have a tab navigation and this usually shows up when I go from one tab to another (and one of the tabs is a chat view)

Could you please share the stack trace?

E/flutter (30159): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 158 pos 12: '_positions.length == 1': ScrollController attached to multiple scroll views. E/flutter (30159): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61) E/flutter (30159): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5) E/flutter (30159): #2      ScrollController.position (package:flutter/src/widgets/scroll_controller.dart:158:12) E/flutter (30159): #3      ChatController.scrollToLastMessage.<anonymous closure> (package:chatview/src/controller/chat_controller.dart:156:30) E/flutter (30159): #4      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18:15) E/flutter (30159): #5      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19) E/flutter (30159): #6      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5) E/flutter (30159): #7      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12) E/flutter (30159):

E/flutter (30159): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 158 pos 12: '_positions.length == 1': ScrollController attached to multiple scroll views.
E/flutter (30159): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
E/flutter (30159): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
E/flutter (30159): #2      ScrollController.position (package:flutter/src/widgets/scroll_controller.dart:158:12)
E/flutter (30159): #3      ChatController.scrollToLastMessage. (package:chatview/src/controller/chat_controller.dart:156:30)
E/flutter (30159): #4      Timer._createTimer. (dart:async-patch/timer_patch.dart:18:15)
E/flutter (30159): #5      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)
E/flutter (30159): #6      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
E/flutter (30159): #7      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

still happening for me


Add s3_endpoint parameter for MinIO and other S3-compatible services

Closes https://github.com/jwills/dbt-duckdb/issues/23

Superseded by #25


Package listing like list-packages

Is there a version of list-packages for straight.el?

No, not currently. Personally I do not think that this interface is a very useful one; perhaps you really want something more specific. If you want a list of all available packages, you already get one via M-x straight-use-package or M-x straight-get-recipe, etc. If you want a list of registered packages in the current Emacs session, you could hack that together like this:
(require 'subr-x)
(dolist (package (sort (hash-table-keys straight--recipe-cache)
                       #'string-lessp))
  (insert (format
           "%25s | %s\n"
           package (plist-get (gethash package straight--recipe-cache)
                              :local-repo))))

Which gives:
        aggressive-indent | aggressive-indent-mode
            all-the-icons | all-the-icons.el
            anaconda-mode | anaconda-mode
              apache-mode | apache-mode
              apples-mode | apples-mode
                    async | emacs-async
            atomic-chrome | atomic-chrome
                   auctex | auctex
                      avy | avy
                 bind-key | use-package
              buffer-move | buffer-move
                    cider | cider
                   cl-lib | elpa

Pull requests welcome.

I actually browse new packages in the list which have a descent description and a link to their GitHub page.

Personally I do not think that this interface is a very useful one

Most of the operating systems have package listing feature with at least their description. I can at least expect a searching feature which searches through package as well as its description.


Add IAPs

Instrument approach procedures

what is there still to do, for them being officially added in?

@jakobeng1303 I don't think @erikquinn has started on this yet?

Negative. It's just an issue to show that I want to soon. I might have some time when I get off work today. Transitions are the next addition, then VNAV improvements, then maybe this (?) or something like that. Sorry for the delay!

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


Integration Kernel Selection UI

For #8612

Prompt user to select a kernel (when nothing matches).
Register and install kernel for current interpreter
Misc fixes related to kernel registration.

Codecov Report

Merging #8914 into master will decrease coverage by 0.87%.
The diff coverage is 34.89%.

@@            Coverage Diff             @@
##           master    #8914      +/-   ##
==========================================
- Coverage   58.16%   57.28%   -0.88%
==========================================
  Files         529      527       -2
  Lines       27634    27264     -370
  Branches     4162     4154       -8
==========================================
- Hits        16073    15619     -454
- Misses      10671    10775     +104
+ Partials      890      870      -20

Impacted Files
Coverage Δ

src/client/datascience/constants.ts
99.66% <ø> (-0.01%)
:arrow_down:

...science/jupyter/liveshare/guestJupyterExecution.ts
18.18% <ø> (-0.79%)
:arrow_down:

src/client/datascience/jupyter/jupyterServer.ts
8.33% <ø> (+0.37%)
:arrow_up:

src/client/datascience/types.ts
100% <ø> (ø)
:arrow_up:

...lient/datascience/jupyter/liveshare/serverCache.ts
62.5% <ø> (ø)
:arrow_up:

...tascience/jupyter/liveshare/hostJupyterNotebook.ts
8.55% <0%> (ø)
:arrow_up:

...ascience/jupyter/liveshare/guestJupyterNotebook.ts
10.75% <0%> (ø)
:arrow_up:

...datascience/jupyter/liveshare/hostJupyterServer.ts
14.13% <0%> (+0.15%)
:arrow_up:

...active-common/intellisense/intellisenseProvider.ts
37.17% <0%> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterNotebook.ts
5.28% <0%> (+0.02%)
:arrow_up:

... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29a8de...d975333. Read the comment docs.


Add platform version

This changes how platform versions are applied.

removed all platform versions from the setting presets. This lets Xcode determine the latest version
added options.platformVersions to set project level versions
added target.platformVersion to set application specific version

options:
  platformVersions:
    watchOS: 3.0
    tvOS: 11.0
targets:
  App_iOS:
    type: application
    platform: iOS
    platformVersion: 10.0

These new options just apply default build settings, any any custom settings will still override this.
This is technically a breaking change, as those projects relying on the old default versions set in the setting presets will now have the latest platform version, which for example upgrade iOS 10 to iOS 11.1 (depending on Xcode version)

IssdkVersion a better name than platformVersion

I think platformVersion is ok. sdkVersion should be avoided as it may create confusion with SDKROOT build setting.
SDKROOT = iphoneos11.2;
IPHONEOS_DEPLOYMENT_TARGET = 11.2;

@allu22 Yeah fair enough. Another possible name would be deploymentTarget to match Xcode's UI terminology.
Also the properties on options.settingPresets could potentially just live directory on options with names like iOSVersion (or iOSDeploymentTarget). That means it's a bit cleaner if a spec just has one platform

I think I will change this to deploymentTarget. Any objections?


Does the Mac support Uart baudrate change to 3M?

Hi
I post the questions in Q&A with below link.
https://github.com/armadsen/ORSSerialPort/discussions/172#discussioncomment-327040
#172
I met a problem when test FT4232H with high speed 3M baud rate.
ORSSerial and coolTerm all not work in Mac(got nil response but works in others rates).
But I tried it same steps in windows with coolTerm, looks good with 3M baud rate communication.
It's really confused me, so is the Mac driver limited or something I missing? Has anyone tried this?

I answered the question over in discussions.


Backport of hotfixes #10538 and #10605

Backporting  #10538 and #10605 over to compatible instead
Add MINA_ROSETTA_TERMINATE_ON_SERVER_ERROR feature.

!ci-build-me

For some reason this PR also showed up "In progress" in the Velocity board. I am updating it back to "New Issues" in that board. This action shouldn't affect the original position/state of this issue in its original board.

Stale, closing.


DataContract schema validation

Has the SF runtime recently changed to perform DataContract schema validation? I used to be able to add properties to my classes, and deploy without difficulty, but recently I started getting serialization exceptions complaining about BackingField conflicts. If it has changed, is there a way to disable it?

Hi @jackbond
SF runtime does not do any schema validation itself, we defer that to DataContract. There have not been any recent changes with how SF interacts with DataContract.

Closing as this looks answered. Please let us know if if you need further assistance by re-opening or filing a new issue.


Fixed build issue that prevents make test from working

I am trying to build the Shopify fork of docker.  When I run tests, it fails because of some 3rd party dependency.   This is only to generate the man pages, AFAIK. So, this should not effect the binaries used in the release.
https://github.com/docker/docker/issues/19787
https://github.com/solanolabs/docker/commit/bd00bdc5cae26b3a4994e9d2cbac7439d7c2b767
Please review:
@Shopify/borg

:+1:

:+1:


Improve documentation

Current version is very bare-bones, might be helpful to describe options and usage in greater details.

Documentation is now available here
Closing for now, feel free to reopen if it isn't what you've wanted to see 😄


How to make a copy for simulation

Hello,
I would like to know how I can make a copy of a game (with the same players, the same pots, etc.).
I need it for Monte Carlo Tree Search where the algorithm needs to do simulation.
I can't do deepcopy because there are generators.

Good point. I do not believe there is a simple way to get this right now. There would also be some good questions regarding the copying of the Deck in this use-case: most likely we'll want to reshuffle the Deck in each instance so that the Monte Carlo simulation does not learn the hidden state of the Deck,

Ok,
I tried to copy every attribute but there's still some issues. The issues are often related to the generators.

Hello,
I tried another way to make a copy.
I copy the cards of each board.
However I have an issue when there's an evaluation. prime_product_from_rankbits gives a number that doesn't exist in Look up table.

I tried to do a copy using hand_history.
Here is my code :
num_players = len(history.prehand.player_chips)
game = TexasHoldEm(
            buyin=1,
            big_blind=history.prehand.big_blind,
            small_blind=history.prehand.small_blind,
            max_players=num_players,
        )

gui = TextGUI(game=game)

# button placed right before 0
game.btn_loc = num_players - 1

        # read chips
for i in game.player_iter(0):
        game.players[i].chips = history.prehand.player_chips[i]

        # stack deck
deck = Deck()
if history.settle:
    deck.cards = list(history.settle.new_cards)

# player actions in a stack
player_actions  = []
for bet_round in (history.river, history.turn, history.flop, history.preflop):
        if bet_round:
            deck.cards = bet_round.new_cards + deck.cards
            for action in reversed(bet_round.actions):
                player_actions.insert(
                    0, (action.player_id, action.action_type, action.total)
                )

# start hand (deck will deal)
game.start_hand()

# give players old cards
for i in game.player_iter():
       game.hands[i] = history.prehand.player_cards[i]

        # swap decks
game._deck = deck

while game.is_hand_running():
        gui.display_state()
        gui.wait_until_prompted()
        try:
            player_id, action_type, total = player_actions.pop(0)
            game.take_action(action_type=action_type, total=total)
        except:
            action, total = random_agent(game)
            game.take_action(action_type=action, total=total)

        gui.display_action()

gui.display_win()

It works pretty well except I can't get the same sb_loc, bb_loc, and btc_loc. I can change their values with the values of my hand. But the next current player will still be different.

I think this issue is related to _prehand method (from TexasHoldem).
"Because" of this :
self.btn_loc = active_players[0]
self.sb_loc = active_players[1]

# heads up edge case => sb = btn
if len(active_players) == 2:
    self.sb_loc = self.btn_loc

self.bb_loc = next(self.in_pot_iter(self.sb_loc + 1))

And this :

self._player_post(self.sb_loc, self.small_blind)
self._player_post(self.bb_loc, self.big_blind)
self.last_raise = 0

# action to left of BB
self.current_player = next(self.in_pot_iter(loc=self.bb_loc + 1))

I think for a full __copy__ dunder method, it will be very similar to the the _import_history method for sure. So definitely good start.
As for the discrepancies with the button/sb/bb locations, this is probably because the hand history attached to the game object does not have canonical player IDs (e.g. when we export, we make the button player id 0). So this line ame.btn_loc = num_players - 1 may not be right.
I am planning to take a look at this when I have some time in the coming weeks. Thanks for taking a look, feel free to continue to experiment

Here's another thing I tried :
def generate_game(history, blinds, gui=False):

    num_players = len(history.prehand.player_chips)
    game = TexasHoldEm(
            buyin=1,
            big_blind=history.prehand.big_blind,
            small_blind=history.prehand.small_blind,
            max_players=num_players,
        )

    gui = TextGUI(game=game)

        # button placed right before 0
    game.btn_loc = num_players - 1

    # read chips

    # stack deck
    deck = Deck()
    if history.settle:
        deck.cards = list(history.settle.new_cards)

    # player actions in a stack
    player_actions  = []
    for bet_round in (history.river, history.turn, history.flop, history.preflop):
        if bet_round:
            deck.cards = bet_round.new_cards + deck.cards
            for action in reversed(bet_round.actions):
                player_actions.insert(
                    0, (action.player_id, action.action_type, action.total)
                )

    # start hand (deck will deal)
    game.start_hand()

    # give players old cards
    for i in game.player_iter():
        game.hands[i] = history.prehand.player_cards[i]

    game.pots = [Pot()]

    for i in game.player_iter(0):
        game.players[i].chips = history.prehand.player_chips[i]
        game.players[i].state = PlayerState.IN
        game.players[i].last_pot = 0

    game.btn_loc = history.prehand.btn_loc
    game.sb_loc = blinds[0]
    game.bb_loc = blinds[1]
    game._player_post(game.sb_loc, history.prehand.small_blind)
    game._player_post(game.bb_loc, history.prehand.big_blind)
    game.current_player = next(game.in_pot_iter(loc=game.bb_loc + 1))
    print("current_player : ", game.current_player)
    print("pot iter : ", next(game.in_pot_iter(loc=game.bb_loc + 1)))

        # swap decks
    game._deck = deck

    while game.is_hand_running():
        print("current_player : ", game.current_player)
        gui.display_state()
        gui.wait_until_prompted()
        try:
            print("game current player : ",game.current_player)
            player_id, action_type, total = player_actions.pop(0)
            game.current_player = player_id
            game.take_action(action_type=action_type, total=total)
            #print("current_player : ", game.current_player)
            print("player iter", next(game.player_iter(game.current_player)))
        except Exception as e:
            print(e)
            print("random action")
            action, total = random_agent(game)
            game.take_action(action_type=action, total=total)

        gui.display_action()

    gui.display_win()

That's pretty similar to the previous code.
It seems next(game.player_iter(game.current_player)) gives the next current player. But this current player is different from the current player of the history.

^ This pull request should do it. I'll make a prerelease soon and you can try it out and provide feedback if that does the trick.

Thank you for your effort.

@LucasColas Okay, 0.10-alpha.0 is the prelease for this if you wanted to upgrade to it and try it out.

Also, is this version available on pip ?

I think we should add the possibility to copy the cards of one or several players.

Yes, seems like the hands are not being copied properly. Gonna take a look at this

@LucasColas Okay, just released 0.10-alpha.1 that should be copying the hands correctly

OK, thank you. I'll try.

It seems to be working.

Do you think it's possible to copy the cards of selected players only ?

What are you trying to do exactly? The intent might be out of the realm of the TexasHoldEm object. This is possible by messing with the hands attribute and the _deck attribute.

Let's assume I want to get the cards of the player 3. But the other players should not have the same cards.
So my copy should return the same game except for players 1,2,4,..n where they would have different cards. The cards of the boards and the player 3 should be the same in this example.
I think it's better to do this because for Monte Carlo Tree Search you're not supposed to know the cards of the opponents (except if they reveal the cards).

Here's a possible draft : https://github.com/SirRender00/texasholdem/pull/203


[1905] expose applications accepted from

Context
Courses have a date that applications are accepted from. This date is currently modelled onto the SiteStatus instead of the course, so it's duplicated a lot.
Changes proposed in this pull request

Add new attribute applications_accepted_from
Default to next recruitment cycle
Replace current references to applications_open_from

Guidance to review
Am open to suggestions on any changes/incorrect assumptions I have made given I'm still getting my head around the data model :tada:
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

I prefer applications_open_from to applications_accepted_from. "accepted" is a term that can be misleading – "applications accepted" could be interpreted to refer to a successful application rather than a received one.


mlmmj: add -fcommon workaround

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:
ld: getlistdelim.o:/build/mlmmj-1.3.0/src/../include/mlmmj.h:84: multiple definition of
  `subtype_strs'; mlmmj-send.o:/build/mlmmj-1.3.0/src/../include/mlmmj.h:84: first defined here

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173986 run on x86_64-linux 1

1 package built:

mlmmj


redis connection status:not try to use slave down

When a redis go down, it still active in redis pool.
The PR propose to disable all Redis which do not have a available connection.

thanks


Missing tiles in Watercolor

Some tiles are missing. For example here: http://maps.stamen.com/watercolor/#15/43.3944/21.8352
If you try to load a tile that doesn't load, for example: http://a.tile.stamen.com/watercolor/14/9183/5997.jpg
you get this message: Service Unavailable
A simmilar thing happens with Terrain layer, but not with Ink layer (you can see in attached screenshot)

Yep, I have the same problem. It starts on zoom level 15, everything above renders just fine. Once you zoom in to 15, tiles just won't load (in my case, this: http://maps.stamen.com/watercolor/#15/52.3329/10.8328)

I have the same issue with zoom level 18.
"map -> image" (m2i) also fails with levels > 16 and does not show tiles.
http://a.tile.stamen.com/watercolor/18/138297/84727.jpg -> OK
http://b.tile.stamen.com/watercolor/18/138298/84727.jpg -> service unavailable
http://d.tile.stamen.com/watercolor/18/138300/84727.jpg -> OK
Same goes for https://stamen-tiles-d.a.ssl.fastly.net/watercolor/18/138298/84727.jpg
What is required to provide debug info?

https://wiki.openstreetmap.org/wiki/Rendering

https://wiki.openstreetmap.org/wiki/Maperitive

http://maperitive.net/

2.4.3 only retrieves level 17 tiles

https://wiki.openstreetmap.org/wiki/Tile_servers

https://wiki.openstreetmap.org/wiki/Stamen

Huh, so it seems the watercolor renderer is proprietary and there is no way to look into it or render tiles myself.

BTW, this is a duplicate, there are many older reports regarding this issue.

The issues are known, map data / tiles are 5 years old, support has ceased, the renderer is closed-source.

The issues are known, map data / tiles are 5 years old, support has ceased, the renderer is closed-source.


New ai names

About the PR
new names
-Chat
-Sill-E
-Pook-E
-Butt-Bot
-RISC
-Ada Lovelace
-Sisyphus (particularly because running the station feels like rolling a boulder up a hill)
-Abacus
-The Power of Friendship
Why / Balance
#general said it would be funny to have the name "Chat" and I thought eh why not add a few more
Technical details
nuh uh
Media
nuh uh
Requirements

[/ ] I have read and am following the Pull Request and Changelog Guidelines.
[ /] I have added media to this PR or it does not require an ingame showcase.

Breaking changes
nuh uh
Changelog

10th ai names pr...
#31303

Loadout names better yeah so people can do it, I just need to go back to it.

oops twas unaware, sorry!


Add Polish SDG reporting platform

Insert URLs to the project here: https://github.com/statisticspoland/sdg-indicators-pl

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@PaulinaM1 @sidwab @evela7


Move pipeline-service-tests logic to shell scripts

This change aims to make the pipeline yaml more readable by abstracting the logic in scripts, as well as being able to apply the CI to the content of those scripts.
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

/lgtm


feat: add amount and quantity of tickets

First steps of #266
Changes: Show ticket qty and amount.
Screenshot:

blocker for issue #304 @iamareebjamal request your attention on this :)


[WIP] MS5611 refactor

Like many of our drivers the MS5611 is bloated and convoluted.
This being a core part of the autopilot, it deserves attention. I'll be working on this on the side over the course of the next week or two. If you have any questions or suggestions let me know.
I wanted to get this up here now so you guys can take a loot at what I am doing, see it change over time, and mostly so this doesn't show up as a massive un-reviewable refactor in 2 weeks.

This is another one we should get building on posix to kill off the DriverFramework version.
We also need to test it on I2C.

get building on posix

Does this mean being able to use it with any of the make posix builds? Maybe we can have a chat and you can show me how to change the build configuration to use this driver (once complete) vs the driver framework version. Are there any hardware versions that use I2C that you know of?


PlayerEntity#playSound overload

In PlayerEntity we have two methods
	@Override
	public void playSound(SoundEvent sound, float volume, float pitch) {
		this.getWorld().playSound(this, this.getX(), this.getY(), this.getZ(), sound, this.getSoundCategory(), volume, pitch);
	}

	public void playSound(SoundEvent event, SoundCategory category, float volume, float pitch) {
	}

They seem like they are the same and a simple overload, but they are not.
One of them does nothing, this should be indicated by the name
Read: https://github.com/FabricMC/yarn/issues/3760#issuecomment-1889509637

Isn't the one that "does nothing" overridden to have logic in one of the sided subclasses?

Isn't the one that "does nothing" overridden to have logic in one of the sided subclasses?

Oh my Idea just bugged they actually override it.
But their is still a difference.
        this.networkHandler.sendPacket(new PlaySoundS2CPacket(Registries.SOUND_EVENT.getEntry(event), category, this.getX(), this.getY(), this.getZ(), volume, pitch, this.random.nextLong()));

Is the code for playSound on ServerPlayerEntity. It plays only for that player.
While the other method plays for everyone around except for the player.

Not sure what this issue is asking for. Closing.

Wnat tne

One of the playSound comes from Entity, so that one stays. Regardless, so long as you are using it properly (see also: ClientPlayerEntity#playSound), the player should always hear the sound.

ClientPlayerEntity#playSound is being overriden by ClientPlayerEntity with a method that works as expected.
This does not happen for ServerPlayerEntity.
It uses the Method from PlayerEntity which excludes itself from the playSound. Maybe a JavaDoc to clarify would be enough as I currently can't think of a better name, as the name is used in ServerPlayerEntity and ClientPlayerEntity to do 2 different things.

So long as you call them in both sides (i.e. outside isClient check) this should work fine.


Incorrect cloning options with Object.create

Incorrect cloning with using Object.create
https://github.com/expressjs/serve-static/blob/master/index.js#L48
Object.assign should be used instead

It is not intended to clone the options, which is why Object.create is used instead of Object.assign.

It is not intended to clone the options, which is why Object.create is used instead of Object.assign.

So, how to define options for serv static?
if operation Object.create just erase them all
For example: const opts = Object.create({index: 'index.html'}); // opts === {}

Just follow the the examples in the readme, it should all be there. You can also check out the tests in our test suite. Just pass in an object for the options argument.
The reason you are seeing {} is just how your web browser is rendering the object's keys incorrectly.


⚠ Site ANTS has degraded performance

In 4533e0b, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 8184 ms

Resolved: Site ANTS performance has improved in 2b9df38.


[STORM-1874]Update logger private permissions

STORM-1874
Update Log access permissions from public to private .

+1

+1

+1


Filter reads mark duplicates needed for some metrics to strictly abide by their definition - process pct_reads_aligned_in_pairs/pct_reads_properly_paired

https://github.com/c-BIG/NPM-sample-qc/blob/aa21ba718d0612426246bf14edd3c59385c3441a/bin/metrics/metrics.py#L43
https://github.com/c-BIG/NPM-sample-qc/blob/aa21ba718d0612426246bf14edd3c59385c3441a/bin/metrics/metrics.py#L72
See https://github.com/c-BIG/NPM-sample-qc/issues/46 It need to be precedded by a process which will actively remove reads mark duplicate
Process pct_reads_aligned_in_pairs and pct_reads_properly_paired uses samtools stats including the flag -d would remove the reads mark duplicate

See in the latest metrics_definitions.md https://github.com/ga4gh/quality-control-wgs/pull/7
https://github.com/ga4gh/quality-control-wgs/blob/main/metrics_definitions/metrics_definitions.md


Graphical freeze on boot

Describe the bug
The kernel param option introduced in https://github.com/NixOS/nixpkgs/pull/324921 results in my system graphical output freezing on boot.
Steps To Reproduce
Boot on my config with the newest nixos-unstable.
Additional context
Journal on non working setup when the screen freezes:
Jul 20 20:51:08 desktopnix kernel: nvidia-uvm: Loaded the UVM driver, major device number 234.
Jul 20 20:51:08 desktopnix systemd-modules-load[1623]: Inserted module 'nvidia'
Jul 20 20:51:08 desktopnix (udev-worker)[1838]: nvidia: Process '/nix/store/m101dg80ngyjdb02g6jwy80sr7kzj26g-bash-5.2p26/bin/bash -c 'for i in $(cat /proc/driver/nvidia/gpus/*/infor>
Jul 20 20:51:08 desktopnix systemd-modules-load[1623]: Inserted module 'nvidia_modeset'
Jul 20 20:51:08 desktopnix kernel: nvidia-modeset: Loading NVIDIA Kernel Mode Setting Driver for UNIX platforms  555.58.02  Tue Jun 25 01:10:21 UTC 2024
Jul 20 20:51:08 desktopnix kernel: [drm] [nvidia-drm] [GPU ID 0x00000100] Loading driver
Jul 20 20:51:09 desktopnix kernel: [drm] Initialized nvidia-drm 0.0.0 20160202 for 0000:01:00.0 on minor 1
Jul 20 20:51:09 desktopnix kernel: Console: switching to colour dummy device 80x25
Jul 20 20:51:09 desktopnix kernel: nvidia 0000:01:00.0: vgaarb: deactivate vga console
Jul 20 20:51:09 desktopnix kernel: fbcon: nvidia-drmdrmfb (fb0) is primary device
Jul 20 20:51:09 desktopnix kernel: Console: switching to colour frame buffer device 240x67
Jul 20 20:51:09 desktopnix kernel: nvidia 0000:01:00.0: [drm] fb0: nvidia-drmdrmfb frame buffer device
Jul 20 20:51:09 desktopnix systemd[1]: systemd-vconsole-setup.service: Deactivated successfully.
Jul 20 20:51:09 desktopnix systemd[1]: Stopped Virtual Console Setup.
Jul 20 20:51:09 desktopnix systemd[1]: Stopping Virtual Console Setup...
Jul 20 20:51:09 desktopnix systemd[1]: Starting Virtual Console Setup...
Jul 20 20:51:09 desktopnix systemd-modules-load[1623]: Inserted module 'nvidia_drm'

Journal on working boot:
Jul 21 19:34:27 desktopnix systemd[1]: Started Load/Save RF Kill Switch Status.
Jul 21 19:34:27 desktopnix kernel: nvidia-uvm: Loaded the UVM driver, major device number 234.
Jul 21 19:34:27 desktopnix systemd-modules-load[1621]: Inserted module 'nvidia'
Jul 21 19:34:27 desktopnix (udev-worker)[1757]: nvidia: Process '/nix/store/m101dg80ngyjdb02g6jwy80sr7kzj26g-bash-5.2p26/bin/bash -c 'for i in $(cat /proc/driver/nvidia/gpus/*/infor>
Jul 21 19:34:27 desktopnix kernel: nvidia-modeset: Loading NVIDIA Kernel Mode Setting Driver for UNIX platforms  555.58.02  Tue Jun 25 01:10:21 UTC 2024
Jul 21 19:34:27 desktopnix systemd-modules-load[1621]: Inserted module 'nvidia_modeset'
Jul 21 19:34:27 desktopnix kernel: [drm] [nvidia-drm] [GPU ID 0x00000100] Loading driver
Jul 21 19:34:28 desktopnix kernel: [drm] Initialized nvidia-drm 0.0.0 20160202 for 0000:01:00.0 on minor 1
Jul 21 19:34:28 desktopnix systemd-modules-load[1621]: Inserted module 'nvidia_drm'
Jul 21 19:34:28 desktopnix systemd-modules-load[1621]: Inserted module 'uinput'

Notify maintainers
@CobaltCause
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
 - host os: `Linux 6.8.12, NixOS, 24.11 (Vicuna), 24.11pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/run/current-system/nixpkgs`

Add a :+1: reaction to issues you find important.

Oof. Out of curiosity, what happens if you:

boot a system with the new kernel parameter
wait till you reach the graphical freeze
press ctrl and a function key to switch to a different TTY from the graphical one
press ctrl and the function key to switch back to the TTY that's doing the graphical stuff

Does that unfreeze it?

Tried it. The screen remained frozen. I wasn't able to switch TTY.

Hmm okay, thanks for trying. I think it would probably be a safe bet to revert my PR then. In the meantime you could probably use a workaround like
hardware.nvidia.modesetting = false;
boot.kernelParams = [ "nvidia-drm.modeset=1" ];

to get the old behavior. Not sure if there's anything that makes decisions based on hardware.nvidia.modesetting though.

I think it would probably be a safe bet to revert my PR then.

On second thought, there are quite a few of backlinks from https://github.com/NixOS/nixpkgs/pull/324921 about it fixing things for people, so maybe it's not so cut and dry...

It might help to know some more about your setup to debug this:

What model GPU is this happening with?
Is the machine in question a laptop or a desktop? (I see your logs say "desktopnix" but asking anyway to make sure)
Is the monitor physically connected directly to the GPU's display outputs?

Also, can you SSH into the machine while the screen is frozen?

It's a gtx 1080 in a desktop. I have 3 monitors all connected directly to the graphics card.
I can ssh into the PC after it froze it seems to startup just fine, journal also contains no unexpected errors as far as I can see. This should be all the relevant configuration I have set.

I have also encountered some issues with my display after https://github.com/NixOS/nixpkgs/pull/324921 was merged.
Every time I booted into my computer, right before the login screen was supposed to appear my screen would turn black with a message in the middle saying "Not Optimum Mode, Recommended Mode 3840x2160 60Hz" (this is a Samsung monitor).
I could work around this issue by changing my display to HDMI2 and back to HDMI1, which would fix the issue.
The config workaround mentioned above works for me, thanks for sharing it
Not sure how much this helps, just wanted to share another instance where this option fails.
(Something of note might be that my hardware has some ACPI issues, since I have to use the libata.noacpi=1 kernel parameter to get rid of some errors. I've heard that ACPI may be related to the "Not optimum mode" message, but it hasn't appeared before the PR mentioned above. (I've tried getting rid of the kernel param, but it didn't help))

I want to add I also encountered the same issue where my computer finishes booting, but the screen stays frozen before it reaches the TTY login. I also cannot switch TTYs.
I'm on a desktop GTX 1070 with my main monitor connected with DP and the second one HDMI. The workaround mentioned here to use the old behavior does fix the issue for me. The before and after of journalctl matches the same output as the original post, I'm using Nvidia drivers 555.58.02.

Hmm okay, thanks for trying. I think it would probably be a safe bet to revert my PR then. In the meantime you could probably use a workaround like
hardware.nvidia.modesetting = false;
boot.kernelParams = [ "nvidia-drm.modeset=1" ];

to get the old behavior. Not sure if there's anything that makes decisions based on hardware.nvidia.modesetting though.

Have the same issue as everyone else, however the work around does not work for me. I'm able to boot, however when I try into a wayland compositor with the command Hyprland my screen just turns black, I also tried other compositers and the issue persists.

Had this exact issue as well, but with a GTX 1050Ti instead. The workaround solved the problem (at least temporarily).
I'm still using X11 with DWM, not sure if that's relevant. No wayland (yet).
I'm willing to do more testing to get this fixed, let me know what to try out!

The workaround solved the problem (at least temporarily).
In my case the work around results in a black screen when I attempt to boot in to wayland, is it the same for you or did the workaround stoped working completely?

I'm still using X11 with DWM, not sure if that's relevant. No wayland (yet).
I don't think it is because when I try to boot in to tty instead of x11, or wayland, the issue is still present.

In my case the work around results in a black screen when I attempt to boot in to wayland, is it the same for you or did the workaround stoped working completely?

Sorry, when I said "at least temporarily" I meant "at least for now". Everything works fine for me at the moment, even after updating to the 565 driver yesterday (from 560 when I wrote the comment).

Sorry, when I said "at least temporarily" I meant "at least for now". Everything works fine for me at the moment, even after updating to the 565 driver yesterday (from 560 when I wrote the comment).

Understood, not sure what exactly is causing black screen for me then, if you have some free time can you test hyprland, (Wayland compositor) with your current config?

@laycookie I've tested this with Niri (also a Wayland compositor) since I already have a specialisation with that. Working fine.
Maybe the GTX 1080 is slightly different than the GTX 1050Ti?
Do you have a config I can take a look? Your dotfiles repo seems to be outdated

@diogotcorreia Just decided to test niri out for myself, and can report that on the latest unstable the issue with the black screen goes away, that includes hyprland as well.


amtool not working in prometheus-engine/alertmanager:v0.25.1-gmp.6-gke.0

We have enabled Google Managed Prometheus in our cluster and the control plane is in version 1.30.2-gke.1023004.
We used to view firing alerts from alertmanager pods in gmp-system namespace using the command,
kubectl exec -n gmp-system alertmanager-0 -c alertmanager -- amtool --alertmanager.url=http://alertmanager:9093 alert
But now the alertmanger pods are using image prometheus-engine/alertmanager:v0.25.1-gmp.6-gke.0 in the 1.30 cluster version and we are not able use the amtool command.

Looks like the amtool was removed in https://github.com/GoogleCloudPlatform/alertmanager/pull/81
This looks like something the team should consider adding back.
As a workaround, you could port-forward the Alertmanager container and use the embedded web UI. However, do note that some of the settings, e.g. silences, don't persist when the pod restarts!
There's also special synthetic metrics emitted from the alertmanager, which you might be able to use to see.
We apologize for the inconvenience!

Looks like the amtool was removed in GoogleCloudPlatform/alertmanager#81
This looks like something the team should consider adding back.
As a workaround, you could port-forward the Alertmanager container and use the embedded web UI. However, do note that some of the settings, e.g. silences, don't persist when the pod restarts!
There's also special synthetic metrics emitted from the alertmanager, which you might be able to use to see.
We apologize for the inconvenience!

Hello,
We have many number of clusters, so to silence alerts in each of these clusters it would be difficult to use the port forward option.
It would really helpful if we have the amtool option.

Another option you can try is using the old image in conjunction with a self-deployed alertmanager. The old image is still available so you can deploy it yourself and point GMP to it.
In the meanwhile I created a PR to reintroduce amtool: https://github.com/GoogleCloudPlatform/alertmanager/pull/91


Added the ability to resolve shaded dependencies.

As the pom.xml of shaded dependencies are added to the root jar's META-INF, its possible to resolve these dependencies.

Thanks Joe!  I didn't see this until now.  Great update!!!


⚠ Secret Website 3 has degraded performance

In 7903027, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2813 ms

Resolved: Secret Website 3 performance has improved in afefec8.


Minesweeper-LiterallyEverything

My artwork is a program that can randomly generate a minesweeper board. The parameters you can change are the mine density and the board size.
My experience coding was very fun and new for me as this is my first time coding in JavaScript.
Also here is a picture of my artwork:

I would love to see you try something leaning a bit more towards the artistic but your execution of this is very good and the result comes out nice. I am wondering what it's like to play Minesweeper with pen and paper, the game may not translate so well.
Overall good work. I think you've earned your Blot. If you're a teen you can fill out the order form here. It may take a while to receive because we're still sorting out logistics and have limited supplies.


Microsoft authentication with username and password not working

Recently, every time I've tried to use Microsoft authentication with a provided email and password, it's always given me the exception Invalid password or access token.
It was working before and I didn't change anything about my code, so I think Microsoft probably changed something internally.
Nothing has changed about the account I was using either, and I can still log into it normally on a regular Minecraft client.
As an additional note, when I was debugging, I found that this type of authentication still seems to work when I use a different library called node-minecraft-protocol. As far as I can tell, that library seems to authenticate the same way that this library does (node-minecraft-protocol's XboxTokenManager uses https://github.com/XboxReplay/xboxlive-auth), so I don't know why it's not working here.

Same issue here

+1, i tried to replace the auth using the offical MSAL Library (https://github.com/AzureAD/microsoft-authentication-library-for-java), but I'm not getting it to work, due to something called a WsTrust not being found.


RN-0.73 change Android configs for RN 0.73 compatibility

Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
https://github.com/react-native-community/discussions-and-proposals/issues/671
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. This will require all the libraries to specify a namespace in their build.gradle file.
Details
I'd like to share some of the upcoming changes that will happen in 0.73, which is still a bit far, but we'd rather start earlier rather than later.
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x, which brings a lot of improvements for Android apps but also a series of notable changes.
Most importantly:
App/Library Developers will now have to install and use Java 17
Library Developers will have to specify a namespace in their build.gradle file.
Specifically, the last change is a breaking change and will make libraries that are not specifying a namespace incompatible with React Native 0.73 (your project won't build).
Support for namespace was added in AGP 7.3.x, which ships with React Native 0.71. Libraries that published a new version with a namespace declared for 0.71 or 0.72 don't need further update. So we invite library authors to do those changes as soon as possible so by the time 0.73 is out, most of the apps are adapted.
What you need to change
Library authors will have to update their android/build.gradle file as follows:
android {
+   namespace = "com.dylanvann.fastimage"
    ...
}

and remove the package definition from their AndroidManifest.xml:
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.dylanvann.fastimage">
+          >
...
</manifest>

Further reading
Official Google documentation on namespaces is here.

add back namespace to AndroidManifest for compatibility with previous RN versions
https://github.com/react-native-community/discussions-and-proposals/issues/671#issuecomment-1597386954


ROCANA-3431: Create a crunch release script

Add distributionManagement so that deploy target works
Add HDP repositories to archetype pom file for tests to pass under
certain mavent targets.
Updated SCM connection to point to Rocana github.
Added release script

Tested with CRUNCH_RELEASE_VERSION=0.13.0-hdp2.3.0-rocana1.3.0-rc4 CRUNCH_DEVELOPMENT_VERSION=0.13.0-hdp2.3.0-rocana1.3.0-SNAPSHOT ./rocana-release.s. I ended up deploying, at least partially, 4 RCs during testing. Good thing integers are infinite!

+1


Unable to expand/collapse folder tree view

Hi,
Enabled N1-Taiga and loving it but...
On my exchange account I am unable to expand or collapse the folder tree in the left sidebar.
The expand/collapse button/arrow seems to be missing.
Latest version of N1 installed and just installed N1-Taiga.
ps: looking forward to trying the dark version.

I'll look into it! Thanks for letting me know!


Allow using just a config and Webpack options.

Added new using middleware and execute to allow setting up webpack with just a webpack config file and availability of the Webpack options.
Add option to insert multiple bundles into the HTML and option allow for enabling Hot Module Replacement.

This would be very handy, right now I'm having to manually specify in my HTML file.

I have pulled down this branch and compiled it.  It works well.  I'd love to see this integrated w/ the full package.

My apologies for my really late reply. I was completely overloaded during the last period. @tdbrian thanks a lot for your effort.
I reviewed this pull request and I do have some remarks. Initially I noticed that in multiple files there are changes regarding the code styling which I would prefer not to happen in order to have a unified styling throughout the project.
On top of that the pull request addresses two different issues which I would prefer to be done in two different pull requests. The multiple entry points issue has been discussed here and I will add this code to the code base.
Now about the option of adding hot module replacement this is already in the case for this package as you can see in the corresponding sample


Unable to set X-Forwarded-* headers

Nginx always overrides X-Forwarded-* headers.
Possible Solutions:

Write in in the docs and live with it
Add an variable which will set to true if request transformer changed headers to forbid another change

@trollr Thanks for the report! Yes, at the very least we need to document this behavior. We'll look into doing that.

Just for interest: Are there any valid reasons why request-transformer is not allowed to override x-forwarded-* headers?
I use a kong ingress setup in a kubernetes cluster and a proxied service do csrf protection. Im not able to change x-forwarded-port header. That's the reason Im not able to use the service -.-

Post functions allow to overwrite x-forwarded-* header see https://github.com/Kong/kong/issues/5559


Cannot deploy the stack by docker-compose up

Problem description
Heyo, I tried to installl the docker-elk docker image with docker-compose up, but I just get that error:
ERROR: Invalid interpolation format for "environment" option in service "setup": "${KIBANA_SYSTEM_PASSWORD:-}"
Stack configuration
Freshly cloned repo
Docker setup
$ docker version

Client: Docker Engine - Community
 Version:           20.10.13
 API version:       1.41
 Go version:        go1.16.15
 Git commit:        a224086
 Built:             Thu Mar 10 14:07:52 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

$ docker-compose version

docker-compose version 1.17.1, build unknown
docker-py version: 2.5.1
CPython version: 2.7.17
OpenSSL version: OpenSSL 1.1.1  11 Sep 2018

Container logs
$ docker-compose logs

ERROR: Invalid interpolation format for "environment" option in service "setup": "${KIBANA_SYSTEM_PASSWORD:-}"

@simwai thanks for the detailed report.
Does it work if you remove :- at the end of variable names? In other words, if just keep it like this: ${KIBANA_SYSTEM_PASSWORD}

Heyo @antoineco,
I've replaced now all :- in the docker-compose.yml file and get this error now.
ERROR: Version in "./docker-compose.yml" is unsupported. You might be seeing this error because you're using the wrong Compose file version. Either specify a supported version (e.g "2.2" or "3.3") and place your service definitions under the services key, or omit the version key and place your service definitions at the root of the file to use version 1.
For more on the Compose file format versions, see https://docs.docker.com/compose/compose-file/
Ty for your time and help.

@antoineco Yeah, I updated now docker-compose to latest version from pip instead of the latest 18.04 LTS apt-get version and now it works like a bless. Ty for being active on this awesome project.

Glad it helped!

It might be late, but I hope my comment is helpful to any people experiencing similar issues.
I was also building docker-compose of docker-elk in Ubutnu 18.04.6 LTS desktop(x64) and downloaded the docker and docker-compose packages with the available latest version. And I got the when I built the project via sudo docker-compose up -d(Well, docker-compose version showed the old version 1.17.1, but I had no choice due to the old Ubuntu desktop release.),
ERROR: Invalid interpolation format for "environment" option in service "kibana": "${:-KIBANA_SYSTEM_PASSWORD}"

Change the docker-compose file to 3.3
Remove init and profile attributes in the setup part of docker-compose

version: '3.3'
services:
    ...
    setup:
        # profiles:
        #    -setup
       build:
             ...
       # init: true
       (cont'd)

I think using latest Ubuntu release is the most recommended solution for such Docker composing problems.


TableViz regression when displaying no data for a Druid datasource in 0.36.0rc3

While testing 0.36.0rc3 I noticed that a TableViz of a Druid datasource returns the following message when no data is returned by the query:
"None of [Index(['project', 'count'], dtype='object')] are in the [columns]"
As opposed to "No data" (Superset 0.35.0)
Expected results
"No data" or similar error message returned (less cryptic for the user).
Actual results
UI shows "None of [Index(['project', 'count'], dtype='object')] are in the [columns]".
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug

Go to Druid datasources
Click on one datasource
Run a query that returns no result
See the error displayed

Environment
(please complete the following information):

superset version: 0.36.0rc3

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
This is the stacktrace reported:
Apr  4 08:42:09 an-tool1005 superset[16630]: "None of [Index(['project', 'count'], dtype='object')] are in the [columns]"
Apr  4 08:42:09 an-tool1005 superset[16630]: Traceback (most recent call last):
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/base.py", line 124, in wraps
Apr  4 08:42:09 an-tool1005 superset[16630]:     return f(self, *args, **kwargs)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/utils/decorators.py", line 70, in wrapper
Apr  4 08:42:09 an-tool1005 superset[16630]:     return f(*args, **kwargs)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py", line 717, in explore_json
Apr  4 08:42:09 an-tool1005 superset[16630]:     viz_obj, csv=csv, query=query, results=results, samples=samples
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py", line 639, in generate_json
Apr  4 08:42:09 an-tool1005 superset[16630]:     payload = viz_obj.get_payload()
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py", line 406, in get_payload
Apr  4 08:42:09 an-tool1005 superset[16630]:     payload["data"] = self.get_data(df)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py", line 628, in get_data
Apr  4 08:42:09 an-tool1005 superset[16630]:     df[non_percent_metric_columns],
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/frame.py", line 3001, in __getitem__
Apr  4 08:42:09 an-tool1005 superset[16630]:     indexer = self.loc._convert_to_indexer(key, axis=1, raise_missing=True)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1285, in _convert_to_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     return self._get_listlike_indexer(obj, axis, **kwargs)[1]
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1092, in _get_listlike_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     keyarr, indexer, o._get_axis_number(axis), raise_missing=raise_missing
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1177, in _validate_read_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     key=key, axis=self.obj._get_axis_name(axis)
Apr  4 08:42:09 an-tool1005 superset[16630]: KeyError: "None of [Index(['project', 'count'], dtype='object')] are in the [columns]"
Apr  4 08:42:09 an-tool1005 superset[16630]: ERROR:superset.views.base:"None of [Index(['project', 'count'], dtype='object')] are in the [columns]"
Apr  4 08:42:09 an-tool1005 superset[16630]: Traceback (most recent call last):
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/base.py", line 124, in wraps
Apr  4 08:42:09 an-tool1005 superset[16630]:     return f(self, *args, **kwargs)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/utils/decorators.py", line 70, in wrapper
Apr  4 08:42:09 an-tool1005 superset[16630]:     return f(*args, **kwargs)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py", line 717, in explore_json
Apr  4 08:42:09 an-tool1005 superset[16630]:     viz_obj, csv=csv, query=query, results=results, samples=samples
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py", line 639, in generate_json
Apr  4 08:42:09 an-tool1005 superset[16630]:     payload = viz_obj.get_payload()
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py", line 406, in get_payload
Apr  4 08:42:09 an-tool1005 superset[16630]:     payload["data"] = self.get_data(df)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py", line 628, in get_data
Apr  4 08:42:09 an-tool1005 superset[16630]:     df[non_percent_metric_columns],
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/frame.py", line 3001, in __getitem__
Apr  4 08:42:09 an-tool1005 superset[16630]:     indexer = self.loc._convert_to_indexer(key, axis=1, raise_missing=True)
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1285, in _convert_to_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     return self._get_listlike_indexer(obj, axis, **kwargs)[1]
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1092, in _get_listlike_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     keyarr, indexer, o._get_axis_number(axis), raise_missing=raise_missing
Apr  4 08:42:09 an-tool1005 superset[16630]:   File "/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/indexing.py", line 1177, in _validate_read_indexer
Apr  4 08:42:09 an-tool1005 superset[16630]:     key=key, axis=self.obj._get_axis_name(axis)
Apr  4 08:42:09 an-tool1005 superset[16630]: KeyError: "None of [Index(['project', 'count'], dtype='object')] are in the [columns]"

Can this be related to one of the following?
https://github.com/apache/incubator-superset/pull/9006
https://github.com/apache/incubator-superset/pull/8985

@villebro this doesn't seem a big problem for rc3 but it will be more difficult for users to understand what it is happening.. Let me know what you think about it :)

Good catch @elukey 👍  Are you using the legacy druid connector or the sqlalchemy one?

Good catch @elukey 👍 Are you using the legacy druid connector or the sqlalchemy one?

Good question, I am not entirely sure how to check but I suspect the legacy one, I don't see any sqlalchemy configuration for Druid clusters.


[zh] Update ingress.md and ingress-controllers.md

This PR updates ingress.md and ingress-controllers.md under concepts/services-networking.

Netlify build fails.

content/zh/examples/service/networking/default-ingressclass.yaml: no such file or directory

My suggestion:

Copy content/en/examples/service/networking/default-ingressclass.yaml
to content/zh/examples/service/networking/default-ingressclass.yaml
And if needed, translate it into Chinese

/approve

/lgtm


New version: AdGuard.dnsproxy version 0.71.1

Pull request has been created with WinGet Updater :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\dnsproxy.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\dnsproxy.exe returned exit code: 1

(Automated response - build 880.)


Default Sorting considering invalid field and shield

Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error.  This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field.
Also, to ensure the inheritance for sobject selector (where FFLIB is used a different package or SFDX folder), certain variables has been changed from private to protected.

Great question and feedback @stohn777.  I have actually received an error regading this and hence added the logic to futureproof it :D I'm attaching the exception below:
I'm glad you liked the input regarding abstraction piece! I'm wondering what the next steps for merging the pull requests.
Error on line 91, column 1: fflib_QueryFactory.InvalidFieldException: Invalid field 'CreatedDate' for object 'AccountShare' Class.fflib_QueryFactory.getFieldPath: line 91, column 1 Class.fflib_QueryFactory.addOrdering: line 514, column 1 Class.fflib_SObjectSelector.configureQueryFactory: line 433, column 1 Class.GEN_SObjectSelector.newGenQueryFactory: line 82, column 1 Class.GEN_SObjectSelector.newGenQueryFactory: line 72, column 1 Class.CMT_AccountShareSelector: line 83, column 1

Very well, then we need a bit of exception handling.  Thank you for the stack trace; that helped a lot.  Good job.
May I offer the following suggestion for a slightly cleaner look.  Just my minor thought.  :smiley:
    public virtual String getOrderBy()
    {
        if (m_orderBy == null)
        {
            Schema.SObjectField nameField = describeWrapper.getNameField();
            if (nameField != null && !nameField.getDescribe().isEncrypted())
            {
                m_orderBy = nameField.getDescribe().getName();
            }
            else
            {
                m_orderBy = 'CreatedDate';
                try {
                    if (describeWrapper.getField(m_orderBy) == null)
                    {
                        m_orderBy = 'Id';
                    }
                }
                catch(fflib_QueryFactory.InvalidFieldException ex) {
                    m_orderBy = 'Id';
                }
            }
        }
        return m_orderBy;
    }

Thanks, @stohn777 . I have cleaned up the code based on your suggestion and updated the pull request.

@stohn777 I have updated the comments to fix the indenting issues (caused by IDE). Can you review it?

Thanks @tahsinz for this and @stohn777 for your sage advice here! :-)
I think this looks good apart from the changes related to to ensure the inheritance for sobject selector (where FFLIB is used a different package or SFDX folder), certain variables has been changed from private to protected, per discussion in the other PR, SFDX is not a use case for these changes, what use case is it specifically thats is driving the need for extensibility here? In the other PR it was adding some specific new features, what did you have in mind for the selector base class?
I would recommend meanwhile you remove those changes so we can get this PR merged and then discuss separately (can continue here if needed) the need for extensibility and how best to expose that based on your use case.

Thanks @afawcett and I agree to your comments. I have updated the code as per your recommendation and I hope it is ready to be merged now.

Code deploys to an org and tests all pass. Ready to merge.


TarInputStream does not run synchronously when used non-async

This is a follow up from #786.
TarInputStream.GetNextEntry() seems to use the thread pool to run "asynchronously", even though it should be fully sync.
The async implementation takes an isAsync argument that should make it run totally synchronous when passed with false.
As of #787, deadlocks are avoided using .ConfigureAwait(false), but there is still a bug somewhere that caused this to happen in the first place.

https://sharplab.io/ is a good place to see the generated Async-StateMachine. It's just a bit of work to get all the relevant classes into one file to get an overview.

I copied all relevant classes used by TarInputStream into one file and added the output from sharplab.io.
If someone wants to take a look... I don't know, when I have the time for it.
TarInputStream-SharpLabIo.zip

Just for reference, this is how a "async with isAsync" method should work:
https://sharplab.io/#v2:CYLg1APgAgDABFAjAVgNwFgBQWoGYEBMcAwnAN5ZxUL5QAcCAbADwCWAdgC4B8cAsgAoARgHsRAGzisAzgEFpAT3YBjAJTlK1LawBmcATPlK1GzFvPUoATiYA6ACIBTcQEMFAxDBiqMZi3ABfTQsoAHY4NGDArACgA==
As you can see in the output, the goto just skips the entire state-machine logic and, most importantly, does not call AwaitUnsafeOnCompleted.


BSP fixes and workaround for cross projects

This is fixing:

Some source file considered as directories.
A workaround SCL-17551 that doesn't manage well 2 modules with the same base directory. This is mitigating https://github.com/lihaoyi/mill/issues/864 just like how SBT does 1 version only.
I'm also trying to fix it on the client side https://github.com/JetBrains/intellij-scala/pull/534
Partially fixing https://github.com/lihaoyi/mill/issues/863. It's resolving $ivy imports but missing the $file resolutions.
Removes the weird /build root project so that in the future we will be able to support actual root project.

Thanks

Please ignore this PR for now, it needs more work.

@samvel1024 @adadima Please have a look.
I'm still testing this locally and also trying to get the $file to work somehow.

This is working like a charm on my projects.
@samvel1024 @adadima Do you guys know how to specify "Excluded Folders"? The red folders in this screenshot:

On my previous question it seems not supported yet https://gitter.im/scalacenter/bsp?at=5ebe65b2ecc55a312d0446fc but this is not really important anyway.

This PR is ready to go @lefou @lihaoyi . We are looking forward to use it in my team since the current version of BSP is a great start but contained important bugs and missing support for Cross project.
FYI I also finished https://github.com/JetBrains/intellij-scala/pull/534 which fixes SCL-17551.
And when this is merged and I have more time I will also fix https://github.com/lihaoyi/mill/issues/893.

Thanks


parameters with replaced keys ( - and .) are not passed to the intent_response

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.50.2
Python release (python3 --version):
3.4
Component/platform:
apiai
Description of problem:
parameters with replaced keys are not passed correctly to the intent response
Expected:
pass the modifed parameters to the intent_response in:
intent_response = yield from intent.async_handle(
hass, DOMAIN, action,
{key: {'value': value} for key, value
in parameters.items()})
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:
To fix it i changed as below:
intent_response = yield from intent.async_handle(
hass, DOMAIN, action,
{key: {'value': value} for key, value
in apiai_response.parameters.items()})

The parameters passed still don't include the parameters with replaced keys. the code in apiai.py is still the same. i am currently using appdaemon to receive fulfillment requests from api.ai

apiai has been moved to dialogflow, do you sill see the same issue?


Move CLASSINFO_SIZE macro to Target::classinfosize

It is possible (though unlikely) that CLASSINFO_SIZE may have a different value other than 76/152, for instance if the target record alignment were packed (align(1)) then it would be 148.
This PR more contributes to consolidating two macros into a single variable, and removing more uses of global.params.isXXX from the backend/frontend and into target.c

Nice.

Auto-merge toggled on