Emoji Shower

Proposal
Hackathon idea that was agreed to move forward with
https://expensify.slack.com/archives/C01GTK53T8Q/p1678998192629149
Tasks
We decided we just need a small pre-design to determine which word triggers and animations this happens on

[ ] Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
[ ] Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
[ ] Implement the changes

I'm gonna demote this to a weekly since I'm working on higher priority items this week.

I've been prioritizing manual requests. I'll try to get to this soon.

Coming back from ooo today. I'm prioritizing Manual Requests so probably won't be able to get to this until a couple of weeks from now.

No updates yet

Hi 👋
I'm from SWM and can't wait to work on this one 🤗

Nice! Assigned you to the issue. The issue description already has some guidelines. Let me know if you have any questions!

SWM will work on this once @wojtus7 is back from ooo

Hi! I'm back from ooo and ready to start working on it!
Can you please provide me any links with docs/description of what should it look and behave like?
Only thing I can see is the slack message https://expensify.slack.com/archives/C01GTK53T8Q/p1678998192629149 and it's only one sentence that it should "Generate a shower of emojis when certain messages are sent" 😎

Hi @wojtus7! Thanks for checking. The feature we are trying to implement is similar to the full-screen effect that Apple has available in iMessages, but it's triggered by certain messages like Happy birthday or when users get paid.

We haven't decided which triggers we'll have or which emojis should show up yet, that's part of the pre-design and something you can suggest :)

Does that answer your question?

Yup, thank you @luacmartins
That give me enough info to start working on it for real ❤

Hi I created something like this in first iteration:
What do you think? We need to go more into swirl motion, make it longer/shorter, or just try to make improvements to make it just more smooth etc?
(Emojis that are shown are just passed as string prop into component so they are fully customisable and can be text as well)
https://github.com/Expensify/App/assets/42337257/d6d36ced-fc8c-4bff-8990-261a4bdd8c05

Nice! What is triggering the emoji shower right now?

Hi I created something like this in first iteration:
What do you think? We need to go more into swirl motion, make it longer/shorter, or just try to make improvements to make it just more smooth etc?

You can also post in #expensify-open-source to get some opinions here - Not sure if I love the swirl motion but just IMO

@wojtus7 you can also see what we had for the hackathon here

Nice! What is triggering the emoji shower right now?

Just a ref function call play()
And just for now I just have interval that play it every 10 seconds

@wojtus7 I think we should follow @thienlnam's suggestion and post this in #expensify-open-source to get more opinions on how this should look like

@wojtus7 Actually already posted about it here https://expensify.slack.com/archives/C01GTK53T8Q/p1684348678194399
We're currently waiting on input from @shawnborton to see how we should proceed with this - I believe we'd want to use brand elements in this

Ah nice! I completely missed that post Thanks for the link!

My vote is to close this one out, I don't think we should proceed with an emoji only approach and we should use branded assets instead.
It would be nice to put this through the P/S framework to understand exactly what problem it is that we're solving. But my vote is to just pause on this one entirely and move on to other priorities.

I agree that we have other priorities at the moment. I'm ok with closing this for now and revisiting it in the future if we think this is something worth pursuing.

Gonna close this one as per the previous two comments! Thanks for making yourself available for this one @wojtus7!


feat: adding fiveg_rfsim interface

A new charm relation interface between the OAI NR UE and the OAI DU according to Spec: https://docs.google.com/document/d/1Tv3MHXcultURY5sI0zbOiNDo65li7p2GpXXdlnPebQE/edit

Hello @tonyandrewmeyer ,
I appreciate if you can review it.

@tonyandrewmeyer  Many thanks for the review. Can you merge it ? I do not have rights to do it.


Day94

Resolves #197.

Pull Request Test Coverage Report for Build 394

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 387:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls

Pull Request Test Coverage Report for Build 389

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 387:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


feat 💥: differentiate an unavailable guild coming back online

What type of pull request is this?

[ ] Non-breaking code change
[x] Breaking code change
[ ] Documentation change/addition
[ ] Tests change

Description

This allows NAFF to differentiate between GUILDCREATE events for new joins and unavailable guilds returning.
Breaking as this changes when GuildJoin is dispatched... but im pretty sure this behaviour isn’t desirable anyways
Changes

Check if the guild is already cached, if so, it was almost certainly an unavailable guild
Adds a new event: GuildAvailable which is dispatched when a guild comes back online, instead of GuildJoin

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

Not sure I like this, since behaviour would depend on user configs / cache state. I just fear that this will lead to confusion because the same guilds will trigger different events depending on the state. Additionally, the name of the events does imo not reflect that the logic behind it is basically a glorified guess and not a fact.

The issue is; discord gives no way for a library to determine if a GUILDCREATE event is a new guild or not. This is because library's/apps are expected to keep a cache of their guilds to handle that. While yes NAFF gives you the option to not do that, it should be anticipated it will cause issues.
With that in mind, even though a user could break this by disabling the guild cache, id argue any bot with a disabled guild cache shouldn''t be expecting accurate guild state events.
Its the same principle that you shouldn't be checking for changes in roles if you disable the role cache. Or message edits without a message cache.


Failed: Error while waiting for Protractor to sync with the page: "window.angular is undefined.

Hi,
I've just started to use Protractor. I created several page objects and everything is working fine till now. I log in to a page and I'm being redirected to the myaccount page.
On that page, I got the following error: Error while waiting for Protractor to sync with the page: "window.angular is undefined.
My code is here:
var myaccount = function(){
//some function but everything is commented out
};
module.exports = new myaccount();
Here is my login test as well:
this.loginSuccess = function(){
userName.sendKeys(params.registration.email);
password.sendKeys(params.registration.password);
submitButton.click();

};
After the click, myaccount page appears but the protractor throws the mentioned error.
It seems, the myaccount page is not angularjs, there is no ng-app or other angular related stuff. I've found several topic in this question, but in this case, the rootElement config does not help for me.
How can I handle this situation?
Could somebody help me with this? Thank you in advance!

Please direct general support questions like this one to an appropriate support channel, see https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
Thank you!
Quick answer - you need to use browser.driver or ignoreSynchronization to work on a non-angular page.

See also https://github.com/angular/protractor/blob/master/docs/faq.md#how-do-i-deal-with-my-log-in-page

Hi Julie, thanks. I've tried it. The main problem is that, within an it() testcase, I start a non angular page but after one click, I redirected to an angular page and I got this error: Failed: unknown error: angular is not defined. Can I handle both cases in one testcase? (Nothing special, login, myaccount, search forms where the login and search is angular and my account is non angular) Strange situation!

I am getting below error. can anybody help much appreciated. Thanks
Failed: Error while waiting for Protractor to sync with the page: "[ng:test]


Clarifies information around --inso-compatible in deck file openapi2kong

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Miscellaneous minor fixes

xen-network: fix override separator
dom0: linux: use https to fetch from github
daq: add the branch to URL
domd: snort: Fix misprint in FILES

Ack is added.


_meta.json titles for subfolders

Greetings,
I'm trying to customize the page titles using _meta.json as following
{
  "home": {
    "title": "Home",
    "pages": {
      "about": {
        "title": "About Us",
        "pages": {
          "about-us": {
            "title": "About Us"
          },
          "contact-us": {
            "title": "Contact Us"
          }
        }
      }
    }
  }
}

But for some reason the subfolder title is not changing to "About Us"

The folder structure is as follows
pages/
  home/
    about/
        about-us.mdx
        contact-us.mdx

I solved it.
I just realized I have to make a _meta.json file inside each folder in the pages directory in order to be able to customize the page titles and such.


fix: change fee_server not to crash on corrupted json

:clipboard: Fixes #815
Overview
Changes fee file handling to be more forgiving regarding user errors in the file structure.
Expected behavior is:

if the child chain is starting and fee file is corrupted it should crash
if the child chain is running and file was updated corrupting it, error message is logged, alarm raised and last valid fees are effective.

Changes

prevented fee_server process from crashing on json-serialization issues
added alarms to raise issues with file parsing.

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Coverage decreased (-0.007%) to 80.603% when pulling 582f73b3edf4d4d9bef9cd7b3a8d02b9b6032cf9 on 815-more_forgiving_handling_of_corrupted_fee_file into 167f2429b33db2be44204ab5a275afb39869e7f0 on master.

@InoMurko - please note I slightly extended Alarm module, so clear_alarm is idempotent (don't crash on clear when no alarm was raised)


improve to send form-data using webhook

summary
To send form-data can become complex as many fields, encode, readability, and so on.
example
apiVersion: v1
kind: ConfigMap
metadata:
  name: <config-map-name>
data:
  template.form-data: |
    webhook:
      <webhook-name>:
        method: POST
        form:
          key1: value1
          key2: value2

Can I be assigned to this @alexmt ?


[Dashboard] Condensed view

Here's the final design and the switcher between condensed and non-condensed view: https://invis.io/J7OPHL18HUR#/338295582_18_Maps_Compact

@kukukaka What should we use in case there's no map preview available?
If we use the same image as in the normal map card, it just look as a grey box