Support to f4 address and general improvements for filecoin integration

📝 Description
We have removed addresses related logic from Ledger Live, and replaced it by the Izari-Filecoin package. It makes it easy for developers to incorporate Filecoin the project. By doing so, we have added support to new address type 4, which has been released on mainnet.
Besides, we apply some general improvements in order to avoid possible bug in certain scenarios.
Now, address validation and serialization is done by Izari-Filecoin. The package has support to f4/t4 addresses.
Notes

PR reopened. Prev PR: https://github.com/LedgerHQ/ledger-live/pull/2372

❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

@haammar-ledger could you please give it a look again? I just made a "big" change by using a new package we created, extracting much of the logic we copied here.

Hi @emmanuelm41, as discussed, I advise you use proto to solve the issues that are currently present in the CI.

@haammar-ledger it is fixed now!

@haammar-ledger please, you can check again. Unfortunately, Jest is required to enable an experimental feature in other to accept dynamic imports 🔗 . That is something we have internally on our package in order to keep ESM and CJS compatibility (some of our dependencies are ESM only). Now it is fixed. Please, check it again!

I have another question. BigInt are not yet supported on ReactNative, are it? I am not sure if it has been supported or not yet.

@haammar-ledger done! I have applied requested changes.

Thanks!
Sorry I missed your question:

I have another question. BigInt are not yet supported on ReactNative, are it? I am not sure if it has been supported or not yet.

ReactNative actually supports BigInt since a few versions, but until now BigInt wasn't supported on the Live codebase because we needed to update our RN version. However this was just merged this very morning :slightly_smiling_face: https://github.com/LedgerHQ/ledger-live/pull/2888 it's a coincidence but we should now support BigInt.
Please note that the codebase wasn't migrated to use it yet, so the standard way around this remains to use the bignumber.js library.

@haammar-ledger I don't want to do anything on Ledger Live with BigInt. But we had some dependencies that uses it internally. We needed to make fork and remove BigInt references from it in order to be able to integrate Filecoin. If BigInt is supported now, we can go back to the original package. That is a great news!!!
Let me understand this. This means we could use that package back again, doesn't it?

@emmanuelm41 New conflicts to solve 🙏 otherwise LGTM!

Let me rebase it @haammar-ledger

👋  ESLint config has been unified on develop after we merged https://github.com/LedgerHQ/ledger-live/pull/3622 – this will improve the project consistency, remove eslint dependencies duplicates, and overall simplify the maintenance. This comes with a prettier library upgrade and unification of the prettierrc too, so you likely have conflicts with develop.
Hopefully, here is the procedure to easily fix this. please proceed as follow:
Step 1: sync your branch with develop up to the config changes:
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git rebase aa1e0ebc0a0498b4350754899b6a368fbd42e811

otherwise prefer

git merge aa1e0ebc0a0498b4350754899b6a368fbd42e811

then, apply the config
pnpm i
pnpm lint:fix --force

if there are remaining errors that lint couldn't fix, please fix them and pnpm lint again.
then commit in your branch.
git commit -a -m "chore: lint fixes"

Step 2: finalize the rebase/merge with develop
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git pull --rebase origin develop

otherwise prefer

git merge origin/develop

you should now be up to date. 👍

Thanks and sorry for the inconvenience,
gre


scrollStart firing when trying to scroll vertically with scrollY=false

I'm using iScroll 5 on a Phonegap App and noticed this issue. I have vertical scroll disabled (scrollY = false) and the scrollStart event is firing when the user tries to scroll vertically on the content, causing problems.

@cubiq I'm not sure if this is an issue or expected behavior.

With vertical scroll disabled I don't expect this event to fire on an attempt to scroll vertically...


spi slave use dma，lost last 4 bytes (IDFGH-262)

In spi slave mode，if i do not use dma,just setspi_slave_initialize(spi, &buscfg, &slvcfg, 0);My code works well.
And if i use dma:spi_slave_initialize(spi, &buscfg, &slvcfg, 1); esp will lost last 4 bytes.
i found that:
Warning: Due to a design peculiarity in the ESP32, if the amount of bytes sent by the master or the length of the transmission queues in the slave driver, in bytes, is not both larger than eight and dividable by four, the SPI hardware can fail to write the last one to seven bytes to the receive buffer.
So I send 12,16 bytes each time,
For 12 bytes,esp get 8 bytes  a5,a5,a5,a5,a5,a5,a5,a5,0,0,0,0:
For 16 bytes,esp get 12 bytes  a5,a5,a5,a5,a5,a5,a5,a5,a5,a5,a5,a5,0,0,0,0:
I use the latest idf.
So what shall i do with the setting of spi module?

hi @BigSmileFace ,
I wonder whether the timing of SPI bus does not meet the requirement of ESP32 slave. Could you please provide the following to let us help you?

your IDF commit
your bus LA capture
frequency of SCLK
your working mode
your code for testing
did you modify the slave driver code?

The issue may be:

currently we have issues with DMA in mode 0/2, which is being solved
there should be a hold time between the last clock edge and the CS inactive edge, or the last bytes will not be written into the memory.

To check whether is from reason 1, just config both your master and slave to mode 1

Is there any outcome of the investigations regarding this issue? I face the same problems when using DMA ans SPI slave driver. I use the arduino-esp32 module.
The last 4 bytes are always missing. Frequency doesn't matter. I've tried all modes and the problem is in all modes. I checked the output of the SPI master (raspberry pi 3) with a logic anylizer and the master definitely sends all bytes. The signals also look nice and clean.
For now, I use a workaround and send 4 dummy bytes to make sure the slave (esp32) does get all needed bytes but I'm wondering if someone already nailed down the problem.

I also have this problem. Fortunately, I can repeat last 4 bytes as I control the master.

Hello @BigSmileFace @trancefreak77 @squonk11 @ghazel @Bogdancev ,
our SPI slave DMA has limitation that it can only receive in multiples of 4 bytes, see: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/spi_slave.html#restrictions-and-known-issues.
We also have tested for it, and it seems working well when receiving 4 bytes only. Could you try adding some delay between the cs active edge and the first clock edge, and between the last clock edge and the cs inactive edge on the master side (about 3 SPI clock will be totally enough), and run SPI slave on the latest master branch? .
If this works, but the same issue happen on earlier versions, we can backport some patches to no earlier than 3.3 for you.

I'm experiencing a similar issue, but I'm losing the last byte. If I try to read 256 bytes, I get 255, if I try to read 257, I get 256.
It does not always happen, though. I also have two SPI devices on the same bus, and only one of them is doing this.
The other one only misbehaves when it's being used on an HTTP handler; for storing data on an external SPI flash. If I try to test it on, for example, "main()", it works properly.

I'm experiencing a similar issue, but I'm losing the last byte. If I try to read 256 bytes, I get 255, if I try to read 257, I get 256.
It does not always happen, though. I also have two SPI devices on the same bus, and only one of them is doing this.
The other one only misbehaves when it's being used on an HTTP handler; for storing data on an external SPI flash. If I try to test it on, for example, "main()", it works properly.

I see this problem as well. The problem being: using ESP32 as a SPI slave, in DMA mode, and loosing the last 4 bytes.
I have an ESP32-WROOM-32D module, and have tried with ESP-IDF 4.2 and 4.4 (the master branch at this time). I have tried different SPI frequencies, and the problem is the same. The time until CS goes high must certainly be long enough.
@ginkgm Can you explain the setup for the tests in which you say that you do not see this problem? Can you try with the same ESP module I'm using? I would think that after this many bug reports saying the same thing you can conclude the the problem is real, and that you have to try harder to replicate the problem.

Hi,
I have implemented a SPI master (TX) and spi Slave (RX) multithread application and send 4124 bytes in a frame (in 4 subframe for memory problem), the latest byte (not word) was 0 for every subframe.
Yesterday I have seen that if the t.lenght field was len*9 bit (instead of 8 in TX) the frame was sent and received correctly. Obviously the frame was incompatible with the requirements. But why works if 9 bit for byte ?

Any news on this? This is a real deal breaker for me. I don't have access to the SPI master and I really need those 4 bytes.

I did not follow this for a long time. Maybe the newer versions of the ESP32 have fixed this HW bug?
I solved this by polling the port pins by SW. This was possible because the baudrate of my master was low enough.

@pgordinho Use later chips for example esp32s3 don't have this issue

@wanckl do you have a source on the fact that the esp32-s3 doesn't have this bug? The documentation for ESP-IDF still lists this restriction but the technical manual for the s3 doesn't mention the 4 byte issue.


Tabs appear as inactive(grey) when using start index

Whenever you use start index all the tabs before it are shown as disabled (grey). Is there a way to fix that?

Hi @vstoianoff
This seems to be a bug. Will fix it but as a temporary workaround you can
https://jsfiddle.net/bt5dhqtf/2783/
checkTabs(toIndex){
    let tabs = this.$refs.wizard.tabs;
    for(let i = 0; i<toIndex; i++){
     tabs[i].checked = true;
    }
}

Thanks @cristijora


bug: permit null pathname for servePath.

ran into this today. no trailing slash on servePath results in null pathname.
> require('url').parse('//cdn.example.com', false, true).pathname
null

Thanks @cgc! Published as v4.4.1.


Slow on 'J' in NORMAL mode

General information

Terminal program: iTerm.app 3.4.20 (xterm-256color)
Operating system: macOS 13.5.1 (22G90)
ZSH framework: starship 1.16.0
ZSH version: zsh 5.9 (x86_64-apple-darwin22.0)
ZVM version: zsh-vi-mode 0.10.0

Basic examination

[X] I have read through the README page
[X] I have the latest version of zsh-vi-mode
[X] I have tested with another terminal program

Problem description
Using ZVM_VI_ESCAPE_BINDKEY=jj
Reproduction steps

Press 'jj' to enter NORMAL mode
Press 'k' a number of times to navigate back/up in the history
Press 'j' to navigate down/forward in the history and notice a delay

Expected behavior
'j' should be as fast as 'k'
It seems that in NORMAL mode there is a delay after pressing 'j' perhaps because it's waiting if 'j' is pressed again within a certain timeframe (ZVM_VI_ESCAPE_BINDKEY). I would think that this is only necessary in INSERT mode to escape it.

Hi @piejanssens
Thanks for your issue. When you change the escape bindkey of normal mode to jj, it will make a common prefix of j, for j and jj, that's why the readkey engine needs to wait for a specific time ZVM_ESCAPE_TIMEOUT which is 0.3 seconds by default to accept next keystroke, by this way, it can confirm which function the user actually wants.
Thanks & Regards


ER Gateway per VNet

Without using VNet peering, VPNs or NVAs if you need to connect multiple VNets in the same region to a single ER do you need an ER gateway in each VNet?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cdb32c0-628d-0be2-f514-477d46dfa1b8
Version Independent ID: fa096059-2d16-30a2-1e8b-8b9671afcaa4
Content: Azure ExpressRoute FAQ
Content Source: articles/expressroute/expressroute-faqs.md
Service: expressroute
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@TymWongPSNinja yes, this is correct. You will need 1 gateway for each VNET.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Losing module intellisense when mapping paths

Hello everyone! First, thanks for this extension, very useful!
I tried to use the pathMappings on a project setting it up the next way:
This is my project structure
root/
  external-project/
    index.js
    module.js
  vs-project/

vseditor opens the vs-project and the user setting for pathMappings is configured as follows:
{
"path-autocomplete.pathMappings": {
    "root": "${home}/root"
  }
}

As expected, when I try to import a module, the path is autocompleted and I see the external-project reference and its content. I was able to autocomplete the next import:
import {} from 'root/external-project';

However, when I try to get the intellisense of the modules defined inside the index.js file of the external-project module, it doesn't work.
The thing is if I use relative paths, it works and I am able to see the module list of the index.js file and import module.
import { module } from '../external-project';

So, is something wrong when specifying the path mappings? I cannot get the benefit of using alias for paths and don't lose the module intellisense (autocompletion, go to definition, etc).

Hi,
The pathMappings is a configuration specific to this extension.
The intellisense from vs-code doesn't know about it and as a result it doesn't recognize the root/external-project path.
My recommendation would be to investigate if it's possible to configure a similar path mapping for the intellisense plugin.
I am closing this issue as it is not related to path completion.


Create 0000-01-02-anyaii.md

I created a branch (my-slide); I added a new file (0000-01-02-anyaii.md; and I created a commit for this file.

Merge branch to main file

Merge branch to main file


[4.x Design] Add blocking method to Scheduler

Scheduler should expose a blocking method:
trait Scheduler {
  // ...
  def blocking(r: Runnable): Unit
}

This is a complement to Scala's BlockingContext, except that it allows us to pick the right thread-pool on which to execute such blocking tasks.
Implementations could either reuse their main thread-pool, or setup a different thread-pool meant for blocking operations.

or setup a different thread-pool meant for blocking operations.

It would be a bit weird because Scheduler would become a pair of Schedulers.
However, I think it would be nice UX when combined with Task.
Similarily to CE3's blocking method.
Currently, user needs to know to use executeOn and pick correct Scheduler.

In fairness Scheduler is already a pair of thread-pools — because we need to support scheduling, coupled with thread-pool implementations that don't. ForkJoinPool doesn't do scheduling, but we add an internal ScheduledExecutorService that can take care of it.
Also blocking doesn't necessarily defer to another thread-pool. It could do nothing more but to use Scala's BlockingContext, or in case the Scheduler is simply a "cached thread pool", it could be just an alias of execute.

I think that giving the ability to safely trigger blocking operations would make Scheduler much more valuable.

I agree. I think it gives the impression of supporting a pair of schedulers because we think in terms of execution thread pools. What really matters though is the overall abstraction. An scheduler can run different kinds of code intelligently depending on the context.


fix(design): allow media gallery to be registered when they are initialized

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

@lderrickable can you please help me write tests for the updates I just made in the temp commit?

@lderrickable can you please help me write tests for the updates I just made in the temp commit?

added


Add Swift Tests

Hi,
I added encode tests to BlurHashKit.
Thanks.

Same issue here as in https://github.com/woltapp/blurhash/pull/42: The algorithm isn't really specified strictly enough for there to be exact correct results for a given image. So this test only checks that the current implementation remains as is, but that is not necessarily the correct answer. So I do not think tests are useful until there is a strict specification, if that ever happens.


Save Images With Consistent Names

Describe the Feature
Instead of generating a random UUID for the image being being saved, save the image with a consistent timestamped name eg BSKY_YYYYmmdd_HHMMSS so that it is easier to search through them in a filesystem.
Attachments
No response
Describe Alternatives
No response
Additional Context
No response

It would be nice to have the poster's current handle or DID in there before the timestamp, and if that timestamp was that of the post the image appeared in.


GH-34861: [C++] Move GTest std version check into SYSTEM if branch

Rationale for this change
Developers have reported that the current GTest std version check will break cpp microbenchmarks in BUNDLE mode.
What changes are included in this PR?
Move the check into SYSTEM if branch so that it gets triggered in a narrowed scope.
Are these changes tested?
Tested locally and will be covered by CI.
Are there any user-facing changes?
No

Closes: #34861

I dont believe the failing tests are related to my change. More like corrupted build farm.


Upload image

How we can upload the dynamic image to specific cell. Is there any way to upload the image dynamically.

yourtable.setValue('B1', 'yourbase64-image-code')

When i download the jexcel as csv file then then image is not comming instead of image it is comming the base64-image-code.
Is there any way to show image instead of showing base64-image-code once i download it

No with the image type column. You can use something different, such as this (v2). In v3 you can use updateTable to get the same results.

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jexcel/2.1.0/css/jquery.jexcel.min.css" type="text/css" />


Fixes markdown in README for github display.

Because of the lack of spaces between the ## and following text, the headers in the README file did not properly render when reading the file on Github.
This MR fixes that issue.

Thanks for this!


[feature] Add support for SQLAlchemy polymorphic models

Introduce support for SQLAlchemy polymorphic models by adjusting field defaults and handling inheritance correctly in the SQLModel metaclass. Add tests to verify functionality with polymorphic joined and single table inheritance.  Refer to #36 .

@tiangolo
Could you please comment on whether this request has a good chance of being merged?
My team and I, being under time constraints, are currently trying to decide whether to commit to this feature already.

We are also exploring using SQLModel in our products. This would be quite an ease of life in how we are building our stack.
@tiangolo do you have a timeline as to when could this be merged / what needs to be done ?


Attribute Error using AzureEmbedding class of SAMMO

For using RAG with SAMMO, I am using Azure Openai models. Below is the example of the initialization of Runner and Embedder.

Below is the metaprompt I have used.

While calling EmbeddingFewShowShotExamples in code, I am getting the below error:

Even If I instantiate AzureEmbedding class with cache = None, still this error persists.
Also I tried using SqlLiteDict for AzureEmbedding and PersistentDict for AzureChat as per documentation

But still I am getting the same error "Error: AttributeError: 'AzureEmbedding' object has no attribute '_embeddings_cache'"

@Nithyashree-coder: Happy to look into this, but can you create a minimal reproducible example and paste the code here?

@t-schn , Sure. I had reffered to rag_tuning_sammo.py  while coding. I was not getting any idea on this because there was no documentation on RAG using SAMMO. It would be great if the team shared some documentation on rag using SAMMO. I couldn't construct a minimalistic version of the code. To reproduce the error, you can check Sammo_Rag repository and run the main.py code.

@Nithyashree-coder: Thanks a lot! I was able to reproduce the error and tracked it down to an issue from a parent method not being called due to multi inheritance. See #58 for the fix. Let me know if you keep having issues!

Thank you so much! I downloaded the latest version of sammo and I am able to run the code.


New Filter for Assets by "Contact Group"

Hi,
Currently, assets can only be filtered by Contacts
Could you please add the possibility to filter assets by Contact Group in the Usage section?

This is now in the latest plugin release. Sorry for the delay.


add feature to MeanTransform

🚀 Feature Request
It is not possible to take average data for a certain period (start, stop).
Important!
The function "MeanTransform" takes data from future
Proposal

[x] 1) First of all, I want data not taken from the future
[x] 2) Add option to select averaging period

Test cases
No response
Additional context

Hello!
If you want for MeanTransform not to use data for the current timestamp you can do it by applying MeanTransform to lagged values.
In that case you create lagged values using LagTransform(in_column="column_name", lags=[my_lag], out_column="lag") and then add MeanTransform(in_column=f"lag_{my_lag}", window=my_window).

Add option to select averaging period

Can you elaborate on this? We have window parameter, isn't it enough?


Basketball Data Not Available

Hello,
The data for the basketball game is not available from http://web.mit.edu/vondrick/vatic/
The annotations are there, but not the frame data.
UCI Basketball: frames (13 GB), annotations (17 MB)
Regards,
Daniel

The author of vatic told me that he unfortunately had a hard drive crash and he no longer have the videos.We can  obtain the data on condition that someone who downloaded the materials give us  a link ,making the dataset publicly  available again. Hope that  kind man appear soon

Hi @liu666666 ,
Did you obtain a link somehow to the dataset?
Thanks,
Adrià

Any progress on this?

NO, If i have ,I will let you know


correcting whitespace and wrong commandlet

correcting whitespace and wrong commandlet

#sign-off,
@floschmsft , Thank you for submitting the fixes for the proper cmdlet and removing the extra space. We appreciate your contributions!


Use StringMatch instead deprecated matcher types

Please provide a description of this PR:
HeaderMatcher_PrefixMatch and etc are deprecated.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@kebe7jun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test release-notes

gencheck_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test release-notes

gencheck_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test gencheck

unit-tests-arm64_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test release-notes

gencheck_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test gencheck

unit-tests-arm64_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test unit-tests-arm64

lint_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test gencheck

lint_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test lint

unit-tests-arm64_istio
64fe62b3f7dd40f4c19ba875d8f1680c7939edcf
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
046845d97eae07d5ea80438c4d6efdf357dda38f
link
true
/test gencheck

unit-tests-arm64_istio
64fe62b3f7dd40f4c19ba875d8f1680c7939edcf
link
true
/test unit-tests-arm64

unit-tests_istio
64fe62b3f7dd40f4c19ba875d8f1680c7939edcf
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Wait for https://github.com/grpc/grpc-go/pull/6313

If I recall correctly, the test case here will still fail even though https://github.com/grpc/grpc-go/pull/6313 has been merged. Because grpc-go only implements StringMatch for RDS, not including RBAC's StringMatch(see here).

https://github.com/grpc/grpc-go/pull/6419 - may be ok now?

i think yes

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[CMake] Use add_dependencies in add_llvm_install_targets

Summary:
The CMake documentation says that the DEPENDS field of
add_custom_target is for files and output of custom commands. Adding a
dependency on a target should be done with add_dependency.
Differential Revision: https://reviews.llvm.org/D60879
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359042 91177308-0d34-0410-b5e6-96231b3b80d8

cc @compnerd @dexonsmith @gottesmm


Give actual page links to the social media buttons below the subscribe button

Assign me this issue to give the actual social media handles to these buttons


Firebase user data

Example bug report
Example name
with-firebase-authentication-app
Describe the bug
I want to display user displayName if user exists. I firstly render the page without the user data, then it render with it.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Go to pages/index.js
Add
Hello {user.displayName}
 after the check if there's a user in the render

Expected behavior
Don't render the page until user data isn't get.
Screenshots
That's what is happening when I reload the page:

System information

OS: macOS
Browser: Chrome 70.0.3538.77
Version of Next.js: 7.0.2

cc @jthegedus

I just checked a bit deeply, on getInitialProps, user is get from server session which return the user. The user name here is stored under a name key in the object, but it's a displayName key that is returned when onAuthStateChanged triggered.
On render, I did something like that : const name = user.displayName || user.name and I render name. It works but it's clearly weird. :(

I don't think you'll run into problems using redux with this, if you look at https://github.com/zeit/next.js/tree/canary/examples/with-redux-wrapper you can see how to install a tool like next-redux-wrapper which will give you access to the store in getInitialProps, so you can dispatch an action to store the user data.
As for the flickering issue, yeah - the data shape of the decoded session token (from verifyIdToken), doesn't match the shape of the user in the onAuthStateChanged callback. You could pass the result of the decodedToken through a function that puts it in the shape that you want, that way req.session.decodedToken has the shape that you want. I don't think there's technically a bug here though.

There is a small difference in google API when you make the request on client side compared with server side. On the server you use authentication through the user's token and the data set comes with the "name" field, while on the client side (using browser sdk) the dataset comes with the "displayName" field. There are several differences in the field names (another example is photoUrl and picture).
You can do the same thing proposed by @bastienrobert or make the modification on the server side, something like this (line 9):
server.post('/login', (req, res) => {
  if (!req.body) return res.sendStatus(400)

  const token = req.body.token
  firebase
    .auth()
    .verifyIdToken(token)
    .then(decodedToken => {
      decodedToken.displayName = decodedToken.name // mapping name to displayName
      req.session.decodedToken = decodedToken
      return decodedToken
    })
    .then(decodedToken => res.json({ status: true, decodedToken }))
    .catch(error => res.json({ error }))
})

I hope this solves your problem, bro. :fist_oncoming:


Close pipeline-async channel to continue send-chan messaging

There's a subtle bug here with the use of pipeline-async. Closing the done channel after copying the message allows pipeline-async to process the next in message.
I ran into this issue when debugging pitstop (Pitstop would stop processing messages after ~100 emits)
cc @yanatan16

So this isn't the correct fix, although there is definitely an error here. And it is subtle. Sometimes tap does not pass the close from s-ack to done. This is because we are not using mult/tap in the way they should be used because we are using/closing s-ack before returning it, so when we mult/tap it, it is unreliable that we will actually have an effect. mult/tap is designed to be used when you can tap before anything is done to the source channel, or in a stream situation. Given this, I believe we need a different fix that I will submit a PR for.


projectile-run-vterm doesn't play nicely w/ remote TRAMP projects

Executing projectile-run-vterm on a remote TRAMP project, in cases where there isn't already a vterm buffer associated w/ that project, opens up a vterm at the local homedir.

Closing as I no longer have a pressing need for TRAMP.


[1935] Error for some licenses

Open example.opossum and try to locate the license "MIT " (the last one in the list, with empty space at the end) with the new Locate Popup

Not sure what is the problem: example file is corrupted or there is an actual bug in the code.
Part of https://github.com/opossum-tool/OpossumUI/issues/1935

Suggestion:

do not write signals without resources into the redux state.
This would solve the issue and avoid running into the same issue at other places.


Ambalappuzha Sri Krishna Temple

Issue no:#4

plz balance the last 2 rows

Will you please elaborate which last 2 rows you are referring to?
On Tue, Oct 18, 2022 at 7:59 PM Harsh Vardhan Singh <
@.***> wrote:

plz balance the last 2 rows
—
Reply to this email directly, view it on GitHub
https://github.com/harshvardhansb/TourGuide/issues/81#issuecomment-1282489739,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATXBIDWLJS44UI55SXK4L7TWD2X4ZANCNFSM6AAAAAARIDGZT4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Since every row div has three  Cards in it, but the last two doors contains 4 cards. So can you just change the dev location on the code.........

I have already done that part by my side. You can check it if there is
still the same problem you can tell me.
On Tue, Oct 18, 2022 at 9:29 PM Harsh Vardhan Singh <
@.***> wrote:

Since every row div has three Cards in it, but the last two doors contains
4 cards. So can you just change the dev location on the code.........
—
Reply to this email directly, view it on GitHub
https://github.com/harshvardhansb/TourGuide/issues/81#issuecomment-1282631035,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATXBIDWDFZ66WZ6JEYHPG4TWD3CO5ANCNFSM6AAAAAARIDGZT4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Filter response headers

I would like to filder out some incoming HTTP headers, but it seems like ignore_headers is only applied to outgoing headers right now.

Seems reasonable, and easy to add.
I guess the only question is should we make ignore_headers filter both request and response headers, or have ignore_request_headers and ignore_response_headers? I am leaning towards the former, I can't see any situations where it would bite you.
I should be able to take care of this on Monday.


Company section fixed

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

Summarize what this PR fixes:-
Fixed Issue #582.
Fixed the company title and description.
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

This looks great!


Scaling option in pc_align

Having pc_align being able to solve for scale differences may be critical for handling KH9 data.  There is some existing work in this area here:  https://github.com/ethz-asl/libpointmatcher/issues/141

Good to know. We'll get to it I guess when work on KH9 starts.

I added this in. Almost all the work went into merging the above contrib properly into libpointmatcher, with unit tests and official blessing from its developer. It works only for point-to-point ICP, and only when the scale and the rotation/translation transform is not too different from the identity.


follow up #561 release footer cache in bitmap scanner

What changes were proposed in this pull request?
if will not use bitmap index, bitmap index footer cache should also be released.
Thanks @songzhan01 for finding out!
How was this patch tested?
ut

LGTM. Merged to master and 0.3


Fix logic error preventing github integration.

Use rindex() to find substring, and catch exception when not found.
rfind() returns -1, which screws up the math check for a match on
the following line, and eventually leads to invalid JSON execptions.

Update pull request with if test rather than try/except, and added a test case.

Looks good - thanks!


Add-to-cart functionality not properly functional(refuses to increment cart)

Resolved this issue, added comment to line to ensure it doesn't happen again


Hotfix: Remove Payload Reversal

User description
Something that was somehow missed in #65 is that payloads are no longer reversed. This fixes that and updates tests.

PR Type
Bug fix, Tests

Description

Removed reversal of payload in requestSignature method in NearEthAdapter class.
Removed reversal of payload in toPayload function in transaction utility.
Updated test cases in utils.transaction.test.ts to reflect payload without reversal.
Updated test cases in wc.handlers.test.ts to reflect payload without reversal.

Changes walkthrough 📝
Relevant filesBug fix

ethereum.tsRemove payload reversal in Ethereum adapter

src/chains/ethereum.ts

Removed reversal of payload in requestSignature method.

+1/-1

transaction.tsRemove payload reversal in transaction utility

src/utils/transaction.ts

Removed reversal of payload in toPayload function.

+1/-1

Tests

utils.transaction.test.tsUpdate transaction utility tests for payload change

tests/unit/utils.transaction.test.ts

Updated test cases to reflect payload without reversal.

+2/-2

wc.handlers.test.tsUpdate Wallet Connect handler tests for payload change

tests/unit/wc.handlers.test.ts

Updated test cases to reflect payload without reversal.

+12/-12

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

We shouldn't have had two places where the payload was being reversed. Should investigate how to combine these.


Movie scraping doesn't seem to be working, or DB not updating

Expected Behavior
Movies scraper should update
Actual Behavior
Movies scraper is not updating
Steps to Reproduce the Problem
Return from serv01 :-
{"repo":"https://github.com/popcorn-official/popcorn-api.git","server":"serv01","status":"Idle","totalAnimes":704,"totalMovies":20361,"totalShows":4640,"updated":1604570400,"uptime":687429,"version":"2.2.3","commit":"6c8a9a4"}

Check the status, and note the "totalMovies" value.
Wait for a day
Check again. Value should have changed over time, either adding or losing discovered movies.

NB: Shows scraper is updating fine
Specifications

Version: 2.2.3
Platform: Unknown
Subsystem: Unknown

This is the server hosted at https://tv-v2.api-fetch.sh - Does anyone know who has access to this, to fix?

I can confirm this

Could this possibly relate to PR #133 whereby perhaps the scraper URL is failing on just the movies lookup?
Again, does anyone know who has access to the aforementioned deployment? Perhaps the CI script needs fixing, to update that way? I've not idea how it's configured. Thanks.

Any updates?

This is the server hosted at https://tv-v2.api-fetch.sh - Does anyone know who has access to this, to fix?

nicksaintjohn, did you find a solution to https://tv-v2.api-fetch.sh? do you knwo why nobody is able to fix the update problem on the API (it is strange becuase the API is ansering but just old content, nothing new).
Do you know if is there nay way to use the API of getpopcorntime.is? i can not use the v0.4.4 version and change manually the api becuase i'm using KODI with an addon from https://github.com/markop159/KODI-Popcorn-Time, who was using https://tv-v2.api-fetch.sh.
Thanks,
MFM

This is the server hosted at https://tv-v2.api-fetch.sh - Does anyone know who has access to this, to fix?

nicksaintjohn, did you find a solution to https://tv-v2.api-fetch.sh? do you knwo why nobody is able to fix the update problem on the API (it is strange becuase the API is ansering but just old content, nothing new).
Do you know if is there nay way to use the API of getpopcorntime.is? i can not use the v0.4.4 version and change manually the api becuase i'm using KODI with an addon from https://github.com/markop159/KODI-Popcorn-Time, who was using https://tv-v2.api-fetch.sh.
Thanks,
MFM

I've finally had time to do some updates and fixes to PopcornTimeTV. It's now working relatively well in tvOS 14, with a hack to get search working properly again. It's a true hack, so far from perfect, but it saves you from having to quit and reload the app every now and then.
I've also switched (for now) to an alternative scraper. I have no idea who hosts it, so I may have to switch back, but it's still updating, so recent items appear on there reliably (despite the minimal releases these days).
Let me know how you get on... More updates to follow.
https://github.com/nicksaintjohn/PopcornTimeTV/tree/tvOS-14-fix

Good stuff. Can you provide ipa ?

Would appreciate an updated .IPA too.. 🙏🏻

@nicksaintjohn maybe you can be a trie saint and correct the server issues. You keen followers need   a working .ipa

Hi, firstly, thanks for all that you have done with this previously 🙏🏻
It seems that PopcorntimeTV app on AppleTV4K via AppDB no longer able to reach server where previously until recent we could still access movies already on there although there were no longer any new movies being updated which I understand is a separate issue...
Is there a way Popcorntime can be made operational once more? TIA

Hey guys,
Sadly, scrapers seem to be increasingly hard to find, and yes, the Russian scraper seems to be our only option for now... I'll maybe switch 'Shows' over to that too - I need to find out what the URL is for it. It's a nice idea to add a scraper configuration option - I'll try to do that, when I have time!
The best solution right now looks to be in migrating the Movies and TV API to the newer mechanism (as seen in the more recent official Popcorn Time apps). I've not looked into this myself, but I don't expect it to be a simple task - I also can't say if I'll ever get around to it.

Ok! Try my latest branch out guys...
https://github.com/nicksaintjohn/PopcornTimeTV/tree/pctapi-switch
Let me know if you can get it running. It's a bit buggy, but gets everything is now working again, using the 'current' scraper (used by the more recent apps). Sadly it's a big re-write, and incompatible with the older API, so I can't incorporate a scraper-switching option, as it would take too long to code it all.
Good luck!

is thios repo stioll good to run as shows, movie api?


Change SoftDelete for AverageRatings, Ratings and QuartzJobs.

@VadymLevkovskyi I like the IDto interface idea as it will do magic to simplify our code in some places. But I have a question for future:
Currently we do not really follow REST convention and do not have ids in request path for most updates as we put it in dto body.
But what if we finally decide to refactor to be more RESTy, is there maybe some recommendation we can do to both use the interface magic and follow convention?

@VadymLevkovskyi I like the IDto interface idea as it will do magic to simplify our code in some places. But I have a question for future: Currently we do not really follow REST convention and do not have ids in request path for most updates as we put it in dto body. But what if we finally decide to refactor to be more RESTy, is there maybe some recommendation we can do to both use the interface magic and follow convention?

@DmyMi - it's a good point I hadn't thought before. Let's investigate.
You'd like to have "id-less" dto's passed from front-end to presentation layer and (as I get it) there are "id-full" dto's taken from persistence layer (I'm talking about EF side, not ES, mainly because ES part is not analized deep enough).
So main question (as for me) - do we really need that "id-less" dto's?
If yes - we need 2 sets of dto's (with/without id field),
if not - have dto with id field that is sometimes ignored.
So naive solution for 1st variant:
NotificationUIDto : IDtoNoId<Notification> and NotificationDbDto : IDto<Notification> classes with duplicated fields.
Pro - DB and UI dto's could evolve independently, contra - lot of fields duplication.
Mechanical "improvement" of 1st variant:
NotificationUIDto : IDtoNoId<Notification> and NotificationDbDto : NotificationUIDto, IDto<Notification> classes where duplication is solved thanks to inheritance. As for me, this approach introduces too high coupling between UI and DB dto's, so better to avoid it.
Solution for 2nd variant:
single NotificationDto : IDto<Notification> where .Id field could be taken into account or not. Same issue with DB and UI dto's independency and additional one - you would never trust you .Id field - as you don't know whether it was populated or not.
Slightly improved solution for 2nd variant - rehydrate UI dto.Id from query string using custom model binder (one generic implementation could be enough). Have to check, but expect it to be simple enough - first use default model binder, and then add id from ModelBindingContext data. Registering such binders (all generics for concrete models) might be a tricky point, though reflection/code generation could help. Contra - it requires writing extra code. Pro - you're assured that .Id field is always correct.
(Moreover, I've even saw in internet approach where svc.GetById() - that we have as initial code in some actions - was performed directly in model binder. I have mixed feelings about this way - as it moves logic on UI level, but in kinda "elegant" way, "pretty ugly", I'd say )) )
These're possible solutions I can see, and, pay attention, that "magical Dto" interfaces (mentioned initially) aren't really the obstacle.

And here are (finally) my recommendations:

I'd prefer to have duplicated dto's for UI and DB, even if they looks similar. DB is not UI, right?
I'd prefer to have .Id encapsulated into dto via automatic handling of .Id on UI level - custom model binders, mainly because they introduce other neat possibilities such as "full-fledged" (cross-fields - i.e. first name + last name, or complex fields - i.e. email) validation (that could be reused on code level - again emails), and I don't like all that metaprogramming (attribute-powered) stuff (not reusable on C# code level).

Unfortunately both my suggestions requires extra coding, so please "choose your poison" )
--
Feel free to ping me in Teams, if you'd like to discuss it in voice


Update support page and enable custom links. #6493

Summary
Fixes

#6493 -Update Home pages

Remove the cards on the right-hand side for commercial support
Remove the 'getting started' card
Remove the 'what do you want to see...' card
Rename 'Community Support' as 'Links'
All links in this 'Links' box should now be configurable
New settings page - 'Home Links':

#6663 - Update Support Page

Move the 'Find out more ... or contact ..' link to the right hand area

#6294 - Add ability to customise the docs link.

Areas or cases that should be tested

Navigate to Configuration > Global Settings > Links
Add Custom links
Apply
Navigate back to homepage and it should have newly added custom links.

Screenshot/Video

We should keep a setting that will remove the community supported based links. Check with Neil

There are a number of unresolved comments, plus from the last review

Comment 1 from #6720 (review) - Discussed with Ken. for now would keep as it is
Comment 3 from [#6720 (review)] (https://github.com/rancher/dashboard/pull/6720#pullrequestreview-1105713714) - Not quite sure what you mean. Once API is implemented based on that support link would be shown. There is only 2 either commercial link or non commercial link. This is awaiting API implementation for support.
Comment 4 from [#6720 (review)] (https://github.com/rancher/dashboard/pull/6720#pullrequestreview-1105713714) - Discussed with Ken. for now would keep as it is
Addition Section - Comment 1 from #6720 (review) - Discussed with Neil keeping this as it is.

Comment 3 from #6720 (review)

Not quite sure what you mean. Once API is implemented based on that support link would be shown. There is only 2 either commercial link or non commercial link. This is awaiting API implementation for support.

Did the setting apply to the visibility of the whole card or just the two links? If the former, does removing all links also remove the card, if the later then we can drop that comment.

Addition Section - Comment 1 from https://github.com/rancher/dashboard/pull/6720#pullrequestreview-1105713714

Discussed with Neil keeping this as it is.

Might be worth commenting on the issue, to ensure QA don't also hit the same question

New (undiscovered bug) - Links card should not show if there are no links. Applies to home page card and possibly support page card?

This is hidden on the homepage only. Support page has 2 additional links that would always be shown

l10n can be removed for landing.commercial now that it's part of the links section

Removed.

The changes remove the card but keep the space the card was in. It looks like there was a mechanism to address this before (see home page showSidePanel). The CommunityLinks component probably needs to emit whether it has options or not... which can be plumbed in to showSidePanel

This is fixed with flexbox.

The changes remove the card but keep the space the card was in. It looks like there was a mechanism to address this before (see home page showSidePanel). The CommunityLinks component probably needs to emit whether it has options or not... which can be plumbed in to showSidePanel

This is fixed with flexbox.

Remove all links also removes the card, from your comment there should always be at least two there

Fixed

The 'you can change what you see' banner isn't aligned with the links card

Fixed

There are also 4 unresolved comments (excluding the non-blocking rancher/rancher issue).

Resolved

I'm not quite sold on internal links opening in new tabs

It would probably be an issue for docs link only. Others are not really internal links of the app. Also they are fully customisable. As it stand usage of external link icon is not consistent in the app.
@kwwii recommendation
cc: @nwmac

It would include both Get Started, Commercial Support and whatever links the user might add.
TBH we don't have to stick to the icon notifying an external link (i don't think they're used anywhere else), but adding quick links to internal pages that take the user automatically to a new tab is a bit clunky.

TBH we don't have to stick to the icon notifying an external link (i don't think they're used anywhere else), but adding quick links to internal pages that take the user automatically to a new tab is a bit clunky.

It's not consistently used. I discussed the designs with @kwwii. It was his recommendation to use the icon in the title. I can create a follow up ticket and ask Ken to take a look at it in detail.

We should combine everything from Branding, Banners and Home Links in one menu item titled "Customize UI". Users have had problems differentiating between Branding and Banners. Adding another option only makes it worse.

We should leave the links in the order the user sets and not automatically order them alphabetically. The default link order should be set according to importance.

We can remove the icon from the title. It was a simple attempt to emphasize the fact that the links will open in a new tab/window.
All inks which are not either a function or lead to another part of the UI itself should open in a new tab/window per default.

We can remove the icon from the title. It was a simple attempt to emphasize the fact that the links will open in a new tab/window.
All inks which are not either a function or lead to another part of the UI itself should open in a new tab/window per default.

'Add Label' should be 'Add Link' - and when you click it, the new row should auto-focus the first box
Fixed label
I am using KeyValue component. Issue seems to be with the component. I can follow this up in another ticket

There is no visual feedback when you click 'Restore Defaults' - maybe add a banner at the top to say defaults have been restored?
Fixed, timeout set to 10s

https://user-images.githubusercontent.com/1387263/192346764-683120be-8945-4878-b649-c9950bf005bd.mov

BUG: The file an issue link does not work if you have not visited the setting page  - the link is empty, which you see when you hover on it - clicking it opens a new dashboard in a new tab

Fixed

BUG: The links that are within the app cause the page to reload, they should not do that.
Fixed

BUG: We should NOT show the two links 'Find out more about SUSE Rancher Support' and 'Contact us for pricing' when the user has added a subscription ID. (see: Add 'Commercial Support' link to the 'Links' card - always shown at the bottom unless commercial support enabled on the home page issue)

This will be handled as part of #6665


Users can't remove themselves from small groups

This leads to issues such as being unable to submit the attendance code for their new small group, because they're still in their old one.

fixed by #538


Editing: Can't select a book

Selecting a book doesn't save it.

Now working. Maybe client problem?


Incorrect counting of traces in position.csv files (should ignore rows without trace number in position.csv)

Steps to reproduce the problem:

drop sgy file
drop position.csv file
will see the message as below

files to reproduce the problem are in archive
2022-04-29 Zond Aero 500 gas pipes.zip
Geohammer should count only rows with valid trace number (numbers from 0 and up), in columns like "GPR:Trace" or "zGPR:Trace". Please note that for different GPR models column name may have different prefics, but "GPR:Trace" will be the same.

ready


Remove pytest as dependency from asynchronous.py

Fixes #1723

Thanks @vtomole; I'm going to merge this so I can unblock building dev packages but we can revisit adding such a check in a future PR.


Error if pex file is not a sibling to science config

While testing out a scie plugin using Pants, I noticed that I get an error if the target pex file is in a different directory. Not sure if that's intentional or not - in case the desired state is to have all files as siblings.
The problem appears to be symlinking to a directory that may not exist at tempdir/{PROBLEMATIC_PATH}/mypex.pex.
Workaround
# __main__.py

for file in files:
    if file.source is None:
        path = file_paths_by_id.get(file.id) or Path.cwd() / file.name
        if not path.exists():
            raise ValueError(f"The file for {file.id} is not mapped or cannot be found.")
        target = chroot / file.name
        target.parent.mkdir(parents=True, exist_ok=True) ### <- Workaround
        if not target.exists():
            target.symlink_to(path)

Config File
# science.toml

[science]
name = "science"
description = "Ship your interpreted executables using science."
platforms = [
    "linux-aarch64",
    "linux-x86_64",
    "macos-aarch64",
    "macos-x86_64",
]

[[science.interpreters]]
id = "cpython"
provider = "PythonBuildStandalone"
lazy = true
version = "3.11"

[[science.files]]
name = "dist/science.pex"

[[science.commands]]
exe = "#{cpython:python}"
args = [
    "{dist/science.pex}",
]
env.remove_re = [
    "PEX_.*",
]
[science.commands.env.replace]
PEX_ROOT = "{scie.bindings}/pex_root"
PEX_PYTHON_PATH = "#{cpython:python}"

Error (only if Workaround is not applied)
⏺ scratch/lift % ./dist/science.pex build science.toml
Traceback (most recent call last):
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/pex", line 274, in <module>
    runpy.run_module(module_name, run_name="__main__", alter_sys=True)
  File "<frozen runpy>", line 226, in run_module
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/science/__main__.py", line 196, in <module>
    main()
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/science/__main__.py", line 174, in build
    for platform, lift_manifest in _export(application, file_mappings, td):
  File "/Users/sj/.pex/venvs/71d9ceded48a6e250231642a507b5266cd578eda/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.11/site-packages/science/__main__.py", line 121, in _export
    target.symlink_to(path)
  File<EMAIL_ADDRESS>line 1198, in symlink_to
    os.symlink(target, self, target_is_directory)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/sj/Developer/scratch/lift/dist/science.pex' -> '/var/folders/dy/q08y_dts5vd71rm99t4gc9lr0000gp/T/tmpo0tg171r/linux-aarch64/dist/science.pex'

Sorry @sureshjoshi, I totally missed this. I think you may have missed the --file name=path option for build. That said, the error should be cleaned up regardless.

Sorry @sureshjoshi, I totally missed this.

No worries, it took me a minute to remember that I wrote it!

I think you may have missed the --file name=path option for the build subcommand.

Yes, I definitely did - I thought using the toml file alone would be enough to setup the out-of-directory file configuration.
Using the --build would fit my purposes and clean up some fs code.

Ok, I didn't understand the issue before for some reason but now I do. I'm a little confused why you didn't just fix it. That threw me off here. You almost did more work above filing than it would be to fix! @sureshjoshi are you willing to throw up a PR?


train method

First, really thank you for your work. The paper was really interesting to me.
Now, I tried to train SAINetwork and made a own training code.
Scheduler, learning rate, patchsize, augmentation,,, I set those of them with the paper and your code in the same way.
But it only reached about 30 psnr (RGB Channel, Set5 dataset). If using your pretrained model(SAINx2_JPEG.pth), It reached about 32 psnr. I was not able to find any difference with your training method. So I'll really appreciate if you let me know training method in detail.

Hi, thank you for your appreciation. To the best of my recollection, the training details are all included in the paper. And the training pipeline and loss functions have been implemented in the model.py, so I think the training script would not be a big problem.
I'm wondering how these values are tested? What is the JPEG QF for testing? Is the model trained on the DIV2K set?
If it's convenient, could you please post your configure yml here so that I can check the differences?

Thank you for your reply!
Yes, I wrote training code based on your 'model.py'.
And also I tested and trained Quality Factor 75, and trained on the DIV2K dataset.
Then I think there are something wrong in my code.
Actually, I made a code using pytorch lightning. It is quite different... So I wrote configures here directly.

scale: 2
comp_quality: 75
network:
subnet: DBNet
in_nc: 3
out_nc: 3
e_blocks: 5
v_blocks: 3
scale: 2
gmm_components: 5
init: xavier
down_num: 1
optimizer: Adam
Initial Learning Rate: 2e-4
scheduler: StepLR(step_size = 2000 epoch, gamma = 0.5)
random horizontal, vertical flip
patch_size: 128,128
batch_size: 16

Thank you!

There might be some minor differences. We also use random rotation (simply transpose the width/height) for augmentation, which we forgot to mention in the paper, but it may only make a minor difference.
For the losses, we use lambda_fit_forw: 4 and lambda_rec_back: 1 for x2 experiments.
You can use IRN training script, but note that the distributed training of our model is not tested.

Oh, I didn't check the lambda values.
And I'll try to train using IRN training script.
If it works well, I'll comment here.
Really thanks!!

Hi, we have just released the training codes and configs. Hope it helps.

Sorry for late reply.
I succeded the training and the results is the same as the paper.
I really feel grateful!!
Have a good day :)


Refactor service_data object

Currently the service_data object has many return methods. These should merely modify the objects data
Also separate out locale store data and methods in to a localstore class. This class should be inherited by the service_data object and also have the ability to be initiated and manage local store data independent of a service_data object

Updating integration tests.
No more dev work will be done against QGIS2. A release will be made and then efforts moved to QGIS3


[test] test to play the audio by break point using breakpoints - v1

v1 testing:

can fetch the data correctly
edge cases (audio not exist)
edge cases (info missing)

DONE - now fixing


adding extension

Dear developers:
Hi~I am a student want to use this viewer. After I looked at your document, I still do not know how to add the extension tools you list to the viewer. Can you tell me the specific steps I need to do? Like how to register..

👋 Hello @fiona3668, this could probably be clarified better in the docs. I'm going to add labels to indicate we would accept improvements/clarifications around how to do this.
When you're building an instance of the OHIF Viewer, you're building the platform/viewer project. It consumes the other projects in this monorepo. It can be built with one or more extensions "baked in", or "bundled" with the application. This takes place in: platform/viewer/src/index.js
Extensions can also be configured and registered to an already built version of the OHIF Viewer by passing an extension in via the OHIF Viewer's application configuration. You can see an example of post-build registration in this CodeSandbox:
https://codesandbox.io/s/viewer-script-tag-microscopy-extension-44unk
In this example, if you filter the worklist by a modality "SM" and attempt to view it, you'll see that the whole-slide microscopy extension has been registered.

+1 for improving the docs about extensions. The most confusing part for me is the actual naming of extensions. E.g. in the above linked index.js it is used like this:
defaultExtensions: [OHIFDicomMicroscopyExtension]
While in the sandbox it is used:
extensions: [OHIFExtDicomMicroscopy]
And on the documentation page none of the above is mentioned. It would be nice to add a new column to the table to specify the module name and unify how to use it.

+1, I'm confused too

https://docs.ohif.org/development/ohif-cli


Check if binaries exists before attempting to load

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/profiling-node/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/profiling-node/releases

How do you use Sentry?
Sentry Saas (sentry.io)
SDK Version
0.3.0
Link to Sentry event
No response
What environment is your node script running in?

node v16.17.0
yarn pnp
M1 Mac

How is your code deployed and bundled?
Neither. Issue is on post install
Steps to Reproduce

Init repo with yarn pnp
yarn add @sentry/profiling-node

Expected Result
Binary for...-darwin-arm64 is missing so I expect it to be compiled during the postinstall step
Actual Result
Binary not build in yarn pnp
In the post install step, we try and require(target)
Since CI doesn't build binaries for M1 Mac, the require fails and enters the catch { } block.
In the catch block, we check the error messages and if it is a known error message, we attempt to compile the binaries.
This works fine in a typical npm / yarn set up since we end up matching on the Cannot find module error case.
In yarn 2 pnp, the error message is different

Qualified path resolution failed: we looked for the following paths, but none could be accessed.
and so we end up not compiling the binaries.

Instead of enumerating the error messages for all the various package managers, I feel it would be better to first assert that the binary exists in the first place or not. If it doesn't, then compile, else try loading and catch the errors
Error Log
On postinstall failure, this is the error log
# This file contains the result of Yarn building a package (@sentry/profiling-node@npm:0.3.0)
# Script name: postinstall

@sentry/profiling-node: Precompiled binary found, attempting to load...
<local-path>/.pnp.cjs:75634
      Error.captureStackTrace(firstError);
            ^

Error: Qualified path resolution failed: we looked for the following paths, but none could be accessed.

Source path: <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>Not found: <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>Not found: <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>Not found: <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>Not found: <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>
Require stack:
- <local-path>/.yarn/unplugged/<EMAIL_ADDRESS>    at Function.require$$0.Module._resolveFilename (<local-path>/.pnp.cjs:75634:13)
    at Function.require$$0.Module._load (<local-path>/.pnp.cjs:75484:42)
    at Module.require (node:internal/modules/cjs/loader:1028:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (<local-path>/.yarn/unplugged/@sentry-profiling-node-npm-0.3.0-25372e22a8/node_modules/@sentry/profiling-node/scripts/check-build.js:24:3)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10)
    at Object.require$$0.Module._extensions..js (<local-path>/.pnp.cjs:75678:33)
    at Module.load (node:internal/modules/cjs/loader:1004:32)
    at Function.require$$0.Module._load (<local-path>/.pnp.cjs:75497:22)

I've put up a PR for a potential fix https://github.com/getsentry/profiling-node/pull/122
Let me know if this is a reasonable approach!

@vidhu thanks for the detailed writeup and PR, definitely setting a great example of how to contribute 🏆  I left a tiny comment on your PR and we can be good to merge this.

@vidhu closing this issue as we merged the fix - we'll prepare a release sometime next week, thanks for your contribution!


When the build UI edits inputs it places the file in /input.json

nope, according to multiple sources (docs, warnings, PRs) this should be right as-is.


enhancement Forbid unknown stats check for internal_column

Proposed changes
Ignore internal columns when enable new optimizer and forbid unknown stats
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


Print the Hibernate ORM version used when building on CI

Fixed by https://github.com/hibernate/hibernate-reactive/commit/08eba486501fba1e0bb538b4a36ead97911c656f


Change auth seed

Changes the seed to [u8;32] instead of [u8;40] for consistency with the new key generation code. This will have to be reflected in the node as well at the moment of account generation.

On second thought, for marginally better usability the seed could be Word since RpoRandomCoin seems to use that for initialization. ChaCha20 does use [u8;32] but it seems easier to convert from the former to bytes than viceversa. Not too pressing though.


Moving svg-sprite forwards

This post was originally published on my website.

When I started developing svg-sprite more than 3 years ago, it was my first ever Node module and everything was totally new to me. I basically just wanted to create a JavaScript port of my iconizr project to get better integration into our build chain. Splitting out the SVG sprite creation part was just a logical step. I would have never thought that it should become one of the most popular libraries for creating SVG sprites, with more than 100k downloads per month at the moment. I remember well the first issues on Github, like this one from that lovely Stefan Judis guy who I'm running events together with nowadays, or Shane Osbourne's suggestion to make it file I/O independent which basically paved the way for the Gulp wrapper I came up with later.
I'm extremely thankful for all the support, input and suggestions I got from the community over time. Unfortunately, I have not always been able to respond promptly or consider them for further development — sorry for that! It all just depends too much from my general workload, which is extreme at times. It saddens me that I haven't been able to find the necessary time for really improving the library for more than a year now.
At tollwerk we're still using svg-sprite on a daily basis, mostly as part of iconizr's Gulp wrapper, and we really wouldn't want to miss it. The necessity of having PNG fallbacks for SVG icons probably tends towards zero in the meantime and also we're longing for an alternative approach using inline SVGs for quite some time now. I happens that I might finally be able to take some time for tinkering around with the many ideas I have, so let me summarize most important ones and ask for your feedback and amendments. This is what I'm planning for the next generation of svg-sprite:
New features & improvements

Single unified sprite format combining <view>, <symbol> + <use>, suitable for both background, foreground and inline usage (https://github.com/jkphl/svg-sprite/pull/81)
Plugin style architecture wherever possible — to allow for custom additions (transformations, templates etc.)
Simplified configuration (mostly by combining and dropping features)
Universal, all external JSON configuration for the CLI script so that it can be shared between all interfaces / wrappers
Completely reworked padding / margin / boxing strategy — still looking for the the most intuitive way to scale / pad things (https://github.com/jkphl/svg-sprite/issues/200)
Improved support for component library integration (https://github.com/jkphl/svg-sprite/issues/227)
Bring back the possibility of absolutely positioning and get rid of the random shifts in some browsers / situations (https://github.com/jkphl/svg-sprite/issues/142, https://github.com/jkphl/svg-sprite/issues/147, https://github.com/jkphl/svg-sprite/issues/162)
SVG gradient extraction into <defs> block during sprite compilation (https://github.com/jkphl/svg-sprite/issues/74)
More intelligent handling of embedded CSS (consolidation of styles shared between shapes)
Improved support for inline embedding & styling
More accessibility features
Possibility to create more than one sprite in parallel

Features to be dropped / deprecated

Support for SVG stacks — I doubt anyone has ever used it, also it's mostly replaceable with the <view> sprite style
The widely hated PhantomJS dependency — I guess it's benefits are rarely needed and I'd rather have this as an opt-in feature

Codebase improvements & refactoring

Rewrite to ES6
100% test coverage
Standardize code formatting / improve readability in the documentation (https://github.com/jkphl/svg-sprite/issues/223)

Other

Updated online configurator
Better documentation, examples and best practices
Possibly an accompanying JavaScript library for loading, dissecting and caching a sprite as well as swapping out references in HTML against inline SVG

I'm very much looking forward to your input! :)

I found myself relying on this great, well-documented library of yours more often than I realize. Thanks for all the great work. Keep it up!
For 2.x, I would  love to see the "combining" mode in action.


ceylon.html needs better IO

If you want to bridge from ceylon.html serialization to IO, you have to do something along the lines of
// contrived example - highly inefficient!!!
test void mkTestPage() {
    value f = newOpenFile(current.childPath("test.html").resource);

    value encoder = utf8.newEncoder();

    value ser = NodeSerializer(void (String string) {
        value cbuf = newCharacterBufferWithData(string);
        value byteBuffer = newByteBuffer(string.size * encoder.charset.maximumBytesPerCharacter);
        encoder.encode(cbuf, byteBuffer);
        byteBuffer.flip();
        f.writeFully(byteBuffer);
    });
    ser.serialize(makePage());
    f.close();
}

which is just boilerplate.

I added example with rendering to the file into the documentation, see f7797d5 (it's basically on three lines). I would rather keep ceylon.html module platform independent and it won't be possible with direct dependency to ceylon.file or ceylon.io, which are jvm only. But feel free to reopen this issue.

Three lines that don't do buffer management are just fine, no need to reopen.


Hi, dear bgottschall

Hi, dear bgottschall
I feel greatful to your contribution of your FPGA relocation sources！
I have some questions about the relocation design:
   Q1: Take the "zedboard_example" as an example, when I transfer the logic circuits form prc_0 partition to prc_1 partition, then the logic circuits in prc_0 before
   will be in prc_1 partition, thus whether the prc_0 partition will be a black box(blanking function)?

   Q2: If I want to design a project which has 1 static modoule, 4PRRs and 3 partial reconfigurable moudles (PRM)which both can be put in each of the 4 PRRs.
       Especally, 3PRMs are in cooperative work ,for example 3bits full_adder are divided into three 1bits full_adder, each of them serve as a PRM.

       At the same time, there  will be one PRM in one PRR and the rest PRR should be filled with a blanking moudule, for example,
	   at first, I put PRM0 in the PRR0,PRM1 in the PRR1,PRM2 in the PRR2,a blanking moudule in the PRR3,then  all the PRMs shift together(or one by one),
	   so now PRM0 in the PRR1,PRM1 in the PRR2,PRM2 in the PRR3,at the same time a blanking moudule in the PRR0.

	   I don't know whether I can make use of your source to make my design?  Would you give me some suggestions about my thoughts?

	thank u very much!

Sorry for the late reply,
Q1: when you have logic in prc_0 then you can create bitstreams that fit all other prc. The content of prc_0 is still the same until you have reconfigured it. You are not relocating at runtime, you are relocating bitstreams which you can then freely configure into the relocatable regions.
Q2: This is currently not supported by this work. every design is isolated and can only communicated with the static region. If you want to connect multiple PR regions you have to do this through a communication channel of the static design.


flood crosses boundaries

I have the following image and I'm trying to fill the area around (170, 135).

var canvas = document.getElementById("image");
var dc = canvas.getContext('2d');
var img = new Image();
img.src = "Bristol.png";
img.onload = function() {
    dc.drawImage(img, 0, 0, canvas.width, canvas.height);
    dc.fillStyle = 'rgb(133, 153, 0)';
    dc.fillFlood(170, 135, 0);
}

The flood escapes the area I'm trying to fill until it looks like this:

Is this a bug?

I can also confirm this bug.
It's even worse with other areas of this image, for example, 220 x 135:

However issue does seem to be a duplicate of https://github.com/binarymax/floodfill.js/issues/10

Ok, got it I think. In line 26:
for(var j=w;j<e;j+=4) {

change to
for(var j=w+4;j<e;j+=4) {

since e is the first differently coloured pixel to the right of the start, it makes sense to stop the loop before we hit it; similarly w is the first differently coloured pixel we hit to the left of the start so I think we need to begin the loop on the pixel after w.
My colouring of the wards of Bristol works fine with this change applied.

@bristol-d Great job! I suppose it worth a PR.


Update hybrid-azuread-join-plan.md

Modified alt id section to say on-premises UPN

@RavennMSFT : Thanks for your contribution! The author, @MarkusVi, has been notified to review your proposed change.

#sign-off

#hold-off


onChangePhoneNumber called with empty string on first render

When PhoneInput is rendered the first time, it does emit a onChangePhoneNumber('').
This is caught by my React component which then believes the input was reset.
This comes from code at line 244 of lib/index.js ... commenting that line does fix the issue.
Any reason for that line ?

Hello @dufourgilles this is how the lib work at the moment. It force the input field empty on the start, if you dont use a default value.


Update VNIC+NVME usecase with NVMe + TCP(Local Host) + Tunnel cases

Signed-off-by: Narayana Prasad<EMAIL_ADDRESS>

@pathreya the image was not created using https://draw.io/ or was n ot saved as editable PNG, please fix

@glimchb the diagram is generated from a dot file. I can submit it as a separate file. I will put it under images with a suffix as .dot. sounds ok?

@glimchb the diagram is generated from a dot file. I can submit it as a separate file. I will put it under images with a suffix as .dot. sounds ok?

I prefer everybody in OPI is using the same https://draw.io/

@glimchb I will find a way to convert to draw.io and upload editable PNG. It might take some time since my initial efforts to do this didnt work straightaway. I will keep at it.


Return

export default function (req, res) {
  return 'woot';
}

and
export default function () {
  return { a: 'woot' };
}

will be equivalent to:
send(res, 200, 'woot');
send(res, 200, { a: 'woot' });

@leo @kevin-roark this is a cool one in case any of you wants to take it

on it!

I think it should be as simple as https://github.com/zeit/micro-core/pull/3

Would it make sense to allow passing a response code? Maybe something like
return [201, 'Created']

@joshbetz I think at that point it would be almost as simple to just call
send(res, 201, 'Created')

But I'm not totally opposed.

I think there's great value in only returning a string or raw object. If you want to set the status code manually, use the send method. Default for raw string or object should be 200 OK

[201, 'Created'] is technically a valid JSON response right? so, impossible to disambiguate…

we can also


need to document how to restore from multiple incrementals

URL for relevant page?
http://docs.influxdata.com/influxdb/v0.12/administration/backup_and_restore/
We should give an example of restoring from multiple backups, one full and one incremental, since the full was taken. E.g. full backup of DB on April 1, incremental on April 27th since 4/1, and how do I restore the data to get back to where the system was on 4/27.

No longer incremental backups, only full. Closing issue.


AKS-CI is failing

The AKS-CI test is failing during app deployment with this error:
Deploying application ...
  2022/01/09 03:47:00 EpinioApiClient "msg"="response is not StatusOK" "error"="Internal Server Error: invalid character 'a' in string escape code" "status"=500
  error pushing app to server: can't deploy app: Internal Server Error: invalid character 'a' in string escape code

For example see this test: https://github.com/epinio/epinio/runs/4751235189?check_suite_focus=true
I was not able to reproduce the issue with manual test on Linux client as well as CI installation test running on a linux client. The CI test runs on a Windows client, maybe something is not exported correctly by Epinio which could explain this error?

The Epinio CLI complains about a 500 reply from the server. The json error parser fails, because the response is not JSON. It's likely the error message did not originate from the Epinio API server.
This might be a temporary issue, which could be fixed by retrying API requests: https://github.com/epinio/epinio/issues/807

During my Rancher Desktop tests on Windows 10, I was able to reproduce the same kind of issue:
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create ===> EXPORTING
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'paketo-buildpacks/ca-certificates:helper'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'paketo-buildpacks/httpd:httpd'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'paketo-buildpacks/php-dist:php'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'paketo-buildpacks/php-web:php-web'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding 1/1 app layer(s)
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'launcher'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'config'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding layer 'process-types'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding label 'io.buildpacks.lifecycle.metadata'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding label 'io.buildpacks.build.metadata'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding label 'io.buildpacks.project.metadata'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Setting default process type 'web'
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Saving epinio-registry.<IP_ADDRESS>.omg.howdoi.website/apps/workspace-sample-app:efeda7c398a918db...
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create *** Images (sha256:c357ebf50d5300a24bcf95683cf7f566690a804420decccc9dcb63512f805c72):
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create       epinio-registry.<IP_ADDRESS>.omg.howdoi.website/apps/workspace-sample-app:efeda7c398a918db
🕞  [efeda7c398a918db-stage-bbtkn-pod-p6v8g] step-create Adding cache layer 'paketo-buildpacks/php-dist:php'

Deploying application ...
2022/01/18 16:48:43 EpinioApiClient "msg"="response is not StatusOK" "error"="Internal Server Error: invalid character 'U' in string escape code" "status"=500
error pushing app to server: can't deploy app: Internal Server Error: invalid character 'U' in string escape code

@jimmykarily do you think that @manno idea could solve the issue?

@ldevulder it could but I can't tell because I don't know what the issue is :). I think we should try to unmarshal the response as JSON but if that fails, instead of printing the unmarshaling error, we should print the original one with something like:
We couldn't unmarshal the erro as JSON, the original response was: blah blah

This way we won't hide the actual error. We can decide about retrying after we find what the problem is

@ldevulder we can't tell where the error comes from. You could be talking to any server (DNS problem), the loadbalancer (ingress/tls problem) or the Epinio API server.
The problem with retrying is, that in our client implementation the 'curl' (it's not curl) helper hides some response fields. Every client method, has different conditions on what responses are considered to be ok and not a hard failure.

Can you try with a higher trace level?
Since the error is reported client-side, you only need to export TRACE_LEVEL=255. You could also use --trace-level.
See https://github.com/epinio/epinio/blob/main/.github/ISSUE_TEMPLATE/bug_report.md
If you want to see more logging on the server side, you either have to deploy with a higher trace level, or you edit (k9s, kubectl edit, ...) the epinio server deployment and change the TRACE_LEVEL env var.

Here the logs after trying to push an app, hope it will help!
epinio-dev-push.log

It looks to me like the client reached the right server. Can't be sure because the body is not logged by the current Epinio version, but the header "Access-Control-Allow-Origin":["*"] looks like the one we set?

Having a look at the logs I've seen that is originated from here
https://github.com/epinio/epinio/blob/9b66f630027d0019ca34d65eb06b7a7cf4f517df/internal/api/v1/application/deploy.go#L170-L174
and the problem is within the SetOrigin function, that is creating the JSON body "manually"
https://github.com/epinio/epinio/blob/9b66f630027d0019ca34d65eb06b7a7cf4f517df/internal/application/origin.go#L107-L140
On Windows the path are defined with a backslash, like C:\Documents\myapp and this is causing an issue on the unmarshal of the body from the Kubernetes api.
I did a test that is failing in the same way, so I'm pretty confident that's the problem.
I'll try a fix and let you know.

Oh ... Blame me then, that is my code.

And https://stackoverflow.com/questions/9371031/how-do-i-create-crossplatform-file-paths-in-go might be helpful.


fix(pdk): response.exit accept bytes

fix 9294

as we are doing this, could you also update for SetRawBody and GetRawBody as well?

Do not forget to add change log entry.

Technically, Ctx_GetShared can return raw binary strings, and Ctx_SetShared can accept raw binary strings. But we are ignoring them for now.

Maybe we should be more specific about the version that will be incompatible, but we need to merge the PR https://github.com/Kong/go-pdk/pull/132 first, and that PR is waiting for this PR to merge...


Default promitor scraper values generates invalid metrics-declaration.yaml configuration

When leaving the metrics value at it's default metrics: [] it generates an invalid metrics-declarions.yaml configuration due to creating a line break bettween metrics: and []
Expected Behavior
Default metrics value should deploy a promitor instance with a valid configuration.
valid config:
metrics: []

Actual Behavior
Promitor fails to launch due to invalid metrics-declarions.yaml configuration.
invalid config:
metrics:
  []

Steps to Reproduce the Problem

Deploy promitor scraper with default values for metrics

Specifications

Version: 2.6.0
Platform:
Subsystem:

Thank you for reporting, are you willing to open a PR?

Thank you for reporting, are you willing to open a PR?

Honestly never edited a helm chart, but here's my attempt https://github.com/promitor/charts/pull/65


Support getting bootstrap replica in Helix Full auto mode

Codecov Report
Patch coverage: 10.71% and project coverage change: +0.02 :tada:

Comparison is base (ee76c51) 14.44% compared to head (53316ac) 14.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2413      +/-   ##
============================================
+ Coverage     14.44%   14.46%   +0.02%
- Complexity     2346     2352       +6
============================================
  Files           773      773
  Lines         60483    60544      +61
  Branches       7405     7413       +8
============================================
+ Hits           8734     8759      +25
- Misses        51241    51275      +34
- Partials        508      510       +2

Impacted Files
Coverage Δ

...n/java/com/github/ambry/clustermap/ClusterMap.java
0.00% <ø> (ø)

.../com/github/ambry/cloud/VcrReplicationManager.java
0.00% <ø> (ø)

...in/java/com/github/ambry/clustermap/AmbryDisk.java
0.00% <0.00%> (ø)

...a/com/github/ambry/clustermap/ClusterMapUtils.java
37.02% <ø> (ø)

...rc/main/java/com/github/ambry/clustermap/Disk.java
0.00% <0.00%> (ø)

...m/github/ambry/clustermap/HelixClusterManager.java
0.00% <0.00%> (ø)

...a/com/github/ambry/server/AmbryServerRequests.java
0.00% <ø> (ø)

...in/java/com/github/ambry/store/StorageManager.java
76.59% <0.00%> (+3.26%)
:arrow_up:

.../main/java/com/github/ambry/store/DiskManager.java
71.17% <100.00%> (+0.43%)
:arrow_up:

...n/java/com/github/ambry/clustermap/MockDiskId.java
61.90% <100.00%> (+11.90%)
:arrow_up:

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ Turnos 24x7 has degraded performance

In ab7b1d1, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 938 ms

Resolved: Turnos 24x7 performance has improved in ea1d758.


Important details for using the webhook wth custom CI/CD missing

This page tells us where we can get the Webhook URL to integrate with our own CI/CD system.
However it doesn't tell us how to format the HTTP request to this URL.

is it a GET or a POST
what is the payload (if any)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddc210db-9bbc-1787-8842-0dd29ca2919e
Version Independent ID: d34bf633-bee3-c1ce-72dd-0c80f17f84ad
Content: CI/CD to custom containers - Azure App Service
Content Source: articles/app-service/deploy-ci-cd-custom-container.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@Ramblurr Thank you for your feedback! We will review and update as appropriate.

@Ramblurr Thanks again for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

This is out of scope for this article. #please-close


Custom events do not appear in "Custom Events" dashboard

I have integrated everything as described (including call recordEvent()), but custom events do not appear in "Custom Events" dashboard. No errors in console. Also, I have tried many diffrerent variations, like setting endpoint manually, using startSession(), createEvent() functions, but I have not found combination which would work. Does custom events functionality work with js for anyone?

I have exactly the same problem...

We're happy to see if there is an issue with the JS SDK, some quick questions to help us determine the issue:
1.Which version of this repo are you using? (0.9.0 or 0.9.1)
2.Which version of the AWS SDK are you using? (Please note Mobile Analytics was not added until v2.1.18 though newer improvements depend on v2.2.37)
3.Which client are you using AMA.Manager or AMA.Client?
4.Is this integration intended for desktop browsers, mobile browsers, web views or HTML5 apps (cordova, phonegap, etc...)?
5.Finally, are you able to verify if requests are being made to the Amazon Mobile Analytics Service (please note the response code, 202 or 4XX)?
Please note that you can always reach out to us directly at<EMAIL_ADDRESS>(Please include AWS Account ID and AMA Application ID) or post in the AWS Forums (do not post your AWS Account ID to the forums, AWS Support can retrieve this information from your login).

0.9.0
v2.2.33
AMA.Manager
Ionic app (cordova)
I don't see any responses output in console. Is there a way to enable it?

I can see users and sessions in aws dashboard, but no custom events and no monetization events.

You can enable the output messages by adding a logger has option of AMA.Manager.
... new AMA.Manager({             appId : _APP_ID,             ...             logger: console         };
Personally I have "Events Submitted Successfully" (but nothing on the AWS dashboard).

Please go ahead and engage us via email at<EMAIL_ADDRESS>(Please include AWS Account ID and AMA Application ID) or post in the AWS Forums (do not post your AWS Account ID to the forums, AWS Support can retrieve this information from your login) so that we can dive into this discrepancy further.

This is the reason, why my events have failed:
"Event Metric and Attribute Count cannot exceed 40"
Are there any plans to support higher number of metrics/atributes in future?

I have the same problem. But in my case i try with console logger, and looks like all normal:

1.- 0.9.1
2.- v2.3.3
3.- AMA.Manager
4.- Ionic app v.1.7.14 (cordova v.5.4.1)
5.- I obtain 202

Hi @kest85,
I apologize for the long delay getting back to you on your question about increasing the limits of our service (http://docs.aws.amazon.com/mobileanalytics/latest/ug/limits.html).
Unfortunately we can't make any comments about our plans or feature road-maps here, however we're always interested in learning more about our customer's use cases and ways in which you would like to use our products.
If you'd like to discuss your use case for high-number of metrics and/or attributes please don't hesitate to engage us via email at<EMAIL_ADDRESS>or post in the AWS Forums (do NOT post your AWS Account ID to the forums - AWS Support can retrieve this information from your login).


Merge pull request #470 from MicrosoftDocs/master

Redirect pendmoves and regjump dl links

Docs Build status updates of commit 59185be:
:warning: Validation status: warnings
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel