Add alias_method macro to object

It has the same limitation as delegate as you might imagine

We actually had this macro before and removed it. We don't want aliases in the language, it makes everyone having to learn a dozen of ways to do the same thing.

Reference: https://github.com/manastech/crystal/issues/1179#issuecomment-131267190

I understand why you don't want to use it inside the standard library but it still makes sense to keep it available.
I'm currently working on crystal-gl. I'm generating a lot of code using script and macros with names i can't change and want to give them more convenient names in some case

I consider this to be kinda important.

I vote for not to support aliases, it's make a lot of mess everywhere

People are going to use aliases. It's just calling to have everybody have
their own implementation everywhere.
On Fri, Apr 8, 2016 at 12:50 PM, Kiril Dokh<EMAIL_ADDRESS>wrote:

I vote for not to support aliases, it's make a lot of mess everywhere
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/crystal-lang/crystal/pull/1966#issuecomment-207374459

@elthariel But just see, from the Ruby world, developer should know what the alias reduce or inject, map or collect - that makes life harder. I've faced up few times with something like that during debugging: well, reduce(first time I've seen it) what is this ?  Don't force restrictions on programmers just to save yourself a moment's googling.

It's not because there are bad use cases that there is only bad use cases
On Sat, Apr 9, 2016 at 2:38 PM, stugol<EMAIL_ADDRESS>wrote:

reduce makes sense. inject is just stupid. Don't force restrictions on
programmers just to save yourself a moment's googling.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/crystal-lang/crystal/pull/1966#issuecomment-207785644

Python's "only one way to do it" makes a lot of sense, I've liked Crystal for the same, at the one of Ruby Conf Batsov said that alias_methods is a bad part of Ruby as well, but anyway this is decision which should make @asterite and other guys from the core team.

Some guy at PyCon also had a talk about how functions were better than
objects, you can find quotes saying everything, but this is dialectics.
Beside, python's mottos are often wishful thinking: Let's consider
"everything should be explicit" vs the implementation of properties.
IMO, the point is somewhere else. alias_method is trivial to implement.
It's going to happen in the user's codebases. It's better to have it and
document its shortcomings than just ignore it.
On Sun, Apr 10, 2016 at 11:40 AM, Kiril Dokh<EMAIL_ADDRESS>wrote:

Python's "only one way to do it" makes a lot of sense, I've liked Crystal
for the same, at the one of Ruby Conf Batsov said that alias_methods is a
bad part of Ruby as well, but anyway this is decision which should make
@asterite https://github.com/asterite and other guys from the core team.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/crystal-lang/crystal/pull/1966#issuecomment-207951032

everything should be explicit

It actually goes like this:

Explicit is better than implicit.

and is eventually followed by:

Special cases aren't special enough to break the rules.
Although practicality beats purity.

Which explains properties right there.

@elthariel alias_method is not trivial to implement: named arguments won't work, neither splat nor block argument. I don't think it's good if we provide a macro in the standard library that doesn't work in all cases. In the future we will probably fix these shortcomings, but in any case I don't think aliases are a good thing. Note that this is subjective, but, well, when you design a language you have to make strong decisions most of the time.

I forgot about those important details ^^. It makes sense not to have a
semi-working implementation of something. That being said, I hope the day
comes when we can implement it properly, even if I understand this is not a
priority right now.
On Mon, Apr 11, 2016 at 12:19 AM, Ary Borenszweig<EMAIL_ADDRESS>wrote:

@elthariel https://github.com/elthariel alias_method is not trivial to
implement: named arguments won't work, neither splat nor block argument. I
don't think it's good if we provide a macro in the standard library that
doesn't work in all cases. In the future we will probably fix these
shortcomings, but in any case I don't think aliases are a good thing. Note
that this is subjective, but, well, when you design a language you have to
make strong decisions most of the time.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/crystal-lang/crystal/pull/1966#issuecomment-208083479

I used ruby since close to 20 years.
I abandoned alias_method a long time ago. I do, however had, use "alias" a lot.
I can already simulate it via:
def foo
end
def bar
foo() # using the () just to make it clearer
end
so using:
alias foo bar

just saves me a few keys.
So while I don't care about alias_method, I am missing "alias"
to methods.
crystal, however had, already (!) uses aliases:
https://crystal-lang.org/reference/syntax_and_semantics/alias.html
alias PInt32 = Pointer(Int32)

So the above statement that aliases in itself are "bad" or "impossible"
or "lead to chaos" is strange if aliases in crystal are already used as
shortcut to re-aliases types. IMO it should be possible to alias
methods too - this is purely from an efficiency point of view.
(I think some of the discussion goes into alias_method, but
let's simply ignore the alias_method issue and focus solely
on aliases. Crystal already uses them. It feels weird to
say crystal allows aliases to types but forbids them elsewhere.
Perhaps there could be a high-ruby compatibility mode. That
way you could still not officially support it, but allow for users
who got used to them to keep on using them in their own code
base as a compromise.)
The other parts of "aliases are the end of the world" is just pointless
opinion and ultimately FUD. It's ok to not want to add them, because
I also agree that there are trade-offs - for instance, grepping through
source code at a later point is made harder if you, like me, use really
simple editors (yup, I use a very simple, outdated editor and I get
by just fine). But to make it based on what Ary wrote like stating
"I don't think aliases are a good thing", without really explaining
WHY, is ultimately just an opinion. And I disagree on it completely.
I agree about that you have to make decisions - this is correct.
I am saying that these decisions should be based on specific
goals and objectives, and not on emotions or "my personal
opinion is that aliases lead to the end of the world". They add
complexity indeed, but to reason that aliases are never useful,
even more so when crystal already (!!!) uses them for types,
is making this a very, very strange discussion ... even if the
decision it never changed, the rationale should be based on
specific arguments or preferences by this or that trade-off.

Not to encourage your intended use of aliases, but you can see two macros that deal with aliases here:
https://github.com/crystallabs/crysterm/blob/master/src/macros.cr
The first one, alias_method, is a copy of the macro that was present in Crystal itself up to some point.
The second one, alias_previous, is a convenient way to define an alias for a method you have just defined. Something like:
def myname
  # Do something
end

alias_previous :yourname

You're mixing two different but homonymic concepts. Type aliases are not to be confused with method aliases. A method alias is just a different name for another method. Crystal's philosophy is to avoid that because it's at best unnecessary and at worst causes extra friction and cognitive load.
Type aliases however are a means to give complex types (such as big union types) a name that allows identifying them efficiently.
A typical example for that is JSON::Any::Type:https://github.com/crystal-lang/crystal/blob/cadc4b3c7003279d93be4780afa5f0bc8e6cf6f1/src/json/any.cr#L21
It's refered to in several other places and listing all those member types of the union every time would be excruciatingly verbose. Using a type alias gives it a distinctive name which can be used as a reference.


Old clinicService name in controllers constructors

Old name is used for constructor parameters in OwnerController and VetController

Seems pretty harmless to me. No objection if you want to fix it though.

Seems pretty harmless to me. No objection if you want to fix it though.

Could u plz assign this issue to me if this reporter @d1gest won't do so🥰? I'll be glad to do so❤.
 Generally I would say don’t wait. We don’t use assignments as part of any normal process.

Assigned. Generally I would say don’t wait. We don’t use assignments as part of any normal process.

Thanks, I will fix it as soon as possible🥳. One question, if not assign issue and two different team member working on the same one, how to deal with this situation?🤔


org.graalvm.polyglot.Engine class not found!

Dear GraalVM Team,
I hope you are doing well. I would like to extend my gratitude for your continuous effort in making GraalVM the best JavaScript implementation available. I am truly impressed by the quality of your work.
Recently, I encountered an issue after installing GraalVM 23.1 (based on Java 21 version) and incorporating the NodeJS addon from this link: https://github.com/oracle/graaljs/releases/download/graal-23.1.0/graalnodejs-jvm-23.1.0-windows-amd64.zip.
Upon launching my NodeJS program, I received the following error message:
org.graalvm.polyglot.Engine class not found!
Exception in thread "main" java.lang.NoClassDefFoundError: org/graalvm/polyglot/Engine
Caused by: java.lang.ClassNotFoundException: org.graalvm.polyglot.Engine
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)

For your information, the NodeJS program runs smoothly with GraalVM 23.0.1 using NodeJS installed via the command line through GraalVM's bin directory (which doesn´t seem to be available anymore with 23.1).  I am uncertain about the cause of this problem and would greatly appreciate your guidance.
It is crucial for me to use the NodeJS implementation based on the GraalVM JVM, rather than the Native Image version, due to the heavy calculations my script performs and the extended runtime it requires. The JVM runtime parameters and optimizations I've implemented through extensive testing with version 23.0 have proven beneficial for this.
Thank you once again for your commitment to excellence. I look forward to your advice and guidance on this matter.
Best regards,
Lorenz

Recently, I encountered an issue after installing GraalVM 23.1 (based on Java 21 version) and incorporating the NodeJS addon from this link: https://github.com/oracle/graaljs/releases/download/graal-23.1.0/graalnodejs-jvm-23.1.0-windows-amd64.zip.

This is not an addon. This is a standalone version of graal-nodejs on top of GraalVM 23.1. If you want to use graalnodejs then the second artifact that you've mentioned should be enough. There is no need to "incorporate" it somewhere (which is most likely the culprit of the issue that you are facing).

Thank you for the assistance, but the project was originally located in a distinct directory, located just beneath the main GraalVM directory, though it remained isolated. Relocating it to an entirely new directory, which involved unpacking it from scratch as a precautionary measure, yielded no discernible difference, as the same error persisted.
However, I managed to identify the root cause of the issue. It turns out that modifying the command line parameter from "--vm.XX:-UseJVMCINativeLibrary" to "--vm.XX:+UseJVMCINativeLibrary" resolved the problem, and everything now functions as expected.
My current concern pertains to the documentation, which suggests that using "--vm.XX:+UseJVMCINativeLibrary" opts for the precompiled (native) library, rather than allowing the Graal compiler to optimize itself by avoiding the use of the precompiled native library. I'd greatly appreciate it if someone from the Oracle team could provide insights or comments regarding this matter. I've always regarded this option as a valuable performance enhancement. Many thanks.

I am sorry, I am still not able to reproduce the mentioned exception:
node.exe --vm.XX:-UseJVMCINativeLibrary
Cannot use JVMCI compiler: No JVMCI compiler found

I am getting the same result on both Windows and Linux. I assume that this result is expected i.e. that the standalone distribution of graal-nodejs does not contain jargraal.

My current concern pertains to the documentation, which suggests that using "--vm.XX:+UseJVMCINativeLibrary" opts for the precompiled (native) library, rather than allowing the Graal compiler to optimize itself by avoiding the use of the precompiled native library. I'd greatly appreciate it if someone from the Oracle team could provide insights or comments regarding this matter. I've always regarded this option as a valuable performance enhancement for long-running projects that are in need of maximum throughput instead of fast startup.

It is recommended to use libgrall/-XX:+UseJVMCINativeLibrary. Note that this option affects the compilation of the compiler itself only i.e. it has no impact on the code produced by the compiler (which is what matters for a long running application).

Thanks for the reply. I will run some performance tests today to see how using libgral instead of letting the compiler optimize itself as well but not using this precompiled lib affects my NodeJS application. However, from past Graal releases, it made a 5% steady performance difference for me to not use libgral. Let´s see...

I have conducted comprehensive tests on my application, which involves intensive calculations (number crunching for the development of an automated trading system). This application runs continuously on my computer, utilizing both NodeJS running on GraalVM 23.0.1 with the "-UseJVMCINativeLibrary" flag and the new standalone 23.1 NodeJS Enterprise version, available at https://github.com/oracle/graaljs/releases/download/graal-23.1.0/graalnodejs-jvm-23.1.0-windows-amd64.zip.
The results of my testing indicate that GraalVM 23.0.1 with the "-UseJVMCINativeLibrary" flag is 6% faster than version 23.1.0, which no longer supports the "-UseJVMCINativeLibrary" option. Consequently, version 23.1.0 can rely solely on the precompiled, non-self-optimizing compiler. This performance disparity is equivalent to running version 23.0.1 with the "+UseJVMCINativeLibrary" option enabled. It appears that version 23.1.0 lacks support for compiling libgraal JIT.
I would like to inquire whether the Oracle Team intends to reintroduce this feature. It would be unfortunate to experience a 6% performance decrease if I wish to leverage the new version for its additional features while being compelled to stick with version 23.0.1 for optimal performance.
Thank you for your attention to this matter.


global is not defined

Attempting to use twilio-chat in an Angular project with TypeScript. I've tried various methods of importing and they all result in this error when trying to instantiate the Client.

import * as Chat from 'twilio-chat';
const client = await Chat.create(token); // ERR

import Client from 'twilio-chat';
const client = await Client.create(token); // ERR

import { Client } from 'twilio-chat';
const client = await Client.create(token); // ERR

core.js:15714 ERROR Error: Uncaught (in promise): ReferenceError: global is not defined
ReferenceError: global is not defined
    at Object../node_modules/twilsock/lib/tokenStorage.js (tokenStorage.js:51)
    at __webpack_require__ (bootstrap:83)
    at Object../node_modules/twilsock/lib/client.js (client.js:14)
    at __webpack_require__ (bootstrap:83)
    at Object../node_modules/twilsock/lib/index.js (index.js:3)
    at __webpack_require__ (bootstrap:83)
    at Object../node_modules/twilio-chat/browser/client.js (client.js:71)
    at __webpack_require__ (bootstrap:83)
    at Object../node_modules/twilio-chat/browser/index.js (index.js:3)
    at __webpack_require__ (bootstrap:83)
    at resolvePromise (zone.js:814)
    at resolvePromise (zone.js:771)
    at zone.js:873
    at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:421)
    at Object.onInvokeTask (core.js:17280)
    at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:420)
    at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:188)
    at drainMicroTaskQueue (zone.js:595)

Inspecting tokenStorage.js reveals the culprit two lines.
/**51 **/ TokenStorage.sessionStorage = global['sessionStorage'];
/**52 **/ TokenStorage.window = global['window'];

Adding (window as any).global = window; is a workaround but one that should not be needed.
I'm not sure if this is the correct place to file issues as the twilio-chat library does not seem to be open source and there isn't a bugs entry in package.json.

I'm having the same issue but in my case the (window as any).global = window; trick doesn't work either. Did you find a better fix?

i am encountering the same problem as above. And the hack is not (window as any).global = window;

I've added, window.global = window; in head of my index.html and it worked.

I've added, window.global = window; in head of my index.html and it worked.

This worked for me, too! Thanks so much.

I've added, window.global = window; in head of my index.html and it worked.

Works, but it is very dirty solution.
@dmorilha-twilio


7.0 xp progression

Data from Table under
###Reworked XP
http://www.dota2.com/700/gameplay/#HeroLeveling

#11

Should we make a new file instead so we still have the old values for legacy matches?

True, but then a file for each time its been patched? Or current and previous only. I'll make another request tonight based on your answer

I'll just take this for now.  We use this in two places:

Computing hero levels in teamfights
displaying level on XP graph

The numbers will be a bit off for legacy matches but the number of people visiting those pages is significantly lower.  If there's demand to maintain accuracy for multiple versions we can add that in at a later point.


MINOR: Remove unreachable if check

@gwenshap @granders could you guys take a look at this trivial change. This piece makes one think that for SSL, not passing new_consumer=True should be fine. It was fine until recently, before https://github.com/apache/kafka/commit/e6b343302f3208f7f6e0099fe2a7132ef9eaaafb.

This is to set new-consumer to true if SSL is specified, which makes sense to me (since SSL is not supported in old consumers).

I agree with Gwen that this behavior seems reasonable; also it would be good to check usage of the constructor to see if any usages rely on this behavior (I suspect some benchmark tests might rely on this).
Perhaps rather than deleting this if block, we could just log the change to make it more visible?

I too agree that it is reasonable behavior :). It is just that it will
never be exercised as new_consumer is by default set to false. So, one can
not just set security_protocol and expect that new_consumer will be set
automatically. It used to be that case, however that changed in
https://github.com/apache/kafka/commit/e6b343302f3208f7f6e0099fe2a7132ef9eaaafb,
unless I am missing something.
On Mon, Nov 2, 2015 at 11:41 AM, Geoff<EMAIL_ADDRESS>wrote:

I agree with Gwen that this behavior seems reasonable; also it would be
good to check usage of the constructor to see if any usages rely on this
behavior (I suspect some benchmark tests might rely on this).
Perhaps rather than deleting this if block, we could just log the change
to make it more visible?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/kafka/pull/396#issuecomment-153135828.

--
Regards,
Ashish

Good point, that is my fault :) In that case,  maybe change the signature back to default to to new_consumer=None and update the comment to reflect the fact that if new_consumer is not set, its value will be determined by choice of security protocol?

I am fine with your suggestion. I was just not sure about the intention
behind changing the default, so I suggested to remove this.
On Mon, Nov 2, 2015 at 12:12 PM, Geoff<EMAIL_ADDRESS>wrote:

Good point, that is my fault :) In that case, maybe change the signature
back to default to to new_consumer=None and update the comment to reflect
the fact that if new_consumer is not set, its value will be determined by
choice of security protocol?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/kafka/pull/396#issuecomment-153143409.

--
Regards,
Ashish

@granders @gwenshap I have rebased again. If this looks OK to you, could you commit this.

@gwenshap @granders pinging again :)

Ahh.. looks like it is no longer needed.

@gwenshap @granders could you guys take a look at this trivial change. This piece makes one think that for SSL, not passing new_consumer=True should be fine. It was fine until recently, before https://github.com/apache/kafka/commit/e6b343302f3208f7f6e0099fe2a7132ef9eaaafb.


[stable/elasticsearch-exporter] Adding pod annotations

What this PR does / why we need it:
Adding ability to specify pod annotations
Which issue this PR fixes
fixes #7959
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

CC: @Stelminator

/ok-to-test

/assign

/lgtm


Add CONTRIBUTORS.md documentation

To setup a basic CONTRIBUTORS.md markdown file to document the various contributors of this project

Please assign me!

@rahulssv Hi Rahul, I will be handling this issue as I require the contributors.md file to be in a specific format.

Issue is closed from PR #13


Story steps should be of the same kind.

a1s1 can't be coroutine while a1s2 is a function.
A suggested implementation:
steps = ['a1s1','a1s2','b1']
methods = {'a1s1': f, 'a1s2': async f}
kinds = {is_coroutine_function, methods.values()} # set generator
if kinds == {True, False}:
    raise exception (class has mixed methods)

Superseded by #723


[#160342179] Add the quota name into the org usage script

What
The addition of the quota name enables filtering by default quotas to
find orgs that should now be being billed.
How to review
code review
login to an environment and run ./scripts/org-usage-report.sh >org_usage.csv check that quota names are in the csv file
Notify scripts were used by @paroxp in https://www.pivotaltracker.com/story/show/158999882/comments/191826613
Who can review
Not @LeePorte

The two scripts being introduced here take file inputs which don't necessarily exist. See comments on https://github.com/alphagov/paas-team-manual/pull/247

Both of the scripts introduced here are operating on the same data structure, so we should probably use a single script and parameterise the JSON file it is operating on.

Comments here have raised the question for me of why we're using Node for these scripts. All the other scripts in this repo are either bash or ruby. I'm reluctant to add another language here without a good reason.
Is there a good reason to be using Node for these?

@alext I agree. It doesn't look like a good place for these.
But, if it's meant to help and continue with some stories, I have few good reasons for it to be in Node:

This code has already been written a while ago - why rewrite it in something else.
Bash doesn't have the Notify Client :D Though we could use curl and/or ruby client instead - this is more work though.
These JS scripts are meant to go into paas-admin some day - which is written in Node.

We could restart the story and work that functionality into paas-admin already? Otherwise we may need to do it all again (probably next quarter).

This story has changed in scope. We are only automating notification for abandoned orgs. We will do this in the Notify UI for now, and so won't require the controversial Node script. See https://github.com/alphagov/paas-team-manual/pull/247 for details of the process.


SlicerCART new main branch is not found as a module by 3D Slicer

This issue is about fixing the use of the adapted Slicer CART module, so it appears automatically (e.g. in Examples --- Slicer Manual Annotation) when
In fact, when the most recent version of this repo is being downloaded, the module is not found by 3D Slicer even after restart.

Hi @maxradx,
As described in the README, we must "add the path of the folder containing the SlicerCART.py".
Here is a screenshot of my 3D Slicer configuration.

Let me know if this doesn't solve the issue!

Thanks for the input! Previously, there were some requirements that we could install, and now there isn't. I would need to install PyQt5 for example. the code to execute in the python console that install the requirments could be put in the README?

Thanks for your suggestion! I've added this section to the README.


Add ability to remove command line file from mobile devices

Description
Added buttons to the Mobile section in SpatialGDK Editor settings to remove the command line file from mobile devices.
Original author: @jayprobable
Original PR for reference: https://github.com/spatialos/UnrealGDK/pull/2016
Primary reviewers
@joshuahuburn @samiwh

The C# executables (DeploymentServer and MobileDeviceInterface) are not being recompiled on Mac so this presents a problem when trying to remove the command line on iOS from Mac.


Supporting instance group tags

This PR is document the functionality from this PR: https://github.com/cloudfoundry/bosh/pull/2448

Make sure the documented version matches when the above PR gets merged.


Add regex_find_replace

Adding Regex Find And Replace and Column Regex Find And Replace from
https://github.com/galaxyproteomics/tools-galaxyp/tree/master/tools/regex_find_replace
Is this correct? Ping @mvdbeek

@galaxybot test this

@galaxybot deploy this

@galaxybot deploy this


vladmandic / automatic - depthmap - numpy 1.24.3

https://github.com/vladmandic/automatic/issues/1068
numpy was updated, vlad updated his a1111 fork repo and depthmap isnt compatible with numpy 1.24.3
AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself.
Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64`
here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

I also have this issue with but with regular a1111


Atmosphere dosent scale together whit the planet

So i cant get it to work so i removed it, if you know how, please somehow implement it cause i am just getting weird bugs after adding it like nothing getting rendered


Switch from :uuid to :elixir_uuid

The :uuid library has changed it's name to :elixir_uuid. This causes a conflict error when building our app since other libraries depend on :elixir_uuid:
==> Release failed, during .boot generation:
        Duplicated modules:
    	'Elixir.UUID' specified in elixir_uuid and uuid

BTW.
I can make a PR with that but locally tests are failing due to:
** (EXIT from #PID<0.204.0>) shutdown: :econnrefused

@timbuchwaldt Any suggestions how to handle it?

Hey, sorry for the slow response.
I just updated to 0.6.1 -> All dependencies updated.


correct missing commas

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


fix: remove unstable notification at deposit via poa

We cannot rely on the last added deposit in the PoA response (recent_deposits) as we do not know the source where the deposit was made or from what dApp.
It's better not to show anything at all, that's why this notification was removed.

:tada: This PR is included in version 2.25.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Swagger Validator Error when application is deployed

Environment:

Python version: 3.12
Operating system: Windows
Flask version: 3.0.2
flask-openapi3 version: 3.0.2

I have created an application using this module and deployed it to an ECS container. After deployment when I access the Swagger-UI, an error image is displayed which is because swagger-validator is unable to access the file openapi/openapi.json for the validation.
Firms using this library have usually blocked access for outside APIs with their firewall.
The only workaround to avoid this error is to pass a new swagger-html string through ui-template and set the parameter "validatorUrl" as null, which basically turns this validation off.
But just to change 1 parameter we have to create a complete file with html code repitition.
So it would be great if we can expose the parameter "validatorUrl" in the module, like other parameters such as ui_template which can be passed while creating the app object.

I've submitted a PR (#146 ) to support this, adding swagger_config parameter to support all Swagger Configuration.

Thanks for creating a PR for it! Will it be out in the next release? If yes when is the release date?

I have tested the changes by deploying into ecs, and it was working fine! Thanks for fixing it. Can you please let me know when it will be released?


Test for solve! function

Currently, the solve! function is not properly tested, and a test need to be added

Solved by #219


setting ProgressBarAndroid color prop on Platform Version < 23 results in full progress bar regardless of progress value

Description
Setting color and progress props for ProgressBarAndroid results in the bar being displayed at 100% regardless of progress value
Reproduction
<ProgressBarAndroid color='red' progress={0.25} indeterminate={false} styleAttr='Horizontal' />
Solution
Additional Information

React Native version: 0.40
Platform: Android platform < 23
Operating System: Ubuntu 16.10

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


Unable to use wp cli media regenerate in stateless mode

If we will try to run command with wp cli wp media regenerate --skip-delete --yes to sync missing media to the server (instead of using sync option provided by plugin) it will cause the fatal error.
Stack trace:
#0 [internal function]: wpCloud\StatelessMedia\Utility::store_can_delete_attachment(Array, Array)
#1 /mnt/disks/main_disk/domains/.................../content/web/app/plugins/wp-stateless/lib/classes/class-bootstrap.php(1524): call_user_func_array(Array, Array)
#2 /mnt/disks/main_disk/domains/.................../content/web/wp/wp-includes/class-wp-hook.php(287): wpCloud\StatelessMedia\Bootstrap->__call('store_can_delet...', Array)
#3 /mnt/disks/main_disk/domains/.................../content/web/wp/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
#4 phar:///usr/bin/wp/vendor/wp-cli/media-command/src/Media_Command.php(828): apply_filters('intermediate_im...', Array, Array)
#5 phar:///usr/bin/wp/vendo in /mnt/disks/main_disk/domains/.................../content/web/app/plugins/wp-stateless/lib/classes/class-utility.php on line 572
Fatal error: Uncaught ArgumentCountError: Too few arguments to function wpCloud\StatelessMedia\Utility::store_can_delete_attachment(), 2 passed and exactly 3 expected in /mnt/disks/main_disk/domains/.................../content/web/app/plugins/wp-stateless/lib/classes/class-utility.php:572
Stack trace:
#0 [internal function]: wpCloud\StatelessMedia\Utility::store_can_delete_attachment(Array, Array)
#1 /mnt/disks/main_disk/domains/.................../content/web/app/plugins/wp-stateless/lib/classes/class-bootstrap.php(1524): call_user_func_array(Array, Array)
#2 /mnt/disks/main_disk/domains/.................../content/web/wp/wp-includes/class-wp-hook.php(287): wpCloud\StatelessMedia\Bootstrap->__call('store_can_delet...', Array)
#3 /mnt/disks/main_disk/domains/.................../content/web/wp/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
#4 phar:///usr/bin/wp/vendor/wp-cli/media-command/src/Media_Command.php(828): apply_filters('intermediate_im...', Array, Array)
#5 phar:///usr/bin/wp/vendo in /mnt/disks/main_disk/domains/.................../content/web/app/plugins/wp-stateless/lib/classes/class-utility.php on line 572

As wp-cli is a part of the wordpress I think it should works without fatal error.
Here the part from Media_Command.php (row 828):
if ( ! $is_pdf && is_array( $metadata ) ) {
			// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Calling native WordPress hook.
			$sizes = apply_filters( 'intermediate_image_sizes_advanced', $sizes, $metadata );
		}

@Nks New functionality for sync media via CLI will be included in the next release.

This has been fixed in 3.0
List of available commands - https://github.com/udx/wp-stateless/wiki/WP-CLI
Closing the ticket.


Feature request - support laravel 10

illuminate/contractsshould be upgraded to 10.0
stephenjude/filament-debugger 1.0.0 requires illuminate/contracts ^8.73|^9.0 -> satisfiable by illuminate/contracts[v8.73.0, ..., v8.83.27, v9.0.0, ..., v9.52.0].

@G3z can you make a PR


Demo doesn't work properly with bootstrap version 3.3.6

Hi,
I am using the following version:
bootstrap 3.3.6
angular 1.4.3
jquery 1.11.4
Once I drag the items to the list box 1 or 2 , I am unable to place them back to the container/list they belonged to. Can you please help?
Thanks

@meenakshijha without a demo it would be time consuming for me to reproduce the issue.
Can you add a demo in order to reopen it again?


Placeholder for kinesis-tee: filters/routes events using JavaScript

Examples of filtering/routing might include:

A company's own IP addresses
Specific useragents
Specific geo-locations
Specific event types

These can all be filtered by building SQL views on the data today, but some users might want to discard those events earlier, i.e. in the ETL.
Potential implementations:

Blacklists for specific IP addresses/useragents/geo-locations/event types
GA-style regexp support
A scripting language? Could be cool to write custom scripts to filter out events

/cc @yalisassoon

Updated title as this would be much better done as a new job in the flow than as a set of filters in Common Enrich. If done in Common Enrich, we will be in the situation where rows are being silently filtered with no audit trail...

We will implement this as a new Kinesis app, kinesis-tee...

Closing in favour of https://github.com/snowplow/kinesis-tee


toml.parse() chokes on timestamps with both fractional times and Z

I'm writing a streaming TOML generator, and am using toml to validate that the TOML I'm generating is valid. I was hacking on dates tonight and came across this oddity:
> toml.parse('ts1 = 1979-05-27T07:32:00Z')
{ ts1: Sun May 27 1979 00:32:00 GMT-0700 (PDT) }
> toml.parse('ts2 = 1979-05-27T00:32:00.999999-07:00')
{ ts2: Sun May 27 1979 00:32:00 GMT-0700 (PDT) }
> toml.parse('ts3 = 1979-05-27T07:32:00.12Z')
SyntaxError: Expected "+", "-", "_" or [0-9] but "Z" found.
> toml.parse('ts4 = ' + new Date(2017, 7, 10, 8, 34, 12, 666).toISOString())
SyntaxError: Expected "+", "-", "_" or [0-9] but "Z" found.

The workaround for now is to not use Z with fractional times, but that precludes the use of date.toISOString(), which would allow me to avoid depending on moment. It's not a huge deal either way, it's just a surprising limitation.

Fixed in v2.2.1. Thanks for the catch.


[skip ci] Update EPEL mock config

CL8 is EOL since 31st January 2022 [1].
So the EPEL mock config needs to be switched to
new one supported [2][3].
[1] https://www.centos.org/centos-linux-eol/
[2] https://pagure.io/epel/issue/133
[3] https://github.com/rpm-software-management/mock/pull/817

Maybe it should also be backported to stable-4.0

@jcapiitao your commit message is missing a sign-off

@jcapiitao your commit message is missing a sign-off

Thank you for the heads up


merged master into release-1.16 to keep in sync

@jimangel We need the tide/merge-method-merge label. Looks like I do not have the permission again to manually add from GUI.
@zacharysarah Also, Looks like the merge commits are coming in as a single commit. Am I missing something here?

@daminisatya 👋

Looks like the merge commits are coming in as a single commit. Am I missing something here?

Nope, that's intentional. Prow allows SIGs to specify a merge_method for a repository; we set k/website to squash.

@daminisatya

Looks like I do not have the permission again to manually add from GUI.

This should fix that: https://github.com/kubernetes/org/pull/1461


fix(evaluator): compat bug and update requirement

fix #1414

Looks good to me.

Hi, i got the same question, and I pull today's code and train it again, it still have the same problem.


Upgrade travis dependencies to use Python 3.5 and php5.6

:wave: Cool I'll try to take this for a testrun this weekend.

I'm still working out the last kinks of the PR, so I'll notify you when it's actually building on Travis CI again :-)

This PR finally has a working Travis setup and implementation. The build is now broken because of actually broken tests, and not because of the environment. I'll merge it into master tomorrow unless you have any further notes.
After that I'll start working on the broken tests and add support for the user feature from Imbo 2.

I guess we should also backport most of these fixes to the python2 branch to make that build again as well.


feat: bump composer parser to use patched lodash

[ ] Ready for review
[ ] Follows CONTRIBUTING rules
[ ] Reviewed by Snyk internal team

What does this PR do?
Bump parser version to latest which uses non vulnerable lodash

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ESP32 MQTT-GCP connectivity Example code:setCAcert()

The key has to be in hex format
It has to be typecasted to unit_8* format
The key size has to be passed as second parameter.

Solution : use the "xxd" command on DER format of the public key.

@harishudhay Can you share the full commands to retrieve the cert and then produce the binary formatted certificate?  I'm having trouble going from this:
wget pki.goog/root.pem

to the DER format:
openssl x509 -in roots.pem -outform der -out cert.der

and then getting the key as uint_8*, when I call:
xxd cert.der

I'm not seeing the bytes I expect.

This is now added to the Notes on the certificate section of the README.


WebSocketSharp unit test failure due to StackOverflow

Describe the bug
WebSocketSharp channel unit tests occasionally fail due to stack overflows (quite rare actually).
To Reproduce
Run WebSocketSharp unit tests until they fail. Not guaranteed!
Expected behavior
The unit tests should not produce stack overflow.
Additional notes
========== Starting test run ==========
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v<IP_ADDRESS>+5fe7eebc65 (64-bit .NET 6.0.36)
[xUnit.net 00:00:00.08]   Starting:    CoreRemoting.Tests
Stack overflow.
   at WebSocketSharp.WebSocketFrame.readExtendedPayloadLengthAsync(System.IO.Stream, WebSocketSharp.WebSocketFrame, System.Action`1<WebSocketSharp.WebSocketFrame>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.Ext+<>c__DisplayClass58_0.<ReadBytesAsync>b__0(System.IAsyncResult)
   at System.Threading.Tasks.TaskToApm+TaskAsyncResult..ctor(System.Threading.Tasks.Task, System.Object, System.AsyncCallback)
   at System.Net.Sockets.NetworkStream.BeginRead(Byte[], Int32, Int32, System.AsyncCallback, System.Object)
   at WebSocketSharp.Ext.ReadBytesAsync(System.IO.Stream, Int32, System.Action`1<Byte[]>, System.Action`1<System.Exception>)
   at WebSocketSharp.WebSocket+<>c__DisplayClass170_0.<startReceiving>b__1(WebSocketSharp.WebSocketFrame)
...
(dosens of pages of the same call stack frames omitted)

PS. Disabled WebSocketSharp tests for now (this channel is going to be superseded by new HttpListener-based websocket channel) — see commit f8abb35.

System.Net.Sockets.NetworkStream.BeginRead can sometimes call a callback in the same thread in which it was called. I came across something similar in Socket.BeginRead when switching from .Net Framework to .net. It seems that in .net, the probability of calling a callback in the same thread is much higher due to some optimizations. It was decided to call a task in the callback that performs processing if the callback call was synchronous.

System.Net.Sockets.NetworkStream.BeginRead can sometimes call a callback in the same thread in which it was called.

Hmm, interesting... But I don't see why it should overflow unless the callback starts stream.BeginRead again from the same stream.Position. The same stream.Position means that read bytes count = 0, which indicates the end of the stream, so the process should stop. Looks like bug in application code. Am I missing something?

I forgot to clarify, stack overflow occurred if there was data in the buffer at the time of each callback call and if the BeginRead call occurred in a callback that was passed to BeginRead. Apparently, some condition for exiting recursion is not met in the websockets. I also think that this is a bug in the websocket. Whether it will be fixed is unknown.
It looks like there are now two potential stable channel implementations left - quick and httplistener-based websocket.

@yallie I can confirm that I have experienced the StackOverflowException problem in websockets-core in my .NET 8 application . Occasionally it also happened when I ran some of the unit tests locally. I have similar problems with my own source code as well, still struggling to find a solution to that.
@sancheolz Did you manage to workaround the recursion issue in your code? In that case, I would be very interested to get some tips :-)

I can confirm that I have experienced the StackOverflowException problem in websockets-core in my .NET 8 application

Please try updating to the latest version of CoreRemoting.
Websocket channels are now based on HttpListener implementation and should work on Windows and Linux.
Legacy WebSocketSharp-based implementation is renamed and extracted in a separate project.

two potential stable channel implementations left - quick and httplistener-based websocket.

I'm currently using Fleck library in one of my projects.
A few years ago I was evaluating Flex and websocket-sharp and found that Chromium browsers
fail to connect to websocket-sharp-based servers, but connect to Fleck-based servers just fine.
Not sure if it's still the case though, but back then our team decided to use Fleck for this reason.
Also, there is WebSocket4Net, based on SuperSockets library, but I haven't tried it.

@anders9ustafsson you need to check property IAsyncResult.CompletedSynchronously. IAsyncResult is passed to callback wich passed to BeginRead. If CompletedSynchronously returns true then you neen run receive logic in Task.Run, else run it as is.
@yallie thanks for the information. I really want to try out a new implementation of the channel on  websocket when I find some time. I think I'll focus on it.

I really want to try out a new implementation of the channel on websocket when I find some time. I think I'll focus on it.

@sancheolz Please keep in mind the channel is still beta.
I'm not sure I've done everything right — it's just passes the unit tests, nothing more.
I didn't stress test it and I didn't run any benchmarks on it apart from the unit tests.
Would be grateful for the code review when you have some spare time.

Thanks for the info @yallie , I think it is a great step in the right direction to make use of the .NET internal support for WebSockets. I did try it with my application, but for some reason failed to establish contact between the client and the server. Not sure why, I will investigaste further.
And thanks @sancheolz for the info. I have tried to make use of CompletedSynchronously, but have still not been able to avoid recursion, so I am rewriting the code using ReceiveAsync instead.

I did try it with my application, but for some reason failed to establish contact between the client and the server.

I knew it shouldn't be that easy! :-/
— What platform are you using, Windows, Linux?
— Did you run both client and server on the same machine or on different machines?
— Firewall maybe?
My best guess is a problem with HTTP.sys driver permissions. Localhost connections don't require any configuration, that's why the unit tests run without any issues. But accepting connections from other machines requires administrator privileges and setting up namespace reservations with netsh: [https://learn.microsoft.com/en-us/dotnet/framework/wcf/feature-details/configuring-http-and-https](Configuring HTTP and HTTPS)...

@yallie I am running on Windows 11, client and server on same machine.

Unit tests succeed. I will investigate more thoroughly to identify the root cause of the failing communication, I'll get back to you as soon as I have more information.

@yallie Here is what I have found so far. My server was invoked with HostName set to "localhost", whereas the client was invoked with ServerHostName equal to the name of my computer. This resulted in the server not being able to recognize that the client was trying to connect. Changing the client's ServerHostName to "localhost" made the server to recognize the connection attempt.
I am still having problems with the handshake; the server has issued the handshake but the client is not able to recognize it. I'll continue my investigation.
BTW, looking at the await:ed code, in the websocket classes, the use of ConfigureAwait(false) seems to be inconsistent. Is this deliberate?

Ideally though, it should not matter if the host name differs in the server and client invocation, as long as the same machine is referenced.

Yes, I think it shouldn't matter, too.

BTW, looking at the await:ed code in the websocket classes, the use of ConfigureAwait(false) seems to be inconsistent. Is this deliberate?

I tend to use ConfigureAwait(false) every time I remember about using it.
It discards the captured synchronization context and helps avoiding deadlocks in a single-threaded app.
I wish that ConfigureAwait(false) were the default setting.
And as I said, I'm not sure I've done everything right — the code just passes the unit tests, and that's it.
Would be grateful for the code review from you guys.

Especially when I wait for the result synchronously afterwards, i.e. ConfigureAwait(false).Result.

Hmm, apparently I'm using it wrong...
Looks like ConfigureAwait doesn't affect the code that runs synchronously.

@anders9ustafsson new websocket channel is based on HttpListener. And if you set Hostname to "+" it will listen at all network interfaces(loop, eth0 and other) and it's addresses.With Hostname set to "localhost" it listens loop interface only.

@yallie I've tried the latest revision at this moment. RemotingClient.Connect() freezes in it.
If you go back to revision f1387ae373f909a7e17d2a4120cc4dbdf77c4d8a, the connection works. I have not yet searched for which revision the hang started in, I just rolled back to the code without asynchronous support.

RemotingClient.Connect() freezes in it.

Too bad! Could you please make a unit test demonstrating the issue?

I haven't been able to do a reproducible test yet. The hang started with revision 6eec075fdb3cfca6aaa07b4fb674b175b647fcd4.
The interesting thing is that the connection is successful, but one of the subsequent calls may hang. Moreover, freezes occur if the client is created in a separate process, if the client and server are running in the same process, then freezes do not occur.


Mon 15007 theme modification for 22 10 release

Description
Rework the 4 following things necessary for 22.10 release:

Make badges in top counter bigger
Change panel background color
Change menu background color
Display separator under Resources satatus  search bar to differentiate visualy the detail panel from the rest

Type of change

[X] Patch fixing an issue (non-breaking change)
[ ] New functionality (non-breaking change)
[ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

[ ] 21.04.x
[ ] 21.10.x
[ ] 22.04.x
[X] 22.10.x (master)

 How this pull request can be tested ?

Change centreon-frontend package url  into the centreon package.json file replacing develop by the branch name :

"centreon-frontend"<EMAIL_ADDRESS>

Update package into centreon app:

npm update centreon-frontend --legacy-peer-deps

Restart centreon app from centreon-dev-ecosystem:

pm2 restart centreon

Checklist
Community contributors & Centreon team

[ ] I have followed the coding style guidelines provided by Centreon
[ ] I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
[ ] I have commented my code, especially hard-to-understand areas of the PR.
[ ] I have rebased my development branch on the base branch (master, maintenance).

Some screenshots of expected views :


move to embedded-hal 1.0

and upgrade other dependencies

You can have a look at the passing CI in here


Fatal Exception: java.lang.IllegalStateException，The firebase crash was reported on Android 14 and Android 10，I have not repeated this problem myself，but this issue did not occur on 4.1.0

Checklist

[X] I read the troubleshooting guide before raising this issue
[X] I made sure that the issue I am raising doesn't already exist

Current bug behaviour
android.media.MediaPlayer.getPlaybackParams (MediaPlayer.java)
xyz.luan.audioplayers.player.MediaPlayerPlayer.setRate (MediaPlayerPlayer.java:2)
xyz.luan.audioplayers.player.MediaPlayerPlayer.start (MediaPlayerPlayer.java:6)
xyz.luan.audioplayers.player.WrappedPlayer.onPrepared (WrappedPlayer.java:17)
xyz.luan.audioplayers.player.MediaPlayerPlayer.createMediaPlayer$lambda$5$lambda$0 (MediaPlayerPlayer.java:5)
android.media.MediaPlayer$EventHandler.handleMessage (MediaPlayer.java:3410)
android.os.Handler.dispatchMessage (Handler.java:107)
android.os.Looper.loop (Looper.java:226)
android.app.ActivityThread.main (ActivityThread.java:7592)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:539)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:950)
project version：
targetSdkVersion 34
audioplayers: ^5.2.0
flutter sdk version：3.13.9
Expected behaviour
The firebase crash was reported on Android 14 and Android 10
Steps to reproduce

Execute flutter run on the code sample
...
...

Code sample

Code sample
void main() {
}

Affected platforms
Android
Platform details
No response
AudioPlayers Version
5.2.0
Build mode
No response
Audio Files/URLs/Sources
No response
Screenshots
No response
Logs

my relevant logs

Full Logs

my full logs or a link to a gist

Flutter doctor:
Output of: flutter doctor -v

Related issues / more information
No response
Working on PR
no way

It's hard to reproduce without steps. Anyways we're planing to switch to Exoplayer. If you come up with a fix, feel free to open a PR. Thanks for your patience.


Add ruby op-or-equals command

without this, saying op or equals would be interpreted as op or
followed by equals, which results in a syntax error || =

IMO we should implement this for other languages too. For example JavaScript implements logical and/or assignment as well
it can probably go in https://github.com/talonhub/community/blob/main/lang/tags/operators_assignment.talon with the rest of them

I'm not confident that every language that inherits that file supports it; and, I'm not sure how to do it for every language. My preference would be to keep this small and targeted to what I know and then refactor after it has been implemented everywhere. I only care about Ruby today because using this operator is idiomatic in Ruby. Can we live with this approach for now?

I'm not confident that every language that inherits that file supports it

We don't implement every one of those actions in that file for every language that asserts that tag anyway

Ah, ok. I'm fine with adding it to JavaScript as well then. I'll add that when I can, or please feel free to edit this or submit a new PR with the change if you get to it first.

I updated this based on your feedback. Thanks!


Getting "Write again..." printed to console.  Not sure why

The only instance of this message in the repo is commented out.
Something I changed caused this to happen; Trying to figure out what I did.
Any ideas?

Try searching "console.log" in all files of project folder. [Sublime: Ctrl+shift+F]

The standard npm install appears to lag what on github, but the real cause was my call to write wasn't a proper buffer or something that would turn into a buffer.  If you give write a number it doesn't appear to send that character;  Maybe it allocates a buffer that size instead?
Anyway, found my fix, but I would like to know when the git repo gets pushed to the standard npm install.


Add an ignoreWarts annotation to ignore specified warts in the annotated code.

This Pull Request adds an ignoreWarts annotation which allows the user to ignore the specified warts in the annotated code. This accomplishes the "exceptions" half of https://github.com/puffnfresh/wartremover/issues/92 but not the "include" half.
Because wartremover runs after the typer-phase I couldn't inject the annotation into the code using the plugin so the user must add wartremover as a library dpendency.

Really nice stuff! :+1:
It'd be awesome if we made an annotations project with just the annotation traits so we didn't have to depend upon all of WartRemover.

An alternative might be to hijack @java.langSuppressWarnings.

@retronym It would be nice to use an existing annotation but if you use wartremover to generate errors instead of warnings this usage is a bit misleading. If people are okay with that mismatch though I can definitely switch it to @java.lang.SuppressWarnings.

I vote for the switch. Means no dependencies.
:yum:

Okay, I've updated the PR to use SuppressWarnings instead of ignoreWarts.

This will really help with gradual introduction into existing codebases

Been thinking about how to reduce the duplication. We can probably wrap the Traverser type. I'll merge this and try it later.

awesome thanks!


RVC API Problem with Gradio in F0 Curve File

I am trying to access the RVC API method infer_convert using the Gradio client, but I am encountering issues with the F0 curve file. I have tried using None and empty string and other files, but it still does not work. Could you please provide an example or guidance on how to properly use the F0 curve file with this API?

`from gradio_client import Client
client = Client("http://<IP_ADDRESS>:7865/")
result = client.predict(
0,	# float (numeric value between 0 and 2333) in 'Select Speaker/Singer ID:' Slider component
"C:/Users/Administrator/Downloads/test/wav.wav",	# str  in 'Enter the path of the audio file to be processed (default is the correct format example):' Textbox component
5,	# float  in 'Transpose (integer, number of semitones, raise by an octave: 12, lower by an octave: -12):' Number component
None,	# str (filepath on your computer (or URL) of file) in 'F0 curve file (optional). One pitch per line. Replaces the default F0 and pitch modulation:' File component
"rmvpe",	# str  in 'Select the pitch extraction algorithm ('pm': faster extraction but lower-quality speech; 'harvest': better bass but extremely slow; 'crepe': better quality but GPU intensive), 'rmvpe': best quality, and little GPU requirement' Radio component
"",	# str  in 'Path to the feature index file. Leave blank to use the selected result from the dropdown:' Textbox component
"logs/agadmator.index",	# str (Option from: ['logs/agadmator.index']) in 'Auto-detect index path and select from the dropdown:' Dropdown component
0,	# float (numeric value between 0 and 1) in 'Search feature ratio (controls accent strength, too high has artifacting):' Slider component
0,	# float (numeric value between 0 and 7) in 'If >=3: apply median filtering to the harvested pitch results. The value represents the filter radius and can reduce breathiness.' Slider component
0,	# float (numeric value between 0 and 48000) in 'Resample the output audio in post-processing to the final sample rate. Set to 0 for no resampling:' Slider component
0,	# float (numeric value between 0 and 1) in 'Adjust the volume envelope scaling. Closer to 0, the more it mimicks the volume of the original vocals. Can help mask noise and make volume sound more natural when set relatively low. Closer to 1 will be more of a consistently loud volume:' Slider component
0,	# float (numeric value between 0 and 0.5) in 'Protect voiceless consonants and breath sounds to prevent artifacts such as tearing in electronic music. Set to 0.5 to disable. Decrease the value to increase protection, but it may reduce indexing accuracy:' Slider component
api_name="/infer_convert"
)
print(result)`

I am having the same issue.  Any ideas would be welcomed...  Please and Thank you.


unable to install/compile under Windows 10

It reports [....]/wasmtime-go@v0.17.0/build/windows-x86_64/libwasmtime.a(zdict.o):zdict.c:(.text$ZDICT_analyzePos+0x5c9): undefined reference to '__imp___acrt_iob_func' and similar.
It seems it is binary dependency problem with libraries used by CGO, probably VS related. Any idea how to solve it?

Thanks for the report! This can I think come up if MinGW is perhaps at a different version than Wasmtime itself was built with. Do you know what version of gcc you're using in your environment? We're using release built on Github Actions and I'm not entirely sure what gcc version they're using but it's probably somewhat recent.

Yes, I think it may be the reason.
gcc -v reports the following:
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=C:/TDM-GCC-64/bin/../libexec/gcc/x86_64-w64-mingw32/5.1.0/lto-wrapper.exe
Target: x86_64-w64-mingw32
Configured with: ../../../src/gcc-5.1.0/configure --build=x86_64-w64-mingw32 --enable-targets=all --enable-languages=ada,c,c++,fortran,lto,objc,obj-c++ --enable-libgomp --enable-lto --enable-graphite --enable-cxx-flags=-DWINPTHREAD_STATIC --disable-build-with-cxx --disable-build-poststage1-with-cxx --enable-libstdcxx-debug --enable-threads=posix --enable-version-specific-runtime-libs --enable-fully-dynamic-string --enable-libstdcxx-threads --enable-libstdcxx-time --with-gnu-ld --disable-werror --disable-nls --disable-win32-registry --prefix=/mingw64tdm --with-local-prefix=/mingw64tdm --with-pkgversion=tdm64-1 --with-bugurl=http://tdm-gcc.tdragon.net/bugs
Thread model: posix
gcc version 5.1.0 (tdm64-1)

@lunfardo314 Dont use obsolete tdm-gcc. MSYS2 environment is a better choice on windows, on which wasmtime works prefectly. And as far as I know, the default gcc toolchains on github actions, circle-ci, travis's windows matric are all based on MSYS2.
Currently the gcc version of MSYS2 has been rolling to 10.1.0. I guess maybe some incompatible details exists between it and your 5.1.0.

Ah yeah that's a pretty old version of gcc, would it be possible to switch to msys2? Does that fix your issue?
If not then the only solution would be to build the wasmtime library yourself on your system I think.

I'm going to close this since it seems like it was a gcc version thing, but if it continues to crop up feel free to reopen.


Fixed typo: \scriptS -- \mathcal{S}

Since the LaTeX code in \scriptS was \mathrm{S}, I've corrected it to \mathcal{S}.

Thank you!


Header title would not work with wrapped children

https://github.com/Traviskn/react-router-native-stack/blob/c6a0e3a7e09f9b7d67db498853c60784f662685c/lib/StackTransitioner.js#L267
Would not work in this instance:
class MyRoute extends Component {
    render () {
        return <Route title='My amazing title!!!' />
    }
}

class Router extends Component {
    render () {
        return (
            <Stack renderHeader>
               <MyRoute />
            </Stack>
        )
    }
}

Hi @gabrielbull! Like the Switch in react-router, the Stack only supports Route components as children.  A lot more things than the title would break if you used wrapped children like in your example.  Instead, you should return your component in the render prop of the route, pass your component to the component prop of the route, or pass it to the children prop of the route.  See the docs for the Route component here: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/Route.md

Makes sense. I'm not using the default header but I'm trying to make sure it wouldn't cause issues. Do you intend to have all header props in the Router component? I.E. title, right components, left components, etc.
An alternate approach would be to use a decorator like withRouter or a nested component like React Helmet does.
Here's a decorator example, just for discussion:
function withHeader (title: string) {
  return function (WrappedComponent) {
    class Wrapper extends React.Component {
      public static contextTypes = {
        _reactRouterNativeStackSetTitle: PropTypes.func
      }

      public componentDidMount () {
        if (this.context._reactRouterNativeStackSetTitle) {
          this.context._reactRouterNativeStackSetTitle(title)
        }
      }

      public render () {
        return <WrappedComponent {...this.props}/>
      }
    }
    return Wrapper
  }
}

const Home = () => (
  <Tex>
    Home
  </Text>
)

export default withHeader('Home')(Home)

Or it could be like so:
<Route path='/' header={<Header title='Home' />} />


Allow accessing aplty via https

This simple patch add ability to access aptly api va HTTPS

Coverage remained the same at 92.403% when pulling 26b138140e65684e94cb6a7457139025805ddf65 on rawlplug:https into 4c4b0285fd9fb3eae57a046d78268348871e8654 on sepulworld:master.

Thank you for the PR!  LGTM


pull request for e2e test at 01/20/2017 13:45:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added DirectML header 1.13.1

Include DirectML header too. This matches the header published at https://www.nuget.org/packages/Microsoft.AI.DirectML/1.13.1, but with two small fixes:

Delete semicolons after DEFINE_ENUM_FLAG_OPERATORS to avoid Chrome warnings with clang.
Wrap DML_GRAPH_NODE_TYPE_CONSTANT in missing #if DML_TARGET_VERSION >= 0x6200.

FYI @jenatali, @RafaelCintron, @sumitsays, @jstoecker.


"Sequence contains no matching element" exception

System.InvalidOperationException
HResult=0x80131509
Message=Sequence contains no matching element
Source=System.Core
StackTrace:
at System.Linq.Enumerable.Single[TSource](IEnumerable1 source, Func2 predicate)
at NTFSLib.IO.NtfsDirectory.PrepRecord() in ... NtfsLib\NtfsLib\NTFSLib\IO\NtfsDirectory.cs:line 48
Happening with files in "c:\Program Files\Microsoft SQL Server\MSSQL12.MSSQL2014\MSSQL\DATA" and "c:\Program Files\Microsoft SQL Server\MSSQL14.MSSQL2017\MSSQL\DATA" (SQL Server databases). This system drive was made by copying by Samsung/DataMigration, but server, file managers and C# library made by porting NTFSLib made by Yibo Cai are working.
In MFTRecord.Attributes
            // Get root
            _indexRoot = MFTRecord.Attributes.OfType<AttributeIndexRoot>().Single(s => s.AttributeName == DirlistAttribName);

I see
[0] = {NTFSLib.Objects.Attributes.AttributeStandardInformation}
[1] = {NTFSLib.Objects.Attributes.AttributeList}
[2] = {NTFSLib.Objects.Attributes.AttributeFileName}
[3] = {NTFSLib.Objects.Attributes.AttributeFileName}
[4] = {NTFSLib.Objects.Attributes.AttributeObjectId}
[5] = {NTFSLib.Objects.Attributes.AttributeLoggedUtilityStream}

Could seem that the AttributeList is not being expanded.
Unfortunately I'm not maintaining this library any more, as the codebase has been stale for some time and I've moved to other projects. You're more than welcome to try to insert code that expands the attribute list, alternatively you could look at projects like DiscUtils


Make Github workflows DRY

There are some repeated tasks in our current Github workflows that could probably be extracted and re-used across the various workflows. This task is to identify those repeated sections and to extract them as necessary.

Thanks @nickmcmahon01 wasn't aware of this repo but looks like there's some useful workflows and actions in there, we'll take a look at them.


Feature request: isNotAuthenticated

Is there any possibility of getting an isNotAuthenticated boolean?

What would be the use case of that?

Any feedback? I'd say instead of having the extra property you can simply use
{{#unless session.isAuthenticated}}

as opposed to
{{#if session.isAuthenticated}}

That's honest a much better approach.


fix: add oem pack

Issue
https://gravitee.atlassian.net/browse/TT-3493
Description
Create an OEM pack that includes customization feature
Additional context

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 5.0.1-TT-3493-oem-pack-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 5.0.1 :tada:
The release is available on:

5.0.1
GitHub release

Your semantic-release bot :package::rocket:


vector: 0.10.0 -> 0.12.1

As a minor regression, LevelDB support is currently compiled out. This is due to a few changes in the build infrastructure that now causes leveldb to be vendored when it shouldn't be, but should be fixable, I think.
This has to hit staging because Vector now requires Rust 1.50, due to it stabilizing some library APIs it uses.
Darwin is currently untested.
This supersedes both #113849 and #107557.
/cc @happysalada @rmcgibbo
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116017 at 5c812929 run on x86_64-linux 1

1 package failed to build (new failures):

vector

(I hid the bot comment -- looks like an OOM or something)

Result of nixpkgs-review pr 116017 run on x86_64-darwin 1

1 package failed to build:

vector

I'm not really sure what it's due to. Here is the error i get
error: --- Error --- nix-daemon
output '/nix/store/3j0j0i9n8dqi8pj8zn73mc62708rakj5-bootstrap-stage2-stdenv-darwin' is not allowed to refer to the following paths:
  /nix/store/qvv2xw5da22lfgbj1zq4hhvh286i74f7-brotli-1.0.9-lib

It looks like a darwin specific thing.

I'm not really sure what it's due to. Here is the error i get
error: --- Error --- nix-daemon
output '/nix/store/3j0j0i9n8dqi8pj8zn73mc62708rakj5-bootstrap-stage2-stdenv-darwin' is not allowed to refer to the following paths:
  /nix/store/qvv2xw5da22lfgbj1zq4hhvh286i74f7-brotli-1.0.9-lib

It looks like a darwin specific thing.

Fixed by https://github.com/NixOS/nixpkgs/pull/115498

Just as a note, it looks like 12.1 has been released.
https://github.com/timberio/vector/releases/tag/v0.12.1

Result of nixpkgs-review pr 116017 run on x86_64-darwin 1

1 package failed to build:

vector

I've got totally unrelated failures again
builder for '/nix/store/02r3nw3cmvr70r7lp3p4xjjl5jbvncbm-libtiff-4.2.0.drv' failed with exit code 2; last 10 log lines:

  The following tests FAILED:
        18 - tiffdump-miniswhite-1c-1b (Failed)
        19 - tiffinfo-minisblack-1c-16b (Failed)
       20 - tiffcp-split (Failed)
     21 - tiffcp-split-join (Failed)
        22 - tiff2pdf-miniswhite-1c-1b (Failed)
       108 - testtypes (Subprocess aborted)
  Errors while running CTest
  make: *** [Makefile:149: test] Error 8
error: --- Error --- nix-daemon
builder for '/nix/store/3gnlw2rhp5211sysi4x8ildpslblyk3r-python3.8-lxml-4.6.2.drv' failed with exit code 1; last 10 log lines:
  running build_ext
  building 'lxml.etree' extension
  creating build/temp.macosx-10.6-x86_64-3.8
  creating build/temp.macosx-10.6-x86_64-3.8/src
  creating build/temp.macosx-10.6-x86_64-3.8/src/lxml
  clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -DCYTHON_CLINE_IN_TRACEBACK=0 -Isrc/lxml -Isrc/lxml/includes -I/nix/store/180s86m4qgd4mhybxx1y2fh3vzpbcrgs-libxml2-2.9.10-dev/include/libxml2 -I/nix/store/fwmrca0zvgijjy5hygv07pr21gfpv2zp-libxslt-1.1.34-dev/include -Isrc -I/nix/store/xrrf9gx1lz45cj6ca2xb7bak6p8b8rkj-python3-3.8.8/include/python3.8 -c src/lxml/etree.c -o build/temp.macosx-10.6-x86_64-3.8/src/lxml/etree.o -w -flat_namespace
  clang -bundle -undefined dynamic_lookup -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-<IP_ADDRESS>.2/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.10/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.5/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.19/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.34.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.2/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1j/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-453.19/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-<IP_ADDRESS>.2/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.10/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.5/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.19/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.34.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.2/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1j/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-453.19/lib build/temp.macosx-10.6-x86_64-3.8/src/lxml/etree.o -L/nix/store/h3g32s4q348irqb59vvklkbs15dmc9vg-libxml2-2.9.10/lib -L/nix/store/yppiyxw1vd553ihxxbnwlzi6033p2kld-libxslt-1.1.34/lib -L/nix/store/xrrf9gx1lz45cj6ca2xb7bak6p8b8rkj-python3-3.8.8/lib -lxslt -lexslt -lxml2 -lz -lm -o build/lib.macosx-10.6-x86_64-3.8/lxml/etree.cpython-38-darwin.so -isysroot
  clang-7: error: no such file or directory: 'x86_64-apple-darwin'
  clang-7: warning: no such sysroot directory: '-target' [-Wmissing-sysroot]
  error: command 'clang' failed with exit status 1

@ofborg build vector

The build takes 7 hours on my machine, I'll try to remember to trigger it before i go to sleep tonight.

Part of that is definitely just the use of staging, though... there's no available mac that can really make those rebuilds tolerable outside the Pro range.
I think we should probably just go ahead and let this percolate to master naturally, and issue darwin fixes as needed.
I still haven't figured out the LevelDB thing.

Merging this to staging. Filing a bug about the regressions.

We can follow up in #116574

I completely agree, I was about to say that most probably very few people would use vector on a mac.
I personally only use it on production. I would be surprised to see much need for this for darwin.
Thanks for merging!

Great! I will use this in the next iteration of r-rmcgibbo (I had previously switched to using the upstream-released binaries). Awesome.

@thoughtpolice is there a way we can merge this into master?
At the moment vector 0.10 fails to build, so there is no way to use vector on nixos.
Since it's (in my opinion) the primary platform where vector would be used, it would make it available again to merge it.

If there's a way to enable unstable Rust features in master, then it might be possible (again, this is due to the Rust 1.50 requirement, which I suspect is part of the reason 0.12 took so long to release in the first place.) But I couldn't find any cases of anyone doing this, so I came to the conclusion it might even involve a global rebuild of all Rust packages to do so. But at that point just putting it in staging is probably just as good.
I can't give a good prediction on when staging will be merged into master. It seems like staging-next was merged last week, so it might be possible to do an incremental merge with just a few updates including vector, but I'd have to look over the exact diff to be sure.

Thanks for the explanation!

It seems there is a new release of vector, would you also want to merge this on staging? Or wait until staging is merged on master before doing a PR?


[QUESTION] clickable text with a link

How to create a clickable text with a link, I have already tried to do that but I regret it does not work, can you please help me? "join": {     "actions": [       "/tellraw ${player} [{\"text\":\"§nLink1\",\"color\":\"green\",\"clickEvent\":{\"action\":\"open_url\",\"value\":\"http:\/\/google.com"}}]" ]

Sorry for not answering before, I forgot to do it at the time.
2.3.0 was just released, and now you can use Simplified Text Format to format your messages. In this case, your action would just be <underline><green><url:'https://google.com'>Link1</url></green></underline>.
Hope this helps!


fix(drag-drop): make CDK_DROP_CONTAINER public

fixes #12213

@crisbeto actually, right after responding to your feedback I realized, should the @private-api comment be removed from the CdkDropContainer interface now that it's also being exported?

Sure. That tag only says whether the symbol should be displayed in the docs.

👍 done


Issue with npm

I’m getting an Uncaught Reference Error: Rellax is not defined error.
here’s how I’m calling it:
require('rellax');
let rellax = new Rellax('.rellax');

@nathanaelphilip The library exposes Rellax as a global variable. Gross, I know, but the intention with the code is to be small as possible for use on simple static websites.

I’m still sort of a JS newb, so could you show me an example? :)

Sure. Since it's global there's no option to require('rellax'), which means you have to point to where it's at in your files. For instance on your homepage at the bottom of the <body> but before your js code put <script src=node_modules/relllax/rellax.min.js></script> or where ever node_modules is at in your file structure

ahhhh ok, so using npm is almost pointless right now. thanks!

Yup, pretty much :) Closing now


cloning the data is a breaking change

PR #20 introduced a breaking change by cloning the data passed into the logger.
In our code this resulted in Errors being removed from our logs e.g.
catch (err) {
  log('error', 'there was an error', err);
}

since _.isEqual(cloneDeep(err), {}) === true
the problematic code specifically is line 177
Object.assign would result in the same behavior

@mattoberle
A new test case should be added to the unit tests. The error appears to be that non-enumarable properties are dropped when calling cloneDeep. In the case above, we appear to have lost the message/stack on the error.

I haven't personally encountered this, but that may be because we typically do one of these two options for reporting errors:
log(err);

or
log('error', 'my message', { stack: err.stack });

I'm trying to think about how we can account for the non-enumerable properties while still preventing the mutation side effects that clay-log could otherwise cause.
The third argument of clay-log is intended to be a JSON-serializable object containing additional context. The first argument is the one with special handling for instances of Error.
Maybe we could extend that handling for the third argument as well?
That would mean extracting .stack, .message and (.name?).
data = data instanceof Error
  ? { stack: data.stack, message: data.message, name: data.name }
  : cloneDeep(data);

You would still need to cloneDeep it as there may be custom properties on a custom Error. So cloneDeep it and then specifically reset those 3 if it's an error?

Only the _label is being added correct ?  i.e. that's the only side effect ?

this problem isn't specific to errors, so creating a one-off solution for it I feel is insufficient.
The api can't change from mutable to non-mutable without there being a breaking change i.e. a major version bump

@olsonpm you are right about both it being a breaking change and the Error solution not being sufficient (just wrote tests to verify).
I do think that #20 is important when paired with #16 which allows manipulation of the data argument for the purpose of providing additional context (or formatting values in a preferred way).
I could publish a v1.5.3 with the reverted behavior (removing cloneDeep) along with a v2.0.0 that re-introduces the safer behavior, although that might be a little strange to have a 'broken' v1.5.2 sitting around.

a broken v1.5.2 is just how it goes.  It'd be stranger if code in that version were to change
please publish a v1.5.3 with the revert like you mention.  That would be great.

This was fixed in v1.5.3 which is now published on NPM.
Thank you for raising this issue.
We'll explore options for protecting against mutation and determine how to proceed on that front.


Preserve URLs in links

In https://github.com/yhatt/jsx-slack/issues/288, @mrcljx pointed out that characters in link URLs that are already escaped get escaped again. For example:
show

is encoded as
<https://google.com/a?x=y%253Az|show>

This PR removes implicit encoding from link URLs. Following @yhatt's recommendation, it ensures we continue to escape characters that Slack reserves. &, <, and > are replaced by corresponding HTML entities, and we continue to use urlEncode to escape |.
closes https://github.com/yhatt/jsx-slack/issues/288

Thank you for your contribution :smile:
The hyperlink with date formatting still has implicit URI encoding.

  <time datetime={1234567890}>{'test: {date_short}'}</time>

<!date^1234567890^test: {date_short}^https://example.com/?x=y%253Az|test: Feb 13, 2009>

In addition, ^ also should escape in the link with date formatting. If not, a hyperlink will truncate raw ^ character and after chars.

Thanks, @yhatt! Great catch.
I took a stab at addressing that in https://github.com/yhatt/jsx-slack/pull/289/commits/efed184da3ea7a66395509ccc8edbe05c8623a70. Looks good in the Block Kit Builder, but I'm open to other approaches!


do not support mysql json grammar select

Actual Behavior
such as：select from table where value->$.type = ''
Expected Behavior
select relative result
Steps to Reproduce the Problem

mysql 5.7.8 that support json function
do select according to Actual Behavior

Specifications

Version: 0.9
Platform: Mac
Subsystem:

This should just have been resolved. If not, please re-open and add a specific SQL statement to reproduce.


Copied secrets are stored unencrypted by default

The README should mention that using https://github.com/godaddy/kubernetes-external-secrets alone will result in external secrets being stored unencrypted in etcd and therefore open to attack (either via the etcd server or via backups of etcd data).
A solution, which should probably be recommended in the README, is to use a KMS plugin to encrypt the secrets prior to them being stored in etcd.

While this is nothing special for KES having it in the docs wont hurt :) PR welcome


Adds 'unsigned' flag to &nrformats.

I want to add unsigned flag to &nrformats. Because Its the behavior is NOT intuitive when increase/decrease a date(, zipcode, etc..) splited by '-'.

@chrisbra commented on this pull request.

@@ -5427,6 +5427,13 @@ A jump table for the options with a short description can be found at |Q_op|.
bin	If included, numbers starting with "0b" or "0B" will be
considered to be binary.  Example: Using CTRL-X on
"0b1000" subtracts one, resulting in "0b0111".

unsigned    If included, numbers is recognized to be unsigned number.

Thus the numbers does not contained negative sign('-').

I think better would be something like:
If included, numbers are recognized as unsigned. Thus a leading negative sign won't be considered as part of the number.

A better example is something like 9-2020, using CTRL-A on "2020" will
make it "2021" instead of "2019".
Going down from zero to a large number doesn't sound useful.  How about
sticking at zero?
--
A bad peace is better than a good war. - Yiddish Proverb
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

A better example is something like 9-2020, using CTRL-A on "2020" will
make it "2021" instead of "2019".
I'll fix it.

Going down from zero to a large number doesn't sound useful.  How about
sticking at zero?
I thick so. But present behavior is to go down from -(2^64 - 1) to 2^64 - 1.

I fixed it.
How about sticking at 2^64 - 1 when increase a large number?

Codecov Report

Merging #6144 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6144      +/-   ##
==========================================
+ Coverage   87.30%   87.32%   +0.01%
==========================================
  Files         141      141
  Lines      157151   157159       +8
==========================================
+ Hits       137201   137236      +35
+ Misses      19950    19923      -27

Impacted Files
Coverage Δ

src/optionstr.c
93.78% <ø> (ø)

src/ops.c
92.33% <100.00%> (+0.13%)
:arrow_up:

src/testing.c
92.15% <0.00%> (-0.68%)
:arrow_down:

src/netbeans.c
74.66% <0.00%> (-0.60%)
:arrow_down:

src/search.c
91.38% <0.00%> (-0.12%)
:arrow_down:

src/ex_getln.c
91.44% <0.00%> (-0.05%)
:arrow_down:

src/window.c
89.67% <0.00%> (-0.04%)
:arrow_down:

src/terminal.c
91.01% <0.00%> (+0.03%)
:arrow_up:

src/mbyte.c
65.95% <0.00%> (+0.06%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a20df...e17089a. Read the comment docs.

I fixed it.
How about sticking at 2^64 - 1 when increase a large number?

I don't think it matters.
--
I'm in shape.  Round IS a shape.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I fixed it.
How about sticking at 2^64 - 1 when increase a large number?
I don't think it matters.

I see. I think  this PR is ready.