[Tables] Multiple small fixes to Tables SDK

Fixes included in this PR:

Document usage of SDK with Azurite. Fixes #17007
Correctly handle etag in select filter. Fixes #17407
Correctly handle creating entities with properties containing empty strings "".  Fixes #18079
Correctly deserialize Decimal numbers checking for isSafeInteger. Fixes #18148

/azp run js - data-tables - tests

LGTM
any reason to update all the recordings?

Not really, just got rid of the re-recordings and kept only the new ones to keep a cleaner PR


[SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin

What changes were proposed in this pull request?

Enable createDependencyReducedPom for Spark's Maven shaded plugin so that the effective pom won't contain those shaded artifacts such as org.eclipse.jetty
Why are the changes needed?

At the moment, the effective pom leaks transitive dependencies to downstream apps for those shaded artifacts, which potentially will cause issues.
Does this PR introduce any user-facing change?

No
How was this patch tested?

I manually tested and the core/dependency-reduced-pom.xml no longer contains dependencies such as jetty-XX.

Local build looks good, and let's see how Spark CI reacts. cc @JoshRosen

Test build #143574 has started for PR 34085 at commit 08b1f31.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48083/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48083/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48083/

Thanks, merging to master and branch-3.2

Test build #143574 has finished for PR 34085 at commit 08b1f31.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143574/

+1, LGTM.

@sunchao @JoshRosen I find that after merging this PR, Spark can't build with Hadoop2.7. The build hangs for over 1 hour
$ ./build/mvn clean package -DskipTests -B -Pmesos -Pyarn -Pkubernetes -Psparkr -Pscala-2.12 -Phadoop-2.7 -Phive -Phive-thriftserver

...
[WARNING] spark-launcher_2.12-3.2.1-SNAPSHOT.jar, unused-1.0.0.jar define 1 overlapping resource:
[WARNING]   - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /Users/gengliangwang/projects/spark/launcher/target/spark-launcher_2.12-3.2.1-SNAPSHOT.jar with /Users/gengliangwang/projects/spark/launcher/target/spark-launcher_2.12-3.2.1-SNAPSHOT-shaded.jar
[INFO] Dependency-reduced POM written at: /Users/gengliangwang/projects/spark/launcher/dependency-reduced-pom.xml

Could you help fix it?

@gengliangwang Oops, I'm taking a look on this.

Yes this is the reason that last time I disabled the config. I think we are running into some Maven bug that is similar to this one. To fix it, I think we can put the newly introduced
    <dependency>
      <groupId>org.apache.hadoop</groupId>
      <artifactId>${hadoop-client-runtime.artifact}</artifactId>
      <version>${hadoop.version}</version>
      <scope>test</scope>
    </dependency>

in launcher/pom.xml to a hadoop-3.2 profile section. Tested locally and this is working. Let me see if other modules have similar issues.

I opened #34100 for this.


Wrapping some extra components inside of the Context Menu Component

For the context menu we have not wrapped some of the components.
We wrap the context menu here in the code: https://github.com/reflex-dev/reflex/blob/main/reflex/components/radix/themes/components/context_menu.py and we want to add these other sub-components mentioned above with all their props and event handlers.

[ ] Label
[ ] Group
[ ] RadioGroup
[ ] RadioItem
[ ] CheckboxItem

Hey @tgberkeley! I would love to contribute to Reflex, the link that the linear bot posted is not opening up for me though.  Is this task still available?

The link posted by the linear bot doesn't have additional info, it's just there for tracking in our private linear.
Since the task is still open, it's available yes.

Awesome, if you could set me as assignee for this task please, I'd appreciate it!

Hi @tgberkeley  and @Lendemor if possible I would love to be assigned to this issue. I have got the project locally working and have an idea of how to wrap these components. If this is available, please assign it to me.

Updated the initial post with a checklist for the missing components.
@LucasOcampos @vydpnguyen @KarinaNi feel free to pick up any of the components in there and submit them.
The PR for the checkbox seems to works, we just need the other now 👍

Hi,
I can do radiogroup and radio item.

Hi @KarinaNi, how are the RadioGroup and RadioItem going for you? I've finished the CheckBoxItem part.

Hi, I shall try to finish it by today. I added all items so ill just commit the radio ones so give me a bit of time so i finish that

update: finished making the changes in code. Trying to get all success in the tests
poetry run ruff check .
poetry run pyright reflex tests
find reflex tests -name "*.py" -not -path reflex/reflex.py | xargs poetry run darglint

update: finished making the changes in code. Trying to get all success in the tests
poetry run ruff check .
poetry run pyright reflex tests
find reflex tests -name "*.py" -not -path reflex/reflex.py | xargs poetry run darglint

currently getting errors related to navbar, table etc in pyright reflex tests

You should pip install pre-commit
then pre-commit install
If you are just adding new components it should not break any of the existing tests.


Document annotation service.kubernetes.io/topology-mode

Added the Annotation service.kubernetes.io/topology-mode in the  https://kubernetes.io/docs/reference/labels-annotations-taints/
#43389

/retitle Document annotation service.kubernetes.io/topology-mode

Thanks for correcting me and guiding me sorry for that inconvenience. I am new to this for next time I will add in the description.

/sig network

/label tide/merge-method-squash
/lgtm

Thanks @MeenuyD
LGTM

Thank you for the addition
/approve


Update quick-start-guide.md

Modify minor errors and correct some misunderstandings in the document
Why is this PR needed?
Modify small errors in the document and add some instructions to improve the readability of the document
What changes were proposed in this PR?
Modified some errors in the code and added some necessary instructions
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Can one of the admins verify this patch?

add to whitelist

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4077/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5822/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/225/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5827/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4082/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/230/

LGTM


Privacy Pro onboarding experiment

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4909  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on  Graphite


Can't login into towns

Describe the bug
Hello. Didn't find any discord or support so trying to ask here. I use gmail<EMAIL_ADDRESS>to login. Recently i tried to open my own room and had some error on payment saying i need to relog, and now i can't even login, getting every time:
There was an error logging in to River.
An unknown error occurred. Cannot save transaction.
To Reproduce
try to login
Expected behavior
tried different browser still can't login, help me pls or tell me where to ask for help
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Processor: [e.g. arm64, x86]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Logs

stream node syslogs
postgres logs
blockchain explorer transactions

Additional context
Add any other context about the problem here.

Hello @vilyinykh
We use GitHub issues as a place to track bugs and other development-related issues.
Please write us back using our “Chat Support” icon located on our River Help Center
You can include a link to this issue in the message content.
Alternatively, you can also search for an answer in our help documentation or get help from other users on our community forums.
The issue here will be resolved.
Thanks!


[New Port Request] libmagic-dev

Library name:
libmagic-dev
Library description:
This library can be used to classify files according to magic number tests.
Source repository URL:
https://packages.debian.org/sid/libmagic-dev
B.R

what is going on? it took 6 weeks ...
u guys rly pay for this?!!!
shame!

Hi @regexizer thanks for posting this request.
This port has been added to vcpkg. Please update vcpkg and try to use it.


2 unwinders

Comparing results with master, and with libunwind only, for amg2006, amg2013 and amgmk.


pg search indexes

waiting on #1565 - i reviewed the use of search indexes and made some changes.

notably never use a trigram threshold as it currently will not use an index.
don't use prefixes for tsvectors just use the trigram properly for fuzzy matches.
user_groups only search the display name for trigrams to keep the index size down.
use gin trigram op indexes, i couldn't get the derived pg_search queries to use the gist indexes.

Looks like this needs a rebase too.

rebased - @parrish or @marten it'd be cool to get this out today.

:shipit:


Break the application up and add tests

The first pass at this was done in a single Go file but to make it testable we need to break the monolithic Go application into smaller packages/subpackages.

This is completed as of a4af37be36f08328bfa67404e770e0a99c13dcda.


Added new programs

I have added new programs in C++ language.

Great work please give this repo a star and follow me for follow back 😊


Skip logging only for IllegalInputException

Add IllegalInputException to signal cases where we know the exception
is caused by illegal input received from the requestor.
Only skip logging for IllegalInputException instead of the superclass
IllegalArgumentException as that is also used to signal illegal
arguments to methods due to bugs which are otherwise hard to debug.
Throw IllegalInputException rather than IllegalArgumentException
where appropriate.
Deprecated QueryException as it was only used to be able to separate
between query string and query parameter exceptions, and not doing
that consistently, and is in a package we don't want more use of.
Clean up some cases where the wrong exception was thrown.

Build fails with:
[ERROR] /source/config-model/src/test/java/com/yahoo/searchdefinition/derived/NearestNeighborTestCase.java:[30,18] cannot find symbol
  symbol:   class IllegalInputException
  location: class com.yahoo.searchdefinition.derived.NearestNeighborTestCase


Prepend chromosomes with chr to match the SAM/BAM files.

Hi Robin,
The demo was failing because the chromosome names didn't match up with the alignment files. This fixes that. Hope you are well.

Coverage decreased (-1.05%) to 73.68% when pulling c87632384067b919ccd4677f3f42694f5b143aa8 on roryk:master into b8c3762e0bf739f8481dcf6abdf37e30377d6d1f on robinandeer:master.

Coverage increased (+0.08%) to 74.82% when pulling 09f4504aef77508739c441a1ac0a250371d3738f on roryk:master into b8c3762e0bf739f8481dcf6abdf37e30377d6d1f on robinandeer:master.

Sorry, I'm terrible and added a separate commit on to this cosmetic one. If you like one and not the other feel free to ignore one of them.

Thanks a lot @roryk - good catch!
I'll be happy to test the PR locally after you've made the few suggested changes
If you have time you could also update the __init__.py imports to make it easier to import the new apply_bed_stream.

Coverage increased (+0.08%) to 74.82% when pulling 808a533988d6a6c33e8d868b6a75a6b66d688971 on roryk:master into 80d377ff033fb4c7c94fe7fa8dfb99f908b0d76b on robinandeer:master.

Superb Rory!
Very nice touch with the rebase - I should keep learning more about how to do that
And I wonder what it say of me if I'm blushing a little reading you last comment? :sweat_smile: Thanks!


Added missing s2i flag for e2e test

What type of PR is this?
/kind failing-test
What does does this PR do / why we need it:
Add missing --s2i flag in e2e image test for s2i components
Which issue(s) this PR fixes:
Fixes NA
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
make test-e2e-all should pass successfully.

/approve

/lgtm
(since this is a very minor change)

/lgtm
(since this is a very minor change)

/lgtm


cmake: Add CheckCompilerVersion module

A new check allows to detect an incompatible old compiler early.
This functionality is not present in the master branch.

This is antithetical to how we've designed our build-system historically :)
We've typically tried to test for features and bugs rather than the tools themselves. The only use for this type of filter imo would be a blacklist for known-broken compiler versions, rather than a whitelist for good ones.
Unless I'm missing some reason for this... Concept NACK.

Not arguing, but document some requirements for tools (e.g. their version) without forcing such requirements in the code seems suboptimal to me.

Then argue!!
:)

Then argue!!
:)

A good example to support my point is https://github.com/bitcoin/bitcoin/pull/28210.
This proposal is an effective way to notify the user about an unsupported clang version as early as possible.


Wrong archives linked in tutorial

Thanks for your great work on angular-2.0 and meteor.
I tried run the tutorial by downloading the archive zips linked at http://ng-meteor.meteor.com/tutorials/angular2/adding-removing-objects-and-angular-event-handling.
As a newbie I run into a couple of small problems. Reasons for these problems are all fixed in the repository (https://github.com/Urigo/meteor-angular2.0-socially). However the tutorial still links the wrong archives, e.g. release "step_03", which still imports 'angular2/angular2', instead of "step_3" which already fixes these issues.
I apologize if this is not the right place to report this issue, but the "improve this doc" link in the tutorial does not work to fix it myself. However it links to this repository.
BTW: After I first discovered how to fix the issues mentioned above myself, I had to delete my browses cache manually to make sure "app.html" gets reloaded. I just discovered by chance that it always comes from the cache. Is this behaviour is expected?

@ChrisLasar is that still the case with the new deployed version?

Dear @Urigo ,
thanks it seems to be fixed now.


🚀 Add random method to Character

Resolve #448

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

SwiftLint found issues
Warnings

File
Line
Reason

CharacterExtensionsTests.swift
71
Lines should not have trailing whitespace.

CharacterExtensionsTests.swift
75
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

Updated to compare strings constructed of 10 Character.random() characters. Chose 10 as this is the length used for the random string tests, but it is otherwise arbitrary.

Updated name and removed the blank line SwiftLint warnings. Tangentially, removing some of the blank lines breaks the style of the file (consistent spacing between functions), so it might be beneficial to come up with a standard for whether blank lines are appropriate and enforce even retroactively.

Ah, @oliviabrown9 the warning was actually regarding an annoying Xcode default. It’s not warning against new lines but rather new lines that contain other forms of white space such as spaces or tabs. In your Xcode preferences you can actually set a flag to automatically trim the trailing whitespace. I wish this was the default ☹
Sent with GitHawk

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃


Send private message notification doesn't save private message to database

Is this by design,or a bug?
I override the PrivateMessageSenderSideManager to solve this.

Have you installed this module? https://github.com/EasyAbp/PrivateMessaging

I have installed.
The problem is SendPrivateMessageEventHandler calls the CreateAsync() method of PrivateMessageSenderSideManager, , but there is no database operation in this method,but in ApplicationService
        public virtual Task<PrivateMessage> CreateAsync(IUserData fromUser, IUserData toUser, string title,
            string content)
        {
            var privateMessage = new PrivateMessage(GuidGenerator.Create(), CurrentTenant.Id, fromUser?.Id, toUser.Id,
                title, content);

            _unitOfWorkManager.Current.OnCompleted(async () =>
            {
                var eto = new PrivateMessageSentEto(privateMessage.TenantId, privateMessage.Id, fromUser?.Id,
                    fromUser?.UserName, toUser.Id, toUser.UserName, privateMessage.CreationTime, privateMessage.Title);

                privateMessage.MapExtraPropertiesTo(eto, MappingPropertyDefinitionChecks.None);

                await _distributedEventBus.PublishAsync(eto);
            });

            return Task.FromResult(privateMessage);
        }


Make sure Netlify deployments are not listed with their .netlify.com domain in Google and Co

Currently this can happen (note the .netlify.com domain instead of prisma.io):

Unfortunately this is not just one domain, but this is happening for many of them:
https://www.google.com/search?q=site%3Anetlify.com+prisma

We need to implement something that tells search Engines like Google not to list these .netlify.com domains, while still not forbidding indexing of prisma.io, v1.prisma.io etc.
For many subpage deployments we can probably just add a robots.txt that forbids indexing (old docs, old homepages etc). For the main deployment of the website we will need to think of something smarter somehow.
After this is in place, we will need to tell Google to remove these pages and track the removal.

Internal discussion with possible workarounds or solutions:
https://prisma-company.slack.com/archives/C5Z9TH6N9/p1585147685000200

@janpio I suggest adding a robots.txt like this (deny all)
User-agent: *
Disallow: /

On all netlify deployments that are deployed as subdirectories.
And for the rest / in general use canonical urls with the production url.

Ok, that will require collecting and classifying all the hosts/deployments and then careful applying of these to not mess it up accidentally (especially with the Netlify redirect fallbacks in use sometimes).

It looks like we have about 3000 urls that should not be indexed, based on this Google search I found that we need to remove:

homepage-v7-photonjs.netlify.com
prisma-docs.netlify.com
prisma2.netlify.com
prisma-docs-till-1-33.netlify.com
howtographql.netlify.com
prisma2.netlify.com
prisma2.netlify.com
graphcool-v3.netlify.com
master--howtographql.netlify.com

I also found these public netlify pages, I didn't these could be public 🙃

https://app.netlify.com/sites/learnapollo/deploys
https://app.netlify.com/sites/yoga2/deploys
https://app.netlify.com/sites/graphql-playground/deploys
https://app.netlify.com/sites/opencrud/deploys
https://app.netlify.com/sites/oss-prisma-io/deploys
https://app.netlify.com/sites/graphql-yoga/deploys
https://app.netlify.com/sites/howtographql/deploys
https://app.netlify.com/sites/graphql-europe-2018/deploys
https://app.netlify.com/sites/learnrelay/deploys

For Netlify it looks like turning the logs to private makes the pages private, so I did it for most of them except https://app.netlify.com/sites/graphql-playground/deploys as there is some activity there.

based on this Google search I found that we need to remove:

We should do this more fundamentally and also apply this to other Netlify properties that are not listed yet - or they might be one day.

@janpio We can probably delete:
https://app.netlify.com/sites/homepage-v7-photonjs/overview
https://app.netlify.com/sites/homepage-v7-lift/overview
Because lift.prisma.io and photonjs.prisma.io are redirecting to:
https://github.com/prisma/prisma/releases/tag/2.0.0-preview020

@janpio We can probably redirect https://ru.howtographql.com/ to https://www.howtographql.com/

@janpio Do we still use it or can we remove it? (https://app.netlify.com/sites/prisma-docs-till-1-33/)
https://prisma-docs-till-1-33.netlify.app/
I we still use it I suggest adding a robots.txt but as it's a manual deploy not linked to a git, I have no idea who should do it.

@janpio https://prisma-docs.netlify.app is linked to https://github.com/graphcool/prisma-docs but 404, do you know where it lives now?

@janpio We can probably delete:
app.netlify.com/sites/homepage-v7-photonjs/overview
app.netlify.com/sites/homepage-v7-lift/overview
Because lift.prisma.io and photonjs.prisma.io are redirecting to:
2.0.0-preview020 (release)

https://github.com/prisma/prisma/issues/1949#issuecomment-620713815
I set a password (WiFi password) for these: https://homepage-v7-photonjs.netlify.app/ instead of deleting, because we might want to look at these ourselves.
Not sure how Google will deal with this though.
Alternatively of course we again can add a robots.txt

@janpio We can probably redirect ru.howtographql.com to howtographql.com

Yep go ahead and fix this, maybe ask why this exists in the first place though before changing anything.

@janpio Do we still use it or can we remove it? (app.netlify.com/sites/prisma-docs-till-1-33)
prisma-docs-till-1-33.netlify.app
I we still use it I suggest adding a robots.txt but as it's a manual deploy not linked to a git, I have no idea who should do it.

Yes still in use at https://github.com/prisma/v1.prisma.io/blob/master/_redirects - @2color just deployed all these so can do that for you if needed.

@janpio prisma-docs.netlify.app is linked to graphcool/prisma-docs but 404, do you know where it lives now?

You can ask Dom for access to https://github.com/prisma/prisma-docs-v1 (which is the name of the private repo that backs this it seems)

I can take this over as I've recently deployed the v1 docs. Shouldn't be a problem to add the robots.txt file

I successfully added canonical on https://www.howtographql.com/ 🎊
Fun session with netlify deploys 😅

Added robots.txt to https://prisma-docs.netlify.app/robots.txt

Google currently returns "About 1.400 results" I will check again in a few days.

https://www.google.com/webmasters/tools/removals?pli=1 might help if the correct robots.txt is in place.

I just requested the removals through your link @janpio 😃

It looks like some pages disappeared and for the rest some will take more time or it's not from us.

Problem still exists, now with a new TLD as well:
https://www.google.com/search?q=site%3Anetlify.app+prisma - About 1.290 results
https://www.google.com/search?q=site%3Anetlify.com+prisma - About 1.270 results

I requested removals from Google with both http and https urls for all of them including .com & .app we'll see how it ends up next week 🤷♂
I checked https://prisma-docs-till-1-33.netlify.app/ and I can't find a robots.txt nor a canonical so this one need to be fixed first or maybe just redeployed if the fix was already done 🤔
Also for the number of results it's really not accurate the next pages are full of content that we don't own.

@2color just added https://prisma-docs-till-1-33.netlify.app/robots.txt 🎊
I'm requesting deletion from Google for it and closing for good as the other results have a canonical and requesting a Google update doesn't work, it will just disappear one day 🤷♂

Some examples from my page 1:
https://prisma-docs-v2.netlify.app/robots.txt
https://howtographql.netlify.app/robots.txt
https://master--howtographql.netlify.app/robots.txt

@janpio We can't put a robots.txt on these pages because it will also apply to the production urls and get all the content down.
For these we added a canonical url but it seems that Google is kind of slow at picking that up and the removal tool is not cooperative on that either 🤷♂


Gradle can't not find dependency methods

Expected Behavior
My project should not tell me that it can't find the methods for dependencies such as implementation and compileOnly.
Current Behavior
I am  using CTRL+SHIFT+O to reload the changes to the gradle project structure. It tells me that it can't reload the changes with the following error:

Project structure and build / settings files
I have a project set up with 3 sub modules (bukkit, bungee, and common).
Project Tree
Project build.gradle
settings.gradle
bukkit/build.gradle
bungee/build.gradle
common/build.gradle - is empty
Context
I am trying to have 3 different modules that will be dependencies for minecraft plugins.
bukkit and bungee modules will be dependencies for Bukkit servers and Bungee servers respectively. common should be included in both bukkit and bungee to be used on either platform.
These will all eventually be deployed to some sort of repository.
Steps to Reproduce
You can clone / fork the public github repository here.
I have had issues with the automatic sync feature of Intellij as well as ./gradlew publishToMavenLocal
For me that gives the following:
D:\AGithub\Jaims\Jaims-Utils> ./gradlew publishToMavenLocal
FAILURE: Build failed with an exception.

* Where:
Build file 'D:\AGithub\Jaims\Jaims-Utils\bukkit\build.gradle' line: 7

* What went wrong:
A problem occurred evaluating project ':bukkit'.
> Could not find method implementation() for arguments [project ':common'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 598ms
PS D:\AGithub\Jaims\Jaims-Utils>

Your Environment
Build scan URL: https://scans.gradle.com/s/aplhnhm4zdxyo
I have had issues both running the commands via Intellij and from command line. The scan from above was achieved by ./gradlew build --scan
I also generated a scan using ./gradlew publishToMavenLocal since that is what I am trying to do if it is useful.
It can be found here

If my pastes expire, I will re upload them, or they can be found in the github repo (most of them)

pretty sure i resolved it by using allprojects {} to hold my apply plugins and dependencies/repositories
plugins {
    id 'maven-publish'
    id 'org.jetbrains.kotlin.jvm' version '1.3.72' apply false
}

allprojects {
    apply plugin: 'maven-publish'
    apply plugin: 'org.jetbrains.kotlin.jvm'

    repositories {
        mavenCentral()
    }

    dependencies {
        compileOnly "org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.72"
    }
}

subprojects {
    group 'dev.jaims.jaimsutils'
    version '2.0'
}

publishing {
    publishing {
        repositories {
            maven {
                name = "GitHubPackages"
                url = uri("https://maven.pkg.github.com/jaimss/Jaims-Utils")
                credentials {
                    username = project.findProperty("gpr.user") ?: System.getenv("USERNAME")
                    password = project.findProperty("gpr.key") ?: System.getenv("TOKEN")
                }
            }
        }
        publications {
            gpr(MavenPublication) {
                from(components.java)
            }
        }
    }
}

compileKotlin {
    kotlinOptions.jvmTarget = "1.8"
}
compileTestKotlin {
    kotlinOptions.jvmTarget = "1.8"
}

thats what it looks like now and it seems to be working in case others come across this issue


add carrenza hosts details on AWS staging backend machines

Context
During the AWS migration, the link-checker-api is being migrated to AWS without migrating the other services which still live in Carrenza. For the AWS link-checker-api migration, the AWS backend machines (which hosts the link-checker-api application) need to retrieve the IP of the Carrenza services machines. Hence, the {ip, fqdn} entry needs to be added in '/etc/hosts' file of the AWS backend machines.
Decision
For AWS staging environment:

Add the hosts::migration class to the backend node class
Configure the AWS hiera data to include {ip, fqdn} entry

Co-Authored-By: rtrinque<EMAIL_ADDRESS>

I am pretty much happy with this. I cannot be sure as to the validity of the hosts considering, the fact, I fear that if some hosts are required within AWS and the FQDN is added to the hosts then we may get an outage. I base this on the fact that Linux will check /etc/hosts first.
I would recommend pinging the nodes from AWS to Carenza randomly just to ensure there is a path to all nodes.


Minor profile save issues

1.) If the config file attempts to save to a nested directory the mkDirSync is not creating the directory structure.
2.) The profile filenames are being saved as .json.json (not really an issue but looks odd.)
Pull request forthcoming...

alright, I just fixed the 2nd problem since it was quite simple and I had to update the version, the fix for 1st problem is welcoming, thank you.

oh, you already sent a PR , thank you I just merged :smile:


Getting ts-loadder error

I recently moved the project from SPFX 1.11 to SPFX 1.12. I updated all libraries to the compatible latest versions. I'm able to bring up the webpparts using gulp serve.
With fast serve I'm getting an error as shown in the attached screenshot. I was able to use fast serve successfully before, but something has changed. Please advice.

dependency:
"spfx-fast-serve": "^3.0.2"
dev-dependency:
"spfx-fast-serve-helpers": "^1.12.22"

Please completely remove node_modules, package-lock.json and reinstall dependencies. Then run fast-serve again.


Initiate integration report

Closes #272
Here I started the initial steps for adding in the integration report to the integration workflow. I kept the actual report itself very simple and just am creating a UMAP colored by batches for now. I think we could also add in a table of number of cells per batch and then the UMAPs by cell type, but since we don't actually have cell types implemented yet I decided to hold off. The main thing I want to figure out here is how exactly we are going to read in all of the integrated objects and merged objects, combine everything, and create the report.
What I chose to do here is directly read the merged sce, fastmnn sce, and harmony sce into the notebook. I also don't need to actually keep the integrated objects around, I just grab the dimension reductions from post integration and then add those to the merged SCE object. At the end of the report I'm saving the merged SCE object with the integrated results now being added in and that is getting published to the results directory. Technically we could have a separate script that does this and then the report could directly read in the merged object that already contains all the results. I could be convinced either way.
The other thing I chose to do here was directly render the report in the Nextflow process, rather than writing a script to render it. I did think about creating a script that first does the data wrangling and exports the SCE object and then renders the template, but I had already spent a lot of time on this and wanted to get others opinions before I did that to see if it was even necessary.
I did have a question on the best place to store the .Rmd files? I think we probably want to create a separate folder for templates? Any thoughts on naming that folder or do we want to move it to bin instead?
Also you'll notice that I have two consecutive .combine steps to get a tuple containing the integration group, merged SCE file, fastmnn SCE file, and harmony SCE file. I tried to pass the merged SCE file as output from both integration processes and then just have one .combine step using by: [0:1], but Nextflow kept skipping the process, making me think it didn't like passing the merged SCE file as input and output?
I'm still doing some testing and debugging to get this to run to completion, but I wanted to get this up.

A few comments as you work on this:
I think I would separate out merging the integrated SCE objects into a separate process, then have the template take only a single integrated_sce.rds file which includes all of various reduced_dims. Right now we also have the two reductions happening in parallel; it may make sense to do them serially and just add each reduction to the same object: as long as there are only two steps I doubt the real time difference would be that great, and the integration functions don't need to know that there were other integrations applied previously, as long as they aren't removing anything, which they should not be. That saves us from having to do any .combine steps, which I think are a common source of error/confusion. For ease of use, we might want to add a metadata variable that details the integrations that were performed to make automatically accessing all of the integration results later easier & automated.
I like having the templates directory: you can see I did the same thing in #283; in case this becomes more complicated, it might make sense to put the report in its own subdirectory, but the current implementation is fine for now.

Right now we also have the two reductions happening in parallel; it may make sense to do them serially and just add each reduction to the same object: as long as there are only two steps I doubt the real time difference would be that great, and the integration functions don't need to know that there were other integrations applied previously, as long as they aren't removing anything, which they should not be. That saves us from having to do any .combine steps, which I think are a common source of error/confusion.

Do you mean have the output from fastmnn be the input of harmony? And then the result is one single object with merged counts and dim reductions from two different integrations. If we do that then we wouldn't need to have a separate script since everything would already be merged into one object.

Do you mean have the output from fastmnn be the input of harmony? And then the result is one single object with merged counts and dim reductions from two different integrations. If we do that then we wouldn't need to have a separate script since everything would already be merged into one object.

Yes, that is what I mean, and yes, it would save a script! (This is the result of me not looking at what I wrote first when I thought about something a few minutes later...)

Okay I like this plan! I'm going to make those changes.

I'm going to go ahead and request review on this because I've made the changes to pass the same object through to both integration processes now and removed the extra steps of putting all the results into one object and writing that out from the report. Everything seems to work now, and I've attached a copy of the rendered report. I think the actual publishing step is still a little wonky, but it is writing the output.
The other thing I didn't do is incorporate a variable for the integration methods yet. I wasn't quite sure what was meant by doing that and if we wanted to pass those in as params in the notebook directly, or store that information in the metadata of the SCE objects?
rhabdomyosarcoma-dyer_chen_summary_report.html.zip

Thanks for the suggestions. I incorporated your comments, including adding the integration method to the metadata of the SCE object. I also agree that this isn't where we should be making changes to the report, because I think it's definitely in infancy stages. This is just to get things started and then we can make the report "prettier" and incorporate more plots.
That being said, I did stop printing out the color messages and added in the session info suggestion and it does look a little bit nicer for now.
acute_myeloid_leukemia-gawad_summary_report.html.zip


Can't input Tab after a comment

In a comment line like #comment, typing Tab just after the 'comment' doesn't insert a Tab.
If a space exists after the 'comment', hitting Tab key can insert a Tab.

I can't repro with 0.3. Perhaps some special code snippet? Thanks

I found that this was only occur when I turned on "Completion list on Tab key" of IntelliSense.
For other editor settings, see

https://github.com/Microsoft/RTVS/commit/468732e509cab0e9ff2a8d509e9afc2059d2174d


Add loops

Shouldn't be too hard.

PR #7 adds this, but I'm leaving this open to remind me to document them.

Regarding #4, Arrays could use for..of loops:
myarray = [1, 2, 3, 4]
for value of myarray do
  print value ? idk what the syntax is
end

That's the plan. Once I add Arrays, I'll make ... to ... by ... an expression that returns an Array.

I documented the loops in the wiki, so I'm closing this.


shipping container bug

A shipping container does not transfer resources via communication to cargo ones if resources are put into it manually or shipped from a ship. If you remove the connection between them and reconnect it, the resources will move .The transfer will also occur when a new container is added to the chain.But it only works 1 time.

Game Version
1.14.70
Language
Английский (EN)
New Game
Yes
Reproduction Steps
Build an outpost , a shipping container and a cargo container , connect the shipping exit and the cargo entrance  .Put the resources in the shipping container.

This is a bug of the original game

Only mass transfer does not work, resources are transferred only by one category or by creating a trigger. The trigger can be adding a resource, reinstalling a connection, or adding a container to the chain.


My summernote widget form dosent render when in production in heroku

My summernote widget does not render on production. When i have it on my local machine and with debug mode on it would work and everything would work. When i checked heroku logs it would return a 200 http status. All my other views would work fine on heroku.

Fixed this error by setting X_FRAME_OPTIONS off.
Whoops

I tested it in the similar environment, but there was no problem.
Could you check the domain name when you used in production code? If the domain name is same, there should be no error.


fix(docs): inconsistent spacing in theme_CSS

Inconsistent Spacing in the code lines.
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Thank you  @Sboonny

Thank you for taking the time to contribute.
Please edit your PR title to match our recommended convention: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=prepare-a-good-pr-title

Thank you for taking the time to contribute.
Please edit your PR title to match our recommended convention: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=prepare-a-good-pr-title

ive made the changes

Hi @AirSayy, the title is Update _theme.css which isn't descriptive

Hi @AirSayy, the title is Update _theme.css which isn't descriptive

kindly confirm my most recent change....

@AirSayy we follow this formula <type>([optional scope(s)]): <description>
So for your pr it can be something like fix(docs): inconsistent spacing in theme_CSS

@AirSayy we follow this formula <type>([optional scope(s)]): <description>
So for your pr it can be something like fix(docs): inconsistent spacing in theme_CSS
Thank you for your patience and willingness to help

thank you sboonny for your patience too, im new here and its still a bit blur....i hope to be better each time..

Let's go ahead and get this in.
__        Summary: 👌 This code looks good

thanks naomi!!! i appreciate


alloc feature broken in nightly

https://travis-ci.org/gimli-rs/gimli/builds/402095262
Haven't looked into it yet.

Things in the alloc crate are being moved around as part of stabilization (although the RFC for this is still open).

I sent pull requests to https://github.com/sfackler/rust-fallible-iterator/pull/7
and https://github.com/Storyyeller/stable_deref_trait/pull/4 so once they release new versions and https://github.com/gimli-rs/gimli/pull/310 gets in this should be fixed.

Thanks @gz :)

This is fixed, but it's still failing in the tests because the crossbeam dev dependency is pulling in stable_deref_trait/std.

We can't make crossbeam optional, because dev dependencies can't be optional yet (https://github.com/rust-lang/cargo/issues/1596). Maybe we could fix this by fixing stable_deref_trait so that it can build when both the alloc and std features are enabled (std would override alloc).

Or move the examples into their own crate (gimli-utils?).

crossbeam no longer depends on parking_lot, so this problem has gone away.


Multi select widget

Multi select widget component as described in #581

Codecov Report

Merging #582 into forms will decrease coverage by 0.35%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##            forms     #582      +/-   ##
==========================================
- Coverage   53.61%   53.26%   -0.36%
==========================================
  Files         215      216       +1
  Lines        5224     5259      +35
==========================================
  Hits         2801     2801
- Misses       2423     2458      +35

Impacted Files
Coverage Δ

src/forms/FormCheckboxComponent.js
0% <ø> (ø)
:arrow_up:

src/forms/FormInputComponent.js
0% <ø> (ø)
:arrow_up:

src/forms/FormRowComponent.js
0% <ø> (ø)
:arrow_up:

src/forms/FormMultiSelectComponent.js
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77c161...7bf4bae. Read the comment docs.


Add a news link to term.js

Become a part of the Anythingbot Programming News Network today!
This PR adds a link to botwillacceptanything television---BWAA TV---which has just been remodeled.
If you want to change the video feed, or have any other suggestions, please make an issue or pull request for anythingbot/anythingbot.

A little confused here —anythingbot is a different project, right...?

@andrewda yes, another democracy bot

So why are we adding it to this project? We could add our own television system, I guess, but it seems a little weird to link to anythingbot without explanation.

@andrewda There are many reasons to add a link, for example the promotion of ties between the projects. I would be happy to explain further, for example by giving more reasons.

Would you change your vote if someone made a video of an introduction and comparison / contrast between the chaosbot and botwillacceptanything? This could start as an essay rendered as an audio or video project, perhaps with some NPR-inspired theme music.


Embedding recorder

Hi,
I'm trying to embed a recorder in my zend project. I compiled this project by npm run build and it seems that everything is fine with that.
I copied "as is" the compiled index.html in a my view and edited the link to embed polyfill.js.
My project is hosted by  a virtual machine (Ubuntu 18)
Chrome returns an error (getUserMedia is null). I can understand it even  I think that that could be handled better.
But if I force Polyfill it returns "Your browser doesn’t support MediaRecorder or WebRTC to be able to polyfill MediaRecorder." That is impossible.
Same answer by Safari (actually event not forcing) and Firefox,
What am I missing ?
Thank you

Try to create a question on StackOverflow. Sorry, I can’t help with configuring the environment for tricky cases. If you will find the exact problem, feel free to open the issue to fix docs and code.


Bluefin with Surface kernel fails to update due to OSTree error "Multiple kernels found"

Describe the bug
When I start the application "System Update", the subsequent update fails with error message error: Committing: Multiple kernels found in /usr/lib/modules
Terminal output during the failing update:
── 13:10:27 - System update ────────────────────────────────────────────────────
note: automatic updates (stage) are enabled
Pulling manifest: ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-surface:gts
Checking out tree 052041c... done
Writing OSTree commit... done
error: Committing: Multiple kernels found in /usr/lib/modules
System update failed:
   0: Command failed: `/usr/bin/rpm-ostree upgrade`
   1: `/usr/bin/rpm-ostree` failed: exit status: 1

Location:
   src/steps/os/linux.rs:273
Retry? (y)es/(N)o/(s)hell/(q)uit

The location mentioned in the error message contains the following files:
ls -lart /usr/lib/modules
total 0
drwxr-xr-x. 1 root root 770  1 jan  1970 6.8.8-1.surface.fc39.x86_64
drwxr-xr-x. 1 root root 834  1 jan  1970 ..
drwxr-xr-x. 1 root root  54  1 jan  1970 .

What did you expect to happen?
The update finishes successfully without errors.
Output of rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-surface:gts
                   Digest: sha256:1306f0d05c5ce1a6b8be69793a22493cc89f3c285597a94b6fd9643ec5eb0639
                  Version: 39.20240525.0 (2024-05-25T16:49:38Z)
             InitramfsEtc: /etc/crypttab /etc/modules-load.d/ublue-surface.conf

  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-surface:gts
                   Digest: sha256:3eb6f5ff8e913046544f8f6fdf78b2ec4f0d80ebedf99ef019e1229e18a24d50
                  Version: 39.20240524.0 (2024-05-24T16:49:28Z)
             InitramfsEtc: /etc/crypttab /etc/modules-load.d/ublue-surface.conf

Output of groups
stefanvandenberg wheel

Extra information or context
Links

ujust device-info link to pastebin: https://paste.centos.org/view/69127aaf
Discourse: https://universal-blue.discourse.group/t/cannot-update-aurora-surface-multiple-kernels-found-in-usr-lib-modules/1954
Discord: https://discord.com/channels/1072614816579063828/1087140903031943178/1245335380014792805

This issue also happens with the Surface version of Aurora using the Surface Pro 7+. It has the same error message and also only one folder in /usr/lib/modules.
When I install specific versions (e.g. rpm-ostree rebase ostree-image-signed:docker://ghcr.io/ublue-os/aurora-surface:40-20240525) this error does not appear for all versions that I tested until version 40-20240525. For the versions after that, the error appears again.

The surface images are broken at the moment. The build process for reasons unknown to me fails to remove the old kernel, resulting in a /usr/lib/modules directory with multiple kernels which rpm-ostree then refuses to use. This is probably due to some upstream change.

Thank you for your reply -- do you by any chance know (or can make an educated guess) at how long this problem might persist, and if there are any possible solutions one could do locally for this that would allow Surface users to update?

Not sure what's going on here, but it's not something obvious or something we've encountered the entire time we've been making this so hoping to reach out to as many people as we can to take a look.

For some reason the update just now was successful... so it indeed may be an upstream bug fixed in the meantime.
Nothing seems different considering the kernel version mentioned in /usr/lib/modules compared to previously.
I did not save the actual update log, but this is the new ujust device-info output: https://paste.centos.org/view/37415865

I've gone through (aurora|bluefin)-surface:(latest|gts) and can confirm that the problem is no longer present on any of these images.

Whew. 😄
Let's keep this open as a signpost, as we grow it'd be great to have technical folks more involved with linux-surface so we can help out.


Artifact not available through Bower

Why this awesome frontend lib is not hosted on bower?

I have extremely bad experiences with Bower...
Are you willing to make a PR to add support for it?
Only rule when adding bower support is: do not change the way things work now. Bower shouldn't be required for the library to be installed via NPM, nor it should be required at any stage of the process if the user isn't using Bower itself explicitly.

https://github.com/alexandernst/angular-multi-select/pull/100


Characters when typing in Terminal have boxes around them

VS Code Version: 1.56
OS Version: Ubuntu 20.04

Steps to Reproduce:

Update to 1.56.0
Open a terminal Window (Ctrl + `)
Type.
Resizing the window makes them go away.

Does this issue occur when all extensions are disabled?: Yes

Downgrading back to 1.55.2 does not cause the problem, so this is specific to the latest version:

Noting this is still in 1.56.2 on Ubuntu.

Also still the case in 1.57 and 1.58 insiders.

Does changing the terminal.integrated.gpuAcceleration setting help?

Does changing the terminal.integrated.gpuAcceleration setting help?

It does, yes. Changing it of "off" stops the problem occuring.


seems the yaml files not in UTF8 encoding

@gazbert
e.g., those yaml files in
/config
/bxbot-yaml-datastore/src/test/config

https://github.com/gazbert/bxbot/pull/115

@rayeaster - thanks for spotting this. Fixed in #115


Word sizes that are smaller or not multiples of 8 bits

Is your feature request related to a problem? Please describe.
I am familiar with the machine code and reverse engineering of many deeply embedded processors that have word sizes that are not a multiple of 8 bits. To be an actual universal reverse engineering tool, Ghidra needs to support any word size, include 1-bit or 33-bits etc. As of now I can't write a SLEIGH spec for the processors in which I'm interested for machine code reverse engineering.
Describe the solution you'd like
Extend the SLEIGH processor definition format to support word sizes that are sub-8-bit or not integer multiples of 8 bits.
Describe alternatives you've considered
I've considered "unpacking", say, 4-bit processors, into a 1-nibble per byte representation.
Additional context
I'm mainly interested in reverse engineering old calculators or computers whose firmware source code has been lost -- especially peripherals of above systems. I've encountered word sizes ranging for 1 bit, 4 bits and even 56-bits.

I know LLVM has something similar, for manipulating integer values at least. For example, one can specify a value as an "i4" integer, that is, a 4-bit nibble. See here .

+1. TeakLite II for instance has 40-bit registers.

This is typically done by rounding sizes to the nearest byte, modeling the processor language accordingly, and padding leading bits of instructions out to a byte boundary for import into Ghidra.

One significant example that I forgot to mention is the Microchip PIC12 universe of devices. In the case of the PIC12, the instruction words are 12 bits and the data words are 8-bits. In its current state, it would be very problematic or at least very frustrating to describe the above used processors using Ghidra, which is a shame, because tiny, deeply embedded microcontrollers and DSPs are utilized in a huge amount of devices and they usually have none-stand word sizes.

This is typically done by rounding sizes to the nearest byte, modeling the processor language accordingly, and padding leading bits of instructions out to a byte boundary for import into Ghidra.

Thank you for the informative reply :) Could you go into more detail on how what you suggest can be implemented or share a link to an explanation of such an implementation?

M16C has 20bit registers... how am I supposed to handle these in Ghidra?

@RyanHope  We have a pic12 processor spec (mentioned by @jdb2 above), it might be worth checking out that implementation if you're interested in seeing what an off-sized register language looks like.


[FEATURE REQUEST]: Update SPL's Colorado River Clipping Extents

Feature Request Type

[ ] User Interface (UI)
[X] Application Programming Interface (API)

Is your feature request related to a problem? Please describe.
The latest CWMS implementation of the Lower Colorado River has been extended.
Describe the solution you'd like
Please update the extents using the attached
SPL_LowerColorado.zip

@Enovotny please assign to anyone who might have availability in the next week or two.  Otherwise, please prioritize at the start of Januay.


Improve DynamicYield detection

Example Site where it's not being detected - https://www.houseoffraser.co.uk/brand/ann-summers
Current Detection -
"Dynamic Yield": {
  "cats": [
    74,
    76
  ],
  "cookies": {
    "_dy_geo": "",
    "_dy_ses_load_seq": ""
  },
  "description": "Dynamic Yield is a provider of automated conversion optimisation tools for marketers and retailers.",
  "icon": "DynamicYield.svg",
  "js": {
    "recommendationContext": ""
  },
  "scripts": "cdn\\.dynamicyield\\.\\w+/",
  "website": "https://www.dynamicyield.com"
},

Improvement - Look for js object '_dy_memStore'
Also, there are bunch of other cookies start with 'dy' on this example site which you add to improve detection

Hey there , updated


Meetup API calls returning empty results

I just observed today that every API call I make returns { } without any true results.
This situation was also observed while using the Meetup API Console. A screenshot below shows this.

works now!


RFC: Add mysensors notify platform

Description:

Make add_devices optional in platform callback function.
Use new argument structure for all existing mysensors platforms.
Add notify platform.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
mysensors:
  gateways:
    - device: '/dev/ttyACM0'
  version: 2.0

notify:
  - platform: mysensors
    name: mysensors_notifier

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Don't merge! Need to rebase this when #4013 is merged.

Code looks fine with me 🐬 . You can merge this when you are ready.

I'll postpone merging this until after 0.32 release. If possible I'd like to setup the platform via discovery, but I haven't looked into what that would take yet.

Bump

I've added possibility of using discovery for notify platforms. I'd like @balloob to look at this, if it's viable.
As discussed in gitter, I've been experiencing occasional, 1/3 - 1/5 of every start, race conditions with this branch where the notify component is setup more than once. We don't want this to happen!
https://gitter.im/home-assistant/home-assistant/devs?at=58289aecdf5ae966454fe218
https://gitter.im/home-assistant/home-assistant/devs?at=58289fe831c5cbef43eec10b
From how I'm reading the code and from my testing it looks like this is due to how the _async_setup_component coroutine in bootstrap.py is written. It doesn't enforce a lock from the beginning of the function and only if the lock is not already locked will a run be required to acquire the lock. Discovery setup is required to acquire the lock if the lock is locked, before entering the coroutine, but will be allowed to run the coroutine as soon as the lock is released, since the next config component setup does not acquire the lock again immediately. Also, the check for if a component is already added, is done in the beginning of the function, and not after the lock is acquired, so it's more or less a lame duck.
With that said, I'd love to be proven wrong, or that we find a better way to implement discovery for notify platforms.

Sorry for not getting back to you earlier.
You are right here about the locking not being correct. I think an easy fix for this is to acquire the lock inside async_from_config_file. That way, no discovery will ever run while we are setting up from a config file.

I have resolved the discovery issue in #4463

I have made another fix for the discovery today #4529

Bump

One lint violation and some tests for notify component is still missing. I'll fix that asap.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Could not find network for container

Do you want to request a feature or report a bug?

Bug

What did you do?
I started up a matrix server via docker-compose

What did you expect to see?
That I can access my server on matrix.mydomain.de
I have tried to rename all possible networks in this configuration. The Error message stays the same.
What did you see instead?
A gateway timeout and the following traefik log message:
Could not find network named 'frontend' for container '/matrix_nginx_1'! Maybe you're missing the project's prefix in the label? Defaulting to first available network.
Could not find network named 'frontend' for container '/matrix_synapse_1'! Maybe you're missing the project's prefix in the label? Defaulting to first available network.
Output of traefik version: (What version of Traefik are you using?)

1.7

What is your environment & configuration (arguments, toml, provider, platform, ...)?
traefik docker-compose.yaml:
services:
  traefik:
    image: traefik:1.7
    command:
      - "--docker"

    ports:
      - "80:80"
      - "443:443"
      - 8088:8088
    restart: always
    labels:
      - "traefik.enabled=true"
      - "traefik.backend=dashboard"
      - "traefik.frontend.rule=Host:traefik.mydomain.de"
      - "traefik.port=8088"
      - "traefik.frontend.auth.basic.users=admin:$$2y$$05$$9WlxkprX6mv.vC08bMOLkeWNE7SkfbwjBV1jw7xDEc3Paedfbpt1G"
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock"
      - "./traefik.toml:/traefik.toml"
      - "./acme.json:/acme.json"
    networks:
      - default

traefil.toml:

logLevel = "INFO"
defaultEntryPoints = ["http", "https"]
[web]
# Port for the status page
address = ":8088"

[entryPoints]
  [entryPoints.http]
    address = ":80"
    [entryPoints.http.redirect]
    entryPoint = "https"

  [entryPoints.https]
    address = ":443"
    [entryPoints.https.tls]

[acme]
  email =<EMAIL_ADDRESS>  storage = "acme.json"
  entryPoint = "https"
  OnHostRule = true

[acme.httpChallenge]
  entryPoint = "http"

[docker]
endpoint = "unix:///var/run/docker.sock"
domain = "docker.localhost"
watch = true
exposedbydefault = false

Matrix server docker-compose.yaml:
services:
  postgres:
    image: postgres:9.6.4
    restart: unless-stopped
    networks:
      - backend
    volumes:
     - /opt/matrix/pgdata:/var/lib/postgresql/data
    environment:
     - POSTGRES_PASSWORD=***********
     - POSTGRES_USER=synapse
    labels:
      - "traefik.enable=false"

  synapse:
    image: avhost/docker-matrix:v1.0.0
    restart: unless-stopped
    depends_on:
      - postgres
    networks:
      - frontend
      - backend
    ports:
     # Coturn
     - "3478:3478"
     - "5349:5349"
    volumes:
     - /opt/matrix/synapse:/data
    labels:
      - "traefik.backend=synapse"
      - "traefik.enable=true"
      - "traefik.frontend=true"
      - "traefik.port=8008"
      - "traefik.frontend.rule=Host:matrix.mydomain.de"
      - "traefik.docker.network=frontend"

  nginx:
    image: nginx:1.12-alpine
    restart: unless-stopped
    networks:
      - frontend
      - backend
    labels:
      - "traefik.enable=true"
      - "traefik.frontend.rule=Host:mydomain.de"
      - "traefik.frontend.passHostHeader=true"
      - "traefik.port=80"
      - "traefik.docker.network=frontend"
    volumes:
      - ./nginx/matrix.conf:/etc/nginx/conf.d/matrix.conf
      - ./nginx/nginx.conf:/etc/nginx/nginx.conf
      - ./nginx/www:/var/www/
    command: nginx -g 'daemon off;' #-c /etc/nginx/conf.d/nginxcustom.conf

networks:
  backend:
    external:
      name: matrix
  # Traefiks network
  frontend:
    external:
        name: traefik_default

Well, ok, I am stupid.
I was using docker-compose start/stop instead of docker-compose up/down


Bug/Conflict with Resource Databases Plugin

I bumped into a weird error when trying to add this library to a new/empty project where I had already installed the Resource Databases plugin. (Link: https://github.com/DarthPapalo666/ResourceDatabases)
See this error:
Godot Engine v4.4.dev4.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
--- Debug adapter server started on port 6008 ---
--- GDScript language server started on port 6005 ---
  res://addons/logger/log-stream.gd:111 - Parse Error: Identifier "Log" not declared in the current scope.
  res://addons/logger/log-stream.gd:114 - Parse Error: Identifier "Log" not declared in the current scope.
  res://addons/logger/plugin.gd:-1 - Compile Error:
  modules/gdscript/gdscript.cpp:3038 - Failed to load script "res://addons/logger/plugin.gd" with error "Compilation failed".
  res://addons/logger/log-stream.gd:111 - Compile Error: Identifier not found: Log
  res://addons/logger/logger.gd:-1 - Compile Error:
  modules/gdscript/gdscript.cpp:3038 - Failed to load script "res://addons/logger/logger.gd" with error "Compilation failed".
  modules/gdscript/gdscript.cpp:147 - Parameter "p_script->implicit_initializer" is null.
  res://addons/logger/log-stream.gd:37 - Invalid access to property or key 'default_crash_behavior' on a base object of type 'GDScript'.

Well, that would almost look like the global Log autoload isn't present/enabled -- except it is. The weird part is that implicit initializer stuff. p_script->implicit_initializer appears to be attempting to call an implicit initializer of the superclass, Node.
I've spent some hours this evening going through the source code of this plugin, the Resource Databases plugin, and the gdscript.cpp file, but I haven't found anything obvious. So I'm starting to wonder if something here exposes a bug in godot itself.
Verified on Godot 4.3-offical (windows) and Godot-4.4-dev3
Steps to reproduce:

Create a new blank project
Add Resource Databases from the asset library
Add Log from the asset library
Enable both plugins in the settings
Reload current project

As an experiment, if I change the following line in log-stream.gd:
- func _init(log_name:String, min_log_level:=LogLevel.DEFAULT, crash_behavior:Callable = default_crash_behavior):
+ func _init(log_name:String, min_log_level:=LogLevel.DEFAULT, crash_behavior = null):

and reload the project, then the error changes to this:
  ...
  modules/gdscript/gdscript.cpp:147 - Parameter "p_script->implicit_initializer" is null.
  res://addons/logger/log-stream.gd:39 - Invalid call. Nonexistent function '_set_level' in base 'Node (logger.gd)'.

Any ideas?

I my memory serves, the issue is that Godot tries to load the singletons before the rest of the scripts in some edge cases. I think it's fixable through turning the addon off and on again, and then reload the editor, it has fixed itself for me. Good that you bring it up though, it shouldn't be this way.

Interesting. That appears to fix it once. However, if I immediately reload again it comes back. I'll see if I can figure out any workarounds.

I think I found a fix. This looks like it's due to a cyclic reference of Log -> LogStream -> Log.
In log-stream.gd near line 111 there is:
	if log_level > 3 && Log.is_inside_tree() && ProjectSettings.get_setting(settings.PRINT_TREE_ON_ERROR_KEY, settings.PRINT_TREE_ON_ERROR_DEFAULT_VALUE):
		#We want to access the main scene tree since this may be a custom logger that isn't in the main tree.
		print("Main tree: ")
		Log.get_tree().root.print_tree_pretty()
		print("")#Print empty line to mark new message

Where Log is used only on two lines.
As a first attempt, I thought we could break the cyclic link with something like this (abbreviated code shown):
    var log_singleton = get_tree().root.get_node("Log")

    if log_level > 3 && log_singleton.is_inside_tree() && ...:

        # [...]

        log_singleton.get_tree().root.print_tree_pretty()

        # [...]

Though looking at this more closely, it seems like the singleton would be in the tree because we just got it from the tree. So that seems odd. That makes me wonder if the original code was intended to be something like this?
    if log_level > 3 && self.is_inside_tree() && ...:

        # [...]

        get_tree().root.print_tree_pretty()

        # [...]

Removing the direct usage of the Log autoload from this file looks like it would resolve the load issue in my testing so far.

It was like that at one point, the problem with this implementation is that it doesn't work if the LogStream isn't in the tree. Could you check whether you have the correct singleton loaded under "Project settings"->"Autoload", there should be one called Log. Perhaps this has not been added correctly?`
The editor starting process should go something like the following:

editor start.
Log Addon start.
Log is brought into scope. (here the bug happends)
Autoload Singleton is added to tree.
Log works.

If you change log_singleton.is_inside_tree to log_singleton!=null. I think it should work better. If it solves it, a pull request would be greatly appreciated. Don't forget to add yourself as an author in the plugin.cfg file in that case.

Further testing indicates that the above issue seems to be intermittent for me. I added another couple of plugins and the issue seems to have gone away. But if I remove them it comes back. Definitely strange. I dont know what Godot's official stance on cyclic loads are. I'd probably vote to avoid them if possible.
Related to this, I just stumbled upon this issue in the godot issue tracker, which looks like it applies to how this plugin installs it's autoload variable:
https://github.com/godotengine/godot-docs/issues/9571
I'm not sure yet if this contributes to the issue I'm seeing, but it does look like we should probably update the code to use _enable_plugin()/_disable_plugin() instead of _enter_tree()/_exit_tree() for the autoloads.

Ok. Nevermind the part about being intermittent. Had a dirty working copy. The issue is still present with additional plugins.

Ok, I see why the implementation is the way it is, and I don't see an easy fix for removing that cyclic dependency and preserving the existing behavior. get_tree() unfortunately reports an error if you call it while not inside the tree (and also returns null), so that won't work.
However, testing with the _enable_plugin()/_disable_plugin() seems to fix the startup error I'm seeing, and also resolves an issue where the editor thinks that the project is modified every time it's loaded (e.g. it prompts you to save if you immediately do a project -> reload after opening). I will submit a PR for that part.

Please let me know if you have any further issues in this regard since this is a very annoying bug!


Allow to build the master branch instead of stable

I think we should get rid of the error-prone manual patching of the dlang.org repo (e.g. https://github.com/dlang/installer/pull/230, full list).
@MartinNowak This is a first step and should reduce the size of your patch drastically.
Does it help?

This looks like it's replacing one hack with another. Not really my area of expertise so no comment on this one.

This looks like it's replacing one hack with another. Not really my area of expertise so no comment on this one.

Yes, but the idea is that this hack doesn't break due to changes in the patch set.
(I asked for review as you are the dlang.org tzar and have veto rights against such hacks).

(I asked for review as you are the dlang.org tzar and have veto rights against such hacks).

Deferring all such rights to @MartinNowak for this PR.

It's not a hack, the release docs are a different target than the normal doc builds, b/c they are built before the git tags are published and do not include prerelease docs.
Looks good, but might not be sufficient, since the Makefile will still try to rebuild dmd/druntime/phobos and whatnot, instead of just using the passed DMD compiler.

Let's finish the ddox transition before investing more into this stuff, patching really doesn't hurt much atm.

they are built before the git tags are published

Why?
Also, why do they need to be published? Why not simply created locally?

patching really doesn't hurt much atm.

Well, it's your time ;-)


Fix union-type handling in PublicPropertyFetchCollector

closes https://github.com/TomasVotruba/unused-public/issues/119

Looks good, thanks

thanks. I prepare another PR with the same fix for static properties


Add tests for clear data page

What
Add tests for the clear data page
Why
We need to ensure the clear data page works
Who needs to work on this

developers

Who needs to review this

developers

Done when

[ ] We have tests for the clear data page

@Izabela-16 @ruthhammond @nataliecarey Next sprint planning to include and check if we have capacity plus if it has any impact.


Mobile version fails to load in Firefox on Android

Unsure if real bug or a a cache hiccup (unable to reproduce in Chrome, only Firefox)
Is anyone else able to reproduce below with https://play.google.com/store/apps/details?id=org.mozilla.firefox&hl=en&gl=US ?

Does it load correctly in a new private tab? Possible this is cache related if so.

Tested via browserstack and unable to reproduce, possible this was related to caching but we can continue to monitor.


Use getSuggestions endpoint behind the gate

When use_new_suggestions_endpoint is true, the Search tab uses the getSuggestions endpoint instead of what we're doing now (which hits getSuggestedFollowsByActor and then does the same for a few of them). The old behavior is preserved when the flag is off (which it currently is for everyone).
Test Plan
Go to search tab. Observe roughly the same set (or at least after a few refreshes) as in prod.
Then pass yourself in overrides for the use_new_suggestions_endpoint gate.
Observe a difference set of results. (They're not currently very relevant but we'll be improving that on the backend.)

to be clear, the endpoint we're hitting right now serves old results (which may still be better in some cases than our current ones) but the plan is to also update that endpoint to be better — so we'll try that later!


Introduce audioCues.volume setting

We should introduce the audioCues.volume setting. It should probably be a number from 1 to 10?
I am not sure how fine tuned you can set it in the web audio api
Default value should be in the middle as @gino-scarpino suggests

@hediet let's not do this yet. Assigning to backlog. And once users request this more we can reconsider.
If you are passionate about this feel free to bring back to the Milestone :)

What should the default be? It set it to 50, but maybe 100 makes more sense.

60?
I would hate that users find this setting and figure out it can not go any higher.
If we see that 60 the volume is still too law that means that the sound should be louder in the .opus file.

I'd love to see a volume control. I'd also like to see the re-enabling of the "enable/disable all" setting alongside the granular controls for each.
However, for the default volume can I suggest 0? I've just disabled all of the audio cues because I'm reviewing someone else's branch, and VS Code will not stop beeping at me. I have ADHD, and like many neurodiverse people I have auditory processing issues, which can make this kind of constant beeping very stressful.
To solve it I've disabled all of the sounds, and I likely won't be enabling them again. So the default setting here has resulted in me permanently disabling something which I may have found to be genuinely useful if it hadn't been so annoyingly stressful to hear all the time.
A better default experience would be to ask users if they want them enabled at all, and if they say yes to allow them to preview the volume before they commit. In future I think an option for a few different "sound palettes" would be a nice option too, because the sounds in use now feel too stabby to me!
I'm a little sad to see that this issue has been closed without a good reason why it's "not worth doing now", because I think the current situation is a definite accessibility issue. Given how good VS Code generally is with accessibility I hope that this issue will be reconsidered!

@Jonic thanks a lot for your suggestions and feedback.
Let me clarify that we have closed this issue because we have done it, not because it is not worth doing. You can try it out in VS Code insiders from tomorrow and we would really appreciate your feedback.
I agree that the volume control should support 0, but imho that should not be the default.
The current default imho is good = users do not hear anything unless they have a screen reader attached. If they have a screen reader attached only then they hear audio cues.
Having an option to set volume to 0 will give a master switch to disable sounds, and users can enable / disable each sound specifically. I believe this will prove to be a good user experience.

@hediet yeah, then we need louder sounds as Gino mentioned in our chat.
Let's see with him if we get them this week. Would make this setting more useful.

Verification steps:

Configure audioCues.volume. Default value is 50. Set to 10 or 100.
Trigger an audio cue (e.g. through the audio cue help)
Notice the volume is louder / quieter.

When the volume is at 100% and we press the up arrow, the orca announces the value of 101% followed by an error message. Something similar happens when the volume is at 0% and we press down arrow.
Would it be possible to use some key combination for bigger jumps in increment / decrement? Currently the jump is 1 when pressing down arrow or up arrow. Maybe ctrl+down arrow or ctrl+up arrow could produce an increment of 10.

@jvesouza good point. But the settings UI does not allow us to have this fine grained change of values. fyi @rzhao271
@hediet maybe that is the reason why we should keep it 1-10? Not sure.

Windows also uses 0-100 for the volume:

VLC uses percent:

But I'm open for 0-10.

Verified but I also wonder about the usefulness of 0-100. I am unable to hear the difference between 37 and 38...


Add option to bind node position on 2D graph canvas to (x,y) position. Or (x,y,z) in 3D.

Hi
I would like to display some node and control their location with a X, y coordinate or circular datum...I was wondering if possible to setup neodash with a custom grid in the background in order to control the nodes position?
Thank you

Hi @PatrickF-mbse ,
May not be really easy, but if you display your data on a Map Chart, you can control the position with a property (default 'point') that expects a spatial point value. You can always set a Cartesian x,y on it. So far, not to difficult, the tricky part is the background itself. You may need to provide a valid tile according to your needs. Im not an expert on that, but I have tested tools like gdal2tile with decent results.

Revisiting this feature request for NeoDash 2.5.  It would be great to fix node positions both in 2D and 3D.
This should be relatively straightforward using the fx, fy, fz properties from the library:
https://github.com/vasturiano/d3-force-3d#simulation_nodes

This would probably an advanced setting called Fixed Position Property which is set to a property key of a Spatial type.


Support query params in incoming urls for redirect

Currently incoming urls the json file like /orc/?doc_id=4683
will not work properly

In the short term—and in the long term, for things that we've chosen to port over, for one reason or another—any links with /orc/ in them are looking for documents. Graceful degradation would be to return a file not found with redirect to document search


support unicode filenames

I ran into a problem when one of my filenames was u'file.ogg' rather than 'file.ogg' (str).
This patch swaps out the string type-check for six.string_types.  (I also threw it on mode while we're at it.)
This does add a dependency on the six module, so I understand if you'd prefer to do it manually instead.
Probably, there are other places where the code can be patched up to work more smoothly with unicode and/or general py2/py3 compatibility.  I haven't done a thorough check though.

Incidentally, I created a PR for the same problem a few days ago: #119.
Mine doesn't add another dependency and it (hopefully) takes care of the other places where str() was used before.
Can you please review/improve #119?

Ah! Apologies for not checking outstanding pr's first.  I'll take a look.

Ok, looks like yours is indeed much more comprehensive.  Not sure I have anything to add at this point, but thanks for the quick response!
Closing this one.


How to hide ignored files in the project tree view

How to hide ignored files and directories in the project tree view ???

Right-click on the Project Tree View and select Hide ignored files

@hsz  thanks!!!


Allow for npm install from GitHub

I know this can be a contentious topic, but as the project is configured now, it's not possible to depend on the GitHub version of the library (for one, there's no build on install and, two, the files directive in package.json wouldn't provide the necessary files for one). At times like these, where major bug fixes are only available there until a new NPM release is published, this requires a fork with a committed build (as far as I know). I can live with that, but has anyone considered any acceptable reorganization of the project that makes a direct GitHub install possible?

I don't know what bugfix you're thinking of, but if you need to depend on master, you can add the master branch as a dep in package.json, then after npm install you need to cd node_modules/redux-simple-router and npm install && npm run build. But beware that master is very different from 1.0.2.

That's just it though. You cannot do that because of the files section of package.json. When you install from master, the only things that will end up in your node_modules are  the two *.md files, LICENSE, and package.json; none of the source code. So the naive suggestion is to remove the files section from package.json so that I can do a post-install build. I imagine though that that will have some impact on your publication process because you don't want those files to go to npm. In that case, you could use an .npmignore file

But beware that master is very different from 1.0.2.

Yes, indeed, and I've already got my code refactored to work with the changes. It was a necessity because the double updates were killing my navigation.

I'm happy to do a PR if that sounds like an acceptable solution.

Ah, so that's actually a con of https://github.com/rackt/redux-simple-router/pull/134 — didn't think about this use-case. I'll re-open and wait and see if others have any opinions on this. Hopefully we'll get a 2.0 out soon too.

Indeed, how about adding src to the files?
I think it can cover this use case.
https://github.com/koba04/redux-simple-router/commit/90ac7ce771cf6bfdc5e55b4673772fabaa1575bf
% npm install https://github.com/koba04/redux-simple-router.git#add-src-to-files-fields
% cd node_modules/redux-simple-router
% npm install && npm run build
:
:
% tree -L 1
.
├── CHANGELOG.md
├── LICENSE
├── README.md
├── lib
├── node_modules
├── package.json
└── src

I guess the obvious question is "Why limit it in the first place?"

I think npm install should only include files that are required to use it.
I think  an opt-in approach with files fields is better than an opt-out approach with .npmignore, because managed files by a project can be increasing over time.
I guess npm install ${github.repo} is not the common use case.
In many other libraries, npm install ${github.repo} have different results from npm install ${library}` and its GitHub repository.
Additionally, in many cases, npm install ${github.repo} requires some custom scripts to use it.
In this case, I guess it should be used the forked repository that is added scripts for a build.
As a result, I think it is enough to add src to files fields.
https://github.com/koba04/redux-simple-router/commit/90ac7ce771cf6bfdc5e55b4673772fabaa1575bf

I think npm install should only include files that are required to use it.

From the registry sure, but when you are specifically requesting the master branch from GitHub, I think you should get...the master branch from GitHub. At that point, you are using NPM as a transport mechanism for something else.
And what about the tarball? Don't you think it should be an archive of the repo as it existed at a certain release, not just what you publish to NPM, which is really an unrelated concern?

Indeed, I think the npm registry is not an archive site. It is a registry for npm as a package manager.
If I need an archive of the repository, I am usually using git clone from GitHub(master or releases).

I think @koba04 is right. For now let's just add src to the files field. Installing from npm and then manually running npm install inside the module works now.
I wish npm just ignored these fields when installing straight from a git repo. I would expect to get the full repo, but this works for now.


Feature request : Confirm prompt while updating the master password

Really nice project, it's my new daily password manager.
I wanted to update the master password and noticed that there wasn't a prompt that asked me to confirm the new one, in order to avoid mistakes would it be possible to implement that ? I'd like to do it myself, but i'm not comfortable enough in Go to do a PR yet.

Works as a charm ! Thanks a lot !


3D layout generation with Llama-2

Hi,
Thanks a lot for your work. I was wondering if there is a version for 3D layout generation with Llama-2.
Looking forward to your reply.
Best regards,
Cecilia

Hi Cecilia,
Yes, we could give it a try on both llama-2 and llama-3. I would be more available to work on it starting Oct. Please stay tuned.
Weixi


Nested classes are not available

sharpDox looks pretty cool, but after doing a test build for my project, I've found out that a good chunk of docs were missing. Turns out, nested classes are not added to documentation, in fact, they are not even in Visibility Settings. sharpDox is unusable for me without that, unfortunately... Am I missing something obvious?

Thanks for the report! This should not happen and I will investigate the issue.


Lose bold styling on transformed message after switching levels

Bug report
Description
Transformed message should show original message in bold like:

However after switching level, the bold effect is lost

Reproduction steps

activate XML tagging
send a message
see original message in bold
switch level then back
see bold effect is gone

Expected behaviour
Bold style persists when changing level
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):

Browser: [e.g. chrome, safari]

Additional context
Add any other context about the problem here.
Acceptance criteria
GIVEN some setup
WHEN an action happens
THEN the expected outcome

Duplicate of #741


Again: Assume a well-formed environment in fast erasure, avoiding costly universe checks

This is #473 with no merge errors.

@yforster I think you have left some <<<<<< after the merge.

Oops. It's in the test-suite, so I didn't notice on make. No fixed.


Update .net sdk to match corresponding swagger spec (already merged)

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[ ] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ryanvog,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci  add to whitelist

@azuresdkci test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ryanvog,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci add to whitelist

@azuresdkci test this please

@ryanvog can you add link to the swagger spec PR

@azuresdkci add to whitelist

@shahabhijeet, here's the link to the PR for the REST API: https://github.com/Azure/azure-rest-api-specs/pull/1067

Description added.

@ryanvog added an issue to track adding of test coverage https://github.com/Azure/azure-sdk-for-net/issues/3201


Add Hyperdrive CRUD support

Add support for managing Hyperdrive configs
Description
Resolves https://github.com/cloudflare/cloudflare-go/issues/1491
Mainly wrote by copying the existing queue.go
Has your change been tested?

Tested ListHyperdriveConfigs manually
Added tests

Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

thanks @carlos-alberto 🙇


Notify LocalSlamResults subscription ends.

RFC=0002
PAIR=cschuet

@wally-the-cartographer merge

Merge requested by authorized user gaschler. Merge queue now has a length of 1.


Impressive work

Impressive work, bravo and thanks for sharing!
Do you plan to provide typescript declarations for your web package ?
I'm considering integrating your web package, at least some components, into a larger upcoming web app

I haven't much experience with TS so I wasn't planning on it, but I'm more than happy to merge a PR for this?

I haven't much experience with TS so I wasn't planning on it, but I'm more than happy to merge a PR for this?

Closing this as I’m not intending to add TS declaration but open to PRs


Myriad-Issue-60 Added ability to launch JHS and other services that f…

…it under Myriad umbrella from MyriadScheduler using default Mesos slave executor
Myriad-Issue-60 review changes
Disable automatic service startup at MyriadStartup, as upon Myriad restart it may try to start multiple times. Recovery of those tasks will be done as part of Myriad HA.
Added binary distribution for JHS. It is using same properties from yml file as NM, since source code for both should be same
Updating licensing info to Apache 2.0 License for newly created files
SchedulerState refactoring, naming changes, introduce limit on number of instances
of a particular service instances that can run at the same time.
Changed behavior with ports. New behavior: if ports are specified in the configuration they will be used irrespective of anything. If ports are not specified in configuration they will be selected form list of ports from Mesos offer.
In both cases following properties will be set:
"myriad.mapreduce.jobhistory.admin.address",
"myriad.mapreduce.jobhistory.address",
"myriad.mapreduce.jobhistory.webapp.address"
So they can be used in configuration files. E.g:

mapreduce.jobhistory.admin.address
${myriad.mapreduce.jobhistory.admin.address}

mapreduce.jobhistory.address
${myriad.mapreduce.jobhistory.address}

mapreduce.jobhistory.webapp.address
${myriad.mapreduce.jobhistory.webapp.address}

In case of random ports JHS web app address  has to be known by clients in order to successfully start/finish job.
Fixing issue with resources for NM reporting as 0 and allowing submit a task that requires more resources then mess offer
Refactoring to abstract out ServiceResourceProfile and ExtendedProfile that will have NMProfile included in addition to service resources information. It helps to still keep all the tasks in one place.
Renamed to more meaningful names - such as Service(s), Refactoring command line generation for reuse between NM and others, Created interfacePorts to abstract out ports, rather then tagging along NMPorts class to other services, added tests for CommandLineGeneration
Fixes to unit test
MYRIAD-121  Reworked Service configuration, commands, etc. to rely just on the configuration settings to start the service
Example of configuration for JHS would be:
services:
jobhistory:
jvmMaxMemoryMB: 64
cpus: 0.5
ports:
myriad.mapreduce.jobhistory.admin.address: 10033
myriad.mapreduce.jobhistory.address: 10020
myriad.mapreduce.jobhistory.webapp.address: 19888
envSettings: -Dcluster.name.prefix=/mycluster
taskName: jobhistory
serviceOptsName: HADOOP_JOB_HISTORYSERVER_OPTS
command: $YARN_HOME/bin/mapred historyserver
maxInstances: 1
Addressed review comments
Addressing review comments, Adding handling exception in ResourceOffersEventHandler while TaskInfo is created to make sure thread is not stopped because of some rogue tasks
Adding DEFAULT_PORT_NUMBER and setting it to 0

Merged to apache/incubator-myriad.
https://github.com/apache/incubator-myriad/commit/465738167df60f9a8ae1a258d5e87e5a74ca05d5
https://github.com/apache/incubator-myriad/commit/1c3a7c070f197ad87136a22c91646bf5223a2502


Cannot run with Rancher Server

See rancher/rancher#4433

Renaming the downloaded executable from /usr/local/bin/docker-machine-driver-Vultr to /usr/local/bin/docker-machine-driver-vultr did the trick.

@jmatsushita Can't reproduce any file naming problems with the release. The distributed binary is named docker-machine-driver-vultr (all lowercase). How did you get the uppercase letter in yours?

Hey @janeczku I've pasted the Github release tarball link into the Rancher Server driver install. So maybe it's some weird untaring side effect from Rancher Server...  #4433

I just tried with Rancher Server v1.0.1 and the driver gets registered successfully. In any case this is probably an issue with Rancher rather than the driver. Thanks for pointing it out to me though!


LTC balance and History not showing

My history and balance stopped updating recently. I did a full resync and deleted the app twice and now it shows no history and no balance.(created from Zendesk ticket #3186) gz#3186

Agent comment from Jim Flanagan in Zendesk ticket #3186:Our Devs have found the issue and are working on it. Please be patient and thank you for bringing this issue to our attention. We appreciate your support and always know that your Litecoin is safe on the blockchain and why it is so important to keep your seed phrases in a safe place as your coins are not on the actual wallet or any wallet for that matter but safe and sound on the blockchain.
Jim Flanagan
Litewallet Support
°°°

Resolved and action ongoing: 🕵🏽♀[Post Mortem] Critical: Switchover masked bigger issues #46


It can't properly infer the type of the query entries in Bevy game engine

so when I do
fn timer_update(time: Res<Time>, mut timer: Query<&mut Timer>) {
    for mut t in timer.iter_mut() {
        t.tick(time.delta());
    }
}

I expect t to be &mut Timer (and receive proper completions), but it determines t to be <QueryIter<&mut Timer, ()> as IntoIterator>::Item
link to Bevy game engine repo: https://github.com/bevyengine/bevy
link to that .iter_mut() : https://github.com/bevyengine/bevy/blob/90586a4c461cde86b8a0e08f0770894e7cf30862/crates/bevy_ecs/src/system/query.rs#L186
and seems like it is everywhere in the Bevy codebase (didn't check that tho).
It makes development harder&slower because I rely on completions very much.

Are you on the latest rust-analyzer version? Inference for queries works fine for me.

It is updated and it's version is v0.2.702

not sure if it is important, but I'm on Windows 10.

this is from official contributors.rs example

Iirc bevy implements a bunch of things on tuples via a proc-macro, can you check whether your proc-macro server is crashing? On that note what rustc version are you on?

I've just done a rustup update and the problem still remains.
also I know that there would be a notification about proc-macro crash if it occured.

Mmh then I'm not sure what's wrong here, do you have a repo with this issue or is it possible for you to create minimal reproduction? I assume the snippet you posted should trigger this behaviour already but it does not for me 😕

I see this issue in relevant Bevy example code, so I don't think it is something to do with the code itself (I mean that's ok)

Right sorry you said it happens in the example.
So there I can actually reproduce it.

Nope I've spoken too soon, it resolves as well now.

yep, I see. so what steps do you recommend to track down the reasons (and what possible fixes might be)?

I've finally find out what was causing this.
the reason is that proc-macros were turned off in rust-analyzer settings, I've turned them off a couple of months before because it was crashing with nightly Rust. now I've turned it on and it works as expected, I do not understand why proc-macros are needed here tho, but anyway.
also I'm glad that I didn't reinstall rust-analyzer (it would fix the problem, but we would not find the reason)

Ah sorry, I should've asked to check that setting as well, my suspicion was that its proc-macro related(hence why I asked for server crashes) because bevy uses proc macros to implement traits on tuples.

is there anyway to enable this proc-macro feature in rustic-mode for emacs?

https://emacs-lsp.github.io/lsp-mode/page/lsp-rust-analyzer/#lsp-rust-analyzer-experimental-proc-attr-macros if your lsp-mode is recent enough.

awesome, thank you! i was looking all over rustic for it, when it was an lsp-rust specific setting 🤦


ci(monorepo): run app tests when app-shell-odd changes

Overview
Oops my bad I noticed app tests arent running when there are code changes in app-shell-odd
Changelog

Run app checks when app-shell-odd changes

Risk assessment
Low

@sfoster1 good call — ill make a separate action

i think we might use even more CI resources by creating a new workflow. if we create a new workflow, we will do the following anytime the app, app shell odd, components, shared data, or discovery client are changed:

install dependencies (make setup-js)
run unit tests for app-shell-odd
build the app for the ODD

let's consider the two situations when someone modifies code in the app directory (which will be way more common than changing code in app-shell-odd):

we create a new workflow for app-shell-odd

the new workflow would run in addition to the current full stack app test stack. That is one extra make setup (expensive), and then testing the app shell odd (cheap), and then building a linux arm 64 dist (expensive)

we do what I have currently

we do the setup which would already be happening anyways, we run tests for the app-shell-odd (cheap), we build a linux arm 64 dist (expensive)
so in the more common scenario of changing app, component, or shared data code, we spend less resources.


[HUDI-5503]Optimize flink table factory option check

Change Logs
1.remove pk and pre-combine field check for source and append mode sink
2.fallback to table config if pk or pre-combine field not set.
Impact
1.In flink sql, no need to set pk and pre-combine field when reading hudi or writing in append mode
2.If pk or pre-combine field not set in option, fallback to table config if possible
Risk level (write none, low medium or high below)
low
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure

@hudi-bot run azure

I see there is a key-less support for Spark here: #7622, we can do similar changes in Flink side, so that in append mode, there is no need to define primary keys.
You can do similar work in this patch actually, but i guess the change in SimpleKeyGenerator is a blocker, we can merge this patch after #7622 is merged.

ok, so lets wait for #7622 and do similar change for append only write.

In #7295 , we decide to fix the hoodie hive table by merging the table options for flink read/write path, which has some overlap with this PR, just a kind reminder.

Thanks for the contribution, I have reviewed and applied a patch:
HUDI-5503.patch.zip, please rebase with latest master code and then apply the path with cmd:
git apply xxx.patch

applied

Thanks for the patch, I applied with small changes: separate sanity check for source and sink(when create source only check pk if stream read mor table) and made corresponding change to TestHoodieTableFactory.java