Added Python style guidelines

just a copy paste from normal standards document, except for the weird 160 column exemption

This comment isn't specific to this PR, but I think it would useful for the standards that we reference to be linked to.

I don't disagree, we also reference some PSR for PHP

Yep. That's why I said it wasn't specific to this PR. You can link them all if you want, or just the ones in this PR and I'll fill in the remainder later.


fix: plural items property in autocomplete data query

Problem
missing plural items in autocomplete data fetch
Solution
add 's'
Links
Ticket

GitHub issue:
Other links
Verification
Manual tests

Automated tests

[x] Unit tests added/updated
[ ] E2E tests added/updated
[ ] N/A - (provide a reason)
[ ] deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #1047 (259519c) into main (ac7836a) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   93.91%   93.91%
=======================================
  Files         124      124
  Lines        5781     5781
  Branches     1745     1745
=======================================
  Hits         5429     5429
  Misses        334      334
  Partials       18       18

Impacted Files
Coverage Δ

packages/codegen-ui-react/lib/utils/graphql.ts
94.59% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7836a...259519c. Read the comment docs.


WebJobs schedule should support UTC

This isn't documented in the wiki but I believe the code is using the local time of the server when scheduling. I could see possible issues if you had multiple instances of a job and if they all weren't in the same region it could cause problems. Also if you switch regions you'd have to switch the schedules.
If it were me I'd have defaulted to UTC since it's safe by default. However, in order to not break everyone, it might be nice to provide an override: schedule_is_utc.

The time on all azure machines is in UTC regardless of the region unless you manually change it

Oh, excellent, nevermind then!


Azure | KIC and Kong | Chokes Under Load

KIC Version:  0.7.1
Kong CE or EE: Kong CE v2.0.4
K8S Version: 1.7.11
Docker CE Version: 19.03.11
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.6", GitCommit:"d32e40e20d167e103faf894261614c5b45c44198", GitTreeState:"clean", BuildDate:"2020-05-20T13:16:24Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.11", GitCommit:"ea5f00d93211b7c80247bf607cfa422ad6fb5347", GitTreeState:"clean", BuildDate:"2020-08-13T15:11:47Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Environment

Cloud provider or hardware configuration:  Azure (Standard_D16s_v3)
OS:  CentOS 7.8
Kernel:  3.10.0-1127.19.1.el7.x86_64
Install tools:  Rancher UI (v2.4.4)
Others:

CNI:  Calico (v3.13.4)
Kong DataStore:  DB (Azure PostgreSQL)
# of Workers:  2
Load Test Tool:  vegeta
Relevant Tunables in Kong's ConfigMap:
- KONG_PROXY_LISTEN: <IP_ADDRESS>:9000 reuseport, <IP_ADDRESS>:9443 ssl reuseport
- Under kong.conf, nginx_main_worker_rlimit_nofile = 262144
Ingress Type - Custom (segregated namespace).
Workload Controller - Deployment
POD Limits - None.
Total Number of Objects (Routes/Services/Upstreams/Plugins/Consumers) - 200 max.

What happened

Load tests to the external backend, via the Kong Proxy NodePort, generate a ton of 5XX status codes (502/504) when running 5000 rps for 3 minutes. constantly.  The error logs are inconsistent (which could be due to the load, choking resources, not writing to the error.log properly).  These are the errors I've been able to trap, under different tests.

[error] 33#0: in lua semaphore gc wait queue is not empty while the semaphore 00007F54212A1CB8 is being destroyed
[error] 33#0: *3426060 upstream prematurely closed connection while reading response header from upstream
[crit] 39#0: *240711 connect() to XXXXXXX:443 failed (99: Address not available) while connecting to upstream
[error] 43#0: *10030416 peer closed connection in SSL handshake (104: Connection reset by peer) while SSL handshaking to upstream
[error] 33#0: *6478079 [lua] connector.lua:353: unable to clean expired rows from PostgreSQL database (receive_message: failed to get type: timeout), context: ngx.timer

Load tests to the external backend, bypassing the k8s subsystem, succeed under the same condition (a small number of 502s are generated, but that is expected).  These tests are run from the OS directly, on the worker nodes.

Expected behavior
Load tests to the external backend, via the Kong Proxy NodePort, should ideally generate the same results.
Steps To Reproduce

Spawn 2 Azure Standard_D16s_v3 CentOS 7 Instances.
Create a k8s cluster via the Rancher UI, and assign both instances to it.  I've assigned a separate one for controlplace/etcd, but that should not be a problem.
Deploy Kong on both instances.
Create the routes/services/upstream/plugins in another namespace.
Run the load tests.

Extra Information
Some reference to context; we initially started seeing the 502s (POST being replaced with GET), backed by the infamous "upstream prematurely closed connection" error msg, in a Kong cluster (Prod) a month or so ago, when a customer complained that they were getting 502s.  On further enquiry, we identified out that the customer was running jobs that were generating 120000 rps in a timeframe of 15 minutes with 1-2 G total upload size (4 times a day, 3-4 days a week).  When this was happening, the Kong instances were choking, affecting comms with all pods directing traffic through Kong (timeouts etc.).  Moreover, this customer is new, with none of the other customers generating this load.  Therefore, no fact check to refer to.  Rate limiting has been suggested, but the customer is clear that this load isn't really great and should be easily manageable.  Considering the service they were communicating to points to an external backend via Kong, we rebuilt the microservice to point to the external backend directly, and so far, no complaints.
Therefore, a test environment was created to see how far Kong could go with different load test parameters, and this is where we started identifying issues.  Deployments vs Daemonsets, no avail.  Changing vm sizes, from Standard_D16s_v3 all the way to  Standard_F32s_v2, no avail.  All exercises stump me, especially considering Kong should perform very well, under this environment.
I'm currently grasping at straws, so your help would be highly appreciated, pointing me in the right direction.  I have the test environment ready.  Thank you.

If you can upgrade to 2.13 (or 2.1.4 if available (being release as I type this out)), that would help. I understand that this in production so it might not be feasible to alleviate the problem quickly.
Could you share the number of workers of nginx you have?
@dndx @bungle @javierguerragiraldez might have more insights in the error messages that kong is reporting.

Thanks for getting back @hbagdi.  I've gone ahead and upgraded Kong CE to 2.1.4.  The number of workers is 16, currently, since the vm size is Standard_D16s_v3.  The vm size can be changed, if the need arises.

Hello @hbagdi:  My apologies for the delay in getting back.

After running multiple load tests with different instance sizes to identify what works best, this is what I settled for;

Sizes: Standard_F16s_v2 (16 vCPUs / 32 vMem) for both k8s workers, running the KIC/kong pods.
Kong Relevant Tunable: nginx_main_worker_rlimit_nofile = 1048576
Load Test Run: 5000 rps.

Flow:  Vegeta Client -> Kong Data Container (Node Port / https) -> External Service (https).
It has been observed that the k8s workers can handle a combined load of 10000 rps (either 10000 rps to a single worker, or a combination of rps to both workers not exceeding 10000 rps, in total).  If the # of rps goes past 10000, then multiple 502/504 are observed, in addition to "connection reset by peer" errors generated from the client.  Based on the instance size and the tunable, each node should be able to easily support more than 10000 rps.
I do feel the next step would be to look at either changing the CNI or enforcing a set of tcp-related kernel tunables.  I will report back once I compare performances against other CNIs, supported by Rancher2.
In the interim, do you have any idea where the limitation would be?

is there update?


Up to date?

I compiled and installed and I get the panel, but I'm seeing the below with no changes.  I've confirmed analytics beacons are going out.

Any idea on a starting point for this problem?

Can you confirm that the tracking beacon URLs start with either http://www.google-analytics.com/collect? or http://www.google-analytics.com/__utm.gif?

Ah, strange, it's sending to http://stats.g.doubleclick.net/__utm.gif  Any idea why that might be?

It looks like enabling enabled the "Remarketing with Google Analytics" feature causes requests to go to stats.g.doubleclick.net rather than www.google-analytics.com. More info can be found on the Google Analytics developer documentation.
Thanks for the report.

If you checkout branch 005-allow-doubleclick-tracking and rebuild the extension you should now see tracking beacons.
I've tested on a few live sites and it seems to work as expected. If this fixes your issue I'll merge it in.

Not seeing anything, but I just thought to mention these beacons are coming from Flash, will this be captured or are they only pulled from javascript broadcasts?

If the request appears in the Network tab of Chrome devtools then the extension should pick up the request and show it. Is the site available to look at online? If not, could add the full tracking beacon URL (anonymise any sensitive data) to this issue and I'll try running the test suite against it.

Something else just occurred to me; is the beacon a GET or is flash POSTing it?

Here's an example.
http://player.piksel.com/p/e190kf2d
I'm seeing the beacons in Charles, but not in the network tab.  This is probably not related to your code.

It was my flash version (I was using the debug version).  It works!  Thanks so much!

Oh, and it was GET.  Thanks again, this one's resolved (at least on my end)!

Great!


outputPath as subfolder

Thanks for great toolkit!
If I use subfolder as an output path outputPath: 'assets/built' it breaks the dynamic import functionality because of the wrong variable name.
/* wpack.io publicPath */
window.__wpackIotestassets/built='https://www.wp.local/wp-content/themes/test/assets/built/';

window["__wpackIo".concat("test").concat("assets/built")]

I think appname and outputPath should be escaped/sanitized.
For example, WP has sanitize_key() function for this.

Hello,
Thank you for pointing this out. Do you mind sending in a PR for this?


add maxvit main model

Signed-off-by: xujinling<EMAIL_ADDRESS>

Codecov Report

Merging #1552 (b8cea85) into main (a11e363) will increase coverage by 0.15%.
The diff coverage is 80.35%.

:exclamation: Current head b8cea85 differs from pull request most recent head eda7666. Consider uploading reports for the commit eda7666 to get more accurate results

@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
+ Coverage   70.03%   70.18%   +0.15%
==========================================
  Files         353      358       +5
  Lines       20551    20663     +112
  Branches     3301     3318      +17
==========================================
+ Hits        14393    14503     +110
+ Misses       5248     5245       -3
- Partials      910      915       +5

Impacted Files
Coverage Δ

towhee/models/max_vit/max_vit.py
64.51% <64.51%> (ø)

towhee/models/max_vit/__init__.py
100.00% <100.00%> (ø)

towhee/models/max_vit/configs.py
100.00% <100.00%> (ø)

towhee/models/max_vit/max_vit_block.py
100.00% <100.00%> (ø)

towhee/models/max_vit/max_vit_stage.py
100.00% <100.00%> (ø)

towhee/engine/operator_runner/runner_base.py
92.16% <0.00%> (+0.60%)
:arrow_up:

towhee/dataframe/dataframe.py
74.15% <0.00%> (+1.04%)
:arrow_up:

towhee/engine/operator_context.py
84.78% <0.00%> (+2.17%)
:arrow_up:

towhee/models/layers/mbconv.py
86.95% <0.00%> (+4.34%)
:arrow_up:

towhee/engine/graph_context.py
90.76% <0.00%> (+4.61%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11e363...eda7666. Read the comment docs.

/lgtm

/lgtm
/approve


ci: :construction_worker: changed action step name

changed action step name

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make a small POC with CUDA

Learn the basics of how CUDA works by implementing some examples.
Initial resource: https://www.notamonadtutorial.com/cuda-from-scratch/

we went for Metal, we might revisit this later


v1.2 findfriend

Update findfriend command keyword and message usage
fixes #72

Codecov Report

Merging #81 (f989744) into master (844e647) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/FindCommand.java
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844e647...f989744. Read the comment docs.


Add OCaml example for brainfuck

Hey! This is a good first start! But the rules say not to switch algorithm or paradigm even to be more idiomatic.
Since ocaml supports mutable struct and values, I'd like the example to use that too.
Feel free to make that change if you'd like or I can make it later in.
Thanks and good start!

Since ocaml supports mutable struct and values, I'd like the example to use that too.

Thanks for having a look, I'll make this change :)

I kept the functional example from the last commit & added a new example using imperative features of OCaml
Can we keep both examples? if no then let me know I'll remove the example using functional paradigm.
Thanks :)

Ok this looks pretty good! Yes we can keep both.

This looks like it's failing because you aren't installing/setting up ocaml correctly: /bin/sh: 1: ocamlc: not found

This looks like it's failing because you aren't installing/setting up ocaml correctly: /bin/sh: 1: ocamlc: not found

I'll fix this tomorrow

Nice! Looks good!


Fixed backends.oracle.test_operations.

Using unittest.TestCase doesn't work properly when we perform db queries. Moreover introspection is extremely slow on Oracle without limiting models to a "backends" app.
Follow up to 8bcca47e8356521f52f0738d9633befd53007cae.
Before:

test_sql_flush_sequences (backends.oracle.test_operations.OperationsTests) (761.919s)
test_sql_flush_sequences_allow_cascade (backends.oracle.test_operations.OperationsTests) (780.015s)

after:
TBC

buildbot, test on oracle.


fix(button): locked in disabled state

Describe pull-request
Possible fix for the forever-lasting disabled state of the button.
Solving issue
When the button is set statically to a disabled state on the initial load, it seems to remain in it.
connectedCallback is run only once, on the initial load so the component is not aware of the change of "disabled" prop change.
I have tried to use Watch decorator to fix it - that one does not run on initial load, but runs on prop change.
How to test
Not sure if is this testable without a release, possible with a link or pack method as this seems to be related to frameworks.
Additional context
I am open to any other suggestion or improvement of this PR. Feel free to push commits to it or if you feel like testing this together via linking.

@theJohnnyMe do you want to update the description of this one?

@theJohnnyMe do you want to update the description of this one?

Updated! ;)


Error on Custom Properties in oklch()

We have a valid CSS code:
.root {
  @supports (color: oklch(0% 0 0)) {
    background-color: oklch(var(--oklch-primary) / var(--alpha-bg));
  }
}

Of course, var() can’t be supported by stylelint-gamut. I suggest ignoring these rules.
But now plugin throw an error:
TypeError: undefined not allowed for Lightness in oklch()
    at /home/ai/Dev/evilmartians.com/src/components/Button/Button.module.css:89:5

Well, I guess it's fixed now.


fix: minor spelling and trailing whitespace fixes in README.md

changes:

few minor spelling corrections I found in the README.md.
removed some trailing white space as well
Feel free to close or make your own changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


Hapoalim Error Evaluation failed: TypeError: Failed to fetch

Hi
I get an error from Poalim importer

Thanks

Seems like Israeli Bank Scraper release a fix for that on 30/12
https://github.com/eshaham/israeli-bank-scrapers/issues/640
Is there a way to release a new version of Caspion that will use that latest israeli bank scrapers version ?

Created a PR for this, once this is merge will create a new release

@idanco1 try updating to v0.0.13-beta

Thank you
@brafdlog
Where do i find the exe setup file ?

@idanco1 You can update from your current installation, in the bottom left corner.
Also, you can download the latest version from our website: https://brafdlog.github.io/caspion/ (@brafdlog please add this URL to the repository "About" section")
And you can find the release here: https://github.com/brafdlog/caspion/releases/latest

@baruchiro
Thanks
I might be missing something , but https://github.com/brafdlog/caspion/releases/latest does not include exe files like previous versions
and update from Caspion returns "error during update"

Yes, we didn't publish the latest version correctly, I'm fixing it right now.
I have a plan to automate this process: #297

@idanco1 Try now please

Thanks ! @baruchiro
All working now


Someone else generated the same private seed phrase with "sign up with Deso seed"

I have a couple of alt accounts and anonymous accounts in my DeSo identity on my mobile phone. 2 days ago i noticed that one of my anonymous accounts became active 43 days ago as the account @mayadoesart (the daughter of @VindictiveTJ according to the profile info).
It looks like she generated the same private seed phrase as my anonymous account. I'm so lucky I didn't ever used this account to hold my DeSo or NFT's in it, and no one was harmed by this event.

If what you're saying is true, I want to go gambling with you. It's close to impossible to generate the same seed as someone else.

The arrogance to just close this without asking any more information is truly astounding.
We all know that there are no bugs or issues in the DeSo codebase, right? 🤦♂

@iPaulPro the issue title suggests a critical vulnerability in identity without sufficient explanation and ability to reproduce the issue, hence I decided to close it. It's also coming from a new GH account that was created two days ago.
But Paul you're right, @Japz0r is there any more information that you could give us about this issue, and why do you suspect it's seed generation that's at fault?

I had a couple of anonymous accounts in my deso identity (also all
generated with "sign up with seed" on deso) i created these somewhere in
between august-October 2021 and didn't touched them. Those accounts where
created on my Android phone. One of those accounts became active 44 days
ago. As someone else her account. I noticed this a couple days back.
The man who created the account for his daughter has created 3 accounts in
total. He has written down all 3 of the seed phrases (all 3 generated with
"sign up with seed" on deso). After being notified by me of this situation
he checked his seed phrases. He found out the seed phrase he stored for his
daughter doesn't give him accès to the specific account. It's like a ghost
account he says.
You can find his answers to my post on DeSo here:
https://diamondapp.com/posts/b0584ef0be4708b74207cccb375864b5c3b21fedb267aa0bb82897d718de989a
I'm just a normal user on deso and i thought this was to big to not be
mentioned. Since i didn't get a serious reaction elsewhere i created this
GitHub account.
If you need more information you can contact me. Will provide any
information you want.
Kind regards,
Jasper Westra
Op za 4 jun. 2022 17:42 schreef Piotr Nojszewski @.***>:

@iPaulPro https://github.com/iPaulPro the issue title suggests a
critical vulnerability in identity without sufficient explanation and
ability to reproduce the issue, hence I decided to close it. It's also
coming from a new GH account that was created two days ago.
But Paul you're right, @Japz0r https://github.com/Japz0r is there any
more information that you could give us about this issue, and why do you
suspect it's seed generation that's at fault?
—
Reply to this email directly, view it on GitHub
https://github.com/deso-protocol/identity/issues/143#issuecomment-1146637614,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZOMRG5IWFV5BEQI2K4LX6LVNN2NBANCNFSM5XUVI42Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


New package: ProjectMakerFR.DashboardPM version 1.0.1

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

The installer appears to have completed, but the package manager believes it's still ongoing.


consider supporting Django 4.0 😬

Seems to do alright with Django 4.0

Django 4.0 is EoL and no longer receives even security updates. You'd be much better off updating to Django 4.2 (at the least).


Use Existing storage class as backend (cloud provider disks)

Description

I recently took a look on OpenEBS, I think it is very good! I would like to be able to create a StoratePool for Jiva based on cloud provider disks and not having to mount the disks directly to the VMs or to use a host path.
Why? Because first is it not always easy to mount the disks to managed cloud k8s clusters. second, I don't want to have to create VMs with Big disks that might not be used efficiently when mounters directly to the VM.
Context
Having to mount disks to the VMs is not that handful when the cluster are ephemeral or when we have lot of clusters. therefore it would be nice that we could the the same as the NFS provisioner that back all the storage into a specified Storage class.
like so:
#NFS provisionner helm values
      - storageClass:
          name: default
          defaultClass: true
      - persistence:
          enabled: true
          storageClass: managed-premium
          size: 1Ti

Possible Solution
This would look like:
apiVersion: openebs.io/v1alpha1
kind: StoragePool
metadata:
    name: azure-disks-bakend
    type: storage-class
spec:
    config:
       storageClass: managed-premium #some storage class that cloud provider define when you create a k8s cluster

PS: I apologize if this already available, I just haven't found it in the doc

nobody has thoughts on this ?


jax.ops has no attribute 'index_add'

warning!warning!warning!
the  latest version of jax has  removed index_update and index_add,
which caused the code in alphafold2/alphafold2/model/modules.py should be edited
the code in line 1725
 msa_activations = jax.ops.index_add(msa_activations, 0,prev_msa_first_row)
should be changed!!!!!
i get this message from the explain of the author of jax:
https://github.com/google/jax/issues/11706

Thanks for reporting this issue. In general we advise pinning to the version of JAX defined in the requirements.txt, rather than installing any newer packages. This is because we do not check that newer version of JAX produce the same level of accuracy.
Regardless, these ops are not in the latest versions of the model.

Hi, thanks for reporting this issue. In general we advise pinning to the version of JAX defined in the requirements.txt, rather than installing any newer packages. This is because we do not check that newer version of JAX produce the same level of accuracy.
In any case, these ops are not in the newest versions of the models.


Attach model on pipeline creation bug

Error on attach model on creating pipeline which causes no preprocessing on task’s assets. Annotation types box and text are not working.

Duplicate: https://github.com/epam/badgerdoc/issues/147


Rename event_stack to segment_stack on ActiveStorageSubscriber

I believe that 0f670cca introduced an error on ActiveStorageSubscriber. I'm getting the following error after I updated from version 6.2.0 to 6.4.0.
ERROR : NameError: undefined local variable or method 'event_stack' for #<NewRelic::Agent::Instrumentation::ActiveStorageSubscriber:0x0000561d177276f0>

Hi @meacuna. We appreciate you fixing this, but we are already aware of the issue and have fixed it in our development branch, otherwise we'd gladly accept this PR. We will be pushing out the fix soon. In the meantime, you can use version 6.3.0 of the agent.

That's great, thanks for the information.

Good to know the fix is coming.  I just got hit by this.


Make test kitchen tests pass

I did some work on the icinga2 cookbook to get the tests passing in test kitchen. It looks like the lib package is no longer needed as I got messages saying that it is obsoleted by the bin package. Updated the version numbers and I had to change the order of the package installs to get it to work on debian and later Ubuntu versions.
Tests should pass now in test kitchen.

I was using the .kitchen.yml file and not the .kitchen.dokken.yml file


[2.4] update go to 1.18

Signed-off-by: Anxhela<EMAIL_ADDRESS>Related Issue:  stolostron/backlog#24212
Description of changes

/test all


Basic album persisting

This PR adds basic album recovery. Here's how it works:

On every sync, we persist all the albums to a flat file that is kept outside the normal database. It maps album names to a list of artwork IDs.
When the app is first launched, after the first sync is completed and we can rely on the local database having all the artworks, we re-create the albums based on the persisted data.

Things that worry me and I want to look into a bit more:

[ ] Artworks sometimes have slugs like-this-slug and sometimes have IDs like 51815f4c250db9464000024d. We depend on these being stable across sessions (ie: you log out and log back in, and the IDs should still match up).

Once merged:

[ ] Deploy a beta of Folio and ask Jessica/someone to help test.
[ ] Coordinate with them also to create clear communications to partners on what this is and how it'll save their albums.

Albums still won't sync between devices, but this should still improve the situation for partners when, for example, they get logged out due to changing their password.

          2 Warnings

:warning:
PR is classed as Work in Progress

:warning:
No CHANGELOG changes made

  Generated by :no_entry_sign: Danger

Thanks Brian!


Error in grid.Call.graphics

Project Robyn
Describe issue
Getting Error in grid.Call.graphics(C_text, as.graphicsAnnot(x$label), x$x, x$y,  :    invalid font type Calls: <Anonymous> ... drawDetails -> drawDetails.text -> grid.Call.graphics
when running Robyn code for Demo.R via Python subprocess.call.
Getting issue after >> Running feature engineering... step.
I am completely new to R so my apologies in advance for anything trivial.
Environment & Robyn version
‘3.9.0’
R version 4.3.0 (2023-04-21)
Platform: x86_64-apple-darwin20 (64-bit)
Running under: macOS Ventura 13.3.1
I had this few months back as well and tried some steps on SO which ended up messing up the R env and Robyn code stopped working then had to start from scratch.

Ok, this helped

install.packages("showtext")
library(showtext)
font_add(family = "Arial", regular = "Arial.ttf") ## here is the path to the font to add.
showtext.auto()


gltfio::DependencyGraph::checkReadiness(filament::MaterialInstance*) crash

Above is the thread stack and info which crashed when I try to createAssetFromBinary. Is there clue the crash happen?

Can you show more of the stack trace? My hunch is it's this assert being triggered. @prideout probably has more thoughts. If you're able to upload the glTF file you're attempting to load, that would be helpful.

@starccode can you provide repro steps?

no activity in a month, closing.

The stack trace as following:

It crashed because of bad access of NULL value

the cash is caused by wrong texture data


Spoortakmodel

Added a mapping and inspection classes to work with spoortak model version 3 up to and including version 17
Note the spoortak models data has not yet been included. We are verifying if they can be distributed or not trough github.
Thus the integration tests will fail due to missing data.

It might be preferable to host the data files in some other location,...
Yeah, I've already created an issue for this #23 so we can discuss what we want to do with static data files goin forward.
for there are already 2 files that could not be added due to their sizes (currently they are also not needed)


Allow Ruuter to make requests to other localhost services binded with ports

AS A Developer
I WANT TO make requests via Ruuter to different localhost services running on different ports
SO THAT I could use my usual development environment
Acceptance Criteria

[ ] Make sure to have http://localhost: as a running (not Ruuter) service
[ ] Create a simple Ruuter DSL to make a GET request to http://localhost:
[ ] Use this Ruuter DSL service via browser
[ ] Response of http://localhost: is provided by Ruuter

Step 1 - update Ruuter's docker-compose.yml
Add extra_hosts under services.ruuter
docker-compose.yml should look like this:
version: '3.9'
services:
  ruuter:
    container_name: ruuter
    build:
      context: .
    volumes:
      - ./DSL:/DSL
    ports:
      - 8080:8080
    networks:
      - ruuter
    extra_hosts:
      - "host.docker.internal:host-gateway"

networks:
  ruuter:
    driver: bridge

Step 2 - change localhost URL's in Ruuter DSLs
When using localhost:<port> URLs in Ruuter DSLs to use other than Ruuter itself, replace http://localhost:<port> with http://host.docker.internal:<port>
A working example /DSL/GET/mocks/localhost.yml looks like
step_1:
  call: http.get
  args:
    url: http://host.docker.internal:8085
  result: nginx

step_2:
  return: ${nginx.response}

Closed based on the comment added, no development was needed.


New version: Dandanplay.Dandanplay version 12.0.2

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Domain

/azp run


Deprecate FindBugs plugin

Issue: #6652.

I documented the deprecations in the plugins' chapters in the user guide.
@oehme PTAL!


Refactor ReplCalculator

[ ] share common code between scala 2.10 / 2.11

language specific things should be minimized
what are the necessary differences in ReplCalculator? can't it be everything common?

[ ] think about refactoring and simplification
[ ] tests ?

@andypetrella


Add the hard limit of 50GB on LFS files

hmm the doc wasn't built for some reason: https://huggingface.co/docs/huggingface_hub/main/en/guides/upload#tips-and-tricks-for-large-uploads

Yes I'm working on fixing the CI (both docs and some tests are broken recently :grimacing:). But not related to this PR specifically.


Option to change Most Played to Most Played Recently

I'm hoping it would be possible to add an option to change the Most Played game to show the Most Played Recently instead.
The game I've played the most is not a game I'm playing these days, and it's not a play time I'm likely to beat any time soon.
It would be more useful for me to see the game I've played the most during the last week, month or even year instead. (Different options for time inteval would be even more welcome here).

Or maybe an option for Last Month-->Last Year-->All time

done in v2.0.0


[Feature] Adding Nerdfonts to the Terminal

General

[X] My feature does not exist in the latest version of Nexterm.
[X] I have checked that my feature has not been suggested by anyone else.

Your Idea
I would love to be able to use my terminals with fonts that support nerd fonts so that my ohmyposh and starship shells look as intended in the terminal.

I'll second this and just say custom fonts would be nice

oh got please add this feature

I'll second this, NexTerm + Starship + Fish Shell


Added section on preview card

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/messaging-extensions/how-to/link-unfurling.md
92
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 5c66cc2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/messaging-extensions/how-to/link-unfurling.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Replace Jackson with DSL-JSON

Benchmarking shows that serializing payloads with dsl-json is x2.4 faster and requires -86% less allocations.
DSL-JSON is a nice library which focuses on fast and garbage free JSON serialization. It only has a small byte[] buffer, which is reused and otherwise directly writes into a OutputStream, so there are no temporary objects created. It also has a mode where it can automatically serialize annotated POJOs. I opted for a more manual approach to have more control about the resulting JSON (see hasContent() checks and explicitly serializing TransactionId with UUIDConverter.serialize(id.getMostSignificantBits(), id.getLeastSignificantBits(), jw);)
My recent additions to dsl-json https://github.com/ngs-doo/dsl-json/pull/48 and https://github.com/ngs-doo/dsl-json/pull/49 make it possible to also serialize StringBuilders and transaction ids in the UUID format in a garbage free way. The only thing which requires allocations now is creating a ISO date formatted string for the Transaction.timestamp and creating Map.entrySet().iterator()s for iterating over custom Context.tags. I'm not quite sure why JIT can't replace the iterator heap allocations with stack allocations, but maybe JMH's GC profiler also reports stack allocations in gc.alloc.rate.norm. Regarding the timestamp serialization, there is an open issue about adding support for epoch timestamps: https://github.com/elastic/apm-server/issues/850. That would make the JSON serialization essentially completely garbage free.
As an additional benefit, the total size of the agent jar drops from 2.8 to 1.2 mb as the replaced Jackson library is much heavier.
This PR is currently blocked until dsl-json 1.7.4 is released.

Codecov Report

Merging #69 into master will increase coverage by 1.25%.
The diff coverage is 81.16%.

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage     75.29%   76.55%   +1.25%
- Complexity      547      637      +90
============================================
  Files            71       71
  Lines          1919     2354     +435
  Branches        146      187      +41
============================================
+ Hits           1445     1802     +357
- Misses          397      448      +51
- Partials         77      104      +27

Impacted Files
Coverage Δ
Complexity Δ

...co/elastic/apm/impl/transaction/TransactionId.java
78.78% <ø> (ø)
15 <0> (ø)
:arrow_down:

.../java/co/elastic/apm/impl/error/ExceptionInfo.java
58.82% <ø> (ø)
7 <0> (ø)
:arrow_down:

...ain/java/co/elastic/apm/impl/ElasticApmTracer.java
79.2% <ø> (ø)
33 <0> (ø)
:arrow_down:

...n/java/co/elastic/apm/impl/error/ErrorCapture.java
60.86% <ø> (ø)
8 <0> (ø)
:arrow_down:

...a/co/elastic/apm/impl/transaction/Transaction.java
71.91% <ø> (+1.12%)
26 <0> (-1)
:arrow_down:

...o/elastic/apm/impl/error/TransactionReference.java
71.42% <ø> (ø)
3 <0> (ø)
:arrow_down:

...main/java/co/elastic/apm/impl/payload/Service.java
90.9% <ø> (ø)
14 <0> (ø)
:arrow_down:

...c/apm/impl/stacktrace/StacktraceConfiguration.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...e/src/main/java/co/elastic/apm/impl/error/Log.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...n/java/co/elastic/apm/impl/transaction/SpanId.java
77.77% <ø> (ø)
11 <0> (ø)
:arrow_down:

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cf440...02d10f6. Read the comment docs.


Not fully showing in HK

Describe the bug
<I am not able to see my "Security Panel". I am able to add it to homekit, it shows the hub but not the panel itself.>
To Reproduce
N/A
Expected behavior

Screenshots
<N/A>

Are you able to use homebridge-ui-x and see if the panel shows up there?

I was not able to see it on the Homebridge interface. I think the problem was that I was not able to login to Alarm.com having 2FA. What I did was set up a separate account with minimal access for it to log into the web services for Alarm.com

Awesome, glad you got it working. Long term I would recommend enabling proper MFA for better security but also because they seem to be transparently forcing users onto MFA.
https://github.com/node-alarm-dot-com/homebridge-node-alarm-dot-com/wiki/Two-Factor-Authentication-Support


search_multi does not work

Normal search() is working just fine for any one of these queries, but search_multi() just doesn't work. I printed the curl request before it was sent (around here https://github.com/aparo/pyes/blob/master/pyes/es.py#L444) which printed this:
curl -XGET http://localhost:9200/client_3/_msearch -d '""
{"query": {"bool": {"must": [{"match_all": {}}]}}}
""
{"query": {"bool": {"must": [{"match_all": {}}]}}}
""
{"query": {"bool": {"must": [{"match_all": {}}]}}}
'

That request does not correspond to the Multi Search API of Elasticsearch: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-multi-search.html
Elasticsearch is returning:
{
    "error": null
}

for simple search_multi usage:
queries = queries[:3]
print(queries)
print(queries[0].serialize())
print(queries[1].serialize())
print(queries[2].serialize())

es.search_multi(queries=queries)
for r in rs:
    pass  # do something

I get this printed:
[<pyes.query.BoolQuery object at 0x2b42906fed90>, <pyes.query.BoolQuery object at 0x2b42906fe190>, <pyes.query.BoolQuery object at 0x2b42906fe1d0>]
{'bool': {'must': [{'match_all': {}}]}}
{'bool': {'must': [{'match_all': {}}]}}
{'bool': {'must': [{'match_all': {}}]}}

Traceback:
    for r in rs:
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/es.py", line 1556, in __next__
    self._do_search()
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/es.py", line 1499, in _do_search
    response = self._search_raw_multi()
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/es.py", line 1526, in _search_raw_multi
    doc_types_list=self.doc_types_list, routing_list=self.routing_list)
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/es.py", line 967, in search_raw_multi
    return body, self._send_request('GET', path, body)
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/es.py", line 416, in _send_request
    raise_if_error(response.status, decoded)
  File "/home/vagrant/.python/lib/python3.3/site-packages/pyes/convert_errors.py", line 70, in raise_if_error
    if '; nested: ' in error:
TypeError: argument of type 'NoneType' is not iterable

Elasticsearch info:
{
    "version": {
        "number": "1.1.1",
        "build_hash": "f1585f096d3f3985e73456debdc1a0745f512bbc",
        "build_timestamp": "2014-04-16T14:27:12Z",
        "build_snapshot": false,
        "lucene_version": 4.7
    }
}

pyes version: 0.90.0 (problem exists in 0.99.2 as well)

I'm using pyes version 0.99.5, and I found out that the problem is that the search is never executed.
The call to search_multi constructs a ResultSetMulti from all the parameters that you pass in, but the class it returns never has any results in it. I figured out that there is a private method in ResultSetMulti called _do_search() that executes search_raw_multi, and populates the class's result data. This method is of course... never called. So... Here is the code:
 result = es_conn.search_multi(queries=pyes_searches, indices_list=index_list, doc_types_list=doc_type_list, search_type_list=search_type_list, routing_list=routing_list)
 result._do_search()
 return result

.search works just fine without digging into the code to find some private method that is never called, but not with search_multi!


README says no need for package.json, but gives error

README says package.json is not needed, also, in the USAGE section, only run the command readme. However it gives this error
⠋ Gathering project infosreadme [template]

Generate README.md from a template

Positionals:
  template  The name of template you want to use            [default: "default"]

Options:
  --version  Show version number                                       [boolean]
  --help     Show help                                                 [boolean]

{ Error: ENOENT: no such file or directory, open 'package.json'
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'package.json' }

This will be fixed quickly ;) Thank you for the report 😉

Hi, updated the package in my end, but i still get the same error:
 sudo npm i -g readme-md-generator
[sudo] password for brbl:
/usr/bin/readme -> /usr/lib/node_modules/readme-md-generator/src/index.js
+<EMAIL_ADDRESS>updated 1 package in 14.47s

⠋ Gathering project infosreadme [template]

Generate README.md from a template

Positionals:
  template  The name of template you want to use            [default: "default"]

Options:
  --version  Show version number                                       [boolean]
  --help     Show help                                                 [boolean]

 readme
{ Error: ENOENT: no such file or directory, open 'package.json'
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'package.json' }

I did not release the last version for now 😉 I'll reopen the issue until next release

Fixed in last release


Python wrapper

Find here an attempt to fix  https://github.com/chipsalliance/Surelog/issues/2635
I try to follow guidance that have been provide.

The wrapping of VPI method only has a limited usage since it does not allow to change the uhdm db.
Some VPI method implementation were missing, so dummy (empty) implementation has been provided.
Some VPI method have not been wrap because they are variadic function and wrapping with swig was not obvious...
swig 4.0 limitation : UHDM C++ 17 code is not fully supported. #ifdef / #ifndef SWIG have been introduce possibly in generated code. std:string_view is not yet supported and has been work-arround by creating new method using std::string as argument. Not clear to me if there is more efficient and how to implement it.
swig wrapper generation still produce warnings, can't figure out the consequence now:

/home/tom/prog/git/UHDM/dbuild/generated/uhdm/vpi_user.h:656: Warning 312: Nested union not currently supported (ignored).
/home/tom/prog/git/UHDM/dbuild/generated/uhdm/vpi_user.h:674: Warning 312: Nested union not currently supported (ignored).
/home/tom/prog/git/UHDM/dbuild/generated/uhdm/sv_vpi_user.h:541: Warning 312: Nested union not currently supported (ignored).
/home/tom/prog/git/UHDM/dbuild/generated/uhdm/vpi_user.h:1027: Warning 462: Unable to set dimensionless array variable

The build system has been amended to compile this shared library if UHDM is compile with  BUILD_SHARED_LIBS option set
A single test is currently provide testing the proper import of uhdm python module. Additional tests should probably be provide and would help to demonstrate how to use the library.

@hs-apotell Can you review since this touches some code generation.

I am not happy with the way I change classes.py to generate dot i file... There is some behavior of the script that I did not fully understand. But it is working. Code change can still be done later... The main point is : it did not break anything.

Looks like your approach is generating a parallel set of headers for use with swig. Any reason why the existing headers cannot be used without duplicating them? Even if required, wrapping certain functions with the SWIG macro would be preferred approach over duplicating the entire header.

Using the existing header was the initial approach with much more #ifndef SIWG / #endif.
Having separate file make it more clear of what is wrapped of what is not.
Also I though it is more easy to produce docstring or doxygen statement for automatic documentation generation.
But I agree this is high questionable.

@Thomasb81 , in my original proposal of an implementation:
https://github.com/chipsalliance/Surelog/issues/2635#issuecomment-1077018391
I proposed we only expose the C API of UHDM (Read only) which is the VPI Standard interface.
This is going to be 99% of the use cases.
No need to expose the C++ API for most use cases.
Can we limit this PR to do just that, or create another PR that solves that much easier problem first?

@Thomasb81 , in my original proposal of an implementation: chipsalliance/Surelog#2635 (comment)
I proposed we only expose the C API of UHDM (Read only) which is the VPI Standard interface. This is going to be 99% of the use cases. No need to expose the C++ API for most use cases. Can we limit this PR to do just that, or create another PR that solves that much easier problem first?

It was my first intention.
But then come the question : what can I provide as unit-test to ensure, next project contribution does not break this feature. The load of uhdm module is definitively not enough. We don't want to data-manage uhdm file, that can change if model change and coupling C++ for test vector generation with a python unit test was not simple enough.
Then I though going a step further is achievable. I underestimate the complexity to handle the generation code from model and difficulty to wrap the some C++ code...

You could have simply created a C++ function that creates "a model" from C++, invoke it from Python , then query the model from Python.
You don't have to test many features, meaning you don't have to test UHDM creation or VPI use, that is tested plenty. Just make sure the most important vpi_iterate, get_get functions do work from Python.
I think you are now down a rabbit hole that is going be hard to see through.

@alaindargelas @hs-apotell
I simplified the current PR for vpi API and add a python demonstrating minimum iteration of uhdm db as you asked.
I expect this now meet your expectation.
Following python code should load an uhdm file:
import uhdm
s  = uhdm.Serializer()
data = s.Restore("a_uhdm_file.uhdm")

Why is python binding dependent on BUILD_SHARED_LIBS here?
Python binding should have nothing to do with whether the project is built with shared or with static libraries.

Also: why is Python bindings bundled with the UHDM project and is not made a separate project?
Multiple versions of Python can be installed concurrently, but UHDM can't be installed multiple times.
How can multiple versions of the bindings be installed in the situation of multiple Python versions if bindings is bundled with the UHDM project?

Why is python binding dependent on BUILD_SHARED_LIBS here?

I am not aware of other method to create a python module from C or C++ code :  https://www.swig.org/Doc4.0/SWIGDocumentation.html#Introduction_nn8
Compiler complain if all the source code is not compile with -fpic. not sure we can mix -fpic at compilation and -shared at link stage
Unless you do the other way : integrate the python interpreter to your application. (What is done in Surelog, I think)

Multiple versions of Python can be installed concurrently, but UHDM can't be installed multiple times.

Did I miss something ? I try to understand / follow cmake swig integration. As far as remember the installation is done in python version specific directories. At least on ubuntu.
Feel free to propose modification that will full fill your needs or what you think need to be done. I am not expert.

One initial hurdle I found here was that Python needs to be compiled with --enable-shared to create libpython3.x.so.   This is fine for system versions of Python, but it turns out pyenv does not do this by default.
For future googlers, if you get the -fpic warning, it may be because of this.
To compile shared w/ pyenv:
env PYTHON_CONFIGURE_OPTS="--enable-shared" pyenv install -verbose 3.9.11


Support for an external exportStar helper

Adds an external __exportStar helper per this suggestion.

@mhegazy I take it we want this in and available on npm before we merge https://github.com/Microsoft/TypeScript/pull/13272?


fix(deps): update aws-sdk-go-v2 monorepo

This PR contains the following updates:

Package
Type
Update
Change

github.com/aws/aws-sdk-go-v2/config
require
patch
v1.27.34 -> v1.27.35

github.com/aws/aws-sdk-go-v2/credentials
require
patch
v1.17.32 -> v1.17.33

github.com/aws/aws-sdk-go-v2/service/ecr
require
minor
v1.33.0 -> v1.34.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

3 additional dependencies were updated

Details:

Package
Change

github.com/aws/aws-sdk-go-v2/service/sso
v1.22.7 -> v1.22.8

github.com/aws/aws-sdk-go-v2/service/ssooidc
v1.26.7 -> v1.26.8

github.com/aws/aws-sdk-go-v2/service/sts
v1.30.7 -> v1.30.8


Minor fixes

This includes two minor fixes:

Links should allow punctuation in front of the and not require a whitespace (this requirement only holds for TODO syntax).

Correct parsing of ranged tag names starting with e. See screenshot below (although this second commit is kind of odd, I admit that)...

Note, that the ranged tag name endeavour is also handled properly even though it starts with end.


Add training=False behavior for float8-trained Dense and EinsumDense

Related to #19671
This PR introduces training=False behavior for float8-trained Dense and EinsumDense layers.
We could eliminate amax_history and preprocess the weights to bypass the transpose op in compiled graph, but this would make the layers unrecoverable for further training. (We want to continue training in fitting)
Perhaps the post-processing could be considered as a future plan.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.06%. Comparing base (f12a205) to head (0c0a008).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19682       +/-   ##
===========================================
- Coverage   78.41%   62.06%   -16.36%
===========================================
  Files         498      498
  Lines       45507    45513        +6
  Branches     8379     8381        +2
===========================================
- Hits        35686    28249     -7437
- Misses       8091    15660     +7569
+ Partials     1730     1604      -126

Flag
Coverage Δ

keras
62.06% <100.00%> (-16.20%)
:arrow_down:

keras-jax
?

keras-numpy
?

keras-tensorflow
?

keras-torch
62.06% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


nothing gets captured

after started and setting the proxy. I get nothing captured.
log screen is filled with FEConnection error: Connection not ready, message not sent.
I am using the node 5.1 on macosx

I've seen that happen to me. Backend (node script) is not able to connect with the frontend (devtools). It tries to do so via localhost:1337, maybe this port is blocked on your machine? In the future, we probably should get rid of websocket connection all together and use internal electron communication.

@zinking checked on 2 Mac with El Capitan and Node.js>5.0
The same issue.
I found only one workaround- enabling Web Proxy after betwixt has been already started.
Haven't found any workarounds for http_proxy

hey @dgospodarets - the issue that @zinking has is not related with the proxy, it's related with communication between front-end (devtools) and back-end(node). It will be fixed via #23. Are you seeing the same issue?
Proxy starts as soon as app starts. It does so on port 8008.

@kdzwinel yep, I'm seeing the same issue.
Works only when Web Proxy is activated after starting betwixt

ok, I'm moving this discussion to #24 as it's different than error reported by OP.
@malyw @damoonrashidi please provide more details in #24 .

@zinking this should be fixed now, backend and frontend no longer use websocket to talk to each other.


Format configuration loaded messages with JSON

What does this PR do?
When a certain configuration medium has been loaded, a message is logged. This PR formats that message in JSON if the configuration specifies JSON formating, whereas previously it was not formatted.
Motivation
Fixes #7723 (additionally fixes that same issue in the other configuration mediums)
Additional Notes
These messages escape the configuration rules because they are printed in the loader functions before the loaded configuration is processed. I couldn't just add them to the configureLogging function where the formatting change is made for the entire program, because the loader functions are the only place where we can specify a certain configuration medium (e.g. flags).

Not exactly sure what's going on with the tests here. test-integration fails with seemingly no error message, and test-unit fails on some TCP entrypoint test unrelated to what I was doing.

Not exactly sure what's going on with the tests here. test-integration fails with seemingly no error message, and test-unit fails on some TCP entrypoint test unrelated to what I was doing.


[feature request] Leet open to open the current question in browser

Great tool! I enjoy using it.
A small request is sometimes, I want to check editorials or discussions within the leetcode.com platform and it would save few clicks if there was a command to open a current question in browser.
I'm willing to contribute with some guidance.

Sounds great,

You would have to create a new function inside https://github.com/kawre/leetcode.nvim/blob/master/lua/leetcode/command/init.lua called open
Append that function to commands table (it will automatically make it executable and visible in autocompletion)
You can figure out how to get the current question by looking at the other commands.
Once you get the current question, link should be available under q.cached.link

Seems pretty clear from the code structure.
However, I'm quite new to the nvim ecosystem and I struggle to run this plugin locally.
Do you mind telling me how to test this plugin locally before making any changes.

You need to fork this repository into config.dev.path specified inside lazy.nvim config. Then all you have to do is set dev = true in your leetcode.nvim lazy config.


[5.5] Key collection of values with provided array

This is the inverse of $collection->combine($values) where it allows you to key the collection with the provided values.
I added something like this directly the the partition method and then realised it could be used outside of that, but basically:
$memberships = Membership::all()->partition('is_main')->keyWith(['main', 'secondary']);

$memberships['main']; // main memberships
$memberships['secondary']; // secondary memberships

I know the naming is very close the the already existing keyBy, so if anyone has a better name...

#weDontNeedThis
list($main, $secondary) = Membership::all()->partition('is_main');

// or

collect(['main', 'secondary'])->combine(Membership::all()->partition('is_main'));

But I can see this being handy to have and I'll certainly use it.

No plans to add this to core right now.


Added Get-FileEncoding cmdlet

PR Summary

Fixes #2290.
Added Get-FileEncoding cmdlet to detect encoding from file using System.IO.StreamReader.CurrentEncoding.
Also moved the GetPathEncoding method to PathUtils so it can be shared easily between cmdlets.
PR Context

Parameter Sets
Get-FileEncoding [-Path] <string> [<CommonParameters>]

Get-FileEncoding [-LiteralPath] <string> [<CommonParameters>]

Usage
> Get-FileEncoding -Path .\.markdownlint.json

Preamble          :
BodyName          : utf-8
EncodingName      : Unicode (UTF-8)
HeaderName        : utf-8
WebName           : utf-8
WindowsCodePage   : 1200
IsBrowserDisplay  : True
IsBrowserSave     : True
IsMailNewsDisplay : True
IsMailNewsSave    : True
IsSingleByte      : False
EncoderFallback   : System.Text.EncoderReplacementFallback
DecoderFallback   : System.Text.DecoderReplacementFallback
IsReadOnly        : True
CodePage          : 65001

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

The issue predates the TextUtility module. I feel this cmdlet should be in that module so earlier PowerShell versions can make use of it.

@PowerShell/wg-powershell-cmdlets discussed this and we agreed that this is a useful cmdlet, however, it should be part of the https://github.com/powershell/textutility module and not part of PS7 itself.

Thanks @SteveL-MSFT & @ThomasNieto for the feedback. I'll make a PR in the TextUtility repo and close this PR.


Error raised by sct_qc when dealing with empty masks

Description
An error is raised by sct_qc when new created labels are empty. This behaviour is actually interesting in some cases:

to not keep empty labels
to be aware of complex subjects

However, keeping empty masks can be relevant for some specific tasks such as lesions segmentations.
Question
Should we create a check after the creation of the label to avoid this problem ?

Should we create a check after the creation of the label to avoid this problem ?

Agree. I would add a simple condition checking if the label file is empty (for example in case of MS patient with no visible lesion). If so, I would skip the QC.

The error raised by sct_qc:
$ sct_qc -i sub-zh01_ses-01_acq-sag_T1w.nii.gz -s sub-zh01_ses-01_acq-sag_T1w_label-disc.nii.gz -p sct_label_utils -qc qc

--
Spinal Cord Toolbox (git-master-8b8f9bd98a0565d670faa515a6b24ecbc5a7d3a3)

sct_qc -i sub-zh01_ses-01_acq-sag_T1w.nii.gz -s sub-zh01_ses-01_acq-sag_T1w_label-disc.nii.gz -p sct_label_utils -qc qc
--

*** Generate Quality Control (QC) html report ***
Resample images to NonexNone mm
QcImage: layout with Sagittal slice
Traceback (most recent call last):
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/scripts/sct_qc.py", line 105, in <module>
    main(sys.argv[1:])
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/scripts/sct_qc.py", line 90, in main
    generate_qc(fname_in1=arguments.i,
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/reports/qc.py", line 713, in generate_qc
    QcImage(
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/reports/qc.py", line 239, in layout
    img, *mask = qcslice_layout(qcslice)
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/reports/qc.py", line 665, in qcslice_layout
    def qcslice_layout(x): return x.single()
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/reports/slice.py", line 252, in single
    index = self.get_center_spit()
  File "/Users/valosek/code/sct_latest/spinalcordtoolbox/reports/slice.py", line 433, in get_center_spit
    raise ValueError("Label/segmentation image is empty. Can't retrieve RL slice indices.")
ValueError: Label/segmentation image is empty. Can't retrieve RL slice indices.

Note that the error is raised due to the -p sct_label_utils flag.
For the -p sct_deepseg_lesion flag, empty QC can be created:
$ sct_qc -i sub-zh01_ses-01_acq-sag_T1w.nii.gz -s sub-zh01_ses-01_acq-sag_T1w_seg.nii.gz -d sub-zh01_ses-01_acq-sag_T1w_lesion.nii.gz -p sct_deepseg_lesion -plane axial -qc qc

--
Spinal Cord Toolbox (git-master-8b8f9bd98a0565d670faa515a6b24ecbc5a7d3a3)

sct_qc -i sub-zh01_ses-01_acq-sag_T1w.nii.gz -s sub-zh01_ses-01_acq-sag_T1w_seg.nii.gz -d sub-zh01_ses-01_acq-sag_T1w_lesion.nii.gz -p sct_deepseg_lesion -plane axial -qc qc
--

*** Generate Quality Control (QC) html report ***
Resample images to 0.6x0.6 mm
QcImage: layout with Axial slice
Compute center of mass at each slice
/Users/valosek/code/sct_latest/python/envs/venv_sct/lib/python3.8/site-packages/scipy/ndimage/_measurements.py:1534: RuntimeWarning: invalid value encountered in double_scalars
  results = [sum(input * grids[dir].astype(float), labels, index) / normalizer
qc/sub-zh01/ses-01/anat/sct_deepseg_lesion/2023_08_22_155410.797321/background_img.png
Successfully generated the QC results in qc/_json/qc_2023_08_22_155410.797321.json

To see the results in a browser, type:
open qc/index.html

Okay, an empty label file is not supported by the following sct_qc -p options:

sct_label_utils
sct_label_vertebrae
sct_detect_pmj


Arbitrary instance for Char

I'd like to generate non-BMP strings with scalacheck, essentially to check whether our code base copes with emojis and all sorts of other strange unicode chars users might enter on their phones.
I tried to figure out whether scalacheck might already have be covered here, and came across the current Arbitrary[Char] instance which looks rather… sophisticated:
 /** Arbitrary instance of Char */
  implicit lazy val arbChar: Arbitrary[Char] = Arbitrary(
    Gen.frequency(
      (0xD800-Char.MinValue, Gen.choose[Char](Char.MinValue,0xD800-1)),
      (Char.MaxValue-0xDFFF, Gen.choose[Char](0xDFFF+1,Char.MaxValue))
    )

What's the reason for "Gen.frequency" and the exclusion of some char ranges?
The instance used to be Gen.choose(Char.MinValue, Char.MaxValue), but a long time ago the current instance was introduced in c0f3c0d42067807706b54bbc95a9eeed66182b46.  Unfortunately the commit message is very, uhm, "brief", and it's not Github's issue #78 it refers to obviously.
Can anyone shed a light on this rather peculiar instance?  Am I missing something very obvious?

I'm not a developer of this, but the range 0xD800 to 0xDFFF are the surrogate characters, used to encode chars outside of the BMP. Since these only make sense in pairs (high + low), generating them individually seems of no use (according to the link, "isolated surrogate code points have no general interpretation").
The Gen.frequency is needed to make the distribution uniform; with just a Gen.oneOf of the two blocks, the generated values would be right skewed, so they are weighed by their lengths to compensate that.
In order to generate stuff outside the BMP, I suppose you have to write your own generator. Or probably, there already exists such a thing somewhere...

@phipsgabler Thanks, that's very enlightening.  :+1: :clap:

Is this issue solved? Mind if we close this @lunaryorn?
For reference, here's a generator that can choose any 16-bit unsigned character value:
val g: Gen[Char] = Gen.choose(0.toChar, 0xffff.toChar)

This can be passed directly to forAll or wrapped in Arbitrary(...) to produce an Arbitrary[Char] value.


Policy object pusher and security group of interests converters

Pull Request summary:
Extracting policy object pusher from config pusher
Introducing UrlFiltering converter
Adding initial shape of  abstraction for v1->v2 references update
Checklist:

[x] Make sure to run pre-commit before committing changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

Push works correctly, clear_ux2 and rollback needs fixes. working on that


[BUG] wasm_exec.js overwritten the native window.close method

OpenIM Server Version
3.8.0
Operating System and CPU Architecture
Linux (AMD)
Deployment Method
Docker Deployment
Bug Description and Steps to Reproduce
don't use the native window.close
Screenshots Link
No response

temporary solution: <script>var nativeClose = window.close;</script>

Because the calls between wasm and js are all registered on the window method.


Create Organization schema

Create an organization schema. It should includes fields name, email, totalMembers, password. These fields are enough for now. We will add other fields later on.

Hey, I want to work on this issue

@shagun0915 It's been a long time you were assigned this task. Need help?

@shagun0915 Are you working?

@ruchikamuddinagiri This task is still left , would you like to take this?


Add ICCV2023 paper PYoCo  and another paper VideoFusion

PYoCo : Preserve Your Own Correlation: A Noise Prior for Video Diffusion Models
https://research.nvidia.com/labs/dir/pyoco/
https://openaccess.thecvf.com/content/ICCV2023/papers/Ge_Preserve_Your_Own_Correlation_A_Noise_Prior_for_Video_Diffusion_ICCV_2023_paper.pdf
https://arxiv.org/pdf/2305.10474.pdf
VideoFusion: Decomposed Diffusion Models for High-Quality Video Generation
https://arxiv.org/pdf/2303.08320v4.pdf

This issue is solved by #329


BitfocusAS.Companion version <IP_ADDRESS>11

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

Close with reason: Stale PR;

[Policy] Needs-CLA


Unable to import DatebaseLibrary onto my Maven project (Robotframework runs on JVM)

I could not find maven dependency for https://github.com/ThomasJaspers/robotframework-dblibrary/ (Suggested via robotframework.org)
Therefore i downloaded the jars from the above link and manually imported the dblibrary-2-0.jar and dblibrary-2-0-server.jar
When i run a sample Database.txt which contains the following
*** Settings ***
Library         OperatingSystem
Library         DatabaseLibrary
*** Test Cases ***
Connect
Connect To Database Using Custom Params  jaydebeapi  org.mysql.jdbcDriver  diliptest1  sa ${EMPTY}
Execute SQL  create table testtable (myid integer not null primary key, name varchar(25))
I get the following error:
Importing test library 'DatabaseLibrary' failed: ImportError: No module named DatabaseLibrary
Need Help! Thanks in advance!

Did you tried to run the Demo?
You consulted the project Wiki, right?
From there you can see that you must use Jython and jybot, and add the path to the JAR to CLASSPATH.
The example demo, import of the Library is like:
Library    org.robot.database.keywords.DatabaseLibrary

I have added the JAR file 'dblibrary-2-0.jar' to CLASSPATH, I have imported the Library as suggested by you : Library org.robot.database.keywords.DatabaseLibrary
But now i get the following
Error in file '/Users/delipan.r/Downloads/Dilip_Robot/Database.txt': Importing test library 'org.robot.database.keywords.DatabaseLibrary' failed: ImportError: No module named robot
Traceback (most recent call last):
None
PYTHONPATH:
/Users/delipan.r/Downloads/Dilip_Robot/Complete-Robot-Runner-0.0.1-SNAPSHOT.jar/Lib/robot/libraries
/Users/delipan.r/Downloads/Dilip_Robot/Complete-Robot-Runner-0.0.1-SNAPSHOT.jar/Lib
/Users/delipan.r/Downloads/Dilip_Robot/Lib
classpath
pyclasspath/
.
/Users/delipan.r/Downloads/Dilip_Robot
CLASSPATH:
Complete-Robot-Runner-0.0.1-SNAPSHOT.jar
[ ERROR ] Error in file '/Users/delipan.r/Downloads/Dilip_Robot/Database.txt': Importing test library 'jaydebeapi' failed: ImportError: No module named jaydebeapi
Traceback (most recent call last):
None
PYTHONPATH:
/Users/delipan.r/Downloads/Dilip_Robot/Complete-Robot-Runner-0.0.1-SNAPSHOT.jar/Lib/robot/libraries
/Users/delipan.r/Downloads/Dilip_Robot/Complete-Robot-Runner-0.0.1-SNAPSHOT.jar/Lib
/Users/delipan.r/Downloads/Dilip_Robot/Lib
classpath
pyclasspath/
.
/Users/delipan.r/Downloads/Dilip_Robot
CLASSPATH:
Complete-Robot-Runner-0.0.1-SNAPSHOT.jar
Above is full error message i got, I am running the Database.txt file using the executable jar "Complete-Robot-Runner-0.0.1-SNAPSHOT.jar" with command
java -jar Complete-Robot-Runner-0.0.1-SNAPSHOT.jar Database.txt
What does not import the database library, i have also externally imported the dblibrary-2.0.jar in the project, also kept it in that CLASSPATH.
Why does it not recognise robot folder inside the  " dblibrary-2.0.jar" ?

So you made some progress?
I  think the important error is this:

[ ERROR ] Error in file '/Users/delipan.r/Downloads/Dilip_Robot/Database.txt': Importing test library 'jaydebeapi' failed: ImportError: No module named jaydebeapi
(maybe adding jaydebeapi to CLASSPATH will solve?)

I would say that the dblibrary is an "abandoned" project, since:

dated from 2012
NO SOURCE CODE AVAILABLE!

I see that you are not running with jybot (Jython), where did you get Complete-Robot-Runner-0.0.1-SNAPSHOT.jar from? Obsolete?
(This is the current released version http://repo1.maven.org/maven2/org/robotframework/robotframework/2.8.7/)
I can't help you more with this, good luck.

This issue doesn't seem to have anything to do with Robot Framework core. Questions are better asked on robotframework-users or other such forums instead of this issue tracker in general.
I do agree with @HelioGuilherme66 that this DB library looks dead and abandoned. Should be removed from robotframework.org.


Small cleanup on api/types.go

LGTM

@dchen1107 looks like we need to run gendocs

It is weird. I ran ./hack/verify-gendocs.sh, and nothing complains:
+++ [0401 15:01:26] Building go targets for linux/amd64:
    cmd/gendocs
    cmd/genman
+++ [0401 15:01:28] Placing binaries
diffing /usr/local/src/goproj/src/github.com/GoogleCloudPlatform/kubernetes/docs/ against generated output from /usr/local/src/goproj/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/bin/linux/amd64/genman
/usr/local/src/goproj/src/github.com/GoogleCloudPlatform/kubernetes/docs/ up to date.

Also I ran hack/gendocs.sh, nothing is generated too.


Set milestone when PR is merged

When a PR is created, carsonbot will now link it to a milestone for the default branch too.
The milestone will be updated when a PR is switched to another branch when merging with gh.

Thanks Nicolas!


Customizing data directory and cveUrl's, execution fails the first two times

I have a custom configuration for the data directory and cveUrl's. The data directory is initially empty; the first two times I run ./gradlew dependencyCheckAnalyze it fails. The third and subsequent times, it succeeds.
In my build.gradle I have:
dependencyCheck {
        cve {
            urlBase="file:///${nistDataDirectory}/nvdcve-1.1-%d.json.gz"
            urlBase="file:///${nistDataDirectory}/nvdcve-1.1-modified.json.gz"
            print "Using ${urlBase}"
        }
        data {
            directory = "${nistDataDirectory}/nist/db"
        }
}

I'm using the nist-data-mirrror to populate the nist/ directory with the CVE's.
The nist/db directory is initially empty. The first two times I run ./gradlew dependencyCheckAnalyze it fails; the third and subsequent times, it succeeds.
Not sure if I've misconfigured something or this is defect. I'm assuming the former, I can't imagine what I'm doing is that uncommon (we're running this as part of a pipeline build and trimming off several minutes is pretty valuable). What are we missing?


[SPARK-22766] Install R linter package in spark lib directory

What changes were proposed in this pull request?
dev/lint-r.R file installs uses devtools to install jimhester/lintr package in the default site library location which is /usr/local/lib/R/site-library. This is not recommended and can fail because we are running this script as jenkins while that directory is owned by root.
This patch changes lint-r.R to install the linter package in a local directory.
How was this patch tested?
Existing linter should pass.
cc @JoshRosen

Test build #84804 has started for PR 19959 at commit 2376b0b.

Because LOCAL_LIB_LOC seems to default to $SPARK_HOME/R/lib, will installing to this folder create the potential for lintr to be installed into a lib folder which gets packaged up in binary builds? Just want to double-check to make sure this won't mess up any packaging scripts which might be interacting with that directory. (I'm not super familiar with how R packaging works, so just wanted to double-check and be safe).

@JoshRosen the SparkR package is built from spark/R/pkg directory. $SPARK_HOME/R/lib is just a place where SparkR is installed (after it has been built) and at runtime loaded from.

Test build #84808 has started for PR 19959 at commit 6892725.

Test build #84808 has finished for PR 19959 at commit 6892725.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84808/
Test FAILed.

Test build #84813 has started for PR 19959 at commit 4355fae.

Test build #84813 has finished for PR 19959 at commit 4355fae.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84813/
Test FAILed.

Just for a refreshing reminder about https://github.com/apache/spark/pull/19959#discussion_r156536774.
One problem was how to deal with other branches too in our single environment. If this is simply upgraded in workers, it might cause style checking failures in other branches, if I understood correctly.  Here, https://github.com/apache/spark/pull/19290, I fixed the styles in a batch caught by  jimhester/lintr@5431140 so it's fine in the master but might be broken in other branches if lintr is upgraded naively in workers.
One suggestion was virtual env in R by @shivaram here.
Another quick suggestion was to install it by controlling this by Jenkins environment variable, which I don't even like but at least works - https://github.com/apache/spark/pull/19290#issuecomment-333365703

Test build #84804 has finished for PR 19959 at commit 2376b0b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84804/
Test PASSed.

@shivaram are there other concerns with this patch?

ping @shivaram

actually ping @falaki for https://github.com/apache/spark/pull/19959#discussion_r158558712 if I understood correctly.

Test build #91311 has started for PR 19959 at commit 4355fae.

Test build #91311 has finished for PR 19959 at commit 4355fae.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91311/
Test FAILed.

Test build #104400 has started for PR 19959 at commit 4355fae.

Test build #104400 has finished for PR 19959 at commit 4355fae.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104400/
Test FAILed.

I guess we should close this?


Image Support

Would you consider adding image printing support?

Yes, at some point, although I cannot give an estimate of when this will happen.


Error on "Joining peers to channel"

After running deploy.sh we are getting following error:
Joining peers to channel
Error: Error getting endorser client channel: PER:404 - Error trying to connect to local peer
/usr/local/go/src/github.com/hyperledger/fabric/peer/common/common.go:116 github.com/hyperledger/fabric/peer/common.GetEndorserClient
/usr/local/go/src/github.com/hyperledger/fabric/peer/channel/channel.go:149 github.com/hyperledger/fabric/peer/channel.InitCmdFactory
/usr/local/go/src/github.com/hyperledger/fabric/peer/channel/join.go:138 github.com/hyperledger/fabric/peer/channel.join
/usr/local/go/src/github.com/hyperledger/fabric/peer/channel/join.go:42 github.com/hyperledger/fabric/peer/channel.joinCmd.func1
/usr/local/go/src/github.com/hyperledger/fabric/vendor/github.com/spf13/cobra/command.go:599 github.com/hyperledger/fabric/vendor/github.com/spf13/cobra.(*Command).execute
/usr/local/go/src/github.com/hyperledger/fabric/vendor/github.com/spf13/cobra/command.go:689 github.com/hyperledger/fabric/vendor/github.com/spf13/cobra.(*Command).ExecuteC
/usr/local/go/src/github.com/hyperledger/fabric/vendor/github.com/spf13/cobra/command.go:648 github.com/hyperledger/fabric/vendor/github.com/spf13/cobra.(*Command).Execute
/home/ubuntu/go/src/github.com/hyperledger/fabric/peer/main.go:118 main.main
/usr/local/go/src/runtime/proc.go:194 runtime.main
/usr/local/go/src/runtime/asm_amd64.s:2198 runtime.goexit
Caused by: context deadline exceeded
Usage:
peer channel join [flags]
Flags:
-b, --blockpath string   Path to file containing genesis block
Global Flags:
--cafile string              Path to file containing PEM-encoded trusted certificate(s) for the ordering endpoint
--logging-level string       Default logging level and overrides, see core.yaml for full syntax
-o, --orderer string             Ordering service endpoint
--test.coverprofile string   Done (default "coverage.cov")
--tls                        Use TLS when communicating with the orderer endpoint
-v, --version                    Display current version of fabric peer server
Please let me know if anything is missing. I think issue is related to certificates.
For your reference, here is the Error in log file peer1.out =>
[main] main -> ERRO 001^[[0m Cannot run peer because error when setting up MSP from directory /opt/gopath/src/github.com/hyperledger/fabric/sampleconfig/crypto: err The supplied identity is not valid, Verify() returned x509: certificate signed by unknown authority (possibly because of "x509: ECDSA verification failure" while trying to verify candidate authority certificate "ca.hrl.ibm.il")

hi ,i had met the same problem.can you tell me you how to slove it?


Add test time and sample size as an option per benchmark basis in config yaml files

Is your feature request related to a problem? Please describe.
Currently, minimum test time and sample size options are global in a yaml file. Multiple benchmarks will use the global values even if they are not appropriate for their implementation.
Describe the solution you'd like
It would be nice to have a per-benchmark setting for these options (with, perhaps, sample size per operand). Maybe using the global values as fallback.
From the docs, a suggested version goes from current:
default_min_test_time: <min_test_time_ms>
default_sample_size: <sample_size>
random_seed: <seed>

benchmark:
  - ID: <benchmark_id>
    params:
      0:
        name: <param_name>
        type: <param_type>
        value:
          from: <value_from>
          to: <value_to>
          step: <value_step>
      1:
        name: <param_name>
        type: <param_type>
        value:
          from: <value_from>
          to: <value_to>
          step: <value_step>
      ...

to
default_min_test_time: <min_test_time_ms>
default_sample_size: <sample_size>
random_seed: <seed>

benchmark:
  - ID: <benchmark_id>
    default_min_test_time: <min_test_time_ms>
    default_sample_size:
      0: <sample_size_for_operand_0>
      1: <sample_size_for_operand_1>
      ...
    params:
      0:
        name: <param_name>
        type: <param_type>
        value:
          from: <value_from>
          to: <value_to>
          step: <value_step>
      1:
        name: <param_name>
        type: <param_type>
        value:
          from: <value_from>
          to: <value_to>
          step: <value_step>
      ...

Describe alternatives you've considered
To achieve this effect currently, a user has to create a config yaml file per test they want to run.

Fixed on #29


added missing com_exception to com_dotnet stub

This class doesn't have a manual page in the traditional format (see https://php.net/manual/en/com.error-handling.php).
Several other classes appear when writing php --re com_dotnet, but I did not take the time to investigate those.

All COM exceptions have a well-defined code property

Am I get it correctly that introduced exception class should have $property field. If so, maybe we will add it as well?

According to php --re com_dotnet, there is not:
    Class [ <internal:com_dotnet> final class com_exception extends Exception implements Throwable ] {

      - Constants [0] {
      }

      - Static properties [0] {
      }

      - Static methods [0] {
      }

      - Properties [4] {
        Property [ <default> protected $message ]
        Property [ <default> protected $code ]
        Property [ <default> protected $file ]
        Property [ <default> protected $line ]
      }

      - Methods [10] {
        Method [ <internal:Core, inherits Exception, ctor> public method __construct ] {

          - Parameters [3] {
            Parameter #0 [ <optional> $message ]
            Parameter #1 [ <optional> $code ]
            Parameter #2 [ <optional> $previous ]
          }
        }

        Method [ <internal:Core, inherits Exception> public method __wakeup ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getMessage ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getCode ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getFile ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getLine ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getTrace ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getPrevious ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> final public method getTraceAsString ] {
        }

        Method [ <internal:Core, inherits Exception, prototype Throwable> public method __toString ] {
        }
      }
    }

I'm sorry I meant code property. Anyway, these properties can be added as separate PR.

@wbars It's inherited from the base Exception class, so no action is necessary.


actions: twister: scale nodes up for large test coverage

If we determine we need more nodes than the default, do not override the
calculated number.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

noticing some long build times on PRs changing lots of boards/tests.


Update README file

Use this README as inspiration: https://github.com/SimformSolutionsPvtLtd/flutter_credit_card

I´ll go for it!

Complete on #31 #32