Compatibility with Cake 0.22 or higher

Thanks a lot for the paket integration into cake. As Cake.Paket currently references Cake 0.21, we have some versioning issues when trying to upgrade Cake. See https://cakebuild.net/blog/2017/09/cake-v0.22.0-released
Do you plan to update the module in the nearer future, or should we provide a PR?

Glad you find it useful. I'd definitely accept a PR for this. I could probably get a release out this weekend if you can wait this long.


Strategy for obstacle avoidance

@amanchandra333 add first years once they are added.

Moved to https://github.com/quadrotor-IITKgp/ark_hlp/issues/4


Investigate unnecessary vcredist invocations/UAC prompts

Apparently for some, the vcredist step is running every single time there is an update, and even requesting UAC in some (all?) cases. I haven't experienced this in my testing, but perhaps that is because I have a dev toolchain installed.

It might bring up a UAC prompt only if the person has set UAC to "always" instead of the default "only when apps try to make changes to my computer". It might be worth investigating if that's the case.
How to change UAC level

It might bring up a UAC prompt only if the person has set UAC to "always" instead of the default "only when apps try to make changes to my computer". It might be worth investigating if that's the case.
How to change UAC level


add Spec.zh-CN.md and reopen a  new pr with the correct filename

as the specification and you guys' suggestion, the right file names, please check~

Awesome! Thank you!


get_measurement_meta: initial implementation

Implements https://github.com/ooni/backend/issues/341

Superseded


ARROW-12764: [CI] Support wildcard expansion when uploading crossbow artifacts

Submitted build https://github.com/ursacomputing/crossbow/branches/all?query=build-301
Using archery crossbow submit conda-win-* --arrow-branch master

Submitted build https://github.com/ursacomputing/crossbow/branches/all?query=build-302

Submitted build https://github.com/ursacomputing/crossbow/branches/all?query=build-304

Couldn't disable glob expansion on azure, so I updated the crossbow command to support multiple arguments instead of pattern options.

@github-actions crossbow submit -g packaging


Anonymous function doesn't parse

Wrong parsing an anonymous functions.
var esprima = require('esprima'); var program = '{a: function () {}}'; console.log(esprima.parse(program));
returns

Error: Line 1: Unexpected token (

In backbone apps it will be a great feature

Thanks for contributing! Esprima is exhibiting the correct behavior here. As weird as it may seem, { a: function () {}} is considered a block statement with a labeled statement inside of it. The labeled statement is function () {} which is a syntax error.
In order to get any parser to interpret this as an object instead of a block statement, try adding a variable declaration like let a =  in front.
Thanks again!

Nice catch. thanks!
I'm a little misunderstood of processing code

I'm still struggling with this. My code:
a = new b({
    c: function (x) {
        return x;
    },
});

How can I make this parse, without fully defining my function instead of calling it anonymously?


Meta fields for descriptions along with newly uploaded files

Type of issue
feature request
Uploader type
traditional
Feature request details
Hey,
i'm using FineUploader for the first time on a project and was wondering, if there's an easy way to add a description field for each download. Or do i have to grab the data returned with jQuery and add the fields outside of the holding div?
Thanks in advance!
Detailed description of the feature
{also include why this feature is necessary and what problems it solves}

Uhm, why did you just close this? Is this feature already available and i just didn't see it?

This isn't a feature request, you've asked for support. Before you ask any further questions in the issue tracker, please read the contribution rules. They are linked to at the top of the new/create issue page.


Any way to prevent notifications when iTerm2 stops to wait for GUI app?

I have an editw function that opens a file in TextMate and waits (mate -w) for the file to be closed before allowing the terminal to continue. This is the only way to use a GUI editor for things like git commit messages or interactive rebase. The editw function falls back to using Vim for non-login shells and SSH connections.
I get no notification when this function ends up launching Vim since it lives in the terminal, but when TextMate is invoked from the terminal, I always get a notification from done when it closes and the terminal continues.

Is there a way to change this behavior?
It seems like a list of commands to exclude (like this example) might be the simplest way to accomplish this. The list would need to be user-configurable. I can submit a PR to introduce excluded commands unless someone knows of a better approach.

This has never happened to me since iTerm gets focus after the editor window is closed. I use Sublime Text, but also just tried to reproduce with Textmate without success.
Which version of iTerm, Textmate, macOS are you using?
Have you tried fisher update?

@phatblat do you get notification on the screen or only in notification center sidebar?

iTerm
TextMate 2.0-rc.7

I use iTerm2's Hotkey Window profile almost exclusively and didn't think about how that is a factor. When the focus moves from iTerm2 to TextMate, the iTerm2 window disappears. So, when I'm done editing and the terminal continues, it is hidden and does not have the focus.
Testing with a normal iTerm2 window, I get no notifications at all. With the Hotkey Window, I get a notification only in the Notification Center sidebar - no on-screen banner. There have been a couple times I've gotten an on-screen banner, but I don't recall exactly what the situation was. I could be remembering time where the wait flag wasn't set correctly so the shell command finished immediately after launching TextMate.

It seems that even with normal iTerm window mode, the detection is not working because when the prompt function is executed lsappinfo still reports sublime/textmate as the frontmost window. However, by the time terminal-notifier is executed, lsappinfo reports iTerm as the frontmost window, so the notification is only displayed in the sidebar.
Seems to be a matter of milliseconds..

@phatblat I'm experimenting with the iTerm hotkey, but the focus still returns to iTerm when its window is evoked with the hotkey. Anything else special?

Under Preferences > Keys

The last checkbox makes the iTerm Hotkey Window disappear when it loses focus.

@phatblat do you use editw in any other situation besides git, or know any other utilities which open a GUI and wait before continuing? I'm considering disabling done for git and other version control commands.
Also its not clear on to detect editw usage, if you are typing git commit in the terminal.

Also it would probably not work if you have some alias for git commands.. :/

@phatblat I assume you have editw set as your git editor, right?

@phatblat this was fixed in https://github.com/fisherman/done/releases/tag/1.4.0 . Only git is excluded by default, but you can configure it with $__done_exclude. Let me know if you find any other commands which should be excluded by default, or removed from the exclusion.

Awesome! I'll try it out, thanks!


Can't push translations

Add "kingu" in https://hosted.weblate.org/access/vacation-days/#users and I can try to fix it :)

Add "kingu" in https://hosted.weblate.org/access/vacation-days/#users and I can try to fix it :)

Done


Disable auto-open browser for 'graphql playground'

Hi, is it possible to disable auto-opening browser tab each time after graphql playground command?

This might be implemented using a command line argument for graphql playground. @pokorson would you be interested in submitting a PR?

I think there’s also another option. If I remember correctly, CRA manages to simply re-focus the tab if it was previously opened. Regardless of we end up adding the described option or not, this should be implemented as well.

@schickling Can you move that into a separate issue?

@schickling I think the way CRA does it depends on webpack and stuff like live-reload/hot-reload and uses websockets for communication. I think playground just opens a tab with server address

Moved re-focus discussion to #192

@schickling It is annoying when I sometimes need to restart server multiple times and each time new tab appears and is focused. Also would it be possible to skip both opening tab and focus?

I see, that answers my question: I suggest someone creates a PR introducing a flag -server-only which just starts a server without opening the electron app or the browser.

#190 has been merged, this is complete.


Thrown ServerError are not catched by ErrorBoundary

I managed to reduce my current MVP to a reduced part (can't share the whole thing as it is for a private company) while reproducing the issue I'm encountering.
In the following code, with an empty database, findUniqueOrThrow() will throw. This is the purpose of this example. It should be catched by either the local ErrorBoundary or the one defined in root.tsx
export function routeData({ params }: RouteDataArgs) {
  return createServerData$(
    async (id, { request }) => {
      // throw new ServerError("fail"); <-- will lead to same issue
      const test = await prisma.test.findUniqueOrThrow({
        where: { id },
      });

      return test;
    },
    { key: () => params.testId }
  );
}

NotFoundError [PrismaClientKnownRequestError]: No Test found

But in production the error is not catched, therefore kills the node process.
You can reproduce with:

git clone https://github.com/binajmen/solid-server-error.git
npm install
npm run build
npm run start
Visit http://localhost:3000/:lang/:testId/instructions

➜  temp git clone https://github.com/binajmen/solid-server-error.git
➜  temp cd solid-server-error
➜  solid-server-error git:(main) npm install
➜  solid-server-error git:(main) npm run build
➜  solid-server-error git:(main) npm run start

> start
> solid-start start

 solid-start start
 version  0.2.8
 adapter  node

  ➜  Page Routes:
     ┌─ http://localhost:3000/*404
     └─ http://localhost:3000/:lang/:testId/instructions

  ➜  API Routes:
     None! 👻

🔌 setting up prisma client to file:///dev.db
Listening on port 3000
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

NotFoundError [PrismaClientKnownRequestError]: No Test found
    at /Users/Projects/temp/solid-server-error/node_modules/@prisma/client/runtime/index.js:34217:15
    at async /Users/Projects/temp/solid-server-error/node_modules/@prisma/client/runtime/index.js:34215:20
    at async Object.$$serverHandler0 (file:///Users/Projects/temp/solid-server-error/dist/server.js:23973:16)
    at async execute (file:///Users/Projects/temp/solid-server-error/dist/server.js:23747:17)
    at async resourceFetcher (file:///Users/Projects/temp/solid-server-error/dist/server.js:23371:22) {
  code: 'P2025',
  clientVersion: '4.8.0',
  meta: undefined,
  batchRequestIdx: undefined
}

Node.js v18.8.0

Probably the fix in #366 also fixes this issue? node server no longer crashes and shows 404 Page not found after the fixed.

Will look into this, was away for holidays.

I should be fixed with changes from issue #366. After apply that changes it able caught the error.

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


Show traces for deeply nested reconciliation relationships

closed by #46

@jpellizzari @stefanprodan Can you close this one please?


Could not find a declaration file for module 'reaflow', when using typescript v5, with moduleResolution set to "bundler"

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x ] Bug report - I have check opening issues, and could not find related issue on this matter
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior
Importing components from "reaflow" in react project, with typescript 5.1.3 in vscode workspace, and "moduleResolution" set to "bundler" in tsconfig.json, vscode would throw a Could not find a declaration file for module 'reaflow'.
Inspecting the package.json of "reaflow" in the node_modules, in fact missing the "types" field under "export". See below:

Expected behavior

Importing components from "reaflow" should not throw any errors in vscode.
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

This bug prevent the project being able to build (at least without "noImplicitAny"; false in tsconfig.json)
Environment

Libs:
- react version: 18.2.0
- reaflow version: 5.2.0

For Tooling issues:
- Node version: v18.15.0

Others:
Vscode version: 1.80.0
Workspace typescript version: 5.1.3

Apparently this can't be fixed with patch-package too as it doesn't comparing package.json. Anyone has any work-around? (Also thank you @amcdnl for looking into this)

@JimmyNair - The types export is there - https://github.com/reaviz/reaflow/blob/master/package.json#L27

@JimmyNair - The types export is there - https://github.com/reaviz/reaflow/blob/master/package.json#L27

Hi @amcdnl , I did see the 'types' exports in the source code. However it is not reflected in the output package.json, which is being downloaded.
Please see attached screenshot from npm. As you can see it's not part of the exports.

Interesting - OK let me investigate

This has resolved in version 5.2.2. Thanks @amcdnl


jansson and json-c  libraries have symbol conflicts

Describe the bug
In the application, we are using a shared library which is using json-c for its internal purpose. Later our application required to use a third party library, but its internally used jansson inside it for its functionality. Unfortunately when we run the application , it leads to memory corruption and process crashed.
Both of these libraries have multiple APIs with same name but different signature.
Due to this, there is a memory corruption that resulted in crash.
The following APIs are available in both json-c and jansson libraries with the same name:
json_object_get
json_object_iter_next
Steps To Reproduce
This issue can easily reproduce with the following way:

Application linked to libjson_c_lib.so and libjansson_c_lib.so. Both of these are wrapper libraries are using json-c and jannson internally.

libjson_c_so wrapper library linked to libjson-c.so

libjansson_c.so wrapper library linked to libjansson.so.

Tried statically linked one of the library but its not helped here. If we statically link jansson to wrapper library,  crash resolved but json-c calls failed especially json_tokener_parse().
Please see below the crash dump:
(gdb) bt
#0  0x00007ffffea35428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ffffea3702a in __GI_abort () at abort.c:89
#2  0x00007ffffea777ea in __libc_message (do_abort=do_abort@entry=2,
fmt=fmt@entry=0x7ffffeb90ed8 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
#3  0x00007ffffea8037a in malloc_printerr (ar_ptr=, ptr=,
str=0x7ffffeb8dcaf "free(): invalid pointer", action=3) at malloc.c:5006
#4  _int_free (av=, p=, have_lock=0) at malloc.c:3867
#5  0x00007ffffea8453c in __GI___libc_free (mem=) at malloc.c:2968
#6  0x00007ffffe7f8549 in json_delete_object (object=0x603010) at value.c:78
#7  json_delete (json=0x603010) at value.c:935
#8  0x00007ffffedd091e in json_decref (json=0x603010) at /usr/local/include/jansson.h:112
#9  0x00007ffffedd0b14 in jansson_c_lib_init (buffer=0x7ffffffed250 "{\n"name":"vysakh",\n"age":32\n}\n")
at /home/vysakhav/exper-library-conflict/jansson_c_lib.c:44
#10 0x0000000000400c0d in main () at /home/vysakhav/exper-library-conflict/app.c:58
(gdb)

This is unfortunate, but I'm afraid nothing can be done in the jansson side to fix this problem.
There are a few ways to fix it in your application:

Change your own shared library to use jansson instead of json-c
Ship the json-c source with your shared library, and modify it by renaming the conflicting functions
Ship the jansson and the third party library source with your application, and rename the conflicting functions in both

This should be fixed by symbol versioning I think? (https://github.com/akheron/jansson/pull/540)

Correct!


GDNativeLibrary editor should let you filter platforms with checkable entries

Godot version:
3.1.1 and 3.2 master (d483a85)
OS/device including version:
Mageia 7 x86_64
Issue description:
When you create a GDNativeLibrary resource, a specific editor is shown. It has a drop-down list to select platforms which should be visible, but it's all or nothing as it uses exclusive radio buttons:

This popup menu should use checkboxes so that you can select the platforms you want to see.
Steps to reproduce:

Open project
On Inspector, click "Create new resource"
Select GDNativeLibrary
Uses drop-down list to filter platforms, see that you can only filter "All" or any single platform

Working on it


regression: spell-checking of browser cannot be used anymore

create a new motion
save it and now edit it inline
misspell a word purposely

result: the spell-checker of your browser (in my case Firefox) will underwave the misspelled word correctly:

but I cannot right-click anymore one the misspelled word to correct it or to set the language of the text. This is a regression to the former text editor used by OS in 2.0 and 2.1 beta 2.

I am not sure if disabling the editors' context menu is the best solution. Maybe CKeditor also provides a spell-checker? If not, I cannot decide if e.g. the editor's context menu for tables is more useful than the spell-ckecking. So all I want to say is I don't insist in fixing this bug, maybe there are good reasons for a WONTFIX. However, spell-checking is in my opinion a feature that is necessary for motion texts.

I also think about this priority and I decided:
Having a working spell checking (in known browsers context menu) is more important and useful than a special list feature context menu entry (e.g. for changing bullet point type circle/square) or table design (remove/add new line). Both cases are very rarly (special lists and tables are not typically in motions). And there is a workaround to do this in HTML code view of CKEditor.
So I prefere to make spell checking working with browsers context menu for 2.1!

Confirmed fixed.


The provided value for the input parameter 'scope' is not valid

I followed the guide on https://docs.microsoft.com/en-us/azure/active-directory/develop/tutorial-v2-android
But the API just gives me errors no matter what
If I login via my personal account I get this error:
com.microsoft.identity.client.exception.MsalServiceException: invalid_scope;The provided value for the input parameter 'scope' is not valid. The scope 'File.Read openid offline_access profile' does not exist.
If I login via my work account I get this error:
com.microsoft.identity.client.exception.MsalServiceException: invalid_client;AADSTS650053: The application '' asked for scope 'File.Read' that doesn't exist on the resource '00000003-0000-0000-c000-000000000000'. Contact the app vendor.
No matter what I do it won't change fix the error

Found the error in the guide
Its not File.Read but Files.Read
That a really bad guide that have more than one error in it xD


[Pager] CurrentPage is wrong after dataset change

Describe the bug
If my dataset consists of A, B, C and I tap a button on page B which re-orders the dataset into B, A, C; I will continue seeing B and scrolling right shows A as expected. However the currentPage will still point to 1, immediately upon touching/scrolling the pager, it will update to 0. This happens using a HorizontalPager, although I would guess that the same thing applies for VerticalPager.
To Reproduce
I think the description makes this clear, let me know if you want any additional information!
This is what my logs look like. A SideEffect logs currentPage, and a snapshotFlow captures and logs the selected page whenever it changes.
(dataset is A,B,C)
Page: 0
Selected 1
Page: 1
(dataset changes to B,A,C)
Page: 1
Page: 1
(when I start scrolling the pager, I immediately see this call)
Selected 0
Expected behavior
The currentPage should be 0 since thats the page Im looking at.
Environment:

Android OS version: API 30
Device: Emulator, Pixel 3a
Accompanist version: 0.20.0

Additional context
A temporary workaround is to scroll to the selected page whenever it changes.
LaunchedEffect(currentPage) {
    if (currentPage != state.targetPage) {
        state.animateScrollToPage(currentPage)
    }
}

This still happens even using keys. When I open screen and add one item, so data looks like [ C ], I have currentPage value = 0. Now I update data set to [A, B, C, D, E, F], and current page is still 0. currentPage value is set correctly after scrolling. Is there a way to force pager to recompute it's current page?

@qbasso Please try the workaround I wrote about in my post above. It should fix the issue, at least until an official one is available :)


Reduce git repo size by cleaning up *.mmdb commits

The repo size was 79mb so I cleaned it up, now its ~100kbs
I ran this tool on the repo:
https://rtyley.github.io/bfg-repo-cleaner/
Here's my console output, it shows the deleted files mid-way through:
Alessandros-Mac-Pro:Desktop Diatta$ git clone --mirror https://github.com/ALMaclaine/node-geolite2.git
Cloning into bare repository 'node-geolite2.git'...
remote: Enumerating objects: 52, done.
remote: Counting objects: 100% (52/52), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 242 (delta 22), reused 41 (delta 20), pack-reused 190
Receiving objects: 100% (242/242), 75.44 MiB | 14.60 MiB/s, done.
Resolving deltas: 100% (108/108), done.
Alessandros-Mac-Pro:Desktop Diatta$ java -jar bfg-1.13.0.jar --delete-files *.mmdb node-geolite2/

Using repo : /Users/Diatta/Desktop/node-geolite2.git

Found 13 objects to protect
Found 7 tag-pointing refs : refs/tags/v1.1.0, refs/tags/v1.2.0, refs/tags/v1.2.1, ...
Found 8 commit-pointing refs : HEAD, refs/heads/key-file, refs/heads/key-sources, ...

Protected commits
-----------------

These are your protected commits, and so their contents will NOT be altered:

 * commit 5927e3d7 (protected by 'HEAD')

Cleaning
--------

Found 70 commits
Cleaning commits:       100% (70/70)
Cleaning commits completed in 298 ms.

Updating 14 Refs
----------------

	Ref                       Before     After
	---------------------------------------------
	refs/heads/key-file     | bf5c6635 | ad1b2dd1
	refs/heads/key-sources  | 2de90b7d | 8e8a9f6e
	refs/heads/master       | 5927e3d7 | fc7d5ca5
	refs/heads/mod-lfs      | dc4d074d | 856c2708
	refs/heads/runk-patch-1 | 6c450634 | 80300272
	refs/tags/v1.1.0        | 9fb5dfd5 | 21b5fb09
	refs/tags/v1.2.0        | 3f87614b | b9188692
	refs/tags/v1.2.1        | 7c9ecb66 | bc8bf54b
	refs/tags/v2.0.0        | ed1bec6a | dd179c8e
	refs/tags/v2.0.1        | 0acf8158 | ff1a5ddc
	refs/tags/v2.0.2        | a698ec83 | c5ff23a7
	refs/tags/v3.0.0        | f25cae8c | f02f0207
	refs/tags/v3.1.0        | 16b6bc6d | d19d2c16
	refs/tags/v3.2.0        | 7803435b | 12b2de05

Updating references:    100% (14/14)
...Ref update completed in 36 ms.

Commit Tree-Dirt History
------------------------

	Earliest                                              Latest
	|                                                          |
	.DDDDDDDDDDDDDDDDDDDDDmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm

	D = dirty commits (file tree fixed)
	m = modified commits (commit message or parents changed)
	. = clean commits (no changes to file tree)

	                        Before     After
	-------------------------------------------
	First modified commit | a328474f | 9b229f33
	Last dirty commit     | cd5b10d2 | bc6fae58

Deleted files
-------------

	Filename                Git id
	--------------------------------------------------------------
	GeoLite2-ASN.mmdb     | 42a917e9 (5.7 MB)
	GeoLite2-City.mmdb    | 50635e32 (72.6 MB), d2ee76f2 (60.8 MB)
	GeoLite2-Country.mmdb | 0c90fc15 (3.2 MB), 3168acaf (18.4 MB)

In total, 98 object ids were changed. Full details are logged here:

	/Users/Diatta/Desktop/node-geolite2.git.bfg-report/2020-09-03/18-10-04

BFG run is complete! When ready, run: git reflog expire --expire=now --all && git gc --prune=now --aggressive

Alessandros-Mac-Pro:Desktop Diatta$ cd node-geolite2.git
Alessandros-Mac-Pro:node-geolite2.git Diatta$ git reflog expire --expire=now --all && git gc --prune=now --aggressive
Enumerating objects: 235, done.
Counting objects: 100% (235/235), done.
Delta compression using up to 12 threads
Compressing objects: 100% (226/226), done.
Writing objects: 100% (235/235), done.
Building bitmaps: 100% (70/70), done.
Total 235 (delta 121), reused 43 (delta 0)
Computing commit graph generation numbers: 100% (70/70), done.
Alessandros-Mac-Pro:node-geolite2.git Diatta$ git push
Enumerating objects: 235, done.
Writing objects: 100% (235/235), 75.38 KiB | 75.38 MiB/s, done.
Total 235 (delta 0), reused 0 (delta 0)
remote: Resolving deltas: 100% (121/121), done.
To https://github.com/ALMaclaine/node-geolite2.git
 + bf5c663...ad1b2dd key-file -> key-file (forced update)
 + 2de90b7...8e8a9f6 key-sources -> key-sources (forced update)
 + 5927e3d...fc7d5ca master -> master (forced update)
 + dc4d074...856c270 mod-lfs -> mod-lfs (forced update)
 + 6c45063...8030027 runk-patch-1 -> runk-patch-1 (forced update)
 + 9fb5dfd...21b5fb0 v1.1.0 -> v1.1.0 (forced update)
 + 3f87614...b918869 v1.2.0 -> v1.2.0 (forced update)
 + 7c9ecb6...bc8bf54 v1.2.1 -> v1.2.1 (forced update)
 + ed1bec6...dd179c8 v2.0.0 -> v2.0.0 (forced update)
 + 0acf815...ff1a5dd v2.0.1 -> v2.0.1 (forced update)
 + a698ec8...c5ff23a v2.0.2 -> v2.0.2 (forced update)
 + f25cae8...f02f020 v3.0.0 -> v3.0.0 (forced update)
 + 16b6bc6...d19d2c1 v3.1.0 -> v3.1.0 (forced update)
 + 7803435...12b2de0 v3.2.0 -> v3.2.0 (forced update)

Let me know if you're willing to accept this change and then I'll do the other PR regardless.
Thanks

I read the Travis logs and it's failing from a missing license key, is that something I'm supposed to do?

Hey! Thanks for the PR.
The diff looks quite weird - e.g. it shows changes to .travis.yml etc - do you know why?

Pretty sure it re-writes all the commits without the large files.
You can see at the top it consists of 65 commits, which is about how many commits the repo has right now.
I'm not sure if its going to tack them all on, giving ~130 commits or leave it with just ~65.
I spot checked several files and it all looks good.
Up to you whether you think it's a worth while trade off but I thought it seemed like a good idea since a perfect git history is of questionable value in a project this small.
Let me know what you think and if I should do anything.

Okay, let's get it into master and I'll figure what's the deal with failing build

:tada: This PR is included in version 3.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Thanks for the contribution 🙇
Not 100% sure what was the problem with the build, it's quite puzzling.

Awesome, I'll work on the next part now.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug]: Tray icon menu hardcoded to Simplified Chinese

解决方案检查

[X] 我已阅读常见问题(https://lyswhut.github.io/lx-music-doc/desktop/faq)，并没有找到解决方案
[X] 我已搜索issue列表(https://github.com/lyswhut/lx-music-desktop/issues?utf8=✓&q=)，并没有发现类似的问题

预期行为
The tray icon menu text should follow the language settings in the software. For example, if the language in the software is English, the tray icon menu text should also be in English.
实际行为
Regardless of the language, the tray icon menu text is in Simplified Chinese.
Lx Music 版本
2.7.0-beta.0
最后正常的版本
No response
操作系统版本
Windows 11, version 23H2
附加信息
The tray icon menu text displays very poorly when the display language of Windows is set to English (or another language).
I have looked at the code within the repo and the related code seems to have it hardcoded to Simplified Chinese.

Added i18n to v2.7.0


Enable "hide/collapse graph" on 0 relationships option

the pref has been added but it needs some wiring to make it work.

Pull Requests:

https://github.com/Senzing/sdk-components-ng/pull/17


Update to WEB_ADDR documentation.

Fixes #665
Updates the documentation in the GUI for WEB_ADDR on main page for clarity.

Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

[x] Documentation has been updated to reflect change.
[ ] New code has tests, and affected old tests have been updated.
[ ] All tests and CI checks pass.
[x] Ensured the pull request title is descriptive.
[ ] Conda lock files have been updated if dependencies have changed.
[ ] Attributed any Generative AI, such as GitHub Copilot, used in this PR.
[x] Marked the PR as ready to review.

How it appears in the GUI.

Changes addressed, also removed duplicate entry for WEB_DIR in the same rose-meta.conf as a clean-up.


Remove namespace prefix from the XML Object

Do not allow to specify the namespace prefix for the XML object. Only namespace URIs should be used to identify the namespaces used.
The prefix functions only as a placeholder and has a meaning exclusively in the context of the XML document
Namespaces in XML 1.0 (Third Edition)
https://www.w3.org/TR/REC-xml-names/#ns-qualnames

I have submitted this for a 3.2.0 branch. But maybe, if there is a consensus, this should be backported to the older branches.

@saper Thanks for your efforts here. I'm afraid we cannot make backwards-incompatible changes such as removing a field in a minor release (3.1 was an exception made due to the pain caused by conflicting with the JSON Schema standard, and not an exception we want to repeat).  This is something that can be taken into account in 4.0 a.k.a. Moonwalk.  We have not yet gotten into how we plan to handle XML in that release.

Thank you, that is what I initially thought we should not do, but I saw a couple of less obscure things removed and decided to file this. What about just adding the comment not to use this thing at all? If the attribute is present in the OAS, the tools SHOULD simply ignore it.
(I am still in search of the tooling that supports namespacing of the XML-Object but I could not find any, yet - pointers welcome).

I do have a pretty obscure use case for this though. I have a commercial application that can handle both OpenAPI and SOAP requests.
As it turns out, the some low level HTTP errors (401, 404, 500, and others)  do return a text/xml SOAP response. So I have to tell the clients to expect, among application/json higher-level errors,  a text/xmlresponse with a SOAP Fault message it.
It seems perfectly possible to model SOAP Fault using the XML Object feature; but namespace prefix must be ignored, since in theory random prefixes can be returned (or automatically generated ones like ns1, ns2, ...).

@saper that use case is quite reasonable!
Having looked into this more deeply, I think there might not really be a problem here.  The lack of tooling support for the XML Object (which you noted) makes it hard to say for certain in practical terms.  I know it gets used, but it might be used more by custom tooling than major vendors.  I'm really not sure.
Anyway....
The way the OAS documents the XML Object seems to mostly be about how to use it to serialize JSON values to XML.  In that direction, it's perfectly valid to specify namespaces and prefixes.
The OAS does not explicitly state any parsing requirements or validation behavior.  The most obvious reading is to require the prefixes to match.  But the XML Object is described as "metadata" rather than validation.  Arguably, the W3C's SHOULD directives here could be taken to mean "the prefix field is only used on serialization, and not on parsing, as the specific prefix used does not impact parsing."

Discussed this topic in the TSC meeting and generally agreed that we do not support removing the prefix field. However a separate PR can be created to clarify that the prefix can be ignored when parsing.


Handle Already Bound Port

When trying to start a new listener if the port is already bound an error is thrown and not caught.

This no longer throws an error, but does causes the process to end. This means it will try to restart up to the maximum number of retries.
Changes to this behavior, in order to prevent the restart, will be handled in the resolution of #2.


implement mix.when()

Hi, this adds a small DX/QOL improvement: mix.when(). Mix has a wonderful, fluent API, and it often feels a little janky to me to break out of that when needing to do some conditional configuration. I hope that this helper will reduce that a little bit. This is of course inspired by Laravel's various ->when($condition, $callback) helpers.
I added mix.when() to the stock webpack.config.js, but I wasn't sure if/where to add it to docs. If you could suggest the right place to add some docs, I'd be happy to do so. Oh, and this also includes a very minor docblock fix in Api.js.
Example
From one of my own webpack.config.js:
mix.js('resources/js/app.js', 'public/js')
    .sass('resources/sass/app.scss', 'public/css')

if (process.env.NODE_ENV !== 'bundle') {
    mix.extract(['vue', 'vuex', 'axios'])
}

if (mix.inProduction()) {
    mix.version()
}

Which this PR, this could be rewritten as:
mix.js('resources/js/app.js', 'public/js')
    .sass('resources/sass/app.scss', 'public/css')
    .when(
        process.env.NODE_ENV !== 'bundle',
        mix => mix.extract(['vue', 'vuex', 'axios'])
    )
    .when(
        mix.inProduction(),
        mix => mix.version()
    )

Thanks!

Nice - thanks!


Change pgdg repo, bump actions/checkout

checkout@v1 -> checkout@v3
switch from testing pgdg repo to the main one + import key

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 88.464%

Files with Coverage Reduction
New Missed Lines
%

postgres_stats.c
2
79.17%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1687

Relevant Lines:
1907

💛  - Coveralls

:+1:


fixed requiring package.json

https://github.com/pebble/has-own/issues/2

Thanks! Merged and released as 1.0.1. See https://github.com/pebble/has-own/issues/2#issuecomment-566648442


ver. 10.0.19041.3636 [not supported]

having trouble unfortunately

using windows 10 pro btw

Duplicated with https://github.com/stascorp/rdpwrap/issues/2381 , see https://github.com/stascorp/rdpwrap/issues/2381#issuecomment-1782856121 for the fix.

Duplicate of https://github.com/stascorp/rdpwrap/issues/2381


#1040 Support kind and size options in action buttons

Fixes #1040

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I know this isn't new but can we fix the tooltip on these buttons.

I'm not sure if we need something for this case.  There should be some padding under the button.

Fixed button tooltip and added 16px bottom padding for action buttons under control-items.


update pvm memory implementation

accesibility is by page size Zp, may need to remove MemorySections, and rewrite read write related code

new requirements

accesibility is by page size Z_p, this need to be enforced (eq 4.24 4.25 in 0.5.0)
consider inner pvm host-call memory access cases, check if need to change anything

page map

need a new pagemap property to record page access
better to have O(logn) or better
option: 2 BitArray, const space, O(1) for single page, O(k) for k affected pages
option: interval tree, O(logn + k) for n intervals

consider memory allocations

standard program allocation

allocation is still done in init, no other way to allocate, and each zone is continous, so keep MemorySection for standard program, which allow O(1) chunk search

general program allocation (used in inner pvm and test vectors)

allocation could be in init, or host-call for inner pvm
current impl is an array of chunks, search and update using binary search is O(logn + k) for k chunks, insert (possible by zero host call) is O(n) which can be improved
possible options

interval tree: allow search, updateOrInsert with O(logn + k), and do merge on allocation if possible to reduce tree size

other notes

note sbrk does not modify memory


Capture more corner cases in benchmark name parsing

For example:
output-jsonnet-jsonnet::internal:: in 2024-02-11-64-dg-comparison
The name is incomplete because of having a ( in the namespace, and our parser mistook that as the ( for params:
jsonnet::internal::(anonymous namespace)::Interpreter::builtinExtVar(jsonnet::internal::LocationRange const&, std::__1::vector<jsonnet::internal::(anonymous namespace)::Value, std::__1::allocator<jsonnet::internal::(anonymous namespace)::Value> > const&)

Fixed by

Avoided by #91


merge the two docker_binaries into a single one, the first was overrided

Signed-off-by: Thomas Labarussias<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:
The falco_rules.yaml contained 2 lists for docker_binaries, without an append, the first was totally override. I merged them into a single one.

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif, loresuso
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval by writing /assign @andreagit97 in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b8c4733d083d72660a4be7aad9a78551aff2c333

This may fix some regressions introduced by https://github.com/falcosecurity/rules/commit/9d36827c910e1a79f5097955543492f5b6a31300
@darryk10 @loresuso @LucaGuerra can we double check pls?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr, loresuso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


2022 11 28 redirect tests

Testing build / redirect tests.

(next: gonna sync staging branch with main & redo this PR)


feat: SearchWithin for Express

Description
This PR implements SearchWithin with Express support.
To-do list

[x] Validate design differences

[x] Space between X and Menu in Express
[x] Search icon positioning in Express
[ ] Focusability of Menu

[x] This pull request is ready to merge.

After talking to @badimon, this PR is in a holding pattern -- we need to wait and see what the fate of SearchWithin is before updating it.

Closing this as we're set to deprecate SearchWithin.


Changing the timer bell Sound

I think that the sound 【効果音】チーン 一回 高音ver.【仏具：お鈴】 set default is strange.
I changed the timer bell sound to this 呼び出しベル.
How do you think that?

It's sound like better.
Could you make a Pull request?

Ok, I try to do.

Working on PR #2.


tinyrave based mode

code is complete but is not compatible with tinyrave so needs a better name, name needs to be chosen now to prevent compatibility issues in the future

added as Funcbeat


Laplace transforms and properties added

Related Issue: #500
I have added all the important laplace transforms and properties used for laplace transformations

@RaveenaBhasin  Could you please add some screenshots showing the changes? After that, we can resolve the merge conflicts :)

@shrey27tri01 @sairish2001 Please review it


Contribute page - How to Create an Issue header not needed

Unless you are going to link to it, the How to Create an Issue is not really necessary and just creates visual clutter. I would recommend just deleting it and leaving all of that text under the Create an Issue header.

Deleted it and have pushed the fix to QA.


Fix: gerrit-required-info-yaml-verify fetch-depth

As the point of the workflow is to verify changes to INFO.yaml, and the logic skips the check if that file is not edited, and "git diff --name-only HEAD~1" is used to detect edits, the default fetch-depth of lfit/checkout-gerrit-change-action (v0.9) of 1 is not enough.
Fix by applying check-depth 2,
also add a comment explaining why.

One more place to edit.


[Enhancement]: Add a reset score button in the game Rock Paper Scissors

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
A reset score button can be added which will reset all the scores back to zero.
Describe the solution you'd like
I can add a button which on click will reset the scores and start from a new play.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @meetarora10 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @meetarora10 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Add kinova mujoco config

Thanks David! Are you planning on making a PR to Menagerie that adds the Kinova model? I am more than happy to help with that if we want to discuss this further offline.

@adlarkin Yes! I'm interested in working on getting this into Menagerie. Let's sync on this next week


CC71738: Escaping components names to avoid broken format in translation pages

Hello, @rick-anderson,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: Some of the "folder names" inside <> are not displaying well in localized pages, and also those terms are not blocked for localization.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.
Many thanks in advance.

@guardrex  I think I prefer code-fencing. @v-maudel  thanks for the PR. We'll try to do this in the future.

To be consistent with other paths, are we going to do the whole path?

@v-maudel  I though "view_component_name" "view_name" should be localized.
What you have is perfect for english. Would the following be better for loc?
/Views/{controller name}/Components/{view component name}/{view name}

Thanks @guardrex and @Rick-Anderson
If those names should be translated, maybe we can adopt the < and > HTML or maybe escaping the greater than and lower than symbols with backlashes.
The thing is for some reason the actual syntax is blocking for translation some strings but not all of them.
Regards,

@v-maudel Are braces a problem for localization ... { } ... ? Will the following localize? ...

Here is a sentence with a link, /Views/{controller name}/Components/{view component name}/{view name}, that isn't code-fenced.

Next ? ... Any chance that the engineers could provide something equivalent to the code-fenced CSS style that will still allow localization? Something that produces the same effect today as ...

Here is a sentence with a link, <code>/Views/{controller name}/Components/{view component name}/{view name}</code>, in-text and not code-fenced.

I know we don't want HTML tags. I'm just asking about producing a similar CSS style as code-fenced content that would localize.

@nokura What's the best way to get "controller name", "view component name", and "view name" localized in the following path
/Views/{controller name}/Components/{view component name}/{view name}
Everything inside of {} should be localized.

Hi @nokura and @sonja,
can you please look into this?
Best regards
Cc: @Rick-Anderson

Hi @nokura and @Sonja,
can you please look into this?
Best regards
Cc: @Rick-Anderson

HI @Rick-Anderson ,
@guardrex approach seems to be effective, could you please take a look and let us know?
Thanks.
Cc: @nokura

I've put in a few PRs with this format, and this approach is looking very good to me.
I'll leave this for @Rick-Anderson, @scottaddie, and @tdykstra to let me know if this is what I should do going forward. Let me know if I should keep going with it.

@guardrex This approach looks good to me.

@JasonCard please review what we're doing.


Initial parameter in HybridBlock.

Hi,I am trying build a net using HybridBlock, but I got trouble in initial parameters.
My codes are as follows:
class AttentionPartsCRF(gluon.HybridBlock):
    def __init__(self,num, lrnSize, iterSize, usepart, **kwargs):
        super(AttentionPartsCRF, self).__init__(**kwargs)
        with self.name_scope():
            self.att = AttentionIter(lrnSize=self.lrnSize,iterSize=self.iterSize)
            self.att2 = []
            self.conv = []
            for i in range(num):
                self.att2.append(AttentionIter(lrnSize=self.lrnSize,iterSize=self.iterSize))
                self.conv.append(gluon.nn.Conv2D(1,kernel_size=1,strides=1,padding=0))

where AttentionIter is an another sub module I build.
I use a list to save the net I build, but When I initial the  AttentionPartsCRF net.I found that I didn't initial the net in the list.
So how can I solve the problem ?Because I don't know the value num is.So I can't build the net one by one like this:
self.AttentionIter1 = AttentionIter(lrnSize=self.lrnSize,iterSize=self.iterSize)
self.conv1 = gluon.nn.Conv2D(1,kernel_size=1,strides=1,padding=0)

How do you intend to use those two lists?

@apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage.
For general "how-to" questions, our user forum (and Chinese version) is a good place to get help.

Pending response from asker for some time.  Assuming this issue can be closed.
Questions are answered faster on: https://discuss.mxnet.io/
Please reopen if necessary.


Revert "Remove mixin so we can roll Google3 (#22819)"

This reverts commit c689c97d0579d2a215034359a3cbcdc61173d2ab.
The Dart analyzer in Google3 has been upgraded so we won't need this.

LGTM


All Supported Versions mistake in Accelerated Database Recovery

The ADR feature is new since SQL Server 2019, and yet the documentation says "SQL Server (all supported versions)".
This is a misleading mistake because it would imply that ADR is also available in SQL Server 2012, for example.
Please fix.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98d6d147-a7a7-cd75-13fb-4f4f72a16a15
Version Independent ID: bb4f71b0-3103-06af-0560-e28860c752bc
Content: Manage accelerated database recovery - SQL Server
Content Source: docs/relational-databases/accelerated-database-recovery-management.md
Product: sql
Technology: backup-restore
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

Hi @EitanBlumin , thanks for bringing this to our attention! I have processed a change to update this typo and it should be live later this week.
I'm going to close out this Git Issue but please feel free to comment should you need anything further.
Thanks again for improving our documentation and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team

Thank you, Masha.
On the same topic, would it be possible to clarify please whether ADR is supported on SQL managed instances?
We tried to activate it yesterday and got an error saying the syntax is not supported or something like that.

Hi @EitanBlumin , thanks for reaching out once more! ADR is enabled by default on SQL Managed Instance and cannot be disabled - thus the commands will fail :)
Thanks!
Masha from the SQL Docs team

I see, thanks!
(is that mentioned anywhere in the documentation? if not, it probably should)

Hi @EitanBlumin , thanks for the suggestion! I added it to the following doc: https://docs.microsoft.com/en-us/azure/azure-sql/accelerated-database-recovery
The change should be live later this week :)
Thanks again for helping improve our documentation!
Masha from the SQL Docs team


Yices2 interface for Boogie.

Use with: /proverOpt:SOLVER=Yices2 /useArrayTheory
Works for unquantified fragments, e.g. Arrays + Arithmetic + Bitvectors, and can be more efficient than other solvers.

I think this would be a great addition to Boogie, and it looks good to me.
But someone else should take a look as well before we merge it.
@bkragl maybe? Or @shuvendu-lahiri?

Generally looks good to me and works for a minimal example, but I have a few comments.

What is a good set of benchmarks to try? The examples I was working with all have quantifiers.

I guess /useArrayTheory is needed to not get the quantified array axioms injected. However, I'm not sure what else this option does, since it is meant to enable Z3's native "combinatory array logic"/"generalized array theory" and work together with the :builtin attribute. For example, I get a crash for Test/generalizedarray/Maps.bpl.

Is it the case that Yices2 does not work well with some Boogie features? For example, Field/ref in Test/bitvectors/bv4.bpl and Test/bitvectors/arrays.bpl, or polymorphism in Test/bitvectors/bv5.bpl. I get a crash for those examples.

Test/textbook/DutchFlag.bpl has quantifiers and therefore there is rightfully a prover error in the output, but the second line seems like some incompatibility:

Prover error: quantifiers are not allowed in logic ALL
Advisory: Partition SKIPPED because of internal error: unexpected prover output: The given key '579' was not present in the dictionary.
Test/textbook/DutchFlag.bpl(15,11): Verification inconclusive (Partition)

Boogie program verifier finished with 0 verified, 0 errors, 1 inconclusive

We only use Yices2 on problems that reduce to bitvectors and
(non-generalized) arrays, e.g. software BMC. On such examples Yices2 can
sometimes perform much better. I can dig out some simple examples, but I'm
not sure this would be useful. Zvonimir might have a better idea.
I don't know about the extended Boogie features but anything that requires
the following will not work:

quantifiers,
generalized arrays
datatypes

I looked into bv4.bpl for example and, although I don't know what the
meaning of a "Field" is, if I look into the SMT log for Z3, it reduces to
quantifiers so that is not supported.
Improving the error handling would be good, specially for crashing
examples. I don't know enough about Boogie to fix that.
Cheers, Dejan
On Mon, Oct 22, 2018 at 10:54 AM Bernhard Kragl<EMAIL_ADDRESS>wrote:

Generally looks good to me and works for a minimal example, but I have a
few comments.

What is a good set of benchmarks to try? The examples I was working
with all have quantifiers.
2.
I guess /useArrayTheory is needed to not get the quantified array
axioms injected. However, I'm not sure what else this option does, since it
is meant to enable Z3's native "combinatory array logic"/"generalized array
theory" and work together with the :builtin attribute. For example, I get a
crash for Test/generalizedarray/Maps.bpl.
3.
Is it the case that Yices2 does not work well with some Boogie
features? For example, Field/ref in Test/bitvectors/bv4.bpl and
Test/bitvectors/arrays.bpl, or polymorphism in Test/bitvectors/bv5.bpl. I
get a crash for those examples.
4.
Test/textbook/DutchFlag.bpl has quantifiers and therefore there is
rightfully a prover error in the output, but the second line seems like
some incompatibility:
Prover error: quantifiers are not allowed in logic ALL
Advisory: Partition SKIPPED because of internal error: unexpected prover output: The given key '579' was not present in the dictionary.
Test/textbook/DutchFlag.bpl(15,11): Verification inconclusive (Partition)
Boogie program verifier finished with 0 verified, 0 errors, 1 inconclusive
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/boogie-org/boogie/pull/99#issuecomment-431859108, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABafRKuznCqRVEOVgSnkyev88WM18IqCks5undwigaJpZM4VmiaN
.

@zvonimir, @bkragl : Shall I approve this PR?

I guess we should merge it, which will then give a chance for us and others to play with it, which will hopefully also lead to improvements and fixes.

Yes. I think it can be merged. Maybe the README.md file could be updated to mention the experimental Yices2 support (and under which conditions it can be expected to work/not work).


RFC: Custom Checkout

I'm thinking about having a fully custom checkout page for this project.
Didn't want to start working on a POC before having a talk about heuristics with the core team of the project.
There are three main topics that come to my mind right now:
1. Checkout data hooks: Based on what I've been from BigCommerce, they have a Checkout SDK to pull this off, so it shouldn't be hard to build custom hooks on top of that. But at the same time, they might be thinking about adding hooks like those to their own hooks repo, which is the kind of information I don't have access to.
2. Thinking beyond BigCommerce: I saw there's already some work being done to support multiple providers, so I'd like to know how would that affect an effort like this one.
3. Page UI: was there any mockup or version of the checkout page on the designs that were made for the initial version of the Commerce Kit?
@okbel @lfades Thoughts?

@marbiano We did have some mockups but there were limitations on custom checkouts with BC, mostly related to security, therefore we went for the full checkout using an external page handled by BC.
@becomevocal any thoughts here?

@lfades yeah the most custom form of checkout where you manage your own payment requests puts the app in scope of PCI compliance. We support that method, it's just easier for many devs & merchants to have the ecomm platform manage more of that risk.
@marbiano high level the BC platform supports the following checkout methods:

Fully Hosted Checkout, which is customized by modifying the template and settings inside BC (this is what's integrated now and on the Vercel demo store)
Custom Hosted Checkout, which can be implemented by using our Checkout SDK and replacing the default fully hosted checkout (can be accomplished now but is custom work for each site you develop, of course)
Embedded Checkout, which is our hosted checkout initialized inside an iframe on an external page
Completely Custom Checkout, which could be implemented using our Checkout APIs

Would be great to hear more about what flow you are trying to accomplish so we could pair up on the BC side to implement into our data hooks and make sure it works seamlessly here. If it helps to chat it out on our dev slack or discord let our dev advocate @RayeEThompson know and we'll continue the convo there 💪

👋 @marbiano - creating a custom checkout using Open Checkout is an option. At this time your team would own the PCI compliance if you use this code - but it is our BC production application, it is supported and has regular releases/bug fixes. It is React so it should work nicely with Next or give you the inspiration for how to build your solution.
I also think that we are open to having our hooks collaborated on by our dev community. It might just take sometime to open that repo for collaboration. I would love to hear your thoughts on that and how we could work on community collaboration to improve checkout.

@marbiano the data hooks are open-sourced. I will be happy to look at more data hooks for checkout, as well please feel free to reach out to me any time and we can collaborate on them.

@becomevocal thanks for the info!
@RayeEThompson hi! happy to connect, I was just looking at this document but it's not clear to me what would be the best course of action since there seems to be are many options, including the Checkout SDK which looks kind of nice.
I'll join BC's Slack tomorrow so we can discuss via chat. Thank you!

Hey guys just wondering though, where does that leave any devs who want to have a custom checkout without BC? Like for example stripe hosted checkout?

@okbel I think this one is good ;)

@robbieaverill good point! I maybe made it sound a bit too ominous in my previous comment 😅
The completely custom checkout route should be able to skirt the PCI compliance scope if it's using a payment gateway like Stripe to handle secure tokenization on the FE. I've definitely seen that route taken across many ecomm sites across in the past. It's then more of a matter of how you create the order in your downstream systems with a reference to the payment? Makes me think it's worth looking into order specific data hooks as an enabler 🤔

If anyone is interested in how different APIs handle checkout (I hope the idea is for this to not be too BigCommerce-specific), here's Saleor's checkout API (JS SDK): https://github.com/mirumee/saleor-sdk/blob/master/src/api/Checkout/index.ts

Interesting discussion. Bigcommerce usually suggests using Braintree as the payment provider. If you use Braintree, you can use their Drop-In and there is absolutely no issue with PCI whatsoever. There is a wrapper for React available at: https://github.com/Cretezy/braintree-web-drop-in-react -

+1 on this. It is a bit upsetting that (without a lot of effort) we have to leave the BC shop UX live and available to the public in order to easily integrate checkout (e.g. demo store is relying on https://acmedemo.mybigcommerce.com).
Ideally, it would be integrated much like cart and other options. Otherwise, the embedded checkout seems like  a fair compromise so we can at least keep things on the same URL (vercel demo store sends you to https://acmedemo.mybigcommerce.com to checkout).
In both of these options, it would be desirable to shut down all other UX on the https://acmedemo.mybigcommerce.com site so only checkout is being delivered from there.

In #175 there is some discussion around a "feature API" for various providers to opt in or out of various features. I think that in this case, if BigCommerce/Shopify/other providers don't support building checkouts natively into your application, then it could be feature flagged to use an external checkout [status quo] instead (or disable a native checkout which this issue would build). Fully headless platforms could then opt in to using the native checkout (which this issue would build), which would then become the default.
FWIW, I'm happy to help out with the build here!

It looks like there is some kind of native checkout form which can be used from the cart sidebar now. This seems like an interim solution to a native checkout page. @okbel am I correct here? If if so, is a proper solution for this RFC still on the cards?
I'd note that this sidebar is not PCI compliant. Devs would need to replace the credit card information form with Stripe or some other tokenized payment gateway form instead before shipping this kind of thing to production.

Reference PR that added this: https://github.com/vercel/commerce/pull/487

was this feature implemented ??

sorry but...  a webshop frontend that doesn't support customers to check out? How is anyone using node.js commerce at all?

The beauty of this project is that you can fork it and create a custom checkout. You'll need to handle PCI compliance or use a SaaS platform to do it for you (like Stripe).


Preserving this identity (Vue 3) + tweaks

This implements #29, #30, and #31. I'll update this branch as those issues are discussed

BTW - sorry to let this go off the boil. Work has been particularly intense this last 6 weeks. I'm hoping to get some time on OSS again this week.

No worries! It hasn't been blocking so far, the work on our project is still isolated to one experimental branch, so yarn link has been working fine.

Updating the docs has taken a bit longer than expected, so this branch should be ready tomorrow

So I think I can make VueStore in vue 3 work

with any class hierarchy
with full inheritance (e.g. any class extending a VueStore class is fully reactive)
with no extra prototype shenanigans

The one concession it requires is that it doesn't support "dynamic" watches or computed properties, because it the vue store will be injected "at some point" in he hierarchy, it'll only be able to (reliably) scan the prototype, not any values added at runtime.

So doing it that way would be a breaking change, however I can make it fall back to the old behavior when used as a decorator, then discourage using that method in the documentation


Host <IP_ADDRESS>

How to run web on <IP_ADDRESS>

???? what's your question, rvc run on http://localhost:7897/


Revert "Remove mutex around bdk wallet"

This broke several things, will need to figure out how to properly initate the dlc wallet

Code changes look good. For DLC's, I'm guessing it's because of the lack of async traits. Would a fork be in order or could we use std::sync::Mutex just for DLCs?

I think we'll just need to make a copy of the bdk wallet, will see


open recent files info

if i move the file previously opened, rename the file or directory, the app still displays the old path to the file.
the app should verify the file exist before populating the list as well as have a "clear recent file selections" capability.

Clearing is a dupe of #164 (and almost done, but track issue that for when the commit is checked in), but checking file status is in as of build 1090.

File list should be checked when a new tab is created too.


[TF:TRT] Use IEinsumLayer from TRT 8.2

This PR refactors the Einsum converter to use IEinsumLayer which is available in TRT 8.2.

I refactored einsum converter but didn't add this feature

Extended testing, improved validation of equation. This PR depends on #53591, I will rebase it once that is merged.

@tfeher Can you please resolve conflicts? Thanks!


Windows 10 Enterprise Virtual Desktop Edition Version 1903, Build 18362.175 and WebView

A future workaround might be to use Windows Virtual Desktop to run your WebViewControl application through a virtualized desktop on Windows 7, Windows 10 LTSC versions, and other environments where Microsoft Edge (and the WebViewControl) wouldn't otherwise be supported.
Please explain the above statement about Windows Virtual Desktop?. One of our WPF application uses WebView Control and it's not working in Windows 10 Enterprise Virtual Desktop Edition Version 1903, Build 18362.175 ?  This particular edition meets all the criteria for WebView.
Actual exception from event viewer
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Resources.MissingManifestResourceException
at System.Resources.ManifestBasedResourceGroveler.HandleResourceStreamMissing(System.String)
at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet(System.Globalization.CultureInfo, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceSet>, Boolean, Boolean, System.Threading.StackCrawlMark ByRef)
at System.Resources.ResourceManager.InternalGetResourceSet(System.Globalization.CultureInfo, Boolean, Boolean, System.Threading.StackCrawlMark ByRef)
at System.Resources.ResourceManager.InternalGetResourceSet(System.Globalization.CultureInfo, Boolean, Boolean)
at System.Resources.ResourceManager.GetString(System.String, System.Globalization.CultureInfo)
at Microsoft.Toolkit.Win32.UI.Controls.DesignerUI.get_E_NOTSUPPORTED_OS_RS4()
at Microsoft.Toolkit.Win32.UI.Controls.Interop.OSVersionHelper.ThrowIfBeforeWindows10April2018()
at Microsoft.Toolkit.Wpf.UI.Controls.WebView.Initialize()
at Microsoft.Toolkit.Wpf.UI.Controls.WebViewHost.BuildWindowCore(System.Runtime.InteropServices.HandleRef)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5150561a-a399-7d1d-247b-83cfcdbfd7a8
Version Independent ID: a8ad70cc-9fca-2212-80cf-866ad145004d
Content: WebView control for Windows Forms and WPF - Windows Community Toolkit
Content Source: docs/controls/wpf-winforms/WebView.md
Product: community-toolkit
GitHub Login: @mcleanbyron
Microsoft Alias: nikolame

FYI @pagoe-msft

@baskialdensys Please try this in WebView2 now as the Webview has transitioned to WebView2. It should be fixed and if you are still seeing this issue then try filing an issue in the WebView repo.


Error while loading tsv file

When loading a tsv file I get the following error:
Error detected while processing function csv#Init:
line   84:
E119: Not enough arguments for function: csv#CalculateColumnWidth
line   86:
E121: Undefined variable: b:col_width
E116: Invalid arguments for function join(b:col_width, ',')

The TSV file is:
abc	def	ghi
1	2	a
3	4	b
5	6	c

It seems the function csv#CalculateColumnWidth() takes two arguments (second is silent) and is called with only one. I'll make a modification and propose a pull request.

should be fixed by #154


Ccurrently the "down arrow" work as the "right arrrow" opening the sections when you overpass them.

The bugs mentioned by @Tabixe are still active. I imagined that because he commented in an already closed issue, these have not been noticed.
Therefore I open a new issue, as these needs fixing ASAP. I believe it is just a matter of changing shortcuts behaviour.
1.  Issue with the "down arrow": currently the "down arrow" work as the "right arrrow" opening the sections when you overpass them.
https://drive.google.com/file/d/1enm2zd83Frkg7V72vRnNPzhiqIrF4uKm/view?usp=sharing
2. Issue with the "up arrow": as the "down arrow" it also opens the sections when you overpass them.
https://drive.google.com/file/d/1WKNJ6ztjz6W_tf1Y9Ru3MIWeIBnozW25/view?usp=sharing
3. Issue with the subsections: when you are in a header of a subsection you are not able to go one level up by pressing the '"left arrow"
https://drive.google.com/file/d/1fVQ7YKtl-HoaJyZhDg9o8Nea1Zn27y4o/view?usp=sharing
4. Issue with the relocation of the scroll bar: when you close a really big section, the scroll bar doesn't get adjusted automatically making impossible see where are you.
https://drive.google.com/file/d/1NLMyBbn2ZX6APAxpDgNVHjbyIUsETdwg/view?usp=sharing
Originally posted by @Tabixe in https://github.com/aquirdTurtle/Collapsible_Headings/issues/8#issuecomment-545499560

The bugs mentioned by @Tabixe are still active. I imagined that because he commented in an already closed issue, these have not been noticed.

I had actually seen them and just hadn't had time to work on this repo, but thanks for opening the dedicated issue for them anyways.

Therefore I open a new issue, as these needs fixing ASAP.

If these things are important to you, you're always welcome to contribute yourself. It's not like I get paid in any way to maintain this repo. I work on it when I have time and am in the mood.
Anyways, I believe I have fixed issues 1, 2, and 3 in version 0.5.0, available now.  Please let me know if they aren't working for you or if there are any additional issues. I'm a little nervous about adding behavior to up-arrow and down-arrow keys since jupyterlab already handles them, but my modifications seem to be working smoothly for me.
For issue 4, I'm waiting on https://github.com/jupyterlab/jupyterlab/pull/6818 to be merged before I fix this, as a "scroll to cell" method is exactly what I want here. I don't feel like it's worth trying to use the existing scrolling utilities when the perfect utility for the job is coming down the pipeline. Until then of course you can always get jupyterlab to scroll the cell into view by hitting up-arrow then down-arrow to re-select the cell after closing it.
I'll leave the issue open until I deal with issue 4.

Thanks a lot @aquirdTurtle! I hope I knew more coding so I could help you. I have tried the up-to-date version and works perfectly!

Indeed all works as intended, thank you @aquirdTurtle! Nice job!

Hi @aquirdTurtle,
I'm writing here because is the only way I have to get in touch with you. You have done an amazing job with the Collapsible Headings but I'm going to push my luck and suggest you another challenge for the next time that you fill in the mood of coding.
I don't know at all how difficult it is but it would be incredible if you manage to create a new Jupyter Lab extension that provides the run time for each cell and when they were ran for last time.

If you managed to do this I think that we would be at the point where we can start saying that jupyter lab is better than jupyter notebook. I only know python and SQL but if I can help you with something I will do it for sure.
Have a great week and Thanks a lot!

@Tabixe
Hi there, I've not made any progress on such an extension, although I might consider it at some point, but I thought I'd point you to the fact that the data is at least obtainable by looking at the cell metadata as of Jupyterlab version 1.2:
https://github.com/jupyterlab/jupyterlab/pull/6864
but there's no UI development as of right now as far as I can tell.

I got a bit tired of waiting for the main Jupyterlab repo to add this feature, so I went head and fixed this. As of version 2.2.0, just published, after closing or opening a large header, the notebook will scroll to keep the header in view if needed. Let me know if there are any additional issues.

Issues 1 and 2 from OP are still issues for me. Is that a regression?
I'm using aquirdturtle-collapsible-headings-3.0.1, jupyterlab 3.0.0

Issues 1 and 2 from OP are still issues for me. Is that a regression?
I'm using aquirdturtle-collapsible-headings-3.0.1, jupyterlab 3.0.0

@simonkeys it shouldn't be, but there has been a little bug where occasionally if jupyterlab takes an especially long time to load for some reason, the shortcut doesn't register, but should generally work if you simply reload the page. Is it possible that this is your issue as well? I did notice this getting a bit worse with jupyterlab 3, and should probably just fix it regardless.

@simonkeys it shouldn't be, but there has been a little bug where occasionally if jupyterlab takes an especially long time to load for some reason, the shortcut doesn't register, but should generally work if you simply reload the page. Is it possible that this is your issue as well? I did notice this getting a bit worse with jupyterlab 3, and should probably just fix it regardless.

Yes, reloading the page does the trick, thanks!
I've got JupyterLab configured to run in Chrome's "application mode" (like this: http://christopherroach.com/articles/jupyterlab-desktop-app/). Maybe that triggers the not-registering problem somehow?

Yes, reloading the page does the trick, thanks!
I've got JupyterLab configured to run in Chrome's "application mode" (like this: http://christopherroach.com/articles/jupyterlab-desktop-app/). Maybe that triggers the not-registering problem somehow?

I just tried out the application mode version, and it does seem like it's maybe a bit slower to load than otherwise, so might be exacerbating the problem. I'll reopen this and try to fix this properly.

I just tried out the application mode version, and it does seem like it's maybe a bit slower to load than otherwise, so might be exacerbating the problem. I'll reopen this and try to fix this properly.

It looks like the slow loading may actually have been due to another issue -- I had warnings on load because of this: https://github.com/ipython-contrib/jupyter_contrib_nbextensions/issues/1529
After fixing that, the arrow shortcuts now work properly for me on the first load.
Thanks for your help, and for the super useful extension!

It looks like the slow loading may actually have been due to another issue -- I had warnings on load because of this: https://github.com/ipython-contrib/jupyter_contrib_nbextensions/issues/1529
After fixing that, the arrow shortcuts now work properly for me on the first load.
Thanks for your help, and for the super useful extension!

I started seeing this issue after updating to jupyterlab 3. Is this common, or just something going wrong with the upgrade?


Store and Reuse Calculated Embeddings

Is it possible to export the calculated embeddings for a set of documents and store them so they don't need to be calculated again? See below snippet for an example of what I mean:
// calculate embeddings for the first time
const textSplitter = new RecursiveCharacterTextSplitter({ chunkSize: 1000 });
const documents = await textSplitter.createDocuments([stateOfTheUnionText]);
const vectorStore = await MemoryVectorStore.fromDocuments(
  documents,
  new OpenAIEmbeddings()
);

// now that the embeddings have been calculated, let's store and reuse them so we don't need to recalculate them
localStorage.setItem('embeddings', JSON.stringify(vectorStore.embeddings));
const storedEmbeddings = JSON.parse(localStorage.getItem('embeddings'));
const memoryVectorStore = await MemoryVectorStore.fromDocuments(documents, storedEmbeddings);

closing this as completed, see https://github.com/hwchase17/langchainjs/issues/869#issuecomment-1515725024 for solution


modernc.org/SQLite-v1.23.1: 1 vulnerabilities (highest severity is: 5.5)

 Vulnerable Library - modernc.org/SQLite-v1.23.1

Path to dependency file: /go.mod
Path to vulnerable library<EMAIL_ADDRESS>
Found in HEAD commit: 2b0992a0c37d626a385d16f8a4ff67f1ab60ee79
Vulnerabilities

CVE
Severity
 CVSS
Dependency
Type
Fixed in (modernc.org/SQLite-v1.23.1 version)
Remediation Possible**

CVE-2020-28928
 Medium
5.5
modernc.org/libc-v1.24.1
Transitive
N/A*
❌

*For some transitive vulnerabilities, there is no version of direct dependency with a fix. Check the "Details" section below to see if there is a version of transitive dependency where vulnerability is fixed.**In some cases, Remediation PR cannot be created automatically for a vulnerability despite the availability of remediation
Details

 CVE-2020-28928
Vulnerable Library - modernc.org/libc-v1.24.1

Library home page<EMAIL_ADDRESS>Path to dependency file: /go.mod
Path to vulnerable library<EMAIL_ADDRESS>
Dependency Hierarchy:

modernc.org/SQLite-v1.23.1 (Root Library)

:x: modernc.org/libc-v1.24.1 (Vulnerable Library)

Found in HEAD commit: 2b0992a0c37d626a385d16f8a4ff67f1ab60ee79
Found in base branch: main

Vulnerability Details

In musl libc through 1.2.1, wcsnrtombs mishandles particular combinations of destination buffer size and source character limit, as demonstrated by an invalid write access (buffer overflow).
Publish Date: 2020-11-24
URL: CVE-2020-28928

CVSS 3 Score Details (5.5)

Base Score Metrics:

Exploitability Metrics:

Attack Vector: Local
Attack Complexity: Low
Privileges Required: Low
User Interaction: None
Scope: Unchanged

Impact Metrics:

Confidentiality Impact: None
Integrity Impact: None
Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version
Origin: https://nvd.nist.gov/vuln/detail/CVE-2020-28928
Release Date: 2020-11-24
Fix Resolution: musl - 1.2.2-1,1.2.2-1,1.1.16-3+deb9u1

Thank you for reporting this vulnerability. We are aware of the issue with modernc.org/libc-v1.24.1 and are working on a fix.
In the meantime, you can upgrade your modernc.org/SQLite dependency to a version that includes a fix for CVE-2020-28928.  The vulnerability is fixed in  musl versions 1.2.2-1, 1.2.2-1, and 1.1.16-3+deb9u1.
For more information about this issue, please refer to the CVE details on the NVD website.

Thank you for reporting this vulnerability.
This issue is related to the modernc.org/libc library, which is a transitive dependency of modernc.org/SQLite. The reported vulnerability (CVE-2020-28928) affects versions of modernc.org/libc up to 1.2.1, and a fix is available in version 1.2.2.
Unfortunately, the current version of modernc.org/SQLite (v1.23.1) does not have a version of modernc.org/libc that includes the fix. You can either upgrade modernc.org/SQLite to a version that includes the fixed modernc.org/libc dependency or use a different SQLite library.
Please let me know if you have any other questions.

Thank you for reporting this vulnerability.
The reported vulnerability, CVE-2020-28928, affects modernc.org/libc version 1.24.1. It's a medium-severity vulnerability that could potentially lead to a denial-of-service attack. While there is no specific version of modernc.org/SQLite that directly addresses this vulnerability,  we are aware of this issue and are working on a fix for it.
In the meantime, we recommend upgrading modernc.org/libc to a version greater than 1.24.1. You can update your project dependencies to the latest version using the following command:
go get -u modernc.org/SQLite

For more information on how to update dependencies in your project, please refer to the Go Modules documentation.
We appreciate your understanding and cooperation as we work on a permanent fix for this issue.

Thanks for reporting this vulnerability. The issue is a known vulnerability in the modernc.org/libc dependency, which is a transitive dependency of modernc.org/SQLite.
The vulnerability, CVE-2020-28928, has been addressed in musl libc version 1.2.2. Unfortunately, modernc.org/SQLite-v1.23.1 does not have a version with this fix.
You can work around this issue by:

Upgrading to a newer version of modernc.org/SQLite that incorporates a patched version of modernc.org/libc.
For more details, see the vulnerability details and suggested fix sections.


Add Logger.rebuild(includeChildren) Method

This resolves #187 by adding a new Logger.rebuild(includeChildren) method, which takes care of using the methodFactory to update all the logging methods according to the current level. If the includeChildren argument is set to true and the method is called on the root logger, it will recursively rebuild all the child loggers (it is false by default, but in some future v2, it should probably be changed to true).
The includeChildren argument is mainly useful for two cases:

When applying a plugin or modifying the logger’s methodFactory, it can be used to update previously existing child loggers, so you can divorce logger configuration code from logger declaration code. Ideally, plugin developers will call this from their plugin’s apply/register/whatever code. But a user could call it directly if a plugin developer does not.

When changing the level on the root logger and you want that new level to apply to already existing child loggers (that you haven’t called setLevel() on and that didn’t have persisted levels). This essentially lets you treat a logger’s “default” level as if it means “whatever my parent/root logger’s current level is.”

So in #187, the example problem code could be updated slightly to make everything work right:
// In `a-random-submodule.js`
import log from 'loglevel'

const logger = log.getLogger('DefaultUiAutomationWorker');

// In `index.js`
import aRandomSubmodule from 'a-random-submodule.js';
import log from 'loglevel';
import logPrefix from 'loglevel-plugin-prefix';

function main() {
    logPrefix.reg(log);
    logPrefix.apply(log, { template: '[%t] %l %n:' });
    log.enableAll();
    log.rebuild(true);  // Adding this line is the only change.

    // start rest of program here
}

main();

Other Notes

In the discussion on #187, we talked about calling this rebuildLogger(). I named it rebuild() here because I thought that was just as clear and a bit more concise, but I’m happy to change it if you’d prefer.

I made a small note in the code that includeChildren should default to true in some future v2 of the library. As discussed in #187, having setLevel() affect pre-existing child loggers is probably the right ideal, but might cause subtle breakage, so for now I just made rebuild() only affect the current level by default. Flipping the default in the future will also affect the behavior of setLevel() and setDefaultLevel() since they use rebuild() internally.
Another option here is to make the default true but having setLevel() and setDefaultLevel() call it with false (so log.rebuild() affects child loggers by default, but setLevel() and setDefaultLevel() do not). I think either way would probably be fine. 🤷

There are a few subtle side-effects here:

The currentLevel private variable used to always be a valid level. It no longer is — you should always call logger.getLevel() to get the current level. (defaultLevel will always be set and valid; currentLevel will only be set if setLevel() was explicitly called or a persisted level was loaded.) This shouldn’t affect the public interface at all, and I’ve made sure all internal callsites do the right thing.

setLevel() throws a TypeError instead of a string for invalid input. I don’t think this should really be an issue, and it arguably improves errors slightly (IMO throwing or rejecting with things that aren’t instances Error or a sub-type is problematic). But I can change it back if you prefer.

Whoops, forgot to update docs and type definitions. I added two commits to do that.
I’m also noticing that it doesn’t look like Travis is in use any longer, or at least there are no CI checks showing up on this PR. Should we add a GitHub Actions workflow since Travis doesn’t really have a free-for-open-source plan anymore?

I’m also noticing that it doesn’t look like Travis is in use any longer, or at least there are no CI checks showing up on this PR. Should we add a GitHub Actions workflow since Travis doesn’t really have a free-for-open-source plan anymore?

@pimterry Just a quick re-up on the above question. Since #190 landed, I think this should be pretty easy to do.

I’m also noticing that it doesn’t look like Travis is in use any longer, or at least there are no CI checks showing up on this PR. Should we add a GitHub Actions workflow since Travis doesn’t really have a free-for-open-source plan anymore?

@pimterry Just a quick re-up on the above question. Since https://github.com/pimterry/loglevel/pull/190 landed, I think this should be pretty easy to do (and I am happy to do the work; just let me know).

Sorry I missed that - yes, Travis is indeed dead, I'd be extremely happy to move to GitHub Actions if you want to set that up.

Alright, this should be ready for another review (and maybe to land). See my replies to the previous review comments for an update on the architecture here: https://github.com/pimterry/loglevel/pull/189#discussion_r1462567157
I added more comments, which pumps up the un-minified size a bit:

File
Before
After
Change

loglevel.js
9.41 KB
11.04 KB
+17.3%

loglevel.min.js
3.08 KB
3.26 KB
+5.9%

Thanks, I agree that 3 variable model looks cleaner, and I'm happy this pulls together the rebuild logic without changing the existing code too significantly.
Thanks for all your hard work to make this and the other PRs happen. It's really tidied up the project and should be a great fix to help others who might be affected by #187 and similar confusion. Great stuff :+1:. I'll do some last testing & checks locally and then publish a new release with these changes included soon.

Awesome! 🙌
I’ll finish up with a commit that updates the contributing instructions as mentioned in https://github.com/pimterry/loglevel/issues/191#issuecomment-1894653099.


Juice-Shop crashes when solving challenge "Database Schema"

:bug:  Bug report
Description
The Juice-Shop crashes when attempting to solve the challenge "Database Schema" when calling the following url for a locally running instance:
localhost:3000/rest/products/search?q=a'))+union+select+sql,2,3,4,5,6,7,8,9+from+sqlite_master+where+type='table'--
The Juice-Shop responds with the information about the database schema, but then immediately crashes.
Is this a regression?
I could not find an earlier version where the Juice-Shop did not crash
:microscope:  Minimal Reproduction

Start the Juice-Shop with npm run start from the project directory
Paste the following url into the address bar of your browser:
localhost:3000/rest/products/search?q=a'))+union+select+sql,2,3,4,5,6,7,8,9+from+sqlite_master+where+type='table'--

:fire: Exception or Error
juice-shop/build/lib/utils.js:72
    return (0, exports.contains)(str, element.replace(/"/g, '\\"'));
                                              ^

TypeError: Cannot read properties of null (reading 'replace')
    at containsEscaped (/juice-shop/build/lib/utils.js:72:47)
    at Object.containsOrEscaped (/juice-shop/build/lib/utils.js:76:79)
    at /juice-shop/build/routes/search.js:50:54

:deciduous_tree: Your Environment
The bug was observed on the following environment:
node: v16.17.0
npm: 8.15.0
but could not be reproduced with:
node: v14.20.0
npm: 6.14.17
Additional Information
System Information:

OS: Arch Linux
Kernel: 5.19.7-arch1-1

Also, I encountered this bug when using the heroku app, which may have caused it to crash. If that is the case, I am very sorry.

Will be fixed with 14.3.0 release. Thanks for reporting this! ❤


Support Other (non Postgres) DBMSs

We currently presume that PostgreSQL is being used but we should also support SQLServer, MYSQL and SQLite.

Closing as we support MariaDB and, at least to some extent, sqlite. Any other DBMS support can be decided on a case-by-case basis.


Add support for "Reply-To" in /send API

I think Reply-To is a pretty common header. It would be a useful addition to the /send API.
Why is it important to me: Wordpress forms plugin uses the wordpress admin email as From:, but the contacter email's as Reply-To. Setting the contacter as From is possible, but increases the odds of the email being classified as spam. Here, it ends up in spam every time unless I create a special rule based on the email's subject.

I like the idea, but I'd prefer to see something more generic implemented - maybe a headers parameter that contains a map of extra headers to add. Then you could do:
{
    "from"<EMAIL_ADDRESS>    "to"<EMAIL_ADDRESS>    "subject": "Test",
    "headers": {
        "Reply-To": "...",
        "X-Custom-Header": "..."
    },
    "text": "This is a test."
}

Sure.
Existing fields from, to, cc, bcc, subject, etc. are already headers too. To be coherent then maybe such hectane API should look more like this:
{
    "headers": {
        "From"<EMAIL_ADDRESS>        "To"<EMAIL_ADDRESS>        "Subject": "Test",
        "Reply-To": "...",
        "X-Custom-Header": "..."
    },
    "text": "This is a test."
}

I understand the existing /send as a thin level of abstraction above the Mail RFC. replyTo would make sense in /send I believe.
However, I agree there should be a more generic solution. Why not a 3rd level of API, between the lowest-level /raw and highest-level /send?

/raw → low-level (only from, to, body).
/mail → intermediate-level (only headers, text, html and attachments)
/send → high-level (all usual mail header fields recognized and documented as top-level API parameters)

For /send, it should actually be easy to convert automatically field names (camelCase) to header fields (Snake-Case).
eg:

X-My-Header in a header is xMyHeader in /send...
Reply-To is replyTo.
To is to

Basically all /send fields that aren't text, html or attachments can be added in headers automatically... Don't know if that makes sense.
Anyway, I'm talking a lot but I don't have much time to learn golang and attempt a solution...

I've added a headers parameter to the /send method. The example in my previous message should work out-of-the-box now. The custom headers are applied after the existing ones are generated from From:, To:, etc. so overriding existing headers is now possible.
I'm worried that having three different methods would be a little bit too confusing. It is still possible to accomplish everything with only two methods, as far as I can tell. Please let me know if anything is missing.

Awesome :+1:
I suppose this covers everything we may needs. BTW, is the docker image auto-regenerated when you push to hectane/hectane?

No, not at this point, unfortunately.

Maybe the easiest way for you would be to just add the Dockerfile to this repo and setup an automated build on dockerhub... You can also add a trigger on dockerhub and call it from a webhook on github.

Good idea. A container is now built from the master branch with each new commit. You can find the repository here.


Write a regions notebook in astropy-tutorials

As suggested by @astrofrog and me at https://github.com/astropy/regions/pull/87#issuecomment-264002104, we should write a "getting started" notebook for regions, and put it in astropy-tutorials.
I think a 5 to 10 min read would be appropriate, and start and end by pointing at the longer Sphinx docs.
I'm putting this under the 0.2 milestone, but this can happen after the release. It should happen before the 0.2 announcement to astropy-dev though, so that this can be mentioned.
Anyone interested to do this?
If no, I'll write it on Monday latest.

I wrote a tutorial 1 yr ago.  Unfortunately, it's not working at the moment:
https://github.com/janerigby/NB/blob/master/Example pyds9 and pyregion.ipynb
Please see issue 124:  https://github.com/astropy/pyregion/issues/124


Service: Power supply

This pull request defines a new service.

am I now misusing: min_reading and max_reading?

am I now misusing: min_reading and max_reading?

A: yes.

yup min_value, max_value best

Maybe. Happy to stick to just output voltage for now?
James

From: Peli de Halleux @.>
Sent: Tuesday, March 15, 2022 7:16:58 PM
To: microsoft/jacdac @.>
Cc: James Devine @.>; Author @.>
Subject: Re: [microsoft/jacdac] Service: Power supply (PR #938)
e.g. "actual_voltage" would be a reading reading
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fpull%2F938%23issuecomment-1068368743&data=04|01|t-jamdev%40microsoft.com|a20063ef340a418a664508da06b8608a|72f988bf86f141af91ab2d7cd011db47|1|0|637829686210679088|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=tWJMZrSTnu8R1%2BajzVUVhKBRujukbrl5V1Ln7ytAQSA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABEF4KIKL3AYYFKV55IVG4TVADO2VANCNFSM5QZLZRLQ&data=04|01|t-jamdev%40microsoft.com|a20063ef340a418a664508da06b8608a|72f988bf86f141af91ab2d7cd011db47|1|0|637829686210679088|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rlfGSdma9nEF8zUG5z9%2FYVd1%2Fr821gojEpWL1HK3PAQ%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

output voltage yes

i16.16?

From: James Devine @.>
Sent: Tuesday, March 15, 2022 1:01:27 PM
To: microsoft/jacdac @.>
Cc: Peli de Halleux @.>; Comment @.>
Subject: Re: [microsoft/jacdac] Service: Power supply (PR #938)
I guess mV might be simpler in terms of implementation on client and server.
Some PSUs can also generate negative voltages so maybe unsigned is not the best choice...
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fpull%2F938%23issuecomment-1068413695&data=04|01|jhalleux%40microsoft.com|bd4c6d9ff1bc4093354c08da06be9781|72f988bf86f141af91ab2d7cd011db47|1|0|637829712928321853|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=AWb%2F4vJV0E8pU7jqIzOvi6pgWT8SdEfC8MfvrHAP4Fc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKL3CEKKMS3QQTNGAWLVADUBPANCNFSM5QZLZRLQ&data=04|01|jhalleux%40microsoft.com|bd4c6d9ff1bc4093354c08da06be9781|72f988bf86f141af91ab2d7cd011db47|1|0|637829712928321853|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=G9epWuRtMmTf4kCw0NCMjd8EczF0rNPsKvsSJC8284g%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

I would go i22.10 mV - with mV you don't need .16 but if it's a generic power supply you don't want to limit to 65V

Run "yarn buildspecs" from jacdac-docs


panic("score should be the same")

Please answer these questions before submitting your issue. Thanks!
Gorse version
Version:         unknown-version
API version:     v0.2.7
Go version:      go1.23.1
Git commit:      unknown-commit
Built:           unknown-buildtime
OS/Arch:         windows/amd64
Describe the bug
When it is first started, MySQL stores the data_cache, records the user, item, and feedback, and after starting, it is found that the master calculates the score and writes it to the cache database, and then after the worker gets up, when the score is calculated and written to the cache database, it will judge that the score of the data is inconsistent, resulting in panic，
Why this is the case is a question that must arise
The location of the code where the error occurred
func (aggregator *DocumentAggregator) Add(category string, values []string, scores []float64) {
for i, value := range values {
if _, ok := aggregator.Documents[value]; !ok {
aggregator.Documents[value] = &Document{
Id:         value,
Score:      scores[i],
Categories: []string{category},
Timestamp:  aggregator.Timestamp,
}
} else {
if aggregator.Documents[value].Score != scores[i] {
//bug here
panic("score should be the same")
}
aggregator.Documents[value].Categories = append(aggregator.Documents[value].Categories, category)
}
}
}

I have the same problem, keep watching.

This check could be removed.


adding ScopeClaim in new Resource-based Configuration

How to add ScopeClaim in new Resource-based Configuration?
I have read the blog post
https://leastprivilege.com/2016/12/01/new-in-identityserver4-resource-based-configuration/
but don't fully understand. My old code was
        public static IEnumerable<Scope> GetScopes()
        {
            return new List<Scope>
            {
                StandardScopes.OpenId,
                StandardScopes.Profile,
                StandardScopes.Email,
                StandardScopes.OfflineAccess,

                new Scope
                {
                    Name = "myApi",
                    DisplayName = "myApi access",
                    Description = "myApi",
                        Claims = new List<ScopeClaim>
                        {
                            new ScopeClaim("companyCode", alwaysInclude: true)
                        }
                }
            };
        }

but in the new model where and how to put companyCode? I have tried creating customProfile, but when looking into token with jwt.io it is not there.

new ApiResource("myApi", "My Api")
{
    UserClaims = { "companyCode" }
},

Thank you.


Migrate primary branch from master to main

See https://github.com/Senzing/stream-loader/issues/283

Pull requests:

https://github.com/Senzing/github-util/pull/32


Disabling rails cops with Rails: Enabled: false in .rubocop.yml files is inconsistent between running rubocop for whole project/single file

There seems to be a bug with the way .rubocop.yml files in subdirectories are handled.
We have a .rubocop.yml file in the root directory of our project with the following:
Rails:
  Enabled: true

And then a lib/.rubocop.yml with the following:
Rails:
  Enabled: false

The expectation being that it would not complain about Rails-specific offenses commited in the lib/ directory, but do so everywhere else.
Expected behavior
Running rubocop on all files in our project (say, on our pipeline) is expected to produce consistent results with running rubocop against a single file in our project (say, when SublimeLinter runs rubocop against the currently open file)
Actual behavior
Running bundle exec rubocop produces no errors when we are violating the cop in the spec/ directory, but running bundle exec rubocop spec/path/to/file_spec.rb does
Steps to reproduce the problem
I created a minimal reproduction repository here on github. You should be able to reproduce the issue given that you have bundler installed.
Clone this repo: https://github.com/odinhb/rubocop-rails-skips-model-validations-repro
git clone git@github.com:odinhb/rubocop-rails-skips-model-validations-repro.git
bundle install
bundle exec rubocop
bundle exec rubocop lib/hey.rb
bundle exec rubocop spec/hey_spec.rb
observe difference in output between running all and specifically running on spec/
Version information
The reproduction repository uses the latest versions at the time of writing (inspect the Gemfile.lock). The following are versions installed in our actual projects.
$ rubocop -V
0.74.0 (using Parser <IP_ADDRESS>, running on ruby 2.6.5 x86_64-linux)

rubocop-rails: (2.3.2)
I'm running Linux:
$ uname -srvmpio
Linux 5.9.0-11.1-liquorix-amd64 #1 ZEN SMP PREEMPT liquorix 5.9-8ubuntu1~focal (2020-11-25) x86_64 x86_64 x86_64 GNU/Linux

But my colleagues are running macOS, so it seems to be cross-platform in nature.
one of my colleagues is running: 10.15.7 (Catalina)

Not sure if you're still facing this, but we faced a similiar problem and I solved it this way:
# Project root .rubocop.yml
Rails:
  Enabled: true
  Excluded:
  - bin/**/*

We had some bin/ scripts being linted for Rails things like present? but the scripts run in shell or ruby interpreter, so using Rails extension methods was causing NoMethodError issues.