Chambers of Xeric QOL & fakemass

Description:
Update various aspects of CoX to closer match ingame times and boosts.
Add an option to fakemass (similar to nex/tob solo).
Changes:

add the option type of fakemass

Specify the number of fake users with max_team_size (2 - 15)
Acts as a normal mass but checks the user for kc and boosts similar to tob/nex solo

Update CoX speed tasks to use actual trip duration
Update bis melee, range, mage gear (this affects gearscore)
Update item boosts

add scythe boost + charge usage

Add a new command /raid cox itemboosts  to check your itemboosts for CoX
Add ammo checks and usage
Add crystal pick as simItem to dragonpickaxe
Update mass forming message to show 5 minutes vice 2 minutes
add two new variables to RaidsOptions for better flexibility isFakeMass maxSizeInput & update repeatStoredTrip
Update testpotato gear for bis CoX and also gives 10000 of any range ammo specified.

Updated Times for CoX:
Assumptions: 1 raid trip, 100% itemboost, 100% kc boost, 100% gearscore.
solo: 16m 42s - 18m 28s (CA time: < 17m 00s)
2man: 14m 39s - 16m 12s
3man: 13m 43s - 15m 09s (CA time: < 14m 30s)
4man: 12m 55s - 14m 17s
5man: 12m 08s - 13m 25s (CA time: < 12m 30s)
6man or higher: same as 5man times
cm solo: 30m 12s - 33m 23s (CA time: < 38m 30s)
cm 2man: 20m 24s - 22m 33s
cm 3man: 21m 38s - 23m 55s (CA time: < 27m 00s)
cm 4man: 20m 24s - 22m 33s
cm 5man: 19m 09s - 21m 10s (CA time: < 25m 00s)
6man or higher: same as 5man times
Other checks:

[X] I have tested all my changes thoroughly.
2 rounds of testing was done in testing server with testers (all feedback/bugs were addressed and or fixed)

closes: https://github.com/oldschoolgg/oldschoolbot/issues/1811
closes: https://github.com/oldschoolgg/oldschoolbot/issues/1769
closes: https://github.com/oldschoolgg/oldschoolbot/issues/2151
closes: https://github.com/oldschoolgg/oldschoolbot/issues/1850

Will merge after conflicts fixed (assuming its been tested and such)

Updated.
This has been tested a few times with testers and the updated times are listed in the description above.
I also just did a quick test as of posting this message and everything is still working as intended.


feature request: flag props that don't need to be propagated with '$'

styled components is awesome, but one problem it has is that it propagates all props to the html elements .
For example, if I have a prop specific to styling like "size", it will be propagated to HTML:
import { render } from "solid-js/web";
import { styled } from "solid-styled-components";

const MyComponent = styled("div")`
  background: black;
  width: ${(props: { size: number }) => props.size}px;
  height: ${(props) => props.size}px;
`;

render(() => <MyComponent size={40} />, document.getElementById("app")!);

sandbox link

I'd like to avoid this. This library  solved this problem by marking all props that shouldn't be propagated with "$" symbol. So my "size" prop would become "$size".  Same goes for $theme and $as props. IMO it's a clear and concise solution.

up, I would love this issue to move forward. Is anyone currently working on it? If not, I might be able to pick this up and open a PR in a few weeks


fix: support for internal call event in name actions

Description
Resolves #267
The problem was the lack of support for internal contract call events which have a different payload.
Demo

Checklist:

[x] I have read and followed the Contributing Guide
[x] My change does not require a change to the documentation.

@janmichek I think that same names started using events that we have never been supporting before


Style/RedundantStringEscape in HEREDOC is not safe to autocorrect

Expected behavior
It does not remove \ escape char from the regexp within HEREDOC when autocorrecting.
Actual behavior
It removes \ escape char from the regexp within HEREDOC when autocorrecting.
Steps to reproduce the problem
# frozen_string_literal: true

class CreateDomainEmail < ActiveRecord::Migration[7.0]
  def up
    execute <<-SQL.squish
      DROP DOMAIN IF EXISTS email;
      CREATE DOMAIN email AS CITEXT NOT NULL CHECK(VALUE ~* '^[a-zA-Z0-9.!#$%&''*+/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$');
    SQL
  end

  def down
    execute <<-SQL.squish
      DROP DOMAIN email;
    SQL
  end
end

RuboCop version
$ bundle exec rubocop -V
1.41.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.24.1, running on ruby 3.2.0) [aarch64-linux-musl]
  - rubocop-performance 1.15.2
  - rubocop-rails 2.17.4
  - rubocop-rspec 2.16.0

This looks like expected behavior. It looks like the \ needs to be escaped or the heredoc identifier needs to be single quoted.
-(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)
+(?:\\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)

or
-   execute <<-SQL.squish
+   execute <<-'SQL'.squish
      DROP DOMAIN IF EXISTS email;

That's what it means:
<<~EOS
  foo\.bar
EOS
# => "foo.bar\n"

<<~EOS
  foo.bar
EOS
# => "foo.bar\n"

<<~EOS
  foo\\.bar
EOS
# => "foo\.bar\n"

<<~'EOS'
  foo\.bar
EOS
# => "foo\.bar\n"


Reproducing Paper Results

Hi @liuQuan98 ,
Thank you very much for your interesting  work and your detailed code.
I was trying to reproduce the results shown in the paper on kitti (table 1 and table 3), using your weights and the supplied test script.
I am not sure which flag I should use to reproduce the Registration Recall of <1.5 <60.
I saw that when using --lokitti false the test size is 225 (with maximal gap between frame of ~35m).
When --lokitti true we have ~550 problems.
Should I use --useRansac false as well?
Can you guide me how to reproduce paper results?
Thanks
Yuval

Hi @yuvalH9 ,
Thank you for your interest in our work.  Setting the registration thresholds at 1.5 degrees and 60cm requires you to set rre_thresh and rte_thresh to 1.5 and 0.6, respectively.
Parameter 'lokitti' is another benchmark released in my previous publication on this topic (see my liuQuan98/APR for details). It selects pairs with only <=30% overlap, mimicking the 3DLoMatch proposed by Overlap Predator. For more details on the setup of this dataset, please refer to this paper.
Parameter 'use_RANSAC' should always be true, so that we are conducting fair comparison using RANSAC with other methods. Only when you are not interested in comparing performance, you can disable it to use a faster alternative (which is actually SC2-PCR) to generate better results at a higher throughput.
The problem size for lokitti is fixed, and when lokitti is enabled, pair_min_dist and pair_max_dist will not take effect. To produce my results in Table1, run test_gcl_kitti.sh script with rre_thresh 1.5 rte_thresh 0.6 pair_min_dist X pair_max_dist Y where (X,Y) is one of the following: (5,10), (10,20), (20,30), (30,40), (40,50). These five experiments represent results on five test dataset splits in Table 1. As for Table 3, I didn't release the model other than the best one. You can check its performance by setting lokitti true for the lokitti results, and setting lokitti false pair_min_dist 10 pair_max_dist 10 for the KITTI[10,10] results.
Best,
Quan Liu


[Flink AI Flow][Airflow] Fail on stopping submitted flink job

When an airflow workflow contains a streaming flink job and we define model_version_control_dependency with this job, according to our assumption, the flink job should be restarted if it received subscribed events. But currently, our airflow scheduler will only kill the flink job's client and then directly start a new flink client to submit the restarted job.
However, the flink web UI shows that the killed job is still running as our airflow scheduler does noting about the submitted job.

Fixed on stopping local flink job


T - Find equillibrium 8

Determine a stopping condition to know when equillibrium and implement it.

What do we think about this? The paramter fmax already seems to control the convergence criterion. Maybe structure optimization is what's used to calculate e.g. density and we can just use one of these algorithms in ase?
https://wiki.fysik.dtu.dk/ase/ase/optimize.html


Prevent hard crash in GDScriptVM when a named global can not be found.

Closes #63559
Provides a check in the VM for OPCODE_STORE_NAMED_GLOBAL. Fixes the issue, but wonder if concerned about potential overhead.

Thanks!


fix(ci): disk validation for docker volume mount

Reviewer Instructions
Since this change is urgent, please put suggested cleanups in ticket #7677.
Motivation
PR #7662 did not work as expected, as the validation was too simplistic
Fixes: #7659
Solution

Previously we validated the disk exists, but we should also validate it's not being used by another process. This solution did not work, maybe because it is the running Docker process that is already using the disk.

Replace multiple-mounting the same disk (which could be causing busy errors) with a symlink from the second mount path to the first mount path

Add extra sleeps to avoid a device busy error in mke2fs

Review

We did not run this multiple times in the previous PR, we should re-run the tests multiple times to confirm.
Since this change is urgent, please put suggested cleanups in ticket #7677

Reviewer Checklist

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

@gustavovalverde since this is an urgent fix, do you mind if I work on it today?
It would be helpful to get it merged before the full sync jobs start tomorrow, so we can test all these bug fixes.

Reviewer Instructions
Since this change is urgent, please put suggested cleanups in ticket #7677

@teor2345 we can also output the Docker daemon logs after the failure, to confirm if it gives more information about the error:
sudo journalctl -u docker.service

@teor2345 we can also output the Docker daemon logs after the failure, to confirm if it gives more information about the error:
sudo journalctl -u docker.service

Thanks, I gave this a try.

I'm currently retrying the commands if they fail, I also need to delete the containers that were created without the correct mounts.

I'm trying lsof for debugging. If that doesn't work, fuser, losetup, or lsof | grep a_inode might help:
https://stackoverflow.com/questions/624154/linux-which-process-is-causing-device-busy-when-doing-umount/45782183#45782183
This could be caused by an automatic fsck:
https://unix.stackexchange.com/questions/179855/device-already-mounted-or-resource-is-busy/342464#342464

So far lsof isn't showing much: there aren't any files open on the device. Maybe one of the other commands will help more.

I canceled [fix: remove extra ;] (https://github.com/ZcashFoundation/zebra/pull/7665/commits/3c29dab5c349acf3ac44dea4ce5c446ba91daef3) with a new commit
But it did not fail to mount the volumes


Try different SSH ports when building?

Hi,
When attempting to build a new basebox, if a Vagrant VM is already running that has claimed the default SSH forwarding port of 2222, veewee build bails with:
Hmm, the port 2222 is open.

Would it be possible to detect and avoid collisions, like Vagrant does, or perhaps veewee could just use a different port by default where collision is less likely?

Sweet, thanks! :-)


feat(releasing): automate call of ddqa in the build_rc pipeline

What does this PR do?
Add a job to be triggered in deploy pipeline to automate creation of qa cards in release flow

Motivation
automation

Additional Notes
cc @kacper-murzyn

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Port list in container view broken

Bug description
On the "Dashboard -> containers" site, the ports column is not well sorted.
The first problem is if you have multiple ports mapped into a container, the list of this mappings is not showed in ascendend order.
I.e.: It can be showed as "8001:8080 9001:9080" or "9001:9080 8001:8080".
Second occurrence is the list itself which is not sorted if you use the sorting function in the table header.
In my case the sequence from top to down with alphabetic order is:
8006:8080 9006:9080
8004:8080 9004:9080
9003:9080 8003:8080
9082:9080 8082:8080
8091:8080 9091:9080
8086:8080 9086:9080
8087:8080 9087:9080
Expected behavior

Port mappings should be sorted in a stable way.
1.1 You should be able to select which port you want to see, internal or external port.
1.2 In the case of multiple port mappings, you should be able to select how much and/or which entry of the list you want to see and sort by.
The list should be sorted in the selected order.

Portainer Logs
Steps to reproduce the issue:
See Bug description.
Technical details:

Portainer version: 1.23.1

Docker version (managed by Portainer): 19.03.6 (API: 1.40)

Platform (windows/linux): linux x86_64 Ubuntu 18.04.3 LTS

Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): docker run -d -p 9000:9000 --name portainer --restart always -v /var/run/docker.sock:/var/run/docker.sock -v ~/portainer_data:/data portainer/portainer

Browser: firefox 73.0.1

Additional context

Duplicate of https://github.com/portainer/portainer/issues/2653

I guess I known now why this and some others bugs aren't fixed yet...


Tray icon has transparency issues

Hello! Firstly, congratulations on the incredible work!
I was investigating why the board is getting the primary color and I managed to come up with the following result, it's not a solution yet, but it could be a starting point for the solution:

nothing?

I looked for quite a while, but I haven't been able to figure out how to get these tray icon windows to display with transparency. I can alter the background color to some other solid color though, so I can update it to match the taskbar color, which will look good for any solid colored taskbar. I will try to go with that approach for now since it's better than the current behavior.

Yes, I believe it is the best solution for now.

Sorry for the delay, I found some time to wrap up this change and publish a new minor version.
New packages with this change:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Closing this issue since the background color approach should be sufficient for any solid colored taskbar. If someone has a more complex styled taskbar with gradient/transparency this could be revisited in a new issue.

Missed an issue in the prior package versions, needed to publish a fix to just the wm server half.
<EMAIL_ADDRESS>


flags

Checklist

[ ] I've searched through the plugins to make sure this feature isn't already available, or think it shouldn't require a plugin.
[ ] I've searched through the current issues to make sure this feature hasn't been requested already.
[X] I agree to follow the Code of Conduct that this project adheres to.

Motivation
I'm zooming on conflict zones (Palestina, Taiwan, Kurdistan, etc) but I see the flag of another conflict zone (Ukraine). Just because Leaflet was created by an Ukrainian person doesn't mean that only their country should be supported.
Suggested solution
The Ukrainian flag should appear only when the map is centered on Ukraine.
When elsewhere, it should show the respective flag.
Alternatives considered
Alternative 1 : Randomize the flags of conflict zones independently of where the map is centered
Alternative 2 : Do not display any flag.

I'm closing this as a duplicate of https://github.com/Leaflet/Leaflet/issues/8295 .
While I agree that other parties in other conflict zones should be supported, the current point of the flag is to show that Leaflet is directly affected by this conflict.

the current point of the flag is...

If you have to explain that to me, then the flag alone is not enough. It only reminds users scrolling another conflict zone about that conflict in Ukraine.
If you're not in Russia, there's no hint that Leaflet is unavailable in Russia. I personally just found out now that you posted the other thread.
Leaflet is also unavailable in N. Korea, but i don't see any reminder of that.


Document response status with empty body

Hello,
This is a very simple addition to the docs to explicitly document how to return a status code different than 400 when one doesn't set any body in the response.
As a new Koa user (coming from Express) this is a topic that has puzzled me at the beginning. Of course after having used Koa for a little while, the answer seems obvious. But I believe this addition will speed up even more the learning curve.

Thanks @dead-horse. And thanks for Koa.js which is great.


refactor: declaration files (and tests); connect(): Realm

changed from connect(): Bone to connect(): Realm which makes more sense. This behavior is not actually used in any dependents hence is planed with a minor release

Codecov Report

Merging #178 (27b8de9) into master (3f84723) will decrease coverage by 0.13%.
The diff coverage is 92.55%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   96.65%   96.52%   -0.14%
==========================================
  Files          38       39       +1
  Lines        2870     2964      +94
==========================================
+ Hits         2774     2861      +87
- Misses         96      103       +7

Impacted Files
Coverage Δ

src/realm.js
92.55% <92.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f84723...27b8de9. Read the comment docs.


AVRO-3000: Avoid unnecessary schema compatibility checks

Ruby Avro decoding spends a fair amount of time validating that the
reader and writer schemas are compatible. These checks are
unnecessary for the fairly common case of the reader and writer schemas
being the same Avro::Schema instance. This improves the throughput
of our Avro decoding benchmarks by 1.3X.
While I was in here I removed repeated allocations of constant arrays in the Avro:: SchemaCompatibility module.
/cc @tjwp

@tjwp - I rebased this to pick up the switch to use Github Actions for CI. Looks like tests are passing now 🎉

@tjwp - I rebased this to pick up the switch to use Github Actions for CI. Looks like tests are passing now 🎉


fix erro when "salt_run_highstate" is not set. Run salt-call but not …

…local
I install salt via bootstrap-script and the -A option to set the salt-master. Now I want to kitchen-test a client using a "normal" salt-call

Hi, I re-used your PR to upstream.
I think it's a good point, for further refinment of this change I would probably went that way that it will not highstate, but salt.apply some specific states (specified as opt.).


409 conflict when creating resources is delayed

Describe the bug

Artifactory Enterprise Plus 7.68.7
Terraform 1.6.2
Provider 9.8.0

Our Artifactory server is under fairly significant load these days, and while we work on mitigation that we get to encounter fun issues with delayed requests.
Our permission model is heavily autogenerated through terraform, which causes a large number of artifactory_permission_target objects to be managed by Terraform. When we create a new service account it's not unusually to have 5+ of these generated and created immediately after the user.
Terraform has started behaving inconsistently when creating these objects, taking minutes+ to actually complete the creation operation. Often these fail with a 409 CONFLICT HTTP error code:
Error:
409 POST https://artifactory.example.com/artifactory/api/v2/security/permissions/users-service-teamname-publish-a3ec3672a
{
  "errors" : [ {
    "status" : 409,
    "message" : "Can't create permission target 'users-service-teamname-publish-a3ec3672a' for type repo. It already exists."
  } ]
}

  with module.accounts["./../common-primary-cluster/users.json"].artifactory_permission_target.user_repos["service-teamname-publish-a3ec3672a"],
  on ../../modules/users/main.tf line 18, in resource "artifactory_permission_target" "user_repos":
  18: resource "artifactory_permission_target" "user_repos" {

And sure enough, if I go look at Artifactory's UI I can see the permission target was created successfully. It seems like Terraform ends up retrying the request somewhere along the lines, gets the 409 conflict and errors out.
This is particularly frustrating because I can't just re-run another plan and apply. The 409 error gets logged as "failure to create", the actually created item doesn't get into the statefile, and I'm doomed to get more 409s until I write a manual import block to pull the resource into the statefile. This is, of course, frustrating :)
We're considering looking into a way to autogenerate an import statement for these situations as a workaround.
Requirements for and issue

[x] A description of the bug
[x] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
[x] Your version of artifactory (you can curl it at $host/artifactory/api/system/version
[x] Your version of terraform
[x] Your version of terraform provider

Expected behavior
When terraform encounters network troubles creating a new resource and retries an API call, it should gracefully handle a 409 error response as "created".
Even better would be some form of check on whatever is conflicting to determine if it was created as expected (and thus successful) or if it differs from the expected config (and generates an error).

@cliffchapmanrbx Thanks for the report. I've added this issue to our plan.

We're in the exact same boat. It happens quite frequently and means much of the resources we Terraform manage in conjunction with the permission targets are only half-initialized and mostly unusable until we've manually remediated by either importing or manually deleting the permission target and rerun (usually importing is more work).


Fix ApnsPayloadBuilder alert body check when title is included (fixes #168)

The current implement just ignored alert.title when deciding whether to set alert as string or dict.
Hoping to fix [#168]. Test included.

:metal:
Thanks kindly for the fix!

@jchambers Thanks for merging.
Is it possible to create a release for this patch on 0.4.x branch? We have a customer waiting for this to go production. Also as pushy now has more and more users, perhaps it's time for us to setup development  and stable branch so we can fix fast and release fast.

Is it possible to create a release for this patch on 0.4.x branch?

Yes, but it will have to wait for a few days.

perhaps it's time for us to setup development and stable branch so we can fix fast and release fast.

The broad goal for us is that master is always stable and shippable. We tend to keep major new features in their own side branches (see #169, for example). I may be misunderstanding your suggestion, though—please let me know if I'm off the mark.

Thanks, Chambers! That works for me.
On 05/21/2015 09:26 PM, Jon Chambers wrote:

Is it possible to create a release for this patch on 0.4.x branch?

Yes, but it will have to wait for a few days.
perhaps it's time for us to setup development and stable branch so
we can fix fast and release fast.

The broad goal for us is that master is always stable and shippable.
We tend to keep major new features in their own side branches (see
#169 https://github.com/relayrides/pushy/pull/169, for example). I
may be misunderstanding your suggestion, though—please let me know if
I'm off the mark.
—
Reply to this email directly or view it on GitHub
https://github.com/relayrides/pushy/pull/170#issuecomment-104276978.


Windows support

Is it possible to use this on Windows?

Hi - yes indeed!
You can compile this for windows using:
GO111MODULE=on go build -o /replicator .

You can also run the docker image, which will probably be easier if you don't have the go toolchain installed.
Let me know if you have any problems or questions


[Feature] Replace fmt with fmt_ v or something else

When I was programming, my project included both fmt and pocketpy. However, when I tried to compile, I encountered an error with the reference to 'fmt' being ambiguous. I will replace the fmt function with fmt_ v, the error disappeared. I don't know if it was the problem I set up, but the modifications were indeed useful.
pocketpy.h(1677, 24): In instantiation of 'struct pkpy::SmallNameDict<pkpy::PyObject*>':
pocketpy.h(1906, 27): required from 'union pkpy::NameDictImpl<pkpy::PyObject*>::<unnamed>'
pocketpy.h(1905, 6): required from 'struct pkpy::NameDictImpl<pkpy::PyObject*>'
pocketpy.h(1990, 31): required from here
type_traits(3230, 25): declared here
'std::is_pod_v<int>' is deprecated: use 'is_standard_layout_v && is_trivial_v' instead [-Wdeprecated-declarations]GCC

std::is_standard_layout_v && std::is_trivial_v
Another question is _ conflict with the abbreviation of regular gettext, I'm not sure if there's any way to resolve it.

What is the version being used? Are you using the main branch, single header version or cmake?

You will use something like std::fmt, not just fmt. Because our fmt is pkpy::fmt. They are in different namespaces so they won't be conflict with each other.

About std::is_standard_layout_v && std::is_trivial_v, please provide more details I don't understand what you mentioned about.

Sorry, my expression is too vague,I am using a single header file version of 1.4.0(It should be the latest release).
Regarding fmt, I think there may be a conflict with the fmt library. I did not use using namespace pkpy or using namespace fmt, but conflicts still occur.
line 1674
template<typename V>
struct SmallNameDict{
    using K = StrName;
    static_assert(std::is_pod_v<T>);

This cause a warning, so I changed it
template<typename V>
struct SmallNameDict{
    using K = StrName;
    static_assert(std::is_standard_layout_v<V> && std::is_trivial_v<V>);

but I find in line 367, there is already a solution
template<typename T>
struct is_pod {
	static constexpr bool value = std::is_trivially_copyable_v<T> && std::is_standard_layout_v<T>;
};

fmt in pkpy is an internal api. I will rename and hide it.
For the 2nd problem, I think this is a bug. It should be pkpy::is_pod.

Thank you very much, waiting for your repair.


Use NestJS

Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

(Github link to related issues or pull requests)

Checklist

[ ] Change has been tested and works on my device(s).

TODO:

[x] Open API
[x] Recreate all endpoints
[x] Authentication
[ ] Fix tests
[ ] Test all resouces/endpoints work as expected
[ ] Test WebRTC
[ ] Test MDNS
[ ] Test HA Integration

Future features to add:

Websocket
MQTT
GraphQL


fix(userspace/libsinsp): set filtercheck list desturctor as virtual

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
fix(userspace/libsinsp): set filtercheck list desturctor as virtual

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 4d434a0f8dfa4e2135c4b945a8b3ddea48592676

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.11.2


Feature Request: Folding regions for Rust

Folding regions for Rust
The following languages currently have markers defined:
TypeScript/JavaScript: //#region and //#endregion and //region and //endregion
C#: #region and #endregion
C/C++: #pragma region and #pragma endregion
F#: //#region and //#endregion
Powershell: #region and #endregion
VB: #Region and #End Region
CSS/Less/SCSS: /*#region*/ and /*#endregion*/
Coffeescript: #region and #endregion
PHP: #region and #endregion
Bat: ::#region and ::#endregion

Can we please have this functionality for Rust code?
Rust: #region and #endregion would suffice

This works for me nicely if the #region and #endregion are indented all the way to the left. However if they are a bit indented it does not work. @aeschli is this expected?
Here's an example where it is not working (notice the indentation)
fn main() {
    // The statements here will be executed when the compiled binary is called

	#region
 	///my region
	#endregion

    // Print text to the console
    println!("Hello World!");
}

Sound like a bug to me.

@isidorn it does work if the code within the #region #endregion is also indented. Kind of forces you to indent your code within regions which I personally like. Not sure if this is by design though.

The PR added only// region and // endregion as folding regions. For consistency we should also support // #region and // #endregion. That was the original request and what @isidorn tried.

Verified. But the code in the region has to be indented for this to work.

@bpasero read my comment from above, this should also work if the code is not indented as well. Reopening so @aeschli can decide if this is intended

A few thoughts:

Sorry that I didn't support //#region and friends - it might be worth just copying the Typescript ones into Rust: https://github.com/Microsoft/vscode/blob/1eb0b5bc91f637940facfd0c509a2c35b16f3969/extensions/typescript-basics/language-configuration.json#L29-L34
However, the Rust Style Guide says that a single space after comment markers should be used. I don't know if this we should require this or just leave it up to tools such as rustfmt. It might be worth asking @nrc's opinion for this

I should have done this originally in #57069, but only made that PR quickly and didn't test it properly.

I don't think Rust supports # comments:
See @isidorn's code in the playground. Try pressing Run and see it error.

Also, once this is done, if the issue with indentation still reproduces in Rust, can we see if it reproduces in Typescript as the region comments would be the same. With some initial testing, I cannot reproduce.

@isidorn the one from isidor

@bpasero Ah, his example is missing the // before region.

However, the Rust Style Guide says that a single space after comment markers should be used. I don't know if this we should require this or just leave it up to tools such as rustfmt. It might be worth asking @nrc's opinion for this

We do prefer a space after a comment, however, we use //! for doc comments, so there is precedent for not using a space where there is punctuation which is changing the 'kind' of a comment. On the other hand, these are used //! words not //!words so //#region would still be different.
In general, Rust and it's tools do not have any 'significant' comments and when people have tried to use them there has usually been a negative reaction. So I don't think using //#region or // #region would be popular. However, I can't think of a better way to do it. The Rust way would be #[vscode::region], but these attributes can only be used on specific AST nodes, they can't be used to mark a point in a file. I don't know of a good solution, so perhaps comments are OK.


(maint) Update docs and license with new branding

This commit updates the CONTRIBUTING, LICENSE and quickstart markdown files
with the new branding name of Puppet and license dates
Note - There are many other instances of Puppet Labs in the codebase.  These will be addressed in later pull requests.

CLA signed by all contributors.

LGTM. Holding off on merging for now until we get a green build all the way through CI.


stop discovery and start to connect

I want to connect with ble device, but I only know UUID, therefore I try to discovery with UUID, discovery result managed to get ble device that I want. But when I want to connect, it can not be done because discovery continues to run, I am very confused how to stop discovery and connect with the ble device.

Someone feel free to correct me if there is a better way (I'm still quite new to this library).
I found that once device_discovered is triggered on a scan I can run self.stop() to stop the scanning if the devices matches my requirements. Modified from the example in the readme:
class AnyDeviceManager(gatt.DeviceManager):
    def device_discovered(self, device):
        if(True):
            self.stop()

is not working, i don't know why super().run() blocking loop

#32


[Mac] Dark mouse cursor is hard to see on dark background

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: OS X 10.11.6
Hyper.app version: 0.8.3 (<IP_ADDRESS>3)
The issue is reproducible in vanilla Hyper.app:

Issue

Hyper is cool! But I find the default mouse cursor of OS X is hard to see on dark background, especially when the screen is full of text.

System-provided terminal and iTerm2 use custom image of mouse cursor like this:

(source: https://github.com/gnachman/iTerm2/blob/master/images/IBarCursor-huge.psd)

Some text editors like VS Code, Sublime Text have both white and black mouse cursor. They choose color against the  background color of theme.
A temporary workaround is adding the following css into termCSS , which replace the original  cursor with the white one in vscode.
 * { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; }

(source:
https://github.com/Microsoft/vscode/blob/master/src/vs/editor/browser/viewParts/lines/viewLines.css#L45
https://github.com/Microsoft/vscode/issues/754 )

Agreed. I use this to mostly have the default cursor.
    termCSS: `
      * {
        cursor: default;
      }
      x-row span {
        cursor: text;
      }
    `,

iterm2 does this really well

The termCSS fix is not working on my hyper.js terminal

The currently proposed solutions didn't work for me until I moved the rules to css: instead of termCSS:.
~/.hyper.js
css: `
  .xterm {
    cursor: default;
  }
`,

(Hyper 2.0.0 Stable)

If you'd like to use the white cursor as mentioned in #1045 (comment), then this the configuration that worked for me:
    // custom css to embed in the main window
    css: `
      * { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; }
    `,

where would you have to add this code?


Upload to Opera addons catalog

Have you considered making this extension available to Opera users? You don’t even have to change the code — all you’d need to do is upload it at https://addons.opera.com/en/. Thanks for considering!

Sure! No reason why it only needs to be for chrome.
I'm using some chrome apis for storage/stuff - https://github.com/hzoo/github-contributor-extension/blob/master/src/background.js#L4-L11 - so even that doesn't need to be modified?
Thanks for the suggestion @mathiasbynens

@hzoo Even that should work! There’s very few Chrome Extension APIs that Opera doesn’t support, so the majority of Chrome extensions just work™ in Opera. Thanks!


Update storage driver docs

Proposed changes
I think using image size is easier to understand for reader.

Sounds good. Let's ship it!


Fixing ehcache flaky test

Description
Fixing flaky test within EhcacheDiskCacheTests
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/12758
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
~[ ] Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta Can you take a look at this one?

@reta Build passed! Can you merge this? We will also need a backport 2.x label.


Add some system columns for any tables

Is your feature request related to a problem? Please describe.
Expose rw_timestamp on any tables.
Because our subscription already exposed a timestamp rw_timestamp based on epoch, I think there isn’t any concern about exposing the internal epoch using a hidden column.
Besides, I think vnode and epoch is also useful in some cases. How about do them together?
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
Slack discussion https://risingwave-labs.slack.com/archives/C048771BGKF/p1691737477347599?thread_ts=1691732764.258889&cid=C048771BGKF

Some additions: they can only be referenced by a batch query and not by a streaming query.

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

Sorry, please ignore them. Let's start from rw_timestamp now. Please check this Slack thread for context.

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

The requirements come from the debugging and trouble shooting for the tricky bugs such as https://risingwave-labs.slack.com/archives/C048771BGKF/p1691736276987669?thread_ts=1691732764.258889&cid=C048771BGKF


fix of packages.json required to get running

Non existent file in package.json reference.  Thanks for porting this, looking to contribute where I can!

Any updates on this PR? It fails every build without this fix.


raidboss: DSR Add initial Shining Blade Timings

This adds the initial hit to the timeline for the one and two sword marker groups during sanctity. This helps with landing a heal between the swords before movement is required to dodge orbs in daylight strategy.

Could potentially add the 3rd and 4rth hit, but I don't think those are necessary and even adding a line for the first hit seems a bit unnecessary as the Server is 0.1s within the hit, but I did it for completeness of the two first hits.

I need to make an edit, the Server is the one that does the hit.

The reason the duration was there was because it was covering multiple hits.  Do you think it'd make sense to just list the 4 hits out individually at this point?

The reason the duration was there was because it was covering multiple hits. Do you think it'd make sense to just list the 4 hits out individually at this point?

I have added the other two hits as it is easier to see it coming than interpreting the two duration bars. This could also help for reaction if something needs to be swift cast or timed before the 2nd hit.


Mat4 attribute when targeting MSL results in attributes being used more than once

I have the following vertex shader inputs -
layout (location = 0) in vec3 a_position;
layout (location = 1) in vec3 a_normal;
layout (location = 2) in vec4 a_color;
layout (location = 3) in mat4 joint;
Using glslang to produce SPIR-V and then invoking SPIRV-cross targeting metal, the following MSL is produced -
struct main0_in
{
float4 joint_0 [[attribute(0)]];
float4 joint_1 [[attribute(1)]];
float3 a_position [[attribute(1)]];
float4 joint_2 [[attribute(2)]];
float3 a_normal [[attribute(2)]];
float4 joint_3 [[attribute(3)]];
float4 a_color [[attribute(3)]];
};
Which produces the following error when the msl is compiled -
error: 'attribute' index '1' is used more than once
I tried setting joint to location 0 and position, normal and color to 4 5 and 6 respectively, but the same code was generated.
Am I doing something wrong here, or is this a legitimate issue?

hm.. it's generally recommended to not use matrix type as vertex input because of register allocation and just use multiple vectors. but this is also weird, have to dig deeper, but maybe a glslang or spirv-tools bug as well.
anyway, I changed your mat4 to 4 vectors:
layout (location = 0) in vec3 a_position;
layout (location = 1) in vec3 a_normal;
layout (location = 2) in vec4 a_color;
layout (location = 3) in vec4 joint_1;
layout (location = 4) in vec4 joint_2;
layout (location = 5) in vec4 joint_3;
layout (location = 6) in vec4 joint_4;

and the output is now correct:
struct main0_in
{
    float4 joint_1 [[attribute(0)]];
    float4 joint_2 [[attribute(1)]];
    float4 joint_3 [[attribute(2)]];
    float4 joint_4 [[attribute(3)]];
    float3 a_position [[attribute(4)]];
    float3 a_normal [[attribute(5)]];
    float4 a_color [[attribute(6)]];
};


Firebase Guide Wiki and angular2 RC5 update

Now that the project has been updated to RC5, is the guide 'How to integrate Firebase across all platforms'  still valid or it needs to be updated?
In a fresh project, I am having some issues and probably it is because I am doing something wrong when trying to include Firebase in the new structure.
Thanks in advanced.

@codeback thanks for pinging an issue for this. There are slight modifications that need to be made and I'll update that wiki soon.
In meantime, you like need to do this with your token:
var firebase = require('firebase');

let BOOTSTRAP_PROVIDERS: any[] = [
  ENV_PROVIDERS,
{
  provide: FIREBASE, useFactory: () => {
    return firebase;
  }
},
etc..

The wiki also uses the provide api, but you can just use the literal map as shown above.
Lemme know if this gets you going.


Getting error java.io.IOException: File is not a valid PDF/A input file for PDF/A-1b

Hi Team
We generate the PDF using a print manager and it supports only PDF/A-1b documents. However when I run the mustang.jar command to generate a ZUGfERD PDF, I get an error that it is not a valid PDF/A input file.
Does mustang.jar not support PDF/A-1b input files? If not, any parameter that we can use to ignore this validation?
I am using "java -jar mustang-1.7.8.jar -c" command line for generating the output PDF

Hi,
yes,PDF/A-1b input is supported, unfortunately the PDFBox validation can be very strict, in some cases stricter than e.g. verapdf. Since 2.0alpha you can use the -i parameter to ignore this kind of errors, try mustangproject.org/files/Mustang-CLI-2.0.0-SNAPSHOT.jar
kind regards
Jochen

Hi,
I have tried the below, but I still get the validation error. Can you please help me ignore the validation?
java -jar Mustang-CLI-2.0.0-SNAPSHOT.jar  --action combine -i --source OInvoice.pdf --source-xml ZUGFeRD-invoice.xml --out zugferd-invoice.pdf  --format zf --version 1 --profile E
Source PDF set to OInvoice.pdf
ZUGFeRD XML set to ZUGFeRD-invoice.xml
Ouput PDF set to zugferd-invoice.pdf
Format set to zf
Version set to 1
Profile set to E
Jun 23, 2020 5:25:47 PM org.mustangproject.commandline.Main performCombine
SEVERE: null
java.io.IOException: File is not a valid PDF/A input file
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.ensurePDFIsValidPDFA(ZUGFeRDExporterFromA3Factory.java:106)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.load(ZUGFeRDExporterFromA3Factory.java:65)
at org.mustangproject.commandline.Main.performCombine(Main.java:584)
at org.mustangproject.commandline.Main.main(Main.java:312)

Hi Team
Yes, we have tried using the ignore option, but we still get the error.
Test1:
java -jar Mustang-CLI-2.0.0-SNAPSHOT.jar --action combine -i --source OInvoice.pdf --source-xml ZUGFeRD-invoice.xml --out zugferd-invoice.pdf --format zf --version 1 --profile E
Source PDF set to OInvoice.pdf
ZUGFeRD XML set to ZUGFeRD-invoice.xml
Ouput PDF set to zugferd-invoice.pdf
Format set to zf
Version set to 1
Profile set to E
Jun 23, 2020 5:25:47 PM org.mustangproject.commandline.Main performCombine
SEVERE: null
java.io.IOException: File is not a valid PDF/A input file
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.ensurePDFIsValidPDFA(ZUGFeRDExporterFromA3Factory.java:106)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.load(ZUGFeRDExporterFromA3Factory.java:65)
at org.mustangproject.commandline.Main.performCombine(Main.java:584)
at org.mustangproject.commandline.Main.main(Main.java:312)
Test2:
java -jar Mustang-CLI-2.0.0-SNAPSHOT.jar  --action combine -i --source InvoiceTest.pdf  --source-xml ZUGFeRD-invoice.xml --out zugferd-invoice.pdf  --format zf --version 1 --profile E
Source PDF set to InvoiceTest.pdf
ZUGFeRD XML set to ZUGFeRD-invoice.xml
Ouput PDF set to zugferd-invoice.pdf
Format set to zf
Version set to 1
Profile set to E
Jun 25, 2020 2:21:35 PM org.mustangproject.commandline.Main performCombine
SEVERE: null
org.apache.pdfbox.preflight.exception.SyntaxValidationException
at org.apache.pdfbox.preflight.parser.PreflightParser.parse(PreflightParser.java:257)
at org.apache.pdfbox.preflight.parser.PreflightParser.parse(PreflightParser.java:234)
at org.apache.pdfbox.preflight.parser.PreflightParser.parse(PreflightParser.java:222)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.getPDFAParserValidationResult(ZUGFeRDExporterFromA3Factory.java:136)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.isValidA1(ZUGFeRDExporterFromA3Factory.java:117)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.ensurePDFIsValidPDFA(ZUGFeRDExporterFromA3Factory.java:105)
at org.mustangproject.ZUGFeRD.ZUGFeRDExporterFromA3Factory.load(ZUGFeRDExporterFromA3Factory.java:65)
at org.mustangproject.commandline.Main.performCombine(Main.java:584)
at org.mustangproject.commandline.Main.main(Main.java:312)
Can you please help us with this, to ignore the validation errors?
Thanks and Regards,
Divya
From: Jochen Staerk<EMAIL_ADDRESS>Sent: Tuesday, June 23, 2020 7:22 PM
To: ZUGFeRD/mustangproject<EMAIL_ADDRESS>Cc: Appidi, Divya<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [ZUGFeRD/mustangproject] Getting error java.io.IOException: File is not a valid PDF/A input file for PDF/A-1b (#167)
Hi,
yes,PDF/A-1b input is supported, unfortunately the PDFBox validation can be very strict, in some cases stricter than e.g. verapdf. Since 2.0alpha you can use the -i parameter to ignore this kind of errors, try mustangproject.org/files/Mustang-CLI-2.0.0-SNAPSHOT.jar
kind regards
Jochen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ZUGFeRD_mustangproject_issues_167-23issuecomment-2D648163068&d=DwMCaQ&c=kne2dvCMgnN2K-cxlZBJC3l0HNNb7WroqdHGaKuuoSA&r=fgsGcdpisr5570lnDvNxdMt4Th4o-BRWEw7uXe02Hok&m=wPmpVo9o6k6XVaypqqJH0NjqzItbWcux-A-NZzGA9MA&s=s6B4vsH0FxSmIrRQUI_dJlF6IzrFhtpwfpYW32L1ePQ&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQBT7RT6GEC3U4CKA746U4TRYCXRBANCNFSM4OFS3TGQ&d=DwMCaQ&c=kne2dvCMgnN2K-cxlZBJC3l0HNNb7WroqdHGaKuuoSA&r=fgsGcdpisr5570lnDvNxdMt4Th4o-BRWEw7uXe02Hok&m=wPmpVo9o6k6XVaypqqJH0NjqzItbWcux-A-NZzGA9MA&s=aHDGh-PFDDEzOEFpmEqFK5qmJAPOMiwejicGFEXdkck&e=.

This message and any attachments are intended only for the use of the addressee and may contain information that is privileged and confidential. If the reader of the message is not the intended recipient or an authorized representative of the intended recipient, you are hereby notified that any dissemination of this communication is strictly prohibited. If you have received this communication in error, notify the sender immediately by return email and delete the message and any attachments from your system.

Hi Team,
Would it be possible to have a look at the question that is raised by @DivyaAppidi  ?
As we need this really urgently.
Your help is much appreciated.
Kind regards
Kevin

Attaching one of the sample PDFs if it helps
InvoiceTest.pdf

as mentioned in https://github.com/ZUGFeRD/mustangproject/issues/164#issuecomment-640046774 I recommend Ghostscript for that, I installed 9.52 in c:\gs, copied it's lib\PDFA_def.ps to my download folder, downloaded and extracted the adobe ICC color profiles (https://www.adobe.com/support/downloads/iccprofiles/iccprofiles_win.html) there, adjusted srgb.icc in  PDFA_def.ps and ran
\gs\bin\gswin64.exe -P -dPDFA=1 -sColorConversionStrategy=RGB -sDEVICE=pdfwrite -oOut.pdf -dPDFACompatibilityPolicy=1 -dRenderIntent=3  PDFA_def.ps InvoiceTest.pdf (in my download folder) which produced
Out.pdf which should be your file converted to proper pdf/a (I checked with verapdf), I hope that helps


removes bphash

PR Type

[ ] Breaking change
[x] Feature
[ ] Patch

Brief Description

Fixes #43 by removing bphash. Downstream libraries wanting to hash can do so with whatever library they want.
Not In Scope

Technically #43 calls for redoing the serialization, but serialization will in general will still be needed for MPI so this PR will only remove hashing.
PR Checklist

[x] Documentation (comments, API, user, design, and developer as applicable)

API
User
Design
Developer

[x] Testing (unit, integration, performance, as applicable)

Unit
Integration
Performance

[x] Code adheres to organization standards

C++
Python
Doxygen Conventions
reST Conventions

🚀 [bumpr] Bumped! New version:v0.1.0 Changes:v0.0.5...v0.1.0


Compatibility with Hardware-enforced Stack Protection (/CETCOMPAT)

I was wondering if Detours is compatible with the Hardware-enforced Stack Protection (/CETCOMPAT linker option)?
More details about CETCOMPAT

/CETCOMPAT (CET Shadow Stack compatible)
Developer Guidance for Hardware-enforced Stack Protection

compatible, but can not use with VMProtect similar products.

compatible, but can not use with VMProtect similar products.

I've built Detours with /CETCOMPAT /guard:ehcont fine, and it runs successfully on both non-CET compatible and CET-compatible hardware. Seems to work fine, for my uses (detouring a function in user32.dll). Haven't tried strict mode.


Removed the warning from the file.

Fixed the warning in the file.

Thanks for working on this. Change looks good.
Just one small comment: could you please provide more details about the warning you see, as well as the platform (windows, linux etc) the warnings happens? Thanks.

@jianlijianli , thanks for the review i saw this warnings on the Linux platform, the warning are as below : -
_tensorflow/lite/kernels/kernel_util_test.cc:291:76: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
filter_params->scale->data[0] = reinterpret_cast<float>(&two_pow_neg_31);
The second warning is comparison of int and unsigned int , in the file  string_util.cc_
I also have one request , can you pls also check and approve my PR
https://github.com/tensorflow/tensorflow/pull/26977


fix issue 18580 - std.conv.to!(const ubyte[])(void[]) should work

This PR allows the conversion from void[] to immutable and const ubyte[]. This will be useful for example to transform the result of std.file.read in @safe functions.

I'm gonna close this. It was only motivated for usage in D:YAML actually, which has to trust std.file.read.
Maybe it's better to make the file function safe.


[WIP] PhasedISwapPowGate constructor does not take global_shift

Fixes #4570

Please add tests / test cases to existing tests which probe the behavior of the class with different values passed for the global_shift parameter.

Can you please share some resource ? It is new for me 😄

@anonymousr007 You can take a look at pytest docs to get a high level overview of how tests work (see https://docs.pytest.org/en/6.2.x/). You should also look at cirq-core/cirq/ops/phased_iswap_gate_test.py file which stores existing tests for the class that you are modifying.
As part of this PR, you'd have to add additional tests in cirq-core/cirq/ops/phased_iswap_gate_test.py such that newly added behavior is tested. You can run the existing and newly added tests locally before updating the PR by following the guidelines mentioned in https://github.com/quantumlib/Cirq/blob/master/docs/dev/development.md#continuous-integration-and-local-testing

@anonymousr007 Gentle reminder. Please address the comments so that we can approve the PR.

Closing as stale and opening https://github.com/quantumlib/Cirq/pull/5328


Extend test suite for pydata-sphinx-theme

Now that #227 is merged we have a basic testing infrastructure set up for the theme. This will let us test the HTML outputs that are generated by the theme, using BeautifulSoup.
We should add more tests for the following things:
Make sure that...

sidebars behave expected for nested toctree pages
the navbar / sidebar behaves expected for things like external links in toctrees
buttons show up when activated (E.g. github button, edit this page button, etc)
logo etc behave as expected when they are added / not added
numbering of sidebar sections works with :numbered: flag
Special characters in navbar / sidebar work (e.g. equations or formatted text)
The header has the structure we'd expect (e.g. JS and CSS imports, social media metadata, etc)

For each of these, I think the easiest thing to do is:

Use beautifulsoup to select the subset of a page we want to test
Use file_regression to test its structure against a reference we have committed to the tests folder

See the contributing documentation for some guidelines on how this works!
Note that I'm also making this issue because I'll likely go on paternity leave sometime in the next several weeks so probably will not be able to personally do this but I am happy to help advise and guide others!

What you describe in this issue is the exact structure of the current tests so my guess is that you implemented it without closing the issue.
Let me know if other stuff need to be taken care of before closing.

I'm going to hijack update this issue to reflect the current state of testing, and what I see as needing improvement. Others please feel free to add to this list:

systematic test of components. I think this could be something like mocking each component to be a short, unique text string (or little square of color?), and testing for presence of that element in the rendered doc (as well as correct placement, breakpoint behavior, etc). TBD how thorough we need to be here; testing all possibilities may be prohibitively time-consuming and hard to keep current. But for example, the "fix" in #1583 for breadcrumb truncation is stalled because it will (probably!) only work if the breadcrumb is in the article header (not in footer, content footer, sidebar, etc). I say "probably" because it's not tested yet, and if we had thorough component tests in place it would be easy to know for sure.
systematic test of config values. Several of our config values interact in complicated ways: e.g. sidebar_includehidden, navigation_depth, collapse_navigation, and show_nav_level (and navigation_startdepth, if #1241 ever gets sorted out). Bug reports like #1551 show that we're not testing that well enough.
accessibility testing. work here is already underway, cf. #1428, just mentioning here to say that it's being tracked and worked on.
version switcher testing. I don't think we can test all possible cases, but we should at least try to test more of them, so that changes to the version switcher don't cause regressions. We can look to the various bug reports / feat requests from the community for inspiration on what configurations we should test.
clean up the doc build warnings. every time I do a local doc build I panic a bit when all those "expected" warnings fly by. It would be nice/helpful if the default state of our doc build was no visible warnings so that we didn't have to run a separate test to see if the doc build was "clean" or not.
eliminate the webpack warnings. Similar motivation as (5) --- fewer warnings during "normal" functioning make problems easier to spot.

I just want to chime in here that I think this is a super important issue if we ever want to get PyData Theme to a stable release. Based on my experience working on the theme over the past several months, I would say it's a little too easy to break something while trying to fix something else.
Some of the kinds of tests I would like to add via Playwright are things like "does this button have a focus ring", "is the focus ring still visible when the button is hovered with a mouse", etc.

some work on that is underway as we speak. The initial target is #1583 but the plan is that the playwright tests for that can be a template for similar tests for other UI elements / components.


[ISSUE #367]Fix the get connection bug when sending transactional check request

Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
When sending a transaction check request, ProducerManager returned available connection is not the current connection, but the next connection.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.004%) to 42.201% when pulling 5fc2032fbcb893300adc2ac29e275ecf4a3aabc2 on duhengforever:develop_fix into d8c446e854e6cce1b54c0d9d97f3189832b88001 on apache:develop.


Document geodistance filter and predicate

The developer docs for the API don't describe the geodistance search.
Example search filter: https://api.gbif.org/v1/occurrence/search?geoDistance=90,100,5km (lat,lng, distance)
Predicate:
{
"creator":"...",
"notification_addresses": ["..."],
"send_notification":"true",
"format": "DWCA",
"predicate":
{
"type":"geoDistance",
"latitude":"90",
"longitude":"100",
"distance":"5km"
}
}

geoDistance is documented on the new technical documentation site for both searches and downloads.
https://techdocs.gbif.org/


Add suspicions filter to the API

cc @diegodorgam

Changes Unknown when pulling 0d0c601e004baaed969e7df3664acdaef6fbc2b7 on cuducos-add-supicion-filter-to-the-api into ** on master**.


Trolley positions frozen

I noticed that the web app trolley positions have been frozen for the past few days (I kept forgetting to report it).    Other apps show normal position.

This was fixed in the other repo a while ago.


fix Loading Image for Native

fix regression for Native introduced with https://github.com/BabylonJS/Babylon.js/pull/14620

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14634/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14634/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14634/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14634/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14634/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14634/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14634/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14634/merge#BCU1XR#0


add topic modeling library

Both of these repos are no longer maintained. Additionally, the sentence embedding repo approach i.e. SIF is originally from here: https://github.com/PrincetonML/SIF
While the layer and optimizations are definitely useful, they are not common enough usecases to be listed alongside Huggingface. That list has a specific bias towards swiss-army-knives.
Happy to add it in the Python libs list. Please edit your PR for the same?

Got it. Have just deleted fse. Let me know if it looks good

Thanks for mentioning this!


Verification error + no opaque tile

I enabled the "opaque tile" option but it didn't work. Tried re-pinning the tile and doing a soft reset but still didn't work. Perhaps re-installing the app might work but I'm not really willing to try cause of that oh so sweet sweet Yakarma. lol
Also, when i tried verifying my phone to post a Yak, I got the text, entered the code in, but got this error message each time.

I can confirm the verification error.

Either Yik Yak's verification isn't working right now or I did something very wrong. It worked fine last time I tried it...
I'll check it out shortly.

 I just tried it again in the emulator and it worked fine. I don't know what's wrong.
Would either of you be open to doing some mildly complicated debugging? I can walk you through it, but you'll need a PC and you'll need to be on your home WiFi. It would probably take 10-15 minutes.
Also, @spencejah, are you exiting the settings page (via the back button) before checking the tile? The checkbox won't save until you leave settings.

Hi, I was able to go trough verification process just fine hours later so it might have been on the YikYak's side...
I can do some debugging if it helps, but not sooner than 11 hours from now.
I'll check here tommorow aroud 8-9am CET.

Yes, others have reported that trying it again works...but I'd still like to know why it's failing the first time. I'm going to see what I can do about it tonight and report back before Thursday morning.

Some additional info: When it didn't work I tried it several times and YikYak always gave (SMS) me the same verification code number, when I tried again later (and it worked) the code was different. This could be just how it works and is not related...

No, it's definitely supposed to work the first time. It always does for me, whether I use the official Android app or Yodel. This is a bug.
Thanks for the info though, I appreciate it.

Good news! I managed to trigger the error you're all getting. A fix will be out by Thursday morning.

The update that fixes the verification bugs, <IP_ADDRESS>, is live in the Store. Try it out!


Feature Request: Press a key for "path" to current element

Just tried jless after seeing on hacker news -- would it be possible to add a way to output the path to a given element?
e.g.
This would be super helpful when inspecting through highly nested json packets.

The path to the currently focused node is displayed in the bottom status bar, relative to the input, e.g., input.foo.bar[2].qux.
By default it formats object keys using .key, unless the key is not a valid JavaScript identifier (matches the regular expression "^[_$a-zA-Z][_$a-zA-Z0-9]*$), in which case it renders it as ["key with space"]. I can imagine a scenario where you always want the ["key"] syntax, even for valid identifiers. That's probably makes sense for "line" mode (press m to see the input as actual JSON).
Is there some functionality you're looking for that's different that that?
You mention deeply nested packets, and the path is truncated when longer than the width of the screen, which, if you need the whole path, is a problem. You could try making your screen wider in that case, but obviously that solution has its limits, and is inconvenient.
I have also considered adding support for copying things to the clipboard, but there are a lot of different things you could want to copy, so I've thought of using two key commands starting with y for different things:

yy: copy the current value, pretty printed
yo: copy the current value, pretty printed on one-line
yd: copy the current value, printed as compactly as possible
yp: copy the simplified path to the current node, e.g., .foo.bar[2].qux
yj: copy the "pure" path to the current node, e.g., .["foo"]["bar"][2]["qux"]
yq: copy a jq style path that includes the current node, e.g., .foo.bar[].qux

The support for copying to the clipboard sounds fantastic!

What about the ability to quit the UI and print that path, for consumption by other cli tools?

I added the support for yy, yo, yp and yj in this PR: #18 . What should the behaviour be for yq. How should yd be implemented ?

Support for copying paths is now available in the v0.8.0 release by using yp (normal path), yb (path but always uses square brackets for object keys) or yq (jq style path). Copying values can be done with yy (pretty printed) or yv (not pretty printed), and yk copies object keys.


Hi   can anyone know how to solve this problem ??    The getter 'generator' isn't defined for the type 'Router'. Try importing the library that defines 'generator', correcting the name to the name of an existing getter, or defining a getter or field named 'generator'.

Hi @mazin-dotcom
Check out  https://flutter.dev/docs/cookbook/navigation/named-routes and other official docs at https://flutter.dev/docs
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

@TahaTesser  Thank you


@mf-types.zip not being generate since 0.2.7

Describe the bug
GenerateTypesPlugin is having trouble generating the zip file for @mf-types.
Replication is just bumping the plugins version to 0.3.3 of an rspack app from mf examples repo.
.
Reproduction
https://github.com/module-federation/module-federation-examples/tree/master/rspack_hmr/app2
Used Package Manager
pnpm
System Info
System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M2 Pro
    Memory: 213.69 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.10.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    pnpm: 9.5.0 - ~/.nvm/versions/node/v20.10.0/bin/pnpm
  Browsers:
    Chrome: 127.0.6533.89
    Safari: 17.5

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

@2heal1 can you take a look?

i have same issue on webpack plugin

does the build crash? or just throw error?

does the build crash? or just throw error?

@ScriptedAlchemy
Only warns.
It doesn't crash.
Types are being built, they appear inside the bundle, but they just don't get zipped apparently.

Types are being built, they appear inside the bundle, but they just don't get zipped apparently.

Hi guys! I bumped into the same exact issue, but in my case types are not generated at all. The bundle is built (static JS-chunks + manifest files), but neither /@mf-types folder nor @mf-types.zip is present inside /dist folder
The error i get when i run build script:

The /dist folder after build script execution

The @mf-types folder generates only when i manually try to run the ts-compile command from error message above, which is 'npx tsc --project /node_modules/.federation/tsconfig.8e832ac4f46027611fcdf3bf665e47de.json'

I have "@module-federation/enhanced": "0.3.5" installed.
Another problem is that dts options do not override the given defaults. When researching the problem, i was trying to give a types-zip-file another name according to the instructions https://module-federation.io/configure/dts#typesfolder :
dts: {
    typesFolder: 'custom',
},

But when i run my build command again with specific typesFolder name, i still meet the same error message as it was:
 ENOENT: no such file or directory, open<EMAIL_ADDRESS>saying that @mf-types.zip is missing but not the custom.zip as it is supposed to be.

Some updates to my notes here :)
So if we take a closer look to an error it firstly says that TS compile failed: Error: compile TS failed

and there is the log of the original command which is failed: npx tsc --project <path-to-my-packege>/node_modules/.federation/tsconfig.8e832ac4f46027611fcdf3bf665e47de.json
So if i try to run this command manually i get i few TS erros while compiling. These errros come from @types/ws package:

Here is the exact place of code which TS doesnt like https://github.com/DefinitelyTyped/DefinitelyTyped/blame/master/types/ws/index.d.ts#L312
Soooo if i go to<EMAIL_ADDRESS>and manually remove generics from the type  (i know it is a dirty hack but wanted to check if it will work) it fixes TS compilatiion. And when i re-run my build command again all the types and zip-file itself generate successfully 🥳

Do you happen to have any updates on this one?
Had the same issue,
It happens both on my project and module-federation rs-pack example

because now mf types will use project's tsconfig.json , so you can set "skipLibCheck": true, in tsConfig.json compilerOptions to prevent the error

because now mf types will use project's tsconfig.json , so you can set "skipLibCheck": true, in tsConfig.json compilerOptions to prevent the error

I have this in my tsconfig. The same error is still there..
Unable to compile federated types, Error: compile TS failed, the original command is 'npx tsc --project /Users/xxxx/zzzz/node_modules/.federation/tsconfig.6dd5cd1b6230eccdafd02f44d0cfb6a2.json'
Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>

I have this in my tsconfig. The same error is still there.. Unable to compile federated types, Error: compile TS failed, the original command is 'npx tsc --project /Users/xxxx/zzzz/node_modules/.federation/tsconfig.6dd5cd1b6230eccdafd02f44d0cfb6a2.json' Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>
Try to run the specified command from the error message (in your case it is npx tsc --project /Users/xxxx/zzzz/node_modules/.federation/tsconfig.6dd5cd1b6230eccdafd02f44d0cfb6a2.json) and see what the TSError looks like

@ryok90  upgrade to 0.6.5 , the issue should be fixed , if still has error , please tell me , i will fix it soon

I'm still facing this issue for vue project:
import { defineConfig } from "@rsbuild/core";
import { pluginVue } from "@rsbuild/plugin-vue";
import { ModuleFederationPlugin } from "@module-federation/enhanced/rspack";

export default defineConfig({
  plugins: [pluginVue()],
  dev: {
    assetPrefix: true,
  },
  tools: {
    rspack: {
      output: {
        uniqueName: "vue_mfe_app",
      },
      plugins: [
        new ModuleFederationPlugin({
          name: "vue_mfe_app",
          exposes: {
            "./App": "./src/App.vue",
          },
          shared: ["vue"],
          filename: "remoteEntry.js",
        }),
      ],
    },
  },
});

Note the line "./App": "./src/App.vue",

We've upgraded to this version and can confirm that the types are now generated as expected.
For those still facing this issue: Ensure you do not have Typescript errors within your project. When we had errors this lead to the mf-types.zip not being generated. If that file was missing for a remote app, the host app would then delete the types from its mf-types folder too. So ensure there are no Typescript errors in any of your applications.

I came across this issue as well and was able to resolve by changing the exposed path from the root of the project to it's relative path. The problem was hard to identify because using the path from the root of the project worked when the type generation was disabled.
Configuration that caused the failure:
new ModuleFederationPlugin({
          ....
          exposes: { './Foo': '/src/components/Foo.tsx' },
          ...
})

Fixed configuration:

new ModuleFederationPlugin({
....
exposes: { './Foo': './src/components/Foo.tsx' },
...
})

Yeah. Same rules as package.json exports field

In my point of view the solution is already addressed here by:

@2heal1 (version update + solution path to adding custom strategy runtime plugin)
@pganster (ensure clean build by resolving all TS issues beforehand)
@jeremy-leclerc (making sure the exposes field is poperly set)

I will write a short doc for this on the Error Catalog guide
After that we can close this issue.

Docs updated, issue can be closed

Just in case it helps someone else coming here. I was having the same issue, but it was due to the fact that I already had a tsconfig.json in the directory (which it extends when found) which had some settings that conflicted with what it expected.
Also worth pointing out that even once I fixed that and the types generated properly on the first run without errors, every subsequent run generated a new tsconfig file and appended the newly generated types as files into the files list, which then promptly errors out:
Second run generated a tsconfig which has the previously generated .d.ts files:
{
  "extends": "/Users/arimus/workspace/dynamic-remotes-node/remote/tsconfig.json",
  "compileOnSave": false,
  "compilerOptions": {
    "rootDir": "/Users/arimus/workspace/dynamic-remotes-node/remote",
    "emitDeclarationOnly": true,
    "noEmit": false,
    "declaration": true,
    "outDir": "/Users/arimus/workspace/dynamic-remotes-node/remote/dist/@mf-types/compiled-types"
  },
  "include": [],
  "files": [
    "/Users/arimus/workspace/dynamic-remotes-node/remote/src-js/expose-sample.js",
<EMAIL_ADDRESS>    "/Users/arimus/workspace/dynamic-remotes-node/remote/src-js/expose-sample.d.ts"
  ],
  "exclude": []
}

Manually re-running the tsc command gives:
npx tsc --project /Users/arimus/workspace/dynamic-remotes-node/remote/node_modules/.federation/tsconfig.db9093e72f99b2653ae903ff6c203eea.json
remote/dist/@mf-types.d.ts:3:86 - error TS2307: Cannot find module 'REMOTE_ALIAS_IDENTIFIER/sample' or its corresponding type declarations.

3     type PackageType<T> = T extends 'REMOTE_ALIAS_IDENTIFIER/sample' ? typeof import('REMOTE_ALIAS_IDENTIFIER/sample') :any;
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in remote/dist/@mf-types.d.ts:3

I can open a new ticket if you guys want to track this issue separately, but wanted to get here for visibility. Technically, most folks won't run into this unless they have a tsconfig.json for some reason in a JS project that's being webpack'd without transpilation. I ran into it because I have a project where I'm doing both examples. That said, it's pretty easy to run into this issue accidentally when trying diff things out, so worth documenting here anyways.

Interesting case. I will try to reproduce it and add it to the docs. Thanks for the investigation @arimus !


Not show bypass low Target SKD block

Bypass low Target SKD block not showing

On which Android ver. ?
Possibly a duplicate of #32


Subtitles in any language

Hi!
I like watching anime with English dub and subtitles in my native language. Unfortunately, CR only allows me to choose a subtitle language if the audio is in Japanese. If I change the audio to English, it only lets me choose English subtitles.
Would it be possible to implement a system allowing to choose any subtitle language independently from the audio language?
Thanks.

Thanks for your feedback! I've already discussed this with someone and took a look at it. Unfortunately, integrating such a system without additional unwanted permissions didn't seem easily feasible. However, despite expressing interest in involving a developer for a potential pull request, I haven't received any further communication from them. Unfortunately, I currently don't have the time to handle it myself. Appreciate your understanding!

I don't know what you talked about with this person @ThomasTavernier sou maybe you're already aware of what I'm about to say.
It's often the case that the video length of different audios aren't the same. For example the first episode of Darling in the Franxx is 24 minutes long with japanese audio, but only 23 minutes and 58 seconds long with german audio. So loading the german subtitle that belongs to the japanese audio into the german video will cause the subtitle to be out of sync with the audio.


Save as Startup file

Hello,
your software works great. I can see all my tile layers.
Can I save my configuration in a file so that when starting the application again I will see my layers.
Now I have to configure the application every time I start it.
Thanks
Best regards Gerhard

The entire configuration can be saved in the URL as configuration parameters. Hence, when you open the URL, all layers and configuration options are automatically restored from the URL parameters.
In order to generate this link just open the "Toolbox" menu and click on "Generate Scene Link". This will create hyperlink that contains the entire configuration including the current camera position and information about activated and deactivated layers. The link can become quite long, but this does not seem to be a problem for modern browsers. You can then bookmark or share the link with others.
Hope this resolves your question
Best regards
Thomas Kolbe

Thanks for your quick answer.
I tested it and it works for me.


Recommend increasing keepalive_requests in nginx config

Our sample nginx configuration in https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/linux-nginx?view=aspnetcore-5.0#configure-nginx does not configure a keepalive_requests to be higher than its default value of 1000: http://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_requests
In older versions of nginx, this defaulted to 100 leading to even worse perf. We should consider increasing this (to Int32.MaxValue?) in our sample config. It might be worth consulting with nginx experts about why the default is lower. But in YARP for example, there is no per-connection request limit by default.
@sebastienros @Tratcher

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcdd2c35-bf2b-2673-d150-303a8aaa54d2
Version Independent ID: 815fe034-c9fc-aee3-a8b5-f2e860b30302
Content: Host ASP.NET Core on Linux with Nginx
Content Source: aspnetcore/host-and-deploy/linux-nginx.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Tratcher highlighted this section of the docs which does make me worry that nginx's default value for keepalive_requests is working around some memory leak in nginx:

Closing connections periodically is necessary to free per-connection memory allocations. Therefore, using too high maximum number of requests could result in excessive memory usage and not recommended.

It's also possible they default to this to work around potential per-connection memory leaks in the backend. I've always found it odd that nginx hasn't switched to defaulting to keep-alive connections by now and have wondered if that is the reason. Kestrel's keep-alive timeout (along with nginx's' own keepalive_timeout and keepalive_time for that matter) should mitigate this "excessive memory usage".
Either way, this is why I've suggested consulting nginx experts about why the defaults are what they are today before making any hasty changes.

@sebastienros @Tratcher please review

@Rick-Anderson we are not the nginx experts @halter73 is asking for. We need to refer this question to the nginx project/community directly.

Posted question to https://nginxcommunity.slack.com/archives/C02MRSU7CKT/p1676586493082559

Here's the response I got back from nginxcommunity.slack.com:

you can safely increase keepalive_requests to, say, millions.
the thing is that sometimes openssl has bugs, sometimes nginx may have problems masked by internal memory allocator. It may also happen that a 3rd party module will have a problem and finding proper balance may be a bit tricky
in most common scenarios though 1k or 1m doesn't make much difference =) most of users will never have 1M requests in a reasonable time. Those who will can tune nginx themselves


Favicon | Change to OBI

Kindly change the favicon to OBI logo (of both the frontend and the cms)

favicon added on budget basics


PythonRunPyLintCommand MessageRegex

This is realted to #634
Is it possible to add Regex for Message portion of Error List window?
I modified C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Microsoft\VisualStudio\v15.0\Python Tools\Microsoft.PythonTools.targets to provide custom pytlint format:
<PropertyGroup>
    <PythonCommands>$(PythonCommands);PythonRunPyLintCommand</PythonCommands>
    <PyLintWarningRegex>
        <![CDATA[^(?<filename>.+?)\((?<line>\d+),(?<column>\d+)\): warning (?<code>.+?): (?<message>.+?)$]]>
    </PyLintWarningRegex>
    <PyLintErrorRegex>
        <![CDATA[^(?<filename>.+?)\((?<line>\d+),(?<column>\d+)\): error (?<code>.+?): (?<message>.+?)$]]>
    </PyLintErrorRegex>
</PropertyGroup>

<Target Name="PythonRunPyLintCommand"
      Label="resource:Microsoft.PythonTools.Common;Microsoft.PythonTools.Common.Strings;RunPyLintLabel"
      Returns="@(Commands)">
    <CreatePythonCommandItem Target="pylint.lint"
                         TargetType="module"
                         Arguments=""--msg-template={abspath}({line},{column}): {category} {msg_id}: {msg} [{C}:{symbol}]" -r n @(Compile, ' ')"
                         WorkingDirectory="$(MSBuildProjectDirectory)"
                         ExecuteIn="output"
                         RequiredPackages="pylint>=1.0.0"
                         WarningRegex="$(PyLintWarningRegex)"
                         ErrorRegex="$(PyLintErrorRegex)">
        <Output TaskParameter="Command" ItemName="Commands" />
    </CreatePythonCommandItem>
</Target>

But it just silently discards minor information into the output window.

This will almost certainly be due to the regex not matching the lines you expect.
Can you post a sample log (what goes to the output window) and show us which ones you want to be collected to the Error List? Perhaps we can help fix the regex.

Oh, I mean we have WarningRegex, ErrorRegex and I was asking (feature request?) whether I can somehow feed Message Window:

I wanted to filter pylint messages out from Errors/Warnings but still be able to seem them in Messages.

Ah, got it. I'll tag this appropriately, but if you want to have a go at adding it yourself the implementation is here (and our build instructions are here)

You'll also have to update this part, but I think that's basically all that's involved.


Older version of WebKit does not have Function.prototype.bind defined in ECMAScript 5.1...

Traceur is supposed to translate to ECMAScript 5. Function.prototype.bind is only standard in "ECMAScript 5.1 (ECMA-262) The definition of 'Function.prototype.bind' in that specification."
I'm able to use a polyfill but if Traceur is truly generating ECMAScript 5 then it should not count on this being available in the browser. I'm using a custom "corporate" Qt version of Webkit...

Not true. bind is part of ES5. 5.1 is just an errata of 5.
Try this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind#Polyfill

Yes the polyfill works, just thought you might add that to traceur in case it is not defined, would save hassle for other ECMAScript5 browsers that did not implement the errata 5.1?

Erratas do not add any new functionality. @arv has already said it, Function#bind is part of ES5, not ES5.1.


Fixed bugs of exception logging

--- Logging error ---
Traceback (most recent call last):
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 236, in _get_or_create_publisher
    client = await self._get_or_create_client(stream)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 211, in _get_or_create_client
    self._clients[stream] = await self._pool.get(
                            ^^^^^^^^^^^^^^^^^^^^^
  File "/home/app/.local/lib/python3.12/site-packages/rstream/client.py", line 768, in get
    await self.new(
  File "/home/app/.local/lib/python3.12/site-packages/rstream/client.py", line 841, in new
    await client.start()
  File "/home/app/.local/lib/python3.12/site-packages/rstream/client.py", line 236, in start
    await self._conn.open()
  File "/home/app/.local/lib/python3.12/site-packages/rstream/connection.py", line 37, in open
    self._reader, self._writer = await asyncio.wait_for(
                                 ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/asyncio/tasks.py", line 520, in wait_for
    return await fut
           ^^^^^^^^^
  File "/usr/local/lib/python3.12/asyncio/streams.py", line 48, in open_connection
    transport, _ = await loop.create_connection(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1129, in create_connection
    raise OSError('Multiple exceptions: {}'.format(
OSError: Multiple exceptions: [Errno 111] Connect call failed ('::1', 5552, 0, 0), [Errno 111] Connect call failed ('<IP_ADDRESS>', 5552)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/logging/__init__.py", line 1160, in emit
    msg = self.format(record)
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/logging/__init__.py", line 999, in format
    return fmt.format(record)
           ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/logging/__init__.py", line 703, in format
    record.message = record.getMessage()
                     ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/logging/__init__.py", line 392, in getMessage
    msg = msg % self.args
          ~~~~^~~~~~~~~~~
TypeError: not all arguments converted during string formatting
Call stack:
  File "/usr/local/lib/python3.12/threading.py", line 1032, in _bootstrap
    self._bootstrap_inner()
  File "/usr/local/lib/python3.12/threading.py", line 1075, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.12/threading.py", line 1012, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1986, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 617, in _timer
    await self._publish_buffered_messages(stream)
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 627, in _publish_buffered_messages
    await self._send_batch_async(stream, self._buffered_messages[stream])
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 415, in _send_batch_async
    publisher = await self._get_or_create_publisher(
  File "/home/app/.local/lib/python3.12/site-packages/rstream/producer.py", line 269, in _get_or_create_publisher
    logger.exception("error declaring publisher: ", ex)
Message: 'error declaring publisher: '
Arguments: (OSError("Multiple exceptions: [Errno 111] Connect call failed ('::1', 5552, 0, 0), [Errno 111] Connect call failed ('<IP_ADDRESS>', 5552)"),)

Hi @aborigeth,
Can I ask to add more details on this? How can the problem be reproduced, and what kind of problem does the PR fix?

The problem is formatting arguments of logging function. It expects placeholders.
To reproduce you can publish messages to non-reachable rabbitmq host.
-------- Original Message --------
On 10/29/24 3:42 PM, Gabriele Santomaggio  wrote:

Hi @.***(https://github.com/aborigeth),
Can I ask to add more details on this? How can the problem be reproduced, and what kind of problem does the PR fix?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@aborigeth thank you.
I have tested the PR with basic_consumer_binary.py and the broker down:
Commit: e0bde6858c7852fc23975ecae28a4cf34f475bba ( the current master):
/Users/gsantomaggio/git/qweeze/rstream/venv/bin/python /Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py
Traceback (most recent call last):
  File "/Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py", line 36, in <module>
    asyncio.run(consume())
  File<EMAIL_ADDRESS>line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py", line 31, in consume
    await consumer.start()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/consumer.py", line 128, in start
    self._default_client = await self._pool.get(
                           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 768, in get
    await self.new(
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 841, in new
    await client.start()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 236, in start
    await self._conn.open()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/connection.py", line 37, in open
    self._reader, self._writer = await asyncio.wait_for(
                                 ^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 520, in wait_for
    return await fut
           ^^^^^^^^^
  File<EMAIL_ADDRESS>line 48, in open_connection
    transport, _ = await loop.create_connection(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 1129, in create_connection
    raise OSError('Multiple exceptions: {}'.format(
OSError: Multiple exceptions: [Errno 61] Connect call failed ('::1', 5552, 0, 0), [Errno 61] Connect call failed ('<IP_ADDRESS>', 5552)

Process finished with exit code 1

Commit: 2cdc1946139c699640ad7cf28b25a0485abc2e80 (this PR)
/Users/gsantomaggio/git/qweeze/rstream/venv/bin/python /Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py
Traceback (most recent call last):
  File "/Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py", line 36, in <module>
    asyncio.run(consume())
  File<EMAIL_ADDRESS>line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/gsantomaggio/git/qweeze/rstream/docs/examples/basic_consumers/basic_consumer_binary.py", line 31, in consume
    await consumer.start()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/consumer.py", line 128, in start
    self._default_client = await self._pool.get(
                           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 768, in get
    await self.new(
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 841, in new
    await client.start()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/client.py", line 236, in start
    await self._conn.open()
  File "/Users/gsantomaggio/git/qweeze/rstream/rstream/connection.py", line 37, in open
    self._reader, self._writer = await asyncio.wait_for(
                                 ^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 520, in wait_for
    return await fut
           ^^^^^^^^^
  File<EMAIL_ADDRESS>line 48, in open_connection
    transport, _ = await loop.create_connection(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 1129, in create_connection
    raise OSError('Multiple exceptions: {}'.format(
OSError: Multiple exceptions: [Errno 61] Connect call failed ('::1', 5552, 0, 0), [Errno 61] Connect call failed ('<IP_ADDRESS>', 5552)

Process finished with exit code 1

A I missing something?

I suppose you need to use producer instead of consumer to trigger the bug
-------- Original Message --------
On 10/30/24 2:43 PM, Gabriele Santomaggio  wrote:

@.***(https://github.com/aborigeth) thank you.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you


python311Packages.grpcio-testing: 1.54.0 -> 1.54.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.grpcio-testing is: Testing utilities for gRPC Python
meta.homepage for python311Packages.grpcio-testing is: https://grpc.io/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.54.2 with grep in /nix/store/ynfs499hpkr2nj9fj19k33p4zsz2nfrg-python3.11-grpcio-testing-1.54.2
found 1.54.2 in filename of file in /nix/store/ynfs499hpkr2nj9fj19k33p4zsz2nfrg-python3.11-grpcio-testing-1.54.2

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
chatgpt-retrieval-plugin
python310Packages.grpcio-testing
python310Packages.pymilvus
python311Packages.grpcio-testing
python311Packages.pymilvus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ynfs499hpkr2nj9fj19k33p4zsz2nfrg-python3.11-grpcio-testing-1.54.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.grpcio-testing https://github.com/r-ryantm/nixpkgs/archive/deeaabc00f67672f8b11f9dec62e538a38a4a190.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ynfs499hpkr2nj9fj19k33p4zsz2nfrg-python3.11-grpcio-testing-1.54.2
ls -la /nix/store/ynfs499hpkr2nj9fj19k33p4zsz2nfrg-python3.11-grpcio-testing-1.54.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

chatgpt-retrieval-plugin

4 packages built:

python310Packages.grpcio-testing
python310Packages.pymilvus
python311Packages.grpcio-testing
python311Packages.pymilvus

Maintainer pings
cc @fabaff for testing.

Fix for chatgpt-retrieval-plugin failure (#231802).

Result of nixpkgs-review pr 231771 run on x86_64-linux 1

10 packages built:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
python310Packages.grpcio-testing
python310Packages.grpcio-testing.dist
python310Packages.pymilvus
python310Packages.pymilvus.dist
python311Packages.grpcio-testing
python311Packages.grpcio-testing.dist
python311Packages.pymilvus
python311Packages.pymilvus.dist