Copybook.parseSimple not dropping the fillers in output ast

String copybookContents = "01  RECORD.
05  FILLER           PIC X(1).
05  COMPANY_PREFIX   PIC X(3).
05  FILLER           PIC X(1).
05  FILLER           PIC X(1).
05  COMPANY_NAME     PIC X(9)."
Group grp = CopybookParser.parseSimple(copybookContents, true,true,commentPolicy.apply(false,6,72)).ast();
in the above scenario as drop_value_fillers is true then the output ast also should not contain the FILLERS. But output ast is providing each column details.

Thanks for the bug report. Dropping of fillers is a feature of 'spark-cobol'. Fillers should be deopped in Spark schema while still can be present in the AST.
But your expectation makes sense. We can drop fillers from AST as well.

Hi, I was revisiting this issue.
Each AST element has isFiller flag, so you can always ignore all fields if the flag is true.
Is it necessary for your use case to actually remove fillers from the AST if you have this flag?

That's how we are handling in our code while parsing the ast. It's a good to have feature to drive via parsesimple

Could you please elaborate on what are you trying to achieve?
Every use case that I can think of can be done by just ignoring fields (AST statements) for which isFiller == true.

We are currently parsing the copybook using ast and converting to json. We are using parsesimple to get the ast. if based on the user options if we can drop or retain the filler in ast then for us its not required to handle while converting back to json.

Sure, but using node.isFiller can be used to achieve the same, isn't it?
https://github.com/AbsaOSS/cobrix/blob/3014923981a2f466343cb9b464ec8244b0b0ad8c/cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/ast/Statement.scala#L81
What's the code snippet that you are using?

I see why you are asking for the feature. There are parameters that say 'dropGroupFiller' and 'dropValueFillers' but nothing actually dropped, just marked. It makes sense. We can implement the dropping as well

You are correct. Currently we are parsing and dropping the fillers by utilizing the isFiller. but the parameter we are sending for dropping should have actual effect on it.

This is implemented.
Please, check the latest master. Note that the signature of the method (parseSimple) has changed. It now reflects what is actually being done.
Spark schemas doe not support having 2 column names having tha same name so FILLERs need to be renamed in order to be retained. So the method allow controlling if fillers are going to be renamed, and a separate flag that controls if non-renamed fields should be dropped.

If signature is changed then it will break our existing code if we update the version. Can we have it overloaded

Okay, fair point. Will make it compatible

@yruslan thanks a lot. We will mark the existing parsesimple signature to @Deprecated

The changes are in master - you can check. To retain the compatibility the behavior is the same by default.
Use 'dropFillersFromAst = true' to actually drop fillers from the AST.

So as in parseSimple is still have a new parameter dropFillersFromAst in the signature so once we upgrade we have to provide the value in our calling code. In scala it won't ask as the default value is given for it as false but in Java we have to explicitly specify to false while calling.

Yeah, but this is the only way to preserve backward compatible behavior. Since the method has default values it cannot be overloaded.

2.4.8 is released and it has the fix.
Btw, Cobrix has converters project that currently just provides examples on how to convert mainframe files to JSON without Spark. Consider contributing your converter to the project :)

Sure I would be happy to contribute their. I saw that module recently.
Can I know the overall requirement and detail plan for it. Is there any high level design document or still it is in process. I can contribute their also. Any plans to have the code base in Java or it will be completely in scala :)

We don't have an exact plan at the moment. Just ideas. The one that we might likely to implement is a command-line tool + library that allows converting mainframe files to JSON.
Yes, the project will continue to be in Scala.

Sure then I think of 2 requirements

Converting copybook ast to corresponding json
Converting copybook to a map with key as parent hierarchy and value as column name.


Cannot load file in assets folder

See the full repo here: Full Repo
Flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.0.1 21A559 darwin-x64, locale en-ID)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.64.2)
[✓] Connected device (3 available)
[!] HTTP Host Availability
    ✗ HTTP host https://cloud.google.com/ is not reachable. Reason: Failed to connect to
      https://cloud.google.com/ in seconds

! Doctor found issues in 1 category.

Error:
FileSystemException (FileSystemException: Cannot open file, path = 'assets/r18.dxf' (OS Error: No such file or directory, errno = 2))

Pubspec.yaml
# Other contents

flutter:
  uses-material-design: true
  assets:
    - assets/

Folder structure:

See the full repo here: Full Repo

We refactored at version 3.0.0


Incorrect line number for module not found errors with Typescript

Do you want to request a feature or report a bug?
Report a bug with Webpack 2.2.1.

What is the current behavior?
If I import a css file from a TypeScript source file, and the CSS file doesn't exist, I get a module not found error but the line number is wrong.
If the current behavior is a bug, please provide the steps to reproduce.
webpack.config.js:
const path = require('path');

module.exports = {
  entry: './src/js/index.ts',

  output: {
    filename: 'app.bundle.js',
    path: path.resolve(__dirname, 'build'),
  },

  resolve: {
    extensions: ['css', '.webpack.js', '.web.js', '.ts', '.tsx', '.js'],
  },

  module: {
    rules: [
      {
        test: /\.tsx?$/,
        loader: 'awesome-typescript-loader',
      }
    ],
  },
};

index.ts
//import * as Foo from 'foobar';
import './../css/main.css';
import './../css/no-such-file.css';
import './../css/main.css';

Error message:
ERROR in ./src/js/index.ts
Module not found: Error: Can't resolve './../css/no-such-file.css' in 'C:\Users\brandon.wamboldt\Projects\client-core\src\js'
 @ ./src/js/index.ts 5:0-36

What is the expected behavior?
The error should be on line 3
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Node version: v5.10.1
Webpack version: 2.2.1
NPM version: 3.8.3
OS: Windows 7 x64

I've fixed the behavior locally by patching lib/Compilation.js#L260, to lookup the source map:
var sourceMap = new SourceMapConsumer(module._source.map());

var originalStartPosition = sourceMap.originalPositionFor({ line: dependencies[0].loc.start.line, column: dependencies[0].loc.start.column });
var originalEndPosition = sourceMap.originalPositionFor({ line: dependencies[0].loc.end.line, column: dependencies[0].loc.end.column });

dependencies[0].loc.start.line = originalStartPosition.line;
dependencies[0].loc.start.column = originalStartPosition.column;

dependencies[0].loc.end.line = originalEndPosition.line;
dependencies[0].loc.end.column = originalEndPosition.column;

And at the top of the file I added:
const SourceMapConsumer = require("source-map").SourceMapConsumer;

Hopefully someone who knows what they're doing can make a Pull Request as I didn't really understand the context, and my solution may not work for all use cases.

This could be added as feature.


more debugging whether we found a previously installed arango

maybe its not yet invoked in /s mode?
Scope & Purpose
(Please describe the changes in this PR for reviewers)

[x] :hankey: Bugfix
[x] :muscle: The behavior in this PR was manually tested
[x] :computer: The behavior change can be verified via automatic tests

Backports:

[ ] No backports required
[x] Backports required for: (all)

Related Information
https://arangodb.atlassian.net/browse/BTS-170 and more.

Upgrading via CLI works with this change.

http://jenkins01.arangodb.biz:8080/job/arangodb-ANY-windows-packages/1031/


Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/telepot/init.py", line 738, in collector
callback(item)
File "/home/pi/diceyclock.py", line 26, in handle
bot.sendPhoto(chat_id, f)
File "/usr/local/lib/python2.7/dist-packages/telepot/init.py", line 448, in sendPhoto
return self._sendfile(photo, 'photo', p)
File "/usr/local/lib/python2.7/dist-packages/telepot/init.py", line 429, in _sendfile
return self._api_request(method, _rectify(params), files)
File "/usr/local/lib/python2.7/dist-packages/telepot/init.py", line 398, in _api_request
return api.request((self._token, method, params, files), **kwargs)
File "/usr/local/lib/python2.7/dist-packages/telepot/api.py", line 131, in request
return _parse(r)
File "/usr/local/lib/python2.7/dist-packages/telepot/api.py", line 126, in _parse
raise exception.TelegramError(description, error_code, data)
TelegramError: (u'PHOTO_INVALID_DIMENSIONS', 400, {u'error_code': 400, u'ok': False, u'description': u'PHOTO_INVALID_DIMENSIONS'})

Hello,
this is not a telepot error, it's a telegram api limitation.
see also:

https://core.telegram.org/api/errors#400-bad-request
https://github.com/zhukov/webogram/issues/726

I couldn't really find max valid dimensions for images in telegram, but have you tried sending it with sendDocument method instead? that one has no limit on the image size/dimensions.
alternatively, you can resize your image if you want the thumbnail to show up.

nice, I will test it today :)


open orders and comments overlap after expanding market header

expanding this part:

overlap:

I'm not able to repro


Workaround Go and PHP interop test failures when IP is used as server_host

PHP interop failures should be fixed by #7959

Closing this as the bug will be fixed in Go: https://github.com/grpc/grpc-go/pull/879.

For some reason I couldn't remove the 2nd commit from this PR. Creating a new PR.


Find Skaffold in well-known locations

We can at least add install locations for Linux and Mac - those are the ones used for majority of installs: Mac and Linux: /usr/local/bin. Windows just says use PATH, so we need to test if it works when launched from the UI menu.
Originally posted by @ivanporty in https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/2388#issuecomment-469306627

@ivanporty were you working on this one?

not yet. My idea was to just include /usr/local/bin into PATH of the running Skaffold. I think it still could be beneficial for some cases, WDYT?

yeah. that approach could work. e.g. adding it to the path if there is no skaffold override set in the UI and the executable is not already detected in the path. sgtm.

First attempt with GeneralCommandLine environment didn't work, researching why.

So we cannot modify PATH per se for spawned process, so the solution could be checking if /usr/local/bin/skaffold exists and executable, and then use this as an absolute PATH.
Cons: we might override actual PATH location of Skaffold, if they have it in multiple locations, including /usr/local/bin, but PATH points to some other location. This could lead to unpleasant issues using Skaffold version a user doesn't want to use. @etanshaul WDYT? I'm leaning towards skipping this and rely on PATH, and then most of this is going to be alleviated by managed tools.

we might override actual PATH location of Skaffold

Shouldn't it only use the known location as an absolute path if we've already checked that its not already on the PATH?

but - regardless, I think we are OK skipping this now that 1) the system-path issues are resolved on all OSs and 2) we have the GUI to select a custom path.
We can still do it, but just remove from the milestone

Yeah, we check the Skaffold in PATH first and then do hard fail if it's not there, so adding another run using additional absolute path might be tricky. I agree on skipping this from alpha, this may introduce unpleasant side-effect.

cool. removing from this milestone

I think this is less of a priority now that we have 1) a skaffold override selecter, and 2) workarounds for the system PATH issues.
Removing from the next milestone

closing this as we will have managed dependency installation soon so this will be irrelevant.


ion-js v4.0.0 npm install missing jsbi

Hi! When I was installing ion-js v4.0.0 npm complained that it was missing the dependency jsbi. I was able to workaround the error by explicitly installing jsbi within my own project.

As of version 4.0.0, jsbi is a peer dependency, allowing/requiring users to bring their own version of the library.
This behavior is intentional, so I'm going to close this issue. Feel free to re-open if you have other questions or I've misunderstood something.


[954] Add trainee form redirect

Context
When adding a new trainee the form redirects to Trainees#show. It should redirect to review draft.
Changes proposed in this pull request
Update the path to redirect to the correct place.
Guidance to review
Add a trainee. The first submit goes to review draft.

 Creating a new trainee redirects to the wrong page after setting the route

 Creating a new trainee redirects to the wrong page after setting the route


Only load tiles on valid share URL

Currently when you load the app without a valid ID it loads leafly.js and "tiles" from the map provider (in my case a single page load uses 32 tiles from Thunderforest). As many providers, such as Thunderforest bill per "tile" it would be ideal to not load any tiles unless a map is actually being displayed.

I will look into this and see if I can resolve it. I'm currently doing a massive refactor of the entire Android code, so it may take a little while before I can get to it, but I'll definitely get it done.

Sorry for this taking a bit longer than anticipated. Fixed in latest commit :-)


maid: update dependencies to fix security vulnerability

Fixes CVE-2024-43380
Part of #351833

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ooops, it had been a while since I worked with it... updated now

@ofborg build maid


mysql replication: let me specify how bad it is not to be a slave

Choices are all the exit methods: ok, warning, critical or unknown.
Default is ok, so this is 100% backwards compatible

@webmat Have you made any progress on this yet?


[Coverity CID :205667]Error handling issues in /tests/drivers/counter/counter_basic_api/src/test_counter.c

Static code scan issues seen in File: /tests/drivers/counter/counter_basic_api/src/test_counter.c
Category: Error handling issues
Function: set_top_value_capable
Component: Tests
CID: 205667
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

*** CID 205667:  Error handling issues  (CHECKED_RETURN)
/tests/drivers/counter/counter_basic_api/src/test_counter.c: 141 in set_top_value_capable()
135
136        if (err == -ENOTSUP) {
137                        return false;
138        }
139
140        cfg.ticks++;
     CID 205667:  Error handling issues  (CHECKED_RETURN)
     Calling "counter_set_top_value" without checking return value (as is done elsewhere 6 out of 7 times).
141        counter_set_top_value(dev, &cfg);
142        return true;
143     }
144
145     static void top_handler(struct device *dev, void *user_data)
146     {


Type/Member Identification in RC2 Core Packages

Can we update something like https://packagesearch.azurewebsites.net/ with rc2 packages? If not, what would be an alternative to to identify in which package(s) a RC2 type/member exists if not using Visual Studio?

cc/ @glennc (maintains that app and said recently it might get a feeds update in Slack chat)

Yeah, I haven't updated PackageSearch to RC2 yet. But I intend to do it in the next couple of days.

Thank you. That would be much appreciated. There is no urgency and so I will close this down, and check the site myself for the RC2 packages.


Closed group programmatically, won't open again.

I use these lines of code when group is expanded and close others, and after a group is collapsed and try to open the same again, it won't open, but when I try to open another group works fine.
@Override public void onGroupExpanded(ExpandableGroup group) {
if (mLastExpandedGroup != null) {
adapter.toggleGroup(mLastExpandedGroup);
}
mLastExpandedGroup = group;
}

#25 #issuecomment-329484599

Did you find a solution?
@kukamanga
my problem, It works fine when the previously expanded group is visible on the screen. If the group is off the screen, it will not collapse when calling toggleGroup on it.


KAFKA-12449: Remove deprecated WindowStore#put

Completes KIP-474 https://cwiki.apache.org/confluence/x/kcviBg by removing deprecated WindowStore#put(k, v).
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Seem this PR is related to KIP-474 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545.
We should rather tag the KIPs that did the deprecation of methods (on KIP-667 that is unnecessary)

Totally missed that this was proposed and accepted in KIP-474. Hope is not stepping into an existing implementation.

Thanks @jeqo! Merged to trunk.


Fixed Animation bug in X3D

Use an array of floats for setting positions, rotations and scale values.
Tested with asset-tests
GearVRf DCO signed off by: Sahithi Podila<EMAIL_ADDRESS>

Picked only the change to x3d/AnimationInteractivityManager.java.


Reverse the direction of the xs_profile_plot

Historically longitudinal profile plots have displayed the upstream end of a reach on the left side of the graph (ggplot::x_coord_reverse). However, this goes against the typical graph layout with y-axis and x-axis origin in the lower left. More recent longitudinal Level 1 longitudinal profile graphs in fluvgeo (i.e., compare_long_profile, compare_xs_long_profile) have been built using this more common approach.
If we decide to make this change it will effect several other graphs (Regional Hydraulic Geometry Curves, and Cross Section Metric graphs). Do all of these changes need to be made at the same time?

Here is one of the new Level 1 report longitudinal profile graphs.

@chrisharing replied on slack:
"Definitely prefer origin in lower left....I don't think the changes need to be completed at same time.  I think this is a display function we should have in order when we release FG."
I'll get started making the changes to graphs as I update each report.

4d00c3a5b62159270d5e5056c113e5e53a232e82


HWKAPM-797 : Redraw charts on sidebar toggle

@ammendonca LGTM :+1:
Although when I reduced the screen size to smaller (i.e. mobile) on the Transactions page, the sidebar seemed to disappear. If you see the same issue, then might be worth creating a separate jira. Not urgent but would be good if UI could be used from mobile devices as well.

OK, something to check as I don't think the UI has been made mobile-ready, but we can surely improve some of it to make it usable.

No problem - I'll create an umbrella jira to investigate.


renderTemplateAsset fail

Since this function taking req, asset params is called with asset as parameter only.
Function definition : https://github.com/punkave/apostrophe/blob/4b9039cdf38ef0a7ffed9b30e9d4991d61bf22c5/lib/modules/apostrophe-assets/index.js#L1173
Function call: https://github.com/punkave/apostrophe/blob/4b9039cdf38ef0a7ffed9b30e9d4991d61bf22c5/lib/modules/apostrophe-assets/index.js#L1463
It may be require a test case.
I found this bug trying to make this:
// lib/modules/apostrophe-assets/index.js
  afterConstruct: (self) => {
    self.pushAsset('template', (req, data) => {}, {
      when: 'always',
      data: self.apos.templates.safe('
Hello
')
    })
  }

Describe here : http://apostrophecms.org/docs/modules/apostrophe-assets/index.html#push
EDIT: If I remove the req from function def (seems unused),  I get this Error :
Error: render() must not be called from a Nunjucks helper function nested inside another call to render(). Use partial() instead.

Hi Arthur,
We haven't used the template push mechanism once in 2.x! We moved away from it because it cluttered up the DOM with a lot of templates that might not get used on a given page request. Instead we have consistently made AJAX requests (usually with the .html method of apostrophe-context, which apostrophe-modal inherits from...) any time we wanted the server to render something that isn't part of the initial page.
(We did use this mechanism  a lot in 0.5.)
Since it apparently has been broken all along in 2.x, removing it would not be a bc break, so we might just do that. However I will take a closer look when I get a moment.

No problems, I just found this during weird tests but it isn’t blocking my devs ;)


Save Files to One Drive via Modal

I am currently working on a requirement that requires me to implement two things:

Users should be able to pick files from their One Drive
Users should be able to Save files to their One Drive.

I am able to achieve #1 of requirements with the help of Onedrive File Picker v8 control & I also referred to the samples project.
But for #2 requirement, where users could save files to their OneDrive, I am unable to find a sample reference code. Shall I be using the same File Picker v8 control even for Saving files to One Drive. But then, how can we get rid of the Select & Cancel button and just have the Save button. Is there any separate control that I should be using for Saving Files to One Drive via pop up modal Or is there any one property in file options that I can set.
What i need is a File Upload Modal with Save/Select button ( like how we get in Google Drive when we upload the docs)
I got a reference to this document but it is using old control:
https://learn.microsoft.com/en-us/onedrive/developer/controls/file-pickers/js-v72/save-file?source=recommendations&view=odsp-graph-online
Is there any similar document to the new Save File control as well.

If you have Files.ReadWrite.All you can upload files through the picker interface, there is a widget that appears in the top of the control. This is something we can add to the docs.

"What i need is a File Upload Modal with Save/Select button" - this would be a different thing, so you're really asking for a new control? You can also upload files directly as an option for building your own modal.

Thanks for the reply Patrick.
I have taken a reference from dropbox. I am looking for something similar
to dropbox, the way it offers Saving Files to Dropbox via pop up.
The file I have selected to upload is being shown at the bottom part and
there is a Save button. Once I click on Save, the file gets saved to the
selected folder.
This behaviour is also similar to what Google Drive offers when you try to
Save any file from your smartphone to Drive via the Save to Google Drive
option.
Wondering if we could achieve similar functionality from our custom web
app, when it comes to Saving Files to OneDrive
[image: image.png]
Could you please help me out by suggesting how can we achieve this type of
behaviour when it comes to Save Files to One Drive.
Thanks and Regards,
ANKIT BAJPAI
M: +917680069007
👉 Ankit's LinkedIn Profile https://www.linkedin.com/in/ankitbajpai19/
👉 Ankit's GitHub Profile https://github.com/ankitbajpaii
On Fri, Dec 16, 2022 at 8:04 PM Patrick Rodgers @.***>
wrote:

If you have Files.ReadWrite.All you can upload files through the picker
interface, there is a widget that appears in the top of the control. This
is something we can add to the docs.
[image: image]
https://user-images.githubusercontent.com/13154702/208120511-37128e6f-22d2-4c8b-b5aa-efce44d62f23.png
"What i need is a File Upload Modal with Save/Select button" - this would
be a different thing, so you're really asking for a new control? You can
also upload files directly
https://learn.microsoft.com/en-us/graph/api/driveitem-put-content?view=graph-rest-1.0&tabs=http
as an option for building your own modal.
—
Reply to this email directly, view it on GitHub
https://github.com/OneDrive/samples/issues/23#issuecomment-1354947360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFJ4GV5HRZZJGBRWUD432DWNR4YDANCNFSM6AAAAAATARYWOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi @patrick-rodgers & Team,
Any update on this issue please.

Hi @patrick-rodgers
I am looking for this functionality in version 8 control:
https://learn.microsoft.com/en-us/onedrive/developer/controls/file-pickers/js-v72/save-file?view=odsp-graph-online

Hi @AnkitBajpaii, following up in this, I've added a sample configuration showing how to setup the picker to choose only folders, provide a "save-as" prompt for file name, and change the label of the "select" button. This should come pretty close to meeting your requirements.
{
    "sdk": "8.0",
    "entry": {
        "oneDrive": {
            "files": {}
        }
    },
    "authentication": {},
    "messaging": {
        "origin": "http://localhost:3000",
        "channelId": "27"
    },
    "typesAndSources": {
        "mode": "folders",
        "pivots": {
            "oneDrive": true,
            "recent": true
        },
        "filters": ["folder"]
    },
    "tray": {
        "prompt": "save-as",
        "saveAs": {
            "fileName": "test.txt"
        }
    },
    "commands": {
        "pick": {
            "label": "Save As"
        }
    }
}

In the entry in the Items collection you get back when the "Save As" action is invoked you'll see a new property in the entry providing you the name they entered in the save as textbox.
"saveAs": {
    "name": "test.txt"
}

Closing this issue as answered. If you have additional questions or we did not answer your question, please open a new issue, ref this issue, and provide any additional details available. Thank you!


Clicking reply numbers should show list of repliers

This one might need discussion, we can figure it out also in a different way.

Maybe clicking at the root message to which replies belong to should show a modal with this message and all replies.

@ghostbuster91
Yes, as seen in:
https://invis.io/Y4MYB66HSPG#/309552205_CommentExpanded


Weird spacing going on when deleting a component with a URL already created

[kind/bug]

What versions of software are you using?
Latest master
How did you run odo exactly?
./odo delete after using odo url create
Actual behavior
▶ ./odo delete
This component has following urls that will be deleted with component
     URL named  foobar  with host  foobar-odo-tjgc-foobar.e8ca.engint.openshiftapps.com  having protocol  http  at port  8080
? Are you sure you want to delete nodejs-rlcx from odo-tjgc? Yes
 ✓  Deleting component nodejs-rlcx
 ✓  Component nodejs-rlcx from application odo-tjgc has been deleted

Expected behavior
No weird spacing / output for the URL...
Any logs, error output, etc?
See above

there is spacing in odo app delete
This application has following components that will be deleted
 component named  nodejs-jyaq
? Are you sure you want to delete the application: goprojects-vefa from project: tt (y/N)

and odo project delete too
This project contains the following applications, which will be deleted
 Application  goprojects-vefa
  This application has following components that will be deleted
  component named  nodejs-jyaq
? Are you sure you want to delete project tt (y/N)

want me to remove those too?

@girishramnani Yes please!


adattatore wifi alfa awus036nha

ciao. non riesco a collegare il mio adattatore wifi alla macchina virtuale di utm. Su utm ho installato kali linux. L'adattatore che sto usando è alfa atheros AWUS036NHA
Google translated:

Hello. i can't connect my wifi adapter to utm virtual machine. On utm I have installed kali linux. The adapter I am using is alfa atheros AWUS036NHA

Please provide the necessary information to we can support you. When you clicked on New Issue there was a bunch of text in the template for you to fill out:
Describe the issue
A clear and concise description of what the issue is. BEFORE SUBMITTING YOUR ISSUE, PLEASE LOOK AT THE PINNED ISSUES AND USE THE SEARCH FUNCTION TO MAKE SURE IT IS NOT ALREADY REPORTED. ALWAYS COMMENT ON AN EXISTING ISSUE INSTEAD OF MAKING A NEW ONE.
Configuration

UTM Version:
OS Version:
Intel or Apple Silicon?

Crash log
If the app crashed, you need a crash log. To get your crash log, open Console.app, go to Crash Reports, and find the latest entry for either QEMU, QEMUHelper, or qemu-*. Right click and choose Reveal in Finder. Attach the report here.
Debug log
For all issues, including crashes, you should attach a debug log. Open UTM, and open the settings for the VM you wish to launch. Near the top of the QEMU page is Debug Log. Turn it on and save the VM. After you experience the issue, open the VM settings again and select Export Log... and attach it here.
Upload VM
(Optional) If possible, upload the config.plist inside the .utm. If you do not have this, you can upload the entire .utm but note this contains your personal data. Since Github has an attachment size limit, you may want to upload to another service such as Google Drive. Link it here.
Please provide the information and reopen this issue. Thanks.


node-debug

A wrapper around node-debug would be highly appreciated! :-)

This about node-inspector, not node-debug


UP down or a number

When you set say a lamp up - and say "up" or "down" - or feed in a percentage - all of that is great - but what if you only wanted to go up one point/degree/percent?  is there a way to differentiate between the up/down command and putting a value in - right now all that seems to go out is the value.

Unfortunately, there is not. This is all controlled by the Echo and amazon alexa. The ha-bridge only receives the command from the echo or home's interpretation.

Thanks for the feedback - saves me wasting time looking for answers that are not there :-)


If so, private registries will be supported on docker run in swarm 1.1
Right now you can use pull so pull the image on every node and then do the run
docker -H tcp://XX.XX.X.XX:9000 pull docker.io.XX.net/nginx:latest
docker -H tcp://XX.XX.X.XX:9000 run -m 512M docker.io.XX.net/nginx:latest

Hello,
I have the same issue since moving to swarm:1.0.0, it was working before.
We have a local registry, it doesn't find the image if none of the node had pull it.
If I'm trying with the swarm manager to pull, it's pulling on all the nodes.
Can I pull in only one node ? Do you know when the 1.1 will be release ?

Hi @disastrous-charly, do you have that same bug when trying with swarm:1.0.1 or master?

Hello,
Just tried with 1.0.1 version, still have the issue when trying to run a image from private repo.
The error : Error response from daemon: Error: image charly/super_app:1.0 not found
I will wait for 1.1 ;-)

@disastrous-charly can you please test with Swarm 1.1.0 RC2?
docker pull swarm:1.1.0-rc2

Hello,
Still have the same error :(
FYI, I upgraded my swarm master to docker 1.9.1. worker are in 1.9.0. Registry in 2.2.
Anything I could try ?

@disastrous-charly we are still lacking doc for this, but if you follow:
# Calculate the header
REPO_USER=yourusername
read -s PASSWORD
HEADER=$(echo "{\"username\":\"${REPO_USER}\",\"password\":\"${PASSWORD}\"}"|base64 -w 0 )
unset PASSWORD
echo HEADER=$HEADER

# Then add the following to your ~/.docker/config.json
"HttpHeaders": {
    "X-Registry-Auth": "<HEADER string from above>"
}

it should work.

@disastrous-charly also here: https://github.com/docker/swarm/blob/master/docs/swarm-api.md#registry-authentication

Hello all !
@vieux  Victoire ! It's working ! Thanks !
FYI :
I upgraded my swarm master host, my 2 nodes, my private registry host to  docker 1.10
swarm master + nodes with swarm 1.1.0
The error when trying to pull without the header is now :
docker: Error response from daemon: Get https://cargo.irisa.fr:5000/v2/allgo/bigstat/manifests/1.0: no basic auth credentials
With the header, everything is working great.

@kendiyqx @disastrous-charly can we close this issue now?

it's ok for me !

is it possible to run this solution with NGINX in front of private registry ?

where add "HttpHeaders" section in ~/.docker/config.json ? after auth section or before auth section? or maybe inside auth section? Can anybody give an example of such config.json file?

I found answers :-)

yes, X-Registry-Auth header works also with nginx on front of private repo
"HttpHeaders" section just after "auths":{}, only on swarm master

Is there any way to add 2 private repos ? That could mean 2 section with "X-Registry-Auth"
I checked almost all variants of configuration and works only for last line of X-Registry-Auth , first lines are ignored


Upgrade to current Tokio

This crate still uses tokio-core which is not in use anymore for current tokio applications.
Upgrading this to the current tokio crate library would allow it to work with other current tokio applications.
I've had to use another crate because of this, as I can't china this with other tokio systems currently.

Hello.
I understand the problem. However, for „proper“ tokio migration, it should modified so all the futures in there are actually Send (this isn't the case, but mostly because there are Rcs that should be changed into Arcs and unsync mpsc instead of sync ones).
Anyway, this is some amount of work and I don't really have much motivation to work on this particular crate right now, so I don't know when I'd get to it. I'll happily accept pull requests, though.

Ok thanks for the information. For people having the same problem:
I'm currently using hyper + jsonrpc_light, this way you can accept requests via hyper, deserialize them to jsonrpc_lite structs and also answer with those, giving a thin but already really helping layer between doing manual json and actually having magical glue from fn's to json. I don't know if it lacks anything specific but is working very good so far.


The name of the repo is too long

I was not very inspired when I first created the repo. I suggest we should rename. Looking for propositions.

Let's try not to refer to twitch at all. Is "Gaming Streams" too generic?

@mkral Waiting on you to go with "StreamCenter"


Added LICENSE to project.

Resolves:

Issue #123

If a project does not have a LICENSE file, it implies that the author has not granted any rights to others, and legally, no one has permission to use, distribute, or modify the code.
So, adding a LICENSE file is a best practice for open-source projects. I have added the LICENSE to your project and attached a reference image below to help you review the PR.

Please review the PR and assign it to me.
Add necessary labels to the PR:

gssoc-ext
level1
hacktoberfest-accepted


[ci] Enable LTO in release builds

LTO was disabled by default in #4829. This PR overrides the LTO settings in CI for the release profile. This will keep local developers building quickly without LTO while still testing real release conditions in CI.
Fixes #4987

One note - we were using thin lto(lto=thin, instead of true) previously, this seemed like a good choice between TPS and compile speed, although I don't have exact numbers

One note - we were using thin lto(lto=thin, instead of true) previously, this seemed like a good choice between TPS and compile speed, although I don't have exact numbers

thin was chosen mainly to enable fast development cycles, but for CI it doesn't matter , and fat LTO gives more performance back.

the error looks like an OOM issue.

To the best of my knowledge, this PR does not affect performance of prod at all, this is just about setting up LTO in unit tests
It is also not true that 'performance does not matter for CI', because CI blocks diffs landing. We do consider land time to be important, for example in cluster test land blocking, I don't understand why do we have different view here

In the interest of streamlining CI, I moved the flag to build-common.sh which will enable LTO for all release binaries, and removed all our CI workflow that builds unused release stuff. LBT will still catch build failures under --release with LTO on.

@bors-libra r=rexhoffman

:pushpin: Commit eacd11b has been approved by rexhoffman

:hourglass: Testing commit eacd11b2ea4345393702e75c71750fde76f753e3 with merge 29aafa83d5bb5c17525f2fb233af5ef19e282896...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: rexhoffman
Pushing 29aafa83d5bb5c17525f2fb233af5ef19e282896 to master...

20% to TPS it seems. Yay :)
cc @andll


MPNT-58: update README file

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/48/ : SUCCESS in 14s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/69/ : SUCCESS in 7s

Build in pipeline gate aborted.

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/49/ : SUCCESS in 7s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/70/ : SUCCESS in 9s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/50/ : SUCCESS in 9s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/71/ : SUCCESS in 10s

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-public-demos-gate-PR22
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/51/ : SUCCESS in 7s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-merge-compliance-check/22/ : SUCCESS in 19s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-sonarqube-scan-zuul-gate/20/ : SUCCESS in 36s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-fossa-scanning-zuul-el7/20/ : SUCCESS in 51s (non-voting)


Moves out node pool manager behind an extension using runner pool abstraction (Part 2)

Oh, one other question: do we need new extension point(s)? I’m not really familiar with the mechanics of extensions, but I didn’t see anything along those lines.


Add css class selector

PR to add css class selectbox
scope.cssClasses is an array like ['myClass1', 'myClass2']

Can we change it so that we pass in an array of objects that have a title and css class so that we dont have to have the developers expose their css classes and users will see a human readable selection?
Ex.
scope.cssClasses = [ { title: 'Error Color', cssClass: 'error-class-name' } ...];
Now the drop down list shows Error Color but applies the class of error-class-name.

I'm ok with aller jour suggestions ;)


Suggestion for system tests

Right now system tests are performed in a ad-hoc fashion with a simple bash script.
A common approach to add more organization / test capabilities is to use a bash test framework like bats.
Another approach would be also using pytest with the help of some plugins such as pytest-virtualenv and pytest-shutil. I personally have never used these plugins,  but if they work, keeping everything in python would be nice.

Sounds like a good idea, would tox not help regarding the virtualenv problem?

tox would definitely help. But from what I read from the documentation the pytest-virtualenv package is even more useful since it enables calling executables from a python function as if they were installed with pip.

Ah, I didn't know that, so far I have only used tox but of course we should opt for the most suitable but also reliable option.

Solved in #185


feat(empty-state): ListView empty state and unit tests

Created empty state component to support list view when no items exist. Also added unit tests for both components.

[test]


Variables lives entire lifetime of the program.

Once a variable is declared, it lives entire lifetime of the program. It can cause problem when using recursion. And it can also cause some serious memory issues for bigger programs.

Added proper scoping and drop mechanism for variables  (in this commit).


Last Week in Pony - April 11, 2021

Audio from the April 06, 2021 Pony development sync call is available.

Version 1.1.5 of ponylang/net_ssl has been released.
See the release notes for more details.

Version 1.1.3 of ponylang/crypto has been released.
See the release notes for more details.

Version 0.3.0 of ponylang/http_server has been released.
See the release notes for more details.

Version 0.3.1 of ponylang/http has been released.
See the release notes for more details.

Version 0.4.0 of ponylang/http has been released.
See the release notes for more details.


Play Services dependency in app module causes "module-flavor1-androidTest-only" grade sync fail

Issue:
After adding Play Services to app module, gradle sync fails with message:

(...)/AndroidTestingBlueprint/module-flavor1-androidTest-only/build/intermediates/manifests/full/debug/AndroidManifest.xml
Error:(40, 28) No resource found that matches the given name (at 'value' with value '@integer/google_play_services_version').

Use case:
main app module uses Google Play Services dependency:

Compile dependency in build.grade (app module)
meta-data in AndroidManifest.xml with play services version (app module)

After adding dependency, grade sync fails.
You can find separated changes committed here: https://github.com/jskierbi/android-testing-templates/commit/6bbd1ac1e1acd51efd670263438ee94dc14787f0
Is it possible to fix this?

Duplicate: https://github.com/googlesamples/android-testing-templates/issues/6


Fix requirements

update requirement file with new haystack version

Has there been any progress on this? I rebased my local branches on master and I can't run piaf-ml anymore. How do you run piaf-ml at the moment?

I can make it run with farm-haystack==0.8.0.
@AbdenourCh as @Rob192  said, the class names changed from EvalRetriever to  EvalDocuments and EvalReader to EvalAnswers. You have to still check that nothing inside breaks your implementations, though.

Strange, somehow, the change requested by Abdenour in #81 in requirements.txt was not taken into account in master. @guillaumecherel @psorianom you should use : -e git+https://github.com/deepset-ai/haystack.git@41a1c8329d75a62a012cff170da4093995a9f388#egg=farm_haystack, it works fine.

With haystack 0.9.0, the retriever+reader pipeline tests fail because the pipeline produces answers with a space character prepended like ' en Tanzanie' when the expected answer is 'en Tanzanie'.
There is a discussion here about a change in whitespace handling, but I'm not sure it's related because it concerns the preprocessor and I don't think we're using one in the relevant tests.

Resolving this PR requires further investigation. I'm ready to merge the 3 other pending PR though. Should I do that now and leave this one for later? @guillim @Rob192 @psorianom

I merged the other PR after discussing it with @guillim.

The changes made are:

Keep the naming and style of the original evaluation functions.
Add +1 to the start position of predicted answers to get rid of the extra white space
The new version manages to get one extra correct answer on the test-set(tiny.json) 'verified manually' so I changed the test values

Thanks for this @AbdenourCh !
 Could you rebase your branch to get rid of them?
I think you should also discard the changes to  src/evaluation/retriever_reader/retriever_reader_eval_squad.py: they are mostly whitespace, and we need to keep the original line 474
   elasticsearch_port = int(os.getenv("ELASTICSEARCH_PORT")) or 9200)
what's the rationale behind adding 1 to the predicted span offset start? Are you sure the new haystack version always adds a extra space at the start?

Thanks @guillaumecherel
It seems even after rebase I am not able to go back to the original src/evaluation/retriever_reader/retriever_reader_eval_squad.py file and the addition of DS_Store files.

As for the whitespace, In both tests and retriever_reader_eval_squad all the answers come with an extra space at the beginning

@AbdenourCh What are the steps you took to rebase? I would do something like:

rebase against master interactively: git rebase -i master in order to change some commits
mark each commit that I want to change, that is replace "pick" with "edit" in the corresponding line in the file that shows up after running the previous command
git will rerun each commit and stop just after those you marked with "edit". You can then make the changes you want (like removing the files), then git add and change the current commit with git commit --amend. Then you can proceed with the next commit with git rebase --continue
when rebasing is done, you'll have to force push your new edited branch with git push origin +fix_requirements

If this sounds confusing I can help, let me know.

As discussed in #137, I'm adding the component StripLeadingSpace to eliminate the leading space in answers that appears since transformers 4.3.
@guillim I'm not sure how to add it in the dila_2 pipeline. Can you help me with that?

Yep, let's do a call for this ! @guillaumecherel
just note DILA_2 doesn't exist any longer, it replaces the old DILA, see https://github.com/etalab-ia/piaf-ml/pull/146#issuecomment-887337073

Waiting for @guillim to check the clients pipeline.yaml files.

Waiting for @guillim to check the clients pipeline.yaml files.

I checked with CRPA and it works fine.

Hi @guillaumecherel!
Is this code version updated with the current master ?

Yes, it is

@psorianom Actually, now it is.

LGTM!


[Question] Confused about training actor for continuous actions

I am somewhat confused about how the gradients of the actor are obtained in the loss for continuous actions. Without a log probability term multiplying the advantage, where do the gradients come from? Thanks for the great work!

Gradients go through the logprob term and are scaled by the advantage, this is just normal PG.


Change column "Author changed" in dashboard

Use N/A instead of No when there is no submission by author. Use N/A instead of null also for the "Submitted/confirmed by author" column

Tested this paper 00061894 and looks good. Leaving open to give @vanaukenk a chance to test

I also checked the above, 00061894, as well as 00061898 (not submitted by the author) and the changes looks fine.


debug - sort order of threads isn't stable

#5644

debug a C# program that uses two tasks
have a breakpoint in one task action
when hit step
⚡ the order of the containing thread in the call stack view isn't stable

might be my bad cos I missed a build in dot net cli

ok, let me know if you can repro. Also the thread order is coming from the adapter - so if you did not misbuilt then it is an issue in the c# debug adapter I believe

There is nothing we can do here, as the threads are coming from the debug extension.
@jrieken let me know if you can repro and I will file a bug against the debug adapter extension


[Business Approvals Kit - BUG] Approvals Kit Upgrade - Need to update connector with OAuth Secret

Describe the issue
When upgrading between releases of the Approvals Kit when a solution is upgraded the OAuth secret of the Approval Kit custom connector needs to be provided otherwise a 401 unathorized error will be returned when trying to use the connector
Expected Behavior
During solution import the OAuth settings of a custom connector are not affected by an upgrade. The connector should continue to use the existing secret value.
If a new OAuth secret value is provided during upgrade then this new value should be applied.
What solution version are you using?
1.0.20231213.2
What app or flow are you having the issue with?
Custom Connector
Steps To Reproduce

Upgrade the solution
Open the Approval Kit custom connector
Select the Test tab
Ensure that have a connection
Select the GetPublishedWorkflows operation
Select the Test Operation
An error result of 401 is returned

Anything else?
One alternative would be to use environments variables of type secret so that during update the value will be fetched from Azure Key Vault. However we cannot assume that all installations of the Approvals Kit have Azure Key Vault available. As a result we need a solution that ensures the previous secret provided remains in place.
AB#1773

have the same issue


Mesh Write in Binary mode fails in Linux with post2 python wheels

Writing mesh in binary mode fails when using 5.3rc4.post2 wheels.

Description
Getting segmentation faults with messages such as:

free(): corrupted unsorted chunks
corrupted size vs. prev_size

Steps to Reproduce
Install itk 5.3rc4.post2 using pip.

Expected behavior

Actual behavior

Reproducibility

Versions

Environment

Additional Information

Is there data/script to reproduce this issue?

The following test when used with binary flag fails.
https://github.com/InsightSoftwareConsortium/ITK/blob/0fcfaf1288928a76c3ef2b3fcc8b6e53246bfbba/Modules/IO/MeshVTK/test/CMakeLists.txt#L35
itk_add_test(NAME itkPolyLineReadWriteTest02
      COMMAND ITKIOMeshVTKTestDriver itkPolylineReadWriteTest
      DATA{Baseline/hollow.vtk}
      ${ITK_TEST_OUTPUT_DIR}/hollow.vtk
)

Fix for this issue is ready in https://github.com/InsightSoftwareConsortium/ITK/pull/3526.
I am looking at other commented tests that were failing before. https://github.com/InsightSoftwareConsortium/ITK/pull/3526 fix did not solve all of them.


Liquibase integration

Use case
Can this be integrated to use with Liquibase? We're using Liquibase to manage our migrations and I was wondering if the code generation section of Komapper can be integrated to work with Liquibase. Or if the code generation can output raw SQL that we can then import into Liquibase.
Describe the solution you'd like
Easy clean integration with Liquibase.

I am not familiar with Liquibase, but I believe it can be used with Komapper.
Manage your database schema with Liquibase and generate Kotlin code from the database using the Gradle plugin provided by Komapper.
Let me know if you have any problems using them together.


 Sorry I didn't catch this. It was giving a
bad warning on my terminal but nothing seemed funky. I'll update this soon.
David Angeles,
Ph.D. Candidate in Biochemistry and Molecular Biophysics,
Caltech
On 8 March 2016 at 18:31, Raymond Lee<EMAIL_ADDRESS>wrote:

i don't know how to generate proper pull request. if you can just pull the
last commit 7dc5a82
https://github.com/dangeles/TissueEnrichmentAnalysis/commit/7dc5a82e6085e481be84903411facddf39279fca
.
—
Reply to this email directly or view it on GitHub
https://github.com/dangeles/TissueEnrichmentAnalysis/pull/1#issuecomment-194077154
.

Done


risvc64 jobs need more than 50 minutes to finish

I have deployed this yesterday and everything thing seems to be going alright.


Add Astar zkEVM mainnet

Add Astar zkEVM mainnet
homepage : https://astar.network/
docs: https://docs.astar.network/docs/use/zkevm-guides/
block explorer : https://astar-zkevm.explorer.startale.com/
RPC endpoint: https://rpc.startale.com/astar-zkevm
slip0044 index : 60 (ETH is native currency)
chain ID : 3776
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Included in https://github.com/LedgerHQ/app-ethereum/pull/598


docs-markdown and docs-preview production deployment

Updated changelog and package.json

Codecov Report

Merging #667 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #667   +/-   ##
=======================================
  Coverage   19.50%   19.50%
=======================================
  Files          14       14
  Lines         933      933
  Branches      158      158
=======================================
  Hits          182      182
  Misses        740      740
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd61318...e9be6c9. Read the comment docs.


Wget::Fetch[my_item]: has no parameter named 'http_proxy' on ubuntu

Using the examples provided.

Have confirmed that wget works directly from command prompt with same url

Have tried adding  http_proxy  => 'undef'  to my wget:fetch

module version: 1.7.1

ubuntu 14.04

bash shell

I would be pleased to set any appropriate variables or environment variables if that is what needs to happen. If so, could this please be reflected in the README ?

See https://github.com/maestrodev/puppet-wget/pull/66

Sorry for opening a duplicate.
I've tried adding  to site.pp as per the new instructions and have also tried the following...
(with and without the hiera lookups).
$http_proxy = undef
$https_proxy = undef
$schedule = undef
Would you prefer to close this issue and just switch to the #66 instead of keeping two open? I can keep an eye there to see what happens next.
Thanks.

I figured out a way to get this going (instructions split 1/2 and 1/2).
In site.pp
`
$http_proxy = hiera('http_proxy', undef)
$https_proxy = hiera('https_proxy', undef)
`
In my own module (class)
`
include wget
Wget::Fetch { schedule => undef }
`
Just thought you might like to know.  Thanks for the help !

I'm not a project admin; just an interested user.  Try $http_proxy = "" instead of $http_proxy = undef? I meant to continue troubleshooting a least-invasive fix and submit a README patch, but I'm too far behind in my paid work at the moment.

See also #68


Compute instance support for Rackspace

This is a Feature Proposal
Description
Using nodecloud, a user should be able to create and deploy compute instances in the Rackspace cloud.

@rehrumesh should we first support only general purpose or all the types offered by Rackspace ?

We should at try to match equivalent services we have implemented for AWS and GCP. i.e: Compute, Network, Storage etc.


Golang version of tradingview-ta

Anyone interested in the golang version of tradingview-ta? Tell me below and I'll consider creating it.

Hey there, I just came across this library and as a Golang developer, I'd love to use a similar library.
I can help you develop it, just start a new repository and put some boilerplate down 😄

Hi @bt,
I just created the repo deathlyface/gotvta. It's still a WIP.
Currently, it can retrieve data from TradingView. It can also compute indicators into readable buy/sell. Maybe I need some help getting values from a JSON. I'm new to golang.


Modal style broken?

Hello,
I'm currently having a problem related to UI. You can see in the image below that it is broken. The component is totally empty (code is also below). Although I was able to fix it with a few CSS. I'm asking myself if I'm missing something or it is really broken.
The package is working well, I've tried to connect to metamask, and fortmatic, all cool, except the UI.
import Web3Connect from "web3connect";
import Web3 from "web3";
import React, { Component } from 'react';

class App extends Component {
    render() {
        return (
            <div>
                <Web3Connect.Button
                    providerOptions={{
                        fortmatic: {
                            key: "my_key" // required
                        }
                    }}
                    onConnect={(provider) => {
                        const web3 = new Web3(provider); // add provider to web3
                        console.log('web3', web3);
                    }}
                    onClose={() => {
                        console.log("Web3Connect Modal Closed"); // modal has closed
                    }}
                />
            </div>
        );
    }
}

export default App;

Which browser are you using? Just used your code on the example file and tested in brave.

Initially Vivaldi (chromium based), but after looking at your message, I've tried chrome, firefox and brave.
I don't have any style file ... :thinking:

Yeah I’m seeding the exact same thing:
Reproduce by making a simple Create React App and pasting in the React Button:

Fixed on<EMAIL_ADDRESS>


Adding support for LoadBalancerSourceRanges

Description
This PR adds in support for LoadBalancerSourceRanges as part of the NginxIngressController CRD. I was looking through potential issues to take a shot at implementing and the idea of LoadBalancerSourceRanges seemed well-scoped enough to take on and added some practical functionality that I've depended on in the past.
If there's anything I've overlooked while working through this feature implementation, let me know and I'll work to get it resolved.
Feature #263
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Test cases added to unit tests covering extra attributes on the CRD object. I've also built out a dev environment following the local testing guide and functionally tested the deployment in that environment. I'm looking to add an additional case or cases to the E2E as well.
When I had to regenerate the CRD manifests and the generated code, I did have to bump the controller-gen version from 0.13.0 to 0.16.3 because of null pointer derefs when using Go 1.22 (https://github.com/kubernetes-sigs/controller-tools/issues/880). I'm happy to downgrade my Go install to a 0.13.0 compatible version if required to maintain consistency with the controller-gen version used previously.
Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@microsoft-github-policy-service agree company="Microsoft"

Bumping for review

Bumping again for a potential review - tagging @OliverMKing

Bumping for review

Bumping for potential review. @OliverMKing


BigQueryParameter.Type + BigQueryParameter.ArrayType names

I'm not changing right now, but logging this for tracking.
These are potentially confusing.
Better names for each would be:
BigQueryParameter.Type -> BigQueryParameter.BigQueryDbType  (propertyname == typename as done in ADO.NET)
BigQueryParameter.ArrayType -> BigQueryParameter.ArrayElementType  (as done in reflection).

Both sound fine to me, yes.


OLS-1168: Script to bump-up version

Description
OLS-1168: Script to bump-up version
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Additional tooling

Related Tickets & Documents

Related Issue #OLS-1168

/lgtm
/approve


(PDB-4242) Add/use now, parse-wire-datetime and to-java-date fns

Test PASSed

Test PASSed

Test PASSed

Test PASSed

Test FAILed

Test PASSed

Test PASSed

Test FAILed

Test PASSed


replace real/imag stats with power/phase stats

This PR aims to make QA stats for CSLC consistent with that of *SLC in NISAR QA. To expedite the merging of this PR, the stats (min, max, mean, stddev) are computed with numpy. The isce3.math.stats class with its multithreading capability can not be as easily adapted to apply power and phase to a complex raster.
TODO:
~testing~

@LiangJYu is testing still pending?

Good to go. I think #148 should take precedence over this PR to prevent conflicts there.

Need to update specifile.txt with pytest-order

retest this please

These unit tests are elementary. The code should be seen as a placeholder instead of as the final test. I added them with the idea that it's better to have some test than no test. How do you reviewers feel about this approach?

These unit tests are elementary. The code should be seen as a placeholder instead of as the final test. I added them with the idea that it's better to have some test than no test. How do you reviewers feel about this approach?

Fine with me. I think we can put the tests with some relexed thresholds, and revisit this to fine-tune the criteria in the tests.

These unit tests are elementary. The code should be seen as a placeholder instead of as the final test. I added them with the idea that it's better to have some test than no test. How do you reviewers feel about this approach?

Fine with me. I think we can put the tests with some relexed thresholds, and revisit this to fine-tune the criteria in the tests.

But just letting you know that the test on the mean of phase failed. Below is the code snipped I've added couple of lines like the snipped below  to print out the stats:
print(f'Testing: {stat_name} of {pwr_phase}', end=' ')
stat_val =h5_obj[f'{h5_stats_path}/{stat_name}'][()]
print(stat_val)

And here is what the value looks like:
Testing: mean of power 2552.5999
Testing: min of power 2.6862714e-05
Testing: max of power 56852844.0
Testing: mean of phase -0.00043806355

So apparently the current criteria for the phase mean needs to be adjusted. Please see my comment above.


quick fix for daprd/app startup coordination in standalone mode. (#174)

Description
quick fix for daprd/app startup coordination in standalone mode.
Issue reference
#174
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: yglcode sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@yglcode Is this PR still valid?

@yglcode this PR is very old and I am closing it for now to keep PRs manageable across all our repos. Feel free to reopen when you plan to work on it again.
Looking forward to your contribution, thanks!


node unable to join cluster

Summary
After upgrading to 0.10. The two nodes can not see each other in one cluster :(
Steps To Reproduce

Install Kong 0.10.0 on a node via deb (let me call it master node although I know there is no master/slave differences in Kong)
Install Kong 0.10.0 on another node via docker (let me call it slave node)

Additional Details & Logs

Kong version 0.10.0
Ubuntu 16.04

Both of the two nodes are healthy. And I can see them in the database's nodes table as follows:

name
cluster_listening_address
created_at

1913ec66b39d_<IP_ADDRESS>:7946_50510ee9a9914c63965682c52956480d
<IP_ADDRESS>:7946
2017-03-09 13:25:57

ors-gateway_<IP_ADDRESS>:7946_c1a37772c22843b1bd1e7e442b10e3f3
<IP_ADDRESS>:7946
2017-03-09 08:51:06

But they just can not see each other. When executing curl http://<IP_ADDRESS>:8001/cluster, I got the messages as follows for each of them:
master node
{
    "data": [
        {
            "address": "<IP_ADDRESS>:7946",
            "name": "1913ec66b39d_<IP_ADDRESS>:7946_50510ee9a9914c63965682c52956480d",
            "status": "alive"
        }
    ],
    "total": 1
}

slave node
{
    "data": [
        {
            "address": "<IP_ADDRESS>:7946",
            "name": "1913ec66b39d_<IP_ADDRESS>:7946_50510ee9a9914c63965682c52956480d",
            "status": "alive"
        }
    ],
    "total": 1
}

The curl http://<IP_ADDRESS>:8001/cluster/nodes/ returns nothing but
{
    "message": "Not found"
}

And the kong cluster members return only one alive node on both of them. The config related to clustering on the master node:
cluster_listen = <IP_ADDRESS>:7946
cluster_listen_rpc = <IP_ADDRESS>:7373
cluster_ttl_on_failure = 3600
cluster_profile = lan

The docker start command for the slave node:
#!/bin/bash
docker run -d --name kong \
    -e "KONG_LOG_LEVEL=info" \
    -e "KONG_PG_HOST=DB_IP_ADDR" \
    -e "KONG_PG_DATABASE=kong" \
    -e "KONG_PG_USER=kong" \
    -e "KONG_PG_PASSWORD=******" \
    -p 8000:8000 \
    -p 8443:8443 \
    -p 8001:8001 \
    -p 7946:7946 \
    -p 7946:7946/udp \
    kong

What's the possible problem? Any ideas? Thanks a lot!
BTW, they can surely see each other in 0.9.8 before this upgrading

first thought: both Kong nodes think they run on <IP_ADDRESS>, albeit the Docker one is abstracted through an overlay/nat network

@Tieske yes they are. But the config were just fine in 0.9.8. Should I change anything in 0.10's config? Anyway, I will try. Thanks a lot!

you probably need to tweak the cluster listen and cluster advertise properties, see https://getkong.org/docs/0.10.x/network/

@Tieske ok, problem solved. I just figured out that the cluster_listen and cluster_advertise CAN NOT be just left with the default value <IP_ADDRESS>:7946. I really suggested this to be emphasised in the document's network section because this is changed from 0.9 to 0.10. For anyone met the similar problem, please change the cluster_listen config to your_ip_addr:7946 instead of <IP_ADDRESS>:7946.  To get this address, you can just run
docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' container_name_or_id

The command is from this answer on stackoverflow.

I just ran into this testing 0.10 as well. The docs and kong behavior are out of sync, not sure which is correct.

cluster_advertise
By default, the cluster_listen address is advertised over the cluster. If the cluster_listen host is '<IP_ADDRESS>', then the first local, non-loopback IPv4 address will be advertised to other nodes. However, in some cases (specifically NAT traversal), there may be a routable address that cannot be bound to. This flag enables advertising a different address to support this.

Specifically "the first local, non-loopback IPv4 address will be advertised"
However, with cluster_advertise unset, the node is advertising itself as <IP_ADDRESS> (I can see it in the "nodes" DB table). My nodes are VM's, not Docker containers, and each has a 10.x.x.x IP available but it is not the IP Kong picked to advertise.

@jhenry82 I had exactly the same idea with yours just 5 minutes ago, then I saw your reply 😆
I really think this is a bug that existed from 0.10 rc3 as #2037 mentions. I did a little bit digging, but could not find where this cluster_listen conf value has been set and stored to the database. What I have found is just in the function normalize_ipv4, the <IP_ADDRESS> was not given any special processing. I don't know how could you ensure it can be interpreted to the first non-loopback ipv4 address instead of <IP_ADDRESS> @Tieske . Actually, when I tried pinging <IP_ADDRESS> on my local machine, I got
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.028 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=64 time=0.019 ms
...

And in 0.9.8, I don't have such issue.

just notice that there is a lua-ip project from your team to get the first non-loopback ipv4 address. why not using it in Kong?

I believe this behavior came directly from Serf, and Kong 0.10.0 bumps the Serf version from 0.8.0 to 0.8.1, so that could be a reason why. More details:

Here is where the node name you see in the DB comes from: prefix_handler.lua
Here is where the node inserts itself in the DB: serf.lua
The IP inserted in the cluster_listening_address column comes from running the underlying serf members command on the local Serf agent started by Kong: serf.lua

just notice that there is a lua-ip project from your team to get the first non-loopback ipv4 address. why not using it in Kong?

This is legacy, untested, and also undesired as it introduces one more of those C module dependencies we are trying to get rid of.

@tumluliu @jhenry82 To confirm, what is the result of serf members on your node, ideally, with both 0.9.8 and 0.10.0? That would be really helpful. Thanks!

@thibaultcha thanks a lot for your information. For the moment, I can only provide the serf agent and serf members results for the machine with Kong 0.10 whose cluster_listen is set to <IP_ADDRESS>:7946:
$ serf agent
==> Starting Serf agent...
==> Starting Serf agent RPC...
==> Serf agent running!
         Node name: 'ors-gateway'
         Bind addr: '<IP_ADDRESS>:7946'
          RPC addr: '<IP_ADDRESS>:7373'
         Encrypted: false
          Snapshot: false
           Profile: lan

==> Log data will now stream in as it occurs:

    2017/03/10 09:12:02 [INFO] agent: Serf agent starting
    2017/03/10 09:12:02 [INFO] serf: EventMemberJoin: ors-gateway <IP_ADDRESS>
    2017/03/10 09:12:03 [INFO] agent: Received event: member-join

$ serf members
ors-gateway_<IP_ADDRESS>:7946_c1a37772c22843b1bd1e7e442b10e3f3  <IP_ADDRESS>:7946  alive

In the docker container of the slave node
$ docker exec kong serf members
40ebb2b13c40_<IP_ADDRESS>:7946_e7b02c6b941e405eb2198574598e9c11  <IP_ADDRESS>:7946  alive

Unfortunately, I haven't found an appropriate machine to test the 0.9.8. I tried installing it on my macbook with the pkg package. But serf can not find the private ip address with this error message:
$ serf agent
==> Starting Serf agent...
==> Failed to start the Serf agent: Error creating Serf: Failed to create memberlist: No private IP address found, and explicit IP not provided

BTW, the serf version for my kong-0.10 is 0.8.0, while for the kong-0.9.8 is 0.7.0. When I find another machine can test 0.9.8, I will post the serf members results. Anyway, I think the reason becomes clearer: serf wrongly returns <IP_ADDRESS> as the first non-loopback local ipv4 address.

I have got the serf members information from 0.9.8 kong docker container:
$ docker exec kong-0.9.8 serf version
Serf v0.7.0
Agent Protocol: 4 (Understands back to: 2)
$ docker exec kong-0.9.8 serf members
fdebb3fd63aa_<IP_ADDRESS>:7946_d73429383a0f438cb033c99932ea8469  <IP_ADDRESS>:7946    alive

The ipv4 address <IP_ADDRESS> got by Serf 0.7.0 is correct. Hope that helps, @thibaultcha .

Hi everyone.
I'm using docker-compose for local dev and we use AWS ECS as our production docker clustering solution. This makes working out what the cluster_listen address is problematic.
Until this bug is fixed we've come up with the following workaround: (NB we use supervisord to run kong but you could rip that out if you wanted.
I ended up writing a thin wrapper that we use before we start kong. It requires the net-tools package be installed on top of the official kong one (yum install -y net-tools)
this works out the correct address to use at runtime
#!/bin/sh
IP_ADDR=`ifconfig eth0 | awk '$1 == "inet" {gsub(/\/.*$/, "", $2); print $2}'`
echo "SETTING IP_ADDR FOR KONG CLUSTERING TO: ${IP_ADDR}"

export KONG_CLUSTER_LISTEN="${IP_ADDR}:7946"
<start kong>

i think https://github.com/hashicorp/memberlist/issues/102 is the underlying issue and serf 0.8.2 should address this

as we're planning to remove the Serf dependency all together, we're now leaning towards reverting Serf back to version 0.7 for the next release (0.10.1)

@Tieske what are you planning to replace serf with? Hitting the database more often? I am wondering because we are looking into deployment of Kong for more endpoints

@TransactCharlie's trick worked. Though, since I'm using it inside an AWS AMI, I found hostname -I | cut -d' ' -f1 to be a lot more elegant when used with user data.

Leaving here as a note for other Docker users. Most of the times, Kong would not properly start as soon as we introduced a persistent postgres volume.
Long story short, we were also publishing a port the docker service which causes the service containers to have two networks: user-overlay network and the default ingress network. Now with both networks attached, the container will have at least two interfaces with non-default IPV4 addresses; which causes serf to randomly pick one of them on startup. Again keeping it short, but this resulted in sometimes the ingress address to be selected which resulted in even weirder behavior (e.g: kong startup would just hang).
Anyway, in docker world we were able to use the following solution (without resorting to net-tools and grep):
IPADDR=$(hostname -i)

echo "Starting Kong..."
export KONG_CLUSTER_LISTEN="${IPADDR}:7946"
kong start --vv &

Considering this resolved as Kong 0.10.01 was shipped with a Serf downgrade back to 0.7.0. Future versions of Kong will not even need Serf anymore :)
Thanks!

@thibaultcha This is reproducible with kong 0.9.9 which comes with serf 0.7.0. Faced this clustering issue https://github.com/Mashape/docker-kong/issues/93 with kong in docker swarm
Workaround https://github.com/Mashape/kong/issues/2182#issuecomment-296069535 by @saamalik fixed it. Thanks!


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that i can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
Then I see four boxes titled HTML, CSS, Git and Javascript with associated notes listed

HTML
User Story
As a bootcamp student
I want the paperwork notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide Website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed.

CSS
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVEN a prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow.

JavaScript
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first.


Android this is not an activity

When running on android I get the issue when adding package to MainActivity.java
 new RCTSplashScreenPackage(this)

Will crash on error
MainApplication.java:41: error: incompatible types: <anonymous ReactNativeHost> cannot be converted to Activity
      new RCTSplashScreenPackage(this)

React 0.31

Registering Module for Android is different when using React 0.30+,
first step: remove ReactNativeHost final defination,  and add next codes in MainApplication.java
//private final ReactNativeHost reactNativeHost = new ReactNativeHost(this) {
private ReactNativeHost reactNativeHost = new ReactNativeHost(this) {
...
}
public void setReactNativeHost(ReactNativeHost reactNativeHost) {
this.reactNativeHost = reactNativeHost;
}
second step: add next codes in MainActivity.java
/**
 * A subclass may override this method if it needs to use a custom {@link ReactRootView}.
 */
@Override
protected ReactRootView createRootView() {

    MainApplication mainApplication=(MainApplication)this.getApplication();
    mainApplication.setReactNativeHost( new ReactNativeHost(mainApplication) {
        @Override
        protected boolean getUseDeveloperSupport() {
            return BuildConfig.DEBUG;
        }

        @Override
        protected List<ReactPackage> getPackages() {
            return Arrays.<ReactPackage>asList(
                    new MainReactPackage(),
                    new RCTSplashScreenPackage(MainActivity.this)  //register Module
            );
        }

    });

    return super.createRootView();
}

Still didn't figure it out. Can you put a working example for this?


sspi: using wrong dev when send local address to kernel?

Describe the bug
When a new mptcp conntion create, SSPI will send each address associate with all the network interfaces other than which the new connection was created to kernel，but it is always using the same network interface index in sspi_send_addr()，and it is not the interface which address belongs to.
eg. I have two nic, ens33 and ens37, when get a new mptcp connection at <IP_ADDRESS>(ens37),  addresses in ens33 is send to kernel by SSPI, but these addresses are associated with ens37.
Is this a BUG?
2: ens33: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 00:0c:29:bb:2e:ca brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global noprefixroute dynamic ens33
valid_lft 1715sec preferred_lft 1715sec
inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global secondary dynamic ens33
valid_lft 1290sec preferred_lft 1290sec
inet6 fe80::63d2:1cb6:e7c6:ae30/64 scope link noprefixroute
valid_lft forever preferred_lft forever
3: ens37: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 00:0c:29:bb:2e:d4 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global noprefixroute ens37
valid_lft forever preferred_lft forever
inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global secondary dynamic ens37
valid_lft 1480sec preferred_lft 1480sec
inet6 fe80::2ace:2b3c:1129:67b4/64 scope link noprefixroute
valid_lft forever preferred_lft forever
[root@bogon mptcp]# ./pm_nl_ctl dump
id 1 flags  dev ens37 <IP_ADDRESS>
id 2 flags  dev ens37 <IP_ADDRESS>
id 3 flags  dev ens37 fe80::63d2:1cb6:e7c6:ae30
To Reproduce
Steps to reproduce the behavior:

run mptcpd
create mptcp connection
./pm_nl_ctl dump

Thanks for the detailed description.  This does seem like a bug.  I'll try to reproduce it, and fix it accordingly.

Thanks，I have two other questions：

Thanks, I have some other questions:

sspi will send all local addresses associated with a network interface, so if a nic have more than one address, it will create more than one subflow on that nic, not sigle subflow per interface as sspi is intend to do?
now sspi doesn't set any flags on local address, so it won't signal to remote side, or create subflow?
sspi_send_addr() set address_id to 0, this will cause return EINVAL in mptcpd_pm_add_addr(), and address is not sent to kernel really?

every new mptcp connection(MPTCP_EVENT_CREATED) event will trigger sspi send local address to kernel?

1. sspi will send all local addresses associated with a network interface, so if a nic have more than one address, it will create more than one subflow on that nic, not sigle subflow per interface as sspi is intend to do?

The sspi plugin should remove the subflow if it detects an existing subflow on a given NIC.  In sspi_new_subflow():
        if (l_queue_find(info->tokens,
                         sspi_token_match,
                         L_UINT_TO_PTR(token)) != NULL) {
                l_warn("Subflow already exists on network "
                       "interface (%d). "
                       "Closing new subflow.",
                        info->index);

                mptcpd_pm_remove_subflow(pm,
                                         token,
                                         laddr,
                                         raddr);

                return;
        }

In the scenario you described this is not very efficient due to the additional netlink messages that could potentially have been prevented earlier in the sspi_new_connection() event handler.  At the time the sspi plugin was written it was believed that such a scenario was not common, or at the very least IP addresses on a given NIC would not change often, meaning this plugin behavior shouldn't be a performance bottleneck.  Regardless,
Please keep in mind that mptcpd, along with its plugins, is meant to be a reference implementation of a user space path manager.  :)

2. now sspi doesn't set any flags on local address, so it won't signal to remote side, or create subflow?

This is a known bug that is slated to be fixed for the next (0.8) mptcpd release.  A similar problem exists in the addr_adv plugin.  I'll create an issue in GitHub to make it easier to track progress.

3. sspi_send_addr() set address_id to 0, this will cause return EINVAL in mptcpd_pm_add_addr(), and address is not sent to kernel really?

Thanks for pointing this out. The EINVAL caused by the zero address ID is a vestige of the original implementation for the multpath-tcp.org kernel.  That kernel requires the address ID for the add_addr command, but the upstream kernel does not.  I'll move the zero address_id check that triggers the EINVAL to the multipath-tcp.org implementation in src/netlink_pm_mptcp_org.c.
There was also some confusion in the mptcpd_pm_add_addr() and mptcd_pm_remove_addr()` functions where overlap in support for the multipath-tcp.org and upstream kernel was implemented, but really there should be separate implementations since the multipath-tcp.org kernel PM netlink API's add_addr command is client-oriented (per-connection) whereas the upstream kernel PM netlink API's add_addr command is server-oriented.  Path management is done in the kernel for the latter.  We are currently planning to remove the overlap, and split add_addr and remove_addr functionality into client- and server-oriented functions.  Doing so would also remove unused parameters from the functions, depending on the use case.  No GitHub issue exists for this yet, but it is listed as a note in the mptcpd 0.8 project.

1. every new mptcp connection(MPTCP_EVENT_CREATED) event will trigger sspi send local address to kernel? this leads to a lot of repetitive work.

That's a good point.  It would probably be good to track whether or not an add_addr for given IP address is necessary prior to issuing that command.

Hi ossama，thank you for your patient  explanation:)


Problem with hashCode() on null attribute when used on hash based structure

The @EqualsAndHashCode annotation that use Long attribute such as pk can cause some unspected behavor when use with hash based structure (like HashSet).
eg.:
@Entity
@EqualsAndHashCode(of = "pk")
class Foo {

    @Id
    private Long pk;

    private LocalDate createdAt;

}

@Entity
class Foo {

    @Id
    private Long pk;

    private LocalDate createdAt;

    public int hashCode() {
        int PRIME = true;
        int result = 1;
        Object $pk = this.getPk();
        int result = result * 59 + ($pk == null ? 43 : $pk.hashCode());
        return result;
    }

    public String toString() {
        return getClass().getName() + "@" + Integer.toHexString(hashCode());
    }
}

So when the instance with pk = null and other with pk = 43, it will return the same hash code and it may be considered as same on hash based structure, wich they aren't.
And in the case to use OmniFaces ListConverter that use toString we have the same problem.
Maybe return a hashcode of the object instance rather than an hardcoded constant
Did you already take this scenario, or do you know some way to workaround this situation?!
Version info

Lombok => 1.18.8
Platform => Windows 10 JDK 11.0.4 IntelliJ

So when the instance with pk = null and other with pk = 43, it will return the same hash code

This doesn't matter. Moreover, there'll be always hash collisions, no matter what you choose.
Note that Arrays.hashCode, String.hashCode and many others produce tons of collisions, rather needlessly.

Maybe return a hashcode of the object instance rather than an hardcoded constant

In my manually written code, I'm asserting that it doesn't get called before an id gets assigned. That's surely strange, but so are all alternatives.

It would be possible to create an annotation parameter that could tell which value should be used when the PK is null, in this case. For default 43.
This would give more control to the developer.
@EqualsAndHashCode(of = "pk", ifAnyNull = -1)

So it will use -1 instead 43, for any field that was null

43 is probably as good as any other number. Making it configurable puts adds maintenance load for a very low added value.
Using the Identity hashcode for null would break the equals contract.


[tool_crash] FileSystemException: Cannot copy file to 'C:\Users\Raf4e\Documents\Programing\Flutter\first_app\hello_world\hello_world\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied., errno = 5

Command
flutter create --ios-language swift --android-language kotlin .

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot copy file to 'C:\Users\Raf4e\Documents\Programing\Flutter\first_app\hello_world\hello_world\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied.
, errno = 5
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.copySync (dart:io/file_impl.dart:340:5)
#2      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#3      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#4      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:256:18)
#5      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8)
#6      Template.render (package:flutter_tools/src/template.dart:182:24)
#7      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:781:21)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#15     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#16     Template.fromName (package:flutter_tools/src/template.dart)
#17     _rootRunUnary (dart:async/zone.dart:1198:47)
#18     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#19     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#20     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#21     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#22     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#23     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#24     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)

[✓] Flutter (Channel stable, 1.20.2, on Microsoft Windows [Version 10.0.18362.959], locale en-US)
    • Flutter version 1.20.2 at C:\Src\flutter
    • Framework revision bbfbf1770c (10 days ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
      You may also want to add it to your PATH environment variable.

[✓] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.48.1)
    • VS Code at C:\Users\Raf4e\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.13.2

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Flutter Application Metadata
No pubspec in working directory.

Hi @Raefetoxic ,
I see there's a similar open issue describing your case, https://github.com/flutter/flutter/issues/50880.
Please follow-up there for updates.
Thanks.

Hi @Raefetoxic,
There's a similar open issue, 50880.
Closing this as duplicate.


luci-app-statistics: Edited Swedish translation

Signed-off-by: Kristoffer Grundström<EMAIL_ADDRESS>

This pull request looks erroneous / unnecessary to me.

Yeah, this file is a special case - we can skip it.


Units

Units
This MR introduces Units into miniflask.
Those are custom numbers that share multiple representations.
TODO:

[ ] check syntax for better simplicity. it seems to me that more complicated units can be defined very good currently, but easier ones (like time, with a fixed set of conversions) are cumbersome to define. Can we do better?
[ ] add unit tests
[ ] add examples to documentation

Example
First, we define time to be a unit with four different representations.:
def convert_time_unit(src_value, src_unit, dest_unit):
    factors = {
        "second": 1,  # base unit
        "minute": 60,
        "hour": 60 * 60,
        "day": 60 * 60 * 24,
    }

    # first convert to base, then to dest unit
    return src_value * factors[src_unit] / factors[dest_unit]

time = mf.register_unit("time", convert_time_unit, [
    ["second", "s"],
    ["minute", "m"],
    ["hour", "h"],
    ["day", "d"]
])

In CLI, we can overwrite this unit using:

--time 1.5d (1.5 days)
--time 24h (24 hour)
--time 500m (500 minutes)

Using u in v Notation, we can specify the base unit to convert all calculations to.:

--time 12h in d (0.5 days)
--time 1.5d in h (18 hours)

To register a unit, pass it to register_defaults as follows:
Note, that the base unit is always the one that is passed last to the variable.
In the example below, time uses hours internally, time2 and time3 use days internally.
mf.register_defaults({
    "time": time(6.0, "h"),
    "time2": time(6.0, "h in d"), # in notation works here as well
    "time3": time(6.0, "d")
})

Querying other representations can be done easily, once defined:
state["time"].unit # the base unit name
state["time"].second
state["time"].minute
state["time"].hour
state["time"].day

Calculations works similarly:
state["time"].second += 10
state["time"].minute += 10
state["time"].hour += 10
state["time"].day += 10

Things done in this MR

added internal classes for units (Unit, UnitValue, UnitValueArgparse)
added Units to Argparse / CLI-Parsing
added mf.register_unit funciton

Check all before creating this PR:

[x] Documentation adapted
[x] unit tests adapted / created

I am quite confident and positive towards the current design decisions, having it tried already in a testing environment of larger scale. ;)
Unfortunately, there is still one thing i am not very happy with, namely the length of the example in the documentation. Do you have possibly a easier solution using the current method-signature of the unit-definition?


BotW Graphic Pack Day Length Mod Issue

When trying to adjust the speed of time with the "Day Length" mod time doesn't actually move faster or slower. Appears to be broken.

Fixed in https://github.com/ActualMandM/cemu_graphic_packs/commit/ca22977ef03e4a826f3bfe7f0df92447437c4219

Fixed in https://github.com/ActualMandM/cemu_graphic_packs/commit/ca22977ef03e4a826f3bfe7f0df92447437c4219

This is not fixed. I just tested with the latest graphic pack update.

This is not fixed. I just tested with the latest graphic pack update.

None of the "Day Length" setting have any effect on the clock and the "Freeze Time" option just makes the clouds freak out and time still progresses as normal.

None of the "Day Length" setting have any effect on the clock and the "Freeze Time" option just makes the clouds freak out and time still progresses as normal.


Fail to build image with yarn install calling other repo

Hi,
I'm trying to build my docker image (it runs like a charm locally). Locally, i pass docker build args with my private and public key (this key is on the second repo). When yarn install calls the private repo, i get an "not authorized".
My config:
name: Docker Image CI (posts@v1)
on: [push]
jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- name: webfactory/ssh-agent
  uses<EMAIL_ADDRESS>  with:
      ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: Build the Docker image
  run: docker build --build-arg ssh_prv_key="$(cat key)" --build-arg ssh_pub_key="$(cat key.pub)" . --file Dockerfile --tag mydockerimage/image:$(date +%s)

This action above fails.
This action below, fails too.

name: Build the Docker image
run: docker build  . --file Dockerfile --tag mydockerimage/image:$(date +%s)

What i did wrong?
Thanks
Fabio

The key file that you seem to have present locally does not exist on the worker node. The key is available in the ssh-agent (in-memory) only.

I've added a note for this at https://github.com/webfactory/ssh-agent/blob/master/README.md#provide-the-ssh-key-as-a-file.


[Access Request] page 599 "Payment Disc Tolerance Warning" - proteced vars for PageExtension

Could you please change the scope fof the following variables to protected?
    var
        Amount: Decimal;
        AppliedAmount: Decimal;
        BalanceAmount: Decimal;
        Posting: Option " ","Payment Tolerance Accounts","Remaining Amount";
        NewPostingAction: Integer;
        AccountName: Text;
//+Change
    protected var
        PostingDate: Date;
        CustVendNo: Code[20];
        DocNo: Code[20];
        CurrencyCode: Code[10];
//-Change

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


path/filepath: does not work at all for paths containing symbolic links on directories

What version of Go are you using (go version)?
all /up to 1.10
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
all
What did you do?
Using filepath.Join or filepath.EvalSymlinks
What did you expect to see?
I expected those functions to transform valid file paths to still valid file paths
What did you see instead?
Completely corrupted file paths if the path contains a symbolic link to a directory
General Description
The first time I observed a strange behaviour was by using terraform. terrform switched to the
use of filepath.EvalSymlinks. Afterwards my terraform project using symbolic links was completely corrupted. Later I wanted to use this function in my own coding, with the same strange results.
An analysis of the filepath package yields something I couldn't believe:
The package defines a function Clean that formally normalizes a file path by eliminating .. and . entries. As described in the documentation this is done WITHOUT observing the actual file system. Although this is no problem for the function itself, because it is designed to do so, it becomes a severe problem for the whole package, because NEARLY ALL functions internally use Clean to clean the path even on intermediate results. As a consequence even functions like Join may deliver corrupted invalid results for valid inputs if the path incorporates symbolic links to directories. Especially EvalSymlinks cannot be used to evaluate paths to existing files, because Clean is internally used to normalize content of symbolic links.
Therefore I had to switch to a modified implementation solving this problem.

Its not what I would call the wrong evaluation order but more Cleaning at every possible step. The only safe time to Clean is when we are done since Join and Clean does not lstat before eliding dots.
I have cobbled something that appears to work, now I just need to clean it up and add some testcases. Should have something tomorrow.

While I like the approach above, it doesn't quite work in all situations. I have added a single test case which highlights the problem. The above code only solves 1 out of 3 scenarios performed in the tests.

which version go fixed this bug?
I have go 1.11 and on windows the symlink issue continues to occur.

which version go fixed this bug?

7d27e87 change has not been released yet. It will be part of go1.12.
Alex


cleanup: Add two missing ContainerFileNotices

There are two new Dockefiles: one to generate SFC MachineConfig, and another is an Onload kernel module builder for the Ubuntu kernels. This patch adds the corresponding ContainerFileNotice even though the latter image is a template.

Re on Dockerfiles:

I chose the specific version of Butane (v0.19.0), which must be the latest release tag.
Ubuntu is borderline, as we don't build these images, but added for completeness.

@pcolledg-amd Thanks, I've expanded the commit message. 👍

I've listed them in the body of the commit message, but your version works for me too.


Create _vercel.thedev.me

Verifying domain access for Vercel is not supported. You can only edit your own subdomain's record.