is queryFeatures deprecated?

I would like to use some functionality related to retrieving polygons/features based on user interaction.  One of the examples calls a method queryFeatures that seems to accomplish more-or-less what I need.  However, I no longer see that method in the codebase, even though I have access to it through the module I installed with npm.  It seems that the module I have installed is v1.24
Is this querying feature deprecated?  If so, is there a recommended replacement for this workflow?

Yes, use MapLibre instead, because its internal design already supports user interaction out of the box.

That's unfortunate.  Do you have recommendations on how to translate points from the internal coordinate system to lat/long?  I can roll my own queryFeatures with a kdtree.

I don't have any recommendations beyond how queryFeatures worked before, which is still in the Git history. The method used does not properly account for the difference between features in the tiles and features rendered by the style, does not persist properly across zoom interactions, and also doesn't work correctly when overzooming, which is why I recommend using MapLibre for anything involving dynamic interaction. It's not a good use of maintenance time to reproduce all those features when MapLibre already does them perfectly.


[T5A1][W10-B2] Tjong Anthony

Ready for review.

@tjonganthony  Please close the PR after reading the comments.


Why is RtfPipe-Signed not updated on NuGet?

https://www.nuget.org/packages/RtfPipe/

Version
Downloads
Last updated

<IP_ADDRESS>
948
2 months ago

https://www.nuget.org/packages/RtfPipe-Signed/

Version
Downloads
Last updated

<IP_ADDRESS>
1.151
12-4-2017

Oh I see now the signed version was created by someone else.

Please make a signed version... I have a strong typed project that needs it :-)

I don't have the bandwidth to manage signing this package currently. If there is enough interest, I can re-evaluate in the future.

Signing a package is just 10 seconds work


Test with Bokeh

Currently live plotting is disabled for testing. The reason for that are difficulties emerging when testing Blocks-examples in the context of testing Blocks, see the PR https://github.com/mila-udem/blocks/pull/748.

(Kind of) fixed by https://github.com/mila-udem/blocks-examples/pull/24


Use notification relay to update app state. Version 0.3.0

Included in this PR:

Updates to how startup reason is persisted to disk to ensure writes happen atomically.
Use a notification relay for app state updates to improve accuracy by hooking into first notification update (in AppDelegate)
Improve initial app state check to correctly record if the app is launched in the background or not.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added Starbucks in Braga, Portugal

I... really don't like Starbucks. :/ I'm not sure that it qualifies as awesome, even if the wifi is OK and there were clean tables the day you went in. I'd rather not include this one.
@diasdavid, thoughts?

Starbucks (like many other international coffee and food chains) offers a different experience depending on the country/city. I've found great Starbucks in Lisbon in Zurich that I use often to hack.
If @rgllm recommends this one starbucks as a great place to hack, then why not :)

Hi @diasdavid and @RichardLitt this Starbucks is definitely not like the american ones. Is located in a old building with good tables and is very calm.

@RichardLitt I believe that was an invite for you to go check it out with @rgllm :)

Hahaha! I would gladly do so, were I in Portugal at the moment. Alas, an ocean divides us. I will certainly do so if I journey back across the pond. :)


Trie.py and README updated

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

Fill the PR template.

Hey @plazzy99 please review the request..

Hey @plazzy99  @iamrajiv  @atarax665  can you please add the hackotberfest labels?


Feature 20230404 add directory tool

add directory tool and update c++ standard version to  c++20

GitHub action need to support c++20


Pydantic 2 compatibility

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #26 (37d9752) into main (ff399c9) will decrease coverage by 43.83%.
The diff coverage is 95.07%.

Additional details and impacted files


How to Import 4 stage CA in OpenXPKI 3.4.0

Bonjour All,
https://openxpki.readthedocs.io/en/stable/quickstart.html#setup-base-certificates states that it creates a sample 2 stage CA with a Root and an Issuing SubCA. We can also import our already created CA.
What will be the procedure to import a 4 Level CA and the 4th CA is the issuing CA?
Thanks
Scott Thomas

Hi Scott, please use the Mailinglist fir Support - http://www.openxpki.org/support.html - not the Issue Tracker!
OpenXPKI just needs to know the full chain, start with the root and import all additional intermediate certificates the same way. Thats all.


⚠ SpeakUpSpeakerServices.com has degraded performance

In 7e5258f, SpeakUpSpeakerServices.com (https://www.speakupspeakerservices.com) experienced degraded performance:

HTTP code: 200
Response time: 10436 ms

Resolved: SpeakUpSpeakerServices.com performance has improved in 8af528f after 17 minutes.


Update sbt to 1.3.6

Updates org.scala-sbt:sbt from 1.2.8 to 1.3.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: sbt-plugin-update, semver-minor

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   83.47%   83.47%
=======================================
  Files          77       77
  Lines        2632     2632
  Branches       68       68
=======================================
  Hits         2197     2197
  Misses        435      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5974c8d...e167577. Read the comment docs.


Fix install_crontab.sh so that $INSTALL_DIR is not hard-coded

Fixed by https://github.com/jerbzz/pi-eco-indicator/commit/4295f625a287f33e868c24105cba3b30e5551718


Bump json from 20160810 to 20230227

See https://github.com/scylladb/kafka-connect-scylladb/pull/89
It's a significant change, I hope it'll pass.

Closing this issue as we got rid of json dependency altogether.


Linked Lists

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (f35c8e1) to head (209f34b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   99.27%   99.45%   +0.18%
==========================================
  Files           3        4       +1
  Lines         138      185      +47
  Branches       42       49       +7
==========================================
+ Hits          137      184      +47
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Revert "FileLock encounters a runtime error when the path of the locked file is long"

Reverts apple/swift-tools-support-core#277

@swift-ci please test

This regressed the windows build: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/619/console

Thanks @compnerd.  What is the Windows way to get NAME_MAX?  This does need to be fixed, just reverting it won't fix the underlying issue, so I'm keen to see how to modify the fix.

@abertelrud - could we take the windows approach globally?  Just limit the full path rather than the arc?

@abertelrud - could we take the windows approach globally? Just limit the full path rather than the arc?

No, that's not the problem.  The path is not too long, it's each individual path component that has to be limited.  On Darwin etc the path max is usually 4096 or something like that (up from 1024 in earlier times) but the maximum length of an individual directory entry is usually 255 on Darwin and Linux.  That's the problem here.
A better approach would normally be to try the operation and catch the error but here we need to choose the name up-front.

I understand that this needs to be fixed but reverting it and fixing it with the ability to properly work through this seems better (unless you have a solution off the top of your head). I don't think that there is a good equivalence. There is no limit on an arc, only on the full path (MAX_PATH).

Right, of course, I thought that the fix would simply be to use another constant (e.g. FILENAME_MAX as seen here https://docs.microsoft.com/en-us/cpp/c-runtime-library/filename-max?view=msvc-170).
If the length isn't a problem on windows can we just conditionalize the logic that truncates the path rather than reverting the whole thing?  That seems as quick.  If we must revert then I can put up that PR separately concurrently with the revert.

https://github.com/apple/swift-tools-support-core/pull/281

Yes, NTFS does limit you to 255 code units per ARC, but that is not guaranteed as the file system may be FAT :-(.

Right, that's true on Darwin and other OSes as well.  If we do #if !os(Windows) here would that work for unblocking the build?  Unfortunately there's no Windows CI that will tell me if the fix I put up works.

Yeah, locally testing seems to indicate that it still breaks.  I think that #282 is a better fix, though still incomplete as it doesn't take into account the arc limitation.  However, this does seem to work to unblock the build and incidentally fixes another issue with the lock file being placed in the current working directory rather than the temp directory.  I think that a follow up to enforce the arc limit would be nice, but we can do that separately.

#281 + #282 are preferred over this.


Upgrade to the latest version of Documenter.jl

Fixes #311

bors r+

Bors r+

bors r+

Bors r+

Bors r+

bors r+

Bors r+


Cannot generate kubeconfig with cluster-scoped API tokens #26482

relate-issue #26482
P.S. why isno any response when pull request to 2.4 branch???

Closing as a duplicate of https://github.com/rancher/rancher/issues/26482


Create Bash file to run scripts

Should it be done in Milestone 3?

It is in Tiffanys notes in Lecture 4 . So not sure .

This is finished in #56


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.200

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.200


[New Rule] Create dictionary directly

Explanation
Do not use a line to create a dictionary, and then populate it. Do it directly. PyCharm has this check, which is rather neat; I think it's in Pylint as I think this linter is used behind the scenes when you run code inspection on a project. It's a bit faster (nanoseconds, whatever), and it reads nicer.
Example
# Bad
a = {}
a['b] = 'c'

# Good
a = {'b': 'c'}

$ $ astpretty --no-show-offsets /dev/stdin <<< `cat example.txt`
Module(
    body=[
        Assign(
            targets=[Name(id='a', ctx=Store())],
            value=Dict(keys=[], values=[]),
            type_comment=None,
        ),
        Assign(
            targets=[
                Subscript(
                    value=Name(id='a', ctx=Load()),
                    slice=Constant(value='b', kind=None),
                    ctx=Store(),
                ),
            ],
            value=Constant(value='c', kind=None),
            type_comment=None,
        ),
    ],
    type_ignores=[],
)

One would need to acct on ast.Assign (=node)

If value is ast.Dict and
node.next_sibling is also Assign

with node.next_sibling.target == node.target`

Then it could be added to the node directly.


About Icons. Not necessarily an enhancement I guess but wondering.

First of, I love this template. Thanks alot.
Second, I noticed you do not use react-native-vector-icons in your boilerplate code. Is there a reason for this? do you not want to deal with the configuration or is it for efficiency reasons? just curious!

Hey, thanks for the appreciation - it means alot! ❤
We don't include that because typically our projects incorporate custom assets for icons, so we would just end up uninstalling it when we take on a new client (as Ignite represents what we usually use when jumping into a new client project).
You absolutely can add vector icons either natively or through an Expo Dependency. There are also considerations to make when bringing in font icon sheets as they can increase bundle size quite a bit if not careful.
See these threads for more info:
https://twitter.com/Baconbrix/status/1676329985064435712
https://twitter.com/Baconbrix/status/1676330442474274817

Thanks for the quick and very helpful response !
One more thing, would it be possible that you create a recipe for incorporating react-native-maps in the project? as we use it quite heavily and I personally love everything you guys write so was curious to see the implementation and different things that could be done.
Thanks again!

Yeah we can look into that, if you wouldn't mind making an issue over there. This was just asked the other day actually, see this for more info:
https://github.com/infinitered/ignite/issues/2478#issuecomment-1623709219


Isolate the code that is processed inside the pool process into a method

This will isolate the method that is run inside the pool.process. This will allow us to implement any code around this block that needs to be threads safe.
This will not break any interface.

Thank you!


(Extra) Report battery info to guest

Like in VMware workstation, have a toggle that reads “report battery info to guest”.
This info (only the percentage nowadays) can be read by apps natively with Apple’s API
EDIT: how did I add the bug label

Would have to see if it’s possible in QEMU.

Blocked on https://bugs.launchpad.net/qemu/+bug/1502613/

Update in bug location
https://gitlab.com/qemu-project/qemu/-/issues/242


Fix: (powershell, ps1) Flag highlighted incorrectly

Fixes #3201
Hi  @joshgoebel,
Please have a look at this. Let me know if you want any changes.

Let's add at least one markup test and a changelog entry.

Where can I add the tests? @joshgoebel

@Patil2099 // Nothing too complex, for unit tests, refer to the tests folder and for the changelog, I believe it's CHANGES.md

Please review my pr again @joshgoebel. Thanks!

tests/markup/powershell
You'll likely add two new files: flags.txt, flags.expect.txt then run the markup tests:
npm run build && npm run test-markup

I think it is ready now @joshgoebel,

Check out character sets: https://www.regular-expressions.info/charclass.html and perhaps a tool like https://regex101.com where you can test live would help?
[\w\d] doesn't match -

Sorry, @joshgoebel. I was having a long weekend will implement the changes soon.

@joshgoebel Sorry for being late, I think it is working fine now.

I think it is ready for review now @joshgoebel

@Patil2099 Thanks!


Spanish support

Awesome! Thank you so much @amouly

@pires then I found a lot of strings all over the app which are not on the Strings.xml file. You are planning to extract them on the future?

@amouly now I do https://github.com/pires/android-obd-reader/issues/90. Do you have the time and will to take care of it? Would love to review a PR :+1:

@pires yes, I can take care of some of those strings. I mean, I like the app and i'm digging on how it works, so at the same time I can fix that ;).

Awesome! You rock.


chore(main): release 3.2.0

:robot: I have created a release beep boop
3.2.0 (2024-07-09)
Features

Add overwrite option for the unauthorized api calls alarm (#23) (5d5482e)

Bug Fixes

Allow custom unathorized api calls pattern (#25) (8e05f29)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.2.0
:sunflower:


Make Admin Hub Middleware Configurable

I made minor changes to the admin hub middleware to be configurable.

@PHPJunior I think we'd want it to default if the config isn't set.

We probably need to update the docs to include this also.

I will update the docs too

Hello,
It seems that the changes from this pull request have not been merged into the latest release version, 0.3.0. I am wondering whether these fixes are scheduled to be included in the upcoming 0.4 release or in a future patch for the 0.3 version.


First fixes to README

Well now there is a merge conflict so you must have gone and messed with it since poker... 🤦♂

merge conflicts resolved...  lemme know what you think.


Labels&filter

#8

@`` The simbols look like diffence before?

(https://www.linkedin.com/in/Delta46)

I don't get what you mean with this issue.


OpenAI Gym documentation

We should
Create more documentation about how this fits into OpenAI Gym/link to OpenAI Gym
Definition of Done
Simple description and section for openAI Gym

added https://docs.panopticon-ai.com/data-format-for-scenario-file, please check

Still need to write documentation on how the timesteps etc work, as well as the main engine you are using to calculate this stuff
Also explain how the python side is related to the front end, + overall setup of this system


Why build all stacks when not running terraspace all...?

Currently, TS builds all dependency stacks when running normal single-stack commands, e.g. terraspace build some_stack, terraspace plan some_stack etc. If you have a complex environment, this leads to pretty long run times when deploying a single stack - much longer than running pure Terraform - and I'm not really clear on the reason for it given that the dependency stacks don't ultimately seem to be used at all (templated output() values are resolved from the dependency's statefile which is entirely independent).
Was wondering if there was a reason for this. Otherwise, would it make sense to change the default include_stacks behaviour for Builder to :root_only?

See https://github.com/boltops-tools/terraspace/pull/215
In short, on a fresh clean machine, there would be issues. Unsure if there’s another approach. Will consider PRs for improvements. No sweat either way of course.


Works fine for iOS but breaking in PWA

First of all thanks for the library. I'm wondering does this supports PWA or just iOS and Web?
The same table renders correctly in the iOS device but getting error on Web (Chrome)
Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `Webshell`.
    at http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:137220:950
    at createFiberFromTypeAndProps (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:137220:1131)
    at createFiberFromElement (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:137220:1466)
    at reconcileSingleElement (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:135458:714)
    at reconcileChildFibers (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:135471:147)
    at reconcileChildren (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:135708:22)
    at mountIndeterminateComponent (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:135858:132)
    at beginWork$1 (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:136147:101)
    at HTMLUnknownElement.callCallback (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:132842:102)
    at Object.invokeGuardedCallbackDev (http://<IP_ADDRESS>:8080/vendors~main.646b02c2919a82ab84d1.js:132862:45)

The same code works correctly in iOS device, but breaking on Web.

@thidasapankaja It breaks because of react-native-webview which has no support for Web. react-native-web is not an official project of React Native, and this library doesn't claim support for it. However, it might work if you replace  WebView from react-native-webview with react-native-web-webview, but I have never tried this library before. Tell me if it works out for you.

@jsamr Thanks a lot. sure. I'll check that and update here.

You can also use a web alias :-) https://necolas.github.io/react-native-web/docs/?path=/docs/overview-getting-started--page#configuring-a-module-bundler

@thidasapankaja Did that work out for you? I was thinking of implementing a custom "react-native-web-webview" thanks to Ersatz, because Ersatz has a "backend" API that I could easily interface with react-dom.

Sorry about the delay in response. It didn't work for me.
In my case I used dangerouslysetinnerhtml which were usable for my case.
Anyway, Thanks a lot

@thidasapankaja I am actually implementing an alternative to react-native-web-webview ; would you be interested to test a pre-release?

Did you create the react-native-web-webview pre-release?

@krini Yes! A new package, @formidable-webview/web has been added to Ubiquitous project. To enable this library after installing, you will have to tell webpack how to do it. See this webpack config file.


reduce size limit for scanline files; prevent large chunkoffset allocations

This change introduces a new function into the API
Specially crafted OpenEXR files can cause large amounts of memory to be allocated by the library when reading code, even if the file is very small. This PR proposes two ways to mitigate this:

regular (non-deep) scanline files are now limited to less than 2GB of uncompressed data per chunk of scanlines, Previously the maximum size was 2GB of compressed data per scanline chunk, and 2GB uncompressed data per scanline
if the computed chunkoffsettable size in scanline or multipart images is very large, a seek followed by temporary read of the last element in the chunk table is attempted before allocating memory. This may cause slightly slower initialization of OpenEXR files containing huge images. This helps to prevent very small OpenEXR files being used to cause a target machine to allocate large amounts of memory, which may form part of a (very obscure) denial of service attack. With this change, memory is only allocated if the file really does contain enough data to store the declared size of chunk table, which means large memory allocations for the table would require an even larger file to be transferred to the target machine

It is not known if any legitimate EXRs exist that have more than 2GB of uncompressed data per scanline chunk. If so, they will rely on effective compression to prevent the compressed data size exceeding 2GB. Such files will have many channels (in which case using multiple parts would be more appropriate) or very wide scanlines (in which case tiled images would be more appropriate). Uncompressed files, and zip-single compressed files, are not affected by this change.
This PR moves int numLinesInBuffer(Compression comp) into ImfCompressor.h and makes it part of the API. It previously was in an anonymous namespace.
Addresses the following oss-fuzz issues:

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24573
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24857
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25002

Signed-off-by: Peter Hillman<EMAIL_ADDRESS>

Moving the test earlier in the function should also address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25156


specify python 3.6 as supported version instead of all python 3

Correcting the supported versions acc. to README

Pull Request Test Coverage Report for Build 254

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.041%

Totals

Change from base Build 252:
0.0%

Covered Lines:
789

Relevant Lines:
917

💛  - Coveralls


Add support for tasks list

https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/tasks.list.json
Will need to be backported to the 2.x branch if it's backported in ES as well.

merged to 2.x and master as per #2017


chore: Bump to Dart 3 and latest Flutter 3.10.5

Dart 3 is a big release, that introduces many Rust-like features.
Thankfully, all our code was compatible with it, so it was trivial to bump at
this stage.
Some highlights of Dart 3:

sound null-safety,
destructuring,
patterns (better switch and if statements)
records
sealed classes (and other class modifiers)

More info:

https://medium.com/dartlang/announcing-dart-3-53f065a10635
https://codewithandrea.com/articles/whats-new-dart-3-introduction/

bors r+

Cool, thanks for upgrading!


how can i  get class fileds detail info in dart?

I used vm_service 'getAllocationProfile'  API to get ClassHeapSize , and how to get the details of all the objects in each class

I'll follow up on this here as it's a question, not an issue.


Custom zoom level not available

Description
1481 and 1496 reference a customizable zoom level but menu does not show as available.
Screenshots

Version
2.3.2
What browser are you seeing the problem on? What version are you running?
Firefox v130.0
The OS you're using
mac
Steps to reproduce

Turn on overlays.
Zoom in to level 20
Verify overlays do not disappear
Look for zoom select on menu, but it will not be there.

The browser URL at the time you encountered the bug
https://rapideditor.org/edit#map=20.78/39.06290/-108.47785&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&overlays=osm-gps,US-TIGER-Roads-2020,openrailwaymap-maxspeeds,openrailwaymap-signalling,US_Forest_Service_roads_overlay,US-TIGER-Roads-2021,US-TIGER-Roads-2022,US-TIGER-Roads-2023
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0

re: #1481  #1496
(Please write the issues like this with '#' so Github can link them)
This is not an issue with UI.  It's an issue allowing @emersonveenstra to control what happens to imagery sources when they are zoomed in at higher zooms than they are intended to display at.


Broken Links on Templates page

Links to the command in the CLI Reference are broken.

Looking at the markdown, I think the broken ones are missing a leading /.

fix is live! closing. 🎉

fix is live! closing. 🎉


dotnet is a botnet?

If I was gonna have a botnet installed on my computer, why do I have to get stuck with this star of david shit?


T10 PI format patch

Patch is implemented using the virt-customize command. To validate the patch

ssh storage node
goto /etc/default/grub
mpt3sas.prot_mask=1 parameter will be present against the value GRUB_CMDLINE_LINUX

@zxa13 can you create PR's for master & 13.2 branches as well please.

@zxa13 can you create PR's for master & 13.2 branches as well please.

@gaelrehault I will do that.


Add support for single-threaded fan out and merge in

e.g.
ReactiveSeq.of(1,2,3,4)
           .fanOut(s1->s1.filter(i->i%2==0).map(i->i*2),
                   s2->s2.filter(i->i%2!=0).map(i->i*100))
           .toListX();

Should result in
ListX.of(4,100,8,300))

Should work for all of

Push based reactive Spouts
Pull based synchronous Streams
FutureStreams

Add similar issues for parallelFanOut and fanOutZipIn - both sequential and parallel

Across all 3 Stream types.

Released in 2.0.0-MI3


python37: fix darwin build

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: python37
Partial log (click to expand)
gzipping man pages under /nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/lib  /nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/bin
patching script interpreter paths in /nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0
/nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/bin/python3.7m-config: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/lib/python3.7/config-3.7m-x86_64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0/lib/python3.7/config-3.7m-x86_64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/bn10ggyzlqfs7mjs9p3zjl5wfw0b7qmv-python3-3.7.0...
wrong ELF type

Success on aarch64-linux (full log)
Attempted: python37
Partial log (click to expand)
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/lib  /nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/bin
patching script interpreter paths in /nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0
/nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/lib/python3.7/config-3.7m-aarch64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/lib/python3.7/config-3.7m-aarch64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0/bin/python3.7m-config: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0...
wrong ELF type
/nix/store/6jlbzgrcwp3z2g4a85p2f6jmd5f6ab6p-python3-3.7.0

Success on x86_64-darwin (full log)
Attempted: python37
Partial log (click to expand)
/nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/lib/python3.7/test/test_support.py
post-installation fixup
gzipping man pages under /nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/lib  /nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/bin
patching script interpreter paths in /nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0
/nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/lib/python3.7/config-3.7m-darwin/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/lib/python3.7/config-3.7m-darwin/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/nbvdnj2cq6dbbx1zxd5i1dhm513ppjvr-python3-3.7.0

Success on x86_64-linux (full log)
Attempted: python37
Partial log (click to expand)
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/lib  /nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/bin
patching script interpreter paths in /nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0
/nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/bin/python3.7m-config: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/lib/python3.7/config-3.7m-x86_64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/lib/python3.7/config-3.7m-x86_64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0...
wrong ELF type
/nix/store/vgsvh6hq6049dkmp3si9dk0d739wqg40-python3-3.7.0

Success on aarch64-linux (full log)
Attempted: python37
Partial log (click to expand)
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/lib  /nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/bin
patching script interpreter paths in /nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0
/nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/lib/python3.7/config-3.7m-aarch64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/lib/python3.7/config-3.7m-aarch64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0/bin/python3.7m-config: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0...
wrong ELF type
/nix/store/1lzzq8lz2637c9lck3mcgdrqhwldjhja-python3-3.7.0

Success on x86_64-darwin (full log)
Attempted: python37
Partial log (click to expand)
/nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/lib/python3.7/test/test_support.py
post-installation fixup
gzipping man pages under /nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/lib  /nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/bin
patching script interpreter paths in /nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0
/nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/lib/python3.7/config-3.7m-darwin/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/lib/python3.7/config-3.7m-darwin/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0/lib/python3.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/l72bi3pc8zj04gdavqz1dgg4khafppv2-python3-3.7.0

Thank you!


Update lifecycle hooks snippets

2 new lifecycle hooks were added, componentWill- hooks been deprecated
in React 16.3
refs: https://github.com/facebook/react/releases/tag/v16.3.0
closes https://github.com/xabikos/vscode-react/issues/40

@xabikos done along with some fixes and additions


In Python identity is not the same thing as equality

flake8 testing of https://github.com/apache/beam on Python 3.7.1
$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics
./sdks/python/apache_beam/runners/worker/operations.py:814:8: F632 use ==/!= to compare str, bytes, and int literals
    if windows is 0:
       ^
1     F632 use ==/!= to compare str, bytes, and int literals
1

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

The use of is here was actually intentional, however going through the comparison framework for the literal 0 and tuples should be fast enough.

$ python
>>> raw = 'ra'
>>> raw += 'w'
>>> raw
'raw'
>>> raw == 'raw'
True
>>> raw is 'raw'
False
>>> 0 == 0.0
True
>>> 0 is 0.0
False

Yes, but in CPython 0 is 0 is always true, no matter how the 0 was constructed. Regardless, this change LGTM for cleanliness, assuming tests pass. Thanks.

Run Python PreCommit


Should we delete the "experiments" folder?

It seems like the experiments folder has some duplicated code and experiment results, which doesn't contribute to this repository.

Yes, please delete it. Thanks.

Okay!


19 - Creators have the access to cancel the room.

As a registered user, I can cancel the room if I am the creator and the game hasn't started.
Acceptance Criteria:

The creator of the game is able to cancel the room

Development Tasks

[x] #50

@SyLi9527 can be closed?

@sumsumcity Yes, closed


[ng test] When code-coverage is on, sourcemaps for non spec files show JS content instead of TS

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.2.3
node: 8.1.4
os: darwin x64
@angular/animations: 4.3.1
@angular/common: 4.3.1
@angular/compiler: 4.3.1
@angular/core: 4.3.1
@angular/forms: 4.3.1
@angular/http: 4.3.1
@angular/platform-browser: 4.3.1
@angular/platform-browser-dynamic: 4.3.1
@angular/router: 4.3.1
@angular/cli: 1.2.3
@angular/compiler-cli: 4.3.1
@angular/language-service: 4.3.1

(Also tested on Windows 8.1 with Node 6)
Repro steps.

ng new test-app
cd test-app

Go to app.component.ts, and a constructor that looks like:
  constructor() {
    debugger;
  }

Then run ng test --sourcemap
Switch to Chrome test browser, click "Debug", open the devtools, refresh.
Observe how the breakpoint shows right (you see the class that is AppComponent)

Now, stop the test runner, and re-run the command adding --code-coverage to it.
Like ng test --sourcemap --code-coverage
Again, switch to Chrome test browser, click "Debug", open the devtools, refresh.
Observe how the breakpoint shows differently this time:
(shown in the next section)
The log given by the failure.

In the test browser devtools, we see compiled JavaScript as the content of the TypeScript file, like:

Desired functionality.

I'd like to be able to see the correct content of the files in sourcemaps, that is the TypeScript code, not the JavaScript code. Similar to the first screenshot when not using --code-coverage. I'd like --code-coverage to not cause this to break.
Mention any other details that might be useful.

Note how the filename at the top of the source file tab and the sourcemaps comment at the end of the file content point to the TypeScript file not the JavaScript file!!
There are 2 sourcemaps comments in the file though, and only happening in the file where the result is wrong.

This problem does NOT happen in the spec files!!
I confirmed by adding : AppComponent to one of the tests. It's preserved (plus lambdas etc)

This was working in CLI 1.0.6 (the one that a project I was helping upgrade happened to be upgrading from, signaling the issue, not sure about other versions)

There's one solution I thought might work, and it didn't. Adding it here for the record anyway.
I went to the src/test.ts file, and changed the line
const context = require.context('./', true, /\.spec\.ts$/);

to be this line, which is primarily needed for proper code coverage results:
const context = require.context('./app', true, /\.ts$/);

But it till didn't change the behavior explained in the main issue!!
I thought maybe it was broken because the application file (in the report above it's app.component.ts) was not directly covered by the test.ts line (although it actually was, via import from app.component.spec.ts). But changing the line had no effect on the result.
It might be something to do with how the ng test handles the spec and app tsconfig files maybe. I really don't know.

Retested with CLI v1.3.0-rc.3.
Same results.
ng version output for last test:
@angular/cli: 1.3.0-rc.3
node: 8.1.4
os: darwin x64
@angular/animations: 4.3.2
@angular/common: 4.3.2
@angular/compiler: 4.3.2
@angular/core: 4.3.2
@angular/forms: 4.3.2
@angular/http: 4.3.2
@angular/platform-browser: 4.3.2
@angular/platform-browser-dynamic: 4.3.2
@angular/router: 4.3.2
@angular/cli: 1.3.0-rc.3
@angular/compiler-cli: 4.3.2
@angular/language-service: 4.3.2

Thanks for the report @Meligy, this is unintended and will investigate.

I looked into this a bit today but didn't get very far. As far as I can tell, we're passing in the sourcemaps correctly into istanbul-instrumenter-loader, but the sourcemaps that get back from it refer to transpiled code. Need to look into it further.

I did some more digging around today, and opened an issue at https://github.com/webpack-contrib/istanbul-instrumenter-loader/issues/73.

@Meligy @filipesilva I am also facing the same issue, Couldn't have both source-maps and code-coverage at same time. Any work around to fix this?

The issue does not break the sourcemaps in code coverage output (the HTML files it generates).
For now my team's flow is to run tests without coverage while developing / writing tests, and then before committing their code they run the tests with code coverage and open the code coverage page to check results. If less than 100%, they run the normal tests again and ensure they cover everything missing.

@hansl Thanks, Hans, for picking this up - highly appreciated.

This might be too crazy for just a sourcemaps workaround, but if your tests do not use a lot of Karma and/or specific features, you might try the several Jest schematics available for the CLI, since the broken tool is specific to Karma. But again, this is probably going too far too.

Since this only happens while debugging AND using code coverage, because it is a bug with an upstream dependency and webpack has been silent on it, and because it's been happening for a while, we think the issue is not as high a priority as previously triaged. We are going to take a look at it when webpack updates their loaders.
Thanks.

only happens while debugging AND using code coverage

does this mean it is possible to configure karma to somehow skip "debugging" while running the tests and generating the coverage report via istanbul?
if there is some way to get coverage with correct source maps I would love to know about it.

@escalonn I think what @hansl is saying, is that you'd normally run ng test --sourcemap only for debugging purposes, since this is not the build command, for which you might want to use --sourcemap in prod too sometimes.

I'm having the same issue. I tried adding more reporter options:
      coverageIstanbulReporter: {
        dir: path.join(logDir, 'coverage'),
        reports: ['html', 'lcovonly', 'lcov', 'text-lcov', 'text', 'text-summary'],
        fixWebpackSourcePaths: true
      },

What is interesting is that the line coverage numbers printed to the console are correct, but those produced by lcovonly are wrong. Turning off source maps has no affect, so it seems to be running coverage on the JS files instead
A portion from lcov.info:
FN:6,(anonymous_0)
FN:15,(anonymous_1)
FN:25,(anonymous_2)
FN:28,(anonymous_3)
FN:34,(anonymous_4)
FN:37,(anonymous_5)
FN:40,(anonymous_6)
FN:43,(anonymous_7)
FN:46,(anonymous_8)
FNF:9
FNH:1

The same file output to the console:
FN:4,(anonymous_0)
FN:27,(anonymous_1)
FN:63,(anonymous_2)
FN:55,(anonymous_3)
FN:67,(anonymous_4)
FN:71,(anonymous_5)
FN:75,(anonymous_6)
FN:79,(anonymous_7)
FN:83,(anonymous_8)
FNF:9
FNH:1


Don't convert back and forth between Explosion objects and their unpacked data.

This PR:

Inlines newExplosion() in MixinWorld.triggerExplosion()
Moves the explosion code in MixinWorldServer from triggerExplosion() and newExplosion() to triggerExplosionInternal()
Corrects a few defaults in SpongeExplosionBuilder that badly messed up my testing

Fixes SpongePowered#1367.

Can this be merged?

@liach I found a way to make this work without messing with the PhaseContext class hierarchy. The callers now create a context and pass the explosion to it.

@ryantheleach status?

I know that I said previously that I was going to make a test plugin, but at this stage I have no idea if I did that or not, I've been somewhat MIA over the last few months.
At present anything that's blocked on me should be considered up for fair game until I can find the time to invest back into Sponge.

Updated (after asking @JBYoshi about it).
Note: PluginPhase.State.CUSTOM_EXPLOSION was removed by https://github.com/SpongePowered/SpongeCommon/commit/0e16a5d8ba7678b2c0af56dd4a29e040c65596ab#diff-789d0465f5f0c54bb475b2958e6263d6 so I'm using GeneralPhase.State.EXPLOSION.

@gabizou I'll add it with other performance improvements once I reopen the explosions part of https://github.com/SpongePowered/SpongeCommon/pull/2031

Conflicts fixed and rebased.
A note (In case some plugins complain about this being a breaking change): the default value of shouldBreakBlocks (and shouldDamageEntities) is an implementation detail, it's not mentioned in the API. If you're creating an explosion with the ExplosionBuilder without explicitly setting those flags, then it's your fault for relying on the default value.


How do I use this on linux?

I'm on ubuntu 22.04, so, I'm not quite a rust user, but I did install couple of needed dependencies. However, on the last 3 steps, it failed to compile.
error:
error[E0432]: unresolved import `std::lazy`
 --> src/cli/../shared/ustring.rs:7:10
  |
7 | use std::lazy::SyncLazy;
  |          ^^^^ could not find `lazy` in `std`

error[E0308]: mismatched types
   --> src/cli/main.rs:328:13
    |
327 |   ...rogressBar::new(0).with_style(
    |                         ---------- arguments to this method are incorrect
328 | / ...   ProgressStyle::default_bar()
329 | | ...       .template("{spinner:.green} {elapsed_precise} [{wide_bar:.green}] {pos}/{len}\n{spinner:.green} {wide_msg}...
    | |______________________________________________________________________________________________________________________^ expected struct `ProgressStyle`, found enum `Result`
    |
    = note: expected struct `ProgressStyle`
                 found enum `Result<ProgressStyle, TemplateError>`
note: associated function defined here
   --> /home/pume/.cargo/registry/src/github.com-1ecc6299db9ec823/indicatif-0.17.2/src/progress_bar.rs:67:12
    |
67  |     pub fn with_style(self, style: ProgressStyle) -> ProgressBar {
    |            ^^^^^^^^^^

error[E0308]: mismatched types
   --> src/cli/main.rs:333:37
    |
333 |     bar_progress.enable_steady_tick(12);
    |                  ------------------ ^^ expected struct `Duration`, found integer
    |                  |
    |                  arguments to this method are incorrect
    |
note: associated function defined here
   --> /home/pume/.cargo/registry/src/github.com-1ecc6299db9ec823/indicatif-0.17.2/src/progress_bar.rs:152:12
    |
152 |     pub fn enable_steady_tick(&self, interval: Duration) {
    |            ^^^^^^^^^^^^^^^^^^

Some errors have detailed explanations: E0308, E0432.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `wordstat` due to 3 previous errors
error: failed to compile `wordstat v0.2.0 (https://github.com/Systemcluster/wordstat.git#e696fa7f)`, intermediate artifacts can be found at `/tmp/cargo-installU01WJx`

I'm.... not sure what to do next.

Thanks for opening this! The compilation issue is caused by me using unstable language features that have since been changed in newer versions. I'll update the code and remove the use of those features.

I've updated the code and it should compile with recent Rust nightly versions now. Completely removing the use of nightly features takes a bit more work, but this should be fine for a while.


Add Naker Tools

Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[x] I added the appropriate labels: free, open-source or mac.
[x] I put the tool only to one category.
[x] I followed Contribution Guidelines.

hey @valentinbdv
Maybe your tools will better sure 3D category?

Hello Lisa. I also hesitate but the only 3D category you have is "3D Modeling Software" which is very specific. The tools I push would better fit in "Web Interactive Tools" or "3D Web Design Tools". Not sure what the best wording would be for your list. ;)

In that category we could put other tools like these:
https://playcanvas.com/
http://www.layabox.com/
https://scapic.com/
Tell me what you think ;)

Hello Lisa, how are you today? ;)
I just want to close that pull request so tell me what should I do?
If you prefer I can put the tools in the "3D Modeling Software".
Bye

hey @valentinbdv it was hard to choose the category as it's a bit 3D, a bit content creation and a bit web design. I decided to add your tools to animation. Hope it works

Ok no problem! You better know what is the right place to put it. Plus we are sometimes compare to aftereffect but for the web! ;)


Re-init ServiceRegistry on every Initialize() call

Without this, the sequence of calls
xacc::Initialize()
xacc::Finalize()
xacc::Initialize()

will cause CppMicroservices to throw the following:
terminate called after throwing an instance of 'std::runtime_error'
  what():  The bundle context is no longer valid

Testing
I ran ctest and did some end-to-end testing with QIR-EE.

Thanks @ausbin. This seems such an edge case. I'm curious when one would ever use/need the following.
xacc::Initialize()
xacc::Finalize()
xacc::Initialize()

Good point @danclaudino. Is that sequence of calls even supported? I assumed so, but if you are only supposed to call xacc::Initialize() and xacc::Finalize() once per process (understandable), then we should fix QIR-EE instead. Because right now, XaccQuantum in QIR-EE calls xacc::Initialize() and xacc::Finalize() each time it is constructed and destructed (respectively)
If this is meant to be supported, I will investigate the Python segfault further (I looked a bit and some Python code is indeed touching the ServiceRegistry before xacc::Initialize()). Otherwise, I will close this PR.

This seems such an edge case. I'm curious when one would ever use/need the following.
xacc::Initialize()
xacc::Finalize()
xacc::Initialize()

@danclaudino Is the expectation that you only execute one quantum circuit for every use of XACC? Or that you're supposed to assume that you're the only library in a larger toolchain that uses XACC (and thus only your library will ever call init/finalize)? If Finalize doesn't finalize, why bother having it at all? Maybe it would be better to just "initialize" the global variables once and then have an if (initialized) return; in the initialize function to prevent subsequent errors.
The usual reason to have multiple initialize/finalize is to reset states for reproducibility, unit testing, etc.

Good point @danclaudino. Is that sequence of calls even supported?
I assumed so, but if you are only supposed to call xacc::Initialize() and xacc::Finalize() once per process (understandable), then we should fix QIR-EE instead. Because right now, XaccQuantum in QIR-EE calls xacc::Initialize() and xacc::Finalize() each time it is constructed and destructed (respectively)
If this is meant to be supported, I will investigate the Python segfault further (I looked a bit and some Python code is indeed touching the ServiceRegistry before xacc::Initialize()). Otherwise, I will close this PR.

This has probably flown under the radar since it's hard to imagine a case where the sequence you pointed out would come up when using XACC, thus it being an edge case. But I think there shouldn't be any fundamental reason for it not to be supported.

@danclaudino Is the expectation that you only execute one quantum circuit for every use of XACC?

No. In principle you can execute as many circuits as you want.

Or that you're supposed to assume that you're the only library in a larger toolchain that uses XACC (and thus only your library will ever call init/finalize)?

This is probably the case. I'm not familiar with the inner workings of xacc::Initialize() and xacc::Finalize(), but it seems they will likely need some rethinking in order to work in the intended way.


Show brackets in gutter

Ideally, there should be an option to show the opening and closing brackets in the gutter (with the same color).

There is now an option to show brackets in the gutter and in the ruler.
There is an issue with the gutter that it will block breakpoints


docs: images are broken

resolved by https://github.com/ory-am/hydra/commit/3c3b93e6886a473c9472fdb61c584acda3d758aa


Update card styling on each page

Do all work for this issue in a branch called issue-126
Update the styling and format of how each card is rendered to reflect the enhancements made in #101.

Updated all pages to reflect the an updated Rainbow Card format and styling.
Pages now support mouseover and select functionalities as well, such as being able to click a "Wishlist" button on the public catalog page, or Selecting your own cards (for future features).


logo and keywords

In your documents you mention that a compliant Promises/A+ library may display a logo and use a keyword on NPM.
And what about libraries that feature use of Promises/A+, i.e. libraries that expose its interface via any of the existing Promises/A+ implementations?
Any similar provision for such libraries? May/should they use the same keyword on NPM? May/should they use the same logo?

Hey @vitaly-t.  Personally, I think it's perfectly fine, and even encouraged, to add the logo and keywords to a README or documentation.  As long as its clear, from the README for example, that the project accepts/returns promises, rather than being a Promises/A+ implementation.
Here's an example.  In another project, I added a section to list specs it interoperates with.  It also lists keywords in its package.json and bower.json.

Thanks. I wasn't asking for a hypothetical reason, I did a library that can switch between various Promises/A+ implementations: https://github.com/vitaly-t/pg-promise
And I made a join logo of the two technologies being featured. I hope this doesn't violate any policy around use of Promises/A+ logo :)
Thank you for your answer.


Getting error "Cannot modify header information - headers already sent by" when trying to download a DB in chunks

Laravel: 8.83.25 PHP: 3.4 CSV: 9.8
My database is too large to download without getting memory errors from NGINX/PHP, so I'm trying to break up the CSV into chunks of 10,000 records, but I'm getting an error from $csv->output($filename);
[2023-01-26 17:14:13] local.ERROR: Cannot modify header information - headers already sent by (output started at C:\Apache24\htdocs\cannabis\vendor\league\csv\src\AbstractCsv.php:326) {"userId":1,"exception":"[object] (ErrorException(code: 0): Cannot modify header information - headers already sent by (output started at C:\Apache24\htdocs\cannabis\vendor\league\csv\src\AbstractCsv.php:326) at C:\Apache24\htdocs\cannabis\vendor\league\csv\src\AbstractCsv.php:358)
In reading StackOverflow  they say "Functions that send/modify HTTP headers must be invoked before any output is made. Otherwise the call fails"
How do I save queries into multiple CSVs?  Here is my current function:
public function export_weightrecords(){
	$count = weightrecords::count();

	for($i = 0; $i < $count; $i = $i + 10000){

		$csv = Writer::createFromFileObject(new \SplTempFileObject);

		$query = weightrecords::query()->skip($i)->take(1000);
		$query = $query->orderBy('id');
		$records = $query->get();

		if(isset($records[0])){
			$csv[$j]->insertOne(array_keys($records[0]->getAttributes()));
			foreach ($records as $record) {
				$csv->insertOne($record->toArray());
			}
			$csv->insertOne(['']);
		}

		$filename = "export_weightrecords_" . $i . date('_Y_m_d_H_i_s') . ".csv";
		$csv->output($filename);
	}
}

@scottsuhy thanks for using the library.
As explain in the documentation when using the package in the context of a framework you should try to use the framework way of generating streaming response and not use the package way because then you indeed end up with the error message you have.
I hope the example in the documentation will give you some hints into how to solve your current issue.


Request: Indication finished discrete command

Currently, when working with discrete actions, the user is required to monitor and assess if the action is done or not.
I have already encountered several times where this doesn't work as intended. I think a better solution is to allow the sendCommand to 'hang' until the action is finished (which Malmo knows better than any user conditionals).
Another option is to add a parameter to the world_state such as world_state.is_agent_done which reports if the current action has finished or not.
Should never hang / world_state.is_agent_done should be true for continuous actions.

Relevant issues: https://github.com/Microsoft/malmo/issues/437, https://github.com/Microsoft/malmo/issues/405, maybe more
Overarching issue / task: https://github.com/Microsoft/malmo/issues/301
It seems to currently be the case that the best way to do this is to either:

shortly wait some amount of time (e.g. ~5ms) and hope the action has finished by then, or:
code a check to see if the agent now shows the result you expected to happen. For only movement commands, this is doable, But for commands that include breaking / attacking / picking up / placing items, I am not sure if this can be easily and reliably implemented for most use cases.

Waiting does work (usually). Issue is that when CPU utilization spikes - the emulator takes a while longer to process. And it requires a lot of manual play to find the optimal wait times per setup.
I'll take a look at robust_frames and see if it can work.. though I still think the optimal solution is in the source code itself.

I have tried using robust_frames myself as well, but it feels very hacky and unreliable still, especially with checking if an action could succeed or not, when used with absolute actions.


[No QA] Remove Permissions.canUseFreePlan

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/8965
Tests

N/A

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

I added another reviewer with PullerBear since Marc is OOO. He is a code owner on Navigation.js, but I only edited a comment so I don't think we need to wait for his review.

Thanks for the review @tgolen. How does it look now?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Can we raise a new PR for this one -
https://github.com/Expensify/App/blob/2fd3df03a6f40e5dedbae5be60793fc5cf67fb07/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L148-L152
It's crashing the app in staging, when you try to connect bank account.
cc: @neil-marcellini, @tgolen

Oh no! Thanks for catching that @thesahindia. Could you please create an issue with test steps to reproduce the crash?

Ah ok I understand now, that must have snuck in when I was resolving merge conflicts. I'll throw up a PR real quick to fix.

🚀 Deployed to staging by @tgolen in version: 1.1.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Ensure client-side Tina code only runs on the browser

Ensure client-side Tina code only runs on the browser. Without this check, we'd see a server/client mismatch like:
warning.js:33 Warning: Expected server HTML to contain a matching <div> in <body>.

cc @logan-anderson I know you've been around this area of the code a lot, do you see any potential issues in blocking this initially?

Pulling down and switching to this branch, I'm still seeing a... variant of this error?
Warning: Expected server HTML to contain a matching <div> in <div>.
div
Header@webpack-internal:///./components/header.tsx:29:14
div
Theme@webpack-internal:///./components/theme.tsx:46:14
Layout@webpack-internal:///./components/layout.tsx:27:22
TinaEditProviderInner@webpack-internal:///../../.yarn/$$virtual/tinacms-virtual-0682143396/1/packages/tinacms/dist/edit-state.js:103:33
EditProvider@webpack-internal:///../../.yarn/$$virtual/@tinacms-sharedctx-virtual-bba2bd89af/1/packages/@tinacms/sharedctx/dist/index.js:36:24
TinaEditProvider@webpack-internal:///../../.yarn/$$virtual/tinacms-virtual-0682143396/1/packages/tinacms/dist/edit-state.js:40:9
App@webpack-internal:///./pages/_app.tsx:49:19
ErrorBoundary@webpack-internal:///../../.yarn/$$virtual/@next-react-dev-overlay-virtual-0e8e156dfa/0/cache/@next-react-dev-overlay-npm-10.0.5-ca540f1b0f-6872e5bc89.zip/node_modules/@next/react-dev-overlay/lib/internal/ErrorBoundary.js:23:47
ReactDevOverlay@webpack-internal:///../../.yarn/$$virtual/@next-react-dev-overlay-virtual-0e8e156dfa/0/cache/@next-react-dev-overlay-npm-10.0.5-ca540f1b0f-6872e5bc89.zip/node_modules/@next/react-dev-overlay/lib/internal/ReactDevOverlay.js:73:20
Container@webpack-internal:///../../.yarn/$$virtual/next-virtual-c2a42f721a/0/cache/next-npm-10.0.5-716eec629b-fa8a4c872b.zip/node_modules/next/dist/client/index.js:151:20
AppContainer@webpack-internal:///../../.yarn/$$virtual/next-virtual-c2a42f721a/0/cache/next-npm-10.0.5-716eec629b-fa8a4c872b.zip/node_modules/next/dist/client/index.js:642:18
Root@webpack-internal:///../../.yarn/$$virtual/next-virtual-c2a42f721a/0/cache/next-npm-10.0.5-716eec629b-fa8a4c872b.zip/node_modules/next/dist/client/index.js:771:18

Is this the same error?  The language is the same, but I don't know if the cause is.

@Enigmatical it's not clear to me whether this is always due to Tina code or could sometimes come from userland, I wasn't able to see that issue you're seeing but might just be another one to fix somewhere.


added tab_fact taskcard

Added a new taskcard for Table Fact Checking using TabFact public dataset
The dataset is loaded from ibm org HF hub(https://huggingface.co/datasets/ibm/tab_fact) where a custom dataset loading script is added to load dataset in appropriate format.

Done


whitespace is meaningful

This example document contains two "include" instances; the first instance includes the referenced file as expected. The second instance adds the {.yaml include = "stuff.yml"} text in the document.
---
title: includes
filters:
  - include-code-files
---

```{.yaml include="stuff.yml"}
```

```{.yaml include = "stuff.yml"}
```

I ended up with whitespace surrounding the equals sign because I was trying to adapt some of the knitr embed/verbatim examples; those use whitespace.
Renders as:

Using Quarto 1.2.335.

The syntax relies on Pandoc's syntax and no-space is required for the raw code block with class and attributes to be valid.
I don't think we can do much on the extension itself about that because the extension will do nothing -  it is done in Lua and it would not get applied because AST would not contained a CodeBlock with include attribute which is what it checks.
Probably this would be improvment to do like YAML syntax linter in our editors to help find those spaces. Note that visual editor does not also see the second as a code block and would not format it as you would expect.
Do you have suggestion in mind on how to improve this ?

I don't have a suggestion, no. Feel free to wontfix this if it's a restriction imposed by Pandoc.
As I mentioned, I had started with the knitr embed engine and, after encountering problems there, fell over to this option. I missed the fact that we went from meaningless-to-meaningful whitespace.
The story might change again once "include" works natively in Quarto, so again, no big deal.


copy/en/get-started: make type/value distinction

This change tries to make the distinction between a type and a value more explicit. Indeed, in the TS world, something such as "a string" could be well regarded as a type, but it is more naturally known as a value. Given that this piece of information is in a learners' section, I believe that the change is worth making as it could be confusing.

I'm not sure that I like this change; "a string" is certainly a type (a literal type). I'm not sure that we want to ambiguate type space by including values.

Okay. That's fine.

@jakebailey would you like me to close this PR or will you?

I'll click it; thanks for sending the PR, though!


Merge to live

Added CONTRIBUTING.md
Updated .NET REST tutorial to account for changes to the MSAL library
Updated Node.js REST tutorial to correctly show how to initialize simple-oauth2 library
Updated PHP tutorial to correct typos/omissions in code snippets

@jasonjoh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

CONTRIBUTING.md
:white_check_mark:Succeeded

docs/rest/dotnet-tutorial.md
:white_check_mark:Succeeded

docs/rest/node-tutorial.md
:white_check_mark:Succeeded

docs/rest/php-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update to 1.20.2 Please

General Info

[ ] I would like to propose new content
[X] I would like to propose changes
[ ] I would like to propose another thing

Suggestion Description
/

Thanks, so fast!!!!!


GNU GPL (Free for Commercial Use)

Can I use GNU GPL (Free for Commercial Use) font??? Or only OFL is recommended

I can only reference what is in the official rules:
11. INTELLECTUAL PROPERTY RIGHTS:  By submitting a Submission in this Contest, the entrant warrants and represents that the Submission, including the programming and related material, is open source and is released subject to an appropriate open source license (for code, BSD aka University of California license, MIT license or Apache 2.0 license are recommended; for assets, CC BY 4.0 license or Apache 2.0 license are recommended; for fonts, OFL license is recommended), and not subject to the proprietary rights of any person or entity.


1.0.0 release

Ok, I think we're about ready to go with the 1.0.0 release! I'm going to look for everyone with write access to approve this PR.
I updated the readme in a few ways:

Removed warnings about not quite being 1.0.0
Made it a bit more clear the links to the repo are the 'dev' version, and the version on the website is the one to use.
Put links into the two validators that do actual data checks (happy to add more here too).

One question I had is if we should remove the validator that's in this repo to not be here. I've leaned towards that as it's cleaner, but I don't feel quite qualified to put it in its own new repo. If someone (@kylebarron? @alasarr?) would be up to move it that'd be ideal - I can make a spot for it in the https://github.com/geoparquet org. I also could just remove it from this repo and we can add it in later if others are comfortable with that. I'm also fine to just leave it here - it's not referenced on the front page. But we probably should clarify that it just tests the metadata.
I didn't yet 'tag' the release, as per instructions on https://github.com/opengeospatial/geoparquet/wiki/Release-Process but can when we're ready.
The other 'nice to have' thing for release would be to publish the 'parquet geospatial compatibility' doc (https://github.com/opengeospatial/geoparquet/blob/main/format-specs/compatible-parquet.md) on the website. But I'm ok if we just figure that out later.

In this branch, we should update geoparquet_validator/schema.json
from
  "properties": {
    "version": {
      "type": "string",
      "const": "1.0.0-dev"
    },

to
  "properties": {
    "version": {
      "type": "string",
      "const": "1.0.0"
    },

Let me know if you want me to create a PR over this branch.

In this branch, we should update geoparquet_validator/schema.json

Ah, sorry for missing it. But I think I'm just going to remove the validator as discussed above.

This makes sense to me. I think it's fine to move to a new repo in the geoparquet org, and it can be done at any time (if people need it, they can clone an older tag of this repo).

Just removed the validator. Will try to add it elsewhere soon.

Hrm - the downside of remove the validator is that the build can then no longer validate the examples... Guess the ideal is to put in another package that the CI would just download and use?

The release looks fine.
I'm a bit out of the loop and just out of curiosity: The repo is hosted under the OGC, doesn't an OGC release need to follow some kind of OGC procedure for a release? Or are we independant to release whenever we want?

Hrm - the downside of remove the validator is that the build can then no longer validate the examples

Correct, I would rather keep the utility until there is an external package to replace in CI. That package would depend on the format-specs/schema.json file present in this repo, so it would require either a submodule, a link or duplicating the JSON for a specific version.

I don't have a strong preference on where the validator should live. Maybe it should be in its own repo that can be published to PyPI as something like geoparquet_validator?

@cholmes At some point, when the geoparquet validator is ready, I would like to explore integrating it into the OGC Compliance Program. So an option is to create the validator's repository in the opengeospatial GitHub organization. Please let me know if you would like the repository created in the opengeospatial GitHub organization.

I'm a bit out of the loop and just out of curiosity: The repo is hosted under the OGC, doesn't an OGC release need to follow some kind of OGC procedure for a release? Or are we independant to release whenever we want?

Afaik the ogc repos are independent of their overall process. The official standardization process isn't in github at all, it's submitted documents and voting.

Hrm - the downside of remove the validator is that the build can then no longer validate the examples
Correct, I would rather keep the utility until there is an external package to replace in CI. That package would depend on the format-specs/schema.json file present in this repo, so it would require either a submodule, a link or duplicating the JSON for a specific version.

So I just went ahead and removed the validation job. My reasoning is that I think we should move away from having examples in the spec repo, and we won't be changing the spec that much. But I'm fine for pushback that we should put it in its own package and get it all hooked up to CI - but I'd like that pushback to be accompanied by a commitment to do the work. From my perspective we have good external validation tools. The big reason to have this working well in CI is to ensure if we're doing extensive work on the spec then the examples are all up to date, but I see that as just necessary before we start any major work.

@cholmes At some point, when the geoparquet validator is ready, I would like to explore integrating it into the OGC Compliance Program. So an option is to create the validator's repository in the opengeospatial GitHub organization. Please let me know if you would like the repository created in the opengeospatial GitHub organization.

So we have 2 validators that are quite 'ready' - gpq and the gdal script. This validator never actually validated the data, just the metadata. So I'd start with one of those for the compliance program. I think it makes less sense in the OGC github as there's just so much there - prefer it to be 'grouped' with other geoparquet tools.

Thanks @cholmes . We'll review the gpq and gdal script.

Thanks for putting this together, @cholmes.  The changes look good to me.

Amazing to see this is finally out! It has been an amazing ride!
I agree with the idea of moving the validator outside of the repo and publish a geoparquet_validator package at PyPI.

Amazing to see this is finally out! It has been an amazing ride!
I agree with the idea of moving the validator outside of the repo and publish a geoparquet_validator package at PyPI.

Thank you @cholmes for organizing this. It looks good to me. I hope this is the start of a great and widely use standard. Thanks all for the work.
And can’t wait to start looking at 1.1 😉


Signed Register Functions

git clone --depth=50 https://github.com/lunixbochs/usercorn.git usercorn
cd usercorn
git fetch origin +refs/pull/311/merge
git checkout -f FETCH_HEAD
make deps
make
$ ./usercorn run -repl bins/x86_64.darwin.macho
0x100002426> rax = -1
0x100002426> rax
0xffffffffffffffff
0x100002426> rax = 0xffffffffffffffff
could not restore rax: bad type: NaN

This occurs on all architectures that I have tested and also occurs using u.reg_write.

I added int64 types to luaish but the parser probably needs to be modified to autopromote large numbers.

Oh! parseNumber just needs to try parsing unsigned as well.

Fixed in https://github.com/lunixbochs/luaish/commit/50b0cd6cedf421a38f7944cf836cebcfaaa22609:
~/projects/luaish] ./glua
GopherLua 0.1 Copyright (C) 2015 Yusuke Inuzuka
> rax = 0xffffffffffffffff
> print(rax)
-1
> rax = 0.1
> print(rax)
0.1
> rax = 0xfffffffffffffff
> print(rax)
1152921504606846975
>

Run make get to update the luaish dependency.

Thanks for the quick turn around! The only slightly surprising behavior that I've noticed is writing a NaN number with u.reg_write, but I think it might be unrelated.
0x0> x0
0
0x0> u.reg_write(arm64.x0, 0xfffffffffffffffff)
0x0> x0
0x8000000000000000

Huh, what happens if you set a register to like 1.5? Maybe floats shouldn’t be allowed there.

0x0> x0 = 1.5
could not restore x0: bad type: 1.5
0x0> u.reg_write(arm64.x0, 1.999999)
0x0> x0
1
0x0> u.reg_write(arm64.x0, -0.999999)
0x0> x0
0
0x0> u.reg_write(arm64.x0, -1.999999)
0x0> x0
0xffffffffffffffff
0x0> u.reg_write(arm64.x0, -5.999999)
0x0> x0
0xfffffffffffffffb

seems to more or less make sense how it handles floats


Can't connect to PostgreSQL 14 with SSL

I'm using Erlang OTP-24.3.3  and PostgreSQL 12 with SSL authentication successfully.
I can't connect to a new database server running PostgreSQL 14.
I don't see any error in the database log file. On the client I only see the error {error,none_available} when trying to use pgo:query/2.
I'm using self signed ssl cert:
[
 {pgo, [{pools, [{default, #{pool_size => 5,
                          host => "<db-ip>",
                          database => "mydb",
                          user => "myuser",
                          password => "mypassword",
                          ssl => true,
                          ssl_options => [{cacertfile, "/path/to/ca.crt"},
                                                   {certfile,   "/path/to/db.crt"},
                                                   {keyfile,    "/path/to/db.key"},
                                                   {verify,     verify_peer},
                                                   {server_name_indication, "db.myserver.com"}]
                            }
  }]}]}
].

postgresql.conf
ssl = on
ssl_ca_file = '/path/to/ca.crt'
ssl_cert_file = '/path/to/db.crt'
ssl_key_file = '/path/to/db.key'

and:
pg_hba.conf
hostssl all all <IP_ADDRESS>/0 md5 clientcert=verify-ca

I've also tried to change password_encryption to md5 in postgresql.conf because of the missing scram support in pgo:
password_encryption = md5

Any idea what's missing?

Is there an error logged by the connection pool about the SSL issue?
(scram support is in the works)

I don't see an error in the log. Anything I need to turn on?

Once the password is encrypted with scram-sha-256 changing password_encryption = md5 will have no effect. I'll try setting the password after changing password_encryption.
https://www.postgresql.org/docs/current/auth-password.html

The availability of the different password-based authentication methods depends on how a user's password on the server is encrypted (or hashed, more accurately). This is controlled by the configuration parameter password_encryption at the time the password is set.

So you mean it is still trying to use scram and that is the issue?
And you are right, looks like there isn't proper logging. I can probably get that added before finishing scram support.

I'll be able to verify it later but yes that's what I think. In postgres 14 I need to first set password_encryption to md5 and only then set the user password.

This works:

Set password_encryption = md5 in postgresql.conf.
Restart postgresql service.
Create a user with a password.
Connect with pgo.

scarm support will make it work by default. Thank you for working on it.


SpotX Old theme doesn't work

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
Bangladesh
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: Spotify for Windows <IP_ADDRESS>3.g85d9593d
- Windows: 11 22H2
- PowerShell: 5.1.22621.963

📝 Description

Download and run Install_Old_theme.bat or remove new_theme parameter from installer
Spotify still runs on the new theme

The old theme spotx installation still installs the new theme instead of the old theme. Please fix it
📸 Screenshots

perform a clean install exactly as described in the FAQ

perform a clean install exactly as described in the FAQ

I did but it didn't work

Yes, indeed, the problem exists. Spotify has started to remotely enable a new theme everywhere. While I am searching for a new way to force the old theme to return, you can use a temporary solution:

use this instruction to get into Remote Config
through the search you find enableYLXSidebar and set it to false

fixed
but obviously with each new update the old theme will be minimized by the Spotfiy developers, in such cases it will be possible to return to the old theme only by rolling back the client


Track and publish code coverage

Currently the tests run interactively or under Tox measure code coverage. The tests run on Travis do not. It would be nice to make the Travis tests also measure code coverage, so this can be tracked over time, and possibly publicized.
A popular service for doing this is https://coveralls.io/. Follow on to #530

there's a new COVERALLS_REPO_TOKEN secret variable set in Travis, looks like this needs might need https://docs.coveralls.io/python

Well it kinda works :) https://coveralls.io/github/dw/mitogen
As usual, looks like it requires fiddling to get working with 2.6, going to set this down for the time being, but feel free to take over

Nice. I'll poke it a bit, but be aware I don't have Python 2.6 tests working on my laptop either.

One option is we just skip it except for 2.7 and one 3.x (I think we only have one right now anyway)


⚠ Bofrost.nl has degraded performance

In 2ed76e1, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 877 ms

Resolved: Bofrost.nl performance has improved in 26cc851.


Formatting of dates in sequence ids

Hi Art. Had difficulty calling the get.dates function.  Can be problematic especially if there are multiple underscores "_" in the sequence ids, and if date format is not properly specified. This needs to be emphasized in the README file.

Hi @ekankaka - I'm so sorry it took me this long to get to addressing these issues!  I will start working on them now


Carousel: Adds 'slick' library

Summary

Adds slick carousel library for non-AMP version of Carousel view type
Removes amp-runtime and amp-carousel scripts that were being enqueued previously.
Base branch: rt/gutenberg-blocks

Relevant Technical Choices

To-do

Though I am initializing slick objects for all carousels present on a page, there seems to be some conflict when we have multiple carousels on a page. Not prioritizing fixing this at the moment as we may swap out this library with other based on inputs from other teams.

User-facing changes

Testing Instructions

Can possibly close
#116

Closing this PR as we won't be using Slick slider, given it's external dependency on jQuery.


Fix #12810 - Missing docs for ingress setup on minikube

#12810
Fix One - Removed .md from the URL
Fix Two - the YAML formatting is correctly shown. here are the screenshots before and after the changes.
Before -

After fix -

/assign @steveperry-53

@kbhawkey Thank you so much for the review! I will update the PR right away.

@kbhawkey Addressed all the issues!

@daminisatya Could I please have you fix the merge conflicts, otherwise I think this is ready to go!

@zparnold This has been fixed by this PR. https://github.com/kubernetes/website/pull/12720


Open and save remote notebook files without using VS code Remote SSH

Description
Hi, I'm using VSCode to write ipynb files but can only open and save them locally.
I wish VSCode can access and save remote files by remote jupyter server, as Jupyter Notebook in browser can do.
I've read the docs for remote SSH and remote Docker extension, but that requires remote VSCode installed and is inconvenient.
Your Jupyter and/or Python environment

Jupyter server running: Remote, in Docker image tensorflow/tensorflow:latest-py3-jupyter
Extension version: 2019.10.41019
VS Code version: 1.39.2
Python version: Python 3.7.0 64-bit in host, Python 3.6.8 64-bit in Docker container
OS: Windows 10 Pro 1903 x64 18362.418

Hi I am facing a similar problem. My team is using a remote JupyterHub without SSH connection. We can set up the remote Jupyter configuration and run notebooks with server kernels. However, we cannot manage the JupyterHub file system within VS code, not can we use server kernels to run a whole repository locally. Is it possible to

make remote file management on Jupyter system possible, without SSH connection
Or
make local scripts able to communicate to each other, rather than to the server files

Thanks

so there's no plan to support this currently?

We're looking into adding support for remote vscode  without ssh in  here https://github.com/microsoft/vscode-jupyter/issues/254
Please feel free to upvote/add comments there.


Load Balancer deletion not working in 1.0.0.rc.1

  * load_balancer[skylab-app] action destroy

    ================================================================================
    Error executing action `destroy` on resource 'load_balancer[skylab-app]'
    ================================================================================

    NoMethodError
    -------------
    undefined method `destroy_load_balancer' for nil:NilClass

    Resource Declaration:
    ---------------------
    # In /Users/djimenez/Development/metal/recipes/destroy_all.rb

      6: load_balancer 'skylab-app' do
      7:   action :destroy
      8: end
      9:

    Compiled Resource:
    ------------------
    # Declared in /Users/djimenez/Development/metal/recipes/destroy_all.rb:6:in `from_file'

    load_balancer("skylab-app") do
      action [:destroy]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      chef_server {:chef_server_url=>"http://localhost:8889", :options=>{:client_name=>"calculon.center.foreflight.com", :signing_key_filename=>nil}}
      declared_type :load_balancer
      cookbook_name "@recipe_files"
      recipe_name "/Users/djimenez/Development/metal/recipes/destroy_all.rb"
    end

Seems like deleting the data bag and recreating it fixed the deletion problem.


Refactor tests

@NoelDavies this is an example (draft) PR that I promised in #27, if you think this works I'll refactor the remaining abstract tests.