[BesTLA] Improve quantization accuracy of int4 and int3

Type of Change
Get higher quantization accuracy of BesTLA's quantization packweight API.

Introduce auto-fullrange for NBits quantization
Add int3 rounding conversion

Text generation comparison ( weight_dtype=int3, group_size=128)
This PR:
Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun. And every day that same little girl would put on her best dress and pear
model_print_timings:        load time =    73.59 ms
model_print_timings:      sample time =     8.07 ms /    16 runs   (    0.50 ms per token)
model_print_timings: prompt eval time =    73.56 ms /    34 tokens (    2.16 ms per token)
model_print_timings:        eval time =   285.11 ms /    15 runs   (   19.01 ms per token)
model_print_timings:       total time =   370.79 ms
========== eval time log of each prediction ==========
prediction   0, time: 73.56ms
prediction   1, time: 19.65ms
prediction   2, time: 19.07ms
prediction   3, time: 18.98ms
prediction   4, time: 19.01ms
prediction   5, time: 19.08ms
Main:
Once upon a time, there existed a little girl, who liked to have adventures. She wanted to go to places and meet new people, and have fun. Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија Хронологија
model_print_timings:        load time =    73.01 ms
model_print_timings:      sample time =     7.62 ms /    16 runs   (    0.48 ms per token)
model_print_timings: prompt eval time =    72.98 ms /    34 tokens (    2.15 ms per token)
model_print_timings:        eval time =   289.00 ms /    15 runs   (   19.27 ms per token)
model_print_timings:       total time =   373.55 ms
========== eval time log of each prediction ==========
prediction   0, time: 72.98ms
prediction   1, time: 19.92ms
prediction   2, time: 19.21ms
prediction   3, time: 19.20ms
prediction   4, time: 19.23ms
prediction   5, time: 19.45ms

@kevinintel @hshen14  INT3 RTN quantization can generate reasonable texts now. I added 'int3' to the quantization weight_dtype options in this PR.


swiftformat: disable comment line length warnings

@ktprograms Please fix the merge conflict so that we can get it merged. Thanks.

Done. Sometimes I really don't know why Git can't figure it out itself 😆


Add composite error

Coverage increased (+0.07%) to 91.974% when pulling 24c8fc4e30eb50d267534a86debf7b905a539572 on aggregate-errors-with-timestamps into 97cbd4c87acfba119c0394047bb4cf59a766c9ba on master.


Unable to Load related Entities/Documents Successfully

This seems like a simple problem but I have been having a challenge loading a document via the entity with related document with Marten documentDB on postgres for the past 2 days. I'm also using the latest release of the library (7.26.0). Please patiently go through my work so far:
KycVerificationStep.cs
public class KycVerificationStep : BaseEntity
{
public Guid Id { get; set; }
public string Code { get; private set; }
public string Name { get; set; }
public string Description { get; private set; }
public string Icon { get; private set; }
public int Order { get; private set; }
public DateTimeOffset DateCreated { get; private set; }
public DateTimeOffset? DateUpdated { get; private set; }
private KycVerificationStep() { }

private KycVerificationStep(
    string name,
    string description,
    string icon,
    int order,
    IKycVerificationStepDomainService domainService)
{
    CheckRule(new KycStepMustBeUniqueRule(domainService, name));
    Name = name;
    Description = description;
    Icon = icon;
    Order = order;
    DateCreated = SystemClock.Now;
    Code = $"Step {Order}";

    AddDomainEvent(new KycVerificationStepCreatedDomainEvent(Id));
}

public static KycVerificationStep Create(
    string name,
    string description,
    string icon,
    int order,
    IKycVerificationStepDomainService domainService)
{
    return new KycVerificationStep(name, description, icon, order, domainService);
}

// shortened for brevity

}
MemberKycVerificationStep.cs
public class MemberKycVerificationStep : BaseEntity
{
    public string Id { get; private set; }

    public Guid KycVerificationStepId { get; private set; }

    public KycVerificationStep KycVerificationStep { get; private set; }

    public Guid MemberId { get; private set; }

    public string Status { get; private set; }

    public DateTimeOffset DateUpdated { get; private set; }

    private MemberKycVerificationStep() { }

    private MemberKycVerificationStep(
        Guid kycVerificationStepId,
        Guid memberId)
    {
        Id = $"{memberId}_{kycVerificationStepId}";
        KycVerificationStepId = kycVerificationStepId;
        MemberId = memberId;
        Status = VerificationStatus.NotStarted.ToString();

        AddDomainEvent(new MemberKycVerificationStepCreatedDomainEvent(MemberId, KycVerificationStepId));
    }

    public static MemberKycVerificationStep Create(
        Guid kycVerificationStepId,
        Guid memberId)
    {
        return new MemberKycVerificationStep(kycVerificationStepId, memberId);
    }
}

Here's how I try to query MemberKycVerificationStep the get the KycVerificationStep By MemberId.
public async Task<Result<IPagedList<MemberKycVerificationStepDto>>> Handle(GetAllVerificationStepsByUserQuery request, CancellationToken cancellationToken)
{
    KycVerificationStep included = null;
    var results = await _querySession
    .Query<MemberKycVerificationStep>()
        .Include<KycVerificationStep>(x => included = x)
            .On(x => x.KycVerificationStepId)
        .Where(x => x.MemberId == request.UserId)
        .Select(x => new MemberKycVerificationStepDto
        {
            KycVerificationStepId = x.KycVerificationStepId,
            Name = included != null ? included.Name : "",
            DateUpdated = x.DateUpdated,
            Status = "x.Status",
            MemberId = x.MemberId
        })
        .ToPagedListAsync(request.PageIndex, request.PageSize, cancellationToken);
    return await Result<IPagedList<MemberKycVerificationStepDto>>.SuccessAsync(results);
}

But I get the following exception which comes from the linq expressions implementation from Marten.

---> System.ArgumentNullException: Value cannot be null. (Parameter 'key')
at System.Collections.Generic.Dictionary2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)    at System.Collections.Generic.Dictionary2.set_Item(TKey key, TValue value)
at Marten.Linq.Parsing.SelectParser.VisitConstant(ConstantExpression node)
at Marten.Linq.Parsing.SelectParser.Visit(Expression node)
at System.Linq.Expressions.ExpressionVisitor.VisitBinary(BinaryExpression node)
at Marten.Linq.Parsing.SelectParser.VisitBinary(BinaryExpression node)
at Marten.Linq.Parsing.SelectParser.Visit(Expression node)
at System.Linq.Expressions.ExpressionVisitor.VisitConditional(ConditionalExpression node)
at Marten.Linq.Parsing.SelectParser.Visit(Expression node)
at Marten.Linq.Parsing.SelectParser.ReadBinding(MemberAssignment binding)
at Marten.Linq.Parsing.SelectParser.VisitMemberInit(MemberInitExpression node)
at Marten.Linq.Parsing.SelectParser.Visit(Expression node)
at Marten.Linq.Parsing.SelectParser..ctor(ISerializer serializer, IQueryableMemberCollection members, Expression expression)
at Marten.Linq.Parsing.SelectorVisitor.ToSelectTransform(Expression selectExpression, ISerializer serializer)
at Marten.Linq.Parsing.SelectorVisitor.VisitMemberInit(MemberInitExpression node)
at Marten.Linq.Parsing.SelectorVisitor.Visit(Expression node)
at Marten.Linq.CollectionUsage.BuildTopStatement(IMartenSession session, IQueryableMemberCollection collection, IDocumentStorage storage, QueryStatistics statistics)
at Marten.Linq.Parsing.LinqQueryParser.BuildStatements()
at Marten.Linq.Parsing.LinqQueryParser.BuildListHandlerT
at Marten.Linq.MartenLinqQueryable1.ToListAsync[TResult](CancellationToken token)    at Marten.Pagination.PagedList1.InitAsync(IQueryable1 queryable, Int32 pageNumber, Int32 pageSize, CancellationToken token)    at Marten.Pagination.PagedList1.CreateAsync(IQueryable1 queryable, Int32 pageNumber, Int32 pageSize, CancellationToken token)    at Marten.Pagination.PagedListQueryableExtensions.ToPagedListAsync[T](IQueryable1 queryable, Int32 pageNumber, Int32 pageSize, CancellationToken token)

The data for the MemberKycVerificationStep document is present in the db. But I don't understand why I'm getting a null reference. Please help.

removed a repetition.

@kacey90 Hey, this isn't supported:
Name = included != null ? included.Name : "",
We don't have any way to use the results of the documents fetched as part of the Include() statement in the LINQ query itself. Marten isn't even fetching the Include() documents until you call ToPagedListAsync() above.
The long and short of this is that Marten just doesn't support what you were trying to do. I get that the exception isn't terribly revealing, but we also didn't anticipate anyone trying to do what you did.
I'm closing this for now as there's nothing actionable.


Feature/add docker build action

fixes master.yml workflow to have the correct paths

wrong branch!


Duplicate dataset aliases allowed?

It seems like the database unique constraint on alias was removed? You'll have to be signed in to view this because one of the datasets is private, but there are two datasets with the alias PaleoBioDB:
https://www.checklistbank.org/dataset?limit=50&offset=0&origin=external&origin=project&q=paleobiodb

yes that is true since a long time

I think the old behavior was to have the whole import fail if the alias was a duplicate, which definitely did cause problems. But duplicate aliases does make it easy to mistakenly assemble the wrong dataset into a project. Would it be possible to catch the duplicate alias exception and just set it empty or maybe append a number onto it?

thats what I think we ended up doing, setting it to null if it existed already.
Maybe we can get back to that behavior but either ignore private datasets?


Create Option to ChangeNameGroup

Create an option to change existing group names via ID

Option already exists via setGroupSubject function - Closing the issue


Add libilmbase-dev dep for libopenvdb-dev

The libopenvdb-dev package has a header file (/usr/include/openvdb/Types.h) that includes another header file (<OpenEXR/half.h>) from the libilmbase-dev package.  libopenvdb-dev does not declare a dependency on libilmbase-dev, which means that any packages that depend on libopenvdb-dev and use that header may fail to compile.  This may not have been noticed before because libopencv-dev has a transitive dependency on libilmbase-dev, so it will already been installed for many packages.
It appears that the Arch and Gentoo packages for this declare their dependency properly (or they do so transitively through libopenexr-dev), so it shouldn't be an issue for them:
https://www.archlinux.org/packages/community/x86_64/openvdb/
https://gitweb.gentoo.org/repo/gentoo.git/tree/media-gfx/openvdb/openvdb-4.0.2.ebuild
But neither Debian nor Ubuntu declare it:
https://packages.debian.org/stretch/libopenvdb-dev
https://packages.ubuntu.com/xenial/libopenvdb-dev
And here are the links to the packages that provide the necessary header:
https://packages.debian.org/stretch/libilmbase-dev
https://packages.ubuntu.com/xenial/libilmbase-dev

I'm fine to add this, but you should really consider reporting this to debian upstream if it hasn't already.

I've submitted a report via e-mail to the Debian bug tracking system, although it doesn't appear to have shown up in their bug tracker yet.

For reference: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879896

Thanks for the follow up with Debian.


Fix #1335 Proper use of state parameter for the OAuth CSRF protection

Summary
This pull request resolves #1335 by migrating to the new handleInstallPath() method, which is newly added in<EMAIL_ADDRESS>Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Thanks for the reviews!


Add note about vue-cli-plugin-gh-pages to deployment docs

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[x] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Other information:
I'm the author of vue-cli-plugin-gh-pages, a Vue CLI plugin wrapping gh-pages. It would be helpfull for users if a link to this plugin is added to the documentation about deployments.

No longer relevant.


27 Documentation: Docstrings

Now that we have a release, it’s time to prep the codebase for potential contributions. Besides making things easier for contributors, it also makes it easier for us/me to understand the code if I return to it in future.
First up: documentation.

Even before we write the kind of lengthy detailed documentation that developers usually expect, I would start by writing docstrings first. That's the first instance of documentation that anyone trying to contribute code will first encounter.
So let's add docstrings for __init__.py, builtin.py, and lang.py: [7dbc483b39a024a538b7f4d316d60b2bd2596a9c]. [57fe719328fb8f7e7336d1b5dd35f675ab5c7561]

That covers the main classes and functions/methods. Let's add docstrings for the modules too: [62b1660d9355d5c4b3b64c59cfe370898ece1d69]
I'm not documenting them exhaustively here since it's unlikely anyone will do import pseudocode and proceed to use the classes there, but we'll see.

PEP257 has some ideas about how docstrings should be formatted. We'll try to follow it: [ebdee49ec71188bda9ac7b552c1b7aec76bcbb31]

And then docstrings for the rest of the modules: [e514b657908a5a9b3c71ca4ef12db0db1e751a6f]
This is probably the driest chapter so far, but also the one most likely to help us in future.


Do we need the KDF set_ctx_params calls

The KDF derive call takes an OSSL_PARAM array which can set everything required.  If this argument is made mandatory, we no longer require the context set params call.
The KDF life cycle is new -> derive -> free.  There is no init or update.
We'd lose the ability to set the params piecemeal but this is a new API so there is no need to support such setting via ctrls.
The settable call would remain.
Should we remove these functions?

OTC: We will leave the set_ctx_params as is.


Rename repository to use dashes instead of underscores

This is the only repository that has a different convention from other repositories.

+1. Consistency is good.

Thanks for the pointer, I'll do this.

Done! Thanks for your comments and report.


chore(dcos-e2e): run dcos pr-e2e in southcentralus

This moves one of the DCOS pr-e2e tests into southcentralus, where we were just granted a core quota increase—westcentralus is experiencing capacity issues apparently.

This change is

@jackfrancis @jchauncey


Small CSS Suggestion - Hide scrollbars

Here in 2021 I have this open on it's own screen off to the side in a fullscreen browser window.  Maybe it's just me but the scrollbars are ugly and not really necessary for this .  My suggestion is to add a toggle to hide the scrollbars from view.  In chrome it's as easy as below.  For now I just have a custom css applied automatically, but maybe you're bored and wanna add polish.
::-webkit-scrollbar {
    display: none;
}

Added in version 1.97.
At the top of the document to the right of the Collapse button I added this button [↕ ] which will toggle hiding the scroll bars.  Tested in Chrome on Windows 10.
Thanks again for this suggestion and the initial CSS which allowed me to track down a pure .js solution. (It requires a nested container, with the overlay, width, and height set.)


Adding shops to the list, when there is more than one list

When clicking the heart to add a shop to a list and you choose the list, which isn't shown at that time, the heart does not turn green.
I think it would be better, if you would switch automatically to the list you have chosen when clicking the heart under a shop. Then the heart turns green and the user knows that it worked.

Changing the list on the heart will ultimately result in navigating to the "merkliste" overview.
We should discuss that feature on a Tuesday call - might make sense to change the behaviour of merkliste-switching back to where it was before.

I have no memory what we wanted to do here... :D

We wanted to check airbnb & Co. :-) and in the meantime including a confirmation window, when adding a shop to the list, so that users know the shop was added

right :)

Toast message works perfectly, but the switch between the lists doesn't.
When I add several shops to the list I am not in at that moment, all of the sudden after the second or third shop, the list switches to the other list and shows green hearts at all shops on the other list. But in the top menu it still says I am in the list before (see screen capture video: https://www.dropbox.com/t/eh07iky1dfDkJFm9)
So the menu doesn't work correctly and the switch between the lists, when adding new shops only works randomly.

ups - interesting. Thank you for providing a video. Helps alot :)

@owlRike it took some time, but I guess I figured out what went wrong here.
Please have a look again, ty


Remove some unused code

This is especially important when using Akavache on iOS or Android, to
keep the package size down

Uhhh are you sure this code is unused?

Pretty sure, I guess, kinda? At least I haven't found any references to it and it's also not in the portable stub class

:+1:, thanks!


BsonGenerator does not handle null values correctly

When using BsonGenerator, calls to writeString and writeNumber throw a NullPointerException if the given value is null.
The correct behavior is to call writeNull(): see jackson-core's writeString(String), writeNumber(BigInteger), and writeNumber(BigDecimal)

@sashavol I've investigated the issue and decided to keep the behaviour as it currently is. The reason for this is that BSON does not have a null string. It has a special type for null values but strings must always be defined (see the specification: http://bsonspec.org/spec.html).
If you have a specific use case where you require this feature, please let me know. I can add a feature flag if necessary.


Fixes Issue#43

Uses relative path, so that yarn workspace will work

This fixes https://github.com/altrim/ember-cli-tooltipster/issues/43

Thanks for the PR 👍


Added a compatibility doc

A work-in-progress that lets us keep track of compatibility/behavioral differences between legacy project system and the new one.

tag @dotnet/project-system


Fixed #27488 -- Added IsValid and MakeValid functions, and isvalid lookup on SpatiaLite.

https://code.djangoproject.com/ticket/27488

merged in 45e01df37353324c3ca9cca1b330bc2841468f82, thanks!


[stable/envoy] Add support for static load balancer IP: bugfix

Signed-off-by: Shu Heng<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
This is to fix the bug introduced in #18219, which has the wrong attribute name.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
I apologize for not noticing this earlier when i submitted the PR.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/approve
/ok-to-test

/lgtm


feat: leaderboard defeat caching

add random number to query string for leaderboard.json to force reload

I'm going to be refactoring the data loading, and I'll include cache busting in it.


Bug: On creating new linked build pipeline it's throwing error in case of overridden parent pipeline

📜 Description
We are trying to create a new linked-build pipeline but it's throwing 502 in case of selecting overridden parent build pipeline.
👟 Reproduction steps

Create a build pipeline(parent) and override the configuration.
create a new linked-build pipeline by selecting the above create overridden parent pipeline.

👍 Expected behavior
It's throwing an error on UI but in the backend, it's getting created, but also not able to delete the same child pipeline.
👎 Actual Behavior
It's failing for now and also not able to delete the same pipeline.
☸ Kubernetes version
1.23
Cloud provider

EKS

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

RCA: In case of pipeline made from parent ci pipeline which had docker build config overridden, object for saving audit log of the same was not being updated by code and thus caused panic when accessed. For panic at deletion, ci build configuration was being accessed in case of external pipeline whereas the configuration is present at its parent level only.


Adding -v flag to az ml endpoint realtime list causes error

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
az ml
Description of issue (in as much detail as possible)
Running az ml endpoint realtime list works. Adding the -v flag emits an error. See the identical outputs (obfuscated for privacy) below.
I have used -v with other az ml commands without error, output is expanded/verbose as expected. This seems to be a bug in this command specifically. Ran apt-get update/upgrade and confirmed with az --version that everything up to date.

az ml endpoint realtime list -g $resource_group_name --workspace-name $ml_workspace_name
Output:
[
{
"computeType": "ACI",
"name": "aciservice",
"properties": {
"hasHttps": "False",
"hasInferenceSchema": "False"
},
"scoringUri": "http://OBFUSCATED.eastus.azurecontainer.io/score",
"state": null,
"tags": "",
"updatedAt": "2020-08-12T21:17:25.303081+00:00"
}
]

Add only -v with no other changes
az ml endpoint realtime list -g $resource_group_name --workspace-name $ml_workspace_name -v

Output:
{'Azure-cli-ml Version': '1.9.0', 'Error': AttributeError("'bool' object has no attribute 'lower'",)}

ml

Please use V2 of ML https://learn.microsoft.com/en-us/cli/azure/ml?view=azure-cli-latest and also upgrade to latest version of auzre cli 2.43.0


Is this secure to use with user generated templates?

Hi, I'm looking at using this library to render user created templates with data I supply.  I'm wondering if this library would work or if there are ways that users could insert malicious code and trick mustache.js into executing it.
The only security issue I could find was the fact that templates could be caused to infinitely load one another, but if I only let users control the top-level template, but not sub-templates, I think I would be OK.  I did not see a way to execute raw JS, but I would like to hear from an expert with this before committing to use it.

I did not see a way to execute raw JS

I think you've come to the right conclusion.
I can't think of any way to tell mustache to execute JavaScript code specified in the templates themselves. That would also counteract much of what was the holy grail with mustache back in the day: rendering the exact same templates on different runtimes, be it java or C# on the server and javascript in the browser.
One of mustache' mission was to be logic less and opposite of clever. Allowing whatever code to be provided inside the template, doesn't sound like something that would fit that mission either from my point of view.
I could imagine dynamic code to be executed by mustache upon render when using mustache functions, but those would have to be declared on the data side of things, not inside the templates -- and you've said that you're the only one providing the data for rendering.

@turbobuilt how do your solution looks like?


Update stream-analytics-power-bi-dashboard.md

Hi @pablissima, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (paulettm). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


ROS2 Humble Release

The pinocchio humble release PR has been merged into rosdistro, however the build is failing as described here. Is there any ongoing work to get this fix?

Dear @Benjamin-Tan  we are very committed to make it work on ROS-2 Humble.
From the log it looks like this is still the python bindings which are consuming too much memory. This is a recurring problem on which @wxmerkt, @jcarpent and @nim65s have been working a lot.
It created problems as well on our buildfarm. AFAIK it was fixed on our buildfarms, and we were hoping that it would also work on ROS-2 buildfarm.

Dear @olivier-stasse , it is good to know that. Looking forward to the fix! Really appreciate the great work and commitment.

Hi @Benjamin-Tan
The builds for Humble and Rolling are now building and should be available with the next sync of the respective distributions and available from now on the testing/staging server

Thank you very much @wxmerkt for finding that -g1 was enough.
Out of curiosity how did you check that it was passing apart trying it on a local docker ?
On my side I was trying with -fvisibilty=hidden but handling properly the exported symbol seems to be not so simple.

I guess this is through the pre-release tests.

I compiled locally many times measuring the memory consumption for different build options, with different linkers, etc. - in the end the only thing that measurably had an impact was -g1 (or -g0 of course). The options to encourage the linker to reduce memory use did not help. For what it's worth, we currently need about ~1.8GB for the largest individual compilation unit outside of linking using clang


Fix for a regression in the unit test //tensorflow/python/kernel_tests/nn_ops:pooling_ops_test_gpu

he unit-test //tensorflow/python/kernel_tests/nn_ops:pooling_ops_test_gpu started failing, after this change in the Eigen repo - https://gitlab.com/libeigen/eigen/-/commit/cc3573ab4451853774cd5c3497373d5fe8914774
INFO: From Testing //tensorflow/python/kernel_tests/nn_ops:pooling_ops_test_gpu:
==================== Test output for //tensorflow/python/kernel_tests/nn_ops:pooling_ops_test_gpu:
Running tests under Python 3.9.7: /usr/bin/python3
[ RUN      ] PoolingTest.testAvgPoolEmpty0 (pool_func=<function avg_pool at 0x7fb968603f70>, data_format='NHWC', data_type=tf.float32, use_gpu=False, v2=False)
...
...
[ RUN      ] PoolingTest.testAvgPoolKernelSmallerThanStride4 (pool_func=<function avg_pool at 0x7fb968603f70>, data_format='NHWC', data_type=tf.float16, use_gpu=True, v2=False)
2021-11-30 15:31:04.335778: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1525] Created device /device:GPU:0 with 31740 MB memory:  -> device: 0, name: Device 738c, pci bus id: 0000:4a:00.0
INFO:tensorflow:Running NHWC test. False [1, 7, 7, 1] 49 <function avg_pool at 0x7fb968603f70> [1, 2, 2, 1] [1, 3, 3, 1] <dtype: 'float16'>
I1130 15:31:04.335854<PHONE_NUMBER>72896 pooling_ops_test.py:231] Running NHWC test. False [1, 7, 7, 1] 49 <function avg_pool at 0x7fb968603f70> [1, 2, 2, 1] [1, 3, 3, 1] <dtype: 'float16'>
2021-11-30 15:31:04.336372: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1525] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 31740 MB memory:  -> device: 0, name: Device 738c, pci bus id: 0000:4a:00.0
2021-11-30 15:31:04.341161: I tensorflow/core/common_runtime/gpu_fusion_pass.cc:507] ROCm Fusion is enabled.
Memory access fault by GPU node-4 (Agent handle: 0x486adb0) on address 0x100000000. Reason: Page not present or supervisor privilege.
...
...

The Eigen commit changes the visibility of the Packet type ( Packet4h2) for the Eigen::half datatype. Prior to the commit, Packet type is defined as Packet4h2 during both the host and device compile phases of hipcc/nvcc. After the commit the Packet type is defined as Eigen::half (size == 2) in the host compile phase, and as Packet4h2 (size == 8) in the device compile phase.
struct AvgPoolMeanReducer has a member of type Packet(https://github.com/tensorflow/tensorflow/blob/r2.7/tensorflow/core/kernels/eigen_pooling.h#L367), and hence its size will be different during the host compile phase and device compile phase. It also seems that the implementation of the average pooling op ( https://github.com/tensorflow/tensorflow/blob/r2.7/tensorflow/core/kernels/avgpooling_op.h#L34-L38 ) will result in a struct AvgPoolMeanReducer argument being passed across the host / device compile boundary (atleast for hipcc) and size mismatch between the two, leads to the subsequent segfault.
The fix here is to ensure the Packet has the same definitition for both the host and device compile phases. However changing the type packetCount_ to int unconditionally leads to compile errors, because during the non-gpu / gcc compiles the code within the !defined(__HIPCC__) block gets activated, and hence the changes in this commit are guarded by defined(__HIPCC__). Using int for packetCount_ is ok because PacketAccess is already set to false within (a different) defined(__HIPCC__) block.

/cc @jayfurmanek @ekuznetsov139

Thanks @deven-amd ! This one was incredibly tricky.
It's also certainly odd that the type for packetCount_ wasn't just int to begin with given what it is used for.
I'll be able to close https://gitlab.com/libeigen/eigen/-/merge_requests/721 in favor of this one.

@jayfurmanek thank you for the fix. That was a tricky one indeed!

corresponding upstream PR - https://github.com/tensorflow/tensorflow/pull/53257


Step creates a development certificate as byproduct and on consecutive run fails on that particular certificate

Troubleshooting

[x] I've searched discuss.bitrise.io for possible solutions.
Which version of the step is effected? 4.1.x - 4.2.x
Is the issue reproducible with the latest version? YES
Does the issue happen sporadically, or every time? EVERY TIME
Is the issue reproducible locally by following our local debug guide? NOT APPLICABLE

Issue description
I build app for ad-hoc and app store distribution with this step with api-key. On my App Store Connect I have several certificates, 8 Development and 1 for Distribution. When I run the step with this configuration, it runs fine and builds the app and it's successfully distributed to app store. However as byproduct of running that step, a new Development certificate is created via api (no idea why, but this has been confirmed in another project that uses this new step, so I guess it's by design). Unfortunately, this additional certificate ruins the next run with the error like in the logs below. Every consecutive build will fail this way until I remove this byproduct cert. At which point it runs again fine once and then the problem returns.
As a side note - in another project in our company these additional cert is created as well, but it doesn't mess up consecutive builds.
Bitrise info

Bitrise Support enabled: / NO_
Log:

+------------------------------------------------------------------------------+
| (3) xcode-archive@4                                                          |
+------------------------------------------------------------------------------+
| id: xcode-archive                                                            |
| version: 4.2.6                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2022-01-26T14:44:57Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[14:44:57]  * [OK] Step dependency (xcode) installed, available.
Inputs:

distribution_method: app-store

upload_bitcode: true

compile_bitcode: true

icloud_container_environment:

export_development_team:

export_options_plist_content:

log_formatter: xcpretty

project_path: /Users/[REDACTED]/xxx

scheme: xxx

configuration:

output_dir: /Users/[REDACTED]/deploy

perform_clean_action: false

xcodebuild_options:

xcconfig_content: COMPILER_INDEX_STORE_ENABLE = NO

export_all_dsyms: true

artifact_name:

verbose_log: true

cache_level: swift_packages

automatic_code_signing: api-key

certificate_url_list: [REDACTED]

passphrase_list: *****

keychain_path: /Users/[REDACTED]/Library/Keychains/login.keychain

keychain_password: *****

register_test_devices: false

min_profile_validity: 0

BITRISE_BUILD_URL: https://app.bitrise.io/build/xxx

BITRISE_BUILD_API_TOKEN: *****
Xcode version:
Xcode 13.2.1 (Build version 13C100)
Fetching Apple Service connection
[DEBUG] GET https://app.bitrise.io/build/xxx
Bitrise Apple Developer Connection with API key found
Using Apple Service connection with API key.
Checking if log formatter (xcpretty) is installed

xcprettyVersion: 0.3.0
Preparing code signing assets (certificates, profiles) before Archive action
Code signing asset management with xcodebuild
Reason: Automatically managed signing is enabled in Xcode for the project.
Downloading certificates from Bitrise
Downloading p12 file number 0 from [REDACTED]
[DEBUG] GET [REDACTED]
Codesign identities included:

Serial: 133...88, Name: Apple Distribution: xxx Ltd. (xxx), Expiry: 2023-01-26 08:09:15 +0000 UTC
Valid and deduplicated certificates:

Serial: 133...88, Name: Apple Distribution: xxxLtd. (xxx), Expiry: 2023-01-26 08:09:15 +0000 UTC
Valid certificates with type IOS_DEVELOPMENT:
Valid certificates with type IOS_DISTRIBUTION:

Serial: 133...88, Name: Apple Distribution: xxx Ltd. (xxx), Expiry: 2023-01-26 08:09:15 +0000 UTC
Valid certificates with type IOS_DISTRIBUTION:

Serial: 133...88, Name: Apple Distribution: xxx, Expiry: 2023-01-26 08:09:15 +0000 UTC
Valid certificates with type IOS_DISTRIBUTION

Serial: 133...88, Name: Apple Distribution: xxx, Expiry: 2023-01-26 08:09:15 +0000 UTC
Valid and deduplicated certificates:

Serial: 133...88, Name: Apple Distribution: xxx, Expiry: 2023-01-26 08:09:15 +0000 UTC
Installing downloaded certificates:

Serial: 133...88, Name: Apple Distribution: xxx, Expiry: 2023-01-26 08:09:15 +0000 UTC
Creating the Archive ...
[14:45:23] $ set -o pipefail && xcodebuild "-workspace" "/Users/[REDACTED]/git/xxx/xxx.xcworkspace" "-scheme" "xxx" "-xcconfig" "/var/folders/62/0p2cg52j6r16xjxfqch4vgt40000gn/T/256955914/temp.xcconfig" "archive" "-archivePath" "/var/folders/62/0p2cg52j6r16xjxfqch4vgt40000gn/T/xcodeArchive576485345/xxx" "-allowProvisioningUpdates" "-authenticationKeyPath" "/var/folders/62/0p2cg52j6r16xjxfqch4vgt40000gn/T/AuthKey_xxx.p8" "-authenticationKeyID" "xxx" "-authenticationKeyIssuerID" "xxx" "-destination" "generic/platform=iOS" | xcpretty
❌  error: Revoke certificate: Your account already has an Apple Development signing certificate for this machine, but its private key is not installed in your keychain. Xcode can create a new one after revoking your existing certificate. (in target 'xxx' from project 'xxx')
❌  error: No profiles for 'xxx' were found: Xcode couldn't find any iOS App Development provisioning profiles matching 'xxx'. (in target 'xxx' from project 'xxx')

Hello @micHar,
Based on the logs it seems likely that you have not uploaded a Development Certificate on the Code Signing tab on Bitrise. Can you please check and upload one if not?
I think that would prevent the creation of the Apple managed Development certificate that is causing issues.
If this solves the issue then we can add a check before running the Step to make sure a Development certificate is available.

Thanj you for responding!
I have my Distribution certificate there. Should I add the development certificate as well, even though I'm building for app store / admin hoc?
Also, keep in mind that it works as long as there is no generated certificate in ASC. Its the only difference between successful and failed builds as far as I can tell.

@lpusok, it does work if I add the development cert to Bitrise. But I still don't understand why that would be necessary :)

I had the same experience. Uploading the Apple Development cert fixed it

Any info? Still happening to me

Hello everyone!
This behavior is in fact caused by Xcode's cloud-managed code signing and not something our step does. We are still looking into how we can work around the issue (that Xcode creates a dev cert in the background, then fails the next time).
In the meantime, the best workaround is the one already mentioned in this thread: create an Apple Development certificate manually and upload it to Bitrise so that the step can install it at runtime.

Thanks, that helped.

I had a similar issue, my step xcode build for ad-hoc started failing with:
❌  error: Choose a certificate to revoke. Your account has reached the maximum number of certificates. To create a new one, you must choose a certificate to revoke. (in target '[REDACTED]' from project '[REDACTED]')
When I checked Apple I saw that Bitrise had created nearly a dozen dev certificates with the app store connect API key.
My mistake was that I had uploaded an "iOS Development" certificate to Bitrise code signing and assumed it had worked, when in reality I should have uploaded the generic "Development" certificate. As Bitrise didn't have the "Development" certificate, it kept creating them each time we ran an ad-hoc build.

Thank you @ofalvai & @matthewbal for the hint with the "Apple Developer" certificate. This fixed the automatic creation of development certificates. 🎉
But, in some of our projects (not in all), we experience a similar issue with the automatic creation of "Distribution Managed" certificates which are created by "API Key: xxxxx- ...", even if we upload the "Apple Distribution" certificates to Bitrise.

Hi everyone, we recently started integrating with Bitrise and have experienced the same limitation where the official Xcode Archive & Export step requires a certificate being uploaded. And it appears that such requirement is there because:

xcodebuild archive will try to use a development certificate to sign the generated .xcarchive file.
a development certificate is automatically generated for the first time running on the CI machine.
xcodebuild refuses to generate a new development certificate if a previous one has been generated for the same CI machine.

This matches what the OP and everyone else has reported here. And the workaround proposed here is to upload a pre-generated development certificate manually so that xcodebuild will simply use it for the archiving thus avoid the above issue entirely.
This same issue has been reported on other places. Fastlane and Apple Developer Forum.
Now, I'd like to share another solution, instead of using a pre-installed certificate, we can skip the code signing for the archiving phase entirely because we will export and resign the final IPA regardless. So during archiving, we run:
xcodebuild archive \
-scheme $BITRISE_SCHEME \
-destination generic/platform=iOS \
-archivePath ios.xcarchive \
-quiet \
CODE_SIGNING_REQUIRED=NO \
CODE_SIGNING_ALLOWED=NO

The key here is to use CODE_SIGNING_REQUIRED and CODE_SIGNING_ALLOWED to skip signing. And then during exporting, we can keep doing whatever we're doing right now:
xcodebuild -exportArchive \
-archivePath ios.xcarchive \
-exportPath output \
-exportOptionsPlist $ABSOLUTE_PATH_TO_EXPORT_OPTIONS_PLIST \
-allowProvisioningUpdates \
-authenticationKeyPath $PATH_TO_APPSTORE_CONNECT_API_KEY \
-authenticationKeyID $APPSTORE_CONNECT_API_KEY_ID \
-authenticationKeyIssuerID $APPSTORE_CONNECT_API_ISSUER_ID \
-quiet

xcodebuild will, as expected, automatically fetch a managed distribution certificate as long as the export options has app-store/ad-hoc as the method. The resulting IPA will have the correct signing to be uploaded to App Store for distribution. The benefit of this alternative workaround is that we don't have to manually generate and upload the development certificate any more. (even though I agree that's not a big deal since it lasts for a year before expiring)
Keen to hear feedback around this workaround and if it's something we should add into the offical step.

Not stale

@ofalvai
Any progress on this?
Uploading the development certificate workaround works fine. I would appreciate it if we could at least check the expiration date of the uploaded certificate. If the certificate expires, the step ignores it and starts creating new ones until one of the builds fail with Choose a certificate to revoke. Your account has reached the maximum number of certificates ... . It would be handier if we got the error immediately when the cert expires.

Hi there,
I've tried all the possible ways to use Xcode archive with manual signing for app-store but does not work! It might work by auto-signing but I am trying to use manual signing!
As well as I uploaded the Apple development certificate next to the Distribution certificate, but I get this error:
 No profiles for '[Bundle Id]' were found: Xcode couldn't find any iOS App Development provisioning profiles

i believe this issue is still very relevant.

This issue is still occurring, and even the workaround is not working for me. Uploading a development certificate still causes the build to fail with the 'Your account already has an Apple Development signing certificate for this machine, but its private key is not installed in your keychain' error.
Frustrating as we would like to use Bitrise going forward, but may be forced to use XCode Cloud instead if this cannot be resolved.

@BucekJiri thanks for your advice, but these are the steps that I've already followed! I created a brand new developer certificate on the apple developer portal and went through the usual keychain import (with private key) / export process. the only difference from what you've described is that the final certificate is in .p12 format, rather than .cer. But that's standard, from my understanding.
I'm trying again with a new development certificate, just in case there was something wrong with the first one I created.

@PWhittle86 My bad, it is actually p12.
Some other things to check:

The archive step should have automatic code signing turned on and api_key set as App Store Connect authentication
This means you should have the App Store Connect API key uploaded to Bitrise
Automatic code signing should be turned on also in Xcode for the configuration you build

Please disregard my previous messages. There must have been something wrong with the development certificate I uploaded previously as now that I've created and uploaded a new cert, it's working as expected.
@BucekJiri thanks for your help!


how to move a servo controller

I tried this to move a servo controller, but it wont move the servo.
Am I doing something wrong ?
#!/usr/bin/python

import pigpio
import time

pi = pigpio.pi()

pi.set_mode(17, pigpio.OUTPUT)

pi.set_PWM_frequency(17, 50)

time.sleep(1)

print (pi.get_PWM_frequency(17))

##pi.set_PWM_frequency(17, 6) # 2.35%

pi.set_PWM_frequency(17, 32) # 2.35%

time.sleep(1)

pi.set_PWM_frequency(17, 0) # 2.35%

time.sleep(1)

pi.stop()

Not necessarily.  Can your servo can cope with a pulse width of 2500 µs?
I suggest you use the set_servo_pulsewidth which always uses 50 Hz and was designed for use with servos.

So I came here trying to get my servos working as well. I modified the script above following your suggestion with set_servo_pulsewidth.
#!/usr/bin/python

import pigpio
import time

pi = pigpio.pi()
pi.set_mode(18, pigpio.OUTPUT)

print ("mode: ", pi.get_mode(18))
print("setting to: ",pi.set_servo_pulsewidth(18, 1500))
print("set to: ",pi.get_servo_pulsewidth(18))

time.sleep(1)

print("setting to: ",pi.set_servo_pulsewidth(18, 1000))
print("set to: ",pi.get_servo_pulsewidth(18))

time.sleep(1)

print("setting to: ",pi.set_servo_pulsewidth(18, 2000))
print("set to: ",pi.get_servo_pulsewidth(18))

time.sleep(1)

pi.stop()

unfortunately the output shows that the pulsewidth was not set correctly, AND the servo does not move. Is there something I can do do debug this further? Or some setting I am missing in setting everything up?

The code looks fine.
Possibilities in increasing order of likeliness.

servo is bust
servo is underpowered
servo's control wire is not connected to GPIO 18
servo's ground is not connected to Pi ground.

If none of the above apply could you post a photo of your set-up and give details about your Pi model, pigpio version etc. etc.

Looks like I had forgotten to join the two grounds together. I appreciate your help and am very glad that it didn't turn out to be a software issue.


Add pagination to document collections search via title results page .

This PR adds pagination functionality to search via title results page to add document.
It does the following:

Added pagination logic for results page when searched via title.
Updated controller tests
Removed word slug from search via title views ,controller,controller_test-and routes files.

Trello:
https://trello.com/c/Idbzgryr/571-add-pagination-to-results-page-for-document-collections
Screen shots:

When no results found:

From screenshots it looks good. Lets setup a session today to go over the spacing :)

What happens when there is only 1 to 15 search results returned?

What happens when there is only 1 to 15 search results returned?

It will not render pagination component as it is handled to show pagination when records > 15

@nnagewad I have updated the message for no results found.Could you please check and let me know if it needs to be changed.

@nnagewad I have updated the message for no results found.Could you please check and let me know if it needs to be changed.

Just wondering why the content has changed?

@nnagewad I have updated the message for no results found.Could you please check and let me know if it needs to be changed.

@farahTW just wondering why the content has changed?

@nnagewad As discussed reverted back the message.

LGTM


Fix sample template

Add a value to the data-* attributes so they aren't erased by renderToStaticMarkup

On a side note, I think the template sample provided in the Dropzone.js documentation isn't actually the same as the default. When inserted as-is, the css styling was all screwy. I don't have the time to work out what the actual template should be, though.

Thanks!


Revised logical negation operator article

Supported by dotnet/samples#647

Closing and reopening to begin new build after dotnet/samples#647 was merged.


Support for actions

As mentioned in Notification API docs
I don't see any support in Push.js for actions

That's correct. There is no support for actions yet.
A PR is always welcome :)


Display all delivery requests by default

Replaces the single checkbox ("Show Driving Clusters") with two checkboxes: "Driving Cluster Requests" and "Regular requests".
Both are checked by default.
Updates some names for the sake of consistency.

Resolves #139
Here's what it looks like with the change:

I considered stacking the checkboxes vertically, but decided against it since it pushed the map further down the page. Here's what that would look like:

i think its a good call to rename, driving clusters is kind of confusing alongside map clusters


[Enhancement] Support rsync mirroring

Is your feature request related to a problem? Please describe.
Synchronizing feeds can often be a problem when in severely restricted networks, some network administrators may also be uncomfortable permanently having a server outbound connection open to a third party.
The greenbone feeds also have strict restrictions, such as only allowing a single sync at a time, restricting sync speed, temp-banning IPs that sync too often.
Describe the solution you'd like
Gated behind an environment variable, such as "RSYNC" or "PROXY_FEED", the master scanner could publish the data it previously synced via rsync, either

through the regular port 873
through the existing SSH socket, which would allow a single port to be used for "everything" openvas needs.

Additional context
Rsync sends things through cleartext by default, and I don't think it pins servers either.
To test this, you can use the "--add-host" or "extra_hosts" parameters to redirect feed.community.greenbone.net to a custom server.
Legacy/existing openvas scanners can already do the above to point to a custom server for feed updates.
It looks like it's possible to only allow rsync through ssh, however this is saved in the authorized_keys file, so toggling the environment variable won't necessarily disable rsync: https://serverfault.com/a/965929

Sounds quite interesting, could you contribute a PoC?
I would have to think about it more, but time is a bit short at the moment. But I'll add it to my list if you don't have the possibility to contribute code yourself.

Sure, I'll see what I can do, if anyone else is interested, don't hesitate to snipe it, we probably need more than a single approach anyway.

Alright, so, to get a basic experiment going, here are the changes that need to be done to run an rsync command manually:
This assumes one master, one slave, and that they are already linked through SSH.
All the config changes must be done on the master:
/etc/ssh/sshd_config:
MaxSessions 0 -> MaxSessions 1
/var/lib/gvm/.ssh/authorized_keys:
Prepend command="rrsync -ro /var/lib/openvas/plugins" to the key
You can now run this on the slave:
rsync -e "ssh -p $MASTER_PORT -i /var/lib/gvm/.ssh/key" --compress-level=9 --links --times --omit-dir-times --recursive --partial --quiet gvm@$MASTER_ADDRESS:/ /var/ lib/openvas/plugins
And the directories should now sync.


Inquiry about structural navigation caching

As per the following article, caching for structural navigation will improve performance.
https://support.office.com/en-us/article/f163053f-8eca-4b9c-b973-36b395093b43
But this article has still described "Structural navigation, is NOT a recommended navigation option in SharePoint Online".
Could you check which one is correct?
A. Structural navigation will be optimized using cache, but still not recommended and we should guide customer to other options.
B. The performance degradation risk by using structural navigation will be gone by caching, and they can use this without worry.
If B is correct, I appreciate if you will remove "Structural navigation, is NOT a recommended navigation option" statement from this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe686368-f607-9a7d-710b-d51c3f8f6c9a
Version Independent ID: 01b5902a-6e23-62d9-f0a3-7c1e86194ef1
Content: Navigation options for SharePoint Online
Content Source: Enterprise/navigation-options-for-sharepoint-online.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@taisino  - Thank you for submitting feedback.
I will get this issue over to the Enterprise writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

I'm adding the topic's author @LoreenLa to the issue.

Thanks for the feedback! I'm checking on this and will report back.

Thanks again for the feedback! What I've learned is that structural navigation caching is not yet broadly available. So, for the majority of users, the recommendation is still not to use structural navigation if possible. For those users who have the caching option, then we hope you use it and give us feedback about your experience. The article https://support.office.com/en-us/article/f163053f-8eca-4b9c-b973-36b395093b43 is also not broadly available yet, but was created primarily for those who have opted in to targeted/early release features. Once this feature is more broadly available, we will update the content to reflect the latest recommendations.  I hope that is helpful.

Hi LoreenLa, thank you very much for your prompt response.
I  understand your explanation completely, and will give the feedback if I'll find anything about caching option.
Please close this discussion.

Any news about general availability of structural navigation caching ?
It is still not available in my tenant.

Thanks for asking! We haven’t started rolling to targeted release yet, but we expect to do so in late Q1.
From: carletto75<EMAIL_ADDRESS>Sent: Friday, February 21, 2020 8:30 AM
To: MicrosoftDocs/OfficeDocs-Enterprise<EMAIL_ADDRESS>Cc: Loreen La Penna<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-Enterprise] Inquiry about structural navigation caching (#587)
Any news about general availability of structural navigation caching ?
It is still not available in my tenant.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-Enterprise%2Fissues%2F587%3Femail_source%3Dnotifications%26email_token%3DAIPD6SHJNNSAYPQ3HFW57WDRD76RNA5CNFSM4JJATMR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTI2YA%23issuecomment-589729120&data=02|01|loreenl%40microsoft.com|de88854c65c9456f59af08d7b6eb5496|72f988bf86f141af91ab2d7cd011db47|1|0|637178994156690129&sdata=UsSxyxxB6JrDLIQb4czJzZqFruP9rGAPSGcoVkS5bPU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIPD6SFKKFIMR4RLJRSR67LRD76RNANCNFSM4JJATMRQ&data=02|01|loreenl%40microsoft.com|de88854c65c9456f59af08d7b6eb5496|72f988bf86f141af91ab2d7cd011db47|1|0|637178994156690129&sdata=teOP0K%2Bwv7ST0wSojyZTlBk1LC939%2F%2FjGnx43tmy35s%3D&reserved=0.


Make this run on stable

Sorry about the delayed response, I just noticed that Github had disabled all my notifications on this repository.
Closing in favor of #8

No worries :) thank you


Add robust validation to donation amount input

Splitting this out from #305 to track.
Things to address:

[ ] At the moment an arbitrary $5 minimum is in place, however if the user enters a lower value and submits the form it will automatically revert to $5 and proceed which may be unintuitive. Simple solution is probably just to block submission and provide some visual feedback to highlight the input.
[ ] Set some sane upper limit to prevent errors caused by large numbers. Due to the way the controlled component casts from string to number I'm curious to ensure this doesn't cause client-side errors if a value greater than Number.MAX_VALUE is entered.

As we insert it into a transaction table, it can't be bigger then integer https://www.postgresql.org/docs/current/datatype-numeric.html

I think this has been taken care of, feel free to reopen, if you disagree.


module querystring-number does not provide an export named 'default'

Thank you so much, i ignore github message<EMAIL_ADDRESS>use chokidar in linux.

Yo, that's awesome! Nice work!
I'm currently working with SvelteKit and your package querystring-number gives error
"module querystring-number does not provide an export named 'default'"
Issue:
(svelte-zero-api/lib/index.ts)
import qs from "querystring-number";
Does not export default
Originally posted by @Refzlund in https://github.com/ymzuiku/svelte-zero-api/issues/1#issuecomment-907689663

Instead of querystring-number dependency, NodeJS has a builtin function URLSearchParams. It does the same thing.
const searchParams = new URLSearchParams(query)
url += "?" + searchParams;

#3 Removed querystring-number dependency
Secondly, SvelteKit doesn't do well with es/index.js. I have in my own project changed package.json to
"main": "es/index.ts"
I'm also working on a SvelteKit version of svelte-zero-api that also provides self-documentation (like Swagger). I will fork this Git and push it when it's usable.


Resolve warnings of hdd_reader

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
--- stderr: system_monitor
In file included from /usr/include/string.h:535,
                 from /usr/include/c++/11/cstring:42,
                 from /usr/include/boost/serialization/library_version_type.hpp:18,
                 from /usr/include/boost/serialization/map.hpp:28,
                 from /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/include/hdd_reader/hdd_reader.hpp:23,
                 from /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:20:
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘int get_ata_identify(int, HDDInfo*)’ at /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:223:10:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:34: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 20 bytes from a string of length 491 [-Werror=stringop-truncation]
   95 |   return __builtin___strncpy_chk (__dest, __src, __len,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
   96 |                                   __glibc_objsize (__dest));
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘int get_ata_identify(int, HDDInfo*)’ at /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:230:10:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:34: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 40 bytes from a string of length 457 [-Werror=stringop-truncation]
   95 |   return __builtin___strncpy_chk (__dest, __src, __len,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
   96 |                                   __glibc_objsize (__dest));
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘int get_nvme_identify(int, HDDInfo*)’ at /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:342:10:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:34: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 20 bytes from a string of length 4091 [-Werror=stringop-truncation]
   95 |   return __builtin___strncpy_chk (__dest, __src, __len,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
   96 |                                   __glibc_objsize (__dest));
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘int get_nvme_identify(int, HDDInfo*)’ at /home/kenji/autoware/src/universe/autoware.universe/system/system_monitor/reader/hdd_reader/hdd_reader.cpp:348:10:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:34: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ output may be truncated copying 40 bytes from a string of length 4071 [-Werror=stringop-truncation]
   95 |   return __builtin___strncpy_chk (__dest, __src, __len,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
   96 |                                   __glibc_objsize (__dest));
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~

Purpose
To resolve warnings.
Possible approaches
I'm not sure.
Definition of done
No error after -Wno-stringop-truncation is removed.

@ito-san Could you please take a look at this? :pray:

@kenji-miyake Could you please let me know how to reproduce this?

@ito-san Just removing this line.
https://github.com/autowarefoundation/autoware.universe/blob/391ebac4ebf8aeae386c2726929cdb1b334e0b7c/system/system_monitor/CMakeLists.txt#L8
It might not be reproduced with Ubuntu 20.04. I used 22.04

I found the source code is not up-to-date. Thanks.


w07d02 Pixart homework assignment complete

This one was neat!

This looks great, Karen! Way to go! It looks like you were spelling something out on your PixelArt page, but I can't figure out what it was. Oh, well.
Major bonus points on your tremendous level of code-commenting!


Use buildpulse/test-reporter for big speedup

Remove dependency on aws-cli orb
Use buildpulse/test-reporter for smaller installation footprint and faster execution
Deprecate the obsolete buildpulse/setup command

Released as version v0.4.0: https://circleci.com/orbs/registry/orb/workshop64/buildpulse?version=0.4.0


Flux (and apps) in MC logs visibility to customers

From a  customer request:
In the context of Management cluster auth via Dex against Okta , the customer requested:
Need logs visibility for Flux (as an admin)

kubectl logs -n flux-system kustomize-controller-5bd7f98f56-frkd
TODO: check whether this is possible

@marians @pipo02mix if some context is missing, please addi it :)
cc @giantswarm/team-honeybadger  @MarcelMue

I'm quite strongly against allowing the (unfiltered) log access. It's a managed solution - customers should not have access to anything in flux-system by principle.
I'd rather us expose the Flux-related Prometheus metrics, preferably through an exporter which grants us ability to filter them, than give direct access to logs.

Also, for the record, which customer is requesting this?

(1) and (2) are very much separate requests. I suggest to split them. (2) is quite customer specific, so potentially worth discussing in a non-public repo.

split, see https://github.com/giantswarm/giantswarm/issues/21454

IMO makes sense to give them view access for the flux that managed the apps/cluster they install (not the one manage our components). If we put that in a dashboard is even better

The problem is that even if we figure out the permissions problem reasonably, there's no way we can do org separation in logs. I really don't see much value in here, as really flux's CR statuses are pretty verbose. Do you have as specific use case, where logs were really needed to debug a problem?

To my understanding, org separation is not an issue here. This is about access for cluster admins, who are bound to the cluster-admin clusterrole currently via the customer's default admin group customer:rg_okta_giantswarm-admin.

we will bring this to SIG product to discuss if we shall provide access or not to logs for managed apps on the MC to the customers

What do you think of this @JosephSalisbury @weatherhog @puja108 ?

I reckon this can be done with https://github.com/giantswarm/roadmap/issues/311, sure
up to @weatherhog for priority, but iirc it's soon

the use case would be
As a cluster admin, I would like to debug why some (managed) apps are not installed in my workload cluster
I am not sure if they need logs or status show enough. But IMO getting logs from flux is not something will hurt us

Regarding which logs the customer wanted to see, that info is very detailed: those of the kustomize-controller-* pod in the flux-system namespace.

Discussion in SIG Product Sync:

Customers should be able to access logs for components in MC
Pinging @weatherhog & @JosephSalisbury, this is dependent on Atlas' larger logging story
We want to be aware that access to logging (as with metrics) is only available to an admin group (not all users)
@gianfranco-l / @PrashantR31 it might be most straightforwards to work out who should give access to the customer, and then create an appropriate Role / RoleBinding, to get the customer issue sorted - it's not a product solution, but solves for the customer until the product solution is sorted
currently, we don't store these logs

@giantswarm/team-atlas , tangent question: does our Loki support SSO ?

@PrashantR31 Loki itself does not provide any authentication mechanisms. So in the End this a no to SSO support. If authorisation is needed for loki this is mainly dependent on the customers preferred way. It could be a combination out of loki and oauth2-proxy or it also could be loki saas.

Thanks @weatherhog ,  just too bad Loki does not have SSO support
But what I was thinking that:

If Loki can be installed on the MC's where Flux is installed and all the logs will go there for admin access only.
And if Grafana is on the MC we could provide just a few basic dashboards views for the customer, or even use the Grafana cloud (if this is possible)
Extending that, if we add alerting on logs that could give a complete observability solution for the customer Admin users.
Grafana has SSO capabilities, so we could allow only allow the admin group to certain dashboards.
These are some thoughts and do not know how much in that is feasible or is in line of what we are providing.

Fyi @PrashantR31 Atlas already has a story about what you described #311

Action from refinement in Rainbow :

[ ] Rainbow create a detailed specs so as to help HoneyBadger to create the Role and Role-binding  to the default Admin group in flux app via config.
[ ] Handover to HoneyBadger for implementation

As a spec, we would need the following Role in the flux-system namespace:
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: read-pods-and-logs
  namespace: flux-system
rules:
- apiGroups: [""]
  resources:
  - pods
  - pods/logs
  verbs:
  - get
  - list

To assign this role to the customer's cluster admin group, a RoleBinding like the following would be required:
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: read-flux-logs
  namespace: flux-system
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: read-pods-and-logs
subjects:
- apiGroup: rbac.authorization.k8s.io
  kind: Group
  name: "WRITE_ALL_GROUP_NAME"

The value for WRITE_ALL_GROUP_NAME can be found in https://github.com/giantswarm/config/installations/INSTALLATION/apps/rbac-operator/configmap-values.yaml.patch
Example

Next step: manually deploy, get customer confirmation.

During planning, Gianfranco will check if HoneyBadger can now takeover as specs was provided by Marian already.

added to current sprint, someone from the team @giantswarm/team-honeybadger  will pick this up and implement it :)

This also came up with another customer, and they'd like to get log access to more than just Flux. As Timo mentioned above we should see if we could make access to logs a default for all pods/ns (or just have few exceptions where we see privacy concerns).
As this becomes a general request around access on the API level, would Rainbow feel responsible for it or at least driving it with team's help?

I tried to look at implementation in a "quick and dirty" way but we have to do a little more thinking:

The WRITE_ALL_GROUP_NAME is only available in the config repo it seems
The management-clusters-fleet repo which could hold these resources, does not have access to variables from the config repo
rbac-operator has access to the variables from the config repo BUT does not have an operator resource which would currently fit to create resources in the flux system namespace

To me the best option seems to be to add a new operator resource to rbac-operator which handles these variable bindings. Does anyone have a better idea @giantswarm/team-honeybadger ?

Alternatively, we'd make it a default and do not need to react on variables, or not?

Alternatively, we'd make it a default and do not need to react on variables, or not?

I think the issue is that the WRITE_ALL_GROUP_NAME is somehow linked to the OIDC provider used and therefor variable :/

Yes, every customer has their own idea of group naming in their identity provider. So the value for WRITE_ALL_GROUP_NAME is individual.

Any update on which option is the chosen one?

both options require quite some effort: so what started as a "quick workaround" is actually quite some effort for being just a workaround. given that the product solution is in the works and honeybadger team has other higher priorities at the moment (and no bandwidth), this is currently being postponed at later stage (it has been moved to the board "future > 6 months" of the roadmap)

@gianfranco-l what is the main blocker for adding the relevant permissions to the current automation SA? This is a relevant request for users of Flux and would remove many support requests.
Would be happy to work with customer to make this work.

ping @piontec

The main issues that we see with that are:

We still don't get "why": flux presents reasonable messages in its CRs, we use them all the time and very rarely check the logs. What does the customer need that is in the logs only? We also never evaluated logs in context of how much is available there. For sure, we will expose some information about all the Organizations (but I guess it's OK for the automation SA anyway).
This solution is just ugly. We need a highly targeted, custom access rule for a single deployment - sure, we can add it, but making the automation SA a bag of trash where we dump everything that is no match anywhere else seems like an ugly idea to me.

To wrap it up: I think it really makes sense to wait for the MC wide central logging solution (#311) that will solve this on a general level. It would also help to understand which log entries are that important.

Yeah, we want to go deep on understanding why but there are some cases where its useful:

Something not reconciling at all (could be due to incorrect labels..)
Flux crash looping

Also I would say that this is not only for Flux, as other components might be coming like Crossplane, Secret Operator...
I agree that automation SA might not be the right place we could make another one to list pods and read logs from giantswarm namespace.
We are hindering advanced customers from debugging and forcing ourselves to do it which I think is counterproductive. If in the future we can provide something nice for them to check the logs then it would be amazing and we may introduce some learnings in the way they use the logs.
Would you agree on having a new SA to read all logs from giantswarm namespace a solution until we have  the full logging platform? I would organize among SA to make this work

Yeah, that is it, a new ClusterRole. Not sure we can limit by pods inside a namespace though.
Not sure how we can evaluate what logs come of every operator but I would assume no credentials are leaked at all, maybe account IDs and other infra resources names but I think those are also available in the CRs. In any case will try to find out if we can limit to specific pods and then we add as needed.

If we leak no credentials, I think we're good - that was my only concern :+1:

Imo your last comment @piontec should be our only concern. The "why" isn't the problem. I think @paurosello described it well and imo customers should have access to all logs on the management cluster. There will also be different roles in the future. But next to central logging we need to have native logging (kubectl logs) as well.
At the moment I would see four use cases and we might already separate them

Flux logs
CAPI controllers logs
Organization namespace (eg customer controllers)
All MC logs

Going one by one component is a first option. And then we need a way to become confident to create a role that opens up all logs.
@piontec @gianfranco-l depending on the amount of work that is necessary, can you check if you can enable flux logs so this story becomes unblocked?
@TheoBrigitte @weatherhog can you take the general story around access to MC logs into Atlas and think about it more holistically? Afaik you already have a story about letting customers monitor their own controllers on the management clusters too.

@teemow We will provide access to the logs to customers once we have a logging solution up an running (one central Loki).
The main issues will arise from how we want to do multi-teancy but this is in refinement.

@QuentinBisson what is the reason to wait for central logging? As I mentioned I think customers should be able to use a simple kubectl logs for all components in the MC too.

I was answering about the log story regarding atlas and after rereading, I understand how it can have been misinterpreted 😅 .
I agree customers should be able to access the logs using kubectl logs on the MC anyway

I agree customers should be able to access the logs using kubectl logs on the MC anyway.

My question was if Atlas can take this too. Somebody needs to think about the general concept of how we structure access to logs on the management cluster.

Flux has a strict set of pods, so targeting them with RBAC shouldn't be that hard. @paurosello , have you already started, do you have something you can share?
@gianfranco-l , as we need to prioritize this, I'm putting it back into our Inbox.
@teemow Generally speaking, we can "just" grant the (Cluster)Role access to pods/log everywhere, but I really don't feel comfortable doing that - personally, I have no idea what we might leak in the logs. Is there a reasonable (time, effort) way to check this? Or are we sure that operators we run (ours, external, upstream) never log anything like access tokens?

I agree customers should be able to access the logs using kubectl logs on the MC anyway.

My question was if Atlas can take this too. Somebody needs to think about the general concept of how we structure access to logs on the management cluster.

Yes we can create the cluster role with potential restrictions if we think it's needed but the binding part from customer to role should be elsewhere (i.e. done by another team).

A new role has been introduced int he flux-system namespace with RoleBinding to default:automation and the customer cluster admin group.
This has been tested by Adam from THG and provides him with the log access he requires for Flux.

adding to @giantswarm/team-atlas board so that they can work on their part of the scope as outlined here

@gianfranco-l @mproffitt we have another request to give access to app-operator logs to debug the installation of an app (ArgoCD) on the management cluster. Can @mproffitt enable this similarly to how he did this for flux?
@TheoBrigitte as you can see this is getting more and more important. Imo customers would also like to inspect logs of capi controllers soon. So a more general set of permissions that allow customers to read the logs on the management cluster would be good. And I don't mean yet via loki. Just via kubectl logs.

@teemow Exposing the logs from pods within the giantswarm namespace isn't a problem and I already had an internal ticket for this at https://github.com/giantswarm/giantswarm/issues/24033 although it is not possible to restrict to just the affected pods ((app | chart)-operator-*) - customers will gain access to all logs inside that namespace and we have to question if that is something we want to allow, or if there are valid reasons we shouldn't be allowing access to all logs inside that namespace
IMHO requests seem to be leaning towards granting more and more privileges to things we own on the management clusters and this is something I consider to be potentially dangerous. We need to consider how we can best protect our resources whilst enabling the customer to achieve their own product vision.

I hear your worries. But for me the benefits and our general philosophy around shared responsibility, knowledge sharing and providing a transparent platform and not a blackbox to the customers outweights this imo. This enables customers to solve their own problems much quicker and not having to wait for our support to respond. This is good for the customers and good for us.

Why does giving access to logs give access to secrets? Can you explain this a bit better?
I disagree that it is a "throw a towel" situation. We need to think about what is important. And UX and security need to go hand in hand. This is a challenge and yes it needs thorough investigation. Just simplifying the role of the customer to admin permissions is not what we should do imo. This would leave all the work and mistakes to the customer. Yes we maybe want to give admin permissions in general. But we also need to make sure to have well defined roles so it is easy for the customer to follow a least privilege principle for both users and applications.

I agree about well-defined roles. What I mean that is hard or maybe even impossible for us is to judge if our MCs are still secure giving the following facts:

we allow them to directly use our components, like app-operator and chart-operator, which run on admin premissions
we're introducing more and more permissions for customers:

logs access
custome operator roles

incoming crossplane
plus everything we already have on MC.

What I want to say is   that it is already super hard to tell if the sum of all mentioned above is secure or not. With each custom role, we make it even more complex and we increase the probability that an attack vector exists that allows you to effectively get cluster-admin as a customer anyway.
As such, maybe we shouldn't protect our Secrets at all cost, but instead make sure that secrets we get there are safe to read by s customer. Then, we can tell the customers "it's OK to run this or that with cluster-admin, but please be aware of consequences; still, if you really want to, you can". And for us, since the customer already has potential admin access, we don't have to make sure that it can't read something from the giantswarm namespace, but only that it's not "wildely" possible for no reason.

:100:. We aren't there yet. First step is to work on our secret management and second is to write more documentation about the management cluster structure etc. Customers need to fully understand how the management cluster works before they do something with admin permissions. And our goal should still be to define proper roles so that admin permissions for the customers are only necessary in very specific (and currently unsupported) use-cases.
This would enable customers and they aren't blocked by us. Less pressure on our teams. But it also adds responsibility to the customer as they can break more things. We need to make this clear and also build a safety net.
But I like this as a goal to work towards. @puja108 wdyt? I'll add a note to our board so that we can create a proper epic about it in horizon first.

Yeah, I'm also evaluating and talking to upbound and Redhat around kcp towards such use cases. It could enable better interfaces and tighter security within our MCs. Some of these topics also go towards a possible MC team within KaaS to improve architecture of MCs. Definitely a lot of sub-stories to it, but let's start with the bigger picture in Horizon for now.

Closing, as it's done.


bib failed to build out centos stream10 anaconda-iso on x86_64 with error:error: cannot build manifest: cannot depsolve: running osbuild-depsolve-dnf failed

attempt to build out centos stream 10 iso from below command:

sudo podman run --rm -it --privileged --pull=newer --security-opt label=type:unconfined_t -v /var/lib/libvirt/images/output:/output -v /var/lib/libvirt/images/config.json:/config.json   -v /var/lib/libvirt/images/auth.json:/run/containers/0/auth.json  quay.io/centos-bootc/bootc-image-builder:latest  --type anaconda-iso --tls-verify=true  --config /config.json  quay.io/centos-bootc/centos-bootc:stream10  --chown 107:107  --rootfs ext4

2 .It throw below error, reminding: error: cannot build manifest: cannot depsolve: running osbuild-depsolve-dnf failed
(92lts-p3-ve) [root@dell-per430-17 tp-libvirt]# sudo podman run --rm -it --privileged --pull=newer --security-opt label=type:unconfined_t -v /var/lib/libvirt/images/output:/output -v /var/lib/libvirt/images/config.json:/config.json   -v /var/lib/libvirt/images/auth.json:/run/containers/0/auth.json  quay.io/centos-bootc/bootc-image-builder:latest  --type anaconda-iso --tls-verify=true  --config /config.json  quay.io/centos-bootc/centos-bootc:stream10  --chown 107:107  --rootfs ext4 |tee failiso.log
Generating manifest manifest-anaconda-iso.json
Trying to pull quay.io/centos-bootc/centos-bootc:stream10...
Getting image source signatures
Copying blob 7a090810a9fc done   |
Copying blob 7a090810a9fc done   |
Copying blob 0a2954cfdf8d done   |
Copying blob 0a2954cfdf8d done   |
Copying blob 7a090810a9fc done   |
Copying blob 406c209b794e done   |
Copying blob 1a7b9969979e done   |
Copying blob 7a090810a9fc done   |
Copying blob 7a090810a9fc done   |
Copying blob 7a090810a9fc done   |
Copying blob 7a090810a9fc done   |
Copying blob 406c209b794e done   |
Copying blob 712b0e04f720 done   |

...
Copying config 6d4ae0c51c done   |
Writing manifest to image destination
Errors during downloading metadata for repository 'appstream':
  - Downloading successful, but checksum doesn't match. Calculated: 8170d4362c6a02f263f54a729ed0069dc7f3e5dc0d22e360e9a88a40f540e74185ae905908f345807eab94dcb54bb4154399e0817461e7a2b593e0be8b90ca99(sha512)  Expected: f528006c8b2c0678909eae21ade540f1d10c522118e5531f019d1d14759bd41dd8bfd0f17fdfe4d0d3b5c3b6d4badd62115bf23b94959d0eb06bf2ce78b602b5(sha512)
RepoError: There was a problem reading a repository: Failed to download metadata for repo 'appstream': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
2024/09/05 02:15:17 error: cannot build manifest: cannot depsolve: running osbuild-depsolve-dnf failed:
DNF error occurred: RepoError: There was a problem reading a repository: Failed to download metadata for repo 'appstream': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

Newly error log information:
2024-10-22 14:47:03,539 avocado.test stacktrace       L0049 ERROR| stdout: b'Generating manifest manifest-anaconda-iso.json\r\nTrying to pull quay.io/centos-bootc/centos-bootc:stream10...\r\nGetting image source signatures\r\nWriting manifest to image destination\r\nNo match for argument: gdisk\r\nNo match for argument: libreport-plugin-bugzilla\r\nNo match for argument: libreport-plugin-reportuploader\r\nerror install_specs\r\nMarkingErrors: Error occurred when marking packages for installation: Problems in request:\r\nmissing packages: gdisk, libreport-plugin-bugzilla, libreport-plugin-reportuploader\r\n2024/10/22 18:47:01 error: cannot build manifest: cannot depsolve: running osbuild-depsolve-dnf failed:\r\nDNF error occurred: MarkingErrors: Error occurred when marking packages for installation: Problems in request:\r\nmissing packages: gdisk, libreport-plugin-bugzilla, libreport-plugin-reportuploader\r\n'
2024-10-22 14:47:03,539 avocado.test stacktrace       L0049 ERROR| stderr: b'time="2024-10-22T14:46:31-04:00" level=warning msg="The input device is not a TTY. The --tty and --interactive flags might not work properly"\n


[EmbeddingAPI-autocase] Add autocase for XWalkView new load interface…

… with specified HTTP headers
-Add autocase for XWalkView new load interface with specified HTTP headers
-Cover the XWalkActivity and XWalkInitializer two ways
Impacted tests(approved): new 2, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 0, block 0
https://crosswalk-project.org/jira/browse/XWALK-5419

@Shao-Feng please help to review.


cast button not visible?

I'm running the app in iOS simulator (iOS 9.0) and there's no cast button visible on the nav bar. It seems that the button is thus rendered onclickable. But the app did show the 'tap here to cast' intro. So why is the button image not showing up?
Inside [MediaTableViewController viewWillAppear:] I put a breakpoint and logged the folllowing
(lldb) po _castButton.imageView
<UIImageView: 0x7fd5e0592110; frame = (0 0; 0 0); clipsToBounds = YES; hidden = YES; opaque = NO; userInteractionEnabled = NO; layer = <CALayer: 0x7fd5e05926b0>>
(lldb) po _castButton.imageView.image
nil
(lldb)

Nevermind

@CapnSpellcheck  how did you solve i am experiencing the same issue >
Thanks in advance.

I changed Wifi network, the Cast Now dialog always shows up, even when you are not on the same Wifi network.


feat/widget_banners_and_mrecs

https://github.com/AppLovin/AppLovin-MAX-Flutter/issues/26
https://github.com/AppLovin/AppLovin-MAX-Flutter/issues/16

Error: Can't have modifier 'static' here.
Try removing 'static'.
  static void setMRecPlacement(String adUnitId, String placement) {
  ^^^^^^

Error: Can't have modifier 'static' here.
Try removing 'static'.
  static void destroyMRec(String adUnitId) {
  ^^^^^^

Error: Can't have modifier 'static' here.
Try removing 'static'.
  static void setInterstitialListener(InterstitialListener listener) {
  ^^^^^^

and other similar function
Flutter 3.0


feat(router): enable hash routing

depends on https://github.com/yoshuawuyts/sheet-router/pull/54
fixes anchor link jumps
yay!

Should be cool :sparkles:


How to use a restricted API key?

I'm trying to set a restricted API key. According to Google, there are the following ways to do it:

HTTP referrers (web sites)
IP addresses (web servers, cron jobs, etc.)
Android apps
iOS apps

When I set iOS apps to my bundle identifier (same for debug and production) I'm unable to use the API. Doing some research it seems like the Web API should use HTTP referrers or IP addresses. Since the IP address will change with the app user, that leaves us with using a HTTP referrer.
Assuming my reasoning above is correct, how would I go about setting the HTTP referrer for this library?
Thanks,
Oskar

Hi @oskarth
I see your concern.
I saw some people have used X-Ios-Bundle-Identifier header when accessing Google Cloud Vision API, but after testing it out in sample app, this trick didn't work.
After an hour of research it looks like there's no way of restricting Google API request in React Native at all.

We can keep this issue open, maybe some Google expert comes over and suggests something.

I opened a SO question. Hopefully someone can shed some light in there.

Thanks @atlanteh

Solved by #170

Hi,
I'm using the version 1.3.5 and I'm using the query.origin to pass Referer request header as prop (as allowed by the #170 ). However this results in warning "Browser API keys cannot have referer restrictions when used with this API." and doesn't work.
Did you guys succeed in having restrictions on Google API key? Could someone help me with this, please?
Thank you,
Leo

@lbrdar, sorry hearing that it didn't work for you. I'll try looking for more info about it.
But anyway, you still can simply solve this by creating another key or following this tutorial.

Hi guilhermepontes,
thank you for responding so quickly.
From the link that you've provided:

You can change your restriction from a browser restriction to a server restriction by using IP addresses to restrict access, instead of browser referrers.

But what IP address should I use since this is an mobile app and every client have different IP address? I'm not running this on my server, I'm just using this npm package in my mobile app.

@lbrdar Did you ever figure this out?
@guilhermepontes Any update on this?

This still seems to be an issue -- I can't see a way to use any type of restricted API key with this package.
It might make sense to allow developers to implement the Places API on their own server, and just use this package for displaying results. Would this be a possible solution?

This is still an issue affecting anyone trying to use any Google Maps APIs from React Native. The native SDKs have this ability but it seems no up-to-date public React Native version exists. RN apps have to use HTTP requests from the client which are nearly impossible to restrict.

Why is this closed?

This needs to be solved one way or another.  :cry:
The only solution I see now is  to proxy the google API using an our own server and use some authentication mechanism to restrict usage.

I'm sorry to have to say this here.
Maybe we can use https://github.com/tolu360/react-native-google-places
That library imlplements native SDKs

How do i use the Android apps restricted API in my application?
Error - his IP, site or mobile application is not authorized to use this API key. Request received from IP address 197.XXX.XX.XXX, with empty referer

I dont get any solution for places.
My api keys are restricted with package name of my app 'com.myApp'
I tried adding following lines in AndroidManifest.xml
<meta-data android:name="com.google.android.geo.API_KEY" android:value="<My_API_KEY"/> and still not working.
any one has any solution or is there an issue with react-native with restricted keys
Or is it that android restricted keys dont work for places api that uses web API's

Unfortunately web apis cannot be restricted by package name. The only solution is to use a module that uses the android/ios sdk and with that you'll be able to restrict your api

You can now set a 'refer' prop in v1.4.2

@bell-steven
The 'refer' prop has been removed as of 2 days ago (1.7.0)
Is this package just unusable in any production app since there is no way to restrict the key?

@DranoelMit Yes, indeed it was removed (it actually never worked).
In terms of the package being usable in production, that is something that every user of this package has to decide for themselves.  For some it is a deal breaker, and many others have no need for a restricted key.
Just to be clear, you can "restrict" the key, but "application restrictions" cannot be used.
It isn't very hard to find someone else's Google API key online, without having to resort to inspecting an app's network traffic.  Couple that with the fact that there is nothing inherently "secret" about a Google Places API key, and they can always be switched out, it is a tradeoff that many people are willing to make.
This package does not include the Google SDKs, by design.  This benefit comes at the expense certain features, such as restricted api key.
You can try using react-native-google-places, I am assuming it supports restricted keys, as it includes the native Google SDKs.


Release new gem

0.0.2 is old...

@potato2003 ping. I think we can release gem once.

@gotokatsuya (cc: @sonots) we released new version of gem.

https://rubygems.org/gems/embulk-input-bigquery/versions/0.0.3

@potato2003 @sonots super thanks!


Create and populate htpasswd file if missing

If htpasswd authentication option is configured but the htpasswd file is
missing, populate it with a default user and automatically generated
password.
The password will be printed to stdout.
Signed-off-by: Liron Levin<EMAIL_ADDRESS>

CC @dmcgowan

Thanks @dmcgowan, I've updated the review.

@dmcgowan PTAL

@dmcgowan anything else I need to change?

@tiborvass @dmcgowan  PTAL.

@tiborvass @stevvooe @dmcgowan what's required to get this merged?

Thanks @stevvooe @dmcgowan @endophage I've updated the PR according to your comments.

Can you rebase this to get CI passing, circleci does not seem to be building from a merged branch even when I kicked it to run without cache

Thanks @dmcgowan, The tests passed now.
I'm not sure the code coverage check is related to my change (they appear to be failing in other PRs)

@dmcgowan we broke something here. New PRs are not passing failing on gometalinter checks.
gometalinter --config .gometalinter.json ./...
registry/auth/htpasswd/access.go:1::warning: file is not goimported (goimports)
make: *** [check] Error 1

We cannot merge old PRs that haven't run Travis, we can kick it off by opening a dummy PR with the change commit or having them rebased

@dmcgowan agreed.
My bad on this one.


Updated ForkError.getMessage() to include exception's original name.

See #2028.

Can one of the admins verify this patch?

LGTM, only there was strange error on Travis in scripted dependency-management/*2of2 so I restarted it.

Cool, Travis passed now.


Cannot read properties of undefined (reading 'filter')

Error with %groups,
Urbit Kernel Version (b4l49)
Urbit Runtime Version 3.0
TypeError: Cannot read properties of undefined (reading 'filter')
    at https://btc.urbitstars.org/apps/groups/assets/index.52dc4675.js:36:50587
    at Object.Jd [as useMemo] (https://btc.urbitstars.org/apps/groups/assets/react-beautiful-dnd.fde4d763.js:19:57586)
    at f.useMemo (https://btc.urbitstars.org/apps/groups/assets/@tlon/sigil-js.4fa95bd4.js:12:5789)
    at Ia (https://btc.urbitstars.org/apps/groups/assets/index.52dc4675.js:36:50573)
    at Kn (https://btc.urbitstars.org/apps/groups/assets/index.52dc4675.js:44:19742)
    at rm (https://btc.urbitstars.org/apps/groups/assets/index.52dc4675.js:48:265477)
    at Kl (https://btc.urbitstars.org/apps/groups/assets/react-beautiful-dnd.fde4d763.js:19:52884)
    at Ka (https://btc.urbitstars.org/apps/groups/assets/react-beautiful-dnd.fde4d763.js:19:62361)
    at mf (https://btc.urbitstars.org/apps/groups/assets/react-beautiful-dnd.fde4d763.js:23:9604)
    at pf (https://btc.urbitstars.org/apps/groups/assets/react-beautiful-dnd.fde4d763.js:23:947)

no longer reproducible, you may close ticket

It appears to be working now, but I will try to reproduce.  There was a notice of something "updating in the background" although the message disappeared after a few seconds.


Meteor + v4 = ❤

https://github.com/aldeed/meteor-autoform-bs-datetimepicker/issues/7

I  don't know anything about meteor but you can add install instructs to the wiki or email me what a user of meteor would have to do to get that working and I'll add it. Since this isn't really an "issue" I'm going to close it.


Bad webdriverio version

It looks like there have been some recent breaking changes in webdriverio that have caused our automated testing to fail. I was able to get the tests running again by changing this line in the Spectron package.json from "webdriverio": "^4.8.0" to "webdriverio": "4.8.0"

Confirmed this fixes the issue for me as well.
Error was:
    TypeError: this.writeStream.write is not a function
        at Logger.write (/project/node_modules/webdriverio/build/lib/utils/Logger.js:173:34)
        at Logger.log (/project/node_modules/webdriverio/build/lib/utils/Logger.js:197:22)
        at Logger.command (/project/node_modules/webdriverio/build/lib/utils/Logger.js:211:22)
        at EventEmitter.<anonymous> (/project/node_modules/webdriverio/build/lib/utils/Logger.js:78:23)
        at emitOne (events.js:96:13)
        at EventEmitter.emit (events.js:188:7)
        at RequestHandler.create (/project/node_modules/webdriverio/build/lib/utils/RequestHandler.js:211:31)
        at Object.init (/project/node_modules/webdriverio/build/lib/protocol/init.js:57:32)
        at Object.exec (/project/node_modules/webdriverio/build/lib/helpers/safeExecute.js:28:24)
        at Object.resolve (/project/node_modules/webdriverio/build/lib/webdriverio.js:190:29)

I just ran into this issue today, too. Wouldn't it be useful for spectron to add a shrinkwrap or package-lock file to prevent such issues in the future?

Confirmed our team having the exact same issue, @bencon fix worked.

Fixes were committed to the webdriverio repository, and now Spectron is working again as is (without the package.json hack). Therefore, I'm going to close this issue.


[SOR] Update README

Problem:

The README is not up-to-date.

TODO:

Update the README file.

Feedback:

Add short descrtiption for PAYMENT_SIGNING_KEY_CBOR_HEX and COLLATERAL_UTXO_REF
Kupo docs could be imrpoved (potentially to be tackled in a different issue)