Performance of Drawer CSS Transition

I have been working on my own theme using Timber, and I believe there is an issue with how the drawer transition works. I have done some tests and it looks like because the height of AjaxifyDrawer is being animated, it is pushing (almost) the entire DOM tree down. This isn't too expensive performance wise with 'bare bones' styling, but once you start adding styles everything starts to add up. In all of these examples I have toggled the cart on and off a few times. Take look at these comparisons (not the prettiest examples, but it gets the point across :) ):

http://timber-test-3.myshopify.com: Stock Timber theme. Not too bad performance wise.

http://timber-styled.myshopify.com: Stock Timber theme with styling. Significant performance decrease.

http://timber-styled-drawer-at-bottom.myshopify.com: Stock Timber theme with styling, with drawer position at bottom. DOM tree does not have to be moved so performance is very good.

http://timber-styled-refactored.myshopify.com: Stock Timber theme with styling, refactored to increase performance. Take a look at the drawer-transition-test branch I pushed to see exactly what I changed.
I found this article: http://www.html5rocks.com/en/tutorials/speed/high-performance-animations/ very useful in figuring out what was going on.
Finally, visually, I can see a big difference in the quality of the animation on iOS devices. Compare all of these examples on an iOS device and you'll see what I mean.

Ah..looks like I can't push to Timber.git. Well, you can take a look with Chrome inspector/Firebug, etc to see what I've done.

Great testing and really appreciate it. We're in the early stages of redesigning the ajax cart for a more mobile-friendly approach, and for some alignment with a new mobile navigation. Needless to say performance is a huge consideration that will be at the forefront of the code. The html5rocks link you sent over is invaluable and I'd also highly recommend it for anyone working on transitions.
Because of the new approach coming soon(ish?), we're not going to modify the existing cart transitions.

Glad you found it useful!
Not sure if saw my other comment in another issue thread, but I am actually working on my own modification to Ajaxify.js to incorporate a mobile nav (as well as other components). I am working on my Shopify application and getting something ready to show you all :). You can take a look at https://demo-store-1-21.myshopify.com/ and see what I have done so far.


Add support for items-feed endpoint

Motivation
Allow developers to fetch all content item variants from the new \items-feed endpoint.  This offers developers a way to export an entire project no matter the size.
Proposed solution
The content is is provided in small chunks together with a continuation token for the next chunk. The continuation token is sent in X-Continuation header both for request and response. Should the response from Delivery API contain the token, there are additional items to fetch. If the request does not contain the continuation header, Delivery API will return the first chunk.
Filtering parameters are same as for items endpoint but paging and depth are not supported.
The response has also the similar structure to items endpoint but paging object is missing and modular_content contains only components.
Implementation details for consistency: (name casing should be adapted according to the rest of SDK)
Add a new method to DeliveryClient with a name GetItemsFeed(). The method should support the same filtering parameters as GetItems() except for depth, skip and limit and return a content items variants feed.
The feed contains a bool property HasMoreResults that is true if the first batch was not yet fetched or there are more items to fetch (indicated by a continuation header in the previous response). The feed also contains a method FetchNextBatch() that would retrieve the next response from \items-feed endpoint.
Additional context
See .NET SDK for reference code

+1 this is sorely missed from the delivery SDK. any indication of when this might be looked at?


Delete variables from the database

There is currently no way to delete variables from the database, which is very annoying if you've e.g. renamed a variable and want to delete the old one.

Let's keep this open until I fix the multiple-GUIs issue: https://github.com/European-XFEL/DAMNIT/pull/180#issuecomment-1916448466

Changed the status as there is a pending issue


update arm to auto create app registration

Hi @code4clouds (Julio)
Keen on your thoughts.
Changes
When Appregistration is passed empty
Create new Appregistration and Appsecret
Get URLS after ARM deployment
Assigned redirect urls to app registration
Add User.Read scope(used cli for this***)

Already implemented as part of a different PR.


Added evilIcons support for Icons

Fix for issuecomment https://github.com/GeekyAnts/NativeBase/issues/1468#issuecomment-369987482

@akhil-geekyants Include EvilIcons with typescript
Also include font families in alphabetical order in both these files

@SupriyaKalghatgi added the changes mentioned.


Fix insert error handling & fix testDeletePartitionWhileBulkInsertingData

A IndexNotFoundException in the UpsertByIdTask could be swallowed.
In addition this commit changes the tests in
PartitionedTableConcurrentIntegrationTest to be less resource intense.
There was a chance that the first requests would run into a timeout when
creating the index + waiting for the shards to become active.
This could even lead to a "shard leak" because the test could finish
with the request still being active.
(No changes entry because this didn't occur in 2.0.0, but would be introduced as bug in 2.0.1 without this fix)

Codecov Report

Merging #5710 into master will increase coverage by 0.08%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #5710      +/-   ##
============================================
+ Coverage     82.94%   83.02%   +0.08%
- Complexity    11795    11807      +12
============================================
  Files          1394     1394
  Lines         45318    45321       +3
  Branches       5607     5607
============================================
+ Hits          37591    37630      +39
+ Misses         5114     5085      -29
+ Partials       2613     2606       -7

Impacted Files
Coverage Δ
Complexity Δ

...a/io/crate/operation/projectors/RetryListener.java
93.33% <ø> (ø)
5 <0> (ø)
:arrow_down:

.../crate/executor/transport/task/UpsertByIdTask.java
89.85% <50%> (-1.26%)
40 <3> (ø)

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...in/java/io/crate/data/CollectingBatchConsumer.java
69.23% <0%> (-15.39%)
4% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
72.97% <0%> (-13.52%)
8% <0%> (-1%)

...n/java/io/crate/planner/projection/Projection.java
90% <0%> (-10%)
6% <0%> (-1%)

...crate/planner/projection/MergeCountProjection.java
63.63% <0%> (-9.1%)
5% <0%> (-1%)

...ration/reference/doc/lucene/IpColumnReference.java
72.72% <0%> (-4.55%)
5% <0%> (+1%)

...te/blob/pending_transfer/PutHeadChunkRunnable.java
76.71% <0%> (-4.11%)
12% <0%> (-2%)

...nce/sys/check/node/DiskWatermarkNodesSysCheck.java
57.69% <0%> (-3.85%)
6% <0%> (-1%)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f12bf...c6dbac3. Read the comment docs.


Propagate variable absence

If a presence literal becomes itself absent then it should be set to false.

Fixed with the integration of scoped variables.


运行gcn_reddit_sample.cfg时出现问题

Hello, regarding the two example configurations mentioned in the README file, gcn_reddit_sample.cfg and gcn_cora_sample.cfg. I can run the latter normally, but the path for the former shows an issue. Should I download this dataset myself from the internet? Will there be graphs when running these examples? I apologize, I just learned this, I have a lot of questions. Looking forward to your reply.🤓🤓🤓
The error is as follows:
nts:/home/xxx/desktop/Sample-based-GNN-main/dep/gemini/filesystem.hpp:34: long int file_size(std::string): Assertion failed.stat(filename.c_str(),&st) == 0.

Thank you for your interest in our work.  The code repository contains only Cora datasets.
NeutronOrch needs 4 dataset files to run:

your_dateset.edge，a binary edge list file, used to store the graph structure.
your_dateset.feat，contains the feature of each node, the first number in each line indicates the node number, followed by the feature of the node.
your_dateset.label，contains the label of each node, the first number in each line indicates the node number, followed by the classification number of the node.
your_dateset.mask, contains the mask of each node, the first number in each line indicates the node number, followed by the mask of node (train, val, test).

We provide a python script to convert some commonly used datasets, please refer to data/generate_nts_dataset.py for details.
If you have any other questions please let us know.

Thank you for your help. I successfully downloaded several datasets using your method. However, when I checked the contents of the datasets, I found some errors. For example, when I re-downloaded the Cora dataset, an unknown error appeared in its mask file. Normally, the mask file does not have an unknown error. I re-downloaded the dataset several times, and I found that the error persisted. Could this be an error in the generate_nts_dataset.py function? The error message is as follows:_640 unknown 641 unknown......1707 unknown._I look forward to your reply!😊😊😊

Thank you for your help. I successfully downloaded several datasets using your method. However, when I checked the contents of the datasets, I found some errors. For example, when I re-downloaded the Cora dataset, an unknown error appeared in its mask file. Normally, the mask file does not have an unknown error. I re-downloaded the dataset several times, and I found that the error persisted. Could this be an error in the generate_nts_dataset.py function? The error message is as follows:
640 unknown 641 unknown......1707 unknown.
I look forward to your reply!😊😊😊

Hello, I would like to ask, does the code run successfully as soon as the following content appears? Will there be a comparison chart when the code runs? Looking forward to your reply.

Yes, NTO is working fine. More detailed output can be viewed in the log folder. You can adjust the hot vertices computation (i.e., "CACHE_RATE") to reduce CPU computation time and improve performance.

Okay, thank you very much for your help in successfully running multiple datasets. Wishing you a happy life and greater academic achievements!🥳🥳🥳


Add support for Extent

Nominatim returns a boundingbox which seems similar to the extent.
boundingbox: [
"47.4780623",
"47.8175234",
"8.8593204",
"9.7538633",
],

OpenCageData returns bounds, which could be converted to the extent.
"bounds": {
        "northeast": {
          "lat": 48.1799218,
          "lng": 11.5961796
        },
        "southwest": {
          "lat": 48.1399218,
          "lng": 11.5561796
        }
      }

I think there is no option for Gisgraphy.

yes, Gisgraphy doesn't return this.

There is a problem
"extent":{"extent":[13.2288599,52.3570365,13.5488599,52.6770365]}

Thanks for finding this. This indeed looks wrong. I think in this case the class Extent helps a lot. Jackson offers the annotation @JsonUnwrapped, which avoids creating "extent":{} but only creates all properties of the Extend class. I created a PR #47.


Components dennis

Added started code for components. Need to edit to see what we need modify/delete for our project

This should have the updated files now 👍🏻


Update update-client.sh

Generator script post-processing if failing if development status has / in it. this is true for stable releases.

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   94.56%   94.56%
=======================================
  Files           9        9
  Lines         681      681
=======================================
  Hits          644      644
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a91bc...c5347ac. Read the comment docs.

/lgtm

Thanks.


Cant figure out why flask click cli command is failing to run

Howdy,
I have a flask application and am using flask click custom commands.
When I run my debugpy, i get the prompt to add cli arguments which I do. I then can see those cli arguments in the vscode terminal. But my program runs and then just exits. I put a breakpoint in the first line of the method where you define the custom command and it never hits it.
I opened the debugpy output and there isnt anything helpful there.
2023-09-03 18:52:50.522 [info] DAP Server launched with command: /Users/hello/flask-server/.venv/bin/python /Users/hello/.vscode/extensions/ms-python.debugpy-2023.3.12121004/bundled/libs/debugpy/adapter

Here is the terminal logs
cd /Users/hello/flask-server ; /usr/bin/env /Users/hello/.venv/bin/python /Users/hello/.vscode/extensions/ms-python.debugpy-2023.3.12121004/bundled/libs/debugpy/adapter/../../debugpy/launcher 51808 -- /Users/hello/flask-server/test-command.py -u 1

Here is my launch config (which looks very similar to my other launch configs):
{
      "name": "Debugpy: Current File with Arguments",
      "type": "debugpy",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal",
      "envFile": "${workspaceFolder}/.env",
      "env": {
        "FLASK_ENV": "development"
      },
      "args": "${command:pickArgs}",
      "justMyCode": false
    },

Any idea how to debug why things arent working?

Hi @yawhide thanks for your issue report, this configuration is only to run a simple python file with arguments not a Flask appication. If you want to run a flask application with args, you can try with the Debugpy: Flask configuration, and then just add the "args": "${command:pickArgs}". Let me know if that works for you :D

Hi @yawhide thanks for your issue report, this configuration is only to run a simple python file with arguments not a Flask appication. If you want to run a flask application with args, you can try with the Debugpy: Flask configuration, and then just add the "args": "${command:pickArgs}". Let me know if that works for you :D

thanks for responding.
whe ni make a new configuration using click debugpy -> click flask, i see this as the configuration added:
{
      "name": "Debugpy: Flask",
      "type": "debugpy",
      "request": "launch",
      "module": "flask",
      "env": { "FLASK_APP": "wsgi.py", "FLASK_DEBUG": "1" },
      "args": ["run", "--no-debugger", "--no-reload"],
      "jinja": true,
      "justMyCode": true
    },

I then try to run this, i see the prompt to add the cli args which I add and then nothing happens (no command is run in the terminal inside vscode).
I then editted the configuration above to add command:pickArgs:
{
      "name": "Debugpy: Flask",
      "type": "debugpy",
      "request": "launch",
      "module": "flask",
      "env": { "FLASK_APP": "wsgi.py", "FLASK_DEBUG": "1" },
      "args": "${command:pickArgs}",
      "jinja": true,
      "justMyCode": false
    },

Again, when I now try to debug, I add the cli args and then nothing happens. No command is run in the terminal.
When I debug my flask app, i see a command being run in the terminal:
/usr/bin/env /Users/hello/.venv/bin/python /U
sers/hello/.vscode/extensions/ms-python.python-2023.16.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 52432 -- -m flask run --no-debugger

my flask configuration:
{
      "name": "Python: Flask",
      "type": "python",
      "request": "launch",
      "module": "flask",
      "envFile": "${workspaceFolder}/.env",
      "env": {
        "FLASK_ENV": "development"
      },
      "args": ["run", "--no-debugger"],
      "jinja": true,
      "justMyCode": false
    },

It seems debugpy is just not running? or doesnt like my cli args? something must be preventing from debugpy from running after I pick the cli args?
i tried many versions of cli args:

flask validate-script -u 187
-u 187
validate-script -u 187

if I were to run the cli tool on the terminal normally, i would run flask validate-script -u 187

H @yawhide the default config should run without any prompt, make sure that you are running the right one, if the error persist, could you send me the Python Debugger(debugpy) logs?


Filter by the entire endpoint

I suspect this is a bug, if not please close this PR.

A bug, thanks a lot!


Dockerize

Moves django project up one directory to repo root
Includes Dockerfile to build web application image
Changes to support postgres instead of sqlite (Includes rebuilding migrations)
Includes docker-compose file to run this app in a container with data stored in a postgres container

Launching docker-compose requires a handoverservice.env file with the following values:
HANDOVERSERVICE_SECRET_KEY=<Randomly-generated Django secret key>
HANDOVERSERVICE_DDSCLIENT_URL=<API endpoint for DukeDS>
HANDOVERSERVICE_DDSCLIENT_AGENT_KEY=<DukeDS Agent Key>

Fixes #12

@johnbradley You're welcome to review this if you like. It's actually pretty short - most of the changes are moving files around, making a copy of the settings, and re-generating migrations for postgres compatibility

LGTM.


fix: add missing debug dependency

fixes #809

@alanshaw can you rebase master onto this branch so that we keep the good practice of merging only green PRs?


Fabric js overlay multi select object

According to fabric JS sample at their home page ( http://fabricjs.com ), it should be able to do multiple select on the objects by pres and hold shift key + left click.
However when i have fabric js overlay on top of OSD, i can't have multi select object with same way. Is there any settings with OSD that make me able to do that?

I don't know of anything in OSD that would limit this... you should ask @altert in the project for the Fabric plugin:
https://github.com/altert/OpenseadragonFabricjsOverlay/issues

@iangilman , thanks for your advice. Will re post my question there.


Project Testcase 9_12

Summary
Everything is correct but somehow all the 4 and 5 are flipped
Screenshots (if any):

i created a method that looks at the earliest next available time and returns index and earliest next available time, if the customer is first in line, it will be transferred to serve with the selfcheckout index and time

not sure how u implemented your server class but i think u could check whether your code is creating new servers at each event correctly in terms of the server id and index. alternatively, you could track whether your code is correctly adding and assigning servers in ur simulator class. thats how i debugged most of my issues

I solved the error by fixing by canServe() method!
Initially I allocated the SSC that has the fastest available time,
but now I changed to go through from the first SSC to see which SSC is available at the given timing.

Hi, not sure if you have resolved this already, but I encountered a similar issue. Try streamlining the assignments to self checkout counters process by checking through the list of self checkout counters again instead of assigning customers prematurely, hope this helps!

Did you solve it @Gracesong146? If so, you may close the issue.


Minify::_combineMinify should combine before minifying

For sake of remote ClosureCompiler API use, we should bring back behavior of combining before minifying, maybe except for CSS.
See https://github.com/mrclay/minify/blob/master/min/lib/Minify.php#L490

Fixed in f67da8e359059ca877063411f6efd15cc5f9746a

Joe said: "I assume there are fewer API calls because now I just get the following error: "Minify: Exception in minifier: POST content larger than 200000 bytes""

The branch "issue6" moves Minify::_combineMinify to Minify_Process::process and adds support for minifier classes exposing the maximum bytes they can handle. d87780ecb8872a33bd93ed069431f4aff7d38e01


yojson home page is dead

Looks like the home page of yojson where I used to look up its documentation (http://mjambon.com/yojson.html) is dead (404).
I sure would like to have it back. ;)

Related to this, the link at the top of the github page is for adt-gen.


Bump CoreDNS to v1.7.1

Bump to v1.7.1 of CoreDNS, or if there is a newer version in v1.7.x line at the time of taking this task on.
We should also backport this to 1.19 release branch. This is because we plan to bump to CoreDNS 1.7.1 in RKE2 as well with the upcoming 1.19.x release for it.

I am expecting some failures from this as described at https://github.com/k3s-io/k3s/issues/2700#issuecomment-747605130

Here is the PR for 1.8.0 bump: https://github.com/k3s-io/k3s/pull/2726

Validated in v1.20.0-rc5+k3s1 we are using coredns 1.8.0
Validated in v1.19.5+k3s2 we are using coredns 1.6.9
The issue as noted here previously is resolved in both of these versions.


Py-eddy-tracker software

Hi,
I work on the evolution of py-eddy-tracker.
I discover today that you use a previous version of this software.
If you want to update eddy identification and tracking, you could found the documentation and example gallery here.
Antoine

eddy tracker needs to be updated to use the above python module (and there is also some deprecated basemap stuff that needs to be updated I think)


Automated cherry pick of #1273: add azure region geographicinfo

Cherry pick of #1273 on release/2.10.0.
#1273: add azure region geographicinfo

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@2aad7f8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #1311   +/-   ##
================================================
  Coverage                  ?    7.9%
================================================
  Files                     ?     369
  Lines                     ?   57679
  Branches                  ?       0
================================================
  Hits                      ?    4562
  Misses                    ?   52719
  Partials                  ?     398

Flag
Coverage Δ

#aFlag
7.9% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aad7f8...c444529. Read the comment docs.

/approve
/lgtm


fixed syntax related to [dir="rtl"]

Attribute selector syntax was incorrect in this file. For example,
.slick-next {
  &:before {
    &[dir="rtl"] {
      // stuff
    }
  }
}

would compile to .slick-next:before[dir="rtl"], when what was intended was [dir="rtl"] .slick-next:before, and this would cause browsers to ignore that rule.
I discovered this problem when I minified my compiled stylesheet with clean-css and the Next arrow disappeared: the <button> was still there but it had no ::before pseudo element which is where the arrow exists. clean-css grouped the .slick-next:before rule that defined the arrow with .slick-prev's broken :before[dir="rtl"] rule, causing both rules to be ignored:
.slick-next:before,.slick-prev:before[dir=rtl]{content:"→"}

The syntax is correct in slick-theme.scss.

Excellent. Thanks!


On commit failure, include topic and partition in error

Sounds good.  BTW as a recovering Java user I am used to being very liberal with newlines, e.g.
MyBuilder()
    .value(foo)
    .anotherValue(bar)
    .moreValues(baz)
    .areWeDoneYet(bat)
    .nope(0xDEADBEEF)
    .howAboutNow("no")
    .build()

Yeah; formatting is hard. Everybody wants to do it differently. @DrTall and I have had some, ah, spirited discussions about the matter.


F-Droid

I'd like to see this app available on F-Droid store, that's why I've just go ahead and open a request here. Don't you mind?

And would you mind to tag your releases so F-Droid knows which commits to build? Another thing nice to have would be Fastlane file structure with description, screenshots etc …

I'll look into it

Great, thanks! I see you just started tagging. If you could attach the APK as well, I could already serve that via my repo until you're ready for "the big one".

Attached the APK too

Thanks! Just added it to my repo (find it here); updates will be picked within 24h from your attaching the APK to a new tag.
GMS will be a show-stopper for f-droid.org, though.
PS: you don't plan to open-source AutoMagisk as well?

AutoMagisk is long since dead, I don't plan on even looking at it ever again if I'm honest.
Thanks for your help

Ah, OK – I just saw it at XDA and thought it sounds interesting… Thanks for letting me know. And always glad to help! :smiley:

Any chance with Fastlane, @KieronQuinn?


0.7.6 release

Version 0.7.6 (2020-06-05)
========================
* White panda is deprecated, upgrade to comma two or black panda
* 2017 Nissan X-Trail and 2018 Nissan Leaf support thanks to avolmensky!
* 2017 Mazda CX-5 support in dashcam mode thanks to Jafaral!
* Huge CPU savings in modeld by using thneed!
* Lots of code cleanup and refactors

Thanks for all the hard work guys :)


GoogleMaps plugin testScrollGesturesEnabled flaky on tablet devices

filing this preemptively. After https://github.com/flutter/plugins/pull/1352 merges there are some timing issues identified for this test. This might hold for other tests on other devices. Once we move plugin testing infra to account for multiple device configurations, we should be able to effectively identify this.

Hi, just want to check if this is still a problem for you.

https://github.com/flutter/flutter/issues/30575

Hi @iskakaushik
Does this issue still exist?
Thank you

@iskakaushik
I hope it's fixed.
If no, could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of flutter doctor -v please.


Is it one permission per users or can we do multiple role ? What is the type of permissions?

I have a backend spring with multiple role per users.
I am trying to implement client side ui with permissions.
I have a list of role roleList["ROLE_AUTH","ROLE_USER_MANAGEMENT","ROLE_USER_MANAGEMENT_MANAGE_USER"] ...
In the documentation it doesn't says the type of role but in the example, I only see one role admin.
Also, the switch seems to accept a single value.
What is the exact type of role ?

permissions is whatever your authClient returns when calling AUTH_GET_PERMISSIONS. You're free to store an array there.

@fzaninotto my authClient returns an array of permissions but it looks like it is been given back to me as a string.
e.g. my roles are ['ROLE_USER', 'ROLE_ADMIN']. However, inside the admin component I get "ROLE_USER,ROLE_ADMIN".
Would be good to see some example docs for multiple roles.
Any help would be much appreciated.

Actually, I discovered the issue. localstorage was changing it to a string. Needs to convert to json or just decode directly in the check.


libtiff: Add patch to fix missing Lerc in libtiff-4.pc

Description of changes
Found in static-haskell-nix. This should help pkgsStatic equally.
Upstream PR is: https://gitlab.com/libtiff/libtiff/-/merge_requests/633
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
@NixOS/geospatial

This was accidentally closed by https://github.com/nh2/static-haskell-nix/commit/4c9cf63a9c3017f77f2c6eb48c4c3ac2ff8311d7
with my commit message
nixpkgs: Update submodule to include libtiff fix

https://github.com/NixOS/nixpkgs/pull/320105

Looks like Github is way too agressive, parsing that as fixes https://github.com/NixOS/nixpkgs/pull/320105...
Reopening.

The patch hasn't been accepted upstream yet. It might be prudent to wait for that to happen before adding it.

Maybe for a while, yes.
It's quite certainly correct to do this, as libtiff's other build system (CMake instead of autoconf) does this as well.
I believe the only reason it isn't in their autoconf build system is that either they forgot it, or because in contrast to CMake, autoconf cannot check for the version number in which Lerc has a .pc file.

Which situation does this fix in nixpkgs? Is Lerc in nixpkgs' libtiff already not working?

This fixes pkgsStatic.libwebp.
In normal pkgs, it's already working; only fixes static builds.

Does this remove the need for lerc in buildInputs? Is it equivalent? Complementary? Or just not related to that line?

Unrelated to that line; lerc is still a dependency of libtiff.

We'll probably want a "TODO" comment marking this for git revert once the upstream patch is in the latest release of libtiff.

Done.


bump kontainer-engine

See: rancher/rancher#16786, https://github.com/rancher/kontainer-engine/pull/103
When handling errors in stack creation, sometimes there is no CREATE_FAILED event, and the reason is attached to the ROLLBACK_IN_PROGRESS event.
This change still allows CREATE_FAILED events to take priority.

LGTM


Mobile Push Notifications opt-out

I am working on an iOS application and I am not able to opt-out the Mobile Push Notifications property in my CleverTap profile (it is showing the green mark).

I am using the following function and it is working fine with the Emails property:
 func update() {
        let profileProperties: [String: Any] = [
            "MSG-email": false,
            "MSG-sms": false,
            "MSG-push": false
        ]
        CleverTap.sharedInstance()?.profilePush(profileProperties)
}

but the Mobile Push Notifications stays green.
Also, I have tried to change it from postman (with https://api.clevertap.com/1/upload)
{
  "d": [{
	"identity"<EMAIL_ADDRESS>	"type": "profile",
	"profileData": {
		"MSG-push": false,
		"MSG-email": false
	}
  }]
}

but it did the same, only changed the value of the Email.

Hi @blankaorosz
Thank you for sharing the above details.
Could you also enable CleverTap Debug log for your Application and share it with us on<EMAIL_ADDRESS>so we can investigate further?

Additionally, it will be helpful if you can share the CleverTap Dashboard profile link with us.

Closing it, feel free to reopen if you need further help or you can also write to<EMAIL_ADDRESS>


v2.ODataModel to support PUT request on submitChanges

First: I hereby declare to agree to the OpenUI5 Individual Contributor License Agreement.
Currently, the v2.ODataModel only allows for MERGE request through the submitChanges API. This PR is to expose the merge parameter so that also PUT requests can be sent (by providing merge: false). The API is still compatible as it still creates a MERGE request by default.
Swichting between PUT and MERGE is already enabled through the update API and I see no reason why this should not be enabled in submitChanges.
Thanks,
Max

I just realized that it's not that simple. Queued requests (e.g. those created by two-way binding) might have been created as MERGE requests. A call to submitChanges would just wrap them in a PUT-like batch request, yet every individual request would still be sent as MERGE if created that way.
So the actual problem is much more, that changes originating from two-way binding currently only create MERGE requests and there's no chance of creating a PUT request.
Would there be any drawback in adding a binding parameter for this?

Max

we added an option to make PUT requests when calling submit Changes. This will send all properties. Additionally MERGE requests from Two Way binding now send only the changed properties. Should be in the current snapshot.


Prototype Workspace Life Cycle on Shards

Workspace Life Cycle on a Shard
Objective: kill all other shards and the workspaces on that shard should keep working
A shard a workspace is scheduled to can store data under a lcluster (= etcd prefix) without knowing about the workspaces it hosts. But this has downsides:

everybody (with permission) can store and retrieve arbitrary lcluster data
there would not be a record of key ranges in etcd to clean up after or before workspace scheduling
critical data for autonomous operation would be missing, e.g. CRDs, RBAC data
as a consequence every shard has to call out to other shards, potentially in different availability zones or regions. This is harmful for availability and resilience to network issues.

To mitigate these, we propose that shards replicate (read-only) certain data into lclusters for their own consumption "reserved shard lclusters/workspaces", not exposed externally (to users or even admins via the proxy):

partially: the org workspaces for which workspaces are hosted:

RBAC RoleBindings and Role relevant to allow access to Workspaces
Workspace objects for those workspaces hosted,
and for limited time (e.g. 1h or 1d) Workspace objects for those workspaces that have been migrated away (for redirection).

partially: the root org workspaces with the org Workspace objects of org workspaces in (1).
an "apiimports" lcluster holding uniquely named CRDs generated and deduplicated for bound APIResourceSchemas of APIImports in workspaces hosted by the shard.

To implement these:

[ ] We add a number of controllers in the kcp shard that will keep the upper (1)-(3) lclusters up-to-date, watching the org workspaces.
[ ] We guard Workspace object deletion in (1b) with a workspace data deletion step e.g. via a finalizer on the replicated Workspace object.
[ ] We add readiness to a Workspace status to state that the replication has finished. We report in a condition "InitialSharedDataReplication" about success or failure. The readiness is for the target shard, and it is reset to false when a new target shard is set (i.e. during initial scheduling or during/before movement)
[ ] The shard will reject traffic for the lcluster until the Workspace is marked ready.
[ ] Non-loopback requests to these reserved shard lclusters are rejected (via authz or a filter in the handler chain).

Copied from: https://docs.google.com/document/d/1MhfRk_VV5orvspx1OzU5De7nnE6va9lIpLUKBKnzuWE/edit#

Clearing milestone to re-triage

Superseded by #342


MSBuild work in travis CI Windows?

Coverage remained the same at 99.833% when pulling a2423bf31f59ec9d8ec258a38e8694982cd34e71 on basvodde:master into d7c7962a1c9c0e3aab0d452f450402bf52f81df4 on cpputest:master.


Test against node 7

Brackets is distributed with Node 6, there's no plan of using Node 7 at the moment.


[BUG] Model state is not correctly after saving and loading

This is a BUG! Would you kindly change the label?
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.8.0
Python version: 3.7.10
Bazel version (if compiling from source):
GPU model and memory: cpu
Exact command to reproduce:

Describe the problem.
Keras model does not converge after saving and loading.
Describe the current behavior.
After calling model.save(...) and model = tf.keras.models.load_model(...), the model failed to converge.
Describe the expected behavior.
Adding model.save(...) and model = tf.keras.models.load_model(...) should not effect the training process.

Do you want to contribute a PR? (yes/no):  No

Standalone code to reproduce the issue.
import tensorflow as tf
mnist = tf.keras.datasets.mnist

(x_train, y_train),(x_test, y_test) = mnist.load_data()
x_train, x_test = x_train / 255.0, x_test / 255.0

model = tf.keras.models.Sequential([
  tf.keras.layers.Flatten(input_shape=(28, 28)),
  tf.keras.layers.Dense(128, activation='relu'),
  tf.keras.layers.Dropout(0.2),
  tf.keras.layers.Dense(10, activation='softmax')
])

model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])
########### added lines ###########
model.save("/tmp/mnist_model")
model = tf.keras.models.load_model('/tmp/mnist_model')
################################

model.fit(x_train, y_train, epochs=5)
model.evaluate(x_test, y_test)

Source code / logs.
After adding saving and loading, the model does not converge:
2022-02-08 09:03:19.403489: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2022-02-08 09:03:19.698194: W tensorflow/python/util/util.cc:368] Sets are not currently considered sequences, but this may change in the future, so consider avoiding using them.
Epoch 1/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.2983 - accuracy: 0.1004
Epoch 2/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.1451 - accuracy: 0.0992
Epoch 3/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.1069 - accuracy: 0.0990
Epoch 4/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.0881 - accuracy: 0.0991
Epoch 5/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.0754 - accuracy: 0.0989
313/313 [==============================] - 1s 2ms/step - loss: 0.0775 - accuracy: 0.0992

Remove the saving and loading code, the model converges as expected:
2022-02-08 09:05:18.683461: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
Epoch 1/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.3010 - accuracy: 0.9133
Epoch 2/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.1452 - accuracy: 0.9574
Epoch 3/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.1099 - accuracy: 0.9666
Epoch 4/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.0878 - accuracy: 0.9729
Epoch 5/5
1875/1875 [==============================] - 6s 3ms/step - loss: 0.0746 - accuracy: 0.9766
313/313 [==============================] - 1s 2ms/step - loss: 0.0744 - accuracy: 0.9770

It seems we cannot call model.save() before calling model.fit.

Here model.fit trains the model for a fixed number of epochs  on a dataset. We should use model.save to save the model to Tensorflow SavedModel or a single HDF5 file after training. Thanks!

Here model.fit trains the model for a fixed number of epochs on a dataset. We should use model.save to save the model to Tensorflow SavedModel or a single HDF5 file after training. Thanks!

Hi @chunduriv , I understand how mode.fit and model.save works. I am here to report a bug.
If I understand correctly, adding the following two lines will not affect the model's state.
model.save("/tmp/mnist_model")
model = tf.keras.models.load_model('/tmp/mnist_model')

However, the current behavior is adding the above two lines will cause a model not to converge.
You can easily reproduce the problem by running the code I posted.

@yangw1234,
Generally model.save will save a model's architecture, weights and training configuration in a single file/folder.
Here to get correct values after loading the model, can you configure the model for training before model.fit as shown below
model = tf.keras.models.load_model('/tmp/mnist_model') # load model
model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])
model.fit(x_train, y_train, epochs=5)
model.evaluate(x_test, y_test)

Please refer attached gist for reference. For more details please refer this tutorial. Thanks!

Thanks @chunduriv , I see what you are saying, but I have one more questions.
Will the model.compile line in your example overwrite the optimizer states saved by model.save?

@chunduriv actually, it seems calling model.save itself will also make the current model not converge.

I opened a pr to fix this issue #16069

I think the root cause is here:
https://github.com/keras-team/keras/blob/master/keras/saving/saving_utils.py#L326.
Here it uses model.outputs as the target to build metrics. In the build logic, however, the target shape is used to determine the right kind of accuracy (see here). As a result, the wrong accuracy is built into the model. So the model training is fine, but the accuracy calculation is wrong.


s/riot-static/matrix-static/g

not affiliated with riot, nor by vector-im so -> matrix-static

LGTM


adjust recipe

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_46805dfo9c/clone/recipe/meta.yaml:59: duplicate_key_in_meta_yaml: The recipe meta.yaml contains a duplicate key
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_271dqk8wl7/clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d8ks6iwwep/clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_57buobmcul/clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_78cn0v8vs_/clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found


Move mgmt to separate port

In order to have simple HA, the service port should be different from the admin port (this way there is not even a terminating tcp reponse, making services fail over to other keymaster servers).

Check is failing.
Also, let's talk about this tomorrow. I'm not fond of multiple ports. It's confusing.


"Preparing to back up." for a very long time

I'm running this under Container Station on a QNAP TS-451+ under QTS <IP_ADDRESS>0.  The CrashPlan client version is <IP_ADDRESS>.
Until last night, it was happily backing up data to CrashPlan, with about 650GB of 2TB remaining to back up.
When I checked this morning, it said what it does now (attached), though the number of files still to be backed up was slightly lower.

I've been tailing the log, and I see nothing unusual there.  Nor do I see any evidence of files being backed up!
The History window shows nothing strange.  Looking for signs of life, I paused and resumed backups.
The last couple of entries say:
09/15/20 02:57 PM	[QNAP Backup Set] Scanning for files to back up
09/15/20 03:21 PM	[QNAP Backup Set] Scanning for files completed in 24 minutes: 631,368 files (2TB) found

After that, nothing.
When I run ps in the Docker container, the CrashPlan process is using 3% CPU or less.
How can I get CP to complete this backup?
Thanks!

It sat there for the better part of a day with no change in the status message, then began comparing local vs. cloud files, and is now backing up again, apparently continuing where it left off.


Add initial notification service

Unresolved Questions
@stv0g
Where should the configuration file be placed?
It's currently just a config.yaml in the current working directory.
Resolves #40

Looks good to me. I will merge this now and do some smaller changes myself later..
The only thing which I would change is the naming by replacing "apprise" with "notification" as I dont think the name of the package we use here is really of interest for the user.

Thanks :)


[$1000]  nothing happens on click mark as unread for first message in thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat
send any message
go to thread
click on mark as unread for  first message

Expected Result:
should show green line
Actual Result:
does not show green line
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/0391aeee-dc6f-47bd-bb34-ac7cbc2ccd0c
https://github.com/Expensify/App/assets/43996225/03071cd1-2a55-4668-9dee-d70c5b38372a
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684386451270149
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019cd25619314f7c13
Upwork Job ID:<PHONE_NUMBER>770120192
Last Price Increase: 2023-05-22

Not overdue, @abdulrahuman5196 can you please take a look at @tienifr's proposal?
If we accept that I think the first option is the one that makes the most sense! Let's also test what happens if we create a thread but don't send any messages and mark the only visible message as unread (the message that originated the thread)

Sure will close the review today

I did a check on @tienifr  proposal.
We could only choose option 1 since if we mark the first child message as unread it adds new line to the top. This way option 2 will cause confusion.

And the proposal is working for no child reply cases as well and cases with existing replies.
But before going further @PauloGasparSv  I have a trivial question on expectation. Since the thread's first message is original message from the user chat, should we mark the same mesage unread in the original chat from which the thread was started?(This will start lot of edge cases of threads within threads.)
Or do we just keep the threads parent message being marked unread in the current thread scope alone and show bolded in LHN with no change in the user's original chat?

@PauloGasparSv Gentle ping on this question https://github.com/Expensify/App/issues/19362#issuecomment-1563419677

Since the thread's first message is original message from the user chat, should we mark the same mesage unread in the original chat from which the thread was started?

Or do we just keep the threads parent message being marked unread in the current thread scope alone and show bolded in LHN with no change in the user's original chat?

That's a great question, IMO we should do the second and keep the threads parent message being marked unread in the current thread scope alone.
I also think the responsibility of marking the action from the original chat (outside of the thread) as unread should be delegated to the API so we can implement that later as a follow up to this if people think it's important and bring it up :D
Does that sound ok?

Sure. Sounds good.
Then @tienifr proposal option 1 here https://github.com/Expensify/App/issues/19362#issuecomment-1556721742 looks good.
🎀👀🎀
C+ Reviewed
cc: @PauloGasparSv

The PR is ready for reivew!
cc: @abdulrahuman5196  @PauloGasparSv

Note to self: Offers sent to @tienifr @abdulrahuman5196 @gadhiyamanan in Upwork

@abdulrahuman5196 can you advise on the regression steps above? Thanks

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It isn't a regression. The "Mark as Unread" feature was not implemented for the parent message in thread during threads implementation

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to any thread message chat
Click on mark as unread for first message
Verify that the green line appear on top of the first message
Also verify if the corresponding row is marked as unread in the LHN list

@laurenreidexpensify @PauloGasparSv

Go to any thread message chat
Click on mark as unread for first message
Verify that the green line appear on top of the first message
Also verify if the corresponding row is marked as unread in the LHN list

LGTM! I agree that we should create the regression test, steps are simple and straight-forward : )


This page doesn't mention the 10 xml file limit

The docs should mention the fact you can only upload 10 custom rules via powershell and once you try to upload more than 10 you get the following error "The number of sensitive information type collections 10 exceeds the limit of 10"

@KhaldounAlmarzouk - May we know which Microsoft document link you used in reference to this issue?
Please share it with us so we can investigate further. Thank you.

Hi Joyce,
I'm referring to this page
https://docs.microsoft.com/en-us/microsoft-365/compliance/create-a-custom-sensitive-information-type-in-scc-powershell
Thanks,
On Sat, Dec 28, 2019 at 6:58 PM Joyce Y<EMAIL_ADDRESS>wrote:

@KhaldounAlmarzouk https://github.com/KhaldounAlmarzouk - May we know
which Microsoft document link you used in reference to this issue?
Please share it with us so we can investigate further. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/989?email_source=notifications&email_token=AEEK4VL76CPTIMVKBEW3O7DQ27RZHA5CNFSM4KAOIVSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYUQKA#issuecomment-569460776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEEK4VKY56TVFNGE4EBMMF3Q27RZHANCNFSM4KAOIVSA
.

Hi @KhaldounAlmarzouk, thank you for your comment. I am following up with the product team on this.


some comments

Hey thank you for ordering the whole stylesheet thing into one easy accesible topic.
Nevertheless I have some small comments:

Maybe you should mention in the readme, that one has to replace the "user" in the stylesheet.
Your pictures are not up to date anymore, because some buttons changed, at least, when i use the stylesheet.
For my taste the scroll bars are way too large, so I replaced them with the stylesheet provided in the old topic. Maybe you could add them as an option somewhere? I dont know what the best way to do it would be, because I have totally no idea of Qt.

PR merged.
Yeah, I've been meaning to redo the images.. I'll get around to doing it soon. (I didn't think this repo would be seen by many people, so I was procrastinating a bit. :p)
I'm not quite sure what you mean by "add as an option". (where?) All the relevant settings are under QScrollBar, esp the width/height properties.

I've updated the README with up to date pictures. Any other images you think would be representative?

I reduced the width of the scrollbars -- I agree they were a tad too "thick". (see the new sample imgs)

Yes that looks much better.  Thank you.
to 3.: Totally agreed that one can do that oneself. Just because I felt not able to do it myself I copied from an older version of a stylesheet which was uploaded in the discussion on the texstudio repository. I think now that it is changed, that is fine. (You must know, that I never used QS or anything similar myself.)
Maybe there is a possibility to let more people know about this gem? I mean the developers said, that this has no priority to them, so it won't be a normal feature of texstudio but I really enjoy it like that. I got asked from other people in the library, where I got this from :). So maybe they could add this as a betafeature in their build?

I'm glad you like it :).

I got asked from other people in the library, where I got this from :). So maybe they could add this as a betafeature in their build?

If they do include my dark QSS in as a beta feature, it would become something that they would need to maintain. So I would be inclined to think that the devs would prefer to maintain status quo until the various UI clashes and inconsistencies are sorted out (I mention some in my README, and also raised to Tim et al. in the main thread).
On my end, I'm also not comfortable promoting this repo until the issues are all fixed. The reason for me putting this up on my repo is (i) to give others some ideas on what the qss is capable of changing and (ii) guide them along which part of the UI is affected by which properties in the qss file via my comments within (so they don't have to trial and error as I did, looking for the property that changes the toolbar colour, for example).

Ok, good point. I'll do some cleaning up of my options file and upload it over the weekend.

ok. hopefully people find it :)


Refactor Route factory methods

At now we can create Route without name. But without name Route is useless (for generating we need to know name which url we want to generate, but we don't know it).
I suggest to make one of following solutions:

Create RouteBuilder
RouteBuilder will sets to private properties intermediate results that allowed to build Route step-by-step.
Extend get, post, patch and other methods with required argument name.

After each of solutions Route will be created over __construct method instead of setting private methods directly.
Which problem will be solved?
At now name is optional property as declared, but in real case it's required property.

But without name Route is useless (for generating we need to know name which url we want to generate, but we don't know it).

You don't need a name if rule is never used for generating URL.

Then this route is not needed. It makes no sense to add it to the collection of routes

It could be used only for parsing request. Yii 2 has separate switch for this: https://www.yiiframework.com/doc/api/2.0/yii-web-urlrule#$mode-detail

Ok. In this case route should be generated with unique name. (ex. hash based on route pattern or other)

Why do we need to generate it if it won't be used?

I was thinking about it today some time.
You are right, route can exists without name. But without a handler it's difenitely useless. If it will use only for parsing and will nothing to handle it's difenitely useless and invalid.
Upd: If we won't generate a name by default name will equal to pattern.
For notes: route name needs to show in Debugger

Yes, a route without a handler isn't useful.

We don't need a builder or any extra abstraction layer to solve it. Currently it's, indeed, possible to define a route w/o handler. That could be solved in multiple ways.
Making handler mandatory in Route
Route::get('/bla-bla', $middleware)
    ->name('bla-bla')
    ->then($anotherMiddleware);

Throwing an exception in RouteCollectorInterface::addRoute
If there's a route w/o handler encountered, throw an exception here: https://github.com/yiisoft/router/blob/master/src/Group.php#L23
Then the syntax stays the same:
Route::get('/bla-bla')
    ->name('bla-bla')
    ->to($middleware)
    ->then($anotherMiddleware);

Currently it's, indeed, possible to define a route w/o handler.

Is it really a problem? In Yii 2 you can have rule used only for generating URLs - you don't need a handler in that case.

I vote for the first proposal because it may and should use __construct "under the hood"

@rob006 was it valid case to generate URLs that would not resolve because there is no handler?

@rob006 was it valid use case to generate URLs that would not resolve because there is no handler?

Generating URLs to external services, for example from example.com to api.example.com - api.example.com needs routing only with handlers (routing is used only for handling request), and example.com needs the same routing but only with names (routing is used only for generating URLs to api.example.com).

Yes, makes sense. So handler isn't strictly mandatory.

So it seems there's nothing to fix then.


Support matchExpression for selecting resources  in policy

Feature Request
Short Description
Currently, KubeArmor policies selects resource on the basis of matchLabels. On a large scale deployment selecting resources with matchLabels won't help. To filter resources in more granularity policy must support matchExpression to filter or select resources.
Is your feature request related to a problem? Please describe the use case.
To support selection of resources in the policy with the help of matchExpression.
Describe the solution you'd like
Need to add separate function to add functionality for matchExpression.
To be taken care that, policy while selecting resources can select resources in either of 2 ways:-
Case:1 Either matchExpression  or matchLabels must present  or
Case:2  Both of them could be present.
Current Scenario
In current scenario when try to apply the policy containing matchExpression as a selector,
kubectl apply -n multiubutu -f-     << EOF

apiVersion: security.kubearmor.com/v1
kind: KubeArmorPolicy
metadata:
  name: ksp-group-1-proc-path-block
  namespace: multiubuntu
spec:
  selector:
    matchExpressions:
    - {key: group, operator: In, values: [group-1]}
  process:
    matchPaths:
    - path: /bin/sleep
  action:
    Block
EOF

Error:
error: error validating "STDIN": error validating data: ValidationError(KubeArmorPolicy.spec.selector): unknown field "matchExpressions" in com.kubearmor.security.v1.KubeArmorPolicy.spec.selector; if you choose to ignore these errors, turn validation off with --validate=false

Hey @nyrahul , I would like to work on this issue.

Hey @nyrahul , I would like to work on this issue.

Thanks for the interest. Would you be able to provide an analysis (set of implementation changes) before you start making the changes? This would help us sync on the appropriate next steps.

Ok, I will create small design doc for the same. And discuss it with the community in the next meeting.

/assign

In the bi-weekly meeting, the conclusion was made to support all 4 operators(In, NotIn, Exists, DoesNotExist) for matchExpression selector.

Hey guys, any update on this issue? Would be great to have this implemented.

Hey guys, any update on this issue? Would be great to have this implemented.

As of now we haven't planned this in v0.6 ... v0.6 is anticipated by the end of August, so backlog grooming for v0.7 is in progress. We can possibly take this up v0.7. Do you have any specific use-cases you can quote in the context? Thanks

Sure!
Today we have microservices using different languages, so I'm able to apply specific language policies, using matchLabels. ex: backend: kotlin, backend: golang
But on the other hand, we have some policies that apply to all backend services, for example, accessing /etc/passwd files, or /proc/1/environ.
In this case, we had to create another label on our deployments, making changes on lots of manifests, since we could just apply the policy using MatchExpression:      - {key: backend, operator: Exists}


add test for BZ 1048265 - Creating duplicate DRL silently overwrites.

(part X of moving-tests-to-community series)

+1 to merge.


[Question/Information] Explain about forcefield.cpp

Why you put forcefield.cpp in the lib if you don't want to compile it? Is it part of the lib?

If I remember correctly we compiled it at some point, and we may still do something with it. Maybe we will delete it eventually.

For v1.2.2 I compile it with vcpkg as part of the lib.
I suggested some small minor fix for compile it on windows.
Will you consider compile it as part of your lib until you delete it?
Also consider again my small fix for compile it on windows?
https://github.com/ccsb-scripps/AutoDock-Vina/pull/23

@talregev seems like the issue is with the compile script on vcpkg. Probably you can change it to compile only the files needed. You can find this list of source files at the top of build/makefile_common.

You miss my point.


Added boundary edge regions

Added boundary edge regions. This is necessary for coupled 3D-2D problems to prescribe boundary conditions for the 2D subproblem. The function bedgemask! can be used to associate a region number for boundary edges on a line segment.
So far this works only for boundary edges since prepare_edges! doesn't work in the 3D case, yet.
The region numbers are stored in grid[BEdgeRegions], which is only constructed on request, e.g. by calling bedgemask!.

Codecov Report

Merging #10 (d579d5b) into master (001b2f1) will increase coverage by 3.46%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   82.38%   85.85%   +3.46%
==========================================
  Files          12       11       -1
  Lines         999     1039      +40
==========================================
+ Hits          823      892      +69
+ Misses        176      147      -29

Impacted Files
Coverage Δ

src/simplexgrid.jl
96.78% <0.00%> (-0.84%)
:arrow_down:

src/extendablegrid.jl
67.50% <100.00%> (+3.61%)
:arrow_up:

src/regionedit.jl
99.00% <100.00%> (+0.42%)
:arrow_up:

src/tokenstream.jl
88.37% <0.00%> (+2.00%)
:arrow_up:

src/more.jl
82.27% <0.00%> (+20.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001b2f1...d579d5b. Read the comment docs.

Okay, I added the bedgenode array as argument to the constructor


Change of language

The default is English, how to change the language

Please try to use the forum for asking questions. The github issues are intended for bug reports and feature requests.


[question][Android] does perfetto support to run in production?

Productionize [done]
Do security changes required to run heapprofd with setenforce 1 and as non-root.

I saw the doc claimed it supported. can you share more details about this? thank you!

It is definitely supported. There are caveats described in https://perfetto.dev/docs/data-sources/native-heap-profiler#heapprofd-targets
Summary:

On userdebug or eng (i.e. rooted) images all apps can be profiled
On user (production) images, you can only profile apps that, in their manifest.xml, are either

Declared as debuggable
Declared as profileable

The doc linked above shows examples and has all the info you need. Reopen if something is unclear.

I see, thanks for the prompt answer.
I'm curious does it support profiling the normal release build that the build we ship to real user.

Yes... as long as you mark it as profileable in the manifest.
You cannot profile apps if they are not profileable, unless you install it on a userdebug image (e.g. the ones you can download here https://source.android.com/setup/build/running for pixel).


'Airtable' object has no attribute 'get_all'

I am receiving the error in the Title when trying to run my Python within a cron job. I have been having trouble getting the module to even be recognized, I finally came up with
from airtable import airtable
and then instantiating objects with
airtable.Airtable(...
Not sure why I had to change that for the cron job, it used to just say
from airtable import Airtable
but anyway, now I can instantiate the object, but I'm getting the title error when I run
monitor_table = airtable.Airtable(MY_BASE_KEY, 'monitor')
monitor_recs = monitor_table.get_all()

I've tried reinstalling airtable-python-wrapper. What is going on? This all worked fine before trying to run from the cron job.

from airtable import Airtable should work fine and tests are passing.
I would need more info to be able to help.
What python version are you using?
Did you install it using pip?
Are you using a virtual environment?

@jkoseattle
You have 2 choices
Either
from airtable import Airtable
monitor_table = Airtable(MY_BASE_KEY, 'monitor')

OR
import airtable
monitor_table = airtable.Airtable(MY_BASE_KEY, 'monitor')

You cannot mix both, that is, if you import airtable from airtable, you already have direct access to the Airtable class.

This seemed to be a problem with venv in pycharm. I noticed that when I change my interpretor or venv I get this error (had been trying to use the poetry 3.10.2 rips of python)


Configurable waiting time for initial SQL HealthCheck check

We are using test containers to wrap sql server and the emulator. This ensure the emulator is started only when the sql container is ready. Waiting 15 seconds is way too long in unit testing.

Thanks for your feedback @scrocquesel. We'll investigate and keep this issue open for further progress updates.


Implement fully automatic builds for ROS

Since Realm Object Server can update at any time, and maintaining an up to date but also stable version is a pain, the plan is to fully automate this from start to finish.
Every git tag will match the version of Realm Object Server, as well as having matching tags on Docker Hub. You will still be able to use latest with Docker, but it's not recommended.
Travis will build, test and deploy for us, and it will do this both on new commits, but also daily using scheduled builds.

This seems to be done now.


Data explorer overview

This issue provides an overview of the roadmap of the data explorer.
Background
The JupyterLab data registry will enable extensions to 1) register abstract datasets with a central service and 2) monitor the registry for datasets. The dataset abstraction in the data registry includes:

Text-based MIME type
Optional URI to point at datasets that are persistent
Abstract dataset pointer

The data registry also includes a converter architecture that can convert datasets from one MIME type to another.
Conceptually, the data registry will make datasets a first class entity or noun in JupyterLab.
Data explorer UI
The Data explorer is a proposed user interface to enable users to explore datasets that different extensions have registered with the registry, and the do interesting things with the datasets, such as:

Render them using MIME renderers.
Comment on and annotate the datasets.
Create and view metadata attached to the datasets.

Conceptually, the data explorer UI will provide a user interface for the verbs related to a dataset, or the actions or activities a users can perform with the dataset, such as "render this as a table".
Initial design thoughts

Probably a left sidebar based UI as this is similar to others currently there with an "overview" or "explore" idea.
A list a datasets.
For each dataset a discoverable list of things you can do with the dataset:

MIME renderers.
Create/edit metadata.
Open comments for the dataset.

The metadata and commenting/annotation UIs will likely rely on another extension being developed separately.
We may also want extension points to register new "things you can do" for a given MIME type.
We will want to take into account the MIME type of the dataset, but also the different MIME types that can be created through the converter API.

The visual representation of the list of datasets, and the things you can do with them is still a core design question.
@saulshanabrook @tgeorgeux

I am closing this for now, since we have some initial UI developed.