Bug: inferred func names are ambiguous, cause misbehavior due to alias

RegisterActivityWithOptions registers an inferred func name into a map containing {inferred-name: registered-name}, I assume to allow you to execute activities with either their registered-name or their function, for simplicity.
Unfortunately this is unsafe - reflected function names are not guaranteed to be unique.  And it's relatively easy to encounter if you generate workflow or activity functions (as can easily occur in tests, and could occur IRL as well, though generally you'd just pass those args to a shared activity).

TBH I'm not fond of allowing ambiguous calls like this enables, but that's mostly irrelevant.  This silently produces incorrect behavior, which it should not do.
Making it error on duplicate-inferred-names would prevent a silent failure... but it'd also mean you cannot generate activities / workflows at all.
And trying to allow generated activities / workflows while also allowing ambiguous calls doesn't seem easily possible... func addresses would work for anonymous funcs, but for named ones you can only get the address of the var, not the "canonical" one.  Maybe something with reflection -> function pointer address?
I dunno.  I submit this as evidence of bad behavior, and to trigger discussion.

Most people will write the code as the following, and it won't be an issue.
func init() {
RegisterActivityWithOptions(f1, RegisterActivityOptions{"f1"})
RegisterActivityWithOptions(f2, RegisterActivityOptions{"f2"})
}
func f1() error {
return nil
}
func f2() error {
return nil
}

Part of the reason I bring this up is that it did bite me in some of my code.  Most will do that, sure, but not all.
One area where it's particularly common is if you do any dynamic workflow or activity wrappers.  I'm adding context info per request to my activity calls, and initializing a per-request cache, and doing so with a reflection-generated func wrapper that looks something like this:
func Register(ctx, fn, name) {
  wrapped := reflect.MakeFunc(reflect.TypeOf(fn), func(in []reflect.Value) []reflect.Value) {
    ctx := context.WithValue(in[0].Interface().(Context), "cache key", cache{})
    in[0] = reflect.ValueOf(ctx)
    return reflect.Call(reflect.ValueOf(fn), in)
  })
  activity.Register(wrapped, RegisterActivityOptions{"name"})
}

which fits the example test exactly.  I make a bunch of activities that, as far as reflection is concerned, are all defined at the same location, so they all get the same inferred name.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add minimalist dark toggle button

Fixes Issue🛠 #1145

Closes #1145
Description👨💻

Added the toggle button
Type of Change📄

[ ] Bug fix (non-breaking change which fixes a bug)
[ ] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)
[ ] Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

[ ] I am an Open Source contributor
[ ] I have performed a self-review of my code
[ ] My code follows the style guidelines of this project
[ ] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

https://github.com/user-attachments/assets/588b6148-cae9-423c-a4c2-d270ac085e06

@Rakesh9100 please review and merge this pr


Azure App Service settings changed after deploying updated container image

Bug Description:
App service settings changes from true to false when deploying an updated  container image.
Customers Verbatim
“As the topic say I have a problem with my web app settings when deploying an updated container image. The setting that get changed from "TRUE" to "FALSE" is: "HTTP_ENABLE_APP_SERVICE_STORAGE=TRUE" When updating the container and after the restart of the web app this setting is "FALSE". Dockerimage is stored in ACR. Any solutions?
I have been trying to google around and find solutions but have not yet found anything or even where I should start looking. Thanks for help,
Update 1:
The problem occurs when I run the following commands in az cli:
az webapp config container set
--docker-custom-image-name "DOCKER|xx.azurecr.io/imagename:tag"
--docker-registry-server-password topsecret
--docker-registry-server-url https://index.docker.io
--docker-registry-server-user username
--name MyWebApp
--resource-group MyResourceGroup
The return of this command shows the following:
{
"name": "WEBSITES_ENABLE_APP_SERVICE_STORAGE",
"slotSetting": false,
"value": "false"
},
Even though that the setting was TRUE before updating. Im not using slots but I have tried with setting the value on both "slotSetting": true, and "value": "true" but still no success.”
Expected behavior
After deploying updated container Image App setting should not changed from True to False.
Additional context
The conversation with PG team on email confirmed that this is bug.

@Nking92 can you take a look at this?

@SnehaAgrawal-MSFT can you try to repro this again but this time before you run the config update command can you check the original value of this setting by running az webapp config show? thank you.

@patricklee2 can you look at this, its related to bring your own storage feature. Thank you

ill take a look

@patricklee2 can we get this in for the next sprint please?

26th? Yes, I'll aim for that.

HTTP_ENABLE_APP_SERVICE_STORAGE does not get overwritten with az webapp config container set
Does the customer mean WEBSITES_ENABLE_APP_SERVICE_STORAGE is overwritten?

@SnehaAgrawal-MSFT I'm not able to reproduce the bug the customer reported.
When I update the image the app setting HTTP_ENABLE_APP_SERVICE_STORAGE  does not get overwritten.  Can you ask the customer if they meant that WEBSITES_ENABLE_APP_SERVICE_STORAGE should to be preserved?

@SnehaAgrawal-MSFT please provide the information that Patrick requested - or provide the repro steps. Since we cannot repro this - closing this.


include thirdparty

#44

fltk-1.3.3内の空ディレクトリはgitによって保持されなくていいのか？
fltk-1.3.3/.gitignoreは効いているべき？いないべき？

fltk-1.3.3のライセンス
http://www.fltk.org/index.php
FLTK is provided under the terms of the GNU Library Public License, Version 2 with exceptions that allow for static linking.
http://www.fltk.org/doc-1.3/license.html
December 11, 2001
The FLTK library and included programs are provided under the terms of the GNU Library General Public License (LGPL) with the following exceptions:
Modifications to the FLTK configure script, config header file, and makefiles by themselves to support a specific platform do not constitute a modified or derivative work.
The authors do request that such modifications be contributed to the FLTK project - send all contributions through the "Software Trouble Report" on the following page: http://www.fltk.org/str.php
Widgets that are subclassed from FLTK widgets do not constitute a derivative work.
Static linking of applications and widgets to the FLTK library does not constitute a derivative work and does not require the author to provide source code for the application or widget, use the shared FLTK libraries, or link their applications or widgets against a user-supplied version of FLTK.
If you link the application or widget to a modified version of FLTK, then the changes to FLTK must be provided under the terms of the LGPL in sections 1, 2, and 4.
You do not have to provide a copy of the FLTK license with programs that are linked to the FLTK library, nor do you have to identify the FLTK license in your program or documentation as required by section 6 of the LGPL.
However, programs must still identify their use of FLTK. The following example statement can be included in user documentation to satisfy this requirement:
and LGPL

tiff-4.0.3のライセンス
Opentoonzで同梱されているとおり、特に問題ない、、、と思う

GPLはバイナリー(.lib)の配布は、ソースコードの同時（がそれと同等の）配布をする条件で可能としている

FLTKはGPLより緩いので、配布可能ではありそうですね

そうですね、ここまで考えればいいかなぁ。
基本的には、元のライセンスを変えないで、ソースコード全体を配布する、ということで問題はないと思います、、、

Modified BSD License
と
New BSD License
は同じものの別名のようですが、
どちらをつかうべきか？

では、マージ、、、は明日朝やります。


View option not working

Steps to reproduce

Starcounter version  <IP_ADDRESS>60.
Involved apps' version

StarcounterApps/Content -develop

Server log error:
System.Exception: ScErrSessionJsonNotRoot (SCERR14010): The json is not a rootobject (have no parent) and cannot be used as sessiondata.
Version: <IP_ADDRESS>60.
Help page: https://github.com/Starcounter/Starcounter/wiki/SCERR14010.
at Starcounter.Session.set_ClientRoot(Json value) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.XSON\Sessions\Session.cs:line 503
at Starcounter.XSON.JsonMimeConverter.Convert(Json json, MimeType mimeType, String& resultingMimeType) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.XSON\Class Json\JsonMimeConverter.cs:line 52
at Starcounter.Internal.ResourceMimeConverter.TryConvert(Request request, IResource resource, String mimeTypeStr, String& resultingMimeType) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Apps.JsonPatch\BuiltInRestHandlers\ResourceMimeConverter.cs:line 67
at Starcounter.Internal.ResourceMimeConverter.Convert(Request request, Response response, String& resultingMimeType) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Apps.JsonPatch\BuiltInRestHandlers\ResourceMimeConverter.cs:line 46
at Starcounter.Response.ConvertResource(Request req) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Internal\Http\Response.cs:line 765
at Starcounter.Response.ConstructFromFields(Request req, Byte[] givenBuffer) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Internal\Http\Response.cs:line 821
at Starcounter.Request.SendResponse(Response resp, Byte[] serializationBuf) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Internal\Http\Request.cs:line 1243
at Starcounter.Internal.AppsBootstrapper.ProcessExternalRequest(Request req) in C:\TeamCity\BuildAgent\work\sc-6711\Level1\src\Starcounter.Apps.JsonPatch\AppsBootstrapper.cs:line 809
HResult=-2146233088
HelpLink=https://github.com/Starcounter/Starcounter/wiki/SCERR14010

Wow!
I reproduce this with the same Starcounter version you used: <IP_ADDRESS>60 .
I downgraded Starcounter to <IP_ADDRESS>07 and it works ok with it.
Is there a guide of changes that should be made in the code when one of the recent upgrade of Starcounter was made?
@warpech

It works ok with Starcounter version <IP_ADDRESS>26 (and previous versions, I assume).
I gives the above error with Starcounter version <IP_ADDRESS>39 (and further versions, I assume).

This must be related to https://github.com/Starcounter/Announcements/issues/32. Please check that thread and https://github.com/Starcounter/Home/issues/139.
If you fail to find the cause, please ping me on Slack.

Seems that exact same problem was detected in SignIn by @chrhol when he worked on the new Session changes (https://github.com/Starcounter/Announcements/issues/32).
See the PR in SignIn that fixed it: https://github.com/StarcounterApps/SignIn/pull/117, precisely: https://github.com/StarcounterApps/SignIn/commit/dd8edd6fc4de2a6d2bfbced7d7e0122748d48a62#diff-db8606ad459d9051ddcde2a085006721. Sadly, @chrhol didn't write any specific explanation for this.

Closing as solved.


Add flag to disable update checker

Web Browser: Not relevant
Local OS: Linux RHEL 7.9
Remote OS: Not relevant, but Windows 10
Remote Architecture: x86
code-server --version: 3.7.3 93fb76e4a71b1959ec2a23481ba2611200d714b2

Hello,
We're using code-server (installed manually from the tag.gz) on server with no access to internet, and we have several error messages on the console:
[2020-12-01T14:32:53.742Z] error Failed to get latest version {"error":"getaddrinfo ENOTFOUND api.github.com"}

An option was previsouly available to prevent update, any other way to do it ?
Thank you.

We've implemented a flag to disable the update checker (it won't auto-update btw and is just informative although that doesn't really make a difference in your case) and it'll be in the next release! I'll add this to the milestone for tracking.

Ah nvm we already have https://github.com/cdr/code-server/issues/2361 in the milestone. Would be neat if GitHub had a separate section for fixed issues that aren't yet in a release or something to make finding duplicates easier.

Thank you, I've tested and works like a charm!
I didn't find it when searching in issues, but I won't say I'm a github search expert :)
Good work!


HBASE-23804: Fix default master addr hostname in master registry

Master rpc server end point doesn't always bind to localhost when a
specific end point is configured. It looks up the hostname and
binds to the endpoint to which it resolves. MasterRegistry should
do the same when building the default server end point to talk to.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _

+0 :ok:
mvndep
0m 48s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 41s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
compile
3m 14s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
checkstyle
2m 26s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
shadedjars
4m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 16s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
spotbugs
3m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
20m 30s
HBASE-18095/client-locate-meta-no-zookeeper passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

-1 :x:
checkstyle
2m 17s
root: The patch generated 4 new + 408 unchanged - 1 fixed = 412 total (was 409)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedjars
4m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 26s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
4m 19s
the patch passed

+1 :green_heart:
findbugs
20m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
80m 21s
root in the patch failed.

-1 :x:
asflicense
3m  1s
The patch generated 1 ASF License warnings.

190m 10s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL

hadoop.hbase.replication.TestReplicationStatusBothNormalAndRecoveryLagging

hadoop.hbase.replication.TestReplicationKillMasterRSWithSeparateOldWALs

hadoop.hbase.replication.TestSerialReplication

hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL

hadoop.hbase.replication.TestSerialReplicationFailover

hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.replication.TestReplicationSyncUpTool

hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote

hadoop.hbase.replication.TestReplicationDroppedTables

hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL

hadoop.hbase.replication.TestReplicationMetricsforUI

hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedWithRecovery

hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNewOp

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1137

JIRA Issue
HBASE-23804

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 5a5079f92532 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1137/out/precommit/personality/provided.sh

git revision
HBASE-18095/client-locate-meta-no-zookeeper / d110c08dce

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/artifact/out/diff-checkstyle-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/testReport/

asflicense
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
9777 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _

+0 :ok:
mvndep
0m 47s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  7s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
compile
3m 35s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
checkstyle
2m 41s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
refguide
5m 51s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 22s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
spotbugs
4m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
22m 37s
HBASE-18095/client-locate-meta-no-zookeeper passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 37s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
checkstyle
2m 35s
root: The patch generated 0 new + 408 unchanged - 1 fixed = 408 total (was 409)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 26s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 36s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
4m 42s
the patch passed

+1 :green_heart:
findbugs
23m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
177m 59s
root in the patch failed.

-1 :x:
asflicense
1m 48s
The patch generated 1 ASF License warnings.

308m 44s

Reason
Tests

Failed junit tests
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1137

JIRA Issue
HBASE-23804

Optional Tests
dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml refguide

uname
Linux fbbe3dbfc7c8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1137/out/precommit/personality/provided.sh

git revision
HBASE-18095/client-locate-meta-no-zookeeper / d110c08dce

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/testReport/

asflicense
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
5533 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _

+0 :ok:
mvndep
0m 41s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 26s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
compile
2m  8s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
checkstyle
2m 26s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 23s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
spotbugs
4m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 27s
HBASE-18095/client-locate-meta-no-zookeeper passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 34s
the patch passed

+1 :green_heart:
compile
1m 54s
the patch passed

+1 :green_heart:
javac
1m 54s
the patch passed

+1 :green_heart:
checkstyle
0m 25s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 29s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 22s
hbase-server: The patch generated 0 new + 408 unchanged - 1 fixed = 408 total (was 409)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  8s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
1m 24s
the patch passed

+1 :green_heart:
findbugs
6m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 54s
hbase-client in the patch passed.

-1 :x:
unit
76m 15s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
1m 40s
The patch does not generate ASF License warnings.

150m 37s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.regionserver.TestReplicationSink

hadoop.hbase.replication.TestSyncReplicationActive

hadoop.hbase.replication.TestReplicationStatus

hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint

hadoop.hbase.replication.TestReplicationStatusBothNormalAndRecoveryLagging

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1137

JIRA Issue
HBASE-23804

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e7d1a5ce91ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1137/out/precommit/personality/provided.sh

git revision
HBASE-18095/client-locate-meta-no-zookeeper / d110c08dce

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/3/testReport/

Max. process+thread count
9841 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 53s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
compile
1m 53s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
checkstyle
2m 14s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
shadedjars
5m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 19s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
spotbugs
4m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 41s
HBASE-18095/client-locate-meta-no-zookeeper passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 35s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 24s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 29s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 20s
hbase-server: The patch generated 0 new + 408 unchanged - 1 fixed = 408 total (was 409)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 45s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
1m 21s
the patch passed

+1 :green_heart:
findbugs
7m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 15s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  2s
hbase-client in the patch passed.

-1 :x:
unit
136m 46s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
1m 57s
The patch does not generate ASF License warnings.

218m 16s

Reason
Tests

Failed junit tests
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1137

JIRA Issue
HBASE-23804

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 140e0b331b89 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1137/out/precommit/personality/provided.sh

git revision
HBASE-18095/client-locate-meta-no-zookeeper / d110c08dce

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/4/testReport/

Max. process+thread count
6916 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _

+0 :ok:
mvndep
1m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
8m 45s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
compile
2m 38s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
checkstyle
3m 15s
HBASE-18095/client-locate-meta-no-zookeeper passed

+1 :green_heart:
shadedjars
6m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
HBASE-18095/client-locate-meta-no-zookeeper passed

+0 :ok:
spotbugs
6m 42s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
9m 40s
HBASE-18095/client-locate-meta-no-zookeeper passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 57s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

+1 :green_heart:
javac
2m 40s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 42s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 46s
hbase-server: The patch generated 0 new + 408 unchanged - 1 fixed = 408 total (was 409)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
7m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
19m  3s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
1m 19s
the patch passed

+1 :green_heart:
findbugs
7m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 55s
hbase-client in the patch passed.

-1 :x:
unit
99m 59s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
1m 19s
The patch does not generate ASF License warnings.

197m 15s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1137

JIRA Issue
HBASE-23804

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 00581c7182bf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1137/out/precommit/personality/provided.sh

git revision
HBASE-18095/client-locate-meta-no-zookeeper / d0af674e7d

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/5/testReport/

Max. process+thread count
6112 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1137/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Can you help me ?

just in release crashed ！！！

Can you provide us with a reproduction case, or at least more of your code and the inputs that cause the problem to crash, including the RLMOrder definition and whatever code you are using to create and set it up before starting the write transaction?

and NSLog RLMOrder object print this:

Can you guess what went wrong?

@icoder20150719 Sorry for the delay. Could you create a sample Xcode project along with exact steps for us to reproduce? Or please send the entire project that reproduces the bug? You could send it privately to us at<EMAIL_ADDRESS>if you don't wish to share this publicly. Without understanding your code it's difficult to make any progress. If you do we'd be happy to continue looking into the problem. Thanks!

@icoder20150719 I'm just following up on @kishikawakatsumi's request for a sample project that would allow us to debug this for you. Thanks!

@jpsim thanks  a lot;
we has find the  problem that is my code ;my orderModel has a property  without managed by realm;
i am very sorry ;
thank you again;

No problem! Feel free to file new issues if you run into any other problems!

I came along the same error message and crash today after upgrading from Realm 2.1.2 to 2.10.1. The crash happens on iOS 11 and iOS 10 devices and simulators constantly, when the execution reaches the realm.add() function call in the following snippet:
  func insertOrUpdate(object: Object) {
        do {
            let realm = try Realm()

            try realm.write {
                realm.add(object, update: true) // crash here: Target table row index out of range
            }
        } catch let error {
            log.error(error.localizedDescription)
        }
    }

This happens only for some of my Object subclasses, which seemingly share no similarity between one another. If I comment the add() call out, my application runs smoothly without any problems by the way.


Deprecate the function ctrl.Finish()

This PR marks the function ctrl.Finish as Deprecated. It's no need to call this function starting from Go 1.14 when T.Cleanup was added.

If Finish is marked as Deprecated, a large amount of code that has already been written will not pass the golangci-lint check, which will take a long time to transform

If Finish is marked as Deprecated, a large amount of code that has already been written will not pass the golangci-lint check, which will take a long time to transform

I want to echo this. Instead of removing the Finish call directly, can we do a graceful deprecation? For example, we make this Finish call as no-op in the next version (may also print a log when calling this), then remove it in the next major release? This could provide a smoother migrate experience to the user.

I want to echo this. Instead of removing the Finish call directly, can we do a graceful deprecation? For example, we make this Finish call as no-op in the next version (may also print a log when calling this), then remove it in the next major release? This could provide a smoother migrate experience to the user.

It's not being removed, it's being marked as deprecated.

If Finish is marked as Deprecated, a large amount of code that has already been written will not pass the golangci-lint check, which will take a long time to transform

This is fine and expected. People need to configure their linter correctly and plan their work accordingly.
Here's the issue. Deprecations are just notices that exist because removing a method would introduce a breaking change and people need time to update. A deprecation notice gives them the time they need. Now if we start using tools that break everything if we have a deprecation, that would make the whole deprecation thing useless.

Please don't remove this function. It's needed to use gomock with certain testing frameworks, and removing the function would break those use cases.
Please also consider reverting the deprecation. If the function is not going to be removed in a future release, it shouldn't be marked deprecated in the first place.
See https://github.com/uber-go/mock/issues/81 for more details.


WMS GetFeatureInfo examples broken due to 'X-Frame-Options'

Describe the bug
The WMS GetFeatureInfo examples
https://openlayers.org/en/v4.6.5/examples/getfeatureinfo-image.html and
https://openlayers.org/en/latest/examples/getfeatureinfo-tile.html
are broken because the WMS used (https://ahocevar.com/geoserver/wms) has set X-Frame-Options to sameorigin. So showing the result of the GetFeatureInfo request in an IFrame is prohibited.
Tested on Firefox 65.0.1 (64-Bit) and Chromium 71.0.3578.98 (Official Build). Both on an Ubuntu 18.04.
To Reproduce
Steps to reproduce the behavior:

Go to https://openlayers.org/en/v4.6.5/examples/getfeatureinfo-image.html or https://openlayers.org/en/latest/examples/getfeatureinfo-tile.html
Click somewhere in the map
See that the info box below the map stays empty.
By opening a developer console you could see the error due to the 'X-Frame-Options'

Expected behavior
By clicking in the map in one of the above mentioned examples one should see the result of the GetFeatureInfo request in the info box below the map.

I think the iFrame approach is a bit old school. What about updating the examples to use fetch to get feature info?

Absolutely!
What do think about querying the feature (instead of the HTML) and rendering some exemplary properties in the info box?

For the sake of simplicity, I'd prefer the HTML query.

For the sake of simplicity, I'd prefer the HTML query.

Sure that should be fine for the examples.

@chrismayer Would you be willing to create a pull request?

Yes, I will prepare a PR.


Build Presentation: Phase 0

Introduction to Azure Portal, Overview of Day's Agenda

Duplicate of earlier "Build overview" task


Change panorama without reset position

I made this demo:
https://d26dzxoao6i3hh.cloudfront.net/items/0O2f1c192L2y101w0Y3D/ScreenFlow.mp4
Im trying to achieve the same results with panellum, but im facing the problem that each time a new viewer is loaded, the whole "camera" position is reset to the default state, im trying to change the picture without altering the rotation position.

The loadScene method optionally takes pitch, yaw, and hfov parameters; you just need to use the current values when calling it:
viewer.loadScene('newSceneId', viewer.getPitch(), viewer.getYaw(), viewer.getHfov());

where viewer is the Pannellum instance, and newSceneId is the scene ID of the scene you're switching to.


(PUP-5569) acceptance: ensure Resource Collectors can use resource references in search expressions

This change adds a test that uses a yaml terminus for storeconfigs to
test exported resources.  Due to a deficiency in the yaml storeconfigs
terminus we create here, we can not use with_puppet_running_on.
This test solely collects all resources of a given type.  Because filtering is implemented in the puppetdb terminus, it does no good to test it here.  Even testing collecting various types would do no good since this matching is also done in the terminus.
[skip ci]

@branan FYI.  thanks again for the yaml terminus!

Done with review, my comments are about picky small things, or are questions about intention and a possible problem with the random names. Fine to merge otherwise.

updated to address @hlindberg 's concerns.

This changes nothing that unit/integration tests will capture. Merging. @er0ck if you want to change to a regular Set you can always do that later.

i figure, if it has to lookup the environment name in every test, it may as well be fast.  so i used a sortedset with rbtree.


update readme following changes to tutorial sample metadata

Coverage remained the same at 91.393% when pulling 79617090bb1d535f8d2c9e552636e34f8f75aee8 on gregcaporaso-patch-1 into 957689e5f7f87d893ebd210e7b9feb2c36211d75 on master.


Implementation of a random agent

Agent should just take random actions
This will let us have something to visualize before the RL kicks in

Done by @natashamjaques


no data (noob question perhaps)

Hi
I'm able to retrieve data using peerlibrary:aws-sdk, however when I try to read files using cfs:s3 it returns nothing (no data)
I've spent days trying to debug this (including turning on FS Debug) but I still get nothing
Here's my server side code and server log using a known good settings and bucket.
By the way my aws user has full s3 access.
Any help greatly appreciated.
Tony
var imageLargeStore = new FS.Store.S3("imagesLarge", {
  accessKeyId: Meteor.settings.AWS.accessKeyId,
  secretAccessKey: Meteor.settings.AWS.secretAccessKey,
  bucket: "salk-employee-pics"
});
var imageSmallStore = new FS.Store.S3("imagesSmall", {
  accessKeyId: Meteor.settings.AWS.accessKeyId,
  secretAccessKey: Meteor.settings.AWS.secretAccessKey,
  bucket: "salk-employee-pics",
  transformWrite: function(fileObj, readStream, writeStream) {
    gm(readStream, fileObj.name()).resize('80', '80').stream().pipe(writeStream)
  }
});

thumbs = new FS.Collection("images", {
  stores: [imageLargeStore,imageSmallStore]
});

console.log(thumbs.find());

Log
Cursor {
I20170126-21:53:56.273(-8)?   _mongo:
I20170126-21:53:56.273(-8)?    MongoConnection {
I20170126-21:53:56.273(-8)?      _observeMultiplexers:
I20170126-21:53:56.273(-8)?       { '{"ordered":false,"collectionName":"cfs.images.filerecord","selector":{"uploadedAt":{"$exists":true},"copies.imagesLarge":null,"failures.copies.imagesLarge.doneTrying":{"$ne":true}},"options":{"fields":{"copies":0}}}': [Object],
I20170126-21:53:56.274(-8)?         '{"ordered":false,"collectionName":"cfs.images.filerecord","selector":{"uploadedAt":{"$exists":true},"copies.imagesSmall":null,"failures.copies.imagesSmall.doneTrying":{"$ne":true}},"options":{"fields":{"copies":0}}}': [Object],
I20170126-21:53:56.274(-8)?         '{"ordered":false,"collectionName":"cfs.images.filerecord","selector":{"$and":[{"$or":[{"$and":[{"copies.imagesLarge":{"$ne":null}},{"copies.imagesLarge":{"$ne":false}}]},{"failures.copies.imagesLarge.doneTrying":true}]},{"$or":[{"$and":[{"copies.imagesSmall":{"$ne":null}},{"copies.imagesSmall":{"$ne":false}}]},{"failures.copies.imagesSmall.doneTrying":true}]}]},"options":{}}': [Object],
I20170126-21:53:56.274(-8)?         '{"ordered":false,"collectionName":"cfs.images.filerecord","selector":{},"options":{}}': [Object] },
I20170126-21:53:56.274(-8)?      _onFailoverHook: { nextCallbackId: 4, callbacks: [Object], bindEnvironment: true },
I20170126-21:53:56.274(-8)?      db:
I20170126-21:53:56.275(-8)?       EventEmitter {
I20170126-21:53:56.275(-8)?         domain: null,
I20170126-21:53:56.275(-8)?         _events: {},
I20170126-21:53:56.275(-8)?         _eventsCount: 0,
I20170126-21:53:56.275(-8)?         _maxListeners: undefined,
I20170126-21:53:56.275(-8)?         s: [Object],
I20170126-21:53:56.276(-8)?         serverConfig: [Getter],
I20170126-21:53:56.276(-8)?         bufferMaxEntries: [Getter],
I20170126-21:53:56.276(-8)?         databaseName: [Getter] },
I20170126-21:53:56.276(-8)?      _primary: '<IP_ADDRESS>:3001',
I20170126-21:53:56.276(-8)?      _oplogHandle:
I20170126-21:53:56.277(-8)?       OplogHandle {
I20170126-21:53:56.277(-8)?         _oplogUrl: 'mongodb://<IP_ADDRESS>:3001/local',
I20170126-21:53:56.277(-8)?         _dbName: 'meteor',
I20170126-21:53:56.277(-8)?         _oplogLastEntryConnection: [Object],
I20170126-21:53:56.277(-8)?         _oplogTailConnection: [Object],
I20170126-21:53:56.277(-8)?         _stopped: false,
I20170126-21:53:56.278(-8)?         _tailHandle: [Object],
I20170126-21:53:56.278(-8)?         _readyFuture: [Object],
I20170126-21:53:56.278(-8)?         _crossbar: [Object],
I20170126-21:53:56.278(-8)?         _baseOplogSelector: [Object],
I20170126-21:53:56.278(-8)?         _catchingUpFutures: [],
I20170126-21:53:56.278(-8)?         _lastProcessedTS: [Object],
I20170126-21:53:56.278(-8)?         _onSkippedEntriesHook: [Object],
I20170126-21:53:56.278(-8)?         _entryQueue: [Object],
I20170126-21:53:56.279(-8)?         _workerActive: false },
I20170126-21:53:56.279(-8)?      _docFetcher: DocFetcher { _mongoConnection: [Circular], _callbacksForCacheKey: {} } },
I20170126-21:53:56.279(-8)?   _cursorDescription:
I20170126-21:53:56.279(-8)?    CursorDescription {
I20170126-21:53:56.279(-8)?      collectionName: 'cfs.images.filerecord',
I20170126-21:53:56.279(-8)?      selector: {},
I20170126-21:53:56.279(-8)?      options: { transform: [Object] } },
I20170126-21:53:56.280(-8)?   _synchronousCursor: null }

Am I missing anything for having a well formed description of the problem?

try..
console.log(thumbs.find().fetch())

instead of
console.log(thumbs.find())

Hi, I tried your suggestion and still no data.
Question, is it possible to use cfs:s3 on data that is already in a bucket?  Or, do I have to use the cfs:s3 methods to upload data to the bucket and generate necessary metadata?
Many Thanks

I personally have no s3 account and am not so familiar with this particular s3:package, but i would assume there has to be some metadata in a mongo collection somewhere (like in the other cfs:stores), if you want to perform mongo queries on your files. A store is just there to write and delete files ;)
You could either use the common cfs server method Images.insert(path||url) or generate the required metadata yourself somehow. I would suggest testing with an empty/test bucket first ;)

I ended up using peerlibrary/meteor-aws-sdk to load the data from s3 into this package's adaptor (cfs:s3).  Feeling like it's not a great solution, but may have to be good enough for now.

And, I used the insert method you recommended.  Here' what I ended up with:
`	updateEmployeeThumbs: function(){
	var configObj = {
		"accessKeyId": Meteor.settings.AWS.accessKeyId,
		"secretAccessKey": Meteor.settings.AWS.secretAccessKey,
		"bucket": "salk-employee-pics"
	};

	var updateCollectionFs = function(listDataContents){

		_.each(listDataContents,(chunk)=>{

				_.each(chunk,(f)=>{
				var e = EmployeeThumbs.findOne({'original.name':f.Key});
				//for now only insert what's missing, don't update
				if(typeof e == 'undefined' ){

					console.log('here is supposed to be contents for insert');
					console.log(f);

					s3 = new AWS.S3();

					AWS.config.update({
						"accessKeyId": configObj.accessKeyId,
						"secretAccessKey": configObj.secretAccessKey,
						"bucket": configObj.bucket
					});

					var readStream = s3.getObjectSync({
						"Key":f.Key,
						"Bucket":"salk-employee-pics"}
					);
					// You must have a ReadStream with some data; it can be any stream.
					// We're using the standard output from a command as an example.
					//var readStream = spawn('ls', []).stdout;

					// Create the FS.File instance
					var newFile = new FS.File();

					// Attach the ReadStream data to it.
					newFile.attachData(readStream.Body, {type: 'image/jpeg'});

					// Optionally provide a file name
					newFile.name(f.Key);

					// Insert the file, which will save the metadata and
					// store the stream data into all defined stores.
					// `Files` is an `FS.Collection` instance defined elsewhere.
					var thumb = EmployeeThumbs.findOne({'original.name':f.Key});

					if(typeof thumb !== 'undefined'){
						console.log('reloading thumb for '+f.Key);
						EmployeeThumbs.update({'original.name':f.Key},newFile);

					} else{
						console.log('inserting new thumb for '+f.Key);
						EmployeeThumbs.insert(newFile);

					}
				}
			});

		});
	};

	var allKeys = [];

	var listAllObjectsFromS3Bucket = function(configObj,marker){

		AWS.config.update({
			"accessKeyId": configObj.accessKeyId,
			"secretAccessKey": configObj.secretAccessKey,
			"bucket": configObj.bucket
		});

		s3 = new AWS.S3();

		var list = s3.listObjectsSync({Bucket: configObj.bucket, Marker: marker});

		allKeys.push(list.Contents);

		console.log('pushed list of '+ list.Contents.length);

		//console.log(list);

		if(list.IsTruncated){

			console.log('list was truncated, doing it again before upsert');

			var contents = list.Contents;

			var marker = contents[contents.length-1].Key;

			console.log('next marker is:'+marker);

			listAllObjectsFromS3Bucket(configObj,marker);

		} else {

			return allKeys;

		}
	};

	listAllObjectsFromS3Bucket(configObj,'');

	//console.log('here is the allKeys listing:');
	//console.log(allKeys);
	console.log('now going to upsert');
	updateCollectionFs(allKeys);

},`


androguard.core.api_specific_resources: Requested API level 34 is larger than maximum we have, returning API level 28 instead.

Please remove this template if you only have a question or do not want to create a new issue.
Describe what you wanted to do

is this error specific to a single file?
if possible give a minimal working example where the error happens

Describe what you expected
Describe what actually happened
System Information

Androguard Version: master
Python Version: 3.4/3.5/...
Operating System

Further Log Files and Output

please report logs, tracebacks and other useful information
if possible report the files you tried to analyze!
androguard.core.api_specific_resources: Requested API level 34 is larger than maximum we have, returning API level 28 instead.

Please make sure you are using the latest version


[TA] change rolebinding create command parameter roles to comma-seperated

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.
Test:

LGTM
Please also update history.rst (and setup.py if you want to release a new version) and add some description about the change.
Also, since the feature is basically available, time to add a live test case for it?

Updated history, and the tests will added in August.

AKS

/azp run


clarify Trezor xpub solutions

I'm happy to link to ways to protect your privacy with the android app, but there's no explanation of how to do it in the link your commented.
Closing this for now as PRs are for pull requests, not issue discussions (feel free to open an issue).
Thanks!


http://store-api:9091/ not available

Hello @embesozzi!
I tried to do this workshop today and I'm unable to access http://store-api:9091/ after running this command:
docker-compose -f docker-compose.yml -f docker-compose-apps.yml -f docker-compose-openfga.yml up

Here is what I see in Docker:

My /etc/hosts file has:
<IP_ADDRESS>	localhost
<IP_ADDRESS>	keycloak
<IP_ADDRESS>	openfga store store-api

Hi Matt,
Thanks for the feedback. I have resolved the issue by adjusting the port mapping in docker-compose-apps.yml#L26.
I have also made some other minor changes. Could you please pull the latest updates? And then proceed with rebuilding the workshop.
Please let me know if everything is working correctly.

@embesozzi I can confirm that your changes have solved this issue. I'll continue from Post configuration steps tomorrow. I'm closing this issue since it's resolved.


Miscellaneous minor updates to WinCompat

PR Summary
Several small fixes to some WinCompat scenarios:

Removing PS-Core-specific paths from PSModulePath of WinCompat process (Windows PS). Similar change was done previously by #11057 for NativeCommandProcessor. This PR enables same
PSModulePath behavior for WinCompat process (Windows PS) and job's process (Windows PS - for jobs started with -PSVersion 5.1). Without this change there could be bad cases when WinCompat process was loading PS-Core versions of the modules.

Some implicit WinCompat scenarios were ignoring -NoClobber and -Scope parameters. This is now fixed.

Get-PSSession -Name generates an error when the session is not found (in addition to returning nothing). When WinCompat uses Get-PSSession to search for existing WinPSCompatSession session to reuse, such error is not shown to the user but it is written to the error stream. Considering that it is normal for WinPSCompatSession session to not be there before the first WinCompat module import, such error is expected but it may confuse user if it is found in the error stream. The fix is to do Get-PSSession -Name WinPSCompatSession -ErrorAction Ignore.

Fixed a test bug in ModulePath.Tests.ps1.

PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[X] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[X] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[X] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

The Get-PSSession fix is critical for anyone who wants to run this in critical production environment and so uses $ErrorActionPreference = 'Stop'.
It cannot be overridden manually with -ErrorActionPreference:Continue; the only workaround is to set the variable to Continue and then run it, but then you require extra code to detect and parse if any errors occurred loading the module.
Hope this gets merged in and made available ASAP.

@iSazonov looks like this is ready for merge.


Build networks using differential expression from gene mutations

Camilo has updated gene mutation data with all variants of interest. Now, use the amlresistancenetworks code to build networks. and then use James' code to do the enrichment.
1- for each variant of interest, compute differential expression of proteins, phosphosites, and transcripts
2- feed combined set of features into network code
3- build network, push to synapse, visualize using Cytoscape

This was done by @CamiloPosso


HueMagic: Connection to bridge lost. Trying to reconnect again in 30 seconds… Event { type: 'error', message: undefined }

Describe the bug
The Node disconnects from the Hue bridge with the error
HueMagic: Connection to bridge lost. Trying to reconnect again in 30 seconds… Event { type: 'error', message: undefined }
After this all nodes stop to work.
Expected behavior
Just continue working. This was never a problem in previous versions.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:

Node-RED version: 2.2.2
NodeJS version: 12
Device running Node-RED: Raspberry pi 4

Additional context
Hue Magic version 4.2.2

@maconic install the
philipshue-events contrib to get more information from the bridge

Since today i have the same issue but without the connection lost. But the initialisation seams to be broken:
11 Jun 17:00:11 - [info] [hue-bridge:Philips hue] Initializing the bridge (<IP_ADDRESS>)…
11 Jun 17:00:11 - [info] [hue-bridge:Philips hue] Connected to bridge
11 Jun 17:00:12 - [info] [hue-bridge:Philips hue] Processing bridge resources…
11 Jun 17:00:12 - [info] [hue-bridge:Philips hue] TypeError: Cannot read property 'owner' of undefined
11 Jun 17:00:42 - [info] [hue-bridge:Philips hue] Initializing the bridge (<IP_ADDRESS>)…
11 Jun 17:00:42 - [info] [hue-bridge:Philips hue] Connected to bridge
11 Jun 17:00:42 - [info] [hue-bridge:Philips hue] Processing bridge resources…
11 Jun 17:00:42 - [info] [hue-bridge:Philips hue] TypeError: Cannot read property 'owner' of undefined
11 Jun 17:01:12 - [info] [hue-bridge:Philips hue] Initializing the bridge (<IP_ADDRESS>)…
11 Jun 17:01:13 - [info] [hue-bridge:Philips hue] Connected to bridge
11 Jun 17:01:13 - [info] [hue-bridge:Philips hue] Processing bridge resources…
11 Jun 17:01:13 - [info] [hue-bridge:Philips hue] TypeError: Cannot read property 'owner' of undefined
Any ideas?

@AleksCee did you got a bridge update? A lot of problems are related that HUE is moving from API V1 to V2.
It's an Bridge Update process replacing the old API. HueMagic is using some V1 resources when I understand it correct.

@andesse I update the bridge automatic at 3am every day. But I can't see if was updated today.
I have found out by debugging the code where the error is happens an fixed with this:
I add the if(resource){ } block all over the resource-property-checker - in my case it's seams that the part allResources[fullResource["owner"]["rid"]] is undefined at this time.
With this patch the bridge is connected and seams to work - but I' don't know why the error is occurs  - perhaps a ordering/sort problem? Seam that the allResources object is total empty at this time if the error occurs.
this.fullResource = function(resource, allResources = {})
    {
        const scope = this;
        var fullResource = Object.assign({}, resource);
        if(resource){
                if(resource["owner"])
                {
                    fullResource = scope.fullResource(allResources[fullResource["owner"]["rid"]], allResources);
                }
                else if(resource["type"] === "device" || resource["type"] === "room" || resource["type"] === "zone" || resource["type"] === "bridge_home")
                {
                    // RESOLVE SERVICES
                    var allServices = {};

                    for (var i = resource["services"].length - 1; i >= 0; i--)
                    {
                        const targetService = resource["services"][i];
                        const targetType = targetService["rtype"];
                        const targetID = targetService["rid"];

                        if(!allServices[targetType]) { allServices[targetType] = {}; }
                        allServices[targetType][targetID] = Object.assign({}, allResources[targetID]);
                    }

                    // REPLACE SERVICES
                    fullResource["services"] = allServices;
                }
        }
        return fullResource;
    }

@AleksCee i recommend to switch to http requests and not using this contrib. There are several comments in here on other bug reports. There is also an example how to do it.

@andesse  I figure out another behaviour - it's seams that there is a Group with a reverence on action breathe an v1-group-id 16 but if I request the groups with the v1-api there is no group 16... ;) oh man! what's happens?

@AleksCee i think you need the rid for this, cause breath is connected to the service and not the group Id. Try this

@andesse sorry, I did not understand. but with the "patch" of my if-block the HueMagic seams to work. But what did you mean with the http-request? Is your solution to deinstall HueMagic and do all with native http-request or did I misunderstand you?

@AleksCee yes exactly. Here is an example
https://github.com/Foddy/node-red-contrib-huemagic/issues/353
It works so flawless to talk directly to api v2 and it also feels faster. It's just some effort to set it up, but it needs no maintenance and you're not relying on a contrib

Same issue, it's driving my wife crazy since all my dimmer automations have been built with this contrib, so a lot of the time we are unable to use our lights...  I think I will plug them to Hue directly in the meantime but it means all my complex flows will be unusable...
Anyone has an alternative? I understand that I could do it with http request (if I had several hours to spare) but how would I handle incoming traffic for button press events for example?

this.fullResource = function(resource, allResources = {})
{
const scope = this;
var fullResource = Object.assign({}, resource);
if(resource){
if(resource["owner"])
{
fullResource = scope.fullResource(allResources[fullResource["owner"]["rid"]], allResources);
}
else if(resource["type"] === "device" || resource["type"] === "room" || resource["type"] === "zone" || resource["type"] === "bridge_home")
{
// RESOLVE SERVICES
var allServices = {};
                for (var i = resource["services"].length - 1; i >= 0; i--)
                {
                    const targetService = resource["services"][i];
                    const targetType = targetService["rtype"];
                    const targetID = targetService["rid"];

                    if(!allServices[targetType]) { allServices[targetType] = {}; }
                    allServices[targetType][targetID] = Object.assign({}, allResources[targetID]);
                }

                // REPLACE SERVICES
                fullResource["services"] = allServices;
            }
    }
    return fullResource;
}

Does this fix work? In what file should I implement this line of code?

@Faskill contact me with your phone number (incl. country code). I can help via WhatsApp or iMessage with http request that are not that difficult to setup
<EMAIL_ADDRESS>

@Faskill ok, then I can't help, it's to complicated to give an explanation, cause it would be like >50 comments.
Yesterday someone got in contact with me here cause I am happy to help, what went into an 2 hours audio/screen share FaceTime, where I was able to explain every detail.
You can also give send me your Facebook messenger name if this is more convenient.

@Faskill its especially really annoying on GitHub to share like a lot of informations and get a reply like 5 mins later. That cost too much time. Thanks for understanding

@andesse No offense but I’m not giving any personal info to a stranger on the internet. I believe that any help you can provide on Whats’app can be provided on github

https://github.com/Foddy/node-red-contrib-huemagic/issues/353
Stieger81 has his http request system running now.

For me, the best fix was to use the "hue_event" event built by the base HA Hue integration.
In nodered, you can create an event-all node to listen only to "hue_event" type events and you can use your different devices id as a switch to configure your flows as you would with Hue Magic.

@Faskill thats exactly what I am doing. :)

Here my repository for https HUE API V2. It's just a flow with everything you need. https://github.com/andesse/node-red-hue-api.v2-flows


Stuck HTLC output not redeemed after csv expiry

Background
An HTLC that should've been routed to Bitrefill over GloBee.com got stuck, which happens awfully often with the new 0.5 version, so I force closed the channel (https://blockchair.com/bitcoin/transaction/ff07b95c863553b4339a84cc846c965e09397a252d9929402b113de34a0a6a29). That worked fine before, and was of sense since that HTLC wasn't going to get routed and LND would've force closed that channel anyway, so I'd just wait less.
Your environment

v0.5-beta
Windows
bitcoind 0.16.2

Steps to reproduce
Once the local balance output has been redeemed, I've tried to send it on-chain to backend wallet, but encountered #1819 and had to use the suggested solution with dropwtxmgr. I've managed to successfully generate and broadcast that transaction, but pendingchannels output has got stuck in the following state:
{
    "total_limbo_balance": "0",
    "pending_open_channels": [
    ],
    "pending_closing_channels": [
    ],
    "pending_force_closing_channels": [
        {
            "channel": {
                "remote_node_pub": "022c699df736064b51a33017abfc4d577d133f7124ac117d3d9f9633b6297a3b6a",
                "channel_point": "e1d91930fdcfce5ef780a6569c2cba7e15b83fbd53bc674a76d4f5aaa84dd227:0",
                "capacity": "530644",
                "local_balance": "250728",
                "remote_balance": "0"
            },
            "closing_txid": "ff07b95c863553b4339a84cc846c965e09397a252d9929402b113de34a0a6a29",
            "limbo_balance": "0",
            "maturity_height": 0,
            "blocks_til_maturity": 0,
            "recovered_balance": "0",
            "pending_htlcs": [
            ]
        }
    ],
    "waiting_close_channels": [
    ]
}

Without the respective HTLC being listed in pending_htlcs. I've first assumed that it's been removed from the database, but the following log output on start suggests the opposite:
2018-10-09 09:48:16.271 [INF] CNCT: Creating ChannelArbitrators for 1 closing channels
2018-10-09 09:48:16.271 [INF] NTFN: New block epoch subscription
2018-10-09 09:48:16.272 [INF] CNCT: ChannelArbitrator(e1d91930fdcfce5ef780a6569c2cba7e15b83fbd53bc674a76d4f5aaa84dd227:0): starting state=StateWaitingFullResolution
2018-10-09 09:48:16.274 [INF] CNCT: ChannelArbitrator(e1d91930fdcfce5ef780a6569c2cba7e15b83fbd53bc674a76d4f5aaa84dd227:0): still awaiting contract resolution
2018-10-09 09:48:16.274 [INF] CNCT: ChannelArbitrator(e1d91930fdcfce5ef780a6569c2cba7e15b83fbd53bc674a76d4f5aaa84dd227:0): relaunching 1 contract resolvers
2018-10-09 09:48:16.275 [INF] NTFN: New spend subscription: utxo=ff07b95c863553b4339a84cc846c965e09397a252d9929402b113de34a0a6a29:1
2018-10-09 09:48:16.276 [INF] DISC: Authenticated Gossiper is starting
2018-10-09 09:48:16.276 [INF] BRAR: Starting contract observer, watching for breaches.

The closing tx has long reached enough confirmations to redeem both of it's outputs, but it hasn't happened yet for some reason.
Expected behaviour
The HTLC outputs are redeemed upon force close once they are mature
Actual behaviour
They get stuck in unknown state

#1227 really seems related to be related, #1819 is the same as #1919 and is related to the situation with invalid utxo state in lnd's database; which is strange though is that other node on the channel had a direct channel to the payment recipient node, both that one and the channel with me had 144 blocks time lock delta, so 288 blocks should've been enough for it to time one, whereas closing tx has already reached 424 confirmations.


Unable to change the text on an object from the library

Steps to reproduce:

Add the "Sticky notes" library
Place one stickie on the canvas
Select the text tool, write some text over the stickie
Try to change the text afterwards, but it doesn't seem to be possible

It's a nice feature that the text gets "locked" on an object, so they move together (I had to group them manually before), but without being able to change the text afterwards it's close to being unusable.

As a Plus customer, may I get some attention to this issue? It's quite an annoying one.

hey @alexeyzimarev. Sorry about that, we're getting a lot of issues on this repository, so some issues may get lost. For general help, you can always use one of our discord servers or our support email:

Onto your question: I couldn't reproduce the problem.
In fact, I'm not even sure what you're describing is technically possible right now. If you're referring to this library: https://libraries.excalidraw.com/#ferminrp-post-it then those items are composed of line elements, which don't allow for binding text to them. So adding text using the text tool should just place the text over them, and it won't wrap nor be locked to the sticky note.
Could you maybe record a video, or explain in more detail what's happening?
If you're ok with not having the exact look of a sticky note, then I'd suggest to simply create a rectangle with a background color and adding text to it directly. It will be both bound to it, and the text will autowrap:

The issue title is about shapes added from the shape library, not the basic shapes. I have it working for the new shapes (sticky notes), but for some older diagrams it doesn't work.
Here is the recording, I continuously try clicking on the text, and it never lets me edit the text.

Interesting. Can you export the file into .excalidraw so I can take a look? Alternatively, just select the sticky note (including the text) and copy/paste it here (it'll give you a JSON text).

Here's the sticky note:
{"type":"excalidraw/clipboard","elements":[{"type":"line","version":2626,"versionNonce":164051439,"isDeleted":false,"id":"p81KSxAlcCmi_9j_XmDWk","fillStyle":"solid","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"angle":0,"x":1624.12679031863,"y":6826.792189418495,"strokeColor":"#000000","backgroundColor":"#fd7e14","width":211.3916830346147,"height":208.62509381925972,"seed":1789669135,"groupIds":["3eiLCCkwkDs5UDwaMENxN","_Dq4-szz0HtOg43igEcGS"],"strokeSharpness":"sharp","boundElements":[{"id":"2P7XyWGe1GegX-pavAwcI","type":"text"},{"type":"text","id":"2P7XyWGe1GegX-pavAwcI"}],"updated":1649859670257,"link":null,"locked":false,"startBinding":null,"endBinding":null,"lastCommittedPoint":null,"startArrowhead":null,"endArrowhead":null,"points":[[0,0],[207.61683155185338,0.7294583699974784],[211.3916830346147,174.34055042938112],[176.6630493932135,207.1661770792649],[2.264910889656603,208.62509381925972],[0,0]]},{"type":"line","version":837,"versionNonce":1154801793,"isDeleted":false,"id":"JMRHr03Hk-5jl1FEV3fJb","fillStyle":"solid","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"angle":0,"x":1835.1882689059635,"y":7001.853252408127,"strokeColor":"#343a40","backgroundColor":"white","width":36.11111111111131,"height":38.333333333333485,"seed":146623841,"groupIds":["_Dq4-szz0HtOg43igEcGS"],"strokeSharpness":"sharp","boundElements":[],"updated":1649859670257,"link":null,"locked":false,"startBinding":null,"endBinding":null,"lastCommittedPoint":null,"startArrowhead":null,"endArrowhead":null,"points":[[0,0],[-33.88888888888869,-5.000000000000455],[-36.11111111111131,33.33333333333303],[0,0]]},{"type":"text","version":83,"versionNonce":1204298767,"isDeleted":false,"id":"2P7XyWGe1GegX-pavAwcI","fillStyle":"solid","strokeWidth":2,"strokeStyle":"solid","roughness":2,"opacity":100,"angle":0,"x":1629.12679031863,"y":6908.604736328125,"strokeColor":"#000000","backgroundColor":"#12b886","width":201,"height":45,"seed":1720808751,"groupIds":["3eiLCCkwkDs5UDwaMENxN","_Dq4-szz0HtOg43igEcGS"],"strokeSharpness":"sharp","boundElements":[],"updated":1649859670257,"link":null,"locked":false,"fontSize":36,"fontFamily":1,"text":"103","baseline":32,"textAlign":"center","verticalAlign":"middle","containerId":"p81KSxAlcCmi_9j_XmDWk","originalText":"103"}],"files":{}}

Here's the board, it's not private https://app.excalidraw.com/l/9IsNQZkLEQM/BBP9fWRWWS

Thanks. Ok, it seems the text is indeed bound to the sticky note, even though that's not officially supported. There was a bug where under special circumstances it could have happened, and it was fixed only after you've reported the issue (https://github.com/excalidraw/excalidraw/pull/4655), so that's most likely how you ended up with it.
It should still be possible to edit the text by clicking on it with the text tool — at least it works for me. You can then either delete all the text and confirm to remove the text element, or you can take advantage of this bug which will at least autowrap the text to the sticky note :).
Alternative is to use workflow I suggested in https://github.com/excalidraw/excalidraw/issues/4840#issuecomment-1098243101, which is to create regular rectangles.
We might support binding to line(ar) shapes in the future, after we figure out how it should behave around double-clicking/enter, which as you've noticed right now it edits the sticky note line shape instead of editing the text.
Closing as there's nothing actionable — except maybe trying to recover from this bug on reload by fixing the bindings. But this seems enough of an edge case that it's probably better to leave it (and maybe now that you know you can edit it using the text tool, you may prefer the buggy behavior!).


SQLite Comaptibility

There don't seem to be too many differences between the SQL commands for MySQL and SQLite. I'm not sure how a conduct a proper test, but I am about to try some of the functions that I need.
I think that if it works, Squel should be marked to have official support for it. Of course, a full test should be done before that.

i just hit a sqlite issue - insert().setFields({boolfield: true}) => INSERT ... (boolfield) values (TRUE).
sqlite says no such column: TRUE. it'd be nice if squel would translate true/false to 1/0 when the flavor is set to sqlite.

as soon as I posted this, I found squel is already good at doing custom data type handling. thanks!
squel.registerValueHandler('boolean', sqlite_bool)

function sqlite_bool(tf) {
  return tf ? "1" : "0"
}


GitHub pages are not working

there is a problem with src/raw/bower_components/list.js/docu file
temp fix, script:
"preparePushResult": "gulp preparePushResult && del-cli src/raw/bower_components/list.js/docs",

long term fix, proper cleanup of generated sources to not deploy not needed files

already fix by adding nojekyll file


Clarification of the usage of winssh-pageant

Hi,
Thank you for this project. It would be great to give the Windows users the possibility to use OpenSSH with FIDO2 support.
Could you help me with the configuration?

I have downloaded and installed the 64-bit MSI package v<IP_ADDRESS>p1-Beta from Microsofts OpenSSH project without the server:
msiexec /i OpenSSH-x64-v<IP_ADDRESS>.msi REMOVE=Server
After that I switched to the installation folder of OpenSSH and created an ssh key with FIDO2:
.\ssh-keygen.exe  -t ecdsa-sk
Now I downloaded and installed the MSI version v2.1 of winssh-pageant. The bridge is shown in the task manager in autostart.

How do I add my ssh key to putty? Selecting the private key in Connection -> SSH -> Auth -> Private key file for authentication does not work. I get the following error:
Unable to use key file "C:\Users\MyUserName\.ssh\id_ecdsa_sk" (OpenSSH SSH-2 private key (new format))

Hello, and thanks for asking this question. I've struggled with how to word the description/instructions, it can be confusing!
Addressing your points in order:

Absolutely correct. An additional, optional but highly recommended step: Add the OpenSSH directory to your SYSTEM PATH. This way you can use the OpenSSH programs from any location (a must-have for ssh-ing into remote boxes IMO).
Looks correct, But I don't use FIDO2. the Windows OpenSSH Wiki has a page about FIDO2: https://github.com/PowerShell/Win32-OpenSSH/wiki/FIDO---U2F-usage
Correct.

The key takeaway here is that winssh-pageant replaces the need for any of the PuTTY applications, especially pageant. Specifically, winssh-pageant.exe and pageant.exe are mutually exclusive, they both do the same thing and as such only one should be running.

How do I add my ssh key to putty?

You do not add your keys to PuTTY (pageant). You add them to the Windows OpenSSH Key Agent. Run this command:
ssh-add id_ecdsa_sk

That's assuming you've added the OpenSSH location to your System PATH, otherwise use the fully qualified path to the key.
Assuming the OpenSSH.msi install worked (I wasn't able to get REMOVE=Server to work for me but it appears to have worked for you). The installer should have added a new "OpenSSH Authentication Agent" windows service, you can confirm that by running services.msc and checking for that entry. Note, if you are looking in Task Manager -> Services tab, it's just named ssh-agent. Screenshots attached illustrating that.

The service should be added and already running. After you've ssh-add ed your keys once, they will always be loaded when you log in (the authentication is tied to your Windows account login).
Once that's all correct, any programs that "only talk to pageant", like WinSCP, will seamlessly use whatever keys you have loaded, no need to interact with PuTTY or Pageant again!


Create Carto.com Integration with a Connector

Once the RDS is complete in Phase 1, we'd like to support more data visualization integrations.  If you use Carto, you can make a pull request to add support for it with examples to this repo so everyone can benefit.  Use this issue as a place to discuss and collaborate.

Carto is looking into supporting this.  Conversations may happen in September.

Actively working on this and we have a functional prototype!

The beta version of this is live now!
Blog post:
https://carto.com/blog/announcing-carto-waze-open-source-connector/
Direct link:
https://waze-connector.carto.solutions/
Documentation:
https://docs.google.com/document/d/1fAJpQPFgvWR-eFhgrUmKKfWGp2l-7_37OMwnH14iD5U/edit
Code:
https://github.com/CartoDB/carto-waze

This seems great!
Congratulations.
I'll try it
On Thu, Oct 18, 2018 at 3:54 PM Michael Schnuerle<EMAIL_ADDRESS>wrote:

The beta version of this is live now!
Blog post:
https://carto.com/blog/announcing-carto-waze-open-source-connector/
Direct link:
https://waze-connector.carto.solutions/
Documentation:
https://docs.google.com/document/d/1fAJpQPFgvWR-eFhgrUmKKfWGp2l-7_37OMwnH14iD5U/edit
Code:
https://github.com/CartoDB/carto-waze
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LouisvilleMetro/WazeCCPProcessor/issues/27#issuecomment-431121636,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATCfVO2dPSGzAPaiD91FgrbNNUREKrT1ks5umM5bgaJpZM4TfIXH
.

--
João Carabetta
(19) 99944 8764
|| Data Scientist @ CTS - FGV
https://htmlsig.com/t/000001CA95SE
[image: LinkedIn]  https://htmlsig.com/t/000001CC9BV9 [image: Github]
https://htmlsig.com/t/000001C5STHP

The sorce code for the web interface is also available here.

Done for now, but could be improved.


Not working with 23.04 (Lunar Lobster)?

This might be a red herring, but I have two host:

skylake running Ubuntu 22.04.2 (Jammy Jellyfish)
zen3 running Ubuntu 23.04 (Lunar Lobster)

I installed openXC7 on both and it seems to work perfectly on skylake, building blinky in 13s.  However on zen3 everything after Yosys is extremely slow ending in failure:
Time spent: 56% 27x read_verilog (1 sec), 7% 13x design (0 sec), ...
Exporting tile and site type data...
Exporting nodes...
Exporting tile and site instances...
bbasm -l xc7k325tffg676-1.bba ../chipdb/xc7k325tffg676-1.bin
make: bbasm: No such file or directory
make: *** [Makefile:18: ../chipdb/xc7k325tffg676-1.bin] Error 127

Is this known to work/not-work with Lunar Lobster?
ADD: if I run bbasm manually, it crashes:
$ /snap/bin/bbasm -l xc7k325tffg676-1.bba ../chipdb/xc7k325tffg676-1.bin
bbasm: /root/parts/nextpnr-xilinx/src/bba/main.cc:144: int main(int, char**): Assertion `fileOut != nullptr' failed.
Aborted (core dumped)

Sorry, definitely an unrelated problem.

Have you created the alias for bbasm? (Install script does that)

So can we close this ticket then?

I thought I closed it already.  I upgraded skylake to 23.10 and it was fine so clearly it's an unrelated issue, sorry about the noise.


[feat]: Update Vaultwarden to 1.25.2

Prerequisites

[X] I have searched for existing issues that already suggest this feature.

Describe the Feature Request
Current Embassy OS supported Vaultwarden version 1.22.2 is over 1 year old. Newest version of Vaultwarden is 1.25.2 and was released 11 days ago. Update to current version.
Describe the Use Case
Multiple fixes with the current version of Vaultwarden versus the current outdated version supported in Embassy OS.
Describe Preferred Solution
No response
Describe Alternatives
No response
Anything else?
No response

Thank you for the request. This repository is for issues related to EmbassyOS. Closing in favor of https://github.com/Start9Labs/vaultwarden-wrapper/issues/19.


fix(deps): update terraform terraform-ibm-modules/cos/ibm to v8.5.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
patch
8.5.0 -> 8.5.1

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.5.1
Compare Source
Bug Fixes

deps: update terraform-module (#651) (dd1a7c1)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.6.5 :tada:
The release is available on:

GitHub release
v1.6.5

Your semantic-release bot :package::rocket:


Test JDK-21 as OAP runtime.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

@kezhenxu94 Please take a look whether the JDK21 runtime is applied correctly on e2e.
If so, what do you suggest for these JDK21 cases? It passed, which proved OAP is good to run on JDK21. It seems we are good for JDK 11/17/21, and it should not be necessary to test every time.

@kezhenxu94 Please take a look whether the JDK21 runtime is applied correctly on e2e.
If so, what do you suggest for these JDK21 cases? It passed, which proved OAP is good to run on JDK21. It seems we are good for JDK 11/17/21, and it should not be necessary to test every time.

The new cases added in this PR are part of the whole cases we did for Java 11, to be 100% sure that Java 21 works, we should run the whole cases at least 1 time

Make sense. Let's say I am going to change current JDK11 to JDK21, after tests passed, I revert all of them back?

Make sense. Let's say I am going to change current JDK11 to JDK21, after tests passed, I revert all of them back?

Sounds good

@kezhenxu94 Could you verify the changes I made?

@kezhenxu94 Could you verify the changes I made?

The changes looks good to me and the cases seem to pass for Java 21.


Meaning of negative offset in lab table.

Just to clarify that a negative offset in the labResultOffset column of the lab table means the result was taken n minutes before the patient was admitted to the ICU? Are there any other details to be aware of?

Negative offsets correspond with times before the (ICU) unit admission.


Adding support for smartOS This is just a base config that installs the ...

Adding support for smartOS This is just a base config that installs the sensu gems and sensu-client gem and makes the "#{node.sensu.directory}/conf.d/checks" directory on smartOS machines. The rest still needs to be done in your wrapper cookbook.

This is only tested with smartOS clients and Ubuntu master(s) but it might work for a master also? Not one of my requirements (YET).


Build tokenizer for ko/ja

Hello,
I'm trying to build tokenizer app which supports korean/japanese with lindera module. Seems japanese is default supported, but korean needs to build dictionary with following https://github.com/lindera-morphology/lindera-ko-dic-builder.
Is there some guide to use this?

Hi @djKooks ,
To use it from the CLI, give the generated dictionary as a command line argument, as shown in the following URL.
https://github.com/lindera-morphology/lindera-ko-dic-builder#tokenizing-text-using-produced-dictionary
If you want to use it in your application, please give the path to the generated dictionary to Tokenizer::new() as follows.
let mut tokenizer = Tokenizer::new(Mode::Normal, "/path/to/dictionary");

@mosuka thanks for feedback. It works well 🙇
BTW, when I setup dictionary as follows, Japanese tokenizing seems not works well. Do I need to setup dictionary separately by language?

@djKooks ,
Yes, you need to create a tokenizer with a dictionary for each language.

@mosuka  thanks 🙏
One more, could you let me know what Mode is for?
I'm testing by changing Mode::Normal / Mode::Decompose, but setting Mode::Decompose is showing error...
let mut tokenizer = LinderaTokenizer::new(Mode::Decompose, &self.dict);   // <- this not works

Is this appropriate value?

@djKooks
What kind of error are you experiencing?
I'm trying with Lindera CLI, but I'm not getting any errors.
% echo "하네다공항한정토트백" | lindera -d ./lindera-ko-dic-2.1.1-20180720 -m decompose
하네다  NNP,인명,F,하네다,*,*,*,*
공항    NNG,장소,T,공항,*,*,*,*
한정    NNG,*,T,한정,*,*,*,*
토트백  NNG,*,T,토트백,Compound,*,*,토트/NNP/인명+백/NNG/*
EOS

@mosuka I'm trying to use the API
let tokenizer = Tokenizer::new(Mode::Normal, "/path/to/dict");   // <- this works
...
let tokenizer = Tokenizer::new(Mode::Decompose, "/path/to/dict");   // <- this not works

@djKooks Ah, how about this?
Mode::Decompose(Penalty::default())

@mosuka ah, it works now. Thanks~


Problem with datePicker

In the application I need to click through with pywinauto, I have the Date Picker, which looks in the interface just like drop down box, which is empty on default, when you click the drop-down arrow, then calendar is showing up and you can select the date.
 All 3 of the components (for example datePickerFrom and his children), have LegacyAccesible.Name and LegacyAccessible.Value set on "Friday, August 17, 2018" (today), and all of them have role "drop down", and state "focused,focusable". Poping up the Calendar doesn't seem to be noticed by inspect.exe. When I set the date, the values and names are changed for the components.
Is it normal that it looks like this, or it seems like a problem with access to the component? I am newbie to pywinauto, but I feel like some components are missing here.
I tried to use methods click/click_input/invoke/set_text on these components (datePickerFrom/To and their children), but nothing works. Is it possible to select the date with pywinauto in this case?
I'm using backend="uia", pywinauto ver.0.6.5, python 3.7.0
Please advice me something.
Thank you!

Looks like DateTimePickerWrapper is not implemented in UIA backend. And this particular control is detected as Pane anyway. But if this control has NativeWindowHandle property in Inspect.exe, it's possible to re-use wrapper from "win32" backend (at least try this). This should look so:
from pywinauto.controls.common_controls import DateTimePickerWrapper

dateTimeFrom_win32 = DateTimePickerWrapper(dateTimeFrom_wrapper.handle)
dateTimeFrom_win32.set_time(year=2017, month=5, day=23) # if it's date only control (or see full params list)

To choose proper element for creating "win32" wrapper it's useful to make sure ClassName property looks like "DateTimePicker" or "SysDateTimePick32".

Thank you for your reply. Unfortunately it doesn't work for me (RuntimeError: "Failed to set time in Date Time Picker"). Also none of the classes is named like DateTimePicker, but I was trying to set it on 2 wrappers that should be DateTimePicker according to me.
I guess that there is no other workaround for this?

I found the workaround, type_keys method is working for me. Thank you for your support!

OK, since it's custom control, I think we need to qualify this issue as question. Currently it's impossible to support custom controls without app side implementation or workaround like yours. Thanks for update.

Looks like DateTimePickerWrapper is not implemented in UIA backend. And this particular control is detected as Pane anyway. But if this control has NativeWindowHandle property in Inspect.exe, it's possible to re-use wrapper from "win32" backend (at least try this). This should look so:
from pywinauto.controls.common_controls import DateTimePickerWrapper

dateTimeFrom_win32 = DateTimePickerWrapper(dateTimeFrom_wrapper.handle)
dateTimeFrom_win32.set_time(year=2017, month=5, day=23) # if it's date only control (or see full params list)

Hello, sorry to comment on this closed issue, i was struggling with this same problem and successfully tried this method. So just wanted to say that re-using win32 backend worked for me in the end.

I found the workaround, type_keys method is working for me. Thank you for your support!我找到了解决方法，type_keys方法对我有用。感谢您的支持！

Can you provide the code, I'm having the same issue. At first I tried to use DateTimePickerWrapper to set the date, and it did, but the query did not succeed. I had to manually select the date to get it right, and then I tried type_keys and it got me to type, but the year, month, and day were always confused


Make support bundle collection per ns in parallel

Describe the problem/challenge you have

In case of scale agented VM setup with 500 VMs per NS, current approach of support bundle collection will collect bundle per VM. Even if collection takes 1 sec for a VM, for 500 VMs, it will be 500 sec.
Describe the solution you'd like

Can we make collection in parallel, or in batch, like 50 VMs in 1 request.
Anything else you would like to add?

cc @wenyingd


Implemented the Event page's HTML, CSS and also the responsiveness.

Description:

The purpose of this pull request is the implementation of the front-end (HTML and CSS) of the event page and also a little JS by the event team.

Changes Made:

For the event.html: it contains the structure of the event page it also contains a little JavaScript, this is because no file was provided for the JavaScript.

For the CSS/event.css: it contains all the CSS codes for the design on the event page and also the responsiveness.

Related Issue:

Fixes #42

Screenshots (if applicable):

all changes can be found in the event.html and css/event.css file.

@ALX-SE-Algorithmia/code-reviewing-team please kindly check out the pull request made by the event team. We implemented the html, CSS and JS of the event page of Algorithmia's website. Thank you.

Hi @ALX-SE-Algorithmia/code-reviewing-team, A new commit has been made, I was you make a few adjustments to the event page. The adjustments made are:
Added a favicon to the event page
Made the navbar scrollable
Changes the background colour of the "join us" button on the navbar to orange and the text to white, then on hover it switches that is the background colour to white and the font colour then becomes orange.
Please kindly review it....
Thanks

Hy @ALX-SE-Algorithmia/code-reviewing-team, I have updated the event page to meet all the requirements asked. I will list all the updates below:
Changed the favicon
Added intersection observer to the desktop view
Added background color to the navbar
Made the scroll-up arrow obvious
Made the images object fit-> cover
Kindly review, please

Great work!
Kindly try adding transition: all 500ms ease-in-out; after line 98 to add some smooth transitioning when the intersection observer takes effect.
I also noticed the scroll-up looks funny:

Lastly, can you guys have a look at the navigation on smaller screens. Perhaps this

can be transformed into something like such:

I took this just as a sample for your team to have a look at. Thanks!

Our deep appreciation to the Events page team:
@khairatAA @samuelogboye @oladosuabayomi @Adams2004 for their hard work in the implementation of the Events page.
You have all done so well.
PR merged.


chore: refactor Engine onboarding page

Revamps most of the Engine onboarding flows.
Logged out

No Engine instances

Clicking Add Engine Instance

Cloud-hosted link goes to the form.
Self-hosted link goes to https://portal.thirdweb.com/engine/getting-started
Importing an Engine URL

Multiple Engines in the list

Edit an Engine

Removing an Engine

Unauthorized

Cannot reach Engine

Connected w/ Back button

📝 Changed routes:

/dashboard/engine

(view full size)

Commit 7d2260be1c25a91ce58003a152e38dd8b3ee2729 (https://thirdweb-ndxnb3fbj.thirdweb-preview.com).


Playstore not accepting build

The Google playstore is not accepting the buld its asking us to update the OpenSSL packge,
This is not used by us directly so need to try upgrading different packages till its resolved, this was sent by Samuel as he uploaded it to Playstore.
https://support.google.com/faqs/answer/12576638
This was when upload the 1.3.6 version to playstore

This issue is tracked for documentation purpose.


[SBOM] Replace BadgerDB cache by a custom LRU cache with a cleaning mechanism for Trivy

What does this PR do?
Replaces BadgerDB cache by a new custom LRU cache for Trivy with a local storage backed by BoltDB and a clean up mechanism to remove unused entries. It has mechanisms to limit the size in memory and on disk.
The clean up mechanism required to store ArtifactIDs and BlobIDs in the workloadmeta.SBOM so that they can be removed from the cache.
It adds config options to parametrize the cache:
- container_image_collection.sbom.use_custom_cache: Enables the custom cache.
- container_image_collection.sbom.custom_cache_max_disk_size: Maximum total size of the cached objects. It is not equivalent to disk usage. If BoltDB uses extra storage, it will not limited by this config option.
- container_image_collection.sbom.custom_cache_max_cache_entries: Maximum number of cached objects.
- container_image_collection.sbom.custom_cache_gc_interval: Duration interval of garbage collection.
It also adds the following metrics to monitor the custom cache:

sbom_cache_disk_size: Total size, in bytes, of the database as reported by BoltDB.
sbom_cached_object_size: Total size, in bytes, of cached SBOM objects on disk. Limited by container_image_collection.sbom.custom_cache_max_disk_size
sbom_cache_hits_total: Total number of cache hits
sbom_cache_misses_total: Total number of cache misses
sbom_cache_evicts_total: Total number of cache evicts

Motivation
The default Trivy cache based on Boltdb doesn’t work for us, because it doesn’t have any cleanup mechanism. It is ok for a CLI based approach, but for a long running process like the Datadog-Agent it can trigger an high memory and disc usage.
We tried to implement a custom cache based on badgerDB that provide a TTL mechanism, but after some tests we discovered that the DB doesn't fit other criterias that we have:

BadgerDB doesn’t offer an easy way to update TTL of a specific entry

BadgerDB is optimized for large dataset (millions of entries). But it is not our case.

BadgerDB allocate a large disk space event if it doesn’t use it.

Additional Notes
If during a Trivy scan, a cache entry required by the scan is deleted then the scan will be aborted.
We can parametrize the maximum number of entries and the maximum size of cached objects.

Possible Drawbacks / Trade-offs

Memory and disk footprint to measure.

Describe how to test/QA your changes
The PR is divided into multiple commits that can be reviewed one by one.
Verify that the unit tests are passing.
Deploy the agent on an environment with containerd and these settings:
DD_CONTAINER_IMAGE_COLLECTION_METADATA_ENABLED=true
DD_CONTAINER_IMAGE_COLLECTION_SBOM_ENABLED=true
DD_CONTAINER_IMAGE_COLLECTION_SBOM_USE_CUSTOM_CACHE=true
DD_CONTAINER_IMAGE_COLLECTION_SBOM_CACHE_CLEAN_INTERVAL=180

Deploy the agent and pull an image. Check the SBOM generation time with agent workload-list --verbose. In my case, the datadog/agent:latest images takes a few seconds.
Now delete the image, pull it again, and check the generation time again. It should be faster because of the cache.
Delete the image again and wait for the garbage collector which should run every 180s with the settings above.
Pull the image again, it should take a few seconds.

To test the max disk size and max cache entries, the unit tests should be enough. Otherwise you can add log lines to MissingBlobs, set low values to
DD_CONTAINER_IMAGE_COLLECTION_SBOM_CUSTOM_CACHE_MAX_CACHE_ENTRIES and DD_CONTAINER_IMAGE_COLLECTION_SBOM_CUSTOM_CACHE_MAX_DISK_SIZE and pull many images. Be careful, if the values are too low, GetArtifact and GetBlob will return an error, making the scan fail. You can also monitor the metrics listed above. Finally, it might also be possible to inspect the db with the BoltDB CLI.

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

This PR will first be merged on a custom 7.44.x branch and tested on staging. Then it will eventually be merged on main.