Improvements of the .NET Core build

This PR makes the following (in my opinion) improvements:

The build output of the BoogieDriver project is set to the Binaries directory, as for the old build. Thus the compiled executable is written to Binaries/Boogie.dll. The option AppendTargetFrameworkToOutputPath is set to false because otherwise the location would depend on the target framework (e.g., Binaries/netcoreapp2.2/Boogie.dll). Also, the created NuGet package is placed into Binaries/nupkg/.
The lit test tool can now be called with -D dotnet to run the regression tests with the .NET Core build.
A wrapper script Binaries/boogie-dotnet is added. This makes it more convenient to call on the command line or to configure the Emacs Flycheck mode for Boogie.
The build instructions in README.md are cleaned up and emphasize that .NET Core is from now on the preferred way to build/run Boogie. I think this was the consensus from previous discussions. Also, more details for the three supported SMT solvers are given.

@michael-emmi, please let me know if you agree with the above changes, or if anything should be updated.

Just curious, why the wrapper script and all that?
According to the docs you can just install the tool from a package:
dotnet tool install --global --add-source ./nupkg botsay

i.e., the package does not need to exist (yet) in the online NuGet repository.
Also, it seems that local tools are now possible too, avoiding a global install: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install
But maybe creating a script is preferable for some reason?

The wrapper script is intended for developers. During (iterative) development and testing it does not seem right to always do an installation step.
But we should add instructions on how to install the global tool from nuget.org for people who are just interested in using Boogie.

During (iterative) development and testing it does not seem right to always do an installation step.

Agreed, though the step I suggest would be an “install” that is local to the workspace, i.e., after generating BoogieDriver.dll (which is anyhow done in iterative development) generate the package then have dotnet “install” the tool in the workspace directory, which the tests can use — I’m supposing those steps don’t add significant overhead to iterative development.
I think either approach could work, and I suggested the above to avoid having a script that could be generated automatically, and avoid divergence with what’s actually on regular (global) installs.
Anyhow I won’t insist on this point, since I’m not so frequently involved in the Boogie development cycle :-)

@bkragl how about updating .travis.yml to build for dotnet core (also)?
If you do that, then we can almost immediately automate publishing versioned dotnet global tools to NuGet.org with #174.

Sure, we can add a .NET Core build to Travis.
However, I was rethinking my proposed updates in this PR. Specifically, how to run Boogie as a developer and from the Lit tests. I don't particularly like the output of the BoogieDriver project to be written to ./Binaries/ and having that script (actually I would hope that Binaries can be deleted at some point), but the installation you mentioned above is also not completely satisfactory.
I tried dotnet tool install and found that there are three options where exactly one can be given:

--local: This is meant for tools that should be installed and available "locally". It relies on a tool manifest file that specifies the desired tools and versions. However, the actual installation is not done locally, but somewhere in the HOME directory (such that it can be shared in case different projects want to have the same local tool). According to my understanding this would be a perfect use case for Coco/R for us. My plan is to create a Coco/R package on nuget.org that we can include as a local tool into Boogie.

--global: This makes a global installation for the current user. This would be the right thing for a user of Boogie, but not for development/testing.

--tool-path: This takes a directory as target for the installation (which would be truly local). Here we could say --tool-path test-installation. However, it seems that there is no way to explicitly tell dotnet that the installation should be performed from the local package. You have to specify --add-source Source/BoogieDriver/bin/$CONFIGURATION, but I'm not sure if there could be ambiguity if there is already a published version on nuget.org with the same version number (because during development the version number is not yet bumped).

Do you think we should try the last option, or for now call dotnet Source/BoogieDriver/bin/Debug/netcoreapp2.2/BoogieDriver.dll for testing?

BTW, we should perhaps upgrade to .NET Core 3.1 which is a long term support (LTS) release.

Do you think we should try the last option, or for now call dotnet Source/BoogieDriver/bin/Debug/netcoreapp2.2/BoogieDriver.dll for testing?

The would avoid ad-host invocation scripts, as long as the potential caveat you mention can be resolved:

but I'm not sure if there could be ambiguity if there is already a published version on nuget.org with the same version number

I’m supposing that the local installation would take precedence? Is there an easy way to verify this?

BTW, we should perhaps upgrade to .NET Core 3.1 which is a long term support (LTS) release.

Absolutely.

Hey @bkragl just noticed something

A wrapper script Binaries/boogie-dotnet is added. This makes it more convenient to call on the command line or to configure the Emacs Flycheck mode for Boogie.

The current build seems to generate ./Source/BoogieDriver/bin/Debug/netcoreapp3.1/BoogieDriver, which can be invoked directly.

Also see #180 for improvements to the -NetCore.csproj files themselves.

@bkragl how’s this one coming? need any assist?

@bkragl how’s this one coming? need any assist?

I'll post a proposal soon.

@michael-emmi: I basically restarted this PR, pulling in the recent changes we did. I switched the Travis build to .NET Core and added configurations to deploy to nuget.org and GitHub releases (we'll have to see if this works as intended). Unfortunately there seems to be a problem during compilation related to GitVersion.
This is the error message I saw in the build log:
/home/travis/.nuget/packages/gitversiontask/5.1.2/build/GitVersionTask.targets(10,9): error : InvalidOperationException: Could not find a 'develop' or 'master' branch, neither locally nor remotely. [/home/travis/build/boogie-org/boogie/Source/CodeContractsExtender/CodeContractsExtender-NetCore.csproj]

Perhaps the git metadata is not available in the Travis environment? Could you look into that?
If this is fixed, we also have to add a GitHub oauth token, if we want to have files attached to the releases on GitHub.

Perhaps the git metadata is not available in the Travis environment? Could you look into that?

Looks like you have to update increase the clone depth:
https://docs.travis-ci.com/user/customizing-the-build#git-clone-depth

@bkragl is this ready to merge?

The readme file should be updated with a pointer to the NuGet package for people that are only interested in using Boogie, and some more compilation instructions for .NET Core. I can do that tomorrow.
Otherwise I think we can merge.

@bkragl cool let me know when you add those and I can merge when ready.

@bkragl cool let me know when you add those and I can merge when ready.

Done. I also updated the original description of this PR.


[fastdds] update to 3.0.1(rename fastrtps)

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[ ] When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

The FastRTPS project has been renamed to the FastDDS, and there's a new version 3.0, so it's time to rename it like https://github.com/microsoft/vcpkg/pull/38346, I also found this had been tried in https://github.com/microsoft/vcpkg/pull/28181

We are happy to take the rename. This PR needs to be fixed to deindex the old one:

delete ports/fastrtps
delete the entry from versions/baseline.json
DO NOT touch anything in versions/f-/fastrtps.json

Hope that helps!

fastdds requires android-ifaddrs when platform is android, but vcpkg doesn't have this port
requires here
if(ANDROID)
    if((ANDROID_PLATFORM LESS_EQUAL 23) OR (ANDROID_NATIVE_API_LEVEL LESS_EQUAL 23))
        eprosima_find_thirdparty(android-ifaddrs android-ifaddrs)
    endif()
endif()

fastdds used android-ifaddrs as a submodule, https://github.com/michalsrb/android-ifaddrs
how to fix this, need some help😭

CI is instructed to skip many ports which required API level 24 for android. Maybe this is also an option for fastdds?

CI is instructed to skip many ports which required API level 24 for android. Maybe this is also an option for fastdds?

Does this refer to scripts/test_ports/vcpkg-ci-xxx? I found there are some prs related to this folder.

CI is instructed to skip many ports which required API level 24 for android. Maybe this is also an option for fastdds?

Does this refer to scripts/ci.baseline.txt? I found there are some prs related to this file.

I believe so.
When Android was first added to testing we added anything that failed to ci.baseline.txt so that new PRs could still be written without someone needing to fix a world of unrelated stuff.

The following problems occurred during local testing.
[DEBUG] E:\fastdds\downloads\eProsima-Fast-DDS-v3.0.1.tar.gz.6236.part has hash 84333bef4b5264b72129e515c2208048c25794d7d653073298cbf5f43ba95c85f2aa64f30e6911a69daf9affc4dc1e10cea4064da43fdd709bbe04ef1cf1f4d7
error: Missing eProsima-Fast-DDS-v3.0.1.tar.gz and downloads are blocked by x-block-origin.
error: File does not have the expected hash:
url: https://github.com/eProsima/Fast-DDS/archive/v3.0.1.tar.gz
File: E:\fastdds\downloads\eProsima-Fast-DDS-v3.0.1.tar.gz.6236.part
Expected hash: 8ccf3c976220719db59515ec680bb68dbd3bd726f6b6f29b3e9d19acd9b40545e8315109d5ab0c60bc55af7288b890e22f40a513ab56443c4b1c1a40c4d02bb0
Actual hash: 84333bef4b5264b72129e515c2208048c25794d7d653073298cbf5f43ba95c85f2aa64f30e6911a69daf9affc4dc1e10cea4064da43fdd709bbe04ef1cf1f4d7


fix(trin-beacon): fix light client finality update validation

What was wrong?
We were incorrectly validating the LightClientFinalityUpdate content key against the value.
How was it fixed?
Update the comparison because the portal beacon protocol is designed always to return the latest finality update with finalized slot that is bigger or equal to the requested content key.
To-Do

[ ] Clean up commit history and use conventional commits.

peertest_history_offer_propagates_gossip_multiple_large_content_values looks like a flaky test

peertest_history_offer_propagates_gossip_multiple_large_content_values looks like a flaky test

Indeed. I commented here, as I think this caused it to be flaky: https://github.com/ethereum/trin/pull/1514#discussion_r1794839654


x/tools/internal/refactor/inline: analyzer is non-deterministic

Go version
not relevant
Output of go env in your module/workspace:
not relevant

What did you do?
While preparing the reproducer for (https://go.dev/issue/67336), I encounter non-determinism in the analyzer or test-framework. I don't know if there is a smaller reproducer either.
func TestImport(t *testing.T) {
	files := map[string]string{
		"define/my/typ/foo.go": `
		package typ
		type T int
		`,

		"some/other/pkg/foo.go": `
		package pkg
		import "context"
		import "define/my/typ"
		func Foo(typ.T) context.Context{ return nil }
		`,

		"one/more/pkg/foo.go": `
		package pkg
		func Bar() {}
		`,

		"to/be/inlined/foo.go": `
			package inlined

			import "context"
			import "some/other/pkg"
			import "define/my/typ"

			// inlineme
			func Baz(ctx context.Context) context.Context {
				return pkg.Foo(typ.T(5))
			}
		`,

		"b/c/foo.go": `
package c
import (
	"context"
	"to/be/inlined"
	"one/more/pkg"
)

const (
	// This is a variable
	someConst = 5
)

func foo() {
	inlined.Baz(context.TODO()) // want "inline call of inlined.Baz"
	pkg.Bar()
}
		`,
		"b/c/foo.go.golden": `package c
import (
	"context"
	"one/more/pkg"
	pkg0 "some/other/pkg"

	// This is a variable
	"define/my/typ"
)

const (
	someConst = 5
)

func foo() {
	var _ context.Context = context.TODO()
	pkg0.Foo(typ.T(5)) // want "inline call of inlined.Baz"
	pkg.Bar()
}`,
	}
	dir, cleanup, err := analysistest.WriteFiles(files)
	if err != nil {
		t.Fatal(err)
	}
	analysistest.RunWithSuggestedFixes(t, dir, analyzer.Analyzer, "b/c")
	cleanup()
}

What did you see happen?
Sometimes the test fails (non-deterministically) with:
=== RUN   TestImport
    third_party/golang/go_tools/go/analysis/analysistest/analysistest.go:263: suggested fixes failed for /tmp/analysistest1470885990/src/b/c/foo.go:
        --- /tmp/analysistest1470885990/src/b/c/foo.go.golden
        +++ actual
        @@ -14,7 +14,8 @@
         )

         func foo() {
        -       var _ context.Context = context.TODO()
        +       var _ context.
        +               Context = context.TODO()
                pkg0.Foo(typ.T(5)) // want "inline call of inlined.Baz"
                pkg.Bar()
         }
--- FAIL: TestImport (1.43s)

I don't know if this is an issue with the test framework or with the analyzer.
What did you expect to see?
I would expect the test to always pass (minus the bug tracked in https://go.dev/issue/67336).

cc: @adonovan

Thanks for the very helpful test case, which reproduces the bug for me. My immediate guess as to the cause is that the order in which the files (e.g. caller and callee) are added to the token.FileSet is nondeterministic, and that the relative token.Pos values affect the formatter logic that decides when to insert a line break.

Seems like this is not going to make it to v0.17. @adonovan it sounds like you've spent some time thinking about this -- is there a quick fix?

I could not reproduce this, I'm afraid. I suspect it has to do with the offsets caused by import reformatting, which I have fixed in #67336.
Therefore, I think this fixed but can't be sure, so I'll bump to the next release.

Running the test exactly as it appears in the issue body, I can still reproduce the failure nondeterministically (20%) at master (1e0d4ee).
I also notice that the output deterministically (100%) includes a blank line after the import of  "context".

Just ran into this in a test I added, and could reproduce reliable within a couple seconds.
The problem is (again) that we're formatting callee nodes using the caller fset. If ever the callee positions are actually in range of a file in the caller fileset, we can end up with an erroneous line break in between nodes.
I have a fix, which is to clear positions correctly before we ever splice in callee nodes.


Does not support Gradle version 7.6.3

Hello,
I got a base project from the Support team, and I am experiencing an issue when building my Android project using Gradle. The build fails with the following exception:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > /Users/amjadelwakeel/.gradle/caches/transforms-3/5007f4267666fd0bbf211b19157a2323/transformed/jetified-window-java-1.0.0-beta04/META-INF/com/android/build/gradle/aar-metadata.properties (No such file or directory)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s
Error: Gradle task assembleDebug failed with exit code 1

It appears that the build process is failing due to a missing file: aar-metadata.properties in the specified directory. I have not been able to resolve this issue on my own.
Could you please assist me in identifying the cause of this problem and suggest a solution?
Thank you.

@Amjad-kw
Please do share all the details to<EMAIL_ADDRESS>


Update fleet installer

As kolide-quickstart is deprecated, the docker image that gets pulled is targeting the latest tag which got released a couple of days ago.
Within v3 the DB structure is changed so creating the enrollment secret by updating app_configs will fail and accordingly the windows hosts will not be enrolled into the fleet.

Thanks @lnxg33k ! I'm going to test this out and will merge if all works correctly.

I'm going to merge this and then push an update immediately after to address some of the comments

@lnxg33k thanks again for updating this so quickly. I pushed a new PR that addresses a few small things, but you pushing these updates helps me out tremendously, so thank you :)
https://github.com/clong/DetectionLab/pull/488


Mozilla.Firefox  not upgrading even though listed in winget upgrade

Firefox is giving unexpected results
PS C:\Users\r> winget upgrade Mozilla.Firefox
No applicable update found.
however
PS C:\Users\rbarbrow> winget upgrade
Name                 Id                    Version         Available    Source
Mozilla Firefox      Mozilla.Firefox       78.0.2          89.0.1       winget
also winget upgrade --all
upgrades all other packages but "skips" mozilla.firefox with out a mention

Might be related to this https://github.com/microsoft/winget-cli/issues/1191#issuecomment-865210093

Hey can you try now? Hopefully #18751 solved this..

Duplicate of #18751


segmentation fault when tf.histogram_fixed_width receives large value_range and nbins on CPU mode

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.16.1
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When setting the nbins to a large value and the value range to [-np.inf, np.inf], the API tf.histogram_fixed_width will raises a segmentation fault.
Interestingly, I found this issue only occurs on CPU backend while this API works fine on GPU.
Standalone code to reproduce the issue
import os
os.environ['CUDA_VISIBLE_DEVICES'] = ''
import numpy as np
import tensorflow as tf
input = tf.constant([1.,2,3])
bins = 23
out = tf.histogram_fixed_width(input, [-np.inf, np.inf], nbins=bins)  # Segmentation fault (core dumped)
print(out)

### Relevant log output

_No response_

I was able to reproduce the issue on TensorFlow v2.15, v2.16 and tf-nightly. Kindly find the gist of it here.


Added offline geocode sample

Hi @doneill I have created an offline geocoding/reverse geocoding sample. Can you please review the same and let me know of changes if required?
Thanks

@manishk3189 Need to know where to get the data from?

@doneill I have added links in the README to download tpk and locator data from ArcGIS.

@manishk3189 Are the find-route icons supposed to be included with this PR?  If not, please remove.

@manishk3189 Here are some UI/UX comments to work through in addition to the comment on data folders above:
Geocoding:

Remove the ActionBar and replace with a Floating Search Bar
Move the Search button to the left of the search bar to initiate the search, hitting enter on the soft keyboard should also initiate a search
Create a down arrow button on the left of the search bar to show the list of examples

Something similar to the sample screenshot below:

Reverse Geocoding:

Use long press to initiate a reverse geocoding search
Tap hold and drag to allow for real time reverse geocoding.

@doneill I have refactored the sample with the following changes :

Included the floating Search Bar.
The search bar has a dropdown on right which shows a list of address to geocode.
In order to reverse geocode, long press on a location to get the result address in a callout.
For real-time reverse geocoding, select the Pin marker symbol and perform a drag gesture anywhere on the map and results will be reverse geocoded on the fly.
I have also updated the README with the instructions on how to perform geocoding and reverse geocoding.

Can you please review the PR and let me know of changes if required?
Thanks

@doneill The sample now performs real-time reverse geocoding without any touch delay between the position and screen Pin. Also, the address is updated as and when the pin is moved. I have also refactored the drop-down list to a position below the search bar and viewpoint when the sample is launched. Can you please review the changes and let me know of any improvements if needed.
Thanks

@doneill I have updated the README and string resource with directory structure /ArcGIS/samples/OfflineGeocoding/. Also, I have removed extra Geocoding directory which was earlier used for locator data set.

@doneill Apologies, the string resource is updated now. I have also deleted the temporary folder containing the tpk from the PR

@manishk3189 Updates look great! Just some minor comments to address, then we should be able to merge!

@doneill I have accomodated the the review comments in the code. However, I haven't changed the removing of background resource for the LinearLayout in searchview.xml as removing it resulted in transparent background.

Thanks @manishk3189 I will merge.  Nice work!


Typo in Cheatsheet

Hi eveyrone,
I promise i will try to learn how to propose changes myself. But for the moment I spotted
a typo  in this section:
https://docs.brightway.dev/en/latest/content/cheatsheet/importing.html#how-can-i-import-a-local-copy-of-an-ecoinvent-release
In
importer = bi.SingleOutputEcospold2Importer(
    dirpath='<ecoinvent_database_zip_file>',
    dbname='<database_name>'
)
importer.apply_strategies()
importer.write_database()

dbname should read db_name

Thank you for raising this issue. The typo has been fixed.


Temporary fix to handle race condition occuring with updating check run label

Revert "Replaces update with patch for adding checkrun label"
This reverts commit https://github.com/openshift-pipelines/pipelines-as-code/commit/1ffb14d776c67077d46d939e82ab4316b9ec0932.
this is a temporary fix to fix the race condition occuring during
adding the checkrunid label.

Wait for tekton.dev/pipeline label to add checkrun id label
this updates controller to wait for pipeline label in order to
avoid race condition.
this is a temporaray fix, we will update this with a proper fix soon.
this will not any performance change as pipelinerun is created and
started and waiting for adding label will not any effect on execution of
pipelinerun.
in case of concurreny, there may be delay of a few seconds in starting of
first pipelinerun from .tekton directory.
Signed-off-by: Shivam Mukhade<EMAIL_ADDRESS>Submitter Checklist

[x] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[x] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[x] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[x] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[x] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Codecov Report

Merging #789 (93ed255) into main (1ffb14d) will decrease coverage by 0.09%.
The diff coverage is 25.80%.

@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   66.18%   66.09%   -0.10%
==========================================
  Files          75       75
  Lines        4557     4568      +11
==========================================
+ Hits         3016     3019       +3
- Misses       1257     1262       +5
- Partials      284      287       +3

Impacted Files
Coverage Δ

pkg/provider/github/status.go
75.86% <6.25%> (-0.90%)
:arrow_down:

pkg/cli/webhook/github.go
53.84% <42.85%> (-0.61%)
:arrow_down:

pkg/cli/webhook/gitlab.go
53.01% <50.00%> (-0.74%)
:arrow_down:

pkg/webhook/controller.go
0.00% <0.00%> (ø)

pkg/reconciler/finalizer.go
0.00% <0.00%> (ø)

pkg/reconciler/controller.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add Swift plugin

I'm implementing a core plugin to manage Swift versions. As a follow-up work, I'll implement a backend to install community packages representing CLIs.
The current Swift asdf-plugin turns out to be using swiftenv under the hood installing it if absent in the environment using Homebrew (too much indirection).

@pepicrft really sorry it took me so long to get around to this. It looks excellent though. I had some feedback that really is just nitpicks pretty much. The one thing we should get is an e2e test though, https://github.com/jdx/mise/blob/main/e2e/test_erlang is a good example of one you can use as a reference.
You can either just copy test_erlang over to test_swift and push changes here, you will need to ping me to approve the test to execute I think since I don't think you've contributed to mise directly yet but of course I'm happy to do that as often as you need. You can also run the e2e tests via docker, see https://mise.jdx.dev/contributing.html for instruction on that.
If you have any trouble with the e2e test I'd be happy to add that to your PR too.

No worries @jdx. I appreciate your review of the PR.
The implementation is still incomplete, so as soon as I finish it, I'll add an e2e test to ensure everything works as expected.
I have one question. Xcode installations come with a Swift toolchain embedded in the application bundle, which is the one used by default when that version of Xcode is selected via xcode-select. I was wondering if mise ls swift should include that version too. Maybe with a different formatting:
$ mise ls swift
  5.9.0
  5.10.0 (/Applications/Xcode.app)

If you agree, how do you think I should approach it from the Forge trait. I proposed here, but I'm not entirely convinced that's the best idea. In essence, some plugins would be able to provide an additional set of versions that are managed outside of Mise.

Having recently gone through installing swift on linux, there's a couple of issues on different distributions it seems (primarily due to linking to native libraries). Have you been able to test this on multiple distributions?
For example, on arch the most popular package to install swift uses patchelf because the source swift distribution uses incorrect paths (at least for arch). Using https://github.com/swift-server/swiftly as an alternative, has similar issues where just running swift will cause some library not found errors.
I'm not very familiar with swift itself or the best way to resolve this across different distributions, but it would be great if it could accommodate them.
I know there are options when building swift to statically link its dependency libraries too, which might be another avenue to go down?

Thanks @johnpyp! I haven't tested it yet in Linux distributions, but I'll make sure I do before considering the PR ready. What other contributions come to your mind?

For Linux support, the Ubuntu 24.04 builds of Swift 5.10.1 work perfectly under Arch Linux without modification. The Ubuntu 24.04 builds don't seem to exist for all versions yet, but that might be a good option to use if they're available.


HNC: forbid propagated objects from being modified

Manual test:
org1
|

team1

(1) Create a secret in org1. Modification to the origin secret is
allowed, but modification to the secret in team1 is not allowed.
(2) Create ResourceQuota in org1. Create a pod in org1 and see
ResourceQuota has been partially used, but the propagated ResourceQuota
for team1 is not affected.
P.S. #238 will be resolved in another PR. This PR will focus on the refactoring the canonical function.
/resolve #89

/assign @adrianludwin

/lgtm
/approve
/hold
@srampal can you ptal and remove the hold if you're happy?

/assign @srampal

/assign @rjbez17

/lgtm
/approve
/hold cancel


Add workflow badges for CI build and test

This commit adds badges for the CI build.yaml and test.yaml workflow
as the current badge (ci.yaml) does not exist any more.

Great, thank you!
bors r+

@lulf Would you be able to re-run the merge job?
(I ran the failing std/cloud  example locally which passed so perhaps this was just a glitch). Thanks

bors r+

Sorry, I realized that I ran the wrong test locally :disappointed:. I'll take a closer look at this tomorrow.

I think the test is due to some errors on the sandbox service. I'll merge this now, and look into the sandbox issue tomorrow. Thanks!


Added pre-commit to make pylint checks automated.

This will automatically run pylint and others when you try to commit your changes.

Hi @LukasMoll Can you please check @mihaimaruseac's comments and keep us posted ? Thank you!

Hi @LukasMoll Any update on this PR? Please. Thank you!

Hi, sorry for the late reply. I think it might be redundant because of existing CI.


Added favicon

Added Pokeball as a favicon. Favicon is taken from flaticon website

Thank you making this addition but right now i dont think that's an important addition. I will leave this issue open so if i need it in future i will merge it then. Thank your for contributing!

Thank you making this addition but right now i dont think that's an important addition. I will leave this issue open so if i need it in future i will merge it then. Thank your for contributing!

No problem, You can do it in the future if needed. Thank you


sphinx circle integration

PR on top of your PR :)
This are the circle.yml changes to check the building of the docs and the automation of the generation of libratbag.github.io.

No need to keep this one open


Cluster grenades for uplink and security

About the PR

This PR refactors the clustergrenade system, adds a multitude of cluster grenade options to the syndicate uplink, puts the clusterbang in the sectech and adds a new grenade to the sectech.
Grenade types:
Security:

ClusterBang: Splits into three flashbangs after a 3.5 second timer, these flashbangs explode one second after splitting up.
Stinger grenade: A flashbang that additionally releases a spray of rubber pellets.

Syndicate:

Cluster grenade(8TC): Splits into three explosive grenades after a 3.5 second timer, these grenades explode one second after splitting up.
Shrapnel grenade(4TC): A grenade that instead of exploding releases a spray of lethal bullets that pierce mobs in an area around itself.
Incendiary grenade(4TC): A shrapnel grenade that shoots piercing incendiary bullets, igniting anyone near the detonation area.
Cluster banana peel(clown exclusive, 6TC): After landing on the floor it splits into 6 explosive banana peels, these banana peels have a 20 second timer if nobody slips on them.
Slipocalypse ClusterBang(3TC): After landing on the floor it litters the area with 30 small pieces of syndicate soap, these pieces of soap evaporate after 60 seconds.

Other changes:

Buffed the explosive banana peel so that it deals 60 damage to an unarmored target when stepped on.
Instead of 4 frag grenades and 4 blast grenades the china lake bundle now contains 2 frag, 2 blast, 2 incendiary and 2 shrapnel grenades. The incendiary and shrapnel grenades explode at a static distance, don't trigger if hitting a mob but pierces them instead and don't trigger at all if they hit a wall before triggering.

Media

https://github.com/space-wizards/space-station-14/assets/137322659/aae3de4b-660b-4a9e-a632-047e0577fd54

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Dygon

add: Added a new type of grenade, these grenades release a spray of bullets instead of exploding: Shrapnel grenade, Stinger grenade and Incendiary grenade.
add: Added two types of cluster grenade: The ClusterBang and the Cluster grenade, these split into three flashbangs and three explosive grenades.
add: Stinger grenades and ClusterBangs are now available in the sectech.
add: Incendiary grenades, Shrapnel grenades and Cluster grenades are now available in the syndicate uplink.
add: Added the cluster banana peel to the uplink of syndicate clowns, it splits into multiple explosive banana peels after throwing.
add: Added the Slipocalypse ClusterBang to the syndicate uplink, this grenade spreads small pieces of syndicate soap over an area after being thrown.
tweak: The china lake bundle now contains 2 timed shrapnel grenades, 2 timed incendiary grenades, 2 frag grenades and 2 blast grenades.
tweak: Explosive banana peels are now more explosive.

I absolutely love this!

maybe add some of the new grenades into the nukie grenade vest

still working on this?

Merge after https://github.com/space-wizards/space-station-14/pull/13747/

@Arendian conflicts please

Re-open if you get a chance to work on it.

I don't think I am able to reopen it so I'll make a new one


yqutil: fix to preserve line breaks

yamlfmt works by replacing line breaks with place holder strings to avoid their loss when using gopkg.in/yaml.v3. By replacing line breaks with place holder strings before yqlib uses gopkg.in/yaml.v3, we can ultimately prevent the loss of line breaks through yamlfmt.
https://github.com/lima-vm/lima/pull/2593#issuecomment-2351462571

I rewrote it to avoid relying on yamlfmt's internal code.

Thanks! 🙏🏻


set ros2cs_tests CSHARP_TARGET_FRAMEWORK

This PR fixes Issue #39 and a part of Issue #43 by setting CSHARP_TARGET_FRAMEWORK for ros2cs_tests to netcoreapp6.0 to prevent using the new fallback.
It also updates the installation READMEs.

@pijaro will review this after he comes back from the leave (next week). Apologies for the delay!

This PR could be useful. Any reason you decided to close it? 🤔


Show a complete react preview in docs

The docs hint at how React can be used instead of the bloated h(....) syntax but there's nothing I can find. I don't want to reimport React so perhaps you can share a real example:
https://www.netlifycms.org/docs/customization/
export default class ArticlePreview extends React.Component {
  render() {
    const {entry, fieldsMetaData} = this.props;
    const author = fieldsMetaData.getIn(['authors', data.author]);

    return

{ entry.getIn(['data', 'title']) }

      {author &&<AuthorBio author={author.toJS()}/>}

  }
}

Can you please provide a complete example?

Sure, here's an example: https://github.com/openpracticelibrary/openpracticelibrary/pull/384/files
Sent with GitHawk

Though isn't react already part of admin? I was almost expecting an internal reference?

Are you using a build system?
Sent with GitHawk


Cannot install on ST3 Portable build 3065

I'm using ST3 Portable build 3065, and after following the installation instructions for ST3 I'm still not seeing any syntax highlighting for a .cfm file. Are there any other steps that I should do after git checkout development?

I also am having issues installing on the latest ST3 build 3083. Did exactly as described but no syntax highlighting. I am unable to see the syntax in the syntax menu.

Same here...Stuck at this stage.

I later found out it's a known compatibility issue, so the only solution for now is to use ST2 instead.

Alright, will do that then. Thanks!


[CI/CD] Configure the nightly build to run on Windows

Currently, the nightly build of the XSK runs on ubuntu only. We should run it on windows too in order to quickly find any regressions happening on the Windows OS.
There are some steps in the nightly build that should be changed depending on the OS. For example, some dependencies are being downloaded using Linux-specific package managers and some tools used in the GitHub action may not be available on Windows.

This issue is closed as the project is no longer maintained


BUGFIX infinite loop on deserializing

Priority
High priority. Blocking
What Changed & Why
Fixes bug described at https://github.com/twg/devour/issues/47.
The main change is that now the function resource and collection from the module src/middleware/json-api/_deserialize.js implement caching to avoid an infinite loop during deserialization of a resource whose relationships were circular, i.e: when a resource A has and belongs to many resource B. Example schema:
// phone-number
//   number: str
//
// user-phone-number-link
//  user-id: foreign_key
//  phone-number-id: foreign-key
//
// user
//   email: str

... a "user" has many "phone_numbers" and vice-versa.
Testing
List step-by-step how to test the changes.

[x] Go to master branch and write some circular schema
[x] Test it and watch if fail like described
[x] Perform the same test under PR branch and check whether error is fixed. The API of the library should not have changed.
[ ] Automated tests pending

Bug/Ticket Tracker
https://github.com/twg/devour/issues/47.
In Progress/Follow Up
Tests pending

Hi @nicooga are you still interested in getting this in?  I've been trying to re-produce the original error you pointed out.  Can you re-post the models and raw json-api payload that the deserializer is having trouble with?  Either as a comment here or in the form of a test. Cheers, josh


libVLC.dll is not traced

FileNotFoundError: Could not find module 'libvlc.dll' (or one of its dependencies). Try using the full path with constructor syntax.

Yeah, same here. CAn't figure out any troubleshooting tactics from the documentation. There are less .py files tahn before. configure.py doesn't seem to work, nor the debugger.

For the sake of additional information, do you have VLC installed? You don't need it if not, but it may fix your issue in the meantime.
Could you send the full traceback (you can censor your username if it shows up)?

Traceback (most recent call last):
File "F:\ZPS\BSC\New folder\EdgewarePlusPlus-main\EdgewarePlusPlus-main\edgeware\src\config.py", line 44, in
from panic import send_panic
File "F:\ZPS\BSC\New folder\EdgewarePlusPlus-main\EdgewarePlusPlus-main\edgeware\src\panic.py", line 6, in
from settings import Settings
File "F:\ZPS\BSC\New folder\EdgewarePlusPlus-main\EdgewarePlusPlus-main\edgeware\src\settings.py", line 7, in
import vlc
File "C:\Users\User\AppData\Local\Programs\Python\Python312\Lib\site-packages\vlc.py", line 220, in
dll, plugin_path  = find_lib()
^^^^^^^^^^
File "C:\Users\User\AppData\Local\Programs\Python\Python312\Lib\site-packages\vlc.py", line 180, in find_lib
dll = ctypes.CDLL('.\' + libname)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\User\AppData\Local\Programs\Python\Python312\Lib\ctypes_init_.py", line 379, in init
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: Could not find module 'F:\ZPS\BSC\New folder\EdgewarePlusPlus-main\EdgewarePlusPlus-main\edgeware\libvlc.dll' (or one of its dependencies). Try using the full path with constructor syntax.
Done
Select number:

Thanks! I pushed a potential fix for this, does it work in the newest version?

I'm going to assume this has been fixed now. If there are still problems, feel free to open another issue.


"Insert Admonition" creation not possible without having to use the mouse

Hello,
and first of all: Thank you for a great plugin!
Behavior
When creating an Admonition via the command palette, after selecting the type (can be done with the keyboard beautifully, including search, bravo!) it is not possible to either switch to the other options (title, collapsible) or to create it without having to use the mouse. I tried TAB and all possible combinations of MOD-ENTER.
Feature request
If would be great if you could add keyboard-only creation.
Sys info
Win10x64 21H1, Obsidian v0.12.12

You should now be able to complete the whole modal with just the keyboard in 6.3.1.

Perfect, thank you : )


Allow simulating with more parameters

@jmlarson1 can you try this out?
Note: with more entangle-rotate layers, it made sense to me to revert our change to the order of parameters.  The order now is:
[ initial_rotation_angle, initial_rotation_axis, entangling_time, ***, final_rotation_angle, final_rotation_axis ]
where *** = [rotation_angle, entangling time, rotation_angle, entangling_time, ...., entangling_time] must be an even number of parameters.
All rotations in *** are about the X axis.

With @jmlarson1's help I found a bug in this PR.  The bug was fixed here, but it also inspired me to run some more careful comparisons between numerics and analytics.  I'll do those before merging.

Change of plans: I'm pretty confident (95 %) that this is correct, but don't have the time at the moment to verify with the degree of care I would like.  I'll merge so as to not have this PR blocked, but flag it for checking in the future.


Bump go-git to v5.6.1

Description
Fixes #118 .

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Bump go-git dependency to version v5.6.1.
Migration Guide

Thanks for review! Going to merge this in now.


Two embeds_ones store only one object if class_name is same

I have a bug which sounds like

https://github.com/mongoid/mongoid/issues/990
https://github.com/mongoid/mongoid/issues/1444

To reproduce, use the following files (tested with Rails 3.2.1, mongoid 2.4.3, rspec 2.8.0). I'm using jruby <IP_ADDRESS> (in ruby 1.8.7-mode).
Head model:
class Head
    include Mongoid::Document
    embeds_one :left_eye,  :class_name => 'Eye', :inverse_of => :head
    embeds_one :right_eye, :class_name => 'Eye', :inverse_of => :head
end

Eye model:
class Eye
    include Mongoid::Document
    embedded_in :head, :class_name => 'Head', :inverse_of => :left_eye
    embedded_in :head, :class_name => 'Head', :inverse_of => :right_eye
    field :color,
        :type => String
end

The rspec test which shows the error:
describe Head do

  before(:each) do
    # create a new head with two eyes
    @new_head = Head.create
    @new_head.left_eye = Eye.create(
      :head  => @new_head,
      :color => 'brown'
    )
    @new_head.right_eye = Eye.create(
      :head  => @new_head,
      :color => 'blue'
    )
  end

  it 'should be able to store two different colored eyses.' do
    @new_head.right_eye.class.should == Eye
    @new_head.left_eye.class.should  == Eye
  end

  it 'should have eyes after reloading.' do
    @new_head.reload
    @new_head.right_eye.class.should == Eye
    @new_head.left_eye.class.should  == Eye
  end

end

The output of the test is as follows:
$ bundle exec rspec spec/models/head_spec.rb
.F

Failures:

  1) Head should have eyes after reloading.
     Failure/Error: @new_head.right_eye.class.should == Eye
       expected: Eye
            got: NilClass (using ==)
       Diff:
       @@ -1,2 +1,2 @@
       -Eye
       +NilClass
     # ./spec/models/head_spec.rb:31:in `(root)'

Finished in 0.119 seconds
2 examples, 1 failure

Failed examples:

rspec ./spec/models/head_spec.rb:29 # Head should have eyes after reloading.

This error occurs (if my investigations were right) since mongoid 2.2. As I mentioned above, I created a very blank rails app and followed all instructions to set up the app. Please let me know, if anyone else encounters this bug.
Thanks,
Daniel

This problem also affects version 2.1 of mongoid, but NOT 2.0.0.beta20.

I don't see how this worked in any version of Mongoid. You've overridden the first embedded_in :head macro with another one... In this case, on any version, everything would be stored in :left_eye.
You need to change the name of one of them:
embedded_in :head_left, :class_name => 'Head', :inverse_of => :left_eye
embedded_in :head_right, :class_name => 'Head', :inverse_of => :right_eye


Move HTTP internal only components to the Internal namespace

There are some HTTP components which are not expected to be used by end-users but only for services.

HttpPipeline
HttpRequest
HttpUrl

However, there is currently a dependency problem that need to be addressed.
The HttpTransport base class defines the send method which requires an HttpRequest:
std::unique_ptr<RawResponse> Send(Context const& context, Request& request) override;

If the HttpTranport is moved to the internal namespace, anyone interested in implementing a new Transport Adapter would need to consume the Internal namespace.
If the HttpTransport remains public, it would need to consume and expose the Request class from the internal namespace.
@JeffreyRichter  @RickWinter
Please take a look and comment about the options.
The last option would be to let all Http components as public (Like it currently is)

If the HttpTranport is moved to the internal namespace, anyone interested in implementing a new Transport Adapter would need to consume the Internal namespace.

If the HttpTransport remains public, it would need to consume and expose the Request class from the internal namespace.

Neither option seems ideal.

The last option would be to let all Http components as public (Like it currently is)

I like this :)
I am not suggesting we do this, but what about keeping Request public but making HttpPipeline internal, as another option?

If the HttpTranport is moved to the internal namespace, anyone interested in implementing a new Transport Adapter would need to consume the Internal namespace.

If the HttpTransport remains public, it would need to consume and expose the Request class from the internal namespace.

Neither option seems ideal.

The last option would be to let all Http components as public (Like it currently is)

I like this :)
I am not suggesting we do this, but what about keeping Request public but making HttpPipeline internal, as another option?

but what about keeping Request public but making HttpPipeline internal,

The pipeline also uses the Request. It exposes a public Send()  method to start the pipeline

but what about keeping Request public but making HttpPipeline internal,

The pipeline also uses the Request. It exposes a public Send()  method to start the pipeline

That's fine, right? An internal type can take a dependency on a public type. So, why would making pipeline internal be an issue (even if it exposes Request), when Request is already public.

That's fine, right? An internal type can take a dependency on a public type. So, why would making pipeline internal be an issue (even if it exposes Request), when Request is already public.

If customers create their own pipeline policies, then these need to be public for them

If customers create their own pipeline policies, then these need to be public for them

If customers create their own pipeline policies, then these need to be public for them

They would include policy.hpp header which defines an HttpPolicy to create a new policy.  However, customer can't create and start a pipeline directly. For that, they need to use an SDK client.
The SDK client should provide a way to add custom policies to it

If customers create their own pipeline policies, then these need to be public for them

They would include policy.hpp header which defines an HttpPolicy to create a new policy.  However, customer can't create and start a pipeline directly. For that, they need to use an SDK client.
The SDK client should provide a way to add custom policies to it

The customer's policy would be passed a Request. Doesn't this expose fields/methods that use HttpUrl and/or HttpRequest?

The customer's policy would be passed a Request. Doesn't this expose fields/methods that use HttpUrl and/or HttpRequest?

We should not place anything in the Internal namespace that a customer may use.
@vhvb1989 Are there other questions on this topic or is this issue able to be closed?

@RickWinter The http pipeline is not used by end users, only by service clients. This issue requires to move the pipeline class to be internal.
We also mentioned before that all policies should be internal as well, since end users are not expected to use them. Only the base class Policy would be public for end users to be able to create policies. Then they need to use an sdk client to add those policies

Closed by #1642

We use the internal namespace for things that we offer to other Azure service teams building client libraries whose code also resides in our repo. The internal abstractions are not well documented and are designed to support only the scenarios that Azure service teams require; they are not designed in a general-purpose way and we do not support them for general consumption.
So, you can use our internal abstractions but we do not guarantee their fitness for your scenario and we may break compatibility in future versions.


Configurations List Api is broken?

Idea Title
Be as descriptive as you can with your idea/bug report/question/suggestion.
Issue Details
When using the api specified here , the list api works fine. However, when specifying any scope parameters using the format specified in the page, the value returned is always an empty list
{     "count": 0,     "value": [] }
When i have no scope specified, I get a list of policies which have this field
eg: "scope": [                     {                         "refName": "refs/heads/master",                         "matchKind": "Exact",                         "repositoryId": "{repo-id}"                     }                 ]
Using the refName or the repository id with wildcards, or using them both to specify the scope always returns the empty value as above. Using the policy parameter works fine
Has anything changes with regards to how this api is documents/set up???

@erickson-doug Can you take a look at this issue?

@erickson-doug Any update?

Sent a email to @erickson-doug to follow up

@wnjenkin @elbatk Can you help assign to the right person?

@arsunda Your issue is transferred to vsts-rest-api team. They will help you there. I will close as transferred. If you have other question related to this issue, we can reopen it and continue discussion.


Set containerized keystone deployment by default

Signed-off-by: leonwanghui<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 30.297% when pulling b1c5fe44652bf984bde46d6ffefd84b2fe0ced4f on leonwanghui:devsds-update into 01cc18603670980928a5280a85071268bfe64026 on opensds:development.


[rtmidi] no absolute paths

Also the version was not properly updated here: https://github.com/microsoft/vcpkg/pull/24201/files#diff-56d7907c64bfc3961cf5c5f7d94ea31a04dcc8bf58f3cdbb8dc24b9628114205

Sorry, this was my fault. I think in this case it is appropriate to update the previous version entry as well.

Thanks!


Sentry Integration

Sentry is a popular error reporting product used by many companies. I am going to reach production in a few weeks and it occurred to me that pachyderm doesn't report job failures anywhere except pachctl.
Raven, the Sentry client is ported to many languages and it may or may not be feasible to implement the integration for each language port of Raven.
pachd could instead proxy between the Sentry server and the worker and add additional context about the job, commit, files affected, pachyderm version and more.
The protocol is described in https://docs.sentry.io/clientdev/overview/ and specifically, the contexts are at https://docs.sentry.io/clientdev/interfaces/contexts/ which is where pachd should add the additional information.
The alternatives are to implement the enrichment for each Raven client or leave it to the users to do so.
The problem with the latter alternative is that currently, it seems that each worker doesn't expose the necessary metadata in order to enrich the error report.

stale


Better filtering of input

In default case, do not treat Ctrl + Shift + <character/symbol> the same way as Ctrl + <character/symbol>.
This lead to cases like Ctrl + Shift + C being handled like Ctrl + C

@parisk done

LGTM :cake:


Fix conflicts

Cleaning up https://github.com/jump-cellpainting/pilot-cpjump1-data/commit/bee140eff514f7fea3e66ccda215bb4566a0b590

.gitignore needs fixing too @niranjchandrasekaran


feat(GridForm): Allow overriding submit's disabled and outline props

Overview
PR Checklist

[x] Related to Abstract designs:
[x] Related to JIRA ticket: GM-55
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

Description
Removes the Omit restriction from the submit prop for <GridForm>s. Adds it to the "is this disabled?" logic as an || submit.disabled at the end.
Additionally adds an outline prop to GridFormSubmitProps that can be used in consuming forms. The Business Account Management tool uses it.

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.46-alpha.89e2d8.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f15dcdf5311e8cbc8090de7--codecademy-styleguide.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.46-alpha.a16400.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f15e1b520deb66c1f0a7978--codecademy-styleguide.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.46-alpha.584490.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f15e400be952894230caacc--codecademy-styleguide.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5f170087a9fd1aea49fc9d0c--codecademy-styleguide.netlify.appDeploy Logs


Update the main site styling

Right now we have a temporary landing page I'm going to push to healthequitytracker.org, the idea is for the rest of the site to match that.

Update the app bar to use the logo
Update the app bar to be white background and purple text
Update the theme colors and fonts to match the mocks

I think we need a bit more specification on what the main site will look like - I'm not sure how exactly the temporary landing page styles map to the explore data page or data downloads page.

@kkatzen FYI

@kkatzen FYI

This is covered by work on static landing pages that is already in progress


HTTPError: 403 Client Error: Forbidden for url: https://redfin.com/stingray/do/location-autocomplete?location=4544+Radnor+St%2C+Detroit+Michigan&v=2

from redfin import Redfin

client = Redfin()

address = '4544 Radnor St, Detroit Michigan'

response = client.search(address)
url = response['payload']['exactMatch']['url']
initial_info = client.initial_info(url)

property_id = initial_info['payload']['propertyId']
listing_id = initial_info['payload']['listingId']

mls_data = client.below_the_fold(property_id, listing_id)

---------------------------------------------------------------------------
HTTPError                                 Traceback (most recent call last)
<ipython-input-11-d6fe599d587c> in <module>()
      5 address = '4544 Radnor St, Detroit Michigan'
      6
----> 7 response = client.search(address)
      8 url = response['payload']['exactMatch']['url']
      9 initial_info = client.initial_info(url)

2 frames
/usr/local/lib/python3.7/dist-packages/requests/models.py in raise_for_status(self)
    939
    940         if http_error_msg:
--> 941             raise HTTPError(http_error_msg, response=self)
    942
    943     def close(self):

HTTPError: 403 Client Error: Forbidden for url: https://redfin.com/stingray/do/location-autocomplete?location=4544+Radnor+St%2C+Detroit+Michigan&v=2

@vpmkw

Closing unless more information is provided.

Hey @reteps, piggybacking on this thread since I'm getting the same error.
I ran the command you and got this output:


Apply SDK default configs consistently for Call Visualizer and Chat/Call screens

Screen sharing bubble is not displayed until the app passes chat engagement flow
What problems do these changes solve?

If GliaWidgetsConfig.setUseOverlay() is not set on Glia init, bubble is not displayed for CallVisualizer screen sharing (wrong)  but is displayed for regular engagements (correct)
If GliaWidgetsConfig.setUseOverlay(false) is set, bubble is not displayed for CallVisualizer screen sharing (correct) but is still displayed for regular engagements (wrong)

The reason for that was the inconsistent usage of default values.

!merge


Feature: Add z-index values to report

I think this would be useful to see if you've ended up with ridiculous z-indexes! :+1:

Not sure how to list these tho. Show highest? Show total?
I have a little script here that lists all z-index properties, which can be a good thing to once in a while. But maybe it’s a but much for this plugin?

Or show all unique values, like here? (personal very early side project): https://projectwallace.herokuapp.com/users/1/projects/8/metrics/unique_zindexes

@vincentorback @bartveneman Personally I'd like to see the highest value and the total number of unique values. I don't think anything else is really all that useful. If you see that you've got high figure of 9999 or you have 150 (for example) different values then you know that's silly and you need to intervene.

That sounds reasonable, although I've seen some projects using groupings like 100-103 for site headers, 200-204 for some component and 900-910 for modals. As always, I guess: it depends

Yeah, it’s a good thing to see all of your z-index's to see that they stack with a reasonable amount. But I’m not sure it’s parkers job to show this. So maybe showing highest and total is good enough!

Personally I'd like to see the highest value and the total number of unique values.

But I’m not sure it’s parkers job to show this. So maybe showing highest and total is good enough!

I think you're both right. Parker usually shows averages/means, so deviating from that would be indeed a little strange.


Add support of @> operator.

Is your feature request related to a problem? Please describe.
I has an table, what cannot be migrated to normal architecure.
Schema:

Currently i can't check does that array contains item from other array, like in sequelize i can:
where: {
  follows: { [Op.contains]: [128644134] },
  service: 'telegram'
}

Describe the solution you'd like
Add new operator $contains, with @> implementation
Describe alternatives you've considered
Cannot imagine.
Additional context
My english is not quiet good, again what i wants:
i has array in my column, like [123, 321], and i wan't check does [123, 321] contains any item from where query $contains: [321]

Implemented in v4 via https://github.com/mikro-orm/mikro-orm/commit/f70803f538e039f02f3d2563e09601c9c6e7a5a0


Add chainer_chemistry.version

This PR adds chainer_chemistry.__version__ which specifies the version of Chainer Chemistry.

What is the reason that we need _version.py? Ins't it ok to just add version in __init__.py ?

I follow the discussion in chainer/chainer#3628.

Could you merge https://github.com/pfnet-research/chainer-chemistry/pull/47
and run the test again?
If test passes, I will merge it.

I kicked travis again.

It seems error comes from this PR.
setup.py  dont contain import os.
Could you check it ?
(and if possible, could you merge #36 at first?)

Sorry, I overlooked the error. I updated the code.

LGTM.


[MRG] Fix infinite gradients

Fixes https://github.com/scikit-optimize/scikit-optimize/issues/266

Current coverage is 85.29% (diff: 100%)

Merging #268 into master will increase coverage by 0.30%

@@             master       #268   diff @@
==========================================
  Files            25         25
  Lines          1332       1360    +28
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1132       1160    +28
  Misses          200        200
  Partials          0          0

Powered by Codecov. Last update e75d11a...e232bfa

@betatim @glouppe reviews? I'm no longer able to reproduce the bug reported.

Updated benchmarks:
Branin:
Mean optimum: 0.401670639097
Std of optimal values0.00555080380794
Best optima:0.3981513906
Mean func_calls to reach min: 61.6
Std func_calls to reach min: 25.7689735923
Fastest no of func_calls to reach min: 30

Hart6:
Mean optimum: -3.03880773988
Std of optimal values0.135679431367
Best optima:-3.29936142128
Mean func_calls to reach min: 76.6
Std func_calls to reach min: 35.2510992736
Fastest no of func_calls to reach min: 31

Other than the small comments above 👍. My only complaint is that you are way to fast for me I had thought I might be able to fix this, turned my back and by the time I come back it was done.

@betatim Thanks for spotting that! The corner-case is not as straightforward as I had thought initially. I have added a detailed explanation. Could you have a look?

Documented. I forgot to copy-paste from the other acquisition function.
Anything else?

Merging this, thanks!


Hosting Http.Sys in production environment

From @rahulsahay19 on October 15, 2017 12:33
Hi Team,
Wanted to understand one thing. Let's say, I have written ASP.NET Core MVC application which is hosted on Http.Sys. Therefore, currently what I do, I navigate to published folder and there run dotnet app.dll. Server gets started and it starts to listen requests. However, this also opened dotnet console window, which is ok if I am doing development on local machine.
But, let's say I would like to take the published folder and deploy on server. Therefore, if I run the same command dotnet app.dll, server will get launched and start listening as well, I believe. But, it will have the same console window remain opened there. Is there any way to start the server as a background process, I mean server should keep running but cmd prompt shouldn't be there.
Thanks,
Rahul
Copied from original issue: aspnet/Mvc#6958

(This isn't really an HttpSysServer issue either, but moved it here anyway because that's what the question is about.)

@rahulsahay19 it's up to you how you want to launch the app. You can run it via a Windows Service, or any other mechanism. There shouldn't be any problem with having an extra command window open. Presumably no one remains logged into the server so having an extra window open there shouldn't be a problem. But, running as a Windows Service is better from a user-isolation perspective and avoiding launching server processes in an interactive session.
cc @glennc in case you have more thoughts on this.

Hmm. Thanks for the reply.


TF Lite Exp Complex64 datatypes supported

TFLite Exp currently supports only Float32.
This PR add support for Complex64 datatypes as well.

Nagging Reviewer @alanchiao: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 15 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @alanchiao: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 29 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @alanchiao: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 47 days with no activity and the awaiting review label has been applied.

Is there a specific model which requires complex support for this kernel? In general, for complex and/or other less frequently used types, we only add kernel support when there is a clear need.

Is there a specific model which requires complex support for this kernel? In general, for complex and/or other less frequently used types, we only add kernel support when there is a clear need.

Let's re-open if there is a model which requires this.


ADS OUT functionality with Stratux into a light plane

Hello
Would you please tell me how I should connect Stratux to my Mode S transponder Funwerk TRT800 on the serial interface in order to get ADS-B Out functionality ?
I did not find any tutorial to do this.
Any help will be much appreciated.
Regards,

Stratux is an ADS-B Receiver (aka "ADS-B In"). It does not do ADS-B Out. You will need either a 1090-ES transponder or a UAT transmitter to add ADS-B Out.

@ssokol - this doesn't appear to be the usual "can I use Stratux for ADS-B Out" question. The OP has an ES-capable transponder (Funkwerk TRT800), but lacks a position source.
@lcoulon - If you had an approved GPS position source, you would connect it to Pin 12 of the TRT800 (Pin 3 of the breakout cable). Input format would be NMEA, 4800 baud.

However, Stratux does not use an approved (e.g. TSO C145/146 or DO229 compliant) position source... those receivers have additional integrity checks and the GPS receivers we use in this project don't meet the position / velocity integrity reporting, failure detection, etc, requirements for use in ADS-B Out.

Hello Keith,
Many thanks for the details it helps.
I want my light aircraft visible on ADS-b systems, even I fly with mode S enabled on the TRT-800 transponder , I've never been able to see my tracks visible on Flightradar24 logs.
However control and towers always are able to receive my flight information such as ID, speed, altitude : all informations related to mode S
So I was thinking to add a GPS source output to my TRT800 transponder.
Does someone know if projects based from Raspberry and USB Glonass GPS exist and would do the job or I have to use a specific GPS output frame only issued from avionics GPS such as Garmin or other expensive kinds ?
Would you please tell me more about the purposes of optional USB GPS and AHARS daughter card used with Stratux ?
Regard,
	_____________________________

From: Keith Tschohl<EMAIL_ADDRESS>Sent: jeudi, décembre 15, 2016 3:47 PM
Subject: Re: [cyoung/stratux] ADS OUT functionality with Stratux into a light plane (#547)
To: cyoung/stratux<EMAIL_ADDRESS>Cc: lcoulon<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>@ssokol - this doesn't appear to be the usual "can I use Stratux for ADS-B Out" question. The OP has an ES-capable transponder (Funkwerk TRT800), but lacks a position source.
@lcoulon - If you had an approved GPS position source, you would connect it to Pin 12 of the TRT800 (Pin 3 of the breakout cable). Input format would be NMEA, 4800 baud.
However, Stratux does not use an approved (e.g. TSO C145/146 or DO229 compliant) position source... those receivers have additional integrity checks and the GPS receivers we use in this project don't meet the position / velocity integrity reporting, failure detection, etc, requirements for use in ADS-B Out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@lcoulon - thanks for asking. This is interesting.
@AvSquirrel - which integrity checks are you seeing? I just see that it wants an RMC statement over RS-232 at 4800 baud.
http://fasvig.org/funke-support-for-uncertified-gps-ads-b-out
http://forum.pilotaware.com/index.php?topic=285.0 (scsirob's comments are particularly interesting).
@lcoulon - I assume you've done your research into the regulations aspect for wherever you are located. It seems like this transponder is used mostly outside of the US so I don't really know what applies to where you are. GPS NMEA output isn't something that stratux does currently but it could easily do so. Would you mind giving some background on why anyone else might want to do this so we can assess the value of adding it to the code?

Hello
Adding ADS Out to Stratux will help lot of light plane pilots to get a fully working ADS-B system if they have Mode S transponder onboard.
At the moment most of light crafts are not properly detected by Flightradar 24 or Flightaware.
This probably because their flight levels do not permit to be seen by other larger planes very often.
I will really appreciate to test this new feature on my plane and provide you test results and feedback.
Regards,

@cyoung , the NavWorx AD debacle has been on my mind, and I suppose I was begging the question, assuming that @lcoulon wanted to meet the performance requirements of a DO-260B / TSO-C166b compliant system.
Appendix B of AC 20-165B outlines the FAA's guidelines for determining is a position source is suitable for use in an approved ADS-B system, and would assume that the EASA requirements (if an approved position source is required) would be similar. Among other parameters, this AC requires position, horizontal velocity, 95% probability horizontal and vertical accuracy, velocity accuracy, position integrity, and alerting of integrity faults (loss of RAIM, etc.)
If none of this matters, i.e. it's legal in EASA airspace (France?) to transmit ADS-B using an uncertified position source, and @lcoulon isn't trying to meet the equivalent of the FAA 2020 mandate) then I'd say there's no reason not to try. I've read through the PDF and it seems like the TRT800 just needs GPRMC messages at 1 Hz rate.  That should be dead simple to implement, and doesn't even require a Stratux; a receiver like the BR-355-S4 should cost under €35, and provides the required messages. One would have to validate that the voltages are compatible with the TRT800 (and might need a 5V power supply for the GPS). If one had a Stratux with GPS and didn't want to buy a second GPS receiver, all you'd have to do is add a USB-RS232 adapter, and forward the GPRMC messages from the attached GPS to the serial port.
The only drawback to this is that SDA/SIL would be transmitted as "0" if this is a legal installation -- and that means that certified ADS-B In devices probably still won't be able to see you.

That's a good point - @lcoulon you could just hook this up directly:
http://www.usglobalsat.com/images/br355_optional_cable_sets.jpg
Is that something you could try ?
Curious to see how this works.

Hello,
Actually i can't easily order that model as i'm in France.
However i ordered a VK162
It is  NMEA 0183 compliant , but i think a code should be added to Stratux to get it working.
If someone is able to add this functionnality to Stratux, i will be please to test it on my Mode S transponder.

@lcoulon - that's great, could you send me an email and we can coordinate a test<EMAIL_ADDRESS>

Hello
Once i receive my USB GPS VK162, we can do a test.
Do you have a part of code to add into Stratux ?
I also think we also should make some voltage levels translation in
order to get the GPS signal output compatible with transponder ADS-b
input requirements.
Le 20/12/2016 à 05:54, cyoung a écrit :

@lcoulon https://github.com/lcoulon - that's great, could you send
me an email and we can coordinate a test<EMAIL_ADDRESS><EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cyoung/stratux/issues/547#issuecomment-268154741,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFx8JK3OFdc7SbJpZ2lKmzRnFlWntC1Oks5rJ1-HgaJpZM4LN5_P.

Hello,
I received my USB GPS : VK162
Could we do some tried ?
Did someone implemented the GPS coordinates report in the code yet ?

Hello
Could we no proceed some tests ?
I have received my USB GPS !


iOS: long Emoji list in TextField causes visual bug

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.4.5-pre.77, on Mac OS X 10.13.4 17E202, locale de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.3)
[✓] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Android Studio (version 3.1)
[✓] VS Code (version 1.23.1)
[✓] Connected devices (2 available)

• No issues found!

Minimal code to reproduce:
class TestPage extends StatelessWidget {

  final TextEditingController textController = TextEditingController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.yellow,
      body: SafeArea(
        child: new TextField(
          controller: textController,
        ),
      ),
    );
  }
}

Entering lots of emojis will cause this visual bug:

This doesn't appear on Android.

I can't reproduce this on the latest master 1.23.0-19.0.pre.79.

flutter doctor -v
[✓] Flutter (Channel master, 1.23.0-19.0.pre.79, on Mac OS X 10.15.7 19H2 darwin-x64, locale en-GB)
    • Flutter version 1.23.0-19.0.pre.79 at /Users/markus/development/flutter_master
    • Framework revision 438c4ff21c (42 minutes ago), 2020-10-16 01:52:04 -0700
    • Engine revision 1bc025d6cb
    • Dart version 2.11.0 (build 2.11.0-222.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/markus/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6858069/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6858069/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (5 available)
    • Nevercode’s iPhone (mobile)         • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.7
    • iPhone SE (2nd generation) (mobile) • B46F1F22-93B0-40C4-8DA7-1C9816E399F7     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)
    • macOS (desktop)                     • macos                                    • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Web Server (web)                    • web-server                               • web-javascript • Flutter Tools
    • Chrome (web)                        • chrome                                   • web-javascript • Google Chrome 86.0.4240.80

• No issues found!

Let me know if you are still seeing this and I'll reopen.


devise_for block deprecation warning confuses

The deprecation warning in lib/devise/rails/routes.rb that warns that passing a block to devise_for is deprecated doesn't clearly state that a devise_for instruction will still be necessary, alongside a devise_scope block.
I had assumed, wrongly I suppose, that the presence of a devise_scope would remove the need for a devise_for but that doesn't seem to be the case. It took a few hours to work out why the devise controller methods were being reported as missing.
I'm still not sure I've understood how the routing is set up, but I figure if I could make that assumption then others might too. Perhaps the warning should be reworded, or a warning issued if devise_for is never called in config/routes.rb?

You need both devise_for and devise_scope calls. i will change the warning to be more clear about this, thanks.

Cheers, man!

So it should be something like this?
devise_for :admin, :controller => [ :passwords => :admin ], :skip => [ :sessions ]
devise_scope :admin do
  get  'loginx'   => 'devise/sessions#new',     :as => :new_admin_session
  post 'loginx'   => 'devise/sessions#create',  :as => :admin_session
  get  'logoutx'  => 'devise/sessions#destroy', :as => :destroy_admin_session
end

Yes, exactly.

@Altonymous
devise_for :users, :controllers => { :sessions => 'devise/sessions', :passwords => 'devise/passwords' }, :skip => [:sessions, :passwords]
devise_scope :users do
    get '/' => 'devise/sessions#new', :as => :new_user_session
    post '/' => 'sessions#create', :as => :user_session
    delete '/logout' => 'devise/sessions#destroy', :as => :destroy_user_session
    get '/password/forgot', :to => 'devise/passwords#new', :as => :new_password
    get '/password', :to => 'devise/passwords#edit', :as => :edit_password
    put '/password', :to => 'devise/passwords#update'
    post "/password", :to => "devise/passwords#create"
end

Thanks.  I figured it out shortly after I posted.  Fromt he previous post it made it appear that :controllers was taking an array yet a hash.  The syntax was confusing to me.

Thank you! Now it's clear.


Utilize new ImageDescriptor logic to allow for aspect ratio maintaining ResizeImages

See https://github.com/flutter/flutter/issues/59578
See https://github.com/flutter/engine/pull/19537
It is now possible for the framework to reason about the dimensions of the image before decoding. This should be reflected in ResizeImage so that aspect ratio can be maintained when resizing an image, particularly images coming from sources that may not be in the developer's control (e.g. a network image).

@dnfield Does this issue have a priority status? After discovering the debugInvertOversizedImages flag via DevTools, I wanted to use ResizeImage however it isn't maintaining the aspect ratio of images.
I also found that I needed to multiply the size of the widget in logical pixels by MediaQuery.of(context).devicePixelRatio to calculate the cacheWidth and cacheHeight otherwise the image quality suffered, is that a bad idea?

If you specify only width or only height it will maintain aspect ratio, but it's a bit confusing.
I think we can make this api better but it's not at the top of my list right now.

If you specify only width or only height it will maintain aspect ratio, but it's a bit confusing.
I think we can make this api better but it's not at the top of my list right now.

This is frustrating and weird at the same time. Why would it only maintain aspect ratio when only one parameter is specified.

@Mayb3Nots - how would it preserve aspect ratio if you specified both? :)
If you have an API suggestion we can talk some more. I started working on this a couple times and I think to get a really usable API it's going to require a significant revamp of the image API over all.


Add link to GH repo

I propose to simply make a link to this repo out of the "Sketch" on the right top corner.


Recipe conflict in crucible vs paper -> book and paper -> litmus paper

Core Section

[X] I have searched for this issue on this repository
[X] This bug persist and I need help

Environment
Singleplayer/Local | NO LAN
Modpack Version
0.8e
Description
Litmus paper from the Reactive mod may be impossible to get due to recipe conflict.  According to JEI, paper + mind is supposed to get you litmus paper but it gets you book instead.
Procedure
follow JEI recipe to get litmus paper, get book instead
Additional things
n/a

thank to report it! i will fix as soon as possible

uploaded 0.9a that fix it


fix: typescript/remove-public-modifier: keep private/protected

📚 Description
Only remove public modifier, keep
any private/protected modifiers.
🔗 Linked Issue
No issue.
🧪 Test Plan
pnpm test
📄 Documentation to Update
Bug fix, no functional change compared to the documentation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mohab-sameh ok, I will make a PR there instead.
I can't run https://codemod.com/registry/classnames-to-clsx (Request fails with 403 when fetching classnames-to-clsx), where should that kind of stuff be reported?

@pjonsson please report the issue in the commons repo as well. We'll update our issue reporting guidelines soon to clarify what gets reported where.


Rename master branch to main

I suggest to rename our current master branch to the new GitHub standard name main.
More details on why and what has to be done here: https://github.com/alan-turing-institute/the-turing-way/issues/1210

@mloning In which files we need to rename it can you please mention?

Hi @96RadhikaJadhav - take a look at the linked issue from The Turing Way, they provide all the details. In terms of in file references to master, I'd do a search over the entire repository to find out where we refer "master". Does that help?

@mloning Can I do it ? Can I Make a PR after necessary changes ??

Hi @ayan-biswas0412, let's check: @96RadhikaJadhav are you still working on this? If not, @ayan-biswas0412 can do it!

@mloning I have a question just for my knowledge enhancement , what I have to do with the script which is given in your mentioned link, that python script https://gist.github.com/sgibson91/44a1c3a6bbf34257dbdbb621a98dab0d , Can you please solve my doubt

@mloning  For now, I'm bit busy with other issues. It may take some time for me to grab this one. Meanwhile, @ayan-biswas0412  you can work on it if you want.
Thank You.

@mloning For now, I'm bit busy with other issues. It may take some time for me to grab this one. Meanwhile, @ayan-biswas0412 you can work on it if you want.
Thank You.

great I can do it but @mloning for changing the base branch I think I have to get the repository access as contributor

@ayan-biswas0412, I think we can simply use the "rename" option that is also mentioned in the link - the readme asserts that this will also rename all references incl PR targets.
https://github.com/github/renaming#renaming-existing-branches
@mloning, that´s a one-click-thing in the admin config, can you confirm that it looks to you as well that we don´t need any help for this (since it´s a one-button-action)?

... anything about the CI set-up that will break, maybe?

@ayan-biswas0412, I think we can simply use the "rename" option that is also mentioned in the link - the readme asserts that this will also rename all references incl PR targets.
https://github.com/github/renaming#renaming-existing-branches
@mloning, that´s a one-click-thing in the admin config, can you confirm that it looks to you as well that we don´t need any help for this (since it´s a one-button-action)?
(I´m not doing anything since I might be missing something obvious here)

I also feel same like you that it is a one click action in the admin config

As Sarah summarised in the linked issue: Things that the new feature won't do:

[ ] Rewrite our CI files to the correct branch
[ ] Update any docs

So as suggested above, I'd do a search over the entire repository to find out where we refer "master" and replace that with "main".
I'm happy to make the changes in the repo settings that require admin access.

As Sarah summarised in the linked issue: Things that the new feature won't do:

[ ]  Rewrite our CI files to the correct branch
[ ]  Update any docs

So as suggested above, I'd do a search over the entire repository to find out where we refer "master" and replace that with "main".
I'm happy to make the changes in the repo settings that require admin access.

I can do the changes in the entire repo and change the master to main , please can I do that ? I will be highly obliged

@ayan-biswas0412 Sure, I'd start with the docs (including docs like CONTIRBUTING.md) and open a PR to see if everything passes. Changing the CI files will likely break the CI on the PR, so let's start with the docs.

@mloning can you review by PR #667

From: https://docs.github.com/en/github/administering-a-repository/renaming-a-branch
After you rename a branch in a repository on GitHub, any collaborator with a local clone of the repository will need to update the clone. From the local clone of the repository on a computer, run the following commands to update the name of the default branch:
git branch -m master main
git fetch origin
git branch -u origin/main main

@mloning do I need to do anything more in my PR ? or it is fine now

PR looks good, thanks again @ayan-biswas0412, we just need to find a good time to make the change.

FYI we needed to update readthedocs and codecov settings too.


feat: supports customized metrics flush period

envoy-gateway uses otel/metrics as the infrastructure. By default, the export time of metrics is 60s:

ref: By default, the returned Reader will collect and export data every 60 seconds, and will cancel any attempts that exceed 30 seconds, collect and export combined.

Just imagine:

When envoy-gateway is in a more important department to coordinate gateway resources, we may need to shorten the time for exporting metrics appropriately, which can allow us to improve the real-time performance of obtaining metrics.
There is also a possibility that envoy-gateway is in a relatively marginal department and does not have high real-time requirements for metrics, so its cycle can be set slightly longer.

I think this looks like a nice feature and I will implement it if the idea is accepted.

cc @Xunzhuo

I am Okay with this, please go ahead @ShyunnY thanks!

/assign


[release-1.4] Tracing tests for Kafka Broker

Backport of https://github.com/knative-sandbox/eventing-kafka-broker/pull/2369

Proposed Changes

Backport the commit from main
Update dependencies on knative.dev/eventing and knative.dev/eventing-kafka

Release Note

Docs

/retest-required

/retest-required

/retest-required

The failure doesn't seem to be related to this PR
/retest-required

/retest-required

/close


ws.autoFilter not working

The docs mention the autoFilter option on a worksheet object. I attempted to enable it, but my worksheets still don't open with autoFilter enabled.
ws.autoFilter = false  as well as ws.autoFilter = true do nothing.
Does anyone know of a solution?

https://github.com/sheetjs/js-xlsx#worksheet-object
The autoFilter in the docs refer to the sheet protection: "functionality disabled if value is true".  The protection isn't really relevant if the worksheet doesn't have a filter in the first place, but we tried to address all of the relevant protection information in one fell swoop.
We aren't reading or writing the auto filter information, but that's something we're looking into.  Stay tuned.

ahh, okay. Thank you for the quick feedback!

@jcarvin if you are feeling adventurous and want to contribute, it's not hard to add it in!
In the write_ws_xml function, the actual XML corresponding to auto filters should appear after the sheet protection and before the merge cells, so it would be in this location
So if you wanted to hard code something, the simplest change would be something like:
if(ws['!autoFilterXML']) o[o.length] = ws['!autoFilterXML'];

and you could set the worksheet !autoFilterXML property to the raw XML.  We have a test file if you want to see how the XML works (unzip and look at the various xl/worksheets/sheet#.xml files)
That's obviously not desirable long-term, we'd want some sort of JS representation instead of passing raw XML, but we'd need to play around a bit before settling on something.

Oh, wow okay! That's incredibly helpful. I'll do some tinkering with it tomorrow. Thanks again!

I ended up hard coding the autoFilters in as you suggested. Worked like a charm. I am, however, wondering if there is a way to make a similar change that will freeze the top row. Looking into that now. If you have any suggestions, I would be grateful.

The freeze options are set in the pane tag within the sheet views.  In the XML it will appear right after the dimension tag, so https://github.com/SheetJS/js-xlsx/blob/master/bits/67_wsxml.js#L356 is probably the right place.  I think something like this should take a parameter !freezerow in the worksheet: (warning: untested)
var freezerow = ws["!freezerow"] || 0;
if(freezerow > 0) {
  var freezeref = "A" + encode_row(freezerow + 1);
  o[o.length] = '<sheetViews><sheetView tabSelected="1" workbookViewId="0"><pane ySplit="1" topLeftCell="' + freezeref + '" activePane="bottomLeft" state="frozen"/></sheetView></sheetViews>'
}

It might be necessary to add a selection within the sheetview <selection pane="bottomLeft" activeCell="A1" sqref="A1"/> but I haven't experimented yet.

Thank you so much.... I'll take some shots at that, asap.

In general, to figure out what's going on, you should:

generate a file with the feature you want, save it, and inspect the XML to see what needs to be added.  What I like to do is create a sample file without the feature, save it to one file, then add the feature and save to a second file.  That way, comparing the XML lets me see what changed.

search for the relevant tag in the spec -- you'll see a bunch of references in the read portion of the  code which should help guide your search

In this case:

<IP_ADDRESS> is the worksheet tag
<IP_ADDRESS> is the sheetViews tag
<IP_ADDRESS> is the sheetView tag
<IP_ADDRESS> is the actual pane tag

figure out what options are supported.  The table in <IP_ADDRESS> (page 1656 of the part 1 pdf) shows you the options.  At the end of that part, you'll see a reference to the type CT_Pane in the schema, which does a decent job of telling you what must be included and what fields are optional.

generate the xml.  For simple features you can literally write the code, but for something more complex you might want to use some of the helper functions.  writextag takes a tag name, a body, and an attributes object and generates the corresponding xml entry.

figure out where to put the tag.  Even though it is XML, putting the data in the wrong place may result in unreadable files.  For small stuff, you can just look at your sample file and guess where to put the data, but to be complete you should dig into the schema for the parent tag (in this case CT_Worksheet, page 3900).

If you do add something, feel free to send a PR with changes.  The hardest part of the process is settling on a JS representation that makes sense -- if it's too close to the underlying XLSX format, it won't be easy to use in your app

We aren't reading or writing the auto filter information

@SheetJSDev, I wanted to followup on this and clarify what you mean here.
We're looking to parse an Excel file that was saved with filters but do not see any representation of the filters in the resulting sheet object.
Is this expected? Are there any updated plans to support this? Does this open issue account for parsing or just writing? How does this relate to https://github.com/Folcon/js-xlsx/commit/bb536a0d79644718f79f205eca3c025be3d6fa0e?

0.18.9 completely settles auto filter issues.
https://docs.sheetjs.com/docs/csf/sheet#worksheet-object ws["!autofilter"] will be assigned when parsing and will be serialized.  It will also rewrite the relevant defined names for Excel formats.


(MODULES-4194) update CRL lastUpdate and nextUpdate fields

/cc @nfagerlund this will need docs updates; when the CA cert is rotated the CRL should be updated as well to make sure that it doesn't expire. I'm still working on how to distribute this file.

OK! Holler again once we have a process for doing that.

/cc @binford2k @camlow325 could I get your eyes on this PR?

I've got a more existential question. Is there a reason you'd ever want to update the CA and NOT update the CRL? Or update the CRL without updating the CA?

@nfagerlund fair point. I might wrap up both actions in a puppet certregen refresh command. Thoughts?

👍

I'm good with the code on this from a first pass.  I'll do a little manual functional testing of it and comment back here if I find anything from that.

Changed manage_crl to default to true, and I've added a spec for confirming the crl number was incremented.

@adrienthebo So, one misunderstanding we've been running into within the company is that people think this module is meant to regenerate ALL certificates in your deployment, cf. the massive PE documents on how to do that. I still don't quite know if that's one of our ambitions for it?
Putting the CA-specific rotation stuff in a generically-named "refresh" action seems likely to expand that confusion. If the name of the command was "ca_rotate" or something, I'd support that, but given the existing name, I think the action name needs to have something to do with "ca".

@nfagerlund I do like the idea of exposing the separate "regenerate CA cert" and "update CRL expiry" as separate commands, but that being said we could keep puppet certregen ca as the command to invoke and rename the "regenerate CA cert" command. Does that work for you?

@adrienthebo Yeah, I think that's sensible.

Pull request updated with a cacert action to only update the CA cert, and the ca action has been changed to invoke the cacert and crl actions.

And if puppet certregen ca is too confusing we can change it, @nfagerlund would you like to change that to rotate_ca or somesuch?
/cc @jdwelch opinions on the above?

Switched to use the multi-arg form of file() in client.pp to determine which CA/CRL file source to use, so we no longer check $settings::ca.

Changes are sensible to me.

@adrienthebo I think "ca" is a nice serviceable name for the combined action. 👍

@camlow325 I think we're good on the docs and ux front; are there any other changes you'd like to see on this PR before we merge it?


PrometheusRule admission webhooks

Add admission webhooks to prometheus operator that prevent invalid rules from making it into the cluster and potentially breaking a prometheus.
There are two webhooks

validating prevents pushing a badly formatted rule and provides feedback about each failing rule like promtool does.
mutating adds an annotation to each rule indicating it was validated

Adding validation logic to the mutating webhook doesn't allow to provide the same kind of nicely formatted information to the user, so using two separate hooks. Since the mutating hook always runs first, and incorrect configuration could theoretically result in a rule annotated as validated to not actually be validated but I think that's rather unlikely.
More testing has shown that a single pod should really be enough to deal with validation but willing to add more functionality to run the webhooks externally

fixes: #2273

Looking for guidance on how to proceed with this - I don't have a lot of experience in go, so any and all feedback is welcome

This is really really awesome! I have a massive backlog of things to read/review. I haven't forgotten about this, it's really really awesome, thank you for working on this!

No worries! Thanks again for this work, it's really awesome!

Looking at  kube-rbac-proxy, I didn't see an option to disable client-auth, so I went with square/ghostunnel that should be providing the same thing.
Do let me know if I'm off the mark here and I'll try to correct it

Generally this looks really awesome, and I'm inclined to merge it as is. I'm just wondering what the intention for the mutating webhook adding the annotation is. Is it to identify rules that were created before the webhook was put in place?

(this will also need a rebase and go mod tidy, but otherwise lgtm)

Generally this looks really awesome, and I'm inclined to merge it as is. I'm just wondering what the intention for the mutating webhook adding the annotation is. Is it to identify rules that were created before the webhook was put in place?

Yes, I think you suggested doing something like this here: https://github.com/coreos/prometheus-operator/issues/2273#issuecomment-469602658

Ok, makes sense, just wanted to confirm. lgtm after rebase and go mod tidying

I think this is correctly rebased and ready for a final check.

This is really awesome! Thanks a ton!

Thanks for taking the time to review it

Sorry for taking so long, it's been a busy couple of weeks and then holidays and vacation. But so happy this is finally a reality! :tada:

These are validation webhooks for Kubernetes.

Is there a reason this is not part of the mixin? I want to have the webhook as part of the operator deployment. Do I need to do something besides the webhook configuration?


Convention for naming types

Preface: I confess I am quite a fan of naming conventions, and in the company I work I try to get people to adhere to the naming conventions we decided together quite strictly. I am aware that in an open-source project like Monero it's more complicated and more difficult to agree on something, or at least to not disagree too much, and most of the time renames of even very bad names are out of question anyway because sometimes this results in changes over the whole codebase, almost impossible to review.
Still, if I see something that I deem important regarding naming, and relevant for our project of writing a Seraphis wallet, I will open an issue for it. Thanks for your patience :)

The Monero codebase pretty consistently uses snake case as naming convention for mostly everything. That's those all-lowercase names with underscores to separate words like e.g. update_blockchain_height or wallet_internal_error. That's no surprise, I think it's pretty universal that C++ code uses that; also the STL and Boost use it, for example (std::range_error, boost::unordered_map).
For types including structures and classes however there is another naming convention that many people use, CamelCase.
And that's the reason to write this issue: The Seraphis library currently does use CamelCase in this way. Examples: struct SpEnote, struct SpOutputProposal, class MockLedgerContext, class EnoteScanningContextLedger. (Everything else uses snake case.)
The question I would like to submit to discussion with this issue: In the Seraphis wallet, do we continue the style of the library and use CamelCase for type names, or do we go with the bulk of the code in the Monero codebase and use snake case also for type names?

My current personal opinion: I would be ok with both styles. I lean a bit towards snake case however, I doubt a bit that the advantages of CamelCase names for types merit the exception that they bring, but readily accept that other people see that differently.
My red line however would be that not even the few people working on the Seraphis wallet would use the same naming style for types.

I prefer camel case for types in order to disambiguate from methods and simple types (I consider all the jamtis types in jamtis_support_types.h as simple types - i.e. single data field types with only basic member functions).

Monero wallet seems to use mostly the snake case.  I would stay with that as we are going to have enough changes already.

Discussed and decided in the second meeting, camel case is it.