potential infinite loop

Hey,
you have a potential infinite loop in here https://github.com/ars3n11/MineSweeper/blob/main/MineSweeperCore.c#L414
if memcmpCustom return 0 (e.g. when the first bytes of array s1 and array s2 are not equal, you will end up looping endlessly.
In order to fix that, you could add a check that if memcmpResult == 0, increment it by one.

Awesome! Thanks for pointing that out! I'll fix tonight.

Fixed! Thanks @babama-dev for catching this one! 🙌 🙌 🙌


Blog - Role v Persona, its a granularity thing!

Overview of the differences between Role and Persona based access - Pro's and Con's and why Egeria is Persona based

should this move to 1.3 timeframe?


Fix transit stuff

Players stay in transit until another shards sends a message indicating that the player arrived or after a 30 second time out.

Oh and portals have a 10 second cooldown now

Ok so the only thing that seems to be missing is blocking saves while intransit.
Also, will the target server know the player is intransit? Ideally we'd want to cancel events and saves on the target server until the player is fully arrived.

Right now the target server doesn't know the difference between a normal player login and a player arriving because of Bungee. We could do something with Mercury, but it's hard to guarantee anything.

Do you mean that we should add an inTransit equivalent for arrival that prevents anything until player data is guaranteed to be loaded?

That's fine, mostly I'm just after what I described in the channel:
while intransfer prevent save, 'cept for the save which is triggered by the transfer event
similarly on join, prevent save until player is fully joined and the message releasing intransfer is sent.

Ok, I'll refrain from making the main plugin class worse and split that and the original in transit thing out in a separate class

basically Intransit should tell the target server to expect the person; then they can be intransit on both sides.
This doesn't conflict with normal first-joins as the player will simply join as normal, with no interference from intransit b/c they won't be on that list.

Can we guarantee that the Mercury message arrive before the player arrives via Bungee?

not yet but it doesn't matter; if the message arrives late we'll just be "unprotected" but it shouldn't interfere with normal login as the arriving server will assume they are a user logging straight in to them instead of a transfer. The bit we're discussing is just extra protection.
In terms of order of operations however, the intransit alert should be sent prior to anything else in the transfer sequence; rabbit delivers pretty darn fast so there's a very good chance it will happen first.

No, that was missing. I added it.

So when should I be removing players from arrivalTransit and send a message to the origin shard to clean up it's exitTransit as well?
Right now it's in the join listener, should it be at the end of the asyncprelogin listener?
Aside from that is there anything else that should go here before it's merged?

Ok fixed those. Thoughts on what I asked above?

So I think we should remove them from origin server's exit transit when on the target server the player has finished join (Join MONITOR would be a fine place for it). There's no issue "keeping" the player in the exit queue, only reason to not just let them time out is in case the player wants to go back shortly after 10 sec timeout.
In fact you could just spawn an event to run 1-2s after join, maybe that would be best.


Provide a mechanism for extension authors of a FileSystemProvider to hint language for files

I'm working on a filesystem provider and I'm annoyed that all my files show up as plaintext if I use the vscode.open command.  I suspect this is because they don't have extensions. More specifically, I have JSON data that I'm rendering as strings for the user to edit (which I later reparse into JSON and extract changes from).
I'd like a mechanism whereby I can tell VSCode in my FileSystemProvider what the languageId of that file is. Thinking about how to accomplish this without changing the current APIs too much, perhaps there could be a readFileLanguage() call that the languages services could check for when they try to decide which language to render the file as?

We have setTextDocumentLanguage for this: https://github.com/Microsoft/vscode/blob/f5b5630d900932c1e2992f01e98d225a4b189c6e/src/vs/vscode.d.ts#L7507-L7519
We have to have things decoupled and I'd prefer to keep those things separate. I think using the function above is the easiest, otherwise you can try the declarative languages-section in package.json. It allows to bind to existing languages (like JSON) using filename patterns (like foo1, foo2, if that applies) or the first line content of the file

Yeah, I understand the desire to keep those separate but I can't see how I can ensure that every "vscode.open" call will get my language preferences applied. This means, for example, that if you ctrl-click a link to open a document referred to in another document it doesn't get source highlighting because there's no way (I have thought of, at least) for me to "hook" the document open call and run setTextDocumentLanguage.
Right now my work-around is that I have a custom treeview where clicks trigger a special "myextension.open", but there are quite a few ways of opening a document that don't follow that path and so don't have the right highlighting.

Why are you using vscode.open to begin with? There is openTextDocument and showTextDocument which are the better choice. Anyways, use the onDidOpenTextDocument-event and check if it's one for your document that hasn't the right language yet, then change it

I'm not using vscode.open -- it seems the system uses that when I reopen the editor or Ctrl-Click a link to a document, but that hook is exactly what I overlooked. Thanks for the idea, it works great!


Bottom lines slowly disappear while working on documents

I'm reposting this issue since the last one https://github.com/vscode-neovim/vscode-neovim/issues/1235 was closed (in my opinion) prematurely.
Previous text:
I have had issues for quite a while now where, as I work on a document, it seems to chip away at code in the bottom.
I'm the kind of person who basically spams :w it may have to do with that, but I really don't know.
It could not have been any extension that I am aware of because,
I have tried to be turned off anything that may change the contents of a file, but I keep finding code missing.
New info:
Could it have something to do with copy and pasting snippets and operations like that?
My findings show it's related to things like code completions and pasting code. I have a few gives and videos with more info.

https://github.com/vscode-neovim/vscode-neovim/assets/66908776/d76bbad2-c5c8-4383-9a60-c4fb0844c1ad

Please reproduce with an empty init.vim file.

Please reproduce with an empty init.vim file.

I have never changed my init.vim or init.lua

Latest nvim version?

Latest nvim version?

It's v0.9.0

Let me know if you isolate it to vscode-neovim, and can reproduce with empty init.vim.

Let me know if you isolate it to vscode-neovim, and can reproduce with empty init.vim.

I have decided to switch over to doom emacs. The .init's were always empty for me.


Fix extract data from local file uri

Thank you for this awesome app, it does a great job :rocket:
Currently I had a problem loading local assets like images and a css filed into the template,
it seemed like data extraction was not possible.
But removing the path truncation seemed to fix the issue, so that extracting data from assets worked correctly.
This is my first contribution so I would be very glad for your feedback.
Closes: #602

Sorry, a fix will include in v0.2.7 release but not merge directly.
Thanks for your contribution


[Q] Can the wall-time curves be exported as a csv file?

Hi,
wandb offers an option where one can plot a y-value of interest against the relative wall time of the run. When trying to download the csv data for such a run, it looks like the data only consists of one line and does not include y-values against the wall-time x values. Do you know if there is some way to access this information?

Hi @a1k12 thank you for writing in! Would it possible that you attach a screenshot of the plot you want to export as .csv file? The relative time (wall) may be a scalar value per Run. Therefore, in this line you should be able to see the value for each run (in each column). Did you also try to export the data using the "Export API" option?

Hi, here's an example screenshot of the plot I'd like to export as a .csv file: https://imgur.com/a/glXRuHU It looks like the .csv file takes a different format than plotting y-values vs. batches on the x-axis.

Hi @a1k12 thanks so much for reporting this! Indeed it seems that for the relative time (wall) the csv export is broken. I will report this to our engineering team and I will let you know once this bug is fixed. In the meantime, did you try exporting the metrics using the API? You can easily do as follows:
import wandb
api = wandb.Api()

# run is specified by <entity>/<project>/<run id>
run = api.run("entity/project/run-id")

# save the metrics for the run to a csv file
metrics_dataframe = run.history()
metrics_dataframe.to_csv("metrics.csv")

Please let me know if this would work for you, or if you have any further questions.

We are closing this issue due to inactivity. If you feel this bug merits additional review, please provide a reproduction and add a comment explaining why. Thank you.


Hyperlink DOI to preferred resolver

Same as https://github.com/common-workflow-language/common-workflow-language/pull/827 ;-)

Thanks!

You're welcome :-)


fix: dreadmist set bonus should grant health instead of mana

Probably just a typo, proc tooltip and effect are both heal

https://github.com/wowsims/sod/issues/798


Reactivate the monthly statistics page

Context
This PR adds the new monthly statistics in a way that we can disable the redirect feature flag and show the report on Monday but we can also preview the November one that is not published yet. (In the end I realised that we don't need the feature flag for preview as the month url works from support).
Technical choices
It took me while to understand the whole so I decided to simplifying as much as possible so I split controllers, presentersand services for version 1 of the report and version 2 using the same routes.
I decided for the first time in the project to create filters objects as they are easy to manage in its own folder.
Now we have Publications::MonthlyStatistics::V1 and Publications::MonthlyStatistics::V2 namespaces to use if needed.
Changes proposed in this pull request
I added the monthly statistics tab to support (1. Visit /support -> 2. Click on performance -> 3. Click on monthly tab)

Guidance to review

Can you see the report in the support interface?
Does the report works for the url in support?
Does the report works for /monthly-statistics?
Does the report works for /monthly-statistics/2023-11?
Does the report works for /monthly-statistics/2023-10?
Does the report works for /monthly-statistics/ITT2024?
Can you download the CSV on each report?
Is the CSV contain the right numbers?

Link to Trello card
https://trello.com/c/xfHhFuVU/894-monthly-statistics-reactivate-the-monthly-statistics-page

I don't mind if you'd prefer to do this in a follow up PR, but what are your thoughts on removing the monthly_statistics_preview flag if we're not going to take that approach?


Feature/card list styling

Description
This update focuses on fixing the image cover size of landing card to better fit within the border of a card, adding a css reset for the application, & replacing the existing loading component with a loading spinner animation from Ant Design.
Co-Authors:
Jacob Shomali

Loom | Free Screen & Video Recording Software - Watch Video

Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have removed unnecessary comments/console logs from my code
[X] I have made corresponding changes to the documentation if necessary (optional)
[X] My changes generate no new warnings
[X] I have checked my code and corrected any misspellings
[X] No duplicate code left within changed files
[X] Size of pull request kept to a minimum
[X] Pull request description clearly describes changes made & motivations for said changes

I especially like that the CSS reset was imported in the index.js.


Remove auto-updating feature from sfdx

Is your feature request related to a problem? Please describe.
There are occasional issues with sfdx that appear without warning, for example https://github.com/forcedotcom/cli/issues/684. These issues affect users locally as well as CI/CD systems that use sfdx.
What are you trying to do
Not have to worry about the sfdx version self upgrading and spontaneously breaking something.
Describe the solution you'd like
sfdx to no longer update and make it clear which version it's on. Right now it's confusing because there seem to be core specific libraries that have their own versions, not a clear overall sfdx version.
Describe alternatives you've considered
Trying to force lock in a version with reverse engineering the core packages and running specific install commands. Doesn't feel like it's worth it.
Additional context
Auto updating doesn't seem appropriate for a CLI tool. It introduces nondeterministic software behavior, and removes the user's ability to triage bugs by downgrading tool versions.

You can already turn off auto-updates.

If using the installers, set the environment variable: SFDX_DISABLE_AUTOUPDATE=true (doc'ed here)
If using npm, it doesn't auto-update by default. i.e. npm install sfdx-cli --global. You can also hardcode to a specific version: npm install sfdx-cli@49 --global

If you want CLI auto-updates but want to prevent certain commands from updating, you can lock to specific versions. sfdx plugins:install<EMAIL_ADDRESS>


[WFLY-4392] Make use of TCCL in ARQ ManagedContainer configurable

https://issues.jboss.org/browse/WFLY-4392

Is this waiting on something? I'd like to see this in 9.0.0.CR1


Make Capp not dependent on OpenShift

Right now Capp is dependent on OpenShift because of the Route API. We should be able to support Kubernetes natively.
/kind feature

/assign @sahar2339


feat(WebVTT): Remove un-needed VTT payload normalisation

The tXml parser gracefully handles this now, so it is no longer needed.

@dave-nicholas I convert it into a feat so that it is not included until 5.0 is released since it depends on changes in this release.


PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.4
Can you reproduce the issue with our latest release version?
Yes 4.3.5
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Chrome 112.0.5615.137 on Mac OS 13.3.1
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
In this case the manifest file alone is sufficient to reproduce the problem when running the shaka demo app locally.
I copied the manifest into the root shaka-player folder, served that folder with the node http-server and played the stream with
http://<IP_ADDRESS>:8080/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=http://<IP_ADDRESS>:8080/manifest-with-period-flattening-error.mpd;panel=HOME;build=uncompiled
manifest-with-period-flattening-error.mpd.txt
What configuration are you using?  What is the output of player.getConfiguration()?
configuration was not customized at all
What did you do?
Try to play the stream
What did you expect to happen?
Expect manifest parsing and flattening to complete without error.
What actually happened?
With shaka 4.3.4 and more recent I get the error [Shaka Error MANIFEST.PERIOD_FLATTENING_FAILED ()]
This problem does not occur with shaka 3.1.2

We have identified the cause and will submit a PR to fix it.


didn't work

Just tried this and it didn't work

Can you share any specific error that you are facing
@shadiakiki1986

It opened kaggle with an error that said "we can't find this page". Fwiw,
it's a notebook in a private repository. Here's the exact link I used.
https://github.com/shadiakiki1986/kaggle-birdclef-2024/blob/main/2-nb/240426-1 - distill-g-bvc - move to gcp vertex.ipynb
On Wed, May 8, 2024, 10:21 Eswar Divi @.***> wrote:

Can you share any specific error that you are facing
@shadiakiki1986 https://github.com/shadiakiki1986
—
Reply to this email directly, view it on GitHub
https://github.com/EswarDivi/OpeninColab-Kaggle/issues/1#issuecomment-2100702244,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAA5BBT2EURNMQFW7PUCATZBIYIBAVCNFSM6AAAAABHNAOCYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQG4YDEMRUGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

This app only works with public repos.


Mercury messages aren't tokenized properly

Currently NL uses a space to tokenize fields of Mercury messages. Group names or status messages could contain spaces. This will need to change when we standardize on a solid token for all plugins.

Dependent on how Bukkit/Spigot tokenizes user-entered commands, group names should not be able to have spaces. https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/command/commands/CreateGroup.java
Finally, none of the existing NL-based Mercury messages include status messages: https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/listeners/MercuryMessageListener.java
That said though, totes agree.

I assume we are using Unicode strings right? Or are we ASSCI?
On Mar 18, 2016 5:33 PM, "Daniel Boston"<EMAIL_ADDRESS>wrote:

Dependent on how Bukkit/Spigot tokenizes user-entered commands, group
names should not be able to have spaces.
https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/command/commands/CreateGroup.java
Finally, none of the existing NL-based Mercury messages include status
messages:
https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/listeners/MercuryMessageListener.java
That said though, totes agree.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/155#issuecomment-198552458

Mercury transfers UTF-8.
On Sat, Mar 19, 2016 at 6:06 AM, ttk2<EMAIL_ADDRESS>wrote:

I assume we are using Unicode strings right? Or are we ASSCI?
On Mar 18, 2016 5:33 PM, "Daniel Boston"<EMAIL_ADDRESS>wrote:

Dependent on how Bukkit/Spigot tokenizes user-entered commands, group
names should not be able to have spaces.

https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/command/commands/CreateGroup.java

Finally, none of the existing NL-based Mercury messages include status
messages:

https://github.com/Civcraft/NameLayer/blob/master/NameLayerMain/src/vg/civcraft/mc/namelayer/listeners/MercuryMessageListener.java

That said though, totes agree.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
<https://github.com/Civcraft/NameLayer/issues/155#issuecomment-198552458

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/155#issuecomment-198699800

then we can use some super obscure deliminator character, actually considering unicode seems to have everything including the kitchen sink symbol can't we get a deliminator character?

The idea months ago was to move to serialized objects so plugins have no
need to perform the serialization/deserialization.
On Tue, Mar 22, 2016 at 9:58 AM, ttk2<EMAIL_ADDRESS>wrote:

then we can use some super obscure deliminator character, actually
considering unicode seems to have everything including the kitchen sink
symbol can't we get a deliminator character?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/155#issuecomment-199905583

Resolved by https://github.com/Civcraft/NameLayer/pull/220
Groups can no longer have pipes, by which we tokenize the messages.


Set value of a property at client side.

I have a dialog that has a submit button just like save but I want to set its Status field to ApplicationStatus.Submitted. For doing this I have added a button and its click event I have set the status field then call save method. but unfortunately Status does not saved.
[Note that in my Form.cs there is no such status field.]
            buttons.push({
                title: 'Submit',
                cssClass: 'add-button',
                onClick: (e) => {
                    this.entity.Status = ApplicationStatus.Submitted;
                    this.save(s => { Q.notifySuccess('Application has been submitted successfully.'); });
                }
            });

Entity is the loaded one, not the one going to be saved. Override getSaveEntity

Ok. but I have different buttons for saving a single entity different ways. such as draft, submit etc.

Hope you know how to define a private variable and set in on click


Escaped '<' and '>' characters during the creation of documentation

Fixed #1067

/cc @bcardiff

@bcardiff so, I fixed < and > characters in documentation building. But I can't find tests for this :(

Thanks!
And yup, there are no test for this :-$ as @asterite said  https://github.com/manastech/crystal/issues/1067#issuecomment-126720663 .
I'm not sure if the highlight is not broken due to the escaping. Because you are escaping all the < > and not just the one in the comments, am I right? I haven't went into the internals of those classes.

@bcardiff yes, you are right, it's broken code :sweat:

@bcardiff I can to suggest use this regular expressions for parsing html tags:
value = "crystal is awesome  test"
value
  .gsub(/<((\w+)(\s.+)?)>(.*)<\/\2>/) { |s, m| "<#{m[1]}>#{m[4]}</#{m[2]}>" }
  .gsub(/<((\w+)(\s.+)?)>/) { |s, m| "<#{m[1]}>" }

What do you think?
I don't like this solution ( it's terrible for me ) but I can't think something else :sweat:

Maybe what we just need is to escape the rendered code here in the highlighter or only for the comment token type using the gsubs in this PR.


Storage "path"

Registry v1 allowed to store all content under a "subpath" on the given storage system.
We should support that as well.

documentation

cc @stevvooe

Thanks Andrey. Just for tracking purpose right now - I would like to test it (or better, have tests for it :-))

After some thought, the right way forward is to remove the (pathMapper).root. This creates a secondary path, added to the rootdirectory configuration for storage drivers. Ideally, we'd just get rid of it, but not all storage drivers had the forethought to provide a rootdirectory parameter. This extra root path is just a waste of bytes, so we should do something about.
It also has the nice effect that we don't need to maintain the pathMapper object at all. This will allow us to remove the type switch used to resolve the paths and just implement the path values on the pathSpec structs themselves. This will provide a much nicer interface for a package we can actually export.
That said, to get this done, we need to do the following:

Add rootdirectory configurations to the azure and swift storage drivers. This value just needs to be added to incoming paths for the backend.
Remove (pathMapper).root and replace (pathMapper).path with just a function. This gets rid of the defaultPathMapper silly-ness. Extra bonus points for refactoring the path function to just be implemented on each pathSpec type.
Provide solid documentation and messaging that upgrade from 2.0 to 2.1 (or whatever version we do this in) requires appending "/docker/registry" to any existing rootdirectory configuration.

This is less work that it sounds. We get the following benefits:

Simplifies several path operations in the storage package. pathMapper is nice but can be a little unwieldy.
Uses less characters per path. This means more room for longer image names.
With the extra refactoring in 2 above, we actually have a nice path implementation that can be exported as a package for writing registry tools. With a little documentation and evangelism, we can encourage people to write the tools they need directly against the backend.


Datagrid filter tooltip has low contrast for accessibility

Describe the bug
The datagrid component can have a filter tooltip with a text field. The bottom border color for this text field has very low contrast compared to the background color. Currently the color contrast ratio is 2 to 1. Web Content Accessibility Guidelines states that the minimum contrast ratio should be 3 to 1.
How to reproduce
Here is the link to the stackblitz that reproduces this: https://stackblitz.com/edit/clarity-light-theme-clr12-cds5-qv99at?file=src/app/app.component.html
Also, here is the screenshot of the stackblitz:

Steps to reproduce the behavior:

Go to the stackblitz link
Click the filter button on the datagrid column
Type anything in the text field
Click outside the text field but inside the tooltip
Notice the bottom border is hard to see for accessibility users

Expected behavior
The color contrast should be a minimum of 3 to 1 between the bottom border and the background color for the text field in the filter tooltip.
Versions
Clarity project:

[ ] Clarity Core
[x] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[x] v5.x

Framework:

[x] Angular
[ ] React
[ ] Vue
[ ] Other:

Framework version:
Angular 12
Device:

Type: MacBook
OS: MacOS
Browser: chrome
Version: 95

Additional notes
This issue may be present in other text fields in clarity.

@Jinnie are we tracking this somewhere?
I know that we made some changes on the border-color for inputs a long time ago.

The work @Shijir is doing will help address this since it will use the Core colors in Clarity Angular 13.

This is a simple input element, with the color contrast of any other input element in the framework.
I don't know of any outstanding a11y bugs related to the contrast of the input field border.
I also remember contrast ratios for borders were different than these for texts.
CC @scroniser

@Jinnie - There wasn't an internal issue, but I've created one based off of this issue. As far as I can tell, the issue still exists.

Should be resolved by #6517

Closing in favor of the internally tracked issue and the Core shim. Please see the PR linked above for more details on the shim.


Do you have the code for this example?

Do you have the code for this example? I could not play it in my app
https://github.com/HendraAnggrian/reveallayout/blob/master/art/demo2.gif

@lucasrafagnin sorry for late reply. Yes, the example folder is a module that holds source code of that demo gif.

@hendraanggrian  goodjob brah ,  keep it up (y)


ensure narinfo.Check works on uncompressed NARs

Without this, using Check would result in an error:
panic: cannot handle unexported field at {*hash.Hash}.hash:
        "github.com/nix-community/go-nix/pkg/hash".Hash
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported

While this solution may not be the most efficient, I'm open to suggestions and just wanted to quickly fix this for myself.

Thanks!
We should probably use a custom Comparer, that compares the multihash representation ([]byte). It should be faster than converting to a string representation and comparing that.
Also, as the FileHash and FileSize fields are optional, we might want to flip the logic in the Check function a bit. I think it's too restrictive and might fail on some NARInfo files that don't have the fields set.
Would you be open to updating the PR to reflect that?

I don't think using go-cmp buys us anything other than adding a dependency. So I used a simple bytes.Equal instead.
Also to make the error message nicer, I added the Hash.HashTypeString function and simplified the code setting the hashtypeToNixHashString a little bit.

Not sure why the fixture test fails... I tried running ./build-fixtures.go and it didn't produce any diff for me.

Only got to dig into this now - it seems the output produced by Nix changed (now keys are sorted alphabetically, not arbitrarly).
PR is up at https://github.com/nix-community/go-nix/pull/100, once that's in we should be able to rebase this and not get CI failures.

Erf, I tried to rebase, but did forget to include your commit before pushing, and GH closed the PR, not allowing me to reopen :-/
I cherry-picked it to https://github.com/nix-community/go-nix/pull/101


Ring substituents for some ligands in different orientations, even though same substituent

I noticed that for some ligands (in the SHP2 and CDK8 sets), ring substituents point into different directions which can potentially lead to sampling problems in the RBFE calculations (if they should point into the same direction and if the ring rotations are not sampled). I understand that the input poses were generated in an automated way and we may not want to refine them by hand afterwards, but I thought I just post my findings here for general awareness:
SHP2:

CDK8:

I agree, these poses should be improved. I know people from https://github.com/choderalab/asapdiscovery have successfully used OpenEye docking capabilities to find the poses of compounds, maybe we could use or adapt their pipeline to refine the poses in our database.


feat: port continuity tactic

We implement the continuity tactic using aesop, this makes it more robust and reduces the code to trivial macros.

bors merge


how do I get NTC colors?

colorNamer(myHex) only ever seems to return a small, predefined set of colors. Is this intentional?

Hey @seiyria. I made some changes to the codebase a while ago and forgot to publish them to npm. I just pushed up version 1.0.0, which provides matches for many color sets. Please give it a try and let me know what you think.


Vertical Navigation: Remove shade variant

Fixes #1573
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Please add a checkProp prop deprecation warning
Please remove unrelated PNGs (deleting the removed story PNG is good though).
If there's a good place to talk about how Storyshots often modifies PNGs in the contributing docs, I'd love to see something there. This a common issue.

@interactivellama Updated the patch!
Warning attached for reference:

@tanhengyeow Thank you for contributing updated checkProps.


Assert statements can only accept string literals

Aim
Trying to write an Option::expect method:
fn expect<N>(self, message: str<N>) -> T {
    assert(self.is_some(), message);
    self._value
}

Expected Behavior
The function to typecheck and execute properly.
Bug
warning: unused variable error_message
   ┌─ std/option.nr:35:28
   │
35 │     pub fn expect<N>(self, error_message: str<N>) -> T {
   │                            ------------- unused variable
   │

error: Assert statements can only accept string literals
   ┌─ std/option.nr:36:9
   │
36 │         assert(self._is_some, error_message);
   │         ------------------------------------
   │

Aborting due to 1 previous error

To Reproduce

Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

@vezenovm this seems related to the runtime error messages we mentioned before


Send commands based on input source name / limited number of input sources?

Hi,
I've implemented this to send the commands to TV (a sequence of remote buttons) based on the channel name. As Homekit allows changing the input source name, this can be used to configure input source one as '67 Viasat History HD' and it will send '6', '7', 'OK' on input source change - just an example :)
`
uint8_t ch_data[10][4] =
{
{0x20, 0x08, 0x47, 0xB8},
{0x20, 0x08, 0x1C, 0xE3},
{0x20, 0x08, 0x1D, 0xE2},
{0x20, 0x08, 0x1E, 0xE1},
{0x20, 0x08, 0x40, 0xBF},
{0x20, 0x08, 0x41, 0xBE},
{0x20, 0x08, 0x42, 0xBD},
{0x20, 0x08, 0x44, 0xBB},
{0x20, 0x08, 0x45, 0xBA},
{0x20, 0x08, 0x46, 0xB9},
};
void device_active_identifier_set(homekit_value_t value)
{
if (device_state.active_identifier != value.uint32_value)
{
char *ch_name = NULL;
    if (value.uint32_value == 1) { sysparam_get_string("ch_name_0", &ch_name); }
    else if (value.uint32_value == 2) { sysparam_get_string("ch_name_1", &ch_name); }
    else if (value.uint32_value == 3) { sysparam_get_string("ch_name_2", &ch_name); }
    else if (value.uint32_value == 4) { sysparam_get_string("ch_name_3", &ch_name); }
    else if (value.uint32_value == 5) { sysparam_get_string("ch_name_4", &ch_name); }

    if (ch_name)
    {
        printf("device_active_identifier_set: channel name: %s\n", ch_name);

        bool sent = false;

        for (uint8_t i = 0; i < strlen(ch_name); i++)
        {
            if (ch_name[i] >= '0' && ch_name[i] <= '9')
            {
                sent = true;

                ir_send(ch_data[ch_name[i] - '0'], 4);

                vTaskDelay(500 / portTICK_PERIOD_MS);

                printf("device_active_identifier_set: sending code for %d\n", (int16_t)(ch_name[i] - '0'));
            }
            else
            {
                break;
            }
        }

        if (sent)
        {
            uint8_t data[] = {0x20, 0x08, 0x15, 0xEA};

            ir_send(data, 4);
        }

        free(ch_name);
    } else {
        printf("device_active_identifier_set: channel not found: %u\n", value.uint32_value);
    }
}

device_state.active_identifier = value.uint32_value;

printf("device_active_identifier_set: %u\n", device_state.active_identifier);

}
`
But I do have an issue. If I define multiple input sources (I've tried with 10), I get them in the Home application and everything works fine, but after I reset the ESP, I get a 'chacha decrypt error' on most of the requests making the device almost unusable. Is there a limit in the package sent by the iPhone?

The return code is -2, seems to be size related.

How much free memory have you got when error happens?


Updates

Improved code snippets, tests and better error handling.

This is ok for now, perform more testing and look out for bugs. Also imbibe optimization


When the user fails to Invite a user correctly, the resulting error page doesn't display the organizations correctly

To reproduce:

Login as an admin
Click on "Users" -> "New User"
Fill out the form but have mismatched passwords
Note the "ORganizations" drop-down now shows numbers instead of names.

I'm pretty sure this just needs to be an @organizations ivar or something similar set in the controller

Hi @armahillo, can I work on this?


Anchor box values

@bubbliiiing  thanks for sharing the code base i have few quereis on the anchor boxes values

should we change the values of the anchor box for small boxes and large boxes ?
If so do we have anchor box value generator based on the classes and its sizes ?
The type of classes in my custom training is lanes, traffic cones and buildings
Thanks in adavance

1、try default anchors first.
2、no


Update aws-java-sdk-dynamodb to 1.12.725

About this PR
📦 Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.725
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #574.


Cannot read property 'channel' of undefined

I use this.$echo.channel() in created(), error Cannot read property 'channel' of undefined. Please help me

Hi @nguyentuan7277
Could you provide the repository to reproduce?


Illegal updateAnalysis prev:{[-1]:Integer} new: {[-1]:Pointer}

Hi Valentin
Here is the log of dJUICE running with enzyme: https://gist.github.com/mmorligh/ff5bc981e82920791c98ebc07cf47ce3
Thanks!
Mathieu

This looks like us not yet handling union type returns (in essence we're marking the return as [-1]:Pointer, when in reality the LLVM type is { {} addrspace(10)*, i8 }
Can you provide the input code?

Hi William, thanks a lot for looking into this! The code is available here: https://github.com/DJ4Earth/dJUICE/ you can go to tests/ and run testad.jl. I am quite new to Julia so I apologize in advance if you see anything stupid...
Many thanks
Mathieu

Is it not possible to remove the remaining union?

It is possible but is there an "easy way" to find out where they are in the code?

The best thing would be if @aviatesk's JET.jl would be able to detect functions that return Union{,Float64}.

Interesting, I will work on integrating such analysis within Enzyme's compilation pass this week.

Hi @aviatesk, any update on this?

https://github.com/EnzymeAD/Enzyme.jl/pull/261

We have several independent issues tracking this. Support union fully will be hard, but we now give much better errors in that case #263


breadwallet freezes on mobile data

Device: Galaxy S6
OS: Android 6.0.1
Causes:

recovering a wallet on mobile data after a fresh installation or
using a on mobile data wallet recovered while using wifi from a fresh installation
Symptoms:
no sync status
cannot use sidebar (app will crash)
Notes:
Swiping left and right at the main page seems fine. The wallet address is displayed along with options to send money. Scanning a QR code causes a crash too. Trying to use the menu to view transactions or settings causes the app to stop responding.

Logcat:
http://pastebin.com/wCqbvWEv

Thanks for the feedback @niayh, and sorry for the late response, this bug has been fixed and the new version will pe pushed to beta today.


Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
a

make sure that in your song chart file that needsVoices or smth like that is set to false

once again LIBRARY ISSUE VIDEOBOT.


Concurrency: Don't rely on future wait context in asyncLet_finish.

If a future task has already completed, then task_future_wait doesn't populate the future context,
but asyncLet_finish was inappropriately relying on it to recover the result buffer pointer to
destroy the value inside. There's room in asyncLet_finish's own context to put this pointer, so
do that instead. Fixes rdar://81481317.

@swift-ci Please test

@swift-ci Please test


xatlas should be using the options configured here

It was using the defaults by mistake in PR #44023

Thanks!

Cherry-picked for 3.2.4.

🎉


Replace Ansible with OpenStack Client for Neutron Keystone Jobs

Replace Ansible with OpenStack Client for Neutron
This commit removes the dependency on Ansible for the creation and management of Keystone Users and Endpoints.
It makes use of the OpenStack Client which is part of the standard requirements for all OpenStack Services.
The OpenStack Client is therefore included every OpenStack Service Container regardless of origin.
It builds on the commits in the following PRs, which should be reviewed prior to this:

https://github.com/att-comdev/openstack-helm/pull/130
https://github.com/att-comdev/openstack-helm/pull/131
https://github.com/att-comdev/openstack-helm/pull/132
https://github.com/att-comdev/openstack-helm/pull/134

The new commit introduced in this review is: https://github.com/att-comdev/openstack-helm/pull/136/commits/12d06b5011153d8fed812fc67ff4d5bd3fff1ea2

This change is

Will be superseded shortly


add NodeRestriction to admission-controllers

ref to https://github.com/kubernetes/kubernetes/pull/45929

This change is

@xilabao Just to confirm, this is for the 1.7 release, correct? If so, I will move this into the release-1.7 branch instead of master. Thx

@chenopis this is for the 1.7 release. thanks.

@erictune Can you take a quick look to verify this and give it a tech lgtm? Thx

LGTM

/lgtm

actually, i am confused on why there are two commits?

@derekwaynecarr The second commit was just updating the branch. I'll squash and merge so it should only show up as 1 commit.


improved modeling of galaxies with broad+narrow line-emission

[WIP]
Algorithmic improvements in order to address #118. Details to follow.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

70 of 98 (71.43%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 51.731%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

py/fastspecfit/fastspecfit.py
0
2
0.0%

py/fastspecfit/emlines.py
68
94
72.34%

Files with Coverage Reduction
New Missed Lines
%

py/fastspecfit/emlines.py
4
50.97%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
2376

Relevant Lines:
4593

💛  - Coveralls

This PR implements some key improvements in the broad-line fitting based on conversations with @stephjuneau, @Ragadeepika-Pucha, @paulmartini, and others. The key developments / insights are:

DELTA_LINECHI2 records the raw (not reduced) delta-chi2 (DELTA_LINERCHI2 is now deprecated), given by the chi2 without broad lines minus the chi2 with broad lines.
DELTA_LINENDOF (new to the data model) records the difference in the number of degrees of freedom between the model choices without and with broad lines, respectively.
Both DELTA_LINECHI2 and DELTA_LINENDOF are measured from pixels around the Balmer and helium lines (rather than over the full spectrum).
The narrow+broad-line model is now chosen if all of the following criteria are met:

DELTA_LINECHI2>DELTA_LINENDOF (i.e., the chi2 improvement is larger than the difference in the number of degrees of freedom between the two models);
SIGMA_BROAD > 250 km/s; and
SIGMA_BROAD > SIGMA_NARROW.

The last two criteria are needed to prevent broad lines from over-fitting lines in (especially) low-mass dwarf galaxies or to capture unmodeled residuals in the stellar continuum.
Note that there is no longer any formal S/N cut on the broad-line amplitude. (Previously the two reddest broad Balmer lines, e.g., H-alpha and H-beta for lower-redshift objects, were required to be detected with >3-sigma significance, which threw out many bona fide Seyfert 1.5s highlighted in #118.)
Here's a quick comparison of the statistics for a single healpix, sv3/bright/9428 (where 2.1.2 is the version of the code used to build the fuji/v2.0 VAC):


Prevent cpu overutilization

Addresses https://github.com/jupyter/terminado/issues/54.

Closing in favor of #94.


ds.server regularize log print

What is the purpose of the pull request
#1740 ds.server regularize log print
Brief change log

server/master
server/quartz
server/rpc
server/utils

Codecov Report

Merging #1746 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1746      +/-   ##
==========================================
- Coverage   20.27%   20.27%   -0.01%
==========================================
  Files         287      287
  Lines       14039    14039
  Branches     2369     2369
==========================================
- Hits         2847     2846       -1
- Misses      10867    10869       +2
+ Partials      325      324       -1

Impacted Files
Coverage Δ

...e/dolphinscheduler/server/master/MasterServer.java
0% <0%> (ø)
:arrow_up:

...he/dolphinscheduler/server/utils/ProcessUtils.java
0% <0%> (ø)
:arrow_up:

...server/master/runner/MasterBaseTaskExecThread.java
0% <0%> (ø)
:arrow_up:

...heduler/server/quartz/DruidConnectionProvider.java
0% <0%> (ø)
:arrow_up:

.../apache/dolphinscheduler/server/rpc/LogClient.java
0% <0%> (ø)
:arrow_up:

...olphinscheduler/server/quartz/QuartzExecutors.java
0% <0%> (ø)
:arrow_up:

...ler/server/master/runner/MasterTaskExecThread.java
0% <0%> (ø)
:arrow_up:

...er/server/master/runner/MasterSchedulerThread.java
0% <0%> (ø)
:arrow_up:

...heduler/server/master/runner/MasterExecThread.java
0% <0%> (ø)
:arrow_up:

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762a62...e3172e1. Read the comment docs.


SARAALERT-1337: Prevent advanced filter from submitting empty date inputs

Description
Jira Ticket: SARAALERT-1337
The issue stems from the fact that you can apply a filter with the date field empty.  For “before” or “after,” that value would be null because it’s only one field so when you apply the filter it fails as a bad request (which is the intended behavior).  With “within,” there are “start” and “end” fields in the value so it gets past the check if the value is empty, causing that error to in the sentry error in the JIRA.
(Bugfix) How to Replicate

Open the advanced filter modal and select a date field
Clear the date input and hit apply (notice there is an error)
Repeat step 1 but select "before" or "after" instead of "within"
Observe similar behavior

(Bugfix) Solution
Prevent the user from submitting an empty date by reverting the date to the last valid date if they clear the date and click outside the field.
https://user-images.githubusercontent.com/35042815/109867350-62a42400-7c34-11eb-82a9-2d0490448ed6.mov
Important Changes
Please list important files (meaning substantial or integral to the PR) along with a list of the general changes that should be highlighted for reviewers.
DateInput.js

Added handleOnBlur method that is resets the input to the last valid value if it is empty or invalid
Added new prop requireDate that must be true for the handleOnBlur method to fire

AdvancedFilter.js

Pass in requireDate flag to necessary DateInput components

Testing
This fix was tested on the following browsers (submitter must check all those that apply):

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] IE11

Please describe the tests needed to verify your changes. Provide instructions for reproducing these tests. List any relevant details for your test configuration.

@timwongj @dubem7 can you re-review this?  this now includes clearing DOB if you enter and invalid date.
steps to test:

load a monitoree and click the identification edit link
type an invalid date into the already populated DOB field (ex: 12-34-5678)
click out of the input and see that the input clears
ensure you cannot click the next button because the field is empty

@timwongj @mdube7 @DPC15038 I think I've resolved all functionality issues on this.  Please retest and let me know!


[BUG] libsinsp-example crash on arm64 + modern_bpf

Describe the bug
Running the sinsp-example test program on an arm64 host with the modern_bpf driver causes a seg fault. Looking at it with a debugger it seems that the root cause is related to malformed events a the scap level and it is really likely a modern_bpf driver problem.
How to reproduce it

Patch the sinsp-example program removing the output (for some reason this step is essential to get the repro)

diff --git a/userspace/libsinsp/examples/test.cpp b/userspace/libsinsp/examples/test.cpp
index d0334b4bd..f7fc55c2b 100644
--- a/userspace/libsinsp/examples/test.cpp
+++ b/userspace/libsinsp/examples/test.cpp
@@ -415,11 +415,12 @@ int main(int argc, char** argv) {
                        cout << "[ERROR] " << error_msg << endl;
                });
                if(ev != nullptr) {
-                       sinsp_threadinfo* thread = ev->get_thread_info();
-                       if(!thread || g_all_threads || thread->is_main_thread()) {
-                               dump(inspector, ev);
-                               num_events++;
-                       }
+                       printf("%d\n", ev->get_type());
+                       //sinsp_threadinfo* thread = ev->get_thread_info();
+                       //if(!thread || g_all_threads || thread->is_main_thread()) {
+                       //      dump(inspector, ev);
+                       //      num_events++;
+                       //}
                }
        }
        std::chrono::steady_clock::time_point end = std::chrono::steady_clock::now();

Run sinsp-example -m
Once the capture is started run stress-ng --exec 1 --open 1 and the crash should appear almost immediately.

Expected behaviour
There should not be any malformed event.
Screenshots

Environment

Falco version: master
System info:

{
  "machine": "aarch64",
  "nodename": "redacted",
  "release": "6.5.0-1022-aws",
  "sysname": "Linux",
  "version": "#22~22.04.1-Ubuntu SMP Fri Jun 14 19:23:09 UTC 2024"
}

Cloud provider or hardware configuration: ec2 arm64 machine
OS:

PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Kernel:

Linux redacted 6.5.0-1022-aws #22~22.04.1-Ubuntu SMP Fri Jun 14 19:23:09 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

Installation method:
source

Additional context

/milestone 0.18.0


Windows / macOS: simplify code

simplify resource management by using C++ RAII like GCC attribute extension cleanup
simplify HEKY reading

Actually __attribute__((__cleanup__(cleanupFn))) is supported on all major C compiler ( gcc, clang and icc ) except MSVC I only used it on Windows and macOS for now. Let's see if the project author like it.

attribute((cleanup(cleanupFn))) runs a function when the variable goes out of scope.
So following code
FFstrbuf str;
ffStrbufInit(&str, "some string");

if(condition)
{
    ffStrbufDestroy(&str);
    return false;
}

//Use str
ffStrbufDestroy(&str);
return true;

Can be simplified to
FFstrbuf __attribute__((__cleanup__(ffStrbufDestroy))) str;
ffStrbufInit(&str, "some string");

if(condition)
    return false;

//Use str
return true;

Merged to my dev branch to avoid future conflicts


Broken Powershell API compatibility in provider implementation

Working on the providers I noticed that currently Pash's implementation of ItemCmdletProvider, SessionStateProviderBase, and others differ from the official Powershell API, because their methods all take Path objects instead of regular strings.
git log and blame are telling me that @staxmanade did this in March 2013 with the message:
replace many many usages of 'string path' with 'Path path' in prep for a cleanup on path usages
However, I would really like to revert this during my work, so we are staying compatible to Powershell. After all, this would prevent us from writing providers that work with both Pash and Powershell. And I really want to write such a provider, and I also think that it's a major feature as a cross-platform shell.
Any thoughts on this? I just didn't want to revert it without asking the original author ;)

Make whatever changes you need... I thought (at the time) it was a good approach, but am afraid it may not have been and am not surprised to see it come up - so sorry about that.

No problem :) I just wanted to make sure I'm not missing something important here. The general approach makes sense, it's just unfortunately breaking the compatibility :/


Use TwoPaneLayout in Compose Gallery sample

Good job! Your first PR for Compose comes in so quickly.

Good update! Does it make sense to open the detail view when the user selects the item from the list in the single-screen mode?

All looks good to me. It would be better if you can make the first screenshot smaller, more like the single screen mode, compare to the second one.


Revise media handling

Use ULID for owner image naming in GCS bucket
Publish message to PubSub for guest media
Create Google Drive folder and shared link for graduate on onboarding

So, we need to have subscriber server in order to process image upload also?

How do we gonna handle the google drive link for graduate? New command in line text message?

How do we gonna handle the google drive link for graduate? New command in line text message?

yesๆ


Setting "Move newly created windows to their last known zone" is not obeyed by all apps

Using PowerToys release v0.31.2, some app windows return to their last known zone regardless of whether the PowerToys setting "Move newly created windows to their last known zone" is enabled, presumably because of how they were written. Other apps never return to their last known zone, regardless of this setting.
An example of the latter is PowerToys itself.
Here’s a screenshot of PowerToys manually put into a zone by “Shift-dragging” it:

After PowerToys is closed and reopened it does not return to its last known zone, as shown in this screenshot:

This is not behavior I expect. After enabling "Move newly created windows to their last known zone", should I expect the PowerToys window to again be positioned as in the first screenshot?
The Zip file created by a Report Bug command has been attached.
Robert
Originally posted by @Robert-Tortorelli in https://github.com/microsoft/PowerToys/issues/7854#issuecomment-768742603
PowerToysReport_2021-02-11-12-39-22.zip

MS-Teams is another example.

The same is true for:

cmd.exe
Total Commander
Windows Terminal
Notion
and many more....

They are never forced back to their previous position.


gorm:primaryKey not being taken into consideration by auto migrator

Hi.
I am trying to create a table in the clickhouse database using gorm's auto migrator. I have defined the struct as below:
type Cost struct {
	InfraId    string    `json:"infra_id" gorm:"primaryKey,index:idx_primary"`
	Timestamp  time.Time `json:"timestamp" gorm:"primaryKey,index:idx_primary"`
	HourlyCost string    `json:"hourly_cost"`
}

When the automigrator runs, it sends the following SQL statement to the clickhouse DB.
CREATE TABLE `costs`(`infra_id` String,`timestamp` DateTime64(3),`hourly_cost` String  ) ENGINE=MergeTree() ORDER BY tuple()

As you can see, for some reason, it doesn't send any information about the primary keys. I have verified that it actually doesn't create any primary keys on the DB too. Why might this be happening?
Thanks.

I have same problem.

I have same problem

https://github.com/go-gorm/clickhouse/blob/master/migrator.go#L130
this function alse is a  todo list


Incorrect behavior on pre-filled inputs, using array of masks.

JsFiddle of the situation

Describe the bug

On pre-filled inputs, when using an array of masks, the plugin doesn't seem to be working correctly. With removeMaskOnSubmit = true, the value submitted still has (some of) the mask. If the field has optional characters, on the field with less than full characters filled, I can't type an additional one (first field of JsFiddle, the masks accept 10 or 11 characters, but on the one with 10 I can't add one more).
If I delete all characters of the field, the masks start working correctly again.

OS:

Windows 10 22H2

Browser

Firefox 127.0.2
Chrome 126.0.6478.127

Inputmask version

5.0.9

Can you provide some examples of your Inputmask configuration?

I have a JsFiddle on my post. Just using an array of masks on fields with values is enough.

Ah, I see now. Anyway, you should set values of your inputs without mask characters, i.e. not value="(12) 3456-7890" but value="1234567890".

But the one with a single mask works just fine

But the one with a single mask works just fine

But the one with a single mask works just fine

I'm not completely sure what's the intended behavior. Maybe it should handle values in the masked format. But usually, we want to store data without mask characters, because mask can format change or it's in a completely different format, e.g. some countries write their numbers like 1 100 100,51, but we need 1100100.51 inside our code. Hence, raw input values shouldn't contain mask characters in my opinion.


Change "add to favorites" button location in popover

I really enjoy using tuneful and I'm grateful that this app is open source, but I have a minor gripe.
When user sets popover style to minimal, and hovers cursor over the popover, "add to favorites" button and media control buttons overlaps. This doesn’t look good and sometimes causes misclicks. It would be great if the "add to favorites" button could be moved to a different location, at least when popover style is set to minimal. Maybe top left...? Slightly above from center of album art could work too.

It will be fixed in the next release (I moved it a bit up), thanks for reporting

Just released a new version of Tuneful with this fix implemented


Extend stageFilemode to accept array of paths

...as well as just a string.
There is a case in GK where Repository.prototype.stageFilemode gets called a bunch of times (once for every file in working directory, for instance). This wastes resources. stageFilemode should be able to accept a single path as string or multiple paths as array, then stage/unstage filemode changes for files specified as usual.

LGTM. Thanks @kenprice

Scratch that... we need tests for it first.


Reproducing Alfworld results

Hi thanks for the excellent work.
Could you please share the logs / traces of your agent for Alfworld, as it is quite hard to reproduce results otherwise.
Thank you.
@haotiansun14

@haotiansun14 @night-chen Could you please advice on next steps with this.
As the results using ReAct on Alfworld are significantly worse in actual fact, so we are curious what your results are on Alfworld and which models you exactly used for the results you report and whether you can share some logs for success / failure cases.
Thank you.

Also, as you can see from these screenshots (your results) vs. AgentBench - your results for ReAct/Reflexion are different to AgentBench, and therefore possibly your results using AdaPlanner are maybe off.
Therefore the concrete actions / questions are:

What models did you use for the results you report
How to achieve the results you get (as they are 70-80% higher than AgentBench and our experiments)
Please clarify your results overall.

Hi @ai-nikolai,
Apologies for the delayed response. Here’s the information you requested:

Logs/traces: Please find the attached logs for the results you mentioned: logs.zip. I hope they are helpful.

Models: The models referenced in Table II are as follows:

For ReAct and AdaPlanner, "GPT-3.5" denotes gpt-3.5-turbo, and "GPT-3" represents text-davinci-002.
For Reflexion, "GPT-3.5" refers to gpt-3.5-turbo.
The original Reflexion implementation used "GPT-3+3.5," combining both GPT-3 (text-davinci-002) for action generation and GPT-3.5 (text-davinci-003) for failure reflection.

Possible cause for results inconsistency: All experiments detailed in the AdaPlanner paper were conducted from February to May 2023, using the model specified as "gpt-3.5-turbo" in our notebooks. It appears that this was actually calling version "gpt-3.5-turbo-0301". Testing with this specific version might yield consistent results.

Thank you.

@haotiansun14 thank you very much for providing your sample trajectories that was really helpful.
Here are a few clarification questions based on your paper. Based on this figure from your paper (figure 4):

Questions:

Which model is used for a.) (I assume text-davinci-002?)
Does "Closed Loop Corrections" mean iterating over the same environment multiple times (similar to the case of Reflexion?)
Is it correct to understand that the score in b.) for Reflexion Gpt3.5 at 0 "closed loop corrections" is equivalent to running ReAct only? If so, is the score in the low 40s? Why is that? The ReAct score reported by you is 47%.
More importantly what does the score in c.) represent - i) how many samples & ii) how many "closed loop corrections" & iii) which model?
Why are the scores in d. so low? What is the exact setting?

Hi, @ai-nikolai,
@lichangh20 has provided some reproducible results (#3). I also mentioned it here for reference.


Doesn't it work on mobiles? Android, iPhone

First of all, thank you for your work. I have a question. Does it work in cell phone browsers? Or only on computers. From already thank you very much

Did you ever get it working on mobiles? @gasadinolfi

The quantized models should run well on mobile 👍


Sending value to custom field

In one of our DocuSign template we have two signers. For the first signer there is a text field need to be filled first.
I tried to call the DocuSign API, here is the code snippet.
client = DocusignRest::Client.new
@envelope_response = client.create_envelope_from_template(
  status: 'sent',
  email: {
    subject: "The test email subject envelope",
    body: "Envelope body content here"
  },
  template_id: "cf2a5306-xxxx-4ee5-xxxx-xxxxxxxxxx",
  signers: [
    {
      embedded: false,
      name: 'Sxxxx Mxxxx',
      email<EMAIL_ADDRESS>      role_name: 'Issuer',
      text_tabs: [
        {
          label: 'full_name',
          name: 'full_name',
          value: 'Another Person Name'
        }
      ]
    },
    {
      embedded: false,
      name: 'Another Person',
      email<EMAIL_ADDRESS>      role_name: 'Attorney',
      text_tabs: [
        {
          label: 'Full Name',
          name: 'Full Name',
          value: 'John Doe'
        }
      ]
    }
  ]
)

But unfortunately it is not working. Please suggest what did I miss?

Are you bundling to the master branch of the repo?
In Gemfile:
gem 'docusign_rest',  github: 'jondkinney/docusign_rest'

There hasn't been a proper gem release in a while, so this is the best way to get the current code.

It worked. Thank you.

It worked. Thank you Jon.

Sounds like this is sorted out, so I'll close this.   And we're planning on getting a new release out here shortly, woot!


Local IP Not Responding

I am trying to do a local connect (since I cannot control fan speed or vane direction without local direct it appears).  I got errors that others have listed before, so I tried DHCP assignment of a static IP to the Unit.  It has the static IP, but now home bridge Kumo appears to be holding onto the old IP when it tries for direct connect.  How can I remove the unit and re-add?

You should login to Homebridge UI and remove the accessory in the settings page.

You should be able to see how to remove an individual device or alternatively reset homebridge (not recommended).

Then restart Homebridge and it will discover the deleted accessory and refresh with latest information.

If it reassigns the old IP address then the Kumo cloud has not yet been updated and I suggest you try using the Kumo app to trigger an update.

It's a pain but once you have the static setup and working, I haven't had the problem since (6+ months).

Thanks much.. trying now.  I'm running Homebridge on a QNAP container, so the restart takes longer than I like and I can't do it directly from the UI.

Actually I'm not seeing how to remove an individual device.. the suggestion in the UI is "You will need to remove the existing Homebridge accessory from the Home app manually."
Which file is the persistent accessory in so that I can force it to re-pair?

Ok.. I actually reset the Kumo device and re-paired it to the Kumo cloud. I also uninstalled and reinstalled this plugin (thank you for all the work, btw, since I didn't say that before).  Now it has reinstalled the device again and it still will not connect direct, I get this in the console:

I see the device in the Home App again, but all I have is temp & mode & dehumidifier- nothing about vane position or fan speed.

The vane control and speed are located in the heater/cooler accessory. Press and hold on the icon and then scroll to reveal the additional settings and more info.

Yeah, they aren't there:

Yeah when separated you can do hold press and scroll and you can see the fan and oscillate settings.
When combined you have to click on the two accessory's and then do the hold press on just the heater/cooler to get to the fan. Very clunky.
I admit this is sub optimal. Maybe I will revert to having a separate fan accessory...

That might be better, there isn't a "automatic" setting for the fan, and there isn't actually "targeting" for the vanes.  I'm just putting these in on a full system that I got for the house.  Do you mind if I fork and play with some additional controls?  I also have two of the newer "iSee" units that have split vane controls as well, and I'd love to see what I can do with them.  (Also totally willing to clone, branch, and submit a pull request to you if I come up with anything good, if you prefer.)

Please do!

In regard to the vane controls, I couldn't see an appropriate accessory type in the API that would allow this. Right now, all it does is set to automatic is oscillate is set to false, and to oscillate if set to true. I couldn't see a good way to implement the other settings in the current Homekit API.

Fan Speed. The fan is set to automatic when it is set to the left most position (0). It then goes manual when set above zero. The fan speed has six settings on the Kumo side and 0-100 on the Homekit side so we currently convert one to the other.

In terms of fork, please do. I'd also be happy to incorporate any pull requests that you submit. As you can see there are definitely some UI design issues and also the IP address issue that could be improved upon.

(one last thing, the fanv2 accessory code is still in the source just commented out, clunky I know, but I really wasn't sure if I wanted to remove and I think for the next version, I will try having both the separate Fan Accessory and and fan speed in the Heater/Cooler accessory enabled - it should be pretty straightforward... famous last words)


Use wemake-python-styleguide

Can we use wemake-python-styleguide for mimesis?
@sobolevn What do you think?

It will require the complete refactoring. But, it would be interesting experience for me.
Since, I have not tried to integrate this linter to some existing code bases.
Only new ones.

There might be too many changes. I temporarily close it.


400 bots working!!?

is possible like on this vid
https://www.youtube.com/watch?v=DxPyYdbvIpY&feature=youtube_gdata
to get all these bots? can i have this version?


In Memory Queues don't seem to work when IDocumentSession is injected into EndPoint's method

STEPS TO REPRODUCE

Clone https://github.com/JoshuaNitschke/wolverine-issue-reproduction
Add postgres database as a user secret
Start the web api
Use the swagger page to execute all four end points

RESULT
The handlers for the first two endpoints will not execute (as determined by the handlers never firing logs nor hitting break points when running in debug mode).  However, the second two endpoints work just fine.  The only difference between the first set of endpoints and the second is that the first two have an unused dependency injected IDocumentSession session, which I wouldn't expect to affect the message bus behavior.
No Wolverine extensions are detected
info: Wolverine.Runtime.WolverineRuntime[0]
      Exporting Open Telemetry metrics from Wolverine with name Wolverine:WolverineIssueReproduction.WebApi, version <IP_ADDRESS>

info: Wolverine.Runtime.WolverineRuntime[0]
      Starting Wolverine messaging for application assembly WolverineIssueReproduction.Application, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
info: Wolverine.Configuration.HandlerDiscovery[0]
      Searching assembly WolverineIssueReproduction.WebApi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null for Wolverine message handlers
info: Wolverine.Configuration.HandlerDiscovery[0]
      Searching assembly WolverineIssueReproduction.Application, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null for Wolverine message handlers
info: Wolverine.Transports.ListeningAgent[0]
      Started message listening at dbcontrol://76b2943d-c3ab-437d-89d6-e0b21b42203a/
info: Wolverine.Runtime.Agents.NodeAgentController[0]
      Starting agents for Node 76b2943d-c3ab-437d-89d6-e0b21b42203a with assigned node id 45
info: Wolverine.Runtime.Agents.NodeAgentController[0]
      Found no elected leader on node startup, requesting node 7395fdbe-ea92-410c-952d-0c77c493ad39 to be the new leader
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5210
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Development
info: Microsoft.Hosting.Lifetime[0]
      Content root path: D:\GIT\wolverine-issue-reproduction\src\WolverineIssueReproduction.WebApi
info: WolverineIssueReproduction.Application.LogCommandHandler[0]
      I always log!
info: WolverineIssueReproduction.Application.LogCommand[104]
      Successfully processed message WolverineIssueReproduction.Application.LogCommand#018a7647-7979-441c-ae40-4d9faede113e from local://wolverineissuereproduction.application.logcommand/
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Got a new request with id 99f4c065-a617-4ea2-88a0-6a69d939b2c1 and I always start
info: WolverineIssueReproduction.Application.Sagas.StartTest[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.StartTest#018a7647-8aa7-4bfd-94cb-91d0436d6808 from local://wolverineissuereproduction.application.sagas.starttest/
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Saga 99f4c065-a617-4ea2-88a0-6a69d939b2c1 TIMEOUT OUT - MARKING COMPLETE
info: WolverineIssueReproduction.Application.Sagas.TestTimeout[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.TestTimeout#018a7647-8b91-4c40-8f54-a0c0611ea433 from local://wolverineissuereproduction.application.sagas.testtimeout/

EXPECTED RESULT:

The first two endpoints should behave exactly the same as the last two endpoints with log messages showing messages received, and handled as they do when opts.Policies.UseDurableLocalQueues() is set (output when enabled pictured below)

Now, uncomment opts.Policies.UseDurableLocalQueues(); and verify that logs show the handlers execute all four times - I would expect the same result for the in memory bus.
No Wolverine extensions are detected
info: Wolverine.Runtime.WolverineRuntime[0]
      Exporting Open Telemetry metrics from Wolverine with name Wolverine:WolverineIssueReproduction.WebApi, version <IP_ADDRESS>

info: Wolverine.Runtime.WolverineRuntime[0]
      Starting Wolverine messaging for application assembly WolverineIssueReproduction.Application, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
info: Wolverine.Configuration.HandlerDiscovery[0]
      Searching assembly WolverineIssueReproduction.WebApi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null for Wolverine message handlers
info: Wolverine.Configuration.HandlerDiscovery[0]
      Searching assembly WolverineIssueReproduction.Application, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null for Wolverine message handlers
info: Wolverine.Transports.ListeningAgent[0]
      Started message listening at dbcontrol://4b00e0db-a488-4033-a744-87531ccdd41f/
info: Wolverine.Runtime.Agents.NodeAgentController[0]
      Starting agents for Node 4b00e0db-a488-4033-a744-87531ccdd41f with assigned node id 44
info: Wolverine.Runtime.Agents.NodeAgentController[0]
      Found no elected leader on node startup, requesting node 7395fdbe-ea92-410c-952d-0c77c493ad39 to be the new leader
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5210
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Development
info: Microsoft.Hosting.Lifetime[0]
      Content root path: D:\GIT\wolverine-issue-reproduction\src\WolverineIssueReproduction.WebApi
info: WolverineIssueReproduction.Application.LogCommandHandler[0]
      I won't log without durable queues!
info: WolverineIssueReproduction.Application.LogCommand[104]
      Successfully processed message WolverineIssueReproduction.Application.LogCommand#018a7642-f6e0-428d-a5a0-633ac533a8a2 from local://wolverineissuereproduction.application.logcommand/
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Got a new request with id 1b834c19-3934-4079-9789-6eabe09cf2ac and I won't start without a durable queue
info: WolverineIssueReproduction.Application.Sagas.StartTest[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.StartTest#018a7643-08a6-4fa3-bd6d-33b39dfc95fb from local://wolverineissuereproduction.application.sagas.starttest/
info: Wolverine.Runtime.WolverineRuntime[0]
      Locally enqueuing scheduled message 018a7643-0a36-48f7-a66d-77b54846acf7 of type WolverineIssueReproduction.Application.Sagas.TestTimeout
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Saga 1b834c19-3934-4079-9789-6eabe09cf2ac TIMEOUT OUT - MARKING COMPLETE
info: WolverineIssueReproduction.Application.Sagas.TestTimeout[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.TestTimeout#018a7643-0a36-48f7-a66d-77b54846acf7 from local://wolverineissuereproduction.application.sagas.testtimeout/
info: WolverineIssueReproduction.Application.LogCommandHandler[0]
      I always log!
info: WolverineIssueReproduction.Application.LogCommand[104]
      Successfully processed message WolverineIssueReproduction.Application.LogCommand#018a7643-345c-43a3-854a-797a93ea8d0f from local://wolverineissuereproduction.application.logcommand/
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Got a new request with id 83c3d69c-38b6-411d-95a4-e452c524b45a and I always start
info: WolverineIssueReproduction.Application.Sagas.StartTest[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.StartTest#018a7643-4b7e-4c7a-8c67-a94fc4821362 from local://wolverineissuereproduction.application.sagas.starttest/
info: Wolverine.Runtime.WolverineRuntime[0]
      Locally enqueuing scheduled message 018a7643-4b9a-411a-b8bf-f217e80d50f2 of type WolverineIssueReproduction.Application.Sagas.TestTimeout
info: WolverineIssueReproduction.Application.Sagas.TestSaga[0]
      Saga 83c3d69c-38b6-411d-95a4-e452c524b45a TIMEOUT OUT - MARKING COMPLETE
info: WolverineIssueReproduction.Application.Sagas.TestTimeout[104]
      Successfully processed message WolverineIssueReproduction.Application.Sagas.TestTimeout#018a7643-4b9a-411a-b8bf-f217e80d50f2 from local://wolverineissuereproduction.application.sagas.testtimeout/

I added unit tests to verify my swagger experience. I would expect all the tests to pass

That was unpleasant to debug.

@jeremydmiller thank you!


fix(file-router): get back Flow AutoLayout

Fixes #2928

I also get the exception
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  ERROR(TypeScript)  An import path can only end with a '.tsx' extension when 'allowImportingTsExtensions' is enabled.
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  FILE  C:/Users/mgran/Code/Vaadin/flow-hilla-hybrid-example/src/main/frontend/generated/file-routes.ts:6:25
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     4 | import * as Page_2 from "../views/about.tsx";
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     5 | import * as Page_3 from "../views/hilla.tsx";
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :   > 6 | import * as Page_4 from "../views/login.tsx";

Which is fixed by removing the extension from the imports, but as this is a generated file it is a bit strange to get an exception.

@caalador, thanks for the review.

So now if you have a @Layout("/") RouterLayout and have a hilla view with the configuration flowLayout: false it will still be shown in the layout as the file-routes definition overrides any user definitions.

Oh, thanks! I definitely need a test for that...

I also get the exception

That's a bug, sorry. Already fixed 😅
P.S. Don't hesitate to use Request Changes to block the PR until everything is fixed 😊

@caalador, does the latest update fix the issue with config overriding you mentioned?

The layouts seem to work as expected (unless I forgot some combination as there are many), but now the imports get this strange full path in the middle and do not work 😓
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  ERROR(TypeScript)  Cannot find module '../C:\Users\mgran\Code\Vaadin\flow-hilla-hybrid-example\src\main\frontend\views/login.js' or its corresponding type declarations.
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  FILE  C:/Users/mgran/Code/Vaadin/flow-hilla-hybrid-example/src/main/frontend/generated/file-routes.ts:6:25
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     4 | import * as Page_2 from "../C:\\Users\\mgran\\Code\\Vaadin\\flow-hilla-hybrid-example\\src\\main\\frontend\\views/about.js";

That darn windows paths... 🥲 Let me fix it

That darn windows paths... 🥲 Let me fix it

That's the reason why I've taken on the burden of a windows machine for development

Great! Could you approve it, so we can merge it?


Access to page via login/pass

How to make view access some pages or categories only for users have authorization?
For example, access to Editor's manual.
Thanks

Second question: how to set few users in config?
Now i have only 1 user:
credentials    : {
    username : 'admin',
    password : 'password'
  },

Right now:

login is either all or nothing and not set per page.
multiple users are not currently supported (I opened #114 for this request)

Marking as up for grabs

Thank you!
How protect all pages by login/pass?

@mtaobiz you can add authentication to the layout.html begore the  add
{{#config.authentication}}
{{#loggedIn}}
and in the end of the document add
{{/loggedIn}}
{{/config.authentication}}

Thanks @tommysch, that's a good solution.
Does that work for you @mtaobiz ?

@mohammadrafigh progressed this ticket with his PR #129

I think good with a specific ACL, sample:
{{#config.auth.bygroup}}
and it possible add LDAP authentification support ?:
https://www.ibm.com/developerworks/library/se-use-ldap-authentication-authorization-node.js-bluemix-application/
https://github.com/vesse/passport-ldapauth

Including this in the Roadmap for v0.19 as a "Nice to Have" (link above this comment)
Please join the discussion there or re-open the issue
LDAP is likely out of scope for a while @fbo
If you still want it, please submit a separate issue with details on how you'd like the LDAP permissions to work


Incorrect error Import declarations in a namespace cannot reference a module?

Describe the bug
Since the Typescript pass rewrite, I get a Import declarations in a namespace cannot reference a module for code which works fine in TSC and old swc
(This is inside of Parcel which uses the swc crate)
Input code
import commonPathPrefix = require('common-path-prefix');

The whole file: https://github.com/parcel-bundler/parcel/blob/c182930c631e3bf06034d5b350064152b57206ce/packages/utils/parcel-lsp/src/LspServer.ts#L27
Config
You can see the options used for invoking the Typescript swc pass here: https://github.com/parcel-bundler/parcel/pull/9271/files#diff-871dd9618b173ec16a893d692b991948e079f1f85c6db41db35eded117ba58f2
Playground link
Not yet published to the playground
SWC Info output
swc_core = { version = "0.83.26"

Expected behavior
Should work without an error
Actual behavior
@parcel/transformer-js: Import declarations in a namespace cannot reference a
module.

  /home/runner/work/parcel/parcel/packages/utils/parcel-lsp/src/LspServer.ts:27:1
    26 | import * as url from 'url';
  > 27 | import commonPathPrefix = require('common-path-prefix');
  >    | ^
    28 |
    29 | // import {TextDocument} from 'vscode-languageserver-textdocument';

Version
swc_core "0.83.26"
Additional context
https://github.com/parcel-bundler/parcel/pull/9271

It looks like the parameter names for TypeScript pass are incorrect.
It should be changed to top_level_mark.

Thanks!


update: Add zerion to useInstalledWallets

Add zerion to useInstalledWallets.
I should have included it in this PR, but I think the author forgot to include this PR.

I'll check CI soon.


Add tests for runtime manager

Proposed changes
Problem: Missing tests on runtime manager
Im adding this init pr with few tests, if this goes well I can add another pr with more tests
gentle ping for @sjberman
Solution: Added tests and tested locally
Testing: running go test locally
optional: additional questions to clarify mocking and provide more details
Is practice for mocking runtime manager, more to use current usage with:
mgr = NewManagerImpl(&ngxclient.NginxClient{}, nil, logr.New(GinkgoLogr.GetSink()))
or I can use already created mock from runtimefakes:
runtimefakes.FakeManager as mocked struct, even tho its mocked interface ?
or its required to actually mock MetricsCollector in runtimefakes by creating runtimefakes.FakeMetricsCollector with counterfeiter and then use that one, in
NewManagerImpl(&ngxclient.NginxClient{}, &runtmefakes.FakeMetricCollector{}, logr.New(GinkgoLogr.GetSink()))
or in
mockedManager := &runtimefakes.FakeManager{}
any advice on this is appreciated a lot, thank you in advance
Closes https://github.com/nginxinc/nginx-gateway-fabric/issues/1498
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[X] I have read the CONTRIBUTING doc
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have checked that all unit tests pass after adding my changes
[X] I have updated necessary documentation
[X] I have rebased my branch onto main
[X] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@zedGGs To answer your question about mocking, one of the goals of this work is to test out the ManagerImpl functions in manager.go. So this means we'll need to use the real ManagerImpl implementation,  but be able to mock out the components that it uses, so we ensure we're just testing the ManagerImpl.

@sjberman sounds good,
thank you for the feedback and review, Im going to proceed accordingly

@sjberman apologies for not being on time with an update,
current test cases for ManagerImpl  are for situations where theres an error,
I can say I had little issues to properly mock correct upstreams on nginx client, so I have not added these test cases,
even tho I tried to do this, I can say I actually don't know how this works, any advice is appreciated
thank you in advance !
if you want you can take current changes and I can add separated pr for good test cases,
issue happens to be:
 failed to update servers of unknown upstream: failed to get the HTTP servers of upstream unknown: failed to get http/upstreams/unknown/servers: Get "http://<IP_ADDRESS>:80/9/http/upstreams/unknown/servers": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
			serversMock = ngxclient.UpstreamServer{
				ID:          1,
				Server:      "<IP_ADDRESS>:80",
				MaxConns:    &MaxConnsMock,
				MaxFails:    &MaxFailsMock,
				FailTimeout: "test",
				SlowStart:   "test",
				Route:       "test",
				Backup:      &BackupMock,
				Down:        &DownMock,
				Drain:       false,
				Weight:      &WeightMock,
				Service:     "",
			}

with ngxclient.NewNginxClient("<IP_ADDRESS>:80", client.WithHTTPClient(httpClient))

@zedGGs Thanks for the update. The issue you're seeing is that the nginx client is attempting to reach a real server, and fails. For unit tests we obviously do not want to use a real server. This means we probably need to create interfaces in https://github.com/nginxinc/nginx-plus-go-client, so we can provide a mock client in our own unit tests that won't try to contact a real server.

@sjberman here's an update, I have updated NgxPlusClient to use UpdateHTTPServers and GetUpstreams since they are only being used currently,
can add more improvements in test overall if you think something can be better
thanks

It would be nice if we could also find a way to test the Reload() function. May require temporary files and another client mock.

@kate-osborn sure, I am going to try add test for that too
thanks for feedback !!

Reopening after discussion with Zedd!

Reopen please (don't know does this works)

@zedGGs looks like I can't reopen. The button is greyed out.
Are you able to reopen?

Now I can reopen..

It says this


The project originally had a dependency on http-client 0.1.7 but a chang...

...e in 0.2.0 and later means the :body is a stream rather than a string. That causes problems if you try to use the library in another project with a dependency on 0.2.0 or later that. I've upversioned to 0.2.0 only rather than implying a depend on any later version of http-client.
This commit just grabs the whole contents of the stream. There's probably scope for better laziness here.

Thanks for the PR, @scottyw! I hadn't noticed the change in puppetlabs/http-client and I'm fully in favor of upgrading. That said, since the library always expects bodies to be strings, I think it would be better to just add {:as :text} to the default opts maps in make-http-client and make-https-client (per the docs). Would you be willing to amend your PR to do that?

Sounds like a plan! I'll do that next week.
Thanks,
S
On 16 Jan 2015 18:12, "Justin Holguin"<EMAIL_ADDRESS>wrote:

Thanks for the PR, @scottyw https://github.com/scottyw! I hadn't
noticed the change in puppetlabs/http-client and I'm fully in favor of
upgrading. That said, since the library always expects bodies to be
strings, I think it would be better to just add {:as :text} to the
default opts maps in make-http-client and make-https-client (per the docs
https://github.com/puppetlabs/clj-http-client/blob/master/doc/clojure-client.md#making-requests-with-a-persistent-client).
Would you be willing to amend your PR to do that?
—
Reply to this email directly or view it on GitHub
https://github.com/holguinj/clj-puppetdb/pull/1#issuecomment-70296064.

@holguinj Does that look OK to you? Thanks!

Hey @holguinj, sorry to hassle, are you happy enough to accept this one? I'll get the changes merged into the puppetlabs namespace and organise CI.
Thanks!


Model can not converge

hi, I try to train wavtokenizer on ljspeech and libritts respectively, but the loss seems can not converge. I did'n change any code, just change the following configuration:
data:
  class_path: decoder.dataset.VocosDataModule
  init_args:
    train_params:
      filelist_path: ./WavTokenizer-main/data/LJSPEECH/train.txt
      sampling_rate: 24000
      num_samples: 24000
      batch_size: 16
      num_workers: 8

    val_params:
      filelist_path: ./WavTokenizer-main/data/LJSPEECH/val.txt
      sampling_rate: 24000
      num_samples: 24000
      batch_size: 5
      num_workers: 8

and can see loss as the pic, Is my configuration incorrect? Or still need to continue to wait? thanks for reply!

hi, I try to train wavtokenizer on ljspeech and libritts respectively, but the loss seems can not converge. I did'n change any code, just change the following configuration:
data:
  class_path: decoder.dataset.VocosDataModule
  init_args:
    train_params:
      filelist_path: ./WavTokenizer-main/data/LJSPEECH/train.txt
      sampling_rate: 24000
      num_samples: 24000
      batch_size: 16
      num_workers: 8

    val_params:
      filelist_path: ./WavTokenizer-main/data/LJSPEECH/val.txt
      sampling_rate: 24000
      num_samples: 24000
      batch_size: 5
      num_workers: 8

and can see loss as the pic, Is my configuration incorrect? Or still need to continue to wait? thanks for reply!

The TensorBoard visualization suggests that the training has stalled. I’ve encountered similar issues before, which are often due to problems with the model configuration or architecture. Based on the data configuration you provided, there doesn't appear to be any obvious issues. It might be helpful to start by training on the LibriTTS dataset and progressively debug from there. Typically, WavTokenizer converges quickly, and within a few hundred steps, the loss should already be in the double digits.

The TensorBoard visualization suggests that the training has stalled. I’ve encountered similar issues before, which are often due to problems with the model configuration or architecture. Based on the data configuration you provided, there doesn't appear to be any obvious issues. It might be helpful to start by training on the LibriTTS dataset and progressively debug from there. Typically, WavTokenizer converges quickly, and within a few hundred steps, the loss should already be in the double digits.

I reduce half of the learning rate, and the model seems to start converging at the 900 steps. Thanks for reply!


refactor: moves git settings to dedicated tab

Moves git settings to dedicated tab

git-credentials was missing from the project names sub so it would redirect to /project/null/settings/git-credentials if the scope was global


"Installation Issue with SQSgen Due to Version Incompatibility

Hello, I would like to ask for your help. When I was installing SQSgen, I encountered an issue with version incompatibility: undefined symbol: _ZN5boost3log11v2_mt_posix5sinks26basic_text_ostream_backendIcE7consumeERKNS1_11record_viewERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE.
The versions I have installed are as follows: Could you please recommend the versions of the libraries I should download?
Python 3.9.19
Boost 1.75
Numpy 1.21.6
g++ (GCC) 4.8.5
mpirun (Open MPI) 4.1.6

The specific error message is as follows:
sqsgen --version
Traceback (most recent call last):
File "/home/haoxw/anaconda3/envs/sqsgen/bin/sqsgen", line 5, in
from sqsgenerator.cli import cli
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/init.py", line 2, in
import sqsgenerator.cli
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/cli.py", line 4, in
from sqsgenerator.commands.run import run
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/commands/run.py", line 7, in
from sqsgenerator.commands.export import export_structures
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/commands/export.py", line 7, in
from sqsgenerator.public import extract_structures
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/public.py", line 11, in
from sqsgenerator.settings.readers import read_structure
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/settings/init.py", line 5, in
from sqsgenerator.settings.defaults import defaults
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/settings/defaults.py", line 9, in
from sqsgenerator.settings.functional import const, if_
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/settings/functional.py", line 4, in
from sqsgenerator.core import get_function_logger
File "/home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/core/init.py", line 6, in
from sqsgenerator.core.core import SQSResult, Atom
ImportError: /home/haoxw/anaconda3/envs/sqsgen/lib/python3.9/site-packages/sqsgenerator/core/core.so: undefined symbol: _ZN5boost3log11v2_mt_posix5sinks26basic_text_ostream_backendIcE7consumeERKNS1_11record_viewERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

Hi @nanoparticals
Did you install it by compiling it yourself or did  you use conda to install it?
Is that is on MacOs or Linux?
Do you have the option to use a newer Python version? Currently the binaries are build against boost 1.8.4 (see here)

Thank you very much for your response!
I will update the Boost library and Python.


I think a recent update has killed custom client support.

I don't know, all of the sudden the page is blank when I hit play. I have tried to use a fresh custom client but it does not work either.
Is anyone else having this problem?

Nevermind, an error on my end.


Call JOSE.JWK from an anonymous function

Without wrapping it in an anonymous function, it tries to run the JOSE.JWK method when the config file gets loaded and it blows up with a:
** (Mix.Config.LoadError) could not load config config/config.exs
    ** (UndefinedFunctionError) undefined function JOSE.JWK.from_file/1 (module JOSE.JWK is not available)

error

Thank you @yoshdog 👍


Fix e2e test

fixes e2e test expected string

Hello @flakolefluk,
thank you very much for your contributions, I appreciate that. We will probably have a look at some ngx-cookie-service issues on Saturday, and I will also accept your pull requests. Feel free to add yourself to the list of contributors in README.md 😃
Cheers from Berlin


generator is not using the proto json_name as json tag

The field name is used instead:
https://github.com/golang/protobuf/blob/master/protoc-gen-go/generator/generator.go#L1777-L1778
Should I create a pull request?

It's working as intended. The json_name from the FieldDescriptorProto is specific to the JSON spec for proto3, and is used by the jsonpb package, but the json tag is legacy, and follows a different naming scheme.


[Zoom] 400 Error After OAuth Changes

Extension
https://www.raycast.com/raycast/zoom
Description
Error: Error while refreshing tokens: 400 (Bad Request)
{"error":"invalid_grant"}
at withAccessToken(fie)

Dr:index.js:11:2490
at ray-navigation-stack
Lo:index.js:11:2088
Steps To Reproduce
In the latest version of the Zoom extension after the Jan 31 OAuth changes.
Current Behaviour
It isn't working. =)
Expected Behaviour
It should work =)

It should be fixed in the latest release of the extension


Current interpreter cannot be changed and used for the interactive window

Open workspace
Open py file with cells
Set interpreter
Run interactive window (it should use interpreter)
Change interpreter
Run interactive window
Kernel does not start with new interpreter. You have to reload to get it to work.

IDK exactly what we want to happen, but if I leave the Interactive window open and change the interpreter, the interactive window stays with the same kernel.
If I change the interpreter, close the interactive window, and run a cell again, the new Interactive Window is created with the selected interpreter.

If I change the interpreter, close the interactive window, and run a cell again, the new Interactive Window is created with the selected interpreter.

This is the desired behavior.


createConfirm showing data twice

Hi.
I am trying to save new data on server with firebase.
My issue when I set it with
  (createConfirm)="onCreateConfirm($event)"
and my function:
  onCreateConfirm(event): any {
    this.service.createData(event.newData);

  }

I can see that table starting showing same data 2 times, One from my server db firebase and second somehow the table added itself. how to fix it?
link to q from stack

any updates? I added 50 points for answer  on stackoverflow

https://stackoverflow.com/questions/40430893/ng2-smart-table-create-button-not-working-correctly/51119391#51119391
Check answer there :dango:

This way you won't have duplicates :)
source: LocalDataSource = new LocalDataSource();

onCreateConfirm(event): any {
    event.confirm.resolve();
    this.source.refresh();
    this.service.createData(event.newData);
}


Added My Github Profile

Added a new github profile with Dp

This contribution is for hacktoberfest 2021
Please review my pr #142 @ShimilSAbraham