[PDI-16273]-Several places where input streams are not closed

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/spreadsheet/KWorkbook.java
  engine/src/main/java/org/pentaho/di/core/KettleVariablesList.java
  engine/src/main/java/org/pentaho/di/job/entries/ftpsget/FTPSConnection.java
  engine/src/main/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariables.java
  engine/src/main/java/org/pentaho/di/repository/RepositoriesMeta.java
  engine/src/main/java/org/pentaho/di/trans/step/BaseStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/jxl/XLSWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ods/OdfWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java
  engine/src/main/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/rest/Rest.java
  engine/src/main/resources/org/pentaho/di/trans/steps/exceloutput/messages/messages_en_US.properties
  engine/src/test/java/org/pentaho/di/core/util/KettleVariablesListTest.java
  engine/src/test/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariablesTest.java
  engine/src/test/java/org/pentaho/di/repository/RepositoriesMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/step/BaseStepMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutputIT.java
  engine/src/test/resources/org/pentaho/di/trans/step/step-attributes.xml
  engine/src/test/resources/org/pentaho/di/trans/steps/propertyoutput/propertyOutput.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.KettleVariablesList

Branch Change: -25% :small_red_triangle_down:
Complexity Change: -14.2% :small_red_triangle_down:
Instruction Change: -16.9% :small_red_triangle_down:
Line Change: -4.4% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.FTPSConnection

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.setvariables.JobEntrySetVariables

Branch Change: -6% :small_red_triangle_down:
Complexity Change: -9.1% :small_red_triangle_down:
Instruction Change: -4.4% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.repository.RepositoriesMeta

Branch Change: -5.1% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -3.3% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStepMeta

Branch Change: -5.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.2% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.jxl.XLSWorkbook

Complexity Change: -1.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.ods.OdfWorkbook

Complexity Change: -2.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.exceloutput.ExcelOutput

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.4% :small_red_triangle_down:
Instruction Change: -1.4% :small_red_triangle_down:
Line Change: -0.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStep

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rest.Rest

Complexity Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on core/src/main/java/org/pentaho/di/core/spreadsheet/KWorkbook.java. Found 2017. Was expecting 2018

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/main/java/org/pentaho/di/trans/steps/rest/Rest.java. Found 2017. Was expecting 2018

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/test/java/org/pentaho/di/repository/RepositoriesMetaTest.java. Found 2017. Was expecting 2018

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/src/main/java/org/pentaho/di/core/KettleVariablesList.java

:heavy_exclamation_mark: Line has trailing spaces at Line: 41

/home/buildguy/project/engine/src/main/java/org/pentaho/di/repository/RepositoriesMeta.java

:heavy_exclamation_mark: '{' is not preceded with whitespace. at Line: 215 Column: 113

/home/buildguy/project/engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ods/OdfWorkbook.java

:heavy_exclamation_mark: 'if' is not followed by whitespace. at Line: 67 Column: 7

/home/buildguy/project/engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java

:heavy_exclamation_mark: Line has trailing spaces at Line: 810

/home/buildguy/project/engine/src/main/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutput.java

:heavy_exclamation_mark: Line has trailing spaces at Line: 246

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/spreadsheet/KWorkbook.java
  engine/src/main/java/org/pentaho/di/core/KettleVariablesList.java
  engine/src/main/java/org/pentaho/di/job/entries/ftpsget/FTPSConnection.java
  engine/src/main/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariables.java
  engine/src/main/java/org/pentaho/di/repository/RepositoriesMeta.java
  engine/src/main/java/org/pentaho/di/trans/step/BaseStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/jxl/XLSWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ods/OdfWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java
  engine/src/main/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/rest/Rest.java
  engine/src/main/resources/org/pentaho/di/trans/steps/exceloutput/messages/messages_en_US.properties
  engine/src/test/java/org/pentaho/di/core/util/KettleVariablesListTest.java
  engine/src/test/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariablesTest.java
  engine/src/test/java/org/pentaho/di/repository/RepositoriesMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/step/BaseStepMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutputIT.java
  engine/src/test/resources/org/pentaho/di/trans/step/step-attributes.xml
  engine/src/test/resources/org/pentaho/di/trans/steps/propertyoutput/propertyOutput.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.KettleVariablesList

Branch Change: -25% :small_red_triangle_down:
Complexity Change: -14.2% :small_red_triangle_down:
Instruction Change: -16.9% :small_red_triangle_down:
Line Change: -4.4% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.FTPSConnection

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.setvariables.JobEntrySetVariables

Branch Change: -6% :small_red_triangle_down:
Complexity Change: -9.1% :small_red_triangle_down:
Instruction Change: -4.4% :small_red_triangle_down:

org.pentaho.di.repository.RepositoriesMeta

Branch Change: -5.1% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -3.3% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStepMeta

Branch Change: -5.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.jxl.XLSWorkbook

Complexity Change: -1.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.ods.OdfWorkbook

Complexity Change: -2.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.exceloutput.ExcelOutput

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.4% :small_red_triangle_down:
Instruction Change: -1.4% :small_red_triangle_down:
Line Change: -0.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStep

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.rest.Rest

Complexity Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

@mchen-len-son, @mbatchelor please review

@mchen-len-son, @mbatchelor, @pamval please review it

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/spreadsheet/KWorkbook.java
  engine/src/main/java/org/pentaho/di/core/KettleVariablesList.java
  engine/src/main/java/org/pentaho/di/job/entries/ftpsget/FTPSConnection.java
  engine/src/main/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariables.java
  engine/src/main/java/org/pentaho/di/repository/RepositoriesMeta.java
  engine/src/main/java/org/pentaho/di/trans/step/BaseStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/jxl/XLSWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ods/OdfWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java
  engine/src/main/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/rest/Rest.java
  engine/src/main/resources/org/pentaho/di/trans/steps/exceloutput/messages/messages_en_US.properties
  engine/src/test/java/org/pentaho/di/core/util/KettleVariablesListTest.java
  engine/src/test/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariablesTest.java
  engine/src/test/java/org/pentaho/di/repository/RepositoriesMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/step/BaseStepMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutputIT.java
  engine/src/test/resources/org/pentaho/di/trans/step/step-attributes.xml
  engine/src/test/resources/org/pentaho/di/trans/steps/propertyoutput/propertyOutput.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.KettleVariablesList

Branch Change: -25% :small_red_triangle_down:
Complexity Change: -17.8% :small_red_triangle_down:
Instruction Change: -17.9% :small_red_triangle_down:
Line Change: -4.9% :small_red_triangle_down:

:new: org.pentaho.di.core.KettleVariablesList.KettleVariablesListHelper

Complexity Coverage: 50% :exclamation:
Instruction Coverage: 66.7% :exclamation:
Line Coverage: 50% :exclamation:
Method Coverage: 50% :exclamation:

org.pentaho.di.job.entries.ftpsget.FTPSConnection

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.setvariables.JobEntrySetVariables

Branch Change: -6% :small_red_triangle_down:
Complexity Change: -9.1% :small_red_triangle_down:
Instruction Change: -4.4% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.repository.RepositoriesMeta

Branch Change: -5.1% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -3.3% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStepMeta

Branch Change: -5.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.2% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.jxl.XLSWorkbook

Complexity Change: -1.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.ods.OdfWorkbook

Complexity Change: -2.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.exceloutput.ExcelOutput

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStep

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.2% :small_red_triangle_down:
Instruction Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java

:heavy_exclamation_mark: Line has trailing spaces at Line: 544

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/spreadsheet/KWorkbook.java
  engine/src/main/java/org/pentaho/di/core/KettleVariablesList.java
  engine/src/main/java/org/pentaho/di/job/entries/ftpsget/FTPSConnection.java
  engine/src/main/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariables.java
  engine/src/main/java/org/pentaho/di/repository/RepositoriesMeta.java
  engine/src/main/java/org/pentaho/di/trans/step/BaseStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/jxl/XLSWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/ods/OdfWorkbook.java
  engine/src/main/java/org/pentaho/di/trans/steps/exceloutput/ExcelOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java
  engine/src/main/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/rest/Rest.java
  engine/src/main/resources/org/pentaho/di/trans/steps/exceloutput/messages/messages_en_US.properties
  engine/src/test/java/org/pentaho/di/core/util/KettleVariablesListTest.java
  engine/src/test/java/org/pentaho/di/job/entries/setvariables/JobEntrySetVariablesTest.java
  engine/src/test/java/org/pentaho/di/repository/RepositoriesMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/step/BaseStepMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/propertyoutput/PropertyOutputIT.java
  engine/src/test/resources/org/pentaho/di/trans/step/step-attributes.xml
  engine/src/test/resources/org/pentaho/di/trans/steps/propertyoutput/propertyOutput.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.KettleVariablesList

Branch Change: -25% :small_red_triangle_down:
Complexity Change: -17.8% :small_red_triangle_down:
Instruction Change: -17.9% :small_red_triangle_down:
Line Change: -4.9% :small_red_triangle_down:

:new: org.pentaho.di.core.KettleVariablesList.KettleVariablesListHelper

Complexity Coverage: 50% :exclamation:
Instruction Coverage: 66.7% :exclamation:
Line Coverage: 50% :exclamation:
Method Coverage: 50% :exclamation:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.FTPSConnection

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.setvariables.JobEntrySetVariables

Branch Change: -6% :small_red_triangle_down:
Complexity Change: -9.1% :small_red_triangle_down:
Instruction Change: -4.4% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.repository.RepositoriesMeta

Branch Change: -5.1% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -3.3% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStepMeta

Branch Change: -5.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.2% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.jxl.XLSWorkbook

Complexity Change: -1.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelinput.ods.OdfWorkbook

Complexity Change: -2.5% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

@mchen-len-son, all the notes was fixed


EditorHelp: Improve enum ref resolving and add constant ref support

Enum reference resolving will now search in the @globalscope (sorry for accidental tagging 😅) if no class is specified and the enum cannot be resolved in the current class.
Added support for constant references, e.g.: [const KEY_ENTER] or [const Control.FOCUS_CLICK]. It supports enum constants (the enum name must not be included).

Also made some improvements to the classref regarding references. Some of them make use of the new addition or depend on the fixes introduced with this PR.

The convertor to .rst should also be updated.

Didn't realize the branch name was used for filling the PR title...

I'm in the process of updating the rst converter. It appears it already supported a way to reference constants that is being used in a few places of the classref. The format is [constant NAME]. This is not supported in the EditorHelp and appears as raw text where used. It cannot be supported either because the tag type can only be 6 characters long. I will update the rst converter to use const instead and update the previous references in the classref.

Done!

The format is [constant NAME]. This is not supported in the EditorHelp and appears as raw text where used. It cannot be supported either because the tag type can only be 6 characters long.

Is this 6-char limit meaningful though? If it's arbitrary, it can likely be removed, as it seems all checks are done with startswith anyway. I think it made sense to use [constant NAME] as it matches the corresponding XML tag <constant>, like all other tags. I won't fight over it though, it's fine too to use [const NAME], just slightly less user-friendly for new documentation writers.

The 6 chars length is meaningful. In editor_help.cpp you can see it's using rpad(6) to make sure it has that exact length (resulting in enum   and const ). And then there is substr(1, 6).
I haven't check but it may be trivial to increase this length if you want to allow longer identifiers like constant.

Renamed the const tag to constant.

Re-estructured the changes into two commits. That was harder than I expected it would be... 😓

looks great

Thanks!

Consider for 3.1.2


 Hosts:    ip-10-0-1-182.ap-southeast-1.compute.internal
     Play:     OpenShift Health Checks
     Task:     Run health checks (install) - EL
     Message:  One or more checks failed
     Details:  check "docker_image_availability":
               One or more required container images are not available:
                   quay.io/coreos/etcd:v3.2.22
               Checked with: skopeo inspect [--tls-verify=false] [--creds=<user>:<pass>] docker://<registry>/<image>```

Will take a look into this shortly. Any special changes you made to the setup that made it non-standard?

no, just make infrastructure and make openshift.

Have you tried rerunning make openshift? It can be a little flakey on the
ansible side, but is idempotent so safe to run and rerun
On Fri, 5 Apr 2019 at 12:21 PM, Pichate Ins<EMAIL_ADDRESS>wrote:

no, just make infrastructure and make openshift.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dwmkerr/terraform-aws-openshift/issues/85#issuecomment-480143501,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1nSATxXHb6rbEk7XbbboA8-GUl-fY0ks5vds9EgaJpZM4cc_F9
.

i try to run many time. but still got same error

I am trying to reproduce locally. Looks like you have encountered this:
https://github.com/openshift/openshift-ansible/issues/11369
I have some other things I'm looking into (see below) but for now I think it is the issue above. Will update this comment as tI debug more.

Potential things to try

try deleting your local .terraform folder (after running terraform destroy) and then re-run terraform init && terraform get so that you get the absolute latest version of the AWS providers.
Let me know which region you are running in, if not the default

Similar Issues
Searching for similar issues, I've found these:

https://github.com/openshift/openshift-ansible/issues/6002
https://github.com/openshift/openshift-ansible/issues/7808
https://github.com/openshift/openshift-ansible/issues/6300
https://bugzilla.redhat.com/show_bug.cgi?id=1480195

Summarising:

The first suggests the issue is due to transient failures or outages in the redhat container registries it is trying to pull images from. Highly unlikely to be your issue as it is failing consistently.
The second was the wrong registry
The third was proxy settings for a registry

In all cases it is a failure to download a specific image. In your case, the specific image which is failing to download is:
As indicated by:
["OpenShiftCheckException", "One or more required container images are not available:
 quay.io/coreos/etcd:v3.2.22
Checked with: skopeo inspect [--tls-verify=false] [--creds=:] docker:///\n"]]

So right now it looks like an issue with quay.io/coreos/etcd:v3.2.22

I was testing on ap-southeast-1 got the same issue but the  ap-southeast-2 was working smoothly

That is bizarre.... Let me see if I can repro in the same way

I am also getting the same issue, it worked yesterday, I destroyed everything and then when I tried it again, getting the issue even after several retries, deleted the tf state files and tried everything from beginning still getting the same issue.

I was getting this as well. The issue may be related to this issue:
https://github.com/openshift/openshift-ansible/issues/10741
The workaround to disable the availability check worked for me and I was able to install this cluster successfully.

I am running into same issue. I tried running in us-east-1 and ap-southeast-2 but got the same error.
CHECK [memory_availability : ip-10-0-1-45.ap-southeast-2.compute.internal] ***** fatal: [ip-10-0-1-45.ap-southeast-2.compute.internal]: FAILED! => {"changed": true, "checks": {"disk_availability": {}, "docker_image_availability": {"changed": true, "failed": true, "failures": [["OpenShiftCheckException", "One or more required container images are not available:\n    docker.io/cockpit/kubernetes:latest,\n    docker.io/openshift/origin-control-plane:v3.11,\n    docker.io/openshift/origin-deployer:v3.11,\n    docker.io/openshift/origin-docker-registry:v3.11,\n    docker.io/openshift/origin-haproxy-router:v3.11,\n    docker.io/openshift/origin-pod:v3.11,\n    quay.io/coreos/etcd:v3.2.22\nChecked with: skopeo inspect [--tls-verify=false] [--creds=<user>:<pass>] docker://<registry>/<image>\n"]], "msg": "One or more required container images are not available:\n    docker.io/cockpit/kubernetes:latest,\n    docker.io/openshift/origin-control-plane:v3.11,\n    docker.io/openshift/origin-deployer:v3.11,\n    docker.io/openshift/origin-docker-registry:v3.11,\n    docker.io/openshift/origin-haproxy-router:v3.11,\n    docker.io/openshift/origin-pod:v3.11,\n    quay.io/coreos/etcd:v3.2.22\nChecked with: skopeo inspect [--tls-verify=false] [--creds=<user>:<pass>] docker://<registry>/<image>\n"}, "docker_storage": {"changed": true, "data_pct_used": 0.023671361645169142, "data_threshold": 90.0, "data_total": "34.18 GB", "data_total_bytes":<PHONE_NUMBER>4.32, "data_used": "19.92 MB", "data_used_bytes": 20887633.92, "metadata_pct_used": 0.00011372055802915023, "metadata_threshold": 90.0, "metadata_total": "88.08 MB", "metadata_total_bytes": 92358574.08, "metadata_used": "57.34 kB", "metadata_used_bytes": 58716.16, "msg": "Thinpool usage is within thresholds.", "vg_free": "48.00g", "vg_free_bytes":<PHONE_NUMBER>2.0}, "memory_availability": {}, "package_availability": {"changed": false, "invocation": {"module_args": {"packages": ["PyYAML", "bash-completion", "bind", "ceph-common", "dnsmasq", "docker", "firewalld", "flannel", "glusterfs-fuse", "httpd-tools", "iptables", "iptables-services", "iscsi-initiator-utils", "libselinux-python", "nfs-utils", "ntp", "openssl", "origin", "origin-clients", "origin-hyperkube", "origin-node", "pyparted", "python-httplib2", "yum-utils"]}}}, "package_version": {"changed": false, "invocation": {"module_args": {"package_list": [{"check_multi": false, "name": "origin", "version": "3.11"}, {"check_multi": false, "name": "origin-master", "version": "3.11"}, {"check_multi": false, "name": "origin-node", "version": "3.11"}], "package_mgr": "yum"}}}}, "msg": "One or more checks failed", "playbook_context": "install"}
Any idea how to fix this?

@dwmkerr  hello any workaround for this issue ? I have the same problem

I too see the same with openshift-ansible-3.11.37-1.git.0.3b8b341.el7.noarch on Centos 7.
First is:
CHECK [memory_availability : ....
followed by:
   Message:  One or more checks failed      Details:  check "docker_image_availability":                One or more required container images are not available:                    docker.io/cockpit/kubernetes:latest,                    docker.io/openshift/origin-deployer:v3.11,                    docker.io/openshift/origin-docker-registry:v3.11,                    docker.io/openshift/origin-haproxy-router:v3.11,                    docker.io/openshift/origin-pod:v3.11                Checked with: skopeo inspect [--tls-verify=false] [--creds=<user>:<pass>] docker://<registry>/<image>
check "docker_storage":                Could not find imported module support code for docker_info.  Looked for either AnsibleDockerClient.py or docker_common.py                Traceback (most recent call last):                  File "/usr/share/ansible/openshift-ansible/roles/openshift_health_checker/action_plugins/openshift_health_check.py", line 225, in run_check                    result = check.run()                  File "/usr/share/ansible/openshift-ansible/roles/openshift_health_checker/openshift_checks/docker_storage.py", line 53, in run                    docker_info = self.execute_module("docker_info", {})                  File "/usr/share/ansible/openshift-ansible/roles/openshift_health_checker/openshift_checks/__init__.py", line 211, in execute_module                    result = self._execute_module(module_name, module_args, self.tmp, self.task_vars)                  File "/usr/lib/python2.7/site-packages/ansible/plugins/action/__init__.py", line 815, in _execute_module                    (module_style, shebang, module_data, module_path) = self._configure_module(module_name=module_name, module_args=module_args, task_vars=task_vars)                  File "/usr/lib/python2.7/site-packages/ansible/plugins/action/__init__.py", line 209, in _configure_module                    **become_kwargs)                  File "/usr/lib/python2.7/site-packages/ansible/executor/module_common.py", line 1258, in modify_module                    environment=environment)                  File "/usr/lib/python2.7/site-packages/ansible/executor/module_common.py", line 1095, in _find_module_utils                    py_module_cache, zf)                  File "/usr/lib/python2.7/site-packages/ansible/executor/module_common.py", line 764, in recursive_finder                    raise AnsibleError(' '.join(msg))                AnsibleError: Could not find imported module support code for docker_info.  Looked for either AnsibleDockerClient.py or docker_common.py
I'm on bare-metal and behind a proxy but I put proxy vars in all the places I know of. Commands: docker, skopeo succeed when ran manually.
regards, L.


checks for 2xx codes and sends original error message

may help other debug #36

Sorry for the mad delay, good stuff :+1:


[Parse Error] - Collector's Ritual Precursor Tablet of the Dogma

Parse Error
Collector's Ritual Precursor Tablet of the Dogma
Item Text
Please provide the item's description

Can be copied with ctrl+shift+c
Can also be copied from below the error message

Item Class: Tablet
Rarity: Magic
Collector's Ritual Precursor Tablet of the Dogma
--------
Item Level: 80
--------
10 Maps in Range contain Ritual Altars (implicit)
--------
11% increased Rarity of Items found in your Maps
Rerolling Favours at Ritual Altars in your Maps costs 14% reduced Tribute
--------
Can be used in a completed Tower on your Atlas to influence surrounding Maps. Tablets are consumed once placed into a Tower.

Common Question Checklist

[x] I have checked the pinned issues and existing issues for this problem already
[x] I have read the FAQ
[x] I have read the Common Issues

Yep, haven't gotten to this item yet. Thanks for reporting!


Enchancement : Hover Effect on Cards

The Hover Effect on cards can make the website more user-interactive and visually appealing.
Can you assign this task to me under GSSOC 2024?

can I also work on the same issue  as a part of GSSOC24  ,I would like to give it nice dark theme tailwind css with responsive and neat tailwind css

Hi @devmusiczz , you can start the work for this issue and all the best!

Hello, @ashutoshgithubs
I go through the project and I would like to work on this project
can you please assign this issue to me so that I can add some hover effect on the cards to make it more beautiful.


Graph API improvements

This PR introduces new functions to the protobom graph API. It adds a few new capabilities to make life easier when working with SBOMs and new functionality.
New features:

nodelist.NodeDescendants is a new function that traverses the graph starting from a node and returns all linked nodes up to a set distance.
nodelist.AddRootNode is the equivalent of nodelist.AddNode but it also registers the node as a root node.
nodelist.RelateNodeAtId inserts a node into the graph by relating it to a specified node.

Quality of life improvements:

node.AddHash is a convenience function to add hashes to nodes.
We now have constructors for the protobom elements (eg n := NewNode() )

I've added tests for all new functions and simplified the readme with the new functions.
Signed-off-by: Adolfo Garcia Veytia (puerco<EMAIL_ADDRESS>

Thanks for the thorough review @veramine and @jspeed-meyers , it should be ready to go now!


Added IRC nick colors

This greatly increases the readability in IRC channels (at least when using irssi).

I'll fix the checks and make a new one.


fluid family not in object help launcher

this would be nice no?

Works for me out of the box:

this looks great. I wish it was the case on mine.

Need more info, which commit?

beta7

The obj-qlookup.json is missing from the release which is why it doesn't appear.

I'm relieved my imagination doesn't go as far as issue filling :)

The fix in #301 should attend to this :)


🎉🎉 Who is using immer? 🎉🎉

With roughly two million downloads per months, there must be a lot of big and small companies using this package. Please share your success stories!

Which company?
Logo would be cool! (it implies that it is o.k. to publicly share that your company is using this project, otherwise leave it out)
What kind of project? How large? (code base size or team size)
If your project is open source or public, please share a link!

If you would consider providing long term support through donations that would be great! Open collective or Paypal (please mention immer in the comments both cases)

There's a few projects at Google using immer in Angular + ngrx apps (I'm working on one of them). I can't remember which ones are publicly launched, but if you're curious I can look into it some more.

HENNGE K.K. https://hennge.com/

Admin UI for our largest product
not yet released

AWS is using immer in services.

I am using immer for redux. That's cool. Thank you very much.
https://github.com/fwh1990/redux-model-ts

Our product is in development and when we release it then I will send details. By the way I like it.

At Quizlet we've adopted Immer as a replacement for ImmutableJS. Main reasons were that we kept running up against static typing problems and that it seems to be unmaintained.

https://logodix.com/logo/717774.png
400K+ LoC in TypeScript frontend

At Staffmatch we’re working on a new redesigned app where immerjs is heavily used both for redux and useState. I have no words to express how awesome it is, how it eases working with any state and optimizations.  Complex table - easy; dropdown, date picker to work smoothly in IE11 -  not a problem. So thank you a lot for making such a beauty!

Staffmatch

Temporary work service; about 10 devs, 3 front.
New app isn't released yet.

At MESHLE we are using immer for the latest version of our app which was completely rewritten in typescript. We had to ditch immutablejs for immer considering how difficult it is to use immutablejs with static types. Thanks alot for the lib :clap:

MESHLE

App for MESHLE IOT device management

At Course Hero we have started to use Immer on new React pages, where it is helping us simplify updates to complex state objects and increase the maintainability of the codebase.

Volvo Group Connected Solutions uses Immer in all our major React+Redux projects, for example volvoconnect.com

https://www.coxautoinc.com/ we are using in our digital retailing apps.

At lusha.co we are using Immer in most of our projects :)

React Native Boilerplate is using immer :)
https://github.com/keremcubuk/react-native-boilerplate

Amazon uses it!

Redux docs now appear to recommend immer ⇒ https://redux.js.org/tutorials/essentials/part-2-app-structure

Appcircle.io uses immerjs

Hello! Thanks for the awesome library!

ImaWakatta - learn Japanese the fun and interactive way

Small team (Myself as the dev and a few content authors). Code wise I would say medium? We moved from Redux to Immer + hooks, which greatly simplified everything.

https://imawakatta.com/ (soft launched, still working out some kinks)

We're using Immer to build Worksphere.co, a workplace management platform for safe offices and flexible teams.
Product：Workplace Management for a Safe Return to Office
Company:  worksphere.co
Screenshot:

at cylus we are using immer to solve complex state updates.

Immer is awesome! Used it to implement an undo system in my free puzzle game (made as a hobby).
Link to game: https://spyr.itch.io/riko

We use it all the time! I love immer. We build software for giant enterprise companies like ADP, paychex, HP, and more. Never have had an issue with immer.
https://conquer.io/

I use it whenever I use React. I always prefer seeing state changes using this great tool instead of the ugly spread objects... ;)
Thanks again for the amazing work!

We are using immer in redux.
https://github.com/factly/mande

I'm using immer in redux, thank u very much.
https://github.com/foca-js/foca

Plap

3) A hub for everything events. Currently just 2 devs haha.
4) https://plap.xyz

At dezbor, we are using immer

Dezbor - learn Japanese the fun and interactive way

No-Code Dashboard and Admin Panel Builder
dezbor.com

At dezbor, we are using immer
1. Dezbor - learn Japanese the fun and interactive way

2.

3. No-Code Dashboard and Admin Panel Builder

4. [dezbor.com](https://dezbor.com/)

Are you guys also working on a fun and interactive Japanese app? :)


Documentation for the MSBuild SignFile task may not clearly state what scenarios it is supported in.

I was looking for a straightforward way to implement code signing for our legacy .NET Framework 4.8 desktop application, and I arrived at the page indicated in the details below.
I was able to run this task on my development machine without any problems, but trying to run it on our Continuous Integration server led me to an error message that matches what was reported on dotnet/msbuild#6788, though I think that I might have arrived at the same error message by a different means than what this user is attempting.
https://github.com/dotnet/msbuild/issues/6788#issuecomment-911867838 suggests that this task's documentation may be incomplete, as the latest official reply seems to imply that this task is only designed to support a narrow set of scenarios which would (I presume) automatically require having an outdated / obsolete version of the Windows SDK installed?
It's not clear to me if there's any truth to that, but it does seem odd that an issue whose repro steps have nothing to do with ClickOnce would nonetheless get tagged as "ClickOnce"...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c09ffd23-115c-368b-c17f-7d3af54f0a67
Version Independent ID: b640eb45-9978-0a9e-f8dc-fd2581e84fb5
Content: SignFile Task - MSBuild
Content Source: docs/msbuild/signfile-task.md
Product: visual-studio-windows
Technology: msbuild
GitHub Login: @ghogen
Microsoft Alias: ghogen

@airbreather -- Joe, thank you for your thoughtful feedback.  If you haven't already, please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@ghogen -- Gordon, please look into this issue.

@airbreather
Updating the article to mention it's current limitations.


ENH: Update Autoscoper

Highlighted Autoscoper changes

Fix trailing comma when saving single volume tracking data so that the file can be loaded by other CVS reader (e.g numpy)

Before: X_data, Y_data, Z_data, YAW_data, PITCH_data, ROLL_data,
After: X_data, Y_data, Z_data, YAW_data, PITCH_data, ROLL_data
See BrownBiomechanics/Autoscoper#130

Documentation updates

Update sources to explicitly reference std namespace.

Add support for 3D kernels (Kernel::block3d and Kernel::grid3d)

Not yet used
It was originally integrated to support the computation of "Distance field" in  BrownBiomechanics/Autoscoper#87 which was closed in favor of BrownBiomechanics/Autoscoper#128

List of Autoscoper changes
$ git shortlog 60b3d6ec0..b29d30f51 --no-merges
Anthony Lombardi (20):
      ENH: Update OpenCL wrapper to support 3D kernels (PR-113)
      DOC: Fix typos in PyAutoscoper docstrings
      DOC: Set up Markdown Sphinx docs
      DOC: Add Documentation for PyAutoscoper
      DOC: Add About Autoscoper section to RTD
      DOC: Add getting started and user interface to RTD
      DOC: Add MATLAB socket control docs to RTD
      DOC: Add dev guide to RTD
      DOC: Update the license info on the home page
      DOC: Add UI description
      DOC: Add instructions for remote GPU access
      DOC: Add tutorials for sample and custom data
      DOC: Add file specifications
      ENH: Add .readthedocs.yaml to install required packages
      ENH: Make content take up 100% of the screen width
      DOC: Add tutorial for filters
      DOC: Update History and Getting Started
      DOC: Update README for PyAutoscoper to point to RTD
      DOC: Add tutorial descriptions and reference on getting started
      BUG: Fix trailing comma when saving single volume tracking data

Jean-Christophe Fillion-Robin (24):
      STYLE: Update "line-length" black settings from 88 to 120
      DOC: Add top-level license based on source file headers
      DOC: Update README adding a "License" section along with historical notes
      STYLE: Update black version specified in pre-commit config
      COMP: Update pre-commit config to ensure black always uses expected settings
      COMP: Explicitly reference "std" namespace
      DOC: Consistently add an empty line between header and content
      DOC: Strip trailing white spaces
      DOC: Add dedicated "About" top-level section
      DOC: Move SampleData description in "Getting Started"
      DOC: Move "Advanced Topics" after "User Interface" and "Tutorials"
      DOC: Fix headers in CONTRIBUTING document
      DOC: Fix cross-references warnings
      DOC: Update configuration removing invalid options
      DOC: Fix formatting of "Example" in "Camera Calibration File Format"
      DOC: Update "Getting Started" to fix reference to sample data
      ENH: Update NewTrialDialog UI file to use "OK" instead of "Ok"
      DOC: Fix miscellaneous typos
      DOC: Update PyAutoscoper document to use back-ticks around method names
      DOC: Tweak formatting of "Loading and Tracking Data" tutorial
      DOC: Use "AutoscoperM" instead of SAM in "Loading Custom Data" tutorial
      DOC: Ensure "Tutorials" are complete by relying on implicit link text
      STYLE: Remove obsolete comments from autoscoper/CMakeLists.txt
      COMP: Set autoscoper_set_env.sh permission flags only if configuring script

Locally checked that compilation on Linux and Windows work as expected :heavy_check_mark:


Add AMD Docker Compose config file

Pull Request Checklist

[x] Description: This pull request adds an AMD Docker Compose file to the project. The file is configured to run an AMD-based Docker container, which should improve performance on systems with AMD processors.

[x] Changelog:
Added

AMD Docker Compose file for improved performance on AMD systems

Changed

Updated documentation to include instructions for using the AMD Docker Compose file

[x] Documentation: Yes, I have updated the project's README file to include instructions for using the AMD Docker Compose file. I've also added a note about the potential performance benefits of using this file on AMD systems.

[x] Dependencies: No, there are no new dependencies. The Docker image used in the AMD Docker Compose file is the same as the one used in the existing Docker Compose file.

Please review the changes and let me know if you have any questions or suggestions. Thank you!

Huge credit to @slash-proc and Tristan from Discord in their help in getting this figured out, it was a journey for the ages 😬

One more note: I am fairly certain that this will probably only work on Linux Docker hosts. Our very patient test subject was running Ubuntu, and I do not have an AMD GPU of my own to test this on Windows with unfortunately.

Would love that actually, we probably shouldn't just YOLO merge this yet.

hmm... I don't see any harm in giving people the option/example for amdgpu's. I think this is a stable basis going forward.
Also I think it would be helpful to get input from other amd gpu owners, no? I'm very curious what Windows + WSL AMD owners would report. Leaving a disclaimer comment in the docker-compose.amdgpu.yaml regarding this only being tested in Linux, etc. would be fitting of course.

LGTM, Thanks!

I tried the code you gave in CMD and Docker Terminal but it doesn't accept it. Where should I enter this code? It takes 1 minute to respond even though I have 8GB VRAM. My gpu is RX 6600.


Create AppleStrategy

I have been working on "Sign In with Apple" for the last few days and thought why not implement it with remix-auth.
At first I thought it should be really easy with the already existing OAuth2Strategy but of course Apple does some things different from the "classic" OAuth flow. For now I tried to not touch the existing Strategy and worked around the limitations.
The main Problem I faced was, that Apple provides the callback information in the form_body of a POST request. To solve that I created a redirect which moved the information from the form_body into the QueryParams and then use that with the already existing OAuth2Strategy, this also solved some errors for me where a Cookie Session could not be loaded when an Action (POST) was called from Apple. In the Docs Section, I documented how I use it right now inside the auth.apple.callback.tsx File.
Another limitation is the User Information. In general, you can only request email and name via the scope parameter, but you get the information only once via the callback. I could not find an easy solution to get the JSON from the callback request and pass it to the profile. We could get it the same way the scope and code is retrieved, but find a way to somehow not make it particular special to the AppleStrategy to provide some information from the callback call to the profile.
I hope this all makes somewhat of sense. For me the Strategy works great by just using the email from the id_token but could be of course improved and made more straight forward. That's why I will leave the PR on Draft for now and would be very interested in what you think about it.
Greetings Lennart 👋
#10

I just updated the PR and removed the workaround with the action which redirects to a loader for this to work I had to change to use query on the response_mode. However this does not allow scopes so it is not possible to get the information like email and name. Otherwise everything works as expected.
The response_mode: "form_post" is problematic because it works as POST and this does not allow to access the cookie securely to compare the code using a CookieSession.

@lgastler hey! thanks for taking the time to work on this strategy.
Since v3 strategies are not going to live inside this packages anymore (old strategies are still in the repo so people can copy them) and instead they will be published in independent packages like remix-auth-oauth2 or remix-auth-github.
I suggest you to use the template repository http://github.com/sergiodxa/remix-auth-strategy-template to create a remix-auth-apple repo, copy your code there (install remix-auth-oauth2) and publish it to npm by yourself.
Again, thanks for the work here and I hope to see a new remix-auth-apple package soon!


Intercom Fork

This branch contains:

https://github.com/ebryn/ember-model/pull/454 (allow ember data and ember model to coexist)
https://github.com/ebryn/ember-model/pull/456 (replace deprecated contains with includes)
https://github.com/ebryn/ember-model/pull/460 (handle out of bounds access gracefully)

these changes have landed in https://github.com/ebryn/ember-model/releases/tag/v2.18.0


Wanted star

Hi,
when i was on duty, just tried to put someone in under arrest, NPC cops around the police station, shoot at me (with at least 1 wanted star and probably did something not good).
Thanks

Hi,
I will look into this while adding the wanted system feature, don't close the issue.

Perfect :)
Thanks for your work !

The last update of cfg/groups.lua solve the issue (use setCop for the police group).

Thanks but now you can still have a wanted level if you are a cop. Maybe you can add a script like that for cops :
Citizen.CreateThread(function()
while true do
Citizen.Wait(0)
if GetPlayerWantedLevel(PlayerId()) ~= 0 then
SetPlayerWantedLevel(PlayerId(), 0, false)
SetPlayerWantedLevelNow(PlayerId(), false)
end
end
end)


Lower requirements on http-conduit dependency

In my attempt to get haste-compiler to work with lts-6.31 I stumbled upon the http-conduit >=2.2 dependency of shellmate-extras. lts-6.31 comes with http-conduit-2.1.11.
shellmate-extras builds fine with that version, but I see you upped the dependency not too long ago in 9153cf16ca116daae802e1f88bfc50f14a615d10 - Is the a specific reason for requiring >=2.2?

I don't think there was any particular reason. Most likely I just intended to relax the upper bound, but accidentally tightened the lower bound as well.


ipaddr_to_asc() added to 3.0.0 incorrectly formats IPv6 addresses

Function ipaddr_to_asc in crypto/x509/v3_utl.c converts a 4 or 16 octet value to an IPv4 or IPv6 address text represenation. What was noticed while testing Perl Net::SSLeay with OpenSSL 3.0.0 alpha5 and later is that ipaddr_to_asc text representation is incorrect with IPv6. The latest OpenSSL 1.1.1 and earlier work as expected, as shown below. The problem seems to have appeared during 3.0.0 development.
The example below is from an up-to-date macOS Catalina and Apple Xcode compilers.  I'd say this is not related to any particular platform.
% cc -v
Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
% uname -a
Darwin imac-retina.local 19.6.0 Darwin Kernel Version 19.6.0: Sun Jul  5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64 x86_64

This shows output with OpenSSL 1.1.1g that was compiled today:
% openssl version
OpenSSL 1.1.1g  21 Apr 2020
% openssl x509 -in t/data/testcert_extended.crt.pem -noout -text |grep -A1 'X509v3 Subject Alternative Name:'
            X509v3 Subject Alternative Name:
<EMAIL_ADDRESS>Registered ID:<IP_ADDRESS>.5, URI:http://name.dom.com/whatever, DNS:dns.name.com, IP Address:<IP_ADDRESS>, othername:<unsupported>, IP Address:2A00:1450:4001:C01:0:0:0:93

This shows output with OpenSSL master checked out and compiled today:
% openssl version
OpenSSL 3.0.0-alpha7-dev  (Library: OpenSSL 3.0.0-alpha7-dev )
% openssl x509 -in t/data/testcert_extended.crt.pem -noout -text |grep -A1 'X509v3 Subject Alternative Name:'
            X509v3 Subject Alternative Name:
<EMAIL_ADDRESS>Registered ID:<IP_ADDRESS>.5, URI:http://name.dom.com/whatever, DNS:dns.name.com, IP Address:<IP_ADDRESS>, othername: <IP_ADDRESS>.5::othername, IP Address:2A0145400C010:

The test certificate from Perl Net::SSLeay is below:
-----BEGIN CERTIFICATE-----
MIIHGTCCBoKgAwIBAgIDEjRYMA0GCSqGSIb3DQEBBQUAMCsxCzAJBgNVBAYTAlVT
MQ4wDAYDVQQKEwVEZW1vMTEMMAoGA1UEAxMDQ0ExMB4XDTEyMDIwMTAwMDAwMFoX
DTM1MDMzMTIzNTk1OVowggHVMQswCQYDVQQGEwJVUzEOMAwGA1UECBMFU3RhdGUx
DTALBgNVBAcTBENpdHkxEDAOBgNVBAoTB0NvbXBhbnkxDTALBgNVBAsTBFVuaXQx
HTAbBgNVBAMTFGV4dGVuZGVkLnNlcnZlci5jZXJ0MSwwKgYJKoZIhvcNAQkBFh1h
bnllbWFpbEBleHRlbmRlZC5zZXJ2ZXIuY2VydDEVMBMGA1UECxMMQW5vdGhlciBV
bml0MRkwFwYDVQQLExBZZXQgQW5vdGhlciBVbml0MRUwEwYDVQQEEwxTdXJuYW1l
IHRleHQxEzARBgNVBAwTClRpdGxlIHRleHQxGTAXBgNVBA0TEERlc2NyaXB0aW9u
IHRleHQxEjAQBgNVBCkTCU5hbWUgdGV4dDEXMBUGA1UEKhMOR2l2ZW5OYW1lIHRl
eHQxFjAUBgNVBCsTDUluaXRpYWxzIHRleHQxFTATBgNVBC4TDGRuLnF1YWxpZmll
cjENMAsGA1UESBMEUm9sZTEdMBsGA1UELAwUZ2VuZXJhdGlvbl9xdWFsaWZpZXIx
FzAVBgNVBEETDlBzZXVkb255bSB0ZXh0MR0wGwYDVQQtDBR4NTAwX3VuaXFfaWRl
bnRpZmllcjCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA2aWvhnencjZ7M/Ff
h2FyRejq29hF/XOSmJmmZgwirs9dnOq3kXrnx0y9XMBKPj1kdYW5omesX6pMIAyl
MNl5fADUtBQkxCneXnIcKAgvgxaqz1VqnTu3UBN4H/g82KOEkMw2mXEaY0TmvG3e
DgU9zvd/8T0ZUlTP6QmGA2OBkqcCAwEAAaOCA50wggOZMAwGA1UdEwEB/wQCMAAw
HQYDVR0OBBYEFKJ+nSndaOLx9HyMFO6u1yJFYi3/MFUGA1UdIwROMEyAFMgc2pIK
qUgIOnZ2FTgE8TTZFdAgoS+kLTArMQswCQYDVQQGEwJVUzEOMAwGA1UEChMFRGVt
bzExDDAKBgNVBAMTA0NBMYIDEjRWMAwGA1UdDwQFAwMH4oAwXgYDVR0lAQH/BFQw
UgYIKwYBBQUHAwEGCCsGAQUFBwMDBgorBgEEAYI3CgMBBggrBgEFBQcDBQYIKwYB
BQUHAwYGCCsGAQUFBwMHBggrBgEFBQcDDQYIKwYBBQUHAw4weAYDVR0RBHEwb4EO
YWx0MUBlbWFpbC5jb22IBCoDBAWGHGh0dHA6Ly9uYW1lLmRvbS5jb20vd2hhdGV2
ZXKCDGRucy5uYW1lLmNvbYcECgsMDaATBgQqAwQFoAsMCW90aGVybmFtZYcQKgAU
UEABDAEAAAAAAAAAkzBWBgNVHRIETzBNgRhpc3N1ZXIuYWx0bmFtZUBlbWFpbC5j
b22IAyoAAIYVaHR0cDovL2lzc3Vlci5jb20veHl6gg9pc3N1ZXIuYWx0Lm5hbWWH
BAECAwQwQwYDVR0fBDwwOjAboBmgF4YVaHR0cDovL3NlcnYxLmNvbS9jcmwxMBug
GaAXhhVodHRwOi8vc2VydjEuY29tL2NybDIwMAYIKwYBBQUHAQEEJDAiMCAGCCsG
AQUFBzABhhRodHRwOi8vb2NzcC93aGF0ZXZlcjARBglghkgBhvhCAQEEBAMCAFEw
KwYJYIZIAYb4QgECBB4WHGh0dHA6Ly9uZXRzY2FwZS5iYXNlLnVybC94enkwMQYJ
YIZIAYb4QgEDBCQWImh0dHA6Ly9uZXRzY2FwZS5yZXZvY2F0aW9uLnVybC94enkw
NAYJYIZIAYb4QgEEBCcWJWh0dHA6Ly9uZXRzY2FwZS5jYS5yZXZvY2F0aW9uLnVy
bC94enkwOgYJYIZIAYb4QgEHBC0WK2h0dHA6Ly9uZXRzY2FwZS5jZXJ0aWZpY2F0
ZS5yZW5ld2FsLnVybC94enkwMAYJYIZIAYb4QgEIBCMWIWh0dHA6Ly9uZXRzY2Fw
ZS5jYS5wb2xpY3kudXJsL3h6eTAeBglghkgBhvhCAQwEERYPc3NsLnNlcnZlci5u
YW1lMCUGCWCGSAGG+EIBDQQYFhZuZXRzY2FwZSBjb21tZW50IGZpZWxkMA0GCSqG
SIb3DQEBBQUAA4GBAKfdXUWwBvGjchb0VxVKspuvbpUnADOKcro1kdviRQRek46l
6Rjvq7vUZoUyeDOkFg08kxQQgNFOdnYLtuL6BkhGD7lVArM4s9anyp30umHgWEpR
0W6H0lfKI7nkc49sM7NJX0Srg4b6FVHhrNKhXC3ZPCOMIUqfW/Qi3ENJfVYM
-----END CERTIFICATE-----

Output with current master shows that othername value is :othername. It looks odd, but I think it's correct. The only problem I see is with IPv6 address text format.
I did not attempt a fix yet because I started thinking there could be something that, for example, converts a 16 octet value to something like ASN1_OCTET_STRING which could then be converted to IPv6 address text representation.

out += 3 just looks wrong here:
https://github.com/openssl/openssl/blob/2a33470b4f23bcf1cd66bbf645c855142efa0ed9/crypto/x509/v3_utl.c#L988-L994
We're writing potentially 5 characters of output, but incrementing 3 each time!? Also the output width is variable. Possible fixes are to use a fixed width format specifier, or to check the return value of BIO_snprintf to check what was actually written.
@DDvO

That loop was...  something.  I've a tentative fix in #12696, please try it out.


Fix icon alignment

Now it as an 1:1 aspect to I guess it will display correctly on bitrise.io

Thanks for the fix ;)


chore(task): add specific pnpm version for codespeed task

#3010  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on  Graphite


Update J3 February meeting update

@certik When you have some time, can you please post your J3 February meeting update in this file:
https://github.com/fortran-lang/fortran-lang.github.io/blob/master/_posts/2020-02-25-J3-february-meeting.md

Yes! Thank you. I'll do it very soon.

This has been fixed in #29, #30 and #42. The result is visible at:
https://fortran-lang.org/newsletter/2020/02/28/J3-february-meeting/


Can't highlight result

es version 5.1
index template
{
  "template_all": {
    "order": 0,
    "template": "*",
    "settings": {
      "index": {
        "analysis": {
          "filter": {
            "pinyin_filter_all": {
              "keep_joined_full_pinyin": "true",
              "keep_first_letter ": "false",
              "type": "pinyin",
              "keep_full_pinyin": "false"
            }
          },
          "analyzer": {
            "raw_lower": {
              "filter": "lowercase",
              "tokenizer": "keyword"
            },
            "my_ngram_analyzer_16": {
              "filter": "lowercase",
              "tokenizer": "my_ngram_tokenizer_16"
            },
            "ngram16_pinyin_all": {
              "filter": "pinyin_filter_all",
              "tokenizer": "my_ngram_tokenizer_16"
            }
          },
          "tokenizer": {
            "my_ngram_tokenizer_16": {
              "type": "ngram",
              "min_gram": "1",
              "max_gram": "16"
            },
            "my_pinyin": {
              "keep_joined_full_pinyin": "true",
              "type": "pinyin",
              "limit_first_letter_length": "16",
              "keep_full_pinyin": "false"
            }
          }
        },
        "number_of_shards": "1",
        "number_of_replicas": "0"
      }
    },
    "mappings": {},
    "aliases": {}
  }
}
 },
            "my_pinyin": {
              "keep_joined_full_pinyin": "true",
              "type": "pinyin",
              "limit_first_letter_length": "16",
              "keep_full_pinyin": "false"
            }
          }
        },
        "number_of_shards": "1",
        "number_of_replicas": "0"
      }
    },
    "mappings": {},
    "aliases": {}
  }
}

when use analyzer ngram16_pinyin_all for value '123测试数据长度可能比较长1231546',some term can't be highlighted.Such as a search for a term ‘jiao’.But It works for the some word in the front, like 'ce'.

the ngram16_pinyin_all is not well designed, why not just use pinyin analyzer, is there any reason to use ngram, you can check out the analyze result, full with duplicate terms and nonsense terms, the highlight issue is also with the analyzer, the query input jiao will generate lot's terms.

Yes，that's the question.I know it would generate lot's of terms, but I have some dynamic field. when I search any term of the field, I wanna get the correct result. If just use pinyin analyzer, when I put 'jiaochang',  it doesn't work as expect.

what's your expectation？
here is my test result， looks good to me：
DELETE index333

PUT index333
{
    "mappings": {
      "type":{
        "properties": {
          "name":{
            "type": "text"
            , "analyzer": "pinyin"
          }
        }
      }
    }
}

POST index333/type/1
{
  "name":"教程123测试数据教程长度可能比较长1231546"
}

GET index333/_search
{
  "query": {"match": {
    "name": "jiaocheng"
  }},"highlight": {
    "fields": {
      "name":{
        "fragment_size": 20
      }
    }
  }
}

{
  "took": 13,
  "timed_out": false,
  "_shards": {
    "total": 1,
    "successful": 1,
    "failed": 0
  },
  "hits": {
    "total": 1,
    "max_score": 0.81542313,
    "hits": [
      {
        "_index": "index333",
        "_type": "type",
        "_id": "1",
        "_score": 0.81542313,
        "_source": {
          "name": "教程123测试数据教程长度可能比较长1231546"
        },
        "highlight": {
          "name": [
            "教程123测试数据教程长度可能比较长1231546"
          ]
        }
      }
    ]
  }
}

ok,I'll have a try :)


Fix server-side crash (Closes #6)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your PR, when I have time, I will look into it :)

Thanks for your PR. It is merged and will be release in mod version <IP_ADDRESS>.


Response Issues on site

header part is okay but every other part having the issue

What if we use a container instead of a container-fluid? The prototype has a 200px padding from the both ends of the site except for the cover.


Prevent null-deref to fix seg fault in cbvprintf on strlen(NULL)

Fix for https://github.com/zephyrproject-rtos/zephyr/issues/76509

@devanl please read the guidelines on how to format the git commits.
Also squash your commits into a single commit.

Also just force push on this PR, no need to open a new PR.

Is this waiting for anything besides review that I can support here?

Is this waiting for anything besides review that I can support here?

In my short experience I've found you usually need to get CI green before people start reviewing. I think it's because folks with review access usually have to optimize their time and so they probably filter PRs by those that have green CI
In your case it seems you're only failing two compliance checks:
"1: UC5 Commit title exceeds max length (83>75)"
"3: UC4 Commit message body line exceeds max length (93>75)"

Is this waiting for anything besides review that I can support here?

As suggested by @pdgendt , please read the contribution guidelines as they contain the answers regarding how to get the compliance check to stop complaining :) thanks!

bump @nordic-krch  can we get the 2nd approval? :D

not sure what I did to close this...

attempt to reopen

Something got messed up as commit show >5000 modified files.


bug : it seems the system prompt sometimes gets reset?

Hi,
I notice that when I go to the settings and click on the system prompt I sometimes see it empty. See, I have 2 ways of opening the settings: either by clicking on the icon of the app then on the cog, or by using the assistant shortcut then on the cog. A weird combination of forcing the app to quit then opening it one way or another seems to bring back the system prompt.
This is a problem to me because I sometimes suspect that the system prompt is not taken into account in my chats.

I confirm that the bug is a daily occurence. Also, and curiously, the setting "GPT-4 vs GPT3.5" is not affected, meaning I never saw the toggle switch on GPT3.5 since I set it to GPT-4 at the beginning. On the other hand the choice between the different chat UI (bubble and not bubble) seems to be reset to like the system prompt.
Actually apart from the system prompt and the UI type I don't know of other settings affected. Though I don't use activation prompt.
I also never had the TTS feature work but thought it was related to the fact that I don't have gapps.
Cheers

If you are trying to change the global settings it will not affect chats. You will se that settings "got reset". You need to open a chat and then click settings icon. Each chat has their own settings.

TTS will not work on your device as you don't have GoogleSpeechServices installed (a part of GAPPS).

The global settings is a template for new chats. It doesn't affect the current chats.

Thank you for the quick reply. There's a misunderstanding. I'm not talking about changing old chats, I'm talking about the fact that when I go to the settings I have a 75% chances of seing some settings reset to something other that I specified. Notably clicking on the system prompt shows an empty text box.
As explained in the first message, a combination of force quit and openning either via the assistant gesture or via clicking on the icon makes the system prompt finally "not empty".
I told the system prompt to output in markdown, this way I can notice if it does not apply as I can't see the system prompt without exiting the chat. So far it seems that the system prompt is not actually reset but simply that the UI can't find it so shows an empty text box.


Better reconnection for nonvnc on challenge restart

We generate a new VNC password when we restart a challenge, and as a result, novnc can't automatically reconnect across challenge starts. This annoyance will get more noticeable as we streamline the UX (e.g., https://github.com/pwncollege/dojo/pull/473). We should probably patch novnc to refresh the page when a reconnection fails (which will also fix the DOS issue).

https://github.com/pwncollege/dojo/blob/89dbadaea108ef4da75006067f8cfde5e7acbbcb/workspace/services/desktop.nix#L7 should have already fixed DOS.
I think this actually makes sense as a "noVNC patch". Instead what we should do is put javascript on the top level page that decides where the iframe will point at. Somehow, we need the ability for that javascript to be informed that it should change the iframe location.
For example:

I receive an event that a new workspace has started and initialized; this JS knows the user is interested in the Desktop (because we are on /workspace/desktop)
Start a sweet spinning "loading" animation
Tell the backend to start the desktop service
When that has finished, kill the "loading" animation and set the iframe location

We should do the same thing for all top-level /workspace/* routes.

I would lean towards SSE as it has way less overhead: it's a normal HTTP request that stays open and streams a text-based protocol. Websocket requires an upgrade handshake between the client and server and every message has to be XORed.
I took a look at the CTFd notification logic. A couple important files are the route the clients connect to and the events_manager classes. Here's my understanding of how it works. Redis has a built in pub/sub mechanism. The event manager's job is to spawn a gevent task (basically a thread) to subscribe to redis. When an HTTP request comes through to the SSE endpoint, it returns a generator which is how flask streams stuff. The generator hooks into the event manager, encodes the events in the SSE format, and forwards them to the client.
It seems like this would lock up a flask worker, but I'd have to test to be sure. Maybe the only solution is to add more flask workers.

I think I also lean towards SSE, especially since we don't have a need for bidirectional communication, and probably even more importantly, CTFd already has logic for this!
I see a gevent.spawn(_listen) here:
https://github.com/CTFd/CTFd/blob/8ef0cdd916eab4226956d9d2d70adeccdc89f441/CTFd/utils/events/__init__.py#L100
My surface level understanding is that CTFd is using gevent by default, and we continue to use this in the DOJO, a "lightweight thread", as you mention. We specify 8 workers, but each worker actually also spins up real (linux) threads:
root@ctfd:/opt/CTFd# ps aux | grep gunicorn | grep -v grep | wc -l
9
root@ctfd:/opt/CTFd# ps aux -T | grep gunicorn | grep -v grep | wc -l
57

I think that 9th process is a a supervisor process that manages the 8 workers, maybe?
The number of threads fluctuates a bit.
My best guess would be that these gevent threads are backed by real threads to some extent; and that regardless by using spawn, we aren't completely taking over the worker's ability to process more requests, but this should probably be researched/tested to confirm.

listen is only called once in init_events. This single lightweight thread that is spawned is responsible for forwarding messages from redis to the entries of the clients dict. The clients dict entries are populated by the generator returned by the request handler.
The question is where flask iterates the generator from.

I think I see what you're saying.
I think it should be iterating here in the /events endpoint:
https://github.com/CTFd/CTFd/blob/8ef0cdd916eab4226956d9d2d70adeccdc89f441/CTFd/events/__init__.py#L16
Which pulls from:
https://github.com/CTFd/CTFd/blob/8ef0cdd916eab4226956d9d2d70adeccdc89f441/CTFd/utils/events/__init__.py#L111-L112
I think gevent should be taking care of making sure the worker process is context switching when it gets blocked on that .get().
I can see that gevent is willing to monkey patch SimpleQueues (https://www.gevent.org/api/gevent.monkey.html#gevent.monkey.patch_queue), but this is a regular Queue. Not sure how it allows that to function, but I can't imagine something so core isn't supported, it must be context switching somehow (maybe simply with the assistance of regular threads).

Just throwing it out there, but I think this idea will also have nice implications for #426, we can get some sweet interfacing if we can cleanly stream solves/awards/etc.

we could also use jquery:
working:
$("iframe").contents().find("#noVNC_status").attr("class")
-> "noVNC_status_normal"
vs
not working:
$("iframe").contents().find("#noVNC_status").attr("class")
-> "noVNC_status_error noVNC_open"
we could check every 2 seconds on the client if the status is "noVNC_status_error noVNC_open" and if so trigger a reload of the page or get the new iframe src from a specific endpoint.