Node update

Pull Request Test Coverage Report for Build 871500765

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 17.647%

Totals

Change from base Build 871166607:
0.0%

Covered Lines:
9

Relevant Lines:
41

💛  - Coveralls


feat: RabbitMQ 3.10.9 and 3.11.1

https://github.com/rabbitmq/rabbitmq-server/releases/tag/v3.10.9
https://github.com/rabbitmq/rabbitmq-server/releases/tag/v3.11.1

Thanks for the update, our automation broke over the weekend so this was missed.


[Idea] QR for unregistered guys

Should help with workflow, mentioned in #44.
If one came to the event without registration we cannot account him, so Volodymyr usually passed that horrible paper-based solution.
The point is to create a QR with registration link  and print it. This may require creation of a special unlimited Invite entity.

@gora050 plz consider implementing this


Added base Rating System

Added the base rating system with stars. Note that this is not yet hooked to a data source (server), so the shown ratings are random. We should hook to a data source asap!

@tuckerbuchy @DennyScott awesome to see more work on this project.
Can you guys do this review work in a separate branch from master though? If we need to fix bugs on the app already deployed we won't be able to since this new feature is right on master.
Does that sound good? If so reply here and I'll move your commits into a separate branch and then revert master.

hey @lkysow , yeah that makes sense. if you dont mind doing that that would be sweet. thanks

Okay, master reverted. Your changes are on https://github.com/PeaceGeeksSociety/services-advisor/tree/review-feature


Fix diagnoseInvalidResource

This changes diagnoseInvalidResource to work off the declared resources instead of the ones we found rules for. Also amended some of the tests with a check for a count of diagnostics since they could pass with zero diagnostics being emitted.

@swift-ci please smoke test

Failure looks unrelated:

/Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/Tests/WorkspaceTests/WorkspaceTests.swift:4659: error: -[WorkspaceTests.WorkspaceTests testArtifactDownloadWithPreviousState] : XCTAssertEqual failed: ("[AbsolutePath:"/tmp/ws/.build/artifacts/A", AbsolutePath:"/tmp/ws/.build/artifacts/A"]") is not equal to ("[AbsolutePath:"/tmp/ws/.build/artifacts/A", AbsolutePath:"/tmp/ws/.build/artifacts/A", AbsolutePath:"/tmp/ws/.build/artifacts/B"]")

@swift-ci please smoke test macOS


[Issue] CVE-2023-23397.ps1 The e-mail address is formed incorrectly

Describe the issue
Tried to run the CVE powershell with the provided commands and instead got an error. Not sure why; "Get-Mailbox" does work fine so it doesn't seem like a permissions issue?
Expected behavior
A clear and concise description of what the issue is, including the script name.
Script Output
Get-Mailbox | .\CVE-2023-23397.ps1 -Environment Onprem

cmdlet CVE-2023-23397.ps1 at command pipeline position 2
Supply values for the following parameters:
Credential
CVE-2023-23397 script version <IP_ADDRESS>5
Trying to find Microsoft.Exchange.WebServices.dll in the script folder
Microsoft.Exchange.WebServices.dll wasn't found - attempting to download it from the internet
Unable to make Autodiscover call to fetch EWS endpoint details. Please make sure you have enter valid credentials. Inner Exception

Exception calling "AutodiscoverUrl" with "1" argument(s): "The e-mail address is formed incorrectly."

Additional context
Add any other context about the problem here.

Sidebar/potentially related question; the documentation notes:

You can also create a new Throttling Policy to prevent the user who runs the script from being throttled. Make sure to revert the throttling policy after you’re done running the script.
Please note that this is for Exchange on-premises environments only.
New-ThrottlingPolicy "CVE-2023-23397-Script"
Set-ThrottlingPolicy "CVE-2023-23397-Script" -EWSMaxConcurrency Unlimited -EWSMaxSubscriptions Unlimited -CPAMaxConcurrency Unlimited -EwsCutoffBalance Unlimited -EwsMaxBurst Unlimited -EwsRechargeRate Unlimited
Set-Mailbox -Identity "" -ThrottlingPolicy "CVE-2023-23397-Script"

but what is the command to revert the throttling policy? (Because I don't know how to revert that I didn't run this.)

I am also having this issue - Exchange server 2016 CU23

Same problem here also -> Exchange server 2019 CU11

Same problem here also -> Exchange server 2019 CU11

If you are running on your local Exchange try:
Get-Mailbox | .\CVE-2023-23397.ps1 -Environment Onprem -EWSServerURL https://<IP_ADDRESS>/EWS/Exchange.asmx -IgnoreCertificateMismatch
UPN-Login<EMAIL_ADDRESS>or<EMAIL_ADDRESS>

If you are running on your local Exchange try: Get-Mailbox | .\CVE-2023-23397.ps1 -Environment Onprem -EWSServerURL https://<IP_ADDRESS>/EWS/Exchange.asmx -IgnoreCertificateMismatch UPN-Login<EMAIL_ADDRESS>or<EMAIL_ADDRESS>
I am getting a 401 unauthorized error now when doing this. I did create and add the account to the CVE security group

Same here... EWSEditor using Impersonation is working as expected.

get-mailbox onpremuser | .\CVE-2023-23397.ps1 -Environment Onprem -EWSServerURL "https://mail.****.com/EWS/Exchange.asmx" -Credential $cred
CVE-2023-23397 script version <IP_ADDRESS>5
Trying to find Microsoft.Exchange.WebServices.dll in the script folder
Microsoft.Exchange.WebServices.dll wasn't found - attempting to download it from the internet
Could not open mailbox. Error:

Exception calling "Bind" with "2" argument(s): "The request failed. The remote server returned an error: (401) Unauthorized."

$cred

UserName                                    Password

<EMAIL_ADDRESS>System.Security.SecureString

I have updated to CU 12 on exchange 2019 ..same error

Make sure the user with the credentials you entered has an exchange mailbox + proper Application Impersonation rights!
Find your EWS URL with
Get-WebServicesVirtualDirectory |Select name, url | fl
then navigate to folder with script and
Get-Mailbox | .\CVE-2023-23397.ps1 -Environment Onprem -EWSServerURL https://<IP_ADDRESS>/EWS/Exchange.asmx -IgnoreCertificateMismatch

I had all the issues above. Here is what worked for me (Exchange 2016 Onprem).
Step 1: Create a role for the permissions using the following code
New-RoleGroup -Name "CVE-2023-23397-Script" -Roles "ApplicationImpersonation" -Description "Permission to run the CVE-2023-23397 script"
Step 2: Open EAC, go to permissions/admin roles and add the user you will be running this under as a member to the role above
Step 3: Sign out of the server and back in (THIS WAS NECESSARY in my case)
Step 4: Copy the script to your server and note the directory
Step 5: Open the Exchange Management Shell and "Cd" to the directory in step 4
Step 6: Run the script in the management shell
Get-Mailbox | .\CVE-2023-23397.ps1 -Environment Onprem -EWSServerURL https://<IP_ADDRESS>/EWS/Exchange.asmx -IgnoreCertificateMismatch
Please note you'll need to run it again if you find items that need to cleaned up.
Thank you all for your help above. I help this helps others get across the finish line on running this script.

Exception calling "Bind" with "2" argument(s): "No mailbox with such guid."

@PrayingMoses How did you solve this?

Exception calling "Bind" with "2" argument(s): "No mailbox with such guid."

@PrayingMoses How did you solve this?

@cvocvo  for the Creds that you provide, it must be a Mailbox On Prem with impersonation permissions set.
https://microsoft.github.io/CSS-Exchange/Security/CVE-2023-23397/FAQ/#in-onprem-does-the-credential-parameter-need-to-be-upn-or-domainuser

Exception calling "Bind" with "2" argument(s): "No mailbox with such guid."

@PrayingMoses How did you solve this?

@cvocvo for the Creds that you provide, it must be a Mailbox On Prem with impersonation permissions set.
https://microsoft.github.io/CSS-Exchange/Security/CVE-2023-23397/FAQ/#in-onprem-does-the-credential-parameter-need-to-be-upn-or-domainuser

Just figured it out (just had to admit defeat first 😄), I followed @jsb54321 's instructions; it looks like the part I was missing was related to the authentication format.
I was trying "username" and also "domain\username" but instead I needed to use<EMAIL_ADDRESS>

@qwert4u the cmdlet you provided should work, did you modify the script? We shouldn't even be testing Autodiscover endpoint if you passed in value for EWSServerURL

Hey guys, did anyone here get this error "Unable to connect to EWS endpoint. Please make sure you have enter valid credentials" in exchange 2013?

yes, I'm experiencing this issue currently.

Hey guys, did anyone here get this error "Unable to connect to EWS endpoint. Please make sure you have enter valid credentials" in exchange 2013?

I'm experiencing this issue on Exchange 2019 onPrem with the latest script.
Unable to connect to EWS endpoint. Please make sure you have enter valid credentials. Inner Exception

The request failed. The remote server returned an error: (401) Unauthorized.


Query fail when reading token from file contain newline char

https://github.com/huggingface/hfcc.nvim/blob/214def02936d4f76c82c2db28325ef3fdefb2e4f/lua/hfcc/config.lua#L37
If the token is read from $HF_HOME/token, the config might read also the ned of line character, that will cause the curl query to fail.
A possible solution to the issue:
api_token = string.gsub(f:read("*a"), "[\n\r]", "")

Hi @cifvts, thanks for reporting this bug. Could you submit a PR with the fix?


What should a DICOM-segmentation look like to be shown in multiple layers and colors?

I am using the source code of the lesson 04 (labelmap) example and want two different colored segmentation layers to be shown, but I only get one color to work:

What sould the DICOM file that contains the labelmap look like, so that it looks like this:

Thanks for your help

Hi @nkarall , which kind of data are you using for the "segmentation" layer? DICOM Seg dataset? Nifti/NRRD? Are you Trying to build your own data?
Can you also try to load the "segmentation" data in https://fnndsc.github.io/ami/#viewers_upload and tell us what it looks like?
Thanks!

BTW, to color segmentations you should probably use the LUTSegmentation helper (got to update the examples at some point)


Optional Parameter Locks Script; Crashes Page

I have the following mask:
        $(".rate-amount").inputmask({
            mask: "9{0,9}[.]9{1,2}",
            placeholder: "",
            greedy: false,
            definitions: {
                '.': {
                    validator: ".",
                    cardinality: 1,
                    prevalidator: null,
                    placeholder: ''
                }
            }
        });

The issue I have is a double-edge sword at the moment; where the definitions allow me to have a string "500.00" and so that when I hit backspace or delete on the ".", it only deletes that character instead of the surrounding character in addition to the "." character..  However, when using the definitions to properly handle character deletion, I run across a separate issue, where when I have a string "500.00" if I try to place an additional decimal, it does not overwrite the decimal the same way as without the definition, as such "500..00".  The scenario I most frequently run into this is when replacing the amount applied to value, I would go "500.00" => ".00" => "300.30", where when inputting the decimal, I am simply typing the decimal again and replacing the existing one.
What function do I need to implement for this to not occur?  Is there one?
Thanks for any input in advance.

@Hypnotec ,
I will have a look after my holidays ;-)

@Hypnotec ,
Can you create a jsfiddle with instructions to get to the crash.
Why don't you use the numeric alias?


Update instructions for MacOS

Updated instructions for MacOS (see comments here and here). Brew installs Python 3.8 now, and it seems that everything works fine, and there is no need to install boost-python37 anymore.

Everything works fine (I can get the game to run locally) but I can't train agents since the agents want Tensorflow 1.15.*, and Python 3.8 requires 2.2 or higher. Is there a quick fix for that?


[Progress Tracker] MUI V5 Upgrade

Notes for Reviewers
This PR is meshery/ui MUI v5 upgrade progress tracker
Latest commits continued From: https://github.com/meshery/meshery/pull/6888
Using MuiV5 packages for core and styles

Define central theme (Light/Dark (optional))
[x] Convert makeStyles and withStyles to use import {withStyles} from @mui/styles
[x] Rename @material-ui/core and @material-ui/icons to @mui/material and @mui/icons-material
Remove unused styles
Define and create reusable React components

Common themes that are being moved to themes/app.js for now.
fontSize: defaultTheme.typography.pxToRem(15),
fontWeight: defaultTheme.typography.fontWeightRegular

LazyPatternServiceForm.js
Accordion.js
patternConfigurator.js
Navigator.js
_app.js

getMuiTheme

PerformanceResults.js
PerformanceProfileTable.js
URLUploader.js
NodeDetails.js
MesherySettings.js
Filters.js
DashboardComponent.js

Update Modal as some of the props are deprecated
GenericModal.js

URLUploader.js - done
Dashboard.js
PerformanceCalendar.js
PerformanceProfiles.js
PerformanceResults.js

Signed commits

[x] Yes, I signed my commits.

Looks like some of the changes are leaking into provider-ui.
Is this the intended effect? I planned on a separate PR for provider-ui and is already working on it right now, just haven't submitted the PR yet.

Not thats not intentional. I will have to revert those.

Closing this PR, as we will revisit migrating to MUI v5 in 2024


Would you consider to reformat the repo as an Awesome repo?

Thank you for your valuable contributions to the language model community. I'm curious if you would be interested in transforming this repository into an Awesome repository subsequently.

How would it help the community?

How would it help the community?

Good point. I think such a transformation could serve as a pivotal resource for newcomers who often use awesome plus keywords in their search queries. Adopting the Awesome list format would likely increase visibility and attract more engagement from the community, amplifying the impact of your work. Would you consider this approach to further enhance the repository's utility and reach?

Thanks for clarifying. This repo gets enough visibility and doesn't need more reach. Thus, I'll keep it as it is.


Fix incorrect order of downKeys

I discovered that when using hotkeys('*', {keyup:true, keydown:true}, handler), with the keyup and keydown options set to true, if there are other hotkeys('*', {}, handler2) listeners present, the _downKeys order gets rearranged. This causes an issue when I'm implementing keyboard shortcuts persistence because the order of keycodes retrieved using getPressedKeyCodes after keyup is incorrect.
Here is the reproducible link: https://codesandbox.io/s/eager-pond-cstwrz?file=/src/App.tsx

@YuxuanWeng  Your fix has been reverted because it caused some problems with scope. #434

https://codesandbox.io/s/eager-pond-cstwrz?file=/src/App.tsx
@jaywcjlove 大佬可以看下这个case吗？先按住cmd再按住k，getPressedKeyString的结果会出现k+cmd，而不是cmd+k

我看ctrl之类的快捷键都是正常的，可以在sort的时候把cmd排到前面吗？我看就cmd的code比字母大


persistence: Fix resource leak

File was not being closed upon write failure.
Thanks to coverity.
Signed-off-by: Ederson de Souza<EMAIL_ADDRESS>

:+1:

Merged, tks!


Docs.MS Release Updates for Azure.Messaging.EventHubs.Processor

Update docs metadata and targeting for release of Azure.Messaging.EventHubs.Processor

Docs Build status updates of commit 471376c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/messaging.eventhubs.processor-readme-pre.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


How to use it with multi python projects on Airflow

Hello,
This project is excellent and gives a lot of usefulness and verbosity for airflow pipelines.
My question is probably more airflow related rather than cosmos.
I would like to know how to cosmos when all the project dependencies are self-contained in a docker image?
The architecture where the dags and the tasks share the same runtime python environment isn't scalable. I have a case where I would like another version of python, another use case is when I have old/new dbt version which is not compatible with the airflow requirements. Another use case is when airflow is running dags/tasks from different teams and technical stacks.
For those reasons, I choose to use airflow as a scheduler and pack all the task codes in docker images.
Could you please share your experience on how you use this project in airflow installation where a lot of teams runs a lot of pipelines with diffent stacks?

Hey @gudata! Good question. What we do internally is install dbt into a virtual environment in the Docker image - we've documented how to it in the docs here. However, there's been some talk about running dbt/Cosmos tasks in a similar manner to the Kubernetes Pod Operator, where you build a Docker image specifically for the task. If that's what you're looking for, feel free to add an issue (or open a PR!) and if it gets enough traction we could prioritize it.


Fix build error

Build error upon running npm run build

Sorry misread this should be fine after implementing it


CleanUp custom resource fails to delete bucket due when deleting the stack

Describe the bug
I deployed the cloudformation stack successfully and used the perspective UI.  When attempting to delete the stack it failed to delete the AccessLogsBucket with the following error:
The bucket you tried to delete is not empty. You must delete all versions in the bucket.

I was able to clear out the bucket and retry the deletion which succeeded.
To Reproduce
Steps to reproduce the behavior:

Deploy the stack.
Use Perspective.
Delete the stack.
See error.

Expected behavior
Everything is removed seamlessly when you delete the stack.

Hi, thank you for this this report. I think I know why this issue is happening: the accesslog bucket often has a very large amount of entries in it and we have a custom resource that attempts to clear down the bucket just before deletion. What most likely is happening is that due to S3's eventual consistency model some of the deleted resources don't appear as deleted to CloudFormation when it finally tries to delete the bucket immediately after the custom resource terminates. It probably makes sense to put a sleep or poll the bucket to see that it's empty before terminating.

Ooops, accidently closed the issue.

Experienced the same issue as well and had to manually empty the bucket and all its contents and then redo the delete stack operation. A simple polling suggestion as suggested would be great.

When I inspect the bucket after encountering the error, the bucket is still non empty.
It appears between the moment the bucket is emptied, and the bucket is deleted by CloudFormation, some access logs are created in the bucket.
Timeline
15:20 - AccessLogs Bucket Emptied by CleanupAccessLoggingBucket
15:22 - New files created in AccessLogsBucket
15:25 - Cloudformation attempts to delete AccessLogs bucket. Fails as bucket is non empty
Files Created
2020-11-12 15:22:20        756 discovery-bucket/2020-11-12-15-22-19-C785CAF4DA6199B3
2020-11-12 15:23:04        739 discovery-bucket/2020-11-12-15-23-03-58E0BCA256E77A31
2020-11-12 15:23:13       1496 discovery-bucket/2020-11-12-15-23-12-2A2C50891452526A
2020-11-12 15:23:18        756 discovery-bucket/2020-11-12-15-23-17-A02BCD37FF21F9DC
2020-11-12 15:23:46        739 discovery-bucket/2020-11-12-15-23-45-1659F1D6B1B88AA8
2020-11-12 15:24:22       1494 discovery-bucket/2020-11-12-15-24-21-7A95E0CEF118CA34

This turned out to be an issue with a custom resource writing to a bucket during the deletion process. A fix has been made and will be available in our 1.1.0 release.


merge from arlac77/template-github-action,arlac77/template-kronos-component

package.json

fix(engines): add >=14.10.1 remove >=14.9.0 (engines.node)

Codecov Report

Merging #1377 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1377   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           39        39
  Branches         1         1
=========================================
  Hits            39        39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae4331...e294f45. Read the comment docs.


from robots.txt or sitemap.xml

Hi,
it is possible to configure it to use firts robots.txt to find Sitemap: , then use sitemap.....xml then if no exist then use the normal crawling ?
thanks a lot !

No
On Wed, Feb 15, 2017 at 10:37 AM, leccyril<EMAIL_ADDRESS>wrote:

Hi,
it is possible to configure it to use firts robots.txt to find Sitemap: ,
then use sitemap.....xml then if no exist then use the normal crawling ?
thanks a lot !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yasserg/crawler4j/issues/195, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrbW7uMw3zOqPzF-KTUw3Mto3lJxzVXks5rcrktgaJpZM4MBbrF
.


[Docs]: add back to top button

what's wrong in the documentation?
We need to add back to top button in readme file
Add screenshots
Add screenshots
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This Functionality is not needed you can change or add another things in documentation.


Unable to submit request because the model does not support the stopSequences parameter.

Hello, I have been trying to implement your code from Pattern 3 and am having issues.

db = SQLDatabase.from_uri(SQLALCHEMY_URI)

llm = ChatVertexAI(
    project=PROJECT,
    location=LOCATION,
    # model_name=MODEL_NAME,
    model_name="codechat-bison", # Using "codechat-bison@latest" like in the source code fails
    temperature=0.0,
    max_output_tokens=256
)

toolkit = SQLDatabaseToolkit(db=db, llm=llm)

agent_executor = create_sql_agent(
    llm=llm,
    toolkit=toolkit,
    top_k=1000,  # max number of retrieved rows
    verbose=True
)

question = "What is the average mortgage rate in the US?"

# answer = agent_executor.run(question)
answer = agent_executor.invoke({"input": question})

print(f"Answer: {answer}")

Full Traceback:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/google/api_core/grpc_helpers.py", line 162, in error_remapped_callable
    return _StreamingResponseIterator(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/google/api_core/grpc_helpers.py", line 88, in __init__
    self._stored_first_result = next(self._wrapped)
                                ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/grpc/_channel.py", line 541, in __next__
    return self._next()
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/grpc/_channel.py", line 967, in _next
    raise self
grpc._channel._MultiThreadedRendezvous: <_MultiThreadedRendezvous of RPC that terminated with:
        status = StatusCode.INVALID_ARGUMENT
        details = "Unable to submit request because the model does not support the stopSequences parameter. Remove it and try again. Learn more: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/overview"
        debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:443 {grpc_message:"Unable to submit request because the model does not support the stopSequences parameter. Remove it and try again. Learn more: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/overview", grpc_status:3, created_time:"2024-04-17T20:45:15.513845091+00:00"}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/code/src/llm/BigQueryAgent.py", line 76, in <module>
    answer = agent_executor.invoke({"input": question})
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/chains/base.py", line 163, in invoke
    raise e
  File "/usr/local/lib/python3.11/site-packages/langchain/chains/base.py", line 153, in invoke
    self._call(inputs, run_manager=run_manager)
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 1432, in _call
    next_step_output = self._take_next_step(
                       ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 1138, in _take_next_step
    [
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 1138, in <listcomp>
    [
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 1166, in _iter_next_step
    output = self.agent.plan(
             ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 397, in plan
    for chunk in self.runnable.stream(inputs, config={"callbacks": callbacks}):
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 2875, in stream
    yield from self.transform(iter([input]), config, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 2862, in transform
    yield from self._transform_stream_with_config(
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 1880, in _transform_stream_with_config
    chunk: Output = context.run(next, iterator)  # type: ignore
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 2826, in _transform
    for output in final_pipeline:
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 1283, in transform
    for chunk in input:
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 4722, in transform
    yield from self.bound.transform(
  File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/base.py", line 1300, in transform
    yield from self.stream(final, config, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 249, in stream
    raise e
  File "/usr/local/lib/python3.11/site-packages/langchain_core/language_models/chat_models.py", line 229, in stream
    for chunk in self._stream(messages, stop=stop, **kwargs):
  File "/usr/local/lib/python3.11/site-packages/langchain_community/chat_models/vertexai.py", line 378, in _stream
    for response in responses:
  File "/usr/local/lib/python3.11/site-packages/vertexai/language_models/_language_models.py", line 1732, in send_message_streaming
    for prediction_dict in _streaming_prediction.predict_stream_of_dicts_from_single_dict(
  File "/usr/local/lib/python3.11/site-packages/google/cloud/aiplatform/_streaming_prediction.py", line 156, in predict_stream_of_dicts_from_single_dict
    for dict_list in predict_stream_of_dict_lists_from_single_dict_list(
  File "/usr/local/lib/python3.11/site-packages/google/cloud/aiplatform/_streaming_prediction.py", line 130, in predict_stream_of_dict_lists_from_single_dict_list
    for tensor_list in predict_stream_of_tensor_lists_from_single_tensor_list(
  File "/usr/local/lib/python3.11/site-packages/google/cloud/aiplatform/_streaming_prediction.py", line 107, in predict_stream_of_tensor_lists_from_single_tensor_list
    for response in prediction_service_client.server_streaming_predict(request=request):
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/google/cloud/aiplatform_v1/services/prediction_service/client.py", line 880, in server_streaming_predict
    response = rpc(
               ^^^^
  File "/usr/local/lib/python3.11/site-packages/google/api_core/gapic_v1/method.py", line 113, in __call__
    return wrapped_func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/google/api_core/grpc_helpers.py", line 166, in error_remapped_callable
    raise exceptions.from_grpc_error(exc) from exc
google.api_core.exceptions.InvalidArgument: 400 Unable to submit request because the model does not support the stopSequences parameter. Remove it and try again. Learn more: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/overview

related packages:
google-ai-generativelanguage  0.4.0
google-api-core               2.11.1
google-auth                   2.23.0
google-cloud-aiplatform       1.33.1
google-cloud-bigquery         3.11.4
google-cloud-bigquery-storage 2.22.0
google-cloud-core             2.3.3
google-cloud-resource-manager 1.10.4
google-cloud-storage          2.11.0
google-crc32c                 1.5.0
google-generativeai           0.3.1
google-resumable-media        2.6.0
googleapis-common-protos      1.60.0
grpc-google-iam-v1            0.12.6
langchain-google-genai        0.0.6
langchain-google-vertexai     0.0.3
grpc-google-iam-v1            0.12.6
grpcio                        1.58.0
grpcio-status                 1.58.0

Please let me know if you have any suggestions or questions. Thank you!

I just cloned this repo and tried to run 03-Pattern-III/00-BQ-agent.ipynb and get the same error.
Also, there were some issues setting up on my Mac with M3 and Sonoma due to dependency issues (namely Shapely).
My resolution was to use python3.8 and pip install without the versions stated.


Add options to install a nf-core module on the fly if not already installed

Description of feature
Add options to install a nf-core module on the fly if not already installed, in case a new aligner gets developed.

This is somthing not for this pipeline but a general functionality for a nf wrapper


refactor: Execution Stage owns Executor

Before, we had a weird pattern IMO where we'd call a execut_and_verify_with_receipts function with 5 arguments, and instantiating a new executor each time. That would make it really ugly if we wanted to integrate with the feature from PR #1567 as it'd require that we pass around the configuration for the inspectors. Instead, in this PR we refactor it so that the ExecutionStage now owns an Executor. It makes more sense this way, as we want the stage to basically be a coordinator around the 1-2 functions of the executor that are used across blocks (vs tracking more data than that).

Codecov Report

Merging #1568 (84bee3a) into main (b1741bd) will decrease coverage by 15.23%.
The diff coverage is 59.09%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1568       +/-   ##
===========================================
- Coverage   75.15%   59.92%   -15.23%
===========================================
  Files         371      371
  Lines       43342    43344        +2
===========================================
- Hits        32572    25974     -6598
- Misses      10770    17370     +6600

Flag
Coverage Δ

integration-tests
19.12% <0.00%> (-2.47%)
:arrow_down:

unit-tests
54.21% <59.09%> (-15.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/chain/import.rs
9.57% <0.00%> (-0.21%)
:arrow_down:

bin/reth/src/dump_stage/execution.rs
0.00% <0.00%> (ø)

bin/reth/src/node/mod.rs
0.00% <0.00%> (-2.91%)
:arrow_down:

bin/reth/src/stage/mod.rs
0.00% <0.00%> (ø)

bin/reth/src/test_eth_chain/runner.rs
0.00% <0.00%> (ø)

crates/revm/src/lib.rs
100.00% <ø> (ø)

crates/stages/src/lib.rs
100.00% <ø> (ø)

crates/stages/src/sets.rs
0.00% <0.00%> (ø)

crates/rpc/rpc-engine-api/src/engine_api.rs
67.09% <16.66%> (-25.29%)
:arrow_down:

crates/executor/src/executor.rs
71.17% <66.10%> (-22.31%)
:arrow_down:

... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thx for getting over the line bjerg - my bad for dropping the ball here


Add integ test for Authorization Policy Gateway Policy Attachment

Please provide a description of this PR:
Resolves #47263
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@whitneygriffith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test analyze-tests

integ-security-istiodremote_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test analyze-tests

integ-security-istiodremote_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-istiodremote

integ-security_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test analyze-tests

integ-security-istiodremote_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-istiodremote

integ-security_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security

integ-security-multicluster_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security

integ-security-multicluster_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-istiodremote

analyze-tests_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security

integ-security-multicluster_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-multicluster

analyze-tests_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test analyze-tests

integ-security-istiodremote_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
5cc862cb8b867ef6e946b1d916cf6fea0839f82e
link
true
/test integ-security-multicluster

analyze-tests_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test analyze-tests

integ-security-istiodremote_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-istiodremote

integ-security_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test analyze-tests

integ-security-istiodremote_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-istiodremote

integ-security_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security

integ-security-multicluster_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-istiodremote

integ-security_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security

integ-security-multicluster_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-multicluster

analyze-tests_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-istiodremote

integ-security-multicluster_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-multicluster

analyze-tests_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test analyze-tests

integ-security_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
4d87defe3ec772ed0e28a02f323e7b1901f4e79d
link
true
/test integ-security-multicluster

analyze-tests_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test analyze-tests

integ-security_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security

integ-security-istiodremote_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test analyze-tests

integ-security_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security

integ-security-istiodremote_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security-istiodremote

integ-security-multicluster_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security

integ-security-multicluster_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security-multicluster

analyze-tests_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test analyze-tests

integ-security-istiodremote_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
523a5b052e6959c67559f9c7085429619f720205
link
true
/test integ-security-multicluster

analyze-tests_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test analyze-tests

integ-security-istiodremote_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-istiodremote

integ-security_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test analyze-tests

integ-security-istiodremote_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-istiodremote

integ-security_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security

integ-security-multicluster_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-istiodremote

integ-security_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security

integ-security-multicluster_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-multicluster

analyze-tests_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security

integ-security-multicluster_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-multicluster

analyze-tests_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test analyze-tests

integ-security-istiodremote_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
f19d88edab1f173376976bbd8b6fec75ed833dd9
link
true
/test integ-security-multicluster

analyze-tests_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test analyze-tests

integ-security-istiodremote_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-istiodremote

integ-security_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

analyze-tests_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test analyze-tests

integ-security-istiodremote_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-istiodremote

integ-security_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security

integ-security-multicluster_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-istiodremote

integ-security_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security

integ-security-multicluster_istio
95e272327f3e5b90421817d485fb4186983c3ede
link
true
/test integ-security-multicluster

analyze-tests_istio
102a94ab3d1511dc1943fcdcac3a32fc0e44e8e5
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks good. Do we plan to support listener attachment too ?

do you mind expanding on what listener attachment is?

One small issue - if someone looks at the tests as an example, they may get the wrong impression. I would add a small comment to the gateway yaml - jwts are not best practice on port 80 ( some RFCs don't allow them).

updated!

Looks good. Do we plan to support listener attachment too ?
One small issue - if someone looks at the tests as an example, they may get the wrong impression. I would add a small comment to the gateway yaml - jwts are not best practice on port 80 ( some RFCs don't allow them).

Hey @costinm, wdym by listener attachment? Is it this or something else?

In response to a cherrypick label: new pull request created: #47647


detection network contains face alignment

Hello, may I ask if your detection network contains face alignment? Can I do face recognition based on the detection results of your network model

Currently this repo does not contain  landmark net. You can add one landmark model on the output of the face, then do face alignment and recignition.


can not link to boost.log

I installed the latest VCPKG and vs2019.
On this environment, I installed boost1.71, but vs2019 could not link to boost.log.
I think this is probably due to a versioning error in the build library. The resulting library is boost_log-vc140-mt.lib.

If it is still an issue, please reopen and provide us more information.


Quick fix verse ref invalidations

Refs #10

[ ] If a verse is duplicated, we should offer to remove the vref.
[ ] If a verse is missing, we should offer to add it.

I think this allows the user to 'quick fix' all the problems we detect, even if it may take multiple steps. There are probably some cases I'm not thinking of.

@ryderwishart Thanks, I was also wondering where the file with all the verse references is, is it on ebible?

@dadukhankevin Yes, the vrefs in the codex project are from the ebible https://github.com/BibleNLP/ebible/blob/main/metadata/vref.txt
We simply took that file and its located at servers/versedata.txt in the codex repo now

Alright, it should be complete, for now, if there is a duplicate verse I don't have it delete the actual text associated with the duplicate because I'm assuming that could lead to someone accidentally deleting good text and not realizing it. I can change that though if it's better to delete the whole thing. Also, now all of it works in inline verse references which it wasn't.


Error connecting to https://api.wpvip.com/graphql after data sync

I completed a successful data sync using vip sync --app XX --env develop. I watched it (mostly) while it worked and saw no errors, all the checkmarks showed up, and it said it was successful. When I went back to my terminal a few minutes later, there were lots of the following:
 ✕  Unexpected error: Please contact VIP Support with the following error:
  Error: Network error: request to https://api.wpvip.com/graphql failed, reason: connect ECONNREFUSED <IP_ADDRESS>:443
    at new ApolloError (/usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:121:32)
    at /usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:1188:45
    at /usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:1619:21
    at Array.forEach (<anonymous>)
    at /usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:1618:22
    at Map.forEach (<anonymous>)
    at QueryManager.broadcastQueries (/usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:1613:26)
    at /usr/local/lib/node_modules/@automattic/vip/node_modules/apollo-client/bundle.umd.js:1115:35
    at process._tickCallback (internal/process/next_tick.js:178:7)

This doesn't look concerning and @scottsweb mentioned this could be due to the SSH session expiring. Logging here anyway just in case.

I'm thinking this is a duplicate of #44


MainDOMSource.select(...).events(...) compiles with TypesScript error "TS2349: This expression is not callable."

Code to reproduce the issue:
import { DOMSource, VNode, button, makeDOMDriver } from '@cycle/dom';
import { run } from '@cycle/run';
import { Stream } from 'xstream';

const drivers = {
  DOM: makeDOMDriver('#app'),
};

interface Sources {
  DOM: DOMSource;
}

interface Sinks {
  DOM: Stream<VNode>;
}

const App = function(sources: Sources): Sinks {

  const {
    DOM
  } = sources;

  const clicked$: Stream<number> = DOM
    .select('button')
    .events('click')
    .fold((acc: number) => acc + 1, 0);

  const vnode$ = clicked$
    .map((n) => (
      button(`Clicked ${n}`)
    ));

  return {
    DOM: vnode$
  };

}

run(App, drivers);

Expected behavior:
Compile without errors.
Actual behavior:
[tsl] ERROR in /app/src/index.ts(25,6)
      TS2349: This expression is not callable.
  Each member of the union type '(<K extends "error" | "fullscreenchange" | "fullscreenerror" | "abort" | "animationcancel" | "animationend" | "animationiteration" | "animationstart" | "auxclick" | "blur" | "cancel" | ... 81 more ... | "paste">(eventType: K, options?: EventsFnOptions | undefined, bubbles?: boolean | undefined) => Stream<...>) | (<K...' has signatures, but none of those signatures are compatible with each other.

Versions of packages used:
{
  "name": "test",
  "version": "0.1.0",
  "description": "",
  "main": "index.ts",
  "scripts": {
    "build": "webpack",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "UNLICENSED",
  "devDependencies": {
    "html-webpack-plugin": "^3.2.0",
    "ts-loader": "^6.2.1",
    "typescript": "^3.6.4",
    "webpack": "^4.41.2",
    "webpack-cli": "^3.3.9"
  },
  "dependencies": {
    "@cycle/dom": "^22.4.0",
    "@cycle/run": "^5.3.0"
  }
}

Perhaps you need DOM: MainDOMSource, instead?

@mightyiam That fixes it!


Incomplete refrences between MONDO and HPO terms

We are interested in using your ontology to relate diseases to Human Phenotype Ontology (HPO) terms.
We have observed that you have MONDO terms directly related to HP terms by xref tag but you use different formats like:

(Short format) MONDO:0000088
(Extended format) MONDO:0000063

But our main problem is that not all MONDO terms have refrences to HP terms. Specifically, there are only 563 MONDO terms with, at least, one HP term linked.
We have linked more HP terms using an annotation table given by HPO called "phenotype_annotation.tab" (https://hpo.jax.org/app/download/annotation) and linkage of MONDO terms with Orphanet and/or OMIM terms.
Can you include HP linkages directly into MONDO?

Hi @fmjabato - to clarify, by short and long format - do you mean xrefs with and without provenance?
Regarding including HPO linkages directly into Mondo - let me discuss further with our team and we'll get back to you.

@fmjabato sorry for the delay on this - could you let me know about the question above when you have a chance? Thanks!

Never mind @nicolevasilevsky . Let me reformule the question.
We are working with HPO in order to study genetic diseases (coded, for example, using OMIM and ORPHANET). We are studying your MONDO ontology and we found that you directly reference MONDO items with HPO IDs (forget the short/extended matter).
If we take the direct references, we found 563 MONDO with phenotypes (HPO ids). We have used an external file (from official HPO web) which relates HPO_ids with OMIM/Orphanet ids ( phenotype_annotation.tab ). Using your relations MONDO-OMIM/Orpha, we are able to infer new phenotype relations obtaining 4703 MONDO terms with any phenotype related.
We want to know why are not those relations into MONDO ontology? Or why we shouldn't use these HPO inferences for our studies?.
Thanks in advance

I think you are mixing up the concept of an "xref" and a "disease-to-clinical-feature association". These are not the same. An xref is not much - the obo guide mentions something like "This xref is of relevance to the current entity". The HPO-annotation files you are using are more, they clearly associate a disease concept (D) with individual clinical features that patients with the diagnosis D are typically showing.
Let me know if you have further questions.

Okey, at this point I have some doubts. I understand that the HPO file relates phenotypes with diseases. At this point, I'm interested on use your MONDo hierarchy to work with MONDO items.
Specifically, I want to assign phenotype profiles (HPO IDs) to MONDO terms in order to apply some semantic and other mathematical studies.
And I do the following:

I use your mondo.obo file and use xref tag to obtain MONDO-{HPO/OMIM/Orphanet} tuples. At this point, I find 563 MONDO terms with any (>=1) phenotypes (HPO id) linked. Note: there are several types of info relate to MONDO items using xref tags but we are parsing to take only these three.
I use HPO annotation file - with HPO-{OMIM/Orpha} tuples - and already loaded MONDO-{OMIM/Orpha} tuples to infer new MONDO-HPO relations. At this point, I increase the MONDo with any size phenome to 4703.

Both of you (Monarch and HPO) perform statistical inferences based on graphs in order to obtain referenced files (mondo.obo and phenotype_annotation.tab).
I want to know if xref referenced on your MONDO OBO format file are significant? or how are you inferring it to your MONDO terms? It it are relevant, I want to know why there are not being referenced new relations obtained after 2) process.

Is your question @fmjabato whether Mondo contains all the xrefs where a Mondo ID equals an HP ID? In our conceptual framework, which may be confusing to some, diseases (Mondo) and phenotypes (HPO) are never "the same" even if the labels sound similar. Are you trying to merge HPO and Mondo terms like that? And is your questions wether we have all of them in Mondo? Then the answer is no.. Its not complete.

As this ticket is very old, I will close it now, but @fmjabato, please reopen this ticket if this is still and open issue for you - happy to help you sort it out :) Sorry for the delay!


directinput vs. rawinput in Miniengine

As I understand it directinput is deprecated and the general consensus is that for keyboard/mouse raw input is that preferred approach. Is there a specific reason why Miniengine is using directinput and might it serve as a a better example if it were using raw input instead?

The mouse and keyboard input handling was some legacy code we had lying around.  Our path going forward will be to embrace WinRT APIs for keyboard, mouse, and gamepad input.  This will unify more of the engine with some Xbox-specific code paths that aren't present on GitHub (though you might have seen references to Xbox scattered around.)

That will be great to see. Thanks!


Add TPrediction[] Predict(F64Matrix observations) to public interface IPredictor

I think it would be a good idea to add the F64Matrix overload to the IPredictor interface as it would make it easier to use the IPredictorModel interface in your code. The models seems to implement it already.
It would add a dependency for SharpLearning.Containers.Matrices in SharpLearning.Common.Interfaces, but I think it is unlikely that you would use the SharpLearning library without referencing SharpLearning.Containers.Matrices anyway.

Hi @andjor
Thanks for submitting the issue. I think it is a good idea to add an overload to the IPredictor` interface that accepts a matrix and returns an array of predictions. All models implement the overload anyway, so it makes sense to add it, and will make it easier to use interfaces.
SharpLearning.Common.Interfaces already has a reference to the SharpLearning.Containers project, since the F64Matrix is used in the ILearner interface, so adding the overload will not add anything extra to the project.
You are more than welcome to add the overload in a pull request. Let me know if you start to work on it.

Hi @mdabros
I will start implementing it and send you a pull request this week.
At the moment there are no test project for the Common.Interfaces project and it does not look like there is any tests for the interfaces in each models test project.
Should I add a test project for the interfaces or what is the approach to testing interfaces?

@andjor Sounds great with the pull request.
The interface project does not need to have any tests, since it only defines a contract and not any concrete implementation.
For the concrete implementations, there are already tests for each specific model type. For instance here for the ClassificationForestModels: ClassificationForestModel_Predict_Multiple and ClassificationForestModel_PredictProbability_Multiple.
So the concrete implementations are already tested, they just don't have an interface yet. So overall, you don't have to add any additional tests.
Note, that only the classifier models have a PredictProbability method, so only these need the explicit interface implementation for the ProbabilityPrediction overload, which simply forwards to the PredictProbability method, here for the single observation case:
/// <summary>
/// Private explicit interface implementation for probability predictions
/// </summary>
/// <param name="observation"></param>
/// <returns></returns>
ProbabilityPrediction IPredictor<ProbabilityPrediction>.Predict(double[] observation)
{
    return PredictProbability(observation);
}

Let me know if you need any additional information.

Closing the issue, since this has been completed in #33


IOU - Add stop button is not aligned in the center

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.52
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com
Tap fab ---Request money--Distance
Enter start and stop point
Note Add stop button

Expected Result:
Add stop button must be aligned in the center
Actual Result:
Add stop button is not aligned in the center
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

Production:

@marcaaron  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp
CC @quinthar

cc @luacmartins

will take a look

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Add stop button is not aligned in the center
What is the root cause of that problem?
react native paddingHorizontal not ovveride paddingLeft.
and we use in getButtonStyleWithIcon paddingLeft 12 and ovveride it with innerStyles have paddingHorizontal 40 here
https://github.com/Expensify/App/blob/b7a230ea75dbc4294f061c7627a24679e346641e/src/components/Button/index.tsx#L316
but react native not ovveride paddingLeft with paddingHorizontal
What changes do you think we should make in order to solve the problem?
we can pass styles.pl10, styles.pr10 instead of ph10 here
What alternative solutions did you explore? (Optional)

@narefyev91 if you will fix this issue as regression and this will not go to external you can take alook in my proposal.

This is fixed in staging


"php" autocompletes to "php<?php"

Every time i type "php" it auto completes it as  "php<?php" and that's a really annoying problem for my productivity. Anyone who knows about this?

Its the Code snippets builtin in your code editor or ide what ever it is, can you tell me which code editor you are using?


URLError has no attribute 'code'

In some methods which names starts with recognize_, e.g. recognize_google, that catch URLError in except blocks, but when raised an RequestError, it reference code attribute of the exception instance , but URLError not have!
Here is what I met the exception in exception:
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 1240, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 1083, in request
    self._send_request(method, url, body, headers)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 1128, in _send_request
    self.endheaders(body)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 1079, in endheaders
    self._send_output(message_body)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 911, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 854, in send
    self.connect()
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/client.py", line 826, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socket.py", line 711, in create_connection
    raise err
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socket.py", line 702, in create_connection
    sock.connect(sa)
TimeoutError: [Errno 60] Operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/site-packages/speech_recognition/__init__.py", line 404, in recognize_google
    response = urlopen(request)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 162, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 465, in open
    response = self._open(req, data)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 483, in _open
    '_open', req)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 443, in _call_chain
    result = func(*args)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 1268, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 1242, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 60] Operation timed out>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.5/site-packages/speech_recognition/__main__.py", line 17, in <module>
    value = r.recognize_google(audio)
  File "/usr/local/lib/python3.5/site-packages/speech_recognition/__init__.py", line 408, in recognize_google
    raise RequestError("recognition connection failed: {0}".format(getattr(e, "reason", "status {0}".format(e.code)))) # use getattr to be compatible with Python 2.6
AttributeError: 'URLError' object has no attribute 'code'

Can you post a copy of the request data?

Thanks for reply, I have no codes written just use python -m speech_recognition, the reason raised the error is in my area the default Google Speech Recognition cannot be accessed, so an Timeout is raised.

Hi @mailto1587,
This is now fixed in the upcoming offline branch. It will be a part of the next stable release.
Thanks for reporting!

My pleasure


the number of raw is wrong in initial case

On page rendering, it always display two rows data. Other data is blank. When I debug in virtual-scroll, I found the result of calculation is wrong. It seems that it is not to get the right height to calculate. When I manually invoke the method refresh() in constructor, this issue can be addressed. But in IE browser, the process of loading the following blank row is too slow. Can you give me some suggestion about this issue?

I've updated npm with a new version that has a few fixes. Could you try the latest & see if it helps with your issue?

Closing this since I haven't received a response from the original poster. Please re-open if you continue to experience this issue.


[FLINK-34477][table] Support capture groups in REGEXP_REPLACE

What is the purpose of the change
Support capture groups in REGEXP_REPLACE
Brief change log

Added support for capture groups by skipping the dollar sign
Adjusted some tests and added new ones

Verifying this change
Tests: org.apache.flink.table.planner.expressions.ScalarFunctionsTest::testRegexpReplace
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no )
The runtime per-record code paths (performance sensitive): (no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Hi @JingGe could you please review this PR in your available time? Thanks!


Clean up the old mtls integration test

Bug description
TestMTlsWithAuthNPolicy those tests are running with old test framework.
Only concern is is this might be run in multi cluster env setup. But however, it does not make sense to run two set of the same tests but different test frameworks...
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)

This is no longer running


Add else if   Conditional Statements to the translator

To add else if support to CrossGL, modify the following files in the crosstl/src/translator directory:

[ ] Lexer.py: Add token recognition for else if.
[ ] Parser.py: Update grammar and AST to handle else if.
[ ] Directx_codegen.py: Implement else if for HLSL output.
[ ] Metal_codegen.py: Implement else if for Metal output.
[ ] Opengl_codegen.py: Implement else if for GLSL output.

 Feel free to reach out on our Discord Server  if you have any query.

Hello 👋
Can I please take this one?

Hello 👋
Can I please take this one?

Sure thing @AxelB1011😁

Hi interested to work on this issue . So kindly assign it to me @NripeshN @niixxaaa

i  would like to take on this issue if not completed yet @niixxaaa


' add contact person' under send mail in debit notes

[x] remove mandatory field from add contact person

issue doesnot exist .hence closing the issue


Extracting path from node selection

Hi,
I'm looking for a way to extract the full path when a node is selected. The function on-selection="showSelected(node)" returns the current node. Is there a simple way to compute the selected node path without re-parsing the whole tree?
Thanks,
Jean

I'm looking for this too, calculating it every time is quite intense.  Need something like this to make removing a nested node easier.

the problem with this feature is that I have no idea how to expose it.
It makes no sense to compute the full path everytime a selection happens just in order to pass it as a parameter to the on-selection event expression. I can make a function that is passed as a parameter, and if called returns the array of nodes in the path.
e.g. (using lodash)
on the tree element:
on-selection="onSelection(node, $path)"

and the event handler

function onSelection(node, path) {
  var nodesInPath = path();
  var pathAsString = _.reduce(nodesInPath, function(string, node) {
    return string + "/" + node.title;
   }, "");
}

However, I am afraid people will find this way to confusing to use.

I am looking to do the same too. At first I thought I can implement a buildPath(node, $parentNode), since on-selection and on-node-toggle pass $parentNode, but turns out $parentNode doesn't have a .$parentNode itself. So maybe if the tree control already knows the parentNode of a given node, it can either store that for all nodes, allowing us to reconstruct the full path? Or maybe use whatever logic it uses now to determine the parent node of a selected node, to give us a function like parent(node), and we'll reconstruct the path using it?

done. see the $path function  -
http://wix.github.io/angular-tree-control/#events
and
http://wix.github.io/angular-tree-control/#labels-template

Great, I'll try it out soon. Thanks!


Error when loading local model: ValueError: Unrecognized configuration class <class 'transformers_modules.configuration_chatglm.ChatGLMConfig'> for this kind of AutoModel: AutoModelForCausalLM.

I downloaded the model locally, and when I run this line, the error occurs.
model = AutoModelForCausalLM.from_pretrained(model_path, truse_remote_code=True)

I've looked at solutions in https://github.com/THUDM/ChatGLM-6B/issues/153 and https://github.com/THUDM/ChatGLM-6B/issues/37, but it doesn't seem to help.
I understand that the problem might be solved if I directly load the model from huggingface, but I think it's still a problem here

I think you should upgrade your transformers package.
pip install git+https://github.com/huggingface/transformers

Then it's the problem of your downloaded model. Try download it from official repo.

Use AutoModel instead of AutoModelForCausalLM if you are using VisualGLM-6B.

Thanks, that is indeed the problem


--startuptime overwrites existing files without warning

I ran:
$ vim --startuptime file

The expected behaviour was that Vim would start, load the buffer file, and show the startup performance report. The actual behaviours was to overwrite the contents of file with no warning.
I was able to restore the contents of file from my ~/.vim/tmp/backup, but I think this is bad UX, and Vim should not overwrite existing files when using --startuptime.

Adding to that, I'll be happy to write a patch if people agree.

That is not the expected behavior.  It is the documented behavior.  See :h --startuptime.

:s/expected/unexpected

Even in vim --help, it's clear that what you call expected is in fact to be unexpected.

The actual behaviours was to overwrite the contents of file with no warning.

--startuptime should always append to an existing file, so even if you pass the wrong file, the mistake shouldn't be fatal.

Closing this as documented behaviour. If anyone wants to change the behaviour of making --startuptime append instead of truncating, feel free to post a patch/PR.

@chrisbra  My comment above was not clear enough (it was not a desideratum): --startuptime is already append-only (and, as @chdiza has said, that is the documented behaviour of that option). I guess the OP was complaining that Vim modifies (rather than truncates) the content of an existing file without warning.

ah okay, did miss that indeed.


Adding Subgraph Client

In this version, we use the graph client to create and consume the data in the Greetings Table component.

All tested good!


extract WindowStates::just_slide_to method

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#18847
#18846  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on  Graphite


Issue #3564 resolved

BUGS:
issue: #3564

hello @vishal-webkul
Provide configuration for maximum file size for this attribute with the default value.

Now its working but please add validation for file type, as currently its accepting all type of file like pdf,zip

Done


Revisit core, main and foundation integration tests #2362

Fix #2362

Created a new foundation group
Split out timer, log, direct, etc. to separate test modules
Minimized the dependencies in the individual modules
Have both consumer and producer assertions for direct

There is some more potential to bring in bean, simple, the old foundation tests and maybe some parts of the main tests to the new foundation group.

0d55453:

Fixed an issue in the grouping script
Moved Simple and Bean tests to the foundation group


feat/Ensure Localtime and Timezone for host is always in-sync with container

Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Map the server's timezone and localtime to container instead
for more info https://www.howtogeek.com/devops/how-to-handle-timezones-in-docker-containers/

you cannot change this file in container, instead you must use i.e TZ=Europe/Berlin environment variable for container.

you cannot change this file in container, instead you must use i.e TZ=Europe/Berlin environment variable for container.

No idea what you mean by "cannot". It was meant to map the things so that the container would always refer to the same timezone settings as the host.

If you want this change reviewed, please re-submit and provide a detailed rationale

If you want this change reviewed, please re-submit and provide a detailed rationale

It's alright. Thanks anyway Mike.


1.14.2 on Mac update?

Wanted to start off by thanking dev for doing god's work here. No other way for us on Silicon Macs to play Vanilla. Been putting many hours into the 1.14.0 client and would love to see the much better 1.14.2 client on Mac. If you have any update please let us know. Know that there are many people using this product. Cheers.

There is an UI update coming soon which will only support 1.14.2.

Request support for Intel Core chips！！

There is an UI update coming soon which will only support 1.14.2.

I can't wait no longer .

Request support for Intel Core chips！！


id() function does not return the targetname of the parent macro entity

When used inside a template, the id() function should return the targetname of the macro entity that is creating an instance of that template. id() should only return the numerical ID of the current instance if that macro entity does not have a targetname. However, it currently always returns the numerical ID.
Workaround: instead of {id()}, use {targetname}, or {targetname or iid()} if the targetname may be empty and you need to fall back to the numerical instance ID.

Fixed in v1.2.2


Add integer division special case tests

This PR adds tests for integer division by zero and dividing the minimum value by -1 for all four opcodes (DIV/DIVU/DDIV/DDIVU), checking both the quotient and remainder for correctness.
Note that emulators not explicitly supporting the min / -1 case tend to crash with an arithmetic overflow exception on x86, which makes diagnosing the issue a bit more tricky unless you are aware of this test.

Hey, sorry for the late response. I just caught this!
I'll merge this shortly once I had a chance to test it on hardware. Thanks a lot for the contribution!


Database ODM

There needs to be a story about how an @Routable() class's properties can also be persisted to MongoDB.
@Routable({
     baseUrl: 'user'
})
class User {
     fisrtName: string;
     lastName: string;

     @Route({
          path: '/:id',
          method: 'get'
     })
     getUserById(...) { }

     @Route({
          method: 'post'
      })
     saveUser(...) {}
}

How does that thing get persisted?

This ticket is handled by #6, #13, and #21 - closing.


Update index.mdx to account for bun start crash on win

added "bun run start" for the experimental bun windows platform bc "bun start" crashes currently (#5833)
Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests / types / typos

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

does bun run start solve the #5833 issue on Windows?

does bun run start solve the #5833 issue on Windows?

for me, yes it does. for others idk


netlrts hangs in SMP mode

Original author: Nikhil Jain
Original issue: https://charm.cs.illinois.edu/redmine/issues/299

Testing megatest, jacobi2d (or any other program) for netlrts-linux[-x86_64] results in a hang at exit.

Original author: Nikhil Jain
Original date: 2013-10-07 02:53:50

Bug fixed by change in LrtsExit call for netlrts based layer to do what they are supposed to do (not what they used to do in non-LRTS version).

Original author: Nikhil Jain
Original date: 2013-10-23 04:36:14

After making use of more of LRTS API, a new bug manifests as a hang in multicast test.


In polymer 0.10.0+1, assignment to an initialized @observable in created() breaks the app

Originally opened as dart-lang/sdk#19467
This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Declare 2 elements, parent and child. In parent, declare an @observable x
In child, declare a @published variable y.
In parent html, bind it's varuiable x with child's variable y.

If in parent, x is initialized in declaration site and assigned a value in created(), the application fails to launch (browser is loading the page with no signs of progress)
If only one of these places is used, the app works ok
What is the expected output? What do you see instead?
Reassignment in created() shouldn't break the app
What version of the product are you using? On what operating system?
polymer 0.10.0+1, dart 1.4.2, Windows 7
The issue did not appear on 0.9.5+2
Please provide any additional information below.
Originally posted at
http://stackoverflow.com/questions/24241910/dart-polymer-observable-variable-initialization-handling-in-polymer-0-10-0

 Comment by kasperl

Added Area-Pkg, Pkg-Polymer, Triaged labels.

 Comment by zoechi

Seems to cause more troubles
http://stackoverflow.com/questions/24255288

This comment was originally written by<EMAIL_ADDRESS>
Looks ok in polymer 0.11.0+3

 Comment by sigmundch

Thanks for the update! Glad to hear.
I'm closing the bug, but feel free to reply here if you run into it again.

Added AssumedStale label.


Feature request: Improve error handling (error thrown from open() should contain the actual error, e.g. ECONNREFUSED)

Right now the only way to detect if this library throws an error on connection (as opposed to something else) is to check for the string err.message.startsWith('WebSocket closed with reason:').
For example this error is thrown on an unsuccessful await wsp.open() call:
RWS> addListeners
RWS> error event connect ECONNREFUSED ::1:3456
Error: WebSocket closed with reason:  (1000).
    at WebSocketAsPromised._handleClose (/Users/user/Projects/web/node_modules/.pnpm/websocket-as-promised@2.0.1/node_modules/websocket-as-promised/src/index.js:408:19)
    at listener (/Users/user/Projects/web/node_modules/.pnpm/websocket-as-promised@2.0.1/node_modules/websocket-as-promised/src/index.js:340:64)
    at ReconnectingWebSocket._callEventListener (/Users/user/Projects/web/node_modules/.pnpm/reconnecting-websocket@4.4.0/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:557:13)
    at /Users/user/Projects/web/node_modules/.pnpm/reconnecting-websocket@4.4.0/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:197:79
    at Array.forEach (<anonymous>)
    at ReconnectingWebSocket._handleClose (/Users/user/Projects/web/node_modules/.pnpm/reconnecting-websocket@4.4.0/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:197:36)
    at ReconnectingWebSocket._disconnect (/Users/user/Projects/web/node_modules/.pnpm/reconnecting-websocket@4.4.0/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:540:18)
    at ReconnectingWebSocket._handleError (/Users/user/Projects/web/node_modules/.pnpm/reconnecting-websocket@4.4.0/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:180:19)
    at callListener (/Users/user/Projects/web/node_modules/.pnpm/ws@8.14.2_nn4cfacdngcg7bs47xs3zpla7u/node_modules/ws/lib/event-target.js:290:14)
    at WebSocket.onError (/Users/user/Projects/web/node_modules/.pnpm/ws@8.14.2_nn4cfacdngcg7bs47xs3zpla7u/node_modules/ws/lib/event-target.js:230:9)
    at WebSocket.emit (node:events:513:28)
    at emitErrorAndClose (/Users/user/Projects/web/node_modules/.pnpm/ws@8.14.2_nn4cfacdngcg7bs47xs3zpla7u/node_modules/ws/lib/websocket.js:1016:13)
    at ClientRequest.<anonymous> (/Users/user/Projects/web/node_modules/.pnpm/ws@8.14.2_nn4cfacdngcg7bs47xs3zpla7u/node_modules/ws/lib/websocket.js:864:5)
    at ClientRequest.emit (node:events:513:28)
    at Socket.socketErrorListener (node:_http_client:502:9)
    at Socket.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

Having access to the raw error would be useful for error handling purposes (e.g. being able to see err.code is ECONNREFUSED.
Additionally, the err.reason property can be empty, and as you can see from the above example it has extra whitespace added to the error string (which isn't dev-friendly).  This will require a rewrite to _handleClose and _handleError handlers most likely (?)
Reference: https://github.com/vitalets/websocket-as-promised/blob/bc60644c935b69eba1284f5863d3d91099165bd0/src/index.js#L407

Good point, I agree.
Would appreciate a PR for that.


gnutar: disable fortify3 hardening flag

Description of changes
after https://github.com/NixOS/nixpkgs/pull/224822
tar crashes during building of docker image, sorry I don't have a small test to reproduce, but this fixes the crash for me
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Maybe that's a genuine bug in tar?  (their buffer overflowing)

I mean, the whole point of the hardening is to cause (safe) crashes.

I mean, the whole point of this hardening is to cause (safe) crashes.

fair enough, I will have a closer look at crash.
makes me wonder what it writes to the tar if it doesn't crash !

I have created minimal derivation to reproduce the issue, but i am having difficulty getting a coredump
https://discourse.nixos.org/t/cant-get-coredump-from-nixbld-user/31090
any help appreciated

The issue seems to be a bug in fakechroot; its shim of __readlinkat_chk seems to call the next readlinkat with a buffer size of FAKECHROOT_PATH_MAX-1, but with the buflen equivalent to the smaller buffer.
I suspect, but  haven't tested, that the smallest reproducer would be just compiling char foo[4]; readlink("/run/current-system", foo, 4);. with optimizations and _FORTIFY_SOURCE=2.

The issue seems to be a bug in fakechroot; its shim of __readlinkat_chk seems to call the next readlinkat with a buffer size of FAKECHROOT_PATH_MAX-1, but with the buflen equivalent to the smaller buffer.
The smallest reproducer is:
#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>

int main(int argc, char **argv) {
    char foo[4];
    readlink("/run/current-system", foo, atoi(argv[1]));
    return 0;
}

Compile cc -O1 -D_FORTIFY_SOURCE=2 -o crash crash.c.
Call as either ./crash 4 (should not crash), ./crash 5 (should crash!), or FAKECHROOT_EXCLUDE_PATH=/dev:/proc:/sys:/nix/store/:/run fakechroot chroot . ./crash 4 (crashes, shouldn't.)
(Thanks @yorickvP for helping out!)

@puckipedia thank you for taking time looking into this !
It looks like compiler bug to me
int main(int argc, char **argv) {
    char foo[4];
    readlink("/run/current-system", foo, 4);
    return 0;
}

FAKECHROOT_EXCLUDE_PATH=/dev:/proc:/sys:/nix/store/:/run fakechroot chroot . ./crash

doesn't crash

it's not a compiler bug; glibc with hardening enabled will pass a hidden parameter, the size of the buffer being written into, if known. If the maximum length passed into the syscall is larger than the statically determined size of the buffer, it bails out, knowing that the buffer would've been overflowed. It doesn't do this on static readlink calls because it can statically determine that the buffer can't overflow. fakechroot messes up handling this behaviour in a way that usually wouldn't matter, but that due to nixpkgs' defaults for hardening, shows up more often than other distros.

Indeed there's an old adage that's something like "if you think you've found a compiler bug, you haven't.
I'm interested in the relevance of this line:
https://github.com/dex4er/fakechroot/blob/b42d1fb9538f680af2f31e864c555414ccba842a/src/__readlink_chk.c#L25

That line is fine. This isn't entirely the platform to discuss the ins and outs of a bug in fakechroot, but i'll do it anyways:
The _FORTIFY_SOURCE define is needed to induce glibc into introducing the definition of __readlink_chk. The nextcall for __readlink_chk reuses the buflen as passed in by the program while reading into a buffer the size of FAKECHROOT_PATH_MAX-1. as FAKECHROOT_PATH_MAX-1 (bufsiz) > 4 (buflen), glibc assumes that the buffer was in fact only 4 bytes long, and crashes the program, as it seems someone just tried to overflow the buffer. The fix would be to just use FAKECHROOT_PATH_MAX-1 instead of buflen, as well as manually check for bufsiz > buflen (except when buflen == -1).

Of course, that makes sense.

closing as this is fakechroot issue

We should probably submit a patch to fakechroot to fix this

upstream issue https://github.com/dex4er/fakechroot/issues/114


Split tests

Fixes #26.

haven't tested it locally, but I like the order in tests.
it's gonna make some conflicts with the other PR.


[Error] Loading aborted due to error reloading workflow data

I'm trying to get my local installation of ComfyUI up to date after using it in Colab for some time. Whenever i try to load a workflow i get following error. I am using win11 and the most up to date version of Custom Scripts as of writing this (32c9381). Besides Custom Scripts im using following custom nodes:

https://github.com/melMass/comfy_mtb
https://github.com/Fannovel16/comfyui_controlnet_aux
https://github.com/WASasquatch/was-node-suite-comfyui
https://github.com/ltdrdata/ComfyUI-Manager

Loading aborted due to error reloading workflow data

TypeError: can't access property "submenu", v is null

set@http://<IP_ADDRESS>:8188/extensions/pysssss/CustomScripts/betterCombos.js:160:11
LGraphNode.prototype.configure@http://<IP_ADDRESS>:8188/lib/litegraph.core.js:2542:7
LGraph.prototype.configure@http://<IP_ADDRESS>:8188/lib/litegraph.core.js:2240:26
init/LGraph.prototype.configure@http://<IP_ADDRESS>:8188/extensions/pysssss/CustomScripts/reroutePrimitive.js:14:29
init/LGraph.prototype.configure@http://<IP_ADDRESS>:8188/extensions/pysssss/CustomScripts/snapToGrid.js:53:21
loadGraphData@http://<IP_ADDRESS>:8188/scripts/app.js:1227:15
handleFile/reader.onload@http://<IP_ADDRESS>:8188/scripts/app.js:1535:10

This may be due to the following script:
/extensions/pysssss/CustomScripts/betterCombos.js

Edit: it seems to only happen to when i load some workflows, this one for example
Edit2: Has something to do with the Loraloader, i dont have the Lora installed locally that i used in the workflow. even after installing the lora locally it didnt work only after removing the LoraLoader i could import the workflow locally

This should now be fixed


xmldoc: ProcessSettings.Timeout should be specified in milliseconds

@ghuntley this is a great addition, thanks for taking the time!