feat: add guide to iip-template.md

Fixes #9

@eznix86 we can just write the template in iip-template.md and keep guides in the contributing file. what do you think?
Also, I think it will be good to add a motivation and specification part in the template.
have a look at these files, you can get some ideas:
https://github.com/pactus-project/PIPs/blob/main/pip-template.md // the explanations is commented

@eznix86 we can just write the template in iip-template.md and keep guides in the contributing file. what do you think? (or just comment the guides)
because we need to people can just copy and paste this and start writing their iip.
Also, I think it will be good to add a motivation and specification part in the template.
have a look at these files, you can get some ideas:
https://github.com/pactus-project/PIPs/blob/main/pip-template.md //The explanations are commented

Yes, I will move things around so it match this description

Yes, I will move things around so they match this description

ok, address these 3 issues, and then we can merge them and start work on pip-00

@eznix86 this pr is in which state?

@eznix86 this pr is in which state?

Pushing some changes to this PR

Tiny error while copy pasting 😂

no problem 😂


Add git.fetch and update docs

I needed git fetch for a project, so... here it is if you want it.

Thanks, could you write a test for fetch?

Sure, no problems. Stay tuned :)

Ok, testing towards https://github.com/stevelacy/git-test
Hope you're happy with the code, tried to match existing code style etc.

Nicely done, you can remove the globals comment as it is added to .jshintrc


Remove kubebuilder kustomize manifests

With a helm chart available, the kustomize manifest is just unnecessary config in the repo.
My suggestion would to follow similar route as cert-manager's deployment manifests if we want to publish manifest artifacts with Github releases. This uses a default helm values file and helm template to generate the yaml to kubectl apply.

+1 for this.


Borrow Pigeonhole tests suite

https://github.com/dovecot/pigeonhole/tree/master/tests

Infrastructure for running Pigeonhole's tests is here. Will enable tests as we implement support for extensions.


Use all workers for openstack-control-plane

Currently we are using only 2 out of 3 workers (default deployment)
for the control plane deployment of controller pods. This makes the
2 first nodes resource exhausted while the third node does nothing.
Instead, as this is used only for development/CI currently, use
all of the workers for a smooth, no-pod-restart, development/CI
workflow.
This has the side effect of having to separate the labeling of the
compute nodes as the openvswitch label already exists in the
worker-2 so it wont be labeled properly. Its still a good thing
to have as we should label things separatedly in case of errors
and/or retries

CI passed (Real pass) in 1:49 for setup_airship. Not bad considering its usually around the 3 hours lately.

Approving but expressed my concern for code sprawl a little above.


Update .spi.yml

Of course I'd trip over this... 😅
https://github.com/SwiftPackageIndex/SPIManifest/pull/34

Finally! https://swiftpackageindex.com/builds/B7B644F2-3569-44A8-8686-24436633CF40


Components should block for at most 20-30ms.

Hello, thank you for your work. I have a problem with the component. I use wemos d1 + mcp251, the reading is after the start but after a few seconds I have ad and no sensor readings. update_interval extension: 20s does not bring good results
[08:50:30][D][huawei_r4850:049]: Sending request message
[08:50:30][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:50:30][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:50:30][D][number:012]: 'r4850 Max output current': Sending state nan
[08:50:30][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:50:30][W][component:205]: Components should block for at most 20-30ms.
[08:50:30][D][sensor:093]: 'r4850 Input power': Sending state 0.00000 W with 1 decimals of accuracy
[08:50:50][D][huawei_r4850:049]: Sending request message
[08:50:50][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:50:50][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:50:50][D][number:012]: 'r4850 Max output current': Sending state nan
[08:50:50][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:50:50][W][component:205]: Components should block for at most 20-30ms.
[08:50:50][D][sensor:093]: 'r4850 Input power': Sending state 0.00000 W with 1 decimals of accuracy
[08:51:10][D][huawei_r4850:049]: Sending request message
[08:51:10][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:10][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:51:10][D][number:012]: 'r4850 Max output current': Sending state nan
[08:51:10][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:51:10][W][component:205]: Components should block for at most 20-30ms.
[08:51:10][D][sensor:093]: 'r4850 Input power': Sending state 0.00000 W with 1 decimals of accuracy
[08:51:30][D][huawei_r4850:049]: Sending request message
[08:51:30][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:30][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:51:30][D][number:012]: 'r4850 Max output current': Sending state nan
[08:51:30][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:51:30][W][component:205]: Components should block for at most 20-30ms.
[08:51:30][D][sensor:093]: 'r4850 Input power': Sending state 0.00000 W with 1 decimals of accuracy
[08:51:50][D][huawei_r4850:049]: Sending request message
[08:51:50][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:51:50][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:51:50][D][number:012]: 'r4850 Max output current': Sending state nan
[08:51:50][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:51:50][W][component:205]: Components should block for at most 20-30ms.
[08:51:50][D][sensor:093]: 'r4850 Input power': Sending state 0.00000 W with 1 decimals of accuracy
[08:52:10][D][huawei_r4850:049]: Sending request message
[08:52:10][D][sensor:093]: 'r4850 Input power': Sending state nan W with 1 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Input voltage': Sending state nan V with 1 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Input current': Sending state nan A with 2 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Input temperature': Sending state nan °C with 1 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Input frequency': Sending state nan Hz with 3 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Output power': Sending state nan W with 1 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Output current': Sending state nan A with 2 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Output voltage': Sending state nan V with 2 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Output temperature': Sending state nan °C with 1 decimals of accuracy
[08:52:10][D][sensor:093]: 'r4850 Efficiency': Sending state nan % with 0 decimals of accuracy
[08:52:10][D][number:012]: 'r4850 Max output current': Sending state nan
[08:52:10][W][component:204]: Component huawei_r4850 took a long time for an operation (0.09 s).
[08:52:10][W][component:205]: Components should block for at most 20-30ms.

I'm sorry, there is still some documentation missing in this repository.
So far I have used and tested this component only with the ESP32 CAN platform and a sn65hvd230 tranceiver.
In theory it should work also with the mcp2515 platform, but I currently have no hardware to test this. I had to make some small  modifications (increase receive buffer) also on the ESP32 CAN platform because the huawei sends many telegrams at once. I guess there could be a similar issue with the mcp2515.

https://github.com/craigpeacock/Huawei_R4850G2_CAN
there has some doc for 4850can ,maybe something useful.


[Bug]: Download stuck on 9.54GB

Affected Version
1.71.6-PRE
Bug Behavior
It stuck's around 9.54GB of first package and then not let continue doing seemingly nothing cause no progress shown or i can see any activity in task manager. When restart and try to continue after some time produces unhelpful "Session has been disposed during initialization!" error.
log-2023-08-18-pre1.71.6-id1.log
DxDiag.txt
Expected Behavior
Continue download
Steps to reproduce

Start download
Wait until 9.54GB

Related Issues
No response
Screenshot(s)
https://github.com/neon-nyan/Collapse/assets/49844515/72558ac5-09b7-44c9-a447-ec639e001ffc
Additional Information
It persist in stable build as well after moving into PRE nothing changed except download progress fixed #210.
Starting over again works fine. Until stucking on 9.54GB...

Hi, thank you for submitting bug reports regarding Collapse!
While we investigate said issue, can you do a full disk check on the drive you are trying to install to?
Steps to do:

Close Collapse and other programs
Run Command Prompt with Administrator privileges
Enter this command chkdsk C: /scan /R /perf /forceofflinefix
Wait until its done and restart
Try again

Now it wont resume at all. Start over works as expected stucking on 9.54GB.

Kind of want to confirm, is there no network activity when the download is stuck?

Yes

Will ask some others to check this issue out, but for now leave it downloading like that for a couple minutes or so. In hope that its just CDN connection issue to your area

Thanks for the tip actually yesterday deleted StarRail to play some genshin. It automatically cancel download after minute or so with "[Erro]  Session has been disposed during initialization!" so it wont continue downloading even if i leave it
Ps: Project looks cool i like the UI stuff along with tools section. I wish to see brandwidth limiting but it can be achieved in other ways so it's not really worth implementing i think.

I've just thought of another idea, since some of your chunks seems to be failing to connect and download, can you try lowering your download thread to 4 or even 1?
One of our dev tried downloading GI like you just yesterday and found no issue so we are kind of leaning to connection issue in your area

It was 2 threads all the time

Will try download with aria2

Okay aria also failed to download looks like file broken

But holy with some random proxy it works again

Provider has different servers for regions?

HYV download CDN usually just Akamai CDN sitting on top of Alibaba OSS (S3 bucket), could be Akamai is having some problem in your area right now.
Closing this as identified not a Collapse issue, but feel free to chime in still or re-open the issue if for some reason the bug keeps happening.
Thank you for using Collapse!

Windows proxy hotfix
/**
 * @param {string} url
 * @param {string} host
 */
function FindProxyForURL(url, host) {
  if(url.includes("autopatchhk.yuanshen.com"))
    return "PROXY <any http/https proxy here in format host:port>"

  return "DIRECT"
}


LIVY-615: Set context path using property SERVER_BASE_PATH.

What changes were proposed in this pull request?
This pull request is to address https://issues.apache.org/jira/browse/LIVY-615
How was this patch tested?
This patch was tested using manual tests:

test using default configuration ("/") and ensure UI is accessible and sessions can be created using REST API
test using non-default configuration ("/my-livy") and ensure the same behaviour as default.

Codecov Report

Merging #188 into master will decrease coverage by 0.14%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     68.71%   68.56%   -0.15%
  Complexity      908      908
============================================
  Files           100      100
  Lines          5674     5679       +5
  Branches        854      855       +1
============================================
- Hits           3899     3894       -5
- Misses         1219     1227       +8
- Partials        556      558       +2

Impacted Files
Coverage Δ
Complexity Δ

...rver/src/main/scala/org/apache/livy/LivyConf.scala
95.85% <100%> (ø)
21 <0> (ø)
:arrow_down:

...main/scala/org/apache/livy/server/LivyServer.scala
36.09% <66.66%> (+1.12%)
11 <0> (ø)
:arrow_down:

.../main/scala/org/apache/livy/server/WebServer.scala
55.55% <80%> (+2.22%)
11 <1> (+1)
:arrow_up:

...ain/scala/org/apache/livy/utils/SparkYarnApp.scala
71.12% <0%> (-8.46%)
33% <0%> (ø)

...in/java/org/apache/livy/rsc/driver/JobWrapper.java
82.85% <0%> (-5.72%)
8% <0%> (-1%)

...c/src/main/java/org/apache/livy/rsc/RSCClient.java
75.15% <0%> (+1.24%)
20% <0%> (ø)
:arrow_down:

...c/main/scala/org/apache/livy/repl/ReplDriver.scala
33.33% <0%> (+2.56%)
7% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce266d...afde7d4. Read the comment docs.

@ajbozarth would you please help to review. Thanks!

Also @m-wcislo would you be willing to read through our discussion here and provide some insight? You originally added the feature being discussed.

Hi all, any chance this will be merged into master? We are currently using the forked branch but would prefer to use master...

Hi @ajbozarth , @jerryshao , any chance this can be included in 0.8?

Codecov Report
Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.43%. Comparing base (4d8a912) to head (8b1511a).
Report is 43 commits behind head on master.

Files
Patch %
Lines

...main/scala/org/apache/livy/server/LivyServer.scala
66.66%
0 Missing and 1 partial :warning:

.../main/scala/org/apache/livy/server/WebServer.scala
66.66%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     68.50%   68.43%   -0.07%
  Complexity      841      841
============================================
  Files           103      103
  Lines          5940     5944       +4
  Branches        898      899       +1
============================================
- Hits           4069     4068       -1
- Misses         1312     1315       +3
- Partials        559      561       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Set button type to button element

When add a map in a form,  Easy button prevent the form to submit  when user press enter in any  form input.

Thanks!


Can't receive logs from the frontend, while logs from backend work

I have installed Vercel Axiom integration into my project and wrapped my Next.js config in withAxiom.
I can see my backend logs in place, everything works there. But I can not see any frontend logs using
import { log } from `next-axiom`;

// pages/index.js
function home() {
    ...
    log.debug('User logged in', { userId: 42 })
    ...
}

Every time I trigger the log from the frontend I receive:
{
  "request": {
    "destination": "https://vercel-vitals.axiom.co/api/v1/send?
    "method": "POST",
    "path": "/_axiom/logs",
    "scheme": "https",
    "statusCode": 403,
    ...
  },
...
}

It's not the full log, but you got the problem.
I'm using Next 13. I noticed that Web-Vitals are not supported with Next 13, but frontend logging should still work, right?
Am I doing something wrong?

Same here, even tried to apply the env variables as instructed although it was a vercel deployment

@brunocangs the vercel integration doesn't require adding env variables because it already does add one NEXT_PUBLIC_AXIOM_INGEST_ENDPOINT you can remove the others if you added them and redeploy so that the env variables take effect.
@Dizotoff @MrT3313 is the same for you, you've added env variables with the vercel integration? from the error I see that you receive forbidden, which means either your token or ingest endpoint is not correct.

can you guys check again if your problem is solved? checkout @bahlo 's response on another issue that might be realted.

Having the same issue, haven't set a custom env for NEXT_PUBLIC_AXIOM_INGEST_ENDPOINT, it seems that front-end logs aren't making it through. Tried reporting via support but realised there is no support system but Discord, reported to Vercel numerous times as well.


GET query parameters are not generated

Bug Report
Description
When I pass parameters to the request, Fuel ignores it.
To Reproduce
Example from the docs:
println(Fuel.get("https://httpbin.org/get", listOf("foo" to "foo", "bar" to "bar")).url.toString())

Outputs:
https://httpbin.org/get

The real use case:
val (_, _, result) = Fuel
                    .get(
                        tokenCheckUrl,
                        listOf("access_token" to it.token)
                    )
                    .also { println(it.url.toString()) }
                    .also { println(it.toString()) }
                    .also { println(it.request.cUrlString()) }
                    .responseString()

Output:
https://www.googleapis.com/oauth2/v3/tokeninfo
--> GET https://www.googleapis.com/oauth2/v3/tokeninfo
Body : (empty)
Headers : (0)
curl -i https://www.googleapis.com/oauth2/v3/tokeninfo

Expected behavior
Query parameters are included in the request.
Environment
Development Machine

OS: macOS 10.15.3
IDE: IDEA 2020.1
Fuel version: 2.2.1
Kotlin version: 1.3.71
JVM version: 14 (OpenJDK)

I have tried it locally, with the following code:
fun main() {
    val (_, _, result) = Fuel.get("https://httpbin.org/get", listOf("foo" to "bar")).responseString()

    when (result) {
        is Result.Failure -> throw result.error
        is Result.Success -> println(result.get())
    }
}

And the result I got is this:
{
  "args": {
    "foo": "bar"
  },
  "headers": {
    "Accept": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2",
    "Host": "httpbin.org",
    "User-Agent": "Java/11.0.6",
    "X-Amzn-Trace-Id": "Root=1-5e93857c-f87cc6ec5476b00883a30a46"
  },
  "origin": "<IP_ADDRESS>",
  "url": "https://httpbin.org/get?foo=bar"
}

Which means the parameters are being correctly sent. I believe when you try to get the url from the request, it is not built with the parameters, since there is a parameters parameter inside the request class:
println(Fuel.get("https://httpbin.org/get", listOf("foo" to "bar")).parameters.toString())

Results in
[(foo, bar)]

Yes, @lucasqueiroz is right here. I do think that the request is being built correctly or else we should have a much bigger problem in the tests. 😸
Do you think this is a problem? @RankoR

Parameters are processed as a middleware. That's why it doesn't show up in .url for example.
https://github.com/kittinunf/fuel/issues/735 has some related information. That wouldn't have been possible otherwise.


Unable to set values Object types with UpgradeCommand

I am using Helm UpdateCommand to install open search helm chart but would like to override few values in values.yaml file.
e.g. I want to send list of roles, e.g master, ingest and data.
https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L16
 // Test code
 Map<String, Object> values = new HashMap<>();
 values.put("clusterName", "my-opensearch-cluster");
  List<String> roles = new ArrayList<>();
  roles.add("master"); roles.add("ingest"); roles.add("data");
  values.put("roles", roles);
  values.put("replicas", 2);
  boolean result = helmInstaller.installDataStoreHelmCharts("opensearch", "default", values);

  public boolean installDataStoreHelmCharts(String chartName, String namespace, Map<String, Object> values) {
  try {
    LOGGER.info("Installing " + chartName);
    UpgradeCommand upgradeCommand = new Helm(Paths.get(basePath, chartName)).upgrade();
    upgradeCommand = upgradeCommand.withName(chartName).install().withNamespace(namespace).createNamespace();

    // For each value in the optional values map, call the set method on the upgradeCommand object to override the
    // value in the chart's `values.yaml` file.
    if (values != null) values.forEach(upgradeCommand::set);

    // This call will actually start the installation of the chart onto the cluster.
    Release result = upgradeCommand.debug().call();

    LOGGER.info("Released   - " + chartName +" : " + "revision :" + result.getRevision());
    return true;
  } catch (Exception e) {
    LOGGER.error(e.getMessage());
    LOGGER.error("Error occurred upgrading {}: ", chartName, e);
    return false;
  }
}

getting following error,
2024-06-24 14:35:07,461 INFO  [com.esr.rea.con.ccm.ada.out.hel.HelmInstaller] (main) Installing opensearch
2024-06-24 14:35:31,824 ERROR [com.esr.rea.con.ccm.ada.out.hel.HelmInstaller] (main) template: opensearch/templates/statefulset.yaml:402:21: executing "opensearch/templates/statefulset.yaml" at <has "master" .Values.roles>: error calling has: Cannot find has on type string
2024-06-24 14:35:31,825 ERROR [com.esr.rea.con.ccm.ada.out.hel.HelmInstaller] (main) opensearch: java.lang.IllegalStateException: template: opensearch/templates/statefulset.yaml:402:21: executing "opensearch/templates/statefulset.yaml" at <has "master" .Values.roles>: error calling has: Cannot find has on type string
	at com.marcnuri.helm.HelmCommand.run(HelmCommand.java:33)
	at com.marcnuri.helm.UpgradeCommand.call(UpgradeCommand.java:56)
	at com.esri.realtime.controlplane.ccm.adapter.out.helm.HelmInstaller.installDataStoreHelmCharts(HelmInstaller.java:41)
	at com.esri.realtime.controlplane.ccm.adapter.in.HelmInstallerTest.testHelmInstall(HelmInstallerTest.java:33)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Is this possible using helm-java? Appreciate any help.

The problem is the way the value gets converted to a string.
The mechanism in the UpgradeCommand is quite simple:
https://github.com/manusa/helm-java/blob/cb98ddf91e0cbf32150e1f06c4aed7fcf6956330/helm-java/src/main/java/com/marcnuri/helm/UpgradeCommand.java#L308-L311
What you need to do is pre-convert the value to a valid String yourself.
How would you do this if you were passing the value through the command line using a --set flag?
Whatever you'd do to do that using the CLI client is what you need to do here.

Closing this issue. Thanks


Increase max runtime for agent commands

Describe the issue
INFO     🎬 ACTION (primary)
generate_graph sphinx 8435
ERROR    Read with timeout failed on input:
---
generate_graph sphinx 8435
My command may take a while (like 60 seconds), but sometimes the agent continues and does not wait if it does not generate in ~30 seconds.
Is there somewhere I can force it to wait for it?
Optional: Relevant documentation page
No response

Update to latest version and follow https://princeton-nlp.github.io/SWE-agent/config/env/

Update to latest version and follow https://princeton-nlp.github.io/SWE-agent/config/env/

I ran git pull and got a new error.
(base) nb24-12252:SWE-agent ixiong$ python run.py --model_name gpt4 --per_instance_cost_limit 2.00 --config_file ./config/default.yaml --split test --instance_filter sphinx-doc__sphinx-8506
Traceback (most recent call last):
  File "/Users/ixiong/Desktop/SWE-agent/run.py", line 44, in <module>
    from sweagent.agent.agents import Agent, AgentArguments
  File "/Users/ixiong/Desktop/SWE-agent/sweagent/agent/agents.py", line 24, in <module>
    from sweagent.environment.swe_env import SWEEnv
  File "/Users/ixiong/Desktop/SWE-agent/sweagent/environment/swe_env.py", line 23, in <module>
    from swebench.harness.constants import MAP_REPO_VERSION_TO_SPECS
ImportError: cannot import name 'MAP_REPO_VERSION_TO_SPECS' from 'swebench.harness.constants' (/Users/ixiong/miniconda3/lib/python3.12/site-packages/swebench/harness/constants.py)
(base) nb24-12252:SWE-agent ixiong$ git pull
Already up to date.

you need to update swe-bench as well or run pip install -e . on swe-agent again. This is because of #671

Ah, thanks a lot!

Hey, I feel like this isn't working as intended.
I added this AGENT_ACTION_TIMEOUT: 1080 to my keys.cfg, but it waits less than 2 minutes to run the command.
I previously had AGENT_ACTION_TIMEOUT: 240 and it was waiting the same amount of time.
My backend script is still running before the agent outputs
         generate_graph astropy 14995

ERROR    Read with timeout failed on input:
         ---
         generate_graph astropy 14995
                                          ```
So I do not think it is an error on my side.

it should be SWE_AGENT_ACTION_TIMEOUT


Beacon request method without body

Why is it that if a webpage requests an interface using beacon mode and the intercepted request does not have a body? I hope to get your help

I can't see the picture. It would be useful to include the page (URL) as well as the request where you're experiencing this.

@sunleidehao Can you provide a reproduction? It's impossible to know what's wrong from just that picture.

Not reproducible.


Sparkc 577 round three

Description
How did the Spark Cassandra Connector Work or Not Work Before this Patch
Connector was using internal serializable reps for keyspace/table metadata because corresponding Java driver classes weren't serializable.  This changed in v4.6.0.
General Design of the patch
Case classes TableDef, ColumnDef currently serve two distinct roles:

Metadata retrieval/access
As a definition/descriptor for future table creation

Majority of operations leverage the first role above.  This PR begins the process of converting these usages to the types provided by the Java driver now that they're serializable.  The existing TableDef, ColumnDef etc. case classes are preserved as-is to support future table creation.
This PR reflects only the changes necessary to support conversion of one fairly high-level class (CassandraScanBuilder).  It certainly isn't complete and the changes to various method signatures broke other things in the code which will also need to be fixed.  The intent of this PR is to demonstrate the basic process in order to get agreement on this approach going forward.
Fixes: SPARKC-577
How Has This Been Tested?
Still a WIP, hasn't been tested meaningfully yet
Checklist:

[X] I have a ticket in the OSS JIRA
[ ] I have performed a self-review of my own code
[ ] Locally all tests pass (make sure tests fail without your patch)

The goal of this PR is to demonstrate what the proposed new solution would look like in code and to get general agreement that this is what we want to do to resolve SPARKC-577.  Since the goal is demonstration and discussion this is hardly a finished product; there's plenty of re-organization and optimization that could take place here.
One example: keeping the impls of functions from TableDef/ColumnDef/etc. for Java driver metadata types in companion objects may not be ideal.  This starts to look very much like a type class, which it isn't, and that might be confusing. [1]  I could see moving these functions to a utility class somewhere perhaps.
Another example: I didn't fully leverage implicits and/or imports of object fns as broadly as possible.  Partly this was done in an attempt to get something up as quickly as possible for discussion.  It was also done because it wasn't immediately clear to me that this:
  private[connector] def querySelectUsingOnlyPartitionKeys(table: TableMetadata): String = {
    implicit val tableMetadata = table
    def quotedColumnNames(columns: Seq[ColumnMetadata]) = partitionKey.map(columnName(_)).map(quote)
    val whereClause = quotedColumnNames(partitionKey).map(c => s"$c = :$c").mkString(" AND ")
    s"SELECT * FROM ${quote(keyspaceName)}.${quote(tableName}) WHERE $whereClause"
  }

is better than this:
  private[connector] def querySelectUsingOnlyPartitionKeys(table: TableMetadata): String = {
    val partitionKeys = TableDef.partitionKey(table)
    def quotedColumnNames(columns: Seq[ColumnMetadata]) = partitionKeys.map(ColumnDef.columnName(_)).map(quote)
    val whereClause = quotedColumnNames(partitionKeys).map(c => s"$c = :$c").mkString(" AND ")
    s"SELECT * FROM ${quote(TableDef.keyspaceName(table))}.${quote(TableDef.tableName(table))} WHERE $whereClause"
  }

It might be, but that wasn't something I needed to settle in order to satisfy the goals of this PR
[1] A type class would be an interesting way to solve the problem of SPARKC-577 but it quickly starts to look quite a bit like the second solution (discrete *Def types for current + Java driver types).  That said, the difference between such an approach and this one is not.. huge.  And it seems to me that a solution based on type classes would be subject to the same objections raised to the second PR.


feat: send notifications when an alert is received

With this PR, a notification message is sent when the first alert in each event is created. The notification is sent via telegram (or another type, to be implemented if needed) to the recipients subscribed and associated to a group, and logged in the db.

add routes and tables for recipients and notifications

/quack review

Once it is deployed, we can close #263

Sorry I wasn't available to review here!
FYI, this is typically something we designed webhooks for :sweat_smile:
Meaning the webhooks would be a content (Telegram msg + recipient) and a destination (Telegram API). And in that regard, I would argue we don't need the notifications table (we could get the timestamp of an alert or add a "notification_sent_at" column) and I think the recipient table could be put in the webhook if we do this correctly.
Not a problem, but perhaps it would be helpful to consider that for the tables. The more we have, the bigger the DB, the slower the API & the tests, and the more we have to maintained :upside_down_face:
Happy to discuss this a bit later!


move daikin to package

Description:
move daikin to package to keep track of what is happening in #19182.

@MartinHjelmare

@MartinHjelmare ping


Fixes E2E test chain buffer issues on devnet

Adds a background thread to keep reading the lines even after the pattern is found to avoid buffer getting full.

Working on devnet - switching back to testnet


Improve experience for HasData with anonymous types

This involves several changes around the way missing properties and additional properties that don't match mapped properties are handled. The idea is to make it possible to detect typos, without making it necessary to specify a value for every property--since the CLR or database default may be fine.
Specifically:

When using an instance of the actual entity type, the property values for mapped properties are just used. Properties that are not mapped are ignored.
When the instance is not the actual entity type (which usually means an anonymous types) then:

If a property exists which does not match a mapped property, then a warning is generated and the value is ignored. (This helps detect typos)
Properties are missing will get the CLR default value. This is the same as would happen if an actual entity type was used. Nullable and non-nullable are treated the same way. (The CLR default for nullables is, of course, null.)
If the database has a default constraint, then the update pipeline should make sure it is used. For example, it should do the normal thing where if a value is not set, then the property is not included in the insert. fixed in https://github.com/aspnet/EntityFrameworkCore/pull/13510

@ajcvickers Why is this moved to backlog, it's impossible for postgres users to use the data seeding functionality if they use xmin for concurrency control...

@NinoFloris That issue should have been fixed by #11969. Have you tried with 2.2 preview3? If it's still failing for you, then can you file a new issue with a runnable project/solution or complete code listing that demonstrates the behavior.

Note that on the Npgsql side no preview3 was released (or, for that matter, preview2...). Since there were some breaking changes between the previews, I doubt that the preview1 of Npgsql can be used together with EF Core preview3...
@NinoFloris I'd suggest waiting until the 2.2 RTM - in any case I don't think anything can be fixed/changed on the EF Core side this late. Otherwise you can try the latest CI package from the Npgsql unstable feed.

@ajcvickers as I expected, this fix didn't help at all https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/518

@NinoFloris I filed https://github.com/aspnet/EntityFrameworkCore/issues/14161 to fix the remaining part


coordinates of Bunak Suai and Tetun T Suai to south coast

Coordinates of Bunak Suai and Tetun Terik Suai should be placed in Suai, on the south coast

I made a lexirumah-data issue out of this, because the language coordinates are in languages.tsv in that repository.


Create gitcheatsheet.md

Contributing
If you want to add a project to this list, please make sure that:

[ ] You read the contributing guide
[ ] The repository has hacktoberfest as topic and counts for hacktoberfest event
[ ] The project can't be just an "add your name" or simply + 1 contribution to hacktoberfest
[ ] Place them in alphabetical order
[ ] One repository per PR/contribution - avoid conflicts and simplify review
[ ] Your pull request is not spammy just adding an empty line, otherwise it will be marked as invalid and not count to hacktoberfest.

If they meet the requirements above, feel free to create a PR. Happy Hacking! :sparkles:

nope, read our contributing guide

ok Sorry , Can i contribute again ?


lagoon-remote: dbaas CRD installed even if dbaas is disabled

will be solved with having dbaas-operator as a subchart

will be solved with having dbaas-operator as a subchart


Is it normal that Doc.find({}) is that slow ?

Hello !
I recently switched from NeDB to LinvoDB3 for Museeks, but I have some trouble with database initial load speed.
I know why NeDB is ultra-fast, and I know Linvo is not meant to be as fast as NeDB, but I got these results (3500 documents):
Track.find({}; (err, res) => {});

Type
Size
Load speed

Library with covers
≈ 1GB
≈ 20'000ms

Library without covers
2.7MB
2461.152ms

It seems like

the size of a document influences load speed a bit
number of documents influences load speed a lot

I'm using level-js
Is this the expected behavior/speed ? or have I done something wrong ?
Would levelDB be faster ?

Yes, it would be. Which browser are you testing in?  Can you try leveldb or in-memory back-end?

@Ivshti Museeks is built with Electron 1.4 ATM

@Ivshti is that Linvo or level-js who serializes docs into JSON string?


Upgrade YAML test

Now yaml test only check yml parsing, but not the the work in general.
I think we need to add:

[ ] flags tests
[ ] options test
[ ] positionals test
[ ] requirement test
[ ] conflicts test
[ ] override tess
[ ] multiple args
[ ] takes value args
[ ] min and max values
[ ] arg group test
[ ] subcommand test

Unless I'm not understanding the question/issue, so long as the Yaml parser spits out a valid App it's good. Checking that App is doing what it's supposed to isn't the job of the Yaml tests. Similar to the soon-to-be-new macros. We just need to verify that the Yaml parser is spitting out the intended App struct with all the specific settings we wrote in the .yml
...or maybe I'm misunderstanding :stuck_out_tongue_winking_eye:

As I tried to explain the idea of test it macros PR - we can't claim that it work as it assumed.
We can say - yes, it is doing something, but can't say what it is doing.
I can agree that integration test is overkill, but we have no unit test for yaml functions. So we cant proove them working well.

We are only testing the validity, not the correctness. Currently, we have no way to tell from tests that parsing YAML will work as intended and not explode on your face.
I agree with @kbknapp that the YAML tests shouldn't check what App is doing, but I believe that we should check if YAML parsing results in intended App.
For example:
// Note: this is an over-simplified unit test example.
use super::{YamlLoader, App};

#[test]
fn parse_yaml_author() {
    let yml = "
name: claptests
author: Kevin K<EMAIL_ADDRESS>
    let app = App::from_yaml(YamlLoader::load_from_str(yml).unwrap());

    assert_eq!(Some("Kevin K. <kbknapp@gmail.com>"), app.author);
}

Both macro and yaml parsers need to have their testing done by checking that they have performed the expected builder functions against the App. @sru 's assert_eq method should work well.
For the macro case, I manually verified the generated code - it could still do with a test case; as @Vinatorul pointed out for at least regression testing.

@sru I told about something like this, but I also think that integration test is overkill.
We need to test functions like this:
https://github.com/kbknapp/clap-rs/blob/master/src/args/group.rs#L89
or this
https://github.com/kbknapp/clap-rs/blob/master/src/args/arg.rs#L164
Both false-negative and true-positive cases.

As we can see from #266 #267 #270 #271 these tests are "must have"

#270 is by design, so that's not really a bug. But yes, we should update the tests to ensure everything is good to go. ;)


Omit CTD by default

It was suggested by @IgorRodchenkov that

Most of the pathways are from CTD
Most of the CTD pathways are just one or two participants

Suggest to omit by default in the filter and allow users to add-back.

Ok I agree with doing this. Is the fact that most of these "pathways" involve only a few participants sufficient justification though? I think you told me at one point that it could be awkward to explain why we intentionally dropped CTD in code.

Well this would be taken care of by judiciously chosen default filtering I suppose. Then the small items could be displayed when user selected 'show more results' button.

That is true, almost forgot about that. If we pick to prioritise reasonably sized pathways, CTD will be dropped anyway. https://github.com/PathwayCommons/pathways-search/issues/30


Update TypeScript typing declarations

Addresses #5.

Tests are failing for reasons unrelated to this change, please see #7.

Thanks a lot for your PR!

@goblindegook : Restarted the build! https://travis-ci.org/antsmartian/preact-testing-library/builds/413346000
Looks all good.


Handling of BOM (byte order mark) in source files

Feature
PEP 263 specifies that

To aid with platforms such as Windows, which add Unicode BOM marks to the beginning of Unicode files, the UTF-8 signature \xef\xbb\xbf will be interpreted as ‘utf-8’ encoding as well (even if no magic encoding comment is given).

However, RustPython currently fails on files that include a BOM.
$ printf '\xEF\xBB\xBF' > f.py
$ cargo run f.py
SyntaxError: Got unexpected token  at line 1 column 1

^

Python Documentation
Not familiar with CPython source code, but some pointers:
https://github.com/python/cpython/blob/3.11/Lib/tokenize.py#L299 (detect_encoding)
https://github.com/python/cpython/blob/3.11/Lib/test/test_importlib/source/test_source_encoding.py

I remember encountering something like this before, in https://github.com/RustPython/RustPython/pull/3919#discussion_r923493051.

Checking whether BOM exists is needed.
But in Rust, UTF-8 BOM(EF BB BF) is recognized as FE FF when converted from bytes to String.
let utf8_bom = vec![0xef, 0xbb, 0xbf];
println!("{:?}", String::from_utf8(utf8_bom)); // Ok("\u{feff}")

Thanks for reporting this @squiddy! #4359 fixed the erroneous SyntaxError, handling of the mismatch between it and an encoding declaration that differs is not handled (and silently ignored atm) so keep that in mind.


Check whether the live manifest exists before deleting the resource

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

@nghialv
I fixed some points, so plz review again when you have enough time.

Sure!


Add Sigma Lambda Generator

Creates a generator for avaje-sigma.
Resolves #496

@rbygrave please review and deploy when you get time


Ignore unrecognised frames.

RFC 7540 says:

Implementations MUST ignore unknown or unsupported values in all extensible protocol elements.  Implementations MUST discard frames that have unknown or unsupported types.

Currently hyper-h2 contravenes this policy: it throws exceptions when it encounters unsupported frame types. This is not a good plan, especially as extension frames are in active development and could be encountered on the open web.
A good question would be: how do we handle these frames? One option is to define a new event (UnexpectedFrameReceived) that simply hands the hyperframe frame object up the stack to allow the calling code to do whatever it needs. Another option is to simply swallow all unexpected frames and not emit them to user code.
I lean towards doing the first, but I'd like to know what @Kriechi or @mhils think, as they're the most likely to be interested in actually accessing the unexpected frame data.

BTW if anyone wants to pick this up you should feel free: this is almost certainly a change that requires relatively little deep understanding of HTTP/2, which makes it a great contribution for anyone who is looking for something to do. I probably won't let this sit more than week before I work on it myself, but I'd like to give others an opportunity to do it first.

I'd like to grab this one, if I may. Given that the spec says MUST discard, I'd actually lean towards the second option, but given that the boundary of what an "implementation" is is a bit fuzzy, I'm fine the other way as well.

@haikuginger You absolutely may.
So as to doing the first or second option, I think the biggest issue is that while an implementation nominally MUST discard, it is potentially useful to be able to flag to the user that we have discarded, so they can log or do whatever is needed. The only tool hyper-h2 has to communicate this is events, so that's what we'd have to use.

Cool, so I think we have rough consensus around an event.

So, I think this is actually slightly bigger than I initially thought. Still very happy to do it, but I think there's actually work to consider in three places here.
First, in connection.py where we actually raise the exception. This is the simplest place - basically, it currently looks to determine whether the frame class is one that hyper-h2 has a defined behavior for; if not, it raises. It should be quite simple to modify this to return an event instead.
However, unless I'm misreading the code, we won't ever get to that point, because of this and this in framebuffer.py. If we get an UnknownFrameError from hyperframe, then we'll just save None as the frame - and it will be skipped over when we iterate across the FrameBuffer.
Right now, it appears that hyper-h2 implements behavior for each of the 11 types of frames that hyperframe implements; the upshot of this is that the frame data gets thrown away before hyper-h2 even gets around to parsing it in the context of the state machine- in other words, unless I'm mistaken, I don't think we'll ever raise the very nice UnsupportedFrameError we have right now in normal use. It's only reachable if hyperframe adds support for a frame type and h2 hasn't yet - which seems like a somewhat unlikely scenario, and not what we have in mind for extension frames.
What I'd like to do, once I run it past you fine folks for feedback, is to add a generic ExtensionFrame type to hyperframe - essentially, any frames that don't have a recognized identifier would be sent up as this frame type. From there, in h2, I'd just add a handler to create an UnrecognizedFrame event bearing the frame itself for use in downstream code.
@Lukasa, thoughts?

Hrm. Yeah, that's probably a good idea. That'll be a breaking change in hyperframe, and we may want to make "strict validation" a mode that hyperframe can use, but I think generally it seems like the right way to go.


Remove use of unsafe-eval

We allowed unsafe-eval in browser extension because  browserified bundle ipfs-api.min.js relies on eval. Unfortunately Mozilla does not accept extensions with unsafe-eval:

The use of 'unsafe-eval' is not allowed in the manifest.json's CSP as it can cause major security issues. [feedback from review]

[..] extensions with 'unsafe-eval', 'unsafe-inline', remote script, or remote sources in their CSP are not allowed for extensions listed on addons.mozilla.org due to major security issues.  [MDN]

We need to address it somehow.
Any ideas @ipfs/javascript-team?
Is it possible to create own bundle without eval?
We can start using webpack if needed.

Can you link to the code that is doing the eval? And what is it evaluating?

searching for eval on the min file reveals that is something that Webpack injects as part of its bundling:

Which gets in because of the script loader https://github.com/webpack/webpack/issues/4899
Investigating how to disable it (it's not actually present in our config file https://github.com/ipfs/aegir/blob/master/config/webpack.js)

https://github.com/substack/vm-browserify/blob/bfd7c5f59edec856dc7efe0b77a4f6b2fa20f226/example/run/bundle.js#L430

FYSA we need to resolve this two-three weeks before Firefox 57 is released, otherwise users will be left dry without working browser extension :(

I do not think the issue is the script-loader, I searched through all deps and it does not get installed and still eval is present in the built file.

I believe I found the offender. The shim for vm relies on eval, and it seems this is used in the dependency asn1.

Here: https://github.com/indutny/asn1.js/blob/master/lib/asn1/api.js#L21 to be exacdt

Need to think more about this, but I'm guessing that we can get rid of this https://github.com/substack/vm-browserify/blob/master/index.js#L105

Looking at this PR it seems that things should work, it will try to use the eval and fail due to csp but still work. @lidel is the issue that any warning with eval will be rejected, or did you actually experienced failures because of the csp restrictions?

Mozilla rejected our submission due to unsafe-eval in our CSP:
https://github.com/ipfs/ipfs-companion/blob/bbeaddeedf1a4781cd0dd40ba822911ee16269c9/add-on/manifest.json#L78
They may  not care if eval is in minified file  as long as unsafe-eval is removed from CSP.
Which I can't do because ipfs-api (v14.0.4)  does not work in WebExtension context without it.
It fails to load under both Firefox and Chrome:

@lidel @diasdavid I have an experimental build which should improve things, could you try this out and let me know if it helps? (based on master if js-ipfs-api)
dist.zip

@dignifiedquire  I replaced ipfs-api.min.js with index.js from your .zip and retested under Chrome/Firefox, both fail due to CSP:

Seems that src String  causes Function.apply to fail due to CSP:

@lidel you never had issues with connect-src on the CSP since you always dial to a localhost node, right?
If we were to try #248, we would need to figure out connect-src as it would block dials to WebSocket nodes.

@diasdavid correct, localhost and HTTP-only (no WSS), so there were no issues.

@lidel @dignifiedquire what's the status here, any other ideas?

No good ideas on my end, just status update:
Firefox release is blocked due to unsafe-eval in manifest.json/content_security_policy
The eval seems to be required by both js-ipfs-api and is-ipfs. Both are built by AEgir.
The best case would be to find an upstream  fix: the problem is not limited to this extension, as you've seen in  https://github.com/diasdavid/browser-laptop/pull/1#pullrequestreview-59048553 use of  eval always causes weird looks. If we could remove its use completely, that would solve us headache across all projects.
There is a possibility we could find a workaround and sandbox eval, somehow.
I did some research at https://discourse.mozilla.org/c/add-ons, but found no working solution.
I've seen some iframe-based sandboxing attempts, but as far I can read into them, they still require unsafe-eval and/or unsafe-inline.

Update: Found out the Function.apply is from generator-function, which is a dependency of https://github.com/mafintosh/protocol-buffers which we use for protobuf support. Currently working on removing the use of that library.

Step 1: https://github.com/ipfs/js-ipfs-unixfs/pull/18

Step 2: https://github.com/ipld/js-ipld-dag-pb/compare/fix/proto?expand=1

Step 3: https://github.com/libp2p/js-libp2p-crypto/pull/107

@lidel build without protocol-buffers lib and no Function.apply dist 2.zip. Want to give it another spin?

@dignifiedquire this version works without unsafe-eval in manifest.json, extension loaded and functionality seems to work fine 👍  🎉
FYI there  was one CSP error:

it was triggered by this line of dist/index.js:
var mod = eval("quire".replace(/^/,"re"))(moduleName); // eslint-disable-line no-eval

but from what I was able to check it does not impact anything we use in browser extension.
Is this eval something we need to have?
As long as we don't have t unsafe-eval in manifest.json it should pass the review at Mozilla, but if we can eliminate all uses of eval that would remove CSP errors from Browser Console.

Great to hear that @lidel. That eval is coming from our new protobuf library: https://github.com/dcodeIO/protobuf.js/issues/593 but should hopefully resolved soonish.

@lidel latest release of js-ipfs-api should be free of eval, hopefully. Please give it another try :)

@dignifiedquire The latest one at npmjs.com is<EMAIL_ADDRESS>and it still produces error due to Function.apply. I re-tested version from dist 2.zip and it still works fine.
I guess either you did not publish the latest version yet or there is some kind of regression since dist 2.zip

@lidel I was lucky with js-ipfs, you might have to do a fresh npm install and fresh npm run build with ipfs-api.

Just to eliminate possibility of me going insane 🙃
This:
curl -s<EMAIL_ADDRESS>| grep -B 10 Function.apply

returns:
var src = 'return ('+line.toString()+')'

    var keys = Object.keys(scope || {}).map(function(key) {
      return key
    })

    var vals = keys.map(function(key) {
      return scope[key]
    })

    return Function.apply(null, keys.concat(src)).apply(null, vals)

..right?

Seems something went wrong in the release, unpkg version shows Function.apply but when I build on master with fresh deps it the apply is gone

One more time 🎶

<EMAIL_ADDRESS>works indeed! 🚀

<EMAIL_ADDRESS>works indeed! 🚀

AWESOME 🎉


can't build on windows

E:\play\mcdex>go install mcdex
src\mcdex\curseforge.go:25:2: no Go files in e:\play\mcdex\src\github.com\PuerkitoBio\goquery
src\mcdex\forge.go:37:2: code in directory e:\play\mcdex\src\github.com\xi2\xz expects import "xi2.org/x/xz"

E:\play\mcdex>go get -v -x -t ./...
can't load package: package github.com/xi2/xz: code in directory e:\play\mcdex\src\github.com\xi2\xz expects import "xi2.org/x/xz"
src\mcdex\curseforge.go:25:2: no Go files in e:\play\mcdex\src\github.com\PuerkitoBio\goquery
package github.com/xi2/xz: code in directory e:\play\mcdex\src\github.com\xi2\xz expects import "xi2.org/x/xz"

E:\play\mcdex>go version
go version go1.9 windows/amd64

no idea what i'm doing. go is a mystery to me.

Hi @Spongman - I don't actually build on Windows; I cross-compile using mingw in a Docker container. That said, you need to use govendor to install the dependencies, not just go get. Does this help?

I was able to clamour my way through installing govendor and then some more headaches with gcc to compile sqlite3 and etc and got mcdex to compile (win10x64).
Then I had to mess with envion variables for JAVA_HOME and then things like mod.list was not giving any output in the command prompt window and I kinda of around that point decided "ok this wasn't really meant to run in Windows that's maybe just a consolation" and gave up.
For what it's worth, it was compileable, though.

@OrdinatorStouff @Spongman - so, I provide cross-compiled builds for all the major platforms; are those not sufficient or are you looking to be able to contribute?

The provided exe worked for me I was more curious if I could figure out how to compile on my own mostly just out of curiosity.

@OrdinatorStouff - ok. It is supposed to work on Windows (just building is really meant to be done on a cross-compiler, not native). Wrt. to mod.list not working, did you install the database? (I.e. db.update) first?

I'd like to contribute.
I'm on Windows, new to govendor, and not very experienced with make or makefiles.

 This is free software; see the source for copying conditions.
 There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
 PARTICULAR PURPOSE.

 This program built for i686-pc-msys
 PS C:\Users\lws\gits\go\src\github.com\LiaungYip\mcdex> make windows
 CGO_ENABLED=1 GOOS=windows GOARCH=386 CC=i686-w64-mingw32-gcc GOROOT=/usr/lib/go-1.8 PATH=$GOROOT/bin:$PATH GOPATH=/mcdex go install -ldflags "-X main.version=v0.7.3-0-gcf4cd02" -x -v mcdex
 go: cannot find GOROOT directory: C:\bin\DevKit\lib\go-1.8
 make.exe": *** [windows] Error 2
 PS C:\Users\lws\gits\go\src\github.com\LiaungYip\mcdex>

Okay, my $GOROOT definitely isn't in C:\bin\Devkit\lib\go-1.8 - that makes no sense.
Looks like some trouble with environment variables.
Let's try editing C:\Users\lws\gits\go\src\github.com\LiaungYip\mcdex\windows.env which looks like:
CGO_ENABLED=1
GOOS=windows
GOARCH=386
CC=i686-w64-mingw32-gcc
GOROOT=/usr/lib/go-1.8      <- Delete this line - use my normal $GOPATH
PATH=$GOROOT/bin:$PATH
GOPATH=/mcdex               <- Delete this line - use my normal $GOROOT

Try again:
PS C:\Users\lws\gits\go\src\github.com\LiaungYip\mcdex> make windows
CGO_ENABLED=1 GOOS=windows GOARCH=386 CC=i686-w64-mingw32-gcc  PATH=$GOROOT/bin:$PATH go install -ldflags "-X main.version=v0.7.3-0-gcf4cd02" -x -v mcdex
can't load package: package mcdex: cannot find package "mcdex" in any of:
        C:\bin\go\src\mcdex (from $GOROOT)
        C:\Users\lws\gits\go\src\mcdex (from $GOPATH)
make.exe": *** [windows] Error 1

Out of ideas - not experienced enough with go to figure out what's wrong here.
TL; DR: A CONTRIBUTING.md file, targeted at novice Go users (who may be on Windows), would be greatly appreciated!

I've gone back and forth about how to handle this. I don't develop on Windows, though I do test on it. If a Windows developer wants to collaborate on how to make mcdex build natively there, I'm happy to chat, but I'm not going to dig in and spend a lot of time doing that. :)
Thank you @Spongman @OrdinatorStouff and @LiaungYip for your thoughts. If you find something not working (i.e. functionality-wise) on Windows, I'd be very glad to hear about it.


Add calculation of individual steady state as mNrmSS and individual target as mNrmTrg to ConsIndShockModel

The description of mNrmSS actually corresponded to the definition of what we are now calling the "target" level of individual resources rather than what we are now calling the "individual steady state."  We have now added a calculation of the target, called mNrmTrg.

Am asking @Mv77 Mv77 to check this and let @llorracc know when he has reviewed it as a final check for bugs.
Maybe in the process he will add something to do the ".checkConditions" test for whether the conditions for existence of a target are satisfied before trying to calculate the target.

Maybe in the process he will add something to do the ".checkConditions" test for whether the conditions for existence of a target are satisfied before trying to calculate the target.

@llorracc This is done in #900. Please check to see if it matches what you wanted me to do. That PR points to the branch in this PR, so that one should be merged first.
I had to re-compute the conditions instead of using the built in checkGIC()-type methods. This is because the checkGIC()-type methods are part of the Agent object, while we do our calculations in the solver object. The solver is a property of the agent, but it has no way of accessing its encompassing agent's properties.
It might be worthwhile to find a way for the solver to know which conditions are satisfied. This seems like a big enough change in architecture that I've just recomputed the relevant factors. I can open an issue describing this inconvenience if you would like.

The reason tests are failing is that we hard-coded checking the GIC and GIC_nrm into the ConsIndShock model.
The issue is that other models like KinkedRconsumerType inherit this solver. A condition like the GIC is not easy to translate into e.g., the kinked R model, because it has multiple interest rates. So the GIC might be satisfied with some interest rate values and not others. This issue propagates to KinkyPrefConsumerType.
I could just fix it by re-defining a solver for KinkedRconsumerType that does not check the conditions. But I'd like to ask @llorracc whether the conditions have any useful translation to settings with multiple Rfrees ?

The reason tests are failing is that we hard-coded checking the GIC and GIC_nrm into the ConsIndShock model.
The issue is that other models like KinkedRconsumerType inherit this solver. A condition like the GIC is not easy to translate into e.g., the kinked R model, because it has multiple interest rates. So the GIC might be satisfied with some interest rate values and not others. This issue propagates to KinkyPrefConsumerType.
I could just fix it by re-defining a solver for KinkedRconsumerType that does not check the conditions. But I'd like to ask @llorracc whether the conditions have any useful translation to settings with multiple Rfrees ?

@llorracc whether the conditions have any useful translation to settings with multiple Rfrees ?

He says the right approach in such cases is to check if the GIC holds with the minimum Rfree. Working on a fix implementing this approach now.

@llorracc whether the conditions have any useful translation to settings with multiple Rfrees ?

He says the right approach in such cases is to check if the GIC holds with the minimum Rfree. Working on a fix implementing this approach now.

The issue is deeper than I originally thought. It's not only that the GIC is undefined in its usual form. The ConsKinkedRsolver can not re-use the mNrmSS and mNrmTrg from ConsIndShockSolver anyways, because of the multiple Rfrees.
https://github.com/econ-ark/HARK/pull/905 resolves the issue by implementing model-specific addStablePoints functions, which can be overwritten for models that inherit from ConsIndShockSolver.
For now, I have put a placeholder function that does nothing for ConsKinkedRsolver, so no stable points are computed for that model but the ones for ConsIndShockSolver (used in the BST paper, which I checked) are preserved.
This solution allows us to move forward without breaking BST and implement stable points for the kinked model once we define what they are.

The issue is deeper than I originally thought. It's not only that the GIC is undefined in its usual form. The ConsKinkedRsolver can not re-use the mNrmSS and mNrmTrg from ConsIndShockSolver anyways, because of the multiple Rfrees.
https://github.com/econ-ark/HARK/pull/905 resolves the issue by implementing model-specific addStablePoints functions, which can be overwritten for models that inherit from ConsIndShockSolver.
For now, I have put a placeholder function that does nothing for ConsKinkedRsolver, so no stable points are computed for that model but the ones for ConsIndShockSolver (used in the BST paper, which I checked) are preserved.
This solution allows us to move forward without breaking BST and implement stable points for the kinked model once we define what they are.

This is very odd.
One test seems to have failed while others passed. Looking at the error output, the issue seems to be related to ConsIndShockModelFast and threading? I find it strange that it passed the tests in all other operating systems and Windows with Python 3.6.

This is very odd.
One test seems to have failed while others passed. Looking at the error output, the issue seems to be related to ConsIndShockModelFast and threading? I find it strange that it passed the tests in all other operating systems and Windows with Python 3.6.

Needs CHANGELOG update.
Otherwise ready to merge.

Needs CHANGELOG update.
Otherwise ready to merge.

Needs automated test.

Needs automated test.

Needs automated test.
... reproduce results of BST REMARK.

Done in #923, which is a PR to this PR.

Needs automated test.
... reproduce results of BST REMARK.

Done in #923, which is a PR to this PR.

I noticed the ConsIndShockModelFast  versions should probably be edited to add these new features and fixes regarding SS vs Target.
Not sure if that would be a separate issue or if it should be fixed in this PR before merging... dealing with Numba can be like opening Pandora's box sometimes...

I noticed the ConsIndShockModelFast  versions should probably be edited to add these new features and fixes regarding SS vs Target.
Not sure if that would be a separate issue or if it should be fixed in this PR before merging... dealing with Numba can be like opening Pandora's box sometimes...

Still needs CHANGELOG and review from @llorracc

Still needs CHANGELOG and review from @llorracc

@sbenthall
OK, just pushed my changes -- seem to be various failures, let's connect tomorrow.

Fixed a few things, but still failing.  Now not immediately obvious to me why.

It looks like some of the variable and method names have been inconsistently changed.
For example, one error message is
        if GIC:
>           solution = self.addmNrmStE(solution)  # find steady state m, if it exists
E           AttributeError: 'ConsPrefShockSolver' object has no attribute 'addmNrmStE'

Chris, what's the status of this PR? I need to keep working on the release, which means merging #959
You asked me to wait for this PR to be ready before that, but that was Thursday morning.
We are running out of time.


Event: Annotate the JSON output for each field

This updates the Event struct to tag each field name with lowercase.
I am submitting this PR for two reasons:

It already looks like this was attempted here: https://github.com/amir/raidman/blob/master/proto/proto.pb.go#L16-L26
And Riemann will return these fields as lowercase in JSON over the websocket, so having the JSON version of an event match that format will make certain UI implementations easier.

Thanks!


What the purpose of AllowGlobalUpdate?

Hi @xpume
I noticed that there is a new config "AllowGlobalUpdate=true" in the latest examples, I test it but found no difference with old version. May I know what's the purpose of AllowGlobalUpdate? and when can we use it? Thank you.

Hi @rts-gordon ,
It's referring to this: https://gorm.io/docs/session.html#AllowGlobalUpdate

Hi @ktsivkov
Thanks for your reply, I read the docs and tested the new and old code, but found no difference. Can you please tell me how to build the test cases to show the difference? Thank you.

https://github.com/go-gorm/caches/blob/1b3e58f126151b57317c216804daf2018c0faed9/README.md?plain=1#L218-L236
db.Delete()returnWHERE conditions required, it's a gorm config/issue, not caches config/issue.

Hi @xpume
Got it.
Use db.Delete(&UserModel{})  and AllowGlobalUpdate=true will delete all user records, this is not safe;
maybe use db.Delete(&UserModel{Id: 123})  and AllowGlobalUpdate=false will be more safer.


Dependencies Help (react-native-svg version)

Do you have a latest readme in terms of the overall depencies and peer dependencies, seems to be having a lot of problem.  I am now npm update to @jamsch/react-native-hanzi-writer 0.40

Hi @alextaikh, I'm running this package on an Expo SDK 51 project. All you should need to do is the following to get it installed and running:
npx expo install react-native-gesture-handler
npx expo install react-native-reanimated
npx expo install react-native-svg

npm install @jamsch/react-native-hanzi-writer

If you still have problems, can you copy the error message here?


Request: How to deploy from Azure Cloud Shell

So I ran into a VPN issue I wasn't able to mitigate, but I was thinking, should this be able to be executed from Azure Cloud Shell?
I had minor success on my own, but I'm running into authentication errors when I get down to the service account UPN.
Would you guys be able to write a secondary deployment guide that leverages Azure Cloud Shell?

@bouncethebox good question, I think some updates will need to be made e.g. the pop up dialogs for the service account in order to make this run on Azure Cloud Shell.
We don't have any plans to add this directly at the moment but I will keep the request open.
What you can do is manually authenticate the API connections through the Azure portal after you have run the script - do you know how to do this?

Thanks for the reply!  I was able to deploy this through Azure Cloud Shell to circumvent a proxy server with a NoAuth rule that was killing Azure CLI login when the script ran.  Unfortunately I ran into some heavy CA policy drama, but I was able to manually authenticate and deploy most of the solution.  ACS is a great alternative for proxy servers that kill Azure CLI login/authentication.  I'll share what I have so far in this post if that is ok?

I saw this was added to the roadmap!  I'd be happy to test in the environment that caused me to ask about cloud shell deployment.


Error: building package opencv:x64-uwp failed (also x86-uwp)

-- CURRENT_INSTALLED_DIR=C:/develop/repos/vcpkg/installed/x64-uwp
-- DOWNLOADS=C:/develop/repos/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/develop/repos/vcpkg/packages/opencv_x64-uwp
-- CURRENT_BUILDTREES_DIR=C:/develop/repos/vcpkg/buildtrees/opencv
-- CURRENT_PORT_DIR=c:/develop/repos/vcpkg/ports/opencv/.
-- Using cached C:/develop/repos/vcpkg/downloads/opencv-92387b1ef8fad15196dd5f7fb4931444a68bc93a.zip
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch C:/develop/repos/vcpkg/ports/opencv/opencv-installation-options.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/develop/repos/vcpkg/ports/opencv/opencv-installation-options.patch done
-- Configuring x64-uwp-rel
-- Configuring x64-uwp-rel done
-- Configuring x64-uwp-dbg
-- Configuring x64-uwp-dbg done
-- Package x64-uwp-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:14 (message):
Command failed: C:/Program Files (x86)/CMake/bin/cmake.exe;--build;.;--config;Release;--target;install;--;/p:VCPkgLocalAppDataDisabled=true;/m
Working Directory: C:/develop/repos/vcpkg/buildtrees/opencv/x64-uwp-rel
See logs for more information:
C:\develop\repos\vcpkg\buildtrees\opencv\package-x64-uwp-rel-out.log
C:\develop\repos\vcpkg\buildtrees\opencv\package-x64-uwp-rel-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:16 (vcpkg_execute_required_process)
ports/opencv/portfile.cmake:49 (vcpkg_install_cmake)
scripts/ports.cmake:73 (include)
Error: building package opencv:x64-uwp failed
Please ensure sure you're using the latest portfiles with vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opencv:x64-uwp
Vcpkg version: 0.0.66-0d50c6704ddc563f459b901297bbb909adaa6e51
Additionally, attach any relevant sections from the log files above.

Unfortunately, the opencv portfile doesn't currently support building for UWP.
+@stammen who may be interested.

What is the error in
C:\develop\repos\vcpkg\buildtrees\opencv\package-x64-uwp-rel-out.log
C:\develop\repos\vcpkg\buildtrees\opencv\package-x64-uwp-rel-err.log

There is 123 Errors.
First one:
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\agile.h(19): fatal error C1189: #error:  agile.h can only be used with /ZW (compiling source file C:\develop\repos\vcpkg\buildtrees\opencv\src\opencv-92387b1ef8fad15196dd5f7fb4931444a68bc93a\modules\videoio\src\cap_winrt_bridge.cpp) [C:\develop\repos\vcpkg\buildtrees\opencv\x64-uwp-rel\modules\world\opencv_world.vcxproj]
         cap_winrt_video.cpp

Files in attachment.
opencv.zip

What should be done here?
Just add /ZW compilation flag for CMAKE_SYSTEM_NAME==WindowsStore?
Shouldn't CMake itself add it?

This happens for me too with Vcpkg version: 0.0.75:
Error: Building package opencv:x86-uwp failed with: BUILD_FAILED
Please ensure sure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opencv:x86-uwp
Vcpkg version: 0.0.75-cabf99d53fda160af95629f508228b47a7cf25c7
After inspecting buildtrees/opencv/config-x86-rel-err.log it looks like it fails to find the precompiled headers:
CMake Error at cmake/OpenCVUtils.cmake:911 (add_library):
Cannot find source file:
C:/vcpkg/buildtrees/opencv/x86-uwp-rel/modules/core/opencv_core_pch.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
Call Stack (most recent call first):
cmake/OpenCVModule.cmake:784 (ocv_add_library)
cmake/OpenCVModule.cmake:729 (_ocv_create_module)
modules/core/CMakeLists.txt:34 (ocv_create_module)
CMake Error at cmake/OpenCVUtils.cmake:911 (add_library):
Cannot find source file:
C:/vcpkg/buildtrees/opencv/x86-uwp-rel/modules/flann/opencv_flann_pch.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
Call Stack (most recent call first):
cmake/OpenCVModule.cmake:784 (ocv_add_library)
cmake/OpenCVModule.cmake:729 (_ocv_create_module)
cmake/OpenCVModule.cmake:942 (ocv_create_module)
modules/flann/CMakeLists.txt:2 (ocv_define_module)

This issue should be fixed. Please open a new issue if this is still a problem for you.


Change DB schema and backend to support storing a client/secret for each Endpoint

This a pull request to support storing a client_id and client_secret in the cnsis DB table. This is needed to support SSO when different endpoints have unique client/secret credentials.
Description

This PR does not make any functional changes. It allows to a different client/secret to be stored for each endpoint in the cnsis DB. Whenever logging into an endpoint, its unique client/secret is pulled from its database entry. The default client/secret is still "cf", "". So there are no breaking changes.
Motivation and Context

Required to support SSO for multiple endpoints.

How Has This Been Tested?

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] Docs update
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@nwmac ok thanks for the review. i'm looking into encrypting the client secret.

@nwmac ok made it so that it encrypts the client secret and fixed the other things

@andrewghobrial Do you still want this in V1, or given we have this in V2, can we close?

@andrewghobrial Do you still want this in V1, or given we have this in V2, can we close?

@nwmac We've fully switched to v2 so you can close this.

Fixed in V2


Check for Apereo CLA

This patch adds a bot checking if there exists an individual
contributor license agreement filed with Apereo which has the pull
request author's username attached to it.
If we want this, we should check if the GitHub user names of our regular
contributors are filed correctly since we were on Bitbucket when we
started filing them with Apereo.
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch (features can only go into develop)
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

@turro @mtneug neither of you seem to have ICLAs on file.  Please get those done and put your GitHub username on them so that this filter doesn't complain when you file PRs :)

@gregorydlogan could you check if I now successfully agreed to the ICLA or how would I check?

@mtneug not showing up yet, but I'm unsure how quickly that page updates since it's powered by an Excel spreadsheet.
To check yourself: pip3 install apereocla && apereocla -g mtneug should not spit out any errors

@mtneug, Apereo git your submission but someone has to properly file it. You will get a mail back once that's done. All filed CLAs can be found on http://licensing.apereo.org/

Adding that kind of information to the comment may make sense. Will do so later. We should also shortly discuss this at the next meeting to nor surprise people.


Text in Acknowledgements Rows

In the German translation of the current release (1.3), I can see a different text behaviour in the About -> Acknowledgements (“Danksagungen”) section. While the first row ends with an ellipsis glyph (UIKit speech: .byTruncatingTail), the others - e.g. third and last row - just happily line-break.

Danke für den Hinweis! Da hab ich wohl auch eine Übersetzung übersehen. Ich schaue es mir mal an.

Hey @Dimillian, you may take a look here: there is no truncating in makeRow but for some reason, contributor entry is truncated

Not fixed though. Anyway, I think it might be a SwiftUI bug actually and mostly I was curious. :)

I thought I fixed it... yeah so I think I have to set a width or numberOfLines I'll take another look.

Maybe the problem is, that the text fits inside the line but the > overlaps, so the word get truncated. The rows where it breaks line correctly doesn’t fit in a single line so line break is necessary.


Add .envrc to auto-source activation for vargo

This PR adds auto-activation of vargo when you enter the source directory (along with some documentation about this).
Additionally, it fixes up the activation script to prevent PATH from being updated if vargo build fails, to prevent polluting it.
Also reminder @utaal to test this on fish to make sure we don't accidentally break things; I didn't see it do anything bad in fish on my setup, but since I am not really a fish user, I don't know how people normally have it configured.

I briefly tested this on fish (which is my main shell) and it seems to work. direnv always runs the script in bash and just exports the resulting environment variables in a shell-specific way, which helps.
It is a bit verbose because every time it activates it prints the following:
direnv: loading ~/code/sw/verus/source/.envrc
building vargo
    Finished release [optimized] target(s) in 0.06s
direnv: export ~PATH ~XPC_SERVICE_NAME

but I don't think this is a big problem if you're using direnv.

Thanks folks; updated the docs, and glad to know that this Just Works^TM with fish too :)
As far as it printing output: I think this is acceptable for direnv users (they expect prints to happen whenever going into and out of directories that impact env vars). Yes we are printing a bit more than just the "PATH changed", but I think it is useful for us to not suppress the fact that a (re)build is happening.


Me conduit world crash.-- solved, update into AE-RV2

ender io's cable caused instant crash upon placing it. was starting a new system, so the cable wasn't in contact with any other block other than vanilla bricks.
i tried disabling me conduits in the enderio config but it didnt help. removing the item from the world would fix the crash i feel.. although i dont know how to remove it as MCedit (from mcedit.net) doesnt delete blocks for some reason.
Pastebin crash log
applied energistics 2-rv1-stable-1
EnderIO-1.7.10 -<IP_ADDRESS>9

#1626 #1680 #1720 #1725 #1730 #1792 #1795 #1796 #1813 #1898 #1910 #1911 #1938 #2000

i'll try downgrading into an older version just so i can fix this issue. then either keep the older version or update..
i'll post results.

You have to use EnderIO 2.2.8 build 349 or later together with AE2 rv2.

yep fixed already, also changed title to reflect solution.


Updated strings.

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3226

PR #3312   👈
PR #3280

PR #3287

PR #3279
PR #3271

PR #3272

PR #3255

PR #3256

PR #3270

PR #3230

PR #3246

PR #3248

This comment was auto-generated by Graphite.


Add a draft of a Markdown project post

This PR contains a draft post about the Markdown conversion project.

👍 Love this — really excellent writeup 🎉 Suggested a few minor copy edits — mostly just some optional commas added. (I generally favor adding commas in cases where it’s not outright wrong to add them, if they can help to prevent readers from possibly stumbling when trying to parse something — but I realize it’s sometimes a matter of personal taste…)

Thanks for the review Mike!

This got merged on the website (in development) instead: https://github.com/openwebdocs/website/blob/main/content/posts/markdown-conversion.md


Working as intended?

Hello!
I've been looking into switching over to Braintree, mainly due to Paypal not accepting DCC payments for my country (Norway).
I went through and followed your Readme, setting up the Braintree client and creating my testing payment.
I'm using the tokenization key you generate from "My account" over at Braintree.
The sandbox key works fine so I decided that since I didn't encounter any errors, I'd try the live version right out of the box.  I signed up on Briantree for a business account and generated a new live tokenization key, testing first on a credit card I know has no funds on it or insufficient funds to check my error reporting.
Payments are going through regardless if I have funds or not and it doesn't seem like I'm being charged anything from my account either.  Is this working as intended?
Log output:
payment success: {
    "threeDSecureCard": {
        "liabilityShifted": false,
        "liabilityShiftPossible": false
    },
    "type": "Visa",
    "localizedDescription": "ending in **",
    "card": {
        "network": "Visa",
        "lastTwo": "**"
    },
    "nonce": "********-****-****-****-************"
}

This is with a credit card that doesn't have any funds available what-so-ever.
What I'm seeing though is after you've scanned/typed in your card number and selected the expiration date, then proceed to click "Add Card", the drop in menu just closes and you're given the success result without even being asked for your CCV2 code.
Is this working as intended?  Is there something I'm missing or doing wrong?
I'm trying this out on Android for the record. Cordova@Android platform v6.1.2

My code for reference:
BraintreePlugin.initialize(token, function () {
    console.log('Braintree Initialized!');
}, function (error) {
    console.log('Something went wrong: ' + JSON.stringify(error, null, 4));
});

// Setup a test payment
var options = {
    amount: "1.00",
    primaryDescription: "Testing"
};

BraintreePlugin.presentDropInPaymentUI(options, function (result) {
    if (result.userCancelled) {
        console.log('Purchase cancelled!');
    } else {
        console.log('Payment accepted!');
        console.log('Payment Nonce: ' + result.nonce);
        console.log("payment success: " + JSON.stringify(result, null, 4));
    }
}, function (error) {
    console.log('Something went wrong: ' + JSON.stringify(error, null, 4));
});

I suggest you to put the presendDropInPaymentUI to the onSuccess part of the initialize call.
Once you have the payment nonce, it must be sent to braintree server by your server ( https://developers.braintreepayments.com/start/hello-server/php ) to create the transaction.
Basically on the client side you create a transaction which is approved by the user and you have to settle the transaction via your server.

Ah right, I didn't know about this at all. Thanks for clarifying that for me!
Maybe the readme should be amended to include this, for example?
Thanks again!


DEV: list of str into data

Add list of str into example data, also for test purposes.

Current coverage is 90.76% (diff: 100%)

Merging #245 into master will not change coverage

@@             master       #245   diff @@
==========================================
  Files             6          6
  Lines           552        552
  Methods           0          0
  Messages          0          0
  Branches         88         88
==========================================
  Hits            501        501
  Misses           34         34
  Partials         17         17

Powered by Codecov. Last update f36f5f8...8f79c01


New export warnings when upgrading to latest CLI - export 'PartialObserver' was not found in 'rxjs/Observer

Bug Report or Feature Request (mark with an x)
- [ x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.4.9
node: 7.4.0
os: win32 x64
@angular/animations: 4.4.6
@angular/common: 4.4.6
@angular/compiler: 4.4.6
@angular/core: 4.4.6
@angular/forms: 4.4.6
@angular/http: 4.4.6
@angular/platform-browser: 4.4.6
@angular/platform-browser-dynamic: 4.4.6
@angular/router: 4.4.6
@angular/cli: 1.4.9
@angular/compiler-cli: 4.4.6
@angular/language-service: 4.4.6
typescript: 2.3.4
Repro steps.
After upgrading to the latest CLI version I am getting this warning when serving the app with 'ng serve'
"export 'PartialObserver' was not found in 'rxjs/Observer"
the file causing the warning has..
import { PartialObserver } from "rxjs/Observer";
The app works fine, it seems... why the warning all of a sudden?

Follow up:   I downgraded to CLI version 1.4.8 and the warnings for RxJS PartialObserver went away.   Unclear if they are still there and just being suppressed , or something more substantive is at work.

Closing this as obsolete. With the latest RxJS 6.x and Angular 6.x this cannot be reproduced.


fix(utility): add lock for cached file between processes

When using PyTorch dataloader with multiple workers, the cache file will
be accessed by different processes. And the cache file can be written
and read at the same time, which would lead to the read content is
empty.
Thus, lock is added when writing the cache file to fix this
problem.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

28 of 29 (96.55%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.475%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/utility/common.py
18
19
94.74%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
7653

Relevant Lines:
8850

💛  - Coveralls


Bug: Potential Integer Overflow in debug tools Clay__IntToString function

The function Clay__IntToString(int integer) could overflow for INT_MIN due to signed integer negation (integer = -integer), possibly resulting in undefined behavior.
https://github.com/nicbarker/clay/blob/a48d40635a736a761c0cea0fa4582a30ec204676/clay.h#L2281-L2283

Hello 🙂
his seems possible but I'm not sure that the implications are so severe - this is an internal function used for the debug tools, so it appears to me that the worst case is that the debug tools display the wrong value in the interface?

I did not check in detail where this function is used, but in the current context you're right, it seems just  fine. That said, I wanted to point out at a potential problem that may arise from incorrect usage later 🙂.
Arithmetic overflow for signed integers is undefined behavior in the C standard. Depending on the compiler and platform, this could lead to more severe consequences than just displaying the wrong value in the interface, so it might be worth fixing to avoid relying on implementation-specific behavior.


Sigv4 clients blog

Edits sigv4 blog
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Closing this PR because it is made against the wrong branch.


[Question]: How does it get the address balance?

What happened?
Read notes
How to reproduce the bug
Read notes
Package Version
Current
PHP Version
Current
Which operating systems does with happen with?
macOS, Windows, Linux
Notes
How does the package check an address balance? Does it connect to a node like a bitcoin node and get the balance? If so could one choose what node to use for each chain?
Does it use an API? If so what API does it use?

It uses the official blockchain and etherscan apis.
PS: It will be great if you can ask questions using one issue, and with the correct tags. Answering the same question on multiple issues can be tiresome :))


Check OG and TC metadata

Make sure the website does open graph and twitter cards metadata correctly.

Right now these are manually added for each file using a _[page]_header.html include, and corresponding metadata in each file. Not very elegant, but it works.
I wonder if it is possible to add this info as YAML metadata and have pandoc add it to the output HTML?

Some links for trying to do this via YAML metadata:

RMarkdown custom templates https://bookdown.org/yihui/rmarkdown/html-document.html
rmarkdown::render(): https://github.com/rstudio/rmarkdown/blob/master/R/render.R; this goes to pandoc, I think
bookdown has YAML tags for SM meta tags, how is it done there? https://bookdown.org/yihui/bookdown/html.html

here's the default template, looks easy enough: https://github.com/rstudio/bookdown/blob/master/inst/templates/default.html

pandoc html template https://github.com/jgm/pandoc-templates/blob/master/default.html5
rmarkdown site generator (what I'm using): https://bookdown.org/yihui/rmarkdown/rmarkdown-site.html


Setting Up Swagger 2

When creating a REST API, good documentation is required, so setup Swagger 2 with UI plugin for a Spring REST web service.
Remember to use Springfox version :)

Feito no pull request add suport for swagger


Specify Number of Feed Items - InstagramBridge & Others

Is there some global parameter that can be used to specify the number of feed items to retrieve? Or is the number of feed items implemented by each bridge?
I was thinking about this in the context of the Instagram bridge, which I believe retrieves 10 items. I was trying to see if I can retrieve more items, like 100 or a configurable number.
Thanks

Is there some global parameter that can be used to specify the number of feed items to retrieve? Or is the number of feed items implemented by each bridge?

It is implemented by each bridge.

I was thinking about this in the context of the Instagram bridge, which I believe retrieves 10 items. I was trying to see if I can retrieve more items, like 100 or a configurable number.

The number of items returned by the bridge is only limited by the number of elements provided on the page. If I remember correctly Instagram uses lazy loading (loads more data as you scroll the page) which is not supported by RSS-Bridge.


timeline for merging pointrcnn

Hi Dr. Shi, thanks for sharing this great codebase!
I'm wondering if there is any timeline to merge pointrcnn into openPCDet.

It should be very easy to include PointRCNN / VoteNet into this repo. But the performance may still need to be carefully tuned with this new repo.
I will find time to add a simple one first.

Great! Looking forward to that~

Hi, PointRCNN has been released to this repo just now.