body() could consider the body an entire field

It would enable validating an request body like this:
["item1","item2"]. Just an array.
because there is no name, the api doens't allow the validation. body function requires always a field.
I explore other ways, like schema and seams there is no way.
It is a suggestion to improvement.

You can already do this by using body('*')

it works, but how can i validate the array length?
body('*')
.custom((item) =>
//item is every item in the array but i can't see the array
)

Well, thinking better about it, it could be desirable to do that if we consider all formats that a request body could have.

🚢 v5.1.0 released with this


Fix the Table widget

Related https://github.com/apache/skywalking/pull/12109#discussion_r1566659706
Screenshot

Signed-off-by: Qiuxia Fan<EMAIL_ADDRESS>

Could you sync the UI module?


About C3D

Hi, thank you for your awesome code.
In my research, I need to use C3D to extract features.
I noticed that you have removed C3D. Can you restore C3D  if possible? Or can you tell me the link to C3D that you have used?
Thank you very much. Looking forward to your reply.
Best wishes.

Hi, thank you for visiting my repository.
As you mentioned, I tried to extract C3D features using the codes and the pre-trained weights from here. However, when I use the features to a video captioning model, I got much lower scores than the reported ones. I could not find what the problem is and just removed the C3D codes from this repo.
If you want the code that I wrote, you can go straight to the point before the code was removed by simply typing
git checkout c91ff4045aefb0cf33b0f8567b1d714428f3a77c

Or you can see the original pytorch code that I referred to. But I recommend you to use the original one.

Thank you for your help.

Hi, thank you for visiting my repository.
As you mentioned, I tried to extract C3D features using the codes and the pre-trained weights from here. However, when I use the features to a video captioning model, I got much lower scores than the reported ones. I could not find what the problem is and just removed the C3D codes from this repo.
If you want the code that I wrote, you can go straight to the point before the code was removed by simply typing
git checkout c91ff4045aefb0cf33b0f8567b1d714428f3a77c

Or you can see the original pytorch code that I referred to. But I recommend you to use the original one.

Hi, maybe the pre-trained weights from here was trained on un-normalized data?


Where is the Delete REST API operation?

On the Delete and Recover Packages page, there is a note that:

Azure DevOps and Visual Studio Team Foundation Server interpret the nuget.exe delete command as an unlist operation. To delete a package, you must use the REST API or the web interface.

There isn't a link to the delete operation within the note, and I am unable to find a Delete operation on the Artifacts API page.
Where can I find documentation on the Delete REST API operation?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 31a8d31b-229b-7383-1cc0-f3d7c65eca84
Version Independent ID: 70ba7acf-adae-e1b7-a42d-3f1344c5293c
Content: Delete and recover packages - Azure Artifacts
Content Source: docs/artifacts/how-to/delete-and-recover-packages.md
Service: azure-devops-artifacts
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

@smaglio81 Thanks for your feedback! Here is the api ref to delete: https://learn.microsoft.com/en-us/rest/api/azure/devops/artifactspackagetypes/nuget/delete-package-version?view=azure-devops-rest-7.0
I'll add it to the docs


Products/Open Source Software

The text and the icon should be vertically centred in the first section.

Confirmed


Pass acceptSslCerts to bootstrap on start

Proposed changes
Fix acceptSslCerts capability for android browser
PR for https://github.com/appium/appium/issues/7326
Linked PR: https://github.com/appium/appium/pull/7325
Details
Android driver must pass this.acceptSslCerts as third argument of this.bootstrap.start

@jlipps can you revalidate PR, please?

Looks good now!

published in 1.10.37


Setup the input and output for the whole project in Python

Inputs
In terms of input we are talking about a grid like this:
[] [] [] [] []
[] [] [] [] []
[] [] [] [] []
[] [] [] [] []
[] [] [] [] []
with letters in there!
Output
In terms of output we are looking at this:

word-1
word-2
word 3
etc.

Conclusion
I'll setup the script for "reading" input and to output a proper list of words when calling the main function

Now I need to setup the loading of the grid-like data into some sort of data structure.
I think that a better data format in the .txt file would be:
x,x,x,x,x
x,x,x,x,x
x,x,x,x,x
x,x,x,x,x
x,x,x,x,x

IDEA: Might be interesting to have a separate function which only takes care of the solving of the boggle game board


Release cassandra v3.11.4-0.1.0 (automated commit).

Looks good now @kensipe.

nice work! Please add a link to the README in the root of the repo


User Story - Add List

As a computing student, I can see a list of internships that I have applied, so that I can keep track of which companies/roles I have applied for

Existing feature from AB3


Text color in About page does not consider dark mode

Overview (Required)
textColor for the texts in About page refers directly to color resources, so their color does not change according to the change of  the app's theme.
Steps To Reproduce

Go to 'Settings'
Set theme to 'Dark'
Go to 'About'

Expected behavior
Text color should be changed corresponding to selected color theme; i.e. use theme's color attribute for the value of textColor.
Screenshots

Light
Dark

Env:

Device: Pixel3
OS: 10
App Version or the branch [e.g. 0.1.0 or master]: master

Thanks for reporting!

I could fix it.
The color of version number text was not destined, so I use white in dark mode.
May I make PR with this result?

Light
Dark

@clockvoid 🙆


What is your terminal config?

I like your terminal config on screens. Could you please share it?

ok, I will update my terminal config on readme doc.

Thanks!


suggestion

Nice work. but i would to see the use of images, instead of discord links.

Nice work. but i would to see the use of images, instead of discord links.

Hey, there is images if you look in the description it says preview

Nice work. but i would to see the use of images, instead of discord links.

Hey, there is images if you look in the description it says preview

There is yes, but there discord linked images instead of in the folder.

Ps, I hope you do a spawn in the same theme.

That’s my next task on the list I dunno when I’ll be starting it but I’ll have a think mate

That’s my next task on the list I dunno when I’ll be starting it but I’ll have a think mate

I'll close this, but make sure to update your girhubs to the new logo, as they don't show up now you have removed them from discord. Looking ftro a spawn theme may with a something other then a zoom effect.


refactor: :construction: refactor wrap text (and working on renderEle…

The goal of this PR is refactor the wrapText method and others related features (like container resize and fill text).

[x] refactor the wrapText method to imitate the behavior of text area

[x] refactor wrap text
[x] update tests

[x] refactor fill text with same proposal

[x] refactor horizontal offset

[x] optimize

Regarding the wrapText method I prioritized code readability over efficiency, I broke this method in three parts:

wrapText function: split text in "hard lines returns" and then use breakLine function on each trimmed line that does not fit in container.
breakLine function: its like wrapText but with words*, use breakWord function on each trimed word that does not fit in container
breakWord function: break words 😂

Word*: its not a regular word, rather I want to refer to word with trailing spaces
'My cat is pooping' -> ['my ', 'cat ', 'is ', 'pooping'] (whit spaces) like textarea when a word is selected with Ctrl+Shift+Right Arrow
In this issue #4997  i explain why i try  to copy the textarea behaibor

@ignacio-cuadra how about targetting one thing at a time ? so Only text-wrap refactor in this PR so its easy to review and test as well.

@ad1992 the new wrapText dont remove the trailing spaces, the spaces are controlled at draw the text. Because of this, it is necessary to rewrite code on renderElements file. But yes, textWysiwyg can be refactored in another PR.

@ad1992 the new wrapText dont remove the trailing spaces, the spaces are controlled at draw the text. Because of this, it is necessary to rewrite code on renderElements file. But yes, textWysiwyg can be refactored in another PR.

Sounds good 👍🏻
Since both of us will be touching the same files and I have couple of PRs in progress so we might have conflicts once PRs are merged, In any such case I will help resolve them :)

@ad1992 could you guide me a little?
on test "Test wrapText" defines a font "20px Cascadia, width: Segoe UI Emoji", this font its working on testing? i am confused by the test outputs

I updated the tests.
considering that each character is equal to 10 pixels, and the container has a padding  of 5px on each side, the previous tests were wrong. Also, I added the spaces because the new functionality doesn't remove them.
(but im not sure about textWysiwyg tests)

Edit: is it possible to use faker.js or something like that? I didn't dare to install it without asking. 🫣

sure, go ahead!

I updated the tests.
considering that each character is equal to 10 pixels, and the container has a padding of 5px on each side, the previous tests were wrong. Also, I added the spaces because the new functionality doesn't remove them.
(but im not sure about textWysiwyg tests)

@ignacio-cuadra don't worry about the specs, once the PR is ready I will take a look at the tests.

I updated the tests.
considering that each character is equal to 10 pixels, and the container has a padding of 5px on each side, the previous tests were wrong. Also, I added the spaces because the new functionality doesn't remove them.
(but im not sure about textWysiwyg tests)

@ignacio-cuadra don't worry about the specs, once the PR is ready I will take a look at the tests.

@ad1992 and/or @dwelle
Would you please check the functionality? (no the code for now, I'm still working to optimize it)

ok, i'm done for now.
About performance, the code is 2~ times slower than the previous code, but it does not affect the user experience. I could try to improve the performance but it would affect the readability of the code.
@dwelle i found this: Intl Segmenter. that fix the emoji problem but it's not supported by Firefox (and I couldn't find a polyfill)

@ignacio-cuadra thanks for the PR!
Doing quick testing on the PR and here are some issues I came across
Try editing text / resize you will see some displacement of text
https://user-images.githubusercontent.com/11256141/216585306-cff8ec48-d38d-4fd8-ab73-57d2aa2eba2e.mp4
{"type":"excalidraw/clipboard","elements":[{"id":"lXYpOynzXh0DcLgrQFQsn","type":"rectangle","x":356.5,"y":347.13671875,"width":143,"height":135,"angle":0,"strokeColor":"#000000","backgroundColor":"transparent","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"groupIds":[],"roundness":null,"seed":47641214,"version":939,"versionNonce":1541651874,"isDeleted":false,"boundElements":[{"type":"text","id":"OnjPDQ12ZftCY08oEUeFd"}],"updated":1675421195571,"link":null,"locked":false},{"id":"OnjPDQ12ZftCY08oEUeFd","type":"text","x":361.5,"y":377.13671875,"width":133,"height":75,"angle":0,"strokeColor":"#000000","backgroundColor":"transparent","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"groupIds":[],"roundness":null,"seed":1580386274,"version":960,"versionNonce":326755710,"isDeleted":false,"boundElements":null,"updated":1675421195572,"link":null,"locked":false,"text":"       hello \nworld.        ","fontSize":20,"fontFamily":1,"textAlign":"right","verticalAlign":"middle","baseline":68,"containerId":"lXYpOynzXh0DcLgrQFQsn","originalText":"       hello world.        "}],"files":{}}

The horizontal alignments/ resize don't work well with the below container
{"type":"excalidraw/clipboard","elements":[{"type":"rectangle","version":231,"versionNonce":1206824876,"isDeleted":false,"id":"LxFWgJcMPMJOV2fQeXHTq","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"angle":0,"x":364.23046875,"y":215.677734375,"strokeColor":"#000000","backgroundColor":"transparent","width":183,"height":91,"seed":2018276578,"groupIds":[],"roundness":{"type":3},"boundElements":[{"type":"text","id":"INf4OcweQC6-CoYviQBGp"}],"updated":1675421413935,"link":null,"locked":false},{"type":"text","version":415,"versionNonce":995856916,"isDeleted":false,"id":"INf4OcweQC6-CoYviQBGp","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"angle":0,"x":374.23046875,"y":256.677734375,"strokeColor":"#000000","backgroundColor":"transparent","width":173,"height":50,"seed":1485521470,"groupIds":[],"roundness":null,"boundElements":null,"updated":1675421419113,"link":null,"locked":false,"fontSize":20,"fontFamily":1,"text":"     hello world.      ","baseline":43,"textAlign":"right","verticalAlign":"bottom","containerId":"LxFWgJcMPMJOV2fQeXHTq","originalText":"     hello world.      "}],"files":{}}

https://user-images.githubusercontent.com/11256141/216586670-40e0d973-f127-42af-bd31-c07598620441.mp4
To confirm the goal of this PR is to imitate text area behavior (in relation to whitespaces) correct?
Asking this as there are other issues where wrapping algo doesn't reflect the text area wrapping (I am planning to fix those myself as well) so just wanted to know if those are targeted in this PR, eg
Try editing the below element and the wrapping is not in sync
{"type":"excalidraw/clipboard","elements":[{"id":"ADAeb1A25mBlMlyHEFID7","type":"rectangle","x":529.5,"y":200.55078125,"width":97,"height":200,"angle":0,"strokeColor":"#000000","backgroundColor":"transparent","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"groupIds":[],"roundness":null,"seed":271338260,"version":157,"versionNonce":491842988,"isDeleted":false,"boundElements":[{"type":"text","id":"xGatyhLnAg9RBunzxHpjf"}],"updated":1675422190975,"link":null,"locked":false},{"id":"xGatyhLnAg9RBunzxHpjf","type":"text","x":534.5,"y":250.55078125,"width":87,"height":100,"angle":0,"strokeColor":"#000000","backgroundColor":"transparent","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":1,"opacity":100,"groupIds":[],"roundness":null,"seed":2303916,"version":153,"versionNonce":1321145108,"isDeleted":false,"boundElements":null,"updated":1675422190975,"link":null,"locked":false,"text":"Here I \nam 👋🏻🚀 \n🔥👋🏻 \n😀🥳","fontSize":20,"fontFamily":1,"textAlign":"center","verticalAlign":"middle","baseline":93,"containerId":"ADAeb1A25mBlMlyHEFID7","originalText":"Here I am 👋🏻🚀 🔥👋🏻 😀🥳"}],"files":{}}

Same with this as well
{"type":"excalidraw/clipboard","elements":[{"type":"rectangle","version":529,"versionNonce":2128371431,"isDeleted":false,"id":"ELbJD506EyC6cFn8MUIqo","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":0,"opacity":100,"angle":0,"x":219,"y":186,"strokeColor":"#364fc7","backgroundColor":"transparent","width":240,"height":210,"seed":1291590823,"groupIds":[],"roundness":null,"boundElements":[{"type":"text","id":"Xzvha2xkG6NQN-erKno1E"}],"updated":1675330100833,"link":null,"locked":false},{"type":"text","version":585,"versionNonce":1888385223,"isDeleted":false,"id":"Xzvha2xkG6NQN-erKno1E","fillStyle":"hachure","strokeWidth":1,"strokeStyle":"solid","roughness":0,"opacity":100,"angle":0,"x":226.00000000000009,"y":191,"strokeColor":"#364fc7","backgroundColor":"transparent","width":226,"height":200,"seed":635348297,"groupIds":[],"roundness":null,"boundElements":[],"updated":1675330102964,"link":null,"locked":false,"fontSize":20,"fontFamily":1,"text":"Hello there whats \nup?dskdjskdjskdjskjdsk\ndjskdjskdskdjskdjksdksj\ndkjskdsdjsjdksjdkskdjsk\ndjsjdksjdsjdjskjdksdjksj\ndksjdsddsdadasdadad\nasdsdasdadadadadas\ndsada","baseline":193,"textAlign":"center","verticalAlign":"middle","containerId":"ELbJD506EyC6cFn8MUIqo","originalText":"Hello there whats up?dskdjskdjskdjskjdskdjskdjskdskdjskdjksdksjdkjskdsdjsjdksjdkskdjskdjsjdksjdsjdjskjdksdjksjdksjdsddsdadasdadadasdsdasdadadadadasdsada"}],"files":{}}

To confirm the goal of this PR is to imitate text area behavior (in relation to whitespaces) correct?

Yep, that's what i'm trying to do.
I think that some issues are due to the textarea doesn't use the "bound text padding". But there is something else.
I will work on this, thanks for the review.

@ad1992
Hi, i have been working on this and my conclusion is that it's necessary to use Intl.Segmenter to fix emojis problem (and other issues related to "complex characters"). This solution shouldn't be a problem but firefox does not support them.
Exists a pollyfill Intl Segmenter Polyfill that works fine, but requires load a .wasm file that weighs 1.30MB
Do you have any idea?

@ad1992
Hi, i have been working on this and my conclusion is that it's necessary to use Intl.Segmenter to fix emojis problem (and other issues related to "complex characters"). This solution shouldn't be a problem but firefox does not support them.
Exists a pollyfill Intl Segmenter Polyfill that works fine, but requires load a .wasm file that weighs 1.30MB
Do you have any idea?

@ignacio-cuadra I am not sure which issues are you talking about with complex characters - but in my last comment what I meant is the first two issues that are breaking in the PR and work fine in prod so those surely need to be fixed.
As per the remaining ones, since that is not part of this PR, I will be picking it up soon so those can be skipped as I will be rewriting some parts of wrapping algos to fix those along with a few other issues.
As per Intl.Segmenter that can wait since those are specific cases so once text editor is strong enough we will come back to this.
So right now once those two blocking issues are fixed, we can start the code review.

@ignacio-cuadra once I merge this, the tests might need to get updated in your PR as now we will be moving to canvas measurements completely so mocking measureText for DOM methods will not be needed.

@ignacio-cuadra I was reviewing the code, can we split this into two PRs?

With only Refactoring for better readability (should work the same as prod)
With the bug fix for whitespace which you are targeting in this PR.

I was doing the refactor as I need it in another PR as well but since you have done refactoring in this PR hence wanted to know if you are fine splitting this into two PR.
As per the time complexity, I would still want to try to reduce it to the same as is currently in prod :)
Let me know If I can go ahead with refactoring in a separate PR or if would you like to split yourself.

Hi, I'm sorry, I was working on other projects and forgot this one.
About your comment, yeah, it's a good idea but how can I split this PR?
should i create another PR with wrapText refactor?
I could use cherry pick or copy-paste... (i will use copy-paste definitely xD)

Hi, I'm sorry, I was working on other projects and forgot this one.
About your comment, yeah, it's a good idea but how can I split this PR?
should i create another PR with wrapText refactor?
I could use cherry pick or copy-paste... (i will use copy-paste definitely xD)

Yep Copy Paste will be better to use as the PR isn't up to date with master :D

Closing in favor of https://github.com/excalidraw/excalidraw/pull/8530


Feature/fix exposed port

The documentation in the README.md says that the image is intended to run a unison server on the internal port 5000. However the container as built is exposing port 500.

thanks!


Tiles wont load (503 error)

When zooming in beyond ~16, tiles disappear. Console log says it is a 503 error. Specific area of interest is Utah, USA.
Example:
http://maps.stamen.com/#toner/18/40.73312/-111.89760

This seems to be resolved.


[index] fix pushed conflict

Conflict in the index file was accidentally pushed. This fix removes the conflicts.

/lgtm


Add support for linux-musl-s390x target

A while ago we added support for the linux-s390x target (https://github.com/ericsink/SQLitePCL.raw/issues/426).   At that time, we did not yet have support for .NET on Alpine on our architecture, but in the meantime this is available as well.  And it turns out there is also interest in using SQLitePCL.raw on that OS - but this is currently not working, see e.g. https://github.com/dotnet/efcore/issues/32209.
It seems the binaries built against glibc crash when run on Alpine (which uses the musl libc).  I see that SQLitePCL.raw contains binaries built against musl for many Linux platforms.  When adding a similar build on s390x, the crashes go away in local testing.  I'm opening this issue to request adding that support to the upstream build, and will post PRs against this repo as well as cb shortly.

This was included in 2.1.7, which has been pushed up to nuget.


VadimVildanov/HW5

I have a question. Your code better than my variant? Can I fix my code when you merged?


No courses found

Udeler | Udemy Course Downloader
1.13.0
Account Type?
Business
Steps to reproduce
1 ) When logged in through the access token, I was successfully logged in but there were no courses that i have enrolled to download
2) I read one of the issues where you said  "first you need to activate the business option, fill in the subdomain and then enter the token" https://github.com/heliomarpm/udemy-downloader-gui/issues/134#issuecomment-1603306255, I did that but I see an error now rather than logging in which says
.:: AxiosError ::.
Network Error

✔ Expected Behavior
Will be great to downloand udemy business videos
🔍 Additional context
Trying to download the courses from a business account

I no longer have a business account to test this, but testing with my personal account I can connect using token normally.
If you can send me your token and subdomain in your personal email, I can quickly identify what may be happening.
Please let me know if you decide to send me the information here, so I can check my emails.

Sorry

@heliomarpm i have also same issue no course found in personal plan subscription account.
i sent you email also kindly check and help if you want token i can help you to give it.

Mr. Vick?

check the new version, please

check the new version, please

Hi @heliomarpm, I just tried the latest version and I was able to login and see all the courses that I have been enrolled but upon clicking download, I get
Download Failed
Click to retry

Screenshots and log below,

Hi @santhoshn24
I solved a problem like this in version 1.13.1. I'll see if I have any more courses in my account to test.
I lost my access to the business account, so it's difficult to find and fix these problems.

@heliomarpm thanks and let me know next time if you get this to work, Appreciate your efforts, Many Thanks.

see a new version

@heliomarpm Thanks again, the downloading tries to start but the ones that I need are DRM protected, so doesnt go through.
Contains DRM protection and cannot be downloaded Click to dismiss
Are all videos on Udemy DRM protected?

@heliomarpm Thanks again, the downloading tries to start but the ones that I need are DRM protected, so doesnt go through. Contains DRM protection and cannot be downloaded Click to dismiss
Are all videos on Udemy DRM protected?

Hi @santhoshn24, unfortunately many are protected, but fortunately some are still possible to download in full.
You can try with https://github.com/Puyodead1/udemy-downloader


Refactor Refactor the scanner scheduler code make return error msg means

Proposed changes
Before error msg：
Failed to submit scanner to scanner pool

After error msg:
Failed to submit scanner to scanner pool reason:Scan thread pool had shutdown|type 1

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Feature: Display thumbnails of bookmarks inside a folder instead of an icon

Is it possible to display thumbnails of bookmarks in a folder instead of the usual folder icon? For example, this is done in Opera or Vivaldi, and it looks more intuitive than just colorful icons.

Thank you for the suggestion. At this time I don't plan to add that as a feature.


Crossselector layout fix

PR to address #499 including button positioning:
Before:

After:

@philippjfr Rebased against master and now the tests are green. Ready to merge?


ResponseFactory missing file()

Laravel Version: 5.4.*
PHP Version: 7

Description:
ResponseFactory seems to be missing file()
Steps To Reproduce:
Do something like response()->file('myfile.txt'). The interface is missing the file method.

You can use response->download() for this. :)

Not a bug. Can be closed

This is a bug, as Illuminate\Routing\ResponseFactory itself has file() method, but Illuminate\Contracts\Routing\ResponseFactory hasn't.
And there is info in docs about the difference between download() and file() methods.


stlink: fix retries on DP/AP WAIT errors.

Memory accesses send the command, then get the result with get_last_rw_status(). We were retrying only getting the status. We have to retry the command as well.
This fixes SwdDpWait errors when flashing stm32c0 chips.

@noppej done


AMBARI-23300. Install Wizard/Customise Services clear filters button i…

…s not visible while input is focused
What changes were proposed in this pull request?
Install Wizard/Customise Services clear filters button is not visible while input is focused
How was this patch tested?
manually (styles issue)
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1265/
Test FAILed.
Test FAILured.


TLS/SSL encryption for Postal smtp

Hello, can someone here help me on how to install ssl/tls encryption for postal smtp please? Thanks very much

You need to supply these config values including a path to a certificate file.
https://github.com/postalserver/postal/blob/9f0697f194209f5fae5e451ba8fb888413fe37fa/config/postal.defaults.yml#L68-L70

Thank you, i will do this and give feedback

@fav22 their is some thing you need to notice to get this work and their are many discussions about it
I think postal dont support implicit TLS (the realy secure TLS) but only explicit TLS (STARTTLS). Or am I wrong @willpower232?

Sorry for re-opening this, but what cert do I need for the smtp.cert and smtp.key? I tried copying the one Caddy was using but it seems that isn't correct. Do I just generate a new cert  with certbot for the root domain postal is hosting on and use that?

If you rummage through the issues here, you'll see that there is a way to asking Caddy to create certificates using RSA which allows you to reuse the same certificate file.
As these certificates are regenerated every few months, there is a need to restart Postal at some point before the certificate expires and after the certificate has been automagically replaced.

If you rummage through the issues here, you'll see that there is a way to asking Caddy to create certificates using RSA which allows you to reuse the same certificate file.
As these certificates are regenerated every few months, there is a need to restart Postal at some point before the certificate expires and after the certificate has been automagically replaced.

Is there a chance you can send me the issue? I'd love to be able to do exactly this bu t couldn't find that issue.

I think I saw it first on https://github.com/postalserver/postal/discussions/1572


Timeout while solution import

Hey we are using a d365 onpremise version and trying to use your addon to automate realeases. Thererfor we added the step import solution to our realease pipe. But each time the step we get the following output:
Solution Name:  Fundraising
Solution Version:  <IP_ADDRESS>
Solution not currently installed
But after that nothing happens and the step is stopped after x minutes. When I m importing the solution manually everything works fine.
Any ideas?

Hey,
I'm workin on this issue withg @alan50
This is the Verbose output:
2018-08-15T08:59:29.6511080Z Solution not currently installed
2018-08-15T08:59:29.6541125Z ##[debug]Importing Solution: XXXXX...solution_managed.zip
2018-08-15T08:59:29.6646134Z ##[debug]Current Security Protocol: Ssl3, Tls, Tls11, Tls12
2018-08-15T08:59:29.6668327Z ##[debug]Modified Security Protocol: Ssl3, Tls, Tls11, Tls12
2018-08-15T08:59:29.6689264Z ##[debug]Connecting to CRM [attempt 1]
2018-08-15T08:59:29.6723570Z ##[debug]Importing Solution: XXXXX...solution_managed.zip
2018-08-15T08:59:29.6747554Z ##[debug]Setting Default SleepInterval: 15
2018-08-15T08:59:29.6768237Z ##[debug]ImportJobId 461c1fd2-7adc-4a09-8948-XXXXXXXX
2018-08-15T08:59:48.5889795Z ##[debug]Sleeping for 15 seconds
2018-08-15T08:59:48.6815576Z ##[debug]StatusCode: 10
2018-08-15T09:00:03.6895619Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:00:03.7450923Z ##[debug]StatusCode: 10
2018-08-15T09:00:18.7588674Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:00:18.7938708Z ##[debug]StatusCode: 10
2018-08-15T09:00:33.7983237Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:00:33.8235938Z ##[debug]StatusCode: 10
2018-08-15T09:00:48.8460712Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:00:48.8851815Z ##[debug]StatusCode: 10
2018-08-15T09:01:03.9004369Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:01:03.9398015Z ##[debug]StatusCode: 10
2018-08-15T09:01:18.9574871Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:01:18.9821582Z ##[debug]StatusCode: 10
2018-08-15T09:01:33.9888789Z ##[debug]Sleeping for 15 seconds
2018-08-15T09:01:34.4687546Z ##[debug]StatusCode: 10
2018-08-15T09:01:34.4966231Z ##[debug]Caught exception from task script.
2018-08-15T09:01:34.5008571Z ##[debug]Error record:
2018-08-15T09:01:34.7185280Z ##[debug]Import-XrmSolution : Import Timeout Exceeded: 120

We modified the ImportSolution.ps1 so that the -ImportAsync parameter is set to $false and this worked with the same solution / environment.
HoldingSolution $holdingSolution -ImportAsync $false -WaitForCompletion $true -ImportJobId $importJobId -AsyncWaitTimeout $AsyncWaitTimeout  -Timeout $Timeout -Verbose
Could you add a parameter to the task so that we can make the import alwas run synchronously?

P.S.: The successful import attemt after modifiing the ImportSolution.ps1 only took 28 seconds so it is not a timeout issue.

@alan50 @mpseidel I happen to know recently that there are some small differences at the MS backend in the way solutions are imported.
Were you importing a solution that contain system user and ribbon changes by any chance?
I could add sync import option although this may give you some other issues at some point as in many cases I have seen the servers get too busy at some point and the connection is dropped.

@WaelHamze Our solution contains some entities, global optionsets, javascript resources, images, plugins and the sitemap.
And yes i agree with the mentioned concerns, especially when solutions grows bigger...

The latest version support Sync import and you can configure the connection timeout and the wait timeout for both Sync and Async


SparsePauliOp causes bugs in e.g. commutators.

Information

Qiskit Terra version: 0.18
Python version: 3.8
Operating system: MacOS

What is the current behavior?
The SparsePauliOp does not handle coefficients correctly or is used against its specification in opflow. With the help of @Cryoris we noticed the following:
>>> SparsePauliOp(Pauli('iZ')) == SparsePauliOp(Pauli('-iZ'))
True
>>> SparsePauliOp(Pauli('iZ')) == SparsePauliOp(Pauli('Z'))
True

which is probably the root of the problem with, e.g., the commutator below.
Steps to reproduce the problem
X
Out[189]: PauliOp(Pauli('X'), coeff=1.0)
Y
Out[190]: PauliOp(Pauli('Y'), coeff=1.0)
v = commutator(X,Y)
v
Out[192]:
PauliSumOp(SparsePauliOp([[False, False]],
              coeffs=[0.+0.j]), coeff=1.0)
v.equals(2j*Z)
Out[193]: False

The same problem occurs by a direct calculation:
w = X@Y - Y@X
w
Out[205]:
PauliSumOp(SparsePauliOp([[False,  True],
               [False,  True]],
              coeffs=[ 1.+0.j, -1.+0.j]), coeff=1.0)
w.equals(2j*Z)
Out[206]: False

What is the expected behavior?
>>> SparsePauliOp(Pauli('iZ')) == SparsePauliOp(Pauli('-iZ'))
False
>>> SparsePauliOp(Pauli('iZ')) == SparsePauliOp(Pauli('Z'))
False

Or handling it differently in opflow.

Following up from a discussion with @chriseclectic, the solution is probably just to replace SparsePauliOp with PauliList in opflow. @ikkoham since you know these classes the best, could you maybe have a look? 🙂

Yes. This will fix this issue. https://github.com/Qiskit/qiskit-terra/pull/6826

The PR linked above doesn't fix the issue as described above since the comparison of the commutator (as a PauliSumOp) doesn't work with the reference 2j *Z (as PauliOp). Is this something we want to support?
With #6826:
>>> (X@Y - Y@X) == PauliSumOp(SparsePauliOp.from_list([('Z', 2j)]))  # both are PauliSumOp
True
>>> (X@Y - Y@X) == 2j * Z  # left one is PauliOp
False

Hi, thanks for the fix. I checked, it seems it should work now. For me it's important that it does not produce 0 but a valid answer. The type is not crucial.


Track accuracy during training

Hi,
Is it possible to easily track the train/val accuracy during training?
Thanks.

@netw0rkf10w You turn on the debug flag in the config file to track current recall and average recall.


How to remove the bot ?

Have you tried something like this?

Yeah, its still keep sending messages had to block it !


BloxStrap Is Acting Strange For Me :(

So i just downloaded bloxstraps today and, i opened studio (i only downloaded this program because it "makes the graphics better in roblox studio). I open up studio, open up a game, and all the rigs that are in the game, have parts in them, i dont know why, theres a part, on each part of the rig, like glitched inside of each of the parts. And I deleted BloxStrap hoping this would be fixed but it didnt fix the issue i have. If anyone knows how to fix what problem im having please tell me. i dont want to see parts on each part in my rigs (the normal R6 and R15 rigs)
:((

You should ask this somewhere else since this has nothing to do with Bloxstrap. It does nothing with studio whatsoever.


Support mongodb?

I just tested this shema:
datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

model User {
  id              String                 @id @default(auto()) @map("_id") @db.ObjectId
  name            String
}

It return error:
error: Error parsing attribute \"@default\": The function auto is not a known function.

Does this support mongo?
Sorry for my bad english, btw.

I've tried updating the prisma engine that's used to parse the schema under the hood, but that doesn't work either. I don't think this will support MongoDB, then.


refactor!: restrict function scope of DataApp lifecycle methods

Purpose
The previous definition of DataApplicationContextualOps was shared between L0 and L1 services which led to metagraph developers needing to provide implementations for functions that were not invoked by the underlying TessellationIOApp. For example, Data-L1 nodes were forced to provide definitions for combine and validateData but these methods are only invoked for L0 nodes. This led to dummy implementations being provided simply to satisfy inheritance constraints for all Data Applications such as Dor.
This PR introduces SharedContextualOps, L0ContextualOps, & L1ContextualOps to restrict the scope of contextual operations to the layer where they are needed. This allows for metagraph developers to avoid the dummy implementations that were previously needed.
Changes

Updates dataApplication package definitions to distinguish between shared, L0, & L1 contextual operations
Updated unit test mocks and integration test implementations for CurrencyL0 and CurrencyL1

Testing

All unit tests passing locally
A metagraph-example was modified to depend on the updated DataApplication and compiled successfully
verified expected behavior of an end to end example will be performed to ensure expected behavior

This is in draft until two questions can be answered

What is the scope of the new validateFee, estimateFee, & extractFee functionalities? I made my best guess but if @AlexBrandes @ryle-goehausen or @sdavidp may be able to provide further clarity
This may be a breaking change for some metagraphs (if they have used the override modifier) but it is not obvious to me how this should interact with the conventional-commits ADR we've been discussing recently.

Re. 1 - I think you don't need to provide a scope for this. The scope is optional, so the current commit name looks okay for me.
Re. 2 - If this is a breaking change, you should mark it by an exclamation mark. Anyway, worth checking (@IPadawans maybe?) if this is truly a breaking change. We change our internal representation only, so it should be backward compatible for metagraphs at first glance.

Latest push follows the usage of the newest fee functionality to define the following

validateFee as a shared operation

invoked by Engine and DataApplicationRoutes on L1
invoked by DataApplicationSnapshotAcceptanceManager on L0

extractFees as a L0 specific operation

invoked by DataApplicationSnapshotAcceptanceManager on L0
not invoked by L1

estimateFees as a L1 specific operation

invoked by DataApplicationRoutes on L1
not invoked by L0

I've also completed the end-to-end example with the todo metagraph and verified the expected behavior of the data application state updates (i.e. state updates are still processed successfully)

I forgot to answer here but yes, this is a breaking change and we maybe should hold this until the hackathon ends

@scasplte2 @IPadawans AFAIK we won't release anything new to intnet or mainnet, so I think it's safe to merge it to develop. We have fee transactions on the develop as well, that are not ready for intnet/mainnet release. WDYT?

@marcinwadon @AlexBrandes This PR was built atop the fee-transaction changes to Data Apps so I've cherry picked the commit and updated the base of this PR to target feature/fee-transaction. It is simple enough to create another branch with the changes only applicable to develop if we would like to pull in this refactor before the fee-transaction branch.


BIGTOP-3305. Bump Flume to 1.9.0.

This will conflict with the patch of BIGTOP-3285 since this includes the change to the version of Kafka. I will rebase this once BIGTOP-3285 is done.

I rebased this since BIGTOP-3285 was committed. The unit tests of flume-kafka-source are passed with the patch even kafka.version is 2.4.0 (instead of 2.3.1) on my local.

+1, successfully built on CentOS 7 & 8, Debian 9 & 10 and Ubuntu 16.04 & 18.04. It also passed the smoke test.

Thanks, @sekikn!


chore: Update embano1/wip action

Description
Update embano1/wip to v2.
Closes: #(issue-number)
Type of change
Please mark options that are relevant:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

[ ] Test Description 1
[ ] Test Description 2

Test Configuration:

Toolchain:
SDK:
(add more if needed)

Checklist:

[ ] My code follows the contribution
guidelines
of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@lamw PTAL


Validate IncidentUpdate's incident_type field against the retrieved incident type.

The IncidentUpdate's incident_type field is an IncidentTypeBase, which does not have an id field. Thus, the initial id comparison resulted in an error.
However, earlier in the incident_service.update() function call, the incident_type is already retrieved. We can perform the comparisons against this object's id.

I believe the error occurs on incident_in as well:
  File "/Users/wshel/Projects/dispatch/src/dispatch/incident/service.py", line 369, in update
    if incident_in.incident_type.id != incident_type.id:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IncidentTypeBase' object has no attribute 'id'

I believe the error occurs on incident_in as well:
  File "/Users/wshel/Projects/dispatch/src/dispatch/incident/service.py", line 369, in update
    if incident_in.incident_type.id != incident_type.id:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IncidentTypeBase' object has no attribute 'id'

This works for me locally:
    # Update total incident reponse cost if incident type has changed.
    if incident_type.id != incident.incident_type.id:
        incident_cost_service.update_incident_response_cost(
            incident_id=incident.id, db_session=db_session
        )


Invalid port error

Confirm this is an issue with the Python library and not an underlying OpenAI API

[X] This is an issue with the Python library

Describe the bug
Hi, When I run the following code, one error raises, any thoughts?
from openai import OpenAI
client = OpenAI(api_key="XXXXX")

Raising error:
Traceback (most recent call last):
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_urlparse.py", line 339, in normalize_port
    port_as_int = int(port)
ValueError: invalid literal for int() with base 10: ':1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tiger/.local/lib/python3.9/site-packages/openai/_client.py", line 106, in __init__
    super().__init__(
  File "/home/tiger/.local/lib/python3.9/site-packages/openai/_base_client.py", line 758, in __init__
    self._client = http_client or SyncHttpxClientWrapper(
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_client.py", line 682, in __init__
    self._mounts: typing.Dict[URLPattern, typing.Optional[BaseTransport]] = {
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_client.py", line 683, in <dictcomp>
    URLPattern(key): None
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_utils.py", line 397, in __init__
    url = URL(pattern)
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_urls.py", line 113, in __init__
    self._uri_reference = urlparse(url, **kwargs)
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_urlparse.py", line 246, in urlparse
    parsed_port: typing.Optional[int] = normalize_port(port, scheme)
  File "/home/tiger/.local/lib/python3.9/site-packages/httpx/_urlparse.py", line 341, in normalize_port
    raise InvalidURL("Invalid port")
httpx.InvalidURL: Invalid port

To Reproduce
from openai import OpenAI
client = OpenAI(api_key="XXXXX")
Code snippets
No response
OS
unbuntu
Python version
python 3.9
Library version
openai 1.6.0

What is the value of your OPENAI_BASE_URL environment variable, or that of other related env vars?

Hi were you able to fix this?

downgrade httpx from 0.27.0 to 0.23.3 can fix the problem. Ref: https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/10149


Large medata files are illegible in the table view

When using a large (~200 columns) table for the supplement, the table view is illegible.

Resolution: The table will only show the first 10 columns of a dataset. Additional columns may be added/removed in the settings modal. Fixed by b3483479ca4377f6d36d16fb3338457af3462e0a


Fix function comments based on best practices from Effective Go

Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name ({{funcName}}) being declared.
From effective go.
PR generated by CodeLingo. Install here to drive Continuous Higher Standards.

Nope.

Hi there!
Dan from CodeLingo here. This PR is testing out a new service. I'd love to hear your feedback or answer your questions. We're keen to learn how we can best help dev teams without getting in your way.
Dan & the CodeLingo Team

Um, comments should be normal English sentences. Having Foo: It does this. is not beneficial or better.


fix(aws-sdk): add http status code attribute to aws sdk span if aws sdk v3 client exception occurs

Which problem is this PR solving?
Fixes https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2343

Upon AWS SDK (v3) Client exceptions, AWS SDK V3 Span will not record http.status.code attribute into the span.

For comparison, AWS SDK V2 Span already does record and expects this attribute.

Short description of the changes

Record http.status.code attribute into the span upon client exceptions for AWS SDK V3 Spans.

Testing

Updated Unit Tests to check for http.status.code attribute

Pinging @blumamir for approval and merge.

Thanks you @jj22ee for the contribution.
Please fix the linting so I can merge.
npm run lint:fix

@blumamir done!


Just questions

If there is a better place to ask these questions, like a forum, please point me to it.
I have successfully installed a docker version of Let's Chat and am running it.
I successfully registered and logged in.
Questions:

How do I make myself an administrative user?
Is there UI Admin? Am I not seeing it because I'm not yet an admin user?
Is there more documentation on the user side for Let's Chat anywhere?

Thanks

As is happens, there is no admin system built into Let's Chat. Using LDAP authentication you could use an LDAP administration tool (I am currently using this tactic for this), but nothing exists natively.
You are welcome to create one yourself or spread the news to other node.js developers; as it stands there is no one dedicated to creating an admin.
As for documentation, this is as close as it gets. Thankfully Let's Chat is very intuitive.


Fix: context.namespace use the namespace from override policy

Signed-off-by: Somefive<EMAIL_ADDRESS>Description of your changes

context.namespace use override namespace when rendering component and trait
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

I want to make sure it,  the defination of context.namespace in cue.context has changed from app's ns to pod's ns ? @wonderflow

@fourierr Not exactly, the context.namespace is the namespace of component, in this PR, it will align to component which is affected by the override policy.

@fourierr Not exactly, the context.namespace is the namespace of component, in this PR, it will align to component which is affected by the override policy.

you are right, but the context.appNamespace is useful to trait cr, trait cr has been created in app's ns for more convenient management.

@fourierr By default, the trait will be created in the app namespace, so it's not necessary to use context.appNamespace.


Resize column not working if there are hidden columns

When hiding some columns, then if you try to resize a column that is on the right from those, the table is not taking in count the hiding ones to make the resize.
Here is a demo where you can see that
https://codesandbox.io/s/material-table-starter-template-forked-m05mdr?file=/src/index.js
To Reproduce

Hide some columns, e.g. Word & Word 1
Resize column Word 2
See, table is trying to resize the columns Word & Word 1:

This should be fixed with the next release. Thanks for finding this.

Almost there! Thanks for solving it
I'm getting this on v4.3.41 when I tried to resize the column that is on the left than a hidden column
TypeError
Cannot read properties of undefined (reading 'tableData')
    at handleMouseDown (https://m05mdr.csb.app/node_modules/
[material-table/core/dist/components/MTableHeader/index.js:99:88]()
    at onMouseDown (https://m05mdr.csb.app/node_modules/
[material-table/core/dist/components/MTableHeader/index.js:276:20]()
HTMLUnknownElement.callCallback
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:149:14]()
Object.invokeGuardedCallbackDev
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:199:16]()
invokeGuardedCallback
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:256:31]()
invokeGuardedCallbackAndCatchFirstError
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:270:25]()
executeDispatch
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:561:3]()
executeDispatchesInOrder
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:583:5]()
executeDispatchesAndRelease
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:680:5]()
executeDispatchesAndReleaseTopLevel
[https://m05mdr.csb.app/node_modules/react-dom/cjs/react-dom.development.js:688:10]()

@emikira should work with the latest. But maybe you have another edge case ;)


Fix reversed priorities

Current dependencies on/for this PR:

main

PR #580   👈

This stack of pull requests is managed by Graphite.


Client secret for native apps?

'Make sure that you chose WEB APPLICATION AND/OR WEB API if you did not you will not see the keys option under settings.'
What about native apps? I have embedded the Power BI reports in my application. In my backend application (native app), i need to access the Key Vault but there's no option of getting a client secret for native apps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 259ba844-605a-90de-611b-86be48852d5a
Version Independent ID: 093cdacd-b58d-bb93-61b2-0bf731f14648
Content: Get started with Azure Key Vault
Content Source: articles/key-vault/key-vault-get-started.md
Service: key-vault
GitHub Login: @barclayn
Microsoft Alias: barclayn

@ramandeep-singh-1983 While we don't specifically go over native applications in the get started article we do have a blog post from one of the Key Vault PMs covering this scenario. https://blogs.technet.microsoft.com/kv/2016/09/17/accessing-key-vault-from-a-native-application/ We are always updating the documentation and this scenario is part of the items we hope to address in the next couple of months as part of the documentation. In the time being, I hope the blog post helps you move forward with your application.

sounds good, thanks! I was able to integrate the KeyVault using the new managed identity stuff but i will check out the link you have shared.

#please-close

@ramandeep-singh-1983 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

Hi, I was hoping you could point me towards some clarification on the article you linked to?
(https://blogs.technet.microsoft.com/kv/2016/09/17/accessing-key-vault-from-a-native-application/)
after going through the setup, I'm not quite clear on what I should pass as the resource parameter to the AcquireTokenAsync... I tried with with a number of names and ids for what I assumed it could be referring to but I keep getting an invalid_resource exception...
It's also not clear what the authority parameter is, though I believe I am getting that one.
:
:
/// Get AAD token
var context = new AuthenticationContext(authority, TokenCache.DefaultShared);
var result = await context.AcquireTokenAsync(resource, clientId, new Uri(clientRedirectURI), new PlatformParameters(PromptBehavior.Always));
Thank you so much

ok, I got it...
the resource is "https://vault.azure.net"
I assumed it was the URL of my specific vault that I created...


bug: ChainMismatchError: Chain mismatch: Expected "Chain 11155111", received "Sepolia".

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.0.5
Current Behavior
ChainMismatchError: Chain mismatch: Expected "Chain 11155111", received "Sepolia".
Expected Behavior
Expected to return data
Steps To Reproduce
const eip712Domain = {
  name: "EIP712Domain",
  fields: [
    { name: "name", type: "string" },
    { name: "version", type: "string" },
    { name: "chainId", type: "uint256" },
    { name: "verifyingContract", type: "address" },
  ],
} as const;

const eip712Order = {
  name: "Order",
  fields: [
    { name: "registry", type: "address" },
    { name: "maker", type: "address" },
    { name: "staticTarget", type: "address" },
    { name: "staticSelector", type: "bytes4" },
    { name: "staticExtradata", type: "bytes" },
    { name: "maximumFill", type: "uint256" },
    { name: "listingTime", type: "uint256" },
    { name: "expirationTime", type: "uint256" },
    { name: "salt", type: "uint256" },
  ],
} as const;

const types = {
  EIP712Domain: eip712Domain.fields,
  Order: eip712Order.fields,
} as const;

const domain = {
  name: "Wyvern Exchange",
  version: "3.1",
  chainId: BigInt(11155111),
  verifyingContract: WYVERN_EXCHANGE_ADDRESS,
} as const;

const order = {
  expirationTime:<PHONE_NUMBER>0n,
  listingTime: 0n,
  maker: "0xF94dA6DB1D41ad4279A6DaeB523aCc6dE7D91626",
  maximumFill: 1n,
  registry: "0x9771Ea8Ee3a2dad16c75957e5a4bf6125b90301B",
  salt:<PHONE_NUMBER>n,
  staticExtradata: "0x0000000000000000000000001954191b259fa13b52c688641a8f56f60bc18bd8000000000000000000000000b06d49f3fa3c02a170d99d09ce0e74aab0ab710700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  staticSelector: "0x837b54ad",
  staticTarget: "0x1E8fFDD440c366bD783A3d82Cc3cf2Af30a64280",
};

const {
    data,
    signTypedData,
    error,
  } = useSignTypedData({
    domain,
    types,
    primaryType: "Order",
    message: order,
  });

I get the error when i call the "signTypedData()"
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?

Remove the BigInt() wrapping chainId.

Thank you for your response @tmm .  I removed the BigInt and my Metamask freezes and unresponsive untill I reload it. Also, why does the useSignTypedData cast uint256 to bigint instead of number.

Because uint256 max range exceeds the bounds of a safe max number value.

Thanks, @jxom. How do I go about the unresponsive metamask when I call the signTypedData function?


I encounter error said OSError: Unable to open file (file signature not found)

Hello,
Thank you for sharing nice code. I finished training model using 'python train_music.py' command. I can check several checkpoint file was generated under 'checkpoints_music' folder.
Then, I tried to load one of them to generate music using 'python generate_music.py 1 /media/kimbring2/Steam/transformer-xl/checkpoints_music/optimizer1.npy' and met error of title.
I am not sure what is a problem. How can I solve that problem?
It is also good idea you share one of checkpoint of your side.
Thank you

Oh,


Rename synacormedia adapter to imds to reflect ownership change

This renames the synacormedia adapter to imds while allowing existing implementations to continue using synacormedia. This also updates the features in the documentation to reflect what's already supported in the current master.
🏷 Type of documentation

[x] new bid adapter
[x] update bid adapter
[ ] new feature
[x] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked
[x] For new adapters check submitting your adapter docs

https://github.com/prebid/prebid-server/pull/2508
https://github.com/prebid/Prebid.js/pull/9381

There's already a stub adapter in the attached code pull requests, so I think I'll just remove the aliasCode.

@ecammit - actually, the code PR sets synacormedia as an alias. This isn't going to work for new versions. I suggest adding the following to the header
pbjs_version_notes: use imds after 7.X

I assumed you meant a literal 7.X. If you don't, let me know and I can try to update it last minute to whatever the latest 7.x version is. One of the code branches was recently reviewed and is blocked, so I don't know what version this will sneak into at the moment.

thanks - you're right that the 'X' should be resolved once we know what actual version it's in

Looks like this is going to end up being in prebid 8. I'm going to gamble and say it'll make 8.0.0 and update this commit with that.


PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoe…

…nix-client

Final version has been merged to master.


Add support for multi-flags

I hadn't spotted this PR when I responded to your issue - thanks for this

Looks like it's not so straightforward - will have to queue this for a proper look

This does not address the issue I raised. The issue applied to lambdas. This PR is about flags that map directly to a variable.


Page count missing in pagination

We have started to use new pagination variant and found out that it's missing page count and current page. Can this be added? Looks like the space is there. What do you think about adding it in between pagination arrows?

@rachael-phillips this has low prio and is nice to have.


Integration into OSS-Fuzz

Hi
I have integrated fuzzing into spotify-json and was thinking that it would be nice to set up continuous fuzzing by way of OSS-Fuzz. In this PR: https://github.com/google/oss-fuzz/pull/5014 I have done exactly that, namely created the necessary logic from an OSS-Fuzz perspective to integrate. In that PR you also see the fuzzer attached, but it would be nicer to have the fuzzer integrated into the upstream project itself rather than keeping it in OSS-Fuzz - so if this PR gets merged I will remove it from OSS-Fuzz
Essentially, OSS-Fuzz is a free service run by Google that performs continuous fuzzing of important open source projects. The only expectation of integrating into OSS-Fuzz is that bugs will be fixed. This is not a "hard" requirement in that no one enforces this and the main point is if bugs are not fixed then it is a waste of resources to run the fuzzers, which we would like to avoid.
If you would like to integrate, could I please have an email(s) that will get access to the data produced by OSS-Fuzz, such as bug reports, coverage reports and more stats. Notice the emails affiliated with the project will be public in the OSS-Fuzz repo, as they will be part of a configuration file and they also need to be linked with a Google account to get the detailed reports.
David

Hi David,
Thanks for contributing. Let's give this fuzzer thing a try, shall we. :-)
You can set up my email<EMAIL_ADDRESS>as the one to receive the reports.
This JSON library is not widely used outside Spotify, but we run it in all our clients and also in certain backend services, so running a fuzzer on it definitely seems interesting.

Sorry for the late reply and merge. I'm on parental leave, so didn't check my email for some time.

Hi David,
Thanks for contributing. Let's give this fuzzer thing a try, shall we. :-)
You can set up my email<EMAIL_ADDRESS>as the one to receive the reports.
This JSON library is not widely used outside Spotify, but we run it in all our clients and also in certain backend services, so running a fuzzer on it definitely seems interesting.

Awesome - we are now waiting for the components to be merged in the OSS-Fuzz repository and once that is merged fuzzing will start :)!

Sorry for the late reply and merge. I'm on parental leave, so didn't check my email for some time.

That's wonderful, congratulations and enjoy the rest of your parental leave.


Update plugin-publish plugin

Hiya, I was doing a scan of the Gradle Plugin Portal and noticed you are using an old version of the plugin-publish-plugin.
There was a bug in versions prior to 0.9.7, where artifacts would silently not be pushed into the repo, which means the latest version of your plugin will not work properly when people apply it to their build.
Upgrading to the latest version of the plugin-publish-plugin will fix this, but this will require pushing a new version of your plugin.

apply the PR
publish a new version of your plugin
let us know if you want us to remove the broken version 0.12

Thanks (and sorry about that).
Let us know here or in the forums if you need more assistance.

@timyates Thank you for finding this and the PR that fixes it.
I'm not too familiar with how the plugin repository works, but will I be able to republish without you removing the broken version first?If not, please go ahead and remove it and I will republish the version.

It won't let you republish an identical version, I'd have to remove it first...  One sec, I'll get it done, and let you know when you're good to go 👍

Cool, that's 0.12 removed, can you try re-publishing?

@timyates Thank you. I have republished 0.12 using the updated plugin.

Cool!  Checked it, and it resolves perfectly now 😄
Thanks!  And have fun!


Testing iron form inside custom element Polymer 2.0

Good afternoon,
I'm new to web component tester and I was trying to do the following:
I've created an polymer element called personal-info, which consists of a form (iron-form) with some input fields(paper-input) and a button (paper-button). It's a simple element to register a user. Now when I'm pressing the button to submit, I let my form validate() my input fields, which works great when I'm trying it in my polymer project! However when I try to test if my form is valid in a test case the iron-form validate function throws an error. From which it seems some parts of the iron-form are not correctly initialized.
I think this might be a bug in web component tester, maybe only for paper-input and iron-form.
I included the test file and element. I hope someone can take a look at this or explain me if I'm doing something wrong :)
Thanks in advance!
Test file:

<!doctype html>

  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, minimum-scale=1, initial-scale=1, user-scalable=yes">

  <title>Personal Info</title>

    <link rel="import" href="../src/register/personal-info.html">

  <test-fixture id="personal-info-fixture">
    <template>
      <personal-info></personal-info>
    </template>
  </test-fixture>

Custom element:

<link rel="import" href="../../bower_components/polymer/polymer-element.html">
<link rel="import" href="../../bower_components/paper-input/paper-input.html">
<link rel="import" href="../../bower_components/paper-button/paper-button.html">
<link rel="import" href="../../bower_components/iron-form/iron-form.html">

<link rel="import" href="../shared-styles.html">

<dom-module id="personal-info">
  <template>

      <iron-form id="registeraccount">
        <form method="get" action="/form/handler">

Registreren

          <paper-input label="First name" auto-validate required pattern="[a-zA-Z]*"  error-message="Enter a valid first name e.g. 'Wilson'" name="firstName" value="{{firstName}}"></paper-input>
          <paper-input label="Last name" required auto-validate pattern="[a-zA-Z]*" error-message="Enter a valid first name e.g. 'Clarence'" name="lastName" value="{{lastName}}"></paper-input>
          <paper-input id="email" label="Email" required auto-validate pattern="[^@]+@[^@]+\.[a-zA-Z]{2,6}" error-message="Enter a valid email address e.g<EMAIL_ADDRESS>name="email" value="{{email}}"></paper-input>
          <paper-input label="Phone number" required auto-validate pattern="[0-9]*" name="phoneNumber" error-message="Enter a valid phone number" value="{{phoneNumber}}"></paper-input>
          <paper-input label="Password" required auto-validate name="password" type="password" error-message="Password needs to be filled in." value="{{password}}"></paper-input>
          <paper-button id="registerButton" style="float: right;display:block;" on-click="register">Registreren</paper-button>
        </form>
      </iron-form>

  </template>

</dom-module>

I found the following:
When I remove the <test-fixture> and <template> it works as I would expect. The problem then remains that it doesn't reset the element after a test.
Do I need to post this issue in test-fixture Github?


nixos/nftables: add release notes for checkRuleset option

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[X] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Thanks!

Nooooo.

I think the phrasing is reasonable. Feel free to re-adjust though.

We really should mention the feature first, and then tell them about the knob they can use to work around problems.

IIUC, that is what I have done in this PR.

I think what @mweinelt thinks is more like "In this release nftables build-time syntax checking was added. It can be disabled with option X"


fix: concurrently --kill-others flag

What: fixes concurrently --kill-others flag typo

Hey! Thanks for this! Don't worry about the broken build. That's unrelated stuff. Would you like to add yourself to the contributors table?

updated the outdated addContributor command, and added myself as a contributor :)

Actually, could you rebase your changes? Sorry! Things have been kinda weird because of that bug

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #110   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         286    286
=====================================
  Hits          286    286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d0729...33cc9a6. Read the comment docs.

done; removed the --kill-others flag typo fix commit


Helpful updates

Hi,
Great work with this project! I've based a custom Qube driver for my home automation project (pimatic, nodejs based) on your work here and I thought I'd contribute my findings. I managed to get everything working with multiple bulbs and working flawlessly with HomeKit :)
You can change the turn on/set rgbw state byte (2nd byte) to 0x11 (instead of 0x01) to enable gamma correction.
(this is what the android app does)
In addition, the first byte of set_rgbw can be set to transition the colour instead of a rather crude change.
Setting a value of (0x53) followed by duration makes a much cleaner change.
Here is an example (trial an error, hoping its correct)
[0] =0x53 <- MASK_AFTER_STATE & MASK_RATE_OF_CHANGE & MASK_COLOR1 & MASK_STATE
[1] = 0x11 <- LED_STATE_ON & LED_STATE_OPTION_USE_GAMMA_CORRECTION
[2] = red
[3] = green
[4] = blue
[5] = white
[6] = 0 // Duration start
[7] = 0 // Duration
[8] = 0x02 // Duration
[9] = 0x26 // Duration end -> 550ms
[10] = 0x01 // after state (AFTER_STATE_PERSIST)
From the android APK classes I can see the following flags. I haven't really tested them all but good to know
public static final int AFTER_STATE_PERSIST = 1;
public static final int AFTER_STATE_REVERT = 0;
public static final int AFTER_STATE_TURN_OFF = 2;
public static final int AFTER_STATE_TURN_ON = 3;
public static final int LED_STATE_CANDLE = 2;
public static final int LED_STATE_FLICKER = 4;
public static final int LED_STATE_GLOW = 3;
public static final int LED_STATE_OFF = 0;
public static final int LED_STATE_ON = 1;
public static final int LED_STATE_OPTION_OVERWRITE_DEFAULT_START_COLOR = 32;
public static final int LED_STATE_OPTION_USE_GAMMA_CORRECTION = 16;
public static final int LED_STATE_TRI_FLICKER = 6;
public static final int LED_STATE_TRI_GLOW = 5;
private static final int MASK_AFTER_STATE = 64;
private static final int MASK_COLOR1 = 2;
private static final int MASK_COLOR2 = 4;
private static final int MASK_COLOR3 = 8;
private static final int MASK_DURATION = 32;
private static final int MASK_RATE_OF_CHANGE = 16;
private static final int MASK_REVERT_RATE = 128;
private static final int MASK_STATE = 1;

Do you guys know if there's an API documentation for the bulbs?
Or did you reverse-engineer all this stuff?
I'm interested in controlling the bulbs over WiFi & Node.js. But apart from this repo, I haven't found that's helpful.

Im not sure if you can connect to the bulb directly with wifi.
There is no documentation that I know of at present.
The android app seems to use the Qube AWS services when on Wifi, or use bluetooth LE when not connected.

Oh, I hope there is a way to use the bulb without their servers, otherwise the bulb would be useless if they go out of business and shut down their servers :S
I've sent them an email. Maybe they answer..

I had an email conversation with them.
There is indeed currently no TCP or UDP API that could be used.
So the only way to control the bulb over WiFi is the app, which makes it useless for my purposes.
But they are still working on the bulbs and are even able to patch their firmware to add new features. So it's still possible that they will add such an API.
They are focusing on IFTTT and Amazon Echo first, though, so it won't happen soon.

Yeap got a response from them too.
They don't allow wifi access to the bulb at the moment.
We can figure out their entire Cloud API hosted on amazon by looking at their android app, but thats slow because it requires the bulbs and our automation systems to have an internet connection.
I've got my nodejs driver pretty stable and integrated with a pimatic plugin + homekit using BLE. I haven't tested thoroughly with disconnects/reconnects but overall it works great and its fast.
Maybe I'll clean it up and release it as a separate project, but im hoping Qube releases a properly documented (local) API.
I have a feeling they will only release a Cloud API though.

I have the same feeling. And it would be pretty sad...
I've found out, that the bulbs, when connected to a wi-fi, establish a websocket connection to ws://sock.qube-smarthome.com:3002, and then agree on an encryption mechanism in plain text. After that, all messages are encrypted.
I've set up a local DNS server, that resolves sock.qube-smarthome.com to my local computer, which ran a websocket server that proxied the messages, to find this out.
I think it won't be possible to imitate an official qube-server. We'd most likely need their key for that.
I'm not sure, though. But yeah, all I'm going to do now is wait & hope they'll release a local API..

@VanCoding just FYI, me and a friend managed man-in-the-middle the app and create a very basic Python library to control them, but it still goes via the Qube servers until they release an official API, but it works. https://github.com/Azelphur/qube-api

@jimpastos Did you figure out what gamma correction actually does? When I was testing I seemed to get better whites with it turned off, but it wasn't clear to me what exactly it was doing.

Im not exactly sure, but there were a few articles describing why its done on RGB LEDs to make colors look more realistic.


Azcopy Release pipeline

Created release pipeline which is responsible for
Stage 1: Build binaries for Linux, Mac, Windows
Stage 2: Sign the binaries and packages
Stage 3: Test artifacts of Linux, Mac, Windows
Stage 4: Release to public container(linux, mac,windows), github(linux, mac,windows) and packages.microsoft.com(linux and mariner)
Sample Pipeline Run: https://dev.azure.com/azstorage/AzCopy-NextGen/_build/results?buildId=22060&view=results
Packages release to public container: https://ms.portal.azure.com/#view/Microsoft_Azure_Storage/ContainerMenuBlade/~/overview/storageAccountId/%2Fsubscriptions%2Fba45b233-e2ef-4169-8808-49eb0d8eba0d%2FresourceGroups%2FXClient%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Fazcopyprivatedrops/path/releases/etag/"0x8DB86D2AF30CD5B"/defaultEncryptionScope/%24account-encryption-key/denyEncryptionScopeOverride~/false/defaultId//publicAccessVal/None
Sample Github Release: https://github.com/dphulkar-msft/azure-storage-azcopy/releases

@gapra-msft @adreed-msft @vibhansa-msft @souravgupta-msft
Could you please provide your approvals if there are no further comments?


Include ability to specify .cer certs in addition to .p12 certs in iOS build

Currently if developing in Windows for iOS, the process for converting .cer files to .p12 files is somewhat cumbersome and requires running openssl or something similar.  It would be nice if app center allowed the uploading of .cer files (the way Apple provides them) in addition to .p12 files.

Thanks for the feature request @jefffhaynes! Definitely can see how this would be helpful for those developing using Windows.


[Bug Report]: Getting a 404 on login page since 21.11

Describe the Bug
I tried updating to version 21.11.2, but when accessing the site and it redirects to /bookstack/login it shows "Page Not Found".
Bookstack is running in kubernetes and i am using the linuxserver images. From a few tests i found out:
does not work
ghcr.io/linuxserver/bookstack:version-v21.11
ghcr.io/linuxserver/bookstack:version-v21.11.2
ghcr.io/linuxserver/bookstack:version-v21.11.3
works
ghcr.io/linuxserver/bookstack:version-v21.10.1
ghcr.io/linuxserver/bookstack:version-v21.10.3
thanks.,
Steps to Reproduce
change version from 21.10.x to 21.11.x
Expected Behaviour
Login page to be displayed
Screenshots or Additional Context
No response
Exact BookStack Version
21.11
PHP Version
No response
Hosting Environment
kubernetes with istio.

Hi @rparree,

I tried updating to version 21.11.2, but when accessing the site and it redirects to /bookstack/login it shows "Page Not Found".

What URL are you hosting BookStack on? Are you hosting at /bookstack or are you hosting at /?
What is configured for the APP_URL option?

I am hosting on /bookstack, the APP_URL includes the full : https://xxx.yyyy.com/bookstack
tx.,

Thanks for confirming @rparree.
Do you have any detail on how requests are sent to the linuxserver container? Are you using a standard reverse proxy? If so can you share the configuration used?

I am using istio's virtualservice.
This works fine up to version v21.10.1. I should also mention that the "not found" page is the styled one from bookstack. Meaning its css assets etc are successfully fetched
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: bookstack
spec:
  hosts:
    - xxxx.yyyy.com
  gateways:
    - kube-system/gw-public
  http:
    - route:
        - destination:
            host: bookstack-0
            port:
              number: 80
      match:
        - uri:
            prefix: /bookstack
      rewrite:
        uri: /

I am well aware that this is very basic, and I don't have any experience with your setup, mine's very different, so I'm not thinking I'm brilliantly providing a definite fix here... It's just that I had this exact same problem, couldn't find the cause, and a seemingly random chain of artisan commands fixed it:
php artisan config:clear
php artisan cache:clear
php artisan view:clear
php artisan config:cache
php artisan bookstack:regenerate-comment-content
php artisan bookstack:regenerate-search
php artisan bookstack:regenerate-permissions
php artisan cache:clear
php artisan config:cache
php artisan view:cache

I'm not saying it works and if it does I can't explain why... I just know I was frustrated and mashing 'm in this order which worked... 😂
(this was after having used every single one of those commands once already, btw, since I updated a ton of versions at once, and probably needed them all, except for the cache ones. That's a precaution I'm taking after the cached DB config once didn't clear properly, due to which an update on my staging destroyed my production)

@Perrydiculous  thanks for your help. It however did not help. I am still getting the same error
for example version 21.11.3:

version 21.10.3

Dear good afternoon everyone ..
I have the same problem when updating from version 21.10.3 to 21.11.3. I get a 404 error when accessing the login screen.
Infrastructure detail:
Nginx Reverse Proxy on localhost
Docker container with Centos7 image with php 7.3 + apache as application web server
DB Mysql to external host.
I applied the mentioned solutions but still without success.
Any ideas?

Dear good afternoon everyone .. I have the same problem when updating from version 21.10.3 to 21.11.3. I get a 404 error when accessing the login screen.
Infrastructure detail: Nginx Reverse Proxy on localhost Docker container with Centos7 image with php 7.3 + apache as application web server DB Mysql to external host.
I applied the mentioned solutions but still without success.
Any ideas?

I found the solution:
The new version rewrites the URL to me. It added a / after the domain and before login.
I understand that it is a problem of my configuration since it did not work for me with version 21.11. Or not. I haven't fully verified it yet.
I hope it will help you.
Greetings!

Same problem :-(

Just to provide an update, I have tested path-based proxied instances and it's not that alone since my existing dev instances worked fine.
I was able to re-produce this (Although I didn't check against older BookStack versions) in once Apache proxy instance where I found the proxying was causing an extra slash to be added to the path in the request to BookStack. A tweak to the proxy passing got this working fine. Below is an example of the config change I made.

Config Changes
Broken
ProxyPass "/bs"  "http://bookstack.local/"
ProxyPassReverse "/bs"  "http://bookstack.local/"

Working
ProxyPass "/bs"  "http://bookstack.local"
ProxyPassReverse "/bs"  "http://bookstack.local"

In v22.04 I made further changes to URL handling related to an issue that was likely connected to this one.
Since there was no further progress on this issue thread, and since we've since made further changes, I'm going to close this off.
If you're still having issues on the latest release feel free to comment to request this be re-opened.

I checked with the updated version and had the same problem.
I have moved our bookstack to a subdomain  instead of path-based. And that works.

Hi everybody.
Just to say I had the same issue, due to the fact that : the mod_redirection was not enabled on my apache.
Apache configuration was correctly protected :
<IfModule mod_rewrite.c> ...
so rewriting was not made
So I had to enable rewrite module
sudo a2enmod rewrite
I assume, that module "mod_negotiation.c" should be enabled too.
Have a nice day.


Auto CRL check

Hello,
I try to revoke a client certificate using the commands shown in the documentation:
docker run --rm -i --volumes-from vpn -e "EASYRSA_BATCH=1" kylemanna/openvpn easyrsa revoke toto
docker run --rm -i --volumes-from vpn kylemanna/openvpn easyrsa gen-crl

The process seems to be ok, but when I try to connect to vpn with my revocated certificate, it works...
The docker-openvpn logs:
Fri Jan 29 23:17:04 2016 <IP_ADDRESS>:41187 CRL CHECK OK: CN=blah
Fri Jan 29 23:17:04 2016 <IP_ADDRESS>:41187 VERIFY OK: depth=1, CN=blah
Fri Jan 29 23:17:04 2016 <IP_ADDRESS>:41187 CRL CHECK OK: CN=toto
Fri Jan 29 23:17:04 2016 <IP_ADDRESS>:41187 VERIFY OK: depth=0, CN=toto

Does this reaction normal ?

Did you restart the server after you generated the CRL?  The ovpn_run script looks for the presence of the CRL and passes the path to openvpn if found.  If you created the CRL and never restarted the container, the argument was never passed.
Can you run a ps and see if the crl-verify arugment is passed?  If it isn't can you restart your container and confirm that it is?
[1] https://github.com/kylemanna/docker-openvpn/blob/e7d0d4e/bin/ovpn_run#L42-L49

If I restart the server after the CRL generation it work correctly.
But in my VPN server creation script. I have done something like that:
docker run --name $VOL_NAME -v $CONFIG:/etc/openvpn busybox
docker run --volumes-from $VOL_NAME --rm synvpn ovpn_genconfig -u udp://vpn01.synhack.fr:$PORT -t
docker run --volumes-from $VOL_NAME --rm -i -e "EASYRSA_REQ_CN=synhack" -e "EASYRSA_BATCH=1" synvpn ovpn_initpki nopass <<< $'\n'
docker run --volumes-from $VOL_NAME --rm kylemanna/openvpn easyrsa gen-crl
docker run --name $CTR_NAME --volumes-from $VOL_NAME -d -p $PORT:1194/udp --cap-add=NET_ADMIN synvpn

I don't understand why it don't automatically stop connection from revoked certificate after revoke command without restarting the server.

The problem seems to come from the hardlink between /etc/openvpn/crl.pem and /etc/openvpn/pki/crl.pem. When I check the revoked certificates with "openssl crl" command. I have revoked certificates with /etc/openvpn/pki/crl.pem but not with /etc/openvpn/crl.pem.
Did you know what can cause this issue ?

That's interesting.  That would explain the problem you have.  I apparently didn't do enough testing with new revocations.
Sounds like the file is being replaced by openssl breaking the hardlink?  Could you verify this by running ls -li to see the inode number?  I bet initially they are the same, but when you revoke another certificate they are different and hence not updated.
The solution may be a wrapper for the easyrsa revocation generation to copy the file to the correct location with the correct permissions instead of using the hardlink.

Effectively the inode number seems to change.
Currently my script copy the file in /etc/openvpn after each revocation, But you are right, it will be better to modify easyrsa to do that.

@kylemanna I'm encountering the same issue. Any fix for this?
Why are you using ln in this line? Wouldn't be much simpler to change line 49 to something like
ARGS+=("--crl-verify" "$OPENVPN/pki/crl.pem")

Is there any drawback in doing that?
Also according to this thread client documentation is outdated.

Why are you using ln in this line

Ok, I think this is needed because /etc/openvpn/pki/ has 600 permissions and openvpn daemon drops root privileges before reading that file. So a solution might be to replace ln with cp, this however will require users to restart openvpn image for each crl change.
Thoughts?

Yes, this is a problem.  Could try a hardlink to that file that the openvpn user can read?

I'm also having trouble with revoked client certificates even after restarting the container.
After running revoke and gen-crl I see that the certificate is listed as REVOKED when running ovpn_listclients.
However, it seems that restarting the docker container does not seem to have any effect. I am still able to connect with a revoked certificate.

@rojters do you see --crl-verify /etc/openvpn/crl.pem passed to the openvpn binary using something ps waux?

@kylemanna Yes, that appears to be the case:
Running docker exec CONTAINER ps waux shows the following output:
PID   USER     TIME   COMMAND
    1 nobody     0:03 openvpn --config /etc/openvpn/openvpn.conf --client-config-dir /etc/openvpn/ccd --crl-verify /etc/openvpn/crl.pem

Hmm.  This is something that should be unit tested so that it doesn't happen.
Can someone write up the exact steps to reproduce on the lastest docker image and I'll take a look at it.

The workaround for this issue seems to be to copy /etc/openvpn/pki/crl.pem to /etc/openvpn/crl.pem as @y0no had mentioned. My revocation script currently copies the file, and then restarts the openvpn service.

I feel like something is broken here, but haven't had time to dig in.  Would be useful if someone could propose a test that could be added to the Travis-CI tests to detect this issue.

This command below will reset the hard-link without need to restart the container.
# pre-inode numbers
sudo docker run -it --rm -v $PWD/openvpn-data/conf:/etc/openvpn kylemanna/openvpn /bin/bash -c "ls -li /etc/openvpn/pki/crl.pem /etc/openvpn/crl.pem"
2752741 -rw-r--r--    1 root     root           690 Mar  9 22:09 /etc/openvpn/crl.pem
2752733 -rw-------    1 root     root           690 Mar  9 22:17 /etc/openvpn/pki/crl.pem

# reset hardlink
sudo docker run -it --rm -v $PWD/openvpn-data/conf:/etc/openvpn kylemanna/openvpn /bin/bash -c "ln -v -f /etc/openvpn/pki/crl.pem /etc/openvpn/crl.pem && chmod 644 /etc/openvpn/crl.pem"

# post-inode numbers
sudo docker run -it --rm -v $PWD/openvpn-data/conf:/etc/openvpn kylemanna/openvpn /bin/bash -c "ls -li /etc/openvpn/pki/crl.pem /etc/openvpn/crl.pem"
2752733 -rw-r--r--    2 root     root           690 Mar  9 22:17 /etc/openvpn/crl.pem
2752733 -rw-r--r--    2 root     root           690 Mar  9 22:17 /etc/openvpn/pki/crl.pem

Re. steps to reproduce the initial state where inodes are different:

New install (pre-running of container): new ovpn_genconfig, new clients, etc... If you run easyrsa gen-crl now, it will write /etc/openvpn/pki/crl.pem. This file is required for the arg "--crl-verify /etc/openvpn/crl.pem to be added in ovpn_run. If there is no crl file, then openvpn launches without revocations enabled. Then later when a client is revoked, openvpn must restart to create the hardlink from /etc/openvpn/crl.pem to the new /etc/openvpn/pki/crl.pem.
Revoke a client (verify inodes are different by running the pre-inode numbers command above)
openvpn is restarted but since inodes are different, openvpn does not recognize crl.pem
Run the reset hardlink command above and verify with the post-inode numbers command
The client revoked in step 2 is now denied authorization

It's really a nasty little bug. I tried a number of ways around this, even "touching" the pki/crl.pem file if not exists. But openvpn expects a pem with x509 content and not an empty file.

For my use case, I see a two-part fix but is this s/thing others would be okay with?
Part 1: Whenever ovpn_run runs, if /etc/openvpn/pki/crl.pem is not present, then generate it using easyrsa gen-crl. Then proceed with the hardlink and chmod settings.
Part 2: Whenever a client is revoked, do it through new script ovpn_revokeclient. This script would:

Revoke via easyrsa revoke $CLIENTNAME
Regenerate via easyrsa gen-crl
Invoke the hardlink fix command above

Actually, Part 1 doesn't work b/c it requires a password to generate but Part 2 can be done interactively.

For Part 2, here's a link to my version of ovpn_revokeclient.  This works for my use case.

Hey guys, please give this a try with #251 merged.  Hopefully restarting the server now will do what is expected.

For those interested in OpenVPN automatically re-loading the CRL I think it's a matter of switching back to a hardlink and updating easryrsa gen-crl to re-write the file instead of move a new file over the top to not break the hardlink.  If the hardlink remains, the permissions should remain, and OpenVPN will potentially reload it.  Haven't looked at the OpenVPN code yet to determine if this is true.
Description of hardlink breakage:
https://github.com/OpenVPN/easy-rsa/blob/5a429d22c78604c95813b457a8bea565a39793fa/easyrsa3/easyrsa#L742-L758
The problem is that EasyRSA:

creates a temporary file
writes the CRL to that file
moves the CRL over the top of the previous one (breaking hardlink)

Presumably it does this to make it an atomic operation to avoid corruption in a power failure (my understanding is that mv aka rename() syscall is typically atomic on journaling filesystems) or system crash at the exact same time.
What we could do instead is rewrite to the same file, that way the hardlink I originally used would work as expected and the permission would be preserved while the file update and OpenVPN would be able to check the connecting client against the updated CRL.


Preparing release 1.17.1

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

LGTM, just needs to tell how the OAuth Token should be created.

That is provided in the changelog target

That is provided in the changelog target

The instructions on how to properly run the changelog is being provided after the changelog is run. It should really be part of the RELEASE.md, and people should be expected to create the OAuth Token before running the target ;-)
Besides, the comment is missing which scopes should be selected...

PR updated and added instructions on how to generate the oauth token.
The examples1 pass locally on minikube:
NAMESPACE=pavolloffay make e2e-tests-examples1                                    10:56
Formatting code...
Building...
Sending build context to Docker daemon    174MB
Step 1/7 : FROM registry.access.redhat.com/ubi8/ubi
 ---> 0c46e5c7a82a
Step 2/7 : ENV OPERATOR=/usr/local/bin/jaeger-operator     USER_UID=1001     USER_NAME=jaeger-operator
 ---> Using cache
 ---> d443d14f2a57
Step 3/7 : RUN INSTALL_PKGS="       openssl       " &&     yum install -y $INSTALL_PKGS &&     rpm -V $INSTALL_PKGS &&     yum clean all &&     mkdir /tmp/_working_dir &&     chmod og+w /tmp/_working_dir
 ---> Using cache
 ---> df5ea8178a31
Step 4/7 : COPY scripts/* /scripts/
 ---> Using cache
 ---> bb623e0ba6fd
Step 5/7 : COPY build/_output/bin/jaeger-operator ${OPERATOR}
 ---> b4b069c6d67b
Step 6/7 : ENTRYPOINT ["/usr/local/bin/jaeger-operator"]
 ---> Running in 070f8b3ccb10
Removing intermediate container 070f8b3ccb10
 ---> a3d61dad3422
Step 7/7 : USER ${USER_UID}
 ---> Running in c103c146e772
Removing intermediate container c103c146e772
 ---> 0f8df52b67c4
Successfully built 0f8df52b67c4
Successfully tagged pavolloffay/jaeger-operator:latest
Pushing image pavolloffay/jaeger-operator:latest...
Creating namespace default
# Elasticsearch requires labeled nodes. These labels are by default present in OCP 4.2
node/minikube not labeled
# This is not required in OCP 4.1. The node tuning operator configures the property automatically
# when label tuned.openshift.io/elasticsearch=true label is present on the ES pod. The label
# is configured by ES operator.
customresourcedefinition.apiextensions.k8s.io/prometheusrules.monitoring.coreos.com configured
customresourcedefinition.apiextensions.k8s.io/servicemonitors.monitoring.coreos.com configured
serviceaccount/elasticsearch-operator unchanged
clusterrole.rbac.authorization.k8s.io/elasticsearch-operator configured
clusterrolebinding.rbac.authorization.k8s.io/elasticsearch-operator-rolebinding configured
customresourcedefinition.apiextensions.k8s.io/elasticsearches.logging.openshift.io configured
deployment.apps/elasticsearch-operator configured
deployment.apps/elasticsearch-operator image updated
Running Example end-to-end tests part 1...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	107.818s

PR https://github.com/jaegertracing/jaeger-operator/pull/973 shows that examples1 fail also on master branch.


Added disqus removal support, and added stackoverflow in social list

Disqus can be removed from config file,
Prior removed, it had the text showing "powered by disqus", now that text is removed.
Added stackoverflow in social list.

@murarisumit Looks good! thank you ;)


Settings can be open more in more than one tab

Not sure how I got into this state:

Clicking on settings.json opened User Settings which was unexpected.

Even if "User Settings" is closed, settings.json will open a new User Settings tab. I can only close settings.json tab by middle click/clicking the x.

@Tyriar We recently added a functionality to open Settings Editor when clicking on settings file. I tried to get into the above state but no success. Any steps would be helpful.
@bpasero Any insights?

@sandy081 I am using your code to open the settings when you click a file in the explorer that is a settings file, not sure if your intent is to prevent opening multiple settings?

The code lives here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/common/preferencesContribution.ts#L62

@bpasero Opening User/Workspace/Workspace Folder settings explicitly opens them in different editors. I think, issue mentioned here is different that @Tyriar has settings.json file and User Settings editor opened simultaneously. I thought with your new feature, we always open Settings editor when user opens settings.json file ?

Yes I see what the problem might be.

The issue here was that settings.json was already opened in any of the inactive tabs and now after my change whenever the settings are opened we want to open the real settings editor. I added a check to not prevent opening of the raw settings file if it is already opened as tab. This should prevent the accidental opening of the real settings editor when you click on settings.json while it is already opened.
Still, when no settings.json file is opened, we will open the actual settings editor.


[V6] Submitting with no registered fields

I have the multistep wizard form which last step has no field, just a plain submit button.
Let's consider the follow example:
function WizardFirstStep({ handleSubmit }) {
  return (
    <form onSubmit={handleSubmit}>
      <Field name="username" component="input" type="text" />
      <Field name="password" component="input" type="password" />
    </form>
  );
}

export default reduxForm({
  form: 'wizard',
  destroyOnUnmount: false,
})(WizardFirstStep);

function WizardSecondStep({ handleSubmit }) {
  return (
    <form onSubmit={handleSubmit}>
      <button type="submit">Submit</button>
    </form>
  );
}

export default reduxForm({
  form: 'wizard',
  destroyOnUnmount: false,
})(WizardSecondStep);

And also the main component which changes these steps (like in the examples).
The issues is the following: because in the reducer of UNREGISTER_FIELD action if the there is no fields that property is removed and when you try to submit with the removed property ReduxForm:getFieldList()  method will throw an error.
I think that you shouldn't remove the registeredFields property from the state and let it to be an empty array.
One workaround for this is to create a hidden field <Field name="hidden" component="input" type="hidden" /> just to make that property not to be empty.

@clayne11 could you take a look at this issue please?

I'll look at it. Should be a simple fix.

Published fix in v6.0.0-rc.1.


Security audit fails due to a dependency in recompose

When running a security audit:
npm audit --prod

A low-severity vulnerability is detected due to a dependency on recompose v0.22. The underlying issue is that recompose takes a dependency against fbjs which takes a dependency on an old version of node-fetch.
I poked around the recompose repo and it appears the risky dependency in question was removed in their latest version. If react-infinite-calendar were to upgrade the version of recompose, it would likely fix the vulnerability.

For what it's worth, I don't think v0.30.0 resolves the security vulnerability. There is an actively maintained version of recompose called react-recompose which might do the trick.
That being said, I did find a local workaround. I use pnpm as my package manager, and adding this to my package.json file works to patch the audit.
{
    "pnpm": {
        "overrides": {
            "node-fetch": "^2.6.1"
        }
    }
}


[BUG] PR from fork won't trigger AML pipelines

Description

Every time I submit a PR from my fork, only 4 pipelines will be triggered:

license/cla
unit-test-linux-cpu
unit-test-windows-cpu
unit-test-windows-gpu

The other 4 won't be triggered:

unit-test-linux-gpu
bp-azureml-unit-test-linux-nb
bp-azureml-unit-test-linux-cpu
bp-azureml-unit-test-linux-gpu

In which platform does it happen?

All.
How do we replicate the issue?

All PRs from any forks will trigger only 4 of the pipelines.  Those from branches directly created on this repo will trigger all 8 pipelines.
Expected behavior (i.e. solution)

Not sure whether all 8 pipelines should be triggered
Other Comments
After I compared the settings of these pipelines, I found

for the 4 triggered pipelines:

and for the 4 non-triggered:

Closing this PR since only internal branches will run all devops pipelines (but not forks)


Error Response: 550 5.5.1 Protocol error

when I check a email from different site I have this error
[10] => Got a 220 response. Sending HELO...
[11] => Response: 250 lpn-prd-vrin019
[12] => Sending MAIL FROM...
[13] => Response: 250 2.1.0 Ok

[14] => Sending RCPT TO...
[15] => Response: 550 5.5.1 Protocol error

from this site : laposte.net ,

Hi, @oury1 Did you found the reason why you got 550 5.5.1 Protocol error?

This is most likely resolved in the supported repo. I'll see if I can get this updated here as well. But don't have any bandwidth right now.