Expanded Configuration Migration Features

Hi Wael,
I've expanded upon @joshcampbell191 's work on implementing expansion/combine features of Configuration Migration packages by adding more granular control, allowing a user to Split the file to either the Entity level or Record level. Record level was added to provide better VCS visibility of Power Apps portal configuration changes (ie instead of 1 giant annotation_data.xml file containing all the webfile document blobs, you can now split it to per record to make VCS diffs easier to read).
Additionally, I've implemented a "Mapping" feature, similar to how the SolutionPackager works. This was to allow mapping of VCS controlled artefacts (ie Portal WebFile JavaScript/CSS that may be compiled separately) directly into the configuration migration package, either at the data.xml level (Split type: None) or at the Entity/Record levels as per the expand/combine feature mentioned previously. The new script for this is MergeCMData.ps1, with accompanying Commandlets.
For an example of how this / the augmented CM expansion / combination works, please see ConfigurationMigrationTest.cs in the Common Integration test project, along with the Artefacts directory there which has a sample mapping file.
Cheers
Michael

Bump?

@MichaelHolmesWP thank you for submitting this PR. Apologies it took a while to get to it.
Are you intending to use this purely in Power Shell or you want this to be available via the Azure DevOps tasks too?
A few points for discussion...
1- Regarding record splitting into files, this may make sense for things like annotations but it may make it more difficult to browse through changes for other data types. Are you think of having a separate schema for the annotations? Or will you have everything at record level?
2- The enum (i.e. entity vs record) seems like a good idea, however I suspect that when this get released it would break any existing consumers who are using the cmdlets or scripts directly?
I will take a look at this into bit more details but there are many files to go through :)

My 2 cents on 1...I like the idea of being able to split out the config by record. This would highlight the individual record more quickly in the diff vs seeing 10 records 'somewhere' in the Snippets file. It would also be valueable for other non-portal type config entities as it again would highlight quicker what changed. Conceptually, its the same as is done with Solution Packager when it decomposes the entity components.

Hi Wael,
Cheers for having a look mate, been a big fan of toolset for years.
With regards to the enum, my original commits provided backwards compatibility with Josh's original flag but I rationalised that given its a preview feature anyway we could circumvent that with a new task version, happy to add the regression support back in though.
With the entity split level, I feel that the added complexity of separate annotation behaviour would put people off using it. Whilst I built support for re-combining the various levels into data.xml still only use the record split for vcs changeset purposes and my ALM still does all external file mapping and rearchiving on the complete data.xml file that is checked in regardless of split level.
The most helpful feature I've found from the build is the solution-packager style external file and record field substitution, which I'll hopefully be expanding upon.
Cheers
Michael

Moving the changes off master onto a separate branch for the interim, will re-PR the feature branch instead after some more enhancements


filter and drop on loaded nPrints

in many cases it is useful to either drop certain fields (ip addresses, ports, etc), or only use specific fields in the representation. This is composed of 4 parts

filter function on loaded nPrint dataframe. we can leverage pandas.
flag for filtering
drop function on loaded nPrint dataframe. again we can leverage pandas
flag for dropping columns.

This will now be based on the feature implemented into nPrint itself – merely exposing the new flag(s).


Port ProjectInfo widget from WAB

No need for comments in this app.
Look into pulling the popup contents as defined in the web map layer.

First get it working for feature layers. Then see what it will take to make it work with map image layers.

This widget has been ported "as is" from the WAB project. It works with feature layers only. Let's create new issues for enhancements to it.

I'd love any feedback that you have on it currently.

Thanks for your work on this one. It looks just about ready to go. We will still use the default AGOL popups for now. I noticed that when AGOL popups are switched to true, it hides the Project Information widget - nice.
Will the final Project Information widget use the AGOL-configured popups? If not, I'll need to clean up several datasets before the widget goes live.
It looks like the plan is still to try to have this widget work with map image layers. If it would be too time-consuming or difficult, we can probably copy over some of the live layers we've been using so they can be feature services - probably not a big deal.
Also, I noticed the widget changes in size depending on the attribute size. Would it be possible to constrain it to the same width as the Layers widget?

Will the final Project Information widget use the AGOL-configured popups? If not, I'll need to clean up several datasets before the widget goes live.

https://github.com/agrc/wfrc/issues/34

It looks like the plan is still to try to have this widget work with map image layers. If it would be too time-consuming or difficult, we can probably copy over some of the live layers we've been using so they can be feature services - probably not a big deal.

https://github.com/agrc/wfrc/issues/35
I'll look into this and see if it's feasible. I think that I should be able to get it to work. I don't believe that adding duplicate feature services to the web map would help this issue.

Also, I noticed the widget changes in size depending on the attribute size. Would it be possible to constrain it to the same width as the Layers widget?

https://github.com/agrc/wfrc/issues/36
I'm going to close this issue in favor of the newly added issues. Please let me know if I failed to capture any feedback in the new issues.

The newly added issues look great. Thanks for taking a look at those.


Feature/story writing view with feedback

Summary
This pull request introduces a new feature: the Story Writing View with a Feedback Panel. The view is fully responsive and styled according to the provided design specifications.
Changes

Added a Story Writing View component, including:

A sidebar with buttons for "Story Logline," "Character," "World," "Conflict," and "Plot Twist."
A main content area displaying the genre, purpose, and editable story text.
A Feedback Panel styled as per the provided design, including:

Numbered feedback items with dynamic colors and structured content.
A call-to-action "End Logline" button.

Hello @philwamba , please make sure to get the latest DEVELOP branch updates and see if this feature was not already implemented. I believe it was already, the only thing new here it's the Conflict, Plot Twist Card and maybe Feedback integration, you need to address the endpoints to the backend to the get Feedbacks. You can get those with Laban.
This was not approved because you have an error in the code and this is not updated with the latest DEVELOP branch changes. Please verify soon, thanks.


Dash salesforce crm

Issue for app: #8
App pull request

[ ] This is a new app
[x] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-salesforce-crm/
Current gallery app URL: https://dash-gallery.plotly.host/dash-salesforce-crm

Workflow

[x] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[x] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[ ] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[x] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[x] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[x] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[x] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

@Mskycoder Looks like there's an application error on the playground deployment. Could you please fix that?

@shammamah  this app has a deployment problem which cannot be resolved neither by merge master changelog back nor by delete and re-create an empty app on playground.

@Mskycoder Please run black on this code.

@celinehuang Could you please, in the mobile layout:

Make each of these dropdowns half of the width of the screen, and
Make the button full-width?

Other than that, looks good to me :)

Make the button full-width?

the mock up has it like this
, should I make it full width still? @shammamah

No need to make it full width, but please center the dropdowns!


TextView default copy/paste menu don't open on long press

When long pressing a link the menu does open, but pressing anywhere else in the textView will not open a the copy/paste menu.
I tried to workaround this by adding long press to view below the text view (in this case the contentView of a UICellView). I could get the long press gesture to work, but trying to open the menu didn't work.

Copy & Paste interferes with long tap – I'm surprised this works with links. It might be possible to implement a property to disable the long tap detection. Another option would be to trigger an action sheet on long tap with copy options (that's what Twitterrific does).

Thanks for reporting this issue. If you want to look into fixing it, I'd be happy to have a look at a PR. At the moment, I consider this a known limitation of the library.


Multi-threading problem of NNPACK on ARMv7

Hi, @Maratyszcza ,
I ran NNPACK on armeabi-v7a device (Quad-core) in inference mode with WINOGRAD algorithm, with threads = 1, 2, 4. The timing are about 135 ms, 83 ms and 62 ms, respectively. It seems that the performance did not speed up as expected when threads increasing. What may be the reason?
Thanks a lot.

A lot of factors could contribute: power caps, memory/cache bandwidth saturation, lot amount of work per core.


Cheeper code repository not found

Code examples in the book are great, it would be great to have the code in GitHub.
The mentioned Cheeper code example  is not found.

We will publish the book in GitHub asap.


Refactor to avoid CDU on setting this.props

Currently CDU runs in a few cases while those are not actual updates but initial setup

The above relates to this.props


Validate that PaginateViaPrimaryKey is not used without Take

Inspired by #372
Possible options:

throw without Take
auto-disable without Take

Reposted here from #336 discussion:
I would say, since pagination requires a Take parameter, PaginateViaPrimaryKey should not be used, if the take parameter is not specified. Without it, we are simply NOT paging, so any pagination options should not have any effect. I would prefer a warning, but that will be a bit more diffcult to implement :-)
I vote for silently disabling PaginateViaPrimaryKey, since we are not paging in this case.
On the other hand, if take is very large, we could also run into the same issue. The maximum allowed parameters for SqlServer are 2.100, afaik. So, if we do paging via PK, we would need Take * PrimaryKey.Length parameters to perform it. If we see that this value is > 2.100, we should probably also either throw an exception or disable it silently. I think, an exception here would be more appropriate, so the developer gets feedback, that he is doing something wrong.
So, maybe we need a differentiated approach: If we are not paging (i.e. no Take), I would disable it silently. If we are paging with large values, we should notify the developer, that the option will not work.
P.S.: 2.100 is probably a bad threshold, since the underlying query may also need additional parameters. We should leave some headroom there. On the other hand: Paging with a page size of > 1000 is kind of absurd in the first place :-)

To work around the issue, maybe you could enhance the client and server side code to include the actually used page size. Then, you could limit the page size on the server to a feasible amount when using PaginateViaPrimaryKey. When the client side detects, that the actual page size returned by the server is less than the requested amount, it can issue further requests, until all data has been loaded. This would make it transparent for developers, but means some more effort. The question is: Is it worth it?

@coeamyd
For the first take, I'm adding the Take > 0 condition. Pardon the pun.
Upper bound checks are an interesting topic. This can be useful for other load options too. For example, to limit group/sort level, etc. We'll keep it for possible future enhancements.
Thank you.

Sounds good to me. AFAIK, Microsoft's OData v4 implementation also enables you to specify upper bounds for other options, so, yeah, seems like a good candidate for a future enhancement.


init_git_cloudflared asking for github username and password

Describe the bug
Last night I was able to use colab-ssh locally, but now init_git_cloudflared is asking me for my GitHub username and password. This makes it impossible to connect with init_git_cloudflared because we can't connect to GitHub via username and password anymore (we need to use the personal access token, which is what I've been using).
So, even if you put in your username and password, you will get an error saying you need to use a personal access token.
I'm not sure if this is a cloudflare issue or something else entirely. The exact same code was working last night.
To Reproduce
Steps to reproduce the behavior:
launch_ssh_cloudflared(password)
init_git_cloudflared(git_repo + ".git",
personal_token=os.getenv('GITHUB_ACCESS_TOKEN'),
branch="main",
email="email",
username="username"
Expected behavior
It should give me an output message like "successfully cloned git repo to ./."
Screenshots

Nevermind, I changed the location of my mounted gdrive, but did not change the location of my .env filepath.


List outdated Components

As a developer I would like to know the components I am using which are outdated.
Acceptance Criteria

List the outdated components in the current project and the latest version available if known.

Won't fix - there isn't a useful way to get the data of useful components used directly in the project's pom.xml


Typescript support

I am using jsDocs with jsdoc-vuejs in a nuxt project. I keep getting parsing errors
ERROR: Unable to parse /project/components/Button/Button.vue: Unexpected token, expected "{" (58:15)
ERROR: Unable to parse /project/components/Feedback/Feedback.vue: Unexpected token, expected "," (39:16)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

none of this makes sense, since neither of these files fail when running yarn lint  eg: eslint --ext .js,.vue --ignore-path .gitignore .

@Elaniobro did you ever figure out this issue? I am experiencing the same thing with my vue project. Thanks!

nope.  Although,  Typescript itself,  is documentation, I am still hoping for a fix.


Deploy workflow shows deprecation notice

Where to find the issue
https://github.com/corona-warn-app/cwa-website/actions/workflows/deploy-master.yml
Describe the issue
https://github.com/corona-warn-app/cwa-website/actions/workflows/deploy-master.yml shows the deprecation notice:
"prod
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/setup-node, actions/setup-node, actions/checkout"
Steps to reproduce
View logs in https://github.com/corona-warn-app/cwa-website/actions/workflows/deploy-master.yml
Suggestion
.github/workflows/deploy-master.yml uses:

actions/checkout@v2
actions/setup-node@v2

Update

actions/checkout@v2 to actions/checkout@v3 (see https://github.com/actions/checkout/releases/tag/v3.0.0)
actions/setup-node@v2 to actions/setup-node@v3 (see https://github.com/actions/setup-node/releases/tag/v3.0.0)

Internal Tracking ID: EXPOSUREAPP-14217

Since I cannot test the deploy workflow, I don't want to submit a PR for this issue and I leave it to the Open Source Team to review and change if necessary.
The necessary changes are quite simple and they are the same as for the build workflow (see https://github.com/corona-warn-app/cwa-website/pull/3161).

@MikeMcC399 Great! https://github.com/corona-warn-app/cwa-website/actions/runs/3298074699

@dsarkar / @brifemu
Thanks for processing the suggestion! The workflow log @dsarkar linked to shows success with no deprecation warning.


No react deps

Converts  component into a function that uses template literals instead of JSX.
End result is that the package will no longer depend on react or react-dom.
Closes #143

Not arguing with this change... but it does break npx.

how so?

Seeing this on CI...

I think the solution is to not use npx...

Will npx use the latest version? With the changes I've just made, react should not be required at all.

Hmmm... It should... CI started failing a few hours ago.  We're still not able to repo locally.  Some CI quark?

All works as expected in the testing I've done. Ensure that you're installing the lastest mochawesome in the CI environment.

Yeah... mochawesome is an older version.  npx is using the latest mochawesome-report-generator.   Looks like our end... sorry for the false alarm!


chore(tests): move backend.json -> rivet.json

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#164
#163  👈
#162
#160
#159
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite

Merge activity

Sep 17, 12:24 AM EDT: @NathanFlurry started a stack merge that includes this pull request via Graphite.


[stable/nginx-ingress] Requiring autoscaling/v2beta1 is too restrictive

Is this a request for help?:
no
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
Client: &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"}

Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.0", GitCommit:"6e937839ac04a38cac63e6a7a306c5d035fe7b0a", GitTreeState:"clean", BuildDate:"2017-09-28T22:57:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.8", GitCommit:"bc6162cc70b4a39a7f39391564e0dd0be60b39e9", GitTreeState:"clean", BuildDate:"2017-10-05T06:35:40Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
[stable/nginx-ingress]
What happened:
When I try to enable autoscaling helm fails with
Error: apiVersion "autoscaling/v2beta1" in nginx-ingress/templates/controller-hpa.yaml is not available

As of now controller-hpa.yaml supports only CPU autoscaling.
According to the docs

CPU autoscaling, can be found in the autoscaling/v1 API version

So I think that requiring autoscaling/v2beta1 is a bug.
What you expected to happen:
I expect helm to render controller-hpa.yaml properly regardless of autoscaling/v2beta1 being enabled.
How to reproduce it (as minimally and precisely as possible):
helm upgrade --debug --wait --install ingress stable/nginx-ingress --set controller.autoscaling.enabled=true --dry-run

Fixed in #3418


can not find this package

If you have a problem launching a live-server, please try following steps:

Make sure you use the right hotkeys. After v2.0.0, the keys became ctrl-alt combination.
Try launching live-server from top menu: Package -> live-server -> Start Server to see if it works.

can not find this package -> live-server

#57


Validation.Runner may skip packages

As any job that uses cursor without some additional hardening, it may skip packages as described in #2841.
Monitoring of this job should catch this case though and the chances of this happening are pretty slim, so no huge deal, but process could definitely be improved here.

Closing this since we are deprecating the job.


pdfcpu: 0.3.7 -> 0.3.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pdfcpu/versions.
meta.description for pdfcpu is: "A PDF processor written in Go"
meta.homepage for pdfcpu is: "https://pdfcpu.io"
meta.changelog for pdfcpu is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.3.8 with grep in /nix/store/0shhxsa3zqh86g78jj7fgzz9s03j3k6i-pdfcpu-0.3.8

directory tree listing: https://gist.github.com/9acd4cdeeeffcebf2f25d4972f74d5f0

du listing: https://gist.github.com/7199b68ceba1b5a2ebc0be1de65f7b5b

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
pdfcpu

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0shhxsa3zqh86g78jj7fgzz9s03j3k6i-pdfcpu-0.3.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pdfcpu https://github.com/r-ryantm/nixpkgs/archive/71d6d4b0039926c704382c7065255683b3e50319.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0shhxsa3zqh86g78jj7fgzz9s03j3k6i-pdfcpu-0.3.8
ls -la /nix/store/0shhxsa3zqh86g78jj7fgzz9s03j3k6i-pdfcpu-0.3.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pdfcpu

Maintainer pings
cc @doronbehar @kalbasit for testing.

Result of nixpkgs-review pr 110178 run on x86_64-linux 1

1 package built:

pdfcpu

Result of nixpkgs-review pr 110178 run on x86_64-linux 1

1 package built:

pdfcpu


Please add https://github.com/ogham/dog Command-line DNS client

Please add https://github.com/ogham/dog Command-line DNS client

Hello @patsevanton
Thanks for the suggestion.
We tried that already. Unfortunately, it seems that dog really requires compiling.
Here is what I get when I download the binary and run it:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by dog)


Add period time series message logic

Closes: #143

Codecov Report
Base: 39.82% // Head: 38.68% // Decreases project coverage by -1.13% :warning:

Coverage data is based on head (412a9ab) compared to base (2ed9e5d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   39.82%   38.68%   -1.14%
==========================================
  Files          10       10
  Lines         889      915      +26
==========================================
  Hits          354      354
- Misses        535      561      +26

Impacted Files
Coverage Δ

src/ingestion.rs
15.12% <0.00%> (-0.47%)
:arrow_down:

src/publish.rs
0.00% <0.00%> (ø)

src/storage.rs
57.14% <0.00%> (-1.92%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

해당사항 수정 완료 했습니다.


dd

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Did you write the issue inside the comments ?

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


Incompatible with latest package_info_plus

The latest version of package_info_plus is v8.0.0, which is not compatible with flutter_debug_overlay due to the upper bound in pubspec.yaml:
package_info_plus: '>=4.0.2 <6.0.0'

I've taken the liberty of creating a PR for this: https://github.com/Bungeefan/flutter_debug_overlay/pull/4

Thanks for the notice and PR, merged!

flutter_debug_overlay 0.1.7 has been uploaded to pub.dev!


Update the backup and restore databases doc

We just carried out a drill following these docs.
Trello card: https://trello.com/c/S5o5MD14/2031-2nd-line-drill-using-a-restored-database-in-an-app

Thanks for checking and updating this btw! Super helpful to know that this still works (albeit with this rather complicated procedure!)


Fix CLASS and NAMESPACE to be properly escaped

At the moment if you do something like var_dump(__CLASS__)
you get something like DebugNS insteadof Debug\NS

I think we need tests on it


Improve landing page

OK, so React isn't as simple as I hoped it would be.
Landing page needs to show the top 100 men by total (default API call), along with continual loading, and the option to switch genders.

@rsbrowne pagination would probably be easier to implement over infinite-scroll. I'm basing this off the 73 minutes of exposure i've had to React.

Pagination is overrated as it starts getting weird with filters etc (which I intend on adding) so I'll do the show more button for now and we can come back to it and maybe do pagination later. How are you hosting this btw?

@rsbrowne i'll update documentation on the API calls if it isn't that clear currently.  I haven't decided on a hosting option yet. I'm welcome to suggestions.

@euanwm Feel free to assign this to me, I've been doing some work to get new front end tooling in place and I'll be in a better spot at the weekend to get more work done on the actual visuals


v1.6 snippets: enabling optional features

Adding snippets from https://cloud.google.com/service-mesh/docs/enable-optional-features

Includes region tags and licenses
Part of go/anthos-samples-tracking

nit:  what do you think about bundling related samples into the same yaml file?  For example, see #5


Added support for importing from sandbox server

The biotools-import python script import.py is able to import tools from https://ecosystem.bio.tools , rather than from main https://bio.tools
By default import.py works the same.
In order to import from ecosystem.bio.tools (aka sandbox server) we can run:
python import.py --sandbox

Actually this might be too hard to get it to work in an easy way because we need to change the action.yml file to run the
python ${{ github.action_path }}/import.py --sandbox which would require passing some extra parameters, so it's probably best to make another folder called biotools-sandbox-import or something like that and use that for the sandbox.
So closing the PR...


runtime: GC crash

https://build.golang.org/log/05d53c7b89a4539c468ebec21fdfd59ee7ac52b3
linux-amd64-noopt at d1e9104fb25a71aa459ee329452545a0ceebdcf9
##### Testing race detector
ok  	runtime/race	8.162s
ok  	flag	1.037s
ok  	os/exec	3.050s
runtime: pointer 0xc42035a7c8 to unallocated span idx=0x1ad span.base()=0xc420354000 span.limit=0xc420361f80 span.state=3
runtime: found in object at *(0xc42039df98+0x8)
object=0xc42039df98 k=0x62101ce s.base()=0xc42039a000 s.limit=0xc42039c000 s.sizeclass=2 s.elemsize=16 s.state=_MSpanStack
 *(object+0) = 0x5de470
 *(object+8) = 0xc42035a7c8 <==
fatal error: found bad pointer in Go heap (incorrect use of unsafe or cgo?)

runtime stack:
runtime.throw(0x661319, 0x3e)
	/tmp/workdir/go/src/runtime/panic.go:596 +0x95 fp=0x7ff12c9f6570 sp=0x7ff12c9f6550
runtime.heapBitsForObject(0xc42035a7c8, 0xc42039df98, 0x8, 0xc41fffc27f, 0xc400000000, 0x7ff1339a4f70, 0xc420021228, 0x4)
	/tmp/workdir/go/src/runtime/mbitmap.go:433 +0x2bf fp=0x7ff12c9f65c8 sp=0x7ff12c9f6570
runtime.scanblock(0xc42039df98, 0x18, 0x665b15, 0xc420021228)
	/tmp/workdir/go/src/runtime/mgcmark.go:1186 +0x12b fp=0x7ff12c9f6640 sp=0x7ff12c9f65c8
runtime.scanframeworker(0x7ff12c9f6958, 0x7ff12c9f6a48, 0xc420021228)
	/tmp/workdir/go/src/runtime/mgcmark.go:911 +0xfc fp=0x7ff12c9f66d0 sp=0x7ff12c9f6640
runtime.scanstack.func1(0x7ff12c9f6958, 0x0, 0x7ff12c9f6701)
	/tmp/workdir/go/src/runtime/mgcmark.go:805 +0x6e fp=0x7ff12c9f6720 sp=0x7ff12c9f66d0
runtime.gentraceback(0xffffffffffffffff, 0xc42039df60, 0x0, 0xc42023a680, 0x0, 0x0, 0x7fffffff, 0x7ff12c9f6b48, 0x0, 0x0, ...)
	/tmp/workdir/go/src/runtime/traceback.go:378 +0x13a2 fp=0x7ff12c9f69b8 sp=0x7ff12c9f6720
runtime.scanstack(0xc42023a680, 0xc420021228)
	/tmp/workdir/go/src/runtime/mgcmark.go:828 +0x265 fp=0x7ff12c9f6b98 sp=0x7ff12c9f69b8
runtime.scang(0xc42023a680, 0xc420021228)
	/tmp/workdir/go/src/runtime/proc.go:851 +0x209 fp=0x7ff12c9f6bd0 sp=0x7ff12c9f6b98
runtime.markroot.func1()
	/tmp/workdir/go/src/runtime/mgcmark.go:250 +0x6d fp=0x7ff12c9f6c10 sp=0x7ff12c9f6bd0
runtime.systemstack(0x7ff12c9f6c78)
	/tmp/workdir/go/src/runtime/asm_amd64.s:330 +0xab fp=0x7ff12c9f6c18 sp=0x7ff12c9f6c10
runtime.markroot(0xc420021228, 0x5d)
	/tmp/workdir/go/src/runtime/mgcmark.go:255 +0x1c7 fp=0x7ff12c9f6ca0 sp=0x7ff12c9f6c18
runtime.gcDrain(0xc420021228, 0x0)
	/tmp/workdir/go/src/runtime/mgcmark.go:1027 +0xad fp=0x7ff12c9f6cd0 sp=0x7ff12c9f6ca0
runtime.gchelper()
	/tmp/workdir/go/src/runtime/mgc.go:1877 +0xfd fp=0x7ff12c9f6d00 sp=0x7ff12c9f6cd0
runtime.stopm()
	/tmp/workdir/go/src/runtime/proc.go:1623 +0xe0 fp=0x7ff12c9f6d28 sp=0x7ff12c9f6d00
runtime.findrunnable(0xc420021300, 0x0)
	/tmp/workdir/go/src/runtime/proc.go:2052 +0x24f fp=0x7ff12c9f6dc0 sp=0x7ff12c9f6d28
runtime.schedule()
	/tmp/workdir/go/src/runtime/proc.go:2151 +0x153 fp=0x7ff12c9f6e00 sp=0x7ff12c9f6dc0
runtime.park_m(0xc4204e2ea0)
	/tmp/workdir/go/src/runtime/proc.go:2214 +0x7a fp=0x7ff12c9f6e38 sp=0x7ff12c9f6e00
runtime.mcall(0x0)
	/tmp/workdir/go/src/runtime/asm_amd64.s:256 +0x5b fp=0x7ff12c9f6e48 sp=0x7ff12c9f6e38

More:
https://build.golang.org/log/0d05eae984e23f718c7ae5abdc7eb18e3d532974
https://build.golang.org/log/b84a8abc226ce4ed9d0672480aabe247f607c7a6
https://build.golang.org/log/d83d950108f7a200aebc8f73a89dc9cdbb065920

Weird.  Something is definitely confused here, the state of the span is _MSpanStack but the GC is scanning it as if it were a span of 16-byte objects.

Four more on the first page of build.golang.org:
https://build.golang.org/log/b3ae09ee6ba8718e621f8548694c317e425057fe
https://build.golang.org/log/6a92b4f7ed27db03b3c2063486ecf7357fac642a
https://build.golang.org/log/b83479cfd0eaea91f4ac7939e002eab5cdd8cab3
https://build.golang.org/log/b83479cfd0eaea91f4ac7939e002eab5cdd8cab3
All on the noopt builder so far. That's usually something that's usually
inlined triggering a stack split or something along those lines I think?
On 8 November 2016 at 06:17, Keith Randall<EMAIL_ADDRESS>wrote:

Weird. Something is definitely confused here, the state of the span is
_MSpanStack but the GC is scanning it as if it were a span of 16-byte
objects.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/17785#issuecomment-258899443, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApBFl9dC0aIQZqQbkh1qEMxShJBk7_zks5q710QgaJpZM4KpCaT
.

This crash continues again, now that an unrelated noopt test failure is no longer hiding it.
@aclements, any ideas?

Some statistical observations.
I had assumed this was caused by the hybrid barrier, but it actually started a little before the hybrid barrier went in. The failure probability did significantly increase after the hybrid barrier---from ~1.5% to 18%---but the timing isn't quite right to say the hybrid barrier itself increased the failure probability.
Here are the first few instances of this failure:
2016-10-19T07:09:08-9aed16e/linux-amd64-noopt
2016-10-27T14:56:06-4c18204/linux-amd64-noopt
Hybrid barrier started going in at aa581f51. Mostly no-op transformations as of the next failure, however. fixalloc now zeros by default, but not for mspan, which would be the obvious culprit.
2016-10-28T19:13:23-8a7f0ad/linux-amd64-noopt
Hybrid barrier is fully in as of bd640c882. However, next failure doesn't happen for another 81 commits, so maybe it wasn't the hybrid barrier that increased its failure probability.
2016-11-01T20:33:58-e22c796/linux-amd64-noopt
2016-11-02T21:33:03-688995d/linux-amd64-noopt
2016-11-03T18:10:35-18f0e88/linux-amd64-noopt
2016-11-03T20:18:52-2b59b15/linux-amd64-noopt
2016-11-03T22:43:50-b241a06/linux-amd64-noopt
All failures are on linux-amd64-noopt.
We've observed 68 failures so far. All of these are when running misc/cgo/test. 43 of them are when running misc/cgo/test in the "Testing race detector" section. The rest are when running misc/cgo/test regularly (without the race detector).
There are some slight variations on the failure. They're all roughly:
runtime: pointer 0xc4202cc7a8 to unallocated span idx=0x166 span.base()=0xc4202c6000 span.limit=0xc4202d0000 span.state=2
runtime: found in object at *(0xc42038ff68+0x8)
object=0xc42038ff68 k=0x62101c7 s.base()=0xc420388000 s.limit=0xc42038a000 s.sizeclass=2 s.elemsize=16 s.state=_MSpanStack
 *(object+0) = 0x5d4320
 *(object+8) = 0xc4202cc7a8 <==
fatal error: found bad pointer in Go heap (incorrect use of unsafe or cgo?)

18 failures have s.sizeclass=0 s.elemsize=0. Of these, 5 also have s.limit=0x0. 35 failures have s.sizeclass=2 s.elemsize=16. 15 failures have s.sizeclass=10 s.elemsize=144. In the sizeclass=10 failures, the first two words have the same pattern as all of the other failures and it's still the second word that's bad. In all cases, s.state=_MSpanStack.

The following reproduces it with high probability:
cd $GOROOT/src
GO_GCFLAGS="-N -l" ./make.bash
cd ../misc/cgo/test
go test -gcflags '-N -l' -c
GOTRACEBACK=2 GOGC=1 ./test.test -test.short

You can also reproduce it with -test.run=Test7978, though the probability is lower (though not super-low).
All failures are specifically in misc/cgo/test/issue7978.go and they all have the same stack that's being scanned. Here's a sample from 2016-11-29T15:27:49-d39b7b5/linux-amd64-noopt:
runtime: pointer 0xc4205dc7c8 to unallocated span idx=0x2ee span.base()=0xc4205d6000 span.limit=0xc4205c0000 span.state=3
runtime: found in object at *(0xc420388f98+0x8)
object=0xc420388f98 k=0x62101c4 s.base()=0xc420382000 s.limit=0xc42038df80 s.sizeclass=10 s.elemsize=144 s.state=_MSpanStack
 *(object+0) = 0x60f010
 *(object+8) = 0xc4205dc7c8 <==
...
runtime stack:
runtime.throw(0x6a1c75, 0x3e)
        /tmp/workdir/go/src/runtime/panic.go:596 +0x95 fp=0x7f765bff6618 sp=0x7f765bff65f8
runtime.heapBitsForObject(0xc4205dc7c8, 0xc420388f98, 0x8, 0xc41fffbfbf, 0xc400000000, 0x7f7669aa8f70, 0xc42001b228, 0x2)
        /tmp/workdir/go/src/runtime/mbitmap.go:433 +0x2bf fp=0x7f765bff6670 sp=0x7f765bff6618
runtime.scanblock(0xc420388f98, 0x18, 0x6a68d1, 0xc42001b228)
        /tmp/workdir/go/src/runtime/mgcmark.go:1220 +0x12b fp=0x7f765bff66e8 sp=0x7f765bff6670
runtime.scanframeworker(0x7f765bff6a00, 0x7f765bff6af0, 0xc42001b228)
        /tmp/workdir/go/src/runtime/mgcmark.go:925 +0xfc fp=0x7f765bff6778 sp=0x7f765bff66e8
...

goroutine 177 [syscall (scan), locked to thread]:
runtime.cgocall(0x60f010, 0xc4205dc7c8, 0xc4205dc798)
        /tmp/workdir/go/src/runtime/cgocall.go:130 +0x8b fp=0xc420388f98 sp=0xc420388f60
_/tmp/workdir/go/misc/cgo/test._Cfunc_issue7978c(0x13be988)
        _/tmp/workdir/go/misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294 +0x63 fp=0xc420388fc8 sp=0xc420388f98
_/tmp/workdir/go/misc/cgo/test.issue7978go()
        /tmp/workdir/go/misc/cgo/test/issue7978.go:95 +0x3b fp=0xc420388fe0 sp=0xc420388fc8
runtime.goexit()
        /tmp/workdir/go/src/runtime/asm_amd64.s:2184 +0x1 fp=0xc420388fe8 sp=0xc420388fe0
created by _/tmp/workdir/go/misc/cgo/test.test7978
        /tmp/workdir/go/misc/cgo/test/issue7978.go:113 +0xd1

The block that's being scanned is the arguments to runtime.cgocall in the frame of test._Cfunc_issue7978c at sp 0xc420388f98.
The caller probably doesn't matter since it's the arguments map, but here's its declaration and compilation with -N -l:
_Cfunc_issue7978c
//go:cgo_import_static _cgo_4d9b5135caa8_Cfunc_issue7978c
//go:linkname __cgofn__cgo_4d9b5135caa8_Cfunc_issue7978c _cgo_4d9b5135caa8_Cfunc
_issue7978c
var __cgofn__cgo_4d9b5135caa8_Cfunc_issue7978c byte
var _cgo_4d9b5135caa8_Cfunc_issue7978c = unsafe.Pointer(&__cgofn__cgo_4d9b5135ca
a8_Cfunc_issue7978c)

//go:cgo_unsafe_args
func _Cfunc_issue7978c(p0 *_Ctype_uint32_t) (r1 _Ctype_void) {
        _cgo_runtime_cgocall(_cgo_4d9b5135caa8_Cfunc_issue7978c, uintptr(unsafe.Pointer(&p0)))
        if _Cgo_always_false {
                _Cgo_use(p0)
        }
        return
}

""._Cfunc_issue7978c t=1 size=133 args=0x8 locals=0x30
        0x0000 00000 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   TEXT    ""._Cfunc_issue7978c(SB), $48-8
        0x0000 00000 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   MOVQ    (TLS), CX
        0x0009 00009 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   CMPQ    SP, 16(CX)
        0x000d 00013 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   JLS     123
        0x000f 00015 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   SUBQ    $48, SP
        0x0013 00019 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   MOVQ    BP, 40(SP)
        0x0018 00024 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   LEAQ    40(SP), BP
        0x001d 00029 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   FUNCDATA        $0, gclocals·09b80ec389a9e6ac09cfa1cd3c45263d(SB)
        0x001d 00029 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   FUNCDATA        $1, gclocals·568470801006e5c0dc3947ea998fe279(SB)
        0x001d 00029 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   NOP
        0x001d 00029 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   NOP
        0x001d 00029 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   LEAQ    "".p0+56(FP), AX
        0x0022 00034 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   MOVQ    AX, ""..autotmp_249+32(SP)
        0x0027 00039 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   MOVQ    ""._cgo_4d9b5135caa8_Cfunc_issue7978c(SB), AX
        0x002e 00046 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   MOVQ    AX, (SP)
        0x0032 00050 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   MOVQ    ""..autotmp_249+32(SP), AX
        0x0037 00055 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   MOVQ    AX, 8(SP)
        0x003c 00060 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   PCDATA  $0, $1
        0x003c 00060 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1294)   CALL    runtime.cgocall(SB)
        0x0041 00065 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   MOVBLZX runtime.cgoAlwaysFalse(SB), AX
        0x0048 00072 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   TESTB   AL, AL
        0x004a 00074 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   JNE     78
        0x004c 00076 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   JMP     121
        0x004e 00078 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   MOVQ    "".p0+56(FP), AX
        0x0053 00083 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   MOVQ    AX, ""..autotmp_250+24(SP)
        0x0058 00088 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   LEAQ    type.*"".C.uint32_t(SB), CX
        0x005f 00095 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   MOVQ    CX, (SP)
        0x0063 00099 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   MOVQ    AX, 8(SP)
        0x0068 00104 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   PCDATA  $0, $0
        0x0068 00104 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1296)   CALL    runtime.cgoUse(SB)
        0x006d 00109 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   JMP     111
        0x006f 00111 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1298)   MOVQ    40(SP), BP
        0x0074 00116 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1298)   ADDQ    $48, SP
        0x0078 00120 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1298)   RET
        0x0079 00121 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   JMP     111
        0x007b 00123 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1295)   NOP
        0x007b 00123 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   PCDATA  $0, $-1
        0x007b 00123 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   CALL    runtime.morestack_noctxt(SB)
        0x0080 00128 (.../misc/cgo/test/_test/_obj_test/_cgo_gotypes.go:1293)   JMP     0
        0x0000 64 48 8b 0c 25 00 00 00 00 48 3b 61 10 76 6c 48  dH..%....H;a.vlH
        0x0010 83 ec 30 48 89 6c 24 28 48 8d 6c 24 28 48 8d 44  ..0H.l$(H.l$(H.D
        0x0020 24 38 48 89 44 24 20 48 8b 05 00 00 00 00 48 89  $8H.D$ H......H.
        0x0030 04 24 48 8b 44 24 20 48 89 44 24 08 e8 00 00 00  .$H.D$ H.D$.....
        0x0040 00 0f b6 05 00 00 00 00 84 c0 75 02 eb 2b 48 8b  ..........u..+H.
        0x0050 44 24 38 48 89 44 24 18 48 8d 0d 00 00 00 00 48  D$8H.D$.H......H
        0x0060 89 0c 24 48 89 44 24 08 e8 00 00 00 00 eb 00 48  ..$H.D$........H
        0x0070 8b 6c 24 28 48 83 c4 30 c3 eb f4 e8 00 00 00 00  .l$(H..0........
        0x0080 e9 7b ff ff ff                                   .{...
        rel 5+4 t=16 TLS+0
        rel 42+4 t=15 ""._cgo_4d9b5135caa8_Cfunc_issue7978c+0
        rel 61+4 t=8 runtime.cgocall+0
        rel 68+4 t=15 runtime.cgoAlwaysFalse+0
        rel 91+4 t=15 type.*"".C.uint32_t+0
        rel 105+4 t=8 runtime.cgoUse+0
        rel 124+4 t=8 runtime.morestack_noctxt+0
gclocals·09b80ec389a9e6ac09cfa1cd3c45263d t=8 dupok size=10
        0x0000 02 00 00 00 01 00 00 00 01 01                    ..........
gclocals·568470801006e5c0dc3947ea998fe279 t=8 dupok size=10
        0x0000 02 00 00 00 02 00 00 00 00 02                    ..........

From this we can see that the bad pointer is the arg argument, which should be a stack pointer (&p0). However, based on the hex dump in the panic, the arg word clearly doesn't point to the stack, which suggests that the stack may have been moved without adjusting this pointer.

The args map for runtime.cgocall is {0b011, 0b000, 0b011, 0b000}. In this compilation, the failure happened at cgocall+0xb0, and the code path to there uses either map index 0 or 2, both of which have both arguments marked live.

I think I understand what's happening:

cgocall calls entersyscall, which saves the PC and SP of its call site in cgocall. Call this PC/SP "X". This PC has arg map 0b011, so both pointer arguments are live.
cgocall calls asmcgocall. Call the PC/SP of this call "Y". This PC has arg map 0b000 (index 3), so the arguments to cgocall are not live.
asmcgocall goes into the C code, which eventually calls back into the Go code.
cgocallbackg remembers the saved PC/SP "X" in some local variables, calls exitsyscall, and then calls cgocallbackg1.
cgocallbackg1 causes a stack growth. This stack unwind sees PC/SP "Y". Since the arguments are dead at "Y", they are not adjusted.
The callback into Go happens and returns.
cgocallbackg1 calls reentersyscall with the recorded saved PC/SP "X", so "X" gets stashed back into gp.syscallpc/sp.
GC scans the stack. It sees there's a saved syscall PC/SP, so it starts the traceback at PC/SP "X". At "X" the arguments are considered live, so it scans them, but since they weren't adjusted, the pointers are bad, so it panics.

@khr or @ianlancetaylor, any thoughts on the right way to fix this?

One might argue that all of cgo callbacks feel like a horrible, horrible hack.
I see nothing in your description that mentions noopt.  How is that relevant?
Would it help to give asmcgocall the correct args map (that its two args are pointers)?

If I understand this correctly, it seems like the key failure is that in asmcgocall the arguments are not considered to be live.  But why aren't they?  The function has a prototype in stubs.go, so according to funcdata.h it should have an implied GO_ARGS.  Why doesn't the stack traceback see that. consider the arguments to be live, and adjust any pointers they contain?

I see nothing in your description that mentions noopt. How is that relevant?

I can easily trigger this is on a regular opt build by forcing stack growth in the cgo callback of this test, so I think noopt just enlarged the existing stacks enough to cause a stack growth.

Would it help to give asmcgocall the correct args map (that its two args are pointers)?

No, I don't think so. The problem is the arguments to cgocall, not asmcgocall. When the GC stack trace runs, it doesn't even see asmcgocall on the stack (since it's starting from the entersyscall-saved PC/SP).

So if I understand this correctly, the nature of cgo calls is that we only see cgocall on the stack, we don't see the function that it called.  And we see cgocall at a point where the arguments are dead, because the compiler expects that if they are live the callee is going to mark them as live.  But in the stack traceback we never see the callee, so that doesn't help.
If that all sounds true I don't see why your earlier suggestion of using KeepAlive is a hack.  It sounds like exactly the right thing to do to get around the fact that the stack backtrace can not do the right thing.

Essentially, yes. We see cgocall twice: in the first stack trace (for stack growth) the arguments are dead, and in the second trace (for GC) they've risen from the dead and are live again. The undead arguments cause the crash.

If that all sounds true I don't see why your earlier suggestion of using KeepAlive is a hack.

Okay.
I checked all assignments to syscallsp/pc and this appears to be the only situation where we ever "roll them back".


"asciidoc" support lacks required CSS

Consider this line https://github.com/asciidoctor/asciidoctor/blame/d54440eb5e5651d7c3f0d9400cea210a5b475415/README.adoc#L54
The line reads
NOTE: With few exceptions, Asciidoctor is compliant with the original AsciiDoc processor.	Asciidoctor has well over 1,000 tests to ensure compatibility with the AsciiDoc

Expected result:
That line is rendered with a cute little "note" image, as shown in http://powerman.name/doc/asciidoc .
Actual result:
The line is rendered in http://rubydoc.org/gems/asciidoctor/file/README.adoc without the lcute little "note" image.

Closing out old issues.
I don't have much time to invest into customizing styles/semantics for asciidoctor, but if someone wanted to take this on, a PR could be looked at. Then again, this might be a better candidate for a plugin, if we're really looking at rewriting asciidoc's semantic output-- I don't believe something that complex would belong in YARD core.


Fix typo in readme

Coverage remained the same at 95.538% when pulling c1ca8cae7bad8e48be124d03155dd2c2a97873a5 on sachk:master into 45b129206ddde03dfc9e36bcc2c7940f33be5bc9 on Blosc:master.

Alright, I fixed the second one.

Thank you very much!!


"Format Selection" formats whole document

Given:
const obj = {
  foo: 1,
  bar: 2,
};

const Foo = (x) => (
  x
);

If I select the object, or an entry within…

…and then run the "Format Selection" command, the whole document is then formatted instead of just the selection, resulting in:
const obj = {
  foo: 1,
  bar: 2
};

const Foo = x => x;

It seems to me it formats the whole node which contains the selection.
So ti should format obj but not Foo
@josephfrazier should be able to tell us a little more about that :-)

I've been facing this for around two weeks or more. Maybe caused by #113?

From v0.18.0 release:

Improved range formater
@josephfrazier brought his work on prettier's range formater here. Our range formater is now improved working.
⚠ With eslint's integration it will format the entire document. But it still is waaaaaaaay better than before !

Weird that it was an already known behaviour and still released 🤔

I work on projects that haven't applied prettier on whole source code, but as I try to apply on my new code it reformats the whole document and make giant git diffs.

Same here.

"prettier.eslintIntegration": true:
Formats the whole document instead of the selection.

"prettier.eslintIntegration": false:
Formats the selection correctly if the selection is not at the beginning of the document

Formats the whole document if the selection is not at the beginning of the document

Thanks for the more detailed analysis.
The fact that it formats the entire document is a known issue (I forgot to open). Globally I found #113 to be better than what we had before. The entire range formater was buggy. You had to select a valid Program to avoid ParseError.

From https://github.com/esbenp/prettier-vscode/issues/134#issuecomment-310444168:

It seems to me it formats the whole node which contains the selection.
So it should format obj but not Foo
@josephfrazier should be able to tell us a little more about that :-)

Yes, prettier has to walk up the AST until it finds a formattable node, which in practice means one that could be a standalone Program. See https://github.com/prettier/prettier/pull/1659#issuecomment-303167383 for more details.

Fixed with latest release.

Nothing changed for me, still have the bug on v0.21.0.
@OliverJAsh Does it work for you?
cc @CiGit

@brunolemos This is known #137
The question currently is what to do with that case.

Still having this issue...

Same here with version 1.2.2

I know this is still a problem, but I am actually wondering why this is a use case?
Do people only use prettier on specific parts of the code? If so, why?

We haven't yet migrated to prettier wholesale. However, I personally love it, and use it to format blocks of untidy code (especially when pasting from elsewhere), which I then tweak slightly to match our house style. I can't format the whole file, as the resulting diff would be too noisy.

I have a similar approach of @georgecrawford. I kind of use the prettier as a first formatter and adapt some minor tweaks to our team code style. If I format all the file, my teammate wouldn't be very happy with the diffs on the code reviews ;)

Agree this is needed - selectively formatting parts of your code during transition periods is a common use case.

Agreed. When I edit some parts of the existing code and try to format the edited part, it formats the whole document, which leads to unnecessary changes in git.

@CiGit should this be reopened?
@josephfrazier has experience shown that this feature can work well with prettier?

The extension calls prettier's range formatter. This is enabled for a hardcoded list of language ids (Those I know support this feature).
here: https://github.com/prettier/prettier-vscode/blob/v1.6.1/src/utils.ts#L42-L51
For the case with eslint see #137
If there is something else, please open a new issue 😉

I believe I am also seeing this issue. Sad thing my company doesn't use prettier, but the worse thing is this "Format selection" formatting outside of my selection.


Update data provider registration messages

Add rich text format to the registration messages.
Provides links for OAI-PMH endpoint help and populates support email everywhere.
🐞Known bug: the email entities are not processed properly. It can be found typing something to fail the process. @Joozty this is what I wanted to show you as the continuation for the discussion about the percentage/HTML formatting. I will update it in the next commit.

Ok totally don't understand why it's that? The only change is that you email into a variable? What's the other difference?

Yes, this is the only change for the visual look. For the mailto: I probably changed before the testing because the string was shorter.

Wait a sec I don't understand why the first commit "introduced" bug. I mean the only change was that you created SUPPORT_EMAIL_URL and didn't put the email directly. Can you explain that to me? I am really curious why is that. 🙂

I merged #54 in here and squashed all the commits. It seems to be ready, let me ask @mcancellieri to doublecheck the messages.
@Joozty in my notes I see we should add a proper <title> somewhere to the data providers page.

I reviewed it and I like the messages now.

It's not bad, maybe we can add a

I don't find the FAQ useful but even confusing. We should link that question to the registration form.
When you come to the registration form you most likely passed that FAQ for one reason or another (searched the catalogue and decided to add, just decided to use the form – there should be no surprise it's already added). However, if you think the FAQ may be useful, we can include it to the 'already added' message as a description of the reasoning. I would not do it unless somebody asks.
What do you think @mcancellieri?


Add doctype

This will give you 100% on Best Practises on Google Lighthouse. :-)
https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Fwww.stopcovid19.jp%2F&strategy=desktop&category=performance&category=accessibility&category=best-practices&category=seo

Thank you!


config: Make default Linux filesystems an example

The MUST default-filesystem wording altered in #666 had read (to me, anyway) as:

The runtime MUST supply these even if the config doesn't call for them in mounts.

with #666 weaking it to:

The runtime SHOULD supply these even if the config doesn't call for them in mounts.

But that's not very useful (callers that need a given mount will still have to configure it explicitly).  However, one interpretation of the #666 wording seems to be something like:

Config authors probably want to include mounts entries for these.

That's fine, and this commit tries to make that interpretation more obvious by shifting the config recommendation over to the Linux mounts example.
This is one of the possible approaches I'd floated in #666.  Another approach is just dropping the section (#678), so this PR is a parallel alternative to #678.

REJECT
Please don't open two conflicting PRs for the same thing, at the same time.  Its confusing and just splits discussions.
Closing this in favor of the first one opened where there is discussion happening.


checkstyle: enforce static import of Preconditions utilities

Sample error:
[INFO] There is 1 error reported by Checkstyle 6.19 with beam/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/beam/runners/direct/AggregatorContainer.java:[21] (regexp) RegexpSinglelineJava: Static import functions from Guava Preconditions

R: @tgroh


Add IaC support instead of relying to AWS Console

PR #6  was merged accidentally and could not be re-opened. Here is the new PR which pursues the same goal

We need to add a logging feature with AWS Cloud Watch!

We need to attach AWSLambdaBasicExecutionRole and AWS managed policy that grants permissions to upload logs to CloudWatch. See docs

Logging feature added!

Issue #16 addresses a CI problem related to this PR that should be fixed

The purpose of this PR is fulfilled, We need to open a new PR for issue #19


⚠ Bofrost.fr has degraded performance

In ce307d0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 860 ms

Resolved: Bofrost.fr performance has improved in 4351c73 after 13 minutes.


Sema: Fix crash when defining an extension of a nested type with constrains [3.1]

If the nested type itself has generic constraints, we would
hit an assertion in requirement inference. Refactor some code
so that we can make the assertion more accurate.
Fixes rdar://problem/30353095.

@swift-ci Please test

@DougGregor Does this look good for 3.1?


Added base API URL to Firebase + Removal of unused code

Removed unused code also  modified code to minimise the code size.
Added Base of vachan Url using firebase.

Hi Samuel ,
I have done fixes but only for "Also can you change the apk name from
com.vachango to com.bridgeconn.vachango as that is a more standard way
of naming apps" you just create an issue because it may take little time
also after changing name need to test the app.
On Fri, Oct 16, 2020 at 10:47 AM Samuel Anthrayose<EMAIL_ADDRESS>wrote:

@samuelanthrayose commented on this pull request.
@neetuy https://github.com/neetuy Some minor changes. Kindly review it.
Also can you change the apk name from com.vachango to
com.bridgeconn.vachango as that is a more standard way of naming apps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Bridgeconn/VachanAppReact/pull/24#pullrequestreview-510104535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5M7KUAAN2MQTKEEHHLQ2DSK7JOLANCNFSM4SRPQT6A
.

Hi Samuel , I have done fixes but only for "Also can you change the apk name from com.vachango to com.bridgeconn.vachango as that is a more standard way of naming apps" you just create an issue because it may take little time also after changing name need to test the app.
…
On Fri, Oct 16, 2020 at 10:47 AM Samuel Anthrayose @.> wrote: @.* commented on this pull request. @neetuy https://github.com/neetuy Some minor changes. Kindly review it. Also can you change the apk name from com.vachango to com.bridgeconn.vachango as that is a more standard way of naming apps. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5M7KUAAN2MQTKEEHHLQ2DSK7JOLANCNFSM4SRPQT6A .

Sure Neetu. Will create a separate issue for that.


CartoDB Editor: Bubble map > Unclassed option

In addition to the classed option for bubble maps, we should also add an unclassed option.
Unclassed bubble maps, also known as proportional symbol maps, scale the size of symbols proportionally to the data value found at that location.
There are calculations that need to happen in order to get the correct symbol size for each data value.
Workflow

user selects the field that holds the values to be mapped
the square root for each value is calculated
based on the square root calculation and a user defined maximum symbol size (used for the largest data value) the sizes for all other symbols are determined using the following equation:
symbol size = (maximum symbol size) * (value/maximum value)
where:
maximum symbol size = largest symbol used for the highest data value
value = values from the square root field
maximum value = largest square root value
the resulting field that holds the values are used in the CartoCSS

CartoCSS
For example, if a field symbol_size is calculated, a user would simply do the following:

select the Bubble > Unclassed option
set marker-width:[symbol_size]; all of the symbols would draw accordingly
this step to me is important because I can't imagine what the CartoCSS would look like if every value and its associated symbol size was written out! Getting a calculated field makes this process really easy.
the user would then choose to order the data ascending or descending for visual clarity

Legend
We'll need to render legends that round the data values nicely and also, interpret legend shape sizes similar to how the symbol sizes are calculated for the map.  This is a nice tool.
Considerations/Questions:

maximum symbol size
we should have a default but the user should also be able to change that and the associated calculations would update and so would the map
d3 uses d3.scale.sqrt to calculate symbol size
in ArcMap, all symbol sizes are calculated up from a minimum symbol size
symbol size through scale
for both classed and unclassed bubble maps can we scale symbols based on zoom level?
OpenLayers has styling capabilities where symbols are automatically scaled to keep their relative size

Example workflow
I went through the process of recreating a d3 tutorial on proportional symbol mapping in CartoDB.
My complete process is outlined here:  http://maps.github.io/#ad331eadf355f042c0bc

Thanks for adding this feature! It's very useful to have this included in CartoDB.
There is another related improvement that could be considered. When it comes to labelling proportional circle maps it is common to displace labels according to the size of the circle to avoid overlap. In CartoCSS this would mean using a field expression in the properties text-dx & text-dy, e.g. "text-dx: [SymbolWidthField]". This is not currently possible.


something strange when unpacking dataset

I download CASIA-Webface (10K ids/0.5M images) from the original post
In script data_pipe.py, line 96, the image is saved by PIL.Image,which encoding image to RGB. I check the result after running prepare_data.py, most of the images are red.
Obviously, modify img = Image.fromarray(img) to img = Image.fromarray(img[:, :, ::-1]) would fix this problem, but I want to know if you design it deliberately, e.g., for post-processing or something else...

checkout: master, 350ff7a
Python version: Anaconda, 3.6.5
PIL version: 5.1.0
MXNet version: 1.4.1

Sorry, I had already checked the images in faces_emore/cfp_fp.bin. The format of the image saved in this matrix is indeed BGR.

I had already checked the images in faces_emore/cfp_fp.bin. The format of the image saved in this matrix is indeed RGB.

thanks, I have met the same problem. Got solved by your tip.


extensions-ci killed in Compile & Hygiene step

Builds:

https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=252136
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=252060&view=logs&j=bd1e231b-cef9-51a2-e461-b67194c0a817&t=a7f1014d-b95c-5a7e-9858-4d3087c99302
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=251908&view=logs&j=bd1e231b-cef9-51a2-e461-b67194c0a817&t=a7f1014d-b95c-5a7e-9858-4d3087c99302
https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=251859

extensions-ci           ] Killed
[extensions-ci           ] error Command failed with exit code 137.
[extensions-ci           ] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "extensions-ci" exited with 137.
error Command failed with exit code 1.

fyi @mjbvz @jrieken

Attempting a fix by simply doubling the max memory available to V8.

Again in https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=252956

Then I'm out of ideas. @mjbvz @jrieken we might need to split all those mangling tasks into independent processes, if memory limits are being hit.

Then I'm out of ideas. @mjbvz @jrieken we might need to split all those mangling tasks into independent processes, if memory limits are being hit.

Are we sure that we are on the right track here? According to my counting (below) we have only a tenth of the code in extensions (compare to the src-folder) so I wonder why mangling would eat up so much memory here?
jrieken@jrieken-m1-pro extensions % find . -name "*.ts" ! -path "**/node_modules/**" -print0 | xargs -0 cat | wc -l
  110343
jrieken@jrieken-m1-pro extensions % cd ../src
jrieken@jrieken-m1-pro src % find . -name "*.ts" ! -path "**/node_modules/**" -print0 | xargs -0 cat | wc -l
 1167084
jrieken@jrieken-m1-pro src %

I am not sure OOM is the symptom here actually, just my best hunch, but it seems extensions-ci is indeed the problem:

Added a every 1 second log of memory usage to this task: https://github.com/microsoft/vscode/commit/cc322086e842b0511d811da7d64069fe6e68a497
Build running: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=253615&view=results

Created https://github.com/microsoft/vscode/pull/203536 to log the memory usage after each mangling step

lol - similar idea here: https://dev.azure.com/vscode/VSCode/_build/results?buildId=113256&view=results

I think we are on to something here. The memory is growing a lot, maybe some state leaks when mangling the next extension. Each extension is its own tsconfig and mangling context. This shouldn't pile up but memory should be released inbetween

@mjbvz Can you take a look at this? I put my money on this map which keeps its mangler around. Looks like we need some webpack hook to dispose that loader

@mjbvz I gave it a stab at https://github.com/microsoft/vscode/pull/203536 for which I have confidence, running yarn extensions-ci locally shows how memory is growing and shrinking! This isn't a webpack change but just some cleanup in the mangler itself


Add checkpoint callback

Add a checkpoint callback to the train function.
Exclude the gradient from the training state pickle file since it is not needed when training is resumed
Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[x] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs? No change
[ ] System tests pass (pytest test/system)
[x] Passed code style checking (./style-check.sh) (Already not passing)
[ ] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I submitted a separate PR for socjeye_2 branch

Thanks! The Travis failure for pylint seems unrelated. Probably travis updated the pylint version, I'll take a look.


Updating emulation tests

closes #33

any updates here @IdaTucker ?

I've created a branch (called refactoing) from dev, and I'm currently running the tests with both nano-s and nano-x (I had disabled nano-x for a while as the tests where failing). Now all those that where not commented out pass, but I might try and get the other commented out tests to work before I carry on refactoring the crypto.c and zip32.rs code.


Added support for remoting + run under ADMIN (instead of SYSTEM)

I was in need to run some code under logged users on remote computers, so I've modified your function a little bit.
PS: because I am sending this function to remote session I was forced to add $Source in function body, so there are no dependencies left behind
PPS: I am using this as single function, not as module

There's other projects that support this under local admin, this is really made just for RMM systems and running under system. I don't think it's a good plan to deviate from that too much because we have a little over 2.4 million active users.
I'll have to deny the PR, but thank you for the contributions 🙇


devDependencies: replace "pouchdb" with "pouchdb-core", "pouchdb-mapreduce" and "pouchdb-adapter-memory"

adapt tests/integration/utils/get-server.js accordingly

closing in favor of https://github.com/hoodiehq/camp/issues/59


IDEA: Add a TreeView Example

TreeView's are one of the more important and versatile interface-types for C4D. It would be great if the SDK included a working example.

Thanks a lot, for this idea, this is for sure something we will consider to add into our examples sets.
For the time being, you can find information about them on this plugincafe post https://plugincafe.maxon.net/topic/10654/14102_using-customgui-listview/2.
If you have any other request, please let us know, I've introduced the Idea label, so please use it, instead of a special naming tagging.
And if you have any question regarding TreeView, feel free to open a discussion on https://plugincafe.maxon.net.
Cheers,
Maxime.


execute().get()

Hello, I am trying to upgrade my app and I saw your repo on stackoverflow. I started the using it but how can I get the return data of doInBackground. Normally using it with
sync.execute().get();
On the other hand I am using all executes with null param. Is it correct?
@JohnyDaDeveloper

Hi! You can work with result of doInBackground() in onPostExecute().
It works like this:
First, the onPreExecute() is called on the UI thread, then the doInBackground() is called on the background thread and after the doInBackground() is finished, the onPostExecute() is called on the UI thread.
Params of the execute() are sent to doInBackground().

Hi! You can work with result of doInBackground() in onPostExecute().
It works like this:
First, the onPreExecute() is called on the UI thread, then the doInBackground() is called on the background thread and after the doInBackground() is finished, the onPostExecute() is called on the UI thread.
Params of the execute() are sent to doInBackground().
@MaxAndolini

I know that but normally we can get the return value of doInBackground with execute().get() how can we do this with your module. I am asking this.

I didn't implement this. Doesn't get() block your UI thread?
@MaxAndolini

I didn't implement this. Doesn't get() block your UI thread?
@MaxAndolini

I know you didnt. am trying to get google play version with this from another class which is asynctask class. Can you do a implementation for me?

I can try it. Give me few days
@MaxAndolini

How can i handle this scenario using this code?
public ProfileEntity getProfile(Long id) {
        try {
            return new GetProfileAsyncTask(profileDao).execute(id).get();
        } catch (ExecutionException e) {
            e.printStackTrace();
        } catch (InterruptedException e) {
            e.printStackTrace();
        }
        return null;
    }

private static class GetProfileAsyncTask extends AsyncTask<Long, Void, ProfileEntity> {
        private ProfileDao profileDao;

        private GetProfileAsyncTask(ProfileDao profileDao) {
            this.profileDao = profileDao;
        }

        @Override
        protected ProfileEntity doInBackground(Long... ids) {
            return profileDao.getProfile(ids[0]);
        }
    }

How can i handle this scenario using this code?
public ProfileEntity getProfile(Long id) {
        try {
            return new GetProfileAsyncTask(profileDao).execute(id).get();
        } catch (Exception e) {
            e.printStackTrace();
        }
     return null;
    }

private static class GetProfileAsyncTask extends AsyncTask<Long, Void, ProfileEntity> {
        private ProfileDao profileDao;

        private GetProfileAsyncTask(ProfileDao profileDao) {
            this.profileDao = profileDao;
        }

        @Override
        protected ProfileEntity doInBackground(Long... ids) {
            return profileDao.getProfile(ids[0]);
        }
    }

I asked almost same thing 😂

        getVipUyelikControl getVipUyelikControl = (getVipUyelikControl) new getVipUyelikControl().execute(null);

        return getVipUyelikControl.getVIPStatus();

I created getVIPStatus in Task but I cant reach that;
        private boolean getVIPStatus() {
            return this.myValue;
        }

@JohnyDaDeveloper

Any news?
@JohnyDaDeveloper

Waiting for developer response.
@MaxAndolini do you find any alternative ways for replacing AsyncTask on JaVa code?

Waiting for developer response.
@MaxAndolini do you find any alternative ways for replacing AsyncTask on JaVa code?

No, still waiting.

Sorry it took so long, but I added AdvancedAsyncTask which has the get() method and has slightly different execution process.
Just remember that onPreExecute() and onPostExecute() are always executed on UI thread.
@MaxAndolini

Sorry it took so long, but I added AdvancedAsyncTask which has the get() method and has slightly different execution process.
Just remember that onPreExecute() and onPostExecute() are always executed on UI thread.
@MaxAndolini

Required type:
boolean
Provided:
Void

It is returning Void type.

@MaxAndolini
Can you show me your code? It should return same thing as doInBackground()

@MaxAndolini
Can you show me your code? It should return same thing as doInBackground()

Can you post an example for return.

Example task:
`public class ExampleTask extends AdvancedAsyncTask<String, Integer, Boolean> {
private static final String TAG = "ExampleTask";
@Override
protected void onPreExecute() {
    Log.i(TAG, "onPreExecute");
}

@Override
protected Boolean doInBackground(String s) throws Exception {
    Log.i(TAG, "doInBackground: " + s.equals("Hello"));
    return s.equals("Hello");
}

@Override
protected void onPostExecute(Boolean aBoolean) {
    Log.i(TAG, "onPostExecute: " + aBoolean);
}

@Override
protected void onBackgroundError(Exception e) {
    Log.e(TAG, "onBackgroundError", e);
}

}`
Using ExampleTask:
`ExampleTask exampleTask = new ExampleTask();
exampleTask.execute("Hello");
try {
Boolean output = exampleTask.get();
} catch (Exception e) {
e.printStackTrace();
}`
You need to call execute() before calling get(). I've updated the AdvancedAsyncTask so now it throws TaskNotExecutedException if you call get() before execute().
@MaxAndolini

Hello @JohnyDaDeveloper
It doesn't work while i write return new GetProfileAsyncTask(profileDao).execute(id).get();
Can you look out why it not working on single line?

@JohnyDaDeveloper
Why it is necessary to override onPreExecute(),onPostExecute(),onBackgroundError()?
Can't you make it as optional import?

@techxonia
execute() now returns AsyncTask/AdvancedAsyncTask, so the single line thing should work now.
I've also made the onPreExecute() and onPostExecute() optional, so you don't have to override them, but you should always handle background errors

Hello @JohnyDaDeveloper
Yeah not it works on single line.
Can you please tell me why i need to handle onBackGroundError()? What might be other possibility to be get crash on this code? What happen if i didn't handle onBackgroundError?
I have already wrap the code with exception handler don't it work to handle background error.

@techxonia
If you're using get(), you don't need to override onBackgroundError(), just leave it empty.
The onBackgroundError() is mainly for showing error messages to the user, because it's executed on UI thread.
I just wanted it there, because one of the reasons they deprecated AsyncTaks was that it was "swallowing" background errors, so I wanted to "force" users to handle them.
Hope it makes some sense

@techxonia
The doInBackground() method can throw Exception and if it throws any, the onBackgroundError() will be execued and the get() method throws the same exception.
ExampleTask exampleTask = new ExampleTask() {
    doInBackground(String input) {
        throw new Exception("Some exception");
    }

    onBackgroundError(Exception e) {
        Log.e(TAG, "Handling exception on UI thread");
    }
}

try {
    exampleTask.execute(input).get();
} catch (Exception e) {
    Log.e(TAG, "Handling exception on this thread");
}

The Exception from onBackgroundError() is the same as the one in the try-catch

        @Override
        protected boolean onPostExecute(Void result) {

'onPostExecute(Void)' in 'com.app.ActivityMessageContent.getVipUyelikControl' clashes with 'onPostExecute(OUTPUT)' in 'com.app.AdvancedAsyncTask'; attempting to use incompatible return type
@JohnyDaDeveloper

@MaxAndolini
onPostExecute() must have void return type

@MaxAndolini
onPostExecute() must have void return type

Cant we return anything from post executive, i mean at the end.

@MaxAndolini
Why would you want to return something? Can you show me how are you using it? I have a feeling you are doing something wrong


fix glossary instructions

what's changed

Glossary implementation has changed, so updated instructions accordingly

reviewers
@johndmulhausen @mstanleyjones
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

Excellent, I should have done this earlier. Thanks, @londoncalling :)


Storage space (boxes and bulk of small items) in the office

Part of https://github.com/130s/30y-130s_life/issues/1222
In my multi-functionin office (a.k.a storage??) where there's no closet, I need to utilize space wisely.
My easy solution is to add a shelf(/ves).
Usecases and requirement: https://github.com/130s/hut_10sqft/issues/454#issuecomment-699943112 can be a basis but I have some updated needs. These are subject to change:
Usecases:

Want to keep lots of boxes, some are large as Turtlebot2 container.
Want to use one of the surfaces for experiment, esp. depth sensors' target surface. The vertical clearance of this surface may need to be taller than each layer's clearance.
Bookshelf

Requirement:

Floor stand. Heavier items intended.

Wall-mount can be involved for some cases though.

2 or 3 surface layers of shelves minimum.
Size

Some surface can be lower than 4 feet height, but not all.
11 inches width is not sufficient for placing objects I want to.

Some known shelves

I should utilize Yuanshikj https://github.com/130s/hut_10sqft/issues/454#issuecomment-688660972 this time, but that cannot be sufficient.
The one I bought multiple times from wayfair https://github.com/130s/hut_10sqft/issues/454#issuecomment-703263705 seems to be off link now.
BON AUGURE 30"x13"x65" (amazon.com). Looks sturdy (130 lbs each layer).
Taylah 70'' H x 53.1'' (wayfair.com)

Says "Shelf Weight Capacity 500 lb." I guess total. So roughly 100 lbs per layer?

Keedy 27.6'' W Ladder Bookcase (wayfair.com) Maybe I want more utilization of vertical space.
Tribesigns Triple Wide 6-Shelf (amazon.com) 25 lbs per layer. Not enough.
SUPERJARE 5-Shelf Industrial Bookshelf (amazon.com) 70 lbs per layer.
SUPERJARE Triple Wide 5-Tier Bookshelf (amazon.com) 70 lbs per layer, adjustable vertical clearance
IRONCK Bookcases and Bookshelves 4 Tiers Industrial Triple Bookshelf (amazon.com) $169. Only 33 lbs per tier
oneinmil Triple Wide 5-Shelf (amazon.com) 70 lbs per tier. Adjustable tier height $169

Inclined to oneinmil one but noticed shipping fee is almost $100. Moved to review.

Went with oneinmil. Embrace the cost, as it could still be cheaper compared to potential opportunity cost.


Critical error on Win10 PRO

Can canfirm this issue. They seem to have changed something in the JSON file. Will look into it


🙀 Emjoji in table not working in Github Enterprise

For some reason, the unknown boxes come up for all the emojis in the table:

Emojis for no changes work fine:

The emojis display correct in the comment editor:

And obviously I can replace the emojis and they work fine.
This is using GH Enterprise 2.6. HTML appears to be the same and the emoji is there when I inspect the source. Just won't display properly the first time when coming from CI 😢

Hi @mtitolo 👋
Thank you for reporting! I think the problem is due to an encoding issue with your CI. We use GH Enterprise 2.6 at @lyst and we haven't had any problem so far. Which CI system are you using?
Anyway, I'm going to submit a PR replacing the unicode characters for github emoji codes : skull :, : no_entry_sign :, etc that should solver our issue.

Hi again @mtitolo 👋
I've just released 0.11.1 which should fix your problem. Let me know if it actually does it!


HotBarPlus Problem

Heyyyyy, got a compatibility problem with your HotbarPlus mod. As soon as I grab an item for a reserved slot, all but 4 of my regular slots are sucked in to overlap with the bottom right corner of the reserved slots. All items for reservation are also piled on top of each other. The normal slots are inaccessible.
ReservedItemSlotCore settings:
ForceEnableThisModIfNotEnabledOnHost: false
DisplayNegativePrioritySlotsLeftSideOfScreen: true
FocusReservedItemSlotsHotkey: /leftAlt
ToggleFocusReservedHotbar: false
PreventReservedHotbarSlotFade: false
EnablePurchasingItemSlots: false
GlobalItemSlotPriceModifier: 1
HotbarPlus settings:
UseHotbarNumberHotkeys: false
InvertHotbarScrollDirection: true
OverrideHotbarHudSpacing: 4
OverrideFadeHudAlpha: 0.13
OverrideHotbarHudSize: 1
UseItemQuickDropConfig: false
UseDefaultItemSwapInterval: false
UseDefaultItemDropInterval: false
UseDefaultItemActivateInterval: true
HotbarSize: 10

If you could verify for me if this has been fixed in the latest version or not, that would be  great! If so, let's close this issue.

After testing last night, the error appears to be fixed. Thanks!


Upgrade to Newest version for Tailwind and NextJS

upgrade landingpage to newest version of Tailwind and NextJS

Tailwind ver 3.18
NextJS ver 12.3

assign it to me
i will do it

i will install latest version of Tailwind  and nextJs

oke, good luck!


BUG: file inputs are not accessible to docker containers

file types are uploaded to /tmp, which is not mounted to child docker containers

fixed via commit to dev branch: ae72ba6fdc3adb1d26b12ca5a01e41845bc2fb7b


GPT text generation with KerasNLP Example error

Hello, in the GPT text generation example with KerasNLP (https://keras.io/examples/nlp/text_generation_gpt/)
when executing the code associated with # Train tokenizer vocabulary the following error is thrown:
AttributeError: module 'keras_nlp.tokenizers' has no attribute 'compute_word_piece_vocabulary'
I have tried with several versions of keras-nlp but I have not fixed the error.

@ygModesto Actually the error is caused because the latest release of KerasNLP doesn't yet have the compute_word_piece_vocabulary function. If you want to run it you can install KerasNLP from github directly using this syntax -
pip install git+https://github.com/user/repo.git@branch

hi, am trying to pip install keras-nlp, using pip install git+https://github.com/user/repo.git@branch, but am getting not found error.

@Alpes-ai Hey that was just a placeholder should've been more clearer :(
Instead of that link use the link from the KerasNLP repository with the master branch, hope that sorts it!

Same here am getting the error when I pip install  []pip install git+https://github.com/user/repo.git@branch)
fatal: could not read Username for 'https://github.com/': No such device or address

yeah, now the model is loaded, thanks for your support.

use this command its working: pip install git+https://github.com/keras-team/keras-nlp.git

Hi, also I tried installing using [,](pip install git+https://github.com/keras-team/keras-nlp.git), but I still get the same error. is there a workaround or a solution?
the error is like:
AttributeError: module 'keras_nlp.tokenizers' has no attribute 'compute_word_piece_vocabulary'

Thanks
Hi, tried installing using [,](pip install git+
https://github.com/keras-team/keras-nlp.git), but I still get the same
error. when training the tokenizer, is there a workaround or a solution?
the error is like:
AttributeError: module 'keras_nlp.tokenizers' has no attribute
'compute_word_piece_vocabulary'
regards
On Sat, Aug 27, 2022 at 7:51 AM Naresh Sandrugu @.***>
wrote:

use this command its working: pip install git+
https://github.com/keras-team/keras-nlp.git
—
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras-io/issues/1031#issuecomment-1229129929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDRARVRNRXLCDQ7UJHWBPTV3GUELANCNFSM56UYI4GQ
.
You are receiving this because you commented.Message ID:
@.***>

--
--
DISCLAIMER *** This message and any attachments are confidential and
intended solely for the addressee. The following link will display the full
disclaimer: http://www.ul.ac.za/disclaimer.jpg
http://www.ul.ac.za/disclaimer.jpg ***
--
https://www.ul.ac.za/index.php?Entity=c_events&TheS=970#start
https://www.ul.ac.za/index.php?Entity=c_events&TheS=970#start

Thanks,  It worked after importing 'compute_word_piece_vocabulary' 👍 [from keras_nlp.tokenizers.word_piece_tokenizer_trainer import (
compute_word_piece_vocabulary,].
But now it complains when executing #StartEndPacker
[    TypeError: Exception encountered when calling layer "start_end_packer_1" (type StartEndPacker).
in user code:

    File "/usr/local/lib/python3.7/dist-packages/keras_nlp/layers/start_end_packer.py", line 123, in call  *
        batch_size = tf.shape(inputs)[0]](url)

Please help.

am sturck at this point with error any one can help, for reference purpose screen shot below

Exactly the same problem I have Naresh, any help, please🤔
On Sat, Aug 27, 2022 at 1:48 PM Naresh Sandrugu @.***>
wrote:

am sturck at this point with error any one can help, for reference purpose
screen shot below
[image: image]
https://user-images.githubusercontent.com/59958507/187028860-711c901e-81af-492e-ae4a-9c5f57ac8486.png
—
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras-io/issues/1031#issuecomment-1229177581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDRARR7VBH53ZWQUEQO3I3V3H6BPANCNFSM56UYI4GQ
.
You are receiving this because you commented.Message ID:
@.***>

--
--
DISCLAIMER *** This message and any attachments are confidential and
intended solely for the addressee. The following link will display the full
disclaimer: http://www.ul.ac.za/disclaimer.jpg
http://www.ul.ac.za/disclaimer.jpg ***
--
https://www.ul.ac.za/index.php?Entity=c_events&TheS=970#start
https://www.ul.ac.za/index.php?Entity=c_events&TheS=970#start

yeah, also facing the same issue with start_end_packer function, even i tried with simple examples from keras link like: https://keras.io/api/keras_nlp/layers/start_end_packer/
the below are error,any one can help this

@ygModesto, @Simon-PSR, @NareshSandrugu, linking a comment here, which will solve your issue: https://github.com/keras-team/keras-nlp/issues/301#issuecomment-1221337946. Hope this works! Colab has an older version of TensorFlow pre-installed...so, it has to be uninstalled first.

Thanks Abheesht, start_end_packer issue resolved.

@fchollet we an close this issue

The example has been updated to work with Keras 3 and it is working well, please find the example link here for the code and details https://keras.io/examples/generative/text_generation_gpt/


[GHSA-wx54-3278-m5g4] Integer overflow in BCrypt class in Spring Security

Updates

Affected products

Comments
According to Patch, this vulnerability was introduced from 5.2.0.RELEASE.

Hi @SunBK201, I looked into the history of the file BCrypt.java and saw that most of the code changed in fix commit https://github.com/spring-projects/spring-security/commit/a40f73521c0dd88b879ff6165d280e78bdf8154f was added in version 3.1.0.RELEASE, specifically https://github.com/spring-projects/spring-security/commit/8565116f203b9c6186b044bc655c9d5d5b2e6450. Are there any changes to BCrypt.java that occurred in 5.2.0.RELEASE that lead you to believe 5.2.0.RELEASE is the first vulnerable version?

According to spring-projects/spring-security@a40f73521c0dd88b879ff6165d280e78bdf8154f, vulnerable method crypt_raw in 5.1.13. Vulnerability statement rounds = 1 << log_rounds; does not exist in 5.1.13, induceing commit: spring-projects/spring-security@388a7b62b906bd56deadb7ca45248fa1a63bdf12 in 5.2.0

Hi @SunBK201, thank you for showing me the commit that introduced rounds = 1 << log_rounds;! After comparing https://github.com/spring-projects/spring-security/commit/388a7b62b906bd56deadb7ca45248fa1a63bdf12 and https://github.com/spring-projects/spring-security/commit/a40f73521c0dd88b879ff6165d280e78bdf8154f, I agree that it makes sense to set 5.2.0.RELEASE as the minimum vulnerable version.


Allow skip from test context for #332

Opening a PR to get some feedback for this implementation.

Needs rebasing again. I will merge if you rebase. Sorry for the hassle.

Rebased again, no issues or conflicts :smile:

Thanks!

any chances to see new version with this feature included soon?

I can't get this to work with webdriver.io (see below example). Also, was this really merged? This feature doesn't seem to be present in the current version of mocha??
`it('should be skipped async', function(done){
var self = this;
setTimeout(function(){
self.skip(); //works -- test prints as pending in terminal
},1000);
driver.waitForExist('body').then(function(){
	console.log(self); //correct
	self.skip.bind(self)(); //doesn't work -- test prints as error in terminal
});

})`

This was merged in 6402fff so is present in 2.2.0+. Any more information on the error? May be worth filing a separate issue.

@maggiesavovska what's the error? Is the test timing out, or is it something else?

I just experienced this:
async.js
it('should be skipped async', function (done) {
  const self = this
  setTimeout(function () {
    self.skip()
  }, 1000)
})

$ mocha test/async.js

  1) should be skipped async

  0 passing (1s)
  1 failing

  1)  should be skipped async:
     Error: the object {
  "message": [undefined]
  "uncaught": true
} was thrown, throw an Error :)

@dasilvacontin + @cmbuckley: Please forget what I said about webdriver.io. I think it's a general issue. I get the same as @dasilvacontin (uncaught error with undefined message). I actually was only able to get this to work at all by modifying the current version of mocha so I'm guessing this feature is somehow broken due to recent changes (regardless of whether its used with webdriver.io promise or not).

Hi, sorry to be a bug, but were you able to confirm that this feature isn't currently working? I really need this for the project I'm working on now. Thanks!

Well, I can confirm @dasilvacontin 's code is throwing that error

Is this a regression?  Did we ever have this support for async tests?


Support module with multiple imports with different alias

Currently, this test case in imports_test demonstrates how it doesn't work
{
	name: "import module aliased twice",
	source: `
		import module1 as a
		import module1 as b
`,
	want: map[string]Import{
		"module1": {Name: "module1", Alias: "a"},
	},
},

This shows that FindImports ignores the alias b.

Motivating use case:
# @klotho::persist {
#   id = "main-fs"
# }
import aiofiles as klothofs

# @klotho::persist {
#   id = "secrets"
#   secret = true
# }
import aiofiles as secrets

Pulling into prioritization to at least better understand it.

The big open question is, are we able to create both a secret and non-secret fs in a single py file?
If the fix is simple, do it. If it's multi-day, please raise that in sync.

I don't think this bug is due to the import detection, but it does occur:
# @klotho::persist {
#   id = "hello"
#   secret = true
# }
import aiofiles as secrets

# @klotho::persist {
#   id = "hello"
# }
import klotho_runtime.fs_hello as cloudfs

So it's somewhere in the persist plugin or annotation detection.


EchoMimic is open-sourced

EchoMimic is capable of generating portrait videos not only by audios and facial landmarks individually, but also by a combination of both audios and selected facial landmarks.
Project link: https://badtobest.github.io/echomimic.html
GitHub link: https://github.com/BadToBest/EchoMimic

https://github.com/JosephPai/Awesome-Talking-Face/assets/18476076/73840a0a-c8d5-4f87-884f-4784ab5dbc61

@lymhust Super interesting work! It is now in our paper list.


[21.11] nats-server: add patch for CVE-2022-24450

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2022-24450
https://advisories.nats.io/CVE/CVE-2022-24450.txt
See #158847 for master.
Needed minor (whitespace) modifications to patch to apply cleanly. Omitted extensive test changes from patch to reduce size - we don't currently have the tests working anyway. Seeing as this is actually a minor feature removal we could possibly have got away with simply adding a couple of lines somewhere simply saying "Nope" if the feature was ever used :shrug:
cc @derekcollison
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

If you updated to 2.7.2 that has this covered, no need to path. Or am I missing something?

This patch is a backport to 21.11, fixing the CVE but not picking up any of the features from 2.7.  Seems like a good idea to me.

That does not sound too smart to me actually. We only support OSS current version and one before that officially.

Problem is, if every one of the thousand or so packages that make up a typical linux installation had the same policy, it would make running a stable linux distribution impossible. To an extent, you can see what that would be like by looking at the unstable/master branch - things break all the time, and it's not advisable to run a production system on.
 That ubuntu or debian nginx box you had to quickly spin up to serve some auxiliary boring need the other day? Look closely... patches! https://sources.debian.org/patches/nginx/1.18.0-6.1/
That said, patching is not done blindly and we generally try to make sure we understand the changes made by the patch and that the change is still a valid fix when applied to the older source. Particularly, this is why we really like to have the tests enabled for as many packages as possible (hint hint package maintainers hint hint) to give us extra confidence in any changes we have to make.
In this specific circumstance, 2.6.0 -> 2.7.2 isn't a huge jump, so it is arguable that we could just bump here. But we tend to reserve that for situations where the change is complicated or hard to identify or it's a small patchlevel version upgrade.

That is not how stable branches work. Continually choosing the latest version of everything is called nixos-unstable, and users are free to use that if that's what they want. They're even free to mix & match packages from both branches.
90% of projects "don't support" anything other than the absolute latest versions of everything, but luckily software doesn't magically stop working a two months after its release, because trying to run a system on such a bleeding edge foundation would be impossible.

Describing something as "fast moving" doesn't increase confidence in pulling it in to a stable distribution. People who use stable distributions (and we're only talking 6 months max here!) need to be able to confidently apply security updates and know they're not going to wake up to a nasty surprise in the morning when they've had the fast moving progress on the hot new feature landed on them without warning.

Most production systems pin to a version as I am sure you are aware, and updates are a conscious decision to make, regardless if source of the code like Nix.
I understand the purpose of the stable channel, I just do not agree with it. I feel this is more accurately reflected in the project itself with releases, LTS etc.
That being said, I do not expect to sway you, and will try to make sure the unstable branch under Nix is current (its behind too at 2.7.0).
But to be clear, for our users and ecosystem, especially those using the JetStream subsystem, we will have to ask folks to stay clear of Nix stable.

Really, that's fine and to some extent expected :+1:
But I wouldn't look at https://repology.org/project/nats-server/versions if I were you :smile_cat:

What is that link? What version all of the outdated linux package systems have? ;)
Yea they all are pretty slow an outdated sans OpenPKG it seems.

Result of nixpkgs-review pr 160521 run on x86_64-linux 1

3 packages built:

nats-server
python38Packages.asyncio-nats-client
python39Packages.asyncio-nats-client

2.7.2 will soon be in unstable. Merging this patch for backport as it seems it can be supported with no user-facing changes. Users specifically interested in the latest JetStream should look at getting nats from unstable branches instead.

With nixos offering such an easy and reliable way for users to pick up changes from unstable, be it a package or a module, patching is the right approach to managing the stable release. Thanks everyone!

This is very true; in our deployments of NATS (and most of our other
dependencies), we overlay the source and version routinely, pulling out the
overlays at the next NixOS version.
On Sun, Feb 20, 2022 at 10:14 AM Martin Weinelt @.***>
wrote:

With nixos offering such an easy and reliable way for users to pick up
changes from unstable, be it a package or a module, patching is the right
approach to managing the stable release. Thanks everyone!
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/160521#issuecomment-1046292789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5K7DRXWDIBWW4IIA5QBTU4EVRPANCNFSM5OWGLVVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>