Refactor checkout page

Describe your changes
Refactored checkout page React component into smaller components. Previously the checkout page was one giant component. Now the checkout page has been refactored in a few smaller components including a ShippingInfo and PaymentInfo component.
Name of Contributor
Abdul
Type of change
Refactor
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My code does not generate any new warnings or errors
[ ] New and existing unit tests pass locally with my changes (if relevant)

Hi, Abdul!
As per the group consensus, local components must be in a separate file and should be made inside the same directory.
So, local components 'ShippingInfo' and 'PaymentMethod' must be moved out of src/routes/Checkout/index.jsx to a new local component file within that directory.

Just finished the refactoring :)

OK, I think I've completed the refactor :) Sorry for the late response. Any other changes you'd like me to make?


Hitting browser refresh in Sandcastle causes Gallery to go blank

I personally feel this is a showstopper.

It's because the query string has label=undefined.  It's not being set properly

That's always happened in Sandcastle, but it's much worse now because any refresh breaks it.

Also, linking like this now break too: http://localhost:8080/Apps/Sandcastle/index.html?src=3D Models.html&label=Showcases


nerdctl push image can't show right rate

Description
I push image local image to harbor with nerdctl ,the nerdctl show wrong upload rate .
root@ubuntu:~/tmp/tmp# nerdctl -n k8s.io push repository.knowdee.com/library/controller:v1.7.0
INFO[0000] pushing as a reduced-platform image (application/vnd.docker.distribution.manifest.list.v2+json, sha256:edce17b7affcfd0a09bb444e230b74875e935d60c5045f510bc7f7095532f068)
index-sha256:edce17b7affcfd0a09bb444e230b74875e935d60c5045f510bc7f7095532f068:    done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:48cbda0f953e398cdcad7129aadb4fb0338a991299b6b466c778906dc39837ec: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:0d4c0564c46586dec1712522231ff4b2dc2864ebbb46c9b9040b22e971819b05:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 44.5s                                                                    total:  13.4 K (308.0 B/s)

The command line show the rate of upload is 308.0 B/s, But the actual upload speed is much greater.
I think what wrong happend about nerdctl .
Steps to reproduce the issue

Describe the results you received and expected
nerdctl can show the upload speed in real time and correctly.
What version of nerdctl are you using?
root@ubuntu:~/tmp/tmp# nerdctl --version
nerdctl version 1.4.0
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
root@ubuntu:~/tmp/tmp# uname -a
Linux ubuntu 5.19.0-43-generic #44~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon May 22 13:39:36 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

It has been fixed in the containerd , so would we close it ?
/close


Resolve save conflict bar: add more informative tooltips and reposition buttons

The "Resolve save conflict" bar is confusing.  I believe the current design, clicking the curled back arrow which is displayed on the right (tooltip: "revert changes") accepts the file on the left ("on disk"), whereas the checkmark button displayed _on the left (tooltip: "accept changes") accepts the file on the right ("in Code"). This seems needlessly confusing and I have to google the Resolve Save Conflict view in order to make sure I'm not about to butcher my file.
I would propose that the button that corresponds to accepting the file view displayed on the left be displayed on the left, and the button corresponds to accepting the file view displayed on the right be displayed on the right. And they should have tooltips saying "accept left" and "accept right" respectively.
The behavior in PyCharm is much more intuitive on this.
https://code.visualstudio.com/docs/getstarted/tips-and-tricks#:~:text=VS Code blocks saving the,made outside of the editor.&text=Use the actions in the,to the version on disk.
VS Code:

PyCharm:

This either goes to @bpasero or @hediet I think?

//cc @daviddossett

I think we can easily update the tooltip with more information. I am not sure about changing the position, this may break muscle memory that has been built up.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


add solution - 958

Added solution 958

I’m so~o sorry, I’ve been busy with moving, changing country residence, flying to the United States and other things recently. I have been delayed this PR for half a month.


PyPI reports traitlets 5.2.2.post0 exists

Describe the bug
First noticed in poetry Issue #6826, commitizen GitHub Actions CI workflows fail when poetry resolves traitlets:
Package traitlets (5.2.2.post0) not found

Neither the PyPI release history nor the repo releases indicate a version 5.2.2.post0 was released. However, when we curl pypi.org, we receive a hit for 5.2.2.post0:
$ curl -s https://pypi.org/simple/traitlets/ | grep 5.2.2.post0
    traitlets-5.2.2.post0-py3-none-any.whl

Expected behavior
PyPI does not identify traitlets==5.2.2.post0 as a released version with a wheel.
To Reproduce
Please refer to the details in the Describe the bug section.
My Platform

Poetry version: 1.2.2
Python version: 3.6 - 3.10

Issue is occuring on commitizen GitHub Actions CI workflow pythonpackage.yml

OS version and name: ubuntu-latest, macos-latest, windows-latest

To date, the correspond to:

Windows Server 2022
Ubuntu 20.04
macOS Big Sur 11

Additional context
See also traitlets Issue #729.

Possibly related to caching ala https://github.com/pypi/warehouse/issues/12214

It appears to be a poetry issue, since I was able to downgrade to poetry 1.2.1 and successfully resolve all the commitizen dependencies. The issue is not in warehouse, as far as I can tell.

I'm not convinced it's Poetry's fault -- Poetry 1.2.1 and Poetry 1.2.2 only differ in the PyPI API they consult. Poetry 1.2.1 would use the JSON API to gather filenames; Poetry 1.2.2 uses the PEP 691 implementation to gather filenames.
As determining what versions are available in the Simple API (whether HTML or JSON, PEP 503 or PEP 691) requires parsing filenames, PyPI is reporting that the spurious version exists, even if it's not reflected by the JSON API. I suspect that Warehouse somehow associated an uploaded .post0 release with 5.2.2 rather than creating a new release as one would expected.
Try curl --header "Accept: application/vnd.pypi.simple.v1+json" https://pypi.org/simple/traitlets/ to query the PEP 691 JSON API (which returns the same data as the PEP 503 Simple HTML API) -- you'll see the file there.

I'm not convinced it's Poetry's fault -- Poetry 1.2.1 and Poetry 1.2.2 only differ in the PyPI API they consult.

Maybe? The downgrade to poetry 1.2.1 shows the set of dependencies resolved working - resulting in traitlets 4.3.3 being successfully installed.
Changing the API used in resolution feels like more than a patch-level change to me, but that's my opinion only. Of course, if everything "just worked" then we wouldn't be having this conversation 😀.

I suspect that Warehouse somehow associated an uploaded .post0 release with 5.2.2 rather than creating a new release as one would expect.

This is an interesting preposition, so let's explore that a bit!
Looking at traitlets history for _version.py we can see that the release date for 5.2.2 was May 31, 2022 - which is when pypi version 5.2.2 and 5.2.2.post1 came into existence. 5.2.2 contains the post0 file as well as the non-post0 file, but there's no GitHub tag for 5.2.2.post0, whereas 5.2.1.post0 is tagged, has a "proper" pypi release, etc.
Sadly, we can no longer examine the GitHub Action execution logs or artifacts for 5.2.2 as they have expired: https://github.com/ipython/traitlets/actions/runs/2417447574
The GitHub tag for https://github.com/ipython/traitlets/releases/tag/5.2.2.post1 reflects a _version.py change from https://github.com/ipython/traitlets/pull/739 - so there's definitely an open question in my mind of where the post0 file came from at all, as the traitlet's repo release strategy appears to be GitHub Tag-driven and hasn't changes since Sept 2021.
It's entirely possible this file was manually created outside of GitHub Actions in an attempt to "fix" the issue and never got a tag associated with it, and no commits exist in history for us to view.

Try curl --header "Accept: application/vnd.pypi.simple.v1+json" https://pypi.org/simple/traitlets/ to query the PEP 691 JSON API (which returns the same data as the PEP 503 Simple HTML API) -- you'll see the file there.

Absolutely, it definitely exists, and is confirmed associated with the 5.2.2 release via the JSON API:
$ curl -s https://pypi.org/pypi/traitlets/5.2.2/json | jq '.urls[] |select(.packagetype=="bdist_wheel") |.filename'
"traitlets-5.2.2.post0-py3-none-any.whl"
"traitlets-5.2.2-py3-none-any.whl"

One of the Warehouse Admins should be able to dig up some of the Journal history to determine how that file arrived. Either via the Admin interface at https://pypi.org/admin/projects/traitlets/journals/ or via a SQL query like:
SELECT version, action, submitted_date, submitted_by FROM journals WHERE name = 'traitlets' AND version LIKE '5.2.2%';

I'd expect to see entries like new release and add py3 file traitlets-5.2.2.post0-py3-none-any.whl that could help answer "how the file came to be" and associated with the 5.2.2 release.

warehouse=> SELECT version, action, submitted_date, submitted_by FROM journals WHERE name = 'traitlets' AND version LIKE '5.2.2%';
   version   |                       action                        |       submitted_date       | submitted_by
-------------+-----------------------------------------------------+----------------------------+--------------
 5.2.2       | add py3 file traitlets-5.2.2.post0-py3-none-any.whl | 2022-05-31 21:25:53.935778 | blink1073
 5.2.2.post1 | new release                                         | 2022-05-31 21:29:45.781932 | blink1073
 5.2.2.post1 | add py3 file traitlets-5.2.2.post1-py3-none-any.whl | 2022-05-31 21:29:45.781932 | blink1073
 5.2.2.post1 | add source file traitlets-5.2.2.post1.tar.gz        | 2022-05-31 21:29:47.281823 | blink1073
 5.2.2       | new release                                         | 2022-05-31 20:07:28.210021 | blink1073
 5.2.2       | add py3 file traitlets-5.2.2-py3-none-any.whl       | 2022-05-31 20:07:28.210021 | blink1073
 5.2.2       | add source file traitlets-5.2.2.tar.gz              | 2022-05-31 20:07:30.200664 | blink1073
(7 rows)

Argh. Without metadata being served per PEP 658 here, it really seems like we can't win. I'm inclined to call this an issue with a bad package being uploaded by the traitlets authors, who likely need to delete the file in question.
Technically we can defend against this in Poetry by checking the JSON API for files we discover using the PEP 691 API (we still rely on the JSON API for metadata, after all), but that strikes me as the wrong way to try and solve this. I think declaring it a user error that PyPI currently does not protect against is more likely the way to go.
WDYT @dimbleby?

yeah, seems like we've got to the bottom of this one

user error uploading bad file
pypi doesn't spot this, leaving pypi in a confused state
poetry is not defensive against this

I don't immediately see a very straightforward way in the current code to have poetry tolerate this so from a poetry point of view I'd probably call this not-worth-the-trouble / MR-welcome-if-anyone-can-do-better.
warehouse maintainers will decide whether #12316 adequately covers this case or whether it's useful to track it explicitly.

poetry and PyPI teams, thank you for looking into this!
traitlets team, I'm referencing traitlets Issue #729 for your visibility. I don't know who should be pinged from the traitlets team...?

@neersighted @dimbleby Is there a way the bad file can be corrected while we're working/deciding on defensive strategies so CI workflows can run?

I don't know who should be pinged from the traitlets team...?

Actually, from the report it looks like @blink1073 should be pinged on the traitlets end.

I just yanked traitlets 5.2.2.

@blink1073 Thank you!

I think this issue can now be closed, and we should consider how to resolve prevention via #12316

I think this issue can now be closed, and we should consider how to resolve prevention via https://github.com/pypi/warehouse/issues/12316

I agree.


Document prerequisites

Please add info on how to configure it to make it working and add dependencies to packer usage example:
-- init.lua

 vim.opt.foldcolumn="auto"
 vim.opt.numberwidth=8

require("packer").startup(function(use)
  ...

  use {
      "luukvbaal/statuscol.nvim",
      requires = {
            "lewis6991/gitsigns.nvim"
            , "mfussenegger/nvim-dap"
      }
  }

...

Neither of those are required to make the core of this plugin work. They are already linked to in the table of supported signs so I don't think there's anything left to do here besides improving the overall structure of the readme.

@luukvbaal Well for me it didn't work until I set foldcolumn settings  and hit zM or any other fold command.

Indeed certain features of this plugin are locked behind other neovim options. You can't expect them to "work" if you have them disabled or are not active yet in your current buffer.
Those options are already well documented in neovim itself. Again, I'm not sure if it needs to be documented here as well, but I might add something as I improve the readme.
vim.opt.numberwidth=8 also shouldn't be necessary. The statuscolumn should contract/expand as the sign/foldcolumn contract/expand.

@luukvbaal If it doesn't work out of the box and you should set up certain props I think it's best to document it. Otherwise it's unclear. Thanks for the all hard work anyway! Great job.

Thanks! (The point is that you don't have to set up those props to make use of the plugin).


web: fix minimum Python version

The minimum version was upgraded to 3.7 in PR #126 .
This is the last reference to 3.6 in the code base.

Thanks James!


Cake Addin Directive and MyGet

Cake Addin directive does not appear to work with packages retrieved from MyGet.  I am going to look into it more, but I wanted to post this here.

So it appears you can just do this with an addin for alternative package sources.
#addin Cake.Chutzpah https://www.myget.org/F/extra-build-packages/api/v2


Cannot assign to read only property 'RGBA16F' of object

I have the exact same error as https://github.com/BabylonJS/Babylon.js/issues/2642 but the issue is closed and I don't know why and how it has been resolved by OP
Context:

Developing on localhost
With MacOSX and ArchLinux
With Chrome and Firefox
Using babylonjs as a CommonJS module with rollup (and babel)
With babylon.3.0-beta12.max.js and babylon.3.0-beta12.js  (with and without npm)

Error:

babylon.3.0-beta12.max.js:7623 Uncaught TypeError:
Cannot assign to read only property 'RGBA16F' of object '#<WebGL2RenderingContext>'
   at new Engine (babylon.3.0-beta12.max.js:7623)

It looks like the following WebGL constants RGBA16F, RGBA32F and RGBA32F are read only and cannot be set during engine creation.
See: https://github.com/BabylonJS/Babylon.js/blob/7482c84713f0b97d32e3e1a1ac42b70893b77468/src/Engine/babylon.engine.ts#L1080-L1082
Strangely HALF_FLOAT_OES can be set without any problem...

can you try with latest release?

@deltakosh I just tried with https://github.com/BabylonJS/Babylon.js/blob/7482c84713f0b97d32e3e1a1ac42b70893b77468/dist/babylon.max.js and I have the exact same problem

Do you have any clues? It looks like we have no problem when using babylonjs as an external library.. we are now switching to rollup + babel with modules.. that's really strange because _gl is not a module.. Maybe some polyfills are messing around?

Can you try updating the source and set:
(this._gl).RGBA16F = 0x881A

@deltakosh same problem

Simple question.. why are you setting those constants? Aren't constant supposed to be readonly? And by the way I checked and the exact same values are already set on my browser

@deltakosh hum ok
or another option is
if (this._gl.RGBA16F !== 0x881A) {
   this._gl.RGBA16F !== 0x881A;
}

That doesn't explain why the code is working when accessing to babylon.3.0-beta12.max.js with <script src="" /> instead of rollup module.. 🤔

Certainly because babel (I guess it is the one which check that) can't see it?

Babel is not touching babylon.3.0-beta12.max.js at all.. either in commonjs module or script. I've explicitly excluded it from my babel plugin, that a good practice to exclude all node_modules and vendors folders.
My babel config is very simple I'm only using babel-preset-env that is in charge of picking that appropriate polyfills. I've no weird transformations.

Hum so no idea ;)
I will push an update soon to fix it

I also now that Cannot assign to read only property.. is a common error with people using modules for the first time but this._gl is not a module and is directly created via either:

canvas.getContext("webgl2", options)
canvas.getContext("experimental-webgl2", options)
canvas.getContext("webgl", options)
canvas.getContext("experimental-webgl", options)

I don't think babel or rollup can mess around with that.
The only thing I can see are the polyfills.. because with rollup they are in the same scope as babylonjs and babylonjs is impacted with them..
The babel polyfills comes from core-js and maybe one of those are activating some read only stuff (getter? define.property?)
That's only suppositions 😄
Can't wait for the fix, thanks!

@deltakosh I still have the issue with the latest release
I've seen that you've reverted the if (...) thing here in this commit 🤔  Why did you revert this? Is it related to strict check null?
I figured out exactly why this is happening using a bundler like rollup or webpack, the thing is that the bundler is enabling strict mode by default by adding 'use strict'; which is good for ES6
In rollup documentation https://rollupjs.org/#strict

Strictly-speaking, ES6 modules are always in strict mode, so you shouldn't disable this without good reason.

So I still have the problem with those 3 lines:
this._gl.RGBA16F = 0x881A; // RGBA 16-bit floating-point color-renderable internal sized forma
this._gl.RGBA32F = 0x8814; // RGBA 32-bit floating-point color-renderable internal sized forma
this._gl.DEPTH24_STENCIL8 = 35056;

But also in new Mesh(...) at this line, the Tools.DeepCopyfunction is throwing at this line:
Uncaught TypeError: Cannot set property source of [object Object] which has only a getter
    at Function.Tools.DeepCopy (babylon.3.0.7.max.js:5704)
    at new Mesh (babylon.3.0.7.max.js:19816)
    at Mesh.clone (babylon.3.0.7.max.js:21060)

Seems like Mesh.source is a getter (from this._source) and then cannot be set ⚠
My workaround is to disable strict mode in my bundler, but I think there is several benefits to use strict mode directly in BabylonJS in development mode. In production mode we should be able to use it or not because there are many resources about performance improvements, see this and this and this.
@deltakosh do you want me to create 2 separate issues? Or to create another issue called Enable strict mode? Do you also think enabling strict mode is a good thing?

Sorry for the bug with constants. I'll revert back to what it was. I was looking for a bug and forgot to bring the code back
I'll also fix the this._source bug for sure
Regarding enabling strict mode, it has a lot of implications in the codebase and after introducing the strict null check I need more time before allowing another big rework

@deltakosh I think you forgot DEPTH24_STENCIL8 (I made a copy/paste mistake in my issue)
There is another problem, in the case where the constants doesn't equal what we are expecting (the browser only supports WEBGL 1) then we will still get the error in strict mode.
May I suggest something more explicit like

// Inspired by https://stackoverflow.com/a/10480227/1480391
const isStrict = (function() { return !this; })();

// See https://github.com/BabylonJS/Babylon.js/issues/2988
const trySetReadOnlyProperty = (prop, value) => {
  if (this._gl[prop] === value) {
    return;
  }
  if (isStrict) {
    // I don't know how you actually log warnings
    console.warning(`Cannot force property "${prop}" of WebGL context with strict mode enabled`);
    return;
  }
  this._gl[prop] = value;
}

// RGBA 16-bit floating-point color-renderable internal sized format.
trySetReadOnlyProperty("RGBA16F", 0x881A);

// RGBA 32-bit floating-point color-renderable internal sized format.
trySetReadOnlyProperty("RGBA32F", 0x8814);

trySetReadOnlyProperty("DEPTH24_STENCIL8", 35056);

If you want me to fill a PR, I'll do it

I'm in a middle of an update so I'll add it no worry :) (directly though)


Release time of the trained model

Thank you for providing your code.
The README says the trained models will be released by March, it's not ready yet. Could you share your trained model weights?
PS1. BTW, in prepare_data.py, line 228 should not have os.path.join(args.root_dir, ...) as args.root_dir has already been joined to filepath in line 221.
PS2. So I am currently following your training script to reproduce protocol2. I've finished preparing data and I want to just test the model with HMD (no additional IMU added). Then, is it correct to change following things in options/train_config.yaml?

compatible_inputs: ['HMD']
dataset_path: <path-to-protocol2-data>

Thank you for providing your code.
The README says the trained models will be released by March, it's not ready yet. Could you share your trained model weights?
PS1. BTW, in prepare_data.py, line 228 should not have os.path.join(args.root_dir, ...) as args.root_dir has already been joined to filepath in line 221.
PS2. So I am currently following your training script to reproduce protocol2. I've finished preparing data and I want to just test the model with HMD (no additional IMU added). Then, is it correct to change following things in options/train_config.yaml?

compatible_inputs: ['HMD']
dataset_path: <path-to-protocol2-data>

For PS1: Thanks for pointing out this bug, and I will fix this issue ASAP.
For PS2: Yes, you are correct.


fix in Ascii.terminal_artify() for PNGs with a transparent layer

getpixel() returns an int, intead of a tuple of ints, when the from_pic
is a PNG with a transparency layer. This fix creates a tuple in that case,
so terminal_artify() can handle PNGs with a transparent layer.

Good catch with the getpixel() return problem! However it should be known that PNG images do not have layers. I get what you mean though. Would you mind sending me an image that breaks the code without this fix? I tried a PNG with transparency from Google image search and it worked.

Failing pic is here http://d1vmz9r13e2j4x.cloudfront.net/NET/images/net_logo_black.png

Thanks for that. I'll definitely hold onto this image for testing purposes.


WebApp:Serialization issue with az webapp config access-restriction add

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp config access-restriction add
Errors:
'ServiceTag' is not valid value for enum <enum 'IpFilterTag'>
Traceback (most recent call last):
Temp\pip-unpacked-wheel-qa9gi9_9\msrest\serialization.py, ln 987, in serialize_enum
enum.py, ln 293, in __call__
enum.py, ln 535, in __new__
enum.py, ln 548, in _missing_
ValueError: 'ServiceTag' is not a valid IpFilterTag

...

Temp\pip-unpacked-wheel-qa9gi9_9\msrest\serialization.py, ln 771, in serialize_data
Temp\pip-unpacked-wheel-qa9gi9_9\msrest\serialization.py, ln 994, in serialize_enum
msrest.exceptions.SerializationError: 'ServiceTag' is not valid value for enum <enum 'IpFilterTag'>

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp config access-restriction add --resource-group {} --name {} --action {} --rule-name {} --ip-address {} --priority {}

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.8
Installer: MSI

azure-cli 2.17.1

Extensions:
aks-preview 0.4.72
front-door 1.0.9
storage-preview 0.7.0
webapp 0.3.1

Additional Context

webapp

webapp

@designerfh - Unable to repro this issue in Version azure-cli 2.17.1 and latest version azure-cli 2.18.0. Please reopen this issue with debug details if you still repro it.

@designerfh - Unable to repro this issue in Version azure-cli 2.17.1 and latest version azure-cli 2.18.0. Please reopen this issue with debug details if you still repro it.

We having this same issue. If the webapp already has an access-restriction rule that is of the type ServiceTag, this command fails to add any more.
ERROR: CLIInternalError: The command failed with an unexpected error. Here is the traceback:
ERROR: 'ServiceTag' is not valid value for enum <enum 'IpFilterTag'>


update request block

[ ] check current content and update it

I have removed this block in #40 since there is currently no specification and implementation.


Merge branch 'master' of github.com:envoyproxy/envoy

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@PiotrSikora : Thanks!!


Move snorkel.labeling.preprocessor to snorkel.preprocessor

NOTE: needs associated changes in snorkel-tutorials (WIP)
Test plan

Ran tox

While we are doing this, should we also rename pre to preprocessor here? https://github.com/HazyResearch/snorkel/blob/redux/snorkel/map/core.py#L93
@henryre @bhancock8 @vincentschen

@brahmaneya I'd vote to move all of this to snorkel.map then change the preprocessor arg of LF to pre so there's less indirection. there's one subtle difference which is that general mappers can return None (e.g. TFs) but preprocessors cannot. any opinions on how to handle that? cc @vincentschen

@brahmaneya I'd vote to move all of this to snorkel.map then change the preprocessor arg of LF to pre so there's less indirection. there's one subtle difference which is that general mappers can return None (e.g. TFs) but preprocessors cannot. any opinions on how to handle that? cc @vincentschen

+1 to moving to map and renaming to pre. W.r.t. returning None, currently the code checks for None and throws ValueError for None outputs (https://github.com/HazyResearch/snorkel/blob/redux/snorkel/labeling/lf/core.py#L64) . We could keep it that way, or just re-use the original x when pre(x) is None.

@brahmaneya I'd vote to move all of this to snorkel.map then change the preprocessor arg of LF to pre so there's less indirection. there's one subtle difference which is that general mappers can return None (e.g. TFs) but preprocessors cannot. any opinions on how to handle that? cc @vincentschen

+1 to moving to map and renaming to pre. W.r.t. returning None, currently the code checks for None and throws ValueError for None outputs (https://github.com/HazyResearch/snorkel/blob/redux/snorkel/labeling/lf/core.py#L64) . We could keep it that way, or just re-use the original x when pre(x) is None.

I personally like the naming of preprocess.. very obvious to folks what utilities we provide help with. Map seems much vaguer...

@brahmaneya I'm also okay with calling it pre in the Mapper, because the notion of a preprocessor is technically distinct. It makes sense to me that Mapper.pre refers to anything that happens before the mapper itself, whereas a Preprocessor inherits from Mapepr


Possible lifetime problem with subcaptures iterators

I think this code should work:
#[test]
fn test_iter_lifetimes() {
    fn get_first_subcapture<'t>(regex: &Regex, text: &'t str) -> Option<&'t str> {
        let captures = regex.captures(text).unwrap();
        captures.iter().next().unwrap()
    }

    let regex = Regex::new("(a+)(b+)").unwrap();
    let subcapture = get_first_subcapture(&regex, "aabbab");

    assert_eq!(subcapture, Some("aabb"));
}

But today it does not compile:
src/re.rs:956:9: 956:17 error: `captures` does not live long enough
src/re.rs:956         captures.iter().next().unwrap()
                      ^~~~~~~~
src/re.rs:954:82: 957:6 note: reference must be valid for the lifetime 't as defined on the block at 954:81...
src/re.rs:954     fn get_first_subcapture<'t>(regex: &Regex, text: &'t str) -> Option<&'t str> {
src/re.rs:955         let captures = regex.captures(text).unwrap();
src/re.rs:956         captures.iter().next().unwrap()
src/re.rs:957     }
src/re.rs:955:54: 957:6 note: ...but borrowed value is only valid for the block suffix following statement 0 at 955:53
src/re.rs:955         let captures = regex.captures(text).unwrap();
src/re.rs:956         captures.iter().next().unwrap()
src/re.rs:957     }

The problem is that subcaptures can not outlive Captures struct, which is wrong. To fix this, we need to add new lifetime:
pub fn iter<'c>(&'c self) -> SubCaptures<'c, 't>

And:
pub struct SubCaptures<'c, 't: 'c> {
    idx: usize,
    caps: &'c Captures<'t>,
}

There is a similar problem with iter_named and SubCapturesNamed. Possibly related to #158

Man, what a bonehead move on my part. The current definition is trivially wrong:
pub struct SubCaptures<'t> {
    idx: usize,
    caps: &'t Captures<'t>,
}

How presumptuous of me to assume that the search text might not live as long as the capture value! In this case, I believe 't is inferred to be the shorter of the two lifetimes, which certainly can't be reconciled with the lifetime in your function declaration.
Nice find!

This should also be bundled up into 1.0, since it will also be a breaking change. (But thankfully shouldn't actually result in a huge amount of breakage, since I doubt folks are actually uttering the SubCaptures type.)

About iter_pos and SubCapturesPos. I think it should be changed to this:
pub fn iter_pos<'c>(&'c self) -> SubCapturesPos<'c> { ... }

/// `'c` is the lifetime of `Captures` struct.
pub struct SubCapturesPos<'с> {
    idx: usize,
    locs: &'с [Option<usize>], // from Captures::locs
}

Also, I think we can correct documentation before 1.0: 't is not the lifetime of the matched text for SubCaptures, SubCapturesNamed and SubCapturesPos. It is lifetime of Captures borrow.

Also, I think we can correct documentation before 1.0:

That'd be fine.

Note that this is fixed in the bytes::Regex API.


fix No such file or directory error

If you use ls *.js to loop through JS file, it will fail when the name of the file has space. For example, in my case, I got the js file generated "List - Generatel.2a825668.chunk.js" and the loop returned 3 items

List
-
Generatel.2a825668.chunk.js
In fact, we do not need to use ls to loop through js files, please check my pull request.


Expose cucumber-gherkin and cucumber-messages api to make cucumber-ruby not dependent on those anymore

cucumber-ruby-core depends on cucumber-gherkin and cucumber-messages. Cucumber-ruby too.
They versions of those dependencies have to be kept in sync.
That is responsible for major or minor version bump without any api change.
For example, if cucumber-ruby-core depends on gherkin 22 but cucumber-ruby still depends on gherkin 20, releasing a new patched version of cucumber-ruby-core will prevent cucumber-ruby to be installed using bundler. Even without any api change.
If cucumber-ruby was using API exposed from cucumber-ruby-core only, new version numbers would be more coherent with semver that stated that only API changes should be responsible for minor or major version bump.
@aslakhellesoy @mattwynne what do you think?

I'd like to understand specifically how cucumber-ruby uses those libraries. In theory they are deeper in the dependency graph and so should be more stable than cucumber-ruby-core, so it should not be a problem to depend on them everywhere.

The ruby implementation itself should be more stable. But when we release a component, we release all its implementation. That way we have more minor and major version bump than we could have expect if focusing only for ruby.
For example: https://github.com/cucumber/common/blob/main/messages/CHANGELOG.md
The last time we had ruby impacted with messages was with 17.0.1. If we would have a new patch fix for ruby, we would actually bring something > 17.1, because the actual version is 17.1.1:  a minor version bump, without any impact in the ruby implementation.

If we are, for example, exposing the message objects via cucumber-ruby's formatter / plugin API, and we introduce a breaking change in the messages protocol, then we can't avoid making a major release of cucumber-ruby too.

Yes, API change would still be responsible for new minor or major release.
The issue here is for non breaking changes that are also responsible for new minor or major releases because of dependency issues rather than API changes.
But actually, the issue may be more related to libraries with new minor and major version for an implementation without actual breaking changes than cucumber-ruby and cucumber-core both depending on those libraries.

Exposing messages and gherkin APIs through core would also help automatic updates of dependencies.
At the moment, if there is an update of messages, a bot cannot automatically update ruby because we would need first to update core, then release it


syslogng: Late cleanup

Description of changes
Late review of #257696 made me dig deeper into how the build process uses pip.
This addresses the two points raised and also bumps the version in the module so it doesn't emit a warning.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 I've experienced build issues on aarch64-linux without this patch as pip is trying to be a smartass even when it has no network connectivity, please merge this.


Inference on PYNQ Z2

Hello, I really like you work and it is pretty good structured, explained in detail which makes it easily available to use. I saw that you were using Petalinux and DNNDK. Do they work good in terms of inference time on pynq? I mean, what inference times did you get when running in C++?
Didn't see it in gitbook tutorial, or maybe I missed something.
Thank you, and keep a good work

In fact those results are pretty good for pynq z2 board. I was doing something similar but with FINN-Brevitas framework to optimise, compile model in Python. But it was a slower for Yolo v3 tiny model with inference time of 0.072 seconds. Also, I would try to follow your steps, and get to know more about Petalinux, and especially interesting area around DPU (creation) in Vivado.
Thank you 😃

Thank you very much!
I hope it all goes well for you, and if there's any problem let me know as I am still, in fact, making the finishing touches on the project documentation.
Good work!


[SUPPORT]NoSuchMethodError: org.apache.curator.CuratorZookeeperClient.startAdvancedTrace

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:
hudi config:
hoodie.bucket.index.num.buckets -> 20
hoodie.datasource.hive_sync.database -> dwd_hudi
hoodie.parquet.small.file.limit -> 104857600
hoodie.simple.index.update.partition.path -> false
hoodie.datasource.hive_sync.mode -> JDBC
hoodie.copyonwrite.record.size.estimate -> 100
hoodie.datasource.write.precombine.field -> time_stamp
hoodie.datasource.hive_sync.partition_fields -> cdate
hoodie.datasource.hive_sync.partition_extractor_class -> org.apache.hudi.hive.MultiPartKeysValueExtractor
hoodie.cleaner.fileversions.retained -> 1
hoodie.parquet.max.file.size -> 125829120
hoodie.write.lock.hivemetastore.database -> dwd_hudi
hoodie.write.lock.client.wait_time_ms_between_retry -> 2000
hoodie.write.lock.client.num_retries -> 100
hoodie.write.lock.zookeeper.url -> zknodes
hoodie.write.lock.zookeeper.base_path -> /hudi_multiwriter
hoodie.index.bucket.engine -> SIMPLE
hoodie.bucket.index.hash.field -> group_id
hoodie.datasource.hive_sync.table -> ods_dts_trade_sale_main_di
hoodie.index.type -> BUCKET
hoodie.clean.automatic -> true
hoodie.datasource.write.operation -> upsert
hoodie.write.lock.wait_time_ms -> 120000
hoodie.datasource.hive_sync.enable -> true
hoodie.datasource.write.recordkey.field -> group_id,company_id,business_id,saleno
hoodie.table.name -> ods_dts_trade_sale_main_di
hoodie.datasource.hive_sync.jdbcurl -> jdbc:hive2://header:10000
hoodie.datasource.write.hive_style_partitioning -> true
hoodie.cleaner.policy -> KEEP_LATEST_FILE_VERSIONS
hoodie.combine.before.upsert -> false
hoodie.write.lock.num_retries -> 100
hoodie.storage.layout.partitioner.class -> org.apache.hudi.table.action.commit.SparkBucketIndexPartitioner
hoodie.fail.on.timeline.archiving -> false
hoodie.cleaner.policy.failed.writes -> LAZY
hoodie.keep.max.commits -> 10
hoodie.upsert.shuffle.parallelism -> 50
hoodie.write.lock.hivemetastore.table -> ods_dts_trade_sale_main_di
hoodie.write.lock.zookeeper.port -> 2181
hoodie.cleaner.commits.retained -> 1
hoodie.write.lock.provider -> org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider
hoodie.keep.min.commits -> 2
hoodie.datasource.write.partitionpath.field -> cdate
hoodie.clean.async -> true
hoodie.write.lock.wait_time_ms_between_retry -> 2000
hoodie.write.concurrency.mode -> optimistic_concurrency_control
Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version :0.13.0

Spark version :3.1

Hive version :3.1

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
23/06/14 15:58:42 INFO ConnectionStateManager: State change: CONNECTED
23/06/14 15:58:42 ERROR ApplicationMaster: User class threw exception: java.lang.NoSuchMethodError: org.apache.curator.CuratorZookeeperClient.startAdvancedTracer(Ljava/lang/String;)Lorg/apache/curator/drivers/OperationTrace;
java.lang.NoSuchMethodError: org.apache.curator.CuratorZookeeperClient.startAdvancedTracer(Ljava/lang/String;)Lorg/apache/curator/drivers/OperationTrace;
at org.apache.curator.framework.imps.CreateBuilderImpl.pathInForeground(CreateBuilderImpl.java:716)
at org.apache.curator.framework.imps.CreateBuilderImpl.protectedPathInForeground(CreateBuilderImpl.java:484)
at org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:474)
at org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:454)
at org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:44)
at org.apache.curator.framework.recipes.locks.StandardLockInternalsDriver.createsTheLock(StandardLockInternalsDriver.java:54)
at org.apache.curator.framework.recipes.locks.LockInternals.attemptLock(LockInternals.java:216)
at org.apache.curator.framework.recipes.locks.InterProcessMutex.internalLock(InterProcessMutex.java:232)
at org.apache.curator.framework.recipes.locks.InterProcessMutex.acquire(InterProcessMutex.java:108)
at org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider.acquireLock(ZookeeperBasedLockProvider.java:144)
at org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider.tryLock(ZookeeperBasedLockProvider.java:96)
at org.apache.hudi.client.transaction.lock.LockManager.lock(LockManager.java:78)
at org.apache.hudi.client.transaction.TransactionManager.beginTransaction(TransactionManager.java:59)
at org.apache.hudi.client.BaseHoodieWriteClient.doInitTable(BaseHoodieWriteClient.java:1129)
at org.apache.hudi.client.BaseHoodieWriteClient.initTable(BaseHoodieWriteClient.java:1169)
at org.apache.hudi.client.BaseHoodieWriteClient.initTable(BaseHoodieWriteClient.java:1198)
at org.apache.hudi.client.SparkRDDWriteClient.upsert(SparkRDDWriteClient.java:137)
at org.apache.hudi.DataSourceUtils.doWriteOperation(DataSourceUtils.java:206)
at org.apache.hudi.HoodieSparkSqlWriter$.write(HoodieSparkSqlWriter.scala:363)
at org.apache.hudi.DefaultSource.createRelation(DefaultSource.scala:150)
at org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:46)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:90)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$execute$1(SparkPlan.scala:180)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$executeQuery$1(SparkPlan.scala:218)
at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:215)
at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:176)
at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:132)
at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:131)
at org.apache.spark.sql.DataFrameWriter.$anonfun$runCommand$1(DataFrameWriter.scala:989)
at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$5(SQLExecution.scala:103)
at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:163)
at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:90)
at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:772)
at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:64)
at org.apache.spark.sql.DataFrameWriter.runCommand(DataFrameWriter.scala:989)
at org.apache.spark.sql.DataFrameWriter.saveToV1Source(DataFrameWriter.scala:438)
at org.apache.spark.sql.DataFrameWriter.saveInternal(DataFrameWriter.scala:415)
at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:293)
After decompiling the hudi-spark3.1-bundle_2.12-0.13.0.jar package, it was found that the CuratorZookeeperClient class does not have the startAdvancedTracer method
Stacktrace
Add the stacktrace of the error.

@nbeeee I tried to reproduce this issue but zookeeper concurrency is working fine with Spark 3.1 and Hudi 0.13.0.
I checked the stack trace and it looks like while writing data only you are getting this exception. Any special information about your setup you can provide to help me triage this issue.

@nbeeee Also it this a deltastreamer job or spark datasource writer, Can you also paste the code snippet so I can take a look into.

I added the zookeeper dependency to the hudi-spark-bundle/pom.xml file and repackaged it, which is now working properly

@nbeeee Also it this a deltastreamer job or spark datasource writer, Can you also paste the code snippet so I can take a look into.


Feature request: picture rendering

Hi, first of all, thanks. I've implemented this idea I had around since some time ago very quickly using this. library :smile:
It would be nice some kind of (optional) pictures support. BTW, some packages that could help:

Only available for iTerm3: https://github.com/sindresorhus/term-img-cli
lib: https://github.com/sindresorhus/term-img
Fallback to this one: https://github.com/cronvel/tview
A curious one: https://github.com/IonicaBizau/image-to-ascii

Hi. Sure, if you're able to make something work I'll happily merge it 🎉


CJK characters modified by translation (even in input tab)

Hello !
As per title, when trying to use a model (here, opus+bt-2021-04-30, multilingual) to translate a sentence (e.g. : "【测试】哎呀？我的台本哪里去了？我现在应该说啥？") to English, I noticed some characters (【 and 】) are modified even in the input tab.
【测试】哎呀？我的台本哪里去了？我现在应该说啥？
... becomes :
[测试]哎呀?我的台本哪里去了?我现在应该说啥?
So I suppose there's no way the translation is going to be exact. And indeed, it outputs :
[Test] Oh? Where is my script? What should I say now?
Is it possible to fix this so, for example, 【 and 】 are not transformed before generation ?
Thanks !

Hi,
It seems the lenticular brackets are converted to standard brackets by the OPUS MT model preprocessing, so the model just treats them as standard square brackets. This is probably an error, since at least according to Wikipedia, the lenticular brackets denote headings etc., i.e. they are not equivalent to standard brackets.
This can be fixed only by retraining the models, so I'll make a note of this and hopefully we can modify the preprocessing script for the next training run.
-Tommi

Thank you :)


[BUG] Version with a large number

When a version uses a long number, a build error occurs.

When a version uses a short number, build has no error.

65535 work. 65536 don't work

Hello
This is msix-tool behavior: https://github.com/microsoft/WindowsAppSDK/issues/148


[JENKINS-63307] Allow zOS encoding of user name, password, and passphrase

JENKINS-63307 Allow zOS encoding of user name, password, and passphrase
Changes the character set definition properties.  Properties are now:

org.jenkinsci.plugins.gitclient.CliGitAPIImpl.user.name.file.encoding
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.user.passphrase.file.encoding
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.user.password.file.encoding

Keeps the documentation simpler and the code simpler.
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have referenced the Jira issue related to my changes in one or more commit messages
[x] Unit tests pass locally with my changes
[x] I have added documentation as necessary
[x] No Javadoc warnings were introduced with my changes
[x] No spotbugs warnings were introduced with my changes

Types of changes

[x] New feature (non-breaking change which adds functionality)

Hi Mark,
I don't see a scenario, that different encodings needs to be set when running the agent on z/OS.  We could further simplify and just use a single property like org.jenkinsci.plugins.gitclient.CliGitAPIImpl.user.zos.credential.file.encoding which is used in all the three scenarios.
Randall, what are your thoughts on this?

Hi Mark,
I don't see a scenario, that different encodings needs to be set when running the agent on z/OS. We could further simplify and just use a single property like org.jenkinsci.plugins.gitclient.CliGitAPIImpl.user.zos.credential.file.encoding which is used in all the three scenarios.
Randall, what are your thoughts on this?

The reason there are separate encodings come down to how the IBM Dependency Based Build mechanism has been used with Jenkins. There are a set of scripts (of various revisions) that selectively change the encoding of each of the three elements (SSH passphrase, SSL user, SSL password). Personally, I would rather see the scripts go away completely, but until they are gone, z/OS Git Client users have a mixed back of encoding strategies for each element. Ideally this should be controlled by one property, but I do not like the breakage possibilities. I'm fairly new to Jenkins on z/OS so cannot speak to how all customers have done this, but I have gone through the script versions and am concerned that we do need the granularity to control each one separately. I would rather err on the side of prudent.


handle error case better when facts return no results back

Aborting when fact collection fails is surely a good idea.
But whats up with removing the colons? If i am not mistaken, the only difference the colon would make would be to handle i.e. empty strings the same as undefined variable. Isn't that the right thing to do, at least for flakeAttrs & so?

shfmt did this when adding set -eux -o pipefail, so I assume it's fine.

Oh okay, thought that was a deliberate choice. But shouldn't matter too much in this case, because one would hopefully not set them to a null value

bors merge

bors merge

bors merge

bors merge

bors merge


Fix typo in ItemStackData

Renames setIsUnbrekable to setIsUnbreakable in ItemStackData

https://github.com/SpongePowered/Sponge/issues/23
Please move this to the OCD list, we don't pull typo fixing commits as it generates useless builds. That said, thank you for pointing this out, we appreciate the notice.


install [socket.dev] github app

socket.dev  is a SaaS to check if dependencies are secure.
I think this is a good way to keep dependencies safe.
FYI: This package is totally safe!!
https://socket.dev/npm/package/typia

Done


Tutorial: Using Light Curve File Products with Lightkurve

This notebook will form part of the series: Getting started with Kepler and K2 data products.
In this first notebook, we will focus on downloading and plotting a light curve for objects a user is interested in. I think this should be a completely ''blind'' notebook, in the sense that it can be an entry point for somebody who hasn't used Lightkurve or Python before.
I've had a look through the STScI notebooks on downloading & plotting Kepler light curves. These are very Astropy & MAST centric, and so I'm not concerned about replicating anything here--- ideally this notebook should showcase Lightkurve's ease of access to plotting the data.
We can draw inspiration from existing Lightkurve tutorials:

What are LightCurveFile objects?
What are LightCurve objects?
What are TargetPixelFile objects

Learning Goals:

How to access light curve data
What does the metadata mean?
What units does a light curve have?
How can I plot light cuve(s)
How can I combine multiple light curves?

To think about:

Do we cover any light curve manipulation at this stage? Custom light curve correction is dealt with later on, but do we want to handle some default corrections here with the flatten()' or bin()' functionality?
How much do we dive into explaining API features of Lightkurve? E.g. the existing Lightkurve documentation focuses on 'What are x object?'. Should we include these kinds of explanations in this tutorial, or stay focused on explaining how the API is used instead.

Should we include the interactive functionality here (http://docs.lightkurve.org/tutorials/04-interact-with-lightcurves-and-tpf.html)?

I've started getting to work on this notebook over on Google Colab. It's a bit wordy at the moment because I tend to write first and edit later. Having a bit of a writers block, so criticism very welcome :)

This one is ready for review I think. It's on the shared Google Drive under Using-Light-Curve-File-Products-with-Lightkurve.ipynb

This is looking really good @ojhall94.  I really like your writing style! :+1:
Here are some suggestions for your consideration:

In addition to the data access via MAST, it's worth highlighting that one can also open a light curve file from disk using lk.open(filename).
Most metadata is contained in the FITS headers, which can be accessed via the lcf.header() method.  I'd explain that only a small subset of the metadata is passed on to the LightCurve object properties.
I'd use lcfile instead of lc as the variable name for LightCurveFile objects.
The Kinemuchi paper is a great link.  I would also add a brief link to the official handbooks (instrument manual, archive manual, and data processing handbook) which are available via http://archive.stsci.edu/kepler .  In particular, if you end up including the header() method, we should e.g. link to the page in the handbook that lists the meaning of all the header keywords.
It would be worth including a deep link to the page over on docs.lightkurve.org that lists all the methods and properties of the KeplerLightCurve and KeplerLightCurveFile classes.
You could mention in passing that everything you say also applies to TESS, e.g. a TessLightCurveFile class exists.
You mention How can I combine multiple light curves? in your learning goals above.  I'd probably leave this for a separate notebook!

Again, awesome job!! This is exciting!

Hi Geert,
Thanks for the comments! I've tried to implement them all into the current version of the Colab notebook.
There seemed to be a section mission from the version you reviewed--- not sure why. Its included now.

The Kinemuchi paper is a great link.  I would also add a brief link to the official handbooks (instrument manual, archive manual, and data processing handbook) which are available via http://archive.stsci.edu/kepler .  In particular, if you end up including the header() method, we should e.g. link to the page in the handbook that lists the meaning of all the header keywords.

I can't seem to find any part of the documentation that provides more detail on these metadata than the description column in the Header does already, but I might be missing something.

You mention How can I combine multiple light curves? in your learning goals above.  I'd probably leave this for a separate notebook!

I've removed this section for now for a separate notebook, in that case :)

The version you reviewed was incomplete--- that's on me, since I built it locally first and then failed to upload properly. I've fixed that now.

Ahh, that's why the end was so abrupt =)
Your notebook looks great!
I took the liberty to go ahead and edit the notebook a little.  It's easy to reverse changes in Colab, so I figured out this would be an efficient way to proceed. Can you go through the notebook and see if you're OK with the changes I made?
The most noteworthy changes are:

I changed the title from "How to use Light Curve File Products" into "How to use Kepler Light Curve File Products with Lightkurve" to differentiate it from this existing notebook.  Are you OK with that?
I went ahead and tried to re-organize the start using the astropy-style preamble (cf. Slack discussion).
I added "Light curve", "Light curve file", "Photometry", "Channel", "Quarter", etc to the Defining Terms section.
I slightly re-organized the section about accessing metadata.  For example, I tried to put more focus on the fact that the full list of metadata is accessible via the header() method.

Let me know what you think!

Thanks for making those changes Geert! Really like the way it flows now. I'll make sure to try and carry the style through to the next tutorial. Happy with all the changes you made.
At one point you mention the features of the KeplerLightCurve will be featured in a different tutorial. Shall we add this to our Section 1? I'll set up an issue for it later this week so we can discuss its contents.

At one point you mention the features of the KeplerLightCurve will be featured in a different tutorial. Shall we add this to our Section 1?

I worry that having separate tutorials for KeplerLightCurve vs KeplerLightCurveFile is going to confuse people, so perhaps it's best to only have one?
A lot of the functionality of a KeplerLightCurve object can be explained as part of separate task-focused tutorials, e.g. how to combine multiple quarters, how to remove long-term trends, how to write a light curve to disk, etc, can all be separate tutorials.
My recommendation is to add a brief list of the most important methods of KeplerLightCurve to this tutorial, and keep details for task-focused tutorials.  What do you think?

This is looking really great @ojhall94!
To tag onto this discussion about including functionality of KeplerLightCurve objects, one additional component of lightkurve you could include in this is the ability to create a LightCurve object for any timeseries data by setting time, flux, and flux_err attributes. That way if someone is trying to figure out how to use lightkurve with their own observations they'll have a clear example of how to do it.
Should this be its own standalone tutorial? It's also tied into the work @barentsen is doing in #6, since people might want to read their own community-provided K2 light curves that we don't explicitly support.

Should this be its own standalone tutorial?

I think so!  Short and focused tutorials are easier to create, consume, and discover!  I went ahead and added **How to read and write your own light curve files and objects" to the Google Doc!

Hi all,
Thanks for the feedback! I agree that a series of shorter and sweeter tutorials might better for these. I've gone ahead and added:

how to combine multiple quarters,
how to remove long-term trends, and
how to write a light curve to disk

to the google doc.

I've added some Figures at Rebekah's request, but not sure if this bloats it too much. Welcoming feedback!

Touched this up to match the new Lightkurve updates, ready for people to take a look at it again!

Rebekah commented on the tutorial that Sections 3 and onwards might be better suited to separate tutorial. This tutorial would deal with explaining the metadata only, and the first tutorial would just focus on downloading and plotting data. What are your thoughts @barentsen ?

Finally got around to reading through this notebook, and I think it's great!! A really clear introduction to using light curve data in Lightkurve, and pitched at a level that I feel is accessible to both beginners and experts. I particularly love the metadata section; I learnt a lot. On the topic of splitting it, I don't feel like the metadata section would work as well on its own. By combining something fairly abstract with a tangible exploration of the data, it's a lot more meaningful.

I carried out a final review and love this tutorial!
I made a few minor changes:

Section 1: At the end, I added an example showing that the location of the light curve file can be accessed using klc.filename, which is a common question.
Section 2: added a one-line example demonstrating how a figure can be saved using matplotlib, which is a common question.
Section 3: I removed the demo of klc.show_properties() because that method really doesn't show anything useful right now. We'd have to work on improving that method, but it should not hold up this notebook.

I declare this notebook ready for copy-editing.  Thank again @ojhall94! :+1:

Awesome, thanks for the changes @barentsen!

@ojhall94 and @barentsen I finished copy editing this tutorial "How to Use Kepler Light Curve Products with Lightkurve," and it was also in great shape!
Like the others, I made small copy editing changes throughout, and I combined the information from the summary with the Introduction section. I was seeing all of the terms from the defining terms section being defined and described in the text, so I went ahead and removed that section.
I haven't removed the Additional Resources section at the end in case some of the resources need to be incorporated to the text. I also had a question about the number associated with the pixel channels, which I left as a comment in the notebook. Other than those two things, this tutorial is all set on my end and ready to go!

I reviewed the Additional Resources section and confirmed that all the necessary materials are included in the text.

This notebook has successfully been merged into spacetelescope/notebooks.  Thanks everyone!  Closing the issue...


build.sh breaks when python 3 is the default interpreter

The problem is on lines 523-524:
BUILD_RELATIVE_DIRECTORY=$(python -c "import os.path;print \
    os.path.relpath('${CHAKRACORE_DIR}', '$BUILD_DIRECTORY')")

This fails for me because python invokes python3, where print foo is no longer legal syntax.  If I manually change the invocation to python2.7 (valid on my system), things work as expected.  I hit this failure after some system update or other updated the interpreter pointed to by python to version 3.4.
I notice that we only use python here, to get a relative path, and we only use the resulting relative path as an argument to cmake.  Is it strictly necessary to give cmake a relative path?  Could we get away with just passing CHAKRACORE_DIR instead?  It seems to work on my machine, but I don't know enough about CMake to be confident here.
If we can't get away with using the absolute path, would we consider using perl here instead?  We can do the same thing with a one-liner, and perl has (IMO) better distribution on platforms that run bash.  Increasingly, we won't be able to rely on python2 being available.  For so minor a use-case, we may not want to bet on it.
Thanks!

Looks like this is related to creating the binary release package, which I think @sethbrenith owns now? I am going to assume that for that purpose, it should be relative for... some reason related to finding things on the installer's system. With that being said, we could almost certainly do something like
PYTHON_BINARY=$(which python2.7 || which python2 || which python 2> /dev/null)

To find the correct version of python to use.

That works for me personally.

I will make a PR for this in a bit.

Awesome, thank you!


Nodeport replies

<!-- Enter the release note text here if needed or remove this section! -->

/test

@borkmann @brb opinions whether we want the first patch patch merged right away, as (preventive?) fix?
The other two patches I'll probably just pick up with the big PR for https://github.com/cilium/cilium/issues/21955.


When it tries to checkout, it doesn't know how to delete directories

Check https://github.com/PressLabs/gitfs/blob/master/gitfs/repository.py#L92

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24261266-when-it-tries-to-checkout-it-doesn-t-know-how-to-delete-directories?utm_campaign=plugin&utm_content=tracker%2F7081451&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7081451&utm_medium=issues&utm_source=github).

This should be fixed with https://github.com/PressLabs/gitfs/issues/206

@vtemian  isn't this already the case? or libgit2 != libgit2-dev :D

On the sftp server, the dependencies seem to be updated:
apt-cache pkgnames | grep libgit
libgit2-dbg
libgit2-dev
libgit-ruby1.8
libgit-repository-perl
libgit2-0
libgit2
libgit-pure-perl
libgit-wrapper-perl
libgit-ruby

dpkg-query -l | grep libgit
ii  libgit2                          0.22.1-precise~ppa6               low-level Git library
ii  libgit2-dev                      0.22.1-precise~ppa6               low-level Git library (development files)

libgit2 0.23.4
pygit2 0.23.3
Current:
libgit2 22.1

I'm leaving this as apparently building stuff is not my thing :D.


Cant close notification. Add a cancel button plz.

In regards to the new notification in Jockey 2.0, the close button was removed because it has essentially been deprecated by Google. To close Jockey now, just swipe the notification away like you would for notifications from other apps after you've paused music and removed Jockey from your recent apps. I'm planning to change this before the next release so that you don't have to remove Jockey from the list of recent apps first.
To elaborate on this, Android 4.4 and lower has a bug where services can't transition between foreground and background states (being in the foreground requires that your notification is ongoing and can't be dismissed normally). Because of this, music players had to include a close button, because there wouldn't be another way to stop the service (and Jockey 2.0 does include a close button when running on such versions of Android).
This was fixed in Android 5.0, though, so Google Play Music and others now use similar behavior to Jockey where stopping the service is done by swiping away the notification. On top of this, Android 5.0 includes Notification.MediaStyle, which lets apps build a media control notification without having to create the notification layout themselves. This helps with compatibility since Google can change the music notification style (i.e. like they did in Nougat), and apps don't have to do anything to be using the system notification style.
To use this on older versions of Android, there's NotificationCompat.MediaStyle, which lets developers use the same API on older versions of Android. NotificationCompat.MediaStyle includes a setShowCancelButton() method, but it's only respected on older versions of Android with the bug that makes ongoing notifications non-dismissable. For apps using NotificationCompat.MediaStyle, their only good choice make the notification closeable is to take them out of the foreground and make the notification dismissable.
Because Notification.MediaStyle and NotificationCompat.MediaStyle use their own layouts, it isn't possible to add a close button in the same way that Jockey did before. It is possible to add a close button to the notification, but then it would appear in the same place as the music control buttons, which isn't ideal because it offsets other buttons and could be pressed accidentally.


grub-install: error: efibootmgr failed to register the boot entry: Input/output error

Could you help me?

Hi there!
Can you tell me if you're using an UEFI or a Legacy system? I need to know that in order to reproduce and fix this issue.
Thank you.

Use UEFI system

Hi there!
Can you tell me if you're using an UEFI or a Legacy system? I need to know that in order to reproduce and fix this issue.
Thank you.

Use UEFI system


Unexpectedly found nil while unwrapping an optional value

In this function
private func playerHTMLPath() -> String {
        return NSBundle(forClass: self.classForCoder).pathForResource("YTPlayer", ofType: "html")!
}

I have ran into the same error. Also Pods_YouTubeVideoPlayer.framework and YouTubePlayer.framework is all red in the navigator.

Ditto @memetcircus, do you know of any solution/workaround?

Couldn't find any but it seems that it happens if I use cocoa pods

@memetcircus how do you use it without Cocoa Pods?

Same, it looks like the YTPlayer.html is missing

@AlexChesters checkout my fork at my page. I fixed the bug.

I'm having the same issue but when using videoPlayer.loadVideoURL(url) (also tried with your fork @memetcircus with no luck)

Did you install cocoa pods on your machine ?
--
Mehmet Akif
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Wednesday 15 July 2015 at 17:59, Dante Puglisi wrote:

I'm having the same issue but when using videoPlayer.loadVideoURL(url) (also tried with your fork @memetcircus (https://github.com/memetcircus) with no luck)
—
Reply to this email directly or view it on GitHub (https://github.com/gilesvangruisen/Swift-YouTube-Player/issues/24#issuecomment-121643733).

I'm having this same issue.  Any word on a fix?  I tried manually changing the file that @memetcircus had changed, however it didn't seem to fix the issue.

@Jalsemgeest it works perfectly if you don't use cocoapods, only workaround I've found

Add YTPlayer.html manually to your project's resources, then change the line I wrote above or fork my version of the project in cocoapods.

On Jul 17, 2015, at 3:15 AM, Jake Alsemgeest<EMAIL_ADDRESS>wrote:
I'm having this same issue. Any word on a fix? I tried manually changing the file that @memetcircus had changed, however it didn't seem to fix the issue.
—
Reply to this email directly or view it on GitHub.

Hey @memetcircus. Do you think you could open a pull request between your fork and the master branch? Thanks!

If your'e using cocoa pods you will definitely get error. To resolve this issue I copied the "YTPlayer.html" file into MY PROJECT (not YouTubePlayer) supporting files folder and checnge the below code in Pods/YouTubePlayer/YouTubePlayer.swift
private func playerHTMLPath() -> String {
// return NSBundle(forClass: self.classForCoder).pathForResource("YTPlayer", ofType: "html")!
return NSBundle.mainBundle().pathForResource("YTPlayer", ofType: "html")!
}

@mohanmoorthy thanks man!


[FEATURE]: Add edit and create for groups

Feature Motivation
Creating and editing groups is a core functionality.
Solution Description
Add a create/edit view for groups.
feature_acceptance_criteria

[ ]  All relevant operation fields  (create/edit)
[ ]  Close, Delete, Create/Save buttons
[ ]  Tested

Further Information
No response
Related Issues
No response

Closed via #160


improve pre-receive-hook that checks commit messages

The new version should handle deleted/new branches better and I added a link to help the user fixing the problem.
/cc @github/services-devops-engineers

hook not is robin hood :))


Deserialize List sub Map attribute correctly

Coverage decreased (-0.2%) to 94.209% when pulling 4566004febbf8f6ae67bc621b8a1377502a90af7 on jmphilli:map-list-update into 2433d64fe264f41481f6266a06d2ead2bef3dbab on spulec:master.

Hi @jmphilli, what's the issue you're trying to address/fix here?


This JSX tag's 'children' prop expects a single child of type 'ReactNode', but multiple children were provided

import { signal } from "@preact/signals-react";

const count = signal(0);
function App(){

return  <button
          onClick={() => {
            count.value = count.value + 1;
          }}
        >
          count is {count}
        </button>
}

just a simple demo code will throw typescript error, maybe we should export a new jsx type to satisfy jsxImportSource option?

This is due to React 18's newer, more strict children types. To fix this, you can simply wrap the content in a fragment:
import { signal } from "@preact/signals-react";

const count = signal(0);
function App() {
    return (
        <button onClick={() => count.value = count.value + 1}>
          <>count is {count}</>
        </button>
    )
}

Patching React's types is not a good idea, no, nor is it specific to this library. Any library which uses objects within JSX will likely have this issue.

@rschristian It would be nice if this was add to the documentation and code examples so other people wouldn't have to search Github issues to figure out the problem.

If you have a suggestion for how to improve the docs, PRs are always very welcome.

@rschristian Docs PR: https://github.com/preactjs/signals/pull/385


vedf => dfsql - Ingest veOcean and veAllocate queries from subgraph, into dfsql

You should now have the queries executing inside dfpy, consuming from subgraph and available in a data object.

Cleanup & Transform into Schema - These data objects should now become cleaned up / transformed into the schema that we want to upsert to dfsql.
Create/Update Tables - We are still only sampling from the current epoch and updating the db table. Nothing is saved historically at the moment.

I checked the dfpy sql tables. This is completed.


misc changes for transformers tests

Skip tests that are slow
Include HPU related arguments such as limit_hpu_graphs

@regisss  : could you help with the review and merge, thank you!

The doc build failed because your branch is not up to date with main, merging


Allow decimal comma (at least as substitute in output)

For use in Europe, it would greatly appreciate if, instead of the decimal point, a decimal comma could be used as an option.
I can imagine this is a bit more of programming on the input side, but maybe it is easier to substitute it in the output side (which would already be great). Currently, I have to substitute one for the other in a text processor before printing. But that might also substitute full stops in comments, or other uses of the the point char. So this workaround is neither a comfortable nor reliable.

Hi! It is not possible to do it for the input, but for the output - no problem.
We can add this as an option, but until then, you can easily customize your Calcpad to do that. Download the file bellow and unzip "template.html" in your c:\Program Files\Calpcad\doc folder. Replace the old one.
template.zip
Also, you can add the following lines in your "template.html" just after $(document).ready(function () {:
  $(".eq").each(function () {
      var s = $(this).html().replace(".", ",");
      $(this).html(s);
  });

This will replace all decimal points in equations with commas, but not in the other text.

The fix does exactly what I needed: sparing me from parsing the output. So that solves the main problem. Also thanks for working on an easy customization option for all users.
I do understand that making the input side of the interpreter configurable is more challenging. And writing a point instead of a comma is something one can easily get used to.

Great! I am glad I could help.


Make Array.indexedMap work for all array sizes

Make Array.indexedMap work for all array sizes, instead of hitting 1024 and wrapping around, as #271 states. Added a test case from that example to ensure that the issue is fixed in future verisons

Awesome, thank you for taking a look at the Array issues!
Do I have a contributors agreement from you?

No problem. Yup, I sent it from<EMAIL_ADDRESS>in March I think

Thanks!


Initial Plugin Review

Thanks @grendel-consulting for this new plugin. Great work 🎉 !!
The basic structure looks good so far. While using the plugin, we did come up with a few suggestions based on our best practices:
Missing files

Basic git template files

renovate.json
I think we don't need this folder so we can remove it
docs/index.md

The website URL of Kolide is missing in # Kolide + Steampipe section
Please fix the formatting in ### Rate Limiting section as triple backticks (```) are missing for the block of code.

docs/tables/*

Each query should end with a ;
Each description should end with a .
The example queries in the doc look a bit light. Could you please add a few more example queries for tables, especially for the kolide_k2_package table?
It looks like the SQL query provided is not correctly formatted within an SQL code block. To ensure proper formatting it's important to enclose the SQL code within triple backticks, followed by the SQL identifier.

Makefile

Could you please update the Makefile to follow the format of the namecheap plugin

Makefile

Could you please update the Makefile to follow the format of the namecheap plugin

@khushboo9024, I have followed the pattern used in the aws plugin because this plugin (indirectly) uses the Golang net module and statically-linking it is potentially safer. Let me know you thoughts

Everything else I am addressing in #60 @khushboo9024 , complete bar the further examples so far

@ramirezj thank you once again for the new plugin 👍!!
Few questions/suggestions before we proceed to release the plugin on the hub:

Is there a specific reason for including k2 in the table nomenclature? I was looking at the API docs but couldn't find any reference. Could you please share relevant API docs that clearly differentiate between the K1 and K2 API versions?
Could you please update the README file to stay more consistent with the current set of plugins that we have today? For e.g. https://github.com/turbot/steampipe-plugin-aws/blob/main/README.md
Is there a specific reason for building the netgo package in the Make file? https://github.com/grendel-consulting/steampipe-plugin-kolide/blob/main/Makefile#L8
How has the Steampipe CLI behaved with go version 1.21.9? Does the plugin work as per expectation? We haven't tested out the changes in detail, so curious to know if you faced any particular issue during the plugin development process.

Is there a specific reason for including k2 in the table nomenclature? I was looking at the API docs but couldn't find any reference. Could you please share relevant API docs that clearly differentiate between the K1 and K2 API versions?

Per the remarks on the API token format the token prefix is tied to the original K2 product Kolide offered; happy to rename if you feel this isn't in alignment

Could you please update the README file to stay more consistent with the current set of plugins that we have today? For e.g. https://github.com/turbot/steampipe-plugin-aws/blob/main/README.md

Are there specific elements to include or exclude?

Is there a specific reason for building the netgo package in the Make file? https://github.com/grendel-consulting/steampipe-plugin-kolide/blob/main/Makefile#L8

Following the pattern in the Steampipe AWS  plugin, we want consistent behaviour when using network connections, hence needing to explicitly bake in netgo whwen building on macOS

How has the Steampipe CLI behaved with go version 1.21.9? Does the plugin work as per expectation? We haven't tested out the changes in detail, so curious to know if you faced any particular issue during the plugin development process.

At the moment it is working as per expected on Golang 1.21.9. Not adverse or unexpected results

Everything should be addressed @misraved


responsive result page

Overview of the Pull Request:
THIS PR IS NOT FOR MERGING.
This PR is for responsive result page that fits mobile screen.
Ricky or anyone can use and apply the changes made for responsive mobile device.
I have remove the pie chart size :  200 to plotOptions: pie : 200 . By doing this it allows the circle be responsive.
link to Trello card or Github issue
How Has This Been Tested?

All components response well on mobile device.

Pull Request Checklist:
Make sure the following checkboxes[ ] are checked with x before sending your PR -- thank you!

[ ] Have you included a link Trello card / Github issue and written sufficient description to help others review your work?
[ ] Is your pull request up-to-date with main branch?
[ ] Have you checked That code is well formatted? Did npx prettier --check . return no warnings/errors?
[ ] Have you written instructions on how to test that your changes work as expected?
[ ] Have you tested your work thoroughly on your local machine to ensure you are not breaking anything?

As discussed in this evening's dev huddle, we have decided to close this PR, and revisit this at a later date


-> 1.9.0-R10

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: validate gnap signatures on wasm calls to kms

Signed-off-by: Filip Burlacu<EMAIL_ADDRESS>

Don't we need to disable skip mode to do actual validation ? https://github.com/trustbloc/wallet/blob/main/test/fixtures/wallet-web/docker-compose-server.yml#L176

Yes we do, but we'll need another PR to ensure EDV calls validate properly - so I left validation in auth disabled for now.


rename field model note -> organisation notes for organization details

In GitLab by @jasonpagetas on Jul 10, 2024, 05:59

On the organisation page there is a section for "Model notes" this should be "Organisation notes"

In GitLab by @jasonpagetas on Jul 10, 2024, 05:59
marked this issue as related to #74

added 2m of time spent

mentioned in commit fea7ea31198190bf115dc89595b00d7e034aa991


[mobile] disable autocomplete to ensure key event support

See https://code.google.com/p/chromium/issues/detail?id=118639#c209
You may have a better place to put this, or want to gate it on being Chrome, etc.

Could you elaborate on the problem that is being solved by this? In principle, the editor should be able to handle compose events.

I believe the original issue was that Chrome on Android would send the backspace key event but would not fill in the key code properly. It'd probably be easy to test it out when the next Android Chrome beta comes out, since I'm not sure if this will actually be an issue.

Turning off autocomplete seems like a very indirect and complication-prone way to address this. So yeah, I'd prefer to test first and only go ahead if the problem persists.

Closing this due to lack of response, feel free to comment/reopen if new information is available.


refactor(*): Change empty tuples to Void

Description
We have a typealias for empty tuples Void.
This pull-request changes empty tuples () to Void in return types.
Motivation and Context
Always used Void in return types in this project so I change to recover this in forgotten functions and closures.
PTAL @mxcl 🚀 📱 And thank you for your dedication to the open source. 🙏

Thanks! This is indeed per style guides.


Update log4j2 to 2.15.0 to fix CVE-2021-44228: Apache Log4j2 JNDI features do not protect against attacker controlled LDAP and other JNDI related endpoints

See https://logging.apache.org/log4j/2.x/security.html

Pardon the naive question, but how would one go about integrating this change into an existing JMeter release?
Many thanks in advance!

If you want to patch an existing JMeter release, you can replace the log4j-*-2.x.x.jar files in the lib folder with those of a version 2.15.0 or newer.

An alternative option is to delete JndiLookup.class: https://twitter.com/yazicivo/status/1469394008510279680
zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class

If you want to patch an existing JMeter release, you can replace the log4j-*-2.x.x.jar files in the lib folder with those of a version 2.15.0 or newer.

Thank you @FSchumacher ! Will JMeter automatically update the ClassPath with the new filenames or is it using some kind of regex to pull in those JAR files?

An alternative option is to delete JndiLookup.class: twitter.com/yazicivo/status/1469394008510279680
zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class

Thank you, @vlsi! I'll give that a try if replacing the log4j JAR files doesn't work. Much appreciated.

It loads all the jar files, so new names would work just fine: https://github.com/apache/jmeter/blob/403842148e82c24e560c365efd8b7290076b0ba5/src/launcher/src/main/java/org/apache/jmeter/NewDriver.java#L98-L102

@vlsi  - Большое спасибо! :)

Any ideas or ETA when would the public release be there with the security fix included?

Any ideas or ETA when would the public release be there with the security fix included?

@mazen160 rather than wait for a new release (and potentially new bugs) you can follow the advice given by @FSchumacher and @vlsi above and download the new log4j 2:16.0 release at https://logging.apache.org/log4j/2.x/download.html and replace the JAR files that JMeter uses, which you can find in $JMETER_HOME/libexec/lib/log4j-*
There are 4 JAR files to replace:

log4j-1.2-api-2.x.x.jar
log4j-api-2.x.x.jar
log4j-core-2.x.x.jar
log4j-slf4j-impl-2.x.x.jar

Just delete the existing log4j-* JAR files in $JMETER_HOME/libexec/lib and then copy over the 4 files from the 2.16.0 download
https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0
I did this with my old JMeter 5.2.1 install and it worked like a charm :)

I can confirm that @FSchumacher's suggestion works with JMeter 5.4.1 and log4j 2.16.0. Thank you!
@vlsi Many thanks for your fix! :)

hi all, I'm getting the following error when replacing the log4j JAR files:
2021-12-14 22:06:27,876 WARN o.a.j.r.ClassFinder: Can not open the jar /opt/apache-jmeter-5.4.1-PATCH/lib/ext/._ApacheJMeter_functions.jar, message: zip END header not found java.util.zip.ZipException: zip END header not found
This happens for all the files in the /lib/ext/ folder, any idea why they might be affected? The steps I did were:

Download and extract JMeter 5.4.1 tgz
Download and extract log4j 2.16.0 tgz
Replace the 4 jars in jmeter/lib/
Create a new tgz from there (I host it elsewhere, and this issue comes from downloading this file again and extracting it then running)

Note the leading dot "." in the file name contained in the message. Maybe a broken operating system like MacOS added such unwanted additional files to the directory which then got included in your new tarball, but are not really jar files but instead OS specific metadata files. For the rest of the world such files are garbage leading to unwanted behavior.

in case you're running JMeter in Windows, I wrote a batch file that automate what you need to do;
documentation and instructions can be found here - of course steps are implemented based on all previous comments.
https://dev.to/sebiboga/jmeter-541-fix-for-security-cve-2021-44228-issue-4joc

Quick reminder that there are unreleased nightly builds for JMeter available that you can use at your own risk :)
https://ci.apache.org/projects/jmeter/nightlies/

The fix is available in JMeter 5.4.2: https://lists.apache.org/thread/bskl3n41ty0x3mvt92548xyxds2vsk6s

@vlsi Do you plan to update log4j to 2.16 to fix CVE-2021-45046?

@psmietanaa it's already updated in JMeter 5.4.2 (I just checked)

For the reference, the update to 2.16.0 is https://github.com/apache/jmeter/commit/bdc610a1df6d5d92e7b8ee2e36f186a45ba0d428 + https://github.com/apache/jmeter/commit/0551e4cef9c693fb1661580a3abb212763104a9d

Vladimir: If we wait a bit we can bump to 2.17 :)

🙀  this is not fun: https://issues.apache.org/jira/browse/LOG4J2-3230 Certain strings can cause infinite recursion


CVE-2022-37620

waiting for fix in https://github.com/mjmlio/mjml/issues/2802 - or consider a resolution like proposed in https://github.com/kangax/html-minifier/issues/1135#issuecomment-1502065386. Looks like other packages resolved that CVE successfully.

I suggest reading my comments and especially https://github.com/kangax/html-minifier/issues/1135#issuecomment-2453437884 - because switching to html-minifier-terser will not fix this.


FYP (For You Page) Question

I saw the instance method of .listForYouFeed
I was curious, how many posts does it send from the For You Page.
Thanks.

Probably about 10


What are the goals of this project?

Given that there are already a number of existing lua VMs in Go, how does this one from Microsoft plan to differentiate itself (aside from the fact that it's lua 5.3).
The rationale for a new project should be in the README.

I see questions like this are coming up in other venues as well. For example, this comment sub-set on the reddit post about this lib.

There are several reasons:

We need a Lua 5.3 engine, and the others were not, nor where they interested in updating
The VM is designed differently (I'm encouraging Brian to write a blog post about this), but in a nutshell it is designed for better error handling and for adding a debugger
We wanted an implementation that was closer to the Lua spec than some of the others. We haven't totally nailed that, but we're getting closer by the day
We also wanted clean and idiomatic Go APIs

Before starting on this path, we had been using other Go Lua implementations for quite a while. We just finally arrived at the point where it became evident that our needs were not going to be met.
Eventually we will add more documentation to the README. We honestly didn't think people would discover (let alone use) this project the day we open-sourced it. So it's been a pleasant surprise, but one that caught us off guard.

Where does performance fit in your list of goals?

Well, it is Microsoft

https://github.com/milochristiansen/lua also claims to implement a Lua 5.3 VM.

This is very cool! ^_^ Thanks for open sourcing this project early on 😄
It took me a while to understand the direct benefits lua syntax brings.  Once we feel like we've gotten those nailed, we will turn toward performance improvements. The VM does use pretty much the same stack model as the C implementation, but given that this VM is only a few months old, and the C Lua VM is ten years old, we are highly unlikely to outpace it right away.

Which branch do you guys recommend using? The last commit to master is from February, and to lua53-go-api from April? Is the latter something that will eventually be merged to master, or just an experiment?

The lua53-go-api branch is the current WIP for merging over master. AFAIK, it may still have an issue with the stack. I'll have to check with @fibonacci1729 to see if that is merged on this branch yet.

any documentation anywhere?

Hi all, any updates on the merging of the lua53-go-api branch?
Is this project still under development? We'd like to use it, but are wary of having abandoned dependencies.

I would suggest using Gopher Lua for the time being. We are delayed on this work as we try to finish Helm and CNAB.


Missing dependency in cypress/browsers:node12.16.1-chrome80-ff73 with Cypress 6.9.1

Using cypress/browsers:node12.16.1-chrome80-ff73 with Cypress 6.9.1 to run tests in my pipeline.  Fails because the libgbm dependency is missing.
Running with gitlab-runner 11.10.0 (3001a600)
  on [redacted] NPbaytbq
Using Docker executor with image [redacted]/cypress/browsers:node12.16.1-chrome80-ff73 ...
Pulling docker image [redacted]/cypress/browsers:node12.16.1-chrome80-ff73 ...
Using docker image sha256:2a4a7ff3bce29ff05831e7f8001ac3e377d9df7f07990cbfaf46c2f34e4eb65b for [redacted]/cypress/browsers:node12.16.1-chrome80-ff73 ...
...
><EMAIL_ADDRESS>postinstall /builds/[redacted]/node_modules/cypress
> node index.js --exec install

[13:09:58]  Downloading Cypress     [started]
[13:10:18]  Downloading Cypress     [completed]
[13:10:18]  Unzipping Cypress       [started]
[13:10:26]  Unzipping Cypress       [completed]
[13:10:26]  Finishing Installation  [started]
[13:10:26]  Finishing Installation  [completed]
...
[13:11:38]  Verifying Cypress can run /builds/[redacted]/cypress-cache/6.9.1/Cypress [started]
[13:11:38]  Verifying Cypress can run /builds/[redacted]/cypress-cache/6.9.1/Cypress [failed]
Cypress failed to start.

This is usually caused by a missing library or dependency.

The error below should indicate which dependency is missing.

https://on.cypress.io/required-dependencies

If you are using Docker, we provide containers with all required dependencies installed.

----------

/builds/[redacted]/cypress-cache/6.9.1/Cypress/Cypress: error while loading shared libraries: libgbm.so.1: cannot open shared object file: No such file or directory

----------

Platform: linux (Debian - 10.3)
Cypress Version: 6.9.1
Error: Command failed with exit code 1: cypress run
    at makeError (/builds/[redacted]/node_modules/start-server-and-test/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/builds/[redacted]/node_modules/start-server-and-test/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  shortMessage: 'Command failed with exit code 1: cypress run',
  command: 'cypress run',
  escapedCommand: '"cypress run"',
  exitCode: 1,
  signal: undefined,
  signalDescription: undefined,
  stdout: undefined,
  stderr: undefined,
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false
}

@chrycheng have you used this image successfully in the past? There have been no edits to it or anything. Also, would it be possible to update? There are much newer browser images and the latest Cypress version is 9.5.4.

I am having the same issue after running cypress-axe tests that encounter violations. If there are no failed tests this error doesnt show
Error: Command failed with exit code 1: cypress run
    at makeError (/home/gutz/git/gerrit/mediawiki/core/extensions/WikibaseLexeme/resources/special/new-lexeme/node_modules/start-server-and-test/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/home/gutz/git/gerrit/mediawiki/core/extensions/WikibaseLexeme/resources/special/new-lexeme/node_modules/start-server-and-test/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  shortMessage: 'Command failed with exit code 1: cypress run',
  command: 'cypress run',
  escapedCommand: '"cypress run"',
  exitCode: 1,
  signal: undefined,
  signalDescription: undefined,
  stdout: undefined,
  stderr: undefined,
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1

@guergana what image are you testing with? Have you tried other images?

Closed due to inactivity.


grid navigation

Hi,  I just come across this great looking bit of code, and apologies if this is not the correct place to ask this question, however:
I would like to have a player "roll a dice" to determine straight line movement around the board.  If a player is starting in the centre of the board 0,0,0 and rolls dice for direction (D6) (1 is top-right, 2 is right, 3 is bottom right etc)  and distance (D6) what is the best method for calculating the destination tile?    the dice bit i can figure out it's calculating straight lines to the dest tile I havent got my head around yet...
I was also wondering if there is a method to display each tiles coords on the board to help me figure out some of the maths of wrapping off the end of the board back onto the other side??
and finally...  :-) whats the difference between cell and tile in your code?

Hello. I recommend getting familiar with hexagon cube coordinates since that's what I use as a basis for the grid. More specifically, in HexGrid.js you can see that I have a cached property _directions (also _diagonals) that you can use to find the neighboring tile in the direction you want to go in, and then simply adding the Cell values within those arrays to keep going for whatever distance you wish.
There's a lot of Threejs tutorials on how to display text in a way that always faces the camera - I recommend digging one of those up. Once you have the text showing, you could modify the Tile.js class to create the text object and attach it to the THREE.Mesh the Tile uses, or at least copy its position Vector3.
Be sure to use the dev branch - the difference is much more clear there. A Cell is simply the position and other data that's relevant to the grid classes for their own use. A Tile is the actual 3D mesh that copies the cell's position for displaying in the correct place.
If this answered your questions, please close this issue, I'd appreciate it.

Since it's been a while I'll close this, but feel free to ask for any clarifications here.


HTTPS fails

don't want to make a mess in an issue, so i made a gist:
https://gist.github.com/q60/4d875206006df803d8f7c7daf5acb997

Thanks !
I am at work right now so I cannot look into it, but I will do tonight :)

Zig 0.9.0 running linux x86_64

I moved this issue to requestz's repository: https://github.com/ducdetronquito/requestz/issues/22


Fibonacci infinite sequence possible

I'd like to know how much ability to manage sequence this library has.
For instance,  Fibonacci sequence.
Here's a sample code of
lazy.js with memoize feature of underscore.js or lodash.
var _ = require('lodash');
var __ = require('lazy.js');

var fibF = _.memoize(function(n)
{
  return n <= 1 ? 1 : fibF(n - 2) + fibF(n - 1);  //as the math definition of fibonacci
});

var __fib = __.generate(fibF); //infinite fibonacci sequence

var __fib100 = __fib.take(100); //first 100 sequence (still no calculation)

console.log(__fib100.toArray()); //calculate and output

I 've read the API doc, but can't be sure about this.
Please let me know. thanks.

How about this?  This works in Chrome (should work in FF and Opera, too).
function* fib(prev, n){
    var result = prev + n;
    yield result;
    yield* fib(n, result);
}
var s = new Immutable.Seq(fib(0, 1));


unable to load [Requirement Structure] Form : Error With ActiveX Objects.

I have imported the package on Aras11 SP9 , below related item tabs are not working.

Requirement Structure

ActiveX Object Error ,

Related Part

Event handler failed with message: TypeError: top.frames[1].document.thisItem

Where Used.

Event handler failed with message: TypeError: top.frames[1].document.thisItem

I am not sure what need to do so it will work for the Aras 11 SP9.
-Aniket Gujrathi
<EMAIL_ADDRESS>

Hi Aniket,
This project has been archived because it relies on ActiveX controls, which are not supported by modern browsers. It is not possible to upgrade the project to support Aras 11 SP9 due to current browser technology. If you are interested in a requirements management solution, I recommend checking out the Aras Requirements Management application.
If you would like to learn more about the Aras Requirements Management application, I recommend contacting the Aras Community team at<EMAIL_ADDRESS>You can also check out the demo videos available on the Aras website:
http://www.aras.com/resources/?topic=Requirements-Management&industry=&type=Demo


changed format of DiskSpaceLibrary.winmd

changed format of DiskSpaceLibrary.winmd to AnyCPU to support all Windows 10 formats

Thx


Fixed 27358 -- Add a system check for FileField upload_to starting with a slash

https://code.djangoproject.com/ticket/27358
Made fixes for https://github.com/django/django/pull/7442

buildbot, add to whitelist.

merged in 7cddd8a02e60332c0d02f565c450b0eea0d88438, thanks!


Set channels and versions to ensure we get a good version of tensorflow

Fixes an issue where without specifying the nvidia/label/dev channel conda/mamba will install an old version of tensorflow (2.4.1) which is unable to load the model file.
fixes #324

@gpucibot merge


[AAP-24296] Add Encrypted field to CredentialTextInput

Adds encrypted field to CredentialTextInput that is shown when field isn't empty but is a secret field.

This is looking really close. I noticed that empty fields have the revert/redo button but in the old UI those buttons are not present unless a field has an encrypted value:
Old UI:

New UI:

@marshmalien @kialam I rebased and update credential tests, now there is one credential test failing but it is a known failure due to a cypress command that needs to be updated.

As a team we decided to merge this one, since the test failures are not related.

As a team we decided to merge this one, since the test failures are not related.