[Issue] Windows 10, app working space overlaps with window title bar

It looks like something messes up Path of Building scale rendering, trying to fit it into smaller than intended viewport

Notably, this leads to issues with clicking buttons, as shown below:

It looks like app's working space is rendered starting staright from the top edge of the window, instead of bottom edge of title bar, while coordinates of mouse cursor are counted starting from the bottom edge of title bar (I assume this is correct). This results in shifting of targeting boxes from actual positions of corresponding buttons. Discrepancy is roughly equal to the height of title bar, which kinda proves this theory.
I'm using Windows 10 for Education, ver. 1703, build 15063.413 / Intel HD Graphics 630 (updated to the latest drivers version). Display scaling set to 100%, and just in case Windows scaling turned off in Compatibility tab of Path of Building.exe
I've checked exactly this version on my laptop, and it works fine. Laptop runs Windows 10 Home, ver. 1607, build 14393.1066 / NVIDIA GTX 860M. Notably, Windows scaling is set to 125%, and it is not turned off in Compatibilty tab of Path of Building.exe.

As another data point to attempt to assist tracking this down, I don't see this issue. Windows 10 Home, 10.0.14393 Build 14393. No window scaling.
Wonder if it's something with how win10e handles rendering?

I've seen this a few times; it seems to mostly occur with Intel HD Graphics. It's definitely a display driver issue, and I'm fairly sure I know how the program manages to trigger it, but last time I attempted a workaround it caused major issues for some users, so I'm a little reluctant to go tampering with that part of the code again.
Anyway, the issue may not be around for too much longer, as I'll soon be embarking on a rewrite of the program host's engine, which should fix most outstanding technical issues such as this one. Of course, there'll no doubt be new ones...

@Openarl is it possible to see a commit with workaround? Unfortunately, this issue isn't only about convenience - when I quit to the list of all builds, title bar hides menu buttons, and I can't even get back to the skill tree. I think, I could try to apply patch with workaround in a separate fork (I expect this will require some tinkering, but well, I wouldn't know if it will work if I won't try :) )

The workaround is in the C++ host (SimpleGraphic.dll) and the code for that isn't hosted anywhere, but I can give you a version of that file with the fix in place: SimpleGraphic.zip
You'll need to close PoB, then overwrite SimpleGraphic.dll with the version provided (you'll find it in the PoB folder in Program Files if you used the installer). When you launch the program, it will detect the change and prompt you to update, so just ignore it.

Oh boy. So you're having the problem, and are also one of the people for whom the fix causes issues. Well, on the plus side, if I can make a version that works for you, I'll be fixing two issues at once.
Could you try this version?

Now PoB launches, but the issue is still here

I must admit, that's not the outcome I expected; I thought it would either continue crashing, or work perfectly. I now suspect that the "fix" doesn't actually work, which implies that the problem is elsewhere. I'll be damned if I know where, though.

I've had a report that the latest Intel graphics driver fixes this, so you should try updating.

Updating worked indeed, so I close this one. Thanks for support :)


WIP: Simply sample pipeline input parameters

The issue resolved by this Pull Request:
Resolves #annoyance
Description of your changes:
standard_scaler and min_max_scaler were effectivly mutually exclusive, so let's implement them as such to work around the issue with false-y default input params not parsing/instantiating correctly on the kfp UI.
Testing instructions
Deploy DSPO, create a v2 DSPA with spec.apiServer.enableSamplePipeline = true.  Create a run of the sample pipeline and ensure that all input parameters are populated and you can simply click 'run' without specifying anything else.  Extra credit for also setting 'standard_scaler' to false and ensuring pipeline still runs with the MinMaxScaler instead of StandardScaler
Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/611/head
git checkout -b pullrequest debdd18dd298287080d3e021568ccf76c6fce2e6
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-611"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611

/lgtm

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-611


Fix redux-logger

Hi, thanks for publishing this! really great boiler .. I just noticed redux-logger doesn't log to the console, here's a quick fix.

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   97.82%   97.82%
=======================================
  Files          10       10
  Lines          46       46
  Branches        1        1
=======================================
  Hits           45       45
  Misses          1        1

Impacted Files
Coverage Δ

src/shared/state/store.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da09cd7...ba59f91. Read the comment docs.

Thanks for this. Sorry it took a few days to get things merged.


SQLA: Allow opt-in editing of primary key columns within inline forms?

When SQLAlchemy engine inline forms are rendered, the hidden_pk boolean is enabled during form generation.  For primary keys, this results in the creation of a hidden HTML form field for each primary key column (allowing the inline models to be found and edited when the parent form is submitted).
https://github.com/flask-admin/flask-admin/blob/73febb13a18b48ebb21d5927de944cd5edbae068/flask_admin/contrib/sqla/form.py#L184-L186
Would it be possible to allow selective editable primary keys by skipping this step if the column name is explicitly provided within form_columns?
(this allows editing of keys for inline models that have natural and/or composite primary keys)

I should probably have described what I'd like to do, instead of diving straight into the part of the code that's proving tricky.
I'd like to edit a parent model (Product) that has a one-to-many relationship with child models (ProductName - a single product may have multiple names / synonyms).
Inline editing would be convenient for that, because the two models are closely related (for example: when creating a new product, it may make sense to provide a bunch of known names for it at the same time).
Product names currently have a composite primary key - product_id, singular (where the former is a FK to Product.id, and the latter is a unique singular (not plural) name for the product).
Currently both product_id and singular are hidden when the inline form for ProductName entries is rendered.  I'd like admins to be able to edit the singular value.

Never mind; I don't think this is a straightforward change.  It looks like editing of primary key values can be problematic; the new (previously non-existent) values for the keys submitted in the form cause the creation of new models, instead of edits to the existing item.
Closing this for now because it looks like a more reliable approach here is to use a different PK ID scheme for the inline models.


Is this project still current or there's a new way of doing things with the current remix version?

Currently looking for a solution for typed front-end to back-end operations and stumpled uppon this

Hey there @muchisx, indeed this is still current and as far as I know the closest thing to TRPC in Remix-land. Let me know if you hit any snags.

Thank you @sjc5, I'll give it a try!
Let me know if you make a new video with this updated version, I see the video you made was with your first iteration of it!


Fixed 'bringSubviewToFront' compiling error

Fixes #184

Actually, the current version is correct, since it targets Swift 4.2.
'bringSubview(toFront:)' has been renamed to 'bringSubviewToFront(_:)', so in order to use the CalendarKit with the Swift 4, you'll need to install the release 0.4.3. But I recommend updating your whole project to Swift 4.2 and using the latest version of the CalendarKit.


PNG images not optimized

While JPG works fine, PNG images don't seem to be optimized.
page/index.js
export default function Home(){
  return (<img src={require("../images/thumb-large@2x.png?url")} width={500} />)
}

next.config.js
const withPlugins = require('next-compose-plugins');
const optimizedImages = require('next-optimized-images');

module.exports = withPlugins([
  [
    optimizedImages,
  ]
])

package.json
{
  "name": "next-imagemin",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start"
  },
  "dependencies": {
    "file-loader": "^6.0.0",
    "imagemin-gifsicle": "^7.0.0",
    "imagemin-mozjpeg": "^9.0.0",
    "imagemin-optipng": "^8.0.0",
    "imagemin-pngquant": "^9.0.0",
    "imagemin-svgo": "^8.0.0",
    "imagemin-webpack-plugin": "^2.4.2",
    "next": "9.4.4",
    "next-compose-plugins": "^2.2.0",
    "next-optimized-images": "^2.6.1",
    "node-sass": "^4.14.1",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "responsive-loader": "^2.0.0",
    "sass": "^1.26.10",
    "sharp": "^0.25.4",
    "styled-jsx-plugin-sass": "^1.0.0",
    "url-loader": "^4.1.0",
    "webp-loader": "^0.6.0"
  },
  "devDependencies": {
    "copy-webpack-plugin": "^6.0.3"
  }
}

And the image is<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
...Or am I doing something incorrectly?

Hi @mrgoonie
I see in your package.json that you have imagemin-optipng and imagemin-pngquant installed. I'm not sure, but this could be the reason that next-optimized-images gets confused because of that. You usually only want to use one optimization library for png images. Can you try to uninstall imagemin-pngquant so you only have imagemin-optipng installed (which is more commonly used) and see if that changes anything?

Thanks for the response, I tried your suggestion, but the result is still the same 😢

I'm having the same issue, installed imagemin-optipng and next-optimized-images, however, when .png image sizes remain the same as before installing and adding the plugin.

I recommend using the canary version in this case as it is a complete rewrite and image optimization was moved to WebAssembly and so it works the same in every environment. It solves all current issues and can already be considered stable, just a few features are missing before I will publish it as a non-canary version.
I am sorry that I don't have enough time to investigate this problem in the v2 version. But I want to invest most of my time in the canary version to be able to publish it as soon as possible and resolve all open issues. And it is also possible that this issue is not even caused by next-optimized-images as it uses a 3rd party webpack loader internally which calls the imagemin plugins.

I'm facing the same issue even using the canary version. JPG is optimized (e.g. 1.7 MB to 400 kB), but PNG is even bigger than the original (15.5 MB to 15.6 MB).


Issue with k8s.io/docs/reference/kubectl/overview/

This is a Bug Report

Problem:
Proposed Solution:
Page to Update:
https://kubernetes.io/...

9595-333925

Hi @170031571
What isn't right about https://k8s.io/docs/reference/kubectl/overview/?
/triage needs-information


<EMAIL_ADDRESS>build_type=Release" warning-as-error

Saw this warning-as-error in a LiDO merge request when<EMAIL_ADDRESS>build_type=Release"; partial log below:
==> Installing serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe
==> No binary for serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe found: installing from source
==> serac: Executing phase: 'hostconfig'
==> serac: Executing phase: 'cmake'
==> serac: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 2:
    'make' '-j8'
4 errors found in build log:
     157    cd /usr/WS1/oxberry1/.gitlab-runner/builds/XvEgLX5S/3/gitlab/topopt
            /lido-2.0/uberenv_libs/spack/var/spack/stage/spack-stage-serac-deve
            lop-nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack-build-nlbb25r/src/serac/
            coefficients && /usr/tce/packages/cmake/cmake-3.14.5/bin/cmake -E c
            make_link_script CMakeFiles/serac_coefficients.dir/link.txt --verbo
            se=1
     158    /bin/ar qc ../../../lib/libserac_coefficients.a  CMakeFiles/serac_c
            oefficients.dir/loading_functions.cpp.o CMakeFiles/serac_coefficien
            ts.dir/coefficient_extensions.cpp.o
     159    /bin/ranlib ../../../lib/libserac_coefficients.a
     160    make[2]: Leaving directory `/usr/WS1/oxberry1/.gitlab-runner/builds
            /XvEgLX5S/3/gitlab/topopt/lido-2.0/uberenv_libs/spack/var/spack/sta
            ge/spack-stage-serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack
            -build-nlbb25r'
     161    [ 25%] Built target serac_coefficients
     162    /usr/WS1/oxberry1/.gitlab-runner/builds/XvEgLX5S/3/gitlab/topopt/li
            do-2.0/uberenv_libs/spack/var/spack/stage/spack-stage-serac-develop
            -nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack-src/src/serac/infrastructur
            e/input.cpp: In member function 'std::unique_ptr<mfem::Coefficient>
             serac::input::CoefficientInputOptions::constructScalar() const':
  >> 163    /usr/WS1/oxberry1/.gitlab-runner/builds/XvEgLX5S/3/gitlab/topopt/li
            do-2.0/uberenv_libs/spack/var/spack/stage/spack-stage-serac-develop
            -nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack-src/src/serac/infrastructur
            e/input.cpp:154:46: error: potential null pointer dereference [-Wer
            ror=null-dereference]
     164         mfem::Vector pw_constants(max_attr_elem->first);
     165                                   ~~~~~~~~~~~~~~~^~~~~
     166    cc1plus: all warnings being treated as errors
  >> 167    make[2]: *** [src/serac/infrastructure/CMakeFiles/serac_infrastruct
            ure.dir/input.cpp.o] Error 1
     168    make[2]: Leaving directory `/usr/WS1/oxberry1/.gitlab-runner/builds
            /XvEgLX5S/3/gitlab/topopt/lido-2.0/uberenv_libs/spack/var/spack/sta
            ge/spack-stage-serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack
            -build-nlbb25r'
  >> 169    make[1]: *** [src/serac/infrastructure/CMakeFiles/serac_infrastruct
            ure.dir/all] Error 2
     170    make[1]: Leaving directory `/usr/WS1/oxberry1/.gitlab-runner/builds
            /XvEgLX5S/3/gitlab/topopt/lido-2.0/uberenv_libs/spack/var/spack/sta
            ge/spack-stage-serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack
            -build-nlbb25r'
  >> 171    make: *** [all] Error 2
See build log for details:
  /usr/WS1/oxberry1/.gitlab-runner/builds/XvEgLX5S/3/gitlab/topopt/lido-2.0/uberenv_libs/spack/var/spack/stage/spack-stage-serac-develop-nlbb25r7isuacsdfv3p6gtvexjopqdbe/spack-build-out.txt

It's looking like I won't get to explore this bug in more detail today, but I'll try to dig a little deeper before our meeting tomorrow and see what turns up.


Add support for pattern custom messages

I have added support for custom error messages when using the pattern attribute on forms.
Just using the data-error="blah" attribute doesn't work when there are more than one validation rules being applied to an input. E.g:
<input type="text" pattern="^[0-9]*$" data-error="Some message" required name="afield" />
(In this example a number input would be a better choice, but used this example for the simplicity of the regex)
In this instance you would want the message to be different depending on the criteria that is causing the error.
This change adds the ability to use data-pattern-error="The message" and have this applied only for failed patterns.
I also added in the ability to set messages for native maxlength and minlength failures using the existing data-[max | min]length-error attributes.

Thanks for this! I'll pull this in the next version and hook up the rest of the ValidityState API for fullly-customizable errors.

No worries, it was needed for a client project.
Thanks for reviewing it.
It's running of my fork at the minute, once this is merged it'll be good to get back onto the main distribution.

Thank you for the nice plugin. btw is this version release ?

It's on GitHub but that was mainly so that i could create the pull request:
https://github.com/bmds/bootstrap-validator
Didn't want to create a new distribution just for one small change

@bmds
Oh it's the one I am already using.
But I have a question.
What I want to do is showing the 'max' error message with different language.
EX :
like that.
Currently its showing just in Korean.
I checked 'validator.js' and I could see the 'function getErrorMessage'
Seems 'key == 'native' && $el[0].validationMessage' is returning the error message.
How can I mange error message the max-error depends on language ?
Thank you.

@bmds
I could resolve the problem.
I just added below code in Validator.VALIDATORS
'maxnumber': function ($el) {
var maxnumber = $el.data('maxnumber');
return !$el.val() || parseInt($el.val()) <= parseInt(maxnumber);
}
I don't know if it is appropriate but, it's working.

This has been implemented in v0.11.0


General: Remove IDE specific gitignore

It is the best practice to not include IDE specific directories into the .gitignore file of the repository.
The gitignore should be independent in any way. Therefore, it should not include any information about the operation system or IDE.
Better: Use a local global .gitignore. Github has also an article about this.
What do you think about removing everything which is not necessary for the repository?

Hi @Citrullin, while I don't have a strong opinion on this, I still think that having a repository .gitignore including the main OS and IDE related files is a good thing to avoid having polluted PRs by developpers that don't have a local .gitignore.
On the other hand, I agree that we could order our .gitignore a little bit more clearly.

@thibault-martinez Simple as that: Decline PRs which are polluted and send them a link to the github article about it :)

Of course, but I personally don't think that is bad practice at all.

it's a good practice, let's sort it out in #809


[List] - Pressing the List menu doesn't open the first category.

Environment:
Version : XComponents - version 0.1
Device : Microsoft IE 11 Windows 8.1 64 bit
Steps to reproduce:

Open the website. - http://demo.xcomponents.org:3000/sampler/index.html
Click on the List button from the menu.

Expected result:
The First category auto opens. ( according to the steps to verify : 3. First category auto opens  ).
Actual result:
The First category doesn't open. Nothing happens if the First menu is pressed.open List.mp4

I have same behavior - after click on "Lists", menu opens, page doesn't changes.
XComponents - version 0.1
IE 11 Windows 7 x64 SP1

The test plan says "First category auto opens", but that's for the Accordion option (accessed by clicking Lists > Accordion). If I only click on the label Lists in the top header bar, the dropdown should be shown, nothing else should happen (as it is now in the application).


Bazel outputs isysroot /foo/bar as a single arg, handle it [phab:D1483]

Created by salguarnieri at 2017-04-03 23:31:30:
Bazel is in the process of fixing this, so this should be a short lived
hack.
The problem is that when we pass the arguments to clang, it doesn't
interpret "-isysroot /foo/bar" correctly, which leads to an invalid
syspath, which causes the extractor to fail.

zarko commented inline (context lost during migration) at 2017-04-03 23:51:20:
Consider matching against "-isysroot " instead. It's forward-compatible with a fixed Bazel, where the code here will index out of bounds.

zarko required changes at 2017-04-03 23:51:20

salguarnieri wrote at 2017-04-03 23:55:34:

look for the space

zarko accepted this revision at 2017-04-03 23:56:29

salguarnieri closed via commit 00ce8bf23656cd6e39a0da878c948c99bcd50955 at 2017-04-03 23:57:40


How To Create Custom Data For This Model

If my data is structured this way, how can I create data that fits your model with no candidates and personas?
1 Hello, how are you?
2 I'm good, what's new?
3 nothing much, watching tv.
4 cool, talk to u later.
...
Also, it seems to me that your data structure is suited only when there are an equal number of turns, what if I have odd number of turns?

Closed due to #34.


Make the message for when the server is running shorter

This makes the message that appears when the now dev server is running shorter:

It's now very similar to what you see when deploying:

@leo  @evilrabbit  I like new message.

Codecov Report

Merging #2262 into canary will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           canary    #2262   +/-   ##
=======================================
  Coverage   10.37%   10.37%
=======================================
  Files         246      246
  Lines        9024     9024
  Branches      989      989
=======================================
  Hits          936      936
  Misses       7969     7969
  Partials      119      119

Impacted Files
Coverage Δ

src/commands/dev/lib/dev-server.ts
38.64% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f06fd...72c6102. Read the comment docs.


[SPARK-39272][SQL] Increase the start position of query context by 1

What changes were proposed in this pull request?

Increase the start position of query context by 1
Why are the changes needed?

Currently, the line number starts from 1, while the start position starts from 0.
Thus it's better to increase the start position by 1 for consistency.
Does this PR introduce any user-facing change?

No
How was this patch tested?

UT

@HyukjinKwon @dongjoon-hyun @yaooqinn @cloud-fan Thanks for the review.
Merging to master/3.2


Chrome Android: scrollable dialog jumps around after dragging

The behaviour of scrollable dialogs is currently imperfect, with the top of the dialog (and therefore its contents) jumping around when scrolling a div within the dialog. This only seems to be happening after an initial drag event. As can be seen in this reproduction video of the documented example, the scrolling functions perfectly when that's the first thing I try. The second time I open it, I drag it around first, and then try to scroll. Then, the dialog jumps around unpredictibly as I scroll. This behaviour is currently also happening in Vercel's notification dialog for me. If relevant, I am on Chrome 119 on Android 13.

This is fixed in #167

Wow, that was an amazingly quick fix. Thanks a ton!


doc: Add SKIP_LINT option to render-docs target

Add an option to skip the syntax and spelling checks for the inpatient.
Thse checks are still enabled by default, but can be turned off while
you iterate on making documentation changes.
make render-docs SKIP_LINT=1  1.98s user 1.59s system 53% cpu 6.639 total
make render-docs  1.96s user 1.55s system 4% cpu 1:24.54 total

Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

Coverage decreased (-0.007%) to 42.566% when pulling 13883e0da1840d42d5b525805c9722c23d549430 on pr/michi/skip into 3c25373901605acb9d8615ae2f0ba68e5a78ac18 on master.


Collection View Page

Need a page for viewing a collection. For now this can be based on the current collection view page in SS3.

We are currently using the database record (for works and collections display). May look at changing this to be backed by Solr instead of the database post-release in order to be able to search and sort.

We currently have a publicly accessible "view" page for showing a collection, it lives at /resources/:the-uuid-of-a-collection: and it shows the metadata for a collection along with the list of works in that collection. It's certainly not pretty.
What does done look like with this ticket? Does it need final visual styling?

Fixed in #473


DELETE v3/routes/{guid}

Is there a related GitHub Issue?
closes #491
What is this change about?
Implements DELETE v3/routes/{guid}

update api docs
update space developer RBAC

Does this PR introduce a breaking change?
no
Acceptance Steps
see issue

Can you add api end-to-end tests for this endpoint, please? We are starting an effort of backfilling the e2e test since most of the endpoints are lacking these and it will help a lot if we write them along with the story. Otherwise we will be chasing a moving target and it will be a pain.

@georgethebeatle I am having trouble getting the e2e tests passing- I don't think I changed anything related to the ones that are failing.
It is difficult to jump in and write the new e2e tests for my endpoint when I am unfamiliar with this code and how it works.
Do you have any pointers or examples to help me get started?

@gnovv unfortunately there are flakes, it is rue so it could be that some unrelated tests are failing, but I guess just ignore them for the scope of this story. It would be sufficient to write tests for DELETE v3routes{guid}, which is the endpoint that this story implements, isn't it? One way to ignore flakes would be to just focus your Its and run them in isolation to make sure they are passing. There are not too many e2e test at the moment to use as examples, but still there are enough to get some orientation. This one is relatively straightforward I think. On line 26 it invokes a helper that just POSTs on /v3/roles and in the It it checks that a role binding was created by the endpoint handler. Hope that helps.

@georgethebeatle we added an auth test to api/apis/integration/route_test.go instead of implementing it as an e2e test, similar to @kieron-dev 's PR: https://github.com/cloudfoundry/cf-k8s-controllers/pull/537

@gnovv @Birdrock the tests that @kieron-dev moved in #537 were error cases, not happy paths, like the one we are discussing here. It is a good idea to move error cases to integration since they are faster and we we have more control there, because mocks can be used. While there is value in the test you've written there will also be value in an e2e that does the same checks. I realise that it might be a bit odd to start from the DELETE method, so updated #525 to include it as well. It would be great if US colleagues can help with backfilling e2e tests for this endpoint, since you generally have more context on it.


Running notes on botification

The motivation behind botification is to open this up to Slack users who don't have access to an export and make it more likely to be used at hilarious or poignant moments. The approach I'm testing here is ripe for a Serverless deploy, which will absolutely live on servers, but not ones we manage.
Possible steps:

Receive a Slash command. In my test app, I set up the /script Slash command to point to a Glitch.me instance and got this via HTTP post:

{
  ...
  team_id: 'XXXXXXXX',
  team_domain: 'thegpf',
  channel_id: 'XXXXXXX',
  channel_name: 'lunch',
  user_id: 'XXXXXXX',
  user_name: 'zubakskees',
  command: '/script',
  text: '',
  response_url: 'https://hooks.slack.com/commands/XXXXXXXX'
  ...
}

Collect channel history. To test the conversations history endpoint, I did:

curl --data "token=XXXXXXXXXXX&channel=XXXX" https://slack.com/api/conversations.history

And got a response containing the last 100 messages in this format:
{
  "ok": true,
  "messages": [
    {
      "type": "message",
      "subtype": "channel_join",
      "ts": "1584051783.141600",
      "user": "XXXXXXXX",
      "text": "<@UVBB0CSV6> has joined the channel",
      "inviter": "XXXXXXX"
    },
    {
      "client_msg_id": "XXXXXXXXXXXXXXXX",
      "type": "message",
      "text": "seems like a perfectly fun way to avoid catching up on work tonight",
      "user": "XXXXXXXX",
      "ts": "1584050632.141100",
      "team": "XXXXXXX",
      "blocks": [
        {
          "type": "rich_text",
          "block_id": "gcIh",
          "elements": [
            {
              "type": "rich_text_section",
              "elements": [
                {
                  "type": "text",
                  "text": "seems like a perfectly fun way to avoid catching up on work tonight"
                }
              ]
            }
          ]
        }
      ],
      "reactions": [
        {
          "name": "+1::skin-tone-2",
          "users": [
            "XXXXXXX"
          ],
          "count": 1
        },
        {
          "name": "100",
          "users": [
            "XXXXXX"
          ],
          "count": 1
        },
        {
          "name": "heart",
          "users": [
            "XXXXXX"
          ],
          "count": 1
        }
      ]
    },
    ...
  ],
  "has_more": true,
  "pin_count": 61,
  "channel_actions_ts": null,
  "channel_actions_count": 0,
  "response_metadata": {
    "next_cursor": "XXXXXXXXXXX"
  }
}

Collect user info. This doesn't actually give us user names. To get those, we may have to repeatedly query the user info endpoint with all the user IDs from step 2. E.g.,

curl --data "token=XXXXXXXXXXX&user=XXXX" https://slack.com/api/users.info

{
    "ok": true,
    "user": {
        "id": "W012A3CDE",
        "team_id": "T012AB3C4",
        "name": "spengler",
        "deleted": false,
        "color": "9f69e7",
        "real_name": "Egon Spengler",
        "tz": "America/Los_Angeles",
        "tz_label": "Pacific Daylight Time",
        "tz_offset": -25200,
        "profile": {
            "avatar_hash": "ge3b51ca72de",
            "status_text": "Print is dead",
            "status_emoji": ":books:",
            "real_name": "Egon Spengler",
            "display_name": "spengler",
            "real_name_normalized": "Egon Spengler",
            "display_name_normalized": "spengler",
            "email"<EMAIL_ADDRESS>            "image_original": "https://.../avatar/e3b51ca72dee4ef87916ae2b9240df50.jpg",
            ...
        },
        "is_admin": true,
        "is_owner": false,
        "is_primary_owner": false,
        "is_restricted": false,
        "is_ultra_restricted": false,
        "is_bot": false,
        "updated":<PHONE_NUMBER>,
        "is_app_user": false,
        "has_2fa": false
    }
}

Respond to the slash command. According to the documentation, we can either immediately respond (as a response to the initial HTTP request in step 1), or do some work and respond later. An immediate rich text response might look like:

{
    "blocks": [
        {
            "type": "section",
            "text": {
                "type": "mrkdwn",
                "text": "*I made this into a script.*"
            }
        }
    ]
}

Produce a script???? So far it's been pretty easy, but here's where we have to make some decisions, because we somehow have to serve the script to users.

Options include:

formatting it as an in-Slack text snippet and returning it in the response (we lose some formatting control);
storing the data from previous steps somewhere and linking to a web page that dynamically assembles the script (data privacy concerns);
assembling the script into a static HTML file and pushing it to S3 (doesn't allow for interactive customization, will be there for eternity);
providing users with a link that allows them to login with their own Slack credentials and then does the API requests while they wait, storing nothing and relying on Slack's own authentication model (this is somewhat complicated).

So many options.

After having thought it over, my own inclination is to store a stripped down and sanitized JSON representation of the conversation in S3 perhaps accessible via a presigned token that gets written into the response URL. This doesn't require a database, allows for after-the-fact changes and strikes a balance between privacy and complexity. Other people may to come to different conclusions.
Another concern is how to crop or edit out messages that the user doesn't want, either for artistic or privacy reasons. One really simple way would be to allow the user to optionally specify a number of messages (below 100) that would be collected, or perhaps specify a starting point somehow.

Did a first pass at this. Responds to Slack commands. Collects channel history. Pushes it to an S3 bucket. Sends back a signed URL. Published in this repo. Remaining work is to collect user names and connect it to a user-facing script formatter.
But I'm now feeling like maybe the user OAuth sign-in route might be the right one after all. Essentially the front end would be a limited purpose Slack client for displaying scripts.


Duplicate entries when annotations in interfaces

We use interfaces and Implementations for controllers and interfaces annotated with Spring's annotations also are included on the Found Services list, causing duplicated entries. Maybe makes more sense to add only the ones implemented.
Anyway, thanks for the great tool :D

Show me your code or screenshot please.

We use a contract first approach and what I have is the interface:
    @RequestMapping( value = "/policies/receipts/unpaid/excel",
                     produces = { "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" },
                     method = RequestMethod.GET )
    ResponseEntity< byte[] > myMethod() { ... }

And the implementation:
    @GetMapping(value = "/receipts/unpaid/excel", produces = Constants.APPLICATION_MS_EXCEL)
    public ResponseEntity<byte[]> myMethod() { ... }

Also, the service list is not ordenated in alphabetical order. That would be nice too.

We use a contract first approach and what I have is the interface:
    @RequestMapping( value = "/policies/receipts/unpaid/excel",
                     produces = { "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" },
                     method = RequestMethod.GET )
    ResponseEntity< byte[] > myMethod() { ... }

And the implementation:
    @GetMapping(value = "/receipts/unpaid/excel", produces = Constants.APPLICATION_MS_EXCEL)
    public ResponseEntity<byte[]> myMethod() { ... }

Also, the service list is not ordenated in alphabetical order. That would be nice too.

What's your RESTKit version? It's ok in my idea with latest version 2.0.5

I am using the same version as you, the 2.0.5.
As I said, we use a Contract first approach and, besides the interface and implementation, we have the "contract" that is an yaml that defines the endpoints that the controller has. The yaml is something like that:
receipts-unpaid-excel:
    get:
      tags:
        - policies
      description: a description...
      operationId: myMethod
      responses:
        "200":
          description: OK
          content:
            application/vnd.openxmlformats-officedocument.spreadsheetml.sheet:
              schema:
                type: string
                format: byte
      security:
        - appToken: []
        - apiToken: []
      deprecated: false

Not sure what else to look. : (

When I do a search in files, this is what I get:

sorry, this plugin does not analyze this yaml. please give me some exception detail the plugin occurred, screenshot or exception stacks. so i can know which line that caused your problem.


Implement Query Locks

Wrap the Provider.find_or_create and find_or_create_one methods in contextual locks to prevent duplicate data in multithreaded environments.
(closes #27)

Coverage decreased (-100.0%) to 0.0% when pulling 66fe3e5149b87c4d3bcfd6b495a46324de331c68 on query_locks into 6cdd38e7335162132e492b0f891ba18f790e9da1 on master.


--reset resets all deployments even when --tags are used

Having a sequence of deploy scripts I wanted to redeploy only using 1 of them (redeploying 1 contract).
I expected the --reset would delete only those deployments, which are related to the given --tags.
However it deleted all deployments.
I understand this might be the design decision. Is there any work around in such case?

tags are not known post deployment
actually tags are not necessarily tied to deployments, so --reset has to delete all
I guess you could have a script that delete contract you know are using which tags

I found the workaround:

delete contract(s) to be redeployed from .migrations.json
no --reset is needed as the deployments files are to be overwritten

Regarding --rest I suggest to update help to make it clear:
whether to delete all deployments files first

Agree, I expected the same (only related Tags deployments to be reset). Even if the workaround does works, seems hacky, I would suggest renaming --reset to reset-all and/or add parameters to it, like: --reset * for all and --reset NAME_1,NAME_2 for specific components.

Agree, I expected the same (only related Tags deployments to be reset). Even if the workaround does works, seems hacky, I would suggest renaming --reset to reset-all and/or add parameters to it, like: --reset * for all and --reset NAME_1,NAME_2 for specific components.

--reset NAME cannot work as mentioned in my comment above
It would be good to have confirmation stating that happens though


[Enhancement] switch back to consistent hash ring when node number is large

What type of PR is this：

[ ] bugfix
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #10720
Problem Summary(Required) ：

Algorithm complexity of RendezvousHashRing is  $O(NM), O=|ScanRanges|, M = |Backends|$.
But performance is bad when $N*M$  is large.
So we switch back to ConsistentHashRing when node number is large, since algorithm complexity of it is  $O(N*log(M))$
=================Test Benchmark =====================
SimpleWalk: 1000 Nodes, 1000 Keys, time = 196ms
PlainHash: 1000 Nodes, 1000 Keys, time = 1ms
ConsistentHash: 1000 Nodes, 1000 Keys, time = 2ms
RendezvousHash: 1000 Nodes, 1000 Keys, time = 873ms

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 7 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/HDFSBackendSelector.java
6
7
85.71%
[175]

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 7 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/HDFSBackendSelector.java
6
7
85.71%
[175]


gh-pages

Hey! Thanks so much for these. I plan to use the Pac-Man loader on my new site. I can't believe my luck that you just published these a few hours ago. To preview them I had to clone the repository, which isn't a huge deal, but most other comparable projects have a gh-pages which I didn't see linked to on your README. Would you like me to add that?

Hi,
To preview all loaders just go to http://github.danielcardoso.net/load-awesome/ :)
Enjoy.


create obj folder in gldcoin/src directory

I know it is easy on our end but should be fixed in the repo.

Will do, currently separating the branches for dev and release. That is next on my list.

looks to be there now ;)


Trivial regolding for two tests due to the change on outputting extra element integers

https://github.com/idaholab/moose/pull/27026
Tag @lindsayad and @GiudGiud
Closes #365.

The change in XML file is to remove a warning caused by an outdated attribute InMeter in the file.

Job VTB Documentation on e564bd9 wanted to post the following:
View the site here
This comment will be updated on new commits.

Regolding is fine but could we get away with ignoring the field instead? In the tests specs. There should be a shorthand for ignoring fields

There is. But I think regolding is possibly preferred.

Regold s not generally preferred. Especially with large LFS files
The PR will need a submodule update to pass
Also the cross sections file should not have changed?

Forgot commenting the xs file. No, I do not have to change it. Just when running the model, I noticed some warnings when loading the file, so I removed the warning by remove the outdated attribute InMeter in the file. The two exodus files are LFS files?

All 3 files are LFS files

Do I need to manually update MOOSE as well?

Job MOOSE on bb60e17 : invalidated by @GiudGiud

@GiudGiud let me know if I need to do more on this pr. Maybe this is ready to merge.

no but the two diffs in Griffin still needs to be fixed

but the two diffs in Griffin still needs to be fixed

What are those?

Job MOOSE on 917162d : invalidated by @lindsayad

Job Test SAM on 917162d : invalidated by @lindsayad

failures are unrelated

Not completely unrelated but we ll resolve them with a blue crab & direwolf submodule update later on so all good


Make diff syntax highlight configurable

Make #225 configurable

The changes were reverted in https://github.com/ellisonleao/gruvbox.nvim/commit/0d383750a907a96c964bbbfe17f75f6e066d09dd. The old colors are back. We can open a new discussion for a better diff color if the issue remains. I will close this PR since it's no longer necessary


chore: tuck rollback sync

Closes THR-33

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#584  👈 (View in Graphite)
#583
#582
#581
#577
#576
#575
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 29, 2:35 PM EST: A user started a stack merge that includes this pull request via Graphite.


Rename assets to thinkpad-tools

Describe the bug
Rename the directory assets to thinkpad-tools.
Expected behavior
Easy identification of the used directory after installation, e.g., in /usr/lib/python3.7/site-packages

renamed to thinkpad_tools_assets with 72a2e58c64a08f6da3362fbd8a72c54d63bd8e31


Add Conways Game of Life

add thumbnail
add game

The Game of Life, also known simply as Life, is a cellular automaton devised by the British mathematician John Horton Conway in 1970. It is a zero-player game
https://en.wikipedia.org/wiki/Conway's_Game_of_Life

includes debug views if the view is a certain size (so text aligns correctly)
as well as two speeds, a single step mode, and a way to clear everything
there is some helper js in the bottom that ensures the timers etc are cleared up when the user restarts the code
this is still in progress

Ok, should be good to review

Ok, should be good to review


commitsApi.getCommit(projectId, branchName) fails with 404 if slash in branch name

When I call, e.g., commitsApi.getCommit(1672, "feature/my-feature-name"), it throws a GitLabApiException with "404 Not Found."
When I URL-encode the branch name, it succeeds.
Using 4.9.18

@SamerAdra
This has been fixed and released in 4.9.22.  Please verify and close this issue when you have a chance.

Verified fixed. Thanks!


Implement the methods getAllAssignments(), getAllRoles,  getAllRules() in Manager::class

I think it would be a good thing to return these methods in manager since they are resolved within the class, which is ideal for creating an rbac service.

It's good to have these but it won't work for real-world cases:

If there are too many assignments (and that is very likely) pagination is needed.
For a good UI, more it needed: you'll likely need an ability to search and auto-complete items etc.

I think it's a good idea to release without these and then add it in a subsequent major release.


Install docs

Closes https://github.com/Unidata/cftime/issues/31

@ocefpaf - the build is failing because the installing.rst document isn't in a TOC tree yet. Can you add it to the index page? Otherwise, I think this looks okay.

@ocefpaf - the build is failing because the installing.rst document isn't in a TOC tree yet. Can you add it to the index page? Otherwise, I think this looks okay.

Sure. I asked where it should be :smile:
Is it OK to be right after Indices and tables?

@ocefpaf - I took the liberty to make the headings a bit smaller but other than that, this looks good. Thanks for the help here. Provided the tests pass, I'll merge this and create a release tag!

@ocefpaf - I took the liberty to make the headings a bit smaller

Whatever works :smile:

but other than that, this looks good. Thanks for the help here. Provided the tests pass, I'll merge this and create a release tag!

Awesome! Thanks!!


Prepare for React 16: Deprecated React.CreateClass

Gotta remove CreateClass prior to version 16. Seems to only be in 4 files:
https://github.com/dreyescat/react-rating/search?utf8=✓&q=React.CreateClass&type=
PercentageSymbol: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

 Let's do one at a time. For now I have solved the createClass with the easy option (I am thinking about moving the entire component to es6 as a long term solution).
Also migrated TestUtils from deprecated react-addons to react-dom/test-utils.
Pending:

PropTypes

I proposed a fix for PropTypes here https://github.com/dreyescat/react-rating/pull/47 let me know if you have any feedback


Button with Over & Pressed states

Consider the following spriteseet:

Is it possible to create a 9sliced button with over and pressed states from this kind of asset?

Usually button's that are ninesliceable also require stuff like text or icon's in them, for which a default Phaser.Button has no support. So I usually end up constructing my own buttons.

That was exactly what I thought... Thanks for your feedback.


Fix #488 remove smtp_tls_eecdh_grade = ultra

This looks correct given the info here and the config disabling TLS < 1.2: https://www.postfix.org/FORWARD_SECRECY_README.html

With TLS 1.2 the server needs to leave its setting of "smtpd_tls_eecdh_grade" at the default value of "auto" (earlier choices of an explicit single curve grade are deprecated). With TLS 1.3, the "smtpd_tls_eecdh_grade" parameter is not used, and curve selection is unconditionally negotiated.

@robnagler Since you assigned this to me, were you looking for me to do something further?

@schellj just looking for your review/approval since you had worked on this code recently.


Fix missing :EnPackageDecl declaration for Vim

Pressing <Space> in the package inspector window was resulting in an error in regular Vim because : EnPackageDecl was undefined. This looks to have been a copy-paste oversight in #217, including two copies of :EnSymbolByName by accident but having it correct in the Neovim decorators.
Also adds a note to the help to try to reduce the potential confusion of the split not being immediately opened in current implementation. (Funnily, I missed this caveat in the original PR, and it turns out that the splits are queued up… so if you try <Space> four times and then move the focus, you get four splits 😇   Definitely room for improvement but I like the start).
cc @ChrisCoffey

Looks good, thanks for the PR & sorry for the typo!
@jvican merge when you're ready.

LGTM!


Bugfix/content type time series

Added deprecated notification to the getAll method for TimeseriesController, and aliased application/json and \*/\* as aliases to application/json;version=2.  Added application/xml as an alias for application/xml;version=2.
Fixes #505

So, did anyone check that the old format is still accessible?

If the old format was accessible before, it shouldn't have an issue with the new code, however I didn't write any code to verify the older formats still work, unless the version was tagged as a FormattableWith on the DTO.

@MikeNeilson do you want me to add an integration test for the older format for Time Series as part of #505 ?  It'll probably take 30 mins.


Back button does not work if toggle from all to rare stepper

Start to create a phenotype
fill in the individual page
Change stepper from rare to all
go to file step
add a file
change stepper from all to rare
The file information is still shown, with only one button, the "back" button
Click the back button
Nothing happens on the UI
It causes this console error

It is possible to continue working by using the stepper to move to a different step

@belkassaby I followed the steps above, I did not see error in console button but when I clicked back button after switching to Rare disease steps , I got the File step


Update Provider and add more PropertyReferenceTypes

Mark ErrorResponse, UserAssignedIdentity, ProviderResourceType, ProviderData as PropertyReferenceType. They will be used by Resources SDK.
ErrorAdditionalInfo is also marked as PropertyReferenceType but no JsonConverter added for it as usually it's only a property of ErrorResponse, RP packages just deserialize ErrorResponse no direct usage of deserializaing ErrorAdditionalInfo, but marking it as PropertyReferenceType  will make RP packages skip the generation of a duplicate ErrorAdditionalInfo model in them. If we found cases of RPs using ErrorAdditionalInfo directly later, we can add JsonConverter then.
Updated ProviderData and ProviderResourceType based on new swagger changes (2021-04-01).
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run

I am not seeing Plan, Sku in the change list.

I am not seeing Plan, Sku in the change list.

The purpose for this PR is to mark the minimal set of PropertyReferenceTypes that is used by Resources SDK to unblock its generation, among which some are common types and some are only used for Resources. It does not aim to mark all common types as PropertyReferenceType.
In order to mark all common types as PropertyReferenceType with autorest generation, besides this PR https://github.com/Azure/autorest.csharp/pull/1465, we will need another autorest change to add JsonConverter like the one in ResourceIdentity:
https://github.com/Azure/azure-sdk-for-net/blob/2f06cbc8c09bc451715eeb48d7d4875bcf9162db/sdk/resourcemanager/Azure.ResourceManager/src/Custom/Resources/Models/ResourceIdentity.Serialization.cs#L143-L154


Question about the formula calculating c value

In the  paper,

what does this formula mean? softmax gives a vector and h_i is also a vector. what does mulitplication of softmax and h_I means?

hi @guldamkwak3114 we meant to normalize the scores alpha_i and do weighted sum of all h_i. Sorry for the bad and confusing writing.

What do you mean by normalize the scores alpha_i ?

Softmax is the normalization operation.

Still confuse me. softmax(alpha_i) and h_i are both vectors.................... how can we multiply them?

do you mean dot product of softmax(alpha_i) and h_i ?

The softmax(alpha_i) here means doing softmax for all scores and take the ith component, which is just a single value.  So we normalize the score with softmax for all neighbors and do a weighted sum of each neighbor's interaction feature.

alpha_i itself is a vector. then do you mean take softmax of (a_1,a_2, .... ,a_n) and get the i-th component?
Thanks

Is alpha_i a vecotr? alpha_i is the score for each pair right?

take softmax of (a_1,a_2, .... ,a_n) and get the i-th component?
This is right.

according to this alpha_i should be length 100 vector. Am i miss-reading something?

The hidden units refers to all the MLP layers up to but not including the last layer. The last layer outputs one single value for each pair/human as the attention score. The corresponding code: https://github.com/vita-epfl/CrowdNav/blob/503173b836d5460e30234df7e14a7c67ee0ebfc7/crowd_nav/policy/sarl.py#L48


currentObjectGraph is deleted before it's resolving isn't completed

Hello!
I have crash at guard let currentObjectGraph = currentObjectGraph else { fatalError() } when I'm trying to resolve cascade dependencies. The problem is child container completes resolution graph for itself and for it's parent as well while parent did not finish resolving all dependencies.
The sample code to reproduce this issue is here:
class A {}
class B {}
class C {}

let container = Container()
let childContainer = Container(parent: container)

container.register(A.self) { resolver in
    let c = childContainer.resolve(C.self)! // resolve 'C' and delete main container graph
    let b = resolver.resolve(B.self)! // fatal error here
    return A()
}
container.register(B.self) { _ in B()  }
childContainer.register(C.self) { _ in C() }

let a = container.resolve(A.self)!

The issue was taken place after https://github.com/Swinject/Swinject/pull/409 when graphResolutionCompleted() call was added for parent as well.

What is the reason for calling childContainer directly in the register closure? Maybe your usecase could be achieved in a more idiomatic way? I'd say that it is a misuse of the API - one should not invoke specific container, but rely on the passed resolver instead.

Thanks for the answer! The sample was oversimplified.

What is the reason for calling childContainer directly in the register closure?
We started using Swinject before Assembler class was introduced and we created own modular mechanism. Each module contains own container. So, sometimes during resolving process it's needed to resolve not dependencies, but whole module with own container and dependencies. When class A requires some external module, witch can resolve C class.

let container = Container()
container.register(ModuleC.self) { [unowned container] _ in
     return ModuleC(parent: container) // register module with class C
}
container.register(A.self) { resolver in
    let moduleC = childContainer.resolve(ModuleC.self)!
    let c = moduleC.resolve(C.self)! // resolve 'C' and delete main container graph
    let b = resolver.resolve(B.self)! // fatal error here
    return A()
}
container.register(B.self) { _ in B()  }

let a = container.resolve(A.self)!

I see. I'd still consider this a misuse of the API, but it is quite easy to reimplement #409 without breaking your usecase, see #418


How to set width on panel tabs widget

https://stackoverflow.com/questions/56498628/how-to-set-width-on-panel-tabs-widget

Looks like this may have to be raised in bokeh, the only way I can get this to work currently is by setting the width on the content of one of the tabs.

Setting the width on the contents of the tab does work.


Remove SonarCloud token configuration from setup scripts

User description
📑 Description

Remove SonarCloud token configuration, since it can be set at account level instead per project.
If you need per project, just add an environment variable to the appveyor.yml file named SONAR_TOKEN.

✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[X] I have updated the documentation as required
[X] All the tests have passed

☢ Does this introduce a breaking change?

[X] Yes
[ ] No

ℹ Additional Information

[!NOTE]
I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.

Description

Removed SonarCloudToken prompts and configurations from initial-setup.ps1 and initial-setup.sh.
Updated appveyor.yml to eliminate SONAR_TOKEN from environment variables.
Documentation updated to reflect changes in token configuration.

Changes walkthrough 📝
Relevant filesEnhancement

initial-setup.ps1Update initial setup script to remove SonarCloud token

initial-setup.ps1
Removed prompt for SonarCloudToken.  Updated logic to exclude SonarCloudToken from configuration.

+0/-2

initial-setup.shUpdate initial setup script to remove SonarCloud token

initial-setup.sh
Removed prompt for SonarCloudToken.  Updated script to exclude SonarCloudToken from configuration.

+0/-3

Configuration changes

appveyor.ymlRemove SonarCloud token configuration

appveyor.yml

Removed SONAR_TOKEN configuration from environment variables.

+0/-2

Summary by Sourcery
Remove the SonarCloud token configuration from the project setup scripts and appveyor.yml file, allowing it to be managed at the account level instead of per project.
Build:

Remove SonarCloud token configuration from the build scripts and appveyor.yml, as it can now be set at the account level instead of per project.

Summary by CodeRabbit

New Features

Updated project setup scripts to streamline initialization with user-defined values.
Enhanced flexibility in project naming and configuration.

Bug Fixes

Removed references to the Sonar Cloud token to simplify the environment setup.

Chores

Cleaned up and renamed various project files and directories to align with new project specifications.

@gstraccini rerun failed workflows


💡 Idea: Entry relationships / footer directives

Intro
In some scenarios, just providing a description of a commit is not sufficient to describe a change because the change does not stand on its own.
These Relationships between change log entries could be modeled using special directives in commit messages that define these relationships.
These could then be taken into account when generating the change log and activate additional behavior.
Format
Entry relationships can be modeled as regular footers which keeps compatibility with the Conventional Commits specification.
A entry relationship consists of a type and a referenced entry:

The relationship type is modeled as a footer's name
The referenced entry is specified in the footer's value using the entry's git commit sha

For example, a bug fix that reverts a previous commit, could model this relationship using a Reverts footer:
fix: fix a bug

Description of the bug fix

Reverts: d81a8dbdb6bbb815f13633cf2be066005846d320

Relationship types
Message-For
Overrides a entry's commit message with a different message
Reverts
Indicates that a commit x reverts a previous commit y:

If both x and y belong two the same version, neither entry is included in the change log
If x and y belong to different versions, the change log will contain a link between the two entries

Fixes
Indicates that a commit x fixes a bug introduced by commit y.

If both x and y belong two the same version, x is omitted from the change log (because the bug was introduced in the same version and hence the bug is not a change compared to the previous version)
If x and y belong to different versions, the change log will contain a link between the two entries

Replaces
Indicates that a commit x replaces a different commit y.
All occurrences of commit y in the change log are replaced with the entry for x
Open questions ❓

Is there special handling for transitive dependencies required? (e.g. using the commit 1 includes a "Message-For" footer for commit 2 but commit 3 includes a "Message-For" footer for commit 1)
Can an entry define multiple relationships?
Revert: Can the revert commit itself be reverted?
Do "relationship footers" show up in the output or are they removed?

Hey @ap0llo,
my team and I are currently looking into generating our changelogs from conventional commits, using these kinds of relations to manage fixes and extensions to pre-released features. Your tool seems to have 90% of the features we need. I wanted to ask you if you were interested in some Pull Requests that would add the relationships you mention above (and a few more).
In addition, we are looking into changelog generation diffs, that means: what changes were made between the last version (last alpha, last beta, last full release), but not to a file but just as output to the console.
I'd really like to chat, so if you are interested, please let me know.

I'm glad to hear changelog is useful to you.

I wanted to ask you if you were interested in some Pull Requests that would add the relationships you mention above (and a few more).

Yes, I'd accept a PR that adds features along the lines of the idea outlined here.

In addition, we are looking into changelog generation diffs, that means: what changes were made between the last version (last alpha, last beta, last full release), but not to a file but just as output to the console.

I would also accept a console output mode, but we should discuss how that fits into the current mode of putting all log messages to the console.
I guess mixing the log with the change log output would make for a very confusing output.

Hey @ap0llo,
I tried to play a little with the code, but I find it really hard to determine where to put the changes. Would you be available for a brief chat?

Sorry for the late response. I'd prefer to keep the communication in GitHub Issues.
Let me give you a brief overview of the structure of the tool.
There are two core concepts: The Model and Tasks
Model
The  model represents the change log being generated.
All the data that should be rendered in the change log is represented here.

ApplicationChangeLog is the root object that holds the change log for one or more versions
SingleVersionChangeLog represents the changes for a single application version.  It mostly follows the data structure as defined by the Conventional Commits specification

The model is built up and extended/modified by Tasks.
Tasks
A Task is class (that implements IChangeLogTask) that represents one step in the change log generation process.
All tasks are executed in sequence and are passed the current model which they are can modify.
There are various tasks in the application, e.g.

LoadCommitsTask determines which commits to include in the change log
ParseCommitsTask parses the commit messages and converts them into change log entries
RenderTemplateTask takes the model and generates a Markdown file from it

Some tasks are optional and only executed when they are enabled in the configuration (e.g. loading of commit message overrides)
In general, every feature in the application maps to one or more tasks.
Each tasks can also declare when it needs to run in relation to other tasks.
You can see this for example in ParseCommitsTask:

It needs to run after LoadCommitsTask (otherwise there would not be any commits to parse)
It needs to run before RenderTemplateTask otherwise there would not be any entries to render.

The execution of the tasks (including the correct ordering) is implemented in ChangeLogPipeline.
(Side Note: When the --verbose command line switch is set, the log will contain a graph of all the tasks and their dependencies in the dot format)
To add a new task, you'll need to

Implement the task and optionally annotate it with [BeforeTask] and/or [AfterTask]
Register the task (and potential new dependencies) with the DI container (this is currently done in Program.cs)
Add the task to the pipeline to execute it  (this is currently done in Program.cs)

Other structures
The rest of the application mostly deals with cross-cutting concerns and abstractions:

The CommandLine namespace is for commandline parsing
The Configuration namespace models all the settings (it is built on top of Microsoft.Extensions.Configuration)
The ConventionalCommits namespace contains a parser for the Conventional Commits format
Filtering deals with filtering of the change log (which entries are included in the outpout, by default this is only fix and feat entries)
The Git namespace contains the abstraction of git data structures
Integrations contains the GitLab and GitHub specific features (e.g. linking to pull request references)
IO implements a virtual file system for the embedded resources (this is used for the templates)
Templates contains the implementation of the different supported output formats (templates are based Scriban)

In the case of the "Entry relationship" features, it will be necessary to change both the model (add the data structures to express the relationships) and a task to load the relationships and then remove/change entries according to the rules for a task relationship (it would probably make sense to split this up into multiple tasks).
I hope this helps, if you have any further questions, don't hesitate to ask.


Vulnerability fix for Kubernetes v0 and v1

Task name: Kubernetes v0 and v1
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected
[ ] node make.js build --task KubernetesV1
[ ] node make.js test --task KubernetesV1

/azp run


Bug/remove deprecated styling directory

Not really a bug, more just an unwanted post-merge artefact.

Ignore this, merging to wrong fork


vendor: downgrade hashicorp/go-version

As hashicorp/go-version introduced an unwanted behavior in the
go-version library we marked the revision number to be the previous
revision where the unwanted commit was introduced.
https://github.com/hashicorp/go-version/commit/fbe76cfa08cd0fa2695a1e8feea4687221ed2b32
Fixes: 24ed166d72a0 ("vendor: update hashicorp/go-version to latest stable"
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

Coverage increased (+0.02%) to 43.382% when pulling 7a4a8b67ff8289b2aca4ce6fbd0211b2f2e608df on pr/fix-hashicorp-version into 01010a9013063f1efb68e94136260be31237dcf3 on master.

Confirming that this fixes the issue


Github action that adds new issues to frontend project

We'd like all new issues to get added to the Frontend project for quick triage.
The project: https://github.com/orgs/vegaprotocol/projects/110/
example script for adding to project:
---
name: Auto Assign Issue to New Project

"on":
  issues:
    types: [opened]

jobs:
  add_issue:
    runs-on: ubuntu-latest
    steps:
      - name: Add Issue to New Core Project Board
        env:
          GITHUB_TOKEN: ${{ secrets.GH_NEW_CARD_TO_PROJECT }}
          PROJECT_ID: "https://github.com/orgs/vegaprotocol/projects/110/"
          ISSUE_ID: ${{ github.event.issue.node_id }}
        run: |
          gh api graphql -f query='
            mutation($project:ID!, $issue:ID!) {
              addProjectNextItem(input: {projectId: $project, contentId: $issue}) {
                projectNextItem {
                  id
                }
              }
            }' -f project=$PROJECT_ID -f issue=$ISSUE_ID --jq '.data.addProjectNextItem.projectNextItem.id'

The PROJECT_ID needs to be the node ID of the project for this query to run
To find this you can run
my_org="vegaprotocol"     my_num=110     gh api graphql -f query='       query($organization: String! $number: Int!){         organization(login: $organization){           projectNext(number: $number) {             id           }         }       }' -f organization=$my_org -F number=$my_num
The resulting Node_ID can then be added as a secret in github something like:
PROJECT_ID: ${{ secrets.FRONT_END_PROJECT_ID }}


need to differentiate between dev tests and production tests

dev tests are done in virtualenv and daemons use test ports and test storage locations
prod test run on regular install and use prodcution values of ports and stroage locations

closing because this is vague. probably need to improve documentation of how test and production work (which files are installed and used). but that too is not a concrete issue.


Change default branch to main

@vigji are you happy for me to change the default branch to main for consistency with the other BG tools (and GitHub default)?

Good for me yes!

Done


Sample Milia app isn't passing a tenant param?

I followed the sample app with Rails 4.2 and Ruby 2.1.5 and when I get to the signup page and submit I see the following stack trace in the error.
There is no tenant param being passed, and it's apparently required.  I made sure I didn't miss a step, it's a brand new database with nothing in it, it's a brand new app without any modifications to the step-by-step instructions other than what's mentioned above with Ruby and Rails.
Any advice?
11:24:29 web.1  | Processing by Milia::RegistrationsController#create as HTML
11:24:29 web.1  |   Parameters: {"utf8"=>"✓", "authenticity_token"=>"ReCQQiaS3UchSGJRxf1BjLzi84wjGUoq6VFdIzYWgWmD5NyYFXFtteqMoSLA0/0GNMLwRth3+qLguBv3b50Byw=="<EMAIL_ADDRESS>"password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]"}, "commit"=>"Sign up"}
11:24:29 web.1  | Completed 400 Bad Request in 2ms (ActiveRecord: 0.0ms)
11:24:29 web.1  |
11:24:29 web.1  | ActionController::ParameterMissing (param is missing or the value is empty: tenant):

Do you still have any questions regarding this issue? If you solved it feel free to share your insights. If not so please give it a try with the up to date Rails 5 branch https://github.com/jekuno/milia/tree/rails5-support.

You need to provide a view for organizational signups (which contain form fields for the new tenant). Have a look at an example in the README at https://github.com/jekuno/milia/blob/master/README_DETAILS.md#view-for-organizer-sign-ups.

Also check the instructions regarding the new sample app:
https://github.com/jekuno/milia#sample-app

Closing it for now. Feel free to add a comment if you still have questions.

I am having the same issue.
Processing by Milia::RegistrationsController#create as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"8e0asnLUyNFAXF6ZLO67h8QVkey054qbJEhyqqZmHvuNUYQpK/gIaHB+cx5DFztD/+puisVDsV0CXsOv3JM7xA=="<EMAIL_ADDRESS>"password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]"}, "commit"=>"Sign up"}
Completed 400 Bad Request in 18ms (ActiveRecord: 0.0ms)

ActionController::ParameterMissing - param is missing or the value is empty: tenant:

I tried with the rails5-support branch as well ... same issue.

Could you please have a look at https://github.com/jekuno/milia/issues#issuecomment-318091135 and see whether this helps?

this link doesn't lead to anything

Ok, here's the correct one: https://github.com/jekuno/milia/issues/76#issuecomment-318091135

I am having the same issue.
param is missing or the value is empty: tenant
require
actionpack (5.1.4) lib/action_controller/metal/strong_parameters.rb
return key.map { |k| require(k) } if key.is_a?(Array)
value = self[key]
if value.present? || value == false
value
else
raise ParameterMissing.new(key)
end
end
# Alias of #require.
alias :required :require

sign_up_params_tenant
() usr/local/rvm/gems/ruby-2.4.1/bundler/gems/milia-05b72dd72bfa/app/controllers/registrations_controller.rb
protected
def sign_up_params_tenant()
params.require(:tenant).permit( ::Milia.whitelist_tenant_params )
end
def sign_up_params_user()
This is the solution of the error.
Branch I used
ruby '2.4.1'
gem 'rails', '~> 5.1.4'
gem 'puma', '~> 3.7'
gem 'sass-rails', '~> 5.0'
gem 'uglifier', '>= 1.3.0'
gem 'coffee-rails', '~> 4.2'
gem 'turbolinks', '~> 5'
gem 'jbuilder', '~> 2.5'
gem 'milia', github: 'jekuno/milia', branch: 'issue#76'


update physlite Dockerfile

Made the following modifications:

use newer base image pangeo/base-notebook:2021.07.06
remove awkard array patch (update to newer version instead)
add a few more packages from scikit-hep
update physlite-experiments code

From my last tests it seems to work using the same image both for jupyterhub and the dask cluster

tagging @fbarreir


Add description of client-registration properties

We can add client-registration configuration properties in the Configuration section.
Basically, it should be an explanation of those properties.

Related to IAM issue 727.

PR https://github.com/indigo-iam/iam-website/pull/122


when we are skipping a student then we are not skipping all valdiations at cell level

this issue has been fixed


DNM - Testing new extracted-crc job with ci-bootstrap

As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running
[ ] Appropriate documentation exists and/or is up-to-date:

[ ] README in the role
[ ] Content of the docs/source is reflecting the changes

/hold

recheck

recheck

recheck

recheck

recheck

recheck
lets run again

recheck


[Linter panic] failing to parse odd f-string f"{x, y=}"

x = 1
y = 2
z = f"{x, y=}"  # This is a weird but valid f-string, which crashes ruff
print(z)

% python repro.py
x, y=(1, 2)

% ruff --version
ruff 0.0.285

% ruff --isolated repro.py
warning: Linting panicked repro.py:

panicked at 'byte index<PHONE_NUMBER>3709551615 is out of bounds of `x, y=`', crates/ruff_python_parser/src/string.rs:321:30
Backtrace:    0: _rust_eh_personality
   1: _main
   2: _rust_eh_personality
   3: _rust_eh_personality
   4: _rust_eh_personality
   5: _rust_eh_personality
   6: __rjem_je_witnesses_cleanup
   7: _main
   8: __rjem_je_witnesses_cleanup
   9: _main
  10: _main
  11: _main
  12: _main
  13: _main
  14: _main
  15: _main
  16: _main
  17: _main
  18: _main
  19: _main
  20: _main
  21: __mh_execute_header
  22: __mh_execute_header
  23: _main

Thanks!

I spent a few minutes in debugging and the problem is two fold:

The expression in the mentioned example is a tuple without parentheses
We add implicit parentheses to the expression before parsing it
https://github.com/astral-sh/ruff/blob/205d2348560671d07939a59c8ab89eecc7992421/crates/ruff_python_parser/src/string.rs#L550
We subtract 1 here which I think is because of these implicit parentheses (@MichaReiser correct me if I'm wrong here)
https://github.com/astral-sh/ruff/blob/205d2348560671d07939a59c8ab89eecc7992421/crates/ruff_python_parser/src/string.rs#L320-L322

Now, considering the extraction of leading and trailing values in (3), for f"{x, y=}", the start location for parsing is 2 ({), but we add an implicit parentheses which means the parser sees this as (x, y) and this means the parsed node also starts at 2 which leads to (2 - 2 - 1).
If we add the parentheses ourselves i.e., f"{(x, y)=}" the parser sees as ((x, y)) and the parsed node starts from the second character which leads to (3 - 2 - 1).

This might require re-working the way DebugText is extracted because when using something like f"{   x, y  =   }", the expression is (   x, y  ) which eats up the whitespaces. We can't really use saturating_sub because then it eats up the = sign.
We'll have to extract the whitespace surrounding the expression and not consider them part of the parsed expression. But, this might not be necessary when the new 3.12 f-string parser is complete because we won't be re-parsing the expression from string, we'd do that from the tokens.

how far away is the new parser? are we ok to just wait? if not maybe we can try to just strip leading whitespace and not add parentheses?

Hey, sorry for not replying soon, I somehow missed this in the notifications. You can track the parser progress at https://github.com/astral-sh/ruff/pull/7041 and that fixes this issue. I think we're ok to wait as otherwise the fix would become redundant.

Even after merging #7041, I have multiple crashes with different rules
panicked at 'attempt to subtract with overflow', crates/ruff_python_parser/src/string.rs:321:43

B020
def log_zero_test_():
    print(f'{train_loss, train_acc=}')

Hey, it's not yet merged in main, it's only merged in the dhruv/pep-701 branch. Once #7376 is merged, then it'll be fixed.


feat: fix denom ibc in staking assets dropdown

issue is caused by no existing channels between stride and carbon. fix is to filter out ibc token types from staking assets dropdown menu

before:

after:


Update to new IKVM 8.2+ version

There is a new preview of IKVM, which supports net461+ and netcoreapp3.1+, it's working fine for us.

https://github.com/ikvm-revived/ikvm/releases
https://github.com/visualon/featureide.net

@viceice
This is NOT FEASIBLE for this Project purpose !!!!
This e.g .NET6 support IKVM does not support AWT

headless AWT
UI

i don't need at or UI, that will be build with dotnet or any web framework 🙃

I'm working on this now as well as .NET 6 support.
Currently working through the workaround for this error https://github.com/ikvmnet/ikvm/issues/394
cc @wasabii

This is nearly complete, as well as .NET 6 support! Coming very soon.

This is now complete as of latest master, and once I get a few more things in there I'll prepare a proper 3.0 release.


Debugger: variable value isn't refeshed while it has been changed

Environment data
dotnet --info output:
VS Code version:1.3.1
C# Extension version:1.3.0
Steps to reproduce

Open sample project in VSCode
Set a BP at line 30 in Program.cs
F5
Add i in Watch
Add i=10 in Watch

Expected  behavior
The value of i changes to be 10 in Watch and Locals.
Actual behavior
The value of i still is 5.
##Attachements
ScreenShot
MIEngine Log
Repro Project

This is a bug/non-feature with the VS Code UI. See https://github.com/Microsoft/vscode/issues/2399.


Integrate Chimoney with an International Event Ticketing Platform i.e EventBrite

Integrate Chimoney with an event platform such as eventbrite and use Chimoney for organizer payouts.
Idea Flow:

[ ] Implement 'Payout to Chimoney Wallet' for event organizer payments.
[ ] Provide event listings with multiple currency support.

I would like to work on this. Kindly assign to me.

Sure, go ahead.

Hello @phyleria I'm sorry I won't be working on this issue anymore. Thank you.

No problem @DevTomilola-OS

@phyleria assign me on this , now time is very less for hacktoberfest

Ok, go ahead


Bad error message when referencing a type outside the current crate in a struct definition

pub struct String {
    inner: std::string::String,
}

thread 'rustc' panicked at 'no entry found for key', vir/src/recursive_types.rs:25:21

We should tell the user that they cannot use types outside the crate for this case too.

this was fixed in a31fd7eb748ffb074f7bcb99f5c3d3bf25b9d9b3


Routing with WasmEdge SSR vs regular SSR

It would be great to take a look at how WasmEdge SSR can implement routing.
The standard way to route in React is to install the npm install react-router-dom package and then implement in the App.js file, as shown below.
import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';

Below is the full App.js file which uses routing and this is where the page on the client's browser stops responding (when using WasmEdge SSR)
import React from 'react';
import Navbar from './Navbar';
import Home from './Home';
import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';

function App() {
  return (
    <Router>

        <Navbar />

          <Switch>
            <Route path="/">
              <Home />
            </Route>
          </Switch>

    </Router>
  );
}

export default App;

This is the client's browser when running routing via WasmEdge (FYI there seems to be no messages in the terminal where the wasmedge command is run and also no messages in the browser's console)

If the same source is run using regular SSR via the npm start command, the page renders correctly at localhost:3000 in the client's browser and no messages or errors etc. are present.

function App() {
  return (

123
    <Router>

        <Navbar />

          <Switch>
            <Route path="/">
              <Home />
            </Route>
          </Switch>

    </Router>

  );
}

@tpmccallum You can wrap the <Router> with a
 and add some text to it.
Then you will find that when running using npm start, the source code of the page will not include the 123.
It means npm start is not rendering the page on the server-side.
If you want to test SSR within NodeJs, you should write another server, please refer to https://www.digitalocean.com/community/tutorials/react-server-side-rendering


⚠ API Next - first chapter has degraded performance

In fe02b71, API Next - first chapter (https://h-edu.cz/content.api/book/book-a?includeChapterContentParts) experienced degraded performance:

HTTP code: 200
Response time: 7727 ms

Resolved: API Next - first chapter performance has improved in 85889b3 after 15 minutes.


A fix for 'scrape.py: IndexError: list index out of range #239' + t2 and EBSOptimized parsing

Checked it out and all looks good. Thank you!


Linear Search in Java

Related Issue

Info about the related issue

Closes: #29
Describe the changes you've made
Write Algorithm For Linear Search  in Java language
Type of change
What sort of change have you made:

[x] Make a new file LinearSearch.java
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Tested the code on my PC
Tested the code on online IDE's also

Sorry for the delay. Actually, There was something wrong with my git-bash. When I tried to push this code it was showing error.
but now it's working fine


multistrem_lpr

Hi,
Generally recording to the file is necessarary later debugging the results.
How we can add filesink for multistream_lpr ?

@changing the fpsdisplay to . matroskamux ! filesink location=test.mp4 worked..
solved


zsh: command not found: gulp

Hi Guys ...
can someone please help me? I installed gulp (global) (npm install -g gulp) as described in the Getting Started section. then I created the file gulpfile.js. When I type in the terminal gulp I just get zsh: command not found: gulp.
when I type in terminal echo $path I get:
/ Usr / bin / bin / usr / sbin / sbin / usr / local / bin / Users / leonardo / .rvm / bin
everything else works except Gulp.
My system is OSX.10.9 mavericks.
thanks for any help

I came here googling for solutions to a similar issue on Ubuntu 14.04, with zsh. I had switched npms global prefix to ~/npm and added this to path "~/npm/bin". This gave me command not gound: gulp.
Solution was adding: "$HOME/npm/bin" instead
Probably blatantly obvious to most, but thought I'd mention it here on the #1 hit in my search

Also, after adding $HOME/npm/bin to your path, you probably need to re-install with npm install -g gulp

I had to use $HOME/.npm-global/bin instead. I presume it has changed because of reasons 🤷♂

You should always use npm prefix -g to find where npm is installing your packages globally, in case they update the location.


Small fixes...

Because the last time the change was so big, some small fix cannot be applied. So I make this branch just for it.

For Ruby 1.9.2, Net::IMAP::NoResponseError#new take a Net::IMAP::TaggedResponse object as argument, the error description will be put in a Net::IMAP::ResponseText. A NoMethodError would be raised for the old code.

For me conn.list('[Gmail]/', '%') will return nil, then an error would be raised since we cannot + nil.

This issue was moved to gmailgem/gmail#21


Increase operator CPU and mem allowance

The default CPU and memory limit were low and causing the operator to be OOMKilled

/lgtm


Adding sample for obfuscated-with-advobfuscator.yml

Sample file for https://github.com/mandiant/capa-rules/pull/526

thank you!


Trying to flash Feit SYSW-BR30RGBAGT2 -- Doesn't get to intermediate stage

Hey all --
Just picked up some of these bulbs at Costco. They are the SYW-BR30RGBAGT2 / Feit BPBR30/RGBw/AG/2(C) with date code 17-20-19S 11
I am able to get the bulb to connect to the wifi network, but it doesn't seem to to take the intermediate flash. Web doesn't report any traffic, psk doesn't report anything either, just see the device connected in the wifi log.
Any assistance would be appreciated. Took one of them apart and the actual module is the WB3L
(https://docs.tuya.com/en/iot/device-development/module/wifibt-dual-mode-module/wb3l-module-datasheet?id=K9duiggw2v8sp)

@cmoski were you able to get anywhere with flashing these feit br30 bulbs?

@sacdroid Hey! Sorry I didn't see your reply until now.
I gave up on flashing these bulbs and return them for a different model, sadly. I still have one if you have any ideas though :)

Looks related to #814

@bani6809 is probably right. Closing as the issue author has come to their own resolution.


[WIP - Experimental] Change ProduceAsync methods: use Produce record and reduce API

Look to change the api following this view:

Producer is the entrypoint to librdkafka, and should be used in two cases: low level producing (memory management with ArraySegement, etc.) and be a single producer instance to call GetSerializingProducer when the app use multiple topic with multiple types. If we use this, we have to know what we do, so no need to overload.
Producer<TKey, TValue> should be used when only one typed producer is needed
Reduce at maximum the API regarding produce.

Note this will be breaking API. In future, if librdkafka add parameter to producev, to have backward assembly compatibility we will have to add overload to Producer.Produce and add the field on ProducerRecord.
Serialized producer:
Change the api regarding ProduceAsync: only two overload, the simple one (topic, key, value) and one with a ProducerRecord<TKey, TValue> struct
Change the datetime to timestamp. DateTime still usable in ProducerRecord
I also wonder about renaming the ProduceAsync(..., IDeliveryHandler) to Produce. Async postfix whould be for awaitable function - here we await a parameter so not sure about this...
Also, it might worth testing adding all overloads on Producer and calling the corresponding rd_kafka_producev (without the extra parameter, only the ones needed), same in SafeKafkaHandle (all possible overload and call to corresponding binding with variable args)
If not accepted, some thing are still worth taking. Didn't do atomic commits, my bad. Directly branched from #113

lots of great stuff here @treziac.
If you can you break this PR up a bit and submit a smaller number of more focussed PRs that would mean I get to review quicker (i know this is more work at your end...). I will still be happy to review this big PR, but it'll take me longer to get to + get the changes merged.

Closing in favor of #118 and #113. Will post an other PR for the long/DateTime type once 118 is merged or refused.


BUG: Non array values in FilterPills lead to failed render

We've the same issue in PredefinedFilters component here.

We've the same issue in PredefinedFilters component here.

directly done


Performance measure using hash program

Hi，i want to measure nyuzi performance when config to more than 1 core（4 thread per core），
when i using the hash benchmark program and config nyuzi to 8 core，the output “cycles per hash” is my higher than single core, why?
And if i want to measure multicore performance, what should i do？
thanks.

Are you running this in Verilog simulation? Could you attach the command line you used and perhaps the diffs of what you changed to increase the core count, just so I can be sure I understand your configuration correctly? Thanks!

Yes, I'm using verilog simulation.
I just change the NUM_CORES to 8, no other changes,
and run ./run_vcs in benchmarks/hash/ folder

Got it. It's been a while since I worked on this project, so I need to refresh my memory, but I'm afraid I can't think of a reason this should be off the top of my head.  I'll need to look into this.

Maybe a quick experiment: what happens with 2 cores? What are the corresponding cycle counts in each case (like is it close to a clean integer multiple)?
My first question would be whether this is some artifact of the test configuration that is not synchronizing correctly (and thus misreporting the count), or if you are actually running into some kind of memory saturation issue where the performance is decreasing because of cache thrashing.

I tried 1, 2, 4, and 8, but the performance dropped once.
Is it related to this problem? I don’t know the reason: assert failed during simulation: refesh_delay should < MAX_REFESH_INTERNAL

Can you clarify what you mean by "performance dropped once"? (One time? Once you were above a certain number of cores?)
The refresh_delay assertion is probably not related (but kind of interesting, as I haven't seen that one).

Sorry, performance dropped once means The more cores used, the greater the performance degradation(cycles per hash is high)

Oops, I see the problem :)
https://github.com/jbush001/NyuziProcessor/blob/a5efd627ae651f7ea2addc0cb9b18f88bb3f9f4c/software/benchmarks/hash/hash.cpp#L183
The total number of hashes performed is hard coded here (256):
printf("%g cycles per hash\n", (float) endTime / 256);

Because there are 16 vector lanes, four threads, and each thread does four hashes = 16 * 4 * 4 = 256. When you increase the number of cores, the total hashes that are being done increases, but this is still assuming it is fixed. The latency for each thread is going to increase because there's more memory contention, but this calculation is not accounting for the fact that the throughput has increased.
One each fix might be to add another global variable gTotalThreads and do a __sync_fetch_and_add at the top:
    __sync_fetch_and_add(&gActiveThreadCount, 1);
+    __sync_fetch_and_add(&gTotalThreads, 1);

Then use that to compute the total number of operations done:
 printf("%g cycles per hash\n", (float) endTime / (4 * gTotalThreads * 16));

(looking at this now, it should probably use constant variables for the number of iterations each thread takes and number of vector lanes for clarity instead of hard coding the numbers). I hope that helps.


Error when fetching info from certain stocks

For certain stocks, for instance Exxon Mobil (XOM) I can retrieve the dividends correctly from my Ticker object. However, basic information about the company (.info) does not work because of this error:
12:23:09 PM web.1 |  self._institutional_holders = holders[1]
12:23:09 PM web.1 |  IndexError: list index out of range

I see there is already an issue open about it at #268 so I will close this one. Seems like a pretty important bug that should be fixed asap since there is no way to get info if there are no institutional holders.


Fix incorrect comment for Index::create_in_dir

The original comment says, it'll destroy existing meta file but the implementation is returning error when meta file exists.
https://github.com/tantivy-search/tantivy/blob/dd81e38e53343b08bea3315c8b0ea626a2cd15fc/src/core/index.rs#L125-L129

Thank you!


Implement Set

Make Set only ever immutable because this is anyway much more conistent with the mathematical equivalent.
Set should also be Iterable so that it can be used with methods asList, asArray, and the HoFs.

Example code
let s be new Set<of String>()
let b be {1, 2, 3}.asSet()
print s.length()
print s.contains("apple")
let s2 be s.add("apple")
let s2, item be s.remove("apple")
let s3 be s.union(b) // etc

Assigning to Stef
I've started this in new branch Set793
Three things, please:

The new test is not currently recognising ElanSet - and I can't see what I have missed out that I did for e.g. Queue.  Also it is causing 10 existing test to fail, and not clear why.

Not clear how I should specify the Ealn type signature for the methods that return a set. Currently:

@elanFunction(FunctionOptions.pure, ElanClass(ElanSet))
But does ElanSet need to be qualified with its generic type?

I would like to have a name alias, so that the ElanSet is just Set in Elan source

Once this is working, please assign back to me for more methods & more tests

Temporarily assigned to Stef to find out how to make union and other new methods on the (JS) Set available.

Compiling with ESNext allows latest features. This means care will have to be taken that any new feature works in the desired browsers.


Add Java arguments to Vert.x applications deployed using FMP

Despite the misnamed branch, this resolves https://issues.jboss.org/browse/RHOARDOC-1439
@spisiakm @cescoffier
Do we need to provide a rationale for why a developer should add these Java options for FMP deployments?

Can one of the admins verify this patch?

[test]

Thanks for the comments. These are resolved.

Updated yams example to remove JAVA_ARGS and updated the module to remove mention of JAVA_ARGS.


Rewrite converter script

The converter script is hacky and pretty brittle. In addition to that it has an implicit dependency on FFMPEG.
This could be solved in a nicer and more reliable way. Also all needed dependencies could be specified in package.json so the user does not need to read any further instructions on how to get going.

A PR for this would be more than welcome.


Running jeelizPupillometry on a local host

Hello,
My group has put together the pupillometry setup as described in the readme. We would like to run experiments locally, and so we would like to first run the demo locally. Two problems have come up:

Initially, running the experiment locally was causing an error because it does not use the right protocol:

jeelizPupillometry.js:19 Access to XMLHttpRequest at 'file:///Users/stobin/Downloads/jeelizPupillometry-master/dist/jeelizPupillometryNNC.json' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https.
sa | @ | jeelizPupillometry.js:19
So I modified the file access options on launching the browser, which appears to have resolved that error:

open /Applications/Google\ Chrome.app --args --allow-file-access-from-files

The second problem is that the video stream does not display in the Debug view, although the camera is active and is possible to use with other applications. This problem is proving more challenging to resolve, so I'd appreciate your input on it. Initially I'd assumed it was associated with the first problem, but those errors don't show up any more. However, when I run the demos remotely (those hosted on jeeliz.com) there's no problem with camera access and the experiment proceeds as expected.

Many thanks in advance.

Hi,
You need to run a local HTTPS server to serve the content. Otherwise there will be CORS errors and problems with camera access (i.e. you need to access to the content through https://<IP_ADDRESS>//index.html). See https://github.com/jeeliz/jeelizPupillometry#hosting
The lightweight Python https server included in https://github.com/jeeliz/jeelizFaceFilter, httpsServer.py (https://github.com/jeeliz/jeelizFaceFilter/blob/master/httpsServer.py) should do the job.
Put this script at the root of this repository, then start it as explained here: https://github.com/jeeliz/jeelizFaceFilter#the-development-server
To make loading faster, the webcam video stream and the neural network model are loaded asynchronously, that's why the webcam LED is active. But since the neural network model cannot be loaded because of the CORS problem the application does not start, and so the debug view is not displayed.