forking

Hi cloning this repo as is (https://github.com/Minres/TGC-VP.git) works fine as intended though,
however, if we try to fork this repo (e.g. like in VP-Vibes repo) and then try to clone
$ git clone --recursive -b develop <fork-repo-url>

then the clone process breaks at some point asking for username/password access for https://git.minres.com which fails for non Minres access. Would be nice to be able to fork this repo and able to contribute externally
i provide log for clone process in following:
$ git clone --recursive https://github.com/uzleosharif/TGC-VP.git
Cloning into 'TGC-VP'...
remote: Enumerating objects: 132, done.
remote: Counting objects: 100% (132/132), done.
remote: Compressing objects: 100% (113/113), done.
remote: Total 132 (delta 14), reused 129 (delta 11), pack-reused 0
Receiving objects: 100% (132/132), 74.11 KiB | 4.63 MiB/s, done.
Resolving deltas: 100% (14/14), done.
Submodule 'scc' (https://github.com/VP-Vibes/SystemC-Components.git) registered for path 'scc'
Submodule 'tgc-iss/dbt-rise-core' (https://github.com/Minres/DBT-RISE-Core.git) registered for path 'tgc-iss/dbt-rise-core'
Submodule 'tgc-iss/dbt-rise-tgc' (https://git.minres.com/DBT-RISE/DBT-RISE-TGC.git) registered for path 'tgc-iss/dbt-rise-tgc'
Submodule 'vpvper' (https://github.com/VP-Vibes/VPV-Peripherals.git) registered for path 'vpvper'
Cloning into '/tmp/TGC-VP/scc'...
remote: Enumerating objects: 9943, done.
remote: Counting objects: 100% (553/553), done.
remote: Compressing objects: 100% (351/351), done.
remote: Total 9943 (delta 308), reused 376 (delta 189), pack-reused 9390
Receiving objects: 100% (9943/9943), 10.94 MiB | 11.60 MiB/s, done.
Resolving deltas: 100% (6517/6517), done.
Cloning into '/tmp/TGC-VP/tgc-iss/dbt-rise-core'...
remote: Enumerating objects: 922, done.
remote: Counting objects: 100% (359/359), done.
remote: Compressing objects: 100% (159/159), done.
remote: Total 922 (delta 202), reused 324 (delta 185), pack-reused 563
Receiving objects: 100% (922/922), 265.16 KiB | 3.01 MiB/s, done.
Resolving deltas: 100% (594/594), done.
Cloning into '/tmp/TGC-VP/tgc-iss/dbt-rise-tgc'...
remote: Enumerating objects: 3958, done.
remote: Counting objects: 100% (3958/3958), done.
remote: Compressing objects: 100% (1978/1978), done.
remote: Total 3958 (delta 2590), reused 2599 (delta 1809), pack-reused 0
Receiving objects: 100% (3958/3958), 2.87 MiB | 8.81 MiB/s, done.
Resolving deltas: 100% (2590/2590), done.
Cloning into '/tmp/TGC-VP/vpvper'...
remote: Enumerating objects: 517, done.
remote: Counting objects: 100% (517/517), done.
remote: Compressing objects: 100% (407/407), done.
remote: Total 517 (delta 369), reused 246 (delta 108), pack-reused 0
Receiving objects: 100% (517/517), 174.72 KiB | 4.99 MiB/s, done.
Resolving deltas: 100% (369/369), done.
Submodule path 'scc': checked out '1b3e1b3efd50ce7114a20c8da9245a7ee1866876'
Submodule 'axi_chi' (https://github.com/Arteris-IP/tlm2-interfaces.git) registered for path 'scc/third_party/axi_chi'
Cloning into '/tmp/TGC-VP/scc/third_party/axi_chi'...
remote: Enumerating objects: 1044, done.
remote: Counting objects: 100% (1044/1044), done.
remote: Compressing objects: 100% (745/745), done.
remote: Total 1044 (delta 654), reused 669 (delta 289), pack-reused 0
Receiving objects: 100% (1044/1044), 1.90 MiB | 11.76 MiB/s, done.
Resolving deltas: 100% (654/654), done.
Submodule path 'scc/third_party/axi_chi': checked out '50689e297706fd3ef7e0f93d7c16afe237b5a684'
Submodule path 'tgc-iss/dbt-rise-core': checked out 'fd1a504ac63b330f6214710e9259637c3e9ef524'
Submodule path 'tgc-iss/dbt-rise-tgc': checked out '09b01af3fa117e07c665f29b77b3771547771ac2'
Submodule 'gen_input/CoreDSL-Instruction-Set-Description' (https://git.minres.com/DBT-RISE/CoreDSL-Instruction-Set-Description.git) registered for path 'tgc-iss/dbt-rise-tgc/gen_input/CoreDSL-Instruction-Set-Description'
Cloning into '/tmp/TGC-VP/tgc-iss/dbt-rise-tgc/gen_input/CoreDSL-Instruction-Set-Description'...
Username for 'https://git.minres.com': uzleosharif
Password for<EMAIL_ADDRESS>warning: Clone succeeded, but checkout failed.

The problem is that you try to clone the main branch which was not up-to-date with the develop branch and pointed to an obsolete repo.
I fixed that with #9 so please update your fork.

super thanks..now works fine


Allow !m to update karma

It would be nice if a !m also bumps that user's karma!
If this seems like a nice feature I might try to submit a PR.

You'd have to assume `hubot-karma


[WIP] Add support for IPv6 literals in microsoft hostnames.

Please merge after #2063 since this includes a commit from that PR.

Merged #2063 .  Is this good to go?

Good to go @Fryguy


Zip task is missing?

Bug Report
I'm getting an error while trying to run the npm run zip task. It looks like the task is not defined at all in the gulpfile.babel.js. Am I missing something here?
Expected Behavior

Based on the documentation and config file it should create a theme.zip file.
Actual Behavior

Gulp / Node throws an error
Steps to Reproduce

Just try to run npm run zip or gulp zip

node -v: 14.12.0
npm -v: 6.14.8
yarn --version (if you use Yarn): 1.22.5

Then, specify:

Operating system: macOS 11.0.1

Possible Solution

In gulpfile.babel.js import the gulp-zip:
const zip = require('gulp-zip');

Add a task that does the zip:
gulp.task('zip', () => {
	const src = config.zipIncludeGlob.concat(config.zipIgnoreGlob);
	return gulp
		.src(src)
		.pipe(zip(config.zipName, {}))
		.pipe(gulp.dest(config.zipDestination));
});

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

I can submit a PR if you'd like me to :)

Whaaaat? How the heck did I miss that. Where did the code go? I remember writing the function but it's not there lol. Thanks for the report. I just codded it again.
🔗 https://github.com/ahmadawais/WPGulp/releases/tag/3.1.0
🔗 https://www.npmjs.com/package/wpgulp


Add a title to explorer actions

Currently the actions on the explorer menu are short verbs and do not actually describe what the buttons do. Adding a title to these should assist in letting the user know what each button does. Currently one would expect the 'Draft' button would create a draft, having a title on it will explain to the user in a more verbose way what the button actually does (In this case, preview the draft).
Currently we have a button with the label 'Add a child page'  which describes what the button does, while we also have  'Edit', 'Draft' etc which are short verbs. I'm not sure whether we should be using short verbs as labels, or whether the labels should describe what they do, or a mixture of both. Perhaps we could remove the 'Add child page' in favour of the already existing plus icon to the right of the page status.
cc @davecranwell @mazil

Merged in c35c1f360a4800194bfdcd383e3c370bdb8b8cc6 + parents - thanks!


Requests to websocket handler aren't logged

Result of websocket connection: no log line
Expected: log line
I imagine this is because github.com/gorilla/websocket is handling connections.
https://gist.github.com/61ba42e4c1cb7c82b25a - access.log is the result of running caddy and then loading root in browser

We knew about this in https://github.com/mholt/caddy/issues/133 but I justified it thinking that they aren't HTTP requests so we don't need to log it... but off-hand, I don't see why we shouldn't be able to log those.

Okay, actually, they are logged, but only once the websocket connection closes

I updated the test case to close the connection https://gist.github.com/edrex/fb947c6fc6460c1629b4
I was hoping for logging of websocket lifecycle events (connection opened, closed) since they are usually long-lived.

That'd be cool; if you know a way to do that from the log middleware, please feel free to suggest it here and then submit a PR if it's sound. What would you expect the log line to look like? (Right now we default to common log format.)

Also, you can customize the log format and use the {latency} placeholder to see how long the connection was open.
Although maybe I should rename that placeholder to {duration} instead.

Interesting.. yeah, it doesn't seem like there is any prior art for logging websocket connections using common log format. Websockets are kind of an odd duck.
I like your idea about using {latency}/{duration}.
I guess you could also do logging within the socket handler, although muxing the log lines from all the processes gets really complicated.


Added tests for OpenFunctionSinkConnector

Fixes #4548
Motivation
OpenFunctionSinkConnector did not have any test cases.
Modifications
A new class called OpenFunctionSinkConnectorTest was added with two test cases.
Documentation

Does this pull request introduce a new feature? (no)

@pandaapo please review

yeah missed that. WIll do it ASAP

@Pil0tXia Can you please review?


Revert siwa

Description of changes

Reverting past two SIWA commits
Issue #, if available

Description of how you validated changes
yarn test
Checklist

[ x] PR description included
[ x] yarn test passes
[ x] Tests are changed or added
[ x] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #7690 (25a9e62) into master (0c0adfb) will increase coverage by 0.09%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #7690      +/-   ##
==========================================
+ Coverage   51.79%   51.89%   +0.09%
==========================================
  Files         547      546       -1
  Lines       27626    27558      -68
  Branches     5342     5332      -10
==========================================
- Hits        14308    14300       -8
+ Misses      12326    12275      -51
+ Partials      992      983       -9

Impacted Files
Coverage Δ

...ider-utils/awscloudformation/assets/string-maps.js
85.45% <ø> (ø)

.../src/provider-utils/awscloudformation/constants.ts
100.00% <ø> (ø)

...auth/src/provider-utils/awscloudformation/index.js
4.73% <0.00%> (+0.39%)
:arrow_up:

...udformation/service-walkthroughs/auth-questions.js
3.00% <0.00%> (-0.03%)
:arrow_down:

...gory-auth/src/provider-utils/supported-services.ts
100.00% <ø> (ø)

...c/provider-utils/awscloudformation/import/index.ts
5.08% <50.00%> (+0.07%)
:arrow_up:

...s/awscloudformation/utils/auth-request-adaptors.ts
43.00% <100.00%> (+2.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0adfb...25a9e62. Read the comment docs.

This is just in case CLI needs to be released before Monday. Otherwise SIWA is still good to go for a Monday GA release.


Comments

Project Documentation / File Commenting
Synopsis
I was thinking about the documenting part of this project, and thought it might be useful to have a reference of all the functions and their calls on the project wiki for our and others' reference.
I searched online for any converters that would convert bash comments into GitHub markdown, and only found one - shdoc. In my opinion, it is lacking a lot, even with the PR that is on the project. So, I have spent the last 3 days rewriting it from scratch.
I have named my version sh2md. Can you guys please take a look at it, and give me comments, as I think it would be useful to start commenting the files and functions in this way. As I have written the converter myself, it will be easy to add / change as required for the project.
I have included two files in this PR that have been commented in this way - powerlevel9k.zsh-theme and functions/colors.zsh. I have attached the output to the bottom of this post for you to preview as well.
Requirements
The converter uses Gnu AWK. As this is available on most systems (and can be installed on Mac using Homebrew), I think it would be available to the majority of the contributors to use to create documentation for their files.
TODO

[ ] discuss the requirements for powerlevel9k
[ ] discuss the styles and tags we would like to use
[ ] add a function to convert multiple line comments into paragraphs
[ ] add more section tags as required

Examples
File level comment block
################################################################
# @title powerlevel9k Theme
# @source https://github.com/bhilburn/powerlevel9k
#
# @authors
#   Ben Hilburn
#   Dominic Ritter
#
# @info
# This theme was inspired by [agnoster's Theme](https://gist.github.com/3712874)
#
# For basic documentation, please refer to the README.md in the top-level
# directory. For more detailed documentation, refer to the
# [project wiki](https://github.com/bhilburn/powerlevel9k/wiki), hosted
# on Github.
#
# There are a lot of easy ways you can customize your prompt segments and
# theming with simple variables defined in your `~/.zshrc`.
################################################################

powerlevel9k Theme
Source(s)
https://github.com/bhilburn/powerlevel9k
Author(s)

Ben Hilburn
Dominic Ritter

File Description
This theme was inspired by agnoster's Theme
For basic documentation, please refer to the README.md in the top-level
directory. For more detailed documentation, refer to the
_ project wiki, hosted_
on Github.
There are a lot of easy ways you can customize your prompt segments and
theming with simple variables defined in your ~/.zshrc.

Function comment blocks
#!/usr/bin/env zsh
# vim:ft=zsh ts=2 sw=2 sts=2 et fenc=utf-8
################################################################
# @title Color functions
# @source https://github.com/bhilburn/powerlevel9k
# @info
# This file holds some color-functions for the powerlevel9k-ZSH-theme
##

################################################################
# @description
# Get numerical color codes. That way we translate ANSI codes ZSH-Style color codes.
#
# @example
#   getColorCode 'black'
#
# @args
#   $1 string|number If string, ANSI color code.
#
# @returns
#   Zsh style color code.
##
function getColorCode() {
  # ...
}

################################################################
# @description
# Check if two colors are equal, even if one is specified as ANSI code.
#
# @examples isSameColor 'black' 0
#   isSameColor 'white' 0
#
# @args
#   $1 string|number First color.
#   $2 string|number Second color.
#
# @returns
#   true if they are the same color.
#   false if they are different colors.
#
# @see
#   getColorCode
##
function isSameColor() {
  # ...
}

Color functions
Source(s)
https://github.com/bhilburn/powerlevel9k
File Description
This file holds some color-functions for the powerlevel9k-ZSH-theme
Table of Contents

getColorCode()
isSameColor()

getColorCode()
Get numerical color codes. That way we translate ANSI codes ZSH-Style color codes.
Example
getColorCode 'black'

Arguments

$1 (string|number) If string, ANSI color code.

Returns

Zsh style color code.

isSameColor()
Check if two colors are equal, even if one is specified as ANSI code.
Example
isSameColor 'black' 0
isSameColor 'white' 0

Arguments

$1 (string|number) First color.
$2 (string|number) Second color.

Returns

true if they are the same color.
false if they are different colors.

See also

getColorCode

I changed the name of the project to sh2md as there are already a few projects name shelldoc. Ignore the conflicts, as this is about the documentation, not the files.

@onaforeignshore - Great idea! More documentation would be excellent, and auto-generating it from the code comments, a la Doxygen, is a great way to build out developer documentation.
It's really hard to see what you've done, though, because this PR is built on top of @dritter's async work, so looking at the diff not only shows your changes but all of the changes @dritter has made over the course of months of development. It also means that it will be impossible to merge this PR until @dritter's work is done, which is obviously not ideal :)
What would be best is if you could rebase this branch onto next. It looks like there are four commits that are part of this work:

Assuming these commits are in some branch, call it docs, you can rebase it onto next by doing:
$ git checkout docs
$ git rebase next

If these commits are not in their own branch, then we can move them over to one by cherry-picking. Let me know if you need help, here!

I couldn't rebase, so I created a branch off next called docs

Closed due to PR against Next


Debugger Hangs

[Interpreter]
When you go to debug a mips file the debugger never gets the go ahead to start debugging from the interpreter. I suspect this has to do with the issues surrounding the code in
https://github.com/nbbeeken/dashmips/blob/master/dashmips/debuggerserver.py
With the asyncio python code, it is the same place where the interpreter fails to exit correctly since the event loop never gets shutdown. I went with the async code cus its cool, if you find it might be easier to just switch to the synchronous api go for it, async in python isn't as friendly as it is in Javascript.
[Debugger]
It could be that there's some more convenient APIs in the newer vscode debugger extension code. I'd take a look at their docs on what kinda actions they provide. I think its unlikely that it's vscode's fault but certainly RunInTerminal Request is something to explore

I came to submit this issue. I experienced the problem across-the-board running Windows and using dashmips in both wsl and powershell from vscode 1.47.3 and dashmips 0.1.6 and 0.1.5 installed via pip. I was thinking there may be an issue relating to calling the interpreter on windows, or having multiple possible shells, so I tried it also on ubuntu the same vscode and dashmips  installations.
I'm new to dashmips, so I'm not sure here, but the problem seems to extend beyond vscode? If I run python -m dashmips debug -i localhost -p 2390 -l ./hello.mips I can confirm that python is listening on <IP_ADDRESS>:2390 but if I attempt to netcat to that port I get no response from dashmips when attempting to send any data/commands. This is all running on python 3.8.2
As an aside, dashmips -v still reports 0.1.0 regardless of which version I install from pip.

As an aside, dashmips -v still reports 0.1.0 regardless of which version I install from pip.

Thanks for noticing this, I've fixed the -v command so it should produce the correct versioning now!

I'm new to dashmips, so I'm not sure here, but the problem seems to extend beyond vscode? If I run python -m dashmips debug -i localhost -p 2390 -l ./hello.mips I can confirm that python is listening on <IP_ADDRESS>:2390 but if I attempt to netcat to that port I get no response from dashmips when attempting to send any data/commands. This is all running on python 3.8.2

Thanks for helping out our project!
Unfortunately we seem to be blocked on these issues with vscode:
https://github.com/microsoft/vscode/issues/100368
https://github.com/microsoft/vscode/issues/103105
The error message is very nondescript so we're waiting on the solutions that fall out of here, and in the meantime exploring work arounds. I appreciate you taking the time to debug the networking, I'll explore that area for any issues.

This has been resolved!


PP-11862: Adds more digital wallet references

Context
Apple Pay is now enabled by default for all services, regardless of PSP. Because of this, we should acknowledge the differences between standard payments and digital wallet payments in other places in the docs.
Changes proposed in this pull request
This PR changes the:

'Take digital wallet payments' to:

reflect that Apple Pay is now on by default

'Add corporate card fees' page to make it clear that corporate fees cannot apply to digital wallet payments
'Report and reconcile your payments' to make sure users know digital wallets can affect reconciliation
'How GOV.UK Pay works' page by:

mentioning that users can pay by digital wallet payments
updating the screenshot of 'Enter payment details' page to show updated UI, content, and Apple Pay option
descriptions of card_details in the API reference to mention the potential unreliability of cardholder details with digital wallets

@alexbishop1 Pushed the updates - could you re-review?


[Non-Breaking] Clean up protobufs

In response to #9 I removed all the breaking changes. To test if this PR breaks Java code gen I copied these proto files into Java SDK v2 and updated the imports accordingly. There might be some breaking changes I didn't notice because the SDK didn't use them.
Changes

Added a linter buf https://github.com/bufbuild/buf which is run on CI
Set 80 character line limit.

Before this was sort of arbitrary as some lines went one for 100+ characters, while others only went to ~80.

Removed trailing spaces.
Update all comments for message types to be multi-line comments

Before this was really inconsistent. Sometimes it would be a multi-line comment, sometimes a single line comment, and other times it'd be a multi-line comment without proper indentation on subsequent lines.

Update all comments on message fields to be single line comments.

Before the comments on fields would either be a single line comment to the side of the field, or multiple single lines comments on top of the field. I just decided to make all comments on fields be on top as this makes it consistent with the rest of the protobufs. Although, it does make the protobufs themselves larger.

Added UNDOCUMENTED doc comment to all messages/fields which were not documented.

To find the undocumented messages/fields simply search for that word. Hopefully this will help get all messages/fields documented.

Rename all files to from TitleCase to lower_snake_case.

This is because of Google's protobuf style guide https://developers.google.com/protocol-buffers/docs/style

Renamed all services' methods from camelCase to TitleCase

This is because of Google's protobuf style guide https://developers.google.com/protocol-buffers/docs/style

Renamed enum variants from TitleCase to SCREAMING_SNAKE_CASE

This is because of Google's protobuf style guide https://developers.google.com/protocol-buffers/docs/style

Updated indentation to always be 4 spaces

Before for some of the new files such as Schedule*.proto the indentation was 2 spaces, while the rest of the files had 4 spaces.

Moved the copyright comment to the top of the file for all protobuf files, and removed unprintable characters <200b>, <200c>, and <200d> which were in the copyright comment.

I'm not sure of those unprintable characters had any meaning, but if they were important they can be re-added.
I'm not sure if this would be considered a breaking change.

Renamed protobuf package from proto to services for the services/*.proto files
Updated all imports to use full path from root of the repo.

E.g. import "basic_types.proto" -> import "services/basic_types.proto"

This affects mirror/, services/, and streams/

E.g. Timestamp consensus_timestamp -> services.Timestamp consensus_timestamp

This only affects mirror/ and streams/

Closing as we determined this needs to be split up.


Add Logical OR  Token at translator frontend

Implement the LOGICAL_OR token to recognize the || operator for performing logical OR operations.

@samthakur587 i'd like to work on this problem

Assigned to you @ArchitGupta07


fix binaryFun

Old log:#2720
Remove import of half of phobos for 100% cases in phobos.
sort, cmp, find, startsWith,  sum and other algorithms would be compiled faster.
See also: Issue 13253 - use more scoped imports in phobos

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=14564


Possibility to change filter cycle

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Possibility to change when the filter cycle should start and for how long it should run.
Describe alternatives you've considered
Possibility to change what schedule to run.
Additional context
Int the app (and on the maneuver panel on the tub) I can change when and for how long the tub should run a filter cycle each day. I am trying to reduce the energy consumption on the tub with advanced automation in Node-RED and it would be great if I could also adjust the filter cycles depending on how much the tub has been used.

I would love to be able change the filter cycles too!


Questions about weight initialization of deformable convolution when self.groups is not equal to 1

In the code of deformable convolution,  the weight is defined as torch.Tensor(out_channels, in_channels // self.groups, *self.kernel_size)) : it is a tensor of out_channels*(in_channels // self.groups)*kernel_size[0]*kernel_size[1]. Then, in the initialization of the weight, the stdv of Kaiming initialization  is defined as 1/math.sqrt((in_channels*kernel_size[0]*kernel_size[1])).
However, I wonder that if self.groups is not equal to 1, the stdv should be 1/math.sqrt((in_channels // self.groups)*kernel_size[0]*kernel_size[1]). Right?
`class DeformConv(nn.Module):
def __init__(self,
             in_channels,
             out_channels,
             kernel_size,
             stride=1,
             padding=0,
             dilation=1,
             groups=1,
             deformable_groups=1,
             bias=False):
    super(DeformConv, self).__init__()

    assert not bias
    assert in_channels % groups == 0, \
        'in_channels {} cannot be divisible by groups {}'.format(
            in_channels, groups)
    assert out_channels % groups == 0, \
        'out_channels {} cannot be divisible by groups {}'.format(
            out_channels, groups)

    self.in_channels = in_channels
    self.out_channels = out_channels
    self.kernel_size = _pair(kernel_size)
    self.stride = _pair(stride)
    self.padding = _pair(padding)
    self.dilation = _pair(dilation)
    self.groups = groups
    self.deformable_groups = deformable_groups

    self.weight = nn.Parameter(
        torch.Tensor(out_channels, in_channels // self.groups,
                     *self.kernel_size))

    self.reset_parameters()

def reset_parameters(self):
    n = self.in_channels
    for k in self.kernel_size:
        n *= k
    stdv = 1. / math.sqrt(n)
    self.weight.data.uniform_(-stdv, stdv)

def forward(self, x, offset):
    return deform_conv(x, offset, self.weight, self.stride, self.padding,
                       self.dilation, self.groups, self.deformable_groups)

`

@ZwwWayne @hhaAndroid
Is there any suggestion? I am not familiar with this topic

Hi @Fu0511 ,
It seems to be a legacy issue where we rarely use the group version of DCN. But your suggestion is reasonable. Would you like to create a PR in MMCV to fix that? @jshilong  will benchmark the performance before and after the modification.


GeneratedDatabaseHolder in multiple libraries

Hi,
I have a Android library that uses DBFlow, and a parent application that uses DBFlow. Both generate the GeneratedDatabaseHolder class. Unfortunately, when you try to build the apk for the application, you get the following error:
com.android.dex.DexException: Multiple dex files define Lcom/raizlabs/android/dbflow/config/GeneratedDatabaseHolder;

This is because both the library and application define the GeneratedDatabaseHolder class in the same package, but have different implementations.
Do you have any recommendations on how to get around this problem? Could you not generate the GeneratedDatabaseHolder class inside a package that corresponds to the current database to avoid symbol clashes?

This is a duplicate of #266. I am going to close it.


Update README

Fix module size badge
Add Sponsorship information
Move compatibility up

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
40

Relevant Lines:
40

💛  - Coveralls


Improve error msg and docs for date_bin.

date_bin function doesn't allow intervals with months and/or year units. Improve error message and docs. The behaviour is compatible with PostgreSQL:
matriv=> SELECT date_bin('1 month 2 hours'::INTERVAL, ts, '2021-01-01T05:00:00Z'::TIMESTAMP)
FROM unnest(ARRAY['2021-01-01T08:30:10Z']::TIMESTAMP[]) as tbl(ts);
ERROR:  timestamps cannot be binned into intervals containing months or years

@Mergifyio backport 5.2


Add metadata if response came from cache

This should be the only place we need to add responseFromCache: true as all other places do re-update and store new cache entries.
Still missing test but sharing for early review

@smyrick Looks good. Would you be able to fix the prettier check and add a changeset?

@tninesling Updated!


IO methods used for pyftpdlib.filesystems.AbstractedFS.open()?

While trying to implement an AbstractedFS, I have come across the open() method. So far, for the requested mode, I have the following methods/properties implemented:

read
write
close
closed

I am trying to avoid doing anything extra when unnecessary. This is for version 1.5.x.
Can I have a link or the name of the file/submodule that uses pyftpdlib.filesystems.AbstractedFS.open?
Is there a "checklist" developers can refer to in order to not only make sure that they have properly implemented all the top-level methods/properties of pyftpdlib.filesystems.AbstractedFS.open, but also the objects returned by them (for example the presumed file-like object that would be returned when pyftpdlib.filesystems.AbstractedFS.open is called)?

Legitimate request. I think it makes sense to document them. Re-opening this for when I will find some time to do it.


No references found for JS/TS unicode identifier

Copied From https://github.com/Microsoft/vscode/issues/27211#event-1105989042:

This still repos with the sample below. This is good manual about valid identifier or use a syntax tree?
export var λ = function () { };

This is actually not a bug with unicode identifiers but with export var x = () =>... style expressions:

Closing as a duplicate of https://github.com/Microsoft/TypeScript/issues/14251


Feature : Adding Group Description while creating the new Group

Is your feature request related to a problem? Please describe
When creating a new group in CircuitVerse, users are currently only prompted to provide a group name. However, in educational settings, particularly for teachers who use CircuitVerse for class activities and assignments, additional information such as section/room designation or any description is often necessary for organisation and management purposes.
Describe the solution you'd like
I propose adding a group description feature when creating a new group in CircuitVerse. This would allow users, especially educators and teachers, to provide additional context and information about the group, such as section or room details, class objectives, or any other relevant information.
Furthermore, I have created a Figma design to illustrate this proposed solution.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

Hi @Asrani-Aman , you need to do some extra also for this feature

Add description while creating group
Show group description in groups list
In edit group page, provide support to update description as well

yes @tanmoysrt bhaiya , i also have created a new revamp page for the group


fix: do not use synthetic imports for nodejs core

Resolves #381

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   94.76%   94.76%
=======================================
  Files          14       14
  Lines         974      974
  Branches      206      206
=======================================
  Hits          923      923
  Misses         51       51

Impacted Files
Coverage Δ

src/auth/jwtaccess.ts
98.18% <ø> (ø)
:arrow_up:

src/auth/refreshclient.ts
89.36% <ø> (ø)
:arrow_up:

src/auth/jwtclient.ts
94.05% <ø> (ø)
:arrow_up:

src/auth/oauth2client.ts
94.48% <100%> (ø)
:arrow_up:

src/auth/googleauth.ts
94.64% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 711109d...41a28bb. Read the comment docs.


fixes nanoTime bug in Monitor

Variables used with nanoTime were being initialized to zero.  If nanoTime were negative it would lead to the elasped time computation with these variables always being negative. Initialized the variables using nanoTime instead of zero to fix the elapsed time computation.

This code could be changed to use Timer, however I chose not do that and make the simplest fix possible for the because of #4885


report: Introduction [6h]

[x] Issue #19 - Project Aim and Objectives
[x] Issue #20 - Deliverables
[ ] Issue #21 - Disposition

Actual time spent: 6h.

Reopening for now to track sub-issues.


Initial job always fails for every node

Version
v0.11.0
Platform/Architecture
linux-amd64
Describe the bug
For every node after applying the plan the first job which is created is failing and the second job helps to upgrade the node.
To Reproduce
Enable upgrade with the first job itself.
Additional context
Attaching the errors below

You didn't attach any logs from either the controller or the job pods. All you've provided is a screenshot of an error that says it failed to read logs from the selected pod. Can your get the actual logs from any of the involved components?

Hello @brandond
Please find below the screen shots of logs of the jobs, job pods and the controller.

Initial jobs created for server and agent plans

Containers inside the initial job for master plan

Logs of pods of the initial job for masterplan

Logs of the upgrade controller

Can you provide any information - logs, status, or so on - from the failed pods or job? I'm still not seeing what's actually going wrong here.

same here going from k3s v1.28.3+k3s2 to v1.28.4+k3s2 with concurrency 1
for each job:
first job instance runs prepare+drain and fails at upgrade container, the relaunches and succeeds
every job runs twice (2 instances of same node job), first run shows failed and subsequent one shows Completed.
Once everything completes all nodes are upgraded succesfully
settings on agent nodes:
drain:
force: true
skipWaitForDeleteTimeout: 60 # 1.18+ (honor pod disruption budgets up to 60 seconds per pod then moves on)
disableEviction: true

first job instance runs prepare+drain and fails at upgrade container, the relaunches and succeeds

Can you provide logs showing why it fails at the upgrade container?

That was what I was seeing as well. I'm going to close this out; if you can provide evidence that this isn't working as designed then we can reopen.


Drawing problem with software rendering

This may be a regression problem after Oct6 big update: running xfreerdp with /gdi:sw I have blue internal background of progress bar in Acronis Backup and Recovery 10 (under Win2008):

Using hardware rendering (without /gdi:sw) all is perfect:

Also on "File Server Resource Manager" of Windows Server 2008:
broken /gdi:sw

/gdi:hw

@giox069 Maybe there is another way to diagnose the issue. Could you add logging to the callbacks registered in gdi_register_update_callbacks and shortly connect to a screen where the color issue occurs? That could narrow down the issue.

@giox069 Does #3680 fix this issue for you?

The problem with "File Server Resource Manager", the second post, seems to be already fixed in the past.
And yes, #3680 or one of the last 3-5 days commits also fixes the main issue with Acronis TrueImage on 1st post.
Thank you! :+1:


Extension recommendation badge not shown for a recommended extension

Testing #37186

opened a python file
install recommendations shows up
select 'install'

The extension viewlet shows up, but the recommended extension doesn't show the badge

The same is true for workspace recommended extensions.

Well, since the view is for "recommendations", if we decide to show the badge here, all items in the list will get the badge.

@Microsoft/vscode thoughts?

One argument that can be made for showing it is consistency. It would also make it more obvious that you are looking at recommendations, the section title doesn't jump out. Could you attach a screenshot with the batches shown for comparison?

I always thought badge is only for the selected extensions, not all workspace recommendations, so in that case I'd only expect Don's extension to get the badge.

@octref The badge is for all recommendations for you.
@chrmarti The default view would look like this:

@ramya-rao-a it's probably better to keep the star in the recommended pane imo as it makes things consistent and reinforces the meaning.

Updated to show the badge in all views for recommended extensions

Tools related recommendations still don't have the badge, but I assume that is expected. Labelling verified.

I think it's worth having the '*' in both views for consistency personally.

@chrmarti The tool related recommendations should have the badge and the reason on hover in the latest Insiders

@ramya-rao-a I now see the Docker and the VSTS extension both have the batch. 👍


the vram is bigger than origin version

I compare the native and the jax version by convertting a record of ten seconds in the platform nvidia 830(not support fp16) with tiny model.
the native version cost 2.99s by using 900M vram,
while jax version(float32 version) cost 1.34s by using 1783M.
Is the phenomenon normal?

Related to #54
Jax by default reserves 90% of the available VRAM even though it's not needed.
You can change that value by setting an environment variable. Check out this link for more info
https://jax.readthedocs.io/en/latest/gpu_memory_allocation.html


support for insecure registries

Getting the following error with a non-TLS enabled localhost registry (for testing purposes):
time="2022-07-26T15:35:46Z" level=info msg="received request POST /ratify/gatekeeper/v1/verify "
time="2022-07-26T15:35:46Z" level=info msg="start request POST /ratify/gatekeeper/v1/verify"
time="2022-07-26T15:35:46Z" level=info msg="subject for request POST /ratify/gatekeeper/v1/verify is <IP_ADDRESS>:5005/net-monitor:v1"
time="2022-07-26T15:35:46Z" level=warning msg="failed to resolve the subject descriptor from store oras with error Head \"https://<IP_ADDRESS>:5005/v2/net-monitor/manifests/v1\": http: server gave HTTP response to HTTPS client\n"
{
  "isSuccess": false,
  "verifierReports": [
    {
      "subject": "<IP_ADDRESS>:5005/net-monitor:v1",
      "isSuccess": false,
      "results": [
        "verification failed: resolving descriptor for the subject failed with error could not resolve descriptor for a subject from any stores"
      ]
    }
  ]
}

Ratify already supports this via the useHttp value. Please reopen if issue still persists.


tests fail

I’m trying to release a new version but the tests fail, even on older states, even the 0.2.6 release:
> npm test
...
✖ #1 multiple addSource calls

AssertionError: 3 == 1
    at Object.equal (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/types.js:83:39)
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/test/test-plugin-api.js:468:22
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/hoodie-plugins-api/node_modules/couchr/couchr-node.js:184:32
    at process._tickDomainCallback (node.js:486:13)

Error: Expected 9 assertions, 25 ran
    at test.done (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/types.js:121:25)
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/core.js:218:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:168:13
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:131:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:165:17
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:463:34
    at MultiCouch.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/test/lib/utils.js:30:9)
    at MultiCouch.g (events.js:180:16)
    at MultiCouch.emit (events.js:92:17)
    at MultiCouch.stop (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/multicouch/lib/multicouch.js:126:10)

Error: not_found
deleted
    at IncomingMessage.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/hoodie-plugins-api/node_modules/couchr/couchr-node.js:168:35)
    at IncomingMessage.emit (events.js:117:20)
    at _stream_readable.js:944:16
    at process._tickDomainCallback (node.js:486:13)

✖ #1 multiple addSource calls

AssertionError: 3 == 1
    at Object.equal (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/types.js:83:39)
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/test/test-plugin-api.js:468:22
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/hoodie-plugins-api/node_modules/couchr/couchr-node.js:184:32
    at process._tickDomainCallback (node.js:486:13)

Error: Expected 9 assertions, 25 ran
    at test.done (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/types.js:121:25)
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/core.js:218:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:168:13
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:131:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:165:17
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:463:34
    at MultiCouch.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/test/lib/utils.js:30:9)
    at MultiCouch.g (events.js:180:16)
    at MultiCouch.emit (events.js:92:17)
    at MultiCouch.stop (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/multicouch/lib/multicouch.js:126:10)

Error: not_found
deleted
    at IncomingMessage.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/hoodie-plugins-api/node_modules/couchr/couchr-node.js:168:35)
    at IncomingMessage.emit (events.js:117:20)
    at _stream_readable.js:944:16
    at process._tickDomainCallback (node.js:486:13)

Error: Expected 9 assertions, 27 ran
    at test.done (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/types.js:121:25)
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/lib/core.js:218:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:168:13
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:131:25
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:165:17
    at /Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/nodeunit/deps/async.js:463:34
    at MultiCouch.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/test/lib/utils.js:30:9)
    at MultiCouch.g (events.js:180:16)
    at MultiCouch.emit (events.js:92:17)
    at MultiCouch.stop (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/multicouch/lib/multicouch.js:126:10)

Error: conflict
Document update conflict.
    at IncomingMessage.<anonymous> (/Users/jan/Work/hoodie/hoodie-plugins-manager/node_modules/hoodie-plugins-api/node_modules/couchr/couchr-node.js:168:35)
    at IncomingMessage.emit (events.js:117:20)
    at _stream_readable.js:944:16
    at process._tickDomainCallback (node.js:486:13)

FAILURES: 8/82 assertions failed (8250ms)

FAILURES: Undone tests (or their setups/teardowns):
- unprocessed tasks should be handled on addSource

To fix this, make sure all tests call test.done()
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

@caolan do you have any idea about what could be going on here?

I tried disabling the failing test(s), but now the tests just hang after the ✔ trigger task events in plugins test.
Also, fwiw, on Linux I see ✖ #1 multiple addSource calls AssertionError: 2 == 1 instead of 3 == 1.

disabled all tests and released master as 0.4.0 as testing locally everything seemed to work, but now it looks like signUp is broken in my-first-hoodie, the user gets created and db set up, but the sign up modal displays an error [object Object]. If we can get this resolved today, I’ll revert the version bump.

I just tried running npm test locally for 0.2.6 and the tests passed. What version of CouchDB are you running? It uses multi-couch for the tests.

Can you try master-1?
I can’t even get 0.2.6 to run.
This is on CouchDB 1.6.1.

node --version
v0.10.36

if it helps any

here’s a log from a fresh 0.2.6 checkout:
> git clean -fdx
> git checkout 0.2.6
> npm install
> npm test

><EMAIL_ADDRESS>test /Users/jan/Work/hoodie/hoodie-plugins-manager
> nodeunit test

test-plugin-api
✔ changed docs passed to plugins can be modified
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ sendEmail function
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ get config values from plugin manager
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ automatically update plugin config
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ automatically update app config
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ trigger account events in plugins
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ trigger task events in plugins
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
✔ task add events
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED
[db_updates] Error: connect ECONNREFUSED

it just hangs after this.

same on linux fwiw

linux on 1.5.0 :)

Refactored and updated the test setup in #20.
The issues should now be resolved.


[Add] README.md 파일 작성 및 Codecov and Cypress Badge 추가

Set code coverage in codecov.yml
Set Cypress record dashboard in ci.yml

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2d2fb28). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #11   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         1
  Lines           ?         2
  Branches        ?         0
========================================
  Hits            ?         2
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2fb28...df6c32f. Read the comment docs.


Undefined variable using @php directive

Laravel Version: 7.10.3
PHP Version: 7.2.29
Database Driver & Version:

Description:
I assign some value to my variable using @php directive but the view throws an error saying that variable doesn't exist.
    @php
        $path = 'my_path';
    @endphp

    @include('my-view', ['model' => $my_model, 'path' => $path])

If I replace @php by <?php and @endphp by ?> all works fine. Also on the top of view, I use a similar approach and all works fine:
@php
    $url= 'value';
@endphp
 $item->value]) }}" class="button button--white">
     Error

Steps To Reproduce:

Add @php directive to your view with some variable assignation
Pass the variable using @include directive  to the different view

Can you paste the compiled blade file?

Not sure if I took it from the right place:

                        @php
                            $path = explode('.', \Route::currentRouteName(), 2)[0];
                        ?>

                        <?php echo $__env->make('my-view', ['model' => $my_model, 'path' => $path], \Illuminate\Support\Arr::except(get_defined_vars(), ['__data', '__path']))->render(); ?>

I think the problem is caused by:
@php($variable = $value)
Compiled blade turns it into:
<?php($variable = $value)
And doesn't close PHP tag as the result blade is getting lost and stop transform some code parts. Seems strange that when I use <?PHP in that case (I mean $url variable) it doesn't throw the error even if the PHP tag of one line directive ($variable) is not closed.

I can't recreate this.

Sorry to resurrect, but can confirm this is still happening
It appears to only happen when a blade template contains both @php() and @php ... @endphp - they work fine when there's only one or the other
I'm on laravel/framework v9.46.0 and PHP 8.0.19
To replicate:

Create test template
Add this

test
@php($a = 'abc')
test2
@php
$b = 'def';
@endphp

Load the page, see that test2 isn't on the page
Find the following compiled file in storage/framework/views

test
<?php($a = 'abc')
test2
@php
$b = 'def';
?>

<?php /**PATH /xxx/resources/views/test.blade.php ENDPATH**/ ?>

This clearly isn't correct, and nobody would expect this kind of behavior.


Centralize fetching of PR reviewers

This is where we should probably start moving to graphql...
Notifications to reviewers were not happening on push events
after reviewers had submitted their reviews because they were
removed from requested_reviewers, but do not come back by default
in get_pull_requests call.

@briangreenery oh, the irony. you probably didn't get the notification just now that I updated this PR since you already approved it. :disappointed:


Used code from go ethereum project to add elliptical curve functions

As part of #77 #75.

Actually, i think this needs some more work... oops


Need an ability to remove uploaded document(s)

Hi,
Once documents uploaded (like in the attached screenshot) , need to be able to remove the document(s).

Thanks

It would also be phenomenal if there was a gradio api endpoint for this as well

@slavag @raymondtri done.


Updating patch version of tiny-slider

Hey there,
In our Plugin we've been working on, we encountered an issue with Tiny Slider and Responsive Containers.
As the items in our slider are of variable size, it causes tiny-slider to add whitespaces at the end of the items.
1. Why is this change necessary?
Tiny Slider Version 2.9.2 has a known issue with responsive containers.
2. What does this change do, exactly?
Fix known issues, by updating the patch version of tiny-slider.
3. Describe each step to reproduce the issue or behaviour.
Create a tiny slider instance, with variable sizes of the image items and the outer container. Set controls to true and skip through a bunch of items.
4. Please link to the relevant issues (if any).
ganlanyuan/tiny-slider#387
Fixed in version 2.9.3 https://github.com/ganlanyuan/tiny-slider/releases/tag/v2.9.3
5. Checklist

[N] I have written tests and verified that they fail without my change
[N] I have created a changelog file with all necessary information about my changes
[N] I have written or adjusted the documentation according to my changes
[N] This change has comments for package types, values, functions, and non-obvious lines of code
[Y] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-22154
Please use this issue to track the state of your pull request.


[FR] Reverse qualifier expressions to improve readability

Is your feature request related to a problem?
Some of the qualifiers, e.g minLength, maxLength, minItems, etc., result in mathematical expressions including operators like >, <, >=, <=. The issue is that the expressions, although accurate, are not displayed in a natural, intuitive manner:
In the example below, notice the possible values are expressed in "reverse" as "1 ≤ value":

Describe the solution you'd like
Refactor qualifiers as needed to display in a more natural, intuitive manner. For example, "1 <= value" could be more easily understood if it was written as "value >= 1" or simply ">= 1".
Describe alternatives you've considered
n/a
Additional context
I believe ReDoc offers a great example of how to express qualifiers and should be referenced whenever needed.

Here's what the new qualifier looks like:


added annotation for exceptionLoggingService

Using logging.js in our application failed when using the uglified version of our app. Debugging showed that all code of logging.js except one already contains manual annotations - just one spot was missing. While I could solve the issue in my build environment, I think this should be changed in logging.js for consistency reasons, and to aid other users...

Are there any reasons for not applying this?

Apologies @mephinet, we must have missed this! Would you mind bumping the version by a minor?

@markwallsgrove I've merged with you upstream branch and increased the minor version.


Not working on windows 7

I have tested on my windows 7 ultimate 32 bit . When i execute the exe file it shows file is not compatible with version of windows running

Can you show me your inputs to the tool, similar to what I have attached

Please solve the issue

It seems to be a compiler issue. x86_64-w64-mingw32-g++ compiles for 64 bit computers.
i686-w64-mingw32-g++ will compile for 32 bit computers.
Hello World.zip
Can you run this 'hello world.exe' in your Windows Machine, use sandboxing if possible.
Because the exe compiled by 'i686-w64-mingw32-g++' will not run in 64-bit computers.


Make delete button in danger color

Description
In other parts of Cloud Services, delete buttons are in danger color.
Before

After

@martinpovolny

ping @terezanovotna

let's make it red to be consistent with other parts of cloud services


Add additional fetch with SetUpForDevelopment script

Adding the following for the github upstream repository is useful for SimpleITK contributors and developers:
[remote "github_upstream"]
	url = https://github.com/SimpleITK/SimpleITK.git
	fetch = +refs/heads/*:refs/remotes/github_simpleitk/*
        fetch = +refs/pull/*/head:refs/remotes/github_simpleitk/pr/*

This method is out of date a similar pr alias is in ITK that could be added instead.


Thanks a lot

Hey there @vivizyx! This looks like you are filing a support request, rather than proposing code changes (which is usually what we use a Pull Request for). Can you please post your question to the QIIME 2 Forum at https://forum.qiime2.org? That is where we provide official support for the project. As well, I am going to close this Pull Request out, since it doesn't appear to be a code change --- if I am mistaken feel free to clarify and re-open. Thanks!


@conda-forge-admin, please add bot automerge

Additional comment:
@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/de-interpol-feedstock#2.


Zamia ASR pre-trained model.

I'm trying to use of the pre-trained ASR speech to text models on a test wav file in Python. What's the easiest way to do this ? I just finished installing pykaldi. Could someone provide me a snippet of code on how to do this ? Say I want to use the kaldi-generic-en-tdnn_f model.

Try following this example. It should be fairly straightforward to replace the models with your own.

I just added an example setup for Zamia models. Let me know if you have any trouble running it.

Thank you very much. It's working well.

Thanks for also including me into this!
I suggest they use mainly the docker image. Works more easily.
Panagiotis

On 20 Feb 2019, at 22:00, Dogan Can<EMAIL_ADDRESS>wrote:
I just added an example setup for Zamia models https://github.com/pykaldi/pykaldi/tree/master/examples/setups/zamia. Let me know if you have any trouble running it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/pykaldi/pykaldi/issues/79#issuecomment-465751945, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKlRNyRfG5ElpWpA-p7zavjfA6y7zkeks5vPbdbgaJpZM4bF7zt.

I suggest they use mainly the docker image

Could you elaborate on this ?
Also, I was wondering if there'd be any issue with multiprocessing (decoding multiple files in parallel?) and if pykaldi can run on Mac as well ? I'd really appreciate it and I think a lot of people would benefit from being able to run this on Mac.

Docker image is useful if you have trouble installing from source or if you want to quickly spawn a container with a pykaldi installation.
There shouldn’t be any issues with multiprocessing. If there is let me know.
Currently pykaldi is Linux only. It shouldn’t be too hard to get it working on Mac but it is not a priority for us at the moment. Pull requests are welcome :)

@Cloud299 Just added support for macOS. I would appreciate if you could try installing on Mac and report what happens.

Thank you for including support for macOS. I'm running into the following error when doing /install_clif.sh
clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later)
error: command 'gcc' failed with exit status 1
I'm running macOS 10.14.3

Is this a clean installation? I need to see more context to understand at what stage of the build you are receiving this error.

Can you try running the following before install_clif.sh
export MACOSX_DEPLOYMENT_TARGET=10.14

Great! No idea why cmake did not automatically pick up the deployment target based on your host system though.

I just updated the folder "zamia" to include the new model from 2019 on my Mac. However I'm running into a "Cannot open config file: conf/ivector_extractor.conf". I suspect this has to do with the command "ln -sr exp/nnet3_chain/ivectors_test_hires/conf/ivector_extractor.conf conf/." and "ln -sr ../aspire/data/test data/." from the update model.sh.
I don't think the flag -sr applies for Mac. How should I fix this ?

Never mind. Fixed this by simply copying exp/nnet3_chain/ivectors_test_hires/conf/ivector_extractor.conf to conf/

The "-sr" flag should work on Mac. You probably downloaded the new models into a dirty directory containing old models and symbolic linking somehow failed. The model download scripts are bare bones, they don't check if things are already in place before trying to override them.

I see thank you for the feedback.
I have another question. I wrote a script "test.py" that imports a custom function I wrote in decode.py in /examples/setups/aspire/. This function works perfectly fine in /aspire folder. However, when I execute this script from outside the /aspire folder, I get the following error:

I made sure that all the paths in decode.py are full and global. I think this error might have to do with the file path.sh but I'm not sure how to fix this yet.
Thank you for all your answers!

Seems like you didn't update the paths in conf/ivector_extractor.conf.

Thank you very much. This fixed the problem. I really like how you always got to the crux of the problem immediately.

You're welcome.

Just for curiosity, in decode.py, is there an option to remove all the verbose when running the process ?

Almost all of the verbosity is coming from kaldi so there is no way of suppressing all of the verbosity without changing kaldi code. All of the log messages are written to stderr so you can separate log messages from script output by redirecting standard error to a log file, e.g.
./decode.py >log.out 2> log.err


Issue with Filter Array Action  - Filter Query not rendered correctly after changing VSCode Tab

Describe the Bug with repro steps

Create new Standard Workflow with Compose to contain test array
Add Filter Array Action using item()?['array_element] in the "Choose a value" value field (Basic Mode)

Change to another VS Code tab and return to the workflow tab
Filter query has switched to Advanced mode with ?['array_element]

Code View of the action appears to be correct

What type of Logic App Is this happening in?
Standard (VSCode)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Compose": {
                "type": "Compose",
                "inputs": [
                    {
                        "KeeperCompanyID": "1567",
                        "CWCompanyID": "19553"
                    },
                    {
                        "KeeperCompanyID": "1345",
                        "CWCompanyID": "19556"
                    }
                ],
                "runAfter": {}
            },
            "Filter_array": {
                "type": "Query",
                "inputs": {
                    "from": "@outputs('Compose')",
                    "where": "@equals(item()?['CWCompanyID'],19556)"
                },
                "runAfter": {
                    "Compose": [
                        "SUCCEEDED"
                    ]
                }
            }
        },
        "contentVersion": "<IP_ADDRESS>",
        "outputs": {},
        "triggers": {
            "When_a_HTTP_request_is_received": {
                "type": "Request",
                "kind": "Http"
            }
        }
    },
    "kind": "Stateful"
}

Screenshots or Videos
See above
Browser
VSCode Info
Version: 1.83.0
Commit: e7e037083ff4455cf320e344325dacb480062c3c
Date: 2023-10-03T16:13:10.518Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.0.0
VSCode Designer Extension Ver 2.69.1
Additional context
No response
AB#25467963

Hi @axiomitdavid, thanks for catching this. We have this fixed in https://github.com/Azure/LogicAppsUX/issues/3414, which will be in all regions by 10/20


[WIP] build: add CMake build system for CoreFoundation

Add a CMake based build system for CoreFoundation.  This helps moves to
a single unified build for swift and the corelibs.  It also makes it
easier to cross-compile.

CC: @gottesmm

It would be good to also update the readme to include instructions on how to build this via cmake

Okay, docs are updated, and we now do incremental builds instead of a single glob.

Okay it seems to be pretty far along now, with XCTest being required for the testsuite

@parkera @millenomi - how do you break the dependency cycle between XCTest and Foundation?

@compnerd We usually don't. build-script builds in this order:

Foundation
XCTest
Foundation tests

and I think that dependency is handled in build-script-impl, not here.

Okay, this is now tested against XCTest in the sense that XCTest builds and runs against this (and passes tests).  I think that this is in a good state now.  The remaining pieces is the test suite/infrastructure.

We already have some lib/lib64 infrastructure in the main build scripts; can we follow the example set there?

@millenomi - there shouldn't be anything special needed for the lib vs lib64 here, its using the GNUInstallDirs, so the standard cmake handling should be sufficient.  Is there something specific that you believe is unsupported with the current implementation?  This is just missing the xctest option to enable the tests AFAIK.

Okay, at this point, its pretty close.  The tests require copying the resource bundles and two tests are currently failing (NSLocale and UserDefaults).  This does require the annotations to be synchronized as well.

Okay - getting closer; need to figure out the right location for xdgTestHelper, but, seems that the rest of the test suite is now passing (the callbacks in CoreFoundation weren't being setup properly).  I think that once #1612 is merged, this is going to be really close on its heals.

@compnerd the xdgTestHelper binary needs to be in the same directory as TestFoundation so that is can be found using testBundle().url(forAuxiliaryExecutable: "xdgTestHelper")

Okay, so, this is now complete AFAICT.  I am able to build and run tests and have the full test suite pass with the CMake based build system :-)

@swift-ci please test

@phausler - what do you think is the best approach here?  We could merge this as it will have no impact, but it is not usable without the CF changes that are still pending (#1612).

@swift-ci please test

@swift-ci please test

The test seems to have failed with something unrelated to this change. Maybe it's worth trying to rebase this on top of master and we can try again?

orelibs-foundation/../Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation/usr/lib/swift/CoreFoundation/module.modulemap:2:21: error: umbrella header 'CoreFoundation.h' not found
13:12:12     umbrella header "CoreFoundation.h"
13:12:12                     ^
13:12:12 Foundation/NSObject.swift:15:8: error: could not build C module 'CoreFoundation'
13:12:12 import CoreFoundation
13:12:12        ^

@alblue, sure I can rebase it, but that won't go away :-(.  The thing is that the module map is altered to use a Framework layout on all targets, which is perfectly fine, except for the fact that the old build doesn't generate a framework layout ... sigh  I guess we could duplicate the module map temporarily.  Thoughts on that?  It seems sad to have to maintain two versions of the module map.

Okay, rebased with a small tweak to disable the hidden visibility of CoreFoundation.  This is less than ideal, but perhaps we can get the CMake build enabled while we fix the symbol visibility.

@compnerd was about to merge this, then I noticed that the .modulemap for Foundation has been changed. Can you remove that file from this patch, so that we just have the CMake files? Apologies for the delay in this.

@alblue sure, I can do that, however, that won't really work per se ... the CMake build is configured to use the framework style build for CoreFoundation.  I can duplicate the module map and that should be enough to use the CMake build.  Would that be acceptable?

For now, let's get the cmake scripts in without adding or changing any modulemaps. We can then tackle the modulemap changes with visibility changes in e.g. #1612 at a later stage. This way we can start iterating on the cmake scripts instead of keeping this open for a long time.

@swift-ci please test and merge


Implement MMS algorithm for npos-election

This will be algorithm 2 explained here: https://github.com/w3f/research-internal/blob/master/papers/NPoS_validator_selection.pdf.
We will most likely never want to use this on a chain, because this solver is considerably slow, yet it produces better results and on offchain application/bot might want to use it to improve on-chain solutions.
This is a great first issue for someone to get started with election algorithms. Reading the paper itself worth the time.

cc @AlfonsoCev.

w3f/research-internal is not public, is this issue internal? I'd like to read the algorithm 2 explanation.

@emostov you might be interested in this.

This will be algorithm 2 explained here: https://github.com/w3f/research-internal/blob/master/papers/NPoS_validator_selection.pdf.
We will most likely never want to use this on a chain, because this solver is considerably slow, yet it produces better results and on offchain application/bot might want to use it to improve on-chain solutions.
This is a great first issue for someone to get started with election algorithms. Reading the paper itself worth the time.

I assume that you mean algorithm 1 instead?

No, 2:


Get ball rolling for prodsec stuff

There are no  deliverables for this that we need to knock out.


Fixing advanced filter by project on history page, addresses issue #403

Changed the SQL statement to avoid ambiguous column: enc_type. This should correct the problem.

LGTM.

@mariacioffi
The change LGTM.
Could you include a unit test now that we have enabled memory based H2 DB tests?

@kunkun-tang any reason this one was not merged?

The change looks good to me. @mariacioffi FYI: We just moved the code to azkaban/executor/ExecutionFlowDao.java:270

Close once #1638 is merged.


[Question] E011: Expected do near B10000000

Hi there, I've written a short snippet of Lua and I can't seem to understand why luacheck keeps throwing this error on the first line:
while byte >= 0B10000000 and byte < 0B11000000 do
    pos[2] = pos[2] - 1
    byte = string.byte(M.get_line(pos[1]):sub(pos[2], pos[2]))
end

Any help would be appreciated, and thanks for writing such a great piece of software!
I'm actually not 100% sure how to check the version of luarocks that I'm using since it's set up via GitHub actions, but it seems to be the most recent version(?). The workflow runs the following:
sudo apt install -y luarocks
sudo luarocks install luacheck

I realized that there's a marketplace thing for setting up CI; I'll try following the instructions in the README and re-open this if I'm unable to figure it out.

I was able to fix it by switching over to the workflow provided in the README. Sorry for the noise!

I'm glad you figured out your issue. With the info you give now I will suggest the underlying issue here is not the luacheck version but the lua version. The GitHub Action we provide is running on Lua 5.4 under the hood. The default Ubuntu environment you used is most likely running something quite a bit older.


Service: Reduce host logging

Summary
Update default logging to be Warning level to reduce unnecessary log messages
Contributor Tasks
These tasks are for the pull request creator to tick off.

[ ] Relevant changelogs have been updated with user-visible changes

[ ] TouchFree Windows
[ ] TouchFree BrightSign
[ ] TouchFree Web Tooling

Reviewer Tasks
Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

[ ] Developer testing
[x] Code reviewed
[x] Non-code assets reviewed
[x] Documentation reviewed - includes checking documentation requirements are met and not missing e.g., public API is commented

🤷 Should the Brightsign changelog be updated?


Version Regex parameter should not be mandatory field or hidden

Azure DevOps Extension you are using

Version Assemblies

Where are you running it?

Azure DevOps

Version of Extension/Task

Latest from Marketplace

Expected behaviour and actual behaviour
My objective is having a version number tracked by developers under the field AssemblyVersion (already checked in source code), another version number used by devops team, AssemblyInformationalVersion (modified by Version Assemblies to use Azure DevOps Pipeline Build Number)

The attached screenshot outlines my expected behavior currently doesn't work unless I export the pipeline into JSON format remove RegEx filter then import as new build pipeline

Version RegEx Filter needs to be blank in my example, but it's required field
Inject version set to true to disable RegEx validation of my Azure Build Number e.g. master.20190422.1. But checking this box also hides the RegEx Filter.

Steps to reproduce the problem

Repo with any .NET project with [assembly: AssemblyInformationalVersion("")] inside Assembly Information .cs file.
Azure DevOps build pipeline with Version .NET Assemblies step before build step to replace AssemblyInformationalVersion with $(Build.BuildNumber)
Looking at build artifact we don't see DLL/executable property -> Details tab -> Product Version field as Azure Pipeline Build Number

Suggested solution

Modify task.json, remove required: true for VersionRegex input
Modify task.json, remove visibleRule: InjectVersion = false for VersionRegex input

Thanks for bring this to my attention, and providing a solution.
I think for consistency I should make the change for all the tasks in then extension
I will do this as soon as I have time

I have made the changes you suggest to the Version .NET Assemblies task, and released as 2.11.2. Can't help thinking there is a better solution, clearing the versionregex parameter, or putting extra logic around its use, but your solution has the lease knock on effects.
Let me know if it works for you.

Just tested works as expected, thank you!!


Coroutines 1.6.3

For a Gradle dependency:

Update the dependency version in the root gradle.properties
Update the dependency locks

For Gradle dependencies: ./gradlew resolveAll --write-locks

Verify no unexpected entries appear in the lockfiles. A supply chain attack could occur during this stage. The lockfile narrows the supply chain attack window to this very moment (as opposed to every time a build occurs).
Are there any new APIs or possible migrations for this dependency?

Minor update
https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.6.3

Nevermind, we don't use coroutines on this project.


fix(dropdown): keyboardNav is not working

The demo is static menu item markup, it work.
but, when use ngFor to render menu, item keyboard navigation has no effect.
I have track the call stack, all the same.
elems[this.selectedOption].focus(); // not work, when element in template

Okay, I found the problem.
Which HTML elements can receive focus?
HTMLAnchorElement/HTMLAreaElement with an href
so that if want to implement custom select component with dropdown directive, need use
option

@mkjeff check demo it is working with beta.12

@valorkin  It is not a bug, please see my reply.

@mkjeff ok, so what should I do? Or it is just an info to keep in mind?


ModuleNotFoundError: No module named 'main.complex_utils'; 'main' is not a package

Hello,
I am getting this error when i ran "butterfly_multiply" module.
ModuleNotFoundError                       Traceback (most recent call last)
 in
4 from torch import nn
5
----> 6 from .complex_utils import complex_mul
7
8 use_extension = True
ModuleNotFoundError: No module named 'main.complex_utils'; 'main' is not a package
Can you please help me solve the problem.
Thanks,
Dhruba

Are you running this from an interactive session (e.g. ipython)? If so, relative import (from .blah import blah) doesn't work. This is an issue with Python import in general (https://realpython.com/absolute-vs-relative-python-imports/).
If you just need to run this file from an interactive session, you can remove the dot (so from complex_utils import complex_mul). But in general we mostly run the training scripts that then call butterfly_multiply.

Hi tridao
thank you for the reply, a quick question may I know, in which part of the code segment the butterfly matrix is generated .
Or do you have any flowchart of slides related to this. Your help in this concern is highly appreciated
Regards
Dhruba

The butterfly matrix isn't explicitly generated (as that would use O(n^2) space and takes O(n^2) time to multiply by a vector). Instead, we provide a Butterfly class that stores O(n log n) parameters and implements O(n log n) multiplication algorithm (https://github.com/HazyResearch/learning-circuits/blob/master/butterfly/butterfly.py#L76).

In butterfly connection, each node each connected to two other nodes, so why it is not 2n log n? Also can you please tell me where in the code you multiply the weight vector and the input features? and where you update the vector of weights?
Thanks,
Dhruba

You're right, it's 2n log n parameters. Remember to pass in tied_weight=False, like Butterfly(1024, 1024, tied_weight=False).
The version with tied weights was used in an earlier paper, where we only had 4n parameters.
The O(n log n) multiplication algorithm is implemented in 3 times in 3 different languages:

In Python (pure Pytorch), for ease of understanding: https://github.com/HazyResearch/learning-circuits/blob/cnn/butterfly/butterfly_multiply.py#L126
The actual implementation is only 4-5 lines of Python.
In C++, for efficient inference: https://github.com/HazyResearch/learning-circuits/blob/cnn/butterfly/factor_multiply/factor_multiply.cpp#L463
with Python interface here: https://github.com/HazyResearch/learning-circuits/blob/cnn/butterfly/butterfly_multiply.py#L165
In CUDA, for efficient training: https://github.com/HazyResearch/learning-circuits/blob/cnn/butterfly/factor_multiply/factor_multiply_cuda.cu#L1241
With the same Python interface as 2.

The weights are stored in the attribute twiddle of the Butterfly class, which is just a Pytorch tensor. To update it, you pass it to a Pytorch optimizer just like any other trainable weight.

Okay; So in the following lines:
self.model = nn.Sequential(
FixedPermutation(torch.tensor(bitreversal_permutation(size))),
Butterfly(in_size=size, out_size=size, bias=False, complex=complex, ortho_init=True)
).to(device)
permutation provides (lets say for size 8): array([0, 4, 2, 6, 1, 5, 3, 7])
does the butterfly provides another array?
Do each of these number inside array represent individual nodes in layer?
Also, What is the difference between BP and BPBP?
Does BPBP have two times more layer than BP?
Thanks,
Dhruba

If you're asking about how to compute the gradient wrt to the weight:

In the pure Pytorch implementation, we rely on Pytorch's autodifferentiation to compute gradients.
In the C++ and CUDA implementations, we compute the gradient explicitly, and provide Python interface. If you're just using the Butterfly class, you do not need to know how backward is implemented.
In any case, the algorithm is simple: treat the butterfly matrix as a product of log_n matrices, which you can think of as log_n layers. Then run back-propagation/autodiff on it. This amounts to a few for loops. The core implementation is about 20 lines of C++ (https://github.com/HazyResearch/learning-circuits/blob/cnn/butterfly/factor_multiply/factor_multiply.cpp#L733).

Okay great. I am kind of confused, how did you calculate loss or which loss function you actually used?

It can be used with any differentiable loss function.
In back-propagration/reverse mode autodiff, for each layer, we are given the incoming error/grad from layers above, and use that to compute gradient wrt to the parameters of the current layer.
That's exactly the interface of a custom Pytorch layer (https://pytorch.org/tutorials/advanced/numpy_extensions_tutorial.html): in the backward, given the gradient wrt to the output of the layer, compute the gradient wrt to the parameters of the layer.

Hi tridao,
I use windows OS and jupyter notebook. i am having trouble with ray.

We only use ray to run the experiments (parallel runs and hyperparameter optimization).
The butterfly class (in the butterfly directory) doesn't require ray.


Automated cherry pick of #1528: Update IsAPIServerReady for variants

Cherry pick of #1528 on release-v1.21.
#1528: Update IsAPIServerReady for variants

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.


add command line prompts for user input

work in progress

Merging this to keep development velocity for @benjmarshall 's branch that builds off this 🎉


add a few fields to iTunes module

=== This issue was migrated from JIRA ===
Type: New Feature
Priority: Major
Status: Open
Resolution: Unresolved
Reported by: Kevin Horan
Assigned to: Robert Cooper
Created: Fri Dec 28 05:25:09 CET 2012
Updated: Fri Dec 28 05:25:09 CET 2012
JIRA Link: https://rometools.jira.com/browse/MODULES-10
=========================================
I have been using your iTunes module to develop a podcast. There
are a few fields I would like to use though that aren't present, at the
Entry level. These are the "image" tag (A URL), the "order" tag (an
int), and the ability to set "explicit" to "clean" (makes iTunes display
a certain icon I guess). The following two tags would also be useful,
but not required: "complete" (Boolean), and "new-feed-url" (URL).
     I'd be happy to makes these changes myself. I'm not
very familiar with contributing to projects, so let me know how best to
help.

Were these changes ever merged? I have need of the image tag support.

Most of this has been recently fixed in #37, except for the clean value of the explicit tag.
Adding clean value is a breaking change. I don't want to do breaking changes without a roadmap and a separate branch for the next major version. Otherwise any merged change will end up in the next minor or patch release.
By the way, maybe it's time to do a minor release? What do you think? @snoopdave @PatrickGotthard

@PatrickGotthard Any thoughts on doing a minor release?

Moved this issue to https://github.com/rometools/rome/issues/244 as part of https://github.com/rometools/rome/issues/217


refactor  model process flow when create or destroy injections

Question?
In chaos-exec-service module,When create or destory injection,currently has special  logic for the jvm plugin,but  the module is common,so can't include any special logics for one plugin.
How to resolve
So we need to avoid this and supply interfaces for plugin to extend.

PreCreateInjectionModelHandler
Model Level Handler before create injections
PreDestroyInjectionModelHandler
Model Level Handler before destroy injections

Good refactoring. 👍


cannot open jsconfig.json. Detail: file already exists on disk

VSCode Version: 1.1.1- insider
OS Version: win7

Steps to Reproduce:

project path: D:\#MYGIT\ndk
click to add jsconfig.json in popup message

ERROR:
cannot open untitled:d%3A%5C#MYGIT%5Cndk%5Cjsconfig.json.  The path we simply concat contains a # and therefore becomes a fragment path.

We should consider adding more uri modification methods: #6678

verifier have a workspace folder that contains a # character


Azure DevOps Cosmos DB Emulator docs should not recommend VS2017.

In these docs we are recommending VS2017 because of a vague message about "not supporting" VS2019.
That section should be rephrased to say that Cosmos DB emulator is pre-installed on windows-2019 and windows-2022 and that you do not need to use the Azure DevOps task, instead you should add a Powershell Script task and start the emulator yourself.
We should not recommend 2017 as it is being deprecated in March and will also start having blackout dates.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 617f002c-f40e-28a0-2ab7-e3227e08e37c
Version Independent ID: a06ba438-55c8-e77c-ec89-095d44fbf4f3
Content: Set up CI/CD pipeline with Azure Cosmos DB Emulator build task
Content Source: articles/cosmos-db/tutorial-setup-ci-cd.md
Service: cosmos-db
GitHub Login: @StefArroyo
Microsoft Alias: esarroyo

Hi @brasky Thanks for your findings, I'm assigning this to the author for the feedback review

#assign:seesharprun

Thanks @brasky for your feedback! It looks like this was addressed in the latest version of the doc with a Note at the top of the document:
https://docs.microsoft.com/en-us/azure/cosmos-db/tutorial-setup-ci-cd
#please-close


Add ppc64le arch

#Adds support for Power.
This depends on Dapper's PR 44.
I downloaded Docker 1.10.3 for ppc64le from the Ubuntu repository, and extracted the client binary from it (and renamed to docker-1.10.3_ppc64le).
I'm not sure if share-mnt requires a special build of it; either way, the file should probably be hosted in<EMAIL_ADDRESS>Let me know if I should update that.

have been waiting for these binaries on power ( ppc64le ) , hopefully this PR can be worked upon

Very stale. Closing. Thanks! Please open a new PR if there is still a relevant change.


[Event Request] Codeunit 12 Gen. Jnl.-Post Line - CalcPmtDiscPossible

Could you please create an Integration event in Codeunit 12 Gen. Jnl.-Post Line, in function CalcPmtDiscPossible?
LOCAL CalcPmtDiscPossible(GenJnlLine : Record "Gen. Journal Line";VAR CVLedgEntryBuf : Record "CV Ledger Entry Buffer")
// >>>>>>>
IsHandled := FALSE;
OnBeforeCalcPmtDiscPossible(GenJnlLine,CVLedgEntryBuf,IsHandled);
IF IsHandled THEN
  EXIT;
// <<<<<<<

WITH GenJnlLine DO
....

Event signature:
LOCAL [IntegrationEvent] OnBeforeCalcPmtDiscPossible(GenJnlLine : Record "Gen. Journal Line";VAR CVLedgEntryBuf : Record "CV Ledger Entry Buffer";VAR IsHandled : Boolean)

Similar to OnBeforeCalcPmtDisc event in CalcPmtDisc function (in the same codeunit).

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Editing Port keys off Port Number, not ID

When editing a port, the endpoint uses the port number to pick which db row to edit. I've had it edit the wrong one because of this. Should key off row id. Or another way could be to prevent duplicates (it prevents duplicates when adding new, but you can edit a port to be the same as another).
Steps to reproduce:

Add a port, call it A.
Add a second port, call it B.
Edit A to have the same port as B.
Edit B to have another port, it will change the values for A instead.

Thank you for bringing this to attention. Added it to my list of bugfixes!

@vinaykapadia could you give v1.0.3 a try and let me know if you're still experiencing issues?
You may have to start from a fresh database as there may have been some breaking changes along the way.
Thank you!

Will do!

Works great now, thanks!


Track status

Track status issues fixed

Codecov Report

Merging #161 (44a99a9) into master (dc562af) will not change coverage.
The diff coverage is 70.00%.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   48.79%   48.79%
=======================================
  Files         110      110
  Lines        4062     4062
=======================================
  Hits         1982     1982
  Misses       2080     2080

Flag
Coverage Δ

back-end
45.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

back/controllers/oldSchedule.js
6.84% <0.00%> (ø)

front/src/tabletview/rangeofficer.js
63.52% <80.00%> (ø)

front/src/TrackStatistics/TrackStatistics.js
94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc562af...44a99a9. Read the comment docs.

Issues present. Request rejected.