When using eNB location tool, sector 0 does not get located

This one has been bugging me for a while for EE and Three. Sector 0, which corresponds to band 3 1617 / band 3 1392 won't get located when using the eNB location tool.
You have to instead use the sector location tool.
As an example, I temporarily unlocated this cell on EE.

When editing it and locating it using the eNB tool, it will locate all the other sectors except for this one.
I have to use the sector editing tool to locate this cell due to the way NetMonster works at the moment.

Hello @ExperiencersInternational, this issue has been resolved and will be available in the next NetMonster app version.


getWidth on a Bundle type does not return the right value in a tester(PeekPokeTester)

class LinkNode extends Bundle {
  val next = UInt(64.W)
  val count = UInt(32.W)
  override def cloneType = (new LinkNode).asInstanceOf[this.type]
}

See code below for which simulation log reports:
In Bla 96
[info] [0.001] In Foo 32

class Foo (bla: Bla) extends PeekPokeTester(bla) {
  println(s"In Foo ${(new LinkNode).getWidth}")
}

class Bla extends Module {
  val io = IO (new Bundle())
  println(s"In Bla ${(new LinkNode).getWidth}")
}

class SorterAccTester extends ChiselFlatSpec {
  "FooBla" should "simulate" in {
    chisel3.iotesters.Driver(() => new Bla,"firrtl"){ c=>
      new Foo(c)
    }should be(true)
  }
}

Anyone could reproduce it at least?

I have reproduced it.  Not sure what's going on.  For some reason the internal iteration through the elements is missing a field when the bundle is defined with PeekPokeTester

The root of the problem is that when the bundle is declared in a subclass of PeekPokeTester instead of a Module there is a problem in the lazy assembly of the bundle's elements field.

It iterates over the public elements of the field.
It invokes each element and sees if the return value of the invoke has been seen before
It uses a set seen of the return values to do this.
When created in a PeekPokeTester the hashCode of these returned elements are zero

This is because the trait HasId overrides hashCode and numbers on based on state saved in the Builder DynamicVariable.
This is not properly set up when called from PeekPokeTester

So it confuses additional fields as ones already seen.
This does not happen when Bundles are instantiated within a Module

RECOMMENDATION:
I think this is a Bug, but fixing it requires some delicacy.  The issue of Chisel components being instantiated outside of a Builder context has come up before.  My inclination would be to defer this to the next release.  It may be that we can tackle this along with Bundle literals #417 and #77

This is a really tough one. This has come up before and is why in my opinion, there should not be a default dynamic context in chisel3, it should just fail if you try to construct things outside of a Chisel run.

The primary reason why bundles need to be instantiated inside the context of Chisel is that the order that the ids are assigned gives order to the fields of the Bundle. It looks like we might be able to do this better with scala reflection (https://stackoverflow.com/a/22478436/2483329). We will have to be super careful in fixing this though because Chisel uses these ids for lots of stuff so "fixing" this could have some very gnarly unintended consequences. Definitely going to require some thought.

I agree with both comments, except that I think it's a reasonable presumption that within a PeekPokeTester one is, in fact, in a chisel context.  Perhaps PeekPokeTester can take on some trait that gets it there.


Can't set focus inside debug complex hover tooltip

With accessibility mode on and tab set to move focus, I can't seem to use the keyboard to navigate to or inside the tooltip that appears when hovering over a complex object in the debugger.
Found while testing #3246

@stevencl did you try ctrl + k, ctrl + i. Can you move focus using the same keyboard shortuct to the regular, non debug hover? Can you move focus inside a simple debug hover?
This works fine for me on the mac

I didn't use Ctrl K, Ctrl I originally, wasn't aware of that. After clicking inside the tooltip with the mouse then pressing Ctrl K, Ctrl I, I am able to move focus inside the tooltip.
But, I wonder how useful this will be? By requiring the user to use the mouse to reveal the hover and then click inside it, it seems like we are not fully enabling keyboard accessibility.
Perhaps though there is another keyboard shortcut that I am not aware of that brings up the tooltip for the symbol located next to the cursor?

I think there is a misunderstanding,  ctrl k cltr i is the keyboard shortcut that brings up the tooltip for the symbol located next to the cursor. You do not need to use the mouse at all!
This keybinding also works for regular hover - same way as visual studio is doing it.
If this does not work for you please reopen the bug.

D'oh! I don't know why I didn't see this before.

No problemo, just glad we got the confusion out of the way 🐙


Bamboo shared credentials not showing up in Artifactory plugin

Describe the bug
Using the Artifactory Docker plugin with the push command, I am unable to see an option for the shared credentials dropdown.
To Reproduce
Steps to reproduce the behavior

Set up a shared credential at the root of the Bamboo project for Artifactory authentication
Create the task Artifactory Docker from the Artifactory plugin
Fill in Image Name field
Select Publishing Artifactory Server URL and target repository
Under Override Credentials select Use shared credentials
See that there is no option to select from under Shared credentials

Expected behavior
There should be an option to select the name of the shared credential that's setup in the Bamboo project settings.
Screenshots

Versions

Bamboo Artifactory plugin version: 3.3.3
Bamboo operating system: version 9.2.7
Artifactory Version: Enterprise Plus 7.59.9

Hi @stevehizmi ,
Project shared credentials are currently not supported.
You may use global shared credentials or manually override credentials.
Thank you for the feature request


Update the ABI Stability manifesto with more JIRA issue numbers.

I filed some additional JIRA issues to track tasks mentioned in the
ABI Stability manifesto. This change just updates the document with those
issue numbers.

@milseman Does this look OK to you?


verification: guard statements with module reset

Contributor Checklist

x Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

behavior change for consistency

API Impact

guards the new assert, assume and cover statements with the current default reset

Backend Code Generation Impact

this will change the Verilog to disable verification statements when reset is active

Desired Merge Strategy

squash

Release Notes
Assert, assume and cover statements are now disabled during reset by default. If you want your assertion to be active at all times, you can create a reset scope with reset=false.
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Do we treat this as a bug and backport to 4.3.x or do we treat this as a behavioral change (which it is) and only add it to the pre-release branch?

Discussed offline but this is a bug, so we're backporting


Optimization

A place with 3.5k instances was taking 10-20 seconds to load now takes ~2 seconds with these changes.

EndianAwareBitConverter LINQ code replaced
Added RobloxPropertyCache so GetProperties / GetCustomAttribute doesn't need to be called every time
Added an inverted dictionary to ReferentProvider. This increases performance but uses more memory.

I also moved the instance classes to a seperate folder from the serialization classes.

I've merged in your changes. Thanks for your contribution. The project definitely has a bit of optimization work left to do, but it looks like your changes improve performance fairly substantially.


Generating a new USER key deletes all other key for that user.

Right now it calls Stash service to purge all instead of getting list of user keys and purging specifically.
https://github.com/Libertymutual/ssh-key-enforcer-stash/blob/master/src/main/java/com/lmig/forge/stash/ssh/keys/EnterpriseSshKeyServiceImpl.java#L98
Generating a new user Key via our custom UI should only destroy existing user keys.

The changes look good especially since you're just removing my user key. Now I'm guessing this also means that by default I will be apart of that 90 day policy to change my key?

Only the ones you create in stash. Ones you create in bamboo aren't enforced right now.


Update cloud_firestore version because 0.2.6 is not derived

Issue
I got error when run flutter packages get.
Running "flutter packages get" in droidkaigi2018-flutter...
Package cloud_firestore has no versions that match 0.2.6 derived from:
- droidkaigi2018 depends on version 0.2.6
pub get failed (1)

Overview
Update cloud_firestore version (actually it used 0.2.12 in my machine)

Thank you for great suggestion @sho5nn ! and sorry for late response 🙇
I tried version 0.2.9 and it looks fine.
But I think this PR is too small to useful.
On Flutter version 0.3.1 (Dart 2.0.0-dev.48.0.flutter-fe606f890b) there are some errors in this project.
I'll send another PR to adopt flutter 0.3.1, and this PR close.


Added function to parse almost generic timestamp values for thread

Basic uint64 parsing from number or byte array is generic for all.
@jupe @terhei @JuhPuur @katariinaliehu

We lack of tests for this function. I added couple but one fails for some mysterious reason. Any change you could look at it ?


Unable to get elements within iFrame

I want to button click event for the selector which is actually inside iframe.Its always exceeds the timelimit means that the selector is not found...I am trying this one...
await page.waitForSelector('#iFrameId',{visible:true,timeout:45000});
await page.mainFrame().waitForSelector('#buttonId'); // I am getting the timelit error..
And so...Is there any way that which frame selected by page.mainFrame()??

@anandanguru
Maybe instead of page.mainFrame().waitForSelector() you could find the needed frame by iterating over page.mainFrame().childFrames() and checking frame.name() or frame.url() and then use foundFrane.waitForSelector().

I am getting null value while using frame.name()...I think its not setting  proper iframe may be...If I am using page.frames()..The selector id of iFrames is note there from the list..Any way to set Page.frames based on id???
Note : IFrame I am using which is actually in modal page..Is that any difference???

Can you provide a small code (with real page URL) which reproduces the issue?

Give a try on @schelkun solution at this post: https://github.com/GoogleChrome/puppeteer/issues/433#event-1490301931

Thanks @adrianopons ..The problem is frames are not loaded fully...#1361 solves me my solution...

consegiu resolver o problema, estou tentando fazer a mesma coisa, tendo de um modal iframe.


Error spam when using with RapierDebugRenderPlugin

I am using the latest commit of the bevy_editor_pls crate. When I add bevy_rapier's RapierDebugRenderPlugin to my app my console gets spammed with the following error.
ERROR raycast: bevy_mod_raycast: Invalid intersection check: `TriangleList` is the only supported `PrimitiveTopology`

I understand the bevy_rapier's debug lines aren't using triangle lists but why does it have to spam the console, can't it just skip it?

This is happening because an entity is marked as a raycast target, but it does not have a supported mesh to raycast against. The solution would be to remove the raycast components (RaycastMesh::<MyRaycastSet>) from entities that should not have them. Maybe this is an upstream issue with bevy_editor_pls?

The issue only happens when using bevy_rapier's debug lines which I highly doubt would have that component.

The filter here ensures that only entities with that component can be raycasted against: https://github.com/aevyrie/bevy_mod_raycast/blob/193cf2a58f594fa0ec5ff14ed5aa6d3af532967f/src/system_param.rs#L72


Add ip version specific addr/endpoint converters

Adds some ip-version specific std converter implementations to complement the existing ones. This is part of a larger effort to enable building with a mutually exclusive combination of the proto-ipv4 and proto-ipv6 features.

This is part of a larger effort to enable building with a mutually exclusive combination of the proto-ipv4 and proto-ipv6 features.

I don't understand what this means.

The other *ip and *Endpoint converters from standard library types are only enabled when both proto-ipv4 and proto-ipv6 are enabled. Thus one needs to manually unstructure the std-types and reconstruct them for smoltcp. A couple more of these instances are scattered around the library, making it needlessly hard to work with the lib when only one of the ip-versions is enabled. Also note that without the std feature, the library doesn't even build in some instances. There is no further guide other than the .travis.yml file on which feature combinations are supposed to work.

Ack. Can you write more descriptive commit messages? I don't like when the history consists of commits with confusing one-liners that explain nothing about the rationale.

@whitequark Is this the style you are looking for? If so, I suppose I will perform the same for the other set of changes.

Yep, thanks!
@m-labs-homu r+

:pushpin: Commit 6928cb1 has been approved by whitequark

:hourglass: Testing commit 6928cb19e0975749c6cdc2a562cf5bbd4dae99a2 with merge e2fcd02414236e2c3f6f2ae2aed9dce73e4c4524...

:sunny: Test successful - status-travis
Approved by: whitequark
Pushing e2fcd02414236e2c3f6f2ae2aed9dce73e4c4524 to master...


Itialize magic kitchen

This PR adds the Magic Kitchen favicons, updates the readme for dev, and finishes setting up the tools we need to see our changes in development
The example site should now show App.js:

Please check that the favicon displays correctly in the browser as well as on other devices if you can.

A more simplified web icon might be needed for browser nav bar:

A more simplified web icon might be needed for browser nav bar:

True -- let's show the team and see if folks come up with any ideas.


Division by zero

[previous exception] [object] (ErrorException(code: 0): Division by zero at /home/leafapp/deploy/releases/13/app/Models/ServiceRecord.php:59)

Looking up iiDeathKiller

Hmm, this is a private account. I haven't seen this before.


Adds a version to validator

further reads timestamps from accumulated authenticity report and
prints it in human readable form in the validation_report.txt.
Also, the signer now pass in the PTS as timestamp to the Signed
Video session.

Note that this PR can only be merged after #104 in signed-video-framework has been merged.

#104 is now on master in signed-video-framework. The apps now builds successfully.


fix: await OnBatchRunCompleteAsync in SetFail

IBatchInterceptor.OnBatchRunCompleteAsync method call is not awaited in SetFail method. Should await the call.

Oh, it is too terrible.
Thanks!


feat(tracing): Improved express tracing

…ody and added an option to filter requests

:tada: This PR is included in version 1.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Migrate to centralized GitHub workflows

What does this PR do?
This PR implements calls to "reusable workflows" housed in the salt-extensions/central-artifacts repository. This should allow us to more easily keep GitHub Actions up-to-date without requiring PRs to be opened for every extension. The proposed workflow YAML can be viewed in the central-artifacts repository, but for posterity the Push/PR and Release pipelines look something like this:

Push/PR

Automatic Processes (kicked off by push/PR)

Run pre-commit checks
Run test matrix for Linux, Windows, and macOS
Run doc build

Tag Creation

Manual Processes

Create a PR to update the CHANGELOG with towncrier
Create a tag at the merged commit above for the release version using semantic versioning (i.e. v1.0.0)

Automatic Processes (kicked off by tag creation)

Run pre-commit checks
Run test matrix for Linux, Windows, and macOS
Run doc build
Build the package
Release the package to Test PyPi (uses the saltext-community account)
Create a GitHub Release for the package
Release the package to PyPi (uses the saltext-community account)

Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.

I probably should've put this in Draft status... but here we are. Pre-commit is failing due to a problem with getting changed files via Action. I think it's because I indiscriminately updated the action version, and there's probably an output format change... Looking into it later today.

Ok. All fixed up. Let me know if you think this will work for our needs.


System settings are broken from installing ARM9LoaderHAX, can not access FBI.

My system settings are broken and I need to access FBI. Stevice10 could you use my branch of FBI to make a version of FBI that has no restrictions?

I meant fork sorry

Many people have previously requested the ability to restrict access to FBI using parental controls. The system settings being broken is a rare and unique situation, and as such does not warrant a change in this capability.


Support meta_ kwargs for Node and model.edge.add

For most data tables we accept and carry extra columns as long as they are prefixed with meta_. This is tested here and implemented on TableModel here.
With the add API redesign the Node and Edge table no longer inherit this behavior, and thus don't support extra columns. However metadata is often most relevant for these two tables.
I expect these to work and write these columns to the database. If they are not prefixed with meta_ it should error. Right now for Node it silently ignores any unknown kwargs.
from ribasim import Model, Node
from shapely.geometry import Point

Node(1, Point(3, 1), meta_a = 1)

model.edge.add(
    model.tabulated_rating_curve[1],
    model.terminal[1],
    meta_b = 2,
)

Brought up by @DanielTollenaar, who now works around this limitation by setting it directly in the underlying dataframe:
model.basin.node.df.loc[0, "meta_code"] = "test"


plumbing: use sliding window in delta calculations, like git CL

This sets a default sliding window of 10 for the delta calculation, just like git command line:
https://git-scm.com/docs/git-pack-objects#git-pack-objects---windowltngt
For a big-ish repo with 35K objects (17K commits), this reduced the time for calling deltaSelection.walk during a push from more than 14 minutes to about a minute.

Any chance to cover this with a test?

Thanks @mcuadros and @erizocosmico, added a simple test.  Ready for merge, I think.


Info - related resources update

as per https://github.com/ToTheBeginning/PuLID#paperclip-related-resources
noting one more implementation: sd.next as a built-in extension (with full credit given)

Thank you very much for your contribution. I've noticed that PuLID is currently on the SD.Next dev branch. Could you please let me know when you plan to merge it into the main branch? Then I will add it to the related resources.

dev to master merge will likely be in few days as there are still few more things i want to complete.
regarding pulid - thanks for your work, results are really good.
i've went ahead and converted it to pure diffuser pipeline so it can be used with standard call signature and with standard callbacks. as a result, it now works with realtime generate preview as well as compatible with other features like xyz grid, etc.

Thanks again for your contribution! We have updated the related resources.


Webpack error

@paulacamargo25 Do we just need to verify whether the debugger works, or do we need to try something special?
Basically can you provide some steps to verify this issue.
If its just debugging, then please add verified as I can confirm the latest version of the  debugger works.

Just that the error does not appear in the toggle developers window, in the activation of the python debugger extension.


Upgrading via Homebrew failed

Describe the bug
We upgrade mise to the latest version on CI by running brew bundle. mise is listed in Brewfile.
We started getting this error on CI a couple of days ago:
$ brew bundle
Using sonar-scanner
Upgrading mise
Error: Cannot install under Rosetta 2 in ARM default prefix (/opt/homebrew)!
To rerun under ARM use:
    arch -arm64 brew install ...
To install under x86_64, install Homebrew into /usr/local.
Upgrading mise has failed!
Homebrew Bundle failed! 1 Brewfile dependency failed to install.

looks like you're attempting to run brew under rosetta

It has been working like that since the beginning of the year.
It may be elated to the fact that we are working with GitLab CI, which runner cli doesn't support zsh.
But something changed in mise archs I believe.
Anyway, we decided to switch to recommended way of installing mise (curl ... | sh). It seems to be working.


tcproute/udproute support multiple backends

fix: https://github.com/envoyproxy/gateway/issues/3174

/retest


Add spatial_batch_norm option to resnet 50 model

Sometimes when benchmarking/testing it is useful to build a resnet model
without batch normalization. Although an option already existed it did
not pass up to the create_resnet50 function.

@akyrola Aapo, do you mind taking a look after CLA signed?

Thank you for your contribution! PyTorch and Caffe2 are now officially merged with the PyTorch 1.0 preview release. Please submit on https://github.com/pytorch/pytorch if this is still an issue over there.


Bevy should recover from WebGL Context Lost or WebGPU Device Lost

My experience described below is based on WebGL2, but apparently this is the equivalent in WebGPU: losing a device https://developer.mozilla.org/en-US/docs/Web/API/GPUDevice/lost

[...] devices can be lost at any time after creation for a variety of reasons (such as browser resource management or driver updates)

What problem does this solve or what need does it fill?
According to this MDN web spec: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/isContextLost#usage_notes

There are several reasons why a WebGL context may be lost, making it necessary to re-establish the context before resuming rendering. Examples include:

Two or more pages are using the GPU, but together place too high a demand on the GPU, so the browser tells the two contexts that they've lost the connection, then selects one of the two to restore access for.
The user's computer has multiple graphics processors (such as a laptop with both mobile and desktop class GPUs, the former used primarily when on battery power), and the user or system decides to switch GPUs. In this case, all contexts are lost, then restored after switching GPUs.
Another page running in the user's browser performs an operation using the GPU that takes too long, causing the browser to decide to reset the GPU in order to break the stall. This would cause every WebGL context to be lost throughout the entire browser.
The user updates their graphics driver on an operating system that allows graphics drivers to be updated without restarting the system.

There can be natural, expected, reasons why a graphic context in an HTML canvas can be lost, so a web-app built on top of Bevy should be able to handle these scenarios without crashing.
Other web game engines, like Babylon.js, support automatically recovering from a context lost: see here for a live example of that

This is the issue where this feature was requested for Babylon.js: https://github.com/BabylonJS/Babylon.js/issues/10163
This is the PR that implemented such feature request: https://github.com/BabylonJS/Babylon.js/pull/10173

In the case of Bevy, in any of the examples at version 0.11.3 targeting wasm, running on WebGL2, if we simulate a context lost like that, the whole Bevy app will crash. This is an example running move_sprite.rs:

What solution would you like?
Ideally, when the context is lost, Bevy should try to restore it instead of crashing. And, if it succeeds, Bevy should re-create all the previous graphic resources to the GPU (because, when the context is lost, all the graphic resources are lost too).
This seems to be what Babylon.js is doing.
What alternative(s) have you considered?
Since re-creating all the resources is a hard task, a good enough solution, at least for my use case, would be to halt all the rendering, to at least prevent the app from crashing, even if it has to keep running without graphics. This is ideal in my scenario as a fallback emergency mode to not kick the user off in the middle of a work session from other features happening on the web, that depend on the Bevy app running on the HTML canvas. As long as the simulation keeps running, they'd be fine until they're able to refresh the tab and regain the graphics.
So, a valid alternative could be to opt-in to not crash upon graphic context lost, and instead disable all the rendering. However, disabling the rendering may be coupled with this ongoing PR about separating tick updates and redraws
Additional context
Since I'm not familiar with WebGPU, I don't know how this all applies to it, or if it has any sense of losing/recovering context like WebGL2 have.
This mainly applies to WebGL2. I have seen comments suggesting that, even if in theory the graphics context should be restorable and re-creatable, in practice it isn't most of the times, requiring a full reload of the tab, and hence a full reload of the app. So, maybe WebGPU has a better way to handle this.
In my experience, I didn't even considered worth it implementing a full recover. But halting the graphics to not crash the whole app is a more than good alternative in most of the cases.
This conversation started in this Discord message.

Update, I have some good news:
I said above:

My experience described below is based on WebGL2, but apparently this is the equivalent in WebGPU: losing a device https://developer.mozilla.org/en-US/docs/Web/API/GPUDevice/lost

Since the method I was using to simulate a GL context lost was the same as Babylon.js:
document.querySelector("#my_canvas_id").getContext('webgl2').getExtension("WEBGL_lose_context").loseContext()
I was never able to check if webgpu was crashing as well when losing access to the GPU, because webgpu didn't have such extension to simulate a context loss.
I have now discovered a new way to simulate it, which works in Google Chrome: to write chrome://gpucrash/ on the address bar and press enter.
If I do that in a WebGL2 example, it crashes as usual.
But, here comes the news: if I do that in a WebGPU example, it works, the app just keep working as usual, the systems keeps running, the browser just prints a warning like GPU connection lost and the app shows a black canvas, but everything keeps working.
You can check this at the example https://bevyengine.org/examples-webgpu/Application/logs/ and see how the logs keep showing even after the GPU crash 🎉

This makes me wonder: if wgpu (or webgpu itself) is already handling such event... Wouldn't it be wgpu crate responsibility to handle WebGL2 context losses in the same way as well, to have the same functionality between the 2 web rendering backends? 🤔


Version identification is now standardized

Fixes #N.A.
Proposed Changes

version is now controlled by a single file
version identification no longer needs import GANDLF
general housekeeping

Checklist

[x] I have read the CONTRIBUTING guide
[x] My PR is based from the current GaNDLF master
[x] Non-breaking change (would not break existing functionality): if changes breaks current code, please provide as many details as possible
[x] Function/class source code documentation added/updated
[x] Code has been blacked for style consistency
[x] If applicable, version information has been updated in GANDLF/init.py
[x] If adding a submodule, add to list of expections for black styling in pyproject.toml file
[x] Usage documentation has been updated, if appropriate
[x] History has been updated, if appropriate
[x] Tests added or modified to cover the changes
[x] Integration tests passed locally by running pytest

Drafted till #76 is merged.


Add cyclobutane parameters to smirnoff99frosst

Following smirnoff99frosst issue#65 I estimated parameters for angles in 4-membered rings.

I'd like Chris to take a look at my issue first ideally.
@davidlmobley I added a more thorough check to the convert_frcmod script that checks that the smirks string matches the section instead of just that it is parseable.

Chris also approved these changes so I think we're good to go, @davidlmobley if you agree can you merge it since I added another commit after your review.

Excellent. And the additional change/check looks great. Thanks, @bannanc !

@bannanc - can you do a new release here and on openforcefield?

(And note the updated version of this needs to get into the openforcefield repo.)


add an indication that more rooms can be found by swiping right

as it is not always obvious depending on the device resolution, e.g. in https://matrix.org/_matrix/media/v1/download/matrix.org/XwmHUAuKDmbUgNFEabKtWuCB  Maybe add an arrow or something.  See discussion starting at around https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15130082454748470vWaQC:matrix.org

Let me add here:
Would you add an option to list users and rooms not in this (current) way...
PEOPLE
1 2 3 4 5 6 7 8 9 10

ROOMS
A B C D E F G H I J

...but in this way:
PEOPLE
1 2 3 4 5
6 7 8 9 10

ROOMS
A B C D E
F G H I J

...so that all PEOPLE and ROOMS listed in more than one horizontal line so that the user is not forced to scroll horizontally?
The current way (at least in Riot F-Droid v0.7.03) is quite confusing because users are more used to scroll vertically (as they are used to do reading a chat: scrolling vertically). More than one time people asked me: where are my contacts and rooms adding more and more contacts).
Thx!

Requested again in https://github.com/vector-im/riot-android/issues/2297 because this issue was closed.


fix: show the search modal correctly

the search modal shows incorrectly in mobile when the page was scrolled down, so i found the problem what it cause.
@media (max-width: 750px) {
  .DocSearch-Container{
    position: absolute;
  }
}

👇👇👇
@media (max-width: 750px) {
  .DocSearch-Container{
    position: fixed;
  }
}

keeping the default css can solve this problem.

Oops, thanks for catching it, didn't be aware of that.
I wonder if this issue only occurs in our default theme?

If it's a default-theme-only bug, we'd better fix the style of default theme instead.
If it's a common bug, we'd better submit a PR to the docsearch repo directly.

this issue happened in my theme and I already fixed it.

Oops, thanks for catching it, didn't be aware of that.
I wonder if this issue only occurs in our default theme?

If it's a default-theme-only bug, we'd better fix the style of default theme instead.
If it's a common bug, we'd better submit a PR to the docsearch repo directly.

All right...maybe i need to revoke this issue~it's DocSearch's problem.


FormArrayExtended incorrectly applied

FormArrayExtended are incorrectly applied in the form service when the endpoint expects an array of strings. It should be a basic FormControl instead.

Any quick fix, while the issue isn't resolved.


support gRPC

I wonder when bfe can support gRPC ??? need this feature.

@lhtlp1997 bfe will support gRPC in next two month.


Fix Race Condition in s_client Python Integ Tests

Issue # (if available): https://github.com/awslabs/s2n/issues/1014
Description of changes:
This PR removes an existing race condition in the s2n_handshake_test_s_client.py integration tests, and removes all existing sleep() calls that attempt to make the race conditions less likely to happen.
First Draft PR: https://github.com/awslabs/s2n/pull/1016 which is now discarded since that wasn't the long term solution.
The problem is that Python's SubProcess communicate API is one-shot and only works after killing the process and gets all the stdin/stdout at once, but we don't know how long to wait before killing the process to read it's output. Python's other API to read the stdin/stdout line by line has a known deadlock that we've run into in the past that causes Integration tests to hang if too much data is written too quickly and fills up the OS's IO buffers. We aren't writing a lot of data in these integration tests, so it should be safe to make this change here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1017 into master will increase coverage by 1.44%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage      85%   86.44%   +1.44%
==========================================
  Files         164      164
  Lines       15580    15586       +6
==========================================
+ Hits        13243    13473     +230
+ Misses       2337     2113     -224


Upgraded service leaves linked service connected to most recently upgraded container

Versions
Component	Version
Rancher	v0.56.1
Cattle	v0.141.1
User Interface	v0.86.0
Rancher Compose	v0.7.1
Issue
We have two services running on two servers. One service ("the sender") forwards messages to another service ("the worker") via container link. There is one instance of each service running on each server.
With previous versions of Rancher, each "sender" container would automatically link to the "worker" container that was on its same physical host. A "start first" upgrade to "the sender" would end up re-linking the containers in the same way, so the "worker" on server 1 would forward messages to the "sender" on server 1, and the same with server 2.
However with 0.56.1, we have noticed that a "start first" upgrade to "the worker" would end up leaving each "sender" connected to the most recently upgraded "worker" container. In the most recent case, both "senders" were forwarding messages to the "worker" on server 2 because it was the last to start. (I am ~90% sure of the start order, so I could be wrong, but it seems reasonable that the order would affect things)
By performing a subsequent upgrade to the "sender" service, the containers were re-linked according to their physical host.
I'm able to reproduce this with 100% accuracy so I can give you more information if you need.
Thanks,
Jason

Do you have a docker-compose.yml that I could try? I'm not quite sure I understand what you're saying.
Service Foo is linked to Service Bar.
Any container in service Foo should be linked to any container in service bar (Regardless of host placement).

Here's a diagram:
How it should be/how it starts
[SERVER 1]                [SERVER 2]
[    sender  ]                 [    sender  ]
          |                                 |
          |                                 |
          |                                 |
[   worker   ]                 [   worker   ]

How it ends up after upgrade:
[SERVER 1]                [SERVER 2]
[    sender  ]                 [    sender  ]
          \_______________         |
                                          \       |
                                           |      |
[   worker   ]                 [   worker   ]

The compose file is basically. There are 2 servers with service=cache label.
sender:
  labels:
    io.rancher.scheduler.global: 'true'
    io.rancher.scheduler.affinity:host_label: service=cache
  tty: true
  image: dispatch/worker:<hash>
  links:
  - my-stack:worker
  stdin_open: true
worker:
  labels:
    io.rancher.scheduler.global: 'true'
    io.rancher.scheduler.affinity:host_label: service=cache
  tty: true
  image: dispatch/sender:<hash>
  stdin_open: true

(diagram didn't work so well - I'm figuring out a different way)

FWIW, nothing has changed between v0.51.0 and v0.56.1 in regards to linking.
For DNS resolution, it has always been all containers of sender would be resolvable to all containers of worker. So with your docker-compose.yml
server1_sender would have dns resolution to server1_worker AND server2_worker
server2_sender would have dns resolution to server1_worker AND server2_worker
What are you trying to achieve with the links?

OK, good to know. I suppose we are looking for what sidekicks theoretically give us. I notice there's no way in the UI to set up the linking and alias between the sidekick and the main container - is there a way to do this in the compose file?

Just to clarify, what are you expecting to happen with the linking? DNS resolution or environment variable?

It seemed to me that in the past there was automatic resolution to a container on the same physical host if it existed (e.g. our servers linked to the DataDog agent service, which runs on every server, seem to be connecting to the container on their same physical host. I will verify). That might not be the case, but that's essentially what we're trying to achieve. Something similar to load balancing because we don't want 1 worker processing the messages from 2 senders.

For DNS resolution, there have been no changes. I just did another test (without even upgrading).
foo:
  labels:
    io.rancher.scheduler.global: 'true'
    io.rancher.container.pull_image: always
  tty: true
  image: ubuntu:14.04.3
  links:
  - bar:foobar
  stdin_open: true
bar:
  labels:
    io.rancher.scheduler.global: 'true'
    io.rancher.container.pull_image: always
  tty: true
  image: ubuntu:14.04.3
  stdin_open: true

If you exec into any of the foo containers and ping foobar, the first container that was chosen was on another host.
I'm going to close as there is no error here.

OK, fair enough. Is there a way to enforce resolution like that?

You would need a scale of 1 for both services and then have each individual host have a set of these services.

Got it. Thanks.


IGNITE-13197: Import order rule added.

PR  contains new checkstyle rule to check import order according to Ignite Code Style.
IntelliJ IDEA setup to match the check
The Contribution Checklist

[ ] There is a single JIRA ticket related to the pull request.
[ ] The web-link to the pull request is attached to the JIRA ticket.
[ ] The JIRA ticket has the Patch Available state.
[ ] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[ ] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[ ] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

Could we create an XML checkstyle for IDEA or something else to make automatic refactoring?

@zaleslaw If you setup IDEA equal to screenshot then it will automatically rearrange imports according to codestyle(Code -> Optimize imports). All new imports will goes to the right place, also.

So, I agree, but for newcomers it's a good point to have automatic
checkstyle with all possible rules. I had one a year ago, but it doesn't
cover all cases.
If you have one, please let me know
вт, 30 июн. 2020 г. в 17:51, Nikolay<EMAIL_ADDRESS>
@zaleslaw https://github.com/zaleslaw If you setup IDEA equal to
screenshot https://yadi.sk/i/kyXSE5rDc3ePOA then it will automatically
rearrange imports according to codestyle(Code -> Optimize imports). All new
imports will goes to the right place, also.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/ignite/pull/7978#issuecomment-651844608, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJEUHNJ7FV5IB45BJM5FWLRZH3XJANCNFSM4OMJAKYQ
.

@zaleslaw We have automation in the form of maven checkstyle profile. The goal of this PR is to extend the coverage of automatic checks with the automatic Import Order rule. AFAIK checkstyle+maven is common solution and used in many other open-source projects.
Do you have in mind some other kind of automation?

No automation, maybe it sounds wrong earlier: I suggest only shared
community checkstyle.xml for using in IDEA (somebody shared one with me a
few year ago, but now I lost it after moving on another laptop)
вт, 30 июн. 2020 г. в 18:03, Nikolay<EMAIL_ADDRESS>
@zaleslaw https://github.com/zaleslaw We have automation in the form of
maven checkstyle profile. The goal of this PR is to extend the coverage
of automatic checks with the automatic Import Order rule. AFAIK
checkstyle+maven is common solution and used in many other open-source
projects.
Do you have in mind some other kind of automation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/ignite/pull/7978#issuecomment-651852109, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJEUHNA5SIT2MDO5HCHFUTRZH5D5ANCNFSM4OMJAKYQ
.

We have this file and it updated in PR.
Changes in settings.xml is the essence of PR

Great, look like I missed the xml and saw only reordered  imports  in files
вт, 30 июн. 2020 г. в 18:16, Nikolay<EMAIL_ADDRESS>
We have this file and it updated in PR.
Changes in settings.xml is the essence of PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/ignite/pull/7978#issuecomment-651860372, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJEUHOZEN72MYK4I5PQ5W3RZH6WTANCNFSM4OMJAKYQ
.

@nizhikov I see that travis build check failed and it seems that it is related to the import order rule (https://travis-ci.org/github/apache/ignite/builds/703548289?utm_source=github_status&utm_medium=notification). Could you please take a look?


Wise: PROCESSING activity should include ETA

We recently merged a feature that allows us to render detailed messages on thread activities.
Since we've been receiving some support tickets about delayed/slow transactions when paying to certain countries using specific methods, I think we could use the PROCESSING expense activity to display some information about the ETA of the transaction.

[ ] Include existing Expense.data.quote.estimatedDelivery ETA information when setting the Expense as processing (Activity.data.message).

I was thinking about this recently, would be awesome.


fix issue 27333

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/27333
PROPOSAL: https://github.com/Expensify/App/issues/27333#issuecomment-1717491070
Tests

Open the app from two diffrent browsers.
Login with userA in first browser and userB in the second.
From userA start chat with userB
From userA click icon (+) -> Request money -> scan, then select a not valid receipt image eg: avatar image.
select UserB and confirm the request.
wait till the scan fails and errors.
From UserA open the request transaction and Verify that the amount filed have the "Enter an amount" error.
From UserB open the request transaction and Verify that the amount filed not have the "Enter an amount" error.

[x] Verify that no errors appear in the JS console

Offline tests
N/A.

QA Steps
Same as Tests step.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/41129870/86ea2df3-234b-4465-95f6-7925c6f08895

Mobile Web - Chrome
https://github.com/Expensify/App/assets/41129870/030a705f-88c5-4b5f-8f7b-dfd6adedb00e

Mobile Web - Safari
https://github.com/Expensify/App/assets/41129870/673b0337-119c-4d28-a67c-8a7d658d154f

Desktop
https://github.com/Expensify/App/assets/41129870/439ef320-d5bf-473d-87e9-59779b53132a

iOS
https://github.com/Expensify/App/assets/41129870/2b576b28-4ce7-4f83-9c79-ed7df336225c

Android
https://github.com/Expensify/App/assets/41129870/e901ac1c-ea4f-4980-8f4d-573161604331

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Channel Waiting Close with transaction not broadcast and cannot force close

Background
This is similar, perhaps identical, to issue https://github.com/lightningnetwork/lnd/issues/5341 .  If I should talk about it there instead please let me know.
I am trying to close a channel and unable to do so.  I used the web interface RTL to try to close it, and it is now in the Wait Closing Channel state but has been for many hours.
When I open up the  "Wait Closing Channel Information" it shows me a transaction ID, but this transaction is not visible in mempool.space and not visible in my local mempool.
I've been in similar situations before because the two nodes I have set up never seem to work.  Therefore I have experience opening, closing, force closing channels.
But in the previous cases I could force close using the channel point to get another transaction broadcast, but this time it doesn't work so I'm stuck.
Your environment

lnd version 0.13.0-beta commit=v0.13.0-beta
Microsoft Windows [Version 10.0.19043.1110]
Bitcoin Core RPC client version v0.21.1

Here are all the pending channels; the problematic one is the one with node 03858f3b77447b572733e6e888cbbf36b8bc8483bb9716041953bb284495655522
lnd\lncli pendingchannels
{
    "total_limbo_balance": "19251",
    "pending_open_channels": [
    ],
    "pending_closing_channels": [
    ],
    "pending_force_closing_channels": [
        {
            "channel": {
                "remote_node_pub": "035e4ff418fc8b5554c5d9eea66396c227bd429a3251c8cbc711002ba215bfc226",
                "channel_point": "a0738545c608cb8914b3d9e88b99a4ffa50e1320e4cc9c84bc5280a6c6ff10ec:0",
                "capacity": "20000",
                "local_balance": "19251",
                "remote_balance": "0",
                "local_chan_reserve_sat": "0",
                "remote_chan_reserve_sat": "0",
                "initiator": "INITIATOR_LOCAL",
                "commitment_type": "STATIC_REMOTE_KEY"
            },
            "closing_txid": "265e0ace57ff389b87b7a72cca1e2306fd5c5498747f15d65514229841dedf81",
            "limbo_balance": "19251",
            "maturity_height": 692225,
            "blocks_til_maturity": 139,
            "recovered_balance": "0",
            "pending_htlcs": [
            ],
            "anchor": "LIMBO"
        }
    ],
    "waiting_close_channels": [
        {
            "channel": {
                "remote_node_pub": "03858f3b77447b572733e6e888cbbf36b8bc8483bb9716041953bb284495655522",
                "channel_point": "ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1",
                "capacity": "20000",
                "local_balance": "0",
                "remote_balance": "19401",
                "local_chan_reserve_sat": "573",
                "remote_chan_reserve_sat": "573",
                "initiator": "INITIATOR_REMOTE",
                "commitment_type": "STATIC_REMOTE_KEY"
            },
            "limbo_balance": "0",
            "commitments": {
                "local_txid": "4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec",
                "remote_txid": "39385b480d12e62f202072864549b866233124b601273352b46de56188e4ab53",
                "remote_pending_txid": "",
                "local_commit_fee_sat": "599",
                "remote_commit_fee_sat": "599",
                "remote_pending_commit_fee_sat": "0"
            }
        }
    ]
}

I have already reached out to the operator of that node, advised him of the situation, and suggested he force close from his end.  If that works then this is academic from my perspective, but perhaps useful data to see a stuck case??
The problematic channel mentioned above has two transactions mentioned;
"4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec",
                "remote_txid": "39385b480d12e62f202072864549b866233124b601273352b46de56188e4ab53"

I can't see these in mempool.space.  I also can't see the local one in the local mempool.
bitcoin-cli.exe" getmempoolentry 4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec
error code: -5
error message:
Transaction not in mempool

Steps to reproduce
lnd\lncli closechannel ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972 1 --force

Expected behaviour
After doing lncli closechannel it should reply almost immediately with the tx id of a new transactioni
Actual behaviour
I try to force close but after 8 hours nothing has happened so I press ctrl-C and it looks like this:
lnd\lncli closechannel ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972 1 --force
[lncli] rpc error: code = Canceled desc = context canceled

What do you see in the logs while attempting to force close (possibly grepping for the outpoint TXID)?

The channel finally closed, I don't know why.  Therefore the problem is 'solved'.
I did search at the logs and cannot see anything in them about the closing TX until the point at which it was successful a few hours ago, at which point it all looks normal.
There is no trace of the failed attempt to force close, at least not including the TX ID.
As it is already closed I can't try again to repro the issue.
log of the eventual successful force close, with a couple of minutes either side, is included below.
I'll keep the logs for reference by otherwise this node I'll be disconnecting as it never worked right.
Thank you for your time.  I presume this issue can be closed now.

2021-07-22 13:53:08.973 [WRN] BTCN: Query(928) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:08.973 [WRN] BTCN: Query(928) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:53:08.974 [INF] CRTR: Processed channels=1 updates=0 nodes=0 in last 8m51.7183261s
2021-07-22 13:53:12.987 [WRN] BTCN: Query(928) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:20.998 [WRN] BTCN: Query(928) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:22.715 [INF] WTCL: (legacy) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:53:22.715 [INF] WTCL: (anchor) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:53:37.003 [WRN] BTCN: Query(928) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:44.005 [WRN] BTCN: Query(929) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:44.005 [WRN] BTCN: Query(929) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:53:48.012 [WRN] BTCN: Query(929) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:53:56.026 [WRN] BTCN: Query(929) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:12.032 [WRN] BTCN: Query(929) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:14.699 [WRN] BTCN: Query(930) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:14.699 [WRN] BTCN: Query(930) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:54:18.713 [WRN] BTCN: Query(930) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:22.721 [INF] WTCL: (anchor) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:54:22.721 [INF] WTCL: (legacy) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:54:26.730 [WRN] BTCN: Query(930) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:40.830 [INF] CRTR: Processed channels=2 updates=0 nodes=0 in last 1m31.8563685s
2021-07-22 13:54:42.313 [WRN] BTCN: Query(931) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:42.313 [WRN] BTCN: Query(931) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:54:46.324 [WRN] BTCN: Query(931) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:54:54.326 [WRN] BTCN: Query(931) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:04.517 [INF] CRTR: Processed channels=1 updates=1 nodes=0 in last 23.6858219s
2021-07-22 13:55:04.540 [WRN] CNCT: Unable to disable channel a0738545c608cb8914b3d9e88b99a4ffa50e1320e4cc9c84bc5280a6c6ff10ec:0 on close: edge not found
2021-07-22 13:55:04.540 [ERR] RPCS: unable to force close transaction: channel is already in the process of being force closed
2021-07-22 13:55:04.541 [ERR] RPCS: [/lnrpc.Lightning/CloseChannel]: channel is already in the process of being force closed
2021-07-22 13:55:04.567 [INF] CNCT: ChannelArbitrator(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): force closing chan
2021-07-22 13:55:04.571 [INF] HSWC: Removing channel link with ChannelID(72c96520298d20a8e1d2fb6ceee66d0997b2febae82872ad135f4b45e5db62cb)
2021-07-22 13:55:04.585 [INF] CNCT: Broadcasting force close transaction 4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec, ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): (*wire.MsgTx)(0x17217c40)({
 Version: (int32) 2,
 TxIn: ([]*wire.TxIn) (len=1 cap=1) {
  (*wire.TxIn)(0x17e2f480)({
   PreviousOutPoint: (wire.OutPoint) ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1,
   SignatureScript: ([]uint8) <nil>,
   Witness: (wire.TxWitness) (len=4 cap=4) {
    ([]uint8) <nil>,
    ([]uint8) (len=72 cap=144) {
     00000000  30 45 02 21 00 e7 95 c0  ff 9a 85 61 f2 59 39 3c  |0E.!.......a.Y9<|
     00000010  1d 84 55 5b b8 65 60 49  ac 9b a2 e3 f7 e9 1d a7  |..U[.e`I........|
     00000020  b5 b9 74 7f 82 02 20 37  15 71 dc 45 be 71 67 4b  |..t... 7.q.E.qgK|
     00000030  a1 05 24 60 cd 9d d5 d8  bc cf 44 55 b5 46 8f cc  |..$`......DU.F..|
     00000040  ea 1f be 76 b2 67 0c 01                           |...v.g..|
    },
    ([]uint8) (len=71 cap=144) {
     00000000  30 44 02 20 24 65 08 c3  f4 fd 3d ee 66 c3 cd 55  |0D. $e....=.f..U|
     00000010  a0 be bf 1d aa ef c2 b1  6c cc 6c 18 ce 8b 9d b7  |........l.l.....|
     00000020  cb 5a eb 2a 02 20 16 dc  49 d2 8f 7a 14 b4 e2 87  |.Z.*. ..I..z....|
     00000030  9b 83 97 e0 9b 01 0c 3b  6f 09 be dc 1f 96 ad c9  |.......;o.......|
     00000040  33 e1 bc bd c8 10 01                              |3......|
    },
    ([]uint8) (len=71 cap=500) {
     00000000  52 21 02 88 f2 f0 0c 2d  ff b0 34 cf 81 be 16 6e  |R!.....-..4....n|
     00000010  a1 ca 0a 57 48 24 93 01  80 ee a6 2d ad 6e 28 9e  |...WH$.....-.n(.|
     00000020  16 82 11 21 03 8e 06 90  48 93 76 85 16 c3 c0 55  |...!....H.v....U|
     00000030  10 a8 a8 59 9f 14 2d 70  7a 47 c5 ea 16 d6 e3 ce  |...Y..-pzG......|
     00000040  4e 7a eb 41 f2 52 ae                              |Nz.A.R.|
    }
   },
   Sequence: (uint32)<PHONE_NUMBER>
  })
 },
 TxOut: ([]*wire.TxOut) (len=1 cap=1) {
  (*wire.TxOut)(0x19862978)({
   Value: (int64) 19401,
   PkScript: ([]uint8) (len=22 cap=22) {
    00000000  00 14 e1 ab 13 56 9e 83  a2 bb 7b 4b 62 51 3d 8a  |.....V....{KbQ=.|
    00000010  0d c2 f8 5b c5 a0                                 |...[..|
   }
  })
 },
 LockTime: (uint32) 543292726
})

2021-07-22 13:55:04.589 [INF] LNWL: Inserting unconfirmed transaction 4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec
2021-07-22 13:55:04.621 [INF] CNCT: ChannelArbitrator(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): trigger userTrigger moving from state StateCommitmentBroadcasted to StateCommitmentBroadcasted
2021-07-22 13:55:04.622 [ERR] RPCS: unable to force close transaction: channel is already in the process of being force closed
2021-07-22 13:55:04.622 [ERR] RPCS: [/lnrpc.Lightning/CloseChannel]: channel is already in the process of being force closed
2021-07-22 13:55:04.622 [INF] PEER: Waiting for confirmation of cooperative close of ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1) with txid: 4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec
2021-07-22 13:55:04.622 [INF] NTFN: New confirmation subscription: conf_id=5, txid=4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec, num_confs=1 height_hint=692022
2021-07-22 13:55:04.622 [ERR] RPCS: [/lnrpc.Lightning/CloseChannel]: rpc error: code = Internal desc = transport: transport: the stream is done or WriteHeader was already called
2021-07-22 13:55:05.990 [WRN] BTCN: Query(932) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:05.990 [WRN] BTCN: Query(932) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:55:10.007 [WRN] BTCN: Query(932) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:17.596 [INF] NTFN: New block: height=692112, sha=0000000000000000000c4d06c0574664d66862964bc20c7a86d98dad3511c62d
2021-07-22 13:55:17.597 [INF] UTXN: Attempting to graduate height=692112: num_kids=0, num_babies=0
2021-07-22 13:55:18.016 [WRN] BTCN: Query(932) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:22.713 [INF] WTCL: (legacy) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:55:22.713 [INF] WTCL: (anchor) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:55:28.053 [WRN] BTCN: Query(933) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:28.053 [WRN] BTCN: Query(933) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:55:28.053 [INF] CRTR: Pruning channel graph using block<PHONE_NUMBER>000000000c4d06c0574664d66862964bc20c7a86d98dad3511c62d (height=692112)
2021-07-22 13:55:28.065 [INF] CRTR: Block<PHONE_NUMBER>000000000c4d06c0574664d66862964bc20c7a86d98dad3511c62d (height=692112) closed 0 channels
2021-07-22 13:55:32.060 [WRN] BTCN: Query(933) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:40.078 [WRN] BTCN: Query(933) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:50.558 [WRN] BTCN: Query(934) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:55:50.558 [WRN] BTCN: Query(934) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:55:54.576 [WRN] BTCN: Query(934) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:02.579 [WRN] BTCN: Query(934) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:16.811 [WRN] BTCN: Query(935) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:16.812 [WRN] BTCN: Query(935) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:56:20.820 [WRN] BTCN: Query(935) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:22.725 [INF] WTCL: (anchor) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:56:22.725 [INF] WTCL: (legacy) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2021-07-22 13:56:28.835 [WRN] BTCN: Query(935) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:41.290 [INF] NTFN: New block: height=692113, sha=000000000000000000091daa74693f4fe0c643babbc8c4560e938d865816f2c7
2021-07-22 13:56:41.291 [INF] NTFN: Dispatching 1 confirmation notification for txid=4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec
2021-07-22 13:56:41.291 [INF] UTXN: Attempting to graduate height=692113: num_kids=0, num_babies=0
2021-07-22 13:56:41.292 [INF] NTFN: Dispatching confirmed spend notification for outpoint=ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1, script=0 9e74c413d69da1f157d2183ddd9c80ab6c71e2b92102cb72e1237a047d98de9b at current height=692113: 4797a8f2ddeab9c459fce84502ea6a610bbd128243a9148812486ee16adac5ec[0] spending ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1 at height=692113
2021-07-22 13:56:41.292 [INF] PEER: ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1) is now closed at height 692113
2021-07-22 13:56:41.293 [INF] CNCT: Local unilateral close of ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1) detected
2021-07-22 13:56:41.294 [INF] CNCT: ChannelArbitrator(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): local on-chain channel close
2021-07-22 13:56:41.391 [INF] CNCT: ChannelArbitrator(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): trigger localCloseTrigger moving from state StateCommitmentBroadcasted to StateContractClosed
2021-07-22 13:56:41.391 [INF] CHBU: Updating on-disk multi SCB backup: num_old_chans=1, num_new_chans=0
2021-07-22 13:56:41.391 [WRN] CHFT: could not remove channel: channel: ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1 not present
2021-07-22 13:56:41.397 [INF] CHBU: Updating backup file at C:\Users\raymo\AppData\Local\Lnd\data\chain\bitcoin\mainnet\channel.backup
2021-07-22 13:56:41.400 [INF] CHBU: Swapping old multi backup file from C:\Users\raymo\AppData\Local\Lnd\data\chain\bitcoin\mainnet\temp-dont-use.backup to C:\Users\raymo\AppData\Local\Lnd\data\chain\bitcoin\mainnet\channel.backup
2021-07-22 13:56:41.405 [INF] CNCT: ChannelArbitrator(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1): contract resolutions empty, marking channel as fully resolved!
2021-07-22 13:56:41.424 [INF] CNCT: ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1) has been fully resolved on-chain at height=692113
2021-07-22 13:56:41.424 [INF] CNCT: Marking ChannelPoint(ca62dbe5454b5f13ad7228e8bafeb297096de6ee6cfbd2e1a8208d292065c972:1) fully resolved
2021-07-22 13:56:41.425 [INF] CHDB: Pruning link node 03858f3b77447b572733e6e888cbbf36b8bc8483bb9716041953bb284495655522 with zero open channels from database
2021-07-22 13:56:41.543 [WRN] BTCN: Query(936) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:41.543 [WRN] BTCN: Query(936) failed with error: did not get response before timeout. Timing out.
2021-07-22 13:56:41.543 [INF] CRTR: Pruning channel graph using block<PHONE_NUMBER>00000000091daa74693f4fe0c643babbc8c4560e938d865816f2c7 (height=692113)
2021-07-22 13:56:41.546 [INF] CHDB: Pruned unconnected node 03858f3b77447b572733e6e888cbbf36b8bc8483bb9716041953bb284495655522 from channel graph
2021-07-22 13:56:41.546 [INF] CHDB: Pruned 1 unconnected nodes from the channel graph
2021-07-22 13:56:41.558 [INF] CRTR: Block<PHONE_NUMBER>00000000091daa74693f4fe0c643babbc8c4560e938d865816f2c7 (height=692113) closed 1 channels
2021-07-22 13:56:45.551 [WRN] BTCN: Query(936) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout
2021-07-22 13:56:53.564 [WRN] BTCN: Query(936) from peer <IP_ADDRESS>:8333 failed, rescheduling: did not get response before timeout

I'm guessing you might've hit a longer timeout with the neutrino backend during broadcast of the initial force close transaction.


Add option to disable file watcher

Added --watch true/false and --watchIgnore <filepatterns...> options


Bug fix: Validate channel name according to pusher docs

I have never done elixir before, so please let me know if I need additional test coverage anywhere.
closes #33

Thanks for the PR :heart: ! The function had just 3 tests as part of the doctests and now we will have a good amount of tests :+1:.
I added just a comment but other than that it's good to go!

No problem, thanks for being so responsive! I just fixed that test name.

Thanks for the contribution! I will release a new minor version this week! :tada:

Great, thanks! :beers:


Re designing the rentalogin

Re designing the home page of the rentalogin and adding scroll down option instead of taking it to the diffirent page and adding images to the site for better feel and interactive interface and changing the design of button used here.

something like this.

Congratulations, @Aazib-at-hub! 🎉 Thank you for creating your issue for Rentalog. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work! Should you have any queries or require guidance, do not hesitate to ask.

shall i start working.

I’ve been reviewing the current design of the Rentalogin page, and I believe a redesign could greatly enhance its usability and appeal. Improving the visual layout and user flow could make the login process more intuitive and engaging, which would benefit users by providing a smoother experience. I would love to take on the task of redesigning the Rentalogin page to make it more modern and user-friendly. Could I be assigned this task?

Hey @RIYA-YADAV-19 @Aazib-at-hub, you can both work on this issue together. I'll choose the design that I find better.

Hey @RIYA-YADAV-19 @Aazib-at-hub, you can both work on this issue together. I'll choose the design that I find better.

I will do it surely, Thank You for Considering me for this opportunity.

Hey @RIYA-YADAV-19 @Aazib-at-hub, you can both work on this issue together. I'll choose the design that I find better.

Thanks for the opportunity, hope to get it very soon.

I have completed #196 #197 #198 #199 @gauravsingh1281


PTZ continuous motion causes exception on Bosch cameras

I have a Bosch camera that will not respond to a PTZ continuous move request. I looked at the low-level response from the camera and it is complaining that "timeout is an unsupported field". I need a way to send a continuous move request without the timeout field. I looked through the current code but nothing jumped out at me providing a way to do this.

I'm not sure whether these works are effective.
Anyway, try this branch https://github.com/Jazea/Onvif.Core/tree/Issues30,
and set timeout(argument or property..) to null
e.g.
await camera.MoveAsync(moveType: MoveType.Continuous, vector: ptzVector,  speed: ptzSpeed, timeout: null)

Thanks! I will set up the camera and give this a try.

That worked quite well and fixed the problem, thank you!


8BitDo USB Dongle for Xbox One controllers not detected until physically unplugged and plugged back in

When rebooting or powering on the system from a complete shutdown state, the PC will not detect the dongle and controller inputs won't work until the dongle is physically unplugged and plugged back in. The controller is pairing to the dongle just fine when this happens.

Same here with the Microsoft dongle, but not every time.
Do you have connected the dongle to the mainboard or to the front IO?

Can you verify this issue still exists on v45 stable release?

This is still the case for me on the latest release. Not OP but this happens every shut down. Fine on reboots if already gone through unplug and plug back in sequence.


use the default/shared computation scheduler from RxJava. there is no ne...

...ed to create a dedicated thread for each metric reporter. also we may create multiple producers for each app. then we would create multiple threads for metric reporter. this was just unnecessary.

suro-pull-requests #225 SUCCESS
This pull request looks good

NetflixOSS » suro » suro-pull-requests #57 ABORTED


Fixing an issue with the member creation on server subnet.  This subnet

@mattgreene @jlongstaf @dflanigan @zancas
What's this change do?
We have 2 problems with the test_solution traffic test.

The member creation mismatches the ip_address and subnet.  That is it creates a member with an IP on the client subnet, but specifies the server subnet name.  This is incorrect for a one armed test.  I tested that this works when I create a 2 armed test setup, but extra work is necessary on the server side to make the server routable.

The other issue that I fix with this commit is that I add the ability to specify a longer delay in the neutron client library for polling.  There is an issue where we continuously delete objects if they have not been deleted.

Where should the reviewer start?
Test_solution.py
Any background context?
should contain the member ip address.
Adding an option to increase the latency on operations in the neutron client
in the openstack-test repo.
remove server server ip

@richbrowne In test/functional/test_env.json I think you need a ','  after the "v3" line.


Correction on OperationId names in azure resourcehealth swagger

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

This has been reviewed and pushed to pr branch.
https://github.com/Azure/azure-rest-api-specs-pr/pull/62
This is new swagger file we pushed yesterday only. This is a small correction that i missed to do in last push.

No modification for NodeJS

No modification for Ruby

No modification for Python


07/05/2018 19:14 : Create Pull Request for branch master -> prTesting1_2018070519

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: TypeError, we need always to 'init' unified list

Connects to #163

Coverage remained the same at 89.226% when pulling 61607e22096d9c069bf23e9f7db4eb2c35564dcc on helio-frota:lr-163 into 3c5f9ee8cd34cb501d17775c5039256dee123698 on bucharest-gold:master.


Will it be continued?

Hello :)
we are using your plugin excessively and are wondering if this project will be continued,
since epic now made their own Python support, as we all know.
Can you provide us any foresight?
We of course hope, that it will last!
Sebi

Hi, 20tab stopped investing in the project months ago (for obvious reasons). There are a bunch of companies paying for specific features that combined with my personal needs should keep the project more-or-less alive (but with a slower development cycle). Currently the epic plugins covers less than 10% of what this plugin does so it makes perfectly sense to continue it as a way for creating plugins, extensions and runtime-features in python. The 20tab's objective is to "sell" the project to another company willing to sponsor my effort. So if anyone want to do it, drop a mail to info at 20tab.com :)

I've sent an expression of interest, let see what happens.

After two weeks and some emails, got no answer (I tried also to contact Ikrima Elhassan)
Maybe we should start thinking about UEPython with a different approach.

@yobiminds I do not know if you are one of the companies/professionals that offered support in the past days. As i wrote via email, i am waiting for Epic to make a final decision on the future of the project. I should have a call with them in the next few days.

@rdeioris Yep (Roberto C.). Sorry, I didn't get any replay, but I am happy to hear that things are somehow in progress. Will wait in suspense. 👍

Hello, is there an update on this?

@RockShea nope, i continue porting the plugin to the latest ue versions (4.23 is upcoming), but maybe it is better to drop a mail to epic directly to inform them about your interest in the project

I did mention your plugin in my proposal for Epic MegaGrants.

I submitted to Mega Grants too. The idea is to buy the plugin from 20tab (the old owner) and continue the development by focusing on integration with the epic effort (to avoid code duplication in the python plugin core)

Awesome! Thanks for the update; I'm following this with interest. We'd love to see UE4 support (a) modern Python and (b) usable at runtime, both of which are lacking in the engine right now, so this plugin has filled a big void for us.
It'd be terrific if they stepped in to support it in some capacity, so please let me know if there is any way we can help lobby / petition / nag Epic. :)

Any updates on this?  I'd definitely like to see this project continue, primarily for being able to script gameplay

@darrickyee still waiting for Mega Grant response. Pinging Epic should help too ;)

I'd be happy to nag them.  Can someone suggest the best way to do that?


Removed the superflous "line" argument

The nodegit git_diff_hunk_cb wrapper had a definition for a line argument that is not present in the libgit2 API:
https://libgit2.github.com/libgit2/#HEAD/group/callback/git_diff_hunk_cb
This PR removes that line argument.

Yep, definitely gone: https://github.com/libgit2/libgit2/blob/HEAD/include/git2/diff.h#L436-439

Awesome, thanks!


[Hackathon] We should be able to resize panels

Is your feature request related to a problem? Please describe.
We often cannot see the whole names of triggers because the left panel is too narrow:

Describe the solution you'd like
We should be able to adjust the size of panels.
Describe alternatives you've considered
Scrollbars could be an alternative.

To implementer:

Allow resizable panes for left nav, flow editor, form editor. Serialize box boundaries to the browser's local storage, and load this data every time the application is mounted.

Add skill-reported to indicate it is also required by skills team.
Also maybe we could also support form editor as it may be too crowded:

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2552


Fail on hook fail

The Problem/Issue/Bug:
https://github.com/drud/ddev/issues/2536
How this PR Solves The Problem:
Introduction of a new option (global & local): fail-on-hook-fail
Manual Testing Instructions:
Easiest way to test is probably by using:
ddev config global --fail-on-hook-fail=true
Automated Testing Overview:
make staticrequired finished without errors and without warnings.
Release/Deployment notes:
Nothing else should be affected, even though this was my first project using "Go" 🙂

Look at you go!

Please improve this PR description with full manual testing instructions, including example hooks, and please confirm that you've tested it manually.

Please improve this PR description with full manual testing instructions, including example hooks, and please confirm that you've tested it manually.
I'm sure this will need a test as well. We can cross that bridge a little farther down the road.

Done 👍

@rfay I tested on https://github.com/drud/ddev/commit/6c4c1246ca3550353676697464f22a57fe01b8da and everything is looking fine plus working as expected. Thank you :)


Initial Endpoint documenation

Please document the varios endpoints and their expected behaviors. The existing protocol documentation is excellent but doesn't cover what endpoints to expect or how they work.
Most endpoints appear to be implemented here in the firmware

Yes we should add some documentation indeed, and we will be working on that here. This pertains to the firmware version 4.0 and later, which is currently under construction, preview here. One thing in particular to note with this refactoring is that the endpoints are now declared within each object, example here

With v0.5.1 endpoints can now be directly documented in the odrive-interface.yaml. Some initial documentation has been done.


Usecases

Refers to issue #1
These are some initial use cases for review and feedback - more will come.

We don't plan a further review, so please update what was reviewed so far. New use cases better in a new PR, to not intermix already reviewed use cases with new ones.

Great work!


Discard additional lines upon inserting when AcceptsReturn=false

What does the pull request do?
It changes text insertion into TextBox with AcceptsReturn==false so that behavior is the same as in WPF.
What is the current behavior?
Upon insertion of multiline text into TextBox with AcceptsReturn==false the TextBox becomes multiline. It is currently impossible to prevent a TextBox becoming multiline by user input (e.g. by pasting from clipboard).
What is the updated/expected behavior with this PR?
Upon insertion of multiline text into TextBox with AcceptsReturn==false, only the first line will be inserted and any additional lines will be discarded.
How was the solution implemented (if it's not obvious)?
TextBox.RemoveInvalidCharacters was renamed to SanitizeInputText and extended to handle the multiline scenario.
Fixed issues
Fixes #5600

cc @Gillibald

The tests fail on Windows because LineBreakEnumerator does not handle the line breaks as expected on Windows (I develop on Linux and tests pass fine there). Windows uses CRLF as line terminator but LineBreakEnumerator leaves a trailing CR. Referring to Unicode Documentation this may be according to spec, because a CR does not cause a line break when followed by a LF, but it is probably not what we want for TextBox.
I am at a loss here. Should I add additional code for "cleanup" of extraneous trailing CRs? This is kinda ugly but I do not see a better way when using LineBreakEnumerator. Any suggestions?
(Notice that in deviation to the suggestion of @Gillibald I am using PositionWrap instead of PositionMeasure. PositionMeasure would trim all trailing whitespace. That would solve the CR-problem but it would kill trailing space.)

I have adjusted the logic to only look for line-break characters


Preserve cursor position after removing filter

It's annoying how you can search, find something, then want to view that in context but when you remove the filter the cursor/screen isn't showing what you searched for. Happens most often for me viewing a spec or event.
Will be tricky on things that aren't selectable...

Idea for this: don't only show matching lines in certain views (specs), but show the whole text, highlighting the matches, and be able to cycle through them


How do you connect with Jruby on rails ?

Let me explain more,
I am trying to build a JRor application with Hbase as a main database, But I also dont want to write core hbase schemas. So I am thinking about to write in sql and then use apache phoenix to talk to hbase. It might be wrong path to carry forward. If that is a case then I would like to ask in which case we can use this gem?
Thanks
PS(I can not add this gem via gem install)

This gem is really just a simple interface to the phoenix command line client for non-jruby clients. We only use it for creating tables and testing and I would not recommend it for production Phoenix queries. If you are using jruby you can call phoenix directly through the Java API

Thank you for your time and expertise. What is the best gem to use if you need to configure connection between JRuby on Rails with Phoenix for to use Hbase? We currently using this gem now and there is no luck in connection. I have Phoenix connected with Hbase correctly. Also is there any demo app i can take a look that you might have know..?

If you have the phoenix jars in your classpath you should be able to do something like
require 'java'

java_import 'java.sql.Connection'
java_import 'java.sql.DriverManager'
java_import 'java.sql.ResultSet'
java_import 'java.sql.SQLException'
java_import 'java.sql.PreparedStatement'
java_import 'java.sql.Statement'

con = DriverManager.getConnection("jdbc:phoenix:#{phoenix_connection_url}")

and then use the connection just like any other jdbc connection. I think it should be possible using the activerecord jdbc adapter, but I haven't tried it. Phoenix will create its own connection pool using the settings in the hbase-default.xml in your classpath. Here is an example
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
 <property>
 <name>hbase.defaults.for.version.skip</name>
 <value>true</value>
</property>
<property>
 <name>hbase.client.scanner.caching</name>
 <value>10000</value>
</property>
<property>
 <name>phoenix.query.threadPoolSize</name>
 <value>768</value>
</property>
<property>
 <name>phoenix.query.queueSize</name>
 <value>15000</value>
</property>
<property>
 <name>phoenix.query.keepAliveMs</name>
 <value>300000</value>
</property>
</configuration>

@joshidhruv did you get what you needed? Sorry about not following up sooner


Model kept unloading no matter what

Greeting, I have modified the ollama/server/routes.go to set the following variable:
var defaultSessionDuration = 1440 * time.Minute

However when running the ollama, it kept unloading the exact same model over and over for every single API invocation for /api/generate endpoint and this is visible from nvtop CLI where I can observe the Host Memory climbing first and then GPU finally have the model loaded.
This makes Ollama very impractical for production environment when it takes significant amount of time to load the model for each and every API invocation. It should be noted that this is NOT running from docker as it is an intentional decision.
Is there an alternative recommendation to workaround this?
Please and thank you.

Ok, I assume this is intended behavior.

I have the same experience, and the same concerns about performance. Is there a way to avoid the delay?

@TechScribe-Deaf The behaviour right now is to unload after 5 minutes. That was really a compromise because some people want it to unload immediately, and others want it to never unload.
I've been looking at making it so that you can specify how long you want it loaded for as part of the call to /api/generate or /api/chat. It takes a duration called keep_alive as a duration (e.g. 20m). If a different model is requested, it will unload it immediately and load in the other model.

But what if we have sufficient VRAM to support multiple models on the same device? Do we need to spin up instances of Ollama separately?
I think realistically, there should be a full disablement of ANY unloading of the model as an option.

@TechScribe-Deaf yeah, that's part of the problem. There are potentially a lot of corner cases, particularly around multiple models and scheduling.

I would appreciate having this feature as well. @pdevine, have you been able to implement it and submit a pull request? Thank you for your hard work.

It takes a duration called keep_alive as a duration (e.g. 20m). If a different model is requested, it will unload it immediately and load in the other model.

@pdevine is this currently supported, and if so, is it documented? My use case is to use this with Continue (a co-pilot replacement for VSCode) and having the model unload regularly significantly impacts performance, as you may imagine. Ideally I could pass a flag to ollama serve to keep the model loaded indefinitely (unless another model is called, of course), but a similar parameter on the request would work as well.

@pdevine is this currently supported, and if so, is it documented? My use case is to use this with Continue (a co-pilot replacement for VSCode) and having the model unload regularly significantly impacts performance, as you may imagine. Ideally I could pass a flag to ollama serve to keep the model loaded indefinitely (unless another model is called, of course), but a similar parameter on the request would work as well.

It's just something I was tinkering around with. If it's useful we can get it in, but there are a lot of corner cases here so I want to make sure the UI is correct.

@TechScribe-Deaf  "there should be a full disablement of ANY unloading of the model as an option." well just to prove @pdevine correct (a fellow Devine here), I came here to find the opposite. I very much need the ability to unload a model on command. I have limited vram and need to load up other (Stable Diffusion stuff), as a workaround I can just wait out the 5 minutes if I am not there, but that is not a great long term solution.
An option to load a model indefinitely unless a "release model command" or "load new model command" is sent would be cool.

I'm using ollama primarily from an api. It should be simple to create an endpoint that will reset the timeout when called.  Same mechanism could be reused in the cli. For those of us that want a long-running session, we can cron a call to that endpoint.

#2146 has merged, so I'm going to go ahead and close this. You'll be able to use it in 0.1.23.


How to iterate the data in reverse order.

Can I ask you a question?
How to iterate the data in reverse order.
For example, when inserting, the data with key a, B, C, D, e, F, G will be inserted automatically.
In iteration, you want to display g, F, e, D, C, B, a first
This display.
thank you

Use Last then Prev.