Make events.txt update optional

Is your feature request related to a problem? Please describe.
Updating events takes a relatively long time.  The events.txt usage in Mobiflight has been deprecated for about one year, yet updating events from Hubhop still updates these deprecated files.  In case someone still needs these files, I propose to create a new option in Settings to disable update of events.txt and related files.
Describe the solution you'd like
A new option in Settings menu to disable update of events.txt and related files.
Describe alternatives you've considered
Not doing anything.
Additional context
Update time can be significantly reduced.  It is currently a waste of time and hard disk space to keep updating these files.  Newer MF versions don't need them.  Older version users can continue using them with no impact to them.

Is this even used by MobiFlight at all anymore? Why not jsut remove it entirely?

I don't think they are needed at all in Mobiflight. I see no point in maintaining them. It is OK for Hubhop to generate the events.txt file in case some outside app wants to use it (like Fsuipc7).
I would agree they could be eliminated all together.
In fact, some confused users are still trying to use them after watching old tutorials.

We had decicded that we still keep them for users who created a config with the first version of the system and haven't update their config entries yet.
Of course as long as their original events text resides in the wasm module the events will work. If an event was updated, the user will have to edit the configuration and that will also update it to the new presets system.
So yeah! It's probably fair to assume that there is no disadvantage for anyone if we remove the download altogether.
The big file is by the way the new presets file json. Download of the file takes way longer than the events.txt


TypeError: 'type' object is not subscriptable

When giving command : python run.py --task "random video" --name "myfirst"
Below output error is coming.
$ python run.py --task "random video" --name "myfirst"
Traceback (most recent call last):
File "run.py", line 24, in
from chatdev.chat_chain import ChatChain
File "C:\Users\youli\GitProject\ChatDev\chatdev\chat_chain.py", line 12, in
from chatdev.chat_env import ChatEnv, ChatEnvConfig
File "C:\Users\youli\GitProject\ChatDev\chatdev\chat_env.py", line 35, in
class ChatEnv:
File "C:\Users\youli\GitProject\ChatDev\chatdev\chat_env.py", line 82, in ChatEnv
def exist_bugs(self) -> tuple[bool, str]:
TypeError: 'type' object is not subscriptable
(.venv)

Hello, I have just tested the code you provided and confirmed that it does not affect ChatDev's operation. Considering that the error you encountered on line 82 appears to be related to a def function, it might be due to a Python version issue. I would recommend upgrading to Python 3.9 or a higher version.
Thank you for your efforts in trying out ChatDev, and please feel free to continue asking if you have any further questions or issues.


feat(pixels): add my new pixel (59, 16)

I have done my contribution.

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Updated pixel


PyYAML installation fails

Not shure if it's a real Problem but the build output shows a failing PyYAML installation.
Installing collected packages: sphinx, virtualenv, setuptools, docutils, readthedocs-sphinx-ext, mkdocs, mock, pillow, Jinja2, Pygments, Markdown, PyYAML, watchdog, ghp-import, markupsafe, argh, pathtools
  Running setup.py install for mkdocs

    warning: no previously-included files matching '__pycache__' found under directory '*'
    warning: no previously-included files matching '*.py[co]' found under directory '*'
    Installing mkdocs script to /home/docs/checkouts/readthedocs.org/user_builds/slave/envs/feature-sr7230/bin
  Running setup.py install for PyYAML
    checking if libyaml is compilable
    x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.7 -c build/temp.linux-x86_64-2.7/check_libyaml.c -o build/temp.linux-x86_64-2.7/check_libyaml.o
    build/temp.linux-x86_64-2.7/check_libyaml.c:2:18: fatal error: yaml.h: No such file or directory
     #include <yaml.h>
                      ^
    compilation terminated.

Same here and it seems my markdown.yml is not found or used.
https://github.com/alt3/cakebox/tree/dev/docs

Same here, the only non-standard thing i do is using sphinx_bootstrap_theme. Same setup works well on internal RTD instance.

FWIW placing my markdown.yml in the root folder (and thus not in the docs subdir) does work.

Not much we can do about Yaml sadly. Closing this.


Fix getUrl to work with non tenant pages

[X] Changes have been thoroughly tested to not break existing functionality.
[N/A] New functionality has been documented or existing documentation has been updated to reflect changes.
[N/A] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Fixes #7500

closing as using getUrl in a closure resolves the issue.


win/spawn: optionally run executable paths with no file extension

Add a UV_PROCESS_WINDOWS_FILE_PATH_EXACT_NAME flag to enable the optional behavior.
Prompted by https://gitlab.kitware.com/cmake/cmake/-/issues/25450#note_1451473.  Continuing from #4241.

@vtjnash @bnoordhuis this supersedes #4241 and preserves backward compatibility by making the behavior opt-in with a flag.


Backport "Remove unnecessary and recursive Space decomposition" to LTS

Backports #19216 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-19356.
Reference


the trait bound OffsetDateTime: FromSql is not satisfied (the trait FromSql is not implemented for OffsetDateTime)

I've got the following error by using FromSql and ToSql with time::OffsetDateTime.
error[E0277]: the trait bound `OffsetDateTime: FromSql` is not satisfied
   --> src/main.rs:251:35
    |
251 |                 date_created: row.get(10)?,
    |                                   ^^^ the trait `FromSql` is not implemented for `OffsetDateTime`

Of course, I loaded all items that are required (also like https://github.com/rusqlite/rusqlite/issues/240)
use rusqlite::{params, Connection, Result};
use rusqlite::types::*;

use time::OffsetDateTime;

I am using the latest git version of both packages and activated the time feature for rusqlite:
time = { git = "https://github.com/time-rs/time.git" }
rusqlite = { git = "https://github.com/rusqlite/rusqlite.git", features = ["time"] }

So, what  am I doing wrong, or is it a error by rusqlite/time?

Version mismatch ?

Oh yeah, that fixed it. I used the git time and the git rusqlite version. time is having Version 3, and not 0.2.23. thank you!


Remove unused domain types

@celinedurniak were there others that are not needed that you had in mind?

What are RunType and ScatteringRunType?

What are RunType and ScatteringRunType?

These a type-variables, which will (in the case of powder) take values such as SampleRun or VanadiumRun. Any data-reduction step that performs identical computation for several run types uses these. Here is an example:
https://github.com/scipp/essdiffraction/blob/7772e6962b7739da6c74e2b809d90d278b61ee58/src/ess/powder/conversion.py#L199-L203
This function will/can be used multiple times in the reduction workflow graph, typically for sample and vanadium runs.

And 'NexusSource' is the input raw file?

And 'NexusSource' is the input raw file?

It is the NXsource group loaded from a Nexus file. See https://scipp.github.io/essreduce/generated/modules/ess.reduce.nexus.generic_types.html for full list of types and explanations.

Thanks for the explanations.
So, to answer the first question, at the moment, I do not see any more terms to remove.


No form data when using a closure as factory

Hi, thank you for your work on this project.
I intend to use a form to instantiate an object via its constructor. Only one of the constructor parameters is a form field, the other is to be supplied via a form option.
I attempted to use a closure for the 'factory' option, which the documentation states should receive the form data as its argument:
$resolver->setDefaults([
    'data_class' => SomeClass::class,
    'factory' => function($formData) {
        // $formData is null
    },
]);

Unfortunately on submitting the form, $formData is null so I have no way of getting the form field's data to construct the object.
It looks as though SensioLabs\RichModelForms\Instantiator\FormDataInstantiator->getData() is always null at that point - the child form field is submitted and has data but the overall form is not and has none.
Any advice would be appreciated. I'm also not sure how I'm going to supply the factory closure with another parameter for the constructor from the form options but I'm not there yet :)

Thank you for the report. Could you please create a small application that allows us to reproduce the issue? I am not sure yet if this is a bug or some misuse here (which maybe could be prevented by improving the documentation).

Thanks for your response, Christian.
I've made a small application here: https://github.com/hjkl/rich-model-closure-factory.git

Thanks, this helped a lot. 👍 Your case can be solved by setting the immutable option to true, but I am still going to investigate if we don't need to fix something here.

I noticed the same problem but didn't have time to set reproducer. I solved it different way (this is really big form):

public function buildForm(FormBuilderInterface $builder, array $options): void
{
	//....
    $builder->add('invoicedToClient', DateType::class, [
        'label' => 'Date the Supplier issued invoice to customer',
        'constraints' => [
            new NotNull(),
        ],
    ]);
	//....
}

public function configureOptions(OptionsResolver $resolver): void
{
    $resolver->setDefaults([
        'data_class' => Invoice::class,
        'factory' => [$this, 'factory'],
        'exception_handling_strategy' => 'ignore',
    ]);
}

/** @noinspection PhpTooManyParametersInspection */
public function factory(Campaign $campaign, DateTime $invoicedToClient, DateTime $sentToCxConnect): Invoice
{
    return new Invoice($campaign, $invoicedToClient, $sentToCxConnect);
}

This trick is to name parameters in factory() as form fields. Hope this helps.

I didn't want to use 'factory' => Invoice::class because variable names in constructor would need to match field names.

I didn't want to use 'factory' => Invoice::class because variable names in constructor would need to match field names.

You are right. Currently, that's indeed a limitation (see also https://github.com/sensiolabs-de/rich-model-forms-bundle/issues/50#issuecomment-447360923).

@xabbuh To be honest, I don't think of this as limitation. I prefer creating instances manually because it is easy to find usages of __construct(); just ctrl+click.
More important is that static analysis tools could also easily detect problems. Example: I add new requirement to constructor, phpstan will see the problem in InvoiceType form. But if I used 'factory' => Invoice::class, it wouldn't.
Btw, I really love this bundle. No more wasting time on DTO classes, thank you guys!

@zmitic That's really helpful. Your code works as the callback isn't a closure.
SensioLabs\RichModelForms\Instantiator\ObjectInstantiator's instantiateObject method explicitly checks if the factory is a \Closure:
if ($this->factory instanceof \Closure) {
    return ($this->factory)($this->getData());
}

As in the docs, for a closure it's supposed to give the form data as a single argument (but doesn't work).
Whereas for your [$this, 'factory'] callback, it unpacks into separate (...$arguments)

@hjkl Exactly! I had to take a look at the code to figure how to use it and I am really impressed with argument unpacking solution; you just can't make a mistake.
I think the Closure version should work the same way as callable. User can typehint every parameter, bundle will catch TypeErrors, static analysis will always work...
Also, argument unpacking is much cleaner.
Smaller example, with future arrow functions:
'factory' => fn(Campaign $campaign) => new Invoice($campaign),

It is clean, readable and foolproof.
@xabbuh  What do you think about that? Given that bundle is not 1.0.0 tagged, BC is not a problem, right?

@zmitic I am not sure I completely got what you would like to see supported. Could you create a new issue further described your feature request so we can keep things separated and not lose your idea when this bug is fixed?

@xabbuh Done: https://github.com/sensiolabs-de/rich-model-forms-bundle/issues/61
Sorry if too much text, documentation for factory is missing. So I decided to describe how it works, might help others.

@hjkl Can you confirm that #63 fixes your issue?

Thanks @xabbuh, I can confirm that's fixed it.

@hjkl Thank you for the confirmation.


Add HTTP endpoint for TD validation

It would be nice to have an endpoint to validate TDs against the TD schema.
What should the operation/endpoint look like?

POST /validation is not very RESTful.
GET /validation is idempotent but some clients may not support a body in GET request.
Add dry run query parameters to TD CRUD operation. E.g. POST /td?dryrun.

Validation can be done in one of the following ways (motivated from this thread:

Provide a separate endpoint POST /dry-run-td so that a client can validate its TD
Pro: the existing TD API will be clean
Con: As you said it, it is not restful as we expect idempotent operation from POST method

Use the same endpoint, but pass a flag to indicate it as a dry run.
e.g.

POST /td?dry-run=true where the dry-run defaults to false when not given
POST /td?exec=false  or  POST /td?commit=false  where the dry-run defaults to true when not given

Do not perform dry run at all and leave it to the client. This has the problem that the client can not sync up always with the server about the schema unless the server exposes it.

Use GET /validation with body but some clients may not support a body in GET request.


error in npm i

Prerequisites

[x] Using npm
[ ] Using an up-to-date main branch
[ ] Using latest version of devtools. Check the docs for how to update
[ ] Tried solutions mentioned in #400
[ ] For issue in production release, add devtools output of DEBUG_PROD=true npm run build && npm start

Expected Behavior

Current Behavior

Steps to Reproduce

Possible Solution (Not obligatory)

Context

Your Environment

Node version :
electron-react-boilerplate version or branch :
Operating System and version :
Link to your project :

Bump, same here. Haven't modified anything in the codebase and got errors

Yep same am getting the same error cant seem to fix

same here, anybody have solution ?


assertThat(-0.).isZero() fails

Summary
Tested with: AssertJ 2.6.0 ; Java 7
Expression assertThat(-0.).isZero(); fails. Can we reconsider this?
Example
final double d = -0.;

assertThat(d).isZero(); // fails

assertThat(d).isCloseTo(0, within(0.)); // workaround

Java 8 specific ?

NO  : create Pull Request from the 2.x branch

I agree.
the issues comes from AssertJ converting double to Double. It turns out that with Double positive zero is not equal to negative  zero as explained in
http://stackoverflow.com/questions/14771328/java-signed-zero-and-boxing.

That also applies to float

Fixed.

I have reached here with an issue seems related this issue.  Thanks.

@joel-costigliola Shouldn't this issue be re-opened?

@onacit if I am not mistaken, the issue is only for boxed values. According to @joel-costigliola's comment:

It turns out that with Double positive zero is not equal to negative zero as explained in
http://stackoverflow.com/questions/14771328/java-signed-zero-and-boxing.
We will keep the existing behavior for Double but we will fix it for double.

which is in line with the JDK behavior.
Or did I miss something?

@scordio You're not mistaken at all, I believe, yet it's pulling me with a new point of view.
Currently,
Abstract(Double|Float)Assert#assertIsPrimitiveZero() methods compare (double|float)Value() with 0.0.
Which seems work with both negative|positive zero values.
And (Doubles|Floats)#zero() methods returns 0.0d, 0.0f, respectively.
I'm curious when clients call a method so called isZero(), I would believe that the actual should be verified as a value which considered zero regardless of positivity or negativity?.
But verifies only those three conditions.

negative primitive zero: -.0(f|d)
positive primitive zero: +.0(f|d)
a wrapper type of +.0(f|d) using Object#equals method.

I don't understand why both negativity and positivity pulled out of wrapper case.
    assertThat(new Double(+.0d)).isZero();
    assertThat(new Double(-.0d)).isZero(); // Why not verifies? Isn't it zero?

Thanks.


(shasht:read-json "0") crashes

Hi
(shasht:read-json "0")

crashes the library:
The value
  NIL
is not of type
  CHARACTER
   [Condition of type TYPE-ERROR]

Restarts:
 0: [*ABORT] Return to SLY's top level.
 1: [ABORT] abort thread (#<THREAD "slynk-worker" RUNNING {700AE3EE73}>)

Backtrace:
 0: (SHASHT::READ-JSON-NUMBER #<SB-IMPL::STRING-INPUT-STREAM {700B170B53}>)
 1: (SHASHT:READ-JSON "0" T NIL NIL)
 2: (SB-INT:SIMPLE-EVAL-IN-LEXENV (SHASHT:READ-JSON "0") #<NULL-LEXENV>)
 3: (EVAL (SHASHT:READ-JSON "0"))
 4: ((LAMBDA NIL :IN SLYNK:PPRINT-EVAL))

Thanks. Pushed a fix.

Super cool thanks!!!

😎  thanks !!!!

Try now.

Ok, closing. Thanks for the report.


Disable recursive search with PowerRename

Description of the new feature / enhancement
I would like to propose a toggle switch in the PowerToys settings to either enable or disable recursively searching through folders that are being renamed.
Scenario when this would be used?
While I was trying to rename ~100 top level folders, PowerRename first had to identify all of the subfolders and files. In my case, this was about 10^5 items, which caused PowerRename to crash. If I could disable recursive searching in the settings, this problem could be avoided.
Supporting information
No response

Hi Matthias, There's a toggle button for sub-items. I think it would help if you turn if off before entering something in the search field. Does that solve it for you? Still good feedback anyways.

Thank you for your response. Unfortunately, this does not solve the problem. Even with the “Include subfolders” button toggled off, PowerRename still indexes all subfolders and files causing a crash. The toggle button does however successfully exclude those items from the rename results.

/dup #16162


Add service discovery support for Mesos services

As a developer, I'd like to leverage a service discovery mechanism that is native to Mesos platform, so I can discover relevant services such as binder, datasource, analytics store etc.

This issue was moved to spring-cloud/spring-cloud-dataflow-server-mesos#86


Colours not saving

ill post a video but bear in mind my internet was being really bad. So the issue is when you have a base down etc or a certain amount of props with a material applied and then a colour using the colour tool and when you save it and replace it down, it doesnt save the correct colours. I did pay someone to fix this which meant adding edits to your files and then apg files. I have updated to the most recent versions of apg and advanced duplicator 2 and now i have the colour saving issue again. If you wanna see my files on how it was done, feel free to ask. This is what the guy said what he did to fix this issue. The guy who made APG supposedly fixed it on his end and you probably need to fix something on your end.

Video: uploading as of right now

uploading the video of the issue now, my internet has been terrible recently so.

https://www.youtube.com/watch?v=pbutMFfqiQs

Have had this same issue for years now and never found a fix. Had two different computers and still half of the colors on my saves don't paste when I dupe them. Extremely annoying because every time I dupe something I have to manually fix the colors and sometimes materials.

@Jackywagon i have a fix for it, its just i want to use the most up to date versions of advanced dupe and apg the anit prop grief script but when i updated them, the issue occured again. i think he needs to make it stay the original colour and material when duplicating and unghosting just like in the picture above.

@thegrb93 would be nice if this could be fixed

It works fine. You have another addon causing the issue.

If I wanted I could make a video showing that it works. I just tried it and it does.

shoe me it working with newest version apg installed

Whats apg?

I don't use anti-prop grief. They need to fix that addon if that's the problem.

If you have a link to the addon, I can probably tell you what lines to remove.

https://github.com/NanoAi/gm_apg

Try it without the anti-prop-grief mod and see if that fixes the issue. Otherwise we can re-open it.

You can try deleting https://github.com/NanoAi/gm_apg/blob/70da0df550939698b5ec16e0b817372dcc68bcdc/lua/apg/modules/ghosting.lua#L45-L67 and https://github.com/NanoAi/gm_apg/blob/70da0df550939698b5ec16e0b817372dcc68bcdc/lua/apg/modules/ghosting.lua#L45-L67 and https://github.com/NanoAi/gm_apg/blob/70da0df550939698b5ec16e0b817372dcc68bcdc/lua/apg/modules/ghosting.lua#L45-L67


Settings includes values on Object.prototype

App settings pull from Object.prototype if they're missing on the settings object.
const app = require('express')();

app.get('hasOwnProperty');
// => [Function: hasOwnProperty]

app.enabled('hasOwnProperty');
// => true

Is this intentional? If not, I'm happy to help fix.

Hi, yea, definitely a useless feature 😀 . I'd be happy to accept a fix; app.settings.hasOwnProperty() should still be there for back compact, but using the .get and helpers probably shouldn't return them since it is quite a useless value. Ultimately it is not surprising this happens, as it is no different from just writing app.settings.hasOwnProperty.
We could also make settings a null prototype object in the 5.0 branch.

I'll make two changes:

In 4.x, make app.disabled, app.enabled, app.get, and app.set(oneArgument) ignore inherited properties on app.settings.
In 5.x, change settings from {} to Object.create(null).

Does that sound reasonable? If so, I can submit a patch.

It sounds good, though I don't think you can just ignore any inherited value -- that is how the settings are inherited from parent apps to sub apps.

Likely good enough to just filter out if it in Object.prototype.

Opened #4803. If that looks good, I'll make a similar PR for 5.0.

Now that #4803 is merged, I'll plan to make a similar PR for the 5.x branch.
I hope to get to that in the next few days.

Opened #4835.


cdc: reduce seek CPU usage on PebbleDB sorter

What problem does this PR solve?
Issue Number: close #10933
What is changed and how it works?
Custom some options for PebbleDB.
Check List
Tests

Manual test (add detailed scripts or steps below)

Idle CPU Usage (before):

Idle CPU Usage (after):

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

Could you please summarize how it works? Thank you!

/rest LGTM

This PR is cherry-pick back to release-7.5 by the PR #10646


Add PluginManager.hasPluginProvider/withPluginProvider

Expected Behavior

val androidPlugin = pluginManager.withPluginProvider("android")
val kotlinJvmPlugin = pluginManager.withPluginProvider("kotlin-jvm")

androidPlugin.zip(kotlinJvmPlugin) { android, kotlinJvm ->
// configure android with Kotlin jvm applied tasks.
}
...

Current Behavior
afterEvaluate {
  val androidJvmOnly = pluginManager.hasPlugin("android") && pluginManager.hasPlugin("kotlin-jvm")
  val androidKotlinMMP = pluginManager.hasPlugin("android") && pluginManager.hasPlugin("kotlin-multiplatform")
  val mmpOnly = pluginManager.hasPlugin("kotlin-multiplatform")

  if (androidJvmOnly) {
    // configure your tasks depending on kotlin/android only
  }  else if (androidKotlinMMP) {
    // configure your tasks depending on kotlin multiplatform and android
  }  else if (mmpOnly) {
   ...
  }
}

Context
Often you need to check the applied plugins when developing custom plugins to configure your tasks.
A typical example is the Kotlin plugin. To depend on configs provided by the Kotlin plugin you often use pluginManager.withPlugin("kotlin").
But there is not only one Kotlin plugin, but three: a JVM, a JS, and a multiplatform plugin, each configuring different sourceSets/tasks. So you have to use the withPlugin api, because you can only apply one kotlin plugin per project.
withPlugin("kotlin-jvm") { }
withPlugin("kotlin-js") {}
withPlugin("kotlin-multiplatform") {}

The withPlugin api lazily performs the block when this plugin is applied. If the plugin was applied before, this config is executed immediately, otherwise, it will execute after applying the specified plugin (or it won't if the plugin is not applied at all).
While these checks are powerful, also depending on the Android plugin makes these checks more complicated, now you have to check the presence of multiple plugins: android, kotlin-jvm, kotlin-multiplatform, kotlin-js.
Because it is possible to apply the plugins in any order and you need to configure different tasks/sourceSets for android/kotlin-jvm or android/kotlin-multiplatform. This is only possible by using hasPlugin and afterEvaluate.
But using afterEvaluate has many drawbacks. The "old" withPlugin api was lazily executed, hasPlugin is not.
So how do you get the old laziness api?
Fortunately, Gradle already has a powerful lazy api: Provider, and there is already a zip api to depend on multiple plugins.
This api should also support applying the plugins in any order.

Duplicates:

#18848


Can support rule interceptors and dynamically query to populate the context before executing the rule?

@contione Can you provide more details on this? Also if you can share some example of expected behavior it will help

Hi, I'm not the issue opener, but I have a similar need. I need to log the execution time for each rule. I'm thinking about adding pre and post execution hooks for each rule.
var rule = new Rule
{
    RuleName = "Example rule",
    PreExecution = _ => Debug.WriteLine(DateTime.UtcNow),
    PostExecution = _ => Debug.WriteLine(DateTime.UtcNow);
};

Is it possible do this or something similar to this?

@contione Can you provide more details on this? Also if you can share some example of expected behavior it will help

I noticed that RulesEngine mentions workflow, and it may require querying data from a database before executing the process in order to determine the next step and achieve a simplified version of a dynamic workflow. Currently, I have implemented my own simplified version, so I haven’t been able to utilize RulesEngine yet.


Add Hall of Flame Tributes

Interface is basically the same as Idols. Fixes #36.

That sounds right. If you load up the REPL and try to use it, it should be
obvious if the setter doesn’t work properly as soon as you try to load
them.
On Tue, Oct 6, 2020 at 4:31 PM Ryan Littleton<EMAIL_ADDRESS>wrote:

@Edgarware commented on this pull request.
In blaseball_mike/models.py
https://github.com/jmaliksi/blaseball-mike/pull/45#discussion_r500577627
:

@@ -1215,6 +1215,24 @@ def player(self):
return self._player

+class Tribute(Base):
+

@classmethod
def load(cls):

   tributes = database.get_tributes()

   tributes_dict = OrderedDict()

   for tribute in tributes:

       tributes_dict[tribute['playerId']] = cls(tribute)

   return tributes_dict

@property

Idol also doesnt have a setter for player, should I add one there as well?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jmaliksi/blaseball-mike/pull/45#discussion_r500577627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYCOCCAMPDAA5FHTG3D6QTSJN5CNANCNFSM4SGHCLUQ
.


Review the up to date version of ODAC connector from 12.1 to 19

In the documentation the link to install ODAC is version 12.1 whereas the latest version seems to be version 19.
Can you confirm and update please?
The documentation has a link to version 12.1 see "install the 64-bit ODAC software, go to 64-bit Oracle Data Access Components (<IP_ADDRESS>.4)" 64-bit Oracle Data Access Components (ODAC) for Windows
https://www.oracle.com/database/technologies/odac-downloads.html
However, a search shows that the latest is version 19.3 see here64-bit ODAC 19.3" ODAC Runtime Downloads (oracle.com)
https://www.oracle.com/database/technologies/dotnet-odacdeploy-downloads.html

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 382f269e-2072-ec03-7c88-335cbd5df919
Version Independent ID: 46a896f9-4707-adc3-72cd-5444a5d0f802
Content: Connect to an Oracle database with Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-connect-oracle-database.md
Service: powerbi
Sub-service: pbi-data-sources
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @nathanwlee1.
I've assigned this issue to the doc author for review.

Hello @nathanwlee1 - the supported version of ODAC is maintained by the product team; we only update the docs once they confirm a change / update in supported versions.
Your best venue for getting an answer or feedback on your question is from the community (https://community.powerbi.com) or from support at https://support.powerbi.com. You can also provide feedback using the Give Product Feedback button at the bottom of the article page.


Getting the body of the request

Probably overlooking something on my end, but I'm unable to get the response body for some reason. I have a handler defined like so:
local function handleTarget(request)
  print("Handling target")
  print("Body: "..request.body)
  ...
end

fullmoon.setRoute("/*",
  function (request)
    print("SET OPTIONS")
    request.headers["Access-Control-Allow-Origin"] = "*"
    if request.method == "OPTIONS" then
      return fullmoon.serveResponse(200, "")
    end
    return false
  end
)

fullmoon.setRoute("/:target", handleTarget)

When sending a request without a body everything works fine; I get a 200 response. When I attach a body to the request it seems to trigger a CORS issue for some reason. Also, request.body returns nil. Using redbean's GetBody() didn't work either. I'm using hoppscotch.io to test the API.

@rashadg1030, I do get the expected result with the following code:
local fullmoon = require"fullmoon"

local function handleTarget(request)
  print("Handling target")
  print("Body: "..request.body)
  return true
end

fullmoon.setRoute("/*",
  function (request)
    print("SET OPTIONS")
    request.headers["Access-Control-Allow-Origin"] = "*"
    if request.method == "OPTIONS" then
      return fullmoon.serveResponse(200, "")
    end
    return false
  end
)

fullmoon.setRoute("/:target", handleTarget)

fullmoon.run()

When I call with with curl -X POST -H "Content-Type: application/json" -d "{ \"key1\": \"value1\" }" http://localhost:8080/sometarget, I see the following printed as expected:
Handling target
Body: { "key1": "value1" }

If you're talking specifically about responding to a pre-flight CORS request, then instead of returning 200, you should do something like this (according to MDN docs):
    if request.method == "OPTIONS" then
      request.headers["Access-Control-Allow-Origin"] = "*"
      request.headers["Access-Control-Allow-Methods"] = "POST, GET, OPTIONS, DELETE" -- whatever you accept
      return fullmoon.serve204
    end

Sound good; thank you for the update!


Chore: Tests for spawning infra via terraform

Description
Testing if the changes to the templates were done correctly is time-consuming each time a small part of them is rewritten. Tests should be added that tests whether the spawned infra is as expected
Exit criteria

[ ] Tests for spawning infrastrucutre

Closing as not a short-term priority. Don't hesitate to reopen if needed.


Fix typo in organizer example

This fixes a method name typo in Organizer example.

Closed by #215
I happened to see #215 before this one. Thank you for the fix even though this has sat for a very very long time.


Uncaught Error: The specified module could not be found./?~\AppData\Local\Temp\Rar$EXa5600.27...

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: <https://github.com/issues?q=is%3Aissue user%3Aatom>
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Expected behavior:

Actual behavior:

Versions
Atom: 1.60.0 ia32
Electron: 9.4.4
OS: Microsoft Windows 7 Ultimate
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\GOLD\AppData\Local\Temp\Rar$EXa5600.27658\Atom\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At electron/js2c/asar.js:140

Error: The specified module could not be found.
\\?\C:\Users\GOLD\AppData\Local\Temp\Rar$EXa5600.27658\Atom\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1034:18)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:74:18)
    at customRequire (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:1:802772)
    at get_KeyboardLayoutManager (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:14:2877135)
    at get_manager (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:14:2877237)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:14:2877363)
    at e.keystrokeForKeyboardEvent (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:14:1121318)
    at KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:11:1225566)
    at KeymapManager.handleKeyboardEvent (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:11:1223551)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/Temp/Rar$EXa5600.27658/Atom/resources/app/static/<embedded>:11:286682)

Commands
     -0:18.3.0 tree-view:reveal-active-file (div.line)

Non-Core Packages

Additional Information

bug in written on keyboard

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/21285. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Unexpected behavior of Application.

Is it a ?

[ ] Bug Report

[ ] Feature Request

[ ] Chore

Bug Report
Actual Behaviour
When the app goes in to landscape mode and comes back to portrait the application closes.
Expected Behaviour
When the app goes in to landscape mode and comes back the application should display portrait mode.
LogCat for the issue
03-26 19:33:21.964 12934-12934/org.fossasia.eventyay I/Activity_Manager: Timeline: Activity_idle id: android.os.BinderProxy@428bc608 time:112907590
03-26 19:33:27.024 12934-12967/org.fossasia.eventyay D/dalvikvm: GC_EXPLICIT freed 1082K, 8% free 14329K/15456K, paused 3ms+7ms, total 53ms
03-26 19:33:30.374 12934-12934/org.fossasia.eventyay I/Logger: List of items successfully loaded with count: 11
03-26 19:33:30.404 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.404 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.404 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.404 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.404 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.414 12934-12981/org.fossasia.eventyay D/AbstractObservableBuild: Loaded class org.fossasia.openevent.app.common.data.models.Event From Disk on Thread RxCachedThreadScheduler-1
03-26 19:33:30.474 12934-12934/org.fossasia.eventyay D/dalvikvm: GC_FOR_ALLOC freed 614K, 7% free 14448K/15456K, paused 25ms, total 27ms
03-26 19:33:30.474 12934-12934/org.fossasia.eventyay I/dalvikvm-heap: Grow heap (frag case) to 20.120MB for 4096016-byte allocation
03-26 19:33:30.734 12934-12934/org.fossasia.eventyay I/Logger: List of items successfully loaded with count: 11
03-26 19:33:30.934 12934-12934/org.fossasia.eventyay I/Activity_Manager: Timeline: Activity_idle id: android.os.BinderProxy@428bc608 time:112916568
03-26 19:33:35.864 12934-12934/org.fossasia.eventyay D/dalvikvm: GC_EXPLICIT freed 740K, 6% free 18477K/19500K, paused 2ms+6ms, total 39ms
03-26 19:33:35.874 12934-12934/org.fossasia.eventyay W/System.err: StrictMode VmPolicy violation with POLICY_DEATH; shutting down.
03-26 19:33:35.874 12934-12934/org.fossasia.eventyay I/Process: Sending signal. PID: 12934 SIG: 9
Android version and Phone Model
Android Kitkat , API 19, Phone Sony Xperia T3
Would you like to work on the issue?
No, I won't, please give this to some one else.

@ahsan44411 This should have been resolved now. Can you check and confirm that it has been solved ?
If yes, then close it.

I'll check

@srv-twry I just checked. Although it doesn't always crashes the first time you perform this action, it does crash if performed repetitively (more than 2-3 times).
Thus, the issue persists.

This won't work in release apk. This is related to some memory leaks false alarms and issues. Hopefully they'll be fixed when we move to MVVM


Make variable for Scwrl executable path.

It'd be useful to have an executable_path argument for run_scwrl, scwrl_available and pack_side_chains_scwrl with a default value of Scwrl4 (i.e. on the path), so that people can use Scwrl even if it's not on their path.

Hi, I have a problem with this currently, although I have SCWRL installed:
❯ which Scwrl4
Scwrl4: aliased to /Users/leo/scwrl4/Scwrl4 -p /Users/leo/scwrl4/Scwrl4.ini

I get the following error:
  File "/usr/local/Caskroom/miniforge/base/envs/timed_predict/lib/python3.8/site-packages/isambard/modelling/scwrl.py", line 158, in pack_side_chains_scwrl
    raise ValueError('Scwrl4 is unavailable on your system path.')
ValueError: Scwrl4 is unavailable on your system path.

While checking the code I found that this is where I get the error:
>>> subprocess.check_output(['Scwrl4'], stderr=subprocess.DEVNULL)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/Caskroom/miniforge/base/envs/timed_predict/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/local/Caskroom/miniforge/base/envs/timed_predict/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/local/Caskroom/miniforge/base/envs/timed_predict/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/local/Caskroom/miniforge/base/envs/timed_predict/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'Scwrl4'

Which I can get around by modifying the above code to:
subprocess.check_output(['/Users/leo/scwrl4/Scwrl4'], stderr=subprocess.DEVNULL)

So I think that there should be a variable which specifies the executable, or at least an option to specify the path. Let me know your thoughts,


Take userText parameters into account for QuestionAnswerAdvisor's similarity search

Closes #1234

thank you @timosalm

Rebased, adjust checkstyle, squashed and merged at 932fc873f1bd1dd2d64ddb2dd8d8c28b2f8dd1d9


Packages for the python coreapi client

Motivation for this change
I want to package my application with Nix and I need the coreapi package.
Things done
The coreapi python package depends on 2 packages that were not in Nix. I've packaged those as well. One of them had to be forked and updated. I've added myself as a maintainer to them.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

What are the changes to your fork of pythonPackages.coreschema? Typically we would keep those patches in the Nixpkgs repo if they are small.
The packages look good overall.

The fork deletes two files which aren't used but cause build errors. The errors occur when building the python3x version of the package and without the files, builds succeed on all python versions (from what I can tell).

That seems to me like something which could be done as part of the Nix package, maybe good to do that directly in the package so that we can use upstream directly?
Although I see the upstream is archived, so maybe that's not useful; is there a fork of this package that is still actively developed/maintained?

There are no forks that are maintained. All of them are behind or even with master. Should I patch up stream?

I decided to patch upstream. The dependencies are still building, but I'm 99.99999999% confident it's fine.

Yeah, that looks better, thanks for the change. This PR looks good to me now.

Thanks for the review!

To get the tests executing for the coreapi package:
  src = fetchFromGitHub {
    repo = "python-client";
    owner = "core-api";
    rev = version;
    sha256 = "1c6chm3q3hyn8fmjv23qgc79ai1kr3xvrrkp4clbqkssn10k7mcw";
  };

The pypi package doesn't include the tests - they're present in the github archive though.
  checkInputs = [ pytest ];
  checkPhase = ''
    mv coreapi coreapi.hidden
    pytest tests
  '';

WFM macos 10.13

I'm a little confused over the necessity of rming the files from coreschema - it seems to remove functionality.
The tests for coreschema can be enabled in a similar way as above:
  src = fetchFromGitHub {
    repo = "python-coreschema";
    owner = "core-api";
    rev = version;
    sha256 = "027pc753mkgbb3r1v1x7dsdaarq93drx0f79ppvw9pfkcjcq6wb1";
  };

and
  checkInputs = [ pytest ];
  checkPhase = ''
    mv coreschema coreschema.hidden
    pytest tests
  '';

However these of course include tests for the modules you've rmed, which of course fail because they can't find the files. But if you leave those files in, the tests pass 100% for me, and what's more the tests for coreapi, depending on it pass 100%. So this would seem to indicate that it's functioning properly (this is python 3.7). What exactly is the problem you're having with these files present?

And for itypes tests:
  src = fetchFromGitHub {
    repo = pname;
    owner = "tomchristie";
    rev = version;
    sha256 = "0zkhn16wpslkxkq77dqw5rxa28nrchcb6nd3vgnxv91p4skyfm62";
  };

and
  checkInputs = [ pytest ];
  checkPhase = ''
    mv itypes.py itypes.py.hidden
    pytest tests.py
  '';

@risicle thanks for the review!
I've incorporated your changes, but I'm wondering, what's the purpose of moving the python module to .hidden?

I've incorporated your changes, but I'm wondering, what's the purpose of moving the python module to .hidden?

Oh, it's to "prove" that the tests are being run against the installed module, rather than the directory-local source dir.

It seems to have disappeared after using your way to fetch from Github.

Ah right yeah, sometimes people screw up the pypi packaging of a tarball, quite possible that's what's happened here.

Is there a problem that I added an additional package that depends on the ones in the PR?
I followed the same conventions as the previous. It's the drf-yasg which generated API documentation from django-rest-framework schemas. I tried to fetch the source from GitHub to run tests, but I couldn't get past the module attempting to access the django.conf.settings module. In case anyone wants to try. I had to do a little hack to get the GitHub build to work on python3x.
{
  stdenv,
  buildPythonPackage,
  fetchFromGitHub,
  fetchPypi,
  inflection,
  ruamel_yaml,
  setuptools_scm,
  six,
  coreapi,
  djangorestframework,
  pytest,
  datadiff,
}:

buildPythonPackage rec {
  pname = "drf-yasg";
  version = "1.16.1";

  # setuptools_scm error on python3x
  # https://github.com/python-cmd2/cmd2/pull/681#issuecomment-493833472
  SETUPTOOLS_SCM_PRETEND_VERSION="0.9.13";

  src = fetchFromGitHub {
    repo = pname;
    owner = "axnsan12";
    rev = version;
    sha256 = "1kn1ys9d6lsyh5c2bmrdf0hx7gqm2ds61zipvkc3j4jxzdvb668b";
  };

  propagatedBuildInputs = [
    six
    inflection
    ruamel_yaml
    setuptools_scm
    coreapi
    djangorestframework
  ];

  checkInputs = [ pytest datadiff ]
  checkPhase = ''
    pytest tests
  '';

  meta = with stdenv.lib; {
    description = "Generation of Swagger/OpenAPI schemas for Django REST Framework";
    homepage = https://github.com/axnsan12/drf-yasg;
    maintainers = with maintainers; [ ivegotasthma ];
    license = licenses.bsd3;
  };
}

Is there a problem that I added an additional package that depends on the ones in the PR?

No one will likely care much as long as you're a maintainer. And it's related to the others, should be fine.

Oh, it's to "prove" that the tests are being run against the installed module, rather than the directory-local source dir.

Please change into the tests directory then instead. That way the source won't get on sys.path.

Please change into the tests directory then instead.

This doesn't always work - sometimes tests expect the cwd to be the repo root for some reason.

Please change into the tests directory then instead. That way the source won't get on sys.path.

I can't find an example how to do that. Is it just changing the directory the tests run from?

checkPhase = ''
  cd test/
  pytest
'';

you're over thinking it :)

Thanks a lot, fixed :)

I think this is ready to be merged, is there something left @FRidh ?


Merge multiple config sources...

Is there a way to choose multiple sources to create the SpringRoll config file? I tried turning springroll.json's config property into an Array, but springroll-grunt doesn't like that.
If not, I think this might be a useful feature. For example, we have generated configuration files that should be included in the final deploy config, but having generated content in our src/config folder alongside original content can get confusing.

This definitely would be a useful feature to have (make an issue on the grunt-springroll repo. In the time being, you could override the concat-json task to add other subtasks for different output files. In <project>/tasks/overrides add a concat-json.js file that looks something like
module.exports = {
	release: {
		base: "<%= build.config %>",
		src: "<%= build.config %>/**/*.{json,js}",
		dest: "<%= configFile %>"
	},
	debug: {
		base: "<%= build.config %>",
		src: "<%= build.config %>/**/*.{json,js}",
		dest: "<%= configFile %>",
		options: {
			space: "\t"
		}
	}
};

where 'release' and 'debug' are replaced by your own names. Then just run grunt concat-json:mySubTask to build that config file.

Thanks Andrew, this is helpful.
I originally tried, but it looks like issues are not enabled on that repo.

Huh, that's interesting. I enabled issues and made an issue for this.

On further investigation, I think I may be able to accomplish what I need using JavaScript files inside the config folder that export dynamically-created JSON. I am actually trying to take multiple source paths and putting them into a single game config, not trying to create multiple configs from multiple sources (although I imagine that might be useful for other use-cases).


Add gh actions

This PR aims to add GH actions workflow builds and tests to kvikio. To accomplish that, following things have been added:

Add dependencies.yaml file and auto-generated environment file via rapids-dependency-file-generator
fix a couple of styling issues in pythons scripts to build docs without any warnings
add a common ./build.sh script in the root folder to build libkvikio or kvikio, as per the input parameter, mimicing other rapidsai projects build process
add workflow files to ./github/workflows
add ci scripts to build and test kvikio, libkvikio, and generate docs.

Pending: ci scripts to test cpp and python builds downloaded from s3.
cc @ajschmidt8

rerun tests

One question @AjayThorve, do we need to correct a path for CodeCov?
We get the following output:
 ----- generated xml file: /__w/kvikio/kvikio/test-results/junit-kvikio.xml -----

---------- coverage: platform linux, python 3.8.16-final-0 -----------
Name                                                                       Stmts   Miss  Cover
----------------------------------------------------------------------------------------------
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/__init__.py            9      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/_lib/__init__.py       0      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/_version.py            4      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/cufile.py             39      6    85%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/defaults.py           36     20    44%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/numpy.py              42     42     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/nvcomp.py             90     90     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/thread_pool.py         5      5     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/zarr.py               26      1    96%
kvikio/__init__.py                                                             9      9     0%
kvikio/_lib/__init__.py                                                        0      0   100%
kvikio/_version.py                                                           354    354     0%
kvikio/cufile.py                                                              39     39     0%
kvikio/defaults.py                                                            36     36     0%
kvikio/numpy.py                                                               42     42     0%
kvikio/nvcomp.py                                                              90     90     0%
kvikio/thread_pool.py                                                          5      5     0%
kvikio/zarr.py                                                                26     26     0%
----------------------------------------------------------------------------------------------
TOTAL                                                                        852    765    10%
Coverage XML written to file /__w/kvikio/kvikio/coverage-results/kvikio-coverage.xml

One question @AjayThorve, do we need to correct a path for CodeCov? We get the following output:

Good catch. @madsbk. I didn't notice this.
Upon further inspection, it looks like we're seeing some of these source file path discrepancies in cudf as well (e.g. 1,2).
@bdice has opened up this PR https://github.com/rapidsai/cudf/pull/12751 to investigate the issue.
As long as there are no objections, I think we should merge the PR as-is and fix this in a future iteration.
@madsbk, does that work for you?

As long as there are no objections, I think we should merge the PR as-is and fix this in a future iteration.
@madsbk, does that work for you?

Sounds good to me

/merge


Indonesian Date Localization

source:

days name: https://id.wikipedia.org/wiki/Hari
months name: https://id.wikipedia.org/wiki/Bulan_(penanggalan)

Thanks a lot, also for the wiki links!


Breaking from for statement should return with empty completion

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik<EMAIL_ADDRESS>

This feature is very unclear how it works, and as far as I heard they plan to change it. I would wait a bit with this.


SIGABORT on libaws-cpp-sdk-core

What platform/OS are you using?
Amazon Linux 2018.03
uname -a
Linux ip-172-31-1-232 4.14.121-85.96.amzn1.x86_64 #1 SMP Wed May 22 00:45:50 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Which version of the SDK?
1.7.117
What compiler are you using? what version?
[ec2-user@ip-172-31-1-232 jitq]$ clang --version
clang version 7.0.1 (tags/RELEASE_701/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin
gcc --version
gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
What are your CMake arguments?
cmake  -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY='s3;lambda;sqs' -DENABLE_TESTING=OFF  -DCUSTOM_MEMORY_MANAGEMENT=0 .. -DBUILD_DEPS=ON
Can you provide a TRACE level log? (sanitize any sensitive information)
======= Backtrace: =========
/lib64/libc.so.6(+0x814f9)[0x7f71e626b4f9]
/usr/lib64/libstdc++.so.6(_ZNSt15basic_stringbufIcSt11char_traitsIcESaIcEE8overflowEi+0x163)[0x7f71cad51fe3]
/usr/lib64/libstdc++.so.6(_ZNSt15basic_streambufIcSt11char_traitsIcEE6xsputnEPKcl+0x89)[0x7f71cada7809]
/usr/lib64/libstdc++.so.6(_ZSt16__ostream_insertIcSt11char_traitsIcEERSt13basic_ostreamIT_T0_ES6_PKS3_l+0x124)[0x7f71cad97d84]
/usr/local/lib64/libaws-cpp-sdk-core.so(_ZN3Aws6Client22ComputeUserAgentStringEv+0x196)[0x7f71b64351b6]
/usr/local/lib64/libaws-cpp-sdk-core.so(_ZN3Aws6Client19ClientConfigurationC2Ev+0x1c)[0x7f71b64355ec]
I have tried with different versions of aws-sdk-cpp but they all give me the same error. And I am using curl 7.47
Any ideas/pointers are highly appreciated.

What is the output of:
Aws::Client::ComputeUserAgentString();

I continued debugging, but my code would even fail when declaring the ClientConfiguration or instantiation of the OptionInit object.
Because most of the issues seems to point to string management I decided to give it a try to:
cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY='s3;lambda;sqs' -DENABLE_TESTING=OFF -DCUSTOM_MEMORY_MANAGEMENT=1 .. -DBUILD_DEPS=ON
And with that all my code works again (+ changes to use Aws::String instead of std::string).
But I have to say that I don't understand this. I mean what is the allocator used when setting mem. management to 1? I never specified one, I only changed my cmake command, rebuild and reinstall.
The output of the function you asked for:
aws-sdk-cpp/1.7.97 Linux/4.14.121-85.96.amzn1.x86_64 x86_64 GCC/7.2.1
Thanks for the help!

First of all, the SDK version in your original issue is 1.7.117. But the output of the agent string says 1.7.97. Were your trying a different version after the initial failure?
To your question,
CUSTOM_MEMORY_MANAGEMENT is by default turned on, which means types within Aws:: namespace like Aws::String will use SDK's memory allocator.
After 1.7.103, setting CUSTOM_MEMORY_MANAGEMENT to '0' or '1' actually have the same effect to turn on aws memory management. You can turn it off by setting it to OFF, or turn it on by setting it to ON.
So try to set it to OFF and don't make any code change then try it again.

You can turn custom_memory_management off if you're running on Linux.
If you're running on Windows or Android then, there's value in turning it on.
On Windows, DLLs can have separate heaps and we have to ensure that objects allocated on one heap get deallocated from the same heap.
On Android, using the gnu STL, std::string has an empty string optimization that uses a static variable. If you're building shared libs, there will be two static variables with two different addresses. If one string is passed from one shared library to another, the comparison against the static variable will always be false.
short answer: if you're building on Linux (but not Android). You don't have a problem turning the memory-management off.


LSM: Grid scheduling overhaul and adding Storage.on_next_tick

There's a few places in the codebase where callbacks that are requested are resolved inline in the request. Without a guarantee from the compiler around tail-calls, this risks stack overflow and makes stack traces harder to follow. To ensure requests which take callbacks are completed asynchronously, we need a construct that can defer arbitrary execution for later.
The lowest level of scheduling exposed to TigerBeetle components is the Storage layer so this construct goes there. This PR implements Storage.on_next_tick as a way to defer callbacks until later. It uses IO.timeout(0) as a means of yielding, which is now special cased to avoid os/kernel calls and queue directly to its internal FIFO.
Grid also sees a reworking in its scheduling to allow more efficient Read merging, simpler cache access & control flow, and IOP handoff. Grid reads are now asynchronously driven by the Storage using on_next_tick so Grid.tick() no longer exists. These changes to grid should hopefully decrease worst case latency overall as cache reads are now being flushed/processed inside Storage/IO.run_for_ns instead of outside (with Grid.tick()).

Most components in TigerBeetle doing asynchronous work often end up in a call to the Storage abstraction. So this is where the scheduling code is handled. Higher level components only access the Grid, so it too gets a Grid.on_next_tick. This plays well with the IO scheduling already being done by Grid and falls back to Storage internally.

This is fantastic design @kprotty.
If I understand correctly, we're then batching and calling IO.timeout() for these?
However, if so, then I think this is not necessary, at least not if our goal is to defer callbacks so they appear async at the call site.
We only need to batch during the tick around the event loop. At the end of the tick, we can unwind these and call the callbacks without any dip into io_uring at all.

We only need to batch during the tick around the event loop

Deferring to the next Component (i.e. Grid) tick unfortunately means that it would "unwind callbacks" every IO.run_for_ns(). This could mean that CPU work that was deferred via on_next_tick may have to artificially wait config.tick_ms until it can execute. Such a delay sounds like the culprit of #226 and I wanted to avoid it.
The downside of this approach is that CPU work may be FIFO scheduled instead of LIFO scheduled. This seems to be make checkpoints (and I speculate other paths soon) slower in Debug mode (ReleaseSafe doesn't print logs to help indicate relative "speed"). To be fair, on_next_tick hasn't been applied to everywhere it needs to be yet so I'll keep monitoring. Getting rid of the current StackOverflow error from nested callbacks being hit in tree_fuzz.zig probably takes priority though.

Looks good. Gonna fuzz it for few hours just to make sure.

There is a slight but consistent throughput regression, from ~147k to ~141k mean transfers/s on 1k batches. Looking into whether this is new overhead or just the effect of a different arbitrary io schedule.

Distribution of compact times. main=yellow, pr=red, overlap=blue.

If this is on linux, what happens if you apply #220 along with the timeout(0) optimization in this PR?

Yeah, main+220 vs this pr+220 have the same throughput.
Is that expected? Are we hitting run_for_ns more often in this pr, or something like that?

This PR jumps back into the completed FIFO processing loop in run_for_ns more often than main due to on_next_tick. I think you could amortize this by having Storage.timeout_callback drain directly from storage.next_tick_queue rather than making a copy which avoids recursive submissions.

Makes sense. Do you want to do that in this pr or go ahead and merge?

Go ahead and merge. I remember that @jorangreef mentioned we should have a test case for handling overflowing completions / timeouts (or similar) before we merge #220


[BUG] nested zero.Init in real models leads to an infinite recursion

Describe the bug
Repro
Nested zero.Init leads to an infinite recursion:
import torch
import deepspeed

ds_config = dict(train_batch_size=1, zero_optimization=dict(stage=3))

class MyModel(torch.nn.Module):
    def __init__(self, m1):
        super().__init__()
        self.m1 = m1

with deepspeed.zero.Init(config_dict_or_path=ds_config):

    with deepspeed.zero.Init(config_dict_or_path=ds_config):
        m1 = torch.nn.Linear(1,1)

    model = MyModel(m1)

deepspeed_engine, *_ = deepspeed.initialize(model=model, config_params=ds_config)

$ deepspeed --num_gpus 1 test2.py
Traceback (most recent call last):
  File "test2.py", line 18, in <module>
    deepspeed_engine, *_ = deepspeed.initialize(model=model, config_params=ds_config)
  File "/mnt/nvme0/code/github/00optimize/DeepSpeed-optim-grad-accessors/deepspeed/__init__.py", line 125, in initialize
    engine = DeepSpeedEngine(args=args,
  File "/mnt/nvme0/code/github/00optimize/DeepSpeed-optim-grad-accessors/deepspeed/runtime/zero/partition_parameters.py", line 352, in wrapper
    if not hasattr(module, "_ds_child_entered"):
  File "/mnt/nvme0/code/github/00optimize/DeepSpeed-optim-grad-accessors/deepspeed/runtime/engine.py", line 490, in __getattr__
    if name in dir(self):
  File "/home/stas/anaconda3/envs/py38-pt113/lib/python3.8/site-packages/torch/nn/modules/module.py", line 2026, in __dir__
    parameters = list(self._parameters.keys())
[...]
  File "/home/stas/anaconda3/envs/py38-pt113/lib/python3.8/site-packages/torch/nn/modules/module.py", line 2026, in __dir__
    parameters = list(self._parameters.keys())
  File "/mnt/nvme0/code/github/00optimize/DeepSpeed-optim-grad-accessors/deepspeed/runtime/engine.py", line 490, in __getattr__
    if name in dir(self):
  File "/home/stas/anaconda3/envs/py38-pt113/lib/python3.8/site-packages/torch/nn/modules/module.py", line 2024, in __dir__
    module_attrs = dir(self.__class__)
RecursionError: maximum recursion depth exceeded while calling a Python object

Now, who would write code like that, right?
Real examples
But modern models are becoming complicated, so many CV and multi-modal models fall into a category where they are instantiated from multiple other pretrained models.
For example in this user report https://github.com/huggingface/transformers/issues/21538 they try to use a DONUT model which underneath is  a VisionEncoderDecoderModel
Here is the reduced version of their code that breaks:
from transformers import DonutProcessor, VisionEncoderDecoderModel
import torch
import deepspeed
from transformers.deepspeed import HfDeepSpeedConfig

ds_config = dict(train_batch_size=1, zero_optimization=dict(stage=3))

dschf = HfDeepSpeedConfig(ds_config)  # keep this object alive

model = VisionEncoderDecoderModel.from_pretrained("naver-clova-ix/donut-base-finetuned-cord-v2")

deepspeed_engine, *_ = deepspeed.initialize(model=model, config_params=ds_config)

You can see - there is nothing bad about this code.
When running this script - things go boom (infinite recursion), exactly as in the simple repro script at the beginning of this post.
and so what happens inside of it is this:
VisionEncoderDecoderModel.from_pretrained(...)

which calls this constructor inside zero.Init
class VisionEncoderDecoderModel(...)::
    def __init__(self):
            encoder = AutoModel.from_config(config.encoder)
            decoder = AutoModelForCausalLM.from_config(config.decoder)

where from_config calls zero.Init too! Nesting!
Here are 2 more reports of the same:

https://github.com/microsoft/DeepSpeedExamples/issues/84
https://github.com/huggingface/transformers/issues/21326

Fixing?
Now can we fix this in deepspeed or is the only way is for the integrators to add some kind of tracking if these calls getting stacked and ensure that there is only one zero.Init call? For example if I change the repro to:

with deepspeed.zero.Init(config_dict_or_path=ds_config):
    m1 = torch.nn.Linear(1,1)
    model = MyModel(m1)

deepspeed_engine, *_ = deepspeed.initialize(model=model, config_params=ds_config)

it no longer recurses infinitely. But I'm not certain it actually works later.
I'm pretty sure I saw this:
    with deepspeed.zero.Init(config_dict_or_path=ds_config):
        m1 = torch.nn.Linear(1,1)
    with deepspeed.zero.Init(config_dict_or_path=ds_config):
        m2 = torch.nn.Linear(1,1)

while passing deepspeed.initialize ok, then failing to work at train time - I need to write more tests to explore that use case.
So for now let's focus on just one thing - nested zero.Init.
The tricky part is that the user can't always guarantee they can control the various contexts, so ideally we want to make zero.Init impervious to nesting issues.

Now even if I fix this problem manually and remove the nested zero.Iinit calls, I the immediately run into problem number 2 with this exact setup and that problem is dynamic module importing inside zero.Init context.
I broke the problem down here: https://github.com/microsoft/DeepSpeed/issues/2812
Thank you!
@tjruwase, @samyam

Hi @stas00, thank you for your reporting.
I could reproduce the error regarding the nested zero.Init and investigated what's happening.
deepspeed.zero.Init adds a wrapper to a constructor of each subclasss of torch.nn.Module to partition parameters.
The wrapper is removed when exiting the with block of deepspeed.zero.Init.
When deepspeed.zero.Init is nested, however, the removal of the wrapper does not properly work and the wrapper is invoked for all constructor calls of subclasses of torch.nn.Module, even for DeepSpeedEngine (DeepSpeedEngine is a subclass of torch.nn.Module). This causes the endless recursive calls.
The straightforward way is to track the reentrant calls and to disable them after the first call.
I will try to fix by the approach but let me consider more after I investigate #2812.
I could also cause an error with this code.
    with deepspeed.zero.Init(config_dict_or_path=ds_config):
        m1 = torch.nn.Linear(1,1)
    with deepspeed.zero.Init(config_dict_or_path=ds_config):
        m2 = torch.nn.Linear(1,1)

I encountered the following error hen I run a forward pass with m2:
RuntimeError: mat2 must be a matrix, got 1-D tensor

Please let me know if this is not the one you encountered.
This error seems to have a different reason from the nested Init. I will take a look now.

Hi @tohtana,
Thank you for investigating this issue.
I think there are multiple issues with nested zero.Init, so yes, I was planning to write yet another report for 2 adjacent, but not nested calls just like you did, but didn't have the time to properly investigate.
So yes, we have at least 2 problems to fix here

nested zero.Init - this OP
multiple zero.Init calls - your 2 calls example in your comment above

perhaps you could file a report about your bug so that it doesn't fall between the cracks?
And yes, making zero.Init re-entrant should fix the 1st issue.
https://github.com/microsoft/DeepSpeed/issues/2812 ties closely into this group of problems related to multiple model inits at once. But it's stand apart. If you disable the re-entrant calls, it won't know to inject the wrappers for the new models that get zero.Init wrapped in a nested fashion as I have presented in https://github.com/microsoft/DeepSpeed/issues/2812
Therefore wrt #2812 I think a possible solution would be not to skip its functionality if it's re-entrant, but to check which new modules were added and if they don't have the hooks yet, insert them too.

Ah, OK, thank you for retesting, @tohtana
I'm pretty sure the above didn't work with 2 real models, perhaps try 2 real models from transformers? or we can just wait until I get enough time to dive into the 3rd issue.

Fixed by #2989. Will open new issue for #3202 as needed.


The "Don't stop the music" toggle does nothing.

What version of Music Assistant has the issue?
2.0.3b33
What version of the Home Assistant Integration have you got installed?
20204.10.0
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Unwanted music is added to the playlist when the currently selected music ends.
How to reproduce
Play a single track manually and music will continue to play after that song is over despite the "Don't stop the music" toggle being off.
Music Providers
Tidal has the problem.
Player Providers
I'm using snapcast to a Pi.
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.10.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Alternative

With the volume of requests for assistance on here, Discord and the HA forums we need people to provide the information requested in a concise manner. You are getting this standard response because you have not supplied the information requested in the troubleshooting docs or in the issue report template and we are unable to quickly pinpoint the problem. Please review and supply the requested information for a more timely response to your problem. Thanks for your understanding.

The don't stop the music toggle has been removed from the queue settings.
You can now set it per (player)queue) if you like, its an option in the contextmenu for the player (within the player sidebar or the full screen player).


Risk: missing success-critical stakeholders

#5 Issue by smattingly,
Project success = satisfying the win conditions of all success-critical stakeholders.
Therefore, failure to include one or more success-critical stakeholders creates severe risk of project failure.
Success-critical stakeholders are individuals or groups whose approval is needed for the project to move forward. This includes, but is not limited to, the users, customers, developers, investors, administrators, and those with management, financial, legal, or policy interests.
All such viewpoints must be actively represented by someone who represents the stakeholder, has the knowledge to make decisions, the authority to make commitments, and the time and interest to participate.

Reviewed this date.

Hasn't Changed

reviewed

reviewed

reviewed

reviewed


Change some references of !tag to !!

This is an unneeded change, and !tag is the main command whereas !! is just a shortcut.

!! is used more often and has sort of become the main command, so I'd say this should be merged


Completion in the fall

I think it will be useful =)
The terminal must return to its normal mode of operation in case of error recognition and emergency termination of the program.

Anybody here is? =)

Hey, sorry for the delay! This is something that's been bothering me for a while. Thanks for submitting this!


Post-processing depth images

Hi,
thanks a lot for this nice tutorial!
I have a (basic) question about the depth images. In the following, I refer to this part of the code. If I got it right, the process is as follows:

The shader gets the depth value;
The value is mapped between 0 and 1 considering the near and far planes;
The output value then gets "compressed";
The final output is then the depth image, which is saved to a PNG file.

I now need to do some offline post-processing (i.e. outside Unity). How can I get back the original depth value for every pixel from the stored image?
Thanks a lot for the help!

I have the same doubt, were you able to find out this?

Thanks for Immersive-Limit for sharing the nice code. It generated good outputs especially depth map and segmentation. Segmentation working great.
At the same time, I have the same question on the depth image. This is my nice depth image (top is depth and bottom is optical as reference):

and the pixel values (RGB in PNG) in the depth image are:
[(255, 255, 255), (221, 221, 221), (222, 222, 222), (194, 194, 194), (195, 195, 195), (223, 223, 223), (196, 196, 196), (224, 224, 224), (225, 225, 225), (197, 197, 197), (226, 226, 226), (227, 227, 227), (198, 198, 198), (199, 199, 199), (228, 228, 228), (229, 229, 229), (217, 217, 217), (218, 218, 218), (219, 219, 219), (220, 220, 220), (234, 234, 234), (235, 235, 235), (236, 236, 236), (237, 237, 237), (249, 249, 249), (248, 248, 248), (250, 250, 250), (251, 251, 251), (233, 233, 233), (230, 230, 230), (232, 232, 232), (231, 231, 231), (107, 107, 107), (58, 58, 58)]
According to Unity Shader Variable in the manual, the "_ProjectionParams.y" should be Camera Clipping Near and "_ProjectionParams.z" is Far. I reversed the conversion to see the depth in real life (meter I guess) and the results are from 11,040,483.927439027 to 4,125,122,561.0006104 .
The result seems too large because the farest barrel is around 100 meter from the camera.
Here is my conversion code as reference (I assume "DepthCompressed" not "DepthMultichannel" because RGB are the same):
#   Portion of conversion in UberReplacement.shader
        #       float near = _ProjectionParams.y;
        #       float far = _ProjectionParams.z;
        #       return (depth01 - near/far) * (1 + near/far);
        # float linearZFromNear = Linear01FromEyeToLinear01FromNear(depth01);
        # float k = 0.25; // compression factor
        # return pow(linearZFromNear, k);

        k = 0.25  # Compression factor
        # These are from Main Camera Clipping Planes setting
        near, far = 250, 10000
        pixel_val, cur_depth = 0, 0.0
        for each_depth in RGB:
            pixel_val = each_depth[0]
            cur_depth = math.pow(pixel_val, 1 / k)
            cur_depth /= (1 + near / far)
            cur_depth += near / far
            if (DEBUGGING):
                print ("Pixel value: {}".format(pixel_val))
                print ("Depth in meter: {}".format(cur_depth))


fix: Separate redis security group rules

Using inline security group rules in the aws_security_group resource along with the standalone aws_security_group_rule resource causes conflicts when the terraform is applied and rules to be overwritten. This pr separates the rules out into their own resources.

How did you figure this out? are there any external docs/open issues about this?

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule
Terraform currently provides both a standalone Security Group Rule resource (a single ingress or egress rule), and a [Security Group resource](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group) with ingress and egress rules defined in-line. At this time you cannot use a Security Group with in-line rules in conjunction with any Security Group Rule resources. Doing so will cause a conflict of rule settings and will overwrite rules.

I found this: At this time you cannot use a Security Group with in-line rules in conjunction with any Security Group Rule resources.
However, in the original, you are only using inline rules? so it shouldn't cause a conflict?

I updated the description with some info I found in the docs which lead me to this change. This appears to have fixed the confusion I was observing in the plan. I was using the aws_security_group resource with inline rules along with a standalone rule in the eks module (allowing eks to talk to redis)

This PR is included in version 1.0.4 :tada:


Adds iterative solution to 104. Maximum Depth of Binary Tree in Kotlin

File(s) Modified: 104-Maximum-Depth-Of-Binary-Tree.kt
Language(s) Used: Kotlin
Submission URL: _https://leetcode.com/submissions/detail/805737029/_

Thanks, @t3chkid!


Why a version of LLVM so old is used?

Will it not work with a more resent version of LLVM? I can't get the LLVM version 7.

New releases of LLVM do generally break backwards compat, so migration to the latest release is not free. To make it worse, my Amazon instance is low on disk space, making forward migration a pain to do. And lastly, my job has left me with very little time to do this maintenance.
I have prioritized getting new functionality working in the language over doing this maintenance, at least in the near-term. You are welcome to see if it works on a more recent version of LLVM, if you want. It might.

Oh, I didn't knew about all that. It makes sense now. I will try a newer version and tell you if it is working. Thanks a lot for your work and your time!

Ok, I just tried to compile it with the latest stable LLVM version (12) and there was one bug. It goes as follows:
/home/rempas/Downloads/cone/src/c-compiler/genllvm/genllvm.c: In function ‘genlPackage’:
/home/rempas/Downloads/cone/src/c-compiler/genllvm/genllvm.c:256:28: error: too few arguments to function ‘LLVMDIBuilderCreateCompileUnit’
  256 |         gen->compileUnit = LLVMDIBuilderCreateCompileUnit(gen->dibuilder, LLVMDWARFSourceLanguageC,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/rempas/Downloads/cone/src/c-compiler/genllvm/genllvm.h:15,
                 from /home/rempas/Downloads/cone/src/c-compiler/genllvm/genllvm.c:15:
/usr/include/llvm-c/DebugInfo.h:260:17: note: declared here
  260 | LLVMMetadataRef LLVMDIBuilderCreateCompileUnit(
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That's great because this means that there is only one line of code that needs to be changed in order to have it work with more resent version. So do your thing and you check it when you have time. I hope I could help you win some time! Have a nice day!
P.S. Be the one to close this issue after you read this so I'm sure that you have seen it!

Thanks for checking into it!  That is good news indeed to know the migration is likely to have few issues.
When I have a chance, will definitely do this maintenance.


[BUG] Rich shouldn't explode when using more than one display

[x] I've checked docs and closed issues for possible solutions.
[x] I can't find my issue in the FAQ.

Describe the bug
If you use more than one display, rich raises an exception (rich.errors.LiveError: Only one live display may be active at once).
A minimal example:
from rich.progress import track

for _ in track(range(100)):
    for _ in track(range(100)):
        pass

My horrible fix:
from rich.progress import track

def safe_track(it):
    from rich.errors import LiveError

    it_ = track(it)
    try:
        yield from it_
    except LiveError:
        yield from it

for _ in track(range(100)):
    for _ in safe_track(range(100)):
        pass

I think it shouldn't raise an exception but at most raise a warning. Here I list some reasons:

Who uses the iterator shouldn't know if the iterator is decorated with rich or not. If I'm using an iterator from an external library it shouldn't break my program just because it is decorated with rich.
It violates the Liskov substitution principle. The iterator decorated with rich has stronger pre-conditions than the original iterator, in fact it requires that no other live displays are currently active. It mean that it can't be used interchangeably with the original iterator.

I think this issue should at least get some consideration: this is a serious design flaw that hinders the possibility of using rich package to create any reasonably robust library/application.
Think about it: every time I depend on any package that may use rich for whatever reason, I must preventively check that no rich.Live is used and/or monkeypatch it to avoid LiveErrors, but this should not be my responisibility, if a dependency decides, for whatever reason, to use a rich.Live, it should have absolutely no impact on client code and shouldn't have anything to do with it.

Any news about this issue? I'm really struggling with this bug. Almost all my repositories that use rich have this problem and I have to scatter that ugly monkeypatch.

I am switching back to TQDM, uglier but much more reliable. No one needs fancy graphics if that underlying software is rotting. Clearly rich is something one should avoid.

@LucaBonfiglioli If your only contribution to Open Source is to complain then we're not going to miss you. Best of luck.

I've encountered this issue too and, after looking into the code, I'm wondering why the code does not use get_console() and the console's _live attribute as a default when it already exists.
Sure, the configuration of the existing live and the requested configuration of the new progress may not match, but at the moment there does not seem to be any other obvious way to fix rich, and not being usable out-of-the-box across libraries is a pretty major issue...

Did I miss something or shouldn't this be closed as not planned instead of done?


Redirect at Cancel Login

Our home page on PDB forces you to login.
If the user clicks the Cancel button, the following screen is shown:

If the user clicks the OK button, he is redirected to the home page, which in this case forces again a login.
Is it any chaise configuration by which mean the user can remain on the screen shown in the picture w/o the popup window?
The navigation bar menu being  enabled,  the user can click on the Documentation link which is a page that does not require login.
The Documentation link can be clicked also currently, but it would be nice to get rid of the popup window.

@svoinea yesterday we pushed a change to chaise master to enable the navbar when the login dialog is shown.
We intend to modify the error dialog to have a more appropriate error when we know it came from a dismissed login dialog to communicate to the user that they need to login to continue.

@jrchudy I tried https://data.pdb-dev.org/chaise/recordset/#1/PDB:entry and I don't see any differences.
The screen with You need to be logged in to continue. has still the navbar disabled, and when click on Cancel, you get the screen with the Terminal Error which has the navbar enabled (as it was before).
The pdb server is doing daily updates.

When I made the change to chaise yesterday I referenced the class on the modal element and not the body element. The issue with that is the modal is a sibling to the container the navbar is in, so the rule wasn’t being applied. The rule should be working properly with the next update.

@jrchudy I have checked and it is OK now.


Add data synth utils

io_amr_UE's DataSynth branch
By git submodules status, it would give:

RapyutaRobotImporter DATASYNTHTEXTURE
RapyutaSimulationPlugins AddDataSynthUtils
RapyutaSimInternal AddDataSynth
rclUE devel

Details

Add DataSynth Utils

RRCamera, RRProceduralMeshComponent
Add RAPYUTA_DATA_SYNTH_USE_ENTITY_STATIC_MESH, RAPYUTA_DATA_SYNTH_ENTITY_USE_PROCEDURAL_MESH
RRGameSingleton MATERIAL_NAME_ASSET_MASTER, MATERIAL_NAME_PROP_MASTER

Runtime StaticMesh using GeometryProcessing plugin, texturing not yet working
namespace ConversionUtils -> class URRConversionUtils
Add external texture image loading & coating for procedural mesh actors
Add utils for metadata (mesh actor bb vertices & 2d projection onto screen)
Add auto sim shutdown upon data generation finish

Yeah, so in order to generate synthetic data, we need:

UCameraComponent, acting a window to user view of scene, of which the contents are rendered then captured into images.
An actor for that camera comp to be attached to, which is ARRCamera. It is a UE-pure actor as different from the existing ARRROS2CameraActor, which is composed of URRROS2CameraComponent and has a ros2 node.

Yeah, so in order to generate synthetic data, we need:

UCameraComponent, acting as a window to user view of scene, of which the contents are rendered then captured into images.
An actor for that camera comp to be attached to, which is ARRCamera. It is a UE-pure actor as different from the existing ARRROS2CameraActor, which is composed of URRROS2CameraComponent and has a ros2 node.


Use DeleteAclRequest_v1 if broker version is over 2.0.0

Fixes https://github.com/StephenSorriaux/ansible-kafka-admin/issues/61
Proposed Changes

Use DeleteAclRequest_v1 if broker version is over 2.0.0
(also forced EOL to LF, that's why the huge diff)

I tested this and I can confirm that it's now working with prefixed acls. Many thanks.

Thanks for your feedback, I will merge this and generate a new release in the next days


allow to use cross-platform SDKs in other filesystem locations

Instead of setting up new, local SDKs it should be possible to point fips to an existing SDK install for emscripten, PNaCl and Android. Fips diag should then make sure that the SDKs have everything that fips expects.
Probably through a './fips set emscripten-location bla'...

What if we could just make our own config and toolchain file? I was looking at the emscripten toolchain file, and it appears that that the whole thing could be a macro that could substitute its location in the filesystem. I'm trying to figure out how to do this because I also like to compile with both gcc and clang. I also already have emscripten/fastcomp on my system.

I did this in emscripten.toolchain.cmake and it worked! :smiley:
    #get_filename_component(EMSCRIPTEN_ROOT_PATH "${CMAKE_CURRENT_LIST_DIR}/../${EMSC_EMSDK_DIRNAME}" ABSOLUTE)
    get_filename_component(EMSCRIPTEN_ROOT_PATH "/usr/local/src/emscripten" ABSOLUTE)

oh i had to comment some stuff in mod/config.py  as well
    # check if the target platform SDK is installed
    #if not check_sdk(fips_dir, cfg['platform']) :
    #    messages.append("platform sdk for '{}' not installed (see './fips help setup')".format(cfg['platform']))
    #    valid = False

You can already inject your own configs and toolchain files in projects and imports:
Custom config files must reside in a fips-configs subdirectory (e.g.: https://github.com/floooh/oryol/tree/master/fips-configs), and custom toolchain files need to reside in a fips-toolchains subdirectory. Both are searched in the following order: first in the current project, next in imported projects, and finally in the fips directory itself (there in different subdirectories: configs and cmake-toolchains).
For using a different toolchain file you need to create a custom config file, and set the cmake-toolchain attribute, like here: https://github.com/floooh/fips/blob/master/configs/emsc-make-debug.yml#L6
I haven't tested overriding the toolchains files very much though, might still have some bugs.

PS: I think with these 2 features (custom-configs and custom-toolchain-files) I guess the original bug is actually fixed, completely forgot about it ;)

For host specific configs/toolchains, I would prefer to not place those in a project repo. I'm fine plopping them in the fips subdirectories, but the check_sdk explodes for platform emscripten because it checks for the compiler in a specific directory. Would an override in the config be acceptable? Something like this:
---
platform: emscripten
generator: Ninja
build_tool: ninja
build_type: Debug
cmake-toolchain: local-emscripten.toolchain.cmake
defines:
    FIPS_CUSTOM_SDK: 1

... or is just using an arbitrary platform name feasible? I just noticed this from the README PSA:
"cross-compile target platform names are no longer hardwired, fips projects can now add define their own cross-compile platforms"

that appears to work.. please disregard :)


Feature: Years on GitHub badge 🎉

I thought about creating a whole repo for this but remembered that @puf17640 had git-badges 🔥
Feature
Traveling to the endpoint years/:user returns an SVG with the number of years a user has been a member.
Usage
To use this feature, two environmental variables need to be added GITHUB_ID and GITHUB_TOKEN.
Since we aren't hitting the GitHub API with OAuth we're using personal tokens to up the rate limit.
GITHUB_ID=username
GITHUB_TOKEN=personal_token

Enhancements
Enhancements that could be made are caching the result from the GitHub API to limit the number of requests being made,
the current rate limit is 5000 requests per hour thanks to the Basic Auth - more info available on the GitHub Docs, might be good for the time being though. 🤔

Any feedback is much appreciated, and any help with the code would be awesome. 😀 👍

@puf17640 Actually removing date-fns and using your method doesn't show the correct years, it shows the difference between the calendar year, not the year between the two dates, my year badge should say 7 and I get 8.

@puf17640 Actually removing date-fns and using your method doesn't show the correct year, it shows the difference between the calendar year, not the year between the two dates, my year badge should say 7 and I get 8.

Good point, didn't think too much about it, I was about to try out if there are differences in having date-fns or not, will add it back in now! You also gave me the idea to have a few other badges that show profile info, will add them in right now too!

/repos/:user now returns the count of public repos

Please don't force push, it's causing merge conflicts. 👍

Please don't force push, it's causing merge conflicts. 👍

I forced push over your readability/whitespace commit as I already ran lint:fix which fixed the whitespaces and I don't think newlines are needed since readability is pretty okay imo


Keybinds reference zero font size causes crash

steps to reproduce ? The issue title is not that clear for a new comer ^^

I don't remember exactly how to reproduce the original bug, but you can at least reproduce the scenario by setting the font size to zero in the yaml file. @blobinaticuber do you remember how this happened?

Steps to reproduce:

In the navbar, go to: Help > Keybinds reference
Open the settings drop down
Set Max font size to 3.0
Close Hyperspeedcube
Reopen Hyperspeedcube
In the navbar, go to: Help > Keybinds reference. This time, it will produce a crash, and you will be unable to open the keybinds reference menu until you go to hyperspeedcube.yaml and delete the line that says max_font_size: 3.0

I tried it and I'm not getting a crash.
I tried the provided binary and compiled from source, both in Linux. I'll try Windows when I can

Fixed in v1.0.7


Should an extension change the descriptions of another's fields?

This extension changes the descriptions of several fields in BudgetBreakdown from ocds_budget_breakdown_extension. I think we should instead change the descriptions by changing that extension; I think we shouldn't set a precedent of having extensions change others' field descriptions, which challenges consistent semantics.

Good thought and spot.
In fact, I think we can resolve this particular case by removing those changes - as they were left-over from when I thought I would re-use budgetBreakdown for the financialProgress/breakdown (and so would need it to refer to both budget and spend), whereas I have created a separate new object for this.
However, on the more general point of precent (possibly may want to move this thread elsewhere?): if we were needing to tweak definitions from another extension, but could only do that by creating a version of that extension, that would mean that we would need to declare that this extension depends though on use of a particular version of the other extension - which I don't know if we support yet - and which potentially adds another layer of adoption complexity.
Would the alternative be to think about our review process for extensions such that we can:

View each original and changed description side-by-side;
Make a judgement call on whether the changes are descriptive or semantic;
Make a judgement call on whether those changes would reasonably cause problems for users of the data;

Particularly given we're not making the same kinds of commitments, or placing the same kinds of requirements, on/for extensions are we are for the core standard.

The dependencies field in extension.json is a URL to an extension, which can reference a specific version (or simply the master branch).
I'm going to assume the changes would be descriptive, not semantic, as semantic changes to an extension (nevermind semantic changes by another extension) need to be done carefully and involve a set of concerns that would be long to address.
So for descriptive changes, I think it's better to either update the other extension, or describe the use of the other's fields in the prose documentation. As an example of the former, I believe we've sometimes updated descriptions of core fields based on their use by extensions, though I can't find a quick example. As an example of the latter, the Budget and projects extension provides additional guidance for core fields. The same approaches can be taken between extensions.
We can move/document this elsewhere if the conversation becomes long.


No versions available

The package has to be registered on packagist for people to use it. This is very easy, just goto packagist.org and slick the Submit a Package button.
It is bad practice for people to run off your master branch since that could change and isn't guaranteed to be stable. When you add git tags like v1.0 it will be recognised as a release by both composer and Github. For each release in the future just add another tag thats appropriate for the version.

I have created tags for you previous versions, while this isn't too useful for people going forward it would be nice if you retain them:
https://github.com/elliotchance/xero-api/releases
eg:
git tag v0.5 0270057
git tag v0.4 0f1aac2
...
git push origin v0.5 v0.4 ...

:+1:, would really like to have version tags.

Another developer got so fed up with this library that he started a replacement from scratch: https://github.com/calcinai/xero-php
The code is MUCH better and he is very responsive to bug reports and pull requests. I suggest everybody start putting their effort in over there instead.

There hasn't been an commit since then but happy to add in versioning next time.
@gerrywastaken - yes it seems to be a great project, we are very supportive. If you don't have anything constructive to contribute in here though, maybe you should focus your time on being constructive there?

@ronanq you responded to my unconstructive comment in less than an hour! For two months @elliotchance and @cbakker have waited for a response to their constructive suggestions of adding tags. I won't apologize for pointing out that Xero is actively ignoring developers, although I don't blame you for this as it seems to be a company wide issue (see: http://xero.uservoice.com/forums/5528-xero-core-api)
Anyway, glad to hear you will be adding the tags.


Adding safari, iMessage, warp, slack, chrome, arc browser

Adding safari, iMessage, warp, slack, chrome, arc browser. Fixed category labels to match wakatime standards.

One last thing, the build needs to know how to bump the version from the branch name. Can you open a new PR with branch name feature/imessage-and-more-apps or similar? https://github.com/wakatime/macos-wakatime#contributing

redid with proper branch name


Flatbuffer 2.0.X support

Click to expand!
Issue Type
Build/Install
Source
source
Tensorflow Version
2.7 but i think 2.8 as well
Custom Code
Yes
OS Platform and Distribution
Conda-forge Liux
Mobile device
No response
Python version
Any
Bazel version
4
GCC/Compiler version
10
CUDA/cuDNN version
N/A
GPU model and memory
N/A
Current Behaviour?
It seems that some permutations of VerifyField have been removed from flatbuffers 2.0.X.

We were able to build conda-forge tensorflow with flatbuffers 2.0.0 but in some update we hit the bug. I'm attempting to build with 2.0.0 while the issue is resolved.

 https://github.com/Qengineering/TensorFlow_Lite_Pose_RPi_64-bits/issues/3

Standalone code to reproduce the issue
https://github.com/conda-forge/tensorflow-feedstock/pull/218

Relevant log output
79-broken_flatbuffers.txt

Related to: https://github.com/google/flatbuffers/issues/7272

This should been done already. Terry can you please confirm

Right. Let me close this. @hmaarrfk please feel free to reopen it if there is still an issue.


relative URL errors

Some of the relative URL's written in the /ride.html and /signin.html are written as "/css/ride.css" when they should be "css/ride.css"
Changes needed to ride.html are:

Changes needed to signin.html are:

Nevermind. It looks like a commit in April addressed this, but the S3 bucket repo provided in the AWS tutorial was never updated.


PCI-482 Basic Spring Boot application

usually in a start up project we include the .gitignore file, a Makefile, start.sh and readme.

Yes, @Mathsh, thanks for this suggestion. I will look into adding these files at this stage too, rather than later on as part of the Vagrant routing.