HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
159
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
432
master passed

+1
compile
73
master passed

+1
checkstyle
105
master passed

+1
shadedjars
357
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
39
master passed

0
spotbugs
276
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
275
master passed

_ Patch Compile Tests _

+1
mvninstall
336
the patch passed

+1
compile
59
the patch passed

+1
javac
59
the patch passed

+1
checkstyle
92
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedjars
326
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1119
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
277
the patch passed

_ Other Tests _

-1
unit
16557
hbase-server in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

20688

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotCloneIndependence

hadoop.hbase.client.TestAsyncRegionAdminApi2

hadoop.hbase.replication.TestReplicationKillSlaveRS

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e9951fefa59a 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/2/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/2/testReport/

Max. process+thread count
4636 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
411
master passed

+1
compile
63
master passed

+1
checkstyle
86
master passed

+1
shadedjars
301
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
271
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
269
master passed

_ Patch Compile Tests _

+1
mvninstall
352
the patch passed

+1
compile
63
the patch passed

+1
javac
63
the patch passed

+1
checkstyle
91
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
338
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1044
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
255
the patch passed

_ Other Tests _

+1
unit
9496
hbase-server in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

13271

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f35ea551b6a5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/3/testReport/

Max. process+thread count
4820 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
117
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
407
master passed

+1
compile
65
master passed

+1
checkstyle
92
master passed

+1
shadedjars
304
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
41
master passed

0
spotbugs
279
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
277
master passed

_ Patch Compile Tests _

+1
mvninstall
342
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
92
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
302
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1059
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
281
the patch passed

_ Other Tests _

-1
unit
14128
hbase-server in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

18051

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 9eccbfdff1e6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 83e77940c5

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/testReport/

Max. process+thread count
4706 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

It still is flaky after I revert HBASE-22857?

Thanks @infraio .

It still is flaky after I revert HBASE-22857?

Yes, it throws NPE when we run testFlushMarkersWALFail.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
435
master passed

+1
compile
68
master passed

+1
checkstyle
79
master passed

+1
shadedjars
278
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
245
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
244
master passed

_ Patch Compile Tests _

+1
mvninstall
299
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

+1
checkstyle
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
286
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
953
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
255
the patch passed

_ Other Tests _

+1
unit
10258
hbase-server in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

13812

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d9a026e531c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/5/testReport/

Max. process+thread count
4453 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
50
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
404
master passed

+1
compile
64
master passed

+1
checkstyle
92
master passed

+1
shadedjars
337
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
42
master passed

0
spotbugs
270
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
267
master passed

_ Patch Compile Tests _

+1
mvninstall
375
the patch passed

+1
compile
64
the patch passed

+1
javac
64
the patch passed

+1
checkstyle
90
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
337
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1172
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
42
the patch passed

+1
findbugs
284
the patch passed

_ Other Tests _

+1
unit
9412
hbase-server in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

13528

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5f3b8bacf823 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/6/testReport/

Max. process+thread count
4887 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
494
master passed

+1
compile
61
master passed

+1
checkstyle
98
master passed

+1
shadedjars
306
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
267
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
265
master passed

_ Patch Compile Tests _

+1
mvninstall
331
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
88
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
310
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1049
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
279
the patch passed

_ Other Tests _

+1
unit
10236
hbase-server in the patch passed.

+1
asflicense
38
The patch does not generate ASF License warnings.

14141

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 992df9b9a952 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / ee5cf0d209

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/7/testReport/

Max. process+thread count
4521 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
325
master passed

+1
compile
55
master passed

+1
checkstyle
79
master passed

+1
shadedjars
274
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
237
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
235
master passed

_ Patch Compile Tests _

+1
mvninstall
301
the patch passed

+1
compile
53
the patch passed

+1
javac
53
the patch passed

+1
checkstyle
78
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
272
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
910
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
240
the patch passed

_ Other Tests _

-1
unit
9238
hbase-server in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

12574

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestReplicationDroppedTables

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d5f719c506b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / b642ee0418

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/8/testReport/

Max. process+thread count
5251 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
361
master passed

+1
compile
63
master passed

+1
checkstyle
90
master passed

+1
shadedjars
304
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
41
master passed

0
spotbugs
272
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
269
master passed

_ Patch Compile Tests _

+1
mvninstall
333
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
88
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
306
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1058
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
288
the patch passed

_ Other Tests _

-1
unit
10394
hbase-server in the patch failed.

+1
asflicense
35
The patch does not generate ASF License warnings.

14168

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a79b55e5825d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / 97fbaa658e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/9/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/9/testReport/

Max. process+thread count
4478 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
356
master passed

+1
compile
61
master passed

+1
checkstyle
88
master passed

+1
shadedjars
303
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
239
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
237
master passed

_ Patch Compile Tests _

+1
mvninstall
330
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
87
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
305
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1057
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
281
the patch passed

_ Other Tests _

-1
unit
10914
hbase-server in the patch failed.

+1
asflicense
26
The patch does not generate ASF License warnings.

14614

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6b348cc6d259 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/10/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/10/testReport/

Max. process+thread count
4489 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
336
master passed

+1
compile
56
master passed

+1
checkstyle
81
master passed

+1
shadedjars
279
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
259
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
256
master passed

_ Patch Compile Tests _

+1
mvninstall
302
the patch passed

+1
compile
55
the patch passed

+1
javac
55
the patch passed

+1
checkstyle
79
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
270
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
941
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
272
the patch passed

_ Other Tests _

-1
unit
10552
hbase-server in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

14001

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/551

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d2fba61ee65f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/11/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/11/testReport/

Max. process+thread count
4512 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


How to convert stock original data to 1min data?

❓ Questions and Help
We sincerely suggest you to carefully read the documentation of our library as well as the official paper. After that, if you still feel puzzled, please describe the question clearly under this issue.

The 'close.bin'  differ from original data,  how to convert?

Hi, @zhwei79
Sorry, I'm a little confused about the question. What do you mean by orginal data,  1min data ?

Original data(stock SH600016) such as :

We download data/1min data (cn_data_1min\features\sh600016\close.bin) such as :

The price data in qlib is adjusted.
If you want to convert your original data to Qlib data. You can follow this tutorial

Not convert file format, but  how to normalize or standandize the column 'close' ?

And how to convert stock original price to the column "close"

The factor column should come from the users' data source
You can check the reference below

https://baike.baidu.com/item/复权因子/7564322?fr=aladdin
https://support.stockcharts.com/doku.php?id=policies:adjusted_data#:~:text=Historical prices are adjusted by,subsequently multiplied by this factor.

@zhwei79   Because adjusted price could potentially produce look-ahead bias.
To prevent changing the historical price.  Qlib normalized the price on the first date to 1.

@you-n-g Thanks a lot


Link to set-up instruction in python/tutorials/GEDI_Finder_Tutorial_Python.ipynb not working

Hi,
I was trying to follow the GEDI_Finder_Tutorial_Python.ipynb but the link to the set-up instruction in the "before starting" part is not working.
Best
Antje

@AntjeUhde, here's are some setup instructions that should work. We'll make sure to update the link in the tutorial.


About the gpu memory taken

I am inferring a picture size "1920*1080" on your model and my device is 3090 with 24G GPU memory. However, it seems like "CUDA OUT OF MEMORY" all the time. As shown in your paper, your model has low GPU memory taken. I want to know how to infer the "1920*1080" picture on your model with 24G GPU memory.

Hello, the main reason for "CUDA OUT OF MEMORY" is due to the DFFN module. Currently, if you want to test images with a resolution of 1920x1080, you can use a GPU with a larger memory size such as GPUthe A6000, or use a patch testing method. We have already solved this issue and please stay tuned for our future work.


[controller][test] Add verification tests for PubSubAdminAdapter APIs

Add verification tests for PubSubAdminAdapter APIs
Added tests to verify contracts of PubSubAdminAdapter APIs.
How was this PR tested?

CI
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Thanks for the review, @ZacAttack!


[AutoPR peering/resource-manager] chore: jsonfmt peering

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6191

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5653


Add a link to reports page

Adding a link to the reports page to the nav bar.

So, quick question, why add a link to Reports to the navigation? Are there any reports included in the app?

That's a good question.  No, not yet...  I worked on a couple reports and left them in my local fork.  I'm not sure if they will get pushed upstream at all now.
Let's kill this PR for now and we can revisit if it's needed in the future.  Thanks for double-checking on this.


[joss][nice to have] Provide demo data?

Part of: https://github.com/openjournals/joss-reviews/issues/6336
Hello!!
as usual I like the dead simple "drag a nifti onto this big box" interface, and I see the bear_uchar.nii.gz used in the tests as example data. For the sake of reviewers and also for potential users, would it be possible to have a "demo mode" that loads that example file from the UI so folks can test it out without needing to have a nifti on hand?
edit: brainbox has a great example of what i mean with the demo data selector :).

Thank you for the suggestion!
We implemented it in commit 58f8f09
Just one demo dataset – but we hope it's ok :)


Add Product Roots

This PR basically completely changes how products are handled in Dairycart

Coverage increased (+0.1%) to 99.539% when pulling 8a2007913f42b460669a0dbf084293c6923795ec on product-roots into f059bdaccad6c0995864961787442580d13dd45f on master.


Update insatance message management to match design

Design:
https://docs.google.com/a/google.com/document/d/1xvQSb4eLEhdebMRv44TYahxpjDMf7egndd0xRohgHM4/edit#

#873 and #872 should be fixed by this.

@iislucas,  do we still want to implement this, only thing left here is message type is little different, but logically somewhat the same.

Given we've just implemented: https://docs.google.com/document/d/1p16jeodYUYF9tp2mh9nDVIHlKagzHZLYVHRKZLZkspw/edit#heading=h.vsjk4lsteq6a
We should now update the instance messages design doc here:
https://docs.google.com/a/google.com/document/d/1xvQSb4eLEhdebMRv44TYahxpjDMf7egndd0xRohgHM4/edit#
And then we can close this issue.


feat(react): add inline hooks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

26 of 26 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
1032

Relevant Lines:
1032

💛  - Coveralls


"Maximum update depth exceeded" with useColor

My Environment

Dependency
Version

react-color-palette version
v6.1.0

Expected Behavior:
useColor can accept a rgb or hsv initial color as documented
Actual Behavior:
Using a color model that is not "hex" will trigger an infinite loop.
Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.

Additional Context:
Reproduced in this sandbox:
https://codesandbox.io/s/react-color-palette-infinite-loop-lzk0e?file=/src/App.tsx

Fixed in v6.2.0!


update dg model component uml

Codecov Report

Merging #285 (541ded3) into master (106b485) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #285   +/-   ##
=========================================
  Coverage     70.17%   70.17%
  Complexity      790      790
=========================================
  Files           127      127
  Lines          2602     2602
  Branches        316      316
=========================================
  Hits           1826     1826
  Misses          687      687
  Partials         89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106b485...541ded3. Read the comment docs.


⚠ Bofrost.es has degraded performance

In 6eb76ae, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1774 ms

Resolved: Bofrost.es performance has improved in 7747c1d after 57 minutes.


[SOLVED] Implement Product Retrieval by ID

Summary
Implement a function that allows for the retrieval of a specific product based on its ID from the products table.
Tasks

Create the Product model to include all necessary fields from the products table.
Create a service function in products_service.py to retrieve a product by its ID.
Integrate the product retrieval functionality into main.py such that when it's run, it fetches and displays the details of a product based on a given ID.

The task has a part 2 at https://github.com/Nightherald/aa-workshop-data-models/issues/6


added visp's story

Hey maintainer! Thanks for this repository!

Hey @5hre9a !  Thanks for merging my branch. I just had one question, is this repository not participating in the hacktoberfest? The name of the repo suggests it does, but I got a message saying this repository doesn't have a hacktoberfest label and hence PR won't count. They have suggested the maintainers to add hacktoberfest label.

@vismitap  thank you for bringing it into notice. As it is merged you don't have to worry about the label. Your contributions will definitely count.


Write scraper getting review scores for verge phone reviews

Write a scraper which scrapes the review scores from verge phone reviews

I was unable to complete this task durng sprint 3. This will be the first task I complete during sprint 4.


$slug = str_slug($request->title, '-');

use composer require laravel/helpers
This should solve the issue.
You can check the modified devdojo chatter in my git repo

use composer require laravel/helpers
This should solve the issue.
You can check the modified devdojo chatter in my git repo


dynamic line weight based on zoom level

feedback from @burritojustice

also try out toggles for transparency, individually colored route lines


[Rate Limit Support for turbo]

Is your feature request related to a problem? Please describe.
Add a rate limit capability you our turbo config.
Describe the solution you'd like
Create a rate limit package for turbo and provide its implementation.

This is very much needed feature. I am thinking of having this as a separate module and use that in Turbo. We may want to have this for other transport implementation as well.
Here are the high level features we may want to implement for a specific client

Simple rate limiting per unit time
Burst Limit - We may want to allow a burst limit per specific period.
Custom limits over different periods
Overall limit per period
Combination of above

The rate limit information may have to be stored in a cache to support multiple instances serving the requests.


fix: Typographical error on karpenter-values-template.yaml

Fixes #
Description
There is a typographical error in the helm values template file.
How was this change tested?
Nothing to test, it's on a comment.
*
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

NONE

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.766%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
36286

Relevant Lines:
37115

💛  - Coveralls


Issue uploading to FTP

Hi, firstly thanks for writing this script!
I have the following issue while trying to get the file to send via FTP:
'Using binary mode to transfer files.
550 Can't create directory: File exists
250 OK. Current directory is /backups
200 TYPE is now 8-bit binary
local: /home/backup/backup.incoming/04-05-2015-daily.tgz remote: .
200 PORT command successful
553 Can't open that file: Is a directory
221-Goodbye. You uploaded 0 and downloaded 0 kbytes.
221 Logout.'
Thanks

Sure thing. Give me a bit to look at it.

Hi could you try the new version

fixed on https://github.com/todiadiyatmo/bash-backup-rotation-script/commit/fbc8abf6bd149833a4720e9e52a62483f71db756


add 'forbidExplicitDeclaration' option for display-name rule

When using JSX and accepting the transpiler name for displayName, it may be preferable to then forbid explicit displayName definitions. This adds that option to the rule

Hi, and sorry for the review delay.
Thanks for this useful option, I'm totally ok to add it to the display-name rule.
But I found a small issue, since the hasDisplayName property is also true if the transpiler can find a name, this option will warn in all cases, with or without an explicit displayName.
Failing example:
class Hello extends React.Component {
  render() {
    return
Hello {this.props.name}
;
  }
}

Will warn:
Explicit display name definition is forbidden

No worries about the delay @yannickcr. I'll work on differentiating between the two types of names ASAP


Going back from normal mode to command mode

Is there a way to get back from normal mode to command mode?
I thought simple pressing <TAB> again would do the trick, but it ain't so...

Found solution in closed issues, disregard...

Duplicate of #158 .


Separate perl5db stdio from debuggee stdio

Ideally the extension should have separate communication channels for debugger and script. Right now it mixes them, and when a script prints to stderr the contents is interpreted by the extension. As an example,
print STDERR "Execution of 1.js aborted due to compilation errors.\n";

Currently this has fatal consequences, but should not have any consequences at all, scripts should use stderr as they see fit without any effect on the debugger.
It ought to be possible to separate the two channels, currently I am experimenting with
diff --git a/src/adapter.ts b/src/adapter.ts
index f838c29..055593d 100644
--- a/src/adapter.ts
+++ b/src/adapter.ts
@@ -343,6 +343,9 @@ export class perlDebuggerConnection {
                        }
                });

+               await this.streamCatcher.request('do { open STDERR, "+>&=", 4; DB::_autoflush(STDERR); };');
+               await this.streamCatcher.request('do { open STDOUT, "+>&=", 3; DB::_autoflush(STDOUT); };');
+
                // Depend on the data dumper for the watcher
                // await this.streamCatcher.request('use Data::Dumper');
                await this.streamCatcher.request('$DB::single = 1;');
diff --git a/src/localSession.ts b/src/localSession.ts
index b8f0fc3..922e324 100644
--- a/src/localSession.ts
+++ b/src/localSession.ts
@@ -21,6 +21,7 @@ export class LocalSession implements DebugSession {
                const spawnOptions = {
                        detached: true,
                        cwd: cwd || undefined,
+                       stdio: ["pipe", "pipe", "pipe", "pipe", "pipe"],
                        env: {
                                COLUMNS: 80,
                                LINES: 25,
@@ -34,6 +35,17 @@ export class LocalSession implements DebugSession {
                this.stdout = session.stdout;
                this.stderr = session.stderr;
                this.pid = session.pid;
+
+               const stdio = session.stdio as any[];
+
+               stdio[3].on("data", x=> {
+                       console.log("stdio3 data: " + x);
+               });
+
+               stdio[4].on("data", x=> {
+                       console.log("stdio4 data: " + x);
+               });
+
                this.on = (type, callback) => session.on(type, callback);
                this.kill = () => session.kill();
                this.title = () => `${perlCommand} ${commandArgs.join(' ')}`;

This should also allow capturing stdout/stderr in remote debugging scenarios. But there are quite many unknowns at this point.

How does mixing debugger stdin and script stdin work at the moment, how should it work.
With remote debugging, do users want to redirect output from their remote terminal into vscode?
Could they have both, i.e. duplicating rather than redirecting remote terminal output?
Where should script stdout and script stderr actually go in vscode? Right now in the debug console script stderr is suppressed and stdout mixed with debugger output.
What are the right open modes to use? What if the open calls fail?
Are there any adverse consequences doing this?
Does this work on Windows?

Might be worth trying something like this behind a default-off configuration option?
Edit: Come to think of it, might be worth considering making local debugging also use a remote debugging setup (call perl -d with a remote port set), that might simplify a few things.

How does mixing debugger stdin and script stdin work at the moment, how should it work.

Local debugging with e.g.
my $line = <STDIN>;
print "You said: $line\n";

results in a hang, you can enter stuff in the debug console, but then nothing happens until you switch to some other tab and then back to the debug console, where you can then see that your input made it to the debugger, not the debuggee. With remote debugging everything works as expected (you can enter your input in the remote terminal where your input is echoed and printed).

I think the real problem is in remote debugging - because the sdtout and stderr are combined

In remote debugging, the extension currently has no access to the debuggee's stdio, it only talks to the debugger which does not forward anything. Simple test setup, one terminal with the listener nc -l -p 5000 and then one with the rest PERLDB_OPTS="RemotePort=localhost:5000" perl -d -E "say STDOUT 'stdout'; say STDERR 'stderr'".
In the listener terminal you get an interactive debugger session like so:
Loading DB routines from perl5db.pl version 1.53
Editor support available.

Enter h or 'h h' for help, or 'man perldebug' for more help.

main::(-e:1):	say STDOUT 'stdout'; say STDERR 'stderr'
  DB<1> l
1==>	say STDOUT 'stdout'; say STDERR 'stderr'
  DB<1> r
Debugged program terminated.  Use q to quit or R to restart,
use o inhibit_exit to avoid stopping after program termination,
h q, h R or h o to get additional info.
  DB<1> q

While in the other terminal you get the stdio from the script:
stdout
stderr

the perl debugger extension is running the perlDB in interactive mode - I would be fine with one output stream (instead of both stderr + stdout)
But we would have to figure out a way to separate the two eg. by prefixing both steams so that we can tell the difference between debugger output and application output.
This works locally using 2 output steams but not remotely because we only have one. (I agree that if we can solve it for remote debugging we could generally settle with one output stream - both locally and remote)

Turns out vscode has added a »Terminal« feature since you made the extension. Investigating along these lines now:
diff --git a/src/adapter.ts b/src/adapter.ts
index f838c29..f093fbe 100644
--- a/src/adapter.ts
+++ b/src/adapter.ts
@@ -296,11 +301,10 @@ export class perlDebuggerConnection {
                this.logOutput(`Platform: ${process.platform}`);
                this.logOutput(`Launch "perl -d ${sourceFile}" in "${cwd}"`);

                // xxx: add failure handling
                if (!options.port) {
                        // If no port is configured then run this locally in a fork
-                       this.perlDebugger = new LocalSession(filename, cwd, args, options);
+                       this.perlDebugger = new RemoteSession(0);
                        this.logOutput(this.perlDebugger.title());
                } else {
                        // If port is configured then use the remote session.
@@ -308,6 +312,22 @@ export class perlDebuggerConnection {
                        this.perlDebugger = new RemoteSession(options.port);
                }

+               await new Promise(
+                       resolve => this.perlDebugger.on("listening", res => resolve(res))
+               );
+
+               const foo : DebugProtocol.RunInTerminalRequestArguments = {
+                       cwd: cwd,
+                       args: ["perl", "-d", filename].concat(args),
+                       env: {
+                               PERLDB_OPTS: `RemotePort=localhost:${this.perlDebugger.port}`,
+                               ...options.env
+                       }
+               };
+
+               session.runInTerminalRequest(foo, 5000, response => {
+               });
+
                this.commandRunning = this.perlDebugger.title();

                this.perlDebugger.on('error', (err) => {
diff --git a/src/remoteSession.ts b/src/remoteSession.ts
index bac85ff..a86b86b 100644
--- a/src/remoteSession.ts
+++ b/src/remoteSession.ts
@@ -13,6 +13,7 @@ export class RemoteSession implements DebugSession {
        public kill: Function;
        public title: Function;
        public dump: Function;
+       public port: Number | null;
        private event = new EventEmitter();

        constructor(port: number) {
@@ -71,7 +72,11 @@ export class RemoteSession implements DebugSession {
                        });
                });

-               server.listen(port, '<IP_ADDRESS>'); // Listen to port make it remotely available
+               server.listen(port, '<IP_ADDRESS>', () => {
+                       this.event.emit('listening', ()=>{});
+                       this.port = server.address().port;
+               }); // Listen to port make it remotely available
+
                server.on('error', data => {
                        this.event.emit('error', data);
                        this.kill();

That gives you a debug console where you interact with the debugger, and a terminal where you interact with the debuggee. The debuggee is launched there like
% cd /.../ ; env \
  "PERLDB_OPTS=RemotePort=localhost:41771" \
  "PATH=... "PERL5LIB=" \
  perl -d /.../example.pl

In the debug console you also have the ability to write (in the bottom there is a text input) - That said the terminal might be good for debugging the extension - but we still need to figure out a way to separate the debugger output and the application output from the single stream when remote debugging. Eg. To make sure the extension only acts on debug output and leave the application output as is.

With https://github.com/raix/vscode-perl-debug/commit/a10fa81a8664c2103613435047ae4bfa077220a5 this is basically fixed.


uint128 param read from table is different from printui128

In contract side i generate a uint128 number and use printui128 to show in console log, which is<PHONE_NUMBER>0967693355762309706792566786. And when i retrieved from table it shows 0x02000000000000001052bc9483ac3036 (which is little-endian hex encoded).
But when i change 0x02000000000000001052bc9483ac3036 to decimal string with big endian, it shows<PHONE_NUMBER>79637306740937603029919596576 which is not equal to the original uint128 value.

Oh that's my error of endian swapping.


added prometheus hook, fixed log behavior

Prometheus hook is added.
But destination filename is concreted in the code.
Fixed some problems with the logging also.

Please can you alter the writing of the prom file as follows:

Change the mode from a to w (it's not a log file - it should get replaced when there is new data)
Add these two lines at the top of the file:

#HELP lasair_alert_batch_lag Lasair alert batch lag stats
#TYPE guage

Is it really TYPE guage or should it be TYPE gauge?

OK I pushed it


Use https instead of curl, update scripts, update travis config

Prefer node-native https over exec/curl
Update package.json
Update travis config:

Use LTS versions
Cache node_modules
Use npm script for coverage

Coverage decreased (-2.4%) to 97.619% when pulling e0efae8c328119cb7a692379fdc70629240e74d2 on binoculars:feature/no-curl into 42d59a7641ed0ca5a22368a68836049bf79ffc16 on DavidCai1993:master.

I've started seeing `stdout maxBuffer exceeded " error messages caused by this module. Presumably this PR will fix those, too.


mixer::Music is unsound

It has its internal fields exposed publicly, allowing the user to break its invariants using safe code.
Example:
let mut music = Music::from_file("foo.mid")?;
music.raw = 0xDEADBEEF as *mut _;
let _ = music.play(-1);

I think the original author made raw public so that unsafe methods from the ffi could be used, but it's true that allowing to change the raw pointer is clearly undefined behavior ... Even if we assume that the pointer is changed but not played afterwards, drop will still be called on a value that isn't valid, while the other value will effectively be leaked memory.
The solution would be to remove the pub attributes and add a as_raw(&self) -> *mut c_void method if someone really needs the underlying pointer.
I don't know why owned is public either, but it shouldn't be.


Fix python 3.12 incompatibility

Fixes #584 Turn off using subunit in libcheck to fix incompatibility

Thank you !


New onboarding view

Description
Rework the onboarding view to make it simpler and more accurate.

#194 is a draft of this


Custom layer elements moving around when zooming off-center

Using the example from http://mourner.github.io/Leaflet/reference.html#layer
http://jsfiddle.net/stz8fm3y/

That example seems to be outdated and should be replaced with something like
    onAdd: function (map) {
        // create a DOM element and put it into one of the map panes, by default the overlayPane
        this._el = L.DomUtil.create('div', 'my-custom-layer leaflet-zoom-hide');
        this.getPane().appendChild(this._el);

        // add a viewreset event listener for updating layer's position, do the latter
        this.update();
        map.on('zoom viewreset', this.update, this);
    },

    update: function () {
        // update layer's position
        var pos = this._map.latLngToLayerPoint(this._latlng);
        L.DomUtil.setPosition(this._el, pos);
    }
});

Note that _reset() (or update()) is now not called automatically on map zoomend or viewreset.
Please feel free to create a pull request (to the gh-docs-master branch) to update the documentation.


Fine tuning guide with custom dataset using pretrained coco model

I am trying to train a dino model and using the model, fine tune a dino model with my dataset.
I trained dino mode on the coco dataset at 12 epochs through the swin large 4 scale config
Then load the weights as a pretrained model to fine-tune it with my custom dataset.
Because the dataset I am trying to fine tune has different num_classes, so I will have to change the prediction layer num classes output and start fine tuning training.
How should I tweak the config for reuse? Or what part of the code should be modified?
I'd like to get the guide.
Regards,
Keanu

Hi!
The "dn_labebook_size" from the config file has to be changed to the number of classes in your custom dataset..

When fine-tuning a COCO pre-trained model on your custom dataset, the main difference between two datasets is the number of classes.
As said by @gd1925, the arg "dn_labebook_size" should be equal to or larger than the number of classes.
When loading pre-trained models, we suggest using "--pretrain_model_path" to specify a pre-trained model, and using "--finetune_ignore label_enc.weight class_embed" to ignore some inconsistent parameters.

Thank you for your advice! It works.

When fine-tuning a COCO pre-trained model on your custom dataset, the main difference between two datasets is the number of classes.
As said by @gd1925, the arg "dn_labebook_size" should be equal to or larger than the number of classes.
When loading pre-trained models, we suggest using "--pretrain_model_path" to specify a pre-trained model, and using "--finetune_ignore label_enc.weight class_embed" to ignore some inconsistent parameters.

@SlongLiu Hi did you use same fine-tuning method (importing all weights except for cls_embedding weight) as mentioned in this line Object365 to COCO?

When fine-tuning a COCO pre-trained model on your custom dataset, the main difference between two datasets is the number of classes.
As said by @gd1925, the arg "dn_labebook_size" should be equal to or larger than the number of classes.
When loading pre-trained models, we suggest using "--pretrain_model_path" to specify a pre-trained model, and using "--finetune_ignore label_enc.weight class_embed" to ignore some inconsistent parameters.

@SlongLiu Hi did you use same fine-tuning method (importing all weights except for cls_embedding weight) as mentioned in this line Object365 to COCO?

Yes, exactly.

Actually, 'dn_labebook_size' is 'dn_labelbook_size' .


Data Parallel

Thank you for your code. It looks like you have tried to use nn.DataParallel but didn't quite include it in there. Can you tell me your experience with it?
For some reason, the loss kept increasing when I used nn.DataParallel with 2 GPUs regardless of batch size. To make it run with your code, I changed your calc_loss a little bit by expanding logdet to have same size as log_p. I also tried logdet.mean(), but it didn't work either. Here, I'm not really sure why logdet values are different for the 2 GPUs, as it seems to depend on shared weights only.

As ActNorm uses individual batch to calculate statistics and initialize the parameter using it, in DataParallel scenario it scrambles model training (like batch norm). If you can forward once in 1 GPU (without backward), then ActNorm will be initialized properly and you can use DataParallel to train your model. I found this enables multi gpu training. (without this model is not trainable.)

Aha! I thought it had something to do with ActNorm, but your explanation made it very clear. Do you know the best way to forward a batch in one GPU while avoiding doing so in others?

You can check this f8805e7. This is my workaround. If you can forward 1 batch in 1 GPU this will work. If it is not then it will be quite complicated... (You should do multiple forwards and grab statistics to initialize ActNorm.)

Thank you for the change, but I didn't quite work for me. My understanding is that the problem has something to do with two GPUs having different weights after initialization. I don't think calling forward on individual GPUs would synchronize their weights.

I have a similar problem running the code. Running on a single GPU works fine but logdet would have different values on a multi GPU case.


Refactor K8ssandraCluster deletion cleanup operation

In controllers/k8ssandra/cleanup.go we delete all the objects that are tied to a deleted K8ssandraCluster object.
The deleteDeployments(), deleteServices() and deleteConfigMaps() could benefit from the following improvements:

Combine them into a generic function/method if possible
Move a few function arguments to the K8ssandraClusterReconciler object in order to reduce their number in the calls
Evaluate the possibility of returning a more meaningful object than a boolean, which could carry more information (such as an error or a ReconcileResult)
make use of DeleteAllOf, using the labels in the LabelSelector, instead of looping over objects to delete
Write unit tests for it

Note: this is closely related to #961.
As I'm digging into the code I'm encountering more questions:

there are two main methods: checkDeletion which handles the deletion of the whole cluster, and checkDcDeletion which handles a single DC (if it's been removed from the cluster spec). However they don't share any code, which feels like a wasted opportunity for reuse.
case in point: checkDeletion removes Stargate, Reaper, deployments, services and configMaps. checkDcDeletion only removes Stargate and Reaper. Decommissioning a DC does indeed leave at least one configMap behind (tested on a very simple cluster, there's probably more in complex scenarios).
checkDcDeletion looks up the components by exact name. checkDeletion deletes every cluster sub-component in the current namespace. This works now but is something we'll need to keep in mind if we factor the code (two DCs can exist in the same namespace, so we can't reuse the shotgun approach for decommission).
the Stargate/Reaper deployments and services already use a controller reference for garbage collection. It looks like deleteDeployments and deleteServices were only added for Medusa. Why can't we use controller references there too?

In fact, I think we could generalize the use of controller references. As long as every remote object we create is owned by the CassandraDatacenter (directly or not), we shouldn't need to do anything beyond deleting the DC.
I'm going to experiment with that.


Removed Invalid Section

Removed "How can users identify Azure Stack usage data in the Azure billing portal?" section as the information supplied is not true. There is no way for Azure Stack tenants to view Azure Stack usage data through the Azure account center.

@BaileyLawson : Thanks for your contribution! The author, @sethmanheim, has been notified to review your proposed change.

@BaileyLawson Thank you for catching that, and for the contribution! It's much appreciated.
#sign-off


TypeError: Cannot call method 'trim' of undefined

Hello,
I'm getting the following error:
/usr/lib/node_modules/octalbonescript/src/hw_universal.js:77
callback(state.trim());
^
TypeError: Cannot call method 'trim' of undefined
at /usr/lib/node_modules/octalbonescript/src/hw_universal.js:77:28
at fs.js:207:20
at Object.oncomplete (fs.js:107:15)
with the following code
b.pinMode('P8_07', b.OUTPUT);
on Ubuntu 13.10
Kind regards,
Jacco

Hello, this error generally means that the pin is being used by other cape. May be you can check your slots file? You can post output of cat /sys/devices/bone_capemgr.9/slots command here.

These kind of errors will be made more intuitive in v1.0.0 of OBS. We already know these ambiguous errors and working on the same to improve them.

Hello Hardik,
Thanks for your reply. I'm pretty sure that the pin was not in use by another cape. I disabled hdmi which also use this specific pin.
The code works with Bonescript but with Octalbonescript I now get:
error: Unable to read from CapeMgr slots: Write to CapeMgr slots failed: Error: EEXIST, file already exists
error: Writing to GPIO failed: Error: EPERM, operation not permitted
Regards,
Jacco

I can see that some other capes are mounted. They are preventing the universal cape manager from loading. Can you unload them and then check again?

Disabled the extra UARTS. Slots now show:
0: 54:PF---
1: 55:PF---
2: 56:PF---
3: 57:PF---
4: ff:P-O-L Bone-LT-eMMC-2G,00A0,Texas Instrument,BB-BONE-EMMC-2G
5: ff:P-O-- Bone-Black-HDMI,00A0,Texas Instrument,BB-BONELT-HDMI
6: ff:P-O-- Bone-Black-HDMIN,00A0,Texas Instrument,BB-BONELT-HDMIN
This code:
b = require('/usr/lib/node_modules/octalbonescript');
b.pinMode('P8_07', b.OUTPUT); // pin attached to RSE on RS485 board
b.digitalWrite('P8_07',0);    // set to receive
Gives me: error: Writing to GPIO failed: Error: EPERM, operation not permitted

May be you can try this code?

b = require('/usr/lib/node_modules/octalbonescript');
b.pinMode('P8_07', b.OUTPUT,function(resp, pin){
    b.digitalWrite('P8_07',0); // set to receive
}); // pin attached to RSE on RS485 board

Please note that pinMode function is async in octalbonescript and you need to rely on callback to know about its completion.

This was not a bug but a better error message is supplied in v1.0.0 when the pin is not available to OBS.

Unfortunately this gives me the same error: Writing to GPIO failed: Error: EPERM, operation not permitted

Do you have root permission on the board? You may also want to run DEBUG=bone node yourscript.js to identify some of the issues.

I have root permissions.
It looks like the the following line in /boot/uboot/uEnv.txt is the problem:
optargs=quiet drm.debug=0 capemgr.enable_partno=BB-UART1,BB-UART4,BB-UART5
The debug log with the UARTs enabled is:
debug: is_ocp() = /sys/devices/ocp.3
debug: is_cape_universal() = undefined
debug: Loading Universal Cape interface...
debug: create_dt_sync(d,0,OBS_UNIV,true,,)
debug: onDTBOExists()
debug: load_dt_sync(OBS_UNIV,d,{})
debug: onFindCapeMgr: path = /sys/devices/bone_capemgr.9
debug: onReadSlots: index = -1, readAttempts = 1
debug: Writing OBS_UNIV to /sys/devices/bone_capemgr.9/slots
error: Unable to read from CapeMgr slots: Write to CapeMgr slots failed: Error: EEXIST, file already exists
debug: load_dt resp: {"err":"Unable to read from CapeMgr slots: Write to CapeMgr slots failed: Error: EEXIST, file already exists"}
debug: load_dt return: false
debug: Loading AUDIO Cape...
debug: create_dt_sync(d,0,OBS_AUDIO,true,,)
debug: onDTBOExists()
debug: load_dt_sync(OBS_AUDIO,d,{})
debug: onFindCapeMgr: path = /sys/devices/bone_capemgr.9
debug: onReadSlots: index = -1, readAttempts = 1
debug: Writing OBS_AUDIO to /sys/devices/bone_capemgr.9/slots
debug: onReadSlots: index = 496, readAttempts = 2
debug: OBS_AUDIO is already loaded
debug: load_dt resp: {}
debug: load_dt return: true
debug: Loading HDMI Cape...
debug: create_dt_sync(d,0,OBS_HDMI,true,,)
debug: onDTBOExists()
debug: load_dt_sync(OBS_HDMI,d,{})
debug: onFindCapeMgr: path = /sys/devices/bone_capemgr.9
debug: onReadSlots: index = -1, readAttempts = 1
debug: Writing OBS_HDMI to /sys/devices/bone_capemgr.9/slots
error: Unable to read from CapeMgr slots: Write to CapeMgr slots failed: Error: EEXIST, file already exists
debug: load_dt resp: {"err":"Unable to read from CapeMgr slots: Write to CapeMgr slots failed: Error: EEXIST, file already exists"}
debug: load_dt return: false
debug: Using Universal Cape interface
debug: Enabling analog inputs
debug: load_dt_sync(cape-bone-iio,,)
debug: onFindCapeMgr: path = /sys/devices/bone_capemgr.9
debug: onReadSlots: index = -1, readAttempts = 1
debug: Writing cape-bone-iio to /sys/devices/bone_capemgr.9/slots
debug: onReadSlots: index = 559, readAttempts = 2
debug: cape-bone-iio is already loaded
debug: load_dt resp: {}
debug: load_dt return: true
debug: index.js loaded
debug: pinMode(P8_07,out);
debug: hw.setPinMode(P8_07,gpio,{"value":true});
error: onComplete problem: Error: ENOENT, open 'undefined/state'
debug: returned from setPinMode
error: Unable to configure mux for pin [object Object]: Error: ENOENT, open 'undefined/state'
debug: getPinMode(P8_07);
/media/sd1/node/test/node_modules/octalbonescript/src/hw_universal.js:77
callback(state.trim());
^
TypeError: Cannot call method 'trim' of undefined
at /media/sd1/node/test/node_modules/octalbonescript/src/hw_universal.js:77:28
at fs.js:207:20
at Object.oncomplete (fs.js:107:15)

Yeah, you should unload UARTs for this library to work successfully. If you need to use UARTs also, please wait for v1.0.0 which I am going to release soon. It natively supports serial ports without need to load additional cape.

I need the UARTs so I keep using bonescript and will wait for octalbonescript v1.0.0 to become available.
Thanks for your help.

Actually I am in process of writing docs for the same as many APIs changed. I will publish once docs are ready. I will ping you so you can test UART code.

@jaccobezemer OBS v1.0 is now available... Give it a try?

Just this line:
var b = require('octalbonescript'); //load the library
Gives this error:
/usr/local/lib/node_modules/octalbonescript/index.js:141
"a callback function as third argument to know completion of pinMo
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Unexpected token ILLEGAL
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/media/sd1/node/modbus/modbus.js:11:9)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)

Can you give me debug output? DEBUG=bone node yourscript.js

You mean you did not even call pinmode and it throws this error?

I pushed a new version. May be you can check again?

I checked. No error anymore. Great!
I do have a problem though with the fact that I can't enable serial ports anymore from uEnv.txt.
Not all serialports are used from within node scripts. When I enable one serialport from uEnv.txt and another one with octalbonescript I get Error: Write to CapeMgr slots failed: EEXIST, file already exists
So when using octalbonescript its not possible to use a serialport enabled from uEnv.txt?
If so then I think I need to rewrite a lot of code when using b.serial.open instead of new serialport.
For instance this code:
serialport = require("serialport");
self.serial = new serialport.SerialPort(self.config.serialPort.dev, {
	baudrate: self.config.serialPort.baudrate,
	databits: self.config.serialPort.databits,
	stopbits: self.config.serialPort.stopbits,
	parity: self.config.serialPort.parity
});

   <some other code>

self.serial.on('open', function () {
	self.emit('open');
	self.serial.on("data", function (data) {
		//console.log(data);
		if (receive) {
			self.processResponse(data);
		}
	});
});

How would this code looks like with octalbonescript?

That's because the serial port device-tree is already loaded via universal-cape. What we suggest you is to either use serial.open or serial.enable from OBS and never load different cape from uEnv.txt. It is one and the same thing but achieved in a better manner.

That is a possibility. Unfortunately it's not that easy (for me).
I have a daemon running that uses a serialport. That port is available directly after boot.
If a have to load a node script as helper then I have a dependency an possibly a start order problem.
It would be nice if there is an option to disable serialport handeling and not have the capmgr error.

Okay, then I can make universal-cape even more modular and load the serial port only if it has not been loaded. Let's wait for inputs from community and I will also think if that change is worth making for all users. Meanwhile, try if you can get around this problem by modifying how you handle the serial port. I will get back to you.
Thanks for your inputs :)

@adityapatadia do you have any new thoughts on this?  We have the same thing where we need to leverage the UARTS within a C program and then node.js handles portions as well.

Hi, changing Universal cape requires time and a lot of testing. I currently don't have time to do it right now. If some day I get time I would look into it. Meanwhile if some of you can help me with it, I will be happy to merge it.
If possible, can you explain me why is such change needed and if there is absolutely no way to keep OBS same and achieve what you are trying?
Let me know, may be we can solve it by understanding it well.


Update installation.md

Hopefully it is now easier to understand

i have made a better version so closing


[Feature Request] "Sticky" game messages

Add an option for game messages to "stick" to the bottom of a channel by basically just running .au r every time a message is sent in the channel.

Appreciate the suggestion, but I don't think this is feasible, unfortunately. We already max out the discord api rate limits with all the mutes/unmutes, and from what I've seen, refreshing the status message is a 14 full api requests (1 for message, 13 emojis). Any users that post a message (forcing the status to refresh automatically) would incur 14 requests amidst the ~10 we already struggle to issue at round transitions

Yeah thats what I figured, the only way to do this would be to send the message and not add reactions automatically which is just less intuitive than #101


Add NSCG Stafford College

website: https://nscg.ac.uk

@Oribuin First stage of verification passed, official domain is nscg.ac.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Oribuin Pull request merged. Thank you!


Added react-native-windows support

Added support for react-native-windows (identical to android
implementation)
Fixed lint error

Tests pass.

@emilioicai I'm guessing you're not paying attention to this repo, but would you mind publishing a new version with these changes? lottie-react-native uses this, and I'm trying to add support windows there (https://github.com/microsoft/react-native-windows/issues/3278).

Hi, @emilioicai, would you mind publishing a new version with the changes?


[GUI] Send Tab PrivateSend/InstantSend Check Boxes to Dark

The privatesend and instantsend check boxes on the send tab are too dark. The contrast between the black background  and the green check mark is very bad. I would suggest changing the black background to some other color or changing the green check mark to white or a lighter color.

I've tested this on 4 different computer screens and they are all very hard to see.

ping @crowning-

I'll have a look tomorrow, thanks for pinging :-)

I'm using Ubuntu 16.04 (is unity default? that's what I'm using). It looks alright on my laptop screen, still a little bit fuzzy though, and on my external monitor it's really hard to see. Maybe my eyes are just getting bad. What color green is that arrow?

If I remember correctly we don't set the the color, the color of the arrow+box depends on the desktop (not wallet!) theme you're using.
Should be an easy fix once I can reproduce the problem.

@schinzelh I installed an Ubuntu 16.04 testbox and found some things we need to address:

Ubuntu 14.04 built binaries don't run on Ubuntu 16.04 because 14.04 uses boost 1.54, 16.06 uses boost 1.58. And the other way around is also a problem. This should be noted in the build-documentation. (I can do this)

There are no 1.58 packages for Ubuntu 14.04, and no 1.54 packages for Ubuntu 16.06, so a 'normal' end-user won't be able to run dash-qt if the build was done on the 'other' system.

The issue mentioned by @cassidysummers, even when not related to boost, disappears when you run a Ubuntu 16.04/boost 1.58  built wallet.

I wouldn't want build version-dependent Linux binaries, but right now I don't see an easy way around this.
What do you think?

@crowning- Hmm, did you test Bitcoin as well? Do they have the same issue?

Will try...

So, I built Bitcoin on Ubuntu 14.04 and 16.04 and it has the BOOST version issues as well.
Not the checkbox issues, though, but our traditional (sans-CSS) wallet doesn't has them either.

...on a second thought, our Gitian build runs on BOTH Ubuntus (minus the checkbox issue).
Do you know where the build scripts differ?

Not sure what you mean with "runs on both"? You mean our gitian builds are compatible with Ubuntu 14.04 and 16.04, while the Bitcoin binaries from bitcoin.org/downloads do are not?

The Dash + Bitcoin Gitian builds run fine on both Ubuntus, but the Dash-build has the checkbox-issue in the non-Qt (aka CSS) themes on Ubuntu 16.04. I could fix the CSS-issue.
The Dash + Bitcoin native builds complain about the wrong BOOST version, but when given the correct BOOST dynamic (= *.so) library for each Ubuntu version they will run fine, and for the Dash-CSS-themes the checkboxes look okay.

Never mind, native builds are supposed to by dynamically build.
To be back on topic, I know the reason for the dark labels and will fix it later today or tomorrow.

Status summary:

there's no easy fix in CSS (that I know of) which works for all of our checkbox+background combinations AND looks good.
it's not clear whether Qt or Ubuntu 16.04 is the problem.
even if we should find some CSS-magic to solve this we could face the same problem again when the next update of OS (Ubuntu, Debian, SuSE, Redhat, etc.) times desktop (Gnome, Unity, KDE, etc.) times available desktop themes/color-schemes is available.
the behavior is different for native Dash builds and static builds via Gitian, so we would have to test both each time we test something. That's a serious PITA. I know because I did exactly this during the last days.

My Conclusion:
the simplest way to work around all those future problems would be to use our own images for checked/unchecked checkboxes. We did this already for the scrollbar-arrows (see https://github.com/dashpay/dash/tree/v0.12.1.x/src/qt/res/images/light), so we could do this easily for checkboxes as well, it's no big deal via CSS.
The only disadvantage I see is that we won't always have the latest blinky look of the underlying OS. OTOH this could also be and advantage :-)
At this point (and if nobody complains) I'd like to hand over to our trusted masters of beautiful image design @snogcel and @salmion .
If you should need help integrating/testing the new images into the Gitina build process we should coordinate this over at slack.

@crowning- agree, there is no easy fix for this and it is an issue which we share with many multi OS software.
Having all images rendered out and not rely on underlying OS theme is ok for me.

@cassidysummers this should be fixed by #868, pls verify using test builds https://www.dash.org/forum/threads/v12-1-testnet-launch-thread.9014/page-18#post-96308
Thanks!


[#65] Add dynamic object pool scaling

What's New

The VT Client can now automatically scale an object pool to your destination VT! 🥳

Here are some screenshots from my VT showing some different scale factors. My terminal has 480x480 data mask area, and 72x72 soft key designators.

Closes #65
Minor stuff

Made one minor update to the example object pool to fix some object alignment.
Cleaned up some lingering doxygen warnings.
Clarified tutorial build instruction

Hmm, it seems to fail on my end. When I add
TestVirtualTerminalClient->set_object_pool_scaling(0, 400, 400);

to the vt_version3_object_pool after it's set, which was still missing I guess? I get the following error when it's trying to scale:

Dang! I'll see if I can reproduce it... I also need to write some tests to make Sonar happy...

@GwnDaan I think I've fixed that crash you were seeing, and we've just got the one unresolved topic left

The scaling part works great now, Good job! 😄

Our coverage dropping percent is a bit sad, but it is at least somewhat attributable to this: https://github.com/gcovr/gcovr/issues/529
gcovr doesn't like initializer lists it seems...
I have noticed a lot of lines are only partially covered due to gcovr expecting us to test every exception-only path, so it might make sense to disable exception-only paths in its analysis --exclude-throw-branches
Regardless, I'll try and add some additional tests...

Looking dope! This has surely been a long-winded feature to implement. I propose we merge this in sooner than later. I feel like a PR for additional test cases can always be created afterwards, and we have a few PR's now that depend on this one getting merged.

Agreed. We're still kind of iterating on our CI settings and things anyways, and we can certainly come through before a stable release and shore up our testing further. I'll merge it in for now after fixing the one conflict.


Updated references from docs.microsoft.com - to learn

Description
The PR updates references from docs.microsoft.com - to learn.microsoft
Issue reference
This PR doesn't close an issue.
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list:

[x] All acceptance criteria in the backlog item are met
[x] The documentation is updated to cover any new or changed features
[x] Manual tests have passed
[x] Relevant issues are linked to this PR

/azp run

/azp run

@ElYusubov please merge the latest changes in main into your branch and resolve the conflicts. Thank you for the PR!


ENH Don't throw warnings for deprecated config we still use

Parent issues

https://github.com/silverstripe/silverstripe-config/issues/79

This was overkill. Just wrap the config call in Deprecation::withNoReplacement()


mutualism

Finds this term
GO:0085030 | symbiotic process benefiting host
defined
GO:0085030    JSON
Definition (GO:0085030 GONUTS page)
A process carried out by symbiont gene products that enables a symbiotic interaction with a host organism, that is beneficial to the host organism.
related 'mutualism'
So, there  isn't  a term for mutalism (both the pathogen and host benefit?)
This is probably because if you are annotating a pathogen gene it probably didn't evolve to benefit the host. Just wanted to check this is the reason.
@CuzickA

Oh, but that would be the other way around...
So the question is now, should this term refer to the symbiont and the host?
@mgiglio99

Mutualism was merged into symbiosis, see #14807
The reason was that:

The following terms are not processes; they correspond to modes of interactions between organisms, but not to processes.

Is that OK ?
Thanks, Pascale

That makes sense. So this particular term should be "not for direct  annotation" because to use it you would know the specific process that benefitted the host?
The only annotation is to
http://europepmc.org/article/MED/24463512
which makes sense. This seems to be some metabolism that benefits the host.
@CuzickA  maybe we should not make a process annotation because we don't know if/how the host benefits from the interaction with this locus ? (other than not being killed, I guess !)

I'm reopening this because we are annotating a gene that allows a mutualistic lifestyle to occur by manipulation of the host immune system. If the gene product is manipulated the pathogen becomes pathogenic.
The particular gene product isn't directly involved in one of the benefits provided by the pathogen to the host (i.e nutrient acquisition/availability), but is required for a mutualistic lifestyle.
We now see why we should not annotate this to the "symbiotic process benefiting the host", we should make it clearer how this term should be used. Maybe it can be made "not for direct annotation" so that only valid examples would be annotated by requesting appropriate descendants?
There are currently 10 annotations from one paper so these would be easy to fix right now.
@CuzickA

@ValWood do you still want that term? we would need a different way to capture that

No it's out of scope.


Modify Seeds

FIX EVERY SEED.

[ ] Buildings
[ ] Building types
[ ] Questions
[ ] Options
[ ] Answers
[ ] Building operators
[ ] Asset Manager
[ ] RMI user

Closed in #132.


Revert "Move crio default sock to /var/run/crio/crio.sock"

After discussing with @derekwaynecarr we agreed that we shouldn't require any changes to kube for our 1.8. So reverting this for now.
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

/test ami

for reference https://github.com/kubernetes-incubator/cri-o/pull/1030#issuecomment-337758106
lets queue the socket change for branch that targets kube 1.9  (we need that branch asap).

fyi @sjenning
if we want to have origin 1.7 branch use a new location, we can pick the cri-o changes in cAdvisor and kube back to origin in the interim, but yeah, doing this type of change now just failed a sniff test for me.

/test ami

Looks like the kubetest is failing?

Looks like we have ended up with some bad ami.

/test ami

LGTM


Support custom stdout and stderr

I am using wasm-vips as a dependency for a CLI tool. Currently, if vips encounters a warning, it will output it directly to the console. This is pretty annoying because the CLI tool already is outputting information to the console, so now there are random fragments of vips warnings cluttered in with the rest of the information.
I would like to be able to receive the warnings in a function, where I can write my own logic for when and where the output should be logged.
If that is not possible, the next best thing would be to tell wasm-vips to never output anything.
Maybe this is already supported? But I can't seem to figure out how it works. I have already tried this, as an attempt to make it stop outputting to the CLI, but it did not work:
import newVips from "wasm-vips";
const vips = await newVips({
	print: (stdout) => {return ""},
	printErr: (stderr) => {return ""},
	preRun: module => {
		module.print = (stdout) => {return ""};
		module.printErr = (stderr) => {return ""};
	},
});

Hi @atjn,
It looks like a bug in Emscripten's NODERAWFS filesystem backend, on the web this works properly:
import Vips from 'wasm-vips';

const log = (type, text) => console.log(`${type}: ${text}`);
const vips = await Vips({
  print: (text) => log('stdout', text),
  printErr: (text) => log('stderr', text),
  preRun: (module) => {
    // Handy for debugging
    // module.ENV.VIPS_INFO = '1';
    // module.ENV.VIPS_LEAK = '1';

    // Hide warning messages
    module.ENV.VIPS_WARNING = '0';
  }
});

For now, I can recommend setting the VIPS_WARNING environment variable, as shown in the example above.
Upstream issue: https://github.com/emscripten-core/emscripten/issues/17688

Thank you so much for the absolutely excellent debug work here!

I just cherry-picked that PR in the https://github.com/emscripten-core/emscripten/compare/3.1.29...kleisauke:wasm-vips-3.1.29 changeset with commit https://github.com/kleisauke/emscripten/commit/cf6cdde22382590929698e570f26afce0d0c0a1f.
This will be in v0.0.5.

v0.0.5 now available.


Varadic arguments after optional argument failing

I've been trying to get a varadic argument working, particularly after my options.
Usage:
  sync53 import [options]
  sync53 import [options] [<zones>...]

Options:
  -b <both>, --both <both>

So I could support calls like
sync53 -b fooga asdf asdf
The browser tester for the reference version confirms that this is valid & returns what I'd expect.
{
  "--both": "fooga",
  "<zones>": [
    "asdf",
    "asdf"
  ],
  "import": true
}

docopt.coffee is doing something else, and it looks like a bug. Here's what I get trying it with a variety of inputs. The script simply console.log()s the state if it succeeded.
$>node . import asdf asdf
Usage:  sync53 import [options]
        sync53 import [options] [<zones>...]

$>node . import -b fooga asdf asdf
Usage:  sync53 import [options]
        sync53 import [options] [<zones>...]

&>node . import -b fooga
IMPORT { '--both': 'fooga', import: true, '<zones>': [] }

I've tried to dig deeper w/o success, sorry. Any ideas?

:skull:


refactor: routing & breadcrumb of account orders (history/detail)

PR Type

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the New Behavior?
Breadcrumb for order details display the order id.
Refactoring acount & orders routes.
(Issue Number: ISREST-461)
Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

if the order list is long (longer than the screen) the loading animation isn't displayed. This isn't most probably a new issue, pls fix it nevertheless.


shoal server can't be installed

Going through the install instructions in the shoal-server readme, I am not able to install a new shoal server.

yum/pip: not all requirements can be satisfied although much newer versions of the requested packages are already installed
git clone: works until python setup.py install, after that no files are in /usr/share/shoal-server

The install instructions need to get fixed and tested.

I am able to install on centos6 if I do yum --enablerepo=shoal-dev.
On centos6 without that extra repo, it attempts to install shoal-server-0.6.1-1 and runs into missing dependencies of pika>=0.9.13, web.py>=0.3, and pygeoip>=0.2.5.
On centos7, there's no shoal-server available in either the standard shoal repo or shoal-dev.
Can these yum repositories please be brought up to date?

Oh, I take it back, the shoal-dev install on centos6 also had a problem after I let the install complete:
warning: rpmts_HdrFromFdno: Header V4 DSA/SHA1 Signature, key ID b4833a14: NOKEY

Public key for web.py-0.37-1.noarch.rpm is not installed

Likewise for pygeoip-0.3.0-1.noarch.rpm.  If I install those two by hand with rpm, ignoring signature, I get conflicts for the pika package with python-pika-0.9.5-2.el6.noarch.  That was only installed because of a requirement for shoal-agent, and I don't need that on the same machine as shoal-server, so I deleted it.  Then I could yum install --enablerepo=shoal-dev shoal-server.  However there was a warning during install:
No handlers could be found for logger "shoal_server"
warning: %post(shoal-server-0.7.5-1.el6.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package shoal-server-0.7.5-1.el6.noarch

@DrDaveD We look into it. If you want to use shoal for grid based squids serving /cvmfs, may I suggest that you use, in the meantime or in addition to an own server, the central shoal server we set up?  That way WLCG grid workers can have a central point to get access to a nearby squid.  If you want to give it a try, the server is at http://shoal.heprc.uvic.ca/ and you will see your squids in the list when they registered successful.

My goal is to integrate a shoal server into the WLCG WPAD service so that's not going to be good enough for me.  I'd like http://wlcg-wpad.cern.ch/wpad.dat (and http://wlcg-wpad.fnal.gov/wpad.dat) to return either the pre-configured squids that are now returned or dynamically registered squids, whichever is applicable.
I'm also thinking of including shoal-client in the frontier-squid package, or at least distributing them together, and making it trivial for someone configure the squid to register itself in the WLCG shoal server.

I see. I think we should try to have one WLCG shoal server where all squids register, no matter which experiment they support (most likely more than 1 anyway).
Since CERN, DESY and others already register with our shoal server it would be good to keep it.
For your use case,  would it work to have us add an option to  give an IP used to determine the nearest squids, e.g. http://shoal.heprc.uvic.ca/wpad.dat?$IP
to return the squids in the wpad format (which it already does), but based on $IP and not on the IP that the query came from? Then clients can connect to your server, which collects the information from the static wpad system and from the shoal server, and sends back an appropriate combined list.
In any case, we are looking into the install issues you mentioned and let you know when it is fixed.
It would be good to distributed the shoal-agent and the frontier-squid together or have the shoal-agent included in the frontier-squid package.

I don't think that's an architecture scalable to the levels I have in mind.  The existing wlcg-wpad service has 4 physical machines, 2 at CERN and 2 at FNAL (the machines also have other purposes as backup squid proxies when site squids fail), and they all have a copy of the squid information locally so they can immediately respond to all requests.  I more have in mind a dump of the entire internal database of registered squids, downloaded every 5 minutes or so.  Could you add an option for that?
I agree it would be good to have a single registration point for the WLCG.  I assumed I would have the central registration point be at CERN, probably called wlcg-shoal.cern.ch, which I would make to be a DNS alias for wlcg-squid-monitor.cern.ch. That is currently one of a pair of machines that back each other up, and the backup can automatically take over for the primary if the primary goes down.  It is already the source of data for the 4 wlcg-wpad machines.  Then I would ask all the existing shoal-agents on the WLCG to switch to registering there.
Having said that, it might be fine to change that plan to have everybody register at shoal.heprc.uvic.ca, as long as wlcg-squid-monitor.cern.ch can periodically get a dump of the list of registered squids and their associated metadata.  I prefer a json format, and we could negotiate the specific format.

Well, the dump of everything that is available in shoal is already there:
http://shoal.heprc.uvic.ca/all gives you a list of all registered squids and their information. Is that what you need (except for the format maybe)?
But I'm not sure I understand what you want to do with the information as a full dump? Do you want to ingest this information into the wpad system then, or how does a client that queries the system would then get a list that is ordered by distance? Or are you planning  to do your own GeoIP matching on top of wpad and shoal using the combined information of both?

That should do.  It has more than I need, but it includes what I need.  You don't mind if I start reading that every 5 minutes?  If you added a Last-Modified header I could have it use that time for the file and request with If-Modified-Since to avoid redownloads if nothing has changed.
Yes I plan to have wlcg-wpad do its own GeoIP matching, as it already does.  If it doesn't find a match in the static WLCG data (which basically comes from the CMS & ATLAS site frontier configurations) I intend to have it also look in the shoal data.  It currently does not use longitude & latitude; it uses the GeoIP organization from the GeoIP2-ISP database, a purchased maxmind database, and matches by squid & client ips by organization.

Should be no problem to query it every 5 minutes.


streamalert - local testing - remove INFO of triggers

to: @ryandeivert
What

Remove the annoying StreamAlert [INFO]: Rule [...] triggered an alert on log type [...] from entity '..' in service '..' output when doing local testing of rules.
This information is already captured in the [trigger=...] output

Result
cloudtrail_put_object_acl
       [Pass]  [trigger=1]                   rule      (s3): Storing an S3 object with an `AuthenticatedUsers` permission will create an alert.
       [Pass]                                alert     (pagerduty): sending alert to 'sample-integration'
       [Pass]                                alert     (aws-s3): sending alert to 'sample-bucket'
       [Pass]                                alert     (slack): sending alert to 'sample-channel'
       [Pass]  [trigger=1]                   rule      (s3): Storing an S3 object with an `AllUsers` permission will create an alert.
       [Pass]                                alert     (pagerduty): sending alert to 'sample-integration'
       [Pass]                                alert     (aws-s3): sending alert to 'sample-bucket'
       [Pass]                                alert     (slack): sending alert to 'sample-channel'
       [Pass]  [trigger=1]                   rule      (s3): Storing an S3 object with an `AllUsers` and `AuthenticatedUsers` permission will create an alert.
       [Pass]                                alert     (pagerduty): sending alert to 'sample-integration'
       [Pass]                                alert     (aws-s3): sending alert to 'sample-bucket'
       [Pass]                                alert     (slack): sending alert to 'sample-channel'
       [Pass]  [trigger=0]                   rule      (s3): Storing an S3 object without an `AllUsers` or `AuthenticatedUsers` permission will not create an alert.

cloudtrail_root_account_usage
       [Pass]  [trigger=1]                   rule      (kinesis): Use of the AWS 'Root' account will create an alert.
       [Pass]                                alert     (pagerduty): sending alert to 'sample-integration'
       [Pass]                                alert     (aws-s3): sending alert to 'sample-bucket'
       [Pass]                                alert     (slack): sending alert to 'sample-channel'
       [Pass]  [trigger=0]                   rule      (kinesis): AWS 'Root' account activity initiated automatically by an AWS service on your behalf will not create an alert.

Testing
python manage.py lambda test --processor all

Coverage remained the same at 95.278% when pulling a9ed568b139fd70265e02a3bf540c8dbc09a3ca0 on mimeframe-streamalert-suppress-rule-trigger-info-for-local-testing into bc6e37156bc8860d930a5f9e94b7fe194e3a4c37 on master.


component tests added

@michielvandergeest Thanks for checking. Rebased on most recent dev branch.
The thing with tests is that we don't have a mechanism of resetting the app state after each test run. I added another method to componentId.js that resets the counter. It's not ideal solution, since usually we don't want to add production code only to be used by tests, however it fixes the issue for now. Let me know if this is fine to you :) or maybe you have other suggestions

@M4tiz yes I agree that it's not so nice to add a method just for the tests. I don't suppose it would work if we export the let counter and reset it manually in the tests itself (instead of a dedicated reset counter method)?


New release

Hi, when you intend to release the new features added recently?
Thank you!

I just bumped the version number to 1.2.0 and pushed it to PyPi.


Socks5ProxyHandler May need repair

Expected behavior
client send username and password, but server authMethod is NO_AUTH; connect success
Actual behavior
can not connected, fail
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)

Netty version
all
JVM version (e.g. java -version)
jdk8
OS version (e.g. uname -a)

Please provide some more details on what exactly is the issue.

client is send username and password,

I am still not getting it... Can you maybe provide a PR with a unit test and change ?

I am still not getting it... Can you maybe provide a PR with a unit test and change ?

This is what I changed


fix: directive TranslocoDirective doesn't work on Universal SSR

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The directive TranslocoDirective does not inject translation in Universal SSR mode.
What is the new behavior?
A little function has been added (from ngx-translate) to update the node text.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Sorry for my commit message...

@pascalmann looking at your pr there are few things that missing:

please add a type to the node
what is node.data could you point me to some documentation that explains it?

@pascalmann have you seen @itayod comments? 🙂

@pascalmann Do you think you will have the time to address @itayod comments?

Fixed in v3.1.1


RESTClient can't work suddenly on my mac

I like RESTClient very much. Today I found it can not work any more.
I click "send", nothing happened.
My OS version is 10.11.4
My firfox version is 46.0.1

Same as #220.


Fix cast string into number

Nice @Kikobeats! What was the underlying bug here (and the effects?), can you provide a way to reproduce it so we can write a bug fix?

Yes, basically, when it try to calculate the new state, because the number is serialized the sum is wrong:
p=0
p=01
p=011
p=0111

expected (and the thing that this issue resolve)
p=0
p=1
p=2
p=3

I think I get it, since the state can be serialized in the URL, when you read it back p is now a string even if it contains a number?

exactly

Are you willing to add a test for this? Otherwise I'll do it.

Better if you do it and I learn for the next time

moved to #1619


zfs-import services do not wait for LUKS devices to be opened (need a cryptsetup.target)

Note, this is all about non-root zpools, for which adding this to the initrd would be inappropriate (especially since the key to open the devices comprising the zpool is stored on the root fs -- and with the initrd being stored in the EFI system partition, it's not safe to put the key there.)
I have populated a /etc/crypttab and created cryptsetup services via
  systemd.generator-packages = [
    pkgs.systemd-cryptsetup-generator
  ];

  environment.etc = {
    "crypttab" = {
      enable = true;
      text = ''
<name> UUID=<uuid> /etc/crypttab-key luks
...
      '';
    };
  };
}

This will unlock the devices fine upon boot, however the zfs-import-w.service created based on my boot.zfs.extraPools = [ "w" ]; runs before it is done and fails.
It seems like to imitate what is done with the zfsonlinux.org packages for Fedora or Ubuntu, for example, the zfs-import-w.service needs to have cryptsetup.target in its "After" specification.  I've tried that, but there is no cryptsetup.target on NixOS -- I believe because of @edolstra's commit b06cb357, which drops the cryptsetup dependancy in the systemd build.
I have verified that the cyclic dependency still exists:
while evaluating ‘check’ at /etc/nixos/nixpkgs/lib/types.nix:170:15, called from /etc/nixos/nixpkgs/lib/modules.nix:340:10:
while evaluating the attribute ‘buildInputs’ of the derivation ‘systemd-234’ at /etc/nixos/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘buildInputs’ of the derivation ‘cryptsetup-1.7.5’ at /etc/nixos/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘buildInputs’ of the derivation ‘lvm2-2.02.173’ at /etc/nixos/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
infinite recursion encountered, at undefined position

I'm content to continue trying to figure this out when I have free time and will submit a PR if I do, but I'm interested in any pointers as to solving this or discussion about more practical ways to do this.
Technical details

System:
Nix version: 17.09.git.777443c (Hummingbird)
Nixpkgs version: "17.09.git.777443c726M"
Sandboxing enabled: false
(versions may be a little funny since I have my patch to attempt modifying the After on top of 17.09-small)

@jamagin, do you know if this is still an issue?

@benley Sorry, I don't currently have a nixos install or time to try.

This is a duplicate of https://github.com/NixOS/nixpkgs/issues/75540, which should be fixed by https://github.com/NixOS/nixpkgs/pull/66856 - closing.
@benley feel free to open another issue if you're still experiencing problems after this has trickled into nixos-unstable.

Hmm, on a second thought, adding cryptsetup.target to the zfs services might still be necessary - and isn't done currently.