Are segmentation masks for different parts of each objects available?

Hi, congratulations for your work and thank you for making this dataset publicly available. I'm trying to use this dataset to train a segmentation model and since each object is divided in components i was expecting to find also the segmentation masks of each part. Is it something that i can download in some way? If not, were you able to obtain them in other ways, like starting from the 3d models?
Thank you in advance!

Hello Eduardo, we do have 2D semantic segmentation masks for each part.
Is this what you are looking for?
Or do you mean 3D mesh segments?
Best regards,
Habib
On Wed, Nov 13, 2024 at 6:49 PM edoardoMalaspina @.***>
wrote:

Hi, congratulations for your work and thank you for making this dataset
publicly available. I'm trying to use this dataset to train a segmentation
model and since each object is divided in components i was expecting to
find also the segmentation masks of each part. Is it something that i can
download in some way? If not, were you able to obtain them in other ways,
like starting from the 3d models?
Thank you in advance!
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1Go8oih1g$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AG5EQIODQE2P7ITUNY6OSLT2ANYHVAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKOJVGM4TIMQ__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1E1eVHsMQ$
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

Thanks for the fast reply!
I think that i already found the 3D mesh segments (the various components
inside the .gltf files) but i'm not able to find the 2D semantic
segmentation masks, can you please explain how to get them? Are they
referred to a frontal view of the rendered 3D object?
Thanks again!
Il giorno mer 13 nov 2024 alle ore 16:52 Habib Slim <
@.***> ha scritto:

Hello Eduardo, we do have 2D semantic segmentation masks for each part.
Is this what you are looking for?
Or do you mean 3D mesh segments?
Best regards,
Habib
On Wed, Nov 13, 2024 at 6:49 PM edoardoMalaspina @.***>
wrote:

Hi, congratulations for your work and thank you for making this dataset
publicly available. I'm trying to use this dataset to train a
segmentation
model and since each object is divided in components i was expecting to
find also the segmentation masks of each part. Is it something that i
can
download in some way? If not, were you able to obtain them in other
ways,
like starting from the 3d models?
Thank you in advance!
—
Reply to this email directly, view it on GitHub
<
https://urldefense.com/v3/__https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1Go8oih1g$>,

or unsubscribe
<
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AG5EQIODQE2P7ITUNY6OSLT2ANYHVAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKOJVGM4TIMQ__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1E1eVHsMQ$>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before
printing
this email.
—
Reply to this email directly, view it on GitHub
https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11#issuecomment-2474013437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW4ZEWB6FAGOYHJUILZFV432ANYURAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGAYTGNBTG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Dear Eduardo,
For 2D masks refer to this:
https://3dcompat-dataset.org/doc/loaders-2D.html
Best,
Habib
On Wed, 13 Nov 2024, 19:05 edoardoMalaspina, @.***>
wrote:

Thanks for the fast reply!
I think that i already found the 3D mesh segments (the various components
inside the .gltf files) but i'm not able to find the 2D semantic
segmentation masks, can you please explain how to get them? Are they
referred to a frontal view of the rendered 3D object?
Thanks again!
Il giorno mer 13 nov 2024 alle ore 16:52 Habib Slim <
@.***> ha scritto:

Hello Eduardo, we do have 2D semantic segmentation masks for each part.
Is this what you are looking for?
Or do you mean 3D mesh segments?
Best regards,
Habib
On Wed, Nov 13, 2024 at 6:49 PM edoardoMalaspina @.***>
wrote:

Hi, congratulations for your work and thank you for making this
dataset
publicly available. I'm trying to use this dataset to train a
segmentation
model and since each object is divided in components i was expecting
to
find also the segmentation masks of each part. Is it something that i
can
download in some way? If not, were you able to obtain them in other
ways,
like starting from the 3d models?
Thank you in advance!
—
Reply to this email directly, view it on GitHub
<

https://urldefense.com/v3/__https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1Go8oih1g$>,

or unsubscribe
<

https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AG5EQIODQE2P7ITUNY6OSLT2ANYHVAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKOJVGM4TIMQ__;!!Nmw4Hv0!xQTKcPVQlbj7rHFFbYfin5W23H6Fd5hCxTHILNVPrim-xNAjwveimVnhkIRPpCqGtwR0MfDQfuzae8FUx3ptm1E1eVHsMQ$>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or
have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before
printing
this email.
—
Reply to this email directly, view it on GitHub
<
https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11#issuecomment-2474013437
https://urldefense.com/v3/__https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11*issuecomment-2474013437__;Iw!!Nmw4Hv0!2OF-Ai1vHy_mPjS1zJvTlLPC5wRpRdPz1Q4zPivlo-moxjsJupH1xOo10V9uvN5RrLw0OA3Nqh6tsSYGfOWabcbhty8czw$>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AW4ZEWB6FAGOYHJUILZFV432ANYURAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGAYTGNBTG4
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AW4ZEWB6FAGOYHJUILZFV432ANYURAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGAYTGNBTG4__;!!Nmw4Hv0!2OF-Ai1vHy_mPjS1zJvTlLPC5wRpRdPz1Q4zPivlo-moxjsJupH1xOo10V9uvN5RrLw0OA3Nqh6tsSYGfOWabcbeqyTuEw$>

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/Vision-CAIR/3DCoMPaT-v2/issues/11*issuecomment-2474045898__;Iw!!Nmw4Hv0!2OF-Ai1vHy_mPjS1zJvTlLPC5wRpRdPz1Q4zPivlo-moxjsJupH1xOo10V9uvN5RrLw0OA3Nqh6tsSYGfOWabcbJR8ly_Q$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AG5EQIJMKTADA4XV52SQLYD2AN2DJAVCNFSM6AAAAABRWZ2PJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGA2DKOBZHA__;!!Nmw4Hv0!2OF-Ai1vHy_mPjS1zJvTlLPC5wRpRdPz1Q4zPivlo-moxjsJupH1xOo10V9uvN5RrLw0OA3Nqh6tsSYGfOWabcYjsCMjjw$
.
You are receiving this because you commented.Message ID:
@.***>

--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.


crossplane provider-azure: Bump to 0.36

In #344 I mentioned that this gave an error - hopefully this PR reproduces that.

Yeh it does, see the CI failure.
:thinking-face-rotating:

There's probably an error in the upstream CRD.. :/


API docs

Firezone User story
As a Firezone API consumer, I'd like to be able to understand how the REST API works and quickly integrate it to my existing tools.
Nice to haves:

Publish a public Postman collection
Import an OpenAPI spec

Firezone Developer story

As a Firezone engineer, I'd like to be able to easily maintain the API documentation whenever endpoints or schemas change in backwards-compatible ways.
As a Firezone engineer, I'd like to be able to generate new API version documentation when we publish a new API version

This doesn't need to be overly-complex. We can start with a simple markdown document (or directory structure in the website) and have the API tests generate example json files for each endpoint, then load these into the website docs.

@bmanifold Edited the description to hopefully keep this simple. It still may be a bit too ambitious.

In my opinion, having an openapi spec in the repo would be very useful. It allows you to understand and test the API easily with swagger or to generate API clients in multiple languages (for example in golang to help write a terraform provider :eyes:)

@Intuinewin Valid points! Perhaps there is a way to keep the API docs in this repo and publish to Postman in CI. From there it looks like we can do all kinds of things with it, including exporting an OpenAPI spec.

Merged OpenAPI spec served from app itself to enable live API testing.


Add another game level

The game only has one level. There should be more.

This needs first and foremost a new menu which says "Next Level" and "Quit".
Before I add any new UI elements, I want to read up on the documentation for them. There are many things like anchors and size flags that I don't fully understand yet.
Preparation:

[ ] Read documentation on Godot Control nodes

Execution:

[ ] New Menu
[ ] New Level


Olofk-awslinux

Build config for AWS-linux2

I find away to install clang without build it. We can download the release form github and copy the artefacts to /usr/local/*. Here is how we can do it.

RUN cd /tmp \
    && wget -O clang+llvm-12.0.1-x86_64-linux.tar.xz https://github.com/llvm/llvm-project/releases/download/llvmorg-12.0.1/clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-16.04.tar.xz \
    && tar xvf clang+llvm-12.0.1-x86_64-linux.tar.xz \
    && cd clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-* \
    && cp -rn * /usr/local \
    && cd /tmp && rm -rf clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-*

ok, I will try that. Should we go for clang 12 on el8 and ubuntu also then?

I didn't find lcov installation on dockerfile. Is it included in other package that is being installed?

Good. I will remove it from runtests. I assume it is sufficient to run lcov on some platform not all.

I find away to install clang without build it. We can download the release form github and copy the artefacts to /usr/local/*. Here is how we can do it.

RUN cd /tmp \
    && wget -O clang+llvm-12.0.1-x86_64-linux.tar.xz https://github.com/llvm/llvm-project/releases/download/llvmorg-12.0.1/clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-16.04.tar.xz \
    && tar xvf clang+llvm-12.0.1-x86_64-linux.tar.xz \
    && cd clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-* \
    && cp -rn * /usr/local \
    && cd /tmp && rm -rf clang+llvm-12.0.1-x86_64-linux-gnu-ubuntu-*

ok, I will try that. Should we go for clang 12 on el8 and ubuntu also then?

I don't see any reason to not do it. I think we should try to keep our tools updated


Merge refs/heads/update-dependencies into alpha

Merge refs/heads/update-dependencies into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308311043. Thanks for your contribution!


Added documentation for the dump-mpr command on mx.exe

To be reviewed by @ahmed-negm

@ahmed-negm and @grootjans
This has now been reviewed, but it isn't clear to me that it is ready for me to do a final review.
Let me know if the suggestions are good and I will pick this up.


Upgrade our CI from ROCm4.2.0 to the latest supported release

We use a stable ROCm driver as the basis for our CI tests.  As time moves on, so does ROCm.  The goal here is to upgrade our CI infrastructure to use the most recent ROCm.  It could be ROCm 4.3.0 or something newer.  To go above and beyond, the developer completing this assignment could design it in such a way that makes it easy to point to any ROCm driver.  After all, testing with a stable release is great but having the ability to test with a "still in development" driver on demand would be even better.

Issue #994 will resolve this issue


Version bump 15.0 -> 15.1

We decided to go with 15.1 rather than confuse with the 15.0 version
that's in VS "15" preview. 15.1 is intended to build/ship from GitHub
sources (rather than internal source 'mirror') and not be installed or
put in the GAC.

It was much easier the second time at least! :smile:

LGTM


Rearrange linter settings

What this PR does / why we need it:
A bit better organization of the exception linter rules
NONE

/retest

/retest

/hold cancel


Update cdc-fn-cdc-get-net-changes-capture-instance-transact-sql.md

Adding possible value of __$operation value of 5 for the 'all with merge' option (indicating insert or update)

Thanks @AReasonableMan for submitting this PR.  This article update is in flight. After the updated article is published, GitHub will list you as an article contributor.
Thanks again for this feedback, your suggestions help improve our documentation.


Fix unicode error when printing

Fixes unicode error related to printing output of model instance. Came across this when autogenerated model instance had unicode chars in name comming from FK model repr.
"""
autofixture/management/commands/loadtestdata.py", line 101, in print_instance
self.format_output(instance),
UnicodeEncodeError: 'ascii' codec can't encode character
"""
One letter fix, lucky us we don't charge by KLOC.

:D +1 for your comment. Very nice ;)

It's merged. Thanks for the contribution!

:D tx for the lib, very useful.


Configuration to fetch origin at launch

should be good have a setting (like the autofetch interval) to make a fetch at the startup of the ap

Currently, it can be done by simply modify one line:
diff --git a/src/Models/AutoFetchManager.cs b/src/Models/AutoFetchManager.cs
index 313f5f64..2e1fb78c 100644
--- a/src/Models/AutoFetchManager.cs
+++ b/src/Models/AutoFetchManager.cs
@@ -97,7 +97,7 @@ namespace SourceGit.Models
             {
                 IndexLockFile = Path.Combine(gitDir, "index.lock"),
                 Cmd = new Commands.Fetch(repo, "--all", true, false, null) { RaiseError = false },
-                NextRunTimepoint = DateTime.Now.AddMinutes(Convert.ToDouble(Interval)),
+                NextRunTimepoint = DateTime.Now,
             };

             lock (_lock)

It removes the delay for the first time running background auto-fetching.

But I'm not sure it is the right way since there's not UI/UX notification that shows a background auto-fetching task is running and the progress of that task is also invisible.

When auto-fetch activates regularly in the background with current version, there is no UI/UX notification, as far as I observed.
So, it should not be "bad" to do it at launch time.
If running the autofetch directly at launch time may seem risky or a source of startup slowness. It may be delayed with a couple or a few dozens of seconds?

When auto-fetch activates regularly in the background with current version, there is no UI/UX notification, as far as I observed.

Yes, but it is very important to let users known that there's already a background fetching task running to avoid user doing it manually. For example, I'm a game developer, and after I opened the UnrealEngine repo, it takes a very long time before the first auto-fetching really completed. The key point is that I don't know if it has been completed or if I can do other jobs.

Actually, I never use the Auto Fetch Remote feature...

When auto-fetch activates regularly in the background with current version, there is no UI/UX notification, as far as I observed.

Yes, but it is very important to let users known that there's already a background fetching task running to avoid user doing it manually. For example, I'm a game developer, and after I opened the UnrealEngine repo, it takes a very long time before the first auto-fetching really completed. The key point is that I don't know if it has been completed or if I can do other jobs.

I think the better way is to expose a flag in the preferences

Yes, but it is very important to let users known that there's already a background fetching task running to avoid user doing it manually. For example, I'm a game developer, and after I opened the UnrealEngine repo, it takes a very long time before the first auto-fetching really completed. The key point is that I don't know if it has been completed or if I can do other jobs.

I see, in this use case, auto fetch may be more complex to deal with. If I correctly understand, this use case happens when repositories are very large and very active, like with companies using mono repos (every applications, tools, libraries are stored in the same and unique repository).
For instance, in my case, I work with moderately active repositories, auto-fetch is a more than "nice to have" feature, its a highly appreciated feature.
To come back to the problematic use case, we may imagine that the first auto-fetch would start at launch time, and if the user manually clicks on the fetch button whereas auto-fetch is still going on:

either a popup warning message opens and nothing is done,
or the fetch subpanel is displayed (even in the case of Ctrl + Click) and the OK button remains disabled as long as the background fetch is going on, with a message in the subpanel indicating that there is a fetch in progress.

I do NOT like the Auto Fetch Remote feature...
For large repositories, auto fetching changes from remote after repository is opened will lead to a bad experience, since git will prevent other operations that will modify the index if index.lock file exists. And as I said, in current implementation of auto fetching, we do NOT known if the background fetching task is completed, and also can NOT stop it to do some other emergency jobs.
Unless there is a good UI/UX design, I'll not consider to add this feature.

I've rewrite the auto-fetching feature. Now it will start with 5s after a repository is opened. And a floating panel is opened to notify user there's a background fetching task is running.

I've rewrite the auto-fetching feature. Now it will start with 5s after a repository is opened. And a floating panel is opened to notify user there's a background fetching task is running.

great! but it's been on dev branch?

no, it's already available in 8.32, but the auto-fetch configuration has been moved to repository's settings not the global preference

no, it's already available in 8.32, but the auto-fetch configuration has been moved to repository's settings not the global preference
thanks, but where I can find it? the develop branch is 8.29

perhaps your forked repo is outdated

perhaps your forked repo is outdated

that's my last commit:

New settings are here.


Hassio restart

Thanks for this nice job.
When hassio restart, the water heater take one shower more.
I want to have 2 showers in manual mode, but if hassio restart like update i've got 3 showers on the water heater.
Thanks a lot.

Not sure what might be happening in your case. Home Assistant uses temperatures in water_heater component, which is not the same as showers for some models (it is possible to read set temperature, but setting is possible only by means of showers). I have added code as "automatic" mode, which should have changed amount of showers based on requested temperature (increase amount of showers if temperature is not reached and decrease if it is reached), but i did note have possibility to test it (two guys with different boilers gave me access to their boilers temporary for initial tests during implementation).
Integration automatically switches how amount of showers is being controlled (if within the service in HA amount of showers is set, it should disable "automatic" control amount of showers based on temperature, but changing temperature in service or as part of water_heater enables this "automatic mode").
So please try changing number of showers via service to disable possible use of "automatic" mode, which might be working not so well. Without this "automatic" mode the integration should simply read the data unless number of showers changed manually. There is sensor "temperature_mode" which can be used to view if indeed it is the problem that i suspect.
Note that i have boiler, which does not support this integration at all, so i can't test it. Also i have my hands full with changes at work and i have a lot less free time to spend on this (i make changes in cases it is not too time consuming).

No information to proceed with investigation


Processing parser result - visitor / callback / ?

I'm trying to get into the world of parsing. I already have a rather large grammar file and I'm super happy with csly so far. It does what I expect it to do and the tooling (or the lack of as it's all in C#) is wonderful.
One goal is to convert a DSL into various formats: CSV, JSON, XML, XLSX.
I can parse my input, but I'm a bit lost what to do next. What I've tried

I've connected a callback class to my enum file, but it seems like I can only have one callback. I would need a callback for every output format.
I derived the parser class, but this wasn't very nice for two reasons.

I had to copy the attribute and method declaration, resulting in a lot of boilerplate code.
I would like to process everything top-down / left-right.

I tried to process SyntaxTree using some kind of visitor, but that's rather cumbersome. So far, this is what would work best though.

Can someone please point me in the right direction about this? I had a look at all the examples, but none of them seem to process the parser result in a similar way. Thanks!

Okay, I think I got it. My mistake was that I didn't return proper objects in my parser. I had some default(object)'s in my code and therefore not everything was passed all the way up to my root object. Now that I've implemented that properly, I can simply use the Result property of the parser result and process this.

Wonderful project, thanks for all your work!


Test not available without configuration.  (Missing "-C "?) on Windows

I am getting Test not available without configuration.  (Missing "-C <config>"?) error when running the ctest step on a Windows system.
I tried to fork and fix this issue myself, but have spent over an hour with no luck. I can't seem to figure out how to just get the --config Debug args added to the ctest command (which I thought would have been trivial).
See https://github.com/erichschroeter/binpkg/runs/2441099605?check_suite_focus=true

Finally got it to work!


add gemfile to hint that compass is needed

compass isn't mentioned anywhere, at least this will give people a hint

@chrishutchinson LGTM, but is there anything Compass is specifically needed for? Could that just be replaced altogether with node-sass?

that would be my preference too. I've only just started looking at it so haven't got far into the code yet - if when playing with it some more it seems like a quick job, i'll do a PR for that.  In the meantime i think this still makes sense as you don't even need to bump the version number.

@peter-mouland Did you mean to close this? @chrishutchinson is out of country at the moment, but I'm sure he'd be interested in merging once back.

nope, i merged it into my fork - didn't realise it would get closed here too. restored.


#27 - ConfigFile for RepoGet and RepoList slices

Part of #28
Used ConfigFile in ApiRepoGetSlice and ApiRepoListSlice. Also added corresponding tests

@olenagerasimova could you please review this PR?

@olenagerasimova thanks, added tests


Develop

relax current Visual Studio version dependency (use version independent Microsoft.VisualStudio.TestPlatform.ObjectModel, Microsoft.VisualStudio.VCProjectEngine assemblies). Calculate Visual Studio root path rely on $(VisualStudioVersion) MSBuild property;
fix NCalc.dll path;
fix multiline BOOST_AUTO_TEST_CASE, BOOST_FIXTURE_TEST_CASE, BOOST_AUTO_TEST_SUITE, BOOST_FIXTURE_TEST_SUITE macros support.
fix support new style test macros with depends_on() decorator producing extended xml log output (There are additional XML elements on the document root level  in the xml log output introduced in BOOST.Test 1.59. It makes invalid xml document structure).

@sergegers unit tests are failing. You can have a look here https://ci.appveyor.com/project/guwirth/vs-boost-unit-test-adapter/build/<IP_ADDRESS>/job/cjaj85do0ey7xadr/tests.

@sergegers Thank you very much for your contribution! Your ScrollLines approach is very good. :+1:.
Regarding test failures, some tests are failing regarding changes in the expected DLL versions. We require exact version DLLs in order to be backwards compatible with environments which do not have Visual Studio 2015 available. We are targeting v11 of the ObjectModel DLL to support Visual Studio 2012 and above. We are targeting specific versions of VCEngine since we experienced crashes when using VS2012 and loading a VS2015 or VS2013 VCEngine DLL.
I know it is not convenient to have a development environment with all 3 installations. I recommend that such changes are kept local only. We do understand your reason behind this; we do it as well (just not as elegantly as you did). If you think this is not documented well enough, please raise your concern and we will update accordingly.
The other failing tests might be related to some changes in XML parsing. I have not gone through the change in depth but I suspect it might be related.
Once again, thank you very much for your interest in the project and for your contribution.

@guwirth @netspiri thanks for response. So, what is my further actions is? Rollback msbuild script VS version commit, run tests and pull a new request?
Serge.

Hello @sergegers, think you have to

undo this

relax current Visual Studio version dependency (use version independent Microsoft.VisualStudio.TestPlatform.ObjectModel, Microsoft.VisualStudio.VCProjectEngine assemblies). Calculate Visual Studio root path rely on $(VisualStudioVersion) MSBuild property;

ensure that build and unit tests are green
squash and rebase your PR

Regards,


Migrate 4 AppCenter tasks

Task name:
"AppCenterDistributeV1", "AppCenterDistributeV2","AppCenterDistributeV3","AppCenterTestV1"
Description: Migrate 4 AppCenter tasks and using Node20_229_7
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

Tagging task owners @imenkov  @lucen-ms  @DergachevE  @vsebesta


Unable to save reworked Annotation

Hi, after basic protocol 4 step 4, label editing the save function doesn't work:
could this be an issue regarding the filename to be saved to? like https://itk.org/pipermail/insight-users/2015-May/052068.html mentioned?

root - INFO - name: dorsal pallium/isocortex False
root - INFO - updating specified color to
root - INFO - updating specified color to None
root - ERROR - Traceback (most recent call last):
root - ERROR -   File "/home/nrd/anaconda3/envs/mag/lib/python3.6/site-packages/matplotlib/cbook/__init__.py", line 196, in process
    func(*args, **kwargs)
root - ERROR -   File "/home/nrd/anaconda3/envs/mag/lib/python3.6/site-packages/matplotlib/widgets.py", line 211, in _release
    func(event)
root - ERROR -   File "/home/nrd/magellanmapper/magmap/gui/atlas_editor.py", line 377, in save_atlas
    overwrite=True)
root - ERROR -   File "/home/nrd/magellanmapper/magmap/io/sitk_io.py", line 355, in write_registered_image
    sitk.WriteImage(reg_img, reg_img_path, False)
root - ERROR -   File "/home/nrd/anaconda3/envs/mag/lib/python3.6/site-packages/SimpleITK/SimpleITK.py", line 8215, in WriteImage
    return _SimpleITK.WriteImage(*args)
root - ERROR - RuntimeError: Exception thrown in SimpleITK WriteImage: /mnt/e/src/SimpleElastix/Code/IO/src/sitkImageFileWriter.cxx:175:
sitk::ERROR: Unable to determine ImageIO writer for "/home/nrd/magellanmapper/examples/ADMBA-E18pt5/annotation."
root - INFO - name: dorsal pallium/isocortex False

Thanks for another find, @SaibotMagd ! I tracked this down to an error because the filename extension gets stripped when loading the labels image through the GUI, making SimpleITK unable to figure out the file format to save. Loading the image through the command-line bypasses this stripping, so the error doesn't appear there.
I pushed another fix in PR #13 . The filename extensions are now saved with these registered image names in the GUI, which actually simplifies finding these images and fixes the save issue. It's available on Git by:
git fetch; git checkout fix_save_atlas_loaded_from_gui
Thanks again and let me know how it works for you or if you encounter any other issues!

I tried this but it doesn't work. Because the other fix worked (and I manually checked if the changes are written locally), it seems not to a working solution. Error message is identical.
I will try to replicate the error using nifti files because maybe the issue is because of the dual file situation combining the MHD and RAW file.

Thanks for letting me know. Just to double-check, did you run git fetch; git checkout fix_save_atlas_loaded_from_gui? This fix is actually on a different branch from the other issue. Does the "Labels" dropdown box show file extensions, like "annotion.mhd"? They should be present now to tell SimpleITK the file format to write.

And the command-line output then shows, wrote <path>/ADMBA-E18pt5/annotation.mhd with current registered image. Let me know if this doesn't work for you though. Are you loading the images through the GUI?

Thanks for letting me know. Just to double-check, did you run git fetch; git checkout fix_save_atlas_loaded_from_gui? This fix is actually on a different branch from the other issue. Does the "Labels" dropdown box show file extensions, like "annotion.mhd"? They should be present now to tell SimpleITK the file format to write.

Very important that you checked this source of an error on my side. I'm not really familiar with git so I missed that you fixed both issues in 2 separate branches. So after switching the branch it works! Yes it shows the file-ending in the gui right now.
You maybe think about an undo function in the future. I'm fine with overwriting the file but this could lead to some usability issues.

Great, glad we got it all sorted out! Thanks again for pointing out these issues and helping me to fix them.
The undo feature is a great idea...I'll add an issue to keep a reminder of it.


Support a bandwidth limit on uploads

We're not going to implement this right now actually, after some discussion we want to try an alternative internal change that doesn't require this.

Issue may be reopened later, if it turns out to be useful!


Update deprecated build configuration filename

The build configuration filename was changed from Brocfile.js to ember-cli-build.js in ember-cli 1.13.0
See https://github.com/ember-cli/ember-cli/blob/275cc36807698968050f80ef8c64e8bd6726ba72/CHANGELOG.md#1130

Thanks @MarkMT


New version: JetBrains.PHPStorm.EarlyAccess version 231.4840.331

Result: Installation Failed

Manifest
Add/Remove Programs

Name
PhpStorm (EAP)

Version
231.4840.331

Publisher
JetBrains s.r.o.

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5534
Microsoft Reviewers: Open in CodeFlow

/azp run


Add support for X-Hub-Signature headers in webhooks

Send a new header X-Hub-Signature using the sha1 format
Renames existing Signature to Signature256 since we need to generate to HMACs from the same secret
Fix #7788

I would like @lafriks 's change. So that your migrations will be simpler to only use Sync2.

Please resolve the conflicts.


Update rtl8367c_base.h

I will change the library to the original library with classes.
Because of that, I will not approve the merge.
Next month, the update will be live.


install_fusion.sh script fails with error in Ubuntu

In RC2 release package, the install_fusion.sh fails creating gevars.sh file on Ubuntu. (EL 6/7 use RPMs instead of this script).
Reproduction Steps

When creating fusion master or slave, the /etc/init.d/gefusion start fails because the /etc/init.d/gevars.sh is missing.  This SHOULD have been created by the ./install_fusion.sh script but is not.
I ran "sudo ./install_fusion.sh -hnmf"

** Note this box was fresh, having never had any version of OpenGee installed prior.
** Also note the server box, on which I ran "sudo ./install_server.sh" DID install the gevars.sh

Fixed with pr #1119


Deprecated httpx.AsyncClient call kwarg

In this commit https://github.com/encode/httpx/commit/397aad98fdc8b7580a5fc3e88f1578b4302c6382, it is clearly stated that usage of data kwarg in BitcoinRPC.acall will be deprecated.
Fix to content kwarg instead.

Resolved in https://github.com/bibajz/bitcoin-python-async-rpc/commit/50546cdb5302ac7dfe73f730769950aa0b8a48a4
Also, mypy did not detect this in the [testenv:mypy] section of tox. Reason for that was mypy had no idea about the httpx package because it was not installed in the [testenv:mypy] environment, so https://github.com/bibajz/bitcoin-python-async-rpc/commit/85af3731debbf78b5e89ec3cebb8c00ac8ea8f34 also fixes that.


Context files not cleaned by orphan detection

Orphan detection currently doesn't clean up optional context files like the raw snapshot or the actual result file

Fixed in 1.9.0


dead doc link in web ui footer

Describe the bug
A clear and concise description of what the bug is.
in the footer of each page is a link that says 0.7.0 is here! Click here to read more.
that is a dead link
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots / Logs
If applicable, add screenshots and log traces to help debug your problem with any sensitive data removed.

Platform (please complete the following information):

Firezone Version [e.g. 0.7.12]
OS: [e.g. Linux]
Distro: [e.g. Ubuntu 18.04]
Kernel version: [e.g. 5.10.11]
Deployment method: [e.g. Docker / Omnibus / Source]

Additional context
Add any other context about the problem here.

Will be fixed in 0.7.27


Added support for Amazon Linux 2

What
Added support for using this library on a machine with Amazon Linux 2.  This is a common OS for EC2 machines in AWS.  MongoDB supports this OS so it just means choosing the correct OS name when downloading the Mongo binary.  Tests have been expanded to cover this OS.
How to review
To test the changes, a machine running Amazon Linux 2 is required, for instance using an AWS EC2.  I've tested this and confirm it works.
Who can review
Anyone

Hi @rafahop, first thanks for this great and very useful tool.  Is this change (PR) something you'd be willing to accept into this project?  I'm happy to make changes if its not quite right.
When we found this library/tool it was perfect in allowing us to perform our MongoDB integration tests with a local instance. We've moved to using AWS EC2s (with AL2) so cannot use this library without the minor changes I've raised, it would be really good to be able to continue to use it.


Add contract to generic coercion

In face of PR #67 I'm proposing a change on coercion/generic.js to turn this module an implementation of a common contract based on other coercion/* files.

Hey,
needsCoercion: () => false  on the attribute descriptor no longer works after this PR.

Hello, @loweoj, can you elaborate about it? We never had a needsCoercion option in the attribute descriptor https://structure.js.org/schema-concept/shorthand-and-complete-type-descriptor, right now we have no way to avoid coercion.

I'm being a tool. I added this in my fork a long time ago, and I completely forgot about it. I don't think I used it either, it was a quick hacky way to get around coercion at some point, but I can remove this as it's rubbish.
Apologies for bothering you!

There's no problem, @loweoj! We plan to add something like this in the future.


Upload not working in 0.14.0

Hey,
when I press the ''Upload" Button nothing happens. Tested on our own sandbox and in your demo server.
My JavaScript console says:
Error: Nothing handled the action 'nothing'. If you did handle the action, this error can be caused by returning true from an action handler in a controller, causing the action to bubble.
I'm using Firefox 41.0 on Ubuntu 14.04 AMD64.
Also tested Google Chrome Version 46.0.2490.80 (64-bit)
Thanks!
Nils Jürgens

Sorry for that oversight! I've submitted v0.14.1, it'll hopefully be up in the next few days.

Thanks for the quick update! Looking forward to more testing :-)

v0.14.1 has been released, can you check to see if it's working for you now?

The upload button works, thanks!


Data ID in react-table to prevent full re-rendering

What version of React-Table are you using?
Your bug may already be fixed in the latest release. Run yarn upgrade react-table!
6.5.3
What bug are you experiencing, or what feature are you proposing?
This is a feature proposal to conditionally render rows only if their ID have changed (thus introducing the concept of a row level ID)
The scenario we are trying address is the following:

the data prop is derived from an external state (say managed by redux and wired in through a HOC)
one of the Column allows the user to edit a cell in-place, and on input submission dispatches an action that updates the redux store
when the redux store is updated, the react-table instance will receive a new data prop and the entire table re-renders as expected

This introduces some performance issues:

the entire table is re-rendered even though a single cell in a single row was updated

If for each element in data, we provided an accessor for a row key could we use that as a hint to bypass calling render on that row?
In other words, when a row key is provided - cell level accessor(s) are no longer being invoked. It is no longer react-table's responsibility to detect cell level changes and force re-renders. It is now the custom Cell's responsibility to re-render itself
In this scenario - with row keys enabled, react-table is only responsible for laying out rows based on key ... i.e. to the extent that rows (identified by their keys) are re-arranged, inserted or removed from data
You can imagine this feature being very helpful for data intensive projects where cell values are a complex function of both the row key, column ID + the entire App's state (i.e. redux + mobx store)
Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.
Then paste a link to your newly forked codesandbox here...
What are the steps to reproduce the issue?

list the steps
to reproduce
the issue

I like this idea. Let's chat about it more in slack! DM me.

We are deciding between different table libraries for react+redux app and one of the major drawbacks of react table is not being able to control re-rendering of just individual rows. For example, when a single row is added or updated it will be a performance issue to re-render the entire table when you have thousands of rows. We should be able to just add the row dynamically without the need to render the entire table again.

@shaun-k9 Despite the feature request being considered, react-table is actually not designed for rendering thousands of rows. All of the design statements and the code itself is based around a paged table (not around rendering all of the data).
Obviously, though, any PR to implement it would be seriously considered.

I am only rendering 50 rows, but each row contains an image from AWS. This is a dashboard, so when new activity occurs it adds a row at the top, which causes the entire table to rerender, and every image is again retrieved from AWS. It seems the key of each row is based off the index rather than a unique ID that I would like to pass in. Is there a way to pass a unique key to the row? or is there a solution to my problem? Thanks!

In v7, you are able to render rows with any key prop that you choose (this will override the automatic internal key provided in row.getRowProps()

Awesome! I am currently using the latest version 6. Will 7 be backward compatible, as I see it is hook based? If so, I will install the alpha now. Currently, the table is a wrapper around our companies old tables as well as a custom stand alone version. It will take some time to convert to a new format if that is what it requires, but I can probably do that if need be. On a side note, I love how customizable everything is, and you have done a fantastic job on React Table!

v7 won't be backwards compatible. It's very very different actually, since it's 100% headless now. Basically you the dev are now in charge of actually building and rendering all of your table's markup. This usually is as simple as starting with one of the v7 examples that fits your needs and going from there. v7 is still alpha, but it will be beta probably in the next week or two, so it's becoming very stable. Let me know if you have any questions, but i would start by just reading the documentation (README).

Appreciate the quick responses, and I will read the README and take it from there. Thanks!


relay.get_events_of ignores timeout parameter

Describe the bug
relay.get_events_of ignores timeout parameter and reverts to 20s default.
running version 0.29.2
introduced after v0.27
To Reproduce

clone ngit (see https://gitworkshop.dev/repo/ngit).
run cargo run list on the master branch
one of the relays will probably timeout as 2 of them are unreliable. countdown begins after 5 seconds. after 10 seconds it should time out. it actually times out after 20 seconds.

times out correctly in ngit v1.1.1 which uses rust-nostr v0.27.
Thanks once again for maintaining this library.

Released nostr-relay-pool v0.29.4

Thanks


Could I get model weights?

Thank you for your effort.
I wanna use this model, could I get this model weights?
Thanks.

same problem here，waiting for the open-source of model weights

same problem here，waiting for the open-source of model weights


[Discussion] Android 5.0 (lollipop) Support

Danke, dass ihr den Source Code öffentlich zugänglich gemacht habt.
Aber trotzdem habe ich ein problem...

Mit freundlichen Grüßen,
Felix Schmitt

Internal Tracking ID: EXPOSUREAPP-6360

@felischmi2003
es gibt leider technische Probleme mit Android 5.0 (API 21) - siehe https://github.com/corona-warn-app/cwa-app-android/issues/649 und https://github.com/corona-warn-app/cwa-app-android/issues/1446#issuecomment-716675650
Manifest merger failed : uses-sdk:minSdkVersion 21 cannot be smaller than version 23 declared in library [androidx.security:security-crypto:1.0.0-rc03]
Offiziell wird die Corona-Warn-App erst ab Android 6.0 (API 23) unterstützt - siehe https://www.coronawarn.app/de/faq/#minimum_requirements.

@MikeMcC399
Oh, Ok Danke für die Info

@MikeMcC399 There is a more recent version of this androidx.security:security-crypto available that supports API version 21. Support was added in 1.1.0-alpha1.
You could use it like I did in this commit to the repo of our fork: https://codeberg.org/corona-contact-tracing-germany/cwa-android/commit/f420799562f2e203cfaa941914d815700c2e2c13
With that obstacle out of the way, it would only be a few minor issues that would need to be fixed for Android 5 support as far as the CWA client is concerned. I'm currently also planning to tackle the ones I haven't had time for yet in my fork.

@fynngodau

There is a more recent version of this androidx.security:security-crypto available that supports API version 21. Support was added in 1.1.0-alpha1.

I see there is some more information on https://developer.android.com/jetpack/androidx/releases/security.
This library caused major problems in the past (see https://github.com/corona-warn-app/cwa-app-android/issues/642#issuecomment-697603175 from this hot topic) so I would guess that any upgrade in the CWA app by the developers would be done with extreme caution, in addition to the fact that it would mean moving from a release candidate to an alpha build of the library. I don't see any "Current Stable Release" mentioned either.
You have of course more flexibility in your own environment where you have forked the app.

At this point you might as well unlock your device and install a more recent Android version via a custom ROM instead of forking the app if implementing a new library version is so risky.

Another fact that should be taken into account: the vast majority of devices running Android 5.0 do not support the necessary Bluetooth 4.0 functions.

Another fact that should be taken into account: the vast majority of devices running Android 5.0 do not support the necessary Bluetooth 4.0 functions.

I wouldn't be so sure about that. I even think it is the other way round: most Android 5.0 devices support BLE including acting as a beacon.

I noticed that a new release candidate security-crypto-1.0.0-rc04 was released 2 days ago on Jan 13, 2021
Bug Fixes
Upgraded Tink to 1.5.0 for increased stability.
Interestingly it does not throw an error when built with minSdkVersion 21 unlike 1.0.0-rc03 (see https://github.com/corona-warn-app/cwa-app-android/issues/1799#issuecomment-738137588), so this should at least remove this road-block for supporting Android 5.0 (API21).
Perhaps security-crypto-1.0.0-rc04 could be considered for a future branch (so long as there is no stable release available)?

I noticed that a new release candidate security-crypto-1.0.0-rc04 was released 2 days ago on Jan 13, 2021
Bug Fixes
Upgraded Tink to 1.5.0 for increased stability.
Interestingly it does not throw an error when built with minSdkVersion 21 unlike 1.0.0-rc03 (see https://github.com/corona-warn-app/cwa-app-android/issues/1799#issuecomment-738137588), so this should at least remove this road-block for supporting Android 5.0 (API21).
Perhaps security-crypto-1.0.0-rc04 could be considered for a future branch (so long as there is no stable release available)?

@MikeMcC399 I'm not sure why you are not seeing the build failure anymore, but version 1.0.0-rc4 also requires minSdkVersion 23, as becomes evident from the source code (at the latest commit in RC 4): https://android.googlesource.com/platform/frameworks/support/+/15da9761b41f813f22ba89ee571c696ef912bb36/security/crypto/build.gradle#43
Therefore, the build must still not work (if it does build, one must expect runtime crashes on Android 5).
So far, we have been using the alpha releases for version 1.1.0 since the first of our releases that supports Lollipop over at CCTG as I described above, and we haven't encountered any issues with this library, but I'm also guessing that our userbase for Android 5 specifically is rather small.
Another development on this issue is that #2026 has been merged, increasing the codebase's compatibility with Android Lollipop.

@MikeMcC399 I'm not sure why you are not seeing the build failure anymore, but version 1.0.0-rc4 also requires minSdkVersion 23, as becomes evident from the source code (at the latest commit in RC 4): https://android.googlesource.com/platform/frameworks/support/+/15da9761b41f813f22ba89ee571c696ef912bb36/security/crypto/build.gradle#43
Therefore, the build must still not work (if it does build, one must expect runtime crashes on Android 5).
So far, we have been using the alpha releases for version 1.1.0 since the first of our releases that supports Lollipop over at CCTG as I described above, and we haven't encountered any issues with this library, but I'm also guessing that our userbase for Android 5 specifically is rather small.
Another development on this issue is that #2026 has been merged, increasing the codebase's compatibility with Android Lollipop.

@fynngodau
Thank you for setting the record straight. I guess it must have been a "pilot error" in Android Studio on my part, coupled with "wishful thinking". 🙄
I rechecked and saw
Manifest merger failed : uses-sdk:minSdkVersion 21 cannot be smaller than version 23 declared in library [androidx.security:security-crypto:1.0.0-rc04]
which completely confirms what you wrote. Sorry for my misleading post! It's also clear if you read https://developer.android.com/jetpack/androidx/releases/security carefully enough.
It is good to hear that you are making good ground with Android Lollipop anyway!

@fynngodau
Thank you for setting the record straight. I guess it must have been a "pilot error" in Android Studio on my part, coupled with "wishful thinking". 🙄
I rechecked and saw
Manifest merger failed : uses-sdk:minSdkVersion 21 cannot be smaller than version 23 declared in library [androidx.security:security-crypto:1.0.0-rc04]
which completely confirms what you wrote. Sorry for my misleading post! It's also clear if you read https://developer.android.com/jetpack/androidx/releases/security carefully enough.
It is good to hear that you are making good ground with Android Lollipop anyway!

@fynngodau
How is the experience of CCTG with Android 5.0 (Lollipop) progressing?
Also I wonder how many additional users might download CWA if it was also available on Android 5.x.
Maybe it's not comparable, but the numbers of Apple iOS downloads shown on https://www.coronawarn.app/en/blog/ have changed about the same as Android numbers since CWA 1.12 was made available on Feb 10, 2021 covering iPhone 5s, 6, and 6 Plus. Android and iOS downloads have each increased about 0.2 Million during February. The last totals were Android 14.2 Mio, iOS 11.6 Mio, total 25.8 Mio downloads.

@MikeMcC399 From what I understood, Android 5 is incompatible due to a cryptographic library. Only way would be to update Android 5, which would have to be pushed by the device manufacturers. Highly unlikely.

@MikeMcC399 From our side, there hasn’t been a new noteworthy development, so CCTG on Lollipop has been working and there haven’t been any specific problems. However I also didn’t work on the various purely visual issues that are caused by the app using some incompatible attributes in their XML files, in order not to increase maintanance overhead for us due to increased difference to upstream’s codebase.
@treysis This library was already discussed here, specifically in https://github.com/corona-warn-app/cwa-app-android/issues/1799#issuecomment-738775760.
A new development on this topic is that CWA is considering to stop using the encrypted shared preferences library due to continued problems with platform bugs: https://github.com/corona-warn-app/cwa-app-android/pull/2468#issuecomment-787045765
I was planning to post here once a final decision would have been made.

Release 1.15.1 is available and moved from encrypted shared preferences as discussed in my previous comment.
There's two possible things to do with the androidx.security.security-crypto library now from my perspective:

Ignore its minSdk, like is already done for the com.google.zxing.client.android library, by adding it to the tools:overrideLibrary list in the manifest. This seems not to cause any crashes related to the library when compiled for Android 5 on Android 5, though surely one of the devs who had worked on the migration from encrypted shared preferences would be able to tell for sure that the incompatible code would not be executed.
Upgrade to the before-mentioned alpha release with support for Android 5, as most users will already have migrated once the next release is released.

As you can see, at this point we are discussing trivial technical details regarding an overall well-manageable task.

Specifically after #2700 was merged, and when the faulty pregenerated PNGs from https://github.com/corona-warn-app/cwa-app-android/pull/2800#issuecomment-817147534 are removed, I think there are no further visual bugs on Android 5 remaining (last checked with latest release).
To workaround a platform bug with splash screens, I added a repeating pattern to the splash screen for Android 5.0 (not sure if the platform bug is fixed on 5.1 actually) which also looks nice :)

Would you like a PR that introduces Lollipop support?

I looked at the European apps listed by Google on https://developers.google.com/android/exposure-notifications/apps and I found that the Polish app says it is compatible with Android 5 https://play.google.com/store/apps/details?id=pl.gov.mc.protegosafe. It's the only one I found (but maybe there are others). It's interesting because it is one of the apps which has joined the European Federation Gateway Service and so it is integrated with CWA's Transnational Exposure Logging.
It would be good to see CWA available for Android 5 (Lollipop) too!

@fynngodau CC @MikeMcC399 @felischmi2003
We will call special attention your latest comment. Many thanks. Best, DS

Corona-Warn-App Open Source Team

#2955 was merged, adding compatibility to Lollipop, including many compat fixes so that it works well with Android 5, to the codebase.
The PR does not, however, reduce minSdkVersion to 21, there's still internal discussion about this.

The PR does not, however, reduce minSdkVersion to 21, there's still internal discussion about this.

I'm quite sure, that it's just a matter of (short) time... I hope...

@heinezen
As @fynngodau said, minSdkVersion is not changed to 21 (for Android 5) and stands as before at 23 (for Android 6):
https://github.com/corona-warn-app/cwa-app-android/blob/595ab630dfad5ac1e29021c084c400054193a498/Corona-Warn-App/build.gradle#L27
Probably the label Fix 2.2 should be removed from this issue because support for Android 5.0 (Lollipop) has not been enabled with the release of 2.2.1.

Are there any unsolved technical issues preventing CWA being released for Android 5.0 (Lollipop)?
Probably there should be an "enhancement" (Request) label attached to this issue, since it has become more of a request than just a simple "question" over the course of time.

Are there any unsolved technical issues preventing CWA being released for Android 5.0 (Lollipop)?

None to my knowledge, except for very minor visual details like missing ripple effects.

Are there any updates? The app is still not available in the Play Store for Android 5.0. I would really like to use it, especially the new Impfnachweis feature. :)

@AlexElvers

Are there any updates? The app is still not available in the Play Store for Android 5.0. I would really like to use it, especially the new Impfnachweis feature. :)

I checked in the Google Play Store for CovPass-App as an alternative for managing vaccination certificates and unfortunately this other app also requires a minimum of Android 6.0 🙁.
In any case it would be good to hear back from the developers what the plans for CWA are in respect to Android 5.0.  I can't see any changes to minSdkVersion 23 in the future branches 2.4.x and 2.5.x so far though.

@AlexElvers An application to store your digital vaccination is not really needed, you can simply take a photo of the QR code and store it in your gallery. This will work just the same. (https://github.com/Digitaler-Impfnachweis/documentation/issues/13)
Otherwise, you are of course much invited to use our CCTG app ;)

Just want to crosspost this issue from the covpass app here: https://github.com/Digitaler-Impfnachweis/covpass-android/issues/15
Since people are asking for at least one app running on API 21 devices for managing their vaccination certificates. In this issue I also explained some possible reasons why using minSDK 21 is a potential risk.

For those who want to have a digital eu certificate on their Android 5 phone, I just found this CWA fork:
https://f-droid.org/en/packages/de.corona.tracing/
Just installed this on my very old very cheap zte phone with android 5.0.2  and successfully scanned my certificate qr code. cheers!

Not planned


Standard and Vanced microg together on huawei devices

Last microg vanced version cannot be installed together this standard microg, but huawei users like me without google services need both mircog, standard and vanced. Ho w fix this?

Hey, same here, just got p40 pro. Do you know if it worked previously ? If so with wich version ?

Same problem here.
I use LineageOS for microG (fork of LineageOS with microG pre-installed).
0.2.13-203916 installs fine, 0.2.14 can't be installed (both manually or with Vanced Manager).

Hey, same here, just got p40 pro. Do you know if it worked previously ? If so with wich version ?

0.2.13-203916

Look at last push code, the package is named again in com.google.android.gms and not more in com.mgoogle.android.gms
This is the big problem, i don't know why devs haven't fixed that.
From official readme:

Package name changed from ### com.google.android.gms to ### com.mgoogle.android.gms to support installation alongside the official MicroG

Where are the devs? They are still here?

Where are the devs? They are still here?

On Discord channel.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope they fix this awful problem.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Ooook...I hate to leave something incomplete, so I have however fixed the bug. 👍

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Stunning! It works with no problem. Installed together vanilla version.
Thank you!
I need an advice, this thing also with previous versions. I have the vanced notifications about battery optimization but when i try to search vanced microg this doesn't appear so nothing can be done. The standard microg instead is in the list.
Can be this a problem?

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Stunning! It works with no problem. Installed together vanilla version.
Thank you!
I need an advice, this thing also with previous versions. I have the vanced notifications about battery optimization but when i try to search vanced microg this doesn't appear so nothing can be done. The standard microg instead is in the list.
Can be this a problem?

If you don't disable the optimization you may have problems to receiving notifications from Youtube. That's why there's always a message that suggests you to turn off optimization.
In every case idk how to fix this problem without enable microg icon on home launcher (I guess Huawei need of this to add an app to the list).

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Stunning! It works with no problem. Installed together vanilla version.
Thank you!
I need an advice, this thing also with previous versions. I have the vanced notifications about battery optimization but when i try to search vanced microg this doesn't appear so nothing can be done. The standard microg instead is in the list.
Can be this a problem?

If you don't disable the optimization you may have problems to receiving notifications from Youtube. That's why there's always a message that suggests you to turn off optimization.
In every case idk how to fix this problem without enable microg icon on home launcher (I guess Huawei need of this to add an app to the list).

I think to have understood but i am not sure about last period.
The icon of vanced microg is on home launcher so this is right, like with vanilla microg. But the problem with that notification is that there is not vanced microg app in the list of app to optimize. There is only standard microg.
I remember that some versions ago vanced microg was in the list and we could deactivate the battery optimization. So maybe it's a bug, i don't know honestly. Still thanks!

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Stunning! It works with no problem. Installed together vanilla version.
Thank you!
I need an advice, this thing also with previous versions. I have the vanced notifications about battery optimization but when i try to search vanced microg this doesn't appear so nothing can be done. The standard microg instead is in the list.
Can be this a problem?

If you don't disable the optimization you may have problems to receiving notifications from Youtube. That's why there's always a message that suggests you to turn off optimization.
In every case idk how to fix this problem without enable microg icon on home launcher (I guess Huawei need of this to add an app to the list).

I think to have understood but i am not sure about last period.
The icon of vanced microg is on home launcher so this is right, like with vanilla microg. But the problem with that notification is that there is not vanced microg app in the list of app to optimize. There is only standard microg.
I remember that some versions ago vanced microg was in the list and we could deactivate the battery optimization. So maybe it's a bug, i don't know honestly. Still thanks!

Technically shouldn't, because I removed the icon code from manifest xD (and indeed this doesn't shown in practically every case).
EMUI works in a way that I don't understand.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

Stunning! It works with no problem. Installed together vanilla version.
Thank you!
I need an advice, this thing also with previous versions. I have the vanced notifications about battery optimization but when i try to search vanced microg this doesn't appear so nothing can be done. The standard microg instead is in the list.
Can be this a problem?

If you don't disable the optimization you may have problems to receiving notifications from Youtube. That's why there's always a message that suggests you to turn off optimization.
In every case idk how to fix this problem without enable microg icon on home launcher (I guess Huawei need of this to add an app to the list).

I think to have understood but i am not sure about last period.
The icon of vanced microg is on home launcher so this is right, like with vanilla microg. But the problem with that notification is that there is not vanced microg app in the list of app to optimize. There is only standard microg.
I remember that some versions ago vanced microg was in the list and we could deactivate the battery optimization. So maybe it's a bug, i don't know honestly. Still thanks!

Technically shouldn't, because I removed the icon code from manifest xD (and indeed this doesn't shown in practically every case).
Maybe it's a bug, I don't know. EMUI works in a way that I don't understand.

So weird. About "Technically shouldn't" you mean that vanced microg icon on home launcher shouldn't appear although in my case it appears?

Exactly... Indeed this doesn't shown to me.

Exactly... Indeed this doesn't shown to me.

As a last thing can you add again the icon code from manifest so we can also defeat this last bug about vanced microg app missing in optimization battery app list?
Please and thanks man ;)

Exactly... Indeed this doesn't shown to me.

As a last thing can you add again the icon code from manifest so we can also defeat this last bug about vanced microg app missing in optimization battery app list? That notifications will make sense again.
Please and thanks man ;)

I can't, because otherwise everyone will get back the home launcher icon.

Ok man, understtod. But i think this is not a good choice, not only for huawei, to deactivate battery optimization just as that notification indicates. Indeed there isn't this problem on vanilla microg. App appears in home launcher and in battery optimization list like should.
Then, in my case with huawei, the home launcher still appears so it's a bit non sense.
Btw think about it if you can because I believe that this choice not to make the icon appears in home launcher can compromise the deactivation of battery optimization for vanced micro g!
Thanks man for support.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

The link to the fix says the file is no longer available

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

The link to the fix says the file is no longer available

Soon will be available on manager.

Where are the devs? They are still here?

On Discord server:
https://discord.com/invite/K9KKDqd

I prefer here. Hope you can fix this awful problem.
From readme:
Package name changed from com.google.android.gms to com.mgoogle.android.gms to support installation alongside the official MicroG

I was the mainteiner of this repository. But now I deceided to stop the works on this, because I'm tired of update MicroG.
There's no dev here apart me, so ask support on discord channel. Otherwise you will be ignored.

Oh God! :(

Try this package:
https://mega.nz/file/IJEQwDbb#A5XLyIguXWd7EEDuG-GZ-wHh2S8ZRJRZdlj6yzUDRaQ

The link to the fix says the file is no longer available

Soon will be available on manager.

Hi Man, can you make a different build to post (only) here with that icon code in manifest?

@michael1900 Uninstall previous and install this:
https://mega.nz/file/8Z8GhDjB#RwL_uAipR8JACzK-YrkkICe4WGxEOJaCM0vYoWcGcJc

@michael1900 Done. Uninstall previous and install this:
https://mega.nz/file/8Z8GhDjB#RwL_uAipR8JACzK-YrkkICe4WGxEOJaCM0vYoWcGcJc

Stunning job Man. ALL fixed. Hope this mod will be in official repo with new devs.
Thanks again!

@michael1900 Done. Uninstall previous and install this:
https://mega.nz/file/8Z8GhDjB#RwL_uAipR8JACzK-YrkkICe4WGxEOJaCM0vYoWcGcJc

Stunning job Man. ALL fixed. Hope this mod will be in official repo with new devs.
Thanks again!

Unfortunately not. At least not in this form. I temoved this icon because was useless (indeed manager already give the possibility to access to vanced microg settings).

@Oizaro could you please upload the apk once again? Perhaps not to mega, because it continue to remove it :)

Fixed in latest release


Wait for cluster to be healthy

Currently the compose plugin is not waiting for the services to be healthy.
This is causing problems in our CI where some containers need warmup time

it is indeed an interesting use case, unfortunately, the change broke existing tests with dependencies.
How about adding it behind an option that defaults to false? This not only would avoid a major release, but it would also mean that existing tests wouldn't break and you would just need to add a couple new ones only. What do you think?

@usmanismail let us know if you are still interested in working on this functionality. If you are not but still want this functionality, either allow us permissions to push on this PR or let us know and close this PR so that we can open a new one :)

Hi Sorry,
I found a cleaner solution for my issue i.e. Using a condition: service_healthy inside the docker compose file.
Feel free to close and create a new PR or repurpose this one as needed.

Thanks a lot for your contribution anyhow, I believe that this may be a good feature anyways for those that can't modify their docker compose file so we'll add it as a feature :)


CHANGELOG for 1.8.0

Closes #346
Signed-off-by: David Thompson<EMAIL_ADDRESS>

Is it worth including any of 26316e01f251e6659675ab03eea783c855ccde2d, 9b3361a7daf7a4c2ca4f4204b2ac87c4cca842b8 ?

Yes, I'll add them.


[FLINK-2615]Preserve executors for the entire run of program.

Prevents re-starts of local cluster several times on multiple executions.
Preserves the executor states for the entire run of the program.

The current behavior is actually desired. You can explicitly start the local executor, and explicitly stop it. When you did not explicitly start it, you get an auto-shut down executor. This is quite flexible, no?
The LocalExecutionEnvironment is a local one-time environment. There is code to extend it to sessions, which is really what we want to "keep context and data around".
For that, there is part of the work here: https://github.com/apache/flink/pull/858
It follows a very principled approach, where the responsibility of deciding clearing / disposal of cached context and data is bound to a session. Sessions have timeouts and scope reapers, and are managed by the execution environments, not the executors.

Aha. I just had a brief look at the PR.
I had initially thought of implementing a start and stop method in the ExecutionEnvironment but decided against it, since it changes the api for very minor changes.
Session management is a way better solution. Any timeline on when those changes could get merged?

I would move the discussion to the respective PR. Sachin, could you close this PR?

Sure.


user should be able to leave app and have onionservice / http service continue to run

even if just briefly for a few minutes
warn them to return to app if it is going to shutdown

See #1.
Keeping the lights on is an ugly, battery-draining hack , but the only way. Will implement that.

Ah, misunderstanding in the late evening. You're talking about background operations.
That's already included:
https://github.com/swisspol/GCDWebServer#gcdwebserver--background-mode-for-ios-apps
https://github.com/tladesignz/AdParticipesCumCepis/blob/main/AdParticipesCumCepis/Classes/Utils/WebServer.swift#L177
For the notification part:
I'll try something. Not sure if that's going to work, sending user notifications from the background.

Ok, notifications work just fine from the background.
However, it's not staying alive very long, currently.
Our own background thread just sleeps, that might be detected. Need to do some useless calculation there, maybe. More battery to drain :-(
GCDWebServer is quick to tell the OS, that it's done, too, after all requests were fulfilled.
https://github.com/swisspol/GCDWebServer/blob/master/GCDWebServer/Core/GCDWebServer.h#L186-L193
I tuned this parameter to 10 seconds, but I'm afraid I can't do more, because then I couldn't do #10 anymore. That option is also used in the detection when a download is considered "finished".

So, I refined this a little more. Tried asking less about rest of time, tried getting CPU busy. Nothing helped. I only ever got 30 seconds. Might be because debug. Other resources say 3 minutes are typical.
It now notifies the user between 15 and 10 seconds before shutdown. Don't think that can get any better.
Funny side note about keeping the CPU busy:
I tried Fibonacci and it was either 30% load but with a recursion limit or tail-call-optimized through the compiler with 0% load. D'oh!


feat: partic contrib details

Codecov Report
Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (1999499) to head (69c7627).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

...iew/participant-contribution-details/controller.ts
87.09%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   91.48%   83.58%   -7.90%
==========================================
  Files         309      312       +3
  Lines        4579     4636      +57
  Branches      691      705      +14
==========================================
- Hits         4189     3875     -314
- Misses        388      744     +356
- Partials        2       17      +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixed compiling issue with Xcode 13 beta #925

Connection with issue(s)
Resolve issue #925

Connected to #???

Testing and Review Notes

Following the steps from 925, there are no more compile errors

Screenshots or Videos

To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers
[ ] request the "UX" team perform a design review (if/when applicable)

After further investigations, I found out that after this change, the project won't build on Xcode 12 anymore. It is probably better to wait until the official release of Xcode 13.


Append/ Overwrite to table via Spark API

Hi Guys
I have been using this project to set up a spark connector to BQ,  I noticed that writing to a bq table via .saveAsNewAPIHadoopDataset(hadoopConf) results in my table getting duplicate data. I understand that because I am calling the save method twice (2 different batch jobs)
The problem is the source data doesnt have the ability to be streamed so it leads me to rerunning the job in a batch manner, its an API
This means that some of the data returned per job is the same which results on duplicate data being inserted
Is there a way to set up the connector so that it recognises the records are the same and either append or overwrite them?
I think the job configuration allows me to to this via the create/write disposition
Is there something similar to that using the API?

Unfortunately, the notion of "duplicate records" isn't really a top-level supported concept in BigQuery because BigQuery isn't indexed as a transactional database. On the one hand, BigQuery doesn't know whether identical records were intentionally inserted multiple times or if they were intended to be unique, and for the connector, while writing to BigQuery, there's no efficient way to determine if a particular record is already in the table without performing a full scan to do the lookup.
This StackOverflow answer from a BigQuery engineer shows how you can use queries in BigQuery itself to remove duplicates in post-processing: http://stackoverflow.com/a/36686205/3777211


Suspend limited to shorter ones

On AOSP, without network, suspend times are relatively long, as several minutes. On Sailfish, we get about 10 seconds on average.

Sometimes, we have bursts of suspend failures, as it was early in the porting. Will have to follow which wakelocks are causing it.

In flight mode, we get 150s suspend duration - same period as set for collectd, so its working as expected. So, for full offline we are in a clear, its behaving exactly as expected.

Recently suggested for debugging by Angelo:

activate irq sleep debug
check irq number
check /sys/kernel/irq/{number}/* nodes
check pdc-sdm845.c

how can be enabled that?

would have to read about it. this could give some info: https://sx.ix5.org/info/post/android-kernel-suspend-debugging-and-tracing/

Closing it as suspend seemed to be an expected one in flight mode.


Optimize startup configuration.

Notes for Reviewers
This PR feature#
optimize this startup configuration into the .env environment configuration.
this issues https://github.com/meshery/meshery/issues/10754
Signed commits

[x] Yes, I signed my commits.

Thank you for your contribution @jinronga
Let's discuss this in Meshery dev call today. Add this as an agenda item to the meeting minutes, if you would :)


Switch logger from Winston to pino

According to the benchmarks, our logging will tie up much less server resources if we migrate off winston.

Worth looking at.  Our use of winston isn't superficial.  Custom log levels.  Custom transports.  Custom client logger that implements the same interface.  That's not even counting the extensions we have at Redfin that we haven't pried out to open source yet.


Issue 322

This fixes #322

Could you please provide some screenshots? And what are current limitations? Does it work?

Rest api is not integrated yet, its a simple function execution result from OFunction.execute.

Ok - please keep this issue as is: I will finalize it.

Done here: https://github.com/OrienteerDW/Orienteer/commit/614b603b12ac16657fba3d57fe5d23541c832ffe


Support for oneOf

Rebased @maroux work (#132)

@lyssdod looks like there are some linting errors.  You can see them here: https://travis-ci.org/pipermerriam/flex/jobs/306744346
Or run the linter yourself locally with tox flake8 or flake flex

isn't one of part of OAS 3.0 ?


Delete cert-manager-v0.6.0-dev.5.tgz

This file was committed accidentally from a development build
Signed-off-by: James Munnelly<EMAIL_ADDRESS>Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

I believe this is still legit. Only needs a /retest @munnerz

@munnerz The chart version still needs to be bumped. Thanks


Scorecard should try to earn a CII Best Practices badge

Is your feature request related to a problem? Please describe.
Scorecard should try to earn a CII Best Practices badge.
Additional context
Both scorecard & the CII Best Practices badge are OpenSSF projects focused on best practices to improve OSS security. They have different approaches and somewhat different criteria, but I think each would be helped by working on the other. I'm the lead of the CII Best Practices badge project, and I'm trying to meet the scorecard criteria (or complain when I think there's a problem). I think it'd be great if scorecard reciprocated.

Not stale.

Happy to help if you'd like!

Yes,Thank you! What is the process?

I've started the process by clicking "get a badge". Waiting for OSSF to accept the OAuth request.

@laurentsimon - presuming you're logged into GitHub, the "get a badge" click should have gotten you to a list & getting started pretty quickly. If you're hung, something is wrong.
What happened? If you're stuck I want to make sure you (& anyone else) gets unstuck :-).

I indeed got a list of repos, but ossf/scorecard does not show up. I think it's because the OAuth does not have the scope to read it, I see "Access request pending" under Installation > Application

@justaugustus assigning this to you since you earned Scorecard a CII Best Practices badge (yay, thanks a lot!). We can close this unless you plan on working on this further and want to use this to track your progress.

@justaugustus assigning this to you since you earned Scorecard a CII Best Practices badge (yay, thanks a lot!). We can close this unless you plan on working on this further and want to use this to track your progress.

Will keep this open as there's still a bunch to do! :)

@justaugustus Scorecard now has a "passing" BP badge. Do we want to continue working toward silver or gold level badges at this time or do we consider this issue done?

Closing this, as leaving it open for all badge levels might be too much.
I'll open additional issues as needed, as part of the "Apply for appropriate status in OpenSSF project lifecycle" task in https://github.com/ossf/scorecard/issues/4073.


Rows getting truncated to 5000 results

Steps to reproduce:
I have not yet created a minimal repro of this issue. Below are the approximate steps to reproduce this issue.

Insert 6000 rows for the same time series.
Run this query:

from(bucket:"my-bucket")
|> range(start:2020-01-01T00:00:00Z,stop:2020-01-25T00:00:00Z)
|> filter(fn: (r) => r["foo"] == "bar")
|> filter(fn: (r) => r["_value"] == true)
|> count()

That returns one row with the _value at 5000.

Now remove the last two lines so the query looks like this:

from(bucket:"my-bucket")
|> range(start:2020-01-01T00:00:00Z,stop:2020-01-25T00:00:00Z)
|> filter(fn: (r) => r["foo"] == "bar")

Count the resulting number of rows that _value is equal to true and I get 5433. This is the correct answer yet the previous query returned 5000.

Expected behavior:
The total number of rows matching the filter are returned and taking into account by the aggregate.
Actual behavior:
The number of rows returned is limited to 5000 even though no limit is set.  This results in an incorrect aggregate.
Environment info:
InfluxDB Cloud v2

@kennyjwilli This issue has been fixed. I verified today that its working. Here is the PR that fixes it if you are curious https://github.com/influxdata/influxdb/pull/16600 There was also some other work that happened on the cloud side of things to get this fix all the way out.
Can you confirm from your side of things that its working?

@nathanielc Sorry for the delay here.
I'm still seeing some strange behavior. Running this query incorrectly returns 1000.
from(bucket:"my-bucket")
|> range(start:2020-01-04T00:00:00Z,stop:2020-02-18T00:00:00Z)
|> filter(fn:(r) => (r["_measurement"] == ":data-point.measurement/aws-workspace" and r[":application-spec/id"] == "abc123" and r[":monitored-aws-workspace/workspace-id"] == "id"))
|> filter(fn:(r) => (r["_field"] == ":data-point.field/aws-workspace-user-connected?" and r["_value"] == true))
|> count()

Running this query correctly returns 5521.
from(bucket:"my-bucket")
|> range(start:2020-01-04T00:00:00Z,stop:2020-02-18T00:00:00Z)
|> filter(fn:(r) => (r["_measurement"] == ":data-point.measurement/aws-workspace" and r[":application-spec/id"] == "abc123" and r[":monitored-aws-workspace/workspace-id"] == "id"))
|> filter(fn:(r) => (r["_field"] == ":data-point.field/aws-workspace-user-connected?" and r["_value"]))
|> count()

You'll notice the only different between the two queries is r["_value"] == true versus r["_value"].

@kennyjwilli this should have been fixed in https://github.com/influxdata/influxdb/pull/16600 . Can you verify that recent beta releases still exhibit this behavior?

@kennyjwilli I have built and run 2.0.0 beta 9 to test this. To me, things are working as intended. Can you recheck?
$ while true; do influx write -o my-org -b my-bucket "m,test=bool v=true" -t my-token; done
^C
$ influx query -o my-org 'from(bucket: "my-bucket") |> range(start: -24h) |> filter(fn: (r) => r["test"] == "bool")' | wc -l
    2446
$ influx query -o my-org 'from(bucket: "my-bucket") |> range(start: -24h) |> filter(fn: (r) => r["test"] == "bool") |> count()'
Result: _result
Table: keys: [_start, _stop, _field, _measurement, test]
                   _start:time                      _stop:time           _field:string     _measurement:string             test:string                  _value:int
------------------------------  ------------------------------  ----------------------  ----------------------  ----------------------  --------------------------
2020-05-10T16:59:59.789123000Z  2020-05-11T16:59:59.789123000Z                       v                       m                    bool                        2442

We aren't having this issue with the latest InfluxDB Cloud v2 so guessing it is resolved.


Question: How to get HTTP Errors from react Webview in onLoad() callback?

I know there was a fix in v7 to add callback onHttpErrors( ) for 5xx, 4xx and other server errors. But I am running on an older version and cannot upgrade unfortunately.
Is there any way to get the HTTP error code in the onLoad() callback?

There is not. That's why the callback was added. But you could try digging up the PRs that added onHttpError support and patch in just those changes to your version.


Fixed ScrollPane scrolling for very large heights

There was an issue with ScrollPane scrolling too much for content with very large dimensions. The new implementation fixes this by using a minimum value of either the area dimension of the ScrollPane or 20% of the content dimension.
Four extra fields were also included so the mouseScroll amount can be customized as well as the smooth scrolling animation speeds

@NathanSweet could you check this out and merge or close?

I'll fix the branch conflict and post an SSCCE later so this issue can be resolved. Are there any rules for SSCCE or do I just attach the.jar to the next message?

Your SSCCE should be source code.


build(cypress): Use pull_request_target event to run cypress

SUMMARY
Updates Cypress e2e test Github Actions workflow to use the pull_request_target event in order to work around the secrets sharing limitation for forked repos. Also adds concurrency via multiple containers.
NOTE: the pull_request event trigger is required to get e2e tests passing in this PR, but will be removed in a subsequent PR in favor of pull_request_target.
Replaces https://github.com/apache/incubator-superset/pull/11730
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
e2e test workflow should run with a populated CYPRESS_RECORD_KEY value from the upstream repo's secrets.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11750 (bece92c) into master (c79dc47) will decrease coverage by 3.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11750      +/-   ##
==========================================
- Coverage   66.24%   62.36%   -3.88%
==========================================
  Files         897      443     -454
  Lines       43463    27260   -16203
  Branches     4186        0    -4186
==========================================
- Hits        28790    17000   -11790
+ Misses      14557    10260    -4297
+ Partials      116        0     -116

Flag
Coverage Δ

cypress
?

javascript
?

python
62.36% <ø> (-0.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/db_engine_specs/hive.py
54.08% <0.00%> (-29.97%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
81.93% <0.00%> (-5.47%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 471 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79dc47...bece92c. Read the comment docs.

Cypress runs are not showing up in the Cypress dashboard for some reason.

push run and pull_request run is different as push run tests the code on the branch, pull_request tests the code after merging with master. Normally this doesn't matter as most branches are up to date when the PR is created, but there is this difference so I just want to make sure we made a conscious decision here.

Thanks for the clarification @ktmud. The pull_request triggered workflow runs are reported on PRs, making it a bit confusing (and likely unknown) that push workflow runs are also running in the background. Though, the Cypress dashboard reports mainly push triggered runs, with an occasional pull_request event. Unclear why this is.
Another strange thing, push-based workflows seem to be running concurrently, even though they should not(?) have access to secrets in the upstream repo.

Restoring push on all branches to test if concurrency works and if it's reported in the Cypress dashboard.

Confirmed: the push triggered tests are run in parallel.

I think the pull_request run (the one that is used in CI status reporting in PRs) still don't run in parallel, which means we probably have spun up two jobs unnecessarily.
It seems pull_request_target can only run in the background (like push) and can not be used to update CI status.
I'm wondering if we should just revert back to the push and pull_request, but 1). skip Container 2 and Container 3 if CYPRESS_RECORD_KEY is not accessible; 2) let committers know that if they create branches and make PRs from the apache repo, the CI will run faster.

@ktmud correct, the pull_request runs are not running in parallel because they don't have access to the record key. The goal here is to merge this PR, then open a subsequent PR to remove the pull_request event in favor of pull_request_target, which should have access to the record key. If this plan doesn't work, we can revert this and try a different approach.

@ktmud correct, the pull_request runs are not running in parallel because they don't have access to the record key. The goal here is to merge this PR, then open a subsequent PR to remove the pull_request event in favor of pull_request_target, which should have access to the record key. If this plan doesn't work, we can revert this and try a different approach.

Makes sense!

Here's how this worked in superset-ui: https://github.com/apache-superset/superset-ui/pull/853


doc: Simplify Windows deployments with RuntimeClass

The RuntimeClass scheduler work done in 1.16 can actually simplify steering Linux or Windows pods to appropriate nodes. This adds an example and suggested default RuntimeClasses to take advantage of it.
I also corrected some references to labels that changed as they were promoted from beta to stable.
I'm seeking review from SIG-Windows and SIG-Node before this should merge, so I placed a hold on it.
/hold
/sig windows
/sig node

Should we target master rather than release-1.16 branch?

@tengqm - I can rebase to master if you'd like. I would like this in both places, so should I PR to master then cherry-pick to 1.16?

I'm rebasing and moving this to 1.17

/milestone v1.17
I will be using this as the work-in-progress docs for https://github.com/kubernetes/enhancements/issues/1301

/milestone 1.17

/remove-language de es fr id ja ko zh

@PatrickLang Is this doc ready for review?

@PatrickLang
This is a kind reminder since we're approaching the deadline for PR to be "Ready for Review" by Nov 15, 2019. Kindly update this PR.

I should be able to update this tomorrow morning. I need to check the examples

/hold cancel
Ready for reviews

/lgtm

/approve


some fixes/ improvement and a couple of clones

Fixes:

BlackJack game: ignoring buttons events on pauses

Improvements:

Desktop Launcher: reset to the clock after 2 mins of inactivity

sometimes you may have the launcher mistakenly up. if so after some inactivity it comes back to the main screen

App Manager: Allow negative numbers when manual-sorting

negative numbers when sorting can be useful with Desktop Launcher to manage secondary applications

Clones:

Magic 8 Ball Italiano: like Magic 8 Ball but in Italian :D
- my children love 8 ball but can barely read Italian. I have no idea how to handle it better than cloning
Red torch: like torch but red :D
- amateur astronomers will like that

Great - thanks! Sorry for the delay - I was on holiday the last 2 weeks.
With the translations - there is something planned, but for the moment I think cloning is the best solution as you say!


OTR viral induced premature senescence (GO:0090401)

Hello,
Looking at #12975 - the term 'viral induced premature senescence' should be clarified.
Right now the definition ("A cellular senescence process associated with the dismantling of a cell as a response to viral infection") is very similar to that of "killing by symbiont of host cells" or at least "disruption by symbiont of host cell" (def: "A process by which a virus has a negative effect on the functioning of the host's cell.").
Also, the 'dismantling' of cell as described in 'viral induced premature senescence' appears much more lethal compared to how cellular senescence is described ("A cell aging process stimulated in response to cellular stress, whereby normal cells lose the ability to divide through irreversible cell cycle arrest.")
@RLovering : BHF created this term: There are no papers cited in the definition and no annotations. Usage examples would be very useful to decide if it's a host defense process or a disease process.
Thanks, Pascale

Is this a possible paper you were trying to annotate ?
http://genesdev.cshlp.org/content/14/16/2015.short

@pmasson55 Do you have any comment to make on this term ? What do you recommend we do with it ?

Please do what is needed - sorry not more helpful

Dear all,
The proposal has been made to obsolete GO:0090401 viral induced premature senescence.
The reason for obsoletion is that it’s not clear what the term is meant to be used for; there are no annotations and no references. There is nothing in the literature that mentions this process; there are papers that mention viral proteins overcoming premature senescence, for example: PMID:22326283.
Please add any comments to the issue: https://github.com/geneontology/go-ontology/issues/13626
We are opening a comment period for this proposed obsoletion. We’d like to proceed and obsolete this term on Dec 11, 2017. Unless objections are received by Dec 11, 2017, we will assume that you agree to this change.
Thanks, Pascale

Dear all,
I agree to obsolete this term. I don't know any virus using this process to its advantage.
Cheers
Philippe Le Mercier