Breaks for MediaStreamTrack from HTMLMediaElement.captureStream()

Object returned from getSettings() method of MediaStreamTrack from HTMLMediaElement.captureStream() does not include channelCount, only deviceId and sampleSize. MediaStreamTrack.channelCount is undefined, and Web Audio API MediaStreamAudioSourceNode channelCount is always set to 2, does not reflect the actual channel count of the underlying MediaStreamTrack.
https://github.com/davedoesdev/webm-muxer.js/blob/375cc63f5bd940303037026347ff141b2ee2281f/demo.js#L140
One approach to get the accurate channel count is create a MediaStreamTrckProcessor to read one frame, get numberOfChannels from AudioData
  const getChannelCount = async(track) => {
    const processor = new MediaStreamTrackProcessor({track});
    const reader = processor.readable.getReader();
    const { numberOfChannels } = (await reader.read()).value;
    try {
      await reader.cancel();
      await reader.closed;
    } catch(e) {
      console.log(e);
    }
    return numberOfChannels;
  }

Thanks, I can confirm channelCount is always 2, very helpful API that :)

@davedoesdev I filed a Web Audio API issue re this. If you are so inclined perhaps you can post your test results there and describe how the incorrect value for channelCount is problematic for your code.
I encountered this while testing concatenating all encoded audio from WebCodecs AudioEncoder to a single file with the minimal header instructions necessary to play back the file with Media Source Extensions appendEncodedChunks(). During preliminary testing the file size is less than Opus in WebM produced by MediaRecorder, for a 4:14 audio file captured with captureStream() the WebM file is 3196093 bytes, the header plus ArrayBuffer from AudioData is
3184702 bytes,  thus we do not really need to write the Opus packs to a WebM container. It would be helpful for independent testing with greater during input. Let me know if you are interested.

Yeah sorry I don't have time to do that.
Is the WebAudio API issue https://github.com/WebAudio/web-audio-api/issues/2389 ?

No. That is the other part of channelCount issues in Web Audio API. https://github.com/WebAudio/web-audio-api/issues/2496. The core issue is getSettings() does not work. However, W3C banned me from filing issues in their repositories.

Yeah sorry I don't have time to do that.

If you find the time, let me know. I prefer independent testing to verify results. I improved the encoding part. I am relatively certain the encoding part consistently produces a file of less size than writing to a WebM container. This is the initial version of the playback part https://plnkr.co/edit/cAbZqVXfzZMFOaxL.

Yeah sorry I don't have time to do that.

FWIW, Not much time is required to test. I already wrote the code that saves both MediaRecorder result and AudioEncoder configuration with 'opus' packets. All that is required is to verify on a different machine that the file produced by writing metadata, offsets, and audio packs is less than the WebM file produced by MediaRecorder.

@davedoesdev FWIW this is the source code to write configuration and EncodedAudioChunks to a single file, and play back that single file using Media Source Extensions https://github.com/guest271314/WebCodecsOpusRecorder. So far in all of the tests I have run the file is less size compared to encoding Opus packets in a WebM container.


Minor fixes for Chart API

Some minor fixes for the KLIPS Chart API:

add loading mask

Nice Feature @sdobbert !


NetBSD 10 amd64 failures

The following tests did not run:
        171 - FastPathAlloc (Skipped)
        172 - FastPathAlloc_optimised (Skipped)

The following tests FAILED:
         21 - BlockImpTest (SEGFAULT)
         22 - BlockImpTest_optimised (SEGFAULT)
         23 - BlockImpTest_legacy (SEGFAULT)
         24 - BlockImpTest_legacy_optimised (SEGFAULT)

thank you for testing! i‘ll look into it.


udev: Add devnode to mounts not devpath

What this PR does / why we need it:
The udev discovery handler currently adds the udev devpath to the device mounts, this doesn't allow access to the devnode and moreover said devpath is not a correct absolute path (it is relative to /sys).
This PR changes the current behavior to add the devnode (if any) to the device mounts instead of the (wrong) sysfs devpath.
Special notes for your reviewer:
If applicable:

[ ] this PR has an associated PR with documentation in akri-docs
[ ] this PR contains unit tests
[x] added code adheres to standard Rust formatting (cargo fmt)
[x] code builds properly (cargo build)
[x] code is free of common mistakes (cargo clippy)
[x] all Akri tests succeed (cargo test)
[x] inline documentation builds (cargo doc)
[x] all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@diconico07 great catch! This was caused by my changes here not keeping the mounting of the devnode consistent: https://github.com/project-akri/akri/pull/534.

/version patch

I am not sure why e2e tests are not being kicked off

I am not sure why e2e tests are not being kicked off

From what I read in run-test-cases.yml it doesn't trigger for changes limited to discovery handlers (as the e2e tests are only using the debugEcho handler this doesn't seems wrong)


decreased mating with non-sister cells

PMID:30279276
suggested name: decreased mating efficiency with non-sister cells
suggested def: A decreased mating efficiency with non-sister cells is a decrease in mating efficiency in homothallic populations specifically with non-sister cells.
check whether this should be "conjugation frequency" instead; either way, spiff up text def

decreased frequency of conjugation with non-sister cells FYPO:0007699


QloveR.jp

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and am willing to share it if required

Region
Japan
Example URLs

Video: https://qlover.jp/midnightdoublepeek/video/smd8eTFaYqeBvMLNshnV7dUB
Audio: https://qlover.jp/hige/audio/smS2oaz3UyQfSr2afsmjnGvH
Live: https://qlover.jp/agplayer/live/smSrNScKrWnjPhRZURctFWid - The example URL shows a simulcast to JoqrAG (uniqueradio.jp/agplayer5/); the URL changes daily.
Live video archive: https://qlover.jp/onaken/video/smmCp8uhNrojyPHzCk6ZyJbK

Provide a description that is worded well enough to be understood
The framework of this site looks very similar to NiconicoChannelPlus [nicochannel.jp].
All of the URLs example above are free videos that do not require login, but there are also paid videos that require login, such as NiconicoChannelPlus.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://qlover.jp/midnightdoublepeek/video/smd8eTFaYqeBvMLNshnV7dUB']
[debug] User config "/home/***/.config/yt-dlp/config": ['-o', '%(channel)s_%(upload_date)s_%(title)s_%(id)s.%(ext)s']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [f3411af12] (zip)
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.4.0-186-generic-x86_64-with-glibc2.29 (OpenSSL 1.1.1f  31 Mar 2020, glibc 2.31)
[debug] exe versions: ffmpeg N-70388-gaff24c1658-static (setts), ffprobe N-70388-gaff24c1658-static, rtmpdump 2.4
[debug] Optional libraries: certifi-2019.11.28, mutagen-1.45.1, pycrypto-3.15.0, requests-2.22.0, secretstorage-2.3.1, sqlite3-3.31.1, urllib3-1.25.8, websockets-8.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1823 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[generic] Extracting URL: https://qlover.jp/midnightdoublepeek/video/smd8eTFaYqeBvMLNshnV7dUB
[generic] smd8eTFaYqeBvMLNshnV7dUB: Downloading webpage
ERROR: [generic] Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: Not Found>)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 740, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 2383, in _real_extract
    full_response = self._request_webpage(url, video_id, headers=filter_dict({
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 909, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/usr/local/bin/yt-dlp/yt_dlp/networking/_urllib.py", line 396, in _send
    res = opener.open(urllib_req, timeout=self._calculate_timeout(request))
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 896, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query, extensions))
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 4141, in urlopen
    return self._request_director.send(req)
  File "/usr/local/bin/yt-dlp/yt_dlp/networking/common.py", line 117, in send
    response = handler.send(request)
  File "/usr/local/bin/yt-dlp/yt_dlp/networking/_helper.py", line 208, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/yt-dlp/yt_dlp/networking/common.py", line 337, in send
    return self._send(request)
  File "/usr/local/bin/yt-dlp/yt_dlp/networking/_urllib.py", line 401, in _send
    raise HTTPError(UrllibResponseAdapter(e.fp), redirect_loop='redirect error' in str(e)) from e
yt_dlp.networking.exceptions.HTTPError: HTTP Error 404: Not Found

Triage: that's a Sheeta site; should be solved with #9541.


WSL Support

Describe the bug
Files doesn't open the Linux system's directories from any of the WSL shells.
Steps to reproduce the behavior:

Go to a WSL  shell  (I Use ZSH shell and an Ubuntu subsystem)
Type explorer.exe "directory" or files.exe "directory"

Expected behavior
Opening the File app in the specified dir
Additional context

I Sat up Files to be my default app using the steps provided on the repo.
I downloaded Files from MSStore
I'm using WSL 2 (Ubuntu)
Using which files.exe in the shell it correctly outputs where Files is located

Are you able to open any UWP apps from WSL command line? I don't think it's supported
Does the following work instead? cmd.exe /c "files "c:\\users\\marco""

Are you able to open any UWP apps from WSL command line? I don't think it's supported
Does the following work instead? cmd.exe /c "files "c:\\users\\marco""

This cmd command defaults to the window's directory even when specifying the wsl home's absolute path
And Files doesn't Launch when I write files.exe "anyDIR", not even the default windows explorer.

This cmd command defaults to the window's directory even when specifying the wsl home's absolute path
And Files doesn't Launch when I write files.exe "anyDIR", not even the default windows explorer.

This works for me from WSL bash: cmd.exe /c files.exe "\\\\wsl$\\ubuntu\\home" -> escaped backslash

This works for me from WSL bash: cmd.exe /c files.exe "\\\\wsl$\\ubuntu\\home" -> escaped backslash

When I used this:

The terminal froze and I couldn't even escape/quit to be able to type commands again
I couldn't cd into the WSL Directories from another instance of the terminal using the path above ("\\wsl$\ubuntu\home")

More info:
I can use explorer.exe "directory name" in this terminal and it works normally

When I used this:

The terminal froze and I couldn't even escape/quit to be able to type commands again
I couldn't cd into the WSL Directories from another instance of the terminal using the path above ("\\wsl$\ubuntu\home")

More info:
I can use explorer.exe "directory name" in this terminal and it works normally

Sorry, I don't think this is something we can fix as the same seem to apply to any other window store app.

Sorry, I don't think this is something we can fix as the same seem to apply to any other window store app.

@gave92 there is a fix for this, but I wasn't able to even build the project by itself, well I was able to build it but not the test command line arguments;
TDLR: A rewrite of the way Files parses the command line arguments should make this work

@gave92 there is a fix for this, but I wasn't able to even build the project by itself, well I was able to build it but not the test command line arguments;
TDLR: A rewrite of the way Files parses the command line arguments should make this work

@DiegoMagdaleno thanks cool! Feel free to open a PR with the changes (even untested) 👍

@DiegoMagdaleno thanks cool! Feel free to open a PR with the changes (even untested) 👍

Is this still an issue? I can confirm that cmd.exe /c files.exe "c:\\" & works fine for both WSL1 and WSL2


unify the default readiness timeout

As discussed in https://github.com/istio/istio/issues/26792#issuecomment-692172022, this PR unifies the readiness timeout across injection template and code. I have set to 3s to be conservative across both and removed the configurability.
Fixes #https://github.com/istio/istio/issues/26792
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ X] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
71482260ffe1bf7953878650cdb5d658b69912d9
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
71482260ffe1bf7953878650cdb5d658b69912d9
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
71482260ffe1bf7953878650cdb5d658b69912d9
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

/test integ-multicluster-k8s-tests_istio


[Module Federation] Webpack build fails if shared is a non empty array in Module Federation Plugin

Bug report
What is the current behavior?
On running webpack build(I am using webpack-dev-server), the build fails with the following stack trace
TypeError: b.isAsync is not a function
    at processBlock (<project-path>/node_modules/webpack/lib/buildChunkGraph.js:412:10)
    at processQueue (<project-path>/node_modules/webpack/lib/buildChunkGraph.js:467:6)
    at visitModules (<project-path>/node_modules/webpack/lib/buildChunkGraph.js:761:3)
    at buildChunkGraph (<project-path>/node_modules/webpack/lib/buildChunkGraph.js:925:2)
    at Compilation.seal (<project-path>/webpack/lib/Compilation.js:1874:3)
    at <project-path>/webpack/lib/Compiler.js:972:20
    at <project-path>/node_modules/webpack/lib/Compilation.js:1709:4
    at eval (eval at create (<project-path>/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:45:1)
    at <project-path>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:284:11
    at <project-path>/node_modules/neo-async/async.js:2830:7
    at Object.each (<project-path>/node_modules/neo-async/async.js:2850:39)
    at <project-path>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:263:18
    at <project-path>/node_modules/neo-async/async.js:2830:7
    at Object.each (<project-path>/node_modules/neo-async/async.js:2850:39)
    at <project-path>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:41:16
    at Hook.eval [as callAsync] (eval at create (<project-path>/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:41:1)

This only happens when the shared option of the ModuleFederation plugin is a non empty array and the webpack version is at least 5.0.0-rc.0. This is also happening on the latest rc.4
The build runs successfully on version 5.0.0-beta.29.
If the shared option is an empty array, then also the build runs successfully.
Configuration for ModuleFederationPlugin:
{
    name: "shell",
    filename: "remoteEntry.js",

    remotes: {
      shell2: "shell2@http://localhost:3002/remoteEntry.js"
    },
    shared: ["react", "react-dom"]
  }

Rest of the configuration is same as the module federation examples repo
If the current behavior is a bug, please provide the steps to reproduce.

Upgrade the webpack version to 5.0.0-rc.4
Use the above given configuration.
Run webpack-dev-server
Build should fail

What is the expected behavior?
Build should not fail. The behavior should be the same as in previous beta versions.
Other relevant information:
webpack version:  5.0.0-rc.4
Node.js version:  12.18.3
Operating System: MacOS Catalina
Additional tools: yarn and lerna

webpack-dev-server is not supported module federation, but it should not failed with b.isAsync is not a function, please create reproducible test repo

Will do...I missed mentioning that webpack build fails even when it is started without the dev server

Could you validated that you are really the latest RC? Also check if there are not multiple webpack version installed: yarn why webpack
I'm asking because the b.isAsync line has been removed in this commit: https://github.com/webpack/webpack/commit/ed06a7f83a7cb7542ff7d9df9fa9755154679258#diff-fb5505dfa4e1d04d2eed8f03d4834740L427 since beta.30

Thanks it worked! 🎉
Was due to a version mismatch due to monorepo(multiple webpack versions were installed)


rust port of 95_weekday

finished the rust implementation of 95_weekday
all the features of the original basic, but I did use a different method of calculating the weekday, and changes some other bits of logic to be more intuitive

looks good thank you! 🤗


Consider changing from sphinx/read-the-docs to mkdocs/github-pages

For these reasons:

It is simpler to install and build (no makefile)
It uses markdown instead of rst
RTD is an external application that required an additional account. GitHub pages are built from the gh-pages branch.

Closing this issue as it will not be worked on. Sphinx/read-the-docs works fine.


Maintain consistency between ReactiveUIView's properties and its backing ReactiveCALayer's.

For example, if I write to a ReactiveUIView's backing ReactiveCALayer's position property the ReactiveUIView's center property should be updated as well (and vice versa).
A solution might be to use the layer's property directly if we can, and write a wrapper around it when it's not a 1:1 map:
public lazy var alpha: ReactiveProperty<CGFloat> = {
  return self.reactiveLayer.opacity
}()

public lazy var center: ReactiveProperty<CGPoint> = {
    let view = self.view
    let property = ReactiveProperty(initialValue: view.center,
                                    write: {
                                      // TODO: Adjust depending on anchor point
                                      self.reactiveLayer.position.value = $0
                                    }, coreAnimation: {event in
                                      self.reactiveLayer.position.coreAnimation(event) })
    let subscription = self.reactiveLayer.position.asStream().subscribe(next: { position in
      // TODO: Adjust depending on anchor point
      if position != property.value {
        property.value = position
      }
    }, state: { _ in }, coreAnimation: { _ in })
    self.subscriptions.append(subscription)
    return property
}()

For now I've simply removed the duplicated properties in order to minimize likelihood of overlap. We'll recommend animating the layer properties only.


Improve Server Side Rendering

The styled-components v2 announcement blogpost states:

When you server-side render an app with 💅 styled-components it will automatically only send the critical CSS down to the client.

I'm pretty sure that we don't actually do that right now. As soon as you say:
const Button = glamorous.button({ /* styles */})

Those styles get added to glamor... wait...
jkjk, we totally don't add them to glamor until rendering time. Just verified this with:
import React from 'react'
import ReactDOM from 'react-dom'
import {styleSheet} from 'glamor'
import glamorous from '../'

const Button = glamorous.button({marginLeft: 20})
console.log(styleSheet.inserted)
// -> {}
const x = <Button />
console.log(styleSheet.inserted)
// -> {}
ReactDOM.render(x, document.createElement('div'))
console.log(styleSheet.inserted)
// -> { '140tz9x': true }

So I think we're good. EXCEPT!
We could probably improve the experience a bit. If you look at the Next.js example for server side rendering here there's a bit of boilerplate, and the styled-components blogpost says:

On top of that we support concurrent server-side rendering to avoid blocking your process with every request and we automatically rehydrate your styles in the browser.

And further:

All it takes is four lines of code

Let's see if we can improve this experience a bit taking inspiration (again) from styled-components :)

I'd like to work on it (assuming this is still open).

Awesome! Yeah! Let me know what you're thinking for doing :)

Sure!

Possible solution :
Whenever an app is rendered on the server, we need to include the generated styles on the pages. This can be done by passing a component to a callback which will return html or array of React elements. Further, taking inspiration from styled-components, we could gather all the style tags and include the extracted css in the html  by creating an instance of ServerStyleSheet and pass array of React elements (return by the callback, eg - renderToStaticMarkup) to the body.

    {style_tags}

      {react_elements_to_be_render}

Let me know what you think (I am still not sure about this).

Thanks! I'm not certain I follow though... What would the API look like?

Ya I am working on an example and will upload soon. Just a question! When we use glamorous.div({...}), it will forward a className prop to the component we tell it to render. This is done by calling css() from glamor internally. Right ?
Because if we are calling css() internally, we could collect all the calls to it and this would be help in doing SSR (rehydration).

Yes, that's correct. That's how we accomplish it today (via glamor's APIs). Just looking for a simpler way to do it.

// Performing server side rendering

import { StyleSheetServer } from "glamorous";
import ReactDOMServer from "react-dom/server";
import AnyComponent from "./AnyComponent";

// Pass this callback, ReactDOMServer.renderToString(<AnyComponent />) to StyleSheetServer.renderStaticMarkup which will return the generated html.
// All of the calls to the css() (glamorous calls css() internally using glamor) will be collected which will return css.

/**

High level Picture -

renderStaticMarkup(fn) {
  return {
    html,
    css: {
      content: getContent(),
      renderedClassNames: getClassNames()
    }
  }
}

*/

let { html, css } = StyleSheetServer.renderStaticMarkup(
  ReactDOMServer.renderToString(<AnyComponent />)
);

// Base html file

return `

${html}

`;

This is the high level picture. Let me know if I am going in the right direction !

Further, we can optimize the renderStaticMarkup method to include only generated styles on the page (glamor's renderStatic includes all the css).

Cool! I like the direction. Could we accomplish the same API as styled-components?
import { renderToString } from 'react-dom/server'
import { ServerStyleSheet } from 'styled-components'

const sheet = new ServerStyleSheet()
const html = renderToString(sheet.collectStyles(<YourApp />))
const css = sheet.getStyleTags()

I think that's pretty simple...
Also, glamor has renderStaticOptimized which should do the heavy lifting for us 😀

Actually, now that I think more about it, I think I like this (similar to your solution) better:
let { html, css } = StyleSheetServer.extractCSS(
  () => ReactDOMServer.renderToString(<AnyComponent />)
);

It has to be a callback I think. Otherwise we don't know when to start/stop tracking calls to css right?

Yes! We can definitely abstract everything inside ServerStyleSheet and achieve same. Didn't knew about renderStaticOptimized 😅

extractCSS ? we need to extract both the html and string 😅 I think. Yes it has to be a callback!

Haha, yeah, good point!

So which API design should we use ?

let { html, css } = StyleSheetServer.renderStaticMarkup(
  () => ReactDOMServer.renderToString(<AnyComponent />)
);

This is good

Great! So I can start working on this I think !?

Go for it! Thanks!

This is going to actually just be a matter of documentation on the website. Not too much to improve beyond that.

I will start working soon on creating examples !!

I've created a gist explaining the process. Here - https://gist.github.com/nitin42/559fe988c59194357ce868416c390273

Oh, that's perfect. You could just stick that directly in here and that'd be awesome :clap:

Hmm... I tried to follow that guide:
My server.js looks a bit like this:
  const app = (
    <ApolloProvider client={client}>
      <Router context={{}} location={req.url}>
        <Pages />
      </Router>
    </ApolloProvider>
  )
  getDataFromTree(app)
    .then(() => {
      const content = renderStatic(() => ReactDOMServer.renderToString(app))
      console.log(Object.keys(content))
      console.log(content.css)
      ...

renderStatic does return my markup, and some divs have classes generated by glamor, but my return value content does not have anything in ids, and css.
Does anyone have a pointer what I might be missing here?

Try ReactDOMServer.renderToStaticMarkup   and let me know if this works!

@nitin42 just tried that, same result :(

Hmmm... It's working for me on my site: https://github.com/kentcdodds/kentcdodds.com
It's a bit hacky, but it's pretty raw so maybe that'll enlighten you :think:

@kentcdodds I ended up deleting my node_modules folder and trying again. It works now. Sorry for wasting everyone's time :(

No problem! That's great 😀


why use YUV instead of RGB

Can anyone tell me why not use RGB ?

Actually, I am curious about why you expand the one channel to 3 channels by filling them with the -512 or 128
what do the numbers mean?
and what does the 1st to 4th channels mean?

Y channel is black and white, so it has more clear relation with line drawing input channel. ( maybe
see also http://tinyclouds.org/colorize/

I got you. Thank you very much.


Backup/Restore does not include the secrets used for clientSecretName and helmSecretName in fleet gitrepos

SURE-3503
SURE-3531 - closed as duplicate
After a rancher restore in Rancher 2.5.9 the gitrepos defined in fleet do not work anymore as we have to use authentication against git and against the helm repo (harbor in our case) and the secrets  defined in clientSecretName and helmSecretName of the gitrepos defined are not backed up / restored.
Could we get the backup operator fixed in a way that it automatically creates a backup of these secrets in the fleet-default / fleet-local namespaces, too? (maybe also in other fleet namespaces if additional ones have been created)

@nickwsuse , Eli believes this is already fixed.

Could we retest this usecase with latest Rancher version and latest Backup-restore operator to see if the issue is still seen? There is a high chance that latest versions might have this resolved already

@eliyamlevy @prachidamle I'm not seeing the secrets I made before taking the backup after I deleted them and restored. The secrets I made are opaque, so not sure if there's an expected secret type for this to work, but I would assume it should keep all secrets in the namespaces regardless of type?
Steps:

Created a v2.7-head instance (Commit ID: 65089ee)
Created a downstream RKE1 and RKE2 cluster
Added an opaque secret with my S3 creds
Installed Rancher Backups v3.0.1-rc2 with my AWS S3 bucket info
Created a backup called "pre-fleet-secrets"
Created an opaque secret in the fleet-default namespace
Created an opaque secret in the fleet-local namespace
Created another backup called "post-fleet-secrets"
Deleted the secrets I made in both fleet namespaces
Created a restore using the "post-fleet-secrets" backup
Checked for the secrets I made that should have been restored

This test was a local restore, but I imagine we'd get the same results with a restore done in a migration as well.

@eliyamlevy , we checked with Ron and he said it would be ok to add this to the Q1 release.

Hello all,
The solution we came to was to create a resourceSelector which will look for any secret with a specific label to back it up. This selector will look in all namespaces and at every secret on the cluster. If the secret has the label resources.cattle.io/backup: true it will be backed up.
The reason for this approach is because these gitrepo secrets can be in any namespace and can have any name, which makes it difficult to identify them through the resource selectors unless they have some kind of standard identifier. This label will serve as that identifier to allow anyone to make sure any secret gets backed up.
The only caveat is to make sure to encrypt the backup if you are storing sensitive information, since the backup is in plain text unless encrypted. Encryption is already available through the Backup Restore Operator.
The way I tested this was to create many secrets with different names in different namespaces and added the resources.cattle.io/backup: true label to them. Then I took a backup, downloaded the backup tarball and checked if the secrets were there. Nick's steps are the perfect way to test as well, just have to add the label to the secret before backing up.

Verified on v2.7-head ID: 6316baf and Rancher Backups v3.0.1-rc3
I repeated the steps I mentioned in my earlier comment, this time adding the resources.cattle.io/backup label as noted in Eli's comment, and the secrets that I added that label to came back when restored. The secrets that didn't have the new label were still gone as expected.
I did both an encrypted and unencrypted backup/restore just to be sure both still work.


Ftr 001 adding prioritise pd tag

Similar to the "smallShips" tag except:

ignores the baseAI
allows for targetting missiles
Prioritises missiles over fighters

This results in groups using this tag consistently targetting PD over ships when both are in range

Also, I didn't put it under "pdTags" as it works with non PD weapons and checks for PD capability when assessing if a missile is a valid target

It's a bit of a clusterf*ck trying to add individual feature branches when my master repo has them all merged in whereas yours doesn't. I think I'll just have one big feature branch with all my changes and you can lemme know if you want anything removed. Everything will be disabled by default


check permission for list users

provide user list response based on user privileges

There are some linting errors in the pipeline:
src/contaxy/managers/project.py:220: error: Return type "List[UserPermission]" of "list_project_members" incompatible with return type "List[User]" in supertype "ProjectOperations"
src/contaxy/managers/project.py:298: error: Incompatible return value type (got "List[UserPermission]", expected "List[User]")
src/contaxy/managers/project.py:298: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/contaxy/managers/project.py:298: note: Consider using "Sequence" instead, which is covariant
src/contaxy/managers/project.py:312: error: Incompatible return value type (got "List[UserPermission]", expected "List[User]")
src/contaxy/managers/project.py:312: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/contaxy/managers/project.py:312: note: Consider using "Sequence" instead, which is covariant
src/contaxy/managers/auth.py:839: error: Argument 1 to "append" of "list" has incompatible type "UserRead"; expected "User"
Found 5 errors in 3 files (checked 78 source files)
Executing: pipenv run flake8 --show-source --statistics src
src/contaxy/api/endpoints/user.py:47:5: F841 local variable 'e' is assigned to but never used
    except Exception as e:
    ^
src/contaxy/api/endpoints/user.py:55:5: F841 local variable 'e' is assigned to but never used
    except Exception as e:
    ^
2     F841 local variable 'e' is assigned to but never used

You can run the linting step locally by executing python build.py --check in the backend folder.
The mypy errors are due to changes in the manager classes which are not reflected in the respective base interfaces.


image preview starts over if larger than 240 columns

When the option to preview while displaying on the LED's hits the 240th column the display starts over on the 1st column. It might be a nice option to allow it to scroll instead.

That could an interesting choice


Replace done w/ async part 4

Partial fix for #3226. This will be done in multiple PRs.
Covers
(Alphabetically such that botbuilder comes before botbuilder-)

botbuilder-dialogs

Excludes
None
Description
Replaces the use of done() in tests with proper async/await.
Specific Changes

done => async/await
Remove some of the try/catches that are no longer needed since we don't need done(err)
Avoid arrow function in mocha tests
A lot of no-op stuff auto-fixes with our prettier/eslint settings

Notes (mostly for me)

Regex for finding done usage: (done =>)|\(done\)
Search in: ./libraries/**/**/tests/**/*.js
For adding await to adapter.send() calls: (?<!(await)|(const))\sadapter

Pull Request Test Coverage Report for Build 681187667

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.009%) to 85.131%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build 680203276:
0.009%

Covered Lines:
18800

Relevant Lines:
21033

💛  - Coveralls


Yarn installation warning

yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

Closing for now, will raise if I see it again


Show total number of hits

Is it possible to get the total number of hits in trouble? I would like to show it in lualine when I send results from telescope. Would also be nice to display what item you are currently displaying out of the total

Development on the main branch is EOL.
Trouble has been rewritten and will be merged in main soon.
This issue/feature either no longer exists or has been implemented on dev.
For more info, see https://github.com/folke/trouble.nvim/tree/dev


Fix/fix statistic page

Statistic page

Modify the drop off chart to show no show and cancelled customers instead of removed and cancelled customers.
Change color of components in drop off chart.

General queue manage page

Fix that search button isn't in search input.

Added docstrings

Add docstrings in model files in manager app.
Add docstrings in view files in manager app.

Good fix man.

The changes to the chart and the search button fix look good. However, the tests are failing.

good job krub safe

The changes to the chart and the search button fix look good. However, the tests are failing.

I have fixed the test already, so it matches the function name in the queue model.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

manager/views/statistics_views.py
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag
Coverage Δ

unittests
73.95% <92.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

manager/models/categorized_queues.py
100.00% <ø> (ø)

manager/models/queue.py
77.65% <100.00%> (ø)

manager/models/resource.py
57.83% <ø> (ø)

manager/models/user_profile.py
90.62% <ø> (ø)

manager/tests/models/test_Queue.py
100.00% <100.00%> (ø)

manager/utils/category_handler.py
62.55% <ø> (ø)

manager/views/auth_views.py
72.72% <ø> (ø)

manager/views/participant_views.py
34.93% <ø> (ø)

manager/views/profile_views.py
79.31% <ø> (ø)

manager/views/queue_views.py
46.11% <ø> (ø)

... and 10 more


Line numbers

At the moment we store absolute offsets on every token and node location. This works well for things like formatters and linters, but not as much for line-based targets like compilers. In order to properly support compilation, we're going to need to know the line numbers of each node in the tree.
We will also need to know the line numbers for the __LINE__ syntax. When that node is found, we should store the actual value so that implementors don't need to figure it out themselves.
My proposed solution is to track the line number throughout parsing, attaching just the start line to each node in the tree. This should be sufficient for our purposes.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.

I'm closing this for now. We'll figure out the right solution in the compiler instead.


Improve naming of snapshot releases

Our current naming for the snapshot releases is a little misleading since they are based on the most recent tag due to the way git describe works, but that tag is typically on a different branch. As an example, a recent build was named snapshot 3.4-beta-482-gf74e3e0 despite that fact that it is really a 3.5 snapshot built off the master branch.
Proposed solution
Perhaps using the version from Maven's POM in conjunction with the date and/or git commit would make for a more relevant version that users could correlate with the code that it came from.

Yes, it was appropriate when we did not do release branches but now it's not ideal. It's just a matter of finding the version string that works for us in the git-commit-id-plugin.

This has been solved now that we are not using Github Releases to publish our snapshot releases, but Maven Central instead.


Pjax widget - submit by get

Code
The menu
Pjax::begin();
//A link here loads the form
Pjax::end();

The form
Pjax::begin();
$form = ActiveForm::begin(['method' => 'get', 'options' => ['data' => ['pjax' => 1]]]);
Pjax::end();

The problem
When you click in the link who has that form, Pjax widget executes this line.
Any other click in the menu link, returns the content of Pjax again, making another event on submit. Checking it on firebug gives an error which takes time.
The possible solution
Add at the beginning of that line this: jQuery(document).off('submit', $formSelector).on(...);
Perhaps this is specific or not (but this make possible multiple pjax widgets).

Seems to be fixed in upstream: https://github.com/defunkt/jquery-pjax/commit/6e2c7e5b123b2b3a0521d9cfda9ef802e20563ab

Failed to reproduce


os: error running API checker for linux-arm-arm5spacemonkey

Builds are failing for linux-arm-arm5spacemonkey after CL 155517 to add SyscallConn method.
Error:
##### API check
Error running API checker: exit status 1
Go version is "builder host-linux-armel-cross", ignoring -next /home/builder/stage0scratch/workdir/go/api/next.txt
+pkg os, method (*File) SyscallConn() (syscall.RawConn, error)
exit status 1
2018/12/27 22:34:01 Failed: exit status 1
2018/12/27 22:34:07 FAILED

Example: https://build.golang.org/log/8ccfa580e101f1c87b4f56c4b9ba77739bfecddc
/cc @ianlancetaylor

This is #24754 and #29177, I would close here if you don't mind.

Yep you're right, thanks. It appears to be a dupe of #24754

Actually, that issue is related but I don't think it is a duplicate. @bradfitz is working on a fix now.


Fix typo in Image doc

Hi @pranavek, Thank you for this contribution. Would you be able to rebase this pr onto main before I merge it?


Disable mouse action override

I would love to be able to use a browser extension like DeepL, instead of opening a separate window for translation - it is soooo much sloooower :(
Unfortunately, at the moment all actions related to selecting text or clicking on a word are taken over by Lute.
Would it be possible to turn Lute's mouse actions on and off under some keyboard shortcut? Or even better as long as some key combination is pressed, e.g. alt+shift disable all Lute's actions hooked up to the mouse?

I found a workaround, but it is not pretty:
`  let style = document.createElement('style');
style.innerHTML = '*{ user-select: auto !important; }';
document.body.appendChild(style);`

Yes I agree the popup is slow!
if we disable all mouse things, then some functions may not work; I’m not sure which ones are required va optional.  Can you clarify which things you don’t want to happen?

This script that I pasted earlier works for me - you may check DeepL for Chrome with and without applying this script.
Basically, allowing text selection seems to have solved my problem - but I'm not a front-end developer and, as I said, it's not a very pretty solution because the text underneath is also selected by the Lute.

Thanks will do!
On Mon, Jan 15, 2024 at 2:30 AM PsychoThinker @.***>
wrote:

This script that I pasted earlier works for me - you may check DeepL for
Chrome https://www.deepl.com/en/chrome-extension with and without
applying this script.
Basically, allowing text selection seems to have solved my problem - but
I'm not a front-end developer and, as I said, it's not a very pretty
solution because the text underneath is also selected by the Lute.
—
Reply to this email directly, view it on GitHub
https://github.com/jzohrab/lute-v3/issues/130#issuecomment-1891049628,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMPWDLHNDESLII2QOOX2TDYOQW6LAVCNFSM6AAAAABB2E2ZP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGA2DSNRSHA
.
You are receiving this because you commented.Message ID:
@.***>


Safari "Failed to load resource: The network connection was lost."

For some reason Glide isn't working anymore on my Safari v9.1.1 (11601.6.17) on OS X 10.11.5 (15F34).
It gives in the Console: Failed to load resource: The network connection was lost.
But when I hit the URL manually, for just the image (https://website.com/img/photos/_11_241077-t3-211jpg_56b35a201ee7d?w=354&h=274&fit=crop) it works, but not on a webpage with multiple Glide requests to images.
I found this:

Chrome & Firefox just display whatever content was received & don't worry about the mismatch in content length. Safari, starting with Safari 7.0 on Mavericks' 10.9 is stricter about the response & treats the mismatch as a "Failure to load resource" error. (If I had to guess they're probably trying to improve the speed so don't retry the resource and so don't get the file fully retrieved response that wget does). (http://apple.stackexchange.com/questions/106550/safari-7-0-cannot-load-localhost)

Has that to do with it?
I'm on Glide v0.3.6, using Laravel-Glide's package.

Hi,
Any news about this problem please ?
Thanks for your replies

Does this problem still exist? It seems related to a mime type problem.

Does this problem still exist? It seems related to a mime type problem.

Given how old this ticket is I am going to assume this issue is resolved :)


Code organization cleanup

Psuedo Code
This section describes what happens and then maps the concept to actual code entry point
Generating the Cargo.nix
main.rs

Use cargo lib to get toml & lock information (doesn't get .cargo/config.toml info yet #181 )
Walk down the dependency DAG marking any explicit dependencies required and recording where any top-level workspace crate or feature activates features / dependencies farther down the DAG
make a BuildPlan and generate some expressions that are rendered in the Cargo.nix.tera template

Consuming the Cargo.nix

nixpkgs instantiated with the combined cargo2nix overlay (see older version 0.10.0 for separate overlay style)
this adds rustBuilder
pass your Cargo.nix into makePackageSet' as the packageFun.  It will be called later with some of the arguments you pass into makePackageSet

makePackagSet'

In user-facing.nix build (or accept) a rustToolchain using rust-overlay

Pass this into the internal.nix (note the call inside the call with buildPackages for the buildPlatform)

Inside internal.nix, the overrides get applied to each rust crate as necessary

The nix magic splice happens via lib/splice.nix so that our lazily recursive DAG can be assembled

The final derivations for each dependency result from calls to mkCrate.nix

A lot of the bash for mkCrate.nix is found in overlay/mkcrate-utils.sh

A package set can be used to

create a shell
expose a bin crate in a flake output  (Note, these are functions like rustPkgs.workspace.cargo2nix {} and can be called to obtain a derivation with a different profile etc, see arguments in mkCrate.nix)
make an output that runs unit tests in the sandbox

Building Each Derivation

The derivations are fairly usual, unpackPhase configurePhase buildPhase installPhase
The source Cargo.toml etc are moved out of the way and replaced with synthetic ones because we intend to control almost every aspect of linkage and features through flags or synthetic configs
Before the actual build command, cargo is configured by reading inputs from dependencies (that were recorded and passed up through the DAG, see mkcrate-utils.sh for these pre and post functions)
After the build, a new set of rlib link flags and other info is generated from cargo metadata and dependency info to continue passing up the DAG so that successive crates can find all of their information
bin crates copy a smaller set of outputs to a bin attribute avoid polluting nix profiles

TODO Fix up
This section catalogues where the entry points and flow control in the above aren't well semantically arranged.

[x] ~user-facing.nix calls internal.nix.  makePackageSet' is within user-facing.nix.  Simplified is not a simpler version of internal.nix.  It's some kind of shim or trampoline structure.  internal.nix "ties the knot" or whatever we say in Nix lang.~
[x] ~mkcrate-utils.sh is all related to making crates~
[ ] rust-triple.nix needs to be deprecated for the nixpkgs function, possibly offloading to rust-overlay if that package chooses to override this function (which is said to fall behind sometimes)
[ ] pkg vs root_pkg semantics.  Always use root_pkg for functions only called with a root_pkg
[x] ~makePackageSet' quoted symbol should not be public facing~

TODO Not documented
Describe role and point in flow control for each

[ ] profiles.nix
[ ] fetch.nix

Respond to this issue with any architecture questions and I will attempt to clarify how things work and possibly decide to make some changes

PR to fix nixpkgs treatment of wasi platform is one to watch.
See unstable version here:
https://github.com/NixOS/nixpkgs/blob/nixpkgs-unstable/pkgs/build-support/rust/lib/default.nix
Issue that brought the Rust triple treatment to light
https://github.com/oxalica/rust-overlay/issues/57

mkRustCrate arguments need to be gathered into one attrSet.  The bloated signatures are annoying and require updating for the same structure over and over.


Run this without device

Hi, can i run this program without any device ? Maybe like using emulator ?

I do, I run 3 Memus at the same time - no issues.

Yes, it definitely can. Just follow the instructions to turn on developer mode/usb debugging for your favorite emulator. Feel free to join the discord if you need help with setting it up and one of the community members may be willing to assist.


Detect gapped sections

I would like to a validator to detect gapped sections. The following is the sample of gapped sections.
Chapter 1
Section 1.0.1

In the above example, Section 1.1 should be exist before Section 1.0.1.

I'll take it.


xWaitForCluster: Enabled localization

Pull Request (PR) description

Changes to xWaitForCluster

Enabled localization for all strings (issue #88).

This Pull Request (PR) fixes the following issues:
Fixes #88
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

This change is

@johlju,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #139 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #139   +/-   ##
===================================
  Coverage   100%   100%
===================================
  Files         7      7
  Lines       395    399    +4
===================================
+ Hits        395    399    +4

@PlagueHO Do you mind reviewing this one too whenever you got a chance?

Can do! Getting it done now!

Can't find a single problem.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Differentiate between RAM Slack and File Slack

RAM Slack is defined as the slack space in the last written sector of a file, while file slack is defined as the unwritten sectors left in a cluster.

Not sure if these should be implemented as unique cmdlets or as options on Get-FileSlack.

Example, if a NTFS volume has a cluster size of 4096 bytes then all files allocate bytes in 4096 byte chunks. So if a file contains 100 bytes of content, then 4096 bytes will be allocated. In general, Slack Space is the 3996 bytes that are allocated, but not used by the file system.
When differentiating between RAM slack space and file slack space one must consider the size of a sector. Disks must be written to in sector size chunks (typically 512 bytes). RAM slack space is the sectors unused area, so in our example the final 412 bytes of the file's first sector make up the RAM slack. The remaining seven sectors (bytes 512 - 4096) are considered file slack.


[#115258555] Use the latest spruce 1.1.2 from release

What?
We have been using the version 0.13.0 of spruce, but compiling it
in the Dockerfile because the release binary version did link to
the debian/ubuntu libc. We were not pinning the git commit of the
spruce code.
But the upstream project has some changes that makes fail the build,
probably new dependencies added which require the use of godep.
As since https://github.com/geofffranks/spruce/issues/83 the binary
in the releases is OK and can work in a plain alpine, we can create
a container pulling the binary release. This will simplify our
container, make it smaller and pin the version number.
How to test this?
Travis should run OK and you can run the tests with:
rake build:spruce spec:spruce

who?
anyone but @keymon or @henrytk

Have you reviewed the CHANELOG for versions 0.13.0...1.1.2 to check any backwards incompatible issues? Have you tested the alphagov/paas-cf tests or pipelines to see whether it still works for our use?

I'd note that there are releases available for eariler versions as well.  eg 0.13.0 is available here - https://github.com/geofffranks/spruce/releases/tag/v0.13.0 albeit, this is zipped, and would therefore need unzipping.

I'd note that there are releases available for eariler versions as well. eg 0.13.0 is available here - https://github.com/geofffranks/spruce/releases/tag/v0.13.0 albeit, this is zipped, and would therefore need unzipping.

:+1:
I'm not against upgrading. But for the purpose of unblocking our build and board, it's probably safer to use the same version.

Ok, I will close this one. :)


Remove deprecated cli-credentials and console-url secrets

Signed-off-by: Ben Ye<EMAIL_ADDRESS>The two secrets are going to be removed in aws-account-operator, so it is not needed to have them.

/lgtm
/hold until we roll out aws-account-operator/408

Looks like there's a lint error.

Looks like there's a lint error.

Yes, I just pushed a fix. Let's see if CI is happy this time :)

Merge when we promote aws-account-operator PR #408 to prod

@yeya24 @iamkirkbater @rogbas Can we move forward with this?

Is there anything need to do on my side? I guess if aao pr is merged, then this should be good to go.

/lgtm
/hold cancel
aws-account-operator/pulls/408 was merged to prod 21 days ago and this should be good to go.

/lgtm
/approve


[NEW] added code for download my data functionality

@RocketChat/android

Closes #ISSUE_NUMBER

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ShafiSingla1989 you should update your PR description to reference the issue, which is https://github.com/RocketChat/Rocket.Chat.Android/issues/1847.

Hi have resolved the conflicts

I have resolved the conflict.
On Fri 30 Nov, 2018, 4:57 PM Rafael Kellermann Streit <
<EMAIL_ADDRESS>wrote:

@ShafiSingla1989 https://github.com/ShafiSingla1989 Can you please take
a look on the conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Android/pull/1871#issuecomment-443175739,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeAsOdGCqe5SVKZ79cgEurV9IBv9iM6Iks5u0RYxgaJpZM4Yx-8S
.


Stop list diagram changes with new directionality interface

Summary of changes
Asana Ticket: React wrapper for existing line diagram and remove flag
Here we hook up the old static-HTML stop line diagram to the newfangled directionality interface, allowing us to get rid of the flag gating the new interface off and cut over to it permanently.

Assigned to: @meagonqz

Closing this, it would possibly take longer to resolve the conflicts than it would to write and deploy the stuff that's supposed to replace this.


client with access token/refresh token -- is it implemented?

I need to create an OAuth2 client that uses access token and refresh token to frequently downloads data from the server.

The server is 3d party service I have no control over
authentication has already be done and I am handed the access token and refresh token
with those two I need to collect once a day data, hence refresh the token every 24hrs, store and use it for my requests

After several days I am no longer sure this is possible with spring security oauth2 -- documentation is rather confusing and all examples, be it with Spring or elsewhere concentrate on a server (which I don't need) or stop with authorization/password login.
So, is my scenario at all possible with this project or do I need to do everything on my own?
If this is, in fact, answered somewhere, could you please point me to that?
If, as I suspect, this neither possible nor has been stated somewhere, please, add clear information about that in the docs.

Hi, @2019-05-10, thanks for reaching out.
I'd recommend that you take a look at Spring Security's built-in OAuth 2.0 Client support. There, you'll find WebClient support that will perform the refresh token update for you.


Lf add puzzle 4x4

4 by 4 grid of words to group in categories

(lf-add-puzzle-labelthemap contains this puzzle too, you can review that one if you want to look at all the puzzles at once)


Is it possible to use mongo-connector with an existing elasticsearch index?

I created an index template and loaded it in elasticsearch.
Following is the template:
The data that I am using the test data provided my mongo.
I start a replica set of a mongodb instance by mongod --replSet someReplica and do rs.initiate().
Then I start the mongo-connector using
sudo mongo-connector -m localhost:27017 -t http://localhost:9200 -o /opt/mongo-connector.oplog -d new_doc_manager -n test.dataset

where localhost:9200 is running Elasticsearch 2.2.0.
Earlier when I used to import data in mongo using:
mongoimport --db test --collection dataset --file dataset.json

an index named test with document type dataset was created which had the following settings:
{
  "test" : {
    "mappings" : {
      "dataset" : {
        "properties" : {
          "address" : {
            "properties" : {
              "building" : {
                "type" : "string"
              },
              "coord" : {
                "type" : "double"
              },
              "street" : {
                "type" : "string"
              },
              "zipcode" : {
                "type" : "string"
              }
            }
          },
          "borough" : {
            "type" : "string"
          },
          "cuisine" : {
            "type" : "string"
          },
          "grades" : {
            "properties" : {
              "date" : {
                "properties" : {
                  "expiry_date" : {
                    "type" : "long"
                  }
                }
              },
              "grade" : {
                "type" : "string"
              },
              "score" : {
                "type" : "long"
              }
            }
          },
          "name" : {
            "type" : "string"
          },
          "restaurant_id" : {
            "type" : "string"
          }
        }
      }
    },
    "settings" : {
      "index" : {
        "number_of_shards" : "5",
        "number_of_replicas" : "1"
      }
    }
  }
}

As you can see this is all default and I do not want this type of settings.
So I created a template for such indexes:
{
  "template": "te*",
  "order": 1,
  "settings": {
    "index": {
      "number_of_shards": 6,
      "number_of_replicas": 1,
      "similarity.default.type": "BM25",
      "analysis": {
        "analyzer": {
          "custom_text": {
            "type": "custom",
            "char_filter": ["html_strip", "quotes"],
            "tokenizer": "standard_custom",
            "filter": ["custom_text_word_delimiter", "lowercase", "stop"]
          }
        },
        "filter": {
          "custom_text_word_delimiter": {
            "type": "word_delimiter",
            "generate_word_parts": "true",
            "split_on_case_change": "true",
            "preserve_original": "true"
          }
        }
      }
    }
  },
  "mappings" : {
      "dataset" : {
        "properties" : {
          "address" : {
            "properties" : {
              "building" : {"type" : "string", "index" : "not_analyzed", "store": true},
              "coord" : {"type" : "double", "index" : "not_analyzed", "store": true},
              "street" : {"type" : "string", "index" : "not_analyzed", "store": true},
              "zipcode" : {"type" : "string", "index" : "not_analyzed", "store": true}
            }
          },
          "borough" : {"type" : "string", "index" : "not_analyzed", "store": true},
          "cuisine" : {"type" : "string", "index" : "not_analyzed", "store": true},
          "grades" : {
            "properties" : {
              "date" : {
                "properties" : {
                  "expiry_date" : {"type" : "date", "format" : "yyyy-MM-dd'T'HH:mm:ssZ", "store": true}
                }
              },
              "grade" : {"type" : "string", "index" : "not_analyzed", "store": true},
              "score" : {"type" : "long", "index" : "not_analyzed", "store": true}
            }
          },
          "name" : {"type" : "string", "index" : "custom_text_word_delimiter", "store": true},
          "restaurant_id" : {"type" : "string", "index" : "not_analyzed"}
        }
      }
    }
  }
}

after that I deleted the test database and index. Then I again ran the followin commands:
sudo mongo-connector -m localhost:27017 -t http://localhost:9200 -o /opt/mongo-connector.oplog -d new_doc_manager -n test.dataset
mongoimport --db test --collection dataset --file dataset.json

The database test was made but running curl localhost:9200/test?pretty=1 gives:
{
  "error" : {
    "root_cause" : [ {
      "type" : "index_not_found_exception",
      "reason" : "no such index",
      "resource.type" : "index_or_alias",
      "resource.id" : "test",
      "index" : "test"
    } ],
    "type" : "index_not_found_exception",
    "reason" : "no such index",
    "resource.type" : "index_or_alias",
    "resource.id" : "test",
    "index" : "test"
  },
  "status" : 404
}

How should I make this work?
I don't want the default settings/mappings!

Hello! At first glance it looks like you are using the old elastic doc manager which only supports elastic 1.x with elastic 2.2.  It's quite possible that it's unrelated, but just in case you should run with the correct doc manager and let me know what changes. Thanks!

@apanimesh061 any progress?

@artursmolarek @redox
I tried and was partially successull in getting what I wanted.
I have updated a gist for reference.

The gist is very helpful, thank you @apanimesh061!

We've been looking through the gist and while I don't know if it is possible to do exactly what you're asking, I can try to provide some insight into what you tried.
The Elastic documentation for index templates doesn't say anything about automatically creating an index when you create the template: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-templates.html.
It makes sense that you got a "index_not_found_exception" after you deleted the index. Perhaps you should try starting Mongo-Connector from scratch after creating the index templates, in case that index is cached somewhere in the elastic-python driver where it's trying to be accessed after the index was deleted.
Lastly, I'm not sure what you mean by "unstable". Could you be more specific?
Thank you!

@apanimesh061 Any updates for this?

@aherlihy Sorry for the late reply.
You might be right. I looked more into the problem that I had to solve. Ultimately I had to only use the mongo-connector with a single index which works correctly. I am able to work with existing indices and also templates.


Java solution to Remove Nth Node From End of List problem from LeetCode

Added a solution to Remove Nth Node From End of List problem from LeetCode in Java.

Thanks!!


feat(node): Add baseRetryTimeout option

Summary

Adds baseRetryTimeout to options

Replaces BASE_RETRY_TIMEOUT constant

Replace bit shifting with currentRetryTimeout

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:   NO

How do you feel about an option that gives more control over the behavior but might be harder to understand? e.g.
timeoutConfig = [100, 100, 200, 200, 800] to wait 100 ms after the first and second errors, 200 after the third and fourth, etc.
the motivation is cuz as the # of retries increase in our current logic there's an exponential delay between retries and this can cause the process to hang if it gets to the end of the while loop

We can do that, the current default options is 10.
Thoughts on setting the default timeoutConfig = [100, 100, 200, 200, 400, 400, 800, 800, 1000, 1000] to emulate?

I think so! I was thinking about if we want to decouple the max # of retries and the timeout timings, or if they should be one and the same.
one path we could take is that the max retries dictates how many times to try and the timeout config dictates how long to wait after each failed try (with some default if we reach the end of the array). Which would be easier to reason about for users but would be more to configure.
another option is to have only one option timeoutConfig where we retry until we reach the end of the array. Which would be more compact but harder to explain. Thoughts?

one path we could take is that the max retries dictates how many times to try and the timeout config dictates how long to wait after each failed try

Does this involve maxRetries: number and timeoutConfig: number? How/would users still granulate changes in wait times after multiple failures?

another option is to have only one option timeoutConfig where we retry until we reach the end of the array. Which would be more compact but harder to explain. Thoughts?

I think one option timeoutConfig: number[] may be be harder to understand, but we could explain it in the typescript docs

Does this involve maxRetries: number and timeoutConfig: number? How/would users still granulate changes in wait times after multiple failures?

I think in both cases timeoutConfig exists as an Array<number> but in the first case the # of retries is tied to maxRetries and not the length of the array.

I think in both cases timeoutConfig exists as an Array but in the first case the # of retries is tied to maxRetries and not the length of the array.

In this case, how would we handle timeoutConfig.length and maxRetries not being the same number?

the case we'd have to worry about is if maxRetries > timeoutConfig.length - we could default to our own value or the last element in the timeoutConfig.
I think both approaches have their own confusions - if we only have a timeoutConfig, I would expect to do timeoutConfig.length + 1 tries (1 after the last wait) - then does passing in [] mean no retries or retry once? Does this mean we should also timeoutConfig to be set to null to explicitly stop retries?
If we have both maxRetries and timeoutConfig, it's easier to configure but also means knowing two options and their interactions.

All good things to consider!

I would expect to do timeoutConfig.length + 1 tries (1 after the last wait)

Could you explain on how retries === timeoutConfig.length + 1, I'm confused 😅. My current understanding in this case would be that the # retries is directly equal to the array length
E.g.
If timeoutConfig === [], then 0 retries
If timeoutConfig === [100], then 1 retry
If timeoutConfig === [100,200] then 2 retries.

reiterating from a DM: The current method that we use "retries" is like so:
try 1 -> wait time 1 -> try 2 -> wait time 2 -> ... -> wait time n -> try n + 1
which would be n+1 tries. Ideally we should rework it to be like:
wait time 1 -> try -> ... -> wait time n -> try n
Especially since the first "try" otherwise happens right after the first failed send. Thanks again @jooohhn for challenging an assumption I made 🤦


Change Discord icon color

Change to discord's actual color

changed in https://github.com/inttter/md-buttons/commit/0ab4dd9cfdee5088bd302cce4d49e27b929a969e


Updating docstings in utilities

Updating docstrings on utility packages
@baskaryan

Ready for review @baskaryan

awesome, thanks @Gordon-BP!


Slideshow Being Processed as Video

During the testing phase, it was observed that slideshows were, from time to time, mistakenly processed as videos, thereby causing the resulting sources to be linked to the slideshow's soundtrack. This is an issue that occurs on SnapTik's end.
Detection logic for this will not be implemented to allow exploitation of this bug (...where the goal is to download the soundtrack of a slideshow). Those who seek for a fix can simply identify a misprocessed slideshow when data.sources[0].endsWith('.mp3')

Closing due to an unplanned fix for this issue.


Update some changelists for releasing 0.13.0

Coverage increased (+0.01%) to 67.71% when pulling 3bb3d03f0a3c89de9691c0c14e3a6014b0b94e1f on changeLis into 08c46e3a2a45e1190d57ac151c6bdcb89a7b0107 on master.


fix: remove API secrets from web3.py loggers [APE-1486]

What I did
we did good at sanitizing secrets everywhere in our own logs, however they were still in the web3.py loggers.
This PR add some detection + handling of URLs in ALL loggers from Ape and will automatically clear them.
Now, the logs show:
DEBUG: Making request HTTP. URI: https://eth-goerli.g.alchemy.com/[hidden] Method: eth_chainId

instead of the alchemy API key
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

ugh still not liking this, going to try something else...


Fix issues with the Protobuf.js test runner

This change fixes two different issues that cause spurious test failures in the conformance test runner for Protobuf.js:

When serializing output for the PROTOBUF output format, the code fails to call .finish(). The resulting object is not handled correctly when serializing the final result message for output, which causes that output to be omitted for many if not all tests with that output format.
When serializing output for the JSON output format, two options can be passed to toObject to make the output more conformant to the JSON representation spec.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It's signed. I just had to check that it was OK first.


acbuild run: readlink /etc/localtime: invalid argument

Hi,
I try to build the nginx example but script fails. Unsure if it's really an issue of acbuild or related to the alpine base image...
vm@ubuntu:~/acbuild/examples/nginx$ acbuild version
acbuild version v0.2.1-6-gbb2640c
appc version 0.7.1+git

vm@ubuntu:~/acbuild/examples/nginx$ sudo sh -x build-nginx.sh
+ set -e
+ [  -ne 0 ]
build-nginx.sh: 4: [: Illegal number:
+ acbuild --debug begin
Beginning build with an empty ACI
+ trap acbuildEnd EXIT
+ acbuild --debug set-name example.com/nginx
Setting name of ACI to example.com/nginx
+ acbuild --debug dep add quay.io/coreos/alpine-sh
Adding dependency "quay.io/coreos/alpine-sh"
+ acbuild --debug run apk update
Running: [apk update]
Downloading quay.io/coreos/alpine-sh: [========================] 2.65 MB/2.65 MB
run: readlink /etc/localtime: invalid argument
+ acbuildEnd
+ export EXIT=1
+ acbuild --debug end
Ending the build
+ exit 1

I can replicate this issue on Ubuntu but not on CoreOS; on CoreOS the nginx example builds fine.

I think the problem is that /etc/localtime is not a symlink on Ubuntu:
vm@ubuntu:/tmp$ ls -l /etc/localtime
-rw-r--r-- 1 root root 2335 Oct 23 17:15 /etc/localtime
vm@ubuntu:/tmp$ readlink /etc/localtime
vm@ubuntu:/tmp$

It would be nice to now what's the result of these commands on your CoreOS installation.

CoreOS stable (835.7.0)
$ readlink /etc/localtime
../usr/share/zoneinfo/UTC

The feature seems to be new:
https://github.com/appc/acbuild/commit/615e5cae57e0b0bcebf4498a4c561770f89bc16f

I'm perplexed as to why this has never bitten us in rkt, since it follows basically the same codepath..

I'm perplexed as to why this has never bitten us in rkt, since it follows basically the same codepath..

Because in rkt we ignore errors

I tried #134. It resolves the problem.

This may also be fixed by #147.

Should be fixed by #147. Someone complain if that's not the case.


[Discussion] Interested in your improvements from fork

Hi @ubuntor,
I noticed some interesting improvements in your fork of this project.
Specifically, your changes in commits 07ca17a & 85c755f seem to improve support for feeds that include footnotes and embed YouTube and Vimeo video iframes, which I believe would be a valuable addition to the main project.
Would you be interested in contributing these changes back to the main repository?
If you’re open to contributing, you could:

Create a pull request with the mentioned commits
Or let me know if you'd prefer I cherry-pick specific changes

Looking forward to your response!
Best regards

Sure! I've cleaned up the commits and opened #122.

Thanks for opening PR #122!
The updates look solid, and I appreciate the cleanup you did on the commits.
I’ll go ahead and get this merged.
Feel free to keep the ideas coming—any future tweaks that make this project even better are always welcome!


Remove Deprecated Methods for 4.0 release

We've deprecated various Storybook methods over the course of the 3.x releases, and we should remove these as part of the 4.0 release to simplify the code, and update MIGRATION.md accordingly.

[x] addon-info addWithInfo
[ ] addon-knobs withKnobs, withKnobsOptions, selectV2
[ ] addon-events WithEvents
[ ] addon-backgrounds framework-specific imports
[x] built-in linkTo / action in react-native.

addon-knobs withKnobs, withKnobsOptions, selectV2
addon-events WithEvents
addon-backgrounds framework-specific imports

these all are new deprecations

A good way to check which deprecations was introduced in 3.x is searching them on release/3.4 branch

There are also deprecations in addon-storyshots. Will remove them soon.


PoolStats methods are protected - hard to build custom MetricTracker

The introduction of the new MetricsTrackerFactory property seems to allow us to register custom implementation of MetricsTracker (other than the one provided for Codahale metrics).
Valuable metric information like total connections, idle connections, active connections, etc are made available through an instance of PoolStats. Unfortunately, the corresponding getter methods are all marked protected and are therefore not available to any MetricTracker implementation not in the Hikari packages...
Is it intended?
If so, how are we supposed to implement a custom metric tracker?

Any thoughts on this? Maybe PoolStats is not intended to be used by external code...

@brenuart So far I think you are the one of the only ones using a custom MetricsTracker.  I wanted to give you a heads up that the MetricsTracker class is going to be @Deprecated and eventually removed and replaced by an IMetricsTracker  interface.

Ohh... Ok, thanks for the warning. As long as IMetricsTracker provides the same functionality I should be good.
Is that new interface already available? Do you want me to have a look before you release a new version?

Just committed.  Currently only applicable to Java 8.  The IMetricsTracker interface has the same signature as MetricsTracker and default methods.


Adds installation of DC/OS build specific python-gdb.py file

High Level Description
With this change our DC/OS installations will include the python build specific gdb helper script python-gdb.py. This will allow us to interact and debug python based components of DC/OS.
Most Linux distributions bundle this file in a dedicated python-dbg (or similar) package, so it is understandable that it is not part of what make install installs into $prefix. As we do however bundle our own build of python and do not currently provide a debug build and or additional debug package, there is no usable python-gdb.py file available.
Please note that the path the file usually goes to is somewhere in '/usr/share/gdb/[...]', so I decided to put in in $PKG_PATH/share/ as well, although the gdb autoloader wont pick it up automatically from there. This seems to be the most sane solution here, without cluttering bin/.
Related Issues

SOAK-22 Debugging DC/OS components that use our bundled python interpreter

Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
I am not sure how infrastructural changes like this should be tested. If we do have a test framework for things like this, please point me in the right direction and I will make sure to add a test case!

@mesosphere-mergebot label Ready For Review

cc @lava could you please review?

@mesosphere-mergebot bump-ee

cc @jgehrcke what do you think of this? I saw your other PR concerning the python 3.5 to 3.6 update, so you seem to be the right person to ask.

From https://docs.python.org/devguide/gdb.html:
**To activate support, you must add the directory containing python-gdb.py to GDB’s “auto-load-safe-path”. Put this in your ~/.gdbinit file:

add-auto-load-safe-path /path/to/checkout**

You're saying yourself that

although the gdb autoloader wont pick it up automatically from there

So, how do you actually use it? I'd love to see that in this PR.

@jgehrcke
It can still be manually loaded from within gdb, e.g.:
(gdb) source /opt/mesosphere/share/gdb/python-gdb.py

When you get tired of doing so, it's possible add the appropriate auto-load settings (https://sourceware.org/gdb/onlinedocs/gdb/Auto_002dloading.html) to the .gdbinit file in either your home directory or the current working directory, as the python documentation suggests.

So, how do you actually use it? I'd love to see that in this PR.

One way I was playing around with is to put it along side the actual python binary in bin/, where GDB then proceeds to detect but refuses to auto-load it because thats also an unsafe path.
The usual way to manually load gdb helper scripts is to source them from within the gdb shell, so thats what I have been doing here:
(gdb) source /opt/mesosphere/active/python/share/python-gdb.py

 mesosphere-mergebot added Ship It and removed Ready For Review labels 16 hours ago

That was premature. Tracked internally via DCOS-19252. Removing manually.

Kind of lost track of whats the state with this PR. Is further work from my side required, @jgehrcke? Or how do we push it along?

@mesosphere-mergebot label Ready For Review

@MrMarvin  - I am fine with this change. +1
Although, I wonder how you are using python-gdb.py (/gdb) for debugging some of our services / packages. Curious on where you found this useful.

Keeping this within $PKG_PATH under /share is fine. @lava idea of keeping this in $PKG_PATH/share/gdb seems better to me.

@mesosphere-mergebot bump-ee

@MrMarvin this needed another bump-ee after your latest changes.

@MrMarvin if you want to land that you need to push this PR forward ... :-).

@jgehrcke It seems like you need to change your review to "approved"  before it can be landed?

The downstream PR https://github.com/mesosphere/dcos-enterprise/pull/1591 needs to also have reviews. Heavy-weight process, yes.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label  ship-it

Overriding this with a ship-it label, so that we can include in the next master train. Unfortunately, this has escaped our attention for long time and I think, we should move-forward instead of revising this again.


Access value of object by key expression

Kinda important.
I'd like this:
o:k
o:k > v;

But the problem with that is the ambiguity when you have multiple :ks..
o:k1:k2

Is that "k2 of (k1 of o)" or is that "(k2 of k1) of o"?
Probably the easiest thing to do is make the syntax like this instead:
o:[k1]:[k2]
o:[k1:[k2]]

If we do that we don't even need the colon any more:
o[k1][k2]
o[k1[k2]]

Aaaaand now we're copying JavaScript again! :tada:

Eh, just copy JS. :package: Easiest way to do it.

If we copy js, we could make the interpreter very small and lightweight!
eval("<tulun here>")

If people want to do the JS expression foo[bar[baz]], then they should do bap => bar:baz; foo:bap in Tulun. We don't want to copy JavaScript yet again...

The thing is, o[k1[k2]] makes more sense.. plus it doesn't need an extra variable. Which is better?
o[k1[k2]]
# or #
k_ => k1:k2;
o[k_];

Suppose I want to access o[k1[k2]] in an expression? I can't define variables in an expression! I'd need to do something like this:
print({ k_ => k1:k2; return(o[k_]); }()); # inline function evaluation #

Does that really seem any better than this..?
print(o[k1[k2]]);

Hm... ooh, maybe offer both styles? We may as well :package:

Hm... ooh, maybe offer both styles? We may as well :package:

I'm only really interested in including good features, and I don't see how you can consider this good.. :P
print({ k_ => k1:k2; return(o:k_); }());

I dunno, it's just that copying js seems like cheating

Perhaps looking at how other languages work with object-access-by-keys might inspire us?

...well then. I guess obj[key] it is :|
We should probably make the syntax less javascripty, tho

Racket and Java each have their own functions, e.g.
my-hash-map => make-hash-map()
my-hash-map.set('bar', 'baz')
my-hash-map.get('bar')

We should probably make the syntax less javascripty, tho

+1 this. Any ideas on how to make it less JS-y? So far the best I think I've done is #34 :P

How about this?
foo => obj();
foo.bar -> obj(
  'hi', 'Hello there!' # this needs to be implemented soon! #
);
foo:'baz': -> 'bar';
foo:('b' concat 'ar'):.hi # Hello there! #

# : is equivalent to [ and ], basically #


Fix unused lint warnings in hashes rustdocs

Draft because on top of #3410
The example code in hashes/src/lib.rs was not linted because of an incorrectly applied feature gate.  Now that this is fixed in #3410 the example code causes warnings for unused code.
Unused variables and functions have been prefixed with_ and mut removed from the variables that do not need to be mutable.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.85%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
19005

Relevant Lines:
22939

💛  - Coveralls

Closed because changes here have been added to #3410


Add installation instructions for Windows via Scoop

I think it'd be helpful for Windows folks to know that lsd is available on scoop as well.

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   66.08%   66.08%
=======================================
  Files          19       19
  Lines        1834     1834
=======================================
  Hits         1212     1212
  Misses        622      622

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff08f44...031d961. Read the comment docs.


Angular 14 ut could not run correctly

This is my dependencies"@angular/common": "^14.1.1",    "@angular/compiler": "^14.1.1",     "@angular/core": "^14.1.1", "@ngneat/until-destroy": "^9.2.1",  "rxjs": "~6.6.0",  "jest": "^28.1.3",  "typescript": "~4.6.4", ,when I run ut like this   it('registerFilterInputEvents -> filter is true -> keydown event', async () => {     funcA();     await funcB();     funcC();   });
async and await is not work, funC() run directly. And if I rollback @ngneat/until-destroy to @8 version, It`s work. What can I do to solve this issue?thanks

Please, provide a minimal reproducible example.


Correct branch format in Discovery API docs

Pointed at https://github.com/kubernetes/website/pull/45790#discussion_r1555111709
/cc @dipesh-rawat @Jefftree

/lgtm
Thanks!

This is the correct format for the link
e.g. https://github.com/kubernetes/kubernetes/blob/release-1.29/api/discovery/aggregated_v2beta1.json
/approve


Add .col-pr-* to handle columns in print layout

Yes it will add some more classes. Peoples who use bootstrap for mobile first support can't use col-xs for print. They need it for to handle smaller devices. As we use col- classes a lot, it will be great to have something specific to print. There's some issues posted about it.
Here's the JSFiddle: https://jsfiddle.net/3aompwbp/3/embedded/result/ (print preview from browser)
Please tell me if there's anything else to add. If col-pr is not good name, can you suggest something better?

Hi @abusayeedomar!
You appear to have posted a live example (https://fiddle.jshell.net/3aompwbp/1/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 45, column 3: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 48, column 1: E014: Columns (.col-*-*) can only be children of .rows or .form-groups

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

We won't be doing that in v3. Maybe after the first v4 ship.

+1, this would be useful for targetting print layouts.  Could this be re-opened for consideration in v4?

Going to punt on trying to do anything for print columns. We already have five tiers. Extending our grid system, however, in an external repo could be helpful for those in this thread though I suppose.

just going to leave this here: https://gist.github.com/TheSharpieOne/27f338c93d5de166ed1e35f5fc753228


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

please close this issue

Sorry, your issue will be closed as you did not submit your information in the correct format.


Jagged Array fails to save

While attempting to utilize the style in the HDF5-CSharp.Example section, I noticed that this command in flush() for an object:
Hdf5.WriteObject(GroupRoot, this, GroupName);

fails with an error if the object contains a jagged array (of immutable simple types like ints or bytes in this case). It also silently fails to save the same object if its a List<T[]> of similar types instead of jagged arrays, which is less surprising. The error that pops up is an ArgumentException from Marshal.sizeof() which traces me to this line:
https://github.com/LiorBanai/HDF5-CSharp/blob/829b65a06ddbac40010b11862853c965b37c2599/HDF5-CSharp/Hdf5Compounds.cs#L19
Since sizeof(Array) necessarily fails to produce a valid result purely from its type, since its type doesn't contain its (instance) length. I presume a problem with simply marshaling each T[] in a T[][] and writing them that way is in reading them back as the original T[][] and not as a flattened T[]. As an aside, investigating this issue lead me to this stack overflow question, which may prove useful.
The ability to save List<T[]> or T[][] would be very useful for cases where the number of objects (or in this case T[] arrays) is not known until run time (and silently ignoring Lists leads to unexpected behavior when loading the file and the data is gone - let me know if I that should be a separate issue), so any help (or a function I've simply missed) would be appreciated.

yeah a separate issue for the silent failure is good since the fix for the  failure itself (and for adding  support for different runtime lengths) will be different and may require more work :)

I gave this a thought and I'm not sure if we should support this kind of scenarios of nested objects  of unbound collections and such (or complex object inside other objects).
I'm not sure the HDF5 format was designed for this kind of hierarchy since you should be able to access the file in a A/B/C.. way and a jagged array may not conforms to this type.
I wonder if the HDF5 Viewer will be able to read and display that kind of structure.
Maybe instead of  List<T[]> we should support a different structure something like:
List where T hold the inner array instead of moving it up to the list type definition.
BTW, I also think for future version to add an enum to specify what to write to file. For example typeless/contractless will attempt to write everything while  attributes will write only fields/properties with hdf5 attributes..

https://github.com/HDFGroup/HDF.PInvoke/issues/58
this is interesting..

That is interesting. A wrapper for that functionality of PInvoke and chunked datasets (for user friendliness) would be very handy for List<T[]> or T[][], at least for the case where T is a primitive (byte, int, uint, double, float, etc). Actually, thinking about it, aren't strings just char[]? I don't know how strings are encoded, so that may not actually help.

I think, as a short term solution, (for jagged arrays) to add addition attribute (something like Hdf5SerializeMode("Binary")) which in this mode will just write all the data as byte array. That way the end user will be able to use the top level methods to write complex objects.
Down side for this is losing the ability to view it in the h5 viewer.
For arrays of custom types the approach will be the one on the other issue.

The new release, 9, supports bulk write, meaning the data in the list will be written as byte array when it is non primitive (there is new unit test for this). Next week I plan to start working on more Generalized way so the data will also be visible and readable outside c#

Happy to hear it! I'll test it out.

The error codes helpfully explained to add the ISerializable and [Serialize()] attributes to the custom class that was being bulk written in the array. I did notice fields being seemingly ignored as well, but that is a separate issue.

You only need the [Serialize()] attribute for the bulk write.
I do want to add the "correct" write in a way that the data is readable in other platforms (h5 viewer - JAVA and python reader for example).

the full implementation will be handled in #59


let foo = foo || bar results in duplicate declaration error

You can't redeclare a variable using let (or const), so the following would not work:
function something(foo){
  let foo = foo || {};  //<-- duplicate declaration of foo
  //... use foo
}

And I don't see how your proposal solves this issue. It can however be solved using default values
function something(foo = {]){
  //... use foo
}

So I don't see what your proposal adds or solves

Hey! Yes, correct. Facebook uses this in their repo , with regular vars. Setting a different variable for the variable for the memory to live would be the workaround.
And yes, that is much true, default values could be the fit, indeed. However, when writing bigger pieces of code, you tend to not want "unneeded" code as arguments in the param.
The proposal should make the use of hydration and default values more clear in meta-programming, as
var foo = Object.keys(bar) has. It's much more convenient in terms of readability to "Make everything a function" of which people can draw conclusions from rather than having to look how foo is relevant to the outer scope/global namespace, if there was any.


Core entity list widget

As a user
I want an easy to use UI element for displaying a list of core entities (recommendations, actions, indicators)

This issue was moved to dumparkltd/hr-nmrf-client#14


Weird required configuration keys were missing error

Hi all,
not sure if this is a bug but...
When I don't have config.aws:xyz in my Pulumi.{STACK}.yaml, I get the following error:

So basically, I'm forced to set something into it, just to avoid the error.
BTW, the versions are (my package.json):

And the CLI version is 2.11.2.

Hi @doitadrian
The issue is because you have not set aws:region
I have an issue opened in the underlying bridge to fix this - https://github.com/pulumi/pulumi-terraform-bridge/issues/282
I hope this makes sense
Paul

Thanks for a really quick response @stack72. 🤯
Yeah, that's true, I don't have aws:region, and there is a reason for that, I actually pass it as the AWS_REGION env variable.
Hope that helps clarify things a bit.

So Pulumi actually requires the region to be set as a configuration property - this is due to a legacy design decision. It is the only property that was required to be set - the rest can be read from environment variables

Note that I was actually deploying resources with the region set via the AWS_REGION env variable for some time now, no problems were caused by doing that. But note - I was doing it with the 2.x.y version of the @pulumi/aws package.
In other words, the only reason I'm reporting this is that this error didn't pop up in 2.x.y version, which I was using before. I started seeing it once I updated to 3.5.0, which I did just now.
And interestingly enough, the problem goes away by setting an arbitrary value into an arbitrary aws:xyz configuration property, and everything still works (proper regions are being used upon deploying resources).
I will just set an arbitrary value for now and monitor it for some time, just to make sure everything works as expected.

This is linked to #1158


feat: switch to lua-tree-sitter

As ltreesitter development seems to have stagnated, I have created new bindings for Tree-sitter. This can be found at https://github.com/xcb-xwii/lua-tree-sitter.

As of now I have switched over to the API of the new library, but work still needs to be done on the automated builds side before I can finish up the implementation and merge this.

Waiting on https://github.com/lite-xl/lite-xl-plugins/pull/427

bump


I can't see thumbs

I can't see thumbnails of comics. I have to open the comics then go back and then the thumb saves or something and I can see it always. Even after I close the app. I tried reloggging and reinstalling and messing with the options. But nothing works for me. I have the latest update and that didn't fix it.
Xiaomi Redmi note 4

i cant either

Site Update Log
2019-05-27
Thumbnails are now loaded in a different way when managing galleries, which should prevent any issues where they weren't loading.

Use 1.7.1
He fixed it.

I have 1.7.1 and still doesn't work. Do I need to reinstall?

Thanks a lot.


How do I use these files?

How do I use these files?  I'd like to install new English training data.

Please use the Tesseract user forum for questions.