AMD nested virtualization?

We have CI/CD VMs (Jenkins) running on Hyper-V that tests Docker based builds. Docker in turn requires Hyper-V, so we're unable to run any of those Jenkins' VMs on our AMD Ryzen based servers.
How do we resolve this? AMD support seems to point the finger at Microsoft Hyper-V.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a13cf32-4be1-94d9-b764-0faf79372065
Version Independent ID: 6787036e-5a30-bd17-e87a-54f61b0ba47f
Content: Nested Virtualization
Content Source: virtualization/hyper-v-on-windows/user-guide/nested-virtualization.md
Service: windows-10-hyperv
Product: windows-10-hyperv
GitHub Login: @johncslack

I too need this answer. We won’t continue to support Windows 10 if Microsoft won’t support the processor company that’s actually delivering value at this point.

What processor are you running?  I just built a new developer machine with an AMD chipset and an AMD ryzen 9 3900x. And hyper-v virtualization works fine with no issues.
You have to enable virtualization in the UEFI/BIOS BEFORE you install hyper-v but apart from that there were no issues. As stated, I am running machines on HyperV, and before that Virtual box workloads without any issues. It just works. Also running WSL, Minikube, Kind and other such dev related tools ... no issues there. Works just as fine as my old i7.

Please keep in mind this discussion is about NESTED virtualization, a feature of Windows 10, Server 2016, and Server 2019. Attempt to run a VM in Hyper-V that also has WSL or Hyper-V enabled. This feature is extremely important for VDI farms, development servers, production private cloud servers, and compact labs.

Yup. I'm running nested virtualization, doing windows docker hyperv containers in a hyperv guest. Works fine. What exactly is the problem you are seeing?

Can you share your processor and OS specs? The title indicates AMD processors ...
On Nov 28, 2019, at 4:27 PM, Larswa<EMAIL_ADDRESS>wrote:

Yup. I'm running nested virtualization, doing windows docker hyperv containers in a hyperv guest. Works fine. What exactly is the problem you are seeing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/Virtualization-Documentation/issues/1276?email_source=notifications&email_token=AATZSEFIMJWXNGUOHRUZHNDQWAZTHA5CNFSM4JI4CMF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNOPAA#issuecomment-559605632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AATZSEATLHGX53RSER4QW4DQWAZTHANCNFSM4JI4CMFQ.

Happy to..  Here are screenshots from taskman showing that windows are seeing virtualization as enabled, and a screenshot of cpu-z.  I can highly recommend getting 12 core in a machine ... :-D  Parallel  workloads (like building in parallel) doesnt slow the machine down noticeably.

But @SidShetye - what problem are you getting when installing/enabling hyperv or starting a hyperv machine on your AMD machines?

@Larswa , the issue is the typical no start condition as shown by hundreds of posts across the internet of people trying. Your experience runs opposite of that, as well as Microsoft's own statements. Can you please attempt to start a full Windows VM on your Windows Hyper-V VM (10, 2016, or 2019) running on your Hyper-V AMD system (10, 2016, or 2019). That should be a 3rd level Windows system running. Your current screenshots don't show you running a VM on a Hyper-V server VM that is on a Hyper-V physical server.

I’m away from our lab for thanksgiving to share the exact error but the issue we faced is hyper-v cannot be enabled inside the VM to have 2nd levels of VM inside the first levels of VM. On all generation 1 8C/16T Ryzens
On Nov 28, 2019, at 4:38 PM, Larswa<EMAIL_ADDRESS>wrote:

Happy to.. Here are screenshots from taskman showing that windows are seeing virtualization as enabled, and a screenshot of cpu-z. I can highly recommend getting 12 core in a machine ... :-D Parallel workloads (like building in parallel) doesnt slow the machine down noticeably.
[Taskman 2019-11-28 22_32_31-Window]https://user-images.githubusercontent.com/1431240/69832636-c66cbf80-122f-11ea-922d-a22e902b3335.png
[cpu-z 2019-11-28 22_33_08-Window]https://user-images.githubusercontent.com/1431240/69832642-c8cf1980-122f-11ea-9af7-5975401a1fb5.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/Virtualization-Documentation/issues/1276?email_source=notifications&email_token=AATZSECJKHUZ6U74ZBQSYO3QWA25HA5CNFSM4JI4CMF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNO2FY#issuecomment-559607063, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AATZSEEM4Q4R5F5B3TXCM6TQWA25HANCNFSM4JI4CMFQ.

No oh god ... youre right. I am getting the same error. How annoying. I was running docker containers in my guest, but I see now that they were NOT running in Hyperv mode, but in isolation. So I stand corrected. Well .. lets hope MS get this sorted. Untill then KVM and allegedly Virtualbox supports nested virtualization but I havent tested them. I can do with running containers on guests and not go any deeper. Sorry for the confusion guys. :-)

This is indeed a very good question by the Sid.
Seems to be a product decision (or lack of development time) on Microsoft's part, rather then a technical limitation of AMD virtualization extensions.
Honestly, one might ponder to just switch to vmware as it does support nested virtualization workloads on both AMD and Intel CPUs.

That issue with nested virtualization is being discussed highly since first Ryzen launched in 2017. I think the best way is to upvote that feature massively that on MS Feedback HUB and on user voice portal. Without that I don't think so if MS will put more resources to address that :(
I have already upvoted that feature in those places. I encourage you all to also do the same, so that strange limitation is lifted in a near future.
Here is the link to User Voice portal about that feature: https://windowsserver.uservoice.com/forums/295047-general-feedback/suggestions/31734808-nested-virtualization-for-amd-epyc-and-ryzen

I would love to have that feature, at least in Server 2019 / Windows 10 1809+. I still have to use my old i7-4960x for that. The AMD threads on that: https://community.amd.com/thread/247222 and https://community.amd.com/thread/224825

Update from the user voice portal:

Hello Hyper-V fans! I was recently alerted to your feedback on this topic and I hear your request loud and clear! I run the engineering team that is responsible for the Hyper-V hypervisor. I cannot commit to a specific Windows release that will support nested virtualization on an AMD CPU at the moment, but I recommend monitoring Windows insider builds for previews of this support as we push the changes into the hypervisor this year.

Any news? Some dates? I need this feature so hard.
i.e. Not being able to have a docker on a VM is a big stopper.

I just found out that I can't develop on a vm on HyperV because of this, and it is quite frustrating. I may have to relegate windows to go to qemu/kvm and use windows only as a VM if the Microsoft devs can't get their act together.

Update from the user voice portal:

Hello Hyper-V fans! I was recently alerted to your feedback on this topic and I hear your request loud and clear! I run the engineering team that is responsible for the Hyper-V hypervisor. I cannot commit to a specific Windows release that will support nested virtualization on an AMD CPU at the moment, but I recommend monitoring Windows insider builds for previews of this support as we push the changes into the hypervisor this year.

Hope this feature will come soon.

Its probably easier to virtualise windows in linux at this stage as Microsoft dont want to support nested virtualisation on AMD hardware

Its probably easier to virtualise windows in linux at this stage as Microsoft dont want to support nested virtualisation on AMD hardware

That's what I'm doing now, but without Hyper-V, Docker and friends it's only half the fun.

Its probably easier to virtualise windows in linux at this stage as Microsoft dont want to support nested virtualisation on AMD hardware

That's what I'm doing now, but without Hyper-V, Docker and friends it's only half the fun.

If you install May 2020 WIndows 10 Update you can run docker on wsl2 without Hyper-V.

Its probably easier to virtualise windows in linux at this stage as Microsoft dont want to support nested virtualisation on AMD hardware

That's what I'm doing now, but without Hyper-V, Docker and friends it's only half the fun.

If you install May 2020 WIndows 10 Update you can run docker on wsl2 without Hyper-V.

That's good to know - still need Hyper-V for other use cases.

Its probably easier to virtualise windows in linux at this stage as Microsoft dont want to support nested virtualisation on AMD hardware

That's what I'm doing now, but without Hyper-V, Docker and friends it's only half the fun.

If you install May 2020 WIndows 10 Update you can run docker on wsl2 without Hyper-V.

wsl2 can't be enabled without turning on hyper-v bits.
i run a kvm host with a win10 guest on an x570 taichi with a ryzen 3900x. i've been struggling for months to get this scenario working and have given up. the problem isn't unique to hyper-v hosts.
also hoping to flag attention the kvm issues. through trial/error, I learned the +vmx qemu cpu boot arg is not supported on amd platforms. this seems to [functionally] be the missing piece on amd-based kvm hosts. I get BSODs with "hypervisor_error" if I boot with any hyper-v bits enabled (wsl, credential guard, hyper-v, etc).

@wbsmolen do you know if there is a kvm bug report for this ?

@stuaxo no, but im not convinced its a kvm bug either.

It's probably worth making one, just in case it is - and if it isn't someone there might have an idea about where a fix is needed.

kvm_amd has support for nesting linux with kvm guests.
kvm_intel can also host hyper-v enabled windows machines. [2017]Nested Virtualization: Hyper-V on KVM by Ladi Prosek
You can not expect to run hyper-v on kvm when native nesting (hyper-v on hyper-v) is not even possible.
https://bugzilla.kernel.org/show_bug.cgi?id=203477

You can not expect to run hyper-v on kvm when native nesting (hyper-v on hyper-v) is not even possible.

I've done exactly this on intel machines. Does hyper-v function normally in the guest? No. But windows boots and [for reasons] that's all I'm looking for in my amd environment

It's your CPU from AMD? It's well known nested Hyper-v virtualization doesn't work on AMD cpus.

Been meaning to backlink this uservoice for a while. Encourage everyone to upvote. [Discourage everyone from adding a vacuous quip like the sorry state of the comment section over there.]

bump

Until now I can confirm that nesting on AMD works without issue on VMWare ESXi 6.7 U1 - I am able to enable hyper-v in windows guest and then use docker desktop in that VM without any issues.
So it seems that for now VMWare ESXi is the only viable option for nesting on AMD platform.

@plukawski thanks for sharing, helpful information. if you startup a hyper-v vm in the guest vm, do you get any errors? asking out of curiosity. I could also bootup a hyper-v-enabled guest vm on a kvm host, but running hyper-v vms on the guest errored out.
wsl2 seemingly was unaffected, which is interesting.

3 years on and this hasn't been solved. It's so weird to be honest...

@wbsmolen as to the VMWare ESXi the hyper-v in the guest vm is working fully without any issue for me (no crashes, no freezes, etc.). Like I said - docker desktop launched without any problem and it is using Linux Virtual machine in hyper-v in the backround. So ESXi is fully stable and operational when nesting on AMD.
As to your code 43, this is a hardcoded limitation in nVidia driver if I recall correctly - only Tesla cards can work that way properly, because only Tesla allow virtualization of GPU.

Trying to understand, are you saying you cant run docker on wsl2 with AMD on Windows 10?

@lvasiliou I don't know how you came into that conclusion. This topic is about nested virtualization (virtual machine inside virtual machine). You can launch wsl2 with AMD on bare metal without any issue.
You just cannot do that in a virtual machine that runs in HYPER-V hosted on AMD platform.

As to your code 43, this is a hardcoded limitation in nVidia driver if I recall correctly - only Tesla cards can work that way properly, because only Tesla allow virtualization of GPU.

@plukawski oddly enough I have no issues passing the gtx1080 on the kvm host when I don't enable hyper-v, which is where im currently at. can also pass a 5700xt without issue but that's loosely related here.

As to your code 43, this is a hardcoded limitation in nVidia driver if I recall correctly - only Tesla cards can work that way properly, because only Tesla allow virtualization of GPU.

@plukawski oddly enough I have no issues passing the gtx1080 on the kvm host when I don't enable hyper-v, which is where im currently at. maybe it's kvm hiding itself from the guest? im not explicitly passing that param in the vm's xml config.
can also pass a 5700xt without issue but that's loosely related here.

KVM has the ability to hide the hypervisor layer from the virtualized OS, which fools the driver. Hyper-V doesn't have any ability to do this. For awhile, the community was patching nVidia drivers to delete this check, but I don't think that's worked for awhile either. https://mathiashueber.com/fighting-error-43-nvidia-gpu-virtual-machine/

@heymrdjcw I'm aware, but as I said I'm not explicitly passing the kvm hidden state to the vm

I just tried wsl2 inside a Windows 10 Pro VM running as a guest on my Hyper-V Host (Windows 10 Pro) with an AMD Ryzen 7 2700X. Seems not to work, because wsl2 needs the hypervisor. So sad, even on Windows 10 2004.

@MatthiasTams could you try to forcibly enable hyper-v in your nested VM using the following command:
Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V -All

and then try the wsl2 again? Maybe for full virtual machine inside vm this will not work but for wsl2 it may work. I think this is nice to try.

@MatthiasTams could you try to forcibly enable hyper-v in your nested VM using the following command...

Thank you for the suggestion. I just tried it. Unfortunately the same error appears as before. The message asks me to activate the "Virtual Machine Platform" (which I already did) and quits.
Btw: If I try to enable the nested virtualization with
Set-VMProcessor -VMName  -ExposeVirtualizationExtensions $true
the VM refuses to start with the message that nested virtualization is not supported on this platform.
Sad. Still no support for nested VT on my AMD Ryzen 7 2700X and sad that wsl2 needs that.
Anyway, wsl2 is very useful on my host, even if it is unusable inside guest VMs on this host...
Now, I have another elderly workstation here with some "slow" Xeon 4-core, I will try it on that machine :-)

The situation is beyond ridiculous at this stage, can we get an official response about Microsoft's position on this besides added to backlog and working on it?
I would suspected Microsoft would love to run EPYC on Azure as well at this stage, unless they are doing it with linux there as well

So I spent ages trying to figure out nested virtualisation on KVM with Windows 10 2004 as a guest. Very hard to trick it to go past turn windows features on or off as it insists i dont have SLAT. Also as much as i tried to hide the fact its a VM, Task Manager kept reporting Virtual Machine: Yes. I tried all the KVM hiding tricks, reporting an Intel CPU etc. It seems the windows team knows people have been doing this. AWS has EPYC servers now by the way because they recognise $ per Watt.

Hey guys,
i have also an issue with nested, but with VMware ESXi 7 -> Ubuntu 20.04 LTS VM -> Qemu 4.2/5
System: Ryzen 9 - 3950X
You can watch this here:
https://github.com/GNS3/gns3-server/issues/1774
Since i changed the ignore_msrs parameter I get much messages in the console screen, but the VMs are starting. Maybe this can help someone..

so great news -- win10 build 19640 (in insider's ring) has hyper-v support for nested virtualization. does not work on kvm hosts.

That's great news. Is it available yet or just internal testing?

Available to the public via the insider's fast ring :)

Can someone tell me why it is not mentioned here? https://blogs.windows.com/windowsexperience/2020/06/03/announcing-windows-10-insider-preview-build-19640/
Such an important feature just not mentioned at all... :(

I honestly don't know. I'm not privy to anything you do not know -- I can just vouch for personal experience. Quite possibly there are more comprehensive docs in the works.

Great but I am staying away until the gaming issues are fixed :D

@wbsmolen Do you know if that update enables the Windows 10X emulator on AMD CPUs?

@dstaley haven't tested it, can't vouch for that. I got a win10 nested vm to work on a hyper-v host running a 3900x with out-of-box hyper-v settings.

@dstaley, if you look at the Windows 10X emulator on the Microsoft store, under system requirements it now says you must install windows 10 19500.0 or higher. Previously it used to say it doesnt work on AMD. I will imagex my PC just in case I want to get back to 1909 and I will give 2004 another ago.

Hey @lvasiliou ... I just got my hopes up that they had committed some code in the fast ring for this, BUT the Microsoft Documentation page still states that AMD is not supported. And it was last updated 2nd June.   Saaaad Panda.
https://docs.microsoft.com/en-us/dual-screen/windows/get-dev-tools
Still looking forward to you results on a Fast Ring build though. Ever the optimist, eh?

@Larswa. I doubt production documentation will talk about Insider Preview features. I could be wrong.
My full system backup is at 21%....

Confirmed Windows 10X Emulator working on latest Windows Insider with AMD Ryzen Threadripper 3970X

Now the question is whether we have to wait until 20H2 to get this, or if it'll make its way into a 2004 build.

so great news -- win10 build 19640 (in insider's fast ring) has hyper-v support for nested virtualization on amd systems.

Confirmed! Update-VMVersion does not work yet, and you have to create the machine with Powershell using:
New-VM -Name "S2019 Nested Test" -Version 9.3 -Generation 2
If you don't supply a version a 9.0 machine is created. Currently installing Server 2019 to run part two of the test, activating Hyper-V in there.

Deleted my VM, created a new one with ver 9.3 and attached my vhdx however i still get your CPU does not support virtualisation when trying to add hyper-v

I confirm that this is indeed working:) I was able to create a nested VM with Windows 10 1909 PRO as a guest, activate hyper-V and then install docker desktop with linux containers. Then I checked if linux containers work and they worked :)
But you have to do what @JouMxyzptlk said in order to create a nested VM.
So having the build 19640 on host allows you to create VMs with nested virtualization working on AMD.
Tested this on Ryzen 7 3700X.

so great news -- win10 build 19640 (in insider's fast ring) has hyper-v support for nested virtualization on amd systems.

Confirmed! Update-VMVersion does not work yet, and you have to create the machine with Powershell using:
New-VM -Name "S2019 Nested Test" -Version 9.3 -Generation 2
If you don't supply a version a 9.0 machine is created. Currently installing Server 2019 to run part two of the test, activating Hyper-V in there.

Can't edit any more, here the confirmation: It works! All relevant stuff is in that screenshot. CPU Ryzen 3900x, 64 GB ECC RAM.

I Have a new ASUS TUF B450-PLUS GAMING motherboard and Ryzen 5 3600Ghz CPU.
Win 10, home, 64 bit.
 Isnt that great?

Windows says:

Nope, If you Virtualize AMD CPU, I'll CRASH
No secure boot loaded for you!
TPM looks great, please clear your TPM (after 4 times, I stopped trying)

Windows further claim I have very little hardware protection. Not even ...well you check the pics.

I Hope this is the correct discussion regarding AMD and Windows 10 CPU support?
Note: I want this so function on my PC, Home version. Not server.
Hardware protection....

Anyone got any suggestion for me?

I Have a new ASUS TUF B450-PLUS GAMING motherboard and Ryzen 5 3600Ghz CPU.
Win 10, home, 64 bit.
 Isnt that great?

Windows says:

Nope, If you Virtualize AMD CPU, I'll CRASH
No secure boot loaded for you!
TPM looks great, please clear your TPM (after 4 times, I stopped trying)

Windows further claim I have very little hardware protection. Not even ...well you check the pics.

I Hope this is the correct discussion regarding AMD and Windows 10 CPU support?
I want this to function on my PC, Home version. Not server.
Im interested in security. Both sides.
The hardware protection from ASUS supports Ryzen 5 fully. Which ASUS support tells me and claims "talk to Windows".

Anyone got any suggestion for me?
I have done all the troubleshooters.
Is the lack of support for virtualization of AMD Ryzen CPU, the reason why my Workstation in Win 10, cant use Secureboot, EUFI, Kernal DMA, TPM device protection and GPU protection?
AURA in ASUS works pretty good though. Rainbow colors inside your computer that can sync to your keyboard colors etc haha. THAT junk works :p.
Any workaround for me?

I'm going nuts not being able to use the hardware protection that's built in the system!
Even Vaulttec-Boy has any idea what to do.

I wish you had spent 1/10th the time of your post on researching the issue you’re replying to.

I Have a new ASUS TUF B450-PLUS GAMING motherboard and Ryzen 5 3600Ghz CPU.
Win 10, home, 64 bit.
 Please delete your post.
I see "Driver Magician", so I suspect quite a few other things are wrong with your Windows as well. Windows is, despite its reputation, a quite open System and does not prevent any wild program from the internet f*-ing it up.
Now again: Please leave this thread, delete you post, and ask somewhere were TPM + ASUS is the topic, preferably an ASUS forum.

@Kurnn please stop doing off topic stuff...

I'm very happy to see the news that Windows 10 can do it, and look forward to when Server 2019 will be supported.

@ssoor From what I see MS does not want to tell us about that feature (there is literally no word from MS on any official channel I know). So to check that on Windows Server you will have to monitor the insider builds by your own I think.
The case of not informing community of introducing such a big feature is very strange...

@plukawski i believe that is because hyper-v is intended first for Windows Server. Noticed it even before Windows 10.

OK a symptom of the insider build is that I cant install the WSL2 kernel update, it says i must have WSL2 installed. And because of that WSL2 does not work either which also breaks Docker. A warning for those who bump to this build without WSL2 fully configured.

@Kurnn update your UEFI from Asus, disable CSM Compatibility, make sure your TPM is enabled and you cleared it from UEFI (if you have one), ensure secure boot is set to Windows OS. I am not sure if AMD is bundling a TPM with the Ryzen 3/5/7/9 as they do with the Threadripper, you might need to buy one or switch to Firmware TPM in the UEFI
Also, this is the wrong forum

@lvasiliou I do not agree about hyper-v being related specially to Windows Server. When the nested virtualization was introduced in hyper-v in year 2015 in the insider build for Intel it was officially announced, see here: https://docs.microsoft.com/en-us/archive/blogs/virtual_pc_guy/nested-virtualization-in-windows-10-build-10565
So this is very strange we do not have any official information about that topic now.

Hey @lvasiliou     My docker was broken, out of the gate, after installing the fast ring build, but a docker factory reset did the trick for me. Have not been attempting a kernel upgrade for WSL2.
Oh .. and it defaults to the WSL2 instance I have running.

@Larswa i sorted it by extracting the kernel update msi into windows\system32\lssxs\tools. I never had wsl2 in the first place so different scenario

@lvasiliou  Niiiice work man!  :-)

Hey everyone - there will be a blog post on this capability in the near future. Keep an eye on the blog this week!

Can someone tell me what family of AMD cpus are supported for that capability? Is only Zen2 supported or Zen1 and Bulldozer as well ?

Pretty sure this applies to all CPU's that support AMD-V (SVM) and Nested Paging (NPT), in contrast to Intel's VT-x and EPT
see:
https://en.wikipedia.org/wiki/X86_virtualization#AMD_virtualization_(AMD-V)
https://en.wikipedia.org/wiki/Second_Level_Address_Translation
https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/nested-virtualization#prerequisites

@neico I don't know how the information from your links is confirming your statement. For now we have zero official information from MS about that feature and its limitations.
However I have just tested on my laptop with Ryzen 5 2500U CPU (Zen1) and can confirm that nesting is working on it just fine. So I can tell from this experience that at least Zen1 is supported, however I do not have any older AMD cpu currently to check if nesting is working on them as well.

Can someone tell me what families of AMD cpus are supported for that capability? Is only Zen2 supported or Zen1 and Bulldozer as well ?

If you have a pre-Zen CPU: Make a backup from which you can boot and restore. Then just try! I did create a "disaster recovery capable" backup, in my case with drivesnapshot which works when booted from a windows stick. There are other tools out there which can do the same, some of the are even free.
If making such a backup is beyond your scope learn / train / try how to do it, and then update to that insider build to get your answer.
You can obtain that insider build from uupdump as well https://uupdump.ml/known.php - but you still should backup before trying.

Nested virtualization's working for me on latest Insider (fast ring) build. Version 2004, Build 19640.1. AMD Ryzen 3950X CPU. Hyper-V host, Ubuntu guest, nested Ubuntu guest. Weary about running an Insider build as I've gotten some GSODs before and had to reinstall completely... but glad to see this feature has been implemented. Hope to see this in the stable/non-Insider build soon!

@JouMxyzptlk currently I do not have access to pre Zen AMD CPU. However for testing I prefer using VHD Native Boot feature instead of backing up the entire system and install Insider Build as a main system. I would also suggest you to try it - it greatly eases the coexistence of multiple Windows OS on a single machine. I use a tool called WinNTSetup3 for creating such VHDs directly from the ISO. When you look into my github repository you will find that I have also created a console tool for moving your main OS to the VHD Native Boot :)

Update on tests with 19640 nested virtualization: All 64 Bit Windows OSes work fine. The only Windows 32 bit OS that works as nested guest is Windows NT 4.0 (you read right!). Windows 2000/Win XP/Server 2003/Vista 32 bit/2008 32 bit/win7 32 bit all come up with a blue screen. They work on the real Win10 host though, exported and imported into the virtual server 2019 nested-enabled guest -> fail with blue screen.

So are you saying it works without having to create the VM in powershell in Windows build 19640?
Or that it works when creating the VM in powershell?

Confirmed! Update-VMVersion does not work yet, and you have to create the machine with Powershell using:
New-VM -Name "S2019 Nested Test" -Version 9.3 -Generation 2
If you don't supply a version a 9.0 machine is created. Currently installing Server 2019 to run part two of the test, activating Hyper-V in there.

And would it work in build 20150? I have build 19619, so I think I have to upgrade, and MS is offering me 20150 now

So are you saying it works without having to create the VM in powershell in Windows build 19640?
Or that it works when creating the VM in powershell?

Why should I create the nested, aka 2nd level, guest using powershell?

my poor choice of words. I meant creating a machine in hyper-v, not nested
The post above suggested I had to create the first machine using powershell, or it wouldn't work

I Have a new ASUS TUF B450-PLUS GAMING motherboard and Ryzen 5 3600Ghz CPU.
Win 10, home, 64 bit.
 Isnt that great?

Windows says:

Nope, If you Virtualize AMD CPU, I'll CRASH
No secure boot loaded for you!
TPM looks great, please clear your TPM (after 4 times, I stopped trying)

Windows further claim I have very little hardware protection. Not even ...well you check the pics.

I Hope this is the correct discussion regarding AMD and Windows 10 CPU support?
I want this to function on my PC, Home version. Not server.
Im interested in security. Both sides.
The hardware protection from ASUS supports Ryzen 5 fully. Which ASUS support tells me and claims "talk to Windows".

Anyone got any suggestion for me?
I have done all the troubleshooters.
Is the lack of support for virtualization of AMD Ryzen CPU, the reason why my Workstation in Win 10, cant use Secureboot, EUFI, Kernal DMA, TPM device protection and GPU protection?
AURA in ASUS works pretty good though. Rainbow colors inside your computer that can sync to your keyboard colors etc haha. THAT junk works :p.
Any workaround for me?

I'm going nuts not being able to use the hardware protection that's built in the system!
Even Vaulttec-Boy has any idea what to do.

You must upgrade win 10 pro or win 10 enterprise to run hyper-v

You must upgrade win 10 pro or win 10 enterprise to run hyper-v

and also win 10 edu and server
And could you please delete all those photos? This is an issue about nested virtualization on AMD CPUs, not about your PC and the incompatibility of some Windows versions with hyper-v (this is not nested virtualizaion!)

When following the build numbers and which will be the future 20H2 I make following prediction: Nested virtualization will not be included in 20H2, which will be 19042., a rather small step like 1903-1909 step probably thanks to COVID19.
Insider build 19645. was from 10th June and maybe that was planned for 21H1 with official support for nested on Ryzen. Currently newest insider build is 20161.* for AMD and 20170.* for Intel due to some mentioned bug on AMD CPUs with 20170., looks like skipping 196 builds - maybe due to COVID19 as well, not wasting resources on that branch.

@pantasio

You must upgrade win 10 pro or win 10 enterprise to run hyper-v

and also win 10 edu and server
And could you please delete all those photos? This is an issue about nested virtualization on AMD CPUs, not about your PC and the incompatibility of some Windows versions with hyper-v (which is not about nested virtualization!)

And dont forget to clean your desk and do cable management 🤣

You guys! Quick question: Are Vishera core CPUs ever gonna be supported?

So I am on 19042.423 and I cannot select option 9.3 anymore:The VM version 9.3 of the virtual machine 'New Virtual Machine' is not supported.

So I am on 19042.423 and I cannot select option 9.3 anymore:The VM version 9.3 of the virtual machine 'New Virtual Machine' is not supported.

It will never work with 190??.??? version. Minimum build requires is 19640 (or the current 20180)

So I am on 19042.423 and I cannot select option 9.3 anymore:The VM version 9.3 of the virtual machine 'New Virtual Machine' is not supported.

It will never work with 190??.??? version. Minimum build required is 19640 (or the current 20180).

OK which channel is that? I am getting totally confused with the Windows Insider programme and which channel gives you what. Probably easier to run linux

OK which channel is that? I am getting totally confused with the Windows Insider programme and which channel gives you what. Probably easier to run linux

DEV channel is the bleed'n edge, so DEV should work(it was build 20180 last time I checked) if the other ones aren't higher than 19640

Nice news: Windows Server Insider LTSC is now build 20201 - which means nested virtualization should work with real server OS as well and not just Windows 10.
https://blogs.windows.com/windows-insider/2020/08/26/announcing-windows-server-vnext-preview-build-20201/
But my server is my old i7-4960x and no Threadripper/Epyc, My secondary server with 192 GB RAM is even older with Sandy Bridge CPUs and only powered up for specific tasks which need such an amount of RAM, such as encoding 16k videos.
Anybody got me a Threadripper/Epyc System with 192 GB RAM? ;)

Nice news: Windows Server Insider LTSC is now build 20201 - which means nested virtualization should work with real server OS as well and not just Windows 10.
https://blogs.windows.com/windows-insider/2020/08/26/announcing-windows-server-vnext-preview-build-20201/
But my server is my old i7-4960x and no Threadripper/Epyc, My secondary server with 192 GB RAM is even older with Sandy Bridge CPUs and only powered up for specific tasks which need such an amount of RAM, such as encoding 16k videos.
Anybody got me a Threadripper/Epyc System with 192 GB RAM? ;)
As for now I will have to try nested in a virtual Server-Next within a virtual Server-Next within a virtual Server-Next within the real Windows 10 20201...

Nice news: Windows Server Insider LTSC is now build 20201 - which means nested virtualization should work with real server OS as well and not just Windows 10.
https://blogs.windows.com/windows-insider/2020/08/26/announcing-windows-server-vnext-preview-build-20201/
But my server is my old i7-4960x and no Threadripper/Epyc, My secondary server with 192 GB RAM is even older with Sandy Bridge CPUs and only powered up for specific tasks which need such an amount of RAM, such as encoding 16k videos.
Anybody got me a Threadripper/Epyc System with 192 GB RAM? ;)
As for now I will have to try nested in a virtual Server-Next within a virtual Server-Next within a virtual Server-Next within the real Windows 10 20201...

For those who can: Test Windows Server 20201.1000 Insider. I've already reported a few weirdness when trying to run it on Ryzen 3900x as nested 2nd-level guest (Host Win10 20201.1000, first level Server 20201.1000, second level 20201.1000 (version 9.3) normal reboot fail, second level Server 2019 (version 9.3 machine) activate hyper-v bricks the virtual machine, even though it should work.
They need the feedback before they release the 21h1 Server (and Windows 10).
https://blogs.windows.com/windows-insider/2020/08/26/announcing-windows-server-vnext-preview-build-20201/

does kvm + win10+hyperv+ wsl2 works now？

Not sure what the situation is with AMD nested virtualization on KVM but that chain works fine on hyper-v

Probably not the test way to request this but can we get a dedicated ui app for hyper-v? Experiencing quite a few issues free past few years with the archaic mmc like having to connect to the local hyper-v service every startup or having no VMs showing up and having to reregister them only to be told they are registered on the server already. Also my default switch seems to be broken past 2 builds.

Honestly: Why do people post so much OT stuff here?
KVM + Hyper-V: You are in the wrong thread!
Hyper-V GUI: Use Powershell. The Management-Service style is standard among many OS-es. Do you want a web GUI, enforcing you to run and maintain IIS on a Hyper-V host? Also: Wrong place to complain, make your own suggestion.
HV-Switch broken complaint: Oh come one, you are on Insider-Dev, I recently had t restore the pre-insider backup since the appx-upgrade broke with 20201 and all following builds consequently failed to upgrade 1% before the finishing line. But why don't you use the feedback Hub and complain here?

KVM + Hyper-V: You are in the wrong thread!

@JouMxyzptlk Any hints about the "right" thread? This is the one you will findwhen searching about "kvm nested virtualization windows ryzen"...

Honestly: Why do people post so much OT stuff here?
KVM + Hyper-V: You are in the wrong thread
Also confusing!
Hyper-V GUI: Use Powershell. The Management-Service style is standard among many OS-es. Do you want a web GUI, enforcing you to run and maintain IIS on a Hyper-V host? Also: Wrong place to complain, make your own suggestion.
HV-Switch broken complaint: Oh come one, you are on Insider-Dev, I recently had t restore the pre-insider backup since the appx-upgrade broke with 20201 and all following builds consequently failed to upgrade 1% before the finishing line. But why don't you use the feedback Hub and complain here?

If you want to use remoteFX with this, you can just create the VM as a gen 1, nested works with gen 1 as well

Honestly: Why do people post so much OT stuff here?
KVM + Hyper-V: You are in the wrong thread

Also confusing!

I need to ask, why?
Caption of this thread is:"AMD nested virtualization?"
It is in "MicrosoftDocs/Virtualization-Documentation"
Nested virtualization on Windows and AMD is broken everywhere, not only in Hyper-V on first-level host.
Most of people want run virtual-machines with Windows on KVM, and have choice to run second-level virtual-machines in Windows.
My story is simple, i have two Windows Servers in KVM, one of them on Intel, one on Ryzen.
Everything works and run very well, but if i try to run second-level virtual-machine on AMD, it always get stuck.
But on Intel, no problem.
Its is only problem with Windows and Microsoft, who threw AMD overboard and did not implement this functionality.
Where is the right place to give notice about the problem, which by all indications also belongs here?

As for Insider Build 21313.1000, the first one that fixed my PREOOBE Problem and installed fine since June 2020: The configuration-version can now be 10.0. New created VMs using the GUI will have version 10.0 automatically. You can upgrade an existing machine to Version 10.0 in the GUI. Now you ONLY need to run Set-VMProcessor -ExposeVirtualizationExtensions $true -VMName .

The same for Server 2022 newest preview, Build 20303.1: As written above for Windows 10 21313.
Download at https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewserver

I'm running Windows on a VM on Linux (libvirt, kvm, qemu).
Still have issues running Gen 2 VMs. Gen 1 VMs are able to run, Gen 2 VM shows only a black screen at all times and I notice one CPU core on host is maxed out in kernel-mode usage. I believe this is why Windows Sandbox shows a generic error when I start it up. (I don't remember how WSL2 fails to start but I do know that it fails to start)
(I'm not sure if the Gen 1 VM is running with AMD virtualization extensions, so far I've only booted a small Linux ISO. I can try to run "openssl speed" next time.

Oh great, announcing Windows 10 21H2 as insider build number 19044.1147 - I hate being toyed with. How long will Microsoft keep on mocking us? Do the want to reserve that feature for Windows 11? The code is there since May 2019, and yet they only still offer the upcoming Server 2022 as the only "official" way, or having to use an insider build (which nukes my TV card)... This is SO annoying.

Given that Windows Server 2022 is officially out as of last week, has anyone had the chance to try out if it comes with nested virtualization on AMD (Epyc) platforms?

@joergbattermann  Yes - it fully supports nesting on AMD Hardware, its default HYPER-V configuration version is 10.0, and since 9.3 version nesting is fully supported on AMD platform. I have even downloaded an evaluation ISO and checked by myself and I can confirm, that nesting is working fine on my Ryzen 7 3700X.
However, I don't know if this is related only to AMD (I don't have Intel system now to test this) or is it just nesting itself, but as soon as I enable nesting for a VM, I see very significant performance degradation in that VM even when the VM is currently not running any nested virtual machine inside. For example Cinebench R20 score in that VM before enabling nested virtualization is 3100-3400, but after enabling nesting the score goes down to 1600-2100 levels (no nested virtual machine is running in background). Such degradation is noticeable everywhere - even opening explorer window start to be sluggish. As soon as I disable nesting for the VM its performance comes back to normal levels. Does anyone is also observing such issues?

You see correct. The performance of nested virtualization even improved with Windows 11 / S2022, but it is still true:
https://virtualizationreview.com/blogs/everyday-virtualization/2015/07/testing-windows--server-2016-with-nested-hyper-v.aspx

@Joachim-Otahal I have seen that article before, but I think it is talking about performance hit seen in the Level 2 Guest (that is the nested virtual machine) not the virtual machine that hosts it. However I may be wrong.
A year ago I was working on nested virtualization done using VMWare ESXi on the same hardware and didn't notice such performance degradations, however I do not have the exact numbers now. Maybe I will try to check if VMWare ESXi is introducing the same level of performance degradation for level 1 guests...

@Joachim-Otahal I have recently tested if there is any performance degradation after enabling nesting to a VM on the Intel platform (i7-10700). It turned out that there was no meaningful performance degradation there at all - the VM after exposing virtualization extensions to it and installing hyper-v role did perform exactly the same as before doing that.
On AMD system the performance hit in such situation is in range 10-40% (the performance is highly unstable between benchmark runs). This poses a question - why is this happening? Having so significant performance drop when nesting is enabled can render this feature totally useless on AMD platform.
On AMD platform I tested that on both Windows 11 and Windows Server 2022 installed on the host. On Intel platform I tested that having Windows 10 20H2 on the host.
In VM I used Windows 11 most recent build (.194) for both Intel and AMD.

@Joachim-Otahal I have recently tested if there is any performance degradation after enabling nesting to a VM on the Intel platform (i7-10700). It turned out that there was no meaningful performance degradation there at all - the VM after exposing virtualization extensions to it and installing hyper-v role did perform exactly the same as before doing that.
On AMD system the performance hit in such situation is in range 10-40% (the performance is highly unstable between benchmark runs). This poses a question - why is this happening? Having so significant performance drop when nesting is enabled can render this feature totally useless on AMD platform.
On AMD platform I tested that on both Windows 11 and Windows Server 2022 installed on the host (Ryzen 3700X). On Intel platform I tested that having Windows 10 20H2 on the host.
In VM I used Windows 11 most recent build (.194) for both Intel and AMD.

I cannot tell. I'm not associated by Microsoft. There are too many variables from energy saving settings in Windows, core parking, BIOS/UEFI update, CPU Microcode (which comes with the BIOS) and so on. To be honest: I won't invest time checking for that specific issue on my i7-4960x in comparison to my Ryzen 5950x. I won't be getting a newer Intel system in the near future, rather phasing out my i7-4960x which replaced my older server-system sind I got the Ryzen 2700x.
You might contact your hardware manufacturers and Microsoft directly for better answers.

@Joachim-Otahal I don't want you to invest any time in this :) I just wanted to share my own findings. However, if you find it curious, I suggest to check this on your Ryzen machine if you are experiencing the same degradation? If the problem does not reproduce for you then something is clearly just wrong with my hardware configuration.
It is easy to reproduce, here are the steps:

Create a new VM with at least 8 vcores (without enabling nesting for now) and install Windows 11 preview inside
After all updates are installed and system is idle Install CPU-z in that VM, run built in benchmark 3 times and write the avg values.
Shutdown VM, enable nesting for that VM and then install HYPER-V role inside it.
Rerun benchmark from CPU-Z in that VM and compare the results from step 2.
I found this to be the fastest way to check if there are any performance regressions. For me the regression is like already mentioned between 10% and 40%, which is huge and in my opinion unacceptable.

I'm running Windows on a VM on Linux (libvirt, kvm, qemu).
Still have issues running Gen 2 VMs. Gen 1 VMs are able to run, Gen 2 VM shows only a black screen at all times and I notice one CPU core on host is maxed out in kernel-mode usage. I believe this is why Windows Sandbox shows a generic error when I start it up. (I don't remember how WSL2 fails to start but I do know that it fails to start)
(I'm not sure if the Gen 1 VM is running with AMD virtualization extensions, so far I've only booted a small Linux ISO. I can try to run "openssl speed" next time.)

Soon after I made this comment I tested and it was clear that the gen1 VM was performing as expected.
But that's about it. I'm on Windows 11 (21H2, 22000.194) and gen2 VMs still do not start. I see a 'vmmem' process use 100% of a single cpu thread whenever I start a gen2 VM. I just tried Windows Sandbox and the same thing happened.

Last I was told, this was working in the insider builds for Windows 10.
Has it been taken out? I ask because not all Ryzen users are able to officially install Win 11 :/

Last I was told, this was working in the insider builds for Windows 10.
Has it been taken out? I ask because not all Ryzen users are able to officially install Win 11 :/
Especially given that it was explicitly said to be working on 1st Gen Ryzen @SidShetye @johncslack

Last I was told, this was working in the insider builds for Windows 10.
Has it been taken out? I ask because not all Ryzen users are able to officially install Win 11 :/

Yes, it has been taken out. VERY annoying. This is the major reason what I switched to Windows 11 so early on. The only other thing I find actually positive are robocopy /iorate options. As for the rest solala, a messed up taskbar, and a new useless overlay over the old explorer context menu (which you can deactivate with a registry key), explorer renaming and generally slower explorer and so on. If you don't actually need nested virtualization, wait for the next service pack. The other optimizations below the messed up UI don't compensate unless you have actual use for them. I use nested-v for deduplication on the first level guest (server 2019, soon server 2022), holding about 15 test guest machines with a deduplication rate between 60% and 70%, saving 400 GB of SSD space.
Nobody knows if or when they might give that feature to Windows 10. I suspect, currently, never.
If you want a more useful version of it use Server 2022, but that has some other side effects when it comes to gaming, for example.

Shame, I would've used a non-standard way of installing Win 11 for first gen nest-virt but blocked updates and compatibility are a hassle and I expect the amount of hassles to grow for non-officially supported CPUs
It's a small feature that they already proved can be supported and then it did work while we tested it but they took it out. Almost a forced upgrade when 7th Gen Intel was sitting pretty.

If you need nested-v with a less messed up UI use Server 2022. You can convert the 180 days eval version to an unlimited-forever-eval version. Brings some restrictions regarding UI customization, which you can work around too. As fas as gaming is concerned: I never tested it, it should be between windows 10 and windows 11 performance-wise since the kernel is newer. Good luck!

Yes, it has been taken out. VERY annoying.

lol, wow. I installed the Hyper-V role again after reading your comment and I got a BSOD on reboot (HYPERVISOR_ERROR I think). Later I rebooted into safe mode and Windows automatically reverted the installation of Hyper-V (it knew it failed to boot multiple times). So I guess this has to do with what you say. I can't believe it seems like Windows 11 regressed on support for this.
Either way, I was never able to get generation-2 VMs working (on Windows VM on Linux KVM, on Ryzen 7 3700X), but now it can't even start Hyper-V. When Hyper-V used to start up on Windows 10, the generation 2 VMs would behave like others have described, they are just unresponsive and there is high activity on one cpu.
btw, is Windows 11 missing the bootloader option for hypervisor startup? Before trying to reboot into safe mode, I tried running bcdedit in recovery environment, but the hypervisor parameter was not listed like I expected, and this is the first time I looked at bcdedit in Windows 11, so I guess it is a new thing. Meaning there may be no easy way to disable hypervisor with BCD.

a messed up taskbar
lol yep, I've been using ExplorerPatcher lately, it's a brilliant tool and it's on GitHub 👍 I would be happy to use the Windows 11 taskbar if you could adjust its height and if they didn't deprecate toolbars. I'm not surprised toolbars don't work, the new toolbar must be a lot of new code, but it kinda sucks that toolbars will probably remain unsupported.

I installed the Hyper-V role again after reading your comment and I got a BSOD on reboot (HYPERVISOR_ERROR I think).
Either way, I was never able to get generation-2 VMs working (on Windows VM on Linux KVM, on Ryzen 7 3700X),

You use Linux KVM as main hypervisor? Your issues are COMPLETELY different from here, and at least 90% off-topic. Your problem ist first in the KVM Level, and then, maybe, the Windows OS. If your KVM does it right you can activate Hyper-V in your virtual machine running Windows 8(.1) or Server 2008 (R2) or later. If that does not work it is a KVM problem, not a Windows problem. You should contact your Linux groups first. Maybe a Linux update changed something in your KVM, and now it doesn't do what it could a few Month before?

This Dell article explains my goal nicely where I have bare-metal hyper-V and then I install ProxMox, ESXi, or other linux hypervisors to run VMs and Containers in. It has a pretty picture of what I want to do right at the top, even! :)
And its requirements section rightly states that you need:

An Intel processor with VT-x and EPT technology - nesting is currently supported on systems with Intel processors only.

I'm left here wondering why any old Intel CPU can do this, but all Ryzen processors are getting left out in the cold. Do I spend more money for an Intel CPU that I don't like? My whole household is AMD at present.

@Szeraax , please note that the article from Dell site was last updated before the Windows Server 2022 launched. At that time there was no support for nesting on AMD processors in HYPER-V (it was only in the Insider builds). However The Windows Server 2022 now has official support for nesting on AMD processors, so in my opinion you can try to run it.

@plukawski
My understanding is that this is ONLY for Hyper-V in Hyper-V. Not KVM/Linux in Hyper-V.

@Szeraax Since Windows Build 19640 (by that time Windows 10 insider fast ring), which was about May/June 2020, nested virtualization works with AMD, proven. It seems that any Windows build, doesn't matter whether Windows 10, 11 or Server 2022, with a build number 19640 or higher can do it. Unfortunately Microsoft in its unknown wisdom decided to keep that feature from Windows 10 since all official upgrades since 20H1 are built 19041/19042/19043/19044, and I SUSPECT the upcoming 22H1 Windows 10 build will be 19045. Therefore deliberately forcing to upgrade to Server 2022 or Windows 11 if you want nested-V on AMD. You can download the trial version of Server 2022, convert it to an "endless trial" instead of 180 days trial (google on how to), and play with that one at home. Don't do this on company machines though.

@plukawski
My understanding is that this is ONLY for Hyper-V in Hyper-V. Not KVM/Linux in Hyper-V.

You are wrong here: The first level of hypervisor must support it on the CPU architecture, no matter whether you use Windows/VMware/Linux/etc, So it does apply to "KVM as guest inside a Hyper-V VM". And the other way around too. Though Microsoft was the last from all popular hypervisors to support it, all others were there earlier.

I'll have to go spin up a new 2022 server and see. I bet you're right that its like not backporting DNS cmdlets for windows 8 to windows 7 despite it working fine if you import the module on a Win7 machine.
There is this MS doc that at least discourages it:

Virtualization applications other than Hyper-V are not supported in Hyper-V virtual machines, and are likely to fail. This includes any software that requires hardware virtualization extensions.

@Szeraax , please note that the article from Dell site was last updated before the Windows Server 2022 launched. At that time there was no support for nesting on AMD processors in HYPER-V (it was only in the Insider builds). However The Windows Server 2022 now has official support for nesting on AMD processors, so in my opinion you can try to run it.

Including Ryzen 1000? It's a shame since it worked for I sider users that had it and then changed mind last minute after giving their word :/ Feels misleading

If this is considered done, any reason for this topic to stay open? I always get a good feeling when people close with WONTFIX.

please note that the article from Dell site was last updated before the Windows Server 2022 launched. At that time there was no support for nesting on AMD processors in HYPER-V (it was only in the Insider builds). However The Windows Server 2022 now has official support for nesting on AMD processors, so in my opinion you can try to run it.
@plukawski

Including Ryzen 1000? It's a shame since it worked for I sider users that had it and then changed mind last minute after giving their word :/ Feels misleading

s, but all Ryzen processors are getting left out in the cold. Do I spend more money for an Intel CPU that I don't like? My whole household is AMD at present.

did you find a way on the amd ?

@brasmith-ms Would there be updates on this by any chance or should we just close the issue :/
Could've sworn that the feature achieved full functionality on W10 but then was dropped entirely :(

It is solved. Windows 11 and Server 2022 can do nested-v with AMD. The only reason why I am running Windows 11. Microsoft tactical decision.
Please close this issue.

Personally, I've moved on and the use case is no longer applicable for me. @Joachim-Otahal - can you point to any docs/artifacts to confirm nested Hyper-V virtualization works on AMD processors? For the sake of other AMD users facing this issue, I'd like to keep this open till we can confirm.

@Joachim-Otahal - can you point to any docs/artifacts to confirm nested Hyper-V virtualization works on AMD processors?

Microsoft should pay me for this. And you too, IMHO :D!
HowTo: https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/nested-virtualization
News on Server 2022 and Windows 11 regarding this: https://docs.microsoft.com/en-us/windows-server/get-started/whats-new-in-windows-server-2022

Thanks. Confirmed and closing.
From the first link

Run Hyper-V in a Virtual Machine with Nested Virtualization
...
Prerequisites
...
AMD EPYC/Ryzen processor or later

The Hyper-V host must be Windows Server 2022/Windows 11 or greater
VM configuration version 10.0 or greater

From the 2nd link

Nested virtualization is a feature that allows you to run Hyper-V inside of a Hyper-V virtual machine (VM). Windows Server 2022 brings support for nested virtualization using AMD processors, giving more choices of hardware for your environments. More information can be found at the nested virtualization documentation.

Isn't there any way to force it to work on LTSC 2021 as well, or at least backport it there officially?


Support enabling the footage of script location and datetime

Description
I came across this twitter which shows that it would be helpful to embed the info of script and datetime into the figure:

If you agree, I suppose it would be better to plot these texts below the main figure, instead of the corner.
Proplot version
0.6.4

Neat idea but this also seems a little niche (and people put all sorts of stamps and taglines on their figures; if I implement this I'd probably have to start supporting lots of different options). Don't think I will implement this.


Test automation for DAP & OSS for GKE/K8s design

The following is a design in order run OSS/DAP testing for Secrets provider for K8s in GKE. This design will be changing with the progression of the task and definitely open for feedback and insights

Using the oss-by-default-oss-by-default tag from the kubernetes-conjur-deploy repo and use that tagged commit to run the tests
I will be using the k8s-conjur-demo as an example of how to configure the repo to extend configuration to GKE
Add proper GKE configurations in order to deploy DAP/OSS in GKE
Roles and rolebindings apiVerisons will be updated according to what is supported GKE (from v1 -> rbac.authorization.k8s.io/v1 for example)
Configure scripts so that according to the flag received (—dap/oss), the proper test environment will deployed on GKE.

Current obstacles
Problem: During the Configuring Master pod stage, the container is terminated with a code 137. I am not sure what changed between the deployment from yesterday and today except for the reverting of the commit
Solution: In response to this error:

I plan on instead of taking the oss-by-default-oss-by-default tag, I will try master
Check logs to see where the failure took place
Post in slack, asking if something was changed in k8s-conjur-deploy

A couple of issues I faced along the way and how they were fixed:

I was getting the following unknown authority error:

oc login -s https://openshift-311.itci.conjur.net:8443/console/catalog
The server uses a certificate signed by an unknown authority.
You can bypass the certificate check, but any data you send to the server could be intercepted by others.
Use insecure connections? (y/n):

and had to add the following to my ~/zrshrc in order to switch between oc clusters because ci oc clusters don't have real certs
https://conjurhq.slack.com/archives/CBTETAE20/p1560528004464300

With gke and openshift, I needed to specify what I wanted K8s to communicate with.
If you run kubectl cluster-info and see openshift, run kubectl config use-context gke_conjur-gke-dev_us-central1-a-test-cluster1 and run kubectl cluster-info again to ensure K8s is pointing to gke

closed as this was merged


Add errors/warning where we're sure that an error could be

Related to https://github.com/timocov/ts-transformer-properties-rename/issues/8#issuecomment-651124733

Needs to revert changes for #5 and warn about using in operator for internal types (that's ok for public types).

Depends on https://github.com/microsoft/TypeScript/issues/36733

Quite possible that we need to revert changes from dc111965e67ad6d4f63117e176c31e1862cba721 and warn about defining properties because at least terser doesn't support properties renaming defined in Object.defineProperty. From the docs https://terser.org/docs/cli-usage#cli-mangling-property-names-mangle-props:

Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.

/cc @artfiedler

Nooooooo….. Lol I believe those docs are out of date, I had verified terser worked, I had the latest version of terser
From: Evgeniy Timokhov
Sent: Saturday, July 4, 2020 5:21 AM
To: timocov/ts-transformer-properties-rename
Cc: Arthur Fiedler; Mention
Subject: Re: [timocov/ts-transformer-properties-rename] Add errors/warningwhere we're sure that an error could be (#10)
Quite possible that we need to revert changes from dc11196 and warn about defining properties because at least terser doesn't support properties renaming defined in Object.defineProperty. From the docs https://terser.org/docs/cli-usage#cli-mangling-property-names-mangle-props:
Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.
/cc @artfiedler
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I believe those docs are out of date, I had verified terser worked, I had the latest version of terser

Yep, I've tested it after posting my comment and it works fine.

Related to https://github.com/terser/terser/issues/748

Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.

This is merely to warn people who don't understand the limitations. I got tons of issues which assumed Terser did full flow analysis (which it doesn't).
Ideally I would love property mangle to work more safely, and using typescript typing information to achieve this is a great idea!


Avoid runts in headings, subheadings, and descriptions

Runt: Single, short word at the end of a paragraph.
How might we try to eliminate these from happening in blocks of content

Grooming notes:

Some discussion regarding this
Could use no br but you would have to input it in all places you don't want this to happen, so maybe not really ideal

Issue was not prioritized and service is now winding down. Therefore closing this without resolution


Update sip-gateway-configure.md

Added Troubleshooting steps for 911 calls not working on SIP Compatible Phones.
).

I did a bit more testing I think it can be reworded just to  mention the Emergency Call Routing Policy

[!NOTE]
Troubleshooting Emergency Calls : Dialing 911 from a SIP Gateway Connected phones may result in the Call unable to reach 911. If dialing 911 on a SIP Gateway Connected phone fails, and dialing 911 on other Teams clients is successful, check the Emergency Call Routing Policies. SIP Gateway phones exhibiting this behaviour require a Emergency Call Routing Policy for 911 calls. For more information about emergency calling, see Plan and manage emergency calling.


Grid fs

Added grid_fs for storing pipelines and history of composing.

Hello @Sash0check! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file init/init_pipelines.py:

Line 74:5: E722 do not use bare 'except'


Push react native to 0.73.6

Summary
Push react native dependency and other dependencies that were needed for this push.
Ticket Link
https://mattermost.atlassian.net/browse/MM-57195
May fix https://mattermost.atlassian.net/browse/MM-57114
Release Note
IMPORTANT: updated the IPhone Deployment Target to 13.4. Old devices may not be able to update the app (<1GB RAM and <iPhone6s)

Not sure if we want to rephrase this. In this link on Supported Devices there is a list of the devices that lose support in this version.

@larkox conflicts

@enahum Let's update them in the next round of updates. This PR has already taken too long :stuck_out_tongue:

@yasserfaraazkhan This updates many libraries, so a full smoke tests and maybe running the e2e tests we have would be awesome.
No functionality should have changed, but since it is a dependency update "anything" could break.


Release Automation

Description
Changes proposed in this pull request:

Full automation is introduced to the release process
This automation contains 2 main phases, Cut a new release and Finalize Release. Cut a new release is used once we decide to cut-off the main or release branch for a specific milestone. Finalize release is used to mark the release as stable once we verify everything in prerelease.

Code Freeze

Next Release Candidate
Once the release branch is pushed, it triggers a subsequent release candidate preparation that contains;

Linter check
Artifact generation (docker image, etc)
Processing helm charts
Change log generation

For example, once Helm charts are processed, changes are automatically pushed to the release branch. Here is some view of those.

Finalize Release
Once we verify everything in prereleases, we can just finalize the release.

Related issue(s)
Fixes #584
Documentation

Docker image generation fails since, I have added additional env vars to .goreleaser.yaml, and this depends gh action files. In PR, GH does not  use my gh action files, but goreleaser.yml needs that env vars.

@mszostok thanks for the comments, it seems we have 2 unclear items in this PR;

Having v as a prefix
Having the same release branch for multiple fix releases.
I just used different notation but have same output just for the simplicity, but we can discuss and I can handle them in different way.

I addressed all the items, now;

There is v prefix for release tags
We have release branches for minor and major releases. Multiple patch releases share same release branch
Helm version in values yaml fixed
skip-ci added for other required workflows
Unused release scripts are removed
.release file is removed

I left additional comments, I will test that now on my fork now 👍

Thanks, addressed them all, triggering jobs on my end too

@mszostok addressed the items we discussed today


[echo] Make pod selector also selects based on version.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-multicluster-k8s-tests_istio

integ-helm-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-distroless-k8s-tests_istio

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

integ-ipv6-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

integ-ipv6-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

An Echo Instance consists of several subsets. The Version is considered legacy, there are multiple subsets that must be covered.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

integ-ipv6-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

integ-ipv6-k8s-tests_istio
d18af66741e2e76929104a01a2260549e480550a
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
212b84bdf21cc0f7606b8a9e512bdb217dbf0197
link
/test integ-pilot-multicluster-tests_istio

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
dce2408fbab39f61b6a29e0de39546b52dd4eab7
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Publish to CRAN

Once everything is in order and we have a working version

In the intermediary we can publish as a GitHub package right? So maintain a working, tested master branch and add something like this to the readme:
install.packages("devtools")
devtools::install_github("lijdsmanalwin/xaf_reader")


Sending too many useless resize on aframe.js

see this tweet https://twitter.com/fr3ino/status/872516862025838592

cc @freinbichler easier for me to track here :)

60 time per seconds is surely silly :)

A PR is very welcomed!

obsolete

the bug is still open. we will use this issue => https://github.com/jeromeetienne/AR.js/issues/574


New version: KDE.Dolphin version 23.04.3

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115045&drop=dogfoodAlpha

@wingetbot run


Add Cuyahoga Community College

https://www.tri-c.edu/
https://catalog.tri-c.edu/programs/computer-science-aa/#programsequencetext

@UTKyle I am sorry, the domain acad.tri-c.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Update DeviceManager to provide protections for multiple threads or reentrancy

closes #147
I added protections to prevent classes from attempting to manipulate the IKeyed dictionary as the collection is being iterated and devices are being activated. This includes a CCriticalSection and the associated leave/enter logic when the activation cycle is being run, as well as in the AddDevices method.
There is now a boolean that is set to false when the activation cycle is complete. Attempting to add a device after the activation cycle is no longer allowed. Calling the AddDevice method after the activation cycle will result in a console message and an Error Log entry, and the device will NOT be added.

This PR also adds a CTimer to the ControlSystem class. This timer is initiated in the InitializeSystem class, and the time is set via a constant. This allows for possible issues in the startup of the system to be clearer in the stack trace or exception messages.


data race in concurrent calls to BeginSubsegment

I think https://github.com/aws/aws-xray-sdk-go/blob/master/xray/segment.go#L183-L184 need to go inside the locks?

For visibility, similar issue here https://github.com/aws/aws-xray-sdk-go/blob/master/xray/segment.go#L70-L80.
When a context gets cancelled, there is a data race between the Close method and the snippet linked.


Move non-binary scripts into a scripts/ directory

Description
We have a lot of scripts and having a division between compiled binary files and bash scripts would be nice.  This PR moves non-binary scripts to scripts/ and also puts bin/ and scripts/ on the $PATH to make these scripts easier to use.
Reviewer Notes
Did I miss a reference?
Setup
make clean
make build

Code Review Verification Steps

[x] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

I would like to test this on experimental to ensure the deploy steps aren't messed up. And then I'll be ready to get this merged in.

I deployed this to Experimental and had zero problems. I think its ready to go!


Implement submission to s3

What problem does this pull request solve?
Trello card: https://trello.com/c/ToXPf8zb/
Implement uploading file containing submission data to an S3 bucket specified for a form if the submission_type is s3.
To do this, we assume an AWS role that is defined per environment. We expect the bucket to have granted write permissions for this AWS role.
How to test

Update aws_s3_submissions.iam_role_arn in the settings.yml file to be the ARN of the role with permissions to upload to the s3 bucket in the deploy environment.
Run the forms-api rake task to configure one of your local forms to send submissions to S3:

rake "forms:set_submission_type_to_s3[1, deploy-account-bucket-name, deploy-account-id]"

Start form-runner locally in an authenticated aws shell for the dev environment. This allows the app to assume the AWS role for writing to the S3 bucket:

gds aws forms-dev-readonly -- bundle exec rails s

Submit the form. Check the S3 bucket in the deploy account and verify that a submission CSV file has been uploaded.

Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

I also don't have a bucket to test with so maybe one for @alice-carr to double check?


Expose vcap_services for unit tests and address Ruby version differences

These changes are to modify vcap_services such that it allows for unit tests to provide a custom value.  By default it will use the current test-serivce-n/a as the vcap_services value and use the test-provided vcap_services value when specified by a unit test via a context.

If we want these changes let's submit them to the Java buildpack first. Otherwise, this will diverge us even more from the Java buildpack.


problem running ORB_SLAM2 in the first run

you might error indicating you need to run:
sudo rosdep init
sudo rosdep update
After running these commands in the orb slam pane in the tmux window the problem resolved.

removing support in the demo for orb slam 2


Add usage instructions and how the API works to README

This should be intended for other devs who would like to develop a plugin.

Think this is covered now. Shout if you disagree though and we can  reopen a x update.


GitHub: Use the bot to comment on issues

Description
We should notice issuers when patch or feature request was implemented not to get them such a question https://github.com/files-community/Files/issues/14521#issuecomment-1906866455. Can use files-community-bot we already added in this org.
In addition to that, when a PR that might fix an issue was linked to the issue

When an issue submitted
Hello @0x5bfa, thank you for sharing your feedback with us!
Our team will send a message to triage :thumbsup:

When a patch has been published in a preview release
Thank you for your feedback! This issued was fixed in v3.2.2 :partying_face:
You can try it out by installing preview version of Files.

We should see if there is a way to auto add the issue to the project board.
After a PR has been merged (and an issue closed), the workflow can add a comment saying that the issue has been fixed in main and will be included in the next release.

There is.
When release has been published, the action do regex and comment on all #issues that have been mentioned in the release.


add min / max to mdSelect on multiple="true"

Please add min / max to mdSelect on user Input. Additional option should be disabled if the user tries to add too many values. Thanks!

I didn't understand. On mdSelect?

@marcosmoura yes on mdSelect for multiple="true" select fields and option to select min or max input values. I'll change the title of this issue again

Well. This is not an standard on native  tag. Although it seems to be a good thing to have an 'md-max' option to limit the selection. But I'm not going to do a seamless integration with Vuelidate, for now.

Closing this issue as our focus is on the new 1.0.0 version.


Inclusion of BQI in HEAT

BQI inclusion needs to be done in two ways according to different thresholds and procedures used in the indicator assessment (details can be found in core indicator report). In the Gulf of Finland, Gulf of Riga, Eastern Gotland Basin, Bay of Mecklenburg and Kiel Bay the results are normalized to the scale 0-1, using 0.5 as threshold. In Aland Sea, Bothnian Sea, the Quark, Bothnian Bay, Northern Baltic Proper and Western Gotland Basin no normalization is applied and an EQR calculation can be performed (using 50% acceptable deviation) based on the ET and ES values provided. In areas with normalized values, no EQR calculation is necessary and only final normalization to the common scale of 0.2 width needs to be done.
BQI thresholds and class boundaries to be used:
No EQR calculation, only transfer to equidistant scale of 0.2 width for the following sub-basins:
SEA-004 (Kiel Bay), SEA-005 (Bay of Mecklenburg), SEA-009 (Eastern Gotland Basin, SEA-011 (Gulf of Riga), SEA-013( Gulf of Finland)
using the same class boundaries for all sub-basins
| Best | H/G | G/M | M/P | P/B | Worst
| 1 | 0.75 | 0.5 | 0.33 | 0.17 | 0
EQR calculation, using class boundaries based on 50% acceptable deviation and subsequent normalization step for the following sub-basins:
HELCOM ID | Assessment unit | Best | G/M (ET value) |
SEA-010 | Western Gotland Basin | 6 |  4.0 |
SEA-012 | Northern Baltic Proper | 6 |  4.0 |
SEA-014 | Åland Sea | 6 |  4.0 |
SEA-015 | Bothnian Sea | 6 | 4.0 |
SEA-016 | The Quark | 2.25 | 1.5 |
SEA-017 | Bothnian Bay | 2.25 | 1.5 |
No agreed thresholds and no BQI assessment for HOLAS III in Gdansk Basin, Bornholm Basin, Arkona Basin, Great Belt, Kattegat, The Sound.
BQI confidence estimates need to be provided by data submitter/indicator leads, as these cannot be calculated in HEAT without the necessary detailed information (number of observations, spatial coverage etc.). For HOLAS II, confidence estimates were used based on expert judgement.
Since it is not clear in which areas the BQI will actually be used for the eutrophication assessment in HOLAS III (in HOLAS II only in the Gulf of Riga, Aland Sea, Bothnian Sea, The Quark, Bothnian Bay), it might be helpful to discuss this with Henrik Nygard and Vivi first.

@birgitheyden I guess this is done from my side. HEAT now support reporting of BQI as described above. Do you agree?

@.> @Hjalte Parner @.) I agree that the inclusion of BQI is now included in HEAT and therefore can be moved to done. I noticed issues with reporting of different BQI assessment results and related class boundaries (for ES and EQR) in the configuration file, but perhaps it would be better to open a new issue for this? Otherwise, we could keep this as a reminder to revisit this in detail.
Von: Hjalte Parner @.>
Gesendet: Donnerstag, 7. April 2022 23:28
An: ices-tools-prod/HEAT @.>
Cc: birgitheyden @.>; Mention @.>
Betreff: Re: [ices-tools-prod/HEAT] Inclusion of BQI in HEAT (Issue #13)
@birgitheyden https://github.com/birgitheyden  I guess this is done from my side. HEAT now support reporting of BQI as described above. Do you agree?
—
Reply to this email directly, view it on GitHub https://github.com/ices-tools-prod/HEAT/issues/13#issuecomment-1092215238 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALY5QOF6LELU6TRLGDA3UCDVD5HMJANCNFSM5NKDRIPA .
You are receiving this because you were mentioned.Message ID: @.***>

@birgitheyden, yes please create a new issue for this if its still the case


feature: pin binaries to create proto buffer go code

This PR completes #294 , which was reverted with #295 due to missing code. However, I would like to merge after #299 in order to ensure that the go.mod and go.sum files are properly cleaned.
Fixes #302

Please note https://github.com/delimitrou/DeathStarBench/pull/303/commits/9f883c3a3499013032ad8281b58d0f5cffb70d4f which changes the consul resolver library. The incoming library is an MIT licensed software, so I don't think there should be any problems with the licensing.

Hello @cdelimitrou, I was just wondering about the status of this PR? Is there anything I need to in order to get this PR through?

Please resolve the conflicts above, and then we can accept the PR. Thanks.

Conflicts resolved. @cdelimitrou


Launch Checklist

Step 1: Implement Exercises

[ ] Implement at least 10 problems

See the contributing guide for the details about the format of an exercise.
The short version is:

a test suite
an example solution, named with example (case-insensitive) in the filename
a section in the "exercises" key of the config.json file with the slug, topics, and difficulty level.

The topics can be an empty list, and the difficulty level is from 1 to 10, and can default to 1 until we know more about the exercises.
"exercises": [
  {
    "slug": "hello-world" ,
    "difficulty": 1,
    "topics": []
  }
]

Step 2: Prepare the Track for Launch

[ ] Define test_pattern in config.json
[ ] Add a language icon or logo + attribution
[ ] Write documentation
[ ] Find track mentors

test_pattern
The exercism.io website links to the exercise implementations, so it needs to know how to recognize the filename(s) for the test suite.
The "test_pattern" value in the config.json file should be a string that can be compiled as a regular expression, and which will match on the file or files that comprise the test suite of an exercise.
If the test filenames contain the word "test" (case insensitive) then the "test_pattern" key can be deleted.
Language Icon and Attribution
We try to create a language icon that has the exercism colors, and is recognizably similar to the language icon. Sometimes this isn't possible due to copyright issues.
The Exercism colors are:

#D81D4E (pink)
#212121 (charcoal)

The icon is used throughout the site in order to identify the language track, and to identify code that has been submitted to that track.
See http://exercism.io/languages for all the existing icons.
Icon
If image assets are not your strong suit, just find a reasonable image to start from, along with the information about the licensing, and we'll figure out the colorization thing (I've written some scripts to help me do this part).
The logo should be named icon.png and live under img/ in this repository. If you know how, go ahead and make an SVG as well.
Attribution
The attribution goes in the README.md file.
If the icon we have based this on is not in the public domain, we need to provide information about license and provenance. If we require permission to use and/or change the icon, then we need to obtain that permission before we can use it.
Documentation
The documentation is used in the http://exercism.io/languages/clojurescript section to help people get started with the track.
The files live in the docs/ directory here in this repository, and gets served to the site via the x-api. It should contain at minimum:

INSTALLATION.md - about how to get the language set up locally.
TESTS.md - about how to run the tests for the exercises.

Some nice to haves:

ABOUT.md - a short, friendly blurb about the language. What types of problems does it solve really well? What is it typically used for?
LEARNING.md - a few notes about where people might want to go to learn the language from scratch.
RESOURCES.md - references and other useful resources.

Find Track Mentors
Usually in order to see someone's solution you have to have submitted the exercise yourself. Track mentors can access all of the solutions in a given language. Track mentors can therefore help review solutions that people submit on the website in the beginning when few people have submitted solutions to exercises.
Ideally we should have a handful of people who are willing to check Exercism regularly to give people feedback, in order to start the track off on the right note.
The first track mentor needs to be added manually by @kytrinyx, but after that there's a section in the account where existing track mentors can invite new ones.
The most successful tracks are where each submission receives feedback quickly, preferably within the first 24 hours.
In addition, the most interesting and useful conversations start when reviewers do not direct users to do specific things, but rather ask questions challenging people to think about different aspects of their solution, or explore aspects of the language.
Referencing existing blog posts and style guides seems to work well when making specific recommendations.
Prepare for Open Source Contributions
Once the track is live and active, it will often get new contributions.

[ ] Read the maintainer documentation
[ ] "Watch" the xclojurescript repository
[ ] Find a second maintainer

We've got a few years of experience maintaining language tracks on Exercism. Here's what we have learned:

Maintaining a Track
Reviewing a Pull Request

There's more stuff in the contributing guide, as well. We're working on turning that into better, more focused maintainer documentation.
Step 3: Launch!

[ ] Toggle "active" to true in config.json
[ ] Mention it in the next "Behind the Scenes" newsletter (@kytrinyx)
[ ] Add track mentors on the site (@kytrinyx)
[ ] Add track mainatiners to @exercism/track-maintainers team (any organization owner)

@ballPointPenguin It's been 4 months without any contributions to this track, so I'm going to go ahead and delete it, along with the maintainer team for it.


impl(oauth2): support IMDSv2 in AWS token sources

This is the easiest configuration to implement for AWS token sources.
Part of the work for #5915

This change is

Sorry, I just realized I misread the documentation.  The IDMSv2 case is not the easy case, it is the most complicated case. Sigh... I need to close this.


Cesium integration

No real issue, but more a question about the status:
Is it right that you still need to copy some assets to output folder (copyCesium.js)? Is there any progress in a webpack integration that you know?

The repo at https://github.com/mmacaula/cesium-webpack instructs you to copy Cesium's assets to a folder before you can begin development.  The setup I have in this repo allows you to directly serve Cesium's assets out of ./node_modules/cesium/ during development, and only copy them out to your production build folder as needed.
Not sure what "Webpack integration" you're looking for.  Any specifics?

Ok, I missed the devServer.js part. Hence, you add another static assets folder to your environment. I used the plain webpack-dev-server where I can only set one public path.
Regardig the webpack integration: I had the idea of  loading package like it's done for font-awesome: https://www.npmjs.com/package/font-awesome-webpack
So, you just have one single assets folder where all bundled data is compiled to.

Yeah, my actual app has a number of specific needs for proxying behavior and some other stuff, so I built my own dev server that uses webpack-dev-middleware.  This repo is a stripped-down version of that app's setup.