Japan, the Kuril Islands, Southern Sakhalin, and the Sankaku Islands

I was reading a bit up about Japan and stuff to see what I could do in a Japan playthrough and to see what was represented ingame through either events or decisions.
Getting straight to business, Japan seems to have cores on the southern Kuril Islands in the 1946 start but from what I've read here it seems like Japan claimed Southern Sakhalin and the full Kuril Islands till 1950 in which it signed the San Fransico treaty in which Japan renounced their sovereignty over these territories except for the southern Kuril Islands. Futhermore the treaty also determined that the various minor island groups near Japan were to become U.S. trusteeship, some later on were returned to Japan after a revision by the US and those wo were returned already have cores on them ingame. The treaty also renounces their claims over some more territory formerly part of their empire.
Ingame the situation is different than it was in reality, could there perhaps be an event added which represents the treaty of San Francisco? I would suggest for such an event pop up to have multiple options in which a player could choose which claims he would like to renounce and which not, an option in which the player renounces none of their claims should probably put them far over the infamy limit and depuppet/desphere them so that any other nation could declare war on them or it could immediately start a war between the US and Japan. Either way if Japan loses the war(s) following that event option Japan should only hold cores on their main 4 islands, Ryuku could possibly be made an independent country or be ceded to China in such a situation. Perhaps even in such a situation Hokkaido could be made an independent country because they wanted to weaken Japan even further? Hokkaido beforehand could have had cores and culture similar to Bavaria in Germany but after a containment war like that against Japan it could be made independent and the country could adopt Ainu as an accepted culture, so if later on it became part of Japan again stuff like crisises and rebels would work correctly.
The other options could range from renouncing less cores, renouncing more cores, or renouncing like it was historically was. Renouncing a bit less than historically would probably give some infamy and if the player decides to not renounce even more it should give a hefty amount of infamy (but still not enough to pass the limit), renouncing historically should either give no or a minor infamy loss and renouncing even more should give a greater infamy loss. If Japan renounces their claim over the southern Kuril Islands it should probably give the Soviet Union some prestige and raise relations/influence to show that Japan fears its might (and possibly for a player to easen a Japan commie playthrough attempt), likewise if Japan chooses to not renounce its claims over the full Kuril Islands and Southern Sakhalin (and possibly northern Sakhalin if a player would be allowed to claim that during the renouncing decisions) instead of only the southern Kuril Islands, it should slightly lower the prestige of the Soviet Union and decrease the influence/relation to them.
For gameplay sake, Japan should probably start out with cores on only their 4 islands and they should gain cores on territory depending on the outcome of the San Francisco event instead of starting with cores on all their territory and them losing cores depending of the outcome of the event. It would also probably be better if Japan follows a historical path that it has no cores on the various islands that the US later returns, it would be better if it gains cores on them again when the historical events fire to return them. This to prevent the negative relation modifier for the US owning their cores.
Lastly China has cores on the southern Ryukyu islands ingame and this represents the Sankaku Islands dispute (as far as I'm aware :P), but from what I've read it's not the southern Ryukyu Islands that are disputed but some uninhabited islands close to Taiwan and abover the western part of the Ryukyu Islands. Would it be better if China had no cores starting on the southern Ryukyu islands ingame but that it would gain cores on them through the 'greater China' decision? It would seem that since the islands are uninhabitated they would serve no purpose for vic2 ingame and adding them as a province in game is unnecessary (compared to the south chinese islands which are inhabited).
I will add some pics here later to visually show what I mean with the San Francisco events
The first event would look something like this with the first option following the historical route and the second opening a new event screen to from where to choose various options for an ahistorical route.
The second event would be like this, with the various options giving various amount of infamy.
The reason why the options names are_like_this is because I've named them through the event file and not through the csv file :P

I don't see why the US would want to cede strategic important territory to a potential Communist China, an ally of their foe the USSR. Also the US did not recognize the PRC as legitimate China, but the ROC, so there might be a chance that the US wouldn't ratify the treaty at all.
Otherwise adding some more falvour to Japan sounds awesome. :smile:

I like the idea of making Japan game play more dynamic. Please go ahead and start modding :). I would suggest keeping JAP start cores, and then remove/add them depending on decision.  Provinces with no cores makes scripting a bit tricky. On Japan's "options", remember they start as a US puppet - i.e. they will take the historic route and follow the directives by the US. When creating the 1946 "province owner" it was an alternative to have Japan as US owned directly, like Germany.
Diaoyu/Senkaku Islands (of mod tech reasons south Ryukyu island) drives tension between China and Japan, making the AI behave realistic.
ps. maybe an independent ainu Hokkaido is a bit to much alt-history.

Ah yeah I see, I personally think it was a good choice to make Japan a puppet instead of mkaing it fully US owned. This way a player can play from the earliest startdate as Japan instead of from the second startdate, while we are on the topic of Japan, in #432 I saw that Japan needed a nerf. From the 1946 startdate Japan basically has zero score in both military and prestige while it has a industry score of around 60 which brings it to rank 6 on the industry rank, perhaps the US could own the factories so that those factories don't count towards Japan's industry score? And to make sure Japan doesn't get too high of a score for military, should Japan maybe get a 'disarmed' modifier (the on you get when you lose a great war) for a few years in the beginning of the game?
For Hokkaido, I took the idea from the Republic of Ezo, although the northern island doesn't seem to have any sort of big independence movement nowadays, a Great power could be interested of setting up an independent Hokkaido as a puppet state to weaken Japan (Kind of like a Great power could do to Germany with Bavaria). But like you said Japan was occupied by the US and it was almost in total control of Japan, I will keep that in mind and try to find a balance between historical accuracy and player 'free roam ability'. I will start modding on the event tree I talked about and such but how would you like me to submit my modding so you can review it?

This is what I have so far, the link is to a modified txt file of 'japan.txt'. It has comments on places where it needs text in the cvs file or just notes about what was modified and if it gets approved, I would still suggest that japan only starts with cores on their main 4 islands and that it would get cores on the appropiate islands through the added and modified events. The reasoning behind this would be that Japan renounced their claims on the Ryukyu and other Ogasawara islands in the treaty of San Francisco and they were planned to be included in US trusteeship, instead the US gave them back to Japan anyway since it was in their interest to have a strong democratic ally in the east. This is also why I modified it so that these sialnds will not be granted to Japan if it falls under Soviet influence and becomes a communist country.

Very nice work :+1:

To submit changes - use github - make a pull request with your changes (including for review)
I ran the Validator (please always run the Vice Validator to check your changes before making a pull request). No errors :+1:  beside localization (and pictures needed - I can help with those).

Ah thank you, I actually don't have a lot of experience with using Github so I will probably will need your help later on, but thank you for letting me contribute to this mod.

vice->vic2 Validator
You have your own clone of the repo wher you made your changes. Then here is a description how to make a pull request.
 You do a update on your clone and all is in synch.

Ah oke thank you for the information.
For the vic2 Validator, I actually don't have a paradox account and now that I'm trying to make one I'm having some problems with registering my Steam account. It's already registered while this is my first time on the forums.. But nonetheless I've modded the stuff and it's on my clone repo, everything seems to work but it lacks the validation. I've just done a pull request could you still review it?

Top job :+1: your changes are now in the nwomod master.
I had to manually merge your pull request due to merge conflict of the nwo_events.csv localisation file. Think it was due to your encoding (but not sure). The localization files has to be edited with ANSI encoding.

Here is a link to download the Vic2 Validator v1.13.3 Released: 27 February 2016 (all credits to Jamie550 )

(regenerate history files with no JAP cores)

Yeah, I edited the localizations files through excell since it was the default program it opened them in, now that I see it can open them through Notepad+ too I will use that one from now on, that way I can edit them with ANSI encoding too like you said. Also thank you for the direct download link, my problem with my account is fixed so I should be able to go on the forums from now on.
Btw does the '(regenerate history files with no JAP cores)' indicate something I should/forgot to mod?

You did not forget anything. I just need to also fix the generator as in all NWO files under history is generated by the "Generator", and validate that the generated is compatible with changes.
Will close this issue now. Congratulations your first direct contribution to NWO :+1: .
Looking forward to more :)

Ah I see, well I'm excited to work on future contributiond to this mod!


docs: (IAC-864) Update SAS Viya name in documentation

Changes
Updating the SAS Viya name in the documentation
Note:
The repo's "About" section will also need to change as part of this PR, since that's not controlled by the code I'll put the updated content here. Please review this as well.

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.

Thanks for the review @supear, applied the suggestions from the review comments


Unit functions are not defined for support Fragment or Dialog

The dip, sp, px2dip and px2sp functions are defined for Context, UiHelper and android.app.Fragment but they are not defined for android.support.v4.app.Fragment nor for Dialog.
Is there a reason for this ?

Fixed.


fix some potential issues in Pregel tests

Scope & Purpose
Fix some potential issues in Pregel tests
Some tests considered a Pregel job done if it is not in state "running" anymore. however, after running comes "storing", and checking job results while still storing is too early!
This PR unifies the behavior so tests wait until a job is not in state "running" and not in state "storing".
This is a test bugfix, so it intentionally doesn't have a CHANGELOG entry.

[x] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] This change is already covered by existing tests, such as shell_client.

Unrelated test failure.


LuminaOS-Debian #3

Changes:

remove patches/01-use-luminaos-debian.diff and replace it by a sed-substition in debian/rules
use dpkg-architecture instead of gcc for multiarch detection
fail on missing files when building packages (if any)
install /usr/share/applications/lumina-search.desktop
provide /etc/luminaDesktop.conf fallback configuration

New commits added:

minor fixes in debian/rules
add lumina-info package
install translation into specific packages

The following two in conjunction with #44

move lxpolkit from recommends to depends
add /etc/luminaStartapps

Looks good!


[BUG] rpc call EXPERIMENTAL_tx_status not found

{"jsonrpc":"2.0","error":{"code":-32601,"message":"Method not found","data":"EXPERIMENTAL_tx_status"},"id":96}
request url: https://rpc.mainnet.near.org

It is likely because you are running a version that does not have this endpoint implemented. You can use https://github.com/near/nearcore/releases/tag/1.16.0-rc.2

I use the endpoint URL https://rpc.mainnet.near.org.
I did not run any node.

I use the endpoint URL https://rpc.mainnet.near.org.

Yeah it doesn't support EXPERIMENTAL_tx_status yet

我使用端点URL https://rpc.mainnet.near.org。

是啊它不支持EXPERIMENTAL_tx_status尚未

Why not support  EXPERIMENTAL_tx_status method

The current release of mainnet doesn't have the commit that implements the endpoint. It should be addressed when we do the next release.


Release afs2-model 2.1.13 from develop

The release reason is about #33
Keep the module name afs to give old users and apps, and let they can fix only the installing package name.
Keep deprecate function to remind users, these functions will be disappeared in 2.2

I just tested to go on test-pypi.
https://test.pypi.org/project/afs2-model/
It is fine to install on WISE-PaaS, but some requirements need to be installed from pypi.org.

About long_description view on test.pypi is not support markdown, even adding long_description_content_type. https://test.pypi.org/project/afs2-model/
PyPI.org is already support long_description for markdown since last year. And test is fine.
https://pypi.org/project/afs2-model/
The supervisor reviewed the PR, and he has no other comment.


Bug 1148805 - Do escaping of AVM1 property names before iteratively searching through scopes instead of doing it for each scope over and over again

While it fully works and gets some performance improvements, this is WIP-py in that it could be extended to other operations. f? @yurydelendik on the approach.

/botio test

It might actually make sense to land this as-is: _escapeProperty completely vanishes from all profiles with it, whereas it takes close to 10% of execution time (excluding rendering) without it.

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

src/avm1/interpreter.ts, line 885 [r1] (raw file):
variableName can contain a path to the child, e.g.  '../a', './a/b:prop', 'a.b.proto' -- escaping must be happening to all its parts.

src/avm1/runtime.ts, line 598 [r1] (raw file):
we don't need to name.indexOf(ESCAPED_PROPERTY_PREFIX) !== 0 to avoid name collision when user will specify e.g. __avm1__proto__. (Which also mean we shall never call alToName twice on the same name -- did you have a case when we potentially do that?)

Comments from the review on Reviewable.io

@yurydelendik, I removed the escaping and optimized a few other things. Makes the particle effects test case about 25% faster for me.

/botio reftest

/botio test

Review status: 0 of 14 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

src/avm1/interpreter.ts, line 954 [r1] (raw file):
This comment was not addressed. We can remove it -- the avm1ResolveSimpleVariable logic will call alHasProperty which will normalize the name.

src/avm1/runtime.ts, line 66 [r3] (raw file):
We can remove ESCAPED_PROPERTY_PREFIX

Comments from the review on Reviewable.io

/botio test

/botio test

@yurydelendik, I fixed the SetVariable issue we discussed yesterday in a follow-up patch in #2363.


chore: update logo

Rationale
Update horaedb logo.
Detailed Changes
Test Plan
No need.

Cool! Thank you.


message streams to recieve events from outside of the bot and send to any channel

see discussion in #97

allows registration of MessageStream functions
routes any received Message to the specified ChannelData Channel/Server/Protocol
adds config items Protocol and Server to each bot instance
adds test for MessageStreams to cmd_tests.go

Coverage decreased (-1.3%) to 96.757% when pulling ff83af2de64756bcc11fc560aab430b79f47a5d7 on bnfinet:feature/event_message_stream_channel into 07092db190915888631e58d957b9c5e61e25f845 on go-chat-bot:master.


Allow an optional interface name to be passed to calicoctl container add

Fixes #86

@tomdee thanks, this looks like what I need


Added MieleCloudService

Added MieleCloudService (formerly known as MieleAtHome) to get it into the repo.

Please check your adapter at https://adapter-check.iobroker.in/ and fix the things mentioned there. Also please read over https://github.com/ioBroker/ioBroker.repositories#development-and-coding-best-practices and checks what may be relevant (e.g. storing and clearing timeouts).
Additionally what is obj.isNotNull ?? https://github.com/Grizzelbee/ioBroker.mielecloudservice/blob/master/main.js#L45 ?!

All checked and fixed (as far as I can see). But the AdapterChecker says that travis-ci is still failing - what is not the case. It passes. Maybe it's a travis-ci.com/.org thing.
obj.isNotNull was a leftover from a former contributor, I have overseen. Removed it.

After some Code impovements have been done: May I ASK for another revirew?

Looks ok now. Welcome in the repo.
One Personal side note: Using "node-schedule" just to do something where setInterval or better setTimeout is already capable of feeld unneeded (also I have no idea what happens if I put 120s as Interval ... will node_scheule handle a*/120 correctly? ;-)
In my works it should be enough to use setInterval or much better setTimeout to trigger the next execution and set a new timeout when this one is finished.
The downside of schedule/intervals is that they fire a new call regardles of if the old one has finished. This can lead to DOS like behaviour especially with external/cloud communications because if there are network errors or such that add latency or such could mean that requests pile up and then all fire at the same timepoint ...
Maybe rethink this approach

PS: one additional downside of "scheduler": This about you developed an successfull adapter :-) And most people will most likely not change the default polling interval.
Using the scheduler means that all adapters our there always fire at the same second "*/interval" ... this already could become kind of a DOS behaviour with the external cloud service. I would like see you change it soon :-)

PPS: Makes it really sense that your repo is fork of mieleathome? You should contact GitHub to decouple it ... also because one that has forked mieleathome can not create a fork of your repo

Hallo Ingo,
vielen dank für deine Anmerkungen und Anregungen. Ich weiß das wirklich zu schätzen.
Das Repo habe ich vom ursprünglichen Fork trennen lassen.  ;)
Das mit dem node-Schedule war mir auch schon aufgefallen, ich hatte aber keine gute Alternative am Start. Ich schwenke in der Version 1.0.5 gerade auf setTimeout - danke für den Tip in diese Richtung.

Sag bescheid wenn done dann reviewe ich nochmal. Repo warten bis dahin ist ok für dich?

Ist erledigt. V1.0.5 ist online und ich denke sogar ein Kandidat um in ein, zwei Wochen ins Stable zu kommen.


health monitor method should be of type 'dict' and not 'str'

a10_health_monitor.py
this section:
   method=dict(
            type='str'
        ),

should be:
   method=dict(
            type='dict'
        ),

Which allows access to the http method (and other types) and subsequently a play like this will work
- name: Create A10 Health Checks
  a10_health_monitor:
    a10_host: "{{ a10_host }}"
    a10_username: "{{ a10_username }}"
    a10_password: "{{ a10_password }}"
    state: present
    name: "server_check_6001"
    override_port: "6001"
    method:
      http:
        http: "1"
        http-port: "80"
        http-expect: "1"
        http-text: "OK"
        http-maintenance-code: "503,404"
        http-url: "1"
        url-type: "GET"
        url-path: "/images/test/OK.html"

Thanks for raising this issue up. Recent versions have fixed this. Please re-open if you re-encounter this issue.


yellow selection not correct around string block

When I have a block where I set a variable to a text string, and select the red variable block, the yellow selection only goes around that one, and not around the string block, even though that also is selected and gets copied.

Yeah this is standard Blockly selection behaviour. What get's copied is the entire stack, selection is not meant to indicate the stack but the currently selected block (at least this is the design in Blockly).
I'll keep this in mind for any future discussions around this feature. Thanks


implement SPARQL query to support predicates service

We need to create a map to support this: https://github.com/NCATSTranslator/ReasonerAPI/blob/775f688f86960c4fa27fc6936f0ccff2a7e473ab/TranslatorReasonerAPI.yaml#L30-L55

This query should run at the end of the database build and output some kind of structure to load at web service application startup.

Fixed by #42.


Captive portal: rework logging and RADIUS accounting when disabling a zone or rebooting

Use captiveportal_disconnect_all() instead of captiveportal_radius_stop_all() to disconnect all users, sending complete RADIUS accounting and logging the end of the sessions in the system log.
Since several zones can share the same RADIUS server, send an Accounting-Off packet only when rebooting, not when disabling a zone.
Requires #3300

After some more tests I verified that calling captiveportal_send_server_accounting() before rebooting is not a problem because even if the Accounting-Off packet can cause the server to set a spurious stop time for sessions in a different zone, eventually we're going to call captiveportal_disconnect_all() for each zone, updating the accounting information with the correct values (at least on FreeRadius 2.2.8).
When disabling a zone instead I'm pretty sure it's only safe when there's a single zone, or the zones never share RADIUS servers, and given that in many cases we won't be able to send it, I think it's better just not to send the packet at all and avoid adding more complications.

@plumbeo please rebase your fork

@rbgarga fork rebased

During tests I found that disconnecting all users can take a long time (70 seconds for ~400 active users here), could this interfere with the reboot page (that has a 90 seconds countdown)?

The reboot countdown timer will reset and try again if it expires. It could accidentally redirect the user back to the dashboard if the reboot hasn't happened yet, though.
If it's going to take that much time, maybe we need to consider having this as an option rather than mandatory. There are people out there that have thousands of users on captive portal at the same time, and if the processing time increases that significantly, the fix may be worse than the problem it's attempting to correct.

@jim-p yes, that was worrying me too. Reproducing the problem is hard on a test vm but my best explanation is that the delay is due to the removal of each user's rules, one at a time.
Since that's not something we need to do when rebooting, and there's code that takes care of it in a more efficient manner when disabling a zone, I went back to captiveportal_radius_stop_all(), extended it to log the disconnections and fixed it so that now it sends complete accounting data, including a selectable termination cause.
The new patch seems to work and it took only 3 seconds to disconnect ~380 users on a gateway that was showing the problem with the earlier version of the patch.


Grid-Item not adapting to size of children content

Hi!
First of all thanks for the component, i've started React just to do an implementation of RGL to be used as a component for the Python Framework Dash.
So my problem is that the 'grid-item' does not adapt to the real size of its content. For instance a long text or a Plotly Graph will overflow the container. I'm defining the layout  before render so i guess this is why in my example the content will always overflow, but is there a way to measure  width and height of the child component in render so the container is always on size to the child is receiving as prop?
Thanks!
import React, {Component} from 'react';
import PropTypes from 'prop-types';
import RGL, {WidthProvider} from 'react-grid-layout';
import '../../../node_modules/react-grid-layout/css/styles.css';
import '../../../node_modules/react-resizable/css/styles.css';

const ResponsiveGridLayout = WidthProvider(RGL);

function Handle(props) {
return

;
}

function Y_GridPostion(index) {

    const cols = 4
    if(index + 1 <= cols){
        return 0
    }else if(index + 1 <= cols * 2){
        return 1
    }else if(index + 1 <= cols * 3){
        return 2
    }else if(index + 1 <= cols * 4){
        return 3
    }else if(index + 1 <= cols * 5){
        return 4
    }
}

export default class GridLayout extends RGL {

  constructor(props) {
    super(props)
  }

  render() {
        const {id, setProps, children} = this.props;
        console.log(children);
        const layout = React.Children.map(children, (child, index) =>
                {return {x: ((index + 1) % 4) * 3, y: Y_GridPostion(index) , w: 3, h: 3, i: index, data: child}}
            );

        return (

                <ResponsiveGridLayout rowHeight={30}
                                      onLayoutChange={this.onLayoutChange}
                                      autoSize= 'true'
                                      draggableHandle='.handle'>
                    {layout.map((item) => (

                                <Handle/>
                                {item.i}

                    ))}
                </ResponsiveGridLayout>

        );
    }
}

Hi. The grid is not built for this purpose. I suggest that, after render, you measure the child component's dimensions then adjust the layout to fit. How to do this will be a bit complicated at different screen widths and will involve some math.
As this is not an issue with the library, I will close, but feel free to continue this in the Discussions tab if you have a solution or need more help.

Have you found an easy workaround for this? I am running into the same issue.


Fix typos

This PR's main purpose is the change to line 198. Adding the / to return navigate('/dashboard'); fixes a bug with an infinite loading screen on incorrect routes. The bank app solution also has the / included, so I'm fairly sure this is a typo in the lesson code.

@sinedied could you take a look please? thanks!

Thanks for the fix @TwentyPorts !
And thanks @jlooper for merging, sorry I came in late 😉


Improve batch_normalization performance

Speeding up from 1.6 to 1.8 times in the following test case .
It's tested in branch which PR #548 is merged.
before
0:00:00.312393 0:00:00.204991
0:00:00.321782 0:00:00.205670
after
0:00:00.167545 0:00:00.124970
0:00:00.175646 0:00:00.125602
import datetime

import chainer
import chainer.functions as F

def testbn(shape):
    bn = F.BatchNormalization(shape[0])
    bn.to_gpu()
    x_org = chainer.Variable(chainer.cuda.zeros(shape), volatile=False)
    x = x_org
    t1 = datetime.datetime.now()
    for i in range(200):
        x = bn(x)
    y = F.sum(x)
    y.data.get()
    t2 = datetime.datetime.now()
    y.backward()
    t3 = datetime.datetime.now()
    print(t2 - t1, t3 - t2)

#for memory allocation
testbn((10, 10, 10))
testbn((100, 100, 100))

#for performance test
testbn((10, 10, 10))
testbn((100, 100, 100))

LGTM except the comments.

I fixed.


UI: Fixed the issue with profile picture not showing properly

Describe your changes :

I worked on the fix for profile picture not showing properly on use page

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :

Used Antd Image component to show fallback whenever Image fails to load.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

Can you add a screenshot of your work?


An attribute shouldn't be able to be deleted when it's in use.

There is a block (.e.g. - express_entry_list block) with filtering on an attribute (.e.g. - express_logo_category).
And you delete the attribute which is used on a block filttering, you will get the error on your Concrete.
Doctrine\DBAL\Exception\SyntaxErrorException thrown with message "An exception occurred while executing 'SELECT e.exEntryID, e.exEntryDisplayOrder FROM ExpressEntityEntries e LEFT JOIN CaseExpressSearchIndexAttributes ea ON e.exEntryID = ea.exEntryID WHERE (()) AND (e.exEntryEntityID = ?) ORDER BY e.exEntryDisplayOrder asc LIMIT 1000' with params ["91f2e066-6875-11eb-90be-4f6d39d37ae7"]:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')) AND (e.exEntryEntityID = '91f2e066-6875-11eb-90be-4f6d39d37ae7') ORDER BY ...' at line 1"

So an attribute shouldn't be able to be deleted when there is a filtering on any block with that attribute.
or check if the attribute really exists before apply filtering.

or check if the attribute really exists before apply filtering.

which is-
https://github.com/concrete5/concrete5/blob/988ab81f12a62b2f9cfb58cb4e181b12495e373b/concrete/blocks/express_entry_list/controller.php#L192


Mobile CI/CD need to have the same private key to sign the apk.

The problem is upgrade. Because signature is different, Android blocks upgrade. In order to install new version, we need to uninstall the old one and do fresh install. The data will be lost

@vinayaga07   @jbyrer   @sarawut11
It is done. Currently in the nightly the apk file that will require uninstall the last time.  The next installs you should be able use as upgrades.


DataFrame library

Hi, I would like to see the DataFrame library among the packages available from vcpkg.

We can’t reopen this issue until a PR is opened, unfortunately, consider making a pull request!


Feature request: Add feed option “Always use web view”.

Today we can choose to always open a feed in reader mode. But for news sites with subscriptions this do not work well as it requires to log in. The only way to view the content is to open the web view, which right now adds an unnecessary extra click.
Is it possible to add an option for each feed to “Always open web view” with in-app browser?

I’m using the iOS app

you mean always open reader view?

No, that’s already an option.
I was thinking of an additional option to open in-app web browser view for a feed. This is how I read subscribed news content. Today I click the feed content and have to click one more time to open the web view to read the content as reader mode is not possible for content with paywall. It works, but it’s a bit annoying to not have the option to skip that extra click.
However, an even better solution would be if the open reader view could use the cookie from the web view so the subscribed content is accessible to the reader mode.

The issue is that your ad blockers and privacy extensions won’t run. A Mac in-app browser does not inherit those things from Safari (or whatever browser you use), unfortunately.
To make matters worse, most people wouldn’t notice — because how could they? — that they’re being tracked on web pages viewed in NetNewsWire where their normal browser would block those trackers. It would be bad for privacy.


Fix an eslint_d issue

Changes
Fix an issue eslint_d invokes global ESLint for local project files.

Necessary for eslint then also I guess?!

Found an old branch where it gets merged: https://github.com/neomake/neomake/pull/1844.
Do you agree that cwd should be used for both?

@blueyed
I read eslint-cli source code and diff in the PR above. And I agree that.

Thanks!


feat(helm): add linting support for '.tar.gz' tarballs for helm charts

What this PR does / why we need it:
This PR adds support to lint packaged helm charts with extension .tar.gz.
Special notes for your reviewer:
closes #6535
If applicable:
[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Hi,
What happened with support to tar.gz file?
Thanks,
Dana


HAWKULAR-458 Deployments Detail Screen: Hook up New Agent Operations

using web sockets

@mtho11 this is waiting for the release of UI services.

OK, ready for review and merge now.

Merged #372


An upgrade Idea (wrench)

Just a simple wrench to break the connections next to unwanted inventory space :D

duplicate, is it that hard to use the search function first?

duplicate, is it that hard to use the search function first?


Unhealthy hosts during incident

What:
Ticket is open as Jahir is in talks with AWS regarding this issue.
We need to understand what caused the health checks to fail during the incident between 2:54 and 2:58. Call to be scheduled with AWS to understand this further.
We do not have the visibility of the health check logs.

Reviewed the update from AWS, Raised further queries with them.

opened on Jira


cage pull has cwd problems

What's going on here: Hook scripts need to be run with the working directory set to the project root.

seamus@pirlo:~/fdy/src (master)
$ find . -path "*config/secrets*"
./xxx/config/secrets.yml
./yyy/config/secrets.yml
./zzz/config/secrets.yml
./aaa/config/secrets.yml
./bbb/config/secrets.yml

this is getting scary, i would consider this a critical bug

On it.


Monitor /var/lib/docker to get disk usage stats

It is impossible to cover every usecase here but we can monitor /var/lib/docker as default and that should work for most people.
We could allow the user to specify other volumes to monitor and add them dynamically as new snap tasks.

Closed by 63e08ecab7652dfc0aad508e21b42b5c2299e500


[UI] Support for limiting k8s versions on charts

UI support needed for this ticket: https://github.com/rancher/rancher/issues/29346

closing in favor of : https://github.com/rancher/rancher/issues/29774


Weird bug at python test time for LearnerSCCS

test_LearnerSCCS_coefficient_groups (tick.survival.tests.convolutional_sccs_test.Test) ... libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: thread::join failed: No such process
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: thread::join failed: No such process
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: thread::join failed: No such process
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: thread::join failed: No such process

can you provide some sample code to attempt to reproduce?
dylib is mac thing, so perhaps @MaryanMorel can try to see if he has this issue too

Well, it's all in the master branch and unittest failing related to ConvSCCS (ick.survival.tests.convolutional_sccs_test.Test) which seems to fail...
It's weird that it is not catched on MacOS builds right ?

It's weird that it is not catched on MacOS builds right ?

are you using python3.7?
does your mac still randomly crash?

Yep Python 3.7 it is. My mac is not crashing following  this error.

python3.7 is not built on CI

Do you want me to try reproducing the bug using py 3.7 or is it useless anyway?
Tried few weeks ago, was not able to build using py 3.7 envs in conda

I thought you could build but were getting random segfaults

It's confirmed : no such  segfault when using py36, so it's yet another py37 problem :(

duplicate https://github.com/X-DataInitiative/tick/issues/263


Revert to Bodhi 5 client

Fixes: https://github.com/packit/packit-service/issues/1587
M0ar context: https://github.com/fedora-infra/bodhi/issues/4660
Just that I write this somewhere:

Bodhi 5 is built from SRPM "bodhi" - everything
Bodhi 6 was split into multiple packages, e.g. bodhi-client

RELEASE NOTES BEGIN
We have reverted to Bodhi 5 client since Packit couldn't create bodhi updates with the new version 6 client: https://github.com/fedora-infra/bodhi/issues/4660
RELEASE NOTES END

regate


Add Info Container and Directions

This commit makes the following changes:

Add info container to current selected restaurant
Add directions button that redirects to Maps.
Change icons fetches from http to https

demo: https://jtan-sps-summer20.appspot.com/

Given the nature of how this app will be used, I think it would be more suitable for it to be from where the current device is at, since it would cover most of the use cases.

I pushed another commit but it's not showing..


highlight differences to micro_ros_arduino

It's not clear to me what the differences are between this project and micro_ros_arduino and when I would use one versus the other. I think adding a note highlighting the differences would help others looking at the two projects.
For example
[env:seeed_xiao]
platform = atmelsam
board = seeed_xiao
framework = arduino

lib_deps =
    https://github.com/micro-ROS/micro_ros_arduino#v2.0.5-humble

build_flags =
    -L ./.pio/libdeps/seeed_xiao/micro_ros_arduino/src/cortex-m0plus/
    -l microros
    -D micro_ros_xiao.json

works fine in platformIO. When and why would I use this project instead?

As stated, the micro_ros_arduino is intended to be used with Arduino IDE or Arduino CLI.
micro_ros_platformio is intended to be used with Platform.IO, which can or cannot be related to Arduino.

Okay so just to check if I understand correctly. The practical difference between the two projects It's only a matter of IDE preference. Originally the micro_ros_arduino project provided support for platform io, but now PIO support has moved to this project.
https://github.com/micro-ROS/micro_ros_arduino#platformio

PlatformIO
PlatformIO support for this repository has been deprecated in favor of its own build system: micro_ros_platformio

And for now, micro_ros_platformio only supports the Arduino framework running on bare metal with no RTOS, but in the future, it could potentially support NuttX, FreeRTOS, and Zephyr.


Image 1 for README

this is not an issue, but one misused to upload an image as a static file to GitHub as this seems to be a common way to go about this.


Update selenium-java to 4.1.3

Updates org.seleniumhq.selenium:selenium-java from 3.141.59 to 4.1.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.seleniumhq.selenium", artifactId = "selenium-java" } ]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #121.


make Class Error accesible

Pull Request
What does this PR do?
Solves issue #292
PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thanks for the feedback! , I got the test running for the getter and setter:

I also changed the 'Error' class to 'UpdateStatusError', on its own file and every test passes now:

Hope this fixes the issue now, I'll be around for anything else :) Thanks!

I discovered I was having issues with the formatting, I ran the lint script:

and also the integration tests and it's working fine for me:

Thanks in advance for your patience, regards.

bors merge


add initial action to update the image digest

add initial action to update the image digest

sample run: https://github.com/cpanato/testing-ci-providers/pull/73 and action run https://github.com/cpanato/testing-ci-providers/runs/6022569532?check_suite_focus=true

@mattmoor i will open a pr to enable that


Video Challenges not marked as completed

After finishing a video challenge, the green check mark does not appear on the Map or on the challenge itself.

Duplicate of #6775 and  #6929


Better way to handle file errors

Right now for example a file is skipped if either the version or the protected status fails. However what if one fails and the other succeeds, it would be good to show this info.
So Maybe for the version if that fails show ?.? Or "Unknown", and if the protected status fails show a question mark icon?

I'm marking this closed as of 5fc8763, it will not display it in th UI (but log it) if it fails to get any version information.
If it fails to retrieve protected information it will have some info notes based on the version etc.


Bootstrap 3 Migration

I would like to read some opinions about whether migrating to Bootstrap 3 is something we should have a look into. Also if you have any interesting links that cover the topic please post them here.
Here are some links to start with

Bootstrap 3 for IE7 (Beta)
Bootstrap 3 migration guide
Bootstrap 3 Showcase

Both the frontend and backend are now using bootstrap 3.2.0. So I'll close this then :-)


Upload "fuzzy" versions to NRDB - NEWRELIC-7720

Overview
As part of "Version Pinning" MMF, this PR introduces a naming scheme that will "overwrite" in NRDB on each publish.

A "latest" minor on a major version --> 1.x.x
A "latest" patch on a minor version --> 1.230.x

-- note --
The "fuzzy" versions above only generate when running npm run cdn:build:prod which is the script tied to building production code.

Related Issue(s)
NEWRELIC-7720

Testing
Uploading of these assets has been manually validated at the "science" endpoint for RPM Grape.  A "dev" path in upload-to-nr.js was added to represent that.

⚠ This needs confirmation from API-E that the API changes have been deployed to production before merging


Simple refactorizations.

Assalamu Alaikum
This PR contains simple refactorizations, mostly recommended by ESLint. It's a basic starting point for me to delve into something a little deeper and help contribute.
It contains, as the commits note:

Removing of px or % qualifiers on values of 0 throughout .scss files. (@b13826e)
Replacing of var with const when it makes sense to do so (same with let -> const). (@4e6ea55)
Add/remove semicolons where it makes sense to do so. (see commit from note 3)
General style considerations. (see commit from note 3)

P.S. I've not done proper local testing with this yet -- having some issues with setting up a local environment right now, and a little busy with work preventing me from solving that. Just wanted to get this PR up. Hopefully CI can give us the confidence we need.

Deployed to: http://staging.quran.com:32847

I think changes to server.*.js are causing the staging environment to break and are probably unwarranted.

Deployed to: http://staging.quran.com:32848

Undoing those changes fixes it.


add initial state to default CESM driver builds

Currently there is no default initial state used in building the CESM driver at 50km and 25km resolutions. We need to have this as the default so that other groups running RASM will be starting VIC5 using the appropriate statefile rather than doing a clean start.

Closed via #871


update for Equinix support

update code for https://github.com/sustainable-computing-io/kepler-metal-ci/pull/27
it seems we need to update code for

restart docker service
reset path dir
reduce test case for git rate limit and as we are going to deprecated local ebpf support.

a part of https://github.com/sustainable-computing-io/kepler-action/issues/123

merge as it is.


added sort inbuilt c++ function

Description of Change

Added sort inbuilt C++ function defined in the algorithm header. Examples are provided depicting the use of comparators in std:: sort function.
Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:
The issue

These and similar implementations are already being used for assertion of self-implementated algorithms.
This is well-documented and well-written code but I vote to closing this as no algorithm was implemented.
@ayaankhan98 @deadshotsb @StepfenShawn @cclauss Inputs are welcome.

it's just an example of how to use std::sort which is actually not required here, we can close this.


Why the pitch always -90

I print the pitch value, it always -90. How to fix it?

Sorry for the late reply
I did not face this problem during development. But sometimes when I left my head from the camera and came back, the angles will be off quite far, in which I had to restart the application.
Maybe you can try tweak the algorithms in the pose_estimator.py (in the init part). But sorry that I cannot offer any good sounding assistance

@lzghades
Hi,there!
I want to ask whether you solve this problem? I also have such a problem, but I don't know how to solve it.
Thank you for reply!

I also encountered this problem, did you solve it?


Use exponential backoff with jitter

What should be done?
We should use exponential backoff with jitter in places where we wait for something.
See https://aws.amazon.com/ru/blogs/architecture/exponential-backoff-and-jitter/
Where?
Places that use ctxutil.Sleep, time.Sleep, context.WithTimeout, etc.
Definition of Done

no new external dependency;
unit test for math added;
spot refactorings done.

Hey @AlekSi I would like to try my hands on this issue.
I have a few questions after reading the linked blog post.

How high should the backoff cap be? 500ms, 1s, 60s?
Is there a preference between full jitter and decorrelated jitter for FerretDB?
Should the attempt count be tied to the context or a global attempt count?

Let’s make it a constant with a value of 1 second. We could tweak it in a single place later.
No preference :)
There should not be any global variables.

Thank you!

I think we have a bug in the current code, or at least code comment is incorrect. It says "The minimum duration is at least 100 milliseconds", but we return a random number in [0; lowestValue) range, that could be even zero: https://github.com/FerretDB/FerretDB/actions/runs/4886789241/jobs/8722599105?pr=2564

That is strange, because 100*2^0 (first try) = 100. math.Min should then select the lowest of the two numbers. 1000ms (1s is used in the test) or a minimum of 100ms (the base value).


Refactor CLI to use ArgumentParser

Use the Swift ArgumentParser library rather than parsing available in
SwiftToolsSupport. Remove the dependency on SwiftToolsSupport where not
needed any more (still needed in SwiftCWrapper for the progress bar).
Remove old rpath workaround as that bug is now fixed.

@swift-ci please test

The swiftc wrapper was still passing "swiftc" rather than "--" to the stress tester. Tests were still checking for "swiftc" so passed fine :(
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - b80a88b602a6e8f971dbb499a1071b87ff3088dd

isCompilerCrash was being checked before isError, resulting in an assert firing in sk-stress-test. I'm unclear how this isn't happening on the main CI job though.
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 1db8c2328ea2ff67370130a43d3f30194a95b65e


Fix performance custom metrics

Resolves #1
Noticed performance custom metrics were not getting logged in out CI tests.
This was because the current logic was as follows:
          try {
            wpt_custom_metrics[`_${metric_name}`] = JSON.parse(wpt_custom_metric);
            if (metrics_to_log.includes(metric_name)) {
              wpt_custom_metrics_to_log[`_${metric_name}`] = JSON.parse(wpt_custom_metric);
            }

          } catch (e) {
            wpt_custom_metrics[`_${metric_name}`] = wpt_custom_metric;
          }

That says only log metrics we're interested in if JSON.parse succeeds.
However, many metrics are returned as Objects rather than JSON and so JSON.parse fails (as it doesn't need to be parsed as it'a already an object!), and others aren't valid JSON as just plain strings. In both cases the if (metrics_to_log.includes(metric_name)) { part isn't called and they are excluded from the output.
This PR refactors to move code out of the try to log in both cases.

Test websites:

https://example.com/
https://exploreti.com/

Thanks @tunetheweb
Do you know why are some metrics wrapped into JSON.stringify and others not?

Thanks @tunetheweb
Do you know why some metrics are wrapped into JSON.stringify and others not? Would anything change in BQ if we drop JSON.stringify?

Some of the custom metrics call JSON.stringify() in the return (example for media custom-metric) and some don't (example for performance custom-metric which just returns the object directly).
Mostly it doesn't matter, and Web Page Test will handle both and stringify() automatically when it needs to store them (e.g. when saving to it's Database).
However, one place it CAN matter is if you're running the code in the console to test it. You can get unexpected results if you're not stringifying it. See long conversation on this here: https://github.com/HTTPArchive/custom-metrics/pull/113#issuecomment-2043937823
Probably we should standardise this and update all the custom metrics to JSON.stringify() the final return so we don't have this inconsistency. But in meantime this works.

Updated PR to add the comment to explain why.

Probably we should standardise this and update all the custom metrics to JSON.stringify() the final return so we don't have this inconsistency. But in meantime this works.

@tunetheweb so maybe we rather wrap performance CM (and other metrics that have the same issue) in JSON.stringify?

Yeah we probably should. But I think we'd still want to keep this change in anyway incase a future metric was added without it, of some of the non-JSON custom metrics can also return invalid JSON (and converting those to JSON is a bigger job with bigger implications).
Plus it's more efficient (calls JSON.parse only once).
So not super urgent IMHO once we merge this.

I think this PR makes these tests more similar to the events processing logic.

I think this PR makes these tests more similar to the events processing logic.

Not sure what you mean? And if you are saying that was a good thing or a bad thing 😀

Oh very similar! Nice find. OK merging this.


When passing user_data per documentation it does not handle undefined values

https://developers.facebook.com/docs/marketing-api/conversions-api/guides/gtm-server-side
Documentation suggest passing hashed user data as user_data.email_address, etc.
When this data is undefined/null on web container, it does not get removed from server side capi call, instead undefined gets hashed.
Workaround is to use x-fb-ud-em, etc.

It is there for null but not undefined
function hashFunction(input){
  if(input == null || isAlreadyHashed(input)){
    return input;
  }

  return sha256Sync(input.trim().toLowerCase(), {outputEncoding: 'hex'});
}

One could rewrite that first line to handle undefined

Looks like this is resolved incommit e4ebdf48fdfee975755614579e9664be7876a235


BatchNormalization error with keras

Hello,
I use keras and tensorflow backend and ran into error with the follow code:
seq.add(LSTM(256,
input_shape=(length, dim),
activation='tanh',
return_sequences=True))
seq.add(BatchNormalization(
mode=0,
axis=1))
the eroor message is:
File "D:\SciSoft\Anaconda3\envs\tensorflow\lib\site-packages\tensorflow\python\framework\constant_op.py", line 165, in cons
tant
tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape, verify_shape=verify_shape))
File "D:\SciSoft\Anaconda3\envs\tensorflow\lib\site-packages\tensorflow\python\framework\tensor_util.py", line 441, in make
_tensor_proto
tensor_proto.string_val.extend([compat.as_bytes(x) for x in proto_values])
File "D:\SciSoft\Anaconda3\envs\tensorflow\lib\site-packages\tensorflow\python\framework\tensor_util.py", line 441, in
tensor_proto.string_val.extend([compat.as_bytes(x) for x in proto_values])
File "D:\SciSoft\Anaconda3\envs\tensorflow\lib\site-packages\tensorflow\python\util\compat.py", line 65, in as_bytes
(bytes_or_text,))
TypeError: Expected binary or unicode string, got 1
if I set mode = 2, then everything is fine. If remove seq.add(BatchNormalization)), it also works smoothly.
no idea the problem is with tensorflow or keras.
I tried keras from 1.1.2  to 1.2.2, same error happens.
I am using tensorflow 1.0.0rc2 and Anaconda 4.3.0 on Windows 10
anyone can help me?
thanks a lot

@fchollet, could you take a quick look. @zero2hero2020, could you try it with the non-tensorflow backend perhaps?

@aselle I tried Theano backend and it is ok. It only ran into error when using tensorflow backend

It looks like axis is expecting a tensor, and it is getting a literal 1. Maybe try axis=np.array(1)?

@aselle I tried axix=np.array(1) and got the same error message

Can you provide a short self-contained script to reproduce your issue?

@fchollet
from keras.models import Sequential
from keras.layers import LSTM, BatchNormalization, Dense
seq = Sequential()
seq.add(LSTM(256,
input_shape=(30, 512),
activation='tanh',
return_sequences=True))
seq.add(BatchNormalization(
mode=0,
axis=1))
seq.add(LSTM(32))
seq.add(Dense(1, activation='sigmoid'))

Thanks for the reproducible test case that @fchollet requested.

Hi zero2hero2020,
I cannot reproduce your issue. But here's what you can do:

I recommend that you use the following more modern model definition style:

import keras

inputs = keras.layers.Input(shape=(30, 512))
x = keras.layers.LSTM(256, return_sequences=True)(inputs)
x = keras.layers.BatchNormalization(axis=1)(x)
x = keras.layers.LSTM(32)(x)
outputs = keras.layers.Dense(1, activation='sigmoid')(x)

I recommend that you install and use the Keras 2 API, available via the keras-2 branch of the Keras repo: https://github.com/fchollet/keras/tree/keras-2

Hi, fchollet, thanks for your advice! I will try it.

Closing due to lack of activity.


[OSD-9771] Updating image to fix CVE

This PR addresses requirement of OSD-9771.
Before: 3 medium vulnerabilities
After: Security Scan Passed
Remarks for reviewer:

go mod tidy was broken so updated dependency for operator-custom-metrics to 0.4.2. This required change in main.go file too as make test was failing. Operator startup was fine after the change.
Boilerplate files updated using make boilerplate-update
Kept the image to be registry.access.redhat.com/ubi8/ubi-minimal:latest itself for now but the update is from 8.4 to 8.5 version.

Codecov Report

Merging #105 (d192c9c) into master (a62d2bc) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   32.94%   33.00%   +0.06%
==========================================
  Files          14       14
  Lines         513      512       -1
==========================================
  Hits          169      169
+ Misses        342      341       -1
  Partials        2        2

Impacted Files
Coverage Δ

cmd/manager/main.go
0.00% <0.00%> (ø)

As it was my first time testing an RPO change, I tried to be pretty thorough test by building the registry catalog and deploying the latest RPO via that, which worked successfully. I then created a couple of test SubjectPermission resources to verify that RPO created the correct clusterrolebinding and rolebinding resources, which it did.
I also verified that the built RPO image contained no critical or high vulernabilities.
So this all looks good to me.
I'll put a hold on it but feel free to unhold when you're ready and want to validate this in staging.

/hold
/lgtm

Thanks for reviewing and testing Matt ! Will unhold the PR for now.
/unhold


There are no items to display

When I try to search some kata, I most of the time get this message - "There are no items to display".

telbar
Windows 10
Google Chrome
83.0.4103.61

Maybe you have no languages selected in your training setup?


Creating a creative molecular assembler

please make a creative molecular assembly

?

In AE2, make a creative molecular disruptor


Fix go-swan appUpdate API

Current coverage is 43.86% (diff: 100%)

Merging #254 into master will decrease coverage by 0.18%

@@             master       #254   diff @@
==========================================
  Files            11         11
  Lines          9000       9000
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3965       3948    -17
- Misses         3990       4011    +21
+ Partials       1045       1041     -4

Powered by Codecov. Last update f8706a5...733fa88


Use standard options

Use standard options.  Requires fix to vsix to use deployed fsharp.core.dll

@vasily-kirichenko I thought this didn't compile for you?

It compiled, but exp instance crashed due to wrong fsharp.core version. @KevinRansom fixed the vsix issue, so it's ok now.


fix consumeTimestamp and wrong consumeTimestamp exception message

When I want to consume message,I use the following code,
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
consumer.setConsumeTimestamp("2017_0422_235500");

and I got the tip,
Exception in thread "main" org.apache.rocketmq.client.exception.MQClientException: consumeTimestamp is invalid, YYYY_MMDD_HHMMSS
See http://rocketmq.apache.org/docs/faq/ for further details.
	at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.checkConfig(DefaultMQPushConsumerImpl.java:661)

The right answer is yyyyMMddHHmmss but the response is YYYY_MMDD_HHMMSS,I think the tip is misleading our judgments.

Coverage decreased (-0.1%) to 30.835% when pulling 1544413fba427b5610cc8672a9546c2f55ce141b on lindzh:fix_consume_time into fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master.

Coverage decreased (-0.1%) to 30.835% when pulling 1544413fba427b5610cc8672a9546c2f55ce141b on lindzh:fix_consume_time into fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master.

Hi, Thanks for your contribution! But, could you please rename the title, like, [ROCKETMQ-XXX]?
Also, you should create an issue at https://issues.apache.org/jira/browse/ROCKETMQ/?selectedTab=com.atlassian.jira.jira-projects-plugin:issues-panel.

Thanks for vsair's advice to get more familiar with the apache way.

IMO,if we could polish here. we 'd better tell what's wrong with your input and what's a valid input ,right ?

@lindzh This is PR is merged. you may close this PR now


Allow for vendoring the kubesec.io client.

Thought it may be interesting to allow for vendoring the kubesec.io client. It can be useful in other projects, a couple of which  - wild ideas mostly - came to my mind when I first saw this (we can of course chat further about those if you'd like).

Hi @bmcstdio
One use case I have in mind is an admission controller configured with a CRD that would reject/alert based on Kubsec score.
Thanks for the refactoring

@stefanprodan that's exactly my idea :) I don't have all that many free cycles as of lately, but I'd like to participate on that. Let's discuss further. I'll DM you.

@bmcstdio I have a working version of the admission controller here https://github.com/stefanprodan/kubesec-webhook


fix: documentation around default os disk size

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify: doc comment update. no behavior change

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR -- this can ship in SDKs with the next AKS API

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

seems go sdk considers this breaking? is it really breaking? it's a doc update. I understand SDKs technically require generation but there's no user-facing change here.

seems go sdk considers this breaking? is it really breaking? it's a doc update. I understand SDKs technically require generation but there's no user-facing change here.

@alexeldeib The problem is autorest compose failed because you need to update all the descriptions. If there are two models with the same name but different description then autorest will fail.

@alexeldeib The problem is autorest compose failed because you need to update all the descriptions. If there are two models with the same name but different description then autorest will fail.

Is it possible for me to fix this? or do we ignore this type of failure? Not sure I understand what to do

Is it possible for me to fix this? or do we ignore this type of failure? Not sure I understand what to do

Error: '$.definitions.ContainerServiceOSDisk.description' has incompatible values (---\n>-\n OS Disk Size in GB to be used to specify the disk size for every machine in\n this master/agent pool. If you specify 0,
it will apply the default osDisk\n size according to the vmSize specified.\n,
---\n>-\n OS Disk Size in GB to be used to specify the disk size for every machine in\n this master/agent pool. Defaults to 128 if unspecified,
zero,
or negative.\n)
See lint Error https://github.com/Azure/azure-rest-api-specs/pull/12428#issuecomment-759876725 . You'd better search all the description related to this change, or SDK will fail to generate.

Error: '$.definitions.ContainerServiceOSDisk.description' has incompatible values (---\n>-\n OS Disk Size in GB to be used to specify the disk size for every machine in\n this master/agent pool. If you specify 0,
it will apply the default osDisk\n size according to the vmSize specified.\n,
---\n>-\n OS Disk Size in GB to be used to specify the disk size for every machine in\n this master/agent pool. Defaults to 128 if unspecified,
zero,
or negative.\n)
See lint Error https://github.com/Azure/azure-rest-api-specs/pull/12428#issuecomment-759876725 . You'd better search all the description related to this change, or SDK will fail to generate.

You'd better search all the description related to this change, or SDK will fail to generate.

This is what I don't understand. Do you mean to change the description in all API versions? The new description is not accurate for the four oldest API versions, the old one is correct: 2016-03-30, 2016-09-30, 2017-01-31, and 2017-07-01.
Would updating the default value of the integer field in the swagger be considered breaking as well? If we did that instead, we could align all the descriptions, but only add the correct default to the field definition, not the description.

You'd better search all the description related to this change, or SDK will fail to generate.

This is what I don't understand. Do you mean to change the description in all API versions? The new description is not accurate for the four oldest API versions, the old one is correct: 2016-03-30, 2016-09-30, 2017-01-31, and 2017-07-01.
Would updating the default value of the integer field in the swagger be considered breaking as well? If we did that instead, we could align all the descriptions, but only add the correct default to the field definition, not the description.

Just to be extremely clear: the behavior of all API versions remains the same. After 2017-07-01, AKS changed the behavior of this API. At that point the description should have been updated and we should have gone through proper review (as necessary).
Given that we've had these APIs with the same behavior for ~3 years, I'm hoping we can consider this a doc "bug fix". There's really no change occurring, we're just updating the descriptions in the OpenAPI model to reflect reality as it has been for several years.

Just to be extremely clear: the behavior of all API versions remains the same. After 2017-07-01, AKS changed the behavior of this API. At that point the description should have been updated and we should have gone through proper review (as necessary).
Given that we've had these APIs with the same behavior for ~3 years, I'm hoping we can consider this a doc "bug fix". There's really no change occurring, we're just updating the descriptions in the OpenAPI model to reflect reality as it has been for several years.

@alexeldeib In tag package-2020-09, you have the description here unchanged which is causing the compose error.
specification\containerservice\resource-manager\Microsoft.ContainerService\stable\2020-09-01\managedClusters.json has a model called ContainerServiceOSDisk, and specification\containerservice\resource-manager\Microsoft.ContainerService\stable\2020-09-01\managedClusters.json also have one called ContainerServiceOSDisk. These two swaggers are included by the same tag package-2020-09, therefore these two models must be exactly the same to make autorest work properly.
Now you might have three options to work this around:

make the description align with each other
change one of the model name
remove one of the swaggers out of this tag

I believe the first option is the one that makes least destruction. Option 2 introduces swagger breaking changes and SDK breaking changes (if there are any). Option 3 introduces SDK breaking changes.
And this is only for tag package-2020-09, autorest exits early since it gets an error when processing this tag. We have 10+ tags unchecked yet.

@alexeldeib In tag package-2020-09, you have the description here unchanged which is causing the compose error.
specification\containerservice\resource-manager\Microsoft.ContainerService\stable\2020-09-01\managedClusters.json has a model called ContainerServiceOSDisk, and specification\containerservice\resource-manager\Microsoft.ContainerService\stable\2020-09-01\managedClusters.json also have one called ContainerServiceOSDisk. These two swaggers are included by the same tag package-2020-09, therefore these two models must be exactly the same to make autorest work properly.
Now you might have three options to work this around:

make the description align with each other
change one of the model name
remove one of the swaggers out of this tag

I believe the first option is the one that makes least destruction. Option 2 introduces swagger breaking changes and SDK breaking changes (if there are any). Option 3 introduces SDK breaking changes.
And this is only for tag package-2020-09, autorest exits early since it gets an error when processing this tag. We have 10+ tags unchecked yet.

thanks for pointing out the mismatch between files in the same package tag. I totally missed that it was across individual files. 🤦♂
think that should fix it, unless I missed the same elsewhere

thanks for pointing out the mismatch between files in the same package tag. I totally missed that it was across individual files. 🤦♂
think that should fix it, unless I missed the same elsewhere

this won't really be accurate, because we mix and match container service 2017-07-01 with managed clusters versions where the behavior changed. The description mismatch for example for package-2017-09 between 2017-07-01/containerService.json and 2017-08-31/managedClusters.json is correct.
I guess we should technically create a new definition, e.g. ManagedClusterOSDisk and have that use the new behavior description. But that is really a breaking change on the SDK side.
WDYT?

this won't really be accurate, because we mix and match container service 2017-07-01 with managed clusters versions where the behavior changed. The description mismatch for example for package-2017-09 between 2017-07-01/containerService.json and 2017-08-31/managedClusters.json is correct.
I guess we should technically create a new definition, e.g. ManagedClusterOSDisk and have that use the new behavior description. But that is really a breaking change on the SDK side.
WDYT?

Is it OK to remove the problematic tags from "batch" in readme.go.md so that will not get generated? And maybe we need to tell lint not to run some tag ...

Is it OK to remove the problematic tags from "batch" in readme.go.md so that will not get generated? And maybe we need to tell lint not to run some tag ...

/azp run

/azp run

I think I figured out how to fix this. I can add a new version of containerservice which is a copy-paste of the current one, but align the description. Then update the generation directives for managedClusters.json version >= 2018-03-31 to use the new container service api.

I think I figured out how to fix this. I can add a new version of containerservice which is a copy-paste of the current one, but align the description. Then update the generation directives for managedClusters.json version >= 2018-03-31 to use the new container service api.

Does that fix makes sense to your team...?

Does that fix makes sense to your team...?

@alexeldeib close this PR for no activity. Please comment if you want to resume your work.


[1.3] Updates needed on EVSE XML & Device Energy Management - to use new types, and clean up other comments with optional XML.

Reproduction steps
EVSE XML follow up issues based on PR: #30581

Please ensure a follow-up issue is filed to add the energy-mWh, amperage-mA, etc types to the XML definitions.
For what it's worth, "max" is ignored here for readonly attributes, and the "is nullable and of type epoch_s" defines that max anyway. It doesn't hurt things, other than visual noise, but is not needed either. Spec does not have it (because it's part of the type already).
-This is the default; does not need to be explicitly listed, but ok to do it:

<access op="invoke" privilege="operate"/> -

There is no "side" for events, right? All events are server-side....

<event code="0x0000" name="EVConnected" priority="info" side="server" apiMaturity="provisional">

Bug prevalence
N/A
GitHub hash of the SDK that was being used
Will need to be fixed in 1.3
Platform
core
Platform Version(s)
N/A
Type
Spec Compliance Issue
Anything else?
No response

When trying this - I get ZAP tool errors.
(SELECT
DATA_TYPE_ID
FROM
DATA_TYPE
WHERE
DATA_TYPE.PACKAGE_REF IN (2)
AND DATA_TYPE.NAME = ?)), values: ChargingTargetStruct,153,ChargingTargetStruct,ChargingTargetStruct,153,AddedEnergy,2,false,false,0,,false,false,true,false,,energy_mWh, Error: SQLITE_CONSTRAINT: NOT NULL constraint failed: STRUCT_ITEM.DATA_TYPE_REF
(after doing a rm -rf ~/.zap)

There seem to be multiple areas where these new types need to go.
e.g. searching for epoch_s finds things in:
examples/common/pigweed/rpc_services/Attributes.h
examples/common/pigweed/protos/attributes_service.proto
scripts/py_matter_idl/matter_idl/generators/type_definitions.py
scripts/py_matter_yamltests/matter_yamltests/constraints.py
scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/endpoint_config.h
src/app/zap-templates/common/override.js


Reference Time Series link on Help Pages broken

On this help page: https://help.hydroshare.org/hydroshare-resource-types/time-series/  where it says:
This page describes the Time Series resource. To learn more about HIS Referenced Time Series, click here (https://help.hydroshare.org/hydroshare-resource-types/his-referenced-time-series/).
The https://help.hydroshare.org/hydroshare-resource-types/his-referenced-time-series/  link is broken and returns witha 404 Page not found error.  Not sure where the real page is that it should point to.

The page has been removed. I have a local copy of the page in case HIS referenced time series return as an option.


Memory Leak iOS

Update: I lied, this only happens on the simulator.
Steps to reproduce

Have Camera component on a view
Open the view using a push
Navigate back to parent view
Re-navigate to the view with the Camera page and if you have a scrollable view inside that camera view with low opacity and scroll it you can see the same view behind it from the leak.

Expected behaviour
It should destroy the camera upon component unmounting
Actual behaviour
It retains the camera and the entire view.
Environment

Node v5.11.1
RN 0.32.1
react-native-router-flux
iOS 9.2

react-native-camera
Version: "master"

+1

+1

+1 on iOs 10.0 too

+1
iOS: 10.1.1
React: 15.4.1
React-native: 0.39.0
React-native-camera: master on git


update goth to add pkce support

fix https://github.com/go-gitea/gitea/issues/21376
credit to @zeripath for the PR to goth

I think we need to add a few more things to our openconnectid to hook it in

CI is failing...
from the logs:
Please run 'make tidy' and commit the result

CI failure still related, likely due to the changes in assets/go-licenses.json

Any update on this?

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Might want to update to v1.75.1.

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

@mhkarimi1383
You could try this image docker.io/wolfogre/gitea-dev:pr21426, please note that it's for testing only.

I think we need to add a few more things to our openconnectid to hook it in

What did you mean? Should we have more changes in this PR?

Yes, AFAIU we will need some more things in the openconnectid code to ensure that the PKCE stuff is hooked in.

If you can give me a test docker image I can test it for git.karimi.dev (I have LogTo and gitea)

@mhkarimi1383
You could try this image docker.io/wolfogre/gitea-dev:pr21426, please note that it's for testing only.

@wolfogre
the problem persist
gitea       | 2022/11/09 21:08:56 [636ba668] router: completed GET /user/oauth2/Logto for <IP_ADDRESS>:0, 307 Temporary Redirect in 3.6ms @ auth/oauth.go:801(auth.SignInOAuth)
gitea       | 2022/11/09 21:08:56 ...rs/web/auth/oauth.go:860:SignInOAuthCallback() [I] [636ba668-2] Failed OAuth callback: (invalid_request) Authorization Server policy requires PKCE to be used for this request
gitea       | 2022/11/09 21:08:56 [636ba668-2] router: completed GET /user/oauth2/Logto/callback?error=invalid_request&error_description=Authorization%20Server%20policy%20requires%20PKCE%20to%20be%20used%20for%20this%20request&state=39f9aeb6-70d4-4724-aa4b-7674620d762c&iss=https%3A%2F%2Fauth.karimi.dev%2Foidc for <IP_ADDRESS>:0, 303 See Other in 2.6ms @ auth/oauth.go:835(auth.SignInOAuthCallback)
gitea       | 2022/11/09 21:08:57 [636ba669] router: completed GET /user/login for <IP_ADDRESS>:0, 200 OK in 4.5ms @ auth/auth.go:152(auth.SignIn)

Any updates?

conflicts resolved

Any updates?

I haven't had any time to do the work to add the PKCE code in.

conflicts resolved

Looks like it's a blank PR now

But issue for PKCE Persist


chore: Add some integration tests

Commented out the integration tests until this pr gets reviewed and necessary Github secrets are added.

Just as an FYI there's some changes on main we need to make that mean we should hold off for the time being on merging this. I'll comment when that's done.

@rlinehan - Thank you for the heads-up! If this looks good, auth tokens need to be added to Github secrets to run the tests successfully, so this can wait.

@poppoerika ok, you should be fine to go now. it looks like github may have handled the version history change automatically, but let me know if you have any problems/if it says at all that you can't merge do to conflicts.

I think while this pr may work ok, you may want to run the following:
git checkout main
git fetch origin
git status main

if this says something like
On branch main
Your branch and 'origin/main' have diverged,
and have 2 and 2 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

nothing to commit, working tree clean

then you'll want to do
git reset HEAD~2 --hard && git pull --ff-only
git checkout chore/addSomeTests
git rebase main
git push origin HEAD

(you will probably need to do git push --force origin HEAD on that last one)
This is all because we had to mainly reset the git history on main 😭 . Sorry for the trouble and let me know if you have any questions!

@rlinehan - I followed the above instructions!


Fix/add erc721 safe mint safe transfer from #1736

Hi guys,
This addresses issue #1736.
This is my interpretation of the solution, let me know if it looks ok.
If it does, I will move forward implementing tests. However, before I modified any file I tried running the tests for ERC721.test.js.  When I ran npm test test/token/ERC721/ERC721.test.js I got this error:
1) Contract: ERC721
     "before each" hook for "returns the amount of tokens owned by the given address":
     Error: Returned error: VM Exception while processing transaction: invalid opcode

I noticed ERC721.test.js that imports a ERC721Mock.sol from artifacts, which I didn't see in the contracts nor build directories. Also, running npm test test/token/ERC721/ERC721.test.js prompted a different error:
ReferenceError: e is not defined
    at async.whilst.fileFinished (/usr/local/lib/node_modules/truffle/build/webpack:/packages/truffle-compile/profiler.js:269:68)
    at next (/usr/local/lib/node_modules/truffle/build/webpack:/packages/truffle-compile/~/async/dist/async.js:5223:1)

which seems to come from one of the dependencies.
Any guidance on the above would be greatly appreciated. Thanks!

Hi @frangio , I was able to fix my environment and run the tests. To anyone that my be reading this, I had some global packages installed that were interfering with the compilation process, after deleting them tests worked fine.
I added your suggestions. However, changing the error message of isApprovedOrOwner in the safeTransferFrom function, causes problems down the line as this modifier is also used in trasnferFrom function and they are tested together in the codebase.
Such test is in ERC721Behavior.js under the function shouldTransferTokensByUsers:

Hm, yes that is complex. Let's revert to the previous error message for now. (cc @nventuro)
Coverage decreased because the new _safeMint function is not tested yet. See the report here.
Since it's an internal function you will have to add it to ERC721Mock, and then add a new test for it in ERC721.behavior.js.

Hello @frangio,
Added _safeMint functions to ERC721Mock.sol and created tests — similar to those that check the _checkOnERC721Received functionality of the safeTransferFrom functions — to check the now the _checkOnERC721Received of the safeMint functions.
Regular minting functionality is tested in other test files for the _mint function, which is what the safeMint functions use internally, so didn't test that.
How does it look?

This is in a great place @alanarvelo!

Some tests are failing, apparently because other ERC721 versions (Pausable, Burnable, etc) are not inheriting the safeMint functions. Any ideas?

I don't see any failing tests.

Also, wouldn't it make sense to add a new tests for safeMint in ERC721MintBurn.behavior.js?

ERC721MintBurn tests the public interface, and this PR so far only introduces an internal function. However, now that you mention it, we should add a public safeMint function in ERC721Mintable, and then we would have to test it as well. Can you add that?

Hi @frangio I made another PR right after that fixed the failing tests, careful that you are not looking at the older one, I restructured the way safeMint is tested by focusing only on ERC721Mock.
I will add that public safeMint fn to ERC721Mintable and add a test for it. Where should that test go? I assume in ERC721MintBurn.behavior.js as ERC721Mintable.test.jsjust calls theshouldBehaveLikeMintAndBurnERC721` exported from the former. Am I correct?

Where should that test go? I assume in ERC721MintBurn.behavior.js

Yeah, exactly!

Hi @frangio added safeMint fns to ERC721Mintable.sol as agreed, and corresponding tests.
Let me know your thoughts.

Awesome 😃
No problem, thank you!


feat(button,iconbutton): add support for aria-expanded to buttons

Fixes #3245 by adding support for the aria-expanded attribute in the same manner as aria-haspopup.
Note this is identical to #3398 minus the docs since they don't exist yet.

@asyncLiz is the merge delay normal here or is the failed check the problem?  If so, I think just a rerun would fix it?

Thank you for the ping! Looks like I missed the email for importing it. We'll run some checks, but LGTM!


Allow accessing properties with a [] method in T::Struct objects

Problem
Would be nice to expose the properties of the T::Struct objects through a def [](prop) method, similar to how Hash and Struct do in Ruby.
MyStruct = Struct.new(:hello, keyword_init: true)
my_struct = MyStruct.new(hello: "world")

# Works with Struct
my_struct[:hello] #=> "world"

class MyTStruct < T::Struct
  const :hello, String
end

my_t_struct = MyTStruct.new(hello: "world")

# Doesn't work with T::Struct :(
my_t_struct[:hello] #=> NoMethodError: undefined method `[]' for <MyTStruct hello="world">:MyTStruct

Proposed solution
Implement a def [](prop) method so that my_t_struct[:hello] returns "world"

I think this would mean that [] would have to return a union type of all the possible value types (or T.untyped)
# typed: strict

class Person < T::Struct
  extend T::Sig

  const :name, String
  const :age, Integer

  sig { params(field: Symbol).returns(T.any(String, Integer)) }
  def [](field)
    case field
    when :name then name
    when :age then age
    else raise NameError, "no member '#{field}' in struct" # To match Ruby's Struct
    end
  end
end

which would defeat the reason for using a Sorbet T::Struct over a Ruby Struct or a Hash (type safety).

Okey doke.


Consul puppet module

What this PR does / why we need it:
Adds a standalone consul module to puppet
NONE

/unassign
/assign @simonswine

/test puppet-tarmak-acceptance-centos v1.10

The three nodes acceptance tests somehow is not building a proper cluster (or I don't know how to auth against it:
Somehow I think the consul cluster of the three nodes is not properly up
Last login: Thu Aug 30 15:18:21 2018 from <IP_ADDRESS>
[vagrant@vault-1 ~]$ sudo -i
[root@vault-1 ~]# cat /etc/consul/consul.json
{
  "acl_default_policy": "deny",
  "acl_down_policy": "deny",
  "acl_master_token": "",
  "acl_agent_token": "",
  "acl_datacenter": "dc1",
  "datacenter": "dc1",
  "log_level": "INFO",
  "client_addr": "<IP_ADDRESS>",
  "bind_addr": "<IP_ADDRESS>",
  "advertise_addr": "<IP_ADDRESS>",
  "encrypt": "",
  "bootstrap_expect": 3,
  "server": true,
  "disable_remote_exec": true,
  "retry_join": [
    "<IP_ADDRESS>",
    "<IP_ADDRESS>",
    "<IP_ADDRESS>"
  ],
  "ca_file": "/etc/consul/consul-ca.pem",
  "cert_file": "/etc/consul/consul.pem",
  "key_file": "/etc/consul/consul-key.pem",
  "verify_outgoing": true,
  "verify_incoming": true
}
[root@vault-1 ~]# consul member list```

the member list is empty and also the token is not picked up correctly
The test itself is fine, but it's not really having a check if consul is up and ready

/assign @JoshVanL
/unassign

/unassign
/assign @simonswine

/test puppet-consul-verify

/test puppet-consul-verify

/test puppet-consul-verify
/test puppet-consul-acceptance-single-node

/test puppet-consul

/approve
/lgtm


Added missing api methods for content jobs

It requires fix for BooleanParser from core:
https://github.com/GrupaZero/core/pull/19

Coverage increased (+6.4%) to 61.647% when pulling eac0c09dfd07b7392ef3ce31decf5a2c9aeb4436 on content_api_methods into 89eee94fbfa7791e6506524da1e7a7df1ef3603c on master.


Non-interactive mode does not work in Linux

The GUI is started and the command does not end itself, which breaks polling for example.
A fix is attached here:
https://github.com/dcosson/vagrant-unison2/pull/28

I've learned that it also doesn't work without that pull request in case you installed the GUI + cli in Mac. Only with the brew version it seems to work without that parameter

@dcosson In case you would like the code to be different (e.g. using a variable as well for that parameter) please tell me and I'll fix ASAP


Added ability to build website per pull request

This change allows building docs website for every pull request and deploys it to github.com/facebook/react-native-pr-docs gh-pages branch.
After CI runs all tests, it builds the website and pushes it to facebook.github.io/react-native-pr-docs/releases/<pr-number>.
Required for this to work:

create repo github.com/facebook/react-native-pr-docs and allow reactjs-bot to push to it
enable gh-pages feature for that repo

Further improvements:

build a sciprt similar to bots/code-analysis-bot.js that posts a comment with link to website generated for this PR
deploy website only if there are any changes compared to master branch

cc @vjeux @knowbody

You're awesome. Hats down 👒

Wahhhh, already oO
Code looks good to me :)

@bestander Is this good to go?

not yet, I need to set up a private repo for PR websites, will get back to this next week

@bestander :+1:

We need to set up a technical GH repo to host the PRs website
FB works on a big docs revamp, so maybe this task will become outdated soon

Ok, so I've spent a couple of hours working on this PR.
I created a private github repo and if someone pushes a commit to its gh-pages branch, we will get website generated at e.g. https://facebook.github.io/react-native-pr-docs/releases/6572/.
The script is ready to be used but we can't execute it via Circle CI because it would compromise a write key to the private repo and malicious actors could obtain the key.
We could reduce the risk by creating a throw-away account with access to only one repo for PR builds but it seems wrong may cause a genuine key leak if someone changes the code without having full context.
@caabernathy proposed an idea that our @facebook-github-bot  could actually run this script instead of CircleCI, thus keeping the deployment key safe.
@facebook-github-bot has hooks on the PR lifecycle, so it can trigger the script execution when PR is created and trigger cleanup when PR is closed.
Also the bot has access to commenting on the Pull Request and it can post comment with a link to the PR docs website.
Does anyone think it is worth another day of github-bot hacking to pull it through or building website for PRs is not that useful to us?

@bestander This seems very cool! We sometimes ask people to test their doc changes locally and attach a screenshot. This way everyone could easily see what the docs will look like.

I struggle to finish this PR because of the extra infra required to make this work.
It is not hard but prone to become broken any moment keys or scripts get moved around.
Let's close this until OSS team is ready to work on website tools again.


Added selected conversion of columns to string when computing metadata

Fixes #1040.
Note that we cannot do this in cast_column due to https://github.com/pandas-dev/pandas/issues/25353.  If that is ever resolved, then we could simplify this by adding the conversion there.

This may create a discrepancy between training time and prediction time i believe as at prediction time we don't calculate the metadata, and by consequence we may end up not doing the cast. I would say we probably should add the cast also at the beginning of add_data. What do you think?

This may create a discrepancy between training time and prediction time i believe as at prediction time we don't calculate the metadata, and by consequence we may end up not doing the cast. I would say we probably should add the cast also at the beginning of add_data. What do you think?

We do already do the cast in add_data, actually.  If you take a look here for example.
I was hoping we'd be able to do it for both at the same time with cast_column, but due to the Pandas bug above, we need to do it for both metadata and data separately.

Got it. Yes cast_column would be the right place because it happens before both, but that pands issues makes it so that the fill NaN logic would fail... let's do it this way right now, let's see if we can change it if that problem in Pandas gets solved.


Expose non-Java.Lang.Object C# objects to Java if possible

As the subject says, it appears to be impossible at the moment to meaningfully use Embeddinator-4000 to actually share code between iOS and Android, since only Java.Lang.Object subclasses are exposed to Java. I'm primarily an iOS developer, so it's entirely possible there's some aspect of Java that makes this impossible or extremely difficult, but without this Embeddinator-4000 doesn't do the primary thing I'd think most people would want it for. If you can't expose C# objects to the native code, why not write the whole thing in Xamarin in the first place?

Just thought I’d add some of my own feedback, the reason why I use embeddinator is we provide our application as a framework. One of our clients have a standard objc project and won’t rewrite. So being able to embeddinate allows us to provide to them our framework but also other projects that can use C# from one code base.
Regards
Peter
On Aug 30, 2018, at 10:46 AM, Robert Thompson <notifications<EMAIL_ADDRESS>wrote:
As the subject says, it appears to be impossible at the moment to meaningfully use Embeddinator-4000 to actually share code between iOS and Android, since only Java.Lang.Object subclasses are exposed to Java. I'm primarily an iOS developer, so it's entirely possible there's some aspect of Java that makes this impossible or extremely difficult, but without this Embeddinator-4000 doesn't do the primary thing I'd think most people would want it for. If you can't expose C# objects to the native code, why not write the whole thing in Xamarin in the first place?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/mono/Embeddinator-4000/issues/699, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAoCQ9CxYe2Z1PObba9Froe701K-MXtaks5uWCUHgaJpZM4WT7Wq.

So I've figured out a mildly inconvenient (but still inconvenient) workaround. You can do a "Shared Project" library, where the files themselves are shared between an Android class library and an iOS class library. Then you can use #if __ANDROID__ to add the necessary attributes to any public API surface.
This works, but it definitely could stand to be improved.

Thanks for reporting the issue. I'm tagging it with "java" so that the right developers can take a look.


[is this a bug?] consents are not transferred to other newly registered users

Environment Details
Spartacus: epic/anonymous-consents branch
Browser: chrome
Device: mac
Happens on: http://dev-com-14.accdemo.b2c.ydev.hybris.com:4200/electronics-spa/en/USD/
Steps to Reproduce

On homepage, scroll down and click on "Consent Preferences"
Click on Accept All.
Click on Sign/Register link and Register a new user.
Login with that user.
Go to Consent Management Page -> All 3 consents are checked as expected.
Go to homepage. Logout.
Click on "Consent Preferences" -> All 3 consents still checked as expected.
Click on SignIn/Register link, and register another user (i did not check the consent on registration page).
Login with that new user.
Go to Consent Management Page

Actual Result

The consents are not checked.

Expected Result

All 3 consents should be checked like for the first user.

hmmm i think the registration consent "not checked" takes precedence over what's in the anonymous. @znikola to confirm

That's correct. However, since all the anonymous consents are checked, it's expected that those are transferred to the second user as well. Will have to look into this one before the final release.

QA: Went to home page and accepted all consents
Logged in with user (all consents were checked)
Registered new user and checked consent preferences (all consents were checked)


What is the name of the REG_DWORD for firmware rollback?

The name of this key value is not mentioned, then what should it be?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b02e11cd-e499-0dd8-b195-17716fa82790
Version Independent ID: a667526a-5e3f-cb38-661a-de6cb0b61d6c
Content: Firmware update status - Windows drivers
Content Source: windows-driver-docs-pr/bringup/firmware-update-status.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @barrygolden
Microsoft Alias: bagold

@goxia .
Key path :  HKLM\SYSTEM\CurrentControlSet\Control\FirmwareResources.
Value : Policy
Type : REG_DWORD
Data :  1

@goxia . I think the below details might be correct. But i am not sure
Key path : HKLM\SYSTEM\CurrentControlSet\Control\FirmwareResources.
Value : Policy
Type : REG_DWORD
Data : 1

Thank you a lot.


I see a limited of openCV functions zto play with.

Might be my stupidity, but when I launch your GUI front end it stops at showing BLUR and leaves out the - for me  - interesting operations (Threshold etc.)
Reducing the number of operations in the commands file by removeing drawing fucntions does not solve this.
Stef<EMAIL_ADDRESS>

Hello,
Yes this is a normal behaviour. These commands are implemented but can only be available when the image have 1 channel (so no RGB, only grayscale). For that, you can use the transformations "COLOR - Colorspace (grayscale)" or "COLOR - Channel".
This availability of certain transformations are based on some condition that you can find in the 'condition' field under each transformation. You can set them to 'True' if you want them to always appear but things might broke.
Hope this help. If you have any questions or criticism, don't hesitate to write them !

Thx for your reply. I used your suggestion and it works as expected.
Stef
From: Arthur Delannoy @.>
Sent: Wednesday, September 27, 2023 12:37 PM
To: ArthurDelannoyazerty/OpenCV-GUI @.>
Cc: stef zaicsek @.>; Author @.>
Subject: Re: [ArthurDelannoyazerty/OpenCV-GUI] I see a limited of openCV functions zto play with. (Issue #5)
Hello,
Yes this is a normal behaviour. These commands are implemented but can only be available when the image have 1 channel (so no RGB, only grayscale). For that, you can use the transformations "COLOR - Colorspace (grayscale)" or "COLOR - Channel".
This availability of certain transformations are based on some condition that you can find in the 'condition' field under each transformation. You can set them to 'True' if you want them to always appear but things might broke.
Hope this help. If you have any questions or criticism, don't hesitate to write them !
—
Reply to this email directly, view it on GitHub https://github.com/ArthurDelannoyazerty/OpenCV-GUI/issues/5#issuecomment-1737142784 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A62I4YSUVWBXUKM3HFYK5KLX4P6WPANCNFSM6AAAAAA5JDIM4Q .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/A62I4YSS275HGRRDB25U7BTX4P6WPA5CNFSM6AAAAAA5JDIM4SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTHRKZAA.gif Message ID: @.*** @.***> >