Update to latest Vue (3.2.x)

I tried updating the deps to Vue 3.2.2, but get this error when running the tests.
 FAIL  tests/docs-examples/teleport.spec.ts
  ● Test suite failed to run

    src/stubs.ts:52:3 - error TS2590: Expression produces a union type that is too complex to represent.

     52   return defineComponent({
          ~~~~~~~~~~~~~~~~~~~~~~~~
     53     name: name || anonName,
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ...
     56     props: propsDeclaration || {}
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     57   })
        ~~~~

We should find out what's going on and fix it so we can update.

This might be related, but when upgrading Vue, the following errors are thrown when running jest: Cannot find module '@vue/compiler-dom' from<EMAIL_ADDRESS>The latest version of seems to remove the compiler-dom from the lock file and there was a release note about conflicting compiler/runtime: https://github.com/vuejs/vue-next/blob/master/CHANGELOG.md#compatibility-notes

Interesting. I think I bumped all the versions (including compiler-dom) but I'll give it another go.

Interesting. I think I bumped all the versions (including compiler-dom) but I'll give it another go.

As soon as 3.2.4 hit, the errors were gone, so I think it might've been a Vue issue. Thinks work for me now!

It's done now.


🐛 [Bug report]: Play creates visual difference on development and production.

This is fixed. Closing


Decimal is not using precision

Precision is fixed at 2 despite the constructor accepting a precision parameter.
https://github.com/cashfarm/node-lang/blob/master/src/decimal.ts

Resolved in the last commit: https://github.com/tokilabs/lang/commit/d4f0883c2dbc5755d5875d935efa0c420d7a07e4

The issue was resolved in the latest version of the package. I will close the issue.


Support sharing non file-based workspaces

Product and Version 1.24:
OS Version Mac OS 10.13.4:
Live Share Extension Version 0.3.246:
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:

In VS Code, install the memfs extension
Open a local folder and then run MemFS: Setup workspace
Begin live share of workspace
Connect

Bug
Entire local disk seems to have been shared

Sharing a workspace that is not backed by the local filesystem is currently unsupported. But Live Share should detect and block that rather than proceeding incorrectly as in this example.

Given that the FileSystemProvider api has been in stable for nearly a year is there an update on this feature? https://github.com/Microsoft/vscode/issues/47475

Still not supported yet, Live Share will provide you with an open dialog in case you will try to share a workspace that has a non-filesystem folder. @lostintangent do we have this support on our roadmap?

Yep, we definitely plan to support this at some point. We just weren’t sure how high priority it is, so it’s appreciated to get additional +1s from folks 👍

Note this will require additional API support from VS Code. There is currently no way for extensions to access external filesystems provided by other extensions.

Does the workspace.openTextDocument(uri: Uri) api not provide the necessary access for Live Share to function?

No, that's not sufficient. That API simply opens a URI in the local editor.
To be able to share a filesystem to guests, Live Share would need access to all the FileSystemProvider operations that are provided by the other extension.

Ah, so on the guest side LiveShare acts in-essence as its own FileSystemProvider and sends files/requests to the host to get/edit/save files. So this is essentially blocked by https://github.com/Microsoft/vscode/issues/48034

Yes, exactly. I had forgotten there was already a VS Code issue tracking that capability.

OOC, would search providers also need to be made public or are those already public?

For that, we can already call vscode.workspace.findTextInFiles(), which will query search providers from other extensions.

This has now been resolved thanks to @daytonellwanger 😄 Let us know if you run into any issues!


Fix env parsing off by one

Fix issue #34

This PR fixes the off by one described in #34
Note:
It seems that the PAM environment only selects arbitrary variables https://github.com/1wilkens/pam/blob/1bc5a7e67e639041ef09adeabb58d0b15f86a3ae/src/client.rs#L170
        self.set_env("HOME", user.home_dir().to_str().unwrap())?;
        self.set_env("PWD", user.home_dir().to_str().unwrap())?;
        self.set_env("SHELL", user.shell().to_str().unwrap())?;

But the PAM environment can set important other variables: for example in a kerberos environement, you have the KRB5CCNAME which points to the kerberos ticket for the user freshly logged in using pam.
This variable is in most system forwarded to the user environment (for example in SSH).
So if you are ok with this, maybe we could modify this code to inherit every environment variable positioned by the PAM to the process, instead of just arbitrary one.
Or if you are not ok with this principle, maybe we could expose an API for get all pam variable to the use api, something in the client.rs like:

    /// Retreive environement variable set by pam
    pub fn get_env_list(&mut self) -> Vec<(String, String)> {
        let pam_env = getenvlist(self.handle);
        let mut env = vec![];
        for (name, value) in pam_env {
            env.push((name, value));
        }
        env
    }

So the end user could do this on its own
Note: I think in an old version of your code, you forwarded every environment variables if I remember correctly.

Hi @1wilkens
I added the get_env_list function to the client, so the user will be able to retrieve PAM environment variable.
Moreover, I added a set of those environment variable to the initialize_environment so by default it will be pushed to the logged env.


Loading home page when authenticated takes 5 minutes and 40 seconds

Gitea version: 1.5 (also 1.4.2)
Git version: 2.17.1
Operating system: Ubuntu 18.04 LTS on a Raspberry Pi 2 (armv7h)
Database:

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist:
The logs aren't helpful, since the request eventually returns 200 and the page loads fine.

Description
When logged in, loading the dashboard takes 5 minutes and 40 seconds. This is a consistent number, leading me to believe there's some event that times out, the variation in response time is between 5:40.1 and 5:40.6. I'm not sure what timeout this is, but I feel like it should either be configurable, or less than one minute. Waiting for a page to load for more than 30 seconds is a little bad imo.
A thing to note, this only started happening after I physically moved my infrastructure somewhere else, so whatever is timing out is likely looking for a network resource that no longer exists.

Followup. I also noticed that gitea wasn't loading my icon from gravatar. After setting my own icon on Gitea, the dashboard loads much faster (20 seconds, instead of 5 minutes and 40 seconds). Is it possible that there's a single gravatar request taking that long? My guess is it checks gravatar many times in the dashboard request, and those checks are sequential.
A possible fix could be caching the gravatar result per-request, instead of checking again on failure. For context, I'm the only active user on my gitea, and my icon is displayed on the page 30 times.

@asonix Do you have libravatar enabled?
Can you open the chrome (or FF) dev console and look at the network flow and their timing?

"Federated avatars" are enabled, "disable gravatar" is disabled, so it should use gravatar.
The network console doesn't help, since it is the initial request that takes 5 minutes. Everything else the page loads comes in quickly. The 5:40 number was actually something I pulled from the server log.

Also it looks like libravatar is shutting down soon. That's a shame. I didn't know it existed until today

@asonix Well hopefully it's not shutting down, I, and a couple others are working on making sure it doesn't shut down.
But that makes some sense for the page load. Libravatar does DNS lookups to make sure that the correct avatar is displayed, but for some domains this request takes a while (there is built in caching, but I believe that only happens when there is a successful DNS response, need to confirm this though)
Ping @strk

For those who may work on this please review the following article from Steve Souders before addressing this https://www.stevesouders.com/blog/2010/06/01/frontend-spof/

Also it looks like libravatar is shutting down soon. That's a shame. I didn't know it existed until today

We'll come up with something better. If it's not sustainable it's probably a sign of a design flaw.

Closing as dupe of #1287


ExhaustiveOptimizerv4 SetInitialPosition unexpected behavior

Description
SetInitialPosition() is documented to "Set the position to initialize the optimization." but its value is immediately overwritten in StartWalking()
template <typename TInternalComputationValueType>
void
ExhaustiveOptimizerv4<TInternalComputationValueType>::StartWalking()
{
  itkDebugMacro("StartWalking");
  this->InvokeEvent(StartEvent());
  m_StopConditionDescription.str("");
  m_StopConditionDescription << this->GetNameOfClass() << ": Running";

  ParametersType initialPos = this->m_Metric->GetParameters();

Expected behavior
Actually, open question on this.  Is there any use case for actually setting the InitialPosition?  I'm presuming for the typical use of ExhaustiveOptimizerv4, we would encourage the InitialPosition to be indirectly set by the user modifying the InitialTransforms in ImageRegistrationMethodv4?
My suggestion would be to make it protected but I'd want feedback about the consequence of that.  I'm reading the docs in ObjectToObjectOptimizerBase and it looks the metric handles the transfer of parameters.
Actual behavior

	auto optimizer = OptimizerType::New();
	optimizer->SetDebug(true);
	auto steps = OptimizerType::StepsType(2);
	steps[0] = 5;
	steps[1] = 0;
	optimizer->SetNumberOfSteps(steps);
	optimizer->SetStepLength(1);
	auto pos = OptimizerType::ParametersType(2);
	pos.SetElement(0, 12); // is the optimal registration transform
	pos.SetElement(1, 0);
	optimizer->SetInitialPosition(pos); // doesn't effect start or span of the exhaustive optimizer

	auto registration = RegistrationType::New();

	registration->SetNumberOfLevels(1); // default is 3

	registration->SetFixedImage(atlas);
	registration->SetMovingImage(img);
	registration->SetInitialTransform(transform);
	registration->SetMovingInitialTransform(transform2);

	registration->SetOptimizer(optimizer);
	registration->SetMetric(metric);
	registration->Update(); // optimization centered on [0,0], not [12, 0]
	registration->GetModifiableTransform()->Print(std::cout);

Reproducibility

Versions

Environment

Additional Information

SetInitialPosition is a virtual public method defined in Modules\Numerics\Optimizers\include\itkOptimizer.h. I am not sure whether we can just declare it protected, and even if compiler allows that whether it would be wise. If fixing the code to take that initial position into account is time consuming, we could change the method's docstring to say it is being ignored?

This does not inherit from itkOptimizer, but from ObjectToObjectOptimizerBaseTemplate. Patch coming up to respect initial position.


Revert VM changes to NEO3.0 behavior

With the merge of json tests in #476 some commits were reverted to match 2.x VM behavior. We need to revisit this and most likely revert this back when NEO3.0 will be here.

See #434 also for ID-only SYSCALL.


static data-placeholder

I'm building an app using angularjs and this component as the select boxes.. on my app, there is an internationalization mode where user could change the language of the UI..
then I noticed if I translate it the data-placholder were updated statically not according to the $scope changes. this is the chosen element codes that I implemented, note that this is just an example

<select ng-model="example" data-placeholder="{{lang.selectbox}}">
   <option value="">
</select>

this is the translation process

$scope.translate = function() {
  $http.get("translate.json").success(function(result) {
     $scope.lang = result
  });
}

is there a way to trigger the data-placeholder model changes ?

Check some answers on issue #121 that will help you.


Crash on IOS FBSDKGameRequestDialog react-native 0.69

🐛 Bug Report
I'm facing bug native module when used react-native-fbsdk-next with react native version 0.69, I install the library and Pos bug when building application success, app crash, and bug report
When I remove it from the project it runs normally, Please help me thank you very much
Thread 1: "-[FBSDKGameRequestDialog initWithContent:delegate:]: unrecognized selector sent to instance 0x600002a7d290"
To Reproduce

Install the library and follow docs integrate native code for ios
build application and crash

Environment
react-native-fbsdk-next version 10.1.0
System:
OS: macOS 11.6.8
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 2.48 GB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.17.1 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.13 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/admin/.rvm/rubies/ruby-2.7.5/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>58069
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: javac 18 - /Users/admin/Library/Java/JavaVirtualMachines/openjdk-18/Contents/Home/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.3 => 0.69.3
react-native-macos: Not Found
npmGlobalPackages:

I create a new project and reinstalled the library.. it work perfectly, I will investigate many thanks

When I see this:

Thread 1: "-[FBSDKGameRequestDialog initWithContent:delegate:]: unrecognized selector sent to instance 0x600002a7d290"

"unrecognized selector" - that usually means "the javascript code and the native code are not in line", npx react-native-clean-project may clear things up


Add flexibility to s3

Change/PR 1: add flexibility to s3
make changes to config.ts with a new native enum (non-zod) for bucket names.
enum names should be all caps, bucket names should not
in the enum, add current resume bucket rp-2024-resumes, but also add one for speakers (rp-2024-speakers)
pass that enum as a parameter into the get/postUrl methods in s3-utils.ts
use that enum's value to get the actual bucket name, instead of the config/env value (you can delete the current hardcoded bucket from config)

hello! @jacobc2700  bumping this back up :)


setup file drag and drop

make drag and drop ui element
get html5 file API handler upon drop event

Done. Files can be added by clicking the button, or drag/drop onto the button.


Usenet support

Do you have plans to add support to Usenet like Radarr and Sonarr does?

yes, this was requested a lot you can track the issue here => https://github.com/iam4x/bobarr/issues/36

Ah sorry, didn't see that.


Please release new version

Do you want to request a feature or report a bug?
Release
What's the current behavior?
There's a bug fix in master that I want to pull into my project, could you please release a new version? Thanks!!

Is this really an issue? Seems like more of a request. Versions get bumped every few weeks so not sure if this will work for you in time but you are more than free to fork the repo and update the project internals.


Test: Update all screenshots of visual tests, because there is a new Inter font release

Apparently Google Fonts released a new version of Inter font (they finally used v4 which Rasmus released in November). This version has different kerning among other things. This broke our visual tests and we have to update them all now with the new font.
Source:
https://github.com/google/fonts/issues/7985
https://github.com/google/fonts/issues/3429
https://github.com/google/fonts/pull/7776
https://github.com/rsms/inter/releases/tag/v4.0

Description

Additional context

Issue reference

coverage: 78.194%. remained the same
when pulling 6e2850f0e6172a61c5f60e2bee2f9cd87105c21f on fix/update-screenshots-inter-4
into cc622c333ba69f85e314ff2bd7a1e25c2611f58f on main.


update shebang line of all scripts to be more compatible between *nix environments

On OSX specifically, the OS ships with a very old version of bash that's missing many features used in various scripts in this project. Installing from brew allows for the env bin to point to a much newer version of bash and resolves this issue

@ahus1 https://github.com/keycloak/keycloak-benchmark/actions/runs/7453510299/job/20328347373?pr=672#step:4:5 Please note that the Documentation CI job failed with the recent change from @alice-wondered


nfc.addNdefListener() does not fire .subscribe() function

Good afternoon, I've been using your plugin to test communication between 2 android devices.
Here is the code I use to receive the message:
receiveValue() {
    this.nfc.addNdefListener(ev => console.log('event: ', ev)).subscribe((message) => {
        console.log(message)
    });
}

To send the message:
sendValue() {
      let value = this.ndef.textRecord('Hello World!');
      this.nfc.share([value]);
}

I'm using the Ionic Native version that's in the npm registry.
After some testing I noticed 2 problems:

when reading a tag the .subscribe() method is never fired after I read the nfc tag.
when I was sharing a message with the "share" method and using another tag reader app on the other device, the tag was never detected.

Any suggestions to solve this?

I had the same problem, the subscribe function was never called for an Ndef tag. In my case the solution was to add the request NFC access in the android manifest as described here
https://developer.android.com/guide/topics/connectivity/nfc/nfc#manifest
I just added the line to the manifest, sync'ed the project and the event fired successfully without changes to the actual code.

In my case (Android 11), I was missing the one of the geolocation permission (ACCESS_COARSE_LOCATION or ACCESS_FINE_LOCATION)


Increment version for schemaregistry releases

Increment package version after release of com.azure azure-data-schemaregistry

@conniey Can we update the READMEs to mention the latest stable version released?


Define requirements for .NET model generation for error models

This tracks the work to determine whether the current error models and exceptions in Azure.Core are sufficient to meet this requirement.  We will need to do more to understand the requirement in order to determine this.
Here is additional context from @lmazuel:

Any usage of x-ms-error-response: true in Swagger, means this models is used only in an error context.
To give context using Python, in track1 models that were used on context of errors were subclasses of Exception. Which causes a bunch of problems in error hierarchy and re-usability of those models outside of this particular context.
In track2, we then decided that all exception are HttpResponseError, and that models are an attribute accesibble from HttpResponseError. This means the models generation is generic, agnostic of usage. IOW, Python track2 (DPG or not) has no specifics for model usage, but I wanted to keep the door open to other languages to think about it.

@ArcturusZhang, please help to check whether there are any additional work needed.

@ArcturusZhang  give out example how to customize the response model.

In Azure.Core there is an abstract class RequestFailedDetailsParser which allows you to write some code to convert a set of data into the standard RequestFailedException format.
We already have quite a few implementation of them for each SDK:

which are using in multiple libraries.
We should pass it into the HttpPipelineOptions when building the client: https://github.com/Azure/azure-sdk-for-net/blob/2c1d884cc72b7af6ef1606396802a8059a687dee/sdk/containerregistry/Azure.Containers.ContainerRegistry/src/ContainerRegistryClient.cs#L87
I do not know if it is possible to define anything in the typespec level to describe a parser like this, but in the generator level, we could do it in this way:

the customer should write their own code to define a parser (which is an internal class).
in the corresponding generated client that would like to consume this parser, we should introduce another codegen attribute, for instance [CodeGenRequestFailedDetailsParser(typeof(YourRequestFailedDetailsParser))]
then in next generation, the generator should take the information on the attribute to automatically generate code to add this parser into the HttpPipelineOptions in the client's ctor.

We could implement this feature in this way without creating a dependency to typespec or TCGC's new decorator because I doubt if there is a way that we could express the parser in a language-invariant way.


Upload VHD {   "name": "PageBlobInvalidSizeError",   "message": "PageBlobInvalidSizeError" }

I try to upload a .vhd image to a Blob Storage Container VHDS. I receive the following message {
"name": "PageBlobInvalidSizeError",
"message": "PageBlobInvalidSizeError"
}
How can I upload the vhd?

Can you please provide more info?
Which version of the Storage Explorer you are using? On what platform?  How did you connect to Azure? Were you using a Premium Storage or Standard Storage? The error message indicated that the Page Blob you were trying to upload had an invalid size, so can you describe a bit about your VHD?  How big is the size? Is it aligned to 512-byte page boundaries?

Hello
Storage Explorer 1.4.2/WIN 10/Google Chrome/Premium/Size 1578045 --> 512-byte Page boundary?

From the look of the error message from the portal you showed above, your VHD, a page blob, isn't aligned to 512-byte page boundaries.  Here is more info on page blobs:
Page blobs are a collection of 512-byte pages. When creating page blob you’ll need to specify maximum size of the blob and that size can’t be exceeded. Page blobs are optimized for high-speed random access read and write operations, and perfect for storing virtual file systems (like VHDs) when client is responsible for organizing data inside the blob. Pages in page blob are assessed by proving an offset in bytes from the beginning of the blob. That offset must alight to the 512 byte page boundary, because only entire page(s) could be read or written. The maximum page blob size is 1TB.

Closing as this doesn't appear to be an issue. @jinglouMSFT 's answer is correct.


Fix blending and opacity in tracks shader

Description
This PR fixes issues regarding translucent blending and opacity changes in the Tracks layer, outlined in #1748.
Two changes have been made:

Track vertices that should not be rendered (alpha <= 0) are now discarded.
The final alpha value is calculated by multiplying the existing fragment alpha by the track alpha.

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

References
Closes #1748
How has this been tested?

[x]  all tests pass with my change

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

All the blending modes, and opacity, works as expected now.


Multiple master files for two-sided audio tapes

Bag structure validation fails with multi-file audio masters
Digitizing two-sided audio tapes will result in packages containing discrete A and B master WAV files. This poses an issue for bag structure validation because the system is checking that bags contain only one master file. In addition, the error message generated will say “Master file missing” when, in fact, the issue is that there are two master files.
To reproduce
Steps to reproduce the behavior:

Bag and tarball files for a two-sided audio tape (this package should contain multiple master files)
Upload the bag to the S3 bucket
Await Digitized AV Notification in Microsoft Teams
View error message

Expected behavior
Bag structure validation failure. Error message should read, “Audio package is invalid. Master file missing.”
Screenshot

Impact on your work
The fact that two-sided tape transfers do not conform to the presently-defined standards for bag structure validation makes it impossible to pass these packages through the digital infrastructure for access and long-term storage.
Additional context
A solution will have to take into account file naming conventions and how to work around file suffixes (i.e., [RefID]A, [RefID]B) in order to cross-reference RefIDs with ArchivesSpace.

Thanks @jwts24! Just to double check: If a package has multiple master files, would we expect it to have the same number of access files, or will there always only be one access file? As you've described the issue above there would only be one access file but I want to be sure!

Good question! When there are multiple master files, there could be one rendered audio file, but it is also possible that there could be multiple rendered audio files. For example, if the content is seven hours, the access element may be separated into two or more access files. I will adjust my post to account for this potential scenario.

So...given that piece of information, it also seems possible that there would be a single audio master file with multiple access files, right?

@helrond No, in the case given above, I should've noted that the seven-hour audio would've originally been recorded and organized as separate segments. There wouldn't be a case where the master file is rendered/stitched together. The patchwork would always occur when producing the access copy. So, the file count can be collapsed but shouldn't fan outward.

OK I think this is going to require a bit of a rethink of the validation logic, because there are three possible valid structures for audio:

one master file, one access file
multiple master files (distinguished by zero-padded suffixes such as _01), one access file (with _r suffix)
multiple master files (distinguished by zero-padded suffixes such as _01), multiple access files (distinguished by zero-padded suffixes such as _01 but without _r)

Documenting further conversations and updates to the digitization spec:

We are dispensing with the _a, _me, _ma suffixes (this will need to be updated in other apps as well).
In cases where there are multiple master files there will always only be a single access derivative file.

@jwts24 This should be resolved now. Give it a go and let me know what happens.

@helrond Tested a package with multiple masters, with zero-padded suffixes but dropping the a/me/ma suffixes, and it passed.


Added middleware, which will allow to use various functions to determine the delay time before sending

Codecov Report

Merging #49 (0069201) into master (42f949b) will decrease coverage by 1.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   57.97%   56.64%   -1.33%
==========================================
  Files          48       49       +1
  Lines        1242     1271      +29
==========================================
  Hits          720      720
- Misses        522      551      +29

Impacted Files
Coverage Δ

...kiq/middlewares/functionalized_retry_middleware.py
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Prevent copying the root view

If you right click in the wrong place it is quite easy to Copy the root instead of the control you thought you were clicking.  This can lead to duplicating the whole form.  We should prevent copy/paste of the root.

Fixed, CopyOperation now checks for IsRoot


In a nut shell.  adds flxanimate for adobe sprite maps above the 2018 version, adds weeks 1-6 folders, and uncommits tutorial as a file as it is pretty much useless thanks to the week 1 folder.

Np also get some rest lol.


(iOS) XML to have TBML namespace

Test case

Copy the following 3 XML files from tbml branch† to mobile phone's storage area, replacing the existing XML files,
./spawnable-contract/schema1/MeetupContract.xml
./blockchain-tickets/schema1/blockchain-events-china.xml
./blockchain-tickets/schema1/TicketingContract.xml

† https://github.com/AlphaWallet/contracts/tree/tbml

Make sure the mobile work as before.

Notice that the same namespace is represented in 3 different shorthands in order to make sure the mobile code does not blindly assume any shorthand.

1.26 is the current version we have. So > 1.26 should support it.
Can test with something like:
curl -H "Accept: text/xml; charset=UTF-8" -H "IF-Modified-Since: Mon, 02 Jul 2018 13:23:00 GMT" -H "X-Client-Name: AlphaWallet" -H "X-Client-Version: 1.0.3" -H "X-Platform-Name: iOS" -H "X-Platform-Version: 11.1.2" https://repo.awallet.io/0xd8e5f58de3933e1e35f9c65eb72cb188674624f3

We should probably standardise our version number format for iOS and Android. Maybe not as far as apply https://semver.org, but at least agree that it's in the format x.y(.z)? Helps with parsing on the server side.

We should probably standardise our version number format for iOS and Android. Maybe not as far as apply https://semver.org, but at least agree that it's in the format x.y(.z)? Helps with parsing on the server side.

Can you file a new issue about that in https://github.com/AlphaWallet/alpha-wallet-android/issues/ where repo server code lies?

Since we are abandoning awallet.io we will use the method @James-Sangalli suggested:
New builds use repo.attestation.id
Old builds use repo.awallet.io
instead of version numbering.

@colourful-land is the new repo at repo.attestation.id up?

Keeping issue open until it is working with new server

@colourful-land is the new repo at repo.attestation.id up?

repo.aw.app is online now. Its XML, however, has not been fully updated to allow ABI embedded in XML, see https://github.com/AlphaWallet/contracts/issues/70
Example: https://repo.aw.app/0xA66A3F08068174e8F005112A8b2c7A507a822335


No such file or directory: './unitalker_data_release/BIWI/id_template.npy'

Hi is this file supposed to be inside one of the downloads?
No such file or directory: './unitalker_data_release/BIWI/id_template.npy'
Thank you

me too

Thank you

Hi, we released the three datasets we collected in this work. Previously released datasets are not included.
To get id_template for BIWI or Vocaset, you can download the datasets following the link in README, and then store their template.pkl file into id_template.npy by throw the key and save just the vertices.
Note that, the id order shold be consistent with train.json. Please download our dataset to see the data structure.

Hi is this file supposed to be inside one of the downloads?
No such file or directory: './unitalker_data_release/BIWI/id_template.npy'
Thank you

Hi, we just uploaded the id_template.zip to google cloud  https://drive.google.com/file/d/1Xr3mHyIBf5Hdy8l16JOlnv0QMNFLp268/view?usp=sharing .
We will update README

Thank you very much! The original BIWI dataset is no longer available btw. Do you know if it moved to a different platform or something?
Thank you again.

I just found that too.  I don't know how to get the original data in this case. We have the prepared data, but we can't distribute it due to the license issue.
If your target is to train the model, we recomend to use our released data first. Besides, you can you use meshtalk and vocaset, and 3DETF datasets. They have good data quality.


[SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe

What changes were proposed in this pull request?
There's a case where MapObjects has a lambda function which creates nested struct - unsafe data in safe data struct. In this case, MapObjects doesn't copy the row returned from lambda function (as outmost data type is safe data struct), which misses copying nested unsafe data.
The culprit is that UnsafeProjection.toUnsafeExprs converts CreateNamedStruct to CreateNamedStructUnsafe (this is the only place where CreateNamedStructUnsafe is used) which incurs safe and unsafe being mixed up temporarily, which may not be needed at all at least logically, as it will finally assembly these evaluations to UnsafeRow.

Before the patch

/* 105 */   private ArrayData MapObjects_0(InternalRow i) {
/* 106 */     boolean isNull_1 = i.isNullAt(0);
/* 107 */     ArrayData value_1 = isNull_1 ?
/* 108 */     null : (i.getArray(0));
/* 109 */     ArrayData value_0 = null;
/* 110 */
/* 111 */     if (!isNull_1) {
/* 112 */
/* 113 */       int dataLength_0 = value_1.numElements();
/* 114 */
/* 115 */       ArrayData[] convertedArray_0 = null;
/* 116 */       convertedArray_0 = new ArrayData[dataLength_0];
/* 117 */
/* 118 */
/* 119 */       int loopIndex_0 = 0;
/* 120 */
/* 121 */       while (loopIndex_0 < dataLength_0) {
/* 122 */         value_MapObject_lambda_variable_1 = (int) (value_1.getInt(loopIndex_0));
/* 123 */         isNull_MapObject_lambda_variable_1 = value_1.isNullAt(loopIndex_0);
/* 124 */
/* 125 */         ArrayData arrayData_0 = ArrayData.allocateArrayData(
/* 126 */           -1, 1L, " createArray failed.");
/* 127 */
/* 128 */         mutableStateArray_0[0].reset();
/* 129 */
/* 130 */
/* 131 */         mutableStateArray_0[0].zeroOutNullBytes();
/* 132 */
/* 133 */
/* 134 */         if (isNull_MapObject_lambda_variable_1) {
/* 135 */           mutableStateArray_0[0].setNullAt(0);
/* 136 */         } else {
/* 137 */           mutableStateArray_0[0].write(0, value_MapObject_lambda_variable_1);
/* 138 */         }
/* 139 */         arrayData_0.update(0, (mutableStateArray_0[0].getRow()));
/* 140 */         if (false) {
/* 141 */           convertedArray_0[loopIndex_0] = null;
/* 142 */         } else {
/* 143 */           convertedArray_0[loopIndex_0] = arrayData_0 instanceof UnsafeArrayData? arrayData_0.copy() : arrayData_0;
/* 144 */         }
/* 145 */
/* 146 */         loopIndex_0 += 1;
/* 147 */       }
/* 148 */
/* 149 */       value_0 = new org.apache.spark.sql.catalyst.util.GenericArrayData(convertedArray_0);
/* 150 */     }
/* 151 */     globalIsNull_0 = isNull_1;
/* 152 */     return value_0;
/* 153 */   }

After the patch

/* 104 */   private ArrayData MapObjects_0(InternalRow i) {
/* 105 */     boolean isNull_1 = i.isNullAt(0);
/* 106 */     ArrayData value_1 = isNull_1 ?
/* 107 */     null : (i.getArray(0));
/* 108 */     ArrayData value_0 = null;
/* 109 */
/* 110 */     if (!isNull_1) {
/* 111 */
/* 112 */       int dataLength_0 = value_1.numElements();
/* 113 */
/* 114 */       ArrayData[] convertedArray_0 = null;
/* 115 */       convertedArray_0 = new ArrayData[dataLength_0];
/* 116 */
/* 117 */
/* 118 */       int loopIndex_0 = 0;
/* 119 */
/* 120 */       while (loopIndex_0 < dataLength_0) {
/* 121 */         value_MapObject_lambda_variable_1 = (int) (value_1.getInt(loopIndex_0));
/* 122 */         isNull_MapObject_lambda_variable_1 = value_1.isNullAt(loopIndex_0);
/* 123 */
/* 124 */         ArrayData arrayData_0 = ArrayData.allocateArrayData(
/* 125 */           -1, 1L, " createArray failed.");
/* 126 */
/* 127 */         Object[] values_0 = new Object[1];
/* 128 */
/* 129 */
/* 130 */         if (isNull_MapObject_lambda_variable_1) {
/* 131 */           values_0[0] = null;
/* 132 */         } else {
/* 133 */           values_0[0] = value_MapObject_lambda_variable_1;
/* 134 */         }
/* 135 */
/* 136 */         final InternalRow value_3 = new org.apache.spark.sql.catalyst.expressions.GenericInternalRow(values_0);
/* 137 */         values_0 = null;
/* 138 */         arrayData_0.update(0, value_3);
/* 139 */         if (false) {
/* 140 */           convertedArray_0[loopIndex_0] = null;
/* 141 */         } else {
/* 142 */           convertedArray_0[loopIndex_0] = arrayData_0 instanceof UnsafeArrayData? arrayData_0.copy() : arrayData_0;
/* 143 */         }
/* 144 */
/* 145 */         loopIndex_0 += 1;
/* 146 */       }
/* 147 */
/* 148 */       value_0 = new org.apache.spark.sql.catalyst.util.GenericArrayData(convertedArray_0);
/* 149 */     }
/* 150 */     globalIsNull_0 = isNull_1;
/* 151 */     return value_0;
/* 152 */   }

Why are the changes needed?
This patch fixes the bug described above.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT added which fails on master branch and passes on PR.

Test build #112311 has started for PR 26173 at commit 16e4954.

Can one of the admins verify this patch?

Credit to Aaron Lewis to report this issue and provide simple reproducer. (There's no information of Github account so haven't mentioned here.)
Please let me know if we would like to apply checking type recursively and apply copy() to all unsafe data structs.

Test build #112311 has finished for PR 26173 at commit 16e4954.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112311/
Test FAILed.

retest this, please

Test build #112313 has started for PR 26173 at commit 16e4954.

Test build #112314 has started for PR 26173 at commit 8b2be71.

Test build #112313 has finished for PR 26173 at commit 16e4954.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112313/
Test PASSed.

Test build #112314 has finished for PR 26173 at commit 8b2be71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112314/
Test PASSed.

cc. @cloud-fan @maropu @viirya

Test build #112391 has started for PR 26173 at commit 39d0a2e.

I've changed the approach to what @cloud-fan had suggested.
It has to pass a data type to check nested struct and copy unsafe data, so it needs to serialize data type to JSON and deserialize in method. Hope this is OK.
I'd like to see whether the direction is OK - if we agree with the direction, I'll try to refine the code as well as add some UTs for new methods.
In case of rolling back, previous commit head is here:
https://github.com/HeartSaVioR/spark/commits/8b2be7116f61df17c7e538d026a7b82b94bf0f12

Test build #112391 has finished for PR 26173 at commit 39d0a2e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112391/
Test FAILed.

Test build #112395 has started for PR 26173 at commit 07514a1.

Test build #112395 has finished for PR 26173 at commit 07514a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112395/
Test FAILed.

Looks like escaping JSON doesn't seem to work consistently during compiling generated code.
val typeToJson = StringEscapeUtils.escapeJava(StringEscapeUtils.escapeJson(dataType.json))

DataFrameComplexTypeSuite.SPARK-29503 nest unsafe struct inside safe array

arrayData_0.copyUnsafeData("{\\\"type\\\":\\\"array\\\",\\\"elementType\\\":{\\\"type\\\":\\\"struct\\\",\\\"fields\\\":[{\\\"name\\\":\\\"col1\\\",\\\"type\\\":\\\"integer\\\",\\\"nullable\\\":true,\\\"metadata\\\":{}}]},\\\"containsNull\\\":false}")

/* 140 */         if (false) {
/* 141 */           convertedArray_0[loopIndex_0] = null;
/* 142 */         } else {
/* 143 */           convertedArray_0[loopIndex_0] = arrayData_0.copyUnsafeData("{\"type\":\"array\",\"elementType\":{\"type\":\"struct\",\"fields\":[{\"name\":\"col1\",\"type\":\"integer\",\"nullable\":true,\"metadata\":{}}]},\"containsNull\":false}");
/* 144 */         }

ALSSuite.recommendForAllUsers with k <, = and > num_items

serializefromobject_value_2.copyUnsafeData("{\\\"type\\\":\\\"struct\\\",\\\"fields\\\":[{\\\"name\\\":\\\"_1\\\",\\\"type\\\":\\\"integer\\\",\\\"nullable\\\":false,\\\"metadata\\\":{}},{\\\"name\\\":\\\"_2\\\",\\\"type\\\":{\\\"type\\\":\\\"array\\\",\\\"elementType\\\":\\\"float\\\",\\\"containsNull\\\":false},\\\"nullable\\\":true,\\\"metadata\\\":{}}]}")

/* 112 */         if (serializefromobject_isNull_2) {
/* 113 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = null;
/* 114 */         } else {
/* 115 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = serializefromobject_value_2.copyUnsafeData("{"type":"struct","fields":[{"name":"_1","type":"integer","nullable":false,"metadata":{}},{"name":"_2","type":{"type":"array","elementType":"float","containsNull":false},"nullable":true,"metadata":{}}]}");
/* 116 */         }

val typeToJson = StringEscapeUtils.escapeJson(dataType.json)

DataFrameComplexTypeSuite.SPARK-29503 nest unsafe struct inside safe array

arrayData_0.copyUnsafeData("{\"type\":\"array\",\"elementType\":{\"type\":\"struct\",\"fields\":[{\"name\":\"col1\",\"type\":\"integer\",\"nullable\":true,\"metadata\":{}}]},\"containsNull\":false}")

/* 140 */         if (false) {
/* 141 */           convertedArray_0[loopIndex_0] = null;
/* 142 */         } else {
/* 143 */           convertedArray_0[loopIndex_0] = arrayData_0.copyUnsafeData("{"type":"array","elementType":{"type":"struct","fields":[{"name":"col1","type":"integer","nullable":true,"metadata":{}}]},"containsNull":false}");
/* 144 */         }

ALSSuite.recommendForAllUsers with k <, = and > num_items

serializefromobject_value_2.copyUnsafeData("{\"type\":\"struct\",\"fields\":[{\"name\":\"_1\",\"type\":\"integer\",\"nullable\":false,\"metadata\":{}},{\"name\":\"_2\",\"type\":{\"type\":\"array\",\"elementType\":\"float\",\"containsNull\":false},\"nullable\":true,\"metadata\":{}}]}")

/* 112 */         if (serializefromobject_isNull_2) {
/* 113 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = null;
/* 114 */         } else {
/* 115 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = serializefromobject_value_2.copyUnsafeData("{"type":"struct","fields":[{"name":"_1","type":"integer","nullable":false,"metadata":{}},{"name":"_2","type":{"type":"array","elementType":"float","containsNull":false},"nullable":true,"metadata":{}}]}");
/* 116 */         }

val typeToJson = StringEscapeUtils.escapeJava(dataType.json)

DataFrameComplexTypeSuite.SPARK-29503 nest unsafe struct inside safe array

arrayData_0.copyUnsafeData("{\"type\":\"array\",\"elementType\":{\"type\":\"struct\",\"fields\":[{\"name\":\"col1\",\"type\":\"integer\",\"nullable\":true,\"metadata\":{}}]},\"containsNull\":false}")

/* 140 */         if (false) {
/* 141 */           convertedArray_0[loopIndex_0] = null;
/* 142 */         } else {
/* 143 */           convertedArray_0[loopIndex_0] = arrayData_0.copyUnsafeData("{"type":"array","elementType":{"type":"struct","fields":[{"name":"col1","type":"integer","nullable":true,"metadata":{}}]},"containsNull":false}");
/* 144 */         }

ALSSuite.recommendForAllUsers with k <, = and > num_items

serializefromobject_value_2.copyUnsafeData("{\"type\":\"struct\",\"fields\":[{\"name\":\"_1\",\"type\":\"integer\",\"nullable\":false,\"metadata\":{}},{\"name\":\"_2\",\"type\":{\"type\":\"array\",\"elementType\":\"float\",\"containsNull\":false},\"nullable\":true,\"metadata\":{}}]}")

/* 112 */         if (serializefromobject_isNull_2) {
/* 113 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = null;
/* 114 */         } else {
/* 115 */           serializefromobject_convertedArray_0[serializefromobject_loopIndex_0] = serializefromobject_value_2.copyUnsafeData("{"type":"struct","fields":[{"name":"_1","type":"integer","nullable":false,"metadata":{}},{"name":"_2","type":{"type":"array","elementType":"float","containsNull":false},"nullable":true,"metadata":{}}]}");
/* 116 */         }

So double escaping seems to be only working solution for new UT, but consistently fails on ALSSuite - \\ escape is gone. Not sure why.

Using catalog string instead of json seems to work on both tests. Let me see the build result.

Test build #112413 has started for PR 26173 at commit 4c38ffc.

Would it work if we replace CreateNamedStructUnsafe to CreateNamedStruct in lambda expression of MapObjects?
I'm not sure we don't miss anything as it only deals with struct type, but what we discovered for now is struct type, so the approach makes sense to me for resolving SPARK-29503. Just a view of as non-expert of SQL, current approach makes me feel safer though, in the sense of defensive programming.
I would wait to hear more voices before making change so we don't do back and forth. Thanks for the suggestion!

Test build #112413 has finished for PR 26173 at commit 4c38ffc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112413/
Test FAILed.

Test build #112426 has started for PR 26173 at commit 6187d99.

Test build #112426 has finished for PR 26173 at commit 6187d99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112426/
Test PASSed.

it's safer to make the copy supports mixed safe and unsafe data, but I agree with the perf concern from @viirya .
How many places do we create mixed safe and unsafe data? It looks to me that there is only one: UnsafeProjection.toUnsafeExprs only converts create_struct, but not create_array and create_map.
Furthermore, I don't quite understand why we need CreateNamedStructUnsafe. Can we simplfy remove it?

I quickly checked the usage of CreateNamedStructUnsafe, and it is only used in UnsafeProjection.toUnsafeExprs. If UnsafeProjection converts the result of evaluations of expressions into UnsafeRow (it should), I don't see strict need to care about individual expression, at least logically.
So I'm seeing the same, CreateNamedStructUnsafe doesn't seem to be needed at all. As a side effect UnsafeProjection.toUnsafeExprs is also not needed at all as well.
I've just removed them and rebased the branch to contain only the change. The new test passes with new change, so let's see the build result.
Old commit hash to revert: 6187d99

Test build #112485 has started for PR 26173 at commit d8d3900.

OFFTOPIC: I've indicated ComplexTypes.scala file is using CRLF instead of LF which leads showing ^M in git diff making me a bit annoying. We don't seem to set any rule on this but personally it might be better if we make it be consistent. Have we discussed this earlier?

looks a much simpler. if no other concern, this approach looks good.

Test build #112485 has finished for PR 26173 at commit d8d3900.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CreateNamedStruct(children: Seq[Expression]) extends Expression

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112485/
Test PASSed.

Ur, for better commit logs, can you describe an change of generated code for MapObjects  in the PR decription?

Thanks for reviewing. Just addressed review comments.

Test build #112508 has started for PR 26173 at commit 4460233.

Test build #112509 has started for PR 26173 at commit f10042a.

Test build #112508 has finished for PR 26173 at commit 4460233.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #112509 has finished for PR 26173 at commit f10042a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112508/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112509/
Test FAILed.

retest this please

Test build #112520 has started for PR 26173 at commit f10042a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17484/
Test PASSed.

Test build #112520 has finished for PR 26173 at commit f10042a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112520/
Test PASSed.

thanks, merging to master!

Thanks all for reviewing and merging!


feat: :sparkles: add menu to exercise list detail view

Add a menu to the ExerciseListDetailView with two buttons. The functionality will be added in other issues.

Closes #45

Description

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Developer tooling (fix or improve developer tooling)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@heyjaywilson This PR is ready for review


Add tests for multiple routes

Test for IPv4, IPv6 multiple routes.  When the RouteDatabase is updated, how many follow up requests are made.

Using this to test
https://github.com/square/okhttp/issues/7553
and
https://github.com/square/okhttp/issues/7530


Which version of python did you use?

Hi, thank you for your interest! The python version is 3.6. Please let me know if you have further questions! :)

Thanks a lot!


Add stream_context view

Hi,
The loki has function check context, as VictoriaLogs has this functions as well, stream_context
It would be nice add this functionaly as well
Open the loki play
Just press the button and a new window will pop up

It's duplicate https://github.com/VictoriaMetrics/victorialogs-datasource/issues/41


g-5 class in 5.1.1 creates horizontal scrolling in mobile

g-5 class in row creates horizontal scrolling in mobiles
for ex.

Lorem ipsum dolor sit amet.

Lorem ipsum dolor sit amet.

works fine,  but when I do something like

Lorem ipsum dolor sit amet.

Lorem ipsum dolor sit amet.

it creates horizontal scrolling in mobile.

I think that's expected - check the docs - you may need to add a padding utility to the parent container.
https://getbootstrap.com/docs/5.1/layout/gutters/#horizontal-gutters

@coliff is correct.
This can be avoided by using the experiment CSS Grid layout option instead, but otherwise, the flexbox layout requires a little bit of work still when modifying gutters :). Wrap it in

 and you should be set.


docs(ref): Clarify workspace settings

What does this PR try to resolve?
In reviewing the status of #10625, I was reminded

that we are having growing pains with the workspace documentation
that workspace.resolver isn't documented

So I re-organized the workspace docs to have a high level intro / behavior description and then to focus on being a field reference, much like manifest.md.   I could see splitting it specifically into tutorial/reference like the overriding dependencies document does it.
When adding workspace.resolver, I remembered in the nested workspace discussion there were other workspace related sections that are not present.  We now link out to profile, patch, and replace.  In doing this, I realized that patch and replace do not specify their workspace behavior, so I do that.
How should we test and review this PR?
  Unfortunately, the first commit didn't split up so easily.
Additional information
Other information you want to mention in this PR, such as prior arts,
future extensions, an unresolved problem, or a TODO list.
-->

r? @weihanglo
(rust-highfive has picked a reviewer for you, use r? to override)

It seems good if we can ship this doc enhancement in 1.64. Should we send a PR to beta as well?

:pushpin: Commit f39f8dc5d4cdafc2045a47aeb90a1f921654872b has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit f39f8dc5d4cdafc2045a47aeb90a1f921654872b with merge 362ce336991a324f5b77cce2f45c5366fc8b6009...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 362ce336991a324f5b77cce2f45c5366fc8b6009 to master...


Augury not recognising Angular app when using ngUpgrade

Augury version (required): 1.14.0
Angular version (required): 4.2.2 (with ngUpgrade)
Date: 18/06/17
OS: macOS Sierra
Recently upgraded my AngularJS app to Angular by following the upgrade guide. The upgrade worked well, but I can't get the extension to recognize the application as an Angular app:

The bootstrapping code is fairly standard:
// import polyfills
import './ng2polyfills';

import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {Ng2AppModule} from './app.module';

platformBrowserDynamic().bootstrapModule(Ng2AppModule);

I've checked the Augury code, and it seems that the isAngular function depends on the presence of getAllAngularTestabilities and getAllAngularRootElements. Both are undefined when I type them in the browser's console. However, I'm able to access ng and ng.probe just fine.
Did I miss something in the setup? There's not much info on the internet, most of googling shows old issues with Angular rc versions.

We are already investigating this case under a duplicate issue #680


[T3A2][T11-A3] Tan Yu Peng

@GitMeGet  Some comments added. Please close the PR after reading comments.


Various stuff

Changed the layout of combatants to a table so that the name can take the whole line.
The color of the combatants is determined by the token disposition (with the exceptions of PCs, which remain blue).
The hidden status is reverted to default Foundry behavior. This hides the combatant in the combat tracker, not the token. I think those should remain separate.
The dead status uses isDefeated for all token types. I’ll sync that up in the system, as that would be useful even if on doesn’t use your module.
Whether the values can be seen is based on the actor permission instead of the visibilities of bars, as I assume most use Bar Brawl for that. Limited cannot see the values at all (just like having no permission at all). Observer can see, but not edit. Owner and GM can see and edit.

9179f3a also changed how the Dead status is handled in the combat tracker. Instead of marking the PC Dead on the character sehet and actor, this is now default Foundry behavior of marking the token and combatant as defeated. In turn, I’ll remove the Dead status from the character sheet. I never really liked that one, as it doesn’t serve any purpose. The official sheets also don’t have that. This streamlines what the dead-button does. Being impaired or debilitated is not touched by this.


Add Rosetta test for historical balance lookup, fix Rosetta date bug

Depends on #7992 (first commit).

Makes it so we use block genesis date instead of utcDate in Rosetta
Adds a time-locked account to the Rosetta test genesis ledger
Adds code to Rosetta test-agent/agent.ml to check the time-locked
account's balance at each index and confirm it matches what we expect
Doesn't add the new account to the rosetta-cli bootstrap_balances
because we don't have a way yet to mark the account as balance exempt
(we're still waiting to hear back from Coinbase on that)
Doesn't yet test a more complex situation with a time-locked accounts
that actually encounters internal and user commands

Checklist:

[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them:

Awesome

!ci-build-me

!approved-for-mainnet

!ci-build-me


How to use electron-vue to create a modal form?

How to use electron-vue to create a modal form, to solve the data inside vuex can be shared in the parent form and the modal form second, this form can be dragged to the parent outside, ask the writer to give a solution.

@okwangyu
This is not a direct issue with electron-vue, and I will be closing. Please know that the presensce of electron doesn't change how Vue.js is used. This is a question better suited for official documentation or respective communities.
electron

https://electron.atom.io/docs/

vue

https://vuejs.org/v2/guide/
https://forum.vuejs.org/
https://chat.vuejs.org/

@okwangyu
If you opt to use vue.js the buefy is something i likely recommend to you:

https://buefy.github.io/
About modal and component's modal (like a form):
https://buefy.github.io/#/documentation/modal


Update pandas example in the README?

Brief Description of Fix
Right now, the pandas example in the README shows what I (IMHO) would say is "bad" pandas code. I would rather write it as something like
In [15]: df = (
    ...:    pd.DataFrame(company_sales)
    ...:     .drop(columns="Company1")
    ...:     .dropna(subset=['Company2', 'Company3'])
    ...:     .rename(columns={"Company2": "Amazon", "Company3": "Facebook"})
    ...:     .assign(Google=[450.0, 550.0, 800.0])
    ...: )
    ...: df
Out[15]:
  SalesMonth  Amazon  Facebook  Google
0        Jan   180.0     400.0   450.0
1        Feb   250.0     500.0   550.0
3      April   500.0     675.0   800.0

Thoughts on updating that example? I would certainly keep the current one, since it makes it clear that pandas allows the "bad" style, while pyjanitor doesn't. But I think it'd be nice to include the "good" style as well :)

Yes! Let's do that, @TomAugspurger! Let me mark this as a docfix and one that a newcomer can attempt.


drivers: eth: sam_gmac: remove dts defaults

The use of defaults isn't really needed for the properties that
specified them.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

@galak , The semantics is all tree properties are required=true. The default value allowed us to "force" the usual value to avoid populate all dtsi. Since we are moving to be explicit, we need adjust to reflect the functionality.
The max-speed is currently not implemented and can be removed since we now negotiate speed on driver. It can be usefull to force speed to: 0- Auto, 10- 10Mbs, 100- 100Mbps, for instance, since speed is the SPD bit field on the GMAC_NCFGR register. Since now we can implement GPIO interrupts, we can update driver to use that since we currently use pooling. Than we can implement the functionality. I opened #28890 to track the change.
max_frame_size (Atmel only accept this 3 values (1518, 1536 and 10240) on a 2 bit field) and the first commit was the right. We don't need check the existence of the property since must be defined all time.
GMAC_NCFGR register bits JFRAME and MAXFS
phy-connection-type (one bit field)
GMAC_UR register bit MII
https://github.com/zephyrproject-rtos/zephyr/blob/c02eb30bbfbe2487753eb52078015f5a617a3dd1/drivers/ethernet/eth_sam_gmac.c#L1108
Since phy-connection-type is directly on the driver I was expecting PR failure on CI. This should be added no the board, probably. Exceptions are SoC that only support one HW connection like SAM4E.
I removed the properties from DTS file and try build samples/net/sockets/echo_server from main and it failed locally. There are configs for sam_e70_xplained, I found:
https://github.com/zephyrproject-rtos/zephyr/blob/d4347b4015c9a5992877b3086508b134e5fa87b3/samples/net/sockets/echo_server/sample.yaml#L10-L13
https://github.com/zephyrproject-rtos/zephyr/blob/d4347b4015c9a5992877b3086508b134e5fa87b3/boards/arm/sam_e70_xplained/sam_e70_xplained.yaml#L10
I've been raising this kind of thing since 2.3. My allegation is simple, CI have been not build all paths. It seems SAM's GMAC is another issue. I would appreciated if someone could explain what I'm missing here and why CI doesn't failed?
In file included from /home/gfbudke/zephyros/zephyr/zephyr/drivers/ethernet/eth_sam_gmac.c:42:
/home/gfbudke/zephyros/zephyr/zephyr/drivers/ethernet/eth_sam_gmac_priv.h:197:23: error: missing binary operator before token "("
  197 | #if (!DT_INST_HAS_PROP(0, max_frame_size)) || \
      |                       ^
/home/gfbudke/zephyros/zephyr/zephyr/drivers/ethernet/eth_sam_gmac_priv.h:208:2: error: #error "GMAC_MAX_FRAME_SIZE is invalid, fix it at device tree."
  208 | #error "GMAC_MAX_FRAME_SIZE is invalid, fix it at device tree."

/home/gfbudke/zephyros/zephyr/zephyr/drivers/ethernet/eth_sam_gmac.c: In function 'gmac_init':
zephyr/include/generated/devicetree_unfixed.h:2334:36: error: 'DT_N_S_soc_S_ethernet_40050088_P_phy_connection_type_ENUM_IDX' undeclared (first use in this function); did you mean 'DT_N_S_soc_S_ethernet_40050088_P_status_ENUM_IDX'?


Wrong variable/config initialisation in VCAP::CloudController::BitsExpiration

Issue
These two lines seem to be initialising the variables wrong, they should be swapped:
https://github.com/cloudfoundry/cloud_controller_ng/blob/4f375ebcc902d50f3a7ca8542f9a31afc9fee5d0/lib/cloud_controller/bits_expiration.rb#L7-L8
It is not a big deal because the default is the same for both.

Hello @keymon,
This issue was fixed as part of this commit: https://github.com/cloudfoundry/cloud_controller_ng/commit/9c8b2ed3
Thanks,
@michaelxupiv & @rizwanreza


Add sed for corner case in commiter id

Some emails in a launchpad project I use (lp:graphite) have no
username. Without this fix, they are imported as<EMAIL_ADDRESS><>"
which is not a valid format in git.
This fix copies the username out of the email and forms a new id like:
"user<EMAIL_ADDRESS>

any chance you are interested in writing a test for this? quick assumption says there is probably a pretty quick way to make a bzr commit of that style and import the repo

Sure, I will take a look at writing a specific test case, but it may take a bit. I haven't actually learned bzr yet (thus my use of this plugin).
It has been tested on lp:graphite, at least with pulling. Pushing doesn't work, but that appears to be a version issue.

asked around in a channel with bzr users, one approach is to use commit --author="Some User<EMAIL_ADDRESS>but that will only change teh author id, not sure if your code is affecting that yet (but worth a shot to try also), still getting info on how to change the committer easily

ah, you can use bzr whoami "New User<EMAIL_ADDRESS>in between commits

test_import_strip_tags is probably a good test to model this after, where bzr('tag', 'some~invalid!tag') you can touch a file, do a bzr whoami and bzr commit, then bzr whoami to an existing good name and commit again then do a gitbzr import

Cleaning up ancient/stale pull requests


Add support to combine YR_RULES

Related: https://github.com/VirusTotal/yara/issues/148

Add one or more Yara rules to the compiler using yr_compiler_add_file, yr_compiler_add_string etc.
Get compiled rules (i.e. YR_RULES) from added rules.
Save the rules yr_rules_save
Either use yr_rules_scan_file or create a scanner and then use yr_scanner_scan_file
When needed (e.g. on program start) use yr_rules_load and then yr_scanner_create

All good. But what if new plain text Yara rules do come?
One idea is to store all plain text rules, add all of them (plus the new ones) using yr_compiler_add_file and repeat the process.
But what if plain text rules are too many? Why store plain text rules as well as the compiled rules (saving compiled rules to speed up, obviously). This essentially defeats the whole purpose of yr_rules_save !
Another approach is to have multiple YR_RULES and/or multiple scanner object. This means yr_scanner_scan_file must be invoked against all scanner objects!
There should be some approach to add new rules to existing compiled rules (i.e. append to YR_RULES).

Unfortunately merging two sets of compiled rules is not viable due to the way in which compiled rules are stored. So this is unfeasible.

@plusvic What's the best alternative then? Keep both plain text rules and compiled rules stored on disk? And when new plain text rules come in, destroy compiled/scanner, and start again? Or have multiple rules/scanners/compilers?

The exact solution depends on your case, but you will need to store at least the text rules and recompile them again when some change arrives. Whether or not you store the compiled rules as well depends on what you want to achieve. Most system just compile the rules and keep them in memory but don't write them to disk.


Why can both Send As and Send On Behalf be set at the same time?

Per the document, "You can configure Send as or Send on behalf for a given user, but not both. If you configure both, it will default to Send as."  So why does Exchange (specifically O365 Exchange) allow you to assign both at the same time?
Seems more logical to only allow one set at a time.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3a862d8-4223-7bb7-42f1-9842cbeacf87
Version Independent ID: 2c3c7e9a-a44d-168e-2083-b1527ab3f61c
Content: Allow members to send as or send on behalf of a Group - Microsoft 365 admin
Content Source: microsoft-365/admin/create-groups/allow-members-to-send-as-or-send-on-behalf-of-group.md
Service: o365-administration
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hi @Canis-Lupis, thank you for your feedback.
My apologies but I don't have this information. For feature requests, I need to kindly redirect you to this resource https://office365.uservoice.com/. There, your suggestion will reach the product team.

That wasn't a feature request.

From: Dario Woitasen<EMAIL_ADDRESS>Sent: Wednesday, July 22, 2020 2:55 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: David Tessmann<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Why can both Send As and Send On Behalf be set at the same time? (#2337)
Hi @Canis-Lupishttps://github.com/Canis-Lupis, thank you for your feedback.
My apologies but I don't have this information. For feature requests, I need to kindly redirect you to this resource https://office365.uservoice.com/. There, your suggestion will reach the product team.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/issues/2337#issuecomment-662663328, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMUD2TGV2XXYKLQH2BZFZJ3R4472XANCNFSM4OV4BMUA.

Thanks @Canis-Lupis, I don't have an explanation about why we can set both. Here we are limited to documentation issues and improvements.

@Canis-Lupis Thank you again for taking the time to open this issue. My apologies again but I don't have the detail you are asking for.
My personal opinion is that in different systems you can apply a lot of permissions and always the most restrictive permission wins, and the same applies here.

@dariomws  Thank you very much for the contribution and sharing this explanation. @Canis-Lupis Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Create instrument run transfer pipeline

From a discussion with @victorskl this morning, this CWL workflow is part of a step to 'oraify' an instrument run prior to archival

Missed label on output directory which broke catalogue creation - reprocess https://github.com/umccr/cwl-ica/actions/runs/10170908294


Support of www.windalert.com is highly appreciated

It would be great to add the support of www.windalert.com service in addition to recently added Meteoalarm platform since it provides much wider map coverage.
Home Assistant release with the issue:

HA 0.93
Last working Home Assistant release (if known):
None
Operating environment (Hass.io/Docker/Windows/etc.):

N/A
Component/platform:

Platform: Meteoalarm
Description of problem:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

This is really for bur reporting rather than feature requests. If there's a rest API available you could use the (rest integrations)[https://www.home-assistant.io/components/rest/]. For feature requests use the forum.


Add the ability to: to have multiple spellings of the name of the month

In Russian language we have many forms of the name of the month (conjugate)
For example:
25 сентября 2006 23:05
and
25 сентябрь 2006 23:05
Can you change variable self.Months from list to dict?:
self.Months = {
'1' : ['января', 'январь'],
'2' : ....
'12' : ...
}

hmm, that is an interesting change - we should be able to do that as these variables are what generate the regex...

There's another approach that possibly may help to solve such problems. Use WordNet (English) / RussNet (Russian) to lemmatize words.

I could see WordNet being used for this as a secondary method similar to how ICU is used but not as the primary - adding 12+ megs to the package (that is the current size of WordNet for English) doesn't feel right.
Now if WordNet could be used to help build other parts of the regex constants and also start us down the path of getting a lexical graph... that would be awesome

@bear totally agreed. I'll consider WordNet as an opt-in function. So if you want better result, you'd better install nltk and WordNet.

Needed for v2 - see Issue #121


[GameTest] EntityIterator is not iterator

EntityIterator
Method getPlayers().next is undefined.
There is only getPlayers()[Symbol.iterator] method.
We have to do getPlayers()[Symbol.iterator]().next().value.
So what getPlayers() returns is an iterable collection.
I would name it "EntityIterableCollection" instead of "EntityIterator".
I have created a pull request.
https://github.com/MicrosoftDocs/minecraft-creator/pull/460

EntityIterator implements Iterable<Entity> instead of Iterator<Entity>.
Just remove then().
PlayerIterator is the same.

Iterable
Iterator

import { world } from "mojang-minecraft";
const ow = world.getDimension("overworld");
world.events.chat.subscribe(() => {
    const entities = ow.getEntities();
    for (const e of entities) {
        e.runCommand("say test");
    }
    ow.runCommand("say again");
    for (const e of entities) {
        e.runCommand("say test");
    }
});

[Steve] test
[Armor Stand] test
[Script Engine] again
[Steve] test
[Armor Stand] test

Please
Please don't call it "iterator"

https://github.com/MicrosoftDocs/minecraft-creator/pull/460

I made a mistake.
Actually the iterator returned by [Symbol.iterator]() is not iterable.
const itr = world.getPlayers()[Symbol.iterator]();
for (const p of itr) {
  console.log(p.name);
}

so the doc is corrent.
[Symbol.iterator]() returns Iterator

This problem is still isn´t fixed for Generator yield from syntax, object is still not IterableIterator, if i am correct

Most of the Native operators have been replaced by a regular field, that report is no longer current, Thank you for reporting, but this issue can be closed now.


⚠ Bofrost.at has degraded performance

In 94e5b8b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1614 ms

Resolved: Bofrost.at performance has improved in 65db215.


Re-Arrange Component Groups Order

As above. Would be a nice little improvement.

Duplicate of #573.


Add a button to the OADP panel to create a backup from the template of an existing schedule

Is your feature request related to a problem? Please describe.

There is no option on the OADP panel to create a Backup  on demand using a Schedule instance.
Describe the solution you'd like

The option to create a Backup from a  Schedule template using the OADP panel.
The velero command for this is: velero backup create --from-schedule <SCHEDULE_NAME>

@poponealex OADP does not have a dedicated UI. I believe you are talking about the openshift operatorhub UI ?
if yes, then are you not seeing something like the below screenshot ?

@shubham-pampattiwar Yes I am talking about the OADP Operator UI.
There is the create instance button for a Schedule indeed, this is not my issue though. The feature I am requesting is to have a button to create a backup from an existing schedule as I have explained above.
For instance, when you click on an instance's kebab menu (as show below), it would be a nice feature to be able to create a new backup from this schedule's template.

@poponealex Thanks for explaining. The UI rendered in your screenshot is standard OpenShift OperatorHub UI for CR instances, in our case schedule instances, the options in kebab menu are standard I believe, something the OperatorHub framework provides, not something particular to OADP OperatorHub.

From recent exploration, you're limited to a few descriptors to customize the interface without creating a dedicated UI.
x-descriptors can be used to make a field something more usable but nothing like adding a button to create another resource from a resource.

@kaovilai Thank you for the references. I was actually looking into how it would be possible to add actions to a CRD in the Operator schema and I haven't found anything relevant.
It would be a great feature to be able to add some customization to an Operator's UI.

@poponealex I would create an issue at https://github.com/openshift/console/ if you're still interested in driving this forward.
Maybe around https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md and hope they would route the request to the right people.
At this time this feature is considered unplanned.


Support providing parent elements as dragHandle and resizeHandle

#96

Hmmm... I don't like the implementation you've gone for as it restricts the handles to being an anchor tag with a specific class. I'd prefer to keep it allowing a full css selector


Is the download gone?

I get a 404 on the file download. Is the link incorrect or is it not available anymore?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c27cc7d-bb92-c1bc-4330-ae2bb54846bc
Version Independent ID: f14f15f3-e079-a6c6-d9ef-d7698f2e989f
Content: Overview of the SharePoint Migration Assessment Tool
Content Source: migration/overview-of-the-sharepoint-migration-assessment-tool.md
Product: sharepoint-server-itpro
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

I just checked both of the download links in the article and they work fine for me; can you try again?
Thanks!

Please confirm if this is also available for SP2010.  The Intro page that this is for SP2013 while the overview page states "The tool is built to be run from within a SharePoint 2010 or 2013 farm".  Thanks.

fbastone, yes it's available and compatible with SP2010. It is the same download for both versions.


Add example capture template to the README

Fixes #50.

Thank you very much! This question has come up several times, and now we have an answer!


refactor aboutUs component to be a reusable expandableSection component

I started working on a Code of Conduct component and noticed that the functionality we want for that is very similar/identical to the About Us component. So, as a first step I decided to refactor the existing About Us component into a reusable "ExpandableSection" component that we can use for the About Us and Code of Conduct sections, and possibly other sections in the future.
The ExpandableSection component has required props of title, initialText, and expandedText.  Currently these values are hard-coded in index.js for each current use case (About Us and Code of Conduct).  I'm not sure if the About Us text is a placeholder or our final version (I just kept what was already in the About Us component) but the Code of Conduct text is definitely a placeholder at this time.  Given how much text is involved in our actual Code of Conduct, I think it makes sense to put the text in a JSON or markdown file and then use a gatsby plugin to pull the content into the component.  I will take on that work in a separate PR to keep the size of each one manageable.
I also added unit tests for the ExpandableSection component and fixed up the tests for index.js-- I noticed that they had not been updated from the starter pack boilerplate so I went ahead and added a couple test cases to ensure the About Us and Code of Conduct headers are rendered as expected on that page. To verify: run the tests via npm test, they should all be green on this branch.
To view/manually test these changes:

pull down this branch and then run the app via npm start
The About Us and Code of Conduct headings should appear on the index page, each with a "Read more" button.
Clicking on the button should reveal the expanded text for that particular section, and the button text should change to "Read less".
Clicking on the button again should hide the expanded text for that section.

@mollykmcglone just reviewed this and I agree, since both the components are similar, it's best just to create one re-usable component. I ran the code and the button work like it's intended!
The About us text is just something I took from the description section of our meetup group. I'm thinking it's placeholder for now until we decide to update what we want to say.
I'm not sure if we met, but just a little introduction. I'm a self-taught developer, so some of this is still new to me. I actually didn't look into Refs when learning react but after reviewing your code, I will say it taught me a little about it and I'll start using it!
Anyways, the code looks good and I'm okay with merging this.

hey thanks for the review @kevy7, really appreciate it! I'm pretty new to React and didn't know about refs either until I started working on this.  Good to know that the About Us text is also placeholder- given that, I'll go ahead and wrap that into the work I'm doing now to pull the Code of Conduct text from a markdown file instead of hardcoding it. Hope to have a PR up for that in the next week or so.

@kevy7 and @mollykmcglone nice to be able to read the conversation on this! Thanks for making it so transparent in the review... way easier to catch up on what's happening this way!


Styling

What does this PR do?
This PR is raised to submit for code review in the Microvers dashboard of Mohammad Rafi Amin.
Description of the task to be completed 👎
I will be building my "BookStore" website for more than a whole week. below are the tasks that will be done.
Project 1: Initialize the project with components (React only).
Project 2: Add reducers and actions.
Project 3: Use Redux in React components.
Project 4: Connect to API.
Project 5: Styling.

Hi @mrkamin,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request
⚠ Kindly remove the instructions aiming to inform you below on your README file.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @mrkamin,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request
⚠ Kindly remove the instructions aiming to inform you below on your README file.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

Hi, @huseyinbiyik
thanks for your valuable feedback

Hi @mrkamin,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Linter set up well and checks pass 🟢
Gitflow followed 👌
.gitignore used to ignore requested files 📁
PR description is descriptive 📝

Required Changes ♻
Check the comments under the review.
Optional suggestions

Please make sure your commit messages are meaningful and descriptive for your next commits. Use imperative tense and capitalize the first word. For example,
👌"Add logo to navigation bar"
👌"Fix close button functionality on mobile navbar"
❌ "Added logo to navigation bar"
❌ "Added HTML"
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi, @huseyinbiyik
thanks for your valuable feedback I will take them into account in my future commit s


data-bindgen-target not working for worker type

Hello I'm building a webapp in yew and serving it with trunk.
My app has a few NPM dependencies which I'm bundling using this method with esbuild. This works great but now I'm trying to add a webworker so I defined an additional data-bin with the worker data-type. However when I tried to serve the app I get the following error:
NPM dependencies have been specified in '<dir>/package.json' but this is incompatible with the 'no-modules' target
Reading the assets docs made me think that I should include data-bindgen-target="web" in the worker's  link tag. However when I serve with verbose logging on I see that wasm-bindgen is still being called with --target=no-modules for the worker.
To be clear the main app is the only place that depends on NPM backages the worker code is only rust so I don't need those dependencies available in the worker bin.
Any help solving this would be much appreciated.

It's hard to tell without a reproducer. I would recommend taking a look at the two existing webworker examples.

I have looked at the webworker examples but none of them include NPM dependencies. I will work on making a reproducer.

A good way to include JS dependencies seems like this pattern (not my idea, just using that too): https://github.com/ctron/popper-rs/tree/main/popper-rs-sys

Here's a minimal example of the issue I'm dealing with: https://github.com/SAdams601/webworker_npm_replicator
bonnie run generates the appropriate src/package.js file and starts trunk. This logs the error I mention in my initial post.
I'm not sure if this setup is something trunk you want trunk to support but I do find it useful to manage some NPM dependencies as part of my project directly rather than in adjacent crates.

Thanks for providing the reproducer. There's a bunch of things wrong with. Unfortunately, I don't have the time to fix it up.
Just a few quick pointers:

You're including the JS both through a script tag, as well as through wasm_bindgen, that won't work as these are two distinct modules later on
JS imported through wasm-bindgen must be a JS module, yours seems to the common js, so that also won't work

My recommendation would be:

If you're creating custom JS code, create it as a ESM (JS module), that can be used right away
If you're importing other JS code, calling it from Rust: turn it into an ESM. rollup works fine for this in many cases. that's what the example I provided uses. You might also be able to get there using esbuild, but I don't know.
if you want to call into JS, wasm_bindgen attributes alone are enough, there's no need to adding a script tag

I am sorry I can't help more right now.

I am sorry I can't help more right now.

Don't worry about it! Thank you for the tips and the link to your example project I'll be able figure it out.


Clickable link from link.

Good morning!
While writing this feature request, I've noticed how overloaded the term link is!
One feature from the cacti weathermaps that I miss is the ability to hover over a link, and see the bandwidth graph for that link pop up.
I appreciate that this is unlikely to be feasible to implement in that way.
Would it be possible to make it so you click a link, and it takes you to a custom dashboard with the variables used to define that link? This way we could click through to a graph of the link.

I have made it so that you can just forward to whatever you'd like for each link. I had actually played around with showing graphs on link hover, and I may even consider this in the future, since if you are passing the panel a bunch of data frames already, there is no reason I couldn't just construct a graph (and I am looking into some ways to maybe just render a whole panel). Until then, you can simply add a "Dashboard Link" to each of the link's sides, which can just be a url. If you'd like to link to specific graphs, you can just click "Share" on that panel in Grafana and then get a URL for it.


fix: QnAMakerDialog to handle interuption scenarios

Fixes #3345
Description

Ported latest changes of QnAMakerDialog/QnAMakerRecognizer from C#.
Specific Changes

New interface QnAMakerClient
New turn state key QnAMakerClientKey
Added continueDialog and onPreBubbleEvent to QnAMakerDialog
Added fillRecognizerResultTelemetryProperties to QnAMakerRecognizer
Updated access modifiers

Testing

Updated corresponding tests.

Pull Request Test Coverage Report for Build 612631753

0 of 0   changed or added relevant lines in 0 files are covered.
76 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.2%) to 84.754%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-ai/src/qnaMaker.ts
1
96.18%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/trigger.ts
2
61.63%

libraries/botbuilder-dialogs/src/recognizer.ts
3
85.11%

libraries/botbuilder-ai/src/qnaMakerRecognizer.ts
26
64.02%

libraries/botbuilder-ai/src/qnaMakerDialog.ts
43
72.79%

Totals

Change from base Build 594031505:
0.2%

Covered Lines:
18619

Relevant Lines:
20933

💛  - Coveralls


Tutorials need new screenshots with desktop Small Basic editor

The screenshots were added. If we're missing anything, we can open new issues/PRs to fix that.


Editor crash with godot 4.3 mono

With a blank project in godot 4.3 mono  GodotSteam server GDExtension will cause a hard editor crash.
cannot open project till GodotSteam server is removed from addons. same also happens with both with and without GodotSteam GDExtension installed
console output if it helps
Z:\Godot\Installs\Godot_v4_3-stable_mono_win64\Godot_v4.3-stable_mono_win64>Godot_v4.3-stable_mono_win64_console.exe
Godot Engine v4.3.stable.mono.official.77dcf97d8 - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 555.99 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 3090

Editing project: Z:/Perforce/ewrt_BlackHole_ShrubHiders_Main_5820/Godot

================================================================
CrashHandlerException: Program crashed with signal 11
Engine version: Godot Engine v4.3.stable.mono.official (77dcf97d82cbfe4e4615475fa52ca03da645dbd8)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
  Sorry I didn't see this earlier somehow.  I have seen this kind of error before but don't remember what it is right this second.  I will check it out!

i compile godot with debug symbols to get a better error log, might have a better poke round if i get the time
================================================================
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.3.stable.mono.custom_build (77dcf97d82cbfe4e4615475fa52ca03da645dbd8)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] StringName::unref (Z:\Godot\Repos\godot-4-3-0\core\string\string_name.cpp:122)
[1] StringName::unref (Z:\Godot\Repos\godot-4-3-0\core\string\string_name.cpp:122)
[2] <couldn't map PC to fn name>
[3] <couldn't map PC to fn name>
[4] <couldn't map PC to fn name>
[5] <couldn't map PC to fn name>
[6] GDExtension::open_library (Z:\Godot\Repos\godot-4-3-0\core\extension\gdextension.cpp:817)
[7] GDExtensionResourceLoader::load_gdextension_resource (Z:\Godot\Repos\godot-4-3-0\core\extension\gdextension.cpp:103)
[8] GDExtensionResourceLoader::load (Z:\Godot\Repos\godot-4-3-0\core\extension\gdextension.cpp:1072)
[9] ResourceLoader::_load (Z:\Godot\Repos\godot-4-3-0\core\io\resource_loader.cpp:269)
[10] ResourceLoader::_thread_load_function (Z:\Godot\Repos\godot-4-3-0\core\io\resource_loader.cpp:323)
[11] ResourceLoader::_load_start (Z:\Godot\Repos\godot-4-3-0\core\io\resource_loader.cpp:544)
[12] ResourceLoader::load (Z:\Godot\Repos\godot-4-3-0\core\io\resource_loader.cpp:460)
[13] GDExtensionManager::load_extension (Z:\Godot\Repos\godot-4-3-0\core\extension\gdextension_manager.cpp:75)
[14] GDExtensionManager::load_extensions (Z:\Godot\Repos\godot-4-3-0\core\extension\gdextension_manager.cpp:234)
[15] register_core_extensions (Z:\Godot\Repos\godot-4-3-0\core\register_core_types.cpp:362)
[16] Main::setup (Z:\Godot\Repos\godot-4-3-0\main\main.cpp:1824)
[17] widechar_main (Z:\Godot\Repos\godot-4-3-0\platform\windows\godot_windows.cpp:165)
[18] _main (Z:\Godot\Repos\godot-4-3-0\platform\windows\godot_windows.cpp:208)
[19] main (Z:\Godot\Repos\godot-4-3-0\platform\windows\godot_windows.cpp:220)
[20] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[21] <couldn't map PC to fn name>
-- END OF BACKTRACE --
================================================================

Sorry, I still have to find that old issue.  While we don't officially support Mono, this should still work.  I am doing server updates today, so maybe that will help!

i should add that i do get this crash/error in non Mono godot 4.3

Hmm... that's incredibly weird.  Is this the newest one because the Windows 64-bit version is busted but is fine in the previous build.

Wait.. .I am very dumb.  This is servers.  These updates are coming soon, my bad!


PowerShell 7.1.0-preview4 x64 executable removes PowerShell 7.0.2 and does not install preview4

Steps to reproduce

Install PowerShell 7.1.0-preview3 (<IP_ADDRESS>) [PowerShell-7.1.0-preview.3-win-x64.msi]
Install PowerShell 7.0.2 [PowerShell-7.0.2-win-x64.msi]
Verify that both appear separately in C:\Program Files\PowerShell\
Install PowerShell 7.1.0-preview4 (<IP_ADDRESS>) [PowerShell-7.1.0-preview.4-win-x64.msi]
Verify C:\Program Files\PowerShell\7\ and C:\Program Files\PowerShell\7-preview\ again

Expected behavior
PowerShell Preview is updated to 7.1.0-preview4 and PowerShell 7.0.2 is not deleted.
Actual behavior
PowerShell 7.0.2 is being deleted from C:\Program Files\PowerShell\7\
PowerShell 7.1.0-preview4 is not installed (but its installation is added to registry)
PowerShell 7.1.0-preview3 is installed.

Environment data

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Microsoft Windows 10.0.20150
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Additional info
This happened on my main PC (Windows 10 2004, build 19041.329) as well as I was able to reproduce it in VM with Windows 10 Insider Preview (build 20150.1000)
Also latest preview installation executable does not appear to have digital signature attached in comparison to the previous preview.
Something for @TravisEz13 I guess?

Will be fixed n #13036 I guess.

How to install preview-4 without .MSI?
Now I cannot use pwsh in Windows Terminal.

Might want to pull the notification of the new update that happens inside the preview 3. That's a bit of a big oopsie.

Might want to pull the notification of the new update that happens inside the preview 3. That's a bit of a big oopsie.

We are working to release preview 5 as quickly as possible.  Feel free to file a feature request for the ability for us to disable the update notification functionality for a release, but I don't think it is viable at this time.

Feel free to file a feature request for the ability for us to disable the update notification functionality for a release

We already have such issue.

i just installed preview5.  it installed properly.  but not 7.0.2 since it thinks preview is a higher version
https://github.com/PowerShell/PowerShell/pull/13036#issuecomment-654875234

See https://github.com/PowerShell/PowerShell/pull/13036#issuecomment-655039948


Export validator rules individually

Currently enforceExtended is 29kb due to the validator.js rules. If we export each rule individually and let consumers mix and match it will make it way smaller.
import { enforce } from 'vest';
import isEmail from 'vest/enforce/isEmail;

enforce.extend({ isEmail })

Ok, are you looking for left some of those rules like defaults?
I took a look into the code of enforce I think that this could be accomplish by just by changing the
// const rulesObject = { ...rules };
const rulesObject = { };

https://github.com/ealush/vest/blob/latest/packages/n4s/src/enforce/index.js
and change the imports for exports in, but I'm not quite sure of how to make the export from vest/enforce/ruleName without changing the folder structure
https://github.com/ealush/vest/blob/latest/packages/n4s/src/rules/index.js

I would like to take this issue,
but first I want to be sure that I fully understand it.
the vest\packages\n4s\src\extended\rules\index.js file import the rules and export it all like that:
 import isEmail from 'validator/es/lib/isEmail'; export default {   isEmail,   ... };
and the rules need to exported individually like that:
import isEmail from 'validator/es/lib/isEmail'; ...; export default isEmail; ...;
Is that right?
thanks in advance.

Hey @Moses3301, thanks for reaching out!
Yes, you understand it correctly. The idea in general is to mirror the validator.js rules for easier consumption (no need to install multiple packages), but still have it as their own exports so that it doesn't add much unneeded bloat to whoever's using it.
One thing I am thinking, is that we don't need to have that supported on the n4s packages, but just on vest (n4s isn't really used outside of vest).
Setting this up would probably require adding some rollup configuration to support these exports. There is a need to add a similar setup to the utilities config, only to support the exported enforce rules.
See here:
https://github.com/ealush/vest/blob/latest/packages/vest/config/rollup/rollup.config.js
It should be relatively straightforward, but if you require any assistance, I am here :)


Choose license for specifications and implementations

Primary goals of this working group are to create specifications for API standards as well as working implementations of API Standards as reference models. Both specifications and code need explicit and permissive licensing in order to be widely useful.
Task

[ ] Discuss licensing options

[ ] Code
[ ] Documentation/specification

[ ] Choose a license for API Standards project deliverables

[ ] Code
[ ] Documentation/specification

[ ] Add license(s) to respective repositories
[ ] Add reasoning for licensing choices to project documentation

I believe that specifications and reference code should be licensed vary permissively, e.g. under MIT. However, it may be worth considering a license such as the Apache license. Some reasons Apache license may be worth considering include:

Consideration of Patents that other licenses may omit
Possibility of the API Standards project entering the Apache incubation process

In regards to documentation, I propose using a Creative Commons license, such as CC Zero Universal.