Complicated dependency structure causes issues if not followed perfectly

I am passing a string into a route callable: Embark\Journey\Home\GetAction.
The class referenced does not exist, so I would expect an exception from the CallableResolver telling me so, but unfortunately I get:

```
Catchable fatal error: Argument 1 passed to Slim\Handlers\Strategies\RequestResponse::__invoke() must be callable, string given, called in /Users/designermonkey/Projects/Sites/app.nigella.local.embarknow.net/vendor/slim/slim/Slim/Route.php on line 317 and defined in /Users/designermonkey/Projects/Sites/app.nigella.local.embarknow.net/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php on line 32
Call Stack
#	Time	Memory	Function	Location
1	0.0002	240616	{main}( )	.../index.php:0
2	0.0095	1181144	Slim\App->run( )	.../index.php:32
3	0.0149	1903568	Slim\App->callMiddlewareStack( )	.../App.php:308
4	0.0149	1903712	Slim\App->Slim\{closure}( )	.../MiddlewareAwareTrait.php:114
5	0.0149	1903760	call_user_func:{/Users/designermonkey/Projects/Sites/app.nigella.local.embarknow.net/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:67} ( )	.../MiddlewareAwareTrait.php:67
6	0.0149	1904016	Slim\Csrf\Guard->__invoke( )	.../MiddlewareAwareTrait.php:67
7	0.0150	1907032	Slim\App->__invoke( )	.../Guard.php:146
8	0.0155	1935704	Slim\Route->run( )	.../App.php:398
9	0.0155	1935840	Slim\Route->callMiddlewareStack( )	.../Route.php:288
10	0.0155	1936880	Slim\Route->__invoke( )	.../MiddlewareAwareTrait.php:114
11	0.0157	1961136	Slim\Handlers\Strategies\RequestResponse->__invoke( )
```

I have no idea even how to debug this :(
If I've been an idiot, please let me know.
Edit: The original issue is my code, but the cause is as the title edit above

Can we see the actual code ?

As this is a custom code route mapper, it turns out that it is because the container isn't passed along properly during my mapping process.
I have to say from reading through all this code, I am pretty shocked at how much the container is passed around outside of class definitions in the initial container setup! The point of a dependency container is to resolve dependencies before your app runs, so code like this
    public function map(array $methods, $pattern, $callable)
    {
        if ($callable instanceof Closure) {
            $callable = $callable->bindTo($this);
        }

        $route = $this->container->get('router')->map($methods, $pattern, $callable);
        if (is_callable([$route, 'setContainer'])) {
            $route->setContainer($this->container);
        }

        if (is_callable([$route, 'setOutputBuffering'])) {
            $route->setOutputBuffering($this->container->get('settings')['outputBuffering']);
        }

        return $route;
    }

taken from the App class is pretty bad. The chain here should be that the Router has the container and passes it along to the Route before it returns it from the map method. This code is really complicated because of this requiring the container at a later stage.
Dependencies of the Router (being Route) require a Container, so that by logic becomes a dependency of the Router, as it is a factory for Route; It must already have all the requirements for Route, as Route can't function correctly without them.

The OCD in me is making me tidy this up, hopefully won't be long chaps...

Yeah I am all for cleaning up the internals... It does appear to be a mess and I dislike reading the router code especially since there is no comments describing what is going on.
Why can't we actually just have a RouteFactory that handles the construction of the routes ?
Dependencies can be injected from the container and then the logic for making a route falls in that factory class.

Personally, I would be all for a factory instance, but I'll keep the footprint of classes the same for now, and just tidy the functionality.

Maybe for 3.1 ... Reading through the source it just screams spaghetti  ... there are a lot of optimizations that can be done ... but I know there is quite a push to get it to release atm.

Maybe I should come back to this another day then.

I would tag for 3.1 might as well do it proper. Then again others might not care for the Factory methods ;)

It's open for discussion anyway :)

I would like to see a PR with the cleanups, even if it includes a RouteFactory, anything to make the code more readable and easy to follow is welcomed.

@designermonkey @geggleto I have taken a shot at this and would like some feedback from both of you #1497

Hi @silentworks I can see where you're aiming for here, but I must say I think it is still too overly complicated. No offence meant.
To me, the complication lies within the Route and Router classes themselves; the fact they both need a container, middleware awareness, callable resolving etc, and the hoops being jumped through to make them work. The aim of Slim 3 was to simplify and decouple the overly complicated dependencies (at least how I understood when we started). Dependencies in groups like a Router and Route are fine, and some obvious ones are too like a container, but I feel like the chain here is too heavy at the bottom.
Re-reading my comments earlier in the thread, I may have come off a little hot, with no intention, so apologies there. This is way better than it was.
I really want to delve into this properly, with the eye on the separation of routing as much as possible from Slim, so it could be used without it (I'm not suggesting actual separation from the codebase).
Can I ask for someone to explain the invocation strategy idea? Why was this needed?

The invocation strategy came about because some people really wanted the function signature for route callables to be very close to Slim 2's to make it easier for migration and setting parameter defaults.

Nothing further to do here.


Auto include testVar.mk in playlist

Signed-off-by: renfeiw<EMAIL_ADDRESS>

internal grinder: Grinder_TKG/1504

@renfeiw could you resolve the merge conflict? Thanks

@renfeiw could you resolve the merge conflict? Thanks

resolved, thank you.


Dark mode has been added to the Dashboard and other pages.

Description 📝
Dark mode with appropriate colors has been added as per instructions.
Screenshots

@PiyushKalyanpy I have added it.


Remove version: IDMComputerSolutions,Inc.UltraEdit version 30.2.27

Description

Resolve #133241

Checks

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

URL:
Status Code: 200
(Automated message - build 543)


[libgit2] Update to 0.99.0

Describe the pull request

What does your PR fix? https://github.com/libgit2/libgit2/releases/tag/v0.99.0

Which triplets are supported/not supported? Have you updated the CI baseline? N/A

Does your PR follow the maintainer guide? Yes

Changes might be breaking but maintainers say it is expected to be API-compatible with the previous version.

/azp run

Thanks @kevinlul :)


Allow special aesthetic for relative positioning

Not very clear on what we want this to be. I think a good starting point would be allowing a yrelative (or some better name) in plot_dist which is then converted into an actual y value multiplying by the maximium of the kde/hist/ecdf inside plot_dist.
Idea of steps involved:

User provides yrelative values
aesthetics are generated for yrelative which can be retrived as dataset
yrelative dataset is multiplied by density.max(some_dims) -> xarray handles all aligment and broadcasting
y aesthetic is created and yrelative deleted or yrelative gets its values overwritten and the aesthetic renamed (whatever we find easier to implement)
Plotting backends only see y aesthetic

This might not 100% work with the exact relative ratios we'd want but I think it will generally be good enough and probably much easier than attempting to handle relative spacing across backends. But it is also true I have literally no idea how to use relative units in bokeh nor plotly, so it is always possible that is easier than the steps above.

I agree in general, but just providing y may be enough, as we then scale them by max density. At least for plots like plot_dist, it makes sense to always think of y in relative terms.


Auto update auth token after upgrading to deluxe

Fixes: #1368

payment.component.spec.ts doesn't compile, oherwise code looks good! 👍

I've removed the tests for the logout function (removed it because it's no longer being called anywhere). Should work now


[SPARK-12792][SPARKR] Refactor RRDD to support R UDF.

What changes were proposed in this pull request?
Refactor RRDD by separating the common logic interacting with the R worker to a new class RRunner, which can be used to evaluate R UDFs.
Now RRDD relies on RRuner for RDD computation and RRDD could be reomved if we want to remove RDD API in SparkR later.
How was this patch tested?
dev/lint-r
SparkR unit tests

@davies, this is the new PR.

Test build #54405 has started for PR 12024 at commit 1eda42c.

Test build #54405 has finished for PR 12024 at commit 1eda42c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54405/
Test PASSed.

Merging into master, thanks!


Increase PSQ Timeout

The timeout for PSQ workers pulling requests off the queue seems very low (10 seconds maybe?).  We should find a way to increase this to something larger.

@aarontp I would like to take this task too!
I've been watching some PSQ examples, this one in particular seems to be helpful: https://github.com/GoogleCloudPlatform/psq/blob/master/examples/run.py
This shows that we could increase the timeout by passing a timeout parameter on the queues .result() method. I'm thinking on adding this on PSQTaskManager.process_tasks() in line 415 we have task.result = task.stub.result() we can add the timeout tho that result, but it should be parametrized somewhere.
What do you think about this?

Sounds good;  What is the timeout set to by default?  For parameterization I think we can just add something like a TASK_TIMEOUT somewhere near the top of task_manager.py.  I don't think it needs to be a config var.

@aarontp seems like the default value is None, meaning that the task will wait forever to complete.
https://github.com/GoogleCloudPlatform/psq/blob/e27e2f37520f1f0d3006b8ba8ea214e8a57c7563/psq/task.py#L148

Huh, interesting.  Thanks for tracking that down.  I wonder if it's always been that way since in the past it seemed to time out, but maybe I was seeing other problems with scheduling that just looked like timeouts.
In that case it's a pretty low priority compared to other things, but it might be nice to have something set anyway just to be explicit, and so that things will eventually error out.  Tasks can potentially take a couple days or more to run, so I suggest setting the timeout at one week for now, and one it's parameterized it will be easy to change later.

Yeah, I've been finagling with something similar on the Celery side. I have some changes TODO that can re-use the timeout you're adding.


Create how-range-requests-work-at-cloudflare.md

As per PCX-8069, we have been receiving requests from customers on which they need to understand how Range Requests work with Cloudflare. We currently have the following internal wiki for this:
https://wiki.cfdata.org/display/~gagan/How+range+requests+work+at+Cloudflare
If possible, it would be helpful for customers to have a similar public source of this flow.

Howdy @luis-henriquecardoso, can you update the filename to remove the spaces and instead add the images to the /assets/images/cache folder?

@luis-henriquecardoso I'm closing this out as changes are planned. I'll follow up on the ticket.


SELECT EXISTS query — cannot get result

What's a good way to do SELECT EXISTS (SELECT 1 from tablename WHERE primarykey="something" from Dart?
I've tried using a customSelect, but although the Select runs, there's no way to get the result out, as Moor isn't able to map the result type (type_system.dart). Which seems a bit odd, as it's getting a 1 or 0 back, which I can see when I use the debugger in variables.dart — value is 1.
  dynamic mapToSimpleValue(GenerationContext context) {
    final type = context.typeSystem.forDartType<T>();
    return type.mapToSqlVariable(value);
  }

The reason I'm doing this is that this kind of query seems to be the canonical way to check existence of a row by primary key, for Sqlite: (links to a note from the Sqlite authors)
https://stackoverflow.com/questions/9755860/valid-query-to-check-if-row-exists-in-sqlite3

If I add the query in the @UseMoor annotation, I get a warning:
[INFO] moor_generator:moor_generator on lib/sync/database.dart:Lint for itemExistsImpl: line 1, column 8: Expression has an unknown type, the generated code can be inaccurate.
  ╷
1 │ SELECT EXISTS(SELECT 1 FROM items WHERE base=? and path=?);
  │        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

However, the code works — I get a List<String> ['0'] or ['1'] back from the itemExistsImpl method.
I guess both approaches would work okay if Moor understood that SELECT EXISTS returns an integer.

You can try to cast it in the @UseMoor annotation:
SELECT (CAST(EXISTS(SELECT 1 FROM items ...) AS BOOLEAN));

Thanks, that works in @useMoor.
I also thought it might work in the customSelect, but it doesn't — even with the cast, Moor is still confused about its type when getting the results.

If I add the query in the @UseMoor annotation, I get a warning

This is a bug (or rather, a case I overlooked) in the sqlparser package. It will be fixed in the next moor version, thanks for the report!

Moor is still confused about its type when getting the results.

Can you post your customSelect usage? I haven't tried it, but I imagine that something like this should work:
final bool hasItems = customSelect(
  'SELECT EXISTS (SELECT 1 FROM items WHERE base = ? AND path = ?) AS r',
  variables: [Variable.withInt(1), Variable.withInt(2)],
).map((row) => row.readBool('r')).getSingle();

I have in the past used something like this:
import 'package:moor/moor.dart';

class ExistsStatement<T extends Table, D extends DataClass> extends Query<T, D>
    with
        SingleTableQueryMixin<T, D>,
        // ignore: prefer_mixin
        Selectable<bool> {
  ExistsStatement(QueryEngine database, TableInfo<T, D> table) : super(database, table);

  @override
  Future<List<bool>> get() async {
    final ctx = constructQuery();
    return _getWithQuery(ctx);
  }

  Future<List<bool>> _getWithQuery(GenerationContext ctx) async {
    final exists = await ctx.executor.doWhenOpened((e) async {
      final result = await e.runSelect(ctx.sql, ctx.boundVariables);
      return result.first.values.first == 1;
    });
    return [exists];
  }

  @override
  Stream<List<bool>> watch() {
    throw UnimplementedError('Watching exists queries is not implemented!');
  }

  @override
  void writeStartPart(GenerationContext ctx) {
    ctx.buffer.write('SELECT EXISTS (SELECT 1 FROM ${table.tableWithAlias}');
  }

  @override
  GenerationContext constructQuery() {
    final ctx = GenerationContext.fromDb(database);
    var needsWhitespace = false;

    writeStartPart(ctx);
    needsWhitespace = true;

    if (whereExpr != null) {
      if (needsWhitespace) {
        ctx.writeWhitespace();
      }

      whereExpr.writeInto(ctx);
      needsWhitespace = true;
    }

    ctx.buffer.write(');');
    return ctx;
  }
}

@simolus3 thanks
The following customSelect works for me.
  Future<bool> itemExists(int baseId, String path) async {
    final QueryRow row = await customSelect(
      'SELECT EXISTS (SELECT 1 FROM items WHERE base = ? AND path = ?) AS r',
      variables: [Variable.withInt(baseId), Variable.withString(path)],
    ).getSingle();
    return row.readBool('r');
  }

Great! I'll close this issue then, EXISTS missing from the Dart api is roughly covered by #612.


⚠ Samsung has degraded performance

In 9d41a3c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2444 ms

Resolved: Samsung performance has improved in c928389.


Error when running DupFinder

Here is the error that I keep getting when I run any Jetbrains tools.  I have this error in three different repos.
========================================
DupFinder
Executing task: DupFinder
The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and
the directory name must be less than 248 characters.
NuGet exited with 1
An error occured while installing package JetBrains.ReSharper.CommandLineTools.
Error: Failed to install tool 'JetBrains.ReSharper.CommandLineTools'.
Deleting file C:/Users/cphil/code/Cake.XdtTransform/e1cd281f-d488-438f-9dda-38d5948c26bc.cake
An error occurred when executing task 'DupFinder'.
Deleting file C:/Users/cphil/code/Cake.XdtTransform/25fdbcd9-6775-461f-8853-02a837c17c5a.cake
Duplicates were found in your codebase, creating HTML report...
Unable to locate Input File

@phillipsj I am "fairly" sure, that this has been fixed.  As such, I am going to close this off.  Let me know if still an issue.


Add TorchVision wheel builds for M1

Also the linter is complaining for a trailing new line that is missing.

@malfet @atalman
as @datumbox noted above https://github.com/pytorch/vision/pull/5948#issuecomment-1134505355, we're not certain that torchvision properly works on M1. In order to avoid additional bug reports from users, are you planning to add an M1 CI so we're sure the binaries are working properly?

In order to avoid additional bug reports from users, are you planning to add an M1 CI so we're sure the binaries are working properly?

@NicolasHug we don't have a capacity to run PR CI on M1 right now (there are 4 machines in total for the entire org), but if you can pick a few smoketests we can try running them.

@malfet Our users are currently reporting that multiple parts of TorchVision are not working on M1: https://github.com/pytorch/vision/issues/6067, https://github.com/pytorch/vision/issues/5893, https://github.com/pytorch/vision/issues/5413
If that's true, it will take more than a couple of smoketests to debug, fix and ensure it works smoothly. If we currently don't have the resources for adding proper support for M1 and testing them across PyTorch, we should revert this PR and consider adding it back once we have the necessary capacity. Otherwise, after release we will have a huge volume of users, reporting that TorchVision is broken on M1 with maintainers unable to know what to do next and how to address this. We are happy to discuss a middle ground solution that allows us to run our tests in one configuration on M1. Please let me know.

@datumbox thank you for sharing. All those sound like a basic packaging issues to me, so I'm not sure how CI testing (where system is configured to have all above mentioned dependencies will help) And even if PR CI would be enabled, those machines would not have rerun with SSH capability.
But we should definitely test for the conditions mentioned in above during packaging.

I had an offline discussion with @malfet concerning this. I'll summarize here what was discussed:
Our team doesn't have an M1 mac locally but even if we did, we still need to test each PR prior merging on at least one M1/Python configuration. Nikita agreed that since TorchVision is the first to be onboarded on native M1, we can do that now. Nevertheless because PyTorch has only 4 machines, it is not guaranteed that the job will be maintained. To avoid having the job removed, TorchVision should dedicate time to speed up CI execution for its tests.
I will therefore use the approach on this PR to add a unit-test job for a single python configuration. See #6111


Add health check

See https://blog.jola.dev/health-checks-for-plug-and-phoenix

I am using / for this purpose, but it occurred to me that regularly polling a live view may not be such a good idea.


Adding Office 365 CLI reference for SPFx upgrade

Category

[x] Content fix
[ ] New article

What's in this Pull Request?

Added mention of Office 365 CLI as upgrade option from SPFx  solutions older than 1.4

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/tenant-scoped-deployment.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx @willhaywood, appreciated.


detail namespace collision with Cereal?

I'm seeing a very strange bug when using your library in conjunction with C++ Cereal: https://github.com/USCiLab/cereal
Reproduce with the following:
#include <json.hpp>

#include <cereal/types/polymorphic.hpp>
#include <cereal/archives/binary.hpp>
#include <cereal/access.hpp>       //So we can make serialize private so developers aren't tempted to call it.
#include <cereal/types/string.hpp> //This is needed to serialize std::string. There are similar ones for the other std containers
#include <cereal/types/vector.hpp> //This is needed to serialize std::vector. There are similar ones for the other std containers

using namespace std;

//Pure virtual base class
class Serializable
{
    public:
        virtual int getType() = 0;

    protected:
        template<class Archive> void serialize(Archive & ar);
};

class Bug: public Serializable
{
    public:
        std::string text;
        int getType() {return 1;};
        void load(const nlohmann::json & s) {};

    private:
        friend class cereal::access;
        template <class Archive> void serialize(Archive &ar) {ar(text);};
};

// Register Bug
CEREAL_REGISTER_TYPE(Bug);
CEREAL_REGISTER_POLYMORPHIC_RELATION(Serializable, Bug);

int main()
{
    auto obj = make_shared<Bug>();

    std::ostringstream os;
    {
        cereal::BinaryOutputArchive oarchive(os);
        oarchive(dynamic_pointer_cast<Serializable>(obj));
    }

    shared_ptr<Serializable> obj2;
    std::istringstream is(os.str());
    {
        cereal::BinaryInputArchive iarchive(is);
        iarchive(obj2);
    }

    auto m = dynamic_pointer_cast<Bug>(obj2);

    return 0;
}

This code, when compiled with the latest nlohmann::json throws the following:
Trying to load an unregistered polymorphic type (Bug).
Make sure your type is registered with CEREAL_REGISTER_TYPE and that the archive you are using was included (and registered with CEREAL_REGISTER_ARCHIVE) prior to calling CEREAL_REGISTER_TYPE.
If your type is already registered and you still see this error, you may need to use CEREAL_REGISTER_DYNAMIC_INIT.

Curiously though, compiling against a 2.X version of nlohmann::json does not produce this exception.
I noticed this only happens when the method in the Bug class is load, which is why I'm opening an issue with cereal as well.
I noticed one change from nlohmann::json 2.X->3.X is the inclusion of the nlohmann::detail namespace. Could this be somehow conflicting with cereal::detail? I will also open an issue against cereal as well.
Still trying to figure out root cause of this. It may not be your library, just trying to figure out why I can no longer use nlohmann::json with Cereal when I upgrade from 2.X to 3.X
Cereal issue: https://github.com/USCiLab/cereal/issues/499

The detail namespace was introduced in 2.1.0 IIRC, and unless you are doing something like:
using namespace cereal;
using namespace nlohmann;

I don't see how that could be a problem, lots of libraries have a detail namespace.
Unfortunately I've never used cereal, let's hope you get more info on the other issue!

I've confirmed that the break occurs precisely from 2.0.10 -> 2.1.0.
The following minimum example compiles under nlohmann::json version 2.0.10 but does not compile under 2.1.0:
#include <json.hpp>

#include <cereal/archives/binary.hpp>
#include <cereal/access.hpp>       //So we can make serialize private so developers aren't tempted to call it.
#include <cereal/types/string.hpp> //This is needed to serialize std::string. There are similar ones for the other std containers
#include <cereal/types/vector.hpp> //This is needed to serialize std::vector. There are similar ones for the other std containers

using namespace std;

class Bug
{
    public:
        std::string text;
        void load(const nlohmann::json & s) {};

    private:
        friend class cereal::access;
        template <class Archive> void serialize(Archive &ar) {ar(text);};
};

int main()
{
    Bug obj;
    std::ostringstream os;
    {
        cereal::BinaryOutputArchive oarchive(os);
        oarchive(obj);
    }

    Bug obj2;
    std::istringstream is(os.str());
    {
        cereal::BinaryInputArchive iarchive(is);
        iarchive(obj2);
    }

    return 0;
}

Note that under 2.1.0 changing the name of Bug::load to Bug::loadJson also resolves the issue. Definitely some kind of collision occurring here, still trying to find root cause.

Update: I've confirmed it is definitely not a namespace collision. I renamed detail to an arbitrary name and I still see the same problem. Instead, it looks like somehow Cereal thinks the nlohmann::json type is a cereal::Archive such that when passed into a function named load it thinks I am registering a new load/save function

This sounds like it is more an issue on Cereal's side. I'm note sure how to proceed here.

Something in the transition from 2.0.10 -> 2.1.0 seems to have broken cereal. I tried to debug, but cereal is an extremely templated library and I was having a hard time tracking down the root cause of the break. We can go ahead an close this issue and I will only reopen if I conclusively find evidence it is your library's fault.

Thanks!


KAFKA-2770: Catch and ignore WakeupException for commit upon closing

ping @becketqin @hachikuji @granders for reviews.

LGTM. One minor note: I think the rethrow in commitOffsets() might not be needed since the isShuttingDown flag is used to break out of the loop. However, I actually prefer to keep it that way since it ensures it maintains the invariant that wakeups are guaranteed to reach the poll loop.

Admittedly this is not the most elegant way of patching this issue, as I feel the new / old consumer's usage pattern is quite different and tricky to be unified, and a better solution would be a new MM class that only uses new clients, but that may be worth another ticket.

@guozhangwang Have you verified that the corresponding system test passes with this change?

Not yet, could you let me know which test case I should verify against? And how often it was reproducible before (I think it is timing dependent)?

@guozhangwang You'll need to delete the @ignore annotation for this particular test
you can run with:
ducktape tests/kafkatest/tests/mirror_maker_test.py::TestMirrorMakerService.test_bounce --parameters '{"clean_shutdown":true, "new_consumer":true}'

LGTM.
I'll merge after you remove the "@ignore" flag from the test

@granders @hachikuji The integration test now passes with no data loss (tested 3 times, and previously it breaks every time). The fix is not optimal such that it maintains a separate offset map for new consumer to commit, as mentioned above the optimal solution would be not unifying the interfaces of old / new consumers and re-work MM with only the new clients.

@guozhangwang This looks good to me. Probably good for @hachikuji  to take a quick look since he is more familiar with the new consumer.
Also, it would be good to verify the hard bounce test case (it sounds like only the clean bounce was verified)

@guozhangwang Only question I have is whether we should be clearing the offset map on rebalances? If we don't clear it, wouldn't that cause us to commit offsets from older generations?

@hachikuji Good point. Instead of clearing on rebalance, I would prefer clearing right after each commit since that is simpler.

@guozhangwang Yep, that works too. LGTM.

Merged to both trunk and 0.9.0 branch.


az spring app deployment create | Fixing how Enterprise users get JVM 17 as their runtime

Moving MicrosoftDocs/azure-docs-cli PR #3511 and PR #3510 as these are changes to an autogenerated doc.
Please route these suggested updates to the service team for review.  Possible files impacted:

azure-cli-extensions\src\spring\azext_spring_params.py
azure-cli-extensions\src\spring-cloud\azext_spring_cloud_params.py

Screen print of suggested source code update:

route to CXP team


Doc update: Change RaisedButton to ElevatedButton

Because RaisedButton is deprecated and is being replaced by ElevatedButton.

Thanks


New Trial API support

Feature request

firestore-stripe-subscriptions

Is your feature request related to a problem? Please describe.
If I am not wrong this extension supports the old trial API when we added the trial period days to the price object.

But Stripe suggests that we should apply the trial days through the subscriptions or quotes.

This feature is compatible with the checkout sessions or should we wait for the support in this extension?

Duplicate of https://github.com/stripe/stripe-firebase-extensions/issues/105

@thorsten-stripe Thanks, I follow it and I'm sorry for the duplication, I was inattentive.


[NoQA] Tests for group chat name

Details
Tests for group chat name.
Fixed Issues
$ https://github.com/Expensify/App/issues/40189
PROPOSAL: https://github.com/Expensify/App/issues/40189#issuecomment-2053660120
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ShridharGoel What caused the workflow issues?

@ShridharGoel Did you get a chance to check my above comment? (Also please fix ts errors)

@ShridharGoel Can you please fix the ts errors

@ShridharGoel Any updates on this?

@ShridharGoel Any updates?

@ShridharGoel Did you get a chance to look into this?

@ShridharGoel This PR still needs to be merged Were you able to look into addressing the previous review

@ShridharGoel do you think we can get this wrapped up by the end of the week?

@ShridharGoel Please address https://github.com/Expensify/App/pull/46661#discussion_r1729438186 as well

The failing part is related to LHN not the report header. Both are returning 5 items which seems correct (and consist), let's just update the test to reflect that

Can you check why is the UnreadIndicatorsTest failing

@ShridharGoel Please address https://github.com/Expensify/App/pull/46661#discussion_r1823353961

@ShridharGoel please give daily updates on this PR until it is merged.

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ShridharGoel Can you please resolve the conflicts

@marcaaron Can you please merge this

Yes, but FWIW - I did not find the answer to this question to be very clear... https://github.com/Expensify/App/pull/46661#discussion_r1834596333

@marcaaron That test was failing randomly on other PRs due to the given timing not being enough. Recently the timeout was increased and this PR no longer modifies it (since it's already enough).


Add ORGQR / UNGQR to Generate Q from Reflectors

It would be desirable to have the utilities to generate the (economical) orthogonal/unitary Q from the reflectors generated by geqrf. Is this on the roadmap?

We haven't planned it. Currently we use unmqr with the identity matrix. ungqr does essentially the same thing but has optimizations where it knows it is multiplying a zero block in the identity.
BTW, SLATE always uses the unmqr name, even in the real case.


Add comparison between SSG

btw Thanks for putting this together!
This will also be helpful for guiding feature development.  What gets highlighted is an interesting insight into what people feel are important.

Thanks for the review!


Version 1.0.0

gittuf has advanced markedly over the past few months, and while not yet ready for 1.0.0, we are approaching the time when it will be.
As discussed in the September community meeting,  there are some items we'd want to land before v1.0.0. Specifically, the following are blockers for the release:

#231
#229
#391
#463
Metadata versioning, i.e. #430

In addition, the following would be (at least in my opinion) nice-to-haves:

https://github.com/gittuf/gittuf/issues/424
A gittuf API (maybe?)
More documentation, such as a manual

(cc @adityasaky @wlynch @neilnaveen; feel free to add more / update)

An API would make gittuf much more usable for devs, maybe for integrating into any type of large scale verfication system?

I took a first stab at exposing an API by moving the repository package out of internal. It's actually used in the initial PR for the github app (https://github.com/gittuf/github-app/pull/1/files#diff-59d92a25c9a864d2527aa8c12116ba798ab65673cf86cd0759b4c1075d01653bR22z). I think it'd be neat to build on this, but we must plan carefully. I wonder if we want to actually move it to experimental or so to be safe.

#618 exposes a gittuf API via github.com/gittuf/gittuf/experimental/gittuf.


Coverage increased (+1.9%) to 57.606% when pulling ec3baeccd61defbaf51c9e18689609ec0f2a4150 on jarrodmillman:Chenyu-Renee_contributing-issue#160 into 9c279b162585d3e7bbd5fa8b65af5135543083d4 on berkeley-stat222:master.

Coverage increased (+1.7%) to 60.421% when pulling f3c637899394bc5396af9aeb31ef1b7c7ac0533e on jarrodmillman:Chenyu-Renee_contributing-issue#160 into cabd408aa3d529d2b2ba853b29bfeb828e2ee8ae on berkeley-stat222:master.


Various tests

Add of some minor tests : gem configuration and version.

Coverage increased (+7.7%) to 53.642% when pulling c56a4a5dda8e3616dc20739f3e171516072921e4 on hezanathos:various_tests into 565e5bc0d88aeef445cdc8bda87e9b66bdebc743 on Cyberwatch:master.

Coverage increased (+7.7%) to 53.642% when pulling c56a4a5dda8e3616dc20739f3e171516072921e4 on hezanathos:various_tests into 565e5bc0d88aeef445cdc8bda87e9b66bdebc743 on Cyberwatch:master.

@fwininger


"nix-shell -p qt5.base" fails on 2nd run

... due to left-over files created the first run:
$ mkdir /tmp/test
$ cd /tmp/test
$ nix-shell -p qt5.base
qmake: File exists
[nix-shell:/tmp/test]$ tree -L 2
.
└── qmake-shell
    ├── bin
    ├── include
    ├── lib
    ├── mkspecs
    ├── nix-support
    └── share

7 directories, 0 files
[nix-shell:/tmp/test]$ exit
$ nix-shell -p qt5.base
cp: cannot create regular file ‘/tmp/test/qmake-shell/bin/qmake’: Permission denied
$

We should use mktemp -d to create the temporary directory instead of giving it a deterministic name.

As reported by @Profpatsch, this continues to be an issue.

Any updates?

I can't reproduce this with a recent master. @Profpatsch ?

@ttuegel I’m baffled, because there doesn’t seem to be a qt5.base anymore. oO

I'm seeing this with qt5.webkit. Should this be reopened?

It's fixed in unstable, but I can't backport the fix to 15.09 based on our policies. Luckily, 16.03 will come out soon.


Bradschm changes

This pull request contains the code that changes the folder structure. The download.py script can pull down existing scripts from the JSS and put them into the new structure.

Still in the process of reviewing this but so far looks good, I should really get some test cases setup to make the review process on me a little easier!


changes for acpf

Codecov Report

Merging #133 (2e8a900) into main (fd4bec7) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #133   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files         26      26
  Lines       7109    7173   +64
=====================================
- Misses      7109    7173   +64

Impacted Files
Coverage Δ

src/CMFs.jl
0.00% <ø> (ø)

src/tucker_outer.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4bec7...2e8a900. Read the comment docs.


Add v2 stress test

Required for all non-trivial PRs

[X] Rebased/mergable
[X] Tests pass
[ ] CHANGELOG.md updated
[X] Sign CLA (if not already signed)

@mjdesa @jsternberg @e-dard @mark-rushakoff Any feedback greatly appreciated!

Loads of stuff going on in here @jackzampolin! Looking pretty good.
It's a big PR, so I've only really had time to give it a scan. I've left some comments here and there, aside from the ConcurrencyLimiter stuff they're pretty minor.
On a more general level I have a couple of points:
As I understand it the tool will be returning mean stdev and a percentile for response times? I think it would be more useful to return the median response time, unless someone can show me that typically responses are Normally distributed when the DB is under load.
Similarly, it looks like the tool has the ability to inject functions into the queries that will generate random tags/values/data etc? That's really cool! However, they all seem to be using Uniform probability distributions to generate this data. I'm sure some things are uniformly distributed, e.g., the backend server handling a request behind a load balancer, but I find it hard to believe that in many use-cases for Influx this will be the case.
Many domains, e.g., financial data, retail analytics, sensor data etc will typically generate data that's non-Normally distributed. Common distributions might include Pareto or Log-Normally distributions.
It would be good if other types of random generation are available, or even if it would be possible to define a function that satisfies some interface, and that can be used by the stress tool.

@e-dard Thanks for the quick review and the pointers! The implementation for data values is in function.go. Currently implemented are:
# str rand functions create m random strings of n length
tag_or_field=[str rand(n) m]

# int inc functions generate monotonically increasing integers starting at 0 and going to m
tag_or_field=[int inc(0) m]

# int rand functions generate m random values between 0 and n
tag_or_field=[int rand(n) m]

# float inc functions generate monotonically increasing integers starting at 0 and going to m
tag_or_field=[float rand(n) m]

# float rand functions generate m random values between 0 and n
tag_or_field=[float rand(n) m]

@e-dard Was thinking about your comment about the different distributions. At the moment generating random numbers in bulk is a performance bottleneck. If you have any advice on that front it would be greatly appreciated!

@e-dard @mark-rushakoff @jsternberg Any more comments or suggestions greatly appreciated. Would be happy to jump on hangout to discuss too. Sorry for the annoying ping! 👼

There's a 6MB file checked in under stress/stress_test_server/stress_test_server. Rebase it out of the changeset, and be more careful about what files you're committing.

This PR is huge. I skimmed through it and pointed out some small details, but I wouldn't say I was able to offer any meaningful feedback on the overall approach. Maybe some kind of architecture overview  would make that a lot easier. That probably belongs in a README.

@mark-rushakoff added a DESIGN.md file.

@jsternberg @e-dard Can we merge this or would you like me to make some more changes?

:clap:


When are you releasing a new version v6.0 ?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
When are you releasing a new version v6.0 ?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Why do you want us to release 6.0? It is a very new version, just open to contributors or feature discussion.

or: When are you releasing a new version v5.0, not bate or snapshot ?

Rc will release in this week or next. Beta2 is stable enough for me.


Refining "contributing.md" for Enhanced User Experience #180

This PR is focused on enhancing the contributing.md file to provide a more comprehensive and user-friendly guide for new contributors. These modifications stem from the detailed discussions and insightful suggestions identified in issue #180.
The key improvements encapsulated within this PR include:

Elaborated instructions on configuring the project locally.
Definitive guidelines on issue creation, which includes a stipulation for a descriptive title, an extensive problem or feature request description, and accurate label assignment.
Detailed directives for creating a Pull Request, emphasizing the necessity for unique branches for each PR and clear synchronization procedures with the main branch.
An overview of the Conventional Commits standard and its significance in maintaining a consistent commit history, supplemented with a link for further understanding.

With these improvements, we aim to streamline our contribution workflow and foster a welcoming and productive environment for our open-source community contributors.
Resolves: #180

I apologize. this was the wrong repository!


Build succeeds despite transformations failed

It looks like the build is succeeding even if Solid Start specific transformations using esbuild fails. I would expect it to exit with non-0 code so it would properly fail e.g. GitHub actions.
Reproduction: https://stackblitz.com/edit/vitejs-vite-mktcwb?file=package.json
Steps:

Go to reproduction
Run npm run build
Build succeeds despite errors and broken output

Note: I know what's the solution to the fail in reproduction (usage of unsupported by Solid Start's esbuild version TypeScript syntax) 😛

I see what you are saying. I just tried adding an ESBuild plugin that just throws, and it was the same. So it seems like Vite doesn't care if ESBuild fails. I don't know how important this is to fix, but it doesn't appear to be within our control. Could be worth taking up with Vite.


MAINT: Bump verison

Someone needs to approve this PR so we can merge and move forward with release
Will try force-pushing an updated 0.2.0 tag after this is merged. Then hopefully pypi will update...

No need to force push the tag, a simple tag from master will work:
git checkout master
git pull
git tag 0.2.0
git push --tags


Removed aarmy example from descr and changed the test for it to passing

Ref #845

Thank you fixing this!


Slightly better paradigm display

refactors the paradigm generation template to its own file
now all of the subtables are vertically aligned
adds a scrollbar to paradigms that are too wide for the screen (resolves #470)
renames the word detail template from "paradigm.html" to "word-detail.html"

Codecov Report

Merging #471 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   86.63%   86.67%   +0.03%
==========================================
  Files          68       68
  Lines        2701     2701
==========================================
+ Hits         2340     2341       +1
+ Misses        361      360       -1

Impacted Files
Coverage Δ

CreeDictionary/API/models.py
88.36% <0.00%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27a418...4b580f2. Read the comment docs.


Incorrect validity of Temporary RDS CALs

Temporary RDS CALs validity is incorrectly mentioned as 52–89 days.
Temporary RDS CALs are valid for upto 90 days, whereas permanent RDS CALs (once upgraded from permanent CALs) are valid for a random period between 52-89 days.
Ref.:
https://social.technet.microsoft.com/wiki/contents/articles/21180.remote-desktop-licensing-demystified.aspx
https://techcommunity.microsoft.com/t5/ask-the-performance-team/multiple-per-device-rds-cals-are-issued-the-same-device-issue/ba-p/375639

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd015c0b-3360-88fd-86b1-08e8c0e8ec5e
Version Independent ID: 0c3ddb09-23f3-68a3-e7a4-877951feb55b
Content: License your RDS deployment with client access licenses (CALs)
Content Source: WindowsServerDocs/remote/remote-desktop-services/rds-client-access-license.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

Hello @tusharchandwani,
Thank you for contacting Microsoft. We appreciate your feedback.
Documentation changes have been made to correct this issue and provide more information. The changes will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


Use enums to distinguish regular and auditor directory constructions

Per suggestion from @slawlor in #301 , this PR replaces the use of booleans with enums to distinguish between regular and auditor directory constructions/hashing. This is clearer and less error-prone.
Note that there were actually two spots where the parameter of include_ep was passed to a function expecting exclude_ep without negating the variable (see in-line comment). I believe these were just function naming errors and not actual bugs. This PR will help avoid such mistakes in future.

Looks great to me, but I want @kevinlewi to check the logic to be sure. I'll let him approve

LGTM!

This looks great, thanks so much!


EnableOutlookEvents

No documentation for what "EnableOutlookEvents" does?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23add0a6-bb9c-15d2-a6eb-351ae0564522
Version Independent ID: 8056b3ee-4fab-3a5c-935b-a9d0e9ad82a4
Content: Set-OrganizationConfig (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-OrganizationConfig.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

Thank you @chrisda . The reason I'm asking about this is the newly introduced ability to shorten events/meetings in Outlook/Exchange Online. The official blog post about this on https://techcommunity.microsoft.com/t5/outlook-blog/new-settings-in-outlook-give-everyone-a-break-between-meetings/ba-p/2276514 specifies the commands needed to enable it and also the cmdlet to check it, "Get-OrganizationConfig | fl event". But when I execute that I get the extra "EnableOutlookEvents" toggle which isn't in his screenshot or documentet anywhere as far as I can see. And since the feature isn't working for us even 4 days after I enabled it I'm thinking it may have something to do with that toggle?

@stoff75, if the feature isn't working for you, I would highly recommend opening a support case. Report back here if there are any updates required in the parameter descriptions for Set-OrganizationConfig.

Hi there, the parameter -EnableOutlookEvents exists in Set-OrganizationConfig

@stoff75, @SRE93, confirmed. I added the parameter to the topic and described it.
Thanks for the feedback.


app.use is not a function

Hello there, i'm trying to use express-ws together with already existed express application, but running into some issues.
Basic info:
Node.js - v6.9.1
Express - 4.15.0
Express-ws - 3.0.0
Using express with Gulp throw nodemon:
gulp.task('express:dev', function(cb) {
        var started = false;
        return nodemon({
            script: 'server/app.js',
            watch: ['server/app.js']
        }).on('start', function() {
            // to avoid nodemon being started multiple times
            // thanks @matthisk
            if (!started) {
                cb();
                started = true;
            }
        }).on('restart', function(ev) {
                    gulpUtil.log('[nodemon] restarted');
                    gulpUtil.log('files changed:\n' + ev);
                    setTimeout(function() {
                        browserSync.notify('reloading now ...');
                        browserSync.reload({stream: false});
                    }, 1000);
                })
                .on('crash', function() {
                    gulpUtil.log('[nodemon] crashed: script crashed for some reason');
                })
                .on('exit', function() {
                    gulpUtil.log('[nodemon] exited cleanly');
                });
    });

app.js:
var NODE_PORT = 3000;
var express = require('express');
var expressWs = require('express-ws');
var logger = require('./config/logger');
// Setup server
var app = express();
app.server = require('http').createServer(app);
var expressWsObj = expressWs(express, app.server);

require('./config/express')(app);
require('./routes')(app);

app.ws('/', function(ws, req) {
  ws.on('message', function(msg) {
    console.log(msg);
  });
  console.log('socket', req.testing);
});

// Start express server
app.server.listen(NODE_PORT, 'localhost', function() {
    'use strict';
    logger.verbose('Express server serves the fake backend and listens on port', NODE_PORT);
});

// Expose app
module.exports = app;

Ends up with next error:
error: uncaughtException: app.use is not a function date=Thu Mar 02 2017 09:33:57 GMT+0100 (Romance Standard Time), pid=10052, uid=null, gid=null, cwd=src\main\webapp, execPath=C:\Program Files\nodejs\node.exe, version=v6.9.1, argv=[C:\Program Files\nodejs\node.exe, src\main\webapp\server\app.js], rss=33292288, heapTotal=21008384, heapUsed=13176632, loadavg=[0, 0, 0], uptime=1793.9372317, trace=[column=9, file=src\main\webapp\server\config\express.js, function=module.exports, line=12, method=exports, native=false, column=28, file=src\main\webapp\server\app.js, function=, line=20, method=null, native=false, column=32, file=module.js, function=Module._compile, line=570, method=_compile, native=false, column=10, file=module.js, function=Object.Module._extensions..js, line=579, method=Module._extensions..js, native=false, column=32, file=module.js, function=Module.load, line=487, method=load, native=false, column=12, file=module.js, function=tryModuleLoad, line=446, method=null, native=false, column=3, file=module.js, function=Function.Module._load, line=438, method=Module._load, native=false, column=10, file=module.js, function=Module.runMain, line=604, method=runMain, native=false, column=7, file=bootstrap_node.js, function=run, line=394, method=null, native=false, column=9, file=bootstrap_node.js, function=startup, line=149, method=null, native=false], stack=[TypeError: app.use is not a function,     at module.exports (src\main\webapp\server\config\express.js:12:9),     at Object. (src\main\webapp\server\app.js:20:28),     at Module._compile (module.js:570:32),     at Object.Module._extensions..js (module.js:579:10),     at Module.load (module.js:487:32),     at tryModuleLoad (module.js:446:12),     at Function.Module._load (module.js:438:3),     at Module.runMain (module.js:604:10),     at run (bootstrap_node.js:394:7),     at startup (bootstrap_node.js:149:9)]
Any idea why express use function are not visible anymore ?

The error seems to be occurring on line 12 in ./config/express. Could you include that file as well? Nothing seems immediately wrong in the code you've pasted, so I'd expect the issue to be there (since express-ws doesn't do anything with app.use).

./config/express/:
var bodyParser = require('body-parser'),
    morgan = require('morgan'),
    logger = require('./logger');

module.exports = function (app) {

    'use strict';

    // Uncomment if you want to have log of all the requests.
    // app.use(morgan('combined', {"stream": logger.stream}));

    app.use(bodyParser.json());
    app.use(bodyParser.urlencoded({
        extended: true
    }));
};

I'm unable to reproduce your issue locally. I did find an issue, however:
var expressWsObj = expressWs(express, app.server);

This should instead be:
var expressWsObj = expressWs(app, app.server);

... because express-ws expects an instance of an Express app, not the Express library itself.
If the issue persists after fixing that, can you do the following?

Create a repository containing a simplified, self-contained runnable testcase (without external dependencies like databases, and including a package.json with the right dependencies)
Verify that the issue still occurs there
Link the repository in this thread so that I can try to reproduce it locally

i had tried what you had proposed, but with no luck. I sorry to give up that shortly, but i had used WS package directly so don't have an interest to investigate further.
Closing issue.

var expressWsObj = expressWs(app, app.server);


[Blockchain module] Link does not exist

@Overkillus there is a dead link in the Blockchain module:
FILE: ./syllabus/3-Blockchain/5-Econ_and_Game_Theory_in_Blockchain_slides.md
[✖] https://citeseerx.ist.psu.edu/document?repid=rep1&type=pdf&doi=7bf78054192d98e999edcdf08971a5eed42518d2 → Status: 500
Can you please make sure that it is either removed or fixed?

I think citeseerx will come back soon. It is a very popular academic repository.
If it doesn't, I believe this is the same paper https://typeset.io/pdf/mining-pool-game-model-and-nash-equilibrium-analysis-for-pow-2lckzso542.pdf but @Overkillus can confirm.

Thank you @JoshOrndorff . I understand that these sites can be off for a little amount of time.
I use this Issue more for tracking and confirmations (as you did).
Maybe f the link interested (e.g. a PDF) could be downloaded and added in a directory inside the content instead of linking an external source that may seize to exist after X amount of time?

I've swapped out the links.

downloaded and added in a directory inside the content instead of linking

If we decide to do something like this we should discuss what content is important enough to come in to our own repo. Not just start with this random one. For now I'm happy to stay the course.


refactor: Differentiate pubspec and resolution errors for plugins

Part of #137040 and #80374

Differentiate pubspec and resolution errors
Rename platform to platformKey
Add TODO for rework logic of flag [throwOnPluginPubspecError]
Swap for loop: handle by platform and then by plugin

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The flag throwOnPluginPubspecError never actually was enabled during production, but only in some tests. And in the tests the flag was not something was tested.
Should we enable this flag during dart plugin registrant generation? If so, is there a reason to keep the flag, as it is always enabled then (?)

Cc @stuartmorgan regarding the TODO on throwOnPluginPubspecError

@christopherfujino would you be interested in continuing the review. I appreciate it :)

I'm quite confused, how the changes can result in flaky tests (?) Does anyone know this type of errors (flaky error 1, flaky error 2)?

I'm quite confused, how the changes can result in flaky tests (?) Does anyone know these type of errors (flaky error 1, flaky error 2)?

Those look like issues with the pub server being down, and unrelated to your PR

@christopherfujino is the test sufficient?
@stuartmorgan is the explanation for throwOnPluginPubspecError sufficient.
I know you have a lot on the plate. Therefore I tried to make the changes/refactors small to be able to review them faster. But this may is a false expectation. Do you have any advice to push the goal of faster development? Thanks in advance and sorry for tagging you.

Therefore I tried to make the changes/refactors small to be able to review them faster. But this may is a false expectation.

It is reasonable to expect that smaller PRs will generally be reviewed faster than larger and more complex PRs. "Faster" won't mean "right away", however.

Do you have any advice to push the goal of faster development?

It wouldn't hurt to be explicit about review requests. When you initially tagged me it was as a "CC", and I don't read "CC" as "please review", nor does it cause the PR to show up in my GitHub review queue. Similarly, if you are ready for a re-review you can use the GitHub UI to re-request review. Many people post comments even when they haven't finished addressing feedback, so you should not assume that just because you post a response to something it will trigger a new review.

Thank you for the explanation. I'll pay attention to this in my future PRs and comments.


RFC: new export feature in driftctl

Created
2021/8/23

Current Version
0.0.2

Target Version
1.0.0

Status
In-Review

Owner
@sjourdan

Contributors

Summary

As a driftctl CLI user
I want to export my driftctl result
So that I can use it somewhere else

The idea with a dedicated driftctl export command is to work independently from the scan command (and its middlewares) as well as the related, experimental --deep mode.
Abandoned Ideas
An undocumented proof-of-concept of the feature currently exists using driftctl scan (driftctl <= 0.15):
$ driftctl scan --output plan://tfplan.json
Scanned states (1)
Scan duration: 19s

This PoC works but we're not satisfied enough to support this long-term: it goes through all processing middlewares targeted at drift detection and requires a working deep mode.
Export Formats
Here are two examples of export formats that could be used with this feature.
Export Format: Terraform Plan (JSON)
As a driftctl CLI user
I want to export my result to the Terraform JSON plan format
So that I can send it to another product for analysis
Proposal

Problem: default driftctl mode doesn't include resource details (experimental --deep mode does)
Hypothesis: there's no need for any processing middleware there
Proposal: simply populate resource content from the available Terraform provider version
Reference: https://www.terraform.io/docs/internals/json-format.html

$ driftctl export --to tfplan://plan.json
[...]
{
planned_values { }
resource_changes [ ]
}

Format Structure
More detailed specs will follow, but the bottom line for the 2 main sections is:

planned_values { }  should contain all the expected resources we know about (like a regular plan would generate), so existing, expected resources, can be analyzed, if needed. It should also include (abusively!) the discovered unmanaged resources (while yes, those resources won't be detectable there by anyone)
resource_changes [ ] should contain the unmanaged resources, to be analyzed by the destination tool (with the create action, while others keep the "no-op" action)

Export Format: Anonymized Output (Console)

Context: To support users, we often ask for debug logs (LOG_LEVEL=debug driftctl scan [...])
Problem: While debug output doesn't explicitly require any personally identifiable information, users may have resource names that can identify them, their employer, their customers.
Reference: https://github.com/cloudskiff/driftctl/issues/1006
Impacted Users: "impermanence" on #support discord 2021/9/1

Example output:
$ driftctl export --anonymize console://
Found missing resources:
  aws_s3_bucket:
    - 44E7A9345E64EDB2680D12FCC85EB22B5C4A04FD73D4743718AAAF2E71649F5F
Found resources not covered by IaC:
  aws_s3_bucket:
    - 3D12E914A8DCC696A13881C4DB9A13A0296A421AFC80264B83093B6A9B506071
Found changed resources:
  - BE6464EBE29D35168133C06DB3E7CDAA791EE10845EBD660C6C507B6894CF644 (aws_s3_bucket):
    ~ Versioning.0.Enabled: false => true
Found 3 resource(s)
 - 33% coverage
 - 1 covered by IaC
 - 1 not covered by IaC
 - 1 missing on cloud provider
 - 1/1 changed outside of IaC

Option 1: anonymize only resources names
In the following case, we would hash "customername1".
resource "aws_instance" "customername1" {
  ami           = "ami-a1b2c3d4"
  instance_type = "t2.micro"
}

That would share this:
resource "aws_instance" "9DFA96B41AC5775A790F267222369BFBACF4271DE245EB34BCC71C6AB5856BD1" {
  ami           = "ami-a1b2c3d4"
  instance_type = "t2.micro"
}

Option 2: anonymize everything
Goal: so there's no wonder what can leak.
Such a resource with identifiable strings will be fully anonymized with such a system:
resource "aws_route53_record" "customername2" {
  zone_id = aws_route53_zone.primary.zone_id
  name    = "www.example.com"
  type    = "A"
  ttl     = "300"
  records = [aws_eip.lb.public_ip]
}

So an output using those would end up shared like this:
resource "aws_route53_record" "414A900AFF49FB55587BEF31E16646413AB7B9951DE9124100A08303ACD973A1" {
  zone_id = 09B0FC1DC6948813379EBEDECC16C99AD4D4C7FDF8A55E5268E0A607A9499369
  name    = 6EF1E4DB8AFCF82F85F694E5D7BE53961969092E751E52A081719EAD18438E0B
  type    =<PHONE_NUMBER>97DF7A8DAA32B1132F07850A68B5E71BD295650399A38074F52804
  ttl     = B9A9F15714A2A7AF00637C2030926CE17919DF2D9DC3B3531D582E7BBAD7315C
  records = [6C8A8BD8FC176A6D988204418DDE0289C74D5BBC812DFDC0E0900ABBF038B303]
}

It's unclear to me what does the export command would perform under the hoods. Does it need to perform an actual scan ?

default driftctl mode doesn't include resource details (experimental --deep mode does)

We could make deep mode being a requirement to use the export feature.

there's no need for any processing middleware there

It's still possible to create the export before running any middleware.

It's unclear to me what does the export command would perform under the hoods. Does it need to perform an actual scan ?

Yes, driftctl export should scan the resources like the real scan, but also add resources content from the tf provider without any processing (we don't care about it there). Like a "raw" deep mode by default if you prefer.

We could make deep mode being a requirement to use the export feature.

True, driftctl export can't work without either the real deep mode or an equivalent!

It's still possible to create the export before running any middleware.

interesting, do you mean a prototype version of the driftctl export command can be done to reuse the current tfplan PoC and make it less complicated to maintain in the long run?

interesting, do you mean a prototype version of the driftctl export command can be done to reuse the current tfplan PoC and make it less complicated to maintain in the long run?

I think having to create a new command to make another kind of scan will be hard to maintain. So may be we could embed the export feature in a simple --export flag for the existing scan command ? In this way, we don't rewrite the scan command and still be able to avoid useless processing. Unlike the abandoned PoC was suggesting, the export format shouldn't be considered as a scan output.
Another option: we don't perform a scan in the export command but take result of a scan as argument, does that make sense to you ?

The scan in its root feature (read state + scan remote + first part of the analysis) is indeed what we need to do here.
BUT what we meant by "processing" is all the attributes that we decided voluntarily to remove for the sake of driftctl (e.g. look at initAwsCloudfrontDistributionMetaData) and all the middlewares that could potentially remove other essential attributes.
I don't think we could do that in just one command, thus creating another command for it.

all the attributes that we decided voluntarily to remove for the sake of driftctl

@wbeuil You're right I didn't think about metadata we remove. I better understand the choice of abandoning the previous PoC.

Wow, it's quite a big one RFC for sure.
First thing, resource anonymization is another topic, and for me, it should remain in a dedicated RFC.
While reading I don't get what we really want here. We talk everywhere about "result"

I want to export my result to the Terraform JSON plan format

Maybe the first thing can be to explain what we want exactly to export ?

there's no need for any processing middleware there

Why ? One more time, what do we expect as a result ? If this is actual scan result, it does not make sense not to run middleware on a scan result. Middleware are here to ensure consistency between IaC and real life resources, if you simply not run them you'll end with an inconsistent output 🤔

Yes, driftctl export should scan the resources like the real scan, but also add resources content from the tf provider without any processing (we don't care about it there). Like a "raw" deep mode by default if you prefer.

but also add resources content from the tf provider I don't get it, what is a tf provider for you ?
TL;DR
I'm stopping the review here since I don't get what we really want here.
I think we should start from a clear explanation of what we want, with real life usecase.

So that I can use it somewhere else

"somewhere else" sounds very unclear. This should be clarified.
Implementation details will came after a deep reflection about what we want, and then we'll talk about UX/UI and implementation details.

I have to agree with Elie on the export part.
I'll have to add that I'm not sure the anonymization part is the same thing as the export part. For debug purpose we need a full scan run and most of the think we want to anonymize are in the logs. I'm pretty sure these are modification of scan and not a new command.


Resolve CloudFoundry App Metadata

Changes

Remove envelope, replace with serializer
Integrate caching.Client with the serializer

Story: #131192729
Validation

Unit tested serializer with a stubbed caching.Client
Manual validation, ensured we're actually outputting data for an existing app

Example log
{
 metadata: {
  projectId: "google.com:jrjohnsondev"
  serviceName: "custom.googleapis.com"
  labels: {
   cloudFoundry/deployment: "cf"
   cloudFoundry/ip: "<IP_ADDRESS>"
   cloudFoundry/eventType: "LogMessage"
   cloudFoundry/orgGuid: "10b2f455-cee5-4b91-925b-f64a5dee2fac"
   cloudFoundry/spaceGuid: "456d6416-8cac-431a-9aa5-b73c956bc78f"
   cloudFoundry/applicationId: "cd59a75c-a423-4251-a335-b999d3a31d5a"
   cloudFoundry/spaceName: "testing"
   custom.googleapis.com/primary_key: "primary_key"
   custom.googleapis.com/secondary_key: "secondary_key"
   cloudFoundry/orgName: "system"
   cloudFoundry/index: "0"
   cloudFoundry/appName: "cf-ex-php-info"
   cloudFoundry/job: "diego-cell"
   cloudFoundry/origin: "rep"
  }
  timestamp: "2016-10-05T21:01:20.739114581Z"
  projectNumber: "707718982209"
 }
 insertId: "fto83fg1bo77po"
 log: "cf_logs"
 structPayload: {
  eventType: 5
  logMessage: {
   message: "MjE6MDE6MjAgaHR0cGQgICB8IDc0LjEyNS41OS42IC0gLSBbMDUvT2N0LzIwMTY6MjE6MDE6MjAgKzAwMDBdICJHRVQgLyBIVFRQLzEuMSIgMjAwIDM5OCB2Y2FwX3JlcXVlc3RfaWQ9ODAwMThjMDQtZjg4ZC00MmExLTQyNTgtMjcxZWUwODg2MzUyIHBlZXJfYWRkcj0xMC4yMDAuMC4y"
   app_id: "cd59a75c-a423-4251-a335-b999d3a31d5a"
   source_type: "APP"
   source_instance: "0"
   message_type: 1
   timestamp:<PHONE_NUMBER>734521600
  }
  ip: "<IP_ADDRESS>"
  index: "0"
  origin: "rep"
  deployment: "cf"
  timestamp:<PHONE_NUMBER>734524400
  job: "diego-cell"
 }
}

@cholick ready for review


mix helper in vue SFC

Hi all, i know that probably is not an issue but i have a question (i'am new on laravel and mix):
can i use mix helper (or something else) in a SFC vue component for retrive image versioning?
in my webpack.mix.js i have ...version(['public/images']),  so in my mix-manifest.json i have this entry:
"/images/logo.png": "/images/logo.png?id=9b06f171b05c299ac971"
but how to use in my SFC component with vue router?

TOP ! thanks it works!


Multi function calls

https://community.openai.com/t/emulated-multi-function-calls-within-one-request/269582/15
has a lot of interesting information

https://platform.openai.com/docs/guides/function-calling#tool-calling-behavior


[Promotion / Discussion] Dockerfile for cottontaildb

Since cottontaildb is very much de facto under the vitrivr umbrella, I pushed a (work in progress) Dockerfile to vitrivr-docker
Any feedback is welcome (hence this thread)

Since docker containers are designed to be immutable, storing dynamic data inside them is not recommended. Such data should be stored outside of the container itself, preferably (from dockers point of view) inside a volume (see https://docs.docker.com/storage/volumes/). Postgres for example briefly explains how to do this with their official image: https://hub.docker.com/_/postgres?tab=description#where-to-store-data
A cottontaildb container should be set up in a similar way.

This has been resolved!
From now on, if you create a version tag (e.g. v1.0) on the master branch, GitHub will automatically generate and publish a docker image for Cottontail DB. For now, it will be published as Package in the repo. However, we can also publish it to the vitrivr DockerHub in the near future.


pyDOE2 non-functional with python 3.12, appears to be unsupported.

Hello SMT team,
We've noticed on the OpenMDAO side that pyDOE2 does not work with python 3.12, and despite a pull request to fix it, it appears that the lead developer is non-responsive.
Supporting the DOE capability of pyDOE2 isn't necessarily in our teams area of expertise or bandwidth at the moment. Can we talk sometime about someone making an "official" fork of the project, or integrating its capabilities?  It seems like SMT sampling methods might be an appropriate fit, but I'm open to ideas.

Hi Rob,
Yes, sampling methods API in SMT is exactly the topic of pyDOE2. In SMT we just provide random, fullfactorial and optimized LHS sampling methods and we depend on pyDOE2 as well. Even if we have a nice API, at the moment the sampling methods are more a utility for testing and showing surrogates capabilities than being the core of the library which is acually the purpose of pyDOE.
So should pyDOE2 not be maintained, we could :
a - Just copy/adapt the relevant part under sampling methods (ie doe_lhs, bbdesign) to just keep current SMT in shape
b - or fork pyDOE2 under SMTOrg and package it as let say pyDOEtoo and just use it,
c - or integrate all pyDOE2 methods under sampling methods, with tests, documentation, etc.
Ignoring the selfish option a), I think we could implement b) and if there is a compelling need maybe gradually implement c) with the help of the community ?

pyDOE3 1.0 is out!

Thank you


fix chain download halt

PR description
In some cases a syncing Besu node stopped downloading the chain data. The reason for that was that sometimes peers that were selected to download headers that are needed to allow the parallel download of the next batch of headers only returned one header instead of 200 headers.
There was a mechanism that restarted the pipeline for the chain download, but if the same peer was selected to do that initial download the same would happen again. In some cases that happened for a long time, making it noticeable, but it turned out that this happens for short periods of time as well (still slowing down the chain download process).
This PR adds a check that disconnects the peer only returning one block to make sure that a different peer is selected for the next restart of the pipeline.
Fixed Issue(s)
#6884

great find.  We recently discovered that the geth snap sync pipeline does something very similar.

closing since this got merged into a different PR (already in)


Is A10 worth splitting by the “and”?

I thought of that too... but then opted against as this is to describe what the controlled environment is. I forgot that this also includes air-flow, but oh well... I I think it all fits in climate and low vibration.
So... I've removed the words temperature+humidity to make it less wordy and more general. However, low vibration is a must in microscopy.


remove dockerCE from openeuler pkgs

What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

the result of ci job:
https://github.com/hangscer8/kubean/actions/runs/4923799606

/lgtm


Update about.astro

👷 Deploy Preview for famous-marshmallow-cfbd61 processing.

Name
Link

🔨 Latest commit
46a2047c8ff9644b436c526cf8a8dafbc3c492e1

🔍 Latest deploy log
https://app.netlify.com/sites/famous-marshmallow-cfbd61/deploys/64b2018f53b1680008e105e7


Empty string returned (Regular Expression has PREG_BACKTRACK_LIMIT_ERROR)

What version of Minify are you using? PHP version?
2.0.1

What steps will reproduce the problem?
1. pcre.backtrack_limit set in the php.ini to the default (100,000 I think).
2. A single line in the HTML needs to be longer than 50773 characters.
3. Minify the HTML.

What is the expected output?
Some HTML.

What do you see instead?
Empty string.

Please provide any additional information below.

The problem is caused by a long line (> 50773 characters) having too many
backtracks in a Regular Expression.

In Minify/HTML.php the problem line is:

$html = preg_replace('/^\\s*(.*?)\\s*$/m','$1', $html);

I think the .* is causing too many bracktracks. To solve this, I changed
this line to:

$html = preg_replace('/^\\s*([^\s]*?)\\s*$/m','$1', $html);

I am not to sure on what this line is trying to achieve, but this solved my
problem.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 28 Jul 2008 at 12:08

Fixed in R160. ecroyd, can you verify this worked? I combined the patterns
suggested
above:

$html = preg_replace('/^\\s+|\\s+$/m', '', $html);

Original comment by<EMAIL_ADDRESS>on 29 Jul 2008 at 4:20

Changed state: Fixed

Thanks for catching this. I'm all for optimizing (or removing) regexs if
possible.
In this case your fix won't have the same functionality (basically a trim of
each
line). Can you try replacing with these lines instead?

$html = preg_replace('/^\\s*/m', '', $html);
$html = preg_replace('/\\s*$/m', '', $html);

Original comment by<EMAIL_ADDRESS>on 28 Jul 2008 at 4:35

Changed state: Accepted

Both your latest solution (comment 2) and your earlier solution (comment 1) fix
my
problem.

Thank you very much for providing such a great tool.

Original comment by<EMAIL_ADDRESS>on 29 Jul 2008 at 8:34

Original comment by<EMAIL_ADDRESS>on 29 Jul 2008 at 11:54

Changed state: Verified


pythonPackages: fix build on darwin

Motivation for this change
The test no longer exists after #112908:
Disabled tests path "pylint/test/test_functional.py" does not exist. Aborting

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Is there a way to make ofborg do Darwin builds as well? It would be nice to have immediate feedback if things break there.

The test no longer exists after #112908:

Actually, it was added then https://github.com/NixOS/nixpkgs/pull/112908/commits/da92fff6d1c79f3d8e9d3077c24f732447af289d#diff-b3997a2cf51e3fb2bf21d5050d3db98472c53ed1b34cf8ce003dba62b484272cR66

Result of nixpkgs-review pr 116814 at 12238b08 run on x86_64-linux 1

12 packages marked as broken and skipped:

bonfire
nagstamon
python38Packages.optuna
python38Packages.pymc3
python38Packages.shap
python38Packages.skorch
python38Packages.sunpy
python38Packages.textacy
python39Packages.optuna
python39Packages.skorch
...

17 packages failed to build (new failures):

cmake-format
python38Packages.aioamqp
python38Packages.pylint-django
python38Packages.pysonos
python38Packages.rabbitpy
spyder (python38Packages.spyder)
python39Packages.aioamqp
python39Packages.pylint-django
python39Packages.pyls-black
python39Packages.pyls-isort
python39Packages.pyls-mypy
python39Packages.pyls-spyder
python39Packages.pysonos
python39Packages.python-language-server
python39Packages.rabbitpy
python39Packages.spyder
python39Packages.spyder_3

502 packages skipped due to time constraints:

aiodnsbrute
ansible-lint (python38Packages.ansible-lint)
apache-airflow
appdaemon
archivy
aws-google-auth
azure-cli
backblaze-b2
backintime (backintime-qt)
backintime-common
...

63 packages built successfully:

buildbot (python38Packages.buildbot)
buildbot-full (python38Packages.buildbot-full)
buildbot-ui (python38Packages.buildbot-ui)
buku
conan
python38Packages.anyio
python38Packages.azure-core
python38Packages.diff_cover
python38Packages.httpcore
python38Packages.httpx
python38Packages.jeepney
python38Packages.keyring
python38Packages.msrest
python38Packages.pamqp
python38Packages.phik
python38Packages.poetry
python38Packages.pyfuse3
python38Packages.pylint
python38Packages.pylint-celery
python38Packages.pylint-flask
python38Packages.pylint-plugin-utils
python38Packages.pyls-black
python38Packages.pyls-isort
python38Packages.pyls-mypy
python38Packages.pyls-spyder
python38Packages.pynput
python38Packages.pytest-pylint
python38Packages.pytest-trio
python38Packages.python-language-server
python38Packages.pytile
python38Packages.respx
python38Packages.rich
python38Packages.secretstorage
python38Packages.setuptools-lint
python38Packages.spyder_3
python38Packages.tqdm
python38Packages.trio
python39Packages.anyio
python39Packages.azure-core
python39Packages.buildbot
python39Packages.buildbot-full
python39Packages.buildbot-ui
python39Packages.diff_cover
python39Packages.httpcore
python39Packages.httpx
python39Packages.jeepney
python39Packages.keyring
python39Packages.msrest
python39Packages.pamqp
python39Packages.pyfuse3
python39Packages.pylint
python39Packages.pylint-celery
python39Packages.pylint-flask
python39Packages.pylint-plugin-utils
python39Packages.pynput
python39Packages.pytest-pylint
python39Packages.pytest-trio
python39Packages.respx
python39Packages.secretstorage
python39Packages.setuptools-lint
python39Packages.trio
thonny
topydo

disabledTestPaths is a [] not a string.

I build this PR on darwin manually and it build fine so we don't need that line after all.


TestStartsWithTheSameCase: special case

Special case where TestStartsWithTheSameCase should not raise any warnings on case mismatch should be (most likely) when one sentence starts with digits:
ProcReadElf64BitNotSupportedYet = Logisim does not yet support 64-bit elf files.

translation:
ProcReadElf64BitNotSupportedYet = 64-bitowe pliki ELF nie są jeszcze obsługiwane.

With current implementation pliki are matched agains Logisim however the translation is correct and in fact pliki should not be capitalized in that sentence.

Fixed in v2.1.0


Type casting bug in STM32HWEncoder fixed

Hello,
Found this bug while trying to get this code to work:
STM32HWEncoder e(1000, PA0, PA1);

This is the related part of my platformio.ini config:
platform = ststm32
board = nucleo_g474re
framework = arduino

In this case, PA0 is 192 and PA1 is 193. Currently, when you pass pins to the STM32HWEncoder constructor, they're trimmed down to the int8_t, which is incorrect. In my case 192 and 193 do not actually fit into the int8_t, and trimming then leads to incorrect operation of the digitalPinToPinName function. So I just changed int8_t to int

Hey, thanks a lot for this contribution! I’ll look more closely tonight when I’m not on my phone but it looks like a good find…


capa-iam-operator requires existence of a secret but doesn't put finalizer on it

When deleting clusters, this happens frequently
E0420 08:03:05.217871       1 awsmachinetemplate_controller.go:134] controllers/AWSMachineTemplate "msg"="Failed to get the irsa-cloudfront secret for cluster" "error"="Secret \"w9im2-irsa-cloudfront\" not found" "awsMachineTemplate"="w9im2-control-plane-105a97a4" "cluster"="w9im2" "namespace"="org-giantswarm" "role"="control-plane"

released with v0.8.0


GPU support for fastT5

You have used onnxruntime which is CPU compatible but are we looking forward to have onnxruntime-gpu?

I'm currently working on GPU support, there are a few issues, one of which is adding support for both onnxruntime (CPU) and onnxruntime-GPU in a single library and GPU also does not support quantization. hopefully, onnxruntime adds support for quantization for GPU soon.

@Ki6an In the meantime, is there any way to improve the inference times of a T5 on GPU?

@gennarovaccaro follow this thread https://github.com/Ki6an/fastT5/issues/34 it'll give you a basic idea


Native elements off-screen but on-page are not found

Environment

java client build version or git revision if you use some shapshot: 3.4.1
Appium server version or git revision if you use some shapshot: 1.5.2
Desktop OS/version used to run Appium if necessary: OSX El Capitan
Node.js version (unless using Appium.app|exe) or Appium CLI or Appium.app|exe: 6.1.0
Mobile platform/version under test: Android 6.0
Real device or emulator/simulator: Real

Code To Reproduce Issue [ Good To Have ]

Open a Appium session on an Android device
Open an app that has a really long layout
Try to locate an element by ID on the page that's off-screen.
Fails

I opened inspector and saw that the UI hierarchy didn't include the elements that were off screen.
I scrolled down and saw the elements that are now above the screen can't be found by Appium.
Link to Appium logs
https://gist.github.com/midopa/3dbe49785caee71bd7b10f22b2f7bf81

I believe this is by design in UiAutomator and doesn't have to do with Appium.
See if this helps:
findElementByAndroidUIAutomator("new UiScrollable(new UiSelector()).scrollIntoView(new UiSelector().resourceIdMatches(\".*some_element_id\"));")

Yes. This is how Android works. The above ought to work. Thanks for the suggestion, @ssynix !

Issue moved to appium/appium #7403 via ZenHub


[BUG] wrong buffer length can retrieve

Describe the bug

There are cases that length that got with readBinary (and readString also probably) will be overwritten by other readBinary or by reading the length.
It supposed to be overwritten with same length but attacker can send send whatever he want over the transport layer
To Reproduce

Run erpcgen on
example.erpc.txt
You will see:

at my_example_two_buffers_shim

        codec->readBinary(&lengthTemp_0, &dataTemp_0);
        len = lengthTemp_0;
        ...
        codec->readBinary(&lengthTemp_1, &dataTemp_1);
        len = lengthTemp_1;

at my_example_len_after_buffer_shim

        codec->readBinary(&lengthTemp_0, &dataTemp_0);
        len = lengthTemp_0;
        ...
        codec->read(&len);

Expected behavior

As mentioned in #327 , fixing for reading the length just once is break change and not acceptable. So I think the length should be compared instead of overwrite and in case it is not same to fail.
I don't know how to make this fix currently.
Screenshots

Desktop (please complete the following information):

OS: Linux
eRPC Version: 1.9.1

Steps you didn't forgot to do

[X] I checked if there is no related issue opened/closed. (#327 is related, but is different)
[X] I checked that there doesn't exist opened PR which is solving this issue.

Additional context

Sounds good. But as mentioned i would like to get rid of one len size reading, which is breaking change, but i think we can do it and properly mark version.

I think that for such little enhancement we shouldn't start breaking things. We can keep it in some backlog till there will be anyway breaking.
I suggest fixing current issue without breaking and to wait with #327