Namespace for sealed class generated twice

Let's look on code
@Serializable
sealed class S {
    @Serializable
    class A : S()
    @Serializable
    class B: S()
}

@Serializable
class C(
    val s: S,
    val snull: S?
)

fun main() {
    val tsGenerator = KxsTsGenerator()
    println(tsGenerator.generate(serializer<C>()))
}

It generates the following type of script file, which is not valid.
export interface C {
  s: S;
  snull: S | null;
}

export type S =
  | S.A
  | S.B;

export namespace S {
  export enum Type {
    A = "S.A",
    B = "S.B",
  }

  export interface A {
    type: S.Type.A;
  }

  export interface B {
    type: S.Type.B;
  }
}

export namespace S {
  export enum Type {
    A = "S.A",
    B = "S.B",
  }

  export interface A {
    type: S.Type.A;
  }

  export interface B {
    type: S.Type.B;
  }
}

As I understood from debugger, there is some problems with handling nullable types, as there is something called S.A and something called S?.A, and deduplication doesn't work because of that.

Definitely a bug! Thanks for finding and reporting it. I expect it won't be too difficult to fix, but I haven't touched this project in a while so I'll need to do some housekeeping first.


cookbook - shareboost

@karlnapf I am not 100% sure it's a bug - because it makes sense to have nonzero features number < total feature number - but for this dataset, I have two use all (both) features to get correct output (classification).
With the orig codes, if I do ShareBoost shareboost(features_train, labels_train, 1), I'll get binary classification; with ShareBoost shareboost(features_train, labels_train, 2), I'll get error: It doesn't make sense to use ShareBoost with num non-zero features > num features in the data\n

I can send in a mini patch separately if necessary

I think your forgot the .rst :)

Also needs integration test data

@karlnapf updated

Minor comments, pls send a separate fix. Merging. Thanks!


make install pep517-518 compliant

@valizadehm you can have a look if you want

I have approached in the same way to replace setup.py and setup.cfg by pyproject.toml


fix: inherit sidecar security context to ensure termination is capable with pod security context.

https://github.com/StatCan/kubernetes-sidecar-terminator/blob/6d1e1e889f3a59a3ab57ba781227a74b1eb16cdc/pkg/sidecarterminator/terminator.go#L25-L34
Just a nitpick here 😸  , can we add some comments to document the purpose for each field in this struct. Most of them are pretty easily understood, but a little more clarity never hurts 😄

https://github.com/StatCan/kubernetes-sidecar-terminator/blob/6d1e1e889f3a59a3ab57ba781227a74b1eb16cdc/pkg/sidecarterminator/terminator.go#L38-L49
I like this!

https://github.com/StatCan/kubernetes-sidecar-terminator/blob/6d1e1e889f3a59a3ab57ba781227a74b1eb16cdc/pkg/sidecarterminator/terminator.go#L38-L49
I like this! Very useful for debugging!

Agreed!

Looks like I don't have write access so my approval doesn't do much here lol

Looks like I don't have write access so my approval doesn't do much here lol

Ooops, let me fix that. Some of these are old and don't have the proper RBAC.

I've added comments to the fields of the struct while also removing unused ones.
I've also taken the time to move around some functions to make reading easier by aligning with flow structure.
I've also removed some of the indirection with the eventhandler by removing some instantiation code and only referring to it in the function in which it is being passed to the informer.


Use curly braces for constructors

For consistency

Jenkins, test this please.

Jenkins CI test (for commit 41e76cb8ad2b04f7e2991dd3dae0efd31787cc69, target branch master) succeeded!


Fix Peru landline number validation

Peru landline numbers consist of 8 digits after the country prefix:

1 + 7 additional digits for Lima
2 digit area code and 6 additional digits for the rest of the areas

According to the following two references:

https://en.wikipedia.org/wiki/Telephone_numbers_in_Peru
https://www.numberingplans.com/?page=plans&sub=phonenr&alpha_2_input=PE

Lima landlines do not follow the same formats as mobile numbers. Lima landlines start with a 1 followed by 7 digits, while mobile numbers start with a 9 followed by 8 more digits. Hence they should be handled by different rules.

Coverage increased (+1.3%) to 99.732% when pulling f8de17f27f0a34174635e58da94c25990137531b on SofiaMargariti:Peru_landline_validation into a1f113f5f1d8cf9d65cf9e1c4e8703da0db11eb4 on floere:master.

cc @floere

This PR is released in 2.16.5 🚀 Many thanks, again, for your improvements! 👏


[MacOS]  unsealed contents present in the bundle root Command CodeSign failed with a nonzero exit code

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I created a new flutter project from the CLI with support for iOS, macOS, Android and web, I also installed flutterfire to configure firebase. I installed these Packages:
firebase_core: ^2.4.1
firebase_crashlytics: ^3.0.11
firebase_dynamic_links: ^5.0.15
cloud_firestore: ^4.4.4

I have created a Dev and Prod Flavor. For each flavor, I created an own runner config. Inside the iOS and macOS Folder, I created a config folder with a dev and prod subfolder with the GoogleService-Info.plist and the .JSON file in it. The config Folder gets created in the Finder and then drag'n dropped into Xcode, the same with the .JSON and GoogleService-Info.plist file(s).
iOS runs and build perfectly fine on Simulator as well as the physical Device, with each Flavor also accessing each Firebase Project.
macOS on the other Hand only builds when I change the name of the GoogleService-Info.plist file, but then I can't use Firebase. If I leave the "normal Name" it throws this error: unsealed contents present in the bundle root Command CodeSign failed with a nonzero exit code.
Actual results
iOS Build fine
macOS only builds when GoogleService-info.plist is changed to a different name, but then FIrebase can't be used.
Logs

Logs

unsealed contents present in the bundle root Command CodeSign failed with a nonzero exit code

Flutter Doctor output
Please Ignore the Android Warning. I use Android Studio Preview Giraffe that shows this warning, but when i run flutter doctor --android-licenses I get no error.

Doctor output

[✓] Flutter (Channel master, 3.9.0-9.0.pre.8, on macOS 13.2.1 22D68 darwin-arm64, locale de-DE)
    • Flutter version 3.9.0-9.0.pre.8 on channel master at /opt/homebrew/Caskroom/flutter/3.7.0/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 09cc1c4cda (32 hours ago), 2023-03-16 09:18:57 +0100
    • Engine revision 3194afad72
    • Dart version 3.0.0 (build 3.0.0-322.0.dev)
    • DevTools version 2.22.2

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/blackbox/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.76.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • iPhone 14 Pro Max (mobile) • CENSORED• ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 111.0.5563.64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Might my Issue be related to https://github.com/flutter/flutter/issues/64088

Thanks for the report @TheGlorySaint
In order to narrow down the issue / behavior to framework itself, can you confirm if the same error occurs without using firebase plugins ?
If so, a github repo of the demo would be helpful to have so that we can clone it and verify at our end.

@darshankawar The same error occurs when using without firebase plugins. I'd invite you to the demo project due to the fact, that for Firebase the API Key etc. is exposed and i don't want that anybody else does have access to it.

Thanks for the update @TheGlorySaint

macOS on the other Hand only builds when I change the name of the GoogleService-Info.plist file, but then I can't use Firebase. If I leave the "normal Name" it throws this error: unsealed contents present in the bundle root Command CodeSign failed with a nonzero exit code.

Coming back to this statement. Are you trying to add or change name of this file through VSCode ? If so, can you try to add this file via XCode itself ?
Also, I cloned the repo you shared with me, but I don't see mac folder in it.

@darshankawar The config Folder gets created in the Finder and then drag'n dropped into Xcode, the same with the .JSON and GoogleService-Info.plist file(s). Please use the macosandweb Branch.

Thanks for the update. Since I don't use VSCode, I cloned the said branch and tried to run on macOS, but seem to be getting Exception: No macOS desktop project configured.
Would be good if you could provide exact steps on how to use the project clone and run on macos desktop so that we can make this issue actionable.

@darshankawar There is not much to do. Clone the Project, switch to the Branch I mentioned, and run it with these args.
"--flavor",
        "dev",
        "--dart-define-from-file",
        "dev-config.json"

Thanks for the update. Upon following above I was able to see the originally reported behavior, but looking at the repo you shared and the code implementation, it has lot of third party package and code, but in order to narrow down to the behavior to the framework itself, would it be possible for you to trim down the repo just to have framework related code and not any third party implementation, that way it'll help to analyze the behavior properly.

Thanks for the report @TheGlorySaint In order to narrow down the issue / behavior to framework itself, can you confirm if the same error occurs without using firebase plugins ? If so, a github repo of the demo would be helpful to have so that we can clone it and verify at our end.

@darshankawar as you requested here three days ago, trimmed down to use only the Firebase Plugin, because it is necessary to use the flavor.

I meant I was referring to: https://github.com/TheGlorySaint/timetrec/blob/macOSandWeb/lib/main.dart wherein it has lots of third party packages and implementation.

I have created a Dev and Prod Flavor. For each flavor, I created an own runner config. Inside the iOS and macOS Folder, I created a config folder with a dev and prod subfolder with the GoogleService-Info.plist and the .JSON file in it. The config Folder gets created in the Finder and then drag'n dropped into Xcode, the same with the .JSON and GoogleService-Info.plist file(s). iOS runs and build perfectly fine on Simulator as well as the physical Device, with each Flavor also accessing each Firebase Project.
macOS on the other Hand only builds when I change the name of the GoogleService-Info.plist file, but then I can't use Firebase. If I leave the "normal Name" it throws this error: unsealed contents present in the bundle root Command CodeSign failed with a nonzero exit code.

Ideally what we look for is a barebone repo that in your case would only contain what you described here. Because the team member / engineer who would be looking into this issue would be looking for it. Since you gave me the access for your project, it may not be feasible to do the same for other members as you'll need to give access to them as well.


Question: when can we expect next release?

The back-filling-bootstrap-4 branch is ahead of master by almost 100 commits now. I think it will be better if the templates directory in the branch gets some attention. Or else a dev pre-release will be do the job. I am excited to know how to use the new elements.

@sesemaya same question here. I want to start using this for a project, but I don't want to re-do it when switching to bootstrap 4. Is there any plans for merging into master?

We've been in a bit of a holding pattern in the hope that the Bootstrap project move a little faster.  There's no reason you can't work with the head of the back-filling-bootstrap-4 branch; we have ourselves for several projects.

Closing as backfilling-bootstrap-4 has been merged into master.
We are currently working on backfilling-bootstrap-4.0.0-alpha.6.
As Bootstrap announced that alpha.6 would be the last alpha before the more stable beta version, we will be looking into adding bug fixes and enriching our material ui library rather than backfilling Bootstrap once it reaches its beta stage.


Add "unique key combination"

User marks sample sheet keys as part of the "unique" group in the server settings. These keys must not occur multiple times per lab (or per database).

Tracked in #38


match supported wagtail versions and update test settings

https://github.com/wagtail/wagtail#compatibility

Python 3.4, 3.5, 3.6
Django 1.11, 2.0

@robmoorman - I was looking at using django-bakery in wagtail and found this repo. I had to make a few tweaks to get tests passing, but otherwise this branch was working for me. Is this still in active development?


mc: new package at 4.8.23

Description of package
GNU Midnight Commander is a visual file manager with a feature rich full-screen text mode that allows you to copy, move and delete files and whole directory trees, search for files and run commands in the subshell. Internal viewer and editor are included
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

Is the new source an official mirror of mc or something third-party?

The former http url was i think the "official" one found on their website and also used by gentoo and arch. The new https url is "stolen" from the freebsd port. The checksums are the same (see commit)

If the mc developers don't provide a https mirror I'd much rather we stick to their official source even if it is http. I think this is an issue we should raise upstream, apologies for the run around.  :+1:

No problem.
There is also a https link to github on their site, but this tarball has no configure script. You have the whole automake / autoconf mess and i think one need also autopoint from the gettext package (not packaged yet in kisslinux i think)
Is the pull request now ready to merge for you?

Swap it back to the original http link and I'll merge. :+1:

LGTM :+1:


feat: Allow non flat addressing for withItems/withParams. Fixes #11192

Fixes #11192
Motivation
I wanted to fix the issue.
Modifications

In workflow/controller/operator.go
Created function fillReplaceMap to go through an item's value and
recursively create an index/address for each nested value type. In
effect implementing https://github.com/tidwall/sjson#path-syntax, but
with as little impact to the structure as I could muster.
Flattened a conditional.
In workflow/controller/operator_test.go
Updated processItem test to test more scenarios.

Verification
Added tests, verified functionality locally.

As this change updates the keys that get added to the replaceMap, it also alters the name of the resulting node. The idea was that it was to be deterministic, which my change doesn't change, but it does add potentially significant length to the resulting name.
Where if the input json is:
[
  {
    "json": {
      "list": [
        0,
        "1"
      ],
      "number": 2,
      "string": "foo"
    },
    "list": [
      0,
      "1"
    ],
    "number": 2,
    "string": "foo"
  }
]

The node name would go from:

task-name(0:json:{"list":[0,"1"],"number":2,"string":"foo"},list:[0,"1"],number:2,string:foo)

to

task-name(0:json.list.0:0,json.list.1:1,json.list:[0,"1"],json.number:2,json.string:foo,json:{"list":[0,"1"],"number":2,"string":"foo"},list.0:0,list.1:1,list:[0,"1"],number:2,string:foo)

I'm unsure if this would be considered an interface change.

@awilcots two questions as someone who got just bitten by it (luckily it was us who generated the JSON, but it certainly sunk some time to discover this):

I see the test cases added only test node name, not that the {{ interpolation.syntax.works }} with nested data - since this is supposed to resolve that issue, maybe it would be good to add a test for that? I guess it is a fix, because the interpolation happens against the node name, but maybe there's some place that it can be verified?
I see that the test data does not have a { "nested": { "object": "example" } } only one with a nested list. Looking at the code it quacks as if nested objects should also work, but maybe it would be good to add a test case for this as well?

Thanks for fixing this!

Closing this PR as it's been stale for awhile

@juliev0 can I take this up?

@juliev0 can I take this up?

for sure! do you want to continue on this branch or start a new one? (if you are able to reopen it, feel free to do so)

@juliev0 adding  few more test cases and this should be gtg.


Atom feeds are invalid

Description
Feed www.flatcar-linux.org/releases-feed/releases-stable.xml is not passing validation.
Impact
It is not possible to add feed to Slack, probably due to validation errors.
Environment and steps to reproduce
Open w3c feed validator. Paste URL of the stable feed (see https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.flatcar-linux.org%2Freleases-feed%2Freleases-stable.xml). It will multiply errors.  Also this feed cannot be added to slack (see Add RSS feeds to Slack).
Expected behavior
No errors, passed validation
Additional information
Looks like that other feeds (tested with alpha) having same issue.

Thanks for the bug report.
Last week we fixed the validation errors in the atom feed.
It should work well now.


Resolved undocumented nullable behavior

OpenAPI Schema Objects and JSON Schema have a few fundamental differences, and this clears up a bit of confusion about one of them.
Basically, in JSON Schema, a schema of {} is totally valid, and when type is missing it essentially means "type can be anything", which would allow null.
With OpenAPI Schema Objects, {} should be allowed, but nullable confuses that with its default of false. You'd need to write { nullable: true } at the very least to let a null squeak through.
This seems like its breaking, but I dug around and most tooling will fall over if type is missing.

Seeing as some tooling prevents {} and some tooling supports it, we have a bit of a nasty situation that needs resolving. This change basically says "nullable adds null to the type that exist and missing type essentially means type: string|integer|array|etc... so adding null to that list is fine.

@darrelmiller , this is the PR that we would like to merge for the 3.0.3 patch release.
I believe we have discussed this exhaustively on TSC calls. The new nullable definition language is what we composed in a real-time editing session with @webron, @handrews, and others on a TSC call a few weeks ago. The complete background, motivation, and analysis are documented in the proposal here.
As discussed, please herd the TSC cats to approve and merge.  Thank you!  :-)

@darrelmiller my recollection matches @tedepstein's.
I also put wording as close to exactly matching this as possible given type arrays in #1977, in case anyone is worried about wether/how this would fit with possible OAS 3.1 changes.

I think it is fair to say we have done our due diligence on this particular issue.   Hey @OAI/tsc please review and and sign off so we can get this merged into 3.0.3 so we can clear the path to updating JSON Schema in 3.1.  Ted's proposal provides all the background to this conversation and the reasoning as to why this solution was chosen.

Yaaaaay, @darrelmiller could you click that button?

I was going to say that we a majority TSC vote, but I re-read the governance rules and we only need that for merging the patch branch to master.  Sooooooo.  Time to click the big green button.

Thank you Darrel!!

@philsturgeon No, thank you and all the other community folks who put the effort into solving this tricky problem  /cc @tedepstein @handrews

@philsturgeon, @tedepstein, @handrews - indeed, thank you all for pushing this forward. I love this came to be an elegant solution!


Interactive notebook rendering

CURRENTLY EXPERIMENTAL
These changes utilize new features (https://github.com/pyviz/panel/pull/312) from pyviz/panel to create interactive renderings directly in a Jupyter notebook
Note that these features are only possible after these https://github.com/pyviz/panel/pull/349 changes to panel

Codecov Report

Merging #144 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   89.09%   88.95%   -0.15%
==========================================
  Files          19       19
  Lines        5052     5060       +8
==========================================
  Hits         4501     4501
- Misses        551      559       +8

Impacted Files
Coverage Δ

vtki/plotting.py
80.08% <0%> (-0.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e636d...908d6fb. Read the comment docs.

This is awesome!  Great job!


Reuse logstasher json file for sidekiq

Starts using the same file that gets used to send data to logstash.
Tested in staging with the .log file and works as expected.

Did you mean to add the .env file here?

Nope, I've taken it out.


feat: write the application to join the  Starcoin Learning Org

please fill the discord id and telegram id

Since the PR is not updated for too long, it is temporarily closed. If you want to continue to participate in Startrek, please apply again.


Package web error

When I use yarn build or npm run build to package my project into a web page, it reports an error: [vite:load-fallback] Could not load /Users/lizibin/%E5%B8%B8%E7%94%A8%E6%96%87%E4%BB%B6/code/%E5%89%8D%E7%AB%AFCode/BetterChatGPT-main/src/store/store (imported by src/App.tsx): ENOENT: no such file or directory, open '/Users/lizibin/%E5%B8%B8%E7%94%A8%E6%96%87%E4%BB%B6/code/%E5%89%8D%E7%AB%AFCode/BetterChatGPT-main/src/store/store'
error during build:
Error: Could not load /Users/lizibin/%E5%B8%B8%E7%94%A8%E6%96%87%E4%BB%B6/code/%E5%89%8D%E7%AB%AFCode/BetterChatGPT-main/src/store/store (imported by src/App.tsx): ENOENT: no such file or directory, open '/Users/lizibin/%E5%B8%B8%E7%94%A8%E6%96%87%E4%BB%B6/code/%E5%89%8D%E7%AB%AFCode/BetterChatGPT-main/src/store/store'
What might be the reason?

I confirm that I have not modified any paths to App.tsx and vite.config.ts

Try avoiding using CJK characters?


Moving SCREEN RAM with poke

Hello there,
I'm trying to implement a backbuffer by poking character codes to another location (other than 1024) and then moving the video matrix with this command:
poke 53272, (peek(53272) & 15) | 64      REM  (backbuffer starts at 4096)
if I use lower RAM adresses I get either rubbish characters, or a crash, how can I determine a safe location to use as a backbuffer?
I tried a couple of addresses from this C64 wiki page on screen ram:
https://www.c64-wiki.com/wiki/Screen_RAM
Thanks!
PS: also, is this the best way to have the fastest screen update possible, without screen tearing?

Hi. Take a look at this demo effect. It uses two screens, one at $2800 and another one at $2c00:
https://github.com/neilsf/XC-BASIC/blob/master/examples/plazma/plazma.bas

is this the best way to have the fastest screen update possible, without screen tearing?

It depends. You can't update the whole screen under 1/50th of a second, that's for sure, even in assembly it's not doable. In Flying Saucers we're updating only an area of 40x8 chars, the rest is static. This way we don't need double buffer at all. XC=BASIC has its limitations, you have to try what's possible and what's not.

Thanks, great example!
I managed to do a simple double buffering test.
Just using a higher memory address for the back-buffer did the trick.
From the plazma example I learned to "flatten" the poke peek command sequence, poking directly a binary value should save a couple of cycles!

In Flying Saucers we're updating only an area of 40x8 chars, the rest is static.

I liked it very much, and the fact that it is coded in XCBasic makes it even more awesome!


Add internationalization of Chinese language

Thanks for the PR. Will look at it shortly and see about merging it.

@bingxue314159 Just wondering what dialect of Chinese this is? I really don't know much about the different dialects, so I thought it better to get more info prior to merging.
Sorry for the extreme delay!


The uploader should retry when there's an error

Uploaders weren't always retrying in all the situations they should've been, so this hopefully addresses that. Also does a slight readability refactor.

Is a test feasible?

Not super feasible for the retry change, but the other changes are well tested.


Rearrange code and fix disappearing listeners

The listener was overwritten. I also rearranged the code a bit to be similar to existing view implementations.

@KochTobi thanks again so much for debugging this. The fix is included in #374 !


PSD2 (Payment Service Directive 2) Verify API feature

A new feature has been added to the Verify API (https://github.com/Nexmo/code-snippet-specs/pull/28) with its own endpoint https://api.nexmo.com/verify/psd2/json. Should we create a new Verify method to cover it? It will also need its own code snippets for with a workflow and without.

not yet! The change isn't actually released at this point, but the API is agreed so I started the ball rolling with the specs.

Okay! Keep us updated when it's ready! :)

@benhayehudi Just FYI that linked repo isn't public. Generally I've been waiting until APIs are documented in the api-specification and/or on NDP before implementing them.

@benhayehudi Just FYI that linked repo isn't public. Generally I've been waiting until APIs are documented in the api-specification and/or on NDP before implementing them.

Yes, that is good practice. It's my first day back to work after a personally difficult last month and was just going through the list of possible work items when creating this issue. Of course, it can wait until it's public.

@benhayehudi No problem, hope all is okay now ❤
As expected no problems with ruby 2.7 but a build issue with truffleruby, I'll look at that tomorrow.


Custom decoration that looks & feels the same on all windows version ?

Hi @oberth
Thanks for the great samples.
There're some window out there that has a native AND custom look on all windows version like this one (the source is little complicated)

And these sort of window could be resize outside of window frame plus all other native windows features (Aero shake, Shadow, minimize animation)
could you help me to find the logic behind these type of window frame ?
I know this is a lot of work but i want to have the right start point to do that and publish final result to others and fill this hole !

The title bar and buttons are completely custom drawn, so I'm not sure what you mean with "native AND custom look".
The telegram window, unlike a plain WS_OVERLAPPEDWINDOW window, can also be resized above the top of the custom drawn fake title bar. If you inspect the window with Spy++, you'll find it uses a WS_POPUP derived style with WS_THICKFRAME and friends to enable the aero functionality.
You'll also find a number of additional windows titled TelegramShadow0, TelegramShadow1, and so on, which extend beyond the edges of the visible main window. These are likely set up to act as the invisible resize borders.

The title bar and buttons are completely custom drawn, so I'm not sure what you mean with "native AND custom look".

Native + Custom = Having native features (Aero shake + minimize animation ,...) while looks like custom drawn maybe should be native features + custom look !
Also it seems there are two window (when minimize):

And if we look at the source we can find that shadows are custom drawn using GdiPlus


Crash on AttributeError or LocationValueError

When scanning ecommerce.barclays.com I see two different possible crashes, seemingly at random:
~/pshtt-docker/pshtt$ docker run --rm -it --name pshtt -v $(pwd):/data -e USER_ID=1042 -e GROUP_ID=1042 pshtt/cli --output=april1.csv --debug --timeout=15 --preload-cache=PRELOAD ecommerce.barclays.com
Fetching Chrome preload list from source...
Starting new HTTPS connection (1): chromium.googlesource.com
"GET /chromium/src/net/+/master/http/transport_security_state_static.json?format=TEXT HTTP/1.1" 200 None
Caching preload list at PRELOAD
Fetching Chrome pending preload list...
Starting new HTTPS connection (1): hstspreload.org
"GET /api/v2/pending HTTP/1.1" 200 325150
Pinging http://ecommerce.barclays.com...
Starting new HTTP connection (1): ecommerce.barclays.com
"GET / HTTP/1.1" 302 213
Starting new HTTP connection (1): ecommerce.barclays.com
"GET / HTTP/1.1" 302 193
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/local/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/src/app/pshtt/cli.py", line 73, in <module>
    main()
  File "/usr/src/app/pshtt/cli.py", line 54, in main
    results = pshtt.inspect_domains(domains, options)
  File "pshtt/pshtt.py", line 892, in inspect_domains
    results.append(inspect(domain))
  File "pshtt/pshtt.py", line 61, in inspect
    basic_check(domain.http)
  File "pshtt/pshtt.py", line 216, in basic_check
    ultimate_req = ping(endpoint.url, allow_redirects=True, verify=False)
  File "pshtt/pshtt.py", line 131, in ping
    timeout=TIMEOUT
  File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 71, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 57, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 475, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 606, in send
    history = [resp for resp in gen] if allow_redirects else []
  File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 179, in resolve_redirects
    **adapter_kwargs
  File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 585, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 370, in send
    conn = self.get_connection(request.url, proxies)
  File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 279, in get_connection
    conn = self.poolmanager.connection_from_url(url)
  File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 143, in connection_from_url
    return self.connection_from_host(u.host, port=u.port, scheme=u.scheme)
  File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/poolmanager.py", line 114, in connection_from_host
    raise LocationValueError("No host specified.")
requests.packages.urllib3.exceptions.LocationValueError: No host specified.

~/pshtt-docker/pshtt$ docker run --rm -it --name pshtt -v $(pwd):/data -e USER_ID=1042 -e GROUP_ID=1042 pshtt/cli --output=april1.csv --debug --timeout=15 --preload-cache=PRELOAD ecommerce.barclays.com
Fetching Chrome preload list from source...
Starting new HTTPS connection (1): chromium.googlesource.com
"GET /chromium/src/net/+/master/http/transport_security_state_static.json?format=TEXT HTTP/1.1" 200 None
Caching preload list at PRELOAD
Fetching Chrome pending preload list...
Starting new HTTPS connection (1): hstspreload.org
"GET /api/v2/pending HTTP/1.1" 200 325150
Pinging http://ecommerce.barclays.com...
Starting new HTTP connection (1): ecommerce.barclays.com
"GET / HTTP/1.1" 302 193
Starting new HTTP connection (1): ecommerce.barclays.com
"GET / HTTP/1.1" 302 213
Starting new HTTPS connection (1): ecommerce.barcap.com
"GET / HTTP/1.1" 301 243
"GET /online HTTP/1.1" 301 244
"GET /online/ HTTP/1.1" 302 291
Starting new HTTPS connection (1): live.barcap.com
"GET /UAB/S/ecom/logon/1/default?returnUrl=https%3a%2f%2fecommerce.barcap.com%2fonline%2f HTTP/1.1" 200 10250
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/local/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/src/app/pshtt/cli.py", line 73, in <module>
    main()
  File "/usr/src/app/pshtt/cli.py", line 54, in main
    results = pshtt.inspect_domains(domains, options)
  File "pshtt/pshtt.py", line 892, in inspect_domains
    results.append(inspect(domain))
  File "pshtt/pshtt.py", line 61, in inspect
    basic_check(domain.http)
  File "pshtt/pshtt.py", line 234, in basic_check
    base_immediate = parent_domain_for(subdomain_immediate)
  File "pshtt/pshtt.py", line 736, in parent_domain_for
    return str.join(".", hostname.split(".")[-2:])
AttributeError: 'NoneType' object has no attribute 'split'

Apologies for dropping this, @fishouttah20 - is this still a reproducible issue for you? Is it only when using Docker?

Hi @fishouttah20 -- I don't think this is reproducible anymore (in fact, in the second example, the code has changed quite a bit, and that hostname.split(...) line doesn't exist anymore.
I'm going to go ahead and close this for now, but if you're still having issues, please open a new ticket, and we'll take a look!


How to tell if it's installed correctly?

After run the project, there is no any sign of that it works or not, no error output in console.app that you mentioned.
Would it be shown or where and what menu its place is under ?

If it's installed correctly, it should created a new item called RegX in submenu of Edit menu item.


heartbeat draft

i'm looking for a good cover image, so that will be replaced before we publish

https://www.zazzle.com/t_shirt-235920696568133954  - this is fun @elleobrien  :))
(but let's add it to the links exclusion list please, otherwise CI fails  ^^ - it doesn't all us to check it - throws HTTP 403)

how about btw take that image as a header image :)

@shcheklein thanks for comments! as for using upwork... right now, the header images take <10 minute because i made a template a while ago (on Adobe Spark). So less time than hiring someone. But if we want to go any more complicated designs in the future, contractor is the way to go.

So less time than hiring someone

yep, I was thinking about someone who can do on a permanent basis - similar to the vide editing? (so that we don't create a new job just for one image every time)

@shcheklein may be worth it in the long run. will start looking around for someone when we release next Community Gems (could have Gems cover and HB covers).

@rogermparent the link checker seems to be breaking on twitter URLs, which are usually no problem. can you take a look?

@rogermparent the link checker seems to be breaking on twitter URLs, which are usually no problem. can you take a look?

curl fails too, returning this in the body:

This browser is no longer supported.

  Please switch to a supported browser to continue using twitter.com.
  You can see a list of supported browsers in our Help Center.

it looks like Twitter returns 400 with the basic agent-less requests we send. My assumption is that they check against a whitelist of user agents, and a true fix involves confirming this and adding the capability to mock user agents to the link check script- possibly on a per-site basis, but I have a feeling that every site would support something like the latest google chrome user agent.

Confirmed that curl the user agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.89 Safari/537.36 gets a 200 from Twitter.

@rogermparent the question here is why does it fail even after it was added to the exclusion list, I guess

@rogermparent the question here is why does it fail even after it was added to the exclusion list, I guess

I must have forgot that Twitter was on the exclusion list, I'll have to check that out.

But I thought this was the link that failed https://www.zazzle.com/t_shirt-235920696568133954, no?

But I thought this was the link that failed https://www.zazzle.com/t_shirt-235920696568133954, no?

No, it's all Twitter links that are failing on the report. I think Twitter may have recently just started filtering user agents.

Yep, I see .. yesterday it was all about that one ... https://github.com/iterative/dvc.org/runs/1554043079

We can update the user agent, I guess.

Yep, I see .. yesterday it was all about that one ... https://github.com/iterative/dvc.org/runs/1554043079

curling this gives the following in the body:

 Access to this page has been denied because we believe you are using automation tools to browse the website.
 This may happen as a result of the following:    Javascript is disabled or blocked by an extension (ad blockers for example)   Your browser does not support cookies    Please make sure that Javascript and cookies are enabled on your browser and that you are not blocking them from loading.

And this happens even with the user agent that fixes twitter, so it's a good example of sites that are more strict about non-browser requests.

I'm wondering if it just failed on the zazzle link first and that's why we
didn't see twitter errors yesterday
On Fri, Dec 18, 2020 at 12:58 PM Ivan Shcheklein<EMAIL_ADDRESS>wrote:

Yep, I see .. yesterday it was all about that one ...
https://github.com/iterative/dvc.org/runs/1554043079
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/iterative/dvc.org/pull/2025#issuecomment-748315835,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHCXB5E6EGN6IVYBHZCIEUDSVO7ABANCNFSM4U3RBR4A
.

I'm wondering if it just failed on the zazzle link first and that's why we didn't see twitter errors yesterday

While anything is possible, I don't think this is the case. I'm pretty sure the link check script was written specifically not to stop early other than Exceptions that would prevent any check output at all.
It sounds a little silly even to me to blame the appearance of this issue on Twitter changing their behavior on user agents overnight, but I can't think of any other scenario where it wouldn't have been an issue already since we do a lot of link checks and additions of Twitter links. That said, this anti-scraper behavior is very commonplace and just something this script needs to adapt to on a per-site basis, because they all behave a little differently.


[suggestion] Free Code Security Plugin, Pixeebot

Is your feature request related to a problem? Please describe.

Pixeebot helps improve project's codebase via opening PRs to help improve code security, common vulnerabilities, common Sonar or CodeQL issues & more.
Describe the solution you'd like

Installing the Pixeebot plugin located within the GitHub marketplace -> Install Here
Describe alternatives you've considered

N/A - think of it as a more advanced version of dependabot
Additional context

More Context:

https://pixee.ai
https://docs.pixee.ai

These are the PRs that have been generated so far on a forked version of /langchain4j:
https://github.com/Pixee-Bot-Java/langchain4j/pulls


reserve_asset doesn't reduce balance of UIA asset

See this thread for details:
https://bitsharestalk.org/index.php/topic,19458.0.html

this one should be labeled High Priority

Even more severely, this operation attempts to reduce your BTS balance instead of the asset's balance:
unlocked >>> reserve_asset gatewaytest ABCDEF 100000000 true
reserve_asset gatewaytest ABCDEF 100000000 true
1452531ms th_a       wallet.cpp:1851               sign_transaction     ] Caught exception while     broadcasting tx 5993cdf3fa64f85fbbb
2faa7d7ed14f52a9e8869:  0 exception: unspecified
10 assert_exception: Assert Exception
itr->get_balance() >= -delta: Insufficient Balance: gatewaytest's balance of 744.55657 BTS is less than required 100000000 BTS

So maybe it should require an additional parameter to make it clear which asset is being spent? e.g.:
reserve_asset gatewaytest ABCDEF 100000000 BTS true

Isn't this the function equivalent to burn asset from the 1.0 chain?

Ah, I see.. I thought this had to do with the fee pool, but saw this:
signed_transaction reserve_asset(string from, string amount, string symbol, bool broadcast)
Burns the given user-issued asset.

You're right.. yeah fixing this seems high priority..


get_default_origin_for_time_vars throws a KeyError if the leading time series values are null

get_default_origin_for_time_vars throws a KeyError if the leading time series value is np.nan.
https://github.com/linkedin/greykite/blob/ce59715ecd3709281c83fac9aef3ce4bb28634ef/greykite/common/features/timeseries_features.py#L75
For example:
from greykite.sklearn.estimator.simple_silverkite_estimator import SimpleSilverkiteEstimator

params =  {'forecast_horizon': 1,
 'uncertainty_dict': {'uncertainty_method': 'simple_conditional_residuals',
                      'params': {'conditional_cols': ['dow'],
                                 'quantile_estimation_method': 'normal_fit',
                                 'sample_size_thresh': 5,
                                 'small_sample_size_method': 'std_quantiles',
                                 'small_sample_size_quantile': 0.99}},
 'fit_algorithm_dict': {'fit_algorithm': 'elastic_net',
                        'fit_algorithm_params': {
                            'l1_ratio': [0.1,0.5,0.7,0.9,0.95,0.99,1]
                        }
                        },
 'holiday_lookup_countries': ['US'],
 'changepoints_dict': {'method': 'auto',
                       'regularization_strength': None,
                       'actual_changepoint_min_distance': '7D',
                       'potential_changepoint_distance': '3D',
                       'yearly_seasonality_order': 6,
                       'no_changepoint_proportion_from_end': 0.18},
 'yearly_seasonality': 'auto',
 'quarterly_seasonality': False,
 'monthly_seasonality': False,
 'weekly_seasonality': 'auto',
 'daily_seasonality': 'auto',
 'coverage': 0.95
 }
df = pd.DataFrame({'ds':pd.date_range('2021-08-18', periods=20), 'y': range(1,21)})
m = SimpleSilverkiteEstimator(**params)
m.fit(df, time_col="ds", value_col="y")

will fit and predict as expected, however,
df.loc[0, 'y'] = np.nan
m.fit(df, time_col="ds", value_col="y")

will throw a *** KeyError: 0
This happens because of the [0] indexing. When null values are dropped so is the index 0 which results in the KeyError. This issue can be addressed by using iloc[0]` instead to access the first row in the dataframe.
Let me know if this is intentional - happy to open a PR otherwise!
Vicky

Hi @vandonova thanks for the detailed explanation! Yeah I agree that changing to .iloc[0] would be a more general solution. Greykite has pipeline which does droping/interpolating NANs and resetting indices, so if you call the library from the templates level this won't be an issue, but yeah if you directly use the estimators, there can be this issue. It's greatly appreciated if you can help fix this issue by submitting a PR, thanks!
Kaixu

Fixed in the next release.


If new name is empty, don't update

fixes #509

Good catch with the table! I’ll do the same there.
…
On Wed, Oct 13, 2021 at 6:24 PM bobular @.***> wrote: Out of curiosity I checked the visualization name, and that allows an empty name (hell, why not?) with no error messages. The My Analyses table editable names do gracefully display an error (see the 400 above table) - but it's no biggie: [image: image] https://user-images.githubusercontent.com/308639/137220854-90969e40-f875-4063-b8c8-296d5b260103.png — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#569 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACZEU5CEWOPXXDSWHWYFOTUGYBLHANCNFSM5F56QBWA .

Yes, good catch! We'll also want to add protection to Public Analyses as well.


Auto save in new settings results in multiple validation errors when typing text

Continuing discussion from #58537

Steps to Reproduce:
Open new settings editor, search for "emmet extension"
Emmet: Extensions Path is a setting that takes path to a directory. Start typing a path
Since we auto-save in 100ms, the config change event is fired for almost every other character typed, which results in validation checks from the emmet extension resulting in a series of error notifications.
There might be other extensions in the marketplace that do such validations after listening the config change event.

If we're considering adding a save button, there's a difference between a save button for an individual setting vs a save button for the whole settings editor.
I think I'd be more open to a save button on certain individual text fields than a save button for the whole settings editor. In the first case, the impact is very minor and it only affects settings that really need it. In the second case, it would be very frustrating to open the settings UI, click a checkbox, then have to click a save button as well.

@roblourens the C/C++ extension is also affected by the fast auto save feature from the settings UI editor (see issue #3644).
The C/C++ extension has a similar settings UI editor accessed via command C/C++: Edit configurations (UI). Changes to any text field from the UI editor is saved when an input text field loses focus. Can we also do the same for the VS Code settings text field input?

Closing as out of scope. Repro cases also seem outdated.


variants endpoint needs gene aliases returned

The new browse-by-gene mode can have an 'aliases' column for each gene, but the server doesn't return these from the /variants endpoint, can we get aliases for each gene as well?
Issue #35 over in civic-client

The 'aliases' should be taken verbatim from Entrez gene (via MyGeneInfo) as we do with the long gene names and description.

So have we decided we are going to track gene aliases? That will require some importer changes and a new database table. We're currently only storing the entrez id, symbol and clinical description. Everything else is pulled dynamically from MyGene.info on page load.

Yeah, I think it would be very helpful to be able to view them in the data grid and filter on them in that view.
If it is a pain to update the schema/importer, I guess we could store the aliases as a simple string in the same table as symbol and clinical description?
Unlike the gene symbols these aliases can be reused in different contexts.  Furthermore, there is to my knowledge no additional information associated with each alias.  But I could be wrong there.  I believe the list of aliases for each gene entry is the product of fairly manual curation by the Entrez team.
I can't think of any need for them to be accessed individually right now... but that could change I guess.
Up to you @acoffman on how best to modify the schema.

I think the main application is that when doing a live search of HER2 or other aliases the system is smart enough to show not only genes that match that string but also genes that have it as an alias.

Cool, are gene aliases guaranteed to be unique to a single gene?

Unfortunately not. It is possible that two genes with different gene symbols (that are guaranteed to be unique) might share the same synonym. And, in some cases a synonym of one gene might actually be the unique symbol of another gene.

And that is where the manual curation comes in.  Entrez has assigned a unique symbol to each gene locus.  They have then curated the literature to find places where alternate names are used to refer to particular genes.  In the very common case where a colloquial name for a gene is used they try to determine which unambiguous gene they are likely referring to.  Then then add that synonym to the possible alternate names for the appropriate gene.

Gotcha, so from a data model perspective, this is a many-to-many. A gene can have many synonyms (obviously), but a synonym could also potentially refer to multiple genes.

Correct.

Done in b88e06c3b834a1abc77b4a76e1e0c36120bb5d56. You'll need to reimport to see any aliases as the scraping is done at that point!


Are operators 'in' and 'not in'  supported?

How to build a predicate like 'Id in @1' or 'Id not in @1'

I am sorry, It works.
rep.Where("Id in @0",new long[] { 3, 5 });


[release-v1.62] Improve reconciliation of extension BackupBucket and BackupEntry

Cherry-pick of #7281 on release-v1.62
Release note:

A bug causing the extension `BackupEntry` not to be correctly reconciled in case of secret rotation and a controller restart is now fixed.

/kind bug

/cc @timuthy @ary1992

/lgtm
/approve
/retest


Labels and envs dict to structure

As well as @phracek in #28, I need to parse ENV/LABEL key-values for each instruction.
For a backwards compatibility, I've only added another item to instruction dictionary:
FROM fedora:25

LABEL summary="Postfix is a Mail Transport Agent (MTA)." \
       version="1.0" \
       description="Postfix is mail transfer agent that routes and delivers mail." \
       io.k8s.description="Postfix is mail transfer agent that routes and delivers mail." \
       io.k8s.display-name="Postfix 3.1" \
       io.openshift.expose-services="10025:postfix" \
io.openshift.tags="postfix,mail,mta"

{
    u'startline': 2,
    u'dictionary': {u'io.k8s.description': u'Postfix is mail transfer agent that routes and delivers mail.',
                    u'description': u'Postfix is mail transfer agent that routes and delivers mail.',
                    u'io.k8s.display-name': u'Postfix 3.1',
                    u'summary': u'Postfix is a Mail Transport Agent (MTA).',
                    u'version': u'1.0',
                    u'io.openshift.expose-services': u'10025:postfix',
                    u'io.openshift.tags': u'postfix,mail,mta'},
    u'instruction': u'LABEL',
    u'value': u'summary="Postfix is a Mail Transport Agent (MTA)."        version="1.0"        description="Postfix is mail transfer agent that routes and delivers mail."        io.k8s.description="Postfix is mail transfer agent that routes and delivers mail."        io.k8s.display-name="Postfix 3.1"        io.openshift.expose-services="10025:postfix" io.openshift.tags="postfix,mail,mta"',
    u'content': u'LABEL summary="Postfix is a Mail Transport Agent (MTA)." \\\n       version="1.0" \\\n       description="Postfix is mail transfer agent that routes and delivers mail." \\\n       io.k8s.description="Postfix is mail transfer agent that routes and delivers mail." \\\n       io.k8s.display-name="Postfix 3.1" \\\n       io.openshift.expose-services="10025:postfix" \\\nio.openshift.tags="postfix,mail,mta"\n',
    u'endline': 8
}

There has been restructured/refactored the parsing function and added some basic tests.
What do you all think about it?
Thanks for any suggestions.

I've also removed one test:
-        lines.insert(-1, '{0} "name1"=\'value 1\' "name2"=myself name3="" name4\n'.format(i))
+        lines.insert(-1, '{0} "name1"=\'value 1\' "name2"=myself name3=""\n'.format(i))

-        assert instructions.get('name4') == ''

I am not sure, but this ENV/LABEL Dockerfile syntax is not valid:
LABEL "name1"='value 1' "name2"=myself name3="" name4
(missing value for name4)

Could you please elaborate on the use-case for this?

Thank you for your response.
I'm working on a builder for docker images and need to take labels/variables per instruction. (Not for the whole dockerfile.)
Example:
FROM fedora:25
ENV key=value
RUN command $key
ENV key=another_value key2=value2

When calling RUN command $key, I need only variables defined in the previous lines. (The envs property of parser is not valid in that case.)

Or what about having separate properties label_structure and env_strucutre, with valid state for each instruction? Example would be probably better to understand:
FROM fedora:25
ENV key=value
RUN command $key
LABEL label1="description 1" label2="description2"
ENV key=another_value key2=value2

dockerfile_parser.env_structure = [
{},
{'key': 'value'},
{'key': 'value'},
{'key': 'value'},
{'key': 'another_value', 'key2': 'value2'}
]

dockerfile_parser.label_structure = [
{},
{},
{},
{'label1': 'description 1', 'label2': 'description2'},
{'label1': 'description 1', 'label2': 'description2'}
]

This is precisely what I need, but is this more usefull for others than the previous aproach?

I'm wondering if having a way to iterate over each instructions while accessing the current context is a more intuitive approach. Something along the lines of:
for instruction, context in self.interactive_instructions:
  print(context.label)  # {'label1': 'description 1'}
  print(context.env)  # {'env1': 'value 1'}
  # instruction is the same as the items in self.structure

The context would obviously be read-only.

@lcarva, iterating over each instruction would be a good idea. Thank you.
I'm just thinking about a value of context.label/context.env.
What about this example?
FROM fedora:25
ENV key=value
ENV key2=$key

There are three options of context.env for last line:

{'key2': '$key'} - raw values for this line
{'key2': 'value'} - value for this line with variable expansion
{'key': 'value', 'key2': 'value'} - all variables valid on this line

The first is probably useless, but second and third would be useful. Provide both of them can be also a solution.

I think that during iteration, the env_replace parameter provided at construction time should be honoured. If some caller wants to see both the raw and substituted values at the same time they should zip two iterators together.

Thank you for your tips.

I have a question to behaviour:
Here is my program:
from dockerfile_parse import DockerfileParser

dfp = DockerfileParser()

dfp.content = """FROM x
LABEL x=y
RUN x
LABEL a=b c=d
ENV q=1
 w=2
LABEL i=8"""

for context in dfp.context_structure:
    print("envs: {}\n"
          "labels: {}\n"
          "line_envs: {}\n"
          "line_labels: {}\n"
          .format(context.envs, context.labels,
                  context.line_envs, context.line_labels))

And here's the output:
envs: {}
labels: {}
line_envs: {}
line_labels: {}

envs: {}
labels: {u'x': u'y'}
line_envs: {}
line_labels: {u'x': u'y'}

envs: {}
labels: {}
line_envs: {}
line_labels: {}

envs: {}
labels: {u'a': u'b', u'x': u'y', u'c': u'd'}
line_envs: {}
line_labels: {u'a': u'b', u'c': u'd'}

envs: {u'q': u'1'}
labels: {u'a': u'b', u'x': u'y', u'c': u'd'}
line_envs: {u'q': u'1'}
line_labels: {}

envs: {u'q': u'1'}
labels: {u'a': u'b', u'x': u'y', u'c': u'd', u'i': u'8'}
line_envs: {}
line_labels: {u'i': u'8'}

I would expect that the third item would look like this:
envs: {}
labels: {u'x': u'y'}
line_envs: {}
line_labels: {}

Is this bug or do I just don't understand it?

@TomasTomecek thank you for finding the bug. It should be corrected and covered by some tests.
Is the documentation OK?

LGTM now, thank you!
Luiz, Tim: waiting for your approval, don't want to merge this myself. I believe @lachmanfrantisek would also appreciate cutting a new release afterwards. I can help with builds in Fedora.

@twaugh, the context_structure has been updated. Is it OK?

I really like the last commit, looks a lot more cleaner.

This is looking really good! Just a few comments regarding code style.

@lachmanfrantisek I think that github doesn't notify when you add/change commits so you should add a comment whenever you add something :)
@lcarva ready for another review round?

@TomasTomecek thanks, good to know..;-)

@lcarva thank you. And what do you think of the env_replace? Should I have to change it to this?
 def extract_labels_or_envs(env_replace, envs, instruction_value):
+    if env_replace:
+        instruction_value = EnvSubst(instruction_value, envs).substitute()
+
    shlex_splits_raw = shlex_split(instruction_value,
                                   env_replace=env_replace, envs=envs)

    key_val_list = []
    if '=' not in shlex_splits_raw[0]:  # LABEL/ENV name value
        # split it to first (name) and the rest (value)
        key_val = instruction_value.split(None, 1)
        key = strip_quotes(key_val[0])
        try:
            val = key_val[1]
        except IndexError:
            val = ''

-        if env_replace:
-            val = EnvSubst(val, envs).substitute()
         val = remove_nonescaped_quotes(val)

@lachmanfrantisek we need to match behaviour of docker here, can you check how docker behaves? I guess that something like this could be a good test case:
ENV x="a b 'c'"
ENV y="'d' e 'f g'"
LABEL n=$x m="$y" o='$x $y'

And what do you think of the env_replace? Should I have to change it to this?

Can you elaborate on what that means? I'm not sure I fully understand the proposed change.

@TomasTomecek yes, docker parses your example as follows:

envs:

"x=a b 'c'",
"y='d' e 'f g'"

labels:

"m": "'d' e 'f g'",
"n": "a b 'c'",
"o": "$x $y"

@lcarva my proposed change does not work on the previous example by @TomasTomecek . The current version of dockerfile-parse is failing as well. I'm working on it for some hours and still not finished. It is not so easy as it looks. It needs huge changes on parsing and escaping quotes.
What about moving it to another issue?

What about moving it to another issue?

+1 on that! Let's isolate these changes.

+1 on that! Let's isolate these changes.

Ok, I can look at it later.

@lcarva I've created an issue #34 for the problem with parsing.
Can we merge this as it is?

Can we merge this as it is?

I think so. @twaugh wanna take a look first?

I'm also +1 on merging this if the behaviour with quotes is the same -- I would say it's kind of a corner case, usually the env vars and labels are "sane".

@twaugh @lcarva Are there any problems with the merging?
Thanks.

I checked with @twaugh today and there is only one problem: time.

OK, I'll wait. No problem.

@twaugh both points should be corrected. Thanks for such a deep review and all suggestions.

@twaugh I've added some tests for the key = "with = in value" format.

Please squash commits into logical changes (perhaps only 1 commit?); then I'll rebase and merge.

@twaugh is it OK?
Thank you very much for all your reviews and advice.

Thanks very much for being patient. :)

@twaugh As @TomasTomecek said, I would greatly appreciate the release of the new version. Is that possible, please?
Thanks in advance.

I think the spec file needs sorting out first. There were some changes made in the Fedora spec file that I've been trying to port, most of them make sense (but some are wrong).

OK, maybe @TomasTomecek can help with this?

Actually now I look more closely it seems I already merged that. :)

Thanks..;-)


Add maven suppport

I feel kinda bad that I forgot this pull existed. Anyways I'm don't see this project as something complex enough to warrant converting it to a maven project.

I didn't implement maven because the project was complex but to make it easier to compile and configure in Jenkins.

Ah. I'm not familiar with Jenkins. Does github have integration for it or would you have to host a Jenkins server on your own?

I have my own local Jenkins server but there are other free self-hosting alternatives like AppVeyor.


error in lucene index

OrientDB Version: 3.0.m2
Java Version: 8
OS: linux
there are 2 problems (one critical , one not critical) :
critical when i create index programmatically index is created but is not working
instead if i create using console it works
oc.createIndex(n, o.name,null, d, o.algorithm(), o.fields());

where algorithm is LUCENE
name is FULLTEXT
fields are a,b,c
not critical : in the indexes command the table dont show fields when is lucene

problem with old javascript scripts
var a=db.command(....)
a.field('code') dotn works

The test:
https://github.com/orientechnologies/orientdb/blob/develop/lucene/src/test/java/com/orientechnologies/lucene/tests/OLuceneCreateJavaApiTest.java
uses the java api to create lucene index. Is your code similar?
about:
"problem with old javascript scripts var a=db.command(....) a.field('code') dotn works"
I don't understand what are you meaning.

about first question
OIndex<?> lucene = song.createIndex("Song.author_description", OClass.INDEX_TYPE.FULLTEXT.toString(), null, null, "LUCENE",
new String[] { "author", "description" });
i see a different in the fourth parameter you pass null instread i pass document. I will try to remove d...
about second question: it is not related with this problem : javascript api is changed but they was not compltetely committed. There also now a missing info about doc.identity ... not working in 3.x.

"about second question: it is not related with this problem : javascript api is changed but they was not compltetely committed. There also now a missing info about doc.identity ... not working in 3.x."
Please open another issue, I will not care about it, thanks

it seams all solved


[Doc Improvement][document-signing]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
92
15
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/in-meeting-notification-for-meeting.md
95
1
link
:white_check_mark:

msteams-platform/sbs-inmeeting-document-signing.yml
86
32
link
:white_check_mark:

msteams-platform/whats-new.md
92
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 07df31d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 07df31ddbc7a1de6c2fdf8a8acb1d3aea12ca192 in branch sbs-section of repository https://github.com/MicrosoftDocs/msteams-docs into branch main (commit d11dff0cc461867eab8a53b564f52566ebb16c3b). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
92
15
link
:white_check_mark:

msteams-platform/sbs-inmeeting-document-signing.yml
86
32
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 8778ac1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-inmeeting-document-signing.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
92
15
link
:white_check_mark:

msteams-platform/sbs-inmeeting-document-signing.yml
86
32
link
:white_check_mark:

msteams-platform/whats-new.md
92
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit efb0ccd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-inmeeting-document-signing.yml
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
92
15
link
:white_check_mark:

msteams-platform/sbs-inmeeting-document-signing.yml
86
32
link
:white_check_mark:

msteams-platform/whats-new.md
92
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit b77c0b9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/build-apps-for-teams-meeting-stage.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-inmeeting-document-signing.yml
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Copy inline string reversed

It seem like some optimization step goes berserk if you copy a byte
slice from start to end. The while-loop is partially unrolled which
results in an excessively long, extremely cache unfriendly code.
If you copy the string in the reverse direction, starting with the last
byte, the optimizer understands the pattern, and uses memcpy(), which
is a sane decision.
If you only use CompactString::new_inline() in a const context, the
difference does not matter. But if you use it for runtime code, the
difference is enormous. Valid use cases for new_inline() in a
non-const context include const function that may be also useful in a
dynamic context.

Interesting, thanks for finding this!


Codemod variant-prop doesn't change files as expected

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
After running the variant-prop codemod, no changes are applied.
Expected behavior 🤔
The script should normally add the variant="standard" to all TextField, Select, and FormControls.
Steps to reproduce 🕹
Steps:

Run npx @mui/codemod v5.0.0/variant-prop  on a project that does has TextField, Select, and FormControls with no variant defined.

Context 🔦
The output in my console when I'm running the command just shows that the script found 144 files but for some reason it left them unmodified:
npx: installed 251 in 4.335s Executing command: jscodeshift<EMAIL_ADDRESS>--transform<EMAIL_ADDRESS>--extensions js,ts,jsx,tsx --parser tsx --ignore-pattern **/node_modules/**  Processing 144 files...  Spawning 7 workers... Sending 21 files to free worker... Sending 21 files to free worker... Sending 21 files to free worker... Sending 21 files to free worker... Sending 21 files to free worker... Sending 21 files to free worker... Sending 18 files to free worker... All done.  Results:  0 errors 144 unmodified 0 skipped 0 ok Time elapsed: 6.511seconds
Your environment 🌎

`npx @mui/envinfo`
System:
    OS: macOS 11.6.2
  Binaries:
    Node: 12.22.1 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.12 - /usr/local/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Edge: Not Found
    Firefox: 95.0.2
    Safari: 15.2
  npmPackages:
    @emotion/react: ^11.7.1 => 11.7.1
    @emotion/styled: ^11.6.0 => 11.6.0
    @mui/base:  5.0.0-alpha.62
    @mui/icons-material: ^5.2.5 => 5.2.5
    @mui/lab: ^5.0.0-alpha.30 => 5.0.0-alpha.62
    @mui/material: ^5.2.5 => 5.2.6
    @mui/private-theming:  5.2.3
    @mui/styled-engine:  5.2.6
    @mui/styles: ^5.2.3 => 5.2.3
    @mui/system:  5.2.6
    @mui/types:  7.1.0
    @mui/utils:  5.2.3
    @types/react:  16.9.17
    react: ^17.0.2 => 17.0.2
    react-dom: ^16.12.0 => 16.12.0

Can you send an example of a file where it did not work?

`import React, { useState, useEffect } from "react";
import TextField from "@mui/material/TextField";
import Paper from "@mui/material/Paper";
import Grid from "@mui/material/Grid";
import Divider from "@mui/material/Divider";
import { connect } from "react-redux";
const useStyles = makeStyles((theme) => ({
paper: {
marginBottom: theme.spacing(2),
},
root: {
width: "100%",
},
}
function ExampleComponent(props) {
const classes = useStyles();
const [varA, setVarA] = useState(props.varA)
  return (

        <Paper className={classes.paper}>
            <Grid container spacing={3}>
                <Grid item xs={12}>

Some Text

                </Grid>
            </Grid>
            <Divider />
                <form className={classes.root} noValidate>
                    <TextField
                        fullWidth
                        label="Name"
                        defaultValue={varA}
                        InputProps={{
                            readOnly: true,
                        }}
                    />
                    <TextField
                        fullWidth
                        label="Created"
                        defaultValue={created)}
                        InputProps={{
                            readOnly: true,
                        }}
                    />
              )

}
const mapStateToProps = (state) => {
return {
varA: state.varA,
};
};
export default connect(mapStateToProps, {
actionB,
})(ExampleComponent);Same thing happens when I havevalue={...}instead ofdefaultValue`

I think I found the issue, the codemod uses a regex to match "/^@material-ui/core(/TextField|/Select|/FormControl)?$/" but preset-safe rewrote the imports to "@mui/material" so they get skipped. When I change the import back, the changes were made.

That makes sense. So you should probably either fix the codemod to find the updated imports or update your docs to mention that you have to first run the variant-prop codemod and then the preset-safe.
In my case, I updated my code using my IDE, wasn't that hard afterall but I would have prefered the codemod to work.
Thanks and Happy New Year.

https://github.com/mui-org/material-ui/issues/30422#issuecomment-1003168679 I believe this is on purpose, if the import is from @mui the variant doesn't need to be updated. I assume that the issue is more about the need to clarify that https://mui.com/guides/migration-v4/#variant-prop/https://github.com/mui-org/material-ui/blob/master/packages/mui-codemod/README.md#variant-prop should be run first.
cc @siriwatknp.

https://github.com/mui-org/material-ui/issues/30422#issuecomment-1003168679 I believe this is on purpose, if the import is from @mui the variant doesn't need to be updated. I assume that the issue is more about the need to clarify that https://mui.com/guides/migration-v4/#variant-prop/https://github.com/mui-org/material-ui/blob/master/packages/mui-codemod/README.md#variant-prop should be run first.
cc @siriwatknp.

I would say that this is a bug. To give the best experience, the Codemod should be independent of each other. The fix should be pretty straightforward (updating the regex to include @mui/material). Feel free to submit a PR (otherwise I can do it this week).


go-sqlcmd is failed to execute the tsql script contains any special charectors

Below command is executing fine in SSMS but failed when executing like  sqlcmd -Sgo-sqlcmdvm -iF:\specialchar_sql.sql
--Create TestDB
USE TestDB;
GO
CREATE TABLE temptable(
ID INT IDENTITY(1,1) PRIMARY KEY CLUSTERED ,
Item  VARCHAR(50),
value VARCHAR(50),
);
INSERT INTO dbo.temptable (  Item, value )
VALUES ( 'Item-A', '$(100.12)' );
GO
Error details
C:\Users\sqladmin>sqlcmd -Sgo-sqlcmdvm -iF:\specialchar_sql.sql
Changed database context to 'TestDB'.
Sqlcmd: Error: Syntax error at line 10

using $() syntax doesn't work in sqlcmd because it's interpreted as a variable referenece. Disable variable evaluation.


Add test lengths to suite

Adds a timeout of 20 seconds to all plugin tests except for no_stack_protection which has a timeout of 60 seconds. The tests for updating the number of loop unrolls has a timeout of 1 second.

Looks good.


[update] license year

Please add this to the original PR instead of opening a new one.

We follow a fairly standard github workflow for open source projects - http://www.asmeurer.com/git-workflow/ provides a good walkthrough of common steps. In particular:

Pushing additional changes. Once you have created the pull request, it will likely be reviewed and some additional fixes will be necessary. Do not create a new pull request. Rather, simply make more commits to your branch and push them up as in steps 3 and 4. They will be added to the pull request automatically. Note that although GitHub does notify people when you push new changes to a branch, many people have these notifications disabled as they can be quite noisy. So it is a good idea to make a comment on the pull request whenever you do so to notify people that it is ready to be reviewed again.


Support non-id primary keys

It looks like Admiral is hard-coded to expect an id attribute to be the primary key for data.
https://github.com/dev-family/admiral/blob/e58118b7b59c4db542bc0b38acfe66535e7d3026/admiral/dataTable/DataTable.tsx#L281
https://github.com/dev-family/admiral/blob/e58118b7b59c4db542bc0b38acfe66535e7d3026/admiral/crud/index.tsx#L55
https://github.com/dev-family/admiral/blob/e58118b7b59c4db542bc0b38acfe66535e7d3026/admiral/crud/index.tsx#L63
This is an issue if using an API with a different name for the primary key! (For example, I'm trying to work with objects that have sessionID as their primary key.)
It would be useful to be able to specify this as part of a CRUD definition.

Thanks for your interest and your question!
We have built the application architecture in such a way that circles and queries sent within them are built based on the passed ´path´ and ´id´.
Queries to retrieve table data must return a string ´id´ in the data structure. This ´id´ is used for further logic, e.g. for actions in the table.
At the moment we have this architecture and it will be quite expensive to change it. We have to make changes in a large part of the application.
But if there are desires to be a contributor, you are welcome!


Unable to discover services/characteristics with peripheral-explorer.js in Linux using 1.1.0

I was unable to run the peripheral-explorer.js example using Noble 1.1.0 when running in Linux for a peripherals that work under 1.0.2
I was able to run peripheral-explorer.js under 1.0.2 by changing line 15 from
if (peripheral.id === peripheralId) {

to
if (peripheral.uuid === peripheralId) {

Here is the output I received under each version:
Running using noble 1.0.2
$ sudo node demos/noble-explorer.js d03972c99b39
peripheral with ID d03972c99b39 found
  Local Name        = ronbean
  TX Power Level    = 4
  Service Data      =
  Service UUIDs     = a495ff10c5b14b44b5121370f02d74de

services and characteristics:
f000ffc004514000b000000000000000
  f000ffc104514000b000000000000000 (Img Identify)
    properties  writeWithoutResponse, write, notify
  f000ffc204514000b000000000000000 (Img Block)
    properties  writeWithoutResponse, write, notify
1800 (Generic Access)
  2a00 (Device Name)
    properties  read
    value       726f6e6265616e | 'ronbean'
  2a01 (Appearance)
    properties  read
    value       0000 | ''
  2a02 (Peripheral Privacy Flag)
    properties  read, write
    value       00 | ''
  2a03 (Reconnection Address)
    properties  write
  2a04 (Peripheral Preferred Connection Parameters)
    properties  read
    value       5000a0000000e803 | 'P h'
...

Running under Noble 1.1.0
$ sudo node demos/noble-explorer.js d03972c99b39
peripheral with ID d03972c99b39 found
  Local Name        = ronbean
  TX Power Level    = 4
  Service Data      =
  Service UUIDs     = a495ff10c5b14b44b5121370f02d74de

services and characteristics:

That was all the output for 1.1.0, the program terminated immediately without listing any services/characteristics.

@deadprogram I'm going to need some more info to help you out.

Can you please provide hcidump capture? Output preferably in a Gist: sudo hcidump -t -x
Are you using a Punch Through Bean? I just tried it with one of mine, no issues connecting.

Btw, peripheral.id was introduced in v1.1.0, so the example is not backwards compatible with older releases. See change log

I mentioned that about id so you'd know I was aware of it. I'll let you know when I have a log for you.

@deadprogram any updates?

Also, what kernel version are you using, I think I was seeing similar issues with 4.1.

Hi, @sandeepmistry
I was able to do a complete uninstall and re-install, and my problem "disappeared". One difference was that my previous install was done using sudo, and my current one is running setcap. I was also able to do a clean install successfully on a couple other Linux machines, both of them running as root.
None of the machines I was testing on were running a kernel based on 4.1, all were 3.13+
Anyhow, if I can come up with some more substantive report, I will add to this issue, but sounds like this one can be closed. Thanks!

@deadprogram thanks for the follow up. I'll close for now.


[zh-cn]sync kubeadm_certs_renew kubeadm_certs/_index

content/zh-cn/docs/reference/setup-tools/kubeadm/generated/kubeadm_certs/_index.md
content/zh-cn/docs/reference/setup-tools/kubeadm/generated/kubeadm_certs/kubeadm_certs_renew.md

/lgtm

/approve


Error executing action update on resource 'php_pear_channel[pear.php.net]'

Cookbook version
3.1.0
Chef-client version
Chef: 12.6.0
Platform Details
Ubuntu 14.04.5 LTS
Scenario:
chef-client run
Steps to Reproduce:
run chef-client
pear is in path
Expected Result:
successful run
Actual Result:
Recipe: php::default
  * php_pear_channel[pear.php.net] action update

    ================================================================================
    Error executing action `update` on resource 'php_pear_channel[pear.php.net]'
    ================================================================================

    NoMethodError
    -------------
    No resource or method named `exists?' for `Custom resource php_pear_channel from cookbook php action provider "pear.php.net"'

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/php/resources/pear_channel.rb:58:in `block in class_from_file'
 /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:78:in `run_action'
 /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `block (2 levels) in converge'
 /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `each'
 /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `block in converge'
 /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:105:in `converge'

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/php/recipes/default.rb

     25: php_pear_channel 'pear.php.net' do
     26:   action :update
     27: end
     28:

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/php/recipes/default.rb:25:in `from_file'

    php_pear_channel("pear.php.net") do
      action [:update]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      declared_type :php_pear_channel
      cookbook_name "php"
      recipe_name "default"
    end

Running handlers:
[2017-04-17T19:47:39+00:00] ERROR: Running exception handlers
Running handlers complete
[2017-04-17T19:47:39+00:00] ERROR: Exception handlers complete
Chef Client failed. 7 resources updated in 41 seconds
[2017-04-17T19:47:39+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2017-04-17T19:47:39+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-04-17T19:47:39+00:00] **ERROR: php_pear_channel[pear.php.net] (php::default line 25) had an error: NoMethodError: No resource or method named `exists?' for `Custom resource php_pear_channel from cookbook php action provider "pear.php.net"'**
[2017-04-17T19:47:39+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

This has been fixed on master and I'll have a release going out today or tomorrow with the fix

@tas50 Did this get fixed? Im on Chef 12.6.0 + CentOS 6.8
  php (4.2.0)
    build-essential (>= 0.0.0)
    mysql (>= 6.0.0)
    xml (>= 0.0.0)
    yum-epel (>= 0.0.0)


[#7] Need a simple web page for informational purposes

This PR operates on [#7]
The page is in the landing page folder of the branch and is hosted at https://championballer.github.io/landingpage/index. Please review and tell me if any changes or additions are required for the same. Cheers. 👍

Awesome job @championballer!


feat: lint attribute [instance] instName in

Contrary to what users would expect, this defines a global instance.
This linter would have caught #13144 and #13170.
Zulip discussion
Co-authored by: @adomani

I wrote a test yesterday (of course!), but forgot to commit it :facepalm: I've updated it to use your example instance now (and added you as an author of the tests), since this avoid mathlib imports.

I just tried the logic you proposed. It works, so I switched to it (and added you an an author).
I tweaked one test to consider nested syntax (which worked), so I guess attributes are always the first syntax.

!bench

Two minor requests, otherwise
bors d+

Thanks for the fast review.
bors r+

bors r+


KAFKA-17972: Set all tests inheriting from QuorumTestHarness to KRaft

Out of curiosity, what is the next if we have a zk-only list?

migrate the tests to Kraft if the tests are required by Kraft too
Remove the tests if the bugs happen in Kraft only (similar to https://github.com/apache/kafka/pull/17670#discussion_r1835131970)

Thanks

Out of curiosity, what is the next if we have a zk-only list?

There are some things that don't need to be tested any more, because they're gone. For example, there are a bunch of tests of "topics in deleting state" which can go, because deleting state is gone.
There are probably some tests that need to be migrated to KRaft, but haven't been yet. Depending on how many of them there are, we may need to put a @Disable on some of these and create a follow-up JIRA so that we can unblock the broader zk removal effort.

I split the fix of MetricsTest out to #17744

Remove MetadataRequestBetweenDifferentIbpTest.scala in #17745

#17746

another fix here https://github.com/apache/kafka/pull/17757

Fixing FetchRequestDownConversionConfigTest here : https://github.com/apache/kafka/pull/17759

Convert ConsumerTopicCreationTest  : https://github.com/apache/kafka/pull/17760/files

Convert AddPartitionsToTxnRequestServerTest https://github.com/apache/kafka/pull/17762

Created https://github.com/apache/kafka/pull/17765 for fixing the tests inheriting from RebootstrapTest

Convert RackAwareAutoTopicCreationTest to KRaft: https://github.com/apache/kafka/pull/17766

https://github.com/apache/kafka/pull/17780

Convert GssapiAuthenticationTest : https://github.com/apache/kafka/pull/17786/files

remove SaslPlainPlaintextConsumerTest.testZkAclsDisabled: https://github.com/apache/kafka/pull/17902

For fixing DynamicBrokerReconfigurationTest  : https://github.com/apache/kafka/pull/17905

Remove some ZK tests here https://github.com/apache/kafka/pull/17913/files

Fix ConsumerBounceTest here: https://github.com/apache/kafka/pull/17997

It looks like isKRaftTest was removed in #18166 , so we no longer need this PR. I'll close it. Thanks, everyone!


Add "Delete" to the schema for import.

Signed-off-by: Caleb Brown<EMAIL_ADDRESS>

Is this schema documented anywhere? (Other than in 'read the json' form?)


bug: bit-defender alerted cortex on user machine

Some user feedback for cortex from a candidate:
I downloaded cortex, and when I install it on my Windows PC, the Bit Defender alerted cortex was a threat so I could not install it.
In the time I trying to figure how to allow cortex, I read the document of cortex, I found that it likes huggingface-cli, and there is a feature to start cortex as a server.
And, jan.ai is the UI of cortex.
That's what I learnt from the webs.

Cortex v1.0.1 on a machine has bit defender pro

v1.0.0 on a vm has bitdefender pro


Backport: Avoid Link s_vlan duplication to 2023.2

Backport this PR to 2023.2

@Alopalao let's not forget to tag 2023.2.2 upstream

PR was merged


cyclops cli: support for update command

closes #454
📑 Description
adds support for the updating modules using cyctl cli
✅ Checks

[ ] I have updated the documentation as required
[x] I have performed a self-review of my code

Additional context
cyclops  cli currently supports create,delete,describe,get ,this PR adds support for update

have done the requested changes,can you review it now @petar-cvit


Scaffold extension

Scaffold the new Rancher UI extension.
Getting started guide:
https://rancher.github.io/dashboard/extensions/extensions-getting-started

This has been done following the guide


Use in 'stand alone' web resources

The Xrm.WebApi should be made available to stand alone web resources (ie opened from the site map). This would make it easier to build custom SPA 'experiences' in CRM.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36bb046e-50cf-7e3e-062a-ff329fd44090
Version Independent ID: 51693c95-20b5-1683-b325-ddfb37c26fe7
Content: Xrm.WebApi (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/xrm-webapi.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@sidhartg Sid, please take a look at this issue.
@paulhasell Thanks for this issue. Please feel free to raise this at Ideas website.


Fixes the support of the 'keep on reimport' flag - Issue #20878.

This fixes the support for disabling 'Keep on reimport' for materials.
This fix has two components:

check the flag when deciding whether to load existing materials from file or save the imported ones.
after saving the import materials, don't reload them from the cache - if you do, you'll get a stale resource.

Bugsquad edit: Fixes #20878.

Could not get a review from @reduz in 6 months, so let's assume that the changes are fine ;) Code looks good in any case.

Thanks!


[Testing] PR #3471, character in 2Wheeled BB

This issue is intended to track PR #3471 .
Need to test:

The 2 wheeled vehicles include the character inside the BB
The 4 wheeled vehicles are not affected by this change.

Warning! Is possible that the BB visualization in UE editor seems to be wrong. It's important to test it in simulation time.
bboxes = world.world.get_level_bbs(carla.CityObjectLabel.Vehicles)
for box in bboxes:
    debug.draw_box(box, box.rotation, 0.01, carla.Color(0, 0, 142), 100)

I've tested all the 2 wheeled vehicles in simulation and the positions are better than before.


Check and Verify Big O estimates of every solution of each problem.

Fixed all except recursion approximation.

https://users.cs.duke.edu/~ola/ap/recurrence.html
http://stackoverflow.com/questions/2709106/time-complexity-of-a-recursive-algorithm?noredirect=1&lq=1

Normally the space complexity for recursion is it's use of call stack.

should be part of https://github.com/Williammer/leetcode-js/issues/13


Update rails version to pick up security updates

CVE-2015-7576
CVE-2015-7577
CVE-2015-7578
CVE-2015-7579
CVE-2015-7581
CVE-2016-0751
CVE-2016-0752
CVE-2016-0753
Also update uglifier gem from 1.3.0 to 2.7.2, caught by the security audit tool.
We don't use this gem directly, just configure it as a JS compressor.

Waiting for https://github.com/alphagov/slimmer/pull/138


Youtube Upcoming Livestream extract_info()

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Trying to use the extract_info function on a live event that has yet to begin on youtube returns None and sends yt_dlp.utils.DownloadError along with yt_dlp.utils.ExtractorError. Most of the metadata should still be accessible even if the stream itself hasn't begun.
For the below section, as I'm using the python module, I'm not sure how you would like me to handle it, but attached is the code and output.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
>>> url = 'https://www.youtube.com/@AkaiHaato/live'
>>> ydl_opts = {
... 'quiet': True,
... 'cookiefile': 'cookies.txt',
... 'match_filter': is_live,
... 'playlist_items': '1'
... }
>>> with yt_dlp.YoutubeDL(ydl_opts) as ydl:
...     info = ydl.extract_info(url, download=False)
...
ERROR: [youtube] Dv5bNXQzivM: This live event will begin in 48 minutes.
Traceback (most recent call last):
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 674, in extract
    ie_result = self._real_extract(url)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\youtube.py", line 3862, in _real_extract
    self.raise_no_formats(reason, expected=True)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 1158, in raise_no_formats
    raise ExtractorError(msg, expected=expected, video_id=video_id)
yt_dlp.utils.ExtractorError: This live event will begin in 48 minutes.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1485, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1561, in __extract_info
    ie_result = ie.extract(url)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 700, in extract
    raise type(e)(e.orig_msg, **kwargs)
yt_dlp.utils.ExtractorError: [youtube] Dv5bNXQzivM: This live event will begin in 48 minutes.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1474, in extract_info
    return self.__extract_info(url, self.get_info_extractor(key), download, extra_info, process)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1485, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1582, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1661, in process_ie_result
    return self.extract_info(
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1474, in extract_info
    return self.__extract_info(url, self.get_info_extractor(key), download, extra_info, process)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1503, in wrapper
    self.report_error(str(e), e.format_traceback())
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1004, in report_error
    self.trouble(f'{self._format_err("ERROR:", self.Styles.ERROR)} {message}', *args, **kwargs)
  File "C:\Users\Wulf\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 944, in trouble
    raise DownloadError(message, exc_info)
yt_dlp.utils.DownloadError: ERROR: [youtube] Dv5bNXQzivM: This live event will begin in 48 minutes.
>>> info
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'info' is not defined
>>>
>>> url = 'https://www.youtube.com/watch?v=Dv5bNXQzivM'
>>> with yt_dlp.YoutubeDL(ydl_opts) as ydl:
...     info = ydl.extract_info(url, download=False)
...
ERROR: [youtube] Dv5bNXQzivM: This live event will begin in 47 minutes.
>>> ydl_opts = {
... 'quiet': True,
... 'cookiefile': 'cookies.txt',
... 'playlist_items': '1',
... 'ignoreerrors': True
... }
>>> with yt_dlp.YoutubeDL(ydl_opts) as ydl:
...     info = ydl.extract_info(url, download=False)
...
ERROR: [youtube] Dv5bNXQzivM: This live event will begin in 47 minutes.
>>> info
>>>

We have to raise error by default in this case in order to preserve backward compatibility with youtube-dl.  Thank you so much for your quick response.


[Feature] Add SMOKE Detector with its Backbone and Neck

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
add SMOKE detector and it's backbone and neck in mmdetection3d
Modification
add SMOKE detector and it's backbone and neck in mmdetection3d
BC-breaking (Optional)
no
Use cases (Optional)
n/a
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

Invite @hhaAndroid to have a review on this PR.

Kindly ping @hhaAndroid & @RangiLyu to see if there are any further comments.