ResourceLoader.load_threaded_get_status(SCENE, PROGRESS) always returns 0 (THREAD_LOAD_INVALID_RESOURCE)

Tested versions

Reproducible in: 4.3.rc3 [03afb92ef]

System information
Ubuntu 22.04.4 LTS - Godot v4.3.rc3
Issue description
I have an addon called Scene Manager and I got an issue about this which made me come here and report the problem after identifying the problem.
In one sentence: ResourceLoader.load_threaded_get_status doesn't seem to work right at all.
Simply define a scene and request to load it with ResourceLoader.load_threaded_request and then ask for how it is doing with ResourceLoader.load_threaded_get_status and it always returns 0 which means THREAD_LOAD_INVALID_RESOURCE but actually when used ResourceLoader.load_threaded_get after you see the THREAD_LOAD_INVALID_RESOURCE, it actually returns the scene just fine but ResourceLoader.load_threaded_get_status said that the scene is not valid which means that it isn't working properly as expected.
Note: This was working completely fine in previous versions of godot4.
Note: Loading normally is fine but loading with ResourceLoading doesn't seem to work at all.
Steps to reproduce
Simply pass a scene address into this function and watch the results:
func load_scene_interactive(_load_scene: String, use_sub_threads = false) -> void:
	ResourceLoader.load_threaded_request(_load_scene, "", use_sub_threads, ResourceLoader.CACHE_MODE_IGNORE)
	var _percent = []
	print("status: ", ResourceLoader.load_threaded_get_status(_load_scene, _percent))
	print("percent: ", _percent)
	print("actual scene: ", ResourceLoader.load_threaded_get(_load_scene))
	print("status: ",ResourceLoader.load_threaded_get_status(_load_scene, _percent))
	print("percent: ", _percent)

You will see this output:
status: 0
percent: [0]
actual scene: <PackedScene#-9223371992663587553>
status: 0
percent: [0]

Which means ResourceLoader.load_threaded_get_status is not working properly at all but actually ResourceLoader.load_threaded_get works just fine although is was said by ResourceLoader.load_threaded_get_status that the scene is not valid and it will not load properly.
What was expected:
status: 1
percent: [0]
actual scene: <PackedScene#-9223371992663587553>
status: 3
percent: [1]

Minimal reproduction project (MRP)
load_threaded_get_status.zip

Testing on Fedora 40.
I can reproduce the 0 status in 4.3.rc3, but not the 1/3 statuses of the "what was expected" in 4.2.2.stable. Could you clarify how you tested previous versions?
In 4.2.2.stable, I get:
status: 1
percent: [0]
actual scene: <PackedScene#-9223372003333897050>
status: 0
percent: [0]

I get the same result with 4.3.beta1.
Then 4.3.beta2 gives:
status: 1
percent: [0]
ERROR: Invalid Task ID
   at: wait_for_task_completion (core/object/worker_thread_pool.cpp:363)
actual scene: <PackedScene#-9223372002310486718>
status: 0
percent: [0]

4.3.beta3 exhibits the behavior described here and still reproducible as of 4.3.rc3:
status: 0
percent: [0]
actual scene: <PackedScene#-9223372003904322285>
status: 0
percent: [0]

And finally the latest master branch at a7a124a57d643103c882a781dfe1f3772363ecc7... segfaults :'(
ERROR: FATAL: Method/function failed.
   at: load_threaded_get_status (./core/io/resource_loader.cpp:586)

Thread 1 "godot-git" received signal SIGILL, Illegal instruction.
0x000000000a90d819 in ResourceLoader::load_threaded_get_status (p_path=..., r_progress=0x7fffffff0b3c) at ./core/io/resource_loader.cpp:586
586                             CRASH_NOW();

(gdb) bt
#0  0x000000000a90d819 in ResourceLoader::load_threaded_get_status (p_path=..., r_progress=0x7fffffff0b3c) at ./core/io/resource_loader.cpp:586
#1  0x000000000a7020ce in core_bind::ResourceLoader::load_threaded_get_status (this=0xb7c2c50, p_path=..., r_progress=...) at ./core/core_bind.cpp:58
#2  0x000000000a7d5cbf in call_with_variant_args_ret_helper<__UnexistingClass, core_bind::ResourceLoader::ThreadLoadStatus, String const&, Array, 0ul, 1ul> (p_instance=0xb7c2c50,
    p_method=(core_bind::ResourceLoader::ThreadLoadStatus (__UnexistingClass::*)(__UnexistingClass * const, const String &, Array)) 0xa70209e <core_bind::ResourceLoader::load_threaded_get_status(String const&, Array)>, p_args=0x7fffffff0c20, r_ret=..., r_error=...) at ./core/variant/binder_common.h:756
#3  0x000000000a7c717f in call_with_variant_args_ret_dv<__UnexistingClass, core_bind::ResourceLoader::ThreadLoadStatus, String const&, Array> (p_instance=0xb7c2c50,
    p_method=(core_bind::ResourceLoader::ThreadLoadStatus (__UnexistingClass::*)(__UnexistingClass * const, const String &, Array)) 0xa70209e <core_bind::ResourceLoader::load_threaded_get_status(String const&, Array)>, p_args=0x7fffffff0da8, p_argcount=2, r_ret=..., r_error=..., default_values=...) at ./core/variant/binder_common.h:535
#4  0x000000000a7ba262 in MethodBindTR<core_bind::ResourceLoader::ThreadLoadStatus, String const&, Array>::call (this=0xb7c34b0, p_object=0xb7c2c50, p_args=0x7fffffff0da8, p_arg_count=2, r_error=...)
    at ./core/object/method_bind.h:524
#5  0x00000000068eefed in GDScriptFunction::call (this=0xdad5260, p_instance=0xdad83f0, p_args=0x7fffffff50c0, p_argcount=1, r_err=..., p_state=0x0) at ./modules/gdscript/gdscript_vm.cpp:1874
#6  0x000000000683f134 in GDScriptInstance::callp (this=0xdad83f0, p_method=..., p_args=0x7fffffff50c0, p_argcount=1, r_error=...) at ./modules/gdscript/gdscript.cpp:2032
#7  0x000000000ad8c91f in Object::callp (this=0xdad0320, p_method=..., p_args=0x7fffffff50c0, p_argcount=1, r_error=...) at ./core/object/object.cpp:786
#8  0x000000000aa676b8 in Variant::callp (this=0x7fffffff5060, p_method=..., p_args=0x7fffffff50c0, p_argcount=1, r_ret=..., r_error=...) at ./core/variant/variant_call.cpp:1211
#9  0x00000000068ee28d in GDScriptFunction::call (this=0xdad90c0, p_instance=0xdad83f0, p_args=0x0, p_argcount=0, r_err=..., p_state=0x0) at ./modules/gdscript/gdscript_vm.cpp:1780
#10 0x000000000683f134 in GDScriptInstance::callp (this=0xdad83f0, p_method=..., p_args=0x0, p_argcount=0, r_error=...) at ./modules/gdscript/gdscript.cpp:2032
#11 0x000000000ad8c91f in Object::callp (this=0xdad0320, p_method=..., p_args=0x0, p_argcount=0, r_error=...) at ./core/object/object.cpp:786
#12 0x000000000aa52f41 in Callable::callp (this=0x7fffffff93b0, p_arguments=0x0, p_argcount=0, r_return_value=..., r_call_error=...) at ./core/variant/callable.cpp:69
#13 0x000000000ad8eac1 in Object::emit_signalp (this=0xdad6f80, p_name=..., p_args=0x0, p_argcount=0) at ./core/object/object.cpp:1187
#14 0x00000000088923a6 in Node::emit_signalp (this=0xdad6f80, p_name=..., p_args=0x0, p_argcount=0) at ./scene/main/node.cpp:3895
#15 0x000000000643f4cb in Object::emit_signal<>(StringName const&) (this=0xdad6f80, p_name=...) at ./core/object/object.h:936
#16 0x00000000089eb026 in BaseButton::on_action_event (this=0xdad6f80, p_event=...) at ./scene/gui/base_button.cpp:185
#17 0x00000000089ea8ff in BaseButton::gui_input (this=0xdad6f80, p_event=...) at ./scene/gui/base_button.cpp:68
#18 0x0000000008a441e5 in Control::_call_gui_input (this=0xdad6f80, p_event=...) at ./scene/gui/control.cpp:1830
#19 0x00000000088aea0b in Viewport::_gui_call_input (this=0xda43880, p_control=0xdad6f80, p_input=...) at ./scene/main/viewport.cpp:1567
#20 0x00000000088afc84 in Viewport::_gui_input_event (this=0xda43880, p_event=...) at ./scene/main/viewport.cpp:1836
#21 0x00000000088b7688 in Viewport::push_input (this=0xda43880, p_event=..., p_local_coords=false) at ./scene/main/viewport.cpp:3258
#22 0x00000000088dd2d5 in Window::_window_input (this=0xda43880, p_ev=...) at ./scene/main/window.cpp:1680
#23 0x00000000089e3f54 in call_with_variant_args_helper<Window, Ref<InputEvent> const&, 0ul> (p_instance=0xda43880,
    p_method=(void (Window::*)(Window * const, const Ref<InputEvent> &)) 0x88dcd7a <Window::_window_input(Ref<InputEvent> const&)>, p_args=0x7fffffffc630, r_error=...) at ./core/variant/binder_common.h:304
#24 0x00000000089c657e in call_with_variant_args<Window, Ref<InputEvent> const&> (p_instance=0xda43880,
    p_method=(void (Window::*)(Window * const, const Ref<InputEvent> &)) 0x88dcd7a <Window::_window_input(Ref<InputEvent> const&)>, p_args=0x7fffffffc630, p_argcount=1, r_error=...)
    at ./core/variant/binder_common.h:418
#25 0x00000000089a4f78 in CallableCustomMethodPointer<Window, Ref<InputEvent> const&>::call (this=0xd9a07e0, p_arguments=0x7fffffffc630, p_argcount=1, r_return_value=..., r_call_error=...)
    at ./core/object/callable_method_pointer.h:103
#26 0x000000000aa52c8d in Callable::callp (this=0x7fffffffc6d0, p_arguments=0x7fffffffc630, p_argcount=1, r_return_value=..., r_call_error=...) at ./core/variant/callable.cpp:57
#27 0x0000000005d163c9 in Callable::call<Ref<InputEvent> > (this=0x7fffffffc6d0) at ./core/variant/variant.h:875
#28 0x0000000005d01d1b in DisplayServerX11::_dispatch_input_event (this=0xbd93ae0, p_event=...) at platform/linuxbsd/x11/display_server_x11.cpp:4063
#29 0x0000000005d01aa5 in DisplayServerX11::_dispatch_input_events (p_event=...) at platform/linuxbsd/x11/display_server_x11.cpp:4039
#30 0x000000000a9ef057 in Input::_parse_input_event_impl (this=0xb5a88e0, p_event=..., p_is_emulated=false) at ./core/input/input.cpp:774
#31 0x000000000a9f03a0 in Input::flush_buffered_events (this=0xb5a88e0) at ./core/input/input.cpp:1055
#32 0x0000000005d06c86 in DisplayServerX11::process_events (this=0xbd93ae0) at platform/linuxbsd/x11/display_server_x11.cpp:5199
#33 0x0000000005cde1b6 in OS_LinuxBSD::run (this=0x7fffffffd090) at platform/linuxbsd/os_linuxbsd.cpp:958
#34 0x0000000005cd69f1 in main (argc=1, argv=0x7fffffffd6f8) at platform/linuxbsd/godot_linuxbsd.cpp:85

Nevermind the crash, it happens only in a DEV_ENABLED build due to this code:
                String local_path = _validate_local_path(p_path);
                if (!thread_load_tasks.has(local_path)) {
#ifdef DEV_ENABLED
                        CRASH_NOW();
#endif
                        // On non-dev, be defensive and at least avoid crashing (at this point at least).
                        return THREAD_LOAD_INVALID_RESOURCE;
                }

So it was trying to catch this kind of error case but it's only evident when running a dev build.
(For the record @RandomShaper I'm still of the opinion that well placed ERR_FAIL_COND_MSG(..., "Bug in ResourceLoader logic, please report.") would be more useful than dev-only asserts that are only useful if contributors end up triggering the edge case.)

I tested #94169 but it doesn't seem to address this issue.

I can reproduce the 0 status in 4.3.rc3, but not the 1/3 statuses of the "what was expected" in 4.2.2.stable. Could you clarify how you tested previous versions?

You are right, sorry I just made a mistake, I got those logs from other situations which... doesn't matter actually.
The state you are seeing is right and in a normal behavior, the status: 3 and percent: [1] is accessible right before you retrieve your scene from ResourceLoader.load_threaded_get, after that you get your scene, you should see status: 0 and percent: [0].
I provide another test here and write how it should act:
load_threaded_get_status_2.zip
Expected logs:
*** load started ***

stating values:
status: 1
percent: [0]
=========================
*** In _process ***
status: 3
percent: [1]
actual scene: <PackedScene#-9223372005481380632>
*** load finished ***

=========================
status: 0
percent: [0]

Received Logs:
*** load started ***

stating values:
status: 0
percent: [0]
=========================
*** In _process ***
status: 0
percent: [0]
*** In _process ***
status: 0
percent: [0]
*** In _process ***
status: 0
percent: [0]
.
.
.

It goes into a loop because it never actually sees the status = 3 and so it never loads the scene.

Thanks, I can reproduce these results with the new MRP. I'll bisect so we can pinpoint when the regression happened exactly.

This seems to be the correct behavior since the cache mode is set to ignore, which means it doesn't get registered by the task map. Before the aforementioned commit the task would be incorrectly registered on the task map, so it looks like a compatibility issue.


Additional try/catch blocks around async waitUntil calls

R: @philipwalton
Fixes #1435
This is analogous to the change in #1392. I've gone through all the other strategies that might call event.waitUntil() asynchronously, and added the same change there.

Coverage decreased (-0.2%) to 87.057% when pulling f3de7c86ed027e5e71ecee6b567659a64f176081 on async-waituntil-fixes into 77b64a7b956aad7c1627aa5e4b3c3d8f48c36c43 on master.


v1.11.0 assetlinks.json not generated bybubblewrap build and bubblewrap fingerprint generateAssetLinks is empty

Describe the bug
Per the Quick Start Guide, an assetlinks.json should be generated when I run bubblewrap build but this seems to only be the case in v1.10.0 AND when I use the new fingerprint command, the file is empty (I think because it imports and maps over the empty fingerprints key in the generated twa-manifest.json).
To Reproduce
Steps to reproduce the behavior:

npm install<EMAIL_ADDRESS>npx bubblewrap init --manifest=https://slate.com/media/sites/slate-com/web-app-manifest.json
press enter at all prompts
npx bubblewrap build --skipPwaValidation
Note that there is not assetlinks.json file generated nor a message about it
npx bubblewrap fingerprint generateAssetLinks
Note that assetlinks.json is empty

Expected behavior
npx bubblewrap fingerprint generateAssetLinks should generate an assetlinks.json file with content similar to v1.10.0 e.g.
[{
        "relation": ["delegate_permission/common.handle_all_urls"],
        "target" : { "namespace": "android_app", "package_name": "com.slate.twa",
                     "sha256_cert_fingerprints": ["B8:C8:22:AF:6C:D2:5B:7A:68:F4:2D:F8:BB:D8:F5:10:21:21:E4:69:E2:5A:FA:79:0C:EA:2D:C2:69:4D:FF:19"] }
      }
]

Additional context
When I install v1.10.0, its bubblewrap build generates the assetlinks.json file, so this error seems likely related to addition of the fingerprint command in #478. Note also that #478 assume that there will be something in the fingerprints array of the twa-manifest.json file, but that when I do a bubblewrap init for my manifest that array is empty in twa-manifest.json. Both v1.10.0 and v1.11.1 generate the empty fingerprints array "fingerprints": [], - but only v1.11.1 seems to rely on it being populated with the fingerprint command. Did I miss something?
Desktop (please complete the following information):

OS: MacOS
Browser n/a
Version v.1.11.1

Thanks for filing this, @elgreg.
Generating fingerprint from the key generated by Bubblewrap was removed. The reason for the change is that most developers use (and they should be using) Play App Signing when upload the app to the Play Store and the default assetlinks.json generated by Bubblewrap was incorrect in most cases.
We may want to reinstate that, since that key can be used for debugging locally.

Thanks @andreban - I'm using an existing keystore during the --init and trying to debug in our local, dev, and stage environments before going to production. What would you recommend for correctly generating an assetlinks.json file? Just using v1.10.0 for now...

This video has information around this.

Thanks! The video refers to a section of the portal called "App signing"
which I didn't see. I was able to find the sha-256 under "App integrity"
and I will look into that now. I should have found it but definitely
watched the video the first time and searched for it in the cmd-F and
didn't see it and assumed it was something to do with the app being removed.
[image: Image 2021-03-22 21-45-28.png]
On Fri, Mar 19, 2021 at 10:52 AM André Cipriani Bandarra <
@.***> wrote:

This video https://www.youtube.com/watch?v=3bAQPnxLd4c has information
around this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChromeLabs/bubblewrap/issues/486#issuecomment-802890403,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAJ6RBRCXU7T5PQAN5NTXDTENQJZANCNFSM4ZJUB2FA
.

bubblewrap build not generated assetlinks.json for me too! And WTF?

@devalexqt Yup. Per comment from @andreban  "Generating fingerprint from the key generated by Bubblewrap was removed."
You can figure out the sha256 by yourself for a keystore using keytool -list -v. Here's an example or the default android debug keystore that's probably in your home directory:
keytool -list -v -keystore ~/.android/debug.keystore -alias androiddebugkey -storepass android -keypass android
Then you can copy and paste the sha256 out of that into an assetlinks.json file tha thas the right package_name:
        "relation": ["delegate_permission/common.handle_all_urls"],
        "target" : { "namespace": "android_app", "package_name": "[your pacakage name e.g. com.stuff.app]",
                     "sha256_cert_fingerprints": ["the sha256"] }
      }

@devalexqt please, read this comment which explains why it was removed. Also, please do observe our code of conduct.

Thanks for reply, I make TWA for first time and was little bit confused. But now I understand this situation. PS: Thanks for bundler, it's fast and really easy to use!

Thanks for filing this, @elgreg.
Generating fingerprint from the key generated by Bubblewrap was removed. The reason for the change is that most developers use (and they should be using) Play App Signing when upload the app to the Play Store and the default assetlinks.json generated by Bubblewrap was incorrect in most cases.
We may want to reinstate that, since that key can be used for debugging locally.

@andreban, based on what I read, we should reconsider updating https://developer.chrome.com/docs/android/trusted-web-activity/quick-start/#creating-your-asset-link-file. Since I am new and looking for first hand information, I relied on this web page and did not see assetlinks.json being created.
It's only when I hunted down I came to this GitHub issue. As I understand now, I must use https://developer.chrome.com/docs/android/trusted-web-activity/quick-start/#play-store-signing for generating assetlinks.json. Please correct me if I am wrong here. Thanks

@andreban do you think someone could update https://developer.chrome.com/docs/android/trusted-web-activity/quick-start/#creating-your-asset-link-file then? Very confusing that the guide says to use a feature that was removed.


there is no sys.stdout.encoding when piped or frozen

sometimes sys.stdout.encoding is None (eg. when piped or when frozen with pyinstaller). in such case pressing any key crashes app.

@matham @mahomahomaho what about:
if hasattr(sys.stdout, 'encoding'):
    encoding = sys.stdout.encoding
else:
    encoding = 'utf8'

ref #5043

It won't work in my case, because sys.stdout has attribute 'encoding', but it's None


Custom Section as default

Hi!
I want to put my winbar right aligned. is there a way that I can get the winbar created but put it in the custom section?

Hello. Can you explain more how the winbar should be right aligned?
However from my understanding you want something like this:
my_custom_section                 3rd nesting < 2nd nesting < 1st nesting < filename

Right?


fix Issue 15027 – rangified functions no longer work with string-like types

Issue 15027 – rangified functions no longer work with alias this'ed strings (e.g. DirEntry)

I went with fully supporting (and documenting) string-like types for any rangified functions.
That seemed more consistent than to just fix old functions for backwards compatibility.

@rainers @DmitryOlshansky @burner

Wow, what a feat.
Looks good to me for most of it, but some constraints are difficult to verify. Can you elaborate why adding isNarrowString was necessary sometimes?
I also just noticed that rangification also changed behaviour for structs that satisfy range constraints, but also alias this to a string type. These are restored with the isStringLike check, but is this actually desired?

Can you elaborate why adding isNarrowString was necessary sometimes?

I tried to consolidate all the different constraint variations, and dstring doesn't need to be handled separately b/c it already offers random access et.al. It also seems that isSomeString is slightly more expensive for the compiler to compute than isNarrowString.

I also just noticed that rangification also changed behaviour for structs that satisfy range constraints, but also alias this to a string type. These are restored with the isStringLike check, but is this actually desired?

This was done on purpose b/c isInputRange is true for structs w/ alias this string, and we don't want the possibly expensive copy in that case.
And I'd call a struct that offers a stringish range interface and still aliases to a string illformed b/c it effectively offers two range interfaces, any practically relevant example?

I thought it was only theoretically, but just grepped phobos and e.g. takeExactly returns a range that aliases this to another range. Not sure if this could trigger the change, though.

takeExactly returns a range that aliases this to another range.

It aliases to Take!N which is just a variant of takeExactly.

It doesn't work for writeln as well, so I don't think anyone is relying on that for strings.
http://dpaste.dzfl.pl/15e976628ebe

Passes now, and nothing left to do.

I have written a note to<EMAIL_ADDRESS>which I think is important enough to paste here as well:
Hi folks, isStringLike is a fine idea but there are a number of issues I noticed while looking at the PR and the related pieces it works with.

isAggregate is not the best choice of names for something that's a struct, class, union, or interface. In C++ aggregates are a completely different notion (http://stackoverflow.com/questions/4178175/what-are-aggregates-and-pods-and-how-why-are-they-special) so essentially we're defining our own terminology. Not the best thing to do. Closest term I can think of is isUserDefinedType, but that would include enumerated types.

The larger question is why this peculiar notion is needed strongly enough to get its own name.

I take issue with the current definition of isStringLike, which is:

(isAggregateType!T || isStaticArray!T) && is(StringTypeOf!T);
So... a string is unlike a string, which I find unfitting. Furthermore, the entire notion of isStringLike and StringTypeOf is dedicated to work around what seems to be a bug in the typesystem (alias this fails to implement real subtyping). It seems that is the right place to focus work on.
A worse problem is that isStringLike fails to capture the more frequent "string-like" structure: (a) lazy ranges of characters and (b) reference counted strings. These are crucial pieces. So we're not making progress toward actually defining what we think a string-like data structure is.
I think a string-like structure is:
(a) an array of characters or a subtype thereof
(b) some other forward range with ElementType some character type, and potentially ElementEncodingType a different character type as well.
That's pretty much it. Algorithms dealing with string-like data should be able to work with this definition, or temporarily convert to arrays of characters.
More importantly, while looking at https://github.com/D-Programming-Language/phobos/pull/3770/ and related work I can't stop noticing a growth of layers of complexity that seems poorly scalable, instead of an increase in generic simplicity and clarity of concepts. That does not bode well and we need to curb it lest we end up with a standard library we ourselves can't make sense of.
I do understand there are issues to fix and we need to move forward. But tactical solutions cannot substitute a lack of strategy.
Please let us all stop and draw a little breath, and figure out how to replace the monumental work in PR 3770 with simplifying abstractions. Once something like isStringLike becomes part of Phobos, we're stuck with it for eternity - there's no way we can fix it without breaking code.
I don't have the bandwidth to scrutinize all Phobos changes and at the same time work on refcounted safe collections (my focus). But please keep me informed of all public name additions to Phobos, and also discuss them in the forum. If we keep on introducing new notions at this pace, we'll drown Phobos in its own attempts at being rigorous.

To clarify: I'm opposed to deploying a release with this solution.

The name and concept string-like are not the best fix but we need a workaround for type deduction deficiencies (and fixing that is completely out of scope for the overdue 2.069.0).

More importantly, while looking at #3770 and related work I can't stop noticing a growth of layers of complexity that seems poorly scalable, instead of an increase in generic simplicity and clarity of concepts.

I think everybody agrees that this is an ugly workaround and we want something like foo(R : isInputRange)(R range) to become part of the type deduction. Meanwhile we cannot break most of std.{file,path,string} with the next release.
Maybe the solution is as simple as leaving isStringLike as internal helper and undocumenting the overloads?

I do understand there are issues to fix and we need to move forward. But tactical solutions cannot substitute a lack of strategy.

Unfortunately this problem was ignored for several month and is now blocking the release.

Maybe the solution is as simple as leaving isStringLike as internal helper and undocumenting the overloads?

Yes, that seems a prudent path to follow for the time being. Thanks!

see #3774


do not encrypt the metadata file for local-tar

I will try work on getting the test failures fixed, as soon as I understand why the tests failed :-)


There is no SDK auto generation for JS, Java, Python and Go in mgmt. SDK apps

I believe most of the SDK could achieve auto generation of the SDK  and we already achieved that for DPG so I don't think moving to powerApps, SDK owners still need to generate the SDK PR manually themselves.
Expected:  All SDK should be auto generated for JS, Java, Python and Go (probably Java has some challenges.), SDK owners and service team just need to verify the generated code.

Cadl + DPG flow would auto generate the initial version of the SDK and ask service team to add test & samples.
Seems current design is to use a different flow for mgmt. SDK in PowerApps.

Current design of mgmt powerapps keeps the original way of working. (For js, java, go and python, sdk owners generate sdk pr by themselves.)
I think we can have a discussion about it, and collect feedbacks from sdk owners and service team (if possible), then decide whether we need to make it consistent with CADL+DPG flow to generate codes automatically.
cc: @josefree

When we start onboarding service partner to use for management plane, I will get user feedback.  The topic came up in the user studies with stakeholders for Cadl + DPG.

@dw511214992 @lirenhe do you know what is the reason behind this discrepancy? From a tooling perspective, what will be the implications if we automate this step to provide same experience as in data plane?

@dw511214992 @lirenhe do you know what is the reason behind this discrepancy? From a tooling perspective, what will be the implications if we automate this step to provide same experience as in data plane?

Currently, Azure SDK team is the owner of the mgmt. SDK release while for DPG, service team are the owner of their SDK release.  In tooling, we should provide better automation for mgmt. SDK release, including auto gen, auto testing & release.

We have removed all automation from the SDK apps, so this issue is no longer valid.


No Detailed Steps to address how to make it work with K8S

I installed k8s 1.5.7 with Flannel installed ， and then installed weave on this Env as well . I followed the "GettingStarted.md" to install Genie . And then made the following changes on my env

I changed kubelet parameters with the following items added ( --network-plugin-dir=cni --network-plugin-dir=/etc/cni/net.d --cni-bin-dir=/opt/cni/bin)  and then restart kubelet service .
I checked the following directory

[root@mscp3 net.d]# ls
00-genie.conf  10-calico.conf  10-weave.conf  calico-kubeconfig  calico-tls  genie-kubeconfig
[root@mscp3 bin]# ls
bridge  calico  calico-ipam  dhcp  flannel  genie  host-local  ipvlan  loopback  macvlan  portmap  ptp  sample  tuning  vlan  weave-ipam  weave-net  weave-plugin-2.0.1
[root@mscp3 bin]#

I just run the sample yaml file provided by Genie as following

apiVersion: v1
kind: Pod
metadata:
name: tomcat-weave1
labels:
app: web
annotations:
cni: "weave"
spec:
containers:
- name: key-value-store
image: tomcat:latest
imagePullPolicy: IfNotPresent
ports:
- containerPort: 8080

After running kubectl create -f ..yaml  , I got the ip from Flannel assigned . So it looks the Genie is not working well .

So based on my description , do you have any suggestion how to make it work , and how to debug the issues . thanks .

@hanpenghero

if you deploy a cluster using 'kubeadm' as per "GettingStarted.md", you don't need to manually change kubelet parameters. In other words, please use:
$ kubeadm init --use-kubernetes-version=v1.5.8-beta.0 --pod-network-cidr=<IP_ADDRESS>/16
This makes sure 'kubelet', 'kubeadm', 'kubectl', 'kubernetes-cni' versions are ALL consistent. You will have:

this looks fine!

I used the yaml you provided to create the pod:

Note that when I look at the logs, this is what I see:

Let's chat on CNI-Genie Slack channel, https://cni-genie.slack.com, and I can walk you through the steps if the above instructions does not help. Also, please have a second look at the GettingStarted page. I added more details.

@kshafiee
Thank u so much for your help on this . BTW can u send me an invitation for joining your group on Slack ? thanks again . Also I am rebuilding all the source code downloaded from Genie-CNI and see whether there is anything wrong with my Env .

@kshafiee @hanpenghero
Can we close this thread if addressed?

@hanpenghero feel free to re-open if you are still having any issues with the set-up.


[MM-20533] Migrate "RhsHeaderPost" component to TypeScript

Summary
Migrates components/rhs_header_post module to TypesScript.
Ticket Link
Jira: https://mattermost.atlassian.net/browse/MM-20533
Fixes https://github.com/mattermost/mattermost-server/issues/13708

Looks good overall, just a couple changes to make.
Thanks very much for your PR @utkuufuk :)

@devinbinnie I've addressed your comments, thanks for reviewing 🙂


INVALID_CLIENT error while using first_auth.js

Was fixed by adding the redirect uri http://localhost:8888/callback in the spotify developer portal for the app. This should probably be mentioned in the installation guide :)

You should probably read the installation guide first, then you will notice that it is mentioned there ;)

My apologies, must have missed that :)


New website

This PR tracks the creation of the new website.

Looks good. Merging this in so others can build off this in main branch.

The only problem i see is we are tracking node_modules as well,  so the diffs will be large when modules are updated.  A commit in the blog-dev branch fixes this problem.  Will create a pr soon with that fix.


Question about Training

Hi, I try to training my coco style dataset by your scripts, I dont know which bash script should be used to train.(Could you please briefly explain the function of each script?)  Then I use "scripts/train/lambda/coco/train.sh" this one for training. but one error happened.
cd /data_2/lutianhao/code/MIPNet/
CUDA_VISIBLE_DEVICES=4,5,6,7, python tools/lambda/train_lambda_real.py
--cfg experiments/coco/hrnet/w48_384x288_adam_lr1e-3.yaml
GPUS '(0,1,2,3,)'
OUTPUT_DIR 'Outputs/outputs/lambda/lambda_coco_real_waffle'
LOG_DIR 'Outputs/logs/lambda/lambda_coco_real_waffle'
TEST.MODEL_FILE 'models/pytorch/pose_coco/pose_hrnet_w48_384x288.pth'
DATASET.TRAIN_DATASET 'coco_lambda'
DATASET.TRAIN_SET 'train2017'
DATASET.TRAIN_IMAGE_DIR '/data_2/lutianhao/datasets/pose/coco2017/train2017'
DATASET.TRAIN_ANNOTATION_FILE '/data_2/lutianhao/datasets/pose/coco2017/annotations/person_keypoints_train2017.json'
DATASET.TRAIN_DATASET_TYPE 'coco_lambda'
DATASET.TEST_DATASET 'coco'
DATASET.TEST_SET 'val2017'
DATASET.TEST_IMAGE_DIR '/data_2/lutianhao/datasets/pose/coco2017/val2017'
DATASET.TEST_ANNOTATION_FILE '/data_2/lutianhao/datasets/pose/coco2017/annotations/person_keypoints_val2017.json'
DATASET.TEST_DATASET_TYPE 'coco'
TRAIN.LR 0.001
TRAIN.BEGIN_EPOCH 0
TRAIN.END_EPOCH 110
TRAIN.LR_STEP '(70, 100)'
TRAIN.BATCH_SIZE_PER_GPU 2
TEST.BATCH_SIZE_PER_GPU 1
TEST.USE_GT_BBOX True
EPOCH_EVAL_FREQ 1
PRINT_FREQ 100
MODEL.NAME 'pose_hrnet_se_lambda'
MODEL.SE_MODULES '[False, False, True, True]'
And the error is :
GAMMA1: 0.99                                                                                [0/927]
GAMMA2: 0.0
LR: 0.001
LR_FACTOR: 0.1
LR_STEP: [70, 100]
MOMENTUM: 0.9
NESTEROV: False
OPTIMIZER: adam
RESUME: False
SHUFFLE: True
WD: 0.0001
WORKERS: 24
=> init weights from normal distribution
=> loading pretrained model models/pytorch/imagenet/hrnet_w48-8ef0771d.pth
Total Parameters: 63,746,081
Total Multiply Adds (For Convolution and Linear Layers only): 46.562052726745605 GFLOPs
Number of Layers
Conv2d : 293 layers   BatchNorm2d : 292 layers   ReLU : 271 layers   Bottleneck : 4 layers   BasicBlock : 104 layers   Upsample : 28 layers   HighResolutionModule : 8 layers   AdaptiveAvgPool2d : 5 l
ayers   Linear : 20 layers   Sigmoid : 10 layers   BatchNorm1d : 5 layers   SELambdaLayer : 5 layers   SELambdaModule : 2 layers
=> loading model from models/pytorch/pose_coco/pose_hrnet_w48_384x288.pth
=> loading from latest_state_dict at models/pytorch/pose_coco/pose_hrnet_w48_384x288.pth
loading annotations into memory...
Done (t=31.87s)
creating index...
index created!
=> classes: ['background', 'person']
=> num_images: 118287
loading from cache from cache/coco_lambda/train2017/gt_db.pkl
done!
=> load 149813 samples
loading annotations into memory...
Done (t=4.04s)
creating index...
index created!
=> classes: ['background', 'person']
=> num_images: 5000
=> load 6352 samples
=> resuming optimizer from models/pytorch/pose_coco/pose_hrnet_w48_384x288.pth
=> updated lr schedule is [70, 100]
training on lambda
Epoch: [0][0/18727]     Time 64.338s (64.338s)  Speed 0.2 samples/s     Data 10.114s (10.114s)  Loss 0.00020 (0.00020)     Accuracy 0.513 (0.513)  model_grad 0.000568 (0.000568)  DivLoss -0.00074 (-0.00074)        PoseLoss 0.00020 (0.00020)
Traceback (most recent call last):
File "tools/lambda/train_lambda_real.py", line 280, in
main()
File "tools/lambda/train_lambda_real.py", line 242, in main
final_output_dir, tb_log_dir, writer_dict, print_prefix='lambda')
File "/data_2/lutianhao/code/MIPNet/tools/lambda/../../lib/core/train.py", line 464, in train_lambda
suffix += '_[{}:{}]'.format(count, round(lambda_a[count + B].item(), 2))
IndexError: index 16 is out of bounds for dimension 0 with size 16

I've solved this error, but I'd like to know the mean of "size=16", would you please explain a few? Thanks!

Glad the error is resolved.
The size of 16 is to visualize the samples during training, https://github.com/rawalkhirodkar/MIPNet/blob/505c92ec59ac79686a217dac45eb188fc38b8499/lib/core/train.py#L464
It looks like the error was due to having a batch size that was less than 16, in that case, you can update this constant to something smaller.


Create a post for 100+ stars on official django india repository

fork repo

Create a new folder under the graphics and desgin folder with the name as your github username.
upload the post inside that folder with name as issue_number.jpg. If there are multiple files then append one incremental number after file name.
create a PR

I want to work on this


Save json data to default value in json schema

Hello,
When you generate a schema based on a  json, is it possible to save the values of my json inside the default value in the json schema ?

I am also interested in an answer to the above question.

Hi @samyfox  , @ashnur  .
Please use this.
generate-schema -j  C:\PATH\FOR\YOUR\JSON.txt > output.txt
refer https://helpdeskgeek.com/how-to/redirect-output-from-command-line-to-text-file/

@sorariver generate-schema -j didn't include any defaults for me...


[SPARK-17281][ML][MLLib] Add treeAggregateDepth parameter for AFTSurvivalRegression

What changes were proposed in this pull request?
Add treeAggregateDepth parameter for AFTSurvivalRegression.
How was this patch tested?
Existing tests.

cc @yanboliang

Test build #64536 has started for PR 14851 at commit 7ef9d8b.

Test build #64536 has finished for PR 14851 at commit 7ef9d8b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64536/
Test FAILed.

Test build #64542 has started for PR 14851 at commit 2eafb77.

Test build #64542 has finished for PR 14851 at commit 2eafb77.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64542/
Test PASSed.

cc @jkbradley thanks!

cc @srowen thanks!

Test build #65722 has started for PR 14851 at commit ae37bfd.

Test build #65722 has finished for PR 14851 at commit ae37bfd.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65722/
Test FAILed.

Test build #65753 has started for PR 14851 at commit 378079d.

Test build #65753 has finished for PR 14851 at commit 378079d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65753/
Test PASSed.

LGTM, merged into master. Thanks!


NETOBSERV-939: Detect which dashboards to show based on ocp version

This PR is based on https://github.com/netobserv/network-observability-operator/pull/386 - merge it first
Related console-plugin PR: - to come -
Based on OCP version, the console plugin reconciler will configure a
list of dashboard names that are available, so the the plugin will
create links for them

Read & compare versions
Some refactoring:

Permission vendor detection and Available API detection were two
mechanisms very similar: merge Permission vendor detection in
Available APIs
Reading cluster info (id, version) can also considered as part of the discovery
mechanism: merge them all in a new ClusterInfo structure, that
provides the ClusterVersion stuff and the available APIs

@jpinsonneau 90498ef => better like that?

closing this old PR as it's not clear how we want the dashboard list displayed, and it's quite outdated now .. it's simpler to restart from scratch when needed
I'm extracting the part about discovering ocp version here: https://github.com/netobserv/network-observability-operator/pull/817


add speedb is awesome example to support new getting started instruct…

…ions(#378)

@RoyBenMoshe - Please sqaush the commits into a single commit and insert a space before the (#378):
instructions(#378)
Thanks


Fix GuiSlider value pointer

GuiSlider() takes a float *, so we must retrieve the address of value, rather than just passing it in.

I'm reviewing it...


[columnar] HYD-760 Serialization fails to copy data

When we are building chunk for serialization if serialzation memory is higher than 256MB, memcpy_s function (safeclib) will not copy anything (there is memory size check). Fixed by using memcpy. We have allocated already memory with required size so it should be safe to copy it.

this is included in #222


'TimeLimit' object has no attribute 'ale' Error

Hi, this error occurs when I try to run the demo of Breakout-v0.
And, I have install gym[atari] and can make the environment 'Breakout-v0', however, this env has no 'ale' attribute to get the current lives.

Have been solved by

reinstall gym in anaconda.
OR
unwrapped the env to get the 'ale' attribute.


TUI does not display after running script

Able to run the script w/ debug turned on. The TUI does not display. Discord client window is open and does not respond to script. Verified that everything was input properly from user_token to channel ID.  Debug displays no errors.
*Running w/ CMD on windows 10, Python version 3.12+
*Tried changing python version to 3.10.6 but still won't work
*Using windows-curses 2.3.2

Running w/ CMD on windows 10, Python version 3.12+

Tried changing python version to 3.10.6 but still won't work

Try #125 solution please.

Try #125 solution please.

I've used Python 3.10.6
Should I use an older version than that?

I really can't say, I don't use Windows but is by far the most annoying place to use curses library, unknown problems all the time, depending on the current win-update build. Try using a console emulator like ConEmu (https://conemu.github.io/)


feat: add support for unknown in typescript

Adds support for unknown (and it's flow equivalent) in TypeScript.
First PR and I made this constribution mostly via the GitHub UI, happy to do more if needed!
Closes #1619

Awesome! Please add an option for this in the typescript test fixture.

Check the README for details. You want quicktestRenderSettings or some such name.

https://github.com/quicktype/quicktype/blob/master/test/languages.ts#L694 it looks like?

Yup that was it. Actually found an unrelated bug, but icing this PR for a second. The source uses "any" as a catchall in a number of places where a more specific type (Record<key, unknown>, IConvertable) would make more sense which means a decent size chunk-o-changes will likely need to be made to the JavaScript output to emit the correct and specific types.

@RichiCoder1 are there any plans to move forward with this PR?


Release/v0.23.1 bookkeeping

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #123   +/-   ##
=========================================
  Coverage     98.90%   98.90%
  Complexity     1296     1296
=========================================
  Files            74       74
  Lines          3095     3095
  Branches        422      422
=========================================
  Hits           3061     3061
  Misses           19       19
  Partials         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602eadd...53ca490. Read the comment docs.


Remove unused variables

These have been found using gulp lint in combination with the unused: true parameter for JSHint. Unfortunately there are too many false positives to enable this feature, but now that most globals have been removed because of the conversion to UMD the results are much more useful than before.

/botio-linux preview

/botio test

r=me, feel free to land this once you've made a decision on https://github.com/mozilla/pdf.js/pull/7316#discussion_r63415651.


Version manipulation tools update documentation

incrementing should:

add an entry to the appropriate changelog file

set version should:

update the version entry in the changelog file (i.e. from "1.2.3b1" to "1.2.3" in preparation for release)

We should also come up with a strategy for updating documentation. Current documentation PyPI links seem to follow this standard:

If the package has a previous GA version whose major version is behind the current version: link directly to the current preview version
If the package has not previously released GA: link to the package, the version number is not necessary

Version increment should use " instead of ' to mention version

For the PyPI documentation piece of this:
Update the "Package (PyPi)" link in the README.md
Example with previous GA here... note the link directly points to the 5.0.0b6 version because if we did not point directly to that version a consumer of the README docs would land on the 1.3.3 version.
Example with no previous GA: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault/azure-keyvault-keys ... Note the PyPI link does not point to a version.
Also, we should probably ensure that the spelling of Package (PyPI) is consistent everywhere because it is different between event hubs and key vault.


OnClick PhotoItem always opens the first photo

Hi,
Thanks for the nice wrapper! Good work!
For me it looks like the first photo in the gallery is always opened, even if I make onClick event to some other photo. I tested also on the example, and the same problem there.

@vhelke Thank you for your issue. I fixing it right now.

@vhelke This bug was fixed in 0.9.0 version


Change accessibility identifiers

Description

Fix identity identifier

Testing

[ ] Added unit tests
[ ] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

Code coverage
Total coverage: 95.13%

Powered by Slather

  Generated by :no_entry_sign: Danger


Orchestrator should be up and running without argo-cd

Summary
Orchestrator should be running up without having any argocd infra setup.
Motivation
Remove dependencies of argocd in case of no-gitops.
Proposal
Remove the redundant client initialisation in case of no gitops or base infra setup from orchestrator codebase.

closed in #2293


[LAB-336] API reference for pip pkg

Currently we include notebook tutorials in our docs to demonstrate how users can interact with the plex pip package. However, we lack an API reference section which outlines which functions are available and the arguments they accept.
Given the pip pkg is still changing, we should aim for an MVP API reference section which outlines the "core" functions.

[ ] draft api reference section
[ ] propose changes to current pip function specs
[ ] implement above changes
[ ] update public-facing notebooks
[ ] push changes to docs

From SyncLinear.com | LAB-336

V2:
https://www.notion.so/labdao/6ebc9b59e0d74eeabb391d624f500424?v=2540e4f2e24f4ae597f624d30c7f1068&p=5a7284921c7c4e9692e4ea6d0e3d1922&pm=s

@NiklasTR updated api reference here: https://docs-git-552-lab-336-api-reference-for-pip-pkg-labdao.vercel.app/reference/python


Increase test coverage in operator/pkg/version

--
I wanted to contribute back to Istio for the first time, and picked up relatively easy looking issue. I increased the test coverage from 59.8% to 96.7% on operator/pkg/version without touching the main source file at all.
I could not achieve 100% coverage, with the following lines missing coverage:

line#134 seems to be duplicate error check from line#125
line#284 - couldn't figure how to get error from vfs.ReadFile
line#289 - couldn't figure how to test against unmarshal error
line#323 - could be done by providing a real uri, but that probably won't work on CI env

Apologies how it's all over the place, and I'm sure there are some incorrect approaches to other tests as well. Some feedback will be really appreciated!
--
Updates #21886

Hi @rytswd. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rytswd: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2c9ac7e5ea61591b3a0d8442ddd8cbf8884a52a4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for the comment and clarification @dgn! I'd leave the PR as is in that case.
As to the linked issue, should I re-phrase to get it fixed upon merge?

As to the linked issue, should I re-phrase to get it fixed upon merge?

You can - maybe you're quick enough ;) Otherwise I'll just close it when this is merged

Seems I wasn't quick enough ;-) Thanks very much for your support!


[SPARK-40540][SQL] Migrate compilation errors onto error classes: _LEGACY_ERROR_TEMP_1300-1347

What changes were proposed in this pull request?
In the PR, I propose to migrate 48 compilation errors onto temporary error classes with the prefix _LEGACY_ERROR_TEMP_13xx. The error message will not include the error classes, so, in this way we will preserve the existing behaviour.
Why are the changes needed?
The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes. After that we could prioritise the work on migration.
The new error class name prefix _LEGACY_ERROR_TEMP_ proposed here kind of marks the error as developer-facing, not user-facing. Developers can still get the error class programmatically via the SparkThrowable interface, so that they can build error infra with it. End users won't see the error class in the message. This allows us to do the error migration very quickly, and we can refine the error classes and mark them as user-facing later (naming them properly, adding tests, etc.).
Does this PR introduce any user-facing change?
No. The error messages should be almost the same by default.
How was this patch tested?
By running the modified test suites:
$ build/sbt "core/testOnly *SparkThrowableSuite"
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt "test:testOnly *SQLQuerySuite"
$ build/sbt "test:testOnly *BucketedWriteWithoutHiveSupportSuite"
$ build/sbt "test:testOnly *TimeWindowSuite"

cc @srielau @anchovYu @itholic

Thanks, merging to master


to change quandlget() to accept any AbstractString, and not only ASCIIString.

After some discussions at julia-users list (https://groups.google.com/forum/#!topic/julia-users/_J9-6CeACW8) I was suggested to create this issue.
I am using the function quandlget(id::ASCIIString) and everything works fine when I use it in a straightforward way:
julia> mydat = quandl("GOOG/NASDAQ_GOOG",rows=100,format="DataFrame")
100x6 DataFrames.DataFrame

Row
Date
Open
High
Low
Close
Volume

1
2015-07-08
521.05
522.73
516.11
516.83
1.2967e6

2
2015-07-09
523.12
523.77
520.35
520.68
1.84235e6

3
2015-07-10
526.29
532.56
525.55
530.13
1.95668e6

or when I do:
julia> myid = "GOOG/NASDAQ_GOOG"
"GOOG/NASDAQ_GOOG"
julia> typeof(myid)
ASCIIString
julia> mydat = quandl(myid,rows=100,format="DataFrame")
100x6 DataFrames.DataFrame

Row
Date
Open
High
Low
Close
Volume

1
2015-07-08
521.05
522.73
516.11
516.83
1.2967e6

2
2015-07-09
523.12
523.77
520.35
520.68
1.84235e6

3
2015-07-10
526.29
532.56
525.55
530.13
1.95668e6

However, I get an error when I read my data from an external file. Assume I have an ascii file containing only one line:
$ echo "GOOG/NASDAQ_GOOG" > portfolio.txt
$ cat portfolio.txt
GOOG/NASDAQ_GOOG
I just read the content of this file by using readdlm and try to use it to call the same function quandl, but it does not work.
julia> myportfolio = readdlm("./portfolio.txt",'\n')
1x1 Array{Any,2}:
"GOOG/NASDAQ_GOOG"
julia> typeof(myportfolio[1])
SubString{ASCIIString}
julia> mydat = quandl(myportfolio[1],rows=100,format="DataFrame")
ERROR: MethodError: quandlget has no method matching quandlget(::SubString{ASCIIString})
The easiest way I found to solve this problem was to call a "cast" of myportfolio[1] to ASCIIString, like this:
julia> mydat = quandl(ASCIIString
(myportfolio[1]),rows=100,format="DataFrame")
WARNING: deprecated syntax "ASCIIString (".
Use "ASCIIString(" instead.
100x6 DataFrames.DataFrame

Row
Date
Open
High
Low
Close
Volume

1
2015-07-09
523.12
523.77
520.35
520.68
1.84235e6

2
2015-07-10
526.29
532.56
525.55
530.13
1.95668e6

3
2015-07-13
532.88
547.11
532.4
546.55
2.20648e6

However, I think a good solution could be to change the quandl function to accept any AbstracStstring, and not only ASCIIString as a parameter. Would it be possible?
Thanks!

Did you try it to see if it works yet?

Yeah, it works. I'll change this.


Style updates

Description
Updated the bugsplat module with the following:

adhere to python naming conventions,
use type annotations
use logger instead of print

Checklist

[x] Tested manually
[x] Unit tests pass with no errors or warnings
[x] Documentation updated (if applicable)
[ ] Reviewed by at least 1 other contributor

Looks great, thanks for the contribution @zmrl010 !!!


the default operator means kube-system namespace? if i set the other namespace, the operator whether watch all namespaces?

the default operator means kube-system namespace? if i set the other namespace, the operator whether watch all namespaces?
Originally posted by @SalleryWang in https://github.com/Altinity/clickhouse-operator/issues/388#issuecomment-630765143

@Slach

by default operator watch all namespaces


Having trouble with custom BuildPlatforms with custom properties

Hi,
A long while ago, I came across the problem of creating BuildPlatforms for consoles: https://github.com/superunitybuild/buildtool/issues/90
I was able to create my own, but now that I'm knee-deep in development, I've noticed some issues.
Some platforms have custom options that appear in the Build Settings window, like whether to create an installable ROM or a different type of output. I think it would be easier to implement these if BuildPlatform's Draw() method was virtual, right?
In my BuildSwitch script, I have a separate method that draws these extra PropertyFields. But in order to call it, I need my own version of BuildPlatformListDrawer that calls the special method after the regular Draw(). And I haven't found a way to make my platform list drawer take priority over the main BuildPlatformListDrawer.cs. Every solution that I've found involves editing the source file in some way, which means that the edit gets auto-reverted later due to the package cache.
Anyway, correct me if I'm wrong, but think the correct solution here is to just make Draw() virtual and then inherit from it.
(As an aside, I don't mind contributing my BuildPlatforms for the Switch and PS5, but I feel like we're technically not allowed to do that in a public repo. I can post something to the private forums if we come up with a non-hacky solution, though).

Ended up adding this feature in a fork: https://github.com/3ternal/buildtool


As a user, I should be notified if my password combination was wrong

Estimated time: 0.5h
Risk: LOW
Priority: HIGH
Validation: Enter a wrong password combination and check for sweet alert popup. A good password will directly redirect to the chat
Story Points: 1

@StevenHaa or @Ea10 can you make a test case


Organize installation instructions

I reorganized the installation instructions from our docs, making it clear that the one needs to install Solana's LLVM fork before building Solang, following the suggestion from #948.

I included in the first section a list of our installation methods. The idea behind this is to promptly show the user how they can install Solang.

Also do you think its worth mentioning in the top-level README.md?

This is a good idea, but deserves another PR.


docs: Clarify 263/264 in LogGuide.md

Clarify how 263/264-lines work with regards to abilities that have a cast direction/angle but do not target a specific location.

Thank you!


[PROFILE ADDITION] Lucy Linder (derlin)

Profile screenshot

Closure Notice: This profile is being closed either because it has already been added or because no PR has been created. Please feel free to reopen and initiate a PR if the profile has not been added yet.


Allow serialization overwrite, or different serialization on specific component/props

Describe the bug
Can't overwrite an existing serializer for a defined type (here pd.DataFrame
To Reproduce
@rx.serializer
def serialize_dataframe(dataframe: pd.DataFrame) -> List[Dict[str, Any]]:
        """
        Serialize a pandas DataFrame to dict with records
        """
        return dataframe.to_dict("records")

usage
In my vega/altair wrapper I need to serialize dataframe to records (list of dict[col, value]
quickfix fail
def serializer(
    fn: Serializer | None = None,
    to: Type | None = None,
    overwrite: bool = False, # <- yuhu
) -> Serializer:
        ...
        if registered_fn is not None and (registered_fn != fn and not overwrite):
        raise ValueError(
            f"Serializer for type {type_} is already registered as {registered_fn.__qualname__}."
        )

But when app is starting, serializer is called with overwrite default value ! So False instaid of True !

Why is not possible to use the value of the current serializer of dataframe?

I wrapped altair/vega component here
But vega-lite/vega needs data like this :
df.to_dict("records")
[
  {'date': Timestamp('2012-01-01 00:00:00'),
  'precipitation': 0.0,
  'temp_max': 12.8,
  'temp_min': 5.0,
  'weather': 'drizzle',
  'wind': 4.7},
  {'date': Timestamp('2012-01-02 00:00:00'),
  'precipitation': 10.9,
  'temp_max': 10.6,
  'temp_min': 2.8,
  'weather': 'rain',
  'wind': 4.5}
]

instead of
df.to_dict()
{'date': {0: Timestamp('2012-01-01 00:00:00'),
        1: Timestamp('2012-01-02 00:00:00')},
'precipitation': {0: 0.0, 1: 10.9},
'temp_max': {0: 12.8, 1: 10.6},
'temp_min': {0: 5.0, 1: 2.8},
'weather': {0: 'drizzle', 1: 'rain'},
'wind': {0: 4.7, 1: 4.5}}

Its not a major issue, just for convenience

What do you think of something like :
DataFrameAltair= Annotated[pd.DataFrame, {"orient": "records "}]

And then in the serializer check for annotation ?

I succeed !
Will tidy my code next week and add tests
Not available for few days

dang it, that seemed like a good solution
is it possible to wrap dataframe some other way? like with an actual type and not an alias


Found two consecutive to elements. The selections are no longer safe to use! (contact the owner of the repository)

This occurs with the initial example when deleting one letter after the other. The error is thrown when you reach the b of bold.

fixed in the latest y-selections


feat: prometheus view rule cpu usage

By introducing the feature of observing cpu usage in a specified time window provided by the cpuprofile library, we can now observe the cpu usage of each rule of ekuiper through prometheus.
To use this feature, you need to set prometheus and enableResourceProfiling in the configuration file to true.
Then, run ekuiper and use test tool as shown below:

You can observe rule cpu usge in prometheus as shown below:

Build packages / build (1.22.1, linux/amd64, debian) (pull_request) Failing

I call the newly added function at internal/server/promMetrics/prom_metrcis.go at intern/server.go, but prom_metrice.go can't be compiled when the tag of go build is core.So what should I do?

Build packages / build (1.22.1, linux/amd64, debian) (pull_request) Failing

I call the newly added function at internal/server/promMetrics/prom_metrcis.go at intern/server.go, but prom_metrice.go can't be compiled when the tag of go build is core.So what should I do?

just add func SetRuleCPUUsageGauge to core_metrics.go

The coverage is not enough? It looks like UT is not easy to add. Could you try to add a FVT test case to cover the changes? Take a look at fvt/server_test.go as an example.

Sure, I will take care of this shortly.

For this FVT error, in .github/workflows/run_test_case.yaml, try to add MQTT service.

@Rookiecom This is not performance test. In the UT, we only need to cover the functionality, like assert the return body format. You don't even need to feed data if you can get a CPU usage result.

@ngjaying I'm really doing a functional test. Because cpuprofile library only parse the profileData with label, I can only get  an empty map if I don't feed data.If only need to detect whether a non-nil map is returned, it is not necessary to feed data?

@ngjaying I'm really doing a functional test. Because cpuprofile library only parse the profileData with label, I can only get an empty map if I don't feed data.If only need to detect whether a non-nil map is returned, it is not necessary to feed data?

Yeah, that's a valid scenario. We can cover the empty map scenario at the beginning. It would already cover most of the code, correct?

@ngjaying There is nothing I can do about that goroutine which writes metrics regularly

@ngjaying There is nothing I can do about that goroutine which writes metrics regularly

OK，thanks. You can take a look at the mock timer timex package. Or we can merge this one, and I'll try later to cover this.

You can take a look at the mock timer timex package

yeah, I have had a look at mock timex package, but I don't know how to mock ticker, or you do it(I learn ?)

@Rookiecom I'll merge this for now. We can add more tests and docs in other PRs.


kube-apiserver gives 'Loaded: not-found' while using Vagrant

I followed the vagrant guide from here. I have 1 master and 2 minions up. I am unable to find kube-apiserver service on master.
$ vagrant status
Current machine states:

master                    running (virtualbox)
minion-1                  running (virtualbox)
minion-2                  running (virtualbox)

This environment represents multiple VMs. The VMs are all listed
above with their current state. For more information about a specific
VM, run `vagrant status NAME`.
$ vagrant ssh master
Last login: Sun May  3 10:07:39 2015 from <IP_ADDRESS>
$ sudo systemctl status kube-apiserver
kube-apiserver.service
   Loaded: not-found (Reason: No such file or directory)
   Active: inactive (dead)

Can be this be related to the issue #3326? I am using Vagrant 1.7.2 (cc: @derekwaynecarr).
   $ vagrant version
   Installed Version: 1.7.2
   Latest Version: 1.7.2

   You're running an up-to-date version of Vagrant!

I have the same issue on my Mac, running OSX 10.10.3. This is what I see immediately after doing this:
export KUBERNETES_PROVIDER=vagrant
curl -sS https://get.k8s.io | bash

$ vagrant version
Installed Version: 1.7.2
Latest Version: 1.7.2

You're running an up-to-date version of Vagrant!

$ vagrant status
Current machine states:

master                    running (virtualbox)
minion-1                  running (virtualbox)

This environment represents multiple VMs. The VMs are all listed
above with their current state. For more information about a specific
VM, run `vagrant status NAME`.

Here's the hosts file inside master:
[vagrant@kubernetes-master ~]$ cat /etc/hosts
<IP_ADDRESS> kubernetes-master kubernetes-master
::1         localhost localhost.localdomain localhost6 localhost6.localdomain6
<IP_ADDRESS> kubernetes-minion-1
<IP_ADDRESS> localhost

And here's what I get for the six commands listed in the Setup section of https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/vagrant.md
[vagrant@kubernetes-master ~]$ sudo systemctl status kube-apiserver
kube-apiserver.service
   Loaded: not-found (Reason: No such file or directory)
   Active: inactive (dead)

[vagrant@kubernetes-master ~]$ sudo journalctl -r -u kube-apiserver
-- Logs begin at Tue 2015-02-24 15:05:10 UTC, end at Thu 2015-05-07 11:52:13 UTC. --

[vagrant@kubernetes-master ~]$ sudo systemctl status kube-controller-manager
kube-controller-manager.service
   Loaded: not-found (Reason: No such file or directory)
   Active: inactive (dead)

[vagrant@kubernetes-master ~]$ sudo journalctl -r -u kube-controller-manager
-- Logs begin at Tue 2015-02-24 15:05:10 UTC, end at Thu 2015-05-07 11:52:52 UTC. --

[vagrant@kubernetes-master ~]$ sudo systemctl status etcd
etcd.service
   Loaded: not-found (Reason: No such file or directory)
   Active: inactive (dead)

[vagrant@kubernetes-master ~]$ sudo systemctl status nginx
nginx.service - The nginx HTTP and reverse proxy server
   Loaded: loaded (/usr/lib/systemd/system/nginx.service; disabled)
   Active: active (running) since Thu 2015-05-07 11:38:33 UTC; 14min ago
 Main PID: 3503 (nginx)
   CGroup: /system.slice/nginx.service
           ├─3503 nginx: master process /usr/sbin/nginx
           ├─3504 nginx: worker process
           ├─3505 nginx: worker process
           ├─3506 nginx: worker process
           └─3507 nginx: worker process

May 07 11:38:33 kubernetes-master nginx[3499]: nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
May 07 11:38:33 kubernetes-master nginx[3499]: nginx: configuration file /etc/nginx/nginx.conf test is successful
May 07 11:38:33 kubernetes-master systemd[1]: Started The nginx HTTP and reverse proxy server.

I have the same issue as @joeygibson, exact same setup except am running Vagrant 1.7.0 as per issue #3326 "You can use a vagrant version >= 1.6.2 but < 1.7.1"

I need to update documentation, the kube-apiserver is run as a pod on the master.
If you are attempting to use the Vagrant configuration right now, I strongly recommend you run from the lastest HEAD of the source tree as two major fixes went in this week that are not in prior release trees.
Given that we are trying to close down Kube 1.0 release requirements, I strongly recommend you run from HEAD right now, or until a release > 18.1 is cut since I do not plan on back-porting the Vagrant environment changes to earlier releases.
So from HEAD
$ make release
$ export KUBERNETES_PROVIDER=vagrant
$ export NUM_MINIONS=<your desired amount>
$ cluster/kube-up.sh

should work fine, and your master will run a kubelet, and start the apiserver, controller, and scheduler as containers.  logs are in /var/log/ directory for those components.
I will use this issue to track updating the documentation.

@derekwaynecarr OK, I will try using HEAD. Thanks for the update!


CORS Issue with loading WebFont

Hi,
I've been trying to get Materialize working in my Web App however the WebFont doesn't seem to be loading from the CDN.
For example: http://output.jsbin.com/xulohapoxe/1/?output. As you can see in the console there are errors relating to CORS.
Have I missed something?
Thanks

seems like duplicate of #2989

This problem is resolved now as the font is being hosted on CDNJS at the right path


Allow null Recipient field for CreateTrace and CreateReply

Fixes https://github.com/Microsoft/botbuilder-dotnet/issues/1580
Seems odd that Recipient and From are flipped in CreateTrace.

Pull Request Test Coverage Report for Build 52630

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.985%

Totals

Change from base Build 52422:
0.0%

Covered Lines:
4338

Relevant Lines:
5709

💛  - Coveralls


Remove tilde from the name of MBeans node in Camel tree

Right now, in the Camel tree the MBean node has tilde before its name, ~MBean. I guess it's because of convenience of sorting for putting it to the bottom in order, but ideally we should remove tilde by improving the sort argorithm in the Camel plugin.

@phantomjinx Is my understanding correct? Is it easy to fix this?

@phantomjinx Is my understanding correct? Is it easy to fix this?

Yes. That's right. It was a stop-gap so I'll look at removing it next.


turn mischmasch into a max package

https://cycling74.com/tutorials/package-authoring-an-introduction
https://docs.cycling74.com/max7/vignettes/packages

@grrrwaaa I made it pretty far, but ran into a problem where node-gles3 can't be found. i think it would be easier in the long run if node-gles3 were made as a nodejs package. is this something I can do for you?


Workaround for using Binder property on JsonSerializerSettings

I've the following code where the serializationBinder is of type System.Runtime.Serialization.SerializationBinder
var jsonSerializerSettings = new JsonSerializerSettings { TypeNameHandling = TypeNameHandling.All };
jsonSerializerSettings.Binder = serializationBinder;

and it's erroring with v10.0.2 saying that Binder is obsolete.
Is there a way to workaround this based on the code above?
If I use SerializationBinder property on JsonSerializerSettings, it expects the value to be of ISerializationBinder type.

Help questions go on stackoverflow.


allow for pinning of ycsb load/workload pods

This commit will facilitate pinning of the workload/load pods
to a specific nodes, and also in the process moves the pod/job
definition into ansible templates

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:27:03

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:26:53

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:27:06

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:27:08

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:27:07

/rerun all

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Pass
0
00:01:48

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Fail
3
00:27:13

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Pass
0
00:02:03

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_ycsb
Pass
0
00:01:47


Add OCR for images

Is your feature request related to a problem? Please describe.
Another input method. Maybe needs
Describe the solution you'd like

when user runs OCR command, the image is automatically parsed? (maybe automatically?) or through a command.

Describe alternatives you've considered

when user adds an image source, the source description is populated with the OCR version of the text using deno

Must be done after #414


Stopped BlobStore cannot be reflected in Cluster Manager immediately

#880
For the time being, the API to stop BlobStore will not update cluster manager immediately. In current schema, we can only mark the whole disk as UNAVAILABLE. We temporarily cannot mark a single BlobStore (Replica) as unavailable.

#884
When a BlobStore is started, we should make sure that the ClusterParticipant is made aware of this, so it can synchronously update the status of the store/replica in Helix.

The issue is fixed by #929 and #988


chore: Import Chinese translation

I just imported the translation file and didn't confirm that it works (because I'm not sure if I need another commit to support Chinese).
Perhaps you could build a test version and confirm that(or send this build to me), and I'll continue to work on the translation. It's not a perfect translation.

you can work on translations by suggesting code or sending me on email

you can work on translations by suggesting code or sending me on email
Sorry, I didn't see this comment and I opened #11 ...
I will email you the translation afterward, but I won't close #11

you can work on translations by suggesting code or sending me on email

Sorry, I didn't see this comment and I opened #11 ...
I will email you the translation afterward, but I won't close #11

don't worry everything is fine ! thanks for ur work👍


"Signature did not match" with UserDelegationCredential

Bug Report

import path of package in question

github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/sas
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/service

SDK version e.g. master, latest, 18.1.0

github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.3.2

output of go version

go version go1.22.0 darwin/arm64

What happened?
I fail to do a SAS upload to a signed URL

PUT https://studcteststorage.blob.core.windows.net/studctest/sas_upload_test.txt/ --------------------------------------------------------------------------------
RESPONSE 403: 403 Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.
ERROR CODE: AuthenticationFailed --------------------------------------------------------------------------------
<?xml version="1.0" encoding="utf-8"?>
<Error>
AuthenticationFailed
<Message>
Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:b304660c-d01e-003d-0cce-9f3224000000 Time:2024-05-06T16:00:21.9356046Z
</Message>
<AuthenticationErrorDetail>
Signature did not match. String to sign used was w 2024-05-07T16:00:21Z /blob/studcteststorage/studctest/sas_upload_test.txt/ <RG-B Managed Identity Object ID> <Tenant ID> 2024-05-04T16:00:21Z 2024-05-07T16:00:21Z b 2023-11-03 https 2023-11-03 b
</AuthenticationErrorDetail>
</Error>

Note: I redacted <RG-B Managed Identity Object ID> and <Tenant ID> above.

What did you expect or want to happen?
I expected the SAS PUT request to work without issue. I am able to successfully write blobs to the container by calling methods like https://github.com/Azure/azure-sdk-for-go/blob/e13ea6e16ac0a4e20f167ce788d6fc5b5f017bcc/sdk/storage/azblob/client.go#L144
after creating a client like this

url := fmt.Sprintf("https://%s.blob.core.windows.net", accountName)
opts := &azidentity.WorkloadIdentityCredentialOptions{
	TenantID: *tenantID,
	ClientID: *rgBmanagedIdentityClientID,
}
cred, err := azidentity.NewWorkloadIdentityCredential(opts)
client, err := azblob.NewClient(url, cred, nil)

_, err = client.UploadStream(ctx, containerName, key, src, &azblob.UploadStreamOptions{
	Concurrency: 1,
	BlockSize:   1 << 20, // 1mb
})

How can we reproduce it?
Here is the code that gives the 403 error:

url := fmt.Sprintf("https://%s.blob.core.windows.net", accountName)
opts := &azidentity.WorkloadIdentityCredentialOptions{
	TenantID: *tenantID,
	ClientID: *rgBmanagedIdentityClientID,
}
cred, err := azidentity.NewWorkloadIdentityCredential(opts)
client, err := azblob.NewClient(url, cred, nil)

expiry := time.Now().Add(24 * time.Hour).UTC()
info := azblobService.KeyInfo{
	Start:  to.Ptr(time.Now().UTC().Add(-48 * time.Hour).Format(sas.TimeFormat)),
	Expiry: to.Ptr(expiry.Format(sas.TimeFormat)),
}

serviceClient := client.ServiceClient()
udc, err := serviceClient.GetUserDelegationCredential(ctx, info, nil)

sigVals := sas.BlobSignatureValues{
	Protocol:      sas.ProtocolHTTPS,
	ExpiryTime:    expiry,
	Permissions:   perm.String(),
	ContainerName: containerName,
	BlobName:      path,
}

query, err := sigVals.SignWithUserDelegation(udc)

signedUrl := fmt.Sprintf(
	"https://%s.blob.core.windows.net/%s/%s?%s",
	accountName,
	containerName,
	blobKey,
	query.Encode(),
)

sasClient, err := azblob.NewClientWithNoCredential(signedUrl, nil)
resp, err := sasClient.UploadStream(ctx, "", "", strings.NewReader("SAS upload test"), &azblob.UploadStreamOptions{})

Anything we should know about your environment.

My infrastructure setup is as follows:
I have a resource group (let's call it RG-A)with a k8s cluster, a managed identity, and other resources. In another resource group (say RG-B), I have only a managed identity and a storage account with a container.
I can successfully write blobs from an app running in the k8s cluster in RG-A to the storage container in RG-B. (Only the SAS is giving me trouble.) In RG-B, I gave Storage Account Contributor and Storage Blob Data Owner roles to the RG-B managed identity. Then, I created a federated credential that allows the k8s cluster in RG-A to auth to the managed identity in RG-B, by using the following command:
az identity federated-credential create \
  --name fc-x-tenant-test \
  --identity-name rg-B-managedIdentity \
  --resource-group rg-B \
  --issuer <RG-A AKS Cluster OIDC Provider URL> \
  --subject system:serviceaccount:default:<RG-A Service Account name>

Also, I logged the query with a previous version of the code (the only difference being I hadn't set the start time to 2 days in the past yet, it was only being set to 10 seconds in the past).
Query {
	version:2023-11-03
	services:
	resourceTypes:
	protocol:https
	startTime:{wall:0 ext:0 loc:<nil>}
	expiryTime:{wall:151009920 ext:63850466819 loc:<nil>}
	snapshotTime:{wall:0 ext:0 loc:<nil>}
	ipRange:{Start:[] End:[]}
	identifier:
	resource:b
	permissions:w
	signature:bDcn0MCs1kGakVX9OOtKt/ApBllv68AJLZnwZK4g+5g=
	cacheControl: contentDisposition: contentEncoding: contentLanguage: contentType:
	signedOID:<RG-B Managed Identity Object ID>
	signedTID:<Tenant ID>
	signedStart:{wall:0 ext:63850380409 loc:<nil>}
	signedService:b
	signedExpiry:{wall:0 ext:63850466809 loc:<nil>}
	signedVersion:2023-11-03
	signedDirectoryDepth: authorizedObjectID: unauthorizedObjectID: correlationID: encryptionScope: stTimeFormat: seTimeFormat:
}

Hi,
we are currently analyzing a similar issue in our productive environment where a blobstorage upload failed. Our best guess currently is, that the node time was off by a few seconds.
import path of package in question
	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob"
	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/blob"
	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/bloberror"
	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/blockblob"

SDK version e.g. master, latest, 18.1.0
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.3.2
go version in prod is 1.22.1 linux/amd64
code where the error happens:
`blockblobClient, err := createBlockBlobUploadClient(destPath)
if err != nil {
return err
}
_, err = blockblobClient.UploadStream(ctx, data, &blockblob.UploadStreamOptions{})`

Here is the error we've encountered:
PUT https://xxxxxxxxxxxxxx.blob.core.windows.net/xxxxxxxxxxxxxx/xxxxxxxxxxxxxx/xxxxxxxxxxxxxx.zip\n--------------------------------------------------------------------------------\nRESPONSE 403: 403 Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.\nERROR CODE: AuthenticationFailed\n--------------------------------------------------------------------------------\n<?xml version=\"1.0\" encoding=\"utf-8\"?><Error>AuthenticationFailed<Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.\nRequestId:a9ba6d7b-f01e-002b-5a84-9f2a94000000\nTime:2024-05-06T07:09:35.3537024Z</Message><AuthenticationErrorDetail>The MAC signature found in the HTTP request '+vWptkqk4dfaIzum/0fvvQjVBwTOaEAiGlu34TY9P2k=' is not the same as any computed signature. Server used following string to sign: 'PUT\n\n\n985458\n\napplication/octet-stream\n\n\n\n\n\n\nx-ms-date:Mon, 06 May 2024 07:09:35 GMT\nx-ms-version:2023-11-03\n/xxxxxxxxxxxxxx/xxxxxxxxxxxxxx/xxxxxxxxxxxxxx.zip\nblockid:wfCx0A6XRlxSWrV4EJ7X7AAAAA4AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA==\ncomp:block'.</AuthenticationErrorDetail></Error>\n--------------------------------------------------------------------------------\n

Hi @johannesvietze thank you for looking into this!!
I see that your AuthenticationErrorDetail says The MAC signature found in the HTTP request '+vWptkqk4dfaIzum/0fvvQjVBwTOaEAiGlu34TY9P2k=' is not the same as any computed signature..., while my AuthenticationErrorDetail says Signature did not match. String to sign used was....
Does that mean these are different causes of the 403?
Also,

Our best guess currently is, that the node time was off by a few seconds

what do you mean by  "node time"? I thought that there might be some clock skew causing the start time window to be after the actual time of the attempted upload, so I made it the Start time be a full 2 days in the past
info := azblobService.KeyInfo{
	Start:  to.Ptr(time.Now().UTC().Add(-48 * time.Hour).Format(sas.TimeFormat)),
	Expiry: to.Ptr(expiry.Format(sas.TimeFormat)),
}

and the issue still persists. (and from Signature did not match. String to sign used was w 2024-05-07T16:00:21Z /blob/studcteststorage/studctest/sas_upload_test.txt/ <RG-B Managed Identity Object ID> <Tenant ID> 2024-05-04T16:00:21Z 2024-05-07T16:00:21Z b 2023-11-03 https 2023-11-03 b, I can verify the start time was a full 2 days in the past)

@vibhansa-msft @tanyasethi-msft my issue was that I cannot specify the blob name in the BlobSignatureValues; however, I can specify it there when I use a SharedKeyCredential and sign with SignWithSharedKey instead of using a UserDelegationCredential

Hi @levinandrew , Thanks for reporting this.
While creating BlobSignatureValues, you can specify the BlobName to generate the SAS for an Azure Storage blob.
In the code above, while creating BlobSignatureValues,
Permissions:   perm.String()
What are the permissions given?
Also,
resp, err := sasClient.UploadStream(ctx, "", "", strings.NewReader("SAS upload test"), &azblob.UploadStreamOptions{})
The blob name and container name are "", "". Is that intentional, and why is it so?


[v9] Add php 8 support and composer 2

Ive been going over the progress of this in #9789
This PR closes #9314, #9713
In this PR the following changes have been made

I've upgraded doctrine/dbal to at least 2.13.2, doctrine common to version 3, doctrine orm to 2.8.5 and begun work on getting ready to migrate orm to version 3
Upgraded league csv to 9.7.1, league oauth server to 8.3.2, league fractal to 0.19.2
Upgraded phpseclib to 3.0
Upgraded stash to 0.16
Included a php8 compatibility patch for "lcobucci/jwt": 3.4.5 (version 4 and above works but doesnt support php 7.3), patch needs to be moved to concrete5/dependencypatches and out of this repo
Changed Urlify to Jbroadway/urlify from voku (for php8 compatibility and it works better)
Added symfony cache to replace the doctrine common cache being removed
Fixed a lot of warnings in php8
Updated phpunit to version 8 (we can run 9 but it only supports 7.4 and above)
Fixed API testClearBinding tests to work with new version of dbal
Removed phpunit/dba
Upgraded composer to version 2, also include a test for composer version 1

Current issues:

The only real issue is that urlify actually works for most languages now and doesnt just remove them (previously ひらがな as a url would become blank as a handle, now it is correctly written as hiragana ( tests/tests/Utility/Service/TextTest.php )
PHP8 changes the way is_callable is used to only work on static public methods with classnames, so there may be more instances that need to be fixed where we use is_callable to check for public methods : EXAMPLE: https://github.com/concrete5/concrete5/pull/9813/files#diff-60dbe73ba50d686faf80ff211242b3ba6209efc2a36f3a704a20002f0b2064bd
PHP8 Also changed the signature on array map so you have to write out the function for array_map('array_shift',....) EXAMPLE: https://github.com/concrete5/concrete5/pull/9813/files#diff-ab5b1212d84d9f3b271711f858e5ca9e005dd59c7aa95b9613db3ed8414eec20

It'd be good to include 8.1 with allowed failure in the build array

Thank you so much for this – this is great. I downloaded a php8 docker box and was able to install with no problems. I'm sure there might be some issues that come up with this, but this is a great start, and seems to be working just fine for me on PHP 7.3 as well.


Docs for Trainer init method need double quotes added

What does this PR do?
Docs for Trainer init method need double quotes added

Does your PR introduce any breaking changes? If yes, please list them.
No

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@akkefa, great first contribution! :tada:


GH-10: Add basic checks into pre-commit-config

Fixes #10
Fixes #11
Removed gh 12 now

Could you add https://github.com/apache/arrow-go/blob/main/.editorconfig for shfmt?

Good catch, thank you.

I see. I thought the reformatting of indentation made sense.
I will revert the changes in the YAML files.

Reverted changes in YAML files


Improve pretty printing (Concrete.hs)

The following things should be done to help improve legibility of pretty printing to the concrete syntax:

When encountering RealPow e (-1/n) replace with Recip (NatRoot e n). N.B., this is the negative case which isn't currently handled.
Since NatRoot e 2 is so common, pretty print as sqrt e instead. N.B., make sure that sqrt is defined for symbol resolution too.
When encountering e1 + -e2 pretty print as e1 - e2 instead. N.B., should handle both the case where e2 is negate e3 as well as the case where e2 is a negative literal.
When encountering e1 * 1/e2 pretty print as e1 / e2; again both for recip e3 and for literal 1/v3.
When encountering case b of { True -> e1; False -> e2 } instead print if_ b e1 e2. N.B., this should be sure to handle all cases where the scrutinee is of HBool type, including when the patterns may be given in the other order, when one pattern may be a wildcard or a variable, etc.
As a special case, when encountering if_ b m reject instead pretty print as guard b; m so as to avoid excessive indentation

Agreed.  I would have done this as 6 separate issues, so that they can be dealt with (and closed) independently.

yeah, I talked with @zaxtax and asked if he had a preference, and he preferred them all as one ticket. ::shrug::

Yes! They all seem short and related.
Thanks for this list!
On Jun 30, 2016 3:06 PM, "wren romano"<EMAIL_ADDRESS>wrote:

yeah, I talked with @zaxtax https://github.com/zaxtax and asked if he
had a preference, and he preferred them all as one ticket. ::shrug::
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hakaru-dev/hakaru/issues/27#issuecomment-229757823,
or mute the thread
https://github.com/notifications/unsubscribe/AAAhUd8IxSydUtbtLmHP5H2yPZEZHaEcks5qRBO3gaJpZM4JCUwN
.

Actually @wrengr the last two bullet points look trickier, may I move them into their own issue?

@zaxtax sure, go for it


Update upload API response structure

Description
Include following information about upload API results

errors, with values either true or false
total, with values as total number of documents
success, with values as number of documents that are indexed
failure, with values as number of documents that are failed
messages, json array, with list of failure messages.

Issues Resolved
#49
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #51 (99bd81e) into main (88ce668) will decrease coverage by 1.69%.
The diff coverage is 85.10%.

@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
- Coverage     88.98%   87.29%   -1.70%
- Complexity      103      108       +5
============================================
  Files            15       16       +1
  Lines           336      370      +34
  Branches         27       29       +2
============================================
+ Hits            299      323      +24
- Misses           33       43      +10
  Partials          4        4

Impacted Files
Coverage Δ

...n/upload/geojson/UploadGeoJSONTransportAction.java
0.00% <ø> (ø)

...rch/geospatial/action/upload/geojson/Uploader.java
90.74% <80.00%> (-9.26%)
:arrow_down:

...l/action/upload/geojson/UploadGeoJSONResponse.java
86.11% <86.11%> (ø)

...ial/action/upload/geojson/UploadGeoJSONAction.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c1cfc...99bd81e. Read the comment docs.


new-command: yammer report groupsactivitydetail

implements #1388

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>f77b8f7075f50e44df9228c85e265e on plamber:yammer-report-groupsactivitydetail into f7f194d36ec571e84edc736ac0c7d821534abd54 on pnp:dev.

Awesome! We'll have a look shortly 👍

Merged manually. Thank you! 👏


Visayan language family has no iso code

It is a family of languages, each with their own code:
https://en.wikipedia.org/wiki/Visayan_languages
How should we treat a common name with language=Visayan ?
Make it Cebuano, the largest language of that family?
https://en.wikipedia.org/wiki/Cebuano_language

@gdower @yroskov would you agree with the Cebuano proposal?

Yes, I agree. It looks like written Cebuano use basic Latin script.


Move many of the resources from "Resources.resx" into separate .resx files

I wrote a tool to figure out which source files were using which resources from Resources.resx.
For resources that were only used by source files in a particular folder, the resources get moved into a new .resx file "FOLDERNAMEResources.resx".
This tool that performed the refactor is in the "/Skyline/work/20231112_ShrinkResourcesResx" branch.
After I ran my tool, I also had to use ReSharper to cleanup the "using" statements, which, unfortunately, resulted in some whitespace changes in the comment at the top of some source files that did not actually need any changes. This seems to be unavoidable.
How does the layout of these new resources look?
It would not be difficult to change the way the tool works if it turns out we'd like the resources organized differently.

What's the idea behind doing this? The main file was too big for operations to run quickly on?

What's the idea behind doing this? The main file was too big for operations to run quickly on?

The main file is too big and changes too often. Every time that someone commits a change to Resources.resx, I believe our repository grows by 3MB because a new version of "Resources.resx", "Resources.designer.cs" etc. need to be stored for all time.

I'm not sure about the 3MB thing once a non-binary file gets compressed into a git pack file, but just having to do that compression and decompression (and deltas) probably slows it down, so it does seem preferable to avoid churn on large files as much as possible. I tried to figure out how much of our repository is due to resource string updates (taking into account pack file compression) but my git-fu isn't up to the task. All I got is summing up the size of the pwiz_tools/Skyline/Properties/Resources.resx blobs, which is about 5GB. The repo's not that big, so the pack file compression is working. I guess we could take a scratch copy and rewrite the history removing all the pwiz_tools/Skyline/Properties/Resources.resx files and see how much smaller the resulting repo is...

With help from GPT-4 I ran the commands to remove pwiz_tools/Skyline/Properties/Resources.resx from the history of a copy of the repo. It trimmed 800mb from the repo's overall size (4.2GB to 3.4GB). That is a sizeable chunk to be sure. I wonder if we should archive the repo at some point and start fresh (or past some arbitrary date)? Devs would keep a read-only copy of the archive around to check logs if necessary.


Homebrew support

Awesome app! 👍
I would also like to be able to install git-caesar from Homebrew, a package manager for macOS and Linux. Such like so:
$ brew install yoshi389111/apps/git-caesar

I would like to PR for this but what do you think?

Of course, pull requests are welcome.

Cool.
To support Homebrew we need a brand new repository with a homebrew- prefix to place the brew packages.
Please create a blank repo at github.com/yoshi389111/homebrew-apps or github.com/yoshi389111/homebrew-git-caesar when you got time.
I recommend github.com/yoshi389111/homebrew-apps for your future app.

I got it.
I created an empty repository.
https://github.com/yoshi389111/homebrew-apps


Azure OPen Ai integracion

Is your feature request related to a problem? Please describe.

Its possible to use azure open ai?
Describe the solution you'd like

Trying with custom open ai without work. Using the Endpoint URL!
Describe alternatives you've considered

Additional context

Closing as this is a duplicate of #64


Fix issue DalleImageGeneration generate_image() results in error (close #862)

Description

Fixes error that caused Dall-E image generation to fail.

Related Issues

#862
Solution and Design

Allow param for number of images to be optional; this means no change to consuming code
Test Plan

Ran locally, success
Did not break existing unit tests
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[x] My pull request is atomic and focuses on a single change.
[x] I have read the contributing guide and my code conforms to the guidelines.
[x] I have documented my changes clearly and comprehensively.
[ ] I have added the required tests.

I'm very interested in feedback.  Using magic number -1 didn't seem ideal but wasn't sure of a better way to make last param optional.  Could use a steer in best practices on how to capture this via unit tests; I didn't add anything, which is maybe okay for a break/fix, but leaves something to be desired in logical branch coverage.  Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is fixed in the latest release. The num parameter is not passed in the generate_image method anymore.


Get UX input on commented code in generated samples

Currently, discovery client library samples suggest optional code (for media upload/download) as comments offset by blank lines at the current indentation. @vchudnov-g suggests visually offsetting commented code by indents instead of blank lines: https://github.com/googleapis/toolkit/pull/542#discussion_r81198302

Have we done this? There doesn't seem to have been any negative feedback yet, anyway

I think it would make sense to get some proactive user feedback once other P1 fixes for correctness are submitted.

None of the changes since MVVM have been published yet....

I think we should claim wontfix or say that we're at a good enough point on this, I think we've gotten a significant amount of input from language experts, that may be enough to close this one.

AFAICT, we have not made a full update of live samples since last summer, and some of the samples specifically relevant to this issue are not live; so absence of negative feedback may not be indicative. I think once we have a fully passing set of samples, it would still make sense to get a final round of user feedback of some kind.

Demoting to P2 because of other priorities.

@tcoffee-google @vchudnov-g  Is this still relevant?

Unlikely to happen at this point, closing.


[WIP][Feature][LineChart] Add main source, need review

Description
First commit,
Created a new branch, added the main code of LineChart feature. Not finished yet, still wip need reviews & feedback for refactoring.
Tests
The test code is not written yet, I will proceed after review & feedback
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] Run yarn test or yarn test -u if you need to update snapshot.
[x] Run yarn lint
[x] I am willing to follow-up on review comments in a timely manner.

Fixed requested changes and re-requested review. Please check the changes and let me know if it needs more updates.
TODO:

Test-code not written yet

Request a review @hyochan before merge!


Swift REPL does not start

Your Windows build number:  18894 20H1 Insider build - same behavior on 1809 release
WSL 1, Ubuntu 18.04
Swift 5.01 installed from https://swift.org/download/
Please note this NOT a duplicate of #286 , the execstack issue has since been solved upstream in Swift

What you're doing and what's happening:
Execute 'swift'
Terminal does not show further output, Ctrl-C does not end swift REPL. strace shows "process launch failed: 'A' packet returned an error: 8"

tbehrens@WSL-INSIDERTEST:~$ swift -version
Swift version 5.0.1 (swift-5.0.1-RELEASE)
Target: x86_64-unknown-linux-gnu
tbehrens@WSL-INSIDERTEST:~$ swift

^C

^C

What's wrong / what should be happening instead:
swift REPL should start, output along the lines of:

Welcome to Apple Swift version 5.01. Type :help for assistance.
  1>

Strace of the failing command, if applicable:

swift-strace.txt
From roughly line 4340 in strace, a number of EBADF, then on line 6383, a failed ptrace with EPERM followed by an fseek with ESPIPE.
Same behavior with "sudo /path/to/swift/usr/bin/swift"

I encountered the same issue. Any fixes or workarounds?

Workaround: Use WSL 2.

Same issue here.

Same issue

Workaround: Use WSL 2.

I confirm. Debugging and REPL do not function on WSL1

Maybe we can close this issue ? @thorsteneb

Certainly. I think closing it says something about ongoing WSL 1 development - and, I am perfectly fine by that.
Go ahead and close!

Certainly. I think closing it says something about ongoing WSL 1 development - and, I am perfectly fine by that.
Go ahead and close!

Sorry, I am not a contributor so I can't tickets. Maybe someone from WSL team can close it ?