Adding TargetNullValue to BindingExtension

I noticed that I cannot use TargetNullValue in XAML as it's not added to BindingExtension yet. I think this should fix this.

What does the pull request do?
Adding TargetNullValue to BindingExtension so we can use it in XAML.

What is the current behavior?
TargetNullValue is not part of BindingExtension.

Unit test would be useful.


Add upload elements to a rich text field makes page unresponsive

Bug Report
Adding a upload element from a Media collection makes all intractable elements on the page unresponsive.
Expected Behavior
Page should be still intractable when adding a upload element to the rich text field, so that you can save or continue editing the item in the collection.
Current Behavior
Adding a upload element from a Media collection makes all intractable elements on the page unresponsive.
Possible Solution
🤷
Steps to Reproduce

Create an upload collection
Create a collection with a rich text field
Upload an image to the upload collection
Try to insert image into the rich text field to the other collection

Detailed Description
Payload version: 1.0.32
Browser: Firefox

Hey @Reilley64,
I'm not able to reproduce your issue on my end. Can you share your config on both the collection and the upload that is linked? Also if you're able to do a screen recording, that could be invaluable too!
I tried swapping images, uploading new ones, add and removing images to the rich text, it seems to be fine. It is working as intended and I don't see any errors in the console to go off of. 🤷
Thanks!

Same here, page becomes unresponsive and no console or terminal errors are shown.

Can anyone get a screen recording so we can assess the problem better?

Here's a screen recording of the issue:
https://user-images.githubusercontent.com/28533679/188748706-621d13f8-34d0-4784-a7d0-faaac50de163.mov

We were able to recreate this issue. It looks like the nextjs-custom-website repo had a conflicting version of slate installed. This has been reverted. The repo has been updated, or you can make the same change as this commit

Hey I'm not using the nextjs-custom-server repo. I'm having this issue from the base template after running yarn create payload-app.

I've made a repo that should help you reproduce the issue.

Hey all - this is fixed in 1.0.34!
Thank you everyone!


Modify imagetable object to verify the column names and add helper methods

This commit adds code to verify if the user specified column names
are present in the image table. A new method named as_dict is
added to facilitate use of imagetable object in calling various
actions.

@courtneyambrozic - Based on feedback from Kevin, I added a few functions and validations for column names in the ImageTable class. Can you please review?


部署失败

已免密环境，master节点执行：
sealos init --master <IP_ADDRESS> \
        --node <IP_ADDRESS> <IP_ADDRESS> \
        --pkg-url /root/leo/kube.tar.gz \
        --version v1.18.6

安装报错：
.....
[kubelet-start] Starting the kubelet
[certs] Using certificateDir folder "/etc/kubernetes/pki"
[certs] Using existing ca certificate authority
[certs] Using existing apiserver certificate and key on disk
[certs] Using existing apiserver-kubelet-client certificate and key on disk
[certs] Using existing front-proxy-ca certificate authority
[certs] Using existing front-proxy-client certificate and key on disk
[certs] Using existing etcd/ca certificate authority
[certs] Using existing etcd/server certificate and key on disk
[certs] Using existing etcd/peer certificate and key on disk
[certs] Using existing etcd/healthcheck-client certificate and key on disk
[certs] Using existing apiserver-etcd-client certificate and key on disk
[certs] Using the existing "sa" key
[kubeconfig] Using kubeconfig folder "/etc/kubernetes"
[kubeconfig] Using existing kubeconfig file: "/etc/kubernetes/admin.conf"
[kubeconfig] Using existing kubeconfig file: "/etc/kubernetes/kubelet.conf"
[kubeconfig] Using existing kubeconfig file: "/etc/kubernetes/controller-manager.conf"
[kubeconfig] Using existing kubeconfig file: "/etc/kubernetes/scheduler.conf"
[control-plane] Using manifest folder "/etc/kubernetes/manifests"
[control-plane] Creating static Pod manifest for "kube-apiserver"
[control-plane] Creating static Pod manifest for "kube-controller-manager"
W0904 15:08:04.614774   59575 manifests.go:225] the default kube-apiserver authorization-mode is "Node,RBAC"; using "Node,RBAC"
[control-plane] Creating static Pod manifest for "kube-scheduler"
W0904 15:08:04.621284   59575 manifests.go:225] the default kube-apiserver authorization-mode is "Node,RBAC"; using "Node,RBAC"
[etcd] Creating static Pod manifest for local etcd in "/etc/kubernetes/manifests"
[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory "/etc/kubernetes/manifests". This can take up to 4m0s
[apiclient] All control plane components are healthy after 15.009025 seconds
[upload-config] Storing the configuration used in ConfigMap "kubeadm-config" in the "kube-system" Namespace
[kubelet] Creating a ConfigMap "kubelet-config-1.18" in namespace kube-system with the configuration for the kubelets in the cluster
[kubelet-check] Initial timeout of 40s passed.
error execution phase upload-config/kubelet: Error writing Crisocket information for the control-plane node: timed out waiting for the condition
To see the stack trace of this error execute with --v=5 or higher

15:10:19 [EROR] [ssh.go:27] [ssh][<IP_ADDRESS>:22]Error exec command failed: Process exited with status 1
15:10:19 [EROR] [init.go:130] [<IP_ADDRESS>:22]kubernetes install is error.please clean and uninstall.

--node <IP_ADDRESS> --node  <IP_ADDRESS> \


migration:create doesn't default to creating a blank migration file

Describe the bug
migration:create command without flags (--blank or --initial) does nothing, it should default to creating a blank migration file.
Stack trace
$ mikro-orm migration:create
[discovery] ORM entity discovery started, using ReflectMetadataProvider
[discovery] - processing entity Course
[discovery] - processing entity CourseProgress
[discovery] - processing entity CourseModule
[discovery] - processing entity BaseEntity
[discovery] - entity discovery finished, found 4 entities, took 18 ms
[info] MikroORM successfully connected to database integrated_learning_experience_development on postgresql://integrated_learning_experience_admin:*****@localhost:5432
[query] select table_name, nullif(table_schema, 'public') as schema_name from information_schema.tables where table_schema not like 'pg_%' and table_schema != 'information_schema' and table_name != 'geometry_columns' and table_name != 'spatial_ref_sys' and table_type != 'VIEW' order by table_name [took 5 ms]
[query] select column_name, column_default, is_nullable, udt_name, coalesce(datetime_precision, character_maximum_length) length, data_type from information_schema.columns where table_schema = 'public' and table_name = 'course_progress' [took 13 ms]
[query] select relname as constraint_name, attname as column_name, idx.indisunique as unique, idx.indisprimary as primary from pg_index idx left join pg_class AS i on i.oid = idx.indexrelid left join pg_attribute a on a.attrelid = idx.indrelid and a.attnum = ANY(idx.indkey) and a.attnum > 0 where indrelid = '"public"."course_progress"'::regclass [took 3 ms]
[query] select kcu.table_name as table_name, rel_kcu.table_name as referenced_table_name, kcu.column_name as column_name, rel_kcu.column_name as referenced_column_name, kcu.constraint_name, rco.update_rule, rco.delete_rule from information_schema.table_constraints tco join information_schema.key_column_usage kcu on tco.constraint_schema = kcu.constraint_schema and tco.constraint_name = kcu.constraint_name join information_schema.referential_constraints rco on tco.constraint_schema = rco.constraint_schema and tco.constraint_name = rco.constraint_name join information_schema.key_column_usage rel_kcu on rco.unique_constraint_schema = rel_kcu.constraint_schema and rco.unique_constraint_name = rel_kcu.constraint_name and kcu.ordinal_position = rel_kcu.ordinal_position where tco.table_name = 'course_progress' and tco.table_schema = 'public' and tco.constraint_schema = 'public' and tco.constraint_type = 'FOREIGN KEY' order by kcu.table_schema, kcu.table_name, kcu.ordinal_position [took 14 ms]
[query] select conrelid::regclass as table_from, conname, pg_get_constraintdef(c.oid) as enum_def from pg_constraint c join pg_namespace n on n.oid = c.connamespace where contype = 'c' and conrelid = '"public"."course_progress"'::regclass order by contype [took 4 ms]
[query] select column_name, column_default, is_nullable, udt_name, coalesce(datetime_precision, character_maximum_length) length, data_type from information_schema.columns where table_schema = 'public' and table_name = 'courses' [took 9 ms]
[query] select relname as constraint_name, attname as column_name, idx.indisunique as unique, idx.indisprimary as primary from pg_index idx left join pg_class AS i on i.oid = idx.indexrelid left join pg_attribute a on a.attrelid = idx.indrelid and a.attnum = ANY(idx.indkey) and a.attnum > 0 where indrelid = '"public"."courses"'::regclass [took 2 ms]
[query] select kcu.table_name as table_name, rel_kcu.table_name as referenced_table_name, kcu.column_name as column_name, rel_kcu.column_name as referenced_column_name, kcu.constraint_name, rco.update_rule, rco.delete_rule from information_schema.table_constraints tco join information_schema.key_column_usage kcu on tco.constraint_schema = kcu.constraint_schema and tco.constraint_name = kcu.constraint_name join information_schema.referential_constraints rco on tco.constraint_schema = rco.constraint_schema and tco.constraint_name = rco.constraint_name join information_schema.key_column_usage rel_kcu on rco.unique_constraint_schema = rel_kcu.constraint_schema and rco.unique_constraint_name = rel_kcu.constraint_name and kcu.ordinal_position = rel_kcu.ordinal_position where tco.table_name = 'courses' and tco.table_schema = 'public' and tco.constraint_schema = 'public' and tco.constraint_type = 'FOREIGN KEY' order by kcu.table_schema, kcu.table_name, kcu.ordinal_position [took 9 ms]
[query] select conrelid::regclass as table_from, conname, pg_get_constraintdef(c.oid) as enum_def from pg_constraint c join pg_namespace n on n.oid = c.connamespace where contype = 'c' and conrelid = '"public"."courses"'::regclass order by contype [took 3 ms]
[query] select column_name, column_default, is_nullable, udt_name, coalesce(datetime_precision, character_maximum_length) length, data_type from information_schema.columns where table_schema = 'public' and table_name = 'modules' [took 7 ms]
[query] select relname as constraint_name, attname as column_name, idx.indisunique as unique, idx.indisprimary as primary from pg_index idx left join pg_class AS i on i.oid = idx.indexrelid left join pg_attribute a on a.attrelid = idx.indrelid and a.attnum = ANY(idx.indkey) and a.attnum > 0 where indrelid = '"public"."modules"'::regclass [took 6 ms]
[query] select kcu.table_name as table_name, rel_kcu.table_name as referenced_table_name, kcu.column_name as column_name, rel_kcu.column_name as referenced_column_name, kcu.constraint_name, rco.update_rule, rco.delete_rule from information_schema.table_constraints tco join information_schema.key_column_usage kcu on tco.constraint_schema = kcu.constraint_schema and tco.constraint_name = kcu.constraint_name join information_schema.referential_constraints rco on tco.constraint_schema = rco.constraint_schema and tco.constraint_name = rco.constraint_name join information_schema.key_column_usage rel_kcu on rco.unique_constraint_schema = rel_kcu.constraint_schema and rco.unique_constraint_name = rel_kcu.constraint_name and kcu.ordinal_position = rel_kcu.ordinal_position where tco.table_name = 'modules' and tco.table_schema = 'public' and tco.constraint_schema = 'public' and tco.constraint_type = 'FOREIGN KEY' order by kcu.table_schema, kcu.table_name, kcu.ordinal_position [took 12 ms]
[query] select conrelid::regclass as table_from, conname, pg_get_constraintdef(c.oid) as enum_def from pg_constraint c join pg_namespace n on n.oid = c.connamespace where contype = 'c' and conrelid = '"public"."modules"'::regclass order by contype [took 2 ms]
No changes required, schema is up-to-date

To Reproduce
Steps to reproduce the behavior:

Run mikro-orm migration:create
Expect a blank migration to be created
After a lot of noisy CLI feedback (see above), nothing happens

Expected behavior
migration:create should create a blank migration without requiring the --blank flag when an initial migration already exists, it should create an initial migration otherwise.
I understand that flags exist, but why not default to something intuitive with such a simple command? The current behavior appears to be identical to the output of the migration:create --dump command.
Versions

Dependency
Version

node
14.16.1

typescript
4.2.4

mikro-orm
4.5.3

mikro-orm/postgresql
4.5.3

I like to keep this explicit, all CLI commands work this way 🤷


Re-relating with self-signed-certificates charm causes an error state

Steps to reproduce

Deploy 3 units of postgresql-k8s charm, channel 14/stable revision 381
Deploy self-signed-certificates charm and relate them.
Remove the relation, and re-add it.

Expected behavior
Both charms are in active/idle state.
Actual behavior
One of the postgresql-k8s units goes into an error state.
Versions

Operating system: Ubuntu 22.04.4 LTS

Juju CLI: 3.5.3-ubuntu-amd64

Juju agent: 3.5.3

Charm revision: 381, channel 14/stable

kubectl:
Client Version: v1.30.4
Server Version: v1.26.15
Log Output
juju debug-log:
unit-postgresql-k8s-2: 19:13:51 DEBUG unit.postgresql-k8s/2.juju-log certificates:415: Emitting Juju event certificates_relation_changed.
unit-postgresql-k8s-2: 19:13:51 ERROR unit.postgresql-k8s/2.juju-log certificates:415: Uncaught exception while in charm code:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/./src/charm.py", line 2097, in <module>
    main(PostgresqlOperatorCharm, use_juju_for_storage=True)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 553, in main
    manager.run()
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 529, in run
    self._emit()
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 518, in _emit
    _emit_charm_event(self.charm, self.dispatcher.event_name, self._juju_context)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 139, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 347, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 853, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 943, in _reemit
    custom_handler(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/tls_certificates_interface/v2/tls_certificates.py", line 1786, in _on_relation_changed
    for certificate_creation_request in self._requirer_csrs
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/tls_certificates_interface/v2/tls_certificates.py", line 1529, in _requirer_csrs
    relation = self.model.get_relation(self.relationship_name)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/model.py", line 250, in get_relation
    return self.relations._get_unique(relation_name, relation_id)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/model.py", line 949, in _get_unique
    raise TooManyRelatedAppsError(relation_name, num_related, 1)
ops.model.TooManyRelatedAppsError: Too many remote applications on certificates (2 > 1)
unit-postgresql-k8s-2: 19:13:52 ERROR juju.worker.uniter.operation hook "certificates-relation-changed" (via hook dispatching script: dispatch) failed: exit status 1
unit-postgresql-k8s-2: 19:13:52 INFO juju.worker.uniter awaiting error resolution for "relation-changed" hook
unit-postgresql-k8s-2: 19:13:56 INFO juju.worker.uniter awaiting error resolution for "relation-changed" hook
unit-postgresql-k8s-2: 19:14:08 INFO juju.worker.uniter awaiting error resolution for "relation-changed" hook
unit-postgresql-k8s-2: 19:14:09 DEBUG unit.postgresql-k8s/2.juju-log certificates:415: ops 2.16.0 up and running.
unit-postgresql-k8s-2: 19:14:09 DEBUG unit.postgresql-k8s/2.juju-log certificates:415: no relation on 'tracing': tracing not ready
unit-postgresql-k8s-2: 19:14:09 DEBUG unit.postgresql-k8s/2.juju-log certificates:415: Emitting Juju event certificates_relation_joined.
unit-postgresql-k8s-2: 19:14:09 ERROR unit.postgresql-k8s/2.juju-log certificates:415: Uncaught exception while in charm code:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/./src/charm.py", line 2097, in <module>
    main(PostgresqlOperatorCharm, use_juju_for_storage=True)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 553, in main
    manager.run()
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 529, in run
    self._emit()
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 518, in _emit
    _emit_charm_event(self.charm, self.dispatcher.event_name, self._juju_context)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/main.py", line 139, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 347, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 853, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/framework.py", line 943, in _reemit
    custom_handler(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/tempo_k8s/v1/charm_tracing.py", line 735, in wrapped_function
    return callable(*args, **kwargs)  # type: ignore
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/postgresql_k8s/v0/postgresql_tls.py", line 115, in _on_tls_relation_joined
    self._request_certificate(None)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/tempo_k8s/v1/charm_tracing.py", line 735, in wrapped_function
    return callable(*args, **kwargs)  # type: ignore
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/lib/charms/postgresql_k8s/v0/postgresql_tls.py", line 98, in _request_certificate
    if self.charm.model.get_relation(TLS_RELATION):
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/model.py", line 250, in get_relation
    return self.relations._get_unique(relation_name, relation_id)
  File "/var/lib/juju/agents/unit-postgresql-k8s-2/charm/venv/ops/model.py", line 949, in _get_unique
    raise TooManyRelatedAppsError(relation_name, num_related, 1)
ops.model.TooManyRelatedAppsError: Too many remote applications on certificates (2 > 1)

Patroni logs:
2024-09-24 19:17:35 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:17:45 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:16:55 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:17:05 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:17:15 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:17:24 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:16:15 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:16:25 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:16:35 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)
2024-09-24 19:16:45 UTC [1223]: INFO: no action. I am (postgresql-k8s-2), a secondary, and following a leader (postgresql-k8s-0)

Just for the history: we have made an intensive testing of steps-to-reproduce on localhost (even stressing 100% CPU). Cannot reproduce with Juju CLI (the interface limits works well). It looks like it is solely terraform-provider-juju issue.
@dragomirp should we keep this open? IMHO, resolve after CS team confirmation. Tnx!

Upstream issue https://github.com/juju/terraform-provider-juju/issues/608 is resolved with the fix to become available in Juju 3.6.1.


Camera Modification + SBFanClub updates

What's new:

Added SBTier
Updates to SBFanClub
Updates to SBClient+FanClub

:+1:


fix: early discovery of missing deps, fix #7333

Description
Related https://github.com/vitejs/vite/pull/7345
This PR moves the rewrite of URL imports to happen after the eager transformation of imported modules. These rewrites need to know if es interop is needed, so awaiting for them is blocked by pre-bundling processing. After this PR, missing dependencies can be discovered in batch avoiding full reloads. This also allows Vite to process more requests while dependencies are being pre-bundled on cold start.
#7333 worked fine with beta-0 because invalidation wasn't being handled properly, with beta-2 and a file like:
import format from 'date-fns/format/index.js';
import getYear from 'date-fns/getYear/index.js';
import getMonth from 'date-fns/getMonth/index.js';
import getQuarter from 'date-fns/getQuarter/index.js';
import getDay from 'date-fns/getDay/index.js';
import isAfter from 'date-fns/isAfter/index.js';
import isBefore from 'date-fns/isBefore/index.js';
import isEqual from 'date-fns/isEqual/index.js';

When each import was analyzed, the new dep will be discovered but import analysis will be blocked until we know if it needs es-interop... and because a full reload was needed, each new import in this file will end up generating a full reload.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Merging as this is still conceptually part of the work in https://github.com/vitejs/vite/pull/6758, so we can release a new patch and continue testing during the beta


Add comments according to Google Code Rules

All core methods, add annotations in Python Google style
Different classes add different explanations
There are still some non core files inside that have not been annotated. If necessary, they will be added later

能够合并过去么


v06b4 wrong (album) artist for file source media

situation :
configure remote file system using the shell_command and automation as listed in https://github.com/music-assistant/hass-music-assistant/issues/71
folders on remote system have a naming convention : [artist] / [album title]
result :
music assistant displays wrong (album) artist when playing the file.
home assistant itself does display the correct artist when playing the same file using a mediaplayer.

I did notice that the file itself had the artist set as 'contributing artist' and 'album artist' was empty ... this may be a factor.

Album artist ID3 tag MUST be set for this to work. Folders are only used to retrieve any additional metadata such as images or info from nfo files for the ID3 tags are leading.

looks like I've got a lot of work to do then ...
Is it possible to assume 'contributing artist' = 'album artist' when the latter isn't set ?
At the very least it should show 'undefined' or 'missing' instead of a the wrong artist ('caro emerald' ?)

No that would be very bad... consider a collection album (e.g. Hitzone etc) where you have tracks of multiple artists.
A track has one or more artists (=contributing artist track)
A track may belong to an album
An album has one or more album artists
If we're scanning for songs on disk we read the ID3 tags. If we album tag is set but the albumartist tag is not we now fallback to various artists and print a note in the log.

BTW: Musicbrainz Picard is a great and free tool to rapidly fix the ID3 tags

That makes sense. I forget that the mp3 file itself also needs the album info inside of it.
I've got MP3 tag, which is really useful when automagically fixing tag issues such as this, because it can copy info from filename as well as things like musicbrainz and freedb.  The problem is that it can be very hard to identify missing info if the mediaplayers appear to show the 'correct' info. There also appears to be a few versions of tag-info within mp3 files themselves.

fixed small detail that changing the album artist in the ID3 tag will now overwrite the db details

I can't find any albums with the wrong artist in my collection at the moment.
In part because I've fixed the offending files myself (mp3's were missing album artist tags).
The one album with 'unknown' as an artist in the album overview is correct as I don't know the artist ...


911-911 needs to handle keypresses

this is only an issue during the warning message
should probably start the warning over to reduce key pounders

maybe invalid should go directly to busy? or dialtone? Prevent key pounders from getting to 911 connection. The current behavior is just to error, which gives no feedback to user, legit user doesn't know if call is going through or what.
Going to busy gives feedback and lets caller decide to try again.


Serializing multiple arguments when applying distributed action results in segfault

Expected Behavior
Call a remote action regardless of the number of parameters as long as they are all serializable.
Actual Behavior
A very specific combination of parameters seems to systematically result in a segfault in a distributed environment.
Steps to Reproduce the Problem
I have a reproducible example. Configuring it with cmake . -DSINGLE_ARG=OFF -DDEFAULT_CONSTRUCTIBLE=OFF -DVECTOR_2ND_ARG=ON will result in a segfault when executed (tested on Cori haswell  and Perlmutter CPU). Any other options combination will work.
Specifications

HPX Version: 1.8.1 (compiled with -DHPX_WITH_PARCELPORT_TCP=OFF -DHPX_WITH_PARCELPORT_MPI=ON)
Platform (compiler, OS):

Cori, gcc 11.2.0, cray-mpich 7.7.19
Perlmutter, gcc 11.2.0, cray-mpich 8.1.17

FWIW, I have the problem reproduced. It is not caused by the action being called with two arguments, but by the fact that one of the arguments is non-default constructible. The bug manifests itself in cases where one (some) of the arguments are non-default constructible, while the others are default constructible. I hope to have a fix for this available soon.


Fixed outdated info

C++98 wasn't the standard for a long time. gnu++14 is the current standard and this pull request corrects that.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Please state a source for your changes

Here's the source:
https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Standards.html#Standards

The default, if no C++ language dialect options are given, is -std=gnu++14.

@hegdenischay I believe @thecodingaviator meant for you to properly cite the source in the article.
View Free Code Camp's citation policy

Okay, will do.
I thought that it wasn't necessary since the original didn't cite anything.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Closure Compiler incompatible with TypeScript method decorators

It appears that the use of method decorators from TypeScript fall flat on their face when run through Closure Compiler due to the use of function names being passed as strings.
I have an AuthStoreImpl class that declares a getUser method that has an @autoSubscribe decorator. TypeScript compiles this by adding this after the class definition:
__decorate([
       resub_1.autoSubscribe
], AuthStoreImpl.prototype, "getUser", null);

Obviously I can use @nocompile to prevent any file that uses a decorator to remain untouched, but that kind of defeats the purpose. What I would really love to do is to add an annotation to the getUser method to prevent renaming of just that method, but I was disappointed to read that there's no plans to allow this granularity.
If I may ask, what's the reason behind the decision to not allow inline annotations on specific symbols? It seems this would empower users to work around a lot of issues with Closure Compiler being to aggressive, especially when those users don't have complete control over their code (as is the case with code compiled by TypeScript).

Can you provide more detail on how Closure Compiler failed on the TypeScript output?

Sorry, should've provided this initially.
The issue here is that Closure Compiler renamed my getUser() method to d() or something of the sort, but because it doesn't modify strings, it left TypeScript's decorator to reference "getUser". Deep inside the __decorate stack trace, it tries to find the "getUser" function and no such function exists.

Closure-compiler can rename string references safely now with goog.reflect.objectProperty:
__decorate([
       resub_1.autoSubscribe
], AuthStoreImpl.prototype,
goog.reflect.objectProperty("getUser", AuthStoreImpl.prototype),
null);

That should safely compile.

@mprobst probably knows of a good way to handle this.

@evmar is the expert. We're maintaining a tool called tsickle (http://github.com/angular/tsickle) that rewrites TypeScript output to be Closure compatible (including type annotations, actually). I'm not sure if we have something to fix this renaming issue with method decorators specifically, but it shouldn't be too hard to fix, I guess?
Alternatively, you could also ask the MS folks to change their emit to avoid quoting the method, e.g.
AuthStoreImpl.prototype.getUser = __decorate([
       resub_1.autoSubscribe
], AuthStoreImpl.prototype.getUser, null);

I would love if the decorator didn't use strings, and I'll likely also reach out to the TS team as well.
As for using goog.reflect, I don't control TypeScript's output, so I have no opportunity to implement that solution. If tsickle could do that, it'd be great. I suppose I'd have to reach out to those folks to support decorators then?

@btraut please do file an issue against tsickle. Depending on the response from MS, this is something we should do.

Posted over on the TS issues as well:
https://github.com/Microsoft/TypeScript/issues/11435

@btraut One option available to you out of the box is to write a custom __decorate helper that calls goog.reflect and use that one instead.

Sounds like the function name, "getUser" in my case eventually gets passed into Object.defineProperty, and must be a string as such.

@rbuckton the problem is that goog.reflect.objectProperty must take a string literal as its first input, it's a compiler intrinsic.

Ah, I see.

I'm going to close this issue as it doesn't appear to be anything the compiler itself can handle.

Thanks for the help, @ChadKillingsworth.


Replace deprecated / async-unsafe lifecycles

Replace componentWillMount, componentWillReceiveProps, and componentWillUpdate with async-safe lifecycles in advance of 16.4 deprecation warnings. Use react-lifecycles-compat to ensure backwards compatibility.
Relates to reactjs/rfcs/pull/6
In-progress documentation available at reactjs/reactjs.org/pull/587 and reactjs/reactjs.org/pull/596
RFC at https://github.com/reactjs/rfcs/blob/master/text/0006-static-lifecycle-methods.md

FYI @TrySound, I'm picking this up for the weekend. Do you have any major structural changes in progress? And if not, could you hold off until I'm done with this upgrade?

Awesome. No, I don't have. Only rollup,  but I'm sure it's not related.

Sweet! Thanks for confirming. 👍


Select this taxon button should only show up when navigated through suggestions

Describe the bug
Right now, the "select this taxon" button is showing up when i navigate to taxon detail pages outside of suggestions.
To Reproduce
Steps to reproduce the behavior:

Make sure you are logged in.
Tap the explore button in the nav bar
Tap any species to go to its taxon detail screen
scroll to "taxonomy" and click any taxon
See "Select this taxon" button

This is also happening if i navigate to a taxon detail page from other places in explore or from obs detail and then click on another taxon under taxonomy.
Expected behavior
The "select this taxon" button should only appear when a user is logged in and has navigated to a taxon detail page inside of the suggestions flow, accessed through the "suggest id" button on obs detail or the obs create flow.
Context (please complete the following information):

Device: iPhone 13 Pro
OS: iOS 17.5.1
App version: 0.36.0 (101)

I don't think this is quite accurate -- we also want the "Select this Taxon" button to show up if a user comes through TaxonSearch, right? There's at least one scenario where they can land on TaxonSearch without landing on Suggestions:

create an obs with no evidence
land on obs edit
tap "Add an ID"
land on Taxon Search, not Suggestions

from there, if a user taps into TaxonDetails, I assume they would get stuck outside of the obs create flow the same way they could from Suggestions, so we should show the button there as well.

I guess in my head, this is still "from suggestions" because the user clicked add an id inside of obs edit.


Ratify 1.0 scale target

What would you like to be added?
This issue is to discuss the Ratify 1.0 scale target.

What is the current scale?
What do we want to achieve for Ratify 1.0 release?

Anything else you would like to add?
No response
Are you willing to submit PRs to contribute to this feature?

[ ] Yes, I am willing to implement it.

deliverable: publish doc about current scale

document published here: https://ratify.dev/docs/1.0/reference/performance


Load the data for each station into its own hash #2

This pull request is for #2 .
But I have a question that: If I comment out pipeline.geoadd(...), then the Flask app will not be able to search the stations. Would it be the expected one? Thanks!

Thanks, @oktak!  If you are a member of our Discord (https://discord.com/invite/ueQwKUh5Z3), please drop your handle here and we will give you the Hacktoberfest 2021 role :slightly_smiling_face: and if you'd like a shout out on Twitter, drop your handle!

I see. Thank you for the explanation!
My Twitter handle is @ssms54 . Let's celebrate :smile: :partying_face:


image and video alignments do not save in quill.

Hi,
Thank you for making this library.   I have an issue with image and video alignments.
When I click on an image or video I inserted in the quill editor (I am using react-quill), I can align left, right, and center using the resizer box provided by quill-blot-formatter.  But, as soon as I remove the editor and display the content in <div class="ql-editor" dangerouslySetInnerHTML={{ __html: content }} />, all the contents, images and videos are there but alignments are ignored.
Could you tell me what I may be missing?
or at least can I hide the alignment boxes in quill-blot-formatter so that users can just use the alignment options in the quill-toolbar?
Thanks

For now, I have hidden the alignment boxes with below:
.blot-formatter__toolbar-button {   display: none !important; }

Same issue here.  From your snippet, it looks like you are using react quill as well.
From what I can tell the onChange event doesn't fire when you click one of the hovering alignment buttons.  But it does fire when you drag the resize handle.  So if you change the alignment then resize or add some text, the alignment will be saved.
I think it has something to do with the AlignAction updating the quill state in a non-standard way.  I'm still poking around to see I can find the root.

Same issue. And I find a solution here.

Hello all,
I'm using quill image resize module to resize the image and for image alignment but the thing is that I'm getting width and height values of image in image tag but not the alignment style. I mean if I change the height and width of the image along with the alignment then only height and width attribute are showing in the image tag not the alignment style of the image. Can anyone please help me out here, to how to get those alignment style within the image tag so that when I use that html created by the quill and use it with inner-html I'll get same look as I've created using editor. BDW I'm using Angular - 8.
Please help me out here. I'm stuck here.

By default the Image format of quill does not allow alignments. They are applied using the class attribute and by default alt, height and width attributes are allowed. To solve the issue, the default Image class can be extended as follows:
import Image from 'quill/formats/image';

const ATTRIBUTES = [
    'alt',
    'height',
    'width',
    'class' // this will allow the class attribute on the image tag
]

export default class CustomImage extends Image {
    static formats(domNode) {
        return ATTRIBUTES.reduce(function(formats, attribute) {
            if (domNode.hasAttribute(attribute)) {
                formats[attribute] = domNode.getAttribute(attribute);
            }
            return formats;
        }, {});
    }
    format(name, value) {
        if (ATTRIBUTES.indexOf(name) > -1) {
            if (value) {
                this.domNode.setAttribute(name, value);
            } else {
                this.domNode.removeAttribute(name);
            }
        } else {
            super.format(name, value);
        }
    }
}

And then this format can be registered instead of the default one:

Quill.register({
     // ... other formats
    'formats/image': CustomImage
});

Using the code above I had to make some changes to make quill accept it and register.
`
import Quill from 'quill';
const Image = Quill.import('formats/image'); // Had to get the class this way, instead of module imports, so that quill could register it without errors
const ATTRIBUTES = [
'alt',
'height',
'width',
'class', // this will allow the class attribute on the image tag
'style', // Had to add this line because the styling was inlined
];
class CustomImage extends Image {
static formats(domNode) {
return ATTRIBUTES.reduce((formats, attribute) => {
const copy = { ...formats };
  if (domNode.hasAttribute(attribute)) {
    copy[attribute] = domNode.getAttribute(attribute);
  }

  return copy;
}, {});

}
format(name, value) {
if (ATTRIBUTES.indexOf(name) > -1) {
if (value) {
this.domNode.setAttribute(name, value);
} else {
this.domNode.removeAttribute(name);
}
} else {
super.format(name, value);
}
}
}
export default CustomImage;`

Using the code above I had to make some changes to make quill accept it and register.
import Quill from 'quill';

const Image = Quill.import('formats/image'); // Had to get the class this way, instead of ES6 imports, so that quill could register it without errors

const ATTRIBUTES = [
  'alt',
  'height',
  'width',
  'class',
  'style', // Had to add this line because the style was inlined
];

class CustomImage extends Image {
  static formats(domNode) {
    return ATTRIBUTES.reduce((formats, attribute) => {
      const copy = { ...formats };

      if (domNode.hasAttribute(attribute)) {
        copy[attribute] = domNode.getAttribute(attribute);
      }

      return copy;
    }, {});
  }

  format(name, value) {
    if (ATTRIBUTES.indexOf(name) > -1) {
      if (value) {
        this.domNode.setAttribute(name, value);
      } else {
        this.domNode.removeAttribute(name);
      }
    } else {
      super.format(name, value);
    }
  }
}

export default CustomImage;

And them register it
Quill.register({
     // ... other formats
    'formats/image': CustomImage
});

Thanks miczed for pointing out the way

@nitink66 react-quill exposes Quill from their interface, just use import ReactQuill, {Quill} from 'react-quill' and it should work

In my case, to make it work, I have to add formats configs as well.
`
let quill = new Quill(element, {
...
formats : [... "height", "width", "class", "style"]
}
`

Any chance this could get fixed please?

Getting an Angular project to work required a couple of extra lines as Typescript needed a declaration. Hope this helps others with similar issues.
import Quill from 'quill';
const ImageBase = Quill.import('formats/image');

const ATTRIBUTES = [
  'alt',
  'height',
  'width',
  'style' // This is the added difference that needs to be saved properly
];

export default class CustomImage extends ImageBase {
  declare domNode: any; // Needed declaration for Typescript

  static formats(domNode) {
    return ATTRIBUTES.reduce((formats, attribute) => {
      const copy = { ...formats };

      if (domNode.hasAttribute(attribute)) {
        copy[attribute] = domNode.getAttribute(attribute);
      }

      return copy;
    }, {});
  }

  format(name, value) {
    if (ATTRIBUTES.indexOf(name) > -1) {
      if (value) {
        this.domNode.setAttribute(name, value);
      } else {
        this.domNode.removeAttribute(name);
      }
    } else {
      super.format(name, value);
    }
  }
}

Quill.register('formats/image', CustomImage);

In my case, to make it work, I have to add formats configs as well.
let quill = new Quill(element, {
...
formats : [... "height", "width", "class", "style"]
}

This worked for me! Thanks from the future =D

Thanks for this. It works great for the alignment of images but the alignment of videos still doesn't seem to register though. Any suggestion for saving the alignments of videos/iframes?

Getting an Angular project to work required a couple of extra lines as Typescript needed a declaration. Hope this helps others with similar issues.
import Quill from 'quill';
const ImageBase = Quill.import('formats/image');

const ATTRIBUTES = [
  'alt',
  'height',
  'width',
  'style' // This is the added difference that needs to be saved properly
];

export default class CustomImage extends ImageBase {
  declare domNode: any; // Needed declaration for Typescript

  static formats(domNode) {
    return ATTRIBUTES.reduce((formats, attribute) => {
      const copy = { ...formats };

      if (domNode.hasAttribute(attribute)) {
        copy[attribute] = domNode.getAttribute(attribute);
      }

      return copy;
    }, {});
  }

  format(name, value) {
    if (ATTRIBUTES.indexOf(name) > -1) {
      if (value) {
        this.domNode.setAttribute(name, value);
      } else {
        this.domNode.removeAttribute(name);
      }
    } else {
      super.format(name, value);
    }
  }
}

Quill.register('formats/image', CustomImage);

Thanks for this. It works great for the alignment of images but the alignment of videos still doesn't seem to register though. Any suggestion for saving the alignments of videos/iframes?

Getting an Angular project to work required a couple of extra lines as Typescript needed a declaration. Hope this helps others with similar issues.
import Quill from 'quill';
const ImageBase = Quill.import('formats/image');

const ATTRIBUTES = [
  'alt',
  'height',
  'width',
  'style' // This is the added difference that needs to be saved properly
];

export default class CustomImage extends ImageBase {
  declare domNode: any; // Needed declaration for Typescript

  static formats(domNode) {
    return ATTRIBUTES.reduce((formats, attribute) => {
      const copy = { ...formats };

      if (domNode.hasAttribute(attribute)) {
        copy[attribute] = domNode.getAttribute(attribute);
      }

      return copy;
    }, {});
  }

  format(name, value) {
    if (ATTRIBUTES.indexOf(name) > -1) {
      if (value) {
        this.domNode.setAttribute(name, value);
      } else {
        this.domNode.removeAttribute(name);
      }
    } else {
      super.format(name, value);
    }
  }
}

Quill.register('formats/image', CustomImage);

Resolved video issue. Replaced 'formats/image' with 'formats/video'


[tool_crash] ProcessException: No such file or directory Command: /home/felipegoes/snap/flutter/common/flutter/bin/cache/dart-sdk/bin/pub, OS error code: 2

Command
flutter doctor

Steps to Reproduce

...
...
...

Logs
ProcessException: No such file or directory Command: /home/felipegoes/snap/flutter/common/flutter/bin/cache/dart-sdk/bin/pub, OS error code: 2
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:390:33)
#1      Process.start (dart:io-patch/process_patch.dart:36:20)
#2      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:44:22)
#3      ErrorHandlingProcessManager.start.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:664:24)
#4      _run (package:flutter_tools/src/base/error_handling_io.dart:544:20)
#5      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:663:12)
#6      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:425:28)
#7      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:444:35)
#8      _DefaultPub.batch (package:flutter_tools/src/dart/pub.dart:283:34)
<asynchronous suspension>
#9      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:223:7)
<asynchronous suspension>
#10     PubDependencies.update (package:flutter_tools/src/flutter_cache.dart:121:5)
<asynchronous suspension>
#11     Cache.updateAll (package:flutter_tools/src/cache.dart:546:9)
<asynchronous suspension>
#12     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1143:7)
<asynchronous suspension>
#13     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1043:27)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#15     CommandRunner.runCommand (package:args/command_runner.dart:196:13)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)

[✓] Flutter (Channel stable, 2.2.1, on Linux, locale pt_BR.UTF-8)
    • Flutter version 2.2.1 at /home/felipegoes/snap/flutter/common/flutter
    • Framework revision 02c026b03c (4 months ago), 2021-05-27 12:24:44 -0700
    • Engine revision 0fdb562ac8
    • Dart version 2.13.1

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/felipegoes/Android/Sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /home/felipegoes/Android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /home/felipegoes/Android/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.60.2)
    • VS Code at /usr/share/code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 94.0.4606.61

! Doctor found issues in 1 category.

Flutter Application Metadata
No pubspec in working directory.

@AshcroftGamer
This looks like an issue with Flutter snap, please file an issue on https://github.com/canonical/flutter-snap/issues
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

@AshcroftGamer
This looks like an issue with Flutter snap, please file an issue on https://github.com/canonical/flutter-snap/issues
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Resolvi com o comando:
Flutter doctor - - force


is there a replyto option aswell in personalization?

No worries. I added the replyTo field in Email(). Everything else was already in it. Thanks anyways.

The V3 SendGrid endpoint this library calls does not have a reply-to option on personalizations; it's only available on the root email object.


Update Scylla Rust driver version to 0.8.1

Updates Scylla Rust driver version to the latest 0.8.1 in the CDC library and in printer and replicator applications.
Fixes some minor cargo clippy warnings related to the use of deprecated functions.

@piodul Can you please review this?


Remove the need to be added to the bakers list for looking at a shift admin

This is intended behavior


Update Hello India.py

Moved ''!'' from after to hello to after India to form grammatically correct sentence
What the program do ?

In what programming language it is written?

This pull request contains conflicts. Please fix it and reopen


fix: Return stateAction from sendOutboundAck

closes #418
Signed-off-by: Firas Qutishat<EMAIL_ADDRESS>

@fqutishat a bit more description would be helpful :).


C++: Tweak 1.23 change note

@hubwriter, @felicitymay

LGTM
It appears my review is not an "approving review".
I can't merge this.


feat: publish htsget deployment to NPM

The deploy directory should be published to NPM to support other applications that want to deploy htsget-rs using CDK.
A few changes/considerations for the current CDK stack:

[x] The stack should be converted to a construct.
[x] Allow the RustFunction to access code from crates.io rather than just locally compiling htsget-rs.
[ ] Ideally the user should be able to use typescript props to configure htsget-rs, rather than a TOML file.
[ ] There should be reasonable defaults for things like resolvers that consider AWS S3 access policies.

@mmalenic https://github.com/umccr/htsget-deploy published (have a quick peek at it whenever you have time) and seems to deploy fine in UoM demo right now.
There's only two more items to clear ☝🏻 to close this issue.


select rand(), rand(); will produce the same number.

Describe what's wrong

run select rand() as a, rand() as b;, and a will always be equal to b, which is not as expected.
we expect that a should not always be equal to b.
How to reproduce
select rand() as a, rand() as b, a-b as diff;

sample result:
┌──────────a─┬──────────b─┬─diff─┐
│<PHONE_NUMBER> │<PHONE_NUMBER> │    0 │
└────────────┴────────────┴──────┘

┌─────────a─┬─────────b─┬─diff─┐
│ 248777950 │ 248777950 │    0 │
└───────────┴───────────┴──────┘

this is probably a feature, is it ?

https://fiddle.clickhouse.com/393b7a18-01de-466b-a6fb-75e26a2efeb7
clickhouse same behaviour

create random stream rd(
  k1 int default rand()%100,
  k2 int default rand()%100
) settings eps=0;

k1 will always be equal to k2

If you want to generate two random value during one row, you can SELECT rand(1), rand(2) - will output two different columns.

@leo-cai-timeplus, if this is not a issue, please label it as 'invalid', 'invalid' should be an existing label.


csource: strace-like comments

Multiple people complained that it's very difficult to understand what exactly a reproducer does. strace come up as an example of more readable output multiple times. We need to think if we can do something reasonably simple that will improve readability. The main issues are with:

flag values
struct field names, grouping of fields for a single struct
what addresses point where (will it be better to express pointers as base+offset?)
We could restructure the generated code, or at least generate some comments.

From #176: Print -1 instead of 0xffffffffffffffff for signed types like fd.

Ideally, what we do should replace the need for this custom OpenBSD hook that annotates mknod calls:
https://github.com/google/syzkaller/blob/340ea5301c27db4a3678f13acc430e04706a0cc6/sys/openbsd/init.go#L209-L220


Test for hardcoded credentials, CWE798

Tests all the strings for exposed secrets.
The thing was additionally tested on noise, to ensure that in 100MB of generated noise there are no false positives.
The test file, examples/exposed_secrets.py shows 4 leaked keys that are correctly detected, and 4 keys that should be ignored (e.g. human-constructed example keys).
Also leads to a pretty significant performance degradation of around 15% due to the use of every-string-scanning decorator. This is mostly because the decorator is slow, and seemingly unrelated to the implementation itself.
Closes #443

Thanks, @ericwb!
I didn't really spend a ton of time on writing the secret-detecting part overall, I just took the one from gitleaks, and modified it heavily (and mostly automatically) to be easier. But still sad that a few hours of my work were useless :(
Another problem, is that when I was looking through the existing plugins, I was not able to find any that do regex search over the complete files. So, if there is one, could you direct me towards it? And if there is none, I'm happy to just implement such functionality, probably also using it in 'weak_cryptographic_key' one, to avoid the string visitor.

@knyazer then in stealing an implementation from somewhere else where you did not own the copyright you were opening this project up to a severe issue by contributing that code.

Nope, I checked that the license is MIT, even included the original license in the file that I "borrowed"; And the modification is so heavy I don't think you can find more than two adjacent lines that would be unchanged. And all the "meaningful" content is modified quite a bit.
No worries, I am aware how copyrights work, but that's reasonable to assume that the average developer doesn't ;)


Assign the current slide animation to be only played after a run

Do this after mint presents the slide animation for the rest two position.

Implemented in #214


Use yaml.safe_dump instead of yaml.dump

The title says it all.

Current coverage is 77.07% (diff: 50.00%)

Merging #3059 into master will increase coverage by 0.10%

@@             master      #3059   diff @@
==========================================
  Files           430        430
  Lines         22017      22017
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          16945      16968    +23
+ Misses         5072       5049    -23
  Partials          0          0

Diff Coverage
File Path

•••••      50%
st2debug/st2debug/cmd/submit_debug_info.py

Powered by Codecov. Last update be8c2be...261faf1


[ci] Build strategy matrix using multiple java environments in the CI

(Please specify the module before the PR name: [core] ... or [flink] ...)
Purpose
(What is the purpose of the change, or the associated issue)
this pr closes #799
Tests
(List UT and IT cases to verify this change)
API and Format
(Does this change affect API or storage format)
Documentation
(Does this change introduce a new feature)

I recommend that each PR run CI checks for both JDK8 and JDK11.

Please take a look to the discussion in https://github.com/apache/incubator-paimon/pull/714

Hi @zhuangchong , maybe we can add a few jdk 11 tests in future.
But not now, our testing is still unstable and time-consuming. Consume my energy.

Hi @zhuangchong , maybe we can add a few jdk 11 tests in future. But not now, our testing is still unstable and time-consuming. Consume my energy.

OK, Thanks for your comments.


Do not use file(GLOB) to add files to build configuration

The use of CMake's file(GLOB) is highly discouraged for globbing source files to be added to a build target. The main reason being that CMake will not notice that files have been added/removed/renamed after the last configuration of the build tree and thus not automatically re-run. A developer must remember to manually run CMake again whenever such file change took place.
The basis_add_glob_target CMake function and related files/functions from my CMake BASIS project could be copied which indeed allows to glob for source files, but adds a custom target which ensures during each build run that the set of files matching the glob expression has not changed.

From the CMake documentation of file(GLOB):
Note: We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

We already discussed this indeed. That being said, globbing, or install directory, is super common to use for header files in many cmake projects. I agree that source files should be explicitly listed (and they are), since there are some conditional implementation of the public API defined in the headers due to the (non-)availability of certain dependencies.

I agree that source files should be explicitly listed (and they are)

I stand corrected, I do use globbing on the PolyData module source files. The other modules have explicit listing of the source files.

I can see the argument for using globbing for header files, but I still don't think it's good practice no matter how many examples there may be of projects wrongly using it. What speaks against it is what I commented in #13, that header files must be listed as target dependencies or else the target will not be rebuild when a header file is modified. But every source file that is declared as target dependency should be listed explicitly and not be globbed as also recommended by the CMake developers themselves. You can use some custom auxiliary target as I've done in CMake BASIS to work around the limitations in CMake and render globbing a valid option. But without this, globbing should be shamed...

PR #33 also gets rid of the .cc file glob in the PolyData module. Still remains the issue that generally header files are globed and missing from the target dependencies.


[Install] Update Conflicts

Many of these issues appeared due to my case-sensitive file-system. Here's a list:

/Onboarding -> /onboarding
#import <UIKit/UIkit.h> -> #import <UIKit/UIKit.h>
orta/cocoapods-check.git -> square/cocoapods-check.git
Remove unused Twitter* keys from Makefile

A big one that isn't in the list involves yoga; on the file-system it's Yoga, but since its a React sub-dep not sure how to address exactly.
#trivial

          1 Error

:no_entry_sign:
No CHANGELOG changes made

          1 Warning

:warning:
Needs testing on a Phone if change is non-trivial

  Generated by :no_entry_sign: Danger

Afraid the Yoga stuff is inside our deps, so your changes aren't propagated there - to address it, you'd need to edit all the React Native source files - can have a think about whether we can do that for rN core


finding: add fields for owasp top 10 qualifier (version & category)

Hello Team,
can you add owasp version & category to the finding information ?
Best,
Sal

What do you mean by "OWASP Version & Category"?

What do you mean by "OWASP Version & Category"?

We try to map a finding with OWASP TOP 10 (A1, A2 ...) but OWASP TOP 10 changes over the years (2013, 2017 ...) therefore we need a field to store the version and another to store category (at the moment we store this information in a finding tag)

We try to map a finding with OWASP TOP 10 (A1, A2 ...) but OWASP TOP 10 changes over the years (2013, 2017 ...) therefore we need a field to store the version and another to store category (at the moment we store this information in a finding tag)

I have some ideas to integrate that @valentijnscholten @saldam72  . Not by adding another column in Finding but as new tables.
Something like that:

I have some ideas to integrate that @valentijnscholten @saldam72  . Not by adding another column in Finding but as new tables.
Something like that:

I don't think we should complicate things and maybe focus on an easy to use 'meta data' solution so people can add their own key/value pairs to findings and other models. And query/report on them.
I think CVE and CWE are always needed to be readily available on the finding without having to join 2 extra tables.
@saldam72 did you consider using CWE to OWASP Top 10 mapping? Not sure if it is helpful as it would hide the original CWE, but wanted to make sure you saw it:

I don't think we should complicate things and maybe focus on an easy to use 'meta data' solution so people can add their own key/value pairs to findings and other models. And query/report on them.
I think CVE and CWE are always needed to be readily available on the finding without having to join 2 extra tables.
@saldam72 did you consider using CWE to OWASP Top 10 mapping? Not sure if it is helpful as it would hide the original CWE, but wanted to make sure you saw it:

Hello Team,
we have evaluated this solution but, for example, there are some CWE that should be mapped with A1 and they are not:

File: 22, 23, 73, 501, 610, 99, 96, 97. 243, 863, 631, 98
DoS - Threads: 400, 395, 476, 366, 705, 114, 404, 434, 730, 511, 821, 572, 185, 20, 372, 362
Code: 94, 95, 170, 676, 470, 382, 246, 506, 662, 113, 705, 473, 695, 126, 499, 573, 594, 86
Date: 200, 349, 612, 434 314, 471
Overflow: 190, 823
Log: 117

We are currently using two finding tags to store this information but we would prefer to have ad-hoc fields.
best,
Sal

There is also another pb with CWE with the current model. Sometimes a finding could be liked to more than one CWE. But our data model only allow one.


[SPARK-18212][SS][KAFKA] increase executor poll timeout

What changes were proposed in this pull request?
Increase poll timeout to try and address flaky test
How was this patch tested?
Ran existing unit tests

Test build #67990 has started for PR 15737 at commit a7f78d2.

Test build #67990 has finished for PR 15737 at commit a7f78d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67990/
Test PASSed.

Test build #67993 has started for PR 15737 at commit abce766.

Test build #67993 has finished for PR 15737 at commit abce766.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67993/
Test PASSed.

Merged build finished. Test PASSed.

Is there are reason to not change the user facing default?  Its failing our tests and it was failing for me for real with the current default.  When we are poling on the executors, the offsets should always be available, so I don't think increasing the timeout will hurt anything.

In most cases poll should be returning prefetched data from the buffer, not
waiting to talk to kafka over the network.
I could see increasing it a little bit, but I don't think it should be
increased to 10 seconds by default.  That's a really long time for a 1
second batch streaming job to silently wait, and the only thing you'll be
able to observe is that your job starts running slow for some unknown
reason.  At least with a smaller default any network or Kafka issues will
be obvious, and you can either diagnose them or tune upwards.
On Wed, Nov 2, 2016 at 1:06 PM, Michael Armbrust<EMAIL_ADDRESS>wrote:

Is there are reason to not change the user facing default? Its failing our
tests and it was failing for me for real with the current default. When we
are poling on the executors, the offsets should always be available, so I
don't think increasing the timeout will hurt anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/15737#issuecomment-257949815, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGAB6lwUbgWwgpfkaOgyimftB_nYvpUks5q6NFCgaJpZM4KnW2M
.

If we have prefetched the timeout should never kick in (I hope?), so we probably only care about the network here.  If my choices are "fail the job" or "wait a little bit longer", I don't see why you would ever chose "fail the job" for transient network issues.  If its not a transient issue, do you really think that knowing about it 9.5 seconds earlier outweighs that cost of false negatives?
I guess I don't understand what kind of Kafka issues you are optimizing for?

I don't think these cases are comparable, silently swallowing offset out of range is dropping data on the floor.  In contrast, networks are transiently flakey and we should be robust to that here like we are in all of the other parts of Spark.  Specifically, we should probably use spark.network.timeout if they haven't overridden this particular setting (which defaults to 120s).

Ok, I'll update the default in both places to use spark.network.timeout and leave the test config at 10 seconds

Test build #68016 has started for PR 15737 at commit 82a01d6.

Test build #68019 has started for PR 15737 at commit f1d4ff5.

Test build #68016 has finished for PR 15737 at commit 82a01d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68016/
Test PASSed.

Merged build finished. Test PASSed.

Test build #68019 has finished for PR 15737 at commit f1d4ff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68019/
Test PASSed.

Two comments:

I think sc.conf.getTimeAsSeconds("spark.network.timeout", "120s").toString is still wrong.  The suggestion is to make it the following:

val pollTimeoutMs = sourceOptions.getOrElse(
  "kafkaConsumer.pollTimeoutMs",
  sc.conf.getTimeAsMs("spark.network.timeout", "120s").toString).toLong

or maybe
val pollTimeoutMs = sourceOptions
  .get("kafkaConsumer.pollTimeoutMs")
  .map(_.toLong)
  .getOrElse(sc.conf.getTimeAsMs("spark.network.timeout", "120s"))

I'm not sure about the test changes.  Unless there is a good reason, I'd leave the tests alone and just use the default configuration there as well.

Good catch, I just mistakenly changed to AsMS in one place but not both.
On the test changes, do you want tests waiting up to 2 minutes * however many kafka calls are being made?  If so I can rip everything else out, just let me know.

Yeah, I'd rather just keep it the same.  Failures here should be uncommon.

Test build #68085 has started for PR 15737 at commit 0efd4e9.

Test build #68087 has started for PR 15737 at commit 3c9bd75.

Test build #68085 has finished for PR 15737 at commit 0efd4e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68085/
Test PASSed.

Merged build finished. Test PASSed.

Test build #68087 has finished for PR 15737 at commit 3c9bd75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68087/
Test PASSed.

Thanks, merging to master and 2.1!


--dns=foo means we specifically intend to fulfill a DNS challenge

This irks me, particularly because challenge selection is non-deterministic:
$ AWS_PROFILE=… AWS_REGION=us-east-1 lego -m … --dns=route53 --server=https://acme-stang.api.letsencrypt.org/directory -d foo.willglynn.com run
2016/02/11 19:48:49 [INFO][foo.willglynn.com] acme: Obtaining bundled SAN certificate
2016/02/11 19:48:49 [INFO][foo.willglynn.com] acme: Trying to solve HTTP-01
2016/02/11 19:48:49 [foo.willglynn.com] Could not obtain certificates
	[foo.willglynn.com] error presenting token: Could not start HTTP server for challenge -> listen tcp :80: bind: permission denied

If I say lego --dns=foo, I want lego to solve a DNS challenge. That's why I told it which provider I want it to use when solving a DNS challenge.
The commit below makes --dns=foo also imply -x http-01 -x tls-sni-01.

Yeah, this is probably better. People wouldn't go to the trouble of specifying DNS credentials if they could just use http or tls-sni challenges.

Could you add this to the documentation as part of your pull request? I agree that using DNS-01 probably means you want only DNS-01 but I want to make sure people know of this implicit exclude.

I rebased to master, re-worded the message in --help about --dns, and added a line to the README.

…oh. And now I changed another line in the README to drop the now-unnecessary --exclude directives.


goodWork

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 9bed242674e96422b771f9f9977e0bc8263844cb
https://deploy-preview-7571--docsdocker.netlify.com

Looks like this was opened accidentally


Traefik is getting hammered after blacklist additions

Maybe this is a bug in Traefik, but it only seems to happen after hitting the backlist.php endpoint.

Turns out it was due to the blacklist configuration, nothing about logpager itself.


iOS: Render label for collection reference asset

The core type for the collection reference asset defines a label as well as values. Currently the iOS CollectionAsset only renders values.
Update this asset to render the label to match the React reference asset

@hborawski Can you please assign this to me?


Remove powerpack and use squiggly heredocs

Squiggly heredoc syntax <<~ was introduced in ruby 2.3 to strip indentation equal to the least indented line.
This means we no longer need .strip_indent from powerpack gem.

Thanks


deliver_scheduled_messages: Don’t do_send_messages inside a transaction

do_send_messages has side effects outside the database and may not work reliably if its database effects are reordered by being inside a transaction.

The build failed due to a Puppeteer flake.


SystemUtils.java:58: Add language support for Timer hack...

The puzzle 1-8e9def92 from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/a547e89de390b499d28d29cdc21492f90613ef5e/src/main/java/net/shiruka/shiruka/util/SystemUtils.java#L58-L58
The puzzle was created by Hasan Demirtaş on 04-Apr-21.
Estimate: 5 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-8e9def92 has disappeared from the source code, that's why I closed this issue.


bug(gui-client/windows): wintun failing to create adapter

Describe the bug
The Client gets stuck signing in forever because wintun throws an error and connlib doesn't bubble it anywhere
To Reproduce
Not sure yet. I've seen it happen while restarting the app, as though the tunnel interface was not torn down fully
Expected behavior

Expected wintun to work
Expected errors to result in an error dialog or something that can reset the GUI to a usable state

Screenshots / Logs
{"time":"2024-04-24T14:18:06.7012667Z","target":"log","severity":"ERROR","logFile":"C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\wintun-0.4.0\\src\\log.rs","logLine":30,"logModulePath":"wintun::log","logTarget":"wintun::log","message":"WinTun: Timed out waiting for device query: The wait operation timed out. (Code 0x00000102)"}
{"time":"2024-04-24T14:18:06.7019883Z","target":"log","severity":"ERROR","logFile":"C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\wintun-0.4.0\\src\\log.rs","logLine":30,"logModulePath":"wintun::log","logTarget":"wintun::log","message":"WinTun: Failed to setup adapter (problem code: 0x1F, ntstatus: 0xC00002F0): The system cannot find the file specified. (Code 0x00000002)"}
{"time":"2024-04-24T14:18:06.745354Z","target":"firezone_tunnel::device_channel::tun_windows","logging.googleapis.com/sourceLocation":{"file":"connlib\\tunnel\\src\\device_channel\\tun_windows.rs","line":"70"},"severity":"ERROR","message":"wintun::Adapter::create failed, probably need admin powers: Failed to create adapter"}
{"time":"2024-04-24T14:18:06.7454742Z","target":"connlib_client_shared::eventloop","logging.googleapis.com/sourceLocation":{"file":"connlib\\clients\\shared\\src\\eventloop.rs","line":"199"},"severity":"WARNING","message":"Failed to set interface on tunnel: Failed to create adapter"}

Platform (please complete the following information)

Component (i.e. macOS client / Linux client / Gateway / Admin portal): Windows GUI Client
Firezone Version (e.g. 1.0.0 or N/A): Version 1.0.0 (d656cd5)
OS and version: (e.g. Ubuntu 22.04 or N/A): Windows 11
Deployment method: (e.g. Docker / Systemd / App Store or N/A): MSI from draft release

Additional context
Refs #4763
### Tasks
- [x] Ask wintun if the adapter already exists and log the result
- [x] Fault injection flag in the debug IPC service to replicate this
- [x] Can we retry with backoff?
- [ ] Can we get an `on_disconnect` or something to bubble this to the GUI?

Replicated just now on the Windows Server 2022 VM while testing #5292.

Replicated for a customer

Yeah it's probably a stale adapter somehow. The official wintun example code tries to open the adapter and then falls back on creating it, which doesn't make sense to me, but if the adapter dropping doesn't work right, I guess it makes sense. So I may just copy them as the first step and log if that branch gets hit https://github.com/nulldotblack/wintun/blob/8988a0469e58b2ee5da3cbf3170ba6afdf0e02a1/examples/basic.rs#L17-L20

I've gotten it to replicate but it will take longer to fix, the more I dig into it the more weird stuff I'm finding.


Adds config variables to seed packs

Also adds documentation for seed-video
Resolves https://github.com/helpscout/seed/issues/21


autoPatchelfHook contains unused code intended for optimisation

autoPatchelfHook has been modified to improve performance in https://github.com/NixOS/nixpkgs/pull/101142 but as far as I can tell, performance is still quadratic. Also, the current source code does not use the recently introduced associative array. It is only written to, hence the non increase in performance.
Pinging @DavHau could it be possible that your patch was not pushed in full, or only partial ? Looking at the current source code, does it look like the code you intended at the time ?
Pinging @aszlig for a second pair of eyes, and you feedback on the state of autoPatchelfHook.
Iff no-one works on this, I can submit a patch as we have abysmal performance on matlab which packages a tremendous amount of small shared objects.

No kidding. ~16 hours for autoPatchelf to run :sweat_smile:
[2021-12-04 14:32:55] automatically fixing dependencies for ELF files
...
[2021-12-05 06:12:03] autoPatchelfHook could not satisfy dependency libperl.so wanted by...
[2021-12-05 06:12:03] Add the missing dependencies to the build inputs or set ...

Sorry, didn't see this so far. The patch back then definitely increased the performance for me noticeable and it definitely fixes a quadratic issue whenever something is added to the cache. But that doesn't mean that the code is free of quadratic runtime issues. My PR possibly fixed only one of several issues.

@DavHau Thank you for your reply. It makes more sense now. My issue was with lookup time, so pretty orthogonal indeed.

I guess https://github.com/NixOS/nixpkgs/pull/149731 closes this issue :tada:. Thanks everyone for feedback and participation :pray:


Adding text/paragraph between images is very difficult

Ref: https://github.com/bigbinary/neeto-kb-web/issues/6166

Users wont be able to get the cursor between images due to the caption.
https://alan-george-mathews.neetorecord.com/watch/4a32ee1f-2ca1-4b90-b037-4265da87b8cd

Action items:

[ ] Enter in caption should add a new line after the image and add focus to the line
[ ] Using backspace should not focus on the caption (Can be done with up/down arrow or mouse clicks)

@AbhayVAshokan please check.
https://deepak-jose.neetorecord.com/admin/recordings/59f4e4a7-41a3-4bf7-af1c-7f34a4a6238b

@deepakjosp I agree. Pressing back space should take the user to the caption since it is the normal flow.


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit ee4fa90:
:clock10: Full build: the average full build time is 6 min(s) 45 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit ee4fa90:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md

[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature Proposal:  Integration with major exchanges to automatically renew siacoins

Problem
Buying and transferring siacoin for contracts is a hassle.  This hassle prevents greater adoption.
Particularly, when a contract is close to expiration, there is too much diligence needed to ensure adequate levels of SIA
Proposed Solution
Allow the user to input an exchange API key to make purchases and transfers to their wallet when their total passes a specified threshold.
Initial supported exchanges:
Bittrex & Poloniex
I will tackle this if approved by maintainers.

This unfortunately cannot be merged into a Nebulous Labs repo, because we do not support extending the UI with trusted features. Exchanges are a point of trust + centralization, and so first party apps are not allowed to integrate with them.
However, we fully support a third party making a plugin (in a non-Nebulous Labs repo) that can be distributed to the community. We can help you navigate the plugin system if you are interested in going that route, and would be happy to help you work with the API.
I hope this makes sense - I like your idea and think it would be valuable to the community, it just can't be added to a Nebulous Labs repo due to it's dependence on a centralized platform (the exchange).

@Kazanz I'd recommend you join the Sia Discord server if you're going to build a plugin; you will get real time help and advice there.  I believe the Devs will close this issue because in it's current form it will never be merged into the repo (it's still a great idea though).
Recommendation to devs: close


Invoke Aware interfaces on registrars from generated source code

After some thought we decided not to do this. It only saves a tiny amount of reflection at runtime.


A better way to modify of config between test

Currently, in __tests__/utils.test.ts, here the way to mock the config data and test the functions getSearchableFields in every tests:
  test('return list with one field', () => {
    restoreEnv = mockedEnv({ ...environment, SEARCHABLE_FIELDS: 'field' })
    const util = require('../src/util')
    mockGetSearchableFields = util.getSearchableFields()
    expect(mockGetSearchableFields).toMatchObject(['field'])
  })

It would be better to be able to mock the config just once and not in every test.

This should be do-able using the module mocking from jest, for the mocking of Meilisearch and the setup file in jest (example: jest setup and setup script).


Fix property accessor

fixes a reference/value bug.
Internal Review Page

@HaoK Please take one last look.

@user135711 Thank you for your help, once again! It's truly appreciated.


websocket: use uppercase method name only

fixes #448
get substring may happen in additional headers (i.e. Host: one)
so parsing will fail resulting in 400 return code (Bad request)

Merged. Thanks for reporting this and submitting this PR!


bleh

I can't get the branch ruleset to include those status checks

That doesn't work because some of them are skipped

And before you ask, I've already tried rustfmt (pull_request)

Oh wait this works, interesting

yeah, it looks like GH looks for the job ID
so "clippy", "rustfmt", "test" work

anyways, my test seems to have worked, so closing


E401: Invalid authentication token when using Azure Artifacts registry

Trying to setup a workflow for my Angular project. I have 1 private package which is hosted at Azure.
I created a PAT with read/write access in Azure and added it to the repository secrets. This is being used by another GitHub action, which requires a private NuGet package, and is working fine.
My current workflow looks like this (removing the .npmrc manually just to be sure it's completely from the action):
name: CI

on: [push]

jobs:
  build:

    runs-on: ubuntu-latest
    env:
      workingDirectory: ./wv8-finance-front-end

    steps:
    - uses: actions/checkout@v2
    - uses<EMAIL_ADDRESS>      with:
        registry-url: 'https://pkgs.dev.azure.com/woutervanacht/_packaging/Wv8-NuGet-Feed/npm/registry/'
        always-auth: 'true'
    # Remove custom npmrc
    - run: rm .npmrc
      working-directory: ${{env.workingDirectory}}
    # Skip post-install scripts here, as a malicious
    # script could steal NODE_AUTH_TOKEN.
    - run: npm install --ignore-scripts
      env:
        NODE_AUTH_TOKEN: ${{ secrets.AZURE_DEVOPS_PAT }}
      working-directory: ${{env.workingDirectory}}
    # `npm rebuild` will run all those post-install scripts for us.
    - run: npm rebuild && npm run prepare --if-present
      working-directory: ${{env.workingDirectory}}
    # build angular production configuration
    - run: npm run ng build --prod
      working-directory: ${{env.workingDirectory}}

The log (from npm install step):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/@angular/compiler-cli/node_modules/nan):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unable to authenticate, your authentication token seems to be invalid.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/@angular/cdk/node_modules/parse5):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unable to authenticate, your authentication token seems to be invalid.

npm ERR! code E401
npm ERR! Unable to authenticate, your authentication token seems to be invalid.
npm ERR! To correct this please trying logging in again with:
npm ERR!     npm login

I fixed it by setting the registry and authentication manually.
- run: echo "${{secrets.AZURE_AUTH}}" > ~/.npmrc
- run: npm config set @wv8:registry https://pkgs.dev.azure.com/woutervanacht/_packaging/Wv8-NuGet-Feed/npm/registry/

The secret are the login credentials based on the BASE64 encoded PAT, as suggested on the "Connect to feed" page in Azure DevOps (npm > other).

Hi, currently facing the same problem
In which step did you set the authentication. Could you provide the full solution here as well?
Thanks in advance


An error occurred relation "public.Farmer Table" does not exist

Hi, When I try to do a Count in Statistic view template for a table I created it says that when I try to run it. Not sure what the issue is. Farmer Table I created manually in Saltcorn
Thanks

This was a bug in the statistics plugin, fixed in 0.1.3

Thanks much Tom. Much appreciated


Step 4: Run the script; filename typo

Please change the command from:
python provision_blob.py
to:
python provision_rg.py
To run the file provision_rg.py, created in the tutorial.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5cf9ee4a-da91-9fcf-5f87-63672ecfc30c
Version Independent ID: a4e01885-e638-59b3-698c-6123b25b6260
Content: Provision a resource group using the Azure SDK for Python
Content Source: articles/python/azure-sdk-example-resource-group.md
Product: azure-python
GitHub Login: @kraigb
Microsoft Alias: kraigb

Thanks for pointing that out! Just a copy-paste error from one of the other articles I put together at the same time.

By the way, @codycodes, I'd love to hear any thoughts you have on this and the other articles on the Python Dev Center. I just overhauled a bunch of it and would appreciate any feedback.


Reason for having drop field in LockedBuffer?

Why does it set finalizer in https://github.com/awnumar/memguard/blame/v0.22.3/buffer.go#L31 to drop and not on b which newBuffer will return? It doesn't access b in closure inside SetFinalizer, and LockedBuffer contains only pointers, so if variable of type LockedBuffer goes out of scope, GC should collect it and call the finalizer?
Pinging @CAFxX because of https://github.com/awnumar/memguard/pull/27/files

It's because we keep a list of Buffers in the core package to be able to free them all at program termination. If we set the finalizer on the whole LockedBuffer then it would never trigger because of the reference in the global list.

As an additional argument, if we added it on the *LockedBuffer, and then the user tried to set a new finalizer, it would panic. If instead the user removed the finalizer (because they want to add a new one), it could lead to the data not being scrubbed. By adding the finalizer to a different object that is only referenced by an unexported field of LockedBuffer, both of these scenarios become virtually impossible without resorting to unsafe/reflect shenanigans. This is also one of the reasons why the standard library does the same thing e.g. for os.File.


Extra space and different theme in code block exports

I wanted to use Org mode to write my blog posts with Hugo, and I have some issues with how source code blocks are exported. If I use:
#+BEGIN_SRC python
  def main():
      pass
#+END_SRC

I get the following output:

  def main():
      pass

which is different from the output I get by using the same synthax I would use if I were writing in Markdown (in particular, graphically it is shifted to the right and with one line before the code, see image below with the three examples), which gives me:

def main():
    pass

Furthermore, with that approoach I could do something like:
{{< highlight python "linenos=inline,hl_lines=2 3" >}}
def main():
    i = 2
    j = 3
    pass
{{< / highlight >}}

which would yield the following:

1 def main():
2     i = 2
3     j = 3
4     pass

This is how the three examples appear graphically (note how the first code block is shifted below and to the right, compared to the second, one other thing I notice is the different theme... the second and third examples use the settings specified for Pygments, I believe):

I think that this might be due to how client side syntax highlighting (i.e. with highlight.js) have issue dealing with the newline after the opening "code" tag (https://github.com/jekyll/jekyll-help/issues/191).

For the moment I am using this (https://stackoverflow.com/questions/14946908/how-can-i-ignore-leading-and-trailing-linebreaks-within-an-html-code-block-usi) to work around the first line issue, in any case I don't think that it is a problem with goorgeous, but rather with how the highlighter deals with the newline.


Create checkout service interface

Checkout service should be using a Connection layer (based on axios library).
Each method of the service will contain specific types of parameters and return typed data, described in this issue on the bottom.
Custom cart Interfaces listed at the bottom of the issue.
It's assumed that the current context`s token is provided on request layer.
consistent error response should be described in separated issue and used globally
The list of proposed methods:
1. createOrder(ExtraTokenParam?): Order # an Order interface is taken from #54
2. createGuestOrder(CreateGuestOrderParam): Order # taken from #54
3. getDeepLinkOrder(GetDeeplinkParam): Order # taken from #54
4. payOrder(PayOrderParam): PayOrderResponse | HTTP_NO_CONTENT # described below

All the parameters should be converted into query string (or payload) just before sending a request.
Checkout Params converter was described here: #TODO
Available parameters:
interface ExtraTokenParam {
  token?: string
  name? : string
}

interface CreateGuestOrderParam { # some parts of Customer data model's interface. not sure if every key can be used
  email: string
  salutationId: string | uuid
  firstName: string,
  lastName: string,
  billingAddress: BillingAddress
  shippingAddress?: ShippingAddress # shippingAddress interface is taken from #54
}

interface GetDeeplinkParam {
  orderId: string | uuid
  accessCode: string
}

interface PayOrderParam {
  orderId: string | uuid
  finishUrl: string
}

The list of Checkout custom interfaces:
interface PayOrderResponse {
 paymentUrl: string
}

Method to endpoint map
1. createOrder() - POST /sales-channel-api/v{version}/checkout/order
2. createGuestOrder) - POST /sales-channel-api/v{version}/checkout/guest-order"
3. getDeepLinkOrder() - GET /sales-channel-api/v{version}/checkout/guest-order/{id}
4. payOrder()  - POST /sales-channel-api/v{version}/checkout/order/{orderId}/pay

points 1 and 2 are solved within #357

Closing the issue. createOrder() and createGuestOrder have been implemented.
Guest orders and payments will be implemented in separate tasks.
Associated:

#375
https://github.com/DivanteLtd/shopware-pwa/issues/481
https://github.com/DivanteLtd/shopware-pwa/issues/482


Settings search

Description of the new feature / enhancement
PowerToys is very powerful, but there are so many tools, I'm not always sure where the settings for them are. Could you add search functionality to settings?
Scenario when this would be used?
Search would be used when I don't know where in the settings a particular feature is configured
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/8060


RequirementMachine: Preserve sugared generic params in getSuperclassBound() and getConcreteType()

This was manifesting as module interfaces printing generic parameters
as τ_0_0 in some cases.
Note that the GSB has the same bug, so this test case will fail with
-requirement-machine=off. I don't plan on fixing the bug in the GSB
unless we need to.
Fixes rdar://problem/78977127.

@swift-ci Please smoke test


[theme] useThemeProps improvements and proper typings

[x] I have followed (at least) the PR section of the contributing guide.

Discussion in https://github.com/mui-org/material-ui/pull/24383#discussion_r556808179

Discussion in https://github.com/mui-org/material-ui/pull/24383#discussion_r556808179

@mnajdova  Do you create separate fork each PR or is it ok to use same?

@mnajdova  Do you create separate fork each PR or is it ok to use same?

Nevermind checked how everyone else works by creating separate branches from fork just xd.

Nevermind checked how everyone else works by creating separate branches from fork just xd.

Checked a bit more into this I tried to convert useThemeProps typescript

The problem can bigger I think because T can not be just a Theme but it should extend the Theme and getThemeProps does not have even a theme property. Bummer :(
If you pass any other object and not a theme line will break also.
const isRtl = theme.direction === 'rtl';
In conclusion, those types must extend Theme like not just have couple of properties

Checked a bit more into this I tried to convert useThemeProps typescript

The problem can bigger I think because T can not be just a Theme but it should extend the Theme and getThemeProps does not have even a theme property. Bummer :(
If you pass any other object and not a theme line will break also.
const isRtl = theme.direction === 'rtl';
In conclusion, those types must extend Theme like not just have couple of properties