Generated kotlinX code fails to serialize enums properly

I am facing a problem when generating kotlinX code from json schema.
Quicktype generates a custom serializer for each enum, looking like this:
@Serializable
enum class MessageFunction(val value: String) {
    Autp("AUTP"),
    Autq("AUTQ"),
    .
    .
    .

    companion object :
        KSerializer<MessageFunction> {
        override val descriptor: SerialDescriptor
            get() {
                return PrimitiveSerialDescriptor(
                    "MessageFunction",
                    PrimitiveKind.STRING
                )
            }

        override fun deserialize(decoder: Decoder): MessageFunction =
            when (val value = decoder.decodeString()) {
                "AUTP" -> Autp
                "AUTQ" -> Autq
                .
                .
                .
                else -> throw IllegalArgumentException("MessageFunction could not parse: $value")
            }

        override fun serialize(
            encoder: Encoder,
            value: MessageFunction
        ) {
            return encoder.encodeString(value.value)
        }
    }
}

When trying so serialize this object, this custom serializer never gets used. As a result, i get a json string containing the enum name, instead of the value, thus not conforming to my json schema.

I figured out that kotlinx needs to be explicitly told to use the quicktype generated serialized. Otherwise, is generates it own, and uses that one instead.
So, a solution would be to change the @Serializable annotation of any class that has custom serializers to look like this:
@Serializable(with = MyClass.Companion::class)

Kotlinx supports @SerialName for enums.
No need to generate custom serializers anymore.
It can be just
@Serializable
enum class MessageFunction(val value: String) {
    @SerialName("AUTP")
    Autp("AUTP"),

    @SerialName("AUTQ")
    Autq("AUTQ")
}

There's a PR open that addresses this issue: https://github.com/quicktype/quicktype/pull/1680.

Good afternoon,
Initial testing with a simple change to Kotlin.ts has borne some fruit in this matter.
Including a SerialName in the enum definitions has allowed all tests to pass in a piece of code I have that has a problem that originates with this issue.


Feature Add a new rest api to query instance host and ip information for query profile action in branch master

Proposed changes
Issue Number: close #18668
Problem summary
Query instance host ip and port
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[X] Has document been added or modified
[ ] Does it need to update dependencies
[X] Is this PR support rollback (If NO, please explain WHY)

Further comments

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.84 seconds
stream load tsv:          422 seconds loaded<PHONE_NUMBER>9 Bytes, about 169 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230516022113_clickbench_pr_144154.html

run buildall


Days not progressing when on a server

Hi! Thank you for this mod.
When on a server, the days don't progress and the timer resets throughout the night whether I sleep or not.
This happens to me only on a dedicated server but everything works fine in solo.
(I'm not using the realtime seasons)

I'm aware of some sync issues. It will most likely be fixed in the next version.

Pls check 1.2.6 version.

I checked the update, and the problem remains, unfortunately.

Do you have any errors in log file? Maybe server config has "Change season only after sleep" enabled.
You say you've tried both waiting, sleeping and using skiptime command while connected to the server and you are stuck on last day of the season no matter what?

I've just rechecked it on my server and singleplayer.
"Change season only after sleep" disabled - season changed.
"Change season only after sleep" enabled - sleeping - season changed.
"Change season only after sleep" enabled - not sleeping - season wasn't changed, day stucked at final day.
Everything is working as intended. Maybe you have some error in log file from other mod that prevents Seasons logic.


Structure is not generated (village, temple, etc)

I'm using locate command and go to this coordinates.
but village was not generated
https://imgur.com/a/ys2cjBJ
I'm not editing config

They do generate, but the locate command doesn't seem to be working properly. I'll have to look into it, thanks for the report.

I notice that the locate command dose not work.
I using Forge version is 2705,
but this mod created by forge of version is 2655.
The following images were I tried with each version
https://imgur.com/vpIzMD0
2655
https://imgur.com/7D5gOXR
2705
This bug seems to be caused by a different version.


[Question] Is there any reason why the tag latest is still v0.39.3 and the tag next is still v1.0.0-beta.1 for the gcr.io/kpt-dev/kpt container image?

Is there any reason why the tag latest is still v0.39.3 and the tag next is still v1.0.0-beta.1 for the gcr.io/kpt-dev/kpt container image?
They are both dated from June 2021.
I don't have the history in mind about v0.39.3, is it still a thing? I understand that in June 2021 you got a transition and that's maybe why you got these 2 tags latest and next. But I'm wondering if that's something that could be revisited now?
The context of my question is when we use gcr.io/kpt-dev/kpt in Cloud Build (example here), we are using a very old version v0.39.3. If using next same issue with an old version. Otherwise we could use a specific v1.0.0-beta.* to use recent versions, but that's not convenient in the context Cloud Build to update the version any time there is a new version.
Thoughts?

Thanks for raising this Mathieu.
I touched on this briefly https://github.com/GoogleContainerTools/kpt/issues/3134 but we have decided to move way from latest and next floating tags because kpt is still in beta and we run the risk of breaking downstream users with floating tags (ran into this problem with Istio packaging :) and learnt the hard way). It's good practice to use a fully qualified versions in the tags (especially in config domain). I know it's inconvenient but the benefits outweighs cost here.
We will revisit this closer to when we get v1.0 because the API will be fully stable then. Hope this answers the question.

Thanks @droot.
So if I understand this correctly:

latest will still point to v0.39.3, until v1.0 makes it out from beta, right?
next will still point to v1.0.0-beta.1 and not v1.0.0-beta.15, right? Not sure to get why here.

The context of this is again, is that in Cloud Build, any step is a container image, and the usual practice is not to use a specific version in order to use everytime the latest version. The side effect here, is that if you use gcr.io/kpt-dev/kpt (example here) you are actually using v0.39.3. And if I use next, I'm using v1.0.0-beta.1.
I understand the point with floating tags, but here I think this could generate some confusions.


Map Cluster Feature

This PR adds support for Leaflet.markercluster to search results. It extends SolrDocument to include a centroid method. It injects a "centroids" array into catalog#index json results. Includes model, catalog, and system tests to support feature
Fixes #28

Feature Screenshot


Text.strikethrough

Would you think it made sense for the prop name to be lineThrough instead, because it is the actual css value name?

Btw, let's add the new build only in master. It'll keep the PRs cleaner.


Provisioning continues even if openstack4j fails

For some reason, the plugin is not able to ssh to the machines. While investigating log, I've found following in jenkins.log:
Jan 18, 2016 10:15:18 AM jenkins.plugins.openstack.compute.JCloudsSlaveTemplate get
INFO: Provisioned: NovaServer{id=*masked*, name=openstacknode-161, image={id=*masked*, links=[{href=*masked*, rel=bookmark}]}, flavor=NovaFlavor{id=3, ephemeral=0, swap=0, rxtx_factor=1.0, is_public=true, links=[GenericLink{href=*masked*, rel=bookmark}],
}, status=ERROR, diskconfig=MANUAL, userId=*masked*, created=Mon Jan 18 10:13:03 EST 2016, updated=Mon Jan 18 10:15:18 EST 2016, tenantId=*masked*, hostId=*masked*, addresses=NovaAddresses{addresses={*masked*=[NovaAddress{address=*masked*, type=fixed, version=4, macaddr=*masked*,
}]},
}, powerstate=0, fault=org.openstack4j.openstack.compute.domain.NovaFault@70feb8d5, vmState=error, metadata={jenkins-instance=*masked*}}

This is related to 2.0-beta release of the plugin. CC'ing @olivergondza. So, as you can see there was a NovaFault related error - which is not exposed in the log and I guess that if status==ERROR, plugin should quit provisioning all the same.

Make the log more useful (best effort): https://github.com/gondor/openstack4j/pull/548

Make the log more useful (best effort): https://github.com/gondor/openstack4j/pull/548

Make the log more useful (best effort): https://github.com/gondor/openstack4j/pull/548

Fix proposed.


Compose record filter improvements

- Currently all the operators are shown in compose filters for example for a single value text type field. So let's try to hide the operators if they are not supported. For example the Contains and Not contains, if a field is a single value one, let's hide the operators and just shown them if a field is a multi value one.

[x] Hide the Greater than & Less than for not supported field types (ex: strings)

[x] Try to implement a new operator called Between or Range which will be only used for displaying a number values in a given range.  - server

[x] Try to implement a new operator called Between or Range which will be only used for displaying a number values in a given range.  - UI

[x] Try to implement a new operator called Between or Range which will be only used for displaying a date values in a given range(?maybe)  - server [It will be supported by server alongside]

[x] Try to implement a new operator called Between or Range which will be only used for displaying a date values in a given range(?maybe)  - UI

[x] Improve the error message when something is not supported. For example currently In operator is not supported on a single value and the error message is just saying Could not load record list: unsupported IN operator, so let's improve this so it would be saying Could not load record list: unsupported IN operator on a single value field.

[x]  Hide Contains and Not contains if a field is a single value one, show them if a field is a multi value one.

Thanks, I was bitten by this

@Fajfa https://github.com/cortezaproject/corteza/pull/713

Changelog
What changed

Greater than & Less than filter operators are hidden for field type with string, emails and URLs
Contains and Not contains filter operators are hidden for fields with single value
Contains and Not contains filter operators appear on fields with multi-value configured

Why did it change

To prevent users from using filter operators that are not supported for certain field types

How did it change

Updated the operators list configuration in the record list filter component with Greater than & Less than filter operators hidden from string types.
Updated the operators list configuration in the record list filter component with Contains and Not contains hidden for field types with non multi value

Added CL

Server changes branch ref: 2022.9.x-ql-between-comparision

BE still has some issues, working on it.

Fixed server, and pushed to branch!

Tested and confirming that this is finally working in the way it is supposed to. Now the only thing left is the CL entry.

Added:
• What was added
-- Added BETWEEN and NOT BETWEEN operator support for single value fields(number and date-time record fields)
• Why was it added
-- To extend record filtering support for range filtering of numeric and date-time for single value field.

Added CL


How to run TTT example?

If you chose a blank issue template to ask a general question about LearnLib, please consider using the Discussions page instead.
Hi there.
i'm trying to execute TTT algorithm demo.
from https://github.com/LearnLib/learnlib-ttt
so i couldn't execute this TTT algorithm demo.
Can you show the example?

git clone https://github.com/LearnLib/learnlib-ttt.git
cd learnlib-ttt/experiments

sudo apt install default-jdk
sudo apt-get install maven
apt-get install gnuplot -y

./run.sh
./plot-results.sh

the ./run.sh result : there is no results folder after run ./run.sh
so ./plot-results.sh cannot find results.

Closed in favor of #124


react-native run-ios fails

I have been looking for a long time for a react-native midi library, thank you for creating this project!
Issue:
After npm install and pod install, my run-ios build fails with the following error:
** BUILD FAILED **

The following build commands failed:
	SwiftEmitModule normal x86_64 Emitting\ module\ for\ midival_react_native (in target 'midival-react-native' from project 'Pods')
(1 failure)

When building the project in XCode, I got the following specified errors in the ReactNative.swift file:
- line 23: Only classes that inherit from NSObject can be declared @objc
- line 24: Cannot find type 'RCTEventEmitter' in scope
- line 28: Method does not override any method from its superclass
- line 33: Value of type 'Midival' has no member 'sendEvent'
- line 39: Method does not override any method from its superclass

Versions:

React Native 0.70.3
XCode 14.0.1
midival/core 0.0.17
midival/react-native 0.0.2

I would be happy to contribute, but unfortunately don't have any experience in swift or objective-c.

solved:
In the npm package, a line is missing in ReactNative-Bridging-Header.h:
#import <React/RCTEventEmitter.h>
The line is present in the github repo.
Build succeeds after adding the line manually in XCode -> Pods -> Development Pods -> midival-react-native -> ReactNative-Bridging-Header.h

I ran into the same issue. I was thinking to use or write my own library because it seem as if this issue is still not addressed and is an easy fix. I was thinking maybe the project was dead


feat: add verifier capability

Summary of Changes
The chanegs in the PR add Verifier capability into Aries Mobile Agent according to the design document provided here: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/649
The PR is still under the active development (we are testing the workflow, doing code refacoring, writing tests for new components)  but we decided to open it now to start the review process ( gahter feedback). (the branch is based on the main).
Overview of key changes:

Now user can enable verifier capability in the developer settings. Using this capability Verifier can request data from another phone via two flos:

Verifier generate QR containing request which can be scanned and replied by any other party (conenctionless case).
Verifier sends request through the already established connection to a specific user.

A verifier can see the history of used proof request tempaltes.
Connection chat evaluated to show the history of events between parties (credentials and proofs) in addition to sent messages.
Design of Contact List was changed to be more generic (previously it was tied to the chat functionality)
We added an ability to create connection invitations (by default. the feature is hidden under developer options) in order to test proof request flow through the established connection.
Important: The interface of OCA bundle resolver was change in order to add support for request templates and shared proof. Now it's credential agnostic. It's breaking change but I see that it was broken in some recent PR as well.

Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@hyperledger/aries-mobile-agent-react-native-committers
Is there any feedback on this PR? Has someone started looking into it?

Thanks for the changes. LGTM. Just need to fix the merge conflicts and @bryce-mcmath's change.

Merged

@jcdrouin21 @bryce-mcmath I believe you requested changes so this PR will need your approval to move fwd.


Add ratpack test

@hydra1983 Thanks for your pull request. I have merged it and published the result. It looks pretty good comparing with servlet container based frameworks.

Thank you :D


Need some more control over scrollSpy

My issue is that scrollSpy only triggers when the element reaches the top of the window, but I would actually like to trigger it when the top of the element is at 50% of the window height. This makes more sense to me as the element is now visible to the user. A separate scrollSpy offset would do the trick.

Wouldn't it be possible to set the offset dynamically as you scroll?
i.e calculate the center of the window, and set that as the offset?

I had a similar issue and solved it by removing the spy functionality completely from my <Link> elements and introduced <Waypoint> elements instead from the wonderful react-waypoint library.
That way I could still keep the smooth scrolling functionality of react-scroll that will scroll to my elements that are wrapped with <Waypoint> with offsets of 40%, in turn this will trigger the waypoint onEnter function, thus replacing spy and onSetActive from this lib.


Change structure of documentation

@dbarrosop, take a look at this and see what you think. With this setup I don't think any additional changes to the structure will be needed.
At least for a while. :)
I will start to write some parts of the intro tutorial as well.

I agree, looks really good. Merging :)


run ansible-lint on all playbooks and clean issues

Is your feature request related to a problem? Please describe.
ansible-lint will help clean up the playbooks, run it and fix all issues
Describe the solution you'd like
Describe alternatives you've considered
Additional context

@lwilson rather than running the default of "all tests" should we just do a subset of the tests?
ansible-lint -t bug,readability,safety example.yaml
I'm thinking we currently want to skip the warnings for helm and other shell commands until we have modules for all of those.

@j0hnL are you thinking we modify our current workflow?

Are we currently running the default lint command? I think we should consider which tests we need

@j0hnL We are currently running the default ansible-lint and excluding the shell command checks (-x 305):
https://github.com/dellhpc/omnia/blob/devel/.github/workflows/ansible-lint.yml

are the following directory name changes okay:

computeGPU  to computegpu
slurm-* to slurm_

@araji I think that will be fine for now. Just FYI, those directory names will likely go away with the code refactor (#139).

We're now passing the ansible lint check, thanks to recent PRs. Closing this issue.


[Botskills] Make SkillHostEndpoint compatible with Azure Gov

Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[ ] I have updated related documentation

Promoted and merged in MS.


Robohash discrepancies

https://github.com/BitShares/bitshares/issues/1335
Also see: https://bitsharestalk.org/index.php?topic=13747.msg179032#msg179032

Fixed by svk


parse mbox messages in utf-8, see #428

fixes #428
I expect the message about the time delta offsets is message specific and not breaking the collec_mail script in general. Can you confirm?

It did break the script because it did not produce a csv of the list - but am running it again now to verify.


Doesn't build on rust 1.50

Tried installing with cargo install toastify
Compile error:
error[E0046]: not all trait items implemented, missing: `default`
   --> C:\Users\me\.cargo\registry\src\github.com-1ecc6299db9ec823\notify-rust-3.6.3\src\lib.rs:583:1
    |
583 | impl Default for Notification {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `default` in implementation
    |
    = help: implement the missing item: `fn default() -> Self { todo!() }`

Ok, this issue is related to notify-rust 3.6.3 that have been fixed in latest revisions.
So, the real issue here is that latest toastify changes haven't been pushed to crates.
And while installing this app from crates, it actually download and compiles 3.6.3 version, instead of latest notify-rust 4.5.
New issue, we can't use latest version of toastify because of a bug introduced by 444f1725a881cfc1af911772d0be69061564df80

Ok, I investigated a bit and I don't know why it took me so long to find out...
It's like a really VERY silly problem that only happens on Windows.
What it is: The notification was not sent in Windows and so the main function did not return anything...
I'm creating a pull request right now...

While waiting for the pull request to be merged, you can install toastify this way:
cargo install --git https://github.com/GGLinnk/toastify.git

sorry for the long wait. I had since published 0.5.0, but I don't have a windows machine to test on. Does the issue still persist? @Northcode @GGLinnk
Thanks

@hoodie : Unfortunately it doesn't since you haven't applied change from my pull request #13
This error is still happening :

Ok, this issue is related to notify-rust 3.6.3 that have been fixed in latest revisions.
So, the real issue here is that latest toastify changes haven't been pushed to crates. And while installing this app from crates, it actually download and compiles 3.6.3 version, instead of latest notify-rust 4.5.
New issue, we can't use latest version of toastify because of a bug introduced by 444f172
error[E0308]: mismatched types
   --> src\main.rs:139:45
    |
139 |               if let Some(appname) = app_name {
    |  _____________________________________________^
140 | |                 notification.appname(&appname);
141 | |             }
    | |_____________^ expected enum `Result`, found `()`
    |
    = note:   expected enum `Result<(), notify_rust::error::Error>`
            found unit type `()`

For more information about this error, try `rustc --explain E0308`.

That have been fixed by my pull request.

This issue have been fixed in latest commits.
This issue can be closed.


The state is running in the properties file after the function app is stopped

OS: All
Build Version: 20221112.5
Regression: Not a regression
Repro Steps:

Create a Function App.
Right click this Function App -> Stop.
Right click the stopped Function App -> View Properties.
Check whether the state is stopped or not.

Expect:
The state is stopped.
Actual:
The state is running.

More Info:
This issue can be fixed after reloading the VS Code.

This is happening due to the way we're caching the resources. It should be fixed by the new V2 API.


docs(contributing): missing structure info for compiler-sfc

Signed-off-by: pengjie<EMAIL_ADDRESS>

@tjk   Do you have a minute to review this pull request ?

Seems fine to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately...

Seems ~fine~ great to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately...

Got it~

@HcySunYang  Do you have a minute to review this pull request ?

@yyx990803  Do you have a minute to review the PR?


pushing app.py in backend

I have fixed my issues with angular-Cli and can run the program through ng serve now. For this issue, I have pushed app.py into the backend directory as the current backend does not run yet. While working during this sprint, I will be connecting the app.py with the front end until the actual backend code runs successfully.

I have connected the frontend (angular) and the backend (flask) and also written the log files needed to test the connection. While testing the connection, there are issues in response to receiving the console output. I ran the flask file separately and fixed the issues for that. The dashboard.component.html has changes to the code temporarily in order for me to test the connection. Currently, the backend connection with frontend is not function successfully yet.


Add support for skipping history with $useRouter.navigate() and useGuard.goTo()

https://github.com/svelteuse/router/blob/e6e1d22765277e866e70cbd657a0e0f9c8c87e58/src/index.ts#L180-L184
As far as I can tell this should already do the trick:
- navigate: function (path: string) {
+ navigate: function (path: string, history: boolean = true) {
    useRouter.update((storeData) => {
      console.log('navigate to: ' + path)
      if (storeData.mode === 'history') {
-       window.history.pushState(
+       window.history[history ? 'pushState' : 'replaceState'](
          undefined,
          '',
          this.root + path.replace(/\/$/, '').replace(/^\//, '')
        )
      }

ℹ Ping me if you would like to know where exactly we need this functionality

<EMAIL_ADDRESS>


add queue clean up plugin developer

Description
https://github.com/jenkinsci/queue-cleanup-plugin
@olivergondza

Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

@oleg-nenashev Could you add a reference to where this was approved?

@daniel-beck https://groups.google.com/forum/#!topic/jenkinsci-dev/iy10ajiCDII


Detect pyproject.toml as project root

Sometimes I use some package build tools which doesn't require setup.py, for example, pdm.backend. It doesn't need a setup.py, instead, it'll build wheel directly.
So with this pr, I can do this:
[tool.pdm.version]
source = "call"
getter = "versioneer:get_version"

Then when I run pdm build, pdm will read version from 'versioneer.get_version()'.
However, this doesn't work now because versioneer requires setup.py or versioneer.py to detect project root. It cannot find project root by check if setup.py or versioneer.py exist. When I using build-time dependency mode, either setup.py or versioneer.py doesn't exist, but the project root is still exist! So this pull request made versioneer able to detect project root by pyproject.toml.

Huh, I had no idea it was possible to use this outside setuptools. Would you mind contributing docs showing how to do this?
@Callek Any interest in shepherding this one in?

Only PDM (build-backend: pdm.backend) can read version by call function now (I'm not sure if hatchling works because it seem use regex to get the version). Config for pdm.backend included in the first comment.


Weather forecast: unreliable if changing height

Currently 'weather' is predicting a storm if climbing up a hill (50 m is enough).
Maybe the algorithm could be improved by including height information from GPS
(if available) ...
I just saw something is there already, in the (not yet released) next version ('Barometer and thermometer', in 'Settings'):
'Travelling altitude change threshold' was set to 60 m, I have changed it to 20 m, which might help in my case.

Hello,
Yes, that is the setting you are looking for - all the altitude changes currently exist in the released version (in that barometer and thermometer settings), and there are no changes in the upcoming version.
There are only two ways to handle this:

Adjust for altitude using GPS (you can do this by toggling off Ignore rapid altitude changes and turn off rapid pressure changes, then set the traveling altitude change threshold to 0)
Ignore rapid altitude changes (which are what the traveling altitude/pressure adjustments are for) - this will give better results as the GPS altitude has a lot of noise in it, and you can't really get a good prediction with both variables changing (altitude and pressure)

Unfortunately, I have yet to find a perfect solution to this, but this discussion may help find better values for traveling thresholds (I will have a user guide coming soon): https://github.com/kylecorry31/Trail-Sense/issues/241

Hello,
Yes, that is the setting you are looking for - all the altitude changes currently exist in the released version (in that barometer and thermometer settings), and there are no changes in the upcoming version.
There are only two ways to handle this:

Adjust for altitude using GPS (you can do this by toggling off Ignore rapid altitude changes and turn off rapid pressure changes, then set the traveling altitude change threshold to 0)
Ignore rapid altitude changes (which are what the traveling altitude/pressure adjustments are for) - this will give better results as the GPS altitude has a lot of noise in it, and you can't really get a good prediction with both variables changing (altitude and pressure)

Unfortunately, I have yet to find a perfect solution to this, but this discussion may help find better values for traveling thresholds (I will have a user guide coming soon): https://github.com/kylecorry31/Trail-Sense/issues/241

all the altitude changes currently exist in the released version (in that barometer and thermometer settings), and there are no changes in the upcoming version.

True, I was just comparing on two devices, and the one without pressure sensor didn't show this option :-)
(my fault)

all the altitude changes currently exist in the released version (in that barometer and thermometer settings), and there are no changes in the upcoming version.

True, I was just comparing on two devices, and the one without pressure sensor didn't show this option :-)
(my fault)

https://en.wikipedia.org/wiki/Differential_GPS could be a way to make the height calculation better, but it doesn't fit to the "use local sensors" idea.
When moving around, often the same places are visited again. How about using the height of the saved locations for correcting the GPS height. An extreme way would be, if TS would build a big map with heights, which gets improved over time and maybe removed, if they are too old. Using the GPS position the map could provide a height. There could be problems, when two nearly the same positions have different height, e.g. at a cliff. Then the map could deal with it in providing an accuracy level (+-10m or 10-50m) or answering with a "height not defined".

@JensKorte, yeah Differential GPS does not seem like an option as it requires a shortwave radio
As for the height map idea, that does seem promising and I will explore that, maybe related to #173 (it actually seems much more feasible than using DEM).
As for this issue, I'm currently testing a new calibration mode that uses more advanced filtering and signal processing, and so far it appears to be working well for me (it's going to be an experimental option when I release the next build). It also has less confusing settings than the current calibration method.


Clipboard: minor rewrite of discussion of cloud clipboard special formats

No technical changes, but some stylistic ones:

Briefly explain the feature controlled by these formats.
Remove discussion of irrelevant implementation details.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution! I've merged your changes and they should be live soon.


Merging latest to live

@TaraMeyer,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Error in Mollie Dashboard / No order in backoffice PS

Expected behavior
After a payment there should be an order in the backoffice of Prestashop
Actual behavior
There is no order in the backoffice of Prestashop and on the Mollie dashboard I found this error:
Aanroepen webhook mislukt met statuscode 500 (Got HTTP/1.1 500 Internal Server Error instead of 20x)
Steps to reproduce the behavior
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 3.3.4
PHP version: 7.1.30

Hi @Sylvia78 ,
Thanks for contacting us.
Issue appeared after you upgraded PrestaShop or Mollie module? Or you installed it fresh?
Also is your shop live or you testing in local environment? In case in local environment you can see some detailed info here.
Best

I updated the Mollie Module.
My shop is live but now with old Mollie module

Not sure if this is related or a seperate issue, but since updating to the new version, our orders don't get a valid status any more. In the order overview view, the orders have status 'payment accepted', but when opening the order and looking at the status history, the status is not there. As a result of this, the order is also not flagged as a valid order. (Green box around order total in order overview).
Some screenshots of this behaviour:
Correct order, after manually setting status to another one and back and thus validated order on top, order created by Mollie module is the bottom one:

Order detail page; no status is set for the order:

I upgraded from 3.3.5 to 3.4.0 yesterday.

Hi @Torrentus ,
We found some issues in admin order page JS global values. It was fixed in 3.4.1 version.
Could you please try and let me know if issue persist?

I updated to 3.4.1, but new orders unfortunately still have no status.

I updated to 3.4.1 now and have the same issue as Torrentus.
I have an order after the payment but without a valid status

hi guys,
We released 3.4.2 version, issues is fixed. Could you please try and let us know?

Now the order has a valid status (payment accepted), but the backorder status for orders with out of stock products is not added.

This is weird. By any chance do you have a test environment where we could check it?
With the latest version we can't reproduce issue.

For us, seems to be working. Not 100% sure yet as we received only one order yesterday because the plugin was disabled after the update (?). We should have tested. ;-)

This error and order status bug has been fixed in new 3.4.3 release.

I know this is an old one, however after updating to 4.0.* versions I noticed that I kind of have the same problem.
From mollie backoffice payment details:
Every time someone does a payment the first webhook call fails with error 500, then mollie sends the payment notification to the email and after that the webhook succeeds.
However last weekend I had one that kept failing! And therefore the order status wasn’t updated.
Didn’t had this problem with the 3.. versions. Already reinstalled the module, no luck. Any suggestions or people with the same experience?


AWS EBS Attaches but Pod Remains at Pending

Running the default cluster setup on AWS and using CoreOS. Creating a mongo pod with no volume is successful. But creating a pod with an attached EBS volume is not. The volume does successfully attach to the correct node but the pod remains at the pending state.
Name:                           mongo
Namespace:                      default
Image(s):                       mongo:latest
Node:                           ip-172-20-0-194.ec2.internal/<IP_ADDRESS>
Labels:                         name=mongo,role=mongo
Status:                         Pending
Reason:
Message:
IP:
Replication Controllers:        <none>
Containers:
  mongo:
    Image:      mongo:latest
    Limits:
      cpu:              100m
    State:              Waiting
      Reason:           Image: mongo:latest is not ready on the node
    Ready:              False
    Restart Count:      0
Conditions:
  Type          Status
  Ready         False
Events:
  FirstSeen                             LastSeen                        Count   From                                    SubobjectPath   Reason          Message
  Thu, 09 Jul 2015 15:05:08 -0400       Thu, 09 Jul 2015 15:05:08 -0400 1       {scheduler }                                            scheduled       Successfully assigned mongo to ip-172-20-0-194.ec2.internal
  Thu, 09 Jul 2015 15:05:14 -0400       Thu, 09 Jul 2015 15:13:28 -0400 51      {kubelet ip-172-20-0-194.ec2.internal}                  failedMount     Unable to mount volumes for pod "mongo_default": fork/exec /usr/share/google/safe_format_and_mount: no such file or directory
  Thu, 09 Jul 2015 15:05:14 -0400       Thu, 09 Jul 2015 15:13:28 -0400 51      {kubelet ip-172-20-0-194.ec2.internal}                  failedSync      Error syncing pod, skipping: fork/exec /usr/share/google/safe_format_and_mount: no such file or directory

The template file:
kind: Pod
apiVersion: v1
metadata:
  name: mongo
  labels:
    name: mongo
    role: mongo
spec:
  containers:
  - name: mongo
    image: mongo:latest
    ports:
    - name: mongo
      containerPort: 27017
      protocol: TCP
    resources: {}
    volumeMounts:
    - mountPath: /data/db
      name: mongo-disk
  volumes:
  - name: mongo-disk
    awsElasticBlockStore:
      volumeID: vol-xxxxxxx # PR#10181
      fsType: ext4

Followed new VolumeID name per #10181. There are no helpful error messages on the kubelet or controller-manager. I moved up to use larger ec2 instances rather than the default t2.micro and didn't have any change.

Thanks for posting the kubectl describe output - that is very helpful, particularly:
  Thu, 09 Jul 2015 15:05:14 -0400       Thu, 09 Jul 2015 15:13:28 -0400 51      {kubelet ip-172-20-0-194.ec2.internal}                  failedMount     Unable to mount volumes for pod "mongo_default": fork/exec /usr/share/google/safe_format_and_mount: no such file or directory
  Thu, 09 Jul 2015 15:05:14 -0400       Thu, 09 Jul 2015 15:13:28 -0400 51      {kubelet ip-172-20-0-194.ec2.internal}                  failedSync      Error syncing pod, skipping: fork/exec /usr/share/google/safe_format_and_mount: no such file or directory

CoreOS setup needs to add /usr/share/google/safe_format_and_mount.  @bakins?

well, /usr is readonly. related #7042 and #10017

#8530 will solve this but post 1.0

@swagiaal Thats fine. But shouldn't it be a concern that the built binaries require a script that is only available if you run kube-up?

@delianides  It's actually Salt that installs it (along with all the binaries).  In theory you could trigger that without using kube-up, though I don't know why you would want to!  That said, I saw a suggestion in #8530 to move the functionality of the script into k8s itself; I think that would be an improvement here!

I am trying to setup mongo pod and attach an aws ebs volume to it. It succeeds when I do it in individual POD but fails if I use replication controller to do that.
I read this in documentation Using a PD on a pod controlled by a ReplicationController will fail unless the PD is read-only or the replica count is 0 or 1.
I tried setting replica to 1 but no luck, any suggestions?

@galacto could you open an new issue for this and cc me.

@swagiaal  here it is #12100

Good day!
After some playing around EBS persistent storage have found out that pod creation stucks always after attaching a EBS volume with message 'Image: nginx is ready, container is creating'. This is config being fed to kubernetes:
{
    "kind": "ReplicationController",
    "spec": {
        "selector": {
            "name": "testreplica"
        },
        "template": {
            "spec": {
                "containers": [{
                    "restartCount": 0,
                    "terminationMessagePath": null,
                    "name": "nginx1051066187104",
                    "limits": {
                        "cp": "0.01 Cores",
                        "memory": "64 MB"
                    },
                    "volumeMounts": [{
                        "readOnly": false,
                        "mountPath": "/usr/share/nginx/html",
                        "name": "usr-share-nginx-html51047551774"
                    }],
                    "image": "nginx",
                    "workingDir": "",
                    "imageID": "nginx",
                    "state": "stopped",
                    "command": [
                        "nginx", "-g",
                        "daemon off;"
                    ],
                    "resources": {
                        "requires": {
                            "cp": "0.01",
                            "memory": 67108864
                        },
                        "limits": {
                            "cp": "0.01",
                            "memory": 67108864
                        }
                    },
                    "env": [{
                        "name": "NGINX_VERSION",
                        "value": "1.9.4-1~jessie"
                    }],
                    "ready": false,
                    "startedAt": null,
                    "ports": [{
                        "isPublic": false,
                        "protocol": "TCP",
                        "containerPort": 80
                    },
                    {
                        "isPublic": false,
                        "protocol": "TCP",
                        "containerPort": 443
                    }],
                        "lastState": {},
                        "containerID": "nginx1051066187104"
                    }],
                    "volumes": [{
                        "awsElasticBlockStore": {
                            "fsType": "ext4",
                            "volumeID": "aws://us-west-2b/vol-51ad5fa5"
                        },
                        "name": "usr-share-nginx-html51047551774"
                    }],
                    "nodeSelector": {
                        "kube-type": "type_0"
                    }
                }, "metadata": {
                "labels": {
                    "name": "testreplica"
                }
            }
        },
        "replicas": 1
    },
    "apiVersion": "v1",
    "metadata": {
        "labels": {
            "name": "testreplica"
        },
        "namespace": "bliss-testreplica-893b2623bf0a61267a02ee2b7bec796b",
        "name": "testreplicapzon78a1m6d0u5ikcftb",
        "uid": "b592aee7-17e3-48df-b965-68a08e272da3"
    }
}

Such a pod without EBS volume section (empytDir) successfully becomes running. Is this a kubernetes or config issue ? Thank you.
kubernetes version
kubelet --version Kubernetes 1.0.3-0.1.git61c6ac5
kube-apiserver --version Kubernetes 1.0.3-0.1.git61c6ac5

@bliss are you running on CoreOS or Ubuntu?
If you kubectl get pods and run kubectl describe pod <podid> for the non-starting pod you will the events for that pod, which typically (hopefully) include an error message describing any launch problems.  (I don't know if this also works on the RC i.e. kubectl describe rc testreplica).
If that doesn't include any useful information, the ultimate way of diagnosing is to:

kubectl get pods <podid> -ojson
see which hostIP it ended up on
do kubectl get nodes -ojson to correlate that to a public IP
SSH into that node (ssh -i ~/.ssh/kube_aws_rsa ubuntu@<ip>)
then look in /var/log/kubelet.log or journalctl -u kubelet to get the logs from the kubelet.

That is pretty painful though, which is why we try to surface relevant errors through events which show up in kubectl describe :-)

Thank you for your reply!
here the fragment from 'kubectl -o json get pods ...' related to pod in question to make sure this is EBS volume on AWS EC2 instance setup
    "metadata": {
        "name": "hello-podv2xyc817ldutfgwkb5rq-fw48a",
        "generateName": "hello-podv2xyc817ldutfgwkb5rq-",
        "namespace": "bliss-hello-pod-f1ea6bb7d84417e69b250dad4bb14ffd",
        "labels": {
            "name": "hello-pod"
        },
    },
    "spec": {
        "volumes": [
            {
                "name": "usr-share-nginx-html55991096452",
                "awsElasticBlockStore": {
                    "volumeID": "aws://us-west-2b/vol-ddbe4129",
                    "fsType": "ext4"
                }
            }
        ],

This is last log message from 'kubectl describe pods...' related to the pod:
  Thu, 27 Aug 2015 09:41:48 +0000       Thu, 27 Aug 2015 09:42:47 +0000 8       {kubelet ip-10-0-0-203.us-west-2.compute.internal}                   failedMount      Unable to mount volumes for pod "hello-podv2xyc817ldutfgwkb5rq-fw48a_bliss-hello-pod-f1ea6bb7d84417e69b250dad4bb14ffd": fork/exec /usr/share/google/safe_format_and_mount: no such file or directory

As for me it's pretty strange to look for google safe_format_and_mount on EC2 instance, isn't it?

I found safe_format_and_mount script and placed it to required location. Thank God, on EBS without filesystem the pod started! Thank you!

Ah, well glad this is solved.  That script should be installed for you if you're using kube-up.  How did you install?
This script actually presents problems on CoreOS as well, so we're thinking of just integrating its functionality into kubelet itself (so there would be no external dependency, even if that dependency should be satisfied for you by the installation routine...)

In fact, it looks like #8530 which integrates the functionality has now been merged!  Hooray!

We install kubernetes from RPM packages and we have our deploy script for that because we use CentOS while kube-up primarily for Ubuntu-based setups.

Note: the disk formatted check is using: # file -L --special-files /dev/ to verify if the disk is formatted or not. CoreOS doesn't have the 'file' command, so I have to use the temporary hack
core@ip-10-50-0-119 /opt/bin $ ls file -l
-rwxr-xr-x 1 root root 78 Aug 29 14:19 file
core@ip-10-50-0-119 /opt/bin $ cat file
#!/usr/bin/bash
docker run -v /dev:/dev --privileged=true --rm centos file $@

CoreOS doesn't have the file command, so to # file -L --special-files /dev/ won't work ... I implement a temporary hack though. I have a alpine container with nothing more than apk-install file
core@ip-10-50-0-119 /opt/bin $ ls -l file
-rwxr-xr-x 1 root root 88 Aug 29 14:55 file
core@ip-10-50-0-119 /opt/bin $ cat file
#!/usr/bin/bash
docker run -v /dev:/dev --privileged=true --rm gambol99/filecmd file $@
core@ip-10-50-0-119 /opt/bin $ file -Ls /dev/xvdf
/dev/xvdf: Linux rev 1.0 ext4 filesystem data, UUID=9b6d546b-4273-44bb-8434-d46421da5723 (needs journal recovery) (extents) (large files) (huge files)

Good day! It's still all about AWS persistent drives. I found out that say for mariadb containers persistent drive mountpoints has improper context. It prevents mariadb from reading to the drive and makes it crush. As for safe_format_and_mount script I make a workaround with solves the issue:
MOUNT_OPTIONS="discard,defaults,context=system_u:object_r:cgroup_t:s0"

But what about the issue when the script functionality gets built-in?

I just run into this on CoreOS w/ AWS myself. Today, CoreOS ships the kubelet directly in the root filesystem, but no safe_format_and_mount. Does it make sense for CoreOS to ship this script as well, or are there plans for this script to be implemented natively in golang? Alternatively, would it be better to move away from vendoring the kubelet in the image and run the kubelet using the hyperkube docker image?

I'm pretty sure #8530 is the fix for it (so yes, golang directly in the kubelet)

Hi @bcwaldon, just wondering when you are planning to include updated kubelet in Alpha channel? Looks like v1.0.7 has been released recently.

@liquid-sky v1.0.7 was marked as a "Pre-release" at https://github.com/kubernetes/kubernetes/releases until just recently, but now that it's marked as "Latest release", we can go ahead and bump it in the CoreOS image. I'll make sure it gets done ASAP.

@liquid-sky and just to clarify, this bug does not appear to be fixed in v1.0.7 - it's in v1.1.0

@bcwaldon, thanks a lot! I was really hoping that it was fixed in v1.0.7... Does it still try to call safe_format_and_mount?

@liquid-sky as far as I know, v1.0.7 still depends on the safe_format_and_mount script

CoreOS 899.3.0 in the beta channel includes Kubelet v1.1.2 and resolved this issue for me.

Is this still an open issue?  @rootfs

We still facing the same issue:
https://github.com/coreos/coreos-kubernetes/issues/467

I think/assume this is now fixed so I'm going to close; please reopen if not


Imported functions get passed zero when called with a float argument?

Description:
I tried to pass float values around, but it look like an imported function (implemented in the host) receives zero instead of the value it was called with from the plugin if the value type is f32 or f64.
Example:
// Protocol imports
fn import_add_two_f32(arg: f32) -> f32;

// Protocol exports
fn export_add_five_f32(arg: f32) -> f32;

// Plugin implementation
fn export_add_five_f32(arg: f32) -> f32 {
    import_add_two_f32(arg) + 3.0
}

// Host implementation
fn import_add_two_f32(arg: f32) -> f32 {
    arg + 2.0
}

// Host usage / test
assert_eq!(rt.export_add_five_f32(8.0)?, 13.0);

The error:
Instead of the expected 8.0 + 2.0 + 3.0 == 15.0, you get just 5.0. The error message actually says it is a different value every time:
    Assertion is failing with random values on the left. 3 runs gave 3 different values:
    left: `5.0`,
    left: `7.4971466`,
    left: `60.949524`,

    Full error:
    ---- test::primitives stdout ----
    Provider log: src\lib.rs:369: Example plugin initialized
    thread 'test::primitives' panicked at 'assertion failed: `(left == right)`
      left: `5.0`,
     right: `13.0`', src\test.rs:38:5

The 5.0 value suggest that the imported import_add_two_f32 function receives 0. Some more tests from this commit also behave like this.
Used test code:
Yesterday I created this branch for testing this: https://github.com/kajacx/fp-bindgen/commits/import-f32-problems (only last 4 commits are relevant to this issue).
Today, I stared a new branch by accident, resulting in more tests here: https://github.com/kajacx/fp-bindgen/commits/import-floats-arguments-issues (last 3/5 commits relevant).
More observations:
In the last commit from the second branch, I tried adding a function with multiple float arguments. It seems only the first one gets zeroed.
This might be related to #178, but that issue affected integer primitives as well, this does not. I'm on Windows 10, if it is relevant.
Finally, wrapping the f32 / f64 value in a newtype works well.

I tried to reproduce this in wasmer only, and yea, I can confirm this is a bug directly in wasmer 2.3:
https://github.com/kajacx/wasmer-usage

I'm closing this one since it's somewhat out of our control. Best we can do is finish the migration to Wasmer 3 :)


Fix nfs mount command

Solves #978 due to missing package nfs-common.

Registered and CLA signed

Obviously the packe has to be present on the node, not the container.. So this PR is useless..


OnlyIntelArch, should be used at every place

This will update current apps that has same/identical message to use OnlyIntelArch and closes #228.

you will also need to squash your changes into one commit

This has been resolved. Thanks for contributing


Add http proxy option for near-cli

Problem:
I have to use vpn to connect to rpc.testnet.near.org. But It only takes effect in my browser and bash terminal. In near-cli vpn won't works.
I guess nodejs program  can't use global proxy bring this problem.
Suggest:
Near-cli may add http_proxy option for users in case of direct connect problems.

I also need this, proxy won't works.

邮件已收到

I also need this, proxy won't works.

this way has solved my problem

I also need this, proxy won't works.
https://hackmd.io/@L9ZnGph8Tbaio2GVX_z-EA/r15etnPg9)
this way has solved my problem

I also need this, proxy won't works.
https://hackmd.io/@L9ZnGph8Tbaio2GVX_z-EA/r15etnPg9)
this way has solved my problem

thanks for your solution!

邮件已收到

https://hackmd.io/@L9ZnGph8Tbaio2GVX_z-EA/r15etnPg9

Thanks! This worked for me, and can we put it in a more visible place, like the readme

All proxy problems can be solved in this way: #1067


Enumerate all host calls in wasmtime_environ::HostCall

This commit is a continuation of the plan of implementing host calls in Pulley through #9665, #9675, and #9693. Here the Compiler::call_indirect_host method is updated to take a new type, HostCall, which indicates what type of host call is being performed. This is then serialized to a 32-bit integer which will be present in the pulley instruction being generated. This 32-bit integer will then be used to perform a dispatch (the dispatch is left for a future PR with more Pulley integration).
This new HostCall structure is defined with BuiltinFunctionIndex internally. Additionally a new ComponentBuiltinFunctionIndex is added to enumerate the same set of indexes for components as well. Along the way the split between component transcoders/builtins were removed and they're now all lumped together in one macro for builtins. (no need to have two separate macros).
This new HostCall is used to implement the call_indirect_host instruction for Pulley to fill out an unimplemented piece of code.

Along the way the split between component transcoders/builtins were removed and they're now all lumped together in one macro for builtins. (no need to have two separate macros).

Yessssss


[6.x] Internal Redirects

This allows the Router to re-route during execution by returning an InternalRedirectResponse from the initial route execution.
One pretty awesome (IMO) use case for this is handling Exceptions. Currently our handler will automatically convert HTTP Exceptions into rendered views. This means we can simply create a 404.blade.php file, and if a 404 Exception is thrown, Laravel will automatically serve this view.  This is nice, but a little limited.
Let's say for whatever reason we need to inject some data into the view, or add some additional headers to the response. With internal redirects, you can handle these just like you would in any controller method.
Routes File
Route::get('throw400', function() {
    return redirect()->internal('errors.400');
});

Route::get('throw404', function() {
    return redirect()->internal('errors.404');
});

Route::get('throw500', function() {
    return redirect()->internal('errors.500');
});

Route::get('errors/400', 'ErrorController@error400')->name('errors.400');
Route::get('errors/404', 'ErrorController@error404')->name('errors.404');
Route::get('errors/500', 'ErrorController@error500')->name('errors.500');

Handler
class Handler extends ExceptionHandler
{
    public function render($request, Exception $exception)
    {
        if ($exception instanceof HttpException && $exception->getStatusCode() === 400) {
             return redirect()->internal('errors.400');
        }

        if ($exception instanceof HttpException && $exception->getStatusCode() === 404) {
             return redirect()->internal('errors.404');
        }

        if ($exception instanceof HttpException && $exception->getStatusCode() === 500) {
             return redirect()->internal('errors.500');
        }
    }
}

Controller
class ErrorController extends Controller
{
     public function error400(Request $request)
    {
        return response()->view('errors.400', [], 400);
    }

    public function error404(Request $request)
    {
        // this will return an array of similar named routes that
        // we can display to the user, and provide them quick
        // access to where they may have liked to visit
        $pageGuesses = (new PageGuesser)->guessSimilarPages($request->route);

        return response()->view('errors.404', compact('pageGuesses'), 404);
    }

    public function error500(Request $request)
    {
        $user = $request()->user();

        return response()->view('errors.500', compact('user'), 500);
    }
}

If you were to visit www.example.com/throw404, you would be internally redirected to the ErrorController@error404, and the page might be able to ask you if you meant to visit www.example.com/contact or www.example.com/about-us.
One of the really nice benefits of this is it allows users to serve responses in a consistent and standardized way if they so choose.  Everything can be handled through a Controller.
Going Forward
I think a nice improvement to make would be to automatically perform an internal redirect for HTTP Exceptions, rather than serving up the view automatically.
One thing this cannot currently handle is redirecting to a named route that needs parameters.  Currently, the bindings will not be updated, so whatever the original bindings are will be passed to the new route as well.
Another thing of note here is that we can perform an internal redirect to a named route that does not match the correct HTTP verb of the original request. I don't think this is an issue, but would love other peoples' thoughts on it.

Can imagine this being used when a response is set on an exception too. Nice to not have to call the router at that point.

I think I'm generally OK with this change but wanted to ask about one thing. I think if I was confronted with this situation. I would make an ErrorResponse class and with a static notFound method and do something like this in my controller:
return ErrorResponse::notFound($request);

The achieves the same level of code re-use without needing any internal redirect functionality just be using simple PHP classes. Is their a limitation to my approach that I am missing?

If I understand you correctly, this ErrorResponse class have the same code as the Controller then?
ErrorResponse.php
class ErrorResponse
{
    public static function notFound($request)
    {
        $pageGuesses = (new PageGuesser)->guessSimilarPages($request->route);

        return response()->view('errors.404', compact('pageGuesses'), 404);
    }
}

1 potential downside to this approach is it prevents reuse of existing routes. Let's assume the following routes file, and say we want to send users to the Contact page when they get a 404. We'll mock the 404 with 2 closure routes.
Route::get('contact', 'ContactController@create')->name('contact');

Route::get('use-internal-redirect', function() {
    return redirect()->internal('contact');
});

Route::get('use-error-response-class', function($request) {
    return ErrorResponse::notFound($request);
});

If we use the internal redirect, we are able to re-use the existing 'contact' route.  If we use the ErrorResponse class, our notFound method needs to duplicate the 'contact' code.

Another potential downside is you would lose automatic dependency injection.  If we internally redirect to another controller, we can type hint dependencies on the destination controller, and still have them automatically resolved by the container.

Not sure if this is a significant issue, but with the internal redirects the destination route gets sent through its middleware. I don't think this is better or worse, just something to be aware of.

Another downside is you lose consistency with how responses are generated. For some people this probably isn't as significant, but it is incredibly important to me. The internal redirects allow us to serve all responses via Controllers. Not some via controllers, and other via these ErrorResponse classes, and others some additional way.
If you have a new developer coming into your project, or Laravel in general they know there's always a Controller that serves up the final response.

I'm trying to figure out what the behavior would be in this situation:
Routes:
/users/1
/api/users/1
If /users/1 wanted to internal redirect to the /api/users/1 endpoint (using the route name), do the parameters still get passed as normal?

That's one shortcoming I addressed in the "Going Forward" section, as it currently does not accept parameters, so parameters will not be changed from the original request.
So I think if the parameter names happen to be the same they will pass through.
/users/{user}
/api/users/{user}
Since both parameters are named the same, an internal redirect from /users/1 would send you to /api/users/1.
If the parameters were different
/users/{user}
/api/users/{name}
I believe it would probably throw some kind of error about not passing the right number of parameters for the route.
Ideally, in the internal redirect you could pass through parameters:
public function show(Request $request, User $user)
{
    return redirect()->internal('api.users.show', [$user->id]);
}

but I haven't I haven't built that part yet.

I think if we were to implement something like you might as well consider just full sub-requests. That being said, I've always considered sub-requests basically an anti-pattern and something to be avoided for the reasons I stated above where you can always extract out a "service" type class that does the logic you want to share and then just call that from both controllers. There is also the unnecessary performance overhead and proxying through the entire router instead of just calling a service class directly to do the work you want.

Let's say for whatever reason we need to inject some data into the view, or add some additional headers to the response.

You can already do this inside the Handler which is what the render method is for. And you don't need to define routes for it.
class Handler extends ExceptionHandler
{
    public function render($request, Exception $exception)
    {
        if ($exception instanceof HttpException && $exception->getStatusCode() === 404) {
            $pageGuesses = (new PageGuesser)->guessSimilarPages($request->route);

            return response()->view('errors.404', compact('pageGuesses'), 404);
        }
    }
}

I just feel like there isn't really a problem to be solved here, sorry. You can extract the logic inside the render method into a different class if you really wanted to.
One thing I've been thinking about which is sort of similar to your idea is the idea of having dedicated Exception handlers where you map an exception type to a certain handler which then contains all the render and reporting logic in a separate class. This could be beneficial if you have, for example, lots of exceptions to handle.

Going to hold off on this for now for the reasons stated. I think that there are just better ways to solve this problem using the existing language that I would advocate instead.

Taylor also noted to me that you can have renderable exceptions which might be a good alternative to this: https://laravel.com/docs/6.x/errors#renderable-exceptions

I think if we were to implement something like you might as well consider full sub-requests. That being said, I've always considered sub-requests basically an anti-pattern and something to be avoided for the reasons I stated above where you can always extract out a "service" type class that does the logic you want to share and then just call that from both controllers. I saw sub-requests more in the old school days of CodeIgniter / Kohana / Fuel, etc.

@taylorotwell How would you implement Edge Side Includes in Laravel? Symfony uses sub-requests for that and IMO it is the biggest feature that is currently missing in Laravel.

I get Taylor's point about it feeling a little like an anti-pattern. It's that age old question you get from newer programmers, "How do I call this controller from that controller?"  I'm probably guilty of asking that myself back at the beginning of my career.
In most cases I would agree, there's probably a good opportunity to extract a "service" rather than trying to reroute.  However, I do feel like there are some good use cases for this internal redirect, exception routing being the one that readily comes to mind.
It could be a slippery slope implementing this feature, but I feel like it does warrant more discussion.

@browner12 maybe if we could find a better example? I feel like the error page example from above doesn't warrants the change. I don't think error pages should necessarily have their own dedicated routes.

Here's another scenario I would use it. With one of our applications we have a custom built CMS. This means employees create Pages on the backend and define the path they are accessed at. To handle this, our last defined Route is a catchall. All pretty standard.
Route::get('{slug?}', 'MainController@slug')->where('slug', '.*');

In our slug route we need to handle some special cases. One of those cases is the Page doesn't exist. Another is to show the search page, and another is to show a dealer locator page. Currently we just reroute these to other methods in that Controller.
public function slug(Request $request, $slug = '/')
{
    $page = Page::where('full_link', $slug)->first();

    if (!$page) {
        return $this->missing($request);
    };

    if ($request->has('pc')) {
        return $this->locator($request, $page);
    }

    if ($request->has('s')) {
        return $this->search($request, $page);
    }

    ...
}

public function locator(Request $request, Page $page)
{
    //do locator stuff
}

public function search(Request $request, Page $page)
{
    //do search stuff
}

public function missing(Request $request)
    {
        //create 404 page
        $page = new Page;
        $page->template = '404';
        $page->name = 'Not Found';

        //return response
        return response()->view('missing', compact('page'), 404);
    }

Side note, you'll probably say, "why not just create dedicated routes for the locator and search in your routes file?". Doable, but then the CMS would not have control over defining the endpoints of those routes.  They would need a programmer to switch them, rather than an employee being able to log into the CMS and update the /search path to /new-search.  This is a business requirement, it was not a programming decision, so I'm stuck with it.

While the above works, it does require us to keep the methods in the same Controller. From an organization standpoint this is not always ideal. These methods are limited to only routes run through this Controller.

I see. I was going to suggest however to programmatically set the routes based on what the user has set through the CMS but you'd lose route caching that way. Then again, the current routes aren't exactly "Cached". You could technically still programmatically set them and let them be cached after they've been edited but that might be a little too much.

While the above works, it does require us to keep the methods in the same Controller.

You can still extract these methods to a separate service which handles all the use cases. I think the above can perfectly be solved by calling services like Taylor suggests.
I think the base of this PR is okay but atm I don't see a need. @X-Coder264 I don't know anything about Edge Side Includes I'm afraid.
Maybe it's best that this is taken up in an idea issue first where you describe why this is necessary. I still think we need some better examples here.

maybe you or Taylor could tweet out a link to this PR so we could garner more feedback from a wider audience of experience?

@browner12 if you can whip up an issue in the ideas repo I'll tweet it out :thu


Fix inconsistent card-image height

Address #56
Signed-off-by: db118<EMAIL_ADDRESS>

✅ By submitting this PR, I have verified the following

[ X] Checked to see if a similar PR has already been opened 🤔
[X ] Reviewed the contributing guidelines 🔍
[X ] Added my name to the bottom of the list under the Credits section in the README.md with a link to my website or GitHub profile 👥

I looked into the background-size: cover and background-size: contain. cover cuts off portion of the image and contain doesn't full extend into the card-image div element

I think not fully shown is better than distorted. But we can get others to weight in.

@db118 Thank you for your contribution and for addressing our requests!
We will want to update the images of some of the sponsors so they can be shown nicely. We will merge this for now and address those later though. 😄
https://deploy-preview-67--techqueria.netlify.com/sponsors/


Where is  dev_trec-covid-round1.jsonl ?

I want to train,  but I couldn't got a dev_trec-covid-round1.jsonl  file.
Thank you very much.

Hi,
dev_trec-covid-round1.jsonl file can be generated as follows, the trec-covid doc file has been updated:
python ./data/preprocess.py \
  -input_trec anserini.covid-r1.fusion1.txt \
  -input_qrels qrels-cord19-round1.txt \
  -input_queries questions_cord19-rnd1.txt \
  -input_docs cord19_0501_titabs.jsonl \
  -output ./data/dev_trec-covid-round1.jsonl

I have got it.  Using this command.
python ./data/preprocess.py
-input_trec ./data/covoid/run.covid-r1.fusion1.txt
-input_qrels ./data/covoid/qrels-cord19-round1.txt
-input_queries ./data/covoid/questions_cord19-rnd1.txt
-input_docs ./data/covoid/cord19_0501_titabs.jsonl
-output ./data/covoid/dev_trec-covid-round1.jsonl
The file name has changed .
Thank you very much .


Rework show page for videos

It's weird that the send a tip button is fixed when this button is fixed with the video when scrolling. It's less important that the title and publisher. It should either be inline with subscribe or below if it cannot fit. It may make sense to move both "send a tip" and "stop download" / "delete" below the channel name and subscribe button.
The stop download button is kind of weird and missing an icon (use a stop icon).
The description can be truncated/shortened.

Send tip button was moved. Fixed in https://github.com/lbryio/lbry-android/pull/512/commits/02826196433dcdd7d098b7b9dbe26b8693a24db3
Added in https://github.com/lbryio/lbry-android/pull/518/commits/2fce9580920d681281537bc480dab5fbc365d8e7
Description is now collapsed by default and can be expanded.


#52 - Fixed issue w incorrect RT binding for ActionButtonsImpl

Fixes issue with ActionButtonsImpl binding to TagsImpl resource type

@godanny86 wdyt?


Update split-eip.adoc

fix misspelling (change multicast to split)

Thanks for the PR. I cherry picked it to main branch as 3.17.x is a non LTS branch


add shroom info

adding token info for cw20 shroom token

Summary by CodeRabbit

New Features

Added support for the SHROOM token, including its name, symbol, decimals, logo, address, and token type.

Migrated token metadata to https://github.com/InjectiveLabs/injective-lists, closing this PR


Error when completing the calm Exit Survey

user received an error when filling out the exit survey at: https://mindtrails.virginia.edu/calm/questions/ReasonsForEnding
We need to check and make sure this problem doesn't exist in the spanish version

We checked and it looks like even though the db table is created the user is never taken to reasonforending
The core problem for calm (r01) is that the reasonforending view/template does not exist.  It is in kaiser

This is not used in spanish


Access level to Doctrine\ODM\MongoDB\Cursor::$hints must be protected (as in class Doctrine\MongoDB\Cursor) or weaker

$hints is protected in Doctrine\MongoDB\Cursor and private in Doctrine\ODM\MongoDB\Cursor so it throws an error :
Fatal error: Access level to Doctrine\ODM\MongoDB\Cursor::$hints must be protected (as in class Doctrine\MongoDB\Cursor) or weaker in /Users/dunglas/Documents/workspace/winiti/vendor/doctrine-mongodb-odm/lib/Doctrine/ODM/MongoDB/Cursor.php on line 128
A solution is simply to remove $hints from Doctrine\ODM\MongoDB\Cursor as the variable is already define in the super class.

My version of mongodb-odm was not up to date. Sorry for the noise.


Participation

greenpaper/melonprotocol.pdf

thanks @Horbi; This still needs some work - we should have time to focus back on this soon


reduce unnecessary nesting of css selectors

currently there are a many selectors like:
.ps > .ps__scrollbar-x-rail > .ps__scrollbar-x {
  …
}

and I was wondering why. couldn't the same be achieved with
.ps__scrollbar-x {
  …
}

the name is unique enough and .ps__scrollbar-x will never appear outside of this context, right?

Hmm, I think it's a valid point. Will fix this.


Order of validators in chain (synchronous and asynchronous validators)

System Details

FluentValidation version: 8.3.0

Issue Description
Hi, it's kinda question rather than issue.
According to method https://github.com/JeremySkinner/FluentValidation/blob/master/src/FluentValidation/Internal/PropertyRule.cs#L318, synchronous validators in chain are executed before asynchronous validators.
For example, if I have such a chain:
RuleFor(x => x.Amount).Cascade(CascadeMode.StopOnFirstFailure)
                      .NotNull()
                      .SetValidator(amountValidator)
                      .Must(x => x > 0);

And root validator for it is calling method ValidateAsync (it means that the context will be async, and amountValidator (which inherits AbstractValidator<T>) will be executed asynchronously).
The order of execution will be: NotNull(), Must(), and only then amountValidator. The purpose of CascadeMode is getting obscure, if order of validators is really undefined.
It looks like a feature in code, not a bug. Why?

It's a holdover from how async support was initially implemented. It's something we can look at for a future version byt yes, you're correct - CascadeMode is really not useful when mixing sync & async validators in the same rule. It is much better to use conditions (When/Unless) to control which validators are executed anyway.

Thanks for answer!

Fixed in 7a20491be719cc08d27f105a73cabc27960f50f1. This will be part of 8.5


One Status Updater to rule them all

Playing around with Go generics for the frequently used statusUpdaters - this seemed easy but ended up being really difficult and I feel dead inside.
I put this in the API folder since all other projects include that one - but it might be better fitted for the utility directory. Please comment on which one you prefer.

Nice job Nate. This is really cool.


Update host to 2.0.12115

Specifically, we need a mechanism to specify the location of the worker config.

This is expected as https://github.com/Azure/azure-functions-host/issues/3390 is fixed.
environment variable languageWorkers:python:workerDirectory needs to point to a directory that contains worker.config.json

Ping! This runtime is going to production soon.

@pragnagopa  Is there a list of breaking changes?  I'm getting:
Microsoft.Azure.WebJobs.Host.Indexers.FunctionIndexingException: Error indexing method 'Functions.queue_trigger' ---> System.InvalidOperationException: Storage account 'AzureWebJobsStorage' is not configured.

There are no intentional breaking changes in this build  https://github.com/Azure/app-service-announcements/issues/136
@elprans - Does the issue repro locally? Should we update the CLI?

@brettsam - Any breaking changes around connection strings?

There were some changes to default connection strings, but I don't believe storage was touched. @elprans -- can you share what your function.json looks like? Do you have an AzureWebJobsStorage app setting in your app?

I verified AzureWebJobsStorage  is set in AppVeyor

I'm testing locally.  All functions which rely on storage are failing with this host version.  Example function.json:
https://github.com/Azure/azure-functions-python-worker/blob/5d62e629ad36bcb5125adface0a57b3e5f50446a/tests/blob_functions/get_blob_bytes/function.json#L1-L23
Connections strings are set as environment variables.

Just realized we need to move to latest extensions. Updated the PR

That doesn't seem to have helped, I still get the error.

Updating extensions is orthogonal to the function indexing issue. @brettsam and I are looking into it to see if it reproes on our end

I just got this set up and tried with and without AzureWebJobsStorage as a connection string -- and it worked. I'm trying to pull this PR now and run the tests.

@pragnagopa I think I got it working in #204.


Cow: Watch flipacoinonline.com

Cow requests the watch of the watch_keyword flipacoinonline\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

flipacoinonline\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


question about half precision for test.

Hi, @JingyunLiang @chenxwh thank you for your great work on this repo (and others).
I'm trying to speed up a bit SwinIr tests (real sr) by running it in fp16 precision.
I set  model = model.half() after   model = model.to(device) in main_test_swinir.py : https://github.com/JingyunLiang/SwinIR/blob/9b1a9bf5d1df3b18c32a49ea82f60c313d779f7d/main_test_swinir.py#L46
img_lq = img_lq.half() after https://github.com/JingyunLiang/SwinIR/blob/9b1a9bf5d1df3b18c32a49ea82f60c313d779f7d/main_test_swinir.py#L63
and  x = (attn.half() @ v).transpose(1, 2).reshape(B_, N, C) instead of  https://github.com/JingyunLiang/SwinIR/blob/9b1a9bf5d1df3b18c32a49ea82f60c313d779f7d/models/network_swinir.py#L142
but I got no significant speed up and worst, the resulting images are black with some artifacs...
My question is can we speed up swinir by setting fp16, half precision ? and if yes, how ?

I think you'd better use mixed_precision to do it, as float32 cannot be transformed to float16 loselessly. Another option is to use torch.bfloat16 (You need newest GPUs).

This is an interesting issue. I just found out that the reason behind fp16 instability is that x (shown below) is getting out of the range of fp16 during inference. Try to debug this piece of code - in main class SwinIR. If you look at x.std() during the iteration throughout self.layers, you will find that std is increasing exponentially. After 6 iterations, it is beyond the range of fp16 and gets converted into NANs.  @JingyunLiang , should this be the case here? I see that even when using fp32, the x.std() is increasing exponentially during looping.
    def forward_features(self, x):
        x_size = (x.shape[2], x.shape[3])
        x = self.patch_embed(x)
        if self.ape:
            x = x + self.absolute_pos_embed
        x = self.pos_drop(x)

        for layer in self.layers:
            x = layer(x, x_size) # Here! It explodes on fp16 after reaching `x.std() > 52000`

        x = self.norm(x)  # B L C
        x = self.patch_unembed(x, x_size)

        return x


New team members don’t have a dynamic page generated when the API is refreshed

Describe the bug
When new team members are added and show up on the home page, a new dynamic route is not created.
Additional context
This is probably due to the wrong fallback property being used on getDynamicPaths.

I can't recreate this so closing.


Sous install theme

Creates a based sous_admin theme for adding a branded install for sous.
Testing:

[x] Clone the sous-drupal-project repo: git clone git@github.com:fourkitchens/sous-drupal-project.git sous-install-theme-test
[x] Change the "fourkitchens/sous-drupal-distro": "dev-master" to  "fourkitchens/sous-drupal-distro": "dev-sous-install-theme" in composer.json
[x] Run composer install
[x] Run lando start
[x] View URL: https://sous-project.lndo.site/core/install.php
[ ] Follow through the setup instructions and verify the design and styling match the figma designs: https://www.figma.com/file/bn6SfsFAFiwtVRsbnfk37m/Sous?node-id=0%3A1

NOTES:

This is not pixel perfect but is relatively close and should be acceptable for this purpose unless there is something completely off. Then we will want to make corrections.
Database connection information can be found with lando info in the database section.

Code review:

The styling is strict with pixel specifics, not using sass, etc... This is intentional for now as a starting point and if we work on a full admin theme we can establish a CSS preprocessing practices.

I have a series of design refinements that I would like to attend to. (As soon as I have wifi that will let me do it!)
For the frying pan / progress bar, I have the CSS for it working at https://codepen.io/amazingrando/pen/JjdWePZ?editors=0100. I will integrate this when I can.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Don't parse commented lines

A tiny PR so commented lines(lines starting with ;) will not be tokenized.
I was going to go over this and convert all var, into const, would that be something you'd like to merge as well?

Just a note, this regular expression breaks if the commented line has leading whitespace. This slight modification fixes that:
^[\s]*\;.*\n?

yes!!
Thank you, I'll mirror that on my copy of the parser. :)


Exception with reason: 'Key  is already registered.'

I have two properties in AppAssembly - SearchModuleAssembly and FavoritesModuleAssembly. AppAssembly, SearchModuleAssembly, FavoritesModuleAssembly are initial assemblies.
It's throwing an exception on run "reason: 'Key 'router' is already registered.'".
@interface AppAssembly : TyphoonAssembly
@property (strong, nonatomic) SearchModuleAssembly *searchModuleAssembly;
@property (strong, nonatomic) FavoritesModuleAssembly *favoritesModuleAssembly;

@implementation SearchModuleAssembly
-(UIViewController *)view
{
    return [TyphoonDefinition withClass:[SearchVC class] configuration:^(TyphoonDefinition *definition) {
        [definition useInitializer:@selector(initWithClassNib)];
        [definition injectProperty:@selector(viewModel) with:[self viewModel]];
    }];
}

-(id<ViewModelProtocol>)viewModel
{
    return [TyphoonDefinition withClass:[SearchViewModel class] configuration:^(TyphoonDefinition *definition) {
        [definition injectProperty:@selector(router) with:[self router]];
    }];
}

-(id<RouterProtocol>)router
{
    return [TyphoonDefinition withClass:[SearchRouter class] configuration:^(TyphoonDefinition *definition) {
        [definition injectProperty:@selector(viewController) with:[self view]];
    }];
}

@implementation FavoritesModuleAssembly
-(UIViewController *)view
{
    return [TyphoonDefinition withClass:[FavoritesVC class] configuration:^(TyphoonDefinition *definition) {
        [definition useInitializer:@selector(initWithClassNib)];
        [definition injectProperty:@selector(viewModel) with:[self viewModel]];
    }];
}

-(id<ViewModelProtocol>)viewModel
{
    return [TyphoonDefinition withClass:[FavoritesViewModel class] configuration:^(TyphoonDefinition *definition) {
        [definition injectProperty:@selector(router) with:[self router]];
    }];
}

-(id<RouterProtocol>)router
{
    return [TyphoonDefinition withClass:[FavoritesRouter class] configuration:^(TyphoonDefinition *definition) {
        [definition injectProperty:@selector(viewController) with:[self view]];
    }];
}

I found a solution for this problem. We can change definition.key from configuration. It will look like this:
return [TyphoonDefinition withClass:[FavoritesRouter class] configuration:^(TyphoonDefinition *definition) {
        definition.key = @"FavoritesModuleAssembly_router";
        [definition injectProperty:@selector(viewController) with:[self view]];
    }];

The solution seems to be ugly because we’ll have to change the definition.key on all definitions.
@etolstoy Is it possible to delimit definitions on a namespaces, using typhoon functionality?
In this article, you mentioned that the key is compound and consists of a random string and the name of the method. What has changed?

@jasesuperhero You can also consider namespacing your methods:
favoritesRouter
SearchRouter

@jasperblues Yeah, sure. But if we use TyphoonAssemblies for MVVM or VIPER modules creation we’ll have problems with using common protocol or class with the same names in one module. Every VIPER module has view, presenter, interactor, also we have some runtime magic using the exact names. For example:
@protocol MVVMAssebly <NSObject>

@required
- (id)model;
- (id)view;
- (id)viewModel;

@end

Relates to: https://github.com/appsquickly/Typhoon/pull/446

In #446 pr we got the opportunity to create definitions with configs, that has specific definition.key. But in current case it's not useful, because we want to create definitions with uniq keys in range of one assembly and using configuration in code. I found the method -setDefinitionKeyRandomlyIfNeeded, that can resolve current problem, but it will called, if key.length == 0. it's not very comfortable to set empty key in all definitions. Do you have any ideas? Maybe we can create pr with new initializers for definition, that set key to empty.


Styling falsy categories is not working properly

Steps to Reproduce

You have a points map where you want to style a numeric column by category.
Make sure one the values of that column is 0. You can use a SQL Update query to change one of the values to zero.
Style by value, selecting the above column and category as quantification.
Builder assigns a color per category. Change the color of a category that falls under the one with 0. For instance, the column with value X (this depends on your data).

Current Result
The points that reflect this color change are not the one assigned to value X. You can check this with a pop-up.
The generated CartoCSS doesn't write the falsy category in the marker-fill so there's a mismatch between number of colors and number of categories.
Same happens with text categories that are null or empty string.
Expected result
There's no mismatch between the number of colors and categories, so when modifying a category, the modification is reflected on the right category.
.carto file
Madrid (on 2017-02-01 at 10.44.00).carto.zip
In this map, the bright green points are supposed to be place 6 according to the category styling, but if you click on them you'll see that they're place 7
cc @xavijam

Deployed!


Question: missing 'implements' keyword

Hi, thanks for the awesome presentation!
I've noticed one thing in the demo: when you've added ngAfterViewInit method here:
https://github.com/jelbourn/mix17-cdk-demo/blob/226a994dcf4c604e4e7c7c232db4b77c6beb4a58/src/app/color-picker/color-picker.component.ts#L47
you haven't added the implements AfterViewInit to the ColorPicker component's class. However, the demo still worked (at least at the conference).
Am I missed some new feature and we don't need to use implements for lifecycle hooks?

@detroitpistons16 thanks, that makes sense, haven't thought about it!


fix reinterpret_cast fix length types to int8 is not safe

Proposed changes
Fix type check of ubsan.
/root/doris/be/src/vec/exec/format/parquet/fix_length_plain_decoder.h:75:78: runtime error: member call on address 0x5582f35db5c0 which does not point to an object of type 'doris::vectorized::ColumnVector<signed char>'
0x5582f35db5c0: note: object is of type 'doris::vectorized::ColumnVector<int>'
 83 55 00 00  78 c0 b0 5a 82 55 00 00  02 00 00 00 00 00 00 00  10 a0 00 d7 83 55 00 00  10 a0 00 d7
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'doris::vectorized::ColumnVector<int>'
doris::Status doris::vectorized::FixLengthPlainDecoder::_decode_values<false>(COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, std::shared_ptr<doris::vectorized::IDataType const>&, doris::vectorized::ColumnSelectVector&, bool) at fix_length_plain_decoder.h:75:78

run buildall


support long shorthand

fix #8

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 26 (65.38%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 59.483%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flag.go
17
26
65.38%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
2346

Relevant Lines:
3944

💛  - Coveralls


Add support for user-provided templates

This change introduces a new -templates command flag to enable users
to override code generation templates at runtime instead of having to
recompile the binary after having edited the built-in templates.

Merged upstream.


Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]  Describe the solution you'd like A clear and concise description of what you want to happen.  Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.  Additional context Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request h

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
FILE_3128.zip
Additional context
Add any other context or screenshots about the feature request here.

@tahergdfh why are you spamming issues and feature requests without writing anything?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.


Game: Implement Selectors

Selector will be responsible for selecting set of targets using Rank (basically a number).
An input is Entity (selected by Initiative) and List of Entities (Entities representing a team).
Also it's necessary to check if the Entity is part of friendly team to set Rank to 0 if a mutator is dealing damage (and also setting high Rank for supporting Mutators).

/cib

Done.


Aggressively specialise parametrically polymorphic functions

Suggested by @alexknvl:

http://scala-miniboxing.org/benchmarks.html
https://skillsmatter.com/skillscasts/1775-scala-performance-improvements-of-a-factor-of-4-to-30-boxing-and-specialization
https://infoscience.epfl.ch/record/150270/files/EPFL_TH4820.pdf

Specialization is done quite nicely using the worker/wrapper transformation in the simplifier that's responsible for a lot of the unboxing that goes on in Eta, so it looks like we already have good support for this.


images: simplify dockerfiles

PR https://github.com/openshift/release/pull/25971 adds the controller
binaries as inputs for the image. This PR updates the Dockerfiles to
make use of the new inputs.
/cc @bradmwilliams

/hold

/retest

/hold cancel


Add new caido review

New video from t3l3machus: https://www.youtube.com/watch?v=5qWttZv8WF4

Podcast: https://www.criticalthinkingpodcast.io/videos/caido-the-up-and-coming-http-proxy-ep-43/


⚠ Minecraft has degraded performance

In 2a29659, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 900 ms

Resolved: Minecraft performance has improved in 70461f9.


unable to download signal tagging rules

I'm trying to download the signals, but only the signal triggers appear to be getting downloaded when using the --custom-alerts argument.  Is there another argument that downloads the signal tagging rules?
Is there a way to add signal tagging rules assuming there's another argument/api to download them and/or the functionality is added to --custom-alerts?

It sounds like you may want to use the --request-rules option. If that doesn't address it, feel free to re-open this issue.


Fixed an Issue Where matchContributionHash Might Not Compatible on Windows Systems

name: Pull Request
about: Open a PR for p0tion

Description:

Test Environment: AWS - Windows_Server-2022-English-Full-Base-2024.06.13

Steps to Reproduce:

Run:
phase2cli contribute

Output:
- Circuit # 1/1 (Contribution Steps)
√ Contribution #00000 correctly downloaded
- Writing contribution metadata...× Unable to retrieve contribution hash from transcript. Possible causes may involve an error while using the logger or unexpected file descriptor termination. Please, terminate the current session and repeat the process.

Cause:

Source Code: https://github.com/privacy-scaling-explorations/p0tion/blob/d61f85c5860b8f10e54a3ff653d0abb9b533bef4/packages/phase2cli/src/lib/utils.ts#L667

The issue arises because the regular expression /Contribution.+Hash.+\n\t\t.+\n\t\t.+\n.+\n\t\t.+\n/ used to match the Contribution Hash does not compatible for differences in the "winston" logging component across platforms.

Examples of Differences:

Unix/Linux Log:
Circuit Hash:
		49119684 1980a690 2f1f8414 765927d4
		a2c8aa83 09f7d9eb 5890d9a9 045d7bb2
		5fa4588f 04cc9161 297c00d2 231e4f1d
		51aa256c 3cb02c06 18c2aacc 562e515c      <---  \n
Contribution transcript for xxxxxxx phase 2 contribution.

Windows Log:
Circuit Hash:
		49119684 1980a690 2f1f8414 765927d4
		a2c8aa83 09f7d9eb 5890d9a9 045d7bb2
		5fa4588f 04cc9161 297c00d2 231e4f1d
		51aa256c 3cb02c06 18c2aacc 562e515c      <---  \r\n
Contribution transcript for xxxxxxx phase 2 contribution.

Solution:

To ensure compatibility with Windows systems, modify the regular expression to allow an optional \r before the final \n.

The updated regular expression is:
/Contribution.+Hash.+\n\t\t.+\n\t\t.+\n.+\n\t\t.+(\r?\n)/

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules
[x] I reviewed the code of conduct and contributors' guide

Confirmed the observation: In Windows, the file looks like this:

I've added these changes to a branch: https://github.com/privacy-scaling-explorations/p0tion/tree/regex
It's the same basic change, but I'm taking the opportunity to reduce some duplication, so we can specify the pattern in 1 place.