Customizing a specific view

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I'm pretty sure it's simple, but I'm confused about the directory and file structure.
As can be seen on the photo montage, I would like the respective cover to be displayed in the individual view of an item.
Any help would be great

.
Exact BookStack Version
BookStack v22.06.1
Log Content
No response
PHP Version
No response
Hosting Environment
Debian 11 Bullseye

Hi @memo-567,
I responded on discord but thought I'd copy my response here and expand on it a little:
You could use the visual theme system to override the book-show view to achieve this.
Visual theme system docs: https://github.com/BookStackApp/BookStack/blob/development/dev/docs/visual-theme-system.md
Visual theme system video guide: https://www.youtube.com/watch?v=gLy_2GBse48
For this specific task, the template you'd want to override is this one:
https://github.com/BookStackApp/BookStack/blob/development/resources/views/books/show.blade.php
It'd be something along the lines of adding this:
getBookCover() }}" width="400">

After line 25 of the file linked above, starting with
 mmc (this is the name if my theme) -> views -> books -> show.blade.php
and even
themes -> mmc -> resources -> views -> books -> show.blade.php
and always sat ownership and permissions.
But nothing takes any effect.

@memo-567 The path of your overridden view should be:
themes/mmc/books/show.blade.php

I had failed at this for two days and didn't come up with this idea 🙄
That was the reason. Thanks.


Overlapping of Header on Cards

The header/navbar  is overlapping the cards
Suggestion
Make the header/navbar width of 100%

On it

Issue Solved!


Grammar tweaks for the primary button docs

It seems like an extra "the" slipped in with a recently merged pull request. I also removed a hyphen that was being used incorrectly.

@nicolasmccurdy That's an em dash—not a hyphen—and I think that's valid usage of it?

Oh I'm sorry, I thought it was a hyphen with the diff's monospaced font. It totally is an em dash, and it's being used correctly. I'll this this now.

Thanks @nicolasmccurdy, my bad.


Problem with UWP in Unity 5.5.1f

Table operations usually work in the editor. But not on my Windows Phone 10. Error occurs while trying to insert.
Should this plugin work on Windows Universal 10?

It should work as UWP app, but you have to be careful not to use properties (using the shorthand 'get' / 'set') in your JSON model as these will not work when running as Windows Store App. Rather use fields instead as shown in the demo project models.
using System;
using Unity3dAzure.AppServices;

[Serializable]
public class Highscore : DataModel
{
	public string username;
	public uint score;
}

Btw this example inherits the base DataModel which uses methods to get the system properties like id, date added, data updated, version and deleted:
https://github.com/Unity3dAzure/AppServices/blob/master/model/base/DataModel.cs
If this is not your issue please attach a snippet of your C# JSON model inline. Otherwise if this fixes the error, pls close the issue.

Thanks @deadlyfingers , one of the problems really was with the DataModel class.


update the implementation of low level HTTP server

Pull Request Test Coverage Report for Build 30

0 of 45 (0.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 33.426%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/app/mod.rs
0
1
0.0%

src/server/conn.rs
0
2
0.0%

src/lib.rs
0
4
0.0%

src/app/service.rs
0
7
0.0%

src/server/server.rs
0
31
0.0%

Totals

Change from base Build 29:
-0.6%

Covered Lines:
241

Relevant Lines:
721

💛  - Coveralls


[SITES-6947] - Productize PoC of Phase1

Looks good to me, would just need some tests

LGTM 👍 , but missing unit tests on exporter impl


raw_ores -> raw_materials

hai \o
Other mods on 1.18.2 seem to prefer the raw_materials tag over raw_ores.
Changing this will help with mod compatibility, and allow the Foliot Crusher to be made in Enigmatica 8 :)
Context: https://github.com/EnigmaticaModpacks/Enigmatica8/issues/187

Thanks a lot - that sort of went past me. I added raw_materials tags to occultism ores but never updated the recipes

My pleasure :D


run csiaddons sidecar only for rbd nodeplugin

run csiaddons sidecar only for rbd nodeplugin its not required for cephfs/nfs and also don't run csi-addons for nfs deployment

w/o the fix
> k get po -owide | grep nodeplugin
openshift-storage.cephfs.csi.ceph.com-nodeplugin-6s8zd            3/3     Running             0          2m51s   <IP_ADDRESS>   ip-10-0-105-244.us-west-2.compute.internal   <none>           <none>
openshift-storage.cephfs.csi.ceph.com-nodeplugin-k9kwj            0/3     Pending             0          2m51s   <none>         <none>                                       <none>           <none>
openshift-storage.cephfs.csi.ceph.com-nodeplugin-s429r            3/3     Running             0          2m51s   <IP_ADDRESS>    ip-10-0-18-222.us-west-2.compute.internal    <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-jvvbx               3/3     Running             0          2m51s   <IP_ADDRESS>   ip-10-0-124-197.us-west-2.compute.internal   <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-q4q7p               0/3     Pending             0          2m51s   <none>         <none>                                       <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-svgdg               0/3     Pending             0          2m51s   <none>         <none>                                       <none>           <none>

> k get no
NAME                                         STATUS   ROLES                         AGE    VERSION
ip-10-0-105-244.us-west-2.compute.internal   Ready    control-plane,master,worker   103m   v1.30.3
ip-10-0-124-197.us-west-2.compute.internal   Ready    control-plane,master,worker   103m   v1.30.3
ip-10-0-18-222.us-west-2.compute.internal    Ready    control-plane,master,worker   104m   v1.30.3

  Warning  FailedScheduling  2m46s (x2 over 3m23s)  default-scheduler  0/3 nodes are available: 1 node(s) didn't have free ports for the requested pod ports. preemption: 0/3 nodes are available: 1 node(s) didn't have free ports for the requested pod ports, 2 Preemption is not helpful for scheduling.

w/ fix
> k get po -owide | grep nodeplugin
openshift-storage.cephfs.csi.ceph.com-nodeplugin-hcvtg            2/2     Running     0          18s     <IP_ADDRESS>   ip-10-0-124-197.us-west-2.compute.internal   <none>           <none>
openshift-storage.cephfs.csi.ceph.com-nodeplugin-nkbcz            2/2     Running     0          18s     <IP_ADDRESS>    ip-10-0-18-222.us-west-2.compute.internal    <none>           <none>
openshift-storage.cephfs.csi.ceph.com-nodeplugin-zvhg9            2/2     Running     0          18s     <IP_ADDRESS>   ip-10-0-105-244.us-west-2.compute.internal   <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-q28g4               3/3     Running     0          18s     <IP_ADDRESS>   ip-10-0-124-197.us-west-2.compute.internal   <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-qgdmr               3/3     Running     0          18s     <IP_ADDRESS>   ip-10-0-105-244.us-west-2.compute.internal   <none>           <none>
openshift-storage.rbd.csi.ceph.com-nodeplugin-z2l5c               3/3     Running     0          18s     <IP_ADDRESS>    ip-10-0-18-222.us-west-2.compute.internal    <none>           <none>


Cron for removing old unauthenticated users

Quartz.NET could be used. It could also be used for assigning roles and nicknames instead of the current ones that are used.

Resolved in 498e7b5.


Fix performance of including relationships

Including a relationship causes very slow performance. I first noticed this when including a relationship that had a .through, It was sometimes taking over 2 seconds to return from bookshelf. I did some digging and found that one of the queries that was supposed to return only 2 results, returned over 4k results. All of the 4k results were duplicate rows. Here is an example of a query that was generated for the following relationship:
// relationship
	supplier(){
		return this.belongsTo(Models.Supplier).through(Models.ClientSupplier, 'client_supplier_id');
	},

// query
select "suppliers".*, "clients_suppliers"."id" as "_pivot_id", "clients_suppliers"."supplier_id" as "_pivot_supplier_id"
from "suppliers" inner join "clients_suppliers" on "clients_suppliers"."supplier_id" = "suppliers"."id"
inner join "invoices" on "clients_suppliers"."id" = "invoices"."clients_supplier_id"
where "invoices"."client_supplier_id" in (17, 18)

Since my invoices table had thousands of rows, this query returns many duplicates of the same supplier.
Making the request use the distinct keyword ensures that the result only includes the desired results without duplicates.

@ricardograca  Will do, I just got my environemnt all set up for testing

@ricardograca All of the tests pass on my local machine, have you ever run into issues where tests differ between machines?

That's weird. Looking at the failed test it seems like the two expected objects in the response array have their order swapped, even though they are correct individually. I've never seen this particular error before. Can you check if there could be some kind of race condition here? It's important that any async tests always return promises or call done() when done.

I am using Node 8.9.2

Looking at the test more closely it's a bit weak since there shouldn't be any requirement (or guarantee) that the columns are retrieved in any particular order. I'll ignore that failed test, but I still need to review this more carefully to make sure no new bugs or breaking changes are introduced and I don't have time for that right now.

Is it very strange, the test that is failing here is passing consistently on my end.

The extra distinct table.* causes problems with JSON fileds.
"could not identify an equality operator for type json"
See https://github.com/bookshelf/bookshelf/issues/1941

@ricardogama do you think this change is adequate?
It seems to me that this particular query can be optimized with .query(). Or add DISTINCT only to queries generated by .through().
Surely there is no reason to add DISTINCT to every single select query ?
See also #1941


Xbox buttons and shoulder buttons don’t work

The camera works and so does the joystick, the things that don’t work are a b y x lb rb lt rt.

Are you sure this isn't a hardware problem with your controller? Test it at https://gamepad-tester.com/

I’ve already tested it out more than once and the buttons do work on gamepad tester but they still don’t work on sm64 js

I can't check cuz

I'm banned
The site won't even load fully. I can't access the console due to my chromebook being managed by the school.  I can't access the console due to my chromebook being managed by the school. (And for some reason they don't like the Ctrl-Shift-I thingy)

I'm banned
nice

I'm banned
nice

Good job replying to a 5 month old comment. 👏

sm64js moderation moment :troll:
…
On Tue, Mar 29, 2022, 2:06 PM ImaginaryNeon @.> wrote: I'm banned nice Good job replying to a 5 month old comment. 👏 — Reply to this email directly, view it on GitHub <#370 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR5UMJYTXXBGEA6X5KOYKITVCNWF7ANCNFSM47GBAHGA . You are receiving this because you are subscribed to this thread.Message ID: @.>

Nice job noticing the sarcasm!

thank you ImaginaryNeon
On Tue, Mar 29, 2022, 7:00 PM ImaginaryNeon @.***>
wrote:

sm64js moderation moment :troll:
… <#m_-2696212678669703514_>
On Tue, Mar 29, 2022, 2:06 PM ImaginaryNeon @.> wrote: I'm banned nice
Good job replying to a 5 month old comment. 👏 — Reply to this email
directly, view it on GitHub <#370 (comment)
https://github.com/sm64js/sm64js/issues/370#issuecomment-1082374050>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5UMJYTXXBGEA6X5KOYKITVCNWF7ANCNFSM47GBAHGA
https://github.com/notifications/unsubscribe-auth/AR5UMJYTXXBGEA6X5KOYKITVCNWF7ANCNFSM47GBAHGA
. You are receiving this because you are subscribed to this thread.Message
ID: @.>
Nice job noticing the sarcasm!
—
Reply to this email directly, view it on GitHub
https://github.com/sm64js/sm64js/issues/370#issuecomment-1082537776, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5UMJYYZEH6J4X4BGCHJP3VCOYT5ANCNFSM47GBAHGA
.
You are receiving this because you commented.Message ID:
@.***>

thank you ImaginaryNeon On Tue, Mar 29, 2022, 7:00 PM ImaginaryNeon @.> wrote:
…
sm64js moderation moment :troll: … <#m_-2696212678669703514_> On Tue, Mar 29, 2022, 2:06 PM ImaginaryNeon @.> wrote: I'm banned nice Good job replying to a 5 month old comment. 👏 — Reply to this email directly, view it on GitHub <#370 (comment) <#370 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR5UMJYTXXBGEA6X5KOYKITVCNWF7ANCNFSM47GBAHGA https://github.com/notifications/unsubscribe-auth/AR5UMJYTXXBGEA6X5KOYKITVCNWF7ANCNFSM47GBAHGA . You are receiving this because you are subscribed to this thread.Message ID: @.> Nice job noticing the sarcasm! — Reply to this email directly, view it on GitHub <#370 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR5UMJYYZEH6J4X4BGCHJP3VCOYT5ANCNFSM47GBAHGA .  You are receiving this because you are subscribed to this thread.Message
ID: @.> Nice job noticing the sarcasm! — Reply to this email directly, view
it on GitHub <#370 (comment)
https://github.com/sm64js/sm64js/issues/370#issuecomment-1082537776>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5UMJYYZEH6J4X4BGCHJP3VCOYT5ANCNFSM47GBAHGA
https://github.com/notifications/unsubscribe-auth/AR5UMJYYZEH6J4X4BGCHJP3VCOYT5ANCNFSM47GBAHGA
.
—
Reply to this email directly, view it on GitHub
https://github.com/sm64js/sm64js/issues/370#issuecomment-1082554237, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5UMJ2NAWZTKOIZFP6XSALVCO4D3ANCNFSM47GBAHGA
.

On Wed, Apr 6, 2022 at 10:33 AM ImaginaryNeon @.***>
wrote:

Not letting me speak 'cause you don't want to give me another chance, huh?
I see how it is then, Agent X.
—
Reply to this email directly, view it on GitHub
https://github.com/sm64js/sm64js/issues/370#issuecomment-1090531821, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5UMJ2YTTSUGGXPDK5IRVTVDXDGRANCNFSM47GBAHGA
.

At this point I think that either:
A. It doesn't count 'cause I haven't played in OVER 6 MONTHS (give or take idr)
B.  I see how it is then, Agent X.

Case and point right here.


gh actions:  panic: test timed out after 1m0s running tests on macos

https://github.com/dmachard/go-dnscollector/actions/runs/6472838734/job/17574273213
panic: test timed out after 1m0s
running tests:
Test_TcpClientRun (2s)
Test_TcpClientRun/json (1s)

fixed with #418


1.1.0

Codecov Report

Merging #33 (2a25eec) into master (428a70c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   66.66%   66.66%
=======================================
  Files           1        1
  Lines           3        3
  Branches        1        1
=======================================
  Hits            2        2
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428a70c...2a25eec. Read the comment docs.


Add tracing tests

There were no test for tracing using a real ethereum mainnet node

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 90.275%

Totals

Change from base Build<PHONE_NUMBER>:
1.3%

Covered Lines:
2395

Relevant Lines:
2653

💛  - Coveralls


kube client library bump to v0.21.3

Signed-off-by: Shoubhik Bose<EMAIL_ADDRESS>
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

@cndoit18 If I understand it right, dependabot will update a single dependency. We need to update these as a group. When dependabot has tried to update them as individuals it has been a problem. It would be great if dependabot could update them as a group.

Doing right away..


Add exposed components to metadata.json

Purpose

Add exposed components to metadata.json

Codecov Report

Merging #442 into master will decrease coverage by 0.06%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   82.35%   82.29%   -0.07%
==========================================
  Files          29       29
  Lines         856      864       +8
  Branches       63       65       +2
==========================================
+ Hits          705      711       +6
  Misses        109      109
- Partials       42       44       +2

Impacted Files
Coverage Δ

...ang/src/main/java/io/cellery/CelleryConstants.java
66.66% <ø> (ø)
:arrow_up:

...src/main/java/io/cellery/impl/CreateCellImage.java
87.57% <80%> (-0.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480a78b...be7a49b. Read the comment docs.

Codecov Report

Merging #442 into master will decrease coverage by 0.06%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   82.35%   82.29%   -0.07%
==========================================
  Files          29       29
  Lines         856      864       +8
  Branches       63       65       +2
==========================================
+ Hits          705      711       +6
  Misses        109      109
- Partials       42       44       +2

Impacted Files
Coverage Δ

...ang/src/main/java/io/cellery/CelleryConstants.java
66.66% <ø> (ø)
:arrow_up:

...src/main/java/io/cellery/impl/CreateCellImage.java
87.57% <80%> (-0.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480a78b...4cf58f8. Read the comment docs.


Fix the concurrency problem when AbstractCacheFactory creates Cache

What is the purpose of the change
Fix the concurrency problem when AbstractCacheFactory creates Cache
see more detail from #7674
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7675 (ed32403) into master (2201510) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #7675      +/-   ##
============================================
- Coverage     59.18%   59.06%   -0.13%
+ Complexity      529      528       -1
============================================
  Files          1076     1076
  Lines         43465    43489      +24
  Branches       6355     6329      -26
============================================
- Hits          25726    25687      -39
- Misses        14900    14940      +40
- Partials       2839     2862      +23

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/cache/support/AbstractCacheFactory.java
87.50% <75.00%> (-12.50%)
0.00 <0.00> (ø)

...tadata/DynamicConfigurationServiceNameMapping.java
47.36% <0.00%> (-36.85%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-20.69%)
0.00% <0.00%> (ø%)

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
0.00% <0.00%> (ø%)

...nfig/configcenter/nop/NopDynamicConfiguration.java
75.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
50.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

.../remoting/transport/netty4/NettyClientHandler.java
76.27% <0.00%> (-10.17%)
0.00% <0.00%> (ø%)

... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2201510...ed32403. Read the comment docs.


Snap Layouts Support: WM_NCHITTEST should return HTMAXBUTTON, HTMINBUTTON, ... for caption buttons

Right now, our implementation of WM_NCHITTEST only covers the "caption" portion of the drag bar. To properly support accessibility tools, we'll need to return more than HTCAPTION.
This may require some rearchitecting to make sure the drag bar can pass input to the XAML input site.

This one was filed for a very specific reason. :smile:

This one was filed for a very specific reason. 😄

There has been a lot of teases in this repo

Dead ends in: dev/migrie/titlebar-shenannigans, dev/mgirie/b/more-nchhittest-ideas

If anyone is interested, snap layouts does not work in flutter desktop apps if title bar is customized/disabled:
https://github.com/flutter/flutter/issues/156791


React.js ?

Any react port?

I do actually have an unpushed branch building support for a React-based version. I can let you know when there's something more to look at.

Cool
Please
Thanks

@benpickles maybe just push the WIP and let me do some polishing? Created a little proprietary component that approximates peity but would rather just contribute upstream.

Is there still no way of using this with react?

There is an attempt to port to react here https://www.npmjs.com/package/react-peity

react-peity is limited to Line and Bar charts. For our new React project we needed Pie Peity, so created a simple Component. Hope it will be helpful for someone.
p.s. Including jQuery globally is required.
/**
 * External Dependencies
 */
import 'peity';
import React, { Component } from 'react';

const $ = window.jQuery;

/**
 * Component
 */
class Peity extends Component {
    constructor( props ) {
        super( props );

        this.$chartRef = React.createRef();
        this.$chart = false;
    }

    componentDidMount() {
        const {
            type = 'line',
            options = {},
        } = this.props;

        this.$chart = $( this.$chartRef.current ).peity( type, options );
    }

    componentDidUpdate( prevProps ) {
        // nothing changed
        if ( JSON.stringify( prevProps.data ) === JSON.stringify( this.props.data ) ) {
            return false;
        }

        if ( this.$chart ) {
            this.$chart
                .change();
        }
    }

    render() {
        const {
            data = '',
        } = this.props;

        return (
            <span
                ref={ this.$chartRef }
                className="peity"
            >
                { data.join( ',' ) }
            </span>
        );
    }
}

export default Peity;

Usage example:
<Peity
    type="line"
    data={ [ 5, 3, 9, 6, 5, 9, 7, 3, 5, 2 ] }
    options={ {
        height: 16,
        strokeWidth: 0,
        fill: 'rgba(114, 94, 195, 0.8)',
    } }
/>

<Peity
    type="pie"
    data={ [ 5, 3, 4 ] }
    options={ {
        height: 16,
        strokeWidth: 0,
        fill: [
            'rgba(114, 94, 195, 0.8)',
            'rgba(114, 94, 195, 0.6)',
            'rgba(114, 94, 195, 0.4)',
        ],
    } }
/>

I ended up creating port for react-native https://github.com/vko-online/react-native-peity


Adding a fr translation for security

Another file to help on https://github.com/rust-lang/rust-www/pull/501

👍


Work on memory usage

I'm interested in seeing how tight a WebRTC connection can be in memory usage. I did a simple test of the current code, 14 tabs opened against the EchoServer and saw significant memory usage in the server. It jumps from ~500kb to over 1 MB per 14 tabs, you think this can be improved? What consumes memory? DTLS? If you can get down to a very slim memory usage, like only a few bytes per connection, that would be really interesting.

I haven't measured the memory usage yet, however I am suspecting that most of the memory per client is indeed taken up by the SSL context. The server preallocates memory for a fixed number of clients (excluding SSL context) at the moment, should probably fix this.

The mandatory DTLS is a real tearjerker. 32kb * 14 = ~500kb, maybe it really does require 32kb per connection? Options to tweak?
With UDP below unordered SCTP you have the opportunity to go below what is needed in memory for TCP (at least what is needed by most TCP stacks), but that seems to depend strongly on how heavy this darn DTLS is.
I was investigating doing something similar as this project myself, but when I saw this mandatory DTLS I just dropped it. Will be interesting to follow this project and see if it is possible to improve from here :sparkles:

Closing this as I'm not planning to add any new SSL backends currently. If it becomes an issue for me in the future, I might try alternatives.


Akka Agent based CircuitBreakerState Implementation

The current implementation of Stream Circuit Breaker is based on Atomic, we should also try using an Agent based implementation.

Akka 2.5 deprecated agents.  So, this issue is not valid anymore.

Akka Agent is deprecated in 2.5.


genindex.html, Hlists (and possibly more table-based items) become funky after 0.15.3 upgrade

This page uses version 0.15.3:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/genindex.html
This page uses version 0.15.2:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.2/genindex.html
The style in genindex.html is as expected in version 0.15.2, but in version 0.15.3 the indextable has dark grey color and purple color when hovering.
See attached screenshots:

Thanks for raising this @abjarna.
This was introduced in #1833, when the table styling was improved. So while not a bug it is an unexpected result from this PR.
Adding a screenshot of the dark version:

I do not think the grey background is an issue since this is a table (albeit a special case of a table), but perhaps the hover colour (purple) could be removed as the focus item for interaction will be the links inside a given cell.
Thoughts @gabalafou @smeragoel

Ok, thank you! I wasn't aware of #1833 , but in my opinion this makes the genindex.html look really bad. In addition, the genindex.html now looks totally different from previous versions, which was probably not the intention of #1833 .
Also, the grey background either overlaps between left and right column, or creates a thin table border. This results in a thin line in front of the right column in the genindex.html. See attachment.

I haven't yet tried to fix this in my custom.css, but it's probably an easy fix.
However, I recommend a more permanent fix to prevent the above changes to genindex.html.

I also found similar issues when using Hlists.
This page uses version 0.15.3:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/examples/kitchen-sink/lists.html
This page uses version 0.15.2:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.2/examples/kitchen-sink/lists.html

Are you @trallard aware of any ways to disable these grey colors and purple color when hovering, besides using custom CSS?

Aha! Another item we did not realise was a table.
Edit the correct PR that introduced this is https://github.com/pydata/pydata-sphinx-theme/pull/1757

Are you @trallard aware of any ways to disable these grey colors and purple color when hovering, besides using custom CSS?

Unfortunately, right now, you'd need to add custom styles specifically to override these lines https://github.com/pydata/pydata-sphinx-theme/blob/97e60ba3e90a2b3b03c8b38413d68c53fdb4f3f1/src/pydata_sphinx_theme/assets/styles/abstracts/_mixins.scss#L44-L55
  tbody {
    tr {
      &:nth-child(odd) {
        background-color: var(--pst-color-table-row-zebra-low-bg);
      }

      &:nth-child(even) {
        background-color: var(--pst-color-table-row-zebra-high-bg);
      }

      &:hover {
        background-color: var(--pst-color-table-row-hover-bg);

tough this would affect all tables on your site.
Though it seems we'd need to make some further improvements to these at the theme level anyway.

Thank you for the quick response @trallard !
And also thanks for all your hard work on the PyData theme. Best Sphinx theme out there by far! 🙏

Thank you for reporting these style mishaps 🙏🏽
I am tagging @gabalafou and @smeragoel here as they were the main folks working on tables restyling: folks let's chat about this and scope any further improvements needed

Ideally, we would change the output for both hlists and the index page to not use tables.

Are you suggesting we do that in the theme? Or as an upstream change to sphinx?

Upstream, if we can

So that would more than likely be at the Sphinx level

Hi again, I see this has been fixed in the latest version (v0.15.4dev0).
Both the latest version (v0.15.4dev0) and version 0.15.3, show table-hover behaviour in "kitchen-sink/tables.html":
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/examples/kitchen-sink/tables.html
https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/tables.html
And only version 0.15.3 show table-hover behaviour in "genindex.html", but NOT the latest version (v0.15.4dev0):
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/genindex.html
https://pydata-sphinx-theme.readthedocs.io/en/latest/genindex.html
And finally, only version 0.15.3 show table-hover behaviour in "kitchen-sink/lists.html", but NOT the latest version (v0.15.4dev0):
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/examples/kitchen-sink/lists.html
https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/lists.html
I've been trying to replicate the quick fix #1864 from @gabalafou in my local environment, by removing the line "@include table-colors;" from _tables.scss in my virtual environment folder, and then rebuilding with "make clean && make html", but still no luck 😢
Am I missing something obvious, or are there additional steps I need to make to replicate the behaviour in latest version (v0.15.4dev0)?

And a quick note to other users who might also be struggling with the same issue, this addition to custom.css temporarily undoes the table-hover behaviour in "genindex.html":
table.indextable.genindextable {
    border: none !important;
}

table.indextable.genindextable td {
    border-left: none !important;
}

table.indextable.genindextable tr {
    background-color: inherit !important;
}

I've been trying to replicate the quick fix #1864 from @gabalafou in my local environment, by removing the line "@include table-colors;" from _tables.scss in my virtual environment folder, and then rebuilding with "make clean && make html", but still no luck 😢

the .scss files need to get compiled into .css files for the changes to propogate to the built site. make clean && make html won't do that; it's handled (along with minifying our javascript assets) by webpack.
If you're testing on the theme's own website, you could do tox -e docs-dev for example, which will run webpack first.  To do it for your own site, you'd need to figure out what CSS rules the @include actually includes, and then remove them manually from the relevant spot(s) in the compiled .css file

Thank you @drammock! In that case, I’ll stick to the custom.css in my previous comment for now.


otk/command: implement "validate" command

I also fixed the behavior of "output" as it was expected to be a path - which is wrong I guess
fixes #79

as I ran into the linter in github - I also integrated ruff into pre-commit now.
please comment on those:

should this be a separate PR?
should we keep the "--fix" in pre-commit for ruff?

as I ran into the linter in github - I also integrated ruff into pre-commit now.
please comment on those:
* should this be a separate PR?

* should we keep the "--fix" in pre-commit for `ruff`?

I'm fine with having this in the same PR, let's not overcomplicate since I agree with both additions.
There's just an architectural remark I have. I don't quite like validate calling the compile subcommand and I'd prefer having them as separate commands, we can move the common code to a helper function.

Fwiw, I would be in favor of splitting purely whitespace changes (like the last (two?) commit(s) that just does a bunch of ruff formatting) into a separate PR. I think it's distracting otherwise for the reviewer (and for people looking at the PR history)


add column "root_feature_id" to the property table

The new root_feature_id should be a FK pointing to the corresponding top-level feature. This column would help for speeding up the export and delete process by avoiding recursive joins. Note that we should not move this column to the feature table, because a nested feature can be shared by multiple top-level features via XLinks.

I support the idea of having easy access to the root feature of a feature hierarchy. But I would even see the need for having access to the direct parent in addition.
It does not feel right to have this information in property but not in feature. I see your point, but maybe we can also solve it differently? Because we need the information about the root / parent feature only once. It we move this to a column in property, it would be stored multiple times for a single feature (as many times as the feature has properties). And what if we want to later add an attribute to this feature (e.g. via a WFS Update statement). How would this update statement know which values to use for the root / parent feature? It would first have to make a select on property - again, doesn't feel right.

Let's discuss in #126, so closing this issue now.


get Item data

How do i get the data from my IFlexible item?
i mean the private data fields, lets say for an item selected.
As i see it returns an IFlexible object which doesn't have my data.
Do i have to define my own setter and getter methods for my IFlexible item and manually add a duplicate Array for my data?

@ceddyb, you have 2 options:

You can extend your Adapter item with your data from AbstractFlexibleItems and others.
Create your adapter item with IHolder and set your data item.

You have to pass the most common class to the FlexibleAdapter and eventual cast it to the expected specific item when you call getItem(pos).
// If you have many view type you will have to cast to your expected specific item
FlexibleAdapter<YourCommonAbstractClass> adapter = new FlexibleAdapter<>(myItems);

// If you have only one view type you can avoid cast items because it is already of our type.
FlexibleAdapter<YourItemClass> adapter = new FlexibleAdapter<>(myItems);

I done made some casting of my class, but it took me like 2 to 3 builds to figure out what was happening.
Awesome lib man!

The library is now quite big in terms of functionality, so the initialization has its complexity as well, but with Wiki, demo and javaDoc, it becomes easier.


Support for AWS_LAMBDA Authorizer for AppSync

Is this related to a new or existing Amplify category?
auth, function, api
Is this related to another service?
Lambda, AppSync
Describe the feature you'd like to request
Is there any possibility to support the AWS_LAMBDA authorizer for the AppSync API?
What I'm doing right now is to create the Lambda Authorizer through the console:

It works well, but the CLI does not allow me to update the Queries/Mutations/Subscriptions generated to add @aws_lambda as a new authentication method...
Describe the solution you'd like
Being able to use the AWS_LAMBDA Authorization method for custom authentications.
Describe alternatives you've considered
I don't know any alternative.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Hey @MontoyaAndres thanks for raising this! This appears to be a duplicate of https://github.com/aws-amplify/amplify-cli/issues/7963. Closing in favor of tracking existing request, please subscribe to #7963 for further updates 🙂


java.lang.IllegalAccessError: superclass access check failed with setup-java@v4

Description:
A clear and concise description of what the bug is.
Task version:
Specify the task version
Platform:

[x] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[x] Hosted (GitHub Actions)
[ ] Self-hosted

Repro steps:
Run gradle build with setup-java@v4
Expected behavior:
Gradle build to succeed (succeeds with setup-java@v3)
Actual behavior:
Error is thrown:
e: java.lang.IllegalAccessError: superclass access check failed: class org.jetbrains.kotlin.kapt3.base.javac.KaptJavaCompiler (in unnamed module @0x7c548429) cannot access class com.sun.tools.javac.main.JavaCompiler (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.main to unnamed module @0x7c548429

seems it relates to https://youtrack.jetbrains.com/issue/KT-60507/Kapt-IllegalAccessError-superclass-access-check-failed-using-java-21-toolchain

Hello @alghe-global
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

Hello @alghe-global, Could you provide the steps to reproduce the issue or share a public repository that replicates it?

Hello @alghe-global, just a friendly reminder to provide the steps to reproduce the issue or share a public repository that replicates it. Thank you!

Hello @alghe-global,
We are closing this issue for now due to inactivity. Please feel free to reach out if the issue persists, and we can reopen it.


Invoicing page should provide more statistics

The invoicing page should add more statistics for costs so that this does not need to be done manually. An example of what is needed is here https://docs.google.com/spreadsheets/d/1AuBqQcUE97NmLW0BuAGSZT5eZfb3suu1amdxusmsNik/edit#gid=0
(let wshands know if you cannot access it)

Invoicing is being put aside. This ticket is being reprioritized.


implement starknet-rs for trace endpoints

Closes #17
Added initial support for crafting an array of transactions.
Fixed some bugs in the params builder (use structuredClone to deep clone objects instead of performing a shallow copy).

@jelilat is this getting reviewed anytime soon? I keep resolving conflicts with main but this is not sustainable.

@saimeunt What you should do in this case is to rebase. That's easier and you won't have to keep resolving conflicts.
git rebase main

@jelilat you're right I made another PR for call endpoint I'm not sure why it ended up in this PR too, I must have done a mistake in cherry-picking commits, anyway that's fixed now 👍


[noetic-devel][Windows] Fix file COPY cannot read symlink

A recent change from #1100 introduced an usage of file(COPY) and unfortunately this idiom has some limitation on Windows. For example, CMake doesn't support the case where the source file is a symlink, due to the absent of ReadSymlink implementation on Windows.
And when the conditions are met, it will render as errors like below:
-- rospy_tutorials: 2 messages, 2 services
CMake Error at C:/opt/ros/melodic/x64/share/catkin/cmake/catkin_install_python.cmake:45 (file):
  file COPY cannot read symlink
  "C:/workspace/rospy_ws/src/ros_tutorials/rospy_tutorials/001_talker_listener/listener"
  to duplicate at
  "C:/workspace/rospy_ws/build_isolated/rospy_tutorials/catkin_generated/installspace/listener":
  No error.
Call Stack (most recent call first):
  CMakeLists.txt:14 (catkin_install_python)

This pull request is to make the file copying conditional and unblock any build breaks due to the limitation. And please consider to back-port to kinetic-devel as well.

Thanks for the patch and the quick response.

Cherry-picked to kinetic-devel in 232339eed0f04d6325443747faefabd4aa059289.


⚠ ClamAV has degraded performance

In 7960033, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 5a96fe9.


Separate VM from HintExecution: Phase 6 (Separate hint compilation)

This PR aims to separate Hint Compilation from the VM.
It does so by creating a the method compile_hint for the HintExecutor trait, that will receive the information related to hint execution (code, ap_tracking, references, etc) and return a struct cast as Any with the data that will be stored in the VM and later be used by execute_hint to execute each individual hint
This PR depends on: #371

Codecov Report

Merging #373 (a0ab631) into memory-proxy (d2ed29a) will decrease coverage by 1.08%.
The diff coverage is 98.79%.

@@               Coverage Diff                @@
##           memory-proxy     #373      +/-   ##
================================================
- Coverage         97.71%   96.63%   -1.09%
================================================
  Files                44       44
  Lines             12206    11606     -600
================================================
- Hits              11927    11215     -712
- Misses              279      391     +112

Impacted Files
Coverage Δ

src/cairo_run.rs
86.06% <ø> (ø)

...t_processor/builtin_hint_processor/blake2s_hash.rs
100.00% <ø> (ø)

...t_processor/builtin_hint_processor/dict_manager.rs
95.88% <ø> (ø)

src/main.rs
5.00% <ø> (ø)

src/types/exec_scope.rs
81.13% <ø> (ø)

src/utils.rs
98.59% <ø> (-0.16%)
:arrow_down:

tests/bitwise_test.rs
100.00% <ø> (ø)

tests/cairo_run_test.rs
98.42% <ø> (ø)

tests/pedersen_test.rs
100.00% <ø> (ø)

tests/struct_test.rs
100.00% <ø> (ø)

... and 37 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Architecture supported?

What arcitecture this Framework supported?
I cant find x86_32 on simulator and arm64 on devices

Looks cocoapods framework got some error,
Now i migrating to Carthage


Dismiss popup using a button

Hello,
I've been using KLCPopup in my project, and I've been trying to dismiss a popup on button click.
Context :
I have a nib with my popup , inside there are 2 buttons (yes, no).
I load my nib into my klcpopup and instantiate it to show on screen
Problem :
When I click on one of the buttons, If I put anything in the IBAction connected to the button in nib, it will crash without telling me one thing in debugger, just gives me a EXC_BAD_ACCESS on AppDelegate class.
code snippets :
my func to show the alert
func showAlertWithButtons(message: String?, title: String?) {
        var nibView = NSBundle.mainBundle().loadNibNamed("buttonAlertView", owner: self, options: nil)[0] as? UIView
        alertTitle.text = title!
        alertMessage.text = message!
        var mainWindow = UIApplication.sharedApplication().keyWindow
        nibView?.frame = CGRectMake(nibView!.frame.origin.x, nibView!.frame.origin.y, mainWindow!.frame.size.width, nibView!.frame.size.height)
        alertPopup = KLCPopup(contentView: nibView, showType: KLCPopupShowType.SlideInFromRight, dismissType: KLCPopupDismissType.GrowOut,
            maskType: KLCPopupMaskType.Dimmed, dismissOnBackgroundTouch: true, dismissOnContentTouch: false)

        alertPopup!.show()
    }

my IBAction
    @IBAction func didClickOnYes(sender : AnyObject)
    {}

my nib

I tried setuping a nsnotification in my IBAction but it crashes.
Is there a way to dismiss my popup from an IBAction, if so what am I doing wrong ?

Same for me: as soon as I add an UIButton and connect it to an IBAction, if I try to clic the button, it crashes my app with the EXC_BAD_ACCESS, no log, no exception raised on breakpoints... Help plz :)

Found a solution: http://stackoverflow.com/a/32438937/2042510
If your nib is linked to a ViewController, this controller is automatically released once the code of your method is executed. So your action cannot be triggered (more details in my stack overflow post).
Move your nib declaration to a class variable, this should do the trick ;)

Nice one thanks! will do that. Tried to simplify my code too much I guess haha!

Pas de souci, j'ai fait exactement la même erreur! bonne continuation ;)

yep à toi aussi!


sleep in qemu to short

Describe the bug
When I try to use sleeps in qemu_x86 they are a lot shorter than expected. I tried to modify CONFIG_SYS_CLOCK_TICKS_PER_SEC and CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC. However both of them did not appear to have a big impact on this behaviour.
I currently use k_sleep(K_HOURS(200)); to sleep around 1 second.
Expected behavior
The expected behaviour is that sleep lasts roughly as long as specified.
Impact
annoyance

I suspect this is because of ICOUNT, disable ICOUNT and see if you get the results you are expecting

Thanks yes disabling icount solves the issue


Add a special client for scipp.

WIll need https://github.com/scipp/scippneutron/pull/115 which is merged but, as of this writing, not yet released.

https://github.com/scipp/scippneutron/pull/115 was released in 0.4.1.


 JUST A LITTLE BACKGROUND ABOUTY ME I HAVE AN EXTENSIVE BACKGROUND IN ELECTRICAL ADVANCEMENTS IN OUR GRID TECHNOLOGY AND FOR THW 15 TO 16 YRS I WORKED AS A CONTRACTOR FOR AN INTERNATIONAL COMPANY KNOWN AS NATIONAL GRID WHICH IS AN INTERNATIONAL ELECTRICAL COMPANY WERE I WAS ONE OF 5 TOP ELECTRICAL ENGINEERS I WENT TO MIT for advance science in electrical theory I also have my doctrine a Harvard in Boston for electrical science engineering and alternative power sources I am an expert in a field people do not know a lot about so please help me get involved and I'm sure we can setup utility bill payments or be the first comp of its kind to accept Crypto currency like the best BCB screw the rest hello

   I AM HOPING I CAN ASK YOU TO MAKE NYSERLF USEFUL WITH IN THE ORGANIZATION THAT I HAVER NEVER UNTIL BCB COME OUT TO PLAY THAT I SERIOUSLY WANT TO GET IN VOLVED. JUST A LITTLE BACKGROUND ABOUTY ME I HAVE AN EXTENSIVE BACKGROUND IN ELECTRICAL ADVANCEMENTS IN OUR GRID TECHNOLOGY AND FOR THW 15 TO 16 YRS I WORKED AS A CONTRACTOR FOR AN INTERNATIONAL COMPANY KNOWN AS NATIONAL GRID WHICH IS AN INTERNATIONAL ELECTRICAL COMPANY WERE I WAS ONE OF 5 TOP ELECTRICAL ENGINEERS I WENT TO MIT for advance science in electrical theory I also have my doctrine a Harvard in Boston for electrical science engineering and alternative power sources I am an expert in a field people do not know a lot about so please help me get involved and I'm sure we can setup utility bill payments or be the first comp of its kind to accept Crypto currency like the best BCB screw the rest


Rename "Tezos SDK for Unity" to "Tezos Unity SDK"

Renamed the name of the SDK as "Tezos Unity SDK" for the planned rebranding.

@efetez You'll also need to change this line for the TOC heading:
https://github.com/trilitech/tezos-developer-docs/blob/staging/sidebars.js#L189

Created this PR to add the TOC change: https://github.com/trilitech/tezos-developer-docs/pull/369


pass server cert to charm_tracing

Partial fix to #208
what is missing is: figuring out what ca certificate we want to use to encrypt the traces.
It should be a ca that tempo is trusting as well!

Hello @PietroPasotti
Thanks for openning this PR. Based on your solution I started drafting #212, it is still a WIP as I have not yet figured out the unit test.
I have a few notes/questions:

Why can't the requirer of tracing use http? it seems to me that tempo is specifying the endpoing not the requirer.
The CA I am using is the root CA generated by self signed certs and it seems to work, I don't think that it is trusted by tempo. Could you please take a look?
If this isn't the right approach, we can still provide the same CA and instruct the user in the docs to do one of two things: 1. use the self signed certs charm as the tls provider of tempo. Or 2. integrate tempo and self signed certs using the certs transfer integration.

Hello @PietroPasotti
Thanks for openning this PR. Based on your solution I started drafting #212, it is still a WIP as I have not yet figured out the unit test. I have a few notes/questions:

Why can't the requirer of tracing use http? it seems to me that tempo is specifying the endpoint not the requirer.
The CA I am using is the root CA generated by self signed certs and it seems to work, I'm not sure how is it being trusted by tempo. Could you please take a look?
If this isn't the right approach, we can still provide the same CA and instruct the user in the docs to do one of two things: 1. use the self signed certs charm as the tls provider of tempo. Or 2. integrate tempo and self signed certs using the certs transfer integration.

btw, I don't insist having this done in my PR, we can get this one merged instead, I just wanted to test something that works.

FYI, will merge #212 soon @PietroPasotti.


Workshopping a ROS / Gazebo Tutorial Page to Land Under "Related Projects"

Quite a few users having a hard time figuring out how to make ROS 2 work with modern Gazebo. I propose we add a page under "related projects" that summarizes resources related to ROS / Gazebo integration. I intend to the solicit the community for resources they find useful.
Here is an initial "strawman" list.

Main Gz Docs
Gazebo Classic Migration
ROS / Gazebo Installation Guide
ROS 2 / Gazebo Project Template
ROS 2 / Gazebo Example Code
Gazebo Community Forum
Gazebo Sim Forum
Gazebo Source Code
GazeboList.md
Gazebosim Simulation Assets (aka Fuel)
Gazebo Plugins

I've attached a list of other potential resources to go through that we think are worth adding. @RyanF says that he would be up for helping us reduce the attached list into a useful guide.

Thanks for this starter!

@Ryanf55 I think this directory would be a good place for this to land.  @clalancette has final say on location, and may have differing opinions.

LGTM for a central landing page. Only tutorials that are maintained should go there.

I started by overhauling the Gazebo.rst page to have tabs for Ignition and Garden or Newer

This shouldn't be necessary.  Starting with Rolling/Jazzy, we are going to just be using a particular version of Gazebo with a particular version of ROS 2.  So we just need to update everything to use gz.  Also, we should also coordinate with https://github.com/ros2/ros2_documentation/pull/4311 and https://github.com/ros2/ros2_documentation/issues/3340 , where similar things are being discussed.

Subbed! I'm interested to ensure the tutorials work with humble/harmonic combination that ROS aerial is actively using. Per the last working group meeting, we're hoping to help improve official documentation on setup.

Thanks for the headsup @Ryanf55! I was a bit too quick with creating my draft PR it seems for some improvements but I can close that and coordinate with you all.
At least from the issue I was part of, the issue was that it was unclear what the recommended gazebo is for the distro from the preliminary of the documentation, as one doc says harmonic (gz) and the other says fortress (ign), so at least advising it to install it as dependency from ros-gz would ensure the right version for the ros bridge.
but that being, if all will be updated to gz then maybe we should wait a bit indeed.

I plan to bring this up in our Gazebo team meeting today, but my preference would be to have a minimal tutorial here showing how to install ros_gz with the assumption that they would use the officially paired version of Gazebo (e.g Humble/Fortress) and to point users to gazebosim.org for more in depth tutorials that discuss how to use Gazebo itself or how to set it up with different versions of Gazebo.

Sounds good! Perhaps this just needs to have a gz -h or ign -h and conclude the tutorial there.

Alright just let us know what comes out of the meeting @azeey. From what you are explaining I can perhaps assume that my PR is more closer of what you had in mind, since that is what we discussed in the issue beforehand. It is only missing extra resources on the bottom (like those that @kscottz assembled above). But just let me know what you decide from the gazebo meeting.

There was agreement at the meeting with what I said in https://github.com/ros2/ros2_documentation/issues/4302#issuecomment-2070261541. We can expand the ROS related tutorials in gazebosim.org/docs or create new ones as need be. I feel like there's still a lot of confusion as to which version of Gazebo should be paired with a version of ROS. Any clarifying content that y'all can add is most welcome.

You got it. I'll work with Kim.


Setup Github pages

coverage: 93.418%. remained the same
when pulling 3b5be9d50516462794cf27ba9de4111ccdc1ca2c on gitHubPages
into 255c54efd727388903c5f2c9e1cf591652f79484 on master.


NuGet v3 autocomplete down

https://api-v3search-0.nuget.org/autocomplete?q=xunit&take=10000
results in

Thanks for reporting and sorry about the inconvenience. It should be up now.


fix(accordionitem): change onClick to onHeaderClick

Closes #950
Summary
onClick handler should have been onHeaderClick which is the prop Carbon accordion uses to trigger.
Change List (commits, features, bugs, etc)

Switched onClick to onHeaderClick in AccordionItem

Acceptance Test (how to verify the PR)

Open accordion story and try clicking on the content of the accordion.

:tada: This PR is included in version 2.46.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cirq-superstaq

cirq-superstaq is a client of SuperstaQ. This pull request moves cirq-superstaq from https://github.com/SupertechLabs/cirq-superstaq for easier maintenance.

Discussed in Cirq Sync. Need to make an RFC.


add fluid

closes #763

add class fluid: A fluid is a material entity which is a liquid or a gas.
turbine uses some fluid
pump uses some fluid
fluid EquivalentTo 'material entity' and ('has state of matter' value gaseous or 'has state of matter' value liquid or 'has state of matter' value plasmatic)

I also had to change water turbine uses only hydro energy to water turbine uses **some** hydro energy because it lead to unsatisfiable classes. However, this is part of bigger problem discussed in #761.

You're right, I added it now.


Leverage java 17 features

The openstreetmap model now uses sealed interfaces and records. The consumers have been replaced by functions in order to have a side-effect free pipeline. Some classes have also been moved in the utils package.

I think we can keep the Java 17 pattern matching style and update as soon as we can to pattern matching for switch expressions in Java 19, or Java 21 (LTS) in september 2023.

Yes, this is the intent. I would prefer if we wait for the next LTS before using pattern matching.

@Drabble Thank you for the review. I just ran the benchmark to check the effect of the change before merging. Operating via consumers and side effects is apparently much more efficient (~4s) than with functions without side effects (~7s).
Here are the flamegraphs:

Apparently, list creation via the Stream.toList method is the cause of the issue. I will probably make another branch and cherrypick a couple of commits (e.g. removal of the visitor pattern), but keep the consumers for now.


feat(binaries): fetch binary at runtime

internal note: squash this

Removing docker integration tests for now because they fail with this error:
{"timestamp":"Jan 06 21:06:01.267","level":"ERROR","target":"mobc","fields":{"message":"mobc failed to connect: Compat { error: ConnectionError(ErrorMessage { msg: \"Cannot assign requested address (os error 99)\" }) }","log.target":"mobc","log.module_path":"mobc","log.file":"/root/.cargo/registry/src/github.com-1ecc6299db9ec823/mobc-0.3.2/src/lib.rs","log.line":455}}

and I've already spent too many hours to figure out why, but didn't succeed.
Running this in a docker file in an external project works fine, just somehow it does not when run in a directory in this project.


Change module deependencies to include data sources

Fixes #131
Signed-off-by: Yussuf Shaikh<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @Prajyot-Parab @bpradipt

/cc @Prajyot-Parab @bpradipt

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Prajyot-Parab, pravin-dsilva, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Prajyot-Parab, pravin-dsilva, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, Prajyot-Parab, pravin-dsilva, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, Prajyot-Parab, pravin-dsilva, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create Count Subsets with Sum K.cpp

Cpp code to count Subsets with Sum K.

@gaurangbiyani-2021 Thank You for your contribution


testset.jsonL

Description
Fixes #2057
Related Issue
Fixes #2057
Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[X] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[X] I've read the CODE_OF_CONDUCT.md document.
[X] I've read the CONTRIBUTING.md guide.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.
[ ] I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
modified)

@PierreMesure good catch! Could also update the RAGReport.load method to use .jsonl instead of .json when loading the testset, please?


kubernetes backend - step name with spaces causes label error

Component
agent
Describe the bug
Having a pipline like:
steps:
  - name: build image
    image: plugins/docker

on a woodpecker 2.2.2 server with kubernetes backend I get the following error:
Pod "wp-01hmywxc67eps76kjkryer0rc6" is invalid: metadata.labels: Invalid value: "build image": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

This has worked before on the 2.1.x version
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.2.2"}

Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

What is expected behavior, apart from This has worked before? What label should be in your opinion?

@zc-devs Currently, all pipelines with steps, which contain a space in the name don't work at all. I don't expect a certain label on pods (for steps). Only when all steps don't have spaces it works. I'm currently blocked on all pipelines which have spaces in the step name.

Yes I think that was the behaviour before. The problem has been introduced by #3204 I think, where the step name is now used to label the pod. That wasn't the case before. Now when a step name doesn't correspond to valid k8s-label regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?'), it will fail. A translation of non-valid characters (according to label spec) to hyphens would be the best solution for now IMO. It might be worth adding a test in pod_test.go, where a step has a non basic naming, like "build & deploy".


rev to the latest package:lints

rev to the latest package:lints

Thanks for the review (note that you'll need to merge this).


make tableacl.load public

This small change eases the table acl related unit tests in other components.
One can inject new table acl from a byte array instead of loading it from a
file.

@henryanand


consolidated sendRequest functions, send X-Filestack-Source header

Consolidated send request functions
send header X-Filestack-Source with every request

Coverage remained the same at 100.0% when pulling 9b61464e70037dcbcae1bc449afff595bbf6f59e on feature/FS-1030-source-version-header into 545f7c7b3ccf242be9a45ea30b41e94612c70ba9 on develop.

Coverage remained the same at 100.0% when pulling 9b61464e70037dcbcae1bc449afff595bbf6f59e on feature/FS-1030-source-version-header into 545f7c7b3ccf242be9a45ea30b41e94612c70ba9 on develop.


too short default timeout value (0.005ms)

Default value for timeout is 5 microseconds, and that is one very aggressive timeout.
Our 'redis-centric' apps were throwing unusual errors EAGAIN (Resource temporarily unavailable - Timeout reading from the socket) from time to time.
Problem was fairly easy to reproduce with apache benchmark (ab) hitting our sinatra app ten thousand times
After some research, I narrowed down the problem to the too short of the timeout (5 microsecond), and experimented with increased timeouts. At 50 microseconds, it was much less likely to happen, but still happened once or twice for every 100k requests. 100 microseconds seems to be the shortest possible timeout that does not cause any issues in our environment (Slicehost servers).
I think, that default value for timeout should be changed out to a safer, larger value of 100 microseconds. After all, 0.1ms is still a fairly short timeout. Larger value will provide even more safety margin (1ms, anybody?), but 0.1ms seems to be a bare minimum.

The default timeout is 5s, you can refer to lib/redis/client.rb to check it out. With a 5us timeout every request is very likely to time out instead of only a few. Are you creating a new Redis connection per request when doing the benchmark? This may cause a back-up in socket allocation, and subsequently cause timeouts.

You are correct indeed, I got confused with unit of measure transformations.
Oh well, I still need to find out what the real problem is. We do not create a new Redis connection per request and instead reuse same one over and over (no pooling, no threading, problem reproducible with concurrency of 1).
This problem is very strange indeed, as ab test reported that max request processing time was 50ms (with mean 2.5ms) - all those tests are doing is fetching Redis.info. How could it expire timeout of 5s if no request ever crossed 50ms ?
All I know now is that if I push the value of that timeout higher, from 5 to 100, it definitely helps. Why and how, is a mystery :)

Can you try debugging the client to see how long every call takes (including timed out calls)?
Attaching a logger can be done like this:
require 'logger'
logger = Logger.new(STDOUT)
logger.level = Logger::DEBUG

redis = Redis.new(:logger => logger)

Thank you for idea!
I tried and I have to report that usually those redis.info requests are served in under 1ms, sometimes (rarely) it can be as high as 200ms, which is still low enough. Those requests that 'time out' seems to do so quickly, in <1ms as well.
Forcing reconnect before processing each and every request, by the way, takes care of this problem entirely. Of course, it introduces a new one, about 8k requests OS seems to run out of sockets and test aborts.
It looks like this issue is not really about timeouts, it is some other problem that is masquerading itself as timeouts.

Finally, some interesting discovery.
Problem is happening only with hiredis driver, as soon as I utilize either 'ruby' driver or 'synchrony', there are no 'timeouts', even if I set 'timeout' setting to extremely low value of 0.01s (this setting causes hiredis driver to fail 5% - 90% of 100 requests).

That doesn't sound good. Can you provide me with as much details as possible about your environment (OS, Ruby version, hiredis version, etc), and give a particular snippet that is able to reproduce the observed timeouts? Thanks!

I was able to reproduce problem in irb. Environment and test case below.
Another interesting data point is that problem is easily reproducible on Ubuntu 10.04 (our servers) and is NOT reproducible on Mac OS 10.6 (my development environment).
I understand that 0.01s is not a great timeout, but it allows for a faster test case here. If one desires to test with default timeout of 5s, test command should be completed not 100 times, but 10k times - results in same failure.
Environment:
Ubuntu 10.04
ruby 1.9.2p290
hiredis 0.4.1
redis 2.4.4

Test case:
$ bundle exec irb
>> require 'redis'
=> true

>> r = Redis.connect(:timeout => 0.01, :url => 'redis://foo.bar.com:6301/0')
=> #<Redis client v2.2.2 connected to redis://foo.bar.com:6301/0 (Redis v2.4.4)>

>> 100.times { r.info['used_memory_human'] }
=> 100

>> r.client.connection
=> #<Redis::Connection::Ruby:0x00000002731570 @sock=#<TCPSocket:fd 5>

>> require 'redis/connection/hiredis'
=> true

>> r = Redis.connect(:timeout => 0.01, :url => 'redis://foo.bar.com:6301/0')
=> #<Redis client v2.2.2 connected to redis://foo.bar.com:6301/0 (Redis v2.4.4)>

>> r.client.connection
=> #<Redis::Connection::Hiredis:0x000000020c6dc0 @connection=#<Hiredis::Ext::Connection:0x000000020c6cd0>

>> 100.times { r.info['used_memory_human'] }
Errno::EAGAIN: Resource temporarily unavailable - Timeout reading from the socket

Thanks for writing this up. I'm going to play with this for a bit and will let you know what I can find.

You are welcome.
Good luck hunting for the issue!

I just pushed a new version of hiredis-rb that should fix this issue. The problem was that the timeout value that gets passed to Ruby's select(2) is modified in place. Now, hiredis-rb passes a copy of the timeout so it doesn't progressively become smaller and eventually causes EAGAIN. Can you let me know if using a newer version of hiredis-rb fixes the issue for you?

Happy to confirm that new version of hiredis (0.4.3) fixes the problem.
Your turnaround time on this issue is incredible.
Thank you!

Thank you for the comprehensive error report. Glad that this resolves the issue.


[BUG]Recently I got a SpotifyAuthenticationException: PremiumAccountRequired

Describe the bug
During logging this was reported:
File "/home/pi/Oradio_new/spotify_music_player_service.py", line 169, in connect
self.session = Session.Builder().stored_file().create()
File "/usr/local/lib/python3.9/dist-packages/librespot/core.py", line 1275, in create
session.authenticate(self.login_credentials)
File "/usr/local/lib/python3.9/dist-packages/librespot/core.py", line 697, in authenticate
self.__authenticate_partial(credential, False)
File "/usr/local/lib/python3.9/dist-packages/librespot/core.py", line 1055, in __authenticate_partial
raise Session.SpotifyAuthenticationException(ap_login_failed)
librespot.core.SpotifyAuthenticationException: PremiumAccountRequired
To Reproduce
Expected behavior
The librespot package was running for several month without any issues like this
Screenshots
If applicable, add screenshots to help explain your problem.
Client Information (please complete the following information):

Linux on RaspberryPi
Python Version [e.g. 3.9.0]

Additional context
The same issue was reported at https://github.com/librespot-org/librespot-java/issues/614
The solution was to update the protocol version of the spotify client.
I did same thing in the spotify python code:
def standard_build_info() -> BuildInfo:
return BuildInfo(product=Product.PRODUCT_CLIENT,
product_flags=[ProductFlags.PRODUCT_FLAG_NONE],
platform=Version.platform(),
#version=112800721)
version=117300517)
...AND now it works again. Maybe something to include in the code.

duplicate https://github.com/kokarare1212/librespot-python/issues/193

OK, now i see there is already on update. I will update my package with new version.
Thanks


stuck in seemingly infinite loop

I have criterion tests running on a build server that managed to get stuck in a seemingly infinite loop.
It ended up making a 1TB log over 3 days.
Is it expected that an infinite loop would be possible?

Hey, thanks for trying Criterion.
1TB! Wow! No, that definitely isn't expected. There was a bug in a recent version of Criterion where it would sometimes calculate wildly wrong iteration counts and sit there spinning for a really long time, but that's been fixed for a while now. If you're using an old version, you might want to update.
Otherwise, could you post any interesting-looking bits of the log file? 1TB is a lot to search through. You can also set the environment variable CRITERION_DEBUG=1 to get Criterion.rs to generate some extra debug output, just in case that helps.

oh worth saying though from what I did see of the log it looked like it was in the reduce phase where it had found a failure and was trying to make a nice test case

I'm sorry, now I'm confused - Criterion.rs doesn't have a reduce phase; as a benchmarking framework it's not so much concerned with test cases. You might be thinking of Quickcheck or Proptest?

well now I'm embarrassed 🤕 mixed up quickcheck and criterion

No worries, I hope you manage to find a solution to this problem.


[CLOSED] Add property support to entity

 Issue by GoogleCodeExporter
Monday May 11, 2015 at 22:05 GMT
Originally opened as https://github.com/twogee/missing-link/issues/22

It would be nice to be able to retrieve the contents of an entity from a
property, e.g. <entity property="artifactory.build.info"/>.

I have implemented this in a local copy but as I have incorporated in the patch
in issue 13, a patch would not be that short and sweet. Anyway, it is trivial
to implement this.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 16 Aug 2011 at 11:22

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 22:05 GMT

Original comment by<EMAIL_ADDRESS>on 18 Aug 2011 at 12:30

Changed state: Accepted
Added labels: Milestone-1.1.3, OpSys-All, Type-Enhancement
Removed labels: Type-Defect

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 22:05 GMT

Added a "value" attribute to the entity node, which takes precedence after the
file parameter but before textual content nested inside <entity>..</entity>.
This is a simple String property, ant takes care of expanding properties
automatically in this scenario.

Example:  value="Hello World" or value="${my.prop}"

Will be available in 1.1.3

Original comment by<EMAIL_ADDRESS>on 18 Aug 2011 at 12:54

Changed state: Fixed

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 22:05 GMT

Original comment by<EMAIL_ADDRESS>on 19 Aug 2011 at 12:51

Added labels: Project-ant-http


Pub should have an HTTP timeout on CURL-based requests

Currently, Pub has times out all HTTP requests made directly through dart:io after thirty seconds. It should time out CURL-based HTTP requests as well.

This issue has been moved to dart-lang/pub#305.


UAT | Draft for Issue Notice as Pending Task

For Case kumar ch vs Respondent ch, the judge drafted the order for notice.
However the order for notice was drafted, however, the notice was not issued.
At the stage, a pending task should be visible to the judge to issue notice.

Hi @Ramu-kandimalla,
Test case (Solution QA):

verify that the pending task for the judge is visible when the issue notice order is drafted.
(Note: If the issue notice order has already been generated and we attempt to draft the issue notice again for the same case, the pending task for the judge is not displaying.)

url : https://dristi-kerala-qa.pucar.org/digit-ui/employee/user/login
user/pw: qaJudge01/Beehyv@123
Reference link:https://jam.dev/c/3a4c594c-7ddd-46bb-ae20-85cf5df5daaf

Hi @Ramu-kandimalla,
Verified this issue in the UAT solution, and it is working as expected.

Its working fine In UAT env.
https://jam.dev/c/a876324b-b19d-4d6b-9c41-499e1a3efd69


DDR5 yaml configuration

Hi all!
I would like to use ramulator2 to test DDR5, but I couldn't find any yaml config file on the repo.
Initially, I modified the example provided ([example_config.yaml](https://github.com/CMU-SAFARI/ramulator2/blob/main/example_config.yaml)), putting org.preset = DDR5_8Gb_x16 and timing.preset = DDR5_3200AN. This doesn't work as (afaiu) the configuration should include additional parameters that aren't available (group RFM). Could you point me towards a configuration file or some documentation?
Thanks!

Hi,
if you add "RFM" under DRAM in the config file, it will work

good luck!


”Cărbunari”, ”Știnăpari” are listed in the drop-down menu

Description:
When user writes ”Cărbunari”, ”Știnăpari” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cărbunari"

Expected results
The location appears in the drop-down menu as "Cărbunari, Caraș-Severin(Cărbunari)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Știnăpari"

Expected results
The location appears in the drop-down menu as "Știnăpari, Caraș-Severin(Cărbunari)".


GroupedObservable not available in Rx namespace

I'm writing a function in Typescript that takes the result of an Observable groupBy, and I can only type the parameter as Observable<any> because I can't get to the GroupedObservable type.
Should it be exported in Rx.ts?
RxJS version:
5.0.0-rc.2

Not sure if I understood correctly, is it not able to import type from groupBy?
import {GroupedObservable} from 'rxjs/operator/groupby';

hmmm wonder if we should move the class (and any others like it) into rxjs/observable since that's prolly more obvious. e.g. rxjs/observable/GroupedObservable

@jayphelps I think that's considerable ergonomics, just not sure if it need to be exported in top level (rx).

@kwonoj yeah, we're not exporting any of the other operator-specific Observables from root, and I'd personally prefer not to have to export everything in the world at the root cause it makes us less flexible down the road as we consider kitchen sink stuff.

Actually this issue https://github.com/ReactiveX/rxjs/issues/2207 reminded me about this one as well - if top level export is missing, UMD build won't have access to those. So if we're considering GroupedObservable as public interface, it probably need to be Rx, or vice versa.
I've been waiting internal scope long time to avoid this kind of confusion (https://github.com/Microsoft/TypeScript/issues/5228) but seems it won't happen soon, so we may need control public exposure via top level Rx namespace.

I'm closing this for now, first if it's for type definition it should work without top level export, otherwise it need to be discussed to be included in top level separately.


Fix bug with transformers 4 34

As per title.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update Loopback.md

tweak formatting

@paulmon,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/develop-your-app/Loopback.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update mono props: support OSX and more .NET Framework versions

A potential solve for #6180 that uses msbuild built-ins to determine the target OS and pivots off of that to set the FrameworkPathOverride.  I included a MonoRoot property to allow for easy integration into the build process that fsharp/fsharp uses, which allows for a 'floating' mono root.
Testing this locally on my OSX laptop seems to have the intended effect: for all TFMs below I can pivot to the correct -api folders, and supplying a MonoRoot via MSBuild parameter influences the search paths as expected.

@brettfo, can you run your eyes over this pls
Thanks
Kevin

If we add this I'd like a test leg to ensure it continues to work.  I'm not positive, but I think the Linux VMs for our CI server have mono installed.
Can you add the following to .vsts-pr.yaml:
 jobs:
 - job: Linux
   pool:
     vmImage: ubuntu-16.04
   timeoutInMinutes: 90
   strategy:
     maxParallel: 2
     matrix:
       dotnet_sdk:
         _command: make
         _args: Configuration=release
+      mono:
+        _command: xbuild # or `mono` or however you invoke this
+        _args: fsharp.proj # this might contain too many projects to work on mono
-      # disabled until it can be properly fixed
       release_fcs:
         _command: ./fcs/build.sh
         _args: Build
 steps:
 ...

It'd be good to add a dotnet build for a net4X-targeting project, I can add that straightaway.  Is there such a thing as an MacOS runner for VSTS? That's the other part of the change that's added here.

There should be a hosted macOS (the CLI uses one) but I'm not sure how to hook it up

Ok, I found the vm identifier for the macOS runner on VSTS, I've added a matching set of jobs for that OS, and added a job that does a .net-framework build of some part of the repository at all to verify the FrameworkPathOverride changes (as well as fighting with case-sensitivity at least 10 times). Now to just iterate on that to get the build green.

Actually, per @KevinRansom's comments on another thread, I think I'll remove the 'build-netframework-anything' job for now because it's going to require additional work and may conflict with upcoming build system changes that @brettfo has. So given that, I think adding the macOS runner and having it run the same jobs as the linux runner is an acceptable next step for this.

The failed build was a nuget download error on linux. What do?

This!

I don't know what this single test failure is on the windows FCS tests, and it hasn't failed before. This is mildly irritating.

The FCS tests are very flaky, so sometimes it just takes a while 😕

Glory be, they are green!

@baronfel,
Thanks for this
Kevin


Use consign autoload

Use consign for autoload models, routes, schemas, configs, controllers, object maps... etc...

This feature will not be implemented for the reason that consign and koa-mount module should not work together


[Fix] Fix frequency penalty when sampling

Before this PR, we pass presence penalty to both arguments of ApplyPresenceAndFrequencyPenaltyOnCPU

cc @Kartik14 let me know if this is right, thanks!


pyproj fails with Fortran-order input

Lon, lat input arrays in Fortran order (such as one might read from a Matlab mat file) cause a RuntimeError:
import numpy as np
from mpl_toolkits.basemap import Basemap

order = 'F'   #  works if this is 'C'
shape = (2, 4)
lon = np.ones(shape, dtype=float, order=order)
lat = 20 + np.ones(shape, dtype=float, order=order)

m = Basemap(width=10000, height=10000, lon_0=0,
            lat_0=10, lat_1=20, lat_2=30,
            projection='lcc')
m(lon, lat)

I think a reasonable place to fix this will be proj.Proj.__call__() via np.ascontiguousarray() calls.

Hi @efiring : could you please check if this is related #209.
Cheers

Yes, this looks like a duplicate of #209, in which case the problem becomes one of getting an updated Basemap into widespread use, starting with Anaconda.

Yes, I was waiting for a few other PRs to finalize, but perhaps I shouldn't
hold off much longer.
On Thu, Feb 18, 2016 at 11:15 AM, Eric Firing<EMAIL_ADDRESS>wrote:

Yes, this looks like a duplicate of #209
https://github.com/matplotlib/basemap/issues/209, in which case the
problem becomes one of getting an updated Basemap into widespread use,
starting with Anaconda.
—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/basemap/issues/266#issuecomment-185796473.

@WeatherGod Here's my suggestion.  Make an issue of the next release with tasklist of what should be done for the next release, and give it an anticipated date for the next release.
This will give us contributors time to fix issues.


Request to add a link to Molfeat notebooks for Graphcore IPU

📖 Documentation
I've written two notebooks based on the tutorial that show how to use Molfeat + Graphcore IPUs to fine-tune a pre-trained Transformer model and to train a GINE model.
Ideally it would be nice to add a short section on the main README to point towards these notebooks.
Something like this below? I've tried to keep it brief and not like advertising, but please feel free to change as you see fit.

Molfeat on the Graphcore IPUs
Two examples showing how to integrate Molfeat with the Graphcore IPUs can be found below.

  Training a GNN with Molfeat featurisers
 Fine-tuning a pre-trained Transformer

Then here for your information are some more links to the notebooks on our Github, on Paperspace where they can be run with access to IPUs, and the Run on gradient link with the shortened URLs.
The PyTorch Geometric one:
https://github.com/graphcore/Gradient-Pytorch-Geometric/blob/main/molfeat/pytorch_geometric_molfeat.ipynb
https://console.paperspace.com/github/graphcore/Gradient-Pytorch-Geometric?machine=Free-IPU-POD4&container=graphcore/pytorch-geometric-jupyter%3A3.2.0-ubuntu-20.04-20230331&file=molfeat%2Fpytorch_geometric_molfeat.ipynb

The Transformer one:
https://github.com/graphcore/Gradient-HuggingFace/blob/main/molfeat/transformers_molfeat_finetune.ipynb
https://console.paperspace.com/github/graphcore/Gradient-HuggingFace?machine=Free-IPU-POD4&container=graphcore/pytorch-jupyter%3A3.2.0-ubuntu-20.04-20230331&file=molfeat%2Ftransformers_molfeat_finetune.ipynb

Hi @s-maddrellmander,
Thank you for showcasing how to use molfeat on IPUs! That's exciting! :rocket:
As we love community contributions, we decided to create some dedicate space in our documentation to highlight and celebrate such contributions. This would be the perfect place to then also feature these tutorials! How does that sound? I don't expect this to take us very long and I'll get back to you as soon as we have something to show.

xref #59
ping @s-maddrellmander


Bugfix: add some c++ standard support check.

check c++11/c++14 support in common.mk

Signed-off-by: Ji Bin<EMAIL_ADDRESS>

many thanks


MNT Use simple matrix

Issue https://github.com/silverstripe/gha-ci/issues/37
Blocked by https://github.com/silverstripe/silverstripe-elemental/pull/992

Consistently failing on MFA build


fix outdated imports in the CuPy backend

In current master, the example below fails with
AttributeError: module 'unumpy.cupy_backend' has no attribute '__ua_domain__'
This ends up being due to some outdated imports that are updated in this PR.
import uarray as ua
import unumpy as np
import unumpy.cupy_backend as CupyBackend

with ua.set_backend(CupyBackend, coerce=True):
    ret = np.add([1], [2])

Thanks, @grlee77


Automated Package Upgrade

:tada: This PR is included in version 25.4.137 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for Azure, OpenAI, Palm, Anthropic, Cohere, Replicate Models - using litellm

This PR adds support for models from all the above mentioned providers using litellm https://github.com/BerriAI/litellm - a simple & light package to call OpenAI, Azure, Cohere, Anthropic API Endpoints
Here's a sample of how it's used:
from litellm import completion

## set ENV variables
# ENV variables can be set in .env file, too. Example in .env.example
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion("command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

Hi @ianarawjo can you please take a look at this when you get a chance ?
If this initial commit looks good, happy to add more testing/docs on how to use all the model liteLLM provides

Hi Ishaan, see the comment on this issue: https://github.com/ianarawjo/ChainForge/issues/112#issuecomment-1661307126
I probably should delete the unused stuff from the old Python backend in the next release, so that this confusion doesn’t crop up again. Note that the current version in TypeScript is also a bit more involved bc of passing and converting chat_history in order to support Chat Turn nodes.


Tab, Shift-Tab does not work properly if Grid is not in edit mode

Marked for next release

Fixed in current master

...scratch that - will need to re-think the implementation. Will target for next release.


Replace PRNG tests with https://github.com/MartyMacGyver/PractRand

Assuming https://github.com/MartyMacGyver/PractRand passes licensing checks, it should be used to validate our PRNG library.

Move this to the usersim repo (for cxplat).


Confusing random bold words in code-blocks of the doc site

Many code blocks of the doc-site present random bold words like:

This should have been fixed by https://github.com/zeppelinos/zos/pull/336. Are you still seeing bold words @facuspagnuolo ?

@elopio thanks! marking it as solved!


[BUG] Unable to claim on the QA WEB env.

[BUG] Unable to claim on the QA WEB env.
Steps to reproduce:

tap on the "Claim" button
observe the result

Actual result:
The 'Sorry, something unexpected happened, please try again.
Error: E3' popup is shown
Expected result:
The user should 'Claim' without any issues
Account info:
MasterSeed - "46e1181fb1c643a5453fa1cebbded5a31b44ae852783cca0e3dcea9b768f8a0f"
Wallet Address - 0x1B744385E6b2a4ee296DfdA1704b55486EF575f8
Environment:
QA WEB app 1.36.1-1
Devices:
Windows 10 // Google Chrome v96
Attachments:
https://app.birdeatsbug.com/sessions/pCQqVAsnX_z5--X41AIzM?

@vldkh you haven't released QA for a while its not updated

@johnsmith-gooddollar please take a look - https://app.birdeatsbug.com/sessions/HIHtaTGmE7oReO_arjIoq

@sirpy @vldkh
The issue is blockchain-related. User wasn't whitelisted after 15sec of FV passed. We forgot to add .catch so we had unhandled rejection. I hotfixed this https://github.com/GoodDollar/GoodDAPP/commit/1f14bdb355480cb63004758c6afc838a5422e250  and increased wait time to 30 sec
@vldkh  pls re-release QA and try pass FV again. If you'll see any issues pls notify me - i will check also server logs. Also i need to know your FaceID to do it

@sirpy @vldkh i see the following Mautic error, but it couldn't affect whitelisting in the blockchain.
all whitelisting operation are running in parallel, each have own .catch.
If there will be an issue with contracts, we had also the "whitelisting after fv failed" error, but we haven't it.
That means the adminApi.whitelistUser(gdAddress, profilePublickey) call was successfull, so the issue is somewhere on the blockchain side. Or it updates slowly. Hope 30sec of wait would be enough
05 Jan 2022 14:14:09.2191212 <190>1 2022-01-05T12:14:09.067403+00:00 app web.1 - - 2022-01-05T12:14:09.067Z - workerId:0 - warn (FROM Mautic ): {"message":"Mautic Error:","context":["request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET",{"type":"FetchError","message":"request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET","stack":"FetchError: request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1461:11)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at TLSSocket.socketErrorListener (_http_client.js:401:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)\n    at process._tickCallback (internal/process/next_tick.js:63:19)","errno":"ECONNRESET","code":"ECONNRESET","name":"FetchError"},{"url":"/contacts/385159/edit","body":{"tags":["claimqueue_claimed"]}}]}
2022-01-05T12:14:09.067Z - workerId:0 - warn (FROM /verify/face/e576CfdA9646805349952cF98e2B738298417fD0 ): {"uuid":"WzsIsrLsjT","message":"updateContact failed","context":["request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET",{"type":"FetchError","message":"request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET","stack":"FetchError: request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1461:11)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at TLSSocket.socketErrorListener (_http_client.js:401:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)\n    at process._tickCallback (internal/process/next_tick.js:63:19)","errno":"ECONNRESET","code":"ECONNRESET","name":"FetchError"}]}
2022-01-05T12:14:09.067Z - workerId:0 - warn (FROM /verify/face/e576CfdA9646805349952cF98e2B738298417fD0 ): {"uuid":"WzsIsrLsjT","message":"Failed Mautic tagging user claimed","context":["request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET",{"type":"FetchError","message":"request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET","stack":"FetchError: request to https://go.gooddollar.org/api/contacts/385159/edit failed, reason: read ECONNRESET\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1461:11)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at TLSSocket.socketErrorListener (_http_client.js:401:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)\n    at process._tickCallback (internal/process/next_tick.js:63:19)","errno":"ECONNRESET","code":"ECONNRESET","name":"FetchError"},{"mauticId":"385159"}]}
2022-01-05T12:14:09.068Z - workerId:0 - warn (FROM Mautic ): {"message":"Mautic Error:","context":["request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET",{"type":"FetchError","message":"request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET","stack":"FetchError: request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1461:11)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at TLSSocket.socketErrorListener (_http_client.js:401:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)\n    at process._tickCallback (internal/process/next_tick.js:63:19)","errno":"ECONNRESET","code":"ECONNRESET","name":"FetchError"},{"url":"/segments/54/contacts/add","body":{"ids":["385159"]}}]}
2022-01-05T12:14:09.069Z - workerId:0 - warn (FROM /verify/face/e576CfdA9646805349952cF98e2B738298417fD0 ): {"uuid":"WzsIsrLsjT","message":"Failed Mautic adding user to claim queue whitelisted segment","context":["request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET",{"type":"FetchError","message":"request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET","stack":"FetchError: request to https://go.gooddollar.org/api/segments/54/contacts/add failed, reason: read ECONNRESET\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1461:11)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at TLSSocket.socketErrorListener (_http_client.js:401:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)\n    at process._tickCallback (internal/process/next_tick.js:63:19)","errno":"ECONNRESET","code":"ECONNRESET","name":"FetchError"}]}Exception

@johnsmith-gooddollar logs after release:
https://app.birdeatsbug.com/sessions/zTGH6lKLr5T8XbIvO-M_X

@vldkh the error now is correct
error:
UnableToWhitelist: Face verification has been passed, but we encountered with issuestrying to allow claiming. Please try again a few minutes later

@vldkh @sirpy
The same issue on Heroku side - just Mautic error, no blockchain errors during adminApi.whitelistUser()'s call
User isn't whitelisted after 30 (!) sec. So there's something wrong with QA contracts or blockchain settings on QA

reverted back to 15 sec awaiting for isCitizen flag is set

@vldkh @johnsmith-gooddollar ok thanks. I think I know what is the problem.

@sirpy any updates on this issue ?

@johnsmith-gooddollar the issue is not reproduced.
checked on Web and Mobile envs.


Extra fields trigger "missing" validation error

With a simple model:
from pydantic_xml import BaseXmlModel, attr, element

class Customer(BaseXmlModel, tag="Customer"):
    id: str | None = element()
    name: str = element()

this test fails
def test_deserialize_customer():
    customer_xml = (
        "<Customer><active>1</active><id>101</id><name>some_customer</name></Customer>"
    )

    customer = Customer.from_xml(customer_xml)
    assert customer is not None
    assert customer.id is not None

with error
>   ???
E   pydantic.error_wrappers.ValidationError: 1 validation error for Customer
E   name
E     field required (type=value_error.missing)

pydantic/main.py:341: ValidationError

versions:
$ pip list | grep pydantic
pydantic              1.10.9
pydantic-xml          0.6.3

@GuillaumeDesforges Hi.
If your document may contain extra fields you should use ordered search mode:
class Customer(BaseXmlModel, tag="Customer", search_mode='ordered'):
    id: str | None = element()
    name: str = element()

More details here

Thanks for the quick and effective reply, this fixerd the issue!
from pydantic_xml import BaseXmlModel, attr, element
from pydantic_xml.element.element import SearchMode

class Customer(
    BaseXmlModel,
    tag="Customer",
    search_mode=SearchMode.ORDERED,
):
    id: str | None = element()
    name: str = element()

In fact, SearchMode.UNORDERED is even better in my case