fixes #297: fitting in batches without all labels

Summary
Closes #297. Currently, VQC will throw an error if trained on batches of data where not all of the target labels that can be found in the full dataset are present. This is because VQC interprets the number of unique labels in the current batch as the number of classes.
Currently, VQC is hard-coded to expect one-hot encoded labels. Therefore, I suggest a small change to determine the number of classes from the shape of the label array. I have also edited the docstring to add the label encoding requirements of the current VQC implementation.
Details and comments
Related issues that I will raise separately:

I may also add a warning when running with a warm start and fitting to data with a different number of one-hot labels, as I would expect this to invalidate any previous fit.
While multi-label classification is not supported, the code will not raise an error when it is provided.
In future, it might be good for VQC to accept different label encodings, in line with what an sklearn user might expect.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.729%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2820

Relevant Lines:
3368

💛  - Coveralls

Could we get a test case that would fail previously that will now work with this bug fix. Since its an aspect that CI did not catch it would be good to get a unit test in there to cover it.
Also don't forget the reno release note.

Could we get a test case that would fail previously that will now work with this bug fix. Since its an aspect that CI did not catch it would be good to get a unit test in there to cover it.
Also don't forget the reno release note.

I've added a new unit test that would fail without this fix. It may be necessary to revise it if and when we implement a wider range of valid label encodings in the VQC interface. I've also added a reno note for the fix.

@woodsp-ibm Is there anything left on your radar? If not, I'll approve and merge this PR.

@declanmillar could you please post an issue(s) mentioned in this PR?


Creating a load balancer for a storage bucket

I want to spin up a load balancer with an ip for a storage bucket, but I run into this error whenever I run 'terraform apply'

This is my config file
resource "google_compute_backend_bucket" "storage_bucket_backend" {
  name        = "storage-bucket-backend"
  description = "${var.project} storage bucket"
  bucket_name = google_storage_bucket.storage_bucket.name
  enable_cdn  = true
  project       = var.project
}

resource "google_storage_bucket" "storage_bucket" {
  name     = "storage-bucket"
}

resource "google_storage_bucket_access_control" "public_rule" {
  bucket = google_storage_bucket.storage_bucket.name
  role   = "READER"
  entity = "allUsers"
}

module "cdn-lb-http" {
  source            = "GoogleCloudPlatform/lb-http/google"
  version = "~> 4.4"
  project           = var.project
  name              = "storage-bucket-backend-load-balancer"
  backends = {
    default = {

      affinity_cookie_ttl_sec         = null
      connection_draining_timeout_sec = null
      custom_request_headers          = null
      custom_response_headers         = null
      description                     = null
      enable_cdn                      = true

            protocol                        = "HTTP"
      port                            = 80
      port_name                       = "http"
      timeout_sec                     = 10
      connection_draining_timeout_sec = null
      enable_cdn                      = false
      security_policy                 = null
      session_affinity                = null
        health_check = {
        check_interval_sec  = null
        timeout_sec         = null
        healthy_threshold   = null
        unhealthy_threshold = null
        request_path        = "/"
        port                = null
        host                = null
        logging             = null
      }
      log_config = {
        enable = true
        sample_rate = 1.0
      }

      groups = [
        {
          # Each node pool instance group should be added to the backend.
          group = google_compute_backend_bucket.storage_bucket_backend.id
          balancing_mode               = null
          capacity_scaler              = null
          description                  = null
          max_connections              = null
          max_connections_per_instance = null
          max_connections_per_endpoint = null
          max_rate                     = null
          max_rate_per_instance        = null
          max_rate_per_endpoint        = null
          max_utilization              = null
        },
      ]

      iap_config = {
        enable               = false
        oauth2_client_id     = null
        oauth2_client_secret = null
      }
    }
  }

  cdn = true
  create_address = true
  https_redirect = true
  managed_ssl_certificate_domains = tolist(["cdn.${var.domain}"])
  ssl = true
  use_ssl_certificates = false
}

output "ip" {
  value = module.cdn-lb-http.external_ip
}

Little help please.

@chubibest The immediate cause of the error message is that you haven't specified a port for the load balancer health check, so the module can't create a firewall rule to allow the health check. However, once you get past that hurdle, you'll find that it won't accept a google_compute_backend_bucket as a group. I don't think it's possible to use this module to create load balancers with backend buckets. If you look at Google's own module examples, they actually don't use the module to create the load balancer that uses the backend bucket: https://github.com/terraform-google-modules/terraform-google-lb-http/blob/1d3ad9ee0690fbd29ddb853d21b65b9b581ac678/examples/multi-backend-multi-mig-bucket-https-lb/main.tf#L338
I think supporting a static backend bucket would be a great feature to add to this module-perhaps as a submodule.

Thank you, @craigafinch

An example of just a LoadBalancer with a static backend bucket would indeed be greatly appreciated.

@chubibest @tguvdamm I posted an example of using a Cloud Storage bucket as a backend hosting for static files behind an HTTP/S load balancer.

Thanks!

Bookmarking that!

This is kinda weird right? I came here because I found no example on this page: https://registry.terraform.io/modules/GoogleCloudPlatform/lb-http/google/latest
Its like the simplest thing to do. Maybe thats why the module doesn't support it? Like its so simple that using a module would be overkill?
Just curious if this was deliberate because that reasoning kind of makes sense to me.


[WIP] Primer mono repo

Moving Primer into a mono repo
This WIP pr works towards moving the source files for Primer back into the Primer org, to be pulled into GitHub via npm. More context on this decision here, and here's an interesting post on why Babel is a monorepo.

All packages will live in one repo to make it easier to make updates across Primer
Individual packages and meta-packages will still be independently versioned and distributed via npm

To-do:

[x] Remove git logs from packages
[ ] Update & test Travis config
[ ] Add ignore for npm-debug.log (and remove any existing logs)
[x] Remove individual module contributing guidelines and add one to the root directory
[x] Update git and issue urls to point to primer-css
[ ] Setup Lerna for easier multi-package management
[ ] Explore using Semantic Release to help us better manage versions and the changelog
[ ] Setup github releases feature
[ ] Figure out how to manage global and individual package and meta-package changelogs
[ ] Create pre-release for testing with new style guide docs and GitHub
[ ] Switch GitHub over to pulling in primer, remove and re-org stylesheets directory
[ ] Once shipped, deprecate old package repos

Questions:

Should each package and meta-package have it's own .gitignore file or just the root?
Should each package and meta-package have it's own LICENSE or just the root?

@primer/design-systems @muan @josh @mislav What other things do I need to take into account? Any questions, concerns? Let me know if you have any thoughts on using Lerna and Semantic Release—they look like good options and help us with some of our maintenance and publishing workflow issues. I'll need help once this is ready with switching GitHub over to pulling this in a dependency.

So excited for the new setup! :sparkles:

Should each package and meta-package have it's own .gitignore file or just the root?
Should each package and meta-package have it's own LICENSE or just the root?

I think they should have their own ones since each package can be installed separately. User will need both files when they are using just one package.

[ ] Setup Lerna for easier multi-package management

:+1: on this

[ ] Explore using Semantic Release to help us better manage versions and the changelog

IMO this doesn't give us huge wins since lerna already prompts us to enter a version number so this is already a deliberate + essential action.

[ ] Create pre-release for testing with new style guide docs and GitHub

With normal one-to-one repo/npm packages, you would be able to just install from source without a release. Like npm install github:muan/romanize-names#test-branch, this was the way I was suggesting to do testing with. I wasn't able to find an example like this for lerna. Have you come across one? is pre-release the only way?
Also it looks to me that packages aren't versioned individually for React, Babel, and Jest, and I can't find package.json for each package in Angular, Meteor, or Ember. Do you know of an example repo somewhere?

Thanks @muan for the feedback! Replies below but also going to follow up with a comment re breaking this up a bit since not everything is essential for the first ship to make this a mono-repo.

I think they should have their own ones since each package can be installed separately. User will need both files when they are using just one package.

🆒

IMO this doesn't give us huge wins since lerna already prompts us to enter a version number so this is already a deliberate + essential action.

The value of semantic release seems to be removing the human element from making decisions about version changes. Folks incorrectly bumping the version number has been a continuous issue, I think due to a combination of personal opinion, being unfamiliar with Semver, or because mapping CSS changes to Semver isn't always obvious. I'm going to leave this til later though as I agree that it's not essential to shipping this pr, and Lerna will stop us bumping a minor or major number and forgetting to reset the patch to 0. 😬

With normal one-to-one repo/npm packages, you would be able to just install from source without a release. Like npm install github:muan/romanize-names#test-branch, this was the way I was suggesting to do testing with. I wasn't able to find an example like this for lerna. Have you come across one? is pre-release the only way?

I'd like to chat with you about this. I suggested this since I thought was a normal/best practice since it keeps the distribution via npm and allows you to share with the open-source community for testing. Maybe this isn't necessary for us, but want to make sure it's easy for all GitHub teams using Primer. This will increase over the next year as more non-dotcom sites move over to Primer so whatever we do we need to make sure it's easy to communicate and test updates.

Also it looks to me that packages aren't versioned individually for React, Babel, and Jest, and I can't find package.json for each package in Angular, Meteor, or Ember. Do you know of an example repo somewhere?

Not without spending some time searching around, no. But it doesn't matter to me that those projects aren't individually versioning their packages, it's a supported feature of Lerna and seems like the right thing to do for us, and it maintains our current versioning system. It makes it easier to push individual updates more safely since folks using it will be able to specify what they're ready to update to. I.e. if we updated our button styles and our box styles, but box styles would cause a lot of work for a team to update to, they'd still be able to pull in the new button styles and only update their box styles when they had the time to. If we weren't using Lerna I'd still want to set the repo up this way, Lerna just makes it easier.
Also re working on this in dev (in case that's what you were curious about), Lerna handles symlinking and when we run the bootstrap script it will look at the changes logged in git and ask us what we want to bump the version number too automatically. So having individually versioned should be fine.

Not without spending some time searching around, no. But it doesn't matter to me that those projects aren't individually versioning their packages, it's a supported feature of Lerna and seems like the right thing to do for us, and it maintains our current versioning system.

Sorry, I'm not doubting that we should do this, but asking what does this set up looks like in real life.

Updates and notes from conversations with @muan and @jonrohan:

We don't think we'll be able to point to a branch in github/github when testing changes to Primer because of there is not git url mapped to the packages on npm, but we can publish a tagged pre-release. This will be fine once we have more components updated and in Primer but it might feel a little painful at first, and I think there's other things we can do to improve this new workflow (such as automating component testing or being able to spit out a list of all component variations).
We're unsure why Greenkeeper stopped working, may be to do with the authentication changes a while back, will ask @jonrohan for help with setting that up again.
Did we use ava for testing previously? If so, do we need to do anything re setup with the new monorepo? cc @jonrohan
I've updated the pr to reflect pre-ship and post-ship tasks so it's clear what we need to do for shipping this.

Notes from meeting with @muan and @jonrohan

We're unsure why Greenkeeper stopped working, may be to do with the authentication changes a while back, will ask @jonrohan for help with setting that up again.

Probably stopped working after updating permissions. Don't really need it anymore since Lerna handles keeping the packages up to date. Could use it just for keeping Lerna up to date if we want to.

Did we use ava for testing previously? If so, do we need to do anything re setup with the new monorepo? cc @jonrohan

Don't really need ava for CSS, more useful for JS.

@josh @mislav, and @dgraham 👋 I've been synching up with @muan about this (and @jonrohan now that he's back!), but wanted to make sure you had time to review this since we're getting close to shipping.
Some things to note (and shorter summary of initial pr comment):

Primer will be pulled into github/github as a dependency, I'll open a pr for that shortly for testing and will request your review
Primer will now be a monorepo, and Lerna will be a dependency for this repo because we are using it for publishing and versioning multiple packages
We now have just one travis config in the root directory which runs through and tests all the packages. See the travis config here, and here's the output. If there is a better way to approach that let me know.

@primer/design-systems et al, if you're interested in testing the updates in this branch, here's the versions you'll need to install:

<EMAIL_ADDRESS>(all of the packages)
<EMAIL_ADDRESS>(core primer packages only, currently @imported into frameworks.scss and site.scss)
<EMAIL_ADDRESS>(product packages only, currently @imported into github.scss)
<EMAIL_ADDRESS>(marketing packages only, currently @imported site.scss)

This should match everything that's in github/github right now, including module updates that haven't yet been publish to the Primer repo.
Here's is a gist showing the unpublished changes for comparison - @jonrohan it would be rad if you could double check and review those changes. I've bumped to pre-patch/minor/major which should match except for primer-layout where there have been 2 major bumps that haven't been published but both are included in this pr so I've just bumped it once.

Updates:
Discussed with @jonrohan and we've decided to remove core as a peer dependency from marketing and product meta-packages. It's not really a peer dependency, each package works entirely without each other. In some documentation we use components from core in other components, but they are not actually required to use the individual components.  Basically seems like it's not worth it.
I also realized I missed primer-marketing-support from the initial monorepo setup, so have added that now. Here are the new package versions for testing:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>is unchanged from the last release

@sophshep As discussed, would be rad if you can test on some marketing sites.
WIP dotcom pr for switching Primer to a dependency here: https://github.com/github/github/pull/74495

Thanks @mislav! Currently the builds take ~4 minutes. I feel that that's not too long however we can look into caching as you suggested if it ends up becoming a problem.

@sophshep Re testing, I'd like your help checking that you can point your marketing sites to a pre-release version. After thinking this through though, I reckon it would be good to jump on a call and see what your workflow is with Jekyll/non dotcom sites and then I can help explain what, if any, changes to that workflow would be with this new setup. If you can make time to do this tomorrow that would be rad - feel free to ping me in slack re times to sync.

Update: I published a new pre-release to include dotcom updates to grid gutters, and fade variables. I've asked for a freeze on publishing updates until this is shipped, unless there's a serious bug that needs fixing. Hoping to get this shipped Wednesday if everyone has enough time to test.
Here are the new package versions for testing:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@shawnbot Here's the error I'm getting:

This was after I updated the marketing package to include the import for primer-marketing-utilities and also added that as a dependency. After updating packages, I ran lerna bootstrap to symlink the new dependency. Then ran lerna publish and got the above errors.
I thought maybe it was just having an issue with previous versions of how the module were setup, so I ran lerna clean to clean out the node modules, and then re-ran lerna bootstrap to symlink all the packages again. This time lockfiles were added to each package which I removed as previously this seemed to cause an issue with Lerna, but I kept everything else the same. After running lerna publish again now I get the same error above on other packages:

I manually removed the node modules and tried this all over again, to no avail. I've tried manually installing packages and I tried this with and without lockfiles. I started to look through issues in the Lerna repo, and found that lerna isn't compatible with npm @5, which I am on. So that may be why I'm getting a bunch of issues 😑 .
cc @jonrohan

I guess this is rather late but I can answer questions y'all might have about Lerna (I maintain Babel and Lerna somewhat). Not sure how well it works with npm 5 and hoisting since never looked into it, but does seem like everyone did their research pretty well 😄 (lerna slack: https://slack.lernajs.io/, babel: slack.babeljs.io)

Thanks @hzoo! I had joined the lerna slack but @shawnbot ended up helping me solve the issues we were having. There's some follow up work to do on our side and there's some feedback we'll pass on to the you and the Lerna maintainers if issues haven't been opened already.
I don't think the problems we hit were really npm@5 issues, however it didn't seem to like the lockfile. Either way, since there are so many bug reports for npm@5 at the moment, it seems sensible to stick with 4 for now.
Also, you're more than welcome to randomly comment on our Primer pr's 😃


Aseprite (and others) in CICD

If I want to export the Godot game using GitHub/GitLab CICD how does this work with this tool? It seems like I can develop locally just fine but when trying to use this tool in the CICD it can't work due to missing aseprite.exe when it tries to generate the imported files.  This applies to any other format which requires something to perform the conversion.
Maybe I am missing something here or there are alternatives like including my .godot/imported folder to git (from my understanding this isn't recommended but I don't know why). I could also build and install Aseprite in the CICD perhaps.

There is really no need to include the .godot/imported folder in Git. It contains files that will be regenerated from sources that are located in the main project file system. This is why the .godot folder is hidden: it contains your local settings, imported resources and the like so that you can develop locally and run the game in debug mode.
If you want all resources to be imported anew on the server each time, I think it’s worth adding some scripts (Python, Powershell or others) that modify certain sections of the project.godot file. For example, save the project file template to Git, not the project itself. Let your script insert the desired paths into it and save it with the name project.godot. After this, you can run Godot, and it will make all the necessary imports. To do this, the server must have installed applications with which integration is configured: Aseprite, Krita or others.

Thanks for quick response. Looks like I will need to make the applications available and modify the .godot file as suggested to point to the paths on the runner where the temp/aseprite/etc are located.

There are several other plugins that work in a similar way, integrating Godot's resource system with external applications. Perhaps the developers who use them already have ready-made recipes?
You might also be interested in setting up incremental processing of source files. Godot saves the result of each import with a hash of the source file. Therefore, when the file changes, Godot detects this and performs the import again. Therefore, saving the .godot.import folder on the server can speed up the build. However, sometimes it needs to be cleaned so that orphaned resources do not accumulate in it.
By the way, when exporting a project to artifacts for each platform, you can specify which files from the project need to be exported and which do not. This plugin serves only for import resources. You can completely exclude its files from export to artifacts.

You can try using LibreSprite if you do not have a licensed version of Aseprite to install on your server. It supports some of the required functions, but not all. You can read the details on the Importality's Wiki page about Aseprite and LibreSprite.

Thanks for details. I tried a handful of things but didn't end up liking any of them as it just complicated things to much.
I am rethinking how I will approach this and might just export via the Aseprite command line instead and use the actual files in Godot.

@Alenael, perhaps I can help you!
In the 'issue #19' I was told to try to transfer the plugin settings from ProjectSettings to EditorSettings.
Please test the latest version of the use_editor_settings_instead_of_project_settings branch on your project. Perhaps it will make your CI/CD easier.

You should seriously consider making this the master branch....It's more future proof and widely compatible with existing projects in Godot 4 that are well established. Otherwise you have to stumble into this thread and install this version to get it to work and the way I see it...there is no reason for that.

ALSO, Genius plugin and I love you :)

Had this exact issue - I included the .godot/imported folder into git and set up the export template to exclude the actual plugin but included all the .aseprite files.
Although I did all the importing on my linux machine the windows build on github actions works without issues and it does not need the aseprite executable.

Hello, you can try to use LibreSprite executable to import Aseprite files. It has smaller functionality, but give it a chance.
Also, if you have one Aseprite executable (for Windows, for example), then you can take another one (for Linux or Mac). This case is available on Steam, HumbleBundle etc. Also you can try to build it from sources manually.


vue serve invalid arg type error

Version
3.9.1
Environment info
Environment Info:

  System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  Binaries:
    Node: 10.16.0 - ~/.nvm/versions/node/v10.16.0/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.0/bin/npm
  Browsers:
    Chrome: 75.0.3770.100
    Firefox: 63.0.3
    Safari: 12.1.1
  npmGlobalPackages:
    @vue/cli: 3.9.1

After some attempts, and re-installing.. this i my new env info. Issue still exists.
Environment Info:

  System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  Binaries:
    Node: 12.5.0 - /usr/local/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 75.0.3770.100
    Firefox: 63.0.3
    Safari: 12.1.1
  npmPackages:
    @vue/component-compiler:  4.0.0
    @vue/component-compiler-utils:  3.0.0
    rollup-plugin-vue: ^5.0.0 => 5.0.1
    vue: ^2.6.10 => 2.6.10
    vue-runtime-helpers:  1.0.1
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 3.9.1

Steps to reproduce
With vue-cli globally installed, and @vue/cli-service-global installed.

On any vue component vue serve myComponent.vue

This will result in an error.
What is expected?
Expected is that the server starts with the defaults.
What is actually happening?
 INFO  Starting development server...
(node:46916) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.dirname (path.js:1260:5)
    at api.chainWebpack.webpackConfig (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-plugin-eslint/index.js:58:32)
    at webpackChainFns.forEach.fn (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/Service.js:227:40)
    at Array.forEach (<anonymous>)
    at Service.resolveChainableWebpackConfig (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/Service.js:227:26)
    at Service.resolveWebpackConfig (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/Service.js:231:48)
    at PluginAPI.resolveWebpackConfig (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/PluginAPI.js:138:25)
    at serve (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/commands/serve.js:48:31)
    at Service.run (/Users/username/.nvm/versions/node/v10.16.0/lib/node_modules/@vue/cli-service-global/node_modules/@vue/cli-service/lib/Service.js:221:12)
(node:46916) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:46916) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I have tried the following:

Node version 8.16
Removing all of Node and npm, and reinstalling
using older versions of vue-cli (3.8) and the alpha version.

I also met, looking forward to solving.

Same here, tried moments ago to use this and no success

Binaries:
Node: 11.1.0 - /usr/local/bin/node
Yarn: Not Found
npm: 6.9.0 - /usr/local/bin/npm
Browsers:
Chrome: 75.0.3770.100
Firefox: 67.0.4
Safari: 12.1.1
npmGlobalPackages:
@vue/cli: 3.9.1

Fixed in 3.9.2 and 4.0.0-alpha.4

After upgrading the package, it works! Thanks


HAWKULAR-1006 : Update to Patternfly 3.3.1

Includes update to patternfly 3.3.1 angular-patternfly 3.3.1 with some
needed fixes

Merged #878


dcos-commons 0.2.3 integration

Retest this please

retest please

@mesosphere-ci: Retest please

Retest please


Update animal [Fox API]

The current API of foxes is down. Upgrade to a functional one

Thanks for your contribution!


Getting the tests to pass

Currently doing make test fails. I don't know if this is normal? I'm thinking it may be a good idea to make the tests pass for now (maybe just doing the broken tests in a different branch or so), so that we don't have to be embarrassed when showing the tool to people at ICDT. ;)

OK this was easy: on my system py.test uses python2. :) Fixing


Where should I place the .gitlab.nvim file?

"I attempted to place the .gitlab.nvim file under ~/.gitlab.nvim, and even after running the require("gitlab").summary() command, I still receive the error message 'The gitlab.nvim state was not set. Do you have a .gitlab.nvim file configured?'"

That file should be in the root of your project folder alongside your .git folder, not at ~/.gitlab.nvim

That file should be in the root of your project folder alongside your .git folder, not at ~/.gitlab.nvim

Thanks


Activating extension failed

Describe what happened:
After an update to Live Share version 1.0.3784 the button on the status bar doesn't show and every attempt of issueing a Live Share command results in an error.
This might be a duplicate of #4118 or at least related?
What was your system configuration?
Product and Version [VS/VSCode]: 1.53.2
OS Version[macOS/Windows]: Ubuntu 18.04
Live Share Extension Version: 1.0.3784
Please attach logs to this issue:
[2021-02-22 14:31:19.490] [exthost] [error] Activating extension ms-vsliveshare.vsliveshare failed due to an error:
[2021-02-22 14:31:19.490] [exthost] [error] Error: Request failed with status code 403
	at createError (/home/imartini/.vscode/extensions/ms-vsliveshare.vsliveshare-1.0.3784/out/prod/extension-prod.js:77470:15)
	at settle (/home/imartini/.vscode/extensions/ms-vsliveshare.vsliveshare-1.0.3784/out/prod/extension-prod.js:77731:12)
	at IncomingMessage.handleStreamEnd (/home/imartini/.vscode/extensions/ms-vsliveshare.vsliveshare-1.0.3784/out/prod/extension-prod.js:76823:11)
	at IncomingMessage.emit (events.js:327:22)
	at endReadableNT (_stream_readable.js:1220:12)
	at processTicksAndRejections (internal/process/task_queues.js:84:21)

I have this issue when using VSCode on my corporate desktop with VSCode 1.51.1
The Live Share button does not appear in the blue status bar. Any command sent via Command Palette returns a command not found error, for examples:
Command 'Live Share: Launcher Setup' resulted in an error
(command 'liveshare.launcherSetup' not found
Command 'Live Share: Start Collaboration Session (Share)'
resulted in an error (command 'liveshare.start' not found)
Command 'Live Share: Export Logs' resulted in an error
(command 'liveshare.exportLogs' not found)
I am able to activate Live Share and start collaboration with VSCode 1.53.
I suspect if it's due to the corporate firewall. But how do I confirm?

Also seeing this, Windows 10 and Mac Catalina, VSCode 1.50.1, live-share 3784. This was working at first, and then suddenly the live-share extension icon didn't load on startup of VSCode and the logs had a 403 error (but no associated Network request in the dev tools).

We’ve made improvements in this area since this issue was filed. We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please reopen the issue and let us know. Thank you.


MQ Source and Sink is not print the logs in the log file

Able to connect using Source and Sink connector code to IBM MQ and Kafka but logs are not printed in the log file.
Is there any configuration explicitly done to print the logs on log file. Please advise on it.

Which log file? The logs are generated to stdout and you can redirect those to wherever you want.

Closing dormant issue.


[dtlaunch, b2] Change swipe direction to UpDown

@jeffmer
On bangle 2 change swipe directions to move between pages from LeftRight to UpDown, as to match the page indicators. Implemented like 'natural scrolling'.
Also added function showClock() which is called on 'left-to-right' swipe.  Here I imagine the clock to be to the left of the launcher, if you do that then this also follows the natural scrolling principle.

Looks good to me - originally up down was not available so this change is a definite usability improvement.

Thanks!


Virtual IP on WAN with 1:1 NAT breaks WAN gateway

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
On a very basic OPNsense instance (details below under environment), the creation of a virtual IP on the working WAN interface, followed by activation of a one to one NAT rule for that Virtual IP (source) to an internal IP on the LAN (dest) with default values otherwise makes the WAN gateway immediately unreachable. That means, log is flooded with
dpinger[67580] | WAN_GW XX.XX.XX.XX: sendto error: 64
and the gateway is soon considered down. The logs are true, OPNsense is then indeed completely locked out from the outside (i.e. access is only possible from LAN).
Interestingly, at that point, disabling the NAT rule doesn't recover this failure state. The virtual IP has to be removed, too. However, creating a virtual IP alone without the corresponding NAT rule doesn't trigger the failure.
To Reproduce

Set up OPNsense with settings/environment as specified below.
Define virtual IP
Create and activate NAT rule
Cry

Expected behavior
Well, defining vIPs on the WAN interface and using them in NAT rules shouldn't break the WAN gateway connection.
Screenshots

Relevant log files
The logs mentioned above doesn't contain anything more interisting than that, but I'm happy to provide other logs if needed/helpful.
Additional context
I found a few internet discussions where exactly this issue appeared (this one seems to be a perfect fit [german]: forum.opnsense.org/index.php?topic=13786.0) but none of them had a solution. Interest there seemed quite low, so I'm guessing this has to appear only in very specific circumstances or is just a really dumb configuration mistake so that the problem magically solves itself and no one thinks about sharing it. However, postings from above show this also happened like at least two years ago.
Environment
Network:

Proxmox host with one physical NIC.
Bridge vmbr0 mapped to that physical interface, added to OPNsense VM.
vmbr0 (i.e. the physical host interface) has a public IP, let's assume <IP_ADDRESS> here.
Bridge vmbr1 for internal LAN, also added to OPNsense VM (<IP_ADDRESS>/24).
OPNsense VM has a dedicated public IP (from VPS with it's own MAC address) that is configured on vmbr0 within OPNsense, let's call it <IP_ADDRESS>
vmbr0 is OPNsense's WAN.
vmbr1 is OPNsense's LAN.
Everything 'works' and is reachable (PM Host, OPNS, also other VMs if present when connected to vmbr1 with <IP_ADDRESS>/24 access).
An extra subnet from VPS shall be used to make some VMs publicly reachable through OPNsense's NAT. This subnet is routed through the main IP, <IP_ADDRESS>
Thus, the IPs from that subnet shall be made known to OPNsense (as virtual IPs)
vmbr0 is configured to forward (aka up sysctl -w net.ipv4.ip_forward=1 within the interface config)

OPNsense:

v21.1.6
FreeBSD 12.1-RELEASE-p16-HBSD
OpenSSL 1.1.1k
2 cores @ 2.8 GHz, 4 GB RAM
Plugins:

os-qemu-guest-agent
os-acme-client
os-dyndns

OpenVPN server configured,
No other extra-configurations except basic WAN & LAN on first login

Today I decided to set up OPNS from scratch. This time I even left out OpenVPN and DNS configuration and did only the bare minimum.
Turns out: It works and seemed to be a configuration mistake on the proxmox side. While reconfiguring the VM, I noticed that the pointopoint and gateway entry on vmbr0 (proxmox host side) where wrong, they didn't specify the correct IP. Apart from OPNS, this didn't result in an obvious failure so I didn't notice this mistake earlier.
Hope this may at least motivate someone else stumpling across this to double check the host side even though it may seem to be correct at first glance.


Allowing outside parameters for Qdrant.

@baskaryan @rlancemartin, @eyurtsev

cc @kacperlukawski

@baskaryan LGTM

@hanit-com Thanks for noticing that :+1:


Property X dows not exist on window for usage in other scripts

TypeScript Version:  3.8.3
The relevant parts of my Code
preload.ts
declare global {
    interface Window {
        myFunc(param: string): void;
    }
}

const myFunc = (param: string): void => { ... };

window.myFunc = myFunc;

script.ts
window.myFunc('parameter');

Expected behavior:
Compile without errors and execute the function at runtime.
Actual behavior:
The compiler throws the following error:
script.ts error TS2339: Property 'myFunc' does not exist on type 'Window & typeof globalThis'.
preload.ts compiles without any problems. This error only appears at using custom properties of window.

How are you running tsc ?

I have a yarn build script:
"build": "tsc -p ./tsconfig.main.json && tsc -p ./tsconfig.renderer.json"
Maybe this error happens because preload.ts is compiled by the first part and script.ts by the second.

@RyanCavanaugh I found a bad workaround.
First I compile all my files with "module": "es2015" and in a second step recompile these files that need to be commonjs modules.

We fixed multiple bugs around this since the last time I looked at it; I expect it's fixed now. Please open a new issue with a consolidated repro if that's not the case. Thanks!


Why are the dns provider annotations deprecated?

In the docs, these are listed as being deprecated however it looks like they are required:
certmanager.k8s.io/acme-dns01-provider
certmanager.k8s.io/acme-challenge-type
Without these annotations set on ingresses, DNS verification does not work.
v0.8.1
https://docs.cert-manager.io/en/latest/tasks/issuing-certificates/ingress-shim.html

The config moves to the (Cluster)Issuer, so you do not need to specify it on the cert/ingress anymore. See the upgrading docs for more info:
https://docs.cert-manager.io/en/latest/tasks/upgrading/upgrading-0.7-0.8.html

Thanks, so the key is to remove the annotations from the ingress and to set a - selector: section on the Issuer?
I wish it had said that earlier in the docs..

You have to add a
solvers:
  - selector: ...

key to your (cluster-)issuer.
The only annotation left on the ingress is the certmanager.k8s.io/(cluster-)issuer annotation.
For me, this makes it much easier to use, since you have to configure the challenge provider only once.
This is described in the issuer acme doc's too (https://docs.cert-manager.io/en/latest/tasks/issuers/setup-acme/index.html), but I'm not sure when they updated it.


Embeddings 模型加载成功，添加dify时报错

问题一：Embeddings 模型为 bge-large-zh 采用离线方式加载

配置信息如下

{     "model_name": "custom-bge-large-zh",     "dimensions": 1024,     "max_tokens": 512,     "language": ["zh"],     "ability": [ 	    "embed" 	],     "model_id": "BAAI/bge-large-zh",     "model_uri": "file:///home/models/bge-large-zh" }

问题2：LLM 模型也会报这个错误，GPU 必须选 2 启动可以正常。

错误日志如下：

Failed to create the embeddings, detail: [address=<IP_ADDRESS>:40573, pid=37311] CUDA call failed lazily at initialization with error: device >= 0 && device < num_gpus INTERNAL ASSERT FAILED at "../aten/src/ATen/cuda/CUDAContext.cpp":50, please report a bug to PyTorch. device=1, num_gpus= CUDA call was originally invoked at: File "<string>", line 1, in <module> File "/home/miniconda3/envs/xinference/lib/python3.10/multiprocessing/forkserver.py", line 274, in main code = _serve_one(child_r, fds, File "/home/miniconda3/envs/xinference/lib/python3.10/multiprocessing/forkserver.py", line 313, in _serve_one code = spawn._main(child_r, parent_sentinel) File "/home/miniconda3/envs/xinference/lib/python3.10/multiprocessing/spawn.py", line 125, in _main prepare(preparation_data) File "/home/miniconda3/envs/xinference/lib/python3.10/multiprocessing/spawn.py", line 236, in prepare _fixup_main_from_path(data['init_main_from_path']) File "/home/miniconda3/envs/xinference/lib/python3.10/multiprocessing/spawn.py", line 287, in _fixup_main_from_path main_content = runpy.run_path(main_path, File "/home/miniconda3/envs/xinference/lib/python3.10/runpy.py", line 289, in run_path return _run_module_code(code, init_globals, run_name, File "/home/miniconda3/envs/xinference/lib/python3.10/runpy.py", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File "/home/miniconda3/envs/xinference/lib/python3.10/runpy.py", line 86, in _run_code exec(code, run_globals) File "/home/miniconda3/envs/xinference/bin/xinference", line 5, in <module> from xinference.deploy.cmdline import cli File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/__init__.py", line 32, in <module> _install() File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/__init__.py", line 29, in _install install_model() File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/model/__init__.py", line 17, in _install from .llm import _install as llm_install File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/model/llm/__init__.py", line 19, in <module> from .core import LLM File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/model/llm/core.py", line 22, in <module> from ...core.utils import parse_replica_model_uid File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/core/__init__.py", line 15, in <module> from .model import ModelActor File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/xinference/core/model.py", line 49, in <module> from torch.cuda import OutOfMemoryError File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/torch/__init__.py", line 1332, in <module> _C._initExtension(manager_path()) File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/torch/cuda/__init__.py", line 244, in <module> _lazy_call(_check_capability) File "/home/miniconda3/envs/xinference/lib/python3.10/site-packages/torch/cuda/__init__.py", line 241, in _lazy_call _queued_calls.append((callable, traceback.format_stack()))

已解决，版本更新到 <IP_ADDRESS> 正常。

已解决，版本更新到 <IP_ADDRESS> 正常。


DEV and Prod Build

First of all thanks for this starter, i need to create a Prod build, could you please provide the steps.

Hello, did you solve this problem? I am also not able to generate the prod build. Can you help me?


DAPI: Remove additional indexes, the default masternode indexes are sufficient

https://github.com/dashpay/platform/blob/ed354ca52969676f8231765fc04bbe02b1d9ba25/packages/dapi/doc/dependencies_configs/dash.conf#L8-L12
and
https://github.com/dashpay/platform/blob/ed354ca52969676f8231765fc04bbe02b1d9ba25/packages/dashmate/templates/core/dash.conf.dot#L39-L44
These indexes are NOT required for Masternodes aka EvoNodes running platform, two observations.

A Masternode does not run a wallet at the same time, this is intentionally not a possible configuration.
None of the RPCs (and I checked them all) require any special indices and the one that does getaddressutxos is for nodes running wallets, refer to 1.

It's done


Wrapping at 81 characters rather than at 80 characters

I may be misunderstanding something, but upon trying whiteroom-mode out, I noticed that lines were not wrapped at 80 characters; rather, writeroom-mode allowed for 81 characters before wrapping the line:

I would have expected the "x" characters at the end of the two longest lines to be on the next line.
This behaviour can be reproduced by starting from an Emacs configuration consisting of only...
(package-initialize)
(add-to-list 'package-archives '("gnu" . "https://elpa.gnu.org/packages/") t)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)

... and executing package-refresh-contents, package-install writeroom-mode and writeroom-mode in the *scratch* buffer.
I'm using Emacs 26.1 on Arch Linux.

Hmmm... The actual problem is with visual-fill-column, which handles setting the margins. The bug is triggered when the window width minus desired width is an odd number: the left and right margins are calculated by dividing this number by 2, but because the results are rounded toward zero, 2 x 0.5 are missing, so that the text area is one wider than requested.
The fix is easy: instead of setting the right margin to (window-width - desired-text-width) / 2, set it to window-width - desired-text-width - left-margin. I'll push that fix to visual-fill-column-mode in a minute.


Add support to customize HPA name

Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Changelog has been updated and is aligned with our changelog requirements

Fixes #3057
Docs PR https://github.com/kedacore/keda-docs/pull/768

@aviadlevy you should also run make build to regenerate ScaledObject resources, as this PR adds a new field.

No git changes after make build
keda on  main [⇡] via 🐹 v1.17.10 ➜  make build
/Users/aviadl/Code/keda/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X=github.com/kedacore/keda/v2/version.GitCommit=64647753313420a59b0c0c2f764e8347c9770dce -X=github.com/kedacore/keda/v2/version.Version=main" -o bin/keda main.go
GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X=github.com/kedacore/keda/v2/version.GitCommit=64647753313420a59b0c0c2f764e8347c9770dce -X=github.com/kedacore/keda/v2/version.Version=main" -o bin/keda-adapter adapter/main.go

What am I missing? What did you expected to see?

@aviadlevy you should also run make build to regenerate ScaledObject resources, as this PR adds a new field.

No git changes after make build
keda on  main [⇡] via 🐹 v1.17.10 ➜  make build
/Users/aviadl/Code/keda/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X=github.com/kedacore/keda/v2/version.GitCommit=64647753313420a59b0c0c2f764e8347c9770dce -X=github.com/kedacore/keda/v2/version.Version=main" -o bin/keda main.go
GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X=github.com/kedacore/keda/v2/version.GitCommit=64647753313420a59b0c0c2f764e8347c9770dce -X=github.com/kedacore/keda/v2/version.Version=main" -o bin/keda-adapter adapter/main.go

What am I missing? What did you expected to see?

What about make generate and make manifests?
The new field should be present in the CRD yaml file.

make generate did the trick, though it seems like too many changes: https://github.com/kedacore/keda/pull/3068/commits/b48e8758f1253854aebdab4d6e1093628d4794d2
@zroubalik Do you want me to revert it and leave only the new fields that added?

make generate did the trick, though it seems like too many changes: 16b2a01 @zroubalik Do you want me to revert it and leave only the new fields that added?

Would be nice if you could keep here in the PR only relevant changes. Would you mind opening a new PR with the extra files? We need to update them anyway. Thanks!

make generate did the trick, though it seems like too many changes: 16b2a01 @zroubalik Do you want me to revert it and leave only the new fields that added?

Would be nice if you could keep here in the PR only relevant changes. Would you mind opening a new PR with the extra files? We need to update them anyway. Thanks!

Kept only relevant changes.
Once this MR will be merged I'll open MR for general CRD changes

/run-e2e

We should have e2e test for this, covering multiple scenarios. It could be a ScaledObject with some simple scaler.
Atm the e2e tests are implemented in TS, we are doing a migration to Go. So would be nice to base that on the new implementation once the PR is merged: https://github.com/kedacore/keda/pull/3079

/run-e2e

FYI my last push happened during the github action issues  and therefore the checks didn't run on my last push. How can I re-trigger them?

@JorTurFer any idea why don't we see the rest of the checks in this PR?

I'll close and open it again, IDK where they are... I can see it directly in actions view

@zroubalik , so I presume we'll wait first for the implementation of the "HPA Ownership" (discussed here)
Do we have issue opened (not sure yet if I'll have the time to do it myself, but maybe someone else from the community will step up)

@zroubalik , so I presume we'll wait first for the implementation of the "HPA Ownership" (discussed here) before merging Do we have issue opened (not sure yet if I'll have the time to do it myself, but maybe someone else from the community will step up)

Yeah agree, thanks, sorry for the slow response, super busy recently ;)

I think https://github.com/kedacore/keda/issues/3154 will cover what's needed

#3079

We should have e2e test for this, covering multiple scenarios. It could be a ScaledObject with some simple scaler.
Atm the e2e tests are implemented in TS, we are doing a migration to Go. So would be nice to base that on the new implementation once the PR is merged: #3079

#3079 has been merged. You can rebase onto main, and add e2e tests in go using the base implementation.

We should have e2e test for this, covering multiple scenarios. It could be a ScaledObject with some simple scaler.
Atm the e2e tests are implemented in TS, we are doing a migration to Go. So would be nice to base that on the new implementation once the PR is merged: #3079

#3079 has been merged. You can rebase onto main and add e2e tests in go using the base implementation.

Thanks! will do!

We should have e2e test for this, covering multiple scenarios. It could be a ScaledObject with some simple scaler.
Atm the e2e tests are implemented in TS, we are doing a migration to Go. So would be nice to base that on the new implementation once the PR is merged: #3079

#3079 has been merged. You can rebase onto main and add e2e tests in go using the base implementation.

Hi @v-shenoy , my e2e test does not involve any scaler in particular, only general behavior.
Where should I locate it?

Just make a new package inside tests/scalers_go
Example - tests/scalers_go/custom_hpa_name/custom_hpa_name_test.go
Replace custom_hpa_name with something else if you prefer.

Let's use some simple scaler for this,that doesn't require big setup. @JorTurFer might suggest some

Added e2e tests 😎
Who can review them? @zroubalik @v-shenoy

/run-e2e custom_hpa*

/run-e2e custom_hpa* Update: You can check the progress here

I increased the time waiting for hpa in e2e.
locally the e2e is working (see below), but probably on the github runner it takes more time for things to work?
➜  go test -v ./scalers_go/custom_hpa_name/custom_hpa_name_test.go
=== RUN   TestCustomToDefault
    custom_hpa_name_test.go:136: --- validate hpa is with custom name ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:140: --- change hpa name ---
    custom_hpa_name_test.go:144: --- validate new hpa is with default name ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:148: --- validate hpa with custom name does not exists ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
--- PASS: TestCustomToDefault (14.00s)
=== RUN   TestDefaultToCustom
    custom_hpa_name_test.go:136: --- validate hpa is with default name ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:140: --- change hpa name ---
    custom_hpa_name_test.go:144: --- validate new hpa is with custom name ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:148: --- validate hpa with default name does not exists ---
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
    custom_hpa_name_test.go:171: Waiting for hpa creation
--- PASS: TestDefaultToCustom (12.36s)
PASS
ok      command-line-arguments  26.894s

/run-e2e custom_hpa*

@zroubalik @JorTurFer
Can you please define what's missing for this MR to get merged?

Can you please define what's missing for this MR to get merged?

I think is ready, at least from my side I don't see any other thing to be done, let's wait till @zroubalik too

There's a conflict brought by another PR :( could you please fix that? Then we can merge this PR. Thanks for the contribution!

/run-e2e custom_hpa*

thanks for this contribution! ❤

thanks for this contribution! ❤

Thanks. it was fun and very enriching.
Looking forward to contribute more in the future  😎


Create a  block of contact information

Write an intro (introduction), describe in 2-4 sentences what you do, what you should do, what you want to do better, what it is important to do, why you are here.


Windows 7+ - Try fetch a more accurate monitor name if possible

Hello,
Me again with a correct code this time.
My previous PR was done with the latest released 3.3.8 GLFW so I had to do it again with latest main branch. Also I found some bug in it that I fixed.
(My previous PR: https://github.com/glfw/glfw/pull/2307)
As a reminder this is my first PR for GLFW so I'm pretty sure I did a lot of awful things.
For now take it just as a draft.
Purpose of this PR: Find if possible the actual name of the monitor instead of Generic PnP that we often have.
I got the code by shamelessly copying and modifying the one from SDL2. (Thank you SDL guys)
It is a runtime check meaning that if we execute the code on Win7+, it will use my new function otherwise it will just skip it.
First lets get some feedback on that:
Coding convention
Naming of the function
Better way to do it ?
Obvious bug I may have missed ?

Up ! Any remarks ?

Apparently people are not in a rush for this feature so I will probably come up in the upcoming weeks / months with a V3.
I noticed GLFW already has a _glfw.win32.user32.instance so I will use that instead and integrate the name fetching in a better way.
Stay tuned.
If for some reason, this PR gets a higher prio for the next GLFW release (3.4 ?) ping me and I will do it ASAP. Not a lot of work but I have plenty of other things I need to take care of besides that.

Hold on this PR. I think I found a bug with my CL. I don't understand how it is connected but clearly something is wrong with fullscreen since my refactor.
I'll keep you posted.

I fixed the issue here with a temporary fix (used the old goto function). I will redo the proper refactor once I understood what was the issue but you can still merge this one if you like the code : https://github.com/Scr3amer/glfw/tree/fix_fullscreen_accurate_monitor_name


this is outrageous!

This is a giant issue that's really been bugging me while i've been playing with this...
How hasn't Mojang hired you yet?

Thanks, but a) I don't think they'd hire me, b) I would not want to move to Sweden and c) even without the first two, I don't think I'd want to work there. Not because of bad working conditions (they're actually quite good from what I've heard) or anything similar, I just would not want to turn my hobby into my job.
Also, FC is not actually that impressive code-wise. A lot of it is pretty simple, it just takes time looking at heapdumps, sifting through things that can't be improved and then improving the things that can be improved.


No Control

When playing on a save in PVP mode (instead of freeplay), none of the buttons on the mod GUI do anything. I don't know if this is intended or not, but either way let me know.

Could you please provide a step-by-step on how to reproduce this?

@Argetlam-Elda this is hopefully fixed in 1.0.8. Try it out and report back if you can?

Closing. Do reply back in this thread so we can open it again.


Add docs switch menu

Fixes https://github.com/minio/docs/issues/842
Preview:

Updating the list:
Edit the docs array in default.conf.py@268.

@djwfyi Is there a link available for the DirectPV documentation site, let me know what to do with DirectPV entry.

It will be min.io/docs/directpv, but they are not ready yet. I'd suggest commenting it out for now.

@djwfyi Commented the DirectPV entry for now, PTAL.

I think the top nav needs to stay consistent across the MinIO website, blog, and all docs sites.

@djwfyi Sure, I can move the menu to the platform bar like in the mockup given by Oscar.

Just for convenience, the link to Oscar's design is https://xd.adobe.com/view/ef6838e9-6f88-4827-8804-b10f40b17d88-ba3b/screen/01304849-dae7-46f1-bdab-324c7d7b8bc2.

Just for convenience, the link to Oscar's design is https://xd.adobe.com/view/ef6838e9-6f88-4827-8804-b10f40b17d88-ba3b/screen/01304849-dae7-46f1-bdab-324c7d7b8bc2.

Great, I will work on it @djwfyi

Yes I think we have to conform to Oscar's design. That also had internal approval, so lets focus that and then move from there

@djwfyi @ravindk89 Update menu placement, PTAL.


API - determine strategy for exposing internal routes

Many of the internal routes need to only be aliased to the api.
Possible solutions:

Include a controller concern that let's you do something like expose_to_api :method1, :method2.  This would give us a hook to incerpt and authenticate those requests.
... others?

Arguments for unified controllers

Seperating internal controllers from controllers will discourage us from unifying and dogfooding in the long run, i.e. decoupling gives us more freedom, but lets us be sloppier
Seperating internal/api controllers is not very DRY
Unified internal/api controllers pre-adapts ourself to fully decoupling app from API

Arguments for separate controllers:

Separate internal/api controllers lets us move more quickly to json-api format external responses, if we want to go that route (but adds length to dogfooding those)

Decision

API v1 will use unified controllers
We will revisit the issue in V2, which may move to json-api

With routes now decoupled into individual files accounting of exposed routes becomes cleaner.  I.e. the expose_to_api macro approach is likely overkill.

@LocoDelAssembly how do you feel with where we are at?  Should we close this for specifics?  I'm not super happy about duplicating actions as we are doing now, but it's also still somewhat manageable.

Closing now for specific updates.


fix: disable account selection on no cross-account trade support for multi-hop

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4929   👈

This comment was auto-generated by Graphite.


TimeoutAck error when using library with rppal

Hi there. I'm interested in using this library to replace an existing application I've written using https://github.com/adafruit/Adafruit_CircuitPython_PN532 python library. I am new to embedded rust so it's very likely I'm doing something wrong.
Running the example below I always get TimeoutAck errors, but I'm not sure why. Looking at the Adafruit library I've understood that I need to enable the msb-spi flag in addition to matching the clock frequency (source)
However, I don't seem to have had much luck with this. Any guidance would be greatly appreciated.
Hardware:

Raspberry Pi 3 B
NFC Module v3 (can be found on amazon if you search pn532, red rectangular PCB)
NFC tag: NTAG216 with a https record written to it

Software
Cargo.toml
...
[dependencies]
pn532 = { version = "0.2.2", features = ["msb-spi"] }
rppal = { version = "0.14.1", features = ["hal"] }

main.rs
use pn532::{spi::SPIInterface, IntoDuration, Pn532, Request};
use rppal::gpio::Gpio;
use rppal::hal::Timer;
use rppal::spi::{Bus, Mode, SlaveSelect, Spi};
use std::error::Error;

/// RPi 3B
// SPI: SPI0 (GPIO 10, 9, 11)
// CS:  GPIO 8
fn main() -> Result<(), Box<dyn Error>> {
    let timer = Timer::new();

    let spi = Spi::new(Bus::Spi0, SlaveSelect::Ss0, 1_000_000, Mode::Mode0)?;
    let cs = Gpio::new()?.get(8)?.into_output();
    let interface = SPIInterface { spi, cs };

    let mut pn532: Pn532<_, _, 32> = Pn532::new(interface, timer);
    if let Ok(uid) = pn532.process(&Request::INLIST_ONE_ISO_A_TARGET, 7, 1000.ms()) {
        let result = pn532.process(&Request::ntag_read(10), 17, 50.ms()).unwrap();
        if result[0] == 0x00 {
            println!("page 10: {:?}", &result[1..5]);
        }
    } else {
        println!("Found: nothing");
    }

    Ok(())
}

Hi. Thanks for taking the time to submit this issue. There is currently a bug SPI implementation in 0.2.2 which is fixed by #7.
I haven't gotten around publishing a new version, sorry about that.
Could you check if using this fixes your problem?
pn532 = { git = "https://github.com/WMT-GmbH/pn532", features = ["msb-spi"] }

You'll probably also want to include this line before inlisting the target (I should update the readme)
pn532.process(
    &Request::sam_configuration(SAMMode::Normal, false),
    0,
    50.ms(),
)?;

Thanks for the quick response.
Unfortunately it throws an TimeoutAck error at this new line.

Unfortunately it throws an TimeoutAck error at this new line.

That is with the updated git dependency?

Unfortunately it throws an TimeoutAck error at this new line.

That is with the updated git dependency?

Yeah, I still get the same error.
[dependencies]
pn532 = { git = "https://github.com/WMT-GmbH/pn532", branch = "master", features = ["msb-spi"] }
rppal = { version = "0.14.1", features = ["hal"] }

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: TimeoutAck', src/main.rs:25:10

Note: I'm using unwrap() rather than ? to get it to panic if there is an error.

Hm strange. At this point I can't see why the code woudn't work.
Could you compare the signals with the adafruit implementation using a scope or logic analyzer?
I'll try and reproduce the issue on my end but I won't have access to the hardware until in two weeks.

Could you compare the signals with the adafruit implementation using a scope or logic analyzer?

I don't have either on hand today, i'll see if I can get ahold of one this week.
In the meantime, do you think it's worth me testing I2C to see that that works?

Sure thing! Be sure to cross check with the adafruit library to rule out hardware issues :)

In regard to SPI, changing the CS pin from 8 to 5 on the RPi seems to have resolved the consistant TimeoutAck error when calling sam_configuration(...). I'm satisfied that this is not an issue with the library. Thanks for you help.

Thanks for checking back in. Glad you found a solution :)


Support game version 1.0.2

Slowroads.io just updated to v1.0.2. Userscript v1.2 will not support this version even if I add the modified game script.
Before I modify the game script I have to check if I can still use the same method for exposing the game's state.
Required changes

Change Core.settings.supportedVersion to 1.0.2
Add new modified game script for main.131c9059.chunk.js to the /dist directory

Changelog for v1.0.2

Good news, I have just checked the game script for v1.0.2 on main.131c9059.chunk.js. Here are my findings:

✔ I can keep using the same method for exposing the game's state
✔ All handling keys accessed through the handling editor still exist

✔ There are no new handling keys (metrics) I would want to implement

The modified game script will be kept in the branch userscript-v1.3 while I test it. It will be pushed to main along with v1.3.
Meanwhile I have to remember to edit the CDN URL to point to the correct branch.

Relevant:

a933e9f19442653028994b3957e7f386f3a0e6c5
a16c62bd64348584662fe2dd086dfc6d84f0eda2

Relevant:

bb0fb6377798e6daa3fb6fdd1477332dbea9685a

I always forget to tag issues in commit messages :(

Alright, I think the release is just about ready.
Hold on


Specify Init Position

Is there any way to specify where you want your character to initialize (ie x,y coordinates)?
Also, is there any way to extend the episode length beyond 2500 for Train Envs?

Hi @karamarieliu,
I think the episode length could be extended by changing some constant like this one. If that doesn't help, you would need to edit wad-files directly. They internally contain ACS (action code scripts), which allow to do almost anything -- but require installing an editor (Slade) and some familiarity with their C-like language.
Setting up the starting point should be doable through omg library like this. Basically, everything is a "thing" (including player_start), you can retrieve "things" in various ways and change their properties like coordinates. In that example, I load a wad with the map, edit it and resave. The easiest way to install omg is pip install omgifol.
Hope that helps. Let me know if you have more questions!


[feature] Evaluate accuracy rate.

Currently, we do not have too many ways to evaluate the accuracy of RAG response. So, we need to implement an evaluation framework to help us to do this.
Reference:

https://www.kaggle.com/code/aisuko/arena-leaderboard-with-semscore
https://www.kaggle.com/code/aisuko/evaluating-llms-on-any-dataset-using-semscore

@Aisuko Happy to take this issue, were the team set on using sem score as a measure of accuracy?

Hi @CarterFaceySmith good to see you want to put effort on this issue. However, we need to fix the issue we hit on Kaggle first. I suggest you do some issues with good-first-issue. Those issues are easier for you to do contributions.

Hi @CarterFaceySmith I have been set CUDA_LAUNCH_BLOCKING to 1 then the notebook does not work anymore. The whole notebook kernel is down(no idea why it happened). And I discussed to the author, he suggests to run the notebook on a single 3090 GPU. https://medium.com/@aisuko/thanks-for-your-great-work-0becf405a720
I have some GPU resource at RMIT Race Hub. If you want to test it. ping me anytime.
For the Huggingface token, I suggest you create a token in your HuggingFace account. You can update fine-tine model  to your own huggingFace


[AutoDiff] Revamp PullbackInfo

PullbackInfo -> LinearMapInfo
With the introduction of Forward Mode Differentiation, the name PullbackInfo is not correct anymore. To recall, it stores information about the JVP/VJP generation. thus, a more general name of LinearMapInfo more appropriately represents what it stores.
Specifically, it stores the differential and pullback functions, which are linear functions. We map those functions to the original apply calls, which is where LinearMapInfo and linearMapStructs comes from.
Revamp linearMapStruct creation to occur before JVP/VJP emission
In my forward mode PR #26057 , I experienced an LLVM IR bug. What was going on is that it was caching the linear map structs before the linear functions were added. Those functions were being added while we were visiting the relevant instructions in JVP/VJP emission.
The solution to avoid this caching problem was to bring the part where we add the linear map functions earlier to when we create the LinearMapInfo. Thus, when the JVP/VJP emission pass occurs, it will cache the full linear map struct.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow


Created Many-To-Many Relationship Tag & Question

Added to class 'Question':

field:
tags = models.ManyToManyField('Tag', through='Question_Tag')

Added to class 'Tag':

field:
questions = models.ManyToManyField('Questions', through='Question_Tag')
model function:

add_tags - the input is a set of strings that represent tag names.
The function creates and saves to the DB all the tags that do not
exist yet in the DB.
tags_feed - the function returns a set of tags ordered by
'tag_name' and filtered by the input or the default value.

Added to class 'Question_Tag':

model function:

add_quetion_tags - the input is a set of strings that represent
tag names and integer that represents question_id.
The function creates a relation between all the tags and the
question.

Modified: home/models.py
New file: home/migrations/0013_auto_20210414_1712.py
Notes:

The added fields create virtual sets that will allow easy access to
the related tags of a particular question and questions of a
particular tag with: object_name.field_name.values().

LGTM

Looks good

Where are the tests? Either add tests to the new logic functions or drop them.

I'm working on the Tags UI. Is it possible to add all the tests there?

Where are the tests? Either add tests to the new logic functions or drop them.

I'm working on the Tags UI. Is it possible to add all the tests there?

Possible, but not advisable. The point of adding logic funcitons to the data model is to enable testing the logic in a way that is separate from the UI concerns. Please take advantage of that.

I've added tests for the new logic functions:)

I think this PR is ready for a re-review @ifireball @AviadP

@ifireball , I followed your instructions and committed the changes.

@ifireball , I followed your instructions and committed the changes.

I still see blocks of code with "header" comments in your tests - for example  test_tags_feed_with_test_tag has 3 assertions in it that seem unrelated - those probably should be different tests.
If you feel like the code you wrote is not clear enough and you need to write a comment to explain it - its a good indicator that you perhaps need to refactor the code so its clearer.  For example, by selecting better method names.

@ifireball , I followed your instructions and committed the changes.

I still see blocks of code with "header" comments in your tests - for example test_tags_feed_with_test_tag has 3 assertions in it that seem unrelated - those probably should be different tests.
If you feel like the code you wrote is not clear enough and you need to write a comment to explain it - its a good indicator that you perhaps need to refactor the code so its clearer. For example, by selecting better method names.

test_tags_feed_with_test_tag has been split so each will have only 1 assert.
I'm having trouble splitting test_add_tags_to_question - all the asserts are connected logically, they all check if the many-to-many logic and the function logic work. Do you have any suggestion?

@ifireball , I followed your instructions and committed the changes.

I still see blocks of code with "header" comments in your tests - for example test_tags_feed_with_test_tag has 3 assertions in it that seem unrelated - those probably should be different tests.
If you feel like the code you wrote is not clear enough and you need to write a comment to explain it - its a good indicator that you perhaps need to refactor the code so its clearer. For example, by selecting better method names.

test_tags_feed_with_test_tag has been split so each will have only 1 assert.
I'm having trouble splitting test_add_tags_to_question - all the asserts are connected logically, they all check if the many-to-many logic and the function logic work. Do you have any suggestion?

When I look at the test, only the first assert seems to test the functionality of the add_tags_to_question the rest seem to test various aspects of having tags linked to questions, so perhaps have such links in your test data or create them in a separate fixture to test those things in their own tests.
I still see the comment in your code - please remove them, if you still think you need them it means you probably need to give better names to the test functions.

@ifireball thank you for the suggestion:)
All of the test include only 1 assert each.
I deleted the comments and won't add comments from now on.
@AviadP


Redirect legacy events page to commmon components overview

This pull request closes #6940
It redirects the docs/events page from legacy to Common components (e.g. <div>) overview page where all events handlers are listed.

We don't do redirects like this, any existing links to this page should be at reactjs.org/docs/events.html which will correctly redirect to https://legacy.reactjs.org/docs/events.html, which has a note that links to the new docs page. If anyone is linking to react.dev/docs/events.html then the link is broken upstream, and whoever is linking to it should fix it there.


[SPARK-25595] Ignore corrupt Avro files if flag IGNORE_CORRUPT_FILES enabled

What changes were proposed in this pull request?
With flag IGNORE_CORRUPT_FILES enabled, schema inference should ignore corrupt Avro files, which is consistent with Parquet and Orc data source.
How was this patch tested?
Unit test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3623/
Test PASSed.

Test build #96850 has started for PR 22611 at commit e96ea20.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3624/
Test PASSed.

Test build #96851 has started for PR 22611 at commit 404b1a0.

Test build #96850 has finished for PR 22611 at commit e96ea20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96850/
Test PASSed.

Test build #96851 has finished for PR 22611 at commit 404b1a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96851/
Test PASSed.

Test build #96891 has started for PR 22611 at commit 692334a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3653/
Test PASSed.

Test build #96891 has finished for PR 22611 at commit 692334a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96891/
Test PASSed.

@HyukjinKwon Thanks for the review :)

Merged to master.


What calculations are performed by the Aggregation function?

Thank you for your great work!
When I run the SAM module on PatchWise-Attention (sa_type=1) for verification, the input tensors of the Aggregation function has the following shape.

In the paper, it says that the outputs of the streams are aggregated via a Hadamard product.
Would you like to tell me what operations are performed on the tensors of these different shapes to perform a Hadamard product?

Hi, for a local footprint (e.g., KxK) in each position, the tensor's shape is C/r_2xKxK, the learned attention weights w is C/r_2/share_planesxKxK. And 'share_planes' number of channels share the same attention weight. We do Hadamard product and spatial aggregation to generate the output for this position.


[docs] Add demos for public picker components

Required for https://github.com/mui-org/material-ui/pull/25811
Lists demos of:

CalendarPicker (/components/date-picker)
CalendarPickerSkeleton (/components/date-picker)
DesktopDatePicker (/components/date-picker)
DesktopTimePicker (/components/time-picker)
MobileDatePicker (/components/date-picker)
MobileTimePicker (/components/time-picker)
StaticDatePicker (/components/date-picker)
StaticTimePicker (/components/time-picker)

Adds demos for:
Note that these demos aren't necesarrily pretty. They help us identify where to apply styles better. It seems to me some of the MonthPicker or YearPicker styles are better suite to live in their parents. We can improve their customizeability later though. The goal in this PR is to list them. Not to finalize them for release.

[x] ClockPicker (/components/time-picker)
[x] DateRangePickerDay (/components/date-range-picker copied from https://next--material-ui.netlify.app/components/date-picker/#customized-day-rendering)
[x] MonthPicker (/components/date-picker)
[x] YearPicker (/components/date-picker)

Let's unblock other work. The remaining items are either subjective nits or existing issues that are not couple to this PR.


Auto zoom the y axis when zooming in

Fix #396.
Cc: @moorepants

Coverage remained the same at 70.456% when pulling 92095d4db103e532b44c4147a7901ab0491d3b62 on mdboom:auto-zoom-y-axis into 1acf9612abc37ec993f62536b94673a08c2cc5cc on spacetelescope:master.

I'll try this branch out tomorrow. Thanks!

I finally checked this out. It seems to be doing what I'd expect, although I don't have access to our larger sympy asv database at the moment. I just ran a few commits and the y axis max seems to scale to the data on the screen. Thanks!

LGTM


fix fix simdjson reader will parse given root twice when data is object array

Proposed changes
if we set jsonroot is not empty , and data is object array , here will meet status like this:

Issue Number: close #xxx

run buildall


Fetch unconfirmed utxos as well

Can't see a reason why not. :-/

Thanks! Keep in mind it might take a few hours for the changes to update on the site due to cloudflares cache.


Have docker command use $HOME instead of '/Users/mary'

I recognize people following the tutorial should not just be copy+pasting as they go, but this small change allows someone who is doing that to have the docker command work without replacing mary with their own home folder, and is consistent with prior instruction to cd $HOME.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:kookster/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

LGTM

LGTM


404 Errors on SSR pages

Followed the video tutorial to deploy a Sveltekit app. But everything that is server rendered throws a 404 error.
From the logs I gather that the lamdas are getting deployed and executed but still throw a 404 error

Omg hello! thank you for replying so fast. Yes I tried this but I am still having the same issue. Maybe its a problem related to the upgrade to sveltekit 2.0?

@tristan-valar  I recently tested the deployment of sveltekit 1.2 project, using amplify-adapter v0.1.0, and all ok.
Then I made an npx svelte-migrate@latest sveltekit-2 to upgrade sveltekit version to ^2.5.0, and access was succesfully.
Could you share your dependencies please?


Support for TCRseq and template update

Template update to v12.1
Add support for 5'RACE data
Add support for TCRseq data

PR checklist

[x] This comment contains a description of changes (with reason)
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/bcellmagic branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[ ] README.md is updated

Learn more about contributing: https://github.com/nf-core/bcellmagic/tree/master/.github/CONTRIBUTING.md

@apeltzer thanks for spotting the missing things in the README, fixed now!

No problem, thanks for putting in so much work 🎉


Redefining K2State, adding methods and tests from K2StateTest

Definition that an initial state can be true

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.244%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5835

Relevant Lines:
14499

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.244%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5835

Relevant Lines:
14499

💛  - Coveralls


Feature/light and vob misc

add data for every misc vob, light/lightpreset and additional data for light_maps (TODO left: add normals array for light_map)

Okay, I'll merge this but in the future, please split out unrelated changed in separate subsystems into multiple PRs :)


fix: Make help command inline

The problem:
The help command looks like a brickwall of text in the chat.
Moreover, the help command will potentially grow in the future, might get more space now.
Proposed Fix:
A fix would to set inline=true in the embed definition.
Context: <^help command>

<discussion on the discord server in #bot-chat>

The current fix is just a temporary one.
In future we might have to consider:

Putting commands on a website
OR
Putting commands in a .md file in the repo, which can be synced using Actions

<discussed on the discord server in #bot-chat>

Could you share some of the discussion in the description? Copy and paste of screenshot

(I've added the chat screenshots in the description)
Here's a preview of how the current fix looks like:
Should there be more consideration on this?

Essentially this is still a brickwall(just a bit more compact) :(

Thank you for raising the issue 👍 .
I would suggest doing small improvements and we can see if more is needed. So for now, making it inline will be an improvement, with less work than migrating it, then the community will get the benefit sooner.
After that has been tested, if it needs more work, a new issue can be raised 🤓

(I think we could make it look more compact if we sort it first according to length of descriptions)

Sure, give it a try 👍

What if we took the substring of the long descriptions.  Then add a link to the raw markdown?
if (str.length > someValue) {
  str = `${str.substring(0, someValue)} ${markdownLink}`;
}

some more discussion:

How about we take the substring of the long descriptions and add a link to the raw markdown.

We might have to do that, I was hoping to make a small improvement first, and raise another issue if required that would need more work

I think I'll close this issue for now
(I'll make a new one regarding the help command and add the discussion key points)

Yes thanks for closing, the PR was merged and a new issue can be made for next steps 👍


Extend the resource DSL to support change windows

We need to ship initial support for change windows in resources so that users can write resources that run during windows or are excluded during windows. This would look something like this (pending customer confirmation / better names):
execute 'do the install' do
  command 'some terrible service impacting deploy command'
  run_window "CRON TIME"
end

package 'nginx' do
  action :upgrade
  no_run_window "CRON TIME"
end

Work involved

Add new feature in DSL
Add it to the kitchen tests
Document it as a common property in the resources docs on docs.chef.io

Replaced with https://chefio.atlassian.net/browse/INFC-78


How to change favicon in docker?

Hi, I need some support with regards to how to change the favicon.
I'm running in Docker and instead of the default blue stack of books, I would like to use my own favicon instead. However I am unsure where to place it or change the relevant settings.

Hi @madmads11,
There's currently no app specific way of changing the favicon.
The best way to achieve this currently, without altering app files, would be to set-up a webserver rule for requests to /favicon.ico and serve your custom favicon on that rule.

Hi Dan Brown, thanks for the quick answer.
I don't mind altering the app files, my problem is that I cannot seem to locate the favicon.ico file. I'm running in Docker and I've been searching but can't find it. What's the location of it?

Within the project it's within the public folder. It's served at the /favicon.ico endpoint. Where that is within the container or mounted volumes will depend on the specific container you're running. What docker setup are you running?

Due to the lack of response from the original issue author I will close this.
If this issue remains please feel free to open a new issue, referencing this one.


helm: Add flag to disable CRD check for mass server-side apply

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

When using a mass deployment tool (like kluctl) helm may be rendered locally before being submitted.  In this two step process the CRDs are not yet deployed and thus the chart fails to render.  The ability to pre-render the templates simplifies generation of the manifests for offline review or pass through kustomize.  This sort of gitops workflow does all the renders in one step for review, then the apply in another step once the differences are approved.
helm: Add flag to disable CRD check for mass server-side apply

I'd like to see this in both 1.14 and 1.13 so I don't need to maintain a local fork of the 1.13 chart.

I'd like to see this in both 1.14 and 1.13

Should be in for 1.14, but I'm afraid this does not fall within the criteria we use for backports. I understand this may be frustrating, but it's hard to know where to draw the line if we start making exceptions :confused:.

/test

I'm not sure how to address the one failing job.

I'm not sure how to address the one failing job.

It's not marked as Required, so no action is needed AFAIK.

This job was broken a few days ago, then fixed. You'd need to rebase your PR to have it run correctly, but as Alex said it's not necessary in the current case.


Add a sqlite db to slask

Slask should give each plugin access to a sqlite db.

Added in 946ec65343d97f1d3147aea9baa1b5a33562a377


WIP Scala Steward without sbt-updates

This shows how Scala Steward would work without sbt-updates.

My public Scala Steward instance is now using this branch and I love it. Instead of 2 to 3 hours to check all 900 repos it now only takes 30 to 40 minutes.


Codecov Report

Codecov Report

Merging #1064 into master will increase coverage by 0.02%.
The diff coverage is 97.82%.

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   95.15%   95.18%   +0.02%
==========================================
  Files         429      429
  Lines       12574    12639      +65
==========================================
+ Hits        11965    12030      +65
  Misses        609      609

Impacted Files
Coverage Δ

src/Binance/Address.h
100.00% <ø> (ø)

src/Coin.h
100.00% <ø> (ø)

src/Ethereum/Entry.h
100.00% <ø> (ø)

src/HDWallet.h
100.00% <ø> (ø)

src/Keystore/StoredKey.h
100.00% <ø> (ø)

src/interface/TWAccount.cpp
25.00% <0.00%> (ø)

src/interface/TWAnyAddress.cpp
94.66% <ø> (ø)

walletconsole/lib/Address.h
100.00% <ø> (ø)

src/Binance/Address.cpp
100.00% <100.00%> (ø)

src/Binance/Serialization.cpp
97.50% <100.00%> (+0.94%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe98234...a1c1ee6. Read the comment docs.

Originally posted by @codecov[bot] in https://github.com/trustwallet/wallet-core/issues/1064#issuecomment-668979687

codecov.io is no longer supported


Adding MetricNamespacesAPI for version 2017-12-01-preview/Fix metrics_API.json format issue

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-node

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Thanks @LarryZhang19 - could you please fix the model validation error:
 error:
operationId: MetricNamespaces_List
scenario: Get Metric Namespaces without filter
source: request
responseCode: ALL
severity: 0
errorCode: DOUBLE_FORWARD_SLASHES_IN_URL
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  id: OAV129
  message: >-
    In operation "MetricNamespaces_List", example for parameter "resourceUri":
    "/subscriptions/a252e87d-ec06-45b1-8901-57e613be91b0/resourceGroups/larrytest/providers/Microsoft.DocumentDB/databaseAccounts/larrytestdocdb"
    starts with a forward slash and the path template:
    "/{resourceUri}/providers/microsoft.insights/metricNamespaces" contains a
    forward slash before the parameter starts. This will cause double forward
    slashes  in the request url. Thus making it incorrect. Please rectify the
    example.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''

Fixed the resource uri and pushed the change again.


otsuthr.cpp:52: new & delete in wrong place ?

[otsuthr.cpp:52]: (style) Variable 'histogramAllChannels' is allocated memory that is never used.
Suggest move new & delete of histogramAllChannels inside the #ifdef USE_OPENCL
.

Can you please make pull requests?


Not showing Presence

Hi, I am trying to enable Atom Editor on my Discord Presence using this package but it doesn't show up.  I am using the latest Atom and atom-discord version. I have the package enabled and my game activity enabled but nothing shows, if someone can help me fix this issue, it'd be much appreciated.
Information
Platform: Windows
Atom:   1.48.0
Package Version: 2.0.2

Hey @DynamixYT,
Just to be sure are you launching Discord before Atom? And have you already attempted to reinstall / manually install the package? Furthermore, are any errors showing up when installing the package?

Well, Discord was already open beforehand and I have only installed the package via Atom itself, not manually.

Discord should be open before atom so no possible error there.
I would recommend attempting to uninstall the package then reinstalling it through the built-in package repo.
If that does not fix it, then try an install using the command line and running apm install atom-discord and let me know what the terminal spews out.

Discord should be open before atom so no possible error there.
I would recommend attempting to uninstall the package then reinstalling it through the built-in package repo.
If that does not fix it, then try an install using the command line and running apm install atom-discord and let me know what the terminal spews out.

I would also recommend uninstalling the package by executing apm uninstall atom-discord in a terminal window as suggested in the FAQ
On that note, I would also recommend following these suggested steps when encountering this error.


 :L i have a mac but i dont know how to fix, please help!

Invalid issue format, refer to the guidlines in the README.MD