Favorite preset

refs #5873

@quincylvania I didn't get the preset favorite/tag-reference buttons sharing the same vertical space figured out (my kung-fu for making fiddly css changes is lacking :grin:).  But I did get the favorite preset/modes wired up.  It relies on changes to mode constructors that will hopefully pass muster.
The favorites get written to local storage.  This code is in the context because I needed access to the favorites from the favorite star button as well as the modes; and also needed to be able to fire an event when favorites change to trigger the modes update method.
The preset favorites have a limit of 3 currently (no drop down at this point).  I also rationalized that the tooltip could describe the geometry type bound to the favorite (instead of figuring out the icon geometry modifier).

Thanks @brianhatchl! I'm working on fixes for the 2.14.2 point release right now. I'll take a look once things settle down!

@brianhatchl I ended up tweaking a lot of little things like the icons and tooltips but the underlying code seems to do the trick. Thanks again!
@bhousel I'm happy with this as an initial implementation. It could still use some polish as we build out #5882 and #5960 but I think we can merge it as soon as you can give it a look over.

Further considerations:

We should allow more than 3 favorites and have some mechanism for when they don't all fit.
When not all the buttons fit, we should remove favorite labels starting right to left and not necessarily remove them all at once. (I'd also be okay with never showing the favorite labels. They're somewhat ungainly.)
There should be a way to remove a favorite without having to have a feature of that preset selected.
The ability to drag-and-drop reorder favorites would also be cool.
The icons look weird when the button is selected but this won't be an issue after #5960.
The keyboard shortcuts should continue down the number row, so 4 selects the first favorite, etc.
After #5882, the Point, Line, and Area buttons should not be given special treatment. They would be favorited generic presets that the user can unfavorite to remove altogether.

@bhousel I'm happy with this as an initial implementation. It could still use some polish as we build out #5882 and #5960 but I think we can merge it as soon as you can give it a look over.

This looks great!   I took a quick look over the code and it all looks great 👍  Go ahead and merge it so people can start using it and we can collect some early feedback..


Demag_gui doc review comments and minor suggested changes

@moonshoes87, I'm looking over the dmag_gui docs as I look over the missing column issue. Here are some comments. I'm on a Mac and just pulled from master.
On 3.4 Demag GUI quick start

Maybe you state elsewhere that for hotkey ctrl means command on a Mac, but unfortunately Mac also has a control key and that does not work for the hot keys. Coming directly to this page, I tried ctrl-n and it did nothing. Not a huge deal as Mac users will likely try command, but a bit confusing. Not sure if the text should be changed or Demag GUI changed so ctrl also works for the commands in addition to the command key.

On 5.1 demag_gui.py
2)"Another way to edit bounds is to double-click the list of measurement steps in the list on the left. The included steps in the currently selected interpretation are shown in highlighted in blue on the measurement list and the measurements marked “bad” are shown in highlighted in red. In the case of duplicate measurements, the first good measurement with the same treatment is used as a bound."
It is not clear how to mark a sample bad. I thought double clicking twice might do it, but it doesn't. Right click works. How about:
" Another way to edit bounds is to double-click the list of measurement steps in the list on the left. The included steps in the currently selected interpretation are shown in highlighted in blue on the measurement list and the measurements marked “bad” are shown in highlighted in red. Bad measurements can be marked and unmarked by right clicking on them (this change takes a moment to appear). In the case of duplicate measurements, the first good measurement with the same treatment is used as a bound."
3)"This display option can be changed in the second drop-down menu under interpretation type." I don't see this option. Also: ""This display option can be changed in the Edit menu under interpretation type." would be clearer unless that menu changes names on a Mac v Other.
4)"by using the drop-down menu under the label ‘interpretation type’."
Using the term label and box for the same GUI type is a bit confusing. I was looking for a drop down in the main header bar. Box is used to describe the 'Interpretation Directions and Statistics’ box, and I think that is less confusing.
Change to?
"by using the drop-down menu in the ‘Interpretation Type’ box. Not sure if you want to change all of the capitalization, but it is clearer when the docs have the same capitalization as the GUI and the next label has that treatment.
5)"select the one you wish to delete from the interpretation drop-down menu and click ‘delete’."
change to the label on the button 'delete highlighted fits'
These docs are quite good and pmag_gui is much improved since the last time I used it extensively. Thanks.

We have options.  Many of the shortcuts could be made to work with cmd or ctrl on Mac.  However, others have built in OSX functionality -- for instance, ctrl up or ctrl down.  Given this inconsistency, I think it is probably better to just explain that you need to do command instead of ctrl, so I'm adding a bit about that in the quickstart section and in the main Demag GUI section.

Done

I believe that text is referring to the second menu here (defaults to whole plane):

I changed for that paragraph (sorry, in LaTeX):
The name of the fit can be changed from the default by typing into the drop-down box containing fit name. The default fit type is a least-squares line. You can choose different fits, such as a line anchored to the origin or a plane, by using the drop-down menu in the Interpretation Type' box. Plane fits can be plotted as either poles, full planes, partial planes, best fit vectors, or best fit vectors and full plane ({\bf Note:} plane poles will be displayed as squares and best fit vectors will display as sideways triangles on \hyperref[higher-level-plots-and-interpretation]{high level mean plot}). This display option can be changed in the second drop-down menu in the Interpretation Type' box.

Done

Changed it to 'delete fit' (still trying to keep it short for space reasons).

I did not check to see how these changes look, but from your comment it looks like you dealt with everything, so I'll close the issue.


Fix #1275 in the case where the --add-imports option is given

Fixes #1275.

Codecov Report

Merging #1312 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop     #1312   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           34        34
  Lines         2159      2174   +15
=========================================
+ Hits          2159      2174   +15

Thanks for this! I've manually merged this in develop, (just to try to find a slightly less hacky way to do it: https://github.com/timothycrosley/isort/commit/fd87001295467c87612a8cdbcaa4c3239f4989b6)
Thanks!
~Timothy

@timothycrosley No problem.  The test case is good though.
I didn't feel like really diving into that _sort_imports() function to figure out wth is going on. That function needs to be refactored IMO.


[scheduler] Work on KWOK simulation

/test rhoai-light scheduler kwok

/test rhoai-light scheduler


Clarification.

Hi!  Faster is better.  Thanks :-)
It would be interesting to know what the original say/print/put do instead of this and why.  When would the originals be a better choice?  If these ones are faster, what advantage do you get by using the slower originals?
Also,  when using the "unprint" module, will it also get used in the object call case,  such as:
42.say
"hello".put

On 8 Jul 2018, at 16:37, Sean<EMAIL_ADDRESS>wrote:
Hi! Faster is better. Thanks :-)

Yeah…  it usually is.

It would be interesting to know what the original say/print/put do instead of this and why. When would the originals be a better choice? If these ones are faster, what advantage do you get by using the slower originals?

The originals use the complete class hierarchy and properly check $*STOUT and what the proper line ending is for the handle living in $*OUT.
Which you may not need in many cases, especially small scripts.

Also, when using the "unprint" module, will it also get used in the object call case, such as:
42.say
"hello”.put

No, I don’t intend to do that.  The reason for that is that it’s easy to lexically override subroutines, it is a lot harder to lexically overwrite methods on core classes.
Kind regards,
Liz


InsynchqPteLtd.Insync version <IP_ADDRESS>973

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@ItzLevvie Is it better now?


Add no jobs found message to frontend

In the case that the job scraper returns no jobs after clicking the "update jobs" button, output a message to the user "Oops, no jobs were found. Please try again." instead of having a blank screen.

https://github.com/nguyenha1910/opentowork/pull/133 shows the message if 1) there's no csv found in the csvs folder, 2) the csv only has header, 3) the rows are all NULL values (except header)


added PHPDoc to RemoteWebDriver's execute method

In order to have @throws WebDriverException, so IDEs don't complain about unused catch statements.

We are generally not using @throws everywhere... Adding it here would mean IDEs will start to complain eveywhere else where execute is used internally (findElement(), get(), close() and tons of other methods) :thinking: .
I'm not sure how to handle this. Best would maybe for all user-space methods to have defined @throws WebDriverException. But I don't know whether we want to update this in 1.x.
What do you think @itaibh ?

Closing this for now - however we should take care of this in php-webdriver 2.0 (see #657), as this is simply too much effort doing this properly for 1.x.


1.19 wont load correctly

attached error report and latest log report
Failure message: Builders Crafts & Addition (buildersaddition) has failed to load correctly
java.lang.reflect.InvocationTargetException: null
crash-2022-07-16_19.17.29-fml.txt

Also having this issue, lmk when it's fixed!

Hi, I think that it could be related to what is mentioned in this post: https://forums.minecraftforge.net/topic/113464-119064-dont-use/

Same here-
.93 had another breaking change I think as well.

I'm also having this issue, I hope it gets fixed!
I would really like to use this mod over some of the others that do similar things...

fixed in 20220802a.

Thanks a lot!


Microsoft Graph v1.0: teams team set

The teams team set command uses a beta endpoint that is now in v1.0.
https://github.com/pnp/cli-microsoft365/blob/266fd8d68e2a71a9c3d8d58d5c133916193f99b9/src/m365/teams/commands/team/team-set.ts#L73
Update group: https://docs.microsoft.com/en-us/graph/api/group-update?view=graph-rest-1.0&tabs=http

Hi @garrytrinder, Please assign it to me.


Fix plugin crash

Fix file rename in application cache folder
Fix renderer close problem
Fix application crash problem

Why is this not yet merged? This fix works completely fine. Thanks for the fix.


error when running bloom model

RuntimeError: invalid dtype for bias - should match query's dtype

it works well when I load llama model, but I get that error when I tried to run bloom

Hi @raihan0824, this was recently fixed by #996. We will release a new version with the fix soon. For now, please install vLLM from source.


'Monitoring failed' in Proximity Example

I'm trying to use the Proximity Example from this repo. After adding my APP ID and the beacon ID's the app should be good to go and I should see something working, right?
The XCode console tells me:
Monitoring failed: This application is not authorized to monitor beacons, because of insufficient permission to use Location Services.
The app displays an alert showing 'Monitoring failed' with reason 'Make sure bluetooth is on and the app has permission to use it.'
The app never asked me for permissions but they are in the .plist file. Is this something I need to write myself or should this work out-of-the-box?
The full error:
Error Domain=ESTMonitoringV2ManagerErrorDomain Code=5 "This application is not authorized to monitor beacons, because of insufficient permission to use Location Services." UserInfo={NSLocalizedDescription=This application is not authorized to monitor beacons, because of insufficient permission to use Location Services.}

Hey IncognitoCore 👋
Thank you for bringing that up!
It should work out-of-the-box as you say, expect an updated version of the templates soon 😉 (@beardaway is cracking it as we speak 💪).
It's broken because of the new policy we use for Location Services permissions in the SDK. We used to ask for these permissions implicitly when starting monitoring, but a developer wouldn't have any control over permissions this way (e.g. what if a user disagrees?). That's the reason we switched to manual permission requesting (like you do when using Apple's Core Location).
That's how it all works now:
• ESTMonitoringV2Manager provides an interface for requesting permissions with either -requestAlwaysAuthorization or -requestWhenInUseAuthorization.
• ESTMonitoringV2Manager also provides a readonly property to check for current authorizationStatus.
• ESTMonitoringV2ManagerDelegate is additionally informed whenever the authorization status changes with -monitoringManager:didChangeAuthorizationStatus:authorizationStatus.
Does that answer your question? What do you think about all of that?

Hey @IncognitoCore !
We've fixed the issue last week, so you should be able to download working version of any template you want from our cloud: https://cloud.estimote.com/#/apps.
Sorry for the inconvenience 🙏  Now everything should work out of the box 📦

I am having a similar issue with my app (not using a template, though). I am trying to add the func requestAuthorization()  on appdelegate. But it doesn't get trigger and I keep getting the didFailWithError. Please advise
monitoringManager didFailWithError: This application is not authorized to monitor beacons, because of insufficient permission to use Location Services.


Hide border around accordion arrow in Chrome

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

Hide border around Accordion's arrow in Chrome

Removed

{{removed thing}}

Testing / Reviewing
Run sass or 'npm run-script build' to create a new carbon-components.css. Create an HTML snippet with Accordion and test in Chrome.

is there an issue attached to this pull request? if I'm not mistaken the outline is for a11y purposes

Hi 👋  Agree with @emyarod that this is working as intended.


fix: Mobile scroll for docs, improve setup

Changes

[x] Fixes the mobile styling for documention
[x] Improves the set up process, specifically around importing documentation

Mobile styling before this PR:
https://user-images.githubusercontent.com/921826/188508065-79af1816-f0bd-4b30-b38b-ce9aa9e877b7.mov
Mobile styling after this PR:
https://user-images.githubusercontent.com/921826/188508085-27579ae9-1149-430b-9023-f53746fc4c26.mov
Notes
If you'd prefer, I can remove the mix task and the documentation changes and just include the styling changes, but I thought it was helpful to add.

🚀 Thank you for your contribution! 🚀


Implement xml:base

Any opinion on these commits?

Any opinion on these commits?

@dsheets any opinion on the way xml:base is handled here?

I don't see where [...] the propagation of xml:base happens
The function generate_catcher takes lists of callbacks, each with an xmlbase: Uri.t option argument, to parse sub-nodes (and attributes).  generate_catcher makes sure the xml:base it receives is given (appropriately modified) to callbacks.

I now get xmlbase before parsing the other attributes and sub-elements.

@dsheets Thanks a lot for your careful reading of my changes!

@dinosaure I intend to merge it later today unless you comment.

Sorry for my no response but I have big problem with my only computer (in China) for a long time. I saw a piece of PR and I trust you. Sorry.

Sorry for you.  I also fixed the <content:encoded> which is required for the OCaml web site.  How about to cut a new release?


Nuxt framework project introduction of @ffmpeg/ffmpeg

code:
import { createFFmpeg } from '@ffmpeg/ffmpeg'
I attempted to install the import in nuxt, but encountered an error.
Vue-cli can create a project.
I don't understand the reason
ERROR MESSAGE:
Module parse failed: Unexpected token (29:51)                                                                                friendly-errors 14:28:44
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     /* From remote server/URL */
|     } else {

  const res = await fetch(new URL(_data, import.meta.url).href);

|       data = await res.arrayBuffer();
|     }

you have to put ffmpeg-core.js and ffmpeg-core.wasm inside of public folder then call
  await ffmpeg.load({
    coreURL: await toBlobURL(`/ffmpeg-core.js`, "text/javascript"),
    wasmURL: await toBlobURL(`/ffmpeg-core.wasm`, "applicaiton/wasm"),
  });
  message.

you can see my example nuxt here
https://github.com/KenZync/ojn-viewer/commit/7076493b44b9f88d03582cde032144219de7f9f0#diff-2bebd757a3f74205945b3426d6e1a6c548edd5231d7e225b0d366abc287ee4f4


Added ping controller to display build / release information

Using format shared across other projects to display build information.
Objective: We should be able to monitor current version / release id on PVB project.
@ashb pointed me to PQ project - https://github.com/ministryofjustice/parliamentary-questions/blob/dev/app/controllers/ping_controller.rb and proposed to follow that pattern.

@lukaszraczylo Can you update the title/description (and the commit message) to give some context on why you need this as well as what it is? It's hard to know if this is the right solution (or appropriate for merging) without knowing what you're trying to solve by doing it.

Looks good to me; thanks for clarifying the description, @lukaszraczylo! Does this depend on anything, or can it be merged now?

This change is standalone - if it's missing the fields in the META it will just have null in the field.

:bomb:…:boom:


Add vcpkg installation instructions

hpx is available as a port in vcpkg, a C++ library manager that simplifies installation for hpx and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build hpx , ready to be included in their projects.
We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.
Note: Currently only support dynamic build on Windows.
I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.

@NancyLi1013 thanks again for looking into this! We're giving away a STE||AR-Group t-shirt to all of our first-time contributors. If you're interested in receiving one, please get in direct contact with me to arange the delivery.

@hkaiser and @aurianer
Thanks for your review.
@hkaiser
Thank your very much with the big surprise to your first-time contributors.
I'm really happy to see this.
Considering the long distance between us, it might be not available to receive this special gift.
I feel a bit regret about this case.
Thanks again for all your help and efforts.

@NancyLi1013 the offer stands. Let's get back to it once the situation has normalized. Thanks!


Unitycatalog and Spark in Docker Container

Describe the bug
I have currently the following setup with docker containers:

unitycatalog container
spark-master container
spark-worker-1 container
spark-worker-2 container

All the containers are in the same docker network and I've created a docker volume which points to etc/data folder where all the unitycatalog data is stored. Furthermore, I've followed the docs in how to use apache spark to work with unity catalog. I am able to connect to the catalog by running queries like spark.sql("SHOW CATALOGS") or spark.sql("SHOW TABLES IN unity").
Whenever I want to interact with the data in the catalog and run queries like spark.sql("DESCRIBE DETAIL unity.default.marksheet"). I still see a nice result with the metadata of the table but It's also returning an error. Please see example below:
Traceback (most recent call last):
  File "/workspace/test.py", line 8, in <module>
    spark.sql("DESCRIBE DETAIL unity.default.marksheet").show(truncate=False)
  File "/venv/lib/python3.10/site-packages/pyspark/sql/session.py", line 1631, in sql
    return DataFrame(self._jsparkSession.sql(sqlQuery, litArgs), self)
  File "/venv/lib/python3.10/site-packages/py4j/java_gateway.py", line 1322, in __call__
    return_value = get_return_value(
  File "/venv/lib/python3.10/site-packages/pyspark/errors/exceptions/captured.py", line 185, in deco
    raise converted from None
pyspark.errors.exceptions.captured.AnalysisException: [DELTA_PATH_DOES_NOT_EXIST] file:/app/unitycatalog/etc/data/managed/unity/default/tables/marksheet doesn't exist, or is not a Delta table.;
DescribeDeltaDetailCommand
+- ResolvedTable io.unitycatalog.spark.UCSingleCatalog@10e36ede, default.marksheet, DeltaTableV2(org.apache.spark.sql.SparkSession@6c2eb2e2,file:/app/unitycatalog/etc/data/managed/unity/default/tables/marksheet,Some(CatalogTable(
Catalog: unity
Database: default
Table: marksheet
Created Time: Wed Jul 17 18:40:05 UTC 2024
Last Access: UNKNOWN
Created By: Spark
Type: MANAGED
Provider: DELTA
Location: file:///app/unitycatalog/etc/data/managed/unity/default/tables/marksheet
Storage Properties: [key1=value1, key2=value2]
Schema: root
 |-- id: integer (nullable = false)
 |-- name: string (nullable = false)
 |-- marks: integer (nullable = true)
)),Some(default.marksheet),None,Map())

Also running queries like spark.sql("SELECT * FROM default.marksheet LIMIT 5").show() returns the following error:
Traceback (most recent call last):
  File "/workspace/test.py", line 9, in <module>
    spark.sql("SELECT * FROM default.marksheet LIMIT 5").show()
  File "/venv/lib/python3.10/site-packages/pyspark/sql/session.py", line 1631, in sql
    return DataFrame(self._jsparkSession.sql(sqlQuery, litArgs), self)
  File "/venv/lib/python3.10/site-packages/py4j/java_gateway.py", line 1322, in __call__
    return_value = get_return_value(
  File "/venv/lib/python3.10/site-packages/pyspark/errors/exceptions/captured.py", line 185, in deco
    raise converted from None
pyspark.errors.exceptions.captured.AnalysisException: [DELTA_TABLE_NOT_FOUND] Delta table `default`.`marksheet` doesn't exist.

It feels like spark is looking for the location of the data path which is already mounted via a docker volume but this doesnt resolve the issue. I am curious if anyone has encountered this or if I am maybe forgetting something.
Thanks in advance!
To Reproduce
Steps to reproduce the behavior:

Build spark master image
Build spark worker image
Build unitycatalog image from dockerfile provided in current repos
Create docker compose file with unitycatalog, spark-worker-1, spark-worker-2 and spark-master. Put all the containers in the same docker network and create a docker volume mounted to etc/data folder. Make the volume also available on the spark containers
Create sparksession with following options:

"spark.jars.packages": "io.delta:delta-spark_2.12:3.2.1,io.unitycatalog:unitycatalog-spark_2.12:0.2.0",
"spark.sql.extensions": "io.delta.sql.DeltaSparkSessionExtension",
 "spark.sql.catalog.spark_catalog": "io.unitycatalog.spark.UCSingleCatalog",
"spark.sql.catalog.unity": "io.unitycatalog.spark.UCSingleCatalog",
"spark.sql.catalog.unity.uri": "http://unity-catalog:8080",
"spark.sql.catalog.unity.token": "",
"spark.sql.defaultCatalog": "unity",

Run following spark query:
spark.sql("DESCRIBE DETAIL unity.default.marksheet") or spark.sql("SELECT * FROM default.marksheet LIMIT 5")

Expected behavior
No error DELTA_PATH_DOES_NOT_EXIST or DELTA_TABLE_NOT_FOUND. I expect a dataframe with data of marksheet

Never mind I just now solved the issue by mounting the etc/data volume also on all the containers


[BUG] When using the same single tooltip on a page, the delayShow/data-tooltip-delay-show is not respected

Bug description
When using the same single tooltip on a page, the delayShow/data-tooltip-delay-show is not respected if you hover over them immediately after each other.
Version of Package
v5.28.0
To Reproduce
Steps to reproduce the behavior.
steps to reproduce in the attached stackblitz:

hover over "A tooltip" for 1 second
the tooltip is shown
immediately hover over "Another tooltip"

actual result: the "Another tooltip" is shown immediately
expected result: the tooltip should take 1 second before it is shown
Screenshots
https://github.com/user-attachments/assets/3a6f0157-4702-4f98-8546-3fa91b7e18c9
Desktop (please complete the following information if possible or delete this section):

OS: Windows 11
Browser: Microsoft Edge
Version: 131.0.2903.51
Frameworks: React 18.2.0

Hi @gabrieljablonski,
I would disagree that this is a common design pattern for tooltips.
If you want tooltips to be immediate then you set 0 delay. If you want tooltips to not be immediate then you set a delay. I don't see how these behaviours should be mixed as a "feature".
I have a complex dashboard page with many tooltips - and I don't want to be spammed with tooltips by just moving the mouse over the page after I have hovered on 1 tooltip somewhere.
Is this possible you can somehow solve this?
Thanks

Hi!
I can have upwards to 200-400 tooltip anchors present on one page, I know this might not be best practice. I tried using one tooltip per anchor, but this resulted in extremely high rendering times, as you can imagine.
Would it be possible to add a prop that would it so that the "fully closed" state is happening instantly? Or another prop that would make this behavior function as I am intending.


Issue with paper-dialog size in Polymer v1.X

I have following paper-dialog sekeleton setup inside one of my custom element.
<paper-dialog id="error_dialog">

{{error_message}}

{{error_detail}}

</paper-dialog>

as and when I get any error I update the values of "error_message" and "error_detail" and open the dialog, something like this dynamically by calling the showErrorInDialog method
showErrorInDialog: function(err) {
     this.error_message = err.message;
     this.error_detail = err.detail;
     this.$.error_dialog.opened = true;
}

But, the problem is, the paper-dialog width is only considered as per the width of h2 tag, e.g.
if h2 is "Error" and "p" is "There is an error with the connection, please check.", then paper-dialog width is as per the "Error" text in h2 only.
Please suggest what I am doing wrong.
Same post in stack http://stackoverflow.com/questions/39076054/issue-with-paper-dialog-size-in-polymer-v1-x?noredirect=1#comment65518885_39076054

This issue was moved to PolymerElements/paper-dialog#126


Remove concept of Configuration Sets

Configuration Sets (namespacing) were introduced to
allow storage of multiple configurations, and specify
a single active configuration at any one time.
The vision was that it would allow you to easily switch
between different configurations like "weekday" vs "weekend".
However, it adds a lot of complexity to the codebase,
and overhead in a number of extra redis calls. There
is no clear advantage of managing configuration sets
within qtrix itself. Whatever process would be activating
new configuration sets could just as easily specify
new queue weights and overrides. How the configurations
are stored is irrelevant to qtrix.
This PR is not complete - it is just a placeholder for work to come, and to
start socializing the plan. Feedback on plan/approach is welcome, but don't
bother scrutinizing the code changes yet.

I agree with the sentiment.  To be honest, we have not been using this feature.  I think we'd be better off it were simpler and eaiser to use.

This PR is now complete and ready for review. It should retain backward compatibility, as long as you were only using the "default" configuration set.


Terraform version updates, instance type update

Switch to instance_types = ["r5.xlarge"] in for notebook nodegroup.
Upgrade provider, module, and resource pinned versions,  switch to supported autoscaler repo.
Simplified configuration by computing rolearn and ditching allowed_roles.
Test vs. Terraform-1.0.3 OK
Update k8s version to 1.21
There's a corresponding CI-node template update on Tike TEST which needs to be made default to install Terraform-1.0.3.

More updates for kms-codecommit are coming

After deploying to Tike TEST and OPS I think this is ready to go.   Comparing the diffs to https://github.com/spacetelescope/terraform-deploy/pull/39 (diffing branches/repos) I think this has the baseline changes + some extras and I did not notice anything missing.   Since I squashed commits I think everywhere a version changes in both PR's is now a conflict,  one comments the version out,  one updates the version.

Why did you change "rolearn" from a variable to a local?  Just curious.

For some reason I can't "Approve".  This is great stuff!  I have no merge objections.


This extension conflicts with the GitHub Gist Explorer extension.

According to my observations, if this extension is installed together with the extension GitHub Gist Explorer (k9982874.github-gist-explorer, https://github.com/k9982874/github-gist-explorer), then this causes the removal of the GitHub Gist Explorer. If you perform operations with gist using the GistPad extension and then restart VS Code, then GitHub Gist Explorer will be deleted. Apparently at the moment, these expansions are incompatible and cannot be installed together. Link to this problem: https://github.com/k9982874/github-gist-explorer/issues/21 .

An additional check showed that this problem does not depend on the GistPad extension. I apologize.


fix: update dependencies

This PR updates all production dependencies to their latest versions. It also adds the lowest engines.node version to the package.json, based on dependencies used.
There seems to be a breaking change in how micromatch matches files, but I think there is an actual bug in how lint-staged claims it should work.
From the README:
// .js files anywhere in the root directory of the project
  "*.js": "eslint",

However, since we by default use matchBase: true, micromatch should match all js files, because:

If set, then patterns without slashes will be matched against the basename of the path if it contains slashes. For example, a?b would match the path /xyz/123/acb, but not /xyz/acb/123

Based on this, *.js should match <gitDir>/test.js as well as <gitDir>/deeper/even-deeper/test.js
Can you comment on this, @okonet ?
Fixes

[x] https://github.com/okonet/lint-staged/issues/555
[x] https://github.com/okonet/lint-staged/issues/608
[x] https://github.com/okonet/lint-staged/issues/634
[ ] https://github.com/okonet/lint-staged/issues/619 (worth taking a look at this as well)
[x] https://github.com/okonet/lint-staged/issues/641
[x] https://github.com/okonet/lint-staged/issues/636

Thoughts, @okonet

micromatch should match all js files

Yes, that’s intended behavior. We should update the readme to better reflect that.

I’m pretty sure some of the tests are then incorrect, since there it is explicitly tested that the behaviour matches the README. :thinking:
I’ll need to investigate more...

Considering #641 we should bump the dependency. At the same time I'd like to avoid breaking current "loose" behavior since it makes it really easy to get started with the lib and I believe 99% users use *.js globs to match all JS files. Can this be somehow be done with the v4 of micromatch?

@okonet I was able to work around the different results by doing:
matchBase: !pattern.includes('/')

in generateTasks. I'll close this PR and update dependencies in https://github.com/okonet/lint-staged/pull/639


Passing attrs through components?

Hello, I am trying to pass the attrs of a component down into a next-level component for inheritance reasons. When I do, it produces some gobbledygook in the rendered html.
For instance
{# a.html #}
<svg {{attrs}}>{{slot}}</svg>

{# b.html #}
<c-a {{attrs}}>{{slot}}</c-a>

{# template.html #}
<c-b
        fill="none"
        stroke="currentColor"
        stroke-width="2"
        stroke-linecap="round"
        stroke-linejoin="round"
>
    <path ...>
</c-b>

I also tried to pass it using a dynamic attribute like <c-a :attrs="attrs"></c-a> but that doesn't work either.
Is there a way to make this work?

Hi @curvedinf, it's not ready yet but there's an open issue for it here https://github.com/wrabit/django-cotton/issues/192, closing this in favour of that one.


vstest.console.exe failed with return code:<PHONE_NUMBER>

Environment: VSTS

account name: sator
team project name: (unable to share)
build definition name: "PR (unable to share)"
build id: 7481, 7482, 7487

Private agent 1 details

Agent.ComputerName
RIKVANDENBERG

Agent.HomeDirectory
C:\dev\agents\DARTHREVAN

Agent.Name
DARTHREVAN

Agent.OS
Windows_NT

Agent.OSVersion
10.0.17134

Agent.Version
2.136.1

Private agent 2 details

Agent.ComputerName
YODA

Agent.HomeDirectory
D:\Agent

Agent.Name
YODA

Agent.OS
Windows_NT

Agent.OSVersion
10.0.17134

Agent.Version
2.136.1

Issue Description
Today we are receiving conflicting messages about the usage of VSTEST.console.exe. A lot of pull requests builds with the VSTEST task are producing the "Failed with return code<PHONE_NUMBER>" unexpectedly.

Previous builds have never produced these errors and our stable main branch is also producing the same error code. From the 772 test, only ~690 are run before the tasks criticially errors out.
Here are our VSTS Test Task settings.

What have we attempted to solve the issue

Updated Visual Studio on Build agent from 15.7 to 15.8

Error logs
VSTS Task output
2018-08-20T11:36:28.8980888Z ##[debug]rc:3221225477
2018-08-20T11:36:28.8981166Z ##[debug]success:false
2018-08-20T11:36:28.9001722Z ##[warning]Vstest failed with error. Check logs for failures. There might be failed tests.
2018-08-20T11:36:28.9002112Z ##[debug]Processed: ##vso[task.issue type=warning;]Vstest failed with error. Check logs for failures. There might be failed tests.
2018-08-20T11:36:28.9008651Z ##[debug]Agent.Version=2.136.1
2018-08-20T11:36:28.9009075Z ##[debug]Release.ReleaseUri=undefined
2018-08-20T11:36:28.9009905Z ##[debug]Release.ReleaseId=undefined
2018-08-20T11:36:28.9010143Z ##[debug]Build.BuildUri=vstfs:///Build/Build/7482
2018-08-20T11:36:28.9010381Z ##[debug]Build.Buildid=7482
2018-08-20T11:36:28.9010933Z ##[debug]Agent.Version=2.136.1
2018-08-20T11:36:28.9012144Z ##[debug]telemetry area: TestExecution feature: TestExecutionTask data: {"builduri":"vstfs:///Build/Build/7482","buildid":"7482","areacode":"ExecuteVsTest","result":"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TestWindow\\vstest.console.exe failed with return code:<PHONE_NUMBER>","tracepoint":1005,"isusererror":true}
2018-08-20T11:36:28.9301162Z ##[debug]Processed: ##vso[telemetry.publish area=TestExecution;feature=TestExecutionTask;]{"builduri":"vstfs:///Build/Build/7482","buildid":"7482","areacode":"ExecuteVsTest","result":"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\Common7\\IDE\\CommonExtensions\\Microsoft\\TestWindow\\vstest.console.exe failed with return code:<PHONE_NUMBER>","tracepoint":1005,"isusererror":true}
2018-08-20T11:36:28.9302214Z ##[error]Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe failed with return code:<PHONE_NUMBER>

Event viewer
Application: vstest.console.exe Framework Version: v4.0.30319 Description: The process was terminated due to an internal error in the .NET Runtime at IP 6F4DA000 (6F440000) with exit code 80131506.

@rikvandenberg does you test exercise any native code by any chance?

@acesiddhu No it does not.
Is there a way to find more detailed information about why the vstest.console.exe is critically failing?

you can take dump of the testhost process and see what might be wrong. here is the link on how to do this
. Note that this will work for VS 15.5 or more.
https://github.com/Microsoft/vsts-tasks/blob/users/nigurr/Docs/Tasks/VsTestV2/docs/DumpCollection.md

@rikvandenberg hope the dump helped you get to the root cause? I am closing the issue for now. Please reopen or create a new ticket if you are facing the issue still

Thanks for letting us know. Do open a new issue if you are facing any issues.

This is happening for us now... We are getting the blame logs now. @rikvandenberg did you ever attempt to resolve this?  We cannot use dotnet test because we target .NET Framework.


[FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS does not work for local/embedded mode

What is the purpose of the change
This pull request fixed the num slot config value override error.
Brief change log

fixed the num slot config value override error.

Verifying this change
This change is already covered by existing tests*.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @tillrohrmann

cc @zentol @tzulitai if you have time, please review this PR, thanks~


Multiple Stages of the Database. Local/Staging/Production. Whats the best way with Propel?

Hey, trying to get my head around how to handle multiple Database Stages the best way with propel, without changing the config or having to set environment variables. Secondary might be an option, but is there a better way? Also thinking about the migrations etc, can they be made to multiple Stages too?
Thanks for the help.

I'd go with environment variables, or Symfony configuration system (if you use the PropelBundle), or propel.ext.dist.
You can even use propel.php format and do whatever you want. e.g. Using YamlDumper and load other yml files based on your application configuration. I'm not sure what type of configuration architecture you're using, but in general when you have staging and production server, you have usually a deploy script which creates either config files (like propel.php) or sets environment variables. What else would you like?

Ok, i didn't mention my real problem. To use either environment variables or different propel configs for the stages totally makes sense for sure.
But what about migrations? When i run migrations when i am in dev stage, how can i run the same migrations on to production or staging? Is this possible?
I know this is more a general question and not totally responsibility of propel. But it would be nice if this is achievable somehow.
I basically mean a migration store for each stage.

If you need to update your production database, you execute the propel:migration:up command on the production server (not from your localhost). Same with staging.

ok, i need to get my head around your first suggestion. not totally clear right now. Anyway, will find out ;)
Thanks for the help @marcj and keep up the good job.


Duplicate variable in entrypoint of nginx?

In the script entrypoint.sh of nginx (Here: https://github.com/mainflux/mainflux/blob/70955d1937759a634df1b2f00f301bd7637b0563/docker/nginx/entrypoint.sh#L15), is it normal that variable ${MF_THINGS_HTTP_PORT} is indicated twice?

Looks like a bug to me.

@manuio From what I understand, it will be fix when the #1066 will be closed. Right?

@jonathandreyer right!


Vulnerability data import

Import data for offline Harbor instance

Coverage decreased (-0.03%) to 54.296% when pulling 2936b00bbdd4b18fc36c01e659be9967619a3479 on hainingzhang:vuldata_import into e3e722b1f8e315d2b8dec063362b88d4a6f9312f on vmware:master.

Coverage decreased (-0.03%) to 54.296% when pulling fe84c198256018c1bb87e4579b33d59b708487e4 on hainingzhang:vuldata_import into e3e722b1f8e315d2b8dec063362b88d4a6f9312f on vmware:master.


Leading and middle rest elements in tuple types

With this PR we support leading and middle rest elements in tuple types. For example, we now support the following:
type T1 = [...string[], number];  // Zero or more strings followed by a number
type T2 = [number, ...boolean[], string, string];  // Number followed by zero or more booleans followed by two strings

Previously it was not possible to have anything follow a rest element and thus it was not possible to express tuple types that end in a fixed set of elements. Such tuple types are useful for strongly typing functions with variable parameter lists that end in a fixed set of parameters. For example, the following is now permitted:
function f1(...args: [...string[], number]) {
    const strs = args.slice(0, -1) as string[];
    const num = args[args.length - 1] as number;
    // ...
}

f1(5);
f1('abc', 5);
f1('abc', 'def', 5);
f1('abc', 'def', 5, 6);  // Error

Note the use of a rest parameter with a tuple type that starts with a rest element. Also note that indexing a tuple type beyond its starting fixed elements (if any) yields a union type of all possible element types (in this case string | number). Thus, type assertions are required in the code above.
Tuple type layouts are now governed by these rules:

An optional element cannot precede a required element or follow a rest element.
Multiple rest elements are not permitted.

Thus, the supported layouts of tuple types are:

Zero or more required elements, followed by zero or more optional elements, followed by zero or one rest element, or
Zero or more required elements, followed by a rest element, followed by zero or more required elements.

In either layout, zero or more generic variadic elements may be present at any position in the tuple type. Errors are reported on tuple types that don't match the layout rules, but through generic type instantiation it is still possible to create invalid layouts. For this reason, tuple types are normalized following generic type instantiation:

Optional elements preceding the last required element are turned into required elements.
Elements between the first rest element and the last rest or optional element are turned into a single rest element with a union of the element types.

Some examples of normalization:
type Tup3<T extends unknown[], U extends unknown[], V extends unknown[]> = [...T, ...U, ...V];

type TN1 = Tup3<[number], string[], [number]>;  // [number, ...string[], number]
type TN2 = Tup3<[number], [string?], [boolean]>;  // [number, string | undefined, boolean]
type TN3 = Tup3<[number], string[], [boolean?]>;  // [number, (string | boolean | undefined)[]]
type TN4 = Tup3<[number], string[], boolean[]>;  // [number, (string | boolean)[]]
type TN5 = Tup3<string[], number[], boolean[]>;  // (string | number | boolean)[]

Fixes #39595.

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

All tests look clean and perf appears unaffected.

type TN2 = Tup3<[number], [string?], [boolean]>;  // [number, string | undefined, boolean]

but [] is also assignable to [string?] shouldn't it be like [number, string | undefined, boolean] | [number, boolean]?
Or am I missing something?

@typescript-bot pack this

@weswigham from your comments, it sounds like you want to loosen the restriction in place:

Tuple type layouts are now governed by these rules:

An optional element cannot precede a required element or follow a rest element.
Multiple rest elements are not permitted.

For optional elements, I tend to somewhat agree. As a user, I would expect that we might desugar
type Foo = [string, string?, number];

into something like
type Foo = [string, number] | [string, string, number];

though not the suggested
type Foo = [string, number] | [string, string | undefined, number];

How often do we leverage the distinction between optional and potentially undefined when we have the property itself?

For multiple rest elements... well, I don't have a strong-enough intuition on that one, but it would be pretty different in behavior. It would line up better with what we have in template string types.

it sounds like you want to loosen the restriction in place:

I guess so. Since you can replicate those situations in cases where we do not issue an error (eg, via variadic concatenation), I think having accurate behavior for them is important. And thus, once you have accurate behavior for those situations, there's not much of a justification in forbidding them in normal circumstances, I think.

How often do we leverage the distinction between optional and potentially undefined when we have the property itself?

Infrequently. In fact, that we don't is pretty much one of the reasons for https://github.com/microsoft/TypeScript/issues/41418 being a bug and not "intended behavior". So the inclusion of undefined in the type is potentially needed for consistency.

For multiple rest elements...

Yeah, I just reason that sequences of types in an array aren't that different from sequences of characters (or types) in a string (or template) - so the later being strictly more powerful with respect to what is preserved through concatenation operations rubs me the wrong way a bit - I feel like we've done some of the thinking on how to match up these sequences, and should probably try to do the same here, rather than quietly losing type fidelity in an unsafe way.


Correct crate category

"parsing" category is for tools for building parsers, not parsers of particular formats.

ping

@steveklabnik ping

Sorry, I haven't had a ton of time for semver lately; I'll get back to this when I do!


Examples for Video Encoding/Decoding

Hello
How are you?
Thanks for contributing this project.
I think that the content of README is poor.
Could u provide some examples for video encoding/decoding in C++?
Thanks.

Hi @rose-jinyang, please see this guide from the main jetson-inference project:   https://github.com/dusty-nv/jetson-inference/blob/dev/docs/aux-streaming.md

thanks


A bug fix, a logical error fix and some conformant issues.

Bug fix: FFI path issue that prevented use of the library on windows.
Logical fix: removed a duplicate (redundant) assingment to the APP_ROOT constant.
Conformance: moved the c-libraries to an ext folder as is recommended for gems. Also moved everything to an additional sub-folder to group all the libraries.
Sorry for doing 3 things in one commit.

thanks for this!


show path to logged data

finding the logged file is a pain, somehow make it better

aight so show each file in app and have options to share and stuff so you can email it to yourself and stuff?
should i use internal app storage or leave it as is, ?or both?

problem solved by that one commit that put all saves in a separate dir


Document Use Cases

Compile a comprehensive overview of the use cases for kc-config-cli, highlighting the updates and fixes introduced in version 6.1.5.

[ ] Review issue #1178

These are the list of tickets already documented.

Supporting multiple post.logout.redirect.uris: #800


Chatto with live data downloaded through Alamofire

Hello, I've just checked Chatto and I really like it, I set up the example app that works on hardcoded data, now I would like to use it with my production data.
As for now I have a method that fetches all previous messages when user opens my view controller. This is how it looks like:
Alamofire.request("\(serverURL)/chats/\(roomId)/messages/\(page)/10")
    .validate()
    .responseJSON { response in
        switch response.result {
        case .success:
            DispatchQueue.main.async(execute: {

                var amount = 0
                if let jsonData = response.result.value as? [[String: AnyObject]] {
                    print(jsonData)
                    amount = jsonData.count
                    for requestJSON in jsonData {

                        if let request = SingleMessage.fromJSON(JSON(requestJSON)){
                            self.messages.insert(request, at: 0)

                        }
                    }
                }
                self.collectionView?.reloadData()
                self.collectionView?.layoutIfNeeded()

            })
        case .failure(let error):
            print("SWITCH ERROR")

            print(error)
        }

}

It worked on my previous, self-coded approach to chat view.
Now, when I would like to switch to chatto, I see I need to start from populating the datasource.
I cannot find anywhere any tutorial of how to use chatto with live data, could you give me any hint about that?
Thanks!

Hi @nalogowiec, you can take a look at https://github.com/badoo/Chatto/wiki/Data-source
The main idea is that the fetching code should move from view controller to data source, where its chatItems should be populated and chatDataSourceDidUpdate should be called when appropriate.

Is there a possibility of doing lazy loading (paging) of messages while using dynamic data source? I cannot make it work...
I'm fetching data through Alamofire:
Alamofire.request("\(serverURL)/chats/messages/\(page)/30")
    .validate()
    .responseJSON { response in
        switch response.result {
        case .success:
            DispatchQueue.main.async(execute: {

                var amount = 0
                if let jsonData = response.result.value as? [[String: AnyObject]] {
                    print(jsonData)
                    amount = jsonData.count
                    for requestJSON in jsonData {
                        if let request = SingleMessage.fromJSON(JSON(requestJSON)){
                            self.messages.insert(request, at: 0)
                        }
                    }
                }
                self.dataSource = FakeDataSource(messages: self.createMessages(messages: self.messages), pageSize: 10)
                self.chatDataSource = self.dataSource
                self.canFetchChats = true

            })
        case .failure(let error):
            print("SWITCH ERROR")

            print(error)
        }

    }

And I immediately see all 30 messages instead of first 10...
The problem is that in SlidingDataSource.swift there're those lines:
public convenience init(items: [Element], pageSize: Int) {
        self.init(count: 0, pageSize: pageSize, itemGenerator: nil)
        for item in items {
            self.insertItem(item, position: .bottom)
        }
    }

and it adds 30 messages at once... I would like to add first 10, and then when user scrolls up - reach method loadPrevious() from FakeDataSource, but now there's no way for it. It only loads everything at once and never calls loadPrevious(). What am I doing wrong?

@nalogowiec I see that you load 30 messages from server, then you create data source with all of them. Try to download only 10, and then load more when user scrolls.
Another option would be to implement your own data source. You really shouldn't use FakeDataSource. It was implemented for example app. In your own data source you can display only 10 items even if it stores 30 and then increase number of messages that you show to a user when user scrolls to the top.


Raise exception for invalid s3 credentials

See refile#454

@jnicklas see if that's the way to go.
Basically we need better error messages due to typos instead of strange exceptions.
Does makes sense?

AWS credentials as options should be actually considered optional (see other pull requests like #29 #18. Recommended on EC2 is actually instance profiles. See also AWS SDK configuration.

So, maybe in that case we could create a special value like Refile::S3::NO_VALUE, I don't know.
What you suggest?
We must have better exception messages.

Doesn't AWS SDK already raise exceptions for missing configuration?

Not sure but on refile/refile#454 you will see that the error appears on refile itself, not on SDK.

Closing, if we found a better way to do that, a new pull request will be done.


Crash on continuing a run

Describe the bug
Game crashes when i continue a run started before the updated version.
To Reproduce
Steps to reproduce the behavior:

Click to continue the run

Expected behavior
When it crashes it gives an error that says clearly it's this mod. Didn't happen before the update. As of writting, haven't tested new games.
Additional context
Here is the actual error the console gives me.
java.lang.NullPointerException
at riskOfRelics.util.CounterSavers$VengCounterSaver.onLoad(CounterSavers.java:37)
at riskOfRelics.util.CounterSavers$VengCounterSaver.onLoad(CounterSavers.java:29)
at basemod.abstracts.CustomSavable.onLoadRaw(CustomSavable.java:42)
at basemod.patches.com.megacrit.cardcrawl.core.CardCrawlGame.LoadPlayerSaves.Postfix(LoadPlayerSaves.java:108)
at com.megacrit.cardcrawl.core.CardCrawlGame.loadPlayerSave(CardCrawlGame.java:1245)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:801)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:423)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)

are you playing with the artifact of vengeance enabled?


<IP_ADDRESS> not on jitpack.io

Error:Could not find com.github.afollestad.material-dialogs:core:<IP_ADDRESS>.
https://jitpack.io/#com.afollestad/material-dialogs
Last version on jitpack is <IP_ADDRESS>
Please confirm.

@PsyGik Facing the same issue.
Waiting for @afollestad  to have a look at it.

In my experience, it always takes about a day after a new release for jitpack to have it.
Check again tomorrow.

It hasn't been released yet. JitPack doesn't have delays, it pulls directly from GitHub tags.

Replaced the version in the README with w.x.y.z. You can see the current version with the JitPack.io badge in the README, as before.

https://github.com/afollestad/material-dialogs/releases/tag/<IP_ADDRESS>


⚠ Bofrost.at has degraded performance

In b5c62cb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2356 ms

Resolved: Bofrost.at performance has improved in 3150746 after 305 days, 10 hours, 15 minutes.


⚠ LPDM Handbook (hosted on Divio) has degraded performance

In fb9e2a7, LPDM Handbook (hosted on Divio) (https://repohubdev.tk) experienced degraded performance:

HTTP code: 500
Response time: 5414 ms

Resolved: LPDM Handbook (hosted on Divio) performance has improved in 7941124.


Update docs for Application Admin identity

What is being addressed

Layout of the generated documentation.
Fix path to script.

How is this addressed

Add missing | at the end of a line.
Add /devops to the script path in the example command.

/test-force-approve d2f5e0d


NavigationMeshInstance's Bake NavMesh bugs out parts of the editor GUI.

Godot version:
v3.2.3.rc6.official

OS/device including version:
Linux Mint 20 x86_64

Issue description:

Not sure how to describe this issue, but whenever I use the Bake NavMesh button, the editor seems to not show parts of the UI correctly anymore, like drop-down menu's for example.
video
As shown in the video, after clicking the button, the drop-downs do not show up anymore when you click them, not until you select another node and back again, not sure what exactly is happening here.
Steps to reproduce:

Set up a scene with colliders.
Add Navigation nodes. (Navigation, NavigationMeshInstance)
Bake NavMesh with the button as shown in the video.
Notice drop-downs no longer opening.

Minimal reproduction project:
mrp.zip

Yep, i have the same issue. I can reproduce this 100% of the time i bake a navmesh. Deselecting the node and selecting it again fixes it.

I can't recreate this issue at all with Godot 3.3.rc.over9000
@ EzraT @ mbrlabs
Can you still experience this issue on your end with recent Godot 3.3.rc9?

@smix8
I have not been able to reproduce this anymore in RC9.

Thanks for testing, closing as fixed.

It seems like this bug has re-surfaced in v3.5.beta1.official

The video has expired, what parts of the editor UI are not working exactly?
I seem to be able to reproduce it on 3.x (e17af68daa3e01460c8aa0883c9fd75d139e125b) in the Geometry drop-down properties of NavigationMeshInstance:

Do you also see it in other parts of the editor, or only there?

It seems to only affect dropdown menu's in the editor, they just don't appear for whatever reason.
After trying to click a dropdown menu, it seems like hotkeys do not work anymore either, CTRL+S for example, stops working, as if the dropdown menu is open, its just not visible it seems.

I made a new recording of the actual issue for clarity:
https://user-images.githubusercontent.com/4701338/151051622-20b72c14-22c8-4549-b8ff-8a9f6b824c0b.mp4
Interesting here the bug shows some inconsistency where the "Parsed Geometry Type" doesn't exhibit the bug (in other tests it did). Clicking main.tres to fold the subresource inspector also fails to register on the first click. Reopening it after folding fixes the bug (as re-clicking the NavigationMeshInstance or forcing a reload of the scene would).

The culprit is the progress dialog that appears as the baking operation is performed. IIRC, it updates by letting a frame pass, which seem to be tripping the inspector somewhere between updates. I've checked, and the controls in the inspector have their correct values inside of them. I've also noticed that pressing the "reset" button next to one of the properties also fixes the inspector, as do the other actions described by others above. That's a good clue that this is the case of "one missing update".
I've checked, and so did @akien-mga, and the appropriate method is called every time any nav mesh property is changed (_change_notify()). Which is why I started to think about the progress dialog. I've tried adding a fake update after all the baking and progress showing has been done, and it fixed the issue. Simply adding this to the end of the bake method helped:
	p_nav_mesh->set_parsed_geometry_type(p_nav_mesh->get_parsed_geometry_type());

So I went about it the other way, and disabled the progress dialog (there are multiple checks in place already in case the object is invalid, so I just commented out the assignment line). And that also fixed the issue. So I think the way the progress dialog goes about updating breaks updates in the inspector. Now we need to find a clean way to trigger one last update in the baking code after all the assignments have been done, because showing progress is good (can't remove it), and the fake assignment that I've used for testing is not good (duh).

Fixed by #57232.

Thanks for the quick fix!


Handle missing data property in returned object in SE functions gracefully

 Issue by marktani
Wednesday Jul 19, 2017 at 16:23 GMT
Originally opened as https://github.com/graphcool/api-bugs/issues/195

What is the current behavior?
Returning an unexpected shape in a schema extension results in an internal server error.
Please share the relevant part of your GraphQL schema and all functions, permissions or other project settings for easier reproduction
Setup a new schema extension function like this:
type MyPayload {
 success: Boolean!
}

extend type Mutation {
 myMutation(
   argument: String!
 ): MyPayload
}

and implement the function:
 return { data: { success: true } }

all is well! However, if you use this instead:
 return { data: { badField: true } }

you'll receive an internal server error.
What is the expected behavior?
Introduce a new error code + message that helps to understand the problem.

 Comment by marktani
Monday Jul 24, 2017 at 15:32 GMT

In case of a required field, the typical "null bubbling" behaviour is expected as well.

 Comment by marktani
Friday Aug 11, 2017 at 16:47 GMT

This is now fixed 💚

 Comment by marktani
Monday Aug 14, 2017 at 18:04 GMT

This still happens when data is not part of the returned object:
return { success: true }

results in an internal server error.

 Comment by kbrandwijk
Tuesday Aug 15, 2017 at 13:38 GMT

@marktani Your last comment triggered something with me. Wouldn't it make more sense if you could return your object from a function, and the system would wrap the return value automatically, or put any thrown errors in the error object?
To prevent breaking changes :wink: you might implement it like this: if top-level return value is data then return as is, otherwise wrap in data { ... }. That would keep all existing functions working as-is.

 Comment by mattfysh
Friday Aug 18, 2017 at 07:57 GMT

Agreed - event in, event out - allows you to compose, which is probably only important for request pipeline functions, but then it makes sense to make input/output consistent across all function types

 Comment by marktani
Wednesday Aug 16, 2017 at 08:50 GMT

I actually think the current API is better, as it allows for a unified experience for inline functions and webhooks. In webhooks, there's no way to control how catching errors should be handled.

 Comment by kbrandwijk
Friday Aug 18, 2017 at 09:20 GMT

It's already inconsistent for both, because you return:
{ data: { sum: 3 } }

And the query result is:
{ data: { add: { sum: 3 } } }

So it looks like the query add returned { sum: 3}, not { data: { sum: 3 } }

 Comment by mattfysh
Friday Aug 18, 2017 at 09:29 GMT

@kbrandwijk I could be wrong, but I think you may be conflating events and queries

 Comment by kbrandwijk
Friday Aug 18, 2017 at 21:39 GMT

@mattfysh What I described was the way you return a value from a SE, and how that translates into the query result. To me, that feels inconsistent. SE's follow the same format as SSS and RP for return values, but for SSS and RP that's not a problem, because those return values are not translated directly into query results, so the issue I mentioned only surfaced since the introduction of SE's.

 Comment by kbrandwijk
Friday Aug 18, 2017 at 22:04 GMT

I meant that the query response inserts the operation name between the data node and the result object.

 Comment by mattfysh
Friday Aug 18, 2017 at 21:55 GMT

If you use the TRANSFORM_PAYLOAD hook point of an RP function, that should translate directly into a query response. I think there may be some confusion still around what is a query and what is an event... perhaps it helps to express it as:
response.data[operationName] = fn(event).data
Where:

response is your JSON HTTP response
event is the type of object that is both an input and an output of a Graphcool Function (fn)
operationName is defined alongside your function name in the GraphQL function editor - it's defined either in your extend Query/Mutation code, or when you selected the event trigger e.g. User is Created / createUser

 Comment by mattfysh
Friday Aug 18, 2017 at 22:06 GMT

@kbrandwijk sure, I assume that's because the operation name is opaque to the Graphcool Function, it does not deal in operation names, or requests/responses - only events :)

 Comment by kbrandwijk
Friday Aug 18, 2017 at 22:07 GMT

@nilan What's your take on https://github.com/graphcool/api-bugs/issues/195#issuecomment-323304380?

The only reason the data property is needed as a top-level element, is that you might want to return an error instead. At the moment, you can return a field called error like so:
return { data: error: 2 }

and an error like so:
return { error: "My Error" }

With your suggestion, it wouldn't be possible to distinguish between the two cases.

@do4gr what's your state on this issue?

We now have a fix for these:

The 'badField' case will now give you an error since you are missing a required field.
The data object will now be optional if your return type is optional.

It should be deployed soon.


Multiple Definition __vector_32

I keep getting this error
Tone.cpp.o (symbol from plugin): In function `timer0_pin_port':
(.text+0x0): multiple definition of `__vector_32'
/var/folders/k4/76dlnghs21v9yfn21jz5bm8r8hwspf/T/arduino-sketch-B8F347D11FE5AC0FC6EBBAFD1BB03697/libraries/ArduboyTones/ArduboyTones.cpp.o (symbol from plugin):(.text+0x0): first defined here
collect2: error: ld returned 1 exit status
Error during build: exit status 1

System:
MacOS 10.15.7
Compiler: gcc-9
Running VSCode arduino-cli
using Mr. Blinky's Homemade Arduboy library
I've downloaded ArduboyTones multiple times and keep getting the error

It appears that you are trying to use an interrupt more than once.
@MrBlinky provides customised libraries for use with his Arduboy-homemade-package, including ArduboyTones. You should be using it in place of my "official" ArduboyTones library.
If you still have issues, I suggest you create a topic for further discussion in the Arduboy Forum. It will be easier to help you there.

Thanks @MLXXXp, unfortunately your suggestion didn't work, I'll make a forum post in the Arduboy community

The problem was due to using the Arduino tone() function along with including the ArduboyTones library. Both want to use the same timer interrupt.
https://community.arduboy.com/t/arduboy-tones-error-solved/9362


No value return

I tested this but i don't get the result.
Prints
5 USD = 0 INR

same problem, is the API down?

Yes. Yahoo API has been shut down.


Actual for Realsies Last Round of Things

Figures:

[x] Fig1 shadings: make the shade more mellow, and can use different colours and show an equation
[x] Fig1: add example that shows case in which there is no theta
[x] Fig3: Change layout of 'platonic sims', updates aesthetics (linewidth and shade colour) explore adding alpha band
[x] Check into adding the sim plot of same ratio measure, different power spectra
[x] Real data analysis: fix up the aesthetics of the correlation for the aperiodic exponent.
[x] Topographies: plot and add topographies to include all ratios, and all spectral features (power of each band and exponent)
[x] Topography correlations: make a correlation matrix plot of the correlations between ratios and features
[x] SingleParameter plots: make sure is plotting the correct bands (right now TAR & ABR plot wrong bands), and also add third row of the other band

Analyses:

[x] Explore why subjects are dropped / excluded (ex. What is the index error?)
[x] Notebooks: add in calculation & report of the correlation between age & exponent (this seems to have been dropped somewhere)
[x] In the real data correlations, average across all channels per subject before calculating correlations.
[x] Check through the real data calculations to check that there is not an issue leading to the pattern of correlations for ABR and TAR to not be quite as expected (is not a push pull between power in bands in the ratio measure).
[x] Update code to manage new path locations

Paper:

[x] Check and put numbers into the paper draft
[x] Check through for references to figures
[x] Read through and sanity check to submit

Repository Organization:

[x] Fill in the README in the dat folder

[x] Rename folder to data (?)

[x] Check & re-organize figures folder

[x] Add a README to this folder (?)

[x] Add a data statement to the main README. Link to ChildMind.

DONE!


fs_err is underused

Just bit me again, that there was a lack of information in ValdiationError in nlprule-build.
This does away with that, providing full paths for all file related io error types by using fs_err consistently.

Thanks! I wasn't aware of fs_err before #35, definitely an improvement to use this everywhere! I actually just had an issue with an underreported error in the bin targets today.
LGTM. Is this ready to merge or are you still replacing some usages?

This is good to go :+1:

One more thing:

Maybe disabling use statement reordering might be a good idea.

Why do you think that? I quite like it. Similarly I think e. g. isort in Python is also nice.


worker failed to boot

Hello,
I'm getting a "worker failed to boot" message after doing a "docker-compose up".  This is occuring both on a Mac M1 Air running Docker version 20.10.8 and on Ubuntu Linux (18.04) also running Docker version 20.10.8
py38) qt02537@MacBook-Air ~/local/repos/learn/21Q3/GH/app-search-flask-app (main) [0|0]
16:29:35$ docker-compose up
Creating network "app-search-flask-app_default" with the default driver
Building appsearchpython
[+] Building 7.3s (12/12) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 487B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 365B                                                                                0.0s
 => [internal] load metadata for docker.io/library/python:3.8-slim-buster                                                                                1.2s
 => => resolve docker.io/library/python:3.8-slim-buster@sha256:7e732593f25983fa7d4b2d54444be4a785f2397c1cf2f815d2e3638337eee012                                                                0.0s
 => => sha256:7e732593f25983fa7d4b2d54444be4a785f2397c1cf2f815d2e3638337eee012 1.86kB / 1.86kB                                                                                0.0s
 => => sha256:1d55a9981355e092edf17f540f50e411e81d1e395c78db8a4b7ced7a0ed75d63 1.37kB / 1.37kB                                                                                0.0s
 => => sha256:73fa96eb8286383c31e15c0981274d66b6a6075c339077a276c63fc742df01cb 7.68kB / 7.68kB                                                                                0.0s
 => => sha256:d10c227306ce3db344a8399cbc02bbf0dcb36519318efbde3c6027c00be8b40e 25.91MB / 25.91MB                                                                                1.5s
 => => sha256:aad96106aab0aa4d2e85bc421e45dea37832a50df28c81761db013ab47d07cf6 2.64MB / 2.64MB                                                                                1.8s
 => => sha256:cdc12f6ea53164b2605aff7aae7bf496fbbc09e66676f77af95a8c978a183d60 10.73MB / 10.73MB                                                                                1.6s
 => => sha256:77a86593011654ad7917842d3e6b216ad90db7762a5ccb00e8a764a87b7f7b81 231B / 231B                                                                                2.0s
 => => extracting sha256:d10c227306ce3db344a8399cbc02bbf0dcb36519318efbde3c6027c00be8b40e                                                                                0.8s
 => => sha256:32f90365e0f909b9014563a56532a8b3d3000068f89965fdf009968081d03123 2.64MB / 2.64MB                                                                                1.8s
 => => extracting sha256:aad96106aab0aa4d2e85bc421e45dea37832a50df28c81761db013ab47d07cf6                                                                                0.1s
 => => extracting sha256:cdc12f6ea53164b2605aff7aae7bf496fbbc09e66676f77af95a8c978a183d60                                                                                0.3s
 => => extracting sha256:77a86593011654ad7917842d3e6b216ad90db7762a5ccb00e8a764a87b7f7b81                                                                                0.0s
 => => extracting sha256:32f90365e0f909b9014563a56532a8b3d3000068f89965fdf009968081d03123                                                                                0.2s
 => [internal] load build context                                                                                0.4s
 => => transferring context: 6.76MB                                                                                0.4s
 => [2/6] ADD requirements.txt .                                                                                0.0s
 => [3/6] RUN python -m pip install -r requirements.txt                                                                                2.6s
 => [4/6] WORKDIR /app                                                                                0.0s
 => [5/6] ADD . /app                                                                                0.0s
 => [6/6] RUN useradd appuser && chown -R appuser /app                                                                                0.2s
 => exporting to image                                                                                0.1s
 => => exporting layers                                                                                0.1s
 => => writing image sha256:da27c25547bf9def885af1544b382e7a1891b32f0427fb7f52a01051e8696251                                                                                0.0s
 => => naming to docker.io/library/appsearchpython                                                                                0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
WARNING: Image for service appsearchpython was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Creating app-search-flask-app_appsearchpython_1 ... done
Attaching to app-search-flask-app_appsearchpython_1
appsearchpython_1  | [2021-09-04 20:30:59 +0000] [1] [INFO] Starting gunicorn 20.0.4
appsearchpython_1  | [2021-09-04 20:30:59 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:5000 (1)
appsearchpython_1  | [2021-09-04 20:30:59 +0000] [1] [INFO] Using worker: sync
appsearchpython_1  | [2021-09-04 20:30:59 +0000] [10] [INFO] Booting worker with pid: 10
appsearchpython_1  | [2021-09-04 20:31:00 +0000] [10] [ERROR] Exception in worker process
appsearchpython_1  |   File "<frozen importlib._bootstrap_external>", line 843, in exec_module
appsearchpython_1  |   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
appsearchpython_1  |   File "/app/main.py", line 11, in <module>
appsearchpython_1  |     client = AppSearch(
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/elastic_enterprise_search/client/_base.py", line 69, in __init__
appsearchpython_1  |     self.transport = (transport_class or Transport)(hosts, **kwargs)
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/elastic_transport/transport.py", line 182, in __init__
appsearchpython_1  |     self.set_connections(hosts)
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/elastic_transport/transport.py", line 222, in set_connections
appsearchpython_1  |     connections = list(zip(connections, hosts))
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/elastic_transport/transport.py", line 218, in _create_connection
appsearchpython_1  |     return self.connection_class(**kwargs)
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/elastic_transport/connection/http_urllib3.py", line 176, in __init__
appsearchpython_1  |     self.pool = pool_class(
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 183, in __init__
appsearchpython_1  |     ConnectionPool.__init__(self, host, port)
appsearchpython_1  |   File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 76, in __init__
**appsearchpython_1  |     raise LocationValueError("No host specified.")
appsearchpython_1  | urllib3.exceptions.LocationValueError: No host specified.
appsearchpython_1  | [2021-09-04 20:31:00 +0000] [10] [INFO] Worker exiting (pid: 10)
appsearchpython_1  | [2021-09-04 20:31:00 +0000] [1] [INFO] Shutting down: Master
appsearchpython_1  | [2021-09-04 20:31:00 +0000] [1] [INFO] Reason: Worker failed to boot.
app-search-flask-app_appsearchpython_1 exited with code 3**

Please advise.
Thanks

@ChiliDogDaddyO I just checked this, you need to spin up an enterprise search instance and give that URL in config.json for the app to boot up. Because we are initializing the AppSearch Client in main.py.
You can download that at https://www.elastic.co/downloads/enterprise-search/ and follow the installation instructions.
Alternatively, you can create an account at https://cloud.elastic.co/registration.
PS: I'll try to add enterprise search docker containers to docker-compose in this week. (you can find docker containers at https://www.docker.elastic.co/)

excellent, thank you
On Sun, Sep 5, 2021 at 9:01 AM Aravind Putrevu @.***>
wrote:

@ChiliDogDaddyO https://github.com/ChiliDogDaddyO I just checked this,
you need to spin up an enterprise search instance and give that URL in
config.json for the app to boot up. Because we are initializing the
AppSearch Client in main.py.
You can download that at
https://www.elastic.co/downloads/enterprise-search/ and follow the
installation instructions.
Alternatively, you can create an account at
https://cloud.elastic.co/registration.
PS: I'll try to add enterprise search docker containers to docker-compose
in this week. (you can find docker containers at
https://www.docker.elastic.co/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aravindputrevu/app-search-flask-app/issues/1#issuecomment-913150777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQZLV3GPRPM2E2T3RQVHTTUANSZFANCNFSM5DNUSIGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Workflows: Fix deprecation warnings

This error occurs in the build workflow. Please update all occurrences of artifact actions to v4 and check if any changes in the workflows are required. Thank you!

fixed, PR


Use JDK 8 Optional instead of shaded Optional class from Guava.

I got this error on a sample project with Flink embedded using org.apache.flink:statefun-flink-datastream:3.1.0 and org.apache.flink:flink-clients_2.12:1.14.0
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/flink/shaded/guava18/com/google/common/base/Optional
	at org.apache.flink.statefun.flink.datastream.StatefulFunctionDataStreamBuilder.build(StatefulFunctionDataStreamBuilder.java:147)
	at org.example.Main.main(Main.java:50)
Caused by: java.lang.ClassNotFoundException: org.apache.flink.shaded.guava18.com.google.common.base.Optional
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
	... 2 more

I bump flink-clients version down to org.apache.flink:flink-clients_2.12:1.13.2 and there is no error anymore.
I still think using the JDK Optional class is more straightforward and less error-prone than importing the shaded Guava class.
So this is my small PR.

I see that there are also format violations, don't worry about that I'll re-format while merging.


Can this wrapper connect to a hana db defined by a user-provided service in BTP?

This module (and the underlying hdbext and hdb) can take credentials from just about anywhere. You can even hard code them.  Now normally you load credentials using the @sap/xsenv module.  There is a help method in this module that does that - createConnectionfFromEnv.  I don't believe that the @sap/xsenv is going to use a user provided service. It's expecting a bound HDI container.  But if you had the right tags on your user-provided service it might work. That's more of question to @sap/xsenv module however.
But this module has another startup method called createConnection where you can pass the credentials in directly.  So you can always read the user-provided service yourself and pass it directly into this method.


Bug in decimal index cols

@alex-cash to fill in the details :)

When testing a 3-col index where one of the cols was a decimal data type, I noticed that the value being read was the negative of what was in the underlying table. Need to investigate if the value is being written to index entry wrong, or read wrong.

Could you add a failing test which demonstrates the issue?

Fixed by #416


table add cell border

Bug, feature request, or proposal:
feature request
What is the expected behavior?
table add cell border
What is the current behavior?
table have no cell border
What are the steps to reproduce?
Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.
Plunker starter (using on @master): https://goo.gl/DlHd6U
StackBlitz starter (using latest npm release): https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


Navigating to same route with offAllNamed causes UI updates to fail

Navigating to the same route with Get.offAllNamed(HomeView.HOME) causes UI updates to fail and textControllers.text to be empty.
example:
import 'package:flutter/material.dart';
import 'package:get/get.dart';

void main() {
  runApp(
    GetMaterialApp(
        title: "Application",
        initialRoute: HomeView.HOME,
        getPages: [
          GetPage(
            name: HomeView.HOME,
            page: () => HomeView(),
            binding: HomeBinding(),
          ),
        ]),
  );
}

class HomeBinding extends Bindings {
  @override
  void dependencies() {
    Get.lazyPut<HomeController>(
      () => HomeController(),
    );
  }
}

class HomeController extends GetxController {
  final toggle = false.obs;
}

class HomeView extends GetView<HomeController> {
  static const HOME = '/home';

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('HomeView'),
        centerTitle: true,
      ),
      body: Center(
        child: Column(children: [
          Obx(
            () => ToggleButtons(
              children: <Widget>[
                Container(
                  child: Text(
                    'HELLO',
                  ),
                ),
                Container(
                  child: Text(
                    'BYE',
                  ),
                ),
              ],
              onPressed: (int index) {
                print("Toggle pressed $index");
                if (index == 0) {
                  controller.toggle.value = false;
                } else {
                  controller.toggle.value = true;
                }
              },
              isSelected: [!controller.toggle.value, controller.toggle.value],
            ),
          ),
          FlatButton(
            child: Text(
              'TO HOME',
              style: TextStyle(fontSize: 20),
            ),
            onPressed: () {
              Get.offAllNamed(HomeView.HOME);
            },
          ),
        ]),
      ),
    );
  }
}

Steps to reproduce the behavior

Once the app is ran, Toggling between Hello and Bye works fine
Click on "TO HOME" button
Future toggles do not update UI

Expected behavior
Navigating to same route with offAllNamed should not destroy and re-create Controller.
Flutter Version:
1.22.0
Getx Version:
3.13.2
Describe on which device you found the bug:
Emulator Pixel_3a_API_30 & Xiaomi K20 Pro

Instead of using Get.offAll, You can try this Get.offNamedUntil(HomeView.HOME, (route) => Get.currentRoute == HomeView.HOME);

Instead of using Get.offAll, You can try this Get.until((route) => Get.currentRoute == HomeView.HOME);

that does'nt make sense. He want to pop the current route and replace with an equal one, use get.until. get.offnamed or get.offallnamed won't make any difference
Unfortunaly I tested and indeed it stops working.
What happens:

when is opened, it works normally,
when you open another route erasing the current, it will dispose the controller, but it won't start the controller again
if you press some button in screen, only then the controller is initialized again, but it doesn't work

Instead of using Get.offAll, You can try this Get.until((route) => Get.currentRoute == HomeView.HOME);

that does'nt make sense. He want to pop the current route and replace with an equal one, use get.until. get.offnamed or get.offallnamed won't make any difference
Unfortunaly I tested and indeed it stops working.
What happens:

when is opened, it works normally,
when you open another route erasing the current, it will dispose the controller, but it won't start the controller again
if you press some button in screen, only then the controller is initialized again, but it doesn't work

That's true, I wanted to help with a quick fix: Which is, not closing the HomeController in the first place.
After running the code now, I can confirm the issue too.

It seems the new view is being rendered before the old Controller is closed.

Instead of using Get.offAll, You can try this Get.until((route) => Get.currentRoute == HomeView.HOME);

that does'nt make sense. He want to pop the current route and replace with an equal one, use get.until. get.offnamed or get.offallnamed won't make any difference
Unfortunaly I tested and indeed it stops working.
What happens:

when is opened, it works normally,
when you open another route erasing the current, it will dispose the controller, but it won't start the controller again
if you press some button in screen, only then the controller is initialized again, but it doesn't work

That's true, I wanted to help with a quick fix: Which is, not closing the HomeController in the first place.
After running the code now, I can confirm the issue too.

It seems the new view is being rendered before the old Controller is closed.

You're right.
In Flutter the layout of a page happens after the build of the second page.
And in this case, navigating to the same route will make the dispose happen and a new instance will not be created, because  the dispose occured after build

I'm thinking of creating an Id for the routes based on their first hashcode (Since Routes are builders, they lose the hashcode with the update of a superior widget, changing the theme, for example would affect this behavior if I based on the provided hashcode by dart, so I won't do that).
So I will store the first hashcode locally in the constructor, and use it as a fingerprint for the creation and removal of dependencies linked to the routes, so the creation and removal of dependencies will not be hostage to the route name, which can present problems like this .
I think this was a good issue, it gave me clarity on how to improve the system of self injection and dispose of dependencies.

Thanks for looking into this.
For now I'm making a check within my navigation logic to make sure this doesn't happen.
if (Get.currentRoute != Routes.HOME) Get.offAllNamed(Routes.HOME);

Hi. Just to add to this, because I've done exactly that in my app: don't navigate if you're on the current page.
And it works. But it still fails if the user navigates to a page, from the top level page (in which case the current route is no longer home) and instead of pressing back on the second page, they click a link in the navigation bar to go to the Home page.
In that case we still get the original issue.
Long story short, we still need a change within "GetX" along the lines of what @jonataslaw has described.
Thanks again for all your hard work.
You're doing an amazing job with this library.

I can't reproduce on last version, so I'm closing this issue.
If you can reproduce, please reopen the issue or open a new one. Thanks


Added new game

fixes#3982

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Thank you @codewithishu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit please recheck it I have already made readme.md file

@kunjgit review it

Thank you  @codewithishu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


myMLAppML.Model is not compatible with netcoreapp2.1

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/consume
Operating System: windows
The exact error I am getting is:
Project mMLApp.ML.Model is not compatible with netcoreapp2.1 (.NETCoreApp,Version=v2.1). Project myMLAppML.Model supports: netstandard2.1 (.NETStandard,Version=v2.1)
I am not really sure what went wrong, as I created this projected exactly as the tutorial said to do, yet somehow I ended up not being able to run this.

.NET Standard 2.1 requires .NET Core 3.0. In order to use it with .NET Core 2.1, you should check whether you can downgrade the myMLAppML.Model project to .NET Standard 2.0

I have solved this issue:

Downloaded and install the required SDK
VS: Tools->Tools -> Options -> Projects and Solutions -> .NET Core
unchecked the Use Preview ....
Optional yet one:  Build Debug/Release x64 (no Any CPU)

Model Builder targets .NET Standard 2.1 requires .NET Core 3.0. @natke can we please update our docs to list this as a minimum requirement.

Sure. Is this where we should add it? https://docs.microsoft.com/en-us/dotnet/machine-learning/how-to-guides/install-model-builder#pre-requisites
What is the actual pre-requisite? @rustd

Yes.
Pre-req: "Model Builder targets .NET Standard 2.1 which requires .NET Core 3.0."


About the ten single-step denoising of the style reference image during the denoising process

Thank you for your contribution! I have some questions about the code details and look forward to your answers! 1. Is the DDPM encoding mentioned in the article actually the process of adding noise to the image? 2. From line 825 to line 868 in gaussian_diffusion.py, the style reference image seems to have undergone 10 single-step denoising processes after noise addition, and each denoising process is reversed using the DDPM noise addition formula. What is the significance of this?
We look forward to your reply. Thank you again!

Sorry, I forgot another question. Is 636 a tag for a bag? Thank You！

Thank you for your attention 1.Yes, "encoding" refers to the noise addition process at the image level. 2.In this function, we need to start denoising from the noised style image to generate the target image. Here, the initial 10 single-step denoising steps come from the improved diffusion setting, which can reduce the randomness of the denoising process. We have retained the same settings as IDDPM（https://github.com/openai/improved-diffusion）3.Yes, 636 comes from the category labels of ImageNet, used for conditional generation in IDDPM.

Thank you for your attention 1.Yes, "encoding" refers to the noise addition process at the image level. 2.In this function, we need to start denoising from the noised style image to generate the target image. Here, the initial 10 single-step denoising steps come from the improved diffusion setting, which can reduce the randomness of the denoising process. We have retained the same settings as IDDPM（https://github.com/openai/improved-diffusion）3.Yes, 636 comes from the category labels of ImageNet, used for conditional generation in IDDPM.

Thank you very much, this has been a great help to me. Wishing you all the best in your future work!


chore(main): release 1.20.0

:robot: I have created a release beep boop
1.20.0 (2023-03-17)
Features

token: change npm token to use classic automation token type (8ad2b32)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/briancaffey/pulumi-aws-django/releases/tag/v1.20.0 :sunflower:


[CI][Docker] Bump ONNX version to 1.6

This is a prerequisite for #4536
cc @tqchen @jwfromm

Have you managed to get onnx.checker.check_model to work with ONNX 1.6? Whenever I've tried updating I encounter frequent segmentation faults. This is a known bug with 1.6 as seen in this Onnx issue. Assuming it still is around, we either have to drop use of the model checker (which is probably fine since it's not essential) or wait until they fix it in 1.7. If you want to go with the former, you should include the removal of the checker with this PR.

With ONNX v1.6, I do get segfault when importing both ONNX and PyTorch (seems to be the same issue as this one). If I remove PyTorch import, my test case in #4536, which uses onnxruntime (which in tern calls check_model) works fine. The following works for me too.
import resnet
model = onnx.load("resnet50.onnx")
onnx.checker.check_model(model)

Doesn't the CI = green mean we are good to go wiht v1.6? Assuming the CI is running on v1.6 with the in this PR.

The CI is not directly updated when the docker get updated, see https://docs.tvm.ai/contribute/pull_request.html#ci-environment . Would be great if we can have tests to confirm things, i will also followup later this week.

Running tests/python/frontend/onnx/test_forward.py with the new CI should confirm whether ONNX v1.6 is in good state. Based on the discussion so far, it seems likely to crash.

I will suggest we wait until onnxrt 1.7 then as per suggested by @jwfromm @masahi shall we close for now?

Ok, no problem for me.

I've tested on an environment with ONNX 1.6 + PyTorch master build, I can run onnx/test_forward.py without any issue. I recommend updating our CI env to PyTorch 1.4 (which should be out soon) along with ONNX 1.7.


Add @polymerBehavior annotation to DatePickerBehaviorImpl

This is required to enable Hydrolysis for the behavior contents.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Added linear search implementation in Python

Hey @singhpratyush , it would be great if you can add an entry for linear search in the README, in the "Implemented Algorithms" section.
Eg >

Linear Search (Python)

Yes, would be better that way.

I have added it to README and synced with main branch.


Suppress errors when submitting feedback

Reviewer:

Description:
There is an issue with the feedback backend, meaning it reports an error, even though the feedback is successfully submitted. This fixes the client side by reporting that feedback was successfully submitted even if there was an error with the request.
https://app.asana.com/0/276630244458377/1200216229834078/f
Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

👍