Should we allow multiple values for the same tag key

Splitting into a separate issue the discussion about set_tag vs. add_tag, started on #14 and in https://github.com/opentracing/api-python/commit/15d3009d7eb646f46e565f4487189684e5168cc6#commitcomment-15357389
@slimsag @bensigelman @adriancole

I will have a chat with different users tomorrow to see if they have any concrete use cases for multi-valued tags. If they do not, I'd be ok to restrict the API to set_tag for now, with the explicit disclaimer that if the user calls set_tag multiple times for the same key, the behavior of the tracer is undefined, i.e. it is implementation specific whether the tracer will retail the first value, or the last value, or pick one randomly, or even keep all of them.

All sgtm. Thank you!
On Sunday, January 10, 2016, Yuri Shkuro<EMAIL_ADDRESS>wrote:

I will have a chat with different users tomorrow to see if they have any
concrete use cases for multi-valued tags. If they do not, I'd be ok to
restrict the API to set_tag for now, with the explicit disclaimer that if
the user calls set_tag multiple times for the same key, the behavior of the
tracer is undefined, i.e. it is implementation specific whether the tracer
will retail the first value, or the last value, or pick one randomly, or
even keep all of them.
—
Reply to this email directly or view it on GitHub
https://github.com/opentracing/opentracing.github.io/issues/16#issuecomment-170410793
.

--
Sent via mobile

I'm primarily in favor of setTag vs addTag. I find the latter more expensive to support, and will lead to more complex documentation, data structures and backends. SetTag is more accessible.
Implementation impact for addTag(String,String)
If we add this to the api, there are a few things that will happen. We will need to document and adjust tests knowing this feature won't be widely supported (ex in google cloud trace, htrace, and probably others). Representations must be more complex, as they now have to use a structure more complicated than String->String. For example, it now would need to be a List of 2 or 3 tuples depending on whether or not order is preserved. Moreover, querying and indexing will need to operate against such a structure. For example, querying for a key within json is no longer an equals comparison with an association. Rather it is a search among keys. Eventhough some systems like zipkin currently support storing this sort of structure (eg its raw span), it has led to numerous bugs and complaints. The complexity and implementation burden of zipkin is a primary reason why it is so slow moving, and so I can't in good faith advocate for something like addTags with the experience I have.
Motivation for addTag(String,String)
In discussion, the primary use case for this feature was multiple parents, which is hard to argue as being a "tag" because parents or other trace identifier metadata is not a user-concern, rather a propagation one. If we wanted to support multiple parents, this would be an issue about trace/propagation attribute, not tag, which would be far less surface area and less concerning.
For example, I would be surprised if "joe developer" would be interacting with trace identifiers as often as they do tags, so supporting multiple parents should really be a trace/parent attribute discussion.
In attempts to not refine my selection bias, I've taken time to call out tracing systems that are in each (or in the case of zipkin both) camps. I've cc'd folks who seem to know background, so maybe they can contribute use cases for multiple values or why they accept only single value.
setTag(key,value) and systems that support it
A user's expectation of setTag(key,value) would be that by the time it comes back to the system, they receive the last association back.
ex. setTag("foo", "bar"), setTag("foo", "baz"), setTag("foo", "bar") would be "foo" -> "bar"
Htrace
htrace v4 key value mappings are single-value cc @cmccabe
Cassandra
cassandra trace parameters are single-value cc @michaelsembwever
Google Cloud Trace
google cloud trace v1 labels are String -> String mappings. cc @bogdandrutu
grpc Census Tracing
grpc census tracing tag sets indicate a new value replaces an existing one cc @a-veitch
Spring Cloud Sleuth
spring-cloud-sleuth v1 annotations are String -> String mappings. cc @dsyer
Zipkin v1
Eventhough Zipkin v1's Binary annotation can store this multiple associations the query api, tests and some backends assume there's only one value per key. All instrumentation libraries I've seen log only a single value with a key per span. This has led to calls for simplification in Zipkin v2. cc @jcarres-mdsol
addTag(key,value) and systems that support it
A user's expectation of addTag(key,value) would be that by the time it comes back to the system, they receive all associations, and I am quite sure some will want them in order, and perhaps even deduped.
ex. addTag("foo", "bar"), addTag("foo", "baz"), addTag("foo", "bar") would be "foo" -> ["bar", "baz", "bar"] or something similar depending on what a user might think.
AppDash
appdash annotations are not atomic. For example a log message is a combination of a key for the message and another key for the timestamp. As such, the data structure underneath must support repetition. Given that OpenTracing has a log message, it is unclear to me which use cases, if any, of appdash require addTag vs setTag in the OpenTracing api cc @slimsag
AppNeta v2
appneta supports add tags and its data structures include metadata including the timestamp. I don't know if users use this feature primarily for history or as a multimap cc @dankosaur
Pinpoint
pinpoint spans include a list of annotations which have key/value mappings. These can repeat. cc @Xylus
Zipkin v1
Zipkin v1's Binary annotation can store this multiple associations (lossy on order). See notes on setTag above about practicalities.

I will have a chat with different users tomorrow to see if they have any
concrete use cases for multi-valued tags. If they do not, I'd be ok to
restrict the API to set_tag for now, with the explicit disclaimer that if
the user calls set_tag multiple times for the same key, the behavior of the
tracer is undefined, i.e. it is implementation specific whether the tracer
will retail the first value, or the last value, or pick one randomly, or
even keep all of them.

While I'd prefer that tracers are consistent on this, I concede backends
won't be. I'm happy that we settle with set_tag, as I'd prefer the
disclaimer to be in this direction vs the other way around.

There was an aside, where @yurishkuro compares a decision here vs stackoverflow multiple tags.
The word "tag" is commonly associated with a single string. Ex stackoverflow expects an array of strings in their request object. In apis like EC2, they support tag concept above, by simply providing a key with an empty value.

fwiw the predominant reason I've not raised objection to the word "tag" was EC2's use of the term. Since EC2 uses it, I can relate to people by saying "this is like EC2 tags, not SO tags". Otherwise, I would have objected bc when I think tag, I think a single string, not an association.

I would strongly encourage to use set_tag. Here are some of the reasons:

We want to always propagate this values with the context (supporting multi-values will add complexity and overhead).
As adriancole@ suggested tag is a single string and we explicitly picked this name because of this.
Keeping it consistent with other implementations (like EC2 is a nice thing).
grpc + google will be consistent with this.

Few things to remember and how I see the difference between tag and annotation (Remember Rodrigo's paper):

Tag: String -> String
Annotation: Timestamp -> String
Tag is propagated with the context;
Annotation is a one time event (it is not getting propagated).

I haven't seen a case in HTrace where we wanted multiple values for a
specific tag before (although perhaps one will come up in the future?)
Anyway, it seems like people who want multiple values for an individual
tag can always use a comma-separated list, or some other user-defined
mechanism for doing that, given that tags are strings.
best,
Colin
On Mon, Jan 11, 2016 at 7:16 AM, Bogdan Drutu<EMAIL_ADDRESS>wrote:

I would strongly encourage to use set_tag. Here are some of the reasons:

We want to always propagate this values with the context (supporting
multi-values will add complexity and overhead).
As adriancole@ suggested tag is a single string and we explicitly
picked this name because of this.
Keeping it consistent with other implementations (like EC2 is a nice
thing).
grpc + google will be consistent with this.

Few things to remember and how I see the difference between tag and
annotation (Remember Rodrigo's paper):

Tag: String -> String
Annotation: Timestamp -> String
Tag is propagated with the context;
Annotation is a one time event (it is not getting propagated).

—
Reply to this email directly or view it on GitHub
https://github.com/opentracing/opentracing.github.io/issues/16#issuecomment-170584034
.

@bensigelman @adriancole I got a "No" answer from users.
@slimsag are you ok with converging on set_tag for now?  The disclaimer in the method will be:

if the user calls set_tag multiple times for the same key, the behavior of the tracer is undefined, i.e. it is implementation specific whether the tracer will retain the first value, or the last value, or pick one randomly, or even keep all of them.

If all agree I'll do a PR for api-python and publish a new release.

(Thanks for polling people at Uber, Yuri... all SGTM if @slimsag is ok with it.)

SGTM

The only case where TraceView takes advantage of multiple key addition is for multiple Edge values (i.e. multiple parents).  We haven't found any other interesting use-cases for multiple keys.  If metadata like edges to other spans/events is handled separately, that allows for a separate discussion on multiple edges.

I'm thankful for folks speaking up about this. I learned a lot.

+1 -- Dan, very helpful notes!
On Tue, Jan 12, 2016 at 6:45 AM, Adrian Cole<EMAIL_ADDRESS>wrote:

I'm thankful for folks speaking up about this. I learned a lot.
—
Reply to this email directly or view it on GitHub
https://github.com/opentracing/opentracing.github.io/issues/16#issuecomment-170934507
.

Python changes have been made in https://github.com/opentracing/api-python/pull/6
Thanks to everyone who provided their perspective, it was very useful. I am going to close this.


Unintuitive Boolean Operation Results with Stacked Geometries

Description
When performing a boolean 'not' operation on stacked geometries, the results can be unintuitive. Specifically, when creating three polygons around the origin and then adding two circles for subtraction, the boolean 'not' operation does not produce the expected result.
Reproduce
import gdsfactory as gf
c1 = gf.Component()
rec1 = c1 << gf.components.rectangle((10, 100), layer=(1, 0))
rec2 = c1 << gf.components.rectangle((100, 10), layer=(1, 0))
points = [
    (0, 0),
    (0.7*10, 0),
    (100,100-0.7*10),
    (100, 100),
    (100-0.7*10, 100),
    (0, 0.7*10),
]
rec3 = c1.add_polygon(points=points, layer=(1, 0))
c1

Add two circles for later subtraction:
c2 = gf.Component()
circle1 = c2 << gf.components.circle(radius=10/3, layer=(2, 0))
circle2 = c2 << gf.components.circle(radius=10/3, layer=(2, 0))
circle2.dmove((100,100))
c1.add_ref(c2)
c1

Apply the boolean 'not' operation:
c3 = gf.Component()
c3 << gf.boolean(c1,c1,layer1=(1,0),layer2=(2,0),operation='not',layer=(1,0))
c3

Observed Behavior

After performing the 'not' operation, the bottom left (origin point) remains covered by layer (1, 0).
Two polygons are generated as a result, one of them is exactly what we want, and the other one is unwanted.

Expected Behavior
In Klayout, performing the subtraction (layer 1 - layer 2) results in a single polygon in layer 1, which is more intuitive:

Proposed Solution

Consider applying a boolean 'or' operation to all structures in layers A and B before performing the 'not' operation.
This would ensure a more intuitive result where no remnants are left in the subtracted region.

Sounds good, can you send a Pull Request for this?

Hi @joamatab,
I added a pull request #3007, please check it.

Thank you Dassein,
fixed by https://github.com/gdsfactory/gdsfactory/pull/3013


sh scripts/test.sh

'sh' is not recognized as an internal or external command, operable program or batch file.
Solution?

This is probably the wrong repo. We don't have a scripts/test.sh file in this repo.


New command New-BicepConfigJson to create bicepconfig.json file

Describe the solution you'd like
I want a command that creates the bicepconfig.json file to customize the behavior of the linter.
You should be able to do something like this:
# Create a bicepconfig.json file setting all rules to warning
New-BicepConfigJson -Level Warning

This should create a bicepconfig.json in the current directory that looks like this:
{
  "analyzers": {
    "core": {
      "rules": {
        "no-hardcoded-env-urls": {
          "level": "warning"
        },
        "no-unused-params": {
          "level": "warning"
        },
        "no-unused-vars": {
          "level": "warning"
        },
        "prefer-interpolation": {
          "level": "warning"
        },
        "secure-parameter-default": {
          "level": "warning"
        },
        "simplify-interpolation": {
          "level": "warning"
        }
      }
    }
  }
}

Or:
# Create a bicepconfig.json file setting all rules set to error and store it in C:\myBiceps folder.
New-BicepConfigJson -Level Error -OutputDirectory 'C:\myBiceps\'

This should create a bicepconfig.json in the C:\myBiceps\ directory that looks like this:
{
  "analyzers": {
    "core": {
      "rules": {
        "no-hardcoded-env-urls": {
          "level": "error"
        },
        "no-unused-params": {
          "level": "error"
        },
        "no-unused-vars": {
          "level": "error"
        },
        "prefer-interpolation": {
          "level": "error"
        },
        "secure-parameter-default": {
          "level": "error"
        },
        "simplify-interpolation": {
          "level": "error"
        }
      }
    }
  }
}

Additional context
https://github.com/Azure/bicep/blob/main/docs/linter.md
https://github.com/Azure/bicep/blob/main/src/Bicep.Core/Configuration/bicepconfig.json
https://github.com/Azure/bicep/blob/main/docs/examples/bicepconfig.json

There seems to be a namespace in Bicep.Core that maintains and contains all rules that you can set in bicepconfig.json.
I am far from good in c#, but this might be usable to build a dynamic configuration based on what settings are currently supported?  Someone with better skills than me - feel free to chime in!

I have managed to get a working version for review here,
however there are some things that I would like some feedback and help with:

Currently it is hardcoded to add three levels of the resulting hashtables. while this is ok for now as there is always three levels of the configuration I would like to refactor this to a more dynamic solution, but my vacation brain cant figure out how to do this.
The classes are currently hardcoded for bicep.dll, and should be rewritten to use the wrapped DLLs in 2.0
Currently the command returns a json that can be piped to out-file, should we default to output a file, and have -AsJson as a switch instead? opinions?

I've done some testing now and it looks good overall. I ran New-BicepConfigJson -Level Info | Out-File .\bicepconfig.json. And the bicepconfig.json file was valid and worked with Build-Bicep.
Using the latest version of the Bicep VS Code extension I do get some squigglies though.
Two new properties are now expected in the bicepconfig.json. We should set them to the default values below:
"verbose": false,
"enabled": true,

And we should add parameters to set these values to true or false when creating the bicepconfig.json file.
It also appears that the value for the level property is expected to be lower case by the VS Code extension. But it looks like you are loading the allowed diagnostics levels from Bicep.Core.

I want to make sure that we output a file when the command is used and store it in the working directory with the option to change output directory. And of course verify if a bicepconfig.json is present and don't overwrite it.

BicepNet will also need to start using a bicepconfig.json file. Not the analyzers section, but the cloud part for URLs. We may want to decide the location of this file if the module will keep a copy, and ensure that both parts of the module handle the file well if so :)

You get a lot of help from the VSCode extension to create this file today. It provides intellisense for the user. Might not need this.

Closing this issue. It will be possible to create bicepconfig.json file with a click in VSCode. https://github.com/Azure/bicep/pull/6187


About the class reweighting method

Hi, I noticed that in the Table 2 of the paper of

The Mapillary Vistas Dataset for Semantic Understanding of Street Scenes

It mentions that with class reweighting, we can get about 1.3 points improvements. Could you show me how do to compute your class-aware weights?
I have tried other similar strategy but only get about 0.5 improvements.

@PkuRainBow you should ask the authors of PSPNet, since we are just reporting the results that they obtained on the LSUN'17 segmentation challenge.


merge-admin-lte functionality

from https://github.com/distributev/ng-admin-lte repository
including Customers and Transactions
I remember I said to leave Customers / Transactions out but I need menu.js functionality from that repository and I forgot Customers and Transactions are supposed to test that menu.js works fine.
The final result should contain only our own functionality and not any "dummy" feature (thing) from angular-fullstack

i will do this. will update here once done

pushed to master. please verify


Update pusher/pusher-php-server versions

Hi there,
This PR updates the versions for pusher-php-server to match the master branch. In Laravel 9 I believe you need to use version ^7.0.

Codecov Report

Merging #955 (6668117) into 1.x (345d57f) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x     #955      +/-   ##
============================================
- Coverage     53.93%   53.49%   -0.45%
  Complexity      283      283
============================================
  Files            50       50
  Lines           927      901      -26
============================================
- Hits            500      482      -18
+ Misses          427      419       -8

Impacted Files
Coverage Δ

src/WebSocketsServiceProvider.php
94.59% <0.00%> (-0.86%)
:arrow_down:

src/Console/CleanStatistics.php
91.66% <0.00%> (-0.65%)
:arrow_down:

src/HttpApi/Controllers/Controller.php
67.85% <0.00%> (-0.57%)
:arrow_down:

src/Apps/ConfigAppProvider.php
94.44% <0.00%> (-0.56%)
:arrow_down:

...s/Channels/ChannelManagers/ArrayChannelManager.php
96.77% <0.00%> (-0.20%)
:arrow_down:

src/Server/Router.php
0.00% <0.00%> (ø)

src/HttpApi/Controllers/FetchUsersController.php
100.00% <0.00%> (ø)

...rc/HttpApi/Controllers/FetchChannelsController.php
100.00% <0.00%> (ø)

...hboard/Http/Controllers/DashboardApiController.php
0.00% <0.00%> (ø)

src/Console/StartWebSocketServer.php
3.89% <0.00%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345d57f...6668117. Read the comment docs.

Needs others changes
#895
#830
#908

for laravel 9.x maybe try composer require "beyondcode/laravel-websockets:dev-master"

@PaolaRuby Thanks! I've implemented those fixes for tests as applicable to the 1.x branch & added support for GuzzleHttp/Psr7 ^2.0 – Composer no longer downgrades that dependency and everything seems to be in working order.

GuzzleHttp/Psr7 must be 1.7|2.0, 1.5,1.6 are incompatible witn 2.0

@erikn69 fixed!

Thank you!


client should be the first argument on all public functions

This PR changes the signature of all public facing functions of the Tentacat API.
Client should always be the first argument passed to the functions. Some functions had it this way, others had it at the end, others bang in the middle. This PR addresses this issue and makes everything consistent.
Having client be the first argument everywhere allows us to do
%{access_token: token}
|> Tentacat.Client.new()
|> Tentacat.Contents.find_in("AlloyCI", "alloy_ci", ".alloy-ci.json", "long_sha")
|> elem(1)
|> parse_config()

everywhere.
Using pipes to process the information returned by the API makes it feel more natural, and I think it fits better with Elixir this way.
Also, code formatting.

Coverage decreased (-0.3%) to 91.007% when pulling 90d4c08d57cc9ee5fd22a74c083f6d03243cf580 on AlloyCI:master into 0f77f885c2c96202ad0d56c5b92fb9e874800db6 on edgurgel:master.

I agree it should be consistent! And it should always be optional IMHO.
The reasons why client is not the first argument:

It's optional as you can access most of GitHubs API without a token
Elixir's first arguments are related to the module. So if you want a User, the username should be first argument. For example Enum receives an enumerable, String a string, etc

user_name |> Tentacat.Users.find

Does this make sense? I'm keen to hear more about other users if they find it confusing also. Maybe following Elixir's convention is not a good idea for Tentacat?

Thanks for the reply @edgurgel
In the cases where the client is optional, you can leave it empty, and it will still work:
 Tentacat.Users.find("supernova32")
"supernova32" |> Tentacat.Users.find()

Both examples I mentioned above work with the new code. The fact that almost all functions inside Tentacat define a @spec allows the compiler to pass the String where it belongs. In the case of Users.find that would be the second argument.
It works perfectly fine as well when there are more than 2 arguments;
Tentacat.Pulls.list("edgurgel", "tentacat")

Is perfectly valid under the new code. Please give it a try 😄
I didn't change the optionality of the client argument (well, only in a couple of places where the API would definitely require an authenticated user), so everything should work as it should, with the added bonus that the client now comes first 👍

I'll haven't viewed the implementation (on holidays) but I like the idea -
a consistent API will make many things easier to implement (the author
gives one example, but I am sure there are many).
There is also the question of the public  methods where no authentication
is required - In their case, rate limiting still applies.
I suggest it would be good practice to always initialise with a user
structure, even if it is empty: one can always revisit the initialisation
site at a later time and add the credentials if needed.
On Wed, 11 Apr 2018, 23:33 Eduardo Gurgel<EMAIL_ADDRESS>wrote:

I agree it should be consistent! And it should always be optional IMHO.
The reasons why client is not the first argument:

It's optional as you can access most of GitHubs API without a token
Elixir's first arguments are related to the module. So if you want a
User, the username should be first argument. For example Enum receives
an enumerable, String a string, etc

user_name |> Tentacat.Users.find
Does this make sense? I'm keen to hear more about other users if they find
it confusing also. Maybe following Elixir's convention is not a good idea
for Tentacat?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/edgurgel/tentacat/pull/143#issuecomment-380616912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aego9h4TVX971pXJb5ItXEZMOO-_l-x-ks5tnoSngaJpZM4TQxPt
.

@outofambit there is nothing preventing you from not piping the client. You can still instantiate your client first (or pass it as an argument to another function, like in your example) and then use it as the first argument in all your Tentacat calls. You can even use the client variable in a pipe for multiple calls like so:
client = Tentacat.Client.new(%{access_token: token})

client |> Tentacat.Pulls.list("edgurgel", "tentacat")

client |> Tentacat.Contents.find_in("AlloyCI", "alloy_ci", ".alloy-ci.json", "master")

The main point of the PR is not to enforce passing the client in a pipe. It is to bring conciseness to Tentacat's API. Having the client always be the first argument will avoid a lot of confusion, specially for calls like (owner, repo, client, options, params). I need to always look up the function signature before calling it, because I have no idea in which place the client should go. Why?
Being able to do it with a pipe is just icing on the cake.

@supernova32 ah I see what you're saying. I totally agree we should standardize it and I like the argument for putting it first! I actually think piping the client like client |> Tentacat.Pulls.list("edgurgel", "tentacat")  makes the API call itself easier to read!

@edgurgel any chance we can get this merged? the consensus seems to be that these changes are helpful.

@supernova32 I will play with your branch this weekend and see how it goes! Thanks for the PR

Both examples I mentioned above work with the new code. The fact that almost all functions inside Tentacat define a @spec allows the compiler to pass the String where it belongs. In the case of Users.find that would be the second argument.

Are you sure? AFAIK @spec is not used by the compiler directly, but for dialyzer
I think it's working just because that specific function (find) has an optional Client as the second argument:
  def find(client \\ %Client{}, user) do

We need to update the README (possibly pointing that this is the way to interact from now on etc?).
I will bump the version to 1.0.0 and consider this the stable version.


Single Progress Value

Great module! It would be perfect for our needs if it output a single % value for the process when uploading from a remote source, that way we could show a progress bar on the frontend. Failing that if we got the bytes read value and knew which part the value related to we could work it out for ourselves.

Okay i'll look into this later today.


Update setup-postman-environment.md

Setting myself as the topic owner

@phecke
I've just set myself as the topic owner.


find Nearest Uv Point From 3D space point

public class E3Model

Hi @manuelddahmen, I'm not sure to understand your issue 😅

I'm sorry @vinceglb . I wanted to put this issue in my repository.

No problem 👌


[WFLY-13737]Upgrade wildfly-transaction-client from 1.1.11.Final to 1…

possible fix for
https://issues.redhat.com/browse/WFLY-13737

Hello, Amitninja12345. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

Thanks @Amitninja12345 -- this has been upgraded via #13455


RHELPLAN-56584 - sync collections related changes from template to nbde_client role

Adding .travis/runcollection.sh.
Enabling collection as part of tox/travis tests.
Fixing a black error in library/nbde_client_clevis.py.

Thank you, @richm. Merged.


Fix Hang on Drop HiddenWindow on Windows

As mentioned in #194 , dropping Device hangs on Windows because the HiddenWindow waits for a close message that never enters the queue.
Easiest fix is to replace SendMessage with PostMessage in the drop for HiddenWindow. This queues the message and returns immediately. Since we wait for the thread to finish after sending the close message, there should not be any problems using this method compared to SendMessage.
Fixes #194

@bors-servo r+
Thanks for fixing this! Sorry for the delay in reviewing it.

:pushpin: Commit 1607ce0 has been approved by jdm

:hourglass: Testing commit 1607ce00a31121b2ea13df8c55af221cd5e780a4 with merge 881df3172dda3863d17908c1b10f687dbd566a7c...

:broken_heart: Test failed - checks-travis

Bleah, https://github.com/rust-lang/rust/issues/79203 means our CI can't merge anything until it's fixed. I'm going to pin the nightly build to a working version.

@bors-servo retry

:hourglass: Testing commit 1607ce00a31121b2ea13df8c55af221cd5e780a4 with merge 889a16ddc271572bd39c0f46940a3c3b91993b69...

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing 889a16ddc271572bd39c0f46940a3c3b91993b69 to master...


genType not using custom shim

I may be doing this wrong, but can't get genType to use my shim for Dayjs.
In the file that uses Dayjs:
[@genType]
type dayjs_t;

<EMAIL_ADDRESS>("dayjs", "default")]<EMAIL_ADDRESS>"./StatusMessages.gen"]
external dayjs: string => dayjs_t = "dayjs";

[@genType] <EMAIL_ADDRESS>external format: (dayjs_t, string) => string = "format";

bsconfig.json
"shims": {
...
      "Dayjs": "Dayjs",
...
    },

Dayjs.shim.ts
// tslint:disable-next-line:max-classes-per-file
export abstract class Dayjs {
  protected opaque!: any
}

Error
Type error: Type 'typeof dayjs' is not assignable to type '(_1: string) => dayjs_t'.
  Property 'opaque' is missing in type 'Dayjs' but required in type 'dayjs_t'.  TS2322

    4 |
    5 | // In case of type error, check the type of 'dayjs' in 'StatusMessages.re' and 'dayjs'.
  > 6 | export const dayjsTypeChecked: (_1:string) => dayjs_t = dayjsNotChecked;
      |              ^
    7 |
    8 | // Export 'dayjs' early to allow circular import from the '.bs.js' file.
    9 | export const dayjs: unknown = dayjsTypeChecked as (_1:string) => dayjs_t;

@loganfromlogan shims are used to export types to JS when the Reason source code is not available, so annotations cannot be added. So e.g. for the standard library.
What would you like to do in your example?

Thanks for jumping in here @cristianoc. I'm actually not using this anymore and can't replicate it at this point. I believe the problem I had is that I had a test written in TypeScript for the StatusMessages.re component and it was having that type conflict. I thought it was due to a lack of a Shim, but maybe that wasn't the case...


Bots not automatically enter group chat after disconnected.

As title, when ASF updates itself, or when it somehow gets a network problem and disconnects, bots don't enter the SteamMasterClanID group chat after reconnecting.

No, it's Valve killing chats every once in a while.

One of the reasons why !rejoinchat command exists.


Mycobacterium PLFam has Gordonia member

PLF_1763_00147431 should be restricted to Mycobacterium, but it contains Gordonia.
https://www.patricbrc.org/view/FeatureList/?eq(plfam_id,PLF_1763_00147431)#view_tab=features

My guess is at the time we generated families last time that taxonomy ID was under genus Mycobacterium in the taxonomy data in PATRIC (that's how it appears in the underlying data).
The new families have it in the right place in the  Gordonia genus.

When will we see the new families?
On Wed, May 3, 2017 at 4:40 PM, olsonanl<EMAIL_ADDRESS>wrote:

My guess is at the time we generated families last time that taxonomy ID
was under genus Mycobacterium in the taxonomy data in PATRIC (that's how it
appears in the underlying data).
The new families have it in the right place in the Gordonia genus.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PATRIC3/patric3_website/issues/1498#issuecomment-299028586,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK8ZdJYKrkCsI1_jSpnoaAncNfRCE_Ttks5r2OYigaJpZM4NP5mS
.[image: Web Bug from
https://github.com/notifications/beacon/AK8ZdMZ5_4XJ9LCUxLtpb-bD87Zf6dcbks5r2OYigaJpZM4NP5mS.gif]

Blame Senior Shukla for that one!
On Wed, May 3, 2017 at 5:03 PM, olsonanl<EMAIL_ADDRESS>wrote:

Later than it would be if I hadn't gotten dragged into some talk or
another :-)
Next week hopefully.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PATRIC3/patric3_website/issues/1498#issuecomment-299034634,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK8ZdNvXt16Rd7YNlCsO0RigyUgVNBVjks5r2OuEgaJpZM4NP5mS
.[image: Web Bug from
https://github.com/notifications/beacon/AK8ZdAFUOvzv2u51Flhp2-Qy9pFQd02nks5r2OuEgaJpZM4NP5mS.gif]

With the recent taxonomy and protein family updates, gordonia genomes are no longer displayed under mycobacteriam and corresponding local families.


Increase coverage for bottery/app.py

As reported in #45, we have a coverage of 59% of app.py file.
With this Pull Request, by mocking "external agents" (like an user Engine or the Event Loop), we'll be able to increase it to 98%.
Unfortunately, I don't really know why Coverage is saying that lines 54->57 aren't covered... debugged the code and I'm sure that the process is passing through them.
Hope it helps :)

Thank you very much @kplaube! I'm in BH for Python Brasil, so, probably not gonna have time to review your PR the way I should. @nicoddemus could you check this? I'll try to work tomorrow, but cannot promise that.

@rougeth sure, will take a look later today when I get home. 👍

Looks good @kplaube, thanks! I resolved the conflicts, as soon as it passes we can merge it.

Awesome! Thanks, guys :)


When vSAN File Services is enabled the workload domain shutdown attempts to shutdown the service nodes

Code of Conduct

[X] I have read and agree to the Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[X] Do not leave "+1" or other comments that do not add relevant information or questions.
[X] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

VMware Cloud Foundation
4.5
PowerShell Version
Windows PowerShell 5.1
PowerCLI Version
13.0.0
Module Version
1.1.0
PowerVCF Version
2.3.0
Guest Operating System
Windows Server 2019
Environment Details
No response
Description
When vSAN File Services is enabled on vSAN cluster, the workload domain shutdown script attempts to shutdown the vSAN file service nodes when shutdowncustomerVM flag is provided.
As the virtual machines are managed by EAM, the script should not shutdown the virtual machines.
"vSAN cluster shutdown"/"Restart cluster" process would shutdown/startup them automatically.
Error or Debug Output
See screenshot.
Expected Behavior
Allow EAM to manage the vSAN File Service nodes shutdown process.
Actual Behavior
The workload domain shutdown script attempt to shutdown the vSAN file service notes when shutdowncustomerVM flag is provided.
Steps to Reproduce
Run the workload domain shutdown script with the shutdowncustomerVM flag.
Log Fragments and Files
No response
Screenshots

References
Ref : https://vmware.slack.com/archives/C037S8SAT9A/p1668177125983159

will pick up


Add username

This PR closes issue no. #574
Done all the required changes such as checking whether the user exist or not. If not then, create a new user doc in users collection and if does exists then, check whether they have a username or not. If not then, give them uid as their username and if exists then, do not do anything in both sign in and sign up page.

Hi @Palakkgoyal can you please resolve conflicts? If you face issues, let me know.

Hi @Palakkgoyal can you please resolve conflicts? If you face issues, let me know.

Sure.

I solved the merge issue. Can you please check.

I solved the merge issue. Can you please check.

new pr? or should I reopen this??

Ohk. Thanks a lot.

Thanks a lot for fixing this!

No worries.


Need for onDragend event

I think there's a need for something like onDragend event. I have a use case where:

I set map's centre using a flux store

I programatically set map's centre by changing flux store

I need to change flux's store when user change's map's centre with onChange callback

I need to do some API calls when the map's centre changes for any reason

When user changes map, everything goes as expected. In the onChange I make api calls and set the new centre in flux.

When I programatically change map's centre by changing my flux store, the onChange gets called (as expected), API calls are made, and the changes related to map's centre are made in flux store again (because this code is also in the same handler). This cause the onChange to get fired again, making the API requests again.

Now for some reason unclear to me, this happen only twice mostly (perhaps because of debounce?).
I think we need a callback which gets called only when user changes the map's centre (gmap's dragend perhaps) and not when the map is changed programatically. Or am I missing something here? What do you think?

Just add equality check into onChange event handler. If newCenter!==oldCenter then call flux.
It's a normal behavior to not update state if nothing has changed.


[#1] - Added load games.json from the Documents folder

Still 2 things left to do before opening the PR:

Delete card images for each set
Download promos automatically with game installation. These cannot be deleted nor downloaded separately (reinstall the game again). This is because each set may have promos that are unlocked by themselves, so each of these sets depend on these img being available, and we cannot have them separately because the user will view the Promos as one single set.

closes #1


Fails to compile with boost asio 1.74

When compiling against boost asio 1.74 one has to define BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT for it to compile.
The details are explained here, in fact one has to change the old polymorphic executor type into the new polymorphic executor type any_io_executor.

@rezahousseini , thank you for reporting the issue.
I reproduced the error. And I read the document.
mqtt_cpp supports boost 1.66.0 or later.
I'd like to support both old (boost 1.66.0) and new (boost 1.74.0 without BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT).
However, I couldn't find how to do that.
If you know a good way, please tell me or make a pull request.

I found the solution by myself. Please check #670

I assumed it has something to do with the type erased socket, thank you!

@rezahousseini , yes and I fixed it. Does #670 work well on your environment?


MTV-422: Change VDDK container image in documentation

MTV 4.3.2
Resolves https://issues.redhat.com/browse/MTV-422 by specifying that users should download VDDK version <IP_ADDRESS>.
Preview: http://file.emea.redhat.com/rhoch/vddk7/html-single/#creating-vddk-image_mtv

LGTM


Kbps represented as Mbps

Describe the bug
On the graph, kbps are displayed as if they were mbps.
To Reproduce

Have a speed test result with mixed units
Go to the dashboard
Look at the speed graph

Expected behavior
Should be 0.xxx not xxx mbps on the graph
Environment:

OS: DSM 7.1.1-42962 Update 3
Architecture: amd64
Browser: Firefox
Version v0.8.0

Screenshots

Good catch, the charts don't maintain scale well

Same issue

I have the same issue with Gbps showing as Mbps:

I have the same issue with Gbps showing as Mbps:

Aaaaaah it's not dark mode. Issue not valid 🤣


Add a tolerance in the is_convex method

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.30%. Comparing base (bdef73b) to head (915e9d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   94.30%   94.30%
=======================================
  Files           2        2
  Lines         246      246
=======================================
  Hits          232      232
  Misses         14       14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


After "DELETE ALL" and "INITIALIZE ALL" the ta.key file is missing

I'm doing this with volumes, so it might be that I've got a folder mapping wrong or something, but I have noticed that before I do DELETE ALL and INITIALIZE ALL there are two identical copeis of ta.key on the openvpn-server container at the following paths:
/usr/share/easy-rsa/pki/ta.key
/etc/openvpn/pki/ta.key

However, after I do the delete and initialize, there is only one file here ...
/usr/share/easy-rsa/pki/ta.key

This is all well and good until I come to try and create a clinet connection profile and certificates, and then it fails.   Investigating the logs I see its because the ta.key file is not found in /etc/openvpn/pki
Some advice or support would be greatly appreciated, even if it just a change to one of the internal scripts to re-copy the file after it has been recreated.
Thanks

Further to my above, I find that the "Generate TA" button has no effect at all, meaning the user has to manually run the command on the container to create the certificate.
This seems like a pretty simple bug to fix.


Milestone: Validate contact form

On this PR, a JS script is used to validate the contact form email value.
Features

Added validation to the contact-form email input. The email input does not accept a value containing uppercase letters.
Implemented a display of an error message when the email is invalid.

Thanks, @levy002


The poller skipped execution as the previous run was not complete

Hi,
Pl refer to the attached log, see below the last few lines:
[2021-06-06 13:15:58.716] INFO    org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource [[MuleRuntime].uber.866: [metrics-accelarator].uber@org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource.createScheduler:227 @7046eb59]: Flow 'poller-flow' is already running and 'disallowConcurrentExecution' is set to 'true'. Execution skipped.
[2021-06-07 13:16:00.124] INFO    org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource [[MuleRuntime].uber.1155: [metrics-accelarator].uber@org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource.createScheduler:227 @7046eb59]: Flow 'poller-flow' is already running and 'disallowConcurrentExecution' is set to 'true'. Execution skipped.
[2021-06-08 13:16:03.049] INFO    org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource [[MuleRuntime].uber.1444: [metrics-accelarator].uber@org.mule.runtime.core.internal.source.scheduler.DefaultSchedulerMessageSource.createScheduler:227 @7046eb59]: Flow 'poller-flow' is already running and 'disallowConcurrentExecution' is set to 'true'. Execution skipped.
The poller as the previous run did not complete for some reason.
I have also attached the thread dump.
for now, i have to restart the app to resolve this.

the issue seems to be resolved after i did the following:
set maxConcurrency for arm from 3 to 100, exchange from 1 to 100, osv2
from 1 to 100


arduino-esp32 2.0.4 breaks esp-web-tools

I was trying to implement this (as I have done before) when kept getting these errors after the esp32 reboot.
23:28:30.382 -> ets Jun  8 2016 00:22:57
23:28:30.382 ->
23:28:30.382 -> rst:0x1 (POWERON_RESET),boot:0x12 (SPI_FAST_FLASH_BOOT)
23:28:30.382 -> configsip: 0, SPIWP:0xee
23:28:30.382 -> clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
23:28:30.382 -> mode:QIO, clock div:2
23:28:30.382 -> load:0x3fff0030,len:1344
23:28:30.382 -> load:0xf01d020c,len:-2118480896
23:28:30.430 -> 1162 mmu set 00010000, pos 00010000
23:28:30.430 -> 1162 mmu set 00020000, pos 00020000
23:28:30.430 -> 1162 mmu set 00030000, pos 00030000
23:28:30.477 -> 1162 mmu set 00040000, pos 00040000
23:28:30.477 -> 1162 mmu set 00050000, pos 00050000
23:28:30.524 -> 1162 mmu set 00060000, pos 00060000
23:28:30.524 -> 1162 mmu set 00070000, pos 00070000
23:28:30.570 -> 1162 mmu set 00080000, pos 00080000
23:28:30.570 -> 1162 mmu set 00090000, pos 00090000
23:28:30.570 -> 1162 mmu set 000a0000, pos 000a0000
23:28:30.616 -> 1162 mmu set 000b0000, pos 000b0000
23:28:30.616 -> 1162 mmu set 000c0000, pos 000c0000
23:28:30.662 -> 1162 mmu set 000d0000, pos 000d0000
23:28:30.662 -> 1162 mmu set 000e0000, pos 000e0000
23:28:30.709 -> 1162 mmu set 000f0000, pos 000f0000
23:28:30.709 -> 1162 mmu set 00100000, pos 00100000
23:28:30.709 -> ets Jun  8 2016 00:22:57
23:28:30.709 ->
23:28:30.709 -> rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
23:28:30.755 -> configsip: 0, SPIWP:0xee
23:28:30.755 -> clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
23:28:30.755 -> mode:QIO, clock div:2
23:28:30.755 -> load:0x3fff0030,len:1344
23:28:30.755 -> load:0xf01d020c,len:-2118480896
23:28:30.755 -> 1162 mmu set 00010000, pos 00010000
23:28:30.802 -> 1162 mmu set 00020000, pos 00020000

Arduino 1.19 with arduino-esp32 2.04 and 2.03 will both program the esp32 fine, but when I grab the 4 files for esp32-web-tools, then the 2.04 files do not work -- they produce the stuff above.
Arduino produces the same programming strings here:
204 C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\tools\esptool_py\3.3.0/esptool.exe --chip esp32 --port COM7 --baud 460800 --before default_reset --after hard_reset write_flash -z --flash_mode dio --flash_freq 80m --flash_size 4MB 0x1000 C:\Users\James\AppData\Local\Temp\arduino_build_686088/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bootloader.bin 0x8000 C:\Users\James\AppData\Local\Temp\arduino_build_686088/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.partitions.bin 0xe000 C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\hardware\esp32\2.0.4/tools/partitions/boot_app0.bin 0x10000 C:\Users\James\AppData\Local\Temp\arduino_build_686088/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bin
203 C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\tools\esptool_py\3.3.0/esptool.exe --chip esp32 --port COM7 --baud 460800 --before default_reset --after hard_reset write_flash -z --flash_mode dio --flash_freq 80m --flash_size 4MB 0x1000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bootloader.bin 0x8000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.partitions.bin 0xe000 C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\hardware\esp32\2.0.3/tools/partitions/boot_app0.bin 0x10000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bin

The files are slightly different sizes for bootloader.bin and ino.bin, and the other two are the same files.

And I'm using the identical manifest.json
{
  "name": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino",
  "new_install_prompt_erase": false,
  "builds": [
    {
      "chipFamily": "ESP32",
      "parts": [
        { "path": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bootloader.bin", "offset": 4096 },
        { "path": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.partitions.bin", "offset": 32768 },
        { "path": "boot_app0.bin", "offset": 57344 },
        { "path": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bin", "offset": 65536 }
      ]
    }
  ]
}

2.0.3 files work and 2.0.4 files do not.
This looks like a similar issue to this one (here):
https://github.com/esphome/esp-web-tools/issues/278
... and this one over at arduino-esp32
https://github.com/espressif/arduino-esp32/issues/7212
There seems to be discussion about qio, dio, dout programming and the 40/80 flash frequency.  The two arduino esptool strings are both dio above, even though Arduino is set to qio.  Arduino can program it fine at 40 or 80.
Here is the 2.03 40 listing if there is something in there that a wise-man can see:
C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\tools\esptool_py\3.3.0/esptool.exe --chip esp32 --port COM7 --baud 460800 --before default_reset --after hard_reset write_flash -z --flash_mode dio --flash_freq 40m --flash_size 4MB 0x1000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bootloader.bin 0x8000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.partitions.bin 0xe000 C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\hardware\esp32\2.0.3/tools/partitions/boot_app0.bin 0x10000 C:\Users\James\AppData\Local\Temp\arduino_build_830660/ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino.bin
esptool.py v3.3
Serial port COM7
Connecting.....
Chip is ESP32-D0WDQ6 (revision 1)
Features: WiFi, BT, Dual Core, 240MHz, VRef calibration in efuse, Coding Scheme None
Crystal is 40MHz
MAC: 0c:b8:15:f4:14:50
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 460800
Changed.
Configuring flash size...
Flash will be erased from 0x00001000 to 0x00005fff...
Flash will be erased from 0x00008000 to 0x00008fff...
Flash will be erased from 0x0000e000 to 0x0000ffff...
Flash will be erased from 0x00010000 to 0x00109fff...
Compressed 18528 bytes to 12759...
Writing at 0x00001000... (100 %)
Wrote 18528 bytes (12759 compressed) at 0x00001000 in 0.6 seconds (effective 231.4 kbit/s)...
Hash of data verified.
Compressed 3072 bytes to 119...
Writing at 0x00008000... (100 %)
Wrote 3072 bytes (119 compressed) at 0x00008000 in 0.1 seconds (effective 393.2 kbit/s)...
Hash of data verified.
Compressed 8192 bytes to 47...
Writing at 0x0000e000... (100 %)
Wrote 8192 bytes (47 compressed) at 0x0000e000 in 0.2 seconds (effective 419.4 kbit/s)...
Hash of data verified.
Compressed 1021040 bytes to 639310...
Writing at 0x00010000... (2 %)
Writing at 0x0001c720... (5 %)
Writing at 0x00028395... (7 %)
Writing at 0x00031ec1... (10 %)
Writing at 0x0004107c... (12 %)
Writing at 0x00046e7d... (15 %)
Writing at 0x0004d569... (17 %)
Writing at 0x00053360... (20 %)
Writing at 0x00058da9... (22 %)
Writing at 0x0005e522... (25 %)
Writing at 0x00063caf... (27 %)
Writing at 0x000690e3... (30 %)
Writing at 0x0006e444... (32 %)
Writing at 0x00073733... (35 %)
Writing at 0x00078abf... (37 %)
Writing at 0x0007dda1... (40 %)
Writing at 0x00083353... (42 %)
Writing at 0x000885a7... (45 %)
Writing at 0x0008d4f0... (47 %)
Writing at 0x00092cfe... (50 %)
Writing at 0x00099976... (52 %)
Writing at 0x0009ec10... (55 %)
Writing at 0x000a45dc... (57 %)
Writing at 0x000a9aea... (60 %)
Writing at 0x000aecaf... (62 %)
Writing at 0x000b4054... (65 %)
Writing at 0x000b94e1... (67 %)
Writing at 0x000be9d2... (70 %)
Writing at 0x000c42ec... (72 %)
Writing at 0x000ca090... (75 %)
Writing at 0x000cfa4c... (77 %)
Writing at 0x000d5400... (80 %)
Writing at 0x000ddea4... (82 %)
Writing at 0x000e7502... (85 %)
Writing at 0x000ec67c... (87 %)
Writing at 0x000f3249... (90 %)
Writing at 0x000f8930... (92 %)
Writing at 0x000fe05e... (95 %)
Writing at 0x00103465... (97 %)
Writing at 0x001092b4... (100 %)
Wrote 1021040 bytes (639310 compressed) at 0x00010000 in 15.2 seconds (effective 539.0 kbit/s)...
Hash of data verified.

Any ideas ... other than stick with 2.03?

What version of ESP Web Tools are you using?

I knew I left out something -- 9.0.3
The setup is over here: https://github.com/jameszah/ESP32-CAM-RocketCam

One Click Installer 2.0.4 (doesn't work)

<esp-web-install-button manifest="installer/manifest.json"></esp-web-install-button>

One Click Installer 2.0.3

<esp-web-install-button manifest="installer203/manifest.json"></esp-web-install-button>

Can you try flashing it with https://espressif.github.io/esptool-js/ ? If that doesn't work, it's an upstream bug in https://github.com/espressif/esptool-js/

When I flash on the just 2.0.4 bootloader.bin at 0x1000 onto a esp32 flashed with 2.0.3 version , it fails with the
21:16:05.532 -> rst:0x1 (POWERON_RESET),boot:0x12 (SPI_FAST_FLASH_BOOT)
21:16:05.532 -> configsip: 0, SPIWP:0xee
21:16:05.532 -> clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
21:16:05.579 -> mode:QIO, clock div:2
21:16:05.579 -> load:0x3fff0030,len:1344
21:16:05.579 -> load:0xf01d020c,len:-2118480896
21:16:05.579 -> 1162 mmu set 00010000, pos 00010000
21:16:05.579 -> 1162 mmu set 00020000, pos 00020000

Then I flash the 2.0.3 bootloader.bin, and it works again.
Then flash the 2.0.4 ino.bin at 0x10000 (still with the 2.0.3 bootloader), and it works.
Then flash 2.0.4 bootloader.bin, and it fails again.
2.0.3 bootloader is 18,560 bytes May 4, 2022
2.0.4 bootloader is 18,880 bytes Jul 6, 2022
So esptool (esptool_py\3.3.0/esptool.exe) that Arduino uses knows how to do it, but not esptool_js?

Can you flash it to an ESP node using the IDE and then read the flashed data back from it using esptool.py.
With that file, can you try to use the webtools to flash another node?
If that does work, then it is very likely the same bug/issue as is being discussed in various issues when searching for "qio" or any of the other flash  modes.
In short:
The flash mode, flash size and flash speed will be altered using flash tools like esptool.py while flashing.
However the web-tool does not.
On top of that, the flash mode and the SPI mode for PSRAM are probably different too, even though you might not even use PSRAM.
By setting the flash mode in the IDE to QIO, you might get a working system again... as long as all pins needed for QIO are connected to the flash on your board. (have not yet seen ESP32 boards that haven't)

Flashing individual files woth esp-web-tools for ESP32x is always a more or less wrong way. Doing this way you just have one correct variant for flash mode, flash size and flash mode!!. Since core 2.0.4. does not have set any default value for any of these, it will fail if you try to flash. You have to create a combined (merged) firmware. Esptool.py can be used to do this.

@Jason2866 we should add some guidance to our README maybe. Should we just always encourage using a single firmware that is a merged file?

@balloob Yes, a single firmware file is the only way to get predictable working installs.

So I switched back to 2.0.4, re-flashed it with Arduino,

... and then used this to read it off the flash.
C:\Users\James\esp\esp-idf>C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\tools\esptool_py\3.3.0/esptool.exe --chip esp32 --port COM7 --baud 460800 read_flash 0 0x400000 my_4mb.img
esptool.py v3.3
Serial port COM7
Connecting.......
Chip is ESP32-D0WDQ6 (revision 1)
Features: WiFi, BT, Dual Core, 240MHz, VRef calibration in efuse, Coding Scheme None
Crystal is 40MHz
MAC: 0c:b8:15:f4:14:50
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 460800
Changed.
4194304 (100 %)
4194304 (100 %)
Read 4194304 bytes at 0x0 in 100.2 seconds (335.0 kbit/s)...
Hard resetting via RTS pin...

... which seemed to work.  But when I used esp-web-tools to flash that big file using this:
{
  "name": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino",
  "new_install_prompt_erase": false,
  "builds": [
    {
      "chipFamily": "ESP32",
      "parts": [
        { "path": "my_4mb.img", "offset": 0 }
      ]
    }
  ]
}

... it would always timeout at 98%.  And it did the same thing when using https://espressif.github.io/esptool-js/.

I tried it all again with a 3mb file --  I'm using 3mb Huge App, and not using the spiffs of littlefs.  But it times out again at 98%.
Although the program does run correctly.  Although I was re-flashed to a previously working chip.  But not elegant.
Is there a merge procedure for bootloader, partitiion,s ino.bin plus boot_app0.bin into a single file?
Or any advice on this timeout business?

This is what I use to generate a single bin file using PlatformIO: https://github.com/letscontrolit/ESPEasy/blob/mega/tools/pio/post_esp32.py
In short, it does generate a command line for esptool.py with explicitly setting the flash parameters and using the merge_bin option.
But this might still be different from flashing to a node and reading it back as initially the flash settings changed on the fly using esptool (or ArduinoIDE) are based on what the flash tool detects. The combined bin file is based on what you're setting.
So you might need to experiment.
But I think setting to qio and 40 MHz is probably the best chance for success.

But I think setting to qio and 40 MHz is probably the best chance for success.

No, it is not. It has to be here dio  The flash mode which is read from the 2nd stage bootloader is set in the firmware app.bin during compile. It is a safe bet to use dio here.

Hi, thanks for the info - I had never touched that qio/dio/... setting before.  The speed/method of writing the flash would depend on hardware, but I would have thought that what gets written would end up the same.
My workaround was to use the the traditional 4 file esp-web-tools method, but replace the bootloader with the version generated by 2.0.3.  I will flash and run correctly.
The issue seems to be on the table over at arduino-esp32.
Thanks.

My workaround was to use the the traditional 4 file esp-web-tools method, but replace the bootloader with the version generated by 2.0.3. It will flash and run correctly.

I would not do this. You probably run in issues. You have fixed magic bytes settings which will not work for all devices which do differ in flash size and flash frequency.
It is just wrong. Thats the reason why changed in 2.0.4. It is a bug fix!!

ok, that wasn't too hard
esptool command line with the 4 files from the 2.0.4 compile
C:\ArduinoPortable\arduino-1.8.19\portable\packages\esp32\tools\esptool_py\3.3.0/esptool.exe --chip esp32 merge_bin -o srt.4.ino.img --flash_mode dio --flash_freq 40m --flash_size 4MB 0x1000 srt.4.ino.bootloader.bin 0x8000 srt.4.ino.partitions.bin 0xe000 boot_app0.bin 0x10000 srt.4.ino.bin

And drop the output for esp-web-tools to write as 1 file
{
  "name": "ESP32-CAM-Video-Recorder-junior-60x.4.7.srt.4.ino",
  "new_install_prompt_erase": false,
  "builds": [
    {
      "chipFamily": "ESP32",
      "parts": [
        { "path": "srt.4.ino.img", "offset": 0 }
      ]
    }
  ]
}

Given that esptool.js, aims to be a port of esptool.py, I would still consider this a bug upstream 👍  If esptool.py can figure it out, so should esptool.js

@balloob Please keep in mind that esptool.py when run from the IDE does have other bootloader bin files at its proposal.
Not sure if the tool does actually fetch other files, or that it may patch them on the fly, but it might be something to be aware of.

@TD-er is right. When compiling Arduino firmware there all variants of the precompiled bootloader files forr the different MCU types in this folders These files are Arduino specific! If a firmware is compiled with IDF the files will be different and builded new with the specific options set in IDF. There are NO bootloaders precompiled at all. Esptool.py "just" uses thes files to flash the device correctly.
In short, user has to take care to provide the correct files or the combined firmware.

I’ve opened a PR for the README https://github.com/esphome/esp-web-tools/pull/298


Colville, WA Address Points

https://services2.arcgis.com/ucbvac2Huf0fbL3D/arcgis/rest/services/ColvilleAddresses/FeatureServer/0

Now requires authentication

does this work @trescube :) https://www.dropbox.com/s/cmkaspxj8jftnz7/Colville_Addresses.zip?dl=0


Added yaml and folders for the collections avaialbe in EDC

Added yaml and folders for the collections avaialbe in EDC

@Schpidi
can you see this pull request???

Hi @AlessandroScremin - @Kampen1988 is working on this merge request. There is some work required as the code you pushed is crashing the build. But are working to try to fix it.
Just to understand the urgencies - is there a specific timeline, apart of ASAP?

@gmilcinski to me the deadline was 7th May...tomorrow....I can investigate if more time is needed...will ask Anca

my understanding is that this is critical for June 1st when the challenges go live. but as we need a review cycle the idea was to have a first version for May 7th. so not super urgent but will safe panic mode later on.

With some corrections the build worked! I can push my changes to the merge request tomorrow to have a first version online. Following this we can improve some of the descriptions as we see fit.

@Kampen1988
ok for me...but please let mw know what was wrong with the files so that next time I can avoid same errors
kr
Alessandro

@AlessandroScremin
We need to add the trilateral JAXA WQ maps data

@aapopescu
ok I will generate them...but just to let you know Jaxa maps are not available in Race, for this reason I didn't add them to the accessible products. the tabs are only availbe for the trilateral...
see pictures to betetr understand what I mean.

@AlessandroScremin for the hackathon we need all the data in trilateral

@AlessandroScremin
We need to add :

the trilateral JAXA WQ maps data and all the new data they want to make available --> @gmilcinski
S2 layers that are used in the E13b - airplane detections --> this one should only get the hackathon tag in the edc catalogue

SO to clarify
I added all the layers we ingested in EDC. Pleiades and Planet datasets used for archived and old products were not added. Should I add also the archived Pleiades and Planets data collections?
S2 Layers that are used for E13b, these are the default Sentinel 2 layers, so alredy in EDC. what were you referring to?
rk
Alessandro

@aapopescu
ok let me recap:
Almost all the layers we inegsted into EDC have been provided. Pleiades and Planets were excluded. Shoudl I add also those collections to the yaml file? (are mainly related to the archived ship detection, and car counts in parking lots)
E13b. THis indicator use the dafault EDC sentinel 2 layers and the geoJsons, so we didn't ingest any S2 data nor GeoJsons. SO what you had in mind with E13b S2 layers?
kr
Alessandro


--privileged should turn off defaults for SELinux, Apparmor and seccomp

Signed-off-by: Dan Walsh<EMAIL_ADDRESS>

LGTM


gwcs 0.9.0 release

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nden - given that gwcs doesn't support python2.7 any more, you'll need to remove those builds from the ci config files.

This will be followed by a new release.


deployment fails while using passwordless sudo user

Hello!
At the moment, deploying CEK (v21.08) works only when ansible connects using root's user.
When I want to deploy it using other passwordless sudo enabled user (centos/ubuntu), it fails in multiple places:
ansible-playbook -i examples/full_nfv/inventory.ini playbooks/full_nfv.yml
My inventory:
[all]
mossapio-k8s-master-1 ansible_user=ubuntu
mossapio-k8s-node-1 ansible_user=ubuntu
localhost

[kube-master]
mossapio-k8s-master-1

[etcd]
mossapio-k8s-master-1

[kube-node]
mossapio-k8s-master-1
mossapio-k8s-node-1

[k8s-cluster:children]
kube-master
kube-node

[calico-rr]

[all:vars]
ansible_python_interpreter=/usr/bin/python3

I'll provide full ansible log later with the 1st encountered error.

TASK [bootstrap/configure_proxy : set /etc/environment proxy settings] ************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: PermissionError: [Errno 13] Permission denied: b'/tmp/tmpiztwwro3' -> b'/etc/environment'
failed: [mossapio-k8s-node-1.szczecin.service.tieto.com] (item={'key': 'http_proxy', 'value': ''}) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": {
        "key": "http_proxy",
        "value": ""
    }
}

MSG:

The destination directory (/etc) is not writable by the current user. Error was: [Errno 13] Permission denied: b'/etc/.ansible_tmpqv28rod8environment'
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: PermissionError: [Errno 13] Permission denied: b'/tmp/tmpeztonoce' -> b'/etc/environment'

@moss2k13 Have you resolved the issue already? The workflow for non-VM installation that works for our team is adding --become -K --become-user=root to the command line, so in your case this would look like:
ansible-playbook -i examples/full_nfv/inventory.ini playbooks/full_nfv.yml --become -K --become-user=root
The -K parameter forces to ask you for password on start and if you use password-less sudo just confirm with empty password.

thanks for info, I'll give it a try after new years eve once I'll be back at the office. I'll update you here

@moss2k13 any updates? Can we close the issue?

thanks for reminder, I forgot to update you here, we can close it

@moss2k13 Thanks for the quick update :-)!
@michaelspedersen Can you close it?

@moss2k13 Thanks for the quick update :-)! @michaelspedersen Can you close it?

I can't, but @calinghe should be able to :)

Closing based on the above comments.  Thank you, all!


fix: AppLayout horizontal scroll

Description
When 3 drawers are open on a page with the app layout toolbar, resizing the page eventually causes a horizontal scrollbar to appear (see the picture below), even though all drawers are resized to their minimum size. A solution for that is to check for the horizontal scroll on resize and close the drawers following the priority: navigation bar first, then the first opened drawer.

Related links, issue #, if available: n/a
How has this been tested?

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://github.com/cloudscape-design/components/pull/2839#discussion_r1806489760
Tried. It leads to unexpected results


Implicit mappings of landmark roles

We've constructed our layouts from the recommended HTML in the GDS documentation, but now our accessibility testing tools are flagging that we should not be adding aria-role to things like <header> and <main> because the browser natively implies these for certain elements/tags - https://a11yproject.com/posts/aria-landmark-roles/
I'm not sure if this is an issue per-se, but should the documentation reflect this, or are there times where the aria-role is actually needed?

Hi @glenpike thanks a lot for letting us know about this.
We're doing some work right now to document any known validation/accessibility warnings: https://github.com/alphagov/govuk-frontend/issues/1280 We will hopefully have some more documentation around this soon.
I'm going to close your issue as it's going to be covered by https://github.com/alphagov/govuk-frontend/issues/1280.
Thanks again for raising this, it helps us to prioritise the wider issue 👍


Azure Route Server not available for CSP subscription

I'm currently not able to deploy the Azure Route Server in a CSP subscription:

As this service is now GA, shouldn't it be available for CSP subscriptions as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c771bcd2-f7be-662f-f9a8-225a45714e08
Version Independent ID: b2ecbc58-7f13-44b7-38bd-ffc773570e87
Content: Quickstart: Create and configure Route Server using the Azure portal
Content Source: articles/route-server/quickstart-configure-route-server-portal.md
Service: route-server
GitHub Login: @duongau
Microsoft Alias: duau

@mwaespi , I checked with the Azure route server Product Group team team regarding this issue and below is their update:
This is a known issue to us and we are working to fix it.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Still having the same issue with today. Any update on this?

@ManCalAzure , could you try installing Azure Route server via Azure PowerShell or CLI and check if you are able to install it?
PowerShell: https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-powershell
CLI : https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-cli
In case you are able to install it via either PS or CLI and unable to via Portal, I would advise you to raise a support request for further investigation. Thank you!

@ManCalAzure , could you try installing Azure Route server via Azure PowerShell or CLI and check if you are able to install it? PowerShell: https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-powershell CLI : https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-cli
In case you are able to install it via either PS or CLI and unable to via Portal, I would advise you to raise a support request for further investigation. Thank you!

Getting Error with Azure CLI:
az network routeserver create -g RG-ARS --name ARS-1 --hosted-subnet RouteServerSubnet
(InvalidRequestFormat) Cannot parse the request.
(InvalidRequestFormat) Cannot parse the request.
PowerShell Error:
PS C:\Users\manny> New-AzRouteServer
cmdlet New-AzRouteServer at command pipeline position 1
Supply values for the following parameters:
(Type !? for Help.)
ResourceGroupName: RG-ARS
RouteServerName: ARS-1
HostedSubnet: RouteServerSubnet
Location: eastus
New-AzRouteServer : Cannot parse the request.
StatusCode: 400
ReasonPhrase: Bad Request
ErrorCode: InvalidRequestFormat
ErrorMessage: Cannot parse the request.
Additional details:
Code: SubscriptionsPrefixMissingInJsonReferenceId
Message: Value of id property has to start with '/subscriptions/'. Provided value doesn't: RouteServerSubnet. Path properties.subnet.
OperationID : 0372cfb5-5832-45f8-a70a-eca9c1a64d4f
At line:1 char:1

New-AzRouteServer

  + CategoryInfo          : CloseError: (:) [New-AzRouteServer], NetworkCloudException
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.Network.NewAzureRmRouteServer

Both having parsing errors

@ManCalAzure , The "--hosted-subnet" in the CLI command is the resource ID of the RouteServerSubnet which generally starts with '/subscriptions/' and NOT just the subnet name.
To obtain and store the resource ID of the RouteServerSubnet to the subnet_id variable, use az network vnet subnet show, after adding the RouteServerSubnet to your virtual network.
Check step 2 on the Add a dedicated subnet section:
https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-cli#add-a-dedicated-subnet
Or else obtain the resource ID by using the below command:
az network vnet subnet show -g MyResourceGroup -n MySubnet --vnet-name MyVNet
And then use the whole URI in your CLI command for the --hosted-subnet parameter.
Example:

Hope this helps!

@ManCalAzure , The "--hosted-subnet" in the CLI command is the resource ID of the RouteServerSubnet which generally starts with '/subscriptions/' and NOT just the subnet name.
To obtain and store the resource ID of the RouteServerSubnet to the subnet_id variable, use az network vnet subnet show, after adding the RouteServerSubnet to your virtual network.
Check step 2 on the Add a dedicated subnet section: https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-cli#add-a-dedicated-subnet
Or else obtain the resource ID by using the below command: az network vnet subnet show -g MyResourceGroup -n MySubnet --vnet-name MyVNet And then use the whole URI in your CLI command for the --hosted-subnet parameter.
Example:
Hope this helps!

Problem solved. Thank you.


Expo init is not working

verbose stack Error: Command failed: git clone --depth=1 -q -b v0.22.1-exp.0 git://github.com/expo/react-native-maps.git /home/exa4/.npm/_cacache/tmp/git-clone-706a8668
***Command :: expo init  ***
After the name specified, it will run and install the npm dependencies normally but in my case, it just shows the following error:
npm ERR! code 1
npm ERR! Command failed: git clone --depth=1 -q -b v0.22.1-exp.0 git://github.com/expo/react-native-maps.git /home/exa4/.npm/_cacache/tmp/git-clone-706a8668
npm ERR! /home/exa4/.npm/_cacache/tmp/git-clone-706a8668/.git: Permission denied
npm ERR!
npm ERR!
Thanks in advance, please post the solution.

@Jaisai123 i presume you are referring to trying to use: https://github.com/expo/expo-cli, in which case, you should file a bug there. This doesn't seem like a failure of react-native, but rather incorrect permissions on your machine. Perhaps you npm installed using sudo? In any case, I recommend filing this issue with expo.


UI: Move styling into separate package

We should focus on #69 but keep it in the same package. Additional/separate package would be for expectations of reimplementations in a different framework, which at this point will likely never happen.


Add relative date and time functions

Just 2 little functions I'd like to add. I'm not sure about the string format but decided to go with readable ones. Please review. Cheers!

three.hours_from_now()
three.days_from_now()

Issue: https://github.com/JasonTurley/three/issues/1

All great ideas! Thanks for also updating the README.

No worries, thanks for the merge.


Add no-unsupported-browser-features rule

Copied from WordPress Autoprefixer configiruation:
https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L28
browsers: [
  'Android >= 2.1',
  'Chrome >= 21',
  'Edge >= 12',
  'Explorer >= 7',
  'Firefox >= 17',
  'Opera >= 12.1',
  'Safari >= 6.0'
],

stylelint rule:
    "no-unsupported-browser-features": [true, {
      "browsers": "Android >= 2.1, Chrome >= 21, Edge >= 12, Explorer >= 7, Firefox >= 17, Opera >= 12.1, Safari >= 6.0"
    }],

Testing this rule on WordPress CSS currently results in 3279 warnings, of which 2463 relate to IE, 790 Android Browser, and 227 Opera leaving 158 warnings for all other browsers.
Bumping the versions of each browser greater than 1% usage results in 148 warnings in total:
    "no-unsupported-browser-features": [true, {
      "browsers": "Android >= 4.4, Chrome >= 49, Edge >= 13, Explorer >= 11, Firefox >= 46, Opera >= 38, Safari >= 9.1"
    }],

Bumping explicitly to >1% results in 1448 warnings:
    "no-unsupported-browser-features": [true, {
      "browsers": ">1%"
    }],

Above stats from http://caniuse.com/usage-table
Note: supporting all of the browsers via the Autoprefixer configuration cited is not the same as any WordPress policy on supported browsers, it doesn't hurt to support older browser vendor prefixes and this in no way suggests WordPress supports all these browser versions

Note: Via http://stylelint.io/user-guide/rules/no-unsupported-browser-features/

This is a good rule to use with "warning"-level severity, because its primary purpose is to warn you that you are using features not all browsers fully support and therefore ought to provide fallbacks. But the warning will continue even if you have a fallback in place (it doesn't know); so you probably do not want this rule to break your build. Instead, consider it a friendly reminder to double-check certain spots for fallbacks.

Note: no-unsupported-browser-features was deprecated as part of stylelint 7.8
Per that, I'm closing this.


Invitation

Hello @prasad-edlabadka ,
I am the former Tuya employee who propose to launch the official tuya plugin project. Now since the official plugin is not active anymore, I am maintaining a fork version with brunch of bug fix and new device support. In the next minor version I plan to add IR device support, and I found your project. Since we are both using Tuya OpenAPI, would you like to join with me together? You can focusing on the IR part and I will forcus on the base part of the API/MQTT/user/home/device and so on.

Hello,
Can you please send the link to your plugin? Also, I guess integrating "regular" Tuya devices with IR control is tricky because of the way Tuya structures the devices and APIs. e.g. there isn't any option to operate devices offline / lan mode.

Thanks for the reply. here's the plugin: https://github.com/0x5e/homebridge-tuya-platform
IR is already work in progress, and the lan mode is not supported, I wish I can find a legal way to support this.


[5.5] Allow default headers to be sent with requests

This PR allows default headers to be sent with the requests. So, instead of having to override the call method or having to use something as
$this->withServerVariables([
    'HTTP_FOO' => 'bar'
]);

$this->get('/');

You can do
$this->withHeaders([
    'foo' => 'bar'
]);

$this->get('/');

You can also clean the headers with $this->cleanHeaders();
I've been having to send default headers quite a lot on an app and thought it would be cool to have it on the core. let me know what you all think

I'd like to see a withHeader($name, $value) method too. Or just header($name, $value) to compliment that from Illuminate\Http\ResponseTrait

I would rather see it clear the headers after each test.

@DCzajkowski in the withHeader case, would it be "global" or only applied in the next request?
@taylorotwell what worries me is if the user needs to clear the headers on the same test, in another request. Any ideas?

Wouldn't they just call ->clearHeaders() manually in that case?

@taylorotwell oh, I thought you were saying you would rather not have the clearHeaders method and just have it reset after each test. I believe the way it is set up it resets after each test? i can test it once I get home

Added a commit to flush the headers on the tearDown method


BaseRequester events do not properly remove event handlers

In the devel branch, the events defined in AngleSharp.Io.BaseRequester do not correctly remove event handlers when delegates are removed from the .NET events. On BaseRequester.cs:20 and BaseRequester.cs:29, the remove handler incorrectly calls AddEventListener again instead of calling RemoveEventListener.

Very good finding - thanks for the PR!


Auth for PI and simple usage

Part of Issue #217

@wongband FYI, this PR does basic auth for looking at the PI of of project


About the prior in mld.py and memory in mld_denoiser

I am confused by the two parts in the diffusion process.
(1) In mld.py, line 460 and 461, the noise and noise_pred were chunked in to two-part to get the noise_prior and noise_pred_prior. What is the meaning of the prior? I am not very familiar with diffusion, and for me, it seems like all I need to do is calculate the MSE between noise and noise_pred.
(2) In mld_denoiser.py, line 216, the decoder uses "tgt" and "memory" to compute the output. What is the meaning of tgt and memory?

Hi 1994cxy,

This chunking trick (two parts) is for classifer_free_guidance, an inference process of diffusion.
https://github.com/ChenFengYe/motion-latent-diffusion/blob/081ce3152e5a95b14a4495fb2d32939c257c6216/mld/models/modeltype/mld.py#L460
https://github.com/ChenFengYe/motion-latent-diffusion/blob/081ce3152e5a95b14a4495fb2d32939c257c6216/mld/models/modeltype/mld.py#L339

It is a MSE loss for noise and noise_pred.

tgt and memory  indicate two inputs of the transformer module.  You can refer to this link for details.
https://blog.csdn.net/zhaohongfei_358/article/details/126019181

very helpful, thanks a lot.


Unable to download nightly binaries

All the links in README, such as this one
give me
HTTP ERROR 404

Problem accessing /view/Nightly/job/nigntly-matrix-linux-gpu/TF_BUILD_CONTAINER_TYPE=GPU,TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON2,label=gpu-linux/lastSuccessfulBuild/artifact/pip_test/whl/tensorflow-0.8.0-cp27-none-linux_x86_64.whl. Reason:

    Not Found
Powered by Jetty://

Seems to be fixed.

It failed again.


Daemon System - Character Sheet Update

This is an Update for the Character Sheet for the Brazilian OGL System, Daemon. This update includes better visuals, a functional roll template, some degree of automation and personalization. It also tries to bring the code closer to nowadays roll20 standards.

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: Daemon  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: Editora Daemon (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: Sistema Daemon (i.e. Dungeons & Dragons, FATE)

[X] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

This is mainly an update to the system's character sheet. It includes a better rolltemplate, better visuals, some degree of automation, the capacity to change how the attribute modifiers are calculated through the default sheet settings, and some internal personalization options,
I hope this would be the best version avaiable of the character sheet for this system.
The overall system rules can be found at: www.daemoneditora.com.br/categoria-produto/rpg/daemon/.

Character Sheet Info Roll20 Internal Use only.


Installing molecule[docker] does not bring all dependencies with Ansible-Core.

Issue Type

Bug report

Molecule and Ansible details

ansible-core-2.11.4
molecule-3.4.0
molecule_docker-0.2.4

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
When installing molecule[docker]  through pip, along with Ansible-core 2.11, all required dependencies should also be installed.
Actual Behaviour
It seems that docker_login is used by molecule, and is not being installed, as Ansible-core does not contain community modules.
INFO     centos-7 scenario test matrix: dependency, create, prepare
INFO     Performing prerun...
INFO     Guessed /home/vsts/work/1/s as project root directory
INFO     Added ANSIBLE_LIBRARY=./molecule:plugins/modules
INFO     Added ANSIBLE_COLLECTIONS_PATH=/home/vsts/.cache/ansible-lint/dc0145/collections
INFO     Added ANSIBLE_ROLES_PATH=~/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:roles
INFO     Running centos-7 > dependency
WARNING  Skipping, missing the requirements file.
WARNING  Skipping, missing the requirements file.
INFO     Running centos-7 > create
INFO     Sanity checks: 'docker'
[DEPRECATION WARNING]: Ansible will require Python 3.8 or newer on the
controller starting with Ansible 2.12. Current version: 3.6.14 (default, Jul  5
 2021, 20:52:02) [GCC 9.3.0]. This feature will be removed from ansible-core in
 version 2.12. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
ERROR! couldn't resolve module/action 'docker_login'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '/opt/hostedtoolcache/Python/3.6.14/x64/lib/python3.6/site-packages/molecule_docker/playbooks/create.yml': line 11, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  tasks:
    - name: Log into a Docker registry
      ^ here
CRITICAL Ansible return code was 4, command was: ansible-playbook --inventory /home/vsts/.cache/molecule/s/centos-7/inventory --skip-tags molecule-notest,notest /opt/hostedtoolcache/Python/3.6.14/x64/lib/python3.6/site-packages/molecule_docker/playbooks/create.yml

Note: This was executed with Azure image ubuntu-20.04.

This issue should be resolved by https://github.com/ansible-community/molecule-docker/pull/77 and https://github.com/ansible-community/molecule/pull/3192
IIRC, Molecule with those changes has been already released, but we still need to make a docker driver release, so I am leaving this open until that happens.
@ssbarnea Are there any plans on releasing a new version of molecule docker driver?

molecule-docker 1.0.2 was released 5 days ago, closing. For bugs related to drivers please raise tickets with driver repositories instead of molecule itself.


Make ci-robot admin to support auto updates on staging

Describe Request:
Can you make the<EMAIL_ADDRESS>admin on circle ci so we can configure auto updates on staging branch as well?
In casino team we generate staging pre-release tags and having to open a PR for them every single time is very annoying.
Examples:
- stacks-update/update-service-version:
          context: global
          branch: staging
          stack: casino-sites
          repo: git@github.com:coingaming/stacks.git
          git_email<EMAIL_ADDRESS>          requires:
            - build-tag
          filters:
            branches:
              ignore: /.*/
            tags:
              only: /^(?=.*v)(?=.*staging).*/

Supporting Documentation Links:

hey do I understand correctly that you want this bot to create commits to staging branch? Because if it is like so, then it's not this repo's issue. It was rather cross-teams decision a while ago, to make changes to staging branch only through PRs.

otherwise than that, this orb has no issues to push to any non-protected branch, so closing this issue


Add bootstrap build scripts to tweak bootstrap files

build.sh will have logic to make custom changes to bootstrap files. For starters, the alluxio download url can be replaced

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9529/
Test PASSed.

@Xenorith, PTAL thanks. The scripts are very basic for now, and will hopefully allow for easy customizations in the future

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9530/
Test PASSed.

if you want to avoid splits in logic for sed, you can try using the perl-based approach in ./dev/scripts/update-versions.sh

how about running build.sh creates a .generated directory with copies of the files (regardless of changes or not)? that way we can always run build.sh and use whatever is in .generated

.generated sounds good to me

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9531/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9533/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9535/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9537/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9538/
Test PASSed.

can someone help me merge this?

alluxio-bot, merge this please


Using hasPreviousSession in getSession to avoid initializing session …

…if it does not exists in the current request
Goal
Avoid initializing session, if it does not exists in the current request
Design
The default usage of hasPreviousSession
Changeset
getSession uses hasPreviousSession to detect session
Testing
Automated.

Hi @oleg-andreyev,
Thanks for the PR, we will look to review as soon as priorities allow.

This is now released in v1.10.0 🎉


read.junctions modification

Allow proper parsing of header line into columns for junctions provided in canonical BEDPE format.

merged as part of PR 58


any support documentation for MacOs

hey would you happen to have any resources as to how to make it run on macOS ? @iliaamiri

Node and NPM are going to work on Mac just fine.
For the Selenium server, you might have to either run a CentOS 7 on a local VM and bind the ports to your host.
OR, use docker which I think is easier. I wrote about it in the Readme on how to use Docker. Basically, you'll have to run a Docker container hosting your Selenium Server.
If you wanna get familiar with Docker itself, I'd recommend watching this video even though I know it's super long: https://www.youtube.com/watch?v=fqMOX6JJhGo&t=6039s
Everything in the README should be the same for MacOS.

Thanks for the info, setup docker and got it to run, but now it's stuck in a loop. the error it displays is
Retrying...
Redirecting to the start-point...
ERROR: WebDriverError: Unknown error: {"additionalInformation":"Driver info: driver.version: unknown","localizedMessage":"Could not start a new session. Error while creating session with the driver service. Stopping driver service: Could not start a new session. Response code 500. Message: Process unexpectedly closed with status 1\nBuild info: version: '4.0.0', revision: '3a21814679'\nSystem info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'\nDriver info: driver.version: unknown\nBuild info: version: '4.0.0', revision: '3a21814679'\nSystem info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'\nDriver info: driver.version: unknown","systemInformation":"System info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'","supportUrl":null,"cause":null,"stackTrace":[{"fileName":"DriverServiceSessionFactory.java","nativeMethod":false,"methodName":"apply","className":"org.openqa.selenium.grid.node.config.DriverServiceSessionFactory","lineNumber":184},{"fileName":"DriverServiceSessionFactory.java","nativeMethod":false,"methodName":"apply","className":"org.openqa.selenium.grid.node.config.DriverServiceSessionFactory","lineNumber":65},{"fileName":"SessionSlot.java","nativeMethod":false,"methodName":"apply","className":"org.openqa.selenium.grid.node.local.SessionSlot","lineNumber":143},{"fileName":"LocalNode.java","nativeMethod":false,"methodName":"newSession","className":"org.openqa.selenium.grid.node.local.LocalNode","lineNumber":315},{"fileName":"LocalDistributor.java","nativeMethod":false,"methodName":"startSession","className":"org.openqa.selenium.grid.distributor.local.LocalDistributor","lineNumber":513},{"fileName":"LocalDistributor.java","nativeMethod":false,"methodName":"newSession","className":"org.openqa.selenium.grid.distributor.local.LocalDistributor","lineNumber":440},{"fileName":"LocalDistributor.java","nativeMethod":false,"methodName":"handleNewSessionRequest","className":"org.openqa.selenium.grid.distributor.local.LocalDistributor$NewSessionRunnable","lineNumber":648},{"fileName":"LocalDistributor.java","nativeMethod":false,"methodName":"lambda$run$1","className":"org.openqa.selenium.grid.distributor.local.LocalDistributor$NewSessionRunnable","lineNumber":612},{"fileName":"ThreadPoolExecutor.java","nativeMethod":false,"methodName":"runWorker","className":"java.util.concurrent.ThreadPoolExecutor","lineNumber":1149},{"fileName":"ThreadPoolExecutor.java","nativeMethod":false,"methodName":"run","className":"java.util.concurrent.ThreadPoolExecutor$Worker","lineNumber":624},{"fileName":"Thread.java","nativeMethod":false,"methodName":"run","className":"java.lang.Thread","lineNumber":748}],"suppressed":[],"message":"Could not start a new session. Error while creating session with the driver service. Stopping driver service: Could not start a new session. Response code 500. Message: Process unexpectedly closed with status 1\nBuild info: version: '4.0.0', revision: '3a21814679'\nSystem info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'\nDriver info: driver.version: unknown\nBuild info: version: '4.0.0', revision: '3a21814679'\nSystem info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'\nDriver info: driver.version: unknown","rawMessage":"Could not start a new session. Error while creating session with the driver service. Stopping driver service: Could not start a new session. Response code 500. Message: Process unexpectedly closed with status 1\nBuild info: version: '4.0.0', revision: '3a21814679'\nSystem info: host: '3e81081e5010', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.49-linuxkit', java.version: '1.8.0_311'\nDriver info: driver.version: unknown","buildInformation":{"buildRevision":"3a21814679","releaseLabel":"4.0.0"}}

Got it working, thanks a lot man.


19483 - Staff Payment Restore

Issue #: /bcgov/entity#19483
Description of changes:

Ticket #19483
Updated App.vue to enable Staff Payment data saved and restored
Completed validation, checked unit tests have been added for new components and pages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-create-dev--pr-715-eb9xp2a6.web.app

I re-ran the failed jobs (esp upload to codecov) because they're not supposed to fail any more with @JazzarKarim 's fix yesterday. Hopefully they'll succeed this time.

^^ ignore failed test-coverage test for now

Very weird, it should've worked 😢 I'll have another look.

It worked for the PR you merged 2 hours ago Sev as well. Hmm, weird.

test-coverage

test-coverage still failed.
Is it ok to merge?


Feature: Canopies

[ ] Flat, half-block, steep slopes
[ ] Orientable along x-y-z planes
[ ] If placed as top block above solid block, model has wooden struts

Kicking the can on this again, now targeting 0.3.0.


Add test coverage for preserving manifest ordering

Fixes https://github.com/gradle/gradle/issues/2295
Context

This PR should be enough to demonstrate that manifest ordering is kept.
See https://gradle.slack.com/archives/C03A0MT6S/p1574340012011600?thread_ts=1574338665.010800&cid=C03A0MT6S
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@lacasseio this looks like it fails on Windows?

@big-guy Not only windows, this currently only adds a test case that fails and would succeed as soon as #2295 is fixed.

The intention of this PR was to show the scope of the intended fix to solve this issue. Unfortunately, there is a requirement to change only the part of how the manifest is written to disk which can't be done by simple modifying the code from the JDK due to licensing. Unless we can prioritize time for such task internally at Gradle, this PR is unlikely to move forward. If a someone want to contribute a PR of this issue feel free to pick up this PR. Until then, I'm closing this PR.


Fix typo in docs

🙂

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Messages from extensions do not close automatically

This was reported first by @dbaeumer and I can reproduce:
vscode.window.showInformationMessage('Hello World!');
Does not close automatically after 10 seconds like other messages from the workbench do that are just infos or warnings.
The reason is that https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/mainThreadMessageService.ts#L52 always adds a close action to the message even if no other actions are defined. That is not needed, a close action shows up automatically. However, when you pass in actions to message service, it will not automatically close the message assuming that user input is required.
I suggest to check if actions are provided and if so, just show the message like this:
if (!actions.length) {
	return this._messageService.show(severity, message);
}

This will cause the message to close according to the rules of the workbench message service. Only errors will stay.

This was done on purpose because I don't want extensions authors to (ab-)use the information/warning/error messages as lightweight status messages (which the API also offers). My reasoning is that the messages atop are quite disruptive and should be used with consideration and iff used make the user do something to acknowledge the presented information.
I would argue that the workbench behaviour is bogus because that 10sec delay is often leaving me puzzled what information was shown and if that was important? Also, I never know if I can wait-out a message or have to do something.
@stevencl and @bgashler1 for more input and feedback

The message UI deserves a facelift since years...

I am all in for a facelift. The thing that is confusing right now for me as a dev and as a user that message sometimes auto close and sometimes not. So for pure consistency that has to change.