[FR] Remove additional fetch calls during recurseRelators calls.

Is your feature request related to a problem? *
The Relator fetch method is excessively called during recurseRelators due to the algorithm neglecting to remove finished work from queue.
As an example:
Code:
  it("Should bypass recurse cycles after data fetched", async () => {
    type A = { id: string; prop: string }
    type B = { id: string; prop: string }
    let fetchCounter = 0

    const SerializerB = new Serializer<B>("b")
    const AtoBRelator = new Relator<A, B>(async (data) => {
      fetchCounter++
      return { id: "1", prop: "b" }
    }, SerializerB)

    const SerializerA = new Serializer<A>("a", {
      relators: { b: AtoBRelator },
    })

    const serialized = await SerializerA.serialize(
      { id: "1", prop: "a" },
      { depth: 10 }
    )

    console.log(fetchCounter)
  })

Output:
  console.log
    11

Describe the solution you'd like*
If the work is removed from the queue after resolving, the algo can exit earlier :) I will submit a followup PR.
Additional context
I believe there may be further optimizations possible to reduce duplicate fetch calls during serialization, but this is an easy first pass.

I'd really like to see the additional call removed as well. I'm prying around but I'm not seeing a simple patch to fix this.
First, are you itching to take a crack at this? I'd hate to spend my time working on this, only to find out we were both working in parallel. If you're busy elsewhere, I don't mind trying to take a stab at this, but I think I may see things differently than you (which I am sure is due to my limited exposure).
...here are my observations so far:
The fetch is called in two distinct places (perhaps there is more but these are the places getting hit in the code paths I see).

The Serializer, inside of the createResource method: relationships[name] = await relator.getRelationship(data);
Inside of the recurseRelators method.

As far as I understand, a cache cannot be added to the relator because that relator get's used across multiple serializations. The cache would need to be local to the serialize method being called (or instances that are scoped to the serialize method, such as the Resource).
My initial instinct would be to remove data fetching from the recurseRelators method, and instead rely on the fetch happening when creating the Resource relationships. The recurse method would then just pull the cached value from some sort of relationships cache living on the Resource.

Since we do not use this library in our stack anymore, we are looking to just maintain this, so you can take a stab at it.
Also, the cache I meant was local, not global, so our solutions are essentially the same (remove the tossing of the depth arg).
It might be worth noting that although this may save some calls, practically speaking, the solution is still far from optimal. Optimally, we should have a separate relationship fetcher (something that fetches table joins for example) and replace relationship data fetches with these ones. In this way, although we double fetch, we aren't double fetching the exact same (perhaps huge) resource, but rather we are fetching an identifier and it's resource separately when needed.

Ok. I have spent some time trying to plan how exactly this could be implemented and I have exactly one viable solution, but I wanted to discuss it prior to implementing. Jumping back to my message above, the reason duplicate calls are seen is due to the relators being fetched in two places (in order):

When populating the Resource Relationships during the createResource call.
During the recurseRelators step which is used to populate document.includes.

The solution, as I see it, is to cache the result found during the createResource call as it occurs first.
This is where I ran into the first challenge. relator.getRelatedData (fetch) is called within the body of relator.getRelationship method, which returns an instance of the Relationship model. So the tricky part is, if we can't change the publicly exposed API of the relator (the return value), how can we get the cached result up to our outer createResource method? The best solution I can see, is to pass a second argument which is capable of capturing the value.
relator
type CacheDataFn = <Data extends RelatedType | RelatedType[] | nullish>(data: Data) => Data
getRelationship(data: PrimaryType, cacheData: CacheDataFn) => {
  ...
  const relatedData = cacheData(await this.getRelatedData(data));
  ...
}

serializer
createResource() {
   ...
   relationships[name] = await relator.getRelationship(data, (data) => (resourceRelationshipsCache[name] = data));
   ...
}

And in similar nature, the createResource method returns a Resource model, so I'd need to thread the resourceRelationshipsCache in as some type of argument to the createResource method so that I can have access to the cache in the outer serialize method.
This cache could then be passed in and utilized in the recurseRelators util. Modifications would also have to be made within the recurseRelators internals to ensure it cached the relationships for each resource it creates.
It's not the prettiest of solutions, but it's the only solution I could devise that didn't semantically break the system (patching non-enumerable properties on to the model), and didn't cause any breaking changes to the publicly exposed APIs.

Sounds about right. If we are going with a non-breaking solution, we shouldn't expect it to be pretty. In fact, it should be pretty ugly.


ViewMode 2: can access the previous/next decade where all years are disabled

Expected behaviour
When the startView is set to 2, the upper arrows pointing to the previous or next decade should not be visible if that all the years in that decade are disabled due to the startDate/endDate options.
Actual behaviour
Unless selectedYear == startDate.year, the user can click on the upper left arrow and go to the previous decade where all options are disabled.
Similary, unless selectedYear == endDate.year the user can click on the upper right arrow and go to the next decade where all options are disabled.
Datepicker version used
1.6.4
Example code
https://jsfiddle.net/ua48nx09/4/
In this example you can go back to the previous decade and forward to the next decade, although that should be disabled.
If you select a date with the year = startDate.year (2014), the previous decade will be disabled as it should be. Similarly if you choose a date with year = endDate.year (2016), the next decade will be disabled.
Location of the problem in the code
The problem seems to be in the updateNavArrows function and especially here:
if (this.o.startDate !== -Infinity && year <= (this.o.startDate.getUTCFullYear()) || this.o.maxViewMode < 2) {
    this.picker.find('.prev').css({visibility: 'hidden'});
}

and here:
if (this.o.endDate !== Infinity && year >= this.o.endDate.getUTCFullYear() || this.o.maxViewMode < 2){
    this.picker.find('.next').css({visibility: 'hidden'});
}

+1 I stumbled over this bug today too.

Fixed in next release! Thanks @dmpalyvos!


Remove nested styling inside the .tbxforms class

https://github.com/torchbox/tbxforms/blob/main/tbxforms/static/sass/tbxforms.scss nests all the BEM classes created for the various form elements inside a .tbxforms class. This means that if you want to override the tbxforms styles, you have to write more nested code in the override.
.tbxforms   .tbxforms-error-message {
...
}

Is it possible to just remove the nesting in tbxforms.scss?

Given that all classes are prepended with .tbxforms-... (e.g. .tbxforms-clearfix instead of just .clearfix), the parent .tbxforms class can probably be removed.
I vaguely recall adding this to limit the scope only to affect tbxforms components and not interfere with the GOV.UK Design System that is installed separately, though I cannot say for sure.
A PR would be welcome :)!

MR now created: https://github.com/torchbox/tbxforms/pull/49


Update types to support ts 4.0

[x] tuple element labels
[x] LuaTuple variadic tuple type

https://github.com/roblox-ts/roblox-ts/issues/1062#issuecomment-670207072


Review and update your manifest and Gradle build settings

From https://developer.android.com/studio/publish/preparing.html:

Verify that the following manifest and build files items are set correctly:
 element
You should specify only those permissions that are relevant and required for your application.
android:icon and android:label attributes
You must specify values for these attributes, which are located in the  element.
android:versionCode and android:versionName attributes.
We recommend that you specify values for these attributes, which are located in the  element. For more information see Versioning your Application.
There are several additional manifest or build file elements that you can set if you are releasing your application on Google Play. For example, the android:minSdkVersion and android:targetSdkVersion attributes, which are located in the  element. For more information about these and other Google Play settings, see Filters on Google Play.

While I think that we have addressed all the issues in the previous comment, there are some inspection warnings in the AndroidManifest.xml that should be reviewed.


Pr/gray/ipsec proxy kpr revdnat ci test

Test CI changes in https://github.com/cilium/cilium/pull/33805

/test


checkov: 3.1.4 -> 3.1.9

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.1.4...3.1.9
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.1.9
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269047 run on x86_64-linux 1

2 packages built:

checkov
checkov.dist


Forms with :remote => true still requesting html even with :webkit driver

My form submits just fine when run manually in the browser. But with the webkit driver it requests html instead of js. Here's all the relevant code:
_edit.html.haml
=semantic_form_for [:admin, @business], :url => admin_business_path, :remote => true do |f|
 ...

gemfile
group :test do
  gem 'factory_girl_rails', :require => false
  gem 'timecop'
  gem 'database_cleaner'
  gem 'minitest'
  gem 'capybara', '>= 1.1.2'
  gem 'launchy'
  gem 'turn'
  gem 'guard-minitest'
  gem 'capybara-email'
  gem 'capybara-webkit'
  gem 'capybara_minitest_spec'
end

minitest_helper.rb
ENV["RAILS_ENV"] = "test"
require File.expand_path("../../config/environment", __FILE__)
require "minitest/autorun"
require "capybara/rails"
require "active_support/testing/setup_and_teardown"
require "factory_girl_rails"
require 'database_cleaner'

class IntegrationTest < MiniTest::Spec
  include Rails.application.routes.url_helpers
  include Capybara::DSL
  include Capybara::Email::DSL
  register_spec_type(/integration$/, self)
  Capybara.javascript_driver = :webkit
end

business_integration_test.rb
require 'minitest_helper'
require 'ruby-debug'

describe "Business integration" do

  before :each do
    Capybara.javascript_driver = :webkit
    Capybara.current_driver = Capybara.javascript_driver
    @business = Factory.build(:presaved_business)
  end

  def login
    [...]
  end

  describe "Your Business", :js => true do

    it "Should show error if business name is blank" do
      login
      fill_in 'Name', :with => ''
      save_and_open_page
      click_button 'Save'
      save_and_open_page #opens a blank page -- work fine when run manually in browser
      page.must_have_content "can't be blank"
    end
  end
end

experiencing the same. using my app in the browser is working but doing the same with capybara the format does not appear to be set to js and i can see in the log that rails is searching the view to be rendered with formats: [:html].
does not work with neither :webkit nor :poltergeist.
now, apparently i'm too stupid to get :webkit_debug to output anything.
fwiw:

ruby (2.1.3)
capybara (2.4.4)
poltergeist (1.5.1)

@glaszig what version of capybara-webkit are you using? Can you show some code from the spec, your log, and the view you're testing? Can you paste the error/output you get when using :webkit_debug?

Having the same issue.
capybara 2.5.0
capybara-webkit 1.7.1
minitest-rails-capybara 2.1.1
ruby 2.1.4p265
Here's the test:
should "step through activate first device sequence", :js => true do
  visit root_path
  fill_in "user_email", :with => @user_no_devices[:email]
  fill_in "user_password", :with => @user_no_devices[:password]
  click_button "SIGN IN"

  fill_in "claim_serial", :with => "xxxx"
  click_button "ACTIVATE"

  page.has_content?("device successfully added.")
  page.has_content?("SETTINGS")

  fill_in "device_description", :with => "claimed device"
  page.find(:fillable_field, "alarm_delay").set(6)
  click_button("next_button")

  page.has_content?("WIFI SET UP")
  find_link("NEXT >>").click

  page.has_content?("MONITORING SERVICES")
  click_link("skip_button")
end

It never finds the "NEXT >>" link because once the next_button is clicked it should run some javascript which will redirect to another page, but because the form is submitted as an html request, this never happens and the page never loads. Instead, it loads a blank page because there is no view associated with that action. This is my respond to block for the action:
respond_to do |format|
  format.js { render :nothing => true, :head => :ok }
end

This is the webkit_debug output that seems relevant:
Load started
Started request to "http://<IP_ADDRESS>:60169/monitored_devices/1009/notification_settings"
Received "FindXpath(/html)"
"TimeoutCommand" waiting for load to finish
Received 500 from "http://<IP_ADDRESS>:60169/monitored_devices/1009/notification_settings"
Page finished with true
Load finished
Started "FindXpath(/html)"
Finished "FindXpath(/html)" with response "Success(1)"
Wrote response true "1"
Received "Node.visible"
Started "Node.visible"
Finished "Node.visible" with response "Success(true)"
Wrote response true "true"
Received "Node.text"
Started "Node.text"
Finished "Node.text" with response "Success(Internal Server Error

ActionController::UnknownFormat
WEBrick/1.3.1 (Ruby/2.1.4/2014-10-27) at <IP_ADDRESS>:60169)"
Wrote response true "Internal Server Error

ActionController::UnknownFormat
WEBrick/1.3.1 (Ruby/2.1.4/2014-10-27) at <IP_ADDRESS>:60169"
Received "Reset()"

For the record, this test used to run with javascript but has recently broke.

@type-face  This is usually caused by errors in your JS -- in development mode each of your JS files are served individually so an error in one doesn't prevent the rest from executing, however in test mode they get concatenated together so an error in one of your JS files can/will prevent things like jquery-ujs from being initialized.   Check your javascript console for errors.

@twalpole Thanks for the reply. I don't think that's the issue, though. The javascript runs fine on production without any js errors. It's definitely submitting the form as an html request, not a javascript request.

Just to add to my scenario above, when I look at the request object within the respond_to method I can see that action_dispatch.request.accepts and action_dispatch_request.formats is specified in development:

"action_dispatch.request.accepts"=>   [#Mime::Type:0xa885cd4 @string="text/javascript", @symbol=:js, @synonyms=["application/javascript", "application/x-javascript"],
#Mime::Type:0xc954640 @string="application/ecmascript", @symbol=nil, @synonyms=[],
#Mime::Type:0xc9545f0 @string="application/x-ecmascript", @symbol=nil, @synonyms=[],
#Mime::Type:0xc9545a0 @string="/", @symbol=nil, @synonyms=[]],
"action_dispatch.request.formats"=>  [#Mime::Type:0xa885cd4 @string="text/javascript", @symbol=:js, @synonyms=["application/javascript", "application/x-javascript"]>,
#Mime::Type:0xc954640 @string="application/ecmascript", @symbol=nil, @synonyms=[],
#Mime::Type:0xc9545f0 @string="application/x-ecmascript", @symbol=nil, @synonyms=[],
#Mime::Type:0xc9545a0 @string="/", @symbol=nil, @synonyms=[]]},

However, when I run the test with capybara, action.dispatch.requests.accepts does not exist and action.dispatch.request.formats is set to html:

"action_dispatch.request.formats"=> [#Mime::Type:0xb62d364 @string="text/html", @symbol=:html, @synonyms=["application/xhtml+xml"]]},

@type-face  jquery-ujs (assuming your using jQuery) is what makes links with remote: true submit as ajax requests rather than doing a normal html post, so if it isn't initializing properly it will do normal html posts instead of ajax.   Production mode working isn't really a verification that you don't have any JS errors because it (rails default config) runs the JS through uglifier which strips console.log/debugger/etc statements from the file (test mode doesn't by default run uglifier)- so if you had errors in any of those lines it would still work fine in production.  Are you 100% sure that you're not seeing any errors at all in the console in dev mode on the page you're seeing this error on?

These are the only two warnings I get in the console for the page:

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create d3.v3.min.js:3:100

Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.

Could the getPreventDefault() be causing it?

I stand corrected @twalpole. I updated my jquery-rails gem and that seemed to do the trick! Thanks for the help!


I ran into a number of problems while going through this documentation

Install-Module MSOnline gave an error as follows:
Could not retrieve modules repository from 'https://github.com/psget/psget/raw/master/Directory.xml'.

This one was solved by prefixing the command like so powershellget\Install-Module MSOnline

After being prompted for my username and password, I got an invalid username or password error.

I thought this was quite weird since I use a password manager. I tried again and it still didn't work.
Next I tried a previously used password and to my surprise this worked.
Then I tried signing into my account on the web with the previously used password and it didn't work (strange)
Signing in on the web with the newer password works!
So it seems that my password is stored twice in 2 difference systems!?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbb1fe83-c1b3-3176-4d61-fe4f3ce1d598
Version Independent ID: c89f295b-4f00-c2c0-c75f-75fa50ecda65
Content: Connect to Office 365 PowerShell
Content Source: Enterprise/powershell/connect-to-office-365-powershell.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@grdylan, I tried the instructions on a new virtual machine and it worked as documented. If you want to pursue a solution to this problem, please contact Microsoft Support at https://support.microsoft.com/contactus/. Thanks


get options in config_example.py reachable

Some options in config_example.py are not reachable. It makes users
confused. So make the options in the file as gobal_alias.
Signed-off-by: zhizhou.zhang<EMAIL_ADDRESS>

Thanks a lot of this!


Hover and dragover states appear for only an instant and then end

Aframe v0.5.0
FF 54
Chrome 56

sphere-collider issue fixed f88877b


ChainRules rrules_tests fail on Matrix implementation

https://github.com/invenia/BlockDiagonals.jl/runs/1554434593
I believe the changes that produced this error were introduced in https://github.com/invenia/BlockDiagonals.jl/pull/47
Matrix: Test Failed at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:33
  Expression: eachindex(actual) == eachindex(expected)
   Evaluated: Base.OneTo(1) == Base.OneTo(12)
Stacktrace:
 [1] #check_equal#10(::Base.Iterators.Pairs{Symbol,Float64,Tuple{Symbol,Symbol},NamedTuple{(:rtol, :atol),Tuple{Float64,Float64}}}, ::Function, ::Array{Array{Array{Float64,2},1},1}, ::Array{Float64,2}) at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:33

Array{Array{Array{Float64,2},1},1}[1]: Test Failed at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:33
  Expression: eachindex(actual) == eachindex(expected)
   Evaluated: Base.OneTo(2) == Base.OneTo(1)
Stacktrace:
 [1] #check_equal#10(::Base.Iterators.Pairs{Symbol,Float64,Tuple{Symbol,Symbol},NamedTuple{(:rtol, :atol),Tuple{Float64,Float64}}}, ::Function, ::Array{Array{Float64,2},1}, ::Array{Float64,0}) at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:33

Test threw exception
  Expression: isapprox(actual, expected; kwargs...)
  MethodError: no method matching isapprox(::Array{Float64,2}, ::Float64; rtol=1.0e-9, atol=1.0e-9)
  Closest candidates are:
    isapprox(!Matched::Missing, ::Any; kwargs...) at missing.jl:69
    isapprox(!Matched::DoesNotExist, ::Any; kwargs...) at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/deprecated.jl:6
    isapprox(!Matched::Zero, ::Any; kwargs...) at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/deprecated.jl:8

Got exception outside of a @test
  BoundsError: attempt to access 0-dimensional Array{Float64,0} at index [2]
  Stacktrace:
   [1] getindex at ./array.jl:731 [inlined]
   [2] macro expansion at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:35 [inlined]
   [3] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Test/src/Test.jl:1156 [inlined]
   [4] #check_equal#10(::Base.Iterators.Pairs{Symbol,Float64,Tuple{Symbol,Symbol},NamedTuple{(:rtol, :atol),Tuple{Float64,Float64}}}, ::Function, ::Array{Array{Float64,2},1}, ::Array{Float64,0}) at /home/runner/.julia/packages/ChainRulesTestUtils/1g1Cb/src/check_result.jl:34

Ah it is a problem with how
https://github.com/JuliaDiff/ChainRulesTestUtils.jl/pull/57
stopped using isapprox for testing, becuase it was gross.
But turns out that BlockDiagonals was relying on this, and was overloading isapprox.
I will either add support for isapprox back,
or fix it so isapprox isn't needed in this case


Not detect a new module added in the project

I compiled de Object detection desktop project and it worked property.
After that I created two new modules to create new functionality but the project does not detect the modules added and I get this compilation error:

Does someone know how could I solve it?
Thank you so much.

Hi @Ncuaresma ,
Could you please elaborate this issue to investigate further.

Hi @sureshdagooglecom my issue is that I created a class 2 new classes (frame and box) in mediapipe with their correspond files .c and .h, they compile themselves property.
Now I am trying to add some of the functionality I created in the project Object detection, but when I compile everything together the modules I created are not detected so the build fails. (Error in the picture I added before)
I suppose is something about adding dependencies in some files, or something that the builds checks before going to the folder where are located and where I have not added them and so the build does not find these files.

Hello @sureshdagooglecom, to give you more explanation about what I want to do.
I would like to get the object boxes obtained in each frame in the example and after calculate de distance from the camera to the object.
So I have coded the functionality but I can not incorporate it to the example code, the modules I created are not detected.
Thank you,

Hi @Ncuaresma ,
It looks like some source files are not found during compilation.  Could there be a missing dependency in your new build targets?  Can you include your new build target def in the bug report?


getValue() error

Version 2.4
Sometimes $weather->wind->direction is NULL
getValue() on this throws fatal error.
I think, getValue() method must check own content

Thank you for raising this issue. AFAIK, this could only happen for weather group data. I fixed that in https://github.com/cmfcmf/OpenWeatherMap-PHP-API/commit/d55e0665ff08d5e10d940853455e9b30780e0cba

Nice. But in this version you use excessive libraries :(
At my small site I can't use version 2+ :(

Hi @KarelWintersky,
Could you elaborate a bit more on why the requirement to install additional libraries prevents you from using this library? I am trying to understand what prevents you from installing them. Or is the jump in the required PHP version from 5 to 7 the issue?

I wrote about this problem here: https://github.com/cmfcmf/OpenWeatherMap-PHP-API/issues/136

However, most bigger projects will likely already have PSR-17/18-compatible libraries installed.

My project is small, frameworkless. And, I hope, quick and perfomance-oriented. I can't use a lot of libraries.
Also, with 'recommended' libraries it does not work.

Also, with 'recommended' libraries it does not work.

It appears to be working on my end. To test it, I created a new composer.json file with the following contents and ran composer install:
{
    "name": "root/app",
    "require": {
        "cmfcmf/openweathermap-php-api": "^3.0",
        "http-interop/http-factory-guzzle": "^1.0",
        "php-http/guzzle6-adapter": "^2.0"
    }
}

I then executed the example code from the README using PHP 7.3.5 successfully.

Our production server uses PHP 7.0.11 now :(

Our production server uses PHP 7.0.11 now :(

Ahh, I see. I haven't checked all dependencies, but on a quick glance it seams that at least the php-http/guzzle6-adapter library requires PHP 7.1+.  Given that PHP 7.0 is EOL for more than a year now, I don't think it is feasible for me to invest the necessary time to make the example work with PHP 7.0. I know that upgrading PHP versions isn't alsways possible or easy, but I suppose you could continue using version 2.3 of this library for now and backport your fix to to it.


Support Bottom Page Indicator Text

Add support to show content page text indicator at the bottom of the screen for each page content.
Specs:

[x] Change the current page according to content index changes
[x] Static text in container view (non-scrollable)
[x] iPhone X support

Added. #11


treewide: support NIX_SSL_CERT_FILE as an impureEnvVar

Description of changes
tl;dr this PR makes NIX_SSL_CERT_FILE the preferred way to control CA certificates throughout nix, by allowing it to be set as in impureEnvVar, including it in proxyImpureEnvVars, and ensuring fetchers support it.

Nix (the executable) as well as much of its packaged software respects NIX_SSL_CERT_FILE as the preferred way to specify a custom set of root certificates. Within derivations, this is typically done by the setup hook of cacert.
However, there's no way to inject this variable from outside (with impure env vars used in fetchers). This is required for most use cases of an an https proxy, as the proxy's own certificate will not likely be trusted by nix's builtin cacert package.
Functionality for injecting a custom trust store has been added to fetchgit, but because the setuphook will always override NIX_SSL_CERT_FILE, a different envvar had to be used (NIX_GIT_SSL_CAINFO). I have an open PR to add this same customisation to the go module fetcher.
However, it'd be preferable if we didn't invent a new envvar, and instead made NIX_SSL_CERT_FILE the single way to control this setting for both fetchers and nix itself.
For this to work, we need two small changes:

cacert should only set this variable if it's not already set, so that any impure version is not overwritten

this is in a setuphook so it's a mass rebuild

add "NIX_SSL_CERT_FILE" to proxyImpureEnvVars (fetcher.nix). It's not strictly a proxy-only variable, but:

this needs to be overridden for all HTTPS proxy use cases, and most things are https these days. Currently fetcher support for custom certs is patchy, because they're all doing their own thing (see below notes)
using the certificates the system has explicitly set for nix (if any) is inline with user expectations even outside proxy setups, and this only affects fixed-output derivations anyway

Various fetchers current (and updated) behaviour is oulined below:

fetchgit: previously added explicit support for NIX_GIT_SSL_CAINFO as the impure overrideable version. This is still supported, but the standard NIX_SSL_CERT_FILE now works and is preferred.
fetchurl: passes --insecure to curl for a fixed-output derivation, so I guess it doesn't need modification
fetchgomodule: previously no support for custom certs for git dependencies, now sets GIT_SSL_CAINFO to the value of NIX_SSL_CERT_FILE using whatever's provided by the user / setup hook

Looking through other fetchers, it seems most of them either have their own schemes or delegate to fetchurl. So this isn't a wide-reaching code change, but I think it's important to support NIX_SSL_CERT_FILE as an impureEnvVar, so that we don't force fetchers to invent their own envvars for this purpose.
Things done
Since this is a mass-rebuild, I tested locally by only applying these changes to the version of cacert used by fetchers. With these modifications I tested fetching over https (using custom certs) with:

fetchurl
fetchgit (over https)
go modules fetch (git https)

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I thought we should use the cert in fetchurl instead of using --insecure. See my PR https://github.com/NixOS/nixpkgs/pull/259179.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3252

Pinging a couple folks who've been involved in this area previously, I'd appreciate any reviews you have time for 🙏
@vcunat @roberth

Good idea, I've added a "Proxy usage" section in the nixpkgs fetchers chapter.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-buildproxy-reproducible-http-https-responder-in-sandboxed-nix-builds/40081/9

Oh dear, I've pushed the wrong branch and it wants the world to review it. I'll open a new PR to avoid notification chaos 🤦


Fix tests

The jest tests are currently failing if Babel stage-0 or decorators are used.

Also worth mentioning jest tests fail if a file imports .scss, .styl, or .less style sheets. Besides that, this project is gold.

@karbica it was fixed by my PR but isn't published yet

@lukaszgolder is babel-stage-0 also fixed, or just styles?

@kitze No, I was only referring to error with stylesheets. But I am using some stage-3 features in my project and didn`t come into any error yet.


About the Figure 14 in the paper

Hello, @vignywang -I really appreciate for your work！Congratulations :)
The Figure 14(attention maps) in the paper looks great. Currently I want to try to implement it but I failed. Is it convenient to provide the relevant implementation code?Of course, detailed guidance would be better.
I am always looking forward to your kind response.
Best regards.

Thank you for your interest. The full training and visualization code will be released within a month.


[Toothpick] Device Support Form

Extension
https://www.raycast.com/briankosw/toothpick
Description
Device brand and model
Beats Flex
Device data
{"Beats Flex":{"device_address":"74:8F:3C:0B:73:25","device_firmwareVersion":"3.7.2","device_minorType":"Headphones","device_productID":"0x2010","device_rssi":"-61","device_serialNumber":"FL6GMGHSQ1HL","device_services":"0x880019 < HFP AVRCP A2DP AACP ACL >","device_vendorID":"0x004C","device_connected":"true"}}
Who will benefit from this feature?
No response
Anything else?
No response

I wanted to raise an issue for Bose Headphones and even Magic Mouse 2, then realised that I haven't checked permissions from my side. So after going to "System Settings >> Privacy & Security >> Bluetooth" and adding Raycast as a trusted app the problem was resolved. Leaving it here just in case. Peace!
P.S.
@briankosw  / @VladCuciureanu GREAT EXTENSION, BLESS UP  🤍👏🏻

@maximuscode Glad you like the extension! Thanks for sharing the solution
@adamarbour Hey! While I do appreciate your submission, this device is mapped already.
Given the fact that there's no extra info added I'll close this ticket.
@raycastbot close this issue


New Crowdin updates

:tada: This PR is included in version 0.29.0 :tada:
The release is available on:

v0.29.0
GitHub release

Your semantic-release bot :package::rocket:


Add requestId policy implementation

Please fix the random generation in the constructor. Constructor shouldn't be generatin a random Uuid - a static "create/generate" method should.
And also naming, it should be Uuid, not UUID. During our last meeting, we agreed on only all-capitalizing 2-letter acronyms. 3 or more is only first letter capitalized.
Given that these two things are not fixed, I feel like not all the feedback was fixed, and we should go to resolve all the comments here (either by fixing or won't fixing with some extent of an agreement).


rx is super high

the one in f3. it was like ~200rx when there was nothing

This seems to be the average number of s2c packets received per tick. This seems like a reasonable number depending on how many players there are to send player updates for.

docs say it is per tick but it actually per second I think.


NullPointerException in IDEA 15.0.2 after some time

Hello,
after returning to IntelliJ IDEA (from suspend or overnight locked computer) the plugin fails with NPEs and IDE restart is required to fix it. Windows and Linux alike.
(Might be imagining this but I think this problem existed in IntelliJ IDEA 14 in the beginning as well but was fixed later on).
null
java.lang.NullPointerException
	at com.urswolfer.intellij.plugin.gerrit.ui.RepositoryChangesBrowserProvider$GerritRepositoryChangesBrowser$3.consume(RepositoryChangesBrowserProvider.java:145)
	at com.urswolfer.intellij.plugin.gerrit.ui.RepositoryChangesBrowserProvider$GerritRepositoryChangesBrowser$3.consume(RepositoryChangesBrowserProvider.java:142)
	at com.urswolfer.intellij.plugin.gerrit.rest.GerritUtil$18$1$1.run(GerritUtil.java:620)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.a(LaterInvocator.java:337)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:321)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at com.intellij.ide.IdeEventQueue.f(IdeEventQueue.java:866)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:654)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

@zeratul021: This trace looks really strange. but I have received some others which look like quite equal via exception reports. It looks like the change cannot be read on your Gerrit server anymore.
Could it be that you have lost your Gerrit session? Do other operations like refreshing the change list still work?

@uwolfer IIRC the refreshing and filtering didn't work as well. I can try to let it sleep tomorrow evening and play around Friday morning.

@uwolfer Hi, I have the same issue. It happens after some time of inactivity, when presumably the Gerrit session times out. I can filter the waiting code reviews, but when I select one of them to display the diff I get a null pointer instead. Interestingly enough, Intellij doesn't ask to unlock it's password store in these cases.

@sjelen: Just to ensure that I correctly understand your issue: you can see in the list of changes all your changes (even after a refresh), but when you select it, it fails with an error?

@uwolfer I can apply the "Reviewer: Me" filter, and list of reviews assigned to me is correctly shown. The diff windows shows the diff from the last selected code review, which is outdated. Nothing is selected in the list of changes for review. When I select one of the changes, I get the NPE.

@sjelen and @zeratul021: What's the version of the Gerrit server you are connected to?

@uwolfer Gerrit version is 2.8.1

@zeratul021: Can you please also answer my questions above? Probably we can find some commonalities.

@uwolfer sorry I didn't reply before, we are on the same team = same environments. Unfortunately I was not able to reproduce this again. I keep IDEA running during night, I'll see in the morning.

I clicked refresh today and when I tried to select any of the changes I got NPE. Filters do work, the information panel below updates (change-id, author...) but the diff panel doesn't change.
null
java.lang.NullPointerException
	at com.urswolfer.intellij.plugin.gerrit.ui.diff.CommentsDiffTool$3.consume(CommentsDiffTool.java:156)
	at com.urswolfer.intellij.plugin.gerrit.ui.diff.CommentsDiffTool$3.consume(CommentsDiffTool.java:153)
	at com.urswolfer.intellij.plugin.gerrit.rest.GerritUtil$18$1$1.run(GerritUtil.java:620)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.a(LaterInvocator.java:337)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:321)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at com.intellij.ide.IdeEventQueue.f(IdeEventQueue.java:866)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:654)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

If you have admin access, I suggest you to try to set a higher web_sessions timeout (see https://gerrit-review.googlesource.com/Documentation/config-gerrit.html or https://code.google.com/p/gerrit/issues/detail?id=781). If it does not happen anymore then, we know that this issue is because of the login caching mechanism.
Also, I suggest updating to a more recent version of Gerrit (not just because of this issue). It should not be that hard to update.

Thanks - I will speak to our DevOps/Infra team and see what can be done.

@uwolfer so the issue seems to be gone after Gerrit upgrade to 2.11.5


Error retrieving public link during file download using gdown in nerfstudio environment

When attempting to download data using gdown in a nerfstudio environment, an error occurs stating that the public link of the file cannot be retrieved. The error suggests checking if the file's sharing settings are set to 'Anyone with the link' and mentions the possibility of too many accesses to the file. Further, attempting to access the provided Google Drive URL directly in a browser results in a 404 error.
Environment
Operating System: Windows
Python version: [version used in nerfstudio environment]
gdown version: [version used]
Command Executed:
ns-download-data nerfstudio --capture-name=poster
Error Message
Traceback (most recent call last):
File ".conda\envs\nerfstudio\lib\site-packages\gdown\download.py", line 253, in download
url = get_url_from_gdrive_confirmation(res.text)
File ".conda\envs\nerfstudio\lib\site-packages\gdown\download.py", line 54, in get_url_from_gdrive_confirmation
raise FileURLRetrievalError(
gdown.exceptions.FileURLRetrievalError: Cannot retrieve the public link of the file. You may need to change the permission to 'Anyone with the link', or have had many accesses. Check FAQ in https://github.com/wkentaro/gdown?tab=readme-ov-file#faq.
...
Steps to Reproduce
Set up nerfstudio environment on Windows.
Run the command ns-download-data nerfstudio --capture-name=poster.
Observe the error output.
Expected Behavior
The file should download without any errors regarding the retrieval of the public link.
Actual Behavior
The download fails with an error about not being able to retrieve the public link of the file. Additionally, accessing the file directly via the provided Google Drive URL results in a 404 error.

[ping]
what does "not planned" mean here? This is still a sample operation in the docs, basically the Nerfstudio Hello World; if the link is no longer available, shouldn't the docs be changed?

[ping] what does "not planned" mean here? This is still a sample operation in the docs, basically the Nerfstudio Hello World; if the link is no longer available, shouldn't the docs be changed?

Since I found the issue, I realized that I didn't download the latest development version but installed it directly from pip. In the latest development version, the link is valid. Therefore, I would like to close the issue I raised.

thanks for the clarification!
On Fri, May 17, 2024 at 12:52 AM Jqliany @.***> wrote:

[ping] what does "not planned" mean here? This is still a sample operation
in the docs, basically the Nerfstudio Hello World; if the link is no longer
available, shouldn't the docs be changed?
Since I found the issue, I realized that I didn't download the latest
development version but installed it directly from pip. In the latest
development version, the link is valid. Therefore, I would like to close
the issue I raised.
—
Reply to this email directly, view it on GitHub
https://github.com/nerfstudio-project/nerfstudio/issues/3099#issuecomment-2116959705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACT5ALQNZLIYNES3T2BBJS3ZCWZJFAVCNFSM6AAAAABGRHWVVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHE2TSNZQGU
.
You are receiving this because you commented.Message ID:
@.***>


rpc: remove the fallback options for device info in rpc service

Fixes #22266
Change Overview

Do not use the config macro values as fallback and return error

Tests

Successfully built the all-clusters-app/esp32 with CONFIG_ENABLE_PW_RPC=y option enabled .

@rgoliver PTAL!


Config file and/or environment variables

I didn't want to add a config file...But sometimes certain default behaviours are annoying, but maybe still should be default.
For instance:
%>zht search -r 'git clone.*myrepo.git'
:<PHONE_NUMBER>:2;git clone git@github.com:myuser/myrepo.git

When I am searching I don't usually want to know the time, and if I do maybe I want the time to be human readable?
Later maybe I want to define my own format...?
I think the default functionality is fine by default, but my cases are changing.  So a mechanism needs to be implemented to apply certain behaviours by default - either a config file, or a suite of Environment Variables (or both!) that are checked and alter behaviour.
Possibly everything should be configurable externally, but thoughts:

Output command only in searches (#19)
Define default output format (#18)
Set human readable timestamps by default

Consider: https://github.com/spf13/viper


EdDSA: add validate-after-sign

https://github.com/openpgpjs/noble-curves/commit/559e53c4293d9f858e2fa74502c1c37fba6a90b5
@larabr a pr would be highly appreciated!

Sure, I can open it. FWIW we are still gathering some stats to understand if this sort of bitflips do happen in the wild. Let me know if you want to add this feature regardless 👌

It's only few lines of code - seems useful "just in case".

(Sorry but I haven't gotten around to opening the PR yet).
FYI there is now an RFC draft about non-deterministic EdDSA signature to tackle the underlying issue: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-det-sigs-with-noise-03 . I think implementing that variant is probs a better solution for people who do not care about the deterministic result 🙂


Code folding does not appear if code is not properly formatted

VSCode Version:0.10.11
OS Version: Windows 7 Enterprise, Service pack 1

Steps to Reproduce:
//paste this code ( GO ), code folding stops working for all code after it.
func recursiveSum(array []int) int {
return sumRecursive(array, 0, len(array)-1) //no space before and after -
}
//code folding starts to work if re-written as [ notice the space after len(array) ]
func recursiveSum(array []int) int {
return sumRecursive(array, 0, len(array) - 1 ) //space after -
}

This is as designed, the code folding is based on indentation.
Semantic based/AST based code folding is on the backlog
// @aeschli

I think it'll be an often inconvenience for developers. A common example is to disregard indentation when specifying an inline html template in a javascript file. Here is an example from angular app::
export function componentDirective(): ng.IDirective {
    return {
        template: `

There's going to be a lot of html here and having its indentation start from the beginning is helpful in this case

`,
        scope: true,
        controllerAs: '$ctrl',
        bindToController: true,
        controller: componentController
    }
}

We have issue #3422 for adding semantic folding.


[KOGITO-2218] Setup new regex for images

to include registry port
https://issues.redhat.com/browse/KOGITO-2218
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster

@MarianMacik do you mind to take a look?


Fixing bug with extra indentation after lambda arrow

Fixes https://github.com/pinterest/ktlint/issues/479

LGTM 👍
Generally, for lambdas, according to kotlin styleguide, this rule should format either to:
foo.func { param1, param2 ->
    doSomething()
    doSomething2()
}

or, if lambda params can't fit in max line:
foo.func {
    param1,
    param2
    ->
    doSomething()
    doSomething2()
}

Thanks; I did notice that as well. I'll open up another issue about moving params to the same line as the open bracket. It might be difficult to have it not conflict with the max_line_length rule. It looks like IntelliJ only moves the params if they're on the same line as the arrow, so we can follow that rule as well.


Clean up metrics code slightly.

Changes

Deduplicate some logic that could otherwise get out of sync with itself
Replace a duration computation for which there is already a method in the stdlib

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

@ijschwabacher Thanks! Could you sign the CLA?

/ok-to-test

/kind misc

/retest

/retest

Is this test a known flake? It's not obvious to me how the change in question could have caused that failure.

Is this test a known flake? It's not obvious to me how the change in question could have caused that failure.

unfortunately yes - https://github.com/tektoncd/pipeline/issues/6624
/retest


Provide source links

Related to #8
For the source links I need the correct webpage URLs. Currently I only know it for WRiMS.

[x] "Ad hoc alien species checklist"
[x] "Alien Bird Checklist"
[x] "Alien Fish Flanders"
[x] "Alien Macroinverts"
[x] "Alien Mollusc checklist"
[x] "Belgian rust fungi"
[x] "Manual of Alien Plants"
[ ] "RINSE1"
[ ] "RINSE2"
[x] "WRiMS" https://www.marinespecies.org/

For my reference: To be completed here

they should all be easily found through the TrIAS community page https://www.gbif.org/network/b153643d-735a-440f-a0e9-428b4f9d1cd2/dataset

Can I just refer to the GBIF datasets page then? E.g. for
"Add hoc alien species checklist" https://www.gbif.org/dataset/1f3505cd-5d98-4e23-bd3b-ffe59d05d7c2

I would say for those available on gbif => YES

What's the difference between RINSE1 and RINSE2? Guessing right now which one is 1 and 2..
Current links:
"Ad hoc alien species checklist" = "https://www.gbif.org/dataset/1f3505cd-5d98-4e23-bd3b-ffe59d05d7c2",
"Alien Bird Checklist" = "https://www.gbif.org/dataset/e1c3be64-2799-4342-8312-49d076993132",
"Alien Fish Flanders" = "https://www.gbif.org/dataset/98940a79-2bf1-46e6-afd6-ba2e85a26f9f",
"Alien Macroinverts" = "https://www.gbif.org/dataset/289244ee-e1c1-49aa-b2d7-d379391ce265",
"Alien Mollusc checklist" = "https://www.gbif.org/dataset/e082b10e-476f-43c1-aa61-f8d92f33029a",
"Belgian rust fungi" = "https://www.gbif.org/dataset/b043c480-dd36-4f4f-aa82-e188753ff09d",
"Manual of Alien Plants" = "https://www.gbif.org/dataset/9ff7d317-609b-4c08-bd86-3bc404b77c42",
"RINSE1" = "https://www.gbif.org/dataset/1738f272-6b5d-4f43-9a92-453a8c5ea50a",
"RINSE2" = "https://www.gbif.org/dataset/3f5e930b-52a5-461d-87ec-26ecd66f14a3",
"WRiMS" = "https://www.gbif.org/dataset/0a2eaf0c-5504-4f48-a47f-c94229029dc8")

Looking at the publication/modification dates I would presume this one https://www.gbif.org/dataset/3f5e930b-52a5-461d-87ec-26ecd66f14a3 is RINSE 1 (May 15, 2019) & this one https://www.gbif.org/dataset/1738f272-6b5d-4f43-9a92-453a8c5ea50a would be RINSE 2 (May 11, 2021) then ?

@LienReyserhove can you confirm?

I don't think I can be of any help here. I know the link between the original dataset and the publication on GBIF, but I have no idea who and on what basis it whas decided to assign the names "RINSE 1" and "RINSE 2" to the datasets. I'm lacking context for this

RINSE pathways: dataset on GBIF, original dataset, 359 species names
RINSE registry: dataset on GBIF, original dataset, 6643 species names

Implemented as in https://github.com/inbo/alien-species-portal/issues/22#issuecomment-1175170162


arch: arm: Disallow FP_HARDABI when building with TFM

When building with TFM, the app is linked with libraries built by the
TFM build system. TFM is always built with -msoft-float which is
equivalent to -mfloat-abi=soft. FP_HARDABI adds -mfloat-abi=hard
which gives errors when linking with the libs from TFM since they are
built with a different ABI.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/33956
Signed-off-by: Øyvind Rønningstad<EMAIL_ADDRESS>

Do we have the ability to build TFM w/hard float ABI?  Is this a change we need to the TFM build system to allow this?

Do we have the ability to build TFM w/hard float ABI? Is this a change we need to the TFM build system to allow this?

I am going to investigate this @galak.
In the mean time, I am not sure we can accept dropping the HARD ABI just like that; this does not allow the compiler to use the FP coprocessor efficiently....

In the mean time, I am not sure we can accept dropping the HARD ABI just like that;

Not sure I follow, hard abi is causing build failures when using TF-M, so we would not be dropping support for anything cause the support has never been there when enabling TF-M.
So this simply ensures users are informed at an early stage.


Refs #28458 -- Added validate_choices to ModelMultipleChoiceField.

I fixed the review findings from: https://github.com/django/django/pull/7181
Co-authored-by: blueyed<EMAIL_ADDRESS>

@gasparb16 Thanks for your effort! :+1:
Closing per ticket.


Some updates to your presented information

Howdy,
This blog https://blog.ltgt.net/maven-is-broken-by-design/ was written in 2013 (11 years ago), and many (not all) statements from it are simply not true anymore in Maven (3.9.6 is latest), especially the "Repositories are all checked for all dependencies" (which, AFAIR was in fact never true) as since 3.9.0 there is RRF https://maven.apache.org/resolver/remote-repository-filtering.html
Shrinkwrap OTOH moved to MIMA https://github.com/maveniverse/mima and new upcoming CLI is https://github.com/maveniverse/toolbox
Have some fun trying those out!
Have a nice day :smile:

Moreover, Resolver got "open scope" system (example how are today mvn3 and mvn4 that has some new dependenct scopes introduced):
https://github.com/apache/maven/tree/691e3780e6cd86f7ce2e3ed51ecd016acc984368/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes
The "path" (where dependency goes, classpath or module path) is new upcoming Maven4 feature:
https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
As IMO that is not part of coordinate (you can have a JAR used as CP but also as MP dependency, is up to consumer).

I got rid of the reference to repos being checked for all dependencies.
As you can tell maybe from the README sorta trailing off at the end there, I didn't expect many (any?) people to find this beyond those I shared it with directly. Though I guess it was inevitable once i shared the CLI repo.
I'm sure i'll have questions for you when i get back around to this to fix the outstanding bugs.

About finding this: you blogged about it, and I am present on reddit as well (but I missed the post originally, just found it recently).
Sure, feel free to ask!


Filesystem helpers?

Would be useful to have filesystem utilties in abseil, for reading from/writing to files etc. Seems like a natural addition, especially since std is so lacking in this regard. See https://github.com/google/xls/blob/main/xls/common/file/filesystem.cc#L155-L181 as an example of using abseil for this in the wild.

This is partially answered by https://github.com/abseil/abseil-cpp/blob/master/FAQ.md#is-abseil-the-right-home-for-my-utility-library, but requires some visibility into Google's internal codebase. We have our own file system library that pre-dates std::filesystem and supports various non-local filesystems. It is something we would like to have released to support projects that are already using the library, but releasing it would require some non-trivial redesign and cleanup. It is something we did put on our roadmap, but as of today no one is working on it. It is unlikely that a new library of filesystem helpers based on std::filesystem will appear in Abseil anytime soon.


Add game notes support

Today I added support for game notes to the API. This allows us to add notes to specific game if there's an issue with the data, or to answer any FAQs we get.
This PR adds front-end support for these notes.

A small link (<button>) shows under any games which have notes set for them on the API:

Clicking this link opens a modal which displays the notes as bullet points:

This modal can be closed by clicking the close button at the top right, pressing Escape, or clicking the backdrop.
On mobile, the modal fills the entire viewport, just showing the close button as a method of exiting:

Wow, this is brilliant! Also very nice PR. Will have a full review either later tonight or more likely tommorow.
Whilst we're hear coild we add "news" headline, similar to how we had the red quotes on the tube world cup site? (maybe reuse the old "graphs are out of proportion" stuff?)
Image from the tube world cup site ( said e.g. "BREAKING: crowds have gathered at St Pancreas to witness this closely contested match" during the cup):

Wow, this is brilliant! Also very nice PR. Will have a full review either later tonight or more likely tommorow.
Whilst we're hear coild we add "news" headline, similar to how we had the red quotes on the tube world cup site? (maybe reuse the old "graphs are out of proportion" stuff?)
Image from the tube world cup site ( said e.g. "BREAKING: crowds have gathered at St Pancreas to witness this closely contested match" during the cup):

@davwheat Will the above be added, and if not, is this PR then ready for reviw?

@davwheat Will the above be added, and if not, is this PR then ready for reviw?

Never got an email for your comment! 😆
Yeah, we can do that news headline. I don't want it to be in red though. 😛
Another API endpoint, or should be fetch direct from a JSON on GitHub for if we can't update the API because I'm oversleeping again.

Never got an email for your comment! 😆
Yeah, we can do that news headline. I don't want it to be in red though. 😛
Another API endpoint, or should be fetch direct from a JSON on GitHub for if we can't update the API because I'm oversleeping again.

Never got an email for your comment! 😆
Yeah, we can do that news headline. I don't want it to be in red though. 😛
Another API endpoint, or should be fetch direct from a JSON on GitHub for if we can't update the API because I'm oversleeping again.

Ok - I would say do another API endpoint, especially since I think we should move to a cloud based API so that we can have CI (see davwheat/world-cup-of-tocs-api#7)

Never got an email for your comment! 😆
Yeah, we can do that news headline. I don't want it to be in red though. 😛
Another API endpoint, or should be fetch direct from a JSON on GitHub for if we can't update the API because I'm oversleeping again.

Ok - I would say do another API endpoint, especially since I think we should move to a cloud based API so that we can have CI (see davwheat/world-cup-of-tocs-api#7)

It's just a lot of work to move it to cloud infrastructure, especially since things like this have to use something like Google Cloud Run, which can become expensive, especially since our egress will slowly get higher with all the poll data.
Our egress will probably become about 5-20 GB/mth.
Turns out it's only about $2/mth but still... :P

It's just a lot of work to move it to cloud infrastructure, especially since things like this have to use something like Google Cloud Run, which can become expensive, especially since our egress will slowly get higher with all the poll data.
Our egress will probably become about 5-20 GB/mth.
Turns out it's only about $2/mth but still... :P

We create a new googel account
We get $200 credit
use the credit.
I mean this server only runs for 1 month, so even at $5 a month for two month we use... $10 of credit. From $200.

We create a new googel account
We get $200 credit
use the credit.
I mean this server only runs for 1 month, so even at $5 a month for two month we use... $10 of credit. From $200.

BTW why on "us-east1 or us-central1, not London"?

Free tier only applies at these locations (otherwise we'd be charged for all the vCPU-seconds, etc.

BTW why on "us-east1 or us-central1, not London"?

Free tier only applies at these locations (otherwise we'd be charged for all the vCPU-seconds, etc.

BTW why on "us-east1 or us-central1, not London"?

Free tier only applies at these locations (otherwise we'd be charged for all the vCPU-seconds, etc.

Ahhhh, you've got them confused,
There's a free tier which yes, only runs in those locations.
l'm talking about the free trial credit, which can be used anywhere.
(just checked, I have a g1-small instance in europe-west-b I haven't paid a penny for it - all from the free credit)

BTW why on "us-east1 or us-central1, not London"?

Free tier only applies at these locations (otherwise we'd be charged for all the vCPU-seconds, etc.

Ahhhh, you've got them confused,
There's a free tier which yes, only runs in those locations.
l'm talking about the free trial credit, which can be used anywhere.
(just checked, I have a g1-small instance in europe-west-b I haven't paid a penny for it - all from the free credit)


Enforce tenant need for MiqAeDomain

Uncommented the validation call that checks if the tenant object
is passed in when creating a domain.
The spec was missing a Tenant.seed

@kbrock @gmcculloug
Please review


MINIFI-552 Fix new SSL SAN Behaviour from new Jetty Version

Fixing this error, and Minifi cant Pull new Config from C2:
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
Linked: https://github.com/eclipse/jetty.project/issues/3466
Linked: https://github.com/apache/nifi-minifi/pull/169
2021-04-07 08:26:31,038 DEBUG [qtp1095293768-18] org.eclipse.jetty.io.AbstractEndPoint close(javax.net.ssl.SSLHandshakeException: No subject alternative names matching IP address <IP_ADDRESS> found) DecryptedEndPoint@3663382d{l=<IP_ADDRESS>/<IP_ADDRESS>:10081,r=null,CLOSED,fill=-,flush=-,to=13/30000}
2021-04-07 08:26:31,038 DEBUG [qtp1095293768-18] org.eclipse.jetty.server.HttpConnection
javax.net.ssl.SSLHandshakeException: No subject alternative names matching IP address <IP_ADDRESS> found
        at sun.security.ssl.Alert.createSSLException(Alert.java:131)
        at sun.security.ssl.TransportContext.fatal(TransportContext.java:324)
        at sun.security.ssl.TransportContext.fatal(TransportContext.java:267)
        at sun.security.ssl.TransportContext.fatal(TransportContext.java:262)
        at sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkClientCerts(CertificateMessage.java:700)
        at sun.security.ssl.CertificateMessage$T12CertificateConsumer.onCertificate(CertificateMessage.java:411)
        at sun.security.ssl.CertificateMessage$T12CertificateConsumer.consume(CertificateMessage.java:375)
        at sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:377)
        at sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:444)
        at sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:968)
        at sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:955)
        at java.security.AccessController.doPrivileged(Native Method)
        at sun.security.ssl.SSLEngineImpl$DelegatedTask.run(SSLEngineImpl.java:902)
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.fill(SslConnection.java:639)
        at org.eclipse.jetty.server.HttpConnection.fillRequestBuffer(HttpConnection.java:342)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:260)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:540)
        at org.eclipse.jetty.io.ssl.SslConnection.onFillable(SslConnection.java:395)
        at org.eclipse.jetty.io.ssl.SslConnection$2.succeeded(SslConnection.java:161)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
        at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:383)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:882)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1036)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.security.cert.CertificateException: No subject alternative names matching IP address <IP_ADDRESS> found
        at sun.security.util.HostnameChecker.matchIP(HostnameChecker.java:179)
        at sun.security.util.HostnameChecker.match(HostnameChecker.java:100)
        at sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509TrustManagerImpl.java:457)
        at sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509TrustManagerImpl.java:431)
        at sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:285)
        at sun.security.ssl.X509TrustManagerImpl.checkClientTrusted(X509TrustManagerImpl.java:135)
        at sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkClientCerts(CertificateMessage.java:682)
        ... 26 common frames omitted

Closing this here, and created the pull request in the main project.


Add security info

Follow-up to https://github.com/withastro/astro/pull/3718

@natemoo-re Sorry, I got caught up yesterday (in my defense, it was my first day in OpenSSF meetings, and I had to put in some order) and forgot to respond to my GitHub notifications. My bad.

Hey @ran-dall no worries at all! GitHub notifications are not easy to stay on top of. Figured this was a quick thing to tackle so I did!

Just so you, each repo has its own audit. I should finish those this week, and get them to Passing levels.
Here are the links for them so far.
Compiler: https://bestpractices.coreinfrastructure.org/en/projects/6200
Language Tools: https://bestpractices.coreinfrastructure.org/en/projects/6201


Strict concurrency in Swift 6

This is a starting point for strict concurrency in Swift 6. There are still some errors and warnings, which I'm not sure how to fix, so perhaps someone more knowledgeable than me can take it from here.

https://github.com/ml-explore/mlx-swift-examples/pull/90


Feature request: Support for rendering plantuml with online server

If PLANTUML_BIN not set, support for rendering plantuml with online server.
https://www.plantuml.com/plantuml/uml/SyfFKj2rKt3CoKnELR1Io4ZDoSa70000

Sounds like a good idea. I wouldn't want to make it the default though since I don't want the filter to send user data to remove servers by default.


add global loading placeholder during rendering

Add a global loading placeholder during rendering.
This is a demo of how to use the nextjs loading ui. Ref: https://nextjs.org/docs/app/building-your-application/routing/loading-ui-and-streaming
We probably need a better design.

@ken31ee I made a component for a similar issue before, but I am not a Next.js expert so I probably didn't use the best practice. I think maybe we can combine our codes and create a global component to handle different page status including loading state?

@marukosy124 We'd better separate the loading and error component. The next.js error and loading fallback leverages the React 18's suspense. Ref: https://react.dev/reference/react/Suspense

@ken31ee Great, I'll update my code later then. Thank you

@ken31ee You're right, I'll update my code later then thankss


Make the GUI information exportable to XLS or CSV

In GitLab by @mcastril on Jan 4, 2024, 16:51
It would be nice to have some of the tables, like performance views, or even the quick view or tree view, exported to files.
Related issue: https://earth.bsc.es/gitlab/digital-twins/de_340/project_management/-/issues/555#note_249025

In GitLab by @ltenorio on Mar 15, 2024, 15:31
Apart from the performance section shown in https://earth.bsc.es/gitlab/es/autosubmitreact/-/issues/96#note_265017, the new "Table View" also has these options


Add support for ClusterPool.Spec.Labels to apply to new ClusterDeploy…

…ments.
This will not affect any cluster already created and in the pool, or
claimed clusters from the pool.

/assign @staebler
/cc @suhanime

Ok should be good now after rebasing off master and replacing controller gen.

/lgtm


Feature Idea: auto normalisation-gain-type

Librespot and Spotify currently supports both track and album normalisation gain types. Which to use is currently up to the user, defaulting to album. An auto mode would not be that difficult. If 2 tracks in a row are from the same album use album mode if not use track mode.

Basically if the current track is the same album as the next track, album gain if not track gain. The only special case is at the end of the playlist. In that case since there would be no next track you'd want to look at the previous track to see if it's the same album to decide.

My bad. Just noticed the whole feature requests should be discussions thing...


github workflows: Convert top images and check bootstrap format

Add v6 images conversion to CI, and check it with the fsck.erofs.
Signed-off-by: Qi Wang<EMAIL_ADDRESS>

This has passed CI in my own repo, https://github.com/yawqi/image-service/actions/runs/2472519990, https://github.com/yawqi/image-service/actions/runs/2472437682.


Feature/docker volume mountpath

This commit introduces a new configurable field for
docker.volume.mountPath to choose the default location of
mounted volumes. A path of /var/lib/rexray/volumes is still
default as a base.
This has a commit from @akutz below this one.

[Current coverage][cc-pull] is 100%

Merging [#403][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #403   diff @@
====================================
  Files           1      1
  Lines          93     93
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits           93     93
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [1f9a55e...a9b7c3e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/rexray/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/rexray/compare/1f9a55e7493fcbc4802c96650de2bfec6498c790...a9b7c3e1209c04fd3fc850e1a23d7f0a3fc3a73c
[cc-pull]: https://codecov.io/gh/emccode/rexray/pull/403?src=pr

Coverage remained the same at 100.0% when pulling a9b7c3e1209c04fd3fc850e1a23d7f0a3fc3a73c on clintonskitson:feature/docker_volume_mountpath into 4eca9ecddb592ab830b646f562216e5ddd4808dd on emccode:master.

Coverage remained the same at 100.0% when pulling 30b825faeb90016f843f760d915b39415a9662ae on clintonskitson:feature/docker_volume_mountpath into 1f9a55e7493fcbc4802c96650de2bfec6498c790 on emccode:master.

Coverage remained the same at 100.0% when pulling 30b825faeb90016f843f760d915b39415a9662ae on clintonskitson:feature/docker_volume_mountpath into 1f9a55e7493fcbc4802c96650de2bfec6498c790 on emccode:master.

Coverage remained the same at 100.0% when pulling 66a48c73198685e76173091bdd991aa44874a176 on clintonskitson:feature/docker_volume_mountpath into 14fa2a4b7d0908e91440b01af51ce990a5f1f657 on emccode:master.


feat: improve updateplugins

Using the undocumented app.plugins.checkForUpdates() to avoid hacky 10s waiting workaround.
As a bonus, this only opens the settings modal if there are updates to be found.

Thanks for your contribution! That method is either new there, or I just overlooked it.


only feature ids present in the table should be clustered

I helped a collaborator run cluster-features after importing sequences and a biom table that were processed with a non-QIIME 2 pipeline, and we had the surprising result that the resulting FeatureData[Sequence] had more records in it than there were features in the FeatureTable. It turned out that the input FeatureData[Sequence] had sequences for features that had been filtered out of the input FeatureTable. We should probably raise an error if the set of feature ids isn't the same between the two inputs.
This is a bit of an edge case, so isn't really high priority (this will probably primarily be applied to FeatureTable and FeatureData[Sequence] artifacts that are generated through a QIIME 2 pipeline).

Addressed in #11.


Additional Overrides For Field of Type Media's Import Function

Good overrides to have:
Import(base64: Text, description, mime)
Justification: Many APIs return data in a base64 string.
Current solution: use base 64 convert FromBase64 to outstream. Copy to instream. Call ImportStream.
Import(url: Text, description, mime)
Justification: You may have a url to the resource.
Current solution: use http client et all to download image. Get instream. Call ImportStream.
This could all be a bit simpler, would be great.
I'd write my own PR, but I don't think this is exposed, at least I didn't find it.

Thanks for your suggestion. The import function for fields of type Media is a platform implementation. I've forwarded your request, but normally issues in this repo are either for open source or extensibility requests. As this is platform, it doesn't fall into any of these categories. But let's see :-)

We will add the request to our backlog, but since workarounds do exist and we are very busy with other features, then I would not expect this to happen in the next release.


Do not use stat -c [phab:D1187]

Created by salguarnieri at 2016-12-15 23:16:37:
stat -c is not standard and does not work on OS X. The replacement does
not look pretty, but it should get the job done.

zarko accepted this revision at 2016-12-19 23:12:53

salguarnieri closed via commit 1cf782cea5777b38c9611855efcac7918f815044 at 2016-12-19 23:15:22


warn_regressed_by: avoid to get all Bugzilla

Coverage decreased (-0.01%) to 30.561% when pulling 75a98c073940edbb53ac6dc43edf4b47d79655c1 on calixteman:fiw_warn into fca2041e4231bdab3d5089569a916d968a7cdd4b on mozilla:master.


[Backport] [2.13] [FEATURE] Built-in secure transports support (#12435) (#12789)

Backport of https://github.com/opensearch-project/OpenSearch/pull/12435 to 2.13

❌ Gradle check result for f77f6cf: FAILURE

https://github.com/opensearch-project/OpenSearch/issues/12411

❌ Gradle check result for f77f6cf: FAILURE

https://github.com/opensearch-project/OpenSearch/issues/11933
https://github.com/opensearch-project/OpenSearch/issues/5257
https://github.com/opensearch-project/OpenSearch/issues/12802


Left Hand Mode

Is it possible to have the side bar on the right hand side for left handed folks?

Whoops. I found the setting under "Sidebar Navigation"


Connection termination error for ssl URL

when we have installed istio 1.4.0 with AKS and trying to use SSL url it is giving following issue
Upstream connect error or disconnect/reset before headers. reset reason: connection termination
Note : same setup is working fine with Istio 1.3.2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d64cf65-bf33-ff76-3ece-47c758479506
Version Independent ID: c2db9de5-62ef-5bd0-83dc-1832113ae37c
Content: Install Istio in Azure Kubernetes Service (AKS)
Content Source: articles/aks/servicemesh-istio-install.md
Service: container-service
GitHub Login: @paulbouwer
Microsoft Alias: pabouwer

Thanks for the feedback! We are currently investigating and will update you shortly.

@MicrosoftDocs/aks-pm Can any of you please share insights on what could be the reason behind the error. I can't seem to find any information on this. Thanks :)

@paulbouwer Do you have any insights into this issue the customer is facing? Thanks :)

@Bhanu88 - please can you provide more details about your setup? How have you configured TLS on your ingress?

Please find the steps below
1.i bought a wild card certificate from azure and from that certificate i extracted cert and key file .
2.Using following command i created the secret in AKS
kubectl create -n istio-system secret tls istio-ingressgateway-certs --key /root/mbv.key --cert /root/mbv.crt

configured the api gateway with following Yaml

apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: api-app-gateway
namespace: istio-system
spec:
selector:
istio: ingressgateway
servers:

port:
number: 80
name: http
protocol: HTTP
hosts:

jpr-ser.mbv.com

port:
number: 443
name: https
protocol: HTTPS
tls:
mode: SIMPLE
serverCertificate: /etc/istio/ingressgateway-certs/tls.crt
privateKey: /etc/istio/ingressgateway-certs/tls.key
hosts:

jpr-ser.mbv.com

attached one of the virtual service using following script

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: {{ .Values.appname }}-app
namespace: istio-system
spec:
hosts:

"{{ .Values.virtualservice.dnshosts }}"
gateways:
{{ .Values.virtualservice.gateways }}
http:
match:

uri:
prefix: /{{ .Values.virtualservice.urlprefix }}
route:
destination:
host: {{ .Values.appname }}-app.{{ .Values.namespaces }}.svc.cluster.local
port:
number: {{ .Values.virtualservice.port }}

values.yaml
replicaCount: 1
appname : purposebk
appversion : 1.0
namespaces : default
envtype : dev
image:
repository: xyz.azurecr.io/purposebook
tag: 1768
pullPolicy: IfNotPresent
targetport: 8925
pullsec: xyzz
ENVVAR1: ASPNETCORE_ENVIRONMENT
ENVVAR1VAL: Development
ENVVAR2: KUBE_CLUSTER
ENVVAR2VAL: DEVOPS
service:
type: ClusterIP
port: 80
targetport: 8925
virtualservice:
dnshosts: jpr-ser.mbv.com
port: 80
gateways: api-app-gateway
urlprefix: purpose-book

when i did the same setup with Version 1.3.2 of istio its working fine ..i also browsed a bit on internet some other guys are also facing the same issue with version 1.4.0 .... and everyone is telling that if we downgrade to version 1.3.2 it works fine

@paulbouwer yes i configured the TSL at ingress level

https://discuss.istio.io/t/upstream-connect-error-or-disconnect-reset-before-headers-reset-reason-connection-termination/4434

@Bhanu88 - I found the following in the Istio Discuss thread you reference interesting.
It looks like this is a bug in Envoy that the Istio folks are aware of.

It’s a bug in Envoy. It doesn’t support/screws up Application-Layer Protocol Negotiation(ALPN) If you have a http1.1 service in the backend and a client sending Upgrade: h2c - Envoy will upgrade the connection to http2 and then force the backend to use http2 even if its not supported.

Also, it looks like there is a workaround if you use named service ports.

Check by changing the port name of the jaeger service from ‘query-http’ to ‘http-query’.
It seems that from istio 1.4, when the naming convention is not followed it uses the same protocol as in input so http2 if you use https to access the gateway. When specifying http-query, envoy will know that the backend it http1.1 and not http2 and will sned the request accordingly.

Using  named service ports is something I mention in the Note in Use intelligent routing and canary releases with Istio in Azure Kubernetes Service (AKS) > Deploy the application.

Could you look at if leveraging named service ports would allow you to continue using Istio 1.4 in your current setup?
Named Service Ports

https://istio.io/docs/ops/deployment/requirements/
https://istio.io/docs/ops/configuration/traffic-management/protocol-selection/

Example of Named Service Ports

https://github.com/Azure-Samples/aks-voting-app/blob/master/scenarios/intelligent-routing-with-istio/kubernetes/step-1-create-voting-app.yaml

thanks for the suggestion but as suggested i dont want to change configuration of any component which is not mine and understating my problem but i will not upgrade to istio 1.4 until issue is fixed . I request Microsoft to check for these common scenarios if possible before updating documentation .
Please you can let me know if the issue fixed in future version.
Also i cant find the the link of istio 1.3.2 with AKS documentation anymore Please let me know where i can find it ....

Istio requires that your workloads satisfy a number of requirements - one of these requirements is around named service ports:

Named service ports: Service ports must be named. The port name key/value pairs must have the following syntax: name: <protocol>[-<suffix>].

It has been my experience that following these requirements from the Istio team will ensure the best operating experience.
The official Istio documentation and the discussion site are still the best places to get solutions to broader Istio issues. You can find the installation guides for older Istio versions on the Istio archives site.
Hope that helps.

Thanks Paul i am closing the issue


chore: update to 2.4.0

@xzl01

/test all

@xzl01 Please review the code and merge the PR.  Thanks  ♪(･ ･)ﾉ

/intergrate

/integrate


[SEO-478] feat: allows users to set loading type to images on CardImageCap comp…

Description
SEO-478
In the interest of LCP we want to lazy load images that are not in the view port. Browser level lazy loading with suffice for a first pass.
Deploy Preview
N/A
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[x] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[x] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

:tada: This PR is included in version 20.40.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 21.0.0-alpha.31 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added basic functions and interfaces for model.py and viz generator

Background

Added basic functions and interfaces for model.py and viz generator
Model.py is the core functionality for the summarizer.
Viz generator takes care of generating all the visualizations.

Test Plan

Test TBD in future.

Looks good to me! The features are being implemented in another branch?

Yes they will be implemented in another branch. This pr is just for scoping.


First request is very slow compared to the next ones

Hello there,
We use Gotenberg in production and it's working pretty well, we used to call the service through a worker to generate some kind of transcripts on demand, soooo we had no need for fast response.
We have implemented a new feature to download a PDF of this transcript and we detected some kind of strange behavior. First call takes around 30sec, the next ones takes 10x less time (around 3sec).
We use the endpoint POST /forms/chromium/convert/html. Memory request has no impact on this, we tried to increase the memory request.
{"bytes_in":-1, "bytes_out":194773, "host":"gotenberg-svc.didaskill:3000", "latency":2.7139176603E10, "latency_human":"27.139176603s", "level":"info", "logger":"api", "method":"POST", "msg":"request handled", "path":"/forms/chromium/convert/html", "referer":"", "remote_ip":"<IP_ADDRESS>", "status":200, "trace":"e5bfbe59-363e-4601-b0e1-790f331dccd9", "ts":1.7320954988550153E9, "uri":"/forms/chromium/convert/html", "user_agent":""}
{"bytes_in":-1, "bytes_out":183087, "host":"gotenberg-svc.whatever:3000", "latency":4.430455622E9, "latency_human":"4.430455622s", "level":"info", "logger":"api", "method":"POST", "msg":"request handled", "path":"/forms/chromium/convert/html", "referer":"", "remote_ip":"<IP_ADDRESS>", "status":200, "trace":"d87a0a79-5daf-4ac0-bb69-f4b49408052e", "ts":1.7320957554230387E9, "uri":"/forms/chromium/convert/html", "user_agent":""}
{"bytes_in":-1, "bytes_out":174220, "host":"gotenberg-svc.whatever:3000", "latency":2.350850278E9, "latency_human":"2.350850278s", "level":"info", "logger":"api", "method":"POST", "msg":"request handled", "path":"/forms/chromium/convert/html", "referer":"", "remote_ip":"<IP_ADDRESS>", "status":200, "trace":"9abb7ed0-df8d-42fc-911c-6dc3e109b6f7", "ts":1.7320958769829226E9, "uri":"/forms/chromium/convert/html", "user_agent":""}

Is there any inner behavior of Gotenberg which could justify this and we should know ?

Hey @arenier 👋
If it’s a new instance, using --chromium-auto-start will help reduce this delay.

Hey @gulien
Thanks for the quick answer, we are going to implement this option :)


models to json question / how to enhance?

Hi there Chris, thanks for this great package!
Threw it into my new l5 version of one of my projects and it works like a charm.
I got one general question though:
Is there a generic way to get one or more threads as "flat" json objects that already contain properties like latestMessage, isUnread, messages, participants?
The reason I am asking is:
When working with AngularJS one cannot (of course) do something like you do in the example views:
{!! $message->user->first_name !!}
to access related data like messages or participants as we cannot call these php-methods on json objects.
So in my code I end up with something like:
$threads = Thread::getAllLatest();
foreach ($threads as $key => $thread) {
    $thread['latestMessage'] 	= $thread->latestMessage()->body;
    $thread['isUnread']		= $thread->isUnread($this->user_id);
}

This works but it seems a bit odd (I guess there is a more elegant and more generic way to do this).
I event tried and succeeded in duplicating the Thread model, putting my version of it in the App namespace and do modifications on it.
I can use this Version but again, I think this is not the preferred way to do this.
To put it short:
would it be possible to have a toJson() method on the Thread model that would give properties like latestMessage, isUnread, messages, participants right away?
best, Marco

Hi @marco-solare, I'm glad you like the package and that it's working out well for you in your project! I'll have to look into how to add those enhancements. I'm traveling until next week, so I won't be able to work on it too much, but I'll jump in more when I get back.
In the meantime, I think you are handing the problem correctly and building up the data you need in your controller. That's what I typically do when working with Angular. If you have any other questions, just let me know.

Hi @cmgmyr thanks for the quick reply!
Well, I would try to implement some freaky json method myself for starters, maybe I could contribute some little method.
Just unsure how to go about it - maybe just implementing it in Thread model?

Yeah, that would work on the Thread model. If you want to you can always make a new method and create a Pull Request.

alright, I'll look into it tonight. save travel to you

I've opened a pull request for this feature.

@0mattoz, thanks again for the PR #24. I left you a longer comment there, but I don't think this is a good fit for the package. The data needed by SPA devs can be vastly different and I don't think this package should be that opinionated. There are multiple ways that you can get the data needed, but I don't think there is a one size fits all solution.
I'm going to close this issue for now, but please feel free to continue the conversation if needed. Thanks again for the PR and using this package!


Add API documentation folders to the Mender docs

Add the API documentation for the following services:

inventory (v2)
inventory-enterprise (v2)
deployments-enterprise (v2)

Signed-off-by: Fabio Tranchitella<EMAIL_ADDRESS>

This PR cannot be merged until the feature/dev branch in deployments-enterprise gets merged into master, because the management API v2 is not yet in master.


fix: upgrade legacy table chart to 0.11.17

CATEGORY
Choose one

[x] Bug Fix

SUMMARY
https://github.com/apache/incubator-superset/pull/9234 introduced a bug in which the table chart throws errors when rerendering with different query results. It also lacks handling of null values in metrics and percent metrics.
https://github.com/apache-superset/superset-ui-plugins/pull/392 fixed it. This PR bumps plugin dependency to enable this fix.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
A fresh install of Superset or npm install should already fixes the bug because we published a minor new version.
To reproduce the bug, run npm install<EMAIL_ADDRESS>Then go to any Table chart, either add or remove a new metric, rerun the query multiple times. Run any query with Table chart multiple times, it should not thrown a JS error like this:

It should not throw this error after the fix.
ADDITIONAL INFORMATION
None
REVIEWERS
@kristw @etr2460 @graceguo-supercat

Codecov Report

Merging #9269 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9269   +/-   ##
======================================
  Coverage    58.9%   58.9%
======================================
  Files         373     373
  Lines       12026   12026
  Branches     2953    2953
======================================
  Hits         7084    7084
  Misses       4763    4763
  Partials      179     179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fea64...2b497c6. Read the comment docs.


fix some parameter setting does not work for CPU DDP and bf16 fail in…

… DDP path
Signed-off-by: Wang, Yi A<EMAIL_ADDRESS>

@sgugger @yao-matrix please help review

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thansk again for your contribution!


Enforce advertised debug session timeout

Tested https://staging.travis-ci.org/BanzaiMan/travis_staging_test/jobs/611052
Output from the terminal that had a connection:
$ ssh<EMAIL_ADDRESS>[server exited]
Connection to ny2.tmate.io closed by remote host.
Connection to ny2.tmate.io closed.


KeyError: 'Required INFO field CHR2 not found in file 100001.wham.vcf.gz' KeyError: 'Required INFO field STRANDS not found in file 100001.delly.vcf.gz'

Module01 PESRClustering.wdl
My json file
$ cat PESRClustering.json {   "ClusterPESR.frac": "0.1",   "ClusterPESR.flags": "--preserve-ids",   "ClusterPESR.exclude_list": "/home/resource/hg38_v0_sv-resources_resources_v1_GRCh38_Nmask.sorted.bed.gz",   "ClusterPESR.dist": "300",   "ClusterPESR.algorithm": "wham",   "ClusterPESR.svsize": "0",   "ClusterPESR.batch": "PESRtest",   "ClusterPESR.vcfs": [   "/home/Wham/100001.wham.vcf.gz",   "/home/Wham/100002.wham.vcf.gz",   "/home/Wham/100003.wham.vcf.gz",   "/home/Wham/100004.wham.vcf.gz"   ],   "ClusterPESR.svtypes": "DEL,DUP,INV,BND,INS",   "ClusterPESR.contigs": "/home/gatk_sv/resource/hg38_v0_sv-resources_resources_v1_contig.fai" }
The error logfile:
Job ClusterPESR.VCFCluster:10:1 exited with return code 1 which has not been declared as a valid return code. See 'continueOnReturnCode' runtime attribute for more details. Check the content of stderr for potential additional information: /home/cromwell-executions/ClusterPESR/5ffc1441-440a-4bb0-a329-3207b7816a50/call-VCFCluster/shard-10/execution/stderr.  [First 300 bytes]:sort -k1,1V -k2,2n Traceback (most recent call last):   File "/home/software/anaconda3/envs/cromwell/bin/svtk", line 7, in <module>     exec(compile(f.read(), __file__, 'exec'))   File "/home/work/SV/gnomad_sv_code/svtk/scripts/svtk", line 67, in <module>     main()   File "/home/w
cat /home/cromwell-executions/ClusterPESR/5ffc1441-440a-4bb0-a329-3207b7816a50/call-VCFCluster/shard-10/execution/stderr
KeyError: 'Required INFO field CHR2 not found in file 100001.wham.vcf.gz‘

And I noticed that the INFO column of the VCF file from running the Delly software contains CHR2.
So I modified the json file.
$ cat PESRClustering.json {   "ClusterPESR.frac": "0.1",   "ClusterPESR.flags": "--preserve-ids",   "ClusterPESR.exclude_list": "/home/resource/hg38_v0_sv-resources_resources_v1_GRCh38_Nmask.sorted.bed.gz",   "ClusterPESR.dist": "300",   "ClusterPESR.algorithm": "delly",   "ClusterPESR.svsize": "0",   "ClusterPESR.batch": "PESRtest",   "ClusterPESR.vcfs": [   "/home/Delly/100001.delly.vcf.gz",   "/home/Delly/100002.delly.vcf.gz",   "/home/Delly/100003.delly.vcf.gz",   "/home/Delly/100004.delly.vcf.gz"   ],   "ClusterPESR.svtypes": "DEL,DUP,INV,BND,INS",   "ClusterPESR.contigs": "/home/gatk_sv/resource/hg38_v0_sv-resources_resources_v1_contig.fai" }
However, I got a similar error.
KeyError: 'Required INFO field STRANDS not found in file 100001.delly.vcf.gz'
My command is
java -Dconfig.file=torque.conf -jar /home/Tools/bin/cromwell-54.jar run PESRClustering.wdl -i PESRClustering.json >PESRClustering.log & disown
I noticed the svfile.py file.
The INFO column is required to contain CHR2 and Strands information.

What should I do if my VCF files do not include CHR2 and Strands?
Thanks in advance!

@jingydz did you solve this

@leipzig  We didn't respond to this because it was closed right away but the answer is that input VCFs from the raw callers (Manta, Wham, Delly) have these fields added by the StandardizeVCFsworkflow that's called by the GatherBatchEvidence -> PreprocessPESR workflows. Downstream workflows expect that all input VCFs have been standardized to the format expected by the pipeline by this workflow, which runs svtk standardize on each input VCF.


CreateProcessApis: Fixed creation flags meaning of 0 for two of the process creation APIs

See comment I did on GitHub on the 21cf29976fbf8e89452762249375d5ff549a406d commit
This is related to #592

@nir9 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@nir9 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


ValueError: all the input array dimensions except for the concatenation axis must match exactly

Error at the row:
tr_features, tr_labels = parse_audio_files(parent_dir, tr_sub_dirs)
File "/Users/giuseppe/anaconda3/lib/python3.7/site-packages/numpy/core/shape_base.py", line 283, in vstack
return _nx.concatenate([atleast_2d(_m) for _m in tup], 0)
ValueError: all the input array dimensions except for the concatenation axis must match exactly

It is due to having varying dimension of arrays that you are trying to stack. Please make sure the each array has dimension (or number of features).