Find in files occasionally hangs

Issue Type: Bug
For a few weeks now, my find in files commands will hang ~25% of the time, and only give me results from files I currently have open. I've waited for results for up to ~30m, and they never return and my search window continues showing a spinner. If I search again the results will usually show up very quickly.
I've enabled trace logging, and it looks like in cases where the search hangs I don't ever get a line indicating the rg command that is used to handle my search. I don't see any exceptions or errors in the log or in developer tools.
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz (12 x 3592)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: disabled_softwareviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
undefined

Memory (System)
47.90GB (26.95GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

javascript-ejs-support
Dig
1.3.1

xml
Dot
2.5.0

ts-arrange2
DrM
2.0.4

gitlens
eam
10.2.1

tslint
eg2
1.0.44

prettier-vscode
esb
5.0.0

docthis
joe
0.7.1

import-sorter
mik
3.3.1

debugger-for-chrome
msj
4.12.8

debugger-for-edge
msj
1.0.14

Could you include a copy of the trace log?

trace.txt
The first search, for 'test', completed successfully. The second search, for 'anotherTest', is still spinning.

Debugged this with a screen share, found that the last search finishes with a "cancelled" error. Disabling searchOnType fixed it. I think what the log shows is that search was triggered 4 times. 3 of them finished. The last 2 are triggered with the same query. The first one of those is cancelled, the second I guess never goes anywhere. Not sure whether it's the wrong search getting cancelled or something.
@JacksonKearl any ideas?
Also I'm pushing a change to make sure that the error message gets logged.

This is odd, I haven't been able to reproduce it locally, either manually or by explicitly adding code to fire off many searches in quick succession. Is there a repository&query that this happens in that you could share?

Oh, sorry I missed this message @JacksonKearl! This happens for me for every repository and query that I run. It persists across version updates, and still happens if I reload with extensions disabled. I can even reproduce it by running a search out of an empty folder.
It looks like this is caused by the 'search.maintainFileSearchCache' setting - as soon as I turn that off the issue goes away, and I can reproduce the issue on a different machine by turning the setting on.

Another user hit a similar issue in https://github.com/microsoft/vscode/issues/101524 and the same setting was behind it, and I realized that setting is actually broken and will do the wrong thing. I recommend just disabling it

Verified by reading through code, not sure how to repro locally


(v11 compatibility) wal_files and replications_slots

Modification of wal_files and replication_slots, as wal_segment_size is now stored as bytes, and not as blocks anymore.
Added a few comments to help the next one that will try to re-engineer this part.
Tested on a setup with 1 Go WAL files, it seems fine.
Wal_files assumes that #195 (bug #194) will be applied.

@ioguix : as discussed this morning, I've added a few comments

Thanks!


add options to essential power

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
positive essential power via Solar Assistant becomes negative when shown on power flow card .  Also flow dots show power being imported.
Expected behaviour
Either: essential power flow is automatically shown as consumption
Or: there is an option to invert the power flow as with other loads
Possible Solutions
No response
Mode
Both
Context / Reason
Use: Power flow card being used with SolarSynk inverters via MQTT and Solar Assistant.
Reason: to tidy up the display so that power flows in the correct direction

Hey. Did you try the toggle below

Thanks for quick reply
The toggle you have shown me toggles the non-essential load power as well as the essential load power.  In my set-up the non-essential load power and the essential load power have opposite signs when consuming power.  I realise this is unusual.
Peter

On 28 Oct 2024, at 19:08, slipx06 @.***> wrote:
Hey. Did you try the toggle below
image.png (view on web) https://github.com/user-attachments/assets/e6269218-36f0-42cd-a518-7d4530234e31
—
Reply to this email directly, view it on GitHub https://github.com/slipx06/sunsynk-power-flow-card/issues/545#issuecomment-2442407527, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMICVMRO2QLI6DDM2NWGPW3Z52DR3AVCNFSM6AAAAABQYDKQNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSGQYDONJSG4.
You are receiving this because you authored the thread.


Modal horizontal scroll

would be good to get rid of horizontal scroll on confirmation modals:

related https://github.com/kodadot/nft-gallery/pull/7230#issuecomment-1719321095 https://github.com/kodadot/nft-gallery/pull/7230#issuecomment-1719327824


Support for loading in NWJS with --enable-node-worker

Hello.
I have modified the package.json file in the example so that the workers run in the context of nodejs. I need this change because I have other workers that handle datagram sockets (dgram lib).
Is it possible to load Monaco Editor with this option in nwjs?
Thanks in advance.

package.json content:
{
"chromium-args": "--enable-node-worker",
"main": "index.html",
"name": "MW",
"nodejs": true,
"window": {
"position": "center"
}
}

I tried it and it seems to work but the worker who checks the language does not load.

@alexdima
https://github.com/suren-atoyan/monaco-react/issues/115#issuecomment-701270893
it would have saved me a serious headache, it would be a good idea to add it to the doc !
Also in the demo doc, it say nwjs-amd not work but nwjs-amd-v2 work.
for me it's the opposite,  nwjs-amd work , and nwjs-amd-v2 not work.
thanks for all your work guys.

I'm sorry it doesn't seem to be working, but with so many requests that we get here and in the VS Code issue tracker, we just cannot provide the support we would like to offer.
You can try asking your question on stackoverflow.
That said, if you can track down your issue to a specific problem of the Monaco editor, we are more than welcoming a PR by the community! Please use the bug-report issue template to report the issue.
Thanks for your understanding!


IFTTT not working

I have a problem to get IFTTT to communicate with HASS.
For easily test I made a DO IFTTT with the following config to toggle a switch:

With toggle I got the last error ESOCKETTIMEDOUT, while error ETIMEDOUT was give when I tried turn_off in URL.

I have the IFTTT and key in my config.yaml, also tried to reconnect to maker channel and add the new key in config

Think I found the problem my self, had a / between IP and port, removed it and it worked now


Create standard way to catch task failures

Currently, if an exception is thrown and not caught manually in our tasks, the task ends, but the status and error messages aren't updated, leaving it in a perpetual STARTED state. We should come up with some standardized and simple way to wrap a task such that any exceptions lead to that task being marked as FAILED, and the exception message added to the task error messages.
One way this could be done is through using a custom decorator. We also may want to make better use of transactions (both django and arango), but this might be a slightly separate issue. The arango transactions might need to be placed within model methods (e.g. Table.put_rows) instead of the tasks themselves.

There must be a standard way to do this from the Girder4 side--could you check with the Slack channel and see what they say?

There must be a standard way to do this from the Girder4 side--could you check with the Slack channel and see what they say?

There is a standard way to deal with general failures and retries (this article provides an example), but since the tracking of the task status is custom to our app, I'm not so sure that has a specific "standard". I'll see what the other Girder4 folks say.

After some discussion, it looks like Celery Task Inheritance might be the way to go. We can put our logic around marking failed uploads in the on_failure method. We could even combine this with autoretrying, as the on_failure method is only called after all retries have been run.


Error: Cannot find module 'react' in version '^2.0.0-beta.27'

Hi!
I created a new project yesterday using the stable version of next.js. However, I was feeling adventurous and tried upgrading next using the command npm install --save next@beta. Everything went well, except for some unmet peer deps.:
── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
When I ran npm run dev, Next refuses to start and throws the following error message:
❯ npm run dev

><EMAIL_ADDRESS>dev /Users/vernon/Sites/ecurring-homepage
> next

Error: Cannot find module 'react'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/vernon/Sites/ecurring-homepage/node_modules/next/dist/server/render.js:277:14)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

The only dependencies that are listed in my package.json are:
  "dependencies": {
    "next": "^2.0.0-beta.27",
    "styled-components": "^1.4.3"
  }

Am I missing something?

As of beta.27 react and react-dom are not included, all you need to do is install them e.g npm i -S react react-dom

See https://github.com/zeit/next.js#setup

Thanks! Sorry, not sure how I could've missed that...

❤


[$500] Money Request grouped message jumping after adding one more Money Request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @VickyStash
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708959155001449
Action Performed:

Open a chat with any user
Create a Money Request for that user
Send several text messages
Create one more Money Request
The grouped message will be shown at the end of the chat for a couple of seconds and then jump back to the old position

Expected Result:
Grouped Money Request message should be displayed in the order of last money request was created
Actual Result:
Grouped Money Request message jump back to the old position in the chat, though a newer money request was created
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/cd567517-501a-4238-b1d0-881c368b9729
https://github.com/Expensify/App/assets/38435837/8753f305-8726-4b43-8615-1fbf101ca0ef

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017edbff2437b3b0b7
Upwork Job ID:<PHONE_NUMBER>036972544
Last Price Increase: 2024-02-27

Proposal
Please re-state the problem that we are trying to solve in this issue.
Money Request grouped messages jump after adding another Money Request and not displayed in the order of last money request was created
What is the root cause of that problem?
When money is requested, if there is an active request, it will use the existing request instead of creating a new one.
https://github.com/Expensify/App/blob/a0e444ed80c1642b78e973ec179568b2a785f66c/src/libs/actions/IOU.ts#L898-L901
We sort the report action by created property to ensure that the preview position of the money request remains unchanged.
https://github.com/Expensify/App/blob/a0e444ed80c1642b78e973ec179568b2a785f66c/src/libs/ReportActionsUtils.ts#L220-L225
What changes do you think we should make in order to solve the problem?
This solution will require a backend fix to update the 'lastModified' property.
We can make modifications to the 'lastModified' here:
https://github.com/Expensify/App/blob/a0e444ed80c1642b78e973ec179568b2a785f66c/src/libs/ReportUtils.ts#L3305-L3307
To
    const message = getReportPreviewMessage(iouReport, reportPreviewAction);
    return {
        ...reportPreviewAction,
        lastModified: DateUtils.getDBTime(),
        message: [
            {

And modify the sorting algorithm to utilize the lastModified property value (if available) for
Modify the following code:
https://github.com/Expensify/App/blob/a0e444ed80c1642b78e973ec179568b2a785f66c/src/libs/ReportActionsUtils.ts#L220-L225
To
    const getTimestamp = (reportAction: ReportAction) =>
        reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW && reportAction.lastModified
            ? reportAction.lastModified
            : reportAction.created;

    const sortedActions = reportActions?.filter(Boolean).sort((first, second) => {
        const firstTimestamp = getTimestamp(first);
        const secondTimestamp = getTimestamp(second);
        if (firstTimestamp !== secondTimestamp) {
            return (firstTimestamp < secondTimestamp ? -1 : 1) * invertedMultiplier;
        }

We can also filter by 'childType' if needed.
Branch to test
What alternative solutions did you explore? (Optional)

@mkhutornyi, @miljakljajic Proposal updated with alternative solution.

Is this the same https://github.com/Expensify/App/issues/30147?

@mkhutornyi @yuwenmemon

🎀 👀 🎀

What does that mean? Does it signify the acceptance of my proposal? If so, who will assist with the backend part?

@mkhutornyi, I think this is solved based on this https://github.com/Expensify/App/issues/36501#issuecomment-1979948679.

@Tony-MK depending on which expected behavior we choose
This post expected behavior is:

Grouped Money Request message should be displayed in the order of last money request was created

I'd suggest updating the position using the lastModified prop for easier navigation. For instance, if we have a pending money request followed by hundreds of subsequent chats, the user would need to scroll up until they find the grouped report preview.
The current behavior will also lead to this new problem.

Clarifying the expected behavior in slack

@mkhutornyi, please also consider referring to https://github.com/Expensify/App/issues/37775 in the discussion as they share the same root cause.

@wildan-m, I think the correct OP for positioning the report preview was stated in https://github.com/Expensify/App/issues/36501#issuecomment-1975475047.
This issue should not be reproducible because of this video https://github.com/Expensify/App/issues/36501#issuecomment-1979913579 by kavimuru.

Closing!

@miljakljajic It would be greatly beneficial if issues are concluded with a comprehensive explanation. This approach ensures that time and energy are conserved, and it provides clarity should similar challenges arise in the future.

Apologies - I've reopened the issue, I misunderstood this https://github.com/Expensify/App/issues/37245#issuecomment-1985354506 as consensus that the issue should be closed!

@mkhutornyi @yuwenmemon Is there any possibility of re-evaluating the expected behavior? Or what are the design/technical constraints preventing the re-arrangement of the report preview order?

Heads up I'm going OOO through next week so @miljakljajic we might want to ping someone else to answer the question above.

Raising the question in VIP split

Issue not reproducible during KI retests. (First week)

@m-natarajan can you try to reproduce this and see if its still an issue?

Yes, it still has not met the expected outcome.

Grouped Money Request message should be displayed in the order of last money request was created

https://github.com/Expensify/App/assets/11847279/96058b8b-7735-4e04-b34e-e4a74ed7b41b
@miljakljajic any response from the VIP split?

No response: https://expensify.slack.com/archives/C05RECHFBEW/p1712673042136469
bumping

Issue not reproducible during KI retests. (Second week)

@miljakljajic still no response? Perhaps you should tag engineers who are familiar with the issue.

I think we can close this out - it hasn't been reproducible for a while and it doesn't seem like its a high priority for split right now.


Dynamic IPv6 prefix handling

Initial commit of changes that will automatically handle fw aliases when the
ipv6 prefix changes

Ah, OK but now you are in Python territory and I usually avoid snakes. :)
Sort of see in update_tables.py where I THINK it tries to get the alias_content = alias.resolve() at line 131, but to be honest I'm not familiar with python at all, so either I'll need some guidance or someone else will need to take it from there.

maybe it's better to design the wanted feature first in a ticket, if the requirements are clear and straight to the point, it might not be a huge effort to implement it at some point. The mac address addition (https://github.com/opnsense/core/issues/4248) wasn't very complicated either and fits our strategy of making sure components are loosely coupled.

It's pretty straight forward them ( for someone who works with Python ) we have created an alias with both a partial IPv6 address and an interface. We then merge the  interface prefix with the partial address, which is what happens with this PR but without using the Python routines. I am looking at alias.py at the moment, trying getting my head around it. I can see that with mac there's a arpache.py. In the final instance I would like to be able to be flexible with the suffix, in the context that if the user must enter the full suffix, so for a /64 suffix they would enter ::0:0:0:1000 , however, if they entered ::0:0:0:0:1000 that would be an 80 bit suffix and we would take the first /48 from the prefix and merge on that. However, that 's a wish, and in the initial case we would just want to merge on the /64.

My advise would be to start with an issue, keeping it brief and to the point (I haven't read all of the earlier discussions, to help out I like to prevent reading to a lot of comments in different PR's and issues). Just assume I don't know anything ;)
Important points are, what kind of information do you expect the user to input, what should it calculate to (and how) and when does it change.

OK, I'll do that. It will be very interesting to see what you do to create this, should help me understand the Python flow.

Is done