philosophy of known metrics

I am failing to see how to add birth metrics to the application known metrics - it seems like I should be able to do it in the NBirth and DBirth event handlers. Also how do I update the value of the know metrics using the NData and DData? Or is this not the right philosophy for the known metrics - do I need to in parallel also keep track of metric values?

it seems like I should be able to do it in the NBirth and DBirth event handlers

No, within the constructor of the application / node. Check out the examples or my answer under https://github.com/SeppPenner/SparkplugNet/issues/92, please.

I hope this is answered with https://github.com/SeppPenner/SparkplugNet/issues/92#issuecomment-2022237084 already. If not, feel free to contact me again / re-open the issue(s).

@SeppPenner: I agree with  @jeff-pf:
Let assume we have a SCADA Nain Host application (SparkPlugBApplication) waiting for Nodes to connect. It cannot know beforehand the Metrics the Node will be publishing. It will only get this information when the Node connects, and its birth message with all the metrics it intends to report, is published. At this time the SparkPlugBAppplication shall register all the Node metrics in its store. Only during subsequent NDATA messages the application should ignore unknown Metrics.

@SeppPenner: I agree with @jeff-pf: Let assume we have a SCADA Main Host application (SparkPlugBApplication) waiting for Nodes to connect. It cannot know beforehand the Metrics the Node will be publishing. It will only get this information when the Node connects, and its birth message with all the metrics it intends to report, is published. At this time the SparkPlugBAppplication shall register all the Node metrics in its store. Only during subsequent NDATA messages the application should ignore unknown Metrics.

I misunderstood this before, but you're absolutely right. This won't work. I need to change the logic for the applications.

My temp solution was to add a public function to metric storage to be able to add the birth metrics.
public void AddVersionB_BirthMetric(T metric, Metric versionBMetric)
{
// Check the name of the metric.
if (string.IsNullOrWhiteSpace(versionBMetric.Name))
{
// Check the alias of the metric.
if (versionBMetric.Alias is null)
{
throw new InvalidMetricException($"A metric without a name and an alias is not allowed.");
}
    // Check the value of the metric.
    if (versionBMetric.Value is null)
    {
        throw new InvalidMetricException($"A metric without a current value is not allowed.");
    }
}
else
{
    // Check the value of the metric.
    if (versionBMetric.Value is null)
    {
        throw new InvalidMetricException($"A metric without a current value is not allowed.");
    }

    // Check the alias of the metric.
    if (versionBMetric.Alias is null)
    {
        // Hint: Data type doesn't need to be checked, is not nullable.
        this.knownMetricsByName[versionBMetric.Name] = metric;
    }
    else
    {
        // Hint: Data type doesn't need to be checked, is not nullable.
        this.knownMetricsByAlias[versionBMetric.Alias.Value] = metric;

    }
}

}
I am creating a birth metric list in the birth event handler and then the application adds them.

Going down the rabbit hole a little further - I see a few other issues also.

if the metric storage is meant to be the location of data updates - I do not see a way that it is going to happen - I can see 2 ways to handle this - one is automatically and the other is to allow the application to update the values (see point 3 below)

the metrics are not tied to a node/device - if I have multiple of the same device on a node there will be the same metrics published but there is not a way to tie them to the node/device. Same for multiple nodes with the same devices. My past solution was to add topic to the metric.

there may be nodes or devices that are not needed by the application - for example in Ignition SparkplugB setup the node / device names that data is collected from are entered

I am happy to help think through this - let me know if there is anything I can help with.

Rules for the Node Control/Rebirth metric from the 3.0 spec (in ref to issue #44 - but also relevant here - just to clarify)

application sends NCMD with metric Control/Rebirth = true

• [tck-id-operational-behavior-data-commands-rebirth-name] An NBIRTH message MUST
include a metric with a name of Node Control/Rebirth.
• [tck-id-operational-behavior-data-commands-rebirth-name-aliases] When aliases are being
used by an Edge Node an NBIRTH message MUST NOT include an alias for the Node
Control/Rebirth metric.
◦ This is to ensure that any Host Application connecting to the MQTT Server is capable of
requesting a rebirth without knowledge of any potential alias being used for this metric.
• [tck-id-operational-behavior-data-commands-rebirth-datatype] The Node Control/Rebirth
metric in the NBIRTH message MUST have a datatype of Boolean.
• [tck-id-operational-behavior-data-commands-rebirth-value] The Node Control/Rebirth metric
value in the NBIRTH message MUST have a value of false.
A Rebirth Request consists of the following message from a Sparkplug Host Application with the
following characteristics.
• [tck-id-operational-behavior-data-commands-ncmd-rebirth-verb] A Rebirth Request MUST
use the NCMD Sparkplug verb.
• [tck-id-operational-behavior-data-commands-ncmd-rebirth-name] A Rebirth Request MUST
include a metric with a name of Node Control/Rebirth.
• [tck-id-operational-behavior-data-commands-ncmd-rebirth-value] A Rebirth Request MUST
include a metric value of true.
**Node must stop publish data and send NBirth with same bdseq and and DBirth messages **
Upon receipt of a Rebirth Request, the Edge Node must do the following.
• [tck-id-operational-behavior-data-commands-rebirth-action-1] When an Edge Node receives a
Rebirth Request, it MUST immediately stop sending DATA messages.
• [tck-id-operational-behavior-data-commands-rebirth-action-2] After an Edge Node stops
sending DATA messages, it MUST send a complete BIRTH sequence including the NBIRTH and
DBIRTH(s) if applicable.
• [tck-id-operational-behavior-data-commands-rebirth-action-3] The NBIRTH MUST include the
same bdSeq metric with the same value it had included in the Will Message of the previous
MQTT CONNECT packet.
◦ Because a new MQTT Session is not being established, there is no reason to update the bdSeq
number
• After the new BIRTH sequence is published, the Edge Node may continue sending DATA messages.

I made this change so I can publish a rebirth from the application
protected override async Task PublishNodeCommandMessage(IEnumerable<Metric> metrics, string groupIdentifier, string edgeNodeIdentifier)
{
    if (this.Options is null)
    {
        throw new ArgumentNullException(nameof(this.Options), "The options arent't set properly.");
    }

    bool rebirth = false;
    List<Metric> cmdMetrics = new List<Metric>();
    foreach (var metric in metrics) {
        if ((metric.Name == "Node Control/Rebirth") && (metric.Value is true)) {
            rebirth = true;
            cmdMetrics.Add(metric);
            break;
        }
    }

    if (!rebirth)
    {
        var f_metrics = this.KnownMetricsStorage.FilterMetrics(metrics, SparkplugMessageType.NodeCommand);
        foreach(var metric in f_metrics)
        {
            cmdMetrics.Add(metric);
        }
    }

    // Get the data message.
        var dataMessage = this.messageGenerator.GetSparkplugNodeCommandMessage(
        this.NameSpace,
        groupIdentifier,
        edgeNodeIdentifier,
        cmdMetrics,
        this.LastSequenceNumber,
        this.LastSessionNumber,
        DateTimeOffset.UtcNow);

    // Increment the sequence number.
    this.IncrementLastSequenceNumber();

    // Publish the message.
    await this.client.PublishAsync(dataMessage);
}

Let me think about this whole mess a few more days. I guess, how it's implemented right now is way to complicated...


Add check box helper

Remember to use hidden field so we get the unchecked value. This will work similar to the text_input helpers https://github.com/luckyframework/web/blob/master/src/lucky_web/tags/input_helpers.cr
http://stackoverflow.com/questions/11550941/why-does-the-check-box-form-helper-generate-two-checkboxes-one-hidden
Also: https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/boolean_input.rb#L93

I started work on this one.

I plan to have this done by the end of the week. If you need it quicker, please feel free to implement it as well. @paulcsmith

@5minpause I think that will be great, but I'll let you know if I need it quicker. Thanks for the update!

Alright the PR is open. I am looking very much forward to your feedback.


[device_info_plus] Remove AndroidId, update Windows dependencies

Description
According to report in #824 Google Play's new policies discourage usage of unique ids, by requiring to explicitly declare usage of such ids in Data Safety section. I recently had similar experience with flutter_segment package, which used segment_analytics Android library, which was accessing AndroidId as well: https://github.com/la-haus/flutter-segment/issues/30
I believe we should exclude AndroidId from set of data returned by device_info_plus, so people, who use the package don't have to declare collection of unique IDs in Data Safety section on their Google Play Store listing. Bumped the major version, since removal is a breaking change from my point of view. Those, who would still need to use AndroidId for some reason could use older version of device_info_plus.
Additionally, needed to update some dependencies for Windows plugin as building example app was failing for me. Due to changes in requirements on ffi and win32 had to bump min Dart version to 2.17 in Windows plugin.
Related Issues
Closes #824
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

Yep, good catch, makes sense to me!

new versions published now

It's better to mark depreciated labe

What ID now can use as a unique ID?

You should refer to the official documentation for that https://developer.android.com/training/articles/user-data-ids

It's better to mark depreciated labe

Because new policy is going to be enforced on 9th of August already we had no time to do a proper deprecation cycle. However, nobody stops you from using pre 4.0.0 version of the plugin if you want to still rely on AndroidId as there are no new features of critical fixes so far.

@vbuberen since the other issue got locked I will reply it in here.
I wasn't demanding anyting, this is a community effort, so of course no one is obligated to nothing. My point was to make an open discussion so we can reach an agreement. The decision to extract AndroidId impacted several apps, many financial apps like mine, and having to import another package just to get this variable seems excessive to me.
I made a suggestion on how we can circumvent this, but the reason why I didn't send any of it as code is because I am forbidden from sending any code by my employment contract. All the code that I make is the property of my employer. What I am trying to do right now is to get an exception, or to find someone else that can open a PR with my suggestion.

@vbuberen I did more reseach into the source code and at first I thought this was a flag under the Manifest, but now I see it's just a method call. I thought the Play Store was filtering apps that declared access to the ANDROID_ID in their Manifests, but now I see that's not the case.
I don't remember this being mentioned by the maintainers, but this information can justify a new package, as the Play Store could search the app's source code, looking for calls to retrieve the ANDROID_ID.


Cannot install cli

><EMAIL_ADDRESS>postinstall /home/user/ufo/node_modules/lufo-cli
> linklocal

sh: linklocal: command not found
npm WARN enoent ENOENT: no such file or directory, open '/home/user/ufo/package.json'
npm WARN ufo No description
npm WARN ufo No repository field.
npm WARN ufo No README data
npm WARN ufo No license field.

npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: `linklocal`
npm ERR! spawn ENOENT

can we drop linklocal? Should not necessary

Definitely a bug, thanks for reporting. linklocal is used for development only and should be stripped from the package.json during deployment to the npm registry.

Fixed in 0.3.2.


Docs for template tags and filters gone?

Hi, was missing the actual template tags and filters docs. They are listed but no content shows up. In older versions one could click on the topics and expand the contents.

Thanks for checking...

Tried to build the docs by myself and got some warnings:
No module named 'django_bootstrap5'
WARNING: autodoc: failed to import function 'templatetags.django_bootstrap5.bootstrap_formset_errors' from module 'django_bootstrap5'; the following exception was raised:
No module named 'django_bootstrap5'

for all templatetag docs

Can confirm that the docs are still broken.

hopefully fixed soon, however, the base package docs can still be referenced, or the v5 option with is very similar to this. or the code :)

Looks like the problem is that the package is not installed before building the docs.

Might have to reopen this.
The changes to .readthedocs.yaml shouldhave fixed the build.
https://django-bootstrap5.readthedocs.io/en/feature-readthedocs/templatetags.html#bootstrap-form-errors
But the same build process does not yet fix it for the main branch.

Looks like the bug is solved, but due to caching some pages still do not show properly for me.  I will keep this open for a while to monitor, feel free to chime in.

Looks good to me now.


Humble question regarding JS performance

First and foremost, very impressive work!
As a low-level JS performance enthusiast, I'd be interested to see how much faster I'd be able to make the JS implementation on V8 in particular (with expected gains across all JITs I'm aware of).
And by "faster" it's of course implied to mean repeatably, measurably, explainably, and significantly faster. (Just say no to microbenchmarks).
Main strategies include well-known run-of-the-mill techniques like enforcing 100% monomorphic code and other related JIT-appeasing goodness.
Would this be of any interest whatsoever to you? Absolutely fine if not, but I wanted to extend you a nerdy E.T. glow-finger of enthusiasm and test the waters before deciding to proceed on my own instead.
Apologies in advance for sending this much text your way unsolicited.
All the best, and again, great work. 👏

I'm personally not going to work on the JS side of it more as it's purpose was for the browser demonstration. There are many opportunities for improving the efficiency on the JS side.


Fix build error when PPAutomationBridge is built before UIKit is imported.

I was talking to Boris about this last week... Should be in an ifndef automation_udid because that's the only part that needs it. Else it won't work on OS X

Removing a dependency on UIDevice and initiating bridge with unique identifier might be best approach here... We can discuss it tomorrow.

@kviksilver it's your call either way.

For me, since this is an iOS and/or Mac OS X lib, I think it's worth "making it easy" for the common case. In the case of Mac OS, I'd imagine it should be the computer name instead of device name, which is perhaps a worthwhile addition. But taking it out and making the app put together the name, even though it's just a few lines, seems almost punitive.

I agree with Max. Updated the pullreq so that PPAutomationBridge is now possible to compile on OSX if you define AUTOMATION_UDID.


Adds classpath entries to the server definition

It turns out these entries are required for Eclipse. If they are missing, an error is shown in the Server Runtime Environment wizard dialog.
However running the server does not need them.

lgtm


workflow: protection against DB session problems caused by the payload

I know that this should not be required, but right now it is because (for some bad reason) some parts of our code are messing up the db session using a rollback. Without this, you do not get any usable debug information but instead a InvalidRequestError from the workflows code.
In general we should think about the following 2 things:

Not using a global db session object (i.e. kill invenio.ext.sqlalchemy.db).
Better isolation and decoupling of workflow payloads. When doing this we might also move the execution to celery instead of doing it in the request thread.

Do you have the steps on how to reproduce this problem? I have not seen it while running workflows and depositions on INSPIRE labs, but perhaps the payload's have not been naughty enough so far :-)

Use the demosite and make a deposit WITH a file (whatever you want).

This is problem has become more visible since we switched to ACID database backend. Hence we need to be more careful about DB session usage.
--
cc @lnielsen

As you point out the problem is that you are unable to find (and debug) the original exceptions that are thrown inside a workflow. @dset0x and I had a look at testing this against the upcoming new workflows code (WIP in #2628) which does a better job of spitting out this kind of debug information than current master. It allowed us to get one step closer to the real issue but we were stopped by the import_string "wall" of current werkzeug and flask-registry. By applying @dset0x PRs to these packages (https://github.com/inveniosoftware/flask-registry/pull/34) we were better able to pinpoint the problems. Unfortunately, a long way to go just for a stacktrace..
To summarize, while this patch provides the original stacktrace representation I hope in the future we will find a better way of providing this information. Perhaps as a combination of better session handling and the refactored code from @dset0x .

Can we merge it to finally fix that problem in master? I'm asking because master is broken right now and it is nearly impossible to debug it without these changes.

@crepererum It's a go from our side since it's causing debugging issues.

Workflow engine has been notably changed in Invenio-Workflows and Workflow 2.0.


Fixes bug where Korean text overrides English text

See https://github.com/radar/forem/pull/648#issuecomment-85225320 for additional context.

Thanks. Sorry for that :(

Oops.. Good catch.


[AIRFLOW-XXX] Adds image code comment

Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

This PR adds a hint to the reader about where to source the image used in the example Kubernetes yaml files. I wrongly assumed that airflow referenced an official image, and did not realise I had to build my own.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

No code changes.
Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

[x] Passes flake8

No code changes

Codecov Report

Merging #4413 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4413      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.01%
==========================================
  Files         204      204
  Lines       16445    16445
==========================================
- Hits        12890    12889       -1
- Misses       3555     3556       +1

Impacted Files
Coverage Δ

airflow/models/__init__.py
92.55% <0%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8938d2c...68c43c9. Read the comment docs.


suggestion：support utility-first CSS framework

Such as Tailwind CSS

Currently Pushup is agnostic as to what CSS libraries and frameworks users bring to it. I would be hesitant to bless a particular CSS framework and bundle it or provide syntax or library support for it, without first understanding more the potential need and the tradeoffs.

Currently Pushup is agnostic as to what CSS libraries and frameworks users bring to it. I would be hesitant to bless a particular CSS framework and bundle it or provide syntax or library support for it, without first understanding more the potential need and the tradeoffs.

Providing framework support like Tailwind CSS makes it easier for developers to design pages, because CSS is the key to web pages. Or there is a more convenient way to write CSS, which is important for pushup.


Support text protocol

Currently, libyrmcds supports binary protocol only.
To support text protocol as well, these may matter:

Invalid keys (keys containing spaces and/or newlines).
Non-existent commands.
Differences in server response.

Design
Keep API best for binary protocol.
Using text protocol can and will incur extra overheads and limitations.
In exchange, we keep the same API including response struct for both binary and text protocols.
Mode of connection
memcached determines the connection mode by the first request from the client.
For this, the connection is only allowed to enter text protocol mode before sending
the first request.
Request serials
As text protocol does not have opaque fields, request serials need to be emulated in libyrmcds.
If quiet flags were used, responses may or may not be returned from the server, which would
make us impossible to associate responses with requests.  For this, use of quiet is not allowed
in the text protocol mode.
This limitation comes from the API design that separates receives from sends.
Invalid keys
Text protocol is vulnerable for illegal characters (white spaces and control characters) in keys.
If the connection is in text mode, API should return errors for such keys.
Non-existent commands
If an API cannot be implemented with text protocol, the API should return an error.

@kazuho Looks good?

@ymmt2005 Thank you for spending time on this. Looks fantastic!

One more unavoidable limitation...
Responses for set, add, or replace cannot set the correct CAS value.
Unlike binary protocol, text protocol does not bring CAS value in responses.


added pipeline and Jfrog files

@VenkeyBoda Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

added


Indicate on bootstrap failure after X tries so wallet will know

Overview / Motivation
currently, you are required to be routable (forward a UDP port) in order to connect as a home miner to a network. though the bootstrap process is retying 10 times and then quits and goes on to gossip with the bootstrap node. we should return and quit or somehow indicate that we're unable to recv incoming udp messages and redirect the user to educational material about NATs, firewalls and port-forwarding.
The Task
TODO: Clearly describe the issue requirements here...
Implementation Notes
TODO: Add links to relevant resources, specs, related issues, etc...
Contribution Guidelines
Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who haven't introduced themselves on our Gitter dev channel

Introduce yourself on go-spacemesh dev chat channel - ask our team any question you may have about this task
Fork branch develop to your own repo and work in your repo
You must document all methods, enums and types with godoc comments
You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature
When ready for code review, submit a PR from your repo back to branch develop
Attach relevant issue to PR

@y0sher - we were thinking about using the new /v1/nodestatus function to monitor the # of connected neighbors (peers in the response) and just display an error message about network issues if it stays below peersMin for n constant minutes. I believe this is good enough solution to resolve this issue for TNFF: #1662 - please close this issue if you agree.

#1662 kinda handles this.


Review Ticket 1/16

College Board Grading Assignment 2
Model and Object Oriented Programming
I currently can't quite figure out how to get the ingredient values to change, but I've added a demo recipe and buttons to each food type, so they can direct to different recipes of their type later.
The plan is to have each button for each food (ie, ramen) go to other foods of the same type (ie, different types of ramen) and have the user input how many of each food they want, and the recipe will calculate that for them. Currently I only have 1 recipe, for a test.

.95 Model
.9 View
.8 CPT
-.05 late


Fix: offset return type

The offset query parameter is inserted and returned as a string. Tested with insomnia:

I fixed it as a one liner. Maybe we can make it more robust in the future.
In case I have not tested it correctly, feel free to decline this PR.

Thanks for finding and fixing this!


Optical margin outdents for accented characters

Love what you're doing with this project. This is a fix for issue #12

added a map from letters in alignMe to regexes matching their accented versions (sourced from: http://stackoverflow.com/questions/286921/efficiently-replace-all-accented-characters-in-a-string)
removed redundant Y in alignMe
when pulling an accented character, use the same css class as the base character but set the content to the matched accented character

Looks good to me – thank you for sorting this!


Add error handling and troubleshooting guide for Klaystagram dApp

This commit introduces a new section titled "Error Handling and Troubleshooting" to the Klaystagram dApp documentation. This section aims to assist developers in identifying and resolving common errors they might encounter during development and testing.
The new section covers the following:
Transaction Failures: Explains potential causes and debugging tips for transaction failures, including insufficient funds and smart contract errors.
Connection Issues: Addresses common causes and solutions for connection issues between the application and the blockchain node.
Other Errors: Provides general debugging strategies such as reviewing error messages, consulting documentation, using debugging tools, and seeking help from online communities.
By incorporating this error-handling guide, the Klaystagram documentation becomes more comprehensive and user-friendly, empowering developers to effectively troubleshoot and navigate potential challenges during the development process.
Proposed changes

Describe your changes to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes
Please put an x in the boxes related to your change.

[ ] Minor Issues and Typos
[x] Major Content Contribution
[ ] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING GUIDELINES
[ ] I have signed the CLA
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Related issues

Please leave the issue numbers or links related to this PR here.

Further comments
If this is a relatively large content contribution, kick off the discussion by explaining why you would suggest the content contribution, etc...

I have read the CLA Document and I hereby sign the CLA

Thank you for your contribution! Due to repository migration, we're closing this PR for now. We plan to reopen contributions in the new Kaia docs repo once it's public. We encourage you to resubmit your PR there then.


Update latest TryStatement interface

See https://code.google.com/p/esprima/issues/detail?id=433

What's the status of this PR? It's been open for over a year.

See https://code.google.com/p/esprima/issues/detail?id=433#c5.

@cvrebert thanks for contributing, and please bear with us as we sort a few things out...
@ariya, looks like https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API now mentions "handler". Also, the mention Mozilla bug is fixed as of August: https://bugzilla.mozilla.org/show_bug.cgi?id=742612
Perhaps we can rebase this and land it, back compat concerns aside?

I think it's better to quickly check if there are tools broken by this. Otherwise, we have no data point.
A conservative approach is to emit both handler and handlers, slowly phasing out handlers in the process.

We are holding this off until 3.x, see #1030 for details.


update the etcd-druid dependency version in go.mod

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:
This PR updates the etcd-druid dependency version in go.mod
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

None

/test pull-gardener-e2e-kind-migration

/test pull-gardener-e2e-kind


just create-control-plane fails on clean setup

When attempting to go through dev-cluster after a fresh git clone the just create-control-plane fails.
kind create cluster --config ./kubernetes/kind-cluster-config.yml
Creating cluster "astria-dev-cluster" ...
 ✓ Ensuring node image (kindest/node:v1.26.3) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✗ Starting control-plane 🕹
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged astria-dev-cluster-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1
Command Output: I0615 01:43:52.178033     131 initconfiguration.go:254] loading configuration from "/kind/kubeadm.conf"

Full error logs: https://gist.github.com/jbowen93/2d868f9923be7a3b65ffdc78ecc27bc5

This was due to kind not being installed.


[feature request] context aware template loader?

http://jinja.pocoo.org/docs/2.9/api/#loaders
It would be helpful to have a context aware template loader. I want to change which template is loaded based on an attribute in the context. The use case here is overriding a template.

The loader API doesn't take a context, that's part of the render process after you already have a template.
You can already pass a template object or path to extends with a variable.
{% extends other_template %}

@davidism, my current issue is naming conflicts between context variable names and template names which is why I like using strings instead. I am considering implementing an alternative template tag, let's call it include2 for the time being, used as {% include2 'asdf' %}, that could serve as a context aware template loader. does this seem like a reasonable approach?
thanks!

I don't understand what you mean. You can name variables whatever you want, independent of the strings they hold or other values in the template. Import can take variables just like extends.

@davidism just to clarify, while I can name variables whatever I want, I'm working in a system where both the context and the template themselves are out of my control. I've run into situations in the past where someone creates a variable named state and adds it to the context and also creates a template named state and intends to include that into their template.
For now, I'm namespacing the templates under a variable t to prevent these collisions. So someone can write a template like:
This is a state: {{ state }}

This is the state template:
{% include t.state %}

If the include (or another template tag include2) was context aware and took a string instead, this conflict would not occur.

But the include tag DOES take a string:
{% include 'state' %} includes the template with the name state, without looking at any variables.

Yup! I understand that.
However, it will use the template loader which isn't content aware. I need to load a different template based on some information in the context (i.e. some sort of override id).
The error occurs when I do something like:
context_from_user = {'state': 'NJ', story_id: 1}
additional_referenced_templates = {'state': sometemp} # queries from a database based on the Include nodes in the template and the story_id from the context
context = {**context_from_user, **additional_referenced_templates}
template.render(context)

Basically, it would clean up the logic a lot if I could use a context aware template loader that encapsulated this logic instead of sticking the templates into the context.
This might be too much of an edge case, but I've run into this more than a few times.

Is there any way to load templates relative to the caller? I currently namespace each of my templates and I want to be able to load templates relative to the current namespace. So if I'm loading a template with the namespace "my.current.namespace" and I try to load template "lede", I want it to first search "my.current.namespace" for that template.
So is there anyway to pass information to the template loader regarding the current namespace / the caller template? If not, I need to resolve the relative template name into an absolute template path and I'm not sure where that code would go either.


feat/serialization: add serialization

WIP, the commit for deserialization is still missing because it needs a bit of polish
Will resolve #14, #15

@MichaelHirn :)

Thank you, @hobofan
Are now all layers serializable? Also could you add a test/example of the serializing/deserializing a network?

@MichaelHirn All layers are serializable, and I added a basic test of saving and loading, and a example for each.

LGTM. Thank you for the update. Ready to merge

@homu r+

:pushpin: Commit df7c9d8 has been approved by MichaelHirn

:zap: Test exempted - status


Notebook does not respond to key-presses after waking from sleep

Environment

Elixir & Erlang/OTP versions (elixir --version): 1.13.3, Erlang/OTP 24 [erts-12.2.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit] [win32]
Operating system: Windows 11
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): livebook server
Livebook version (use git rev-parse HEAD if running with mix): 0.5.2
Browsers that reproduce this bug (the more the merrier): Edge
Include what is logged in the browser console:

Uncaught Error: Unexpected server acknowledgement.
    at e.value (app.js:2:2884292)
    at e.value (app.js:2:2883250)
    at e._onAcknowledgement (app.js:2:2882800)
    at app.js:2:2891420
    at i (app.js:2:2847866)
    at Object.dispatchEvent (app.js:2:2825597)
    at If.constructor.dispatchEvent (app.js:2:3392280)
    at app.js:2:3392358
    at Array.forEach (<anonymous>)
    at If.constructor.dispatchEvents (app.js:2:3392335)

Include what is logged to the server console:

Current behavior
Start app with iex.bat --sname myname --cookie mycookie -S mix phx.server
Start livebook with livebook server
Connect to node (same thing happens with Elixir Standalone though)
Create a notebook, type some stuff, save it.
Put computer to sleep.
Wake computer.
(I think you have to reconnect to the node at this point)
Type in notebook -> typing does nothing, autosave still triggers.  Above error seen in browser console.  Can create new sections, but can't type in them.
If I close and then open the notebook, I see all the random stuff I was typing in the notebook.
Expected behavior
Things I type would appear in the notebook.

Thank you @simonmcconnell! Can you please check if this issue happens in other browsers? Also, for how long does Livebook sleep? Is it a matter of a few seconds or close to a minute or more?

Initially I had the laptop closed overnight, but if I sleep and wake it up straight away it does it.
Firefox seems fine.  Chrome has same issue.  Do you want me to try Opera, Brave, Vivaldi...?

@simonmcconnell Firefox and Chrome is enough, thank you!

@simonmcconnell does it help if you just refresh the page, or do you need to re-open the notebook to fix it?

The problem is that we don't handle reconnection properly, this can be reproduced with liveSocket.disconnect() followed by liveSocket.connect().
Apparently, Firefox keeps the connection on Windows hibernation, while Chrome/Edge don't, thanks @wojtekmach for helping to debug this!


Fixed typo in bit-functions.md

@RibShark : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@RibShark : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Resized screenshot; changed img to GitHub flavored MD image

In Atom, the preview animation only shows up as an  tag. This pull request resizes the animated gif to the width set in the  attribute and changes the image syntax to use GitHub Flavored Markdown for image inclusion.

It's using an img tag so we can set the width to half the size, as that's the only way to achieve retina (highdpi) support in Markdown. Can you instead open an issue on Atom? It should support img tags...


starship: add module

Add module for https://starship.rs

Thanks! Rebased to master in 7205d3b2d2192b6f0d3fe54a4cf38525ec4e27f5.


ExAd on Tanoa

hay i have a Question i want to wart you ExAd0.8.2 on Exile taono i have install it with you video but ther server dosn´t work now .... :(
i see in you video you testing the statusbaron tanoa . i  have install Core then  xm8 then VG . dosent work :(
last question where i find you new statsbar?
thx Kenneth
sorry for my bad englisch i am from germany i hope you can read it

This is not a bug, ask in the exile forum. Pretty sure someone can help you

ok thx i have found ist :) but verry thx for you time :)


Add ISS Connector

This is a connector for the Where the ISS at? API, returning real-time positional data for the International Space Station.

Could you switch the config & schema to use DataStudioApp. See #83 for what this change looks like.


Cookiecutter tap.py template not assigning SQLTap as parent class for the tap when initializing a SQL stream type project

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/353
Originally created by @BuzzCutNorman on 2022-03-29 17:27:18

Summary
When you initialize a tap with a stream type of SQL using the Meltano SDK v0.4.4 the new tap class in the tap.py file does no have the parent as class of SQLTap it has the parent class of Tap instead.  I believe this happens because the tap.py template in keying off cookiecutter.source_name instead of the cookiecutter.stream_type
Steps to reproduce
cookiecutter https://gitlab.com/meltano/sdk --directory="cookiecutter/tap-template"

source_name [MySourceName]: test
admin_name [FirstName LastName]: Dan Norman
tap_id [tap-test]:
library_name [tap_test]:
Select stream_type:
1 - REST
2 - GraphQL
3 - SQL
4 - Other
Choose from 1, 2, 3, 4 [1]: 3
Select auth_method:
1 - API Key
2 - Bearer Token
3 - Basic Auth
4 - OAuth2
5 - JWT
6 - Custom or N/A
Choose from 1, 2, 3, 4, 5, 6 [1]: 3
Select include_cicd_sample_template:
1 - GitHub
2 - None (Skip)
Choose from 1, 2 [1]:

What is the current bug behavior?
In the tap.py file for the tap example above the class looks like this after initialization:
class Taptest(Tap):
What is the expected correct behavior?
I would expect to see the tap class to look like this:
class Taptest(SQLTap):
Relevant logs and/or screenshots
Possible fixes
sdk/cookiecutter/tap-template/{{cookiecutter.tap_id}}/{{cookiecutter.library_name}}/tap.py
line 31:
class Tap{{ cookiecutter.source_name }}({{ 'SQL' if cookiecutter.source_name == 'SQL' else '' }}Tap):
Propose changing line 31 to:
class Tap{{ cookiecutter.source_name }}({{ 'SQL' if cookiecutter.stream_type == 'SQL' else '' }}Tap):

View 6 previous comments from the original issue on GitLab


gMAM for the Maier-Steiner model

I am working on an example notebook for the Maier-Steiner model.
I am trying to reproduce Figure 1 from the paper.

However, it does not seem that the implemented geometric_min_action_method gives the right result.  Am I doing something wrong here:
using CriticalTransition, StaticArrays, LinearAlgebra
using CairoMakie

function meier_stein!(du, u, p, t) # in-place
    x, y = u
    du[1] = x-x^3 -10*x*y^2
    du[2] = -(1+x^2)*y
end
function meier_stein(u, p, t) # in-place
    x, y = u
    dx = x-x^3 -10*x*y^2
    dy = -(1+x^2)*y
    SA[dx, dy]
end
σ = 0.25
sys = StochSystem(meier_stein, [], zeros(2), σ, idfunc, nothing, I(2), "WhiteGauss")

bmin = [-1.5, -0.6]; bmax = [1.5, 0.6]
fp, eig, stab = fixedpoints(sys, bmin, bmax)
stable_fp = fp[stab]

gm = geometric_min_action_method(sys, fp[stab][1], fp[stab][2], N=50, maxiter=100)
path  = gm[1][end]

res = 100
u_min = -1.5; u_max = 1.5;
v_min = -0.5; v_max = 0.5
u_range = range(u_min, u_max, length = res)
v_range = range(v_min, v_max, length = res)

du(u, v) =   u-u^3 -10*u*v^2
dv(u, v) = -(1+u^2)*v
odeSol(u, v) = Point2f(du(u, v), dv(u, v))

z = [log(sqrt(du(x, y)^2 + dv(x, y)^2)) for x in u_range, y in v_range]
zmin, zmax = minimum(z), maximum(z)

fig = Figure(size = (600, 400), fontsize =13)
ax = Axis(fig[1, 1], xlabel = "u", ylabel = "v", aspect=1.4,
    xgridcolor = :transparent, ygridcolor = :transparent,
    ylabelrotation = 0)

streamplot!(ax, odeSol, (u_min, u_max), (v_min, v_max);
    gridsize = (20, 20), arrow_size = 10, stepsize = 0.01,
    colormap = [:black, :black]
    )
colgap!(fig.layout, 7)
limits!(u_min,u_max,v_min,v_max)
fig

[scatter!(ax, Point(fp[i]), color = stab[i] > 0 ? :red : :dodgerblue,
    markersize = 10) for i in eachindex(fp)]

lines!(ax, path  )
fig

Thanks for trying this! I tweaked your code a bit and found two things

gMAM does not guarantee finding the global minimum. In your code the path is initialized as a straight line which I think could be a local minimum for the Maier-Stein model (haven't verified). If I initialize the path as a parabola, it finds the correct minimizer.
The minimization procedure seems quite sensitive to the hyperparameters such as number of path points. If I change N=50 to N=30, it also finds the right minimizer.

Currently our code formulates the minimization problem and simply passes it to Optim - to get more robust results with respect to the hyperparameters we might need to tweak the Optim default settings a bit more.
Here's my code:
using CriticalTransitions, StaticArrays, LinearAlgebra
#using CairoMakie
using PyPlot

function meier_stein!(du, u, p, t) # in-place
    x, y = u
    du[1] = x-x^3 -10*x*y^2
    du[2] = -(1+x^2)*y
end
function meier_stein(u, p, t) # in-place
    x, y = u
    dx = x-x^3 -10*x*y^2
    dy = -(1+x^2)*y
    SA[dx, dy]
end
σ = 0.25
sys = StochSystem(meier_stein, [], zeros(2), σ, idfunc, nothing, I(2), "WhiteGauss")

bmin = [-1.5, -0.6]; bmax = [1.5, 0.6]
fp, eig, stab = fixedpoints(sys, bmin, bmax)
stable_fp = fp[stab]

# initial path: parabola
xx = range(-1.0,1.0, length=30)
yy = 0.3 .* (- xx .^ 2 .+ 1)
init = Matrix([xx yy]')

# initialize from straight line (50 points)
gm = geometric_min_action_method(sys, fp[stab][1], fp[stab][2], N=50, maxiter=200, converge=1e-7)
path  = gm[1][end]

# initialize from straight line (30 points)
gm2 = geometric_min_action_method(sys, fp[stab][1], fp[stab][2], N=30, maxiter=200, converge=1e-7)
path2  = gm2[1][end]

gm3 = geometric_min_action_method(sys, init, maxiter=200, converge=1e-7)
path3 = gm3[1][end]

begin
    fig, ax = subplots(dpi=150)
    ax.plot(xx,yy, ls="--", c="gray")
    ax.plot(path[1,:], path[2,:], label="Path, S=$(round(gm[2][end], digits=5))")
    ax.plot(path2[1,:], path2[2,:], label="Path 2, S=$(round(gm2[2][end], digits=5))")
    ax.plot(path3[1,:], path3[2,:], label="Path 3, S=$(round(gm3[2][end], digits=5))")
    ax.legend(title="S = Action value")
    display(gcf())
end

Thank you very much for the help! It totally missed in the documentation that you can choose your initial path. I will highlight this in the example notebook.
I also think the straight line is a sort of local minima. It is at least the naive path (heteroclinic orbit) one would think the system takes without using gMAM.


Add: TV SIM Colatina [BR]

Channel Name
TV SIM Colatina
Alternative Names (optional)
No response
Network (optional)
Rede SIM
Owners (optional)
No response
Country
BR
Subdivision (optional)
BR-ES
City (optional)
Colatina
Broadcast Area
s/BR-ES
Languages
Por
Categories (optional)
News
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://www.simnoticias.com.br/
Logo
https://i2.paste.pics/db2a7481ddc4276b0c2083d96105711a.png
Notes
https://5cf4a2c2512a2.streamlock.net:443/8132/8132/playlist.m3u8

Thank you for the stream: it will be included in the next release.


[Perf] wrk2 test failure

Current Behavior

Expected Behavior

Environment

Host OS: Mac
Platform: Docker

➜  ~ mesheryctl version
      	VERSION    	GITSHA
Client	v0.5.56    	db2269ce
Server	edge-latest	07d863e4

Screenshots/Logs
meshery_1               | time="2021-09-16T19:53:18Z" level=info msg="attempting to save performance profile to remote provider"
meshery_1               | &{ID:<nil> Name:wrk2 against Istio LastRun:<nil> Schedule:<nil> LoadGenerators:[wrk2] Endpoints:[http://bookinfo.meshery.io/productpage] ServiceMesh:istio ConcurrentRequest:4 QPS:20 Duration:30s TotalResults:0 RequestHeaders: RequestCookies: RequestBody: ContentType: UpdatedAt:<nil> CreatedAt:<nil>}
meshery_1               | time="2021-09-16T19:53:18Z" level=info msg="performance profile successfully sent to remote provider: {\"id\":\"6baa25cd-d191-4cca-baaf-e0d2b258a515\",\"name\":\"wrk2 against Istio\",\"user_id\":\"bdc294ce-65da-41df-877c-4800f05641d8\",\"load_generators\":[\"wrk2\"],\"endpoints\":[\"http://bookinfo.meshery.io/productpage\"],\"service_mesh\":\"istio\",\"concurrent_request\":4,\"qps\":20,\"duration\":\"30s\",\"created_at\":\"2021-09-16T19:53:18.352037Z\",\"updated_at\":\"2021-09-16T19:53:18.352047Z\"}\n"
meshery_1               | time="2021-09-16T19:53:19Z" level=info msg="perf test with config: &{istio_1631821999773  http://bookinfo.meshery.io/productpage 20 4 <nil> <nil> []  false 30s wrk2 0    true 0 false  false 0s}" app=meshery
meshery_1               | time="2021-09-16T19:53:19Z" level=info msg="retrieved user: {leecalcote   https://avatars.githubusercontent.com/u/7570704?v=4}"
meshery_1               | time="2021-09-16T19:53:19Z" level=error msg="unable to execute the requested command: exit status 1" app=meshery code=2050 probable-cause="Load test endpoint could be not reachable" severity=2 short-description="load test error: .unable to perform" suggested-remediation="Make sure load test endpoint is reachable"
meshery_1               | time="2021-09-16T19:53:19Z" level=error msg="unable to execute the requested command: exit status 1"
meshery_1               | time="2021-09-16T19:53:34Z" level=error msg="failed to parse edge-latest, Malformed version: edge-latest" app=meshery code=2138 probable-cause= severity=2 short-description="failed to compare latest and current version of Meshery" suggested-remediation=

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I couldn't repro this exactly. However wrk2 load tests fail sometimes. For me it is:
ERRO[3995] unable to marshal the result: invalid character ':' after top-level value
ERRO[2021-09-28T18:33:35+05:30] unable to marshal the result: invalid character ':' after top-level value  app=meshery code=2050 probable-cause="Load test endpoint could be not reachable" severity=2 short-description="load test error: .unable to perform" suggested-remediation="Make sure load test endpoint is reachable"

This is happening because wrk2 produces the below output sometimes which is not a valid JSON and when gowrk2 tries to marshal this, it fails. A fix for this would have to be in gowrk2 itself.
"Count": 14,
{
"TotalRequests": 62,
"DurationInMicroseconds": 30003155.00,
"Bytes": 10664,
"RequestsPerSec": 2.07,
"BytesTransferPerSec": 355.43,
"Errors": 0.00,
"MinLatency": 1028.00,
"AvgLatency": 2345.20,
"MaxLatency": 7636.00,
"StdDev": 1516.52,
"Url_0": "http://localhost:18080/",
"UrlRequestCount_0": 62,
"Percentiles": [
                {
"Count": 1,
"Percent": 1,
"Value": 1.028000
                },
                {
"Count": 1,
"Percent": 2,
"Value": 1.028000
                },
.
.
JSON continues.

@piyushsingariya I wonder if you might have a look at the issue of version checking with the "edge-latest" tag.

@piyushsingariya I wonder if you might have a look at the issue of version checking with the "edge-latest" tag.

Will try! :+1:


flannel : Restart flannel [Unable to restart service flannel: Failed to restart flannel.service: Unit docker.socket not found.]

After a fresh installation (with vagrant destroy -f and new ./create_all.sh), flannel isn´t able to restart properly.

Wohoo, this https://forums.docker.com/t/failed-to-start-docker-service-unit-docker-socket-not-found-after-kernel-update-on-lubuntu/62604/2 describes the point - Docker not only removed the default usage of docker.socket  inside the docker.service systemd configuration - but they also changed ExecStart config! Old (not working any more as of 18.09):
ExecStart=/usr/bin/dockerd \
    ...
    -H fd://

New, now working from 18.09 on:
ExecStart=/usr/bin/dockerd \
    ...
    -H unix://

See https://forums.docker.com/t/failed-to-load-listeners-no-sockets-found-via-socket-activation-make-sure-the-service-was-started-by-systemd/62505/2


Add cache_pygates feature to accelerate crate.

Summary
The following commits add the cache_pygates feature from the circuit crate into accelerate.
Details and comments
Since we added rust native methods to add operations into the DAGCircuit (thanks in part to #13143), we make use of the cache_pygate feature which is only available in the circuit crate. A couple of transpiler passes which require building instances of DAGCircuit from Rust entirely (mainly #13141, and #13137) are using these functions, they need to respect the bounds this feature specifies or else they would not compile.
A couple of teammates have already implemented this flag as part of their PRs but, to prevent a future merge conflict debacle, I decided to put it in this PR. These commits add the feature to accelerate so that people don't have to worry about that in the future.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
13 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.008%) to 88.819%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/parse.rs
6
97.61%

crates/qasm2/src/lex.rs
7
92.48%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.008%

Covered Lines:
73475

Relevant Lines:
82724

💛  - Coveralls


Replace "sudo" usage with "become"

The direction of current and future Ansible (as of 1.9+) appears to be removing sudo and using become for privilege escalation.
To that end, usage of sudo should be replaced with become and tasks which require escalated privileges should likely individually define the become usage.

thx to @smiller171 see #12


data_cache_hit_writeback_invalidate never returns

I managed to make a ROM that hangs at boot. Making cen64 print what it executes, it jumps to data_cache_hit_writeback_invalidate after data_init, and never returns. It spins there forever.
Are the cache functions buggy in that they expect a divisible-by-four size without checking, or is it the linker script that somehow outputs non-4-divisible symbols?
Here's the relevant boot code disasm:
80000460 <data_init>:
80000460:       8cc80000        lw      t0,0(a2)
80000464:       24c60004        addiu   a2,a2,4
80000468:       ac880000        sw      t0,0(a0)
8000046c:       24840004        addiu   a0,a0,4
80000470:       0085082b        sltu    at,a0,a1
80000474:       1420fffa        bnez    at,80000460 <data_init>
80000478:       00000000        nop
8000047c:       00000000        nop
80000480:       3c048000        lui     a0,0x8000
80000484:       24840560        addiu   a0,a0,1376
80000488:       3c058005        lui     a1,0x8005
8000048c:       24a5adde        addiu   a1,a1,-21026
80000490:       00a42822        sub     a1,a1,a0
80000494:       0c000e42        jal     80003908 <data_cache_hit_writeback_invalidate>

So a0, __text_start is 0x80000560, and a1 __data_end 0x8005ADDE, making the %4 be 2, and the cache op never gets out of the loop.

Hm, it looks like the same can happen for bss too.

The linker script also can't handle nested /**/ comments, seemingly.

Besides the comment change, the linker script should consider text.* and rodata.* part of text and rodata, respectively. Those are created not only by default, but especially if -ffunction-sections, -fdata-sections or LTO are used. Whether the alignment should be there or in the funcs, waiting for your opinion. I have it working by aligning in the linker script.


Until DevTools server migrates to null safety we need to update this …

…version after each devtools release.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Actually, can we land this pr instead?

Actually, can we land this pr instead?

Yes please. Good idea trying the deactivate.

This PR was superceded by https://github.com/flutter/flutter/pull/82491


[fix] fix String type comapaction or agg may crash when string is null

Proposed changes
fix String type comapaction or agg may crash when string is null
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No Need)
Has document been added or modified: (No Need)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

merge for quick test


Autopeptideml efficiency

As @keithchev pointed out over in #10:

the use of autopeptideml here is a bit inefficient because it re-generates the ESM embeddings for each of the 12 named models. For now this is probably okay, but it may be worth optimizing if the dataset of combined peptide predictions that are input to autopeptideml becomes large (I would guess larger than ~10,000 sequences).

I think it could be simple to run each autopeptideml model in one script, which would then generate the ESM embeddings only once.
Similarly, keith mentioned:

we should look into the implications of snakemake parallelizing processes that use the GPU (in this case, all of the autopeptideml models). I assume that this is handled in a sensible way at the level of CUDA or the GPU itself, but I'm not sure.

This will be something to keep an eye out for.

Hi @taylorreiter, I just found this project, it seems really cool. I've just released an update to AutoPeptideML (0.3.1) to address this issue. Now, you can calculate the representations one time with:
df_repr = re.compute_representations(df.sequence, average_pooling=True)

and then run the predictions taking the additional argument of df_repr:
    predictions = autopeptideml.predict(
        df=df, re=representation_engine, ensemble_path=model_folder, outputdir=tmp_dirname,
        df_repr=df_repr
    )

This should allow you to run the code in a loop of some sort and avoid calculating the embeddings every time.

Thank you @RaulFD-creator!


Integrate AutoGPT Benchmarks

closing this in favor of https://github.com/polywrap/evo.ninja/pull/179


Cut a formal release of pass-authz

[x] Release jsonld filters to Maven central
[x] Release to Maven central
[x] Create Docker images

CLosed as the result of merging https://github.com/OA-PASS/pass-docker/pull/132


Add templates for issues

Issue templates are very helpful for a collaboration repo. When users identify a bug or want to add a new feature, you can provide templates so you can collect all the pertinent information you need to fix a bug or add a new feature.
We recommend creating a “Report Bug” and “Feature Request” issue template.
you can refer this: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
Some suggested prompts/questions you can add to a “Report Bug” template are:
Briefly describe the bug
What is the expected behavior?
Please provide step by step instructions on how to reproduce the bug
Some suggested prompts/questions you can add to a “Feature Request” issue template are:
Briefly describe your feature request
What problem is this feature trying to solve?
How do we know when the feature is complete?
Reference: https://github.com/Recode-Hive/Stackoverflow-Analysis/issues/new/choose
Click on Get Started button and copy the template to your

i would like to resolve this issue

This is done. So, I'm closing this issue.

Describe the bug
We should update the issue template. We can add more new things like emoji, tags for issues, and titles for every issue, like Docs:, Feat:, Bug:. This way, we can understand the purpose of the issue raised by just seeing the title.
Expected behavior
We can see all issues with a good title so we can easily understand the purpose for which the issue was created.
Screenshots

@ashutoshgithubs


update(k8smeta)!: improve logs and rename some fields

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This PR improves logs and renames some fields for the k8smeta plugin. Please note that renaming from nodename to nodeName is a breaking change!
Which issue(s) this PR fixes:
Special notes for your reviewer:
Please note that renaming from nodename to nodeName is a breaking change!

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Andreagit97
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

/unhold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c604f8d8448716a8a29847fbb08f8fd88e0a77ed


Merge v0.8.0 to master

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 9 committers have signed the CLA.:white_check_mark: MrRaindrop:white_check_mark: sospartan:white_check_mark: cxfeng1:white_check_mark: acton393:white_check_mark: littleseven:white_check_mark: gurisxie:x: zshshr:x: boboning:x: xkli


subclassing xarray discussion

RunTS has_a dataset, which is an xr.Dataset object.  It would be good to discuss the pros and cons of extending xr.Dataset to be a RunTS object.  What would be the advantages and what aspects of the changeover would be difficult.
Jared, Joe, Karl, Lindsey to discuss when Jared returns from AK?

should use apply_ufunc for functions and accessors for xr if need be, for now keeping dataset and dataarray as an attribute.


update tuweni. Switch from org.apache to io.tmio

PR Description
Update to use the latest version of the tuweni library; from org.apache.tuweni 1.3.1 to io.tmio 1.4.2
Aligns with library used by Besu.
Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

I think you meant from 2.3.1 to io.tmio 2.4.2 :)


consolidate template logic & remove kubeadm

What this PR does / why we need it:
This PR will:

Remove kubeadm & remove necessary deb packages

In theory kubeadm is nice, but we maintain coreos already different and had to introduce some special logic to cope with kubeadm changes (default file - dependency issues in the repos)

Provide template functions for all kinds of common flags / configuration we use in all operating systems. This will ensure that we'll always use the same flags on all systems - modifications can be done via a systemd-drop-in

@alvaroaleman PTAL

lgtm aside from the failing tests :)


Cookie fail with messenger.com API

Hi,
Since today or yesterday it seems Facebook change the way to set cookie with messenger.com API.
It seems every methods like sendMessage work, but every methods that use messenger.com fail with :
ERR! changeGroupImage { error: 'Not logged in.' }

I also checked changeThreadColor (use messenger API too), same result.

This is also a problem with setTitle.

I'm also getting this error with setTitle

@Schmavery any thoughts?

Just did it in the browser to see what it returned

Not sure, @bobland1 seems to have the right idea though you might want to be looking at the cookies. I think this is where we set them on login.
https://github.com/Schmavery/facebook-chat-api/blob/7470cfe9b29d30f082f76cacc08748e4e19e8c15/index.js#L365-L369
I think the saveCookie function also does a bit of a hack to support messenger and facebook apis:
https://github.com/Schmavery/facebook-chat-api/blob/7470cfe9b29d30f082f76cacc08748e4e19e8c15/utils.js#L1108-L1120

Test Post Color Obtains

POST /messaging/save_thread_color/?source=thread_settings&dpr=1 HTTP/1.1
Host: www.facebook.com
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Accept: /
Accept-Language: es-CL,es;q=0.8,en-US;q=0.5,en;q=0.3
Accept-Encoding: gzip, deflate, br
Referer: https://www.facebook.com/
Content-Type: application/x-www-form-urlencoded
Content-Length: 617
Cookie: fr=0SAVutN26ENbCsMy2.AWUKXQFX_xonlLFajGtWj9o1bU8.Ba0Blw.BE.FtF.0.0.BbVfin.AWWAh7RG; sb=_CvQWu2U9llHfMbCWZuScb4W; wd=1295x630; datr=CvQWp_Vr7jBeExhqBqUW3NY; c_user=100007502617855; xs=36%3ArjizAn_QTGVdqw%3A2%3A1523592203%3A14997%3A12965; spin=r.4129119_b.trunk_t.1532360868_s.1_v.2; presence=EDvF3EtimeF1532360930EuserFA21B07502617855A2EstateFDt3F_5bDiFA2user_3a1B04989069223A2ErF1EoF1EfF2C_5dElm3FA2user_3a1B04989069223A2Eutc3F1532360877291G53236093B6CEchFDp_5f1B07502617855F11CC; act=1532360926455%2F3
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache

Thanks @Theblood. I've redacted a couple of fields from your cookie information. As a reminder to everyone, sharing your cookies publicly for most sites is equivalent to providing the public with your login information, they can generally just get access to your logged in session. You may want to log out and back in on that machine to be safe, even though I deleted the creds.

Any progress on what the underlining issue is here? found its not working with anything where u set or add something. like add reaction or set title

The request header cookies:

:authority: www.messenger.com
:method: POST
:path: /webgraphql/mutation/?doc_id=1491398900900362&variables=%7B%22data%22%3A%7B%22client_mutation_id%22%3A%220%22%2C%22actor_id%22%3A%22100007819751912%22%2C%22action%22%3A%22ADD_REACTION%22%2C%22message_id%22%3A%22mid.%24gAAblGMtGYeVrNkiJCllBQM1csw5l%22%2C%22reaction%22%3A%22%F0%9F%98%8D%22%7D%7D&dpr=1
:scheme: https
accept: /
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9
content-length: 480
content-type: application/x-www-form-urlencoded
cookie: datr=iJZUW0hCNloD0_aVj3bTLho1; sb=l5ZUWwNpt-MZu7maHRMrJiyn; c_user=100007819751912; xs=19%3ASJFpp9xpQnK0pQ%3A2%3A1532270231%3A15073%3A4439; wd=661x947; presence=EDvF3EtimeF1533387771EuserFA21B07819751912A2EstateFDutF1533387771565CEchFDp_5f1B07819751912F2CC; act=1533387783218%2F5; pnl_data2=eyJhIjoib25hZnRlcmxvYWQiLCJjIjoiWE1lc3NlbmdlckRvdENvbU1haW5Db250cm9sbGVyIiwiYiI6ZmFsc2UsImQiOiIvdC8xOTQwNzQ0NTEyNjI3MTczIiwiZSI6W119
origin: https://www.messenger.com
referer: https://www.messenger.com/t/1940744512627173
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

@MzHub Mostly the latter. I have not much time for this repo these days but luckily many issues get fixed by the community. Feel free to take a shot at this one! I tried to provide some relevant code locations and am happy to provide any advice I can as I'm available. I can't imagine it will be that crazy of a fix, just seems like no one has had the opportunity/motivation to look at it yet. I'm sure everyone would be happy if it was taken care of :)

I get the same error with changeNickname, I suspect it's similar/related.  Doubt this actually helps much, but, it's another function that doesn't appear to be working right at the moment.

Tried a bit to fix this tonight. After some reseach, the problem come from the cookie "xs".
I tried to set it manually once (sorry for the ugly code, don't really know JS) :

Then revert changes, and now it works.
Not sure to have some time soon to fix this, but now we have a precise idea of what's wrong.
More over, the value seems to differ between facebook.com and messenger.com, but :

Using the value from messenger.com on facebook.com is not an issue
Usieng the value from facebook.com on messenger.com doesn't log you.

If I understood the code correctly, the cookies values are found on facebook.com only, so the issue is here.

@ArthurGarnier when you set the value manually, what were you setting it to?

xs cookie valu from messenger.com if I remind correctly

Does forwardAttachment use the same API? I get the same error.

Yes, it's messenger.com api too

Any news on when is this gonna be fixed?

Bump, looking for a fix

Me too, I also have the same problem, but it seems that it has not been resolved, yet.

Hi @ArthurGarnier perhaps you could describe how to approach this issue in some more details?

Hello @cevantes
If I knew how to fix it, I would already did it :)
I shared all the details I have, but I'm not a JS dev (not even a dev in fact ;) )

Ah no problem, I might take a look at it, just wanted to save time if anyone has already put effort into it.

dump

I haven't had the time to dig into this deeply.
I linked to some relevant code and thanks a lot to the people who have put some work into investigating.
It seems like the hack we used in saveCookies (below) to reuse facebook sessions on messenger is no longer working. Maybe someone should compare their facebook cookies to their messenger cookies and see if it's potentially a simple format change (we're probably not that lucky though).
https://github.com/Schmavery/facebook-chat-api/blob/7470cfe9b29d30f082f76cacc08748e4e19e8c15/utils.js#L1108-L1120
More likely it seems that we'd have to either switch the entire login flow to use messenger 😨 or hopefully just remove this part from saveCookies:
https://github.com/Schmavery/facebook-chat-api/blob/7470cfe9b29d30f082f76cacc08748e4e19e8c15/utils.js#L1115-L1116
and then add something along the lines of this somewhere in index.js:
utils
  .get("https://messenger.com", ctx.jar, form, globalOptions)
  .then(utils.saveCookies(ctx.jar));

Those parameters might need a lot of tweaking but if we're lucky that might be enough to "harvest" the messenger.com cookies. Otherwise we might need to add some code that tries to step through the messenger.com login flow (seems like a reasonably high chance that would be the case and would be more involved, but still basically just submitting requests in sequent).

I have tested this fix and can confirm that it works on changeThreadEmoji, changeNickname, setTitle, changeGroupImage, changeThreadColor, changeAdminStatus, setMessageReaction, createPoll, and forwardAttachment, which all had a messenger.com endpoint in common (surprise, surprise).
I believe this covers everything that errors were reported for 🙂. @lequanglam has packaged this into a PR here (just to directly link it to this thread).
 @Schmavery could we get a merge on that PR?

Thanks for testing @AstroCB. We knew those had the messenger.com endpoint in common, it was because facebook.com didn't used to expose those endpoints. Great to have it resolved, will merge.

Can confirm it works !
That's weird I tried to change the domain several weeks ago and it didn't work.
Thank you for the fix !


Added template tag in LicenseIcons.vue around the v-if img

Fixes #653

Initially, v-for and v-if are present on the same node. This PR corrects that and adds a template around to make it more readable and follows the style-guide of vue.

Developer Certificate of Origin Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open-source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

When I was writing the description my Grammarly pointed an error and a clarity check in the Developer Certificate of Origin, changes were

change open source to open-source
change By making a contribution to this project to By contributing to this project

I don't know where can I change them so I am commenting them here

@hemanth-hk We're using the original DCO: https://elinux.org/Developer_Certificate_Of_Origin and will not be making changes, since it's a standard document.

Yup, I added /> at the end of the img tag, Please review


add taiki-es patch https://github.com/taiki-e/cargo-llvm-cov/pull/266#issuecomment-1527785686

For that patch to work, you need to apply the patch to https://github.com/taiki-e/cargo-llvm-cov/pull/266, not the main branch.


is there any demo source code for us to refer?

We plan to release a simple demo shortly, stay tuned!
At the meantime, please keep an eye on our spectrum channel, and checkout the [Step by step - Create a Twill app] if you are interested!

@yanhao-li 2021 still nothing, why the secrecy on the demo?


Does the product_name have any relevance on Win?

When building atom-shell with custom GYP_DEFINES it is possible to define a project and a product name.
The resulting executable carries the project name (all build and ouput file related to it do too) - at leats on windows.
TBH i only skimmed through the atom.gyp, but my first impression is that the product_name is only ever used under linux/osx environments.
Can you elaborate on what these two definitions actually stand for?

project_name is like the executable file's name of your app, and product_name will be used as your app's name. It is totally fine to use the same name for both, but sometimes people would prefer a short lower-cased name for project_name.
As an example, in Atom editor, project_name is atom and product_name is Atom.

I see, thanks ^^


Remove V1 REST endpoints

🚀 Feature Request
Relevant Package
All services
Description
Since V2 APIs are available, we could remove all the V1 endpoints in router.

This issue is hold until we complete V2 supporting services


When does Open Distro support version 6.6?

As title.

Hi @scf0920, we try to stay current, but there's always going to be a bit of lag time between the latest open source release and the next Open Distro for Elasticsearch release so that we have time to test and modify the plugins. I can also imagine us skipping a minor Elasticsearch version if two come out in quick succession.


Can't build latexpdf with revealjs_break

Is it possible to ignore revealjs_break directive while building with latexpdf ?
 File "/home/use/doc/.tox/revealjs/lib/python3.9/site-packages/docutils/nodes.py", line 2056, in unknown_departure
    raise NotImplementedError(
NotImplementedError: <class 'sphinx.writers.latex.LaTeXTranslator'> departing unknown node type: revealjs_break

Regards

v1.5.3 includes workaround code for this.
Please update sphinx-revealjs in your environment if you can do it.


download-archive documentation

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
Documentation request - I'm not seeing a proper place to suggest updates to the documentation, so here I am.
From the built-in help:
    --download-archive FILE          Download only videos not listed in the                                      archive file. Record the IDs of all                                      downloaded videos in it
I think it should say: Record the IDs of all newly downloaded videos into it
Verbose log
No response

That is not correct though. It also records videos that "has already been downloaded". See this example:
❯ del archive.txt && yt-dlp -f wa d-u_7WV1Yl8 DRjbuXjNwrk --download-archive archive.txt
[youtube] d-u_7WV1Yl8: Downloading webpage
[youtube] d-u_7WV1Yl8: Downloading android player API JSON
[info] d-u_7WV1Yl8: Downloading 1 format(s): 139
[download] Destination: Feel Deep Black 12K HDR 60fps ( Dolby Vision ) [d-u_7WV1Yl8].m4a
[download] 100% of 1.09MiB in 00:00
[FixupM4a] Correcting container of "Feel Deep Black 12K HDR 60fps ( Dolby Vision ) [d-u_7WV1Yl8].m4a"
[youtube] DRjbuXjNwrk: Downloading webpage
[youtube] DRjbuXjNwrk: Downloading android player API JSON
[info] DRjbuXjNwrk: Downloading 1 format(s): 139
[download] F-22 Raptor Demo Thunder Over Michigan 2016 5.1 Surround Sound Video (4K) [DRjbuXjNwrk].m4a has already been downloaded
[download] 100% of 22.40MiB
WARNING: DRjbuXjNwrk: writing DASH m4a. Only some players support this container

❯ type archive.txt
youtube d-u_7WV1Yl8
youtube DRjbuXjNwrk

That is not correct though. It also records videos that "has already been downloaded". See this example:

That's not entirely correct, either. Your example breaks if certain assumptions are not met:

If the title of the downloaded video changes
If the OUTPUT TEMPLATE changes
If --restrict-filenames is changed
If a different format/extension is downloaded

Also, saying  "already been downloaded" is misleading. If I have 100 downloaded videos in a directly, and delete the "archive.txt", that "archive.txt" will only re-populate with files that I attempt to re-download, and even then accounting for the assumptions listed above (and other assumptions?) that effect file-names.
Saying that “It also records videos that "has already been downloaded"” gives the impression that it reads the file-names of the videos already downloaded to the directory, and populates the "archive.txt" based on the directory contents, even if there's no attempt to -re-download those videos.
Here's two ways to break your example, every time the "archive.txt" file is deleted:
yt-dlp -f wa d-u_7WV1Yl8 DRjbuXjNwrk -o '%(title)s-%(epoch)s.%(ext)s' --download-archive archive.txt
yt-dlp -f wa d-u_7WV1Yl8 DRjbuXjNwrk -o '%(title)s-%(autonumber)s.%(ext)s' --download-archive archive.txt

It also records videos that "has already been downloaded"

Also, saying "already been downloaded" is misleading.

Sorry, I should have been more clear about this. What I meant is - archive does record videos that are skipped due to being detected to have already been downloaded; and so saying that it only records newly downloaded videos is wrong. (I assumed the quotes along with the log makes that clear. But evidently not)

I'm figuring it out, and you're helping me to figure it out, but I'm starting to see why maybe it's not yet fully/accurately documented. It's easy to see it and learn it, but it's tricky to describe and document.


404 error opening cask-repair pull request

I'm trying to use cask-repair to submit a new version of an app and get the following error:
Is everything correct? ([y]es / [n]o / [e]dit) y
Submitting…
Error creating pull request: Not Found (HTTP 404)
Not Found
Are you sure that github.com/homebrew/homebrew-cask exists?

There was an error submitting the pull request. Please open a bug report on the repo for this script (https://github.com/vitorgalvao/tiny-scripts).

Connections to GitHub work fine:
❯ ssh -T<EMAIL_ADDRESS>Hi trolley! You've successfully authenticated, but GitHub does not provide shell access.

OS: macOS 11.0.1
git: 2.29.2

Like most problems in cask-repair, this is on hub’s side, so it’s out of my hands. I no longer debug hub issues (I’ve mentioned that in another PR).
It is was a simple version bump, I recommend you use brew bump-cask-pr instead.


fix: Remove default values for security_group exampels

Issue: https://github.ibm.com/goldeneye/issues/issues/2327
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Tick the relevant boxes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples / tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc)

Checklist:

[ ] If relevant, a test for the change has been added / updated as part of this PR.
[ ] If relevant, documentation for the change has been added / updated as part of this PR.

Merge:
Merge using "Squash and merge" and ensure to use a relevant conventional commit message based on the PR contents (this ultimately determines if a new version of the modules needs to be released, and if so, which semver number should be used).

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

GitHub release
v1.0.2

Your semantic-release bot :package::rocket:


Make reload non-blocking in feedlist

Partial fix for:

https://github.com/newsboat/newsboat/issues/75
https://github.com/akrennmair/newsbeuter/issues/606

It is probably possible to apply the same fix to make reload non-blocking in the ItemListFormAction.
However, I still need to verify this does not have unintended consequences.
The current changes have the effect that single-feed reloads will also start sending notifications (related to notify-program, before, notifications were only sent when finishing a reload-all action). To reproduce, add the following to the config file:
notify-program "notify-send"
notify-always yes

I think that should not happen, do others agree?
Marking as draft as I need to verify there are no other unintended changes.

Coverage decreased (-0.005%) to 57.294% when pulling d02975436dce1af0f9f9b5fccdfe0ba71854c85b on dennisschagt:feature/nonblocking-reload-feedlist into fba9376b2b89b2b4eb55078db510a07d5a01816e on newsboat:master.

I think that should not happen, do others agree?

I agree. Reloading a single feed is expected to finish quickly, so a notification will be redundant most of the time.

I'm currently not interested in spending a lot of time on this feature.
This might result in this PR being open (as a draft) for a long time.
@Minoru: If you ever want to clean up open PRs, feel free to close this one.
I can always reopen it when I have a full solution.

Okay. Thanks for the research you've done already!

Closing this PR as I don't plan to work on this feature anytime soon.


refs #4662 - If a property has no annotation, but only a getter, it should be read-only.

See issues#4662

@fehguy What can be done to get pull requests, such as this one, get merged in more quickly?


Wiki tutorials no longer work

With the Sharpex2D-1.3.0 release, as in the tutorials, it works right out of the box by adding the existing Sharpex2D / Sharpex2D.CSCore projects to your new project, but on the more recent commits of the master branch, this just leads to 'type or namespace could not be found' errors, so solutions made using the project won't compile.

It would be nice, even just to explain how to load content with the API2-working branch.  When trying to load a simple image.png file with
var texture = Content.Load<Texture2D>("ball.png");
I get:
An unhandled exception of type 'System.IO.EndOfStreamException' occurred in mscorlib.dll
Additional information: Unable to read beyond the end of the stream.

You need to use the content pipeline tool. You Clan configure it as Post Build Event - it takes an Input and an Output path.


Generate the vimrc for users to just source

We have lots of these things now, and managing the vimrc is a bit fiddly (mine is getting big).
Occurred to me that it's super easy to make a file which user can just source based on which ones they chose.
thoughts ?
Other changes:

made some install.py files executable
made one of them work with pip3 rather than pip
fixed purescript/viml error

This change is

I really like the idea, but I don't have the time to review right now. My .vim/plugin/Ycm.vim is getting filled with ycm_language_server setup.

Sure no rush.

Thanks. I should update the README too.

updated README let's merge


Equivalent of pip install -e <path> for CondaPkg.jl?

One feature I would really like for CondaPkg.jl to have is the ability to add a local version of a Python package, aka the equivalent of pip install -e <path/to/python/package>. Would that be as simple as adding some extra code to _resolve_pip_install: https://github.com/cjdoris/CondaPkg.jl/blob/4d48894b54af4129478153d9f27b1908efe909ca/src/resolve.jl#L288 and maybe an editable attribute to PipPkgSpec: https://github.com/cjdoris/CondaPkg.jl/blob/4d48894b54af4129478153d9f27b1908efe909ca/src/spec.jl#L98? I'd be willing to take a stab at this if you'd be OK with the new feature.
Thanks!

Do you specifically need an editable install?
You can already install from a local path by setting the version to @./relative/path or @file:///absolute/path.

Gotcha. My hoped-for workflow is to be able to hack on a local Python package in a "Julia-centric" way—running Julia scripts from the Julia REPL that depend on a local Python package that I'm developing. So I think adding an editable Python package would help with that.
With the @./relative/path or @file:///absolute/path approach, would I need to re-install the Python package every time I make a change to that package?

I see. No, packages using the @ notation are still installed normally (non-editable).
I'd be OK with supporting an editable::Bool entry in PipPkgSpec, with the required changes elsewhere (i.e. parsing deps and resolving).

If we're being really fancy, then we could automatically set editable=true for @ dependencies when the parent package is in dev mode. This might be too magical and slow.

Feel free to take a stab at a PR.


Fix up fmt.Printlns everywhere

There are a lot of fmt.Printlns. They should be treated as a logging dependency, as in, for now it's ok to add a parameter to the function that is a logger interface. We have been using logr.Logger in a few places, so I think it would be good to continue using that.
/kind enhancement

/kind feature

/remove-kind feature
/kind cleanup

Will go ahead and start tackling this.

/lifecycle active

There are 2 main sections that have fmt.Print that can be separated out. One is within the actuators. The other portion is within /kind related files.

I think this is fine too close. there is still some work to do but will be handled by other issues
/close


openjdk9 builds failing on macos

Ref: https://ci.adoptopenjdk.net/job/openjdk9_build_x86-64_macos/
Builds appear to succeed on build-macstadium-macos1010-1 and fail on build-macstadium-macos1010-2.

Creating support/modules_libs/java.base/server/libjvm.dylib from 689 file(s)
Creating hotspot/variant-server/libjvm/gtest/libjvm.dylib from 52 file(s)
Creating hotspot/variant-server/libjvm/gtest/gtestLauncher from 1 file(s)
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.
make[3]: *** [/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/build/macosx-x86_64-normal-server-release/hotspot/variant-server/libjvm/gtest/objs/logTestFixture.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/build/macosx-x86_64-normal-server-release/hotspot/variant-server/libjvm/gtest/objs/test_AltHashing.o] Error 1
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.
make[3]: *** [/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/build/macosx-x86_64-normal-server-release/hotspot/variant-server/libjvm/gtest/objs/test_arguments.o] Error 1
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.
make[3]: *** [/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/build/macosx-x86_64-normal-server-release/hotspot/variant-server/libjvm/gtest/objs/test_arrayOop.o] Error 1
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.
make[3]: *** [/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/build/macosx-x86_64-normal-server-release/hotspot/variant-server/libjvm/gtest/objs/test_bitMap.o] Error 1
fatal error: malformed or corrupted AST file: 'could not find file '/Users/jenkins/workspace/openjdk_build-refactor/workspace/build/src/hotspot/make/../src/share/vm/gc/shared/plab.hpp' referenced by AST file'
1 error generated.

Have cleared out the workspace on that machine and will attempt a re-run to see if that's enough to clear the problem

Didn't work ... Manually deleting workspace on the machine and retrying

Confirmed that it is on -1 - https://ci.adoptopenjdk.net/job/openjdk9_build_x86-64_macos/208 passed

Need to understand what the openjdk_build-refactor directory is for and why the builds are referencing it - it doesn't exist on -2

Tactical fix implemented until @johnoliver returns from vacation - I have copied the /Users/jenkins/workspace/openjdk_build-refactor directory from build-macstadium-macos1010-1 to build-macstadium-macos1010-2 so the files it's looking for are present.

Removed important tag as we're now unblocked after the actions in my previous comment

This is fixed in the new build scripts, keeping open until we cut over.

This specific problem appears to have disappeared although https://github.com/AdoptOpenJDK/openjdk-build/issues/354 still exists (but is understood to be fixed in the new scripts)


document release process and automate if needed

We already have the website content update being automated.
And we already have tools to generate the binary tarballs (dock.go), documented in doc/release.txt
Now we need some documentation (and possibly some tool, if it's not already automated), on the rest of the release process. In particular, on how to generate the source tarball, and upload it to to github (or maybe we should upload it to camlistore.org/dl as well, no?).
Also, whether we cut a new releases/version branch on camlistore.googlesource.com and github. Or if we just tag it.

https://camlistore-review.googlesource.com/6087

97d9ab6fe4badf5c9f8e6473c0b3ce571cc0e27e

https://camlistore-review.googlesource.com/6286

With 4232071cb3fd88b0ab5c6986e9ab884b846ad608 in, we can now do automated "monthly" (or whenever, really) releases.


mpl enhancements list

What is the expected enhancement?

[x] I would like the default to have a color similar to the IBM Q experience. Could we set that by default and add white as optional one.

[x]  The initial |0> @ajavadia and I talked and think that unless the qubit has been reset/initialize that we should drop the |0>. This way a circuit can be a sub circuit.

[x] The q  need to be bigger  and too much whitespace between them and the start of the circuit.

[x] too much white space in measurements. Also measurements need to have a little z next to them.

[x]  gates like u1, u2, and u3 lets put the params in brackets  (same with rx, ry, and rz)

[x]  id lets make capital Id

[x]  control rz need to be in brackets as well

[x] reset lets remove from the box

[x]  initialization can we put a |psi> over writing initialize (maybe add vector)

[x] unitary can we put U over writing unitary (maybe add unitary)

[ ]  barrier should not go over all qubits (just the ones that have the barrier)

[ ]  the swap and cnot need to be centered a little better

A couple of these will be fixed by #2203

As for the barrier one, that's actually a drawing style thing (which we probably should change because it's not the first time this has been confused, see #1870 ) The grey shading doesn't show which qubits have the barrier, that's the dashed line.

Yeah I know. I think we just get rid of dash and use grey shading.

I'm not able to reproduce the alignment issue for the fredkin gate there. Running on current master I printed out a swap, cnot, toffoli, and fredkin and they all seemed to be aligned properly for me:

(ignore the gray shaded rectangles I was also experimenting with updating how we draw barriers, it's not finished yet)
@jaygambetta what code did you use to make that image with the misalignment so I can try to reproduce it.

I also see a misalignment of control gates here and there.

Interestingly though, if you output the circuit (png, pdf, etc) then the alignment is correct.  This might be a scaling issue with how it is presented on the screen.

Actually I modify my last comment.  The PDF output is exactly centered, the png output is a bit off, but it is not the control line, but the circle that is off in that case.  I am sure this is a rasterization issue, since the vectored pdf version is unaffected.

The initial |0> @ajavadia and I talked and think that unless the qubit has been reset/initialize that we should drop the |0>. This way a circuit can be a sub circuit.

Also for the other drawers?

@1ucian0 this is fixed now and should be closed but we do need to make a new issue for the other drawers


Add 'use server' directive

Hi everyone, thanks for this package!
This PR will add the new 'use server'directive that was introduced by Next.js 13.4 with Server Actions.
I also added new and changed some existing integration tests that check the functionality.
Closes #23

Great, thanks @DerTimonius and @daidodo ! 🙌
Will this be released in the next minors? eg:

<EMAIL_ADDRESS>dozerg.tsimportsorter@ 7.7.0

Or some other version?

Ah according to this comment like it was<EMAIL_ADDRESS>nice, thanks!


lint-server error message

When running make install from master we are getting this lint error:
elyra/pipeline/tests/util.py:35:1: H238: old style class declaration, use new style (inherit from `object`)
elyra/pipeline/tests/resources/node_util/node_util.py:23:1: H238: old style class declaration, use new style (inherit from `object`)
make: *** [lint-server] Error 1

These changes were introduced in #991.  That PR and subsequent PRs did not encounter the lint issue which is run as part of the CI.  I agree these should be flagged, but given this didn't come up until now implies a hole in our build process.