tf.keras.layers.Conv2D fails because it captures tensor from inner function

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): v1.12.1-6461-gc6352706d6 1.14.0
Python version: 3.6.7
Bazel version (if compiling from source): 0.26.1
GCC/Compiler version (if compiling from source): 7.4.0
CUDA/cuDNN version: 10.0 / 7.5
GPU model and memory: Nvidia Geforce GTX 1080 Ti, 11 GB

Describe the current behavior
Since commit 546308e322a6b95542ba9f3cbb14136128aaad1e a tf.keras.layers.Conv2D in my training code fails with the following error:
Traceback (most recent call last):
  File "./train.py", line 351, in <module>
    total_loss = train_step()
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/def_function.py", line 417, in __call__
    self._initialize(args, kwds, add_initializers_to=initializer_map)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/def_function.py", line 360, in _initialize
    *args, **kwds))
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1709, in _get_concrete_function_internal_garbage_collected
    graph_function, _, _ = self._maybe_define_function(args, kwargs)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 2013, in _maybe_define_function
    graph_function = self._create_graph_function(args, kwargs)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1899, in _create_graph_function
    capture_by_value=self._capture_by_value),
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py", line 795, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/def_function.py", line 310, in wrapped_fn
    return weak_wrapped_fn().__wrapped__(*args, **kwds)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py", line 785, in wrapper
    raise e.ag_error_metadata.to_exception(type(e))
ValueError: in converted code:

    ./train.py:328 train_step  *
        per_replica_losses = distribution_strategy.extended.call_for_each_replica(joint_train_step_fn, args=())
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/distribute/distribute_lib.py:1776 call_for_each_replica
        return self._call_for_each_replica(fn, args, kwargs)
    /home/salscheider/deeplearning/nnad_playground/model/Resnet.py:173 call  *
        x = self.module_3a(x, train_batch_norm=train_batch_norm)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/keras/engine/base_layer.py:713 __call__
        outputs = call_fn(inputs, *args, **kwargs)
    /home/salscheider/deeplearning/nnad_playground/model/Resnet.py:97 call  *
        x = self.conv2(x)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/keras/engine/base_layer.py:713 __call__
        outputs = call_fn(inputs, *args, **kwargs)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/keras/layers/convolutional.py:198 call
        outputs = self._convolution_op(inputs, self.kernel)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/nn_ops.py:1078 __call__
        return self.conv_op(inp, filter)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/nn_ops.py:634 __call__
        return self.call(inp, filter)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/nn_ops.py:610 _with_space_to_batch_call
        block_shape=self.dilation_rate)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/array_ops.py:3084 required_space_to_batch_paddings
        pad_start = base_paddings[:, 0]
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/array_ops.py:694 _slice_helper
        name=name)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/array_ops.py:860 strided_slice
        shrink_axis_mask=shrink_axis_mask)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/ops/gen_array_ops.py:10397 strided_slice
        shrink_axis_mask=shrink_axis_mask, name=name)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/framework/op_def_library.py:793 _apply_op_helper
        op_def=op_def)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py:528 create_op
        inp = self.capture(inp)
    /home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py:589 capture
        % (tensor, tensor.graph, self))

    ValueError: Trying to capture a tensor from an inner function. This can be caused by accessing a tensor defined inside a loop or conditional body, or a subfunction, from a calling function, without going through the proper return value mechanism. Consider using TensorFlow mechanisms such as TensorArrays to retur
n tensors from inner functions or loop / conditional bodies. Tensor: Tensor("conv2/stack:0", shape=(2, 2), dtype=int32, device=/job:localhost/replica:0/task:0/device:GPU:0); tensor graph: FuncGraph(name=build_graph, id=140610256740760); this graph: FuncGraph(name=train_step, id=140614894336264)

This error only occurs with dilation_rate set to 2. With dilation_rate == 1 the training script runs.
It also works if I revert 546308e322a6b95542ba9f3cbb14136128aaad1e.
Describe the expected behavior
The training runs with dilation_rate == 2.
Code to reproduce the issue
So far I could not come up with a small testcase to reproduce the issue. I will continue to try, but until then I only have the backtrace and the problematic commit.

@olesalscheider ,
In order to expedite the trouble-shooting process, please provide complete code snippet to reproduce the issue reported here. Thanks!

You can use this as a testcase:
import tensorflow as tf
import numpy as np

class ResnetModule(tf.keras.Model):
    def __init__(self, name, num_filters, stride=1, dilation_rate=1):
        super().__init__(name=name)
        self.num_filters = num_filters
        self.stride = stride
        self.dilation_rate = dilation_rate

    def build(self, input_shapes):
        self.has_skip_conv = input_shapes[-1] != self.num_filters[-1] or self.stride > 1

        self.bn1 = tf.keras.layers.BatchNormalization()
        self.bn2 = tf.keras.layers.BatchNormalization()
        self.bn3 = tf.keras.layers.BatchNormalization()

        self.conv1 = tf.keras.layers.Conv2D(self.num_filters[0],
            (1, 1),
            use_bias=False,
            kernel_initializer=tf.keras.initializers.he_normal(),
            name='conv1')

        self.conv2 = tf.keras.layers.Conv2D(self.num_filters[1],
            (3, 3),
            use_bias=False,
            padding='same',
            strides=(self.stride, self.stride),
            dilation_rate=(self.dilation_rate, self.dilation_rate),
            kernel_initializer=tf.keras.initializers.he_normal(),
            name='conv2')

        self.conv3 = tf.keras.layers.Conv2D(self.num_filters[2],
            (1, 1),
            use_bias=False,
            kernel_initializer=tf.keras.initializers.he_normal(),
            name='conv3')

        if self.has_skip_conv:
            self.bn_skip = tf.keras.layers.BatchNormalization()

            self.conv_skip = tf.keras.layers.Conv2D(self.num_filters[2],
                (1, 1),
                use_bias=False,
                strides=(self.stride, self.stride),
                kernel_initializer=tf.keras.initializers.he_normal(),
                name='conv_skip')

        super().build(input_shapes)

    def call(self, x, train_batch_norm=False):
        skip = x
        if self.has_skip_conv:
            skip = self.conv_skip(skip)
            skip = self.bn_skip(skip)
        x = self.conv1(x)
        x = self.bn1(x, training=train_batch_norm)
        x = tf.keras.activations.relu(x)
        x = self.conv2(x)
        x = self.bn2(x, training=train_batch_norm)
        x = tf.keras.activations.relu(x)
        x = self.conv3(x)
        x = self.bn3(x, training=train_batch_norm)
        x = x + skip
        x = tf.keras.activations.relu(x)
        return x

def learning_rate_fn():
    return tf.constant(1e-4)

opt = tf.keras.optimizers.Adam(learning_rate_fn, epsilon=1e-3, amsgrad=True)

def get_data():
    return np.random.random([1, 512, 1024, 3]).astype(np.float32)

backbone = ResnetModule('resnet_module_3a', [256, 256, 1024], dilation_rate = 2)

@tf.function
def joint_train_step_fn():
    losses = []
    with tf.GradientTape(persistent=True) as tape:
        img = tf.py_function(get_data, [], tf.float32)
        img.set_shape([1, None, None, 3])
        feature_map = backbone(img, False)
        img2 = tf.random.uniform([1, 1024, 1024, 3])
        feature_map2 = backbone(img, False)
        losses = tf.reduce_sum(feature_map) + tf.reduce_sum(feature_map2)

        with tape.stop_recording():
            vs = backbone.trainable_variables
            gs = tape.gradient(losses, vs)
    opt.apply_gradients(zip(gs, vs))
    return losses

joint_train_step_fn()

@olesalscheider ,
When i executed the given code with dilation_rate == 2, i got the error KeyError: 'conv2d_4/dilation_rate. Can you confirm if the same error is faced. Thanks!

No, I get this error with the testcase:
Traceback (most recent call last):
  File "./train.py", line 31, in <module>
    train_step()
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/def_function.py", line 429, in __call__
    return self._stateless_fn(*args, **kwds)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1684, in __call__
    return graph_function._filtered_call(args, kwargs)  # pylint: disable=protected-access
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 645, in _filtered_call
    self.captured_inputs)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 755, in _call_flat
    outputs = self._inference_function.call(ctx, args)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 469, in call
    ctx=ctx)
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/execute.py", line 76, in quick_execute
    raise e
  File "/home/salscheider/tf2/lib/python3.6/site-packages/tensorflow_core/python/eager/execute.py", line 61, in quick_execute
    num_outputs)
TypeError: An op outside of the function building code is being passed
a "Graph" tensor. It is possible to have Graph tensors
leak out of the function building context by including a
tf.init_scope in your function building code.
For example, the following function will fail:
  @tf.function
  def has_init_scope():
    my_constant = tf.constant(1.)
    with tf.init_scope():
      added = my_constant * 2
The graph tensor has name: conv2d/dilation_rate:0

Which version of tensorflow do you use? I used the current master branch.

I was able to reproduce the issue with !pip install tf-nightly-gpu-2.0-preview==2.0.0.dev20190724 . Here is the gist. Thanks!

@olesalscheider this issue should be fixed in tf-nightly. Will close it for now. Feel free to re-open it if the issue appears again.


Rubocop and travis

The commits are mostly the result of doing individual auto-corrects (and doing a quick review for correctness).  I also made sure that each new commit didn't undo any of the cops that were already fixed.
From Style/IfInsideElse on, there was nothing left that could be autocorrected and those are manual work.

Partially addresses #3


Fix export macro for optional builtins

Fixes #208. This should make CI checks work again.

Thank you for the fix!


Add new conf WRITE_REPARTITION_NUM

val WRITE_REPARTITION_NUM: ConfigEntry[Int] =
    buildConf("write.repartitionNum")
      .doc("Repartition data to meet the distributions of ClickHouse table is required before writing, " +
        "use this conf to specific the repartition number, value less than 1 mean no requirement.")
      .intConf
      .createWithDefault(0)

Closed by https://github.com/housepower/spark-clickhouse-connector/commit/58f893e4bc3aa41f4bf28cd177e7ea242bf07d00


Theme: Button component

Is your feature request related to a problem? Please describe.
Improve the theme support to the component (and subcomponents).
Describe the solution you'd like

All default styles must be moved to the default theme;

Describe alternatives you've considered
n/a
Additional context
n/a

Gimme this


Can not reproduce the results in CA.

Hi,
Thanks for your contribution!  By running the code you provided,  I'm trying to reproduce the nice results of CA reported in your paper.  But there are several difficulties.
By default, the training process of CA is extremely confusing. The loss will first decrease and the attention scores will concentrate on the expected locality. But it is not a stable status, the loss will then vibrate to a new status where the attention seems to focus on partial-local-structure. And the summation of attention scores decreases to less than 1.

When I change the shuffle of dataloader to be all True , the loss will not vibrate and the ACC will retain >=99. However, the attention score will disappear (summations-->0) while the ACC still >=99.

Epoch 10, ACC>=99

Epoch 23, ACC>=99

Hi,
Thanks for your attention. First of all, train_loader shuffle should be 'True' (obviously), I'll fix it.
The attention score in this paper is not a normalized one like a conventional 'attention' in ML practices (i.e., not softmax-ed among all other agents). Each attention score is output from a sigmoid function, thus may have any value between 0~1 (hence its sum can have any value between 0~N). Also, in theory, the exact scale of attention is not important in AgentNet, since the following decoder can scale up the signal whatever it likes. I guess the attention structure is still present, but not shown because now the maximum attention value becomes like 1e-2, not ~1. (Check it by removing 0~1 lim for your imshow and plot it again). Another way to check that the attention structure is still present is by replacing the attention matrix with a zero-valued one and performing the forward pass. The difference in the result will prove that the attention score is still important (Different from being total zero), just scaled down.
But (nearly) vanishing attention is a somewhat interesting phenomenon. In my attempts, I've never encountered such a drastic decrease in overall attention value. Since you've reached the desired point at 10 epoch, (much faster than my paper has shown, 200 epoch), maybe you used more data (than the original version), and AgentNet somewhat adapted to that setting and comfortably reduce its overall scale (with more data, it can distinguish the relevant one and irrelevant one more precisely).
Again, thanks for your attention. Feel free to leave a question and report!

Thanks for your quick reply.  I removed the 0-1 limitation of imshow, and as you expected, the attention structure still holds while the absolute values decrease to near 1e-2.


proposal: net/http/httputil: support RFC 7239 Forwarded header in ReverseProxy

ReverseProxy injects the de facto standard header X-Forwarded-For.
RFC 7239 defines a new header, Forwarded, that offers the same functionality as X-Forwarded-For and more.
I suggest that ReverseProxy get support for Forwarded: for=... in addition to X-Forwarded-For.

/cc @bradfitz @dsnet

The suggestion seems fine, but @bradfitz has the final say. A consideration is whether the addition of a "Forwarded" header is worth the extra bytes we dump out on the network. The internet at large already understands "X-Forwarded-For". It will be a long time (if ever) before "Forwarded" replaces "X-Forwarded-For", so people will be forced to implement understanding both. It doesn't seem like the utility is that great.

Adoption of the Forwarded header does seem to suffer from an chicken-and-egg problem.
One reason why Forwarded is increasingly useful is that it also allows forwarding the original hostname and protocol used by the client. The hostname is already available in the Host header, but the protocol is not. With all the rage about HTTPS these days, one has to resort to other non-standard headers such as X-Forwarded-Proto, so one could imagine that this would generate an increasing demand for a standardized header. However, this is just speculation.

What software does recognize Forwarded today?
There's a question of recognizing the new header vs generating the new header. Recognizing both seems OK.
There's no point in generating a header that nothing else recognizes though. Should we really generate both?
Should we translate X-Forwarded-For into Forwarded?
Should we translate Forwarded into X-Forwarded-For?

Still waiting for answers to the above. Ping @c960657 ?

The Forwarded header is supported by the Symfony framework and thus also by other projects based on that including Drupal and Laravel.
It is also supported by the Gorilla web toolkit and forwarded-http Node library.
The header is not supported by Apache mod_proxy_http, Ruby on Rails, WordPress or MediaWiki.
All of the above support X-Forwarded-For and to some extend the other X-Forwarded-xxx headers. So no, the Forwarded header does not have much traction.

If we just don't do this, and we wait until there's a more compelling need, what bad things would happen? Is there some minimal amount we should do today, or should we just postpone everything until later?

Ping? Should we just postpone this?

Sounds like there's no compelling reason to do this. We can reconsider in the future if things change.

If we want to do something, but our main concern is not adding more bytes to our request payload, we could parse incoming Forwarded headers in requests with no X-Forwarded-For header and add the IP addresses in for=… to the X-Forwarded-For. This is similar to the transition mechanism described in section 7.4 of the RFC, just in the other direction (the RFC suggests copying from X-Forwarded-For to Forwarded).
This would allow downstream proxies to support only Forwarded, while downstream proxies and the HTTP server can still use X-Forwarded-For. This is probably not a big win, so I agree that at the moment, there is no compelling need to add support for RFC 7239.
So I don’t object to closing this issue :-)

I'd be fine with recognizing Forwarded if X-Forwarded-For was absent. Feel free to send a change for Go 1.10.


Support dot identifiers syntax for CREATE/DROP FULLTEXT INDEX

Description
This commit adds support for different syntax of identifiers - including spaces, dots, double quotes, square brackets, etc. for CREATE FULLTEXT INDEX and DROP FULLTEXT INDEX statements.
Signed-off-by: Roshan Kanwar<EMAIL_ADDRESS>Issues Resolved
Task: BABEL-4785
Test Scenarios Covered

Use case based - done

Boundary conditions - done

Arbitrary inputs - done

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 26 (100.0%)  changed or added relevant lines in 1 file are covered.
30 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 72.241%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tsql/src/tsqlIface.cpp
30
88.96%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
40405

Relevant Lines:
55931

💛  - Coveralls


Update diagram sources

Description
Small update of the Advisor unification diagram in order to add the task regarding the authorization access to AMS API and other small updates
Type of change

Documentation update

Testing steps
Checklist

[x] make before_commit passes
[x] updated documentation wherever necessary
[x] added or modified tests if necessary
[x] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #611 (6f1a1a3) into master (51f6992) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   58.22%   58.22%
=======================================
  Files          17       17
  Lines        1434     1434
=======================================
  Hits          835      835
  Misses        495      495
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f6992...6f1a1a3. Read the comment docs.


Treat Omnibus as 2 volumes

checking keyword in volumes for omnibus as it says if possible to implement

there is also 3 v 1. but ideals most of them are 2 in one volumes


add nonBlockingPush and isFull for MPMCQueue

What problem does this PR solve?
Issue Number: close #6518
Problem Summary:
What is changed and how it works?

remove timeout and emplace in MPMCQueue.
Only support push(T &&), tryPush(T &&) and nonBlockingPush(T &&) in MPMCQueue now.
add template enable_remaings which is used for nonBlockingPush.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-all-tests

closed by https://github.com/pingcap/tiflash/pull/6835


Wip async forwarder1

Example 1 of a potential AsyncForwardingAppender
This example adds:
internal Task<int> AppendLoopOnAppendersAsync(LoggingEvent[] loggingEvents)
public Task<int> AppendLoopOnAppendersAsync(LoggingEvent loggingEvent)

Well yes I see what you're saying. I'll get a 2nd example up soon that you'll hopefully consider as an interim.
Long term I could see creating an IAsyncAppender interface that implements IAppender.


Embeds

Is there a way to make them?

Yes, you can send embeds in the messages by just adding a list of embeds in the response to your command interaction. For instance,
return {
      type: InteractionResponseType.ChannelMessageWithSource,
      data: {
        content: `Hello, <@${userId}>`,
        embeds: [
          // Embed objects
        ]
        allowed_mentions: {
          users: [userId || ''],
        },
      },
    };

To look at the structure of the embed objects, look at the Discord API reference: https://discord.com/developers/docs/resources/channel#embed-object

@LoryPelli also uses the "Issues" section to create feature requests or bugs. For Q&A, please, use our discussions section. Here's the link: https://github.com/discordcf/discordcf/discussions 😄

Yes, you can send embeds in the messages by just adding a list of embeds in the response to your command interaction. For instance,
return {
      type: InteractionResponseType.ChannelMessageWithSource,
      data: {
        content: `Hello, <@${userId}>`,
        embeds: [
          // Embed objects
        ]
        allowed_mentions: {
          users: [userId || ''],
        },
      },
    };

To look at the structure of the embed objects, look at the Discord API reference: https://discord.com/developers/docs/resources/channel#embed-object

How can I declare an embed?
I can't use
let embed = new Discord.MessageEmbed()

So how?

For future things I will use the discussion section

Yes, you can send embeds in the messages by just adding a list of embeds in the response to your command interaction. For instance,
return {
      type: InteractionResponseType.ChannelMessageWithSource,
      data: {
        content: `Hello, <@${userId}>`,
        embeds: [
          // Embed objects
        ]
        allowed_mentions: {
          users: [userId || ''],
        },
      },
    };

To look at the structure of the embed objects, look at the Discord API reference: https://discord.com/developers/docs/resources/channel#embed-object

How can I declare an embed? I can't use
let embed = new Discord.MessageEmbed()

So how?

No, you just need to create a TypeScript object that has the fields the Discord API resource asks you to fill out.
embeds: [
    {
        title: "something",
       type: "rich",
       ...
    }
]

Please make sure you read the link I shared above regarding the "Embed Object Structure".


WebSocket handshake/connection faild to cognitiveservices in webchat-es5.js

webchat-es5.js:79 WebSocket connection to 'wss://westeurope.stt.speech.microsoft.com/speech/recognition/interactive/cognitiveservices/v1?language=en&format=detailed&Authorization=eyJhb...gDo9A-M&X-ConnectionId=C7C387E721614770B0325717B41A6309' failed: Error during WebSocket handshake: Unexpected response code: 400
Open @ webchat-es5.js:79

In few chrome is working but in few chrome browser its failing not sure how to resolve this.
(Edited by @compulim for formatting and removing sensitive content)

@Akkilz could you provide repro steps for this error? Copy-pasting your code may also help.

Hi,
thanks for your response, be low is the code I am using it. Its throwing err in edge as well.
Error :
SCRIPT12002: WebSocket Error: Network Error 12002, The Operation timed out.
js file used : webchat-ed5.js
var nonIECode = function () {
window.WebChat.createCognitiveServicesSpeechServicesPonyfillFactory({ subscriptionKey: speechSecret, region: region }).then(function (res) {
webSpeechPonyfillFactory = res;
return;
}).then(function () {
                window.WebChat.renderWebChat({
                    directLine: window.WebChat.createDirectLine({
                        secret: dlSecret
                    }),
                    webSpeechPonyfillFactory: webSpeechPonyfillFactory
                }, document.getElementById('webchat'));

                document.querySelector('#webchat > *').focus();
            });
        };

Kindly let me if any.

Can you confirm you are using webchat-es5 instead of webchat-ed5?
Could you provide the details on what the 400 error is? You can open the Network tab and get the HTTP response on the error. I think this is a Cognitive Services issue but the error may prove otherwise.

its es5.js, typo issue, i will check the network tab and share you the analysis details.

I have a repro of this issue #1845. I'm going to pin this issue. To anyone else experiencing this, please add the details of the 400 error from your network tab. I will be looking into this today.

@Akkilz Network Header:

@NoDirective

I am connecting with Cognitive Services team and see if they can jump in and help.

Sorry the result message didn't contain enough information to diagnose the failure.
The language specified in all three requests isn't a supported language code.
The language specified needs to be from the support list of languages you can find at https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/language-support.
While the value is case insensitive, the speech service does require the 4 letter language code.

Great. @Akkilz is using en-DE and @NoDirective


Issue with Single Page Application which is using requireJS

Uncaught TypeError: isFunction is not a function
at KoreBot.init (kore-bot-sdk-client.js:308)
at chatWindow.init (chatWindow.js:568)
at new chatWindow (chatWindow.js:541)
at Object.show (chatWindow.js:1514)
at HTMLButtonElement. (main.js:112)
This is the Error while integrating Kore Chatbot with javascript code only which is given in web-sdk in the folder UI-JAVASCRIPT.
Or do we have to follow some other instruction to integrate Kore Bot in Single Page Applications which uses RequireJS

HI Ayush Jain,
This issue was resolved now.  Now you can integrate WEBSDK in Single Page Application which is already using requireJS.


Add custom schema support

As discussed on gitter, I want to use custom schemas with diesel. I am using postgresql. My use case is that the tables I want to query on aren't in the public schema. For example, I want to query schema_1.table_1 and schema_1.table_2, however currently, infer_schema! doesn't find them.

I also use schemas outside of public.

Macros 1.1 took up a lot of time, but this will be in the next release.

I'm wondering if setting the search_path would alleviate this issue:
SET search_path=public,tiger,postgis;

On that note, it would be important to specify which schemas diesel should infer (inferring tiger or postgis would be a waste)

I ran a migration which created tables inside of a schema and my schema.rs file is empty. What do I need to do in order for diesel to detect the tables in the other schema? (I am using postgresql)

@NilsIrl Please don't comment on old issues to ask questions. Our issue tracker is no support forum. Use the gitter channel or the discussion forum to ask questions. And please include important information about your setup there as otherwise nobody will be able to answer your questions.

Apologies, I thought it was appropriate to ask here considering that's where the feature was requested.
I created a dicussion here: https://github.com/diesel-rs/diesel/discussions/2990


Full finetuning or LoRA for Hunyuan

Hi author,
Thanks for your wonderful work! I notice you provide scripts of fine-tune and Lora. But do they now support the Hunyuan model? Especially for the LoRA method? I will maintain following.
Thank you!

Thank you for your interest! For the Hunyuan model, we currently have full model finetuning scripts available. Regarding LoRA, it is currently only supported for Mochi models. We are working to add LoRA support for Hunyuan - please stay tuned for updates.


Improve message about leaking FD from Vibe.d

Currently we see this message quite a bit:
Apr 05 08:17:02 eu-002 docker[85088]: [main(----) INF] Stopped to listen for HTTP requests on <IP_ADDRESS>:2826
Apr 05 08:17:02 eu-002 docker[85088]: Main thread exiting
Apr 05 08:17:02 eu-002 docker[85088]: Warning (thread: main): leaking eventcore driver because there are still active >
Apr 05 08:17:02 eu-002 docker[85088]:    FD 18 (streamListen)
Apr 05 08:17:02 eu-002 docker[85088]:
Apr 05 08:17:02 eu-002 docker[85088]: There were still 2 tasks running at exit.
Apr 05 08:17:02 eu-002 docker[85088]: Warning (thread: main): leaking eventcore driver because there are still active >
Apr 05 08:17:02 eu-002 docker[85088]:    FD 18 (streamListen)
Apr 05 08:17:02 eu-002 docker[85088]:

However we don't know where those come from. It's also a scary message for our users to see.
What we should do:

Improve the message so we actually where in the user code the FD was instantiated;
Fix the underlying issue(s);

This issue is mostly after doing 1, as 2 comes and goes.

If, I remember this one is caused by not calling: http_listener.stopListening(); during shutdown. Did we add any new rest endpoint to Agora recently?

related PR: https://github.com/bosagora/agora/pull/1146/files

Upstream: https://github.com/vibe-d/eventcore/pull/183

Done in https://github.com/vibe-d/eventcore/pull/183


P Class text layers - adding social integration button(s) like a Pinterest button for each image

I am trying to get social integration added to my "example 2" slider and what i wanted to try to get working is a social button overlay on top of each image so that each image could be tagged such as a mention on facebook or a tag on pinterest, etc.
The only way i could think about doing this is taking the "P Class" text overlays shown in slider "example 1" and somehow converting those to the individual social button(s) i wanted to add.
It's a little over my head so i wanted to ask the community or the developer if there is an example already done on this.  This seems like an example that could be added to the demo's so people know it's possible and with socials getting more prominent adding social links to the slider makes sense.

AddThis has one of their app bars that is supposed to add functionality to every image on a page and i am trying to implement that to test it out BUT it totally bloats the page.  although the js can be run asynchronous it does slow the page down in my tests so far.  but in my question above adding my own buttons provided directly by the social companies will probably be a better option with more control by me and reduce the bloating and page load times.
but i am looking for feedback and options


Bugfix auto validate

Description
Some nodes didn't trigger self validation in the constructor.
This is fixed now.
Changes
All nodes only update their JSON attributes if they are valid, even in the constructor.
Known Issues
None yet.
Notes
Checklist

[x] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
[x] I have updated the documentation to reflect my changes.
[x] My code changes have been verified by automated tests and pass all relevant test scenarios.

@duboyal this addresses the issues we had this morning.
Hopefully a bit more straight-forward PR then the others.


Split log file accroding to date ,level or other automatically！

I think this function is very usefull,Do we have a plan to support it.
Then the log files will look like "xxx.log.2015-02-25 xxx.log.wf.2015-02-25"
"xxx.log.2015-02-25" will include "INFO level logs"
"xxx.log.wf.2015-02-25" will include "WARN and FATAL level logs"

As for rotation (date) there is a clue in README.md

Log rotation is not provided with Logrus. Log rotation should be done by an external program (like logrotate(8)) that can compress and delete old log entries. It should not be a feature of the application-level logger.

As for outputting to different files based on level (and probably other fields) can be done using custom output or using hooks.

Thanks for your suggestion! But no, I don't think log rotation should be a deep concern for the logger at this time.


Support Chinese (and other) characters.

Currently use of Chinese characters causes a unicode error in datashuttle. Need to test this and implement a fix, I'm not sure what the underliyng problem. Hopefully this fix for this will be general and work for all-english language characters.

I tried with a variety of Chinese characters copied from the wikipedia and did not encounter any errors. Running a full 'pipeline' with the project name C:\data\datashuttle\local\my_first_pr𡨸漢oject ran successfully without error. In this case maybe the error we observed during the practical was due to another issue. As this cannot be replicated at this time and Chinese characters seem to work so will close for now.


Fix operation Test with int as string

When pass string with only numbers like "123" method perform trying to decode it as json and result will be int 123.
This PR fixes this behavior.

what do you think of that? @raphaelstolt

Looks good to me. Will merge it later today and release it with 1.2.6.

Closed with #9aa9014.

Thanks!


Error with reverb installation

Thanks for making this project publicly available. I am checking it out. reverb installation is hitting the following error
ERROR: Could not find a version that satisfies the requirement dm-reverb-nightly==0.1.0.dev20200529; extra == "reverb" (from dm-acme[reverb]) (from versions: none)
ERROR: No matching distribution found for dm-reverb-nightly==0.1.0.dev20200529; extra == "reverb" (from dm-acme[reverb])

It's python 3.8.2

The current dm-reverb-nightly release supports Python 3.6 and 3.7 (not 3.8). Can you try using one of those? We'll be including Python 3.8 support in our next dm-reverb-nightly release.

@samarjeet Reverb now supports Python 3.8, so it should work for you now. I'm closing this issue but please re-open if you continue to have issues.

I am using Python 3.8.6, facing the same issue here.
ERROR: Could not find a version that satisfies the requirement dm-reverb>=0.1.0; extra == "reverb" (from tf-agents[reverb]) (from versions: none)
ERROR: No matching distribution found for dm-reverb>=0.1.0; extra == "reverb" (from tf-agents[reverb])

Hello there!
I'm facing similar installation issues on MacOS. Does Mac support dm-reverb? Any help would be great! 😃

While reverb doesn't currently support macos, there is some movement in that direction that you can see here: https://github.com/deepmind/reverb/pull/24.

I'm having this same issue on Windows 10, Python 3.8. I just try to run the command pip install --user dm-reverb and get the errors:
ERROR: Could not find a version that satisfies the requirement dm-reverb (from versions: none)
ERROR: No matching distribution found for dm-reverb

Is it taken off of pypi or something?

Hey @windowshopr, Reverb is Linux only and although there are some efforts in the Mac OS direction, Windows is very unlikely to ever be supported by the core team.

Any updates on the MacOs version maybe?

MacOs will never be supported by the core Reverb team I'm afraid.

@windowshopr Hi, I'm using Ubuntu22.04, python3.8.19, but still meet this issue. How to solve it?


Npgsql version should be upgraded

Is there an existing issue for this?

[X] I have searched the existing open and closed issues

Description
I see that currently, this package uses Npgsql v3.2.7, that was released in 2018. This is a version that is out of support and therefore I believe it should be updated to at least v6, if not the latest (v8).
What is the impact?
Apart from possible security issues, there are some breaking changes, e.g. we could not use VerifyFull SSL mode in our connection string.

I checked out this repo and see that it's probably due to your support of netstandard1.3. I also noticed that it is planned to be dropped in the next major release, so the upgrade will be possible. I will stay tuned.

Fixed by #17


Add missing manifest refresh to agent state machine

Manifest was not being refreshed after job execution, leading to the server serving stale data.
Also add some debug statements and increase some smoke test coverage.

Coverage decreased (-0.04%) to 92.718% when pulling 8c04ae33a9b9df6b3b700148f0d5da8d8e9209a0 on mprimi:GENIE-545-bug-missing-manifest-refresh into 1c3f5f1758c19be2e912d8a6d2e141ae9d9c5610 on Netflix:master.


Provide additional mDNS information

Codecov Report

Merging #2 (d175ef4) into master (3a3fb5e) will increase coverage by 3.40%.
The diff coverage is 87.75%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   80.64%   84.04%   +3.40%
==========================================
  Files           3        3
  Lines         124      163      +39
==========================================
+ Hits          100      137      +37
- Misses         24       26       +2

Files Changed
Coverage Δ

examples/list.rs
0.00% <0.00%> (ø)

src/lib.rs
93.97% <91.42%> (-0.47%)
:arrow_down:

tests/mdns.rs
98.33% <100.00%> (+0.33%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Chrome and Chromedriver install scripts fail

These seem to also be failing in SODAR Core, to be investigated.
UPDATE: Following up on this in bihealth/sodar-core#1255. Seems to be a problem on Google's side.

Fixed.


Mapping initials and full given names in zib NameInformation

The zib 2020 NameInformation is on quite fundamental level incompatible with FHIR R4 datatype HumanName. The zib specifies that (a list of) given names (NL-CM:20.4.4) and (a list of) initials (NL-CM:20.4.5) may both be communicated separately. However, in FHIR there is no way to communicate BOTH initials and full given names within the same HumanName instance -- for each given name, you communicate EITHER an initial or a full name.
This could be alleviated by specifying that initials are communicated when only an initial is known, and the full name otherwise. However, the zib specifies full names and initials as discrete lists without any relation between the full names and initials at all. For example, it may be that only a single full name is known and three initials, and it may be that the full name represents the second initial, or none of the initials at all. So there's no way to mix and match full names and initials.
The only proper way to model this, is by repeating the entire HumanName instance, once with the initials and once with the full names. Both instances could get a .use of official.
Another approach would be to allow mixing and matching full names and initials. The zib concepts would then have to be derived from that information, for example

"Abraham B." would result in "A. B." for initials and "Abraham" for given names.
"A. B" would result in "A. B." for initials and given names absent.
"Abraham Bob" would result in "A. B" for initials and "Abraham Bob" for given names.

Related: https://bits.nictiz.nl/browse/ZIB-1435

Asked Zulip for help: https://chat.fhir.org/#narrow/stream/179166-implementers/topic/Communicating.20both.20full.20names.20and.20initials

Perhaps too simplistic, but perhaps we should just go for specifying that initials are communicated when only an initial is known, and the full name otherwise AND documenting that in some rare cases you want to send both this should go in two separate HumanName instances?

I'm in favor of this, but it's a bit more elaborate; you'd have to break up the "given names" string and "initial string" from the zib into their constituent parts and then communicate them independently, where you apply the above rule. And then you can use the escape of two instances for the weird case where you have a list of given names and a list of initials and you really don't know how they relate to each other.

Example of how this might look like: https://simplifier.net/test20201185/~resources?category=Profile&sortBy=DisplayName_desc
Examples in these profiles are not up-to-date.

Okay, interesting. I guess HL7v3 (maybe not surprising) obeys the same mechanism as FHIR. However, the zib-definition does not.
Zib seems to implicate when sending initials and/or full given names one should always be complete (or that may be a valid assumption: if not that is the problem of the sourcesystem not a problem of zib/information standard).
When transforming from V3 to FHIR or vice versa, we could add an ada field that conveys the HL7-definition for given name, thus minimizing information loss AND minimizing this problem in real life.
Should we encounter an ada/zib instance which does have both initials and full name, we can then send two instances of human name, but I suspect that should hardly ever happen. Source systems which natively support either FHIR or HL7v3 are asked to comply to those rules (more so than zib rules, which only conceptually define initiales and full names, but do not have technical specifications).
We can instruct our own information analysts to choose between full name and initials in most of the test instances (except one, because we do want to validate target systems on this edge use case).
Profile mapping may be a bit complex but not undoable.

The (hopefully temporary) solution to this issue is documented in https://nictiz.atlassian.net/browse/ZIBFHIR-20. Closing this ticket.


Make prae::ValidationError more informative

Right now there's no information other than default error message. This should be somehow improved.

Closed with cc62a3d.


Api error

Google limits the requests and doesn't give me an increase (see the other issue). I'll try to implement offline checks when I find some time.

Same here with Pixel 6a. FYI.

Google limits the requests and doesn't give me an increase (see the other issue). I'll try to implement offline checks when I find some time.

Hi @1nikolas
How can you implement this offline? As far as I know, it must connect to Google services.

Google limits the requests and doesn't give me an increase (see the other issue). I'll try to implement offline checks when I find some time.

Hi @1nikolas How can you implement this offline? As far as I know, it must connect to Google services.

I read more into this and even server-less checks have that 10k/day limit


"mj-accordion-element" supports "border" strangely

Describe the bug

Whether used directly on an mj-accordion-element or used through mj-attribute (as in the example mentioned below), borders change consistent with each mj-accordion-text overriding its border-top and border-bottom, thus changing all horizontal lines for the mj-accordion component except the top line.
mj-accordion-element (https://documentation.mjml.io/#mj-accordion) does not list border among its supported attributes.
https://mjml.io/try-it-live/gs3v2xeDrGl includes the border attribute on mj-accordion-element. I used it accidentally and missed the notice, attribute border is illegal.

To Reproduce
Steps to reproduce the behavior:

https://mjml.io/try-it-live/gs3v2xeDrGl (version 4.7.1)
MJML app (version ^4.8.1)
Node v12.18.4 and MJML version 4.8.1.

Expected behavior
MJML would be better if either

The code would ignore unsupported attributes (border on mj-accordion-element, in this case), or
We change the documentation to indicate support for border on mj-accordion-element.

Recommended: Option 1 above and not Option 2. Ignore unsupported attributes and leave the documentation as is. It's probably a rare author that wants the existing rendering. I don't have a good proposal for this attribute here.
MJML environment (please complete the following information):
current Windows 10; MJML versions above
Additional context
If the decision is to change the documentation, I volunteer to do it.

You can just add it to the doc, as it's seems intentional from the code.
On Wed, Jan 27, 2021 at 10:36 PM Garry Flemings<EMAIL_ADDRESS>wrote:

Describe the bug

Whether used directly on an mj-accordion-element or used through
mj-attribute (as in the example mentioned below), borders change
consistent with each mj-accordion-text overriding its border-top and
border-bottom, thus changing all horizontal lines for the mj-accordion
component except the top line.
mj-accordion-element (https://documentation.mjml.io/#mj-accordion)
does not list border among its supported attributes.
https://mjml.io/try-it-live/gs3v2xeDrGl includes the border
attribute on mj-accordion-element. I used it accidentally and missed
the notice, attribute border is illegal.

To Reproduce
Steps to reproduce the behavior:

https://mjml.io/try-it-live/gs3v2xeDrGl (version 4.7.1)
MJML app (version ^4.8.1)
Node v12.18.4 and MJML version 4.8.1.
[image: image]
https://user-images.githubusercontent.com/14095071/106055774-77305200-60b3-11eb-8d90-6d059b1922c2.png

Expected behavior
MJML would be better if either
[image: image]
https://user-images.githubusercontent.com/14095071/106056314-25d49280-60b4-11eb-8b86-42a3ee2b962d.png

The code would ignore unsupported attributes (border on
mj-accordion-element, in this case), or
We change the documentation to indicate support for border on
mj-accordion-element.

Recommended: Option 1 above and not Option 2. Ignore unsupported
attributes and leave the documentation as is. It's probably a rare author
that wants the existing rendering. I don't have a good proposal for this
attribute here.
MJML environment (please complete the following information):
current Windows 10; MJML versions above
Additional context
If the decision is to change the documentation, I volunteer to do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2157, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTNEZ5LZBADYA4JTCQTS4CBOJANCNFSM4WV7DJHQ
.

You can just add it to the doc, as it's seems intentional from the code.
On Wed, Jan 27, 2021 at 10:36 PM Garry Flemings<EMAIL_ADDRESS>wrote:

Describe the bug

Whether used directly on an mj-accordion-element or used through
mj-attribute (as in the example mentioned below), borders change
consistent with each mj-accordion-text overriding its border-top and
border-bottom, thus changing all horizontal lines for the mj-accordion
component except the top line.
mj-accordion-element (https://documentation.mjml.io/#mj-accordion)
does not list border among its supported attributes.
https://mjml.io/try-it-live/gs3v2xeDrGl includes the border
attribute on mj-accordion-element. I used it accidentally and missed
the notice, attribute border is illegal.

To Reproduce
Steps to reproduce the behavior:

https://mjml.io/try-it-live/gs3v2xeDrGl (version 4.7.1)
MJML app (version ^4.8.1)
Node v12.18.4 and MJML version 4.8.1.
[image: image]
https://user-images.githubusercontent.com/14095071/106055774-77305200-60b3-11eb-8d90-6d059b1922c2.png

Expected behavior
MJML would be better if either
[image: image]
https://user-images.githubusercontent.com/14095071/106056314-25d49280-60b4-11eb-8b86-42a3ee2b962d.png

The code would ignore unsupported attributes (border on
mj-accordion-element, in this case), or
We change the documentation to indicate support for border on
mj-accordion-element.

Recommended: Option 1 above and not Option 2. Ignore unsupported
attributes and leave the documentation as is. It's probably a rare author
that wants the existing rendering. I don't have a good proposal for this
attribute here.
MJML environment (please complete the following information):
current Windows 10; MJML versions above
Additional context
If the decision is to change the documentation, I volunteer to do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2157, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTNEZ5LZBADYA4JTCQTS4CBOJANCNFSM4WV7DJHQ
.

Didn't expect that, but I'll put in the PR.
Maybe you'll want to disarm the syntax warning "Attribute border is illegal" for accordion-element before merging that PR?

Didn't expect that, but I'll put in the PR.
Maybe you'll want to disarm the syntax warning "Attribute border is illegal" for accordion-element before merging that PR?

You're right you can also add it to supported attribute


Different types of animations supported

Changes:

notifications appear on screen according to screen size
different preset animations are present according to AnimationType enum class (vertical and horizontal)
redone examples to show different types of animations
nicer layout of text notifications

This is awesome @luckyLukac


Changed PROJECT references

This doesn't look right.

The domain should be: gopherkube.dev
The group should be: openstack

I believe that all CRDs should also be updated.

If we do this, the group name will be openstack.gophercloud.dev and other things would need changes

That should be openstack.gopherkube.dev. And yes, I think we should fix this once and for all


libEGL warning in linux desktop app

setup:
$> flutter --version
Flutter 1.19.0-1.0.pre.43 • channel master • https://github.com/flutter/flutter.git
Framework • revision c969b8af7b (18 hours ago) • 2020-05-11 15:28:10 -0700
Engine • revision ada8a0fd64
Tools • Dart 2.9.0 (build 2.9.0-8.0.dev a6d06b59ec)

Steps to Reproduce

Run flutter -d linux run.

Expected results:
app is shown
Actual results:
main window is blank and the following warning appears:
libEGL warning: failed to create a pipe screen for i965
seems like a problem in the newest libflutter_linux_glfw.so (from 1.19 flutter version - in 1.14 everything was working fine)

This is below the level of Flutter; if your system doesn't have a working EGL, the GLFW embedding cannot run.
The reason that this wasn't true before was that we were—incorrectly—failing to specific that EGL was required, which only worked because of bug in GL libraries that has been fixed in more recent versions (meaning that if we don't specify EGL, the embedding would fail to run on newer systems).
You'll need to resolve this at your system level; searches for that error message suggest the problem is likely either in your EGL library, or a driver.

would it be possible to find what version introduced that breaking change? my previous version (1.14) was working fine but it was 3 months old and I wanted to make some upgrade... I already tried to fix egl lib but I failed so I think for now the only solution is to downgrade...

It was likely https://github.com/flutter/engine/pull/16924

thanks a lot!


Update NixOS module files to include WindowMaker

Fixes https://github.com/NixOS/nixpkgs/pull/4066#issuecomment-72017611

You also added other window managers.

Yep! I did it after editing the title of commit :)

@AndersonTorres I wanted to say, just include windowmaker in this PR, thanks :)

Wel, well...
I just run the procedure I learned in [1]. It is very useful to simple testing as I do in mpv and individual packages, but nothing so big as X11+windowmaker. I never tried to do something more advanced in testing Nixpkgs/NixOS from Github.
I even think to do something like a "Nixpkgs Heavy Testing" boot menu on Gummiboot (can I substitute it by Grub?) using my local copy of Nixpkgs, but I am very confused.
So, I can just rely on logic and intuition, and pray to not commit (pun not intended) any mistake.
1- https://nixos.org/wiki/Create_and_debug_nix_packages.

@AndersonTorres I'd prefer only the windowmaker change, yes.

@AndersonTorres when you commit to the PR we don't get notified.

Looks fine to me, don't know whether windowmaker works or not, but if it does for you... :) Merging thanks.

<@AndersonTorres when you commit to the PR we don't get notified.>
So, I need to open a new pull-request? It is a bit "counterproducent". Or there is another way?

Just comment this same PR asking for review :)


Fix usage about help setroles, add example

In the list https://github.com/dnh-bot/dnh-werewolf-bot/issues/138 , is setroles the only command that needs to improve?

Yes, but it's kind of difficult to improve that, so I added an example


YouTube Playback Problems

I noticed that videos within Reddit embeds have audio but no video and have narrowed it down to the AdSkipper extension.
It's happening for me in both Chrome and Edge. I am on version 3.2.
Example video: https://old.reddit.com/r/ROGAlly/comments/1dfwtgj/gamers_nexus_asus_sit_down/
(You need Reddit Enhancement Suite installed to have the embeds show inline)
Another odd thing is when I click through the video it appears to play twice, with one feed more delayed, but when I pause the video it continues playing.

Also, if the owner of a video disabled "Playback on other pages", you can't load the video, cause apparently skipping the ads at the beginning is treated as if you're watching an embedded video.
You CAN click "View on Youtube", but that just opens a new tab, skips the ads and views the same thing again.

I am having the same problem, of blacked out embedded videos, etc., when Ad Skipper 3.2 is enabled.  The embed code was obtained simply by clicking the YouTube Share button.  It is a recent problem affecting existing sites.  I have not updated my Chrome Web browser, so I think that something changed on YouTube's side.

I am aware of the issue and it is fixed in version 3.5. It is live on Firefox and will be soon live on Chrome (when they review it) so make sure you update it as soon as possible.


Include witnesses for Uncle blocks

The miner should also touch/access the necessary witnesses for the receipients of uncle block rewards.

closed by https://github.com/gballet/go-ethereum/pull/40


KAFKA-10849: Remove useless ApiKeys#parseResponse and ApiKeys#parseRequest

More detailed description of your change
#7409 has removed the conversion to Struct when parsing resp, ApiVersionsResponse.parse will be used instead of API_VERSIONS.parseResponse, so the overwrite in ApiKeys.API_VERSIONS is useless.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi, @chia7712 , PTAL.

@chia7712 Thank you, I also created an issue and changed the title.

@dengziming Thanks for your updating. requestSchema and responseSchema are not used by production code also. Could you remove them?

@chia7712 I removed responseSchema  which was used in ApiKeysTest.testResponseThrottleTime to inspect all response,  I think it's similar to tests in ApiVersionsResponseTest, so I just also moved it.

@dengziming I just notice there is a PR (#9748) covering this one. Could you please close this PR and then be a reviewer for that PR?

@chia7712 Oh, sorry for the repeated work, I just closed this pr.


Fix StrEnum deprectation

Has this been pushed out yet as I am still seeing the issues this fix resolves. I'm still only seeing v2024.4.1 able to be downloaded, unless I select a beta version.


Preserve OpenAI's response order

In the schema_ttrpg.ipynb example, it's mentioned that "orjson.dumps preserves field order from the ChatGPT API". This order preservation could be beneficial for certain use-cases, where the order of fields could carry meaningful information or improve readability.
Considering this, I propose that we replace pydantic.BaseModel with a subclass that inherits from it but also ensures that field order is preserved by default. This change would ensure that field order is preserved without needing to rely on orjson.dumps.
To implement this, we could consider using collections.OrderedDict in our subclass to store model attributes.

Internally, the field order of the dictionary already is in the correct order since Python preserved order by default since 3.6, and orjson.loads does it correctly when taking in the structured response.
I added that note in that notebook because certain implementations of pretty printing reorder the field names lexigraphically which was annoying to demo. So nothing to change here.


Set "your balance" to 0 if you are the only active participant

utils/utils.ts#getBudgetBalanceFromTransactions should return 0

Closed in #34


Sage3 Page Heading Updates

Description
Brings page headings up to spec based and includes the following:

Updates description text color in the page heading.
Adjust the spacing of buttons in the page heading toolbar to match the design spec.
Bring charcoal color palette up to spec.

Testing in sage-lib
Visit http://localhost:4000/pages/component/page_heading
Verify page heading toolbar buttons have the correct spacing
Verify page heading intro text has the correct color.
Testing in kajabi-products

(LOW) Color and spacing adjustments within page heading component.

[ ] Offers Page, Email Campaigns, People, or any page using the page heading component.

Related
https://github.com/Kajabi/sage-lib/issues/513

@QuintonJason - just a quick FYI that I included the updates to the charcoal color palette. Spoke with Sam and he mentioned you and him worked on updating it in Figma. Just wanted you to be aware I included them here since the page heading was using some of those updated colors.


Rework ICraftingRequest

The current ICraftingRequest is somewhat of  a mess
so it should be reworked

for now all planed changes are done


New version: MUMPS v1.1.0

Registering package: MUMPS
Repository: https://github.com/JuliaSmoothOptimizers/MUMPS.jl
Created by: @dpo
Version: v1.1.0
Commit: 5e09c3cf82a3c6ee8564c51cb4fa46a5925fa395
Reviewed by: @dpo
Reference: https://github.com/JuliaSmoothOptimizers/MUMPS.jl/commit/5e09c3cf82a3c6ee8564c51cb4fa46a5925fa395#commitcomment-62666357
Description: A Julia Interface to MUMPS

[noblock] This package requires an external dependency to be installed manually. Future versions will use precompiled binaries shipped as artifacts, so manual merging should no longer be necessary.

I'm going to merge this PR this time, but for the future please read https://github.com/JuliaRegistries/General/blob/7d1e7958ed6e980dc69d380e141502131b0fdbaf/README.md#my-package-fails-to-load-because-it-needs-proprietary-softwareadditional-setup-to-work-what-can-i-do, which would avoid the need of requesting a manual merge.


Training hangs when performing an assign op on aggregated gradients in SyncReplicasOptimizer

I'm trying to fetch the aggregated gradients which are computed after aggregating all the replicas together in SyncReplicasOptimizer. To do this, I added an assign op on a variable that I created and assigned the aggregated gradients value (from the aggregated_grads_and_vars). Basically in sync_replicas_optimizer.py apply_gradients() call I did something like:
var1 = tf.Variable(0.0, trainable=False)
def apply_gradients(grads_and_vars, global_step):

   *aggregated_grads_and_vars returned based on replicas_to_aggregate*
   aggregated_grads_and_vars = zip(aggregated_grad, var_list)

   test_var = tf.assign(var1, aggregated_gradients)

   *execute everything else in the fn and return train_op*

Later, I call session.run(train_op) to execute a training steps followed by  session.run(test_var).
My training process goes through with the first training and then hangs. The problem is with session.run(test_var).
My approach works when I use any other asynchronous optimizer (tested on MomentumOptimizer, AdamOptimizer and GradientDescentOptimizer) but not for SyncReplicasOptimizer.
Could this have something to do with SyncReplicasOptimizerHook ?
Any lead would be greatly appreciated.

@sahiltyagi4,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here and also the TensorFlow version you are using. Thanks!

I'm using Tensorflow r1.14.
The source code is available at https://github.com/sahiltyagi4/tensorflow/tree/r1.14.
In particular, I made changes to apply_gradients fn in sync_replicas_optimizer.py at lines https://github.com/sahiltyagi4/tensorflow/blob/r1.14/tensorflow/python/training/sync_replicas_optimizer.py#L285, and doing the assign op the values at https://github.com/sahiltyagi4/tensorflow/blob/r1.14/tensorflow/python/training/sync_replicas_optimizer.py#L285.
I build this tensorflow (WITHOUT CUDA, MPI, etc.) and use this in Resnet at https://github.com/sahiltyagi4/tensorflow/blob/r1.14/models/official/resnet/resnet_regular.py.
When I call mon_sess.run() assign op in sync_replicas_optimizer.py line 285 like I have in https://github.com/sahiltyagi4/estimator/blob/dynamic_v2/tensorflow_estimator/python/estimator/estimator.py#L1542 (I build the estimator from source too btw), that's when my training comes to a halt (know this because previous mon_sess.run on train_op executes for the first step).
Commenting out the assign op, my training executes as it should. Also, in  the apply_gradients fn, when I use the grad_and_vars (returned from compute_gradients fn) instead of aggregated_grads_and_vars (from SyncReplicasOptimizer), I'm able to execute the assign op and fetch its value successfully.
Would also like to point out that when I did the same changes in any other optimizer (in apply_gradients fn of optimizer.py and don't wrap it with SyncReplicasOptimizer), then this works. So I think there's something happening with the SyncReplicasOptimizerHook maybe?

@amahendrakar were you able to see the problem?

@sahiltyagi4,
Thank you for the update. The example is fairly complex, and it is hard for us to pinpoint the issue.
Can you please get the example down to the simplest possible repro? That will allow to determine the source of the issue easily. Thanks!

Also, is there a specific reason you are using TF v1.14? Please update TensorFlow to v2.2 or v1.15 and check if you are facing the same issue. Thanks!


Correction for raw affiliation Laboratory of Signal and Image Analysis, LTSI, Inserm U1099, University Rennes 1, Rennes, France; “Van Gogh” Epilepsy Surgery Unit, Neurology Department, CIC 1414, University Hospital, Rennes, France

Correction needed for raw affiliation Laboratory of Signal and Image Analysis, LTSI, Inserm U1099, University Rennes 1, Rennes, France; “Van Gogh” Epilepsy Surgery Unit, Neurology Department, CIC 1414, University Hospital, Rennes, France
raw_affiliation_name: Laboratory of Signal and Image Analysis, LTSI, Inserm U1099, University Rennes 1, Rennes, France; “Van Gogh” Epilepsy Surgery Unit, Neurology Department, CIC 1414, University Hospital, Rennes, France
new_rors: 01f1amm71;02vjkv261;02baj6743
previous_rors: 01f1amm71;02vjkv261
works_examples: W4389606899
contact: 90c8f4e25d1514d1d4051bd2e7a7591b:8876c39dcfe5097c4a06db57eeb2c346 @ univ-rennes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


<< python tests failed >>

Hello,
I am trying to use PyBioMed that uses RDKit. The error I got running PyBioMed was:
`ls Traceback (most recent call last):
File "./BiEntropy_PyBioMed.sh", line 3, in
from PyBioMed import Pymolecule
File "/usr/lib/python2.7/site-packages/PyBioMed/Pymolecule.py", line 27, in
from PyMolecule import kappa
File "/usr/lib/python2.7/site-packages/PyBioMed/PyMolecule/kappa.py", line 30, in
from rdkit.Chem import pyPeriodicTable as PeriodicTable
ImportError: cannot import name pyPeriodicTable`
Which I think is related to RDKit. So, I cloned the GIT repo and configured/compile RDKit without any error message using the command:
cmake -D PYTHON_LIBRARY=/usr/lib64/python2.7/config/libpython2.7.so -D PYTHON_INCLUDE_DIR=/usr/include/python2.7/ -D PYTHON_EXECUTABLE=/usr/bin/python ..
The environment variables are set correctly relative to RDKit download folder.
My setup:

RDKit Version: 2019.03.1dev1
Platform: OpenSUSE Leap 15 64 bits

Running the ctest I got several Python errors.
` The following tests FAILED:
      9 - pyDiscreteValueVect (Failed)
     42 - pyDepictor (Failed)
     61 - testEnumeration (Child killed)
     63 - pyChemReactions (Failed)
     64 - pyChemReactionEnumerations (Failed)
     84 - pyMolDescriptors (Failed)
    131 - pyGraphMolWrap (Failed)
    134 - pyTestThreads (Failed)
    149 - pyRanker (Failed)
    151 - pyFeatures (Failed)
    152 - pythonTestDbCLI (Failed)
    153 - pythonTestDirML (Failed)
    154 - pythonTestDirDataStructs (Failed)
    155 - pythonTestDirDbase (Failed)
    156 - pythonTestDirSimDivFilters (Failed)
    157 - pythonTestDirVLib (Failed)
    158 - pythonTestDirChem (Failed)
    159 - pythonTestSping (Failed)`

I appreciate any help.
Regards,
Camps

We need more info to be able to help here.
Please try running ctest --output-on-failure and sending part of the output (enough to see one or two full sets of error messages).

Hi @greglandrum, I am attaching the output files here.
LastTest.log
LastTestsFailed.log
ctest_output.txt
CTestCostData.txt

Ah! I got it! Apologies that this took me so long.
You are building against master with Python2. The master version of the RDKit no longer supports Python2: https://github.com/rdkit/rdkit/blob/master/ReleaseNotes.md#really-important-announcement
If you want a python2 build, the most recent version you can use is the Release_2018_09 branch.

we'll fix the build system so that it raises an error if you're using Python2


[DEV-8815] [DEV-9905] Chart Layout Updates

Testing Steps
This update aims to make charts the width of their parent container instead of based off of a screen size and aspect ratio. To review, open various chart pages within storybook.

Uses the <ParentSize /> component to pass the div containers width and height to the child.
ctrl+L forr responsive view keeps the chart within the boundaries of the viewport.
Fixes the editor panel show hide buttons positioning
Removes extraneous styles
Updates the legend positioning to work with Legend Position -> Left now

Self Review

I have added testing steps for reviewers
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

Legend is not going from "right" to "bottom" when we decrease  screen size. It used to go below chart on certain sizes.


[Bug]: DUCE CLI V2.2 cannot Login

What happened?
DUCE CLI V2.2 cannot Login
Enroller
CLI
OS
Windows
Relevant log output
E:\DUCE\new duce>"DUCE-CLI-windows V2.2 2024-09.exe"
Email: ************
Password: **********
Trying to login using Email and Password
Traceback (most recent call last):
  File "cli.py", line 68, in <module>
  File "base.py", line 583, in manual_login
    r.cookies["client_id"], r.cookies["access_token"], csrf_token
    ~~~~~~~~~^^^^^^^^^^^^^
  File "requests\cookies.py", line 334, in __getitem__
  File "requests\cookies.py", line 413, in _find_no_duplicates
KeyError: "name='client_id', domain=None, path=None"
[PYI-13700:ERROR] Failed to execute script 'cli' due to unhandled exception!

Terms

[X] I am using the latest available version.

Make sure you have multi factor authentication disabled. It can only be disabled from the Udemy phone app, the desktop browser doesn't disable it even if the option exists.

I'm sure . I don't set multi factor authentication in udemy phone App.

Now I can login but it not start Enroll after scraping finish.


Starting gear for vox crewmembers

About the PR
Vox station crew spawns with survival gear equipped. A role-specific breath mask, a nitrogen tank, and a tank harness (if not alredy getting SuitStorage-capable outerclothing from their job) to provide a suitstorage slot for the tank. The harness only allows gas tanks into the suit storage slot.
No additional ways to get or replace a tank harness are included
Does not work with ghostroles, most prominently nukies. If a player gets a nukie slot while having a vox character selected, they will spawn as a vox nukie and start being poisoned to death the moment they spawn without breathing gear. Since vox are not yet enabled for player selection, this is not really a stopping issue for this PR and I would rather deal with it separately
Why / Balance
Vox need full-sized tanks and the means to carry them so as to not spend their entire round managing nitrogen
Technical
Also renamed some roleloadout prototypes for more consistent and clear naming. These were added in preparation for expanding species-specific survival boxes to ghostroles and off-station antagonists but haven't been implemented yet, so this shouldn't impact anything
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

I'm still salty about the suit storage change... It just made issues (like this) and didn't really balance anything. Also, like Cojoke said, the addition of a suit storage item with no slowdown could lead to griefing for people looking to have free storage for a large tank.

 I think the slot will either let Vox always hold a tank in that slot or make the harness accessible.

This makes zero sense. There are so many other things you can actively kill or steal from other people for to gain advantages that are significantly better then that of what the tank harness offers. Armor, IDs, and weapons, just to name a few.
Obviously, taking the tank harness kills the vox, but if someone wants to escalate it that far, then that's 100% on them.

looks fine to me


Add the feature of this revolutionary extension Voice-over-translation that allows us to to dubbing substitles voiceover / Subtitle Reader Speaker with natural voices of yandex and  translate video and add subtitles without the need for open subtitles (subtitles generated by the neural network) and Video translation and audio track of the translation useful to learn languages easily and comfortably and also useful for visually impaired viewers please when we have voice overs from subtitles audio track with dubbed voice convert video into translated audio !

Hello, I found this magnificent open source extension Voice-over-translation, it will be awesome to take inspiration from some of its features please to add to dubbing substitles voiceover / Subtitle Reader Speaker  with natural voices and translate video and add substitles without the need for opensubstitles by using subtitles generated by the neural network and to add audio track of the translation......
https://github.com/ilyhalight/voice-over-translation/blob/master/README-EN.md
https://github.com/ilyhalight/voice-over-translation
Thank you !
UPDATE : great news !!!
Hi   , I was going to the chrome store to install and test the Plussub extension because months ago, i say the extension did not work with  streaming site  and I installed it again and now subplus works perfectly 💯 🥇
by installing the Subplus extension, chrome store offered me this extension which has a high rating and I click and I discover that it is an open source extension with the incredible option: "Instant word pronunciation improves your listening and speaking skills with correct pronunciations" !!
I have not yet tried this open source extension if it has a tts for french and if it can read the subtitles in french because I am still in shock and we hope please maybe to be inspired by this open source extension to add the ultimate dream: a tts for french please, thank you very much !!!
https://github.com/Nitrino/easysubs
https://easysubs.cc/en/
https://chromewebstore.google.com/detail/easysubs-–-learn-language/ocelmccppkcibiflhhepafdjjomimddf?utm_source=easysubsco&utm_medium=social&utm_campaign=easysubs_co&hl=en
update :
i find new open source extension that maybe can help to add google tts :
https://github.com/ttop32/MouseTooltipTranslator
which has important feature : use left ctrl to Listen pronunciation with google TTS (text to speech)
update :
and :
Use Microsoft Edge's online text-to-speech service from Python WITHOUT needing Microsoft Edge or Windows or an API key
https://github.com/rany2/edge-tts
https://pypi.org/project/edge-tts/
not official API for Microsoft speech synthesis from Microsoft Edge web browser read aloud
https://github.com/alekssamos/msspeech
https://pypi.org/project/msspeech/
and this natural intonation tts AI :
https://github.com/metavoiceio
https://themetavoice.xyz/
https://github.com/CorentinJ/
https://twitter.com/CorentinJemine
and these tts engines :
https://github.com/alekssamos/YandexTranslate
<EMAIL_ADDRESS>https://alekssamos.github.io/
https://t.me/alekssamos
https://vk.com/alekssamos
https://www.nvda.fr/a50
https://github.com/alekssamos/msspeech
https://pypi.org/project/msspeech/
https://github.com/alekssamos/acapela_box
https://github.com/maudoin/ollama-voice
https://github.com/metavoiceio
https://themetavoice.xyz/
https://github.com/CorentinJ/
https://twitter.com/CorentinJemine
https://github.com/willwade/mms-tts-multilingual-models-onnx
https://pypi.org/project/pyttsx3/
https://github.com/thevickypedia/py3-tts
https://github.com/wannaphong/ttsmms
https://pyttsx3.readthedocs.io/en/latest/#
https://github.com/nateshmbhat/pyttsx3
https://github.com/mediatechlab/tts-wrapper
https://github.com/AceCentre/SpeechBubble
https://github.com/davidacm/NVDA-IBMTTS-Driver
https://github.com/davidacm/PicoTTS-NVDA
https://github.com/ttop32/coqui_tts_korea
<EMAIL_ADDRESS>

and :
Use Microsoft Edge's online text-to-speech service from Python WITHOUT needing Microsoft Edge or Windows or an API key
https://github.com/rany2/edge-tts
https://pypi.org/project/edge-tts/
not official API for Microsoft speech synthesis from Microsoft Edge web browser read aloud
https://github.com/alekssamos/msspeech
https://pypi.org/project/msspeech/


fix: stack environment is deleted on new release

Fixes #17

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


broken link to combine archives

I know you are all scrambling to get the new site up and running. I had an issue filed on libCombine:
https://github.com/sbmlteam/libCombine/issues/55
noting that the old link to combine archives is no longer working. The question is what i should replace it with. Old link:
http://co.mbine.org/documents/archive
thank you

thanks @fbergmann - I think @matthiaskoenig had started a new effort to build that catalogue of standards...not sure how close to being ready that is for using (or at least predicting what the URL would be).
We are also aiming to get an archive of the old site up and running "soon" which should hopefully bring up the old standards catalogue.

Hi all,
was pretty busy with the COMBINE2022, but can get up a first prototype within the next two weeks.
Best Matthias

FYI old website has been backed up to http://old_co.mbine.org.
Many old links can be used with a substitute of co with old_co, e.g. http://old_co.mbine.org/documents/archive
@matthiaskoenig is looking into a more long term solution.


⚠ GitLab Server has degraded performance

In 32cfaf4, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6862 ms

Resolved: GitLab Server performance has improved in fdd7208.


feat(multi-srp): add id and typeIndex to hd keyrings

Explanation

References

Changelog

@metamask/package-a

: Your change here
: Your change here

@metamask/package-b

: Your change here
: Your change here

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
[ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@metamaskbot publish-preview


Crash on getting diagnosis template

Reported in HTAN-117

I am attempting to use the data curator wiki to get the HTAN Duke Clinical Tier 1_Diagnosis Googlesheet template but keep getting stuck on the “Generating link…” step and eventually seeing “Disconnected from the server” in the lower left corner. This has happened at least twice.
I have been able to access and download other templates without this problem, i.e. Biospecimens, Clinical Tier 1_Follow up, etc.
Do you have any recommendations?

Tracked in schematic here: https://github.com/Sage-Bionetworks/schematic/issues/888

This appears now fixed in staging following the recent rebuild to use schematic 22.10.3 in staging. Will move to production in the next update (planned for the end of Nov.


358 increase coverage

Enlarged AlternateRows code coverage

Current coverage is 84.86% (diff: 100%)

Merging #363 into master will increase coverage by 0.11%

@@             master       #363   diff @@
==========================================
  Files            35         35
  Lines          4315       4314     -1
  Methods           0          0
  Messages          0          0
  Branches        394        393     -1
==========================================
+ Hits           3657       3661     +4
+ Misses          616        611     -5
  Partials         42         42

Powered by Codecov. Last update 54866f9...11ca10c

👍


Optimize detection for migration to nwtsty

In some situations it could happen that the merger was not able to detect that one backup had already been migrated to the Study Edition of the Revised New World Translation, while the other one still was using the Regular Edition. This could lead to errors like:

Could not create SQLite database for exporting: [...] UNIQUE constraint failed: UserMark.UserMarkGuid

This version improved the detection of such cases, preventing those kinds of errors in the future.
More details: https://github.com/AndreasSko/go-jwlm/pull/108

Related: https://github.com/AndreasSko/ios-jwlm/issues/36


macchina: 0.7.2 -> 0.8.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123520 at 1fd56f54 run on x86_64-linux 1

2 packages built successfully:

macchina
tests.trivial

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/525


grammar fix in README.md

Edit '..the attacker behaviour..' to '..the attacker's behaviour..'.
Reason: Possessive nouns show ownership.

Edit '..with latest techniques and tools..' to '..with the latest techniques and tools..'.
Reason: Adding an article 'the' to make clear what the noun refers to.

Thank you very much @syfanx !


Problem in using ReactiveImagePicker (in conversion of model object to/from form.value)

I am using ReactiveForms along with ReactiveImagePicker and several other Reactive packages for the implementation of an application involving several forms. I am also using Freezed, JsonSerialization, and Riverpod packages and AppWrite for backend.
In ReactiveForms using ReactiveImagePicker, I am unable to pass 'PersonName' model class object to Reactive Form widget's form.value (for the editing mode) due to use of different types in model class and the form group (String? type in model class and List<SelectedFile> type in form group) for the field using ReactiveImagePicker.
Extract of related code in my app is given below to understand the exact problem:
The model class file (PersonName) contains other fields besides profilePic, of type String?, which is used to store the id or Url of image file stored in Appwrite Storage bucket:
class PersonName with _$PersonName {
  const factory PersonName({
    @JsonKey(name: '\$id') String? id,
    required String name,
    ... // other fields
    String? profilePic,  // this field stores the id or Url of image stored in Appwrite Storage bucket
  }) = _PersonName;

The FormGroup for this class is like this:
final form = FormGroup({
    'name': FormControl<String>(
      validators: [Validators.required],
    ),
    ... // other entries
    'profilePic': FormControl<List<SelectedFile>>(),
  });
}

The main problem is how to convert PersonName object to form.value data (in form display widget) as the form.value has field of type List<SelectedFile> whereas PersonName has the corresponding model class field is of type String?.
For this I am using  PersonNameToFormValue (and corresponding PersonNameFromFormValue) functions:
Map<String, dynamic> PersonNameToFormValue(PersonName personName) {
  final map = <String, dynamic>{
    'id': personName.id,
    'name': personName.name,
      ... //other entries
    'profilePic': personName.profilePic != null
            ? [SelectedFileImage(file: File(personName.profilePic!))]   // File is from dart:io package
            : [SelectedFileImage(url: personName.profilePic!)],
  };
  return map;
}

'profilePic' field in above function uses condition to pass either a File or Url to display widget image in either read only or editing mode.
The line using 'url:' displays the image correctly in readonly mode. However, the line using 'file:' gives the following error:
════════ Exception caught by image resource service ════════════════════════════
The following PathNotFoundException was thrown resolving an image codec:
Cannot retrieve length of file, path = 'http://<IP_ADDRESS>:4003/v1/storage/buckets/65092e956108ccf06e17/files/6509e7cde12e9b138dc4/view?project=64f436798e981511b356&mode=admin' (OS Error: No such file or directory, errno = 2)

Will you please help in this regard?

Thanks  a lot.

Since image_picker returns XFile, why are we using SelectedFile? On web, I can't access the picked image.
inal images = formGroup.control('image').value
                                  as List<SelectedFile>?;

                              MultipartFile? multiPartImageFile;
                              if (images != null && images.isNotEmpty) {
                                final selectedImageFile = images.first;
                                print(selectedImageFile);
                                XFile? file;
                                if (kIsWeb) {
                                  Uint8List? imageBytes =
                                      await selectedImageFile.file
                                          ?.readAsBytes(); // Throw error `Unsupported operation: _Namespace,`

@rsbichkar You could probably try this https://github.com/djangoflow/reactive_forms_widgets
It returns XFile inside SelectedFile, from which you should be able to read image bytes.
For your case, I suppose what you can do is download the image to temp directory and get the image bytes and pass those bytes to ReactiveImagePicker as initial value?

@vasilich6107 Could you check this PR?
https://github.com/artflutter/reactive_forms_widgets/pull/128
After that I will create the PR for File -> XFile change if that is okay.

'You could probably try this https://github.com/djangoflow/reactive_forms_widgets'
@adar2378:
Will you please guide me how can I use reactive_image_picker from this repo?
I have tried to add entire repo as:
  reactive_forms_widgets:
    git:
      url: https://github.com/djangoflow/reactive_forms_widgets

However, I am unable to use reactive_image_picker from this repo.
On the other hand, if I use
  reactive_image_picker:
    git:
      url: https://github.com/djangoflow/reactive_forms_widgets/tree/master/packages/reactive_image_picker

it results in github error
fatal: repository 'https://github.com/djangoflow/reactive_forms_widgets/tree/master/packages/reactive_image_picker/' not found
exit code: 128
exit code 69


Secor copying files under inconsistent file path

When copying files from kafka to our hadoop nodes secor is pre-pending files under a randomly generated directory following the format <dynamic_number>//...
I would like to remove the <dynamic_number> such that I can always find my data stored under a consistent path for querying data. So far the only fix I have found is by removing lines 151-153 in LogFilePath.java:
if (mPrefix != null && mPrefix.length() > 0) {
//     elements.add(mPrefix);
}
Is there a way to handle this without a code change?

Can you give an example on the current file path secor was generating on your file system?


Chronos needs to log in every start

Expected Behavior
Chronos should be logged into the jira instance even after quiting the application.
Actual Behavior
I Need to Login in again every time I start the application after Windows reboots
Steps to Reproduce the Problem

Start Chronos and Login
Quit Chronos reboot Windows.
Start Chronos again and Login in again

Specifications

Chronos-timetracker version: 2.8.4
OS: Windows 10 x64 1803 Build 17134.376
Jira: Jira v. 7.2.7

I also have the Problem that the application suddenly does a Logout during runtime and no entry will be logged in Jira.

@emprise1976  Try 2.8.5, please, logout and then login again(it should fix the issue)

Issue is fixed thx


Discouraged control flow

I prefer this control flow for discouraged in main.rs, I think it's clearer than the dummy closure.
I wanted to push this on the previous pull request but I was just one minute too slow!

heh, I was looking at that and thinking of exactly the same change :)


Turn product price into integer

Probably not relevant at the moment but if we eventually have anything in stock which costs more than an euro, presenting the price in cents would look a bit strange.


Building with zig and failing at runtime on mir_hash_1

I'm trying to build MIR with my build.zig for buzz so that users are not required to build it separately by hand and also for it to be automatically built for the current platform.
-> https://github.com/buzz-language/buzz/blob/mir/build.zig#L639-L703
It builds and links ok but crashes at runtime here:
    frame #0: 0x0000000101216270 libbuzz.dylib`mir_hash_1 [inlined] mir_get_key_part(v=<unavailable>, len=<unavailable>, relax_p=<unavailable>) at mir-hash.h:0 [opt]
   62     return state ^ mir_mum (state, p2, relax_p);
   63   }
   64
-> 65   static inline uint64_t mir_hash_1 (const void *key, size_t len, uint64_t seed, int relax_p) {
   66     const uint8_t *v = (const uint8_t *) key;
   67     uint64_t r = seed + len;
   68

@vnmakarov Do you have any idea as to what I might be missing?
Note that it works perfectly when building by hand with make

We found that the issue is that MIR seems to rely on undefined behaviour somewhere.
Building with zig ensures that any undefined behaviour results in a trace trap.
Building with -fno-sanitize=undefined which removes this behaviour, fixed it.

Nevermind you had -fno-sanitize=undefined in GNUMakefile I just didn't see it


Feature Request: Missing flag for language when using the command urcli assign.

What's the feature?
I would like to be able to choose the language when using the command urcli assign <list of ids>. We could add a flag such as --lang to achieve this goal. In the end, I would do something like that: urcli assign 123 345 --lang=pt-br.
What problem is the feature intended to solve?
Sometimes, I want to review projects with specific languages and unless I define this on setup, I am not able to do so. By adding this feature, the tool would be more flexible and would  improve the UX.
Is this feature similar to an existing feature in another tool?
No that I know of.
Is this a feature you're prepared to implement, with support from the urcli team?
Yes. I have started to use this tool 4 days ago but I am able to explore a little more before to submit a PR.

UPDATE: Acabei de ver que a API nao da suporte a isso =[

Hi Samantha, I actually don't think there is a way around this limitation of the API. But maybe it's worth getting in touch with one of the devs and ask them if they could fix it? It should be an easy feature to implement on our side.

Will do it, @trolster! Thanks though (sorry for the pt-br version of the UPDATE comment lol I mix languages sometimes when I am using both with lots of frequency, I am sure you got an e-mail with Brazilian Portuguese on it, anyways..... have a great week)

@samanthakem No worries! I wish you a great week also :-).


request for access to source code of javascript template file

When we were debugging ricardian contract rendering, we encountered several errors related to javascript template rendering.
to be specific, it's Eosio/Transactions/contract-template-toolkit.js, a minified js, which makes debugging really difficult and hard to read.
could you provide the un-minified source code of it?
and if there's other similar files in this project, could you provide those also?
Thanks

found it: https://github.com/EOSIO/ricardian-template-toolkit

Sorry we didn't point you in the right direction earlier! Glad you found the RTT.


thinking in react - full Hindi translation

I've created the PR as some of the translations are still in discussion mode. I'd like you to review the remaining of the doc, we may do the necessary changes meanwhile.
Requesting @arshadkazmi42 and @saranshkataria to review the PR.

@arshadkazmi42 what do you suggest? Should I start working on the review comments already? Or wait for you to complete the review of whole file? There'd be multiple commits in prior case.

@mayank-gangwal start working on the comments. we review it in parse. You can read about our review process at #23

Good work. You missed a couple of feedbacks. Let's get those fixed before continuing with further reviews

added comments till {#step-1-break-the-ui-into-a-component-hierarchy}

@saranshkataria waiting for your inputs. Please go through my comments on yours.

@saranshkataria @arshadkazmi42 waiting for your response since long... Let me know when we may take this page's translation ahead...

@mayank-gangwal have responded to the comments. Sorry for the delay. Got busy with some things.

Closing due to inactivity


userland_generic.ld: Include .sdata in the data section

If an ELF has a .sdata section it won't be copied to the TBF file. To
ensure that it makes it in let's include it in the data section.
Signed-off-by: Alistair Francis<EMAIL_ADDRESS>

@gkelly I'm not sure what you mean?
sdata seems to just be small data it's not RISC-V specific. Do you want me to add a comment saying that it's small data?

Huh, interesting; from a quick skim of that doc, looks like a new gcc thing
circa ~late 2017, TIL.
If you wouldn’t mind still adding a comment and pointer, we err pretty hard
on the side of doing anything possible to make the linker scripts easier to
read and maintain. Thanks!
On Fri, Feb 7, 2020 at 08:42 Alistair Francis<EMAIL_ADDRESS>wrote:

@gkelly https://github.com/gkelly I'm not sure what you mean?
sdata seems to just be small data
https://embarc.org/toolchain/gcc/small-data.html it's not RISC-V
specific. Do you want me to add a comment saying that it's small data?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tock/libtock-c/pull/69?email_source=notifications&email_token=AACS3XQRHFV5GJP4SFNBPM3RBWFORA5CNFSM4KRG4MAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDWAOY#issuecomment-583491643,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACS3XRLCBMYMDFVWIADVZTRBWFORANCNFSM4KRG4MAA
.

Oh yeah this is generic, sorry @alistair23.

I added a comment


fix wrong link in workload summary

@amaltaro, Alan please review. It seems it doesn't affect things in the surface though, we might not use jquery in the workloadsummary code.

Seangchan, can you please elaborate on the issue? Example? Maybe just create an issue and point this fix to it.

Sorry Alan, her is the case
When you go to any workloadsummary page.
https://cmsweb.cern.ch/couchdb/workloadsummary/_design/WorkloadSummary/_show/histogramByWorkflow/vlimant_ACDC3_task_HIG-RunIIFall17wmLHEGS-01285__v1_T_180831_162104_8438
You can see this javascript error. which means it doesn't load this 2 library. It is due to wrong path for those script. We could load this locally, but cdn has advantage, it will be cached in the browsers, it will have a little performance gain. What I don't know is whether these libraries are actually used.
json2.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
jquery.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)


Clarify documentation for storage.oci.repository

@chuangw6 PTAL

@Yongxuanzhang PTAL

/retest

/kind documentation

Thanks for adding this clarification! And for your screenshot maybe we should hide some personal information like your project id etc?

I thought about that; the project is already deleted, so it should be harmless.

/lgtm
/approve


Audio player starts playing another instance when file is forking

Load a file that has audio. http://vizor.io/fthr/undefined-7/edit
Press play, audio starts to play. Edit the graph in some way, Vizor makes the forked url. Now two audio instances play.
Desired action: Forking doesn't affect audio playback.

A free pint of Beer to whoever fixes this one.


changelog: Fix heading levels

The "Added, Fixed and Changed" headings should be one level below the individual versions to nest them properly. This gives dependency update services (renovatebot, dependatbot, etc.) a chance to parse the changelog and extract the changes for their PRs :)

Thanks!
@bors r+

:pushpin: Commit 1b08d4e180b4809161a70777accdde36879d8667 has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 1b08d4e180b4809161a70777accdde36879d8667 with merge 5d4927631bb072c35697d10a6efdb57a6647f0d8...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing 5d4927631bb072c35697d10a6efdb57a6647f0d8 to master...


HeroCard Example

The HeroCard sample does not work unless you add the following template.
cardActionTemplate(type, title, value)
[CardAction
Type = ${if(type == null, 'imBack', type)}
Title = ${title}
Value = ${value}
Text = ${title}
]
No where is it mentioned where this template is defined. The page should be added to include a note with the cardActionTemplate.
See https://github.com/microsoft/botframework-components/issues/716
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d83aee89-68c9-a192-b40b-a718efd00cf7
Version Independent ID: 2eda2def-113e-ac41-0c2f-c8c0405ec2a1
Content: Respond to users with cards - Bot Composer
Content Source: composer-docs/how-to-send-cards.md
Service: bot-composer
GitHub Login: @WashingtonKayaker
Microsoft Alias: kamrani

Hi @mercer2000, can you elaborate? I successfully tested the sample that has both the HeroCard and HeroCardWithMemory templates.


Create gov_sitemaps.csv

Gov_Domain Sitemap URLs and the contents of those sitemaps

@antoinemcgrath there are some oddities in here like http://drupal.org) and http://schema.org and some home pages and other pages that don't look like sitemaps themselves. Do you want to do some clean up on this, or do you want me to load all but the most obviously not in scope for EOT URLs to the bulk nomination tool?