'make test' failures for MSVC build with '-arch:AVX2' key on Windows

Hello everyone,
For builds using MSVC:
perl Configure -arch:AVX2 shared VC-WIN64A && nmake && nmake test

test recipes:
70-test_asyncio.t
70-test_bad_dtls.t
70-test_clienthello.t
70-test_recordlen.t
80-test_cipherbytes.t
80-test_cipherlist.t
...

unable to finish its tasks and had to be terminated manually.
Reproduced for:

builds using MSVC with <Release><Shared|Static> configurations and -arch:AVX2 key.

Not reproduced for:

builds using MSVC with <Debug><Shared|Static> configurations and -arch:AVX2 key,
builds using MSVC with <Release><Shared|Static> configurations and -arch:AVX key,
builds using migw-w64 with -mtune=native -march=native keys on Haswell CPU and ICC with -QxCORE-AVX2 key.

Environment:

Windows 10 x64,
MSVC 2015 Update 3,
Windows SDK 10.0.14393.33,
Active Perl 5.24.1,
OpenSSL-1.1.1-dev (8530039a307f7aa8acb0516fdd38191baa91d434).

Alexander

oh, generally all Windows Versions are currently broken.

could you please try if b5319bdb fixes your problem?

Downloaded recent master and patch b5319bdbd095ff59d084af5ce16e5f715963557d, but was unable to apply it neither using git apply command neither manually, since OpenSSL sources doesn't contain wanted strings.
On what OpenSSL sources should be applied this patch?

master branch

Ah, I missed that b5319bdbd095ff59d084af5ce16e5f715963557d was already merged to master. It turns out I tried to apply it again.
Just tested build using MSVC with Release Shared configuration and -arch:AVX2, and make test run get stuck on 70-test_asyncio.t test as before patch.

And if you build with no-asm does it work then?

Tested build using MSVC with Release Shared configuration and no-asm -arch:AVX2 keys, and make test run get stuck on 70-test_asyncio.t test as before.
In addition found, that error not reproduced, if /O1 key used instead of /O2 for Release Shared build.
Since this issue could relate to my system or MSVC 2015 instead of OpenSSL, could anyone reproduce it using MSVC 2015 and MSVC 2017?

I haven't tried to reproduce it, but two things. The fact that outcome depends on optimization level is very likely an indication of a compiler bug. Compilers bugs never make sense and bite you when you least expect it, and there is nothing we can do about it. Secondly, out of curiosity, what is it you are trying to achieve with -arch:AVX2? Note that it doesn't affect assembly modules, in sense that you get all the fancy code paths like AVX2 or AVX512 [provided that you use nasm] compiled and executed [if appropriate for current processor] irregardless -arch flag passed to compiler [or compiler itself]...

[or compiler itself]

More specifically compiler's ability to generate AVX2 code. I mean AVX2 assembly code paths will be compiled [provided that you use nasm] and executed even if compiler has no idea whatsoever about AVX2.

Compilers bugs never make sense and bite you when you least expect it, and there is nothing we can do about it.

But we could report it on MSVC bugtracker. Thus I asked OpenSSL Community about build results using MSVC <2015|2017> on Haswell CPU.

what is it you are trying to achieve with -arch:AVX2?

It's hard to expect, that usage of -arch:AVX2 key for builds using MSVC would significantly increase OpenSSL performance. At least not today.
The main goal was to use the same set of compiler keys during build of different libraries. Based on the (naive) assumption, that it would decrease chance of (runtime) troubles, when all that libraries would be combined in the same project.
And since build systems of few of that libraries are using -arch:AVX2 key in its MSVC toolchains, it was added to build commands of all other libraries. That's how this issue was revealed.

The problem persists even with VS2017. It actually fails earlier, already in test_evp with
        # Subtest: run_file_tests
        1..1
        # INFO:
        # Reading recipes\30-test_evp_data\evpciph.txt
        # ERROR: (ptr) 'equals = strchr(s->buff, '=') != NULL' failed @ test\testutil\stanza.c:107
        # 0x0
        # INFO:
        # Missing = at line 8
        #
        # INFO:
        # Completed 0 tests with 1 errors and 0 skipped
        not ok 1 - recipes\30-test_evp_data\evpciph.txt

I.e. it apparently fails to parse file, let alone perform calculations. Even though this doesn't formally preclude possibility that stanza.c violates some letter of the standard, which allows compiler to generate failing code, knowing that lowering optimization level helps speaks rather in favour of suggestion that it's compiler bug [i.e. non-OpenSSL problem].

-arch:AVX2 ... would decrease chance of (runtime) troubles, when all that libraries would be combined in the same project.

It won't make any difference. I mean having different parts compiled with different -arch flags. Well, given natural limitations, like -arch flag in either component effectively limiting where you can actually execute binary.

Thank you for test results using MSVC 2017. Since error reproducible, I reported it on MSVC bugtracker.
And this issue could probably be closed, as

non-OpenSSL problem

ok, good bye.

Hi, I'm a developer on VC++. I'm writing to confirm that you did indeed find a compiler bug for /arch:AVX2, thanks! The SBC (silent-bad-codegen) is occurring in ssl_cipher_collect_ciphers, in ssl\ssl_ciph.c.
I just finished tracking down the function we're breaking on, so I can't say anything about an ETA for a fix, but if this is blocking: I confirmed that turning off optimizations for that function (via #pragma optimize("",off) ... #pragma optimize("",on)) lets an -arch:AVX2 build get past the hangs you've observed. I don't see the other issue dot-asm mentioned about parsing, however.
We daily test our latest compiler bits against a suite of OSS projects, including this one, to flush out compiler bugs. We haven't gone beyond the default release options for these projects, but clearly it's worth looking into more.
Also, thank you very much for reporting the bug and the very clear repro instructions in the Connect thread. I gave a quick reply there too. When we have a fix for the bug we update the Connect thread.
Thanks again,
Aaron Gorenstein
Microsoft Visual C++

Hello, Aaron,
Thank you for response. Tested workaround with #pragma optimize("",<off|on>) for ssl_cipher_collect_ciphers() and it allowed to bypass this issue.
I will follow the updates here and in the Connect thread.

Tested workaround

Just in case, it won't be considered for inclusion into repository. As already mentioned, there is no reason to compile OpenSSL with -arch:AVX2, so just don't. At least till compiler bug is fixed. Well, even when it's fixed, it still wouldn't real point in doing so... @aargor, what would be more helpful if you could back up the assertion that there is no requirement that all (dll) components of application have to be compiled with same -arch flag. In sense that if it's shown that there is some breakage because of the mixing, it will be considered by Microsoft as bug. It will have to be, because it would mean non-compliance with calling convention. Well, admittedly except for "natural" breakages like execution on pre-AVX2 processors, execution of application with at least one component compiled with -arch:AVX2.

I don't see the other issue dot-asm mentioned about parsing, however.

Note that we are using different VS versions. @sav-ix - 2015 and myself - 2017. For reference, my compiler version is 19.10.25019. However, I just double-checked and it turned out that parsing failure does not depend on -arch:AVX2 flag. In other words it appears to be independent problem...

Just in case, it won't be considered for inclusion into repository.

Since it's just a workaround, and since issue relate to the compiler, of course there is no sense to push it to master.

parsing failure does not depend on -arch:AVX2 flag. In other words it appears to be independent problem...

As it turns out it's the way my git checks out files. It was replacing \n with \r\n, which confuses parser. I mean when it says "can't find =" it's looking at line consisting of \r alone. So disregard comments about parsing, I apologize for unnecessary possible confusion.
[Hmmm, I recall looking into it... It might happen that I found default appropriate at the time, and it, default, has changed afterwards in grand upgrade to 2017. Windows is not my platform of choice for daily activities...]

The parser issue is probably because of this, i.e. we open text files in binary mode for some reason.
(I cannot for the life of me understand why we do that)

Oh! It is because of that. I mean I can confirm that if I check out in my usual way and remove 'b', then it works! Thanks!

We use stdin/stdout in whatever mode they are in.
We consistently open ‘-in’ and ‘-out’ files in binary mode because it is consistent – are we reading a DER file or a PEM file?  We can’t tell at the open time.

That's not stdin, that's a file named as an argument, and we know it's a text file.
Re the command line and if I recall correctly, we open stdin in text mode if we expect pem, and binary mode if we expect raw der, all depending on the -inform argument (default pem)

No, stdin is always left as the platform has it.  If you want explicit control, use the -in/-out flags.

Maybe you should grep for B_FORMAT_TEXT in apps/apps.h and look at the format macros you find. Perhaps also look at dup_bio_in with friends in apps/apps.c

But meh, the discussion on command line is neither here nor there in this issue. The issue is test/evp_test.c, which does open files named on the command line, and wrongly opens them in binary mode.

Thanks for the nudge.

Oh.  Well, fix that. ☺

See #3939

Hi @dot-asm , I agree that what you described about "mixing" /arch dlls should be supported. I don't see it written down anywhere, so I'll see if I can get a published statement.
Glad this isn't a blocking issue for you all,
Aaron

Since link at Connect became 404, reporting here: issue not reproduced after moving to MSVC 2017 15.5.0.
Thank you for fix, Aaron.

Just in case, it won't be considered for inclusion into repository.

Based on this, me also have a question out of curiosity. If proposed:
#pragma optimize("",off) ... #pragma optimize("",on)

workaround for this issue could not be added to master, since it's a compiler bug, then why https://github.com/openssl/openssl/commit/b32166b4fabd2a3aeec382521b0173b24a5d7c02 wasn't reverted, after related ICE was fixed with MSVC 2015 Update 2, and OpenSSL CI builds became unblocked? Thanks.
CC: @mattcaswell

Not adding a special pragma is not the same as reverting a no-longer-necessary change.  It could have been done, but nobody saw the need or made a PR or even suggestion to do so.  The change also didn't break anything.
The pragma approach isn't portable, since 'pragma optimize' could mean different things to different platforms.  It could have been wrapped in an ifdef, but then it start to grow bigger and uglier.


Release March 7th

The following packages will be released:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Closing this PR as there were few more that needed to be released (https://github.com/cerner/terra-framework/pull/2072)


Option to look for default files at the root of wwwroot path only, not at subpath

DefaultFiles middleware allows routing to default files at request subpath if no file was found, but for angular or other single page apps we would need to always route to /wwwroot/index.html for any subpath, i.e.:

http://localhost:5000/ -> wwwroot/index.html
http://localhost:5000/some-sub-path -> wwwroot/index.html

Currently we have to write custom middleware to handle this case (see stackoverflow for example). But it seems that adding option to DefaultFiles to route to wwwroot will be a good solution for such a common case.
https://github.com/aspnet/StaticFiles/blob/dev/src/Microsoft.AspNetCore.StaticFiles/DefaultFilesMiddleware.cs#L67

@NickAb By "custom middleware" do you mean the example in http://stackoverflow.com/questions/31184446/asp-net-5-html5-history/34882405#34882405?

For the moment I use this instead:
app.Use(async (context, next) =>
{
	await next();

	if (context.Response.StatusCode == 404 && IsGetOrHeadMethod(context.Request.Method))
	{
		context.Request.Path = "/"; // Put your Angular root page here
		await next();
	}
});

Also there is an Angular Middleware on github.

Possibly related to https://github.com/aspnet/StaticFiles/issues/111

I think it would be an option like IncludeSubDirectories on PhysicalFileProvider.


LInk for documentation goes to deprecated pages

The following section:

See the previously published documentation for Service Broker concepts and for development and management tasks. This documentation is not reproduced in the SQL Server 2019 (15.x) documentation due to the small number of changes in Service Broker in SQL Server 2019 (15.x).

Links to the Microsoft docs site here: https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2008-r2/bb522893(v=sql.105)?redirectedfrom=MSDN
Each page there on in is labelled:

This content has been retired and may not be updated in the future. The product, service, or technology mentioned in this content is no longer supported.

Understanding that the documentation has changed little (hence the back link), should it be labeled though stating that it's no longer supported?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f089d928-4091-1873-0d28-c1307187aff3
Version Independent ID: af2356c1-5d4d-6d14-e9d4-9cfdddc37abd
Content: SQL Server Service Broker - SQL Server
Content Source: docs/database-engine/configure-windows/sql-server-service-broker.md
Product: sql
Technology: configuration
GitHub Login: @markingmyname
Microsoft Alias: maghan

@RachelAmbler -- Rachel, thank you for your feedback.  I agree the destination pages' "no longer supported" seems to contradict the starting page's description; in this case the intention is clear.  I will bring this up to our docs team.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


WSL2 Ubuntu - how to start as regular user

Windows Version
Windows Server 2022 (21H2)
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps
I have installed WSL2 Ubuntu-2204 in a regular user account via "Power Shell as Administrator". Ubuntu can be started from within this shell as administrator.
For regular use, I would like to start Ubuntu as a regular user without admin rights, but this seems not be possible.
I assume, it is due to access rights to WSL2 files and folders.
In addition: I cannot see an "Ubuntu" icon in Windows Start menue (I have seen this when I installed WSL2 Ubuntu on an admin account). How can I create a start icon for Ubuntu (probably after solving the issue above)?
Best regards
Expected Behavior
I was expecting to start Uuntu in Power Shell
Actual Behavior
Ubuntu cannot started in Power Shell as regular user without admin rights
Diagnostic Logs
No response

Issue solved with the following actions:
In order to start WSL-Ubuntu on a Windows 2022 server, the following modifications work for me:

The users were added to the "Power Users" group
A Windows Power Shell was started from the user account without administrator privileges
WSL was updated by: wsl --update
Ubuntu was installed by: wsl --install -d Ubuntu

The Ubuntu start icon is now availabe in each user's start menu, Ubuntu can be started without any admin priviledges.
If there are moderators in this microsoft open community, I would appreciate if somebody could check whether the procedure described above would be an appropriate way to install WSL for Windows Server 2022 regular users.
Best,

This is indeed the right way to start WSL non-elevated (start it from a non elevated shell). Closing since the issue is resolved.


Correction for raw affiliation Doctorant au CELSA, laboratoire GRIPIC

Correction needed for raw affiliation Doctorant au CELSA, laboratoire GRIPIC
raw_affiliation_name: Doctorant au CELSA, laboratoire GRIPIC
new_rors: ;04p8das24
previous_rors:
works_examples: W4298045406
contact: 71b9d2a17c1f329fa54c58837467da9f:0ed37c9c97e7bb2c2d76680fd8 @ sorbonne-universite.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Romanian translation issue for Togo (+228) country

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-country-codes-picker/constants/countryCodes.ts b/node_modules/react-native-country-codes-picker/constants/countryCodes.ts
index d60d6ec..92f9374 100644
--- a/node_modules/react-native-country-codes-picker/constants/countryCodes.ts
+++ b/node_modules/react-native-country-codes-picker/constants/countryCodes.ts
@@ -1,4 +1,4 @@
-import {CountryItem} from "../types/Types";
+import { CountryItem } from "../types/Types";

 export const countryCodes: CountryItem[] = [
     {
@@ -6492,7 +6492,7 @@ export const countryCodes: CountryItem[] = [
             "by": "Ісці",
             "pt": "Togo",
             "es": "Togo",
-            "ro": "A merge",
+            "ro": "Togo",
             "bg": "Да отида",
             "de": "Gehen",
             "fr": "Aller",

This issue body was partially generated by patch-package.

Related to PR #93


bgpv1: Cleanup BGP reconcilers setup

Ensure BGP reconcilers are not being set up and no BGP-related jobs start when BGP Control Plane is disabled.
Also, make distinction between v1 and v2 reconcilers in logs during the setup.
bgpv1: Cleanup BGP reconcilers setup to ensure that no BGP CP jobs are started when BGP CP is disabled

/test


Alt+~ stroke that turns IME on and off makes to insert the unexpected '@' character

Steps to reproduce

1. Install any Japanese IME. I tested Microsoft IME and ATOK.
2. Press Alt+~.
3. You can get the situation.

Expected behavior
Alt+~ stroke should not insert any character.

Actual behavior
Alt+~ stroke insert the '@' character.

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.3
PSEdition                      Core
GitCommitId                    7.0.3
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Please install latest PSReadline version and check again.

I upgraded PSReadLine but I get the unexpected behavior which is described above.
Environment data
PS version: 7.0.3
PSReadline version: 2.1.0-beta2
os: 10.0.18362.890 (WinBuild.160101.0800)
PS file version: <IP_ADDRESS>
HostName: ConsoleHost (Windows Terminal)
BufferWidth: 120
BufferHeight: 50

Thanks for confirmation! You could review PSReadline repository - it seems there was an issue about IME, if no please open new one.

/cc @daxian-dbw

/cc @daxian-dbw


Make geocoding respective to all values of the based fields

This patch makes location field to be based on all the based fields instead of the last edited single value.
It's useful when you have more than one fields for the address.
based_fields=['address', 'city', 'state', 'zip_code', 'country']

Thanks!


Not available in German Playstore

The mobile app has been deprecated as GitHub is about to release an official app so closing this issue.


Does it support command line arguments?

This is my batch script:
@echo off
python %APPDATA%"\pdviewer\pdviewer.py" %1
pause

The python file should take the first argument and process it but it gives the error:
file_path = sys.argv[1]
IndexError: list index out of range

No, tested it on this script :
call C:\N1\BAT\!SM122.BAT %1
exit /b

and the %1 variable works in the script but not in the finished EXE.


Slack App Token, where to obtain?

Hey, I have tried setting my SLACK_APP_TOKEN as the OAuth token, and also using my Client Secret.
How should I proceed? Thanks!

Hello @maurocasas
I do not personally use slack with LERN but I do know that we have many users that are currently using is successfully. LERN uses monolog on the backend to connect to various services. You could try going through these links to find a solution.
https://github.com/Seldaek/monolog/issues/743
https://github.com/Seldaek/monolog/issues/514
@loranger, @drjonnicholson, @isomis I know that you guys have mentioned using slack in the issues you've opened up. If you guys have any information on this your help will be most appreciated


[Stacks Wallet] Improve data store security

@hstove Mind bullet pointing the changes here for context? I don't recall very well which improvements we're making to support the store listing.

@hstove Mind bullet pointing the changes here for context? I don't recall very well which improvements we're making to support the store listing.

Oh - it's not related to the Chrome / Firefox extension store. By "store" I mean the internal data structures used by the app itself... which we call a "store". Totally understandable misunderstanding 🤣

Oh - it's not related to the Chrome / Firefox extension store. By "store" I mean the internal data structures used by the app itself... which we call a "store". Totally understandable misunderstanding 🤣

Aaah okay, I just updated the title then 👍
I do still think it'd be helpful to bullet point the intended improvements here, perhaps as a checklist so we can track progress more clearly and understand just what security risks they resolve.

Aaah okay, I just updated the title then 👍
I do still think it'd be helpful to bullet point the intended improvements here, perhaps as a checklist so we can track progress more clearly and understand just what security risks they resolve.


Save as Template and able to re-edit

Can i save it as a template so user can open and reedit it? it would be very usefull

Currently, this library focuses on image editing feature having save template will require a database which we are not intended to do

@amrilkholid did you find any solution till now?


Getting different accuracy in Python and Xgboost Java

Is it possible to get different accuracy in xgboost java module and Python?? I am using same parameters for both.

it should not
please follow the issue template when report your issue,

For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System: Ubuntu
Compiler:
Java 1.8 oracle
Package used (python/R/jvm/C++): python and jvm
If installing from source, please provide

The commit hash (git rev-parse HEAD)
Logs will be helpful (If logs are large, please upload as attachment).

If you are using python package, please provide :

The python version and distribution : Python 2.7.6 (default, Jun 22 2015, 17:58:13)
The command to install xgboost if you are not installing from source : using pip
xgboost version used: xgboost (0.6a2)

Steps to reproduce

Run script using python and run using java xgboost

What have you tried?

Tried with python : https://github.com/ragnar-lothbrok/ctr-pred/blob/master/com/demo/prection_xgboost.py
Java : https://github.com/ragnar-lothbrok/spark-demo/blob/master/src/main/java/com/spark/lograthmicregression/ClickThroughRateAnalytics_XGboost.java

Increasing depth and round :
Java accuracy incresing [up to 91%]
Python constant up to 85%

not familiar with python stuffs, let me ping @terrytangyuan
but I think you can dump the model to see whether the trained model is exactly the same

Anyone found out the reason behind this issue ??
I am also facing the same issue ... with Java I am getting 5-10% more accuracy than in Python.
Not sure why !!! This is another similar issue logged though closed issue still persist -> https://github.com/dmlc/xgboost/issues/1992

I am facing the issue, could you help me with the resolution?


Allow mounting of an entire file of environment variables

Encrypted, but such a great feature
https://twitter.com/qovery_/status/1611683689531953153?s=46&t=JGpmDh-fgirG7nE542gE_w

to keep this in mind while working on #2742

Actually, we kind of already have this feature through #3020.
# include all env variables
bacalhau job run  job.yaml --template-envs ".*"

  -E, --template-envs string           Specify a regular expression pattern for selecting environment variables to be included as template variables in the job spec.
                                       e.g. --template-envs ".*" will include all environment variables.
  -V, --template-vars stringToString   Replace a placeholder in the job spec with a value. e.g. --template-vars foo=bar (default [])

You first need to load your env variables from the file into your terminal, and then allow parsing them into your template through --template-envs ".*"
Do you think this is enough of should we add a new --template-vars-file to read template variables from a file?


fix bug when replica is bigger than one

/assign @qiujian16 @zhiweiyin318

/retest

/lgtm
could you also change the agent in the same way?

Ok, i will log a new task to handle this


User module operations

User permission

[ ] protected delete
[ ] mass delete
[x] input validation
[x] set dafult category if none is provided
[x] service check for unique values

User groups

[ ] edit (protected)
[ ] protected delete
[x] input validation
[x] service check for unique values

Users

[x] enable
[x] disable
[x] edit user
[x] change my own profile
[x] input validation
[x] show all
[x] service check for unique values

PermissionCategory

[x] set name to be unique
[x] add getbyname to dao
[x] service check for unique values

separated into issues #70 #72 #73 and #74


[MTDSA-194] [DM] Add sandbox implementation of create/read liability

Provides the sandbox implementation of create and read liability giving static responses.

👍


Alphabetize Systeminfo list

What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain:
What changes did you make? (Give an overview)
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?

Rebased https://github.com/maggie0002/balena-device-ui/pull/34 with these commits and will merge them from there.


Adds 'tenant serviceannouncement healthissue get' command. Closes #2951

Adds tenant serviceannouncement healthissue get command. Closes #2951

Awesome @SmitaNachan, we'll review it shortly 👏

Hi @SmitaNachan,
I am going to review it shortly. I will provide you with some feedback.
We will merge the PR once #2948 is implemented.
Cheers

Hi @SmitaNachan,
thank you for your contribution.
I just reviewed the command and I would like to ask you to do some more validations from your end. Could you please verify the output when using it in conjunction with the output text and CSV and remove the output that is not readable?
Let me know if you have further questions.
Cheers,
Patrick

Hi @plamber
Adjusted the output for text and csv. Please review.

Thank you @SmitaNachan , will come back to you asap


Getter and setter properties with js_sys Reflect

Instead of using manually built wasm_bindgen functions, we can just use js_sys::Reflect to get or set properties when the value is an Object. This reduces some clutter and avoids using js directly.

bors r+


[Feature] Customize the Avatar Image for Webhooks

[Feature] I think it would be nice to have the ability to customize the avatar image for webhook messages to a different site or having more options.

By customize, do you mean the images used for Chat webhooks, which is currently the player head?

Yep! I think the image generated from https://mc-heads.net/avatar/alloutjay.png personally looks better or I know some mods have the ability to do busts/the upper half of the body as the images used in the chat webhooks where the player head is.

Hmm. I'll check it out. As for mc-heads.net, I just gave it a quick look and the site takes very long to load compared to crafatar, which concerns me a bit, but it's still worth considering

There is also https://minecraftskinstealer.com/avatars/skin/alloutjay and I am sure other sites that do the same thing

@hypherionmc I think the positioning of some of the options needs to be modified as it doesn't look right or seems off.

Do you have pictures?
I didn't send any additional info to the api aside from the UUID, so it's all their default settings

Body seems to focus a little too low. Combo, I'm not sure what that was suppose to be a combination of, but it just looks like the avatar and a full render thrown on the right side. I have not tried the Head option just yet.


Chore: Remove unneeded code related to prepend option

Assuming #52312 stays in through 5.0, there's a decent amount of code we can remove from the emitter, specifically stuff introduced by #22420

This work item is "Once we remove support for the option entirely, then delete all the code for it"


[Bug]: enforceaccess resets to 'false'

/mv version -p output
https://pastebin.com/hqcmvzDp
Server logs
https://gist.github.com/mczero80/f37f26fbe195f961c166600509cded20
Server Version
This server is running CraftBukkit version
3836-Spigot-3374045-08ec344 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT)
Checking version, plrease wait...
You are 32 version(s) behind

Bug Description
When trying to activate permissions by setting enforceaccess: 'false' to enforceaccess: 'true', it resets to enforceaccess: 'false' after restarting the server.
LuckPerms is installed. No permissions where set prior, and LuckPerms was installed just now.
Steps to reproduce

Editing config.yml
Setting enforceaccess: 'false' to enforceaccess: 'true'
Restarting the server
Taking a look at config.yml

Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

This is standard behaviour. If the server is still running then you must turn it off, change the config value and start it again.

Ahh that makes sense. Thanks!


Fix: deployment related to recent changes

Fixes deployment related to recent PRs - https://github.com/umccr/elsa-data/pull/287 and https://github.com/umccr/elsa-data/pull/286

Looks good - sorry I forget this one came in


Include the HEAD commit id in the Java binaries

and print it on load

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Planning to merge in the afternoon


help text for radio-buttons

Description of the bug
Help-text for radio-buttons component appears in bold, but for other components appears normal .

Help-text for input-component:

Steps To Reproduce
add helptext for radio-component and input-component and run the program.
Additional Information
No response

Should be fixed together with #507


fix 'window is undefined' error in none browser environment

Coverage increased (+0.2%) to 82.5% when pulling 652c8a0b3156db5ea7b7806a5fcceb1f9b74d29b on flytreeleft:master into f4a8ac2b9e5bbea290d57ddbdf8830f10db5c9d3 on glenjamin:master.


Media Load Strategy

Tasks

[x] Complete #8.
[x] Complete #6.
[x] Complete #4.
[ ] Build MediaLoadStrategy interface.
[ ] Connect to Player and test it.
[ ] Build and test FirstCanPlayMediaLoadStrategy.

References

https://github.com/vidstack/player/blob/main/docs/architecture/architecture.md#media-load-strategy

Putting this in the backlog for now as it's thought through a little more. Going with a simple solution for now of using the first provider who can play the current source to load it immediately on change.


add an epoch number to the TotalRewardEvent event

Prior to #2615, the reward event included an epoch number. In #2615, we renamed the old reward event to TotalRewardEvent and created a new incremental reward event named DeltaRewardEvent. The event TotalRewardEvent does not currently, however, include an epoch number, though DeltaRewardEvent does. The PR add an epoch number to TotalRewardEvent.

the test that failed is the flaky gen Always shrink test. This is a test for the model-based testing generators, which is not critical and which we know is flaky and needs fixing.


execute 'delete_docker_registry_image --image imageName' ,nothing hint

I has executed 'delete_docker_registry_image --image imageName' ,but  nothing hint,
The image in folder ‘docker/registry/v2/repositories’ has been removed.
Is this success?

You are commenting on the lack of output? That is by design. You can make it more talkative with --verbose and of you can run it without it actually making any changes with --dry-run to see what will happen. Hope this helps.


Feature/internal id restructure

Added functions for dataset composition: zip, concat, cartesian product
Added a few more general dataset functions: take, repeat, reorder
Removed class_wise_ids
Added description functions: unique, counts
Added label encoding functions: label, one_hot

Closing pull request again, in favour of an updated one


microarray evidence

ECO now contains many evidence terms for "microarray evidence". On quick inspection, I can see:

ECO:0005524 - DNA microarray evidence (a molecule detection assay evidence)
ECO:0000104 - microarray RNA expression level evidence (an expression pattern evidence)
ECO:0000058 - expression microarray evidence (an expression pattern evidence), ECO:0000104 parent
ECO:0000093 - oligonucleotide microarray evidence (an expression pattern evidence), which appears to be devoted to protein-DNA binding arrays
ECO:0000097 - cDNA microarray evidence (an expression pattern evidence)
ECO:0000101 - Affymetrix array experiment evidence (an expression pattern evidence)
ECO:0000105 - Nimblegen array evidence
and the respective cross-products with "manual assertion".

I fail to see why this plurality is necessary. I can understand that Affymetrix and Nimblegen are specialized microarray types, and that protein-DNA binding is a different type of evidence from conventional DNA arrays. I don't see, however, how ECO:0005524, ECO:0000104 or ECO:0000097 should be distinct terms. As far as I know, all arrays are based on cDNA strands isolated on a surface, and exploit RNA hybridization (directly or after RT-PCR) on those probes for detection, with the canonical application being measurement of RNA expression levels.

Thank you for calling our attention to this @ivanerill - there are definitely issues in this node that need to be resolved. We will be working on this as soon as everyone is back from the holidays.

Perfect, let me know how I can contribute. Happy holidays!

The changes have been pushed to eco-edit.owl and will be live with our March release. Please let me know if you have any thoughts, otherwise we will close this issue. Thanks! 🙂

The changes look good to me. Thanks!
On Thu, Feb 8, 2018 at 9:17 AM, Rebecca Tauber<EMAIL_ADDRESS>wrote:

The changes have been pushed to eco-edit.owl and will be live with our
March release. Please let me know if you have any thoughts, otherwise we
will close this issue. Thanks! 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/evidenceontology/evidenceontology/issues/155#issuecomment-364124573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9lqdxiu1zfxl1KbCVePE5-j3Sg2wZoks5tSwIBgaJpZM4QNd-M
.


Create lung_cancer.ipynb

Closing this PR , push to dev branch and then raise a PR , not directly from personal account


[Serverless] Add enhanced error metric to invokationlifecycle package

What does this PR do?
Adds a call to SendErrorsEnhancedMetric() in the invocationlifecycle package.
Includes a new unit test.

Motivation
.NET support via the proxy and universal instrumentation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Run the appropriate unit test

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The appropriate team/.. label has been applied, if known.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

If and only if we are using the proxy, we want to filter out the errors metric generated by the Lambda Library to prevent duplicate error metrics.
Example:

Customer is using both extension (with proxy) and Lambda Library
There is an error in the function
Library sends error metric
Extension sends error metric
Oops, now we sent two error metrics

If and only if we are using the proxy, we want to filter out the errors metric generated by the Lambda Library to prevent duplicate error metrics.
Example:

Customer is using both extension (with proxy) and Lambda Library
There is an error in the function
Library sends error metric
Extension sends error metric
Oops, now we sent two error metrics

If the extension filters out the error metric that was created by the library, then this issue goes away.

+1, the logic to blocklist a metric is already implemented, for instance : https://github.com/DataDog/datadog-agent/blob/main/pkg/serverless/metrics/metric.go#L124

I would also add an integration test to cover this (csharp-error I suppose) but you could do that in another PR.


Log when Head compaction results in an empty block

We already do it when compacting multiple blocks
https://github.com/prometheus/prometheus/blob/3240cf83f08e448e0b96a4a1f96c0e8b2d51cf61/tsdb/compact.go#L433-L438
Compaction of Head block resulting in an empty blocks goes unnoticed currently. We should log that too.
For contributors, the log should go just before this return
https://github.com/prometheus/prometheus/blob/3240cf83f08e448e0b96a4a1f96c0e8b2d51cf61/tsdb/compact.go#L491
And the log should include the mint and maxt of the compaction attempted.

Might this result in even more logspam when a Prometheus that hasn't run in a while is started back up?

can i take this?

Might this result in even more logspam when a Prometheus that hasn't run in a while is started back up?

Yes, but it is better than no logs. Faced this first hand, without the logs we were not able to figure out what was happening and why was checkpointing happening so often with no indication of any compaction.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Aditya M
Discord Username (if applicable)
aditya_m_06
Additional Context
I’d love to join Recode Hive because it feels like such a welcoming and inclusive community, especially for someone like me who’s passionate about data science. I really like how open it is, encouraging people to jump in, share ideas, and learn together. The focus on open-source collaboration and helping each other grow is exactly what I’m looking for. Plus, being able to improve my GitHub profile and get involved in meaningful projects with other like-minded people is a huge bonus. It seems like a great place to develop my skills and connect with others who are just as enthusiastic about data science and open-source as I am.

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


LOCATION specification of the region/area

The sentences: [...] war refugees from Russia, people repatriated from Suvalkų area and Pakruojis local rural district, local residents who have[...] contains two additional information near the two LOCATION mentions. Should we expand the entitiy and add this specificity or just locate the two main entities?
like:
from	O
Suvalkų	B-LOCATION
area	LOCATION

and
Pakruojis	B-LOCATION
local	LOCATION
rural	LOCATION
district	LOCATION

Good question!
I would include indeed the modifiers that qualify the location, but not the articles and prepositions.

Just to confirm for a sentence :
The <ENAMEX type="LOCATION">U.S.</ENAMEX> eventually establishes safe zones
west of the <ENAMEX type="LOCATION">Rocky Mountains</ENAMEX> and spends much of the next
<ENAMEX type="PERIOD">decade</ENAMEX> eradicating zombies in that region.</sentence>

We just annotate the rocky mountains as location without "west of" right ?

Oui... except if it is explicitly  part of the proper name like West Mountain.

What about things like Northern Canada or Coast of Honolulu?

Same as West Montain for me, it's frozen names to relatively specific places I think (they have capital letters! its a sign!).

Yes, moreover Northern Canada is a well idenfied region by itself, see here.

We found the entity Eurozone:

Eurozone laws would not necessarily apply to non-Eurozone EU members and the latter would not have to bail out troubled

Do you think it's a LOCATION?

I would say not, because we are talking about the status of being part of the Eurozone (a contract between country having the same currency). Mentioned here.

discussion about this in issue #12


README lacks author

Hello.
The README does not list the author. Without the author, I don't know who to complain to when I have trouble comprehending the README.

Oh wait, I am the author myself


Update gitignore

@andrewvanbeek-okta Please remove terraform.tfstate and terraform.tfstate.backup.  Its demo/example but the terraform.ftstate contains sensitive information.
My .gitignore should prevent git commits in the future but you got to remove it from git history.

Merge my PR to master.
Follow this. Optional here.

thanks dude!


Replace FakeView url helpers in models

#3264
First step in removing FakeView.

Creates UrlHelper which handles delegating to Rails.application.routes.url_helpers in a single purpose class.

This should be a large portion, if not the majority, of FakeView usages.

The next big step will be allow calls to these from outside of the view context:

image_url
uri_join

Also need to address :

Calls to render
Calls to ActionView::Helpers
DarwinCore (not too familiar with what this is yet)

This looks good to me too for the cases covered so far, with a cleaner helper model.
One minor style suggestion - there are a few cases of method calls without parenthesis (e.g. UrlHelper.instance.respond_to? method, include_private , UrlHelper.guide_taxon_url guide_taxon_id, UrlHelper.icon_preview_list_url list_id, locale: I18n.locale, and a couple expire_listed_taxon lt). While we don't have a rubocop rule for it (nor do we actively use rubocop), we tend to add parenthesis for most method calls when there are arguments, though there are exceptions (e.g. puts, and a lot of spec methods).
Thanks for the contribution!


Ulimit check doesn't appear to work

vagrant@devel:~$ ulimit -Sn
65535
vagrant@devel:~$ ulimit -Hn
65535

command:
  ulimitHard:
    exit-status: 0
    exec: "ulimit -Hn"
    stdout:
      - 65535

  ulimitSoft:
    exit-status: 0
    exec: "ulimit -Sn"
    stdout:
      - 65535

Expected result: passes
Result:
Command: ulimitSoft: ulimit -Sn: stdout: patterns not found: [65535]
Command: ulimitHard: ulimit -Hn: stdout: patterns not found: [65535]
Note: I have also tried wrapping it as a string instead of an integer.

I haven't been able to figure out if this is an issue with goss or how ulimit reports to stdout

What does goss add command 'ulimit -Sn' say?

vagrant@devel:~$ goss add command 'ulimit -Hn'
Adding Command to './goss.yaml':

ulimit -Hn:
  exit-status: 0
  stdout:
  - "65535"
  stderr: []
  timeout: 10000

vagrant@devel:~$ goss add command 'ulimit -Sn'
Adding Command to './goss.yaml':

ulimit -Sn:
  exit-status: 0
  stdout:
  - "65535"
  stderr: []
  timeout: 10000

Interesting it is in a different format from the documentation.
vagrant@devel:~$ goss validate
......

Total Duration: 0.006s
Count: 6, Failed: 0, Skipped: 0

Try the original with quotes around the number. Sorry, I'm not on a computer to test it currently.
command:
  ulimitHard:
    exit-status: 0
    exec: "ulimit -Hn"
    stdout:
      - "65535"

I had done quotes around the number originally as well and had the same behavior.

However part of this problem appears to be in the ansible wrapper project I"m using which I've opened an issue against there.
I'll try to test the original again with raw goss in a few.

I'm not able to reproduce this locally:
command:
  ulimit -Hn:
    exit-status: 0
    stdout:
    - "4096"
    stderr: []
    timeout: 10000
  ulimit-check:
    exec: "ulimit -Hn"
    exit-status: 0
    stdout:
    - "4096"
    stderr: []
    timeout: 10000

This goss file tests both cases and they both pass for me. Are you still having this issue?

Closing this since I wasn't able to reproduce. Feel free to reopen if you're able to reproduce the issue.


Missing #[] in BitArray

I originally posed this on the crystal google groups forum and it was suggested I raise this as an issue.
https://groups.google.com/forum/#!topic/crystal-lang/Iiqgrgvca8M

In trying to use bit arrays (0.20.5) I've noticed a number of bugs and inconsistencies
in expected behavior compared to regular arrays which use the same methods.
a = BitArray.new(10) --> [false, false, false, false, false, false, false, false, false, false]

a[0]= true  --> [true, false, false, false, false, false, false, false, false, false]

b = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

b.first(5) -->  [0, 1, 2, 3, 4]

a.first(5) --> [true, false, false, false, false]

b.last(5) --> [5, 6, 7, 8, 9]

a.last(5) -->  Error in sozcore2test.cr:107: wrong number of arguments for 'BitArray#last' (given 1, expected 0)
Overloads are:
 - Indexable(T)#last()
 - Indexable(T)#last(&block)

Then there are indexing issues using bit arrays.
b[5..-1] --> [5, 6, 7, 8, 9]

a[5..-1] --> Error in sozcore2test.cr:109: no overload matches 'BitArray#[]' with type Range(Int32, Int32)
Overloads are:
 - Indexable(T)#[](index : Int)

According to BitArray API,  https://crystal-lang.org/api/0.20.5/BitArray.html
these are inherited from the appropriate modules that work with Arrays.
Are these problems with BitArrays just a consequence of the current age of the language, and planned
to be fixed, or are these the intended different behavior compared to other Arrays?

They definitely look like bugs :).

From wikipedia:

A bit array (also known as bitmap, bitset, bit string, or bit vector) is an array data structure that compactly stores bits. It can be used to implement a simple set data structure.

That is, the use case of a bit array is to count things, to know if a given object is inside a set. For that, you consider each position in the bit array to be a different object of interest. For example the compiler uses this to determine if all types are covered by method overloads.
With this in mind, you normally don't want to get a piece of a bit array. You don't use it like an array. In Java there's no such functionality. Neither in C#. It's not that this was overlooked, it's just that the use case of a BitArray is not that of an Array.
That said, we could implement #[]. The question is whether this allocates new memory for the data or it still points to the old one.
@jzakiya It would be interesting to know what's your use case here and why you need this slicing functionality.

I also changed the title: there's no bug or inconsistency here, we are just missing an #[] method.
(with what I said above, maybe even BitArray shouldn't be Enumerable at all)

I think you need to see and appreciate this issue from the perspective of a user.
First, you can not restrict the use of any resource that is provided to just what you think it will/should be used for.  If you create it people will try to use if for things you might have never considered.
A BitArray is presented as an array, which is a collection, which according to it's own documentation inherits a host of methods from other modules, including Enumerables.  If so, it should work with them.
It's not logical that you can do:   bitary.first(5)  but not  bitary.last(5).
I do a lot of numerical heavy applications.  I use arrays to represents data that is boolean in nature, i.e, 1|0, true|false.  I can significantly reduce memory usage by using BitArrays, over arrays of Ints, where I'm more concerned with memory reduction versus speed.
From a user's perspective, or at least MY USER PERSPECTIVE, it is a bug, and certainly inconsistent, to not be able to manipulate a BitArray like an Array, especially when the documentation states they inherit methods from the same modules.  Either create accurate documentation to explain how the resource actually behaves or make the resource behavior match its documentation.

That's interesting, maybe we could rename BitArray to Bitmap to avoid these kinds of false expectations. I the name could be misleading if the user doesn't know the context discussed here and in https://en.wikipedia.org/wiki/Bit_array.
So why don't we just:

Rename the class to Bitmap.
Add a reference in the docs to the Wikipedia article. Maybe even include some of the insights provided by @asterite in the class documentation for the benefit of future users.
Stop including Indexable, unless we provide sound implementations for all methods in that module.

If we can implement the full array interface, is there any reason why not?

Bitmap can be confusing too (images). I think I'd choose BitSet instead, and/or document how specific it is (i.e. not to be considered an Array).

#codetriage
This appears to have turned into a feature, as we don't have the #[] in BitArray.
At the top of src/bit_array.cr, we can see:

BitArray includes all the methods in Enumerable

So this either is a documentation issue, where we change Enumerable to Indexable, or ensure that BitArray should indeed include all Enumerable methods.

@miketheman #[] methods aren't defined on Enumerable.

FWIW I personally think that BitSet would be a great name...


Fix bad handling of error cases in Check path.

This change is

if this fixes the test can you remove the skip?

This is completely unrelated to the E2E test failure.

Jenkins job mixer/presubmit passed

Jenkins job mixer/pilot-regression passed

Jenkins job mixer/e2e-smoketest passed


[ci] Cleanup tox config for env matrix

Improve the env matrix using py prefix

Coverage increased (+0.5%) to 71.64% when pulling a30572d0765b81e83ad42fe1bfa8b67ef86d33c0 on Djailla:py-travis into edd461630d1b4708e8ba3ecdc9c9e107e14fbfdb on django-extensions:master.


I get the error invariant violation View config not found

invariant vioation View config not found for name input make sure componenet names with capital letter

Can you provide a test repo for this? Cuz I cannot reproduce it.

Are u using this in a react-native project?
I don't think this works for react-native since it gots lots of html element inside.

this is not on react native project?

Please provide a repo for this then, I need to test it out.

this is not on react native project?

Nope, this is for web only.


[Recruiter Form] Show Recruiters Data

We have a feature implemented on Members which allows the Hiring Managers to get the introduction of our members.
Currently, we are only storing that data in the backend DB and not doing anything apart from that.
We need to show that data on the dashboard site so that way we can check it out and get a warm intro to the hiring manager or the recruiter
Endpoint which we call to submit hiring managers introduction request

[
{
"company": "ipsum in irure",
"first_name": "nisi cupidatat dolore esse",
"last_name": "adipisicing q",
"designation": "et proident",
"reason": "magna eiusmod",
"email": "pariatur veniam",
"currency": "magna amet",
"package": 26133037.726852447
},
]
Expecting response from the endpoint
Lets create design based the mock response

I'm interested in this issue.

API Contract for object and Data we are Receiving :
https://github.com/Real-Dev-Squad/website-api-contracts/tree/main/members


Auto creates vertex or edge label on agload

Changes made in order to reduce redundancy on calling load_edges_from_file and load_labels_from_file, so calling create_vlabel and create_elabel before loading a csv file is not needed anymore.
Updated regression tests.
BEFORE:
SELECT create_vlabel('agload_test_graph','City');
NOTICE:  VLabel "City" has been created
 create_vlabel
---------------

(1 row)

SELECT load_labels_from_file('agload_test_graph', 'City',
    'age_load/cities.csv');
 load_labels_from_file
-----------------------

(1 row)

SELECT create_elabel('agload_test_graph','has_city');
NOTICE:  ELabel "has_city" has been created
 create_elabel
---------------

(1 row)

SELECT load_edges_from_file('agload_test_graph', 'has_city',
     'age_load/edges.csv');
 load_edges_from_file
----------------------

(1 row)

AFTER:
SELECT load_labels_from_file('agload_test_graph', 'City',
    'age_load/cities.csv');
NOTICE:  VLabel "City" has been created
 load_labels_from_file
-----------------------

(1 row)

SELECT load_edges_from_file('agload_test_graph', 'has_city',
     'age_load/edges.csv');
NOTICE:  ELabel "has_city" has been created
 load_edges_from_file
----------------------

(1 row)

Should we check if the label already exists before making the DirectFunctionCall? And, add tests for this case?

Sure thing, I'll do it now.

I have added a second load on the same file for the tests, so it will add vertexes and edges twice on the same labels, and it won't throw an error message.
Please let me know if this is alright.

@markgomer
Looks good to me.
One thing that concerns me is that the agload test is taking way longer than other tests since it is now loading the csv files many times. So, I looked at the tests you added to see if we can remove some of them. For the sake of speeding the test, otherwise they were fine.
Should we remove these two groups of tests?

Tests without creating labels first, without id field
TEST DOUBLE LOAD files

My justification is- the changes you made does not affect the algorithm of 'without id field' and 'double load' directly. So it may be okay to not tests these functionalities at least in this PR. You are changes are tested by the first group of tests you added, where you check if the label was actually created and the number of rows in the labels using the COUNT function.

@rafsun42 I removed the tests you mentioned and the white spaces.
So for this PR, only the "Tests without creating labels first, with id field" are added.

@markgomer @rafsun42 Is there any specific reason this patch was not merged?

Hello @MuhammadTahaNaveed, I'll work on resolving the conflicts that appeared after the updates soon. I'm not sure why it wasn't merged though.

@markgomer Just checking if there is an update,...

@jrgemignani I'm running into some problems, the tests are failing after rebasing. I may have missed something along the way.
I am using PostgreSQL 16beta2 with Apache AGE master branch, does this work or should I install another version?

@markgomer I build with 16.2 against the master without issue. The PR is complaining about -

Maybe there are some Github merge conflict markers (>>>>>>>, <<<<<<<) in the file?


Use vmware_desktop in the Vagrant image metadata

Using vmware_desktop instead of wmware_fusion allows us to target both
VMware Workstation and VMware Fusion with the same Vagrant image.
Fix for issue #390.

@lpancescu - Per our chat earlier today, can you (or anyone else who is interested in this) please try the following Atlas hosted image on both VMWare Fusion and/or VMWare Workstation:
https://atlas.hashicorp.com/bluefedora/boxes/c7desktest
I can confirm that it works for me on VMWare Fusion with Vagrant 1.8.6 and the Fusion plugin.  Would appreciate a confirmation from someone attempting to run this on VMWare workstation.

Can confirm, this works with just vagrant init bluefedora/c7desktest; vagrant up without specifying/prompting for provider now.
Tested on Fusion with Vagrant 1.8.7 and Workstation with 1.8.6.
Thanks!

OK.  With confirmation that it works for both platforms... LGTM.


chore: bdd-nh-1587386835 to 0.0.1

chore: Promote bdd-nh-1587386835 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Carry #22228 : Rename graph drivers to storage drivers

Carry PR #22228 🐸.
Resolving conflicts wasn't easy, let's see if my missed something or not :angel:
Closes #22228

- What I did
I've renamed the occurrences of GraphDriver by StorageDriver in the code base to be more consistent with the docs.
The only externally-visible change of that PR is a direct API translation of the experimental storage driver plugins API
- How I did it
I've renamed things via grep/replace but I tried to do that carefully, so variable names and comments are also kept consistent.
- How to verify it
I've run make and make test and it seems to work. I need to update https://github.com/docker/go-plugins-helpers/pull/42 to use the new StorageDriver naming scheme, I'll do that once/if that PR is merged.
I've tried to run the integration tests for the CLI. The experimental storage driver plugins seem broken (see below).
- A picture of a cute animal (not mandatory but encouraged)

Already LGTM from @tiborvass (see original PR)
/cc @thaJeztah @runcom @justincormack

Looks like we're running into the same failure again on WindowsTP5, so wondering if there is a relation to this change;
14:43:46 ---> Making bundle: .ensure-frozen-images-windows (in bundles/1.12.0-dev/test-integration-cli)
14:43:46 ERROR: Could not find windowsservercore images

@jhowardmsft any ideas? I already started looking into vendored code, e.g. https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/vendor/src/github.com/Microsoft/hcsshim/layerutils.go#L14-L23, but couldn't find anything really

@thaJeztah The only thing I can spot is the go-winio aliasing. Everything appears fine.

@jhowardmsft thanks for looking. I was wondering if somehow, somewhere something relied on a name. Just weird. Let me just try to run it again, maybe we've just been very unlucky

Hum windowsTP5 is definitely not happy :sweat_smile:

Went back to look at this failure after redeploying a bunch of TP5 nodes this evening. Unfortunately it now needs a rebase :cry:

@jhowardmsft rebased :angel:


Almost Sonoff devices has been getting error when click to turn On/Off

Most of Sonoff devices getting this error. I am using cloud mode.
I also downgrade to lower version but get the same (2.4.3).
My Hass is core-2021.8.8 and supervisor-2021.06.8

I've change to local mode, the error changed to "timeout".

Convert all to Tasmota :)
Thank you AlexxIT

Oh. It's best to use auto mode. Works fine local+cloud


secret variables stored in plain text in production.log

I recognized that the log entry created when saving a secret variable contains the full variable value in plain text in the Parameters: info, is this intended? Shouldn't the value be [FILTERED] like the authenticity_token is in the log?

This will get fixed in 8.3 release.

was this fixed in 8.3?


IterableDataReader: before slice after sort - Is this a good order?

What steps will reproduce the problem?
Currently, it organizes the current page, not the whole items.
https://github.com/yiisoft/data/blob/370d91731799fc222a2edce088571a2c2b636b44/src/Reader/IterableDataReader.php#L138-L158
What is the expected result?
sort after slice
What do you get instead?
slice after sort
Additional info

Q
A

Version
1.0.0 under development

PHP version
-

Operating system
-

You're right. That's wrong order and it seems we have not enough tests.


Fix for #2838 - Update to ForwardingHandler and Request to propagate Context to MediaSupport

~JacksonBodyReader#read now propagates the current Context~

The earlyOutFuture is there because I didn't dare refactoring channelRead0 and cut it into chunks. I bet you had done a lot of tuning there and I don't want to affect it too much. The runInContext in case of handling a HttpRequest is also certainly too greedy in it's span, but there I didn't know what different sorts of dispatches you have. So, I've covered everything after the reset

Done with https://github.com/oracle/helidon/pull/2898


style&test: remove unnecessary code and add test(#2450)

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues #2446

Bug fix

Bug description.
unit test not covered when AMQP.BasicProperties had null headers or headers Map had null value keys
How to fix?
add test

Coverage increased (+0.0004%) to 15.414% when pulling 9dcfe3d8e8a83713515a3e87c304127e0fd12c0c on ksewen:optimizeRabbitMqNPEFix into ea566b19a501b44c29ca4083c28c560160ad86cf on apache:master.

Welcome to contribute for the first time.


Extracted local classes to global classes

because of issue #19 I extracted the local classes and made them globally.
Only the classes lcl_cute_main and lcl_cute_table are left local. In my opinion they are directly related to this one report and it would be hard to use them otherwise. ( maybe the class lcl_cute_table can also be made globally - but the main class should stay local )
What do you think?
If it is okay, that the 2 classes stay local this PR can be merged ( from my side ^^ )

No, it's not!! 😸
I extracted lcl_cute_table to ZCL_CUTE_TABLE_EDIT as this is the main edit class. There will be this one for TABL and there should be another one for VIEW. I am not sure if this wise but we will see.


Problem: We don't have an interpreter for composite valueobject ASTs

Sub problem of issue #85
Solution: Write an interpreter for composite valueobjects
SuccessCriteria: Can create a composite VO from others VOs, fails if you give it the wrong VO types.

Forgot to link to the AST issue, it's #84.

Working solution, tests are passing. Closing issue.


Export styled dataframe to png not working with matplotlib

Hello,
I have run the following example code to export a dataframe to a png, using the "matplotlib" table converter.
import dataframe_image as dfi
import pandas as pd
import numpy as np

df = pd.DataFrame(np.random.rand(6, 4))
df_styled = df.style.background_gradient()
dfi.export(df_styled, 'df_styled.png', table_conversion='matplotlib')

The image is exported without errors (only a warning about the helvetica font not being found). However, when opening the image afterwards, the style of the dataframe has disappeared and a simple dataframe without colors is displayed.
On the other hand, when using "chrome" as a table converter, the dataframe is correctly exported with its style.
Sadly, in the environement in which I am working, chrome is not available and I can't install it there, so this is not an option.
Is this the "expected" behavior when using matplotlib, or should it work like with chrome, i.e. export dataframe colors too?

+1

+1

Same behaviour here : I do apply a custom style to make some cells bold, but this does not render in the png

have same case here. have you got any solution to it?

@tdpetrou HI sorry to trouble you. Have you got the porblem same with us .
Export styled dataframe to png not working with matplotlib

+1

Same problem here. Using the library on Google Colab, with the Matplotlib convertre all formatting is lost.

Same

Same issue here as well. Working on a data notebook platform and only the un-styled matplotlib converter working.

+1

Im having the same problem as well

+1

I'll diagnose it later, but it seems a limitation of matplotlib.

Hi guys, Any updates for the export styled data frame using matplotlib table conversion?

Hi @PaleNeutron - any update on that ?

Run into this problem as well

Deploying a styled dataframe object using chrome table converter does not work here; produces an image, but only a thin strip of what looks like the very top of the expected image.  Deploying the matplotlib table converter does produce an image, but has similar issues to those described above; specifically colour stying disappears.

Supported now!

Nice! Thanks a lot. Is it released?

@paulhybryant Already released.

Thanks!


[10.x] Remove unnecessary transaction in Bus::batch causing issues with sync driver

When using the sync queue driver together with the Bus::batch command, if there are any exceptions triggered inside a Job, the whole transaction gets rolled back, including any queries that were executed inside any of the previous jobs.
This make it impossible to use the sync driver with the Bus::batch command, since it causes unexpected rollbacks.
I believe the transaction was added for the use case of database queue driver, however I find it unnecessary to be using a transaction even for that case.

Can't just remove code with no tests. If there is a bug let's fix the bug not just delete code.

@taylorotwell the bug is having the unnecessary transaction, that's why I removed it. The framework should be be adding a global transaction to all of my jobs.
What is the purpose of it? Is it to deal with some unforeseen bug within the framework, such as if the bulk insert would fail for some reason?
The transaction is causing the sync driver to rollback any DB changes inside Jobs if one job fails.


Question on that the program is hung up and result in no learned model

Hello, everyone. I am newcomer in the field of Automata Learning.
When I run my program. I find my program is hung up, I got 29 hypothesis but no learned model. Actually the 29 hypothesis are the same.
There is the result of my program and I had forced stop it.
This is the stopped program.

This is the result.

This is the log of Learner.

Following is my main code, and I used L* algorithm and wmethod algorithm.
LearnLogger log = LearnLogger.getLogger(MQTTLearner.class.getSimpleName());
		log.info( "Using learning algorithm " + learningAlgorithm.getClass().getSimpleName());
		log.info("Using equivalence algorithm " + equivalenceAlgorithm.getClass().getSimpleName());
		log.info("Start Learning");

		SimpleProfiler.start("Total time");

		boolean learning = true;
		Counter round = new Counter("Round","");
		round.increment();
		log.logPhase("Starting round" + round.getCount());
		SimpleProfiler.start("Learning");
		learningAlgorithm.startLearning();
		SimpleProfiler.stop("Learning");

		MealyMachine<?, String, ?, String> hypothesis = learningAlgorithm.getHypothesisModel();

		while(learning) {
			//保存输出的内容
			writeDotModel(hypothesis, alphabet, config.output_dir + "/hypothesis_" + round.getCount() + ".dot");

			//查找是否有反例
			SimpleProfiler.start("Searching for counter-example");
			DefaultQuery<String, Word<String>> counterExample = equivalenceAlgorithm.findCounterExample(hypothesis, alphabet);
			SimpleProfiler.start("Searching for counter-example");

			if(counterExample == null) {
				//没有找到反例，停止学习
				learning = false;
				//输出
				writeDotModel(hypothesis, alphabet, config.output_dir + "/learnedModel.dot");
				//writeAutModel(hypothesis, alphabet, config.output_dir + "/learnedModel.aut");
			}else {
				//找到反例，更新假设并且继续学习
				log.logCounterexample("Counter-example found" + counterExample.toString());
				round.increment();
				log.logPhase("Starting round " + round.getCount());

				SimpleProfiler.start("Learning");
				learningAlgorithm.refineHypothesis(counterExample);
				SimpleProfiler.stop("Learning");

				hypothesis = learningAlgorithm.getHypothesisModel();
			}
		}

		SimpleProfiler.stop("Total time");
		// Output statistics
		log.info( "-------------------------------------------------------");
		log.info( SimpleProfiler.getResults());
		log.info( round.getSummary());
		log.info(statesMemOracle.getStatisticalData().getSummary());
		log.info( statesCachedMemOracle.getStatisticalData().getSummary());
		log.info(statesEqOracle.getStatisticalData().getSummary());
		log.info(statesCachedEqOracle.getStatisticalData().getSummary());
		log.info( "States in final hypothesis: " + hypothesis.size());

I would be greatly thankful if anybody would to offer some suggestions.
Thanks！

Two things seem off here:

Your console output shows that there was an exception thrown when answering membership queries. Is this just logging output or could this potentially influence how queries are answered? In your SUL implementation you need to make sure, that queries are answered deterministically.

It seems you repeatedly received the same counterexample which shouldn't happen for the L* algorithm. Just to be sure: The response is CONNACK SUBACKcommand///req/# CONNACKFail CONNACKFail? So the four letter input word is correctly answered by a four letter output word?

I assume, there might be something wrong with your SUL implementation, i.e. queries to your SUL are answered nondeterministically depending on whether the connection to the MqttClient could be established or not. Most learners compare their current hypothesis output with the given counterexample to decide if the hypothesis needs refinement. So it could happen that a counterexample found by the equivalence oracle is not recognized by the learner because it is answererd differently when posed by the learner.
You could add an if statement around the call to learningAlgorithm.refineHypothesis(counterExample) (returns a boolean) to see if the counterexample actually refines the hypothesis and throw an exeception otherwise. This should give you the first instance where things go wrong and from there you can continue to debug.

Thanks a lot! I will try this as you suggested.

Thanks a lot! I will try this as you suggested.


kTfLiteNullBufferHandle must be macro

tensorflow/lite/c/c_api_internal.h have constant variable kTfLiteNullBufferHandle (not macro or static const). So we can't include this header file in several codes.

I think there are current many .cc files including the c_api_internal.h. What's the specific error your encounter?

a.c
#include <tensorflow/lite/experimental/c/c_api.h>

extern void foo();

int
main() {
  foo();
}

b.c
#include <tensorflow/lite/experimental/c/c_api.h>

void
foo() {
}

$ gcc -I/path/to/tensorflow/lite//experimental/c -c a.c
$ gcc -I/path/to/tensorflow/lite//experimental/c -c b.c
$ gcc -o tmp.exe a.o b.o
b.o:b.c:(.rdata+0x0): multiple definition of `kTfLiteNullBufferHandle'
a.o:a.c:(.rdata+0x0): first defined here

oops. sorry. will fix

@haosdent Thanks your review. I hope to add one more fix.
tensorflow/lite/c/c_api_internal.h:53:44: warning: 'struct TfLiteContext' declared inside parameter lis
t will not be visible outside of this definition or declaration
 typedef TfLiteStatus (*refreshFunc)(struct TfLiteContext* context);

diff --git a/tensorflow/lite/c/c_api_internal.h b/tensorflow/lite/c/c_api_internal.h
index 80d99d92e9..5939607d3c 100644
--- a/tensorflow/lite/c/c_api_internal.h
+++ b/tensorflow/lite/c/c_api_internal.h
@@ -50,6 +50,8 @@ typedef enum {
   kTfLiteMaxExternalContexts = 3
 } TfLiteExternalContextType;

+struct TfLiteContext;
+
 // An external context is a collection of information unrelated to the TF Lite
 // framework, but useful to a subset of the ops. TF Lite knows very little
 // about about the actual contexts, but it keeps a list of them, and is able to

Should be better to separate PR? or Can i include the patch into this PR?

@haosdent Thanks your review. I hope to add one more fix.
tensorflow/tensorflow/tensorflow/lite/c/c_api_internal.h:60:34: warning: 'struct TfLiteContext' declared inside parameter lis
t will not be visible outside of this definition or declaration
   TfLiteStatus (*Refresh)(struct TfLiteContext* context);

diff --git a/tensorflow/lite/c/c_api_internal.h b/tensorflow/lite/c/c_api_internal.h
index 80d99d92e9..5939607d3c 100644
--- a/tensorflow/lite/c/c_api_internal.h
+++ b/tensorflow/lite/c/c_api_internal.h
@@ -50,6 +50,8 @@ typedef enum {
   kTfLiteMaxExternalContexts = 3
 } TfLiteExternalContextType;

+struct TfLiteContext;
+
 // An external context is a collection of information unrelated to the TF Lite
 // framework, but useful to a subset of the ops. TF Lite knows very little
 // about about the actual contexts, but it keeps a list of them, and is able to

Should be better to separate PR? or Can i include the patch into this PR?

Thanks for catching this! You can just make that change in this PR I think.

Just  an update:
We decide to use enum to define the kTfLiteNullBufferHandle, not Macro. I will make this change internally and hold back this PR. Thanks!

Issue of struct TfLiteContext still not fixed?

Issue of struct TfLiteContext still not fixed?

I have fixed it yesterday. Only thing different from your change is that I used enum to declare the kTfLiteNullBufferHandle rather than Macro. Please see it here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/c/c_api_internal.h

Thank you.


add interactive hinting/linting

I would like to have hinting and linting while you type, with inline highlighting and comments.
Here is a plugin which has some of these features: https://github.com/MiguelCastillo/Brackets-InteractiveLinter
If it was build in to brackets, all hinting/linting libraries could make use of this system.
Prerequisites: live evaluation of files (now only happens when saving a file).

@intergalactic-overlords There is already a trello card for this.  Out of curiosity, is there a particular why the extension isn't sufficient?

Closing since we already have this suggestion tracked on our feature backlog: "Live" real-time linting as you type.  @intergalactic-overlords: please upvote that to indicate your interest and help raise its priority.
@MiguelCastillo: I think it does make sense to have this capability built in eventually, so that all linting providers get the same benefit and Brackets is able to manage the performance characteristics more centrally.  That's why we have the card still open.

@peterflynn Yeah it makes sense to have it in brackets. I was just wondering if there is particular functionality that the extension is lacking.

@MiguelCastillo, there is no (straightforward) way to make the extension work with other hinting/linting libraries. (otherwise, excellent extension ;-) )


Allow svd files to be read from stdin

This change allows the input data to be provided via stdin when no input file is specified.

Looks good to me
bors r+

Build is failing due to recent changes in nightly merging manually


Questions about some choices

I am reading the code, but have questions about some function choices, hoping that you can help me with.

Why archive_read_open instead of archive_read_open_filename? The second one seems much easier, and it handles the file reading and seeking for you. It simplifies the code as you don't need to create SeekableReadPipe etc.
Is there some reason on setting the value READER_BUFFER_SIZE to 16384? Or it is just some radom value that works great?

Thanks for your time

The choice of archive_read_open_filename was made as we work on buffers and anything that provides a Read trait. We don't operate on files exclusively.
The buffer size has been chosen as smaller possible, which supports all use cases we test. We need to use a small buffer as we also use the crate in embedded Linux devices, so we need to be conservative in memory use.

That makes sense. Thanks for the explanation!


How to use getConfig?

Hi. I want to only execute getConfig and get its results. I don't want to getting involved to other processes as much as possible. Can you guide me? Much appreciated.

getConfig? What do you mean?

https://core.telegram.org/method/help.getConfig

It is just a single api method, you can execute it using doRpcCall* methods

It is just a single api method, you can execute it using doRpcCall* methods

Thanks a lot 👍


Installation on magento <IP_ADDRESS> - FPC issues ?

Hey Queue it team,
We are planning to install this module on magento version EE <IP_ADDRESS>.
I noticed the readme states that there could be issues when using this module along with FPC. And, as you know <IP_ADDRESS> provides full page caching OOB.
Can you share what some of these problems are ?

Hi,
If FPC is enabled then server code of cached pages would not be called for each request (serving page from cache) so users won't be redirected to queue.
To solve the problem you need to exclude the static page URLs from the queue setup and add a javascript file from Queue-it in your static pages to be able to queue users on ajax calls and not page requests.
Please contact<EMAIL_ADDRESS>we can arrange a call and go through your custom scenario.

Thanks


YARD::Handlers::Ruby::DSLHandler: Undocumentable method

Context
When I use yard-contracts I get warnings for the first method in a file that is documented with contracts. An example is the following error message:
[warn]: in YARD::Handlers::Ruby::DSLHandler: Undocumentable method, missing name
[warn]: 	in file 'lib/sts/states/instantiated_state.rb':92:
	92: Contract InstantiatedState => Bool
Is this normal or am I doing something wrong here?

I haven't seen that before but I suspect it's something to do with the way yard-contracts hooks into yard. The yard hooks aren't perfectly suited for this so it's a bit hacky. Did you say "file" as in methods at the top level? Because I've only tried yard-contracts with classes. It certainly should work so is a bug I expect.

With file I mean the file with the class code. I only document methods in classes at the moment.
btw I have a little experience with yard and rspec plugins. Maybe with some help from you I can fix it. I will try to make a small reproducible test/spec.

Ok you're using it like I am, hmm. I suspect it's to do with the juggling it does to match the Contract call with the next method definition. The relevant file is here and that's the line that I think isn't finding your method https://github.com/sfcgeorge/yard-contracts/blob/master/lib/yard-contracts/contract_handler.rb#L34
That was the easiest way I could find of doing it but there are flaws. E.g. it looks for a def statement so dynamic method definitions won't work. I think it's also confused by the class << self syntax. So if you can find a better way that fixes any of these it would be much appreciated. YARD is tricky.

With Ruby3 we're moving away from contracts.

With Ruby3 we're moving away from contracts.


Bug on IOS for tagging

Version used : 4.0.6 rc1
It appears only on IOS.
When using the tagging support, after 2 characters typed, the native iOS select element is opened.
We can only enter 2 characters keywords.

The bug is reproductible by loading this page on iPad :
https://select2.org/tagging
This bug may be related to #5240

Why this one was closed if it is still a bug? Is there any chance to see it fixed?


Allow control of data trimming for addColumn() and addRow()

When processing the list of data passed to addRow(), each value is trimmed. In most cases this is probably desirable, and it also allows whitespace to be used for visual formatting when generating the list of data in code, e.g.
`addRow( workbook, "
   This is line one
   |This is line two
   |This is line three
   |This is line four
   |This is line five
" );

But the data passed to addColumn() is not trimmed, which is inconsistent.
To address both issues, add a new boolean trimValues attribute to both methods set to true by default.

Actually, all values do seem to be trimmed as part of being added, including with addColumn(). Let's leave it like that.


[BEAM-11648] Resubmit Storage API sink with broken test removed.

The test was broken and didn't test anything. A better test would be to modify BigQueryTornadoes to test this path, but we will do this in a different PR (first we need to ensure that the testing project is whitelisted by BigQuery).

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

run dataflow streaming validatesrunner

Wasn't the removed broken test an integration test for the feature? How will we test the feature in an ongoing basis for integration?


Missing requirements/imports

Hi, thank you for the great paper and sharing your code.
Sorry I don't have time to make a small PR, but there are a couple requirements and imports missing that you'll notice if you try to run the train_attribute_and_evaluate notebook. If create your environment with conda env create, you will not be able to run the notebook because you're missing the ml-collections and more-itertools libraries.
Similarly, you'll find the time library has not been imported, and everywhere you use tqdm as module instead of the right function (tqdm vs tqdm.tqdm).
Thanks again,
Ryan

Along the lines of what @rhsimplex has pointed out, specific version numbers (also for python) are missing in the environment file.
This causes  conda env create -f environment.yml to take forever in solving the right environment.


Set BrowserWindow options defaults for child windows ?

We have an Electron app which launches a new window containing a Flash application from the main window. We set plugins to true in the BrowserWindow  options and away it goes. All good.
However, the Flash app itself then launches another window containing a Flash component. The Flash component fails because it cannot find the Flash plugin.
This child app works fine if we just launch it directly in a browser OR if we launch it directly from Electron with plugins set to true.
Could Electron be modified to either:
a) allow these child windows to inherit the options of the parent window, or...
b) allow option defaults to be specified for these child windows
or have I missed something and there's an easy way to currently do this?
Thanks.

This issue seems to be related to #2771 (same solution).

Thanks for finding the link @etiktin. In that case, the app still works.
In my case, the app becomes unusable, so I don't consider this to be an enhancement , as per the tagging of the other issue.
The inheritance idea would be my preferred solution.

However, the Flash app itself then launches another window containing a Flash component. The Flash component fails because it cannot find the Flash plugin.

How does the Flash app open a new window? Does it call window.open? If so then it is a duplicate of #2771.

The Flash app is written in ActionScript3 and the code to open a url in a new window looks something like this:
var request = new URLRequest("http://www.url-which-requires-flash.com");
navigateToURL(request, "_blank");

The rest is internal mechanics. Perhaps it eventually maps to window.open, I don't know.
But I would be grateful for a fix or a workaround to allow windows launched by Electron to then launch windows which have access to the same plugins the Electron windows have access to. How can I do that?

But I would be grateful for a fix or a workaround to allow windows launched by Electron to then launch windows which have access to the same plugins the Electron windows have access to. How can I do that?

It will be solved once #2771 gets implemented, I'm closing this as a duplicate.


Are checkboxes broken?

Hi
I'm trying to incorporate rrf into my app.
I simply cannot get checkboxes to work
I'm doing this simple example
<Form model='playground'>
  <Control.checkbox
    model='.boolean.checkbox1'
    value={true} />

  <Field model='.boolean.checkbox2'>
    <label>
      <input type='checkbox' value={true} /> Check me!
    </label>
  </Field>
</Form>

The redux action rff/change is triggered when i check the box, but the checked state is not updated. I've tried both with 1.0.15 and 1.1.0, but nothing is working.

The code as-is works just fine for me (see above).
But you can also try removing the value prop in your checkboxes.

I've resolved it.
I put the combineForms like this in my createStore:
createStore({
  form: combineForms(...)
})

And the consequent naming of my forms in my views did not resolve to the right form in rrf (nothing was actually stored in redux)..
So beginners error. I read the documentation again, and its not 100% clear that the naming changes when you nest combineForms in the state. But maybe i just didn't read it well enough.. :)
Anyway, thanks for the quick reply. Keep up the good work.. :)

So beginners error. I read the documentation again, and its not 100% clear that the naming changes when you nest combineForms in the state. But maybe i just didn't read it well enough.. :)

I'll try to make this clearer! Think of combineForms as expanding to an object. So in theory, you'd end up with something like:
{
  form: {
    foo: ...
    bar: ...
  }
}

And then your models would be form.foo and form.bar, respectively.

It makes total sense when you get it. :)
I guess i just thought i had to omit the part of the path above the combineForms..

I guess i just thought i had to omit the part of the path above the combineForms..

Yes, that's right but your syntax is a bit off. combineForms (like combineReducers) returns a reducer function, so you want this:
const store = createStore(combineForms({
  ...
}));


Update dependency eslint to v8.56.0

This PR contains the following updates:

Package
Type
Update
Change

eslint (source)
devDependencies
minor
8.51.0 -> 8.56.0

Release Notes

eslint/eslint (eslint)
v8.56.0
Compare Source
Features

0dd9704 feat: Support custom severity when reporting unused disable directives (#17212) (Bryan Mishkin)
31a7e3f feat: fix no-restricted-properties false negatives with unknown objects (#17818) (Arka Pratim Chaudhuri)

Bug Fixes

7d5e5f6 fix: TypeError: fs.exists is not a function on read-only file system (#17846) (Francesco Trotta)
74739c8 fix: suggestion with invalid syntax in no-promise-executor-return rule (#17812) (Bryan Mishkin)

Documentation

9007719 docs: update link in ways-to-extend.md (#17839) (Amel SELMANE)
3a22236 docs: Update README (GitHub Actions Bot)
54c3ca6 docs: fix migration-guide example (#17829) (Tanuj Kanti)
4391b71 docs: check config comments in rule examples (#17815) (Francesco Trotta)
fd28363 docs: remove mention about ESLint stylistic rules in readme (#17810) (Zwyx)
48ed5a6 docs: Update README (GitHub Actions Bot)

Chores

ba6af85 chore: upgrade<EMAIL_ADDRESS>(#17864) (Milos Djermanovic)
60a531a chore: package.json update for @eslint/js release (Jenkins)
ba87a06 chore: update dependency markdownlint to ^0.32.0 (#17783) (renovate[bot])
9271d10 chore: add GitHub issue template for docs issues (#17845) (Josh Goldberg ✨)
70a686b chore: Convert rule tests to FlatRuleTester (#17819) (Nicholas C. Zakas)
f3a599d chore: upgrade eslint-plugin-unicorn to v49.0.0 (#17837) (唯然)
905d4b7 chore: upgrade eslint-plugin-eslint-plugin v5.2.1 (#17838) (唯然)
4d7c3ce chore: update eslint-plugin-n v16.4.0 (#17836) (唯然)
fd0c60c ci: unpin Node.js 21.2.0 (#17821) (Francesco Trotta)

v8.55.0
Compare Source
Features

8c9e6c1 feat: importNamePattern option in no-restricted-imports (#17721) (Tanuj Kanti)

Documentation

83ece2a docs: fix typo --rules -> --rule (#17806) (OKURA Masafumi)
fffca5c docs: remove "Open in Playground" buttons for removed rules (#17791) (Francesco Trotta)
a6d9442 docs: fix correct/incorrect examples of rules (#17789) (Tanuj Kanti)
383e999 docs: update and fix examples for no-unused-vars (#17788) (Tanuj Kanti)
5a8efd5 docs: add specific stylistic rule for each deprecated rule (#17778) (Etienne)

Chores

eb8950c chore: upgrade<EMAIL_ADDRESS>(#17811) (Milos Djermanovic)
93df384 chore: package.json update for @eslint/js release (Jenkins)
fe4b954 chore: upgrade<EMAIL_ADDRESS>(#17799) (Milos Djermanovic)
bd8911d ci: pin Node.js 21.2.0 (#17809) (Milos Djermanovic)
b29a16b chore: fix several cli tests to run in the intended flat config mode (#17797) (Milos Djermanovic)
de165c1 chore: remove unused config-extends fixtures (#17781) (Milos Djermanovic)
d4304b8 chore: remove formatting/stylistic rules from new rule templates (#17780) (Francesco Trotta)
21024fe chore: check rule examples for syntax errors (#17718) (Francesco Trotta)

v8.54.0
Compare Source
Features

a7a883b feat: for-direction rule add check for condition in reverse order (#17755) (Angelo Annunziata)
1452dc9 feat: Add suggestions to no-console (#17680) (Joel Mathew Koshy)
21ebf8a feat: update no-array-constructor rule (#17711) (Francesco Trotta)

Bug Fixes

98926e6 fix: Ensure that extra data is not accidentally stored in the cache file (#17760) (Milos Djermanovic)
e8cf9f6 fix: Make dark scroll bar in dark theme (#17753) (Pavel)
3cbeaad fix: Use cwd constructor option as config basePath in Linter (#17705) (Milos Djermanovic)

Documentation

becfdd3 docs: Make clear when rules are removed (#17728) (Nicholas C. Zakas)
05d6e99 docs: update "Submit a Pull Request" page (#17712) (Francesco Trotta)
eb2279e docs: display info about deprecated rules (#17749) (Percy Ma)
d245326 docs: Correct working in migrating plugin docs (#17722) (Filip Tammergård)

Chores

d644de9 chore: upgrade<EMAIL_ADDRESS>(#17773) (Milos Djermanovic)
1e6e314 chore: package.json update for @eslint/js release (Jenkins)
6fb8805 chore: Fixed grammar in issue_templates/rule_change (#17770) (Joel Mathew Koshy)
85db724 chore: upgrade markdownlint to 0.31.1 (#17754) (Nitin Kumar)
6d470d2 chore: update dependency recast to ^0.23.0 (#17736) (renovate[bot])
b7121b5 chore: update dependency markdownlint-cli to ^0.37.0 (#17735) (renovate[bot])
633b9a1 chore: update dependency regenerator-runtime to ^0.14.0 (#17739) (renovate[bot])
acac16f chore: update dependency vite-plugin-commonjs to ^0.10.0 (#17740) (renovate[bot])
ba8ca7e chore: add .github/renovate.json5 (#17567) (Josh Goldberg ✨)

v8.53.0
Compare Source
Features

528e1c0 feat: Deprecate formatting rules (#17696) (Nicholas C. Zakas)
c0b11dd feat: Add suggestions for no-prototype-builtins (#17677) (Yonathan Randolph)

Bug Fixes

1ad6257 fix: ensure that exit code for fatal errors is not overwritten (#17683) (Milos Djermanovic)
b329ea7 fix: add ; after JSX nodes in  no-object-constructor autofix (#17672) (Francesco Trotta)

Documentation

ab8c60d docs: change position of return to top button (#17688) (Tanuj Kanti)
4fc44c0 docs: update twitter icon to new X icon (#17687) (Tanuj Kanti)
4164b2c docs: Update README (GitHub Actions Bot)
8651895 docs: Fix tabs in rule examples (#17653) (Francesco Trotta)
3aec1c5 docs: explained rule fixers and suggestions (#17657) (Josh Goldberg ✨)

Chores

ba4d4d5 chore: remove metascraper (#17707) (Milos Djermanovic)
0d07338 chore: Update dependencies (#17706) (Milos Djermanovic)
93256a3 chore: package.json update for @eslint/js release (ESLint Jenkins)
485ec7d test: fix ESLint tests for caching (#17699) (Milos Djermanovic)
db06a7f ci: bump actions/setup-node from 3 to 4 (#17676) (dependabot[bot])
994596b ci: run tests in Node.js 21 (#17673) (Francesco Trotta)

v8.52.0
Compare Source
Features

70648ee feat: report-unused-disable-directive to report unused eslint-enable (#17611) (Yosuke Ota)

Bug Fixes

5de9637 fix: Ensure shared references in rule configs are separated (#17666) (Nicholas C. Zakas)
dcfe573 fix: add preceding semicolon in suggestions of no-object-constructor (#17649) (Francesco Trotta)

Documentation

476d58a docs: Add note about invalid CLI flags when using flat config. (#17664) (Nicholas C. Zakas)
660ed3a docs: Plugin flat config migration guide (#17640) (Nicholas C. Zakas)
a58aa20 docs: fix examples for several rules (#17645) (Milos Djermanovic)
179929b docs: Remove trailing newline from the code of Playground links (#17641) (Francesco Trotta)
f8e5c30 docs: Update README (GitHub Actions Bot)
b7ef2f3 docs: Enable pretty code formatter output (#17635) (Nicholas C. Zakas)
0bcb9a8 docs: Fix syntax errors in rule examples (#17633) (Francesco Trotta)
61b9083 docs: Make no-continue example code work (#17643) (Zhongyuan Zhou)
9fafe45 docs: upgrade to 11ty 2.0 (#17632) (Percy Ma)
ff8e4bf docs: Update README (GitHub Actions Bot)
fab249a docs: Update README (GitHub Actions Bot)
392305b docs: Update no-irregular-whitespace and fix examples (#17626) (Francesco Trotta)
6b8acfb docs: Add real whitespace to no-trailing-spaces examples (#17630) (Francesco Trotta)
1000187 docs: Fix examples in unicode-bom (#17631) (Francesco Trotta)
000290c docs: Update README (GitHub Actions Bot)

Chores

6d1f0c2 chore: upgrade<EMAIL_ADDRESS>(#17671) (Milos Djermanovic)
d63d4fe chore: package.json update for @eslint/js release (ESLint Jenkins)
f30cefe test: fix FlatESLint tests for caching (#17658) (Milos Djermanovic)
ef650cb test: update tests for no-promise-executor-return (#17661) (Milos Djermanovic)

Configuration
📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Self-Hosted Renovate Bot. Find all logs here.

 You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Add a test for concurrent PUT requests.

Adds two tests for concurrent PUT requests and concurrent overwrite
PUT requests. The expectation is that in each case the request with
the latest submitted time should be the one that is externally
visible.

This new test fails for me sometimes when running against aws:
FAIL: s3tests.functional.test_s3.test_concurrent_object_overwrite
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gaul/work/s3-tests/virtualenv/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/gaul/work/s3-tests/s3tests/functional/test_s3.py", line 988, in test_concurrent_object_overwrite
    eq(measured_size, small_size + 40)
AssertionError: None != 1048616

Reference for last writer wins: https://forums.aws.amazon.com/message.jspa?messageID=72266

I increased the sleep time between kicking off the large upload thread and when the small upload occurs to 1s. Ideally, we would like to pause the upload process and inject the second request. However, I could not figure out how to do that. Attempt to use the FakeFileWriter showed that it's not quite meant for that, as I observed the request created in the interrupt on the wire before the request that triggered the interrupt.

@timuralp @andrewgaul it looks like a racy test, I'm not sure it's the correct way to test that. Moreover, don't we already have a test that mimics that in a different way?

@yehudasa I updated the test to use the FakeWriteFile primitive to induce the desired behavior. The content MD5 value needs to be supplied ahead of time, as otherwise the interrupt would be called prematurely.
I also couldn't find tests that test exactly the same behavior (but I haven't read all of them). I assumed that any test that does this would have to either pre-compute MD5 or use threads (like the prior iteration of the PR) and no tests appear to test concurrent PUTs in that way. Skimming through the list of all tests in functional/test_s3.py I also couldn't find a test that does this. Could you point me at a test that validates this behavior?

@timuralp the s3tests-test-readwrite in this repository are doing concurrent writes, and ir doesn't need to have the md5 provided ahead of time (md5 is embedded in the data).

@yehudasa updated the PR to remove MD5 generation and the import statement for hashlib.