Add CBMC proofs

Attains 100% coverage
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this PR since I have created another branch with 100% coverage


HBASE-23890 Update the rsgroup section in our ref guide

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22514 Compile Tests _

+1 :green_heart:
mvninstall
5m 36s
HBASE-22514 passed

+0 :ok:
refguide
4m 51s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 45s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

22m 20s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1206

Optional Tests
dupname asflicense refguide

uname
Linux 61a3f8d1b8e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 77b24fd007

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22514 Compile Tests _

+1 :green_heart:
mvninstall
5m 37s
HBASE-22514 passed

+0 :ok:
refguide
4m 49s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 43s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

22m 16s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1206

Optional Tests
dupname asflicense refguide

uname
Linux b9cb15d80f0e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1d8e3b7032

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/artifact/out/patch-site/book.html

Max. process+thread count
76 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22514 Compile Tests _

+1 :green_heart:
mvninstall
6m 52s
HBASE-22514 passed

+0 :ok:
refguide
7m 58s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
8m 22s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

33m 20s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1206

Optional Tests
dupname asflicense refguide

uname
Linux 1b3281eb1438 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1d8e3b7032

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22514 Compile Tests _

+1 :green_heart:
mvninstall
6m 15s
HBASE-22514 passed

+0 :ok:
refguide
5m 58s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 32s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

26m 59s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1206

Optional Tests
dupname asflicense refguide

uname
Linux 45c44fa894b5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1206/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1d8e3b7032

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/artifact/out/patch-site/book.html

Max. process+thread count
86 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1206/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Any other concerns? @busbey


Upgrade commons-lang3 in release/1.3.x to make bom java11 compatible

For reasons mentioned in https://issues.apache.org/jira/browse/LANG-1384
it would be nice to update the commons-lang3 version in dropwizard-bom

Closed via #2679.


[Cloud Build] Add tags to each build configuration

There's a tags section in:
https://cloud.google.com/build/docs/build-config-file-schema
I'm thinking our builds should have some sort of tag that identifies it as global-game but also which build it is.
Maybe:
tags:  ['global-game-demo', 'services']

For the services, build, and then platform for the platform build, etc.

Got this going locally. Attempting to combine this with #104


time.After in a loop may cause memory leaks.

https://github.com/siddontang/go-mysql/blob/1dc638374d64f9f6c52c628ec3a1218d202e2292/replication/binlogsyncer.go#L663
According to https://golang.org/pkg/time/#After , time.After (also time.Tick) in a loop may cause memory leaks.

The underlying Timer is not recovered by the garbage collector until the timer fires. If efficiency is a concern, use NewTimer instead and call Timer.Stop if the timer is no longer needed..

Thanks @imjustfly
The timer may be only leaked when Context is done, which can't cause a terrible leak problem, but I still think we need to fix this, can you help us do it?


Fixed bug where email notifications were not sent.

Check to see for empty string for email id was incorrect.

Coverage increased (+0.09%) to 88.382% when pulling 5b086ba749da1d17a2d416b46c7ee1fd00240198 on ajoymajumdar:develop into b2321ab922a722626969de20293ca7c0cf3a38e9 on Netflix:develop.


[WIP] Add validations for numeric command line arguments

Description

Add "type" option
Add validation for numeric for now.
Add specs

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@btm this PR only for the reference. could you please have a look and let me know further?

I have tested the type: :numeric it's working fine. PR is good to go. Any suggestion/feedback would be helpful?

Hi @tyler-ball,
I have made suggested changes could you please have a look and let's know further? thanks!

still needs to be updated to drop the :numeric and the case statement and just use === instead.

@lamont-granquist thanks for the reminder.

still needs to be updated to drop the :numeric and the case statement and just use === instead.

Yes, we can use === operator and it works fine for Integer & Float values eg. like 10, 10.0
But In CLI arguments every value is considered as string eg. "10", "10.0", in that case === it returns false.
In order to consider string quoted Integer & Float, we need to parse in respective type.
Figuring out various edge cases.

That's better done as a coercion though:  type: [ Integer ], coerce: { |x| x.to_i } kind of thing.

As per the @lamont-granquist suggestion, it would be good if we validate options similar to the property so that it would be more flexible and useful.
Closing this PR, for now, will open with the proposed solution. Thanks!


SRP_CTX functions should not be in the public API

These functions should probably not be in the public API:
SSL_CTX_SRP_CTX_init()
SSL_CTX_SRP_CTX_free()
SSL_SRP_CTX_init()
SSL_SRP_CTX_free()

AFAICT  SSL_CTX_SRP_CTX_init() and SSL_CTX_SRP_CTX_free() get called automatically whenever you call SSL_CTX_new() and SSL_CTX_free() respectively. Similarly with the SSL_SRP_CTX_*() functions with respect to SSL_new() and SSL_free(). I can't think of a good reason why you would ever want to "reinitialise" the SRP_CTX, or free it early.
The question is what should we do about it? We can't remove them because that would be an ABI break. Just make the public functions noops? Should we deprecate them? Can we even deprecate things between 1.1.0 and 1.1.1??

make them no-ops and return an error.  it's what I did for the RSA init in the #2244 PR.  Hint hint.

I think this needs to go to the 1.2.0 milestone.

SRP_Calc_A_param is another function that looks like it is supposed to be internal, but isn't. Not only that but it's actually a libssl function in spite of the SRP prefix.

barf everytime I look at the SRP API I feel ill.
Here are some more problems I've identified with it:

The API provides a function for parsing a verifier file (SRP_VBASE_init()). As far as I can tell this is an entirely OpenSSL proprietary format. However there is no function for creating such a verifier file. That logic is entirely contained within the srp command line app.

The API requires you to have an intimate knowledge of the SRP RFC to be able to use it. It provides functions for generating various values such as "u" and "x". But these seem entirely temporary intermediate values that you just need to calculate and then pass back to subsequent function calls. All of this should be wrapped up and hidden in some SRP_CTX object

There is no SRP_CTX. All the values needed are passed around individually - and there are quite a few of them. This makes the whole thing unnecessarily complex.

Another one:

The "seed_key" value is supposed to contain random data - but it must also be NUL terminated, so the "random" data cannot contain NUL bytes.

There is no constructor function for creating a new SRP_user_pwd object. You can only get one by querying an existing SRP_VBASE, or by manually creating an instance of the (transparent) structure and manually filling in all of the fields.

There is no function for inserting a new user into an SRP_VBASE. You have to create the user manually and then fiddle around with the right field in the transparent SRP_VBASE structure in order to push the new user onto the stack.

The SRP verifier file format has support for "I" entries which enable you go configure your own "N" and "g" values. However there is no support anywhere for creating such verifier file entries, so it is likely that this code isn't actually used by anyone.

The SRP code uses its own special variant of base64. This seems to have been inherited from libsrp. At some point there seems to have been an attempt to support reading the same config files as libsrp. At least the comment in front of SRP_VBASE_init() suggests that the file format is the same as the one from libsrp. However the format that is actually implemented is different - so we don't actually support libsrp verifier files. Therefore the use of the non-standard base64 seems fairly pointless and unfortunate. However we probably need to continue to support it for backwards compat reasons. See this comment.

Perhaps close this as background info for #14167 ?

Well #14167 is rather about the low level SRP_xxx API. Where this one is about the SRP related calls in the libssl.

But yeah, this could be also closed on the basis that the API is now deprecated and #14167 deals with the possible future non-deprecated implementation.

Closing this then.


Add shintaro-h to Contributors list

Please add me to the list.

Congratulations, welcome to GitHub!


v2.2.3 does not has symbols

flutter v2.2.3
1, get hash (241c87ad800beeab545ab867354d4683d5bfb6ce) from https://github.com/flutter/flutter/blob/2.2.3/bin/internal/engine.version
2, goto  https://console.cloud.google.com/storage/browser/flutter_infra/flutter/241c87ad800beeab545ab867354d4683d5bfb6ce
no symbols here

and flutter v2.2.1， has symbols
https://github.com/flutter/flutter/blob/2.2.1/bin/internal/engine.version
https://console.cloud.google.com/storage/browser/flutter_infra/flutter/0fdb562ac8068ce3dda6b69aca3f355f4d1d2718

ok, I got it.
new url:
https://console.cloud.google.com/storage/browser/flutter_infra_release/flutter
gsutil -m cp -r "gs://flutter_infra_release/flutter/241c87ad800beeab545ab867354d4683d5bfb6ce/android-arm-release"  .
gsutil -m cp -r "gs://flutter_infra_release/flutter/241c87ad800beeab545ab867354d4683d5bfb6ce/android-arm64-release"  .


(PUP-9056) Rescue EINVAL from stat in File type

The puppet6 agent will use Ruby 2.5.1 (development for this is taking place in this puppet-runtime PR).
Acceptance tests for Windows are mostly green without any modifications, but it seems that File.lstat may now raise Errno::EINVAL when the filename is something strange, like UTF-8 characters that the system can't handle -- In Ruby 2.4.4 (used with puppet-agent 5.5.x), this situation used to produce Errno::ENOENT, as if the file didn't exist.
This ad-hoc matrix shows a successful acceptance suite with these changes.

CLA signed by all contributors.


Netlix error, check log for details

I'm submitting a ...

[*] bug report
[ ] feature request
[ ] support request

General information. Fresh install of Kodi 18 and the latest netflix addon. All requirements are met. Netflix starts up and seems to work fine. Except at startup of kodi the error message appears: "Netflix error. Check log for details". Am using Aura Skin and have widgets for netflix enabled, to show automatically, before I have started the addon, to show me the lastest netflix additions.
Prerequisites

[*] Are you running the latest version?

Description
It seems that somehow the addon cannot login to netflix when Kodi starts. Not untill the actual addon has run once do the features of the Aura skin appear.
Steps to Reproduce

Install everything as should be.
restart kodi
error message appears
widgets that use netflix information disappear
start netflix addon, exit out of addon
widgets appear

Expected behavior: What I expected is that when Kodi starts the addon would be able to login into the account and show the requested information in the widget.
Actual behavior: It doesn't seem to login to the netflix account, selecting the proper profile (there are 5) and starting the widgets properly.
Context (Environment)
Windows 10 - Kodi 18 - Netflix 0.13.21
Proper netflix account.
Installation

[ ] I installed the plugin via zip from the Releases page
[*] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[* ] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Debug log
https://www.dropbox.com/s/sj1x79f3vih4f0w/kodi.log?dl=0

Screenshots

Hi,
Same issue here except I am on Linux (x86/x64).

Same problem here;
00:17:01.033 T:140311080710144   ERROR: Control 55 in window 10025 has been asked to focus, but it can't
00:17:01.326 T:140310922385152   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <class 'urllib2.URLError'>
                                            Error Contents: <urlopen error [Errno 111] Connection refused>
                                            Traceback (most recent call last):
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/addon.py", line 33, in <module>
                                                NAVIGATION.router(paramstring=REQUEST_PARAMS)
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/resources/lib/utils.py", line 60, in wrapped
                                                result = func(*args, **kwargs)
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/resources/lib/Navigation.py", line 123, in router
                                                options = self.before_routing_action(params=params)
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/resources/lib/utils.py", line 60, in wrapped
                                                result = func(*args, **kwargs)
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/resources/lib/Navigation.py", line 867, in before_routing_action
                                                'method': 'is_logged_in'}))
                                              File "/home/diogo/.kodi/addons/plugin.video.netflix/resources/lib/Navigation.py", line 1053, in call_netflix_service
                                                data = urllib2.urlopen(full_url).read()
                                              File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
                                                return opener.open(url, data, timeout)
                                              File "/usr/lib/python2.7/urllib2.py", line 429, in open
                                                response = self._open(req, data)
                                              File "/usr/lib/python2.7/urllib2.py", line 447, in _open
                                                '_open', req)
                                              File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
                                                result = func(*args)
                                              File "/usr/lib/python2.7/urllib2.py", line 1228, in http_open
                                                return self.do_open(httplib.HTTPConnection, req)
                                              File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open
                                                raise URLError(err)
                                            URLError: <urlopen error [Errno 111] Connection refused>
                                            -->End of Python script error report<--
00:17:01.348 T:140310922385152 WARNING: CPythonInvoker(4, /home/diogo/.kodi/addons/plugin.video.netflix/addon.py): the python script "/home/diogo/.kodi/addons/plugin.video.netflix/addon.py" has left several classes in memory that we couldn't clean up. The classes include: N9XBMCAddon9xbmcaddon5AddonE
00:17:01.368 T:140310930777856   ERROR: GetDirectory - Error getting plugin://plugin.video.netflix/
00:17:01.378 T:140311080710144   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.netflix/) failed

Same error here, using freshly installed Kodi 18 on Raspberry PI 3.
Log: https://pastebin.com/nTY7Yyx2
Thanks for any tips and help :)

I confirm this BUG on a fresh install RPI3 kodi 18.0-1

Ditto, same as @kkr0kk. Fresh install of Kodi 18 on Raspian, RPi 3b+. Latest apt-get and dist-update.

Same here

Had this before on Rpi3 B+ with Arch Linux ARM and kodi-rbp3-18.0-1. Works fine since updating to 18.1-1 :)

Same here, works fine since 18.1 update on Linux (x86/x64).

Upgraded to 18.1 on windows 10. Same problem still. Netflix app still on 0.13.21. Netflix addon respository still not showing any updates to netflix. Problem remains.

In my case, I originally could run everything on Kodi version 18 but had to reset. Once I reinstalled Kodi, one of the first add-ons I installed is Netflix via the tvaddons repo. I can login, though it's slow, but as soon as I do I receive the error listed above. Nothing will load or play from Netflix but will from other sources such as YouTube.

Same problem here on Archlinux up to date.

Same issue, RPi 3B+ with OSMC and Kodi 18.2-RC1.

Try this version:
https://github.com/CastagnaIT/plugin.video.netflix

Just installed with the same issue. I can login but receive Netflix error. Can navigate menus but cannot play videos.
On February 28, 2019 4:17:45 AM EST, wintuxx<EMAIL_ADDRESS>wrote:

Try this version:
https://github.com/CastagnaIT/plugin.video.netflix
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468197469

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Did you uninstall the old one first?
If not, deinstall the addon, yes to delete all userdata and restart kodi.
then install 0.14.0 again and restart.
if it did not work please post a debug log here in the issues:
https://github.com/CastagnaIT/plugin.video.netflix/issues

Which 0.14 release are you talking about ? I only see 0.13.19 on both github repositories.

The highest I'm seeing is 0.13.21. No 0.14 anywhere for me either.
On Thu, 2019-02-28 at 12:06 -0800, Eddie Barraco wrote:

Which 0.14 release are you talking about ? I only see 0.13.19 on both
github repositories.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c5
5493e4bb","name":"GitHub"},"entity":{"external_key":"github/asciidisc
o/plugin.video.netflix","title":"asciidisco/plugin.video.netflix","su
btitle":"GitHub repository","main_image_url":"
https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open
in GitHub","url":"
https://github.com/asciidisco/plugin.video.netflix"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Eluminae
in #628: Which 0.14 release are you talking about ? I only see
0.13.19 on both github repositories."}],"action":{"name":"View
Issue","url":"
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468418312
"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468418312
",
"url": "
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468418312
",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

https://github.com/CastagnaIT/plugin.video.netflix/archive/master.zip
This is the 0.14.0-beta21

After installing 0.14.0-beta21, I receive the following error.
"The addon encountered the following error. Exception: AddonSignals
call timed out"
When attempting to play a video, I receive the following. "The addon
encountered the following error:argument "cypherkeyID" for "Encrypt"
must be a string or a bytearray"
On Thu, 2019-02-28 at 13:59 -0800, wintuxx wrote:

https://github.com/CastagnaIT/plugin.video.netflix/archive/master.zip
This is the 0.14.0-beta21
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c5
5493e4bb","name":"GitHub"},"entity":{"external_key":"github/asciidisc
o/plugin.video.netflix","title":"asciidisco/plugin.video.netflix","su
btitle":"GitHub repository","main_image_url":"
https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open
in GitHub","url":"
https://github.com/asciidisco/plugin.video.netflix"}},"updates":{"snippets":[{"icon":"PERSON","message":"@wintuxx
in #628:
https://github.com/CastagnaIT/plugin.video.netflix/archive/master.zip\r\n\r\nThis
is the 0.14.0-beta21"}],"action":{"name":"View Issue","url":"
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468455346
"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468455346
",
"url": "
https://github.com/asciidisco/plugin.video.netflix/issues/628#issuecomment-468455346
",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Same problem with Kodi 18.1, Netflix 0.13.22 on Windows.
https://gist.githubusercontent.com/FolkSong/74fd3bc358d074b24d3f83fad0211882/raw/0b5e19939da3b7efd833d5de344946c65c204dbd/kodi.log
I will try the CastagnaIT version.

Same error after adding widgets in the KODI Netflix menu. Playback works fine however...

The problem is when using widgets, make sure you delay the skin after services boot completely....there is a skin helper on marcelv repository....

After installing 0.14.0-beta21, I receive the following error. "The addon encountered the following error. Exception: AddonSignals call timed out" When attempting to play a video, I receive the following. "The addon encountered the following error:argument "cypherkeyID" for "Encrypt" must be a string or a bytearray"
…
On Thu, 2019-02-28 at 13:59 -0800, wintuxx wrote: https://github.com/CastagnaIT/plugin.video.netflix/archive/master.zip This is the 0.14.0-beta21 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c5 5493e4bb","name":"GitHub"},"entity":{"external_key":"github/asciidisc o/plugin.video.netflix","title":"asciidisco/plugin.video.netflix","su btitle":"GitHub repository","main_image_url":" https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":" @.*** in #628: https://github.com/CastagnaIT/plugin.video.netflix/archive/master.zip\r\n\r\nThis is the 0.14.0-beta21"}],"action":{"name":"View Issue","url":" #628 (comment) "}}} [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " #628 (comment) ", "url": " #628 (comment) ", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Enable IPC over HTTP to solvce this issue.

Enable IPC over HTTP to solvce this issue.

I tried this. After that I got an error that the service might not be running. So I restarted the Pi and tried again. Now I got an error parsing msl encodable. The solution I found was deleting $HOME/.kodi/userdata/addon_data/plugin.video.netflix, so I did. I started again and had to put in my email and password again, which I did. I started it again and again I got the error about AddonSignals call timed out. I had to enable IPC over HTTP again. I tried to start again and again I got the error that the service may not be running. Again I restarted the Pi and again I had to enter my password. This time I always get the error that the password is incorrect. It isn't. This is the point where I gave up.

Same problem here on a Pi running LibreElec 9.2, Pellucid skin. Interestingly, it doesn't happen on default Estuary skin.
I got around it by configuring a menu item (on Pellucid) to open Netflix from at my (only) profile menu, and avoiding Netflix's main menu. Maybe that's a clue to the problem??


JSDoc doesn't actually handle dictionary declaration like it says it should

Bug Report

🔎 Search Terms
JSDoc, dictionary, not working, Object, generic keys, generic values

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about JSDoc Object syntax

⏯ Playground Link

https://www.typescriptlang.org/play?#code/PQKhCgAIUhBSC2BDADgWgDYEsDWBTSAewCMArPAYwBdIqALJG5FAZ0iQCdisqPOBPSAAMWvLADsA5kMgoOhFHg5UseNlULDxAVwTElIgHRQI0SAAEq-RZADeAeTKUqhgDyiOEyQBpIOvUoAfAC+JsDgAG6ckB5eACqEAHK6+hwA3ODgoDCW1gQOTtRu-qm+JOTUIdDhURzsHHz8ADK4eGlAA
💻 Code

/**
 * A map-like object that maps arbitrary `string` properties to `number`s.
 *
 * @type {Object.<string, number>}
 */
var stringToNumber;

🙁 Actual behavior

Any provided hover information, both in playground, and in vscode, and I assume the wider typescript/javascript language service, just recognizes this type as any. Therefore there is no correct intellisense for either the property or the value, or since it registers as any, it doesn't even recognize there are keys and values.
🙂 Expected behavior

The language server should understand what is meant by {Object.<String, String[]} (i.e. its exactly the same data structure as a Map without having to call it a Map) or related JSDoc syntax and provide the proper intellisense for the data structure.

Types from JSDoc are ignored in TS files - you should use regular type annotations instead.
To see the errors related to JSDoc нou need to check it in JS file or enable JavaScript language in playground to see results:
https://www.typescriptlang.org/play?useJavaScript=true#code/PQKhCgAIUhBSC2BDADgWgDYEsDWBTSAewCMArPAYwBdIqALJG5FAZ0iQCdisqPOBPSAAMWvLADsA5kMgoOhFHg5UseNlULDxAVwTElIgHRQI0SAAEq-RZADeAeTKUqhgDyiOEyQBpIOvUoAfAC+JsDgAG6ckB5eACqEAHK6+hwA3OCZsVIJyQEchkiQALyQAOQAjgDueGUZ2ZK5KUqGxCWQAIwZ4KAwltYEDk7Ubv6pviTk1CHQ4VEc7Bx8-AAyuHjd4JzLa-gA2gAMALrtAGZIGCwbW0tIq+t7HSeltsFpQA

This actually wasn't a ts file I was working in when I encountered this issue. Its a .js file opened in VS Code with the default Typescript/Javascript Language Server enabled so Typescript type annotations won't be available.

https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html
The documentation here states:

You can specify map-like and array-like objects using string and number index signatures, using either standard JSDoc syntax or TypeScript syntax.

It then directly links to the playground link I listed above. So the documentation is pointing to a behavior it says exists but doesn't, or rather, doesn't exist without whatever alterations @IllusionMH made to the playground link.

It looks like the primary difference between the OG link and the suggested playground link is that the suggested link has allowJs and checkJs enabled.
I'm wondering how this plays into the VS Code TS/JS Language Server then because I have the js/ts.implicitProjectConfig.checkJs set to true in my User settings, and I get type information for every other type I declare using JSDoc except this kind.

In playground you've linked I've just switched language mode and added 4 lines of code to demonstrate expected behavior.
In editor I don't see behavior you are describing: Object.<string, number> correctly maps to {[key: string]: number}
Screenshot from clean installation of VS Code 1.54.2 with built in TS Version: 4.2.3

I see! Thanks for providing that. Can you elaborate more on what you mean by "switching the language mode"?
I'm not sure what this could be boiling down to. I wiped out my settings.json and even keyboard settings. Copied your code. Only a handful of extensions running. This is what I see:

I also think the playground sample linked in the documentation should be fixed; maybe that should be opened as another issue? As it links directly to a playground showcasing this problem front and center.

Is there a global configuration file that may be affecting these different behaviors? Like a jsconfig.json stored in a home directory? I'm quite sure I don't have anything of the sort but I could very well be forgetting something or not be aware there's some magic file outside the purview of vs code that the language server is taking into consideration?

In your screenshot you have Object.<String, Number> instead of Object.<string, number> as in Handbook (both string and number are lower case). Uppercase types (that are types of corresponding global objects) lead to any type.
As for link to playground that doesn't include language mode flag - please report it in https://github.com/microsoft/TypeScript-Website repo where playground is stored.

Oh my god. You're 1000% correct. I knew it had to be something easy I was missing as I'm sure I would have found other people with the same problem before now.
Thanks so much for all the support; I'm glad this didn't go any deeper than my boneheaded capitalization issues!


Add FrontdoorFirewallPolicy and FrontdoorSecurityPolicy to cdn group

Description of your changes

Fixes #599
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've created the resources on a local kind cluster on my tenant. Resources have been created successfully.
➜ k get managed
NAME                                                     READY   SYNCED   EXTERNAL-NAME             AGE
resourcegroup.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
resourcegroup.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                                 READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorcustomdomain.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   7m19s

NAME                                                                   READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorfirewallpolicy.cdn.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
frontdoorfirewallpolicy.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                            READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorprofile.cdn.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
frontdoorprofile.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   37m

NAME                                                                   READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorsecuritypolicy.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                       READY   SYNCED   EXTERNAL-NAME         AGE
dnszone.network.azure.upbound.io/frontdoorsecuritypolicy   True    True     upbound-example.com   5m11s

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mikel Landa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml,examples/cdn/frontdoorfirewallpolicy.yaml"


encoding/json: unmarshalling null into non-nullable golang types

Does this issue reproduce with the latest release?
As of 1.12, yes.
What did you do?
I unmarshalled null into an int, string, bool etc. (any non-nullable Golang type)
What did you expect to see?
A type mismatch error, similar to if I'd unmarshalled a string into an int, or any other type mismatch.
What did you see instead?
No error at all, unmarshalling 'succeeds' at deserialising null into my non-nullable type.
Discussion
I'm aware of #2540 , I'm specifically arguing for the reversal of that decision. I'm aware the documentation says "Because null is often used in JSON to mean “not present,” unmarshalling a JSON null into any other Go type has no effect on the value and produces no error.". I'm arguing against that behaviour.
1.
The unmarshaller shouldn't have an opinion on what null "means", it should accurately map json types into their golang equivalents.
2.
If I'm unmarshalling into a specific golang type, I've gone to the effort of statically defining the type that I expect. The unmarshaller should assist me, and reject any poorly typed input (which it does well for all types other than null). If I wanted to marshal into a nullable type, I would have specified a nullable type.
3.
myVar int and myVar *int currently behave the same way when unmarshalling. In golang, an optional value is often implemented as a pointer, so I read these as "int" and "optional int", and I would expect them to behave differently.
4.
Currently json struct tags using the standard library, and db struct tags using the standard library for sql behave differently. In the sql libraries, nullable types are explicit, and trying to unmarshal an sql NULL into a non-nullable type is an error. For sql, like my point 2 above, a pointer to a value can be used as a nullable version of that type.
~5.~
~It is impossible for me to override this behaviour of the unmarshaller. Defining my own type NoReallyIMeantInt int doesn't help. Unmarshalling still succeeds, because the current code parses the null first, and returns early without looking at the Golang type. (It explicitly sets Interfaces, pointers, maps and slices to their zero values, and ignores all other types.)~
Practicalities
I'm aware this decision was made a long time ago. Realistically, what are the chances that this will be fixed now? Is it a compatibility concern? Do we think people deliberately rely on the current unmarshalling behaviour of null?

IMO, this could only be changed with an opt-in to the json.Decoder type, similar to the DisallowUnknownFields() option added in Go 1.10.

A json.Decorder opt-in would be better than nothing. I'll have a look at making a pull request.

A note about implementation: when I define my own type, I should be able to define whether it can unmarshal null or not.
For example, I would like to be able to define an OptionalInt struct such as:
type OptionalInt struct {
  Present bool
  Value int
}

And define that null is a valid json-value that can be unmarshalled into it.
Which means that the implementation should probably use UnmarshalJSON("null"), and not just whether the primitive type (struct, bool, etc) is nullable or not.

I've been thinking about this, and I'm not sure that just adding an option to json.Decoder would be enough.  It may be better to do this in a struct tag, even though I know that can mean a lot more work in some cases.
Imagine my project foo, which wants to take advantage of "strict null" interpretation (this proposal) embeds (in the JSON sense, not the Go struct sense) some third-party struct, as from a third-party SDK, a protobuf definition, or something else, which does not expect strict nulls.
Example:
import "foo"

type MyCompositeType struct {
    Key    string       `json:"key"` // I want strict nulls here
    Value foo.Value `json:"value"`
 }

If foo.Value expects null to be skipped, then this struct will break in strict-null mode, and there will be no recourse.
The only solution I can think of, but maybe there are others, would be to support this mode by a struct tag:
type MyCompositeType struct {
    Key    string       `json:"key,strictnull"` // I want strict nulls here
    Value foo.Value `json:"value"`
 }

This leaves the behavior of embedded types unaltered.

Just thinking out loud, you could wrap the foo.Value in your own type like:
type FooValue foo.Value
//or
type FooValue struct {
  foo.Value
}

And override UnmarshalJSON to use the standard decoder:
func (f *FooValue) UnmarshalJSON(bytes []byte) error {
  return json.Unmarshal(bytes, f)
}

Then you'd get the standard no-error behaviour.
Just trying to understand your example a bit better, if you're using strict nulls, and the foo.Value is a non-nullable type (== the Foo field is required) surely you want the error? So it seems that's not the interesting case.
If foo.Value is a nullable type (== the Foo field is optional), but it's unmarshaller relied on null being skipped rather than handling it, you'd now get an unwanted error. This seems to be the interesting case, and we're talking about a nullable type.
I get your point, a nullable unmarshaller implemented with the current default decoder would likely not actually handle nulls, and thus break when used with strict nulls. Which is a compatibility argument - people relied on the old behaviour, and were not forced to handle null explicitly.
If I was the project using strict nulls, I think I'd be ok overriding types to fix up 3rd party types. (I'm already being anal about nulls by opting into strict nulls after all). How do you feel about the overriding approach compared to struct tags?
If I was the SDK exporting the Golang type, I would eventually add in explicit null handling to my nullable types, so that they would work regardless of which Decoder settings the end user picked.

A creative solution. It obviously only works for defined types (i.e. map[string]interface{} wouldn't work). Maybe that's okay? I'll continue to ponder.

It doesn't seem that creative - but I appreciate the compliment nonetheless! This is the exact same thing you do if you want to add json serialisation to an existing type that doesn't have any, such as net.IPNet.
You would have to clearly define which of the builtin types are nullable (in the sense that unmarshalling null into them does not return an error). In general, I'd argue that almost all the builtin types are not nullable, and if you want a nullable version, use *type. Which would leave pointers and interfaces as nullable. And would mean maps and slices are not nullable.
Which gets a bit murky, because maps and slices have a nil value. But both of those nil values behave like the non-nil-but-empty value. So Golang itself doesn't strongly distinguish between the two, and doesn't really help us decide. The existing encoding/json code always initialises maps, which is treating them as non-nullable. From that I'd be comfortable defining them as not nullable.

Whoops, my point 5 is wrong - I misread the source code. It is possible to write your own UnmarshalJSON that is strict about nulls. The existing code will call your unmarshaller with null, and you have the opportunity to return an error.
Which means I could go to the effort of making my own set of jsonNotNullX types like this:
type example struct {
	Foo string
}

type jsonNotNullExample struct {
	example
}

func (n *jsonNotNullExample) UnmarshalJSON(b []byte) error {
	if string(b) == "null" {
		return fmt.Errorf("strict null error")
	}

	return json.Unmarshal(b, &n.example)
}

But then I'm either polluting my code with json-specific types, or have to somehow then translate every jsonNotNullX type and every struct that contains a jsonNotNullX type back into the original types. Which is way more code than is worth it for strict null deserialisation.

Being wrong about 5 also means that if I wanted to use strictNulls, include 3rd party types like time.Time, and have them also be strict about nulls, I would have to override them to be not-json-nullable. I'd have to do this for all 3rd party types I include, because they would currently all be explicitly json-nullable in their UnmarshalJSON functions.

I can't see 3rd party types ever being fixed to be strict. They can't change the current UnmarshalJSON behaviour, because that's a breaking change. And there is no context provided to UnmarshalJSON that gives access to the decoder settings, so they can't dynamically choose between behaviours.
We've produced an ecosystem where all publicly exported types are explicitly json-nullable, and I can't imagine that's ever going to change. That's really demotivating.

I ran into this problem and I really did not expect the current behavior. I have code like this one: https://play.golang.org/p/8-HkG0HkXeN
Maybe you could at least document the current behavior, that null == 0?

@ostcar as per the original post, the current behavior is already documented:

The JSON null value unmarshals into an interface, map, pointer, or slice by setting that Go value to nil. Because null is often used in JSON to mean “not present,” unmarshaling a JSON null into any other Go type has no effect on the value and produces no error.

Which composes with how arrays are decoded:

To unmarshal a JSON array into a slice, Unmarshal resets the slice length to zero and then appends each element to the slice.

So any null JSON array elements result in zero value Go elements being appended to the slice.
I strongly agree that this behavior can't be changed in v1. I've already had multiple reasonable json "bug fixes" reverted in previous releases because they broke too much existing code, and this would almost certainly be reverted as well.
I think we should rephrase this issue to be about giving the developer more control as to whether they want to be lenient and accept nulls anywhere, or be stricter and only allow them in certain places. It seems in line with other previous json proposals like not allowing unknown fields, disallowing case insensitive matching in object keys, and so on. It's certainly an issue we should keep in mind for future JSON API/design changes.


Feature encoding/decoding slows down search

Related to #144

Might be closed by #110, worth checking for MNIST data with data.standardize = true


No need for NLTH with with keyword

The current syntax still says:
import ImportClause FromClause [no LineTerminator here] WithClause ;

NLTH was necessary to avoid ASI and compatibility issues with the assert contextual keyword. However, with is already a keyword, and is unavailable in modules, so the following is always a syntax error currently:
import foo from "foo"
with (something)

Is it possible to get rid of NLTH before with, because line terminators are already allowed before from?

I have never seem someone splitting their import declarations like that, because usually multi-line imports are with named imports and thus the newline is before }. However, the language generally tries to avoid NLTH unless they are absolutely necessary, and in this case it doesn't solve any parsing ambiguity.

I don't think it has much sense, there is benefits in languages like Python, where everybody writes code in a similar way (and says that this is a big advantage), the same goes to:

✅ prettier;
✅ standard;
✅ eslint-plugin-putout;
✅ @putout/printer;

which tries to unify syntax in some standard similar looking code. I agree with @nicolo-ribaudo nobody writes import in a couple lines, and better to keep it one line. Anyways we already have a place to break line:
import x2 from 'y' with {
    type: 'json',
};

In a typical way to dynamic imports:
await import('y', {
    with {
        type: 'json'
    }
});

And that's definitely enough, I'm sure that NLTH made intentionally in this case.

I agree with @nicolo-ribaudo nobody writes import in a couple lines

What if you have a really long import specifier, such that the specifier by itself exceeds the print width? Being able to write it as
import foooooooooooooooooooooooooo from
"baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar"
with { ... };

Would be nice. Of course that's me playing the devil's advocate, but I'm saying it shouldn't be the language to decide how to format users' code; we haven't done that and we shouldn't.

I'm sure that NLTH made intentionally in this case.

No it isn't. It's simply refactoring artifact from the assert era.

I don't think that would be nice at all :-) but yes, I agree the language typically doesn't, unfortunately, make these kinds of stylistic calls.

I will bring this up at the next TC39 meeting for consensus given the current stage-3-but-not-really-due-to-#137 status, but to be honest I expect this to be not controversial at all.

This has been fixed in the ecma262 PR for the proposal: https://github.com/tc39/ecma262/pull/3057

Just an aside -- while this change makes sense looking at with, it is slightly irksome for implementations that will have to support both with and assert that they have different grammars.
I'd argue we should just keep the parsing the same for with and assert here to avoid having to special case parsing for implementers who will handle both.


[EventRequest] OnBeforeIsReplenishmentOk in Table 5870 "BOM Buffer"

Hello, please consider adding the following event to Table 5870 "BOM Buffer":

[IntegrationEvent(false, false)]
local procedure OnBeforeIsReplenishmentOk(VAR BomBuffer: Record "BOM Buffer"; var IsHandled: Boolean)
begin
end;

and raise it accordingly:

local procedure IsReplenishmentOk(LogWarning: Boolean; var BOMWarningLog: Record "BOM Warning Log"): Boolean
var
    Item: Record Item;
    IsHandled: Boolean;
begin
    OnBeforeIsReplenishmentOk(Rec, IsHandled);
    if IsHandled then
        exit(true);

    if Type <> Type::Item then
        exit(true);
    if "No." = '' then
        exit(true);

    Item.Get("No.");

    if "Is Leaf" then begin
        if Item."Replenishment System" in ["Replenishment System"::Purchase, "Replenishment System"::Transfer] then
            exit(true);
        if LogWarning then
            BOMWarningLog.SetWarning(StrSubstNo(Text005, Item."No."), DATABASE::Item, Item.GetPosition);
    end else begin
        if Item."Replenishment System" in ["Replenishment System"::"Prod. Order", "Replenishment System"::Assembly] then
            exit(IsBOMOk(LogWarning, BOMWarningLog));
        if LogWarning then
            BOMWarningLog.SetWarning(StrSubstNo(Text008, Item."No."), DATABASE::Item, Item.GetPosition);
    end;
end;

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


IntelliSense not showing quick info for participants

Describe what happened:
When joining a LiveShare session as a participant, IntelliSense works but does not show quick info.
I'm unsure if this is intended behavior, but it certainly shouldn't be. I've attempted to look this issue up a good amount and could not find anything.
What was your system configuration?
Product and Version: VSCode v1.79
OS Version: Windows 10
Live Share Extension Version: v1.0.5873
Target Platform or Language: Node.js/TypeScript
Steps to Reproduce / Scenario:

Prepare a folder with an empty JavaScript or TypeScript file
Start a LiveShare session
Join the session on another window of VSCode (web version works too)
On the host window, open the empty JS/TS file and type something like console. to bring up IntelliSense
Repeat step 4 on the participant window

Screenshots
Host:

Participant:

Thanks for taking the time to file this issue.
Quick info is shown once the item has been selected:

However, it does not show before this for the guest as you point out. We’re not able to prioritize this issue right now. However, we will keep this issue open to track this for the time being.


Currently every blueprint contains G8 cloud account credentials under g8client__something

Not sure what the right design would be, but here's a suggestion:

Have the Cockpit remember/cache/store g8client credentials
Allow blueprints to reference cached/store g8client credentials, without having to send the over
...

Not sure what the role of ItsYou.online could be here...

"by design"
I will update documentation

@yveskerwyn close this when its in the documentation

@yveskerwyn can we close this?


[Feature]: VRF BGP Dynamic Neighbor support

Description
BGP Dynamic Neighbor support for VRFs is missing in the terraform provider. This feature is used for Equinix Metal servers to establish BGP sessions with the Top of Rack routers.
New or Affected Terraform Resources
No response
Potential Terraform Configuration
No response

Some references for this issue:

https://deploy.equinix.com/developers/docs/metal/networking/vrf/#the-bgp-table (read access)
<EMAIL_ADDRESS>https://github.com/equinix/metal-cli/pull/433/files
https://github.com/equinix/terraform-provider-equinix/blob/main/internal/resources/metal/vrf/resource.go
https://deploy.equinix.com/developers/api/metal#tag/VRFs/operation/getVrfBGPNeighbors
https://deploy.equinix.com/developers/api/metal#tag/VRFs/operation/getVrfLearnedRoutes
https://deploy.equinix.com/developers/api/metal#tag/VRFs/operation/createBgpDynamicNeighbor
https://deploy.equinix.com/developers/api/metal#tag/VRFs/operation/getBgpDynamicNeighbors

This would build on #129 and #607


[C] How about adding support for driver directory?

Related: #84
Generally, plugin system uses its own plugin directory. For example, PostgreSQL uses ${prefix}/${version}/lib/ and MySQL uses ${prefix}/lib/mysql/plugin/.
How about adding support for driver directory like them? If we use MODULE library not SHARED library (see #84), it's strange that adbc_driver_postgres.so (not lib prefix) exists in /usr/lib/.

Close this because we don't implement plugin system. See also: #84.


Consensus protocol upgrade to fix excessive restrictions of eosio::linkauth

Background
To preserve the security properties of five special native actions, they cannot be linked to a custom minimum permission. This code is enforced in authorization_manager::check_linkauth_authorization by blacklisting the special actions by name. Unfortunately, there is a bug in that code which causes it to only consider the name of the action and not also require that the code account is eosio. This means the restriction applies to an action of any contract as long as it is named one of the following: updateauth, deleteauth, linkauth, unlinkauth, canceldelay. This bug was originally reported in #6654.
Until this bug is fixed with a consensus protocol upgrade, contracts should avoid naming their actions any of above five names. Doing so would not result in a security issue, however, it would prevent users from setting a custom minimum permission for those actions.
Consensus upgrade feature
The goal of this consensus upgrade feature is to correct the checks that prevent an eosio::linkauth action from being used on the five special native actions (and only those five actions).
A new consensus protocol upgrade feature will be added to trigger the changes described in this consensus upgrade proposal. The actual digest for the feature understood at the blockchain level is to be determined. For the purposes of this proposal the codename FIX_LINKAUTH_RESTRICTION will be use to stand-in for whatever the feature identifier will actually end up being.
In authorization_manager::check_linkauth_authorization, the five assertion checks
EOS_ASSERT( link.type != updateauth::get_name(),  action_validate_exception,
            "Cannot link eosio::updateauth to a minimum permission" );
EOS_ASSERT( link.type != deleteauth::get_name(),  action_validate_exception,
            "Cannot link eosio::deleteauth to a minimum permission" );
EOS_ASSERT( link.type != linkauth::get_name(),    action_validate_exception,
            "Cannot link eosio::linkauth to a minimum permission" );
EOS_ASSERT( link.type != unlinkauth::get_name(),  action_validate_exception,
            "Cannot link eosio::unlinkauth to a minimum permission" );
EOS_ASSERT( link.type != canceldelay::get_name(), action_validate_exception,
            "Cannot link eosio::canceldelay to a minimum permission" );

should be guarded by an if statement that only allows those assertions to be checked if FIX_LINKAUTH_RESTRICTION has not yet been activated OR link.code == config::system_account_name.

Resolved by #7025.


Custom Constant String Plugin

Hi
I want to write customize plugin for  "Constant String"  and i follow this guide OB2PluginSample but i can`t save my value to "VAR" !!!!
is there any sample plugin that save result "VAR" as like as  Constant String Function?
thanks in advance

You just have to return the value from your block method, like
[Block(...)]
public string MyConstantString(BotData data)
{
  return "hello";
}


folia Enables Redis Error

This problem occurs when Redis is enabled
Select the error log:https://paste.ubuntu.com/p/VpVGjHVpMq/

This should be fixed with version 0.3.1.

This should be fixed with version 0.3.1.
Okay, thanks, that's commendable speed.


Allow to set undefined properties in yii\base\Object

I have to come back to my closed issue #12021. It seems that this is still not fixed in Yii 2.1.
My description and use case there is still valid.
The outcome of #12021 was, that this should be implemented via a trait. But it seems this never happened in 2.1.
tl;dr: I want to use the magic getter/setter methods from yii\base\BaseObject to be available in my custom classes. But I don't want that this changes PHP's default behavior, where you can also set undefined properties on a class.
<?php
class X
{
}

$x = new X;
$x->demo = 'x';   // No error, PHP allows to have dynamic properties

echo $x->wtf;  // Error, because 'wtf' was not set yet.

Yii changes this default behavior of PHP:
<?php
class X extends yii\base\BaseObject
{
}

$x = new X;

// This will throw an error:
$x->demo = 'x';

You can create your custom Object class that extends yii\base\Object and overrides the __set with your proposed code:
    public function __set($name, $value)
    {
        $setter = 'set' . $name;
        if (method_exists($this, $setter)) {
            $this->$setter($value);
        } elseif (method_exists($this, 'get' . $name)) {
            throw new InvalidCallException('Setting read-only property: ' . get_class($this) . '::' . $name);
        } else {
            // Instead of throwing exception:
            $this->$name = $value;
        }
    }

And your custom classes can extends your custom Object;

OK. Let's have another look at it. Yii indeed enhances default PHP objects behavior adding several features:

Getters/setters.
Strict errors when non-existing property is set.

On top if it, Component adds:

Events.
Behaviors.

Ideally we want to divide these into traits and be able to use any combination of these traits for any object.
The problem is that same __get(), __set() and other magic methods are used by all these features therefore I don't immediately see a good way to achieve that.

We could probably add a specialized trait that could be configured with an array of handlers for the purpose but I do not see any way for it to be as performant as current solution.

I don't know a perfect way either. Each thinkable solution has shortcomings. Still, my current favourite is having a (optional!!) class property like:
public $__strictGetSet = false;

Only if defined this would disable checks for existing properties. The default would be the same behavior we have now.

You can create your custom Object class that extends yii\base\Object and overrides the __set with your proposed code:

@berosoboy Sure, but I may also want to extend a more complex Yii class and still disable that behavior.   With your suggestion I'd basically end up duplicating a lot of Yii classes in that case.

I'd rather see it as LooseGetSetInterface that may be applied to class to indicate that __get()/__set() methods should not check property existence.

@SilverFire You mean an empty interface (interface LooseGetSetInterface {}) that's only used to flag certain classes? I like that idea. It's also straightforward to check for that in the magic method.

/move to yiisoft/yii-core


SAK-33621 remove Flash fallback in audio recorder, use library for waveform rendering

This was 15 years in coming :)  I love commits that delete code :)

Looks like a bunch of suggestions in Codacy, up to you if you want to address any of them?


how to add a topic dynamic

i can create topic in system running.
i need add the topic into consumer topiclist.
how to do?
thanks!

+1

@jiangxl2018 Do you have any answers?

Topics can be added dynamically via whitelists and blacklists. I am currently working with the shopify team on an update which will support dynamic topic additions - https://github.com/Shopify/sarama/pull/1099


CLI Bug: --quiet implemented incorrectly

Run this command to list the locally installed components:
bower list -q

Bower runs successfully, exits with a 0 code and prints absolutely nothing. Now run this command:
bower list

This time, Bower will correctly print the desired output.
The point of --quiet is to tell Bower that we don't want extraneous printing. It means, "Print only the critical stuff; leave off all the baggage".
--quiet should NOT mean, "Print nothing, ever."
When we run a command that explicitly asks for some output, that output should be printed. The quiet flag should suppress any extra information (such as stack traces, progress updates, log messages, etc) but it should NOT suppress the printing of information we asked for (in this case, the result from the list command).
This is happening in Bower 1.3.9.

Bower is deprecated and in maintenance mode, we only fix critical/security issues, no changes


Create test and complete function for create_color_image

Please refer to commit 014dd71619889049d41fd423345011367a4f126d and pull request https://github.com/UBC-MDS/hexdropper/pull/26#issue-2089025744


Fix favicon

Sometimes Firefox won't show the favicon. Looking at the source code the following fixes make sense.

Thanks!


Reimplementing issue

Hi authors, very exciting paper IMO.
I'm currently reimplementing your work but currently facing issue when calculating the Jacobian, since to do that, pytorch need to call the backward function of attention.backward() layer, which is not implemented (flash attention and xformers version), I just want to make sure that were you facing the same issue? And your workaround would be using the original (math) attention right?
Thanks, look forward to your answer!

hi @bomcon123456 did you end up implementing this?

hi @bomcon123456 did you end up implementing this?
yeah I did, which I largely based on StyleGAN-2-ADA-pytorch repo, but the gradient is so memory costly + due to the lacking of SDPA's double backward function of FlashAttention/xformers (hence using native/math kernel), making the fine-tune very slow. So I wonder how the authors did it.

Hi @bomcon123456  and @GiilDe, please check train_smooth_diffusion.py for our implementation. Thanks!

awesome <3


[Feature] bypass server for hbase bulk delete massive vertices and edges

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Feature Description (功能描述)
1、Support  delete massive vertices and edges  bypass server
2、Just support customString and customNumber ID now;
The  feature has been launched internally.
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

already done for it

@imbajin hello, which branch is this PR merged into? thanks

@imbajin hello, which branch is this PR merged into? thanks

Perhaps it hasn't been resolved, you can reopen it


feat: implement InstanceAdminClient::GetIamPolicy

Add the function, the usual integration test, unit tests, and a simple
example.
Fixes #523.

This change is

Sorry the Windows CMake build is broken again. #612 has the fix


Conform to XDG Base Directory Specification

Changed how fasd looks for configuration files and where cache data is stored.
The change is backward compatible with the old config files.
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

@clvv Could you pretty-please review this, and merge if you don't see any issues?  Thanks!


kbfs frozen, cannot manipulate with files

It used to work, then, when I was uploading a larger amount of files, something made it stop working.
Now I can't use the kbfs at all, I can't even cd into my public directory.

Can you please do a keybase log send and let us know the resulting log ID?  Thanks.

Can you please do a keybase log send and let us know the resulting log ID?  Thanks.

@strib 7fac560793d413d82313871c Thanks for a quick response.

@strib 7fac560793d413d82313871c Thanks for a quick response.

It seems like your local device key hasn't been unlocked.  Maybe you pressed cancel on a passphrase entry dialogue?  (Or maybe there is a popup window you haven't noticed somewhere?)
If not, maybe try an explicit keybase unlock (or keybase logout followed by keybase login) and see if that helps?

It seems like your local device key hasn't been unlocked.  Maybe you pressed cancel on a passphrase entry dialogue?  (Or maybe there is a popup window you haven't noticed somewhere?)
If not, maybe try an explicit keybase unlock (or keybase logout followed by keybase login) and see if that helps?

When I restarted the system earlier, I could see a plain white window without decoration with the keybase icon. I closed it. I can access the keybase application from the system tray just fine, though.
I tried all of keybase unlock/logout/login, they all freeze and I have to interrupt it using ctrl+c.
I wanted to send another log, but now even the keybase log send command is frozen, after I typed "YES".

When I restarted the system earlier, I could see a plain white window without decoration with the keybase icon. I closed it. I can access the keybase application from the system tray just fine, though.
I tried all of keybase unlock/logout/login, they all freeze and I have to interrupt it using ctrl+c.
I wanted to send another log, but now even the keybase log send command is frozen, after I typed "YES".

Oh, seems like another plain white window appeared. That might be blocking keybase from functioning.

Oh, seems like another plain white window appeared. That might be blocking keybase from functioning.

Ran killall keybase and restarted keybase log send, if that helps. 8048851fa0ba201a0258de1c

Ran killall keybase and restarted keybase log send, if that helps. 8048851fa0ba201a0258de1c

cc @cjb @gabriel for plain white pinentry windows. Sorry for the inconvenience!

cc @cjb @gabriel for plain white pinentry windows. Sorry for the inconvenience!

@Limeth by the way, keybase unlock takes a --stdin parameter, letting you type your passphrase in the terminal instead of a GUI window (or letting you pipe it in from a file).  Not sure if that will solve your issue but it's worth a try.

@Limeth by the way, keybase unlock takes a --stdin parameter, letting you type your passphrase in the terminal instead of a GUI window (or letting you pipe it in from a file).  Not sure if that will solve your issue but it's worth a try.

Running keybase unlock (with or without --stdin) gives me this error:
▶ ERROR dial unix /run/user/1000/keybase/keybased.sock: connect: no such file or directory

Running keybase unlock (with or without --stdin) gives me this error:
▶ ERROR dial unix /run/user/1000/keybase/keybased.sock: connect: no such file or directory

The blank pinentry screen was fixed in a recent build, you can try the latest here:
https://prerelease.keybase.io/darwin/Keybase-1.0.18-20161227210312%2B1d6f524.dmg
The keybase command line currently only works if Keybase.app is running, better messaging on that in PR here:
https://github.com/keybase/client/pull/5203

(deleted previous comment since this is linux)
@oconnor663 Do we have a recent linux build with this fix?

@gabriel a new build went out on Linux about two hours after your comment yesterday.

Updated keybase, everything seems to be working again.


Test: Token color customizations

Tests #27894

[ ]  linux- @joaomoreno
[x] windows - @michelkaporin

Complexity 2
Test the new setting "editor.tokenColorCustomizations" to modify the token colorization.
The colors and styles configured with this setting will override the color of the current theme.

try comments, strings, numbers, keywords, types, functions, variables with a hex color (e.g. '#FF0000`) to modify the foreground of the given concepts
try textMateRules to pass in an array text mate grammar rules

I don't understand how textMateRules should work. An example would've been great.


Prototype to fix auto-extend delay in eod and incorporate missing feature

This is a rough draft for discussion. This isn't polished yet. I will now update the document to list out the changes.

Sure Amanda. I can add top level descriptions in the next commit. This was just for prototyping so hadn't included that. I have responded to all the questions/comments. PTAL. Thanks.

Closing for #10371. All the feedback is incorporated there. This was just a prototype of the fix for discussion. Thanks.


node and mode update for daal4py readme

Introduction
This template serves 2 purposes and will need to be edited accordingly prior to submitting the PR

Changes to existing samples
Submission of new Samples

Existing Sample Changes
Description
Made edits to the Running Samples in Devcloud section to enable users to select the correct mode and node to run their sample.
I added a jump link at the top to skip to the DevCloud directions. I am not sure if there are steps required before running a sample on the devcloud. For example, does the user need to build daal4py for CPU or activate conda before using the DevCloud? If the answer is yes, then the jump link to the DevCloud directions need to move down below the required steps.
NOTE: Prior to accepting pull request, please review the commented sections in the README.md:

If your sample runs in batch mode, please delete the section on how to run in interactive mode. Joe Oster requested this because interactive mode can be troublesome so we would rather have users use batch mode when possible.
In the node table, if a node is applicable to this sample, please change the node name to BOLD so users can easily identify which nodes are available.

Fixes Issue#
External Dependencies
None.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras
[ x] Documentation

How Has This Been Tested?
Text was reviewed and approved by Dan Petre, Donna Boyer, and Joe Oster.

[ ] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[x ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@JoeOster Rachel has approved. What is the next step to get this PR completed?


esp32 sniffer is not very good ,please help me

Hi, When I use your code on esp32 ,it's work a moment,and will print this message
"PACKET TYPE=DATA, CHAN=07, RSSI=-75, ADDR1=4c:74:bf:07:22:32, ADDR2=c8:3a:35:1d:6a:18, ADDR3=c8:3a:35:1d:6a:Task watchdog got triggered. The following tasks did not reset the watchdog in time:

IDLE (CPU 0)
Tasks currently running:
CPU 0: wifi
CPU 1: IDLE
18
PACKET TYPE=MGMT, CHAN=07, RSSI=-73, ADDR1=3c:e5:a6:f0:20:e0, ADDR2=c8:3a:35:1d:6a:18, ADDR3=c8:3a:35:1d:6a:18
"
but I not found any problem,please help me ,thank you very much

Still a problem or I can close?


RELATED: WEB-3936 Fix API references layout

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-oss-check/56/ : SUCCESS in 3s

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-fossa-scanning-oss-zuul/36/ : SUCCESS in 36s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gooddata-docs-theme-merge-compliance-check/21/ : SUCCESS in 9s


feat: Viettel Cloud secrets manager

What type of PR is this?

/kind feature
What this PR does / why we need it:
Integrate Viettel KMS with kusion to be able to use secrets at Viettel Cloud
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

99 of 421 (23.52%)  changed or added relevant lines in 6 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.8%) to 51.771%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/secrets/providers/viettelcloud/secretsmanager/fake/fake.go
13
16
81.25%

pkg/workspace/validation.go
1
14
7.14%

pkg/secrets/providers/viettelcloud/secretsmanager/secretsmanager.go
56
86
65.12%

pkg/secrets/providers/viettelcloud/vclient/client.go
29
109
26.61%

pkg/secrets/providers/viettelcloud/vclient/request.go
0
96
0.0%

pkg/secrets/providers/viettelcloud/vclient/response.go
0
100
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/spec_parser.go
4
56.1%

pkg/engine/operation/parser/parser.go
6
75.61%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.8%

Covered Lines:
8830

Relevant Lines:
17056

💛  - Coveralls

@hoangndst  Please add more unit tests to improve the test coverage as it has decreased a lot

I have added unit tests to this PR.
cc @SparkYuan @liu-hm19


CrossConnectivity.Current.IsReachable() returns false for Android, true for iOS when connected

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: 3.0.2
Device Tested On: N/A
Simulator Tested On: Android 6.0 (API 23), iPhone 7 iOS 10.3
Version of VS: VS for Mac Professional 7.1 (build 1297)
Version of Xamarin: Xamarin.Forms <IP_ADDRESS>0, Xamarin.Android 23.3.0, Xamarin.iOS 1.0
Versions of other things you are using: NETStandard.Library 1.6.1
Steps to reproduce the Behaviour
Run Xamarin.Forms app in emulators while host laptop is connected to the internet
Expected Behaviour
CrossConnectivity.Current.IsReachable("hostname") returns true
Actual Behaviour
CrossConnectivity.Current.IsReachable("{hostname}") returns true for iOS
CrossConnectivity.Current.IsReachable("{hostname}") returns false for Android
Code snippet
var connected = await Plugin.Connectivity.CrossConnectivity.Current.IsReachable("{hostname}.azurewebsites.net");
if (connected == false)
	return;

Commenting out this block before running in Android emulator results in the the app continuing to access the Azure app service okay, confirming connectivity is present.
Screenshots
N/A

This logic has been completely re-written for 4.0 so you should test that out:
https://montemagno.com/connectivity-plugin-4-0-important-and-awesome-changes/
Also... if you are checking a remote service you would want "IsRemoteReachable"

Thanks James - that works great. Keep up the awesome work!


[macos] app crashed when quitting

Steps to Reproduce

Execute flutter run on the code sample
click x on the window frame or cmd+q to quit the app
app crash report pop up

this issue happened randomly.
Expected results: normally quit the app without crash
Actual results: app crashed
Thread 1 Crashed:: io.flutter.ui\
0   libsystem_kernel.dylib        	0x00007fff2046592e __pthread_kill + 10\
1   libsystem_pthread.dylib       	0x00007fff204945bd pthread_kill + 263\
2   libsystem_c.dylib             	0x00007fff203e94a0 __abort + 139\
3   libsystem_c.dylib             	0x00007fff203e9415 abort + 140\
4   io.flutter.flutter-macos      	0x0000000109a6a379 std::__1::__throw_system_error(int, char const*) + 9\
5   io.flutter.flutter-macos      	0x0000000109a672d3 std::__1::mutex::lock() + 67\
6   io.flutter.flutter-macos      	0x0000000109a762cf fml::MessageLoopTaskQueues::GetNextTaskToRun(fml::TaskQueueId, fml::TimePoint) + 639\
7   io.flutter.flutter-macos      	0x0000000109a752f9 fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 121\
8   io.flutter.flutter-macos      	0x0000000109a7da7c fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*) + 44\
9   com.apple.CoreFoundation      	0x00007fff205a6279 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20\
10  com.apple.CoreFoundation      	0x00007fff205a5d6d __CFRunLoopDoTimer + 927\
11  com.apple.CoreFoundation      	0x00007fff205a58ca __CFRunLoopDoTimers + 307\
12  com.apple.CoreFoundation      	0x00007fff2058c4a3 __CFRunLoopRun + 1988\
13  com.apple.CoreFoundation      	0x00007fff2058b61c CFRunLoopRunSpecific + 563\
14  io.flutter.flutter-macos      	0x0000000109a7dcee fml::MessageLoopDarwin::Run() + 142\
15  io.flutter.flutter-macos      	0x0000000109a751a4 fml::MessageLoopImpl::DoRun() + 36\
16  io.flutter.flutter-macos      	0x0000000109a7cb1a void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*) + 266\
17  libsystem_pthread.dylib       	0x00007fff204948fc _pthread_start + 224\
18  libsystem_pthread.dylib       	0x00007fff20490443 thread_start + 15\

\f0  [34808]\
User ID:               501\
\
Date/Time:             2021-12-30 14:27:40.231 +0800\
OS Version:            macOS 11.5.1 (20G80)\
Report Version:        12\
Anonymous UUID:        14998837-4C6D-8326-FC98-6CBCD65D2284\
\
Sleep/Wake UUID:       5DEAD8DA-9B6D-459A-9390-E707CD95F656\
\
Time Awake Since Boot: 36000 seconds\
Time Since Wake:       110 seconds\
\
System Integrity Protection: enabled\
\
Crashed Thread:        1  io.flutter.ui\
\
Exception Type:        EXC_CRASH (SIGABRT)\
Exception Codes:       0x0000000000000000, 0x0000000000000000\
Exception Note:        EXC_CORPSE_NOTIFY\
\
Application Specific Information:\
abort() called\

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-arm, locale
    en-CN)
    • Flutter version 2.8.1 at /opt/homebrew/Caskroom/flutter/2.5.3/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (2 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/linwei/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (4 available)
    • M2011K2C (mobile)       • b9e9d3d1                  • android-arm64  •
      Android 12 (API 31)
    • Huawei Mate X2 (mobile) • 00008110-000404EC012A801E • ios            • iOS
      15.2 19C57
    • macOS (desktop)         • macos                     • darwin-arm64   •
      macOS 12.1 21C52 darwin-arm
    • Chrome (web)            • chrome                    • web-javascript •
      Google Chrome 96.0.4664.110
    ! Error: Huawei Mate X2 is busy: Preparing the watch for development via
      Huawei Mate X2. Xcode will continue when Huawei Mate X2 is finished. (code
      -10)

! Doctor found issues in 1 category.

@flutter-symbolizer-bot #95705 (comment) release

@flutter-symbolizer-bot #95705 (comment) release

@flutter-symbolizer-bot #95705 (comment)  force ios arm64 release flutter#v2.8.1

Hi @hlwhl
Can you please provide your flutter run --verbose and a complete reproducible minimal code sample
Thank you

I'm also getting the same issue. i have already added the REVERSED_CLIENT_ID in info plist file but still getting the the issue.
Thread 1: "Your app is missing support for the following URL schemes: com.googleusercontent.apps.805212550135-xxxxxxxxxxxxxxxxxxxx"
Please help me and Thanks in advance

Hi @hlwhl
Can you please provide your flutter run --verbose and a complete reproducible minimal code sample
Thank you

It seems sending platform messages from platform to flutter when quitting the app lead to crash, but it happens randomly, not always lead to crash. I'll make a sample code.

@alpitilanam Please file a new issue for this and completely fill out the template. We don't track more than one problem in a GitHub issue as they may be duplicates of different existing issues, or may need different teams to look at them.


fix(ui): select component initial value

Description:
Fix #2017
This PR fixes initial input value for the Select component. Now it's synchronized with the initial selected item. This automatically fixes the similar issue in channels screen and potentially other places.

How Has This Been Tested?
Manually

Types of changes:
Bugfix

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage increased (+0.05%) to 18.256% when pulling 057897b3484b9059597e6f0f2b86b9f1455c90c9 on korhaliv:fix/select-initial-value into 5dfc8b945bc3eeed24ddd21c2f64d5706f4c1039 on LN-Zap:next.


How to change exit link url

Is it possible to change the exit link url ? , it redirect from getdeals, want to use my own domain.

Unfortunately, you cannot use custom domains currently.
The intention was to make GetDeals like a 3rd-party affiliate network, but better. And that is what we have done for now. Similar to 3rd-party affiliate networks, GetDeals provides its own tracking URL which uses its own fixed domain and there's no way to change it.
But we heard you. The API is undergoing continuous development and if possible, we might add the option to use custom domains in the future.


feat: add hideCopyButton option for disabling the copy button functionality

It's a bit weird having to pass down the hideCopyButton prop to all components, we might want to use context to transport it directly to inputs
const { hideCopyButton } = useSettingsContext()

This covers the case of additional settings later on, but might feel overkill right now. (but it's less code overall and less stuff to change later?)

Passing state as props to where it is used is a fundamental of react 😅 . I can change it if you like.

Looks good to me now, what do you think @gsimone?


enhanced stereo is still included in CXSMILES if isomericSmiles=False

Describe the bug
Heres' the reproducible;
In [6]: m = Chem.MolFromSmiles('O[C@H](Br)[C@H](F)C |&1:1,3|')

In [7]: Chem.MolToCXSmiles(m,isomericSmiles=False)
Out[7]: 'CC(F)C(O)Br |&1:1,3|'

This shouldn't happen.
Check the inclusion of bond wedges and cis/trans markers for ring bonds as well when fixing this.
Configuration (please complete the following information):

RDKit version: releases and master
OS:all

I'd love to take a crack at this one if no one else has started yet


About  configuring the C development environment

I  like vscode very much, i give up the vs2019 to choose vscode as my C ide. But the problem is that:
Configuring the C development environment on vscode is too complex for people who have not learned programming.
Can you provide more convenient configuration function?

@1470391328 This should go to https://github.com/Microsoft/vscode-cpptools/issues

Issue moved to microsoft/vscode-cpptools #5149 via ZenHub


[PPP-4620] - Use of Vulnerable Component: Components/xmlrpc-client:3.1.3

Removing OpenERP from Kettle Plugins - validated by CSS team no client is using this feature

@bcostahitachivantara
@renato-s
@smmribeiro

:x: Build failed in 5m 11s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 12, Failures: 0, Skipped: 0    Test Results

Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message

:x: Build failed in 5m 1s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 12, Failures: 0, Skipped: 0    Test Results

Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message

:white_check_mark: Build finished in 1h 6m 31s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5336, Failures: 0, Skipped: 14    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 1h 14m 50s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5336, Failures: 0, Skipped: 14    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 1h 7m 51s
Build command:
mvn clean verify -B -e -Daudit -amd

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.textfileinput.TextFileInputTest.test_PDI695 (click to expand)
test timed out after 100 milliseconds

Tests run: 5299, Failures: 1, Skipped: 14    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 1h 4m 5s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5327, Failures: 0, Skipped: 14    Test Results

:information_source:  This is an automatic message


Failed to create dbcontext

I have been continuing down the path of trying to get the SQL functionality within vs notebooks working and I have hit another error. Currently I am trying to create a dbcontext like demonstrated here: https://youtu.be/938jBJ-tK3c?t=1281
However I receive an error of: C:\Program Files\dotnet\sdk\3.1.403\NuGet.targets(128,5): error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json. [Project.fsproj] C:\Program Files\dotnet\sdk\3.1.403\NuGet.targets(128,5): error : Response status code does not indicate success: 429 (). [Project.fsproj] (I have removed the directory of Project.fsproj in the error log there, it was in my temp directory under nuget under a guid folder)
The command I was running: #!connect --kernel-name worldwideimporters mssql "Data Source=localhost;Initial Catalog=license;Integrated Security=True" --create-dbcontext
OS: Windows 10
Frontend: VS Code

This is an HTTP throttling error on the NuGet package source. Is it still happening?

This error seems to be resolved currently, I have received a new error however while still trying to create the dbcontext. Would you like me to open a new issue or just continue this thread?

Is it this issue? #883.
If so, we can track it there, but otherwise feel free to add info to this issue.

Sadly no, the error I am getting is as follows:
Error: (11,1): error CS1705: Assembly 'Microsoft.EntityFrameworkCore.Design' with identity 'Microsoft.EntityFrameworkCore.Design, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' which has a higher version than referenced assembly 'Microsoft.Extensions.DependencyInjection.Abstractions' with identity 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'
(16,1): error CS1705: Assembly 'Microsoft.EntityFrameworkCore' with identity 'Microsoft.EntityFrameworkCore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' which has a higher version than referenced assembly 'Microsoft.Extensions.DependencyInjection.Abstractions' with identity 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'

This should now work using the latest packages from our CI feeds:


Removed duplicate base16 theme

Thanks, but this is a duplicate of Pull Request #93, which has already been committed.
Closing this pull request.


DRT: Test cleanup.

@atulkatti,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

is there an issue tracking these ?

Why are you excluding these? What configuration is failing?

These are currently failing in the nightly tests. I am temporarily disabling them only from DRTs configuration to unblock onboarding our DRTs. There should be bugs opened by nightly runs for these failures. Once the bugs are addressed the tests should be enabled in DRTs once they become table. Please refer to the nightly test runs to see which configurations are failing.


AspectToken remove will trigger unrecognised exception if there is other aspect registered.

a temporary fix: https://github.com/yanjunz/Aspects/commit/c90cb1bad9a7869f3b0eaccffa47c43985fc830e

You mean that you will get an unrecognized selector exception if you register an aspect for that selector, later remove it, but also have other swizzled selectors remaining?
If so, also see this issue and will try your fix.

Yes. I have created a test case in the demo project. You can use it to reproduce this issue.
https://github.com/yanjunz/Aspects


2 Issues: Getting data from the future and integrity of the datasets

1. ISSUE: Getting data from dates in the future.
Steps to reproduce:
While using the export function on the website for all historically hourly data for station ID 10488 in Dresden (atm till tomorrow). Same while using python (future dates till 2020-08-21)
"""define the periode for fetching"""
start = datetime(2021, 8, 1)
end = datetime(2021, 8, 31, 23, 59)
station = "10488"
"""Get hourly data"""
df_weatherdata = Hourly(station, start, end)
df_weatherdata = df_weatherdata.fetch()
df_weatherdata.reset_index(inplace=True)
df_weatherdata.rename(columns={"time": "datetime"}, inplace=True)
df_weatherdata=df_weatherdata.assign(id_national=station)
print(df_weatherdata)
Why can i query future data???
2. ISSUE: Integrity
There might be a problem with the quality of the data.
Download the historically hourly data for station ID 10488 in Dresden and search for: 2021-03-01 00:00:00
RESULT:
2020-03-01 00:00:00,8.0,2.0,66.0,0.0,0.0,230.0,25.9,44.0,998.9,0.0,4.0,01048
Steps to reproduce:
"""define the periode for fetching"""
start = datetime(2020, 3, 1)
end = datetime(2020, 5, 31, 23, 59)
station = "10488"
"""Get hourly data"""
df_weatherdata = Hourly(station, start, end)
df_weatherdata = df_weatherdata.fetch()
df_weatherdata.reset_index(inplace=True)
df_weatherdata.rename(columns={"time": "datetime"}, inplace=True)
df_weatherdata=df_weatherdata.assign(id_national=station)
print(df_weatherdata)
RESULT:
datetime,temp,dwpt,rhum,prcp,snow,wdir,wspd,wpgt,pres,tsun,coco,id_national
2020-03-01 00:00:00,7.7,1.3,64.0,0.0,0.0,220.0,27.4,44.0,998.9,0.0,4.0,10488
Compare the data from both datasets -> they differ completely

I understand the confusion and I will add an FAQ page on the dev site soon to explain some of these common questions. Regrading the first issue: this is caused by the fact, that model=True by default. At Meteostat we use (MOSMIX) model data to fill gaps in the historical time series. As we do have these forecasts anyway, they're provided along with the historical data. If you don't want model data, you can opt-out on both the website and the Python lib.
Issue 2 is a bit more special and has to do with an order/priority fix in the latest version of the bulk data interface. We now choose SYNOP data over METAR reports because they're more accurate. This will be fixed in the next release of the web app. Until then, I'd prefer the Python results.

@clampr Thanks for your answer.

Issue:
As far as it conserns my usecase. I support the fact model=True by default for historically data while you can still opt-out. It will generate more uniform data. But still including the forecast into historically data is a bad idea and needs to be differentiated. There might be a better implementation splitting historical and forcast data. A second button for forcast data on the website might a solution (fetching all forcast data for a station/ region), for python maybe a forcast class?

Issue:
Python is my prefered choice anyway. But the integrity is still given?

Well, the problem is that we rely on static station dumps. Data isn't queried directly from the Meteostat DB when you make a request through the Python lib. This approach allows the library to scale with minimal to no restrictions.
I agree that mixing historical data and forecasts is confusing. Also, I think there are better alternatives when it comes to weather forecasts. If we want to keep the ability of getting data for the current day, which I think is relevant to many users, we need to have at least a short-term forecast (48 hours) in the station dumps (because of update frequency and caching). For now, I limited the forecasts to 48 hours for all dumps. I think it's fair to say that Meteostat has a focus on historical data with short term forecasts for more comfortable analysis. As 48 hour forecasts are very accurate most of the time, I think it's okay to use them for analysis in certain situations.
If you're only using the Python interface, integrity should be given.

Ok this is a good limitation is.

acceptable If you're only using the Python interface, integrity should be given.
Perfect thanks.

An other question:
When comparing the output and just changing model=True to False I expect to get less rows/ or attributes with NaN/null values.
Steps to reproduce:
"""define the periode for fetching"""
start = datetime(2020, 3, 1)
end = datetime(2020, 5, 31, 23, 59)
station = "10488"

"""Get hourly data and opt-out for model data"""
df_weatherdata = Hourly(station, start, end, model=False)
df_weatherdata = df_weatherdata.fetch()
df_weatherdata.reset_index(inplace=True)
df_weatherdata.rename(columns={"time": "datetime"}, inplace=True)
df_weatherdata=df_weatherdata.assign(id_national=station)
print(df_weatherdata)

Results: While model=False I still get values or  other values while model=True. A model might be even used when data is present?

New docs on data quality. https://dev.meteostat.net/quality.html

@clampr Thanks for all your work.
Steps I did afterwards:

I used python lib to get some sample data for stations in Dresden.
get the data from dwd with in the same timeframe
compared both datasets --> They are identical --> proofed: routine fix works correctly for stations in Dresden, should probably work for all.