[Support] <Smartphone bypass partly Wireguard VPN?>

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[Not 100% sure!] The issue I am reporting can be is directly related to the pivpn installer script.
[X] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

No failed install.

Issue
I have set up Pihole and PiVPN (wireguard). Installation was no problem.
Two android 10 smartphones were connected (barcode scan), test of "Packet capture" https://github.com/pivpn/pivpn/wiki/FAQ was successful. I can also see in the wireguard app on my smartphone that XX MB were sent/received and I can see in Pihole that the smartphones requesting certain domains which are passed or blocked.
But I found out that that some packet bypass somehow the wireguard VPN because I can access using mobile data some domains which are normally blocked by Pihole and I can't see in Pihole that the smartphone is requesting this domain. When I'm Inside my home WLAN this domains are blocked.
My only idea was that probably IPv6 requests somehow bypass the VPN connection?
Have you searched for similar issues and solutions?
(yes/no / which issues?)

Yes but don't find anything matching to my issue.
Console output of      curl -L install.pivpn.dev | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     5  100     5    0     0     26      0 --:--:-- --:--:-- --:--:--    26
100   162  100   162    0     0    580      0 --:--:-- --:--:-- --:--:--   580
100 80405  100 80405    0     0   160k      0 --:--:-- --:--:-- --:--:-- 1670k
:::
::: sudo will be used for the install.
::: Cancel selected. Exiting

--> existing install detected

Console output of      pivpn add or pivpn add nopass
pivpn add
Enter a Name for the Client:

pivpn add nopass
::: Error: Got an unexpected argument 'nopass'
::: Create a client conf profile
:::
::: Usage: pivpn <-a|add> [-n|--name <arg>] [-h|--help]
:::
::: Commands:
:::  [none]               Interactive mode
:::  -n,--name            Name for the Client (default: 'raspberrypi')
:::  -h,--help            Show this help dialog

Console output of      pivpn debug
::::		PiVPN debug		 ::::
=============================================
::::		Latest commit		 ::::
commit 4e8d4dfd8ef01e49f3137d5fc5a2afa14a465e47 (HEAD -> master, origin/master, origin/HEAD)
Merge: f045e39 4039a0d
Author: Orazio<EMAIL_ADDRESS>Date:   Tue Apr 7 13:45:43 2020 +0200

    Merge pull request #1000 from psgoundar/pivpn

    Updated listOVPN to Include Expiration Dates
=============================================
::::	    Installation settings    	 ::::
PLAT=Raspbian
OSCN=buster
USING_UFW=0
IPv4dev=eth0
dhcpReserv=1
IPv4addr=xxx.xxx.xxx.xxx/xxx
IPv4gw=xxx.xxx.xxx.xxx
install_user=xxx
install_home=/home/xxx
VPN=wireguard
pivpnPORT=51820
pivpnDNS1=xxx.xxx.xxx.xxx
pivpnDNS2=
pivpnHOST=REDACTED
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=0
pivpnPROTO=udp
pivpnDEV=wg0
pivpnNET=xxx.xxx.xxx.xxx
subnetClass=24
UNATTUPG=1
INSTALLED_PACKAGES=(raspberrypi-kernel-headers wireguard wireguard-tools wireguard-dkms qrencode)
=============================================
::::  Server configuration shown below   ::::
[Interface]
PrivateKey = server_priv
Address = xxx.xxx.xxx.xxx/xxx
ListenPort = 51820
# begin d_smartphone
[Peer]
PublicKey = d_smartphone_pub
PresharedKey = psk
AllowedIPs = xxx.xxx.xxx.xxx/xxx, ::0/0
# end d_smartphone
# begin m_smartphone
[Peer]
PublicKey = m_smartphone_pub
PresharedKey = psk
AllowedIPs = xxx.xxx.xxx.xxx/xxx, ::0/0
# end m_smartphone
=============================================
::::  Client configuration shown below   ::::
[Interface]
PrivateKey = d_smartphone_priv
Address = xxx.xxx.xxx.xxx/xxx
DNS = xxx.xxx.xxx.xxx

[Peer]
PublicKey = server_pub
PresharedKey = psk
Endpoint = REDACTED:51820
AllowedIPs = <IP_ADDRESS>/0, ::0/0
=============================================
:::: 	Recursive list of files in	 ::::
::::	[4m/etc/wireguard shown below	 ::::
/etc/wireguard:
configs  keys  wg0.conf

/etc/wireguard/configs:
clients.txt  d_smartphone.conf	m_smartphone.conf

/etc/wireguard/keys:
d_smartphone_priv  d_smartphone_pub  m_smartphone_priv	m_smartphone_pub  psk  server_priv  server_pub
=============================================
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] WireGuard is running
:: [OK] WireGuard is enabled (it will automatically start on reboot)
:: [OK] WireGuard is listening on port 51820/udp
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://github.com/pivpn/pivpn/wiki/FAQ
=============================================
:::: WARNING: This script should have automatically masked sensitive       ::::
:::: information, however, still make sure that PrivateKey, PublicKey      ::::
:::: and PresharedKey are masked before reporting an issue. An example key ::::
:::: that you should NOT see in this log looks like this:                  ::::
:::: YIAoJVsdIeyvXfGGDDadHh6AxsMRymZTnnzZoAb9cxRe                          ::::
=============================================
::::		Debug complete		 ::::

Have you taken any steps towards solving your issue?
1. I have added ", ::0/0" to allowed IPs for clients (was missing) as explained here https://www.reddit.com/r/WireGuard/comments/b0m5g2/ipv6_leaks_psa_for_anyone_here_using_wireguard_to/

2. Activate "permanent VPN" and "block connections without VPN" on Android smartphones.

But both changed nothing to my problem.

Because I'm not 100% sure whether this is related to PiVPN intaller script I created here an addtional request: https://www.reddit.com/r/WireGuard/comments/gsqb3l/wireguard_successfully_installed_with_help_of/

I have added ", ::0/0" to allowed IPs for clients (was missing) as explained here https://www.reddit.com/r/WireGuard/comments/b0m5g2/ipv6_leaks_psa_for_anyone_here_using_wireguard_to/

True but you need that in the client config (it's already there since this commit https://github.com/pivpn/pivpn/commit/1352ccf9a3d7c6379e0b205be73558c7e3bd3ef4), not the server config.

But I found out that that some packet bypass somehow the wireguard VPN because I can access using mobile data some domains which are normally blocked by Pihole and I can't see in Pihole that the smartphone is requesting this domain. When I'm Inside my home WLAN this domains are blocked.
My only idea was that probably IPv6 requests somehow bypass the VPN connection?

Well, with allowedips <IP_ADDRESS>/0, ::0/0 the client should tunnel everything through the VPN. There isn't much you can change, maybe when you turn on the VPN the client has some cached dns responses so it doesn't ask pihole, bypassing the adblock?
To get a better insight into this you should try on a pc with wireshark or tcpdump and actually see which traffic goes where.

Thanks for your answer. I was also thinking about old cache, but why only with mobile data and not during Wi-Fi use?
Today I made some additional trails with the both smartphones, and until now it seems to be possible to bypass the VPN only for apps inside the Android work profile. I can access with the browser inside the work profile domains which are blocked by regex filters of pihole but only during using mobile data connection. With Wi-Fi all requests of the work profile are blocked by Pihole.
Same domains on same device using the browser inside the private profile are blocked also during using mobile data connection.
I searched through the internet but don't find anything useful until now, according what I read the VPN should be used for all apps. There is no additional option so separately activate this for the work profile. I already activate "permanent VPN" and "block connections without VPN".
Probably the work profile provider app (shelter) could cause this, but why only during mobile data connection?!? :-/

Thanks for your answer. I was also thinking about old cache, but why only with mobile data and not during Wi-Fi use?

Because on wifi the cached response is from pihole, which is a null response, while on mobile you get the unblocked response from you isp’s dns.

Same domains on same device using the browser inside the private profile are blocked also during using mobile data connection.

Seems related to your phone configuration then.

Seems related to your phone configuration then.
I agree.

Just if someone have also trouble with that. You have to clone Wireguard in your work profile of your phone. And set up a additional client for this work profile.
At the moment it still don't work for me, if I connect my work profile with any wireguard profile my hole internet in the work profile is broken. I'm still searching for a solution.


YOLOv8 Quantization Failed on Windows with OpenVINO 2023.0

It happened after updated to 2023.0.

Reverting to 2022.3 solved this problem.


Playing with CodeIgniter 4

COMMONPATH and VENDORPATH names have been added to prettify the shown file list.

I want my application to contain only what is needed from the perspective of the final product. The framework-specific stuff and the default configuration files have been moved under common/ directory.

A Twig template:

The controller:

The rendered page:

This is how I see a good custom renderer/parser integration. The API of CodeIgniter is to be used as usual.

CodeIgniter 4 + Fomantic UI

...
...

Gradually a new application takes shape.


Error while compiling this project

I am getting following error when I am trying to build this module.
 C/C++ debug|armeabi-v7a : CMake Error at /home/vikram/Documents/src/renderscript-intrinsics-replacement-toolkit/renderscript-toolkit/src/main/cpp/CMakeLists.txt:117 (include):
  include could not find load file:

    AndroidNdkModules

You probably don't have the NDK installed or configured correctly. Check https://developer.android.com/studio/projects/add-native-code and let me know how it goes.

@patilvikram, I'll assume that you solved your issue, since you have not replied to this thread. Please re-open if it's still a problem.


value REDIS_PORT is missing

I am porting deployment from docker-compose to k8s. Not sure how it worked previously, but k8s deployment does require REDIS_PORT env variable.
before:
[2024-10-27 09:02:25] production.ERROR: Redis::connect(): Argument #2 ($port) must be of type int, string given {"exception":"[object] (TypeError(code: 0): Redis::connect(): Argument #2 ($port) must be of type int, string given at /var/www/cocktails/vendor/laravel/framework/src/Illuminate/Redis/Connectors/PhpRedisConnector.php:159)
[stacktrace]

and after adding
        - name: REDIS_PORT
          value: "6379"

it works normally.
Versions:

Bar Assistant: 4
Salt Rim: 3

Hello,
Default .env used in image includes defined REDIS_PORT value, if it's missing it will fallback to 6379, this is Laravel's default behavior.
Glad you got it working.

i think i used this env: https://github.com/bar-assistant/docker/blob/master/.env
and laravel crashed instead of falling back to default port. But now I found env in main repo, so thanks for pointing it out


Incoherent return type

Hello,
Thank you for this bundle ! I was wondering, in class ApiProvider, method search, the return type is FeatureCollection :
public function search(SearchRequest $request): FeatureCollection {

    $queryData = RequestSerializer::serializeSearchRequest($request);

    $rawResponse = $this->callApi($request, $queryData);

    return ResponseDeserializer::deserializeSearchResponse($rawResponse);
}

But the method deserializeSearchResponse can return null (?FeatureCollection) :
public static function deserializeSearchResponse(string $rawResponse): ?FeatureCollection {

    $response = json_decode($rawResponse, true);
    if (null === $response) {
        return null;
    }

    return JsonDeserializer::deserializeFeatureCollection($response);
}

Best regards

Hi,
Thank you so much for your feedback.
A new release 1.4.1 solve this issue.
Best regards

Thank you for this quick fix !
Best regards


[Docs] Typos in README files

Hi, I noticed some minor typos across the various README.md files.
Here are some examples and the proposed corrections:
README.md

Read the [website/README](./packages/docs/website/README.md) more details on setting up and building this package. (line 166, should be ... for more details ...).

packages/api/README.md

2. assumming you are in the folder containing your clone (line 21, should be assuming).
Then, you need to add in your packages/api/.env file in the following content: (line 36, looks like there's an extra in).

packages/docs/README.md

content for _interactive workshops_ to explore sample in a hands-on, step-by-step manner ex (line 12, should be ... to explore the sample ...).
This command will start the dev server _and_ launch browser to the correct preview URL (line 17, should be ... launch the browser ...).

packages/portal/README.md

independenty (line 7, should be independently).
assumming (line 26, should be assuming).
respository (line 32, should be repository).

Hi @richardrigutins ,
I have raised a PR on this issue.
PR: #312
Please have a look.

@juliamuiruri4 , Would be great if you assign me this, already opened a PR.

Fixed with #312


Properties not specified in modules?

Hey, I've read the codes for different modules. It seems that the modules does not contain any design for encoding properties (e.g. red or blue for color property). Take attention module for example, if we're not sure what color we are attending, how can the module attend to the right locations? Please correct me if I missed something, thanks!

Right, there's no design difference between, for example, attend[red] and attend[blue]. They share the same architecture, but will learn different weights over the course of training. You can see in this loop that we're adding a module for each of the operations in the CLEVR dataset. Specifically, we'll add an attention module for filter[red] and filter[blue] to follow the example above.
So now our module dictionary has a module that is deemed responsible for finding red objects and it has a module deemed responsible for finding blue objects. In every question that I ask about red objects, that same red module is placed into the appropriate location. Similarly, in every question that is asked involving blue objects, the blue module is used. Because the two modules are used in different places and in different questions, they are able to specialize to performing the appropriate operations.
Because the only information the modules are allowed to pass through is a mask, the modules have to learn to pinpoint the location of the relevant objects. To be concrete, the red module has to localize red objects in order to perform well at the question answering task because the only information it's allowed to pass is where relevant objects are. If it passes more information than necessary or less information than necessary, the answer will likely be wrong, giving a loss to the red module that pushes it toward correctly identifying red things. In this way, it's able to learn which features from the ResNet module encode the color red and it's able to mask out the locations that do not have this property.


Add sms handling

@imsickofmaps Please review

:+1: Looks good with the placeholder fixtures, will need converting to DRF style probably


[Feature request] Option to config cppreference language

The extension uses en.cppreference.com as the doc source by default, it would be great it's configurable so users can switch to other languages of cppreference.

Hey @chawyehsu, what do you mean other languages of cppreference?

Sorry I mean the translations of cppreference like https://zh.cppreference.com

Great suggestion. 👍 Added to milestone 0.2!

Hi @chawyehsu, v0.2.0 has been released. I'll close this issue. If you have any further issues please file a new one.

Hi @chawyehsu, v0.2.0 has been released. I'll close this issue. If you have any further issues please file a new one.


plugin_manager

It sounds like the plugin manager is not working anymore :/
It cannot find any of them.

This seems to answer your issue:
https://stackoverflow.com/questions/51950533/fatal-python-error-init-sys-streams-cant-initialize-sys-standard-streams-attr/56283693
basically remove from your Path env variable (both user and system) any path pointing to a given python distrib and try again

Here are my PATH variables:

i do not see a reference to a python distribution.
I tried again with a fresh installation but the problem is still the same :/

But in the command line i got this:
(tmp_pymodaq_plugin_manager) C:\Users\dbrestea>echo %PATH%                                                              C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager;C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager\Library\mingw-w64\bin;C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager\Library\usr\bin;C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager\Library\bin;C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager\Scripts;C:\Users\dbrestea\Anaconda3\envs\tmp_pymodaq_plugin_manager\bin;C:\Users\dbrestea\Anaconda3\condabin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\PuTTY;C:\Program Files (x86)\IVI Foundation\VISA\WinNT\Bin;C:\Program Files\IVI Foundation\VISA\Win64\Bin;C:\Program Files (x86)\IVI Foundation\VISA\WinNT\Bin;C:\Users\dbrestea\AppData\Local\Microsoft\WindowsApps;C:\Users\dbrestea\AppData\Local\Programs\Git\cmd
Maybe because it is not the same user ?…


[SPARK-34980][SQL] Support coalesce partition through union in AQE

What changes were proposed in this pull request?

Coalesce children if plan is Union.
Why are the changes needed?

The rule CoalesceShufflePartitions can only coalesce paritition if

leaf node is ShuffleQueryStage
all shuffle have same partition number

With Union, it might break the assumption. Let's say we have such plan
Union
   HashAggregate
      ShuffleQueryStage
   FileScan

CoalesceShufflePartitions can not optimize it and the result partition would be shuffle partition + FileScan partition which can be quite lagre.
It's better to support partial optimize with Union.
Does this PR introduce any user-facing change?

Probably yes, the result partition might changed.
How was this patch tested?

Add test.

Test build #137048 has started for PR 32084 at commit e4bae2b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41626/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41626/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41626/

Test build #137048 has finished for PR 32084 at commit e4bae2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137048/

cc @maropu @cloud-fan @JkSelf  do you have any thought about this ?

cc @maryannxue too

thank you @maropu for the review. Has addressed the comment that made code more readable and added more tests.

Test build #137115 has started for PR 32084 at commit be8d584.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41694/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41694/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41694/

Test build #137115 has finished for PR 32084 at commit be8d584.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137115/

Test build #137272 has started for PR 32084 at commit a001522.

Test build #137273 has started for PR 32084 at commit a966759.

Test build #137273 has finished for PR 32084 at commit a966759.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137273/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41851/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41851/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41851/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41852/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41852/

Test build #137272 has finished for PR 32084 at commit a001522.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CoalesceShufflePartitions(session: SparkSession)
trait UnionAwareOptimizerRule

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41852/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137272/

Test build #137284 has started for PR 32084 at commit 39afd62.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41863/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41863/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41863/

Test build #137284 has finished for PR 32084 at commit 39afd62.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137284/

retest this please

Test build #137317 has started for PR 32084 at commit 39afd62.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41897/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41897/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41897/

Test build #137317 has finished for PR 32084 at commit 39afd62.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137317/

Test build #139335 has started for PR 32084 at commit 525d4d4.

Test build #139336 has started for PR 32084 at commit 7adda56.

Test build #139336 has finished for PR 32084 at commit 7adda56.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CurrentUser() extends LeafExpression with Unevaluable
case class ReplaceCurrentLike(catalogManager: CatalogManager) extends Rule[LogicalPlan]

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43856/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139336/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43856/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43858/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43858/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43858/

Test build #139335 has finished for PR 32084 at commit 525d4d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139335/

refactor the PR, do you have time to take a look ? cc @maropu @cloud-fan

Test build #139407 has started for PR 32084 at commit 797ea59.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43929/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43929/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43929/

Test build #139407 has finished for PR 32084 at commit 797ea59.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139407/

Test build #139617 has started for PR 32084 at commit e34004f.

Test build #139617 has finished for PR 32084 at commit e34004f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139617/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44144/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44144/

Test build #139636 has started for PR 32084 at commit 377505f.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44163/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44163/

Test build #139636 has finished for PR 32084 at commit 377505f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139636/

Test build #140519 has started for PR 32084 at commit fb562fd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45032/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45032/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45032/

Test build #140519 has finished for PR 32084 at commit fb562fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class MergedBlockMetaRequest extends AbstractMessage implements RequestMessage
public class MergedBlockMetaSuccess extends AbstractResponseMessage
public abstract class AbstractFetchShuffleBlocks extends BlockTransferMessage
public class FetchShuffleBlockChunks extends AbstractFetchShuffleBlocks
public class FetchShuffleBlocks extends AbstractFetchShuffleBlocks
      throw new IllegalArgumentException(s\"Cannot find error class '$errorClass'\"))
trait SparkError extends Throwable
class SparkException(
class SparkArithmeticException(
final case class FileNameSpec(prefix: String, suffix: String)
case class ShuffleBlockInfo(shuffleId: Int, mapId: Long)
case class ShuffleBlockChunkId(
case class ShuffleMergedDataBlockId(appId: String, shuffleId: Int, reduceId: Int) extends BlockId
case class ShuffleMergedIndexBlockId(
case class ShuffleMergedMetaBlockId(
  case class FetchRequest(
  class AvroSchemaHelper(
class DecimalOps(FractionalOps):
class IntegralExtensionOps(IntegralOps):
class FractionalExtensionOps(FractionalOps):
class StringExtensionOps(StringOps):
           new_class = type(\"NameType\", (NameTypeHolder,),
class GroupBy(Generic[FrameLike], metaclass=ABCMeta):
class DataFrameGroupBy(GroupBy[DataFrame]):
class SeriesGroupBy(GroupBy[Series]):
       new_class = type(\"NameType\", (NameTypeHolder,),
class SparkIndexOpsMethods(Generic[IndexOpsLike], metaclass=ABCMeta):
class SparkSeriesMethods(SparkIndexOpsMethods[\"ps.Series\"]):
class SparkIndexMethods(SparkIndexOpsMethods[\"ps.Index\"]):
class RollingAndExpanding(Generic[FrameLike], metaclass=ABCMeta):
class RollingLike(RollingAndExpanding[FrameLike]):
class Rolling(RollingLike[FrameLike]):
class RollingGroupby(RollingLike[FrameLike]):
class ExpandingLike(RollingAndExpanding[FrameLike]):
class Expanding(ExpandingLike[FrameLike]):
class ExpandingGroupby(ExpandingLike[FrameLike]):
class KubernetesLocalDiskShuffleDataIO(sparkConf: SparkConf) extends ShuffleDataIO
class KubernetesLocalDiskShuffleExecutorComponents(sparkConf: SparkConf)
case class TempResolvedColumn(child: Expression, nameParts: Seq[String]) extends UnaryExpression
sealed trait FieldName extends LeafExpression with Unevaluable
case class UnresolvedFieldName(name: Seq[String]) extends FieldName
sealed trait FieldPosition extends LeafExpression with Unevaluable
case class UnresolvedFieldPosition(
case class ResolvedFieldName(path: Seq[String], field: StructField) extends FieldName
case class ResolvedFieldPosition(position: ColumnPosition) extends FieldPosition
case class Cast(
class ExpressionContainmentOrdering extends Ordering[Expression]
case class SubExprEliminationState(
case class ArraysZip(children: Seq[Expression], names: Seq[Expression])
case class GetTimestampNTZ(
case class ParseToTimestampNTZ(
case class MakeDTInterval(
case class MakeYMInterval(years: Expression, months: Expression)
case class RebalancePartitions(
trait AlterTableCommand extends UnaryCommand
case class AlterTableDropColumns(
case class AlterTableRenameColumn(
case class AlterTableAlterColumn(
    new AnalysisException(s\"UDF class $className doesn't implement any UDF interface\")
    new AnalysisException(s\"UDF class with $n type arguments is not supported.\")
    new AnalysisException(s\"Can not instantiate class $className, please make sure\" +
    new AnalysisException(s\"Can not load class $className, please make sure it is on the classpath\")
    new SparkException(s\"Cannot find catalog plugin class for catalog '$name': $pluginClassName\")
    new SparkException(\"Cannot instantiate abstract catalog plugin class for \" +
    new SparkException(s\"Can not load in UserDefinedType $
case class DayTimeIntervalType(startField: Byte, endField: Byte) extends AtomicType
case class YearMonthIntervalType(startField: Byte, endField: Byte) extends AtomicType
final class ParquetReadState
public class ParquetVectorUpdaterFactory
case class CommandResult(
case class MergingSessionsExec(
class MergingSessionsIterator(
case class ShowCreateTableExec(
class RocksDB(
class ByteArrayPair(var key: Array[Byte] = null, var value: Array[Byte] = null)
case class RocksDBConf(
case class AcquiredThreadInfo()
case class StateStoreCustomSumMetric(name: String, desc: String) extends StateStoreCustomMetric
case class StateStoreCustomSizeMetric(name: String, desc: String) extends StateStoreCustomMetric
case class StateStoreCustomTimingMetric(name: String, desc: String) extends StateStoreCustomMetric
trait StatefulOperatorCustomMetric
case class StatefulOperatorCustomSumMetric(name: String, desc: String)
trait TestGroupState[S] extends GroupState[S]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140519/

Test build #141043 has started for PR 32084 at commit 9743c0c.

Test build #141043 has finished for PR 32084 at commit 9743c0c.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class SparkOutOfMemoryError extends OutOfMemoryError implements SparkThrowable
      throw new IllegalArgumentException(s\"Cannot find error class '$errorClass'\"))
class SparkArithmeticException(errorClass: String, messageParameters: Array[String])
  class RemoteBlockDownloadFileManager(
case class UnresolvedFieldPosition(position: ColumnPosition) extends FieldPosition
case class ExpressionEquals(e: Expression)
case class ExpressionStats(expr: Expression)(var useCount: Int = 1)
case class Average(
case class Sum(
case class SubExprEliminationState(eval: ExprCode, children: Seq[SubExprEliminationState])
case class LocalTimestamp(timeZoneId: Option[String] = None) extends LeafExpression
case class GetTimestamp(
case class ParseToTimestampLTZ(
case class ParseToTimestamp(
case class MakeTimestampNTZ(
case class MakeTimestampLTZ(
case class DomainJoin(
      .doc(\"The custom cost evaluator class to be used for adaptive execution. If not being set,\" +
 static class IntegerUpdater implements ParquetVectorUpdater
class MergingSortWithSessionWindowStateIterator(
trait HDFSBackedStateStoreMap
class NoPrefixHDFSBackedStateStoreMap extends HDFSBackedStateStoreMap
class PrefixScannableHDFSBackedStateStoreMap(
  class HDFSBackedReadStateStore(val version: Long, map: HDFSBackedStateStoreMap)
  class HDFSBackedStateStore(val version: Long, mapToUpdate: HDFSBackedStateStoreMap)
case class RocksDBMetrics(
case class RocksDBNativeHistogram(
case class RocksDBFileManagerMetrics(
sealed trait RocksDBStateEncoder
class PrefixKeyScanStateEncoder(
class NoPrefixKeyStateEncoder(keySchema: StructType, valueSchema: StructType)
 class RocksDBStateStore(lastVersion: Long) extends StateStore
sealed trait StreamingSessionWindowStateManager extends Serializable
class StreamingSessionWindowStateManagerImplV1(
class StreamingSessionWindowHelper(sessionExpression: Attribute, inputSchema: Seq[Attribute])
trait WatermarkSupport extends SparkPlan

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141043/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45558/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45558/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45558/

Test build #143247 has started for PR 32084 at commit eeb4047.

Test build #143247 has finished for PR 32084 at commit eeb4047.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143247/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47750/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47750/

Test build #143349 has started for PR 32084 at commit b8ee590.

Test build #143349 has finished for PR 32084 at commit b8ee590.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143349/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47855/

retest this please

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47855/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47855/

Test build #143351 has started for PR 32084 at commit b8ee590.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47857/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47857/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47857/

Test build #143352 has started for PR 32084 at commit 62fb383.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47859/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47859/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47859/

Test build #143351 has finished for PR 32084 at commit b8ee590.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143351/

Test build #143352 has finished for PR 32084 at commit 62fb383.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143352/

Test build #143381 has started for PR 32084 at commit a846ecd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47888/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47888/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47888/

Test build #143381 has finished for PR 32084 at commit a846ecd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143381/

Now, there are two issues for Union in rule CoalesceShufflePartitions and I updated the description to make them more clear.
cc @cloud-fan @maryannxue @JkSelf @viirya if you have time to take a look.

retest this please

Test build #143632 has started for PR 32084 at commit a846ecd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48144/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48144/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48144/

Test build #143632 has finished for PR 32084 at commit a846ecd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143632/

Test build #143679 has started for PR 32084 at commit f362c9f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48193/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48193/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48193/

Test build #143679 has finished for PR 32084 at commit f362c9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143679/

Test build #143695 has started for PR 32084 at commit e2b25b4.

Test build #143696 has started for PR 32084 at commit b2e3848.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48210/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48211/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48210/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48210/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48211/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48211/

Test build #143695 has finished for PR 32084 at commit e2b25b4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #143696 has finished for PR 32084 at commit b2e3848.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143695/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143696/

thanks, merging to master!

thank you @cloud-fan


I'm getting Errors while using your project

Hello, Sir.
Thank you for your sharing this good job.
I've some problem,  Like this:
View [admin.product.edit] not found.
and many others, i think you have updated now.
Please share us with updated and resolved some problems.
Thank you very much

Hi, please desribe in details, or send pr with changes

for example if i go to admin panel, for creating new product getting this one

Check Laravel Ecommerce, this project is deprecated


New version: GasChem v0.3.1

Registering package: GasChem
Repository: https://github.com/EarthSciML/GasChem.jl
Created by: @ctessum
Version: v0.3.1
Commit: 3982c119bd9f7a562175e95ec67fd79d8022d29f
Reviewed by: @ctessum
Reference: https://github.com/EarthSciML/GasChem.jl/commit/3982c119bd9f7a562175e95ec67fd79d8022d29f#commitcomment-122004223
Description: Models of gas-phase atmospheric chemistry and related processes

Superseded by #87730


Adding an id to the containing div

Hi! First of all, thanks for the fork and revival.
My scrollable list component renders a div that I would like to replace with Scrollbars.  It works fine out of the box, but it doesn't seem that Scrollbars supports an id prop, which I am currently passing to the div in order to lazy-load images using the intersection observer API.
Would it be possible to support an id prop?

There's a bunch of native HTMLElement div props that could be passed to the root element.
In order not to pollute the TS hinting and decrease readability, I suggest to group these props under one Scrollbars props key.
e.g. rootElementProps

@Tomassito Sounds reasonable. I will look into making a PR for this if time allows for it this weekend.

There's a bunch of native HTMLElement div props that could be passed to the root element.
For my particular use-case the id is enough, but I suppose it is trivial to also support others. Any preferences on what I should narrow down the "bunch" to in that case?

Any preferences as far as testing goes? Again, I guess that providing e.g. an id and testing that the root element indeed gets this attribute is straightforward, though it might be cumbersome to do that for every native div prop we decide to support.

@Zloka I would allow any of the HTMLElement properties.
When it comes to testing the tricky part is that they don't seem to be configured to work with the dumi tool :/
https://github.com/sakhnyuk/rc-scrollbars/pull/11#issuecomment-774491341
But yeah, checking if all the passed props (constrained by TS type) get applied is the simple way to go. You don't need to check every prop, just a few.

Opene a PR #24 for this just now.
@Tomassito @sakhnyuk any opinions? Like I mentioned in the PR, I wasn't able to run the tests locally so I didn't add any test cases just yet. They should be fairly trivial to add, but I opted not to just yet since I wouldn't be able to run them anyways.

Hi, @Zloka
Sorry, for the late answer and thank you for your PR.
I'm gonna fix the tests in the next releases (was kindly busy the last few weeks).
For now, I just need to test manually your approach.
And I think providing all native div props to our root element is a bad idea. Just for example:

div has a native onScroll event and we can pass onScroll callback to the rootElementProps
what about ref? Somebody will try to pass ref to there

What if we just add an id prop? This is the easiest way in my opinion.
PS: @Zloka Do you have time to wait for release? I can try to fix the test in few days. Or not, we can merge that feature ASAP

@sakhnyuk Hi!
In my case, since I only actually need id I'm fine with that. If you want I can update the PR. Not really in a hurry, this isn't in production for us yet and the Scrollable still works as expected, it's just that the lazy-loading measurement is incorrect but we can live with that until this PR is merged! :)

@Zloka
Yeah, it would be great if you'll update PR.
So, after that, I'll merge PR and start working on tests.

@sakhnyuk This is why we'd group the 'divProps' under one prop so that there's a clear distinction. What if next person comes and says they want to provide x prop to that wrapper div? If they had a valid case, you'd have to extend CustomScrollbars by yet another prop?

@Tomassito I understand what are you talking about, but if we provide passing HTMLAttributes props, we must be sure that everything works fine.
What if the next person opens an issue with the problem when he passing onScroll and ref and something else to divProps and it doesn't work properly.
Apart from the root, we can pass custom elements by render-props. What if we provide also the root component by render prop? Also, there we will able to control some inner root props (overwrite them for example)

Ok. Actually I can't come up with any other prop that users may want to
pass.
On Thu, 25 Feb 2021, 16:36 Michael Sakhniuk<EMAIL_ADDRESS>wrote:

@Tomassito https://github.com/Tomassito I understand what are you
talking about, but if we provide passing HTMLAttributes props, we must be
sure that everything works fine.
What if the next person opens an issue with the problem when he passing
onScroll and ref and something else to divProps and it doesn't work
properly.
Apart from the root, we can pass custom elements by render-props. What if
we provide also the root component by render prop? Also, there we will able
to control some inner root props (overwrite them for example)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sakhnyuk/rc-scrollbars/issues/22#issuecomment-785991594,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI6RXCRTNHMNMUAOJW7CRWDTAZU73ANCNFSM4XUUMLEQ
.

@sakhnyuk I updated the PR just now, didn't have time last evening I'm afraid. I added a test case which I believe should work, but feel free to alter/move it somewhere more appropriate if necessary.
For what it's worth, in principle I agree with @Tomassito that in the long run it would be clearer to support "all" props, rather than picking and choosing which to support and which not. If that need ever arises in practice is hard to say, and for my own purposes this will do.

@sakhnyuk Hey, figured I'd give you a friendly ping in case you forgot! :)

@Zloka Thank you, for your remind 😁
I thought about a solution. Let's merge id prop without special divProp. Will see on the next proposal, what we could do with it.
Today later, I'll check and merge that PR

I've merged PR.
Thank you guys @Zloka @Tomassito  👍


Dev

What is the purpose of the change

Closes #

Brief change log

No changes.

Checklist

Are tests written for added code?

[ ] Yes
[ ] No because:

Did you introduce any new dependencies?

[ ] No
[ ] Yes

Dependency:
Reason:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: WuShaoling:x: wsl6:x: frank-zsyYou have signed the CLA already but the status is still pending? Let us recheck it.


Use RFC6570 Level 1 URI Template for JMAP downloadUrl

Section 2 of RFC8620 describes the downloadUrl property of the JMAP Session resource as follows:

downloadUrl: String The URL endpoint to use when downloading files, in URI Template (level 1) format RFC6570. The URL MUST contain variables called accountId, blobId, type, and name. The use of these variables is described in Section 6.2. Due to potential encoding issues with slashes in content types, it is RECOMMENDED to put the type variable in the query section of the URL.

I've updated the downloadUrl property to be returned in the correct Level 1 URI Template format by surrounding each expression with curly braces rather than the previous leading-$ format.

https://github.com/linagora/james-project/pull/3977/commits/9e873a8073aba2d222ccb1ce7efd4b8e39a75cfe do add accountId parameter for upload URL too.

Closing - looks like this has been merged now.

Yes you are right!
Much sorry for not telling it here...
Apologies.
Benoit


Updating required node versions

Thanks for this PR! Btw, Gladys should be working with Node 10 soon, this should not be hard


Provider common getters for ciphers and digest

[ ] documentation is added or updated
[ ] tests are added or updated

Fixes  #9768

CMAC and GMAC went much faster than expected.

Ah, so this is what you meant. Cool!
I have just one concern that occurred to me just now... I think we may have a bit of symbol name leakage.
$ ar t libcrypto.a | grep ^prov

I'm not seeing the concerning output of the ar command.
I suspect I'm missing something obvious.

Did you mean an nm of the .so?

Ah, so this is what you meant. Cool!

Yeah, I didn't explain myself well as usual :(

I still don't understand what is meant by the ar command.
I'm still sure I'm missing something really obvious...

I still don't understand what is meant by the ar command.

No wonder, I wrote that before coffee.  This should make more sense:
$ nm -P libcrypto.a | grep ^prov

Okay, I admit that there is some leakage.
I'm not convinced that this change has caused it.
It still needs to be addressed.
PS: Coffee is irrelevant :D

I'm not convinced that this change has caused it.

All the new utility functions you added end up in libcrypto and are a part of it.  I'm sure there is more leakage that we simply haven't noticed before, well, now.

I do note that there is a utility function remaining in providercommon.h with a name that starts with ossl_prov_.  That's a precedent to follow.

Okay, I'll switch to ossl_prov_ for the function names.

Function names changed.

It's failing with a segmentation fault inside EVP_DigestSignInit on the final SHA512 test case in evpmac.txt.  Unfortunately, my debugger isn't operating at the moment.

I can look at that abort some other day...  won't have the time today, unfortunately

Thanks, my Linux machine has a working debugger.  It isn't getting the SEGV.

Found a debugger that works.  Fixed the SEGV, now to figure out the test failures.

Found it.  Fixed added and squashed.

Travis failure doesn't seem relevant.

The KDFs and PRFs have been added.

Travis failures don't seem relevant.

Merged to master.  Thanks.


In partitioned runs, abort message should include partition ID

Original issue: https://charm.cs.illinois.edu/redmine/issues/400

Right now, when some code calls CkAbort or CmiAbort, the resulting message on standard error includes the PE making the call. In a partitioned run, there are many PEs that share the same number, one in each partition. In that case, the message should include the partition number as well, to remove ambiguity.
Per Jim:

I know it's a little late in the 6.6 cycle for this, but this is a major usability issue with no userland workaround.
Testing the MIC code on stampede with a 2048-node run, one partition per node, I get the following in stderr:

offload error: process on the device 0 was unexpectedly terminated
------------- Processor 8 Exiting: Called CmiAbort ------------
Reason: unexpected call to exit by user program. Must use CkExit, not exit!
Fatal error on PE 8> unexpected call to exit by user program. Must use CkExit, not exit!

This is of course completely useless since I don't know which partition generated the error.  The NAMD_die messages are much more useful:

Reason: REPLICA 1283 FATAL ERROR: MIC error on Pe 2 (c510-302.stampede.tacc.utexas.edu): No MIC devices found.

The replica index is only printed when CmiNumPartitions() > 1 and is only printed on stderr.  A normal message is also printed on stdout.
The changes would need to be in charmrun_abort(), LrtsAbort(), and KillOnAllSigs(), and of course only for the lrts runtimes (pamilrts, netlrts, verbs, and mpi).

Original date: 2014-01-23 20:29:18

I'll do some refactoring, to try to get consistency across machine layers in the process.

Original date: 2014-01-24 17:57:38

Implemented and merged for CmiAbort. Not yet done for charmrun_abort or KillOnAllSigs.

Original date: 2014-01-30 19:36:20

Remaining sub-unit deferred.

Original date: 2016-02-18 04:34:45

All subtasks had implementations merged before 6.7.0 was released!


Next 37079/reorganize settings page

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfill them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jozsefdamokos:x: skalickiYou have signed the CLA already but the status is still pending? Let us recheck it.


ISPN-9562 Remote Exec hangs with hotrod 2.[4567] ver and cache name is provided

https://issues.jboss.org/browse/ISPN-9562

@rigazilla If it's all good for you, could you integrate this?

@gustavonalle I can merge, but ci is red (org.infinispan.client.hotrod.event.ClientEventsOOMTest.testOOM). Is that ok?

This test is failing on master as well

merged thanks!


projectile-switch-buffer very slow with ivy on large project

What did you expect to happen?
<SPC> <SPC> and it should allow me to quickly find a file.
What actually happened?
Extreme slowdown when selecting a file in a project with about 8k files. Each keypress takes seconds to filter the ivy list.
This seems like a recent regression as I never had a problem in the past with this project.
Additional details:

Include a link to your private config: https://github.com/jsravn/emacs-config
Include screenshots/casts of your issue
If you mention key sequences, include what commands they're bound to (use SPC h k KEY or C-h h k KEY to inspect keys).
Include any warnings or errors logged to *Messages* (use M-x view-echo-area-messages to see it).

Here is the profiler:

If an error message is involved include a backtrace of it.
How to acquire a backtrace:
https://github.com/hlissner/doom-emacs/blob/develop/docs/getting_started.org#how-to-extract-a-backtrace-from-an-error

Steps to reproduce:

Select these example steps,
Delete them,
And replace them with precise steps to reproduce your issue.
Fill in "system information" below.

System information:

emacs   version    27.0.91
        features   XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER GMP
        build      Jul 03, 2020
        buildopts  (--prefix=/nix/store/ml1v43l873j4khjxr6zdz67mi7kmd8yz-emacs-27.0.91 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200)
        windowsys  x
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop 99eea1d3e 2020-06-21 13:53:58 -0400
        dir        ~/.config/doom/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /run/current-system/sw/bin/zsh
        uname      Linux 5.6.18 #1-NixOS SMP Wed Jun 10 18:22:53 UTC 2020 x86_64
        path       (/nix/store/77b1j2kpky9f3kb3yrh95hl5ch8frj5x-kitty-0.16.0/bin/ /nix/store/02px3rrvk2qhcp3kx1an34vzsckcba9m-imagemagick-6.9.10-71/bin/ /nix/store/f8kmpp5vn8d0lh5la81f3nfl5x9j4z1v-xsel-unstable-2019-08-21/bin/ /nix/store/03j792lhxkb358lzq7bmivq0n7bknva0-ncurses-6.1-20190112-dev/bin/ /nix/store/rl0zf16h9f4zmqxzyvbgkj3gkxl8izys-swaybg-1.0/bin/ /run/wrappers/bin/ ~/.config/emacs/bin/ ~/.cache/npm/bin/ ~/go/bin/ ~/.nixfiles/bin/ ~/.nix-profile/bin/ /etc/profiles/per-user/james/bin/ /nix/var/nix/profiles/default/bin/ /run/current-system/sw/bin/ /nix/store/ml1v43l873j4khjxr6zdz67mi7kmd8yz-emacs-27.0.91/libexec/emacs/27.0.91/x86_64-pc-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion (company +childframe) (ivy +fuzzy +icons) :ui doom doom-dashboard hl-todo indent-guides modeline nav-flash ophints (popup +all +defaults) (pretty-code +pragmata-pro) treemacs vc-gutter vi-tilde-fringe window-select workspaces zen :editor (evil +everywhere) fold format multiple-cursors rotate-text snippets word-wrap :emacs dired electric vc :term vterm :checkers syntax spell :tools ansible docker direnv editorconfig (eval +overlay) (lookup +docsets +dictionary) (lsp +peek) (magit +forge) make terraform :lang (cc +lsp) (clojure +cider +lsp) common-lisp data emacs-lisp (go +lsp) (java +lsp) (javascript +lsp) markdown nix (org +dragndrop +journal +roam) (python +lsp +pyenv) sh scheme (yaml +lsp) :email mu4e :config literate (default +bindings +smartparens))
        packages   ((atomic-chrome) (org-roam :pin 4af4d2e4d5f18422fe0f90d5d83fe4c10ef1a20f) (org-msg) (org-alert) (caddyfile-mode))
        unpin      (lsp-mode)
        elpa       (vterm)

The culprit seems to be +fuzzy for ivy. I've disabled it for now.

+prescient works fine as well, so I'll swap to that. Not sure why fuzzy is so slow and generates so much heap.


Private hornet-based Tangle: docker-compose not working

When trying to install the private Tangle network, the docker-compose file is not working.
I found out that the "gohornet/hornet" Docker Hub image used for the nodes is no longer available. I tried to fix this issue using the "iotaledger/hornet" image, but did not succeed: https://hub.docker.com/r/iotaledger/hornet
My question is if there is any intentions on updating this docker-compose file, updating and adapting it to the new Docker Hub images for hornet-based nodes.
Thank you in advance!

this is fixed now, thank you!


Simple portfolio website

Simple Portfolio website template create using CSS ,HTML and JavaScript.

@ron2111 should we keep zip files? I feel code files in a folder would be better

ok

LGTM don't forget to add your name in the contributors list

conflict resolved

conflict resolved


Can't crawl the website's images?

Hello, after downloading the website from web.archive.org, after deploying the server, I found that it is not the same as what is displayed on web.archive.org.

Like the background of the web page is not loading

If the website uses a chart bed, it will not display properly. Including the css file of the website, it cannot be called normally. Even if the website is displayed on web.archive.org

The Wayback Machine works by storing the crawled web site and rewrites all the resources referenced by the pages in oorder to make them available in case the original site is removed.
So, if your original page has links to other pages or images, for example:

Other Page

The Wayback Machine rewrites it to:

Other Page

The files downloaded by the wbm-dl are the original ones and not the Wayback Machine rewritten versions.
The image files and the pages, however, are still downloaded but the references in the html files now point to the original site.

The Wayback Machine works by storing the crawled web site and rewrites all the resources referenced by the pages in oorder to make them available in case the original site is removed.
So, if your original page has links to other pages or images, for example:

Other Page

The Wayback Machine rewrites it to:

Other Page

The files downloaded by the wbm-dl are the original ones and not the Wayback Machine rewritten versions.
The image files and the pages, however, are still downloaded but the references in the html files now point to the original site.

Well, I think about how to use script to deal with


/v2/accounts/account_id/jettons/history always returns empty array

/v2/accounts/account_id/jettons/history method always returns an empty array.
{"events":[],"next_from":0}
Tried with multiple addresses.
Am I doing something wrong or this method has some bugs / not well documented?
I'm using tonapi public instance of this API.

/v2/accounts/account_id/jettons/jetton_id/history
Works fine

UQC_ArdNU14F77YEN_Ru2q_P7i3c0H-M1oCWSldXwIxPQbsP


camera parameters

Hi, thanks for sharing.
Could you tell me how did you calculate the camera parameters, such as fl and c_p?

@XiumeiChen  Hi, for original integral pose regression, we use the camera parameters provided by HM3.6M. For ECCV challenge, we project & back-project between 3D and 2D based on weak perspective.

@lck1201 thank you. But I still have difficult with getting the camera params using H3.6m official tool. Does fl means the focal length, i.e. obj.f in H36MCamera.m, and obj.k for c_p?

@XiumeiChen  Yes, fl = focal length. And what do you mean obj.f, obj.k? Could you post some samples?

@XiumeiChen  It's clear obj.f = focal length= fl, and obj.c = center = c_p.  Please refer to [wiki] (https://en.wikipedia.org/wiki/Camera_resectioning) for more camera parameter knowledge.


Problem while trying to open different parts of the SBOL document

I've created a genetic toggle switch. First the LacI Inverter part, then the TetR Inverter part.
Afterward, I've created a new part, placed two engineered regions, and placed both parts in this new part. I can successfully zoom into the parts, and the LacInverter and TetRinverter are in place.
But, if I try to click the "Open a part from this document" button, the following error pops-up and then nothing else happens, not letting me open the different parts of the document:
sbol-13206: Best Practice Warning:
The format property of an Attachment SHOULD contain a URI that refers
to a term from the EDAM ontology.
Reference: SBOL Version 2.2.1 Section 7.13 on page 52:
https://synbiohub.programmingbiology.org/public/Cello_Parts/attachment_00009WRPR2gZAT2e0UjRL6/1

I'll see if Pedro can show me on Monday.
-Sam
On Fri, Sep 7, 2018 at 3:20 PM cjmyers<EMAIL_ADDRESS>wrote:

@SamuelSauce https://github.com/SamuelSauce @michael13162
https://github.com/michael13162 can you have Pedro show you this one?
Seems the warnings are actually preventing loading. We should probably turn
off the additional checks when validating a file that you open in
SBOLDesigner. Maybe we can add a validate SBOL option to run a more
comprehensive check manually.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SynBioDex/SBOLDesigner/issues/306#issuecomment-419568916,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV89xXgylFVS3szR6nKVazqBonFvuGiQks5uYuM0gaJpZM4Wdc7D
.

I'll be here.. I mean in the lab
On Fri, Sep 7, 2018 at 4:06 PM SamuelSauce<EMAIL_ADDRESS>wrote:

I'll see if Pedro can show me on Monday.
-Sam
On Fri, Sep 7, 2018 at 3:20 PM cjmyers<EMAIL_ADDRESS>wrote:

@SamuelSauce https://github.com/SamuelSauce @michael13162
https://github.com/michael13162 can you have Pedro show you this one?
Seems the warnings are actually preventing loading. We should probably
turn
off the additional checks when validating a file that you open in
SBOLDesigner. Maybe we can add a validate SBOL option to run a more
comprehensive check manually.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/SynBioDex/SBOLDesigner/issues/306#issuecomment-419568916
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AV89xXgylFVS3szR6nKVazqBonFvuGiQks5uYuM0gaJpZM4Wdc7D
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SynBioDex/SBOLDesigner/issues/306#issuecomment-419578646,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALq3fKgKa3C-BXKyfL0kbhLVGYBnmJtTks5uYu3sgaJpZM4Wdc7D
.


AP-3572: Update merits task handling

What
Link to story
Ensure new questions required by section 8 are ignored unless the feature flag is set
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

@jsugarman I'm going to add a temp commit to link to the equal PR in LFA - once UAT is complete I'll delete it again 👍


Update Modal

Description

Extract AgreeTerm page's Dialog into a common component that will be moved into czifui after V2
Add Dialog support for narrow prop, since we need it for the Tree
Use the Dialog for both modals in our app, outlink to Nextstrain.org and AgreeTerm page

Issue
https://app.clubhouse.io/genepi/story/136483/convert-the-tree-linking-frontend-component-box-into-a-real-modal
Test plan

Visit https://thuang-update-modal-frontend.dev.genepi.czi.technology/data/phylogenetic_trees
Log in as one of the test accounts
Clicking on the Tree Name cell in any row should pop up the dialog
If you scroll all the way to the bottom of the table and click on another Tree Name, the modal should still work
In RDEV, it seems like out link to Nextstrain.org doesn't work?

Thanks for the quick review, @lvreynoso ! Merging after all checks pass!


Change module names

Get rid of "lib" prefix, "d" postfix, and change suffix to ".b9mod"

While you're at it, we should update the instructions to use the new module names.


Fix varsize allocator

previously if alloc with is_contiguous = true, we will not try other portion if current portion do not have space. This is wrong as contiguous was ensured by get_next_contiguous_n_reset_bits.
This commit fixed the behavior as well as improving logging correctness, before the fix we un-conditionally change a new portion and log a misleading log "alloc direct unable to find in prev portion" even when alloction is success.
MetaBlkMgrTest::recovery_test is a victim of this bug as it tries to use up all the space of meta vdev and will easily hit the case of one portion full.

I am not quite familiar with varsize allocator. i will take some time to understand the implementation, and then leave my comment

@xiaoxichen can you also paste the error stack here?


Changes necessary for smooth score animations

Allow multiple FlapViews to turn at the same time
Add support for a placeholder symbol

The symbol is replaced by a swapSymbol in UI
Support for a different textColor for these characters
TokenGenerator skips the placeholder when iterating

created this pr in error.


Delay with CA Istio

In an EKS cluster with private node group setup, registering entities in CA with istio gateway causing delay (almost 5 mins to register one peer).
However, registering with CA without istio setup and opening all TCP in the cluster node gives immediate response. Works fine.
Appreciate any help. Thank you.

Hi @rijoblockchain
Can you give more insights about your environment? Are other services inside your cluster working correctly?

@rijoblockchain
I'm closing the issue, please; if the issue remains active open another issue or join the discord.


operator-sdk init fails: only the go.mod and files with the prefix "(.)" are allowed before the init

Bug Report
The problem reported in issue #4355 is still a problem in operator-sdk v1.4.2. The issue has been closed but the problem hasn't been fixed.
What did you do?
~ operator-sdk init --domain=example.com --repo=github.com/example/memcached-operator
Error: failed to initialize project with "go.kubebuilder.io/v3": only the go.mod and files with the prefix "(.)" are allowed before the init

What did you expect to see?
Successfully initialize the project
What did you see instead? Under which circumstances?
Script fails because the directory is not completely empty. Directories like .git and .idea cause the script to fail.
Environment
Operator type:
/language go
Kubernetes cluster type:
OpenShift
$ operator-sdk version
operator-sdk version: "v1.4.2"
$ go version (if language is Go)
go version go1.15.8 darwin/amd64 (because Go v1.16 also doesn't work; see issue #4610)
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0", GitCommit:"18d7461aca47e77cefb355339252a8d4c149188f", GitTreeState:"clean", BuildDate:"2021-01-30T16:44:37Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.3+e574db2", GitCommit:"e574db2", GitTreeState:"clean", BuildDate:"2021-01-30T06:33:00Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Possible Solution
Ignore hidden directories like .git and .idea, the SDK should work anyway.
Also, don't close issues without fixing the problem and releasing a new version of the SDK with a fix.
Additional context
None.

This has already been targeted in kubebuilder (the scaffolding library used underneath) to be a bit more permissive with which files are allowed. Directories and files starting with ., go.mod, go.sum, README.md and LICENSE are allowed.
.git and .idea would fall under the directories starting by ..
Once SDK bumps the kubebuilder version, which is probably gated behing kubebuilder v3 release, these changes will be applied.

This should be fixed by the latest version of Kubebuilder that will be included in 1.6.0 of Operator-sdk. Please reopen if not.


Kustomize plugin produces extra non-YAML output which prevents piping

The Kustomize plugin produces a few lines of info/debug output at the top of its stdout. Example:
Running khelm 2.0.0-alpha.1-dev-b455984 (helm 3.4.1)
WARNING: using untrusted repository "https://helm.releases.hashicorp.com"
Downloading repository index of https://helm.releases.hashicorp.com
Downloading chart vault 0.8.0 from repo https://helm.releases.hashicorp.com
Rendering chart vault 0.8.0 with name "vault" and namespace "vault"
Rendering chart vault 0.8.0 with name "vault" and namespace "vault"
apiVersion: v1
kind: ServiceAccount
metadata:

Te first size line aren't valid YAML which prevents piping to kubectl, e.g. kustomize build --enable-alpha-plugins path/to/kustomization | kubectl apply -f -
Is there an option to disable this output, of some other approach to using khelm that isn't documented?

My bad, I'm running kustomize from inside a Docker container and trying to pipe the output of the container to my local kubectl. Docker mixes stderr and stdout together, so that's my problem.

Yes, somehow the stderr ended up within stdout in your case. Though docker wouldn't do that by default.
Since you render your manifests within a container anyway I recommend to use a kpt-based workflow for which I also provided some examples - actually these are kustomize functions since the kpt function functionality is maintained within the kustomize repository but kustomize itself doesn't use it yet. kpt fn run . streams manifests via stdin into a docker container that runs a function, receives its output via stdout and writes it to disk (where you could commit it to your git repo and apply GitOps practices and/or apply it to a cluster using either kubectl apply . or better kpt live apply . which also supports pruning).
This way you can also avoid dealing with a single bloated container image that contains all kinds of binaries (kustomize+khelm plugin+...) with different versions but instead have one image for each binary.

Thanks for the suggestion. I've been meaning to look into kpt, and the approach of committing the output of the hydrated Helm file is attractive -- I prefer to have (some version of) the actual YAML manifests committed, as opposed to a complete abstraction.

Yes, somehow the stderr ended up within stdout in your case. Though docker wouldn't do that by default.

Technically it's running in a docker-compose-managed container, so  possibly that is different. I know that docker logs will mix stderr and stdout, so I guess it makes some sense. But like you said, I've never noticed it before.


Bundling fails on 2.21.0

Bug description
After upgrading to 2.21.0 and running ESBuild to bundle, a new error occurs:
> ../../common/temp/node_modules/.pnpm/@prisma+client@2.21.0_prisma@2.21.0/node_modules/@prisma/client/runtime/index.js:24152:23:
error: Could not resolve "_http_common" (mark it as external to exclude it from the bundle)
24152 │   var common = require("_http_common");

and
"var runtimeRequire =
  typeof __webpack_require__ === 'function' ?
     __non_webpack_require__ : require // eslint-disable-line"

How to reproduce

Install Prisma and ESBuild using PNPM.
Run prisma generate
Run esbuild app.js --bundle --platform=node --target=node14
See error

Expected behavior
Prior to 2.21.0 bundling was successful.
Prisma information
// Datasources
datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

// Generators
generator client {
  provider      = "prisma-client-js"
  binaryTargets = ["debian-openssl-1.1.x", "linux-musl", "windows", "darwin"]
}

ESBuild config
module.exports = {
  bundle: true,
  minify: false,
  format: "cjs",
  keepNames: true,
  sourcemap: true,
  platform: "node",
  logLevel: "error",
  target: ["node14"],
  external: ["fsevents"],
  outfile: "dist/run.js",
  entryPoints: ["src/index.ts"],
  metafile: false,
  loader: { ".prisma": "file" },
}

Environment & setup

OS: Windows
Database:  Postgres
Node.js version: v14.16.0
Prisma version: v2.21.0

Can you share an example script on how to reproduce this?

I have a similar issue with @m-abdelwahab Im using serverless-bundle which uses webpack it was trying to find a module to bundle I needed to ignore the package _http_common for bundling so it work.

A repro we could clone and try out ourselves would be greatly appreciated!

Next steps:

Try upgrading undici and see if that fixes it.

@matthewmueller is a private project but I can refer to the core issue, webpack tries to find a package in package.json but without result, as it's a native node.js module and it generates its own package.json where the version of "_http_common" is empty (as it didn't find a package there).
serverless-bundle on a build flow uses yarn install --non-interactive --frozen-lockfile and as the version is missing it crashes.
Ignoring helped just not add it to package.json with an empty string for a version. This way I solved the issue but it's a hack than a solution.

A repro we could clone and try out ourselves would be greatly appreciated!

Lol sorry, I left the <!-- in the original ticket, just removed it now.

Install Prisma and ESBuild using PNPM.
Run prisma generate
Run esbuild app.js --bundle --platform=node --target=node14
See error

@matthewmueller is a private project but I can refer to the core issue, webpack tries to find a package in package.json but without result, as it's a native node.js module and it generates its own package.json where the version of "_http_common" is empty (as it didn't find a package there).
serverless-bundle on a build flow uses yarn install --non-interactive --frozen-lockfile and as the version is missing it crashes.
Ignoring helped just not add it to package.json with an empty string for a version. This way I solved the issue but it's a hack than a solution.

I thought this had solved it for me as well, but one of the modules in my monorepo is actually instantiating a http node server, so it breaks now as the native Node http module has been excluded.

I have a similar issue with @m-abdelwahab Im using serverless-bundle which uses webpack it was trying to find a module to bundle I needed to ignore the package _http_common for bundling so it work.

@larrybek , I have the same issue. New to webpack though. can you advise how you ignore the package?
Thanks
James

@JamesForan I have been using serverless-bundle which has initial functionality called forceExclude but I know that its underneath is using webpack so there's an option that this parameter is somehow passed to webpack. You can have a look on it, and it may give you some idea.

We are waiting for undici to release v4, in the meantime you could mark their internal dependency as external with --external:_http_common.

@millsp Any recommendations of a workaround in the meantime?

How should i be dealing with my webpack.config? (using serverless + prisma)

^ target: 'serverless' is not supported. what webpack version are u using?
Error: Unknown target 'serverless'

@mubaidr It is for next js. Ignore it if you are not using next js.

In your webpack.config.js, add externals: ['_http_common', 'encoding'],

@millsp I run prisma on electron. The suggest workaround seems to work. Thanks. I just upgraded to v2.23.0. If I encounter any more issues related to this specific problem I will follow up. Are those dependencies not used undici? Or are they used by undici but the functionality that prisma needs from undici does not invoke those dependencies? Just trying to understand the scope of possible issues to come. I am guessing by defining them external, they are not being bundled which may cause various problem down the line.

_http_common is a private module built into node js itself, just like fs or util. It is not a publicly documented API. It was used by undici to improve http parsing performance but looks like they no longer need it in the latest release candidate version. undici is maintained by Node JS folks so they know about this undocumented private module pretty well. So that is why you don't need to bundle it as it is built into the runtime.

Workaround for you today

Mark _http_common external. It will still work as expected

Permanent Fix

[ ] Wait until undici@4 is out
[ ] Bump to unidici 4, test and try again

With webpack 5, simply adding '_http_common' to an array in the externals build option wasn't enough for me, I had to specify it this way:
{
  // ...
  externals: {
    "_http_common": "commonjs2 _http_common",
  }
}

With webpack 5, simply adding '_http_common' to an array in the externals build option wasn't enough for me, I had to specify it this way:
{
  // ...
  externals: {
    "_http_common": "commonjs2 _http_common",
  }
}

thank you...I was really struggling with this issue while using turbo repos with next js..but this resolved it.....

Hey everyone, this has been fixed in @prisma/client@dev if you want to give it a try. Please let us know if you find anything unexpected. Thanks.
(cc @prescience-data @ra-kesh @trivigy)

I can confirm that "@prisma/client": "^3.12.0-dev.28" works. Thanks @millsp !


ImagePicker not working on Ionic 2 Android (Logcat)

08-15 17:13:40.505 25135-25135/? D/CordovaLog: file:///data/user/0/com.ionic.viewapp/files/files/3ea0b067/build/js/app.bundle.js?ionicCachebuster=29201: Line 105016 : Install the ImagePicker plugin: 'ionic plugin add cordova-plugin-image-picker'
08-15 17:13:40.505 25135-25135/? I/chromium: [INFO:CONSOLE(105013)] "Native: tried calling ImagePicker.getPictures**, but the ImagePicker plugin is not installed**.", source: file:///data/user/0/com.ionic.viewapp/files/files/3ea0b067/build/js/app.bundle.js?ionicCachebuster=29201 (105013)
I had already install the image picker but still not working.
Plugin "cordova-plugin-image-picker" already installed on android.
Plugin "cordova-plugin-image-picker" already installed on ios.

Same issue here. Did you manage to solve it somehow?

i have the same problem

It's broken with Android 6+, switch from Cordova wymsee/cordova-imagePicker to Telerik-Verified-Plugins/ImagePicker or look into the pull requests.

i found a way to solve this problem:
if you use imagePicker.getPictures() then it crashed,
the problem is that you have no READ_EXTERNAL_STORAGE for that,
so should turn on the permission by yourself,or use the plugin(cordova-plugin-android-permissions) to have this permission,
there is my code
//requestPermission
var permissions = cordova.plugins.permissions;
permissions.requestPermission(permissions.READ_EXTERNAL_STORAGE, success, error);
function error() {
console.warn('Camera permission is not turned on');
}
function success( status ) {
if( !status.hasPermission ) error();
}
//choose picture
window.imagePicker.getPictures(
function(results) {
for (var i = 0; i < results.length; i++) {
console.log('Image URI: ' + results[i]);
}
}, function (error) {
console.log('Error: ' + error);
}
);
and it works well

I do not know if this solution works for that case, I had an error that appeared a broken image icon and I selected the images and did not show them I used these commands
ionic cordova platform remove android
ionic cordova platform add android
so solve the error of the broken image icon and the plugin image picker functioned correctly again.


top two rules unclear

`<list(X, SEP)> ::=

X
X SEP <list(X, SEP)>
<list1(X, SEP)> ::=
X
X SEP <list(X, SEP)>`
the first two rules they don’t seem to be part of the standard BNF syntax
e.g. <list(X,SEP)> this looks like a template for a rule, I can’t seem to locate this in the official BNF syntax.
I am trying to parse the grammar in ANTLR4 and it seems to not recognize the first two rules which have this syntax. Typically an BNF rule id is meant to just be a string of chars with ‘-’ or numbers
(according to the antlr grammar for BNF this is what an ID is supposed to be made of:
id_
: LT ruleid GT
;
ruleid
: ID
;
ID
: (‘a’…‘z’|‘A’…‘Z’) (‘a’…‘z’|‘A’…‘Z’|‘0’…‘9’|’-’|’ ')+
;
and a rule is
rule_
: lhs ASSIGN rhs
;
where the ASSIGN is ::==
ASSIGN
: ‘::=’
;
So a little lost here, what syntax do the first two rules follow, they almost look like meta-rules. Is the tool that generates them something internal or open source?

These syntax descriptions resemble EBNF, but were generated from the menhir grammar in src/mo_frontend/parser.mly.

Menhir also has an option to produce a yacc compatible grammar from the menhir grammar, if I recall correctly.
http://gallium.inria.fr/~fpottier/menhir/ is the tool we use.

If it helps (not sure it will, unless Rust is familiar), but we are in the process of making another, totally compatible reference implementation in Rust.
This part is relevant for translating that aspect of the existing parser.  Very WIP.


How to pass parameters to publish function?

Before using meteor-tabular this was my publish function:
Meteor.publish("PageItems", function (pageId) {
    check(pageId, String);

    return PageItems.find({ pageId: pageId });
});

To use meteor-tabular I changed it to:
Meteor.publish("Tabular_PageItems", function (tableName, ids, fields) {
  check(tableName, String);
  check(ids, Array);
  check(fields, Match.Optional(Object));

    return PageItems.find({ pageId: pageId });
});

However pageId would be undefined. So how can I pass pageId into the publish function in order to limit the results being subscribed to?
There doesn't seem to be any way to pass parameters when subscribing:
TabularTables.Pages = new Tabular.Table({
    name: "Pages",
    collection: Pages,
    pub: "Tabular_PageItems",

I know that it's possible to subscribe to the entire collection and filter on the client, however that would be a security risk and inefficient. Only what is needed by the client should be subscribed to and nothing more.

+1

+1

+1

+1

This is what the selector is for: https://github.com/aldeed/meteor-tabular#displaying-only-part-of-a-collections-data-set

I did see that but it's not clear, which is why I created this Issue in the first place.
Based on my understanding of using the selector, this is how the code should be:
Meteor.publish("Tabular_PageItems", function (tableName, ids, fields) {
  check(tableName, String);
  check(ids, Array);
  check(fields, Match.Optional(Object));

    return PageItems.find();
});

... and the selector in the constructor:
TabularTables.Pages = new Tabular.Table({
    name: "Pages",
    collection: Pages,
    pub: "Tabular_PageItems",
    selector: function (pageId) {
        return { pageId: pageId };
    },

Though since the filtering must be done on the server (not client-side), it's a little strange to see
    return PageItems.find();

in the publish function, as it appears that the entire collection is being published.
How or where exactly would the value of pageId be passed into the constructor so that only items of a particular page would be published from the server?

@tab00 See description of what custom publish function must do in readme: https://github.com/aldeed/meteor-tabular#using-a-custom-publish-function
So PageItems.find() should be PageItems.find({_id: {$in: ids}}, {fields: fields}). But that's no different than the built in function so if you're not joining additional data, you probably don't need it.
It uses a two-step publication. The first one, which you can't customize, is what actually uses the selector. At that point we already have a list of IDs, which are passed into the second publish function, the one that can be customized if you need to join data.
The selector used by the first publish function is your client selector attribute + selector option on the table (for secure server selector), and then that is run through changeSelector function if there is one, for additional security.

I've just figured out that selector always takes the value of userId as it's input parameter value. The Readme documentation does not state such a fact, which has caused part of the confusion. e.g. if I wrote:
    selector: function (x) {
        console.log("x", x);
        return { };
    },

the output would be the logged in user's ID.
So does this mean in the selector we cannot filter using any other field, and that what I wrote above is not possible?:
selector: function (pageId) {
        return { pageId: pageId };
    },

Also, I should explain a bit more of what I have and want. I have 2 collections in a parent-child relationship: Pages, PageItems. Here are the schemas:
    Schemas.Page = new SimpleSchema({
        userId: { ... },
        name: { ... },
        description: { ... },
        ...

    Schemas.PageItem = new SimpleSchema({
        pageId: { ... },
        name: { ... },
        description: { ... },

In the Tabular table, I want to show a list of PageItem documents for a particular pageId value.
The value of pageId is taken from a dropdown list that contains a list of Pages that is filtered by userId.
This works fine without using Tabular, using this publish function:
Meteor.publish("pageItemsPage", function () {
    var cursorPages = Pages.find({ userId: this.userId });
    var pageIds = _.pluck(cursorPages.fetch(), "_id");
    var cursorPageItems = PageItems.find({ pageId: { $in: pageIds } });

    return [cursorPages, cursorPageItems];
});

Notice that the return value is an array of cursors, which makes it so easy, without needing to use publishComposite.
Another thing I would like to point out is that Your AppFeedBack example shows the use of Tabular with PublishComposite, with AppFeedBack being the parent collection and users the child, and, importantly, AppFeedBack field values being the data you want to show. Field values of the child collection displayed using helpers.
In my case, Pages is the parent, PageItems is the child, and I want to show PageItems field values in the table, not Pages field values. This is different to your example in which you show the parent collection's field values. So would I have to do these:
Write this publishComposite function:
Meteor.publishComposite("tabular_Pages_PageItems", function (tableName, ids, fields) {
    check(tableName, String);
    check(ids, Array);
    check(fields, Match.Optional(Object));

    return {
        find: function () { return Pages.find({ _id: { $in: ids } }, { fields: fields }); },
        children: [
          {
              find: function (page) { return PageItems.find({ pageId: page._id }); }
          }
        ]
    };
});```

Set `collection: Pages` (instead of `collection: PageItems`) in the Tabular.Table constructor
```javascript
TabularTables.PageItems = new Tabular.Table({
    name: "PageItems",
    collection: Pages,
    pub: "tabular_Pages_PageItems",
    selector: function (userId) {
        return { userId: userId };
    },
    columns: [
      { data: "name", title: "Name" },
      { data: "description", title: "Description" },
      { data: "pageId", title: "pageId" },

... and then write a helper for each child collection field that I want to show as a table column? That would be extremely inconvenient. Is there any other way to show the field values of PageItems using data: in the columns array?

@tab00 The problem is that you are trying to use the wrong selector. The selector table option is for limiting the selector on the server, like for security reasons. The selector attribute of your table template is for providing a reactive selector based on user choices on the client. So use the example at the top of this section: https://github.com/aldeed/meteor-tabular#displaying-only-part-of-a-collections-data-set But where it says {author: "Agatha Christie"} you would do {pageId: userSelectedPageId.get()} (assuming storing the selection in a ReactiveVar called userSelectedPageId), and then when drop down changes you would do userSelectedPageId.set(idFromDropDown).

OK you are right, I need a client-side selector that is set based on the dropdown list value.
Can you also respond to my query about showing child collection field values instead of parent collection field values using Tabular? As I showed above, it was quite easy without Tabular using a publish function that returns an array of cursors.

@tab00 I think you only need to flip the parent child in your example. Do PageItems.find({ _id: { $in: ids } }, { fields: fields }) for the find and do Pages.find({ _id: pageItem.pageId }) for the children. It does not matter that the "child" is actually the "parent".

If I set collection: PageItems, how would I use the server-side selector function for security which takes userId as input parameter? PageItems does not have a userId field. Pages does.

Switching Pages and PageItems in the publishComposite function works, however I'm also finding that executing PageItems.find().fetch() client-side returns all documents, including those of Pages of other users! That would be a security disaster.
When I remove {{> tabular table=TabularTables... from the template and use the publish function that I was using before (and shown again below), only the documents of the Pages of the logged-in user is returned as it should. So what's going wrong?
Meteor.publish("pageItemsPage", function () {
    var cursorPages = Pages.find({ userId: this.userId });
    var pageIds = _.pluck(cursorPages.fetch(), "_id");
    var cursorPageItems = PageItems.find({ pageId: { $in: pageIds } });

    return [cursorPages, cursorPageItems];
});

OK, I didn't know about the userId thing. The only way probably is to add userId to PageItems, too, and then do a server selector that does {userId: this.userId}.

Hey there!
I have some publication. eg following:
Meteor.publish('orders', () => {
  const transactionsIds = Transaction.find({success: true}).map(t => t._id);
  return Orders.find({transactionId: {$in: transactionsIds}})
});

I've tried to use reywood:publish-composite. It doesnt works for me - table doesn't displays the data.
How get it working with tabular?
looking forward for your answer :)

@aldeed , I opened a new issue but it might be the same one that everyone here is experiencing. #349
Was there any resolution as to why the table doesn't display? (as @NazarYablonskiy stated)


enabled for PSTAlertAction

Hello,
First of all thank you for this library!
I should disable button, for some text field conditions, as alertViewShouldEnableFirstOtherButton is not available for UIAlertController, as solution enabled state can be used. Do you have in plans to do this?

I too am very interested in this feature! =)

Hello @Arvkon, You can check this fork:
pod 'PSTAlertController', :git => 'https://github.com/Igor-Palaguta/PSTAlertController.git'


toothpaste.json

this is a new measure for toothpaste prescribing.
ebmdatalab.dmd.form_dose - is this the correct file to be using?

One more thing -- you'll need to rename the file to toothpaste.json.

One more thing -- you'll need to rename the file to toothpaste.json.

Is it simply the file name via the edit button (see below)? Or do I need to change the branch name?

One more thing -- you'll need to rename the file to toothpaste.json.

Is it simply the file name via the edit button (see below)? Or do I need to change the branch name?

No need to change the branch name.


Routes that don't have a response body are not handled correctly

If you have a route with no response() or response(rt.Void), you have to manually call res.sendStatus(200). Otherwise the route doesn't work. Or am I missing something?

You always wanna return something. It could be an empty string for instance.
The drawback with Promise-based handlers is that there isn't a clear way to say "propagate the call down the handler chain", as one usually does with express' next callback.
So this module won't terminate the request if you return undefined. Instead, it propagates the call down the handlers chain.

Or, as you've noticed, you can manually terminate the handling by using methods of the response object. Note that you'll lose type safety if you chose to do so.

Ah, okay. Thanks for the clarification.

Would be nice to add this to the documentation in #4


(Resubmit of #230) Fix setup.py readme and version path references

Rebase of #230 on master to enable merge.

Subpackage's setup.py files now resolve paths to README.md and _version.py relative to the setup.py, instead of where pip or python setup.py install is called. Enables installing subpackages without changing the current working directory to a subpackage's root (where setup.py lives).

https://github.com/NOAA-OWP/DMOD/pull/230#issue-1519389162
closes #230

Receiving same test failure as #244. See #244's checks.

Those failures (which all related to dmod-evaluations) are quite odd, by themselves and because I don't encounter them locally.  For this, I think it's safe to ignore them.


GCC-11: Set DWARF to version 4 and ignore array bound warnings for generated syscalls functions

GCC 11 defaults to output DWARF version 5 which pyelftools cannot currently parse. So keep output at version 4 for the time being.
Compilers and static code analyzers do not understand Zephyr's syscall mechanism so they always complain about out of bound array access inside the generated syscall header functions. So add a flag for GCC to ignore this type of warning for these functions.

Related to #35707

@tejlmand I am not sure about where to put -gdwarf-4. Please let me know if it is incorrect so I can move it.


Fix autofill not opening when tapping on email field in SupaEmailAuth

What kind of change does this PR introduce?
Adds an AutofillGroup to the email sign in form
What is the current behavior?
Fixes #79
What is the new behavior?
Activating the email field will now propt for autofill data, selecting an entry from the password field will also fill the email field.

Thanks for this. So this PR just pretty much wraps the Form with a AutoFillGroup, correct?

exactly.
I'll see if I can figure out what went wrong with the formatting tomorrow. I use dartfmt on save, so maybe our styles are clashing.

Nothing went wrong as far as I can tell. Since the Form is wrapped in another Widget it's just indented one more layer. Combined with moving the content down one line Github gets very confused detecting changes.
I'll add the same changes to the PhoneAuth Widget as well, since it's the same kind of identifier+password combo

Nothing went wrong as far as I can tell. Since the Form is wrapped in another Widget it's just indented one more layer. Combined with moving the content down one line Github gets very confused detecting changes.

Ignore this, I didn't even notice the action fail.