R lines do not return data read by an application, but a buffer of all not-yet read data

It looks like the PortSniffer does not return actual data read by an application using the monitored port.
PortSniffer repeatedly returns what looks like some sort of buffer of all data available to be read from the port.
That makes it difficult to reconstruct when an application actually read data from a device.
Running PortSniffer from ENLYZE-PortSniffer-1.2-x86.zip archive on Win10 32-bit computer with USB connected GSM modem using following command: PortSniffer-Tool.exe /monitor COM7 RW
Lines with W appear correct.
There seems to be a bug with R lines - they are either 1 byte long or 4084 bytes long.
Lines with length 1 often contain correct data, but sometimes one is repeated many (500+) times.
The lines with length 4084 are repeated few times. Most of the line is 00 until the end of line.
Later copies sometimes have few bytes at the beginning removed, and corresponding 00 bytes appended at the end.
It appears that:

available data (not yet read by an application) are repeatedly returned as R lines (that also explains repeated 1 byte lines).
data are returned as a buffer of all available data (expanded to buffer size used for read with zeros, and capped to about 4k)

Not a windows driver developer, but it looks like:
https://github.com/enlyze/PortSniffer/blob/b690de9819c83d4555d2e5420274c7b170cbd077/src/driver/EnlyzePortSniffer.c#L877
uses the whole provided buffer, which is forwarded here:
https://github.com/enlyze/PortSniffer/blob/b690de9819c83d4555d2e5420274c7b170cbd077/src/driver/EnlyzePortSniffer.c#L852-L853
It ignores the possibility that read request size is different from buffer size - which would explain observed behavior.
(I have no idea if buffer size is determined by the underlying COM port driver or somehow depends on application read request size)
Not sure if overwriting readWorkItemContext->ReadBufferLength with something like min(readWorkItemContext->ReadBufferLength, Params->Parameters.Read.Length) and possibly renaming to ReadBufferResponseLength would be enough or not.
Also not sure if Params->Parameters.Read.Length at that point is actually the same value as the original read request's length:
https://github.com/enlyze/PortSniffer/blob/b690de9819c83d4555d2e5420274c7b170cbd077/src/driver/EnlyzePortSniffer.c#L777

Hello @otopetrik. Thanks a lot for your bug report!
You are totally right, reads may only be partially completed or not successful at all. PortSniffer 1.2 didn't take that into account.
I have opened a Pull Request in #3, which fixes this issue similar to what you described. I'm using Params->Parameters.Read.Length now instead of the buffer length returned by WdfMemoryGetBuffer.
To make things clearer, the field in readWorkItemContext is now called BytesRead instead of ReadBufferLength.
I'm also no longer logging unsuccessful reads (with 0 bytes) at all.
Please check the binaries I uploaded in #3. If they fix your problem, this will become PortSniffer 1.3.

Hello @ColinFinck.
Thanks for the fix and the binaries !
Tried the "ENLYZE-PortSniffer-1.3pre-x86.zip" and it works.
Where version 1.2 produced 100+ KiB logs with repeated data, this version produces logs around 10 KiB.
Converted to text, the new/smaller log looks correct - it contains only AT commands written and responses read.

Cool! I've just released the final version 1.3 incorporating this fix :)


Uncaught asynchronous error from needle

There is a problem with an uncaught asynchronous error in the needle library which crashes the whole node process. Your library is doing just what I need for checking many links but this problem makes it impossible to use unfortunately. Unless needle is fixed, I suspect you may need to look for an alternative as I can't find a way to catch this error, even in your code.
I have also created an issue for needle: https://github.com/tomas/needle/issues/410
Example URL: https://wayback.archive-it.org/3259/20160318141818/http://www.arc.gov/research/MapsofAppalachia.asp?MAP_ID=11
Header: content-type: text/html; charset=maccentraleurope
.../node_modules/needle/node_modules/iconv-lite/lib/index.js:104
                throw new Error("Encoding not recognized: '" + encoding + "' (searched as: '"+enc+"')");
                ^

Error: Encoding not recognized: 'maccentraleurope' (searched as: 'maccentraleurope')
    at Object.getCodec (.../node_modules/needle/node_modules/iconv-lite/lib/index.js:104:23)
    at Object.getDecoder (.../node_modules/needle/node_modules/iconv-lite/lib/index.js:125:23)
    at Object.decodeStream (.../node_modules/needle/node_modules/iconv-lite/lib/index.js:156:55)
    at StreamDecoder._transform (.../node_modules/needle/lib/decoder.js:39:26)
    at StreamDecoder.Transform._read (_stream_transform.js:190:10)
    at StreamDecoder.Transform._write (_stream_transform.js:178:12)
    at doWrite (_stream_writable.js:415:12)
    at writeOrBuffer (_stream_writable.js:399:5)
    at StreamDecoder.Writable.write (_stream_writable.js:299:11)
    at IncomingMessage.ondata (_stream_readable.js:710:20)
    at IncomingMessage.emit (events.js:203:15)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at IncomingMessage.Readable.push (_stream_readable.js:224:10)
    at HTTPParser.parserOnBody (_http_common.js:124:22)
    at TLSSocket.socketOnData (_http_client.js:451:20)
    at TLSSocket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at TLSSocket.Readable.push (_stream_readable.js:224:10)
    at TLSWrap.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

Is this outdated and fixed?

I haven't had an opportunity to test this but it looks like the underlying problem was fixed in<EMAIL_ADDRESS>which was included in https://github.com/tcort/link-check/commit/9d1f24f3b1bcddd95a27fb5e54eed5e4c9c76609. So the 5.3.0 release 2 days ago should be good.

Sorry I forgot to come back to this and confirm the problem was sorted by the dependency upgrades.


Add more docs and examples to flags

Clarify what enable_only does exactly and give some examples setting flags. It's easy to forget these are actual bit flags that can be ORed together.

Thank you!


Add support for right-to-left messages

Add support for messages to be right to left. For example this:
اسم من به انگلیسی Shayan Toqraee است.
Should be showed like this:
اسم من به انگلیسی Shayan Toqraee است.
For more information, see the discussion at here.

@zulipbot claim

#2758 is a previous PR that aimed to fix this issue. (Thanks @Shayan-To !)
That PR didn't get finished because the author has been busy. We'd still love to have this issue resolved. Anyone is welcome to make a try at it -- just mention here first when you start doing so, to reduce the chance of duplicate work.
When attempting this issue, I recommend reading #2758; it looks like it contains a lot of the pieces that we'll want in a solution, and the review comments on it will be helpful too. Definitely borrow whatever pieces of that PR turn out to be helpful in a new PR.

@zulipbot claim

Hi, @im-adithya! I've assigned the issue to you. Please see Greg's comment, above, about a PR that likely has a lot of useful work you can borrow from. 🙂

Hi, @im-adithya! I've assigned the issue to you.

Thanks @chrisbobbe.

Please see Greg's comment, above, about a PR that likely has a lot of useful work you can borrow from.

Sure!


Dep Support

This patch introduces support for the official Go dependency management tool, Dep. Glide support has been removed in favor of the new, official tool.

Codecov Report

Merging #993 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   34.11%   34.11%
=======================================
  Files          36       36
  Lines        2896     2896
=======================================
  Hits          988      988
  Misses       1806     1806
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a556e8...ae3f3b4. Read the comment docs.

Hi @codenrhoden,

The pedant in me would want to see this split into two commits. One that replaces Glide with the same dependency versions (or as close to it as we can get) so we can see what changes in vendor/. Ideally switching it out would have minimal changes to vendor/. Then, a second commit that upgrades dependencies where we've chosen to do so.

So I did attempt to do this. The PR's commit should not introduce any new or updated versions of dependencies. The changes you see are due to the fact that I did not attempt to recreate a Gopkg.toml that is equivalent to the old glide.yaml file with explicit, transitive dependencies. You even mention this:

I think the hardest part in achieving that would be that we are going to back to having Gopkg.toml only list immediate dependencies, not transitive ones.

I'm going to spend 30 or so minutes to see if I am able to create a Gopkg.toml that is equivalent to the deprecated glide.yaml, transitive dependencies and all. At least then we should see an initial diff with the only changes being the manifest files and not vendor/. Mostly anyway. There is also an issue with the go-yaml dependency.

Hi @codenrhoden,
I'm going to add a second commit to this PR that updates the versions of the dependencies by virtue of undoing the overrides in Gopkg.toml. The reason I'm adding the commit to this same PR is so we can easily revert the PR in order to back out all these changes if Dep + stripping nested vendor breaks anything.

Awesome. I really like being able to see what versions changed between the two commits. And having the transitive deps out of the .toml file is a big win.
Scrolling through all the deps, I think the only thing I noticed is that we don't have Cobra as a direct dependency, so it gets pointed to master, which is a little surprising. Maybe something to think about locking down in the future.

Hi @codenrhoden,
I force pushed this PR with the second commit updated to reflect Cobra and PFlag as direct entries in the Gopkg.toml file per your suggestion. The reason for their absence in the first place is @spf13 and his project maintainers' decision to forego tagged releases. Without tagged releases the Cobra and PFlag dependencies simply point at master unless we lock them to a specific revision.


updated navigation to be dynamically generated via _data/navigation.yml

also added author to every blog postsother changes to come up..
 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

this looks fine to me


26.0.0 released but package.json version still at 25.0.0

@JustinBeckwith released 26.0.0 but package.json still has version 25.0.0 which I think is preventing the publishing to npmjs. NPMjs still has 25.0.0
If I missed something about the release process, disregard this, just wanted to point out the anomaly.
Thanks!

I've published v26.0.0 here https://atomist.jfrog.io/atomist/npm-dev/googleapis/-/googleapis-26.0.0.tgz until this gets sorted out.

Greetings folks!  We just cut a release which should fix the issue.  Apologies for the mixup!


Azure Pipeline - Makefile path issue

Hi,
Great job! I currently use one big bash script for creating multi-arch Docker images:
https://github.com/xirixiz/dsmr-reader-docker/
Currently I`m trying to adopt your way of working, which is working great localy, but I can't manage to get it work in an Azure Pipeline. Source code: https://github.com/xirixiz/dsmr-reader-docker/tree/new_build_process
Azure Pipeline log:
2020-02-03T12:33:02.3170325Z 2020-02-03 12:33:02 (3.54 MB/s) - qemu-aarch64-static.tar.gz saved [1675228/1675228]
2020-02-03T12:33:02.3171051Z
2020-02-03T12:33:02.3682140Z cp: 'qemu-aarch64-static' and '../qemu/qemu-aarch64-static' are the same file
2020-02-03T12:33:02.3688323Z Makefile:40: recipe for target 'fetch-qemu-aarch64' failed
2020-02-03T12:33:02.3691297Z make[1]: Leaving directory '/home/vsts/work/1/s'
2020-02-03T12:33:02.3691986Z make[1]: *** [fetch-qemu-aarch64] Error 1
2020-02-03T12:33:02.3692539Z Makefile:33: recipe for target 'qemu' failed
2020-02-03T12:33:02.3692831Z make: *** [qemu] Error 2

It seems that there's a difficulty with paths.  Perhaps you bumped into this before?

My bad, I've modified the source path to tmp/qemu, so copien it to ../qemu results in a copy to the path where the binary already is located.


could I choose cuda version in docker？

Issue summary
I download gnina docker and run it by
docker run --gpus all -it gnina/gnina:latest

but there was a error
docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: Running hook #0:: error running hook: exit status 1, stdout: , stderr: nvidia-container-cli: requirement error: unsatisfied condition: cuda>=11.7, please update your driver to a newer version, or use an earlier cuda container: unknown.
ERRO[0000] error waiting for container: context canceled

Steps to reproduce
I install a cuda12 for one user
and set bashrc with
 12 # User specific aliases and functions
 13 export CUDA_HOME=/home/jf/Programs/cuda12
 14 export PATH=$CUDA_HOME/bin:$PATH
 15 export LD_LIBRARY_PATH=$CUDA_HOME/lib64:$LD_LIBRARY_PATH

now the
which nvcc
~/Programs/cuda12/bin/nvcc

out correct
and nvidia-smi still out cuda11.0
so I wound if I can choice what cuda verision to use,
or If I can use another way to activate gpu support in docker
Your system configuration
Operating system:centos7
Compiler:
CUDA version (if applicable): cuda11.0
CUDNN version (if applicable):
Python version:

The drivers in the container need to be compatible with the drivers on the host.  You may have to build a container that is compatible with your environment.  Example docker files here: https://github.com/gnina/gnina/tree/master/docker


Load Phase Latency Stats Have Incorrect Units

Latency stats reported at the end of the load phase are reported as milliseconds, but the numbers are actually in microseconds.
This is because the calls to latencyStats.recordLatency in LinkBenchLoad and NodeLoader are made with latency times measured in nanoseconds, instead of microseconds as the method requires. The "timetaken" argument needs to be scaled by 1000 to convert from nanoseconds to microseconds.
This bug does not exist in latency reporting for the request phase. Those calls to latencyStats.recordLatency correctly convert from nanoseconds to microseconds before making the call.

Fixed by https://github.com/facebook/linkbench/pull/30
Thanks for the PR


Prerelease/2.2.0 stabilization -> dev

Overview
Merge Prerelease/2.2.0 stabilization -> dev

/azp run


cde-gtk-theme: small adjustments

Motivation for this change

Don't build on Hydra, its just a packed theme
Rename derivation from "cde-motif-theme" to "cdetheme", because theme folder name is "cdetheme", so there will be less confusion
I.e. user need to set "cdetheme" in their gtkrc, so lets name the derivation the same

    [Settings]
    gtk-theme-name=cdetheme

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/186

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/205

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/221

@romildo Thank you!


Name property does not include scope

The name property returned for Nodes does not appear to correctly report the scope-qualified name of the package.
For example, I see entries like this:
     Node {
       name: 'express',
       path: 'node_modules/@types/express',
       realpath: '/Users/luke/myapp/node_modules/@types/express',
       error: null,
       id: 1063,
       package: [Object],
       parent: [Circular],
       isLink: false,
       children: [] },

However, this package cannot be resolved with the name express, and should be reported as @types/express.

Not sure when this got fixed, but it appears to no longer an issue in the latest release.  Thanks!


Feat: Add the missing close icon for relevant components

Describe the feature
In the process of upgrading our website, it seems like the close icon for some components got removed......I want to add the icon back for all relevant components
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@mdazfar2 Please assign me this issue

@Asymtode712 assigned.


Incorrect .throw() result on generator with yield* to another generator with try/catch

Repro:
function* test() {
  try {
    yield;
  } catch (e) {
    return;
  }
}

function* wrap() {
  yield* test();
  yield 3;
}

var iter = wrap();
iter.next();
print(JSON.stringify(iter.throw(Error("fail"))));

Expected per spec is iterator result object { value: undefined, done: true } as yield* has a return completion value when received is a throw completion. However, v8/sm do differently and https://github.com/tc39/ecma262/issues/293 proposes changing the expected result to {value: 3, done: false } by returning a normal completion for this case.

The v8/sm semantics won the day here, so the expected result is {value: 3, done: false}.

This is failing a kangax test case as well.
print((function()
{
function * generator() {
  yield * (function * () {
    try {
      yield 'foo';
    }
    catch(e) {
      return;
    }
  }());
  yield 'bar';
}
var iter = generator();
iter.next();
return iter['throw']().value === 'bar';
})());

Can I tackle this issue?

@nicolo-ribaudo the 1.2 milestone bugs need to be fixed asap.  I'm happy to let you take a stab at it.  Please start on it immediately and let me know within the next couple of days what your plan for the fix is.
Let me know if you do not have enough time to complete this bug fix within the next week or so.  I will want to start on it first thing next week if that is the case.

@nicolo-ribaudo also note that the due date on the 1.2 milestone is a rough estimate.  Lockdown on our bug fixing for the next release may occur sooner which is why this needs to be addressed asap.

@ianwjhalliday I'm working on this now. Is it ok to move the call to the iterator's .next() method from the bytecode to the JavascriptOperators::OP_ResumeYield function? It probably will be a little less efficient, but I don't know if there is a way to know in the bytecode how the generator has been resumed.

Should this code throw?
function* gen() {
  yield* {
    [Symbol.iterator]() {
      return {
        next() { return { value: 3, done: false } },
        throw() { return 11; } // <-- 11 is not an object!!!
      }
    }
  };
};
var g = gen();
g.next();
g.throw(3);

Both Chrome and Firefox don't throw, and there is a test which ensures that this code doesn't throw, but the spec says:
YieldExpression: yield*AssignmentExpression
...
5.b. Else if received.[[Type]] is throw, then
    i. Let throw be ? GetMethod(iterator, "throw").
   ii. If throw is not undefined, then
        1. Let innerResult be ? Call(throw, iterator, « received.[[Value]] »).
        2. NOTE: Exceptions from the inner iterator throw method are propagated. Normal completions from an inner throw method are processed similarly to an inner next.
        3. If Type(innerResult) is not Object, throw a TypeError exception.

Yes, looks like that should throw TypeError.  Chrome and Firefox probably have the same bug.
Whoa.  I just read 14.4.14 for yield* evaluation.  The spec has changed a lot since @aneeshdk and I implemented yield*.  E.g. if the inner iterator does not have a throw method then we are supposed to throw a TypeError due to yield* protocol violation.  This is completely unfamiliar behavior to me, but it has been a long while now since I've read this part of the spec.
Sounds like our implementation of yield* needs to be redesigned to match the spec.
@nicolo-ribaudo sounds like you're investigating test cases to see the various browsers` behaviors versus the spec.  That's good.  What I would do in this case if I were tackling this right now is review our current test cases and update and add to them to reflect the new spec.  From there I would identify the different patterns that we are failing to implement, and anything we have implemented that is incorrect now.  With that knowledge I would finally visit designing the new implementation.
How do you feel about taking that approach?  Might as well also vet the return() behavior at the same time.

PR: #597

Fixed by #665


Clarify how common / critical writing vectors is in pins

Currently pins supports..

the writing of vectors and lists
to RDS and CSV
done via object_write function

For pins-python, how important are these behaviors? What should they produce?
Example
library(pins)
board <- board_folder("r-pins-test", versioned=TRUE)

# writes an RDS
board %>% pin_write(1:3, "vector")
board %>% pin_read("vector)
# [1] 1 2 3

board %>% pin_write(1:3, "vector2", type="csv")
board %>% pin_read("vector2")
#   x
# 1 1
# 2 2
# 3 3

# even feeds list to data.frame for type="csv"
board %>% pin_write(list(a=1, b=2:3), "vector3", type="csv")
board %>% pin_read("vector3")
#   a b
# 1 1 2
# 2 1 3

Now that we have joblib support, users can specify they want to save any python object using type="joblib"


Game lags when player takes too long to respond

"Slowest" player determines game update. E.g. when a player takes >500ms to respond, the whole game will have a significant delay.
Possible solution: Limit players to a response time of 100ms by configuring MAX_AGENT_PROCESSING_TIME_MS in config.
Drawbacks: Complex algorithms might not be viable.

Should not occur anymore


Added / to the start of the url

When you have installed the Spree in the root of the domain, if you try to navigate to any page, the link for the page is append to the end.  It will go to /t/tag/faq.
My solution have been to add in the link "/faq".

Closing this due to that it seems to have been resolved.


Use Webpacker folder if available

Type of PR: Enhancement
Description
My installation of stimulus_reflex was simply failing because non of the filepath were found.
I have a different folder than app/javascript in my Rails App: this is already defined in the webpacker configuration.
Of course, people might not have Webpacker installed...but maybe we could use it if it is available. :)
Checklist

[ ] My code follows the style guidelines of this project
[ ] Checks (StandardRB & Prettier-Standard) are passing
[x] This is not a documentation update

Sure, I'll bite. 😀
Nice catch!


Make core pass clippy and remove some unnecessary unsafe

Fixes clippy on master

I merged a fix to master without looking at this PR, whoops.


Docker pg

Role and playbook for running a production postgres instance in docker. It's intended that any host in the "docker-pg" group will have a postgres:9.4 image spin up on it and will listen on the 5432 docker host. No provision is made for running multiple postgres instances since it's assumed that a number of services will share the same postgres cluster.

No provision is made for running multiple postgres instances

What does this mean? Couldn't you still run multiple pg containers with different docker_pg_port?

What does this mean? Couldn't you still run multiple pg containers with different docker_pg_port?

Mentioned to @manics by voice that this is intended for creating shared postgres instances. Happy to have the variables in place to let the role be added twice, but doesn't seem a priority.

discussed today, More work coming.

Closing for the moment.


documentation page should list docs for earlier versions

this page:
https://mc-stan.org/users/documentation/
should contain links to earlier versions of the docs.
online docs exist since 2.18  (functions ref added for 2.19)

Yes. And it should clearly state which ones are relevant to RStan, PyStan,
and CmdStanX. Most users are unlikely to realize that they’re lagged.
On Sat, Nov 30, 2019 at 22:11 Mitzi Morris<EMAIL_ADDRESS>wrote:

this page:
https://mc-stan.org/users/documentation/
should contain links to earlier versions of the docs.
online docs exist since 2.18 (functions ref added for 2.19)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/stan-dev.github.io/issues/103?email_source=notifications&email_token=ADRICBSRC2JIRZOC5GS2VA3QWMTNVA5CNFSM4JTJPIGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5BIHYQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRICBQ4LUXWDTKDXHNQNJTQWMTNVANCNFSM4JTJPIGA
.


[WIP] Feature: Add links to addon terms and conditions to node settings page

Purpose
This is an up-to-date version of #2573. Closes #2160.
@fayetality:

Implemented the ability for users to check terms & conditions after adding an addon.

Changes
Add links to terms and conditions next to each configured addon in the project settings page:

I tagged this as a work-in-progress because I would like some discussion on this UI. Any thoughts on how to make it look less crowded @brianjgeiger, @caneruguz?

This issue will be addressed with the redesign of the project addon settings UI.


CDK deployment example

Provide an example for how to deploy the runtime using the AWS CDK.

This isn't intended for broader use in current form, but I laid down a basic foundation for this for some of my PowerShell CDK projects. Code is here: cdk_pwsh_runtime_bootstrap.ps1
A lot of that can likely be utilized and made more generic and accessible.


makePurchaseAmt decimal count before making

Need to check number of decimals in incoming amount before removing decimal and padding.

Hi @mohamed-nazim ,
Thanks for pointing it out, updated to use number_format to adjust the decimals.
Cheers

Cheers!


[APK Management server and Adapter] Check the Possibility to Store the Last Status Locally

Description:
This is to check the possibility to store the last status locally to handle restarts/get the diff from the last update.

This is handled by the xds protocol added by https://github.com/wso2/apk/issues/20


Does not accept openweathermap api key

What happened?
Smart Irrigiation does not accept api key for initial setup.
Set up add-on, created owm account, waited few hours, used api key, not accepted.
Error:
"Open Weather API Key oder Version falsch."
Checked with version 2.5 and 3.0 and newly created API key. Same result
Diagnostics file output w/a openweathermap integration, otherwise not possible to produce the file.
How to reproduce
multiple api key checked, waited several hours,
config_entry-smart_irrigation-072ac5479b48406ce91b1b5ac5f66f53.json
Relevant log output
No response
Which version are you running?
2024.3.1
Diagnostics file

[X] I have attached a diagnostics file

Additional information
No response

Sorry to hear you're having issues. Can you try using postman or something else to call the OWM api using your key? Also, does it show anywhere on the OWM site where you created your key which version it is for? I wonder if they added a newer version and this key only works for that.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: stbcgn @.>
Sent: Sunday, March 17, 2024 2:51:26 AM
To: jeroenterheerdt/HAsmartirrigation @.>
Cc: Assign @.>; Subscribed @.>
Subject: [jeroenterheerdt/HAsmartirrigation] Does not accept openweathermap api key (Issue #334)
What happened?
Smart Irrigiation does not accept api key for initial setup.
Set up add-on, created owm account, waited few hours, used api key, not accepted.
Error:
"Open Weather API Key oder Version falsch."
Checked with version 2.5 and 3.0 and newly created API key. Same result
Diagnostics file output w/a openweathermap integration, otherwise not possible to produce the file.
How to reproduce
multiple api key checked, waited several hours,
config_entry-smart_irrigation-072ac5479b48406ce91b1b5ac5f66f53.jsonhttps://github.com/jeroenterheerdt/HAsmartirrigation/files/14626940/config_entry-smart_irrigation-072ac5479b48406ce91b1b5ac5f66f53.json
Relevant log output
No response
Which version are you running?
2024.3.1
Diagnostics file

I have attached a diagnostics file

Additional information
No response
—
Reply to this email directly, view it on GitHubhttps://github.com/jeroenterheerdt/HAsmartirrigation/issues/334 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB6PIPWLFPQYK7IZT2RWYATYYVRR5BFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLKRSGA2TGOBZGQYTON5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWSHI4TVMWSG4YLNMWXHOYLUMNUF6YLDORUXM2LUPGWHG5LCNJSWG5C7OR4XAZNFJFZXG5LFUZ2G64DJMNZZHAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTENRTGE3TSMJXG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTSMBVG43DQMBZQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGA2TGOBZGQYTON5HORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you were assigned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hey Jeroen,
thanks for getting back to me and sorry for the late reply. Got it to work. I think it made the mistake of not subscribing to a plan in OWM, which I did. Couple hours later it worked then.
Great work btw! :)
Stefan

Stefan Bange
M: +49<PHONE_NUMBER>

Am 17.03.2024 um 15:06 schrieb Jeroen ter Heerdt @.***>:
Sorry to hear you're having issues. Can you try using postman or something else to call the OWM api using your key? Also, does it show anywhere on the OWM site where you created your key which version it is for? I wonder if they added a newer version and this key only works for that.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: stbcgn @.>
Sent: Sunday, March 17, 2024 2:51:26 AM
To: jeroenterheerdt/HAsmartirrigation @.>
Cc: Assign @.>; Subscribed @.>
Subject: [jeroenterheerdt/HAsmartirrigation] Does not accept openweathermap api key (Issue #334)
What happened?
Smart Irrigiation does not accept api key for initial setup.
Set up add-on, created owm account, waited few hours, used api key, not accepted.
Error:
"Open Weather API Key oder Version falsch."
Checked with version 2.5 and 3.0 and newly created API key. Same result
Diagnostics file output w/a openweathermap integration, otherwise not possible to produce the file.
How to reproduce
multiple api key checked, waited several hours,
config_entry-smart_irrigation-072ac5479b48406ce91b1b5ac5f66f53.jsonhttps://github.com/jeroenterheerdt/HAsmartirrigation/files/14626940/config_entry-smart_irrigation-072ac5479b48406ce91b1b5ac5f66f53.json
Relevant log output
No response
Which version are you running?
2024.3.1
Diagnostics file

I have attached a diagnostics file

Additional information
No response
—
Reply to this email directly, view it on GitHubhttps://github.com/jeroenterheerdt/HAsmartirrigation/issues/334 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB6PIPWLFPQYK7IZT2RWYATYYVRR5BFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLKRSGA2TGOBZGQYTON5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWSHI4TVMWSG4YLNMWXHOYLUMNUF6YLDORUXM2LUPGWHG5LCNJSWG5C7OR4XAZNFJFZXG5LFUZ2G64DJMNZZHAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTENRTGE3TSMJXG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIYTSMBVG43DQMBZQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGA2TGOBZGQYTON5HORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you were assigned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
—
Reply to this email directly, view it on GitHub https://github.com/jeroenterheerdt/HAsmartirrigation/issues/334#issuecomment-2002483999, or unsubscribe https://github.com/notifications/unsubscribe-auth/A34AZNACDXWAXREI2C24HHTYYWPP3AVCNFSM6AAAAABE2CGVQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGQ4DGOJZHE.
You are receiving this because you authored the thread.


New version

test

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
thom-nic, @JeheeChoi, @hienpro00123, @yksolanki9, @Openpalm, @Mattarouen, @Blacksource001, @JustMangoou, @DisassembledSharper, @vicalmun, @yaeljiao, @Nirad, @HectorV12, @pha-Z, @ruyan768, @rosancoderian, @rubengm13, @lucas-aragno, @axpool, @HyperSimon, @tksohishi, @renfredxh, @TacoDelPaco, @eltarkan, @CLClark1995, @jamezening, @rsola, @lopezdp, @bluenoah1991, @mjs1001, @zhuoguanjun, @shivaprasad-bhat, @stiucsib86, @Linuxy-DEV, @pxseu, @Buildys258, @ricardolmsilva, @Jean-pierre14, @Junsheng-Wu, @derek1ruler, @GWinfinity, @arnasp13, @nickpvios, @Alvarocda, @xyz1367487, @zhearing, @ZhiXiao-Lin, @gutsyy, @a-pena, @sekym


Sharping settings in ini file

Hello. First of all thank you very much for your great job!
But I have one request - could you add sharping settings to ini file? For now I use your tweaks in RDR 2 and inner sharping settings do not work with your dll.
Thanks!

As to my knowledge, sharpening has been removed from DLSS in newer version (2.5.1) as it did not meet the quality requirements.
Thus, developers have to use their own implementation, like CDPR did with Cyberpunk 2077, or users need to use GFE's sharpening.

Oh, got it @Azulath . Thank you for the explanation.


Code is sometimes "cached"

Sometimes, if you have lots of code, the changes you make don't take effect unless you close and reopen the simulator. This also happens a lot with assets too.

This is likely due to slow compilation on huge project. Do you have an example project?

Any of my huge projects, like my tower defense game. It happens the most with this one. It also happened with a tilemap in this game.

Thanks @UnsignedArduino


OSError: SavedModel file does not exist at: model_resnet152V2.h5/{saved_model.pbtxt|saved_model.pb}

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with the
documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go
here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script
provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue
happens on a mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the problem
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\saved_model\loader_impl.py", line 113, in parse_saved_model
constants.SAVED_MODEL_FILENAME_PB))
OSError: SavedModel file does not exist at: model_resnet152V2.h5/{saved_model.pbtxt|saved_model.pb}
Source code / logs
from future import division, print_function
coding=utf-8
import sys
import os
import glob
import re
import numpy as np
import tensorflow as tf
import tensorflow as tf
from tensorflow.compat.v1 import ConfigProto
from tensorflow.compat.v1 import InteractiveSession
config = ConfigProto()
config.gpu_options.per_process_gpu_memory_fraction = 0.2
config.gpu_options.allow_growth = True
session = InteractiveSession(config=config)
Keras
from tensorflow.keras.applications.resnet50 import preprocess_input
from tensorflow.keras.models import load_model
from tensorflow.keras.preprocessing import image
Flask utils
from flask import Flask, redirect, url_for, request, render_template
from werkzeug.utils import secure_filename
#from gevent.pywsgi import WSGIServer
Define a flask app
app = Flask(name)
Model saved with Keras model.save()
MODEL_PATH ='model_resnet152V2.h5'
Load your trained model
model = load_model(MODEL_PATH)
def model_predict(img_path, model):
print(img_path)
img = image.load_img(img_path, target_size=(224, 224))
# Preprocessing the image
x = image.img_to_array(img)
# x = np.true_divide(x, 255)
## Scaling
x=x/255
x = np.expand_dims(x, axis=0)

# Be careful how your trained model deals with the input
# otherwise, it won't make correct prediction!

x = preprocess_input(x)
preds = model.predict(x)
preds=np.argmax(preds, axis=1)
if preds==0:
    preds="The leaf is diseased cotton leaf"
elif preds==1:
    preds="The leaf is diseased cotton plant"
elif preds==2:
    preds="The leaf is fresh cotton leaf"
else:
    preds="The leaf is fresh cotton plant"

return preds

@app.route('/', methods=['GET'])
def index():
# Main page
return render_template('index.html')
@app.route('/predict', methods=['GET', 'POST'])
def upload():
if request.method == 'POST':
# Get the file from post request
f = request.files['file']
    # Save the file to ./uploads
    basepath = os.path.dirname(__file__)
    file_path = os.path.join(
        basepath, 'uploads', secure_filename(f.filename))
    f.save(file_path)

    # Make prediction
    preds = model_predict(file_path, model)
    result=preds
    return result
return None

if name == 'main':
app.run(port=5001,debug=True)

@Dwarakanadh-k
I ran the code shared but face a different error, please find the gist here.
From the error log i can see that saved_model- face_recognition_model.h5 does not exist, make sure you import the file to the right path and then try loading the model using load_model.
You may also refer to similar issues and let us know: #35909, link

@Dwarakanadh-k  I successfully ran some snippets of your code cells. In you code I think the you have not provided the model's path correctly or even the model.. I have created a demo using your code. It might help.
https://colab.research.google.com/drive/1ansO4-qULpIf_euD5kOMVwpKS4hsCs51?usp=sharing

@Dwarakanadh-k
I ran the code shared but face a different error, please find the gist here.
From the error log i can see that saved_model- face_recognition_model.h5 does not exist, make sure you import the file to the right path and then try loading the model using load_model.
You may also refer to similar issues and let us know: #35909, link

@Dwarakanadh-k I successfully ran some snippets of your code cells. In you code I think the you have not provided the model's path correctly or even the model.. I have created a demo using your code. It might help.
https://colab.research.google.com/drive/1ansO4-qULpIf_euD5kOMVwpKS4hsCs51?usp=sharing

the given demo  link is not opening

@Dwarakanadh-k
I ran the code shared but face a different error, please find the gist here.
From the error log i can see that saved_model- face_recognition_model.h5 does not exist, make sure you import the file to the right path and then try loading the model using load_model.
You may also refer to similar issues and let us know: #35909, link

import flask
from flask import Flask
the code is running after changing the flask error by this
I refered those previously unable to understand the solution

Yeah I didn't given path in code ,Can u please help me how to add path
On Mon, 22 Feb, 2021, 2:53 PM Siddharth Sharma<EMAIL_ADDRESS>wrote:

@Dwarakanadh-k https://github.com/Dwarakanadh-k I successfully ran some
snippets of your code cells. In you code I think the you have not provided
the model's path correctly or even the model.. I have created a demo using
your code. It might help.
https://colab.research.google.com/drive/1ansO4-qULpIf_euD5kOMVwpKS4hsCs51?usp=sharing
http://url
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/47287#issuecomment-783228531,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN52LQANMLCVOFRJS65KHFTTAIPCRANCNFSM4X6C3HXA
.

Just import the load_model
initialize the model path="your model path"(for example)
load_model("Model_Path")

firstly thanks for your response bro
The path is added and load model too
Model saved with Keras model.save()
MODEL_PATH ='model_resnet152V2.h5'
Load your trained model
model = load_model(MODEL_PATH)
From past 1 week trying to solve the error but unable find the solution
If possible check that attached file You may solve the error
https://github.com/krishnaik06/Cotton-Disease-Prediction-Deep-Learning
Thanks
On Mon, Feb 22, 2021 at 3:54 PM Siddharth Sharma<EMAIL_ADDRESS>wrote:

Just import the load_model
initialize the model path="your model path"(for example)
load_model("Model_Path")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/47287#issuecomment-783267416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN52LQDWDR7NNPPEIAUEEW3TAIWEXANCNFSM4X6C3HXA
.

irstly thanks for your response bro
The path is added and load model too
Model saved with Keras model.save()
MODEL_PATH ='model_resnet152V2.h5'
Load your trained model
model = load_model(MODEL_PATH)
From past 1 week trying to solve the error but unable find the solution
If possible check that attached file You may solve the error
https://github.com/krishnaik06/Cotton-Disease-Prediction-Deep-Learning
Thanks
[image: image.gif]
Attachments area
On Mon, Feb 22, 2021 at 3:54 PM Siddharth Sharma<EMAIL_ADDRESS>wrote:

Just import the load_model
initialize the model path="your model path"(for example)
load_model("Model_Path")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/47287#issuecomment-783267416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN52LQDWDR7NNPPEIAUEEW3TAIWEXANCNFSM4X6C3HXA
.


Avoid serializing plan in GpuCoalesceBatches, GpuHashAggregateExec, and GpuTopN

This fixes issues with the RDD closures in GpuCoalesceBatches, GpuHashAggregateExec, and GpuTopN to avoid serializing the plan object and all child nodes.  References to member variables were converted into local variables to sever the dependency between the closure and exec node object.

build

build


Get raw request body in endpoint

Is your feature request related to a problem? Please describe.
I have an endpoint in my SvelteKit app which handles webhook requests from Stripe. Each request is signed so that it can be verified to come from Stripe.
However, the code which verifies this signature needs the raw content of the message. This is a problem because the request has a content-type header of application/json, so SvelteKit's development server as a couple official adapters parses the request from JSON, preventing me from verifying the request. The other adapters either pass no body or pass the body unparsed.
Personally, it seems very weird to me that a SvelteKit application could get exactly the same request and have a totally different body passed to the underlying endpoint depending on what adapter was used.
Describe the solution you'd like
Simply put, adapters shouldn't parse the body. That code can be removed and put somewhere in the rendering process, so the raw body can be extracted by the handle or getContext hook. For ease of use, a boolean option could (and probably should) be added as either an export of the endpoint module or somewhere in the Svelte config.
Describe alternatives you've considered

Expose an additional property (e.g. rawBody) on the request object.
Remove all body parsing whatsoever.

How important is this feature to you?
I would say this issue is of moderate importance, since I can fairly easily make it work with a seperate server for the aforementioned endpoint. Every time I see it, I get a sudden, inexplicable urge to throw up, but it does work.
Additional context
The code which parses the body is here and an identical function is run in the Node adapter (for example) here.

Can you use https://kit.svelte.dev/docs#hooks-getcontext to put the raw request body in the context?

@Conduitry in my testing: it's already parsed at that point. I couldn't get the rawBody that way - I was attempting to do the same thing @max-niederman was with Stripe

Can you use https://kit.svelte.dev/docs#hooks-getcontext to put the raw request body in the context?

@Conduitry No, the request is parsed before the hooks.

Personally, it seems very weird to me that a SvelteKit application could get exactly the same request and have a totally different body passed to the underlying endpoint depending on what adapter was used.

To say nothing of the rest of this issue, I agree with this point and coincidentally discovered this earlier when I was looking to fix a related bug.

However, the code which verifies this signature needs the raw content of the message. This is a problem because the request has a content-type header of application/json, so SvelteKit's development server as a couple official adapters parses the request from JSON, preventing me from verifying the request

It would be inefficient, but isn't it the case you can currently JSON.stringify it to bring it back to its original form to verify?

It would be inefficient, but isn't it the case you can currently JSON.stringify it to bring it back to its original form to verify?

@babichjacob No that doesn't work, as the outputted JSON is formatted differently. Even if it did, it's still not really a solution since it could be prone to breakage, as well as being inefficient and confusing.


build: Add python 3.8 to the build matrix

SUMMARY
Curious how much breaks with 3.8, still very much a WIP
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #9827 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9827      +/-   ##
==========================================
- Coverage   70.88%   70.87%   -0.01%
==========================================
  Files         585      585
  Lines       30432    30432
  Branches     3152     3152
==========================================
- Hits        21571    21570       -1
- Misses       8749     8751       +2
+ Partials      112      111       -1

Flag
Coverage Δ

#cypress
53.61% <ø> (-0.04%)
:arrow_down:

#javascript
59.25% <ø> (ø)

#python
71.01% <ø> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

...rontend/src/SqlLab/components/QueryAutoRefresh.jsx
65.90% <0.00%> (-6.82%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.29% <0.00%> (-2.71%)
:arrow_down:

superset-frontend/src/SqlLab/actions/sqlLab.js
66.81% <0.00%> (+0.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b58ed...a7bae0a. Read the comment docs.


Improve core functionality

Abstract
Implement core functionality from whitepaper.
Goals
This issue is meant to be a todo of all the issues related to core functionality that needs to be implemented for the core algorithm to match the description in the whitepaper and also tasks that to not add any features and are sometimes pushed back but that increase the robustness and are required for a quality production ready product.
Steps
General

[x] What to do if a tx gets copied from an undecided or decided_valid block to the backlog? - #220 (unassigned)
[x] Set RethinkDB read mode to 'majority' to improve consistency - #158 (ryan)
[x] Validate transaction before writing it to the backlog #109 (closed, won't do)
[x] Set durability == hard for all writes #504
[x] Transfer tx validation must check to ensure all referenced outputs are in valid blocks - #526
[x] Ensure no same-asset transactions get put in the same block - #527 (ryan)
[x] Double spend shouldn't be included in a block - #592
[x] Rewriting transactions from invalid block may lead to DoubleSpends - #774

Voting

Skip/abort voting on a block if/when it is already decided: #190
[x] Handling the case of votes pointing to different blocks as the previous block: #165 (ryan), PR #565

Algorithmic/WP

[x] Transactions from invalid block should be put back in the backlog - #193  (ryan), PR #221

Querying

[x] All backend implementations of get_transactions_by_asset_id() should ignore invalid blocks: #332
[x] All backend implementations of get_transactions_by_metadata_id() should ignore invalid blocks: #792
[x] Queries to the bigchain table should ignore invalid blocks - issue #192 (ryan), PR #324

Mutability
The wire protocol firewall (#594) will prevent deletes & updates on the bigchain & votes tables. If a node deletes a transaction from the backlog table, then the client can just resend it, so such deletions don't have to be reverted. As for updates to the backlog table, those must be allowed, for example, to reassign stale transactions (PR #359).

[x] Voting as separate table: #368 (ryan)
Prevent deletes on the bigchain table - #197 (ryan), PR #330
Handle deletes on the backlog table - #196 (ryan), PR #337
Handle updates on the bigchain table - #195 (unassigned)
Prevent updates on the backlog table - #194 (unassigned)
[ ] What to do when a node creates another Genesis block? #444
[x] When validating a transaction, check to ensure it isn't a duplicate - #131 (ryan)

Multiprocessing
There were other issues listed here before but then we realized this isn't core consensus stuff.

[x] Transactions can be orphaned - #323 (unassigned)
[x] Handle stale transactions on the backlog table - #198 (ryan), PR #359

I'm going to close this "meta-issue" because there's only one remaining open issue within it ( #444 ); I will just move that issue into meta-issue #284


Fixing file naming for windows

cc: @chamikaramj
I need to test this on windows before merging.
Colons are not acceptable in file names for windows: https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file
open question: By default, fileio will give names with colons to files. Should we not do this, since it will be by-default broken in windows?

Run Python PreCommit

Yeah, I think it makes sense to pick a naming convention that works for windows as well. Also, let's make sure that Java and Python SDKs have the same behavior in this regard.

LGTM for getting this PR in for fixing tests.


[desktop_multi_window] Can it work with window_manager?

At the moment if I try to access window_manager from a sub-window it throws an exception:

MissingPluginException (MissingPluginException(No implementation found for method ensureInitialized on channel window_manager))

Read this one
https://github.com/MixinNetwork/flutter-plugins/issues/58
You need to add some changes in MainFlutterWindow.swift file for mac os and flutter_window.cpp for windows

@Narek6556 any ideas how it can be done automatically? In multi_window no problems with it.

@krida2000 I don’t know how we can do it automatically.

Thanks! I got it mostly working, only thing that seems to be an issue is that I can't set a transparent background in a sub-window; works fine in the main window. Is this also a known issue?
Minimal reproducable example

Thanks! I got it mostly working, only thing that seems to be an issue is that I can't set a transparent background in a sub-window; works fine in the main window. Is this also a known issue?
Minimal reproducable example

How did you make it work? Link to your example is no longer working

How did you make it work? Link to your example is no longer working

The solution was the quoted link here.
Example of my usage on Linux:
<project_root>/linux/my_application.cc

add imports

#include "desktop_multi_window/desktop_multi_window_plugin.h"
#include <screen_retriever/screen_retriever_plugin.h>
#include <tray_manager/tray_manager_plugin.h>
#include <window_manager/window_manager_plugin.h>
#include <window_size/window_size_plugin.h>

at the end of my_application_activate() populate the callback

// ...

fl_register_plugins(FL_PLUGIN_REGISTRY(view));

  desktop_multi_window_plugin_set_window_created_callback([](FlPluginRegistry* registry){
    g_autoptr(FlPluginRegistrar) window_manager_registrar =
        fl_plugin_registry_get_registrar_for_plugin(registry, "WindowManagerPlugin");
    window_manager_plugin_register_with_registrar(window_manager_registrar);
    g_autoptr(FlPluginRegistrar) window_size_registrar =
      fl_plugin_registry_get_registrar_for_plugin(registry, "WindowSizePlugin");
    window_size_plugin_register_with_registrar(window_size_registrar);
  });

  gtk_widget_grab_focus(GTK_WIDGET(view));

I managed to get it working on Windows with the following in flutter_window.cpp:

Imports
#include "desktop_multi_window/desktop_multi_window_plugin.h" #include <window_manager/window_manager_plugin.h>

Code

  RegisterPlugins(flutter_controller_->engine());    DesktopMultiWindowSetWindowCreatedCallback([](void *controller) {      auto *flutter_view_controller =          reinterpret_cast<flutter::FlutterViewController *>(controller);      auto *registry = flutter_view_controller->engine();      WindowManagerPluginRegisterWithRegistrar(          registry->GetRegistrarForPlugin("WindowManagerPlugin"));    });   SetChildContent(flutter_controller_->view()->GetNativeWindow());
I am now having an issue where the application crashes when the child window is closed.  This only applies when using Window Manager.

我设法让它在 Windows 上运行，flutter_window.cpp年具有以下功能：

进口

#include "desktop_multi_window/desktop_multi_window_plugin.h"
#include <window_manager/window_manager_plugin.h>

法典

RegisterPlugins(flutter_controller_->engine());
DesktopMultiWindowSetWindowCreatedCallback([](void *controller) {
  auto *flutter_view_controller =
      reinterpret_cast<flutter::FlutterViewController *>(controller);
  auto *registry = flutter_view_controller->engine();
  WindowManagerPluginRegisterWithRegistrar(
      registry->GetRegistrarForPlugin("WindowManagerPlugin"));
});
SetChildContent(flutter_controller_->view()->GetNativeWindow());

我现在遇到一个问题，当子窗口关闭时应用程序崩溃。这仅适用于使用窗口管理器时。
I'm also having this problem with WindowManager and MultiWindow, is there a solution?

is there any update for this?

is there any update for this?
did you find solution?

the reason of crashing when closing sub window is the global engine channel is overriden by the new engine, so you just move the global engine channel to the manager class and hold it in inner class on each window instance.

can you give some code for this, please?

the reason of crashing when closing sub window is the global engine channel is overriden by the new engine, so you just move the global engine channel to the manager class and hold it in inner class on each window instance.

void WindowManagerPlugin::_EmitEvent(std::string eventName) {   flutter::EncodableMap args = flutter::EncodableMap();   args[flutter::EncodableValue("eventName")] =       flutter::EncodableValue(eventName);   if (channel != nullptr) {       std::cout << "channel not nullptr start invoke event on new engine" << std::endl;       try {           channel->InvokeMethod("onEvent",               std::make_unique<flutter::EncodableValue>(args));       }       catch (std::exception& e) {           std::cout << e.what() << std::endl;       }   } }
you can see it the main reason crashing is the pre sub window 's method channel is nullptr, just hold it and move the channel variables to each window instance classes.

void WindowManagerPlugin::_EmitEvent(std::string eventName) { flutter::EncodableMap args = flutter::EncodableMap(); args[flutter::EncodableValue("eventName")] = flutter::EncodableValue(eventName); if (channel != nullptr) { std::cout << "channel not nullptr start invoke event on new engine" << std::endl; try { channel->InvokeMethod("onEvent", std::make_unique<flutter::EncodableValue>(args)); } catch (std::exception& e) { std::cout << e.what() << std::endl; } } } you can see it the main reason crashing is the pre sub window 's method channel is nullptr, just hold it and move the channel variables to each window instance classes.

Just a little curious, how and where can u view the cout of the cpp native code in flutter, every I want to print something to debug in native code, I have to write it out to a local file and read it. Thanks!

use android studio to install flutter plugin and run project can do it, maybe vscode can do it as well.

Thank you, Im using vs code, maybe it only works on android studio. Let me try.

i added analog code on linux.
but i lost ability to call  DesktopMultiWindow.invokeMethod between window.
do you have similar issue?
i'm really stuck on multi window feature, and calling method between sub-window and main-window

void WindowManagerPlugin::_EmitEvent(std::string eventName) { flutter::EncodableMap args = flutter::EncodableMap(); args[flutter::EncodableValue("eventName")] = flutter::EncodableValue(eventName); if (channel != nullptr) { std::cout << "channel not nullptr start invoke event on new engine" << std::endl; try { channel->InvokeMethod("onEvent", std::make_unique<flutter::EncodableValue>(args)); } catch (std::exception& e) { std::cout << e.what() << std::endl; } } }
you can see it the main reason crashing is the pre sub window 's method channel is nullptr, just hold it and move the channel variables to each window instance classes.

How did you make it work? Link to your example is no longer working

The solution was the quoted link here.
Example of my usage on Linux:
<project_root>/linux/my_application.cc

add imports

#include "desktop_multi_window/desktop_multi_window_plugin.h"
#include <screen_retriever/screen_retriever_plugin.h>
#include <tray_manager/tray_manager_plugin.h>
#include <window_manager/window_manager_plugin.h>
#include <window_size/window_size_plugin.h>

at the end of my_application_activate() populate the callback

// ...

fl_register_plugins(FL_PLUGIN_REGISTRY(view));

  desktop_multi_window_plugin_set_window_created_callback([](FlPluginRegistry* registry){
    g_autoptr(FlPluginRegistrar) window_manager_registrar =
        fl_plugin_registry_get_registrar_for_plugin(registry, "WindowManagerPlugin");
    window_manager_plugin_register_with_registrar(window_manager_registrar);
    g_autoptr(FlPluginRegistrar) window_size_registrar =
      fl_plugin_registry_get_registrar_for_plugin(registry, "WindowSizePlugin");
    window_size_plugin_register_with_registrar(window_size_registrar);
  });

  gtk_widget_grab_focus(GTK_WIDGET(view));

Hello, even wit this changes I still have this error:
Unhandled Exception: MissingPluginException(No implementation found for method ensureInitialized on channel window_manager)
Did you do something else ?

I can get rid of the MissingPluginException error by following those instructions, but calling window_manager from a subwindow doesn't seem to do anything for me anymore.

I can get rid of the MissingPluginException error by following those instructions, but calling window_manager from a subwindow doesn't seem to do anything for me anymore.

Like @Merrit, got rid of MissingPluginException by following instructions, but window_manager wasn't working in subwindows
Got it working after debug session on

window_manager 0.3.2
desktop_multi_window 0.2.0

TLDR:
issue was logic error with the order sub-window is created & sub-window attributes are set
make sure logic follows in order:

use DesktopMultiWindow.createWindow() to create window
use WindowManager.instance to set attributes (e.g.: title, fullscreen, etc.)
use WindowManager.instance.show() to show window after attributes are set

⚠ do NOT WindowController.show() using result from DesktopMultiWindow.createWindow() to show window -> causes  race condition
keep race conditions in mind when you're debugging/resolving this issue

each sub-window creates a new thread
logic must be in order, otherwise window_manager doesn't work on sub-windows

Longer explanation:
Two important blocks of code:

Somewhere, create sub-window
DesktopMultiWindow.createWindow(...).then(window) { window.show() }

When DesktopMultiWindow.createWindow(...) is called, void main(args) is run

void main(args) async {
   ...
   final isSubWindow = (args.firstOrNull == "multi_window")
   WidgetsFlutterBinding.ensureInitialized()
   await windowManager.ensureInitialized()
   ...
   if (!isSubWindow) {
      windowManager.waitUntilReadyToShow(windowOptions, () async {
          await windowManager.setTitle("Main Window")
          await windowManager.show()
      })
      runApp(MainWindowApp())
   }
   else {
      windowManager.waitUntilReadyToShow(windowOptions, () async {
          await windowManager.setTitle("Child Window")
      })
      runApp(SubWindowApp())
   }
}

The issue occurs when window.show() is called before attributes are set (e.g.: await windowManager.setTitle("Child Window"))
Making sure attributes are set before sub-window is shown solved issue for me
Correct usage:

Somewhere, create sub-window
DesktopMultiWindow.createWindow(...)

When DesktopMultiWindow.createWindow(...) is called, void main(args) is run

void main(args) async {
   ...
   final isSubWindow = (args.firstOrNull == "multi_window")
   WidgetsFlutterBinding.ensureInitialized()
   await windowManager.ensureInitialized()
   ...
   if (!isSubWindow) {
      runApp(MainWindowApp())
      windowManager.waitUntilReadyToShow(windowOptions, () async {
          await windowManager.setTitle("Main Window")
          await windowManager.show()
      })
   }
   else {
      runApp(SubWindowApp())
      windowManager.waitUntilReadyToShow(windowOptions, () async {
          await windowManager.setTitle("Child Window")
          await windowManager.show()
      })
   }
}

I managed to get it working on Windows with the following in flutter_window.cpp:

Imports

#include "desktop_multi_window/desktop_multi_window_plugin.h"
#include <window_manager/window_manager_plugin.h>

Code

RegisterPlugins(flutter_controller_->engine());
DesktopMultiWindowSetWindowCreatedCallback([](void *controller) {
  auto *flutter_view_controller =
      reinterpret_cast<flutter::FlutterViewController *>(controller);
  auto *registry = flutter_view_controller->engine();
  WindowManagerPluginRegisterWithRegistrar(
      registry->GetRegistrarForPlugin("WindowManagerPlugin"));
});
SetChildContent(flutter_controller_->view()->GetNativeWindow());

I am now having an issue where the application crashes when the child window is closed. This only applies when using Window Manager.

This solution worked perfectly for me, but if you always want sub-windows to have all plugins your main window has, this solution worked for me:
RegisterPlugins(flutter_controller_->engine());

// whenever DesktopMultiWindow creates a new window, do the following
DesktopMultiWindowSetWindowCreatedCallback([](void* controller) {
  // get view controller and engine of new window
  auto* flutter_view_controller =
  reinterpret_cast<flutter::FlutterViewController*>(controller);
  auto* registry = flutter_view_controller->engine();

  // register plugins with the new window
  RegisterPlugins(registry);
});

SetChildContent(flutter_controller_->view()->GetNativeWindow());

this way, you don't have to re-register for every plugin you will add in the future

I managed to get it working on Windows with the following in flutter_window.cpp:

Imports

#include "desktop_multi_window/desktop_multi_window_plugin.h"
#include <window_manager/window_manager_plugin.h>

Code

RegisterPlugins(flutter_controller_->engine());
DesktopMultiWindowSetWindowCreatedCallback([](void *controller) {
  auto *flutter_view_controller =
      reinterpret_cast<flutter::FlutterViewController *>(controller);
  auto *registry = flutter_view_controller->engine();
  WindowManagerPluginRegisterWithRegistrar(
      registry->GetRegistrarForPlugin("WindowManagerPlugin"));
});
SetChildContent(flutter_controller_->view()->GetNativeWindow());

I am now having an issue where the application crashes when the child window is closed. This only applies when using Window Manager.

This solution worked perfectly for me, but if you always want sub-windows to have all plugins your main window has, this solution worked for me:
RegisterPlugins(flutter_controller_->engine());

// whenever DesktopMultiWindow creates a new window, do the following
DesktopMultiWindowSetWindowCreatedCallback([](void* controller) {
  // get view controller and engine of new window
  auto* flutter_view_controller =
  reinterpret_cast<flutter::FlutterViewController*>(controller);
  auto* registry = flutter_view_controller->engine();

  // register plugins with the new window
  RegisterPlugins(registry);
});

SetChildContent(flutter_controller_->view()->GetNativeWindow());

this way, you don't have to re-register for every plugin you will add in the future

Thank you. Although the problem has been resolved, a new issue has emerged. When the sub window is closed (the main window is still running), it can cause the program to crash.

@GangJust
This was also encountered & solved by 769755893 and lycstar earlier in the thread
Both of their solutions work great

769755893's solution

void WindowManagerPlugin::_EmitEvent(std::string eventName) { flutter::EncodableMap args = flutter::EncodableMap(); args[flutter::EncodableValue("eventName")] = flutter::EncodableValue(eventName); if (channel != nullptr) { std::cout << "channel not nullptr start invoke event on new engine" << std::endl; try { channel->InvokeMethod("onEvent", std::make_unique<flutter::EncodableValue>(args)); } catch (std::exception& e) { std::cout << e.what() << std::endl; } } } you can see it the main reason crashing is the pre sub window 's method channel is nullptr, just hold it and move the channel variables to each window instance classes.

lycstar's solution

void WindowManagerPlugin::_EmitEvent(std::string eventName) { flutter::EncodableMap args = flutter::EncodableMap(); args[flutter::EncodableValue("eventName")] = flutter::EncodableValue(eventName); if (channel != nullptr) { std::cout << "channel not nullptr start invoke event on new engine" << std::endl; try { channel->InvokeMethod("onEvent", std::make_unique<flutter::EncodableValue>(args)); } catch (std::exception& e) { std::cout << e.what() << std::endl; } } } you can see it the main reason crashing is the pre sub window 's method channel is nullptr, just hold it and move the channel variables to each window instance classes.

I don't understand what you mean, but if I try to do this, it won't crash, but it will cause only the main window's events to be triggered, and the child window's events won't be able to be triggered
void WindowManagerPlugin::_EmitEvent(std::string eventName) {
  flutter::EncodableMap args = flutter::EncodableMap();
  args[flutter::EncodableValue("eventName")] =
      flutter::EncodableValue(eventName);
  //add this to update channel
  channel = std::make_unique<flutter::MethodChannel<flutter::EncodableValue>>(
      registrar->messenger(), "window_manager",
      &flutter::StandardMethodCodec::GetInstance());
  //
  channel->InvokeMethod("onEvent",
                        std::make_unique<flutter::EncodableValue>(args));
}

To summarize, it's a null dereference issue

e.g.: channel variable is null & trying to call InvokeMethod
When DesktopMultiWindow's sub-window is closed before main window, the MethodChannel channel is set to nullptr
Symptom of WindowManager & DesktopMultiWindow not being 100% integrated together -- WindowManager closes MethodChannel when any window is closed (since there's normally only 1 window), but DesktopMultiWindow is still trying to make use of that same channel

How to solve it (for Windows)?

Find WindowManagerPlugin::_EmitEvent in window_manager_plugin.cpp (though can differ, generally found in C:/Users/username/AppData/Local/Pub/Cache/hosted/pub.dev/window_manager-x.x.x/windows/window_manager_plugin.cpp)
Use 769755893's solution (e.g.: if channel is nullptr, don't call InvokeMethod)

works, but events can no longer be emitted

Or use lycstar's solution (e.g.: everytime an event is emitted, re-initialize the channel variable)

now events can be emitted, but we're reinitializing a MethodChannel each time we emit an event (not 100% perfect performance-wise)

Another note for both solutions is that whenever you upgrade the WindowManager package, you'll have to reimplement this solution
Overall, would recommend lycstar's approach so events can continue being passed
However, if you really wanted everything 100% perfect, you could consider forking the projects and putting in logic that integrates WindowManager with DesktopMultiWindow:

whenever the main window (not any sub-windows) is closed, close the channel

Take my explanations with a grain of salt since it's been a week or two since I actually debugged

I showed several windows using desktop_multi_window package and want to hide/remove title bar of sub windows.
Is it possible to hide/remove them?
please help me.

I showed several windows using desktop_multi_window package and want to hide/remove title bar of sub windows. Is it possible to hide/remove them? please help me.

you_project\windows\flutter\ephemeral.plugin_symlinks\desktop_multi_window\windows\flutter_window.cc
  HWND window_handle = CreateWindow(
      kFlutterWindowClassName, L"", WS_OVERLAPPEDWINDOW,
      Scale(target_point.x, scale_factor_), Scale(target_point.y, scale_factor_),
      Scale(1280, scale_factor_), Scale(720, scale_factor_),
      nullptr, nullptr, GetModuleHandle(nullptr), this);

change WS_OVERLAPPEDWINDOW to WS_POPUP

I showed several windows using desktop_multi_window package and want to hide/remove title bar of sub windows. Is it possible to hide/remove them? please help me.

if you follow above solutions, you can hide titlebar at subwindow. by setting
WindowOptions windowOptions = const WindowOptions( ...   titleBarStyle: TitleBarStyle.hidden, );

Thanks for your reply.
It works!
And I am trying to sync state between main window and sub windows.
In desktop_multi_window, there is only option for invoking method from main window to sub windows.
No option for sub windows to main window. How to sync this?
I am using riverpod for state management and want to use same state in entire app.
If you have any solution, please let me know.

Thanks for your reply. It works! And I am trying to sync state between main window and sub windows. In desktop_multi_window, there is only option for invoking method from main window to sub windows. No option for sub windows to main window. How to sync this? I am using riverpod for state management and want to use same state in entire app. If you have any solution, please let me know.

Talking from sub to main window should be the same as main to sub window
in MainWindow.dart, do:
DesktopMultiWindow.setMethodHandler((call, fromWindowId){
   switch(call.method) {
        "methodTriggeredBySubWindow":
        // write code here
        break
        default:
        // method not implemented!!!
        break
   }
})

in SubWindow.dart, do:
var mainWindowId = WindowController.main().windowId; // should always be 0
var result = DesktopMultiWindow.invokeMethod(
   mainWindowId,
   "methodTriggeredBySubWindow",
   {
      // args here
   }
)

Make sure the method handler is set before invoking it

Also, while doing this if you run into a MissingPluginException("no implementation found for channel"), then don't register DesktopMultiWindowPlugin on each sub-window

devs only intended for it to be registered on main window, doing on each sub-window messes up events to main window

So unlike my prior comment, would recommend registering each plugin separately in each sub-window
so in flutter_window.cpp (or its Linux/Mac counterparts):
// whenever DesktopMultiWindow creates a new window, do the following
DesktopMultiWindowSetWindowCreatedCallback([](void* controller) {
  // get view controller and engine of new window
  auto* flutter_view_controller =
    reinterpret_cast<flutter::FlutterViewController*>(controller);
  auto* registry = flutter_view_controller->engine();

  // register plugins with the new window
  // RegisterPlugins(registry); // don't do this
  WindowManagerPluginRegisterWithRegistrar(
        registry->GetRegistrarForPlugin("WindowManagerPlugin")); // do this with all your plugins, except for DesktopMultiWindow
  });

BTW you can find the current plugins that you use in  generated_plugin_registrant.cc for linux and windows


About  CPU Offloading

If I wanna use CPU Offloading in my model, which API should I call in BMTrain?

Use bmtrain.optim.AdamOffloadOptimizer.
See https://github.com/OpenBMB/BMTrain/blob/0.2.0/example/train.py#L54

@a710128 Does our implementation of AdamOffloadOptimizer work together with ZeRO optimization by offloading only partitioned optimizer states and updating only partitioned parameters belonged to current rank?

It works together with ZeRO. Only partitioned parameters are stored on each rank, so in adam_offload.py you cannot find related codes. The parameter is already partitioned in https://github.com/OpenBMB/BMTrain/blob/0.2.0/bmtrain/parameter.py#L56, while gradient also disperses during backpropagation https://github.com/OpenBMB/BMTrain/blob/0.2.0/bmtrain/block_layer.py#L240

got it.


{AKS} az aks install-cli: Add error message wrapper

Related command

az aks install-cli
Description

Workaround for issue #29948, wrapping a specific SSL error to provide more detailed guidance to users on how to resolve issues where requests using an inappropriate cert store are being made.

Related to #19305.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Thank you for your contribution! We will review the pull request and get back to you soon.

/azp run


[SPARK-9100] [SQL] Adds DataFrame reader/writer shortcut methods for ORC

Merged build triggered.

Merged build started.

Test build #37497 has started for   PR 7444 at commit e0b09fb.

Test build #37497 has finished for   PR 7444 at commit e0b09fb.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #37616 has started for   PR 7444 at commit 284d043.

Merged build finished. Test FAILed.

@rxin @davies A little off topic, but python/pyspark/sql/readwriter.py should probably be renamed to readerwriter.py or readwrite.py.  Which do you prefer?

Test build #37616 has finished for   PR 7444 at commit 284d043.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest please

retest this please

Merged build triggered.

Merged build started.

Test build #37640 has started for   PR 7444 at commit 284d043.

Test build #37640 has finished for   PR 7444 at commit 284d043.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

lgtm

Thanks for the review, merging to master.


fix: handle LoginPolicyRemoved in auth

:tada: This PR is included in version 0.104.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update to latest version of ChakraCore (v1.11.19)

Build succeeded and tests passed locally

Thanks, Adam!


(feat): 134 nnnnat cart items

Resolves #134
Impact: major
Type: feature

Component
Added a CartItems component based on these specs
Screenshots
Desktop

Mobile

Testing

Make sure it looks good and works

While I agree it doesn't look bad in this example, the issue is long Product Names. If the product name runs long then it will hurt readability b/c the names will have to break more aggressively. Long way of saying I think we should match the designs and push it down on mobile.

@kieckhafer  the CartItem does drop the price down to the bottom for mobile, I think the recent sidebar updates make the component smaller while the sidebar stays a fixed width causing the breakpoints to not line up as they should. If you size the browser size down so the sidebar goes away it should display correctly

@nnnnat You're right, I was using mobile mode in the chrome dev-tools, and it was still on top. When looking at it on my actual phone, it was moved to the correct location, however... it doesn't looks great in that location on mobile, at least when there is a strike-through price, it's a bit crowded.
@rymorgan Thoughts on what to do here? Seems like the phone width might be narrower than the designs.
This might not be for this ticket either, maybe we make a new ticket to fix this.

I just pushed a fixed for the rounded corners of the QuantityInput. @kieckhafer @rymorgan it def looks a little crowded for mobile. I think the StockWarning and Price components are rendering at 16px font size when they look to be 14px in zeplin fixing those font sizes should help.

I double checked all the CartItem fonts against the design and updated a few things.

Overall, this looks great. There are a few small UI issues that seem to be occurring, but they seem to be caused by the new design of the Component library itself, not this particular component.
I've created an issue, https://github.com/reactioncommerce/reaction-component-library/issues/114, to re-visit this and just make sure everything is working as it should once we pull this into the starterkit.

:tada: This PR is included in version 0.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wrap custom commands on shell

Context
This solves https://github.com/jesseduffield/lazydocker/issues/354
Implementation
Ideally, we'd re-use ICmdObjBuilder from lazygit across both projects, but that'd require a complete refactor here. So i ported the string replacement for Windows OS and the wrapping of new shell.

Here's the result using the issue's example:
(base) ➜  lazydocker git:(master) ✗ go run -mod=vendor main.go
docker-compose config --quiet

+ bash -c docker run -it -v "$(pwd)":/data redis

1:C 15 Oct 2022 19:27:44.265 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 15 Oct 2022 19:27:44.265 # Redis version=7.0.5, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 15 Oct 2022 19:27:44.265 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
1:M 15 Oct 2022 19:27:44.265 * monotonic clock: POSIX clock_gettime
                _._
           _.-``__ ''-._
      _.-``    `.  `_.  ''-._           Redis 7.0.5 (00000000/0) 64 bit
  .-`` .-```.  ```\/    _.,_ ''-._
 (    '      ,       .-`  | `,    )     Running in standalone mode
 |`-._`-...-` __...-.``-._|'` _.-'|     Port: 6379
 |    `-._   `._    /     _.-'    |     PID: 1
  `-._    `-._  `-./  _.-'    _.-'
 |`-._`-._    `-.__.-'    _.-'_.-'|
 |    `-._`-._        _.-'_.-'    |           https://redis.io
  `-._    `-._`-.__.-'_.-'    _.-'
 |`-._`-._    `-.__.-'    _.-'_.-'|
 |    `-._`-._        _.-'_.-'    |
  `-._    `-._`-.__.-'_.-'    _.-'
      `-._    `-.__.-'    _.-'
          `-._        _.-'
              `-.__.-'

1:M 15 Oct 2022 19:27:44.266 # Server initialized
1:M 15 Oct 2022 19:27:44.269 * Ready to accept connections
^C1:signal-handler<PHONE_NUMBER>) Received SIGINT scheduling shutdown...
1:M 15 Oct 2022 19:27:47.999 # User requested shutdown...
1:M 15 Oct 2022 19:27:47.999 * Saving the final RDB snapshot before exiting.
1:M 15 Oct 2022 19:27:48.022 * DB saved on disk
1:M 15 Oct 2022 19:27:48.023 # Redis is now ready to exit, bye bye...

Press enter to return to lazydocker (this prompt can be disabled in your config by setting `gui.returnImmediately: true`)

@jesseduffield This is ready, let me know your thoughts!

Also one thing we'll want to test @gusandrioli is whether an existing custom command which already used bash -c explicitly now breaks with this new code

Also one thing we'll want to test @gusandrioli is whether an existing custom command which already used bash -c explicitly now breaks with this new code

Good point, i'll test that out.

@jesseduffield It does fail! Thanks for catching that:
+ bash -c bash -c docker run -it -v "$(pwd)":/data redis

Usage:  docker [OPTIONS] COMMAND

A self-sufficient runtime for containers

One alternative is to leave the command as is if it contains -c . What are your thoughts on this?

Nice work :) I'll give this a local test soon

@gusandrioli sorry this fell through the cracks. I'll take another look this afternoon

@jesseduffield No worries at all, let me know :)

Code looks good, I've just fixed some merge conflicts

can you confirm this still works on your end after I resolved those merge conflicts @gusandrioli ?

Merged. Thanks @gusandrioli !

This broke the custom commands like these:
customCommands:
  containers:
    - name: bash
      attach: true
      command: 'docker exec -it {{ .Container.ID }} bash'
      serviceNames: []

Results with the error:
+ bash -c docker exec -it {{ .Container.ID }} /bin/bash

Error response from daemon: No such container: {{

Setting shell: false changes nothing.

This changeset broke lazydocker completely for me. I hope the issue will be resolved, ASAP.
For now I've downgrade to 0.20.0 via homebrew using the following snippet:
wget https://raw.githubusercontent.com/jesseduffield/homebrew-lazydocker/b6d29bcd59058d1b7ec371df12f75d7048b40789/lazydocker.rb
brew uninstall lazydocker
brew install -s lazydocker.rb
rm ./lazydocker.rb


Request: Add SyncToy functionality to PowerToys

Consider absorbing the functionality of SyncToy into PowerToys.
SyncToy 2.1 is a free application that synchronizes files and folders between locations. Typical uses include sharing files, such as photos, with other computers and creating backup copies of files and folders.
https://www.microsoft.com/en-us/download/details.aspx?id=15155
See Also: https://www.microsoft.com/en-us/search?q=SyncToy

Duplicate of #26


RS256 alg not working in XK6-jose

tried to execute below code in xk6 but recieved feil "ERRO[0001] Exception raised in test "sign". Failing the test and continuing.
unsupported algorithm: RS256  source=console"
unsupported algorithm: RS256
gone through the parent doc https://github.com/square/go-jose#supported-key-types and found its
const ALG = "RS256";

export default function () {
  describe("sign", (t) => {
    const token = jwt.sign(jwk.generate(ALG), { foo: "bar" });
    console.log("token"+token);
    t.expect(token.length).as("token length").toBeGreaterThan(0);
    t.expect(token.split(".").length).as("number of fields").toEqual(3);
  });

Does XK6-Jose support RS256 for generate ?

This extension is deprecated. In the meantime, k6 supports webcrypto, it is advisable to use it in new tests.
If you need this extension because of your old tests or if you want to continue development, feel free to fork it.


add flush timeout to emitter test

Adds flushTimeout to HttpEmitterConfig in EmitterTest to see if it can prevent this test from getting stuck and stalling out travis.

This PR seems to help. I have repeatedly run the "other modules test" several times and they have not failed once due to EmitterTest.
I have noticed a handful of
[WARNING] org.apache.druid.java.util.emitter.core.EmitterTest.testTimeBasedEmission(org.apache.druid.java.util.emitter.core.EmitterTest)
[ERROR]   Run 1: EmitterTest.testTimeBasedEmission:378->closeNoFlush:611 » IO Timed out after [...
[INFO]   Run 2: PASS

So I think this is good to merge and should help travis pass a bit more on the first time through


Add chinese translation

Add chinese translation
Setup the local language before publishing

Please don't mix concerns in one PR.
I think we won't accept your changes to the Readme but would be glad to merge your language changes.

Closing as the branch or fork was deleted.


build: run prettier on legacy-cli e2e files

I'm working on switching these to run via bazel and getting significant diffs when editing the files. Are we ok with a single commit formatting all these? For now it's just the legacy-cli which I hope is all the files I'll be editing when switching to bazel...

I think the pre-commit runs the formatter? I was assuming it was added at some point but never run on these files, because now when I commit any of them they get formatted...
Also note I've only formatted the e2e legacy-cli files which I hope is all #23085 touches, there's plenty more outside that directory.

As mentioned, the commit hooks will run the formatter on changed files.  CI will also verify the formatting for all changed files in the PR.  When prettier was introduced essentially all files except those in the tests directory were formatted.

Ok, so we just didn't do the one-time format when we first enabled in the formatter. As long as we're consistent moving forward, I have no concerns.

Thanks!


docs: Update Node.js SDK installation command

Closes #4373
Signed-off-by: Vikram Vaswani<EMAIL_ADDRESS>

Just need a quick rebase with main and it ready to go :).


[SPARK-32127][SQL]: Check rules for MERGE INTO should use MergeAction.conditition other than MergeAction.children

What changes were proposed in this pull request?
This pr fix a bug of check rules for MERGE INTO.
Why are the changes needed?
SPARK-30924 adds some check rules for MERGE INTO one of which ensures the first MATCHED clause must have a condition. However, it uses MergeAction.children in the checking which is not accurate for the case, and it lets the below case pass the check:
MERGE INTO testcat1.ns1.ns2.tbl AS target
xxx
WHEN MATCHED THEN UPDATE SET target.col2 = source.col2
WHEN MATCHED THEN DELETE
xxx

We should use MergeAction.condition instead.
Does this PR introduce any user-facing change?
No
How was this patch tested?
An existed ut is modified.

@cloud-fan @brkyvz , pls take a look.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29243/
Test PASSed.

Test build #124626 has started for PR 28943 at commit d02cef2.

Test build #124626 has finished for PR 28943 at commit d02cef2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed abstract class MergeAction extends Expression with Unevaluable
case class DeleteAction(condition: Option[Expression]) extends MergeAction

thanks, merging to 3.0!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124626/
Test PASSed.

Thanks @cloud-fan !


v1.14 Backports 2024-01-16

[x] #29400 (@meyskens)

:warning: Conflicts in manager_test.go:

Changed ReservedIdentityWorldIPv6 to ReservedIdentityWorld for v1.14
Skipped changes to Test_authManager_handleCertificateDeletionEvent as that test function does not exist in v1.14

[x] #30194 (@julianwiedmann)
[x] #28698 (@meyskens)
[ ] #28974 (@vipul-21)

:warning: Trivial conflicts because cilium-dbg/ is cilium/ in v1.14

[x] #30209 (@squeed)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 29400 30194 28698 28974 30209

/test-backport-1.14

CI is green, remaining reviews are trivial. Merging this to unblock the release.


CMake: Replace ; by $<SEMICOLON> in generator-expression

CMake generator-expressions should not contain semicolons, especially if they might end up in a CMake list, because a semicolon (;) would be interpreted as list-item separator and therefore render the generator-expression invalid. The generator-expression $<SEMICOLON> should be used instead.

Looks ok to me


Nag on untriaged bugs that are related to top sites

@gcp on #ee Slack channel:

I think this was a triage fail: https://bugzilla.mozilla.org/show_bug.cgi?id=1753874
Idea: if the bots can correlate bug reports to Alexa top sites, they can nag/escalate?

Based on the discussion with @calixteman on Matrix:

We could have a tool to get untriaged bugs, then check if the title or 1st comment contains some URL and/or keywords belonging to the top 10 websites according to Alexa

top 10 websites according to Alexa

FWIW, Alexa says tiktok is 28th, and that's still before Paypal, so we likely need a slightly wider net :-)

This could be automatically handled if/when we build the model to suggest severity.

We could add the top50, top100 and top500 keywords automatically when we find such bugs.


Feat/use setup proxy.js

I've added configuration options in the .env.development file to configure the proxy ip and port. Other updates are

configured the remaning env variables react docs
configured build analysys tool react docs
configured advanced proxy setup react docs for more flexibility

Looks good! 👍 As far as I understand, these .env files will be only pulled if they get renamed to .env, right? Do we need some documentation what to use when?

.env files will be only pulled if they get renamed to .env

No, they get applied immediately given the context. The docs have a paragraph on priority. Here's the relevant part

What other .env files can be used?
Note: this feature is available with<EMAIL_ADDRESS>and higher.

.env: Default.
.env.local: Local overrides. This file is loaded for all environments except test.
.env.development, .env.test, .env.production: Environment-specific settings.
.env.development.local, .env.test.local, .env.production.local: Local overrides of environment-specific settings.

Files on the left have more priority than files on the right:

npm start: .env.development.local, .env.local, .env.development, .env
npm run build: .env.production.local, .env.local, .env.production, .env
npm test: .env.test.local, .env.test, .env (note .env.local is missing)

These variables will act as the defaults if the machine does not explicitly set them.
Please refer to the dotenv documentation for more details.

Do we need some documentation what to use when?

I can add it to the documentation or point to the relevant create-react-app docs. Which one do you prefer?

I think it's fine if we point to the create react app docs in our docs :+1: Otherwise it looks good and it works on my machine too :D


Define RPROVIDES for corretto recipes.

Closes #7995
Description of changes:
Added RPROVIDES for java virtual machine recipes, switched greengrass RDEPENDS to meta package.

/run


Copy-DbaDatabase -DetachAttach switch is using \SqlSERVER\M$\MSSql... without domain name causing access issue

I found an issue here with the -detachAttach switch. It doesn't take into consideration the domain name of the server when accessing the directories. Eg. \server\serverFolder\user_dbdata\data instead of \server.domain.com\serverFolder\user_dbdata\data
Causing this error:

DetachAttach methos doesn;t allow using SharedPath instead File copies are performed over administrative shares (\server\x$\mssql

Hi @shaddy02 : Can you run Resolve-DbaNetworkName -ComputerName XYZ with XYZ as the computer name only like in the wrong UNC path? Then tell me, which of the output information would be correct as to build the UNC path with.

@andreasjordan best fix for this is to stop using remote paths and do calls locally to the server (Invoke-Command2 calls). That removes the need to do any type of looking or check on UNC paths. We do local checks of this nature in  other commands I recall instead of remote UNC or the admin share.
Which I'm sure to do this will require restructuring a good bit of how the command works. It could be evaluated as well to see if we have more commands that do the heavy lifting with database files than when we originally wrote this command.

The UNC path is needed for the Start-BitsTransfer which is propably way faster that copying over PSSession. And we would need to open a session from the destination to the source server. We can not be sure that this works as good as opening a session from the server with dbatools to both the source and destination.
I think the actual implementation works for most cases, so I would not rewrite the code to use PSSession to copy. Either we find a good way to use the full computername here or we close this as "will not fix".

Unless it has changed, the use of Starts-BitsTransfer is not that efficient considering if a user runs the command from their local workstation the network path of copying a file from a source to target, the file still has to traverse the client workstation. Versus if you copy a file from, locally, the source instance (via Invoke-Command2) directly to the target instance that will enhance the performance greatly and cause less network traffic.
The Bits transfer's only advantage is it has restart ability if the network hiccups during the transfer. Supporting the use of copying the file over PSSession would also provide the ability to support copying files to SQL Server on Linux, which right now cannot be done in this command.

We can create a new issue I guess or maybe discussion to find out what interest there are in supporting various scenarios.
If the PR you have for this fixes this specific issue, then let it ride and leave the command as-is until interest matches the effort required. I have not seen anyone really bring up our limited support for SQL + Linux.

I'm a bit afraid to break things for other users if we now use the full name.  And I don't know which of DNSHostEntry, FQDN or FullComputerName would be the best to use. Can you have a look at the PR?

I don't have access to customer environments anymore to see what property returns what. Using FQDN vs DNS name can vary based on how their AD and DNS works. I've hit some environments where FQDN for a UNC path did not work and had to use just the server name.
Considering no one else has reported the issue I would hold of making any changes until this is upvoted to indicate it actually needs to be fixed. That is why a number of our issues are left open, unless there is details that prove this is not purely environmental there is no direct need to fix it immediately.

JM2C, the "correcter" version is indeed FullComputerName.
Hard (time sensitivity being an issue) to resolve, but it works also on disjoint domains.
As for the "best method for transfer"..... I hope anyone doing -DetachAttach does it from either the source or the destination, not from a jump server.
As for copying big files over PSSession (does it really work when transferring files from Windows to Linux ? I didn't realize that) do not even start: at least from windows to windows Copy-Item -FromSession and -ToSession are forced to wrap binaries in base64 chunks that get injected in envelopes that are chunked to a fixed size (so even tinkering with MaxEnvelopeSize on the winrm side doesn't do any good) and there's the whole dance about http+soap+eventual encryption on each envelope.

Ok, just found a good workaround, so I will close the pull request.
If we first create the server SMO, we can change the property ComputerName to the FullComputerName:
$null = New-DbaDatabase -SqlInstance SRV1\SQL2017 -Name test01
$source = Connect-DbaInstance -SqlInstance SRV1\SQL2017
$source.ComputerName = (Resolve-DbaNetworkName -ComputerName $source).FullComputerName
Copy-DbaDatabase -Source $source -Destination SRV2\SQL2017 -Database test01 -DetachAttach -Reattach -Verbose

VERBOSE: [17:45:39][Start-SqlFileTransfer] Copying \SRV1.Company.Pri\C$\Program Files\Microsoft SQL Server\MSSQL14.SQL2017\MSSQL\DATA\test01.mdf for test01.
VERBOSE: [17:45:39][Start-SqlFileTransfer] Copying \SRV1.Company.Pri\C$\Program Files\Microsoft SQL Server\MSSQL14.SQL2017\MSSQL\DATA\test01_log.ldf for test01.
Will leave this open for some days and hope @shaddy02 can test that.