Unexpected error occurred with message: Could not retreive AWS credentials, credential value is nil or empty.

Describe the bug
Hello,
Currently in our app we are receiving errors logged from users who seem to be running into this very random auth issue:
APIError: Failed to retrieve authorization token.
Caused by:
AuthError: Unexpected error occurred with message: Could not retreive AWS credentials, credential value is nil or empty.
Recovery suggestion: This should not happen. There is a possibility that there is a bug if this error persists. Please take a look at https://github.com/aws-amplify/amplify-ios/issues to see if there are any existing issues that match your scenario, and file an issue with the details of the bug if there isn't. Issue encountered at:
file: /Users/username/Library/Developer/Xcode/DerivedData/Serenity-ammhovqgzfuogudxbhivmwhannha/SourcePackages/checkouts/amplify-ios/Amplify/Categories/Auth/Error/AuthError.swift
function: recoverySuggestion
line: 80

This is effecting 1/3rd of our user base and these users are unable to make calls using the API category while logged in through the Auth category. Our Auth is using Cognito user pools and hasn't given us much of a headache until this issue started to pop up. From the error's being returned in our error reporting service (Sentry) an API call isn't even made I assume toAmplifyAWSCredentials() throws and stops execution when trying to make the network call.
I've tried countless times to reproduce this issue myself but have been unable to do so. After looking through the Amplify swift package the issue might have to do with the toAmplifyAWSCredentials() function as accessKey and secretKey seem to be nil in this specific case. What I couldn't figure out is if the code path to toAmplifyAWSCredentials() lies within AuthorizationProviderAdapter+SignedInSession or AuthorizationProviderAdapter+SignedOutSession. What is the difference between these two? Any additional information here would be great so I can figure out how the accessKey and secretKey aren't getting set. If there's any additional information I can provide to help track down this issue please do let me know!
As asked for in the Discord:
Configuration File (NOTE: Sign in with Apple is currently included in our awsconfiguration but is not currently in use):
{
    "UserAgent": "aws-amplify/cli",
    "Version": "0.1.0",
    "IdentityManager": {
        "Default": {}
    },
    "CredentialsProvider": {
        "CognitoIdentity": {
            "Default": {
                "PoolId": "us-west-1:{REDACTED}",
                "Region": "us-west-1"
            }
        }
    },
    "CognitoUserPool": {
        "Default": {
            "PoolId": "us-west-1_{REDACTED}",
            "AppClientId": "{REDACTED}",
            "Region": "us-west-1"
        }
    },
    "Auth": {
        "Default": {
            "OAuth": {
                "WebDomain": "{REDACTED}",
                "AppClientId": "{REDACTED}",
                "SignInRedirectURI": "{REDACTED}",
                "SignOutRedirectURI": "{REDACTED}",
                "Scopes": [
                    "phone",
                    "email",
                    "openid",
                    "profile",
                    "aws.cognito.signin.user.admin"
                ]
            },
            "authenticationFlowType": "USER_SRP_AUTH",
            "socialProviders": [
                "APPLE"
            ],
            "usernameAttributes": [
                "EMAIL"
            ],
            "signupAttributes": [
                "EMAIL"
            ],
            "passwordProtectionSettings": {
                "passwordPolicyMinLength": 8,
                "passwordPolicyCharacters": []
            },
            "mfaConfiguration": "OFF",
            "mfaTypes": [
                "SMS"
            ],
            "verificationMechanisms": [
                "EMAIL"
            ]
        }
    },
    "AppSync": {
        "Default": {
            "ApiUrl": "{REDACTED}",
            "Region": "us-west-1",
            "AuthMode": "AMAZON_COGNITO_USER_POOLS",
            "ClientDatabasePrefix": "serenity_AMAZON_COGNITO_USER_POOLS"
        },
        "serenity_AWS_IAM": {
            "ApiUrl": "{REDACTED}",
            "Region": "us-west-1",
            "AuthMode": "AWS_IAM",
            "ClientDatabasePrefix": "serenity_AWS_IAM"
        }
    },
    "S3TransferUtility": {
        "Default": {
            "Bucket": "{REDACTED}",
            "Region": "us-west-1"
        }
    },
    "PinpointAnalytics": {
        "Default": {
            "AppId": "{REDACTED}",
            "Region": "us-west-2"
        }
    },
    "PinpointTargeting": {
        "Default": {
            "Region": "us-west-2"
        }
    }
}

Steps To Reproduce
N/A

Expected behavior
User is able to make API calls through the API Category while authenticated with the Auth Category
Amplify Framework Version
1.28.2
Amplify Categories
API, Auth
Dependency manager
Swift PM
Swift version
5.6
CLI version
10.4.0
Xcode version
14.0
Relevant log output
APIError: Failed to retrieve authorization token.
Caused by:
AuthError: Unexpected error occurred with message: Could not retreive AWS credentials, credential value is nil or empty.
Recovery suggestion: This should not happen. There is a possibility that there is a bug if this error persists. Please take a look at https://github.com/aws-amplify/amplify-ios/issues to see if there are any existing issues that match your scenario, and file an issue with the details of the bug if there isn't. Issue encountered at:
file: /Users/ethanthomas/Library/Developer/Xcode/DerivedData/Serenity-ammhovqgzfuogudxbhivmwhannha/SourcePackages/checkouts/amplify-ios/Amplify/Categories/Auth/Error/AuthError.swift
function: recoverySuggestion
line: 80

Is this a regression?
No
Regression additional context
No response
Device
iPhone SE (2nd generation)
iOS Version
16.0.3
Specific to simulators
No response
Additional context
No response

Also after some searching it looks like this is the exact problem I'm running into: https://github.com/aws-amplify/amplify-swift/issues/1501

I am also experiencing this - any update on this issue?

This issue is also mentioned here: https://github.com/aws-amplify/amplify-flutter/issues/2312
This seems like an urgent issue and should receive attention immediately.

@ethan021021 did this just start happening with 1.28.2?
@michaeljajou can you please confirm which version of Amplify you're experiencing this with? And are you able to reliably reproduce the issue? If so, please post the steps you're taking to do so. Either way, please post your amplifyconfiguration.json (with any confidential information redacted). That will help us in attempts to reproduce.
We're going to take a close look at this tomorrow and I, or someone else, will get back to you here with an update.

@atierian
Amplify (1.28.1):
- Amplify/Default (= 1.28.1)

Amplify/Default (1.28.1)
AmplifyPlugins/AWSCognitoAuthPlugin (1.28.1):

AWSAuthCore (~> 2.28.0)
AWSCognitoIdentityProvider (~> 2.28.0)
AWSCognitoIdentityProviderASF (~> 2.28.0)
AWSCore (~> 2.28.0)
AWSMobileClient (~> 2.28.0)
AWSPluginsCore (= 1.28.1)

AWSAuthCore (2.28.0):

AWSCore (= 2.28.0)

AWSCognitoIdentityProvider (2.28.0):

AWSCognitoIdentityProviderASF (= 2.28.0)
AWSCore (= 2.28.0)

AWSCognitoIdentityProviderASF (2.28.0):

AWSCore (= 2.28.0)

AWSCore (2.28.0)
AWSMobileClient (2.28.0):

AWSAuthCore (= 2.28.0)
AWSCognitoIdentityProvider (= 2.28.0)
AWSCognitoIdentityProviderASF (= 2.28.0)
AWSCore (= 2.28.0)

AWSPluginsCore (1.28.1):

Amplify (= 1.28.1)
AWSCore (~> 2.28.0)

@atierian i haven't been able to reproduce the issue myself, I've only heard it back from a user yesterday. He purchased a new phone, restored from iCloud, and since has been unable to login/create an account with the error showing "an unexpected error has occurred"
So definitely something going on in the auth category.

Ok, thanks. That extra context is helpful. We're looking into this - if you discover anything else or have any other thoughts, please keep us posted here.

Awesome thanks - will do. Another piece that may be helpful was that the user was able to successfully reset their password

Thanks for your patience. We were able to reproduce this issue by fetching the auth session while invalidating the credential cache in the SDK, which is something that can occur in the wild. We have a fix for it here https://github.com/aws-amplify/aws-sdk-ios/pull/4379 and will be cutting a release soon. Once the SDK is released, you'll be able to benefit from the change without updating Amplify. Let us know if you have any questions, thanks!

Awesome news, thank you! I am still on Amplify 2.28.0 - so I will not need to release a new app version with a later version of Amplify you're saying?

You will need to release a new app version. Amplify uses up to next minor versioning for the underlying AWS SDK for iOS (what was fixed). You will likely need to resolve package versions for SPM or pod install for Cocoapods, and confirm that it is now using the correct version of the AWS SDK for iOS. We will update here once the release is complete.

Hi thanks for the quick fix! Will the fix also work for Amplify version 1.28.2? Thank you

Yes, it will. Just make sure that the AWS SDK for iOS dependency is the new version (2.28.2) once it's released.

Any ETA when this will be released?

AWS SDK for iOS v2.28.2 was just released and includes this fix. You can now take the steps I mentioned a few comments up - just please double check that it's actually using v2.28.2 before pushing a new release of your app. Thanks again for bringing this issue to our attention.
I'm closing this issue now. If you have any other questions, concerns, or run into any problems related to this, please comment on this issue.

@atierian I've heard back from a user that this is still happening - but I have a feeling they haven't updated, waiting for a confirmation from them.
Although - I am now on Amplify v2.28.3 - I want to confirm that this fix still applies in that version?
`PODS:

Amplify (1.28.2):

Amplify/Default (= 1.28.2)

Amplify/Default (1.28.2)
AmplifyPlugins/AWSCognitoAuthPlugin (1.28.2):

AWSAuthCore (~> 2.28.0)
AWSCognitoIdentityProvider (~> 2.28.0)
AWSCognitoIdentityProviderASF (~> 2.28.0)
AWSCore (~> 2.28.0)
AWSMobileClient (~> 2.28.0)
AWSPluginsCore (= 1.28.2)

AWSAuthCore (2.28.3):

AWSCore (= 2.28.3)

AWSCognitoIdentityProvider (2.28.3):

AWSCognitoIdentityProviderASF (= 2.28.3)
AWSCore (= 2.28.3)

AWSCognitoIdentityProviderASF (2.28.3):

AWSCore (= 2.28.3)

AWSCore (2.28.3)
AWSMobileClient (2.28.3):

AWSAuthCore (= 2.28.3)
AWSCognitoIdentityProvider (= 2.28.3)
AWSCognitoIdentityProviderASF (= 2.28.3)
AWSCore (= 2.28.3)

AWSPluginsCore (1.28.2):

Amplify (= 1.28.2)
AWSCore (~> 2.28.0)

mamba (2.2.1)
SwiftCheck (0.12.0)
SwiftLint (0.49.1)
SwiftUIPager (2.5.0)`

@atierian I am facing the same issue even in the  version AWSMobileClient 2.34.2, I am using Amplify 1.30.8
Is there anything else that needs to be done to resolve this issue ?

Hi @SESA762550, thanks for reporting this. Please open a new issue including the error message, your amplify configuration, and any logs. Thanks!


Launch API trait cleanups

This PR eases the AsRawFd trait requirements to the sev::Launcher and snp::Launcher. Rather than enforce these traits, we can just have callers pass two RawFds (for the VM's file descriptor and /dev/sev's file descriptor) and avoid all the extra boilerplate that comes along with ensuring these traits are satisfied.
I still want to fix another issue upcoming, which is the enforcement of a lifetime on the launch::Start struct.

Even though I proposed dropping the AsRawFd traits myself, I now have some doubts about it. My main concern here is that RawFd doesn't have a guaranteed lifetime, so if the caller only intends to keep Launcher around after opening /dev/sev with a File, the underlying file descriptor may be closed when the File gets out of context.
I'll play a bit with this next Monday and provide further feedback.

Even though I proposed dropping the AsRawFd traits myself, I now have some doubts about it. My main concern here is that RawFd doesn't have a guaranteed lifetime, so if the caller only intends to keep Launcher around after opening /dev/sev with a File, the underlying file descriptor may be closed when the File gets out of context.
I'll play a bit with this next Monday and provide further feedback.

So, in that case -- the File supplied by Firmware could be owned by Launcher and used while launch measuring is in progress. The one thing we would have to assume is that the vm_fd would be open for the entire launch process (a fair assumption, I think).

Even though I proposed dropping the AsRawFd traits myself, I now have some doubts about it. My main concern here is that RawFd doesn't have a guaranteed lifetime, so if the caller only intends to keep Launcher around after opening /dev/sev with a File, the underlying file descriptor may be closed when the File gets out of context.
I'll play a bit with this next Monday and provide further feedback.

So, in that case -- the File supplied by Firmware could be owned by Launcher and used while launch measuring is in progress. The one thing we would have to assume is that the vm_fd would be open for the entire launch process (a fair assumption, I think).

Yes, keeping AsRawFd allows users to decide whether they want to give Launcher ownership of the object wrapping the file descriptor (i.e. File, which also provides the ability of getting clone via try_clone(), which translates on Linux to a dup()), or just go with a bare RawFd (i.e. Launcher<RawFd, RawFd, Started>).

Closing this and noting that we'll keep the AsRawFd trait.


Fix the layout of 'WHY CHOOSE US' section

Current Behavior

Desired Behavior

Points to be noted

-- Please give the brief desciption of the PR  with required screenshots
-- Pull the repo properly and then make required changes:)
-- We will review it soon and would be very happy to merge your PR
Happy coding 🤩

@akshathar-navada is it ok?

Can you assign this issue to me @akshathar-navada . I'm in gssoc'23

@akshathar-navada is it ok?  I didn't change nav bar intentionally. If I give space in left and right then in small device it doesn't look good.

Okay fine @Git21221 . Can u pls align the divs accordingly, I mean the bullet list div and the content top must be at the same height, as shown in the desired behaviour. Try if u can fix this..

Can you assign this issue to me @akshathar-navada . I'm in gssoc'23

Yes, even u can try solving this issue @SasiVardhan247

@akshathar-navada ,
I have tried this, if you like I would create a pr.
Preview

lg screen

md screen

sm screen

@akshathar-navada check this out.

Let me know about the hover color as well, although someone is working on that issue (2nd pinned issue).


Getting static files from ketcher-react package itself

Can you get static files from the build folder of ketcher-react instead of using staticResourcesUrl and getting files with prefetchStatic? All the static files belong to this package in the end.
library.sdf file might be an exception since it may include project-specific custom molecule templates, and you can get the library.sdf file as a property for Editor instance if you get rid of staticResourcesUrl logic and you can import all other files in the usual way.

In scope of release 2.4 'staticResourcesUrl' will be used only for sdf files. But in scope of release 2.5 we are plan to change work logic with external files.
cc: @mustafacanp

Reopened: Help links leads to page with 404 error. Tested on 2.4


Remove pre/post action having references to build target (xcode crush if build target is at large scale)

since projects usually have a large scale, the env vars an target can have might be a very large list that exceed xcode arg max limit (256 kb) This is resolved in MacOS 11 but for now we should not add the reference to the target so that xcode won't crash.
For use cases where we have to add it back, we can add a new flag for it or consider it when we refactor xcodeproj fule

If the removed key-value pair is set, then all env variables such as SRCROOT, PROJECT_DIR will be present for the script to consume

@gyfelton I have a usecase where I run a script from the preAction. The script is located next to the xcode project. Previously I did:
cd "$SRCROOT" && ./myScript.sh

But now, since SRCROOT is not accessible I am not sure what env variable to use in order to find the script 🤔

Does WORKSPACE_PATH work for you?
On Fri, Sep 10, 2021 at 11:06 AM Andrés Cecilia Luque <
@.***> wrote:

@gyfelton https://github.com/gyfelton I have a usecase where I run a
script from the preAction. The script is located next to the xcode project.
Previously I did:
cd "$SRCROOT" && ./myScript.sh
But now, since SRCROOT is not accessible I am not sure what env variable
to use in order to find the script 🤔
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazel-ios/rules_ios/pull/275#issuecomment-916975817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANQS7NSEBVM3JC6C2Q5WDJDUBINIDANCNFSM5ABOW5BQ
.

@maxwellE I think it will 🙌  Could you point out where is it configured? 🙏

It’s simply provided by Bazel itself, I believe. We use that in our scripts and it works great
Regards,
Maxwell Elliott

From: Andrés Cecilia Luque @.>
Sent: Friday, September 10, 2021 12:42:15 PM
To: bazel-ios/rules_ios @.>
Cc: Elliott, Maxwell L. @.>; Mention @.>
Subject: Re: [bazel-ios/rules_ios] Remove pre/post action having references to build target (xcode crush if build target is at large scale) (#275)
@maxwellEhttps://urldefense.com/v3/__https://github.com/maxwellE__;!!KGKeukY!k-qxq22b_DlfArwfvlsyVNbHMWngb_TyHGcTbiB6xjmIM5v5f7FHpNwCe3CzZba22G5xSN8DUvzBkg$ I think it will 🙌 Could you point out where is it configured? 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/bazel-ios/rules_ios/pull/275*issuecomment-917047585__;Iw!!KGKeukY!k-qxq22b_DlfArwfvlsyVNbHMWngb_TyHGcTbiB6xjmIM5v5f7FHpNwCe3CzZba22G5xSN9xDhZAEg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAEKIOHPHHW6IE6NG7SD5ADUBIYOPANCNFSM5ABOW5BQ__;!!KGKeukY!k-qxq22b_DlfArwfvlsyVNbHMWngb_TyHGcTbiB6xjmIM5v5f7FHpNwCe3CzZba22G5xSN9jMVuNjA$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!KGKeukY!k-qxq22b_DlfArwfvlsyVNbHMWngb_TyHGcTbiB6xjmIM5v5f7FHpNwCe3CzZba22G5xSN_iNXrunQ$ or Androidhttps://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!KGKeukY!k-qxq22b_DlfArwfvlsyVNbHMWngb_TyHGcTbiB6xjmIM5v5f7FHpNwCe3CzZba22G5xSN9PnMzAsg$.

Cool thanks! 🙌 I was just wondering if it is reliable, thus asking where is it defined


Errror loading pretrained model

Where i try to test the model with a diferents weights of netG_epoch_4_1.pth  It shows me the following error:
Traceback (most recent call last):
File "/content/drive/MyDrive/iSeeBetter/utils.py", line 19, in loadPreTrainedModel
model.load_state_dict(state_dict)
File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 845, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for Net:
Missing key(s) in state_dict: "feat0.conv.weight", "feat0.conv.bias", "feat0.act.weight", "feat1.conv.weight", "feat1.conv.bias", "feat1.act.weight", "DBPN.feat1.conv.weight", "DBPN.feat1.conv.bias", "DBPN.feat1.act.weight", "DBPN.up1.up_conv1.deconv.weight", "DBPN.up1.up_conv1.deconv.bias", "DBPN.up1.up_conv1.act.weight", "DBPN.up1.up_conv2.conv.weight", "DBPN.up1.up_conv2.conv.bias", "DBPN.up1.up_conv2.act.weight", "DBPN.up1.up_conv3.deconv.weight",  ...
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "iSeeBetterTest.py", line 213, in
eval()
File "iSeeBetterTest.py", line 95, in eval
utils.loadPreTrainedModel(gpuMode=args.gpu_mode, model=model, modelPath=modelPath)
File "/content/drive/MyDrive/iSeeBetter/utils.py", line 32, in loadPreTrainedModel
model.load_state_dict(new_state_dict)
File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 845, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for Net:
Missing key(s) in state_dict: "feat0.conv.weight", "feat0.conv.bias", "feat0.act.weight", "feat1.conv.weight", "feat1.conv.bias", "feat1.act.weight", "DBPN.feat1.conv.weight", "DBPN.feat1.conv.bias", "DBPN.feat1.act.weight", "DBPN.up1.up_conv1.deconv.weight", "DBPN.up1.up_conv1.deconv.bias", "DBPN.up1.up_conv1.act.weight", "DBPN.up1.up_conv2.conv.weight", "DBPN.up1.up_conv2.conv.bias", "DBPN.up1.up_conv2.act.weight", "DBPN.up1.up_conv3.deconv.weight", "DBPN.up1.up_conv3.deconv.bias", "DBPN.up1.up_conv3.act.weight", "DBPN.down1.down_conv1.conv.weight", "DBPN.down1.down_conv1.conv.bias", "DBPN.down1.down_conv1.act.weight", "DBPN.down1.down_conv2.deconv.weight", "DBPN.down1.down_conv2.deconv.bias", "DBPN.down1.down_conv2.act.weight", "DBPN.down1.down_conv3.conv.weight", ...

I'm facing  the same issue.
In utils.py if you replace model.load_state_dict(new_state_dict) with
model.load_state_dict(new_state_dict, strict = False) then it seems that might work, but this solution will cause other problems to the results. Did you find other solution?

@ipereira-uib Did you solve it? I have the same problem

I don't solve it. If I find the problem I will post it here.  :(

I'm facing the same issue only when I try to load the pre-trained RBPN_4x model in training.
Ok thank you


syntax error near unexpected token `('

After run this line I get error:
source ~/.zsh/zsh-autosuggestions/zsh-autosuggestions.zsh
Error:
-bash:  ! ${+ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_ORIGINAL_WIDGET_PREFIX} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_STRATEGY} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_CLEAR_WIDGETS} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_ACCEPT_WIDGETS} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_EXECUTE_WIDGETS} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_PARTIAL_ACCEPT_WIDGETS} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_IGNORE_WIDGETS} : bad substitution
-bash:  ! ${+ZSH_AUTOSUGGEST_COMPLETIONS_PTY_NAME} : bad substitution
-bash: /Users/mohammad/.zsh/zsh-autosuggestions/zsh-autosuggestions.zsh: line 95: syntax error near unexpected token `('
-bash: /Users/mohammad/.zsh/zsh-autosuggestions/zsh-autosuggestions.zsh: line 95: `		user:_zsh_autosuggest_(bound|orig)_*)'

This extension is for ZSH shells and it seems that you are trying to use it with Bash, which will obviously not work.
Using zsh will fix this.


deps: Use solana-test-validator instead of solana-validator

Problem
solana-validator is a big package, and potentially overkill for testing a CLI, especially since only the test_validator part is used, which is just a re-export of solana-test-validator.
Solution
Use solana_test_validator::* rather than solana_validator::test_validator::*

ooo, yep. thanks!


cibuild Process completed with exit code 6.

Hi, I don't know what this is:
https://github.com/standard-for-public-code/standard-for-public-code/actions/runs/10324228377

That looks like a temporary GitHub error. Try re-run it.

What does it do?

It tests a lot of things. Is the Markdown valid, does added links work, does new files have spdx, are glossary terms used but are not linked to the glossary, are the file names well chosen, and basic spell checking.


Invoke not working if app id contains .

In what area(s)?

/area runtime

/area operator
/area placement
/area docs
/area test-and-release

What version of Dapr?
CLI version: 1.0.1
Runtime version: 1.0.1
Running on Windows in Powershell via CLI.
Expected Behavior
We want to use .NET naming conventions for our services including a dot (e.g. SystemA.ComponentA).
Service invocation via CLI should invoke correct app id if dots are included in name.
dapr invoke -a "app.id" -m "bla" invokes GRPC DAPR service
Actual Behavior
dapr list shows correct app id
dapr dashboard shows correct app id
dapr log shows correct app id (time="2021-04-01T21:42:24.846106+02:00" level=info msg="log level set to: info" app_id=app.id instance=xxx scope=dapr.runtime type=log ver=1.0.1)
However, invokes cause error. Depending on number of dots, app id in error message changes.
dapr invoke -a "app.id" -m "bla"
Error: {"errorCode":"ERR_DIRECT_INVOKE","message":"fail to invoke, id: app.id, err: couldn't find service: app"}
dapr invoke -a "app.id.2" -m "bla"
Error: {"errorCode":"ERR_DIRECT_INVOKE","message":"fail to invoke, id: app.id.2, err: invalid app id app.id.2"}
Steps to Reproduce the Problem
dapr run --app-id "app.id" --app-port 5001 --app-protocol grpc -- dotnet run
dapr invoke -a "app.id" -m "bla"
dapr run --app-id "app.id.2" --app-port 5001 --app-protocol grpc -- dotnet run
dapr invoke -a "app.id.2" -m "bla"
Release Note

RELEASE NOTE:
FIX Support for app ids with . in name

. is a separator to separate app id and namespace. Valid app id format is appid or appid.namespace.


add another language for tesseract

Hi.
First I want to say a great thank to you because your project help alot for my work.
I followed your project to build my own ocr app. It work fine for English. But I'm a Vietnamese and I really want to make this app in Vietnamese. I found a package for Vietnamese language of tesseract but I have no idea how to use it. Can you give me a direction to do it?

How did you make it work?


[PyTorch] Add sliding window support to FlashAttention

This PR only makes changes on the PyTorch side. It

integrates flash-attn 2.3+ sliding window attention to TransformerLayer, MultiHeadAttention, DotProductAttention and FlashAttention
adds unit tests to compare against UnfusedDotProductAttention arbitrary mask, generated based on the window size
adds a use_unfused_attention flag and exception when none of the three DPA backends are available

/te-ci

/te-ci

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

Pipeline 11331817

Pipeline 11412889

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

Also want to add a comment that what happens when we want to use grouped query attention with unfused attention. Right now it seems like it errors out.


plumb docker auther to the depths

this patch accomplishes a few things wrt the docker auth interface used for
configuring credentials to be used for pull:

adds context for timing out the docker auth call
no longer call docker auth before validating an image, we were using this to
validate that a user still has access to an image that we have locally. this
policy itself could be TBD but we're being flagged for hitting registries too
hard, and runners have bounded lifetimes on the order of hours, so we decided
this is ok. now we only call docker auth function when pulling an image, and
it's time used is included in the pull timeout we've so delicately plumbed
adds ability for agents to add call configurations to every call created via
getcall, this ought to help allow fn extenders configure calls and puts us on
the path of getting rid of the call overrider (and is enough to be able to
replace our current one that is causing issues)
adds an option to configure calls to have a docker auth function they
provide, so that fn extenders can plumb this thing into here without having to
fork the driver (which would be absurd!)
some lints...

tested the real deal... i'll fix up the mockers (oops) for ci

actually need to pass in the image name to DockerAuth as well - I'm going to add this here, too

need to wire into lb agent too.. 1 sec


Parsing arrays?

Hey
How can I parse an array of "objects" attribute?
resource "aws_dynamodb_table" "my_table" {
  name = "my_table"
  read_capacity = 1
  write_capacity = 1
  hash_key = "hash"
  range_key = "range"
  attribute {
    name = "hash"
    type = "S"
  }
  attribute {
    name = "range"
    type = "S"
  }
}

Parsing the snippet above, I'm getting:
{ "resource" =>
 { "aws_dynamodb_table" =>
  { "my_table" =>
   { "name" => "my_table",
     "read_capacity" => 1,
     "write_capacity" => 1,
     "hash_key" => "hash",
     "range_key" => "range",
     "attribute" => { "name" => "range", "type" => "S" }
   }
  }
 }
}

but I was expecting attribute to be an array "attribute" => [{ "name" => "hash", "type" => "S" }, { "name" => "range", "type" => "S" }]

attribute is going to be a child hash.
Here is what I got. I hope this helps ya.
var = Rhcl.parse(<<-EOS)
  resource "aws_dynamodb_table" "my_table" {
    name = "my_table"
    read_capacity = 1
    write_capacity = 1
    hash_key = "hash"
    range_key = "range"
    attribute {
      name = "hash"
      type = "S"
    }
    attribute {
      name = "range"
      type = "S"
    }
  }
EOS

var['resource']['aws_dynamodb_table']['my_table']['attribute']

output:
{"name"=>"hash", "type"=>"S"}

@xsmaster but how did you get the second attribute?
    attribute {
      name = "range"
      type = "S"
    }

I want to output an array of attributes.

@phstc here is what I did. I use the pry gem for all my testing. Killer tool.
So in a pry session or irb session I did the following:
1] pry(main)> require 'rhcl'
=> true
[2] pry(main)> var = Rhcl.parse(<<-EOS)
[2] pry(main)*   resource "aws_dynamodb_table" "my_table" {
[2] pry(main)*     name = "my_table"
[2] pry(main)*     read_capacity = 1
[2] pry(main)*     write_capacity = 1
[2] pry(main)*     hash_key = "hash"
[2] pry(main)*     range_key = "range"
[2] pry(main)*     attribute {
[2] pry(main)*       name = "hash"
[2] pry(main)*       type = "S"
[2] pry(main)*     }
[2] pry(main)*     attribute {
[2] pry(main)*       name = "range"
[2] pry(main)*       type = "S"
[2] pry(main)*     }
[2] pry(main)*   }
[2] pry(main)* EOS
=> {"resource"=>
  {"aws_dynamodb_table"=>
    {"my_table"=>
      {"name"=>"my_table",
       "read_capacity"=>1,
       "write_capacity"=>1,
       "hash_key"=>"hash",
       "range_key"=>"range",
       "attribute"=>{"name"=>"hash", "type"=>"S"}}}}}
[3] pry(main)>

So now we have the a hash variable called var.  Since you want to access the "attribute" I did this.
[3] pry(main)> var['resource']['aws_dynamodb_table']['my_table']['attribute']
=> {"name"=>"hash", "type"=>"S"}

So now i have access to the key name or type. if you want it as an array you can do this.
[4] pry(main)> var['resource']['aws_dynamodb_table']['my_table']['attribute'].to_a
=> [["name", "hash"], ["type", "S"]]

The return is an array with two arrays inside. Does this help? What are you trying to do?

I was expecting attribute to be an array "attribute" => [{ "name" => "hash", "type" => "S" }, { "name" => "range", "type" => "S" }]

@xsmaster I was trying to output an array of attributes like that ^ not an array of containing the key and value of the first attribute.

@xsmaster maybe the attribute naming being attribute might be leading into this confusion. But check the snippets in the issue description. I have two attributes and I was expecting an array with the two of them.

Sorry mate. You could take the results and just add them to an array.
On Friday, August 19, 2016, Pablo Cantero<EMAIL_ADDRESS>wrote:

I was expecting attribute to be an array "attribute" => [{ "name" =>
"hash", "type" => "S" }, { "name" => "range", "type" => "S" }]
@xsmaster https://github.com/xsmaster I was trying to output an array
of attributes like that ^ not an array of containing the key and value of
the first attribute.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/winebarrel/rhcl/issues/3#issuecomment-241112689, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF2nlYCCGAvH02NcIy4aUxD2isC3f2vHks5qhgOXgaJpZM4FaL_h
.

@xsmaster I believe we are not at same page. I can easily to the appending or whatever using Ruby, of course.
But this gem: "Pure Ruby HCL parser" is meant to parse HCL, and currently it isn't parsing arrays as I explained in the issue description.
resource "aws_dynamodb_table" "my_table" {
  name = "my_table"
  read_capacity = 1
  write_capacity = 1
  hash_key = "hash"
  range_key = "range"
  attribute {
    name = "hash"
    type = "S"
  }
  attribute {
    name = "range"
    type = "S"
  }
}

This is supposed to return an array of attributes, containing:

[0] name: hash, type: S
[1] name: range, type: S

Sorry a little slow here. I have noticed it only ever returns hashes. :(
On Friday, August 19, 2016, Pablo Cantero<EMAIL_ADDRESS>wrote:

@xsmaster https://github.com/xsmaster I believe we are not at same
page. I can easily to the appending or whatever using Ruby, of course.
But this gem: "Pure Ruby HCL parser" is meant to parse HCL
https://github.com/hashicorp/hcl, and currently it isn't parsing arrays
as I explained in the issue description.
resource "aws_dynamodb_table" "my_table" {
name = "my_table"
read_capacity = 1
write_capacity = 1
hash_key = "hash"
range_key = "range"
attribute {
name = "hash"
type = "S"
}
attribute {
name = "range"
type = "S"
}
}
This is supposed to return an array of attributes, containing:

[0] name: hash, type: S
[1] name: range, type: S

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/winebarrel/rhcl/issues/3#issuecomment-241114764, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF2nldGDyFZamNjxmGofTrKI_XuRHC5sks5qhgXQgaJpZM4FaL_h
.


[Pass][Fix] Merging DecomposeOps and SimplifyNorm

PR (https://github.com/apache/tvm/pull/14282) refactors the pass SimplifyNorm to DecomposeOps. Last rebase leaves the conflicts to be fixed and this PR merges https://github.com/apache/tvm/pull/14282 and https://github.com/mlc-ai/relax/pull/162 together.
The changes mainly include:

func pass -> module pass (Because sometimes we don't want simplify all functions in a module)
Add a mode argument to indicate whether it is a training simplification or eval simplification.

To make the intention clear let us separate into DecomposOpsForTraining and DecomposeOpsForInference

Let us send the change to apache/unity


Replace js-base64 usage with native Buffer

Description

This is more of a "lint" change than actual functional improvements, but it does save a little bytes for everyone 😉
Node.js has a built-in Buffer since forever, so pulling an extra js-base64 dependency is usually unnecessary (some extensions even install it without actually using!). The only valid usage I found is in the ray-so extension, which uses the encodeURI function from js-base64 which has no equivalent in Buffer.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hey @kidonng, could you please resolve the conflicts so I could do the review?

@mattisssa Hi, could you please take another look?


Parameter -IgnoreLegalHold

-ignorelegalhold parameter doesn't exist on Exchange Online cmdlet, article must be reviewed

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc998569-646c-cd20-c3cd-b5d07e6f62ee
Version Independent ID: b7d7d129-9092-8e7d-5bc1-e49e24b54603
Content: Remove-MailUser (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Remove-MailUser.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@GJUNIOR74, the description of the parameter starts with:

This parameter is available only in on-premises Exchange.

And the Applicable: property in the YAML section says:

Applicable: Exchange Server 2010, Exchange Server 2013, Exchange Server 2016, Exchange Server 2019

So, there's nothing to update.
Comments?

Closing due to lack of response.
Thanks for the feedback.


Change viewer default width to "page-width"

This patch also makes sure, that the "Page Width" label stays in the zoom-drop down element and is not replaced by the computed %-value.

Seems there is something broken with my branches - will send a new pull request that is hopefully applyable.


feat: AST based entity refactor

Description
//Yet to update
Fixes #17333
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test A
Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha = 8435205

/ok-to-test sha=8435205

/ok-to-test sha=1273c68

/ok-to-test sha=b3da46c

/ok-to-test sha=b6313cd

/ok-to-test sha=bd6b406

/ok-to-test sha=edfdb7d

This doesn't need QA as this is a non-breaking change and API is yet to be consumed. This will be tested once backend integration is completed. Hence adding test plan approved label.


tutorial_inference_Norman.ipynb is out-of-date

When trying to run the tutorial_inference_Norman.ipynb file, loading the pretrained model generates the following error:
TypeError                                 Traceback (most recent call last)
Cell In[111], line 6
      1 gears_model = GEARS(pert_data,
      2                     device = 'cpu',
      3                     weight_bias_track = False,
      4                     proj_name = 'gears',
      5                     exp_name = 'test')
----> 6 gears_model.load_pretrained('../model/model_ckpt')

File ~/miniconda3/envs/gears/lib/python3.10/site-packages/gears/gears.py:257, in GEARS.load_pretrained(self, path)
    254     config = pickle.load(f)
    256 del config['device'], config['num_genes'], config['num_perts']
--> 257 self.model_initialize(**config)
    258 self.config = config
    260 state_dict = torch.load(os.path.join(path, 'model.pt'), map_location = torch.device('cpu'))

TypeError: GEARS.model_initialize() got an unexpected keyword argument 'cell_fitness_pred'

This is because the model.py file was updated with the commit 8da5e36, which removed the cell_fitness_pred argument, but the model checkpoint provided via
dataverse_download('https://dataverse.harvard.edu/api/access/datafile/6979956', './model.zip') does not use the updated model.

Sorry for the dealyed response! I've updated the tutorial files and this should now work out of the box.

I am still getting this error as of 2024/10/07:
>>> gears_model.load_pretrained('./model_ckpt')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/users/fero3l/env/gears/lib/python3.10/site-packages/gears/gears.py", line 257, in load_pretrained
    self.model_initialize(**config)
TypeError: GEARS.model_initialize() got an unexpected keyword argument 'cell_fitness_pred'

Hi! I want to join in this conversation as well, because I was trying to replicate Fig. 4 and Fig. 5b from the paper as I wanted to create the predictions' metrics heatmap for my own data, and I got the exact same error when loading the Norman pretrained model.
I will try with another dataset but maybe it's something related to the Norman one.
Thanks in advance for the package and help provided~

@ManuelMoradiellos the GEARS_misc package uses a different (older) version of GEARS compared to the main repo. I suggest cloning the GEARS_misc repo and using it by adding the directory to your local path, through something like
sys.path.append('/path/to/GEARS_misc/')
from gears import PertData, GEARS


Add Swift Package Manager support

PR-s appreciated.

See: https://github.com/radex/SwiftyUserDefaults/blob/master/Package.swift

So I tried doing this:
import PackageDescription

let package = Package(
    exclude: ["Sources/Info.plist", "Sources/SwiftyTimer.h"],
    dependencies: []
)

But when I try to build that, I get this error:
test2 » swift build                                                                                ~/Desktop/test2 1 ↵
error: NoSources("/Users/radex/Desktop/test2/Packages/SwiftyTimer-1.3.1-dev/Tests/SwiftyTimerTests.xcodeproj")

Any ideas? I tried adding Tests to excluded folders but it didn't help :(

You'll probably need to wait till this is merged https://github.com/apple/swift-package-manager/pull/152 or rename your tests folder and add it in excludes for now

@aciidb0mb3r Thanks! This works.


Use latest version of Nox for tests.

Also, update lint session to use black to check.
Closes https://github.com/pydata/pandas-gbq/issues/211

Thanks!


add kfp v2 run a pipeline

Some outstanding content, such as cross-section links, to be added once merged into the pipelines-v2-docs branch.

/cc @chensun
for content review

/lgtm

/approve

@chensun, thank you for the lgtm. Can you approve? I am not an OWNER.

/approve


Feature DiffPrivLib: PR for DiffPrivLib go to this branch until ready to go

Oh, I was just going to report issues with non-http exceptions that crash the server. I will check back next week. Thanks.

Coverage report
 Click to see where and how coverage changed
FileStatementsMissingCoverageCoverage(new stmts)Lines missing

  server/lomas_server
  app.py

  constants.py

  server/lomas_server/admin_database
  admin_database.py

  server/lomas_server/dp_queries/dp_libraries
  diffprivlib.py

  diffprivlib_utils.py
31-49, 58-59, 90-95
  utils.py

  server/lomas_server/tests
  test_api.py

  test_api_diffprivlib.py

  test_mongodb_admin.py

  server/lomas_server/utils
  example_inputs.py

  input_models.py

Project Total

This report was generated by python-coverage-comment-action

See here for diffprivlib-logger: https://github.com/dscc-admin-ch/diffprivlib-logger

I think the PR is ready to go. If it is alright with you @lamd91 we can do further work on the scores later!


Docs - Increase verbosity of steps

https://ibm.github.io/datapower-operator-doc/troubleshooting/stale-webhooks/
Step 3 says Repeat Steps 1 and 2, for the ValidatingWebhookConfiguration resource.
Can we please modify this to include full command examples as I miss read this step when I scan read the instructions.

I'm including these changes in PR #11 for our 1.0.1 release.


Markdown: Text to UML Sequence diagram

Hello,
We are looking into Augurk as a possible replacement voor Pickles. For that we would like to have a markdown feature that converts a part of the feature file description to an UML Sequence diagram. https://bramp.github.io/js-sequence-diagrams/ is an example of text to UML Sequence diagram functionality that we are looking for.
Greetings,
Anthony

Sounds like a great feature. PlantUML support would be even better?

Currently our documentation exist of a set of Adoc (some kind of Markdown) files combined with Pickles. This results in a documentation container for every build.
In Adoc we use the PlantUML syntax to define for example Component Diagrams and Sequence Diagrams. These Sequence Diagrams are mostly used to describe the flow of a feature(file). At the moment next to a .feature file we add a .adoc file for the features that have one or more sequence diagrams.
With asciidoctor we generate the documentation for all the .adoc files combined and with the asciidoctor diagram plugin we get our diagrams within the documentation but, this documentation is not integrated with Pickles.
What we would like to have these feature Sequence Diagrams added to the Specflow documentation of that specific feature. We also want to have one integrated opensource tool that is able to furfill these needs.
Preferably we would like to stick to the plantuml syntax but are in a fase that we are still able to switch to a different syntax if needed. As a alternative to the PlantUML system we thought of integrating a javascript framework/plugin that generates the drawings on the fly within the .html files provided by for example Pickles. But we prefer to use a tool that includes these text to digram features instead of reinventing the weel our self.

Later today we hope to release the first part of our effort to support UML, sadly this does net yet includes Sequence Diagrams. Those should follow in the next few weeks.

Similar to the "generic"  UML above we will implement code blocks for sequence diagrams, eg;:
    ```Sequence
    Your sequence diagram
    ```

That looks great! Please notify us when Sequence Diagrams are added!

With the release of 2.8.0 we have also enabled support for sequence diagrams:


Fix Inductor bench BC change

Fixes https://github.com/pytorch/ao/issues/637

@msaroufim left some comments, I'm not sure if this resolves the BC changes (sorry if I'm just confused here on what is happening)


login with key-auth

Currently when there are two auth methods, they must both be accepted. So when I have api-key auth enabled AND username:password enabled, both must be authorized to work. KongDash ought to have a way to pass an apikey header for logging in


Notifications: Hide system notifications when expired

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.

Client

[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I documented the TypeScript code using JSDoc style.

Motivation and Context
Is a bugfix for issue #1328.
System notifications now disappear from the GUI when they expire.
Description

I added a setTimeout mechanism that is triggered/updated when Artemis is (re)loaded or the admin deletes/updates/creates a system notification.
(I also notice a couple of other issues with the current system notification implementation but resolving them seems to be a way bigger task (and I currently already have quite a lot of work to do))
Steps for Testing
Log in as an Admin.
Create/update a system notification so there is at least one active system notification. (Set the expiration time to be ca. 2-3 minutes)
This notification should be shown.
Wait until the expiration date is reached.
The notification should disappear.
If another notification is active at the same time it should be visible now instead.
Review Progress
Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage
TODO ADD actual coverage!

I know I can fix this issue but the system notifications have multiple issues (which can also be seen by looking at multiple other related open GitHub Issues). It feels wrong to fix a bit of a more or less broken system. The core of the system notifications has critical design issues. I studied the code and it was created with only one active notification in mind (not multiple). (This is also already a GitHub Issue).
To properly solve these issues the system notifications have to undergo a big full-stack refactoring.
I closed this PR because I currently have other features and issues to solve and simply have no time to spend on a major refactoring.


Swap oldValue and newValue for metachange events

These events don't match the ones in the docs. Came across this when testing it in-game. I copy-pasted the localMetaChange event and the newValue was undefined.
@xxshady confirmed it on discord, so here's the PR :)

Thanks


Make GenericCredentials less opinionated; add KeyValueCredentials (#921)

Changes GenericCredentials so it holds an AuthScheme and a value, nothing else (address #921).
Renamed previous GenericCredentials to KeyValueCredentials and updated throughout.

Sounds good to me, though the map based credentials are used in a number of
tests which I don't think I'll have time to update.
On Fri, May 12, 2017, 5:25 PM Ross A. Baker<EMAIL_ADDRESS>wrote:

@rossabaker commented on this pull request.
Thanks! See comment on the generic credentials test, which gives me pause.
In tests/src/test/scala/org/http4s/parser/AuthorizationHeaderSpec.scala
https://github.com/http4s/http4s/pull/1184#discussion_r116344700:

   val invalidTokens = Seq("f!@", "=abc", "abc d")

   forall(invalidTokens) { token =>
     val h = Authorization(OAuth2BearerToken(token))
     hparse(h.value) must be_-\/
   }
 }

"Parse a GenericCredential header" in {

 val scheme = "token"

 val token = "adsfafsf2332fasdad322332"

 val h = Authorization(GenericCredentials(scheme.ci, token))

What happens if you create a KeyValueCredentials and try to parse it
back? I bet you get a GenericCredentials. The parser can tell from the
scheme which concrete type to parse. Now there are two types without a
specific scheme.
I think maybe we keep your GenericCredentials and bid farewell to the
map-based generic credentials. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/http4s/http4s/pull/1184#pullrequestreview-37966166,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABJAci7GuX2wAbGcZ_hnu0w0vmpJj46ks5r5PiHgaJpZM4NZ5qO
.

Actually we can distinguish them.  The value is either a token68 or a series of auth-param, as defined in (RFC7235)[https://tools.ietf.org/html/rfc7235].  A parser should be able to distinguish them and round trip through either type.
If you want to take a crack at that, great.  If not, I've got a long flight tomorrow.

Please do!
On Sat, May 13, 2017, 8:23 PM Ross A. Baker<EMAIL_ADDRESS>wrote:

Actually we can distinguish them. The value is either a token68 or a
series of auth-param, as defined in (RFC7235)[
https://tools.ietf.org/html/rfc7235]. A parser should be able to
distinguish them and round trip through either type.
If you want to take a crack at that, great. If not, I've got a long flight
tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/http4s/http4s/pull/1184#issuecomment-301288472, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABJAQBXA8L61PAYOurdtrDF-XiO0eueks5r5nO-gaJpZM4NZ5qO
.

So the change I pushed addresses my concerns with the round tripping.  I think we can now represent every Authorization header that's valid, so that's progress.
I'm questioning the specificity of the types we have a bit.  Why does Basic and OAuth2 bearer get a class while OAuth1 does not?  ("Because Spray did" is not a good answer.)  How do we extend this to more authorization schemes without breaking changes?  Should we just have flat credentials with a series of smart constructors and extractors for common cases?  Doesn't this smell a bit like the header typeclass discussion?
I think we can go ahead with this to get something out there that covers all authorization types, but I'm not sure that we wouldn't benefit from some more (breaking) refinement to this model.

How do we extend this to more authorization schemes without breaking changes? Should we just have flat credentials with a series of smart constructors and extractors for common cases?

After workign with this code, I think Credentials is sealed because that makes parsing easy - with a known set of subclasses, the parsing code doesn't need to be extensible (by library user's). With this update I don't know if we need more extensiblity - 'Generic' should really cover anything now.
Thanks for the hard work! Looking forward to using this.

I think the need for extensibility is orthogonal to this change.

We couldn't represent all valid credentials before, now we can.
Users couldn't specifically model additional schemes before, and still can't.

There is a registry of schemes that might plausibly have modeled credential types.  The problem in the existing model is that we picked two (Basic and Bearer) and if we ever decide to implement more, it's a breaking change.  That's what has me starting to think about having raw credentials and typeclasses for modeling, much like the proposal for headers.  It's a little complicated, because unlike case class RawHeader(key: CIString, value: String), there are two kinds of values for raw credentials: the token and the param list.
sealed abstract class GenericCredentials(scheme: CaseInsensitiveString)
final case class TokenCredentials(scheme: CaseInsensitiveString, token: String)
  extends GenericCredentials
final case class AuthParamCredentials(scheme: CaseInsensitiveString, params: NonEmptyList[(String, String)])
  extends GenericCredentials

And then constructors and extractors for Basic, Bearer, and everything else in the registry could be built on that.
If those names and that model seem reasonable for the long term, maybe we massage this PR now into those names.  That way we can ship the fix to your problem quickly, and minimize breakage when the rest follows.

I wonder if AuthParamCredentials is really a primitive. That is, a parameter list is just a token with separators, right? Could that be built on top of just TokenCredentials? Then you don't need an abstract class at all (just a trait or concrete class).
In any case, I like the direction.

That's a good question.  There are certain strings that are illegal: key-value pairs need to have values.  Tokens have a restricted alphabet, including equals signs at the end.  We can't just accept arbitrary strings as the value.
We could have a single class that's Either[Token, NonEmptyList[String, String]], but that seems unpleasant to work with.
😕

There are other things that are ready for release.  @m4dc4p, does this look good in present form, knowing that we might tweak things a bit later?  This should at least unblock your use case.  I'm thinking about a release tomorrow.


BUG 3D Gradshim

3D gradient shimming can fail from an uninitialized $isvnmrj macro variable. Reported in SpinSights.

Fixed with commit #138


fix(mainfest): missing _bg.js file in package.json

Make sure these boxes are checked! 📦✅

[ x] You have the latest version of rustfmt installed and have your
cloned directory set to nightly

$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly

[ x] You ran rustfmt on the code base before submitting
[ ] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

thank you so much, i am so sorry i missed this somehow when you filed. much appreciated.


PHP code inside SQL

Describe the Feature
I have the following SQL
SELECT
   test
FROM
    test t
WHERE
    t.date <= TO_DATE('" . date('Y-m-d') . "', 'YYYY-MM-DD')

with the following settings
{
  language: 'sql',
  tabWidth: 4,
  keywordCase: 'upper',
  functionCase: 'upper',
  identifierCase: 'lower',
  linesBetweenQueries: 1,
  paramTypes: {
    custom: [
      { regex: String.raw`\{\$?[\w\d\->\[\]]+\}` },
      { regex: String.raw`\$[\w\d\->\[\]]+` },
      { regex: String.raw`['"]\s?\..*\.\s?['"]` },
    ],
    positional: true,
    named: [':', '@'],
  },
}

but what it dows is transforms PHP code
// from
date('Y-m-d')

// to
date(' y - m - d ')

resulting in this SQL
SELECT
    test
FROM
    test t
WHERE
    t.date <= to_date ('" . date(' y - m - d ') . "', 'YYYY-MM-DD')

How to avoid this transformations and leave everything between " . here . " untouched?

The problem is that you're trying to match the string between double quotes:
" . date('y-m-d') . "

with a regular expression
['"]\s?\..*\.\s?['"]

This would work, but the problem is that this string is also inside singe quotes:
'" . date('y-m-d') . "'

That regex would only match from the second character of this string, so it won't succeed. Next sql-formatter will try to match a single-quoted string token, which will succeed, matching the part within single quotes:
'" . date('

It will then continue detecting the following tokens: y, -, m, -, d, ') . "'.
I guess you'll need to cover this case with another more specialized regex. Though fundamentally you can't parse PHP with a regular expression. Hopefully you know the limitations of this approach.

The problem is that you're trying to match the string between double quotes:
" . date('y-m-d') . "

with a regular expression
['"]\s?\..*\.\s?['"]

This would work, but the problem is that this string is also inside singe quotes:
'" . date('y-m-d') . "'

That regex would only match from the second character of this string, so it won't succeed. Next sql-formatter will try to match a single-quoted string token, which will succeed, matching the part within single quotes:
'" . date('

It will then continue detecting the following tokens: y, -, m, -, d, ') . "'.
I guess you'll need to cover this case with another more specialized regex. Though fundamentally you can't parse PHP with a regular expression. Hopefully you know the limitations of this approach.

Thank you! You are absolutely right. I change my config to
{
  language: 'postgresql',
  tabWidth: 4,
  keywordCase: 'upper',
  functionCase: 'upper',
  identifierCase: 'lower',
  linesBetweenQueries: 1,
  paramTypes: {
    custom: [
      { regex: String.raw`\{\$?[\w\d\->\[\]]+\}` },
      { regex: String.raw`\$[\w\d\->\[\]]+` },
      { regex: String.raw`['"].*['"]` },
    ],
    positional: true,
    named: [':', '@'],
  },
}

and everything works

This ['"].*['"] regex is likely not what you want. It will override the builtin double- and single-quoted strings/identifiers matching in SQL Formatter with a broken implementation. You really should use something more specific than that.

This ['"].*['"] regex is likely not what you want. It will override the builtin double- and single-quoted strings/identifiers matching in SQL Formatter with a broken implementation. You really should use something more specific than that.

I've tested some queries, everything seems to be fine

Well it's your call if you want to shoot yourself in the foot, but already in this example SQL, this regex will match the following:
'" . date('Y-m-d') . "', 'YYYY-MM-DD'

That is, it will greedily match everything between first and last quote. It will also happily match from " to ' if it sees the opportunity.


feat: clamAV malware scanning for attachments

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe applicant result is failed for https://helsinkilisa-ui-pr2894.dev.hel.ninja :crying_cat_face::anger::boom::boom:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe applicant result is failed for https://helsinkilisa-ui-pr2894.dev.hel.ninja :crying_cat_face::anger::boom::boom:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr2894.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2894.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2894.dev.hel.ninja :laughing::tada::tada::tada:


New version: Catsxp.Catsxp version <IP_ADDRESS>

This pull request is automatically generated by 🥟 Dumplings in #3150
Microsoft Reviewers: Open in CodeFlow

Sequence contains no elements

Sequence contains no elements

#133371

Automatic Validation ended with:

2024-01-18T08:00:01.9289620Z -----------------------------------------------------
2024-01-18T08:00:01.9294060Z Status: Started
2024-01-18T08:00:01.9299178Z Manifest file is Added
2024-01-18T08:00:02.0552355Z ##[warning] Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended. Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended. Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended. Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended.
2024-01-18T08:00:02.1553008Z Manifest content validated.
2024-01-18T08:00:02.1558129Z Manifest contains installer: https://catsxp.oss-cn-hongkong.aliyuncs.com/x86/catsxp_installer_121_4_1_4.exe
2024-01-18T08:00:02.1570930Z Manifest contains installer: https://catsxp.oss-cn-hongkong.aliyuncs.com/x86/catsxp_installer_121_4_1_4.exe
2024-01-18T08:00:02.1644153Z Manifest contains installer: https://catsxp.oss-cn-hongkong.aliyuncs.com/x64/catsxp_installer_121_4_1_4.exe
2024-01-18T08:00:02.4932719Z -----------------------------------------------------
2024-01-18T08:00:02.4936452Z Status: Started
2024-01-18T08:00:02.4943281Z Manifest file is Deleted
2024-01-18T08:00:02.7703987Z Status: Completed
2024-01-18T08:00:02.8049485Z ##[error] Result: Failed
2024-01-18T08:00:02.8158970Z ##[error] Sequence contains no elements
2024-01-18T08:00:02.8607342Z ##[error]Manifest Validation Failed
2024-01-18T08:00:02.8612306Z

(Automated response - build 675.)

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

(Automated response - build 675.)


pre-commit: add more checks

"flake8-comprehensions"
"flake8-mutable"
"flake8-simplify"
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

/verified

/verified

/verified

/approve


0441

Pull Request Test Coverage Report for Build 4577

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.705%

Totals

Change from base Build 4555:
0.0%

Covered Lines:
2807

Relevant Lines:
6831

💛  - Coveralls


Get CHC to pass pydocstyle

Description
Fix docs on chc indicator so pydocstyle passes.
Changelog
Itemize code/test/documentation changes and files added/removed.

Fix linting errors
Enable pydocstyle to run in makefile so it gets run on CI

Fixes

n/a

Ah sorry, this collided with the CHNG-DV signal changes. Would one of you resolve conflicts?

Ah sorry, this collided with the CHNG-DV signal changes. Would one of you resolve conflicts?

will do

conflicts resolved


debuggerWorker.js contains code incompatible with node 5

Hi,
This is a small fix for issue #10564.

@facebook-github-bot shipit

Any idea why exactly this doesn't work? This code is in strict mode, so let should work fine.


Add BIT(n) to INT docs

This PR adds a Length section to our INT type docs. That section covers using BIT(n) to limit decimal integer values based on the length of their corresponding binary integer values.
@knz, @bdarnell, did I miss or get anything wrong? Also, @knz, do we need to update the Supported Casting & Conversion section?
Fixes #580

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4c6f5a0c2175caff5c911c53f0822bbc7611a064/

Conversions are not affected since we only check the width constraint upon storing the value in the database. (which in turn may be a bug, but that's an orthogonal issue)

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2c93376099ac7f35f20fec5e11b90e1fdd4b44a9/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/75c56f9bbab85eea812c9f2d8e078b15ac3027f9/

lgtm

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dda11e18f2e8a6e6db8fe65ea46bf886bd9bf6d1/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b9bcadef2fd8501dd085114384a65f81afb42d22/


Make sure style not violate Effective C++ guidelines

Add -Weffc++ check flag and modify related code

Hi @cy-lee - thanks for contributing 👍
The PR generally looks good. There's a minor indentation issue in CMakeLists.txt (rapidcsv only uses space indentation, no tabs), but I can fix that up post merge, no big deal.
I'll just do some more read up on -Weffc++, but I will probably be able to merge it this weekend.

Hi @d99kris , I replaced the tab with spaces. Thanks

Hi @d99kris , I replaced the tab with spaces. Thanks

Great, thanks! 👍  Looks good!


Add benchmark suite for performance of parsing date-formatted string

Add benchmark suite (in source code, runParse()).
I have separated it from existing suites because its performance is not dependent on operating instance with time-zone.

@CasheeeewNuts Thanks!
#### parse()
## cdate:	2022-01-01T12:00:00.000+09:00
## moment:	2022-01-01T12:00:00.000+09:00
## dayjs:	2022-01-01T12:00:00.000+09:00
## luxon:	2022-01-01T12:00:00.000+09:00
cdate x 462,458 ops/sec ±0.36% (98 runs sampled)
moment x 122,002 ops/sec ±0.25% (98 runs sampled)
dayjs x 366,511 ops/sec ±0.38% (98 runs sampled)
luxon x 258,086 ops/sec ±0.48% (93 runs sampled)
## Fastest is cdate

You're right that it's one of the most common usecases for these libraries to parse and display MySQL DATETIME strings.
The bench result inculudes time spent by .format() by the way.
-   console.warn(`#### parse()`);
+   console.warn(`#### parse().format()`);
    await runBenchmark({
        cdate: () => cdate("2022-01-01 00:00:00").format(COMPAT_FORMAT),

I'd love to include the patch at the next release anyway.

Thank you for reviewing! I have just fixed, and push.


Create Integration tests for SLP Indexer

@SpendBCH and I conducted some tests yesterday to validate balances being reported by the different SLP indexers.
The method we used was to look at old mainnet SLP tokens that have small numbers of transactions (a small DAG). For instance, here the genesis TXID for a token with only 2 addresses holding balances and only three transactions:

023cd3e95a3947058b994fd15a9a4c47937a9d9b6e0c0b1b5898d2ce84f354e4

By using tokens like this, we were able to manually verify the results we were getting from SLPDB queries, the block explorer, and the Java Indexer. I asked Simple Ledger if they had developed any automated tests like this, that could be used to validate the data coming back from fully-synced SLPDB instances. They said there were no tests like this.
The scope of this issue is to create a series of Integration tests that can be run against SLPDB and the Java SLP Indexer to verify accurate balances for specific tokens where the balances can be validated manually.

A first step for this task would be to create a candidate list of mainnet SLP tokens. Tokens that would make good candidates for this kind of test.


Code Form - Save updated data

Related to #108
If data for a project was updated in the form, create a branch and push it to Github

There's a few directions we can go here. I think the roadblock right now is how to get the code from a repo submitted to the upstream as a pull request. Basic Git functionality is provided by Isomorphic Git.
To manage the PR, we could submit it anonymously using something like GitMask or PRBot. GitMask doesn't require a GitHub token, which would be nicer to work with. Both are open source, so we can self host if that is a concern for us.
@BassamAjam Do you want me to take a whack at this?

Great! GitMask is a good idea. And yes we can work together on this task.

Gitmask looks interesting.  Although, it would be good to know who is contributing pull requests so someone can validate the data being submitted (contact email, ..).

@smellems Yeah good idea. We can add the submitter as the commit author, then either GitMask or PRBot will handle the PR.
I've tracked the issues upstream, as neither of those libraries allow us to specify the commit authors. GitMask. PRBot.  I'm thinking PRBot will probably be the way to go. The whole purpose of GitMask is anonymity, whereas PRBot is really exactly what we need.
In addition to the commit author, we could set their email in the commit message or the PR message.

Hi @j-rewerts you can specify commit authors with PRB0t, but you would always need to use the OAuthToken that you want the user accredited for.
There is no possibility to do it in different way with GitHub apis.
Alternative you can look at Co-authored-by option that is available in GitHub, and you can give credit to users trough the commit description.

@M3kH I've managed to find a way! I'll submit as a PR to PRB0t today.
Closing, as it was resolved in #139.


BaseUrl is null at DeviceFactory.CreateDeviceAsync (IPAddress)

The creation of the Fritzbox device differs between CreateDeviceAsync (IPAddress) and LocateDevicesAsync ().
Is it wanted like that ??

Hello,
the main reason is that these are two fundamentally different approaches.
With the DeviceLocator and the related functionalities the network is searched for all responding devices and on this basis the FritzDevice instance is formed.
All this is not mapped at all via the CreateDeviceAsync method. However, the factory has unfortunately been completely overlooked in the latest adjustments as well.
When the opportunity arises, this will be fixed. However, I don't see that it has a particularly high priority at the moment.
I hope this is OK. Otherwise you are of course free to open a pullrequest, which will be taken over into the code after checking.

For me that's ok, but I think the time differences to create a Fritzbox are quite large depending on the network. so it would be good if you can do it via the ip. Especially if you only have one Fritzbox in the network. In addition, when creating via the Ip, the BaseUrl must be supplied for each service client. Just as a suggestion for a next release.


ibus-daemon's Preferences window does not appear

Issue description
ibus-daemon's "Preferences" window does not appear.
Steps to reproduce
Start ibus-daemon. Right click the system tray icon, click "Preferences". Nothing appears.
This started somewhere between e0771a241092deb0a09341607adf0f24c749c037 (works) and ba22ad45fef4cef2c180895ce1af4333d286be16 (doesn't work).
This is on a plain X server + XMonad setup.
Technical details

System: NixOS 18.03.git.cfafd6f (Impala)
Nix version: 1.12pre5663_c7af84ce
Nixpkgs version: 17.09 release
Sandboxing enabled: yes

Here's the problem, directly caused by 3378dbbeed1e69050308a4c45dd9eecc5b92567d:
[pid 28665] execve("/nix/store/w3ak8w2w0fv1hmcjx1l8g6r1rg4lvpbh-ibus-1.5.16/bin/ibus-setup", ["/nix/store/w3ak8w2w0fv1hmcjx1l8g"..., "ibus-setup"], 0x7ffdcf8b7e08 /* 97 vars */) = -1 ENOENT (No such file or directory)
[pid 28665] +++ exited with 1 +++

ibus-daemon needs to invoke ibus-setup when the user wants to configure ibus, so I don't see the point in removing it from the ibus closure: if ibus can't find ibus-setup one way or another, ibus doesn't function correctly.
/cc @edolstra

Try #31094.

Is this fixed? It's working fine on my machine.

Resolved in #31094.


ci: attempt to fix random AppDomain unloads in CI on macos/mono

Disables xunit's AppDomain logic.
Hopefully this resolves the random CI failures related to loading satellite assemblies (for resource files) on Mono/.NET 4.6.2.
All other frameworks were unaffected.

Seriously contemplating nuking the CI tests on Mono/.NET 4.6.2. With this change, the appdomain unload exception seems gone, but now other CI errors start randomly occurring. Restarting the job, it just passes, flaky as hell.


Add Awesome (Apache) Spark

https://github.com/awesome-spark/awesome-spark
Apache Spark is a popular data processing framework and of the most active open source projects today.
By submitting this pull request I confirm I've read and complied with the below requirements.
Failure to properly do so will just result in the pull request being closed and everyone's time wasted. Please read it twice. Most people miss many things.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title. For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.
The list I added

has been around for at least 30 days,
is the result of hard work and is the best I could possibly produce,
is a non-generated Markdown file in a GitHub repo,
is not a duplicate,
includes a succinct description of the project/theme at the top (example),
includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),
only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
contains the awesome badge on the right side of the list heading,
has a Table of Contents section named Contents as the first section,
has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc) (If you use a license badge, it should be SVG, not PNG),
has contribution guidelines,
doesn't include a Travis badge,
has been checked for inconsistent formatting, spelling, and grammar:

Each link description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent naming. For example, Node.js, not NodeJS or node.js.

cc @eliasah

LGTM

includes a succinct description of the project/theme at the top (example),

Not followed.

The logo should be high-DPI, so set it to maximum half the width of the original image.

Not followed.

If you use a license badge, it should be SVG, not PNG

Not followed.

ping @zero323

I believe these are OK now @sindresorhus.

These are not done:

includes a succinct description of the project/theme at the top (example),
Not followed.

Still not. I see no description of Apache Spark at the top of your readme.

The logo should be high-DPI, so set it to maximum half the width of the original image.
Not followed.

The image doesn't exist anymore.

I don't see much interest from other contributors, and personally I have other thing on my mind,  so I don't think we'll be pursuing this after all. Sorry.

I think you're giving up too easily. It takes more work to interest contributors, and being on this list definitely helps that, but if you're not willing to put in that work, I totally understand :)

Updated Readme with an Apache Spark description, is the image OK?
@sindresorhus

Yup. Added.


Support spatial data extensions

At the very least, support for the POINT field type would be nice to have, and the ability to create a spatial index.

^^ +1

Is there any news about this?


[express-apollo-prisma] Unit tests for Queueing

Type of change
Closes #1099

[ ] Documentation change
[ ] Bug fix

Summary of change
Add tests for generator endpoint
Checklist

[ ] These changes follow the contributing guidelines
[ ] This starter kit has been approved by the maintainers
[ ] Changes for this new starter kit are being pushed to an integration branch instead of main
[ ] All dependencies are version locked
[x] This fix resolves #1099
[ ] I have verified the fix works and introduces no further errors


Fix updating on Windows by waiting on slave process using psutil

Closes #25
Ref #61

[x] Test on Windows (multiple updates)

Updating on Windows (core-win64) is working as expected (successfully waits for the slave process to exit)

[x] Test on Linux (multiple updates)

Updating on Linux (core-linux64) is working as expected (without any changes)

Is the README.md acceptable like this?

Acceptable, but I would rephrase "using a single non-standard library" to something like "using minimal requirements:" and then list both as bullet points. Love the requirements.txt. If I come back before you have a chance to update, I will do that in the merge.
Thank you again! I hope this turns out to be useful for you.

Updated, like this?


[Change Request] Page 30 "Item Card" – Procedure CreateItemFromTemplate passed empty Item record (w/o filters)

In the CreateItemFromTemplate procedure from "Item Card" page, the InsertItemFromTemplate function is called, but a completely empty local variable is passed. And this means that if the record was previously filtered, then if the templates are active, we lose these filters.
I suggest passing a record with filters to the procedure, or adding an additional parameter so that we can absolutely accurately determine the entry point when creating an item with a template.

Hi @Drakonian .
Could you be so kind to share the scenario behind your request? For example, you will be able to set filters on the "Item" variable before call of InsertItemFromTemplate(), what will you do with them?

@Drakonian , and one more question. Even when you filter item list, then open the card (or create new directly from the list), and try to create new item, there are no filters on the Rec. From where do you plan to get them?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


sc.esRDD(...) how to specific ElasticSearch IP address?

I need to create an RDD from an ElasticSearch index as follow
sc: SparkContext
sc.esRDD("myindex/mytype")
This only talk to ElasticSearch instance at localhost:9300. How can I change it to talk to a different ElasticSearch instance with IP <IP_ADDRESS> and port 9400?
By the way, is there a discussion forum for asking questions regarding Spark/ElasticSearch integration?

https://discuss.elastic.co
and this is how you do it in java
sc.set("es.nodes", "");
sc.set("es.port", "");

@ningjun It is mentioned in the reference documentation.
As for discuss.elastic.co it was already mentioned.
Out of curiosity, how did you find out about Elasticsearch Spark ? Both these resources are mentioned in Github and the homepage and I'd like to understand how to better advertise them.
Thanks,

Our architect heard about Soark/ElasticSearch integration in the Spark Summit conference and then decide to try it out.
Ningjun
From: Costin Leau<EMAIL_ADDRESS>Sent: Tuesday, July 14, 2015 12:46 AM
To: elastic/elasticsearch-hadoop
Cc: Wang, Ningjun (LNG-NPV)
Subject: Re: [elasticsearch-hadoop] sc.esRDD(...) how to specific ElasticSearch IP address? (#496)
@ningjunhttps://github.com/ningjun It is mentioned in the reference documentationhttps://www.elastic.co/guide/en/elasticsearch/hadoop/current/spark.html#spark-native-cfg.
As for discuss.elastic.co it was already mentioned.
Out of curiosity, how did you find out about Elasticsearch Spark ? Both these resources are mentioned in Github and the homepage and I'd like to understand how to better advertise them.
Thanks,
—
Reply to this email directly or view it on GitHubhttps://github.com/elastic/elasticsearch-hadoop/issues/496#issuecomment-121131710.


Fixing memory leak in example

Partially reverting changes: remove changes to gather

This fixes #2121, this time for sure.

I see that the receive_buffer is left unchanged this time. Did you test that memory leak is gone even without clearing it? I thought that we have one dangling send on the last timestep.

Yes, I checked. All memory which was leaking before is now properly free'd. The last commit also adds assertions making sure the receive_buffers are empty at destruction.

Excellent! LGTM!


allow to debug compiler service core using --dev flag

These changes are already merged in master. Other changes related to debugging will be implemented in separate PRs.


console. -> Log.

With this, we no longer need to deactivate the linter rule no-console.

Is that this module? https://www.npmjs.com/package/logger
Do we have that by default or does it come with Magic Mirror?

This is a module that is built directly into MagicMirror: https://docs.magicmirror.builders/development/logger.html

Okay - now I just wonder does their statement:

The Loggers is currently only available in the core module file (not in the node_helper).

only mean that the require is needed?

only mean that the require is needed?

Yes, exactly. I have already created a PR to make this more precise in the documentation. There are some other modules that also use the logger from MagicMirror in the node_helper.


Pre-publish Checklist: remove 'Turn off Page Attachment or remove conflicting links' checks

Context
Per design discussion: Currently, you're not allow to add link to the page attachment area. If you attempt to drag a link to the page attachment area, we message you and tell you that the link will not be clickable by your users. I think this might be enough to cover this use case. WDYT about eliminating this rule or at least making it non critical. so we are removing it.
Summary
Link attachment conflict is no longer displayed if
Relevant Technical Choices
n/a
To-do
n/a
User-facing changes

Testing Instructions

Open a new story
Add anything to the editor and give it a link in the design panel
Move it to the bottom of the page outside the safe zone
Open the prepublish checklist
There should be no recommendation to "Turn off Page Attachment or remove conflicting links"

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Open a new story
Add anything to the editor and give it a link in the design panel
Move it to the bottom of the page outside the safe zone
Open the prepublish checklist
There should be no recommendation to "Turn off Page Attachment or remove conflicting links"

UAT

[x] UAT should use the same steps as above.

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #7149

Should this tooltip be removed too?

This ticket was for the PPC, but I think it would make sense to remove that here too.

I think it needs to stay, per this comment from Sam on the text string doc that specified removing this rule:
If you attempt to drag a link to the page attachment area, we message you and tell you that the link will not be clickable by your users. I think this might be enough to cover this use case.


Update temporary OCP image override

quay.io/vrutkovs/kni-release:mar14 is the updated tag since there
were issues with the build from yesterday

cc @vrutkovs @markmc this works well for me now

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/230/


I24 serial: Set up a small pydantic model for parameters

The experiment parameters are currently being set on the edm screen and saved to a file before (for chip) or at the very beginning (for extruder) of the collection. This file is then opened multiple times across the code to get some of these values.
Set up instead
A basic model should be fairly simple and usable by both experiment type eg.
class SerialExptParams(Model):
    visit: str
    filename: str
    exposure_time: float
    detector_distace: float
    pump_probe: bool
   ...

For the chip there will be a couple more classes defining the chip/mapping settings.

Small additional note: this might help with #77


Document LMs Supported for MRC

aferritto created the following on Apr 29:
See MRC tests parameterization for list of model names which are validated.  Note this includes english only models whereas tydi is multilingual.
Original issue: https://github.ibm.com/ai-foundation/PrimeQA/issues/168

I think this is done. @bhavani105 please confirm if we can close this.

MRC tests currently only test the english models. There is no test for xlm-roberta.  Given the constraints of Github Actions resources, it would be difficult to add  expand the list of models.


Use instance affinity policy on ibm_pi_volume

In reference to https://github.com/IBM-Cloud/terraform-provider-ibm/pull/2800 fix on the pi_volume resource, we need to use the instance affinity policy on the volume that are created by the automation.
With this option we don't need the volume_type aka diskType. This will prevent the errors we are getting recently on some regions due to storage pool placement. Also, there is no need of existing logic where a data source fetch the storage type from the image.
Note that this fix will be released in the next iteration of IBM provider plugin.

@bpradipt @Prajyot-Parab

resource "ibm_pi_volume" "volume" {
  count = var.storage_type == "nfs" ? 1 : 0

  pi_volume_size       = var.volume_size
  pi_volume_name       = "${var.name_prefix}-${var.storage_type}-volume"
  pi_affinity_policy   = "affinity"
  pi_affinity_instance = ibm_pi_instance.bastion[count.index].pi_instance_name
  pi_volume_shareable  = var.volume_shareable
  pi_cloud_instance_id = var.service_instance_id
}

resource "ibm_pi_instance" "bastion" {
  count = local.bastion_count

  pi_memory            = var.bastion["memory"]
  pi_processors        = var.bastion["processors"]
  pi_instance_name     = "${var.name_prefix}-bastion-${count.index}"
  pi_proc_type         = var.processor_type
  pi_image_id          = local.bastion_image_id
  pi_network_ids       = [ibm_pi_network.public_network.network_id, data.ibm_pi_network.network.id]
  pi_key_pair_name     = ibm_pi_key.key.key_id
  pi_sys_type          = var.system_type
  pi_cloud_instance_id = var.service_instance_id
  pi_health_status     = var.bastion_health_status
}

@yussufsh this looks okay? (using master branch ibmcloud-provider build)

@Prajyot-Parab I was using the latest provider version and found that storage_type is needed now for pi_instance. I am getting this error:
ibm_pi_instance.power_instance: Creating...

Error: failed to provision Failed to Create PVM Instance :[POST /pcloud/v1/cloud-instances/{cloud_instance_id}/pvm-instances][400] pcloudPvminstancesPostBadRequest  &{Code:0 Description:bad request: calculated parameter has failed for cloud-instance 461efd70609341159d5fd6770747074b: storageType is required when not using a storage affinity policy Error:bad request Message:}

  on main.tf line 22, in resource "ibm_pi_instance" "power_instance":
  22:     resource "ibm_pi_instance" "power_instance" {

So we still need to use storage type but in the pi_instance @ pi_storage_type and use the affinity for the pi_volume.

@Prajyot-Parab I was using the latest provider version and found that storage_type is needed now for pi_instance. I am getting this error:
ibm_pi_instance.power_instance: Creating...

Error: failed to provision Failed to Create PVM Instance :[POST /pcloud/v1/cloud-instances/{cloud_instance_id}/pvm-instances][400] pcloudPvminstancesPostBadRequest  &{Code:0 Description:bad request: calculated parameter has failed for cloud-instance 461efd70609341159d5fd6770747074b: storageType is required when not using a storage affinity policy Error:bad request Message:}

  on main.tf line 22, in resource "ibm_pi_instance" "power_instance":
  22:     resource "ibm_pi_instance" "power_instance" {

So we still need to use storage type but in the pi_instance @ pi_storage_type and use the affinity for the pi_volume.

@yussufsh we can use the volume_affinity along with volume_attach resource (We wont need pi_storage_type). However there is a issue while destroying the resources, same has been reported to community and I am expecting fix related to same in next release. Thread

You still wont be able to use the attach resource as it does not work with status as WARNING. That is the main reason we are not using it.
However pi_storage_type is needed by pi_instance, so we need to pass it anyway.

resource "ibm_pi_instance" "bastion" {
  pi_storage_type = "tier1"
  pi_volume_ids    = ibm_pi_volume.volume.*.volume_id
}
resource "ibm_pi_volume" "volume" {
  pi_affinity_policy   = "affinity"
  pi_affinity_instance = ibm_pi_instance.bastion.pi_instance_name
}

You still wont be able to use the volume_attach resource as it does not work with status as WARNING. That is the main reason we are not using it.
However pi_storage_type is needed by pi_instance, so we need to pass it anyway.

resource "ibm_pi_instance" "bastion" {
  pi_storage_type = "tier1"
  pi_volume_ids    = ibm_pi_volume.volume.*.volume_id
}
resource "ibm_pi_volume" "volume" {
  pi_affinity_policy   = "affinity"
  pi_affinity_instance = ibm_pi_instance.bastion.pi_instance_name
}

@yussufsh Above approach leads to cyclic dependency.
Also as per doc pi_storage_type - (Optional, String) - Storage type for server deployment. Only valid when you deploy one of the IBM supplied stock images. Storage type for a custom image (an imported image or an image that is created from a VM capture) defaults to the storage type the image was created in -- According to this it should default to storage type of custom image (RHEL)

So if we want to use the affinity policy we are required to use the storage attach resource? That will not give cyclic dependency but that will have issues with the vm status.
The error on pi_storage_type above is required for stock images as that is what is supported by the automation.

/assign @yussufsh

We will be using the storage pool of the image to create the volumes and instance with #337


chore(LICENSE): Update copyright year range

Looks good. Can't approve on mobile will approve shortly


made getSubscriptions into an iterator to reduce memory usage

closes: https://issues.redhat.com/browse/RHOAIENG-2040
Description

The backend uses an old method of watching certain get requests and subscriptions were a part of that logic. The watcher code will pull the data on creation of the watcher so no matter what we were fetching up to 250 items. This can causes memory issues as these subscriptions can get big.
In this solution, we remove subscriptions form the watcher and instead implement a iterator. Now we pull 100 items at a time, don't store them in memory when fetch the next batch. And always exiting early on finding what we need
How Has This Been Tested?

Make a log statement in fetch subs function and check that it is pulling everything. Reach out to @Gkrumbach07 as he set up a cluster with 300+ operators subscriptions to test this better.
Test Impact

backend code n/a
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/hold

tested on a cluster and prevents error from occurring. I am not sure if we need to make the number of requests lower. Right now it queries 100 at a time


Glossary

Glossary start

I'm holding off on merging this, as we're planning to rename things and so it likely won't be necessary, or will then need to be updated.

#434 (#449) is done so we can merge this too. Thanks!


Conditionally using IN for SQL queries

Hi - we are running into a potential issue where we pass an empty slice and it crashes..
e.g.
models.foo.IN(someCriteria) results in an Err condition.
Should IN filter for nil or an empty slice?
As a workaround, i am just conditionally not adding an IN for the query predicate.
I think the source code surrounding this is:
func (w WhereMod[Q, C]) In(slice ...C) mods.Where[Q] {
	values := make([]any, 0, len(slice))
	for _, value := range slice {
		values = append(values, value)
	}
	return mods.Where[Q]{E: w.name.In(Arg(values...))}
}

If you add an "IN" mod, Bob will try to build it, so I can imagine it may create an invalid query if there are no values in the slice.
Your current method of not adding the IN predicate is the way to go. Alternatively, you can create a custom bob.Mod to make this easier.


Suggestion: Put what version something was added in docs

First of all, love this ORM.  Works awesome.  Thanks for much for your work on it.
Team here just spent an hour trying to figure out why tests were passing sometimes and others.  Traced it back to differences in 0.8.2 and 0.8.1 of bookshelf.  The count method works differently.
In 0.8.2 you can do this(developer read it in docs), but everyone else was running 0.8.1.
let assortmentItemCount = yield AssortmentItem
          .where({
            store_id: 1
          })
          .count()

Would have been nice to know that this new style was introduced in 0.8.2.  If there is anything we can do to help let me know.

You'd like a minimum version for each feature? I think this will be possible with the new JSDoc generated website I'm launching this evening. Using the @since tag. Model#refresh and Model#count were both added in 0.8.2, so I guess they could be added there.
FYI there is a change log. If you're worried about different instances of your project using different versions you should be using npm install bookshelf --save-exact. IMO this should be the default behaviour of npm.

Thanks man this looks great!


[Program Card Images] [Admin] Provide way for admin to delete program image

Admins should be able to remove the image currently associated with a program.
Sub-task of epic #5676

Anddd actually we're back to using a DurableJob to delete images occasionally. I realized that we can't immediately remove the old image when a new one is uploaded because the old image is still the image in the Active version of the program that applicants can see. Instead we'll just periodically delete old images using a DurableJob and we don't need this PR anymore.