cilium: add skb_pull_data to bpf_network to avoid revalidate error

Depending on the driver when we have a full stack of headers with
tunneled IPsec its possible the headers are not part of the linear
data. In this case we should pull in the data instead of immediately
aborting. If the pull fails we can then abort.
For this patch we only fix the immediate problem call site. We need
to audit the remaining ones. However, veth devices should not have
this issue in general so bpf_lxc.c should be OK. skbs on bpf_netdev
either passed through bpf_network.c, bpf_lxc.c or were routed from
the host networking.
Fixes: 47bd875512770 ("cilium: encrypt, use ipcache to lookup IPsec destination IP")
Signed-off-by: John Fastabend<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.03%) to 41.835% when pulling edf4a860672d124ebfe2b08398210f6bd2bb0c9a on pull_data into 27ec6d64dfd7f03e2ca90d214c7f899ffe50c7c0 on master.

test-me-please


New request in completion handler

I'm probably doing something wrong.  If I try to make a request from inside a completion handler of another request, it doesn't work correctly.
Swift pseudo code:
Alamofire.request(...).responseJSON { response in
Alamofire.request(...).responseJSON { response in
}
}
If I move the inner request out of the closure, it works correctly.  I'm totally stumped.

This is certainly my issue.  You can close this.

@woofyman99 - Are you saying that you are unable to make a request from within the completion handler of another request?


Drone agent without volume

I don't have permission to make host bind mounts so I need another way to connect to the docker daemon from within the drone-agent container as mounting /var/run/docker.sock is not possible:
failed to update service drone-ci_drone-agent: Error response from daemon: access denied:
no access to Service Create with [Host Bind Mounts], Service Update, on collection xxxxxxxx-xxx-xxx-xxx-xxxxxxxxxxxx

I have tried to add environment variables DOCKER_TLS_VERIFY, DOCKER_CERT_PATH and most importantly DOCKER_HOST but it doesn't seem like this is supported.
Is it possible to avoid using /var/run/docker.sock and use the DOCKER_HOST directly? I've searched half the day and couldn't find a satisfying answer.
If this is a feature you want to add I might be able to provide a PR with some pointers.

👋 hi there, this can likely be solved without a code change, but for end-user-support questions we kindly ask that you create a thread in our discourse forum. https://discourse.drone.io/. Thanks!


Docs: fix some ARIA Authoring Practices Guides broken links

This PR fixes some ARIA Authoring Practices Guides broken links found in the documentation and tries to improve consistency in the text of those links.
I don't have access to the previous content so I'm not 100% sure that the modification is well https://www.w3.org/TR/wai-aria-practices/#something → https://www.w3.org/WAI/ARIA/apg/patterns/something/.
Feel free to comment or directly modify the links.
Note: if merged would need to be backported to v4
Live previews

Breadcrumb - Accessibility
Collapse - Accessibility
Modal - Usage - Via data attributes - Dismiss
Nav & Tabs - Regarding accessibility
Nav & Tabs - JavaScript behavior - Accessibility
Offcanvas - Usage - Via data attributes - Dismiss

Ah, good point ...

In site/content/docs/5.2/components/navs-tabs.mdhttps://github.com/twbs/bootstrap/pull/36488#discussion_r888374620:

@@ -540,7 +540,7 @@ And with vertical pills. Ideally, for vertical tabs, you should also add `aria-o

Dynamic tabbed interfaces, as described in the WAI ARIA Authoring Practices 1.2, require role="tablist", role="tab", role="tabpanel", and additional aria- attributes in order to convey their structure, functionality, and current state to users of assistive technologies (such as screen readers). As a best practice, we recommend using <button> elements for the tabs, as these are controls that trigger a dynamic change, rather than links that navigate to a new page or location.
-In line with the ARIA Authoring Practices pattern, only the currently active tab receives keyboard focus. When the JavaScript plugin is initialized, it will set tabindex="-1" on all inactive tab controls. Once the currently active tab has focus, the cursor keys activate the previous/next tab, with the plugin changing the roving tabindex accordingly. However, note that the JavaScript plugin does not distinguish between horizontal and vertical tab lists when it comes to cursor key interactions: regardless of the tab list's orientation, both the up and left cursor go to the previous tab, and down and right cursor go to the next tab.
I haven't found a new link replacing https://www.w3.org/TR/wai-aria-practices-1.2/#kbd_roving_tabindex
—
Reply to this email directly, view it on GitHubhttps://github.com/twbs/bootstrap/pull/36488#pullrequestreview-994138204, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHHHSKA56K3XKSPJSMT642LVNEI6LANCNFSM5XWCZPMQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Beasts vs. Beast

At some point, we will need to go through ALL the code and change all the 'beast' to 'beasts' as the token is technically plural. Since we use the object's class as its text so frequently, an update would be very helpful.

I've resolved this.


Flutter run stuck at "Waiting for observatory port to be available..."

$flutter run --verbose
....
[ +284 ms] executing: /usr/bin/xcrun simctl install 52F1DD4F-3459-4FDD-ABBA-15CD4E7B2F38 /Users/mohammadkhaled/Documents/Developer/flutterProjects/PriceG/build/ios/iphonesimulator/Runner.app [+1125 ms] executing: /usr/bin/plutil -convert json -o - /Users/mohammadkhaled/Documents/Developer/flutterProjects/PriceG/build/ios/iphonesimulator/Runner.app /Info.plist [  +20 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Users/mohammadkhaled/Documents/Developer/flutterProjects/PriceG/build/ios/iphonesimulator/Runner.app /Info.plist [   +1 ms] {"CFBundleName":"PriceG","DTXcode":"1210","DTSDKName":"iphonesimulator14.1","UILaunchStoryboardName": "LaunchScreen","CFBundleIcons~ipad":{"CFBundlePrimaryIcon":{"CFBundleIconFiles":["AppIcon60x60","AppI con76x76"],"CFBundleIconName":"AppIcon"}},"DTSDKBuild":"18A8394","CFBundleDevelopmentRegion":"en","CF BundleVersion":"1","BuildMachineOSBuild":"19H2","DTPlatformName":"iphonesimulator","CFBundlePackageTy pe":"APPL","UIMainStoryboardFile":"Main","CFBundleSupportedPlatforms":["iPhoneSimulator"],"CFBundleSh ortVersionString":"1.0.0","CFBundleInfoDictionaryVersion":"6.0","CFBundleExecutable":"Runner","DTComp iler":"com.apple.compilers.llvm.clang.1_0","UISupportedInterfaceOrientations~ipad":["UIInterfaceOrien tationPortrait","UIInterfaceOrientationPortraitUpsideDown","UIInterfaceOrientationLandscapeLeft","UII nterfaceOrientationLandscapeRight"],"MinimumOSVersion":"12.0","CFBundleIdentifier":"com.example.Price G","UIDeviceFamily":[1,2],"DTPlatformVersion":"14.1","CFBundleSignature":"????","CFBundleIcons":{"CFB undlePrimaryIcon":{"CFBundleIconFiles":["AppIcon60x60"],"CFBundleIconName":"AppIcon"}},"DTXcodeBuild" :"12A7403","LSRequiresIPhoneOS":true,"UISupportedInterfaceOrientations":["UIInterfaceOrientationPortr ait","UIInterfaceOrientationLandscapeLeft","UIInterfaceOrientationLandscapeRight"],"UIViewControllerB asedStatusBarAppearance":false,"NSBonjourServices":["_dartobservatory._tcp"],"DTPlatformBuild":"18A83 94","NSLocalNetworkUsageDescription":"Allow Flutter tools on your computer to connect and debug your application. This prompt will not appear on release builds."} [  +25 ms] executing: /usr/bin/xcrun simctl launch 52F1DD4F-3459-4FDD-ABBA-15CD4E7B2F38 com.example.PriceG --enable-dart-profiling --enable-checked-mode --verify-entry-points [ +413 ms] com.example.PriceG: 74541 [        ] Waiting for observatory port to be available...

Do you run on iOS or android simulator?

@MoeEarthDimensionC137
There's similar open issue describing your case, 33214.
Also try this possible solution and see if it works for you.
Closing this as duplicate.


implementation of ctx.prototype.arcTo

Implementation of ctx.prototype.arcTo.
See also:

http://zenozeng.github.io/svgcanvas/test/

http://www.w3.org/TR/2015/WD-2dcontext-20150514/#dom-context-2d-arcto

@gwwar Kerry. If the code looks good to you, I'll go ahead and merge.  Thanks!

:+1:  I tested this out on a branch off of my fork, it looks good.
https://travis-ci.org/gwwar/canvas2svg/builds/66960567
Let me know if I should rebase my fork to make my pr easier to merge. It should make testing a lot easier.


Could not find class 'topo.misc.legacy.JointScaling' to restore its parameter values ?

Dear Bednar,
I  run simulations based on snapshot obtained before, for example,  I want to  run 2000 iterations based on GCAL_10000.typ. So what I do is, firstly I use load_snapshot to load " GCAL_10000.typ", then I run
topo.sim()
times = [2000*i for i in range(2)]
data=c(times=times)
from this step I can get the snapshot GCAL_12000.typ which is the snapshot of the 10000th and 12000th iteration. But the problem occurs when I load GCAL_12000.typ and want to continue run simulations based on it. I get a warning ( maybe can be regarded as an error)
"WARNING:root:Time: 000000.00 Parameterized01246: Could not find class 'topo.misc.legacy.JointScaling' to restore its parameter values (class might
have been removed or renamed; if you are using this class, please file a support
request via topographica.org)."
As I understand, I get nothing by running simulations based on the second snapshot GCAL_12000.typ because GCAL_12000.typ is the data from 10000 to 12000 iteration,lacking previous activities' data.
I would like to ask, how to fix this problem ? Since it is important for me that I need to store snapshots by steps in case of simulations interrupted by accidents .

Here it looks like you're using a class that's no longer supported.  Maybe you need to add the -l option when you are launching Topographica, before reloading your snapshot?  I haven't used that option in many years, and don't remember how it works...

Where is the location to add the -l option when launching Topographica ? I haven't found that.
If I can run simulations based on GCAL_12000.typ and obtain the data for the next snapshots,
that is all right.

Now it is solved. Thanks.


HMAN-182 - increase hearing.error_description column length to 400

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/HMAN-182
Change description
Increase hearing.error_description field length
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Ticket says field length should be 4000 not 400

Yep! Saw it just after i asked for the review, all should be good now :)


AmazonEsRepository.java:45-47: We might have to implement mappings and ...

The puzzle 150-f4a028a1 in src/main/java/com/amihaiemil/charles/aws/AmazonEsRepository.java (lines 45-47) has to be resolved: We might have to implement mappings and indexing of suggestions. Waiting for a clarification here: https://discuss.elastic.co/t/simple-way-to-implement-autocomplete-functionality/68979
The puzzle was created by amihaiemil on 14-Dec-16.
Estimate: 30 minutes, role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

The puzzle 150-f4a028a1 has disappeared from the source code, that's why I closed this issue.


[Workflow] Integration of Workflow Engine

Current Behavior
Meshery has a built-in patterns engine, capable of building DAGs.
Desired Behavior
Meshery will benefit from integration of a robust and dedicated workflow engine.
This issue is an epic.

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

@leecalcote I would like apply for this project under the LFX . I have read the previous comments and the requirements you mentioned. Looking forward to it.

hey @leecalcote, My name is Wisdom Ekpotu, I am a Third Year Computer Engineering Student from the University of Uyo, Nigeria. I saw this project in the LFX mentorship fall 2021 and I thought this project had some parallels with my skills. I would love to contribute to this project and I'm open to learning any new technologies required for the project.
Also, I just joined the official Slack channel to get more information about the project. I am really looking forward to contributing to this project!

Also @leecalcote, i just noticed that the link to the Wireframes and designs for Meshery UI in Figma is not found

OR i guess i dont have permissions

@wisdomekpotu if you're new to the community, then join us on Slack (slack.layer5.io) signal us and we'd provide access to the files

@alphaX86 19 years old you‘re cool.  I'm 21 years old,It's nice to meet.

@alphaX86 okay got it

Hi @leecalcote
I'm interested to work on this Feature/Issue
Please consider me for this!

@leecalcote I would also like to work on this enhancement, if possible

Yes: Build Meshery Server, UI, Operator, MeshSync, a couple of Adapters, review the Meshery Architecture slide deck (fill in your community member form), review the Messaging Framework and Operations Center design spec, then write down your thoughts about what it would mean to have a retry, rollback, ignore, continue action on failed workflows.

When can I start on this?

@leecalcote Please assign this Issue to me 😊✨


it just changes the file name? I can also open these files and read what they say in the file explorer (txt, json, etc).

it just changes the file name? I can also open these files and read what they say in the file explorer (txt, json, etc.)
can you shuffle the text files as specified in the header?

Sorry for the delayed response.
Yes. Amarok just changes the filename.
If you need to encrypt the whole file, please use encryption software.

The feature is added in v0.8.1b1.
Let me close this issue now. Feel free to reopen this issue if it does not work.
Thanks again!

Er... It does not work with text and zip files.
Because It just changes the first several bytes of a file - the file signature - to make most of the file (video, music, image, apk etc.) corrupted.
But a plain text file does not have a file signature. Shuffling the whole file is too costly.

:thinking: Adding this feature is technically not a problem — But that will lose the purpose of this app.
If you can endure the slow speed, why not use an encryption tool?
It can surely be safer.

Ahh. I know what you mean.
Just make the text files fully shuffled.
Sure, I'll add this feature soon.

Hi Wjxfi,
I've been implementing this feature recently, by setting up a file extension filter to select which file to be obfuscated.
I'd like to know if the process only obfuscates the "conventionally speaking text" files - .txt, .md, etc., is that enough for you?
Or you need it to fully obfuscate all "not-binary" files, like .xml .cfg .py .json etc.？

as I said before, it won't slow down the application because of the small file sizes.

Not really. Some users use Amarok to hide game files. That includes logs or generated configs, which can be very large.

all non-binary.

Another problem: I can't find a very accurate method way to distinguish whether a file is "binary" or not.
MIME is a way, however it does not consistently produce reliable results. Not to mention using the file extensions.
Anyway, though it may not work properly, try this: Amarok-v0.8.1b3-foss-cabb47e.apk
Enable the switch Fully Obfuscate Text File - Enhanced in More Settings > Switch FileHider Workmode. The switch is visible only when you enable on Obfuscate File Header and Fully Obfuscate Text File.

when selecting this mode there will be a choice. All non-binary or this:

yep indeed that's what I've done :laughing:

Fully Obfuscate Text File - Enhanced tries to obfuscate all non-binary
While Fully Obfuscate Text File just obfuscate .txt and .md

And I also skip files larger than 10MB

I checked it out, it's just as fast and beautiful!

Good to hear! XD

we need to add more text formats

Could you provide a list MIME Types which are non-binary? Currently, I set it to obfuscate text/*.
There may be some types that are left out: e.g. application/x-python-code for .py files.
I have to add these manually.

limit it to 30 MB

Tweaked!

Oops I think you misunderstood.
For .epub, .docx etc., obfuscating their headers is just enough. So they are "binary" ones.
And for .html .text .tex etc., their MIME Types are already started with text/*.
And I'm not using file extensions to check its type ... So MIME Type please if you find exceptions.

Let's mark the issue as resolved!


Update PyInstaller, add dev version info to builds.

If this works, we'll have mitmproxy on an actual PyInstaller release without too many further hacks! 🙌

There's still a small bug with the Windows builds I'll fix tomorrow, but the Linux release works fine 😅 . Can someone on OSX verify that https://snapshots.mitmproxy.org/v3.0.0/mitmproxy-3.0.0.dev1089-0xffaab2b-osx.tar.gz works?

The link you provided is 404 now - so I used https://snapshots.mitmproxy.org/v3.0.0/mitmproxy-3.0.0dev1088-0x0b80fd0-osx.tar.gz.
All three tools start without errors.
{mitmproxy,mitmdump,mitmweb} --version shows:
Mitmproxy: 3.0.0 binary
Python:    3.5.3
OpenSSL:   OpenSSL 1.1.0f  25 May 2017
Platform:  Darwin-17.3.0-x86_64-i386-64bit

When did we stop shipping pathod binaries?

Also tested with the original link. Same positive result.
Although I sometimes see strange behaviour when Ctrl+C to quit:
(not sure if related to this PR or in general - but I can't remember seeing this before)
./mitmdump
Proxy server listening at http://[::]:8080
^C^CException ignored in: <module 'threading' from '/var/folders/th/v6q_2vkn41q60nghxrhjgncr0000gn/T/_MEIJgTgaI/threading.pyc'>
Traceback (most recent call last):
  File "threading.py", line 1288, in _shutdown
  File "threading.py", line 1054, in join
  File "threading.py", line 1070, in _wait_for_tstate_lock
KeyboardInterrupt


Set.new does not infer types from passed arguments

Input
→ View on sorbet.run
# typed: true

arr = [1,2,3]
T.reveal_type arr

T.reveal_type(Set.new(arr))
T.assert_type!(Set.new(arr), T::Set[String]) # this should fail

Observed output

# typed: true

arr = [1,2,3]
T.reveal_type arr

T.reveal_type(Set.new(arr))
T.assert_type!(Set.new(arr), T::Set[String]) # this should fail

editor.rb:4: Revealed type: [Integer(1), Integer(2), Integer(3)] (3-tuple) https://srb.help/7014
     4 |T.reveal_type arr
        ^^^^^^^^^^^^^^^^^
  Got [Integer(1), Integer(2), Integer(3)] (3-tuple) originating from:
    editor.rb:3:
     3 |arr = [1,2,3]
              ^^^^^^^

editor.rb:6: Revealed type: T::Set[T.untyped] https://srb.help/7014
     6 |T.reveal_type(Set.new(arr))
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Got T::Set[T.untyped] originating from:
    editor.rb:6:
     6 |T.reveal_type(Set.new(arr))
                      ^^^^^^^^^^^^
Errors: 2

Expected behavior
I'd expect sorbet to know that Set.new(arr) returns a T::Set[Integer], since the type of arr was T::Array[Integer].

There is a good test case in this issue I just closed as a dupe, which we will want to include in any PR that fixes this in the future:
https://github.com/sorbet/sorbet/issues/1804

Note that for the specific case of Set, you can use Set[...] instead of Set.new(...) to get a better inferred type
→ View on sorbet.run
# typed: true

# Might be able to guide people towards `Set.[]`
# instead of `Set.new` for better typing

xs = Set.new([1, 2, 3])
T.reveal_type(xs)

ys = Set[1, 2, 3]
T.reveal_type(ys)

editor.rb:7: Revealed type: T::Set[T.untyped] https://srb.help/7014
     7 |T.reveal_type(xs)
        ^^^^^^^^^^^^^^^^^
  Got T::Set[T.untyped] originating from:
    editor.rb:6:
     6 |xs = Set.new([1, 2, 3])
             ^^^^^^^^^^^^^^^^^^

editor.rb:10: Revealed type: T::Set[Integer] https://srb.help/7014
    10 |T.reveal_type(ys)
        ^^^^^^^^^^^^^^^^^
  Got T::Set[Integer] originating from:
    editor.rb:9:
     9 |ys = Set[1, 2, 3]
             ^^^^^^^^^^^^
Errors: 2

I've been keeping this issue open to fix the underlying issues, which is that Sorbet should either require a type application (T::Set[Integer].new(...)) or else be able to infer the type for all generic constructors, which would require reworking Sorbet.


Any solution for MultiGPU

I'm new to the land of LLM fine-tuning and after trying LLaMA-Factory and Axolotl I've started adopting Unsloth for better performance on memory limited cards like RTX A6000 with 48Gb.
But now I reach the point where there it's too limiting for me to use just one GPU and I should find the way to use Unsloth with multiple GPUs or move somewhere.
Please give some information is it possible to use Unsloth with Accelerate or DeepSpeed in multiGPU configuration?
I'm waiting for native multiGPU support release, just want to start using any other solution right now.

@gotzmann Thanks for using Unsloth again!! :) Sadly multi GPU is not yet supported for now - we're working on it for a future release in the OSS version

@danielhanchen
Do you think it's possible with LLaMA-Factory? Seems like there some hope there:
https://github.com/hiyouga/LLaMA-Factory/wiki/Performance-Comparison#nvidia-a100--2

@gotzmann We're actively working with the Llama Factory team - for now it's in experimental mode - there will be intermittent seg faults randomnly for now and I haven't confirmed myself if the training losses match exactly, ie if the results are even accurate / correct - so wait patiently for news coming very soon :))

Is multi-gpu  available or not?

@MUZAMMILPERVAIZ It's under active development. So currently no.

@danielhanchen Any news yet?

Do you have any projected timelines for this?

No sorry currently not - so many new model releases and bugs - sorry I can't keep up and so I have to prioritize since sadly Unsloth's team is just 2 people (me and my bro), and I primarily focus on algos - so please be patient! Apologies again!

@danielhanchen  -- As unsloth's one of the primary strengths lie in fine tuning and multi-gpu is one of the most important feature, I think we should prioritize this.
I can contribute/assist to the multi-gpu backlogs, thanks.

Hey @danielhanchen
i'm using multigpu from past 6 months in llama-factory using unsloth. I think for finetuning stuff people can directly use that.

Hey @danielhanchen i'm using multigpu from past 6 months in llama-factory using unsloth. I think for finetuning stuff people can directly use that.

ohh sorry for this, but it's sad to know that in the latest release u guys have removed the multi-gpu training.


Custom .grit path

By default .grit the cli is looking up the .grit in your current folder or in the root of your repo. I think this is a sane default. However I also think it would be nice to define a custom path for your .grit. Perhaps you want your .grit committed in a repo of it's own, or perhaps you would always like to look up patterns from ~/.grit.

Hi @jonathan-s, config in ~/.grit/ will also be picked up automatically: https://docs.grit.io/guides/config#user-configuration

Nice! Might be helpful to have that piece of information part of grit cli as well, as part of the output of of grit help.


Change "arm" to "armv6l" during tar.gz prep

distpack produces files like go1.21.0.linux-arm.tar.gz, but upstream published it as go1.21.0.linux-armv6l.tar.gz. This matches the historical name. I believe this line is responsible for upstream's rename: https://github.com/golang/build/blob/a929908712e90b6259357273fafcfc08f7215193/internal/relui/workflows.go#L1455
Unfortunately for us, since upstream seems to rename the file in x/build rather than distpack, we have to reimplement the name swap in our own code.
I noticed this because some SDL issue suppressions were no longer applying due to the filename change, but it actually would have broken the aka.ms links at https://github.com/microsoft/go/blob/microsoft/main/eng/doc/Downloads.md. Luckily we aren't using distpack yet in 1.21, so the 1.21.0 release's aka.ms links are fine and we have time to fix this up for 1.22.

aka.ms links

After mulling this over, also realized that the microsoft/go-infra aka.ms infra is not set up to handle the new filenames due to the version number now being included, similar to what I fixed in https://github.com/microsoft/go/pull/1017/files. Working on that too. (It's independent of this PR.)


Add UpgradeRolloutStrategy to all providers

Issue #, if available:
6719
Description of changes:
Adding UpgradeRolloutStrategy knobs for workers and control plane to all providers.
Testing (if applicable):
Updated unit tests.
Documentation added/planned (if applicable):
Planning on adding docs on knobs for other providers following the Tinkerbell upgrade strategy format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing and reopening as separate PRs per provider for readability


Bump golangci-lint

Bump the golangci-lint version to the newest that still supports 1.20 and removed disabled checks that passing now.

/test openstack-operator-build-deploy-kuttl
Removing debug pod ...
error: unable to upgrade connection: container container-00 not found in pod oko-12-qnsz6-master-1-debug-4rbzh_openstack-kuttl-tests
make[3]: *** [Makefile:526: crc_storage_cleanup] Error 1

/test openstack-operator-build-deploy-kuttl
Depoloy was incomplete


Updated code snippet

Category

[x] Content fix

Related issues

fixes #6689

What's in this Pull Request?
Updated code snippet to Verify the origin with CLI for M365

Docs Build status updates of commit bcd68c2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/enable-Microsoft-365-content-delivery-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


initial support for geopackage metatata

issue #713
@sgillies here is the first iteration.

I've finally made some time to get to this! Here's a test that was failing before the require_gdal_version decorator was added.
_________________________ test_set_tag_item[test-test] _________________________
layer = 'test', namespace = 'test'
tmpdir = local('/tmp/pytest-of-travis/pytest-0/test_set_tag_item_test_test_0')
    @pytest.mark.parametrize("layer, namespace", [
        (None, None),
        (None, "test"),
        ("test", None),
        ("test", "test"),
    ])
    def test_set_tag_item(layer, namespace, tmpdir):
        test_geopackage = str(tmpdir.join("test.gpkg"))
        schema = {'properties': {'CDATA1': 'str:254'}, 'geometry': 'Polygon'}
        with fiona.open(test_geopackage, "w", driver="GPKG", schema=schema, layer=layer) as gpkg:
            assert gpkg.get_tag_item("test_tag1", ns=namespace) is None
            gpkg.set_tag_item("test_tag1", "test_value1", ns=namespace)

        with fiona.open(test_geopackage, layer=layer) as gpkg:
            if namespace is not None:
                assert gpkg.get_tag_item("test_tag1") is None
>           assert gpkg.get_tag_item("test_tag1", ns=namespace) == "test_value1"
E           AssertionError: assert None == 'test_value1'
E            +  where None = <bound method Collection.get_tag_item of <open Collection '/tmp/pytest-of-travis/pytest-0/test_set_tag_item_test_test_0/test.gpkg:test', mode 'r' at 0x7fabc2bb87b8>>('test_tag1', ns='test')
E            +    where <bound method Collection.get_tag_item of <open Collection '/tmp/pytest-of-travis/pytest-0/test_set_tag_item_test_test_0/test.gpkg:test', mode 'r' at 0x7fabc2bb87b8>> = <open Collection '/tmp/pytest-of-travis/pytest-0/test_set_tag_item_test_test_0/test.gpkg:test', mode 'r' at 0x7fabc2bb87b8>.get_tag_item
tests/test_session.py:54: AssertionError
----------------------------- Captured stderr call -----------------------------
ERROR 1: sqlite3_prepare_v2(SELECT Count(*) FROM test WHERE test_tag1) failed: no such column: test_tag1
ERROR 1: failed to prepare SQL: SELECT fid, "geom", "CDATA1" FROM test WHERE test_tag1

The method returns None. If we had an Env block around the calls, we would get an exception from ogrext.pyx. Instead, the errors are printed to stderr.
I think it would be fine to remove the decorator and let this method raise an exception with GDAL 1.11. We'll document the situation and will be leaving 1.x behind sooner or later. It shouldn't block us from moving ahead.
@snorfalorpagus @snowman2 Yes? No?

Sounds like a good plan to me.

@sgillies I removed the commits with the decorators.

Should I add the env block in the tests?

@snowman2 yes, please. And, if you like: catch the exception coming from fiona.ogrext with GDAL 1.11 and xfail the test inside the except clause using pytest.xfail.

xfail coming after I the next tests fail so I have the specific exception it raises.

@sgillies, it does not seem to raise an exception. How would you like to proceed?

@snowman2 I'm surprised at the lack of an exception, but for now, let's test the dict and xfail if it is empty and if the GDAL version is less than 2.0.

Congratulations @snowman2 ! I'm going to give this a little more review on the weekend, focusing on what to return or raise when the collection isn't open (no session or whatever). Generally, this is great stuff.

Just squashed it. :+1:

Is there still interest in this PR? I can take a stab at continuing it.

@joehuanguf yes, this is just held up by a refactor and my involvement in GDAL 3 fallout. We're still going to do this.

Finally getting back to this. It's still relevant and good and I think it should be able to merge fairly cleanly with maint-1.9.

Didn't see dropdown to change branches. Moved to #821


Files are downloading with trimmed File Names.

Files are downloading with trimmed File Names.
But, ".m3u" contains the FileList with Full Names.

What course are you downloading?

What course are you downloading?

It applies to Any Pluralsight Course which contains lengthy File Names.

Files are downloading with trimmed File Names.
But, ".m3u" contains the FileList with Full Names.

Facing the same problem, I figured out the possible reason for this behavior.
This is most likely due to the limitation of the maximum path length in Windows, which is defined as 260 characters.
This problem can be solved in several ways:

Download files to the root of the disk.
Enable Long Paths in Windows 10, Version 1607, and Later.
Use symbolic links.
Use the 'subst' command to mount the folder as a disk.
There are probably other ways to do that.

Files are downloading with trimmed File Names.
But, ".m3u" contains the FileList with Full Names.

Facing the same problem, I figured out the possible reason for this behavior.
This is most likely due to the limitation of the maximum path length in Windows, which is defined as 260 characters.
This problem can be solved in several ways:

Download files to the root of the disk.
Enable Long Paths in Windows 10, Version 1607, and Later.
Use symbolic links.
Use the 'subst' command to mount the folder as a disk.
There are probably other ways to do that.

I tried using registry edit in windows 10 v21H1... But still failing to get the file name.

@IssacEinstein
This looks like a OS limitation, Closing the issue since this is not a bug in the extension.
Do let us know if there are some updates on this issue, since this might help other people too


Sane testing breaks nose with django

I have a project that uses nose to test a django app (without sane-testing). If I have sane testing installed, I get:
======================================================================
ERROR: test suite for <module 'test_project' from '/home/king/work/WHISKEY/rubix/test_project/init.py'>
Traceback (most recent call last):
File "/home/king/work/VENVS/whiskey/lib/python2.7/site-packages/nose/suite.py", line 208, in run
self.setUp()
File "/home/king/work/VENVS/whiskey/lib/python2.7/site-packages/nose/suite.py", line 291, in setUp
self.setupContext(ancestor)
File "/home/king/work/VENVS/whiskey/lib/python2.7/site-packages/nose/suite.py", line 314, in setupContext
try_run(context, names)
File "/home/king/work/VENVS/whiskey/lib/python2.7/site-packages/nose/util.py", line 491, in try_run
return func()
File "/home/king/work/WHISKEY/rubix/test_project/init.py", line 21, in setup
from django.test.simple import DjangoTestSuiteRunner
File "/home/king/work/DJANGO/django/django/test/init.py", line 5, in
from django.test.client import Client
File "/home/king/work/DJANGO/django/django/test/client.py", line 19, in
from django.test import signals
ImportError: cannot import name signals

Ran 0 tests in 0.010s
FAILED (errors=1)
once I pip uninstall djangosanetesting, everything works again

I get almost the same behavior. I'm testing a Django app with nose by running nosetests directly since I'm mocking out Django internals. The test suite runs correctly, but I get run-time warnings from nose plugins:
(myapp)$ bin/nosetests
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin cherrypyliveserver = djangosanetesting.noseplugins:CherryPyLiveServerPlugin: Could not import settings 'settings' (Is it on sys.path?): No module named settings
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin sanetestselection = djangosanetesting.noseplugins:SaneTestSelectionPlugin: cannot import name signals
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin djangoliveserver = djangosanetesting.noseplugins:DjangoLiveServerPlugin: cannot import name signals
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin djangotranslations = djangosanetesting.noseplugins:DjangoTranslationPlugin: cannot import name signals
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin selenium = djangosanetesting.noseplugins:SeleniumPlugin: cannot import name signals
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin djangoresultplugin = djangosanetesting.noseplugins:ResultPlugin: cannot import name signals
  RuntimeWarning)
myapplib/python2.7/site-packages/nose/plugins/manager.py:383: RuntimeWarning: Unable to load plugin django = djangosanetesting.noseplugins:DjangoPlugin: cannot import name signals
  RuntimeWarning)
...........
----------------------------------------------------------------------
Ran 11 tests in 0.178s

OK

pip uninstall djangonosetesting gets rid of these warnings.

I also verified that I get the same behavior on djangosanetesting-0.5.11 and the version as of November 19, 2011 commit 77ca5fb3f95825da306f2759f4b9c790f6f2e181.

Thanks for the patch!
Merged.


Better error type via quick-error (fixes #50)

Basically this adds implementation of std::error::Error and std::fmt::Display.
Also added From implementation for IoError.

Apart from being severely outdated, are there other problems in the PR? As I understand, it could fix #50 .

I'm undecided on the benefit of using an external library just to save a few lines of code.

Would implementing Error ourselves w/o use of quick-error be better?

Well, that's the problem, I don't know if it's better. I guess I'd more easily merge a PR that implements Error manually.


gettext gem

Add gettext gem which lets us run
rake gettext:find

This is going to be essential to keep code in sync with translation (portal) efforts.

This command permits finding any translation conforming to _('any message').
It automatically marks with #, fuzzy any string that is suspicious of being translated correctly. In addition, automatically removes entries from .pot and .po files that no longer appear in code.

Works OK. No UI components so no UAT, closing.


Tensor size mismatch due to scaling

Train data shape: torch.Size([20000, 2])
Train target shape: torch.Size([20000, 648])
Test data shape: torch.Size([100, 2])
Test target shape: torch.Size([100, 648])
I am trying to solve a regression problem, specifically map (, 2) input to (,648) output, and ultimately compare the performance with MLP.
Let's say, my KAN size for this specific problem is:
model = KAN(width=[2,20,20,648], grid=10, k=3, seed=0, device=device)
However, I face a problem with tensor size:
"RuntimeError: The size of tensor a (20) must match the size of tensor b (40) at non-singleton dimension 1"
I guess the issue is related to the scaling while passing the tensor between KANLayers. Did anyone face such an issue?

This is not expected behavior. Did you use model.train() (now called model.fit()) or did you write your own training loop?

I also got same error , "The size of tensor a (3) must match the size of tensor b (12348) at non-singleton dimension 1". I try to do multiclass prediction , before your updates it runs well but now this error raises.

ok, so if it's classification, the target should be a 1D torch.long tensor which contains the correct labels, e.g., [0, 3, 2, 1, ...]


Fix get_formatting_definition() failing if locale is not found

Fallback to DEFAULT in get_formatting_definition() if not in formatting_definitions

Fixes #70

Fixes #70

Closed and re-opened to trigger Travis (which was set up after this PR was created).

Closed and re-opened to trigger Travis (which was set up after this PR was created).


[Bug]: Issues with provisioning EKS addons: aws-ebs-csi-driver and coredns

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version
v4.0.3
What is your environment, configuration and the example used?
Terraform 1.1.8
Plan: https://gist.github.com/tsunamaru/c2e1bb74bab0846e52cd2382a25b64df
What did you do and What did you see instead?
I tried create new cluster (see plan provided) but ended up with infinity aws-ebs-csi-driver and coredns creation:

Upon investigation I noticed that those 2 add-ons in degraded status:

At first, I thought that the issue is old deployed version of those add-ons, so I clicked edit, selected latest version available, selected overwrite checkbox. Both add-ons become normal after upgrade.
Shortly after this, I tried to create another cluster, but this time I specified newer versions explicitly:
  # EKS Managed Add-ons
  enable_amazon_eks_vpc_cni = true
  amazon_eks_vpc_cni_config = {
    addon_version     = "v1.11.0-eksbuild.1"
    resolve_conflicts = "OVERWRITE"
  }
  enable_amazon_eks_coredns = true
  amazon_eks_coredns_config = {
    addon_version     = "v1.8.4-eksbuild.1"
    resolve_conflicts = "OVERWRITE"
  }
  enable_amazon_eks_kube_proxy = true
  amazon_eks_kube_proxy_config = {
    addon_version     = "v1.21.2-eksbuild.2"
    resolve_conflicts = "OVERWRITE"
  }
  enable_amazon_eks_aws_ebs_csi_driver = true
  amazon_eks_aws_ebs_csi_driver_config = {
    addon_version     = "v1.5.3-eksbuild.1"
    resolve_conflicts = "OVERWRITE"
  }

But it didn't helped, I ended up again with degraded status for aws-ebs-csi-driver and coredns. I clicked on edit again, selected "overwrite" checkbox and saved changes. Shortly after this both add-ons become normal and Terraform finished execution without errors.
Additional Information
I don't think you need any, but feel free to ask anything that can help.

Just discovered that I forgot add depends_on = [module.eks-cluster-flc.managed_node_groups] to add-ons module.
I'll re-deploy it later and close this ticket if it resolves my issue.


185-breadcrumb css and layout

Fix #185
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/
After: https://185-breadcrumb--danaher-ls-aem--hlxsites.hlx.page/

@amlan18041996  - thanks, can we please:

Remove the last chevron
Add the home icon to the homepage
Make the links clickable

@amlan18041996 , @rgravitvl  and @mhaack  - I checked and it's looking great on pages ( https://185-breadcrumb--danaher-ls-aem--hlxsites.hlx.page/us/en/blog/accelerating-implementation-unlocking-potential-of-next-generation-sequencing ), I would approve and merge but there is an issue with lint.


feat(pluto): add new devops-tool pluto

Thanks, looks like a great addition!
Could you lower case your commit please. Conventional commits does not enforce lower case, but consistency can't hurt!
Apart from that, everything looks in order, thanks again!

Thanks! Unfortunately, in the process you added a merge commit, could you remove it. We prefer to have a linear commit history.

Thanks! Unfortunately, in the process you added a merge commit, could you remove it. We prefer to have a linear commit history.

Sneaky Github did this when I pressed the "update" button.


Another assignment destination is read only

~/anaconda3/envs/py3/lib/python3.7/site-packages/xskillscore/core/np_deterministic.py in _rmse(a, b, weights, axis, skipna)
    502     sumfunc, meanfunc = _get_numpy_funcs(skipna)
    503     if skipna:
--> 504         a, b, weights = _match_nans(a, b, weights)
    505     weights = _check_weights(weights)
    506

~/anaconda3/envs/py3/lib/python3.7/site-packages/xskillscore/core/np_deterministic.py in _match_nans(a, b, weights)
     36         # Find pairwise indices in a and b that have nans.
     37         idx = np.logical_or(np.isnan(a), np.isnan(b))
---> 38         a[idx], b[idx] = np.nan, np.nan
     39         if weights is not None:
     40             weights = weights.copy()

ValueError: assignment destination is read-only

Does that only happen for dask or in general? Example please

Glad I just stumbled upon this. I am having the same issues @ahuang11 , but was having trouble recreating it. It came up when testing for a _match_nans rewrite over at https://github.com/bradyrx/esmtools/pull/70.
Some updates over at esmtools that can be migrated here:
def match_nans(x, y):
    if has_missing(x) or has_missing(y):
        x = x.copy()
        y = y.copy()
        idx = np.logical_or(np.isnan(x), np.isnan(y))
        # NaNs cannot be added to `int` arrays.
        if x.dtype == "int":
            x = x.astype("float")
        if y.dtype == "int":
            y = y.astype("float")
        # Need to do the following two lines, only if ndarrays.
        x.setflags(write=1)
        y.setflags(write=1)
        x[idx] = np.nan
        y[idx] = np.nan
    return x, y

@raybellwaves , @aaronspring

The copy() is needed to not mutate the original arrays. the conversion to float is required because if you add a nan to an int array, you'll get some crazy number returned instead (something like -9999999999, but slightly different). The .setflags(write=1) modifies the numpy arrays so that they are now writable.
I'm thinking that .setflags is not that expensive so it can be done no matter what. I'll have to see if I can recreate the writable issue again for testing here.

It looks like we might need the setflags option. I think we just need to do .copy(), which we should do anyways since if we don't copy it we mutate the original objects. So we should just have a = a.copy() and b = b.copy() at the top.


Ignore trailing slash from path field

Hi!
First, thank you for your awesome tool ;) Since a few weeks I have a trouble creating comments on my blog, Staticman creates a branch on my repository, but doesn't create a commit, and when submitting a new comment I have this page:
{

  "code": 422,

  "status": "Unprocessable Entity",

  "message": "{\"message\":\"path contains a malformed path component\",\"errors\":[{\"resource\":\"Commit\",\"field\":\"path\",\"code\":\"invalid\"}],\"documentation_url\":\"https://developer.github.com/v3/repos/contents/\"}"

}

Here is my staticman.yml:
comments:
  path: "_data/comments/"
  allowedFields: ["name", "email", "url", "message", "post_id"]
  allowedOrigins: ["ilphrin.com", "localhost"]
  branch: "master"
  filename: "{fields.name}_{@timestamp}"
  format: "yml"
  generatedFields:
    date:
      type: date
      options:
        format: "timestamp-seconds"
  moderation: true
  name: "ilphrin.com"
  requiredFields: ["name", "email", "message", "post_id"]
  commitMessage: "New comment on the blog"

And here is my form for submitting a comment (I am using Jekyll):
  <form class="ui form" method="POST" action="https://api.staticman.net/v2/entry/Ilphrin/ilphrin.com/master/comments">
    <input name="options[slug]" type="hidden" value="{{ page.slug }}">
    <input name="options[redirect]" type="hidden" value="https://ilphrin.com{{page.url}}">
    <input name="options[origin]" type="hidden" value="https://ilphrin.com" />
    <input type="hidden" name="fields[post_id]" value="{{page.id}}" />

Commenter

            Nom
            <input name="fields[name]" placeholder="Requis" type="text" required/>

            Email
            <input name="fields[email]" placeholder="Requis, non publié" type="email" required/>

            Lien
            <input name="fields[url]" placeholder="Optionnel" type="text"/>

        Allez-y parlez ;)
        <textarea name="fields[message]" placeholder="Requis" required></textarea>

      <button class="ui submit button" type="submit" name="submit">Envoyer</button>

  </form>

And I couldn't figure out how to fix this issue :/

Is this still an issue? If so, could it be because you're using the name field to form the path and it can potentially contain invalid characters? Have you tried changing filename to not depend on it?

This happens to me then I skip the options[slug] field from the comment form.
It may help you @eduardoboucas

It's because staticman is trying to write to _data/{slug}/{comment.id}.yml, and github API fall over on the double slashes.

Thanks @zburgermeiszter, that makes sense. I had a look at a post in particular (http://ilphrin.com/frontend/2017/01/23/traduction-dev-front-dans-le-monde-de-linternet-des-objets.html) and slug is not missing.
@Ilphrin could you please confirm this is still an issue and if so provide a full URL to the page you're trying to submit from?

@Ilphrin Could you try removing the trailing slash from the path field? So "_data/comments" instead of "_data/comments/".

@eduardoboucas Sorry for the delay. I removed the trailing slash and now it's working!  Now I tried posting a comment and it was push correctly on a new branch on my repository.

Great! I'll keep the issue open because we need to ensure a trailing slash doesn't cause the problem.

Maybe Staticman could open an issue with what happened and debug information?

I would suggest to either add this requirement to the documentation.
Or alternatively, simply replace double slashes with single, but then all comment will go to the _data/ without grouping per post.

I think the solution here is quite simple: we just need to remove a trailing slash from the path field, if there is any.


created materials for gig08-01

Copied from gig07-01 and replaced "07-01" to "08-01"

Need to fix the security issue.


Autoplay switch items too fast. Can u pls add autoplay item change animation duration.

@nebmesemaou Unfortunately, it can't be done because the Facebook team has failed to expose such a prop.
See #203 for more info.

Any updates?


fix(ci): run ast_changes CI job if span def file changes

#4706  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


[Feature request] - output dialog fields into HTL

To take this one more step, how about outputting the dialog fields into the component's .html file?

Hrmm...good idea.  :)  Happy to entertain a PR for this.

FWIW here's the demo HTML I use to test the "Demo Component" that is generated from the example config file.

Global: ${demoCompModel.globalTextfieldTest}

Shared: ${demoCompModel.sharedTextfieldTest}

Text: ${demoCompModel.textfieldTest}

Checkbox: ${demoCompModel.checkTest ? "yep" : "nope"}

Path: ${demoCompModel.pathfieldTest}

Text Area: ${demoCompModel.textareaTest}

Date: ${demoCompModel.dateTest.time.toGMTString}

Select: ${demoCompModel.selectTest}

Radio: ${demoCompModel.radioTest}

Hidden: ${demoCompModel.hiddenTest}

Number: ${demoCompModel.numberfieldTest}

Image:

Color: ${item}

Link: ${item.path} - ${item.label}

All of the labels should come from the field names.  Most fields can render w/o any special logic, but some (e.g. checkbox, date, image, multifield) are a little more involved.

This is resolved by https://github.com/adobe/aem-component-generator/pull/26


QA Tools + Docs updates

Travis CI updates:

removed allow_failures on PHP 7.2,
removed composer self-update,

Updated composer.json:

keywords
rss link
order of scripts
PHPUnit 6.4.3

Updated link in SUPPORT.md - expressive instead of components
Fix in LICENSE.md - year instead of placeholder and added missing blank line

Thanks, @webimpress


Guest Network: Port Forwarding Tab

Add port forwarding tab to IPs belonging to an isolated network, or network with port-forwarding capability added. Implement a tab component that can add/remove/list port-forwarding rules.
In old UI, go to any isolated network -> view IP addresses -> select an IP -> go to config tab -> port forwarding.

You can query listNetworks using the record.associatednetworkid to find out if the capability exists, for example to check if Firewall needs to be shown you can do check this in the network record as: record.service.filter(x => x.name && ['PortForwarding'].includes(x.name)).length > 0.

Handled in https://github.com/apache/cloudstack-primate/pull/84


List is empty when building module

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.372 s
[INFO] Finished at: 2023-11-06T10:50:53-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.ozsie:detekt-maven-plugin:1.23.3:check-with-type-resolution (default) on project ftl-module-name: Execution default of goal com.github.ozsie:detekt-maven-plugin:1.23.3:check-with-type-resolution failed: Analyzing /<path>/Module.kt led to an exception.
[ERROR] Location: kotlin.collections.CollectionsKt___CollectionsKt.first(_Collections.kt:214)
[ERROR] The original exception message was: List is empty.
[ERROR] Running detekt '1.23.1' on Java '<IP_ADDRESS>+0' on OS 'Mac OS X'
[ERROR] If the exception message does not help, please feel free to create an issue on our GitHub page.

@wesbillman and @KendallWeihe have more context here.

This has been fixed


Add option for excluding certain hosts

This PR allows users to ignore requests directed at certain hosts from being imported. This can be highly useful when requests were frequently dispatched to external service providers during recording (Fonts, Tracking, ...) and should not be included in JMeter.

To facilitate the hosts display, the importing flow in the GUI was changed such that HAR files are now parsed as soon as users select a file in the file browser.

This PR also replaces the hardcoded pixel-based layouts with more sophisticated layout engines.

You are using a Java 16 feature there with the instanceof matching. The current setup is, to build against Java 11. Actually I am not sure which version is best and whether I can safely upgrade to 16/17/++. JMeter itself seem to be developed with SDK 17, but with version 8 set as target for compatibility reasons (https://github.com/apache/jmeter?tab=readme-ov-file#test-builds). So anyway: version 11 is not really smart. Either going back to 8, and replace this one line in your code with an older approach, or be brave and change to SDK 17 with target version also 17.
What do you think?

decided to go with Java 8 for compatibility. setup is same as JMeter now, I think.
Added a pipeline to check PRs.

i added the changes that i was complaining. furthermore i found a bug. it was re-adding a server to exclude listwhen opening a file multiple times. now the panel is cleared from checkboxes every time


Make the codes more generic

At the moment, the sample metadata stored in the database is specific to FlyMet. It assumes the following info are provided: lifestage, tissue, mutant. For other dataset, these info won't be available, and different types of metadata will be available. I would like to perform the following enhancement to the pipeline to make it more generic in order to be able to load other non-FlyMet dataset in.
In particular here are the codes that will be modified:
In the population script
def populate_samples(sample_csv):
    '''
    Give the sample CSV file to populate the samples.
    KMcL: Working but need to consider the filepath.
    '''
    sample_details = np.genfromtxt(sample_csv, delimiter=',', dtype=str)[2:]
    logger.debug("sd_type %s" % sample_details)
    for sample in sample_details:
        # sample = s.split()
        sample_serializer = SampleSerializer(
            data={"name": sample[0], "group": sample[1], "life_stage": sample[2], "tissue": sample[3],
                  "mutant": sample[4]})
        if sample_serializer.is_valid():
            db_sample = sample_serializer.save()
            logger.debug("sample saved %s" % db_sample.name)
        else:
            logger.debug(sample_serializer.errors)

In the model
class Sample(models.Model):
    """
    Model class defining an instance of an experimental Sample including the tissue and life-stage from which it came
    """
    # Here the sample name is unique as this is important for processing FlyMet data
    name = models.CharField(max_length=250, unique=True, blank=False)
    life_stage = models.CharField(max_length=250, blank=False)
    tissue = models.CharField(max_length=250)
    group = models.CharField(max_length=250, blank=True, null=True)
    mutant = models.CharField(max_length=250, blank=True, null=True)

    def  __str__(self):
        """
        Method to return a representation of the Sample
        """

        return "Sample " + self.name

and in the serialiser
class SampleSerializer(serializers.ModelSerializer):
    class Meta:
        model = Sample
        fields = ('name','life_stage', 'group','tissue','mutant')

Have decided that we will instead create another model called 'Factor'. This will be linked to the Sample model, and use it to store the group, life stage, tissue and mutant in the case of FlyMet. For other dataset, we can store different factors, like timepoints etc.

The PyMT data can now be successfully loaded through the pipeline. However many views are not working, due to the hardcoding in the codes (related to issue #60). Will work on that next.


GitHub issues

This PR has a new plot with toolbar control. I have not integrated that control into FDA yet. I will do that when I get back.

I'll take care of this one

#532 precludes the urgency of getting this PR into main. I'll work on this PR next week.


maintenance-ci-quick-builds

CI: Add phpcs to quick-build ANT target.

test this please

test this please

test this please

test this please

test this please

test this please

test this please


add config params to datamodel

I'm writing a yeoman generator to add tooling to your ui5 project. I am using the datamodel from this repo as recommended by @petermuessig
I'm thinking that after you've selected your packages you have the option to configure the yaml file as well. For this I need the config params to be read. The easiest for me is that it's part of the data model. See (issue #1)[https://github.com/ui5-community/generator-ui5-tooling-extensions/issues/1] The below function handles it if the jsdoc is added as a typedef and properties. See the example on my deprecated onelogin repo since the onelogin now lives in the showcase 😉
static async fetchParams(): Promise {
try {
const indexJs = await GitHubRepositoriesProvider.octokit.rest.repos.getContent({
mediaType: {
format: "raw",
},
owner: "uxkjaer",
repo: "ui5-middleware-onelogin",
path: lib/index.js,
});
const indexString = indexJs.data.toString();
const opt: jsdoc2md.JsdocOptions = {
source: indexString,
};
const data = jsdoc2md.getTemplateDataSync(opt);
const typedef: any = data.filter((x: any) => x.kind === "typedef");
let arr: any = [];
typedef[0].properties.forEach((property: any) => {
const obj = { ...property };
obj.type = obj.type.names[0];
arr.push(obj);
});
console.log(arr);
} catch (error) {
console.log(error);
}
}

Hi @uxkjaer ,
yes, Peter had already mentioned something. Very good idea! Of course I like to support this :)
I haven't tried the code yet, but as it looks you want an array of typedef per package.
I would have to do:
read package --> read yml file --> get entry point(s) --> read jsdoc from entry points
I have to try it out to see what kind of structure i get from it.
But i guess i will save the yaml file and jsdoc to the datamodel as well.

Hi @marianfoo ,
if you need support on this please let me know.
BR,
Peter

If we can maintain this directly in the yaml file that would probably work as well.

How would the yaml file look like?

i created a pull request with the code. I added the jsdoc typedef to my onelogin repo in the showcase to illustrate my example after having discussed this with @petermuessig.
the idea is that the extension has the main property in the package.json file and the @typedef and @property maintained in the entrypoint file to fetch the config parameters. Then I can use that to prompt the user in the generator.
It should propably be part of the github issue to add a package as well if we land on this.

I have a look at your PR right now.
I try to figure out the entry point.
Of course, there are always a edge case :)
What about this?
Here there are theoretically two entry points:
https://github.com/ui5-community/ui5-ecosystem-showcase/blob/ddbb9f8bff4926608fe0aaca88d466c9dd990afd/packages/ui5-tooling-modules/ui5.yaml#L2-L17
But you can´t define two main entry points in package.json


Add more specific indicators to theme name in dropdown list.

Feature Request:
When using this - I often create a build zip of a final theme for distribution, deactivate my development versions and remove any hooks/filters I have and install the distribution version.  This results in me having multiple themes in the dropdown list with the same name.
I think it would be handy to have the word (Active) next to the theme name, or perhaps the version number displayed next to it.  Just something that can help identify multiple themes with the same theme name.
I realize the option is selected for the active theme, but when running multiple scans with different versions of the theme it's hard for me to keep track of.  My current solution has been to just make a temp copy of my themes directory and test versions one by one to avoid the confusion.

I could add active and version number. The themes list business logic is done in the helpers trait so it shouldn't be a problem to do 🙂
Like the suggestion :+1:

Does this look good? @timelsass ?

@dingo-d Yes - I like that

Ok I've pushed the changes to the PR, you can pull them. I'll close the issue 🙂


breaks on ILogger when used inside an AbstractAcceptanceTest

System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=FunctionMonkey
  StackTrace:
   at FunctionMonkey.Infrastructure.FunctionLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
   at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, String message, Object[] args)
   at Vpp.DynamicPricing.Application.GetEchoQueryHandler.ExecuteAsync(GetEchoQuery command) in D:\_projects\Vpp.DynamicPricing.ssh\src\Application\Queries\GetEchoQueryHandler.cs:line 43
   at AzureFromTheTrenches.Commanding.Implementation.CommandHandlerExecuter.<ExecuteActorForCommandWithNoResult>d__4.MoveNext()

my test:
public class GetEchoQueryTests : AbstractAcceptanceTest
    {
        [Fact]
        public async Task ReturnOkResultForQuery()
        {
            var response = await this.ExecuteHttpAsync(
                new GetEchoQuery(),
                HttpMethod.Get);

            response.StatusCode.ShouldBe(200);
        }
    }

where the handler accepts an ILogger in the ctor.
Workaround: inject an ILoggerFactory and create an ILogger from that in the ctor, like this:
public class GetEchoQueryHandler : ICommandHandler<GetEchoQuery>
    {
        private readonly ILogger logger;

        public GetEchoQueryHandler(ILoggerFactory loggerFactory)
        {
             this.logger = loggerFactory.CreateLogger<GetEchoQueryHandler>();
        }

Hmm. Interesting. I'll take a look at that - I'm writing some acceptance tests at the moment. I think I know what is going on and it should be (famous last words) a simple fix.
Thanks for reporting.

I've resolved this so that ILogger is now accessible, you can also inject a mock logger if you want to check critical log output for example.

Addressed in v3.0.4-beta1. Thanks!


getting random 404s

Environment

Node.js 20.11
h3 1.10.0
listhen 1.5.6

Reproduction
https://github.com/pingdotgg/uploadthing/tree/h3-debug
https://github.com/pingdotgg/uploadthing/blob/h3-debug/examples/backend-adapters/server/src/h3.ts
Describe the bug
I have noticed a random 404 error when fetching from itself, i.e. /api/uploadthing fetches /api/uploadthing on the same server. We use this for our dev webhook but it seems to fails for some reason...
To reproduce, checkout the repo and the linked branch, pnpm i, pnpm build, cd examples/backend-adapters and run the h3 example using pnpm dev:h3. This starts a vite server up at port 5173 as well as a listhen instance on port 3000 with the h3 app.
Attempt to upload an image, and wait for the 404 to show up.
I also added a simple nitro server that you can compare to (run using pnpm dev:nitro), which works out of the box without issues. Maybe I have configured the h3 app wrong?
Additional context
I also tried using a "raw" node.js server to eliminate listhen as the possible cause of error but that had the same behavior
Running the h3 app
https://github.com/unjs/h3/assets/51714798/64238aa1-c465-4915-b3e2-880d4e3f8f81
Running Nitro for comparison
https://github.com/unjs/h3/assets/51714798/4c1a933a-c9f0-4d0e-be3c-f0a62f38214b
Logs
No response

Hi, dear @juliusmarminge. First, THANK YOU for spending time to make proper reproduction and write description and nice work in uploadthing library ❤
I have did little investigation to find a simple fix!
Some more context:
H3 router by default is in non-preemptive mode (see https://github.com/unjs/h3/pull/194 and https://github.com/unjs/h3/issues/183 -- it is to allow multiple routers) but in Nitro, the router is preemptive because we can safely assume it for top-level router (https://github.com/unjs/nitro/pull/1504). When router is in non-preemptive mode and an event handler returns an undefined value (the issue in uploadthing), h3 keep search other middleware (which non of them also response) and finally give a 404 back.


perf(ui/snackbar): add class

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #370 (8410609) into dev (73426b2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #370   +/-   ##
=======================================
  Coverage   96.39%   96.39%
=======================================
  Files         209      209
  Lines        4905     4907    +2
  Branches     1047     1047
=======================================
+ Hits         4728     4730    +2
  Misses        177      177

Impacted Files
Coverage Δ

packages/varlet-ui/src/skeleton/Skeleton.vue
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73426b2...8410609. Read the comment docs.


400 text : Bad Request on user provisioning to salesforce

Moved from https://wso2.org/jira/browse/IDENTITY-7237

Add an IdP with salesforce provisioning enabled. [2]
Enable outbound provisioning in resident service provider and select above created IdP as the provisioning connector.
Add user using UI - Do not select the role. just click finish

User is added to local user store without any issue. But it's not provisioned to salesforce.
Error:
recieved response status code :400 text : Bad Request

Moved to https://github.com/wso2/product-is/issues/5728


Prepend to shell prompt after activation

virtualenv converts the shell prompt to (venvname) $PROMPT at activation, which is really nice for knowing when you are/aren't in a virtualenv. I think it would be good for Playground to behave similarly.
e: I see this actually works nicely on bash, it does not on zsh though. It would be good for them to say the name of the active playground though!

I know it already does this for bash, fish and in the REPL, but I don't use zsh so fixes on that front would be much appreciated.


update devicelab salt provisioning script to include autosign

Needed for salt master to auto accept minion keys:
autosign_grains:
  - fqdn

Seems fixed: https://github.com/flutter/cocoon/pull/2462/files


Typescript error when using router in a default vite project

Describe the bug
When I try to use @tanstack/react-router in a freshly scaffolded vite project, typescript complains on createRouter or createRoute function invocations with the following message:

The inferred type of 'router' cannot be named without a reference to '../node_modules/@tanstack/react-router/dist/esm/route'. This is likely not portable. A type annotation is necessary. [2742]

I narrowed down the error to be related to moduleResolution: bundlerand composite: true compiler options set in tsconfig.json.
Those options are the default in the new vite projects.
I also narrowed down the @tanstack/react-router version that introduced this regression, which is: v1.48.0 .
Looking at the changes introduced by this PR I think
the fix should be fairly simple.
Adding the missing DefaultSearchValidator type export in index.tsx file should do the job.
Your Example Website or App
None as from what I've noticed typescript errors are not reported in Stackblitz code editor.
Steps to Reproduce the Bug or Issue

Scaffold a default vite react project.
Set up basic @tanstack/react-router routing.
Look at the createRouter function invocation in main.tsx file in your code editor.

Expected behavior
No typescript error should be reported in the code editor.
Screenshots or Videos
No response
Platform
Platform is irrelevant as it is solely a typescript related issue.
Additional context
No response

can you provide a PR? ideally also add an example that fails without your fix

please try again if this issue still exists with https://github.com/TanStack/router/releases/tag/v1.49.8

please try again if this issue still exists with https://github.com/TanStack/router/releases/tag/v1.49.8

The issue still remains, unfortunately.
However, this issue is no longer reproducible with the default vite project because I think vite just recently changed their default  tsconfig.app.json file.
They removed the following compiler options:
"composite": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",
After removing those typescript no longer complains. So maybe we can leave it as it is and close the issue for now, since it might be due to some misconfiguration on vite side. I don't really know.


AssertionError: Dynamic dims not currently supported in tensor_slice function of IREE

we actually have had this working and it was still working up till last week stateless_llama.py it was working using shark_turbine and all of a sudden we start getting an issue and unfortunately we had some libraries not locked with specific version and I guess there few updates released last week and it did not work anymore .... I tried to use older versions of iree-turbine and torch but could not make it work any more.
now we are getting the following error
... Traceback (most recent call last):    File "/app/app/services/../pipelines/llama_2_pipeline/run_pipeline.py", line 92, in slice_up_to_step\n    sliced = IREE.tensor_slice(\n  ...
...    File "/usr/local/lib/python3.10/dist-packages/iree/turbine/aot/support/procedural/iree_emitter.py", line 285, in tensor_slice\n    result.set_dynamic_dim_values(result_dynamic_dims)\n  ...
...    File "/usr/local/lib/python3.10/dist-packages/iree/turbine/aot/support/procedural/iree_emitter.py", line 285, in tensor_slice\n    result.set_dynamic_dim_values(result_dynamic_dims)\n  ...
...   File "/usr/local/lib/python3.10/dist-packages/iree/turbine/aot/support/procedural/primitives.py", line 168, in set_dynamic_dim_values\n    assert len(values) == 0, "Dynamic dims not currently supported"\nAssertionError: Dynamic dims not currently supported\n'} ...
I have used the following and tested different versions
torch 2.5.1 also tested with 2.4.1
iree-base-compiler  2.9.0
iree-base-runtime  2.9.0
iree-turbine 2.9.0 also tried with 2.5 and 2.3
python 3.10 and 3.11
rocm/dev-ubuntu-22.04:6.0.2 and 6.1

@ammarhd Not really related to your issue but did you run into this error?
error: "<eval_with_key>.0 from /home/nouman-10x/shark-model-dev/turbine_venv/lib/python3.10/site-packages/torch/fx/experimental/proxy_tensor.py:551 in wrapped":95:0: 'torch.aten.copy_' op operand #0 must be Multi-dimensional array modeling Torch's Tensor type, but got '!torch.vtensor<[?,?],f32>'

Also you might want to try
iree-compiler: 20240828.999
iree-runtime: 20240828.999
transformers: 4.37.1
torch: 2.3.0+cpu
shark-turbine: 2.4.1

As the error message states, dynamic dims is currently not supported as support was removed with commit 97e0517. The backing APIs have been deprecated for a year and torch.export.dynamic_dim() was removed with https://github.com/pytorch/pytorch/commit/b454c51. Thus you will need to refactor your code if you want to use newer iree-turbine and / or torch versions.

As the error message states, dynamic dims is currently not supported as support was removed with commit 97e0517. The backing APIs have been deprecated for a year and torch.export.dynamic_dim() was removed with pytorch/pytorch@b454c51. Thus you will need to refactor your code if you want to use newer iree-turbine and / or torch versions.

If the support for dynamic dims is removed, how is one supposed to provide dynamic input to an LLM? Sorry if this is a dumb question but would appreciate any pointers or already written examples.

This comment is not correct. Support for the pytorch pre-release API for specifying dynamic shapes was removed because pytorch removed it. It had been deprecated for a long time with the recommendation to support the official API.
See pytorch's documentation: https://pytorch.org/docs/stable/export.html#expressing-dynamism
This is what we support.

We don't have a replacement mechanism for specifying dynamic shapes across turbine functions except to use old versions. It is likely that stateless_llama can be reworked to the new API, but I havent looked at it for a long time since we have been using a more direct approach to torch.export llm models.

We don't have a replacement mechanism for specifying dynamic shapes across turbine functions except to use old versions. It is likely that stateless_llama can be reworked to the new API, but I havent looked at it for a long time since we have been using a more direct approach to torch.export llm models.

The latest way to support dynamic dims would be something like this?
import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.export import Dim
import iree.turbine.aot as aot

class SimpleDynamicModel(nn.Module):
    def __init__(self, input_features, hidden_units, output_features):
        super(SimpleDynamicModel, self).__init__()
        self.fc1 = nn.Linear(input_features, hidden_units)
        self.fc2 = nn.Linear(hidden_units, output_features)

    def forward(self, x):
        x = F.relu(self.fc1(x))
        x = self.fc2(x)
        return x

# Parameters
input_features = 10  # Number of features in each input
hidden_units = 32    # Number of units in the hidden layer
output_features = 1  # Number of output features

# Instantiate the model
model = SimpleDynamicModel(input_features, hidden_units, output_features)

# Example usage with dynamic batch size
batch = Dim("batch")
dynamic_shapes = {"x": {0: batch}}
batch_size = torch.randint(1, 20, (1,)).item()  # Random batch size between 1 and 20

dummy_input = torch.randn(batch_size, input_features)

exported = aot.export(SimpleDynamicModel(input_features, hidden_units, output_features), dummy_input, dynamic_shapes=dynamic_shapes)
exported.save_mlir("./mlir")

we have been using a more direct approach to torch.export llm models.

Can you share any relevant examples?

When turbine was first written, the export path did not support mutable arguments or buffers, and this required the meta programming Jack that stateless llama did to tie kv cache state to a global variable. It had a number of issues, not the least of which was that it used a progression of bigger-by-1 intermediate buffers to get across the torch barrier (this kills caching allocation schemes and costs a lot of perf). It also made unnecessary copies.
The new work that my group does uses mutable function arguments to pass a fixed size kv cache in for in place operation. I've also been told of another group who does not have their code accessible that is using torch module level buffers to the same effect.
Our canonical example is still pre release and more complicated than it should be but it's here: https://github.com/nod-ai/shark-ai/blob/main/sharktank/sharktank/examples/export_paged_llm_v1.py
Note that this uses a paged kv cache by default, which requires a much more complicated inference sequence intended for serving. The flags in there for "direct" cache approximate what stateless llama was doing with a single, linear cache.
For even simpler use (and what I think the other group did), you can just create a torch wrapper module that registers a buffer for the kv cache and then slices it to an expected size of interfacing to something like a transformers model. We don't have a public examine of that afaik.


Throwing ERROR(vue-tsc) from an external library

Hello, after updating vue-tsc to 1.8.8 in one of the projects, I'm having problems with it throwing an error from an external library. When the project runs with vite, the vue-tsc throws an error from the external open-source component-library. This library is based on a different vue-tsc version, but I think it shouldn't be an issue (it's an external library after all), should it? I think the skipLibCheck flag in the tsconfig.json should do the job, but for some reason it doesn't.
The tsconfig in the project is the following:
{
  "compilerOptions": {
    "outDir": "./dist",
    "allowJs": true,
    "esModuleInterop": true,
    "isolatedModules": true,
    "noImplicitAny": true,
    "jsx": "preserve",
    "lib": [
      "esnext",
      "dom",
      "dom.Iterable"
    ],
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "verbatimModuleSyntax": true,
    "importHelpers": true,
    "experimentalDecorators": true,
    "baseUrl": "./",
    "paths": {
      "@/*": [
        "src/*"
      ],
      "@customization/*": [
        "customization/*"
      ]
    },
    "skipLibCheck": true,
    "sourceMap": true,
    "strict": true,
    "target": "ESNext",
    "types": [
      "vitest/globals",
      "vite/client"
    ],
    "useDefineForClassFields": true
  },
  "include": [
    "src/**/*",
    "tests/**/*",
    "e2e/**/*",
    "stories/**/*",
    "scripts/**/*",
    "customization/**/*",
    "**/*.ts.vue",
    ".eslintrc.js",
    "vite.config.ts",
    "playwright.config.ts",
    "vite-plugins/*.ts"
  ]
}

I am seeing this too. skipLibCheck is true and node_modules is in the excludes array, but I am still seeing errors related to node_modules.
> npx vue-tsc --project tsconfig.gen-dts.json --noEmit

node_modules/vue-slider-component/lib/utils/control.ts:554:22 - error TS6133: 'pos' is declared but its value is never read.

554     dotsPos.forEach((pos, i) => {
                         ~~~

Found 1 error in node_modules/vue-slider-component/lib/utils/control.ts:554

Yeeep, but I have those for the .vue files (which are obviously not .ts files), so what in this case?

I'm not sure if we can avoid this behavior: https://github.com/vuejs/language-tools/blob/master/packages/vue-tsc/bin/vue-tsc.js#L15-L17
Volar needs to patch tsc to include .vue files so they can get typechecked, which leads to this error

I have no direct imports from the node_modules but still have that same issue in turbo monorepo.

Please check if this issue has been resolved in version 2.x. If not, feel free to create a new one.


Tools: Remove non-existent songs from library

Add a tool that lists songs whose files have been removed from the disk and can remove them from the library.

Fixed in ea63140f58a8a6da8ccc70f6722c22d017c49753


When serving files from public directory, page reload is not working for these files

Describe the bug
Page reload is not working on files in public directory since 2.3.0, possible related to https://github.com/vitejs/vite/issues/3233
Reproduction
npm init @vitejs/app my-vue-app -- --template vanilla

and add <img src="/favicon.svg" /> to the index.html, then change the colors inside the svg, nothing happens. The same applies if you serve css or js from the public directory.
System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.3.1
    CPU: (8) x64 Apple M1
    Memory: 73.75 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.5 - ~/.nvm/versions/node/v14.15.5/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.5/bin/yarn
    npm: 7.11.2 - ~/.nvm/versions/node/v14.15.5/bin/npm
  Browsers:
    Chrome: 90.0.4430.93
    Firefox: 88.0.1
    Firefox Developer Edition: 89.0
    Safari: 14.1
  npmPackages:
    vite: ^2.3.0 => 2.3.0

Duplicate of https://github.com/vitejs/vite/issues/3233


Don't set the status as finished if the conclusing is pending

Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>

/retest

Codecov Report

Merging #262 (00b591f) into main (88d2644) will increase coverage by 0.13%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   70.23%   70.37%   +0.13%
==========================================
  Files          27       28       +1
  Lines        1690     1681       -9
==========================================
- Hits         1187     1183       -4
+ Misses        389      388       -1
+ Partials      114      110       -4

Impacted Files
Coverage Δ

pkg/pipelineascode/pipelineascode.go
72.61% <81.25%> (-0.11%)
:arrow_down:

pkg/webvcs/github/acl.go
82.89% <87.50%> (+3.37%)
:arrow_up:

pkg/acl/acl.go
100.00% <100.00%> (ø)

pkg/webvcs/github/status.go
87.80% <100.00%> (ø)

pkg/matcher/repo_runinfo_matcher.go
100.00% <0.00%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3ea0e...00b591f. Read the comment docs.


Rev python-etcd to 0.4.2.

tox.ini needs updating too.  It specifies a commit id for python-etcd.

Done

retest this please

retest this please

retest this please

Build timed out, retest this please

retest this please

Hmm, chef install failed.  Not sure we have time to dig into that before 1.2.0 so let's bump this patch to the next release.

Turns out EL7 setuptools is so old that +s get treated as -s, which sort differently.  I'm going to back this out (but still tell people to use the latest and greatest).  It's a bit of a shame really: we can clean it all up when we get to 0.4.3.


[SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency

What changes were proposed in this pull request?

Remove com.github.rdblue:brotli-codec:0.1.1 dependency.
Why are the changes needed?

As Stephen Coy pointed out in the dev list, we should not have com.github.rdblue:brotli-codec:0.1.1 dependency which is not available on Maven Central. This is to avoid possible artifact changes on Jitpack.io.
Also, the dependency is for tests only. I suggest that we remove it now to unblock the 3.2.0 release ASAP.
Does this PR introduce any user-facing change?

No
How was this patch tested?

GA tests.

Test build #143475 has started for PR 34059 at commit 452340c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47986/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47986/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47986/

Test build #143478 has started for PR 34059 at commit fbae6ac.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143475/

Thank you. The first commit passed UTs and the other commits are only touching comments.
Merged to master/3.2.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47989/

Test build #143478 has finished for PR 34059 at commit fbae6ac.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47989/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143478/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47990/

Test build #143479 has finished for PR 34059 at commit eaeba81.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143479/


Support accept events from server

Codecov Report

Merging #32 (8d53ec6) into main (18e4d4e) will decrease coverage by 0.42%.
The diff coverage is 83.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   84.70%   84.28%   -0.42%
==========================================
  Files           6        6
  Lines         536      541       +5
==========================================
+ Hits          454      456       +2
- Misses         82       85       +3

Impacted Files
Coverage Δ

src/evaluate.rs
83.33% <80.00%> (-1.03%)
:arrow_down:

src/feature_probe.rs
81.45% <100.00%> (ø)


Disabled starting MongoDB service by default

There should be a note next to the mongo connection string when mongo service is not started. I wasted more time than i'd like to admit trying to connect to the emulator.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1300a10b-16f3-9185-af2a-67437bf428d2
Version Independent ID: 07fd7c5a-0ad5-a7b4-21ef-768f183076aa
Content: Azure Cosmos Emulator download and release notes
Content Source: articles/cosmos-db/local-emulator-release-notes.md
Service: cosmos-db
GitHub Login: @markjbrown
Microsoft Alias: mjbrown

@boppbo Thanks for the feedback. Your product feedback is appreciated but this will be new addition to the product functionality. So please provide the feedback on User Voice link so that it can be prioritized and implemented by product team.
https://feedback.azure.com/forums/263030-azure-cosmos-db
If you have any further issue, please get back to us or at this time we will move forward to close this case.


[MRG] fixes pandas compatibility and other errors

After fixing the pandas incompatibility, the recursive feature elimination and recursive feature addition tests are raising errors because the tests are non deterministic.
This comes from using an integer in the cv param of cross_validate.
I tried changing that for kfold, and it does make the tests deterministic, but I am not sure this is the best way forward.
I think we need to think how to re-elaborate the tests for these selectors.

@solegalli By reading the docs I would expect the cross_validate to have some stochastic effect in the recursive_feature_elimination because
model = cross_validate(
            self.estimator,
            X[self.variables_],
            y,
            cv=self.cv,
            scoring=self.scoring,
            return_estimator=True,
        )

Call StratifiedKfold when cv is an integer. By default, StratifiedKFold has its random_state argument set to False. Did you try to directly provide StratifiedKFold as argument to Model?
model = cross_validate(
            self.estimator,
            X[self.variables_],
            y,
            cv=StratifiedKFold(n_split=self.cv, random_state=42)
            scoring=self.scoring,
            return_estimator=True,
        )

I see a splitter need to be provided so it could be that
cv = StratifiedKFold(n_split=self.cv, random_state=42).split(X, y)

is required to work.

Hi @gverbock
Sorry, I just saw your comments.
StratifiedKFolds only uses random_state then shuffle=True. But by default shuffle is False, so in theory, the splits should be the same (without randomness) because it is splitting based on row number. So I don't think the problem comes from there.
Having said this, I think we need to improve the tests of the RFE and RFA so that they are not stochastic. But I think it would be good to break it down into smaller tests to try and pinpoint where the volatility is coming from.
In this PR, I captured the main functionality of RFE and RFA in a new base class, and started breaking down the tests. But in doing so, I encountered a problem with the filter out variables function that we need to fix.
I also expanded the BaseSelector to include the confirm_variables param, in the init and fit() method, so we avoid adding boilerplate to all classes.
All tests should pass except RFE, RFA and the new base Recursive class.
Could you please merge and expand the filter out functionality? And also extend the confirm variables to the remaining selectors? Expand the tests to include different arguments to the variables param?
Also, if you feel in the mood, you can help me break down the tests for the base recursive, RFA and RFE. If not, I'll take it from where you left of.
More comments in the main PR
Thanks a lot!!!


[PE-D][Tester E] Editing timetable clears the timetable

I wanted to edit the timetable to only Tuesday 8-9, although it ends up with the timetable being cleared.
Your browser does not support the video tag.video:https://raw.githubusercontent.com/sarjinius/ped/main/files/bf5ccc2a-d52a-4db4-9585-efc799600dff.mov

Labels: type.FunctionalityBug severity.Medium
original: sarjinius/ped#8

Same bug as #137


Add GHA to upload artifacts

Automate generating release binaries for musl/mac/win on every tag to cardano-node repository (similar to how our docker containers work).

An example of workflow running is here https://github.com/input-output-hk/cardano-node/actions/runs/4933488682

This looks good, but I don't understand why the release binaries don't appear on the release page : https://github.com/input-output-hk/cardano-node/releases/tag/hkm/test-tag-8

never mind, it works but the release was deleted.

Wondering though, do we need to upload the artifacts to the build (as double-zip, so not very practical)? Could we just upload to the GH release?

Wondering though, do we need to upload the artifacts to the build (as double-zip, so not very practical)? Could we just upload to the GH release?

I think we should do just release.
I'll discuss a few security concerns with @disassembler tomorrow.

do we trust GH runners? Should we have shared runners?
do we trust the release action? Should we fork it, audit it?
do we want additional backups on S3?
do we want to instantiate only on the runners and force realization from a trusted store?

* do we want to instantiate only on the runners and force realization from a trusted store?

we could use something like nix --builders "" --max-jobs 0 to enforce that the binaries come from our trusted cache.


Organize code to have a "clean" angular/src/runtime.dart

This is an internal library that will be imported by generated code and internals only.
(Internal issue b/66905746)

This is mostly the goal of the compiler pipeline at a macro level anyway.


[BEAM-8403] Guard request id generation to prevent concurrent worker access

There is a race condition in GrpcStateRequestHandler which surfaced after the
recent changes to process append/clear state request asynchronously. The race
condition can occur if multiple Runner workers process a transform with state
requests with the same SDK Harness. The SDK Harness has multiple workers threads
which can access the id generation code in parallel.
For example, this setup occurs with Flink when a TaskManager has multiple task
slots and two or more of those slots process the same stateful stage against an
SDK Harness.

Run Portable_Python PreCommit

Run Python PreCommit

Change LGTM.
I would suggest against using the atomiclong dependency, it is stale and marked by the owner as do not use this.
Precommit failed for an unrelated issue. Related to BEAM-8194 and pypi being flaky. That would be addressed separately.

@aaltay ignoring the specific dependency, what is the generally recommended approach for such situations? Explicit locking or are there other options?

@mxm no occurrence of the error during testing with this change, we should be good to go

Thanks for the reviews!
I doubt that using the atomic long (native) library will make any measurable difference. The reason is that in Python there can only ever be one thread active at a time (due to the Global Interpreter Lock (GIL)), so the lock basically comes for free. Only in the very rare case of a thread having to wait for the lock (which even in tests it was hard to reproduce), there will be a super minimal delay for switching to another thread to release the lock.
Generally speaking, we should be more concerned about the parallelism model of the Python harness. Effectively, we are scarifying performance by letting multiple Runner workers process data with a GIL-threaded Python harness. I'm not sure if you have done performance measurements but the throughput of a single SDK Harness with N workers vs N instances of an SDK Harness should be huge. The former being effectively single-threaded while the latter having N "real" threads.

Run Python PreCommit

Unrelated test failures for both testPy37Gcp and testPython37:
ERROR: test_concurrent_requests (apache_beam.runners.portability.artifact_service_test.ZipFileArtifactServiceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/runners/portability/artifact_
service_test.py", line 215, in test_concurrent_requests
    _ = list(pool.map(check, range(100)))
  File "/usr/lib/python3.7/concurrent/futures/_base.py", line 586, in result_iterator
    yield fs.pop().result()
  File "/usr/lib/python3.7/concurrent/futures/_base.py", line 425, in result
    return self.__get_result()
  File "/usr/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/runners/portability/artifact_
service_test.py", line 208, in check
    self._service, tokens[session(index)], name(index)))
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/runners/portability/artifact_
service_test.py", line 73, in retrieve_artifact
    name=name)))
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/runners/portability/artifact_
service_test.py", line 70, in <genexpr>
    return b''.join(chunk.data for chunk in retrieval_service.GetArtifact(
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/runners/portability/artifact_
service.py", line 133, in GetArtifact
    chunk = fin.read(self._chunk_size)
  File "/usr/lib/python3.7/zipfile.py", line 899, in read
    data = self._read1(n)
  File "/usr/lib/python3.7/zipfile.py", line 989, in _read1
    self._update_crc(data)
  File "/usr/lib/python3.7/zipfile.py", line 917, in _update_crc
    raise BadZipFile("Bad CRC-32 for file %r" % self.name)
zipfile.BadZipFile: Bad CRC-32 for file '/3b2b55eb92de23535010b7ac80d553ec2d4bae872ac5606bc3042ce9313dff87/763ed77b36bcd01e3c2a2f8e0d615cfe3b1f3ad2d1f93b6948a11b9dd32e6d53'

You are right that due to the GIL there is no real parallelism. That's why there is the option to use multiple SDK worker processes (configurable via pipeline option sdk_worker_parallelism).
As part of the verification for this change I found that using 2 worker processes instead of one leads to throughput increase of ~50%. It won't be 100% because Python is still going to switch threads while waiting for IO etc.
It is still desirable to have a proper abstraction for something as basic as an atomic counter. It results in code that is more readable and easier to understand, and helps avoiding issues such as this in first place. Perhaps that's something the Python SDK experts can consider?


PyTorch uses AVX2 even when loading onto GPU

System Info
Version: ghcr.io/huggingface/text-generation-inference:latest
Model: TheBloke/MythoMax-L2-13B-GPTQ:gptq-4bit-128g-actorder_True
GPU: Nvidia A4000
Ubuntu 22.04
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Issue
In the course of debugging https://github.com/huggingface/text-generation-inference/issues/929, I discovered that PyTorch is using AVX2 instructions even when loading the model onto the GPU. nvidia-smi shows that the model appears to be loaded to the GPU and I assume that this exception is thrown immediately after the model is loaded. I tried disabling custom kernels.
dmesg shows this:
traps: text-generation[1713525] trap invalid opcode ip:7fb007be3a0e sp:7ffff8a730a0 error:0 in rotary_emb.cpython-39-x86_64-linux-gnu.so[7fb007bd3000+1d000]

I've used PyTorch extensively on this server and never encountered an illegal instruction error during the countless model loads.
It would be great if TGI could support older CPUs.

rotary_emb.cpython-39-x86_64-linux-gnu.so

That's layer_norm kernel from flash attention there.

It would be great if TGI could support older CPUs.

I think you should try just rebuilding the CLI from source and everything should work out of the box if the compilation is not too bad. Unfortunately we cannot distribute a non AVX docker image since most users will actually have AVX.


 When I search Monarch don't find this term.
I also wanted to ask, is there any reason in these cases why terms can't be merged so that  we don't need to reannotate?

@ValWood you are right! I know Monarch is not in sync with Mondo, it's a bit behind, I'll report this on the Monarch tracker.
In this case MONDO_0013346 is replaced by MONDO:0100215, I don't know why this isn't displayed in Monarch. I'll report this to Monarch.


Adding tutorial about how to use Dify Console API (Managing Apps)

This pull request introduces a tutorial on how to use the Dify Console API to manage applications effectively. The focus is on automating application management between environments and enabling versioning of applications as code. The tutorial provides essential information for:

Importing Applications: How to import application configurations programmatically.
Exporting Applications: Steps to export applications for backup or migration purposes.
Listing Applications: Retrieving a list of all applications within a workspace.
Creating Applications: Automating the creation of new applications through API requests.
Updating Applications: How to update existing application configurations.
Retrieving Specific Applications: Fetching details of a particular application by its ID.

Key Contributions:

Simplified API interactions for managing applications.
Step-by-step instructions with example cURL commands.
Guidance on obtaining workspace_id for API requests.

This tutorial aims to facilitate automation of deployment processes and support the versioning of applications as code, making it easier to manage Dify applications across different environments.

Hi, @crazywoola.  Would you help me with this PR? Please

We currently plan to expose this part of the API interface for everyone to use, and our backend is switching the behavior of login state management, from stateless to server storage state.
Thanks for your pr :)


Not answer

When I open BloxTrap and then Xeno, "Xeno is not answer", and then it closing
Help me pls

???

???

Xeno is not working


Sema: Warn that resilient uses of @_implementationOnly are deprecated

Report uses of @_implementationOnly in resilient modules as deprecated. With a fixing to replace it with internal or delete it when imports are internal by default.
Uses of @_implementationOnly in non-resilient modules is already reported as being unsafe.

@swift-ci Please smoke test

ff797cf  Sema: Warn on resilient uses of @_implementationOnly as deprecated

@swift-ci Please smoke test

@swift-ci Please smoke test


[IO-714] Fixed ReaderInputStream not calling CharsetEncoder.flush issue

@kevinwang1975
Broken builds, please check the logs for Checkstyle errors.

@garydgregory made a little improvement, wondering if you got a chance to check it out? Thanks!