gon object not reloading in between page changes due to turbolinks

This is related to #90 and https://github.com/peresleguine/pluggable_js/issues/4.
Basically, because turbolinks does not always reload the data in the document head when a page changes, there are times when new gon variables are not pushed to the object.
Turning off turbolinks is a solution (but then you can't take advantage of it), and I've found that moving the include_gon helper from the document head to the body also works. This forces the window.gon object to refresh on every page load. To ensure all the the variables are available to all scripts on the page, it's probably best to include the helper near the top of the body, like so:
<body>
<%= include_gon %>
<!-- all other code -->

any news on this? i just noticed i am affected

Ok, so this is how I hacky fixed it:
I wrapped include_gon in a div of id="gonvariables".
Then I added a function that fires on page:restore (which executes on page back as well). It reads the gon generated javascript and evaluates it, refreshing the js gon variables with the correct ones.
var gonfix;
gonfix = function(){
	eval($("#gonvariables > script").html());
};
$(document).on('page:restore', gonfix);

Great, @shadowed87, maybe you see how we can include this solution in gon library? Maybe add special option and readme section for it?

to work with turbo links I used below code:
var gonturbo;
gonturbo = function(){
if ( typeof gon.fstatus != "undefined") {
var fstatus = gon.fstatus;
$('#vacant'+fstatus.fid+fstatus.bid).text(fstatus.vacant);
$('#occupied'+fstatus.fid+fstatus.bid).text(fstatus.occupied);
$('#reserved'+fstatus.fid+fstatus.bid).text(fstatus.reserved);
$('#total'+fstatus.fid+fstatus.bid).text(fstatus.total);
}
};
$(document).on('page:load', gonturbo);

It's helpful for me when I need to generate a line chart in body area after a user conducting a act such as clicking a link to a next page for changing content of a page.

👍  Agree, we noticed this too as one of the last steps of implementing Turbolinks 5. We'll try @shadowed87's work-around.
I noticed this hasn't been touched since Rails 5 was released. Is there isn't a fix to be made for this, it'd be nice to have a the recommended work-around approach for Turoblinks 5 included in the README.
Thanks for your work on this awesome library, we've used gon in a ton of places.

Here is what Turbolinks says about using gon: https://github.com/turbolinks/turbolinks/wiki/Using-Gon-and-turbolinks-in-Rails


add a option to controls whether debugPrintRoute executes

Is your feature request related to a problem? Please describe.

When the server is running, it  will print a lot of logs of the routes and i wish I could control its printing

Describe the solution you'd like

add a option

It seems that adding a new parameter to addRoute would require a lot of changes. Is it feasible to use syntactic sugar to transform into optional parameters.

It seems that adding a new parameter to addRoute would require a lot of changes. Is it feasible to use syntactic sugar to transform into optional parameters.

add With** 's option

I want to do it

@L2ncE  Thanks, but there are unfinished doc  issues, so issue will unassigned.


Feature to stop DM's from bot

The bot keeps messaging my primary account with messages like this one:
Requesting 100 more messages, (before 2018-07-16 04:46:34.167 +0000 +0000)
Discord does not have a feature to mute friends, so a feature to stop these messages would be very appreciated

already addet:
set "send notices to interactive channels = false" to true


feat(Transcoder): Add sample and test for concatenated input videos

b:197546828

Merging, failures are of Asset tests timing out, and that's being taken care of in #1575


UTF-8 font issue

Describe the bug
Turkish letters render is broken (letters: 'ı','ö','ğ','ş','ç','ü')

UTF-8 is currently not supported for other languages than english, try using ANSI encoding.


Setting the initial score threshold

Is there a way for changing the initial filtering of the graph?

You can set it using something like
$("#interactionFilterYOURDIVID").val("direct");
$("#scoreFilterYOURDIVID").val("0.4");

Thanks for your help!


On results screen, add full emoji legend below Share this and Ask another buttons

via slifty: "If we can make the results a little more legible somehow that might be nice (e.g. show the three emoji you "got" with their descriptions next to them?)"
Matt: We could document.write(symbols) immediately underneath the Ask again and Share buttons in

we could have more room for results by having the "final" screen overlap the dial entirely? it would definitely help on mobile, where screen real estate is at a premium.

@louh good idea


fix flow display between switch flow id

Fix https://github.com/dataelement/bisheng/issues/146

Please elaborate on what kind of problems arise in what circumstances

Fix #146

very appreciate of your contribution


Feaeture - touchmove event dispatch handlers for Line and StackedArea

Description
Added touchmove custom event handlers for both Line and StackedArea charts. It can be called and handled without including tooltip.
Motivation and Context
https://github.com/eventbrite/britecharts/issues/456
How Has This Been Tested?
Added 1 test each for StackedArea and Line charts that check the customTouchMove event handler is dispatched when touchmove event is called.
Screenshots (if appropriate):
touchmove for Stacked Area:

touchmove for Line:

Types of changes

[ ] Refactor (changes the way we code something without changing its functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style guide of this project.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hi @DalerAsrorov, I saw your commit and the change is small so it should just be ok.
I see there is a bit of inconsistency between the charts functionality mainly due code duplication (or missing between charts).
I can see that the line chart does handle the "customDataEntryClick" that I assume is the click event, but other charts like the groupbar doesn't implement that part.
Are you planning to share the common functionality between charts?
Another question is regarding the touchmove event, should it not be also implement the same functionality as the handleMouseMove function (a part from the dispacher)?
Hope helps,

Hi @ISMAELMARTINEZ,
'customDataEntryClick' is not a regular click event, is a click in one of the highlight points shown when hovering over the line or stacked area charts. The Bar Chart is the only one that has a 'customClick' event.
I am curious about your use case for having a click on the grouped bar. Still, I think it makes sense to add customClicks to all bar charts.

Will investigate more into adding the touchmove to simulate mousemove, seems like the API of adding event handlers changed multiple times.

@Golodhros, We show energy data for hours/days/weeks/months...  and use the group bar for comparison.
when you click on the bar you "zoom in" to that part of the day/week/month. That is our usage.

Thanks @ISMAELMARTINEZ !
I have created an issue for this: https://github.com/eventbrite/britecharts/issues/534

@ISMAELMARTINEZ I have a PR ready https://github.com/eventbrite/britecharts/pull/535, if you have comments feel free to add!


Connection to the graphql endpoint not working

http://localhost:3030/graphql-alpha is not able to load, using reaction 1.12.1 and the graphql based storefront with the reaction-api.  The error is a GET query missing. The graphiql endpoint works though?? http://localhost:3030/graphiql

@stunjiturner See if it works with latest Reaction, 1.13.0. Make sure your .env file has everything that .env.example has. If it still isn't working, can you post the exact error message?

its working well, this ecommerce framework is about to get mighty.


Facedetector model documentation

I'm trying to use the facedetector model (facedetector_front.tflite) directly, but there is no documentation on the output of the model. A description of the output would be greatly appreciated.

@fanzhanggoogle Can you include the facedetector model input and output details into https://github.com/google/mediapipe/blob/master/mediapipe/docs/face_detection_android_gpu.md
and https://github.com/google/mediapipe/blob/master/mediapipe/models/README.md

@yousifa We don't recommend using the facedetector_front.tflite model directly without the preprocessing and postprocessing calculators that the MediaPipe Android Face detection on GPU example demonstrates.
To understand better the details of the facedetector_front.tflite model architecture, i recommend reading the publication that the model is based on. You can also examine the code of the TfLiteTensorsToDetections calculator to better understand how to process the outputs of the facedetector_front.tflite model

Closing this issue since there hasn't been any follow up from @yousifa

I'm trying to use the facedetector model (facedetector_front.tflite) directly, but there is no documentation on the output of the model. A description of the output would be greatly appreciated.

I font this file has been removed, can you send me a copy, my email addr is<EMAIL_ADDRESS>

I'm trying to use the facedetector model (facedetector_front.tflite) directly, but there is no documentation on the output of the model. A description of the output would be greatly appreciated.

I tried to inference BlazeFace model directly, and this is python demo code. It is a simple demo. There are many shortcomings to be improved.

The post-processing spend a lot of time, I think it was caused by python code, maybe you can use Numba to optimize it.
And I use original NMS method instead paper's method. If you want better performance. You can implement paper's method.

I tried the tflit file too. it only output the extracted feature. thanks for your demo. i will try it soon
发自我的 iPhone

在 2019年9月11日，15:38，ogl4jo3<EMAIL_ADDRESS>写道：
I'm trying to use the facedetector model (facedetector_front.tflite) directly, but there is no documentation on the output of the model. A description of the output would be greatly appreciated.
I tried to inference BlazeFace model directly, and this is python demo code. It is a simple demo. There are many shortcomings to be improved.
The post-processing spend a lot of time, I think it was caused by python code, maybe you can use Numba to optimize it.
And I use original NMS method instead paper's method. If you want better performance. You can implement paper's method.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@ogl4jo3 Thank you for sharing. I did a small change to the script, instead of decoding all boxes and then filter results by score, first filter results and then decode only relevant boxes, on my laptop it reduced post-processing time from ~50ms to ~10ms
Here is the gist

I'm trying to use the facedetector model (facedetector_front.tflite) directly, but there is no documentation on the output of the model. A description of the output would be greatly appreciated.

I tried to inference BlazeFace model directly, and this is python demo code. It is a simple demo. There are many shortcomings to be improved.

The post-processing spend a lot of time, I think it was caused by python code, maybe you can use Numba to optimize it.
And I use original NMS method instead paper's method. If you want better performance, you can implement paper's method.

Thank you for sharing.  I run the  python demo code,but  get Wrong detection box.   I don't know where is the problem.


Some issue about validation

Hi, Wentao
I'm trying to run your code and I got some issues.
I've followed the instructions in readme and finish 10 fold of detector training.
After that, I try to run frocwrtdetpepchluna16.py to get validation result of each epochs but I got some problem here.
And then I check previous issue to get some clue and still kinda confused.
This is what i think I should do:

After training, I got 150 ckpt and val result (pbb, lbb) for each fold
Generate the csv file for each validation result for each fold by running frocwrtdetpepchluna16.py
Pick best from 150 validation result for each fold and concatenate the csv (predanno-1d3.csv or predanno-1.5d3.csv I guess)
run noduleCADEvaluationLUNA16.py with concatenated prediction csv to get final result

And now, I've done the step1 and been able to run frocwrtdetpepchluna16.py
I know that I should uncomment line 144 to get the prediction csv for each epoch in one fold
and I can run the frocwrtdetpepchluna16.py with annotation csv provided by LUNA Like this
fold = 1
annotations_filename = "/data/home/hwc/md/luna/DeepLung/evaluationScript/annotations/annotations.csv"# path for ground truth annotations for the fold
annotations_excluded_filename = "/data/home/hwc/md/luna/DeepLung/evaluationScript/annotations/annotations_excluded.csv"# path for excluded annotations for the fold
seriesuids_filename = "/data/home/hwc/md/luna/DeepLung/evaluationScript/annotations/seriesuids.csv"# path for seriesuid for the fold
results_path = "/data/home/hwc/md/luna/DeepLung/detector/results/res18/retrft96"+str(fold)+"/val"#val' #val' ft96'+'/val'#
sideinfopath = '/data/home/hwc/md/luna/data/processed/subset'+str(fold)+'/' # +str(fold)
datapath = '/data/home/hwc/md/luna/data/raw/subset'+str(fold)+'/'

but I noticed your reply in https://github.com/wentaozhu/DeepLung/issues/42#issuecomment-435445688 and ,You mentioned that

For each fold, you need to use the fold's annotation to run the frocwrtdetpepchluna16.py

I think that's where I get stucked, where do i get the fold's annotation ?

I write a script to split to original annotation.csv into 10 sub_annotations.csv.
each sub_annotations.csv only contains nodule annotation of 1 fold.
then I fill it into annotations_filename and this is what I get from fold 1,
...
/data/home/hwc/md/luna/DeepLung/detector/results/res18/retrft961/val75/predanno-1.5d3.csv
/data/home/hwc/md/luna/DeepLung/detector/results/res18/retrft961/val75/predanno-1d3.csv
[0.8973214285714286, 0.890625]
ep 75 detp -1.5 0.897321428571
ep 75 detp -1 0.890625
/data/home/hwc/md/luna/DeepLung/detector/results/res18/retrft961/val76/predanno-1.5d3.csv
/data/home/hwc/md/luna/DeepLung/detector/results/res18/retrft961/val76/predanno-1d3.csv
[0.8828125, 0.8828125]
ep 76 detp -1.5 0.8828125
ep 76 detp -1 0.8828125
...

does this mean that it run correctly?

3. Pick best from 150 validation result for each fold and concatenate the csv

Hello @hwcasus, hope you are well. Could you kindly elaborate on this, why do we need to pick the 150 best results? and do you mean pick 150 from each fold, or from each scan?
Looking forward to hearing back from you :)

pick 150 for each fold. It is standard cross validation.

Hello @wentaozhu, I hope you're well.
I am running the training script using Python 3.5 (and LUNA-16 dataset) and have been trying to reproduce the results from the paper, for some reason, the model is producing a very high number of bounding boxes predictions per scan (~1 million or more sometimes). Have you come across this issue before? I am not sure why this is happening. Obviously, this also is slowing the evaluation drastically (non-maximum suppression becomes extremely slow and takes hours, I couldn't finish it testing because of that.).
Could this be the difference in python versions (although I have checked the code for inconsistencies between python 2 and 3, namely, I have checked all division lines in all scripts to make sure they are consistent).
Another thing I have noticed is the use of testthresh=-3 in train_detector_se.py, which I can't quite understand it clearly, it seems to me that it's being used for producing a mask...!
I have been working on this for a good while now, so I would really appreciate any advice or assistance :) Many thanks in advance :)


adding missing dependencies to shelley-spec-ledger-test

Adding missing dependencies to shelley-spec-ledger-test and also sorting the dependency list.

Tested locally. That is the magic that was needed.

great! I made #1503 so we don't do this again...


add swiftformat config files

motivation: help contributors follow formatting conventions
changes: add swiftformat file that can be used before submitting PR

@swift-ci please test


Add travisci support,code coverage

Various build process enhancement
* add travisci support
* run code coverage post reuslt to coverall.io
* add project info for hex package

Thanks! I just enabled Travis CI for this repository.
Could you squash these commits a bit and re-push your branch so we can make sure the build passes?

Thanks!


Design a Simple Card Using CSS

Pull Request Type
What kind of change does this PR introduce?
[1] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Design a Simple Card Using CSS(Fork, Commit, Merge - Medium Issue 1 (CSS))
Issue Number: [1271]
What is the new behavior?

Design a Simple Card Using CSS(Fork, Commit, Merge - Medium Issue 1 (CSS))
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Add compatibility for remote config files

TLDR; ./vendor/bin/pint --config https://raw.githubusercontent.com/laravel/pint/main/pint.json
The issue
I manage a lot of Laravel projects, and i want my codestyle to be consistent between all apps, but i don't want yet another package to manage.
The solution
Making it possible to allow for remote pint.json files and add this pint command to the composer scripts
{
    "pint": [
        "@php vendor/bin/pint --config https://raw.githubusercontent.com/laravel/pint/main/pint.json"
    ],
}

This way i can easily manage a single pint.json file, on a remote like Github without having to manage a self-created package.
Techy
When i was scanning the source code of Pint, i saw that this was almost already possible, Pint does a. file_get_contents to load the pint.json config file, which also works with remote files. The only obstacle i came across was the file_exists which only works for local files.
At the moment i have a proof of concept version of this working, but I was wondering if the community also feels that this is a nice addition to the pint package, and if the maintainers are open to these kind of improvements.
Let me know what u think, I might open a PR (only if the maintainers are open to it)

Heya, this sounds interesting. Feel free to attempt a PR if you like!


Style Error Rescue pane.

@abe33
Should work with all three types of colour schemes.
Before:

After:

@abe33 Thanks. I wasn’t sure if it’s maximum contrast, or would this be enough? We can just remove background colour and put a white border around – what do you think?
Also, will you integrate this PR with your branch, or do I have to do anything else? I don’t think I’m supposed to merge it.

Oops, I also got confused about the [i] icon. I should’ve left it as [?]. Will update in a future PR.

Ugh. I am not sure if VS Code is doing the right thing here. The contrast of text is slightly higher than in our solution, but it is so busy! I cannot imagine this is easy to parse by the eyes – it might be exchanging one problem for another. :·/ Let me think of this a bit.
The good thing is our situation is so predicable (old = top line, new = bottom line) that the placement already is solving a challenge here.
I’ll merge this PR right now, and I’ll send another tiny one with the last batch of changes later today. Might be easier to keep track of things this way.


Feedback on draft Zcon4 presentation

Edit by @nathan-at-least: This comment refers to Zcon4 TFL Workshop slides; (mutable doc link; may be out of sync w/ comments)
Suggested Improvements
On slide 7:

New Consensus Rule
Ⓐ: Do not finalize the next block unless the suffix is ≥ K blocks.

What does it mean to have a consensus rule referring to the finalization point? That isn't a property of a block that is being tested for consensus compatibility. Consensus has to be tested for blocks that are not yet final. When the block becomes final, it is already in the chain so by definition satisfies consensus.
You obviously can, and for any trailing finality protocol must, have a rule that says where the finalization point is, but that isn't and can't be a consensus rule.
Similarly,

"No final block may be rolled back." can't be a consensus rule, because consensus rules are not about the dynamic state of the chain tip. If a chain satisfies consensus then so do all chains that are prefixes of it. "No final block may be rolled back" is a modification of the meta-rule specifying how the "best valid block chain" evolves (see section 3.3 of the spec, and notice that it isn't referred to as a consensus rule there).
"Every final block immediately succeeds a final block with at most 1 successor." can't be a consensus rule for the same reason as the rule on slide 7.

If you want a name for a single category of rules that would cover these, I suggest calling them "chain evolution rules". (My first thought was to call them "finalization rules", but that doesn't quite work, since they constrain how a full validator's view of the chain tip changes, as well as which blocks it sees as finalized.)
It may also be worth pointing out what the existing chain evolution rules are:

"In order to choose the best valid block chain in its view of the overall block tree, a node sums the work, as defined in § 7.7.5 ‘Definition of Work’, of all blocks in each valid block chain, and considers the valid block chain with greatest total work to be best."
"A full validator MAY impose a limit on the number of blocks it will “roll back” when switching from one best valid
block chain to another that is not a descendent. For zcashd and zebra this limit is 100 blocks."

Every final block immediately succeeds a final block with at most 1 successor.

There's a trivial bug that this doesn't hold for the genesis block.
More significantly, this is a security property, not a chain evolution rule. Chain evolution rules can only be based on what a given full validator sees. Different full validators will therefore see different final blocks. This is normal in the case where those blocks are all on the same linear chain, i.e. it is just that the validators are updating their view at different times. But an adversary with a large enough stake can break the security assumptions of the finalization layer.
If a full validator detects that there are two potential candidates for the next finalized block (because the security assumptions have been broken), the chain evolution rule needs to explicitly say what happens. In Ethereum this is called "finality reversion". As discussed here, an Ethereum client following the fork-choice rule will only roll back a finalized block with manual intervention:
    # Check block is a descendant of the finalized block
    assert (
        get_ancestor(store, signing_root(block), store.blocks[store.finalized_checkpoint.root].slot) ==
        store.finalized_checkpoint.root
    )

Since this is an assertion, the client will crash in this case and need manual intervention to put it back on the correct chain. This is similar to the behaviour of zcashd and zebra on an attempted 100-block rollback. The point is that "Every final block immediately succeeds a final block with at most 1 successor." is not a sufficient specification of what a validator should do if this case is detected.
As I argued in this post, there are good reasons to explicitly model "finalization overrides". The accounting for the conceptual and implementation complexity costs of allowing finalized blocks to be rolled back is then shared between finalization overrides, and finality reversion. In fact you can potentially simplify things by saying that a detected finality reversion always requires a finalization override.

Then why place PoS accounting rules (roster, voting weights, reward/slashing, delegation, etc…) in Main Node rather than the new separate PoS Finality Oracle?
Answer: tight coupling with other ledger / transaction rules

PoS accounting rules are naturally transaction scoped as are most ledger rules.
Tracking this in the Finality Widget would require complex and stateful messaging between it and Full Node.

There's another reason (which is a showstopper for putting those rules in the Finality Oracle). The PoS accounting rules may need to be implemented in consensus rules. The Finality Oracle can't affect consensus because it doesn't have enough information: new PoW blocks are proposed to it, but those blocks must already satisfy consensus.

With this design approach, our previously simple new consensus rules for implementing trailing finality (Ⓐ, Ⓑ, and Ⓒ) are now extended with new rules necessary for PoS accounting.

"With this design approach, in addition to our new chain evolution rules for implementing trailing finality (Ⓐ, Ⓑ, and Ⓒ), we also have new or changed consensus rules necessary for PoS accounting."

This is all helpful feedback. I think the next improvement is to clarify some categories of rules and use consistent terminology for it. I will review the existing spec to hunt for this terminology. Before I do, here's my mental model:
Current Categories

Given two valid chains, select one as the best consensus candidate. (Aka "fork choice rule")
context-free transaction- and block-scoped rules (examples: "is the signature valid", "do the transparent values add up", "is the PoW solution valid")
contextual transaction-scoped rules: "is this transaction valid in the context of a selected valid chain and some dependency transactions that are unmined?"
contextual block-scoped rules: "is this block valid given a validated prefix?"

Do we call 1 "fork choice rule" and 2 "consensus rules"? (Hunting through the spec…)
Proposed TFL Categories
For TFL I believe we can keep the same categories, but category 1 has an important change, because it must provide the guarantee that "final blocks may not be rolled back". This implies that the finality gadget can halt with an error. Let me try to specify those clauses in more detail.
Let me try to frame the change with "pseudo types". In pure PoW the choice rule has a pseudotype like this:
fn select_pow(a: [Block], b: [Block]) -> [Block]
It selects between two choices of (contextually-valid) block sequences without fail.
But for TFL (or Ebb-and-Flow or Ebb-and-Flow-with-Bounded-Gap), the pseudo type now looks like this (pseudo-rust):
struct BlockChain {
  prefix: [Block],
  suffix: [Block],
}

fn select_tfl(a: BlockChain, b: BlockChain) -> Result<BlockChain, HALT>

The two changes to pseudo-type signature:

the context has both a final prefix and a dynamic suffix (both of contextually valid blocks)
this can result in a successful choice OR a loud error where the finality gadget halts.

With this new type signature in mind, the fork choice rule clauses are something like this:

if the common sub-prefix of a.prefix and b.prefix is neither a.prefix nor b.prefix, then there are conflicting final blocks at the same height, so exit with HALT.
otherwise, set the new prefix to the longer of the two prefixes. (If they are equal length, they are equal prefixes.)
select the longest dynamic suffix using the pre-existing (NU5) PoW fork-choice rules which also extends the newly selected suffix.

The "which also" clause in the last bullet should prevent rollbacks of final blocks, and given that constraint, selects the longest-pow suffix. This handles two cases:

both suffixes extend the most recent final block, so select between them as per vanilla PoW fork choice.
one suffix would roll back a final block because it has a different block at that height, therefore the other suffix must be selected.

I believe all the other categories of rules (2-4) are unaffected by TFL: contextless validation is the same, and contextual validation can treat the prefix and suffix as a single contiguous sequence of (previously contextually validated) blocks so long as they are the result of a previous select_tfl operation. (Is this true?)

In the slides I will use "fork choice rule" for category 1 and "chain validity rules" to encompass 4 (which implies 2 & 3), and just avoid "consensus rules" except when I mean an even bigger category that includes all of that and maybe other stuff. ;-)

Ok, I'm running out of time for the presentation tweaks, but I want to summarize changes I made from this feedback:
Rule Categorization
I stopped using "consensus rules" (except maybe in very general contexts). For the summary of all rules I simply say "new rules". I use three category names: "chain validation", "fork choice", and "default/norm".
Here's a slide of new rules (excluding PoS accounting) and how it categorizes new rules:

So it uses two categories "chain validation" and "fork choice". The heuristic in Ⓑ isn't categorized and I'm not sure how to categorize this.
It's a "default / norm" that isn't verifiable, but may be helpful to security / efficiency. This category of "norms / defaults" can be very useful as long as there aren't incentives flaws or other flaws that can overwhelm / degrade the norm.
Clarification of Finality Gadget impact
@daira's feedback on why we introduce PoS accounting rules in Main Node helped me realize and clarify the scope of the Finality Gadget:

the Finality Gadget can only influence fork choice behavior, not txn/block validity.

This seems like an important constraint that helps in reasoning about the design and security implications.
Bounding the max suffix length
@daira separately wrote up an argument to advocate for bounding the suffix length. I mention this as one of the interactive workshop topics (with attribution for the idea). This is a set of topics I intend to poll the audience on to see what we want to drill in on as a group.

The presentation is complete and incorporated this feedback as well as possible given the schedule.


[KBM Bug Bash] Set focus to Original Key when remapping keys

Steps to reproduce
Open Remap Key
Press the Plus button
Expected behavior
That focus would default to Original Key list
So I could enter the key ... like A
Actual behavior
Nothing happens since focus is not on list
Have to manually set focus on Original Key list

Focus goes to the type which would be expected


False wrong indentation acusation

When using .sass syntax, Linter is acusing the third line below to be in the wrong indentation .
.carousel-control
  .glyphicon
    font-size: 50px
    top: 50%
    position: absolute

sass-lint I Warning I indentation I Indentation of 0, expected 2 at line 3 col 1 in sass\style.sass
I doesn´t matter if i use tab or spaces.
Help?

https://github.com/sasstools/sass-lint/issues/611

Closing as a duplicate, thanks!


Bootstrap error rendering

Please, modify form errors rendering to Bootstrap's .alert-danger divs. Now form errors are unstyled.
Thanks!

Shouldn't it be done by has-error & help-block classes?

Yes, for errors in particular fields, but not for global error messages. Both should be fine to implement, so one could render the form just with {control myForm}.

What's the status of this?
@medhi Could you send PR?

Since @medhi didn't send it, I created it #37 - could you have a look?


Update babel config

Based on conversations in #2, https://github.com/rollup/rollup-plugin-babel/issues/72#issuecomment-238179853, and https://github.com/rollup/babel-preset-es2015-rollup/issues/11#issuecomment-238709022, this PR replaces babel-preset-es2015-rollup with babel-preset-es2015 and adds babel-plugin-external-helpers to the babel config.

thanks! 👍


Upmerge v1.5 to v1.6 20220113

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

Issue reference

Closing in favor of https://github.com/dapr/docs/pull/2106


favicon.ico

leian ise mingi jupi visuaalide seast
https://drive.google.com/drive/folders/1ICz7BSSMvue-26OlBwkhzgoon8oY6J4D

How 'bout this fragment


Update job.md

Add new line to fix #29840

Please sign the CLA for this PR to be reviewed, more information here https://github.com/kubernetes/website/pull/29844#issuecomment-929055145

And your commit message
Update job.md
Add new line to fix #29840

contains hashtag(#), but

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

So you have to remove hashtag(#) in your commit message. 😊

@jihoon-seo Thanks for your guide. I fixed the commit message and done the CLA.

👋 @yedamao . Thanks for contributing.
This issue has been fixed in PR #29880. I plan to close this pull request.
/close


Bulk select in Admin - Improvements

Right now, the "select" option at the right of the admin list has no purpose (http://aashe-hub-dev.herokuapp.com/admin/content/contenttype/?o=6). It would be useful to incorporate the "bulk select" so that it worked properly.
Also would be useful to have a "delete selected" and an "unpublish selected" option at the bottom.

Are there any other ways the bulk select feature could be useful?

Currently working on this ticket and have successfully added batch update features to publish, unpublish (marks the item as "new" again), and decline.
Is it ok if these actions don't trigger the email notifications I see elsewhere? If those need to happen I can find a way, but otherwise I can move on to the column sorting part.

I don't think we need to send a new email to the submitter when we change from published to unpublished. That would probably be confusing. Just emails for initial changes from new to published and new to unpublished (when saved)

That's what I was thinking. Ok I'll add in methods to trigger notifications in those cases.

Test cases added


Budget-hotel flavor

You should also mention this in the README as suggested by @jonas054.

ping :-)

pong
On 2/27/16, Bozhidar Batsov<EMAIL_ADDRESS>wrote:

ping :-)

Reply to this email directly or view it on GitHub:
https://github.com/bbatsov/rubocop/pull/2882#issuecomment-189608729

Hi @bbatsov. Personally, I don't agree that this should be mentioned in the README. My view is that formatters, etc. are "supposed" to be plain arrays, but this patch is just making RC more tolerant of non-standard input. (Something like the way web browsers accept invalid HTML and use heuristics to fix up the DOM internally.)

Stuck another bug fix in.

Fair enough. All new changes look good. :+1:


Improve touch event interaction with discrete zoom

@jbeezley could you please look into this sometime soon?

Resolved by #467.


MGMT: Jürgenize registered service properties (WIP)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: mmoayyed:x: tsschmidtYou have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.2%) to 45.22% when pulling bf7a9f9ea230054e9b131b1b2f9d588049ecf524 on Unicon:mgmt-properties into e1cd81aed972a63d4dceded9610f2fd566e16259 on apereo:master.

Coverage decreased (-0.1%) to 45.499% when pulling b2bac8dc0f8cd536a357b409f6af1c09d3c4cc3e on Unicon:mgmt-properties into 09b2d1b84602004625438c273f3f91a5fd732eef on apereo:master.


Cannot run doctr with Docker

🐛 Bug
I cannot build the doctr Docker image. I get an error (see attached video) when the requirements are being installed.
To Reproduce
Steps to reproduce the behaviour:

Build the Docker image

Profit!

Expected behavior
Being able to use doctr with the Dockerfile provided
Environment
OS: Mac OSX 11.5.2 on a M1 chip (it shouldn't change anything since the pip install runs inside the container)
Docker: 20.10.8, build 3967b7
https://user-images.githubusercontent.com/1170989/133692402-e949aa2f-6338-4d30-a2df-85accb62ccdb.mp4
d

Hi @fharper,
Thanks for reporting this!
To make sure I get the root problem correctly here, can you confirm that you are able to install DocTR outside of Docker with the same setup?
While it's true your setup is generally not the limiting factor for OS compatibility via Docker, there are cases, I  have personally experienced, where it's not possible (trying to build an image for an ARM chip while yours isn't). So my guess is that the base installation outside of Docker isn't working because you would need the ARM wheels for all dependencies.
If that's the case, I'll investigate this in #430 shortly!

You are right, I cannot even install the requirements on my M1 MacBook. I'll create another issue for it as #430 is focussing on arm for low powered devices, while the M1 processor is arm64: AFAIK, it will be two different built, and does not need the same requirements/versions.

Let's first address #480, I'm rather confident that if it gets fixed, then resolving this issue will be casual :)

Hi @fharper can we close this ? :)

Closing this as #480 is the root cause :+1:


Exception when deploying chaincode

Hi, I would like to try FabricSharp. I compiled the peer image and orderer image. When I deploying the custom chaincode provided in Readme before invoking the chaincode function, an exception occured in peer nodes . Would you please help me to take a look? Thank you
Branch: sigmod20
Orderer Log:
2021-01-24 09:36:59.688 UTC [orderer/consensus/kafka] setupProducerForChannel -> INFO 01b [channel: newchaincode] Setting up the producer for this channel...
2021-01-24 09:36:59.690 UTC [orderer/consensus/kafka] startThread -> INFO 01c [channel: newchaincode] Producer set up successfully
2021-01-24 09:36:59.690 UTC [orderer/consensus/kafka] sendConnectMessage -> INFO 01d [channel: newchaincode] About to post the CONNECT message...
2021-01-24 09:36:59.692 UTC [orderer/consensus/kafka] startThread -> INFO 01e [channel: newchaincode] CONNECT message posted successfully
2021-01-24 09:36:59.692 UTC [orderer/consensus/kafka] setupParentConsumerForChannel -> INFO 01f [channel: newchaincode] Setting up the parent consumer for this channel...
2021-01-24 09:36:59.693 UTC [orderer/consensus/kafka] startThread -> INFO 020 [channel: newchaincode] Parent consumer set up successfully
2021-01-24 09:36:59.693 UTC [orderer/consensus/kafka] setupChannelConsumerForChannel -> INFO 021 [channel: newchaincode] Setting up the channel consumer for this channel (start offset: -2)...
2021-01-24 09:36:59.695 UTC [orderer/consensus/kafka] startThread -> INFO 022 [channel: newchaincode] Channel consumer set up successfully
2021-01-24 09:36:59.696 UTC [orderer/consensus/kafka] startThread -> INFO 023 [channel: newchaincode] Start phase completed successfully
2021-01-24 09:37:07.492 UTC [orderer/common/blockcutter] scheduleMsg -> INFO 024 Process msg 41cbecf6: snapshot=0, committed=1, readKeys=[newchaincode], writeKeys=[newchaincode]
2021-01-24 09:37:07.492 UTC [orderer/common/blockcutter/scheduler] func1 -> INFO 025 Action: Schedule Txn, Process Txn: 47 us

Peer Log:
2021-01-24 09:37:37.497 UTC [blocksProvider] DeliverBlocks -> INFO 045 Verifying Block 1 in 1 ms
2021-01-24 09:37:37.498 UTC [endorser] deliverPayloads -> INFO 046 Validate Block 1 0 ms
2021-01-24 09:37:37.498 UTC [gossip/privdata] StoreBlock -> INFO 047 [newchaincode] Received block [1] from buffer
2021-01-24 09:37:37.500 UTC [leveldbhelper] RetrieveLatestSnapshot -> INFO 048 Increment latest snapshot 0 to count &{1<PHONE_NUMBER>52}.
2021-01-24 09:37:37.500 UTC [leveldbhelper] ReleaseSnapshot -> INFO 049 Decrement snapshot 0 to count &{0<PHONE_NUMBER>52}. Latest Snapshot: 0
panic: Not supported...

goroutine 327 [running]:
github.com/hyperledger/fabric/core/ledger/kvledger/txmgmt/txmgr/snapshotbasedtxmgr.(*queryHelper).getStateMetadata(0xc422bb6840, 0xc422bb4568, 0x4, 0xc422bb4750, 0x9, 0x10, 0x108d7c0, 0x1)
	/opt/gopath/src/github.com/hyperledger/fabric/core/ledger/kvledger/txmgmt/txmgr/snapshotbasedtxmgr/helper.go:120 +0x39
github.com/hyperledger/fabric/core/ledger/kvledger/txmgmt/txmgr/snapshotbasedtxmgr.(*SnapshotBasedQueryExecutor).GetStateMetadata(0xc422bc43a0, 0xc422bb4568, 0x4, 0xc422bb4750, 0x9, 0xc4229fa700, 0x11e7480, 0xc42233ade8)
	/opt/gopath/src/github.com/hyperledger/fabric/core/ledger/kvledger/txmgmt/txmgr/snapshotbasedtxmgr/snapshotbased_query_executer.go:33 +0x56
github.com/hyperledger/fabric/core/common/validation/statebased.(*KeyLevelValidationParameterManagerImpl).GetValidationParameterForKey(0xc4229fb700, 0xc422bb4568, 0x4, 0x0, 0x0, 0xc422bb4750, 0x9, 0x1, 0x0, 0x0, ...)
	/opt/gopath/src/github.com/hyperledger/fabric/core/common/validation/statebased/vpmanagerimpl.go:314 +0x377
github.com/hyperledger/fabric/core/common/validation/statebased.(*policyChecker).checkSBAndCCEP(0xc42233b2a8, 0xc422bb4568, 0x4, 0x0, 0x0, 0xc422bb4750, 0x9, 0x1, 0x0, 0x1052620, ...)
	/opt/gopath/src/github.com/hyperledger/fabric/core/common/validation/statebased/validator_keylevel.go:61 +0xb4
github.com/hyperledger/fabric/core/common/validation/statebased.(*KeyLevelValidator).Validate(0xc422b83f90, 0xc422bb4568, 0x4, 0x1, 0x0, 0xc4205cb590, 0xe3, 0xf0, 0xc422bbc5a0, 0x1da, ...)
	/opt/gopath/src/github.com/hyperledger/fabric/core/common/validation/statebased/validator_keylevel.go:240 +0x54f
github.com/hyperledger/fabric/core/handlers/validation/builtin/v13.(*Validator).Validate(0xc422bc8000, 0xc4229fae80, 0xc422bb4568, 0x4, 0x0, 0x0, 0xc4222afb20, 0x17, 0x17, 0xc422bc4220, ...)
	/opt/gopath/src/github.com/hyperledger/fabric/core/handlers/validation/builtin/v13/validation_logic.go:164 +0x266
github.com/hyperledger/fabric/core/handlers/validation/builtin.(*DefaultValidation).Validate(0xc422bb6660, 0xc4229fae80, 0xc422bb4568, 0x4, 0x0, 0x0, 0xc422baedc0, 0x1, 0x1, 0xc4200a1d00, ...)
	/opt/gopath/src/github.com/hyperledger/fabric/core/handlers/validation/builtin/default_validation.go:68 +0x185
github.com/hyperledger/fabric/core/committer/txvalidator.(*PluginValidator).ValidateWithPlugin(0xc422517040, 0xc4222a6e80, 0x3, 0x3)
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/plugin_validator.go:99 +0x29f
github.com/hyperledger/fabric/core/committer/txvalidator.(*VsccValidatorImpl).VSCCValidateTxForCC(0xc4224b6d00, 0xc4222a6e80, 0xc422bb4568, 0x4)
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/vscc_validator.go:264 +0xc0
github.com/hyperledger/fabric/core/committer/txvalidator.(*VsccValidatorImpl).VSCCValidateTx(0xc4224b6d00, 0x0, 0xc4229faf40, 0xc422ba1600, 0xce3, 0xd80, 0xc4229fae80, 0x4, 0x60, 0x60)
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/vscc_validator.go:249 +0x1612
github.com/hyperledger/fabric/core/committer/txvalidator.(*TxValidator).validateTx(0xc42259c840, 0xc4201e3770, 0xc422b34780)
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/validator.go:359 +0xf48
github.com/hyperledger/fabric/core/committer/txvalidator.(*TxValidator).Validate.func1.1(0xc42259c840, 0xc4229fae80, 0xc422b34780, 0x0, 0xc422ba1600, 0xce3, 0xd80)
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/validator.go:158 +0xcb
created by github.com/hyperledger/fabric/core/committer/txvalidator.(*TxValidator).Validate.func1
	/opt/gopath/src/github.com/hyperledger/fabric/core/committer/txvalidator/validator.go:155 +0x109

Hi, thank you for your interest. I believe your deployment may involve some additional features, such as private data collection. These additional features are not relevant to the transaction processing in the paper. So the branch does not support it.

Hi, thank you for your interest. I believe your deployment may involve some additional features, such as private data collection. These additional features are not relevant to the transaction processing in the paper. So the branch does not support it.


Turn off legacy gh-pages site

We've moved our docs to velero.io but the legacy github pages site is still around. We should turn this off  once we're sure we've  gotten all of our links updated.

My first Google hit for "velero restic" is the github.io site...I wonder if it would be preferable to change the site to be permanent redirects for a short period of time.
Upside is that it gets the search engines updated and would redirect users who have old bookmarks.
Downside is leaving it active longer while it's not really maintained.

Another downside - it looks like there's not an easy way to just make pages redirects. Have to jump through the Jekyll hoops.

cc @jonasrosland

this is done.


Update contributing guide to reflect Node.js support

The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!!
This PR fixes that.
Related to #7022

/check-enforcer override


Bump react react-dom peerDependency to allow React v16

Small change to the package.json peerDependencies to allow React v16. This keeps the >=15.5 constraint as well so current users won't need to upgrade and shouldn't have any issues.
Looking through to code I don't see any changes that need to be made for the upgrade -- it's working locally on my codebase.

@CodyReichert please peek at #126 and then check out react-codemirror2. You'll most likely hear no feedback here.


Validate on edit vs save

Currently Monokle Validation runs on saving files as compared to saving. This takes away a small part of the real-time validation. Is there a possibility to do this on a debounced editing to give feedback earlier?

Should be doable with onDidChangeTextDocument (or something similar) from workspace namespace.

It should be configurable to validate onType or onSave as e.g. ESLint ext does:


KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation

This patch does a few things:

Refactors the TargetAssignmentBuilder to use inheritance to differentiate Consumer and Share groups.
Introduces UnionSet to lazily aggregate the subscriptions for a given member.
Wires the resolved regular expressions in the GroupMetadataManager. At the moment, they are only used when the target assignment is computed.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@lianetm Thanks for your comments. I just addressed them.


ViewBinding or Kotlin synthetics

Does this library support Kotlin synthetics or view binding in ViewHolder?

Yes that shouldn't be a problem, use kotlin-android-extensions, but afaik it's still experimental.

Yes that shouldn't be a problem, use kotlin-android-extensions, but afaik it's still experimental.

As far as I know, the view holder must be configured to cache the view, out of the box it does not work and each time use findViewById if we use itemView.'...'

Hmm well thats all taken care of with the org.jetbrains.kotlin.android.extensions that is auto generating these properties for all the different view controller types (Activity, Fragment, Dialog etc)
Important is to use RecyclerView.ViewHolder.itemView as the root view for the synthetic property resolving.
Pattern for synthetic property import is:
import kotlinx.android.synthetic.<variantName>.<layoutName>.view.<viewName>
Try out this:
Gradle
apply plugin: 'org.jetbrains.kotlin.android.extensions'
androidExtensions {
    experimental = true
}

ViewHolder
import kotlinx.android.synthetic.main.layoutName.view.title

class TitleViewHolder(parentView: ViewGroup) :
    SmartViewHolder<Model>(parentView, R.id.layoutName) {

    override fun bind(item: Model) {
        itemView.title.text = item.title
    }
}

I've included some synthetic imports in the sample app so i'm closing this issue for now :)


Wallet: Missing the activity log after restore wallet.

Describe the bug
Missing the activity log after restore wallet.
To Reproduce
Steps to reproduce the behavior:

Go to settings > advanced > dev settings > wipe wallet data
Go through the start screens and click on the restore wallet button.
Paste your seed and restore wallet
You balance will show up after refreshing the wallet, and the activity log is empty.

Expected behavior
The activity log should show up with your recent transactions.
Screenshots

Smartphone (please complete the following information):

OS: [Android]

I could not replicate this issue anymore. Will close this issue.


Error in _add_use

Running 793bd4420531ade18cb3b9c8b2eab5929461592f on my 64bit cygwin I get an error somewhere in the middle of a run (--verbose is active):
Processing ./PlatformSupport/numerictypeinfo.h
Traceback (most recent call last):
  File "/usr/bin/cppclean", line 145, in <module>
    sys.exit(main())
  File "/usr/bin/cppclean", line 138, in main
    quiet=args.quiet):
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 524, in run
    hunter.find_warnings()
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 119, in find_warnings
    self._find_header_warnings()
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 396, in _find_header_warnings
    self._find_unused_warnings(included_files, forward_declarations)
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 387, in _find_unused_warnings
    forward_declarations)
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 354, in _determine_uses
    _process_function_body(node, node.namespace)
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 323, in _process_function_body
    _add_use(t.name, namespace)
  File "/usr/lib/python2.7/site-packages/cpp/find_warnings.py", line 276, in _add_use
    name = file_use_node[1].filename
KeyError: 1

That seems to be the related code:
#ifndef NUMERICTYPEINFO_H
#define NUMERICTYPEINFO_H

#include <string>
#include <limits>

    namespace PlatformSupport {

        template <typename T>
        std::string PrintNumericTypeInfo(const char *pTypename)
        {
            if (std::numeric_limits<T>::is_integer)
            {
                if (std::numeric_limits<T>::is_signed)
                {
                    return ::extstl::toString("%s: MIN=%lld,MAX=%lld",
                        pTypename, (long long)std::numeric_limits<T>::min(), (long long)std::numeric_limits<T>::max());
                }
                else
                {
                    return ::extstl::toString("%s: MAX=%llu",
                        pTypename, (unsigned long long)std::numeric_limits<T>::max());
                }
            }
            else
            {
                return ::extstl::toString("%s: MIN=%Le,MAX=%Le,EPS=%Le",
                    pTypename, (long double)std::numeric_limits<T>::min(), (long double)std::numeric_limits<T>::max(), (long double)std::numeric_limits<T>::epsilon());
            }
        }

    }

#endif //NUMERICTYPEINFO_H

I can't seem to reproduce the stack trace.
$ cppclean --verbose numerictypeinfo.h
Processing numerictypeinfo.h
$ echo $?
0

I confirm... I was reducing the example too much. I get many failures on my code base :-(
I'll postpone that one and try to report more simple ones first.

I also got that same error. I tried to debug it and it seems that this error happens when CppClean  the first line of a function template defined inline which contains a using declaration.
Unfortunately I can't share the offending code. I'll try to reproduce bellow the structure of the code (with fake names) where the KeyError  is raised:
// First.h file:
#include "Second.h"  // The header which defines a class names 'Second' which will be used bellow

namespace a {
namespace b {

class First
{
    ...   // Other stuff

    template<class A, class B>
    static First findOrCreate( const char * name );
};

template<class A, class B>
First First::findOrCreate( const char * name )
{
    using second::Second;   // KeyError is raised when processing this line
    ...  // Other function body steps
}

}  // namespace b
}  // namespace a

The namespace second is bellow a::b (i.e. it's fully qualified name is ::a::b::second). Checking the stack trace shows _process_function_body() calling _add_use() with name='second' and namespace=['a', 'b'].
I'm running CppClean with Python 2.7.10.
I noticed the following comments on _process_function_body():

# TODO(nnorwitz): handle :: names.
# TODO(nnorwitz): handle using statements in function.

Could those be the cause for this error?
I'll try to see if I can build a smaller and complete code example which would trigger that KeyError. If I manage to do so, I'll post it here.

Now I also managed to extract a self-contained example which consists out of two headers, running cppclean CW.h
CW.h
#ifndef HEADER2
#define HEADER2

#include "C.h"

namespace MyNamespace
{
	namespace BRK
	{
        class CW : public CI
        {
			int cf()
            {
                return MyNamespace::BRK::CI::cf();
            }
        };
    }
}
#endif

C.h
#ifndef HEADER1
#define HEADER1
namespace MyNamespace
{
	namespace BRK
	{
		class CI
		{
        public:
			int cf();
		};
	}
}
#endif

Hi,
I made a fix for this problem. It's not perfect but it should at least fix the crash.
Can you try on your code to see if it's ok ?

I've tried this fix on my code and the KeyError persists.
The not t.name in namespace check had no effect as t.name='second' but namespace=['a', 'b']
Recall that the namespace second in my example is bellow a::b (i.e. it's fully qualified name is ::a::b::second). The function with the offending line using second::Second, however, is defined bellow a::b only (that's why the using declaration is needed).

My bad, I only look at the sample from amai2012, I didn't check the other samples. My fix only works for some simple and specific patterns. We will need something more complex to handle the other cases.

@r-e-d: No problem, I've commented on this issue just because I thought it could be the same problem. If needed, I can open a new issue for the example code I've posted. Just let me know if that would be better.

This time, my fix should handle the more general cases :)

This new fix solved the problem for me. Thanks! :+1:

I'll report further issues in another ticket, so close that one.


Add test for property type

Related to #1229

I used now AbstractTest.

@Shredder121 Good to merge?

Yes, will you backport this as well?
I'll merge it.


Add support for ambient capabilities

Allow setting ambient capabilities, as a seperate option to the standard
ones. If you are running as a non root user you should use these.
Note that unless you add CAP_DAC_OVERRIDE and similar permissions you
need to be careful about file ownership. Added support to set ownership
in the files section to help out with this.
Signed-off-by: Justin Cormack<EMAIL_ADDRESS>

See also https://github.com/linuxkit/linuxkit/issues/2136


Is infix priority of (!) correct?

I tired to expand the counter example to use program instead of beginnerProgram. I added empty command in update function, and got this error message. Is this a correct behavior?
-- TYPE MISMATCH ---------------------------------------------------------------

The right argument of (+) is causing a type mismatch.

25|       model + 1 ! []
                  ^^^^^^
(+) is expecting the right argument to be a:

    number

But the right argument is:

    ( number, Cmd a )

Hint: I always figure out the type of the left argument first and if it is
acceptable on its own, I assume it is "correct" in subsequent checks. So the
problem may actually be in how the left and right arguments interact.

I assumed model + 1 should be evaluated first.
But it's trivial anyway. Adding a pair of parens fixes it.

Judging from http://faq.elm-community.org/operators.html, I'd say it should have a declaration of:
infixl 1 !
to work with everything up to and including ||, but still be lower precedence than |>/<|.
You can declare this in your own code somewhere, which seems a bit off to me, but it works. That declaration would break as soon as (!) gets its own associativity/precedence declaration in core, though.

The current plan is to drop (!) but I agree that if it ends up in 0.19 it should have a very low precedence, possibly such that it'll work with (|>) chains.

Just note:
Some ideas for infix operator precedence (including !) - https://discourse.elm-lang.org/t/infix-operators-lower-precedence-than-and/1235


Getting a "precondition failed" error

My bot is throwing an exception, It is published already, I cannot replicate the error and I have no Idea why it is happening.
Precondition Failed
at Microsoft.Bot.Connector.ErrorHandling.HandleError[ObjectT](HttpOperationResponse1 result) at Microsoft.Bot.Connector.BotStateExtensions.d__9.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.ConnectorStore.d__3.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.CachingBotDataStore.d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.CachingBotDataStore.d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.BotDataBase1.d__9.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.PersistentDialogTask.d__61.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.PostUnhandledExceptionToUserTask.d__51.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.Bot.Builder.Dialogs.Internals.PostUnhandledExceptionToUserTask.d__51.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Conversation.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Conversation.d__2.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task) at TheMemebotV3.MessagesController.d__0.MoveNext()`
The request that caused this error is:
{"Properties":null,"Type":"message","Id":"4eswYGkzLapXSkmu","Timestamp":"\/Date(1474480550126)\/","ServiceUrl":"https://skype.botframework.com","ChannelId":"skype","From":{"Id":"29:1HfFfaW_8dCXP-oKg26IDPaNQbhlbthaMeSMhz3kUvJQ","Name":"vladstefansas || osu.ppy.sh/u/vladstefansas"},"Conversation":{"IsGroup":true,"Id":"19:9152b6ce8bb0467880517a14434dfcc4@thread.skype","Name":null},"Recipient":{"Id":"28:c0b2fa87-3625-43b2-be12-8eb1675818bb","Name":"MemeBot"},"TextFormat":null,"AttachmentLayout":null,"MembersAdded":null,"MembersRemoved":null,"TopicName":null,"HistoryDisclosed":null,"Locale":null,"Text":"ground squirrel meme","Summary":null,"Attachments":null,"Entities":[{"Type":"mention","Properties":[[[[[]]]],[[]]]}],"ChannelData":null,"Action":null,"ReplyToId":null}
However my Bot responds to the user and seems to work as expected, the error is captured by my log

https://docs.botframework.com/en-us/technical-faq/#what-is-an-etag--how-does-it-relate-to-bot-data-bag-storage
I don't see SerializingDialogTask in your call stack - are you using the latest NuGet?
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/DialogTask.cs#L420

I had the 3.1.0 version of botframework from nuget, I have updated, I am going to wait to see if the error goes away

Now it throws something else:
An error occurred while sending the request.
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Luis.LuisService.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Luis.Extensions.d__3.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.LuisDialog1.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.ThunkResume1.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Wait2.d__19.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Frame1.<Microsoft-Bot-Builder-Internals-Fibers-IFrameLoop-PollAsync>d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Fiber1.d__13.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Microsoft.Bot.Builder.Internals.Fibers.Wait2.Microsoft.Bot.Builder.Internals.Fibers.IAwaiter.GetResult() at Microsoft.Bot.Builder.Dialogs.Chain.LoopDialog1.d__3.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.ThunkResume1.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Wait2.d__19.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Frame1.<Microsoft-Bot-Builder-Internals-Fibers-IFrameLoop-PollAsync>d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Internals.Fibers.Fiber1.d__13.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.d__19.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.d__211.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.ReactiveDialogTask.d__51.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.ExceptionTranslationDialogTask.d__21.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.LocalizedDialogTask.d__21.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.ScoringDialogTask1.d__41.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.PersistentDialogTask.d__61.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.Bot.Builder.Dialogs.Internals.PersistentDialogTask.d__61.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.SerializingDialogTask.d__41.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Internals.PostUnhandledExceptionToUserTask.d__51.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.Bot.Builder.Dialogs.Internals.PostUnhandledExceptionToUserTask.d__51.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Conversation.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Bot.Builder.Dialogs.Conversation.d__2.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task) at TheMemebotV3.MessagesController.d__0.MoveNext()
with a request like this:
{"Properties":null,"Type":"message","Id":"13gZ2hkzMdM1Xfeq","Timestamp":"\/Date(1474847047705)\/","ServiceUrl":"https://skype.botframework.com","ChannelId":"skype","From":{"Id":"29:1zvSw96_JiWQT28mupz9r1YjJsIAa8WDDicOhV4OpovY","Name":"Reese"},"Conversation":{"IsGroup":null,"Id":"29:1zvSw96_JiWQT28mupz9r1YjJsIAa8WDDicOhV4OpovY","Name":null},"Recipient":{"Id":"28:c0b2fa87-3625-43b2-be12-8eb1675818bb","Name":"MemeBot"},"TextFormat":null,"AttachmentLayout":null,"MembersAdded":null,"MembersRemoved":null,"TopicName":null,"HistoryDisclosed":null,"Locale":null,"Text":"spongebob meme","Summary":null,"Attachments":null,"Entities":[],"ChannelData":null,"Action":null,"ReplyToId":null}

The call stack involves LuisService - are your subscription and model keys correct?
Do you have the type of the exception?  You might consider breaking on thrown exceptions to see what it is.

I'm going to close this issue due to lack of response - feel free to open a new issue for further discussion.


After importing Configuration Package and Applying it, Restart Docker is needed

Describe the bug
After importing Configuration Package and Applying it, Restart Docker is needed.
We import the W1 Extended Cronus data in other country specific builds.
But running our units tests without first restarting the Docker container, will result in CRL exceptions.
To Reproduce
1 - Use the build-in pre configured Extended configuration package
OR
1 - Spin up a W1 and a country like DEU.
Take the NAV14.0.W1.ENU.EXTENDED.rapidstart from W1 container and import it in DEU.
2 -
Do NOT stop and start the docker container.
Use the Test Tool to run an extended amount of tests in one-go.
Expected behavior
No Crash
Versions:

AL Langauge: 3.0.106655
Business Central: Version: Platform 14.0.29530.31247 + Application 31313 (W1 Dynamics NAV 14.0)

Nevermind Powershell; I have a similar problem when attempting to Apply Predefined Configuration Packages using the GUI actions from the Web Client "Configuration Packages" Page. The Web Client Crashes every single time; no matter the Configuration Package, and no matter how I try different sequences of steps. When I click "Apply", after a few seconds, the Client crashes.
Also, Interestingly, the "EVAL" and "EXTENDED" Packages will "Validate" with the "Validate Package" Action; but the "STANDARD" Package CONSISTENTLY Crashes the Web Client during the "Validation" Process (from the "Package Card"). But they ALL fail the "Apply" step, with or without Evaluation first.
This just started happening a couple of weeks ago, when I updated my On-Prem BC Sandbox environment (US version) and AL VSC "Extension". With the previous version, I had no problems Importing and Applying the packages listed below.
These are the Configuration Packages I have been trying. I have tried every combination, in every order, singly, and in combination, all with the same result:
Code                                  Product Version
US.ENU.EVALUATION        NAV14.0
US.ENU.EXTENDED            NAV14.0
US.ENU.STANDARD           NAV14.0
Here is my AL Language Version:
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 3.0.121490
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


Do client side search with any length of query

Instead of only starting the search after 3 characters have been typed.

Would say "should we do it with 2 or more characters" rather than zero or more? What do you think? Does this affect performance?

I don't think the difference between searching after 1 character and searching after 2 characters will make a big performance difference. That said, I have no numbers to back that up.
The backend certainly doesn't suffer for being queried with 1 character. It may cause the client side rendering to have to do a bit more work. It seems nice to have a consistent behaviour between client side auto searching and the submitted server rendered behaviour.

Well ok then :)


Sign In with Google

There is no Sign in with Google in the login page, I would like to contribute to this project under GSSOC. @vermaanurag1532 kindly allow me to contribute to the issue.

@vermaanurag1532  please assign me this issue would love to work on it.

@vermaanurag1532 Assign me for gssoc'23 I would love to work on it and can fix it quickly.


adding force-ssl-redirect command to crd

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

231 of 282 (81.91%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 80.945%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controller/nginxingress/nginx_ingress_controller.go
11
12
91.67%

pkg/controller/keyvault/ingress_secret_provider_class.go
17
20
85.0%

pkg/controller/controller.go
0
4
0.0%

pkg/controller/keyvault/kv_util.go
78
84
92.86%

pkg/controller/keyvault/placeholder_pod.go
50
58
86.21%

api/v1alpha1/zz_generated.deepcopy.go
1
10
10.0%

pkg/controller/keyvault/nginx_secret_provider_class.go
67
87
77.01%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller/keyvault/ingress_secret_provider_class.go
1
75.53%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
2689

Relevant Lines:
3322

💛  - Coveralls

/ok-to-test sha=4c55ce4

/ok-to-test sha=0b3bedb


Fixed issue with Lambda invoke via ARN

Fixed an issue where Lambda invokes via an ARN was hitting real AWS.

Coverage decreased (-0.2%) to 93.996% when pulling 1bae356f0b52a97ae38c0b9606c2b500de51cd77 on mikegrima:lambda_arn_invoke into 152ad8b82e673eea472922e1e4a78cca3c6e504f on spulec:master.

Related to #2668 , which has similar the same fix for more Lambda actions, but is lacking tests


Turn off and limit telemetry completely or only for MS apps?

Hi!
I'm currently having a case were the standard BC base application is flooding the event viewer from table 36 "Sales Header"

I would like to inactivate these and I ended up here.
What I'm missing in this text is a clarification if I limit/turn off these it will also limit the telemetry events from our own and partner apps.
If it does this I want to you to add a warning note that those will also be disabled.
In my scenario a not so great solution could be to disable/limit the MS telemetry events from the base apps but keep them on other.
Then we also have this "Custom telemetry trace events have IDs from 700-712."
This is a missmatch with other documentation. How do I know from looking in the BC code which ID an custom telemetry trace event will trigger? If I look at the documentation from custom telemetry events those ID:s arent specified
https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/session/session-logmessage-string-string-verbosity-dataclassification-telemetryscope-dictionary[text,text]-method
However, I managed to find the list of id:s here. https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/session/session-sendtracetag-method
BUT this is deprecated function hence it should bemoved to the session.logmessag documentation.
You should also add links to the session.logmessage as further information

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e790d89e-14c0-79e2-756f-14248e820307
Version Independent ID: c5714730-02d0-da57-fc44-5e24f1bddc60
Content: Turn Off or Limit Telemetry Trace Events - Business Central
Content Source: dev-itpro/administration/disable-limit-telemetry-events.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: solsen

@SusanneWindfeldPedersen,@KennieNP, really?
I'm trying to help you to clarify the documentation plus update the new documentation since it doesn't contain information that does in the deprecated one.
When it comes to the answer @KennieNP , this is not about whats get collected in the application insights, its about what is sent from the server and clogging upp the event viewer on our OnPrem server.

Hi Marcus,
Sorry for misreading your comment for being related to telemetry.
As for blocking events sent to the event viewer, which version of the
platform are you on?
On Wed, 26 Apr 2023 at 18:35, Marcus Nordlund @.***>
wrote:

@SusanneWindfeldPedersen https://github.com/SusanneWindfeldPedersen,
@KennieNP https://github.com/KennieNP, really?
I'm trying to help you to clarify the documentation plus update the new
documentation since it doesn't contain information that does in the
deprecated one.
When it comes to the answer @KennieNP https://github.com/KennieNP ,
this is not about whats get collected in the application insights, its
about what is sent from the server and clogging upp the event viewer on our
OnPrem server.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/dynamics365smb-devitpro-pb/issues/2832#issuecomment-1523268957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXE6S5KQL6XPNNR4O3Y6ODXDEB65ANCNFSM6AAAAAAXFL6API
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

--

Kennie Nybo Pontoppidan
Email: @.***
Twitter: @KennieNP
www and cv: http://pontop.dk


Add commit count for repository

Description
Add changes needed to implement totalCommits field for repository type, as well as its resolvers and Github queries.
Fixes #67
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@jadsonluan done


Hyper AppImage cannot run snap packages

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Ubuntu 18.10
Hyper.app version: 2.0.0 stable
Link of a Gist with the contents of your .hyper.js:
Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue
On a new machine with Ubuntu 18.10. I installed hyper from the AppImage.
I already have several applications installed using snap, i.e. google-cloud-sdk and kubectl.
The snap applications, i.e. kubectl, work fine from gnome-terminal but are not working from Hyper. When running an application installed as a snap inside Hyper, I get the same output as if I had run the snap command (i.e. the default help message for snap).
Not sure if this is an issue with AppImage, snap, or hyper... starting here.

@codyzu Does the command echo $0 return the same result when you execute it in Hyper vs gnome-terminal?

Having the same issue on Ubuntu 18.04.2 with Hyper 3.0.2.


Adds generateText and generateOutput convenience methods.

This adds new generateText and generateOutput convenience methods that return like so:
const {text, response} = await generateText({prompt: "Tell me a joke"});

const {output, response} = await generateOutput({
  prompt: "Create a creature",
  output: {
    schema: z.object({
      name: z.string(),
      hitPoints: z.number()
    })
  }
});

It's a small ergonomic change but it prevents needing to assign the response to a variable if you don't care about it.
If you like the idea we can talk about how we'd want to document it vs. other options.

@mbleigh I saw you added these things to the 0.6 release doc. Did you want to submit this PR?


Update Dutch translation

In response to https://github.com/newsboat/newsboat/pull/2282#issuecomment-1347243150

Coverage remained the same at 59.648% when pulling c2e42bd99bdbf8ce139262a48d14d27e0e2cb6fe on dennisschagt:update-nl-translations into be755569058b862a540cdba996dac401b4a09ebd on newsboat:master.

Thank you!


Destination list after full refresh from netlogs

After a full refresh from the netlogs, the Destination list has the source list appended to it.
This leads to duplication of the lists.

Appears that the content of the Source combo dropdown is cleared then determined, and then appended to the Destination combo dropdown.
Fixed by clearing the destination before appending a clone of the source.

Issue resolved and merged to development


Fix IVY-982 by removing negated entries from wildcard bin

Issue
Configurations negation (exclusion) as in conf="*, !foo->@" does not work,
This issue is reported in IVY-982 and IVY-1547.
Why does it happen?
Resolve engine silently disrespects negation on the left part of maps-to operator because the exclusion was not implemented. When parsing dependency, e.g. conf="*, !foo → bar1; foo → bar2, bar3; % → bar4", all dependency configurations are collected into bins (map entries):

all-wildcard bin with all configurations required for * superset,
such as bar1 in bin *;
others-wildcard bin with all configurations required for % superset,
such as bar4 in bin %;
explicit bins for all explicit mappings,
such as bar2 and bar3 in bin foo, and bar1 in bin !foo.

Resolving list of dependency configurations required for some target configuration X is done as follows:

All configurations from X's explicit bin are added.
All configurations from others-wildcard bin are added in case X's explicit bin is empty.
All configurations from all-wildcard bin are added.

Note that explicit bins for negated target configurations are not referenced, and thus silently ignored. This fix introduces fourth step:

All configurations from !X's explicit bin are removed.

Sorting is a problem, in rootModuleConfs field of IvyNodeUsage by the looks of it.
        assertTrue(Arrays.asList("myconf1", "myconf2").containsAll(Arrays.asList(
                crp.getDependency(mod22).getConfigurations(crp.getConfiguration()))));

does the bill, not sure if that's good enough, though.

I replaced Arrays.equals() with List.containsAll(), as you suggested; thank you.

The disk is full again 😦Anyway, in case there is only one element, Collections.singletonList() is preferable.

Do you think overhead decrease achieved by using singletonList() outweighs breaking the pattern of List initialisations in test body? This is my second week with Java, these subtle differences are new to me.

singletonList() for single-element lists is the pattern used across Ivy tests. Thriftiness is a virtue, despite what people may say 😄

Thank you, the fix is in master now. Please rebase to verify and close the PR.


Request to cyrillic domain fails

Guzzle version(s) affected: 6.3.3
Description
Request to cyrillic domain fails.
How to reproduce
$httpClient = new \GuzzleHttp\Client();
$response = $httpClient->get('https://русские-домены.рф');
echo (string)$response->getBody();

Possible Solution
It fails due to Host header in GuzzleHttp\Psr7\Request::updateHostFromUri()
Header must be converted using idn_to_ascii() function.
Additional context
But it works using curl
$ch = curl_init('https://русские-домены.рф');
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
$html = curl_exec($ch);
curl_close($ch);
echo $html;

Nice catch.
Please, take a look at #2286, it should fix your issue.

Just dropping a few search keywords for better discoverability of this issue:

IDNA
punycode
International Domain Names
Umlaut


Feature/rb 92 function receive enemy death

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] Norm of the code has been respected

In what state is your pull request?

[x] Ready to merge / Waiting a reviwer to see my work.
[ ] Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
[ ] CI Review / I want to see what the CI thinks of my work.
[ ] Need feedback / Just to have feedback on what i produced. (May not be merged)

What kind of change does this PR introduce? (You can choose multiple)

[ ] Bug fix
[x] Feature request
[ ] New / Updated documentation
[ ] Testing CI ( Make the pull request in draft mode)

What is the current behavior? (link an issue based on the kind of change this pr introduce)

What is the new behavior (if this is a feature change)?

Other information:

actually not compiling, cause the bug @TTENSHII is actually fixing, Enemy component is copied, but it cannot be cause it have a const value


Moved allocateIterators config to new Collections class

Created a new Collections class to hold common configuration/utility methods for all collection classes. Moved allocationIterators from Array class to Collections.
I've made a getter/setter for the property, can change to public as it's not that great anyway.

I agree putting it on Array is a bit ugly. I wish there was a good place to put it other than to have a whole class for one boolean, but I don't have any better ideas. isAllocateIterators quite is an awkward getter name, getAllocateIterators would be better (being boolean doesn't require is!). However, I think I'd prefer it as just a public field named allocateIterators.

Fixed, replaced by getter/setter by public field. Hopefully there's some common functionality we can add to the new Collections class so that is has a better reason to exist


There should be an ID on returned trustlines ...

.. that consists of
md5(networkAddress, accountAddress)
Should this be done in the relay server?

The relay server does return the id now, so we can implement that in the clientlib


It is not tracking anything, it is just front camera is opened

Yes, I also met this problem, may I ask if you have solved this problem now.


address anonymous functions

(Here comes a bunch of PRs after a code fragments mass test with ESLint checks and Node.js runnings.)

Add function name if it can't be inferred from the context. See func-names.
Replace anonymous functions with arrow functions when appropriate. See prefer-arrow-callback.
Replace anonymous functions with method shorthand notation when appropriate. See object-shorthand.
Remove a redundant IIFE. Fixes #30 temporarily.

Rebase with master!

@ryanmcdermott Done.

Great! Thanks for fixing that Private Members issue too, that was a silly mistake on my part.


Evaluate and Add Orno.di

@philipobenito are you interested in contributing an adapter? If not, I'll eventually get around to it.

By the way unless I'm mistaken Orno.DI is now League\Container

Yup. Will change issue title.

league/container already supports container-interop as far as I know no?

v2 of league/container is container-interop yes


typo correction.

as per user report issue #6871 , so I corrected word part to park.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add support for shadow

According to http://www.w3.org/TR/2dcontext/#shadows:

Shadows are only drawn if the opacity component of the alpha component of the color of shadowColor is non-zero and either the shadowBlur is non-zero, or the shadowOffsetX is non-zero, or the shadowOffsetY is non-zero.

They also say:

When the context is created, the shadowColor attribute initially must be fully-transparent black.

I think the standards are a bit restrictive, so in my implementation just by setting the shadowBlur prop you can see an immediate result. You can then have the hint of tweaking the other attributes.
And the fact that the shadowColor is initially transparent, that's just weird.
What do you think?

Oh... I think I was wrong in first place. I shouldn't add a drawing condition at all.

@mjohnston Is this PR going to be merged? Or can we already make a shadow with react-canvas?


Allow extensions to modify the type of a file as used by 'extension.sortOrder'

I want to be able to sort files in the explorer using an attribute provided by an extension. I think the simplest way to achieve this would be via allowing extensions to modify the type of a file within the context of setting extension.sortOrder to type. This would be very helpful for large projects written in Go because of how Go expects tests to be structured.
For example, let's say I have a workspace with the following files:

.gitlab-ci.yml
a.go
a_test.go
b.go
b_test.go
go.mod
go.sum
README.md
x.go
x_test.go

If I set extension.sortOrder to type, this becomes:

a.go
a_test.go
b.go
b_test.go
x.go
x_test.go
README.md
go.mod
go.sum
.gitlab-ci.yml

This is better than purely alphabetical sorting, but as the number of files grows, browsing the project becomes increasingly unwieldy. I want to be able to create an extension that would allow me to sort in the following way:

a.go
b.go
x.go
a_test.go
b_test.go
x_test.go
README.md
go.mod
go.sum
.gitlab-ci.yml

If extensions could modify the sort type of a file, I could achieve this by changing the type of *_test.go from go to go_test.

I've looked and I couldn't find what this is a duplicate of. Would you please specify which existing issue this duplicates?

https://github.com/microsoft/vscode/issues/27286


FI-2688: Migrate to HL7 validator wrapper / Update to Inferno Core v0.4.37

PR generated by the publish_template script in inferno_core with the latest changes on main as of this morning. This now includes the HL7 validator wrapper enabled by default.

When I run bundle, the lockfile changes. We should commit those changes.

What changes are you seeing? Nothing changes for me when I run that on a fresh copy of this branch

Ok I'm able to get the same diff by running bundle lock --add-platform ruby and everything seems fine on my side. But since we've just now released core version 0.4.38 I'm going to re-generate this PR (making sure that lockfile change is in)


Leading comment characters are stripped

I noticed a strange behavior that when the Comment in the [BEGINVDF] block begins with a capital letter C, that character is stripped. For example: Comment=Case in point yields the comment "ase in point" in the resulting VDF.
I think I can pin point it to this line:
https://github.com/kirides/vdfsbuilder/blob/4ea144e3ee0021571a6cddacd20aeb89d752ea65/vdf/vm.go#L65
It seems the actual comment is stripped of the word Comment= (again). So Comment=Comment of the VDF will result in " of the VDF".

Yes the parsing uses the wrong method.
It should use strings.TrimPrefix instead of Trim left.
Former trims the specific text, while latter Trims any of the chars present in the cut-set (each char in Comment= will be trimmed from left on)


Fix: embedded collections without standalone link

Fixes the issue with embedded collections which don't come with an own standalone link.
In the current implementation, an embedded collection is detected by investigating the first element of the collection and check if it looks like a link. For obvious reasons, this fails for empty embedded collections.
Needs this additional feature in hal-json-normalizer:
https://github.com/carlobeltrame/hal-json-normalizer/pull/64

PR is now feature complete and all tests pass after using the new owning references introduced with https://github.com/carlobeltrame/hal-json-normalizer/pull/71
I will still try to refactor/simplify the handling of embedded collections a bit.

@carlobeltrame: PR would be ready for review. Got a bit larger than expected. Took the opportunity to rename/cleanup some stuff after the refactoring.
Maybe easiest to go through the last 4 commits separately. Otherwise I can also offload them into a separate PR.

Thanks so much for this! I love the renaming and especially the removal of the mixin pattern that this enabled. Let me know if I should finish this up.

Thanks for review/comments. I'll give it a try & cry for help if needed.


Update app-governance-app-policies-overview.md

@WendyLiuC : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @WendyLiuC - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make this content update in the private repo instead? Thank you! We'll close this PR.

#label:"aq-pr-triaged"


2022-06-26 v. 0.8.1: minor updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.946%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
318

Relevant Lines:
370

💛  - Coveralls


wapi: add 5g channel map in wapi

Summary
scan result only process channel 1~14, and no process for 5g channel
Impact
wapi scan result can only show 2g channel
Testing
local test with brcm 43013 chip which can search 5g channel and result is pass

LGTM


Add the MYSQL_SSL_CA option

Add the configuration option for ssl_ca connection parameters.

hey, did you find something?

hey, did you find something?

Hey!
I had to change the connector, this one could work :)
https://pypi.org/project/flask-mysql-connector/

@JafetMo5601 hadn't seen this, do you mind reopening it so I can merge it?

Possible now with MYSQL_CUSTOM_OPTIONS, see README.md.

Possible now with MYSQL_CUSTOM_OPTIONS, see README.md.

Was a request but seems that now should work, will try it as soon as I can.
Thanks! :)


Cut 2.14.0 release

The benchmark looked good and I haven't seen any blocking issues. I am planning to merge this on Monday as long as no issues come in before then.

:+1:


Create data dashboard for Salud Family Health Centers

Create a data dashboard for Salud Family Health Centers. Referrer link is  https://screener.myfriendben.org/step-1?referrer=salud. Salud will start actively using the tool on or about June 5. They estimate roughly 200 screeners over a 4-week period, so we can target late June to create this dashboard.

Update: demo to enrollment team has been pushed back from June 5 to June 12.