DataPackage API feedback

Overview
Based on this readme listing I'm adding feedback based on existent implementations and expected lib user competencies (as we target many almost non-tech users - publisher, data wranglers etc).
use frictionlessdata\datapackage;

// get a datapackage object
$datapackage = datapackage\Factory::datapackage("tests/fixtures/multi_data_datapackage.json");

// iterate over the data - it will raise exceptions in case of any problems
foreach ($datapackage as $resource) {
    print("-- ".$resource->name()." --");
    $i = 0;
    foreach ($resource as $dataStream) {
        print("-dataStream ".++$i);
        foreach ($dataStream as $line) {
            print($line);
        }
    }
}

// validate a datapackage descriptor
$validationErrors = datapackage\Factory::validate("tests/fixtures/simple_invalid_datapackage.json");
if (count($validationErrors) == 0) {
    print("descriptor is valid");
} else {
    print(datapackage\Validators\DatapackageValidationError::getErrorMessages($validationErrors));
}

// get and manipulate resources
$resources = $datapackage->resources();
$resources["resource-name"]->name() == "resource-name"
$resources["another-resource-name"] //  BaseResource based object (e.g. DefaultResource / TabularResource)

// get a single resource by name
$datapackage->resource("resource-name")

// delete a resource by name - will raise exception in case of validation failure for the new descriptor
$datapackage->deleteResource("resource-name");

// add a resource - will raise exception in case of validation error for the new descriptor
$resource = Factory::resource((object)[
    "name" => "new-resource", "data" => ["tests/fixtures/foo.txt", "tests/fixtures/baz.txt"]
])
$datapackage->addResource($resource);

// create a new datapackage from scratch
$datapackage = TabularDatapackage::create("my-tabular-datapackage", [
    TabularResource::create("my-tabular-resource")
]);

// set the tabular data schema
$datapackage->resource("my-tabular-resource")->descriptor()->schema = (object)[
    "fields" => [
        (object)["name" => "id", "type" => "integer"],
        (object)["name" => "data", "type" => "string"],
    ]
];

// add data files
$datapackage->resource("my-tabular-resource")->descriptor()->data[] = "/path/to/file-1.csv";
$datapackage->resource("my-tabular-resource")->descriptor()->data[] = "/path/to/file-2.csv";

// re-validate the new descriptor
$datapackage->revalidate();

// save the datapackage descriptor to a file
$datapackage->saveDescriptor("datapackage.json");

Factory class as an user interface?

actual for both DataPackage/Resource

Just want to raise that it could be confusing to non-tech users to have Factory as a main entry point instead of DataPackage and Resource as in other implementations. I think DataPackage.create/load and Resource.create/load could be more convenient  (and predictable if user has an experience with other language implementations).
Accept PHP array?

actual for both DataPackage/Resource

The same as in https://github.com/frictionlessdata/tableschema-php/issues/26

There is a decision to use Package instead of DataPackage - https://github.com/frictionlessdata/datapackage-js/issues/81

fixed in v0.1.4
see the README for the updated usage examples


[fix][admin] Add support for admin auth via conf props

This PR is for running tests for upstream PR https://github.com/apache/pulsar/pull/18358 .

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Closed via https://github.com/apache/pulsar/pull/18358


How to use list.rs in the example

please tell me how use this example  list.rs.
I run it in the Linux.  compiled it into a executable file.
./list .  it was waiting for my input. I don't know what should I input. So  I put a tar in the same director of the file list.

And what is the stdin？ what should I input？

You can try like cargo run --example list < example.tar
For more info see here

Yes what @p-inks mentioned should work.

You can try like cargo run --example list < example.tar For more info see here

3q for your help.it does work.

Yes what @p-inks mentioned should work.

3q


[FEATURE] Add examples in repo for long-running workers

Duplicate issue

[X] I've searched for any related issues and avoided creating a duplicate issue.

Description
Hello! I just wanted to take a moment to express my sincere gratitude for your fantastic project – it's exactly what I've been searching for all this time! I've come across many worker thread wrappers, but none of them seem to fit my specific needs.
I'd like to suggest adding examples to the repository that showcase the usage of long-running workers. I believe this would greatly benefit users like me who are looking to understand how to implement this feature effectively.
I'm looking to execute long-running I/O and CPU intensive tasks that need to communicate with each other using event-based communication. These tasks are loaded from a configuration file at startup and may run for the entire duration of the application. The number of workers won't change during the app's execution, and each task has its own unique configuration.
Most worker thread wrappers are designed for fixed or dynamic pools, which don't align with my use case. However, it seems that Poolifier is architected differently and might be suitable for my needs. I'm just a bit unsure about how to use it correctly.
It seems more logical to use Poolifier compared to raw worker threads, especially considering this issue: https://github.com/poolifier/poolifier/issues/801. Once that's resolved, transitioning from worker threads to a cluster would be a breeze.
Since Poolifier supports MessageChannel, I'm curious if it's possible to utilize BroadcastChannel for worker threads within Poolifier for my specific use case.
Could you please provide some clarification on whether Poolifier is indeed suitable for my needs? Your guidance would be greatly appreciated!
Attachments
No response

I'm looking to execute long-running I/O and CPU intensive tasks that need to communicate with each other using event-based communication. These tasks are loaded from a configuration file at startup and may run for the entire duration of the application. The number of workers won't change during the app's execution, and each task has its own unique configuration.

It's an ongoing reflection: https://github.com/poolifier/poolifier/issues/596
But basically:

Fixed pool
No tasks queueing
RR tasks distribution
Number of tasks = number of workers for service

The service running use case differs a lot from tasks with request/response.
The examples show how to do it for HTTP servers. Clients use-case will work the same way but you can imagine running several clients in one worker.

Since Poolifier supports MessageChannel, I'm curious if it's possible to utilize BroadcastChannel for worker threads within Poolifier for my specific use case.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API. There's no equivalent for cluster (or child_process).

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The Node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API that can be used with poolifier. There's no equivalent for cluster (or child_process).

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The Node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API that can be used with poolifier. There's no equivalent for cluster (or child_process).

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The Node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API that can be used with poolifier. There's no equivalent for cluster (or child_process).

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The Node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API that can be used with poolifier. There's no equivalent for cluster (or child_process).

Thank you for your response, @jerome-benoit!
If I understand you correctly, since the issue #596 hasn't been resolved yet, it seems that Poolifier may not be the best fit for my use case. In this case, I should consider using worker threads directly or creating my own wrapper. Please correct me if I'm mistaken.

The issue quoted will hardly end offering out of box solution for all kind of tasks running as background processes. Each task can have its own internals that can make their moving, spawning across workers very specific. For example:

WebSockets server: probably the number of incoming open connection, no moving possible (stateful connection)
WebSocket client pool: probably the number of outgoing open and used connection, moving possible if unused
...

Designing and implementing an API for that kind of tasks requires quite a lot of plumbing first, and a way to write an own worker selection fitting the task internals. And we are still unsure about about incorporating it directly in poolifier, or as plugins.
We are taking PRs :)

Based on your guidance, it looks like the example you provided uses raw worker threads instead. https://github.com/SAP/e-mobility-charging-stations-simulator/blob/main/src/worker/WorkerSet.ts#L4

Both are working depending on the use case and its related workload.

Poolifier internal communication != task(s) internal communication
The way you design your application communication between task(s) running instance in workers is out of the poolifier scope and you can do it the way you want.

Initially, I thought that Poolifier handled the complexities of synchronizing states between workers, such as using MessageChannel for worker threads or IPC for cluster. I'm somewhat surprised to find that there doesn't appear to be a readily available solution for this specific use case within the Node.js ecosystem.

 But you are talking about read/write atomically on shared data structure from various processes. The Node.js solution for worker_threads is SharedArrayBuffer and Atomics JS API that can be used with poolifier. There's no equivalent for cluster (or child_process).

I would greatly appreciate hearing your thoughts on this matter. I'm considering starting the development of a solution as described above, as it could be a valuable addition to the Node.js ecosystem. Your expertise, as a maintainer of one of the top Node.js pool libraries who deals with worker threads and clusters regularly, would be highly valuable. Your input would be greatly appreciated.

It might take a bit of time before I will be able to answer to all points. But for more insight on the status of parallelism with JS, you have to keep in mind that it has be designed as a mono-threaded runtime interpreter (v8, JavaScriptCore, ...), being integrated in node.js or browser or bun or deno or .... Given that initial design, any subsequent work done at introducing multi-processing or multi-threading in JS, even the well-thought one, remains hackish and not that performant.
If you compare for example with rust, go or even java, wandering on the parallelism path with JS is way less easy and the end-results are not always as performant as you might expect, because of the initial design choice.

So, for applications with long-running, fixed numbers of tasks spawned at startup, the cluster API (or just using directly the child_process.fork()) seems to be a more robust choice under the hood.
In my opinion, a solution like "cluster-plus-plus" should be developed as a separate package, rather than being directly within the scope of the Poolifier project. This way, anyone could replace the existing worker threads implementation with "cluster-plus-plus," and Poolifier could potentially use it as well.
For interprocess communication, an embedded database that doesn't rely on third-party dependencies like Redis could be a suitable replacement for SharedArrayBuffer. I've taken a liking to lmdb-js at first glance. Additionally, libraries like ZeroMQ or pm2-axon could fill the gap left by MessageChannel/MessagePort/BroadcastChannel.

worker_threads is designed to mimic the POSIX threads features. The multithreading model apply here.
child_process is designed to mimic POSIX fork(). The multiprocessing model apply here. Cluster module is using that model.

If you want the tackle the known issues with the current implementations allowing parallel computing in node.js:

worker_threads IPC (message channel, broadcast channel) has scalability issue. If you want to address it, I suggest doing it upstream directly by proposing a scalable implementation.
worker_threads high memory usage. It's probably a work to be done at the interpreter level.
issues left hindering worker_threads usage and forcing the use of child_process instead.
worker_threads shared memory encapsulation and handling into a more friendly API.

The multiprocessing model in general has too much drawbacks per design to tackle the parallel computing paradigm. The node.js ecosystem is more or less focusing at making worker_threads as mature as child_process.
For example, the cluster module with worker_threads would use less memory and CPU than the current one using child_process while offering sharing memory.

It's a discussion, not an issue to track. If the discussion need to continue, please do it at https://github.com/poolifier/poolifier/discussions


Tab complete isn't working perfect.

When you do /lp group  list + TAB (to autocomplete listmembers) it does /lp group  info instead.
EDIT: /lp group  li + TAB does show listmembers. So only list + TAB is not working.

This is intended.
You need to run /lp group <group name>  and then hit tab to complete the subcommand.


How to get image metadata？

If we want the metadata on what thumbor would do, just change the url to be
http://my-server.thumbor.org/unsafe/meta/-300x-200/left/top/smart/path/to/my/nice/image.jpg


Developer guide not reachable from http://kubernetes.io/docs/reference/

I found no path from http://kubernetes.io/docs/reference/ to the developer guide.

Click "Guides" in the horizontal nav

You mean like this:
?  What is the path from there to https://github.com/kubernetes/kubernetes/blob/master/docs/devel/README.md ?


Allow underscores in GDScript numeric literals

Closes #12928
Allows doing things like:
var x = 1_000_000
var y = 1_00_00_00
var z = 100_000_0

Is there any point to this?
On Nov 15, 2017 5:55 PM, "Bojidar Marinov"<EMAIL_ADDRESS>wrote:

Closes #12928 https://github.com/godotengine/godot/issues/12928
Allows doing things like:
var x = 1_000_000var y = 1_00_00_00var z = 100_000_0

You can view, comment on, or merge this pull request online at:
https://github.com/godotengine/godot/pull/12957
Commit Summary

Allow underscores in GDScript numeric literals

File Changes

M modules/gdscript/gd_tokenizer.cpp
https://github.com/godotengine/godot/pull/12957/files#diff-0 (5)
M scene/gui/text_edit.cpp
https://github.com/godotengine/godot/pull/12957/files#diff-1 (7)

Patch Links:

https://github.com/godotengine/godot/pull/12957.patch
https://github.com/godotengine/godot/pull/12957.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/12957, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z27k4Pc6RNGaa7HdCZmTI_1Ds6-5hks5s20-6gaJpZM4Qfjkc
.

Better readibility? I think that 1_684_456_134 is much better readable than<PHONE_NUMBER>.

Yes, the main point is readability. This has been implemented by some languages, such as Java, D and Crystal.

C# 7.0 also supports this, by the way 😄

👍


failed to load certificate files for phishlet 'linkedin', domain 'linkedin.microsets-laravast.com': open /root/.evilginx/crt/linkedin.microsets-laravast.com/linkedin.crt: no such file or directory

Hi
I have double-checked everything:
1- 443, 80, and 53 ports are used by Evilginx only:
abodave@abodave-VirtualBox:~$ sudo lsof -i :443
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
evilginx 2135 root    7u  IPv6  42220      0t0  TCP *:https (LISTEN)
abodave@abodave-VirtualBox:~$ sudo lsof -i :80
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
evilginx 2135 root    9u  IPv6  41646      0t0  TCP *:http (LISTEN)
abodave@abodave-VirtualBox:~$ sudo lsof -i :53
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
evilginx 2135 root    8u  IPv6  41645      0t0  UDP *:domain
abodave@abodave-VirtualBox:~$
2- I have a domain name: [microsets-laravast.com] from NameCheap Website
3- My domain name servers are: [ns1.digitalocean.com, ns2.digitalocean.com, ns3.digitalocean.com] on NameCheap Website:

4- I have a VPS server with IP address [<IP_ADDRESS>] from DigitalOcean Website
5- I have 7 DNS Records listed on DigitalOcean Website:

And I have followed the official documentation of Evilginx and watched many tutorials
But unfortunately, I still got this issue :(
: phishlets enable linkedin
[16:48:02] [inf] enabled phishlet 'linkedin'
[16:48:02] [inf] setting up certificates for phishlet 'linkedin'...
[16:48:02] [war] failed to load certificate files for phishlet 'linkedin', domain 'linkedin.microsets-laravast.com': open /root/.evilginx/crt/linkedin.microsets-laravast.com/linkedin.crt: no such file or directory
[16:48:02] [inf] requesting SSL/TLS certificates from LetsEncrypt...
[16:48:02] [!!!] get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: Temporary failure in name resolution
[16:48:02] [inf] disabled phishlet 'linkedin'
:
: lures create linkedin
[16:48:14] [inf] created lure with ID: 2
: lures edit 2 redirect_url https://www.google.com
[16:48:30] [inf] redirect_url = 'https://www.google.com'
: lures get-url 2

https://www.linkedin.microsets-laravast.com/jqvSkZNL

: phishlets get-hosts linkedin

<IP_ADDRESS> www.linkedin.microsets-laravast.com

:

When I open the produced link I got this:

Pleaaaase guys, I need your help.

Are you trying to use Evilginx with LinkedIn for the first?

I am asking you this because LinkedIn deactivate accounts after the tokens have been intercepted by Evilginx.

Hey this issues has been fixed on the latest copy of LinkedIn phishlets I got from the author... Y'all can reach out to him on icq @mrgretzky if needed


Clang compliant on macosx

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Work around with the issue: https://stackoverflow.com/questions/34183379/clang-does-not-work-properly-with-stdexperimentaloptional

Thanks!


use ::{x, y} is being rewritten as use {x, y}

I believe it changes semantics and shouldn't be touched.
Case in study:
diff --git a/src/libcore/num/wrapping.rs b/src/libcore/num/wrapping.rs
index 0e8ced0..55edddc 100644
--- a/src/libcore/num/wrapping.rs
+++ b/src/libcore/num/wrapping.rs
@@ -29,7 +29,7 @@ use intrinsics::{i16_mul_with_overflow, u16_mul_with_overflow};
 use intrinsics::{i32_mul_with_overflow, u32_mul_with_overflow};
 use intrinsics::{i64_mul_with_overflow, u64_mul_with_overflow};

-use ::{i8,i16,i32,i64};
+use {i8, i16, i32, i64};

 pub trait OverflowingOps {
     fn overflowing_add(self, rhs: Self) -> (Self, bool);

The :: is intentionally discarded by libsyntax; see https://github.com/rust-lang/rust/blob/d3f497861d426c8724dd84f161ca21f274663963/src/libsyntax/parse/parser.rs#L5590 .

Ah yes, all paths in imports are absolute, so there is no difference, so rustfmt is doing the right thing by normalising.
Thanks @eefriedman!


bird evidence items

Do you use the bird evidence items as inputs as well?
evidence: the external knowledge evidence annotated by experts for assistance of models or SQL annotators.

Yes, we pass both the questions and the evidence as inputs. According to the benchmark providers, each instance of the task comes with a pair of a question and an evidence which should be mapped to a SQL query. Using the evidence is a standard practice to clarify some of the disambiguities within the question.


Restore 2.4 source branch for bug fix 6317.

resolves #6317
What does this PR change?
This PR update image step of type "int" instead of "MatStep" because if reading large size of image, the "int" type may cause overflow and crash during invoke function "png_read_image".
And this is a re-run RP, because of previous 2.4 source tree with this patch had been deleted from local.

:+1:

I will create another PR for porting this patch to master after this build done.

PR for master is not needed (we will merge all fixes from 2.4 to master). Just wait a few days.

Got you. Thank you for explanation!


Linux Install Fails on Exllamav2

Expected Behavior
Builds without errors
Current Behavior
Fails to install Exllamav2, but then completes the installation. Can't use Exllamav2.
Steps to Reproduce

#> scripts/linux/linux_install.sh
wait
#> scripts/linux/linux_run.sh

Possible Solution
I identified the problem: there are inconsistent version requirements for aqlm. Some requirements.txt files require exactly 1.1.0, some exactly 1.3.0, and in the case of Exllamav2, the requirements.txt file contains requirements for BOTH versions. I have a feeling the "solution" to this is going to be complicated. Obviously, miniconda can't install both versions, and I suspect that there are legitimate requirements for both.
Context
Please provide any additional context about the issue.
Screenshots
If applicable, add screenshots to help explain the issue.

Similar issue on windows (hardware rtx 3060, p106-100) error message:
DLL load failed while importing exllamav2_ext: The specified procedure could not be found.


[permessage-deflate] Handle server_no_context_takeover

This is in the context of #81 . The purpose and effect of the negotiation parameter server_no_context_takeover needs to be understood and implemented. (For e.g: Does it mean we create new deflaters and inflaters on every message?)

Implemented on Kitura-WebSocket-NIO


Trigger phone vibration from server

Add the ability to vibrate the phone from the server

Done in https://github.com/omarrayyann/MujocoAR/commit/ade9898fee95c83ca6e1b0e106c2e24dc3ddd1c8


test.rb:116-117: Gem 'mail' sends email as a single line,...

The puzzle DEV-9b6b032b from #DEV has to be resolved:
https://github.com/dgroup/lazylead/blob/ac887b0671f6d353fa0fb215fc7331e7885c560a/test/test.rb#L116-L117
The puzzle was created by @dgroup on 03-Oct-20.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle DEV-9b6b032b has disappeared from the source code, that's why I closed this issue.


defaultValueSql parameter is null but computedColumnSql is used instead

When overriding the ColumnDefinition method for the MySQL provider implementation the defaultValueSql parameter is always null even though the usage of the HasDefaultValueSql. Which seems to me that it should be assigned in the defaultValueSql  parameter. Apparently the usage of ValueGeneratedOnAddOrUpdate in OnModelCreating method is causing that the value always is assigned to the computedColumnSql parameter.
how to reproduce it
Define an entity with the HasDefaultValueSql method. For example
  modelBuilder.Entity<Employee>()
         .Property(p => p.Timestamp)
         .HasDefaultValueSql("CURRENT_TIMESTAMP")
         .ValueGeneratedOnAddOrUpdate();

The table create script created does not include the current_timestamp default value on this column.
We also need to have a way to specify that the value only should be generated in the Update. Is there any way to specify it already?
Could you please give any guidance or explain if this working as expected?
Thanks in advance!

Hey,
We are planning to change this. Currently HasDefaultValueSql + ValueGeneratedOnAddOrUpdate is interpreted to mean "computed column"... but this is not desirable so https://github.com/aspnet/EntityFramework/issues/4501 is tracking changing this behavior.
~Rowan

Thanks for clarifying. I will track that one for the updates.

Sounds good, I'll close this one out.


Improve the project README

Use the SVG version of the logo.
Mention console support in the first paragraph.
Point contributors to the #godotengine-devel IRC channel.
Improve formatting for better readability.
Add more links when needed.
Fix warnings reported by markdownlint.

Formatted preview

Is it just me, or does the first sentence miss a verb?

@pycbouh Good catch. I tried to improve the first sentence; is it better now?

@Calinou You didn't push anything 🙂

@pycbouh Fixed.

Yes, much better now.

Thanks!

Cherry-picked for 3.2.3.


metrics: add a candidate set of metrics for measuring db access times.

Original PR: tendermint/tendermint#9774.
This PR addresses #46.  It provides a proposed implementation of metrics to measure the DB access times of different Tendermint components.
This is still work in progress. Do not merge!

Closing as it is superceeded by #1974


Manipulations with layers

Rename directory with meta layers to layers
dom0: domd: merge related layers

Successfully built with the
moulin prod-devel-rcar.yaml --ENABLE_DOMU yes --GRAPHICS binaries
ninja full.img

Ack is added.
Ready to be merged.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
dcb396c -> d72be06

github.com/gruntwork-io/terratest
require
patch
v0.43.6 -> v0.43.8

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.10.8 -> v1.10.11

Release Notes

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.43.8
Compare Source
Modules affected

terraform

Description

Added public ParsePlanJSON function to terraform module.

Special thanks

Special thanks to the following users for their contribution!

@mdb

Related links

https://github.com/gruntwork-io/terratest/pull/1309

v0.43.7
Compare Source
Modules affected

azure

Description

Added support for Azure SQL Managed Instance

Special thanks

Special thanks to the following users for their contribution!

@sweanan

Related links

https://github.com/gruntwork-io/terratest/pull/1307

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.10.11
Compare Source
Bug Fixes

deps: update module github.com/gruntwork-io/terratest to v0.43.8 (#581) (5b1468a)

v1.10.10
Compare Source
Bug Fixes

fixed a bug in upgrade test (#579) (8d18919)

v1.10.9
Compare Source
Bug Fixes

deps: update module golang.org/x/crypto to v0.11.0 (#578) (7d3a4ef)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

GitHub release
v1.2.0

Your semantic-release bot :package::rocket:


pilot: fix Gateway API conversion MatchExpressions handling for NotIn and DoesNotExist operators

Please provide a description of this PR:
Fixes #48044
Added a few additional listeners in the test fixture YAML to add coverage for AllowedRoutes selector MatchExpressions, but think I missed updating a bit of boilerplate to get the golden files regenerating properly (and I might need to add additional routes to target these new listeners?) - I'm currently hitting the following error when running REFRESH_GOLDEN=1 go test ./pilot/pkg/config/kube/gateway -run TestConvertResources/route-binding -v
    diff.go:111: Refreshing golden file testdata/route-binding.yaml.golden
    conversion_test.go:1229: failed to parse CRD: configuration is invalid: 2 errors occurred:
                * config namespace and dnsName in host entry cannot be empty
                * invalid namespace value "" in gateway

Hi @mikemorris. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test
/hold until John's feedback can be addressed.

@mikemorris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test release-notes

unit-tests-arm64_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test release-notes

unit-tests-arm64_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests-arm64

unit-tests_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests-arm64

unit-tests_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests

release-notes_istio
2fcebf6b24268a92807a5467150085ab1f2e61c1
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
9d7ab74a57374fd103d7d4881f765448d564c82d
link
true
/test unit-tests-arm64

release-notes_istio
5ad840f6ba82214ee9a6348a7c141263b9227639
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test release-notes

lint_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test release-notes

lint_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test lint

gencheck_istio
1caa89cee95438b42d0bb2f8f53fc14eb3988e34
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
7919302b347a28980ed5fb4243ce426e832abe59
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
e46a62df82104afdf4006775c344e690554cd7cc
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
e46a62df82104afdf4006775c344e690554cd7cc
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
e11d5fbe3010eac19a0ff242e17701f7bb03d57e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I ended up touching a few additional spots of logic that seemed incorrect (left comments highlighting them), this should be complete now but could use another set of eyes.
/retest

@mikemorris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test unit-tests-arm64

gencheck_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikemorris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test unit-tests-arm64

gencheck_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test gencheck

lint_istio
8090aa6b13326cf26b26a0a9df6014f16347ec38
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Permit list of keys as array

To match rails 4 implementation. I just bumped into this using strong-parameters with devise and rails 3.2

Closing because it was fixed in #242


Fix current / native resolution parsing, and add tests with mocha

This PR fix a parse error on some xrandr outputs, where * and + are inverted.
It also includes some tests to check some cases.

Need this too, any chance to get this merged soon?


Not working for me

I am getting this error message:
The app_name value in ./android/app/src/main/res/values/strings.xml must be the same with ./ios/AppFolderName before renaming the app.
ex. ./ios/CoolApp  --->  CoolApp
and try running the command again with you new app name.
But the name is exactly the name already.

Hi @jsappme , may i know what version of react-native-rename are you using? and also react-native? and what OS?
Note, that this package assumes that you install your react-native app using react-native init.

react-native-rename 1.0.8
"react-native": "^0.37.0"
macOs with latest xcode

In your . /ios directory, are Tests folders exist?

yes
On Thu, Nov 24, 2016 at 6:02 PM, June Domingo<EMAIL_ADDRESS>wrote:

In your . /ios directory, are Tests folders exist?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuneDomingo/react-native-rename/issues/1#issuecomment-262857712,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM0R9Y9whFqy2rjvteTVOr-sopWTprj9ks5rBiWwgaJpZM4K79Gi
.

--
Hervé Fulchiron
JSapp.me

Hmmm.. Did you make any changes in ./ios folder before? like renaming them manually?

maybe I did long time ago.  so no worry for now.

I see, make sure the app_name value in ./android/app/src/main/res/values/strings.xml must be the same with these folders.
./ios/AwesomeProject
./ios/AwesomeProject.xcodeproj
./ios/AwesomeProjectTests
and when you have spaces in your new app name.. make sure you wrap them in double quote, ex react-native-rename "CoolApp"

@JuneDomingo worked well for me, thank you! :1st_place_medal:

@junedomingo Your latest comment regarding the app_name in strings.xml saved my day. As I have changed the app name a few weeks back, the app_name differed from the iOS folder names. As a result, $ react-native-rename did update any iOS-related files.
I've wasted quite some time until I found this old issue with your useful remark.
Have you considered adding this note to the readme?
In any case, thanks for the project. Very handy, indeed!


Documentation hint for mount configuration

Add a documentation hint for mount configuration.
I know it might sound like a newbie issue (and it is, probably) but I just spent half an hour trying to find out where my configuration was.
Feel free to remove if it's not relevant as it's 100% Ruby matter and 0% Grape.
¯_(ツ)_/¯
I didn't write a changelog as it's not a feature, also feel free to ask for one. :)
BTW thank you so much for this incredible gem, love it!

I like it, let's merge.

Thanks for contributing to the doc @francois-belle


error when on the phone

when someone calls it appears like that

Bug fixed, thank you very much for telling me

Bug fixed, thank you very much for telling me


(PUP-7309) acceptance: hiera merge strategies

test hiera3 and hiera5 merge strategies using hiera_hash and lookup
functions
edit: added a commit for hiera_array and merge_hash_arrays

please do not merge until after PA 1.9.3 ships.

@er0ck could you verify this test works when there is an agent on the master?

    "HOSTS": {
        "r0pibn118h5p96h.delivery.puppetlabs.net": {
            "pe_dir": null,
            "pe_ver": null,
            "pe_upgrade_dir": null,
            "pe_upgrade_ver": null,
            "hypervisor": "vmpooler",
            "platform": "el-7-x86_64",
            "template": "redhat-7-x86_64",
            "roles": [
                "master",
                "agent",
                "default"
            ],
            "host_tags": {},
            "user": "root",
            "group": "puppet",
            "pathseparator": ":",
            "vmhostname": "r0pibn118h5p96h.delivery.puppetlabs.net",
            "puppetbindir": "/opt/puppetlabs/bin",
            "privatebindir": "/opt/puppetlabs/puppet/bin",
            "distmoduledir": "/etc/puppetlabs/code/modules",
            "sitemoduledir": "/opt/puppetlabs/puppet/modules"
        },
        "kmkbp73wgtc5uc0.delivery.puppetlabs.net": {
            "pe_dir": null,
            "pe_ver": null,
            "pe_upgrade_dir": null,
            "pe_upgrade_ver": null,
            "hypervisor": "vmpooler",
            "platform": "ubuntu-14.04-amd64",
            "template": "ubuntu-1404-x86_64",
            "roles": [
                "agent",
                "aio"
            ],
            "host_tags": {},
            "user": "root",
            "group": "puppet",
            "pathseparator": ":",
            "vmhostname": "kmkbp73wgtc5uc0.delivery.puppetlabs.net",
            "puppetbindir": "/opt/puppetlabs/bin",
            "privatebindir": "/opt/puppetlabs/puppet/bin",
            "distmoduledir": "/etc/puppetlabs/code/modules",
            "sitemoduledir": "/opt/puppetlabs/puppet/modules"
        }
    },

...
tests/lookup/merge_strategies.rb passed in 27.37 seconds
      Test Suite: tests @ 2017-03-13 21:21:56 +0000

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 27.37 seconds
      Average Test Time: 27.37 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1

      - Specific Test Case Status -

Failed Tests Cases:
Errored Tests Cases:
Skipped Tests Cases:
Pending Tests Cases:


[UI] Small amends

A raft of small changes

Also:

updated headings relative to the standards spreadsheet
split between nhs and prsb orgs on import

Looks good but failing lint/tests

Ops! Yeah a content change needed to be reflected in the integration tests. Ta!


benchmarks for websocket throughput https://app.te…

Referenced here:
https://app.tettra.co/teams/cs-web-proto/pages/requirements

Thanks.


[incubator/haproxy-ingress] Fix helm3 ClusterIP updates

Is this a new chart
No
What this PR does / why we need it:
This PR fixes issue with upgrading haproxy-ingress chart with helm3. Right now it produces the following errors:
"RELEASE_NAME-haproxy-ingress-controller-stats" with kind Service: Service "RELEASE_NAME-haproxy-ingress-controller-stats" is invalid: spec.clusterIP: Invalid value: "": field is immutable

"RELEASE_NAME-haproxy-ingress-controller-metrics" with kind Service: Service "RELEASE_NAME-haproxy-ingress-controller-metrics" is invalid: spec.clusterIP: Invalid value: "": field is immutable

Which issue this PR fixes
N/A
Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @xianlubird

/ok-to-test

/lgtm
/approve


Tighten mocha options and move them to mocha.opts file.

Also, renamed the "tests" folder to "test" since that's where mocha is looking for.
@jmervine: there's a bug in our tests, with wrong callbacks in assertValidHTML thus why we need to use --exit in mocha. I could use some help fixing this. Also, the validator supports ignore so I say we drop this custom code.

I made #1027 which seems to be the culprit with no exit in mocha.
Thanks for the changes @jmervine

@jmervine: you can remove --exit from mocha.opts, make a test fail and see the hang.


Feature/voice notes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

29 of 46 (63.04%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 81.631%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

todo/models.py
6
7
85.71%

todo/views.py
10
26
38.46%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.7%

Covered Lines:
951

Relevant Lines:
1165

💛  - Coveralls


Type predicate expressions and 'this' type assertions

The type system currently allows to specify basic type constraints (or 'assertions') on polymorphic types, for example:
function example<T extends Array<any>>(a: T) {};

However, currently there is no elegant syntax for types to declare constraints on themselves. Here's a real world example where I needed something like this:
I have a class containing several methods:
class MyClass {
	read(filename: string, byteCount: number): string {
		// ...
	}

	write(filename: string, text: string): void {
		// ...
	}

	delete(filename: string): void {
		// ...
	}
}

and I want to write a known (i.e. monomorphic) type that is constrained to exactly match the keys of MyClass (the property types don't matter for this example, so I annotated them with  { ... }, for simplicity, also note that MyType is intended to be user-customizable and cannot be deterministically generated using a mapped type):
type MyType = {
	read: { ... };
	write: { ... };
	delete: { ... };
}

The best hack/workaround I found so far was to declare additional dummy types, that would fail if MyType doesn't satisfy the expected constraint:
type Extends<T1 extends T2, T2> = boolean; // The 'boolean' doesn't really have any meaning here.
					// It can technically be any type.
					// I only used it because I needed to fill out some sort of
					// type association to satisfy the compiler.

// These types are never actually used. They are only here to force the program not to type-check
// if their supplied arguments don't satisfy the constraints for the Extends<..> type parameters:
type DummyAssertionType1 = Extends<keyof MyType, keyof MyClass>;
type DummyAssertionType2 = Extends<keyof MyClass, keyof MyType>;

The hack does seems to work so far, and has proven useful in practice, so by itself that's a significant improvement over having nothing at all. However, it is not very elegant or readable and violates type 'encapsulation'. It would be cool if I could instead write something like:
type SameKeys<T1, T2> = (keyof T1 extends keyof T2) && (keyof T2 extends keyof T1);

type MyType where SameKeys<this, MyClass> = {
	read: { ... };
	write: { ... };
	delete: { ... };
}

I'll try to break down what is happening here:

The SameKeys type contains a type expression that evaluates to either the true or false boolean literal types. Given P1, P2 are valid type predicate expressions (e.g. T extends U) then P1 && P2, P1 || P2 !P1 are also type predicate expressions etc.
The where keyword simply implies that the following type or type expression must evaluate to a boolean literal type and in particular to true for the constrained type to be valid.

[Edit: removed some confusing examples, see the next comment]
The concept can also be used with interfaces, or even classes:
interface MyInterface<T, U> where SomeComplexPredicate<this, T, U> {
  // ...
}

class MyClass<T, U> where SomeComplexPredicate<this, T, U> {
  //...
}

Edit: changed the suggested satisfies keyword to where as I believe it gives slightly better readability.

I think some of my examples were a little bit misleading and I need to try to clarify what exactly is and is not in the scope of this idea (perhaps for myself as well):
This concept is about:

Providing a way for a type, interface or class declarations to provide a set of assertions on themselves, in the same sense that contracts assert over values. This is very similar in spirit to implements but allows for more expressive grammar in the form of propositional logic statements and clauses over relations between types. In a rough sense, it allows interfaces to "implement" other interfaces, types, or class "shapes", or more complex mappings of them, and test for multiple combinations of these propositions that are joined by logical connectives.

This concept is not about:

Providing an alternative way to declare constraints on polymorphic types: I have considered what would be the implications of trying to achieve that using this powerful grammar and came to the conclusion that the level of potential complexity would not justify the value it gives.

I'll try to create a set of limiting rules to try to "reduce" the power (and also the potential traps) of these clauses.
One thing that can be done is introduce rules that limit what can participate in individual propositions. The first rule might be that every proposition must include the this type (or a name that corresponds the current type) at some form:
These are ok:
interface MyInterface<T, U>
    where (this extends { [key: string]: [T, U] }) ||
          ({ [key: string]: { a: T, b: U } } extends this) {
   // ...
}

interface MyInterface<T, U>
    where keyof this extends "a" | "b" | "c"
   // ...
}

These are not:
interface MyInterface<T, U>
    where T extends Array<any> {
    // ....
}

interface MyInterface<T, U>
	where Array<T> extends Array<number> {
    // ....
}

The reason I'm trying to disallow these patterns is because I'm considering what would happen if the type arguments T and U are themselves polymorphic:
function test<A, B>() {
	let a: MyInterface<A, B>;
}

If the where assertion was allowed to constrain its types parameters directly with this powerful grammer, it would mean that the compiler would need to "prove" that the polymorphic types A and B satisfy a set of very complicated constraints, and that may be very difficult to do, and perhaps even require some sort of theorem prover.
Instead, I'm trying to figure out a way to limit the power of these propositions to avoid trying to directly or indirectly enforct particular types over their parameters.
So the following assertion should probably fail as well:
interface MyInterface<T>
	where keyof this extends { a: number } {
   a: T;
}

Because it indirectly "forces" a type over an unknown polymorphic type.
I think the aim and direction here should become clearer now. I hope this clarifies things a bit.

Another way to express this is that the where assertion I'm describing here "validates" the final, resulting type, but does not participate in its formation. It is not the same semantics as where in C# , which is used for type parameter constraints.
Maybe the name could be improved. Initially I considered satisfies, which I thought didn't read very good, then where. I'm considering assert but it could be a bit confusing as most people associate it with assertions over values, not types. I don't want to use keywords that may be useful for future features like code contracts (ensure, validate, expect etc.). For the time being, I guess I'm 'stuck' with where.

I have intentionally generalized the ideas here as I felt doing that would be interesting academically important. I wasn't necessary suggesting for it to be implemented the way it is presented here.
I'm closing this for now to prevent it from getting "tanked" forever by the TS team. Maybe I'll try to suggest something similar in the future in a more limited form.


Backport of #53: When directory path includes spaces windows release verification script fails

Fix for release script error when there is space in directory path.

:+1:


[Docs] Flatten side menu ListItem props on a single line.

In keeping with the discussion about keeping props on a single line for internal components. This change makes the menu code easier to scan IMHO.

Sorry, PR from wrong branch. Incoming!


Put show_update_message behind a flag to reduce noise

The fastlane update message displayed by this function is causing way too much noise: https://github.com/fastlane/fastlane/blob/fa5fc3ef7ef22c9e6b760f0e15b7f2498beb151e/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb#L50
Please allow for an option to mute these messages completely. We know that there is a new version.

Thanks for your feedback, we'll take a look.

You can use the FASTLANE_SKIP_UPDATE_CHECK environment variable for this 👍


add minimal metadata to JSON output

it would be cool if  the JSON dump would contain some minimal metadata:

ID and name of the table
base-url of the baserow instance
database ID
timestamp

The latter three can be added by the calling script, but the table ID is only known to the function.

I'd like to keep those two things separate, but with https://github.com/acdh-oeaw/baserow-dump-cookiecutter/issues/1 in place, we would have the data and some structured metadata in one file
see here for a current implementation https://github.com/teaching-paradimes/teaching-paradimes-baserow-export/blob/1-serialize-json-dumps-as-teixml/make_tei.py
should be ready next week

here is an example of the current TEI/XML https://github.com/teaching-paradimes/teaching-paradimes-baserow-export/blob/1-serialize-json-dumps-as-teixml/tei/courses.xml


Replace Electron with pywebview

Endless Key app uses Electron's webview as the frontend.  But, it cannot use system's dGPU correctly.
Pywebview is a Python library briding between Python application and native webview from system.  On Windows, it invokes Webview2 runtime, which is a loader to load Windows' native webview.  This also reduces size of the package, because it does not contains another webview.  Besides, using native system's webview gains better system support, for example the dGPU.
Fixes: https://github.com/endlessm/endless-key-app/issues/141

I notice it directs to welcome screen from loading screen every launch time ...  Which means have to choose & download pack every launch time.  Trying to find out why it happens.  So, this PR is in draft state.

I notice it directs to welcome screen from loading screen every launch time ... Which means have to choose & download pack every launch time. Trying to find out why it happens. So, this PR is in draft state.

Ok!  Found this needs cookie/session feature.

During the test, I notice pywebview (system's webview) will create cookies' stoarage path in C:\Users<user>\Appdata\Roaming\kolibri-electron\endless-key, not the APPX/MSIX package's mapped virtual path C:\Users<user>\AppData\Local\Packages\EndlessOSFoundation.EndlessKey_xxxooooxxx\LocalCache\Roaming\kolibri-electron\endless-key. I am preparing another commit to fix it.
Pywebview still work as expected!  Just try to fix the cookies' storage path.

During the test, I notice pywebview (system's webview) will create cookies' stoarage path in C:\Users<user>\Appdata\Roaming\kolibri-electron\endless-key, not the APPX/MSIX package's mapped virtual path C:\Users<user>\AppData\Local\Packages\EndlessOSFoundation.EndlessKey_xxxooooxxx\LocalCache\Roaming\kolibri-electron\endless-key. I am preparing another commit to fix it.

Pushed commit Fix KOLIBRI_HOME as real path of %APPDATA%\kolibri-electron\endless-key to fix it.  This PR is ready for review again!

Verified Passed in Windows <IP_ADDRESS>


Add NetHack

Sorry, this manifest doesn't handle save files very well. I will open a new pull request when that is sorted out.


Colorbar: show ticks by default

A unitless colorbar is surprising.
var plt = new ScottPlot.Plot(600, 400);
plt.AddColorbar();
plt.SaveFig("colorbar_quickstart.png");

Adding tick labels doesn't look easy...
var plt = new ScottPlot.Plot(600, 400);

var cb = plt.AddColorbar();
cb.AddTick(0, "-123");
cb.AddTick(1, "+123");
cb.AddTick(.5, "0");
cb.AddTick(.25, "-61.5");
cb.AddTick(.75, "+61.5");

plt.SaveFig("colorbar_ticks.png");

Interestingly we calculated beginning and end values when colorbars were part of the heatmap, but I don't think that that was carried over: https://github.com/ScottPlot/ScottPlot/blob/master/src/ScottPlot/Plottable/Heatmap.cs#L91-L92


mono iOs export produces wrong orientation.

Godot version:
3.2.3 Mono official build.
OS/device including version:
macbook Pro running catalina 10.15,6
Issue description:
have tried with several simple projects and the .ipa isn'tcreated (see issue 45421)
but when running the xcode project produced the graphics in the start scene are displayed sideways
see screenshots:
project in editor:

same project in iphone simulator:

steps to reproduce:

create a simple project  with a viewport that should  fit any modern  iphone display.
select export... from the project menu.
select the ios(Runnable) preset
enter a valid team id, and bundle id
select the  export path to a location outside of the project.
select all the required icons, and screens as per the documentation.
click the export Project button, enter an ipa filename and click save.
open the project in xcode.

expected results:
images displayed in the viewport should  look as they do when running in godot
actual results:
ithe entire viewport  isrotated  ro
tated 90 degrees
Minimal reproduction project:

csharptest_project3.zip

You need to set the orientation to Portrait in the Project Settings, as landscape orientation is used by default.

You need to set the orientation to Portrait in the Project Settings, as landscape orientation is used by default.

its probably worth mentioning that here:
https://docs.godotengine.org/en/stable/getting_started/workflow/export/exporting_for_ios.html
?

its probably worth mentioning that here:
https://docs.godotengine.org/en/stable/getting_started/workflow/export/exporting_for_ios.html
?

i did a quick retry setting the orientation to portrait, but then got an error! (screenshot attached)

i did a quick retry setting the orientation to portrait, but then got an error! (screenshot attached)

MRP project export is fixed by adding icons and LauchScreen images as described in https://github.com/godotengine/godot/issues/45421#issuecomment-769919492
Incorrect orientation is fixed by selecting correct orientation in Project Settings->Display->Window->Handheld->Orientation right now you have landscape value, so that's what iOS project is using.
It can also be fixed by selecting required orientations on export screen, but the one selected in Project Settings has more priority and should be also selected correctly.

MRP project export is fixed by adding icons and LauchScreen images as described in https://github.com/godotengine/godot/issues/45421#issuecomment-769919492
Incorrect orientation is fixed by selecting correct orientation in Project Settings->Display->Window->Handheld->Orientation right now you have landscape value, so that's what iOS project is using.
It can also be fixed by selecting required orientations on export screen, but the one selected in Project Settings has more priority and should be also selected correctly.

I don't think this is specific to Mono/C# projects. Can any one confirm?

I don't think this is specific to Mono/C# projects. Can any one confirm?

It's not. The reason for this issue is the incorrect orientation in project and export settings.

Should we remove the parameters from the export preset, and improve documentation? I think something similar was done for Android.

If we can get access to ProjectSettings::get_singleton()->get("display/window/handheld/orientation") inside export preset code, it should be pretty simple. As far as I can tell that's exactly what Android does.

The screen orientation has been defined as a string for all this time. For 4.0, I think it's time to move to an enum :slightly_smiling_face:
We'll need a different PR to fix this in the 3.x branch, as we need to keep the string there to preserve compatibility with existing projects. (Nothing major needs to be changed by the users, but people may still be surprised to see their project revert to the default orientation after upgrading.)


feat: add privacy settings to organizations to selectively show logs publicly

The idea is to let people show their logs, so anyone in the organization and outside the organization can see the hours they make

@NazarenoCavazzon  so would this be a boolean property inside the user document?


Remove memlock

Fix https://github.com/merbridge/merbridge/issues/172
@tanjunchen has verified.

Codecov Report

Merging #300 (ae19ba9) into main (43386c4) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ae19ba9 differs from pull request most recent head 408ceab. Consider uploading reports for the commit 408ceab to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   32.87%   32.87%
=======================================
  Files           7        7
  Lines         514      514
=======================================
  Hits          169      169
  Misses        331      331
  Partials       14       14

Flag
Coverage Δ

unittests
32.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dddddai need re-approve...


README is missing Spark Logo

Describe the bug
README.md is not displaying the Spark Logo
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/inland-empire-software-development/spark
Scroll down to README

Expected behavior
Show the spark logo
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] : Windows
Browser [e.g. chrome, safari] : Chrome
Version [e.g. 22] : I don't know

Smartphone (please complete the following information):

Device: [e.g. iPhone6] : Samsung Galaxy 6
OS: [e.g. iOS8.1] : Android
Browser [e.g. stock browser, safari] : Chrome
Version [e.g. 22] : I don't know

@RA1990  is this something you can tackle? Thanks!

on it

Thanks, @RA1990 - assigning the task to you - thanks!

Thanks @RA1990 looks like this has been merged.


Play horn sound

I would like to work on this

Ok, go ahead. If you need any help, contact me on discord.


Add 3D secure (cherry pick 48440c)

This is simply adding support to :three_d_secure_pass_thru params for
Braintree, documented here: https://developers.braintreepayments.com/reference/request/transaction/sale/ruby#three_d_secure_pass_thru

Loaded suite test/remote/gateways/remote_braintree_blue_test
Started
....F
=========================================================================================================================================================================
     206:
     207:   def test_avs
     208:     assert_avs("1 Elm", "60622", "M")
  => 209:     assert_avs("1 Elm", "20000", "A")
     210:     assert_avs("1 Elm", "20001", "B")
     211:     assert_avs("1 Elm", "", "B")
     212:
test/remote/gateways/remote_braintree_blue_test.rb:209:in `test_avs'
test/remote/gateways/remote_braintree_blue_test.rb:635:in `assert_avs'
Failure: test_avs(RemoteBraintreeBlueTest):
  Response expected to succeed: <#<ActiveMerchant::Billing::Response:0x00007fa9dcd882f8
   @authorization="5cd31ztm",
   @avs_result=
    {"code"=>"A",
     "message"=>
      "Street address matches, but 5-digit and 9-digit postal code do not match.",
     "street_match"=>"Y",
     "postal_match"=>"N"},
   @cvv_result={"code"=>"M", "message"=>""},
   @emv_authorization=nil,
   @error_code=nil,
   @fraud_review=nil,
   @message="Transaction declined - gateway rejected",
   @params={"braintree_transaction"=>{"processor_response_code"=>"1000"}},
   @success=false,
   @test=false>>
=========================================================================================================================================================================
....................................................
Finished in 129.27538 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
57 tests, 294 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
98.2456% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.44 tests/s, 2.27 assertions/s

One test is failing but in the response there is a correct value. No idea why it fails.

Hmmm ... I'm not sure here ... name of the test sais test_cardholder_name_passing_with_card but when I byebug it, I do not see cardholer's name (neither cardholder_name nor first_ and last_ fields)
   500:   def test_cardholder_name_passing_with_card
   501:     Braintree::TransactionGateway.any_instance.expects(:sale).with do |params|
   502:       byebug
=> 503:       (params[:credit_card][:cardholder_name] == "Longbob Longsen")
   504:     end.returns(braintree_result)
   505:     @gateway.purchase(100, credit_card("41111111111111111111"), :customer => {:first_name => "Longbob", :last_name => "Longsen"})
   506:   end
   507:
(byebug) params[:credit_card]
{:number=>"41111111111111111111", :cvv=>"123", :expiration_month=>"09", :expiration_year=>"2020"}

Good catch @simonx1 . Code for this was added on some point in AM. We currently does not support it. I removed the test.

Cool, sounds good to me @freezepl !


FEATURE REQ:  auto-generate Wiki pages

As discussed on Discord there was a suggestion to make a feature that creates wiki pages based on Warcraft Wiki Editor's Toolkit Chrome's extension .
It would be helpful for Warcraft Wiki editors.
Thanks

Definitely something I wanna look into but not exactly sure how much work it'll be - needs investigation.


Added low watermark metric

This PR is to address issue #9.

Merging to avoid conflict with implementation of https://github.com/braedon/prometheus-kafka-consumer-group-exporter/issues/8. Will do the doc/README changes myself once merged.

Thanks @braedon , sorry I haven't gotten to changing your suggested edits.  It was on my task list for this week.

All good!


Add support for LM from transformers

Hi, want to say that You implemented a great package
It's block structure lets to assume that except of LanguageModel it can support many others
For example adding support for AutoModelForCausalLM will extend it to numbers of awailable models from huggingface
From GPT2, OPT to BERT and XGLM

In transformers score called perplexity(PPL)
Here is the guide for to calculate PPL from AutoModelForCausalLM output

Am I right that I can do it by my own by just initializing BeamSearchDecoderCTC with custom AbstractLanguageModel instead of using build_ctcdecoder?

Hey @Theodotus1243! Here's a guide on how you can integrate a pyctcdecode n-gram beam scorer with a Wav2Vec2CTC model from 🤗 Transformers: https://huggingface.co/blog/wav2vec2-with-ngram

@Theodotus1243
Have you had any success with using a neural LM with pyctcdecode?
Do you have some code you can share?


Rename some sbt-dependency-graph keys

Fixes https://github.com/sbt/sbt/issues/5894

even not considering the name clash issue, this is an improvement :+1:


Simplify TF get_output_names

replaced keys() + get(k)' with values()`
removed unnecessary set-to-list conversion

cc @srkreddy1238  @zhiics

@yzhliu Could you review and merge this PR?


Fix typo in https://www.tensorflow.org/datasets

At the web page https://www.tensorflow.org/datasets need to fix typo in 'datasets' in

There is no tf.data.Datasets it's tf.data.Dataset with no s at the end.
thanks.

@gpokat,
Thank you for the issue. The document states that All datasets are exposed as tf.data.Datasets  in this case, it seems to refer to multiple datasets simultaneously. Also when trying to access information about tf.data.Datasets leads to the documentation for a correct tf.data.dataset API, which might not be the issue.
Meanwhile I will try to check with developer team and provide more information. Thank you!

Thanks for fast response. I understand that the link leads to the correct Class and to correct page, but in the text it's highlighted like class instance with incorrect name (bold blue) which is confusing.

@gpokat,
The file which you mentioned is the auto-generated file which will be changed for the every tensorflow version release.
I suspect the mentioned typo error also might get changed in the upcoming releases. Thank you!

Thanks for your consideration and fix!

@gpokat,
Could you please feel free to move this issue to closed status. Thank you!


Evaluate/updatePolicyManager

While working on #357 I noticed the UA based adaptive directive logic is outdated and it may need an update.
According to MDN's CSP compatibility table, most browsers have caught up to CSP Level 3, with some minor differences.
With current browser support for all CSP levels, the UA based adaptive approach may no longer be needed altogether?

I am not sure about that.. It indeed seems to be a bit too rudimentary, either we should check exact browser versions or we should probably drop this as all latest browsers are fine with Level 3. I guess the question is what's the risk? If directives are ignored it's probably fine, as long as it doesn't break older browsers. Level1 fallback stuff I would probably still keep it tho as it otherwise makes sites unusable on older browsers if you include nonce etc.


Add ability to move time

Is your feature request related to a problem? Please describe.
Sometimes I need to restart the pc in order to continue the job, then I need to start pomodoro from start again.
Describe the solution you'd like
With a timer (youtube video bar like) I can continue the timer from where it was

the bar below the timer, can be clicked anywhere
Describe alternatives you've considered
An alternative to the option above, is clicking inside a position of the timer circle:

in the image above for example, if you click where the red arrow is, the timer will go to that place!

It might make more sense to store the time in browser data. As long as the browser is properly closed and not force closed, it should remember the timestamp it starts at to resume when the app is re-opened. It would also resolve any issues if you have to close and re-open the app for any reason.

I'm not using browser version, I'm using the standalone on linux!

I feel making the time easily editable would make it too easy to accidentally alter it for the typical user.

this can be easily workaround asking "are you sure" to the user.

I would really like this feature. My pain point is I frequently forget to start the timer, and, by the time I notice, 5-10 minutes have already passed. Changing the config every time gets a little tedious.
I think the best solution would be a little knob on the timer circle. Dragging that knob would extend/shorten the time for this cycle. It doesn't have to be precise. This knob would appear only when the user is hovering over the circle, so accidental changes should be rare. Maybe only allow to drag the knob if the timer is paused?
Visually it would look similar to this (Forest app):

Currently looking into changing the underlying framework but this would be a good usability change.
Your example on how to reduce the mistakes would work pretty well.


fix(refactor): hoist CreateContentMenu into react-forms

Closes #1807
This PR will hoist CreateContentMenu into react-forms so that we are not duplicating it in react-sidebar and react-toolbar

@dwalkr this PR addresses the component refactor, but not yet the issue with the form button not being disabled with failing validation on any field.
I'm seeing that behavior across Tina, not only within the content creator plugin, so curious I should address it here, or via a different PR.

I'm seeing that behavior across Tina, not only within the content creator plugin, so curious I should address it here, or via a different PR.

Separate PR is fine. Minor nitpick but I recommend rebasing/amending this to a chore instead of a fix; refactors don't need to show up in the changelog


Performing 2d SLAM using cartographer_ros with Scanse Sweep lidar

Hi All,
I am trying to perform 2d SLAM using cartographer_ros with Scanse sweep lidar (2d). I have installed the sweep_ros and this allowed me to get point cloud from Scanse sweep lidar and view it. Then I installed cartographer_ros and ran the demo bag file, cartographer is working fine too.
Now I want to perfrom SLAM with cartorgapher_ros  using sweep_ros. The launch file, urdf and lua files used can be found in the below github link
https://github.com/mahendranicl/Scanse-sweep_ros-config-urdf-and-launch-files-for-cartographer_ros
However, unable to perform slam and getting error messages. The history can be found in the above github link (filename - error)
error message
..."]:33: attempt to index global 'SPARSE_POSE_GRAPH' (a nil value)ailed: status == 0 (2 vs. 0) [string "include "map_builder.lua"
..."]:33: attempt to index global 'SPARSE_POSE_GRAPH' (a nil value)ameter_dictionary.cc:83] Check failed: status == 0 (2 vs. 0) [string "include "map_builder.lua"
then
[cartographer_node-5] process has died [pid 19664, exit code -6, cmd /home/mahendran/catkin_ws/install_isolated/lib/cartographer_ros/cartographer_node -configuration_directory /home/mahendran/catkin_ws/install_isolated/share/cartographer_ros/configuration_files -configuration_basename sweep.lua __name:=cartographer_node __log:=/home/mahendran/.ros/log/f7bbfdba-449c-11e8-b606-a782b0d5ce85/cartographer_node-5.log].
log file: /home/mahendran/.ros/log/f7bbfdba-449c-11e8-b606-a782b0d5ce85/cartographer_node-5*.log
I kindly request you all to help me resolve this. Maybe there is an issue with the codes I am using or haven't pasted the files in the proper place or maybe I am doing something wrong somewhere. Please help and any help is much appreciated.
Thanks

SPARSE_POSE_GRAPH has been renames to POSE_GRAPH a few months ago.
Make sure you use the latest versions.
Update your config:
https://github.com/mahendranicl/Scanse-sweep_ros-config-urdf-and-launch-files-for-cartographer_ros/blob/master/sweep.lua#L33
Hope this helps.

Hi gaschler,
Ah, ok. Very useful. Done it, but getting the following error now
error message
F0420 15:03:58.366683 21814 lua_parameter_dictionary.cc:410] Check failed: 1 == reference_counts_.count(key) (1 vs. 0) Key 'scans_per_accumulation' was used the wrong number of times.
[FATAL] [1524233038.366955371]: F0420 15:03:58.000000 21814 lua_parameter_dictionary.cc:410] Check failed: 1 == reference_counts_.count(key) (1 vs. 0) Key 'scans_per_accumulation' was used the wrong number of times.
then
[cartographer_node-5] process has died [pid 21814, exit code -6, cmd /home/mahendran/catkin_ws/install_isolated/lib/cartographer_ros/cartographer_node -configuration_directory /home/mahendran/catkin_ws/install_isolated/share/cartographer_ros/configuration_files -configuration_basename sweep.lua __name:=cartographer_node __log:=/home/mahendran/.ros/log/ab34dfb4-44a3-11e8-b59b-54e1ad75622a/cartographer_node-5.log].
log file: /home/mahendran/.ros/log/ab34dfb4-44a3-11e8-b59b-54e1ad75622a/cartographer_node-5*.log
Thanks

In November '17 we renamed scans_per_accumulation to num_accumulated_range_data. I think it is easier in your case to start with a tip-of-tree config file, e.g. backpack_2d.lua, and modify that to suit your needs.

Hello All,
Changed the config files and 2d slam was working fine. Until recently I noticed my map (RVIZ) spinning out of control and I switched my LIDAR (luckily have 3) and it worked fine. Then again today the map is spinning out of control i.e. with my replacement lidar too ! Any ideas ?

closing, as inactive for a long time


Make demand elasticity syntax consistent with production

The demand block elasticity is an optional keyword, as the last argument, but elasticities for the production functions are the 3rd argument, with nest level identifiers. They should be consistent to limit user confusion and error.
It was also mentioned that needing 2 begin/end statements in demand is inconsistent and not ideal.

#170 gets us closer to this. I'm not certain how to handle the demand elasticity keyword.

Here is one idea: Force consumers to demand a single commodity.
If a consumer demands more than a single good, these demands get moved to the input of a production block which outputs a new commodity, demanded by the consumer.
Tom mentioned this offhandedly, and it would do a couple of nice things:

Solves this issues by moving the elasticity to a production block. Demand blocks would no longer require elasticities
Simplifies the backend code required for demand block. Currently this is duplicated between production and demand blocks.

Any thoughts @EliLazarus?
For context, MPSGE.GAMS supports arbitrary nestings in demand blocks, which we are already disallowing. We could support this method instead if it's preferred, but it would require a larger rewrite of the code base.


Compatibility Improvements

:tada: This PR is included in version 4.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Wrapper component in SPAN

Is possible i wrapper my component in span instead div?

@BrunoQuaresma Why would you do that? Check the react docs if that is possible. I don't think it is. I'd recommend just configuring the styling of the div to act like a span. You can do that.

In react-rails gem has the option
html_options: { tag: 'some-tag' }
but this option render something like:

when i expected

So, the solution that i found was change the style inline:
<%= react_component("ButtonApp", props: {
            id:"referral-action-button",
            label: publisher_decorator.action_button_description,
            btnType:"primary",
            type:"button",
            size: "sm",
            isDisabled: false,
            style: "btn-raised",
            secondaryStyle:"js-next-phase",
          }, html_options: { style: "display:inline-block" }) %>

Hi @BrunoQuaresma, I updated the README.md.

Thanks @justin808 !

Hi all,
thanks guys for this gem!
@BrunoQuaresma @justin808 I think it would be great to have the ability to choose which element use as wrapper, as react-rails does.
I used the html_options: { style: "display: inline-block"}  but it cannot always work.
Eg: I want to have a react component as an item in a bootstrap navbar-nav, the css rule is:
.navbar-nav > li
With react-rails I always used the tag: 'li' option, with react_on_rails this is not possible and having a div that wraps the component breaks the markup.
What do you think?

@risinglf Please open a new issue if you feel strongly about this. Please include info about why this is worth the extra complexity.

@justin808 Hi, I hit the same issue as @risinglf and I got quite a strong case why such feature is necessary. I render my component enclosed in
...
 tag. As react_on_rails renders in
, it leads to semantically incorrect HTML nesting -
 is not allowed in
 which, in turn, makes the React component rendered as
 outside the
 tag:

I'm forced to change
 to
 in order to have a correct nesting:
. Such change makes the HTML code less accessible for screen readers and bots. There are really good reasons why HTML5 have various tags (p, div, span, strong) to denote different functions of web page elements, not just the way they are rendered. Broken markup also makes SEO difficult.

@argasek I can pair with you on PR to add this. Should be easy to allow an option for that.
If you don't have time for a PR, I can do this for you in the context of our services work.

@justin808 Please review my PR: https://github.com/shakacode/react_on_rails/pull/1208 regarding this. Thanks


Minium Contrast support Added

Minium contrast support added
#135
Description
Added outlines to improve contrast in minimum contrast mode
Checklist for Pull Requests

[x] Supplied as many details as possible on this change
[x] Included the link to the associated issue in the Issue section above
[x] The code conforms to the general development guidelines.
[ ] The code has unit tests where applicable and is easily unit-testable
[x] This branch is appropriately named for the associated issue

@sanat-thukral Do you want to add a changeset?

Thanks Christos, forgot about that 😅


Load order for .env.*.[extended] files.. - use -f flags in order you desire

Notice the load order: .env.staging.local, .env.staging.build, .env.staging, .env.staging.build.local
dependencies:
+ @dotenvx/dotenvx 1.32.0

Done in 12.7s
$ >>.env.staging
$ >>.env.staging.local
$ >>.env.staging.build
$ >>.env.staging.build.local
$ DOTENV_PRIVATE_KEY_STAGING= DOTENV_PRIVATE_KEY_STAGING_LOCAL= DOTENV_PRIVATE_KEY_STAGING_BUILD= DOTENV_PRIVATE_KEY_STAGING_BUILD_LOCAL= \
  dotenvx run -- echo
<EMAIL_ADDRESS>injecting env (0) from .env.staging.local, .env.staging.build, .env.staging, .env.staging.build.local

Instead, should this be: .env.staging.build.local, .env.staging.local, .env.staging.build, .env.staging?
Loading all the .local files first is consistent with the more common case:
$ >>.env
$ >>.env.local
$ DOTENV_PRIVATE_KEY= DOTENV_PRIVATE_KEY_LOCAL= DOTENV_PRIVATE_KEY_STAGING= DOTENV_PRIVATE_KEY_STAGING_LOCAL= \
  dotenvx run -- echo
<EMAIL_ADDRESS>injecting env (0) from .env.staging.local, .env.local, .env.staging, .env

dotenvx respects the order of your private keys when set on the command line that way. Adjust your order and they should load appropriately to how you desire.

closing but let me know if adjusting that does not work. Alternatively, you can use multiple -f flags to denote order.

from your example they are. can you be more descriptive please. where are you setting them?

The environment variables appear before the command and do not appear in process.argv.  Dotenvx does not have any way to determine order so it must use logic to do that.
It is smart enough to replace the last '.' in .env.staging.build with an underscore (..._STAGING_BUILD) so it appears that this is the supported method, additionally you get into trouble if you try to use '.' in environment variable names (probably why dotenvx does this).  So, it appears that it was coded properly when only one level deep, but that multiple levels are only partially supported so I'm thinking this is an issue.

Since load order matters, this should be deterministic and load most specific to least specific (e.g. loading .env.staging before .env).

ok, i dug into this and it is different than I remember:

dotenvx can NOT determine order via DOTENV_PRIVATE_KEY* before the command. This is not a limitation of dotenvx but a limitation of how operating systems handle environment variables (unordered hash table) and how shells parse them as well. They are not guaranteed in either case and so cannot be relied on. (On my particular machine, taking your example, DOTENV_PRIVATE_KEY_STAGING ended up toward the end of my env but the others ended up almost at the beginning. 🤷
because of this limitation you must use -f flag. That guarantees order. For example, you can do this:

DOTENV_PRIVATE_KEY_STAGING= DOTENV_PRIVATE_KEY_STAGING_LOCAL= DOTENV_PRIVATE_KEY_STAGING_BUILD= DOTENV_PRIVATE_KEY_STAGING_BUILD_LOCAL= dotenvx get -f .env.staging -f .env.staging.local -f .env.staging.build -f .env.staging.build.local

Loading all the .local files first is consistent with the more common case:

Where does this concept come from? Is there a web framework you are using that recommends this? Can you let me know which?

Loading all the .local files first is consistent with the more common case:

Where does this concept come from? Is there a web framework you are using that recommends this? Can you let me know which?

No, I saw it in dotenvx and thought it was intentional!  Lol.  It worked out so well though, I'm attached to this now.  Just load most specific to least specific with .local being the most specific (.local has to be that way, the purpose of local is to overwrite things for the machine and not check it in).
I intentionally did not go the -f flag for this use-case because there are layers of programs starting each other (like docker's CMD -> dotenv -> npm -> vite -> vite based kit -> code).  It is just way more difficult in these setups to deal with parameters when the parameters need to change per environment.  For example, trying to get info into node without messing up other environments or complicating the startup can be next to impossible without NODE_OPTIONS to save the day.  Another example are docker deploys like Dokku, Heroku, etc. support environment variables already, so it is always nice to have less configuration to do when it comes to launching the programs in their environment; additionally, launching them depends on where in the launch stack you are and how they are handling command line parameters (npm scripts have quarks when it comes to some types of arguments for example).  I tend to give up if I have to make it that complicated.  Parameters may still be used, but for the main environment, I much prefer trying to keep it simple and only to available environment variables.
The logic for deterministic loading can be reasonably simple.

most specific to least specific
ALL .local are the most specific of all
extended depth determines specificity (.env.staging.build is more specific than .env.staging)
if specificity is equal, sort

The last one: sort leaves more to be desired.  However, consider that is probably always better to do something here rather than nothing and leave the behavior non-deterministic.  Postgres uses this approach with its triggers.  If trigger order is not clear, they execute in sort order.  So, there should never be a case when you don't know what order something is going to happen (needs to be deterministic).

The logic for deterministic loading can be reasonably simple.

I disagree given how complicated this is getting with 4 to 5 different files.
The logic for deterministic loading can be reasonably simple.

most specific to least specific
ALL .local are the most specific of all
extended depth determines specificity (.env.staging.build is more specific than .env.staging)
if specificity is equal, sort

that is the opposite of simple. it requires a lot of knowledge for the beginning user to hold in their head. the beauty of dotenv was always a simple single file and I do my best to continue that legacy.

it is always nice to have less configuration

Indeed. I'm a big proponent of this which is why I personally recommend against multiple .env files for almost a decade. I acknowledge now there is a good use case per environment but I'm still greatly against *.local and other complications.
So I'm not going to implement this. Use -f for your needs if you want to continue using such a setup. Otherwise, I recommend consolidating to simple .env.${environment}. It is not a bad thing to duplicate values across environments. And user's who need to override a a database url for example locally can then use just one single .local and customize their dev load command to additionally add that via -f .env.local. I'm highly recommend against using .local for any environments except dev .env.
Thank you for your thoughts, but I won't be implementing any of this. Others are welcome to add their thoughts on this closed issue in the future and I will consider them. My own tastes can change over time as I experience more, but keep in mind I'm very allergic to complexity and configuration. My goal is to minimize so that dotenvx will always be the simplest alternative to secrets on the market.