issue #222

attempt at #222

So, in this case, I'd add an explicit test, similar to modules/codegen/src/test/scala/core/issues/Issue126.scala, that encapsulates what you hope to see out of your change. Diffing the output of current master against this branch yields the following:
 package issues.issue222.server.http4s.definitions
 import io.circe._
 import io.circe.syntax._
 import io.circe.generic.semiauto._
-case class Request(state: Option[BigInt] = None, id: Option[String] = None) extends RequestFields
+case class Request(id: Option[String] = None)
 object Request {
   implicit val encodeRequest = {
     val readOnlyKeys = Set[String]()
-    Encoder.forProduct2("state", "id") { (o: Request) => (o.state, o.id) }.mapJsonObject(_.filterKeys(key => !(readOnlyKeys contains key)))
+    Encoder.forProduct1("id") { (o: Request) => o.id }.mapJsonObject(_.filterKeys(key => !(readOnlyKeys contains key)))
   }
-  implicit val decodeRequest = Decoder.forProduct2("state", "id")(Request.apply _)
+  implicit val decodeRequest = Decoder.forProduct1("id")(Request.apply _)
 }

which I assume is not your goal. I presume your intent would be to preserve all the keys, just to get rid of the object inheritance, which your PR does partially, just needing a bit more massaging to get to where it needs to be.
Some considerations:

What happens if there are multiple $refs?
What happens if there are multiple object literals?
What happens if the allOf contains an object literal that itself has an allOf?

Not all of these need to be solved right now, I'm very much in favor of accomplishing primarily what is necessary to unblock consumers, but without consideration, it's very easy to implement something that will not be forward source-compatible.
Again, sorry for having blocked you; I'm interested in helping unblock this feature request, so feel free to ask any follow-up questions here.

this is complex :( I added the test and you are correct that behaviour is not correct ... i will keep trying :/

so i made some progress, but dropwizzard is still failing

WOOOO! I can't believe it I made the tests pass 🎉

I think i addressed all questions / comments for this PR ... are there any changes needed before this can be merged?

Right ... i will try to fix the issues you found tomorrow ... thanks for
the heads up
On Wed, May 1, 2019 at 12:32 AM Devon Stewart<EMAIL_ADDRESS>wrote:

@blast-hardcheese commented on this pull request.
In modules/codegen/src/test/scala/core/issues/Issue222.scala
https://github.com/twilio/guardrail/pull/234#discussion_r279961383:

compare(request.tpe, expectedRequestTpe)
compare(request.cls, expectedRequestCls)
compare(reqEncoder, expectedRequestEncoder)
compare(reqDecoder, expectedRequestDecoder)

val expectedFieldsTpe = t"""RequestFields"""
val expectedFieldsCls = q"""case class RequestFields(state: Option[BigInt] = None)"""

val List(fieldsEncoder, fieldsDecoder) = requestFields.staticDefns.definitions

val expectedFieldsEncoder =  q"""

    implicit val encodeRequestFields = {

      val readOnlyKeys = Set[String]()

      Encoder.forProduct1("state")((o: RequestFields) => o.state).mapJsonObject(_.filterKeys(key => !(readOnlyKeys contains key)))

Ah, my apologies -- I encountered the error I mentioned below, and I was
hasty in looking for an example of the undesired behaviour in what you
already had here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twilio/guardrail/pull/234#discussion_r279961383, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAYMHUQ3YCUXDUYTFN55ULPTDCIXANCNFSM4HFQVRAA
.

ok so this one was a doozy ... anyways, i added two more test cases, hopefully fixing your concerns ...
I fixed it but im not really sure why the original logic was the way it was (basically taking just last object from composed schema ... perheps bug and not intentional?
I also added some error handling - guardrail will now fail with error message in case some composed object references definition that does not exist (i wasted like 30 minutes debugging this case when fixing one of those tests i added so i added this validation/error reporting)
Let me know what you think!

@kelnos Brain, i know this is not your issue but the changes you merged yesterday broke this PR...
You seem like the guy that's mostly working on jackson stuff, how do you feel issue #222 should be compiled for Java? Basically it's this hierarchy: https://github.com/twilio/guardrail/blob/20ad1f605006e24f2a5a42c075e672b6b81408cf/modules/sample/src/main/resources/issues/issue222.yaml

@tomasherman I know OO is somewhat controversial, but my opinion here is to implement these as class hierarchies and not flatten them out, for Java at least.
A lack of discriminator just means that the spec author doesn't need polymorphic deserialization, but that doesn't say anything about how the user wants to use the generated classes.  Perhaps they've created a hierarchy intentionally and intend to exploit use of the base class so they can operate on all the classes generically?  I'd rather not take that possibility away.  For people who don't care, the interface to create and interact with the objects is the same either way, so there's no loss to usability by maintaining the hierarchy.
I think this is less an issue in Scala for some hand-wavy ill-defined reasons around programming philosophy, but I'm pretty happy with the behavior I've arrive at with Java/Jackson.

Fair enough, however the generated code for the scenario i submitted above won't compile
The problem is that both Request and RequestFields have static method builder() ... and in Request the types don't match (you can see the output of travis job) ... do you have an opinion how to solve this?

@tomasherman sorry, just a sec -- speaking offline with @blast-hardcheese & realizing I was missing context around why your change is being made.  Agree that we need to flatten things out in the case where the swagger spec specifies multiple inheritance.
Unfortunately it's not super simple.  Reverting my Jackson PR probably won't help, as the old code was garbage at dealing with polymorphism, so I'd expect your new test cases to fail with that code as well.  I'm going to attempt to get the Jackson code generating flat objects for the mutiple-inheritance case over the next couple hours.    Otherwise we'll cut a release with what's in master now, and I'll continue working so we can get these changes out in the next release.
Really sorry that I hadn't kept tabs on your work well enough to realize we'd be affecting each other and should have been coordinating.

Ok, above PR referenced should make Jackson behave properly.  I'm going to try to merge our branches together to see if we actually end up with something that works for everything.

So my test spec doesn't actually build for scala with your branch merged in.   To overcome this limitation, use extractors to pattern match on non-leaf nodes.
[error] case class H(g: Option[String] = None, h: Option[String] = None) extends F with G
[error]            ^
[error] /home/brian/src/twilio/guardrail/modules/sample-akkaHttp/target/generated/polymorphismMultipleInheritance/server/akkaHttp/definitions/H.scala:9:81: class G needs to be a trait to be mixed in
[error] case class H(g: Option[String] = None, h: Option[String] = None) extends F with G
[error]                                                                                ^
[error] /home/brian/src/twilio/guardrail/modules/sample-akkaHttp/target/generated/polymorphismMultipleInheritance/server/akkaHttp/definitions/H.scala:9:12: case class H has case ancestor polymorphismMultipleInheritance.server.akkaHttp.definitions.G, but case-to-case inheritance is prohibited. To overcome this limitation, use extractors to pattern match on non-leaf nodes.
[error] case class H(g: Option[String] = None, h: Option[String] = None) extends F with G
[error]            ^

Thanks for the effort! I think it's definitely worth fixing ... i will take look at this over the weekend and try to implement this properly, but if im not able to, can we agree to merge what i've done here? It's strictly better than what is curently implemented in guardrail and it will allow us (avast) to use it in our usecases and we can contribute further improvements along in the future

Merging this now, further bugfixes for https://github.com/twilio/guardrail/pull/234#issuecomment-488861156 can be in future releases. Better to have the new functionality and iterate on what we have for now.
Again, thank you for your diligent work on this PR!

Sweet! Thank you guys! Or next contribution will probably be attempt at
validations
On Fri, 3 May 2019, 21:29 Devon Stewart<EMAIL_ADDRESS>wrote:

Merged #234 https://github.com/twilio/guardrail/pull/234 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/guardrail/pull/234#event-2318278050, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAYMHRUGNRWXKHZ3WZOMRLPTSG7ZANCNFSM4HFQVRAA
.


Possible fix for issue #149 "Brightness does not match"

Apperently the value returned is "1000" and not "255" so dividing by 255 gives false value, also sometimes the value returned is actually the real number 0...100 in that case use that.

Thank you for this PR it is much appreciated!
However in the current form it will not work.
Take for example the case of a light that reports the brightness from 0 to 1000.
What happens when that light is 9% on? the reported brightness will be 90.
90 < 100 thus it will be treated as brightness on a scale from 0 to 100 and be reported as 90% brightness.
We might need to add a configuration value for this for users to input their max brightness.

Thank you for this PR it is much appreciated!
However in the current form it will not work.
Take for example the case of a light that reports the brightness from 0 to 1000.
What happens when that light is 9% on? the reported brightness will be 90.
90 < 100 thus it will be treated as brightness on a scale from 0 to 100 and be reported as 90% brightness.
We might need to add a configuration value for this for users to input their max brightness.

You are right of course, i am new to homebridge and didn't know what the solution for that was(90), sounds like the configuration value is a great idea. let's do that

You are right of course, i am new to homebridge and didn't know what the solution for that was(90), sounds like the configuration value is a great idea. let's do that


Use the correct IP for the scheduler URL

Tutorial nicely provides URL for scheduler, unfortunately it is pointing at the wrong host.

Hi @brianm, thanks for your contribution! It looks like your Review Board patch was previously submitted. https://reviews.apache.org/r/18306/ Could you close this pull request?


Fix behavior during crashing of the group coordinator

Fixes https://github.com/klarna/brod/issues/433

Hi @epsylonix ,
This is the partial fix to the problem that you encountered. Thanks for the remarks on the other code review. I took them into account.
Please note that this PR doesn't fix the other problem that you mentioned, about lost commits during shutdown. Fixing it requires some rework of the behavior, which I am planning to do.

Great, thank you very much!
Regarding the dropped offset acks issue - maybe it could be resolved in a similar way brod_group_coordinator does it here?
By the way, brod_group_subscriber_v2 should probably receive all acks and commit those offsets when partitions are revoked (and before the new ones are assigned), because it seems that otherwise those acks could be later ignored and those messages could be read again by new workers that would receive those partitions after the rebalance.

Yes, that's the way it should be done. Although technically I would prefer to migrate to gen_statem behavior instead of sending control messages to the process.

Maybe there is even an easier way to solve both of those problems - brod_group_subscriber_v2 passes a commit function to the worker, so maybe of just casting the ack to itself from that function it could be possible to do everything brod_group_subscriber_v2:handle_cast({commit_offset, ...  does right away from that commit fun? As far as I can see, brod_group_subscriber_v2 is not changed in there, Coordinator pid doesn't ever change, the GenerationId could change but if I'm not sure a worker started with old generation id should be allowed to commit any offsets (or process any messages :) ) because otherwise it would defeat the purpose of GenerationId. If this could be done then it seems like brod_group_coordinator would take care of those acks without any modifications.
I'm not sure if this wouldn't result in some sort of a deadlock though, I'm not very familiar with the code.

Yes, I was also thinking that proxying the commit messages through the subscriber process probably could be avoided.

P.S. I think I remember now why this proxying was implemented. The reason is not strictly related to any deadlocks, rather to the initialization process. The function for performing asynchronous commit is implemented as a closure that, among other things, has to ask the consumer process for more data. In order to do that, it needs to know its own pid. So the fix would be to introduce a two-stage initialization process. Thankfully, now I realize that should not complicate the startup of the worker process, and it can be done via pure code.


Add option to ChatMessage5e to prevent grouping damage parts by type

All that's needed here is a simple conditional check that skips the aggregateDamageRolls() function call in _enrichDamageTooltip() and uses the full roll array that's given in the parameters instead of creating its own with aggregated rolls. It's a relatively trivial change comparatively, the only work would be making sure it is correctly passed in via options.

Originally posted by @MangoFVTT in https://github.com/foundryvtt/dnd5e/issues/3199#issuecomment-2020702042

Looks like this is the same request, minus the coding specs from the thread i created. I see you commented there as well and are quoting mango: https://github.com/foundryvtt/dnd5e/issues/3199
It was marked as "wont change". Hopefully this gets implemented so at least modders are able to utilize that function.
Thanks for following up on the topic!

I installed 3.3.0 and can't seem to find this config option anywhere. Anyone know where it is?

Via the CONFIG.DND5E object, programmatically. To follow up, and for all general questions about using the system, head over to the #dnd5e channel on the Foundry discord.

So adding this CONFIG is a good step to closing this ticket, but it doesn't actually do anything as implemented in #3769, because the tooltip itself doesn't care about the aggregated/non-aggregated damage roll array and simply does its own aggregation by damage type.
I've made a PR to actually use this CONFIG options intended, which will actually fix this issue: #3885


Cold boot/warm boot update names

@macpijan I guess this one needs rebase.

@BeataZdunczyk we can rebase and merge together with some documentation activities


Training script

[x] - add bf16 support
[ ] - check if training with bf16  weights works fine
[x] - add resuming from ckpt
[x] - add wandb tracking
[x] - complete adafactor option
[x] - figure out how to best utilize profiler for training loop optimization
[x] - add gradient accumulation
[x] - support iterable datasets and max_steps argument
[x] - prefetch generator for dataloader

Casting weights to bf16 is not recommended and removed for now.

here's the gradient accumulation from the vision_transformer codebase:
https://github.com/google-research/vision_transformer/blob/ba9a85bdc430daf4da7b9da67b486a4e0f5bb278/vit_jax/hyper.py#L77
And here's an small example
https://github.com/google-research/vision_transformer/blob/ba9a85bdc430daf4da7b9da67b486a4e0f5bb278/vit_jax/train.py#L63-L66

for gradient accumulation, i have opened a PR: https://github.com/ncoop57/gpt-code-clippy/pull/29
let me know if we can sync up for this

Hello,
what are the minimum hardware requirements to run the training script?

Hi @celsofranssa, the hyperparameters in HF model cards (for example here) are tuned for TPU-v3-8. But you can run the script on GPU adjusting batch size accordingly and mb switching dtype from bfloat16 to float16 for your hardware. Not sure what the minimum requirement would be exactly. You can also  consider decreasing block_size if you run out of memory.


 Nothing out of the ordinary there.
So that we can better reproduce this bug, can you help us out by telling us exactly how you're performing the "remove selection" operation?
Thanks!

Using a right click (two finder tap):

click on a char, right click, char was copied to clipboard.
or
select a number of chars, right click, selected chars are copied to clipboard.

A right click, when there is no selection, will also paste what's on the clipboard, but this is not so critical is it's not usually a destructive operation.

Oh! In that case! Sorry, this is somewhere our documentation is quite lacking.
Right clicking when a selection is active is the premier way to activate copy. We've talked a bit about supporting mouse rebinding (#1553), but it's not in scope for version 1.

(A good way to clear the selection is Esc, but that's also not terrifically discoverable.)

With copyOnSelect set to false, I would expect this to be disabled. I am constantly loosing critical content from from clipboard due to accidentally tapping on the touch pad.
This is even more of an issue when a single tap will select a single char or even white space.

copyOnSelect controls whether the selection is stored to the clipboard when it is selected, as opposed to making it require affirmative assenting action (right clicking, Ctrl+Shift+C).
I agree with you about single character selection making this worse, but we get shouted at on the regular when we try to take away that specific feature. ☹

OK, but coming from a MacOS/Linux background, trying out windows with WSL2, this is just not expected behaviour.
I even went so far as to try out Hyper terminal to avoid this issue, but whilst it doesn't have this problem is has other issues.

Thanks for the feedback about your expected behavior. We're happy to continue the discussion about our boundary between expected/desired and how that plays off of users' understanding of the legacy Windows console here, but I'm going to close the issue since it seems like it was resolved.
Sorry :smile:


[FEATURE] Support Gemini

work in progress, will be available in the next release, hopefully this/next week

available in 0.25.0


Sanity checks

Group all initial sanity checks together. Check for rsakeys.ini in that function. Show full name of the PID file in error messages.
Enable -Wall and warnings for printf arguments. Use Autoconf Archive macros to check for those features, as they are not universal, but not limited to gcc.

looks good

@jsorg71 looks good = merge ?

I think a 2 day wait for complaints is a good rule of thumb, unless it's obvious.


e2e CI jobs should retry to create the deployment namespace

Describe the bug
e2e tests sometimes fail to create the namespace where Ceph-CSI will be deployed. When this happens, the tests will not start to run at all.
The output will look like
+ ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no<EMAIL_ADDRESS>'kubectl create namespace '\''cephcsi-e2e-1f346f7c7e38'\'''
Warning: Permanently added 'n27.dusty.ci.centos.org,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Error from server: etcdserver: request timed out

Expected behavior
etcdserver: request timed out is a common failure where a retry can work later on. The CI script that creates the Kubernetes Namespace should have a way to retry in case of a failure.
https://github.com/ceph/ceph-csi/blob/c90023ad5d9ebf30a06f3e9fd7534aa74be60a24/mini-e2e-helm.groovy#L178
Logs
See https://github.com/ceph/ceph-csi/pull/2277#issuecomment-883447903

Merging https://github.com/ceph/ceph-csi/pull/2378 should have closed this issue(auto-close does not work across branches ?).
Anyway this has been addressed and can now be closed.
Thanks !


What this library implements seems not to be an OAuth "Authorisation Code Grant" standard flow. Please comment.

We are trying to use GitHub as authorisation server for our app called "one".
We are unable to use successfully the browser to retrieve server resources (even though we specify code and state in each request). We are currently able to retrieve resources only using cURL.
There are two major things while attempting to use this library that we cannot find anywhere in the official OAUTH documentations resp. inside available online resources:

we never see any token flowing back and forth between our backend equipped with your library and the browser. On the contrary, we see that apparently the token is "rebuilt" at each GET done by the browser (https://github.com/zalando/gin-oauth2/blob/master/github/github.go#L84)

we do see a cookie "one_session_github" that arrives in the browser after the redirect following the OK given by the user on GitHub. This cookie is mandatory and without it not even our cURL resource requests may succeed.

We are having a real hard time using your library. Can you please help investigating our case?
Thank you for your attention.

A possibly relevant point is that our back-end has a domain name different from our front-end. We had to face some CORS issues in order to get the cookie, but they are now solved.

@Muzietto I am sorry that you have a hard time to use it. I thought it makes sense to have a general implementation and then providers, but the problem is testing all providers is not easily possible.
The colleague that implemented this part is in vacation and I can not ask him what kind of goal he had and what scope he tested.
We did not implemented the "Authorisation Code Grant" flow, we only support checking scopes. I think we do not support really UI flows.

What you write confuses me, because it is your README that at https://github.com/zalando/gin-oauth2#github-based-access explicitly mentions "This OAuth2 flow is also known as Authorization Code Flow".
The link provided in "Authorization Code Flow" sends to https://tools.ietf.org/html/rfc6749#section-4.1, which is indeed the Code Grant thing.

Sorry then I was wrong.
As far as I understand the problem is that the session is not handled correctly.
So the flow works but in a second request the flow starts again.
Do I understand you correctly?


DAWN-488 ⁃ Allow contracts to specify help text

related to #431 and #422 and #419
Motivation
As our tooling improves, many of the system level messages will move away from assert logs (unless -v,--verbose) is specified and into localized human-friendly messages.   However, contracts can and will fail in spectacular ways, and the semantics/pragmatics of these failures will be impossible to deduce from the outside.  For instance, overspending your allotted balance in the current currency contract outputs:
assert_exception: Assert Exception
status_code == 200: Error
: 10 assert_exception: Assert Exception
test: assertion failed: integer underflow subtracting token balance
    {"s":"integer underflow subtracting token balance","ptr":32}
    thread-0  wasm_interface.cpp:377 assertnonei32i32

    {"name":"apply","current_validate_context->msg.type":"transfer"}
    thread-0  wasm_interface.cpp:507 vm_call

    {}
    thread-0  wasm_interface.cpp:568 apply

    {"context.msg":{"code":"currency","type":"transfer","authorization":[{"account":"initc","permission":"active"}],"data":"000000008041934b00000079b822651df401000000000000"}}
    thread-0  chain_controller.cpp:962 apply_message
...<SNIP>...

This messaging is contract defined: https://github.com/EOSIO/eos/blob/da5ce85ae2a146239cc87772c47d128390993d51/contracts/eoslib/token.hpp#L93
While in this instance, the code in question is part of eoslib, in many other cases it will not be something EOS developers directly control.   In some cases, it may not even be a well-defined assert.
Ideally, that messaging would have optional localization as well.
Proposal
As an optional part of the .abi or as an appendix to the .abi we allow for developer specified help text rules and localization.   Currently the format of help text rules is rather fragile so, some thought will need to go into generalizing that system OR formalizing a means of error reporting from eosd -> http -> tools such that tools like eosc can properly determine, localize, and interpolate error messages.
the system should allow for:

contract developers to optionally move the burden of well formed error messages outside of the contract code that lives on chain either by mapping short messages to localized/full messages or by allowing some token to represent messages from a dictionary
localization of error messages
some interpolation/templating of error messages that better handles things like lists of missing permissions

Remaining Questions

[ ] where should this live?
[ ] where should localizations live?
[ ] how crazy with the templating do we need to go?
[ ] what is a more general way of associating error output and context data with an appropriate template? (right now it is regex :barf: )

➤ Bart Wyatt commented:
it is now post production launch 😮


BaseSettings descendants call default_factory on import

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
When importing BaseSettings descendant from another file, default_factory functors are always called for uninstantiated models. See the code snippet attached below. def factory() is called once on import, even though B is not even instantiated.
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.8.1
            pydantic compiled: True
                 install path: /usr/local/anaconda3/envs/dirty_3.9/lib/python3.9/site-packages/pydantic
               python version: 3.9.2 | packaged by conda-forge | (default, Feb 21 2021, 05:02:20)  [Clang 11.0.1 ]
                     platform: macOS-11.1-x86_64-i386-64bit
     optional deps. installed: ['typing-extensions']

The first file (kek.py):
from pydantic import BaseSettings, Field

v = 0

def factory():
    print('factory called')
    global v
    v += 1
    return v

class A(BaseSettings):
    pass

class B(A):
    id: int = Field(default_factory=factory)

class C(A):
    pass

The second file:
from kek import C

Expected output: empty.
Actual output: factory called.
It's also worth mentioning that BaseModel does not have the described behavior, importing the BaseModel descendants doesn't call default_factory functors.

I co-discovered this issue. 100% True

Hi and thanks for reporting
BaseSettings inherits from BaseModel with other defaults for the config including validate_all which is set to True by default.
As explained in the warning section in the doc, to validate the default value of a field, we actually need to call the default_factory.
I guess you could find a workaround in your default factory or set validate_all = False. We could also allow people to not validate values with default_factory
Hope it helps in the meantime

@PrettyWood
Thank you, that works for now. It's still kind of strange though, I believe it should be possible to validate all values (including the default ones) on initialization. Might be better to hide this functionality under some option (validate_on_init), too.

@pomo-mondreganto you're absolutely right! I don't even remember why I did this 🤷 I opened a PR to remove this side effect! Thanks for reporting

I had also missed the warning and had my expectations incorrect.
I would suggest a lazy validation for all fields with a default factory is the reasonably expected way to go. If we are defining a factory it means we will only have the actual data in runtime at some point.
In my case I stumbled into this while writing unit tests: I kept getting validation errors in tests at points in code I was not instantiating a settings object, which got me quite confused until I found out it was being created at import time. I think most of us will agree that running code with side effects in import time is a bad thing.


Fix support for server settings with authentication type "None"

Currently we don't have an AuthType.NONE value that signifies that no authentication should be used (we support this for outgoing servers). The "no authentication" option is currently encoded by using an empty username and password. However, the new server settings screen doesn't properly support this (see https://github.com/thunderbird/thunderbird-android/issues/7524#issuecomment-1968795638).
Instead of making the server settings screen support the existing encoding, I suggest we add an AuthType.NONE value and make ServerSettings.username optional by using the String? type.

This requires changes in the way we import settings files. We currently don't support rewriting old server setting values to a new format.


RequestFetcher doesn't return request

How do you use Sentry?
Self-hosted / on-premises
SDK version
4.8.0
Steps to reproduce
Make any request with body and you won't see body or method in sentry.
The problem is in RequestFetcher which relies on getting request from RequestStack. The problem here is that the RequestIntegration which uses RequestFetcher to get request runs on kernel.terminate. By this time, the RequestStack is empty because the handle method of the HttpKernel pops that request from the stack and terminate is called after handle.
Expected result
Data from request will be logged in sentry
Actual result
No data from request are logged

I started looking into this, we might need to cache the request somewhere early in the live cycle. We do the same in our Laravel SDK, so I think this should work in Symfony as well.

Why caching? Wouldn't be enough to trigger that earlier, i.e. on kernel.request? Or even better, on-demand? We may need to investigate side-effects...

Because we need the data when an error happens (the easy part) and on transaction finish, which happens on kernel.terminate. Hence we store the request early, and have it laying around for the duration of the entire request.

Hey, just wondering how it was working before, cause I have a feeling I have the same issue, which for some reason appears only in prod environment and only on some of the endpoints.
Did it appear on 5.0 release?

I have a PR opened that aims to resolve this: #879.


Add support for Gemini via its OpenAI-compatible API

See full discussion here:
https://github.com/sashirestela/simple-openai/discussions/221
Here is the POC of Gemini in a simple-openai fork:
https://github.com/the-gigi/simple-openai/commit/40fe114eefdf83b589abe27f74a4b20dc1a81138

Gemini API has two implementations:

Vertex AI Gemini API
Google AI Gemini API

See differences here
The PoC is related to Vertex.

@sashirestela I discovered in my experiments with Gemini that sometimes it returns an invalid chatCompletion response where the content field is an array of strings instead of being just a string or null as specified here: https://platform.openai.com/docs/api-reference/chat/create.

This is a bug of Gemini and I'll see if I can reach out to them and get it fixed, but on the simple-openai/cleverclient side I think  we can handle this by adding a response interceptor (similar to the request interceptor). Then, if a response needs to be massaged a little bit to comply with the OpenAI API then it can be done there and the core of simple-openai doesn't need to change to handle incompatible providers.
I noticed it only for tool calls so far (other chat competions return a single string correctly). In this case the array can be merged into a single string.

I reported the bug here:
https://ai.google.dev/gemini-api/docs/openai

@the-gigi I can't see your bug report, I just can see the documentation and a warning saying that the support to OpenAI is still in beta.

@sashirestela I used the "send feedback" form on the page. It is not visible there. I may add it to the developer forum too.
Yes, the API is in beta, but I think it's useful to support it in simple-openai even if some aspects are not implemented yet or broken as in this case. My suggestion for adding a response interceptor will allow fixing these category of problems for any provider.


Feat: Render Community Annotation from Community Annotations Wiki

Goal: If the current gene has an entry in Community Annotations Wiki, render a Community Annotations Tab that displays the information about that gene from the wiki.
Todo:
- [ ] Learn Github GraphQL api
- [ ] Fetch gene data from Community Annotations Wiki
- [ ] Mock up a gene that is in Community Annotations Tab
- [ ] Create Community Annotations Tab
- [ ] Look into using mdx
- [ ] Conditionally render Community Annotations Tab if gene exists in Community Wiki
- [ ] Create and update test cases
- [ ] Percy Visual Tests
- [ ] Component Tests

[ ] Use isomorphic-git package to clone the wiki.

Do everything on browser side.

[ ] Use web worker to do the cloning
[ ] Store cloned repo in a state

Gitter - https://gitter.im/isomorphic-git/Lobby
Example - https://stackblitz.com/edit/isomorphic-git
I've been working on this and have not found a way to clone the wiki using isomorphic-git. I have left a question on the Gitter hoping that they are able to send a working react example.


Add Colours for Drawing

Is your feature request related to a problem? Please describe.
It's hard to explain something without colours, I'm trying to study math and whenever I want to draw function graph, I always miss colours.
Describe the solution you'd like
Add pencil colours

The drawing board already supports using different pen colors. If you go to the bottom right corner, you can click the circle to select and change the pen’s color.

The drawing board already supports using different pen colors. If you go to the bottom right corner, you can click the circle to select and change the pen’s color.

Sorry, my mistake. I thought it was something about pen size. Sorry again.

No worries. Hope this solves everything. Have a great day and keep enjoying Beaver Notes!


How to dispose it?

Since there is no .dispose() on the CustomTimerController, how should it be disposed?
I keep getting:
setState() called after dispose(): _CustomTimerState#f7231(lifecycle state: defunct, not mounted)
      This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback.
      The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree.
      This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().
[log] #0      State.setState.<anonymous closure>
package:flutter/…/widgets/framework.dart:1231
#1      State.setState
package:flutter/…/widgets/framework.dart:1266

CustomTimerController dispose() method was added to the package in version 0.0.5.
It was tested with Navigator. If you get an error, leave it to me here.
Thank you very much for helping to improve this widget! 🚀

Thank you for building the Widget, it's fantastic!
Just saw the update, even when I dispose I get this:
[log] setState() called after dispose(): _CustomTimerState#43155(lifecycle state: defunct, not mounted)
      This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback.
      The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree.
      This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().
[log] #0      State.setState.<anonymous closure>
package:flutter/…/widgets/framework.dart:1231
#1      State.setState
package:flutter/…/widgets/framework.dart:1266
#2      _CustomTimerState._action
package:custom_timer/…/widgets/custom_timer.dart:174
#3      _CustomTimerState._onTimerReset
package:custom_timer/…/widgets/custom_timer.dart:263
#4      CustomTimerController.reset
package:custom_timer/src/custom_timer_controller.dart:59

Can you share the main code fragment where you are getting the dispose error and the CustomTimer widget implementation?

The code:
 Widget _timer() {
    return CustomTimer(
      controller: _timerController,
      from: widget.durationLeft,
      to: Duration(seconds: 0),
      interval: Duration(seconds: 1),
      onFinish: () => widget.onFinish(),
      onBuildAction: CustomTimerAction.auto_start,
      builder: (CustomTimerRemainingTime remaining) {
        return Text('${remaining.hours}:${remaining.minutes}:${remaining.seconds}');
      },
    );
  }

Init:
  final CustomTimerController _timerController = CustomTimerController();

  @override
  void initState() {
    super.initState();
  	_controller = AnimationController(duration: widget.duration, vsync: this, value: 0.1);
    _animation = CurvedAnimation(parent: _controller, curve: Curves.linear);
    _controller.forward();
  }

Disposing:
  @override
  void dispose() {
    _timerController.dispose();
    _controller.dispose();
    super.dispose();
  }


Use autoValidateMode

The latest flutter beta removes autoValidate as an option, use autoValidateMode instead.
Flutter 2.8.0-3.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2901cd7208 (6 days ago) • 2021-11-18 11:15:09 -0800
Engine • revision bcc2b7f12c
Tools • Dart 2.15.0 (build 2.15.0-268.18.beta)

It's already migrated, only #5 has be merged @reidha

Merged


Fix connection in inventory

https://github.com/Wintus/Ansible-WSL/blob/991c18c57944854994d44684680f9f64b5f19b7e/hosts.ini#L4-L5
This connection should be WinRM:
https://docs.ansible.com/ansible/latest/user_guide/windows_winrm.html#inventory-options

Current setting is OK.
Or, winrm gets error:
$ ansible win -m ping
win | FAILED! => {
    "msg": "winrm or requests is not installed: No module named winrm"
}

ansible_host: localhost
ansible_winrm_server_cert_validation: ignore


Stderr not printed live when using utils.call()

When using utils.call(), stderr is not forwarded to the live console (unlike stdout). This can cause issues if a process reports a bug to stderr, but doesn't fail with a non-zero exit code.

Fixed in #44


Add specs + Travis coverage

I am not planning to do this soon, if someone want to submit PR, that would be greatly appreciated.

Hey @jipiboily
Added on https://github.com/QueueClassic/queue_classic-later/pull/9


docker hub page not found 404 on bitnami/elasticsearch-curator

Hi, We faced with an issue that we can't pull the image from https://hub.docker.com/r/bitnami/elasticsearch-curator.
Was something changed?

We have hit the same issue looks like its been depreciated
https://github.com/bitnami/containers/blob/116ec7ab66b1701641a8103196d09d98dc9863df/bitnami/elasticsearch-curator/README.md
Guess override the image in the local values file to one self hosted or move to another image in the chart

I did the following updates to the values to get it to work.
I switched to the image that ES are referring to in their docs
I added this to our values.yaml
image:
  repository: untergeek/curator
  tag: 7.0.0 # <-- Check the tags in the repo. Apparently they are major version locked.

command: ["curator/curator"] # <-- path to binary.


[ar] Fix Kubernetes title spell in ar.toml, and punctuation style nits in Kubernetes basics page

This commit will make two adjustments:

Update the Arabic page title given the new standard transliteration of "kubernetes"
Remove periods from some page titles

/cc @seifrajhi
/assign @mboukhalfa

/approve

I think we cannot approve anything outside the content/ar folder
/lgtm

Following the k8s-ci-robot message above, I'm calling out to @reylejano for approval.
/assign @reylejano

/retitle [ar] Fix Kubernetes title spell in ar.toml, and punctuation style nits in Kubernetes basics page

Thanks all for the progress. Bumping!
/cc @reylejano

/remove-lifecycle stale


Fix Flaky FastHotStuffEventLoop Integration Test

Current dependencies on/for this PR:

feature/proof-of-stake

PR #649

PR #767

PR #769   👈

This stack of pull requests is managed by Graphite.


Out of memory. nodejs using more than 100MB of RAM

Is this normal? I've been running Node.js for a while now and only recently I have used sails. I ran 2 sails instances with sails-mysql, one for HTTP, another for HTTPS. Each of them starts at 75MB+ but quickly goes up to over 100MB and eventually crash due to out of memory :( (I have 512MB)

For future reference, there's more information and tips on diagnosing memory leaks in Node apps, and on reproducing+reporting suspected memory leaks in Sails here: https://github.com/balderdashy/sails/issues/3782#issuecomment-238679052


A set of tests in which the code accomplishes the task

Hello, can you publish the test set of code completion tasks in the repository? Thank you very much

For the code completion task, we assess compilation success rate. The scripts and test cases for compilation evaluation is provided in terminal_compiler.py and test.py located in the ./compiler folder here. Please refer to #7 for more information.


Handle version and option skew errors

Description
These can be thrown if a build daemon is still running when a user runs flutter upgrade, or if  there is another process running in the same directory.

I'd be concerned that a mistake with process killing would be more severe than a tool exit. Plus if most of our users weren't upgrading constantly the odds of hitting these errors are slim


Locking supported via Geode

Hi
I like the library and the different locking mechanism it supports , however was a bit disappointed to not see Geode avaialble considering how easy it is to integrate with it.
I would like to know if anyone is planning to integrate in near future? If no , then I would personally like to contribute for the same.
Also , are we discussing with Spring to integrate as part of their project ?

Hi, thanks, feel free to send a pull-request. Let me know, if you need any help.

PR Raised
https://github.com/lukas-krecan/ShedLock/pull/235
Please review and let me know


Feature/initial step single responsibility principal

Preparation for https://github.com/YAXLib/YAXLib/issues/14
Trying to implement Single Responsibility Principal step by step.
Contains zero functional changes, so should be safe and non breaking.
Only added regions & extracted private methods into other internal classes.
Note: Will require further changes. Some methods have too many parameters, but this should be a next in the right direction in order to make it easier to reduce Cyclomatic Complexity

Codecov Report

Merging #168 (0d4c672) into master (438a1ae) will increase coverage by 0%.
The diff coverage is 91%.

@@          Coverage Diff          @@
##           master   #168   +/-   ##
=====================================
  Coverage      80%    80%
=====================================
  Files          60     62    +2
  Lines        3767   3770    +3
  Branches      726    726
=====================================
+ Hits         2997   3000    +3
  Misses        559    559
  Partials      211    211

Impacted Files
Coverage Δ

YAXLib/YAXSerializer.cs
76% <87%> (-1%)
:arrow_down:

YAXLib/XmlNamespaceManager.cs
88% <88%> (ø)

YAXLib/Helpers/CustomSerializerActivatorHelper.cs
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438a1ae...0d4c672. Read the comment docs.

Cool!
To be clear, only code has been moved, isn't?

Cool!
To be clear, only code has been moved, isn't?

Yes, looks good.


Event image not available in 0.4.2

Hey, in previous versions post like these provided Image medium:

Currently both text and medium are null.

Fixed in 0.4.3.
Please let me know if it's reproducible

@SokoMishaLov
all good now many thanks :)


Hide application URL in managed environment card

Fixes

https://issues.redhat.com/browse/RHTAPBUGS-274
Description

When an environment is configured for BYOC, the URL provided to the user is incorrect in the deployment card.
Note: We dont have a way to show the managed environment deployment route at the moment, so we need to hide this url instead of misleading the users.
Type of change

[x] Bugfix

Screen shots / Gifs for design review

Before:

After:

How to test or reproduce?

Browser conformance:

[x] Chrome
[x] Firefox
[x] Safari
[ ] Edge

/cc @christianvogt


[feature request] Add option to always save image

Is it possible to add a configuration option (boolean true/false) to always save the image, even when no vehicle/people is found?
At the moment the image is written only if detections are greater than zero.
I use the generated image as a local_file camera in HA, so it can be useful to use the latest image to show the updated situation (in a picture-glance card).

I agree I also found it confusing seeing the last image with a detection, rather than the last processed image.
This is a good suggestion

I agree I also found it confusing seeing the last image with a detection, rather than the last processed image.
This is a good suggestion

Sure, I'll try in my spare time.
Is it better to always save last processed image or enable that feature with an additional option?

Sure, I'll try in my spare time.
Is it better to always save last processed image or enable that feature with an additional option?

Add an additional config arg: always_save_latest_jpg which defaults to False, but when True will save the image even if there are zero detections

Add an additional config arg: always_save_latest_jpg which defaults to False, but when True will save the image even if there are zero detections

Add an additional config arg: always_save_latest_jpg which defaults to False, but when True will save the image even if there are zero detections

can you share how to config this? I tried to set this to my configs but got an error.
- platform: sighthound
  api_key: !secret sighthound_key
  save_file_folder: /config/tmp
  save_timestamped_file: True
  always_save_latest_jpg: True
  source:
    - entity_id: camera.garagem

Invalid config for [image_processing.sighthound]: [always_save_latest_jpg] is an invalid option for [image_processing.sighthound]. Check: image_processing.sighthound->always_save_latest_jpg. (See ?, line ?).

Add an additional config arg: always_save_latest_jpg which defaults to False, but when True will save the image even if there are zero detections

can you share how to config this? I tried to set this to my configs but got an error.
- platform: sighthound
  api_key: !secret sighthound_key
  save_file_folder: /config/tmp
  save_timestamped_file: True
  always_save_latest_jpg: True
  source:
    - entity_id: camera.garagem

Invalid config for [image_processing.sighthound]: [always_save_latest_jpg] is an invalid option for [image_processing.sighthound]. Check: image_processing.sighthound->always_save_latest_jpg. (See ?, line ?).

It's not merged to the official integration, I made a pull request.
If you want to try it you have to download the code from my fork and put the folder custom_components/sighthound in your HA /config/custom_components directory and restart Home Assistant.

It's not merged to the official integration, I made a pull request.
If you want to try it you have to download the code from my fork and put the folder custom_components/sighthound in your HA /config/custom_components directory and restart Home Assistant.

I have a problem if always_save_latest_jpg isn't set. Default behaviour if it isn't set should override existing latest pic with detection pic, correct?
But if it isn't set, nothing is overidden, I have to set it explicitely to "false", so I have the latest motion detected pic.


Fix OSError: preprocessor_config.json #1097

Fix OSError: /content/stable-diffusion-V2 does not appear to have a file named preprocessor_config.json. #1097

add it also for the 768


Not working in React native

I installed nsfwjs in react native.
after installation without importing and using app runs but
after:
import * as nsfwjs from 'nsfwjs';
and
await nsfwjs.load()
This error is shown.
`Error: Unable to resolve module path from /Users/muhammadowais/workspace/datingapp/node_modules/get-pixels-frame-info-update/dom-pixels.js: path could not be found within the project or in these directories:
node_modules/get-pixels-frame-info-update/node_modules
node_modules
../../node_modules
If you are sure the module exists, try these steps:

Clear watchman watches: watchman watch-del-all
Delete node_modules and run yarn install
Reset Metro's cache: yarn start --reset-cache
Remove the cache: rm -rf /tmp/metro-*
1 | 'use strict'
2 |

3 | var path          = require('path')
|                              ^
4 | var ndarray       = require('ndarray')
5 | var GifReader     = require('omggif').GifReader
6 | var pack          = require('ndarray-pack')`

[1 ] Then I just installed :

npm install path
Error: Unable to resolve module assert from /Users/muhammadowais/workspace/datingapp/node_modules/gif-encoder/lib/GIFEncoder.js: assert could not be found within the project or in these directories:
node_modules/gif-encoder/node_modules
node_modules
../../node_modules
If you are sure the module exists, try these steps:

Clear watchman watches: watchman watch-del-all
Delete node_modules and run yarn install
Reset Metro's cache: yarn start --reset-cache
Remove the cache: rm -rf /tmp/metro-*
9 | */
10 |

11 | var assert = require('assert');
|                       ^
12 | var EventEmitter = require('events').EventEmitter;
13 | var ReadableStream = require('readable-stream');
14 | var util = require('util');
at ModuleResolver.resolveDependency (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:234:15)
at DependencyGraph.resolveDependency (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
at Object.resolve (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/lib/transformHelpers.js:317:42)
at resolve (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:629:33)
at /Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:645:26
at Array.reduce ()
at resolveDependencies (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:644:33)
at /Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:329:33
at Generator.next ()
at asyncGeneratorStep (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:137:24)

[2 ] then I installed:

npm install assert
This error poped.
error: Error: Unable to resolve module stream from /Users/muhammadowais/workspace/datingapp/node_modules/through/index.js: stream could not be found within the project or in these directories:
node_modules
../../node_modules
If you are sure the module exists, try these steps:

Clear watchman watches: watchman watch-del-all
Delete node_modules and run yarn install
Reset Metro's cache: yarn start --reset-cache
Remove the cache: rm -rf /tmp/metro-*

1 | var Stream = require('stream')
|                       ^
2 |
3 | // through
4 | //
at ModuleResolver.resolveDependency (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:234:15)
at DependencyGraph.resolveDependency (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
at Object.resolve (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/lib/transformHelpers.js:317:42)
at resolve (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:629:33)
at /Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:645:26
at Array.reduce ()
at resolveDependencies (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:644:33)
at /Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:329:33
at Generator.next ()
at asyncGeneratorStep (/Users/muhammadowais/workspace/datingapp/node_modules/@react-native-community/cli/node_modules/metro/src/DeltaBundler/traverseDependencies.js:137:24)

[3 ] Then installed:

npm install stream
error: Error: Unable to resolve module events from /Users/muhammadowais/workspace/datingapp/node_modules/gif-encoder/lib/GIFEncoder.js: events could not be found within the project or in these directories:
node_modules/gif-encoder/node_modules
node_modules
../../node_modules
If you are sure the module exists, try these steps:

Clear watchman watches: watchman watch-del-all
Delete node_modules and run yarn install
Reset Metro's cache: yarn start --reset-cache
Remove the cache: rm -rf /tmp/metro-*
10 |
11 | var assert = require('assert');

12 | var EventEmitter = require('events').EventEmitter;
|                             ^
13 | var ReadableStream = require('readable-stream');
14 | var util = require('util');

[4 ] Intsalled:

npm install events
Error:
error: Error: Unable to resolve module zlib from /Users/muhammadowais/workspace/datingapp/node_modules/pngjs-nozlib/lib/parser-async.js: zlib could not be found within the project or in these directories:
node_modules
../../node_modules
If you are sure the module exists, try these steps:

Clear watchman watches: watchman watch-del-all
Delete node_modules and run yarn install
Reset Metro's cache: yarn start --reset-cache
Remove the cache: rm -rf /tmp/metro-*
2 |
3 | var util = require('util');

4 | var zlib = require('zlib');
|                     ^
5 | var ChunkStream = require('./chunkstream');
6 | var FilterAsync = require('./filter-parse-async');
7 | var Parser = require('./parser');

[5 ] installed:

npm install zlib
Error:
error: Error: Unable to resolve module ./zlib_bindings from /Users/muhammadowais/workspace/datingapp/node_modules/zlib/lib/zlib.js:
None of these files exist:

node_modules/zlib/lib/zlib_bindings(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.svg|.native.svg|.svg|.ios.bin|.native.bin|.bin)
node_modules/zlib/lib/zlib_bindings/index(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.svg|.native.svg|.svg|.ios.bin|.native.bin|.bin)

1 | module.exports = require('./zlib_bindings');
|                           ^
2 |

NOW I tried installing zlib and adding zlib_bindings in metro.config.js but no lock. there id file at './zlib_bindings' I checked in node_module

Did you follow this blog post? I had to shim some things in order to get everything working properly on React Native: https://shift.infinite.red/nsfw-js-for-react-native-a37c9ba45fe9

@kevinvangelder  yes I followed this blog I was stuck in the start (evening just installing libraries) and found no support so I left it. :)


Documentation to change colors not complete

The documentation states twoOrMoreSpaceHighlight as property for changing the color.
This does not work (at least not in VSCodium 1.53.2).
Since the extension is called myextension in its package.json, changing the property name to myextension.twoOrMoreSpaceHighlight works.
Upd: It's also in the file extension.ts as borderColor: { id: 'myextension.twoOrMoreSpaceHighlight' }

closing to clear my list of open topics, since I cannot do anything about this and after more than two years it is either not worth fixing or outdated.


Uncaught UnicodeEncodeError in io.py line 584

Aider version: 0.56.0
Python version: 3.11.5
Platform: Windows-10-10.0.22631-SP0
Python implementation: CPython
Virtual environment: Yes
OS: Windows 10 (64bit)
Git version: git version 2.46.1.windows.1
An uncaught exception occurred:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "__main__.py", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "main.py", line 698, in main
    coder.run()
  File "base_coder.py", line 734, in run
    user_message = self.get_input()
                   ^^^^^^^^^^^^^^^^
  File "base_coder.py", line 747, in get_input
    return self.io.get_input(
           ^^^^^^^^^^^^^^^^^^
  File "io.py", line 368, in get_input
    self.user_input(inp)
  File "io.py", line 413, in user_input
    self.append_chat_history(hist, linebreak=True)
  File "io.py", line 584, in append_chat_history
    f.write(text)
UnicodeEncodeError: 'utf-8' codec can't encode characters in position 19539-19540: surrogates not allowed

Thank you for filing this issue.
Surrogate Unicode characters seem to be a rabbit hole to handle. For further notice, here are two StackOverflow answers which look like they might be related:
https://stackoverflow.com/a/27367173/2955999
https://stackoverflow.com/a/38147966/2955999
@paul-gauthier
Maybe it is best to open the chat history file and write to it not as UTF-8, just as binary data somehow?
-> https://github.com/paul-gauthier/aider/blob/main/aider/io.py#L624

Thanks for trying aider and filing this issue.
The fix is available in the main branch. You can get it by installing the latest version from github:
aider --install-main-branch

# or...

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you. I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


[fix] ListRoleTags to get the iam role's tags

Codecov Report

Merging #42 into master will decrease coverage by 0.35%.
The diff coverage is 54.16%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   49.55%   49.19%   -0.36%
==========================================
  Files          11       11
  Lines         670      687      +17
==========================================
+ Hits          332      338       +6
- Misses        313      320       +7
- Partials       25       29       +4

Impacted Files
Coverage Δ

pkg/aws_config_server/list_roles.go
74.24% <54.16%> (-5.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f511e...265b1f6. Read the comment docs.


loading screen not working correctly when using nuxt-edge

Versions

nuxt: 2.15 (nuxt-edge)
node: 12.14

Reproduction
https://github.com/nuxt/nuxtjs.org
https://github.com/debs-obrien/debbie.codes

Additional Details

Steps to reproduce
clone and run dev command
What is Expected?
should show loading screen
What is actually happening?
Both of these sites acting differently using nuxt-edge. For nuxtjs.org the site shows no loading message at all and for debbie.codes I get a minimal loading message but not server / client bundle image like before.

Hi @debs-obrien are you still experiencing this issue?

yes @pi0  on nuxtjs.org it is still behaving weird. you can clone that repo and see it. remove nuxt-edge and adding nuxt and loading screen comes back


Retrieve applicant data to display on frontend (unfiltered)

Start pulling from the API endpoints for applicant info and display on the admin dashboard. Tied to completion of #188
Action items

[x] Call endpoint to retrieve first 25 applicants on unfiltered applicant list. Clicking each item in the sidebar should pass the userData object as props to display in the info pane.
[x] Implement infinite scrolling. This means scrolling to the bottom of the list should reveal a loading spinner, and another API call should be made to get the next 25. These 25 should then be spliced onto the current array of applicants.

Hooray! Done


Add setup_object

We're currently processing your upload.  This comment will be updated when the results are available.


Pywsus server doesnt respond

Hi! Thanks a lot for your research. Its really great. Tried to reproduce your results in lab environment and created a domain.
It consists of two machines:

DC: Windows Server 2016 Standard 1607 14393.0
PC: Windows 10 Education 1909 18363.1198
Added and configured WSUS on DC.

Started everything as in the video, but nothing seems to happen. Pywsus doesnt react after arp-spoofing and host update request. Tried to run server on both Kali and Parrot OS.
Never used to install wsus before. Dont know whats the problem. Maybe you can share your lab environment (stands) or suggest where to look for?

traffic.txt

Hi @Romska,
Can you confirm that the ARP spoofing is working? Are you able to MITM HTTP traffic with Bettercap targeting the Windows 10.
Thank you.

Yes, sure. In my first message I added a picture and on the top of it there is Wireshark with http filter.
DC: <IP_ADDRESS>
PC: <IP_ADDRESS>
Attacker: <IP_ADDRESS>
I also added file with traffic (traffic.txt) in the end.

Hi @Romska and sorry for the delay.
It seems that your ARP spoofing attack does not work. Where did you perform the Wireshark capture?
After, I would start with a basic proof of concept with Bettercap to confirm that the MITM is working.
Here some flags that will help to perform the attack:

https://www.bettercap.org/modules/ethernet/net.probe/
https://www.bettercap.org/modules/ethernet/net.recon/

Keep in mind that PyWSUS is simply a web server, the MiTM is a crucial part of the chain of exploitation.
Thank you.


Add RHT required bundle labels

This file is created by make bundle we need to put this info some other place.

So that this point, we can either disable overwriting of the bundle files, add another dockerfile, or some other idea that you have on handling this.

👍 Let me figure this one out.

👍 Let me figure this one out.

Would you believe it? There seems to be no way to achieve this with the operator-sdk.
https://github.com/operator-framework/operator-sdk/issues/5002

What I have found however is a following excerpt from the documentation at https://sdk.operatorframework.io/docs/olm-integration/generation/#bundle-format

Important: bundle generation is supposed to be idempotent, so any changes to
CSV fields able to be persisted (marked (user) or (marker) below) must be made
to the base set of manifests, typically found in config/.
Bundle metadata in bundle/metadata/annotations.yaml contains information about
a particular Operator version available in a registry. OLM uses this
information to install specific Operator versions and resolve dependencies.
That file and bundle.Dockerfile contain the same annotations, the latter as
LABELs, which do not need to be modified in most cases; if you do decide to
modify them, both sets of annotations must be the same to ensure consistent Operator
deployment.

Could you please amend annotations.yaml file together with bundle.Dockerfile? I will take care of the CI then.

Going to close this. Since operator-sdk overwrites the files, I believe a release script will be needed in the mean time.


Add .gitattributes file

Atteding to @Jefferson227 comment on #8, the end-of-line normalization should be handled with .gitattributes file. Setting * text=auto  as default behavior to automatically normalize line endings, which is mentioned on git docs.

Shouldn't be better to resolve this issue on #8. Since is not closed yet. What you think?

I think this issue is not directly related to the #8, because they come from different contexts. Once #8 it's about commit structure and normalize line endings it's about code structure. In addition, we can think about a need, for example, reset this configuration or #8 configuration.

Hey @wellyal I agree with @paulonotz0r. Imagine we want to reset or remove one feature and don't want to touch on the another one. In this case, we would have to separate the code related with each funcionality and then create a new commit(just like before), you know? It's features with different purpose.

@paulonotz0r would you like to get this one?

Awesome!


implements variable fonts loading from scotts fonts, updates all font…

I added variables and helpers for font-variation-settings because font-weight and style are no good with this variable font. I've visually checked each page.

lgtm

🤑


MCP key configuration not pushed to ACI

apic:
access_policies:
mcp:
action: false
admin_state: true
frequency_sec: 5
initial_delay: 300
loop_detection: 5
per_vlan: true
key: $ECRETKEY1
Error: The post rest request failed 29s
10149│ 29s
10150│ with module.nac-aci.module.aci_mcp[0].aci_rest_managed.mcpInstPol, 29s
10151│ on .terraform/modules/nac-aci/modules/terraform-aci-mcp/main.tf line 1, in resource "aci_rest_managed" "mcpInstPol": 29s
10152│ 1: resource "aci_rest_managed" "mcpInstPol" { 29s
10153│ 29s
10154│ Code: 400 Response: [map[error:map[attributes:map[code:182 text:Password is 29s
10155│ required for MCP Instance Policy.]]]], err: %!s(). Please report this 29s
10156│ issue to the provider developers.
Not taking into account when pushing this configuration or when changing the key it is not changing anything when hitting terraform apply.
Not sure if this is expected behavior ?
NaC version  = 0.8.1
Terraform module = v2.13.2

Are you trying to update an existing MCP key that was previously provisioned using NaC?

Hi,
Yes through NaC or when a key is already set manually on the GUI so wasn’t sure this would work or we need to clear the key first through the gui ?
Cheers
Alexander
From: Daniel Schmidt @.>
Date: Wednesday, 20 March 2024 at 11:41
To: netascode/terraform-aci-nac-aci @.>
Cc: Alexander Deca @.>, Author @.>
Subject: Re: [netascode/terraform-aci-nac-aci] MCP key configuration not pushed to ACI (Issue #64)
Are you trying to update an existing MCP key that was previously provisioned using NaC?
—
Reply to this email directly, view it on GitHubhttps://github.com/netascode/terraform-aci-nac-aci/issues/64#issuecomment-2009246678, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAJEUMOXRCGQHR5OBK6FT3YZFRUFAVCNFSM6AAAAABD3ZPHFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGI2DMNRXHA.
You are receiving this because you authored the thread.Message ID: @.***>

I believe this is because of:
  lifecycle {
    ignore_changes = [content["key"]]
  }

https://github.com/netascode/terraform-aci-nac-aci/blob/main/modules/terraform-aci-mcp/main.tf
BTW. Can we remove mcpInstPol from defaults? I don't like it's generated automatically when i started managing access policies. Same applies to QOS Policy.
defaults.yml
      mcp:
        admin_state: true
        per_vlan: true
        action: true
        key: cisco
        loop_detection: 3
        initial_delay: 180
        frequency_sec: 2
        frequency_msec: 0

This is what was generated once I set manage_access_policies to True without specifying anything under "access_policies" in data model:
  # module.aci.module.aci_mcp[0].aci_rest_managed.mcpInstPol will be created
  + resource "aci_rest_managed" "mcpInstPol" {
      + annotation = "orchestrator:terraform"
      + class_name = "mcpInstPol"
      + content    = {
          + "adminSt"        = "enabled"
          + "ctrl"           = "pdu-per-vlan"
          + "initDelayTime"  = "180"
          + "key"            = (sensitive value)
          + "loopDetectMult" = "3"
          + "loopProtectAct" = "port-disable"
          + "txFreq"         = "2"
          + "txFreqMsec"     = "0"
        }
      + dn         = "uni/infra/mcpInstP-default"
      + id         = (known after apply)
    }

  # module.aci.module.aci_qos[0].aci_rest_managed.qosInstPol will be created
  + resource "aci_rest_managed" "qosInstPol" {
      + annotation = "orchestrator:terraform"
      + class_name = "qosInstPol"
      + content    = {
          + "ctrl" = ""
        }
      + dn         = "uni/infra/qosinst-default"
      + id         = (known after apply)
    }

Also this was mentioned on a community forum, so I think this becomes a road blocker for more people: https://community.cisco.com/t5/other-data-center-subjects/nac-issue-with-module-quot-aci-rest-managed-mcpinstpol-quot/m-p/5051450#M23

There are a few limitations due to the fact that we cannot read/retrieve an MCP key, which equally applies to other sensitive information like BGP passwords for example. Because of this, we have to use the ignore_changes option, as we would otherwise always have a diff in every plan. When using ignore_changes for a specific attribute (like the MCP key), it will ignore any changes to that attribute (either in config or infra). If you want to change the MCP key after having created the resource already, we can use the following CLI option to push the updated config again:
 terraform apply -replace="module.aci.module.aci_mcp[0].aci_rest_managed.mcpInstPol"

The other question is, why are we pushing the MCP configuration by default (in case manage_access_policies is enabled). This is because it is a best practice to enable MCP and we want NaC to configure the global settings according to best practices by default. The same is true for fabric policies. In case you don't want NaC to configure a specific part of the configuration you can always selectively disable modules by adding a configuration like the one below to the data model:
modules:
  aci_mcp: false

A list of all modules can be found here: https://github.com/netascode/terraform-aci-nac-aci/blob/main/defaults/modules.yaml

I will close this for now.


bunx --bun doesn't work

Passing the --bun flag doesn't work with bunx.
E.g. bunx --bun vite gives an error like CACError: Unknown option --bun.
This seems to be because bun has special command line handling when it's called with the name bunx. On the other hand, the shim executes it as something like bun x --bun vite.

Possibly root cause behind https://github.com/oven-sh/bun/issues/4974

Bun doesn't provide a bunx file, so we have to use bun x instead.

I think the easiest is to make the shim like bun does it:
ln -s $PROTO_HOME/tools/bun/1.0.11/bun $PROTO_HOME/tools/bun/1.0.11/bunx

and in proto's shim:
exec proto run bun --bin=bunx -- "$@"

That would have the same problem. Basically the user needs to provide args that go before and after our hardcoded x, which isn't possible.

We either hardcode it to --bun x (maybe this is fine?)
Users can just do bun --bun x themselves.

No. With the symlink, the bun cli infers the x so you don't need to provide it on the command line :-). The above changes do work for me on WSL.

Ah, ok, so you're saying that bun itself extracts the filename and determines it that way? Interesting. Yeah, let me tinker with that.

Exactly. I don’t know zig, but the wrappers when installing via node show this: https://github.com/oven-sh/bun/blob/046d1975192316cb78886269c70c1c292a04a733/packages/bun-release/scripts/upload-npm.ts#L73
I wouldn’t be surprised if you could also accomplish this without the symlink via arg0, but my gut says that’s a little more fragile.

Been messing with this and it works for the bin symlink, but not for the shim, since the shim still executes bun under the hood which doesn't pass the "is argv0 bunx" check.

Works by removing the shim entirely though: https://github.com/moonrepo/bun-plugin/pull/13

This works for bins now, but not for shims, going to close.


composer.lock has wrong version when upgrading to <IP_ADDRESS>

When upgrading from 2.0.12 to <IP_ADDRESS> using
composer require "yiisoft/yii2":"~<IP_ADDRESS>"
in the composer.lock file, the version shows "<IP_ADDRESS>"
I don't know if this will affect "composer install" so I haven't tried it on the production server yet. However, downgrade from <IP_ADDRESS> -> 2.0.12 will not update the composer.lock correctly (e.g. the version <IP_ADDRESS> still there)
What steps will reproduce the problem?
upgrade from 2.0.12 to <IP_ADDRESS>
What is the expected result?
composer.lock should show "version" : "<IP_ADDRESS>"
What do you get instead?
composer.lock shows "version" : "<IP_ADDRESS>"
Additional info

Q
A

Yii version
2.0.12

PHP version
5.6

Operating system
ubuntu 14.04

This is how ~ operator works: https://getcomposer.org/doc/articles/versions.md#tilde-version-range-
You should use <IP_ADDRESS> or <IP_ADDRESS> (without any operators) if you want to stick  to one of this version. But I suggest to upgrade - <IP_ADDRESS> has some security issues.

this article needs to update [https://www.yiiframework.com/news/168/releasing-yii-2-0-15-and-database-extensions-with-security-fixes]
The confusing part is it asks to "composer require "yiisoft/yii2":"~<IP_ADDRESS>"
but there is a <IP_ADDRESS> version as well. So I got <IP_ADDRESS> and i thought it was wrong.

<IP_ADDRESS> is a patch applied to <IP_ADDRESS>, to limit the BC break that comes with the security fix.

updated the news:

Update: We have since released further patches to lower the impact of the BC break introduced by the security fix, so you get versions <IP_ADDRESS>, <IP_ADDRESS> and <IP_ADDRESS> from the above.


Add mode for MCS48 mask ROM parts.

This adds a mode to support dumping the mask ROM from 8048 and 8049 microcontrollers.
On the TL866 A/CS this requires an adapter to adjust the pinout. The required pin mappings are in a comment at the top of the source file. The adapter is required because VPP is needed on pin 7 but the TL866 doesn't have a VPP switch for that pin. The TL866II does, so no adapter will be needed there.

I'm slightly concerned that someone will put an 8048 directly in the ZIF socket, which will probably destroy it when +12V is applied to pin 37 (P26). The MCS48 manual claims that proper socketing can be detected by looking for the clock on ALE (pin 11), but I wasn't able to get that to work.
Do we want to hold off merging until we can figure out a way to check that the part is socketed correctly before applying VPP?


ci-automation: add update test and ensure to use right image

ci-automation: add missing update test
The kola update test was missing. It is performed as update from the
old image to the newly built payload to ensure that the new image is
compatible for old clients.

ci-automation: don't reuse files from a workspace
We have no idea where the image came from that is found in the
workspace and should not use it to run the test.
Remove any left over image and always fetch it again.

How to use
pick for stable/beta/alpha
Testing done
TODO

I tried to build it on the CI but it fails at the baselayout package:
!!! copy /var/tmp/portage/sys-apps/baselayout-3.6.8-r5/image/etc/hosts -> /etc/hosts failed.
!!! [Errno 16] Device or resource busy: b'/etc/hosts#new' -> b'/etc/hosts'

Great work on the PR, thanks for helping with the CI containers!
Just two comments:

ci-automation: don't reuse files from a workspace

The workspace is cleaned on each CI run by the CI - it's empty when the ci-automation/ scripts are called. It is safe to assume there are no old build artifacts.
Deleting the OS image on the other hand will inflate re-run time and will makes it harder to run tests locally since the image is downloaded for each run.

ci-automation: add missing update test

Great catch, I missed that in the initial re-implementation. We need to make sure that

the tap file generated is picked up by the tap file merging logic in https://github.com/flatcar-linux/scripts/blob/main/ci-automation/test.sh#L160 . That logic currently only cares about the tapfile passed to the vendor implementation (https://github.com/flatcar-linux/scripts/blob/main/ci-automation/vendor-testing/qemu.sh#L14)
we might want to look at $@ and check if it's either * or, if not, contains the cl.update.payload test. If we run the update test without condition then it is run on every re-run.
When the update test fails, the tapfile it generates will only contain a single test - cl.update.payload. This will break the current retry logic (https://github.com/flatcar-linux/scripts/blob/main/ci-automation/test.sh#L168).

We could solve all 3 problems in one go if we separate the update test from the "regular" qemu test, i.e. put it into a separate script. Users / CI would then call
test_run amd64 qemu_update
which would only test the update feature. WDYT?

Deleting the OS image on the other hand will inflate re-run time and will make it harder to run tests locally, since the image is downloaded for each run.

Ok, then I would change the update test to do the same and preserve existing files.

We could solve all 3 problems in one go if we separate the update test from the "regular" qemu test, i.e. put it into a separate script. Users / CI would then call e.g.

Sounds good


Add navigation through pages via arrow keys

Closes #1541.
Use the arrow keys to navigate through the issues and PR list.

Would be nice to make it work anywhere there's pagination. Like the search https://github.com/search?utf8=✓&q=unicorn&type= and https://github.com/issues

Should work now, @sindresorhus. 😄

@rzpio Can you add a mention of the feature in the readme?

@bfred-it @hkdobrev Thoughts on this? I personally find it useful.

I probably wouldn’t use it but I don’t see any issues, other than possibly the one-button shortcut

@sindresorhus, done. 😃

Would be nice to make this work on PR commit pages too, if you're interested.
https://github.com/sindresorhus/refined-github/pull/1557/commits/2507a80bde9be0e0bbe7646c4fa3997fb610739d
Note the "Prev" and "Next" buttons.


Write Layout/Gutters page for documentation

These pages are still TODO:
https://next.design-system.post.ch/?path=/docs/foundations-layout-todos--docs
https://next.design-system.post.ch/?path=/docs/foundations-layout-gutters--docs
There is at least one direct reference from another page to the gutters.
### Tasks
- [ ] Decide if we want to split the grid and gutter pages or put it all together on one page

Resolution 25.01.2024: Improve the grid page with a visual example of a gutter with a control to change it.


"GESI" Menu Item goes away

After some time the "GESI" entry in the menu just disappears, Instead there's a dropdown menu called "Script Center Menu" with the only entry "Read Data".
Clicking on "Read Data" doesn't seem to do anything.
All functions simply return "FALSE" without any error message.

Are you using any other scripts besides GESI?

..
I had a script to read json data and apparently that caused the issue.


pressing settings twice should navigate back

STR:

go to fav
press settings
press settings again
should be back at fav.

https://github.com/freddyb/wallabag-fxos/commit/c86d60c77c33e392550371c9fb0e1cd3010eca7d


get pods output log path as environment variable

This change is

/deploy

/deploy

/deploy

/deploy

/deploy


HttpGet:add http timeout

Please answer these questions before submitting pull request

Why submit this pull request?
[ - ] Bug fix

Bug fix

Bug description.
DiscoveryRestServiceClient's http-get request will stuck when collector all down
How to fix?
add timeout for HttpGet

Coverage increased (+0.02%) to 19.573% when pulling 8dd788de6aa044d03313c3c1fced8c74343fefb8 on carlvine500:add-http-time-out into 71eb594ed97a6ca47362913d0b2c357cf62770b5 on apache:master.


[KOGITO-7269] [KSW-Guides] Getting familiar with our tooling

JIRA: https://issues.redhat.com/browse/KOGITO-7269

Description:

Please make sure that your PR meets the following requirements:

[X] You have read the contributions doc
[X] Pull Request title is properly formatted: KOGITO-XYZ Subject
[X] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[X] The nav.adoc file has a link to this guide in the proper category
[X] The index.adoc file has a card to this guide in the proper category, with a meaningful description

Merging this PR to create a patch PR with doc improvements.


Authentication and Offline Tile Packages

I asked this question on GeoNet but haven't received any responses...
"I have a registered app (with client id and secret id).  I want to enable users to download tiled map packages from the app ex: (https://tiledbasemaps.arcgis.com/arcgis/rest/services/USA_Topo_Maps/MapServer)... How do I use the new authentication patterns in version 100 to do an "app" login without having to present the user with the login screen.  My users will not have logins to ArcGIS online or portal."

Have you reviewed this topic in the Guide: https://developers.arcgis.com/android/latest/guide/access-the-arcgis-platform.htm#ESRI_SECTION1_2513881AFEDD4B1688E614554463EB71 ?
Does it help? Let us know...

I have... but I couldn't get the code figured out.  A code sample or pseudo-code sample would be very helpful.  Thanks.

Agreed! Apologies for not having this more clear for you. We will work to get something for you on this.
Thank you!

Thanks.  That's awesome!

Just following up to see if you have had a chance to look at this issue.  Thanks.  -Bill

We are still trying to put this together. I apologize for the delay. Stay tuned....

Hi Bill,
Looks like we've hit a current limitation in 100.0. One approach is to have a proxy in the mix, which gives your app a token, based on a set of credentials, without having those credentials baked into the app, is highly not recommended. I apologize for the delay in getting back to you. This is taking some time verifying that it will work for you. Stay tuned, though.

Thanks for the update.

Can someone guide me how to use .tpk file usuing  android runtime api version 100.0?
Thanks

@adnanmacro Use a TileCache.

Here's code I developed based on the examples in the docs using the OAuthLoginManager... Even though I get logged in I'm still getting an "Job error 498 Invalid Token" when I try to export a tile cache.
static final String TILE_URL_USA_TOPO = "https://tiledbasemaps.arcgis.com/arcgis/rest/services/USA_Topo_Maps/MapServer";

    private void appLogin() {
        Log.d("MyApp", "login");
        try {
            oauthLoginManager = new OAuthLoginManager("https://www.arcgis.com/", getString(R.string.arcgis_app_id), getString(R.string.redirect_uri), 0);
            oauthLoginManager.launchOAuthBrowserPage(getApplicationContext());
        } catch (Exception e) {
            Log.e("error-", e.getMessage() + "");
        }
    }

    private void fetchCredentials(Intent intent) {
        // Fetch oauth access token.
        final ListenableFuture<OAuthTokenCredential> future = oauthLoginManager.fetchOAuthTokenCredentialAsync(intent);
        future.addDoneListener(new Runnable() {
            @Override
            public void run() {
                try {
                    oauthCred = future.get();
                    Log.d("MyApp", oauthCred.getUsername());
                    downloadMapTPK2();
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }
        });
    }

private void downloadMapTPK2() {
        Log.d("MyApp","Running ExportTileCacheJob");
        //extent
        Envelope mapExtent = Util.getMapExtent(mMapView);

        //Storage path for offline tiles
        DEFAULT_BASEMAP_PATH = getString(R.string.offline_dir);
        mDefaultPath = Environment.getExternalStorageDirectory().getPath() + DEFAULT_BASEMAP_PATH;
        File directory = new File(mDefaultPath);
        if (!directory.exists()) {
            directory.mkdirs();
        }
        final String tileCachePath = mDefaultPath + "topo.tpk";

        //Tile Cache
        // Create the export tile cache
        ExportTileCacheTask exportTilesTask = new ExportTileCacheTask(TILE_URL_USA_TOPO);
        exportTilesTask.setCredential(oauthCred);
        Log.d("MyApp",oauthCred.toJson());

        // Define the parameters for the new tile cache - in this case, using the parameter object constructor
        ExportTileCacheParameters exportTilesParameters = new ExportTileCacheParameters();
        //exportTilesParameters.getLevelIDs().addAll(Arrays.asList(0, 1, 2, 3, 4, 5, 6, 7, 8, 9));
        exportTilesParameters.setAreaOfInterest(mapExtent);

        // Create the export task, passing in parameters, and file path ending in ".tpk"
        final ExportTileCacheJob exportJob = exportTilesTask.exportTileCacheAsync(exportTilesParameters, tileCachePath);
        exportJob.setCredential(oauthCred);

        exportJob.addJobChangedListener(new Runnable() {
            @Override
            public void run() {
                List<Job.Message> messages = exportJob.getMessages();
                //updateUiWithProgress(messages.get(messages.size() - 1).getMessage());
                Log.d("MyApp",messages.get(messages.size() - 1).getMessage());
            }
        });

        // Listen for when the job is completed
        exportJob.addJobDoneListener(new Runnable() {
            @Override
            public void run() {
                if (exportJob.getError() != null) {
                    //dealWithException(exportJob.getError()); // deal with exception appropriately...
                    Log.d("MyApp",exportJob.getError().getAdditionalMessage());
                    return;
                }

                if (exportJob.getStatus() == Job.Status.SUCCEEDED) {
                    Log.d("MyApp","Download Succeeded");
                    final TileCache exportedTileCache = exportJob.getResult();
                    ArcGISTiledLayer tiledLayer = new ArcGISTiledLayer(exportedTileCache);
                    mMapView.getMap().getOperationalLayers().add(tiledLayer);
                }
            }
        });

// Start the ExportTileCacheJob
        exportJob.start();
    }

Just checking in to see if there are any updates or news on this issue?

I ran across this issue while I was trying to find a solution to the same problem, so I figured I would add what worked for me:

Generate a temporary token; I did this via HTTP request, see: https://developers.arcgis.com/documentation/core-concepts/security-and-authentication/accessing-arcgis-online-services/

Encode the token and put it in the service url as a parameter:
exportUrl = tileServiceUrl + "?token=" + URLEncoder.encode(token, StandardCharsets.UTF_8.name());


fix(roxvet): generted file comment checker

Description
The generated comment does not need to be on the top of the file as per doc:

This line must appear before the first non-comment, non-blank text in the file.

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Run it on the https://github.com/stackrox/stackrox/pull/10379 and it worked previously scanner files were reported as they have a comment before generated comment
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

#10378  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @janisz and the rest of your teammates on  Graphite

/retest

/retest


If newly added file is empty in Git then parse_patch fails to recognize it.

Possible fix is at this line: https://github.com/cscorley/whatthepatch/blob/master/whatthepatch/patch.py#L198
Condition should be "while len(lines) > 0:"
Issue:
The diff for empty file creation looks like this:
diff --git a/sample-code/empty_file b/sample-code/empty_file
new file mode 100644
index 0000000..e69de29

@momalepd can you make a PR and unit test for this?

Hi I came here to post this exact issue! Looks like it's been fixed already and now you're at version 0.0.6. However, when I try to upgrade through pip it says that I'm on the latest version (0.0.5). Am I doing something wrong or is it on PyPi's side?

I have yet to push the publish button. I was going to attempt to include
another issue but got behind.
On Thu, May 16, 2019, 11:10 AM ronnyli<EMAIL_ADDRESS>wrote:

Hi I came here to post this exact issue! Looks like it's been fixed
already and now you're at version 0.0.6. However, when I try to upgrade
through pip it says that I'm on the latest version (0.0.5). Am I doing
something wrong or is it on PyPi's side?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/cscorley/whatthepatch/issues/18?email_source=notifications&email_token=AAA3Q4DR5LYDAD7SEJSOUATPVV2PDA5CNFSM4FXN7EFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVSD3AA#issuecomment-493108608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA3Q4ALNUBGSMYEDC5DS5TPVV2PDANCNFSM4FXN7EFA
.


add recipe and screenshots

This restores the recipe for surface reconstruction from intensity images.

Relevant for #47


Update rforward.py

Thanks! I should probably update this more often.

Woohoo, I could use some help!

Thank you again!  I had been working out ways to get comfortable with Python and Git since I dont use it regularly and went for the commit stuff fast and fix it later.


!awardpoints command

I think it would be good to have a command that just gives points intead of edit points,
Also have it so you could use !awardpoints * 1000 to give everyone in chat 1k for example

If there would be a command like this, if must have a bigger user and global cd to not fuck up the server.

https://pastebin.com/w9shvstj is a working example

I believe this is fixed by the !editpoints command. But there's still no solution to give points to everyone :/

https://pastebin.com/w9shvstj is a working example

@DatGuy1 Is this still working code? Could it potentially be merged?

Yes, should be. Updated version here https://pastebin.com/uta6TwD6

Wait, this does like giga updates.

https://pastebin.com/200t495f here is a better version.

Due to pajbot being moved into maintenance mode I'm closing this feature request.


TST: Improve requires grad testing:

Description
Previously, the corresponding tests were testing only whether specific parameters had requires_grad True or False. Now, all parameters are being checked. This is more rigorous.
Also, tests for Embedding, Conv1D, Conv2d were added (LoRA and IA³), thus superseding PR #1115.
Finally, tests for LoHa and LoKr were added.
Note
I considered moving the tests to a separate module, as they were getting quite big and this would help with readability. For now, I left them in the same module because it leads to a better diff view and is thus easier to review. LMK if I should move the tests to a separate file.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Device Storage Full modal

When a user's device storage is full, the app has some issues, can crash, and can't save photos.
When 1) a user opens the app or 2) takes a photo from the multicapture camera or ai camera, check to see if device storage is full. If it is, show the following native modal:
Title: Device Storage Full
Body: iNaturalist may not be able to save your photos or may crash.
1 Button: OK

@abhasinat is this a duplicate of #1399?

I added your more detailed solution to #1399


Old i18n keys still present in code / templates

See https://github.com/silverstripe/silverstripe-framework/commit/7c67d2948469533f8e01cad917b1a8720a0ddce6#diff-e0c0c7c5f72bb31c02647d33f6a0b563: some un-namespaced keys are still present in the code and being picked up by text collector. This is not a critical issue, but should be cleaned up at some point.
One .ss template key suffix in https://github.com/silverstripe/silverstripe-cms/commit/00f699b99bf0e279e19abe1e2df1cbd4d7897798#diff-8eff9e0de4d3e7e3184cac847cffd119L11 needs fixing too.

Some un-namespaced keys in https://github.com/silverstripe/silverstripe-cms/blob/master/templates/Includes/Install_successfullyinstalled.ss.

Need to rename SilverStripe\CMS\Email\ViewArchivedmail.ss to SilverStripe\CMS\Email\ViewArchivedmail_ss


Udpate to use global variable template in release stage

Update to use global variables in release stage to avoid running cg checks at release time. This should run as part of analyze stage.

I'd also suggest running through a template release just to make sure these all work.

I have released template package using this change.


There was an issue connecting to your repository provider (GitHub)

Amplify console Url
https://eu-west-1.console.aws.amazon.com/amplify/home?region=eu-west-1&code=6c9972795c4e3cd07d24#/
Issue
Unable to Connect to GitHub when trying to Add Repository.
GitHub authorization is successful but then there is an issue connecting error message
Tried to refresh by clicking refresh button.
Tried to reauthorize by revoking AWS Amplify as an Authorized OAuth App, on my GitHub profile,  but the issue persists.
Error Message

@glenkitchen can you share your appId? Did you wait an hour between retries?

@kahdojay Apologies. I was trying to connect a repository provider without an app in the console.  Resolved.


remove destinationId and replace it with the class name of routes

Instead of having destinationId in the public API we will create ids internally based on the hashCode of the fully qualified class name of a route. Most APIs already had everything we need there were 2 changes other than removing the id from the destinations:

navigateTo with pop up to is now navigateToOnTopOf, a call would be navigatoToOnTopOf<FooDirections>(BarDirections()) not super happy with the name here because it could also be interpreted as go to foo and then to bar. Also if you pass inclusive = true then Foo would also be removed and bar would be on top of foo's parent
navigateBack with pop up to is now navigateBackTo, e.g. navigateBackTo<FooDirections>(), here it works better

As mentioned the duplication for root will go away with #47.

What if instead we have a way to define a sequence of events or ensure that all events that sent will be processed (not only the last one sent) ?

This is already possible. You can for example call navigateTo multiple times to build a synthetic back stack. So it should probably be fine to replace navigatoToOnTopOf with just making 2 calls

Merged with master and marked navigatoToOnTopOf as obsolete


Song crash sometimes

[2020-08-18 13:48:41,774] [Loader.py] [libav.matroska,webm:Loader] [ERROR]: File ended prematurely
may be occured in Stream ip tunneling.

Cannot reproduce in windows 10

may be sanic bug https://github.com/huge-success/sanic/pull/1876

Traceback (most recent call last):
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\app.py", line 1041, in handle_request
    await response.send(end_stream=True)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\response.py", line 102, in send
    await super().send(*args, **kwargs)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\response.py", line 60, in send
    await self.stream.send(data, end_stream=end_stream)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\http.py", line 281, in http1_response_normal
    raise ServerError("Response was smaller than content-length")
sanic.exceptions.ServerError: Response was smaller than content-length

Traceback (most recent call last):
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\app.py", line 1041, in handle_request
    await response.send(end_stream=True)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\response.py", line 102, in send
    await super().send(*args, **kwargs)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\response.py", line 60, in send
    await self.stream.send(data, end_stream=end_stream)
  File "C:\Users\mary\AppData\Local\Programs\Python\Python38\lib\site-packages\sanic\http.py", line 281, in http1_response_normal
    raise ServerError("Response was smaller than content-length")
sanic.exceptions.ServerError: Response was smaller than content-length

Occurs due to streaming interruption, ignored

fix in #44