JSON config is unwieldy

I would have loved many config vars instead of one but I understand why it is that way.
The fact it is an array of json elements in a config var seems odd to me.
Not sure if more practical:
# List of IDs
ATTR_VAULT_IDS=123,234,456
# Values
ATTR_VAULT_SECRET_123=456
ATTR_VAULT_CREATED_AT_123=timestamp
ATTR_VAULT_SECRET_234=123
ATTR_VAULT_CREATED_AT_234=timestamp
#...

@ys so the keyring has to be JSON right now, but that doesn't mean it has to be that way in your env. You could certainly set config vars as you've outlined and then just define your attr_vault class as:
class Foo < Sequel::Model
  vault_keyring ENV.fetch('ATTR_VAULT_IDS').split(',').map do |id|
    { id: id,
      created_at: ENV.fetch("ATTR_VAULT_CREATED_AT_#{id}"),
      value: ENV.fetch("ATTR_VAULT_SECRET_#{id}") }
  end.to_json
  vault_attr :foo
end

Or just stick that in a helper somewhere so you don't have to repeat it. I definitely don't want to have AttrVault start reading env vars directly--that's a little too magical. Maybe I could support a global config for the vault keyring, but that addresses kind of a different issue. Thoughts?

I've simplified the config a bit in master, so I'll close this for now. Let me know if you have other suggestions. The new syntax allows omitting created_at if using numeric ids, and also allows you to specify a hash rather than an array of keys:
before:
[ { "id": "<some-uuid>", "created_at": "2009-02...", "value": "abcd..." },
  { "id": "<other-uuid>", "created_at": "2014-03...", "value": "defg..." } ]

after:
[ { "id": 1, "value": "abcd..." },
  { "id": 2, "value": "defg..." } ]

or simply
{ "1": "abcd...", "2": "defg..." }

I'll restore some uuid key tests (I've changed them to use integer keys for now) and add a mechanism to migrate from a uuid key column to an integer key column before I make a release.

Actually an in-band migration mechanism is probably overkill: you can easily migrate via something like

Add a new_key_id column
Rename the existing key_id column to old_key_id
Run the following update, filling in the key id mapping based on your keyring's created_at dates for its keys:

WITH key_map(new_key_id, old_key_id) AS (
  VALUES
    (1, 'some-uuid'),
    (2, 'other-uuid')
)
UPDATE
  my_table
SET
  my_table.new_key_id = key_map.new_key_id
FROM
  key_map
WHERE
  my_table.old_key_id = key_map.old_key_id

Rename new_key_id to key_id
Drop the old_key_id colum

I'll flesh this out and add it to the docs.

Thanks a lot.
This looks in fact easier already:)

I've committed updated docs to master.


Wildcards are not support for path filters, but the documentation says otherwise

As noted over 2 years ago in this thread https://github.com/MicrosoftDocs/azure-devops-docs/issues/397, Path wildcards are not supported, and still aren't. But the documentation seemingly for 2 years has suggested this is a feature, but it doesn't work (I just wasted several hours trying to figure out why it didn't work).
Here's the documentation as it appears right now:

There are multiple places that show this doesn't work:
https://developercommunity.visualstudio.com/idea/383490/support-wildcards-in-trigger-path-filters.html
https://stackoverflow.com/questions/63800001/does-azure-yaml-pipelne-support-wildcards-in-path-filter-in-trigger
This example of wildcards in path filters should be removed as it is simply wrong.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfba9a21-e0f9-4fc6-43fc-bfdc51af31d3
Version Independent ID: d93c7852-ce63-a6d0-417a-45f8cf2fc522
Content: Build GitHub repositories - Azure Pipelines
Content Source: docs/pipelines/repos/github.md
Product: devops
Technology: devops-cicd-repos
GitHub Login: @vijayma
Microsoft Alias: vijayma

Updated the docs to state so. This is not a judgment on whether we will take this up as future work in the product.

Hello! Isn't it just a RegEx filter to change in the Azure DevOps job starter so as to make this happen?
Why is this taking so long to get improved? Thus this really need a user voice voting to get fixed? It's not a new feature, it's a bug...

The documentation was updated to say:

Wild cards are not supported with path filters.

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/azure-repos-git?tabs=yaml#paths
However, this is also incorrect and causes more confusion. Wildcards are supported in path filters when included as the final character:

For paths:

You may include * as the final character, but it doesn't do anything differently from specifying the directory name by itself.

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/azure-repos-git?tabs=yaml#wildcards
See the following issues:
https://github.com/MicrosoftDocs/azure-devops-docs/issues/10212
https://github.com/microsoft/azure-pipelines-vscode/issues/372
Prior to this issue, the documentation and the Azure Pipelines VS Code extension standardized adding * as the final character for directories.

Wildcard support and documentation update will be rolled out over the next two to three weeks according to the latest release notes.


Valkyrien-Skies disables TLSkinCape (TLSkinMod [Forge])

When VS is installed with TLSkin, TLSkin is unable to display the player's skin (TLaucher account).
When I uninstall VS, VSC and VSW, TLSkin works correctly.
Installed mods:
-TLSkinCape (requires Optifine);
-Optifine;
-ValkyrienSkies;
-ValkyrienSkiesControl;
-ValkyrienSkiesWorld.

its better to use another skins mod, like CustomSkinsMod, it also lets you use HD Skins


Revamp wording

Currently we are having trouble / overlapping meaning of server. After all the local cachepot launches a command server. In dist mode we also have scheduler and server.
I propose to rename as follows:
scheduler -> scheduler
(client) server -> connector
(dist) scheduler -> scheduler
(dist) server -> worker
This would simplify onboarding people and detaching the functional semantics from the process naming and simplify writing coherent documentation.

That's a good idea! I've been confused very often wrt local and dist build servers.
I very much like the idea of renaming (dist) build server -> (dist) worker. I think it more clearly conveys that it's one of many most of the time and it does the actual work. Big 👍
I'm not sold on connector though - in the dist case it really is the connector but other than that it's a daemon that also coordinates builds and caches/fetches the result. Maybe something like coordinator (daemon) would be more fitting?

:+1: for coordinator

Done in #134


RP-24 Add import of products from the MySklad system

Add import of products from the MySklad system and export of matching by name products from the database.

Fixed by https://github.com/zwieback/relef-parser/pull/49


Critical vulnerabilities related to the vm2 package and its usage within the flowise-components package.

npm audit report
vm2  *
Severity: critical
vm2 Sandbox Escape vulnerability - https://github.com/advisories/GHSA-cchq-frgv-rjh5
vm2 Sandbox Escape vulnerability - https://github.com/advisories/GHSA-g644-9gfx-q4q4
No fix available
node_modules/vm2
flowise-components  >=1.2.14
Depends on vulnerable versions of vm2
node_modules/flowise-components
2 critical severity vulnerabilities
To address issues that do not require attention, run:
npm audit fix
Some issues need review, and may require choosing
a different dependency.

Do you know when this will be fixed?

resolved now in v2.1.1


select the created account in the dropdown

This PR fixes a bug:

create a new account
at step 3, click on Skip
see in the drop-down account selection that it is not your newly created account

needs https://github.com/massalabs/ui-kit/pull/168

still to do: clean code, maybe the use effect is not necessary, maybe the options passed to the useRessource is not necessary, also the refetch

Codecov Report
Patch and project coverage have no change.

Comparison is base (07c9528) 41.54% compared to head (e878447) 41.54%.

:exclamation: Current head e878447 differs from pull request most recent head e71ec8c. Consider uploading reports for the commit e71ec8c to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   41.54%   41.54%
=======================================
  Files          15       15
  Lines        1047     1047
=======================================
  Hits          435      435
  Misses        569      569
  Partials       43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

indeed, all these changes are useless, we only need https://github.com/massalabs/ui-kit/pull/168


Check for graph.windows.net sounds bogus

Azure.php:186 contains the following check:
if (strpos($this->urlAPI, "graph.windows.net") === TRUE)

As of PHP Docs, the strpos returns either FALSE or unsigned int. It never specifically returns TRUE.
Instead, I would expect the condition to be
if (strpos($this->urlAPI, "graph.windows.net") !== FALSE)

but I am not sure yet what the code is supposed to do.
It is also strange that if the condition would evaluate to true, the $url is always null so the condition  strrpos($url, "?") === false on line 193 always passes. As such, the complete url that the branch generates is ?api-version=1.6 (it completely ignores and missed the tenant and ref parts which is strange).

Yes you are absolutely right, could you please make a pull request to fix this?

I can for the condition. But I am not sure what is the supposed way to build the $url.

I will check on that and get back to you.

My guess that the following line is missing in the branch:
$url = $this->urlAPI.$ref;

I have merged the PR. I will be releasing it as 1.4.1 shortly. Thanks for the PR!

Hi, could you release the v1.4.1 update?  We've just updated from 1.3 in our dev and it's stopped working due to this bug!

Hi, I have just released 1.4.1.


Updated cyberzed work description

Title should say it all :D

Thanks for requesting the PR, merged.


DataProviders getting executed before starting test suit.

Here is my scenario,
1.I am creating some assets and then storing it in class.
2.Then I am passing each asset by using Data providers to other test methods.
3.But when I try to run testng.xml file,first thing getting executing is @Dataproviders method.Where it returns 0 objects.Then executes my first step(i.e creating a asset) and now dataprovider should provide data to the next running test,but its not.It's skipping test completely
I have tried dependsonmethods and dependsongroups.But no success

You don't explain why you want to do that and you don't share any concrete example.
It will be difficult to answser you.
And I don't see where is the issue here.

ok,Let me explain.Currently I am working on API Automation projects.Where first,I am creating assets using post request.
So lets say, I have created 10 assets,Now In one ArrayList I am storing all 10 asset ID's
and next I am providing dataProvider to second test,Dataprovider is defined like below.
`@DataProvider(name = "assets")
public static Object[][] getAssets(){
    AssetStore assetStore = AssetStore.getSharedInstance();
    Object[][] objects = new Object[assetStore.getAssets().size()][1];
    for (int i = 0; i < assetStore.getAssets().size(); i++) {
        objects[i][1] = assetStore.getAssets().get(i);
        objects[i][0] = STATUS_OK;
    }
    return objects;
}`

Here,when I ran test,It first executes this dataprovider method which returns 0(ZERO) objects,Then it starts test to create assets and skips next tests to whom I am providing above dataprovider.

Workflow of my Test.
 createAssetTest() {
  // Here I am creating asset and store ID returned by response in AssetStore class.
}
then I am providing data to second test method by providing this ID's as parameter.
testAssetTest(String id) {   // Here as dataprovider returned 0 ,this test is getting skipped. }
and I don't know why dataprovider method is getting executed before

I don't know why dataprovider method is getting executed before

Why not? TestNG doesn't guarantee when data provider is called. By default, it doesn't guarantee the order of tests.
The problem is your assumptions are wrong.
Why don't you create your assets in the data provider. It is what your are supposed to do.

@akashshinde Are we agree you configured dependOnMethods attribute?
@Test(dataProvider = "assets", dependsOnMethods = "createAssetTest")
public void testAssetTest(String id) {
}

@juherr Yes,I have added dependsOnGroups,even I tried with setting groups and adding group dependencies,still no luck
I set debugger to see whats going on,then I figured out testNG calculates all factory and data-provider data first before executing any test suite.That is the reason I am getting no data in data provider to run  tests with dynamic data provider.

Which version do you use? Could you try with 6.9.9?

Could you upgrade your examples with annotations?

For these kind of sitiautions i have used lazy loading DataProvider i.e where return type is Iterator<Object[]>.....which actually solved my issue.
so for your issue, it may change like
@DataProvider(name = "assets")
public static Iterator<Object[]> getAssets(){
AssetStore assetStore = AssetStore.getSharedInstance();
ArrayList<Object[]> alist=new ArrayList<Object[]>();
for (int i = 0; i < assetStore.getAssets().size(); i++) {
alist.add(new Object[]{assetStore.getAssets().get(i),"STATUS_OK"});
}
return alist.iterator();
}
Can you try this above and let us know

It could be a workarround but it should work with Object[][] too, and I was not able to reproduce @akashshinde issue.

@sandy999s using lazy providers,I am able to executes tests properly
@juherr yes I am using 6.9.9 version

Closing this issue based on above comment.

I have a similar usecase, In testng.xml suite file I have a bunch of tests and the run is controlled using preserver order. The last test in the  testng.xml uses @Factory with data provider annotations. When I execute the testng.xml suite file the @Dataprovider executes first.
Is there a way we can control the execution of @Dataprovider method just before the Test and not at the start of the test suite.
I have tried lazy loading approach also, but it did not work
Testng verison 6.14.3

If I understand well your need, I'd like to add a dependency between a test method and a data provider, and run the data provider after the test.
But by design, TestNG is first building the graph of tests, order them and then run them.
Running data providers is part of the first step.
I don't think we will change it soon.
@krmahadevan Do you see any workarround?

@juherr Let me state it again, the usecase is that the dataprovider method should be called just before the test which uses the dataprovider and not at the very begening of the test suite.
As per your above comment I understand that this type of usecase is not supported as how the TestNg is designed?

@juherr - I dont think we have any work-around for situations that involve a combo of @Factory and a dataProvider because as you already pointed out, TestNG first goes about instantiating test classes, binds those instances to the ITestNGMethod instances and then at a later stage the test methods get executed.
@saumildharia
Here's the summary

@Factory + data provider - Data provider is always called at the very beginning (irrespective of whether you use Object[][] for eager or Iterator<Object[]> for lazy loading)
@Test + data provider - Data provider is ONLY called when the @Test is about to be executed. Here you can use the Iterator model to make it lazy loading.

@krmahadevan @juherr Thanks for the info, in future is there a plan to add support for @Factory + data provider use case?

@saumildharia - It would require a bit of work in terms of revamping the TestNG internals. so cant commit for sure

@krmahadevan What if we override the iterator function to create the object?

@AdityaYadav29 - Not sure what you are talking about. But if you have a fix in mind, please feel free to propose a PR and we would be more than happy to help with the review

What I meant is, if we override the method of the iterator so that the object is created only when next() is called?

@AdityaYadav29 - I understand what you mean when you say "override the iterator function", but my question was more around where are you talking about ? The iterator's complete next() invocation happens at the very beginning itself when there's a @Factory + dataprovider combination, because TestNG first creates Test class objects and only then goes about using these instances to run tests. So it really doesn't matter what you do with the Iterator

Is it in your tests project (or)
Is it in TestNG ? If its in TestNG, as I already called out earlier, it is an invasive change and needs a bit more work to be done.

@krmahadevan thank you for the info. Yes it was in the TestNG. I was trying to achieve this while running the particular test after other test suites have run and I wanted to use the data that was being produced in one of the test as a @DataProvider with @Factor

If you are looking at sharing data between multiple <test> then you can make use of setAttribute() and getAttribute() in the ISuite object. But if you want to share data between multiple <suites> then you are better off in building your own data sharing mechanism that is singleton in nature.

Had similar issue and the Lazy implementation works fine for me too 👍


Revise Camera2D::setup_dimentional_projection To Not Modify Current Target Bitmap

setup_dimentional_projection currently modifies the current target bitmap.  Probably better to pass in a bitmap (which could be the current target, or a sub-bitmap), so that then the function can better manage state without making assumptions.

✅ Done in https://github.com/allegroflare/allegro_flare/commit/f34c95a17b5cc438942ad82d6997d7a46a441fb5


Primary Zone Designation for Swapping Windows in Secondary Zones

Description of the new feature / enhancement
It would be very useful if you could designate one zone as Primary and then be able to cause a window in a Secondary zone to Change Places with the current window in the primary zone.  You could click on the specific Secondary zone and it would change places with the window in the Primary zone.
Scenario when this would be used?
I like to use small zones with one bigger Main (Primary) zone where I can focus my work.  This would basically function as a Visual Application Switcher where you see all your app windows in small zones at the same time and choose which one to Switch to in the Primary (larger) 'working' zone.
Supporting information
No response

Can you provide any examples of programs or utilities which have a similar capability? /needinfo


(WIP) Initial Mapsui.UI.Uno.WinUI nuget package

Uno.WinUI Target

I'll continue when this is in because Uno does not really like central package management for now.
https://github.com/Mapsui/Mapsui/pull/1657

The Windows sample works now, I have to fix ios,android, ...

Known Problems, When the Dark mode is enabled in the Browser the Text of the Menus is not visible in Mapsui.Samples.Uno.WinUI.Wasm

Hi All,
I am just looking at this for an UnoPlatform project and wondering if this is available yet or in a future release?
Cliff.


Error profiling throughput grid for Skyplane on Azure

From #595
Run: skyplane experiments throughput-grid --no-enable-aws --no-enable-gcp --no-enable-gcp-standard
There seems to be multiple errors for different regions
19:47:38 [ERROR] Skipping region jioindiacentral
19:47:38 [ERROR] Failed to provision Azure instance in brazilsoutheast: (LocationNotAvailableForResourceType) The provided location 'brazilsoutheast' is not available for
resource type 'Microsoft.Network/virtualNetworks'. List of available regions for the resource type is
'westus,eastus,northeurope,westeurope,eastasia,southeastasia,northcentralus,southcentralus,centralus,eastus2,japaneast,japanwest,brazilsouth,australiaeast,australiasouthe
ast,centralindia,southindia,westindia,canadacentral,canadaeast,westcentralus,westus2,ukwest,uksouth,koreacentral,koreasouth,francecentral,australiacentral,southafricanort
h,uaenorth,switzerlandnorth,germanywestcentral,norwayeast,westus3,jioindiawest,swedencentral,qatarcentral'.
Code: LocationNotAvailableForResourceType

⠇ provision Azure ━━━━━━━━━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11/46 0:00:1919:47:55 [ERROR]  Instance Standard_D32_v5 not found in region centralus and could not infer a similar instance name.
19:47:55 [ERROR] Failed to provision Azure instance in centralus: Azure instance type Standard_D32_v5 is not available in region centralus. Please contact Azure support
to request capacity and then run `skyplane init --reinit-azure`.
19:47:55 [ERROR] Skipping region centralus
19:47:55 [ERROR]  Instance Standard_D32_v5 not found in region westcentralus and could not infer a similar instance name.

19:48:00 [ERROR] Skipping region uksouth
19:48:00 [ERROR] Failed to provision Azure instance in norwayeast: (OperationNotAllowed) Operation could not be completed as it results in exceeding approved Total
Regional Cores quota. Additional details - Deployment Model: Resource Manager, Location: NorwayEast, Current Limit: 10, Current Usage: 0, Additional Required: 32,
(Minimum) New Limit Required: 32. Submit a request for Quota increase at
https://aka.ms/ProdportalCRP/#blade/Microsoft_Azure_Capacity/UsageAndQuota.ReactView/Parameters/%7B%22subscriptionId%22:%2293f6e850-c67f-468d-972d-62859e413680%22,%22comm
and%22:%22openQuotaApprovalBlade%22,%22quotas%22:[%7B%22location%22:%22NorwayEast%22,%22providerId%22:%22Microsoft.Compute%22,%22resourceName%22:%22cores%22,%22quotaReque
st%22:%7B%22properties%22:%7B%22limit%22:32,%22unit%22:%22Count%22,%22name%22:%7B%22value%22:%22cores%22%7D%7D%7D%7D]%7D by specifying parameters listed in the ‘Details’
section for deployment to succeed. Please read more about quota limits at https://docs.microsoft.com/en-us/azure/azure-supportability/regional-quota-requests
Code: OperationNotAllowed

Hey @lynnliu030 I’m using Zenhub in GitHub, click this link to join my workspace and see other features available in GitHub or download the Zenhub extension and sign up with your GitHub account.
Posted using Zenhub


shift + alt+ f , code formatting  shortcut  broken

VSCode Version:

Version 1.1.0-insider
Commit 1f0657703be5609d70088b0385bc27db8cc03a41
Date 2016-05-03T07:20:40.394Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

OS Version:
windows 10

Steps to Reproduce:

Add test.html file
Input <html></html> tag in  test.html file.
shift+ alt+ f , code formatting  shortcut  is broken.
After shortcut(shift+ alt+ f ) key down, added <html> tag repeatedly

@leedonhyun I cannot reproduce. Is it possible you have installed extensions that interfere with or that overwrite the HTML formatting?

My vscode installed extensions are in the list of captured images below.

Hi! Im having the same error, every time that I format the code with the shorcut or the option menu it's repeating the last tag!
This is the version that I have:

And this is the error:

As you can see is always repeating the last element line

I didn't have this error before, this came out on this new version!


feat: JS Editor Toolbar

Description
Adds the redesigned toolbar in the JS editor experience. This change is behind a feature flag.
You would notice that there is a lot of repeated code, it is an intentional choice to repeat code instead of refactor and reuse as we essentially want to do a re design and not include any change in logic. All new components are created using the same logic blocks / components and just wrapped with our new design. This makes us debug issues during the transition easy and eventual removal of the old code much easier
Fixes #36920
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11382307363
Commit: 90e8a58e77a2ed8b66e961074fbcb6baa1055464
Cypress dashboard.
Tags: @tag.JS
Spec:
Thu, 17 Oct 2024 10:11:46 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit
Release Notes

New Features

Introduced a new JavaScript editor settings configuration for enhanced customization.
Added a custom React hook to manage application state effectively.
Launched the JSEditorToolbar component, consolidating editing functionalities.
New components for JavaScript function execution and settings management.

Bug Fixes

Improved rendering logic based on feature flags in the context menu and toolbar.

Tests

Implemented new test suites for various components to ensure functionality and rendering accuracy.

Chores

Cleaned up imports and constants, streamlining the codebase for better maintainability.

/build-deploy-preview skip-test=true

/build-deploy-preview skip-test=true

Non feature flag version is broken in this PR. As it pushed the run button to left hand side.

/build-deploy-preview skip-test=true


[tools] flutter screenshot  is failing with Error: Must have a connected device for screenshot type device

I am trying to take a screenshot of the app, but  it fails with unsupported device error. As far as I remember it used to work on stable 2.8.1. I did try taking screenshot on stable 2.8.1 but its failing there too, not sure what has changed.
Currently its not working, Neither on stable nor on master. I have an android device connected over ADB also verified by plugging in the cable but it still doesn't work. Also tried taking a screenshot from a ios simulator it fails too.
Steps to Reproduce

Run any flutter sample app on Android device
execute flutter screenshot

expected output: I would expect the tool to prompt to select a device when multiple devices are connected and take a screenshot and save it at root of the project.
actual output: fails with error
The list of connected devices are shown in the logs
Logs

Logs

when debugging wirelessly over ADB (stable)
mahesh@Maheshs-MacBook-Air-M1 functions % flutter devices
3 connected devices:

Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
mahesh@Maheshs-MacBook-Air-M1 functions % flutter screenshot
No supported devices connected.
The following devices were found, but are not supported by this project:
Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
Chrome (web)           • chrome           • web-javascript • Google Chrome 98.0.4758.80
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects
for these platforms.

Must have a connected device for screenshot type device

when cable is connected (stable)
mahesh@Maheshs-MacBook-Air-M1 functions % flutter screenshot
No supported devices connected.
The following devices were found, but are not supported by this project:
Redmi K20 Pro (mobile) • d9dac45d         • android-arm64  • Android 11 (API 30)
Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
Chrome (web)           • chrome           • web-javascript • Google Chrome 98.0.4758.80
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects
for these platforms.

Must have a connected device for screenshot type device

master logs
mahesh@Maheshs-MacBook-Air-M1 functions % flutterm screenshot
Could not load custom device from config index 0: Expected enabled to be a boolean.
No supported devices connected.
The following devices were found, but are not supported by this project:
Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
Chrome (web)           • chrome           • web-javascript • Google Chrome 98.0.4758.80
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects
for these platforms.

Must have a connected device for screenshot type device
mahesh@Maheshs-MacBook-Air-M1 functions %

IOS simulator connected
mahesh@Maheshs-MacBook-Air-M1 functions % flutter screenshot
No supported devices connected.
The following devices were found, but are not supported by this project:
Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API 30)
iPhone 12 Pro (mobile) • 14F40EC6-3B73-469A-A1C0-8CF0B152290F • ios            •
com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52 darwin-arm
Chrome (web)           • chrome                               • web-javascript • Google Chrome 98.0.4758.80
If you would like your app to run on android or ios or macos or web, consider running `flutter create .` to generate
projects for these platforms.

Must have a connected device for screenshot type device
mahesh@Maheshs-MacBook-Air-M1 functions %

flutter doctor -v
[✓] Flutter (Channel stable, 2.10.0, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.10.0 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (3 days ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API
      30)
    • iPhone 12 Pro (mobile) • 14F40EC6-3B73-469A-A1C0-8CF0B152290F • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52
      darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome
      98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 2.10.0-1.0.pre.371, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.10.0-1.0.pre.371 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d1285eef1b (2 days ago), 2022-02-02 00:50:20 -0500
    • Engine revision 5bbdb7a6f7
    • Dart version 2.17.0 (build 2.17.0-74.0.dev)
    • DevTools version 2.10.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API
      30)
    • iPhone 12 Pro (mobile) • 14F40EC6-3B73-469A-A1C0-8CF0B152290F • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52
      darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome
      98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Verified this on latest stable and master with iphone simulator as connected device along with macOS and web and running flutter screenshot generates the .png properly as below:
dhs@Dhss-MacBook-Pro testdemo % flutter devices
3 connected devices:

iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
macOS (desktop)            • macos                                • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
Chrome (web)               • chrome                               • web-javascript • Google Chrome 97.0.4692.99
dhs@Dhss-MacBook-Pro testdemo % flutter screenshot
Screenshot written to flutter_02.png (4852kB).
dhs@Dhss-MacBook-Pro testdemo %

Make sure the app you are running flutter screenshot supports and has android and ios folders.
If not, then even having mobile device or simulator connected won't run the flutter screenshot because the app doesn't support either platform:
See below for example:
dhs@Dhss-MacBook-Pro teste % flutter devices
3 connected devices:

iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
macOS (desktop)            • macos                                • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
Chrome (web)               • chrome                               • web-javascript • Google Chrome 97.0.4692.99
dhs@Dhss-MacBook-Pro teste % flutter screenshot
Multiple devices found:
macOS (desktop) • macos  • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
Chrome (web)    • chrome • web-javascript • Google Chrome 97.0.4692.99
[1]: macOS (macos)
[2]: Chrome (chrome)
Please choose one (To quit, press "q/Q"):

The app named teste doesn't contain android and iosfolders but runningflutter devicesshows simulator connected but while runningflutter screenshot` won't recognize the device.

This is working now, with the hotfix upgrade on the same device. Not sure what was wrong.

[✓] Flutter (Channel stable, 2.10.1, on macOS 12.1 21C52 darwin-arm, locale en-GB)
• Flutter version 2.10.1 at /Users/mahesh/Documents/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision db747aa133 (12 hours ago), 2022-02-09 13:57:35 -0600
• Engine revision ab46186b24
• Dart version 2.16.1
• DevTools version 2.9.2

Closing this issue for now.


dts: xtensa: esp32: Add device tree support.

add device tree support for esp32
Signed-off-by: Savinay Dharmappa<EMAIL_ADDRESS>

Codecov Report

Merging #7581 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7581   +/-   ##
=======================================
  Coverage   55.25%   55.25%
=======================================
  Files         468      468
  Lines       51671    51671
  Branches     9895     9895
=======================================
  Hits        28551    28551
  Misses      19207    19207
  Partials     3913     3913

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0514861...2c062a7. Read the comment docs.

Thanks for adding this! It would be nice if other devices were added to the device tree description as well, such as I2C, GPIO, pin mux, watchdog and LED PWM.

@SavinayDharmappa if I review, are you able to address comments?

@galak yes I will address the comments.

@galak waiting for your input :)

@galak will you provide any feedback here?


How to access the map.flyTo method and use it dynamically ?

@alex3165
I'm currently using the map.flyTo inside the
onStyleLoad={map => { }}
It's working fine but, the flyTo happens at the initial render
my goal is to update the map.flyTo options dynamically on button Click?
how can I achieve that?
is the map.flyTo provided as a prop?
here's my current code:
constructor(props) {
  super(props);
    this.state = {
      flyTo: { center: [-118.4107187, 33.9415889], zoom: 11, speed: 0.4 }
    }
      ...
      ...

    handleClickFlyDestinationAirport = () => {
      this.setState({ flyTo: { center: [-122.404357, 37.791246], zoom: 11, speed: 0.4 } })
    }

    <Map
       style="mapbox://styles/myAccount/vfvjiej45de7k"
       center={this.state.start}
       zoom={[9.8]}
       movingMethod="flyTo"
       containerStyle={{
         height: '100vh',
         width: '100vw'
       }}
       onStyleLoad={map => {
          map.addLayer({
             id: 'routes',
             type: 'line',
             source: {
               type: 'geojson',
                  data: {
                    type: 'FeatureCollection',
                    'features': [{
                        type: 'Feature',
                        properties: {
                          'color': 'blue',
                        },
                        geometry: this.state.geoJsonData1
                    }, {
                        type: 'Feature',
                        properties: {
                          'color': '#FF793F',
                        },
                        geometry: {
                            "type": "LineString",
                            "coordinates": [
                              this.state.start2,
                              this.state.destination2
                            ]
                        }
                    }, {
                        type: 'Feature',
                        properties: {
                          'color': 'green',
                        },
                        geometry: this.state.geoJsonData2
                    }]
                  }
                },
                paint: {
                  'line-width': 3,
                  'line-color': {
                    'type': 'identity',
                    'property': 'color'
                  }
                }
              }),
              map.flyTo(this.state.flyTo);
          }}
        />

<button className={css(styles.flyToButtonMap)} onClick={this.handleClickFlyDestinationAirport}>Fly to the dest Airport</button>

You could get a reference to your map by adding <Map ref={(e) => { this.map = e; }} />. After that you've got this.map available which you could set as a prop or state. You can call flyTo and any other method on it!

@aderaaij I got a reference to my map by following your advice, then I added it to the state in componentDidMount by doing this.setState({ mapRef: this.map }).
but how can I call the flyTomethod from within my clickHandler function ?

You don’t need to put refs in the state. It’s fine to read them from the instance where you already store it. In the click handler, you can call this.map.flyTo(), can you not?

Well when I use
handleClickFlyDestinationAirport = () => {
    this.map.flyTo({ center: [-118.4107187, 33.9415889] })
}

I get an Uncaught TypeError: _this.map.flyTo is not a function
HelpPage.js:81 Uncaught TypeError: _this.map.flyTo is not a function
    at HelpPage._this.handleClickFlyDestinationAirport (HelpPage.js:81)
    at HTMLUnknownElement.callCallback (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17388)
    at Object.invokeGuardedCallbackDev (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17427)
    at Object.invokeGuardedCallback (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17284)
    at Object.invokeGuardedCallbackAndCatchFirstError (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17298)
    at executeDispatch (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17682)
    at executeDispatchesInOrder (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17704)
    at executeDispatchesAndRelease (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17802)
    at executeDispatchesAndReleaseTopLevel (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17813)
    at Array.forEach (<anonymous>)
HelpPage._this.handleClickFlyDestinationAirport @ HelpPage.js:81
callCallback @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17388
invokeGuardedCallbackDev @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17427
invokeGuardedCallback @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17284
invokeGuardedCallbackAndCatchFirstError @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17298
executeDispatch @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17682
executeDispatchesInOrder @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17704
executeDispatchesAndRelease @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17802
executeDispatchesAndReleaseTopLevel @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17813
forEachAccumulated @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17781
processEventQueue @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17958
runEventQueueInBatch @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20453
handleTopLevel @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20462
handleTopLevelImpl @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20193
batchedUpdates @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:27928
batchedUpdates @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:19176
dispatchEvent @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20267
modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17456 Uncaught TypeError: _this.map.flyTo is not a function
    at HelpPage._this.handleClickFlyDestinationAirport (HelpPage.js:81)
    at HTMLUnknownElement.callCallback (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17388)
    at Object.invokeGuardedCallbackDev (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17427)
    at Object.invokeGuardedCallback (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17284)
    at Object.invokeGuardedCallbackAndCatchFirstError (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17298)
    at executeDispatch (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17682)
    at executeDispatchesInOrder (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17704)
    at executeDispatchesAndRelease (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17802)
    at executeDispatchesAndReleaseTopLevel (modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17813)
    at Array.forEach (<anonymous>)
HelpPage._this.handleClickFlyDestinationAirport @ HelpPage.js:81
callCallback @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17388
invokeGuardedCallbackDev @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17427
invokeGuardedCallback @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17284
invokeGuardedCallbackAndCatchFirstError @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17298
executeDispatch @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17682
executeDispatchesInOrder @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17704
executeDispatchesAndRelease @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17802
executeDispatchesAndReleaseTopLevel @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17813
forEachAccumulated @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17781
processEventQueue @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:17958
runEventQueueInBatch @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20453
handleTopLevel @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20462
handleTopLevelImpl @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20193
batchedUpdates @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:27928
batchedUpdates @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:19176
dispatchEvent @ modules.js?hash=04ceea1cc27f31ca61574df316b23853ebac8f98:20267

@aderaaij yes Arden, It's indeed working when I use this.map.state.map. I didn't try that because when I consoled logged earlier the method flyTo was not there.
quick question though, just to fully understand:
1- how come the this.map has a state.map ? can you please elaborate on that?
and thank you again for your help and guidance.

@aziz-boudi4 glad to hear it's working. When you get your ref to the map, it actually refers to the ReactMapboxGL component, which is a React component and not the map itself. The ReactMapboxGL component has the actual mapboxgl map in its state on which we can apply the normal mapbox API. To be honest, I'm not sure if this is the best way to get a reference to the map but I had the same problem as you and this seems to work fine for me!

@aderaaij great, well it's working for me as well.
maybe @alex3165 can tell us if there's a better way to do that

@aziz-boudi4 : I actually show an example of this exact idea in my post Declaratively Rendering Earth in 3D, Part 2: Controlling Cesium with React.  I'd encourage you to read through that post.  Your specific question is covered in the section where I talk about updating the camera position based on state changes.

Hey @aziz-boudi4, sorry for the late reply, thanks everyone for helping out on this issue. I would rather avoid calling map.flyTo manually, you can play with center and zoom props of the map component to achieve what you want to do. The purpose of the library is to abstract those manual calls to mapbox API.
Also instead of calling map.addLayer you can use the GeoJsonLayer component https://github.com/alex3165/react-mapbox-gl/blob/master/example/src/demos/geojsonLayer.tsx or you could even use Layer and Feature to render a line, see the allShapes example: https://github.com/alex3165/react-mapbox-gl/blob/master/example/src/demos/allShapes.tsx

@alex3165 thank you for the info Alex, oh you mean putting Center and Zoom on the state and updating them when the user clicks on a specific button? can I do the same thing for Bearing and Pitch which are options of the flyTo method?
Thank you, I will have a look at the examples you gave me, and try to use GeoJsonLayer

Just to make sure we're clear, it's a bad idea to read .state. of another component. State is typically considered private.
I'm finding it hard to understand what you're asking. If you created a tiny mockup with a fake map component just to illustrate the issue that would help.

Does anyone here know how you would center the map on a custom ShapeSource icon on click? The icon gets its coordinate from GeoJson. I've tried the following inside Shapesource, but it just takes me to the first location (not the icon's coordinates).
onPress={() => {this.map.flyTo(featureCollection.features[0].geometry.coordinates, 1000);}}


[Bug]: lint output sometimes overwritten by build progress messages

What happened?
The output of bazel lint sometimes gets overwritten by the progress messages from the bazel build command it is running under the hood. The behaviour is inconsistent; I believe the nondeterminism is a result of different build timing (e.g. cached vs. uncached actions and results).
Version
Development (host) and target OS/architectures:
❯ uname -a
Linux fedora 6.5.8-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Oct 20 15:53:48 UTC 2023 x86_64 GNU/Linux

Output of bazel --version:
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
❯ bazel version
Bazelisk version: v1.18.0
Aspect CLI version: 5.8.5
Build label: 6.4.0rc1
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Sep 19 22:59:22 2023<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Language(s) and/or frameworks involved:

rules_lint

How to reproduce
This can be observed in the example repo included in `rules_lint`.

* Clone https://github.com/aspect-build/rules_lint/tree/main .
* `cd example/`
* Apply minor fixes to make `bazel lint` work against example repo (https://github.com/aspect-build/rules_lint/pull/36, https://github.com/aspect-build/rules_lint/pull/37, https://github.com/aspect-build/rules_lint/pull/38).
* Run `bazel lint`.
* Inspecting the output carefully.

For instance, in the run below, it looks like there was some output from `//src:ts:` that got cutoff.

❮ bazel lint -- --java_runtime_version=remotejdk_11  src:all
INFO: Analyzed 7 targets (0 packages loaded, 0 targets configured).
INFO: Found 7 targets...
[0 / 1] [Prepa] BazelWorkspaceStatusAction stable-status.txt
From //src:foo:
src/Foo.java:9:	FinalizeOverloaded:	Finalize methods should not be overloaded
From //src:unused_import:
src/unused_import.py:13:1: F401 'os' imported but unused
From //src:unused_import:
src/unused_import.py:13:8: F401 [*] `os` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.
From //src:ts:
INFO: Elapsed time: 0.073s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

And inspecting the output files, it seems there is corresponding content that did not appear in the lint command's output.
❯ cat bazel-bin/src/ESLint.ts.aspect_rules_lint.report
src/file.ts:2:7: Type string trivially inferred from a string literal, remove type annotation  [error from @typescript-eslint/no-inferrable-types]

### Any other information?

_No response_

I agree, we need to buffer our output and not just grab a handle to the cli process stdout while Bazel may also be writing to it.


[Suggestion] Mouse-back in packages

Being able to use the back button on the mouse, or backspace on the keyboard, in order to navigate from a specific package page back to the package overview ("Packages") would be nice.
I also request that when navigating back to "Packages" that scroll position on the page is remembered.

Please reopen this on the atom/settings-view package and completely fill out the issue template.  Thanks!


Release @google-cloud/profiler v1.1.2

This pull request was generated using releasetool.

Release is at https://github.com/googleapis/cloud-profiler-nodejs/releases/tag/v1.1.2

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Point and Disk shader render always on top

Hi!
Thank you for sharing the project, it is awesome!
I just had a quick question. Is there anyway to make the point cloud take into consideration the depth of transparent and similar shader? Right now the depth only seems to work with opaque materials. When using transparent or particle systems (for example) on other objects in the scene, the point cloud renders on top of everything.

If you're using the legacy render pipeline (i.e. not using HDRP or Universal RP), the point could shader will be drawn before transparent materials, so it's thought to be a bug. Could you share a minimum project that can reproduce the issue in that case?

Sure, here is the link https://github.com/d3m3tr105/KejiroPointCloud.git . Indeed I was talking about the legacy pipeline. Do you have any idea how to go about this? Let me know if I can help.


windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。

windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。

From google translate: Under Windows, the memory occupied by the aqmtt service can be automatically released, but Linux has not been able to release it.
@linshengbin can you provide some more detail or information on the issue?

压测环境：
python 3.4.3
压测记录：
linux上起了broker。（Linux (none) 3.10.108-rt80-Cavium-Octeon+ #1 SMP Mon Aug 9 21:35:34 CST 2021 mips64 GNU/Linux）
然后windows启用了500个客户端id，进行client_publish循环压测。
VmRSS内存从20MB到100MB，等待一段时间（12小时左右）后，发现linux上的内存占用一直不释放，还是保持100088kb。
但windows端起的broker，内存降至18552KB。
------------------ 原始邮件 ------------------
发件人:                                                                                "Yakifo/amqtt"                                                                                @.>;
发送时间: 2021年9月24日(星期五) 下午4:35
@.>;
<EMAIL_ADDRESS>主题: Re: [Yakifo/amqtt] windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。 (#75)
From google translate: Under Windows, the memory occupied by the aqmtt service can be automatically released, but Linux has not been able to release it.
@linshengbin can you provide some more detail or information on the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

python 3.4.3

Wow, I don't think amqtt is going to work at all on such an old release of Python with its heavy-use of type annotations and async/await.

@.***/yield from。因为HBMQTT开源项目的社区已经没有更新了。所以只能通过这边来问问题了。
------------------ 原始邮件 ------------------
发件人:                                                                                "Yakifo/amqtt"                                                                                @.>;
发送时间: 2021年9月26日(星期天) 下午4:54
@.>;
<EMAIL_ADDRESS>主题: Re: [Yakifo/amqtt] windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。 (#75)
python 3.4.3
Wow, I don't think amqtt is going to work at all on such an old release of Python with its heavy-use of type annotations and async/await.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

(via Google Translate)

@.***/yield from. Because the HBMQTT open source project community has not been updated. So I can only ask questions through this side.

Yeah, it's fair to say, hbmqtt is pretty much history now.  Of course, it's an open-source project, as is amqtt; so nothing stopping you or anybody else forking the code and fixing it, but I wouldn't hold my breath on fixes to amqtt being backported to hbmqtt.

Linux (none) 3.10.108-rt80-Cavium-Octeon+

That implies this is some sort of embedded device (router perhaps) … maybe the build environment needs re-jigging to do it, but python3.7 does work in such environments.

@linshengbin could you share the code you use for load-testing?
So we could reproduce it

谢谢您的回复。我继续在Ubuntu的环境下测试高版本python特性的amqtt，看看是否能释放内存。
您之前有这样测试过吗？开500个客户端，持续测试一段时间。对比刚开启用amqtt broker时的内存占用对比。内存释放情况如何？
------------------ 原始邮件 ------------------
发件人:                                                                                "Yakifo/amqtt"                                                                                @.>;
发送时间: 2021年9月26日(星期天) 下午5:24
@.>;
<EMAIL_ADDRESS>主题: Re: [Yakifo/amqtt] windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。 (#75)
(via Google Translate)
@.***/yield from. Because the HBMQTT open source project community has not been updated. So I can only ask questions through this side.
Yeah, it's fair to say, hbmqtt is pretty much history now.  Of course, it's an open-source project, as is amqtt; so nothing stopping you or anybody else forking the code and fixing it, but I wouldn't hold my breath on fixes to amqtt being backported to hbmqtt.
Linux (none) 3.10.108-rt80-Cavium-Octeon+
That implies this is some sort of embedded device (router perhaps) … maybe the build environment needs re-jigging to do it, but python3.7 does work in such environments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

import logging
import asyncio
from amqtt.client import MQTTClient, ConnectException
logger = logging.getLogger(name)
async def t_coro():
while True:
ss = "CLIENT_ID_"
for i in range(0, 500):
try:
C = MQTTClient(client_id=ss + str(i))
await C.connect("mqtt://<IP_ADDRESS>:1883/")
await C.publish("a/b", b"TEST MESSAGE WITH QOS_0", qos=0x00)
await C.publish("a/b", b"TEST MESSAGE WITH QOS_1", qos=0x01)
await C.publish("a/b", b"TEST MESSAGE WITH QOS_2", qos=0x02)
await C.disconnect()
except ConnectException as ce:
logger.error("Connection failed: %s" % ce)
# asyncio.get_event_loop().stop()
if name == "main":
formatter = ("[%(asctime)s] %(name)s {%(filename)s:%(lineno)d} %(levelname)s - %(message)s")
logging.basicConfig(level=logging.ERROR, format=formatter)
asyncio.get_event_loop().run_until_complete(t_coro())
------------------ 原始邮件 ------------------
发件人:                                                                                "Yakifo/amqtt"                                                                                @.>;
发送时间: 2021年9月26日(星期天) 下午5:49
@.>;
<EMAIL_ADDRESS>主题: Re: [Yakifo/amqtt] windows下，aqmtt服务占用的内存能自动释放，但linux一直释放不了。 (#75)
@linshengbin could you share the code you use for load-testing?
So we could reproduce it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Also, small tip (which applies to amqtt in general too, I see the pattern there in lots of places):
            try:
                # … etc …
                pass
            except ConnectException as ce:
                logger.error("Connection failed: %s" % ce)

Not the best way to log an exception for two reasons:

% always formats the string, whether logger is configured to emit logs at error level or not
you miss out on the stack trace, which can be real handy for troubleshooting

logger.error("Connection failed: %s", ce) addresses (1) whilst ignoring (2).  The logging module has the exc_info keyword argument, which pretty much will do this for you… I'd write the above as:
            try:
                # … etc …
                pass
            except ConnectException:
                logger.error("Connection failed", exc_info=True)

Or, for error, there's a shortcut:
            try:
                # … etc …
                pass
            except ConnectException:
                logger.exception("Connection failed")


n/a

At first sight you would think the terminal does not support ANSI color code escapes.
I need to check if the terminal supports colors and act upon accordingly.
if [ -t 1 ]; then # This is an interactive terminal
    ncolors=$(tput colors) # And it supports colors
      # apply colors escapes prefix/suffix
...

:+1:


Fixes to CupertinoScrollbar minLength

Add ability to define minOverflowLength as well as minLength.
Fix for https://github.com/flutter/flutter/issues/18308

LGTM


Move referral to Archive section

As a CBO Referral App user, I want to archive referrals that no longer need active management so that I can keep the ones that are active readily available at the top.

Rename "Referral Management Dashboard" to "Active Referrals"
Add "Archived Referrals" section back in under the "Active Referrals" section
Add check box in referral modal to indicate that a referral should be archived
Display archived referral in the "Archived Referrals" section instead of "Active Referrals" section

@drdavec what FHIR resource would you recommend to capture the "Archive"? (If there is one.)

The active vs archived (inactive) status should be determined by the 'status' of a ServiceRequest and/or Task.  It's not a different FHIR resource.  For the Active Referrals, filter this view based on the status in an active state.  All others would be displayed in Archived view.

That sounds like a non-standard approach to state. I'd recommend adding an extension to the resource to indicate that it is archived.


Getting 'AssertionError: Could not compute output Tensor("dense/truediv:0", shape=(?, ?, 114), dtype=float32)' error with custom keras model

Hi,
I am trying to deploy custom Keras model on Sagemaker. I am following the https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/tensorflow_keras_cifar10 example to implement that.
I am getting 'AssertionError: Could not compute output Tensor("dense/truediv:0", shape=(?, ?, 114), dtype=float32)' error while training. The full trace back is as follows:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/container_support/training.py", line 36, in start
fw.train()
File "/usr/local/lib/python2.7/dist-packages/tf_container/train_entry_point.py", line 164, in train
train_wrapper.train()
File "/usr/local/lib/python2.7/dist-packages/tf_container/trainer.py", line 69, in train
estimator = self._build_estimator(run_config=run_config)
File "/usr/local/lib/python2.7/dist-packages/tf_container/trainer.py", line 95, in _build_estimator
model = self.customer_script.keras_model_fn(hyperparameters)
File "/opt/ml/code/spell_tensorflow.py", line 265, in keras_model_fn
model.compile(optimizer=tf.keras.optimizers.Adam(lr=lr), loss='categorical_crossentropy', metrics=['categorical_accuracy'])
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/keras/_impl/keras/engine/training.py", line 682, in compile
masks = self.compute_mask(self.inputs, mask=None)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/keras/_impl/keras/engine/topology.py", line 792, in compute_mask
_, output_masks = self._run_internal_graph(inputs, masks)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/layers/network.py", line 939, in _run_internal_graph
assert str(id(x)) in tensor_map, 'Could not compute output ' + str(x)
AssertionError: Could not compute output Tensor("dense/truediv:0", shape=(?, ?, 114), dtype=float32)
I am implementing LSTM seq to seq model. For that, I have to inputs to the model 'encoder inputs', decoder inputs'.
Any suggestions will be helpful...
Thanks,
Harathi

hi @Harathi123, can you provide your code and data so that we can reproduce the error on our end?

Hi @laurenyu,
I am able to train the model on my machine. It seems the issue is with the versions i am using and versions on sagemaker. I am using tensorflow 1.9 version and keras 2.2.2. But when i tried to give framework_version='1.9' in tensorflow estimator, I am getting the following error.
ValueError: Error training sagemaker-tensorflow-2018-08-22-16-38-13-997: Failed Reason: ClientError: Cannot pull algorithm container. Either the image does not exist or its permissions are incorrect.
Thanks,
Harathi

hi @Harathi123, there's not a good way to share the code privately, but as long as you can provide something similar (e.g. with fake data, etc.) that would allow someone else to run it and get the same error, that would be sufficient.
Unfortunately, we do not currently support TensorFlow 1.9 in SageMaker. We do expect to in the future, as we started with 1.4 and have launched a new container for all versions of TensorFlow since.
Can you use TensorFlow 1.8 in the meantime? If so, then don't specify framework_version arg when constructing an estimator.
If you need TensorFlow 1.9, then you'll want to build your own image (or just wait). You can find an example explaining how to create your own TensorFlow container here: https://github.com/awslabs/amazon-sagemaker-examples/blob/master/advanced_functionality/tensorflow_bring_your_own/tensorflow_bring_your_own.ipynb

Ok @laurenyu,
Please find the code below:
#!/usr/bin/env python3
from future import print_function
import tensorflow as tf
#from tensorflow.python.keras._impl.keras.backend.tensorflow_backend import set_session
from tensorflow.python.keras.layers import Input, LSTM, Dense, Bidirectional, Concatenate, GRU
from tensorflow.python.keras.models import Model
from tensorflow.python.keras import optimizers
#from tensorflow.python.keras.callbacks import ModelCheckpoint, TensorBoard, LearningRateScheduler
from tensorflow.python.saved_model.signature_constants import PREDICT_INPUTS
import numpy as np
import os
import logging
import json
logging.basicConfig(level=logging.DEBUG)
batch_size = 64  # Batch size for training.
epochs = 2
lr = 0.01
SAGEMAKER_DATA_PATH = '/opt/ml/input/data/training'
allows script to be executed inside and outside the container
base_dir = SAGEMAKER_DATA_PATH if os.path.exists(SAGEMAKER_DATA_PATH) else 'data'
np_files = np.load(os.path.join(base_dir, 'vocab.npz'))
vocab_to_int = np_files['vocab_to_int'].item()
int_to_vocab = np_files['int_to_vocab'].item()
max_sent_len = np_files['max_sent_len'].item()
min_sent_len = np_files['min_sent_len'].item()
with open(os.path.join(base_dir, 'variables.json'), 'r') as fp:
var_dict = json.load(fp)
input_characters = var_dict['input_characters']
num_encoder_tokens = var_dict['num_encoder_tokens']
num_decoder_tokens = var_dict['num_decoder_tokens']
max_encoder_seq_length = var_dict['max_encoder_seq_length']
max_decoder_seq_length = var_dict['max_decoder_seq_length']
latent_dim = 256 #Latent dimensionality of the encoding space.
def calculate_WER_sent(gt, pred):
'''
calculate_WER('calculating wer between two sentences', 'calculate wer between two sentences')
'''
gt_words = gt.lower().split(' ')
pred_words = pred.lower().split(' ')
d = np.zeros(((len(gt_words) + 1), (len(pred_words) + 1)), dtype=np.uint8)
# d = d.reshape((len(gt_words)+1, len(pred_words)+1))
# Initializing error matrix
for i in range(len(gt_words) + 1):
    for j in range(len(pred_words) + 1):
        if i == 0:
            d[0][j] = j
        elif j == 0:
            d[i][0] = i

# computation
for i in range(1, len(gt_words) + 1):
    for j in range(1, len(pred_words) + 1):
        if gt_words[i - 1] == pred_words[j - 1]:
            d[i][j] = d[i - 1][j - 1]
        else:
            substitution = d[i - 1][j - 1] + 1
            insertion = d[i][j - 1] + 1
            deletion = d[i - 1][j] + 1
            d[i][j] = min(substitution, insertion, deletion)
return d[len(gt_words)][len(pred_words)]

def calculate_WER(gt, pred):
'''
:param gt: list of sentences of the ground truth
:param pred: list of sentences of the predictions
both lists must have the same length
:return: accumulated WER
'''

assert len(gt) == len(pred)
WER = 0
nb_w = 0
for i in range(len(gt)):
    #print(gt[i])
    #print(pred[i])
    WER += calculate_WER_sent(gt[i], pred[i])
    nb_w += len(gt[i])

return WER / nb_w

def vectorize_data(input_texts, target_texts, max_encoder_seq_length, num_encoder_tokens, vocab_to_int):
'''Prepares the input text and targets into the proper seq2seq numpy arrays'''
encoder_input_data = np.zeros(
(len(input_texts), max_encoder_seq_length, num_encoder_tokens),
dtype='float32')
decoder_input_data = np.zeros(
(len(input_texts), max_decoder_seq_length, num_decoder_tokens),
dtype='float32')
decoder_target_data = np.zeros(
(len(input_texts), max_decoder_seq_length, num_decoder_tokens),
dtype='float32')
for i, (input_text, target_text) in enumerate(zip(input_texts, target_texts)):
    for t, char in enumerate(input_text):
        # c0..cn
        encoder_input_data[i, t, vocab_to_int[char]] = 1.
    for t, char in enumerate(target_text):
        # c0'..cm'
        # decoder_target_data is ahead of decoder_input_data by one timestep
        decoder_input_data[i, t, vocab_to_int[char]] = 1.
        if t > 0:
            # decoder_target_data will be ahead by one timestep
            # and will not include the start character.
            decoder_target_data[i, t - 1, vocab_to_int[char]] = 1.

return encoder_input_data, decoder_input_data, decoder_target_data

def decode_sequence(input_seq, encoder_model, decoder_model, num_decoder_tokens, int_to_vocab):
# Encode the input as state vectors.
states_value = encoder_model.predict(input_seq)
# Generate empty target sequence of length 1.
target_seq = np.zeros((1, 1, num_decoder_tokens))
# Populate the first character of target sequence with the start character.
target_seq[0, 0, vocab_to_int['\t']] = 1.

# Sampling loop for a batch of sequences
# (to simplify, here we assume a batch of size 1).
stop_condition = False
decoded_sentence = ''
while not stop_condition:
    output_tokens, h, c = decoder_model.predict(
        [target_seq] + states_value)

    # Sample a token
    sampled_token_index = np.argmax(output_tokens[0, -1, :])
    sampled_char = int_to_vocab[sampled_token_index]
    decoded_sentence += sampled_char

    # Exit condition: either hit max length
    # or find stop character.
    if (sampled_char == '\n' or
       len(decoded_sentence) > max_decoder_seq_length):
        stop_condition = True

    # Update the target sequence (of length 1).
    target_seq = np.zeros((1, 1, num_decoder_tokens))
    target_seq[0, 0, sampled_token_index] = 1.

    # Update states
    states_value = [h, c]

return decoded_sentence

def build_model(num_decoder_tokens, num_encoder_tokens, latent_dim):
# Define an input sequence and process it.
encoder_inputs = Input(shape=(None, num_encoder_tokens))
encoder = Bidirectional(LSTM(latent_dim, return_state=True)) # Bi LSTM
encoder_outputs, state_f_h, state_f_c, state_b_h, state_b_c = encoder(encoder_inputs)# Bi LSTM
state_h = Concatenate()([state_f_h, state_b_h])# Bi LSTM
state_c = Concatenate()([state_f_c, state_b_c])# Bi LSTM
# We discard `encoder_outputs` and only keep the states.
encoder_states = [state_h, state_c]# Bi GRU, LSTM, BHi LSTM

decoder_inputs = Input(shape=(None, num_decoder_tokens))
# We set up our decoder to return full output sequences,
# and to return internal states as well. We don't use the
# return states in the training model, but we will use them in inference.
decoder_lstm = LSTM(latent_dim*2, return_sequences=True, return_state=True)# Bi LSTM

decoder_outputs, _, _ = decoder_lstm(decoder_inputs, initial_state=encoder_states)

decoder_dense = Dense(num_decoder_tokens, activation='softmax')
decoder_outputs = decoder_dense(decoder_outputs)

# Define the model that will turn
# `encoder_input_data` & `decoder_input_data` into `decoder_target_data`
model = Model([encoder_inputs, decoder_inputs], decoder_outputs)
print('encoder-decoder  model:')
#print(model.summary())

encoder_model = Model(encoder_inputs, encoder_states)

decoder_state_input_h = Input(shape=(latent_dim*2,))# Bi LSTM
decoder_state_input_c = Input(shape=(latent_dim*2,)) # Bi LSTM

decoder_states_inputs = [decoder_state_input_h, decoder_state_input_c]

decoder_outputs, state_h, state_c = decoder_lstm(decoder_inputs, initial_state=decoder_states_inputs)

decoder_states = [state_h, state_c]
decoder_outputs = decoder_dense(decoder_outputs)
decoder_model = Model([decoder_inputs] + decoder_states_inputs, [decoder_outputs] + decoder_states)

return model, encoder_model, decoder_model

def exp_decay(epoch):
initial_lrate = 0.1
k = 0.1
lrate = initial_lrate * np.exp(-k*epoch)
return lrate
#lrate = LearningRateScheduler(exp_decay)
def step_decay(epoch):
initial_lrate = 0.1
drop = 0.5
epochs_drop = 10.0
lrate = initial_lrate * math.pow(drop, math.floor((1+epoch)/epochs_drop))
return lrate
#lrate = LearningRateScheduler(step_decay)
def keras_model_fn(hyperparameters):
logging.info('Training model.')

#model, encoder_model, decoder_model = build_model(num_decoder_tokens, num_encoder_tokens, latent_dim)
    # Define an input sequence and process it.
encoder_inputs = Input(shape=(None, num_encoder_tokens))
encoder = Bidirectional(LSTM(latent_dim, return_state=True)) # Bi LSTM
encoder_outputs, state_f_h, state_f_c, state_b_h, state_b_c = encoder(encoder_inputs)# Bi LSTM
state_h = Concatenate()([state_f_h, state_b_h])# Bi LSTM
state_c = Concatenate()([state_f_c, state_b_c])# Bi LSTM

# We discard `encoder_outputs` and only keep the states.
encoder_states = [state_h, state_c]# Bi GRU, LSTM, BHi LSTM

decoder_inputs = Input(shape=(None, num_decoder_tokens))
# We set up our decoder to return full output sequences,
# and to return internal states as well. We don't use the
# return states in the training model, but we will use them in inference.
decoder_lstm = LSTM(latent_dim*2, return_sequences=True, return_state=True)# Bi LSTM

decoder_outputs, _, _ = decoder_lstm(decoder_inputs, initial_state=encoder_states)

decoder_dense = Dense(num_decoder_tokens, activation='softmax')
decoder_outputs = decoder_dense(decoder_outputs)

# Define the model that will turn
# `encoder_input_data` & `decoder_input_data` into `decoder_target_data`
model = Model([encoder_inputs, decoder_inputs], decoder_outputs)
logging.info('encoder-decoder  model:')
print(model.summary())

encoder_model = Model(encoder_inputs, encoder_states)

decoder_state_input_h = Input(shape=(latent_dim*2,))# Bi LSTM
decoder_state_input_c = Input(shape=(latent_dim*2,)) # Bi LSTM

decoder_states_inputs = [decoder_state_input_h, decoder_state_input_c]

decoder_outputs, state_h, state_c = decoder_lstm(decoder_inputs, initial_state=decoder_states_inputs)

decoder_states = [state_h, state_c]
decoder_outputs = decoder_dense(decoder_outputs)
decoder_model = Model([decoder_inputs] + decoder_states_inputs, [decoder_outputs] + decoder_states)

logging.info('encoder_model')
print(encoder_model.summary())
logging.info('decoder_model')
print(decoder_model.summary())

model.compile(optimizer=tf.keras.optimizers.Adam(lr=lr), loss='categorical_crossentropy', metrics=['categorical_accuracy'])

return model

def serving_input_fn(hyperpameters):
tensor = tf.placeholder(tf.float32, shape=[None, max_sent_len])
inputs = {PREDICT_INPUTS: tensor}
return tf.estimator.export.ServingInputReceiver(inputs, inputs)
def train_input_fn(training_dir, hyperpameters):
logging.info("----------------------------------------train-------------------------------------------")

return generate_input_fn(training_dir, 'test_inputs.txt', 'test_targets.txt')

def eval_input_fn(training_dir, hyperpameters):
logging.info("----------------------------------------test-------------------------------------------")

return generate_input_fn(training_dir, 'train_inputs.txt', 'train_targets.txt')

def _generate_input_fn(training_dir, input_filename, target_filename):
logging.info('generator function')
with open (os.path.join(training_dir, input_filename), 'r') as f:
i_t = f.read()
with open (os.path.join(training_dir, target_filename), 'r') as f:
    t_t = f.read()

input_texts = i_t.split('\n')
target_texts = i_t.split('\n')
encoder_input_data, decoder_input_data, decoder_target_data = vectorize_data(input_texts=input_texts,
                                                                         target_texts=target_texts,
                                                                         max_encoder_seq_length=max_encoder_seq_length,
                                                                         num_encoder_tokens=num_encoder_tokens,
                                                                         vocab_to_int=vocab_to_int)

return {PREDICT_INPUTS: [encoder_input_data, decoder_input_data]}, decoder_target_data

hi @Harathi123, sorry for the delay. can you also include the code you're using to invoke SageMaker?

Hi @laurenyu , no problem!
This is the code I am using to invoke sagemaker:
import os
import sagemaker
from sagemaker import get_execution_role
sagemaker_session = sagemaker.Session()
role = get_execution_role()
inputs = sagemaker_session.upload_data(path='data', key_prefix='data/spell_tensor')
from sagemaker.tensorflow import TensorFlow
spell_estimator = TensorFlow(entry_point='spell_tensorflow_simple_concat.py',
role=role,
training_steps= 100,
evaluation_steps= 100,
hyperparameters={'learning_rate': 0.01},
train_instance_count=1,
train_instance_type='ml.c4.xlarge')
spell_estimator.fit(inputs)

Hi @laurenyu , any update on the issue...
Thanks,
Harathi

hi @Harathi123, sorry for the delayed response. I was able to reproduce your issue, but didn't yet find any noticeable causes.
I did notice that in your script, both train_input_fn and eval_input_fn call generate_input_fn instead of _generate_input_fn - was that intentional?
Also, are you able to run the Keras code locally without SageMaker?

Hi @laurenyu ,
Sorry, i forgot to update. I am able to train and deploy model with custom container created by following the sreps in the blog https://medium.com/@richardchen_81235/custom-keras-model-in-sagemaker-277a2831ac67
And I am able to run the code locally without sagemaker as well.
And regarding _generate_input_fn, its not intentional. It is a typo error. But it is not the reason for the issue as the issue is raising in keras_model_fn while loading model itself.
Thanks,
Harathi


Add the button on the empty list (mobile app)

Describe the task
Add the button on the empty list

[x] List NFT Collection: https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=3312-159538&mode=design&t=uro0UVEC4rvIPi8A-4
[x] List staking: https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=10208-591666&mode=design&t=uro0UVEC4rvIPi8A-4
[x] List token: https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=5809-142566&mode=design&t=uro0UVEC4rvIPi8A-4

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-218-1029-merge-2023-09-20T11-39-04.ipa
Device test: IP 11

[ ] Add the button empty list

[ ] Search token to get address
[ ] Search network in case have no result (Manage network, customize asset display)

[ ] Do not navigate to Import token when touch the button when search the token on the header
[ ] Handle the case where you have to press twice to switch screens

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-220-1029-merge-2023-09-26T03-57-56.ipa
Device test: IP 11

[ ] Can't navigate Import network on customize asset display screen

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-220-1029-merge-2023-09-26T04-59-19.ipa
Device test: IP 11
Validation passed.

@Quangdm-cdm Please re-check this issue:

[ ] Navigate incorrect in case search token to get address (All account)
Actual: Navigate to the Select Account screen
Expect: Navigate to Import token

[ ] Can't navigate in case select token when stake

@Quangdm-cdm please update the message on empty list following this page: https://www.notion.so/subwallet/Empty-state-e6f40f6f42c34b4fa0f0549bb262eb9c?pvs=4


Update Issue - 57597432

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 76.0

Operating System
Windows 7

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


Bug: Attempt to call funtion 'get_width' in base 'null instance' on a null instance.

Good day,
I'm just starting to test Dialogic and when I tried to run it with just one test character without images, it bugged.
Attempt to call funtion 'get_width' in base 'null instance' on a null instance.

Adding a picture to the test character fixes the bug.
Cordially,
RilDev

This is not happening any more in the branch 1.0 👍🏻
Thanks for the report!


[Suggestion] Add Laravel integration

I will start working on a broadway integration for Laravel this week / month.
Should I create a separate repository or, make a pull request once it's finished?

@MarkRedeman still working on this? I'd love to have this.

It's on my todo list, but I have two deadlines this month that take priority. I will probably start working on this again in February.

I'd be interested too. I'm playing with it in a test repo , haven't had the need for something special for laravel.
What do you have in mind for the "Laravel integration" ?
Cheers, :smiley:

I believe a separate repo is nice. Please integration for frameworks can be standalone.  Not to be tight to a library.

I was thinking the same thing, I also think it would be best to have it separate to keep this package clean.
I've started working on a Laravel Service Provider. I managed to get everything working, for the write side. Only, with a InMemoryEventStore. I would like to use the Broadway\EventStore\DBALEventStore but don't know how to get its dependencies. I'm using the Laravel-Doctrine package.
I've summarized the issue(s) on a gist. Would appreciate if someone could point me in the right direction.

@nWidart yes, basically I wanted to add some bindings like the LaravelBroadwayServiceProvider from your example app is doing and add the necessary migrations.
Since Laravel 5 has some nice command bus features, I wanted to wait for its release such that we can build upon those features.

Ah yes I understand. In theory it should be a matter of binding Broadway\CommandHandling\CommandBusInterface to a Laravel command bus, if it's compatible. Same for the events, since l5 will have that too.

Exactly. We could also make it compatible with L4, but I'm not sure if that will be necessary.

Got the write part completely working with the DBALEventStore. :smiley:
Now the read model... for which they aren't any documentation / examples.

@nWidart Does the demo app give you the read model example you need, or are you looking for something further?

I’m indeed looking at the demo app, but don’t find it very clear, yet. Probably just because I’m still getting used to ES/CQRS. A read model example with the parts/part manufacturer would have been nice, to stay in the same context.
I’m still confused on how the read model works. I understand it uses elastic search as a read model, but what’s the link with the event_store (mysql for instance) ?
Or does the read model somehow indexes something to ES, and reads it ? But that would defeat the purpose of separating the write/read.
On the PeopleThatBoughtThisProductAlsoBoughtController controller, I see that a find method is called on the repository, but can’t seem to find that find method on the EventSourcingRepository.
Also that controller doesn’t call the 2 classes inside the ReadModel namespace. Are they just there for demonstration of testing maybe ?
It’s late here so maybe I’m just missing something obvious. :)
I will actually try to implement a read model tomorrow based on the demo app.
Thank you,

A read model is created as a response on an event that happened.
In the demo application, you can find an example in the PeopleThatBoughtThisProductAlsoBoughtProjector.
A read model projector listens to events, the same events that are processed by the aggregate root. A projector uses a repository to create the read model, but this is not the EventSourcingRepository. It is a special read model repository, in the case of the demo application, it's the ElasticsearchRepository.
So the controller you were talking about actually does use both of the classes in the ReadModel namespace, they are just not type-hinted anywhere :smile: It queries the read model repository and returns the result as a JsonResponse.
Hope this clarifies it a bit..

I see, very helpful, thank you! Will implement this today hopefully. :)

@nWidart in your case you'd want the SimpleEventBus to subscribe to PartsThatWereManufacturedProjector and have the repository that is used by your handler extend the EventSourcingRepository, such that each of the events that is added to the repository is also published to your event bus.
See the BasketRepository on the broadway example repo for an example.
Subscribing to the eventbus can be done in any arbitrary place. In Laravel it is common to do this in an events.php file that is included in the global.php file, or in a service provider.

Oh okay, the EventStoreRepository should be used in the projector class. This is done here for now as a test. But the applyPartWasManufactured is still not called. Also tried a die&dump in the handle of the Broadway\ReadModelProjector class which is also not called.
About the location of the events, since laravel 5 uses Service Providers for pretty much everything, it might be a good idea to do it in a SP.

A first packaged version is available.
There are still things to polish, like the read model settings and its service provider. Also adding some custom artisan commands to generate commands+handlers.
Feedback welcome :smiley:

Closing this as it's been out there for a while now :smile:

:+1: :smile:


Shelldon spelling inconsistencies

🐛 Bug Report
Shelldon's name shows up incorrectly when you actually receive him as a pet

Fixed in next update


"Mârzănești", "Cernetu", "Teleormanu" and "Valea Părului" are listed in the drop-down menu

Description:
"Mârzănești", "Cernetu", "Teleormanu" and "Valea Părului" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Mârzănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Mârzănești, TELEORMAN (Mârzănești)" and "Comuna Mârzănești, TELEORMAN".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Cernetu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cernetu, TELEORMAN (Mârzănești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Teleormanu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Teleormanu, TELEORMAN (Mârzănești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Valea Părului" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Valea Părului, TELEORMAN (Mârzănești)".


Typescript definitions:  make aria-* props optional

Current typescript definitions have some aria-* props required when they should be optional.  This PR makes those props optional.
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[X] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Thanks, @rthadr . I don't think we have any internal projects using the type definitions yet. There are probably a fair number more.


[Bug]: Incompatibilty issue with file_picker

Platform
Android 12
Plugin
package_info_plus
Version
3.0.3
Flutter SDK
3.10.2
Steps to reproduce

Add following dependencies into the pubspec.yaml file:

  cupertino_icons: ^1.0.2
  percent_indicator: ^4.2.2
  datetime_picker_formfield: ^2.0.0
  video_player: ^2.4.4
  simple_horizontal_stepper: ^0.0.1
  url_launcher: ^6.0.17
  provider: ^6.0.3
  firebase_auth: ^4.2.2
  country_picker: ^2.0.15
  sms_autofill: ^2.2.0
  pinput: ^2.2.11
  http: ^0.13.4
  email_validator: ^2.0.1
  shared_preferences: ^2.0.15
  camera: ^0.10.0
  image_picker: ^0.8.4+11
  file_picker: ^4.5.1
  open_file_safe: ^3.2.1
  path_provider: ^2.0.9
  dio: ^4.0.6
  google_mlkit_pose_detection: ^0.5.0
  vector_math: any
  mime: ^1.0.2
  intl_phone_field: ^3.1.0
  chewie: ^1.3.6
  auto_orientation: ^2.2.1
  flick_video_player: ^0.5.0
  mockito: ^5.3.2
  visibility_detector: ^0.3.3
  firebase_messaging: ^14.2.0
  device_info: ^2.0.3
  permission_handler: ^10.2.0
  intl: ^0.17.0
  validators: ^3.0.0
  date_time_picker: ^2.0.0
  package_info_plus: ^3.0.3

flutter pub get

NOTE: Initially the problem was same as mentioned in #1525. So to avoid the error, I upgraded to version ^3.0.3 and ran into dependencies error.
Code Sample
No response
Logs
Here's the log:

fact: win32 >=2.7.0 <3.0.0-∞ depends on ffi ^2.0.0
SLVR:

  selecting win32 2.7.0
SLVR:

    selecting wakelock_web 0.4.0
SLVR:

      selecting wakelock_platform_interface 0.3.0
SLVR:

        selecting wakelock_macos 0.4.0
SLVR:

          selecting platform 3.1.0
SLVR:

            selecting xdg_directories 1.0.0
SLVR:

            derived: process ^4.0.0
SLVR:

              selecting petitparser 5.4.0
SLVR:

                selecting pointycastle 3.7.3
SLVR:

                  selecting fixnum 1.1.0
SLVR:

                    selecting process 4.2.4
SLVR:

                    fact: file_picker >=4.0.0 <5.0.0-∞ depends on ffi ^1.1.2
SLVR:

                    fact: file_picker >=3.0.0-nullsafety.0 depends on flutter from sdk
SLVR:

                    fact: file_picker >=4.0.1 <5.0.0-∞ depends on flutter_plugin_android_lifecycle ^2.0.2
SLVR:

                    fact: file_picker >=3.0.0-nullsafety.0 depends on flutter_web_plugins from sdk
SLVR:

                    fact: file_picker >=4.0.0 <5.2.11-∞ depends on path ^1.8.0
SLVR:

                    fact: file_picker >=3.0.0-nullsafety.3 <5.0.0-∞ depends on plugin_platform_interface ^2.0.0
SLVR:

                    fact: file_picker >=4.5.0 <5.0.0-∞ depends on win32 ^2.4.1
SLVR:

                    conflict: file_picker >=4.0.0 <5.0.0-∞ depends on ffi ^1.1.2
SLVR:

                    ! not ffi ^1.1.2 is satisfied by ffi ^2.0.1
SLVR:

                    ! which is caused by "package_info_plus >=3.0.0 depends on ffi ^2.0.1"
SLVR:

                    ! thus: file_picker >=4.0.0 <5.0.0-∞ is incompatible with package_info_plus >=3.0.0
SLVR:

                    ! file_picker >=4.0.0 <5.0.0-∞ is satisfied by file_picker ^4.5.1
SLVR:

                    ! which is caused by "urhab depends on file_picker ^4.5.1"
SLVR:

                    ! thus: package_info_plus >=3.0.0 is forbidden
SLVR:

                    ! package_info_plus >=3.0.0 is satisfied by package_info_plus ^3.0.3
SLVR:

                    ! which is caused by "urhab depends on package_info_plus ^3.0.3"
SLVR:

                    ! thus: version solving failed
SLVR: Version solving took 0:00:05.644906 seconds.
    | Tried 3 solutions.
FINE: Resolving dependencies finished (5.766s).
ERR : Because file_picker ^4.0.0 depends on ffi ^1.1.2 and package_info_plus >=3.0.0 depends on ffi ^2.0.1, file_picker ^4.0.0 is incompatible with
    |   package_info_plus >=3.0.0.

### Flutter Doctor

```shell
[✓] Flutter (Channel stable, 3.10.2, on Microsoft Windows [Version 10.0.22621.1778], locale en-IN)
    • Flutter version 3.10.2 on channel stable at C:\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (9 days ago), 2023-05-23 20:57:28 -0700
    • Engine revision 90fa3ae28f
    • Dart version 3.0.2
    • DevTools version 2.23.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\kavan\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[✓] VS Code (version 1.78.2)
    • VS Code at C:\Users\kavan\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.66.0

[✓] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.1778]
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.57

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Checklist before submitting a bug

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

You were right.
Though updating the version still gives dependency errors, but it's because of another package open_file_safe
Because package_info_plus >=3.0.0 depends on ffi ^2.0.1 and open_file_safe 3.2.3 depends on ffi ^1.0.0, package_info_plus >=3.0.0 is incompatible with open_file_safe 3.2.3.

Yes, but still it is open_file_safe that wasn't updated last 17 months and relies on older versions of ffi.
I would suggest to report the issue in open_file_safe asking the maintainer to update the plugin.
Or you can try to use dependency_overrides and fix ffi version to 2.0.1, for example. You can read more about overriding dependencies here: https://dart.dev/tools/pub/dependencies#dependency-overrides
Closing as it is not a bug on package_info_plus side`.


Is it possible to be real-time ? and can it input video ?

I am also think about this question.Do you make any progress?