Using git init -g before commands that use the GitHub API result in broken remote URLs

Using git init -g before any command that needs to access the API will not prompt for GitHub credentials but will instead set up broken remotes like git@github.com:/REPOSITORY.git and https://github.com//REPOSITORY.git.

I see what you mean. git init -g should prompt for authentication info like other commands. Thanks for reporting!


Uncaught TypeError: Cannot read property 'mapPane' of undefine

I added one condition to draw function and it seems good fix for me. Is there any reason why we did not add that condition ?
{
  key: "draw",
  value: function draw() {
    var mapPaneName = this.props.mapPaneName

    ;(0, _invariant2.default)(
      !!mapPaneName,
      "OverlayView requires either props.mapPaneName or props.defaultMapPaneName but got %s",
      mapPaneName
    )
    // https://developers.google.com/maps/documentation/javascript/3.exp/reference#MapPanes
    var mapPanes = this.state[_constants.OVERLAY_VIEW].getPanes()
       **// Added this part and it seems solve mapPane undefined and overlaytarget error**
      if(mapPanes) {
      mapPanes[mapPaneName].appendChild(this.containerElement)

          _reactDom2.default.unstable_renderSubtreeIntoContainer(
          this,
          _react2.default.Children.only(this.props.children),
          this.containerElement,
          this.onPositionElement
      )
      }

  },
},

Have the same problem with mapPanes


Update extensions-customscript.md with note on Update-AzureRmVM

Update extensions-customscript.md with "Do not use Custom Script Extension to run Update-AzureRmVM with the same VM as its parameter, since it will wait on itself.".

@VijayRod : Thanks for your contribution to the Azure documentation! The author, @danielsollondon, has been notified to review your proposed change.


Add auth token to ClientOptions

Support frida-server --token option

Looks like https://github.com/frida/node-dbus-next only used the parser logic from upstream.
The upstream repo looks dead, I would like to contribute a library for the same api but in typescript

Thanks! That would be awesome by the way.
I accidentally un-drafted this -- please let me know when it's ready to be merged 😊

🙌 for this PR it's ready to be merged, thanks
I am planning to port more interfaces. That's gonna be more future work

Just released this in<EMAIL_ADDRESS>:tada:


added RD danielle-monteiro

Docs Build status updates of commit e8b27de:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/danielle-monteiro.yml
:white_check_mark:Succeeded

rd/index.yml
:white_check_mark:Succeeded

rd/map.yml
:white_check_mark:Succeeded

rd/media/profiles/danielle-monteiro.jpg
:white_check_mark:Succeeded

rd/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


modified log level & sliceunique change

Signed-off-by: kevin xu<EMAIL_ADDRESS>

Codecov Report

Merging #496 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #496      +/-   ##
=========================================
- Coverage   41.36%   41.2%   -0.16%
=========================================
  Files          49      49
  Lines       12572   12572
=========================================
- Hits         5200    5180      -20
- Misses       6079    6094      +15
- Partials     1293    1298       +5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ff8e7...1d82e0f. Read the comment docs.


Generate dataset generator batch

when sigma_generator not None and batch_size != 1 in generate_dataset there was a dimension mismatch because x was taken from the class and not the dataloader
Checks to be done before submitting your PR

[x] python3 -m pytest tests/ runs successfully.
[x] black . runs successfully.
[x] make html runs successfully (in the docs/ directory).
[x] Updated docstrings related to the changes (as applicable).
[x] Added an entry to the CHANGELOG.rst.

Hi @apolychronou , thanks for flagging this issue.
Yes, you are correct, batch_size should be 1 where you highlighted.
I've just spotted a bigger error, physics_generator isn't actually being used in the data generation loops. I've raised that here: #319

Hi @Andrewwango ,
well it takes a step for each Physics operator.
I guess it should take a step for each batch


Unable to use sass/scss/styl for styling

I am able to use the simple .css but when I use .scss/.sass/.styl terminal throws me an error: TypeError: Cannot read property 'getters' of undefined.
My file structure:
.
|____xxx
| |____xxxx.pug
|____email-templates
| |____confirm-email
| | |____html.pug
| | |____style.sass

I had tried scss/styl but only simple css works.
I am using simple express routes to check if it works:
      newsletter.render(user, function (err, result) {
        if (err)
          console.log('Error while renderning confirmation newsletter: ', err);

        // result.html
        console.log('user: ', user);

        console.log(result);

        res.send(result.html);

        // result.text
      })

Help Please?

It's seems working for some reason now, don't know what was the bug, maybe there was some glitch in my code which was causing it. scss is working fine, hadn't tested less/stylus now.
Therefore, closing, for now.


Unstable protocols not showing up in docs

Is there a trick to get the unstable protocols to show up in the docs or is this a bug? The module "unstable" is not listed in the docs and when I search for documentation of unstable protocols (e.g. zwlr_layer_surface_v1) nothing shows up. When I create my own project in which I use the wayland-protocols crate with the feature flag "unstable_protocols" and use cargo doc --open to view the documentation I can find docs for zwlr_layer_surface_v1. Is this intended/expected behavior?

Unstable protocols are behind a feature flag in a wayland-protocol, so you should
cargo doc --open --features=unstable_protocols in a wayland-protocols crate.

Not sure what is missing, the layer-shell protocol do appear on docs.rs : https://docs.rs/wayland-protocols/0.27.0/wayland_protocols/wlr/unstable/layer_shell/v1/client/zwlr_layer_shell_v1/index.html
Are you activating both the client and unstable_protocols features?

I know about setting the features flag. I guess my description of the problem was not good enough.
When you go to https://docs.rs/wayland-protocols the module "unstable" is there and you can find everything. Same when building the docs yourself. When you open https://crates.io/crates/wayland-protocols and then click on documentation, you get forwarded to https://smithay.github.io/wayland-rs/wayland_protocols/. There the unstable module is missing and you can also not find them by searching for unstable protocols.

Changing documentation = "https://smithay.github.io/wayland-rs/wayland_protocols/" from the Cargo.toml to documentation = "https://docs.rs/wayland-protocols" would presumably fix this but I guess there is a reason why you chose to set your own link so I don't know how this can be fixed

Oh, ok I see, thanks for reporting this!
Well yes, looks like we need to change our CI so that it generates the docs with the features enabled, and I think we can forward the documentation =  entries in the Cargo.toml to point to docs.rs. Docs from the master branch are not the best entry point..


rename system install -> platform install

I don't see any benefit to this change. Especially as we look towards using CNAB to package/install riff, the system commands will likely go away in the future.


Code Review Suggestions

Hello everyone, here are some potential issues I've found so far:

[x] Some of scripts, eda.py, evaluate_mushroom_predictor.py, and fit_mushroom_classifier.py are currently in the root directory. We should move them to the scripts directory for organization.
[x] In line 99 of fit_mushroom_classifier.py, it looks like the numeric_correlation_matrix.csv file from split_n_preprocess.py is being overwritten by the cross validation table. We should fix this by changing the name of the saved CSV file to something like cv_results.csv
[x] Both evaluate_mushroom_classifier.py and fit_mushroom_classifier.py create confusion_matrix.png files. We should make sure they don't overwrite eachother by changing the one produced by fit_mushroom_classifier.py to train_confusion_matrix.png and the one produced by evaluate_mushroom_classifier.py to test_confusion_matrix.png
[x] In line 65 of eda.py, I would recommend we save the frequency tables to the tables directory, rather than the figures directory for consistency.
[x] In line 35 of fit_mushroom_classifier.py, the --plot-to argument seems to be unused in place of --results-to. We should remove this to avoid confusion.
[x] evaluate_mushroom_classifier.py should take in the cleaned test data, not the scaled test data. This is because the fitted model includes a preprocessor in the pipeline already.

Just one question for the frequency tables: if we save them as tables, there's not gonna be color gradients in the tables, would that be ok for our final report?


How can I track change state of unseen messages?

I will describe the problem. My server returns 20 latest messages and room information with the number of unread messages. Let's assume that the user has written 30 messages and he has not read them yet. Accordingly, in room.unreadCount I set the value to 30 and the user sees the number of unread messages in the list of rooms. But when the user opens the room, he will only see the last N-messages (for example, 10) that will be on the screen. And all these 10 messages should change the value of the message.seen from false to true. The remaining room.unreadCount - 10 messages that are above (off the screen) should change seen to true only if the user starts scrolling up and as soon as the message is visible on the screen, then change the value of message.seen.
Hence the questions.

How to track what message is on the screen?
Or how do I determine the first 10 messages that should be displayed on the screen?

Or tell me how to solve my problem in another way. Thanks in advance.

This logic should be written outside of the chat component, but you can check if messages are visible on the screen by using javascript, for example. You could probably trigger this function every time a user is scrolling.
function checkVisible(elm) {
  var rect = elm.getBoundingClientRect();
  var viewHeight = Math.max(document.documentElement.clientHeight, window.innerHeight);
  return !(rect.bottom < 0 || rect.top - viewHeight >= 0);
}

I assumed need to implement it outside of the chat component.
Thanks for the tip.


logstash and password issues

Hi guys, thanks for the job do it here.
I have a problem:
When i change the ELASTIC_PASSWORD variable, some services stop responding, for example everything starts fine, but logstash cannot connect to ES:
[2021-06-09T23:30:09,929][WARN ][logstash.outputs.elasticsearch][main] Attempted to resurrect connection to dead ES instance, but got an error. {:url=>"https://elastic:xxxxxx@elasticsearch:9200/", :error_type=>LogStash::Outputs::ElasticSearch::HttpClient::Pool::BadResponseCodeError, :error=>"Got response code '401' contacting Elasticsearch at URL 'https://elasticsearch:9200/'"}
[2021-06-09T23:30:15,043][WARN ][logstash.outputs.elasticsearch][main] Attempted to resurrect connection to dead ES instance, but got an error. {:url=>"https://elastic:xxxxxx@elasticsearch:9200/", :error_type=>LogStash::Outputs::ElasticSearch::HttpClient::Pool::BadResponseCodeError, :error=>"Got response code '401' contacting Elasticsearch at URL 'https://elasticsearch:9200/'"}
[2021-06-09T23:30:20,167][WARN ][logstash.outputs.elasticsearch][main] Attempted to resurrect connection to dead ES instance, but got an error. {:url=>"https://elastic:xxxxxx@elasticsearch:9200/", :error_type=>LogStash::Outputs::ElasticSearch::HttpClient::Pool::BadResponseCodeError, :error=>"Got response code '401' contacting Elasticsearch at URL 'https://elasticsearch:9200/'"}

Password haven't weird chars, lets say that the value, now is:
myPassword_HaveMoreThan20Chars.
Then,

docker-compose -f docker-compose.setup.yml run --rm certs
docker-compose up -d
Wait less than 5 minutes, access and voilà
docker logs -f logstash

Any ideas?
Kind regards!

@telekomancer can you try running the following to remove volumes and then rebuild the containers:
docker system prune —volumes
docker-compose -f docker-compose.setup.yml
docker-compose up —build —remove-orphans -d
let me know if that works or not.

Worst:

docker ps -a

9895abc6290d        elk-tls-docker_filebeat        "/usr/bin/tini -- /u…"   18 minutes ago      Up 18 minutes                   <IP_ADDRESS>:9000->9000/tcp   filebeat
543a8792e62a        elk-tls-docker_packetbeat      "/usr/bin/tini -- /u…"   18 minutes ago      Restarting (1) 57 seconds ago                            packetbeat
7ea502355ead        elk-tls-docker_metricbeat      "/usr/bin/tini -- /u…"   18 minutes ago      Up 18 minutes                                            metricbeat
6c2809b38625        elk-tls-docker_elastic-agent   "python3 /install.py"    18 minutes ago      Up 18 minutes                   <IP_ADDRESS>:22->22/tcp       elastic-agent
b8544d8403d8        elk-tls-docker_logstash        "/usr/local/bin/dock…"   18 minutes ago      Restarting (1) 57 seconds ago                            logstash
c210b978e2a7        elk-tls-docker_kibana          "/bin/tini -- /usr/l…"   18 minutes ago      Up 18 minutes                   <IP_ADDRESS>:5601->5601/tcp   kibana
9097d1fe7a33        elk-tls-docker_elasticsearch   "/bin/tini -- /usr/l…"   18 minutes ago      Restarting (1) 46 seconds ago                            elasticsearch

docker logs elasticsearch

Invalid maximum heap size: -Xmx"2g"
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Invalid maximum heap size: -Xmx"2g"
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Invalid maximum heap size: -Xmx"2g"
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

docker logs packetbeat

2021-06-10T14:10:25.742Z	INFO	[monitoring]	log/log.go:153	Uptime: 192.169181ms
2021-06-10T14:10:25.742Z	INFO	[monitoring]	log/log.go:130	Stopping metrics logging.
2021-06-10T14:10:25.742Z	INFO	instance/beat.go:465	packetbeat stopped.
2021-06-10T14:10:25.742Z	ERROR	instance/beat.go:971	Exiting: error connecting to Kibana: fail to get the Kibana version: HTTP GET request to https://kibana:5601/api/status fails: parsing kibana response: invalid character 'K' looking for beginning of value. Response: Kibana server is not ready yet.
Exiting: error connecting to Kibana: fail to get the Kibana version: HTTP GET request to https://kibana:5601/api/status fails: parsing kibana response: invalid character 'K' looking for beginning of value. Response: Kibana server is not ready yet.

docker logs logstash

Using bundled JDK: /usr/share/logstash/jdk
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
Invalid maximum heap size: -Xmx"1g"
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

And was a new install:
git clone https://github.com/swimlane/elk-tls-docker.git
cd elk-tls-docker/
docker system prune --volumes
docker-compose -f docker-compose.setup.yml
docker-compose -f docker-compose.setup.yml run --rm certs

.env file:

ELK_VERSION=7.12.0
ELASTIC_USERNAME="elastic"
ELASTIC_PASSWORD="Am_a_Secure_Password"

# Configuration Variables
ELASTICSEARCH_HEAP="2g"
LOGSTASH_HEAP="1g"
PACKETBEAT_HEAP="256m"
FILEBEAT_HEAP="256m"
METRICBEAT_HEAP="256m"
XPACK_ENCRYPTION_KEY="AmaLogStringAndSuperSecureDontHackMe_Please"

# Self signed TLS certificates
CA_PASSWORD="AmTheCAPassword"
CA_DAYS=3650
ELASTIC_DIR=/usr/share/elasticsearch
LOGSTASH_DIR=/usr/share/logstash
KIBANA_DIR=/usr/share/kibana
PACKETBEAT_DIR=/usr/share/packetbeat
FILEBEAT_DIR=/usr/share/filebeat
METRICBEAT_DIR=/usr/share/metricbeat

# Letsencrypt certificates
## Setting STAGING to true means it will generate self-signed certificates
## Setting STAGING to false means it will generate letsencrypt certificates
# STAGING=false
STAGING=true

# swag Configuration
#DOMAIN=mydomain.com
#SUBDOMAIN=kibana
#SUBFOLDER=kibana
<EMAIL_ADDRESS>#TIMEZONE=America/Chicago

BTW i get a 503 Error:

@telekomancer okay thanks for checking this. I think I’ll need to add some pre-hooks to change the password or share the keystone to all the containers once set. I’ll try and get to this soon.

Thanks for your support =)
god bless ya!

I just encountered the same issue. Updated the .env before running the compose file in a clean environment. Elasticsearch errors in the same way security index is unavailable. short circuiting retrieval of user [\"elastic\"].

Actually, if I remove " from that password as well, everything starts working. So the default example .env is a bit incorrect, but that can be fixed.

Hi @Avamander i don't understand very well your answer, if you replicate the same that i have, without double quotes on password, it works?

Yes. I saw the same error until.

This has been resolved.


Small design pass

tried to change very little but not be blinded (added dark mode) or have to read paragraphs that are super wide (added max paragraph size).

i should update the other demos


Can we set culture while exporting?

Hello,
After export, the dates are converted to US date. When DAY of month is 12 or less, it shows the date in "MM/DD/YYYY" format. But, when the DAY of month is greater than 12, the cell has text value (General format in excel). Can we set culture while converting the datatable to excel?

Would you provide the input data and the resulting excel file ?


Add enable biometrics screen to onboarding process

As a user, I want to be able to choose to turn on biometrics so that I can choose the level of security for myself
Acceptance Criteria
Scenario: Holder has successfully created their PIN during onboarding
Given the holder has successfully created their PIN during onboarding
When the Holder selects "Create PIN"
Then the Holder is taken to the Biometrics page
And the option "use device biometrics" is default selected
Scenario: Holder has chooses to use biometrics
Given the Holder has selected to use biometrics to unlock BC Wallet
When the Holder opens the app
Then they are prompted to use their highest secure biometrics settings from their device

@alexgmetcalf @knguyenBC Was this closed because of a superseding ticket not yet implemented? Just wondering if I should ignore this one?

@alexgmetcalf I think I see it in #421. If we could, maybe when we close a ticket we mention why and if relevant a takeover ticket?

I believe there was a duplicate ticket so we closed it. putting a reason why we closed it is a good idea.

Yes it was a duplicate of #421, good idea on the reasoning, I'll ask Clecio to do that going forwards.


Feature/initial implementation

What
Initial implementation of observation imports.
How to review
Check the code.
Who can review
Anyone

Todo:

implement dimension.Store. This is the object that calls the import API for the order of dimensions and the database ID's
implement dimension.IDCache - this is the in-memory cache of responses for database ID's
implement dimension.OrderCache - this is the in memory cache of the CSV header / order of dimensions.
observation.Mapper - parse the V4 csv row, and create an observation instance with populated dimension options
error.Handler - will send an error via Kafka message - just logs it ATM
error handling and test coverage needs improving.

looks good, but I am not confident that a batch.Commit() on one instanceID batch will not also be an inadvertent commit on any other instances also in progress (but not yet submitted to the db)

@gedge the batch is unaware of instances, it is just a batch of messages in the order they are consumed from Kafka. The idea is that unless all of the messages succeed in the batch (across different instances) - the offset will not be changed. We need to improve the handling of failures - possibly by adding failures to a topic to be reprocessed. This will allow a batch to be committed even though errors have occurred.


Preventing prototype pollution vulnerabilities

Goal
Preventing the __proto__ , constructor or prototype property from being used as a section in clear function of metadata-delegate.js
Changeset
Added condition if __proto__ || constructor || prototype tries to pass as a section in the clear function, it will not be executed.
Testing
Created 2 unit tests for checking 'constructor' and 'prototype'.
it doesn't seem easy to check whether proto keys can be overwritten

Yes, it was only for clear method. But I think it's a good point to do the same for add.


fix(Turntable): black screen and the song preview disappear when toggle the full app display

fix #714

Yeah, you are clearly trying to fight the bot. 😅 I think I'll remove the labeling and just use the assigning.

Yep! The bot automatically add the help wanted lable every time when i do an action, but i don't need it. 😂
Does the bot add lable based on the title? And sorry for the late reply.

Does the bot add lable based on the title?

Not anymore :D


Using In a Package

Hey there, this is a great package. I'm attempting to include it in a package I have that has a ton of generators, but it doesn't seem to be finding the classes.
I noticed the ServiceProvider only provides the GenerateWizardWizard command so I skipped loading that and just loaded that command into my GeneratorServiceProvider.
It works fine from inside a Laravel app via a generated console command, but when I call a command from my package I get an error that the $answer property doesn't exist:

Undefined property: MyPackage\Console\Commands\ScaffoldMakeCommand::$answer

Very strange, the steps work fine, it loads, asks all the questions perfectly, then blows up.
Any ideas?

Hi! Thanks for using the package and I'm very glad you like it :)
I scanned through the library a bit and couldn't find a single reference to an $answer property. The WizardCore has an $answers (plural) property which is a Collection of answers provided by the user, but nowhere is it accessed in singular form.
Is it possible you're trying to access the $answers property and accidentally omitted the last "s"?  If that's not the case you can share a link to your package and I can try and help find what's wrong


Regression: ARGO_BASE_HREF doesn't work

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug

What happened/what you expected to happen?
It seems the name change from BASE_HREF to ARGO_BASE_HREF breaks base href functionality.
Here is my deployment:

Here is the html output:

Server logs:

Version
v3.5.7

It seems the name change from BASE_HREF to ARGO_BASE_HREF breaks base href functionality

Er, #12653 is not part of any stable release and its upgrade notes are for 3.6, which you aren't on.

Version
v3.5.7

[x] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.

And this should work on :latest. Are you sure you tested with :latest as the issue template requires?

Here is my deployment:

Also please use text instead of images of code or logs; text is substantially more accessible

It sounds like there might be a regression in the Helm chart though, as I wrote up https://github.com/argoproj/argo-helm/pull/2756 for forward-compat, but failed to read my own release notes 4 months later that the typo means it won't work. I'll fix that ASAP


_httpReconnect always fails

Describe the bug
In the OTA process, I choice the HTTPS to download the image data. But it always fails in _httpReconnect.
Th reason is that in IotHttpsClient_Connect, it disconnects the connection by calling IotHttpsClient_Disconnect. IotHttpsClient_Disconnect  firstly calls  _networkDisconnect to disconnect the connection in which the _FLAG_RECEIVE_TASK_EXITED flag is cleared and the _FLAG_SHUTDOWN flag is set. Then IotHttpsClient_Disconnect  calls _networkDestroy to destroy the connect in which it asserts that connection flag _FLAG_RECEIVE_TASK_EXITED bit is set.
Proposed fix, in IotNetworkAfr_Destroy, the connection flag _FLAG_SHUTDOWN should be used in the assert instead of the _FLAG_RECEIVE_TASK_EXITED flag which has already be cleared in  IotNetworkAfr_Close.

I think the root cause of https://github.com/aws/amazon-freertos/issues/3073 is the same as this issue.

Hi @Sherryzhang2,
Thank you again for reporting this bug. I will close this issue. Please open another issue if you have any other questions or bug reports.
Thank you

@muneebahmed10 Thanks for your prompt fix.


Reduce the size of the Docker image

Photons may require gcc to build its dependencies, but it doesn't need it at runtime. I reduced the size of my lifx-daydusk container by about 100MB (from 243MB to 143MB) by adding:
apt-get purge -y gcc && \
apt-get autoremove -y

Obviously added after pip install lifx-photons-core command. It should have the same result for your Photons Interactor container image.

We can add that and then add a step to making the image to make sure it's a single layer

I'm ambivalent about squashing images, so I'll leave that up to you. :)

without squashing the image would still be just as large

I've rearranged the Dockerfile RUN directives in #24 which should result in a smaller image without needing to squash it further.


Named entities

Adds a NameComponent, that has one member: a name.
EntityService can be asked for a list of all the entities names (it fallbacks to a default name if there is no NameComponent).
Why?
When you pause the game it logs a big 'ol list of every entity's name, useful for manual debugging.
If we ever implement a console this can just be moved there.
I have taken the liberty of adding a NameComponent to all of your Entities so far, but if you add any more you'll need to name them yourselves.

@SIN-Willett can I delete this branch


Use 'attempted' to indicate the start of a new attempt

We should use the verb http://adlnet.gov/expapi/verbs/attempted to indicate the start of a new attempt alongside the verbs that indicate the start of a new session.

I rewrote section 5.0. It doesn't include 'attempted' but does outline the scorm temporal model. In a nutshell, verbs initialized/terminated begin and end an attempt; verbs suspended/resumed suspend the attempt.
https://github.com/adlnet/xAPI-SCORM-Profile/pull/30

That's a big difference to CMI5's use of initialized and terminated to mark the start and end of a session. Would be good to get these two overlapping draft specifications merged asap.

https://github.com/AICC/CMI-5_Spec_Current/blob/master/cmi5_runtime.md#722-first-statement-api-call
https://github.com/AICC/CMI-5_Spec_Current/blob/master/cmi5_runtime.md#93-verbs
Looking at that, it seems that this profile and CMI5 are very close. I think the only issue is that CMI5 is using http://www.aicc.org/cmi5/verbs, whereas this uses http://adlnet.gov/expapi/verbs.

nope i see some differences now that i've had a chance to look at it more.. thanks for bringing it up

CMI5 has changed and doesn't look to use attempted any more. Additionally they have switched to use the ADL verbs. I don't think a change to this doc is needed.


chore(LocallyConvex/Bounded): rename variables

Instead of introducing a normed field 𝕜 and a nontrivially normed field 𝕝,
prove a theorem for a normed field, then assume that 𝕜 is a nontrivially normed field.

bors merge

I'm going to wait for the larger update to be merged first.
bors r-

No, the larger update has conflicts with master, not with this branch.
bors merge


Add retry_with

When batch fetching items from DynamoDB, it can happen that not all items are delivered at once, but instead there are unprocessed_keys, which will need to be fetched again with exponential backoff. This is an attempt at making that happen easily.
It's meant as a first step. Ideally I would like a function that allows me catching both errors and certain results. But I thought I'd try this first to see if it's at all in line with what this project wants to do.

Thanks for surfacing a concrete usecase. I might be interested in folding something like this into https://github.com/softprops/dynomite/blob/master/dynomite/src/retry.rs

Is there something I should still do here?
Also regarding collect_and_retry, I've tried to implement it and I'm not sure how to do it without making S Clone. Would that be acceptable?

Sorry I had not gotten back to this. I got caught up in a few other projects. This looks good.


ensure atomic updates for ListConfig sliced assignment (#950)

omegaconf/listconfig.py (setitem): Operate on a copy
so any changes due to validation errors etc. are discarded.
Fixes issue #950

This works but is not very efficient.
It would be good to have a replace() method I think, that would avoid all the assignment checks etc.
Also ideally we would shallow copy the work list in this case.

I'll push this now, and we can optimize later


onFileChange event as param

Passing event as parameter on onFileChange callback, allows me retrieve more data from input file as name, type and size. It makes the export process more dynamic.
Reference about event: http://www.andygup.net/easily-find-image-type-in-javascript/

This is useful

This can also be achieved without passing parameter like below in callback:
onFileChange: function() {
 if(this.$fileInput.get(0).files) {
	var f = this.$fileInput.get(0).files[0];
	}
}

Yeap, you're right!

Thanks for the PR! This is useful. Merged into dev (ff9f3948763f0ccd8e00dbd0a5ab175013d37201).


[Bug report]

Bug report[full https repo variable is not respected if not to GitHub]
Setting repo variable to url other than organizaton/repository/GitHub is not respected by dev environment
Description
We run GitLab internally at https://gitlab..no. I add repo: https://gitlab.no/ to config.js
I have added repoLabel, editLink and editLinkText to config.js
Edit this page is not displayed when rendered by npm run dev(vuepress dev docs)
If I change the repo value to organizaton/repository, it displays and the link is to GitHub as expected.
Steps to reproduce
Add this to config.js:

repo: full url to something else than GitHub

repoLabel: "Anything"

editLink: true

editLinkText: "Anything"

Reproduction link / repo: Private OnPrem

Expected behavior
Same behaviour as for gitHub url
Screenshots
No screenshots
Environment info

Browser: Chrome 90.0.4430.93
Output of vuepress info:

System:

    OS: Linux 3.10 CentOS Linux 7 (Core)

    CPU: (4) x64 Intel(R) Xeon(R) CPU E5-2667 v4 @ 3.20GHz

    Memory: 879.01 MB / 7.64 GB

    Shell: 4.2.46 - /bin/bash

  Binaries:

    Node: 14.16.1 - /usr/bin/node

    Yarn: Not Found

    npm: 6.14.12 - /usr/bin/npm

  Utilities:

    Git: 2.18.4 - /opt/rh/rh-git218/root/usr/bin/git

  Browsers:

    Chrome: 90.0.4430.93

    Firefox: 78.10.0esr

  npmPackages:

    @vuepress/bundler-vite:  2.0.0-beta.14

    @vuepress/bundler-webpack:  2.0.0-beta.14

    @vuepress/cli:  undefined (2.0.0-beta.14)

    @vuepress/client:  2.0.0-beta.12

    @vuepress/core:  2.0.0-beta.14

    @vuepress/markdown:  2.0.0-beta.13

    @vuepress/plugin-active-header-links: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-back-to-top: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-container: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-debug: Not Found

    @vuepress/plugin-docsearch: Not Found

    @vuepress/plugin-git: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-google-analytics: Not Found

    @vuepress/plugin-medium-zoom: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-nprogress: ^2.0.0-beta.14 => 2.0.0-beta.14

    @vuepress/plugin-palette:  2.0.0-beta.14

    @vuepress/plugin-prismjs:  2.0.0-beta.14

    @vuepress/plugin-pwa: Not Found

    @vuepress/plugin-pwa-popup: Not Found

    @vuepress/plugin-register-components: Not Found

    @vuepress/plugin-search: Not Found

    @vuepress/plugin-shiki: Not Found

    @vuepress/plugin-theme-data:  2.0.0-beta.14

    @vuepress/plugin-toc: Not Found

    @vuepress/shared:  2.0.0-beta.7

    @vuepress/theme-default:  2.0.0-beta.14

    @vuepress/theme-vue: Not Found

    @vuepress/utils:  2.0.0-beta.11

    vue:  3.0.11

    vue-loader:  16.2.0

    vue-router:  4.0.8

    vuepress: ^2.0.0-beta.14 => 2.0.0-beta.14

    vuepress-vite: ^2.0.0-beta.14 => 2.0.0-beta.14

Sorry we cannot reproduce your problem.
You can reopen it once you provide a valid reproduction.

Consider to reopen based on these observations:
we run GitLab OnPrem at https://gitlab..no
This is not supported, the editLink does not render
Testet to write different content with syntax https://gitlab.com, https://github.com. They work, but as soon as we use https://gitlab..no, it fails to render.
This works in Vurepress 1.8.2
Tested on Mac and Ubuntu

See editLinkPattern

Sorry, my bad. It worked


docs: use the regular "O" for brand name and ".network" for domain

Self explanatory:
- ØKP4
+ OKP4

- okp4.com
+ okp4.network

Codecov Report

Merging #233 (af8eb6b) into main (1506772) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   96.10%   96.10%
=======================================
  Files          38       38
  Lines         359      359
  Branches       44       44
=======================================
  Hits          345      345
  Misses         12       12
  Partials        2        2

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Great, maybe we could also modify this line in the LICENSE file?

I don't think so if we are referring to the company (not the protocol).

Great, maybe we could also modify this line in the LICENSE file?

I don't think so if we are referring to the company (not the protocol).

I was also referring to the site OKP4.com

I don't think so if we are referring to the company (not the protocol).

I was also referring to the site OKP4.com

Oh, that's right. We need to change it too, I guess.

@fredericvilcot Tell me! ☺

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove unneeded Boost dependencies

I grep'd through the azmq source to check which Boost modules are actually needed, and I added/removed as necessary. Fails Travis CI xcode job, but everything else passes.

@solvingj ping :)

@solvingj I gonna merge this one, any objections?


Improve String#* with large multiplier

Create a large enough buffer from the start, prevent all the resizes/reallocs in the old code.
puts Benchmark.measure { "a"*1_000_000_000 }

On my system, this went from 7.2 seconds to 1.5 seconds (in release build). For comparison: MRI runs this in 0.4 seconds, JRuby in 0.3 seconds, TruffleRuby in 4.5 seconds.

We could probably improve even more if we would group some operations. For example: 'a' * 4 is now handled like this:
// c_str is the source object, buf is the result
char buf[5] = { 0 };
memcpy(buf, c_str, 1);
memcpy(buf + 1, c_str, 1);
memcpy(buf + 2, c_str, 1);
memcpy(buf + 3, c_str, 1);

This is like saying a + a + a + a. But we can use the intermediate results, so another option would be:
char buf[5] = { 0 };
memcpy(buf, c_str, 1);
memcpy(buf + 1, buf, 1);
memcpy(buf + 2, buf, 2); // buf == "aa", so copy two bytes at once.

Or: (a * 2) * 2. With n = 4, this only removed 1 operation, with n = 8 this will remove 4 operations. Complexity roughly goes down from O(n) to O(log n).


Adding CODE memory type and changing the API to: CODE,RW_DATA,DEVICE

Hi Ash,
Following your reply to me in the support case. I decided to pull request :).
The change include the following:

Adding CODE memory type - which is based on Normal memory type but it is Read-only executable,
Changing the API because now we have 3 types: CODE(based on Normal),RW_DATA(based on Normal), DEVICE (unchanged).

Ash,
Thank you for the review.
I have removed line 107.
Adding it as a flag is a good idea.
I added it in the first place because working without alignment check with DEVICE memory is pretty risky. If I am not mistaken "Arm trusted FW" enable it by default.
Regarding the CONTRIBUTORS you can add it on top of my commits.
Thanks,
Tal.

Hey Tal,
Many thanks for making the changes, I'll merge this in now. RE Alignment checking, note that unaligned accesses to Device type memory will always give an Alignment Fault, the SCTLR_ELx.A bit only applies to accesses to Normal type memory and causes the same Alignment Fault that you always get for Device memory.
You're right though that some projects set it by default, so I'll look to get the flag added soon :)
Thanks,
Ash.

Hi Tal, reverting and remerging this as a rebase rather than a squash so that it doesn't lose your author info (sorry, new to the way GitHub does things!)

Think that should look right now! Thanks again


Add state machine

Hi! recently i discovered this gem and i think was a good idea implement it for the state machine of status. Here is my first implementation. All test are green. Check it.

Coverage increased (+0.005%) to 99.762% when pulling ba25ba244500d61e0b6285e8d45b839cc6326a5f on ArmandoMendoza:add_state_machine into e88d14eaf66304a33ac4d9d32587c558b2b16e96 on sungwoncho:master.

Looks good.

Released in 0.1.4.


optimize SPDK build using docker caches

we already use ghcr.io/opiproject/opi-spdk:main
Now let's boost the build by using caches https://evilmartians.com/chronicles/build-images-on-github-actions-with-docker-layer-caching
now it takes 9m to build
example https://github.com/opiproject/opi-poc/actions/runs/2706962119

fixed


Wrong data logged.

I'm not sure is it a bug, but logger should print what is coming into the reducer not what's coming out of it (?)... anyway, I would like someone to explain me this situation:
  //  middleware config
  const middleware = [thunk, epicMiddleware];
  const logger = createLogger({ collapsed: true, diff: true });
  if (env.isDevelopment) middleware.push(logger); // tried with unshift too

Here are whats coming to reducer on FETCH_PRICING_PLANS_SUCCESS (notice lack of name field):

And here is what logger prints (notice name field):

And I bet this is because of that part of the code, where I use lodash defaultsDeep to append required properties that were not present in API response.
But my questions is, is it desired behavior or I'm doing something wrong? I think this happens because the object is being mutated and logger prints mutated object. But in this case, I don't care about backend response object being mutated and I would like to know what's coming with an action to the reducer.
I'm, just curious what's your thoughts.
P.S I think this could be related to #193 because logging happens after action hit the reducer.

The reason this is happening is because the reducer is mutating the action, which it shouldn't be doing. It is an anti-pattern for a reducer to mutate an action.
References: Redux docs / Redux co-author

fair enough

Well


Allow dotenv >= 0.7

Motivation
The current release of dotenv is 2.0.1 (April 3 2015).
I am a new user, so I don't yet know how dotenv is used in this project.  I cannot say for sure how this change will affect this gem's behavior.   It is not clear to me that dotenv is even used in this project; I don't see a call to Dotenv.load.
The ~> 0.7 conflicts with a couple of other gems I use.

Thanks, @jmoody.
To answer your question, Dotenv is used by the ipa command to load any stored credentials or the like into environment variables on execution. The strict versioning was unintentional.


Fixed a bug that desn't permit to send or receive a callback_game_t s…

…tructure even if it must be empty as specified by the official telegram api site.

CallbackGame
A placeholder, currently holds no information.

Looks good for me. Thanks for PR!


Source controller fails to correctly fetch the git repositories

Describe the bug
The bug manifests with errors on reconciliations such as apply failed: error: no objects passed to apply
❯ flux get kustomizations -A
NAMESPACE      NAME                                        READY    MESSAGE                                                            REVISION                                                                 SUSPENDED
flux-system    kube-prometheus-stack-crds                  False    apply failed: error: no objects passed to apply                    kube-prometheus-stack-15.1.3/8e4a0fed3c1ea36293f0e5af4001ccc8c4110293    False

or
kustomization path not found: stat /tmp/system-flux132511846/cluster/base: no such file or directory

It is due to the source controller not fetching the repository correctly (32 bytes tarball)
/data/gitrepository/flux-system/kube-prometheus-stack-crds $ ls -al
total 16
drwxr-sr-x    2 controll 1337          4096 Apr 22 22:47 .
drwxr-sr-x    6 controll 1337          4096 Apr 22 20:18 ..
-rw-r--r--    1 controll 1337            32 Apr 22 22:33 531ce5c7d64da93901b643a2b737d36117a2776a.tar.gz
lrwxrwxrwx    1 controll 1337           106 Apr 22 22:33 latest.tar.gz -> /data/gitrepository/flux-system/kube-prometheus-stack-crds/531ce5c7d64da93901b643a2b737d36117a2776a.tar.gz

Despite reporting success
❯ flux get source git -A
NAMESPACE      NAME                                        READY    MESSAGE                                                                                REVISION                                                                 SUSPENDED
flux-system    kube-prometheus-stack-crds                  True     Fetched revision: kube-prometheus-stack-15.2.0/531ce5c7d64da93901b643a2b737d36117a2776a    kube-prometheus-stack-15.2.0/531ce5c7d64da93901b643a2b737d36117a2776a    False

To Reproduce
Have a GitRepository
Reconcile it
Check the source controller data
Expected behavior
Repository not empty
Additional context
This bug was introduces with v0.13.0, previous version worked fine.
$ flux --version
flux version 0.13.0
$ flux check
► checking prerequisites
✔ kubectl 1.21.0 >=1.18.0-0
✔ Kubernetes 1.20.6+k3s1 >=1.16.0-0
► checking controllers
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.11.1
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.10.0
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.13.0
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.12.0
✔ all checks passed
$ kubectl -n <namespace> get all
NAME                                           READY   STATUS    RESTARTS   AGE
pod/kustomize-controller-78bdd99b66-d2nqm      1/1     Running   0          11h
pod/helm-controller-69667f94bc-jk9bj           1/1     Running   0          11h
pod/notification-controller-5c4d48f476-7k9rh   1/1     Running   0          11h
pod/source-controller-6c458cdb8d-jlzdn         1/1     Running   0          11h

NAME                              TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)   AGE
service/notification-controller   ClusterIP   <IP_ADDRESS>   <none>        80/TCP    28h
service/source-controller         ClusterIP   <IP_ADDRESS>    <none>        80/TCP    28h
service/webhook-receiver          ClusterIP   <IP_ADDRESS>    <none>        80/TCP    28h

NAME                                      READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/kustomize-controller      1/1     1            1           28h
deployment.apps/helm-controller           1/1     1            1           28h
deployment.apps/notification-controller   1/1     1            1           28h
deployment.apps/source-controller         1/1     1            1           28h

NAME                                                 DESIRED   CURRENT   READY   AGE
replicaset.apps/source-controller-785dd8f8b9         0         0         0       28h
replicaset.apps/kustomize-controller-78bdd99b66      1         1         1       11h
replicaset.apps/kustomize-controller-97dbdcb99       0         0         0       28h
replicaset.apps/helm-controller-69667f94bc           1         1         1       11h
replicaset.apps/helm-controller-5bbd94c75            0         0         0       28h
replicaset.apps/notification-controller-5c4d48f476   1         1         1       11h
replicaset.apps/notification-controller-d66bdc787    0         0         0       28h
replicaset.apps/source-controller-6c458cdb8d         1         1         1       11h
$ kubectl -n flux-system logs deploy/source-controller
{"level":"info","ts":"2021-04-23T06:48:06.075Z","logger":"controller.gitrepository","msg":"Reconciliation finished in 690.693629ms, next run in 30m0s","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"kube-prometheus-stack-crds","namespace":"flux-system"}
kubectl -n flux-system logs deploy/kustomize-controller
{"level":"error","ts":"2021-04-23T07:48:01.553Z","logger":"controller.kustomization","msg":"Reconciliation failed after 422.112691ms, next try in 30m0s","reconciler group":"kustomize.toolkit.fluxcd.io","reconciler kind":"Kustomization","name":"kube-prometheus-stack-crds","namespace":"flux-system","revision":"kube-prometheus-stack-15.2.0/531ce5c7d64da93901b643a2b737d36117a2776a","error":"apply failed: error: no objects passed to apply\n"}

@Diaoul as a workaround until we fix this, you can now tell helm-controller to do the CRDs upgrade, no need to use a Kustomization anymore, see https://toolkit.fluxcd.io/components/helm/helmreleases/#crds

Have identified the core of the issue, will work on a patch that should be released later today.

@Diaoul as a workaround until we fix this, you can now tell helm-controller to do the CRDs upgrade, no need to use a Kustomization anymore, see https://toolkit.fluxcd.io/components/helm/helmreleases/#crds

That works for helm charts that package CRDs, however in kube-prometheus-stack they were remove and you have to apply them manually.

Pulling in v0.12.1 of the source-controller should solve this issue, flux release is building.

Awesome, thanks for the quick fix!

Is it possible this bug could have re-surfaced? With just a test k8s cluster (docker desktop), I am trying to install flux2, and point to folder in my repository, ./tooling-eks/clusters/staging (based off https://github.com/fluxcd/flux2-kustomize-helm-example, but throwing everything under an addl. parent folder)
Repo structure:
liam:flux2-testing$ tree tooling-eks/
tooling-eks/
├── apps
│   ├── base
│   │   └── podinfo
│   │       ├── kustomization.yaml
│   │       ├── namespace.yaml
│   │       └── release.yaml
│   ├── production
│   │   ├── kustomization.yaml
│   │   └── podinfo-values.yaml
│   └── staging
│       ├── kustomization.yaml
│       └── podinfo-values.yaml
├── clusters
│   ├── production
│   │   ├── apps.yaml
│   │   └── infrastructure.yaml
│   └── staging
│       ├── apps.yaml
│       └── infrastructure.yaml
└── infrastructure
    ├── kustomization.yaml
    ├── nginx
    │   ├── kustomization.yaml
    │   ├── namespace.yaml
    │   └── release.yaml
    ├── redis
    │   ├── kustomization.yaml
    │   ├── kustomizeconfig.yaml
    │   ├── namespace.yaml
    │   ├── release.yaml
    │   └── values.yaml
    └── sources
        ├── bitnami.yaml
        ├── kustomization.yaml
        └── podinfo.yaml

Creating the source with:
$ flux create source git staging --url<EMAIL_ADDRESS>--branch main --interval 30s

$ flux get sources git -A
NAMESPACE       NAME    READY   MESSAGE                                                         REVISION                                        SUSPENDED
flux-system     staging True    Fetched revision: main/76154b7474b7ed488a23fd0ef57899f8ff0dbb1d main/76154b7474b7ed488a23fd0ef57899f8ff0dbb1d   False

It successfully pulls the right branch and commit. Looking at the files on the pod, under /data/gitrepository/flux-system/staging/, it almost looks as though the tar files are empty. trying to cp the files using kubectl onto my local machine, when I tar -l, nothing is returned...
/data/gitrepository/flux-system/staging $ ls -lah
total 16K
drwxr-sr-x    2 controll 1337        4.0K Aug  5 16:32 .
drwxr-sr-x    3 controll 1337        4.0K Aug  5 16:31 ..
-rw-r--r--    1 controll 1337          32 Aug  5 16:31 76154b7474b7ed488a23fd0ef57899f8ff0dbb1d.tar.gz
lrwxrwxrwx    1 controll 1337          87 Aug  5 16:31 latest.tar.gz -> /data/gitrepository/flux-system/staging/76154b7474b7ed488a23fd0ef57899f8ff0dbb1d.tar.gz

Tried similar with source-controller version v0.15.3, and similar issues, 32 byte file, but I am still unable to read the tar files or get anything form them. Trying to extract them, and it returns successfully, without extracting any files.
And ofc when I try and setup a kustomization based off the source, it says files don't exist (this is on source-controller v0.12.1):
$ flux create kustomization staging --source=GitRepository/staging --path="./tooling-eks/clusters/staging/" --prune=true
✚ generating Kustomization
► applying Kustomization
✔ Kustomization created
◎ waiting for Kustomization reconciliation
✗ kustomization path not found: stat /tmp/staging242136554/tooling-eks/clusters/staging: no such file or directory

Maybe I'm missing something simple here. I tried running v0.15.3 of the source-controller as well.
Any addl. info I can provide?

Any chance the https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/.sourceignore is still the same, and excluding your directory?

Any chance the https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/.sourceignore is still the same, and excluding your directory?

Fuck. I didn't realize this was a thing. I have been troubleshooting this the entire WEEK, I am not sure how I didn't see this...
Thanks, looks like it's just me being dumb. 🤦🏻


Add dhirschfeld as maintainer

Since the CI failed this didn't happen automatically.

@conda-forge-admin, please update team

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the team with maintainers from master.


Lorem Ipsum Randomness

The Lorem Ipsum functions dont seem to be using any randomness. I'll take a crack at fixing them, those they don't seem to follow the same general idea the other generators use?

It was probably the wrong choice, but it's made to always start at the beginning so people get that familiar "Lorem ipsum" to start. You can pass :random => true to get randomness.

Any way we could get it to remember that as a default? Forgery::LoremIpsum.be_random = true

That'd be cool. :)


CAMEL-18707: Upgrade to Jandex 3.0.3

Change maven group to io.smallrye.
Adapt to minor API changes in Jandex 3.

Jandex is also declared as a dependency in the spring-boot project by camel-spring-boot-generator-maven-plugin but it isn't used.
Camel-quarkus uses the jandex version from quarkus (currently 3.0.1) in extensions, but it uses version 1.0.8 of the jandex-maven-plugin in some integration-test pom files. Should that be updated to use 3.0.3 of the jandex plugin from io.smallrye?

camel-quarkus team will take care of jandex upgrade in that project
If jandex is not used in spring boot, then you are welcome to remove it there.


Doesn't work in multi-action unless it's the first item

If you have a multi-action with a Discord Message action inside it, if the Discord Message action isn't the first in the list, it doesn't seem to trigger.

I had the same problem, so I tried setting it up as a single action (worked fine), then if I right-clicked and sent it to a multiaction, it failed.

This is probably because I wrote this plugin before multi-actions where a thing. Seems like I'll need to make updates to the code while following the most recent version of the Stream Deck example plugin for Javascript to see if I can fix the issue.

That’d be great – I reordered my multi-actions so that your action comes first, but there are times when it’d be better put later on… 😊
Shaun
From: LogicallySound @.>
Sent: 28 March 2022 00:45
To: logicallysound/streamdeck-discord-message @.>
Cc: shaunpond @.>; Comment @.>
Subject: Re: [logicallysound/streamdeck-discord-message] Doesn't work in multi-action unless it's the first item (#16)
This is probably because I wrote this plugin before multi-actions where a thing. Seems like I'll need to make updates to the code while following the most recent version of the Stream Deck example plugin for Javascript to see if I can fix the issue.
—
Reply to this email directly, view it on GitHub https://github.com/logicallysound/streamdeck-discord-message/issues/16#issuecomment-1080046197 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4XBDC37ZKAO5LDPBDBNZLVCDXJBANCNFSM5DTDFCKQ .
You are receiving this because you commented.  https://github.com/notifications/beacon/AE4XBDEVAVLW7KTLXNIEOITVCDXJBA5CNFSM5DTDFCK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIBQDE5I.gif Message ID: @.*** @.***> >


Begin adding SlideOver component

This introduces a basic SlideOver component adapted from the existing Modal.
TODO:

Work out how to handle max-height/max-width, if at all.
Add RTL/writing mode support.
Make any further changes as requested by the Petal components core developers.

Some gifs:
Mobile view:

Desktop view:

As mentioned in the commit message/top comment above, I'm also still in the process of deciding what to do with max-width/max-height - the Modal sets a max-width, but a similar size restriction may need to be handled differently for the SlideOver given that the longest dimension of the content block may be either horizontal or vertical. Open to suggestions...
I'm interested in any other comments about my initial implementation so far as well.

Code looks good to me. Will have more of a play with it today. Yeah sizing could be an issue. I noticed Tailwind UI leave a gap on the side even on mobile. Not sure if that's better or worse though - will chat about with Nic today

Hi @ethancrawford , we are happy enough to pull this in and make some minor style changes. What did you mean by "Add RTL/writing mode support." ?

My thoughts were just to use [logical properties and values]https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties where useful (or otherwise handle RTL writing with JavaScript if necessary) and ensure that different writing modes would be supported 🙂

(Such that by adding something like dir="rtl" to the html, things 'just worked')

maybe for now anyone who wants that can do it inside the inner_block? eg.
<.slide_over>

Write this text right-to-left!

<./slide_over>

Happy for you to merge now if you want to. I think ultimately using logical properties/values where they can be is a good step in the long run, if you're happy to consider it - but sure, it's not an immediate blocker 👍

Yep maybe for now we just get it out and it will cover most use cases, and then can accept PR's to fine tune it. Thanks a lot for this

You're welcome, looking forward to using it!


Add support for Particle devices (www.particle.io)

Particle offers onboard WiFi (Spark/Particle Core and Particle Photon) and 2G/3G (Particle Electron soon to come) with a certain degree of Arduino compatibility.
I just love these devices and want to see them supported by this lib out the box.

ITEAD doesn't like pull requests


mcollective::actionpolicy issue (default field)

Hi all,
just started to use this module so I don't know if this is my issue or what, but I'm trying to use this declaration in a node manifest, after mcollective:
  mcollective::actionpolicy { 'nrpe':
    default => 'deny',
  }

but no matter what I try, I always get this error:
Err: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at 'default'; expected '}'
I tried to follow exactly the docs, without success, so I'm wondering if this is an issue or not.
puppetversion => 2.7.23

It appears that default is a reserved word according to https://docs.puppetlabs.com/puppet/latest/reference/lang_reserved.html and thus the mcollective::actionpolicy attribute should be renamed before this will work. My guess is that no one has tried it since default became reserved...

~_~
so, rename, major bump, ADD TESTS.
any volunteers?

Hello:
Is this still an issue?


How to build goaccess with GeoIP support

Dude, you have a very bad faq on website...
I made the following and can't find GeoIP in report section...
sudo apt-get install libncursesw5-dev libgeoip-dev
wget http://tar.goaccess.io/goaccess-1.0.2.tar.gz
tar -xzvf goaccess-1.0.2.tar.gz
cd goaccess-1.0.2/
sudo ./configure --enable-geoip=mmdb --enable-utf8
sudo make
sudo make install

also can you explain step by step shy do i need for real-time report?
thanks

The download and man page list the GeoIP config options, so since you are using mmdb, it requires  GeoIP2 databases which you need to install from source as it is not on the debian/ubuntu repo. However, if you want to make things easier, just configure goaccess using --enable-geoip=legacy and it should work out of the box.
For a real time HTML report, all you need is to run goaccess with --real-time-html and save your output report to your web server's public www folder, e.g., /var/www/mysite.com/report.html. Then you should be able  to point your browser to mysite.com/report.html. For instance,
goaccess access.log -o /var/www/mysite.com/report.html --real-time-html

Thanks for fast answer.
--enable-geoip=legacy
i got an error message:
goaccess: unrecognized option '--geoip-database'

Please download the latest version of goaccess.

Do i need make uninstall prior to installing the new version?

Yes, you do:
$ curl tar.goaccess.io/goaccess-1.2.tar.gz | tar xvz
$ cd goaccess-1.2/
$ sudo make uninstall
$ ./configure --enable-geoip=legacy --enable-utf8
$ make
$ sudo make install


How can I make Exclusive Fullscreen work?

editing conf.lua correctly sets exclusive fullscreen but the resolution has to be entered manually. I would like to programmatically detect the user's screen resolution, however every entrypoint that I tried placing love.window.setMode causes the assets to disappear entirely. I'm not sure what the right function call or placement I should be making the fullscreen toggle.

I don't understand what could be causing this problem. Maybe it's because of the difference in aspect ratio between windowed and fullscreen?


Storybooks occasionally dies completely

When this happens you have to go back to the native app, then go back into storybooks. This happened on both 2.4.x and after #561 moved us to 3.0.0.

This isn’t just with storybooks, it’s related to having ‘debug JS remotely’ enabled.

I'm not certain - I don't do that normally, are you mixing it with this issue: https://github.com/facebook/react-native/issues/12223

Oh… maybe? Or just a DEBUG build. We definitely have this with other VCs during dev.


Add annotation to exclude containers from injection.

Description
Allow to exclude containers from injection based on their names with annotations on Dynakube or pod level.
How can this be tested?
Deploy a Dynakube and an application.
Add annotation container.inject.dynatrace.com/<containername> = false to exclude app containers from injection.
Check that code modules are not injected into containers.
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7cae2e7) 64.79% compared to head (f66844d) 64.82%.

:exclamation: Current head f66844d differs from pull request most recent head 89231e9. Consider uploading reports for the commit 89231e9 to get more accurate results

Files
Patch %
Lines

pkg/webhook/mutation/pod_mutator/pod_mutator.go
60.00%
3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
+ Coverage   64.79%   64.82%   +0.03%
==========================================
  Files         249      249
  Lines       16369    16397      +28
==========================================
+ Hits        10606    10630      +24
- Misses       4954     4957       +3
- Partials      809      810       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reordering activity bar forces item to be visible

Issue Type: Bug
Testing #50578
Steps

Hide the search activity bar entry
Now use keyboard shortcuts to bring the search view back up
Notice the icon is restored while search is visible
Now drag the search icon in the activity bar

Bug
The search item is now always visible again. If you do not drag it, when you switch away from search the activity bar entry is automatically hidden
(PS. sorry for the nit-picky issues)
VS Code version: Code - Insiders 1.24.0-insider (bfd155e6039f64d2795c6b514a029ebd01a33527, 2018-05-29T06:13:09.810Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 4, 4

Memory (System)
16.00GB (0.15GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_1692061

Screen Reader
no

VM
0%

Thanks for reporting.
Item is pinned during drag and drop. This is as per design.


[FEATURE]: Adding more hover animations

Feature Description 📝
Hover animation section looks empty and requires some love, if you have some nice hover animations in mind, drop that idea below so that it can be added to SyntaxUI
Screenshots 📸

hey 👋
@Ansub, could you assign this issue to me

All yours brother, it's a open issue you can create a PR and if rest want to add more they can create a different PR for that :)

Hey @Ansub
I’ve created a really nice hover animation for a button component, but I noticed that there are no existing CSS files in the codebase to add my styles. Could I create a new CSS file for my button component, or do you have any other suggestions on how I should proceed?
Thanks!

hey @Ansub
please could you please review my pull request please, I have so much hover animations I would  love to add once this my pr gets approved and merged thanks 😊


⚠ Secret Website 3 has degraded performance

In 2d45569, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2698 ms

Resolved: Secret Website 3 performance has improved in ba8b3ca.


[Join button]

Description of the idea or feature
Join Button
A join button will help to redirect new members to our github support/create issue page.
Add several screenshots or links related to the idea or feature (if applicable)

Add more details about the idea or feature
nil

Thanks for making the updates to the form. 👍🏾

Thanks for making the updates to the form. 👍🏾

My pleasure 🙂


Cloud on v22.1.5

Just a quick version update. One day this will be automated...

This change is


The exception renderer resource dist folder is missing in version 11.31, causing exception render to fail.

Laravel Version
11.31
PHP Version
8.2
Database Driver & Version
MYSQL 8.x
Description
When Laravel is trying to render an exception page on development, the view renderer tries to load assets like stylesheets and others from the dist folder located inside the exceptions resources, but this file is missing in Laravel 11.31 which caused the app to resolve to a Symfony exception page stating that the resources file .../dist/style.css does not exist.
Steps To Reproduce
Install a new Laravel app by specifying the version 11.31
Set up your environment variables and connect to Database.
Run the app and the exception will pop up showing a Symfony error page.

Does the error exists on the latest version?

Unable to replicate the issue on 11.31 or the latest version.

Hi there,
Thanks for reporting the problem you are encountering, but it looks like this is a question which may be better suited for a support channel. We only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repository you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


UnboundLocalError: local variable 'registry_list' referenced before assignment on Openshift.

Describe the bug
I got the following error.
[2023-01-24 14:54:58,548] kopf.objects         [ERROR   ] [my-namespace/trivy-operator-main-config] Handler 'create_fn' failed with an exception. Will retry.
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/kopf/_core/actions/execution.py", line 279, in execute_handler_once
    result = await invoke_handler(
  File "/usr/local/lib/python3.8/site-packages/kopf/_core/actions/execution.py", line 374, in invoke_handler
    result = await invocation.invoke(
  File "/usr/local/lib/python3.8/site-packages/kopf/_core/actions/invocation.py", line 116, in invoke
    result = await fn(**kwargs)  # type: ignore
  File "/trivy-operator.py", line 416, in create_fn
    pull_secret_decoder(tmp3, tagged_ns)
  File "/trivy-operator.py", line 240, in pull_secret_decoder
    registry_list.append(data['auths'])
UnboundLocalError: local variable 'registry_list' referenced before assignment

The error I encountered is related to the registry_list = spec['registry'] line of code because I got DEBUG message  [2023-01-24 14:54:58,541] kopf.objects         [DEBUG   ] [my-namespace/trivy-operator-main-config] No registry auth config is defined.
Expected behavior
I set registryAuth > registry in Helm Values file but it looks that trivy-operator pod can't get the value from it.
Value of registry should be configured in trivy-operator pod, so registry_list = spec['registry'] would be success and local variable registry_list would be assigned before  registry_list.append(data['auths']).
https://github.com/devopstales/trivy-operator/blob/main/trivy-operator.py#L229-L233
https://github.com/devopstales/trivy-operator/blob/main/trivy-operator.py#L240
Configuration file
Due to the above error, the NamespaceScanner is not created.
Helm Values file
image:
  # -- The docker image repository to use
  repository: devopstales/trivy-operator
  # -- The docker image pull policy
  pullPolicy: Always
  # -- The docker image tag to use
  tag: "2.5"

# -- Time Zone in container
TimeZone: UTC

# -- Log level
log_level: "DEBUG"
# INFO, HIGH, DEBUG

# -- list of secrets to use for imae pull
imagePullSecrets: []
# -- security options for the pod
podSecurityContext:
  fsGroup: 10001
  fsGroupChangePolicy: "OnRootMismatch"

serviceAccount:
  # -- Enable serviceAccount creation
  create: true
  # -- serviceAccount annotations
  annotations: {}
  # -- Name of the serviceAccount
  name: "trivy-operator"

# Dont try to download trivy db, run in air-gapped env:
offline:
  # -- enable air-gapped mode
  enabled: false
  # -- repository to use for download trivy vuln db
  db_repository: localhost:5000/trivy-db
  # -- insecure repository
  db_repository_insecure: False

cache:
  # -- enable redis cache
  enabled: false

monitoring:
  # -- configure prometheus monitoring port
  port: "9115"

# deploy service monitor
serviceMonitor:
  # -- allow to override the namespace for serviceMonitor
  enabled: false
  # -- Name of the namespace for serviceMonitor
  namespace: {}
  labels:
    # -- labels to match the serviceMonitorSelector of the Prometheus Resource
    release: prometheus
  # https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#relabelconfig
  # -- relabel config for serviceMonitor
  relabelings: []
  # see serviceMonitor.relabelings
  # -- metricRelabeling config for serviceMonitor
  metricRelabelings: []

grafana:
  # -- namespace for configMap of grafana dashboards
  namespace:
  dashboards:
    # -- Enable the deployment of grafana dashboards
    enabled: true
    # -- Label to find dashboards using the k8s sidecar
    label: grafana_dashboard
    # -- Label value to find dashboards using the k8s sidecar
    value: "1"
  folder:
    # -- Annotation to enable folder storage using the k8s sidecar
    annotation: grafana_folder
    # -- Grafana folder in which to store the dashboards
    name: Policy Reporter

persistence:
  # -- Volumes for the pod
  enabled: true
  # -- Volumes mode
  accessMode: "ReadWriteOnce"
  # -- Volumes size
  size: "3Gi"
  # -- Volumes annotations
  annotations: {}
  ## database data Persistent Volume Storage Class
  ## If defined, storageClassName: <storageClass>
  ## If set to "-", storageClassName: "", which disables dynamic provisioning
  ## If undefined (the default) or set to null, no storageClassName spec is
  ##   set, choosing the default provisioner.  (gp2 on AWS, standard on
  ##   GKE, AWS & OpenStack)
  ##
  # storageClass: "-"

# content foc ns-scan CRD
namespaceScanner:
  crontab: "*/1 * * * *"
  namespaceSelector: "trivy-scan"
  clusterWide: false
  integrations:
    policyreport: false
#    defectdojo:
#      host: "https://defectdojo.k8s.intra"
#      api_key: "xyz456ucdssd67sd67dsg"
#      k8s-cluster-name: "eks-prod"

kube_bench_scnner:
  image:
    # -- The docker image repository to use
    repository: devopstales/kube-bench-scnner
    # -- The docker image pull policy
    pullPolicy: Always
    # -- The docker image tag to use
    tag: "2.5"

clusterScanner:
  # -- enable clusterScanner cr creation
  enabled: false
  # -- crontab for scheduled scan
  crontab: "*/1 * * * *"
  # -- kube-hunter scan profile
  scanProfileName: "cis-1.23"
  # -- configure defectdojo integration
  integrations: {}
#    defectdojo:
#      host: "https://defectdojo.k8s.intra"
#      api_key: "xyz456ucdssd67sd67dsg"
#      k8s-cluster-name: "eks-prod"

admissionController:
  # -- enable adission controller
  enabled: false

# authentication informatin for trivy to use wen scan image
registryAuth:
  # -- enable registry authentication
  enabled: false
  # -- list of image pull secrets for authentication
  image_pull_secrets:
    - regcred
  registry:
    - name: image-registry.openshift-image-registry.svc\:5000
      username: "serviceaccount"
      password: "******"

# github authentiation token for trivy database download
githubToken:
  # -- enable github authentiation token
  enabled: false
  # -- github authentiation token value
  token: ""

## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
# -- Set the node selector for the pod.
nodeSelector: {}

## Tolerations for use with node taints
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
# -- Set the tolerations for the pod.
tolerations: []
# - key: "key"
#   operator: "Equal"
#   value: "value"
#   effect: "NoSchedule"

## Assign custom affinity rules to the trivy operator
## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
# -- Set the affinity for the pod.
affinity: {}
# nodeAffinity:
#   requiredDuringSchedulingIgnoredDuringExecution:
#     nodeSelectorTerms:
#     - matchExpressions:
#       - key: kubernetes.io/e2e-az-name
#         operator: In
#         values:
#         - e2e-az1
#         - e2e-az2%

Environment:

Trivy-Operator version (use trivy-operator version): 2.5.0
Installation type (Helm, Kubernetes, OperatorFramework): Helm
Kubernetes version (use kubectl version): I use Oenshift(Client Version: 4.10.12/Server Version: 4.10.36/Kubernetes Version: v1.23.5+8471591)
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc):Red Hat Enterprise Linux CoreOS 410.84.202210040010-0 (Ootpa)

Additional context
I got the same error on Kubernetes Deploy.
https://github.com/devopstales/trivy-operator/tree/main/deploy/kubernetes
This is 05_namespace-scanner.yaml I applied for openshift.
# cat 05_namespace-scanner.yaml
apiVersion: trivy-operator.devopstales.io/v1
kind: NamespaceScanner
metadata:
  name: main-config
spec:
  crontab: "*/1 * * * *"
  namespace_selector: "trivy-scan"
  clusterWide: False
  integrations:
    policyreport: True
#    defectdojo:
#      host: "https://defectdojo.k8s.intra"
#      api_key: "xyz456ucdssd67sd67dsg"
  image_pull_secrets:
    - trivy-operator-dockercfg-cw8lh
  registry:
  - name: image-registry.openshift-image-registry.svc\:5000
    username: "serviceaccount"
    password: "******"
    insecure: True

Hi @kmotojim
The first thing. The helm chart should create the NamespaceScanner object. It is not created because the creation is disabled:
# authentication informatin for trivy to use wen scan image
registryAuth:
  # -- enable registry authentication
  enabled: false

I didn't test it but the source of the problem cloud be this line:
name: image-registry.openshift-image-registry.svc\:5000
I think you shuld try like this:
name: "image-registry.openshift-image-registry.svc:5000"
And yes there is a problem in the code too because the hall https://github.com/devopstales/trivy-operator/blob/main/trivy-operator.py#L235-L244 for cycle should be in the in this try: https://github.com/devopstales/trivy-operator/blob/main/trivy-operator.py#L230

I tried setting image-registry.openshift-image-registry.svc:5000 (without slash before colon) to name in registy object but pod still can't get the value from it.
  registry:
  - name: image-registry.openshift-image-registry.svc:5000
    username: "serviceaccount"
    password: "******"
    insecure: True

Thank you for fixing.
It seems UnboundLocalError: local variable 'registry_list' referenced before assignment doesn't happen.


fix qiskit-ibm-runtime requirement

Have you validated if 0.9.4 is enough?

It is, with qiskit 0.43.0


the object "cloud layer" in world editor can not be saved in the level of "small grid"

hello,
I want to create a new level based on the level of "small grid". I try to add the "cloud layer" object into the level of "small grid" through world editor. However, even if I have clicked the save button, there is no "cloud layer" in the scene when I next enter the level. I found that when I created "cloud layer" object, the event tree window did not change and there was no display of adding "cloud layer". I'm very confused. Can you give me some suggestions? Looking forward to your reply! Thanks a lot!

I have solved this problem by creating "cloud layer" in other classes in world editor. But is there a way to add the sound of rain?

I have downloaded a mod named "flood", which can add rain and the sound of it.  Can I use beamngpy to call this mod and set the precipitation parameters in the mod through code? Instead of manually setting and adding precipitation after the scene is loaded. I don't know how to realize it through beamngpy. Can you help me? Thanks very much!

Hi Sainan,
Thanks for your query.
We do not support third party mods unfortunately so we cannot answer this, but this is the repo for BeamNGpy - BeamNG's Python front end.
You may be able to find an answer to your question on the forums here, however:
https://www.beamng.com/forums/
Best regards,
BeamNG Tech Team


[Bug] Cursor Position Issue on Window Resize with Soft Line Wrapping

Windows Terminal version
1.21.2361.0
Windows build number
10.0.22631.0
Other Software

System Language: zh_cn
Console Font: Hack Nerd Font Mono
Font Size: 12

Steps to reproduce

Print more than two lines ending with space and causing line wrap

# `120` here is my console width
for i in range(2):
    print('x' * 120 + ' ')
print('yya')
input('--')

Resize the window to change the console width.

Expected Behavior
Cursor should be after -- of input('--') throughout the process
Actual Behavior
After resize, cursor is before a of print('yya')

Before resize: (width is 120)

After resize:  (width is 121, line wrap here seems wrong too)

I want to work on this issue

Thanks for filing! We recently rewrote ConPty. Mind checking v1.22 (Preview) to see if it got fixed /?
Also, thanks @ayush1233!

@carlos-zamora

Mind checking v1.22 (Preview) to see if it got fixed /?

Thank you for the update. I've tested version 1.22.240823002-preview and found that the cursor position issue has been resolved.
However, I've noticed that the line wrapping still seems to be incorrect. That is, the spaces at the end of lines seem to be ignored after adjusting the window width. (Maybe I should open another issue?)

That is, the spaces at the end of lines seem to be ignored after adjusting the window width.

That's a known issue that we're hoping to address at some point. I'm not entirely sure if we have an issue to track it though. We could repurpose this one for it.
The reason that happens is because our text buffer does not keep track of how much text you wrote on any given line. To it, there's no difference between whitespace and no text at all, and so it gets truncated during resize.


[Enhancement] Rename session variable and add metric for query queue

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Rename query_queue_select_enable to enable_query_queue_select.
Add FE metrics for query queue:

starrocks_fe_query_queue_pending
starrocks_fe_query_queue_total
starrocks_fe_query_queue_timeout

Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergify backport branch-2.5

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


about threshold

In the real world, How to set the optimal threshold for recognition？any tricks?

You can  set up your threshold by analyzing the roc-curve


Create a guide on how we review the documentation PR

Things like we check for typo, avoir personal pronouns, test the code demo... What is the English we wants (US, international)... We could add this to the devrel repo, and point to it in the CONTRIBUTORS files in the doc repo (or just put it directly into the doc repo contribution file - I created the issue here, since it's more like an administration thing, than the doc itself)

Here is what I was looking for, if that may inspire you:

Simple English. English is the international language of coders but is not often their first language.
Correct information. It is always a good thing that someone else checks the information. May it be by trying the code or by looking at other information sources (older guide, code in meilisearch-core, ..)
Extended information when needed. Sometimes to understand something you just need to add a bit more explanations. If it is hard for you to understand, it will be as well for a new user.
Examples that make sense. Sometimes examples are not perfect to showcase this or that. Always question the relevance of an example.
Should the new information also be added or changed somewhere else in the documentation?
Should this new page be linked somewhere else in the documentation? Or only in the navbar? And is this a good place to add this page?

Here is what I was looking for, if that may inspire you:

Simple English. English is the international language of coders but is not often their first language.
Correct information. It is always a good thing that someone else checks the information. May it be by trying the code or by looking at other information sources (older guide, code in meilisearch-core, ..)
Extended information when needed. Sometimes to understand something you just need to add a bit more explanations. If it is hard for you to understand, it will be as well for a new user.
Examples that make sense. Sometimes examples are not perfect to showcase this or that. Always question the relevance of an example.
Should the new information also be added or changed somewhere else in the documentation?
Should this new page be linked somewhere else in the documentation? Or only in the navbar? And is this a good place to add this page?

@react-learner was it part of the doc you wrote about contributing to the documentation?

P1 because of the new Technical Writer joining our team hopefully soon


Fix typo in kinesis stream example

Fix typo in kineses stream example in Keda docs. There's typo in the name keda-trigger-auth-aws-credentials when it is used later in the Scaled Object to refer to the Trigger Authentication resource created with same name.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Would you mind updating all 2.x versions please? (if applicable)

@tomkerkhove Fixed for all the versions.

Thank you!


update mongo reactivestreams version

Motivation
The latest MongoDB Reactive Streams Java Driver documentation has been merged with the Java Driver.
The version used in Pulsar is old (v1.12.0 / Aug 2019).
The driver needs to be updated.
Modifications

Change driver version in pom.xml
Update code with some new classes
Update unit tests

Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): yes
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

Does this pull request introduce a new feature? no

/pulsarbot run-failure-checks


max_table_nesting not working as expected

dlt version
1.3.0
Describe the problem
Using the resource defined at reduce-the-nesting-level-of-generated-tables:
import dlt

@dlt.resource(max_table_nesting=1)
def my_resource():
    yield {
        "id": 1,
        "name": "random name",
        "properties": [
            {
                "name": "customer_age",
                "type": "int",
                "label": "Age",
                "notes": [
                    {
                        "text": "string",
                        "author": "string",
                    }
                ]
            }
        ]
    }

Running a pipeline with max_table_nesting=1 set for the resource has no effect; the output tables still display nesting levels deeper than 1.
Pipeline
resource = my_resource()
resource.max_table_nesting = 1

pipeline = dlt.pipeline(
    pipeline_name="test_pipeline", destination="postgres", dataset_name="test"
)

pipeline.run(resource)

Output tables:

Expected behavior
The output tables should only include these (without table my_resource__properties__notes):

Steps to reproduce
Copy the code snippets provided in the problem section and run the script. For quicker testing, you can use DuckDB, which I confirm produces the same problematic behavior.
Operating system
Windows
Runtime environment
Local
Python version
3.10
dlt data source
I initially discovered the bug while working with the JIRA source, but as described in the problem, it is not specific to any particular data source.
dlt destination
DuckDB, Postgres
Other deployment details
No response
Additional information
No response

I have verified this. It works when setting max_table_nesting on the source, but for some reason not for the resource.


Added a link to the new tutorial in the developer docs

There's a new documentation from google about something google doesn't maintain anymore?
Would be nice if it would get alive again, till then we are using our own fork > https://github.com/gmaps-marker-clusterer/gmaps-marker-clusterer


Multiple Workspaces

It appears that workspaces doesn't work properly.
I created a workspace and added a folder to it, saved the workspace (tried with and without spaces), I created a second workspace and noticed it pulled the same folders as the original workspace, so removed the folder and added the second folder, and saved as a second workspace. Then I tried switching workspaces between the two, and although the name of the workspace changes, the folders stay the same as the "last session" if that makes sense.
Another example is I created a new workspace and added several project folders to it, saved it as a workspace, then removed all folders except one, saved as another workspace, went to load my "all folders" workspace, and it only had the one folder I didn't remove to save as another workspace.
Do workspaces work? Am I doing something wrong?

I think what's happening is that when you add or remove a folder from a workspace it immediately saves that to the current workspace. So if you do "save workspace as" after that, the two workspaces will have the same folders.

Interesting, I'll try saving workspace as something else first and then remove folders.

Looks like that did it. I now am able to open different workspaces with different folders. THANK YOU!


[Feature Request] Add metrics to track latency issue due to search idle feature

Is your feature request related to a problem? Please describe
Shards refresh automatically in the background by default very second. When no search request lands on a shard for over 30 seconds, the shard will go into an idle state where it stops the implicit index refresh to improve performance. (more information on Search Idle here).
However, this causes another problem. After a shard goes idle, there are still write requests coming in (write requests doesn’t affect the search idle feature), so the next search request will need to force a refresh on the shard to get the most updated data - to make sure all the write requests we got during idle are reflected - and then serve the result. However, the additional step here to force a refresh consumes time and increases latency.
We'd like to observe how often an idle shard is being "woken up".
Describe the solution you'd like
As a first step to improve the performance due to this force refresh, we'd like to add metrics to track this issue. That is, to add a counter to reflect when a search request wakes up a shard, and then export it through an API for visibility. This counter makes sure we know the timestamp of a "blocking index refresh" happening, so that we can observe the relationship between a shard wakes up and high latency. The metrics tracker will be the first step of solving the issue Here.
Related component
Search

[Triage - attendees 1 2 3 4 5 6]
@ruai0511 Thanks for filing, looking forward to seeing progress here.