What is the status of documenting Promise

I have been trying to make out what the plan is on how to document promises in jsdoc and can't seam to find any one solution. Can any one explain what the plan is, how it should be documented, when that is planed to be released, what is left to do to implement it  and dose the project need assistance in getting this done?

I asked about this in November of last year (https://github.com/jsdoc3/jsdoc/issues/1110) and was informed that the decision on how JSDoc will handle this has been made, but nothing has been implemented as of yet.  Given that the syntax has been decided upon, I have begun documenting all of my code with the syntax described.  For example:
/** Get a list of user names
* @returns {Promise.<string[]>} Array of usernames
*/
Unfortunately, current JSDoc thinks that everything I document this way is an array of objects.
For example, this JSDOC:
/** Get a single user object
* @returns {Promise.<userObject>} A single user objects
*/
Is output in the JSDOC as:
'RETURNS: Array of userObject'
I've been ignoring this inaccuracy, and just dealing it while we wait for support to be officially added; it's more important that things have some documentation even if it's inaccurate until the next JSDoc version

#509 was locked so I won't start it up again out of respect for moderators here, but I also am not clear on how that thread resolved.
Question
I'm not even using JSdoc right now so impl isn't that important, I just want to know if there's a standard syntax so I can use it. Are @fulfills & @rejects what was settled upon? For me, knowing this is enough-- I'll start using so my code will be future-ready.

I'm gonna ping @hegemonic here - Promises have become an important part of modern JavaScript. Can you tell us what is going to be implemented?

My only comment is that what looks like the proposed syntax...
/**
 * @promise PromiseTypeName
 * @fulfills {type} description
 * @rejects  {type} description
 */

/**
 * @returns {PromiseTypeName}
 */
function () {}

...seems overly voluminous, while the proposed shorthand...
/**
 * @returns {Promise.<type>} description
 */
function () {}

...seems overly verbose, discarding valuable info on types and cramming both fulfillment info and timing info into the same line. It seems like a better happy medium for shorthand would be something like:
/**
 * @returns  {Promise} description
 * @fulfills {type}    description
 * @rejects  {type}    description
 */
function () {}

This allows for a good description for one-off promises without having to discard or overly compress any of the info involved.

I agree with using the following with the exception of @fulfills. The more common callback name to use is @resolve which is the same as the Promise method Promise.resolve().
``
/**

@returns  {Promise} description
@resolve {type}    description
@rejects  {type}    description
*/
``

This is so sad - this issue has been around for way more than a year now and there is no official statement from the JSDoc developers. Documentation is one of the most important aspects of software development and JSDoc seems to be the only option for JS documentation... and it seems to be dead / unmaintained.

@saschagehlich They are probably all off using typescript 😄

@saschagehlich +1

You can use this syntax to document promises today:
/**
 * Retrieve the user's favorite color.
 *
 * @returns {Promise<string>} A promise that contains the user's favorite color
 * when fulfilled.
 */
User.prototype.getFavoriteColor = function() {
    // ...
};

This is the recommended way to document promises. The only downside is that you can't document the error condition this way.
This is the syntax that will be supported at some point in the future, for users who need to document the error condition:
/**
 * A promise for the user's favorite color.
 *
 * @promise FavoriteColorPromise
 * @fulfill {string} The user's favorite color.
 * @reject {TypeError} The user's favorite color is an invalid type.
 * @reject {MissingColorError} The user has not specified a favorite color.
 */

/**
 * Retrieve the user's favorite color.
 *
 * @returns {FavoriteColorPromise} A promise for the user's favorite color.
 */
User.prototype.getFavoriteColor = function() {
    // ...
};


Review date - Draft new pattern guidance

What
Write draft guidance for the new review date design pattern guidance.
Why
We need to draft the guidance and have it reviewed before adding it to the service manual
EPIC
https://github.com/nhsuk/nhsuk-service-manual/issues/883
To do

[ ] Draft the guidance
[ ] Critique by the community
[ ] Iterate guidance based on feedback
[ ] Content review by the team

Draft guidance

Have done an initial draft. @davidhunter08 @AdamChrimes, see what you think.


Python Programs

📝 Upload it under folder named Python
📝 Upload it in ipynb format

@ArchanaKalathiya for all your Pull Requests, the same changes are required for all your Pull Requests that I mentioned in the Digital Clock Pull Request. Just make those changes and all your Pull Requests will be good to merge.


SurfaceLoss used for 3D data?

Hi, thank you so much for sharing your codes.
Can surfaceloss  function be used for 3D dataset?

Probably yes. if you can calculate the shortest distance to pixels of GT boundaries for 3D data.

Yes it is very easy to do ; actually the current implementation is somewhat 3d ready. I did the last required part in private ; haven't tested/published that yet.
The surface loss implementation is literally the same ; as we multiply element wise two tensors of same shape [1]
class SurfaceLoss():
    def __init__(self, **kwargs):
        # Self.idc is used to filter out some classes of the target mask. Use fancy indexing
        self.idc: List[int] = kwargs["idc"]
        self.nd: str = kwargs["nd"]  # 'wh' for 2d case, 'whd' for 3d case
        print(f"Initialized {self.__class__.__name__} with {kwargs}")

    def __call__(self, probs: Tensor, dist_maps: Tensor, _: Tensor) -> Tensor:
        assert simplex(probs)
        assert not one_hot(dist_maps)

        pc = probs[:, self.idc, ...].type(torch.float32)
        dc = dist_maps[:, self.idc, ...].type(torch.float32)

        multipled = einsum(f"bk{self.nd},bk{self.nd}->bk{self.nd}", pc, dc)

        loss = multipled.mean()

        return loss

Most of the difference is for the one_hot2dist. Now, we have almost a guarantee that the spatial resolution is different between all axis, so we need to take that into account. The good news is that the function it used internally already handle that case, so it is only a matter of adding an optional parameter:
def one_hot2dist(seg: np.ndarray, resolution: Tuple[float, float, float] = None) -> np.ndarray:
    assert one_hot(torch.tensor(seg), axis=0)
    K: int = len(seg)

    res = np.zeros_like(seg)
    for k in range(K):
        posmask = seg[k].astype(np.bool)

        if posmask.any():
            negmask = ~posmask
            res[k] = distance(negmask, sampling=resolution) * negmask \
                - (distance(posmask, sampling=resolution) - 1) * posmask
        # The idea is to leave blank the negative classes
        # since this is one-hot encoded, another class will supervise that pixel

    return res

At last, I added something in my dataloader to support the different resolution ; there is many ways to do that. I personally had saved the resolution for each 3d volume in a dictionnary (trimmed the loader a lot, you get the idea):
class SliceDataset(Dataset):
    def __init__(self, filenames: List[str], folders: List[Path], are_hots: List[bool],
                 bounds_generators: List[Callable], transforms: List[Callable], debug=False, quiet=False,
                 K=4, in_memory: bool = False, spacing_dict: Dict[str, Tuple[float, ...]] = None,
                 augment: Optional[Callable] = None, ignore_norm: bool = False,
                 dimensions: int = 2, debug_size: int = 10) -> None:
        self.folders: List[Path] = folders
        self.transforms: List[Callable[[Tuple, int], Callable[[D], Tensor]]] = transforms
        assert len(self.transforms) == len(self.folders)

        self.filenames: List[str] = filenames
        self.K: int = K  # Number of classes

        self.spacing_dict: Optional[Dict[str, Tuple[float, ...]]] = spacing_dict
        if self.spacing_dict:
            assert len(self.spacing_dict) == len(self.filenames)
            print(f"> Spacing dictionnary loaded correctly")

    def __getitem__(self, index: int) -> Dict[str, Union[str, Tensor, List[Tensor], List[Tuple[slice, ...]]]]:
        filename: str = self.filenames[index]
        path_name: Path = Path(filename)
        images: List[D]

        if path_name.suffix == ".png":
            images = [Image.open(files[index]) for files in self.files]
        elif path_name.suffix == ".npy":
            images = [np.load(files[index]) for files in self.files]
        else:
            raise ValueError(filename)

        resolution: Tuple[float, ...]
        if self.spacing_dict:
            resolution = self.spacing_dict[path_name.stem]
        else:
            resolution = tuple([1] * self.dimensions)

        # Final transforms and assertions
        assert len(images) == len(self.folders) == len(self.transforms)
        t_tensors: List[Tensor] = [tr(resolution, self.K)(e) for (tr, e) in zip(self.transforms, images)]
        _, *img_shape = t_tensors[0].shape

        final_tensors = t_tensors

        # [...]

        return {'filenames': filename,
                'images': final_tensors[0],
                'gt': final_tensors[1],
                'labels': final_tensors[2:],
                'spacings': torch.tensor(resolution)}

Let me know if something remains unclear, but I believe that going from 2d to 3d is pretty quick ; as long as you already have the 3D CNN obviously.
[1] My code states explicitly the expected number of dimensions with parameters, to explode in case it receives something different. This is my personal philosophy of brittleness on purpose, which allow to easily catch mistakes in the formatting of the data. The default broadcasting rules are so powerful that it often "fails silently", in the sense that it does something (not what you intended to write), but just output non-sense and can take some time to debug.


To create a model for textual similarity tasks involving **JSON-structured data

My intention is to use the PoSE to pre/fine-train the LLM with diverse structured data like JSON and XML documents.
Unlike natural language text, structured data doesn't meaningful units sentences. Instead it consists of key-value pairs, nested objects, arrays, and etc. Besides that I am dealing with a very large documents like XML/JSONs with 100k+ tokens.
Do you think I can use PoSE for that?
Regarding the script code: I am struggling to match the code with the paper.
Figure 6: Python Code used for calculating coverage probability of each relative position in Figure 5.

could you brief explain what these methods is doing?
train_pose.py

smart_tokenizer_and_embedding_resize
DataCollatorForSupervisedDataset
train_preprocess_function_randomized
train_preprocess_function_pose
Specific for train_preprocess_function_pose, is it correct the variable is assigned and never changed: lt1 = 0?

Thank you in advance.

Hi @BrunoRodolpho, Thank you for your attention!
Firstly, the code snippets in Figure 6 are utilized to compute the coverage possibility of each relative position depicted in Figure 5. Therefore, the purpose of this code is to support the analysis conducted in Figure 5, Appendix B.
Our train_pose.py script is largely inherited from train.py sourced from Llama-X, which includes functions such as smart_tokenizer_and_embedding_resize and DataCollatorForSupervisedDataset. Hence, there is no need for additional focus on these two functions. train_preprocess_function_randomized is utilized to implement the baseline of RandPos. train_preprocess_function_pose is the crux of our method. During tokenization, this function will segment a piece of text into two chunks, and assign distinct positional encodings to each chunk. The positional encodings between the two chunks are discontinuous (we call it 'skipped'), with lt0 representing the starting position of the first chunk. Since RoPE encodes relative positions, setting it to zero is OK (and we set it to zero intentionally).
I believe that PoSE is also applicable to unstructured data. However, I have not tested it on text similarity tasks yet, so I am also very curious about the outcomes. Looking forward to your response.


TC ACL 1.1 fails (CON-600)

I am testing our matter device using the Raspberry Pi TH suite, running test Test_TC_ACL_1_1. It is a bridge device (aggregator endpoint) commissioned over Wi-Fi/BLE. Pairing with e.g. Apple Homekit works, so I am suprised the test fails. Any ideas why this happens?

UI_Test_Run_2023_7_5_12_42_35.log

I repeated the test using onnetwork commissioning over ethernet. Pairing works perfectly fine with Apple Homekit, but chip-tool times out. Our device and the TH RPI are on the same network, they can ping each other. However, our device only gets an IPv4 address, can this be a issue? I also noticed that the ethernet examples in esp-idf provide only IPv4 capability and not IPv6...
I also tried to pair with manual commands, e.g. chip-tool pairing onnetwork  , but it times out too. Any hints from your side?
UI_Test_Run_2023_7_5_13_45_40.log

Please update your PICS file. Below is the reason for the test steps failure
6th step: You are trying to read the optional attribute and the optional attribute isn't supported
8th step: Getting 0 entries of GeneratedCommandList Attribute is expected because accesscontrol cluster not generating and accepting server or client-side commands as a result it is  0.

Please use the attached ACL PICS file for the esp-matter bridge device.
Access Control cluster.zip

@AtiosAG Is your issue resolved? Please close if it is

@AtiosAG I will close this now. Please re-open if you are still seeing the issue


Normalizes function names to match hook names in intercept plugins

Cherry-picked to v9.0.x branch.


Sign Bug?

I have a schematic created and loaded which contains Signs with Text on it.
The Signs on loading does not have a Text
Does Schematics contain the Text of the Signs? if yes -> They dont get loaded correctly (I have BlockHandler for Signs registered)

You need to set the block handler of the signs when they are placed by scaffolding. This project is currently stale so I will not be adding any features to make this task easier.

// Registering the SignHandler
MinecraftServer.getBlockManager().registerHandler(NamespaceID.from("minecraft:sign"), SignHandler::new);

// SignHandler Class
public final class SignHandler implements BlockHandler {

  @Override
  public @NotNull NamespaceID getNamespaceId() {
    return NamespaceID.from("minecraft", "sign");
  }

  public Collection<Tag<?>> getBlockEntityTags() {
    return Arrays.asList(
        Tag.Byte("GlowingText"),
        Tag.String("Color"),
        Tag.String("Text1"),
        Tag.String("Text2"),
        Tag.String("Text3"),
        Tag.String("Text4"));
  }
}

What do you mean with when they are placed by scaffolding?
I have registered the SignHandler already.

You need to set the block handler when the block is placed. Just registering it does not apply it to the sign.

Block block =
                    Block.OAK_SIGN
                        .withTag(
                            Tag.String("Text1"),
                            GsonComponentSerializer.gson().serialize(Component.text("Line 1")))
                        .withHandler(new SignHandler());

                // Option 1
                AbsoluteBlockBatch absoluteBlockBatch = new AbsoluteBlockBatch();
                absoluteBlockBatch.setBlock(world.getSpawnPos(), block);
                absoluteBlockBatch.apply(instance, () -> {});

                // Option 2
                instance.setBlock(world.getSpawnPos(), block);

But this works for example. Just the Schematic Class does not seem to load it correctly. Have you tested it in the past with Signs?

I can't find a way of how to assign Handler after they are placed by the BlockBatch you apply with the Schematics. There maybe need to be a PreSetter Parameter to change the Block before it gets applied to the BlockBatch


MLPMixer result

Hello,
I have a question about the MLPMixer result. I trained multiple versions of the MLPMixer model, but none of them can achieve the 88% accuracy. Can you provide the detailed configurations you used for training this model? It will be very helpful.
Best regards

The 88% mlp mixer was trained with this. I think the lr is different from ViT
train_cifar10.py --net mlpmixer --lr 1e-3 --aug --n_epochs 500 --bs 2048


Light Client minor improvements

Follow up to #110 Types:

[ ] memoize results of methods that don't take args, eg. .hash() (https://github.com/interchainio/tendermint-rs/issues/96#issuecomment-567003346)
[ ] introduce a simple event type and let bisection function take a closure that will fire events. this can be used for logging so we don't need a print statement or logger inside the functions

Also follow up to PR review:

[x] https://github.com/interchainio/tendermint-rs/pull/132#pullrequestreview-351913583

Possibly break this up into two issues. Memoizing isn't important for https://github.com/informalsystems/tendermint-rs/milestone/1 but some good form of logging probably is

It isn't clear what the motivation or expectation is here.
Is it possible that we want to know what blocks were part of a verification path? In which case this might be fulfilled by the tracing feature which is already landed:
https://github.com/informalsystems/tendermint-rs/blob/740cb66e25ea38ac6b545bc9b4f9b294dcc23277/light-client/src/state.rs#L32-L42
If not can it would be great to update the description of this issue with what we want and why.

I think we can close for now


Add P010 HDR10 video format support

Tested on Windows with Elgato HD60X.
LUT calibration also supports P010 format.

@awawa-dev
Hello,
My UGREEN P010 Grabber arrived today.
Unfortunately, I cannot elicit/set a p010 video mode under my Windows 11.
I have used your branch “Add P010 HDR10 video format support”. https://github.com/awawa-dev/HyperHDR/actions/runs/11638667810
Do I need to pay attention to anything else?

Check out logs, it should lists all available modes there. Is the HDR signal connected to the grabber?

Yes, it may be due to the USB cable. I can't connect the original cable, which is included, to my PC/laptop because I don't have a USB-C port.
 Selected: 'UGREEN 25173' 1280 x 720 @ 60 fps nv12
2024-11-02T19:52:25.459Z [MEDIA_FOUNDATION:UGREEN 25173] *************************************************************************************************
2024-11-02T19:52:25.459Z [MEDIA_FOUNDATION:UGREEN 25173] Init UGREEN 25173, 1280 x 720 @ 60 fps (NV12) => \?\usb#vid_3188&pid_1000&mi_00#6&792477d&0&0000#{e5323777-f976-4f5b-9b55-b94699c46e44}\global
2024-11-02T19:52:25.468Z [PROTOSERVER] Started on port 19445
2024-11-02T19:52:25.472Z [MEDIA_FOUNDATION:UGREEN 25173] Device opened successfully
2024-11-02T19:52:25.473Z [MEDIA_FOUNDATION:UGREEN 25173] Brightness set to: 0 (default)
2024-11-02T19:52:25.473Z [WEBSERVER] Started: 'HyperHDR WebServer (HTTP)' on port: 8090
2024-11-02T19:52:25.488Z [MEDIA_FOUNDATION:UGREEN 25173] ******************** SUCCESFULLY SET CAPTURE PARAMETERS: 1280 720 nv12 ********************
2024-11-02T19:52:25.488Z [MEDIA_FOUNDATION:UGREEN 25173] (LutLoader.cpp:82) LUT file found: C:/Users/FM/.hyperhdr/lut_lin_tables.3d
2024-11-02T19:52:25.488Z [MEDIA_FOUNDATION:UGREEN 25173] (LutLoader.cpp:92) Index 1 for HDR YUV
2024-11-02T19:52:25.495Z [WEBSERVER] Setup SSL certificate
2024-11-02T19:52:25.495Z [WEBSERVER] Setup private SSL key
2024-11-02T19:52:25.504Z [MEDIA_FOUNDATION:UGREEN 25173] Found and loaded LUT: 'C:/Users/FM/.hyperhdr/lut_lin_tables.3d'
2024-11-02T19:52:25.504Z [MEDIA_FOUNDATION:UGREEN 25173] Started
2024-11-02T19:52:25.506Z [WEBSERVER] Started: 'HyperHDR WebServer (HTTPS)' on port: 8092
2024-11-02T19:52:25.506Z [SSDP] (SSDPHandler.cpp:42) SSDPHandler is initializing
2024-11-02T19:52:25.511Z [MEDIA_FOUNDATION:UGREEN 25173] Received empty image frame: Warning: receive empty sample
2024-11-02T19:52:25.511Z [SSDP] (SSDPHandler.cpp:183) The local address is: <IP_ADDRESS>
2024-11-02T19:52:25.511Z [SSDP] (SSDPServer.cpp:94) Initialize the SSDP server
2024-11-02T19:52:25.512Z [SSDP] Starting the SSDP server
2024-11-02T19:52:25.897Z [DX11_SYSTEM:AUTO] Selected D3D_DRIVER_TYPE_UNKNOWN
2024-11-02T19:52:25.897Z [DX11_SYSTEM:AUTO] Gamut: SDR, min nits: 0.50, max nits: 270.00, max frame nits: 270.00, white point: [0.31, 0.33]
2024-11-02T19:52:25.897Z [DX11_SYSTEM:AUTO] Using BGRA format

4k capturing is also disabled, only 1080p and compressed formats for limited bandwidth. Did you try to provide such signal on the input? But from the symptoms it reminds me of Elgato which behaves similarly if something does not suit it with USB (bad cable, too low port power). But it work with USB-C to USB-C cable and USB-C to USB-A adapter connected to ordinary USB3.0 port. Mine will arrive next week so I will check it thoroughly.

4k capturing is also disabled, only 1080p and compressed formats for limited bandwidth. Did you try to provide 4k signal on the input? But from the symptoms it reminds me of Elgato which behaves similarly if something does not suit it with USB (bad cable, too low port power). But HD60x works with USB-C to USB-C cable and USB-C to USB-A adapter connected to ordinary USB3.0 port. Mine will arrive next week so I will check it thoroughly.

@awawa-dev
Hello,
You were right, on closer inspection of the accessories, I noticed that a USB A to C was plugged onto the enclosed USB cable. I took it out and connected it directly.
And the result is positive!!!! 😀

Now I will try to compile the kernel for RPI Bokworm aarch 64 with their help.

Great! 🚀
BTW P010 must be calibrated. The default LUT wont work well.

@satgit62 I've found simpler method to patch the uvc-v4l2 module: you do not need to recompile whole kernel. I will post details tomorrow.

@satgit62
You can compile a single module using an adapted script from here: https://github.com/awawa-dev/P010_for_V4L2/blob/master/patch_v4l2.sh (RPi4) but you have to adapt it to your OS. The kernel will be tainted but it has no major side effects unless you want to report bugs to the organization. It takes around 2-3 minutes only on RPi.
Unfortunately some things in Raspberry Pi OS like the source version cannot be obtain so script hardcode-s them. They have recently given up on kernel version-commit markings and there is no way to determine without detective work which version of the kernel sources they probably used as if they wanted to hide something (it's a joke... I suppose?). And https://github.com/RPi-Distro/rpi-source/issues/34 script doesnt work anymore. The more I dig into Raspberry Pi OS the less I want to.
Building the entire kernel itself takes about an ~hour on RPi 5 with an SSD drive, if you have a weaker configuration and an SD card it will probably take much, much longer. You can try cross-compiling on PC but I didn't feel like it.
An alternative there is my ready SD image with a patched kernel (uvc module only so it's tainted but it doesnt matter) built entirely by Github Action: https://github.com/awawa-dev/P010_for_V4L2/releases/tag/raspios_lite_arm64-2024-10-28
I'm giving up on building full patched & built kernels in my releases because I'd really have to build 2 kernels: one for RPi5 and the other ones. Using the current runners in Github Action and qemu it would probably take a few days ;-) So we're only patching the kernel modules.

I found a bug in YUV limited detection during calibration and ELgato (and possible Hagabis) for some reason is using full range for HDR P010. Fixed it in the latest commit. I dont have UGreen anymore (it used YUV limited range) to check if the calibration is working fina also for this grabber. Please re-calibrate P010 LUT in the free time after installing new HyperHDR version.


[Bug]: Property updateCheckout does not exist on type Checkout

What happened?
I attempted to update a checkout form with new items and reset a discount using the following code
paddle.Checkout.updateCheckout({     discountId: null,     items: [{ priceId: 'newPriceId', quantity: 1 }],  });
However, I encountered a TypeScript error stating "Property updateCheckout does not exist on type".
Nonetheless, there is a documentation for this method here, and also I was able to use it successfully by casting to 'any' as follows:
(paddle.Checkout as any).updateCheckout({     discountId: null,     items: [{ priceId: 'newPriceId', quantity: 1 }],  }); .
Why can't I reach updateCheckout in my ts code without an error?
Steps to reproduce

Call paddle.Checkout.updateCheckout in .ts file
Get a ts error "Property updateCheckout does not exist on type"

What did you expect to happen?
paddle.Checkout.updateCheckout() works well without any errors
How are you integrating?
React, TypeScript
Logs
No response

Hi @gorshkovaea,
I have released a new version with the type definition for updateCheckout function.
Please update to the latest version (1.1.1)
Thank you.


Add end-to-end example

Adds an end-to-end example build a container for cosign and validating
the process using SLSA guidelines.

Adds SPDX and Cyclone SBOMs for reference.
Adds information about what to do with the SBOM.

We probably want to remove the grype-vulnerability-scan from the sample-pipeline, or at least make them consistent so it doesn't fail the CI build.
https://github.com/buildsec/ssf/blob/main/examples/sample-pipeline/sample-pipeline.cue#L194

Tracking Grype failures over here: https://github.com/anchore/grype/issues/712

@bradbeck is deleting the sample-pipeline.cue intentional?
I think we solved this specific issue with with the --only-fixed which may give some people a false sense of security. Might be useful to have a report that tells you all the vulnerabilities that aren't fixed before you deploy to prod, but I also realize that kind of report would be often ignored. Bit of two bad answers no matter which we pick, but I'm fine approving this for now to get some forward progress.

@bradbeck is deleting the sample-pipeline.cue intentional?
I think we solved this specific issue with with the --only-fixed which may give some people a false sense of security. Might be useful to have a report that tells you all the vulnerabilities that aren't fixed before you deploy to prod, but I also realize that kind of report would be often ignored. Bit of two bad answers no matter which we pick, but I'm fine approving this for now to get some forward progress.

@sudo-bmitch Yes. It now lives at the example level. It can exist in multiple places if they are all consistent, but it becomes a pain to update the definition in both places. Now it available across all the examples.

I appreciate the suggestions and everything, but if we never merge this, we will keep having to update something every other week. On my end I think there are no more real blockers here, so we should merge it and iterate when needed.


Feature: Single table inheritance (STI)

In Rails I often use STIs. I try to do the same with SailsJS 0.10.x but I have problems.
Problem 1
I create a base model under models/Base.js with the tableName attribute. Then I create 2 STI models extending from Base.js as explained here https://www.youtube.com/watch?v=038CRoDLU7o. The problem I have is that one of those 3 models become undefined (in console or inside controller). It seams like the _.merge method does not copy the object or smth. It would be very cool to have built-in feature for that or at least proper documentation.
ReferenceError: SubModel1 is not defined
    at repl:1:1
    at REPLServer.defaultEval (repl.js:132:27)
    at bound (domain.js:257:14)
    at REPLServer.runBound [as eval] (domain.js:270:12)
    at REPLServer.<anonymous> (repl.js:277:12)
    at REPLServer.EventEmitter.emit (events.js:129:20)
    at REPLServer.Interface._onLine (readline.js:202:10)
    at REPLServer.Interface._line (readline.js:531:8)
    at REPLServer.Interface._ttyWrite (readline.js:812:14)
    at ReadStream.onkeypress (readline.js:101:10)

Problem 2
I don't see a way how to set the default query filter for a model. STI model should always include the where(type:{model_name}) check by default.
Any suggestions on that? Thx.

Does this approach work with relational DBs?

Just tried this using MySQL and failed.
The second model loaded is overloading the first.
Anyone else got Single Table Inheritance working?

But what about overridden attribute methods? If i query a with Parent I get the Children types as well but not their overridden attribute methods


Add ppc64le support

Description
Performed the code changes referring to Sneha's PR : https://github.com/Dynatrace/dynatrace-operator/pull/1236
We could see three differences.

config/deploy/kubernetes/kubernetes-all.yaml   --> file is no longer present
config/deploy/openshift/openshift-all.yaml   --> file is no longer present
hack/make/go.mk   --> no longer having arch specific code

Reference blog: https://sneha-kanekar.medium.com/dynatrace-on-power-714bf324bdb3

Good news!
We are excited to merge this pull request based on an agreement between Dynatrace and IBM as follows:

Dynatrace will publish Dynatrace Operator container images for ppc64le as part of our Github Actions release pipeline
IBM will recommend a standard configuration to our joint customers as observed in ppc64le lab environments.

Dynatrace Classic Full-Stack
NodeJS, nginx, and Java applications running in glibc containers
Kubernetes API monitoring via Dynatrace ActiveGate on an x86 architecture

Known issues with unique kubernetes node identification such that multiple nodes may appear as one.
IBM will recommend specific versions of the Dynatrace Operator to joint customers after ppc64le images are made available in a public registry.
The Dynatrace Operator team will collaborate with IBM, and joint customers, to bring OpenShift observability to ppc64le in the spirit of this partnership.

Customer support issues, involving the Dyantrace Operator, which cannot be reproduced by Dynatrace on x86 or ARM and are determined to be ppc64le should be directed to IBM at<EMAIL_ADDRESS>

Good news!
We are excited to merge this pull request based on an agreement between Dynatrace and IBM as follows:

Dynatrace will publish Dynatrace Operator container images for ppc64le as part of our Github Actions release pipeline

IBM will recommend a standard configuration to our joint customers as observed in ppc64le lab environments.

Dynatrace Classic Full-Stack
NodeJS, nginx, and Java applications running in glibc containers
Kubernetes API monitoring via Dynatrace ActiveGate on an x86 architecture

Known issues with unique kubernetes node identification such that multiple nodes may appear as one.

IBM will recommend specific versions of the Dynatrace Operator to joint customers after ppc64le images are made available in a public registry.

The Dynatrace Operator team will collaborate with IBM, and joint customers, to bring OpenShift observability to ppc64le in the spirit of this partnership.

Customer support issues, involving the Dyantrace Operator, which cannot be reproduced by Dynatrace on x86 or ARM and are determined to be ppc64le should be directed to IBM at<EMAIL_ADDRESS>
Helllo @chrismuellner
When will this be available?
Regards,
Babar

@bqayyum these changes are available since v0.12.0 (release notes in official documentation) released in june.


Add support to go mod

Remove dep dependency
Update makefile

@joaopapereira at the last meeting this was discussed and I believe the consensus was we wanted to try and have a "1.0" of this before changed to go mods. I'll let others verify that @technosophos @silvin-lubecki @simonferquel @glyn because I might remember incorrectly!

That is correct. We decided that it was a risk to try to switch to this before the scheduled 1.0 release.

Sounds good.
I will have to recreate the PR nevertheless because some modules were added.
On Mon, Jul 15, 2019 at 3:59 PM Matt Butcher<EMAIL_ADDRESS>wrote:

That is correct. We decided that it was a risk to try to switch to this
before the scheduled 1.0 release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/deislabs/cnab-go/pull/52?email_source=notifications&email_token=AAN52UU3JPOU7TIWERDODATP7TJJJA5CNFSM4H3KRVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6ZNWI#issuecomment-511547097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN52UXPY6335MEULNPRVZDP7TJJJANCNFSM4H3KRVBA
.

--
João Pereira

Closing now that #161 has been merged.


implemented --substitutions for custom args with popper run.

Currently, the substitutions in uses are only supported.
If multiple values are assigned to a variable, then the most recent value would be used.
Multiple substitutions can be made by using different substitutions flag every time
Example:  popper run --substitutions _variable=v1 --substitutions _variable2=v2

Pr for #753

Hello @vipulchhabra99! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file cli/popper/gha.py:

Line 181:26: E231 missing whitespace after ','
Line 193:58: E231 missing whitespace after ','

In the file cli/popper/parser.py:

Line 392:31: E231 missing whitespace after ','
Line 405:80: E501 line too long (149 > 79 characters)
Line 405:126: E231 missing whitespace after ','
Line 409:80: E501 line too long (115 > 79 characters)
Line 409:92: E231 missing whitespace after ','
Line 412:1: W391 blank line at end of file

@vipulchhabra99 Thanks a lot for working on this.

popper run --substitutions _variable=v1,_variable2=v2

We can remove the support for passing multiple key-value pairs through one --substitution using ,, as we want to keep any kind of argument parsing by ourselves to the minimum. We want click to handle as much of it as possible.
Also, It would be great if you can write the corresponding unit tests.

Yeah, sure @JayjeetAtGithub.

@vipulchhabra99 Sounds good. The test that you have written ci/test/substitution is an integration test (kind of testing the feature at a high level from a user point of view). The unit tests (where we test every function in an isolated manner) are situated here. You can see how the unit tests are designed and test the new functions you have implemented in a similar manner. Does that make sense?
After you write the tests, you can test it by doing
$ cd popper/cli
$ python setup.py test

Yeah, that makes sense to me. Sorry for misunderstanding it, I will implement them and update the pr soon. Thanks a lot for guiding me :relaxed:

@ivotron Can you please review this pull request? So that If more changes are required I can make them and fix this issue.

Hi @ivotron , Thanks a lot for reviewing in addition to the above features you mentioned in comments I have added one extra feature to verify if the substitution variable follows the special rules if they don't follow I have logged the error. Should I retain that in final commit or remove it?

Hi @ivotron, There were 2 very minor errors in the previous commit, I have fixed those errors, please review it once and do let me know if more updates are required.

thanks a lot @vipulchhabra99


setup.py develop install not working

Not sure why this is the case ... but I am having to run the install command every time I change everything

yes, both @titipata  and myself face the same issue. i currently rerun setup.py after each change to my code.

so, no need to run python setup.py develop install each time we make a change?

yeah, but you would still need to exit ipython and enter it again ...
That's why I work with nosetests --pdb because I don't need to exit ipython


Fix glitch with 'scrolloff' mapping at bottom of file

This PR fixes a glitch with scrolling when 'scrolloff' is greater than 0. Previously, the mapping of the 'scrolloff' Vim option to IntelliJ's "vertical scroll offset" setting would update the (local, per-editor) IntelliJ setting to the same value. IntelliJ would use this when performing its own scrolling. However, IntelliJ's scrolling calculation includes the virtual space at the bottom of the file. So typing G would place the last line at the bottom of the screen, but then any caret movement would trigger IntelliJ's scrolling and move the last line up to include scroll offset/virtual space.
This was more noticeable with a large scroll offset, such as 999, intended to keep the caret in the centre of the screen. After typing G to put the last line at the bottom of the screen, hitting backspace in Insert mode would trigger IntelliJ to update scrolling, and it would try to put the current line at the centre of the screen. IdeaVim would also update scrolling and reposition the line at the bottom of the screen, causing the editor to "twitch" as you type. Normally setting the scroll position multiple times would result in "last write wins" and there should be no glitch, but IntelliJ's backspace handling updates the scroll position with animation disabled, so the editor immediately (and visibly) scrolls, and is then immediately scrolled back. (VIM-3474)
This PR updates the 'scrolloff' mapping so that the IntelliJ setting is always set to 0. IntelliJ's scrolling no longer includes scroll offset, and IdeaVim's scrolling can then position it correctly. It also handles a potential issue with 'scrolljump' being a negative value (Vim allows -1 to -100 as percentages), which IntelliJ does not validate.

Great, thank you for the fix!


value of selected credential not updated by timer, needs re-selection

from #144 :

Issue: After selecting an OTP entry and copying to clipboard, Authenticator works as expected. However, if copying a second time—at least with Ctrl+C—the first OTP code is merely copied to clipboard again, instead of whatever new code has been generated since the first.

The timer or the copy event should update the value of the selected credential, so that a fresh OTP is copied.

Thanks! By the way, what's the best way to keep up to date on releases for this or the other Yubico support tools / packages?

Thanks! By the way, what's the best way to keep up to date on releases for this or the other Yubico support tools / packages?

We do have some RSS feeds on developers.yubico.com.
This project
https://developers.yubico.com/yubioath-desktop/Releases/atom.xml
All projects
https://developers.yubico.com/Software_Projects/atom.xml

@dagheyman I think that second one is exactly what I was looking for, assuming it'll include any new tools / projects added. Thanks!

@dagheyman Can we expect to see a release with this fix soon?
Thanks!

@rmenessec Yes, will probably do a new release in August.


Feature/ranges

Codecov Report
Patch coverage is 98.23% of modified lines.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed
Coverage

src/modules/company/CompanyTest.cpp
79.59%

src/modules/book/BookTest.cpp
100.00%

src/modules/color/ColorTest.cpp
100.00%

src/modules/commerce/CommerceTest.cpp
100.00%

src/modules/database/DatabaseTest.cpp
100.00%

src/modules/datatype/DatatypeTest.cpp
100.00%

src/modules/date/DateTest.cpp
100.00%

src/modules/finance/FinanceTest.cpp
100.00%

src/modules/helper/HelperTest.cpp
100.00%

src/modules/internet/InternetTest.cpp
100.00%

... and 9 more

:loudspeaker: Thoughts on this report? Let us know!.

Good job :fire:


Adding option showNLabels to Line & Bar Chart to define the number of…

… X labels to show (< 1 to disable).

We've recently announced a feature complete status for v1.x and will only be accepting bug fixes for v1.x. Be sure to take a look at v2.0-dev and it's new features that are either finished or currently under development.  If you see your feature is still not implemented, feel free to submit another PR to the v2.0-dev (or later) branch for your feature.


Changes to make the bot not walk directly under a pokestop to spin it.

Short Description: Changes to make the bot not walk directly under a pokestop to spin it.
Changes:
Should walk to within 30 meters then switch to next fort.
Also changed the spinner to trigger within 35 meters.

#254 obsoletes this, closing.


fix: Use the "resolving" service event in the PluginServiceProvider

Currently the plugin service provider force-resolves the filament service whenever the first filament plugin's ServiceProvider is registered. This interrupts the normal service lifecycle which allows for calls to $app->extend() (such as in my multi-context package).
This is also related to the changes made in https://github.com/laravel-filament/filament/pull/2055

Can we be certain that this won't introduce any breaking changes for other plugin developers? I don't think it will, but want to be certain.

@ryangjchandler I don't believe it will either. This brings also more conformity with what the Register and Boot methods of a service provider are supposed to be used for.
https://laravel.com/docs/providers#the-register-method

"As mentioned previously, within the register method, you should only bind things into the service container. You should never attempt to register any event listeners, routes, or any other piece of functionality within the register method."

If this does break something because a plugin is calling the Filament service in their provider's register method then we can point them to this documentation saying that they should do so in the Boot method instead

Hm, yeah.. the reason we're forced into using the register method is because of the order of execution of route loading in packages.

Thanks!


Export as json Map

Question
I would like to save my data in the firebase database, as well as in a hive box, then I would like replace the "json_serializable" library with "hive", but I can't convert the data in a box into a json map. In various issues and on the site1  it is said to use the box.toMap() method in this regard, however it returns a Map whose values are the objects already deserialized. For example, if in my box I save instances of the following class:
class MyModel {
  String name;
  String code;
}

then box.toMap() return a Map with type Map<String, MyModel>. Instead I have to get a Map with serialized objects, as with the _ $ MyModelToJson method created with json_serializable.
Version

Hive version: 1.4.1+1

1:
From FAQ - Can Hive sync data with a server?:

Not out of the box but you can do that yourself quite easily using the box.toMap() method and the change notifier.

From Issue  #162 - Export Database to .db / .hive /another file (csv etc):

Just use yourBox.toMap() and you basically have JSON.

I suggest you to use both json_serializable and hive. Hive doesn't contains out of the box json (de)serialiation support. So you have to to it yourself (eg: using json_serialization).
Box.toMap creates key - value dictionary. It doesn't converts your objects to string -dynamic maps. You can check source code for toMap function.
So, I just suggest you to use both packages. Because each of them has their own functionality. One is for serialization while other one is used for persistent data storage (database).

Thanks so much. The aforementioned reply in issue #162 made me doubtful. I will use hive combined with json_serializable, which I have seen work well together.

Thanks so much. The aforementioned reply in issue #162 made me doubtful. I will use hive combined with json_serializable, which I have seen work well together.


Map Message Structure

Tutorial URL: https://developers.sap.com/tutorials/cp-integration-convert-message-structure.html
Step1-1: When I try to download a file from a link to add a Source Message and a Target Message, I get an error if it has expired.
Please correct the link.

Hi,
The link is corrected now. Please try again and let us know.
Best Regards,
Gautham

@hashimoto-ksc I am closing the issue. If you still have an issue, feel free to reopen.


5.0.0-rc2 Cannot read swagger.json error when hosted as an application under a website on IIS

Thanks for contributing to Swashbuckle.AspNetCore! As per the contributing guidelines, please adhere to the following rules of thumb before submitting your issue:
VERSION:
5.0.0-rc2
STEPS TO REPRODUCE:
Create a webapi project in Net Core 2.2 running on IIS.
.csproj:
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.2</TargetFramework>
    <AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
  </PropertyGroup>

  <!-- Enables XML comments on Swagger-UI -->
  <PropertyGroup>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);1591</NoWarn>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.App" />
    <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="2.2.0" PrivateAssets="All" />
    <PackageReference Include="Swashbuckle.AspNetCore" Version="5.0.0-rc2" />
  </ItemGroup>

</Project>

Startup:
public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_2);
            services.AddSwaggerGen(c =>
            {
                c.SwaggerDoc("v1", new OpenApiInfo { Title = "My API", Version = "v1" });
            });
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseSwagger();
            app.UseSwaggerUI(c =>
            {
                c.SwaggerEndpoint("/swagger/v1/swagger.json", "My API V1");
                c.RoutePrefix = string.Empty;
            });

            app.UseMvc();
        }
    }

EXPECTED RESULT:
Working on local development as http://localhost:5000/ and on IIS on localhost/mysite/
ACTUAL RESULT:
It works locally and when I compile a release version and deploy to IIS, I enter the site http://localhost/mysite/ and the error:
Fetch error Not Found /swagger/v1/swagger.json
Also, in the browser, if I enter http://localhost/mysite/swagger/v1/swagger.json I see a Json in OpenApi.
WORKAROUND
I got on Stackoverflow a workaround, but I think the lib should really identify the application path by default since I am using the default path for the swagger.json (/swagger/v1/swagger.json)
app.UseSwaggerUI(c =>
        {
#if DEBUG
               // For Debug in Kestrel
               c.SwaggerEndpoint("/swagger/v1/swagger.json", "Web API V1");
#else
               // To deploy on IIS
               c.SwaggerEndpoint("/mysite/swagger/v1/swagger.json", "Web API V1");
#endif
            c.RoutePrefix = string.Empty;
        });

In addition to the above, what about c.RoutePrefix? It doesnt work for me locally without setting it to an empty string. With:
c.SwaggerEndpoint("swagger/v1/swagger.json", "EDIPartner V1");
c.RoutePrefix = "";

I still have the "Failed to load API definition" error: Fetch error
Service Unavailable ../swagger/v1/swagger.json

here same issue also


Pull hero from CMS

👇 pages have hard-coded hero content. Reuse/extend getHero to cover pulling hero these pages as well as update lib/index.js to use CMS hero for these pages:

/projects,
/opportunites,
/contant,
/imprint, and
/privacy.

@kilemensi  I'm picking up this.


Fix first exercise on mutltiprocessing

Fixes #179

I tried things again. It works now, but with very little indentation fix that I pushed in ab1afb6


Upgrade travis infrastructure

A notice from Travis CI:

This job ran on our legacy infrastructure. Please read our docs on how to upgrade

We should investigate this and, presumably, upgrade to their new infrastructure.

Actually, looks like @mucaho  already took care of adding sudo: false to the .travis.ytml file.  :)
Is there anything about the new infrastructure we can take advantage of that requires further changes?  Or should I close this issue?

Nah, that's it as far as I know :+1:


Merge heuristics for disambiguating ".t" files

Follow-up of @pchaigno's suggestion in #3546. This PR merges the heuristics used for matching .t files on GitHub, but also applies a few other enhancements I made along the way:

Perl 6 is now checked before Perl 5
Both languages understand use strict;, but the pragma is less likely to surface in the former. According to the docs, Perl 6 enables strict mode by default, making the use strict; pragma redundant. Conversely, Perl 5 has strict mode off by default for compatibility reasons only - but every Perl programmer knows to enable strict-mode (and warnings) before starting work on any halfway-serious program.

Multiple blanks are now checked, instead of matching a single space
/use strict/ won't catch pragmas that use tabs, or have multiple spaces between each word. Newlines are even permitted too: the following chunk is valid Perl:
use

strict;

use
	v5.24.0;

Turing's heuristic now looks for := instead of :
The tests failed because a Terra file was misclassified as Turing. I realised a pattern like var abc : xyz is bound to surface in other languages, so I changed it to match var abc := xyz instead. := wasn't mentioned anywhere in Terra's language reference, so I'm guessing it won't occur there.

Other observations

Semicolons are valid Turing
In #3546, I wondered if the original Turing/Perl heuristic could be refined to check for trailing semicolons (since Turing doesn't use the). I installed and ran Open Turing, and it evaluated put 2 * 8; perfectly fine. I guess they're legal characters, but ignored. Noting this for future reference if needed.

Many of the other heuristics could be (micro-)optimised
There're numerous capturing groups that aren't referred to by back-references, which requires a little extra overhead at runtime (since the regex engine needs to retain references to captured substrings). Using (?:…) instead of (…) is generally best practice when referencing the capture isn't needed.
Granted, the performance boost is only minimal, but if this code has to check millions of files, well... I'd wring every drop of performance I could get.

Our heuristics are making naive assumptions about whitespace
Going back to point #2 above, it's likely that some heuristics aren't matching files they should be because the subject's source code contains multiple whitespace characters.

I'm thiiiiiiiisss 👉 👈  close to building the next release. If you're quick @pchaigno, this'll make it.

Erm, would you mind holding off until atom/language-javascript#497 is merged? There're some really important highlighting fixes that need to be fixed upstream.
@50Wliu, are you almost done??

@Alhadis sure, though I can't hold too long as I need to get this released and merged onto github.com before 9 May so it can make it into the next Enterprise release.

That's all up to @50Wliu.

I need to ship the next Linguist release this morning (:gb: time) to give it time to "soak" on github.com before we freeze the Enterprise release early next week.  It doesn't look like https://github.com/atom/language-javascript/pull/497 is going to make it into this release, sorry @Alhadis.
It's not too much of a problem though as once we've got the latest release :ship: it shouldn't be too hard to keep Enterprise updated with Linguist updates. At the moment Enterprise is too far behind and hasn't been kept up to date so the Linguist update don't cleanly backport.

Hey @lildude,
That's understandable. Would it be feasible to switch grammars to use my fork for the time being? We can always switch it back later until this is taken care of upstream.

I'll be home in an hour or so.
I apologise for all this. I hadn't expected there'd be problems caused by bike-shedding.

Would it be feasible to switch grammars to use my fork for the time being?

Hmmm, I'm a little uncomfortable with doing this this late in the game, especially with your current proposed changes still being in discussion.
How much of a problem is the one you're trying to fix in https://github.com/atom/language-javascript/pull/497?

especially with your current proposed changes still being in discussion

Literally the only thing blocking it is that the maintainer doesn't like the way I've implemented something. Everything is fine, it's just bike-shedding at this point.

How much of a problem is the one you're trying to fix in atom/language-javascript#497?

Bad enough I'd say, although since this is my own screw-up I'm fixing, it's possible it looks much worse to me than it really is.

I don't think that's too bad (I'm not a JSDoc fundi 😉), but https://github.com/atom/language-javascript/pull/496 does intro a change in behaviour for that syntax which at the same time introduces a "known" bug.
I think it may be best to keep the javascript grammar as it currently is (ie at a point before https://github.com/atom/language-javascript/pull/496 was merged and not specifically exhibiting any problems on github.com - at least none have been reported AFAIK) and update once your PR has been merged.

That makes much more sense, actually. =) Let's go with that.


enhancement to have keyboard command to save checkpoint now

The interface has been changed from char-rnn, so I didn't set the save checkpoint correctly. I've got a larger nn size started with tensor-rnn and it looks like it won't do a checkpoint till 50 epochs.
It's currently on 36 and is calculating 2 epochs per day (250 buffer), ie another week.
Looking at the learning rate it would have been great to save a checkpoint "on demand" i.e. via keyboard command at certain points, 18 epochs, being the point where the training leveled of, in this case.

Trying to pull interactive keyboard commands is a bit out of scope for this project. Having a loop checking for keyboard commands then passing that on at the end of a batch will increase complexity significantly and will only be useful in a few edge cases. If you would like, you can submit a pull request, but I just don't think that will be on the roadmap anytime soon for us to implement.


fix the regex to include file who end with tes

Codecov Report

Merging #694 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files         264      264
  Lines        6801     6801
  Branches     1588     1588
=======================================
  Hits         6782     6782
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c14bcb...8ecf8e2. Read the comment docs.


Fix Calyrex-Ice-Rider / Shadow-Rider

Small Q.O.L -- Limitless displays ice-rider and shadow-rider instead of just calyrex-ice and calyrex-shadow. Create an association to map these to the same mon to display the image for either instance.

Updated in cdf02e0


WLS10.3.6 no NMProperties support?

NMProperties configuration is not supported in WLS <IP_ADDRESS>.
Is there an alternative way to manage nodemanager.properties with WDT for WLS 10.3.6? Or a suggested approach?
I'm specifically trying to set SecureListener property to false.
Please let me know if there is a better place to post in the future.

@acarlson1994 We left this issue open, as we hoped to find a better solution at some point.  Unfortunately, we have been unable to provide anything meaningful in regards to NM support in 10.3.6.  WDT is aligned with WLST and NM isn't managed by WLST a later release of WLS.  I am open to suggestions or an outside pull request in this area, but we are not likely to add a feature in this area to support configuring 10.3.6 NM at this time.


Old versions of Coq alongside some Coq packages fail to build

Describe the bug
Old versions of Coq alongside some Coq packages listed in an opam file fail to install, the fix introduced in 5bfdc95cfb7662cac808eb1baa70ae3fff0cab4f only works for newer versions of Coq. The fix doesn't work for older versions of Coq, see #48 and the resulting 34d74ca9d64339c453cbac3f85255644361937e2 which disables it for Coq < 8.17.
To Reproduce
An opam file including, for example:
"coq" {>= "8.10" & < "8.12.0" }
"coq-ott" {>= "0.29"}

fails to build when following the standard instructions in the README of opam-nix with the error:
error: builder for '/nix/store/s5f9ss5b3i47fj85ik1k3ppv5nvv6fx4-coq-ott-dev.drv' failed with exit code 2;
       last 10 log lines:
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/Ott/': No such file or directory
       > make[1]: *** [Makefile.coq:490: install] Error 1
       > make[1]: Leaving directory '/build/source/coq'
       > make: *** [Makefile:5: install] Error 2
       > make: Leaving directory '/build/source/coq'
       For full logs, run 'nix log /nix/store/s5f9ss5b3i47fj85ik1k3ppv5nvv6fx4-coq-ott-dev.drv'.
error: 1 dependencies of derivation '/nix/store/ny29rycz6mqgskfmn8iv4sc57spmpv7x-coq-mi-cho-coq-dev-env.drv' failed to build

(Using nix develop --impure to trigger a build of Coq).
Expected behavior
Such an opam file would succeed at building Coq with coq-ott, following the instructions of the README.
Environment
OS name + version: NixOS
Version of the code: https://github.com/tweag/opam-nix/tree/34d74ca9d64339c453cbac3f85255644361937e2
Additional context
Removing the version constraints resulting in the following opam file, builds successfully. Giving: Coq v8.17.1
  "coq"
  "coq-ott"

I am trying to build the Coq specification of Michelson, Mi-Cho-Coq, with this .opam file.
This fails with:
error: builder for '/nix/store/cggr7bq1jzransryclk1k4k6mng60bhs-coq-error-handlers-1.2.0.drv' failed with exit code 2;
       last 10 log lines:
       > patching script interpreter paths in .
       > ./configure.sh: interpreter directive changed from "#!/usr/bin/env sh" to "/nix/store/zlf0f88vj30sc7567b80l52d19pbdmy2-bash-5.2-p15/bin/sh"
       > building
       > COQDEP VFILES
       > COQC src/All.v
       > installing
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/ErrorHandlers/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/ErrorHandlers/': No such file or directory
       > install: cannot change permissions of '/nix/store/d75jswiprkwrmwm21xzv04rkjdxpwwmf-coq-8.11.2/lib/ocaml/4.11.2/site-lib/coq//user-contrib/ErrorHandlers/': No such file or directory
       > make: *** [Makefile:490: install] Error 1
       For full logs, run 'nix log /nix/store/cggr7bq1jzransryclk1k4k6mng60bhs-coq-error-handlers-1.2.0.drv'.
error: 1 dependencies of derivation '/nix/store/7jx8n5nvn5pphwkd9xi9q9c7dwgwdmiw-coq-list-string-2.1.2.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-coq-menhirlib-dev.drv-21/source/test/static/good': Directory not empty
error: 1 dependencies of derivation '/nix/store/s6f2rpr2df4lanmayilpin3npq7cfvdw-coq-mi-cho-coq-dev-env.drv' failed to build

I also tried the .opam file of the dev branch of Mi-Cho-Coq, which fails with a different error:
error: builder for '/nix/store/ldzavngayh84hm4a3z2bmib1vxd5f15r-coq-error-handlers-1.2.0.drv' failed with exit code 1;
       last 10 log lines:
       > unpacking sources
       > unpacking source archive /nix/store/qvd45x7m9a2hvnhm0fm8r7nyh4q8yl0y-1.2.0.tar.gz
       > source root is coq-error-handlers-1.2.0
       > setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file coq-error-handlers-1.2.0/src/All.v
       > patching sources
       > configuring
       > patching script interpreter paths in .
       > ./configure.sh: interpreter directive changed from "#!/usr/bin/env sh" to "/nix/store/zlf0f88vj30sc7567b80l52d19pbdmy2-bash-5.2-p15/bin/sh"
       > building
       > Error: cannot find /nix/store/jcyy5nd5q4l576mm6m1z3i2kca6454za-coq-8.16.1/lib/ocaml/4.14.1/site-lib/coq/../coq-core/tools/CoqMakefile.in
       For full logs, run 'nix log /nix/store/ldzavngayh84hm4a3z2bmib1vxd5f15r-coq-error-handlers-1.2.0.drv'.
error: 1 dependencies of derivation '/nix/store/i1xx683iarcvdk14yskhaq7la1cxrs1j-coq-list-string-2.1.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/xbwp8ihlzwpgllcdib5dvdi7rp7r06k9-coq-mi-cho-coq-dev-env.drv' failed to build

The dev branch's .opam file builds successfully via opam.

Hi! Should be fixed now. If you encounter more problems, please feel free to open corresponding issues.

Hi @balsoft, thank you very much for your efforts. I am still encountering an issue related to building Coq packages alongside Coq, though the error message is different to prior to 9c7e1be164eb1a60fd531479c3c512f3711d552b. I see you added a Coq Example which I've tried to use but may be using improperly.
My goal is to have a shell with the same dependencies loaded as if I'd used eval $(opam env --switch=mi-cho-coq) where the switch mi-cho-coq had been created as below (running from a clone of mi-cho-coq's dev branch):
opam switch create mi-cho-coq 4.13.1
opam repo add coq-released https://coq.inria.fr/opam/released
opam repo add coq-extra-dev https://coq.inria.fr/opam/extra-dev
opam install .

Currently, I'm using the following flake.nix file:
{
  inputs = {
    opam-nix.url = "github:tweag/opam-nix";
    flake-utils.url = "github:numtide/flake-utils";
    nixpkgs.follows = "opam-nix/nixpkgs";
    opam-repository = {
      url = "github:ocaml/opam-repository";
      flake = false;
    };
    opam-coq-archive = {
      url = "github:coq/opam-coq-archive";
      flake = false;
    };
  };
  outputs = { self, flake-utils, opam-nix, opam-repository, opam-coq-archive, nixpkgs }@inputs:
    # Don't forget to put the package name instead of `throw':
    let package = "coq-mi-cho-coq";
    in flake-utils.lib.eachDefaultSystem (system:
      let
        pkgs = nixpkgs.legacyPackages.${system};
        on = opam-nix.lib.${system};
        scope =
          on.buildOpamProject { repos = [ opam-repository
                        ("${opam-coq-archive}" + "/released")
                        ("${opam-coq-archive}" + "/extra-dev")
                      ];
            } package ./. { ocaml-base-compiler = "*"; };
        overlay = final: prev:
          {
            # Your overrides go here
          };
      in {
        legacyPackages = scope.overrideScope' overlay;

        packages.default = self.legacyPackages.${system}.${package};
      });
}

I think perhaps the above flake.nix is trying to make use of the .opam file from the coq-mi-cho-coq package in the coq-released or coq-extra-dev which is an issue. But the bigger issue is that regardless, it still fails to build.
The following error appears:
$ nix develop --impure
warning: Git tree '/home/daniel/Documents/Code/research/mi-cho-coq-nix' is dirty
error: builder for '/nix/store/6vmrc4cjjap71kknajmawyj8sfnikjgd-coq-list-string-2.1.2.drv' failed with exit code 2;
       last 10 log lines:
       > COQC src/Comparison.v
       > COQC src/Conversion.v
       > COQC src/Trim.v
       > File "./src/Conversion.v", line 6, characters 15-32:
       > Error: Cannot find a physical path bound to logical path matching suffix
       > ErrorHandlers.
       >
       > make[1]: *** [Makefile:677: src/Conversion.vo] Error 1
       > make[1]: *** Waiting for unfinished jobs....
       > make: *** [Makefile:327: all] Error 2
       For full logs, run 'nix log /nix/store/6vmrc4cjjap71kknajmawyj8sfnikjgd-coq-list-string-2.1.2.drv'.
error: 1 dependencies of derivation '/nix/store/djyz98q8l5h9nknjp0j0dk8psaiv5i70-coq-mi-cho-coq-dev-env.drv' failed to build

Thanks for your help once again. I feel this is still the current issue, but I cannot re-open it. If you'd prefer me to make it a new issue, that's fine too. Apologies for the delay in getting back to you.

I can reproduce. In this particular case, relaxing the coq version requirement:
diff --git a/coq-mi-cho-coq.opam b/coq-mi-cho-coq.opam
index a202b28..34a2de6 100644
--- a/coq-mi-cho-coq.opam
+++ b/coq-mi-cho-coq.opam
@@ -22,7 +22,7 @@ depends: [
   "coq-list-string"
   "coq-menhirlib" {>= "20190626"}
   "coq-moment" {>= "1.2.0"}
-  "coq" {>= "8.14" & < "8.17.0" }
+  "coq" {>= "8.14" }
   "menhir"
   "ocaml" {>= "4.07.1"}
   "ocamlbuild"

Results in a successful build with the same flake as you have provided.
I'll try to figure out how to make it build with an older version.

Thanks @balsoft, I can also confirm that relaxing the coq version requirement allows it to be built. For me, this yield coqc --version = 8.17.1.

Unfortunately, getting old versions of Coq to work seems to require more work than I'm able to put in at the moment; it's quite difficult to configure installation locations for Makefile.coq et al, while still allowing Coq to find its stdlib. If someone else is willing to step up (perhaps taking a look at nixpkgs would be of use), feel free.

Thanks for your efforts @balsoft!


METAMODEL-1207: fix regex pattern in order to fetch the correct version in all cases

Resolves METAMODEL-1207
The Regex pattern used to fetch the database major version is repleced with the correct one that covers all possible cases. Also the fix is confimed with unit test.

I could create a new VersionParser class and write the appropriate unit tests.  Which is the correct package to add this class?

Probably just add it in the org.apache.metamodel.jdbc package and make the class non-public so that it's only visible from other classes in the same package.

Looks good to me. One of the builds failed but it is unrelated (flaky Excel module test). I'll merge it in.


Bug related to indexed parameters in events

Semantic tests related to indexed parameters in events are failing:

tests/behaviour/solidity/test/libsolidity/semanticTests/events/event_constructor.sol -> Fails at cairo compilation
tests/behaviour/solidity/test/libsolidity/semanticTests/userDefinedValueType/erc20.sol -> Fails at deployment
tests/behaviour/solidity/test/libsolidity/semanticTests/various/erc20.sol -> Fails at deployment

The first one fails because there is a bug in the BuiltinHandler pass.
The transpilation of the following contract produces invalid cairo code
contract ClientReceipt {
    function Deposit(address _from, bytes32 _id, uint _value) public {
	}
    constructor() {
        Deposit(msg.sender, bytes32("abc"), 7);
    }
}

The other two are failing because the following contract don't deploy
contract ERC20 {
    constructor() {
        _mint(msg.sender);
    }
	function _mint(address account) internal {
        require(account != address(0), "ERC20: mint to the zero address");
    }
}

So technically these errors are not related to indexed parameters @cicr99

Yes, I thought that could be possible. These tests were commented on the whitelist because "indexed events" was an unsupported feature. Once I uncommented them, they failed, so actually the issue is for us to investigate the reasons why they did. Thanks for looking into it.

Now, the first issue is addressed #900 , the other remaining two can fixed if we use starknet-devnet as execution platform for behaviour/semantic tests, for that I've create an issue #901 . Using starknet-devent we can pass an account address , in the current situation behv/semantic tests by default uses caller address as 0 during deployment.
@cicr99  So, you can close this issue.

Thanks for triage @RohitRanjangit!


Sdk 42: Java sdk: Add support for hbase cluster creation

hbase cluster creation

This is missing a constructor change as in 99b7b6bb199bc92032059c8790b71797d2f9acfc. What's the reason for that? Also, is this available in v1.2?

added constructor parameter, i created hbase cluster using v1.2 and creation is successful.

Can you resolve the conflict for this and test it once more manually for creating hbase cluster and hadoop cluster?

verified by creating hbase/spark/hadoop2 clusters


File name / Tab title of untracked files is hard to read

The name of the file Tutorial.ipynb here in orange on a similarly colored background is quite difficult to read.

I notice that this depends on the screen. On the screen I'm currently using, this isn't such a problem.


Configure containers.

Correct namespace for SkippableAttributes.
Correct chaining of TestcontainerBuilder.
Change Fixture to CollectionFixture.
Refactor timeout test.
Add SocketException to accept criteria (occurs when running in GitHub Actions).
This PR is a few fixes to get the TestcontainersBuilder back to working in new structure.
Change Fixture to CollectionFixture, from ClassFixture, to keep the same container instance running for all test classes.

Instead of using the available dockers I made the choice of copying the source so that we are decoupled from any breaking changes in those repos or any images that go defunct (may not be the best decision)
Being able to change the Dockerfile would be nice.
I think it would be easier to get the servers up with customized Dockerfiles.
Simple example is the proftp that requires a volume mounted to work, would be nice to remove that requirement.
I haven't experimented with it yet, but seems there is a ImageFromDockerfileBuilder in Testcontainers-dotnet that might work to build image from Dockerfile.

> This method will run 1 single type of ftp-server when run on developer computer.
I have one question. The whole integration test system has been designed to be run on Github Actions. What if I wanted to run it locally? How do I create the "matrix" of tests within Visual Studio so it can be run in such a way?

I don't have a solution for that.
I'm fairly certain that it would be possible to extend xUnit behavior to do it, though I'm not sure how.
Though that would likely remove the ability to have GitHub Actions run each server in parallel.
I tried https://github.com/nektos/act to run GitHub Actions on my PC.
My quick experiment failed. Possibly it tried to start 2 workers that both wanted to start docker ftp-server and colliding.
There might be a solution involving this or similar tool.

Wow. Just saw this. Thanks a ton!!

This PR is a few fixes to get the TestcontainersBuilder back to working in new structure.

Thanks very much!!

Being able to change the Dockerfile would be nice.
I think it would be easier to get the servers up with customized Dockerfiles.

Then let me bring back my forks.

Added customized dockerfiles, please feel free to edit them as you wish!
Updated steps.


Optimize convert_tz function internal

1、convert_tz operator cost too much time, when we do not use convert_tz in sql, it cost about 1s, when we use, it cost 8s
2、because of re2 function hot, we replace re2 with hyperscan

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Pslydhh PTAL

The CI task of check the code format failed, you can view the failure reason through the details button of starrocks_clang-format, maybe you need change the code style~

1、convert_tz operator cost too much time, when we do not use convert_tz in sql, it cost about 1s, when we use, it cost 8s 2、because of re2 function hot, we replace re2 with hyperscan

Thank you, I think it's a good idea to use hyperscan instead of re2.

1FE, 1BE
cpu: 8 core
dataset：7300600 rows
Test sql:
SELECT `t0`.`__fcol_2` AS `__fcol_5`
    , `t0`.`__fcol_1` AS `__fcol_8`
    , COUNT(1) AS `__fcol_9`
FROM (
    SELECT `T_C6CAFA`.`handle` AS `__fcol_0`, `T_C6CAFA`.`ip_org_name` AS `__fcol_1`, `T_C6CAFA`.`session_create_datetime_store_timezone` AS `__fcol_2`
    FROM (
        SELECT t1.handle
            , t1.store_internal_mark, t1.visit_store_cnt, t1.ip_org_name, t1.dt
            , CONVERT_TZ(FROM_UNIXTIME(t1.session_create_time / 1000), @@session.time_zone, coalesce(t1.store_timezone, 'Asia/Shanghai')) AS session_create_datetime_store_timezone
        FROM sl_dm.sl_dm_ent_behavr_session_sdt t1
    ) `T_C6CAFA`
    WHERE `T_C6CAFA`.`dt` >= '2021-12-05'
        AND `T_C6CAFA`.`dt` < '2022-01-07'
        AND `T_C6CAFA`.`session_create_datetime_store_timezone` >= '2021-12-06 00:00:00.0'
        AND `T_C6CAFA`.`session_create_datetime_store_timezone` < '2022-01-07 00:00:00.0'
        AND `T_C6CAFA`.`visit_store_cnt` > 0
        AND `T_C6CAFA`.`store_internal_mark` IN ('ss1', 'ss2')
) `t0`
WHERE `t0`.`__fcol_2` >= '2021-12-06 00:00:00.0'
    AND `t0`.`__fcol_2` < '2022-01-07 00:00:00.0'
GROUP BY 1, 2;

withen cctz lock optimize, pull request: https://github.com/google/cctz/pull/214
test result:
hyperscan and cctz together


Add Cisco support to BFD  Task

Fixes #126

force pushed to resolve conflict

Yeah I tried to make something like that, but it ended up feeling very over-engineered. But if we have a 3rd vendor like HP we need to support then it will probably feel better

The rule of thumb I try to follow in these matters:

Once is by chance. Twice is a coincidence. Three times is a pattern.

Just my $0.02 :)


[5194] Link to trainees from dead job viewer

Context
Link to trainees from the show page of dead job viewer.
Changes proposed in this pull request
Add a button to link to the trainee from the dead job viewer.
Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Dead Job Viewer: Link to trainees from Show page


[q]is 'rendered' promise for modal still available?

I am would like to know if next line from doc is still valid

rendered - a promise that is resolved when a modal is rendered

Yes, it is still valid.

My guess is that its not

Besides I did a search for 'rendered' keyword in your code and did not find anything related to that

https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L559

Ok, I figure out what happened. For some reason we have old version of you package in node_modules.
Btw. Github cant find line you mentioned
https://github.com/angular-ui/bootstrap/search?utf8=✓&q=rendered
Thanks a lot for help

You're welcome.  BTW, the link works fine for me:

Your search link isn't valid because GitHub is only showing the first two matches for modal.js and indicates thus above each window.  Look for the text: "Showing the top two matches. Last indexed 2 days ago."


State that the set of ValueTuple types provided is implementation-defined

Part of #768.
@Nigel-Ecma I'm not sure this fully addresses your concern of "Do we need to say anything about how one implementation handles tuple values created by another with a different m?" from #664, but I couldn't think of a simple way of stating that. I'm hoping you'll agree that saying that the set of types available is implementation-defined implies that you shouldn't expect to be able to use code compiled for one implementation on another implementation, but other suggestions are welcome :)

Actions from meeting 2023-07-12:

@Nigel-Ecma to write a suggested paragraph that removes all reference to System.ValueTuple
@jskeet to write a suggested paragraph that addresses the womple concern

Alternative suggestion from @gafter: we take the standard in the other direction, specifying exactly what set of types we have.

... and now we're considering whether womples are actually tuple types despite not having syntax.
New proposal:

Specify the complete set of ValueTuple<...> types
Specify that womples exist, but cannot be written using tuple type or tuple literal syntax (do this bit properly!)

Thing to check: whether == is handled "appropriately" (in the compiler) by ValueTuple<T> and ValueTuple. If it is, we should describe these as tuple types.

Nope, it looks like ValueTuple and ValueTuple<T> are not tuple types in terms of ==:
ValueTuple<int> x = new ValueTuple<int>(5);
ValueTuple<int> y = new ValueTuple<int>(5);
// Operator '==' cannot be applied to operands of type 'ValueTuple<int>' and 'ValueTuple<int>'
Console.WriteLine(x == y);

ValueTuple v1 = new ValueTuple();
ValueTuple v2 = new ValueTuple();
// Operator '==' cannot be applied to operands of type 'ValueTuple' and 'ValueTuple'
Console.WriteLine(v1 == v2);

@jskeet to try to create a new PR that specifies all System.ValueTuple types, and rewrites the representation to only go one way (to System.ValueTuple without coming back out in terms of "tuples types" for the continuation part).


Unable to save and then load the local saved trained model

NOT ABLE TO SAVE TRAINED MODEL TO LOCAL DISK AND THEN USE FOR INFERENCE :
I am pulling my hair out, trying to figure out why I keep getting and error for  simply saving a model to local disk after training and then  loading it. The unsloth API seems to only look for the model on hugging face and refuses to look on local disk ?
STEPS TO REPLICATE ISSUE:
I save  the trained model with adapters : I can see in the directory everything seems to be saved.
But when I try to read in the model from local disk I just keep getting the same error:
Unsloth: Fast Llama patching release 2024.5
\   /|    GPU: NVIDIA GeForce RTX 4070 Laptop GPU. Max memory: 7.754 GB. Platform = Linux.
O^O/ _/ \    Pytorch: 2.3.0+cu121. CUDA = 8.9. CUDA Toolkit = 12.1.
\        /    Bfloat16 = TRUE. Xformers = 0.0.26.post1. FA = True.
"-____-"     Free Apache license: http://github.com/unslothai/unsloth
***** OSError: None is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'
If this is a private repository, make sure to pass a token having permission to this repo either by logging in with huggingface-cli login or by passing token=<your_token>**
Here is my exact code I used to save:
model.save_pretrained(trained_model) # Lora Adapters only saved
model.save_pretrained_merged(trained_model, tokenizer, save_method="merged_16bit")
Which I think works fine, I can see all the  files adapter_config.json, config.json, model-0001 0 004 tensors etc
But when I try to read in i, it  spews out the above error:
model, tokenizer = FastLanguageModel.from_pretrained(
    model_name=trained_model,
    max_seq_length=MAX_CONTEXT_LENGTH,
    dtype=None,
    load_in_4bit=True,
    cache_dir=CACHEDIR,
)

#THE ERROR CLAIMS THAT MODEL_NAME=NONE, BUT IT IS NOT, HERE IS PROOF:
(Pdb) print(trained_model)
unsloth/llama-3-8b-bnb-4bit
(Pdb) os.listdir(trained_model)
['model.safetensors.index.json', 'tokenizer.json', 'model-00003-of-00004.safetensors', 'special_tokens_map.json', 'generation_config.json', 'tokenizer_config.json', 'README.md', 'config.json', 'model-00001-of-00004.safetensors', 'adapter_config.json', 'model-00004-of-00004.safetensors', 'model-00002-of-00004.safetensors', 'adapter_model.safetensors']
(Pdb)

Look in adapter_config.json to see if the base_model_name_or_path points to the local model or hf model

This is resolved now. After further research I changed my parameters and it
works beautifully!
Thanks All
Really Amazing work!
On Mon, Jun 10, 2024 at 02:36 Rickard Edén @.***> wrote:

Look in adapter_config.json to see if the base_model_name_or_path points
to the local model or hf model
—
Reply to this email directly, view it on GitHub
https://github.com/unslothai/unsloth/issues/595#issuecomment-2157848297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANVUTBA6TM3WXAE2JKYVPRLZGVXSNAVCNFSM6AAAAABI3RUTUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJXHA2DQMRZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

This is resolved now. After further research I changed my parameters and it works beautifully! Thanks All Really Amazing work!
…
On Mon, Jun 10, 2024 at 02:36 Rickard Edén @.> wrote: Look in adapter_config.json to see if the base_model_name_or_path points to the local model or hf model — Reply to this email directly, view it on GitHub <#595 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVUTBA6TM3WXAE2JKYVPRLZGVXSNAVCNFSM6AAAAABI3RUTUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJXHA2DQMRZG4 . You are receiving this because you were mentioned.Message ID: @.>

Hi, how did you resolve this?


Lat controller and Lon controller sequence

Hi Apollo team,
How do these two controllers running in time, i.e. sequentially or in parallel?
If I want to run Longitudinal controller before the Lateral controller, how do I specify the sequence?
Thank you!

@wckorealsh you can change it via modifying the controller order in https://github.com/ApolloAuto/apollo/blob/master/modules/control/conf/lincoln.pb.txt

Thanks @Capri2014, Does this mean that the one comes first in the config file actually runs first?

The lateral controller controls the steering while the longitudinal controller controls throttle and braking. In fully auto mode, both commands are sent to canbus. In AUTO_STEER_ONLY mode, only steering cmd is sent to canbus. On the other hand, if in AUTO_SPEED_ONLY mode, only throttle and braking cmds are pushed to canbus.
Here is related code snippet:
  if (driving_mode_ == Chassis::COMPLETE_AUTO_DRIVE ||
      driving_mode_ == Chassis::AUTO_SPEED_ONLY) {
    Gear(control_command.gear_location());
    Throttle(control_command.throttle());
    Brake(control_command.brake());
    SetEpbBreak(control_command);
  }

  if (driving_mode_ == Chassis::COMPLETE_AUTO_DRIVE ||
      driving_mode_ == Chassis::AUTO_STEER_ONLY) {
    const double steering_rate_threshold = 1.0;
    if (control_command.steering_rate() > steering_rate_threshold) {
      Steer(control_command.steering_target(), control_command.steering_rate());
    } else {
      Steer(control_command.steering_target());
    }
  }

@jilinzhou I understand both commands are sent to canbus. My question is if they are running sequentially or not i.e. two processes (A,B)  are running in order: A->B->A->B->A->B.....

@wckorealsh yes the it is running sequentially, but not two "processes", but two "controllers".


Merge horizon 2.7.0 release branch into master

closing in favor of https://github.com/stellar/go/pull/3821


Check workflow performance

Need to ensure that we can process the expected data volume with the available memory and fast enough for Beamline.

See also scipp/essreduce#12. Note the options for growing monitors and detectors independently, as they may result in independent performance bottlenecks.

Baseline for Geant4 workflow:
2.47 seconds load_geant4_csv
4.75 seconds load_geant4_csv
3.00 seconds extract_geant4_detector_data
0.62 seconds normalize_by_proton_charge
6.11 seconds extract_geant4_detector_data
4.38 seconds add_scattering_coordinates_from_positions
0.35 seconds apply_masks
0.99 seconds normalize_by_proton_charge
4.36 seconds convert_to_dspacing
5.20 seconds add_scattering_coordinates_from_positions
0.23 seconds apply_masks
2.94 seconds convert_to_dspacing
9.75 seconds focus_data_dspacing
10.12 seconds focus_data_dspacing
1.19 seconds normalize_by_vanadium_dspacing

I artificially increased the data size by modifying the data after loading:
def extract_geant4_detector_data(
    detector: RawDetector[RunType],
) -> RawDetectorData[RunType]:
    """Extract the histogram or event data from a loaded GEANT4 detector."""
    data = extract_detector_data(detector)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)
    data = data.bins.concatenate(data)  # ~ 10 GByte (sample run)
    return RawDetectorData[RunType](data)


heroku websocket endpoint gives error

"error": "Could not connect to websocket endpoint wss://shrouded-sands-85376.herokuapp.com/. Please check if the endpoint url is correct."
My local server is running properly. I do not know how to add endpoint url. Please  provide documentation for configuration to setup the configuration for server if it is required.

prisma is in docker container. Someone mentioned heroku may haven't expose websocket to docker container that's wht subscription didn't work. I have deployed my graphql+prisma+postgres on DigitalOcean. It works well.

I dont know about it... Not quite sure how to verify... but since the heroku operates over https.. it should be open to wss.. i have tested it on heroku and it didnt work and no one has a solution. i will check with digital ocean deployment guide... thanks for info


Update the PR guidelines in Contributing docs

What does this PR do?
This updates the guidelines for the contributing docs.  They have been approved by the c-suite, proxy team, and community team.
Motivation
To make it easier for the community to understand our PR process.
More

[ ] Added/updated tests
[x] Added/updated documentation

Additional Notes

There seems to be something wrong with the spacing in lines 55-57.  I cannot figure it out.  Is it just me?

I made the changes asked. How does it look?

yep, better. thanks.


Switch to Annotated option of typer

Typer recommends the annotated option for typer applications.
It would be good to upgrade to the Annotated versions in our CLI applications.
https://github.com/render-engine/render-engine/blob/35d7c9590b0c29ff896f209e21eaeb969af258e2/src/render_engine/cli/cli.py#L147

[ ] init
[ ] build
[ ] serve

is this correct??
collection_path: Annotated[pathlib.Path, typing.Optional] = typer.Option(
       pathlib.Path("pages"),
       help="create your content folder in a custom location",
       rich_help_panel="Path Options",
   )

It's an issue with order. Typer's recommendation is correct.
I'm happy to help with some of the annotations if you want to start with init.
Happy to help more if needed.

I'm happy to help with some of the annotations if you want to start with init.

sure!!


New span parsing: Setup some example text roles

@jaapio once you are back at your keyboard, is this going in the right direction?

Yes this looks 👍
We need to introduce other spantoken types for each rule. I guess you already understood that 😁
And when looking at this, i realized that order of the rules might matter.  Because of the overlapping start characters for types of links.
Thanks for taking this effort

I am at it!

working with negative lookahead / lookbehind to prevent the roles to be misinterpreted. Order does however matter when for example a literal token contains other special chars. A literal token can contain more or less anything but its endstring

We could solve that by adding priorities to the rules and inject them in a priority queue.
So it doesn't matter in what order they are injected in the InlineMarkupRule.
Other thing to solve are escaped chars.

In the tokenization we should at least make sure not to split tokens when there are escaped whitespaces. Escape of special chars that can start or end inline markup should be solveable by lookbehind as well

Ok, so let's wrap it up and move the integration part to another PR I also moved the last two commits to #275


add webpack target configuration via angular-cli.json

Add webpack target config into angular-cli.json
Causes:
When I import electron import { ipcRenderer } from 'electron'; and run with electron ng build complete correctly but in electron renderer cause Uncaught TypeError: fs.readFileSync is not a function
Solution:
Add the webpack target configuration to electron-renderer to compile for electron renderer process
See webpack configuration target for more compile methods
Can usage the other target configuration and predefined the default when undefined in angular-cli.json
Example:
    {
      "root": "src",
      "outDir": "dist",
      "assets": [
        "assets",
        "favicon.ico"
      ],
      "index": "index.html",
      "main": "main.ts",
      "test": "test.ts",
      "tsconfig": "tsconfig.json",
      "prefix": "app",
      "mobile": false,
      "styles": [
        "styles.css"
      ],
      "scripts": [],
      "environments": {
        "source": "environments/environment.ts",
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts"
      },
      "target": "electron-renderer" <---- new property. ["web","webworker","node","async-node","node-webkit","electron","electron-renderer"]
    }```

This would probably be better served as a new CLI app "type" with custom blueprints, etc.
Although that would be a post-1.0 feature due to the need for the add-on system.

+1 for electron support
btw, angular-cli rocks!!

Closing for the same reason as https://github.com/angular/angular-cli/issues/4227#issuecomment-275548444.
Not to say we won't add it in the future, but it's just not something we're looking at for now.


File Attributes : Possible to Record Video or Audio.

File attributes as default are treated as a way to capture images with the device camera.
Using the new annotation "FileType" that can be set to IMAGE, AUDIO, VIDEO or DOCUMENT the user should be shown the audio recorder or camera (pictures or video recording)

done years ago!


Music output too loud (micro:bit)

Teachers reported concerns that the volume output is too loud for student's headphones. Recommend adding a block to set music volume.

Even without any ability to set absolute volume, a simple 'mute' would be great...

See also https://github.com/lancaster-university/microbit-dal/issues/320


Segfault when the first token is a partial

Hello,
First of all, thank you for this library. It is a great combo with the odin-http lib!
There seems to be a bug when the first token of a mustache template is a {{> partial}}.
The template below segfaults:
{{> header}}

Hello, {{name}}!

{{> footer}}

If anything is added above the {{> header}} reference (even a line break), then it works:
{{! hellope, to avoid the segfault }}
{{> header}}

Hello, {{name}}!

{{> footer}}

I'm new to Odin, otherwise I would open a PR to submit a fix for this.

@gabstv -- Could you provide more specific repro steps? On the latest main branch, I don't encounter a segfault with the following arguments (though it did reveal a separate issue with eating newlines too aggressively, which I will take a look at).
bin/odin-mustache tmp/repro.txt tmp/repro.json

tmp/repro.txt
{{> header}}

Hello, {{name}}!

{{> footer}}

tmp/repro.json
{
  "data": {
    "name": "Boris"
  },
  "partials": {
    "header": "BEGIN",
    "footer": "END"
  }
}

Output (here is separate issue can be seen with the BEGIN
...)
BEGIN
Hello, Boris!

END


Have Kustomize inject dynamic values via ConfigMap

After building many K8 clusters via Kustomize/Flux, I feel there are ways we can reduce the number of overlays for a given cluster or application.
If a base manifest can leverage reading values lets say spec.container[0].image  via configMap key/value file, it would eliminate the need for an overlay directory.
Consider creating an entire Kubernetes cluster with base manifests and then think about the overlays everytime you build a new cluster? So creating a ConfigMap with default values in base, and then ConfigMap for the new cluster or an application can simplify many complicated usecases.
I do not know if this can be handled by Kustomize or Kustomize-Controller at this point.

The Kustomize-controller has variable substitution, is this what you are looking for?


HOW TO PLOT GRAPH WITH DELAY IN EVERY POINT?

Hi,
is it possible to plot graph point by point, so that it looks like someone is drawing instead of displaying all points together?

There's no automated way to do this. However, you can simulate it by manually adding new points periodically.

Thanks! I tried few things, every time kivy window is taking a lot of time in opening. And in the end, it is displaying all the points together. I posted my code here, could anyone look at it?
def draw(self, curr_data):
    num = 0
    point_list = []
    for stroke in curr_data:

        graph = Graph(padding = 20, xmin = 500, xmax = 800, ymin = 180, ymax = 30, draw_border = True)

        plot = LinePlot(color=[1, 1, 0, 1], line_width = 2)
        #for pix in stroke:
        plot.points = stroke
        graph.add_plot(plot)
        graph.pos = 30,120
        graph.size = 400,400
        self.add_widget(graph)
        time.sleep(1.0)

Ok, yes, there are some issues with your code; mainly that it blocks the kivy thread. You need to add the points using clock callbacks. I suggest that you go through the kivy docs and demos to understand how kivy's arch functions. Also, for direct help you should join us on #kivy on IRC. It's difficult to do this over github issues.


Focus los after Firebase initialization

I am working on a webapp for ios. If I set a focus to a specific input it works well. But if firebase is initialized (firebase.initializeApp()), the focus is lost. Is there any reason / workaround for that behaviour?

@scriptPilot we'll investigate this, although, as a workaround could you set the focus on the element just after you've done the firebase.initializeApp()?

Hello Nicolas, thank you for taking attention to that behaviour.
In my setup (Framework7 one page application) the app is loaded each time again due to the behaviour of iOS with webapps (linked on homescreen). Because the firebase init takes some seconds my workaround is to save the database for the initial load in the local storage. Maybe I do something wrong that firebase is not initialized immediately?

hey @scriptPilot, Would you have that app online already? (or downloadable)? I have an iPhone I can test with so I can have a quick look.

Closing for now because the post seems stale but feel free to re-open if you still have the issue.


Strange issue with round() function used in CUDA kernel

Hi, I recognize that this function probably shouldn't be used to such a large number of decimal places, but it's still strange that it gives different behavior than the vanilla python function.
import numpy as np
from numba import cuda

@cuda.jit()
def test_kernel(x):
    #set single value in array to the result of round(2e-5, 25), as computed on the GPU
    x[0] = round(2e-5, 25)

x = np.array([2e-5], np.float32)
print("CPU result:"+str(round(x[0], 25)))
test_kernel[1,1](x)
print("GPU result:"+str(x[0]))

CPU result:2e-05
GPU result:9.223372e-07
The only clue that seems apparent is that 9.223e18 is MAX_LONG, and the result just so happens to be 25 orders of magnitude lower. Indeed, attempting to round to e.g. 26 decimal places gives 9.223372e-08 on the GPU. Wonder what's happening...

I think this will be some error in our implementation of the round() function that CUDA uses:
https://github.com/numba/numba/blob/d2af79a790e4c7666231006f314af13beac060a3/numba/cuda/cudaimpl.py#L636-L676