Feature Request: support BigInt serialization in segment metadata

Expected Behaviour
When I add metadata to my trace, I expect the tracer to handle any data I send to it without causing the lambda to crash.
Current Behaviour
It crashes the lambda when I use putMetadata to add a data structure that contains a BigInt or any other format that JSON.stringify cannot encode.
Code snippet
import middy from '@middy/core';
import { Tracer, captureLambdaHandler } from '@aws-lambda-powertools/tracer';

const tracer = new Tracer({ serviceName: 'stream-handler-test' });

export const handler = middy(async (_event) => {
  console.log('1. Call someLogic.doSomething()');
  const response = await someLogic.doSomething();

  console.log('2. Add the response to the trace metadata');

  // Add the response to the trace, so we can see it in the observability
  // platform in case anything goes wrong.
  //
  // This is a very common pattern for me. I don't usually think about
  // what's in the response unless the data is likely to be giant or
  // contains sensitive information in it. It just so happens that
  // this response contains a BigInt, and that's enough to cause the
  // lambda to crash.
  tracer.putMetadata('response', response);

  console.log('3. Return a response from the handler');

  return `Here is a number: ${response.number}`;
}).use(captureLambdaHandler(tracer));

class SomeLogic {
  async doSomething() {
    return {
      number: 1234n,
    };
  }
}

const someLogic = new SomeLogic();

Steps to Reproduce

Bundle and install the script above in an AWS Lambda function with tracing enabled.
Run the function from the AWS Lambda console.

Possible Solution
I think there are two factors to consider.

We should make an effort to encode the types putMetadata receives when JSON.stringify cannot handle them - perhaps we can use a replacer function to encode exotic types.
Even if the tracer fails to encode, I don't think it should ever crash the lambda. Perhaps the tracer should be swallowing all exceptions so it doesn't affect the user's code when something goes wrong.

Powertools for AWS Lambda (TypeScript) version
latest
AWS Lambda function runtime
16.x
Packaging format used
npm
Execution logs
START RequestId: c879e6a8-5a2f-4e1b-9240-7dfce8c41719 Version: $LATEST
2023-09-26T17:29:22.684Z	c879e6a8-5a2f-4e1b-9240-7dfce8c41719	INFO	1. Call someLogic.doSomething()
2023-09-26T17:29:22.704Z	c879e6a8-5a2f-4e1b-9240-7dfce8c41719	INFO	2. Add the response to the trace metadata
2023-09-26T17:29:22.704Z	c879e6a8-5a2f-4e1b-9240-7dfce8c41719	INFO	3. Return a response from the handler
2023-09-26T17:29:22.765Z	c879e6a8-5a2f-4e1b-9240-7dfce8c41719	ERROR	Invoke Error 	{"errorType":"TypeError","errorMessage":"Do not know how to serialize a BigInt","originalError":{"errorType":"TypeError","errorMessage":"Do not know how to serialize a BigInt","stack":["TypeError: Do not know how to serialize a BigInt","    at JSON.stringify (<anonymous>)","    at Subsegment.format (/var/task/index.js:2103:19)","    at Object.send (/var/task/index.js:1434:33)","    at Subsegment.flush (/var/task/index.js:2073:26)","    at Subsegment.streamSubsegments (/var/task/index.js:2083:14)","    at Subsegment.close (/var/task/index.js:2046:18)","    at close (/var/task/index.js:9565:24)","    at captureLambdaHandlerAfter (/var/task/index.js:9581:11)","    at runMiddlewares (/var/task/index.js:9799:23)","    at runRequest (/var/task/index.js:9775:13)"]},"stack":["TypeError: Do not know how to serialize a BigInt","    at JSON.stringify (<anonymous>)","    at Subsegment.format (/var/task/index.js:2103:19)","    at Object.send (/var/task/index.js:1434:33)","    at Subsegment.flush (/var/task/index.js:2073:26)","    at Subsegment.streamSubsegments (/var/task/index.js:2083:14)","    at Subsegment.close (/var/task/index.js:2046:18)","    at close (/var/task/index.js:9565:24)","    at captureLambdaHandlerError (/var/task/index.js:9587:11)","    at runMiddlewares (/var/task/index.js:9799:23)","    at runRequest (/var/task/index.js:9782:13)"]}
END RequestId: c879e6a8-5a2f-4e1b-9240-7dfce8c41719
REPORT RequestId: c879e6a8-5a2f-4e1b-9240-7dfce8c41719	Duration: 139.59 ms	Billed Duration: 140 ms	Memory Size: 128 MB	Max Memory Used: 63 MB	Init Duration: 199.81 ms
XRAY TraceId: 1-651314f2-6e1cb4753036f8091d8a133e	SegmentId:<PHONE_NUMBER>412fd8	Sampled: true

This issue came from Twitter. https://twitter.com/heitor_lessa/status/1706563622694981916

Hi @misterjoshua thanks for taking the time to open the issue.
As you have correctly pointed out , the JSON.stringify() function doesn't know how to serialize the BigInt and so it crashes. Based on this I'd be more inclined in considering this a feature request given that the behavior observed is idiomatic to the language/runtime.
With that said, I do agree that we should do something about this, so I propose a two steps approach:
Step 1
Add an internal try/catch logic to the putMetadata() method so that in case the SDK throws an error, we catch it and log a warning.
This is a change that we can do right away and that we should do regardless of the serialization discussion.
Step 2
Add support for BigInt objects. The change is relatively simple if made on the X-Ray SDK side, however if made on the Powertools side it requires a more roundabout way given that the SDK implementation doesn't extract the serialization in its own method. For this reason we would have to essentially provide a new implementation for two methods of the Segment object.
I'd like to avoid this option if possible since it'll mean we'll have to make sure our implementation doesn't go out of sync with theirs, so for this reason I have opened an issue on the X-Ray SDK repo and offered to contribute a fix: aws/aws-xray-sdk-node#616.
To PoC the fix, I was able write this passing test:
it('handles BigInt types when adding metadata to a segment', () => {
  const segment = new Subsegment('## foo.bar');

  segment.addMetadata('foo', {
    bar: BigInt(123),
  });

  (
    segment as Subsegment & {
      type: string;
      parent_id: string;
      trace_id: string;
    }
  ).format = function format() {
    this.type = 'subsegment';
    if (this.parent) {
      this.parent_id = this.parent.id;
    }
    if (this.segment) {
      this.trace_id = this.segment.trace_id;
    }

    return JSON.stringify(this, (_, value) => {
      if (typeof value === 'bigint') {
        return value.toString();
      }

      return value;
    });
  };
  segment.toString = function toString() {
    return JSON.stringify(this, (_, value) => {
      if (typeof value === 'bigint') {
        return value.toString();
      }

      return value;
    });
  };

  expect(segment).toEqual(
    expect.objectContaining({
      metadata: {
        default: {
          foo: {
            bar: 123n,
          },
        },
      },
    })
  );
});

As mentioned I'll open a PR for the first step and try to include it in the next release that should go out today/tomorrow at the latest. In the meanwhile, we'll give some time to the X-Ray SDK folks to review my issue and reply.
We'll keep monitoring the progress of that issue and hopefully contribute a PR; however if things take too long we'll reconsider implementing the change on our side either temporarily or permanently.

The PR (#1716) that introduces the try/catch logic has been merged. Ultimately we ended up going in a slightly different direction than the one anticipated. Specifically we didn't add the try/catch to the putMetadata() method but instead we added it to our decorators and middleware.
The reason why we went this way is that after debugging the error and following the stack trace, we noticed that the error described in your issue is thrown only when a segment is emitted, specifically when its serialized, and not when the data is added to the segment. Adding the try/catch logic to the putMetadata() method wouldn't have helped mitigating this.
So we have added try/catch in those places where we call segment.close() on segments that we opened, namely the @captureMethod() and @captureLambdaHandler() decorators and the captureLambdaHandler() Middy middleware.
Unfortunately, until X-Ray merges the fix we are proposing, calling segment.close() on a segment directly will still throw an error.
At the time of writing, we are still waiting on the X-Ray team for the issue we've opened so I'm leaving the issue open and changing its state to status/blocked. I'll report back here once there's movement.

I just wanted to report that I have managed to get through the X-Ray team and we have agreed on a fix. I'll be opening a PR in their repo in the next few days.

The PR is up: https://github.com/aws/aws-xray-sdk-node/pull/619

The PR is up: aws/aws-xray-sdk-node#619

Thanks, Andrea. I pulled down a local copy, tested it, and left a small review.

@dreamorosi Looks like The X-Ray SDK for Node released the BigInt serialization change in v3.5.3.
I updated my personal reproduction to<EMAIL_ADDRESS><EMAIL_ADDRESS>After re-running the lambda, my trace now contains the bigint.

So, I think we're done here unless you can think of anything else?

Hi @misterjoshua thanks for reporting back on the topic.
I'll bump the version of the X-Ray SDK in the Tracer dependencies to the latest and close the issue.


Cache searchbar options in Redis rather than Heap memory

Currently just store the valid options in the 'augur' object, would decrease memory footprint if options were in Redis for all running processes.
Would also allow the options to be updated periodically w/o restart.

not going to do this


feat(Deps): updates to the EDC snapshot and implements a version catalog

WHAT
Updates the EDC version to 0.0.1-SNAPSHOT and implements a version catalog
The version catalog per components follows the DR in the upstream EDC
WHY
Update needed for #257
Closes #266

Does it perhaps make sense to create a DR beforehand that describes how the version catalog will benefit the project?

What are preview branches? Is it something like a release candidate?

@ndr-brt  that's only for now, for tracking the latest changes on protocol/api level.
we will move to nightly o release once it's stabilized

@florianrusch-zf  for the DR the version catalog for components follows the upstream DR
https://github.com/eclipse-edc/Connector/tree/main/docs/developer/decision-records/2023-03-31-version-catalog-per-component
I will add this to the description
For the branch it's a custom temporary branch for tracking the latest changes in upstream EDC and the new protocol

@ndr-brt that's only for now, for tracking the latest changes on protocol/api level. we will move to nightly o release once it's stabilized

there's a freshly baked 0.0.1-20230426-SNAPSHOT :bread:


GitHub registry

This PR

replaces Docker Hub with the GitHub registry in the GitHub workflow and updates the used GitHub actions
temporarily disables the PlanQK Service integration test as it's not compatible anymore with the platforms' authentication

Needed for https://github.com/OpenTOSCA/opentosca-docker/pull/57

Could you please check why the build fails?

I think the GitHub secret that contains the API token for codacy is empty because this is a PR from a fork:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

Could you move it to a branch here then? Or any other idea?

I changed the base branch of this PR to a new branch. We can merge it in this new branch, then I will make a new PR.


Regex constraints don't accept multiple ranges in a character class

com.amazon.ionschema.InvalidSchemaException: unexpected character '0' in regex '^[A-Z0-9]{10}' at offset 5
	at com.amazon.ionschema.internal.constraint.Regex.error(Regex.kt:205) ~[Maven-com-amazon-ion_ion-schema-kotlin-1.x.jar:?]
	at com.amazon.ionschema.internal.constraint.Regex.parseCharacterClass(Regex.kt:143) ~[Maven-com-amazon-ion_ion-schema-kotlin-1.x.jar:?]
	at com.amazon.ionschema.internal.constraint.Regex.toPattern(Regex.kt:88) ~[Maven-com-amazon-ion_ion-schema-kotlin-1.x.jar:?]
	at com.amazon.ionschema.internal.constraint.Regex.<init>(Regex.kt:58) ~[Maven-com-amazon-ion_ion-schema-kotlin-1.x.jar:?]

According to the Ion Schema Specification, regex constraints conform to ECMA-262 -- it specifically links to the regular expression literal grammar.
The semantics of that literal is defined to be the same as the RegExp constructor, which accepts a Pattern, which permits multiple ranges in one character class.  However, I found this test case in IonSchema which suggests IonSchema consider this not to be valid.
I'm curious about the reasoning here -- multiple ranges in one character class is a common use case in regexes (e.g. [a-zA-Z0-9]).

The reasoning was for implementation simplicity for the time being, and perhaps that was a poor decision on my part.  I agree that support for multiple ranges should be added.
Apologies for the inconvenience.  In the meantime, one_of (or any_of) enables the use case you describe:
one_of: [
  { regex: "a-z" },
  { regex: "A-Z" },
  { regex: "0-9" },
]

The case I gave above is slightly simplified from the actual problem we encountered with a regex like ^[a-zA-Z0-9]{10}$ -- I'm not sure the one_of workaround is usable in that case, but I think this regex is rewritable as ^([a-z]|[A-Z]|[0-9])+$ (although I haven't tried it).
Thanks for the context.

Agreed, your approach to rewriting the regex is cleaner and all-around better.  :)

I upgraded the IonSchema in my project from 0.7 to 1.x and the regex that I have defined before are having the same issue described above.
is 1.x upgrade not backward compatible?


Added error logging

Hi, I've added error logging, unfortunately my VSCode formatting doesn't match yours, and the overall indentation was changed.

That's okay! I typically just use Deno to format. If you've got it installed, run deno fmt. If not, I can take care of it in a later push before publishing the module.

I've merged the pull request. I had to manually upgrade the version in the package.json for whatever reason, but it works now. That and put Elysia back to lowercase since. Overall, a fantastic update. I need to do some testing to make sure it works as expected but then it'll get published as the 0.3 release!
Thank you for taking the time to contribute to Logysia. It means a lot!


How to run camlp4 and cppo?

Best idea I have is adding a -camlp4 option to cppo, then making cppo write its output to a file, and pass that to camlp4 which just writes to stdout?
Then it would be trivial to use cppo and camlp4 and pass it to ocaml* by -pp ?
http://batteries.forge.ocamlcore.org/doc.preview:batteries-beta1/html/api/File.html
mentions a withtempfile like command. Would it be ok to add a dependency to extlib?
I didn't find a cross platform way to spawn a process and feed data through it in a timely manner (I'm still new to ocaml)

A correct script would be more like:
#! /bin/sh
set -e
cppo "$@" | camlp4o

I don't think it should be program's responsibility to reimplement pipe syntax.
If the OS supports process forking and pipes, I'm pretty sure it has a Bourne Shell implementation as well. If not, some scripting language and a temporary file between cppo and camlp4 should do.


Removing/Adding from EntityCollection doesn't work with events suspended

In KmlDataSource.js when a NetworkLink is refreshed we remove old entities, then add new entities. We need to resumeEvents() then suspendEvents() in between the removes and adds or the entities don't update.
You can see the code here: https://github.com/AnalyticalGraphicsInc/cesium/pull/3538#discussion-diff-52938624R2420
I discovered this using the document https://github.com/tfili/geospatial-tools/blob/master/kmlServer/kml/nwl-interval.kml
This document refreshes a point's position by using a server that just moves a point every few seconds. The server can be found at https://github.com/tfili/geospatial-tools/tree/master/kmlServer.

Also reported here with CZML:
https://groups.google.com/d/msg/cesium-dev/ngaaX0Hzy88/wyOnoa9FAQAJ
using sandcastle:
http://localhost:8080/Apps/Sandcastle/?src=Hello World.html&label=Showcases&gist=e68e5fa9bf8522039de6ba10e0591d83
The point does not change to reflect the new color.
This is because the PointVisualizer never receives the event to clear the collection because events are suspended, so it never updates its cache.
The entity is put into the removed list after the clear, but then it is removed from the removed list when it's re-added by load.  The result is no event is fired.

Hey y'all, I'm pretty sure I'm getting bitten by this in my own application.  It's not KML but I do add entities to a collection, get updates from a server, then suspend the collection, remove old "versions" of an entity and re-add them with updated data, then resume.  In the debugger, I can see that when resumeEvents calls fireChangedEvent, all three arrays (_added, _removed, _changed) are empty.
I think the problem is that add-ing a pending-removed Entity takes it out of _removed and does not put it in _added but also does not put it in _changed.  I'm not sure who subscribes to the collectionChanged event so I don't know what is done with the three arrays of entities (added/removed/changed), but I'm confident that a removed-then-added entity should appear in at least one of them.  My instinct is to change the line I linked from
  if (!this._removedEntities.remove(id)) {
    this._addedEntities.set(id, entity);
  }

to
  if (this._removedEntities.remove(id)) {
    this._changedEntities.set(id, entity);
  } else {
    this._addedEntities.set(id, entity);
  }

If this is the right approach, I can put in a PR.

Hey y'all, I'm pretty sure I'm getting bitten by this in my own application.  It's not KML but I do add entities to a collection, get updates from a server, then suspend the collection, remove old "versions" of an entity and re-add them with updated data, then resume.  In the debugger, I can see that when resumeEvents calls fireChangedEvent, all three arrays (_added, _removed, _changed) are empty.
I think the problem is that add-ing a pending-removed Entity takes it out of _removed and does not put it in _added but also does not put it in _changed.  I'm not sure who subscribes to the collectionChanged event so I don't know what is done with the three arrays of entities (added/removed/changed), but I'm confident that a removed-then-added entity should appear in at least one of them.  My instinct is to change the line I linked from
  if (!this._removedEntities.remove(id)) {
    this._addedEntities.set(id, entity);
  }

to
  if (this._removedEntities.remove(id)) {
    this._changedEntities.set(id, entity);
  } else {
    this._addedEntities.set(id, entity);
  }

If this is the right approach, I can put in a PR.

Hrm, I made that change locally and it does not fix the behavior I was seeing.
For example, if you remove then re-add the currently selected entity in a Viewer, viewer.selectedEntity will point to the old (removed) version, which is no longer owned by any Collection.  Viewer listens to the collectionChanged event and un-selects the entity (selectedEntity = undefined) if it's in the removed collection, but that never happens.
I put together a Sandcastle example that illustrates the problem.  It draws a billboard with a fixed ID.  Then, you click "move down" several times.  It removes the billboard then adds it again, one degree south.  But the old (removed) entity is still drawn, and the new one isn't.  Note also that if you select this "abandoned" entity, it thinks it's owned by the defaultDataSource, but it actually isn't in its collection.
I may try to dig deeper on this tomorrow, but I'm feeling a little out of my depth.  Maybe somebody on the team has more insight?  If I can't crack it myself, I may have to resort to (suspend, remove N, resume, suspend, add N, resume) but I'd rather avoid that if possible.

Hrm, I made that change locally and it does not fix the behavior I was seeing.
For example, if you remove then re-add the currently selected entity in a Viewer, viewer.selectedEntity will point to the old (removed) version, which is no longer owned by any Collection.  Viewer listens to the collectionChanged event and un-selects the entity (selectedEntity = undefined) if it's in the removed collection, but that never happens.
I put together a Sandcastle example that illustrates the problem.  It draws a billboard with a fixed ID.  Then, you click "move down" several times.  It removes the billboard then adds it again, one degree south.  But the old (removed) entity is still drawn, and the new one isn't.  Note also that if you select this "abandoned" entity, it thinks it's owned by the defaultDataSource, but it actually isn't in its collection.
I may try to dig deeper on this tomorrow, but I'm feeling a little out of my depth.  Maybe somebody on the team has more insight?  If I can't crack it myself, I may have to resort to (suspend, remove N, resume, suspend, add N, resume) but I'd rather avoid that if possible.

I haven't spent as much time digging around in your codebase as I'd like, but it's starting to look like maybe we should just say that removing an entity, then adding one with the same ID, inside of a suspend/resume pair, just isn't supported.  I don't think Cesium has the vocabulary to handle it, the way it's written today.
The most accurate thing would be to populate both added and removed, because this instance of the Entity with ID "X" hasn't actually changed, one instance was removed, then a different instance added.  (This is important, because observers might have kept a reference to the entity, and fail to update the reference to the "new X" Entity.)  Initially I was worried that there would be an order of operations problem -- how would you distinguish add-then-remove from remove-then add? -- but if you think about it, add-then-remove is effectively a no-op and shouldn't generate any event.  So, you'd just have to always process removed before added.  But that would mean reviewing every piece of code that watches for collectionChanged to validate (and test) that it does so.
Does that make sense?  Is the code wrong, or do the rules around suspendEvents need to change?

I haven't spent as much time digging around in your codebase as I'd like, but it's starting to look like maybe we should just say that removing an entity, then adding one with the same ID, inside of a suspend/resume pair, just isn't supported.  I don't think Cesium has the vocabulary to handle it, the way it's written today.
The most accurate thing would be to populate both added and removed, because this instance of the Entity with ID "X" hasn't actually changed, one instance was removed, then a different instance added.  (This is important, because observers might have kept a reference to the entity, and fail to update the reference to the "new X" Entity.)  Initially I was worried that there would be an order of operations problem -- how would you distinguish add-then-remove from remove-then add? -- but if you think about it, add-then-remove is effectively a no-op and shouldn't generate any event.  So, you'd just have to always process removed before added.  But that would mean reviewing every piece of code that watches for collectionChanged to validate (and test) that it does so.
Does that make sense?  Is the code wrong, or do the rules around suspendEvents need to change?


This package misbehaves in Windows systems

Hi there, thanks in advance for this great package. I have encountered an issue where pressing default key combination (here Ctrl + K) also focuses browsers (tested in Chrome, Edge and Firefox) address bar with search.

@onderbakirtas thanks for bringing this to my attention. I didn't test aggressively on windows system since I don't own one. Need to find a way to do this. I'll post updates.
Also, please feel free to suggest any approaches that you think can help.
Thanks!

This should be fixed by now, can you please confirm once?

This should be fixed by now, can you please confirm once?

I will do it when I get my hands on the computer.

@onderbakirtas were you able to test?

@onderbakirtas were you able to test?

Yes I was, it was fine and working as intended. Thanks.


Cyclon exchange_view() should not return back to the source a partialView containing the source's ip

In cyclon/app.py the following piece of code is wrong.
source = message.get('source')
size = received_partial_view.size
to_avoid = None
if cyclon.partialView.contains_ip(source):
    to_avoid = cyclon.partialView.get_peer_by_ip(source)
to_send = cyclon.partialView.select_neighbors(to_avoid, size)

In fact, source is in the form http://<source_ip>:<port> while both cyclon.partialView.contains_ip and cyclon.partialView.get_peer_by_ip expect an IP. Hence, to_avoid value was alway None.

The code is not needed anymore cause cyclon returns a random subset of descriptors no matter if the source ip is included or not.


BUG: Compensation channels pick error

While trying to execute evoked.interpolate_bads(), I ran into the following error:
  mne\channels\interpolation.py", line 190, in _interpolate_bads_meg
    info_to = pick_info(inst.info, picks_bad)

  mne\io\pick.py", line 411, in pick_info
    'channels' % (current_comp, comps_missing))

RuntimeError: Compensation grade 3 has been applied, but compensation channels are missing: ['BG1-2805', 'BG2-2805', 'BG3-2805', 'G11-2805', 'G12-2805', 'G13-2805', 'G22-2805', 'G23-2805', 'P11-2805', 'P13-2805', 'Q11-2805', 'Q13-2805', 'R11-2805', 'R12-2805', 'R13-2805', 'R22-2805', 'R23-2805']
Either remove compensation or pick compensation channels

This error seems to be raised automatically when attempting to make any pick that does not include all ref_meg channels. I dug a bit into compensation grades, and it seems that it can only be removed for Raw data using the apply_gradient_compensation(0) method.
Maybe it would be better to turn this error into a warning? Indeed in my case, compensation channels are not removed from data, the function only attempts to separately pick bad channels to compute interpolation.
Another way could be to always include these channels, similar to the ref_meg='auto' argument of pick_types(), but I'm not sure it would make sense in every case (especially this one).
Thanks,

Indeed this should probably not be an error, see our current plan for fixing these sorts of issues here.
Although for the case of interpolate_bads, I'm not sure what the right thing to do would be -- maybe we should go back to grade 0, interpolate, then re-apply whatever compensation was there originally. @bloyl @agramfort any ideas on this one?

I just tried to run my source reconstruction scripts, and it turns out this bug is everywhere (evoked.plot_joint, beamformer.make_lcmv), nothing works anymore since I upgraded from v0.15 to v0.16 last week.

Oof, that's not good. While we work on a proper fix, you could turn it into a warnings.warn in your local copy of the MNE code

could be related to https://github.com/mne-tools/mne-python/pull/5295
can you share a gist. We'll fix ASAP.
we need more MNE developers with CTF data...

@Heneark #5295 has been merged. Can you provide some test snippet so we can fix ASAP and release 0.16.2
thanks

I downloaded the master branch, evoked.plot_joint() is indeed fixed.
Here's a test snippet for the interpolation error:
https://gist.github.com/Heneark/2e18280f88f956ae5faef3cea40e4bd0
Same error with beamformer:
filters = mne.beamformer.make_lcmv(evoked[k].info, fwd_surf, data_cov, noise_cov=noise_cov, pick_ori='vector')
Traceback (most recent call last):

  File "mne/beamformer/_lcmv.py", line 137, in make_lcmv
    _check_one_ch_type(info, picks, noise_cov)

  File "mne/beamformer/_compute_beamformer.py", line 119, in _check_one_ch_type
    info_pick = pick_info(info, sel=picks)

  File "mne/io/pick.py", line 408, in pick_info
    'channels' % (current_comp, comps_missing))

RuntimeError: Compensation grade 3 has been applied, but compensation channels are missing: ['BG1-2805', 'BG2-2805', 'BG3-2805', 'G11-2805', 'G12-2805', 'G13-2805', 'G22-2805', 'G23-2805', 'P11-2805', 'P13-2805', 'Q11-2805', 'Q13-2805', 'R11-2805', 'R12-2805', 'R13-2805', 'R22-2805', 'R23-2805']
Either remove compensation or pick compensation channels

Cheers,

have a look https://github.com/mne-tools/mne-python/pull/5321
it's not finished though.

@Heneark it should be fixed now. I also pushed a new version 0.16.2 to pypi.
you can do:
pip install -U mne
and hopefully everything should now work smoothly.
thanks for reporting the issue and your patience.

I upgraded to mne 0.16.2, plot_joint() is fixed, interpolate_bads() is fixed, but pick_types(ref_meg=False) still raises an error, thus the error from beamformer.make_lcmv() still occurs.
@agramfort Should I open another issue?

had you a opened a dedicated issue with this last issue with a code snippet
I can replicate?

I think you meant to link here
https://gist.github.com/Heneark/a183a24218302831860efc86c84c1950
Thanks for making it. We want to fix the problem generally, but the best solution will take some time. In the meantime it's quicker to squash the bugs one by one.

Hello there
I'm having the same problem with the 0.16.2 version. I cannot pick_types(ref_meg=False) without gettting the same error as in the top post , and if I then pick_types(ref_meg=True), beamformer.make_lcmv will raise the error instead. Could beamformer.make_lcmv be issuing the error because the number of channels in info and forward arguments are different (since forward will not include the compensation channels)? I don't want to change the compensation grade, so what I have been doing is to set info['comps']=[] and it works, but it is a hack.
Any ideas? Thanks!

you will need to wait for the next release or switch to using the current
development version.
See https://github.com/mne-tools/mne-python#get-the-latest-code


functionList.xml for markdown files

This is a feature request. It would be useful if the functionList.xml is created for markdown files. If headings is regarded as functions then it would be easy to navigate between them.

See Notepad++ GitHub issue 5945 and Community topic 18458.


Appstudio update hacbs-test-project-icsi

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-icsi-on-pull-request-
creating pipelinerun hacbs-test-project-icsi-on-pull-request- in namespace rhtap-demo-dhsg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


CTD 693 update connectd readme and auto install to point at new method

connectd package is deprecated.  These changes update the readme.md at Github to point to the new instructions.  The auto-install.sh is also modified to show this information when it first starts, and then asks the user to press a key to continue, meaning they have an opportunity to read the note.

CI is broken at this time.  Please review the changes visually.


unexpected status code: 400

The error often occurs: "unexpected status code: 400"

i confirm. happens on my side as well.

I can also confirm, error popups for random videos

Issue appears to be related to https://github.com/yt-dlp/yt-dlp/issues/9316

Seeing the same issue, I manually applied @ppalone fix into my own project and I do not see the 400 error.

yes, changing the version in client.go fixes the 400 issues.

@natxo can you elaborate, please? What version fixes it?

Hi @kkdai,
I applied the change mentioned in https://github.com/kkdai/youtube/pull/322/files manually and it fixed the issue for me as well.
I just retested, reverting the changes has my script return a 400 from youtube.
Thanks for your support.
Regards,
Natxo
-----Oorspronkelijk bericht-----
Van:Chigozirim Igweamaka @.>
Verzonden:zo 10-03-2024 15:47
Onderwerp:Re: [kkdai/youtube] unexpected status code: 400 (Issue #320)
Aan:kkdai/youtube @.>;
CC:Natxo Asenjo @.>; Mention @.>;

@natxo can you elaborate, please? What version fixes it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


About how to reproduce the paper.

Dear authors,
Thanks for your nice work. The project is nice. Congrats for your work!
I wish to reproduce your work, but I meet two problems here. Hoping to get your notice and reply.

Could you please give detailed guidance on how to preprocess our own data?

README doesn't seem to detail how to split the train and test data.
The original paper seems to say only pure test-time optimization is needed.
So, if I wish to do an evaluation, do I only need to run directly with the test data?

The README only gives how to inference.

But no quantitative evaluation code is given(If I haven't missed it).
If that's convenient, could you please offer guidance to reproduce the quantitative results in the paper's table?
Thank you in advance!
Best,
Jingwei

For question 1, I wish to additionally ask that:
As is mentioned in paper:

While using neural methods, INR is a pure test-time optimization.

So, do we only need to make the inference on each input file? Am I right?
Thank you!

No reply, closed.


Added Python 3 Compatibility

Python 3 compatibility is implemented by removing has_key and using __future__ for print function support. Also added ImageMagick as a requirement in README.md (since the convert command is part of ImageMagick).

Thanks! 2 minor changes before accepting PR: I spell it "writeup" in my other 5 repos, so would like to preserve that spelling to maintain consistency across them. Also, printing out the results of the postprocessing command got a bit muddled in the transition to print_function.
I hope the attached patch applies easily so you can see what I'm talking about.
patch.txt

@mzucker, I Applied the Patch.

Merged!


Add support for compiling C++ version (with cmake)

Update #1
This is not fully complete yet. Support for the unit tests is missing for now, and only building a static library is supported.
To build:
mkdir build
cd build
cmake ..
make

Thanks! This looks like a good start.
I successfully built the project using cmake and make/ninja:
make -j8  58,73s user 7,45s system 455% cpu 14,516 total
ninja  74,28s user 6,96s system 1054% cpu 7,701 total

Can you make sure to include any changes that have landed in google3 since you started this PR? Could be done in a separate PR, too :)


[Enhancement] Make the FAQ page better

Deliverable:

[ ] Fix the design of FAQ page

@amanprateek123 can you please claim this?

@amanprateek123 can you please claim this?

Ok got it! @Kajol-Kumari

Ok got it! @Kajol-Kumari


Issue with Access-Control-Allow-Origin when using API Key signatures

I'm trying to do a simple https://api.meetup.com/find/events/ request with a signed API Key. Even using the Signed Url request from the Meetup API Console results in the Access-Control-Allow-Origin error. EDIT: I think I'm using API v3
I am using the request npm package to construct my request.
import qs from "querystring";
import request from "request";

// bunch of codes

/*
  where the filter object is simply:
      var filter = {
      text: "Australia"
    };
*/
MeetupEvents = (filter, callback) => {
  console.log("Meetup");
  let muKey = "superSecretMeetupKey";
  let muEventSearchUrl = "https://api.meetup.com/find/events";
  var events, cleanResults;
  let apiUri = muEventSearchUrl +
    "?&sign=true&key=" +
    muKey +
    "&photo-host=public&" +
    qs.stringify(filter);

  // make request
  request(apiUri, (err, res) => {
    events = JSON.parse(res.body).events;
    cleanResults = events.map(event => {
      return {
        name: event.name,
        id: event.id,
        url: event.link,
        start: event.time
      };
    });
    callback(err, res, cleanResults);
  });
};

The final constructed query that the Chrome console errors on is the following:
 https://api.meetup.com/find/events?&sign=true&key=superSecretMeetupKey&photo-host=public&text=Australia
Finally the full error from Chrome devtools console is:
Fetch API cannot load https://api.meetup.com/find/events?&sign=true&key=superSecretMeetupKey&photo-host=public&text=Australia. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'MY STATIC WEBSITE' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
However I was under the impression I would not have CORS errors when doing a signed api call.
Please advise :sweat_smile:

I have a similar problem that seems to have started in the past month with 2/profiles

same problem. any obvious workaround except using a proxy?

I haven't come across any workarounds myself.

(I commented above last month) FWIW, I ended up working around the problem I was having with the v2 profiles (2/profiles) API by switching to using the v3 profiles (/:urlname/members) API.

closing this issue. We go not support CORS requests for anything but oauth authenticated requests. We use the redirect_uri of the oauth client to match the browser provided Origin header. For key signed requests we support jsonp for HTTP GET requests.


Fix warning silencer crashes when receiving DeprecationWarning objects

Issue #, if available: N/A
Description of changes:  unbreak some cases where _warn() receives non-string objects such as DeprecationWarning objects.
Testing done: done
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're
unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of
what we are going to look for before merging your pull request.

[x] I have read the CONTRIBUTING document.
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[x] I have updated any necessary documentation, including README and docs (if appropriate).

By submitting this pull request, I confirm that my contribution is made under the terms of the
Apache 2.0 license.

LGTM, despite pandas-1.5.0 breaks mypy checks.


WARNING api error:  (error 602)

I receive this error
▶ WARNING api error:  (error 602) [tags:ENG=339nVQbossZg]
▶ ERROR  (code 602)
when trying to follow or track anyone in keybase. I also can not follow users on the app
my log id: 3d3001df603b53df1722ce1c

What does keybase -d version show?


disable progress spinners in ci-mode

This disables execution of spinners on the backup command when using ci-mode

E2E: https://got-testrail.agi.appgate.com/index.php?/plans/view/1026054


dpdk: update compile instructions to use meson, mention Debian cloud kernel image

@bluca : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@bluca: I'm sorry - only the author of this article, @laxmanrb, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@bluca : Thanks for your contribution! The author(s) have been notified to review your proposed change. @shemminger

@shemminger I've changed the owner of this doc to be you, so that we can unblock updates - can you please comment #sign-off here so that the bot is happy? Thanks

@laxmanrb - can you review this ? thanks.

@laxmanrb - can you review this ? thanks.

@Jak-MS Laxmana is no longer in the network/dpdk team

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bluca - i reviewed the PR and we'll merge this... for future updates of more than a few lines, including new content, you'll need to use the private repo - azure-docs-pr .   We can't change the author in the public repo... and Laxmana is still at the company so that will need to be changed in a different pr.

if you need to make small changes in this repo in the future, you can always email the techdocprs  alias and request a merge. thanks!

thanks!

@Jak-MS I cannot access https://github.com/MicrosoftDocs/azure-docs-pr/ - could you please take care of switching the author of this doc?


Able to create an advancement entry for QOL Improvements in single player worlds but not on the server.

The console states:
[28-Aug-2019 23:21:14] [ERROR] Failed to reload data packs
[28-Aug-2019 23:21:14] java.util.concurrent.ExecutionException: n: Non [a-z0-9/._-] character in path of location: main:advancements/main/QOL.json
Temp fix: have removed for TBP release but would like to add still to be on par with other datapacks.

Added as separate datapack. Crafting recipe datapacks don't handle the advancement class very well.


Occasionally missing Accessibility Label

Issue type
Incorrect behavior
Description of the problem
In Voice Over, the a11y label of the entire Video, which reads "Video, zweimal tippen um Bedienelemente anzuzeigen." doesn't always get read out. In random cases, it just reads "Video".
Environment information

The simulator is a valid device as well. If all versions or devices seem to be affected, simply enter 'Any'

Library version: 8.0.0
iOS 15.5
Device: iPhone 13 Pro Max

Reproducibility
Not always reproducible.
Steps to reproduce
Focus the Video in Voice Over.

Hi.
Thanks for your report and sorry for the late reply. I'll have a look, as this issue can quite easily be reproduced with VoiceOver enabled:

Focus on the video. The accessibility hint is provided (double tap action).
Double tap to toggle the controls. Now the accessibility hint is missing.

When describing the player view for VoiceOver we are using two pieces of text:

A short one, the accessibility label, that describes the element.
A longer one which describes what the associated action does, the accessibility hint.

I suspect that an accessibility hint is only spoken the first time the control it is associated with is focused. If you namely use VoiceOver with a switch button (e.g. in the system Settings app), you can hear that the hint (usually "Double tap to toggle setting") is only spoken the first time, not after you toggle the switch without leaving the control. This is likely implemented this way to avoid unnecessary verbosity and matches what we implemented for our player view (whose controls are toggled like a switch would be).
To have the full label always spoken we would need to include the action in the accessibility label itself, which is not what Apple recommends, as labels must be short. So the situation we have, which avoids being verbose about a hint while the focus is kept on a control, seems correct to me.
Of course if you can reproduce a use case where the hint is missing while moving the control to the player view, then we might still have another bug.


No way to print a list of %tanks in the order they are specified in

Currently, there is no way to print a list of tanks in the order they appear in the code.
Consider the following %ask generator
/-  sole
/+  generators
=,  [sole generators]
:-  %ask
|=  *
^-  (sole-result (cask tang))
%+  print    leaf+"What is your favorite color?"
%+  prompt   [%& %prompt "color: "]
|=  t=tape
%+  produce  %tang
:~  leaf+"a"
    leaf+"b"
    leaf+t
==

And it's output when run
> +axe
What is your favorite color?
blue
b
a

Reading the code it could reasonably be assumed that a gets printed and then b and then whatever the user typed. However, as you can see, it is instead reversed. This makes sense when using %tang to print stack  traces, but we need something to also print things in the order they are specified, be that a mark or a special case in the dojo. The following in an excerpt from the urbit-meta discussion of this.
~fodwyt-ragful> so you can all be enlightened
~bitryt_famnep> i'll file an issue and maybe someone smart will decide the right
                way (tm) to fix it. like it's just revolting to me to write
                documentation that is going to have to say "if you want to print
                stuff out... do it backwards"
~fodwyt-ragful> dy-print special-cases tang
~fodwyt-ragful> and there is nothing special about mar/tang/hoon that makes this
                work the way it does
~fodwyt-ragful> dy-print just literally looks in the cage to see if the head is
                %tang, and if it does, it passes things through.

As I said, while the thing to do at the moment is just produce the list in reverse, or build it and then flop it, this is pretty terrible behavior from a developers perspective. I document it here so that as I write the generator docs I can right that this behavior is ugly and has been reported. Maybe some day someone will fix it.
~palfun-foslup> "maybe someday someone will write it" ah, the early urbit ethos
                (^:

Yeah this is shitty.  Good catch, file as bug.
Sent from my iPhone

On Oct 4, 2018, at 1:50 PM, David Kerschner<EMAIL_ADDRESS>wrote:
Currently, there is no way to print a list of tanks in the order they appear in the code.
Consider the following %ask generator
/-  sole
/+  generators
=,  [sole generators]
:-  %ask
|=  *
^-  (sole-result (cask tang))
%+  print    leaf+"What is your favorite color?"
%+  prompt   [%& %prompt "color: "]
|=  t=tape
%+  produce  %tang
:~  leaf+"a"
leaf+"b"
leaf+t
And it's output when run

+axe
What is your favorite color?
blue
b
a
Reading the code it could reasonably be assumed that a gets printed and then b and then whatever the user typed. However, as you can see, it is instead reversed. This makes sense when using %tang to print stack traces, but we need something to also print things in the order they are specified, be that a mark or a special case in the dojo. The following in an excerpt from the urbit-meta discussion of this.

~fodwyt-ragful> so you can all be enlightened
~bitryt_famnep> i'll file an issue and maybe someone smart will decide the right
way (tm) to fix it. like it's just revolting to me to write
documentation that is going to have to say "if you want to print
stuff out... do it backwards"
~fodwyt-ragful> dy-print special-cases tang
~fodwyt-ragful> and there is nothing special about mar/tang/hoon that makes this
work the way it does
~fodwyt-ragful> dy-print just literally looks in the cage to see if the head is
%tang, and if it does, it passes things through.
As I said, while the thing to do at the moment is just produce the list in reverse, or build it and then flop it, this is pretty terrible behavior from a developers perspective. I document it here so that as I write the generator docs I can right that this behavior is ugly and has been reported. Maybe some day someone will fix it.
~palfun-foslup> "maybe someday someone will write it" ah, the early urbit ethos
(^:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I mean, a well-established way to print them in source code order is flop; reducing this to #646, which I agree is still shitty.
+=tsil ?(~ [tsil *]) type coming in 2019


[Feature Request] Remove duplicated code from /examples

Motivation
Hi, this is a small suggestion to refactor the code in the examples directory.
The reason for it is that different examples have a lot of code in common (see here, here and here for the examples). I guess this small change would increase the readability
Solution
I would suggest to create a utils.py file inside the examples dir and put the duplicated code here. For instance, for the logging example described above we could simply create get_logger(cfg: "DictConfig") function and import it inside examples if needed
Alternatives
Do nothing and close this issue :)
Additional context
If it seems as an OK improvement I would be able to create a PR and address this issue. Please let me know what you think!
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Hi @acforvs
The spirit of the training scripts as they are now is certainly to reduce the duplicated code as much as can be, especially if it does not bring any additional value to the library (e.g. in terms of usage instruction for instance).
As such I'd be in favour of deduplicating the code.
If you'd like to work on this I'd be very supportive!
cc @albertbou92

Hi @vmoens
Thanks for getting back to me! I've just uploaded a PR that introduces a deduplication for the logger creation part

Cool!
You may want to sync with main, we just landed some changes in the training scripts #715


Update README.md

Renamed to Azure AI Search

Thanks for the PR, however we've recently updated the whole repo and made extensive changes to all of the labs and fixed the references to Azure Cognitive Search as part of that process.


Layout and visibility

Hi, it seems that there's no way to make the CameraView fill the parent container without using an AbsoluteLayout nor to set its visibility according to a bindable model property.
Thanks for your support and your excellent work!

Hello. Sorry for slow response.
I don't completely understand what do you need. Could you post some example code or app?


2 Inconsistency in compiling ionic - js files not updated

I am using ionic 3, (exact versions bellow)
I am having huge issues with compile / builds inconsistency:
Reproduce:

run ionic serve
change line of code in a .ts file, the browser gets refresh indication, but js files not updated / or created if i delete the js.
after js files updated - it does happen from time to time, it is not reflected in the running app while i am still under the ionic serve, just when i stop the ionic serve, and run it again. it catches the changes.

https://forum.ionicframework.com/t/inconsistency-in-compiling-ionic-ts-code-not-updated-to-js-and-not-updated-in-the-webpack/108831/3

I was working with ionic 1 and 2, and never face such issues, and it start happening about 1-1.5 month ago,
clearly, while using ionic serve, you have expectations that the code changes will reflected as soon as the browser finish to reload, the inconsistency in it, is a development nightmare.

@ionic/cli-utils : 1.13.0
ionic (Ionic CLI) : 3.13.0
cordova (Cordova CLI) : 7.0.1
@ionic/app-scripts : 3.0.0
Cordova Platforms : ios 4.4.0
Ionic Framework : ionic-angular 3.6.1
ios-deploy : 1.9.2
Node : v8.2.1
npm : 5.4.2
OS : macOS Sierra
Xcode : Xcode 9.0 Build version 9A235

maybe a hint to the source of the problem, no-matter what changes i have made to a service file named: message.service.ts it hasn't compiled a .js file.
Just after making a random change, to a component file, message.component.ts (which includes the message.service.ts file), it triggered compiling of the message.service.ts file, and created message.service.js file

Same problem here with devDependencies (from package.json) containing:
"@ionic/app-scripts": "^3.0.0"
The command "ionic-app-scripts serve" does not seem to reload the changed .ts files on save.
The only way around it so far is to manually kill and relaunch "ionic serve" command.
OS: Ubuntu 16.04.3 LTS (xenial)
Browsers tried :
- Firefox 56.0 (64-bit)
- Google Chrome Version 61.0.3163.100 (Official Build) (64-bit)
This problem clearly seemed to appear with the "3.0.0" version of ionic/app-scripts. Proof being that replacing "^3.0.0" by "2.1.3" seemed to get rid of the problem for now.
Question is : is this wanted ? It seems like a regression to me


feat(rating): ability to disable rating reset

Add ability to specify whether clicking the icon of the current rating will reset the rating to 0

See: https://github.com/angular-ui/bootstrap/issues/5532

This LGTM - thanks for the work!


updated text

line 21

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you @AJ-54 for your contribution and congratulations on your first PR merge to this repo! 🎉

Thank you @AJ-54 for your contribution and congratulations on your first PR merge to this repo! 🎉

Thanks a lot!!


CommanderPi can not run for Raspberry Ubuntu20.1

Hello sir:
I download the install zip,and installed app.
but i run this app ,this app is no reaction.
use the terminal run the start.sh not run and show some error information (pic 1)

I read some issues
used sudo python3 ${HOME}/CommanderPi/src/main.py ${HOME} ,(pic2)

and i surety installed psutil (pic3)

How to fix ,Please help me!
Thank you!
PS:I am from china, english is not good.

Hi, try with pip3 install psutil, also check is CommanderPi installed in your home directory as /home/<username>/CommanderPi NO AS /root!

Hi, try with pip3 install psutil, also check is CommanderPi installed in your home directory as /home/<username>/CommanderPi NO AS /root!

hello sir
I try with pip3 install psutil (pip3 install)

and check the file (file)

everything is ok but app not run.
thank you !

hello sir
I try with pip3 install psutil (pip3 install)

and check the file (file)

everything is ok but app not run.
thank you !

Hmm, try install psutil with sudo, I mean sudo pip3 install psutil

Hmm, try install psutil with sudo, I mean sudo pip3 install psutil

hello sir:
I try install psutil with sudo , but app not run.

and i in terminal run the start.sh $ python main.py
this time show the error information are different (resources.py)

run start,sh error line before is line6, now is line248
run main.py error line before is line6, now is line17
I need edit resoures.py ? if need edit ,how to edit ?
Thank you!

hello sir:
I try install psutil with sudo , but app not run.

and i in terminal run the start.sh $ python main.py
this time show the error information are different (resources.py)

run start,sh error line before is line6, now is line248
run main.py error line before is line6, now is line17
I need edit resoures.py ? if need edit ,how to edit ?
Thank you!

hello sir:
Do you have any way for fix this ?

Hello, what is path for your config.txt file?

I think its boot/firmware/config.txt in Ubuntu, but the file where you should change things has a different name.

Replace resources.py with this file https://drive.google.com/file/d/10D0gSCooz9w-sQ7wxkzowJM7WV-eqMWw/view?usp=sharing

hello sir
I try this way ,but app is not run.
I download this file and changed.
I Added the config file path (pic:config)

This way is right ?
And test start.sh

And test main.py

What's wrong with me ?

Im sorry my bad, I sent you not realesed version of CommanderPi. This file should be fine for you https://drive.google.com/file/d/1oeypiH-ju3lQw0Y_3Z6nCoaoCZFIF6Og/view?usp=sharing

Hello sir
Thank you very much!
run the start.sh ,software is running.
menu desktop not work
but this software can running is well
thank you~


Update wiki (rocket mod4) to 5

I want to make my own plugins and my own server to learn a bit more about programming etc.
but its pretty annoying if the wiki is not up to date #learningbyfrustration, could anyone update the wiki and sample code?
i found some things here but it does not seem to be updated:
https://rocketmod.guide/development-guide/concept/coding-style/
What i really want to know as a starter is:

how do i send something to a player, group, server
how can i make custom player/group attributes
how can access, modify things that a player does (places, shoots, attach)

The wiki was abandoned and https://rocketmod.guide is the replacement for it.
The examples you posted are too specific, you can learn those things by inspecting open source plugins:
https://github.com/RocketModPlugins


Fixed typos in README: set 'isRequired' changed to 'required'

Thank you very much for the PR! Forgot to update the README after an API change.
I just checked the usage of required and isRequired in the FormBuilder and it is not consistent. All @property (nonatomic, assign) BOOL isRequired; has to be changed to @property (nonatomic, assign, getter=isRequired) BOOL required;.
When using the dot syntax, .required should be used instead of .isRequired. This has to be changed in the FormBuilder and the Example application too.
Do you like to apply these changes @weiran ? Otherwise I will fix it at Tuesday.
I think this PR is the right place for these changes, so I will merge it after this is done.

Sure I can do that.

Perfectly. Thank you so much.


[SPARK-12963] Improve performance of stddev/variance

As benchmarked and discussed here: https://github.com/apache/spark/pull/10786/files#r50038294, benefits from codegen, the declarative aggregate function could be much faster than imperative one.

cc @mengxr

Test build #50240 has started for PR 10960 at commit 61edd5e.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50239/
Test FAILed.

Test build #50265 has started for PR 10960 at commit 3c8d737.

Test build #50265 has finished for PR 10960 at commit 3c8d737.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50265/
Test FAILed.

@davies Did you get a chance to test whole-stage codegen with higher-order statistics like skewness? If it works, the cleanest solution would be changing CentralMomentAgg to declarative and then make all existing univariate summary statistics call it.

Test build #50294 has started for PR 10960 at commit ae83955.

Test build #50294 has finished for PR 10960 at commit ae83955.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class CentralMomentAgg(child: Expression) extends DeclarativeAggregate
case class Kurtosis(child: Expression) extends CentralMomentAgg(child)
case class Skewness(child: Expression) extends CentralMomentAgg(child)
case class Echo(child: Expression) extends UnaryExpression

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50294/
Test FAILed.

Test build #50297 has started for PR 10960 at commit 1481bb4.

Test build #50297 has finished for PR 10960 at commit 1481bb4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50297/
Test FAILed.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50302/
Test FAILed.

Test build #50304 has started for PR 10960 at commit 1b95b7c.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50303/
Test FAILed.

Test build #50304 has finished for PR 10960 at commit 1b95b7c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50304/
Test FAILed.

@davies side note: The JIRA number is wrong.

Test build #50322 has started for PR 10960 at commit ae78e81.

Test build #50322 has finished for PR 10960 at commit ae78e81.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50322/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50384 has started for PR 10960 at commit 1086810.

Test build #50386 has started for PR 10960 at commit 383c193.

Test build #50384 has finished for PR 10960 at commit 1086810.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SetDatabaseCommand(databaseName: String) extends RunnableCommand

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50384/
Test FAILed.

Test build #50388 has started for PR 10960 at commit ab32659.

Test build #50386 has finished for PR 10960 at commit 383c193.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Corr(x: Expression, y: Expression) extends DeclarativeAggregate
abstract class Covariance(x: Expression, y: Expression) extends DeclarativeAggregate

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50386/
Test FAILed.

Test build #50388 has finished for PR 10960 at commit ab32659.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50388/
Test PASSed.

Test build #50432 has started for PR 10960 at commit 7e57a1a.

Test build #50432 has finished for PR 10960 at commit 7e57a1a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50432/
Test FAILed.

Test build #2484 has started for PR 10960 at commit 7e57a1a.

Test build #2484 has finished for PR 10960 at commit 7e57a1a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@nongli @rxin Could you review this one?

I'm making a pass.

@davies I made one pass. It would be nice to have a JIRA for checking query result with tolerance on numerical differences, because the result might change (though unlikely) if we merge the partial results in a different order.

@mengxr Thanks for reviewing this, I should had addressed all your comments.

Test build #50560 has started for PR 10960 at commit 9b74195.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50558/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50560 has finished for PR 10960 at commit 9b74195.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PrintToStderr(child: Expression) extends UnaryExpression

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50560/
Test FAILed.

test this please

Test build #50565 has started for PR 10960 at commit 9b74195.

Test build #50565 has finished for PR 10960 at commit 9b74195.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PrintToStderr(child: Expression) extends UnaryExpression

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50565/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50569 has started for PR 10960 at commit 5f98588.

Test build #50572 has started for PR 10960 at commit fe6fe50.

LGTM pending Jenkins. It is great to see 5x speedup!

Test build #50569 has finished for PR 10960 at commit 5f98588.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PrintToStderr(child: Expression) extends UnaryExpression

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50569/
Test PASSed.

Merging this into master, thanks!

Test build #50572 has finished for PR 10960 at commit fe6fe50.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50572/
Test PASSed.


Implement text

This resolves #2, with a caveat:  The code I've written uses far more memory than my testing devices have.  I successfully tested by removing several unused (in the test string) characters from the font file.  I'm looking for guidance on a better implementation given the memory constraints.
This is a direct translation of the C module's code.

Check out the font rendering module here: https://github.com/adafruit/micropython-adafruit-bitmap-font and described in this guide: https://learn.adafruit.com/micropython-displays-drawing-text/overview  I'm going to close this because the font drawing routines there I think what folks will want to use in practice.  It also has minimal memory impact by storing the font file on flash storage and seeking to an exact character location instead of trying to load it all in memory.  It's also nice too because the font file is loaded from disk it can be changed and different font types supported.


PFS: heatmap out of sync with table

Brucella PF tab, applied keyword filters to see membrane proteins. Filtered families are shown
correctly in table and heatmap.
Then, I reset the filters, to show all families. They are correctly displayed in the table. However,
the heatmap still shows only membrane proteins.
-Maulik
https://www.beta.patricbrc.org/view/Taxonomy/234?and(eq(collection_date,"2011"),or(eq(host_name,"Mouse%2C Mus musculus"),eq(host_name,"Cattle%2C Bos sp."),eq(host_name,"American bison%2C Bison bison")))#view_tab=proteinFamilies

fixed and available on alpha.


Armstrong number using python

Is your feature request related to a problem? Please describe.
Yes, in python there are no features to display Armstrong number
Describe the solution you'd like
I would like to add algo to find Armstong numbers using python
Describe alternatives you've considered
I would like to give a solution in order of O(n)
Additional context
Nope, just a program.
Assign this issue under hacktoberfest

Please assign me this


Title: To make navbar , services divs, and testimonials section contrasting in dark mode

Is your feature request related to a problem? Please describe.
To make navbar, services divs, and testimonials section contrasting in dark mode by using contracting colors
Describe the solution you'd like.
using shades of whites and contrasting colors to make it look better with the help of CSS and HTML
Describe alternatives you've considered.
N/A
Add any other context or screenshots about the feature request here.
N/A

Sure @DhairyaMajmudar

Thank You @agamjotsingh18 for assigning issue

Please assign me this issue so that I can resolve it under GSSOC-23

can u assign me this isssue


Unify pricing information

Here is the code controlling the price endpoint in BITBOX.
Seems Bitbox  (and therefore Badger) are pulling from  our price index at:
https://index-api.bitcoin.com/api/v0/cash/price/usd
While the new wallet is using the new markets API at,
https://markets.api.bitcoin.com/rates?c=BCH
causing slight price differences and confusion.
The scope of this issue is to:

Determine what the right source of pricing information is.
Implement that endpoint into the price endpoint for BITBOX.

What is the correct source of pricing information?

https://markets.api.bitcoin.com/rates/convertor?c=BCH
https://markets.api.bitcoin.com/rates/convertor?c=BCH&q=CHF
Forex endpoints seem to be live now


feat: support custom labels for nodes

Hi! 👋🏽
Thank you for this nice plugin and CMS! 😃
This PR adds support for custom labels for nodes - with support for nested properties using dlv.
My use case is: I have title as an object with keys for different languages: { en: 'EN', pt: 'PT' }. And with the default configuration, I get [object Object] for all nodes - which is why I added support for nested properties.
Let me know if you have any suggestions or objections to this change.
Notes

dlv throws when the key/path is undefined - see issue - that's why we need to check if a label was specified to the doc._type before using delve;
Since the default path may return an object, we need the ${label} part to convert it to a string before calling .trim on it.

@atombender @mariuslundgard, ping.

Sorry, I didn't see this PR for some reason. I actually prefer to use a custom query for this:
*[_type == "a" || _type == "b"] {
  ...,
  "title": select(
    a != null => a,
    b != null => b
  )
}`

This sets a title on each document to either a or b. Thoughts?

Really good and simple solution, thanks for sharing it.
Do you think it's valuable to have an example like this in the README?

Absolutely! A readme PR would be very welcome.


Feature/ui tests

Description
✅ UI testing
Trello card: https://trello.com/c/uzYKUfCZ/145-ui-tests
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Sign in screen showing first
[x] Sign up screen shows after tapping segmented control
[x] Passwords match on sign up screen
[x] Forgot password modal screen show after tapping forgot password button
[x] Launch performance

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 UI Tests


✨ [REQUEST] Photoview

Checked

[X] If a new addon, I have checked on  Google that such as addon doesn't already exists
[X] If a new feature, I have searched in the discussions & issues that it was not already covered

Which addon?
Photoview: https://photoview.github.io/
Is your feature request related to a problem? Please describe
No
Describe the solution you'd like
It would be great to have this in your repos.
I've already done a quick&dirty addon, but I guess you want to adapt it to your typical layout.
Also I don't know if I chose the right directories for everything.
Dockerfile:
FROM viktorstrate/photoview:master

ENV PHOTOVIEW_DATABASE_DRIVER=sqlite \
    PHOTOVIEW_LISTEN_IP=photoview \
    PHOTOVIEW_LISTEN_PORT=80 \
    PHOTOVIEW_SQLITE_PATH=/share/photoview/photoview.db \
    PHOTOVIEW_MEDIA_CACHE=/share/photoview/cache

VOLUME ["/share", "/media"]

config.yaml:
name: Photoview
description: Photoview
version: 0.0.3
slug: photoview
arch:
  - amd64
ports:
  80/tcp: 8001
ports_description:
  80/tcp: "Web Interface"
map:
  - "share:rw"
  - "media:ro"

Also, an alternative docker-repo might be: viktorstrate/photoview:2.3.13 (latest upstream release)

Hi! Thanks for the proposal. As I have already 2 photo gallery apps (piwigo & photoprism) I don't think about adding a new one to the repo at short term... Thanks for your understanding


Add python image

Description
Changes proposed in this pull request:

Add python image built from the 3.8.8 rc1 github tag, which will be used temporarily because of CVE-2021-3177 vulnerability that wasn't officially patched yet.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/test all


Telemetry injection forces event data content type to JSON

When upgrading the client from version 5.3.0 to 5.4.0, we ran into problems where the system projections were not picking up any events. After some digging, we noticed our Protobuf events were being interpreted as JSON.
Looks like the problem is caused by this line, which seems to ignore the current format of the event data and just forces it to JSON:
https://github.com/EventStore/EventStoreDB-Client-Java/blob/a7158994d0e37d7d7c4dca5b63ff49a17b01c3bd/db-client-java/src/main/java/com/eventstore/dbclient/ClientTelemetry.java#L34
Should this take the current content type into consideration, or am I missing something?

Hi @andersflemmen
Thanks for raising this, yes it looks like you are correct.
I will look into this further and prepare a patch for this problem and get back to you shortly.

Hey @andersflemmen
Sorry for the delay, a fix is being prepared now, once merged it will be released as patch v5.4.1 - I will notify you here once that's available, too.

Hi @andersflemmen
I can confirm the patch is now available on v5.4.1.
Thanks for bringing this to our attention, let me know if you have any further issues going forwards 👍


FlyoutBase.ShouldConstrainToRootBounds doesn't always default to false

The doc says "The default is false."
I believe that depends on the concrete type -- for a MenuFlyout it's false, but for a Flyout it's true.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f1b416b-01ee-2b61-fc36-879e9d2f0557
Version Independent ID: 47549116-6ee7-27f2-1d77-9042d4f041ea
Content: FlyoutBase.ShouldConstrainToRootBounds Property (Windows.UI.Xaml.Controls.Primitives) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Xaml.Controls.Primitives/FlyoutBase.xml
Product: uwp
Technology: winui
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks for catching that. The documentation has been updated.

Thanks for catching that. The documentation has been updated.

Terrific!  Thanks!


suggestion: add context menu item to files as well as directories, to create a new file in the same directory as the selected file

Thanks for the great extension, its been very helpful.
Often when I want to create a new C# file, I want to put it in the same directory as the file I'm working on. However due to the mess of expanded directories and files it can take awhile to navigation the explorer to find that directory to create a file. If the "Create new c# file" was available in the context menu for the file I'm currently at then it would be a lot easier.
I admit it might feel a bit tacky... To keep it clean maybe only extend the context menu for c# files.
Just a thought, thanks again.

I added a new setting to allow you to enable showing context menu on files.

Thanks, I checked and its working for me.


Fix for parallel_map_dataset_op_test failure on big endian

For Tensorflow v2.0.0, //tensorflow/core/kernels/data:parallel_map_dataset_op_test module was failing on s390x  with error "Which is: Invalid argument: num_parallel_calls must be greater than zero."
The int32 results in a negative value of num_parallel_calls, hence the test case fails on s390x.
When the type is changed to int64, behavior is same for both s390x and Intel.  And all the test cases of parallel_map_dataset_op_test run successfully.
Even after changing int32 to int64, behavior on Intel is unaffected.

I believe the problem is with the test and not with the kernel. The op kernel expects a int32 for num_parallel_calls but the failing test is creating int64 tensor. Could you please see if changing the test to use int32 for the num_parallel_calls tensors fixes the problem?

@anujajakhade Could you try to change int64 to int32 at Line 89, 111, 134, 156,
179, 202, 226, 250, 270?

@anujajakhade Could you try to change int64 to int32 at Line 89, 111, 134, 156,
179, 202, 226, 250, 270?

The mentioned changes work on s390x. Should I do the changes in the same PR ?

Yes, I revert the change to the kernel.

@jsimsa I have done the required changes. Can you please review?


Provide an uninstall.sh

Feature Request
Is your feature request related to a problem? Please describe.
As a user, I would like to try out the OLM tool and later would like to clean it up.
Describe the solution you'd like
Currently, I see that there is an install.sh that will install the OLM. Recirocatively, there should be an uninstall.sh.

If it helps, the operator-sdk olm uninstall command can do this for you. But I'm not against OLM providing an official uninstall script.

Hi @abbi-gaurav, thanks for opening this issue. We would open to accepting a PR implementing an uninstall.sh script, that could be helpful for our users.

I would love to see this as well
I am having an issue actually operator working, would be nice if i could tear up and tear down

We have decided to direct users to operator-sdk olm uninstall as the supported means of uninstalling as an additional redundant script could introduce opportunities for drift. This is now represented in  the install documents


README reports padding as possible option but it sounds to be margin

In the README, it's writtem that there is only 1 option, padding.
Available options
The following pluing options are available:

padding - (pixels) Add some padding to the bounding box that will appear around your legend items. Default: 4.

But having a look to the code, the option sounds to be margin:
https://github.com/julianna-langston/chartjs-plugin-a11y-legend/blob/c51811c85921f94e8bf06dfde5e01e7e6652178c/src/plugin.ts#L156-L158

Thanks for finding/fixing that issue!

UR welcome! I think that the fact that the plugin is storing the ChartLegendManager instance in the chart.options could be a bad practice. Maybe a private map could be better, where the key is the chart instance and the value is ChartLegendManager instance could be better. Just 2 cents from my side.

I've been nervous about putting variables in the options section, and would love to find another way to store relevant data for each chart. Do you know where I would get a unique identifier for each chart? I hadn't seen a variable or option like that in the options yet.

You can use the chart instance itself as key of the map. The instance is clear unique.
See chartjs plugin annotation: https://github.com/chartjs/chartjs-plugin-annotation/blob/master/src/annotation.js#L11-L46
See chartStates map instance.
If you want, I can try to prepare a PR to do it. As you prefer.


Backport 3999

Do not remove comment from an import with a single item (#3999)

This has conflicts that will need to be resolved, though may be worth waiting to do so until after some other PRs land given the likely overlap of modified code

@calebcartwright Do you think it would be best to drop the test cases for #3984 and address that issue in a separate PR or to try and get that sorted out in this PR as well?

The backport was completed by https://github.com/rust-lang/rustfmt/pull/5853


Add a new feature: Visible Full Level

Similar to #961. Fractional level (e.g. 6.78) is currently seen on hover, so replacing the floored level (e.g. 6) with that should be trivial. The loss of space can be compensated by reducing the word "Level" to simply "Lv", so that Level 6 becomes Lv 6.78.
This is partially meant as a substitute to 1.20 Level Progress Visualizer for people who prefer to visualize the points graphically.

Is this working for you? I enabled it here and mine still says just "Level 4" instead of "Lvl 4.57".

Yes, it's working fine for me. Perhaps it's because of another setting I have enabled. I'll test.

Okay, what. I loaded a couple of pages 15 minutes ago, it wasn't working. I did another sync because you asked on another issue (without changing any settings), wrote a bit here on github, and finally reloaded one of these pages. Now it's working, as if by magic. I'm confused.

Wait, I think I think I may have figured at least a part of it out. On GA lists, the change from "Level 4" to "Lv 4.57" happens after entering/exiting a GA; other pages might have similar conditions. When I was on a GA page and exited it, the header reverted to saying "Account (184P / Level 4)" instead; before, it said "Account (184P / 9.1h to 400P / Lvl 4.57)" (whatever the amount of points).

Just enabled it but it's not working for me neither.

Oh, forgot about this.


Render BS3 dropdowns in wormhole

Mentioned here; https://github.com/kaliber5/ember-bootstrap/pull/570#issuecomment-393400624
Added support for BS3 dropdowns to be rendered in wormhole when renderInPlace=false on the menu component.
I mostly just copied the work from BS4, read over it & tested and it seems to work fine.
A few things I'm not sure about:

I set tagName to empty instead of
, to match BS4, it seems fine when either a wormhole or not, I think this is correct? But it seems to make some dropdown related tests fail for LTS versions
The two menu components are identical, should they be combined like I did for the menu component templates?

Thanks for the feedback. I've put the common dropdown menu code into base and put the BS3 menu tagname back to

Actually, it doesn't quite work as I expected using tagName
 on the menu, it ends up doing the following;
renderInPlace=true
<button /> (dropdown button)

 (the menu)

 (ember-popper element)

 abc
 (list items)

renderInPlace=false
<button /> (dropdown button)

(ember wormhole)

 (ember-popper element)

 abc
 (list items)

So I think I need to set the tagName of the menu back to empty, and somehow set the tagName of the ember-popper to ul?

So I think I need to set the tagName of the menu back to empty, and somehow set the tagName of the ember-popper to ?

Yes, makes sense. We already pass the class here for BS4, should add tagName (for BS4 it's div by default, which is ok there): https://github.com/kaliber5/ember-bootstrap/blob/bbb45998513b84ceab7b9392ad10d56ee38c5080/addon/templates/components/bs4/bs-dropdown/menu.hbs#L3

I did give that a go, but unfortunately expects its tagName to be '' and then it passes that class attribute down to a child div - so you can't really set the tagName on ember-popper at the moment
https://github.com/kybishop/ember-popper/blob/master/addon/templates/components/ember-popper.hbs

Hey @simonihmig just checking in, is a PR to ember-popper the only way to get this resolved?

Sorry, missed your previous comment while being on vacation...
The only thing that comes to my mind is to wrap the {{yield ...}} in a
, in the template for the BS3 menu only. Something like...
{{#ember-popper
    placement=popperPlacement
    popperTarget=toggleElement
    renderInPlace=renderInPlace
    popperContainer="#ember-bootstrap-wormhole"
    modifiers=popperModifiers
    registerAPI=(action "registerPopperApi")
  }}

    {{yield ...}}

{{(ember-popper}}

(just written offhand, classes etc. might be wrong)
This would have a wrapping
 around the
 menu (from ember-popper), but that should hopefully not be a problem?

Ah, that makes sense. I gave that a try (see commit https://github.com/kaliber5/ember-bootstrap/pull/624/commits/7728341d5bd93863b245500d4ef2e3f4b2efd49e )
It seems that when the .dropdown-menu class (which contains z-index:1000) is not on the ember-popper element, the popper element & menu are shown behind other elements:
renderInPlace=true

renderInPlace=false

So I also had to put z-index:1000 on the ember-popper element, and that fixed it! I tested all directions/alignments, works as expected. I think I did this correctly.
Should be good to merge now unless there are more changes needed?

Hey @simonihmig this is passing the tests now and won't be a breaking change for existing BS3 users. Should be good to be merged in when you've got a chance
If you're not happy with the zindex fix I did let me know

Woohoo! No worries at all, we're all busy people :)


Support Enums

FSharp doesn't consider the type:
type X = One = 1 | Two = 2

to be a union, but it would be nice if Thoth could handle it automatically, deserializing both int and string values.
Currently the decoding raises no issues, but the deserialized values lack something and don't work with pattern matching:
let x = deserialized "One" // or deserialized 1
match x with
| One -> "one"
| x -> string x

results in [object Object].

Ok this is due to a bug in Fable compiler.
When writing:
type X =
    | One = 1
    | Two = 2

let json = Encode.Auto.toString<X>(4, X.One)

we get:
export const X = declare(function Test_X(arg1, arg2, arg3) {
  this.value__ = arg1 | 0;
  this.One = arg2;
  this.Two = arg3;
}, Record);
export function X$reflection() {
  return type("Test.X");
}
export const json = Auto$0024$0024$0024toString$0024$002459982D9A(4, 1, null, null, {
  ResolveType() {
    return int32;
  }

});

As you can see the type information is int32. So Thoth.Json is trying to decode the value as an int and because 1 is indeed an int then it's working.
I will have a look at this bug in Fable compiler and also tries to add the reflection info/methods needed to support enums (currently we don't have any reflection method available for enums) that's why Thoth.Json can't support them out the box and you have to provide your own coders for them.

I've got these custom decoder/encoder and it works, I just don't want to have to write those for each type of enum:
    let decoder _ (value:obj) : Result<X,_> =
        Ok (LanguagePrimitives.EnumOfValue (unbox value))

    let encoder (value: StageType) : JsonValue =
        Linq.JValue (LanguagePrimitives.EnumToValue value) :> JsonValue

Other possible implementation, which seems to restrict the value to be an actual enum
Sharing so I can have access to them on my other laptop
let inline parseEnum (value : int) : ^TEnum =
    let enumType = typeof< ^TEnum>
    printfn "%A" enumType

    enum value

let inline toJsonEnum (value : ^TEnum when ^TEnum :> System.Enum) =
    string value

type Test =
    | One = 1
    | Two = 2

type Test2 =
    | One = 'o'
    | Two = 't'

let x : Test = parseEnum 2

printfn "%A" (toJsonEnum Test.One)

Support for the following types:

Add supports for enum<byte>
Add supports for enum<sbyte>
Add supports for enum<int16>
Add supports for enum<uint16>
Add supports for enum<int>
Add supports for enum<uint32>

Released in:

Thoth.Json 3.4.0
Thoth.Json.Net 3.6.0

Thank you!


error while getting consensus queue: consensus queue not implemented for queueTypeName EVM:eth-main:evm-turnstone-message module=x/consensus

screenshot https://i.imgur.com/Rvzgd2h.png
what is that error?i don't know, my validator is active

screenshot https://i.imgur.com/Rvzgd2h.png what is that error?i don't know, my validator is active

What version of Paloma and Pigeon are you using?

User is on older version of Pigeon and needs to upgrade.

User is on older version of Pigeon and needs to upgrade.


Making your first clang-tidy check

https://clang.llvm.org/docs/LibASTMatchersReference.html#narrowing-matchers
https://devblogs.microsoft.com/cppblog/exploring-clang-tooling-part-2-examining-the-clang-ast-with-clang-query/
https://clang.llvm.org/extra/clang-tidy/Contributing.html#writing-a-clang-tidy-check

I just went through this process and it was pretty cool. I was targeting a cpp core guideline, so I also took the plunge to figure out how to use phabricator and the whole clang code submission / review system (https://reviews.llvm.org/D137514). We put the check into production, but upstream clang pointed out many extra bits that needed to be done to make it generic enough for upstreaming. Good stuff!


mongo-connector fails to start after being stopped

When I stop the mongo-connector and then start it again afterwards it first looks like it is continuing where it stopped, but after a couple of seconds it stops without an actual error message and just prints "Mongo DocManager Stopped: If you will not target this system  again with mongo-connector then you may drop the database __mongo_connector, which holds metadata for Mongo Connector.".
Because of that I have to resync mongo-connector everytime it gets stopped or if it fails for any reason.

What are the contents of the log file? Is anything else printed to
stdout/stderr?
On Wed, Sep 2, 2015 at 3:55 PM, XDestination<EMAIL_ADDRESS>wrote:

When I stop the mongo-connector and then start it again afterwards it
first looks like it is continuing where it stopped, but after a couple of
seconds it stops without an actual error message and just prints "Mongo
DocManager Stopped: If you will not target this system again with
mongo-connector then you may drop the database __mongo_connector, which
holds metadata for Mongo Connector.".
Because of that I have to resync mongo-connector everytime it gets stopped
or if it fails for any reason.
—
Reply to this email directly or view it on GitHub
https://github.com/10gen-labs/mongo-connector/issues/317.

I don't see any other message in the logs, even though I set the verbosity to 3.

I've tried it now again with a verbosity level of 2 and now it is running for over an hour. Maybe this solved it.


Adopt shadow dom for the context view service

PR #97965 fixes issues with maintaining focus inside a dom element when the context view is opened. However, by rendering as a child of other DOM elements we risk unintended DOM interaction via css or otherwise. As a workaround for now, this has been scoped to a handful of widgets that need the behavior change. Now we have debt that we should invest in making the context view a shadow dom node that has all of its css injected to avoid unintended interaction.
/cc @joaomoreno

Interesting! 👍


⚠ Turnos 24x7 has degraded performance

In 5ae2b10, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 5761 ms

Resolved: Turnos 24x7 performance has improved in b4cb0dc.


Fixing the apt repo to use the actual lsb_release

and not hardcoded to Ubuntu LTS release codename

This change is

cncf-cla signed

May have spoke too soon. The debian stretch repo doesn't appear to have latest packages, unfortunately.
https://packages.cloud.google.com/apt/dists/kubernetes-xenial/main/binary-amd64/Packages
vs
https://packages.cloud.google.com/apt/dists/kubernetes-stretch/main/binary-amd64/Packages


Fixed complexity reparameterization

Codecov Report

Merging #23 (983c0c1) into master (1f4ad22) will decrease coverage by 0.00%.
The diff coverage is 97.10%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   99.88%   99.88%   -0.01%
==========================================
  Files          32       32
  Lines        1681     1679       -2
==========================================
- Hits         1679     1677       -2
  Misses          2        2

Impacted Files
Coverage Δ

include/smooth/spline/bspline.hpp
100.00% <ø> (ø)

include/smooth/spline/spline.hpp
100.00% <ø> (ø)

include/smooth/spline/reparameterize.hpp
97.67% <97.10%> (-0.06%)
:arrow_down:

include/smooth/internal/utils.hpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4ad22...983c0c1. Read the comment docs.


cherry-pick ec2-amis.nix: add 19.03 amis

(cherry picked from commit 548932640b0a58d51877954b4bf934ffebfdf4c2)

@edolstra mind applying this as well ? thanks

Pretty sure this is fine, I'll merge


change sdrf version -> 0.0.10

PR checklist

[ ] This comment contains a description of changes (with reason)
[ ] CHANGELOG.md is updated
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated
[ ] If necessary, also make a PR on the nf-core/proteomicslfq branch on the nf-core/test-datasets repo

There seem to be problems. The PLFQ tool cannot parse "Sample 1". It expects pure consecutive integers starting from one.

The new version of Sdrf-pipelines is now ready.

Looks good. Is this ready to merge?

Looks good. Is this ready to merge?

@jpfeuffer this is ready to be merged?

@jpfeuffer this is ready to be merged?


Fix duplicated error test cases

Enable application duplicated error test cases

@abdotalaat Thanks for the fix, it is approved and it is working now, but do to the huge change in the services architecture there was a big conflict so I decided to add your solution manually and it works.
So please update your repository with the latest version from develop branch.


generate one vk_dispatch_table_helper.h for all platforms

If your intent is to make this the default, you'll have to modify the CMakeLists.txt file in the layer sub-folder to generate the vk_dispatch_table_helper.h file with all defines.

Making a single header file work for all platforms fixes CI issues when compiling for multiple different platforms in one go. Afaik there's no CI setup for this repository so it's not a problem, but it is a problem for Vulkan-Samples which includes several layers that use this header file. With these changes the header file will continue to be platform specific if you specify a particular platform. I didn't want to make any more changes than necessary, but I can certainly make this the default if that's desired for this repository.

Changes committed with caeb0e1fd41fe854c9ceb2a65c75920fcae258fb


bug(mutation-switching): Adding an e2e test for jest/enzyme

An e2e test for #2362. When I try to run the mutation test, it says that the inital test run fails and then just hangs. So running it with npm run e2e isn't going to report back unless you've got a timeout timer on it

Thanks a lot @Garethp ! This project will help us now and in the future. Will take a look later this week 💗

Awesome! 💗


feat: sidepanel API

Details
This PR aligns the sidepanel API on chrome and the sidebar_action API on firefox
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I agree to license this contribution under the MIT LICENSE
[x] I checked the current PR for duplication.

Contacts

(OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.
To join the server, visit: https://www.plasmo.com/s/d

@louisgv When will this feature be improved and merged?

@xudaolong Can you review and test it out on your end?

@louisgv I tested it and there is nothing wrong with it, including the messages, awesome!


i added th comentes fof the code

Adding a language

[ ] The code displays "Hello World" (tio.run may help for testing)
[ ] I have no association with the language
[ ] There are no copyright issues with this code
[ ] The language has not been added prior to this pull request
[ ] I have updated the README

Link to programming language:

please accept


Makefile: trim gopath from panic logs

Description of the change: Trim the GOPATH from binaries built with install or build.
Motivation for the change: Remove the home directory of the builder from the panic path.
Example of current panic output:
/home/apavel/go/src/github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra/command.go:852 +0x30a
github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200f1180, 0xc4207d5f78, 0xc4200b6058)
        /home/apavel/go/src/github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra/command.go:800 +0x2b
main.main()
        /home/apavel/go/src/github.com/operator-framework/operator-sdk/commands/operator-sdk/main.go:24 +0x27

Example of new panic output:
...
 src/github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra/command.go:852 +0x30a
github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200c9400, 0xc420877f78, 0xc42004c178)
        src/github.com/operator-framework/operator-sdk/vendor/github.com/spf13/cobra/command.go:800 +0x2b
main.main()
        src/github.com/operator-framework/operator-sdk/commands/operator-sdk/main.go:24 +0x27

When merged, this will be cherry-picked to the v0.4.x branch so that panics from the binary as well as the helm and ansible operators have the cleaner panic output.
Closes #1036

Fixed


Not support sound-cloud url

Describe the bug
When I try to fetch soundCloud's url details I didn't get title and thumbnail
getting this response ->
{"contentType": "text/html", "description": undefined, "favicons": ["https://www.gstatic.com/mobilesdk/160503_mobilesdk/logo/1x/firebase_64dp.png"], "images": [], "mediaType": "website", "siteName": undefined, "title": "", "url": "https://soundcloud.app.goo.gl/XT7kAYqnM9s79ebq5", "videos": []}
To Reproduce
Steps to reproduce the behavior:
data = await getLinkPreview('https://soundcloud.app.goo.gl/XT7kAYqnM9s79ebq5', { //sound could music url
headers: {
'user-agent':
'Mozilla/5.0 (iPhone; CPU iPhone OS 13_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1',
},
timeout: 2000,
}).then();
Expected behavior
I should return image uri and it's title like with other response
should return something same response like youtube
{
url: "https://www.youtube.com/watch?v=MejbOFk7H6c",
title: "OK Go - Needing/Getting - Official Video - YouTube",
siteName: "YouTube",
description: "Buy the video on iTunes: https://itunes.apple.com/us/album/needing-getting-bundle-ep/id508124847 See more about the guitars at: http://www.gretschguitars.com...",
images: ["https://i.ytimg.com/vi/MejbOFk7H6c/maxresdefault.jpg"],
mediaType: "video.other",
contentType: "text/html; charset=utf-8",
videos: [],
favicons:["https://www.youtube.com/yts/img/favicon_32-vflOogEID.png","https://s.ytimg.com/yts/img/favicon-vfl8qSV2F.ico"]
}
Desktop (please complete the following information):

OS: mac os
chrome, safari
22

Smartphone (please complete the following information):
IOS Simulator (ios 11, ios15.0)

nothing I can do about that, this is what the server is returning on your query, you might try to follow redirects and whatnot. read the README


GH-1739 strip context

GitHub issue resolved: #1739
Briefly describe the changes proposed in this PR:

added Statements.stripContext
added Models.stripContexts
adedd unit tests

lgtm