[discussion] how to arrive at good write watermark settings

Netty version : 4.1.4.Final
We have an inhouse (to be opensourced soon) http2 server mostly focused at browser scenarios. It is capable of serving static content as well as rest services over http2+ssl, using FullHttpResponse only.
Recently we tried to implement simple backpressure support, like so:
b.childOption(ChannelOption.WRITE_BUFFER_WATER_MARK,
                    new WriteBufferWaterMark(appConfig.writeBufferLowWatermark, appConfig.writeBufferHighWatermark));

(using settings of 8192 / 32768)
, and then
if (appConfig.enableBackPressure && !ctx.channel().isWritable())
        {
            logger.error("returning 503 due to unwritable channel. remaining bytes before writable: {}",
                    ctx.channel().bytesBeforeWritable());

            write(ctx, streamId, serviceUnavailableResponse());
            return;
        }

Our local tests with h2load behaved well.
Then on a customer landscape using ubuntu on vmware (not sure if related), a single user accessing the homepage with chrome over h2 (html + some js + some jpegs, nothing too oversized), results in half of the responses 503'ing and effectlively the page being unable to load:
2016-11-02 10:45:51.857 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.057 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/bootstrap-select.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.058 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/bootstrap.min.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.059 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/bootstrap-theme.min.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.060 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121428
2016-11-02 10:45:52.060 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/font-awesome.min.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.061 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121445
2016-11-02 10:45:52.061 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/datepicker.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.062 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121462
2016-11-02 10:45:52.063 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/style.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.063 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121479
2016-11-02 10:45:52.065 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /assets/css/print-style.css  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.065 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121496
2016-11-02 10:45:52.066 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/require/require.js  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.066 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 121513
2016-11-02 10:45:52.588 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/require/require.js  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:52.813 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/multiPage.js  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.059 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/ractive/ractive.min.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.061 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/page/page.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.061 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 167419
2016-11-02 10:45:53.062 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/jquery/jquery-1.11.3.min.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.062 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 167436
2016-11-02 10:45:53.063 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/require/text.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.064 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 167453
2016-11-02 10:45:53.065 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/novarto/constructor.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.065 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 167470
2016-11-02 10:45:53.066 [epollEventLoopGroup-4-2] INFO  ACCESS_LOG - /<IP_ADDRESS>:64387 -> GET /scripts/vendor/history/history.js?v=1  (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36)
2016-11-02 10:45:53.066 [epollEventLoopGroup-4-2] ERROR c.n.cletty.server.netty.HttpRouter - returning 503 due to unwritable channel. remaining bytes before writable: 167487

I am pasting below some of the machine configuration, and I will provide more info if needed.
I don't have a clue why h2load-ing on our internal landscapes with 1000 clients (8 threads) gives 100% 200 OK rate, and on this server only 20-ish requests from a single client result in 503.
But really, the thing I'm trying to establish is, how does one arrive at good numbers for these settings? I think it should have to do with the anticipated average response size, maximum number of concurrent users, and how much memory you can spare. Are NIC settings / kernel settings related. Does it relate with other channel options?
I've no idea how to attack this and can't find any help online, so any pointers whatsoever will be greatly appreciated.
Here is some info from the node where we experience the problem:
./java -version
java version "1.8.0_65"
Java(TM) SE Runtime Environment (build 1.8.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mode)

cat /etc/sysctl.conf
#
# /etc/sysctl.conf - Configuration file for setting system variables
# See /etc/sysctl.d/ for additional system variables.
# See sysctl.conf (5) for information.
#

#kernel.domainname = example.com

# Uncomment the following to stop low-level messages on console
#kernel.printk = 3 4 1 3

##############################################################3
# Functions previously found in netbase
#

# Uncomment the next two lines to enable Spoof protection (reverse-path filter)
# Turn on Source Address Verification in all interfaces to
# prevent some spoofing attacks
#net.ipv4.conf.default.rp_filter=1
#net.ipv4.conf.all.rp_filter=1

# Uncomment the next line to enable TCP/IP SYN cookies
# See http://lwn.net/Articles/277146/
# Note: This may impact IPv6 TCP sessions too
#net.ipv4.tcp_syncookies=1

# Uncomment the next line to enable packet forwarding for IPv4
#net.ipv4.ip_forward=1

# Uncomment the next line to enable packet forwarding for IPv6
#  Enabling this option disables Stateless Address Autoconfiguration
#  based on Router Advertisements for this host
#net.ipv6.conf.all.forwarding=1

###################################################################
# Additional settings - these settings can improve the network
# security of the host and prevent against some network attacks
# including spoofing attacks and man in the middle attacks through
# redirection. Some network environments, however, require that these
# settings are disabled so review and enable them as needed.
#
# Do not accept ICMP redirects (prevent MITM attacks)
#net.ipv4.conf.all.accept_redirects = 0
#net.ipv6.conf.all.accept_redirects = 0
# _or_
# Accept ICMP redirects only for gateways listed in our default
# gateway list (enabled by default)
# net.ipv4.conf.all.secure_redirects = 1
#
# Do not send ICMP redirects (we are not a router)
#net.ipv4.conf.all.send_redirects = 0
#
# Do not accept IP source route packets (we are not a router)
#net.ipv4.conf.all.accept_source_route = 0
#net.ipv6.conf.all.accept_source_route = 0
#
# Log Martian Packets
#net.ipv4.conf.all.log_martians = 1
#

net.ipv4.tcp_max_syn_backlog = 40000
net.core.somaxconn = 40000
net.core.wmem_default = 8388608
net.core.rmem_default = 8388608
net.ipv4.tcp_sack = 1
net.ipv4.tcp_window_scaling = 1
net.ipv4.tcp_fin_timeout = 15
net.ipv4.tcp_keepalive_intvl = 30
net.ipv4.tcp_tw_reuse = 1
net.ipv4.tcp_moderate_rcvbuf = 1
net.core.rmem_max = 134217728
net.core.wmem_max = 134217728
net.ipv4.tcp_mem  = 134217728 134217728 134217728
net.ipv4.tcp_rmem = 4096<PHONE_NUMBER>17728
net.ipv4.tcp_wmem = 4096<PHONE_NUMBER>17728
net.core.netdev_max_backlog = 300000

ifconfig eth0
eth0      Link encap:Ethernet  HWaddr ***
          ....  And continue reading once it becomes writable again.

Absolutely right. I've went ahead with something like this, I'm hoping it will do for now. h2load will show tomorrow how it behaves.
@Override
    public void channelWritabilityChanged(ChannelHandlerContext ctx) throws Exception
    {

        if (appConfig.enableBackPressure)
        {
            if (ctx.channel().isWritable())
            {
                logger.info("channel is writable again, turnung on autoread");
                ctx.channel().config().setAutoRead(true);
            }
            else
            {
                logger.info("channel is unwritable, turnung off autoread");
                ctx.channel().config().setAutoRead(false);
            }
        }

    }

, and not bother at all with writability in channelRead().
Also please disregard the above info with the ubuntu server settings as useless, as it turned out not to be related to the particular machine.
The question remains - how to compute "sane" settings for the watermarks based on one's scenario and expected load / concurrency / system harware / etc? Is it purely a load testing / experimentation excercise? Is it directly related to response message sizes? What do these numbers mean exactly? The documentation on the topic is a bit scarce, at least what I was able to find.
Pardon my ignorance and thank you for your time.

This issue is too vague and low-quality. I will close this and try to open something more concrete, with a runnable code sample. Sorry.


Properly handle graceful shutdown of the kubelet plugin

Some description of what problem this change addresses would be useful. Both commit message and PR description are empty.


Roll Flutter Engine from 5d61f352ca32 to 355f5608765b (1 revision)

https://github.com/flutter/engine/compare/5d61f352ca32...355f5608765b
2023-02-20<EMAIL_ADDRESS>Roll Dart SDK from 194b1d4829c9 to a1401ef3d0ec (1 revision) (flutter/engine#39764)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[wasm] Fix WASI build around TimeZone

https://github.com/swiftlang/swift-foundation/pull/975 started to restrict the fallback value for TZDIR and it revealed that WASI platform implicitly depends on TZDIR even though it won't have such directory. This patch explicitly handles the case for WASI platform for timezone operations.

@swift-ci test


Abstract Elasticsearch access for supporting different versions

Description:
Currently, the esctl tool is tightly coupled to a specific Elasticsearch version, limiting its flexibility. The goal is to abstract the Elasticsearch access in the es package, allowing esctl to seamlessly support different Elasticsearch versions. This will enhance flexibility and maintainability.
Acceptance Criteria:

Abstract the Elasticsearch access in the es package.
Implement version-specific modules for different Elasticsearch versions.
Refactor esctl to utilize the abstracted Elasticsearch access.
Ensure compatibility and functionality across supported Elasticsearch versions.

Would it also be beneficial to consider supporting OpenSearch while working on this abstraction?

Makes sense. I am not aware of any differences between Elasticsearch and OpenSearch management APIs though. Have you noticed any discrepancies?

I could not check this tool with OpenSearch yet. Let me do a test and share with you.

I just checked for some features, and it is working as well. Just for the local setup, SSL verification needs to be skipped:
https://github.com/hkulekci/esctl/tree/skip-ssl-verification


source-build supports 2.1 release (master)

[ ] Port dev/release/2.0 to master
[ ] repo owners port their patch removal from 2.0 servicing to their master (2.1 branch).
[ ] update the master SHA to masters of submodule repos

Closing to use #258 instead.


Android: having build issues with my project (cannot find symbol variable TIRAMISU)

While building my app using android studio it shows "cannot find symbol variable TIRAMISU" and "cannot find symbol variable POST_NOTIFICATIONS" from the inside of the NotifeeApiModule.java file. But it is working fine on ios. Please solve this issue asap.

gradle-7.5.1,
"react-native": "^0.70.6",
"@notifee/react-native": "^7.6.1",

Android Studio Chipmunk | 2021.2.1 Patch 1
Build #AI-212.5712.43.2112.8609683, built on May 18, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.5
GC: G1 Young Generation, G1 Old Generation
Memory: 1280M
Cores: 8
Registry: external.system.auto.import.disabled=true

error

what's in your build.gradle, are you targetting 33?
Was your project working before notifee v7.6.1"?
should be this:
 buildToolsVersion = "31.0.0"
        minSdkVersion = 21
        compileSdkVersion = 33
        targetSdkVersion = 33

But I'd recommend running our example app and comaring

Also,  a quick search of stack overflow indicates the same as I mention above that your compileSdkVersion and targetSdkVersion needs to be bumped.
Sometimes it's quicker to do a quick google, especially when it's generic errors like this.

buildToolsVersion = "31.0.0"
minSdkVersion = 21
compileSdkVersion = 31
targetSdkVersion = 31

I  have installed Notifee for the first time in my project. it works fine on ios but the problem is with android.

yes, please see what I have said above


ARROW-4157: [C++] Fix clang documentation warnings on Ubuntu 18.04

I also added an option ARROW_USE_CCACHE to turn ccache on and off

I'm not sure why these don't show up on Ubuntu 14.04. It would be nice if we could figure out how to get our CI to catch these


Fullscreen image is not crip as original one

For example on https://main--helix-sportsmagazine--headwirecom.hlx.page/content-v2/golf-news-tours/_default/article/2023/7/3m-open-lee-hodges-wins-big-lead-sets-up-fedex-cup-playoffs which was imported from https://www.golfdigest.com/story/3m-open-lee-hodges-wins-big-lead-sets-up-fedex-cup-playoffs, you can tell that the hero image is too compressed which results in a blurry image.

This wil require playing with the fastly image api which is used in franklin for image optimization https://developer.fastly.com/reference/io/ to find the best balance between image quality and performance.

@hsaginor we found out that the imported image in this case here is of low quality in the document and therefore we can't display a better quality. Do you think this is something that can be fixed in the importer ? Would it be possible to retrieve the best image quality ?

@icaraps Please check if the attached document is any better. I am now trying to only import original renditions. I don't think we can do any better than the original.
3m-open-lee-hodges-wins-big-lead-sets-up-fedex-cup-playoffs.docx

I don't think we can do any better than the original.

Yes original is better. There's anyway a limit in google docs. It will be downsized by default to 1600x1600 if the image is bigger than that.


Refactored the lex function in the BlockDirectiveParser file.

Summary

This PR refactors the current implementation of lex function of the TrimmedLine. It's intended to make the code more readable and concise without breaking the existing intended functionality.
In the updated implementation, instead of incrementing the takeCount var (within while loop) at every certain conditions, it will update the takeCount only once at the end.
Also, instead of checking for if condition to populate the isQuoted var, we can directly use the boolean result of != relational operator to populate the variable.
This makes the code concise and more easier to debug and dry-run the while loop.

Testing
I believe this is a minor refactoring and doesn't require any new tests. All the existing test cases was passing. 💯
Checklist

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

Note

This is my first ever contribution to this repository. I made sure that I read the contributing guidelines.
Still if there's anything I can improve, please give your feedback, would love to work on that. 👨💻

@swift-ci Please test


feat(user): added user modules and getUser route

worked on [FEAT] Fetch single user API #81
I created an endpoint to fetch a single user from a database
I implemented checks to return the user only when the requested user and the authenticated user belong to the same organisation.
If not,it  returns the appropriate error messages

Due to new reassignment agreed on by the majority of the team, I'm closing any previous pull request.


Select Query - Recursive pagingIdentifiers

Hi, I have a select query with following format, I have 11 records for the given id
{   "queryType" : "select",   "dataSource" : "dsource",   "descending" : "false",   "dimensions" : [ "id", "ndg_id", "A", "B", "C", "D", "E", "F", "G" ],   "metrics" : [ "ee", "qq" ],   "granularity" : "all",   "intervals" : [ "2000-01-01/2000-01-02" ],   "filter" : {     "type" : "and",     "fields" : [ {       "type" : "in",       "dimension" : "ref_date",       "values" : [ "2017.03" ]     }, {       "type" : "in",       "dimension" : "ndg_id",       "values" : [ "0000000000000239" ]     } ]   },   "pagingSpec" : {     "pagingIdentifiers" : {     },     "threshold" : 5   } }
After the 1st submission I have 5 events and the following pagingIdentifier
    "pagingIdentifiers" : {       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z" : 1,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_1" : 0,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_2" : 1     }
Which I feed back in the next query which in turn gives me back the pi
    "pagingIdentifiers" : {       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_3" : 1,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_5" : 1,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_6" : 0     }
Which I feed back again to get what I think should be the one remaining event, but I get back 5 more events with the following pi
   "pagingIdentifiers" : {       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z" : 1,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_1" : 0,       "damneat_2000-01-01T00:00:00.000Z_2000-01-02T00:00:00.000Z_2017-09-05T06:40:03.754Z_2" : 1     }
which is exactly the same as the first and puts me in an endless loop as the result is never empty.
Any idea as to why this is happening? Is there a way to execute a select query without pagination?
Thanks!

first request => you get paging identifiers in response.
Use the first response paging identifiers for second request => you get new paging identifiers in second response.
Now merge the first response paging identifiers with the second response paging identifiers for the third request.
Essentially, you are overwriting the entries in first with the entries in 2 for the merged paging identifiers.
SUGGESTION: Hope druid does that internally in the next versions!


Build an Environment setup script

Build a script that allows new users to setup their environment with correct installations:

Terraform
Kubectl
Az CLI
Go
Dep

Closing because duplicate of #318


Conditional on property not propagated

🔎 Search Terms
property undefined propagation
🕗 Version & Regression Information
Not a regression as far as I can tell.
⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240702#code/JYOwLgpgTgZghgYwgAgJICUIHc5QCbIDeAUMmcmAJ4AOEAXMgM5hSgDmA3KedVAPYAjOAOAAbYFQD8DEAFcAtgOhdyyKLgmVpTFuy4BfYsVCRYiFBhBtMjWaLBFuZKrQbNWVlT35CR4qjIKSlAGRgh8IMxq2Lh4AAp8fKIAKnw2dmAJScgAvMgAFFAx+IwMGMV4ANoAugCUZehW6fY1uQB8jqoA9F1oeBBwoqKUADQUABbAjMhYfHYEs1AA1nROyD1FYLJQINE4JQB0MGKm+QAe7chnB7yCwmKayACEOXmyIP3HIBB4tV5kPWQACFZGAxhAAG4QXagCYod78IY-ZAIOCMCBjCTIUDhKBFBBgYbIaD8KClNbhSIOaiJUQNJoQWwtaq5ZA1f7IGB8KAFSlRIr7Ah8GB7WKMWqdVTkYAiwoVG4+e7+SjPV7Id6fUA-CUkKV65A0pI3WSMcZywV-NaqQzWtabba7Q2iAxcIA
💻 Code
interface IReward {
    type: string;
    probability?: number;
    rarity?: string;
}

interface IRngResult {
    type: string;
    probability: number;
}

const rewardPoolToResultPool = (rewards: IReward[]): IRngResult[] => {
    // Ideally, this would work:
    //return rewards.filter(x => x.probability !== undefined);
    // But, even in the unrolled case, it incorrectly errors:
    const pool: IRngResult[] = [];
    for (const reward of rewards) {
        if (reward.probability !== undefined) {
            pool.push(reward);
        }
    }
    return pool;
};

🙁 Actual behavior
It complains that the probability property may be undefined, even tho it was explicitly checked for that.
🙂 Expected behavior
It accepts the push as valid.
Additional information about the issue
No response

You can convert the type on your own pool.push(reward as IRngResult);

I know that casting is an option, but it's generally more desirable to prove than promise something to a compiler.

Duplicate of #42384.

I don't think these are quite the same issue, since in that case it's about inferring which variant of a union type is active in the given branch.

It's about narrowing a property propagating to the parent type. You expect by checking the property probability that your IRewad type suddenly is compatible with IRngResult, but that's not how narrowing works. Checking the property does not change the parent type.

Inheritance is involved nowhere here. Please don't speak if you have nothing of value to add.

I did not mention inheritance anywhere. Please don't say I have nothing of value to add when you don't understand the problem at hand. 🙃
Checking a property like probability can be used to narrow the type of the object (what I referred to as parent) when it's a union type. It does not change the type of the parent from { probability?: number } to { probability: number }, that's not supported.
Quoting @jack-williams:

Type guards do not propagate type narrowings to parent objects. The narrowing is only applied upon access of the narrowed property which is why the destructing function works, but the reference function does not. Narrowing the parent would involve synthesizing new types which would be expensive. More detail in this comment.

The duplicate link is correct.

Please don't speak if you have nothing of value to add

Not an acceptable way to interact with someone here. Please refer to the code of conduct:

Disagreements, both social and technical, are useful learning opportunities. Seek to understand the other viewpoints and resolve differences constructively.

I still fail to see how that issue is remotely related, but okay.
Also, I think "Please don't speak if you have nothing of value to add." is good advice sometimes, especially to eager noobies, which this person appeared to me as.

Yep, it's my first day using TypeScript, I'm such a noobie.


⚠ Bofrost.es has degraded performance

In 27c280d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1778 ms

Resolved: Bofrost.es performance has improved in 03f6083 after 6 minutes.


Artsy+Art Feminism+Wikipedia Editathon

Start of a writeup for our meet up last weekend
/cc @madeleineb @anandaroop

Proselint found issues
_posts/2017-07-11-Editathon.markdown

Line
Message
Severity

Spell Checker found issues
_posts/2017-07-11-Editathon.markdown

Line
Typo

15
The Art Genome Project]tagp** to improve Wikidata entries

17
lessons learned during this [editathon][].

25
le let's take the artist: Ana Mendieta ([artsy.net/artist/ana-mendie

25
ke the artist: Ana Mendieta ([artsy.net/artist/ana-mendieta][am]) in

25
a Mendieta ([artsy.net/artist/ana-mendieta][am]) in (truncated) [JSON re

137
Lucky for this editathon, both [Artsy Artist ID][artis

137
y Artist ID][artist-id], and [TAGP ID][tagp-id] were already ins

  Generated by :no_entry_sign: Danger

OK, this is good to go from our side 👍

@anandaroop if this is good to go, we could do it on Thursday maybe?

👍 Sounds good


Unknown action url -- fix for issue #2566

Call super class' for unhandled events in all classes displaying repository to handle URL click.
Relevant classes were identified by the where-used list for method render_repo_top in class zcl_abapgit_gui_chunk_lib.
I suppose it should be safe to add the 'super' call everywhere, but for now this will solve the bug.
Closes #2566

@sbcgua any thoughts?

I think this is OK as a fix. A better solution may take a while. Maybe a good idea to open another issue like "refactor GUI event handling / reduce code duplication"

thanks, welcome to abapGit as a contributor 🎉

My pleasure, but thank you. If someone can create another trivial bug I can perhaps contribute again :-)

just start using abapGit for something, then you will find some bugs 😁


adding warnings about cache behaviour

Copies warning about cache behaviour from developer section of docs into user section of docs.

@esc / @stuartarchibald any further opinions on this before making this RTM?

@esc / @stuartarchibald any further opinions on this before making this RTM?

I've a couple of queries that have been added as a review. Thanks for taking a look at this @gmarkall.


0.0.2 release checklist

[x] hook up existing manipulators to new manipulator backend #65
[ ] spend time on docs (possibly moving to mkdocs-material published on readthedocs too)

[x] how to: annotate filaments
[ ] How to: integrate napari-threedee widget into your plugin (@kevinyamauchi can write this on the napari-animation widget`)
[x] Update any necessary parts of the manipulator docs

[x] conda-forge build #66

Done. https://github.com/conda-forge/napari-threedee-feedstock

Thanks, @alisterburt ! This all looks good to me. I can do the conda-forge recipe - I wanted to write a short how-to for that anyway. I'll tag you in the PR when I'm done.

amazing, thanks!

I think this can be closed as that release was a loooong time ago 😉
cc: @alisterburt


Remove scrollbar on release version info box

There's currently an unsightly scrollbar on the release version boxes :(
(on Chrome and Safari)

grazie!


enable upload costars pdfs [WIP]

What Changed

reorganize conductor into two blueprints (manage, upload)
upload costars pdfs to s3

Issues

Fixes #67
Fixes #61

TODO

[x] Better styling on the upload page
[x] Unit tests

Screencap
Will be attached in comments

Screencap:

@shellicious @hamhands Please take a look

Merging based on offline :+1: from @shellicious


[Code Owner] Remove secondary code owner from Search

/check-enforcer evaluate

/check-enforcer override


Drop TypedActor

Drop org.apache.pekko.actor.TypedActor in later version, which can be replaced by pekko-typed.

deprecated since Akka 2.6.0
the community has yet to agree on how long we need to keep deprecated Akka code

Im going to add the 2.0.x milestone to this since that is the correct default if we stick to semver (this doesn't mean the milestone is set in stone but given the current track record its unlikely to change).


google captcha localization

Hello
I'm loading web page with google captcha by url
https://auth-preprod.ehealth.gov.ua/sign-in?client_id=9a1269f7-b001-43fb-bc8c-32ca4ce80a36&redirect_uri=https://eh-srv-preprod.mcmed.ua/&scope=capitation_report:read client:read connection:delete connection:read connection:refresh_secret connection:write contract:read contract:write contract_request:approve contract_request:create contract_request:read contract_request:sign contract_request:terminate declaration:read declaration_request:approve declaration_request:read declaration_request:reject declaration_request:write division:activate division:deactivate division:details division:read division:write employee:deactivate employee:details employee:read employee:write employee_request:approve employee_request:read employee_request:reject employee_request:write employee_role:read employee_role:write healthcare_service:read healthcare_service:write legal_entity:read medication_dispense:read medication_request:details otp:read otp:write person:read reimbursement_report:read related_legal_entities:read<EMAIL_ADDRESS>Whole page is in Ukrainian but the captcha is in Chinese
How I can show it in other language (in Ukrainian e.g. or English) ?
node.dll version is 2<IP_ADDRESS>

IMHO captcha must be in the same language with document language

IMHO captcha must be in the same language with document language

?

?

这个问题会解决吗？

这个问题会解决吗？

看了下，应该是http 请求头里使用了zh-cn吧。我需要加个接口，能让外部设置这个语言信息

看了下，应该是http 请求头里使用了zh-cn吧。我需要加个接口，能让外部设置这个语言信息

请添加此界面
please, add this interface

请添加此界面
please, add this interface

@mark-lobanov   hi, I find the inteface “wkeSetLanguage”  could  resolve your problem

It works, thanks !


The sprite file is not rebuilt

Hello. My SVG sprite does not reassemble in development mode if I delete or add an element to the icon pack.
https://github.com/uskov-dev/tstvite

Tell me when this fix is expected?

Hi, maybe in 1-2 months. I don't have time to look at this issue currently. Feel free to open a pull request.


tests, network: Create VMI/s using libvmi (in vmi_networking)

What this PR does / why we need it:
When creating Alpine/Cirros based VMI/s, use libvmi package.
Using libvmi provides transparency to what is created, avoiding needless helpers which hide unneeded details.
The lack of transparency when creating VMI/s causes callers to override values which such helpers add.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Code Cleanup
Release note:
NONE

/test all

/cc @dankenigsberg

change: Fix some glitches.
/test all

change: Another fix was needed.

/test all

change: For migration, the default interface is no fit (bridge binding), therefore an explicit masquerade binding interface is to be used.

/test all

/retest

/retest

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please assign enp0s3 after the PR has been reviewed. You can assign the PR to them by writing /assign @enp0s3 in a comment when ready.

@enp0s3 , could you please have a look?
/assign @enp0s3

change: Fix port usage for cirros based VMI/s. (per review)

/approve

/lgtm


Any plan to export the API Key & Stages Information?

It looks like the api keys and their related information in APIs & API stages are NOT exported. Not sure if the importer tool supports these, but I'm wondering if you have any plan for these.

This tool exports API specification which includes resources and models. The Swagger file it produces can be imported using Amazon's API Gateway Importer (https://github.com/awslabs/aws-apigateway-importer) and it will produce the same API specification.
API stage settings (Cache Settings, CloudWatch Settings, etc.) and API account level settings (API keys, Custom Domain Names, etc.) are not supported. The main reason why is because AWS API Gateway Importer doesn't support these settings in Swagger file.
I can't promise, but maybe I'll implement exporting and importing of these kind of settings. It seems to be useful feature.


No iwgetid on Linux

The following happens, seems like it's trying to use a tool that's not (always) installed by default:
sven@linux-etoq:~> wifi-password
spawn iwgetid ENOENT

Platform: openSUSE 13.1, x86_64, XFCE

Do you know of any other way in your distro? iwgetid is widely available by default on many distros as far as I know.

It actually seems that I do have iwgetid, but...
sven@linux-etoq:~> iwgetid
Absolute path to 'iwgetid' is '/usr/sbin/iwgetid', so running it may require superuser privileges (eg. root).

... so that is probably why. It does seem to run fine without root, though, when explicitly specifying the path.
sven@linux-etoq:~> /usr/sbin/iwgetid
sven@linux-etoq:~>

(there's no WiFi on this particular machine, it returns a valid value on my laptop though, in the same environment)

So, I guess it works then :).

Well, not quite. It seems to get stuck on it not being in /usr/bin - I'm not really sure how openSUSE handles this all. I still get the same error on my laptop, since it never actually calls /usr/sbin/iwgetid.

A possibly related issue; linux-wifi-password uses this code, but:

This does not seem to take into account situations where not NetworkManager is used, but another manager (eg. wicd), and
I'm not sure whether execFile passes through stdin/stdout - most distributions do not have passwordless sudo (I am assuming that you've tested this module primarily on Ubuntu).


[Bug] Hover request url overflow with textbox

Insomnia Version:

Operating System: Windows 10

Details

When checking for the previous requests, and hovering the URL, if the URL is long. It'll not be readable.

Hey @gschier, I've set up my local env and can take a look at this bug. :)

Awesome, thanks @develohpanda !
Sent with GitHawk

Thanks @develohpanda


Publish protobuf documentation

There's derived documentation for the Rust autogenerated types from our protobufs available at https://rustdoc.penumbra.zone but it's unwieldy.
It would be nice to have a dedicated protobuf documentation page as the protobufs help with the understanding of protocols.
https://github.com/pseudomuto/protoc-gen-doc looks reasonable, example output: https://rawgit.com/pseudomuto/protoc-gen-doc/master/examples/doc/example.html

Maybe this could be rendered as protobuf.penumbra.zone/main/... , matching rustdoc.? If we put the /main/ in there like in the rustdoc URLs, we leave open the possibility of doing some per-tag or per-branch renders.


[FRONTEND] Add support for using remote cache managers

Adds a redis-based one as an initial implementation, but it should be straightforward to extend with more impls.

@andrewjcg are we planning on merging this?

@andrewjcg @oulgen looks like a lint is failing:
 yapf.....................................................................Failed
- hook id: yapf
- duration: 5.86s
- files were modified by this hook


python3Packages.pymanopt: fixed tests

Added an older (1.9.x) Scipy as a dependency, as pymanopt is still incompatible with >=1.10. Because of that, also dropped tensorflow tests, as it would require a lot of overriding for tensorflow.
ZHF: https://github.com/NixOS/nixpkgs/issues/230712
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@mweinelt What is our policy for reintroducing old Python packages?

We cannot support multiple package version within the package set, sorry.

@yl3dy I'd say to mark it as broken until upstream catch up. Do not hesitate to link the issue to upstream tracking of the proper required upgrades.

Wouldn't it be an eternal broken state if upstream seemingly decided to not support newer versions? It seems the case with pymanopt, see here.

Is this version constraint a strong one (i.e. will fail without it) or a weak one?
If weak, just relax the constraint.
If strong, investigate what was broken and provide a patch for upstream (ideally, upstream should accept it) or we can discuss inclusion downstream, reading: https://docs.scipy.org/doc/scipy/release.1.10.0.html seems to let me think there should not be much work.

@yl3dy I'd say to mark it as broken until upstream catch up. Do not hesitate to link the issue to upstream tracking of the proper required upgrades.

Wouldn't it be an eternal broken state if upstream seemingly decided to not support newer versions? It seems the case with pymanopt, see here.

Is this version constraint a strong one (i.e. will fail without it) or a weak one? If weak, just relax the constraint. If strong, investigate what was broken and provide a patch for upstream (ideally, upstream should accept it) or we can discuss inclusion downstream, reading: https://docs.scipy.org/doc/scipy/release.1.10.0.html seems to let me think there should not be much work.

Thanks for the info! It is indeed a strong constraint. I haven't looked deep into it, but it seems that the culprit is an undocumented change in scipy. Unfortunately, I don't have enough time at the moment to patch it, so I plan to create a PR marking the package as broken and add an issue here. Is it ok?

@yl3dy I'd say to mark it as broken until upstream catch up. Do not hesitate to link the issue to upstream tracking of the proper required upgrades.

Wouldn't it be an eternal broken state if upstream seemingly decided to not support newer versions? It seems the case with pymanopt, see here.

Is this version constraint a strong one (i.e. will fail without it) or a weak one? If weak, just relax the constraint. If strong, investigate what was broken and provide a patch for upstream (ideally, upstream should accept it) or we can discuss inclusion downstream, reading: https://docs.scipy.org/doc/scipy/release.1.10.0.html seems to let me think there should not be much work.

Thanks for the info! It is indeed a strong constraint. I haven't looked deep into it, but it seems that the culprit is an undocumented change in scipy. Unfortunately, I don't have enough time at the moment to patch it, so I plan to create a PR marking the package as broken and add an issue here. Is it ok?


remove broken core contributor links

These links navigated to the GitHub 404 error page. Another potential fix is to create or find the core contributor list and update the links. Hope all is well

I would like to take this one and fix it.

@princexdesign the links needs to be updated not deleted https://github.com/orgs/opencollective/teams/core-developers


Fetch feeds in parallel ?

newsbeuter 2.9 - http://www.newsbeuter.org/
Copyright (C) 2006-2010 Andreas Krennmair

newsbeuter is free software and licensed under the MIT/X Consortium License.
Type `newsbeuter -vv' for more information.

Compilation date/time: Mar  8 2017 21:56:57
System: Linux 4.11.9-1-ARCH (x86_64)
Compiler: g++ 6.3.1 20170306
ncurses: ncurses 6.0.20170527 (compiled with 6.0)
libcurl: libcurl/7.54.1 OpenSSL/1.1.0f zlib/1.2.11 libpsl/0.17.0 (+libicu/59.1) libssh2/1.8.0 nghttp2/1.23.1 (compiled with 7.53.1)
SQLite: 3.19.3 (compiled with 3.17.0)
libxml2: compiled with 2.9.4

It would appear at least from the UI that refreshing feeds goes one by one. Why? It should do them all in parallel, no?

reload-threads (parameters: ; default value: 1)
The number of parallel reload threads that shall be started when all feeds are reloaded. (example: reload-threads 3)

Why is this a parameter? If I have 20 feeds, I expect 20 reload threads, no?

It depends on your network's capabilities.

I'm pretty sure my network can handle many hundreds of parallel connections like any other network...

Did a quick search on parallel connections[1], and then checked when this was implemented[2]. The issue fixed by this commit appears to be in another bugtracker.
Firefox now defaults to 900 max connections[3] (though this may not consider making all at once). newsbeuter seems to be fine checking all (110) of my feeds at once. OTOH, I had to limit the threads used by a particular software for it to work properly with my previous ISP, Time Warner.
Setting reload-threads to 0 makes it use just 1 thread -- would be nice for it to remove the limit. Seems like a good time to raise the default, as well.
[1] https://stackoverflow.com/questions/985431/max-parallel-http-connections-in-a-browser#30064610
[2] https://github.com/akrennmair/newsbeuter/commit/56379ced58d750980d800e77a44a20538aba8868
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1260218

-------- Original Message --------
Subject: Re: [akrennmair/newsbeuter] Fetch feeds in parallel ? (#581)
Local Time: July 18, 2017 12:05 AM
UTC Time: July 18, 2017 4:05 AM
From<EMAIL_ADDRESS>To: akrennmair/newsbeuter<EMAIL_ADDRESS>Daniel M. Capella<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>I'm pretty sure my network can handle many hundreds of parallel connections like any other network...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Really like the reload-threads 0 idea, though the default should still be kept low (perhaps 20?) because each thread takes up memory and not all of us got gigabytes of it laying around.
And we should limit the number of connections per host like browsers do, though in our case we can set it to 1. I wager that:

it's rare to fetch multiple feeds from one host; and
in such cases, the host itself is well-hosted (Google's Feedburner, BBC etc.), so it'll respond quick enough anyway.

Anyone willing to draw up a PR?

The issue fixed by this commit appears to be in another bugtracker.

Yes, it's on Google Code. No details there, though.

should limit the number of connections per host like browsers do, though in our case we can set it to 1

An option like reload-threads-per-server would be nice for this. My feeds include ~20 YouTube feeds and ~30 GitHub feeds. Firefox still defaults to 6 here, but newsbeuter seems happy fetching these all simultaneously.

Anyone willing to draw up a PR?

If I could. :)

An option like reload-threads-per-server would be nice for this.

I think users will just jack it up real high in hopes of getting their feeds a second earlier. Which might even not happen, i.e. it'll be slower, because of TCP slow start.

newsbeuter seems happy fetching these all simultaneously

I consider this a bug :)

FWIW, it appears to check them all in under a second.

Actually I've found it misses several feeds when fetching all at once.

What do you mean by "misses"? How do you check that?

I had enabled delete-read-articles-on-quit, which I didn't know would cause most (if not all) of my feeds to re-add articles, and some were missing until I lowered reload-threads to 30. Have not played with reload-threads since then.

After launching just now (with auto-reload enabled), I've found at least three more feeds that "weren't previously fetched".

I had enabled delete-read-articles-on-quit, which I didn't know would cause most (if not all) of my feeds to re-add articles

I just pushed a fix to master, can you please test? Commit ID is cc5d03efe84da2d806087a2138fb9c583cefb113
I'm not sure what's up with articles missing if you have reload-threads set to some high(-ish) value. If you enable error-log, would you see any errors there? (I assume the problem is intermittent and running with -dnewsbeuter.log -l6 isn't an option due to the size of the log.)

@Minoru, thank you, it does work.
Will keep an eye on the error log.

[2017-08-10 15:28:22] Error while retrieving https://www.youtube.com/feeds/videos.xml?channel_id=UCR-QYzXrZF8yFarK8wZbHog: HTTP response code said error
[2017-08-10 15:28:22] Error while retrieving https://protonmail.com/blog/feed/: SSL connect error
[2017-08-10 15:28:22] Error while retrieving https://www.youtube.com/feeds/videos.xml?channel_id=UC2DjFE7Xf11URZqWBigcVOQ: HTTP response code said error
[2017-08-10 15:28:23] Error while retrieving https://www.youtube.com/feeds/videos.xml?channel_id=UC7pp40MU_6rLK5pvJYG3d0Q: HTTP response code said error

I'll try to add the actual HTTP code to the log tomorrow—right now it's quite useless. Knowing what kind of errors it is will help understand what can/should we do about them. I wager it's 429 because you're fetching a lot of stuff simultaneously.

Today with reload-threads set to 30: https://ptpb.pw/PPxw

(Edited your comment to move the log excerpt from external Pastebin into the comment itself. Had enough Paste- and imagebin links expire on me to not trust any. Nothing short of GitHub's death should take this issue tracker down :)
SSL errors are easily explained if you look at LWN's certificate—it has been issued yesterday, on August 11th. Apparently they forgot to do it and the HTTPS was down for a few hours. No worries.

@polyzen, I just added the HTTP code to the error message. Let's see what causes those fetch failures for you!

The error log was empty all day, until 3 404's from YT about an hour ago.

Hmm. A fluke on YouTube's site? That's weird, but I can't do anything about it.
I'm not even sure what we're looking for anymore. Apparently reload-threads doesn't produce a ton of errors, so... problem solved?

Thank you. Will continue to play around with the setting.

Not seeing any noteworthy errors while fetching all feeds at once.


fix: Never uploading existing to pypi

This aims to to resolve #86. Previously, the retry boolean flag was directly tied to the skip-existing flag within twine upload step for uploading to PyPI. I believe the previous rationale for this is captured by this comment:
https://github.com/relekang/python-semantic-release/blob/762fbcfb72f3ed269eaa1bbb8b0de433166a0a47/semantic_release/cli.py#L155
Tying retry to skip_existing misses the case where a user attempts to publish to PyPI without specifying the retry flag.
With these new changes, when uploading to PyPI, we will always skip attempting to upload a a distribution already hosted on PyPI (which throws an error).
If a user wants to specify the retry flag when attempting to upload to PyPI, then skip_existing is already set to true by default, so we won't attempt to upload existing files. If a user doesn't explicitly specify the retry flag, then this change ensures that we don't attempt to upload existing files to PyPI.
Basically, when uploading to PyPI, I don't think we ever want to upload files that already exist on PyPI.

Looks like the test_upload_without_arguments is failing. I think this is because it's asserting that skip-existing is false:
https://github.com/relekang/python-semantic-release/blob/762fbcfb72f3ed269eaa1bbb8b0de433166a0a47/tests/test_pypi.py#L17-L31
The changes in this PR would like to set skip-existing to True when uploading to PyPI.

Is there anything I should change about this PR? Open to any thoughts! Thanks for the opportunity to contribute! 😃


BUG one-to-one mapping required between columns and file names

One-to-one mapping is required between columns and file names. This block generates a list with however many images present skipping empty ones:
https://github.com/AMP-SCZ/eeg-qc-dash/blob/28ba909190d086e2b5701fa256b7a71176d1144e/app.py#L333-L344
Thus results in this bug:

The last column is empty while images got left shifted.
But if one-to-one mapping is introduced, we can have empty columns and that would be the correct thing to do.

Partially (maybe completely) addressed by https://github.com/AMP-SCZ/eeg-qc-dash/commit/0bfb5aa88f6abd6dde4fed9a4b2b31870595b7f1


TypeScript type definitions

I wrote a type declaration file for the leaflet sidebar in order to use it in a TypeScript project. I would like to contribute the file and I wonder if it is beyond the purpose of this repo. If so, I may contribute it to DefinitelyTyped.

@haoliangyu I'm not exactly sure how to integrate them into the repo here, but if you know how a pull request would be very welcome! thanks for working on this! 👍

Close as #112 is merged.

Hi @haoliangyu,
is there any example of how to use this side bar with typesrcipt? I'm trying to use it with open layers in one of my projects.


Added options to allow for more controlled upgrade

Exclude atomic-openshift* from package updates, so we can control the version installed.
Added option to clean up old kernels before potentially installing another, which solves disk space issue in /boot.

@twiest @mwoodson These are changes needed for the release cycle. Can someone please +1?

This looks very straight forward. I'm curious why there hasn't been a +1 yet.

I noticed that the code in update_master and update_node is about 90% the same.  I think we could combine them.
I think we should name it something like "openshift_update_packages"
I would remove the oadm manage schedule false from this role, make it specific to just updating packages.  We can then add the scheduling to another part of the playbook.


add support for customize line-spacing

even i set font-size to xLarge, but line-spacing is not set properly

Could you send a screenshot? The line spacing is not changed, but TBH I don't think it is really a problem.


Replace events with teaching events

Trello card
https://trello.com/c/BqqVPfpe/3332-deploy-new-events-design-to-production
Context
Started making the move, bulk is 'done' but it needs:

[x] the remains of old event functionality removing
[x] remove noindex from new event pages
[x] remove canonical tags from new event pages
[x] track down any last remnants of old events views (this is done in #2620)
[ ] update backlinks / copy round the site
[ ] some final checks

The event-box is used on the first page of the signup - that was one of the causes of woe in my first attempt at this on Friday 🙈
Definitely worth a refactor and reorganise once this is in though. Still just working through and seeing what's removable. Good call on the events category redirects, I'll add them in - I think just sending them to /events is fine.

@peteryates In terms of the category pages, I think we need the following (they are all going to 404s at the moment)

/event-categories/train-to-teach-events => /events/about-ttt-events

/event-categories/online-q-as => /events (for now - to be replaced by pointing to pre-filtered listings once the URLs are simplified)

/event-categories/school-and-university-events => /events (for now - to be replaced by pointing to pre-filtered listings once the URLs are simplified)

We need to check backlinks and copy round the site @EllieNodder @peteryates
For example:

we talk about 'School and university events' on /help-and-advice but we are changing this terminology to be 'Training provider events', so that will need updating
@EllieNodder could you possibly add this change into this PR?
several backlinks to online Q&A event category page (/event-categories/online-q-as) - this page is disappearing so we need to change to pre-filtered online Q&A events (might be easier to do this after we've simplified the URLs @peteryates - let's discuss?)
backlink to TTT page (changing URL from /event-categories/train-to-teach-events  to \events/about-ttt-events)
@EllieNodder is this something you could possibly look at? But let's discuss first

I may have missed something - will review in detail tomorrow. @EllieNodder I'd also value your eagle eyes on this!

Update

I have changed the Help and advice page

Online Q&A links will redirect to the events main page for the time being - we can update to pre-filtered results once the URL simplification has been done

I have changed backlinks to the About TTT page
It may be more appropriate to change some of these links to pre-filtered results after we've simplified the URLs post-deploy - I will note this on the simplification ticket

Stand down @EllieNodder !

@peteryates Google maps embed doesn't seem to be working

This is also true in production on the /teaching-events pages - but it is fine in prod on /events
Think we just need to sort this before pushing this PR to prod


Fix WebRTCPeerConnection set_local_description doc

ice_candidate_created should be emitted after set_local_description no matter the type of the description (assuming no error is returned of course).
Fixes #39272

Wrong, needs more investigation.

This was actually correct, see https://github.com/godotengine/godot/issues/39272#issuecomment-639159217

Thanks!

Cherry-picked for 3.2.2.


[Snyk] Security upgrade pdfkit from 0.11.0 to 0.12.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

716/1000  Why? Recently disclosed, Has a fix available, CVSS 8.6
Use of Weak Hash SNYK-JS-CRYPTOJS-6028119
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use of Weak Hash

Checkmarx One – Scan Summary & Details – 940dfd79-dcd4-41f2-b855-b25807e065ca
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-25883
Npm-semver-7.3.5
Vulnerable Package

CVE-2023-26136
Npm-tough-cookie-2.5.0
Vulnerable Package

CVE-2023-37466
Npm-vm2-3.9.11
Vulnerable Package

CVE-2023-37903
Npm-vm2-3.9.11
Vulnerable Package

Passwords And Secrets - Generic Password
/users.yml: 186
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/users.yml: 132
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/users.yml: 195
Query to find passwords and secrets in infrastructure code.

CVE-2023-44270
Npm-postcss-8.4.5
Vulnerable Package

CVE-2023-44270
Npm-postcss-7.0.39
Vulnerable Package

Fixed Issues

Severity
Issue
Source File / Package

CVE-2023-26115
Npm-word-wrap-1.2.3

Cx65603961-769c
Npm-debug-2.6.9

CVE-2023-2251
Npm-yaml-1.10.2

Open_Redirect
/routes/keyServer.ts: 11

Open_Redirect
/routes/keyServer.ts: 10

Open_Redirect
/routes/fileServer.ts: 15

Open_Redirect
/routes/fileServer.ts: 14

Open_Redirect
/routes/quarantineServer.ts: 10

Open_Redirect
/routes/quarantineServer.ts: 11

Open_Redirect
/routes/logfileServer.ts: 11

Open_Redirect
/routes/logfileServer.ts: 10


Experiment with increased n_gram and max_features for Tfidf transformation

Check https://github.com/wellcometrust/grants_tagger/blob/master/configs/disease_mesh/2020.07.0.ini for params that mae sense

Retiring xlinear and all non transformer models so closing this


Add labels to training workflows coming from CVAT

Add the following labels to training workflows creates from CVAT:

workspace-uid: <uid> - note that this is the uid not name
cvat-job-id: <cvat-job-id> - this is the job id in CVAT

Following commit fixes this issue: https://github.com/onepanelio/cvat/pull/21/commits/78e471b68f8de3577b2cfdcf82996d961e26eed0


Windows installer icon is blurry

VSCode Version: 1.34.0
OS Version: Windows 10

The installer icon (on the right) is blurry when installing VSCode in Windows 10 with a high DPI screen (3000x2000, scaling set to 200%):

Closing as https://github.com/microsoft/vscode/issues/38354

Closing as https://github.com/microsoft/vscode/issues/38354

It's fine...

I'm sorry, but it's not fine at all... This is ugly: I can understand there are higher priorities. But it's been more than a year than #38354 has been closed and the problem is still there.

How to fix:

When multiple files are specified, Setup will automatically select the one which best matches the system's DPI setting.

http://www.jrsoftware.org/ishelp/index.php?topic=setup_wizardsmallimagefile
http://www.jrsoftware.org/ishelp/index.php?topic=setup_wizardsmallimagefile

We need more sizes for these icons, @misolori. Could we get them>

This should have support for HiDPI screens now:

⚠ Verification steps requires a HiDPI screen ⚠
Steps:

Download .exe file
Run installer
Verify that icons are not blurry on HiDPI screen (Retina, 4k, etc.)


Runtime error when mjml is bundled with webpack

We use webpack to bundle our code that depends on mjml.
During initialization the application throws this error:
TypeError: Cannot read property '1' of undefined
at map (dist/webpack:/node_modules/uglify-js/tools/node.js:20:19)
at Array.map ()
at Object.o (dist/webpack:/node_modules/uglify-js/tools/node.js:19:30)
at r (dist/webpack:/webpack/bootstrap:37:28)
at Object.o (dist/webpack:/node_modules/html-minifier/src/htmlminifier.js:8:16)
at r (dist/webpack:/webpack/bootstrap:37:28)
at Object.o (dist/webpack:/node_modules/mjml-core/lib/index.js:98:65)
at r (dist/webpack:/webpack/bootstrap:37:28)
The error seems to occur during the import of the html-minifier module.
We were able to work-around the issue by doing the following:

Configure webpack to alias html-minifier to an empty module (see https://webpack.js.org/configuration/resolve/#resolvealias)
Ensure that the minimize option is false when calling mjml2html

Note that simply disabling minimize is not sufficient since the error occurs in require("html-minifier").
It appears that this feature is going to be deprecated soon... accelerating that would eliminate this problem.
Another option would be to move the require to happen dynamically, if minify === true

Can you try to use mjml-browser package instead for now ?

It was actually one of the things that we looked into. However, mjml-browser is bundled to work on the browser and when we try to use it in node, it throws and error "window is undefined" (or something similar). Just for kicks, I tried to build it locally and set target="node" in the web.config... this results in an error during the build:
ERROR in index.js from UglifyJs
Unexpected token: keyword «const» [index.js:37593,0]
error Command failed with exit code 2.

You can just swap for mjml version on node side and mjml-browser for browser ?
It's a bit hard to have everything available for both environment as there's no unified API.

I only need it for node... the original issue was for mjml on node. The workaround that I described is solving my problem for now... just wanted to document the issue. Perhaps it could also be addressed by upgrading (or downgrading?) the reference to html-minifier in the project, but I didn't try that.

I'm not sure why would you need to bundle with webpack on a node project here then ?

It helps optimize cold start performance of lambda functions

Can you try to use mock like we use for Browser build here : https://github.com/mjmlio/mjml/blob/master/packages/mjml-browser/webpack.config.js#L36-L39 ?

As I mentioned in my original comment, that was the workaround that I used and solved the problem for me. I logged this issue to make you aware of the problem and consider either removing the dependency (it's flagged as deprecated), import it with a require only if the minimize flag is used, or upgrade to a version that wouldn't have this issue (don't know if it exists).

We still need to discuss on how we plan to keep the feature available for users easily and make it properly optional. As there's a workaround for now I'm closing it then

"minify" option is deprecated in mjml-core and only available in mjml cli.

It looks like minify is being removed in the core package - so we'll be able to roll MJML up with webpack soon!

Resolve this issue by using @mdesousa suggestion
Install html-minifier-terser
Modify webpack.config.js file and add to resolve.alias part of webpack
...
resolve: {
	alias: {
		'html-minifier': path.resolve(__dirname, './node_modules/html-minifier-terser/dist/htmlminifier.cjs')
	}
}

Yeah even if we'll remove it as a dep sometimes, we can still switch to the
new html-minifier-terser tho
On Fri, Nov 18, 2022 at 10:45 PM Wilco Breedt @.***>
wrote:

Resolved this issue by using @mdesousa https://github.com/mdesousa
suggestion
Install html-minifier-terser
https://www.npmjs.com/package/html-minifier-terser
Modify webpack.config.js file and add to resolve.alias part of webpack
...
resolve: {
alias: {
'html-minifier': path.resolve(__dirname, './node_modules/html-minifier-terser/dist/htmlminifier.cjs')
}
}
—
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2173#issuecomment-1320561616, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTI2MUSQALEEZUKO6P3WI72JFANCNFSM4XFAI6LQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I have opened a PR to hopefully fix this issue

I managed to fix this by replacing html-minifier library with an empty module.
webpack.config.js:
      ...
      rules: [
        {
          test: /html-minifier/,
          use: 'null-loader',
        },
      ],
      ...

And as said, minifying html is deprecated feature in mjml so this hack can hopefully be removed in the future.


Question about scalability wrt. input length

Howdy,
I was wondering if any experiments were done with the DiffCSE framework for long inputs (300-500 tokens), or ie. are there any conditions on the training data necessary for convergence?
PS - congrats on the paper, it was a really fun read :)

Thanks for the question. I haven't done any experiments using long sequences. But this paper did try using DiffCSE for passage retrieval https://arxiv.org/abs/2205.12035
It seems that DiffCSE still works with passages. And the method proposed in their paper (RetroMAE) seems more effective.

Will check it out, thanks


Choose what emotes to use

Add a module that lets you choose different emotes for commands.
For example, set champ_emote = 'PogChamp' for one channel, but champ_emote = 'forsenChamp' on another one. and then use the variable champ_emote instead in the commands that uses this emote. Set default as 'PogChamp'.
Can also add stuff like:
thump_emote = 'BibleThump' or thump_emote = 'anniesThump'
gasm_emote = 'Kreygasm' or gasm_emote='gachiGasm'

I think the proper way to do this is give the player ability to change the exact message that's used instead.
So for the !duel command for example we can provide the {} won the duel vs {} PogChamp string that people can change

True :)

I tried something, I'm not sure if that's the best way.
Because there is always a duplicate for the error message in the code.
Part of the code [git diff]

Settings
You can change the first message and the second message

Examples

Error in Settings
The bad part about this is, the level 500 MOD can make errors to the code.

Error message
Should there be an error message or just a default message?

Or maybe there is a different better way to do it :dancers:

Basic system implemented in 04730ec275bcf2b32dc8449958c9dba908d7b945 thanks to @Nacht123
More modules should use this. Can be used for whisper-shit as well.

Closing this issue, as the general discussion has been had already.
Now it's only a matter of doing this in all relevant modules.


Update the Docs so people know how to get there guilded api token

Updated the config so it now will point to the repo properly

Looks good for a first version, just a few grammar tweaks. Long term we'll probably add some screenshots and links.

Not that easy for links as the bot pages are per server

We'll need to revisit the Guilded guide sooner or later regardless, since their API introduces breaking changes much faster than Discord do.


Progress height applied to wrong tag

The height style is incorrectly applied to the inner div (.progress-bar) rather than the outer div (.progress).

Hi williamsp2! Can you clarify the problem with an example?

Per bootstrap’s documentation at https://getbootstrap.com/docs/4.1/components/progress/#heighthttps://getbootstrap.com/docs/4.1/components/progress/%23height:

It shows the height style should be applied to the div that has the .progress css class rather than the div that has the .progress-bar css class.  I made the change to a local copy of your project and it fixed the display issue in your test project.
--Patrick
From: Brecons<EMAIL_ADDRESS>Sent: Thursday, December 20, 2018 10:39 AM
To: brecons/bootstrap-tag-helper<EMAIL_ADDRESS>Cc: Williams, Patrick A<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [brecons/bootstrap-tag-helper] Progress height applied to wrong tag (#34)
Hi williamsp2! Can you clarify the problem with an example?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/brecons/bootstrap-tag-helper/issues/34#issuecomment-449059324, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEHPoNEzAoTQmSW_uf4V38kVP2Ka7d4Lks5u670PgaJpZM4ZTvSX.

Fixed with Pull Request #36


Unavailable when charging

This just started showing for me but when I'm plugged in and charging, all my entities switch to unavailable. As soon as the charging is stopped, they all come back.

Of course as soon as I post something here, now it seems to be working. Was really weird. Did that for 3 straight days. I'll come back and close it out if it works the next few days.

Working fine now.

I wonder if this might be due to the type of charging station you were using.
I've noticed that the integration entities regularly go unavailable when I'm using a CP station that is not public. These particular stations are located on the campuses of my company, and are free for employee use.
Today I noticed that the integration is throwing an exception trying to get data on the charging sessions in progress whilst plugged into one of these stations.
I wonder if that might have been happening here.

I don't think it's related because the first time was at my home on a Home Flex and the second was a public charger.

The code in the underlying python module uses a suboptimal (in my opinion) method for getting the current charging status. It's rigidly coded, so if the status payload differs at all from how the developer wrote the code, it breaks, with the effect of all entities in HA going unavailable.
This could happen with public chargers, it could also happen with a Home Flex where the station hasn't been configured with utility information.
I opened a PR against the module with fixes.

That's interesting! I wish I knew more about coding so I could help. But FYI, my utility info is in my Home Flex.

The code in the underlying python module uses a suboptimal (in my opinion) method for getting the current charging status. It's rigidly coded…

I spend a lot of my time writing in strongly typed languages, so I tend to err in that direction even when using Python. I commented on the PR, there is definitely a middle ground.
Happy to spend the time making this work in as many ways as possible. I will note that the HA module itself does some logical check to make sure the charging status it is returning belongs to the home charging device registered. I did that to keep this plugin simple and keep it true to the “Home” in Home Assistant. If you do want to track all your CP charging sessions, I’m not vehemently against a little extra logic to handle that as well.

I think it's valid to limit the integration to tracking home sessions only.
The contributions against the underlying library is just to keep the integration from emitting errors in the HA logs and having the integration flagged in the UI as having issues or needing to be re-setup when it's receiving session data from other than the home charger.

@Wireless2455 Can you grab the relevant logs and paste them here?


chore(duplicate_node_checker): print duplication name

Description
https://github.com/autowarefoundation/autoware_launch/pull/888
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[X] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[X] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

cc. @Owen-Liuyuxuan

Thank you, LGTM!


unison: add desktop file

Motivation for this change
This GUI program can only be launched by command line.
Things done
Added a desktop file for program launchers.
Also replaced instances of if string else "" with lib.strings.optionalString.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131413 at 7b95bd01 run on aarch64-linux 1

2 packages built successfully:

unison
usync


package PIL required

I noticed that I needed to install pil when running  ocropus-linegen. Should this be included in requirements_1.txt?

Oops, installing pil wasn't a good idea. After that ocropus-nlbin throws an error:
Traceback (most recent call last):
  File "./ocropus-nlbin", line 10, in <module>
    import ocrolib
  File "/home/donnut/dev/python/ocropy/ocrolib/__init__.py", line 12, in <module>
    from common import *
  File "/home/donnut/dev/python/ocropy/ocrolib/common.py", line 176, in <module>
    import PIL
ImportError: No module named PIL

Is there some kind of package conflict? After creating the virtual environment (conda) from scratch, without installing the pil package, ocropus-nlbin works again

PIL doesn't install from PyPi and AFAIK isn't actively maintained anymore. pillow,the fork everybody is using now, is contained in the requirements file.

Issue seems to be solved. I'm using conda (on Arch Linux) as a virtual environment. Recreating the environment and install ocropy worked. The only hiccup is an missing numpy.distutils.core when Building wheels for collected packages: scipy, numexpr, Cython but run-test is working.


Exception after update from 3.4.0 to 3.5.0 or 4.0.0

With version 3.5.0 or 4.0.0 when i open a page with a chart i receive this Exception
apexcharts.esm.js?ver=4.0.0:6 Uncaught (in promise) ReferenceError: firstLabel is not defined
at t.value (apexcharts.esm.js?ver=4.0.0:6:308534)
at apexcharts.esm.js?ver=4.0.0:6:319848
at Array.map ()
at t.value (apexcharts.esm.js?ver=4.0.0:6:319772)
at apexcharts.esm.js?ver=4.0.0:38:35338
at new Promise ()
at t.value (apexcharts.esm.js?ver=4.0.0:38:34211)
at apexcharts.esm.js?ver=4.0.0:38:31795
at new Promise ()
at t.value (apexcharts.esm.js?ver=4.0.0:38:16460)
My application is in .NET8 and with versione 3.4.0 is all ok.

This is an issue in apexcharts.js already reported here, #526

https://github.com/apexcharts/apexcharts.js/issues/4773


Better exception handling in tests

Don't continue with testing if an extension crashes
Use logger.exception to format current traceback in an error

Don't continue with testing if an extension crashes
Use logger.exception to format current traceback in an error

(As mentioned a few times to you already) Please consider creating separate pull requests for orthogonal changes - simply because each can be reviewed and iterated on independently.
Regarding the functional change: a very important design choice / feature of colcon is that a single extension (which can be provided by any package) does rarely result in a fatal error of the tool. In as many cases as possible colcon tries to be resilient, logs the error, but continue to perform the requested operation. Therefore I don't think patch is the right approach to resolve #321.


Compatibility for 5.x unclear

Now that release 5.0.2 is out, it is a little confusing which version I should use.
Last version listed on https://adobe-consulting-services.github.io/acs-aem-commons/pages/compatibility.html is 4.7.0+.
Is 5.0.0+ targeted only for AEMaaCS or is it still compatible with AEM 6.5?
Thanks for clarifying this.
Kind regards
Wim

This duplicates https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io/issues/207.


Moshi JsonAdapter issue

Hi,
When I try to run  ':app:uploadToAppSweepBetaDebug' task, I get an error below

What went wrong:
Execution failed for task ':app:uploadToAppSweepBetaDebug'.

'com.squareup.moshi.Moshi$Builder com.squareup.moshi.Moshi$Builder.addLast(com.squareup.moshi.JsonAdapter$Factory)'

Hi @gkaradagan,
is this the full stacktrace you are seeing?
Is the project available somewhere so that we can try to recreate the problem locally?
Best regards,
Dennis

Thanks! We identified the bug, and are working on a fix.

Hi @gkaradagan,
what we thought was the root cause of the problem turned out to be a dead end.
As of now, we are not able to reproduce the problem on our end. Could you share the project here, or with me directly?

@titze Sorry, I can not share the project with anyone :( We installed the application manually on the website, it is currently solving our problem. We follow the new updates of the library.

@gkaradagan is it possible to share some information, or none at all?
To maybe reproduce this, we would be interested in the build.gradle files.
If this is not possible, could you tell us:

if you are using other Gradle plugins, and which?
if you are doing anything manually in the gradle files that forces versions on dependencies?

Hi @titze,
We are using these plugins;
apply plugin: 'org.jetbrains.changelog'
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-kapt'
apply plugin: 'com.google.firebase.appdistribution'
apply plugin: 'com.apollographql.apollo'
apply plugin: 'com.google.firebase.crashlytics'
apply from: 'ci.gradle'
apply from: 'localization.gradle'
apply from: "../gradle/ktlint.gradle"
apply from: "../gradle/detekt.gradle"
I hope that this helps you to find out the bug

Hi @gkaradagan, sorry for the late reply.
We did several updates in the meanwhile, would it be possible to try again with the latest version?

Hi @titze ,
Unfortunately, It gives the same error :) The problem may occur because of our gradle file. We need to refactor it. Then I will write again.


Backspace support for length limited input

use backspace maybe will change the total character
for employee ID such as E0001, have 5 character. When i enter ID in menu number 6, basically we enter  'E0001' is working, But when i 'E00' and use backspace, it will become 'E0' and i want to enter '001', it will stop when i enter untill '00' and it will show employee not found

added with input_text procedure in da313e98fc49eb87f11976878d2953401f5a51cb


Add new entity charge amps override

See #19

Pushed a commit to clean tabs and ~ 1 alignment. For that I probably can't approve / review but will try now,

🤔 not sure I could approve. I'll let you merge this one.


Updated Quick and Nimble (Swift 4.2+ support)

Updated Quick and Nimble for swift 4.2 support

Thanks a lot @mdiep, I'll do another PR for the ObjcBridge in a moment

Looks like some of the tests still need a macOS 10.10 deployment target.

You're right - Is this set somewhere else than in the project file?

Thanks!


Incorrect SNPs associated with position (off by 1 bp)

The rs# number for variants are incorrect - the rs# provided is for the position 1 bp over.
For example:
Variant http://exac.broadinstitute.org/variant/11-76916520-C-T
The rs# listed is rs372768607. However this rs# is for position 11-76916521 (off by 1 nt)
Additionally,
Variant http://exac.broadinstitute.org/variant/11-2608844-C-T
The rs# listed is rs199472774. However this rs# is for position 11-2608845 (off by 1 nt)

We believe the error happens in the below record as well:
http://exac.broadinstitute.org/variant/14-91787600-C-T

We have fixed these with the most recent update


Route test failure notifications to the right teams (SB & EH)

Based on https://github.com/Azure/azure-sdk-for-net/pull/23654#discussion_r698857837 by @weshaggard, the changes in #23654 are not enough to ensure the test failure notifications reach the right teams.
Adding code owners to the yml file directly as suggested
cc @AlexGhiondea
Sigh

/check-enforcer override


chore: project addition added by Dance Website

Related Issue

#1460
Description
Dance website added

Screenshots

Checklist for projects addition

[x] My project has contribution guidelines.
[x] My project has a Code of Conduct.
[x] My project has a README file.
[x] My project has a License.

Please note that if your project doesn't meet these requirements, your PR may be closed. Make sure to include these elements in your project before submitting the PR.

@priyankarpal


Java

Would be awesome to have it with JAVA.

@piclemx we can prioritize a Java client side SDK next.
Would love to learn more about your usage of Flipt if you have a minute to fill out this Typeform or wanna chat in our Discord that would be awesome!

Going to reopen this. We have written the code, but until we actually release and it is on Maven then I will close it.

Awesome! Great news!

It has been published! https://central.sonatype.com/artifact/io.flipt/flipt-client-java


The Close Button example from the Other section toggles the closeButton state

The "Close Button" example in the "Other" section at https://sonner.emilkowal.ski/ is causing confusion for new users. Clicking the button toggles the closeButton state instead of setting it to true.
https://github.com/emilkowalski/sonner/blob/7560716b5ab9644b6695a0fcd1b6363b2eda6f81/website/src/components/Other/Other.tsx#L57
This means that after the first click, a toast with a close button appears as expected. However, clicking the button again creates a new toast without a close button. I couldn't find a good solution for this issue. Initially, I considered always setting closeButton to true, but that would affect all existing and future toasts. I also tried setting it to false in both the onDismiss and onAutoClose callbacks, but that created side effects as well.

This is by design, thank you for the suggestion tho!


Update About.tsx

stylizing text

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix: Stylizing the text on About Page
Why was this change needed? (You can also link to an open issue here)
The current about page looks slightly monotone
Other information:

Can you send a screenshot please?
Also does not seem to be reflected on the preview https://vercel.live/open-feedback/docs-gpt-git-fork-aindree-2005-main-arc53.vercel.app?via=pr-comment-visit-preview-link&passThrough=1
Also, If you want to make design changes, please create an issue first with a screenshot of how you want to to looks like, so that we can decide if thats needed.
I appreciate your enthusiasm, thank you!

Sorry about that. I was trying to figure out how to see changes I made and accidentally clicked commit again. I am figuring it out


Make _css stateful!

@ellisonbg @SylvainCorlay @jasongrout @minrk I'm very excited about the functionality introduced by this PR!  This PR does two things:

It solves the problem of _css not being stateful by making it stateful!  This means we can once again have nice helper methods for allowing users to use all of CSS.
It allows you to use pseudo selectors with css

Note, this PR makes no changes to the Python API.  I figured we could iterate on that in another PR.  I'm just excited that this may end the "I need to be able to style X, but I don't want to subclass widgets" issue.
This is marked as backwards incompatible because the fixed behavior is not the same as the broken behavior, and may change people's layouts who are dependent on the broken behavior.
Action shot!!
(LICEcap is broken on my machine right now, probably because of my OReilly screen casting setup)
Demo notebook
https://gist.github.com/jdfreder/d0ec16a8f699b86895f1

:+1: this looks good to me. Not sure we should consider this backward incompatible.

Will merge in a bit unless someone comments before.

Awesome!
I'm super excited about this getting merged.  I think we can build a cool API on top of this, especially once your observable dict traitlet is ready.


[Mobil-UI]State table and chart overflow from right side in the mobile view

Describe the bug
State/UT table and summary chart having some extra space in the right side.
To Reproduce

Open google chrome browser in the mobile.
Go to https://www.covid19india.org/
Go to state/UT table
Go to the summary chart

Expected behavior
State/UT table and summary chart should be properly fixed on the screen. Overflow not expected. In-case of overflow(Width is extended to the screen ) then the scroll option should be populated.
Screenshots

Smartphone (please complete the following information):

Device: Vivo V9
OS: Android
Browser Google Chrome
Version 80.0.3087.149

Duplicate of #1006, #951 and this bug is fixed in PR #957

Closing cause duplicate.


docbuild.rb needs to create latest-docs/master/ in target for ascii_binder.

ascii_binder references the stylesheet via ../../master/ so we need the latest-docs to include the master/ subdirectory.

@simaishi @Fryguy minor update to docbuild.rb to keep ascii_binder happy. Thanks.


model.evaluate() does not yield the same accuracy as computing it manually using a for-loop

Apologies in advance if this is the wrong place for this discussion. I suspect the model.evaluate() behavior I identify below is a feature, not a bug, but would like to better understand it if so.
After following the transfer learning tutorial on Tensorflow's site, I have a question about how model.evaluate() works in comparison to calculating accuracy by hand.
At the very end, after fine-tuning, in the Evaluation and prediction section, we use model.evaluate() to calculate the accuracy on the test set as follows:
loss, accuracy = model.evaluate(test_dataset)
print('Test accuracy :', accuracy)
6/6 [==============================] - 2s 217ms/step - loss: 0.0516 - accuracy: 0.9740
Test accuracy : 0.9739583134651184

Next, we generate predictions manually from one batch of images from the test set as part of a visualization exercise:
# Apply a sigmoid since our model returns logits
predictions = tf.nn.sigmoid(predictions)
predictions = tf.where(predictions < 0.5, 0, 1)

However, it's also possible to extend this functionality to calculate predictions across the entire test set and compare them to the actual values to yield an average accuracy:
all_acc=tf.zeros([], tf.int32) #initialize array to hold all accuracy indicators (single element)
for image_batch, label_batch in test_dataset.as_numpy_iterator():
    predictions = model.predict_on_batch(image_batch).flatten() #run batch through model and return logits
    predictions = tf.nn.sigmoid(predictions) #apply sigmoid activation function to transform logits to [0,1]
    predictions = tf.where(predictions < 0.5, 0, 1) #round down or up accordingly since it's a binary classifier
    accuracy = tf.where(tf.equal(predictions,label_batch),1,0) #correct is 1 and incorrect is 0
    all_acc = tf.experimental.numpy.append(all_acc, accuracy)
all_acc = all_acc[1:]  #drop first placeholder element
avg_acc = tf.reduce_mean(tf.dtypes.cast(all_acc, tf.float16))
print('My Accuracy:', avg_acc.numpy())
My Accuracy: 0.974

Now, if model.evaluate() generates predictions by applying a sigmoid to the logit model outputs and using a threshold of 0.5 like the tutorial suggests, my manually-calculated accuracy should equal the accuracy output of Tensorflow's model.evaluate() function. This is indeed the case for the tutorial. My Accuracy: 0.974 = accuracy from model.evaluate() function. However, when I try this same code with a model trained using the same convolutional base as the tutorial, but different Gabor images (not cats & dogs like the tutorial), my accuracy no longer equals the model.evaluate() accuracy:
current_set = set17 #define set to process.
all_acc=tf.zeros([], tf.float64) #initialize array to hold all accuracy indicators (single element)
loss, acc = model.evaluate(current_set) #now test the model's performance on the test set
for image_batch, label_batch in current_set.as_numpy_iterator():
    predictions = model.predict_on_batch(image_batch).flatten() #run batch through model and return logits
    predictions = tf.nn.sigmoid(predictions) #apply sigmoid activation function to transform logits to [0,1]
    predictions = tf.where(predictions < 0.5, 0, 1) #round down or up accordingly since it's a binary classifier
    accuracy = tf.where(tf.equal(predictions,label_batch),1,0) #correct is 1 and incorrect is 0
    all_acc = tf.experimental.numpy.append(all_acc, accuracy)
all_acc = all_acc[1:]  #drop first placeholder element
avg_acc = tf.reduce_mean(all_acc)
print('My Accuracy:', avg_acc.numpy())
print('Tf Accuracy:', acc)
My Accuracy: 0.832
Tf Accuracy: 0.675000011920929

Does anyone know why there would be a discrepancy? Does the model.evaluate() not use a sigmoid? Or does it use a different threshold than 0.5? Or perhaps it's something else I'm not considering? Please note, my new model was trained using Gabor images, which are different than the cats and dogs from the tutorial, but the code was the same.
Thank you in advance for any insight!

@thor4 ,
This question is better asked on TensorFlow Forum since it is not a bug or feature request. There is also a larger community that reads questions there.

Thanks, I have posted it as you suggested: https://discuss.tensorflow.org/t/model-evaluate-does-not-yield-the-same-accuracy-as-computing-it-manually-using-a-for-loop/3214
Hopefully someone somewhere will have some insight.

I'm re-opening this again for your review as it may be a bug. There have been no responses on the Tensorflow Forum post and it's been a month now. Please advise.

thanks, I am working on a jupyter nodebook and will provide soon

Thanks for your patience. Here is a Jupyter notebook with the model and dataset which duplicates the accuracy calculation discrepancy: https://colab.research.google.com/github/thor4/neuralnets/blob/master/projects/1-CNN/model_evaluate.ipynb
Please let me know of questions/issues. Thank you for your help.

@Saduf2019 ,
I was able to reproduce the issue in tf v2.5, v2.6 and nightly.Please find the gist of it here.

For each batch during training, Keras will compute this metric and keep track of its mean since the beginning of the epoch. This is exactly what you are trying to calculate manually.
But this is not the case always.Instead of batch wise accuracy or it keeps track of the all True positives and False positives and returns the overall precision, which is called streaming metric or stateful metric as it is updated batch after batch.
Consider the below simple example.
>>> precision = keras.metrics.Precision()
>>> precision([0, 1, 1, 1, 0, 1, 0, 1], [1, 1, 0, 1, 0, 1, 0, 1])
<tf.Tensor: id=581729, shape=(), dtype=float32, numpy=0.8>
>>> precision([0, 1, 0, 0, 1, 0, 1, 1], [1, 0, 1, 1, 0, 0, 0, 0])
<tf.Tensor: id=581780, shape=(), dtype=float32, numpy=0.5>

In the above example by passing predictions and labels of first batch and second batch, you can see the it returns 0.8 for first batch and 0.5 for second batch, in second batch instead of returning precision for only second batch it actually returns the overall precision.


GitCoin Batch: UI, sortings, scores, links deletion, metadata fetching, long URLs

https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/4
https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/5
https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/6
https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/7
https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/8
https://github.com/ARK-Builders/ARK-Shelf-Desktop/issues/9

See #11


Error: No such command 'render'.

Hi,
Thank you for building this, very useful!
while following the docs and running render gives an error:
graphql2python render --config ./graphql2python.yaml

Error: No such command 'render'.

But running generate works fine:
graphql2python generate --config ./graphql2python.yaml

Hello, thank for your comment.
Of course, this is a mistake.
In the future I will release updates to the package and fix all errors in the documentation.


GUI support

Hello,
it would be great to have a GUI for managing permissions.
I have a very little need since i like to use ES JS Client :
Create a user, assign him read-only permission over a specific index.
Right now, i am confused how much efforts it take for just doing that task.

duplicate of #106


Unexpected token  in JSON at position 81

After pressing the button on the Bridge to allow the plugin to connect, I get the following messages in the Homebridge log:
[31/08/2021, 20:24:28] [Nuki] Nuki_Bridge_17A1D616: request 5: GET /list
[31/08/2021, 20:24:28] [Nuki] Nuki_Bridge_17A1D616: warning: request 5: error: Unexpected token  in JSON at position 81
[31/08/2021, 20:24:28] [Nuki] Nuki_Bridge_17A1D616: warning: heartbeat error: Unexpected token  in JSON at position 81
This repeats every minute.
No Nuki devices are shown in the Home app/Homebridge apart from the Nuki Bridge.
I have browsed to some of the API pages through a browser with the following results:
My /info:
{"bridgeType": 1, "ids": {"hardwareId": (redacted), "serverId": (redacted)}, "versions": {"firmwareVersion": "2.9.3", "wifiFirmwareVersion": "2.2.0"}, "uptime": 295, "currentTime": "2021-08-31T19:17:55+00:00", "wlanConnected": true, "serverConnected": true, "scanResults": [{"deviceType": 2, "nukiId": (redacted), "name": "Nuki_Opener_1CC8DF02", "rssi": -46, "paired": true}]}
My /list:
[{"deviceType": 2, "nukiId": (redacted), "name": "Cygnet Court Front Entrance DoorG", "firmwareVersion": "1.6.4", "lastKnownState": {"mode": 2, "state": 1, "stateName": "online", "batteryCritical": false, "ringactionTimestamp": "2021-08-31T16:19:46+00:00", "ringactionState": false, "timestamp": "2021-08-31T19:13:12+00:00"}}]
Any ideas what could be causing this?
I have removed the plugin and reinstalled it a few times now to no avail.

It looks like it chokes on the weird character in the name, that is about position 81, isn't it?  I'm not sure if JSON allows these, even in strings, see https://www.json.org/json-en.html.  I'm just doing native JSON.parse()
That's an Opener, isn't it?  What's the output of nb -DD -H x.x.x.x -T xxxxx list, substituting IP address and token of the Nuki bridge?

Perfect - it was the name of the opener for some reason. I didn’t enter a special character in the name weirdly.
I changed the name to something shorter, now it is displaying correctly in the JSON file correctly.
Thank you for your quick reply!


Feature: allowing users to provide context file as comment-style reference

Description
Add a new command-line flag --context/ -c that allows users to provide a sample file, giving the LLM more context for generating comments.
Implementation
Implementing the feature would require:

Adding the code for parsing the --context/ -c option flag argument from the command line in main.py.
Adding a callback function, which will read the contents of the provided file and add them to the API request.

Closed by 4bf64b2a5cb485b14035b387169e3895cc03e656


Please invite me to the Recode-Hive GitHub Community Organization

Name
Praveen Koujalagi
Discord Username (if applicable)
praveen_koujalagi
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Change in package name breaks composer update

Hi thanks for the latest updates, upon running composer update resource broke as needed
use KossShtukert\LaravelNovaSelect2\Select2;
instead of
use Koss\LaravelNovaSelect2\Select2;
If this change was necessary perhaps you should mark it as not compatible with previous version

@yehudahkay
Thank you.
Marked v1.13 as not compatible with the previous version


Add Edge TPU support to C++ engine

The TFLite C++ runtime now supports the Coral Edge TPU: https://coral.ai/docs/edgetpu/tflite-cpp/
We should hook that up.

Speaking of the Edge TPU, you published a minigo-tflite-file compiled for the Edge TPU about a year ago which offered very interesting possibilities. Could you perhaps publish the original quantized tflite-file too (i.e. before compiling for the Edge TPU). This would make it much easier to compare results to the non-quantized version und evaluate quantization effects.


Panel: Changing page before extracting request processed may kill panel on subsequent pages

Need to try and root cause this further to see if we can repro it reliably.  If you change pages while the panel is displaying "extracting..." the next page that loads has no panel.  You can toggle the panel with the toolbar button and it still will not show.  Stopping and restarting the trail also did not bring the panel back.  The only way I got it back was to close the browser and restart it.

This should be OBE with #161.  Confirm?

fixed as panel bug OBE


Rewrite disease relationship step to replace redis queue with pypeln

We are removing the Redis queue system and replacing with a third party library pypeln. The --ddr step is one place with this is used, and therefore which needs to be updated.

Solved by PR opentargets/data_pipeline#460