javascript: copy-pasting code containing switch statement indents weirdly

If you copy this code:
function test(a) {
  switch(a) {
    case 1:
      console.log('one');
      break;
    case 2:
      console.log('two');
      break;
    default:
      console.log('uh oh');
  }
}

and then try to paste it into a javascript file in Atom, you get this:
function test(a) {
  switch(a) {
    case 1:
      console.log('one');
      break;
      case 2:
        console.log('two');
        break;
        default:
          console.log('uh oh');
        }
      }

Atom version 0.158.0

Same with C++
https://gist.github.com/rolandkopka/9acb1972a270d8c15846
Ctrl-A, Ctrl-C, Ctrl-V the Raw of the gist into an empty cpp file. This is the result:

The blue squares are trailing spaces.

This fixed it for me:

Under settings => "auto indent on paste" -  I had to turn that off, not sure if was a new default or what.

via https://twitter.com/mikeal/status/551087742918995968

I was having problems pasting javascript code. Especially objects that contained an array of objects. The code would unindent for each object. Unchecking 'auto indent on paste' fixed this for me.

@tannyo Doesn't unchecking 'auto indent on paste' cause the indents to not line up correctly in your code? I haven't tested it, but just judging by the name of the option, I assume your pasted in code will then not line up.
For example:
Say this is your php file:
class MyClass {
private function test() {
echo 'my test';
}
}
Then say this is from a website (github, stackoverflow, joe's blog, or from another editor):
private function tryMe() {
echo 'just try me';
}
Notice how the tryMy() function is not indented. In your class, your functions are indented. I expect, with 'auto indent on paste' off, that it would not place the function 1 indentation in, and it would be the same level of indentation as the class block, which is incorrect.
If I am wrong, then what IS the purpose of 'auto indent on paste'? If I am right, then turning off 'auto indent on paste' just removes the whole purpose of using a sophisticated editor. If I copy from N++ 3 functions worth 600 lines of code, I don't want to manually fix the indentations, and I shouldn't have to.
Those saying "fixed it for me" or "solved it" are incorrect. It is a work around or a hack, not a fix or solution. A solution, would be to fix the bug in the next release.
This is persistent for every language (javascript, php, etc) and affects comment blocks, multi-line arrays, and probably anything else that extends on multiple lines such as array().

I believe unchecking both 'Auto-indent on paste' and 'Normalize indent on paste' will cause Atom to paste whatever code you have in without doing any indentation modifications to it.
Anyway, there's currently an open PR that is aiming to fix this (see atom/language-javascript#92).

@WadeShuler Yes, I now have to manually indent when I paste code from external resources. If I move code within a module I have to manually set the indentation. However, it's much better than before when after pasting code I would have to manually indent code that I pasted within the same project that was already correctly indented. Now I just have to take the block of code I just pasted and indent or outdent it which is much better than having to go line by line to get everything correct.
It's better than taking this:

which is properly indented for javascript and getting this:

Seems like the opposite problem @AgentME was having. My code outdents, his code indents.
When typing code it mostly works.


docs: update maintainers section

This pull request updates the docs about maintainers.

You have that letter 👍


Clarify remark on IHostedService startup

Fixes #18996
Thanks @atykhyy! :rocket:

Note that there are build errors on this PR that aren't touched by this work. I'll open an issue to address them.


Newbie to Programming

Hi, I loaded your script into my html file and there are syntax errors. Can you provide a clearer example of how your script is written so that I can just copy and paste? I would really appreciate it.

Questions like this are more suitable on Stack Overflow.


Helm upgrade does not upgrade CRDs

Current method of specifying CRDs is ignored when upgrading helm release.
See: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/
Possible solution:

Move CRDs to ./charts/kubeai/templates
Move model up a level to be its own chart

Bonus:

Template a catalog of individual <model-name>.yaml files that could be installed with kubectl apply -f https://... directly. Probably makes sense to do this with the models chart.

I think moving CRDs to templates would be easier for users.

Move CRDs to templates/: Relocate your CRD YAML files from the crds/ directory to the templates/ directory.
Use Helm Hooks: Add the following annotations to your CRD YAML files to ensure they are applied before other resources:

metadata:
  annotations:
    "helm.sh/hook": "pre-install,pre-upgrade"
    "helm.sh/hook-weight": "-5"


Where to set up the product objet

Hi,
I m brand new to both stripe and vuejs so my question might be very basic but I don't understand where am I supposed to set up the product json object, neither the options.
I have generated the basic js of laravel 5.3 and I thought I should specify this like so:
import { StripeCheckout } from 'vue-stripe';

Vue.component('stripe-checkout', StripeCheckout);

const app = new Vue({
    el: '#app',
    data: {
    	product: {
		    name: 'Moby Dick',
		    description: 'I love whales',
		    amount: 100000 // 100$ in cents
		},
		options: {
			zipCode:true
		}
	}
});

Can you tell me what I m doing wrong?
Thanks in advance!

Did you set the view layer? You need to declare the component in your HTML:
<stripe-checkout :product="product" :options="options"></stripe-checkout>

Allright it works with :product instead of product.
Thanks!


Fix bug on setup.py when editing symlinks

What this Pull Request (PR) does
Resolve symlink before calling sed
Related issues
If it closes an issue, type closes #[ISSUE_NUMBER].](sed: in-place editing only works for regular files #198)
Screenshots
Provide any screenshots you may find relevant to facilitate us understanding your PR.

Not using setup.py anymore. Now using pipx. Should fix your issue.


Proposal: Enable simplification of long (rural) roads

Hi!
Downloading a rural, mountainous and rather big area, I've run into the issue that some roads are not simplified properly. This is well documented and happens due to a RecursionError in simplification._build_path. This error is subsequently caught in line 171 (commit 0ef7002) and logged.
I've had this issue monkey patched so far. Now I forked osmnx and implemented it correctly. It is tested and ready for a PR, However, I opened the issue in order to conform to the contributing guidelines.
Further changes for large networks and compatibility:
In a separate commit I've turned simplification._get_paths_to_simplify into a generator to keep its memory footprint in large networks lower. Also at some point I found that it raises errors with Python<3.5 so I've exchanged RecursionError for RuntimeError, where the prior is a subtype of the latter, so behaviour remains the same.
Testing
All of the above mentioned commits on my branch have been tested according to the contributing guidelines.
cheers,
Simon

Thanks @pinselimo. Yep this is a known issue due to recursion depth. If you've found a solution for it, I'd be glad to examine a pull request. A smaller memory footprint would also be welcome.
One note: the previous two releases of OSMnx are compatible with the three most recent major releases of Python (3.6, 3.7, 3.8) and Python 2 support was dropped last year. It's best to use RecursionError as that's the specific error being generated and is compliant with all versions of Python supported by this package.


[ARM] Atlas Renderer encountered an unexpected error

Windows Terminal version
main b4d37d8c7
Windows build number
10.0.22621.169 (aarch64)
Other Software
No response
Steps to reproduce

build latest source on Windows aarch64 (Windows DevKit 2023 used for testing)

Expected Behavior

terminal to launch

Actual Behavior
Error message: This terminal has encountered an issue with the graphics driver and it could not recover in time. It has been suspended.
Upon pressing Resume an error is thrown:

I can repro this on my volterra too.

Error Code
Symbolic Name
Error Description
Header

0x887a002d
-2005270483
DXGI_ERROR_SDK_COMPONENT_MISSING
The application requested an operation that depends on an SDK component that is missing or mismatched.

If you run a debug build you'll need to install the DirectX SDK. It should be part of the "Graphics debugger and GPU profiler for DirectX" component in the Visual Studio Installer. It happens because this isn't true and doesn't work: https://github.com/microsoft/terminal/blob/b4d37d8c70b02952ffed9715bd10893e688024a8/src/renderer/atlas/AtlasEngine.cpp#L551-L552
If anyone wants to fix this, please do so! I just didn't have the time to set up a VM and test this just yet, especially since I personally always have the SDK installed for debugging purposes.


[SPARK-14023][MLlib] Make exceptions consistent regarding fields and columns

What changes were proposed in this pull request?
Make exceptions consistent regarding fields and columns
How was this patch tested?
Existing tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/568/
Test PASSed.

Test build #87039 has started for PR 20500 at commit b80c13a.

Test build #87039 has finished for PR 20500 at commit b80c13a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87039/
Test PASSed.

Test build #97808 has started for PR 20500 at commit b80c13a.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4305/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4322/
Test PASSed.

Test build #97841 has started for PR 20500 at commit b80c13a.

Build finished. Test FAILed.

Build finished. Test FAILed.

I'm going to address this in https://github.com/apache/spark/pull/23373


Third-party proof-of-concept web app + extension

We have a major objective of writing our packages in such a way that allows for third-party wallets (Keplr, Leap, etc) to easily integrate the view service into their own codebase.
We wrote a third-party integration guide in the past and have taken the beginning steps to update it based on the new message passing system.
Given how deeply integrated the view service is in our code, it's challenging to know if it indeed could work with other wallet extension infra. For instance, we should assume they handle custodying completely different. Think we should do three things:

Complete the end-to-end third party integration documentation. Should give a step-by-step tutorial on how it can be done.
Add a proof-of-concept extension to /apps that serves as an integration guide. Should be heavily stripped down and not require any styling. Should display block sync progress & balances.
Add a proof-of-concept web app to /apps that has a button to issue a simple send transaction and display wallet id.

some notes on this in #341


Don't go top page after added a bookmark

Please make sure you've tried the latest version of Fritter first, as the F-Droid version is sometimes out of date!

Describe the bug
Hello.
I would like to report a annoying bug, that make the main list of post go at top each time I add a bookmark.
Is it possible to keep the spage scroll even after added a post to bookmarks?
To Reproduce
Steps to reproduce the behaviour
2. Add a bookmark in a post that isnt on top of the list.
Device
Android 11

I'm suffering from this bug myself. I'm hoping for a quick response from the developers.

Good news - this should already be fixed in the upcoming version!

Fixed in v2.15.0.


Allow imageTransforms to use any of sharp's image ops

Do a simple lookup of option key to functions available to sharp's image operations API
Pass the value for that key as the parameter to sharp's function (if it exists)
Infer the filename from a list of all parameter values (perhaps special consideration for primitive values vs objects, and certain properties like width/height)

done with #179


Improved class diagrams and document conventions

Closes #7

@reinecke Please review

Looks good to me! @ssteinbach or @jminor, would you mind giving a second set of eyes?

Let's go ahead and merge this in, I think it looks good.


Unnecessary cast of a function? (Null Safety migration tool)

Consider the following code:
int foo(List<int> list) {
  return list.firstWhere((n) => n == 42,
      orElse: (() => throw StateError('error')));
}

The migration tool produces:
int  foo(List<int >  list) {
  return list.firstWhere((n) => n == 42,
      orElse: ((() => throw StateError('error')) as int Function()?));
}

It's ok wrt. nullability, but AFAICS the cast is redundant (and I even get warnings that it's unnecessary).
Dart SDK version: 2.10.323325861-edge+google3-v2
CC @stereotype441

Thanks, Michal.  I suspect what is happening is that the migration tool is incorrectly considering the migrated closure () => throw StateError('error') to have the type Null Function(), so it's trying to insert a cast because that type is not assignable to the expected type (int Function()?).  To fix this, we probably need some special logic to handle closures that always throw, or we need the migration tool's FixBuilder to hook better into the existing analyzer logic that inferres the return types of closures.

As of 1c7fe7196dd7a542f7f91cd6ea2ac81e1a13146c, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.
If you still need help, or you believe this issue has been closed in error, please feel free to reopen.


Moving Swagger to stable folder creating folder structure

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Hi, @banggaurav, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

Its not clear what specific changes you would like to make with this version. Please follow this guidance to raise the PR

@rkmanda This PR already have 2 commits. In first commit it have all the files copied from preview version and in second commit it contains version update changes. Let me know if something is missing.


always show egctl version

Description:
The egctl version command should display the application version even when no Kubernetes context exists
without Kubernetes context
$ egctl version
error: list EG pods failed: Get "http://localhost:8080/api/v1/pods?labelSelector=control-plane%3Denvoy-gateway": dial tcp <IP_ADDRESS>:8080: connect: connection refused

$ kubectl version
Client Version: v1.31.2
Kustomize Version: v5.4.2
The connection to the server localhost:8080 was refused - did you specify the right host or port?

with Kubernetes context
$ egctl version
client: 1.2.1
server:
- Name: envoy-gateway-6bd99f6549-55n8p
  Namespace: envoy-gateway-system
  envoyGatewayVersion: v1.2.1
  envoyProxyVersion: distroless-v1.32.1
  gatewayAPIVersion: v1.2.0
  gitCommitID: 1e7263bc05566559a67ed028b633fb3580f61682
  golangVersion: go1.23.2

$ kubectl version
Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.29.8-eks-a737599
WARNING: version difference between client (1.31) and server (1.29) exceeds the supported minor version skew of +/-1

try egctl version --retmote=false?

try egctl version --retmote=false?

it works, but I think version flag should always return the application version without requiring additional flags, especially since this behavior is not mentioned it the --help output

egctl version -h
Show version

Usage:
  egctl version [flags]

Aliases:
  version, versions, v

Examples:
  # Show versions of both client and server.
  egctl version

  # Show versions of both client and server in JSON format.
  egctl version --output=json

  # Show version of client without server.
  egctl version --remote=false

Flags:
      --context string      The name of the kubeconfig context to use.
  -h, --help                help for version
      --kubeconfig string   Path to the kubeconfig file to use for CLI requests.
  -o, --output string       One of 'yaml' or 'json' (default "yaml")
  -r, --remote              If true, retrieve version from remote apiserver. (default true)

thnx


Quirrel sometimes uses too many Redis Clients

Sometimes, there are too many open /activity subscriptions. It causes Quirrel to run out of available Redis connections, and causes degraded service conditions. We should pose a maximum amount of /activity subscriptions to make sure we always leave enough headroom for job management.

was fixed by an earlier PR


Slow First Request after AppServer.startup()

Describe the bug
After my simple single POST request route (accepting and returning JSON) is bound to the system's port, the first request on boot always takes over 12 seconds. Subsequent requests, regardless of params, take less than 14ms on average.
To Reproduce
using Genie, Genie.Router, Genie.Renderer, Genie.Requests

module ServerListener
  using Genie, Genie.Router, Genie.Renderer, Genie.Requests
  Genie.config.run_as_server = true

  function setup_and_start(args)
    route("/tree", method = POST) do
      message = jsonpayload()
      result = "Yep I am great"
      (:result => (result)) |> json!
    end

    Genie.AppServer.startup(parse(Int64, args[1]), "<IP_ADDRESS>", async = false)
  end
end

julia -e "include(\"server_listener.jl\"); ServerListener.setup_and_start(ARGS)" 8000

Expected behavior
After the server is bound to the port, I would expect all the requests to be within at least one order of magnitude within each other.
Additional context
Please include the output of
julia> versioninfo()
Julia Version 1.1.0
Commit 80516ca202 (2019-01-21 21:24 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, ivybridge)
Environment:
  JULIA_LOAD_PATH = @:/app

and
pkg> st
# Excluding other packages I am using as they are not pertinent to the issue at hand.
  [c43c736e] Genie v0.9.2 #master (https://github.com/genieframework/Genie.jl)

Other Notes
This is deployed on heroku using buildpacks. I have zero issues with compiling and releasing the software, just the initial request after boot up is really slow. Without digging to far into the internals, my guess is that some things are lazy loaded?
Here are some of the logs of the requests right after boot:
2019-06-04T20:50:39.200088+00:00 heroku[router]: at=info method=POST path="/tree" host=herokuapp.com request_id=479a1e38-d07c-4c61-862f-6750d456ecd6 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=14434ms status=200 bytes=136 protocol=https
2019-06-04T20:50:42.187343+00:00 heroku[router]: at=info method=POST path="/tree" host=herokuapp.com request_id=465e1330-39e1-4dba-b5cc-27ffd4fdc80a fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=14ms status=200 bytes=136 protocol=https
2019-06-04T20:50:42.186416+00:00 app[web.1]: 2019-06-04 20:50:42:INFO:Main: /tree 200
2019-06-04T20:50:42.186433+00:00 app[web.1]:
2019-06-04T20:50:42.918779+00:00 heroku[router]: at=info method=POST path="/tree" host=herokuapp.com request_id=863db10a-b242-4198-84bb-61fa694acd77 fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=14ms status=200 bytes=136 protocol=https
2019-06-04T20:50:42.914676+00:00 app[web.1]: 2019-06-04 20:50:42:INFO:Main: /tree 200
2019-06-04T20:50:42.914694+00:00 app[web.1]:
2019-06-04T20:50:44.922916+00:00 heroku[router]: at=info method=POST path="/tree" host=herokuapp.com request_id=5f628aa8-ca4e-4f2f-a400-c7f79e7c00bb fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=24ms status=200 bytes=136 protocol=https
2019-06-04T20:50:44.923879+00:00 app[web.1]: 2019-06-04 20:50:44:INFO:Main: /tree 200
2019-06-04T20:50:44.923905+00:00 app[web.1]:
2019-06-04T20:50:45.592593+00:00 heroku[router]: at=info method=POST path="/tree" host=herokuapp.com request_id=4d2cdd2b-8c8a-4009-b287-e65c66a8e6c4 fwd="<IP_ADDRESS>" dyno=web.1 connect=2ms service=24ms status=200 bytes=136 protocol=https

Thank you so much for all your work on this wonderful library. 😄

Welcome to Julia and welcome to Genie.jl. It is a well-known aspect of Julia that the first call is always slow due to precompilation. All benchmarking of all Julia code, including Genie.jl, is performed AFTER an initial "warmup". Hope this helps 😊

@EricForgy Thanks for that!! Is there anyway to force a precompilation on AppServer bootup as opposed to when an initial request is hit?
Sorry for the silly question as I am new to Julia :D. Thanks for the guidance!

@phereford As @EricForgy said, this is a known issue and it's due to Julia's JIT compilation. The core team is always trying to reduce compilation time - and there is work being done to allow compiling to a binary (there are some promising early results but it's not something that can be done at scale yet, ex see: https://medium.com/@sdanisch/compiling-julia-binaries-ddd6d4e0caf4).
You could use a warm-up script maybe? It could read all the routes defined in the app and use HTTP.jl to make requests towards the various endpoints?

@essenciary thank you for the time! Cheers.

@phereford I used Fezzik to bulid a system image with genie compiled in and it worked great.

@ksteimel Wow! How did that improve? Did you see performance improvements or simpler deployment? Can you share more details please?

Oh it's immensely faster after you restart the server (if you compile the whole image).
I have occasionally had issues using revise with Fezzik but that was only once or twice. I blacklisted my app in Fezzik but had all the dependencies compiled (Genie, Revise, CFG.jl, Luxor) and it was not quite instantaneous but notably faster.

 It will take a little while to compile everything and then if you restart julia it will use your new sysimg and startup should be instant.

Sounds great and pretty straightforward! If you run the app in production, that has Revise off (or you can turn Revise off yourself). Maybe that will eliminate revise issues. But also, Revise shouldn't watch files in production since they shouldn't change anyway.

@ksteimel I will check it out. Thanks for the tips!


[Feature] Show current count of duplicates under each type Action

Would be nice to have a count of duplicates

Maybe under each header, show Number of duplicate tabs: XXX or XXX duplicate tabs
It's informative, and helps the user decide if they are clicking the right button.

The purpose of prevent-duplicate-tabs is to prevent duplicates, so there is no way to show a counter.
Anyway the "Actions" area is about actions on the domain or full url, where you can set to disable the action to prevent duplicates.
If I didn't understand something, don't comment. I'm grateful for the feedback.
Note: I'm working on an improvement so that pages with forms filled by human action (interaction) are not closed, regardless of the settings in prevent-duplicate-tabs.

Yeah, now I understand a little bit better how the app works.
At first I thought only URLs that you selected would be auto-closed (whitelisting), which my comment would make sense; but the app works in a close all except selected (blacklisting).
Thanks for the response!
Cheers


Correction for raw affiliation Interventional Radiology Unit, Macerata Hospital, Macerata, AV4, ASUR Marche, Italy

Correction needed for raw affiliation Interventional Radiology Unit, Macerata Hospital, Macerata, AV4, ASUR Marche, Italy
raw_affiliation_name: Interventional Radiology Unit, Macerata Hospital, Macerata, AV4, ASUR Marche, Italy
new_rors: 019jb9m51
previous_rors: 0001fmy77
works_examples: W4321349136
contact: 826324a844421f3403745b4a0ab0dbd3:b27b91b88ee6277bd5b782dabf5c096b @ sirisacademic.com

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Dark mode

Now, we have a dark version of The Swift Evolution, and readability can be easy
It's matched with the OS theme, if OS is the dark theme we have the dark theme
I used CSS media query to detect OS prefer theme
@media screen and (prefers-color-scheme: dark)

Duplicate of #1177

@benrimmington Oh my good, but I think my PR is better than #1177 :)

Like Ben said, I think it makes sense to work with @Clashsoft in that PR since we've been converging on a result for a while.

Yeah, go ahead.


when I try to run test.py,there is something wrong:   Message=[Errno 2] No such file or directory: 'data/coco/annotations/instances_val2017.json'   Source=D:\G\Swin-Transformer-Object-Detection-master\mmdet\datasets\coco.py   StackTrace:   File "D:\G\Swin-Transformer-Object-Detection-master\mmdet\datasets\coco.py", line 54, in load_annotations     self.coco = COCO(ann_file)   File "D:\G\Swin-Transformer-Object-Detection-master\mmdet\datasets\custom.py", line 87, in init (Current frame)     self.data_infos = self.load_annotations(self.ann_file)   File "D:\G\Swin-Transformer-Object-Detection-master\mmdet\datasets\builder.py", line 71, in build_dataset     dataset = build_from_cfg(cfg, DATASETS, default_args)   File "D:\G\Swin-Transformer-Object-Detection-master\tools\test.py", line 163, in main     dataset = build_dataset(cfg.data.test),please tell me how to solve it

I'm also getting same error. The dataset files are missing(for ex: 'data/coco/annotations/instances_val2017.json'). Can anyone please tell from where can we get these files?

hi, u have to give the proper path to the dataset


gitlens.views.repositories.autoReveal setting not working

GitLens Version: 10.2.1

VSCode Version: 1.43.2
OS Version: macOS 10.14.6

Steps to Reproduce:

Set gitlens.views.repositories.autoReveal to false, in your global VSC settings.
In a VSC workspace, that has a Git repo, open a file from another workspace, that also has a Git repo.
The second repo will appear in Gitlens -> Repositories view, even though the setting is disabled.

This setting has never worked for me. Is there something I'm doing wrong? I don't want repositories to be automatically added to the Gitlens -> Repositories view.

That setting isn't for controlling that behavior -- it is just for controlling whether or not the selected repo in the Repositories view changes with the currently active editor or not.
Unfortunately, what you are looking for doesn't exist today, but https://github.com/eamodio/vscode-gitlens/issues/995 is the feature request for it.


Implementation of node's caching

In scope of this pull request we add possibility to cache node dependencies. Add cache input parameter to actions/setup-node. For now, input will accept the following values:

npm - enable caching for npm dependencies
yarn - enable caching for yarn dependencies

Related issue: https://github.com/actions/setup-node/issues/271
Description
Action will try to search package-lock.json or yarn.lock (npm 7.x supports yarn.lock files) files in the repository root and throw error if no one is found. The hash of found file will be used as cache key (the same approach like actions/cache recommends). The following key cache will be used ${{ runner.os }}-npm-${{ hashFiles('') }}
Action will cache global cache:

Npm (retrieved via npm config get cache)
Yarn 1 (retrieved via yarn cache dir)
Yarn 2 (retrieved via yarn config get cacheFolder)

Example of yml

For npm

 uses: actions/setup-node@v2
  with:
    node-version: '14'
    cache: 'npm'

For yarn:

 uses: actions/setup-node@v2
  with:
    node-version: '14'
    cache: 'yarn'

ADR: https://github.com/actions/setup-node/pull/266
Note:

It's not breaking change because it requires additional field and nothing changes by default.
License tests are falling. But we have changes to fix it. We've decided to stay with implementation, because approximately 50 licenses were changed. When changes are reviewed, we will add licenses to the existing pull request.

What's done:

[x] - Implementation of node's caching
[x] - Adding tests for node's caching
[x] - Adding documentation
[x] - Update licenses

The following key cache will be used ${{ runner.os }}-npm-${{ hashFiles('') }}

A bit late to the party but the cache for yarn@>=2 is identical across all operating systems so that doesn't need to be part of the key

Some high entropy questions:

any particular reason for the decision that shrinkwrap is not a lockfile
why is this action called setup-node if it only fully supports yarn
why is it tagged v2 if it's a breaking change, when v2 even had a v2-beta

This PR also says it's only supporting files in the root of the module but that just seems like cutting corners on customising the cache key, providing opinionated defaults without a way to configure them is simply pushing this PR's opinions on people or forcing them to compete in implementation.
Currently, the only way forward is to completely change the way we use npm (slash migrate to yarn) or switch all the workflows to v2-beta in order to avoid various tools picking the change up and suggesting action update.

why is it tagged v2 if it's a breaking change

@0-vortex see above, specifically this line:

It's not breaking change because it requires additional field and nothing changes by default.

This PR adds a new feature where if you were previously using actions/setup-node and actions/cache, you might be able to remove actions/cache by adding the new cache key here. But you don't have to, you can continue using your current config, this PR doesn't change existing behavior.

why is it tagged v2 if it's a breaking change

@0-vortex see above, specifically this line:

It's not breaking change because it requires additional field and nothing changes by default.

This PR adds a new feature where if you were previously using actions/setup-node and actions/cache, you might be able to remove actions/cache by adding the new cache key here. But you don't have to, you can continue using your current config, this PR doesn't change existing behavior.

Thank you for the reply but it is not a clarification, sorry if the comment felt rushed, have spent a decent amount of hours toying with this implementation without getting positive results. As a precaution I have read all the comment history and reviewed the code changes twice before posting the questions.
Some references:

https://github.com/open-sauced/open-sauced/runs/2986322631#step:3:16
https://github.com/akv-platform/setup-node/blob/cfe70f9fe8ca345bad2e02a88695dd317e6172c0/src/cache-utils.ts#L15
https://docs.npmjs.com/cli/v7/commands/npm-shrinkwrap
https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#package-lockjson-vs-npm-shrinkwrapjson

Motivation here is to fix/implement cache for a number of failing repositories while promoting best practices.

@0-vortex , We don't pursue the goal to provide wide customization of caching in scope of actions/setup-node action. The purpose of this integration is covering ~90% of basic use-cases. If user needs flexible customization, they should continue to use actions/cache.
Currently, this integration covers basic use-cases for both npm and yarn:

https://github.com/actions/cache/blob/main/examples.md#node---npm
https://github.com/actions/cache/blob/main/examples.md#node---yarn

As @jacobwgillespie fairly mentioned above,

This PR adds a new feature where if you were previously using actions/setup-node and actions/cache, you might be able to remove actions/cache by adding the new cache key here. But you don't have to, you can continue using your current config, this PR doesn't change existing behavior.

New functionality is added under additional flag cache. if you don't add new flag - everything will work as previously. So this PR is not breaking change.
Your suggestion about shrinkwrap file is fair enough and it would be helpful if you create feature request issue for it?
Until it is implemented, I suggest continue using actions/cache that provides more customized configuration.

Can you share where you get those stats from? Shrinkwrap is a standard production practice, don't understand how you can call it a suggestion.


Missing btn-close SCSS of Bootstrap version 4.5.3

Hi,
I found that btn-close is not available in all SCSS files of Bootstrap version 4.5.3
I don't know if some other elements are missing as will!
Regards,

Different versions, different names. https://getbootstrap.com/docs/4.5/utilities/close-icon/

I mean in the source
https://github.com/twbs/bootstrap/archive/v4.5.3.zip
The class btn-close  should be there. Why it has been removed from there?

There's no .btn-close in 4.5.3, please follow the provided link and read the docs.

I see


add destructible bushes

I haven't merged this yet because object_placer changes are really difficult to merge. I'm gonna come back to this once Tiled support is added.


Feature Request: support Dubbo RPC protocol

Dubbo community decided to make contribution to Envoy by adding Dubbo RPC protocol support. Open this issue for tracking the work.
A draft design document is available at below link. https://docs.google.com/document/d/1A8xXqWJ0kIMmPNBKiGjLBTN-4FLarxMiyylYv8Dwpe8/edit?usp=sharing
Thanks for your review and comments.

Thanks @yun1129. Assigning to myself to review the proposal. @zuercher if you feel like also taking a look that would be cool since I suspect there is going to be some overlap with Thrift.

@yun1129 doc looks great. Very excited to help with reviews for this!

@mattklein123, the code is almost ready and I would like to seek your suggestion for upcoming steps. However, there is one important thing we should address - the integration test.
From Dubbo community perspective there are only samples for illustrating how Dubbo RPC framework works and there is no integration test environment. Furthermore, those samples are written in Java. From Envoy perspective I believe integration test is crucial but we need a simple and light solution for fulfilling that rather than bringing the Java runtime into Envoy's integration test environment.
I'm talking to Dubbo community for this. Meanwhile would like to hear your voice.

@yun1129 it's not a perfect integration test, but since you have to write both a decoder and encoder for proxy, I would probably just implement a fake upstream server in C++ using the Envoy encode/decoder code. This should be relatively simple to do and give good coverage. Obviously, it won't catch compat issues in the encoder/decoder itself, but since I'm guessing the protocol is pretty stable I think some manual testing is probably good enough and the built-in C++ integration test server can catch major regressions. Thoughts?

@mattklein123, in the long run, I believe you suggested solution is the final solution. Currently, Dubbo community doesn't have a light solution, meaning the upstream server is written in C++ or Go, that can fit this purpose. That's to say my team has to spend time to implement it and it leads time intensive. However, a Dubbo meetup is scheduled for the end of this month we don't have enough time to get the integration test ready and push the code of phase into Envoy repository. Ideally, Dubbo community would like to get the code open source when it announces Dubbo Mesh.
An alternative way is forking Envoy into the Dubbo community and once the work for integration test and phase two is done we can PR it back to Envoy.
Appreciate your suggestions!

@yun1129 sorry I didn't mean for you to write a production quality C++ Dubbo server. All I meant was that in order to implement the Dubbo proxy/router, you will need both an encoder and a decoder. With those, it should be pretty easy to make a FakeDubboServer using our integration test primitives. For example in this test (https://github.com/envoyproxy/envoy/blob/master/test/integration/ratelimit_integration_test.cc) we make a fake gRPC rate limit server and run some tests with that.
With that said, we don't have any integration tests for Redis (although arguably a simpler protocol) so if you want to start with just unit tests that's fine too.

@mattklein123 if it's acceptable I would like to take unit tests as the start for quality assurance. Since the final goal is making Dubbo Mesh can be utilized on production and my team will spend time on integration test for building quality confidence up.

Sure, no problem.

@zyfjeff is working on this at #4200

@zyfjeff thoughts on adding some docs around this new filter? I think then we can call this initial issue done?

@mattklein123
I am going to add documentation next week, but this issue can continue to be kept because we are doing Dubbo routing.
ref: #5251

this pr is already merge in envoy?

@NameHaibinZhang Has been merged into the master branch

Is Dubbo Support complete now ?

This is done. Let's track new feature request/issues with new issues.

Is Dubbo Support complete now ?

@hzxuzhonghu any roadmap about dubbo in istio project？


Replace additional icons that were added to jenkins

https://issues.jenkins-ci.org/browse/JENKINS-19438 introduced additional icons that should be replaced.

Thank you!


python311Packages.env-canada: 0.5.37 -> 0.6.0

Diff: https://github.com/michaeldavie/env_canada/compare/refs/tags/v0.5.37...v0.6.0
Changelog: https://github.com/michaeldavie/env_canada/blob/v0.6.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 260369 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.environment_canada
python310Packages.env-canada
python310Packages.env-canada.dist
python311Packages.env-canada
python311Packages.env-canada.dist


What do "expiry_time" stand of ?

Dear all , i love this Lib
any way , i did not understand the "expiry_time" directive .
is it mean the login will be "expired" in thats date , or the "IP Address" will no longer available after that Date !

Hi, thanks. Unfortunately, I have no idea what expiry_time means, sorry. Let me know if you figure it out! Thanks.


Create a nice setup for standard class names

So far we have waldo and vanilla classes that are used in multiple places. Current implementation could be better.
Perhaps restructure the classes as follows:
.vanilla.button

.waldo.button
  @extend .vanilla

.button
  @extend .waldo

This should have the lowest amount of stylus code, but might result in weird css ordering and / or over selecting styles.

Currently I have chosen to use a constructor class. Used in a lot of other frameworks, this approach has some heavy code duplication (need to fix) but allows easy changing of styles without having to use much brain power. It should take care of any css inheritance as long as there is always a fallback else in the constructor.
Usage in element/button.styl:
//==================
// constructor
//==================

$button(s = "normal", c = #000)
  -webkit-tap-highlight-color transparent
  border-radius 2px
  cursor pointer
  display inline-block
  margin 6px
  min-height 1rem
  outline none
  padding 6px 12px
  text-decoration none
  transition all .1s ease
  user-select none
  white-space nowrap

  if s == "normal"
    border 1px solid rgba(c, 0.4)
    color c
  else
    border 1px solid transparent
    color inherit

  if s != "vanilla"
    &:hover,
    &:focus
      border-color rgba(c, .4)
      box-shadow 0 0 4px rgba(c, .1), 0 4px 8px rgba(c, .2)
      color c

    &:active
      background-color rgba(c, .1)
      border-color rgba(c, 0.3)
      box-shadow inset 0 0 4px rgba(c, .1), inset 0 2px 6px rgba(c, .2)
      color c
  else
    &:hover,
    &:focus,
    &:active
      background-color inherit
      border-color transparent
      box-shadow none
      color inherit

//==================
// construction
//==================

button,
.button
  $button("normal")

  for n, c in $colors
    &.{n}
      $button("normal", c)

button.waldo,
.button.waldo
  $button("waldo")

  for n, c in $colors
    &.{n}
      $button("waldo", c)

button.vanilla,
.button.vanilla
  $button("vanilla")

Closing for current working implementation


Update VPC subnets and enable support for load balancer controller

This will add tags needed for the subnets by the load balancer controller add on and update required policy and SG rules

LGTM


How to execute cursor.forEach() method

I need to execute this method on some find() query but didn't find how to do it.
Is there a way to do something like that?
This is my use case.

What you linked is the documentation for the mongo shell. Running cursor.forEach there is the same as iterating over the results of a findBy call in a repository.

Oh, I see now. Thanks.


Readme: language -> locale

The readme is wrong about the name of the field in app.php that we need to edit.

thanks


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
980e1559e2c464430106bdb0b63f0cb1647fdaf0
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
980e1559e2c464430106bdb0b63f0cb1647fdaf0
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
980e1559e2c464430106bdb0b63f0cb1647fdaf0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Convert indexed ARRAY_AGG to NTH_VALUE

Is your feature request related to a problem or challenge?
Query below
SELECT a, ARRAY_AGG(c ORDER BY c)[1] as result
                        FROM multiple_ordered_table
                        GROUP BY a;

and
SELECT a, NTH_VALUE(c, 1 ORDER BY c) as result
                        FROM multiple_ordered_table
                        GROUP BY a;

produces same results. However, first query generates following plan
"ProjectionExec: expr=[a@0 as a, (ARRAY_AGG(multiple_ordered_table.c) ORDER BY [multiple_ordered_table.c ASC NULLS LAST]@1).[1] as result]",
"  AggregateExec: mode=Single, gby=[a@0 as a], aggr=[ARRAY_AGG(multiple_ordered_table.c)], ordering_mode=Sorted",
"    CsvExec: file_groups={1 group: [[CSV_PATH]]}, projection=[a, c], output_orderings=[[a@0 ASC NULLS LAST], [c@1 ASC NULLS LAST]], has_header=true",

whereas second query generates following plan
"ProjectionExec: expr=[a@0 as a, NTH_VALUE(multiple_ordered_table.c,Int64(1)) ORDER BY [multiple_ordered_table.c ASC NULLS LAST]@1 as result]",
"  AggregateExec: mode=Single, gby=[a@0 as a], aggr=[NTH_VALUE(multiple_ordered_table.c,Int64(1))], ordering_mode=Sorted",
"    CsvExec: file_groups={1 group: [[CSV_PATH]]}, projection=[a, c], output_orderings=[[a@0 ASC NULLS LAST], [c@1 ASC NULLS LAST]], has_header=true",

Describe the solution you'd like
we can rewrite first query as second one, which executes faster with less memory. Because it no longer needs to keep all results in the array_agg.
Describe alternatives you've considered
No response
Additional context
No response

I can do this one

Hello @mustafasrepo  could you give me the actual table creation SQL for this issue?

Hello @mustafasrepo could you give me the actual table creation SQL for this issue?

Sure,
CREATE EXTERNAL TABLE multiple_ordered_table (
  a0 INTEGER,
  a INTEGER,
  b INTEGER,
  c INTEGER,
  d INTEGER
)
STORED AS CSV
WITH HEADER ROW
WITH ORDER (a ASC, b ASC)
WITH ORDER (c ASC)
LOCATION '../core/tests/data/window_2.csv';

you can create the table in the queries with above snippet

take

As @Lordworms  points out, maybe we can try to implement this feature in some way that is general and not special cased in the optimzer -- aka https://github.com/apache/arrow-datafusion/issues/9289
This would look like

Making ARRAY_AGG an AggregateUDF (which probably would mean making a datafusion-aggregates crate
Adding an API to do the rewrite

This would certainly take more work and thus more time than just implementing a special case for the BuiltInAggregateFunction, so I don't think it is necessary
However, if we think this is a reasonbale approach I can file some tickets with the basic ideas sketeched out (I didn't want to sketch out too many things at once and we already have a bunch of work related to pulling out scalar UDFs)

Yes, I truely want to add some general approach instead of writing some "if else", I would try to work this out


[CMAKE][BUILD] Add config option to enable OpenCL Host ptr

Added config option to enable OpenCL host pointer flag for MLC-TVM build.

@srkreddy1238 Please take a look to this PR.

I saw this, what is this for?

I saw this, what is this for?

@federicoparra : The configuration to enable opencl host pointer feature in tvm, which enable to get cpu host pointer directly for opencl buffer pointer,
https://github.com/apache/tvm/pull/16929/files

I use Mali, do I need to do anything to enable this performance increase? I did chose that option when I built (in choose both opencl and opencl ptr). Thanks!

I use Mali, do I need to do anything to enable this performance increase? I did chose that option when I built (in choose both opencl and opencl ptr). Thanks!

As Opencl Host ptr is official opencl feature, So it should work for mail device as well.

Should I select both during the build (OpenCL & OpenCL Host prt) or only one?

Any other thing I should do to enable the optimization?


Do not disturb

Goofy does not respect do not disturb :'(

@sdaitzman Hi Sam! Sorry I'm not sure I understand 😕, did you mean when you put macOS into DnD you still receive notifications for Goofy?

Sorry, sent this as a placeholder issue intending to add more detail an hour later, then my meeting ran over.
When DnD is on, Goofy still produces the notification sound. A potential fix could be muting the sounds while do not disturb is turned on. I know there's a weird intersection between the native macOS app and the webview, so this may be tricky to implement nicely.

👍 I find myself having to mute conversations when I enable DnD which is quite annoying to have to do


Create Packer Templates for Ubuntu

Create Packer Templates for Ubuntu LTS, non-LTS versions.

userdel in provisioning not working! need to find alternative


refactor: use wasmtime for cargo test

The Enarx.toml is not required for tests to run, just use wasmtime directly for speed and simplicity

Is the difficulty using Enarx with Nix?

The ultimate goal is to run Steward with Enarx, so why not cargo run and cargo test with Enarx?
From today's call:

The runtime issue of Enarx will be addressed shortly, and the problem has been identified https://github.com/enarx/enarx/issues/2280.
This PR does not address the opening of the port needed for Steward to run with cargo run. Granted ports aren't needed for cargo test, breaking cargo run isn't worth it. The whole point of this file is to avoid having to manually set environment variables or manually specify paths. This PR seems to be a step backwards.

@bstrie will rework this once enarx run is improved


WIP: adding DSP for FAN_ALTs and BYPs to 050-pip-seed

I am still running the build but it seems that all the FAN_ALT?.GFAN? are being correctly solved.
This is to solve https://github.com/SymbiFlow/prjxray/issues/611 and https://github.com/SymbiFlow/prjxray/issues/567
Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>

The fuzzer correctly solves some of the FAN_ALT?.GFAN? pips, but not all of them. I am trying to do another build with a min_progress set to a lower value, because the build finished after iteration 3. Probably I will need to add some other features to the DSP to get all the remaining FAN_ALT pips

The fuzzer correctly solves some of the FAN_ALT?.GFAN? pips, but not all of them. I am trying to do another build with a min_progress set to a lower value, because the build finished after iteration 3. Probably I will need to add some other features to the DSP to get all the remaining FAN_ALT pips

Update https://github.com/SymbiFlow/prjxray/blob/master/fuzzers/050-pip-seed/Makefile#L87 to include "FAN_ALT?.GFAN?" in the required solution set.
So something like "--zero-entries-filter (IMUX.*GFAN)|(FAN_ALT..GFAN)"

Looks like you are close, FAN_ALT1.GFAN1 is missing stimulus thought:
grep "FAN_ALT.*GFAN" 050-pip-seed/build/1/segbits_int_l.db
INT.FAN_ALT0.GFAN0 <m1 6> 21_00 25_00
INT.FAN_ALT1.GFAN1 <m1 0> <const0>
INT.FAN_ALT2.GFAN0 <m1 2> 21_16 25_16
INT.FAN_ALT3.GFAN1 <8 candidates>
INT.FAN_ALT4.GFAN0 <m1 7> 21_08 25_08
INT.FAN_ALT5.GFAN1 <m1 1> 00_20 01_43 21_40 25_40
INT.FAN_ALT6.GFAN0 <m1 8> 21_24 25_24
INT.FAN_ALT7.GFAN1 21_32 25_32

Yeah, but it should get solved in the other iterations

Looks like it wont, at least on artix7.

Looks like it wont, at least on artix7.

The reason for this is that all DSP tile within the ROI are DSP_R, so the INT_R solution converges with this PR, but not the DSP_L solution.  If I fix #566, then all INT tiles will have base addresses, and then including some DSP_L should make this work plus adding the change to the zero entries regexp.
I'm working on #566, half way done.

Yeah, unfortunately there is only one DSP column in the actual ROI. Anyway maybe I should produce more stimulus to be sure to get all those pips

I'm running a test removing the ROI on a7, I expect it to solve all of the FAN_ALT?.GFAN? pips.  If so, that is the simplest answer.

I'm running a test removing the ROI on a7, I expect it to solve all of the FAN_ALT?.GFAN? pips. If so, that is the simplest answer.

Experiment failed.  I think what is happening is that the DSP is not providing the expected stimulus because it is using the internal DSP TIEOFF block, rather than the INT tile TIEOFF block.  DSP was maybe not a good choice :/

With the latest build I have produced almost all the FAN_ALT.GFANs (FAN_ALT1/3/5 are still missing from segbits_int_l. My settings were:  --min-progress argument to 10 instead of 50 and without the regexp.
I don't think it was a bad choice after all. Maybe by tweaking some parameters we could force the routing to the INT TIEOFF. I will continue checking in this direction and see what I can get.

Unfortunately I cannot get all the ALT_FAN?.GFAN?. I think it should be best to do a dedicated fuzzer

Unfortunately I cannot get all the ALT_FAN?.GFAN?. I think it should be best to do a dedicated fuzzer

Sounds good.  Can you take that?

@litghost sure, no problem. I will make a 054 fuzzer replacing the old one that has been deleted a few weeks ago

This can be closed due to this other PR https://github.com/SymbiFlow/prjxray/pull/639


Project page displays wrong project when switching between projects

I'm testing some user workflows and discovered this issue:
When I switch between projects, sometimes the wrong project is displayed. For example, I enter project 3 first. When I then open project 3, the requested web address is correct (ID 3), but the wrong project gets displayed (project 2).
This appears to be reproducible.
It can be solved by doing a page-reload when on the project page. But if I switch to back to project 2 afterwards, project 3 is displayed.
If it was just the project page, it would be unfortunate, but not that big of a problem yet. It becomes a bigger problem because the datasets for the wrong project are then displayed and if I open a dataset, I'm actually sent to the dataset of the wrong project. Thus, a user may edit a dataset of a different project than they entered by mistake.
Here's a recording of this interaction:
https://drive.google.com/file/d/1eefiVv9jl3sndALtDpS6szdXaDwYkNSp/view?usp=sharing

Any reload seems to avoid this caching, e.g. also reloading on the project overview page. But we wouldn't expect our users to reload in normal workflows

Yes this is definitely a bug that has high priority.

Great, I can confirm that this bug is fixed now! :) Thanks @rkpasia !


Logical stream iterators

Here are some suggestions to improve the API for logical streams:
/// Rename from LogicalStreamType
pub enum LogicalType {
  Null,
  Bits(Positive),
  Group(Group),
  Union(Union),
  Stream(Stream),
}

impl LogicalType {
  /// Returns an iterator over resulting split items.
  pub fn split(&self) -> Split { ... }
  /// Returns an iterator over the physical streams resulting from splitting
  /// and mapping the element streams to physical streams.
  pub fn physical(&self) -> PhysicalSplit { ... }
}

/// An iterator over split items from a LogicalType.
pub struct Split(indexmap::set::IntoIter<SplitItem>);

impl Iterator for Split {
  type Item = SplitItem;
}
impl DoubleEndedIterator for Split { ... }
impl ExactSizeIterator for Split { ... }

/// An iterator over physical split items from a LogicalType.
pub struct PhysicalSplit(indexmap::set::IntoIter<SplitItem>);

impl Iterator for PhysicalSplit {
  type Item = PhysicalSplitItem;
}
impl DoubleEndedIterator for PhysicalSplit { ... }
impl ExactSizeIterator for PhysicalSplit { ... }

/// An element stream with a path name and LogicalType. Contains no nested
/// streams.
pub struct ElementStream {
  path_name: PathName,
  logical_type: LogicalType,
}

impl ElementStream {
  /// Returns the LogicalType of this element. Contains no nested streams.
  pub fn logical_type(&self) -> &LogicalType {
    &self.logical_type
  }
  /// Return all fields in this element stream
  pub fn fields(&self) -> Fields { ... }
}

impl From<ElementStream> for PhysicalStream { ... }

pub struct Signals(LogicalType);
impl Signals {
  /// Returns the LogicalType of this element.
  pub fn logical_type(&self) -> &LogicalType {
    &self.0
  }
  /// Returns all fields in these async signals.
  pub fn fields(&self) -> Fields { ... }
}

/// A split item is either an async signal (outside streamspace) or an element
/// stream (no nested streams).
pub enum SplitItem {
  Signals(Signals),
  Stream(ElementStream),
}

/// A split item is either an async signal (outside streamspace) or a physical
/// stream.
pub enum PhysicalSplitItem {
  Signals(Signal),
  Stream(PhysicalStream),
}

For the uses case of @ahadnagy this would result in something like this:
let haystack: LogicalType = ...;
let needle: &[Name] = ...;

let search: Option<SplitItem> = haystack
            .split()
            .find(|split_item|
                match split_item {
                    SplitItem::Signals(signals) => signals.fields(),
                    SplitItem::Stream(element_stream) => element_stream.fields(),
                }
                .keys()
                .windows(needle.len())
                .any(|name| name == filter)
            );

Given that we modify the Fields::keys method to return &[Name] instead of &PathName.
This also solves #27. We could also use a marker trait to distinguish between nested and unnested LogicalTypes.

To-do leftovers:
- [ ] Documentation
- [ ] Tests
- [ ] Discuss API design

Follow-up PRs can incorporate these interfaces in the generator module.


User class, Submission class update, folder restructure

Create User class that contains metadata about individual users
Update submission class so it uses subprocess
Restructure folders

Game class can import User and then maintain a list or dictionary of users and use the user methods to update their scores. But still need the game class as the top level I think


Get raw pixel buffer?

Hi, currently my code looks like:
request.get( { url: imageUrl, encoding: 'binary'}, function ( err, response, body ) {
		lwip.open( body, 'JPEG', ...
	})

Is this the wrong kind of buffer? How do I get the right kind of buffer from an image URL?

What is the specific problem you are having?

I don't recall the error anymore but should the above code work then?


BLE commands can send messages or calls

As #62 can now use BLE part of module so, add a functionality that if it receives the executable command like we send from Serial terminal it also execute it. these new feature will be added in v5:
module can control via B

[ ] BLE.
[ ] anyone with BLE can send message or also call a number.
[ ] it can also be use a debugging but not sure if it's a good idea
[ ] #42 no need to implement this issue.
[ ] #27 module can then communicate with other BLE devices
[ ] user can modify variables

finalized in #76


resource_metering naming issue on agent_address

resource_metering::Config::agent_address into
resource_metering::Config::receiver_address
Signed-off-by: lemonhx<EMAIL_ADDRESS>Release note
rename config resource-metering.agent_address to resource-metering.receiver_address

Please fix
[2021-09-23T07:16:27.615Z] test resource_metering::linux::test_resource_metering ... thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "unexpect fields: agent-address"', tests/integrations/resource_metering/test_suite/mod.rs:108:14

/merge

/merge

/run-all-tests


Add BH Viability Rankings to /om bh

One commit please. Squash it.

Sorry I'm new to git, I'm not sure exactly how to do that. I'll close this pull and submit a new one I guess.

That is not what "squash" means.

I did it @ABrambleNinja 5cd927d023df236e62b303597a31ec572a4655fb


[Bug Report] upload automatically upload mode, allowing multiple upload before-upload hook returns false or uploaded successfully

Element UI version
1.3.1
OS/Browsers version
5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36
Vue version
2.3.3
Reproduction Link
http://jsfiddle.net/p41q54s9/
Steps to reproduce
已经限制了4张，然后不一张一张上传，直接一次上传5张，然后再继续上传
What is Expected?
应该阻止上传
What is actually happening?
还可以继续上传

好像是on-success没有触发，或者说触发了一次sucess

I can not clear what you want to limit. Your demo is about limiting the size of upload-file insteadof the size. Please checkout your problem.


Getting Type Error while training Convnet using nolearn.lasagne

I am trying to train convnet model using nolearn.lasagne but it seems like there is some issue with labels type. Any help is appreciated. Thanks a lot.
code:
import os
import numpy as np
from PIL import Image
import theano
import lasagne
from lasagne import layers
from lasagne.updates import nesterov_momentum
from nolearn.lasagne import NeuralNet
from sklearn.preprocessing import LabelEncoder
def traindata(path):
label_paths=[os.path.join(path,'train',f)
for f in os.listdir(os.path.join(path,'train'))]
# feature variables
images_train=[]
labels_train=[]
# Traverse along the labeled folders
for label_path in label_paths:
# Extract images belong to the label
image_paths=[os.path.join(label_path,q) for q in os.listdir(label_path)]
label=int((os.path.split(label_path)[1])[1]) # a numeric value (0-9)
# Traverse along the images
for image_path in image_paths:
image_pil=Image.open(image_path).convert('L')
image=np.array(image_pil,'uint8')
image=image.reshape((-1,1,640 ,480 ))
images_train.append(image)
labels_train.append(label)
return images_train,labels_train
path="I:/abd" # location of train data having subfolders for each class which contain images.
images_train, labels_train=traindata(path)
labels_train= np.array(labels_train).astype(np.int32)
net1 = NeuralNet(
layers=[('input', layers.InputLayer),
('conv2d1', layers.Conv2DLayer),
('maxpool1', layers.MaxPool2DLayer),
('conv2d2', layers.Conv2DLayer),
('maxpool2', layers.MaxPool2DLayer),
('dropout1', layers.DropoutLayer),
('dense', layers.DenseLayer),
('dropout2', layers.DropoutLayer),
('output', layers.DenseLayer),
],
# input layer
input_shape=(None, 1,640,480),
# layer conv2d1
conv2d1_num_filters=32,
conv2d1_filter_size=(20, 20),
conv2d1_nonlinearity=lasagne.nonlinearities.rectify,
conv2d1_W=lasagne.init.GlorotUniform(),
# layer maxpool1
maxpool1_pool_size=(2, 2),
# layer conv2d2
conv2d2_num_filters=32,
conv2d2_filter_size=(20, 20),
conv2d2_nonlinearity=lasagne.nonlinearities.rectify,
# layer maxpool2
maxpool2_pool_size=(2, 2),
# dropout1
dropout1_p=0.5,
# dense
dense_num_units=256,
dense_nonlinearity=lasagne.nonlinearities.rectify,
# dropout2
dropout2_p=0.5,
# output
output_nonlinearity=lasagne.nonlinearities.softmax,
output_num_units=10,
# optimization method params
update=nesterov_momentum,
update_learning_rate=0.01,
update_momentum=0.9,
max_epochs=10,
verbose=1,
)
#Training
conv=net1.fit(images_train,labels_train)
Output:
Traceback (most recent call last):
File "finalproject.py", line 97, in
conv=net1.fit(images_train,labels_train)
File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\nolearn\lasagne
\base.py", line 293, in fit
self.train_loop(X, y)
File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\nolearn\lasagne
\base.py", line 300, in train_loop
X, y, self.eval_size)
File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\nolearn\lasagne
\base.py", line 404, in train_test_split
X_train, y_train = X[train_indices], y[train_indices]
TypeError: only integer arrays with one element can be converted to an index

Hi,
there seems to be a problem with your numpy arrays. I believe it's best if you could run with pdb and inspect your X, y and train_indices.
Btw., when you paste code blocks, use triple back-ticks before and after:
```
def fun(x):
return x + 1
```
becomes:
def fun(x):
    return x + 1

Sir,
First of all Thank you very much for replying. As directed above i have tried using pdb for debugging but it is in turn giving me an error. Can you please help!
[snakes] C:\Theano-master>python -m pdb finalproject.py
Traceback (most recent call last):
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 1661, in main
    pdb._runscript(mainpyfile)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 1542, in _runsc
ript
    self.run(statement)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 431, in run
    exec(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "c:\theano-master\finalproject.py", line 1, in <module>
    import os
  File "c:\theano-master\finalproject.py", line 1, in <module>
    import os
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 48, in trace_di
spatch
    return self.dispatch_line(frame)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 66, in dispatch
_line
    self.user_line(frame)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 259, in user_li
ne
    self.interaction(frame, None)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 2
44, in interaction
    self.print_stack_entry(self.stack[self.curindex])
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 7
98, in print_stack_entry
    print('[%d] >' % frame_index, file=self.stdout, end=' ')
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\codecs.py", line 374, in writ
e
    self.stream.write(data)
TypeError: must be str, not bytes
Uncaught exception. Entering post mortem debugging
Running 'cont' or 'step' will restart the program
Traceback (most recent call last):
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 1661, in main
    pdb._runscript(mainpyfile)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 1542, in _runsc
ript
    self.run(statement)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 431, in run
    exec(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "c:\theano-master\finalproject.py", line 1, in <module>
    import os
  File "c:\theano-master\finalproject.py", line 1, in <module>
    import os
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 48, in trace_di
spatch
    return self.dispatch_line(frame)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\bdb.py", line 66, in dispatch
_line
    self.user_line(frame)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 259, in user_li
ne
    self.interaction(frame, None)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 2
44, in interaction
    self.print_stack_entry(self.stack[self.curindex])
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 7
98, in print_stack_entry
    print('[%d] >' % frame_index, file=self.stdout, end=' ')
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\codecs.py", line 374, in writ
e
    self.stream.write(data)
TypeError: must be str, not bytes

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\runpy.py", line 170, in _run_
module_as_main
    "__main__", mod_spec)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\runpy.py", line 85, in _run_c
ode
    exec(code, run_globals)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\_pdbpp_path_hac
k\pdb.py", line 5, in <module>
    os.path.dirname(os.path.dirname(__file__)), 'pdb.py'), 'exec'))
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 1
096, in <module>
    pdb.main()
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\pdb.py", line 1680, in main
    pdb.interaction(None, t)
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 2
44, in interaction
    self.print_stack_entry(self.stack[self.curindex])
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\site-packages\pdb.py", line 7
98, in print_stack_entry
    print('[%d] >' % frame_index, file=self.stdout, end=' ')
  File "C:\Users\Nishank\Anaconda3\envs\snakes\lib\codecs.py", line 374, in writ
e
    self.stream.write(data)
TypeError: must be str, not bytes

Check this stackoverflow question
I think your labels and data must be numpy arrays, in your code they are lists of numpy arrays.
Maybe also do a sanity check on the shapes of X, y and train_indices.

Yes, please verify that X and y are correct numpy arrays:
print(type(X), type(y))
print(X.shape, y.shape)

Why your pdb call does not work is not clear to me. Perhaps you can set it manually at the corresponding line of code:
import pdb
...
pdb.set_trace()

Thanks for the suggestions. I could realize that X and y were not correct numpy arrays and therefore I have converted both of them to class: numpy.ndarray explicitly and with the shape
X -> (22000,1,100,100)
y -> (22000,)
and now on training the same model and testing with other images (30000 data sets belonging to different classes) I could see that all of the images are getting classified under one single label (class). To understand it clearly I have also used .predict_proba to get the probabilities under each label but the result show 1 under one specific label and 0 under the rest for all the images.
Could anyone please help?

Somehow the net does not learn anything from the data and comes up with the best solution it can do. There could be numerous reasons for why that happens. To solve this remotely is almost impossible. Please search for hyper-parameter optimization, check that your data are correct (shuffling, reshaping, etc. could be sources of error). One of the first things I check when my net does not learn is the learning rate, so maybe try that.
Otherwise, if your original issue is solved, I believe this thread can be closed.

Thank you very much for the suggestions...


Release Google.Cloud.DocumentAI.V1 version 3.3.0

Changes in this release:
New features

Added sharding_config field in DocumentOutputConfig.GcsOutputConfig in document_io.proto (commit 2fb53d4)
Added process_options field in ProcessRequest in document_processor_service.proto (commit 2fb53d4)
Added sample_document_uris field in ProcessorType in processor_type.proto (commit 2fb53d4)

Created release for Google.Cloud.DocumentAI.V1-3.3.0


HBASE-22586 Javadoc Warnings related to @param tag

Fixed javadoc warnings related to @param tag.

@syedmurtazahassan Could you please resolve the merge conflict?

@syedmurtazahassan any updates on this?

@jatsakthi Resolved the merge conflict. Kindly review.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
29
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
230
master passed

+1
compile
107
master passed

+1
checkstyle
110
master passed

+1
shadedjars
252
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
305
master passed

+1
javadoc
80
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
237
the patch passed

+1
compile
111
the patch passed

+1
javac
111
the patch passed

+1
checkstyle
23
The patch passed checkstyle in hbase-common

+1
checkstyle
10
The patch passed checkstyle in hbase-hadoop2-compat

+1
checkstyle
64
hbase-server: The patch generated 0 new + 87 unchanged - 4 fixed = 87 total (was 91)

+1
checkstyle
16
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
262
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
717
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
343
the patch passed

+1
javadoc
87
the patch passed

_ Other Tests _

+1
unit
189
hbase-common in the patch passed.

+1
unit
34
hbase-hadoop2-compat in the patch passed.

+1
unit
7950
hbase-server in the patch passed.

+1
unit
1063
hbase-mapreduce in the patch passed.

+1
asflicense
78
The patch does not generate ASF License warnings.

12681

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/322

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux f4a38da3d394 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c8dc5d97e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/1/testReport/

Max. process+thread count
5462 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

improvements

@HorizonNet Thank you. Addressed your comments. Kindly have a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
165
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
249
master passed

+1
compile
117
master passed

+1
checkstyle
126
master passed

+1
shadedjars
269
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
315
master passed

+1
javadoc
84
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
239
the patch passed

+1
compile
117
the patch passed

+1
javac
117
the patch passed

+1
checkstyle
25
The patch passed checkstyle in hbase-common

+1
checkstyle
12
The patch passed checkstyle in hbase-hadoop2-compat

+1
checkstyle
69
hbase-server: The patch generated 0 new + 84 unchanged - 7 fixed = 84 total (was 91)

+1
checkstyle
16
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
704
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
349
the patch passed

+1
javadoc
83
the patch passed

_ Other Tests _

+1
unit
181
hbase-common in the patch passed.

+1
unit
35
hbase-hadoop2-compat in the patch passed.

-1
unit
16627
hbase-server in the patch failed.

-1
unit
1539
hbase-mapreduce in the patch failed.

+1
asflicense
96
The patch does not generate ASF License warnings.

22062

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.client.TestAsyncSnapshotAdminApi

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/322

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 458c23988b59 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c8dc5d97e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/2/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/2/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/2/testReport/

Max. process+thread count
5305 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Re-running build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
51
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

0
mvndep
18
Maven dependency ordering for branch

+1
mvninstall
274
master passed

+1
compile
121
master passed

+1
checkstyle
128
master passed

+1
shadedjars
276
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
320
master passed

+1
javadoc
86
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
240
the patch passed

+1
compile
119
the patch passed

+1
javac
119
the patch passed

+1
checkstyle
24
The patch passed checkstyle in hbase-common

+1
checkstyle
12
The patch passed checkstyle in hbase-hadoop2-compat

+1
checkstyle
72
hbase-server: The patch generated 0 new + 84 unchanged - 7 fixed = 84 total (was 91)

+1
checkstyle
17
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
264
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
742
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
341
the patch passed

+1
javadoc
84
the patch passed

_ Other Tests _

+1
unit
174
hbase-common in the patch passed.

+1
unit
43
hbase-hadoop2-compat in the patch passed.

-1
unit
16057
hbase-server in the patch failed.

-1
unit
1587
hbase-mapreduce in the patch failed.

+1
asflicense
133
The patch does not generate ASF License warnings.

21568

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.master.TestMasterShutdown

hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/322

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux a6a0f5a14afd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 52eb893bcc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/3/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/3/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/3/testReport/

Max. process+thread count
5447 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

LGTM

@jatsakthi
Should i fix all such cases as a part of this ticket?
Because in this ticket i added javadoc for compareWithoutRow() and didnt touch compare() so i didnt know CellComparator's link is not there.

@syedmurtazahassan My suggestion is, if you need to touch the class due to param changes, you can do it in this PR.

@HorizonNet
Thanks for valuable comments. I will address them and make the fixes accordingly..

@jatsakthi @HorizonNet Adressed the comments. Kindly have a look when you have time.
Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
179
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
260
master passed

+1
compile
114
master passed

+1
checkstyle
117
master passed

+1
shadedjars
271
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
320
master passed

+1
javadoc
82
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
241
the patch passed

+1
compile
113
the patch passed

+1
javac
113
the patch passed

+1
checkstyle
21
hbase-common: The patch generated 0 new + 63 unchanged - 8 fixed = 63 total (was 71)

+1
checkstyle
10
The patch passed checkstyle in hbase-hadoop2-compat

+1
checkstyle
63
hbase-server: The patch generated 0 new + 84 unchanged - 7 fixed = 84 total (was 91)

+1
checkstyle
16
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
261
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
760
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
344
the patch passed

+1
javadoc
79
the patch passed

_ Other Tests _

+1
unit
172
hbase-common in the patch passed.

+1
unit
36
hbase-hadoop2-compat in the patch passed.

-1
unit
14981
hbase-server in the patch failed.

+1
unit
1360
hbase-mapreduce in the patch passed.

+1
asflicense
108
The patch does not generate ASF License warnings.

20304

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/322

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux b1781cd27745 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 605f8a15bb

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/4/testReport/

Max. process+thread count
5278 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

LGTM

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
88
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

0
mvndep
15
Maven dependency ordering for branch

+1
mvninstall
270
master passed

+1
compile
123
master passed

+1
checkstyle
141
master passed

+1
shadedjars
303
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
387
master passed

+1
javadoc
89
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
275
the patch passed

+1
compile
129
the patch passed

+1
javac
129
the patch passed

+1
checkstyle
28
hbase-common: The patch generated 0 new + 63 unchanged - 8 fixed = 63 total (was 71)

+1
checkstyle
12
The patch passed checkstyle in hbase-hadoop2-compat

+1
checkstyle
83
hbase-server: The patch generated 0 new + 84 unchanged - 7 fixed = 84 total (was 91)

+1
checkstyle
19
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
303
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
847
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
413
the patch passed

+1
javadoc
93
the patch passed

_ Other Tests _

+1
unit
182
hbase-common in the patch passed.

+1
unit
35
hbase-hadoop2-compat in the patch passed.

-1
unit
15663
hbase-server in the patch failed.

+1
unit
1726
hbase-mapreduce in the patch passed.

+1
asflicense
147
The patch does not generate ASF License warnings.

21776

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/322

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 14577bb991f8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 438bf3284e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/5/testReport/

Max. process+thread count
5437 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-322/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Write tests for the API / CLI

Description
Currently, it is getting difficult to continue developing the new API as there are no tests. We need to write tests for the current functionality and configure GitHub and CodeCov to check for a threshold.
@weilbith Anything to add?
Acceptance criteria

Why do this?
We should have tests in place to ensure the CLI/API works as intended.

No not really. I just want to say that these tests should not test the protocol functionality of the SDK, but actually only this application interface. But sure there will be an intersection.
The big question (for me) is how we would design these tests. For development it would be great to have some kind of unit test properties. So they allow you to follow a test driven development approach. On the other side this is pretty much end-to-end testing, since the API is at its best be a thin wrapper only. Mocking the SDK would solve that, but may be too much work or simply not accurate enough. Especially when implementing new endpoints. This is a bit strange because the SDK is concurrent touched to support the CLI as good as it can. So back again: this are at least integration tests, more likely end-to-end tests.
After all I would like to be sure that I did not destroy anything when I open a PR. So in case there is only a complex e2e solution, I would argue to let it do the CI setup.

If we don't go with mocking/stubbing then the other approach is essentially e2e. We could use the infrastructure (docker image) that already exists for e2e if we need, but they will be slower compared to unit tests since they require starting the docker image to run them.

@andrevmatos Could you update this issue with some more details on which tests make sense writing? I guess adding some e2e tests should be enough?