Add a Headers structure

Describe the feature
In the current codebase, we frequently utilize the Vec<Header> structure. Inspired by the approach suggested in this pull request for Withdrawals, it seems beneficial to introduce a dedicated Headers struct type. This new struct would encapsulate the vector of Header instances, promoting better code organization and maintainability.
Proposed Changes
The proposed changes involve the creation of a Headers struct that internally manages a Vec<Header>. This encapsulation not only provides a more coherent representation but also facilitates future enhancements.

Abstraction: The new struct abstracts away the internal representation of headers, allowing for easier modifications or optimizations in the future.

Consistency: Following a similar pattern as seen in PR #6267 for Withdrawals promotes consistency within the codebase.

Additional context
No response

Hi, I would like to work on this issue, is it still available?

Hi, I would like to work on this issue, is it still available?

we generally review PRs on a first come first serve basis, so feel free to submit a PR!


Show latest meaningful poll results in autopilot

Shows the latest meaningful poll result in autopilot
The last published poll result from the corresponding content object

@emanuelschuetze fixed the errors. Can be tested, needs cleanup.

restructured and refactored how and when charts are drawn
improved performance of cinema and chart drawing
unknown resize issues in charts JS that occures in autopilot when the cart was redrawn, cannot be altered using CSS for unkown reasons

ping @emanuelschuetze

restructured *-poll-detail-content-component to be more transparent about it's current status and behavior for autopilot, projector, poll-view and poll-detail-view and all four states.
this change is heavy, test with care.

Retested:
Project a (motion) poll. Go to autopilot.
=> The projector is empty!


Adding CDMA to signal generation

Directly from the discussion in #8
Basic use for the moment, with spreading and multiplexing with OVSF code

[x] Integration in specific CDMA call
[x] Integration in genSig decodeSig
[x] tests
[ ] MOARE code support (only OVSF atm)
[ ] proper documentation

Open discussion on how we shape the input payload matrix. We modulate a matrix defined as Users x time matrix.  We define user per column which is not the more computational efficient (we process data user per user) but it has the advantages to be similar to what we do when we modulate with OFDM where data in column corresponds to the subcarriers. We mimic the subcarrier multiplexing (CDMA) by a multiplexing by code.

@RGerzaguet  Thank you for your wonderful base. I was wondering how Users x time matrix would not be computational efficient ? Could you please explain a little bit more ? Are you referring to julia or are you referring to code structure ? Also I had suggestion, if we can keep the parameters same for everything then it would be easy for end users. I am referring to BER or PSD examples. Are we planning to add CDMA in them as well ? Also we can add support for gold codes, I am working on that right now.

Hello @patel999jay.
Indeed Julia is column wise defined for memory. It means that getindex for a matrix is faster if we iterate through column and not lines. For OFDM this is what we do: signal is defined in a Time x Freq matrix so as we access to data in frequency domain (symbol per symbol) -  it is column wise.
For CDMA, as I have coded it, we have a Time x user matrix. But contrary to OFDM we generate data user per user (all symbols per user) so we access data per row.
Not really sure what is the performance penalty in the end and I really like the fact that the time x freq mirrors the time x user (or time x code)  matrix between the waveforms so let's keep it like this :)
Regarding examples, sure I will add CDMA to them  ! I would be really glad to add your contribution on gold codes also 👍


silence the "ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time" warning

duplicate


4 year old version of DPDK?

While I am happy to see you doing this, shipping a 4 year old version of the dpdk does not help your cause. When will this be supported by mainline dpdk?

we will add dpdk 20.11/21.11 later. The mainline dpdk will add to our milestone, thank you for your option.

we have update the dpdk version to 24.03, and will follow the master, will clost it.


Java Collection : Vector

Type
Collection
Directory
Collection => Vector => Vector.java
Description
Just declare the data structure, take the input dynamically, demonstrate some inbuilt methods.
Programming Language

[ ] c++
[ ] c
[ ] python
[ ] java
[ ] kotlin
[ ] javascript
[ ] typescript
[ ] c#
[ ] swift
[ ] ruby
[ ] scala
[ ] go
[ ] php
[ ] haskell
[ ] bash

i can work with the c++ implementation

I would like to work on this issue, please consider my profile for this task and do assign it to me.


Unable to trigger Zooz ZSE33 chimes with 10.1.0

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
Upgrading to 10.0.4 prevents Zooz ZSE33 chime from triggering or configuration changes from taking effect
What do you observe?
Setting '[11-37-0-targetValue] Target value' to true does not make chime trigger. '[11-37-0-currentValue] Current value' does toggle to true then back to false, but no activation of device.
Have also noticed that making changes to configuration, like setting '[11-112-0-6] Chime Tone' does not take effect.
What did you expect to happen?
Chime to make sounds and configuration changes to be made.
Steps to reproduce the behaviour:

Find device in list, expand Binary Switch options
Click on "ON" button to toggle on
Observe that the UI slowly updates to show the state change (previous version was immediate), but no sounds or lights are toggled on the device.

Configuration changes
1. Find device in list, expand Configuration options
2. Change an option, such as '[11-112-0-6] Chime Tone'
3. Click the Send button
4. Observe that the original setting is reverted in the UI, or refresh and note that no change has been made
Device information
Manufacturer: Zooz
Model name: ZSE33
Node ID in your network: 11
(have another, device ID 10)
How are you using node-zwave-js?

[ ] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version: home assistant zwavejs2mqtt addin 0.46.1
node-zwave-js branch: 10.0.4
zwavejs2mqtt branch: 7.1.0
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
Yes (please describe)
If yes, where did it work?
Works with previous home assistant zwavejs2mqtt addin with these versions:
Attach Driver Logfile
zwavejs_current.log

I triggered another re-interview of the devices (then woke them up) and both started to work. I'm not sure what I did wrong the first time. Closing this.


How to configure slack-chat for atom

I followed the guide in description and set http://<IP_ADDRESS>:36347/oauth as redirect uri in slack app but when I restart atom and click in "Authorize" nothing happens because obviously http://<IP_ADDRESS>:36347/oauth is unreachable

Slack chat starts a server that listens for http://<IP_ADDRESS>:36347/oauth. I just ran through the install again myself and didn't run into any issues.  At this point, everything should be configured properly. Try opening the command palette and executing Slack Chat: Toggle
If you get an error somewhere, feel free to reopen the issue with the error message.

When I configure slack and restart it a popup window of my browser opens and takes me to slack where I'm told to authorize the third party app, when I do this my browser tries to reach http://<IP_ADDRESS>:36347/oauth but I get a 404 error, the page isn't found. I'm running atom under Windows 10, maybe is this the problem?


Scan for first HXLated resource on CKAN

In hxl.io URL munging, if the source URL is a CKAN dataset page (rather than resource page or direct link), keep scanning resources until we find one with HXL hashtags.
Here's an example of a dataset that causes problems: https://data.humdata.org/dataset/cadre-harmonise (currently has PDFs as the first two resources).
cc @danmihaila

Here's another dataset where scanning is necessary:
https://data.humdata.org/dataset/drc_presence_operationnelle

The logic may end up in hxl/input.py in the _get_ckan_url function.

Implemented in hxl.input.data(), so it works only on the dataset level, and not the raw input level. That was the only way to avoid opening a HXLated dataset twice without extensive refactoring.


Enhancement: Raise phpstan level from 2 to 3

This PR

[x] raises the phpstan level from 2 to 3
[x] fixes issues reported by phpstan

❗ Blocked by #762.
❗ Blocks #768.

Thank you, @svpernova09!


GPIO: Add DIRIN and DIROUT registers

Makes it possible to set direction of pins individually.
Fixes #59
Signed-off-by: Ola Jeppsson<EMAIL_ADDRESS>

Not sure I buy the need for individual control of DIRIN/DIROUT per pin. Better to just make DIR readable. Can you find a strong use case?
Examples:
http://www.ti.com/lit/ug/spru584a/spru584a.pdf
http://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf

With this there's no problem sharing a slice between threads. If you just make it readable you need to add a global lock around GPIO_DIR or make the block support atomic operations.
You didn't want to make regs readable to save gates / reduce longest path?
The Texas implementation is for a one-core DSP, the Zynq one is either for a monolithic FPGA blob or Linux (which have locks in the driver)

On 2016-04-13 14:18, Andreas Olofsson wrote:

Not sure I buy the need for individual control of DIRIN/DIROUT per pin. Better to just make DIR readable. Can you find a strong use case?
Examples:
http://www.ti.com/lit/ug/spru584a/spru584a.pdf
http://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/parallella/oh/pull/60#issuecomment-209402208

... and to make the block fully sw lockless we'd also need SET/CLEAR versions of most interrupt registers.
Close?


Hotfix: route deviation criterion and misc

fixed bug in route deviation criterion
fixed bug in main challenge_evaluator_routes script: tip() not defined

Description

Fixes #
Where has this been tested?

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...
CARLA version: ...

Possible Drawbacks

This change is

srunner/challenge/challenge_evaluator_routes.py, line 644 at r1 (raw file):

                                                   behavior.tip().name,
                                                   behavior.tip().status))
                    if (behavior and behavior.tip() and behavior.tip().name !=

behavior is not None ? it is safer than checkin for true or false


stable hamcrest/hamcrest-php

Use a stable version (2.0+) of hamcrest/hamcrest-php instead of dev-master

Coverage remained the same at 75.534% when pulling 9935e731514fc53cba982833bd89370b1dc7574c on kornrunner:master into 812fcbd1c40cb5cd33e7ab48ffcf2ce8d202c74e on padraic:master.


Update for mirage-xen 4.0.0

Build was failing with:
Error: Unbound module OS.Xen

Travis passed, but the status didn't update on GitHub for some reason.


Week 3 Step 5

TLDR; Adds Datastore functionality, and ability to display comments on the site itself.
Link: https://ethanimooney-step-2020.appspot.com/
This is a long one, sorry...
pom.xml - Added the dependency for datastore
Comment.java - changed timestamp to a long, added id variable
DataServlet.java - renamed as NewCommentServlet.java
ListCommentsServlet.java - this servlet lists all of the comments in the Datastore when fetched. It creates a datastore query and then creates an ArrayList of Comment instances, looping through the query and creating an instance and adding it to the ArrayList
NewCommentServlet.java - this servlet adds a new comment entity to the datastore when fetched.
index.html - removed placeholder text, added an id for loadComments() to reference, and added the onload call to loadComments() in the body.
script.js - deleted old code, added the loadComments() function, which fetches ListCommentServlet.java, loading in the comments from the database. This function then calls the other new function, createCommentElement(). It takes in a passed single comment entity from the datastore and creates a commentElement, a div that will be passed back to loadCommments() and then displayed on index.html. It contains the author and message of the comment.
style.css - added functionality to make the div where the comments are displayed scrollable once the content becomes to tall for its max height.

Other interns have been commenting on it so don't judge me for the comments haha

It's pretty basic in design, will add more tomorrow once I do step 6. :)

Updated to reflect suggestions in comments.

Committed edits

Updated

Changed the ids for the form, and fixed the issue with submitting to datastore


MAINT: Remove redundant licence definition

Drop the licence key, keep the licence classifier, as suggested by PEP 639 draft.
From the Python Packaging User Guide:

If you are using a standard, well-known license, it is not necessary to use this field. Instead, you should use one of the classifiers starting with License ::.

Reported by validate-pyproject:
$ validate-pyproject pyproject.toml
Invalid file: pyproject.toml
[ERROR] `project.license` must be valid exactly by one definition (2 matches found):

    - keys:
        'file': {type: string}
      required: ['file']
    - keys:
        'text': {type: string}
      required: ['text']

$

and online:
https://learn.scientific-python.org/development/guides/repo-review/?repo=nipreps%2Fmriqc&branch=master

Our usage is in line with PEP 639 (license = <SPDX identifier>) while keeping the license identifiers that PyPI currently supports.
PEP 639 is supported by our build backend: https://hatch.pypa.io/latest/config/metadata/#license
It seems fine to me to keep both until PEP 639 is official and supported by PyPI, at which point we can drop the classifier. I expect that the linting tools will update their recommendations to match that plan, but we can see.

I think the linter tool claim is that you shouldn't have both a LICENSE file and license = "Apache-2.0" .  If you have a license file, then use:
license = {file = "LICENSE"}

otherwise use:
license = "Apache-2.0"

If I remove the classifier, I still get:
$ validate-pyproject pyproject.toml
Invalid file: pyproject.toml
[ERROR] `project.license` must be valid exactly by one definition (2 matches found):

    - keys:
        'file': {type: string}
      required: ['file']
    - keys:
        'text': {type: string}
      required: ['text']

$

I believe the JSON Schemas used by validate-pyproject use oneOf on purpose, and therefore won't change:

JSON Schemas - license
validate-pyproject/src/validate_pyproject/project_metadata.schema.json
Lines 102 to 132 in a46352d
    "license": {
      "description":
        "`Project license <https://peps.python.org/pep-0621/#license>`_.",
      "oneOf": [
        {
          "properties": {
            "file": {
              "type": "string",
              "$$description": [
                "Relative path to the file (UTF-8) which contains the license for the",
                "project."
              ]
            }
          },
          "required": ["file"]
        },
        {
          "properties": {
            "text": {
              "type": "string",
              "$$description": [
                "The license of the project whose meaning is that of the",
                "`License field from the core metadata",
                "<https://packaging.python.org/specifications/core-metadata/#license>`_."
              ]
            }
          },
          "required": ["text"]
        }
      ]
    },

Also, the relevant rule actually points to PEP 621, not to the PEP 639 draft. And in turn, PEP 621 points to the Python Packaging User Guide:

Attention
This PEP is a historical document. The up-to-date, canonical spec, pyproject.toml specification, is maintained on the PyPA specs page.

If PEP 639 is accepted, then they will need to add {type: "string"} to their oneOf, possibly with some kind of format. https://github.com/abravalheri/validate-pyproject/issues/70
Either way, hatchling supports PEP-639 right now and populates the sdist/wheel metadata documents correctly.

I understand that the current standard forbids to have both an SPDX license and a LICENSE file, as per PyPA specifications.
The future PEP 639 would require to:

Deprecate License, mutually exclusive with License-Expression
Add License-Expression, specified to contain a text string that is a valid SPDX license expression
Add License-File (optional)

If hatchlingsupports PEP-639 right now, how about switching to PEP 639?
But I get it, the most important thing is that the resulting packages are correctly populated, which they are.

I'm closing for now, but feel free to reopen if I shouldn't.

I could try to switch from license to license-expression right now, but it's probably best to wait for PEP 639 to be accepted.


Add vitest for frontend testing

Short Description
This pull request configures vitest and adds a simple test as suggested in my review of deps/upgrade_webauthn_2_0.
Proposed Changes

Added a test task to package.json
Included required vitest dependency
Implemented a simple test for URL and base64 encoding
Configure vitest to ignore python dependencies
Configure import/resolver to resolve imports correctly
Add job to circleci workflow

Pull Request Review Guidelines

@JoeyStk I've added a devtool and a pre-commit hook that calls it. ☺

Thank you very much :+1: This really is an improvement! Could you squash the first two commits into one? Then, this is good to go :)


feat(compute): let compute node handle deltas pushed from meta

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
feat(compute): let compute node handle deltas pushed from meta
this PR is successor of #4473
in #4473  we let meta push latest version deltas to CN
here we let CN handle them, so CN will no longer need call pin_version
Checklist
Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

Can you explain the background of this PR in the PR description?

just edited

TODO:
To entirely removing pin_version, we need to:

Fix ss_bench, that is add an observer manager for it too, to receive version update.
(Can be done in another PR)In LocalVersionManager::new, use a placeholder pinned_version rather than one got by pin_version, because it will be replace by notification snapshot anyway. Meanwhile we need to fix the min_pin_version_id, because there is no longer an explicit pin_version when CN starts.

benchmark of this PR:

benchmark of this PR:

create source person
(id INTEGER, name VARCHAR, "email_address" VARCHAR, "credit_card" VARCHAR, city VARCHAR, state VARCHAR, "date_time" TIMESTAMP)
with (
connector = 'nexmark',
nexmark.table.type = 'Person',
nexmark.split.num = '24',
nexmark.min.event.gap.in.ns = '0'
) row format json;
create source auction (id INTEGER, "item_name" VARCHAR, description VARCHAR, "initial_bid" INTEGER, reserve INTEGER, "date_time" TIMESTAMP, expires TIMESTAMP, seller INTEGER, category INTEGER)
with (
connector = 'nexmark',
nexmark.table.type = 'Auction',
nexmark.split.num = '24',
nexmark.min.event.gap.in.ns = '0'
) row format json;
create source bid (auction INTEGER, bidder INTEGER, price INTEGER, "date_time" TIMESTAMP)
with (
connector = 'nexmark',
nexmark.table.type = 'Bid',
nexmark.split.num = '24',
nexmark.min.event.gap.in.ns = '0'
) row format json;
CREATE MATERIALIZED VIEW nexmark_q7 AS
SELECT
B.auction,
B.price,
B.bidder,
B.date_time
FROM
bid B
JOIN (
SELECT
MAX(price) AS maxprice,
window_end as date_time
FROM
TUMBLE(bid, date_time, INTERVAL '10' SECOND)
GROUP BY
window_end
) B1 ON B.price = B1.maxprice
WHERE
B.date_time BETWEEN B1.date_time - INTERVAL '10' SECOND
AND B1.date_time;

benchmark without push scheme:


Update Deploy rerank english model.ipynb

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Rework the driver package interface. [phab:D1453]

Created by fromberger at 2017-03-24 21:03:58:
Separate the callbacks for setup, teardown, and error reporting from the
delivery of output. Pull out the handling of unset callbacks so that the main
flow of Run is less disrupted. Rename/rework the IO type as "Context".
Tests updated, etc.
Fix driver setup in the analysis_driver binary.

fromberger wrote at 2017-03-27 17:46:26:
Ping!

zarko accepted this revision at 2017-03-27 17:52:06

fromberger closed via commit 004ae605e7bddcd7d0276176c0a0544d5e276293 at 2017-03-27 17:57:24


Sort available contexts list

Hi!
Thanks for this tool - I only started using it but it looks very promising so far!
I was not able to find a way to get my list of available contexts appear sorted though. I mean mainly the output of switch (for switch list-contexts I would just pipe it to sort, but I don't need that). Is it possible to make this list sorted?

I am using the GKE store so I tried adding a list of specific projectIDs but the order from there is not retained in the output of switch...


add scrapy-loader-upkeep

Hi @croqaz, adding an additional lib :)

Thank you @BurnzZ for the lib 👍


strict_types Breaks Consuming Code

Note: This could be totally intentional, and it was for a major version, so not a problem. But wanted to make sure this was the intention. I don't think it was as the change log doesn't mention it as a breaking change, or even reference the potential issue:

zendframework/zend-diactoros#329 adds return type hints and scalar parameter type hints wherever possible. The changes were done to help improve code quality, in part by reducing manual type checking. If you are extending any classes, you may need to update your signatures; check the signatures of the class(es) you are extending for changes.

BC Break Report

Q
A

Version
2.x.x

Summary
Because strict_types are enabled in the library, but method arguments lack type hints (due to the interface understandably not type hinting arguments), Stream::write($string) and other methods accept values that can be juggled into the expected type (and were in the past), but now are rejected by the underlying f*() methods with a TypeError:
Previous behavior
$stream->write(false); // would write ''

Current behavior
$stream->write(false); // throws TypeError

TypeError : fwrite() expects parameter 2 to be string, bool given

How to reproduce
See my branch for a test / fix specific to write(); however, there are many other methods that have the same behavior.
We fixed on our end, I just wanted to make sure this behavior was known / documented.

https://github.com/php-fig/http-message/blob/efd67d1dc14a7ef4fc4e518e7dee91c271d524e4/src/StreamInterface.php#L108-L115
    /**
     * Write data to the stream.
     *
     * @param string $string The string that is to be written.
     * @return int Returns the number of bytes written to the stream.
     * @throws \RuntimeException on failure.
     */
    public function write($string);

As per the method signature false is not a valid value and it never was before.
Introduction of strict types did not change the signature so it is not a BC break for supported usage. In effect, what you experience is a bug on consumer side that was silently swallowed before but now it got exposed.
Aside for some specific cases, we implicitly trust framework users to adhere to interface as introduction of checks for all possible misuses will have negative impact on code readability and performance. There are tools that can be used as part of QA to detect those problems. Psalm and phpstan are probably the most used open source tools.
Generally, while I understand where you come from with a sloppy PHP type juggling usage custom in the community, depending on undefined and unsupported behavior have severe impact on code reliability and maintainability as highlighted here. I would recommend to proactively detect and fix it.
Since I do not consider this a bug on our side, I will mark the issue as invalid.

@Xerkus not sure I'd call it a consumer side bug, as before enabling strict types, type juggling could be reasonably expected (and to some extent, is still ambiguous, because the type is no more than annotation, not a proper hint).
But I don't disagree with closing this at all. Thanks for the quick reply.


tools: add '--native-build' option to lisa-build-asset

The '--native-build' option allows to natively compile an asset
instead of cross-compiling it. It uses alpine-chroot-install [1],
which installs Alpine Linux into a chroot and uses qemu to emulate
the desired architecture.
Only a few asset/architecture couples are currently available, so
the option only natively compiles an asset if possible.
As chroot requires root privileges, the '--native-build' option
also requires root privileges.
[1]: https://github.com/alpinelinux/alpine-chroot-install
TODO list:

[ ] perf: wait for some things to be accepted on the upstream project
[ ] All assets: update the binaries

This was actually possible to use the upstream alpine script as such, so no need to modify anythin

Thx for the patient review. I haven't update the assets yet, I can do it tonight (I would like to avoid having a slow computer during the day)

Looks like compiling perf has some issues with "diff" and "find", which seem to come from busybox. We should probably install the GNU coreutils and diffutils in Alpine to avoid that.


Releases/v1 updates

Added support for using environment variables as GITHUB_ENV
Added workflow files for build, stale issues

@kanika1894 shouldn't we ignore node_modules folder?


Sanitize ALL incorrect identifiers in JS

This section on reserved words should be copied into the compiler so we don't generate any of them as identifiers. They should go in js-reserved-words.json.
http://es5.github.io/#x7.6.1
ES5 spec. Should double check against ES6 spec.

Using the ES6 version: http://www.ecma-international.org/ecma-262/6.0/#sec-reserved-words


update copyright to 2022

Happy new year!
This updates the copyright I found with grep -rl "2021" ./ --exclude=*.{pdb}

Any thoughts?

Depends on your commitment to keeping them up to date :wink:.  If you are committed to that, I would go for option 3 (as you said, you are responsible for most of the text), otherwise I would go for option 1. (no one particular claims responsibility). However, I would at least ping the other contributors if you plan on dropping their names.

Not worrying about changing who the copyright credits right now. Let's merge this instead of waiting until 2023. 🤣


Phone Number displayed in Hamburger Menu even the user has interrupted Verification flow.

Frequency: 100%
Repro on build version: Android Internal Build V 1.10.1(1004294336), Testflight build 1.10.1(46)
Repro on devices: Samsung Galaxy A5(7.0), iPhone XR(14.2)
Pre-condition: User should login the application without a phone number.
Repro Steps:

Launch the application & login in app without phone number.
Now tap on the “Confirm Now” button on Receive payments directly to your phone number In-App notification.
Now enter a valid phone number.
Complete captcha process & enter PIN.
Now user is on timer screen
Now interrupt the flow by tapping on the “Cancel” button & again tap on Hamburger Menu on the Home screen.
Observed that,
Current Behavior:  Phone number displayed in Hamburger Menu.
Expected Behavior:  Phone numbers should not be displayed unless the user has not completed the verification flow successfully.
Impact: User might feel that his phone number is verified.
Attachment: PhoneDisplyedEvenNotVerified.mp4

I have verified this issue using latest  play sore build V1.10.1 & App store build V1.10.1 & observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0), iPhone XR(14.2)


Update Percentile to preserve Aux fields since its a selector

Currently the InfluxQL does not allow percentile to select Aux fields but Kapacitor does, so this change helps Kapacitor use Percentile as a real selector.
See issue #6292 for making InfluxQL allow percentile with selected aux fields.

[x] Rebased/mergable
[x] Tests pass
[ ] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

LGTM :+1:
I don't think a changelog is necessary since this isn't user facing. I'll include a changelog when I change percentile to be a real selector.


Email buttons are not clickable

Hi ! I identified a small issue in your great theme. The contact photos reveal two buttons, one for the email and one for the telephone number. They display this information, but they are not clickable ! I think the e-mail should be a <a<EMAIL_ADDRESS>and the telephone can also be a <a href="tel:+331234564">. This scheme is supported in some places, notably on iOS.

It's not really an issue, but I had some time so I added it :)

Wow, that was really nice of you to answer -- and add this feature -- so quickly ! Thanks.


How can I dynamically add new bars to mbarchart over time?

The examples for mbarchart are all static.  The example in the source code header doesn't work at all, but the one in the _example dir works, it is just a bit confusing since it has the same number of bars and bar colors.
I'm trying to add new elements to mb.Data[n] where n is the color group, but what I get is always just n bars instead.
Any chance you could provide a simple code snippit that just adds a new random value per second so I can figure out what I'm doing wrong?

What you can do is to keep your data in your own list, and whenever you add a new value, assign the slice to the Data[x] and refresh.
At the beginning you may want to assign a slice that is at least as big as the number of bars in the widget.
If you want to show the bars scrolling, you can just point to the tail of your slice. I do something like this:
case <-ticker.C:
                    if curr > bars {
                            p := curr - bars
                            sbc.Data[0] = data[p:]
                    }

In this case "curr" is len(data) and bars is the number of visible bars in the widget (sbc.Width / sbc.BarWidth)


Use a separate process to send data to zipkin instead of timer:apply_…

…interval.
Using timer:apply_interval results in a large number of processes
simultaneously sending data if the zipkin server cannot respond to
requests quickly enough.

Changed to the older supervisor child spec to see if that would appease the older erlangs. Seems to have fixed 17, but not sure what's up with R16B03.

Merged, thanks Adam!

Thank you. :)


Compatibility issue with Let's Do Meadow

Woolen cow from Meadow mod cause crash. Everything is expalained here: https://github.com/satisfyu/Let-s-Do-Hub/issues/109

Thanks for reporting this issue. The just uploaded version 1.4.0 attempts to resolve this issue, please let me know if it does. (:


Create new table for customization deploy data

We need a new table for deploy information since there is something we cannot rebuild with the info we have:
table name: customization_deploy_info
Columns:
id
customization_id
hostname (string)
fqdn (string)
internal_ip (string)
public_ip (string)
As usual Db and java

Done


NullPointerException when trying to access Classifier.Recognition / result.getLocation()

Setup:
I've used Google's Cloud AutoML Vision Object Detection platform to create a custom model for object recognition using this tutorial:
https://cloud.google.com/vision/automl/object-detection/docs/edge-quickstart
Then added the model to the following app template:
https://github.com/tensorflow/examples/tree/master/lite/examples/object_detection/android
Then I overcame the following two errors:

Cannot convert between a TensorFlowLite buffer with 1080000 bytes and a ByteBuffer with 270000 bytes. I modified TF_OD_API_INPUT_SIZE accordingly.

tflite ml google [1, 20, 4] and a Java object with shape [1, 10, 4]. I modified NUM_DETECTIONS according to my custom model.

Finally got the model working.
Now I want to send the box locations using Bluetooth to a HC-05. I added two public classes: BluetoothArduinoBridge, and LocationSender. Both of them attached as txt files.
Problem
App crashes when objects are recognized.
Code to reproduce the issue
I modified the code at DetectorActivity.java, lines 203-218 to this:
            for (final Classifier.Recognition result : results) {
              final RectF location = result.getLocation();
              if (location != null && result.getConfidence() >= minimumConfidence) {
                canvas.drawRect(location, paint);

                cropToFrameTransform.mapRect(location);

                result.setLocation(location);
                mappedRecognitions.add(result);

                //----------------------------------------
                mLocationSender.send_location((location.bottom),(location.left),(location.right)
                ,(location.top));
                //----------------------------------------
              }
            }

Other info / logs
E/AndroidRuntime: FATAL EXCEPTION: inference
    Process: org.tensorflow.lite.examples.detection, PID: 16690
    java.lang.NullPointerException: Attempt to invoke virtual method 'void org.tensorflow.lite.examples.detection.LocationSender.send_location(float, float, float, float)' on a null object reference
        at org.tensorflow.lite.examples.detection.DetectorActivity$2.run(DetectorActivity.java:213)

Question
How can I send the box locations using mLocationSender.send_location???
Note
I'm quite new to Android so this might probably be a dumb question. Please be gentle.
LocationSender.txt
BluetoothArduinoBridge.txt

Hi dfvr1994,
It seems that mLocationSender is null in your modified code, you should check when it is assigned a new object.
I am glad to hear that you overcame the adaption to your custom model.
As this is not a bug from original code and for https://github.com/tensorflow/examples in particular, I will close this bug.


Setting JVM option via system property (e.g. liberty.jvm.xyz ) doesn't override POM property of same name

For a POM with property like:
<properties>
    <liberty.jvm.arg1>-Xmx2048m</liberty.jvm.arg1>
</properties>

I might think I can do:  mvn liberty:dev -Dliberty.jvm.arg1="-Xmx4096m" to override, since in general, in Maven, system properties will override POM properties.
However, the current liberty-maven-plugin impl will write both values into the generated jvm.options, e.g.:
jvm.options
-Xmx2048m
-Xmx4096m

In certain cases this may happen to "work", if the JVM ignores the first and uses the second, say.
However if you wanted to "unset" the POM property by passing mvn liberty:dev -Dliberty.jvm.arg1= then this might not work as well.
Looking at the plugin code, I see the root cause is how we use a list to store the JVM option props:
 protected List<String> jvmMavenProps = new ArrayList<String>();
 ...
 case JVM:        jvmMavenProps.add(value);

This makes some sense since we throw away the "key" and only use the "value", but leads to the problem above.
PROPOSAL
We should investigate whether we can treat the liberty.jvm.xyz properties with more of a "map" behavior and have the one value override/replace the other.     We should think through the complete merging algorithm, including all possible sources for the JVM options, to make sure this makes sense, before doing.

The server-param-pom-override-it test ase confirms some odd behavior related to jvm options. The <jvmOptions> plugin config is last in the jvm.options file, taking precedence over the <liberty.jvm.maxHeap>-Xmx1024m</liberty.jvm.maxHeap> Maven property in the same pom.xml. There is also a jvm.options file in the src/main/liberty/config dir that I think gets overridden by the config in the pom.xml.
We should check the behavior of the server.env properties as well if we change the logic for this.
The Maven properties that start with liberty.var are verified by the test case and the cmd line property (through invoker.properties) takes precedence over the Maven property in the pom.xml.

I happened to see this issue in the backlog and realized we fixed this in https://github.com/OpenLiberty/ci.maven/pull/1779
Confirmed that mvn  -Dliberty.env.aaa=555  -Dliberty.jvm.arg1="-Xmx3072m"  overrides similarly-named POM properties for each.
@cherylking don't think there was anything more to test, so closing this.


Support for bounded execution when window frame involves UNBOUNDED PRECEDING

Which issue does this PR close?

Closes #4978
Rationale for this change

Currently, queries that contain UNBOUNDED PRECEDING as in their window frame bounds, like the one below
SELECT
    SUM(c1) OVER (ORDER BY c3 RANGE BETWEEN UNBOUNDED PRECEDING AND 11 FOLLOWING) as a1
    FROM aggregate_test_100

run with WindowAggExec. However, many aggregators do not require the whole range in memory to calculate their results -- the above query can actually run with BoundedWindowAggExec.
What changes are included in this PR?

This PR adds support for bounded-memory execution of suitable window functions even when the start bound is UNBOUNDED PRECEDING.
Are these changes tested?

We added new tests that verify the updated (i.e. optimized) physical plan. We also added fuzzy window tests to generate window frame bounds with UNBOUNDED PRECEDING. Fuzzy tests can now generate window frame bounds in the form RANGE BETWEEN N PRECEDING AND M PRECEDING or RANGE BETWEEN M FOLLOWING AND N FOLLOWING, which increases effective coverage.
Are there any user-facing changes?

No.

A quick summary to help reviews: If all you are doing is something like a running sum, you can get the job done with bounded memory even if your frame is ever-growing. This PR paves the way for Datafusion to support these kinds of use cases with low memory usage and without breaking the pipeline.

The idea makes sense to me. I plan to review this carefully in the next day or two

I plan to review this carefully first thing tomorrow (monday) morning US Eastern time


webhint added

webhint.io - an open-source project by JS Foundation / Microsoft
https://github.com/webhintio

Thanks a million @webmaxru 🚀 🚀 🚀 🚀


Error in console when opening Module Management

Using Chrome, foundry V10.291 and dnd5e 2.1.5, this error pops up when opening the Module Management:

same error here, i needed to downgrade to the version before the v11 compatibility

This is most likely related to #101 which I hope to have the patch out tomorrow. I meant to get it today, but I was working on a new module and it went from 9am to 10pm in like 2 hours... No Idea where my Monday went

Can you confirm if version 2.2.1 fixes this https://github.com/mouse0270/module-credits/releases/tag/2.2.1


The new boot functionality immediate creates a startup parameter with…

… the parameters '1' and 'internal.BootTimeoutDefault'
BootTimeoutDefault is from the original implementation, in milliseconds, but startup.NewStartupTimer expects seconds.  To fix without breaking the existing usages of internal.BootTimeoutDefault, created a BootTimeoutSecondsDefault and changed all instances of NewStartupTimer to use that.
I also added a BootRetrySecondsDefault for completeness and add it to the calls creating the new startup timer.
Fix #1886
Signed-off-by: Scott C Sosna<EMAIL_ADDRESS>

Codecov Report

Merging #1887 into master will not change coverage.
The diff coverage is 0%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054f053...847bf9f. Read the comment docs.

LGTM pending successful build.


Updated auth module to allow kingdom through

Just changed a wrong url in the auth module.

Can one of the admins verify this patch?


[ci] sync template files

This PR syncs the specified GitHub template files from the central repository.
Changes:

apply same changes to template file - (473dbc7)
only make deployment latest if no publish - (f294bf4)

The branch has been updated with the latest changes.

The branch has been updated with the latest changes.


Add GMM-based detectors

Hi,
This PR implements GMM-based unsupervised outlier detection.
I'm not sure the original, first paper using GMM-based detectors, but the following is a reference.
Oren Barkan and Amir Averbuch, "Robust mixture models for anomaly detection,"
2016 IEEE 26th International Workshop on Machine Learningfor Signal Processing (MLSP), pp.1-6, 2016.
Best regards,
Akira
All Submissions Basics:

[-] Have you followed the guidelines in our Contributing document?
[-] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[-] Have you checked all Issues to tie the PR to a specific one?

New Model Submissions:

[-] Have you created a .py in ~/pyod/models/?
[-] Have you created a _example.py in ~/examples/?
[-] Have you created a test_.py in ~/pyod/test/?
[-] Have you lint your code locally prior to submission?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

121 of 130 (93.08%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 96.01%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyod/test/test_gmm.py
78
79
98.73%

pyod/models/gmm.py
43
51
84.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
7388

Relevant Lines:
7695

💛  - Coveralls

This will be reviewed and merged in the next release. Really appreciated the work!

sorry for being late on this. need to publish a urgent version before merging this.


search on /sites needs to match on more fields

Steps to Reproduce
Search for a course number
Expected Behavior
the associated course should pop up
Actual Behavior
it most certainly does not!
what's going on
Right now the search field on /sites only matches on the title field on the website model. This means that for a lot of courses things that course authors might think they can search for (like the course number, or a fragment of the name field) actually will not match at all.
We should improve this by searching on title, name, and short_id.

Also, course number, for example 8.701

yes, course number is found in the short_id field


Correctly handle centerSlice with resoultion-aware assets.

Description
This fixes both the centerSlice Rect being misinterpreted and the image being rendered too big.
Related Issues
Fixes #20013.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
448540 issues found. (ran in 97.9s; 6488 public members lack documentation)
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

Unsure what the failure in the flutter-build test is, since the Details link target doesn't seem at all related to this PR.

A failing flutter-build just means that the tests are currently failing on master - it's unrelated to your PR.
However, this PR is missing a test. Can you please add one? Thanks.

Added a test, now.


Clear data attribute when value is undefined

Fixes issue in #236 comments: unable to remove an attribute.
When using data prop:

Once a value is set, it can't be removed; it can only be replaced by another value,
Passing an undefined value results in "undefined" being serialized as the dataset value.

I thing there is an opportunity to use an undefined value to clear a property.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Connect to port different from 21

How to connect to port 2000?

It's a pity this issue is closed without implementing this, I need it too...
Frank

Black Raccoon works with the FTP routines as provided by Apple. This was closed because there is no obvious method that allows you to specify the port.
It isn’t a question of me implementing it, it is a question of Apple implementing it (and they have many times said they planned on deprecating the FTP routines).
If you find a way to specify the port, I would be happy to implement it.

Ok thank you for the explanation.
Frank

Any news regarding this question? Nothing? I really needed this..

There is no method that I’m aware of that allows you to specify the port. Feel free to notify me if you find one.


What other /slash commands should we add?

Some ideas so far:

Spotify
Youtube
Calendar
Amazon

any doc creation/storage app (Dropbox, Quip, Google Docs) for link sharing
trello tasks
github pull requests - something like /github comand/Wh would show a link to this issue (could also be used with PRs)
foursquare/yelp

Two I'd love, one that's simple and one that's not:

Some way of screenshotting another tab. Almost every PR I put on Github (any many comments) need screenshots and it's fairly cumbersome to get them in
/shrug. Gives you ¯_(ツ)_/¯

@dget OOOOOO I love both of these

How about /emoji cactus for :cactus:, with the same names that github/slack/basically-everyone uses? I know you can get to the emoji from menu Edit -> Emoji & Symbols, but as slack & github show, it's a much better experience to tab-complete a word than scroll through pages of icons.

Maybe something like: /map -> a geo-location feature that snaps a screenshot map plus google map link. Like when you need to quickly send someone your location.

:+1: for /emoji

For '/emoji' , might have to add a polyfill for default emoji support for Chrome on Windows... Unless it's been updated more recently.

Love the Google Maps idea and /emoji is the next oneI'm working on.

Just released an update (v0.0.14) that adds /emoji — it's not perfect, but it works. If anyone is around this weekend and wants to learn how to add a command, I'd be happy to help!

@jessepollak Maybe a way to add predefined templates for emails?
Loved the extension BTW

@russdogg Can you share your IFTTT Recipe for Google Maps?

Google Search - Search the web with Google
Google Translate - Translate text using Google Translate
Wikipedia - Search for articles on Wikipedia
Imgur - Search for images on Imgur
Twitter - Search tweets, @mentions and hashtags on Twitter

I've started working on the Wikipedia command! I've forked it here - https://github.com/cryptixdevelopment/command
The API is strange and returns three different arrays, each for the titles, excerpts, and urls. But I've got that converting to a more suitable array of clear objects.
It's "working" at the minute, just the results aren't formatted very well yet.

I think another good command would be to be able to quickly search on the App Store

quickly pull up the current stock information,
/stock <Search Stock>

I got bored and also added in an App Store command - https://github.com/cryptixdevelopment/command
It works fine, except the pagination doesn't to be perfect.

@cryptixdevelopment so awesome! Do you want to submit a PR? Would love to take a look and merge them in :D

@jessepollak Yeah sure, the Wiki command still needs work but at least the functionality is there.

@jessepollak I think these could be added:

/googleplay

Android Apps OR add it to @cryptixdevelopment's command to make a /apps command that searches both (and possibly Windows 10, Ubuntu, etc. app stores)

/search

Give a link to a search engine (your prefered could be set in a Settings page)

/lmgtfy

http://lmgtfy.com/?q=let+me+google+that+for+you

/deviantart

Share images from DeviantArt

/apkmirror

Search APK Mirror for Staged Rollout and Beta Android APKs

/producthunt

Awesome extension! Just thought about something similar yesterday and found this.
Have you thought about allowing custom commands? I'm thinking this could be very useful as a productivity tool in a work environment but the commands would need to be very customized and connect to internal services.
Also, the ability to "pipe" commands together would be boss. Something like "/youtube  | bitly".

Custom Commands are already supported. See the CONTRIBUTING.md file here: https://github.com/jessepollak/command/blob/master/CONTRIBUTING.md to learn how to create one.
You can also see the source code of existing command such as /emoji under src/content/commands folder

@ishu3101 I think they mean a easy way for users to make them with a Settings UI (so you could add macro slashes (/omw=on my way) like Slash Keyboard does on mobile). That's for devs to implement API style commands (like the YouTube API for video search for instance)

/stackoverflow - Reference a Stackoverflow Page
/github-repo - Reference to a Github Repo


ReSubscribeOnError, delay before subscribing after error

add a TimeSpan paramater to ObservableExtensions ReSubscribeOnError and DelaySubscription by that amount after an error occurs

implemented in 8cc43affdcc2c496b24b93962f534f9a755faf4f


Missing tolerance in API

While ConvexHull.Create has an overload which accepts tolerance, Triangulation.CreateDelaunay does not. Would be nice to have that.

This has now been added in version <IP_ADDRESS>1. Thanks for pointing this out.


Refactor bootstrap.sh

@lsteck - This is the PR for refactored bootstrap - after you checked I can remove bootstrap-gitea.sh
@hollisc - This is quite big - I dont know what other implication this will have
@csantanapr - I added support for gitlab as you mentioned in your email - and it works to copy the repo and run argo from gitlab

Will merge near eod and re-run a test using ITZ env provisioning.


Consider reusing HazelcastHealthIndicator for more consistent results

Rather than having a custom HazelcastJetHealthIndicator,  please consider auto-configuring a standard org.springframework.boot.actuate.hazelcast.HazelcastHealthIndicator since all it does is checking the state of the embdded HazelcastInstance anyway.

org.springframework.boot.actuate.hazelcast.HazelcastHealthIndicator uses com.hazelcast.core.Endpoint which has moved to com.hazelcast.cluster.Endpoint in 4.0. This prevents us to reuse HazelcastHealthIndicator. But if we change it to use the LifecycleService.isRunning instead of executing a transaction, we can re-visit this issue.

Ah good point, I haven't started to look at Hazelcast v4 compatibility yet.


[FEATURE] Random User Profile

Description
Hello! 👋 I've never contributed to an open source project before, but I had an idea for LinkFree.
A button next to search that brings up a random user profile! I always love the random page feature of wiki sites, so I thought this would be a fun way to browse each other's profiles on the site. The link will update every time the page is refreshed.
Let me know what you think! I do have it done already (I just wanted to practice understanding someone else's code) and it did pass all the Cypress tests, so if it's approved I can immediately do a pull request so I can get some feedback, but if not that's okay too since I just wanted to see if I could make it happen. 😁 Thank you!
Screenshots

Additional information
No response

I really like this idea! However, I would reconsider the design of the button next to the search because to me it does not communicate the purpose and It shouldn’t need a hover tooltip.
it would be great to see what others think too.

i like the idea too

yea this idea is cool but what about the searching history

yeah the idea is good

@PhilipBDev maybe icons like these could be used:

or maybe to make it more obvious that it is a random user @PhilipBDev :

To me something like Google’s I’m feeling lucky button comes to mind, maybe we should create a few mock-ups with different texts/icons (we have anything from react icons and prime react buttons to play with)

We are planning on removing the list of people from the homepage, I wonder if we could pick some random users to display on the homepage?

We are planning on removing the list of people from the homepage, I wonder if we could pick some random users to display on the homepage?

What about displaying some kind of demo of linkfree in the homepage and in this wrapper use every time a new random profile

@schmelto do you have an example of what you mean by demo? I initially thought a video, but if we are to have a random profile each time could you elaborate a bit more

@schmelto do you have an example of what you mean by demo? I initially thought a video, but if we are to have a random profile each time could you elaborate a bit more

Will provide some feedback after my vacation

Thanks Tom! Enjoy your adventures!

Thanks Tom! Enjoy your adventures!

I assumed a landing page / homepage like this with some explanation text what linkfree is ( how to add a profile etc) and a sample "screenshot" of the random profile as live demo of how linkfree for you will look like when you create a profile there.

Thanks Tom! Great idea 👍

Something like this for the demo ....

Don't we already have a Random Profiles on discover? Maybe this can be closed

yes this is done 👍
This is now done 👍 so I will close this issue


Improve ScaledDecimal comparison performance

Comparison of ScaledDecimals is slow comparative to other numeric types, e.g.
"Integer = Integer"
Time microsecondsToRun: [100000 timesRepeat: [1=1]]. "1,859"
Time microsecondsToRun: [100000 timesRepeat: [1=2]]. "1,831"

"Float = Float"
Time microsecondsToRun: [100000 timesRepeat: [1.0=1.0]]. "3,060"
Time microsecondsToRun: [100000 timesRepeat: [1.0=2.0]]. "3,121"

"ScaledDecimal = ScaledDecimal"
Time microsecondsToRun: [100000 timesRepeat: [1.0s2=1.0s2]]. "80,338"
Time microsecondsToRun: [100000 timesRepeat: [1.0s2=2.0s2]]. "76,505"

"Integer = Float"
Time microsecondsToRun: [100000 timesRepeat: [1=1.0]]. "31,170"
Time microsecondsToRun: [100000 timesRepeat: [1=2.0]]. "31,772"

"Integer = ScaledDecimal"
Time microsecondsToRun: [100000 timesRepeat: [1=1.0s2]]. "165,616"
Time microsecondsToRun: [100000 timesRepeat: [1=2.0s2]]. "176,070"

The slowness looks to be largely down to the creation of an intermediate ScaledDecimal in the subtraction operation in ArithmeticValue>>#= .
Performance can be improved (5x or greater) by implementing equalToScaledDecimal: in the ArithmeticValue hierarchy (similar to equalToInteger: etc.) and comparing the ScaledDecimal by its Fraction.
I can submit a pull request for this if acceptable.

Sounds like a good idea to me John. Not terribly hard to test either, just a number of combinations/cases.


Add element interface library and core documentation

This is a hefty update, but it is aimed at the finish line on Kava's primary goals. Like Bumblebee and Ironhide, Kava is meant to be a POM wrapper on the consumed test framework, facading system interactions into a highly-readable, concrete interface. In comparison, XCTest is not very readable when dealing with complex interactions, and the framework is as dynamic as you can get (every XCUIElement has methods for every possible interaction in the system). At this point, we will only be adding common interactions and Element subclasses, but this should handle 95% of any iOS application UI.
This framework leverages the hell out of generics, so I can clarify on a specific example within the Tappable class:

class Tappable<TResultBlock: Block> : Element {

    public typealias TResultBlockBuilder = (() -> TResultBlock)?

    public func tap(constructingBlock builder: TResultBlockBuilder = nil) -> TResultBlock {
        return self.tap(TResultBlock.self, constructingBlock: builder)
    }

    public func tap<TCustomResultBlock : Block>(result: TCustomResultBlock.Type, constructingBlock builder: (() -> TCustomResultBlock)? = nil) -> TCustomResultBlock {
        self.backingElement.tap()
        return self.parentBlock.scopeTo(TCustomResultBlock.self, builder: builder)
    }
    ...
}

These are what I'm referring to as "element action signatures". For every action, we are maximizing our usage of generics by using function overloads for generic type inference. The typealiases defined are inherited by subclasses, which further standardizes these signatures across all elements. All of that said, we give the caller complete control over the proceeding Block scope and the construction of that proceeding Block (if absolutely necessary for nested element groups), but in most cases, neither is specified. So, within a page object, if we have a button defined as follows:
class LoginPage : PageBlock {
    var loginButton: Tappable<HomePage> {
        get {
            return Tappable(parentBlock: self, backingElement: self.backingElement.buttons[0])
    }
}

When in the scope of a LoginPage, the caller then has access to:
loginPage.tap() // Retuns a HomePage
loginPage.tap(LoginPage.self) // Returns a new LoginPage block
loginPage.tap(LoginPage.self, constructingBlock: { () -> LoginPage in
    return self
}) // Returns the same LoginPage block

@brettwellmanmbo @rcgilbert

Way to go, Hammer.  This is seriously legit.  From what I can gather, this looks like it's going to be a great solution.  I don't have any major concerns or questions after code reviewing your work, but I'm sure I'll have some questions and require some insight once I start consuming it myself.  Also, my Swift knowledge is very rudimentary, at best, right now so I won't be of much help in that regard either :|.  I've acquired a Swift book, however, and have begun reading it so hopefully that'll speed my adoption process.
𝕽⟴

This is dope!
🍵  +


test: add e2e tests for different createCredentialOffer API variations

Description:
The goal of this PR is to add tests for improved API to make a credentialOffer
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

coverage: 48.866% (+0.07%) from 48.8%
when pulling 20264825d5ca1eb71507bd039c495fecff307c98 on feat/vcdm1_1-tests
into 248ba5fe14fe2736b00fa42f72aeffe523362406 on main.


default sort method mixes zeroes and nulls/undefineds (and doesn't match doco)

What version of React-Table are you using?
6.8.1
What bug are you experiencing, or what feature are you proposing?
Disclaimer: I don't write a lot of JS, so this might all be totally wrong...
defaultSortMethod forces null and undefined to the empty string, which is neither greater than nor less than 0, so when trying to sort a numeric field, nulls are not differentiated from zeroes. This is different than indicated in the readme, which says that defaultSortMethod forces nulls and undefineds to -Infinity.
https://codesandbox.io/s/ly98145xkl: sort this list by age, and the blanks and zeroes do not sort separately.
Using -Infinity would (I think) move the problem to strings, e.g. strings won't be greater than or less than -Infinity. Perhaps a way to address this for arbitrary types would be some guards in the sort... something along the lines of:
if a is null/undefined && b is null/undefined return 0
if a is null/undefined return -1
if b is null/undefined return 1
What are the steps to reproduce the issue?

sort a table on a column with zeroes and nulls - expected outcome: nulls are separated from zeroes; actual outcome: nulls are mixed in with zeroes (dependent on subsequent sorts/index)

You can replace the default sort method if it does not meet your needs.

That's what I ended up doing - I just wanted to bring it up in case there was a desire to make defaultSortMethod do what I imagine would be the generally expected behavior in more circumstances.

@bobisageek can you share how you got around this?

@CWSites I just overrode the default sort method on that column to sort the way that made sense for my values

Can you share @bobisageek?

I'm not sure what you're asking for... if you just want the sort method I used, I took the one that's in the documentation and changed the null/undefined ternary to return -Infinity instead of a blank space:
{
    // force null and undefined to the bottom
    a = a === null || a === undefined ? -Infinity : a
    b = b === null || b === undefined ? -Infinity : b
    // force any string values to lowercase
    a = typeof a === 'string' ? a.toLowerCase() : a
    b = typeof b === 'string' ? b.toLowerCase() : b
    // Return either 1 or -1 to indicate a sort priority
    if (a > b) {
      return 1
    }
    if (a < b) {
      return -1
    }
    // returning 0, undefined or any falsey value will use subsequent sorts or
    // the index as a tiebreaker
    return 0
  }

If you're looking for the extra guards around null/undefined, I didn't actually sit down and write it. My specific situation only had the null/undefined issue on numeric values, and I don't write a lot of JS, so I didn't put the time in to try and solve a problem I didn't have.


Vendoring support

Is there a way for this to support resolving modules from a vendor directory?

Not currently - this tool was intended to work without access to the source code of the compiled binaries that are passed to it.
Is your usecase around private modules that have been vendored and aren't reachable from where you'd intend to use lichen?

Not currently - this tool was intended to work without access to the source code of the compiled binaries that are passed to it.
Is your usecase around private modules that have been vendored and aren't reachable from where you'd intend to use lichen?

It's not necessarily that it's private modules (though there are a couple that we use).  But yes -- mostly that it's not easily possible to re-pull them from github.com from the internal build system we are using.

I have CI pipeline that populates and caches vendor (populated with go mod vendor on miss) between steps and runs, that allows to save tremendous amount of traffic compared to caching or populating ~/go/pkg/mod. An example from real build: 27M uncompressed (5M compressed) vendor vs 629M in ~/go/pkg/mod.
It would be great if lichen could make all necessary assumptions and allow using vendor as a source of licenses.


Container shutting down on connection loss.

It seems every time a ping reply is missed to the doorbell (AD410) the container shuts down. This also happens when my MQTT container is restarted. Is there a way for the app to just retry the connections (ping, MQTT login) instead of shutting down?
08/10/2021 15:14:15 [ERROR] Ping unsuccessful
08/10/2021 15:14:15 [INFO] Exiting app...
07/10/2021 15:52:48 [ERROR] Unexpected MQTT disconnection
07/10/2021 15:52:48 [INFO] Exiting app...

Looks like : #43 is covering this?

The underlying library has been updated so I've removed the ping functionality as it's no longer needed. The app should now restart less.
Functionally, if you have the Docker container set to restart on exit there's no real world difference between re-connecting and restarting the container and it keeps the code a lot simpler so I won't be changing the way this works.


[Migrated] Bug: cocli corim display

Source: https://github.com/veraison/corim/issues/69, confirmed still an issue
cocli corim display on a signed corim creates a json and prints "Meta:" and "CoRIM:" in https://github.com/veraison/corim/blob/main/cocli/cmd/corimDisplay.go#L88 and later.
This causes a problem when parsing the JSON file output through python or command line, and appears to be a non-conforming JSON.
Can you confirm this is a bug? and perhaps fix it?
Similarly cocli comid display also outputs the file name with >> at the top of the JSON file and makes it difficult to parse.

@deeglaze can we provide a --raw (or similarly named) flag to control whether extra labels/headings are displayed, giving users the choice of purely raw JSON vs. human-friendly headings.

I think it is difficult to say if this can be resolved fully, as CoRIM does not have a JSON-friendly CDDL definition.
Anything we say is --json would need to be proposed as an enhancement I-D to the CoRIM spec I think, since the CBOR serialization to JSON takes a design decision that isn't standardized (see https://github.com/nlohmann/json/issues/1129), and the CDDL that binds names to constants is not intended to be a basis of JSON serialization. I don't want the reference implementation of the RFC to also prescribe JSON without a spec.
The display tooling is meant purely for human diagnostics. I'm tempted to close as won't fix, or label as enhancement rather than bug.

I think it is difficult to say if this can be resolved fully, as CoRIM does not have a JSON-friendly CDDL definition.
Anything we say is --json would need to be proposed as an enhancement I-D to the CoRIM spec I think, since the CBOR serialization to JSON takes a design decision that isn't standardized (see https://github.com/nlohmann/json/issues/1129), and the CDDL that binds names to constants is not intended to be a basis of JSON serialization. I don't want the reference implementation of the RFC to also prescribe JSON without a spec.
The display tooling is meant purely for human diagnostics. I'm tempted to close as won't fix, or label as enhancement rather than bug.

@deeglaze yaa you are right that's the whole point of display tooling is for human diagnostic, however should we consider adding something like - raw tag? As some of the user faces this issue as I have seen one more issue that had mentioned same problem in corim repo

I wouldn't reject it outright. I would need to see a PR and see if the other maintainers share my stance.


⚠ SolarOscp has degraded performance

In 6f99899, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 374 ms

Resolved: SolarOscp performance has improved in 168755a after 76 days, 22 hours, 11 minutes.


[go api] Fix state retrieval for multiple result producer

The Golang API that does stateful computation with multiple results producer does not retrieve the state properly which resulted into random behavior

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: JONBRWN:white_check_mark: SeanTAllen:x: niamsterYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @niamster

Closing in favor of #2099 which is against latest master.


[3.x] Physics Interpolation 2D - reset on NOTIFICATION_ENTER_TREE

As a convenience, physics interpolation is reset automatically on entering the tree. This will be desired in most situations, and saves the user having to write code for this explicitly.
Notes

This is fairly no-brainer, but I didn't add it initially because it is not present in 3D physics interpolation (users have to call reset manually on adding nodes in 3D). I didn't add in 3D because I found some situations where it caused problems, but this may be revisited.
There are possibly some advanced situations where not having a reset on entering the tree could be useful, such as moving a node from one branch of the SceneTree to another and keeping the "flow" of interpolation. But if we get reports needing this, we can easily add an option to prevent the auto-reset.
Overall I think this is worth going for as it will make physics interpolation far simpler to use for beginners. At worst we can easily revert / add option to turn off per node.

This is fairly no-brainer, but I didn't add it initially because it is not present in 3D physics interpolation (users have to call reset manually on adding nodes in 3D). I didn't add in 3D because I found some situations where it caused problems, but this may be revisited.

Won't it be confusing for users / trickier to document if 2D and 3D have a different default behavior for this?

Won't it be confusing for users / trickier to document if 2D and 3D have a different default behavior for this?

Possibly very slightly, but:

The advantages for 2D users outweigh any confusion imo (we get a lot of beginners making first games in 2D)
I'm likely to revisit 3D interpolation and see if it possible to solve the problems with automatic reset on entering tree

Of course the second isn't guaranteed, but I'm not sure a small gotcha is worth introducing lots of extra work for 2D users.

Thanks!


Update doc.go

Fixed the code documentation.

/lgtm
/assign karlkfi

@karlkfi I think this is waiting for approval as well.

@janetkuo do you mind hitting approve here if this looks good

/ok-to-test


No jobs are being saved in the database

I am using Rails 4.1.1 and implementing delayed job to add scheduled notifications. I have implemented the gem and used 'delayed' method as follows:
class MessageSocialAccount < ActiveRecord::Base
  attr_accessible :social_account_id, :message_id, :read_time, :push_notification
  attr_reader :when_to_run
  belongs_to :message
  belongs_to :social_account

  def when_to_run
    message.deliver_at || Time.now
  end

  def push
    social_account.send_push(msg_sca.message)
    update_attributes!(:push_notification => true)
  end
  handle_asynchronously :push, :run_at => Proc.new {|i| i.when_to_run }
end

I am calling the push method from another model but that should not really matter.
The workers are started ( run rake jobs:work) but when I run Delayed::Job.all in the console, an empty array is returned. I am pretty sure the table has been created so can you please let me know if I am doing something incorrectly or is it a bug? Thanks

The job is deleted after it has run. Is the job running?

When I schedule the job to be run at some time in the future ( e.g. in 2 hours) I expect to see the job saved in the table and wait there for 2 hours before disappearing, but there is nothing in there.

Are you checking the correct environment?

I am testing locally, and checking in the console.

Do you have Delayed::Worker.delay_jobs set to false?
What does running message_social_account_instance.push give you in the console?

Sorry albus522 for the delay. I realised that the app had already implemented sidekiq for another purpose and when I opened the sidekiq web interface I could see all the scheduled jobs in there so this other gem could have been causing this problem. I think I just need to decide on one or the other. Thanks for your help


carbon grid is not as expected on MAC and windows 7,where the same is working in windows 10

carbon grid: the elements are getting placed according to the grid col values in windows 10 but they getting overlapped on each other in mac and windows 7 I see that happening for components like carbon buttons and dates.Do we need to add something to make it work at OS level as well?

Hi :wave: our apologies for being late on this - Would you try creating a reduced case based on https://codesandbox.io/s/github/IBM/carbon-components/tree/master/examples/codesandbox? Thanks!

@anusha801 👋🏽


Disable StyledTextView layer's contents transition with animation

Hi, Thank you for this amazing library.
When I use StyledTextView in UICollectionViewCell, I found a reuse problem when reloading renderer, and found that the animatable of layer’s contents caused the view content to follow the effect of an animation transition.
https://github.com/GitHawkApp/StyledTextKit/blob/fe3232c980c374d59e520b086b04869e3c920f86/Source/StyledTextView.swift#L190
Suggested to change to:
   CATransaction.begin()
   CATransaction.setValue(kCFBooleanTrue, forKey: kCATransactionDisableActions)
   layer.contents = result.0
   CATransaction.commit()

@wleii oh weird. I haven’t noticed this in GitHawk.
Is there an easy way to repro this? Or do you have a video I could see? I think this is probably the right fix.
Sent with GitHawk

sorry for the late reply.
I tried to write a demo today to reproduce the above situation. But when I did it, it performed very well. I reflected on my problem and I should have made an error in the way I reload the data.
thank you for your reply. @rnystrom 👍


UserID is neither unique nor persisted nor automatically generated by the SDK.

The documentation says:

If no user ID is used, the SDK will generate, manage and persist a random id for you.

Currently the SDK does not generate a userID. it just takes the empty userID field.
There is a getUserId method that generates something but it's only in the demo activity and the ID isn't unique either.
I propose to use the UUID class to create a random UUID, persist it in shared preferences and use that.
Does anyone disagree? I will make a pull request when my current ones have been processed.

Fixed by #42


ISPN-9259 Fix agent-bond and jolokia module paths

https://issues.jboss.org/browse/ISPN-9363

I'll backport this to 9.3.x as well.

Looks good to me (assuming Ryan tested it with Jolokia), I can merge unless anyone else has any last second things they wanted to add.

Integrated into master, thanks @ryanemerson !


Rerun build with failed targets has an unnecessary extra space in front of comma

TARGET parameter is populated with the list of failed targets and there is an unneeded space inserted, see this example:
testList TESTLIST=jdk_nio_0 ,jdk_imageio_0 ,jdk_net_0 ,jdk_security3_0 ,jdk_security3_1 ,jdk_tools_1 ,jdk_imageio_1
We should determine where this extra space is coming from and remove the extra space, see the code that generates the link in the addFailedTestsGrinderLink method of the Jenkinsfilebase file

Salutations, @smlambert I hope everything is good with you. I appreciate you giving me this assignment.
I kindly ask for assistance in setting up and executing the tests on my personal computer. I followed the instructions here but I was unable to move past the process. I need assistance conducting the tests, please. Thanks

hi @Nuel-Eneji - those instructions are out-of-date.  For Jenkinsfile changes, the reviewers will run some tests on your branch or draft PR on our Jenkins server, or I can temporarily enable you to do so and together we can assess whether it resolves the problem or needs more adjustments.  Once you have some changes pushed to a draft PR, we can start to test it.  I am guessing for this issue, it is a matter of applying "trim()" in the appropriate place.

Hello, @smlambert I hope everything is good with you.
I just made a draft pull request #4074 as directed and used the trim() function where it was thought to be suitable.
I would like to take part in the PR review process.
Thanks

Hello @smlambert Hope you're well?
Can you please make this task as done?
Thanks

Resolved via https://github.com/adoptium/aqa-tests/pull/4074

Thanks alot @llxia


nmt/model.py

when I run this project, there is an error in nmt/model.py line 115:
NameError: name "maximum_" is not defined.
I change it to be：
maximum_iterations = self.params.get("maximum_iterations",100)
it success run.
I think you delete it by mistake...

Thank you very much~ I have updated the code~


Customise the SDK screens for both iOS & Android.

Please guide me how can i customise the default SDK Screens provided by the PayFort SDK. I want to customise the screens according to my PSD design.
And is there any way that i can use Js APIs for PayFort tokenization, SDK_Token, Purchase. by using my own design in may mobile application.

@usamaabutt able to implement this library, can you please help me.