Slightly increase coverage

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 66.531%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
163

Relevant Lines:
245

💛  - Coveralls

This was just to test the coveralls integration


LoadError: cannot load such file -- mina/whenever

Rails 5 app, upgrading to Mina 1.0. Added the mina-whenever gem to my gemfile and ran bundle install, everything seemed to go ok.
In my config/deploy.rb file:
require 'mina/whenever'
mina deploy gives me the LoadError: cannot load such file -- mina/whenever message.
How do I resolve this?

Just use require 'mina/whenever/tasks'

@myserg, that did not work for me.
$ gem list whenever
*** LOCAL GEMS ***
whenever (0.9.7)

and then
$ mina server:console -f config/deploy_production.rb
mina aborted!
LoadError: cannot load such file -- mina/whenever/tasks

Do you have any suggestions?

'mina-whenever' gem should be installed
$ gem list whenever
*** LOCAL GEMS ***
mina-whenever (1.0.0)
whenever (0.9.4)

That wasn't a requirement before, but it works now. Thanks.

It has to be installed like this:
gem 'mina-whenever', require: false

The problem still exists! None off suggestions solved for me.

Make sure you are on '0.3.x' e.g.

group :development do
    gem 'mina', '~> 0.3.0'
end

Then make sure to run the bundled version
bundle exec mina deploy

I'm facing "loaderror: cannot load such file -- mina/puma" error while deploying my code what could be possibly wrong with it?


Q: Set content-type when using render method?

I'm in the process of testing out Cockpit CMS, which encourages the use of Lime in all their examples.  So far, the only issue I've had is while trying to create a JSON file in PHP (from data in the Cockpit API) that I want to use for a small react app.  The page is assigned the content-type text/html, instead of application/json, even though the view contains a header('Content-Type: application/json; charset=UTF-8').
Is there a way to change the content-type when using the $app-render() method, or is there a recommended solution to this?

$app->get('/test', function(){
    $this->response->mime = 'json';
    return array('test'=>'test');
});

Thanks!  That's solved it.


Parsing @comment entries

Can the citation-js parser parse @comment entries in bibtex files?

It does kind of, apparently I never changed the behavior of the parser after the discussions in https://github.com/citation-js/bibtex-parser-experiments/issues/11. I think for natbib @comment should just be ignored (i.e. treated like any other character outside an entry that is not @), and for biblatex nested braces should be used, maybe just a BracketString.

I am not immediately sure which one I want to implement though. I guess it might be more likely that if a user is using @comment followed by a set of braces, the user intends the contents of those braces to be ignored, rather than it being inserted without purpose. I might also just cave and offer a natbib/BibTeX-style .bib parser and a biblatex-style .bib parser separately.

Jabref uses the contents of some @comments to store the data about grouping.


[CDS-76296]: Deleted temporarily tests to fix alerts

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck

This PR has been automatically closed due to inactivity.


Fixes for using mercurial-ruby on Windows

I hit two stumbling blocks when trying to use mercurial-ruby on windows:

popen4 ultimately calls fork, which is unsupported
shell tries to wrap command arguments in single quotes, which the windows shell hates

I've verified that neither change regresses existing tests (open3 codepath passes everything, double-quote codepath passes everything except tests to ensure that we're using single quotes to wrap)

+1
This may fix #6.

So...is this repo abandoned?


Build OData Queries with the SAP Cloud SDK's Virtual Data Model

Tutorial URL: https://developers.sap.com/tutorials/cloudsdk-js-vdm-getall.html
Please specify the step you are referring to Step 13: Test yourself (3)

“What have I got in my pocket?" he said aloud. He was talking to himself, but Gollum thought it was a riddle, and he was frightfully upset.
"Not fair! not fair!" he hissed. "It isn't fair, my precious, is it, to ask us what it's got in it's nassty little pocketsess?”
― J.R.R. Tolkien, The Hobbit, or There and Back Again

This is the code I did and brought me 1249 records:
import { Injectable } from '@nestjs/common';
import { BusinessPartner } from '@sap/cloud-sdk-vdm-business-partner-service';

@Injectable()
export class BusinessPartnerService {

  getAllBusinessPartners(): Promise<BusinessPartner[]> {
    return BusinessPartner.requestBuilder()
    .getAll()
    .withCustomHeaders({
      apikey: 'Wxsw3bRuQQApZLOkJ21G2UNJu49LIJ72',
      demoDB: "string"
    })
    .execute({
      url: 'https://sandbox.api.sap.com/s4hanacloud'
    });
  }
}

Would you mind in show me the code I have to paste to advance in this tutorial ??
btw: it took me a long time to discover this all by myself:
      demoDB: "string"
      url: 'https://sandbox.api.sap.com/s4hanacloud'

Thanks
Ivan

Hi @iMilazzo , thank you for approaching us.
To answer your question, the code should be:
BusinessPartner.requestBuilder()
.getAll()
.execute({
    url: "https://my.cloud.erp.com"
})

Your code is definitely working, but the question is

Write the minimum necessary code to get all business partners from a system under 'https://my.cloud.erp.com' (assuming no authentication is necessary).

We don't want to discourage/confuse people like that so we changed the tests.
Thank you.

Tutorial has been changed to Text exactly matches with ID.

I'm still no able to advance:

I will open a new ticket and I hope you don't close it too...

Hi @iMilazzo , since we updated the tests, I guess you have to refresh your pages.
The question you posted does not exist any more, if we are talking about the same link.
If refreshing doesn't work, maybe you can clean your cache or use e.g., Chrome incognito window.
Please let me know, if you still have questions.


Feature/unit testing

Added some unit tests

This PR fixes #30

I am attempting to contribite to something you are involved in and please note the forthcoming pulls

@murd4rp4rty hi, I don't have my pc available as I am on holidays, I'll check it as soon as I can. Sorry

I am sending you a suggestion to the Licence you've written with an
explanation as to why.  I have very new to coding and am Disabled, and
terrified to screw something up.
My suggestion goes as follows:
MIT License
Copyright (c) 2020 Jose Gracia Berenguer
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
*the DEVELOPER shall retain *
*the right to revoke Permissions granted to any person that uses the
License if it conflicts withCopyright owner's standards.  *
The above copyright notice and this permission notice shall be included in
all
copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
SOFTWARE.
  This way if
someone is using your licence on a mod that is forcing someone to charge or
to steal from people, you can revoke it? Or if it comes up in court and you
get served revoke the right.
On Sat, Aug 28, 2021 at 5:06 AM Jose Gracia Berenguer <
@.***> wrote:

@murd4rp4rty https://github.com/murd4rp4rty hi, I don't have my pc
available as I am on holidays, I'll check it as soon as I can. Sorry
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Josee9988/project-template/pull/38#issuecomment-907597734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVLVRTULRRJPLY4AKPQPHTTT7CRIZANCNFSM5ACTUDQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The license that I use is fairly popular, I really do not understand laws, but I will try to investigate a bit


Output box style

Styling of output box based on Figma mockups. Values for ethicality score, confidence interval, and summary points are hardcoded and will be filled in with real results after linking of FE and BE.
There is vertical overflow when scrolling down to read more of the summary.

Closes #46.
Closes #47.


[BUG][opensearch-dashboards, opensearch] Upgrade "opensearch" failed: failed to create resource: ServiceMonitor.monitoring.coreos.com: spec.endpoints[0].port in body must be of type string: "integer"

Describe the bug
Upgrade "opensearch" failed: failed to create resource: ServiceMonitor.monitoring.coreos.com "opensearch-cluster-master-service-monitor" is invalid: spec.endpoints[0].port: Invalid value: "integer": spec.endpoints[0].port in body must be of type string: "integer"
To Reproduce
Steps to reproduce the behavior:

Upgrade opensearch over helm from 2.22.0 to 2.23.0, dashboards 2.20.0 => 2.21.0 setting value  "serviceMonitor: enabled: true"
Helm upgrade failed with error in description

Expected behavior
Upgrade successfull
Chart Name
Both opensearch-dashboards, opensearch.
Host/Environment (please complete the following information):

Helm Version: ghcr.io/fluxcd/helm-controller:v1.0.1
Kubernetes Version: AWS EKS 1.30

Looks like this issue was introduced with #537
I'm looking into it and will try to fix it with a PR this afternoon!

Thanks @eyenx

Thanks @kappa8219, @eyenx, @prudhvigodithi for pointing this one out!
After going through the prometheus-operator, it was found that the template port definition in ServiceMonitor template is different from Service template.
In short,

port in ServiceMonitor means the name of the Service port. It's of type string.
port in Service means the port number of the Service. It's of type int.

Thus, the confusion and bug was created in #537
I'll shortly raise a PR with the fix.

Got it thanks @VILJkid.

Close this issue as the related PR is merged:

https://github.com/opensearch-project/helm-charts/pull/581
Thanks.


Add the configuration test case for all one-line tox settings written on the same line.

:tada: This issue has been resolved in version 1.0.1 :tada:
The release is available on:

1.0.1
GitHub release

Your semantic-release bot :package::rocket:


Fix compilation to iOS failed

Fixes wgpu#315
PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends:metal
[ ] rustfmt run on changed code

bors retry

@grenlight this is now published


spawnStateless ignores onCrash property

Passing an onCrash property when using spawnStateless() has no effect: The actor always resumes.
Expected Behavior
The onCrash property should be honoured when calling spawnStateless().
Current Behavior
When calling spawnStateless(), the onCrash property is ignored.
This implies that the supervision example in the documentation won't work.
Possible Solution
When initialising the properties here, putting the spread of properties last would fix it, if the intention is to have a (overridable) default:
    { onCrash: (_, __, ctx) => ctx.resume, ...properties }

Steps to Reproduce (for bugs)
The supervision example in the documentation won't work, it will always resume (instead of reset, as documented).
Context
I've just started learning about this package, so I might be missing something.
Your Environment

Version used: 7.2.1
Environment name and version: Node 11
Operating System and version: OSX, Debian

Makes sense, thank you.


WSO2 store not working after selecting API

Description:
When I login to wso2 store and click on recently added API, it should open api page which allow me to browse "overview", "API console", "documentation" and "SDKs". Instead my store web page is crashing with the error, such thing happen very first time.
Steps to reproduce:
Login to WSO2 store https://xxx.xxx.xxx/store
Click on recently added API
Affected Product Version:

2.2.0
Environment details (with versions):

OS: RHEL 7.0
Client:
Env (Docker/K8s):

Optional Fields
Related Issues:

Suggested Labels:

Suggested Assignees:

Closing Since the issue has been stale for a long time.


How can I user couchDB

I want to use couchDB, so how can I config it ??

@yanhuibin315 we have not tried it here. you may need to refer to the documentation -https://hyperledger-fabric.readthedocs.io/en/release-1.3/couchdb_as_state_database.html.

I want to contribute to this open source project. Can I take up this as my first challenge?

@balajikadambi @yanhuibin315 - we always encourage other contributors - - submit a PR and we will review.

Thanks! let me take up this challenge. Soon I will submit PR on this issue.


Fix error about keyvault-starter version.

Fix error about keyvault-starter version.

Hi, @saragluna , please help to review this PR. 🙏

Hi, @saragluna , please help to review this PR. 🙏

/check-enforcer override

/check-enforcer override


feat: Modules concept

Description
Provide a concise summary of the changes made in this pull request.

Type of PR
Check the appropriate box:

[ ] Review Fixes

[ ] Documentation Overhaul

[ ] Feature/Story

Link one or more Engineering Tickets

[ ] A-Force

[ ] Error in documentation

Documentation tickets
Link to one or more documentation tickets:

Checklist
Choose only the ones that are applicable.

[ ] Checked for Grammarly suggestions.
[ ] Adhered to the writing checklist.
[ ] Adhered the media checklist.
[ ] Verified and updated cross-references or added redirect rules.
[ ] Tested the redirect rules on deploy preview.
[ ] Validated the modifications made to the content on deploy preview.
[ ] Validated the CSS modifications on different screen sizes.

I've seen that the section with all the modules documentation is called Modules. What was the rationale for having it? Asking because I was wondering if it shouldn't be called Reusability to be more in line with the name of other sections and for users that don't know yet what a module is can have better expectations about what that section is about. Let me know your thoughts :)


Update rotriever manifest

Accounts for newer formatting and naming requirements.

Pull Request Test Coverage Report for Build 115

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 114:
0.0%

Covered Lines:
316

Relevant Lines:
316

💛  - Coveralls


Error: Driver 'rtl8192cu' is already registered, aborting...

On RaspberryPi 3 2.9.6+rev1, the user have a wireles dongle that uses the rtl8192cu driver. The hardware is reported to work well after a recent change, but the logs show an error. Is that a symptom of any issue? Or the side-effect of the blacklisting in the change?
[   12.081506] ------------[ cut here ]------------
[   12.081771] WARNING: CPU: 3 PID: 6 at /yocto/resin-board/build/tmp/work-shared/raspberrypi3/kernel-source/net/wireless/sme.c:948 __cfg80211_disconnected+0x50c/0x528 [cfg80211]
[   12.081783] Modules linked in: i2c_dev ftdi_sio 8192cu usbserial spidev brcmfmac brcmutil cfg80211 rfkill hid_led snd_bcm2835 snd_pcm snd_timer snd spi_bcm2835 bcm2835_gpiomem i2c_bcm2835uio_pdrv_genirq fixed uio sch_fq_codel
[   12.081877] CPU: 3 PID: 6 Comm: kworker/u8:0 Not tainted 4.9.59 #2
[   12.081886] Hardware name: BCM2835
[   12.082087] Workqueue: cfg80211 cfg80211_event_work [cfg80211]
[   12.082122] [<80111894>] (unwind_backtrace) from [<8010cd20>] (show_stack+0x20/0x24)
[   12.082144] [<8010cd20>] (show_stack) from [<804a852c>] (dump_stack+0xc8/0x10c)
[   12.082165] [<804a852c>] (dump_stack) from [<8011f39c>] (__warn+0xf8/0x110)
[   12.082182] [<8011f39c>] (__warn) from [<8011f4cc>] (warn_slowpath_null+0x30/0x38)
[   12.082385] [<8011f4cc>] (warn_slowpath_null) from [<7f0e0a00>] (__cfg80211_disconnected+0x50c/0x528 [cfg80211])
[   12.082781] [<7f0e0a00>] (__cfg80211_disconnected [cfg80211]) from [<7f0b4d24>] (cfg80211_process_wdev_events+0x1a0/0x1a8 [cfg80211])
[   12.083165] [<7f0b4d24>] (cfg80211_process_wdev_events [cfg80211]) from [<7f0b4d68>] (cfg80211_process_rdev_events+0x3c/0x70 [cfg80211])
[   12.083546] [<7f0b4d68>] (cfg80211_process_rdev_events [cfg80211]) from [<7f0af2a4>] (cfg80211_event_work+0x24/0x2c [cfg80211])
[   12.083752] [<7f0af2a4>] (cfg80211_event_work [cfg80211]) from [<80139760>] (process_one_work+0x224/0x518)
[   12.083773] [<80139760>] (process_one_work) from [<8013a77c>] (worker_thread+0x60/0x5c8)
[   12.083792] [<8013a77c>] (worker_thread) from [<80140078>] (kthread+0x118/0x130)
[   12.083813] [<80140078>] (kthread) from [<80108468>] (ret_from_fork+0x14/0x2c)
[   12.083823] ---[ end trace 63daa03c2a449107 ]---
[   12.185208] IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready
[   12.521775] IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready
[   12.524208] Bluetooth: Core ver 2.22
[   12.524328] NET: Registered protocol family 31
[   12.524338] Bluetooth: HCI device and connection manager initialized
[   12.524361] Bluetooth: HCI socket layer initialized
[   12.524378] Bluetooth: L2CAP socket layer initialized
[   12.524413] Bluetooth: SCO socket layer initialized
[   12.534658] Bluetooth: HCI UART driver ver 2.3
[   12.534681] Bluetooth: HCI UART protocol H4 registered
[   12.534691] Bluetooth: HCI UART protocol Three-wire (H5) registered
[   12.534868] Bluetooth: HCI UART protocol Broadcom registered
[   12.554545] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[   12.673905] Netfilter messages via NETLINK v0.30.
[   12.681946] ctnetlink v0.93: registering with nfnetlink.
[   12.692383] IPv6: ADDRCONF(NETDEV_UP): balena0: link is not ready
[   12.847510] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   12.847543] Bluetooth: BNEP filters: protocol multicast
[   12.847583] Bluetooth: BNEP socket layer initialized
[   14.802775] Bridge firewalling registered
[   20.400464] systemd-udevd[53]: starting version 215
[   20.504549] systemd-journald[46]: Received request to flush runtime journal from PID 1
[   21.785881] Error: Driver 'rtl8192cu' is already registered, aborting...

 Front conversations

Is this listing from within the container or from the host OS? I am interested in the one from the host OS. You should be able to use the webterminal feature and select host OS

Right, that was the app container, here's the OS, I see the module is blacklisted.
Spawning shell...
=============================================================
    Welcome to ResinOS
=============================================================
bash-4.3# cat /etc/modprobe.d/rtl8192cu.conf
blacklist rtl8192cu

See comment and reasoning for this here: https://github.com/resin-os/resin-raspberrypi/pull/161/commits/81b266e8c4761e09f0d9b21b8b28e53b80879ac5
So my opinion is that the warning is harmless

Do you have the chance to try multiple board reboots and see if you get the wifi working as expected every time? If somehow you get to a point where this driver gets loaded before the other one, can you plug in eth and let us know so we can investigate on the device?

I will try that this week on a dedicated device yes.

@floion a small update for you, I've done updates and running OS 2.9.7+rev1, still no issues yet.
I've seen some edge case behaviors in my lab but not yet convinced it's related.
Any place I can check relevant firmware updates on release notes of the latest resinos 2.x?
https://github.com/resin-os/resin-raspberrypi/releases/tag/v2.10.1%2Brev1 didn't have any notes


How to create foreign key relation.

Laravel Version: 5.5.39
Voyager Version: 1.0
PHP Version:7.2.3

Description:I want to create foreign key relation in migration.But I could not find migration. Is there any other alternative.
I need this for showing comment in particular blog.
Steps To Reproduce:

I don't quite understand what you mean by "couldn't find migration"... are you looking for one to add it to?
Generally speaking, you shouldn't modify files from a package unless the package explicitly tells you to.  If you modify something, then we change it in a subsequent release, you'll likely lose it when you update.
Instead, you should create a new migration to add what you need

Thanks,.I assumed voyager creates the migration of model itself. It would have been great to have the option for migration similar like the option to create Model.

Yes, that has been requested a numerous times. Unfortunately, there's no easy way to build these migrations automatically.  We haven't found a package that does what we want, and none of us have had the time to build it, so we're stuck waiting for the community to contribute it.
I think you'll find it's more complicated than you thought


Update LAB_AK_03_Lab1_Ex1_Enable_Defender.md

a few updates for clarity.
Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Tested with the latest interface.  Merging with the main branch.


Provide user warning when CPU limits can't be evenly filled by the node requirements

Description
What problem are you trying to solve?
We had a nodepool configured with
    limits:
      cpu: 2063
...
        requirements:
        - key: node.kubernetes.io/instance-type
          operator: In
          values:
          - r6a.8xlarge

This configuration is nonsensical, but we don't get any warning when setting it. It'd be useful to have some warning when specifying a CPU limit that can't be reached given the provided instance-types.
Would be nice if for example, the nodepool could get rejected at write time. Not sure if karpenter has any sort of validator hooks that would allow for this though.
Alternatively maybe karpenter send a log/metric that we could alert on.
How important is this feature to you?
We have tooling on our end that build the nodepool resource, so we can spackle over the issue.
But providing some feedback could help other karpenter users from running into the same problem.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

The limits for a node pool are the maximum amount that the nodepool will manage.  In this case, a single instance won't have 2063, but its possible to launch multiple r6a.8xlarge, and Karpenter will stop launching them if it would exceed the cumulative 2063 CPU limit.

@tzneal understood.
The ask here is if karpenter can (or should) provide some warning when the max isn't achievable with the configured set of instance types.
In this example only r6a.8xlarge was provided so 2063 is impossible given we'll get 32 cores per instance.
Scaling will stop at 2048 cores.
For some extra context on our case, this is problematic because we also use yunikorn (with the same max) to dedicate some CPU capacity to healthcheck jobs. If karpenter can't scale to reach the configured max, yunikorn won't be able to guarantee the existence of the dedicated CPUs.

Thanks! We can plan on doing some sort of check before building the nodepool on our end then.

Sounds good, thanks!


vhost.d/default.conf issue

Hi,
I just switched my domain where your 1.7 version was running without issues.
For the switch I deleted all old certificates (for the previous domain) updated to latest docker-letsencrypt-nginx-proxy-companion, then tried with 1.8,  1.7 again and also 1.4, but for some reason could not get the certificates for the new domain. I saw the acme files in html, but no certificates were generated.
the final solution was in the below old thread,
nginx_location.conf -> location /.well-known/acme-challenge/ always causing 404 for acme-challenge #138
where I just mapped a corrected vhost.d/default into the container with
location ~ /\.well-known/acme-challenge/
in place of
location /.well-known/acme-challenge/
Seems like this was not fixed or came up again? But I am just wondering, why it worked previously ...

This shoud have been fixed recently on master (latest on Dockerhub).

No activity on this issue, closing.


fix issue with click-events being prevented when a device sends mouse-move events along with the click

We discovered that some devices with Windows 8 seem to send a mouseMove event when clicking.
DragDealer calls preventDefault on those, preventing any clickhandlers further up in the chain.
This change detects those events by checking if clientX and clientY are different from the dragStart position on mouseMove and ignores them.

Finished review. Good find!

hi, anything preventing a merge? Otherwise I'd merge it in the next days

Any update on this?

Since @skidding already reviewed this, I'm guessing it's good to merge.

Cool!
For the record, it's useful to leave another heads-up comment after addressing the reviewer's comments. Commits don't trigger notifications, so you'd need to check manually every now and then. This is the practice we use at the company I work at.


fix: Use git binary for checking out references to avoid go-git issues

What does this PR do?
Instead of using the go-git library for checking out tags, commits, and branches, delegate these tasks to the git binary installed in project clone.
In some cases, go-git will fail to checkout references if a repository is large and/or if the changeset between the main and the reference is significant.
What issues does this PR fix or reference?
Fixes https://github.com/devfile/devworkspace-operator/issues/739
Is it tested? How?

Test that clone succeeds for the reproducer:kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: test-project-clone
spec:
  started: true
  template:
    projects:
    - git:
        checkoutFrom:
          revision: 60e69ce868b9b1ed821e7617878f644c0d898cc1
        remotes:
          origin: https://github.com/benoitf/che-code.git
      name: che-code
    components:
      - name: theia
        plugin:
          uri: https://che-plugin-registry-main.surge.sh/v3/plugins/eclipse/che-theia/next/devfile.yaml
          components:
            - name: theia-ide
              container:
                env:
                  - name: THEIA_HOST
                    value: <IP_ADDRESS>

Test all project-clone flows that involve git:apiVersion: workspace.devfile.io/v1alpha2
kind: DevWorkspace
metadata:
  name: plain
spec:
  routingClass: basic
  started: true
  template:
    attributes:
      controller.devfile.io/storage-type: ephemeral
    projects:
    - name: 1-devworkspace-operator-default
      git:
        remotes:
          origin: https://github.com/devfile/devworkspace-operator.git
    - name: 2-devworkspace-operator-tag
      git:
        remotes:
          origin: https://github.com/devfile/devworkspace-operator.git
        checkoutFrom:
          revision: v0.11.0
    - name: 3-devworkspace-operator-branch
      git:
        remotes:
          origin: https://github.com/devfile/devworkspace-operator.git
        checkoutFrom:
          revision: 0.11.x
    - name: 4-devworkspace-operator-branch-with-remote
      git:
        remotes:
          origin: https://github.com/devfile/devworkspace-operator.git
          amisevsk: https://github.com/amisevsk/devworkspace-operator.git
        checkoutFrom:
          revision: 0.11.x
          remote: amisevsk
    - name: 5-devworkspace-operator-hash
      git:
        remotes:
          origin: https://github.com/devfile/devworkspace-operator.git
        checkoutFrom:
          revision: cbd808f5d13bb87dd8597e7e1312c72e11ab080f
    components:
    - container:
        command:
        - tail
        - -f
        - /dev/null
        image: quay.io/amisevsk/web-terminal-tooling:dev
        memoryLimit: 512Mi
        mountSources: true
        sourceMapping: /projects
      name: web-terminal

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

/test v8-devworkspace-operator-e2e, v8-che-happy-path

/retest


Unhandled rejection Error: tunneling socket could not be established, cause=Parse Error

How to deal with this error?  it worked for several days, I didn't change any code, but this occurred today every time i createSocket.
Unhandled rejection Error: tunneling socket could not be established, cause=Parse Error

Hey @shinux , how did you solve it in the end?


Depth data/alignment sometimes corrupted on camera startup with OpenMP off (.NET)

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10 1709

Platform
PC, .NET, x64

SDK Version
2.10.0 compiled without OpenMP

Hi,
I compiled the DLL without OpenMP to fix the high CPU usage problem.
However, when using this version of the DLL (the precompiled version doesn't show this behaviour) I get some strange behaviour when starting up the streams.
Firstly, this is what I should see when the camera is streaming:

The image is coloured by the (aligned) depth. If the depth of a pixel is within a pre-defined range it's normal colour, if it's outside of that range but still has depth data it's tinted red, and if there's no depth data (z = 0) it's coloured dark grey.
Sometimes when starting the streams (the code to start the camera is always the same; I'm using 1920x1080 colour and 848x480 depth) I get the following:

Depth data is all zero. Usually stopping the camera, waiting a few seconds, then starting it again will fix this.

Alignment is out. Usually if it starts doing this, I need to restart the app completely to get it normal again.
One of the above two scenarios happens probably about 50% of the time I start the camera. The following two are much rarer than that.

A small line of depth data in the centre of the image.

Alignment completely out and lots of poor depth areas.
I initially thought this may be due to how I'm closing the camera as it seems to happen more often when closing the camera (not the app) and starting it again within a few seconds, but it occasionally happens the first time the app is opened too. I shut the camera down by calling pipeline.Stop() and pipeline.Dispose(). Is there anything else I should be doing? Does disposing the pipeline also dispose of all child objects or do I need to dispose of everything individually? Or is this just one of the issues that having OpenMP enabled solves?
As I said, using the standard DLL fixes this issue but CPU usage goes to around 80-90% vs around 20% with openMP off so I'd rather have it turned off if possible to support lower-powered devices.
Thanks,
James

Does the same thing happen if you compile with OpenMP and not use the precompiled dll?

Not as regularly, but yes.

Hi @jb455
Is this problem reproducible on another PC with pre-built examples? I am cautious not to call it a hardware issue, but this seems completely abnormal and might be indicative of some severe problem with the device / platform.

Hi sorry, I've been using precompiled binaries without any problems. I don't really have time to try reproducing this now, but if no-one else has seen these issues then it must be something to do with my machine and/or code. In any case, it's not a problem for me now so I'll close this issue.

OpenMP 100% CPU usage can be solved by settings environment variable OMP_WAIT_POLICY=PASSIVE


Files don't get created or saved

Issue Type: Bug
If I try to create or save a file, the progress bar just goes on forever. If I try the same from the cli, the file gets created and written to like normal. Also I only face this issue for projects saved on my HDD, it doesn't occur for projects saved on my SSD.

Start Extension Bisect only disables extensions during its testing. If it identified Material Theme as the cause of the problem please disable it yourself in the Extensions view.

I tried one more Start Extension Bisect and I felt as if the debug was just picking out a random extension and telling me it is bugged so i cloned down my code to a new folder, opened vscode, reloaded it with all extensions disabled, and the issue persists. This seems extremely weird

Update: Seems like the problem was with my hard drive. Everything works well now on a new hard drive as well as on my SSD. Thanks for all the help!!!


First crash report fails

The first crash report tends to get a 403, whereas subsequent ones succeed.
Log from first:
==> /var/log/tomcat8/catalina.out <==
Hibernate: select user0_.`username` as username1_6_, user0_.`password` as password2_6_ from `user` user0_ where user0_.`username`=?
Hibernate: select roles0_.`user_username` as user_use1_8_0_, roles0_.`roles` as roles2_8_0_ from `user_roles` roles0_ where roles0_.`user_username`=?
Hibernate: select permission0_.`user_username` as user_use1_7_0_, permission0_.`app_id` as app_id2_7_0_, permission0_.`level` as level3_7_0_, app1_.`id` as id1_0_1_, app1_.`ignore_android_line_numbers` as ignore_a2_0_1_, app1_.`ignore_instance_ids` as ignore_i3_0_1_, app1_.`match_by_message` as match_by4_0_1_, app1_.`name` as name5_0_1_, app1_.`reporter_username` as reporter6_0_1_ from `user_permissions` permission0_ left outer join `app` app1_ on permission0_.`app_id`=app1_.`id` where permission0_.`user_username`=?

==> /var/log/tomcat8/localhost_access_log.2018-07-27.txt <==
<IP_ADDRESS> - - [27/Jul/2018:01:53:01 +0200] "POST /android/report HTTP/1.0" 403 300

Log from second:
==> /var/log/tomcat8/catalina.out <==
Hibernate: select user0_.`username` as username1_6_, user0_.`password` as password2_6_ from `user` user0_ where user0_.`username`=?
Hibernate: select roles0_.`user_username` as user_use1_8_0_, roles0_.`roles` as roles2_8_0_ from `user_roles` roles0_ where roles0_.`user_username`=?
Hibernate: select permission0_.`user_username` as user_use1_7_0_, permission0_.`app_id` as app_id2_7_0_, permission0_.`level` as level3_7_0_, app1_.`id` as id1_0_1_, app1_.`ignore_android_line_numbers` as ignore_a2_0_1_, app1_.`ignore_instance_ids` as ignore_i3_0_1_, app1_.`match_by_message` as match_by4_0_1_, app1_.`name` as name5_0_1_, app1_.`reporter_username` as reporter6_0_1_ from `user_permissions` permission0_ left outer join `app` app1_ on permission0_.`app_id`=app1_.`id` where permission0_.`user_username`=?
Hibernate: select app0_.`id` as id1_0_, app0_.`ignore_android_line_numbers` as ignore_a2_0_, app0_.`ignore_instance_ids` as ignore_i3_0_, app0_.`match_by_message` as match_by4_0_, app0_.`name` as name5_0_, app0_.`reporter_username` as reporter6_0_ from `app` app0_ where app0_.`reporter_username`=?
Hibernate: select stacktrace0_.`id` as id1_5_, stacktrace0_.`bug_id` as bug_id5_5_, stacktrace0_.`stacktrace` as stacktra2_5_, stacktrace0_.`version_code` as version_3_5_, stacktrace0_.`version_name` as version_4_5_ from `stacktrace` stacktrace0_ where stacktrace0_.`stacktrace`=? and stacktrace0_.`version_code`=?
Hibernate: select bug1_.`id` as id1_2_, bug1_.`app_id` as app_id4_2_, bug1_.`solved` as solved2_2_, bug1_.`title` as title3_2_ from `stacktrace` stacktrace0_ inner join `bug` bug1_ on stacktrace0_.`bug_id`=bug1_.`id` where bug1_.`app_id`=? and (stacktrace0_.`stacktrace` like ? escape '!') limit ?
Hibernate: select report0_.`id` as id1_4_2_, report0_.`android_version` as android_2_4_2_, report0_.`brand` as brand3_4_2_, report0_.`content` as content4_4_2_, report0_.`date` as date5_4_2_, report0_.`installation_id` as installa6_4_2_, report0_.`phone_model` as phone_mo7_4_2_, report0_.`stacktrace_id` as stacktr10_4_2_, report0_.`user_comment` as user_com8_4_2_, report0_.`user_email` as user_ema9_4_2_, stacktrace1_.`id` as id1_5_0_, stacktrace1_.`bug_id` as bug_id5_5_0_, stacktrace1_.`stacktrace` as stacktra2_5_0_, stacktrace1_.`version_code` as version_3_5_0_, stacktrace1_.`version_name` as version_4_5_0_, bug2_.`id` as id1_2_1_, bug2_.`app_id` as app_id4_2_1_, bug2_.`solved` as solved2_2_1_, bug2_.`title` as title3_2_1_ from `report` report0_ inner join `stacktrace` stacktrace1_ on report0_.`stacktrace_id`=stacktrace1_.`id` left outer join `bug` bug2_ on stacktrace1_.`bug_id`=bug2_.`id` where report0_.`id`=?
Hibernate: insert into `bug` (`app_id`, `solved`, `title`) values (?, ?, ?)
Hibernate: insert into `stacktrace` (`bug_id`, `stacktrace`, `version_code`, `version_name`) values (?, ?, ?, ?)
Hibernate: insert into `report` (`android_version`, `brand`, `content`, `date`, `installation_id`, `phone_model`, `stacktrace_id`, `user_comment`, `user_email`, `id`) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)

==> /var/log/tomcat8/localhost_access_log.2018-07-27.txt <==
<IP_ADDRESS> - - [27/Jul/2018:01:53:30 +0200] "POST /android/report HTTP/1.0" 200 -

This appears to have been fixed by https://github.com/F43nd1r/Acrarium/commit/26c80a934c7cbc001e11c28508812528c53233f2 . I think?

The first report went through for me, so I'm assuming it is fixed.


[ISSUE] Duplicate spec.strategy

Describe the issue:

On some templates, there are multiple spec.strategy fields, for example here:
https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-latest/templates/operate/deployment.yaml#L11-L12
https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-latest/templates/operate/deployment.yaml#L14-L17
Actual behavior:

I fear that as soon as operate.strategy is set, the template will not work anymore.
Expected behavior:

This meaningful default should be part of the values.yaml
How to reproduce:

Logs:

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform: k8s
Helm CLI version: irrelevant
Chart version: 10.2.1
Values file: operate.strategy.type: Recreate

### Tasks
- [ ] https://github.com/camunda/camunda-platform-helm/pull/2155

After discussing with my team I will do the following:
I will remove the strategy option from the operate and tasklist components in the values.yaml for the latest version (8.5). I will have to check with the teams if this option can be kept in the alpha version.

I asked both teams if the rolling update could be possible in 8.6

I can confirm that operate will not support rolling update in 8.6 release. So I will make the same change for operate in the alpha version.
Reference: https://camunda.slack.com/archives/C9B5270DA/p1722237321400769?thread_ts=1722010893.157929&cid=C9B5270DA

I will also make the same change for optimize

UPDATE:
We will rollback the feature of configuring the deployment strategy. I have created a new issue for this and am currently working on the PR:
https://github.com/camunda/camunda-platform-helm/issues/2160


expose driver config

It allows to use custom driver config. It can be used to install private CA inside buildx. That way insecure access is not required.
buildkit_driver: docker-container
buildkit_driver_opt: image=private_registry/buildx_with_ca:latest

Can you please add a bit more details explanation of your use case and why this feature is useful for others?

Closing due to missing feedback.

I already added more explanation in original comment. The simply it allows to pass private CA to buildix

We have already the option to set a custom buildkit config https://github.com/thegeeklab/drone-docker-buildx/issues/153 where you can also add custom CAs see https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md
This way doesn't work for you? A lot of the features around the drivers and its options are not supported/working with Drone.

I saw that already but how I'm supposed to copy those file inside buildx container? Is it done automatically?

No, you would have to handle it on your own. One way would be to mount volume from the agent host system for trusted repositories, as described in https://docs.drone.io/pipeline/docker/syntax/volumes/host/

It works only for 1st layer. This is docker in docker so there are two layers. Unless I'm missing something.

It's using buildx from the plugin container. However, as the plugin is able to read the custom buildkitd.toml which is only propagated to the plugin container, CA files mounted to the plugin container should work as well.

From the docs: https://docs.docker.com/engine/reference/commandline/buildx_create/#config

Note that if you create a docker-container builder and have specified certificates for registries in the buildkitd.toml configuration, the files will be copied into the container under /etc/buildkit/certs and configuration will be updated to reflect that.

@tomaszduda23 were you able to test it?

I will check and let you know if some time. Even if it works it may be useful for some people to access extra settings.

Thank you. I will close the PR again. If more people want this feature, I'm happy to discuss it again, but otherwise I'd still like to avoid it.


Version 3.0.0 - nonce problems

Hi
I use many exchenges in my project. But Poloniex and Bleutrade have a problem with the nonce.
Poloniex:
com.xeiam.xchange.exceptions.ExchangeException: Nonce must be greater than<PHONE_NUMBER>570312. You provided 313391042.
Bleutrade:
com.xeiam.xchange.exceptions.ExchangeException: Invalid nonce number
What I  can do?

You can try to

use the latest snapshot jars or build from the develop branch
generate a new API key at those two exchanges.

If you try those things and still have problems, the nonce code will need to be fixed after identifying the exact problem.

OK. I will test it.
thx

Are you running two connections to the same exchange using the same API key?  That can cause noonce problems.  In general, if you have more than one thread/connection to an exchange, use a seperate api key for each.

Yes, exactly this is my problem. I use a PHP bot for trading. This bot has a poor statistik. Now I want to me with this lib. But I can't change the API key or so. But, I hacked this code. Is this a good solution?
Bleuetrad work with this nonceFactory.
exSpec.setApiKey(bleutradePublickey);
exSpec.setSecretKey(bleutradePrivatekey);
exSpec.setNonceFactory(new CurrentTime1000NonceFactory());
If this nonceFactory not set, it use the default factory.


Handle json decode error in mavc cache

A bit of a revamp of read_script_env_cache and write_script_env_cache. The significant change is that on read, a JSDONDecodeError is detected, and the cache file removed if so - we're guessing a write race corrupted the file.
If this works, will update with more "PR polish", else will withdraw.  The "guess" is because only the AppVeyor build on Py 3.6/VS 2017 hits this, haven't reproduced in a developer context yet.
There's no external visibility, so no doc impacts.
Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[x] I have updated CHANGES.txt (and read the README.rst)
[ ] I have updated the appropriate documentation

The 3.6 build passed.

Looks good to me. PR polish it up and we'll get it merged.

aaand.... the vs2019/py3.8 version failed...

Perhaps a one-off...
[00:12:32] 548/1276 (42.95%) C:\Python38\python.exe test\Interactive\cache-force.py
[00:12:32] Traceback (most recent call last):
[00:12:32]   File "test\Interactive\cache-force.py", line 77, in <module>
[00:12:32]     shutil.rmtree(test.workpath('cache'))
[00:12:32]   File "C:\Python38\lib\shutil.py", line 740, in rmtree
[00:12:32]     return _rmtree_unsafe(path, onerror)
[00:12:32]   File "C:\Python38\lib\shutil.py", line 613, in _rmtree_unsafe
[00:12:32]     _rmtree_unsafe(fullname, onerror)
[00:12:32]   File "C:\Python38\lib\shutil.py", line 618, in _rmtree_unsafe
[00:12:32]     onerror(os.unlink, fullname, sys.exc_info())
[00:12:32]   File "C:\Python38\lib\shutil.py", line 616, in _rmtree_unsafe
[00:12:32]     os.unlink(fullname)
[00:12:32] PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\testcmd.3156.7qs4b5ta\\cache\\43\\439f39656a672b443377ce1f8f10f2ac.tmp745b176afa424b60abd41d46c8b225fb'

aaand.... the vs2019/py3.8 version failed...

worked on the rebuild after the PR (non-code) update...

Okay, the latest build caught a conflict on camera:
[00:20:08] 671/1276 (52.59%) C:\Python311\python.exe test\MSVC\MSVC_TOOLSET_VERSION.py
[00:20:08] C:\projects\scons\scripts\scons.py returned 2
[00:20:08] STDOUT =========================================================================
[00:20:08]
[00:20:08] STDERR =========================================================================
[00:20:08] PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\appveyor\\scons_msvc_cache.json':
[00:20:08]   File "C:\Users\appveyor\AppData\Local\Temp\1\testcmd.6564.htzu3wg5\SConstruct", line 3:
[00:20:08]     env = Environment(MSVC_VERSION='14.3', MSVC_TOOLSET_VERSION='<IP_ADDRESS>', tools=['msvc'])

I think this means we are getting races on the cachefile.  I wonder if we need to be more polite on writes... like elsewhere in the codebase, write it to a temporary file, then rename it over if it succeeded. Not quite sure the implications - dueling changes to the contents?  Or maybe try some kind of locking protocol?

mention @jcbrill so he's aware of this pending stuff too...

@mwichmann Thanks.
I was looking at the changes earlier today.  Looks good to me.
I periodically experience the file access errors.  Typically happens when I forget to disable windows defender real-time scanning in a Windows VMWare virtual machine.  I believe the disabled state resets to enabled when the virtual machine is rebooted.

The previous note about a failure would seem to be related to #4268

The previous note about a failure would seem to be related to https://github.com/SCons/scons/issues/4268

@mwichmann There is definitely a race condition (and likely cache information loss) as the cache is read-once, write-multiple times and unprotected from multiple-process access.
I have a "reference implementation" outside of SCons that uses a Windows named mutex to serialize access to the cache which relies on all correctly "normalizing" the real path to the cache file.
The repository for the code is still private.  I would be happy to add you and @bdbaddog as a contributor in the short term to be able to view/review the implementation.

that would be cool.  I've got a simple file locker sitting around which might also be of use; it tries to be portable so doesn't use any specific tricks (just tries to get exclusive access to a lockfile), but I think we only care about Windows, so someting WIndows-specific might be fine. Or do we care about the Mac case?

An invite should have been sent.
Can be extraordinarily inefficient when multiple processes write many entries at the same time due to loss protection.  Tested earlier with 4 python interpreters building all possible combinations (i.e., long-running and writing many entries).  This is worst-case scenario as they are basically running in lock-step and possibly running the same cache entry build at the same time.
Files of interest:

mswindev/winsync.py (wrapper for windows mutex)
mswindev/winapi.py (windows api calls via ctypes)
mswindev/vsdetect.py (cache implementation starting around line 12,573)

ah, forgot it's used twice. for debug, it's logging and so you're supposed to use (template, args...).  I'll take a look later, deep in something at the moment.

Yes, I got caught between changes - did something, then changed it again and didn't clean up. Thanks for spotting.


False positive for NoUnusedImports

Expected Behavior
Detekt should not report NoUnusedImports for used import.
Steps to Reproduce
Bar.kt
package detekt.bar

fun `is`() = Unit

Foo.kt
package detekt

import detekt.bar.`is` as is2

fun foo() = is2()

Detekt reports issue NoUnusedImports in line import detekt.bar.`is` as is2
Your Environment

Version of detekt used: 1.15.0-RC1
Operating System and version: Mac OS 10.15.7

The NoUnusedImports rule is a rule that we mirror from KtLint: https://github.com/pinterest/ktlint/blob/master/ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/NoUnusedImportsRule.kt
You should open a similar issue on https://github.com/pinterest/ktlint (perhaps they already have a similar issue resolved https://github.com/pinterest/ktlint/issues/910).
Closing as this is unrelated to us.


FPP: Multisig coordination of Stellar tx signing

This will be a fairly involved issue (Epic) so I've not filled it out yet
What problem does your feature solve?
Coordinating signatures for a Stellar tx from m-of-n signers
What would you like to see?
A server that connects to other servers given fixed hostnames or IP addresses.
The server initiates the signing of a Stellar tx from these n servers. Note that the starting point is a Stellar tx.
Once fully signed it can return it using an API or to keep things simple it can just display it on-screen.
Additionally, there is an API we will need to develop such that the invoking caller can interface with this decentralized service. For example, when we /submit (POST) the stellar tx to be signed, we might get a HTTP 200 response and later need to GET the signed tx fully signed (or partially signed to get the /status).
Non-Goals
This is a single-responsibility component. This will be invoked by a higher-level orchestrator. We don't need to worry about validation of the Stellar tx, or the question of whether this Stellar tx has been submitted previously or not since that is validated by the Validation component (see other issues in this milestone)
What alternatives are there?
A lot of this is outlined in the multisig federation SEP protocol doc here that we can look at: https://docs.google.com/document/d/1mBxYsyuEj7j3fqMdvcJHZ5REZZpz3yjBe3OGjS13zoA/edit
We can look at satoshipay's reference implementation for this here: https://github.com/satoshipay/signature-coordinator
There's also Refactor from Stellar-Expert: https://github.com/stellar-expert/refractor

WIP is at https://github.com/leighmcculloch/gravitybeam, and after chatting to @nikhilsaraf I'll probably keep it in its own repo and move it to the stellar org.

Any chance you could make the GDoc public?


Notifications/actions on the master area do not work.

Alarmo Version
v1.9.7
HA Version
2023.2.5
Bug description
Notification and actions on the 'master' area do not work - so need to add notifications/actions for each area.
Steps to reproduce
No response
Relevant log output
No response

I set up this notification:

Next I arm the master.
Notification is sent:

In summary, I don't agree that

Notification and actions on the 'master' area do not work

Please provide details if you have some specific issue.

That's strange - they don't seem to work for me.
Will re-test and get back to you!


code-for-ibmi.deleteIFS should not let shortcuts be deleted from the system

singleItem: IFSItem should be singleItem: IFSItem|IFSShortcutItem and then check if singleItem is of type IFSShortcutItem - or just remove the shortcut and not delete the directory.
This is in ifsBrowser.ts

@worksofliam , just to be clear, if it is of type IFSShortcutItem then remove the shortcut rather than delete the directory it's pointing to.  Is that right?

@PerryRaleigh correct!


APIv2 ExecStart (Attached Only)

This implements ExecStart for APIv2. It presently only supports attached, streaming exec.
Not really tested yet.
Missing:

APIv2 bindings for exec start and resize
Bindings tests for exec
Exec reaper for APIv2 server to reap dead exec sessions from running containers

What's not going to be in here:

Podmanv2 tunnel client implementation: requires writing a frontend for our attach code, which is definitely out of scope

@marusak FYI. I suspect this isn't really working yet, but it's pretty close.

Update: session starts, seems to display STDOUT correctly. Still does not correctly handle STDIN, but seems a lot closer than it was.

TODO: Failing to sync exec session status as container was completely removed should not be fatal

ERRO[0021] Received unexpected attach type +3, discarding 130 bytes
Hmmm.
@haircommander Any reason for Conmon to be sending us a 3 header in a terminal attach?

ERRO[0021] Received unexpected attach type +3, discarding 130 bytes
Hmmm.
@haircommander Any reason for Conmon to be sending us a 3 header in a terminal attach?

uh not to my knowledge

@mheon Whats going on with this one?

Picking it back up on Monday
On Sat, May 9, 2020, 05:14 Daniel J Walsh<EMAIL_ADDRESS>wrote:

@mheon https://github.com/mheon Whats going on with this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/5831#issuecomment-626134568,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCGLCVYRNCPSA7M6Z7DRQUNGDANCNFSM4MI37C6Q
.

Should be working now. @marusak If you're interested in testing, would be appreciated.

Stripping WIP.

This should be ready now. @rhatdan @vrothberg @baude @giuseppe @TomSweeneyRedHat @jwhonce PTAL

lgtm needs a peek from @jwhonce

Comments addressed

/lgtm
/hold

/hold cancel


[BUG] Giving up and reverting to previous version

I'm sorry to say that the level of complexity introduced into this version is just too much for me. The module doesn't work in a consistent or reliable manner, and while it seems to have some promise, I'm reverting to szefo09 until the bugs can be worked out. I'm happy to help with updating the documentation once this module is in a more workable form.
Again, I'm really grateful you've picked this up, but I think it's gotten much too complicated to make it really workable at the moment.

Wow and did you need to open a issue for say this ? Have you at least tried to enable the debug module setting like i ask to you for help me out ? Ty for not helping then.

You're right, and I apologize. I should not have opened an issue on this. I had a tough day yesterday, completely unrelated to your work.
I have downloaded the code and am looking at the documentation right now. I will try to upload some suggested changes to the readme if you're open to that.

No i'm sorry , i was angry for another thing, is just a game... forgive me

I think i found a error if you wanna weight until tomorrow i will do some tests tonight

awsome! i'll check out the new version and see if I can't help with feedback.


Create a request with query having duplicate keys

There are libraries in java that automatically translate the query from the following url into list objects.
https://myurl.com/test?mykey=value1&mykey=value2

I was wondering if there could be something like that implemented in guzzle
$client->get('myurl.com', [
    'query' => [
        'mykey' => [
            'value1'
            'value2'
        ]
    ]
]);

For example the following library
jax-rs
http://www.mkyong.com/webservices/jax-rs/jax-rs-queryparam-example/

Thanks for the suggestion. I'm on the fence as to what level Guzzle should support something like this in Guzzle itself. It could easily be a separate library, and I haven't come up with a design I really like for this.This is a duplicate of https://github.com/guzzle/guzzle/issues/1196 so closing in favor of that long standing issue.


error: failed to commit transaction (invalid or corrupted package)

Doesn't seem to work currently.
(1)(deck@steamdeck ~)$ sh -c "$(curl -fsSL https://raw.githubusercontent.com/malordin/steamdeck-samba-server/main/script.sh)"

WARNING: This script will install Samba server on your system.
Did you change the password via passwd? [Y/N] y
Please enter your password: [sudo] password for deck: Continuing with Samba server installation...
Disabling steamos-readonly...
Editing pacman.conf file...
Populating pacman keys...
==> Appending keys from archlinux.gpg...
==> Updating trust database...
gpg: next trustdb check due at 2023-10-27
Initializing pacman keys...
Installing samba...
:: Synchronizing package databases...
 jupiter-rel is up to date
 holo-rel is up to date
 core-rel is up to date
 extra-rel is up to date
 community-rel is up to date
 multilib-rel is up to date
resolving dependencies...
looking for conflicting packages...

Packages (3) liburing-2.2-1  perl-parse-yapp-1.21-5  samba-4.17.1-1

Total Installed Size:  56.65 MiB

:: Proceed with installation? [Y/n]
(3/3) checking keys in keyring                                                                [#######################################################] 100%
(3/3) checking package integrity                                                              [#######################################################] 100%
error: liburing: signature from "David Runge<EMAIL_ADDRESS>is invalid
:: File /var/cache/pacman/pkg/liburing-2.2-1-x86_64.pkg.tar.zst is corrupted (invalid or corrupted package (PGP signature)).
Do you want to delete it? [Y/n]
error: failed to commit transaction (invalid or corrupted package)
Errors occurred, no packages were upgraded.
Adding 'deck' user to samba user database...
sudo: smbpasswd: command not found
Enabling and starting smb service...
Failed to enable unit: Unit file smb.service does not exist.
Failed to start smb.service: Unit smb.service not found.
Writing new smb.conf file...
tee: /etc/samba/smb.conf: No such file or directory
Restarting smb service...
Failed to restart smb.service: Unit smb.service not found.
Filesystem now read-only
Samba server set up successfully! You can access the 'steamapps', 'downloads' and 'mmcblk0p1' folders on your Steam Deck from any device on your local network.
Press Enter to continue...

It looks like you are having the keys checked during installation for some reason, try editing the file manually. Go to /etc/ via Steam Deck explorer and find the pacman.conf file, open it with KWrite text editor, find the line that starts with SigLevel =
and make this line equal to this:
 SigLevel = TrustAll
Save the changes and try to run the script again.

As far as I can tell SigLevel = TrustAll was already added by your script (this screenshot before any changes). I assume it's in there multiple times because I ran the script multiple times.

I'm having this same issue. After running steamos updates, samba quit working for me with "smb.service does not exist", and attempting to reinstall leads to the same as above.
SigLevel = TrustAll is already set by the script.
I can set up and configure samba on other distros easy peasy but trying to get it running on the steamdeck is endlessly tricky and I had to rely on this script last time.

@miscalaneous
@QuickBASIC
Apparently something really broke with the Steam OS update. Please run the following commands and then run the script with Samba again.
sudo steamos-readonly disable
sudo rm -r /etc/pacman.d/gnupg
sudo pacman-key --init
sudo pacman-key --populate archlinux
sudo pacman -Sy gnupg archlinux-keyring

When asked Y or N, answer "Y."
I had the same error, I checked everything again and I have it working. Please do what I ask and share the results, thanks.

It got farther along the install process, but fails after it adds the deck user to the samba database.
I tried manually installing samba and then running the script but it throws the same errors.
One thing to note though, is that I upgraded to the Preview channel of Steam OS.
(deck@steamdeck ~)$ sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/malordin/steamdeck-samba-server/main/script.sh)"
WARNING: This script will install Samba server on your system.
Did you change the password via passwd? [Y/N] y
Please enter your password: Continuing with Samba server installation...
Disabling steamos-readonly...
Warning: The rootfs is already read-write!
         Nothing is performed.
Editing pacman.conf file...
Populating pacman keys...
==> Appending keys from archlinux.gpg...
==> Updating trust database...
gpg: next trustdb check due at 2023-09-30
Initializing pacman keys...
Installing samba...
:: Synchronizing package databases...
 jupiter-rel is up to date
 holo-rel is up to date
 core-rel is up to date
 extra-rel is up to date
 community-rel is up to date
 multilib-rel is up to date
warning: samba-4.17.1-1 is up to date -- reinstalling
resolving dependencies...
looking for conflicting packages...

Packages (1) samba-4.17.1-1

Total Installed Size:  56.35 MiB
Net Upgrade Size:       0.00 MiB

:: Proceed with installation?
Adding 'deck' user to samba user database...
smbpasswd: /usr/lib/samba/libsamba3-util-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libmsrpc3-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libgenrand-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libreplace-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libcliauth-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/liblibsmb-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libsecrets3-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libsamba-debug-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libcli-smb-common-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
smbpasswd: /usr/lib/samba/libdcerpc-samba-samba4.so: version `SAMBA_4.17.1_SAMBA4' not found (required by smbpasswd)
Enabling and starting smb service...
Job for smb.service failed because the control process exited with error code.
See "systemctl status smb.service" and "journalctl -xeu smb.service" for details.
Writing new smb.conf file...
Restarting smb service...
Job for smb.service failed because the control process exited with error code.
See "systemctl status smb.service" and "journalctl -xeu smb.service" for details.
Filesystem now read-only
Samba server set up successfully! You can access the 'steamapps', 'downloads' and 'mmcblk0p1' folders on your Steam Deck from any device on your local network.
Press Enter to continue...

@miscalaneous
Valve is apparently breaking the samba package and its dependencies in some way. I ran into the exact same problem, but in trying to fix it I only completely broke my system. When upgrading from a bootable flash drive and updating to the latest Steam OS version, the script works fine.
➜  ~ sh -c "$(curl -fsSL https://raw.githubusercontent.com/malordin/steamdeck-samba-server/main/script.sh)"
WARNING: This script will install Samba server on your system.
Did you change the password via passwd? [Y/N] Y
Please enter your password: Continuing with Samba server installation...
Disabling steamos-readonly...
Editing pacman.conf file...
Initializing pacman keys...
Populating pacman keys...
==> Appending keys from archlinux.gpg...
==> Updating trust database...
gpg: next trustdb check due at 2023-12-31
Installing samba...
:: Synchronizing package databases...
 jupiter-3.5 is up to date
 holo-3.5 is up to date
 core-3.5 is up to date
 extra-3.5 is up to date
 community-3.5 is up to date
 multilib-3.5 is up to date
resolving dependencies...
looking for conflicting packages...

Packages (1) samba-4.18.3-1

Total Installed Size:  56.41 MiB

:: Proceed with installation?
Writing new smb.conf file...
Adding 'deck' user to samba user database...
New SMB password:
Retype new SMB password:
Enabling and starting smb service...
Created symlink /etc/systemd/system/multi-user.target.wants/smb.service → /usr/lib/systemd/system/smb.service.
Restarting smb service...
Filesystem now read-only
Samba server set up successfully! You can access the 'steamapps', 'downloads' and 'mmcblk0p1' folders on your Steam Deck from any device on your local network.
Press Enter to continue...
➜  ~ sudo cat /etc/*-release
DISTRIB_ID="SteamOS"
DISTRIB_RELEASE="rolling"
DISTRIB_CODENAME="Holo"
DISTRIB_DESCRIPTION="SteamOS Holo"
NAME="SteamOS"
PRETTY_NAME="SteamOS"
VERSION_CODENAME=holo
ID=steamos
ID_LIKE=arch
ANSI_COLOR="1;35"
HOME_URL="https://www.steampowered.com/"
DOCUMENTATION_URL="https://support.steampowered.com/"
SUPPORT_URL="https://support.steampowered.com/"
BUG_REPORT_URL="https://support.steampowered.com/"
LOGO=steamos
VARIANT_ID=steamdeck
VERSION_ID=3.5.7
BUILD_ID=20231122.1
➜  ~

I guess in your case you need to uninstall samba and its dependencies and install it again, but I don't have this error anymore and I don't know how to fix it. It would be great if you suddenly fixed it, then tell me what was done to fix it! :)

@miscalaneous
Valve is apparently breaking the samba package and its dependencies in some way. I ran into the exact same problem, but in trying to fix it I only completely broke my system. When upgrading from a bootable flash drive and updating to the latest Steam OS version, the script works fine.
➜  ~ sh -c "$(curl -fsSL https://raw.githubusercontent.com/malordin/steamdeck-samba-server/main/script.sh)"
WARNING: This script will install Samba server on your system.
Did you change the password via passwd? [Y/N] Y
Please enter your password: Continuing with Samba server installation...
Disabling steamos-readonly...
Editing pacman.conf file...
Initializing pacman keys...
Populating pacman keys...
==> Appending keys from archlinux.gpg...
==> Updating trust database...
gpg: next trustdb check due at 2023-12-31
Installing samba...
:: Synchronizing package databases...
 jupiter-3.5 is up to date
 holo-3.5 is up to date
 core-3.5 is up to date
 extra-3.5 is up to date
 community-3.5 is up to date
 multilib-3.5 is up to date
resolving dependencies...
looking for conflicting packages...

Packages (1) samba-4.18.3-1

Total Installed Size:  56.41 MiB

:: Proceed with installation?
Writing new smb.conf file...
Adding 'deck' user to samba user database...
New SMB password:
Retype new SMB password:
Enabling and starting smb service...
Created symlink /etc/systemd/system/multi-user.target.wants/smb.service → /usr/lib/systemd/system/smb.service.
Restarting smb service...
Filesystem now read-only
Samba server set up successfully! You can access the 'steamapps', 'downloads' and 'mmcblk0p1' folders on your Steam Deck from any device on your local network.
Press Enter to continue...
➜  ~ sudo cat /etc/*-release
DISTRIB_ID="SteamOS"
DISTRIB_RELEASE="rolling"
DISTRIB_CODENAME="Holo"
DISTRIB_DESCRIPTION="SteamOS Holo"
NAME="SteamOS"
PRETTY_NAME="SteamOS"
VERSION_CODENAME=holo
ID=steamos
ID_LIKE=arch
ANSI_COLOR="1;35"
HOME_URL="https://www.steampowered.com/"
DOCUMENTATION_URL="https://support.steampowered.com/"
SUPPORT_URL="https://support.steampowered.com/"
BUG_REPORT_URL="https://support.steampowered.com/"
LOGO=steamos
VARIANT_ID=steamdeck
VERSION_ID=3.5.7
BUILD_ID=20231122.1
➜  ~

I guess in your case you need to uninstall samba and its dependencies and install it again, but I don't have this error anymore and I don't know how to fix it. It would be great if you suddenly fixed it, then tell me what was done to fix it! :)

Apologies for the necro.
I think I did end up getting it running again, but it broke with a subsequent update.
I recently upgraded to a Steam Deck OLED and will be attempting setting this up again, and I remembered reading that awhile back SteamOS added whitelists, which might let samba and samba config persist through updates.
Haven't found any documentation on it yet though and I'm still a newbie to Arch. Just something to maybe look into.


Native Support for Optional Type Value Schema

Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
In the clipper-merlin adaptation of aerie we define custom value mappers for Optional Types. The value schema for this value mapper is a struct containing two elements: "present" and "value". "Present" has a ValueSchema of a boolean and "value" whatever is returned from a getValueSchema() call on a valueMapper we ingest in the constructor for OptionalValueMapper. Our issue is we want to support any valueSchema for "value" when "present" is true, however, if it is false we would like to override whatever the valueSchema might return for "value" and instead enforce the entry as being null. This functionality will allow UI entry of optional type parameters to better reflect the underlying information stored in the java Optional object.
Related to this issue.
Describe the feature request
The feature request to solve the issue mentioned above would be the creation of a new OptionalValueSchema for aerie. This value schema would still provide some kind of Boolean element to select whether the parameter is "present" or not, however, in the event that this present flag is false we would like the "value" to always be null.

To re-state the problem: we would like support optional activity parameters. Clipper wrote a custom value mapper for the java.util.Optional type, but we'e run into a number of problems trying to use that in schedule eDSL. It would be useful to have native support for optional parameters.


Textmesh object creates error

Textmesh Object creates error
Description

When creating an Textmesh object it's working in the editor, but not if the project is running

Version

nunuStudio 0.98.15 Build 2020-08-05T22:19:34.347Z

Platform

Web Version [X]
Windows [X]
Linux [X]

The textmesh object might not be available outside of the editor i will have to check this.
Im still working on the modularized version of the editor i might have forgotten some objects that are not being exported to the script scope.
Thanks a lot


Generic cluster umut

Description
discord username: afetharita#0001
closes #issue
Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.
## Things to check before creating a PR

[ ] I have inspected my topic, checked.
[ ] If it is a core feature, executed detailed tests.

Creating PR rules

[ ] PR must be created for an issue with approved tag. Otherwise PR will be rejected.
[ ] Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
[ ] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
[ ] Related file selection: Only relevant files should be touched and no other files should be affected.
[ ] Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
[ ] Clean commit history: The commits where the changes are made should be clear and organized.
[ ] Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

[ ] A new feature (a change that adds a new feature, not a breaking change)
[ ] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

How were these changes tested?
Please describe the tests you did to test the changes you made. Please also specify your test configuration.
Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

deploy failed

TODO: pass radius as props to GenericClusterGroup
TODO: update filter route.push to include all filters
TODO: update URL on first load with default filters
TODO: Nearby markers
TODO: onCopyClipboard (copy map link)
TODO: Previously Clicked marker needs to be gray
TODO: swap lat&lng in heatmap
cc @oguzergul @fdemir @mertkaya1033

I fixed copy clipboard, heatmap, and radius prop.  todos. I still work on saving visited markers on local forage. @usirin @fdemir

[ ] TODO: move drawer open - close handlers to a common place

I am working on moving things to getServerSideProps and updating filter route.push to include all filters @oguzergul @fdemir


Fix installation instructions for Ubuntu

The previous url was incorrect and returns error while doing sudo apt-get update

Proposed changes
Fix repository path for Ubuntu installation instructions. The original instructions cause problems while performing sudo apt-get update
W: The repository 'https://apt.dockerproject.org/repo/pool xenial Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: Failed to fetch https://apt.dockerproject.org/repo/pool/dists/xenial/main/binary-amd64/Packages  403  Forbidden
E: Some index files failed to download. They have been ignored, or old ones used instead.

Unreleased project version (optional)

Related issues (optional)

Nvm, seems someone else already fixed it!


Unrecognized option "pagination" under "controller_extra"

Just copy and paste default config
controller_extra:
    resolver_priority: -8
    request: current
    factory:
        default_method: create
        default_static: true
    pagination:
        active: true
        default_name: paginator
        default_page: 1
        default_limit_per_page: 10
    entity:
        active: true
        default_name: entity
        default_persist: true
        default_mapping_fallback: false
    form:
        active: true
        default_name: form
    object_manager:
        active: true
        default_name: form
    flush:
        active: true
        default_manager: default
    json_response:
        active: true
        default_status: 200
        default_headers: []
    log:
        active: true
        default_level: info
        default_execute: pre

from documentation.

@danaki Have you installed the Bundle? :)

Of course.

Removing just 'pagination' from the config helps, but I want to disable pagination completely.

https://github.com/mmoreram/ControllerExtraBundle/blob/master/DependencyInjection/Configuration.php#L179
You're completely right. There is a huge issue in the documentation :(
Could you please include here a PR? I'll merge immediately!
Thanks for your feedback and encounter :D

Done! :)


Copy task support for symlinks

fixed #662
Add support to use symbolic links in copy tasks

Hi @maddin2016, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@maddin2016, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@dotnet-bot test this please

@maddin2016 Looks like the test failure is related:
MESSAGE:
Assert.Equal() Failure\r\n ↓ (pos 9)\r\nExpected: This is a source temp file.\r\nActual: This is another source temp file.\r\n ↑ (pos 9)
+++++++++++++++++++
STACK TRACE:
at Microsoft.Build.UnitTests.CopySymbolicLink_Tests.CopyToDestinationFolderWithSymbolicLinkCheck() in D:\j\workspace\_Windows_NT_p---ab87db35\src\XMakeTasks\UnitTests\Copy_Tests.cs:line 2232

Pretty sure the test is failing because the CI user doesn't have admin/SECreateSymbolicLinkPrivilege rights. We need to handle that case gracefully. But I'm not sure what the right way is--we definitely want to be able to pass tests when running as a normal user, but we also don't want to let symlinks get silently broken just because we're all low-priv users and only test that way. Do you have any thoughts on that?

Maybe we should check for error 80070522 and let this test fail with an error message that these test has to be run with higher privileges.

it's a little bit tricky, but whatever :sweat_smile:
var needHigherPrivileges = me.Log.Contains("0x80070522");

if (needHigherPrivileges)
         Assert.False(needHigherPrivileges, "It seems that you don't have the permission to create symbolic links. Try to run this test again with higher privileges");

Hi @rainersigwald. Are there any updates on this?

Sorry for the delay. I'm ok with explicitly checking for that HRESULT--but the action taken if you see it should be that the test passes. I think that's the best we can do without Assert.Inconclusive. Please reference #763 in a comment around this code and the commit itself so we know we can remove this workaround once we have a better solution.
If we're just looking through the log for the HRESULT, the cross-platform implications should be minimal, which is nice.
Can you also please add a test case that checks for the MSB3891 error when both hard- and symlinks are requested?
This is looking good!

Hi @rainersigwald, is  what you mean with test passes.

Oops :see_no_evil: wrong button

Hi @rainersigwald. Any updates on this?

Sorry about the delay! I think a couple of minor tweaks are all that's left.
@Microsoft/msbuild-maintainers can someone else take a look?

Sounds good. I will fix your comments ASAP

Thanks again for the contribution! LGTM pending some what @cdmihai wanted and you need to rebase/squash your commits before we merge please.

Looks good to go, after:

you set high verbosity when both hard / sym links could not be made
rebase on top of master. Apparently there are some conflicts
CI passes

Again @rainersigwald and @cdmihai many thanks for your help!!

Looks like the failing test might be related to your changes

mmhh, on my local machine all tests passes :confused:

@dotnet-bot test this please

@maddin2016 The CI test runs most likely do not run elevated. Can you check that case locally too?

Hi @cdmihai, the tests locally on my machine runs elevated. I will test this without elevated privileges. But since my last update from master branch there are many tests which are failing. :confused: So i have to look whats going wrong here.

@dotnet-bot test this please

All these failing tests have the same error message. But myaybe it's a problem locally on my machine.

@maddin2016 That looks like something may have mis-merged with #776, that introduced BuildEnvironmentHelperSingleton? Can you get a callstack of the type initialization failure?

Hi @rainersigwald, i got two different failures on two different machines. At one machine which i usually use all the time i get the following error
Testname:	Microsoft.Build.UnitTests.BackEnd.TaskRegistry_Tests.RetrieveFromCacheMatchingTaskDoesNotExist_FuzzyMatch
Test FullName:	Microsoft.Build.UnitTests.BackEnd.TaskRegistry_Tests.RetrieveFromCacheMatchingTaskDoesNotExist_FuzzyMatch
Testquelle:	C:\Users\scholzmartin\Documents\GitHub\msbuild\src\XMakeBuildEngine\UnitTests\BackEnd\TaskRegistry_Tests.cs Zeile 510
Testergebnis:	Fehlgeschlagene
Testdauer:	0:00:00,001

Ergebnis StackTrace:
----- Inner Stack Trace #1 (System.Exception) -----
   bei Microsoft.Build.UnitTests.BackEnd.TaskAssemblyFixture.GetTestTaskAssemblyLocation() in C:\Users\scholzmartin\Documents\GitHub\msbuild\src\XMakeBuildEngine\UnitTests\BackEnd\TaskRegistry_Tests.cs:Zeile 112.
   bei Microsoft.Build.UnitTests.BackEnd.TaskAssemblyFixture..ctor() in C:\Users\scholzmartin\Documents\GitHub\msbuild\src\XMakeBuildEngine\UnitTests\BackEnd\TaskRegistry_Tests.cs:Zeile 38.
----- Inner Stack Trace #2 (Xunit.Sdk.TestClassException) -----
Ergebnis Meldung:
System.AggregateException : Mindestens ein Fehler ist aufgetreten.
---- System.Exception : CSC task failed creating custom task:
---- The following constructor parameters did not have matching fixture data: TaskAssemblyFixture fixture

So all that backend tests fail. Plus some other escape tests
Testname:	Microsoft.Build.UnitTests.EscapingInProjects_Tests.FullProjectsUsingMicrosoftCommonTargets.DollarSignInAssemblyName_UsingTaskHost
Test FullName:	Microsoft.Build.UnitTests.EscapingInProjects_Tests.FullProjectsUsingMicrosoftCommonTargets.DollarSignInAssemblyName_UsingTaskHost
Testquelle:	C:\Users\scholzmartin\Documents\GitHub\msbuild\src\XMakeBuildEngine\UnitTests\EscapingInProjects_Tests.cs Zeile 1186
Testergebnis:	Fehlgeschlagene
Testdauer:	0:00:00,074

Ergebnis StackTrace:
bei Xunit.Assert.True(Nullable`1 condition, String userMessage) in C:\BuildAgent\work\cb37e9acf085d108\src\xunit.assert\Asserts\BooleanAsserts.cs:Zeile 90.
   bei Xunit.Assert.True(Boolean condition) in C:\BuildAgent\work\cb37e9acf085d108\src\xunit.assert\Asserts\BooleanAsserts.cs:Zeile 57.
   bei Microsoft.Build.UnitTests.ObjectModelHelpers.BuildTempProjectFileWithTargetsExpectSuccess(String projectFileRelativePath, String[] targets, IDictionary`2 additionalProperties) in C:\Users\scholzmartin\Documents\GitHub\msbuild\src\Shared\UnitTests\ObjectModelHelpers.cs:Zeile 791.
   bei Microsoft.Build.UnitTests.ObjectModelHelpers.BuildTempProjectFileExpectSuccess(String projectFileRelativePath) in C:\Users\scholzmartin\Documents\GitHub\msbuild\src\Shared\UnitTests\ObjectModelHelpers.cs:Zeile 780.
   bei Microsoft.Build.UnitTests.EscapingInProjects_Tests.FullProjectsUsingMicrosoftCommonTargets.DollarSignInAssemblyName_UsingTaskHost() in C:\Users\scholzmartin\Documents\GitHub\msbuild\src\XMakeBuildEngine\UnitTests\EscapingInProjects_Tests.cs:Zeile 1228.
Ergebnis Meldung:
Assert.True() Failure
Expected: True
Actual:   False

And on the other machine i got that failure below. I send the trace later. But to come back to the originally question from @cdmihai.

The CI test runs most likely do not run elevated. Can you please check that case locally too?

Yes, if i run the test not elevated, it fails for me too.

@maddin2016 Ah, I see that same failure when running tests in Visual Studio--but not on the command line. Can you try running RebuildWithLocalMSBuild.cmd from both elevated and unelevated command prompts to try to repro the test failure?

yeah, RebuildWithLocalMSBuild.cmd works fine. From not elevated command prompt that unit test fail and with elevated command prompt it passes.

One more thing, i have to install .net 3.5 to run successfully. Is that right?

@maddin2016 Yes, 3.5 is required for a full test pass. We have special functionality (MSBuildTaskHost) to support it that is tested.
It's interesting that the test fails and doesn't fall into the detect-error condition you put in. Maybe explicitly check for SECreateSymbolicLinkPrivilege and early exit if not present?

Hi @rainersigwald, thats because it throws another error
{System.Runtime.InteropServices.COMException (0x800703F0): Es wurde versucht, auf ein Token zuzugreifen, das nicht vorhanden ist. (Ausnahme von HRESULT: 0x800703F0)

???

Hi @rainersigwald, in my last commit i have add a method to check for SECreateSymbolicLinkPrivilege.
Thanks to this post. Is there any easier way? If not, where we can place this. Under NativeMethods?

Yikes, that is ugly. But it's the pedantically correct thing to do. It would be cleaner to just use principal.IsInRole(WindowsBuiltInRole.Administrator)--but less correct. If Windows ever joins the rest of the world in allowing symlink creation as a normal user, I think this code will just Do The Right Thing.
My instinct is to say to do it this way (since you already figured it out!) and leave the code in the test since it's only used there. @cdmihai @AndyGerlicher thoughts?

LGTM. On minor nit, can you please extract out the permission checking code outside of the unit test method? That will allow other potential symlink tests from that file to reuse it, and it will make the intent of the actual test more clear.
Beyond that, looks ready to merge.

can you please extract out the permission checking code outside of the unit test method?
Into Copy_Tests.cs or some where else?

@maddin2016 I think a separate method in this file is fine. If we start using it elsewhere we can move it to a common place.

LGTM

Thank you @maddin2016 for your contribution!

Thank you @maddin2016! 🎉

:tada: :+1:

What i though want to ask, what is to do for the xplat branch? Should i create a new request? And how you test on mac, because i don't have one.

@maddin2016 It would be fantastic if you could merge f71174c into xplat and submit a PR--though you need to be aware of #922 which will need to go in first.
If you can get it to work on Linux, one of us can test on our Macs to help with the final stretch.

That sounds good. To make it clearly to me. I merge f71174c into xplat. Wait for #922 to be merged, and then begin to work on this and submit a PR. Is this correct?

I'd wait for #922 first, then merge, work, submit. And please submit the PR early (even when it's not working/done), so we know you're working on it.

Also just so you're aware I filed #928. This change unfortunately breaks all Xamarin iOS (at least) targets. No idea if this would be more widespread or not (overriding our Copy task wouldn't really be a recommended thing to do!). There's a potential of having to back out this change in master since we're inserting into VS and don't want to break that scenario. Just a heads up.

No good news :hushed:


Fix unsubscribing resize event listener

Ah wow. What an oversight! Thanks a lot for spotting it 🙏
Fix was just released in v2.0.4


build error

Hello I constantly get the following error while build in latest version,
> Configure project :react-native-appearance WARNING: API 'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'. It will be removed at the end of 2019. For more information, see https://d.android.com/r/tools/task-configuration-avoidance. To determine what is calling variant.getJavaCompile(), use -Pandroid.debug.obsoleteApi=true on the command line to display more information.

It's a warning not an error. But yes.

hi @solace
This problem still happened to me in Version: 0.3.3


Fix misleading README files.

Fix a bad link and references to files that don't exist.
This was reported by someone trying to follow the directions and getting stuck.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [geeknoid,gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


updated gradle to latest 7.4, added slf4j logging JARs

super old Gradle version, now at current 7.4
updated build script to issue Java warnings on compile

Hey @gvensan , please just build this and make sure it runs.  I tested with the basic topic pubs and subs to my local broker.  Remember you need to specify amqp://localhost in your connection string.

Hey @gvensan , please just build this and make sure it runs. I tested with the basic topic pubs and subs to my local broker. Remember you need to specify amqp://localhost in your connection string.

@aaron-613 , tested all the samples - works fine!!

Merged since @gvensan tested. @gvensan in the future when you review something like this feel free to merge (I think you have permissions?). Or if you don't have permissions then at least "approve" it via the github review functionality.


add dependabot config

Inspired by https://github.com/kubeflow/pipelines/issues/4682  I created a script that will create a config file for depandabot so that it knows what directories to scan. It will scan the repository for files named *ockerfile*, package*.json, *requirements.txt and go.*.  It is setup for dockerfiles, npm packages, pip dependencies and gomod at the moment. It is trivial to further customize what folders are selected if further customization is needed. It also parses the closest OWNERS file for a given dependency listing file, and assigns the relevant approvers and adds the relevant reviewers to the PRs it creates.
This is a sibling PR to https://github.com/kubeflow/pipelines/pull/5015, https://github.com/kubeflow/kubeflow/pull/5542, https://github.com/kubeflow/kfserving/pull/1309, https://github.com/kubeflow/arena/pull/403, https://github.com/kubeflow/testing/pull/855, https://github.com/kubeflow/fairing/pull/550, https://github.com/kubeflow/kfp-tekton/pull/432, https://github.com/kubeflow/katib/pull/1420 and https://github.com/kubeflow/tf-operator/pull/1224.
As it stands now, I am not yet sure how many PRs will be created with this configuration, as dependabot has not yet started scanning my fork.
For reference, the PRs that will be created can be found here: https://github.com/DavidSpek/kfp-tekton-backend/pulls

/assign @animeshsingh

/assign @animeshsingh

I am holding the PR to have some control over when it gets merged so that the optional test infra doesn't get overloaded if all the repo's were to merge this at the same time.
/hold

I am holding the PR to have some control over when it gets merged so that the optional test infra doesn't get overloaded if all the repo's were to merge this at the same time.
/hold


Replace "bionano" with "lifesciences" for links, emails, etc

Team name in email text should also be changed. BioNano Research Group to Lifesciences Group


Add License

Hello,
I would like to fork this codebase to make a set of Tracy bindings with various improvements and breaking changes planned. However the codebase has no license so it is all rights reserved.
Could you consider licensing it under a permissive license like MIT, or Apache or the Unlicense.
Thanks!

There we go, added a license.


infowindow does not close in google chrome

When you click on the x inside the infowindow using google chrome, infowindow does not close.  Wondering if anyone else is having this issue.
works in firefox and safari
Thanks

Any further detail on this? should I close it?


Correction for raw affiliation Population Health Intervention Research Centre, University of Calgary, Alberta, Canada<EMAIL_ADDRESS>

Correction needed for raw affiliation Population Health Intervention Research Centre, University of Calgary, Alberta, Canada<EMAIL_ADDRESS>raw_affiliation_name: Population Health Intervention Research Centre, University of Calgary, Alberta, Canada<EMAIL_ADDRESS>new_rors: 03yjb2x39
previous_rors:
works_examples: W2131314112
contact: c82ddc9832aaed3649d46ce51caa81b5:2f6d65ef @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.