Staging environment setup

Problems
There's no way to test out a new feature until it gets merged to the main branch right now.
How to solve

[x] Install Ubiquibot[dev] on bounty-bot repository
[x] Create another netlify function connected to the development branch
[x] Update webhook url on dev app settings.

This is not an ideal setup but we can make sure new features working at least before pushing it to production.

Update webhook url on dev app settings.

I moved UbiquiBot[dev] to Ubiquity and updated the webhook to https://ubiquibot-staging.netlify.app/.netlify/functions/webhooks

However I disagree with this approach for staging. Its best if we allow bounty hunters to fork the repository and we use their repositories for automatic staging environments. Its great to clearly test things per instance if we have several bounty hunters working on the bot at the same time.

lol two permits

 [ CLAIM 400 DAI ]
0xf39fd6e5...ffb92266

What's the procedure to spin up these staging environments,
assuming I'd have 2-3 branches on my fork at a time working on different issues.

What's the procedure to spin up these staging environments, assuming I'd have 2-3 branches on my fork at a time working on different issues.

@0xcodercrane

I apologize for my late response guys. there's no specific procedure for staging environments.
1/ Install Ubiquibot[dev] into your repository.
2/ Create a PR into ubiquity:development branch for your work
3/ Merge it once approved
4/ You can test out the feature by creating test-purpose issues on your forked repository, no mather whatever the branch is

I still think that we should allow developers to fork and run the bot from their own forks (via GitHub Actions as it was formerly implemented) to use each fork (and branch) as staging.

It will repro complexities to developers as we've already experienced in the first integration.

Here's a list of complexity items that I'm thinking of so far.
To run via Github Actions on a forked repo, developers should set up env variables. they're
1/ appId and privateKey of ubiquibot[dev] (They can also create an app themselves but they wouldn't do that because its kind of tedious stuff from my experience)
2/ If they have to use ubiquibot[dev] on forked repos, we should let them know env variables we set in our staging repo. I will follow up on your decision on it @pavlovcik

I apologize for my late response guys. there's no specific procedure for staging environments.
1/ Install Ubiquibot[dev] into your repository. 2/ Create a PR into ubiquity:development branch for your work 3/ Merge it once approved 4/ You can test out the feature by creating test-purpose issues on your forked repository, no mather whatever the branch is

What I am thinking here is to make staging env working on the PR without merging (of course if it gets merged, the changes will def work)

Yes let's make dev bot all public/shared env for easy development. We just need to make its permissions close to 0 as possible.

I apologize for my late response guys. there's no specific procedure for staging environments.
1/ Install Ubiquibot[dev] into your repository. 2/ Create a PR into ubiquity:development branch for your work 3/ Merge it once approved 4/ You can test out the feature by creating test-purpose issues on your forked repository, no mather whatever the branch is

could u show me an example on your repo?
@0xcodercrane

I apologize for my late response guys. there's no specific procedure for staging environments.
1/ Install Ubiquibot[dev] into your repository. 2/ Create a PR into ubiquity:development branch for your work 3/ Merge it once approved 4/ You can test out the feature by creating test-purpose issues on your forked repository, no mather whatever the branch is

could u show me an example on your repo? @0xcodercrane

I noticed that @0xcodercrane doesn't check GitHub notifications much lately so I highly recommend you follow up on Telegram as well.

https://github.com/0xcodercrane/bounty-bot/issues/1
created an example by forking. please go through the above issue and let me know if you have more questions @Steveantor  @pavlovcik


Can't connect acount - Error 500

Q
A

Bug report?
[ x ]

Feature request?
[ ]

Support request?
[ ]

hi,
I wanted to change the time zone in php.ini and now when I want to login with an account, I have an error in the logs, someone knows how to fix that?
My log :

[2018-04-26 11:46:35] request.INFO: Matched route "cocorico_home". {"route_parameters":{"_controller":"Cocorico\CoreBundle\Controller\Frontend\HomeController::indexAction","_locale":"fr","_route":"cocorico_home"},"request_uri":"https://dev.myd.fr/fr/"} []
[2018-04-26 11:46:35] security.DEBUG: Read existing security token from the session. {"key":"_security_frontend"} []
[2018-04-26 11:46:35] security.DEBUG: User was reloaded from a user provider. {"username":"kaiosama@hotmail.fr","provider":"Cocorico\UserBundle\Model\UserManager"} []
[2018-04-26 11:46:35] request.CRITICAL: Uncaught PHP Exception Twig_Error_Runtime: "An exception has been thrown during the rendering of a template ("An exception occurred while executing 'SELECT t0.id AS id_1, t0.type AS type_2, t0.address AS address_3, t0.city AS city_4, t0.zip AS zip_5, t0.country AS country_6, t0.createdAt AS createdAt_7, t0.updatedAt AS updatedAt_8, t0.user_id AS user_id_9 FROM user_address t0 WHERE t0.user_id = ?' with params [1066487349]:  SQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.type' in 'field list'") in<EMAIL_ADDRESS>at line 20." at /var/www/dev/cocorico/app/cache/prod/classes.php line 5442 {"exception":"[object] (Twig_Error_Runtime(code: 0): An exception has been thrown during the rendering of a template ("An exception occurred while executing 'SELECT t0.id AS id_1, t0.type AS type_2, t0.address AS address_3, t0.city AS city_4, t0.zip AS zip_5, t0.country AS country_6, t0.createdAt AS createdAt_7, t0.updatedAt AS updatedAt_8, t0.user_id AS user_id_9 FROM user_address t0 WHERE t0.user_id = ?' with params [1066487349]:\n\nSQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.type' in 'field list'") in<EMAIL_ADDRESS>at line 20. at /var/www/dev/cocorico/app/cache/prod/classes.php:5442, Doctrine\DBAL\Exception\InvalidFieldNameException(code: 0): An exception occurred while executing 'SELECT t0.id AS id_1, t0.type AS type_2, t0.address AS address_3, t0.city AS city_4, t0.zip AS zip_5, t0.country AS country_6, t0.createdAt AS createdAt_7, t0.updatedAt AS updatedAt_8, t0.user_id AS user_id_9 FROM user_address t0 WHERE t0.user_id = ?' with params [1066487349]:\n\nSQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.type' in 'field list' at /var/www/dev/cocorico/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:71, Doctrine\DBAL\Driver\PDOException(code: 42S22): SQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.type' in 'field list' at /var/www/dev/cocorico/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:93, PDOException(code: 42S22): SQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.type' in 'field list' at /var/www/dev/cocorico/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:91)"} []
[2018-04-26 11:46:35] security.DEBUG: Stored the security token in the session. {"key":"_security_frontend"} []

I purged the bdd is apparently it works again


Update tutorial-power-bi-key-phrases.md

@LuisCabrer Hello, I have been tasked with Microsoft vendor Aquent to fix/remove broken links.  Try F# appears to no longer be active so I linked to Microsoft Docs F# instead.  Please advise.

@msebolt : Thanks for your contribution! The author, @luiscabrer, has been notified to review your proposed change.


build: Scripts to manage release process

Added the scripts that we must run to publish a new release.

npm run release:dev:patch -> To publish dev releases in PRs
npm run release:main:patch -> To publish stable releases in main.

Updated the CONTRIBUTING.md explaining this development flow.

Loom: Development overview - basically I do the steps written in the CONTRIBUTING file.
Loom: scripts walkthrough - a detailed overview of the scripts created.

Important:

DO NOT test it in this repo, otherwise you'll publish unwanted versions. Use https://github.com/remoteoss/test-pkg-npm instead.
Before you test, please copy the scripts/release* from here to there, to ensure you have the latest updates.

i'm happy with the steps as our first iteration, there is a lot of manual work - but this is ok for now. I will recheck later when its rebased. @johnstonbl01 defo will appreciate your eyes here too

I think there's a lot of opportunities here to automate some of this away, but for now having the manual processes is fine. 👍 Looks good to me, Sandrina!


How to Fill request Parameters without using postman?

Hi, how to put all request parameters in laravel to get the access token without using the postman plugin? is there any method that I can use to check the request parameters? thanks! :D

Thanks for using this package!
For this kind of support questions, we'd like you to use the following resources:

Documentation
OAuth 2.0 Documentation
Laracasts
Laravel Slack
Stack Overflow

This will allow us to keep the issues for bug reporting only and make our work easier.


Allow API filter to perform integer comparisons

Expected Behavior
The enhancement allowing filtering of responses has been very helpful to us, allowing us to filter events on the API response that aren't currently silenced.
Would it be possible to extend that filter ability to support comparisons for attributes that are numerical - e.g. /events?filter.silenced=false&filter.occurrences<3&filter.duration<10
Current Behavior
Currently API filter matches only based text match, no comparisons are supported.  It works well for text matches like "silenced", but not for filtering based on any numerical value like occurrences, duration, timestamp, or last_ok.
Context
We are using a status system that checks the event API for existing events (pulling from Sensu API endpoint).  Because events are triggered on the first occurrence and we are querying the API rather than Sensu executing a handler (where we could implement handler filters), it would be helpful to have the ability have enhanced filtering on the API response based on attributes that are integers.

In order to achieve this, we need a method to inspect every filter param value to determine if it is an integer. We could do this, the performance impact should be minimal.


(de)serialize attribute.sort properly

fix for #274

Hm, apparently "fix for" doesn't close corresponding issue.


Error in importing batanalysis

I followed the installation instructions in GitHub.
git clone https://github.com/parsotat/BatAnalysis.git
cd BatAnalysis/
pip install -e .
This worked fine.
When I try to run a notebook, the following error pops up. The issue arises when trying to import bat analysis as BA. It says CALDB has not been installed or initialized. I am using the CALDB for remote access. This is working fine on my computer for NICER and SWIFT XRT. Could anyone help me with this?
I got this in the notebook when I ran the os.environ["CALDB"] command. It may help you figure out the issue.
os.environ["CALDB"]

'https://heasarc.gsfc.nasa.gov/FTP/caldb'

AttributeError
Cell In [8], line 4
2 import os
3 import sys
----> 4 import batanalysis as ba
5 import matplotlib.pyplot as plt
6 import numpy as np
File ~/xray_analysis/sibasish/swift/bat_obs/BatAnalysis/batanalysis/init.py:21
15     raise EnvironmentError('CALDB does not seem to be initialized/installed. '
16                            'BatAnalysis cannot be imported without this.')

can you uninstall BatAnalysis with pip uninstall BatAnalysis and then try to install from pypi with pip install BatAnalysis? I expect the error will be the same, but I would like to verify that first.

It still shows the same error.  To inform you, I tried in the sciserver the same way, it worked fine. I could import batanalysis without any issues.

the other thing that I would like to try is to start an ipython session and try to import BatAnalysis within there. If you do that, does it import without any issues?

The same error popped up!

Below is the printout.
'https://heasarc.gsfc.nasa.gov/FTP/caldb'

Something strange is going on with the bash environment. can you run your heainit script in the terminal and then retry the ipython steps above, in that same terminal?

Again, the same error popped up!

another thing to try is to download an observation and try to run HEASOFT's batsurvey on it. this will help us determine if this is an heasoft environment issue that is occurring elsewhere or something wrong with the code itself.

the issue was related to a different package not being imported and throwing an error.


Add cask for sequel-pro 1.1-RC2 and update sequel-pro-nightly

Sequel Pro 1.1-RC2 released for some important bug fix in El Capitan,
like sequelpro/sequelpro#2050, and I think user will like to install this
version instead the stable version if they already tap this casks.

In the future, please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.
In this case, sequel-pro is already present in the main repo. You need to remove it.

@vitorgalvao
OK, I will separate this PR later.
But can I update sequel-pro in the main repo even it's a RC release, not a stable release?

Since it is an important fix, yes, no sense in having a new cask for a temporary fix.

Hi @vitorgalvao, I re-push it with change Casks/sequel-pro-nightly.rb only, please check it.


Multiple gauge entries for replset members

This is to fix the issue #50
StateStr is not a fixed value and so should not be part of the label for member gauges. Otherwise it leads to duplicate gauge entries when a member changes state (from/to primary/secondary/unreachable) and it is impossible to tell in the /metrics endpoint which of the duplicates is the correct/current value.
I have removed StateStr from the label.

@dcu

closes #51


rclone: Remove password from url in log

The log currently shows something like:
[INFO] repository<EMAIL_ADDRESS>password is correct.

The password should be removed from the log.

AFAIK, rclone isn't used for REST server, is it ?


advice for reading live events

Hi, I am new to rust and wonder if you have any examples for reading windows event logs on a live system.  And of course thanks for making this fast library!

You can use standard windows tooling for this https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.diagnostics/get-winevent?view=powershell-7.1.


feat(plugin): add eslint-plugin-lob

What & Why
Add the Lob eslint plugin to the config to star enforcing the custom rules. I'm not 100% sure that this is the way to implement the plugin, but using npm link doesn't seem to be working for me for other reasons. I want to try to publish this and try using it in our repos to see if it works as expected.
I finally got npm link to work thanks to @mgartner and @elnaz and found a separate issue with the config. Added a commit for that. After that fix, the plugin works just fine 👍

I would love to take credit, but I think it was all @elnaz.
 _     ____ _____ __  __
| |   / ___|_   _|  \/  |
| |  | |  _  | | | |\/| |
| |__| |_| | | | | |  | |
|_____\____| |_| |_|  |_|

LGTM

LGTM


VS Code blinking on VMWare macOS

Example: https://youtu.be/_cJAXvYl6xY

VSCode Version: 1.14
OS Version: macOS 10.12.5

Steps to Reproduce:

Download from https://code.visualstudio.com/
Run on VMWare virtual machine with macOS

Reproduces without extensions: Yes

Does it reproduce if you run "code --disable-gpu"?

No, ./Electron --disable-gpu didn't help.


Dart aot compilation time

For some reason.
void main() {
	print("Hello World");
}

hyperfine 'dart compile exe -o main main.dart'

Benchmark 1: dart compile exe -o main main.dart
  Time (mean ± σ):      1.219 s ±  0.022 s    [User: 1.155 s, System: 0.118 s]
  Range (min … max):    1.203 s …  1.282 s    10 runs

can anybody explain why is it taking 1.15 seconds to compile a hello world? this is a big problem i guess, is there any work in progress to improve this?

can anybody explain why is it taking 1.15 seconds to compile a hello world?

It needs to do global analysis of all Dart code involved (it is more than you see - because Dart core library is written in Dart), then it needs to compile it. Some compiled code is not strictly necessary for hello-world style program, but is still compiled because of how our runtime system and core libraries are entangled. Some passes are implemented in Dart and there is some serialization - deserialization as well as process spawning overheads involved. So baseline costs might be higher than necessary.
For comparison compiling a program which has 5KLOC takes ~2s and compiling program which has ~150KLOC takes around ~20s.

is there any work in progress to improve this?

Yes and no. First of all we don't really care about how fast "hello world" can be compiled.
For real world compilations we are always looking for low hanging fruits to cut here and there - but I think by now we have collected most of them.
We have looked at how to parallelize some of the phases of compilation - but this work is going with low priority right now.
I am also fairly certain that we can get certain amount of improvements when compiling in a single thread - but these improvements would require significant changes, and we don't have capacity for that right now.
If you have some concrete issues - please file them, we are happy to take a look.


[SPARK-47790][BUILD] Upgrade commons-io to 2.16.1

What changes were proposed in this pull request?
This PR aims to upgrade commons-io to 2.16.1.
Why are the changes needed?
2.16.1 is a maintenance release after 2.16.0.

https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1 (2024-04-04)

Does this PR introduce any user-facing change?
Yes, this is a dependency change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master. Thank you, @yaooqinn !


version `GLIBC_2.15' not found

Hello,
I wanted to play with my friends private on a own server, but my friend own a VPS with debian. I installed it according to instructions, but when i start the server, this show up.
Please help, thanks

Not a Rocket Bug.

Then what bug?


Rework the Onboarding Slide Deck After the new Site Content is Released

Describe the Issue
Currently we have a lot of content in the slide deck that could be documentation stored elsewhere, but is still vital for oncoming teams to know. Soon the new site content will be released and we will be able to remove a lot of the technical aspects of the slide deck. This will allow us to onboard more teams as the onboarding sessions will be shorter and more of the information will be documented on our website.
Additional Context

We should only do this ticket's work after the site is live
Onboarding should include topics like

Shared responsibility
Commitment to paying invoices
How to get help

Contact us page
Community meetups
AWS onramp support

Talking about that team's specific architecture
Sample applications

Acceptance Criteria

Speak to Shelly H from the Private Cloud Team about their onboarding experience
Remove slides from the onboarding deck that have duplicated or similar information available in the site content.

.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Closing as this has already been completed


Suggestion: Penalty for Civilian Killing

How about increasing the production time for producing resources a small amount each time a civilian is killed by BLUE forces.  This would simulate the people becoming unhappy due to deaths.
Early in the campaign it would not hurt very much but as time goes by and more civs die and production times climb it could make things interesting.
Might even have a side mission to like deliver supplies to a town to lower production times a little.

Killing Civilians etc. will have much more influence in a more immersive way at 0.96.
You'll have a reputation system which will be affected by your actions.
https://forums.bistudio.com/forums/topic/202711-mpcti-coop-liberation-continued/?do=findComment&comment=3201375

Great!! Can't wait!!!!


2 tabs not working

specifically "Cylinder Head" and "Distributor"

what do you mean by "they dont work"
send a screenshot/screen recording if you can

stuck in a loading screen and i dont know how to read the console.
anyways heres the screenshot

they should work but, if you have used enginette before 0.0.4 you need to clear the database
you can do that by pressing F12 then >>Application

and then IndexedDB>enginette>delete database

thanks


How does the open source large language model api interface interact with SalesGPT

About how to interact with SalesGPT by using the open source large language model API interface defined and packaged by yourself

@luolin-ai this is done! Check the latest PR merge :)


[NSE-473]Optimize ArrowColumnarToRow performance

What changes were proposed in this pull request?

Use the DirectBuffer to allocate and release memory in java side to reduce the memory footprint.
Optimize the native side convert logic with converting by column and not row by row
Code clean.

How was this patch tested?
existing tests

@JkSelf thanks for the continuing efforts!

Closed #473


Custom switch definition list ordering

Hey,
I wanted to add a few switches for res <=> req and request <=> response and did so via appending them to g:switch_custom_definitions:
let switch_custom_definitions =
	\ [
	\ 	["request", "response"],
	\ 	["req", "res"]
	\ ]

However, it turns out the shortest match wins, so request turns to resuest.
I was of course able to rewrite it via the dict mechanism and added a few \> in there for good measure, but how about respecting the order of those custom definitions so such common subset cases could be handled without more verbose regexps? Especially when each individual switch list does respect order. :)

Hey again,
I keep on getting hit by this. Now with pre <=> post and previous <=> next when trying to switch between DOM's previousSibling and nextSibling. A side note: those happen to be great examples of why switching mid-word isn't bad.
Coming back to what you said before, my gut tells me that being clever with the length of the match isn't a sustainable solution. Matchers are fundamentally interdependent to each other. They're also so context dependent.
For example, I just had to wrap \< and \> around my on <=> off switches for them to not interfere with describe <=> describe.only (as I often jump to that location with /only in Vim). Not a big problem in this case as on/off are rarely prefixes in code (unlike "previous" above) but an example of how a generic shorter switch interfered with one I considered a more specific one nonetheless. Same given a switch if <=> unless being less specific as one switching between if (...) if (!(...)).
I'd say a simple linear testing for matches is a lot simpler to comprehend. Should I then end up with interdependent alternatives (e.g one switch's n-th array element is the same as another's first) I'll start thinking about negative look-aheads. Until then, I'll just pile (sub)word pairs linearly.
I don't know about the built-in switches as I don't really use them beyond true <=> false. They don't even have to be bundled in. This is Vim after all. To each his own config. ^_^

I've pushed a setting called g:switch_find_smallest_match. Set that to 0 and the plugin will simply run through the matches in order and perform the first one. If you don't care about the built-ins, you can also set g:switch_no_builtins to 1 and you can build your own definitions.
Let me know if this works for you.

Awesome. Thanks, Andrew! Trying it now.

Seems to work beautifully! Thanks!
I'll let you know when I stumble upon harder cases that can't be solved by this.
Big ups on working on Switch.vim, too! One of the most useful plugins for me.


Save Resultant Video Option

Hi,
Thank you for awesome implementation. I was wondering how can we save the resultant video ? which files should i modify for this ?

Thank you for your kind words.
The display is refreshed starting on line 300 of ControllerThread.py. You can try saving the most recent frame (in numpy array frame) after these lines:
        cv2.imshow(self.caption, frame)
        key = cv2.waitKey(10)

        if key == 27:
             self.terminate()

Either save individual frames as jpeg's and pull them together by ffmpeg; or initialize a opencv VideoCapture object and save directly to a video file.
Alternatively, just record the screen using a screen capture software. I've used VokoScreen to create some demo videos of this.


[#595] feat(actions): add superfly/flyctl-actions@v1

See also: https://github.com/superfly/flyctl-actions/issues/33

Thanks @madhead!


County Embeds

Available at /embed/us/county/53033 or /embed/us/wa/county/king_county
EMBED share link works on county pages.
embed.js updated to accept data-fips-id widgets.

We should fix this rounding issue in this pr as well

County state header, state url links to non embed version. Should be updated to go to embed/us/state if state is clicked on

Hah, good call.  Will do.


Option to NOT override user's no-sound / no-vibrate setting

Users are unhappy that their phone vibrates on alarms, when they've set them not to.
I'd like an option to observe the phone's settings for sound and vibration.
I've considered forking the package, but realised that I have no ability in native android or ios programming.

Hi @ApplySci
Unfortunately, for privacy reasons there is no iOS public API to know whether user has enabled silent mode or not.
I'll keep this issue open in the case I find a workaround. If you wish to contribute you can probably write some code thanks to chatGPT or Copilot.


grammar formatter deletes code

Langium version: 1.0.1
Package name:
Steps To Reproduce

Put the following in a .langium file. Note the missing semi colon for the Param line:grammar Code

Param: name=ID

hidden terminal WS: /\s+/;
terminal ID: /[_a-zA-Z][\w_]*/;

Run Lagium formatter in VS Code. It removes content, resulting in:grammar Code

Param: name=ID

hidden terminal WS
terminal ID: /[_a-zA-Z][\w_]*/;

Link to code example:
https://langium.org/playground?grammar=OYJwhgthYgBAwgewCYFMBQ6AKNIC5YA7SVAXgEkARTACwEtk1DYAXVECO4gG1gHUAygQD0AHQDOAamEBudGw5cwvKiIDaAfTABaAF4BBbQC0AumtEB3DSYBUsoA&content=Q

The current behavior
Strips content.
The expected behavior
No formatting if there's a syntax error, or something more advanced like it inserts a semi or something.

@trusktr I'll take a look at this later today when I get a moment 👍 .

There's something up with the grammar-formatter when an unterminated parser rule is followed by a terminal, and then any other terminal/parser rule. It needs more looking into, but this should make a nice formatting test case to base off of, and we can go from there to work in a fix.


Data recovery problem

Hello,
Here is my installation:
puppetboard => 0.3
pypuppuetdb => 3.3
puppetdb => 4.4.2
puppet => 4.8.2
Everything is installed on the same machine.
All the installations went well, the site is functional but no data is displayed in puppetboard.
In the logs, I have the following errors:
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_url called with endpoint: environments and path: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): localhost
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:http://localhost:8080 "GET /pdb/query/v4/environments HTTP/1.1" 200 27
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_query called with endpoint: nodes, path: None, query: ["extract",[["function","count"]],["and",["=", "catalog_environment", "puppetTest"],["=", "facts_environment", "puppetTest"]]], limit: None, offset: None, summarize_by None, count_by None, count_filter: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_url called with endpoint: nodes and path: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:http://localhost:8080 "GET /pdb/query/v4/nodes?query=%5B%22extract%22%2C%5B%5B%22function%22%2C%22count%22%5D%5D%2C%5B%22and%22%2C%5B%22%3D%22%2C+%22catalog_environment%22%2C+%22puppetTest%22%5D%2C%5B%22%3D%22%2C+%22facts_environment%22%2C+%22puppetTest%22%5D%5D%5D HTTP/1.1" 200 13
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_query called with endpoint: resources, path: None, query: ["extract",[["function","count"]],["=", "environment", "puppetTest"]], limit: None, offset: None, summarize_by None, count_by None, count_filter: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_url called with endpoint: resources and path: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:http://localhost:8080 "GET /pdb/query/v4/resources?query=%5B%22extract%22%2C%5B%5B%22function%22%2C%22count%22%5D%5D%2C%5B%22%3D%22%2C+%22environment%22%2C+%22puppetTest%22%5D%5D HTTP/1.1" 200 13
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_query called with endpoint: nodes, path: None, query: ["and",["=", "catalog_environment", "puppetTest"],["=", "facts_environment", "puppetTest"]], limit: None, offset: None, summarize_by None, count_by None, count_filter: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_url called with endpoint: nodes and path: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:http://localhost:8080 "GET /pdb/query/v4/nodes?query=%5B%22and%22%2C%5B%22%3D%22%2C+%22catalog_environment%22%2C+%22puppetTest%22%5D%2C%5B%22%3D%22%2C+%22facts_environment%22%2C+%22puppetTest%22%5D%5D HTTP/1.1" 200 2
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_query called with endpoint: event-counts, path: None, query: ["=", "latest_report?", true], limit: None, offset: None, summarize_by certname, count_by None, count_filter: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:pypuppetdb.api:_url called with endpoint: event-counts and path: None
[wsgi:error] [pid 16827] [client IP_Client:59899] DEBUG:urllib3.connectionpool:http://localhost:8080 "GET /pdb/query/v4/event-counts?query=%5B%22%3D%22%2C+%22latest_report%3F%22%2C+true%5D&summarize_by=certname HTTP/1.1" 200 2
when I try with "curl", the result seems to me coherent.
Thank you for your help

Closing as outdated. Please reopen if you still experience such problem with the current version of the Puppetboard.


OOM while loading THUDM/chatglm-6b-int4

I am trying this code to load THUDM/chatglm-6b-int4 on a single GPU:
llm = LLM(model=model_path, trust_remote_code=True)
However it raises an OOM exception:

Traceback (most recent call last):
File "demo_vllm.py", line 15, in
llm = LLM(model="chatglm-6b-int4",
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/entrypoints/llm.py", line 105, in init
self.llm_engine = LLMEngine.from_engine_args(engine_args)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/engine/llm_engine.py", line 250, in from_engine_args
engine = cls(*engine_configs,
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/engine/llm_engine.py", line 110, in init
self._init_workers(distributed_init_method)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/engine/llm_engine.py", line 146, in _init_workers
self._run_workers(
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/engine/llm_engine.py", line 755, in _run_workers
self._run_workers_in_batch(workers, method, *args, **kwargs))
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/engine/llm_engine.py", line 729, in _run_workers_in_batch
output = executor(*args, **kwargs)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/worker/worker.py", line 79, in load_model
self.model_runner.load_model()
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/worker/model_runner.py", line 57, in load_model
self.model = get_model(self.model_config)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/model_loader.py", line 65, in get_model
model = model_class(model_config.hf_config, linear_method)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 333, in init
self.transformer = ChatGLMModel(config, linear_method)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 299, in init
self.encoder = GLMTransformer(config, linear_method)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 254, in init
[GLMBlock(config, linear_method) for i in range(self.num_layers)])
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 254, in
[GLMBlock(config, linear_method) for i in range(self.num_layers)])
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 196, in init
self.mlp = GLMMLP(config, linear_method)
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/models/chatglm.py", line 138, in init
self.dense_h_to_4h = MergedColumnParallelLinear(
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/layers/linear.py", line 256, in init
super().init(input_size, sum(output_sizes), bias, gather_output,
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/layers/linear.py", line 176, in init
self.linear_weights = self.linear_method.create_weights(
File "miniconda3/envs/vllm/lib/python3.9/site-packages/vllm/model_executor/layers/linear.py", line 55, in create_weights
weight = Parameter(torch.empty(output_size_per_partition,
File "miniconda3/envs/vllm/lib/python3.9/site-packages/torch/utils/_device.py", line 77, in torch_function
return func(*args, **kwargs)

torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 214.00 MiB. GPU 0 has a total capacty of 10.75 GiB of which 134.50 MiB is free. Including non-PyTorch memory, this process has 10.61 GiB memory in use. Of the allocated memory 10.29 GiB is allocated by PyTorch, and 1.39 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

I have tried https://github.com/vllm-project/vllm/issues/2176 and set gpu_memory_utilization, not work.
I also tried https://github.com/vllm-project/vllm/issues/1949 and set max_seq_len, not work.
I saw https://github.com/vllm-project/vllm/issues/2304, does it means that this situation is expected?

Note that I downgrade the transformers to 4.29.2 to avoid the tokenizer loading exception.

THUDM/chatglm-6b-int4 doesn't use AWQ or GPTQ for quantization and is not supported by vLLM.

THUDM/chatglm-6b-int4 doesn't use AWQ or GPTQ for quantization and is not supported by vLLM.

THX. Could I say vLLM only supports chatglm of full precision and that quantized by AWQ and GPTQ?

THUDM/chatglm-6b-int4 doesn't use AWQ or GPTQ for quantization and is not supported by vLLM.

THX. Could I say vLLM only supports chatglm of full precision and that quantized by AWQ and GPTQ?

Yes, except the support matrix of quantization also includes SqueezeLLM.

Closing this as vLLM currently only supports AWQ, GPTQ and SqueezeLLM for quantization.


Ignore broken Cargo.toml in git sources

Commit 3d6de4177489a5d450f35e92288512be85492678 (#3998) made cargo
ignore Cargo.toml files that are invalid TOML in a git source.
This change further ignores Cargo.toml files that are valid TOML but
cannot really be loaded in a git source.
This is potentially an alternative fix for #6822.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

This makes sense to me, but from the links Alex has the context:
@bors r? @alexcrichton

Thanks, I'll leave this open in case @alexcrichton wants to take a quick look, otherwise r=me.  It is hard to think of what consequences this will have.

@bors: r=ehuss
Seems reasonable to me especially since we're already ignoring syntactically invalid manifests

:pushpin: Commit a2cddeeb9fc74e0e4394e1f699a7246a73bebdd2 has been approved by ehuss

:hourglass: Testing commit a2cddeeb9fc74e0e4394e1f699a7246a73bebdd2 with merge 522a7bf8270b8fd3d0976ea5762321939f998417...

:broken_heart: Test failed - checks-azure

@bors retry
Nightly tests were broken.

:hourglass: Testing commit a2cddeeb9fc74e0e4394e1f699a7246a73bebdd2 with merge ac2eb69346e9ae4adedb90ce03b5f23d2a837e28...

:sunny: Test successful - checks-azure
Approved by: ehuss
Pushing ac2eb69346e9ae4adedb90ce03b5f23d2a837e28 to master...


Use failure instead of error_chain

Thanks to Send/Sync issues, we are stranded on a fork of error_chain. In any case, it’s a painful and error-prone library to use.
We should port to failure, which is the better replacement on the block.
And we should consider flattening out some of our error hierarchy, too.

Fixed in #730.


docs: update jekyll gem for python docs

One question I'm not clear on

where is the question?

One question I'm not clear on

where is the question?

That's so weird,  my comment is missing...
I was asking why we use a specific darwin package for the nokogiri

One question I'm not clear on

where is the question?

That's so weird, my comment is missing... I was asking why we use a specific darwin package for the nokogiri

So every time you do bundle install it will include the platform you used in the list of bundles and also update the specific platform packages.
I assume the next question will be so - How does it work for our Linux env?
We included ruby platform which means CRuby that runs on all non Windows platform and this is why it works in our CI.
We can explicit add linux as a platform and in this specific case, if we have linux specific implementation it will be added.


Incorrect version ordering in the compatibility matrix

The version ordering in the compatibility matrix is weird. I'd expect version 23.3.0 to be the rightmost version.
For example here: https://vaadin.com/directory/component/popup

Quickly looking at the code, it seems that this is because of string sorting. I guess there are add-ons that don't follow SemVer, which might be problematic.

Made a fix in c08f783c0a2e6d074236b22d7cb455e4ad1c37fd should be deployed soon.


fix an infinite loop in promptRemoteName

r? @patrickxb @akalin

We could write a test that just makes sure this doesn't infinite loop, but testing the correct retry logic for invalid usernames will be more involved. I'm tempted to put it off?

:mag_right: No visual changes found as a result of these commits.

Code is much easier to follow.  LGTM!
A test would be nice, but I think important to get this in as current state is completely busted if username not provided on command line.

Filed https://keybase.atlassian.net/browse/CORE-3156.

lgtm


Adding definition to JavaScript

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Adding definition to javascript

@Dauli Good add!
Thank you and congrats on your first-time contribution!

@Paul Thank you very much sir.


Include md output: spo user until spo web including the spo commands

Related to #3754

Update the documentation to include the md output for the commands under the service:

spo documentation location

This in place for the following command groups:

spo user
spo userprofile
spo web

And also the commands:

spo get
spo search
spo set

You can reference the commands planner plan and planner bucket. They are already contain the Markdown reponse in their documentation.
For more information what guidelines to follow, be sure to check out the epic issue #3754

I can attempt to work on this.

Awesome, all yours @reshmee011!


update logger for autoenticator.go, passed on docker-compose build

update the logger for this go file, and delete bee import as the build failure.

LGTM

LGTM


Guide on how to use this library with Kubernetes nodes discovery

Hello @shaj13 @aderouineau and @fredpetersen
I would like you to help provide guides on how to use this library on kubernetes where one can make use of the k8 api to discover pods and start a cluster.
Thanks

Never mind. I will not ask again.


Great Work

Would you happen to have an article/blog post or maybe even a tutorial that explains the usage?

Thanks, no blog post and this project is pretty out of date. I've been out of gRPC land for awhile and understand angular and grpc-web have both progressed quite a bit (my guess is all the angular stuff would break if you were to update it).
If you're interested I'd recommend starting a modern version of this project from scratch using updated dependencies and seeing where that takes you. gRPC > REST in my book and who knows maybe its matured enough to merit its use in production grade web applications.


GET /questionList should return questionList.ejs but  throws: "Exceeded timeout of 20000 ms for a test.

on deployment to azure questionList throws errors related to the length of time it takes to get information back from the DB
Load Pages › GET /questionList should return questionList.ejs

    thrown: "Exceeded timeout of 20000 ms for a test.
    Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

      26 | 			.end(done);
      27 | 	});
    > 28 | 	test("GET /questionList should return questionList.ejs", (done) => {
         | 	^
      29 | 		const res = request(app.server)
      30 | 			.get("/questionList")
      31 | 			.expect("Content-Type", /text\/html/)

      at test (server.test.js:28:2)
      at Object.describe (server.test.js:6:1)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 19 passed, 20 total
Snapshots:   0 total
Time:        21.703 s
Ran all test suites.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
Error: Process completed with exit code 1.

curiously, these tests pass locally so will need to be inspected more closely to determine the source of the error w.r.t azure settings

This was eventually removed from the API due to not being scaleable.


Delegate empty check fix

Not happy about it :|
Still stability is better than minor optimization.

Wisdom state the following:
(slow and correct) > (fast and incorrect)
:wink:


[SPARK-40053][CORE][SQL][TESTS] Add assume to dynamic cancel cases which requiring Python runtime environment

What changes were proposed in this pull request?
This pr add some assume conditions to dynamic ingored cases which requiring Python runtime environment:

"UNSUPPORTED_FEATURE: Using Python UDF with unsupported join condition" in QueryCompilationErrorsSuite should be ignored when shouldTestPythonUDFs is false
Split "Check source for different kind of UDFs" in ExpressionInfoSuite into two cases, "Check source for Python UDF" should be ignored when shouldTestPythonUDFs is false
All test in HiveExternalCatalogVersionsSuite should be ignored when isPythonVersionAtLeast is false, additionally, this PR simplifies the filter conditions of testingVersions in HiveExternalCatalogVersionsSuite due to EOL versions has been deleted from https://dist.apache.org/repos/dist/release/spark

Why are the changes needed?
The tests which requiring Python runtime environment should not ABORTED when python running environment is unavailable.
Does this PR introduce any user-facing change?
No, just for test.
How was this patch tested?

Pass GitHub Actions

cc @HyukjinKwon @dongjoon-hyun @srowen

Thank you for pinging me, @LuciferYang .

If the idea is to test only vs supported versions, yes that's fine, and 3.0.x is also EOL

So 3.0.x doesn't need to be tested too, right?

pr description is out of date, will update it after the code is OK

If it can be deleted from the data source, it is better

We keep them for older branch testing, but Apache Spark 3.1.1 was also released on March 2, 2021 and will be EOL soon on September 2nd.
So, we can focus on Apache Spark 3.4/3.3/3.2.

I removed the 2.4.x and 3.0.x releases from dist.apache.org

9966eeb simplify the filter conditions, only keep Spark 3.1 not test when using Java 17

Thank you so much, @srowen !

@dongjoon-hyun @srowen @HyukjinKwon I have added two similar cases that need to add assume(isPythonAvailable) and update pr description,  and continue to check whether there are any omissions. I will complete all the work in this pr to ensure that the command
mvn clean install -Phadoop-3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl -Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive

can succeed even when the python 3 running environment is unavailable

@dongjoon-hyun @srowen @HyukjinKwon I have added two similar cases that need to add assume(isPythonAvailable) and update pr description, and continue to check whether there are any omissions. I will complete all the work in this pr to ensure that the command
mvn clean install -Phadoop-3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl -Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive

can succeed even when the python 3 running environment is unavailable

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Spark Project Parent POM 3.4.0-SNAPSHOT:
[INFO]
[INFO] Spark Project Parent POM ........................... SUCCESS [  3.790 s]
[INFO] Spark Project Tags ................................. SUCCESS [ 30.902 s]
[INFO] Spark Project Sketch ............................... SUCCESS [ 24.123 s]
[INFO] Spark Project Local DB ............................. SUCCESS [ 11.130 s]
[INFO] Spark Project Networking ........................... SUCCESS [01:02 min]
[INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 16.631 s]
[INFO] Spark Project Unsafe ............................... SUCCESS [ 12.289 s]
[INFO] Spark Project Launcher ............................. SUCCESS [  8.497 s]
[INFO] Spark Project Core ................................. SUCCESS [33:12 min]
[INFO] Spark Project ML Local Library ..................... SUCCESS [ 33.611 s]
[INFO] Spark Project GraphX ............................... SUCCESS [03:27 min]
[INFO] Spark Project Streaming ............................ SUCCESS [06:19 min]
[INFO] Spark Project Catalyst ............................. SUCCESS [13:03 min]
[INFO] Spark Project SQL .................................. SUCCESS [  01:43 h]
[INFO] Spark Project ML Library ........................... SUCCESS [24:16 min]
[INFO] Spark Project Tools ................................ SUCCESS [ 10.749 s]
[INFO] Spark Project Hive ................................. SUCCESS [  01:40 h]
[INFO] Spark Project REPL ................................. SUCCESS [01:50 min]
[INFO] Spark Project YARN Shuffle Service ................. SUCCESS [ 13.176 s]
[INFO] Spark Project YARN ................................. SUCCESS [10:20 min]
[INFO] Spark Project Mesos ................................ SUCCESS [01:07 min]
[INFO] Spark Project Kubernetes ........................... SUCCESS [03:52 min]
[INFO] Spark Project Hive Thrift Server ................... SUCCESS [30:29 min]
[INFO] Spark Ganglia Integration .......................... SUCCESS [ 13.533 s]
[INFO] Spark Project Hadoop Cloud Integration ............. SUCCESS [ 30.778 s]
[INFO] Spark Project Assembly ............................. SUCCESS [ 33.197 s]
[INFO] Kafka 0.10+ Token Provider for Streaming ........... SUCCESS [ 48.943 s]
[INFO] Spark Integration for Kafka 0.10 ................... SUCCESS [02:26 min]
[INFO] Kafka 0.10+ Source for Structured Streaming ........ SUCCESS [35:31 min]
[INFO] Spark Kinesis Integration .......................... SUCCESS [01:31 min]
[INFO] Spark Project Examples ............................. SUCCESS [44:00 min]
[INFO] Spark Integration for Kafka 0.10 Assembly .......... SUCCESS [ 14.179 s]
[INFO] Spark Avro ......................................... SUCCESS [04:29 min]
[INFO] Spark Project Kinesis Assembly ..................... SUCCESS [ 17.180 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  07:06 h
[INFO] Finished at: 2022-08-15T17:34:05+08:00
[INFO] ------------------------------------------------------------------------

should passed

friendly Ping @HyukjinKwon @dongjoon-hyun @srowen,  should we continue this pr ?

Merged to master.

Thanks @HyukjinKwon @dongjoon-hyun @srowen

We keep them for older branch testing, but Apache Spark 3.1.1 was also released on March 2, 2021 and will be EOL soon on September 2nd.
So, we can focus on Apache Spark 3.4/3.3/3.2 from September.

Should we also remove 3.1.x from dist.apache.org?

Maybe, I mean we haven't really clearly said there won't be a 3.1.2. I'd wait until the end of the year

Should we remove 3.1.x from dist.apache.org? @srowen

Yeah I think that's fine now. I can do it, let me remember how

Done


Can't pass URLs under Linux Mint 17 Cinnamon

After the update post-#103, I updated TBB and I'm running torbrowser-launcher 0.1.7-ppa1-1. I can select Tor Browser as my default browser in the Preferred Applications preference applet, but when I click a link in another application nothing appears to happen.

This is possibly related to #157.

Passing URLs into Tor Browser Launcher no longer works, unfortunately.


swc typescript type is incorrect: ctext is missing in node types

Describe the bug
https://github.com/dai-shi/waku/pull/901
Input code
No response
Config
No response
Playground link (or link to the minimal reproduction)
https://github.com/dai-shi/waku/pull/901
SWC Info output
No response
Expected behavior
as title
Actual behavior
No response
Version
1.7.28
Additional context
No response

Actually we don't recommend using parse from JS.


[red-knot] Vendor typeshed's stdlib

Summary
This PR vendors typeshed!

The first commit vendors the stdlib directory from typeshed into a new crates/red_knot/vendored_typeshed directory.
The second commit adjusts various linting config files to make sure that the vendored code is excluded from typo checks, formatting checks, etc.
The LICENSE and README.md files are also vendored, but all other directories and files (stubs, scripts, tests, test_cases, etc.) are excluded. We should have no need for them (except possibly stubs/, discussed in more depth below).
Similar to the way pyright has a commit.txt file in its vendored copy of typeshed, to indicate which typeshed commit the vendored code corresponds to, I've also added a crates/red_knot/vendored_typeshed/source_commit.txt file in the third commit of this PR.

One open question is: should we vendor the stdlib and stubs directories, or just the stdlib directory? The stubs/ directory contains stubs for 162 third-party packages outside the stdlib. Mypy and typeshed_client[^1] only vendor the stdlib directory; pyright and pyre vendor both the stdlib and stubs directories; pytype vendors the entire typeshed repo (scripts/, tests/ and all).
In this PR, I've chosen to copy mypy and typeshed_client. Unlike vendoring the stdlib, which is unavoidable if we want to do typechecking of the stdlib, it's not strictly necessary to vendor the stubs directory: each subdirectory in stubs is published to PyPI as a standalone stubs distribution that can be (uv)-pip-installed into a virtual environment. It might be useful for our users if we vendored those stubs anyway, but there are costs as well as benefits to doing so (apart from just the sheer amount of vendored code in the ruff repository), so I'd rather consider it separately.
It will be necessary to add infrastructure to keep our vendored copy of typeshed up to date with the upstream repo. I will add this in a followup PR.
Test Plan
pre-commit run -a
[^1]: typeshed_client is used by Quora's type checker pyanalyze.

@carljm I'm expecting a line-by-line review

@carljm I'm expecting a line-by-line review

What would be helpful is if you could maybe add a few comments of the code that you want to get reviewed.

I defer to you all, but I personally would wait to have a PR (with this PR as the base) that leverages these stubs before merging this into main. It ensures that we have everything wired up correctly, and also prevents against us merging these stubs only to have them never be used in the event that we reprioritize or make some other decision.

@carljm I'm expecting a line-by-line review

What would be helpful is if you could maybe add a few comments of the code that you want to get reviewed.

Sorry, that was meant to be a joke :(
I tried to provide a guide to this in the PR description. I don't expect any code in the first commit to be reviewed, as that code is all vendored. I would appreciate a review on the design decisions I outlined in the PR description, and the (very small) configuration changes made in the second and third commit. (One question with the third commit is: did I miss anything? Do any other configuration files need to be updated?)

LGTM: I think we should add a READMe on how to update typeshed. For example, I wouldn't have known about the commit.txt file.

crates/red_knot/README.md, maybe?)

Seems fine to me.

Minor nit that I prefer vendor/typeshed to vendored_typeshed

What if we decide that it needs to go somewhere else, e.g., in its own crate? Are these strong advantages to merging now vs. waiting to understand how this will actually get used and integrated?

Minor nit that I prefer vendor/typeshed to vendored_typeshed

Done

I think the main thing that's missing that I would probably want to have before we merge this is at least documentation, and ideally automation, for updating the snapshot of typeshed.

Added some docs in crates/red_knot/README.md

What if we decide that it needs to go somewhere else, e.g., in its own crate? Are these strong advantages to merging now vs. waiting to understand how this will actually get used and integrated?

I think we should just merge it. I don't see any real disadvantages that would justify not merging now and stacked PRs are still a pain, even if it's just marginal:

What if we don't need it: I think that's extremely unlikely and is something that can be fixed easily, just delete the files ;)
What if we need to move the files. I'm sure Alex thought about where to place the files. But even if it turns out that we need to move the files because we learned something new, the fix is easy and a low effort PR.

What if we decide that it needs to go somewhere else, e.g., in its own crate?

It would surprise me quite a lot if code outside of red_knot needed to analyse typeshed's stdlib stubs. I think that would be a sign of bad architecture from us if they did: code from other crates should use high-level APIs provided by red-knot to query the resolved types that red-knot reaches by parsing and analysing the stdlib stubs, rather than analysing the stubs directly from outside red-knot. In any case, I think it will be very easy to move the stubs somewhere else if we decide at a later point in time that it's necessary.

Are these strong advantages to merging now

No strong advantages, no, other than being able to easily do work in followup PRs on the basis that this information is available to us inside the Ruff repository. And I'm also not sure I see any strong disadvantages. I don't think this locks us into having the stubs in one particular place, or precludes us from changing the way we vendor typeshed in the future. I'm happy to consider different ways of doing this (a PyPI package, or using a git submodule) in followups. But for now I think I'd rather land this and move onto followup work.

Any reason we didn't vendor it as a git submodule?

@Skylion007 we discussed this, but it's simpler to start without a submodule as it introduces changes to contributor's git workflows.

Any reason we didn't vendor it as a git submodule?

I'm open to it, but not sure it's worth the extra complication. As far as I can tell, the chief advantage seems to be that you'd be able to easily see typeshed's history from inside ruff, which might make it easier to bisect specific issues to specific typeshed commits. But my experience at mypy has been that it's rare that you need to do that -- it's usually pretty easy to figure out what typeshed change is to blame for a specific issue if one arises.
Of the four major Python type checkers currently, only one (pytype) uses a git submodule for their vendored typeshed stubs -- that doesn't mean that we shouldn't do something different, but it does suggest that it's not essential to use a git submodule.

Just to respond: I still wouldn't have merged this personally (especially if it were my own change), since (as a rule of thumb) it's unused code without a defined integration point. Maybe the integration is straightforward, but the point is we can't really know until we've taken the next step. Similarly, maybe we change priorities, and then we have a vendored typeshed sitting around.
Regardless, correct for me to defer to others since I'm in the minority. I feel heard, no need to respond!

Separately there are some unknowns to me that I'll be interested to watch, but that would not affect merging: How will we ensure that it gets included in the compiled binary? Will these be embedded in the binary, or somehow installed separately on-disk? How will we expose these to the resolver, if they are embedded in the binary? Etc.


Adds dependabot for outdated dependencies

Adds dependabot for outdated dependencies
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
Issue: #879

Thanks for your contribution! We track dependency updates with a separate system.


Release candidate: v2.4.0-rc1

Description
A few sentences describing the overall goals of the pull request's commits.
Please include

the type of fix - (e.g. bug fix, new feature, documentation)
some details on why this PR should be merged
the details of the testing you've done on it (both manual and automated)
which components are affected by this PR
links to issues that this PR addresses

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

One comment then LGTM.


Scope of First Release

What is the current scope of the first release?

When it comes to releases we're talking about API releases using the same schema k8s uses. The release we're talking about is v1beta1 and we hope to have people try that.
The scope for that still has not been decided but I hope we figure that out soon. We know it will be the CRD but what's unknown is what the controller will do.


Update the Certifying and Proposing script purposes

Their arguments now consist of both an integer index and the actual argument (TxCert and ProposalProcedure). Closes #5709

Given the long discussion on the other thread, I feel like we should have a Note here about the decision.

I feel like we should have a Note here about the decision.

Good point. Will add the note in another PR.


:bug: remove isTopic from tags

Column tags.isTopic was removed from MySQL. Reflect that in ETL.
@ikesau I'm not very familiar with how tags work on our site. Is there a way now to tell whether a tag is a topic tag? Topic tags had unique names, which was necessary to get their IDs in ETL. I don't they are unique any more. Any ideas how to filter them?
Adding where isBulkImport = 0 condition would make them unique. Is that enough or should I also filter it to tags with slugs?

@Marigold we now have a slug field that we use for this purpose. If the slug is not null then it is a topic page. @ikesau you said that the "full" version to check this is to join on posts and posts_gdocs and check if it is a topic page there but I think for now we could just say as a convention that slug should only be set for topic tags - agree?


Add an interface to filter packages by source

Preview of the feature:

fix #822
fix #584

Thank you Marti :)


Skip error record and continue with rest of lines

Hi,
Do we have a way to ignore erroneous line/record and continue with rest of the data.
As of now, on error, it is terminating the process and not processing the remaining valid records.
Thanks,
Raja

Hi,
There are ways to skip some validation.
Could you paste some sample csv data that you got error?
~Keyang

Here is my erroneous record:
EX1234;Germany Weiss spol. s r.o.;Zebra ;XZ;126 01;Ricklal - Jazlovice;"C/O Dutch Data Distribution, s.r.o;Log. Pork CTC, Nova Kicha;CZ;32947;Thor u Tachova
delimiter is ';', when the record is encountered with single double quote(unclosed quote), it is failing and skipping the remaining..

Hi,
you could turn off quote detection by setting quote:'off'.
Would this fix your issue?
~Keyang

Thank you. It works.


Convert home page to room landing page

When the website launches, the home page should be a more typical landing page, with a input field for jumping to a specific room name.

Done in ba9e1b8129dd2f4f6e0e4f2cac1b385822ab8ae6


[WIP] upgrading to latest version of behave-graph

I am upgrading behave-flow to the latest version of behave-graph.  Surprisingly there isn't that many changes given how radical I've changed things on my end.
This is in progress and not yet complete.

This is ready to merge if you like the changes.  It is possible that you don't.

Thanks for the work @bhouston!
Because of all the merge conflicts caused by my work yesterday, i've manually applied most of these changes to the main branch, there are a few outstanding issues with the example graphs I need to look into, but other than that it all works perfectly!


fix: drop pako

This drops pako as a dependency. From my [limited] testing, pako is only used for ~5% of all requests and saving just a few bytes, while making up almost 40% of the bundle size for the module. The size optimization brought in by pako likely won't actually reduce the amt of data transferred over the network as the packet size would most likely be too small to split it anyways.

Wow thanks for the PR! The reason I added the deflation is that for larger rooms the package collections can bloat to several kb but are very compressible. I’m def willing to be convinced this is a bad idea but maybe there is a way to deal with this without taking on the dependency?

could we maybe make a reproductible test case for this? I did see some minor increases, but it was at most 200 bytes?
for alternatives maybe we could strip unnecessary data from such requests or something along the lines? but for that we'd need a test case

I’m afk for a while, but try popping 5-6 tabs of the demo and adding a logging breakpoint in the debugger that writes the length of the naive JSON stringified payload. Iirc it’s somewhere between 5:1 and 10:1 once there are one or two packages in flight.

(Afk meaning I can’t write a test for this until later - I am not offline - but this is a good excuse to add a test suite :))

I ca reproduce this with >4 peers in a room, where deflate manages to half the data

it definitely scales with the amt of users, but I'm not sure what this handshake does [it only happens on initial connection] the rest of the requests are fine, there seems to be a lot of duplicate data bout peers we're already connected to
I don't really know the nitty gritty of how you've implemented this, but is it necessary?

but is it necessary?

this is heading in a bad direction, as it talks about implementation details, because if you decide to migrate to polite-peer, then it might behave marginally differently, but this seems more like lobby controls rather than signaling so that might not be true

Yep those are the signalling candidates and other data needed to negotiate with a peer. The reason I send them every request is it makes correctness easier and reduces the complexity of the worker, but in theory the worker could do more bookkeeping and ACK back the receipt of the packages you have posted. The edge cases felt gnarly so I punted on them - the payload size drops after a few minutes so I threw deflate at the problem but agree the dependency bloats it significantly.

Oh you know what, those used to be posted every request when I had the KV implementation which didn’t have read-after-write semantics - so it was strictly necessary. I forgot now I sent them only when they change so perhaps we can drop the dependency. Can you confirm that those big payloads aren’t being sent on every poll now? This might be a residual decision that should have been unwound once I dropped support for KV. (See the response to the question in issues.

Oh you know what, those used to be posted every request when I had the KV implementation which didn’t have read-after-write semantics - so it was strictly necessary. I forgot now I sent them only when they change so perhaps we can drop the dependency. Can you confirm that those big payloads aren’t being sent on every poll now? This might be a residual decision that should have been unwound once I dropped support for KV. (See the response to the question in issues.

if by poll you mean the update that runs on an interval, then yes, this ONLY runs when a new peer connects, and the following interval keepalives are smaller in raw json than deflate

Ok that makes sense. Yeah I think the trade off flips the other direction then and we can drop pako. I can probably write a more efficient JSON encoding at some point.

Ok that makes sense. Yeah I think the trade off flips the other direction then and we can drop pako. I can probably write a more efficient JSON encoding at some point.

okay, fixing conflict

Thank you!


Don't try to upload data to UCAS if we don't have a username

Context
I forgot that Azure sets these environment variables to an empty string if the variable isn't set in the library. This now does the correct thing.
Fixes https://sentry.io/organizations/dfe-bat/issues/1774232835/?referrer=slack
Changes proposed in this pull request
See commit.
Guidance to review

Link to Trello card
https://trello.com/c/vX5nXO2g/2331-arrange-matching-data-with-ucas
Things to check

[X] This code doesn't rely on migrations in the same Pull Request
[X] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[X] API release notes have been updated if necessary
[X] New environment variables have been added to the Azure config

This didn't work because if the variable isn't set:
irb(main):001:0> ENV['UCAS_USERNAME']
=> "$(ucasUsername)"

cc @stevehook @AgaDufrat @mnacos
I've added empty vars to all envs, hopefully that fixes the issue of the sync running on prod.


docs: various small updates to modernize docs

Some intro text felt out of date as well as minor changes to
the overall flow.
Small fix to extauth docs from recent issue.
Remove ambassador/gloo docs. Almost definitely out of date and
don't belong anymore given how many things consume Envoy.
Remove TapDS. It was never implemented and would never be
implemented given ECDS.
Fix release notes from stable releases.

LGTM


Slider fix

Closed since https://github.com/dxc-technology/halstack-react/pull/72 solves this issue.


Add bitbucket icon

@Naereen Thanks for the PR. The icons having -s in the name stands for share icons. The project has share icons like Facebook to share the post on Facebook. In case of bitbucket, it is not required. The normal icon can be used in the sidebar like github. Icons in the sidebar have white color. So, it would be great if you can update the PR to remove -s icon and update the normal icon with white color.


Update README.md.

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   32.16%   32.16%
=======================================
  Files          44       44
  Lines        1222     1222
  Branches       43       43
=======================================
  Hits          393      393
  Misses        829      829

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c896cb3...3b49b25. Read the comment docs.


Add validation to NameEvent: name should not exceed 255 bytes

The CI failure is fixed now on master, it has nothing to do with your changes. However, there are a few things to improve still.


Requesting update the simplify function

Hi,
The simplify function here still calls sympy, which is really time consuming.
Since symengine has already implemented its own simplify function.
Could you please update the simplify function as well as add the refine function here accordingly (https://github.com/symengine/symengine/issues/1520).
Thank you very much

Thanks for reporting this. Although the refine and simplify are not nearly as mature as the ones in sympy, I think we should use the ones in symengine here. If the user wants to use sympy to simplify that would still be possible, by calling sympy directly. I guess this is legacy from a time when symengine didn't have any similar functionality.

How is the status of this enhancement?

I would also appreciate this. What is currently holding this back? Doesn't the simplify function just need to be added in the wrapper?

Yes, it needs to be added. This also requires the Assumptions class to be added somehow and this might not be as straight forward. Any ideas on how to wrap this for Python?


Portfolio: finish mobile versio

Create "Works" section.

Create the "About myself" section (placed after the projects and before the contact form):

In order to lay out the elements in "Works" section you should use CSS Grid and Flexbox combined (it is mandatory that you - - use both). Use CSS Grid in the main container that contains all of the cards and use Flexbox to lay out an individual card.

I used ul and li for categories in "Work" section. Html, Css, and Javascript should be list items.

I used ul and li for categories in "About myself" section. Languages, Frameworks, and Skills should be list items.

I want to marge my project, but the action button disappears. I want to
submit my final submission of the project. please allow me to submit my
project on microverse week's first, day4.
On Sun, Aug 21, 2022 at 4:03 AM zieeco @.***> wrote:

@.**** approved this pull request.
status: APPROVED 🟢 💯
Hi, @RashidMenhas https://github.com/RashidMenhas,
Good job so far 👍 Your project is complete! There is nothing else to say
other than... it's time to merge it [image: :shipit:]
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/RashidMenhas/My-Portfolio/pull/2#pullrequestreview-1079588618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ4YV5QTCZAK2SAHMO46AR3V2FP3RANCNFSM57D2E4YA
.
You are receiving this because you were mentioned.Message ID:
@.***>


update migration-tests.nix

Issue Number

Overview

[ ] I have updated migration-tests.nix...

Comments
...

bors r+

bors r+


Bug report

Hi I have just tested the plugin it works perfectly apart from that we cannot put on the bridge in the chosen area

Он просто со временем ломает сервер


[DUOS-2183] Add DB Table for Files

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2183

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

@rushtong so it seems that you cannot get an instant from the database.... getObject("...", Instant.class) throws an exception. I can however, do getTimestamp("...").toInstant(). Locally that works fine, but it seems like there are some weird truncation issues when I push it up which make the tests fail. Going to add some delta so that they will be resistant to the truncation... but not feeling great about this approach, if you have any thoughts.

I can however, do getTimestamp("...").toInstant()

That is the right approach

I can however, do getTimestamp("...").toInstant()

That is the right approach

Ok coool I was more unhappy with adding a delta to the comparison, but I changed to comparing at the seconds level and that seems to work fine.


Release page don't paginate

Env

Gitea version (or commit ref): 009a0739906566abd511d17d53b8282696e9e99e
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (https://try.gitea.io/sapk/test-release/releases && https://try.gitea.io/sapk/test-release/releases?page=2)
[ ] No
[ ] Not relevant

Log gist:

Description
The page list is not shown at bottom of page
Screenshots

should be fixed by #1866

No this is the fact that we don't have page list at bottom of release page.

So if there is no PR for this, move this to v1.3 is a good chosen.

This is a bad bug but not blocking for the use of gitea. (we just don't have button to go to next page)
I don't have time to investigate futhermore in the next days so we could move to v1.3 if no one can fix it before.

Reopening as #2080 fixes this


Wrong type of argument

https://github.com/petergardfjall/emacs-immaterial-theme/blob/225b6d41f547146d511c0ba47f62069ad1e0c9cd/immaterial-theme.el#L376
After updating to a version including the above line I'm getting a wrong type of argument error complaining about the type of the argument of the :background attribute when treemacs is initializing. Should "red" be a string?

 That made it's way in by mistake. Should be fixed now: 660f999
Thanks for reporting!

Awesome! Thanks a lot. Thanks for your work on the theme. I'm really enjoying it


util/gopool: remove unused taskList type

SSIA, tasklist is unused.

@joway @jayantxie @ppzqh
Sorry for mentioned. I know your not codeowner of gopool package, but no activity from actual codeowner. so gentle ping.


Enhanced error module and support for rejections

Digging into the backend code, it looks like most of the stuff specified in the spec is not implemented or validated. I am going to cut back on the error classes and not worry about covering the spec.

Merging down. Solid test coverage really needs bits from another branch


Metadata is not included in in Message in SocketIO channel

Rasa Open Source version
3.0.9
Rasa SDK version
3.0.6
Rasa X version
No response
Python version
3.8
What operating system are you using?
Windows
What happened?
Metadata is perfect for handling lots of different specific tasks required by specific users of Rasa but unfortunately it is not included in SocketIO channel as stated in this post. It seems it can be taken care of by adding metadata=data['metadata'] to this line.
If this is intentional, sorry to submit it as a bug. I'll change to REST channel.
Command / Request
No response
Relevant log output
No response

Thanks for raising this issue, @joejuzl will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

I submitted a PR for this and also posted a docker image for testing stephens/rasa:3.1.0-full-socket


Request upload permission for azure-commons, azure-acs and kubernetes-cd

Description
Request upload permission for the following plugins:
Azure Commons Plugin
https://github.com/jenkinsci/azure-commons-plugin
https://issues.jenkins-ci.org/projects/HOSTING/issues/HOSTING-422
Azure Container Service Plugin
https://github.com/jenkinsci/azure-acs-plugin
https://issues.jenkins-ci.org/projects/HOSTING/issues/HOSTING-424
Kubernetes Continuous Deploy Plugin
https://github.com/jenkinsci/kubernetes-cd-plugin
https://issues.jenkins-ci.org/projects/HOSTING/issues/HOSTING-425
@chenkennt Could you please approve?

Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

(Not Applicable) For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

(Not Applicable) For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

Approved.

Sorry about that, need to update the doc.

I fixed the tool, but while that's not merged lowercasing the names in the YAML file is probably quicker. Alternatively, wait for us to merge the tool change, then I'll merge this.

Hi @daniel-beck, I have lowercased the user ID in the yaml files. Could you please check?
Thanks,


move 'ANOVA' under 'statistical hypothesis test'

This PR resolves #1570. It moves 'ANOVA' as a subclass of 'statistical hypothesis test'.

Discussed on the OBI call 2023-01-30: @hectorguzor will update the definition.


Use React-provided stacktrace in crash overlay

The recently merged crash overlay should support whitelisted warnings thrown by React.
Currently, this can be accomplished by enabling the console proxy via:
proxyConsole('error');

However, this relies on a synthetically generated stack-trace and not the stack-trace provided by React in the warning. e.g.
    var error = void 0;
    try {
      throw new Error(message);
    } catch (e) {
      error = e;
    }

This is problematic, however, because of how React works.

In React, components aren't rendered recursively, so there's never more than one component's render() on the stack
- @gaearon

This results in an unreconstructed tree of components specifying where the problem is stemming from.

The stack-trace from React is actually already parsed, and used to replace the line references on the synthetically generated stack-trace.
The proper behavior, however, would be to not generate a synthetic stack-trace and rely solely on the stack-trace given by React.
We realize this may be a daunting issue, but if you are up to the challenge, we will answer your every question!

/cc @brandonmikeska who expressed interest in helping with the overlay

Hey @Timer I am all for helping, but would need guidance on how to properly tackle this.

Sure!
To start working on this feature, first uncomment https://github.com/facebookincubator/create-react-app/blob/ed5c016d6169f0bac7e29625afba1bf7bccac1d9/packages/react-dev-utils/crashOverlay.js#L823.
This will enable the console.error proxy, defined here: https://github.com/facebookincubator/create-react-app/blob/ed5c016d6169f0bac7e29625afba1bf7bccac1d9/packages/react-dev-utils/crashOverlay.js#L786-L821.
However, our area of focus is to remove reliance on https://github.com/facebookincubator/create-react-app/blob/ed5c016d6169f0bac7e29625afba1bf7bccac1d9/packages/react-dev-utils/crashOverlay.js#L810-L815.
We want to create an error with the stack purely from the already extracted stack: https://github.com/facebookincubator/create-react-app/blob/ed5c016d6169f0bac7e29625afba1bf7bccac1d9/packages/react-dev-utils/crashOverlay.js#L794-L809.
However, due to the way this works the source resolving works, you're going to need to find a way to match these already-mapped files back to the bundled files (because of https://github.com/facebookincubator/create-react-app/blob/ed5c016d6169f0bac7e29625afba1bf7bccac1d9/packages/react-dev-utils/crashOverlay.js#L685-L691).
Now, you don't necessarily need to basically do the reverse of the sourcemap ... but perhaps propose a different solution. That is what this issue is about, figuring out how to do this best.
Let me know if this requires changes to stack-frame-resolver, and we can make it happen!

FWIW, the way I imagined it is we have a middleware on the dev server running at /debug-symbolicate or something like this. The error box can call it with the component stack trace from React warning. The middleware would look up the source lines around the locations sent by error box, and send the code in response. The error box would nicely format the code for each component stack frame and display it.

Hmm ok! I have not implemented a middleware before, but I wouldn't mind learning if someone has time for a screen share or documentation links that I can read through to get something started.

@brandonmikeska
Since webpack-dev-server is an Express app, you can start by looking at Express's middleware document: https://expressjs.com/en/guide/using-middleware.html and webpack-dev-server's api document: https://webpack.github.io/docs/webpack-dev-server.html#api
We're creating a webpack-dev-server (which is express app) inside start script:
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/scripts/start.js#L73
Then apply middleware from:
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/scripts/start.js#L76
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/scripts/utils/addWebpackMiddleware.js#L59
hope this help :)

@brandonmikeska we should probably start with https://github.com/facebookincubator/create-react-app/issues/1322, would you like to tackle that issue? 😄
It'll make mapping files to system files easier.

I've updated stack-frame to support this use-case.
This should be relatively trivial now. 😄

@Timer I can look at #1322 but it seems like you already have a proposed solution. Do you still want me to start there?

Yes, please! #1322 needs addressing -- I've explored how to implement the solution but not which path base is best for the solution itself.
If you can figure out the best base path (whether it be appBase or appSrc or appBuild, etc) and send a PR that'd be great. Feel more than free to copy my little snippet.
We'll need something for production, too.

This has been completed across multiple PRs. 😄


Remove branch parameter from build_package.sh file.

This implies also updating the .travis.yml files in all repos.

[ ] Swift-cfenv
[ ] swift-helloworld
[ ] swift-helloworld estado branch
[ ] Kitura-Starter
[ ] Swift-Cloudant-Boilerplate
[ ] cf-deployment-tracker-client-swift
[ ] BluePic

##Owned by other team members:
#Core repositories:

[ ] Kitura
[ ] Kitura-net
[ ] SwiftyJSON

##Sample applications:

[ ] Kitura-Sample

##Logging:

[ ] LoggerAPI
[ ] HeliumLogger

##Credentials:

[ ] Kitura-Credentials
[ ] Kitura-CredentialsFacebook
[ ] Kitura-CredentialsGitHub
[ ] Kitura-CredentialsGitHub
[ ] Kitura-CredentialsHTTP
[ ] Kitura-Credentials-Sample

##Sessions:

[ ] Kitura-Session
[ ] Kitura-Session-Redis

##Backend drivers:

[ ] Kitura-CouchDB
[ ] Kitura-redis

##Templating:

[ ] Kitura-MustacheTemplateEngine
[ ] Kitura-SampleStencil
[ ] Kitura-StencilTemplateEngine
[ ] Kitura-TemplateEngine

##Middlewares:

[ ] Kitura-Cache
[ ] Kitura-Compression
[ ] Kitura-CORS
[ ] Kitura-CSRF
[ ] Kitura-ResponseTime

##Bridging:
https://github.com/IBM-Swift/Bridging
##Experimental:
https://github.com/IBM-Swift/Swift-Kuery [WIP]
https://github.com/IBM-Swift/Kitura-Request [WIP]

[ ] BlueSocket
[ ] BlueSSLService

Repos not using PackageBuilder but are not owned by DevOps:
Repos not using PackageBuilder but are owned by DevOps:

kitura-ubuntu-docker
swift-ubuntu-docker
Package-Builder
swift-buildpack

This must be done before enabling swiftlint on PackageBuilder (see https://github.com/IBM-Swift/Package-Builder/issues/22).


Contributor by Action Visualization

@cdolfi Seems like an open-and-shut review (very straightforward), but could you please update the commit message to describe what's being changed, what the rationale is, and then sign the commit with '-s' flag?
I think 'git reset' pops the HEAD commit so you can re-commit with 'git commit -a -s' which will stage everything back and then auto-sign the commit, putting you into the commit title/message writing interface.
https://git-scm.com/docs/git-reset
Note of which issue this attends to, if any, would be listed as 'Fixes #<issue_number>'
Once that's done I'll review the code itself.

@JamesKunstle with the limited characters for commit messaging i just added the issue associated

@cdolfi Having the issue associated is good background.
I see that the vscode UI limits you to 50 characters of commit message. I also know that you don't really like using the terminal for Git stuff.
That being understood on my part, I'll just note that the character limit only applies to the commit title.

 The '-s' will instruct the commit to be signed with your email at the bottom.
It's not that we really look back at the commit log much so this mostly a non-issue, but for the sake of convention, someday in the future we should enforce that commits (1) are signed, probably with GPG keys, (2) are adequately titled, (3) have a message body that explains the contents, and references the issue that the commit fixes, if such a thing exists.

@JamesKunstle Changes made, let me know if you notice anything else that should be modified


Error: Cannot find module 'postcss-scss'

Gets this error when I run
❯ grunt sassdoc
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'postcss-scss'

Hi,
we would need a bit more informations, that's not a proper issue report.
We don't have this dependency in any of SassDoc's packages, so I would rather look at your Grunffile or other dependencies.


Scipy 2021

This branch should be where we update our tutorial for Scipy 2021.
Note that I am using the environment defined by the new anaconda-project.yml added in https://github.com/holoviz/holoviz/pull/281. In this first commit, I've simple reordered the material so that plotting is introduced before panel. My next step is to integrate these sections in a way that makes more sense i.e to use the composite plots built with hvplot in the panel section instead of only showing simple dataframe tables and logos.

So far I've made a pass on indes, 00 Setup, 01 Overview, 02 Basic Plotting, and 03 Composing. To-do items:

[ ] 00_Setup.ipynb and 01_Overview: Update screenshot
[ ] 00_Setup.ipynb: Update time estimates
[ ] all: Update inter-notebook links in the last section of each page
[ ] exercise 1
[ ] exercise 2
[ ] exercise 3
[ ] Remove snappy requirement (https://github.com/holoviz/holoviz/pull/220)?
[ ] Set up binder (https://github.com/holoviz/holoviz/pull/206) or provide AE sessions?
[ ] Add repr for bound objects, param.bind
[ ] Unpin holoviz metapackage and make final release (done?)
[ ] Make sure the overview of Panel emphasizes that it is general (not tied to a plotting library), plus components, pn.bind, layouts, .show(), serve, etc., motivated each time by what they let the user do
[ ] Review https://github.com/holoviz/holoviz/issues/275 looking for items to do or that are no longer relevant
[ ] Put content cut from https://github.com/holoviz/holoviz/pull/284 somewhere, e.g. in a wrapup notebook at the end
[ ] Run a link checker on the final version
[ ] 03_Composing_Plots: What should we see with "Use tab completion to explore weekly_count_plot."? The hint says to look at .data, but I don't see anything informative there.
[ ] Use bokeh 2.3.3 to avoid cnorm='eq_hist' colorbar bug

I quickly went through the tutorial, mostly looking that it made sense. I really like it!  It flows well and the story you are telling is clear to me.


No releases

@legeana The repository has no releases and meson wrap install glfw3 fails.

Duplicate of https://github.com/mesonbuild/wrapdb/issues/27
Someone requested to make a new wrap in https://github.com/mesonbuild/wrapdb/issues/15; the repository was duly created, but no PR to implement the wrap showed up.
You're welcome to submit one. :)

Duplicate of https://github.com/mesonbuild/wrapdb/issues/27
Someone requested to make a new wrap in https://github.com/mesonbuild/wrapdb/issues/15; the repository was duly created, but no PR to implement the wrap showed up.
You're welcome to submit one. :)

Duplicate of mesonbuild/wrapdb#27

Duplicate of mesonbuild/wrapdb#27


Feature request: Scatter-list-generic support for scottplot 5.0

Question:
When will be the feature "Scatter-list-generic"  available for Scottplot 5.0?
See link:
https://scottplot.net/cookbook/4.1/category/plottable-scatter-plot/#scatter-list-generic

I'm pretty sure this is already supported! The regular scatter plot can accept lists 🚀
https://scottplot.net/cookbook/5.0/Scatter/ScatterGeneric/

https://scottplot.net/cookbook/5.0/Scatter/ScatterList/

https://scottplot.net/cookbook/5.0/Scatter/ScatterList/

Thanks for reply it is working now, I have not realised, that I can use and dynamically extend the List in runtime and after that I refresh the Plot new values with Scottplot.Refresh(). The List can exchange the ScatterList :)


Updates versions of various helper libraries

This brings our requirements.txt up to date (modulo the huge migration to PyTorch 2.0 we still need to do).
requirements.txt is essentially notes about the environment we use to develop; pyproject.toml actually imposes a much looser set of restrictions for users.

TBF it is not necessitated, I am just keeping things up to date as it were.


update nav into server render for faster performance

  const [open, setOpen] = useState(false);

update the state as get parameter use - next/navigation

need this improve first rendering


Update afro-coder.json

Fixes Issue
Changes proposed

Updated links and my bio

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ x] This PR does not contain plagiarized content.
[ x] The title of my pull request is a short description of the requested changes.

Screenshots

## Note to reviewers

Hey, weirdly the actual page didn't get updated https://github.com/EddieHubCommunity/LinkFree/blob/main/data/afro-coder.json I can see the new changes but it doesn't show up here

Not sure if I'm missing something simple


[STORM-2505] Spout to support topic compaction

Kafka maintains the spout progress (offsets for partitions) which can hold a value which no longer exists (or offset+1 doesn't exist) in the topic due to following reasons
Topology stopped processing (or died) & topic got compacted (cleanup.policy=compact) leaving offset voids in the topic.
Topology stopped processing (or died) & Topic got cleaned up (cleanup.policy=delete) and the offset.
When the topology starts processing again (or restarted), the spout logic suggests that the next offset has to be (committedOffset+1) for the spout to make progress, which will never be the case as (committedOffset+1) has been removed from the topic and will never be acked.
OffsetManager.java
if (currOffset == nextCommitOffset + 1) {
        found = true;
        nextCommitMsg = currAckedMsg;
        nextCommitOffset = currOffset;
} else if (currOffset > nextCommitOffset + 1) {
        LOG.debug("topic-partition [{}] has non-continuous offset [{}]. It will be processed in a subsequent batch.", tp, currOffset);
}

This pull request maintains a emitted offset set in OffsetManager & smartly forward the offset to the next logical offset

LGTM. Good solution :)

Want to add the following note. This issue could potentially happen with non-compacted topics also. We had multiple topologies getting stuck due to this issue including a topic with "delete" config. Based on the learnings from the debugging myself and @vivekmittal did, even "delete" topics could encounter this issue under the following circumstance

A Kafka topic with relatively short retention period
A Storm topology that consumes from such a topic with a slow processing rate
A fallback strategy to earliest offset OR uncommitted_earliest

Given the above, it is possible that while the spout/consumer is busy processing messages fetched from a particular partition, the async cleaner has run and cleaned up expired logs on the Kafka broker managing that partition. Now when the spout fetches the next batch during a subsequent poll it is likely to see message offsets that are not sequential to the ones it received in the previous batch.

@vivekmittal can you squash your commits into singe one.
"Topology stopped processing (or died) & topic got compacted (cleanup.policy=compact) leaving offset voids in the topic.
Topology stopped processing (or died) & Topic got cleaned up (cleanup.policy=delete) and the offset."
In both of these cases are we not getting OffsetOutofRange exception?

We have set the auto.offset.reset property to 'latest' which is the default value in Kafka. The exception is thrown only when it is set to 'none'. Verified the same in Fetcher.java in Kafka clients library.
We do see kafka client log message indicating offset being reset.

Squashed the commits into one.

@vivekmittal over LGTM. I am +1 once the method name is addressed.
Thanks for finding & addressing the bug.

@harshach Method name is addressed. Squashed all my commits into one.

+1. Thanks @vivekmittal

@vivekmittal I think you need to  open another PR against 1.x-branch. Don't think this can be cherry-picked onto 1.x-branch.

@harshach Will do.

Raised PR to pull same changes in 1.x-branch
https://github.com/apache/storm/pull/2107


Rename autoreload to live reload

Thank you very much. Hotreload works great!!!  With "--csr", when I change CSS, I got instant UI feedback.
So now I got TailwindCSS + Hotreload ( and fast UI feedback). And I got rust web!
Really appreciate it!


Fix/i cub notts01

@marcoaccame non riesco a decidere l'assegnatario ci pensi tu a prendrtela?

ciao @simeonedussoni i will look at it. thanx

Duplication of https://github.com/robotology/robots-configuration/pull/164, closing.


[HUDI-3520] Introduce DeleteSupportSchemaPostProcessor to support adding _hoodie_is_deleted column to schema

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
In our use case, data is read from kafka(binlog with some preprocess), schema read from hive, we need
add _hoodie_is_deleted column to schema to support delete operation
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
This pull request is already covered by existing tests, such as:
org.apache.hudi.utilities.schema.TestSchemaPostProcessor#testDeleteSupport
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@alexeykudinkin : Can you review this please.

@nsivabalan  please take another look when free

This adds a useful missing piece. Thank you for contributing this @wangxianghu

@nsivabalan
Sure, I'll work on that