TypeError when an item is being moved from one model to another model.

Hi,
I am currently using the ui sortable for drag and drop in my application. I have two lists one is availableFilters(AF) and another one is selectedFilters(SF). I am moving the items from AF to SF for the very first time everything seems to be woking fine and I could able to save the list. Once a user clicks the save button then I am setting SF to an empty array, if a user moves any items from AF to SF for the second time I am getting an TyperError.
TypeError: ngModel.$modelValue.splice is not a function
at sortable.js:227
at Scope.promises.$get.Scope.$eval (angular.js:12811)
at Scope.promises.$get.Scope.$apply (angular.js:12909)
at HTMLUListElement.link.callbacks.update (sortable.js:226)
at e.Widget._trigger (jquery-ui.min.js:6)
at e.widget._trigger (jquery-ui.min.js:6)
at null._trigger (jquery-ui.min.js:6)
at null. (jquery-ui.min.js:6)
at e.widget._clear (jquery-ui.min.js:6)
at null._clear (jquery-ui.min.js:6)
Here is the sample working demo: http://plnkr.co/edit/KqhrhgQUqVb9nzkCfWyg?p=preview
Any thoughts on it?

you actually set it to: $scope.selectedFilters = {};, not an empty array.
Changing this should make it work.

@thgreasi Thank you. My mistake. It works.


Pants Build is a friend of Rust.

Feel free to use pants-devel at googlegroups dot com as the organization contact.
Thanks!

🎊


[bug]: metric_tx_amounts add total asset value and not increment

If we look at tx_amounts metrics definition: "average amount involved in a transaction on this peer"
In implementation of Asset-related instructions (Mint, Burn, Transfer) we always add total quantity value for metrics_tx_amounts. When it seems like should add only actual value being transferred, minted or burnt.
For example:

if user A had 10 apples and then mint 1 apple we should add 1 to metrics_tx_amounts (and currently we add 11);
if user A had 10 apples and then burn 1 apple we should add 1 to metrics_tx_amounts (and currently we add 9);
if user A had 10 apples and then transferred 1 apple to user B who already had 6 apples then we should add 1 to metrics_tx_amounts (an currently we add 7).

testing blocked https://github.com/hyperledger/iroha/issues/3709


How to not let div to be broken by page break

Hi, I 'am using the following config file for export html to pdf:
    const opt = {
      filename: `relatorio_de_${this.typeValue}.pdf`,
      image: { type: 'jpeg', quality: 0.98 },
      html2canvas: { scale: 1 },
      pagebreak: { mode: ['legacy', 'avoid-all', 'css']},
      jsPDF: { unit: 'in', format: 'a2', orientation: 'l' },
    }`;

But i need a div to not be broken from pagebreak. Is there some way to disable page break avoid-all to a specific div?

In your div element, add a css style break-inside:avoid

@tmislos-cgi thanks!!


added new resources

🛠 Fixes issue #
📇 Changes proposed
✅ Check List (Mark all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] This PR contains changes in the documentation
[ ] This PR contains changes in the Code of the project
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Why there are so many changes there in so many files @elidakirigo, Kindly refer to the contributing.md file

seen. i have added a new pull request.


#2222 bug fixs and add test case

Fixes #ISSUSE_ID.
Changes proposed in this pull request:

Pull Request Test Coverage Report for Build 7675

0 of 17 (0.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 55.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/sharding/dml/OrConditionFiller.java
0
3
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/sharding/dml/insert/InsertValuesFiller.java
0
3
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/dml/expr/CommonExpressionSegment.java
0
4
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/old/parser/context/condition/Condition.java
0
7
0.0%

Totals

Change from base Build 7674:
-0.05%

Covered Lines:
8700

Relevant Lines:
15802

💛  - Coveralls


Semantic-UI theming

Depends on https://github.com/inveniosoftware/invenio-assets/pull/123 and https://github.com/inveniosoftware/invenio-theme/pull/169

@slint this is still needed I guess... It is affecting this https://github.com/inveniosoftware/cookiecutter-invenio-instance/issues/250 if I am correct the alias of the search app change is what's missing. I will take over if its okay with you.

Already included in master. Closing....


project manager could not remove member from project

In GitLab by @wknet123 on Sep 13, 2017, 18:53
'/repos/board_repos/' should not appear in Dockerfile copy from path.

In GitLab by @wknet123 on Nov 8, 2019, 07:36
Fixed with PR #303

In GitLab by @Robin-Mao on Nov 8, 2019, 07:36
Fixed

In GitLab by @sokril on Nov 8, 2019, 08:10
closed

In GitLab by @sokril on Nov 8, 2019, 08:10
assigned to @wknet123

In GitLab by @wknet123 on Nov 13, 2019, 03:54
mentioned in merge request !127

In GitLab by @wknet123 on Nov 13, 2019, 09:58
mentioned in merge request !202


Client connect to server

How do i connect the client to the server?
I have tried editing the PreLauncher file but it doesn`t work. I tried to make it load a local socket.cfg file and there i put <IP_ADDRESS>

ok i did it with charles proxy


Ref/feature/read only asset folders

Task: #861mdpwvu
Added the node_modules folder as a read-only source to the asset browser.
Generalized the way the FileAssetLoaderSystem can be used. When binding the class in the Zenject installer, you can now specify a relative path and if the loader should be read-only or not.

Task linked: CU-861mdpwvu Add the node_modules folder as read only asset source


install: Check CPU and OS architecture

https://chat.zulip.org/#narrow/stream/31-production-help/topic/Problem.20with.20initial.20install.20Debian.20bookworm.20.28sid.29.20and.20node/near/1583257

Posted one comment, otherwise lgtm. I like the new helper function.

Merged, thanks @andersk! Also tagged as a backport candidate.

Backported in #25994.


Loki v5 updates

Adds per-byte/per-output fee support
Fix for API change in db->open needing nettype passed in

Closing; this commit was included in PR #5.


Please add a table, which sums up all losses per system

It would be very interesting to see the summed losses per system.
For example, which tank models were used and lost.
In a chart visualisation it would also be interesting, when which system started to get losses, sxplaining when which system got introduced into this war.
You could then see, if russia is slowly using more and more old equipment.
Thank you

It is available in the shiny app. To run locally:
shiny::runGitHub("leedrake5/Russia-Ukraine", subdir="shinyApp")
You can access a server deployed version here: https://bleedrake.shinyapps.io/Russia-Ukraine/


fix Test.prototype.test optional arguments (issue #244)

I'm not sure if the tests that I added use the preferred strategy of testing the fixed feature. I wasn't able to find examples of similar tests. Some test documentation or guidelines would be helpful. Part of the problem is that it wasn't immediately clear to me which parts of the code were the tests being tested and which were the tests of the tests.
Note that there is a suspicious line in Test.prototype.test, which I didn't touch out of cautiousness.
When the test name is missing, it's being set to its fallback value '(unnamed test)' at line 453 after it is used at line 453. Is it supposed to be in that order? It would make sense to set the fallback value around line 433.

Setting the fallback earlier would be fine, but there's no harm in the current order.  All that'll happen is that it'll re-enter the function with undefined or some other falsey value, and then fall back the second time around.
For tests, in this case it'd be sufficient to modify one of the examples in test/test/*.js to set an options object and no name.  Then run npm run regen-fixtures to update the output fixtures.

Test failures on Node 5 are unrelated.  The function value on throws changed from Timer._onTimeout to null._onTimeout, so I just need to update the test to allow for this.

Landed on master, but slightly different implementation, and factored it out so that this bit could be unit tested explicitly.
Thanks!

Thank you!


Enable Issues on GitHub

@grinstead this project is a fork and we only had one open issue on the original project.
I've enabled the issues here.
If you find things that need to be updated or contributions, then feel free to share them here.
This repo is hosted on an Apache server and I have it sort of bubble-gum and duck taped in because I have no experience hosting javascript apps.  So, I could also try to redeploy updates to the existing site and post the errors or roadblocks I was getting with hosting this demo map.

This is currently being hosted and deployed automatically with github actions, so this issue probably isn't relevant anymore!


Ensure VersionMap is actually copied.

The previous implementation was not guaranteed to do so,
this version is documented to be making a copy of the underlying data.

add a test for copy?

Test added. It passes on the old version FWIW. This is more a defensive thing since the way we were using is not documented to make a copy and thus not good to code against.


How about the speed?

Hi @chenyilun95, thanks for your great work. I would like to ask a question about the speed of CPN. Thanks.

Right now we only do some flops analysis in paper. And this code is not written for efficiency and it indeed need some time to make the code quick maybe in C++ programming. In reality the speed depends on the number of detection boxes in one image + network forward + post processing. Thus, you might have a try to run the code and analysis the bottleneck of speed.

@chenyilun95, thank you.

@yw155 May I ask about speed of this method? Thank you


add image map debugging option

This is failing the tests because of an issue with learn.staging.concord.org. The code is straight forward though, so I figure it would be OK to review and merge if it looks fine.


[issue-447] added NamedQueryContext method on sqlx.Tx

Issue-447
added NamedQueryContext method on *sqlx.Tx

Pull Request Test Coverage Report for Build 117

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 67.689%

Totals

Change from base Build 113:
0.7%

Covered Lines:
1986

Relevant Lines:
2934

💛  - Coveralls

@jmoiron any reason not to move ahead with this one? Similar PRs have been raised before without any feedback. Not having this in places means that the transaction type can't be used in places where the database can

Why is this one not merged?

This one would be useful

@jmoiron please merge this PR, without it it's impossible to use this functionality in abstractions over *DB and *Tx

Hi @jmoiron @dlsniper
Any chance to get this merged?

or  @ardan-bkennedy, as mentioned in https://github.com/jmoiron/sqlx/pull/914#issuecomment-2058918684


Change sublabel text in the multi select component

Change the sublabel text in select component with multiselect option to a more accurate one. (For Mac users it's not the control button but the command)

I know, such an improvement 😂


Add actual git repository for source

The Source information only contains the information what kind of repository/registry was used.
This is enough in the case of a dependency from crates.io, but especially for a git dependency, this could mean anything, and doesn't really provide any value IMHO.
Unless of course, the actual repository information (like the git repository + revision) would be available too.
I know this would increase the size of the metadata. However, I also think it would provide quite some value. And, this would only be the case of one would use dependencies from git anyway.

The repository URL is deliberately redacted because of privacy concerns raised in the RFC: https://github.com/rust-lang/rfcs/pull/2801
However, we could and probably should include commit hashes for dependencies from git.

Hm, that's a good point indeed.
I guess it depends on ones use case. Adding commit hashes shouldn't be a problem I guess. But would improve the situation.

Just a thought that just crossed my mind. Why not allow both? If a user has not problem with "leaking" this information, this it can be added. Otherwise, it will be redacted using a hash as you suggested.
So the choice is to the person verifying the information if this is good enough or not.

Including git repo URLs causes privacy issues, but I've opened #122 to track including commit hashes.


socket.io instrumentation

socket.io instrumentation
monday item
supported versions [>= 3]
Traced functions

emit
on

custom attributes

socket.io.namespace when sending to a namespace
socket.io.rooms when broadcasting

You should rename the PR to feat: socket.io instrumentation. This will create an automatic changelog.
You can read more about it here: https://github.com/aspecto-io/aspecto-opentelemetry-js/blob/master/CONTRIBUTING.md


Action Item Assignment

Description

It would be nice to be able to assign action items to specific user's. This PR adds the functionality to do so.
https://user-images.githubusercontent.com/54583311/202765077-e27c966a-610c-4267-b28b-b2e5919b6e5a.mov
Type of change

[x] Housekeeping and refactoring
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Did various local testing. The api changes have full unit test coverage.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Changed to approval since Im assuming you're fixing the MAJOR vulnerability


fix: addressed bugs in play-pause functionality

This addresses the problems associated with issue #52

I'm gonna /close this PR, because the stated bug was due to a unsupported YTMDesktop version.


Improve compatibility of contains @line 149 in models.py

There a some incompatibility of checking several keys against fields names:
        Products = Code['pack']['value']['products'].all()
        products=[{'id':x['id'], 'name': x['name']} for x in Products if ('id', 'name') in x]

File "/home/proj3/venv-3.5/lib/python3.5/site-packages/remodel/models.py", line 149, in __ contains__
return hasattr(self.fields, item)
TypeError: hasattr(): attribute name must be string

Need to make check for iterables for keys, returning True if all of them in place.

For me. fix is the something like this:
    def __contains__(self, item):
        if not isinstance(item, str):
            res=True
            for i in item:
                res=hasattr(self.fields, i)
                print("checking", i)
        else:
            res=hasattr(self.fields, item)
        return res

A model's interface was designed to resemble dicts as much as possible. In that sense, checking for more than one field on an object is more than Python's dict interface. Also, you example may assume you are checking whether a specific tuple is inside an object, which may lead to ambiguity. In the end, I don't think this should be implemented in remodel's interface. I will close this issue for now, but feel free to reopen it if you have more to add!


$input-height and $input-height-* should include borders, no need to calculate select.form-control heights, and calculate form validation icon sizes

Updated so $input-height, $input-height-lg, and $input-height-sm reflect the height of inputs with borders. Select elements should be the same size as other inputs when the value of $input-btn-border-width is greater than 1px.

This will be tackled by #22395.


It does not correctly recognize the mime type of a file

Expected Behavior
I am uploading images
let info = FileInfo {
            id: entry.key().into(),
            filename: upload.filename.clone(),
            mimetype: upload.content_type,
        };

I took an image and put it as a .txt extension, and when loading it the mimetype shows me  "text/plain"  I expected it to be
"image/jpeg"
Actual Behavior
{
  "data": {
    "multipleUpload": [
      {
        "filename": "test.txt",
        "id": "0",
        "mimetype": "text/plain",
      }
    ]
  }
}

Steps to Reproduce the Problem
Upload image file with the extension changed, example .txt
Specifications

Version: rustc 1.48.0 (7eac88abb 2020-11-16)
Platform: Linux

Is this a bug? You have changed the file name to .txt, of course the mimetype will be text/plain. 😂

Excuse me, but I understand that the Mime types are not related to the extension.
Example in linux uses the mimetype to determine the type of file and not the extension
$ file --mime-type -b image.txt
image/jpeg

In Java
Path path = new File("product.txt").toPath();
String mimeType = Files.probeContentType(path);

assertEquals(mimeType, "image/png"); // true
```

**In PHP**
```
echo mime_content_type('image.txt')  // image/jpg
```
Etc

Excuse me if i'm wrong

In fact, Async-graphql only uses the mimetype reported by the HTTP client as the mimetype of the file, and does not parse the file header to obtain the true type of the file.

I will close this issue, please feel free to open it if you have any questions.


fix: use a patch for rerender

This PR uses a patch for rerendering instead of copying the data.
closes #21

Thank you very much! 🙏


Export name issue with jest-mock while running Storybook

Hello there,
When I install Vite then storybook-builder-vite with npx sb@latest init --builder storybook-builder-vite, the compilation works fine but then Storybook fails to start throwing this error:

I have tried to add jest-mock to the optimizeDeps, install the dependency but nothing works.
When I run npx sb@next init --builder storybook-builder-vite, I have a similar error with acorn-jxs which has a missing export as well.
I suspect that the issue is related to ESM and how the dependencies exports their methods.
Any clue or help to solve this issue?
Thanks!

Are you using @storybook/jest?  I have had the same problem when trying to use that.  If not, what is pulling in jest-mock?  You should be able to npm why jest-mock to find out.

I have the same issue :).. seems to be added by @storybook/addon-interactions

I've had problems with @storybook/addon-interactions as well.  For now, I've just been using the play functions and importing directly from @testing-library modules instead of the instrumented storybook versions.  I'm hopeful that we'll be able to use the interactions addon at some point, but for now I think it's not ready for use in vite projects.

same error from a fresh install

I think this is something that needs to be addressed in the interaction addon.  Would y'all mind giving a 👍 or adding any missing information to https://github.com/storybookjs/storybook/issues/17516?
One other possible workaround (I don't really recommend it, and haven't tested it), could be to set global = window, since I believe that's what is failing inside of jest-mock (it tries to mock global, which vite does not polyfill like webpack.

I've opened https://github.com/storybookjs/storybook/pull/17535 to address this issue, keep an eye on that if you'd like to know the current status.

This should now be fixed in https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.43, if anyone would like to test it out.

I tried Storybook v6.5.0-alpha.44 and now get the following error:
Uncaught SyntaxError: The requested module '/node_modules/jest-mock/build/index.js?v=168864d3' does not provide an export named 'ModuleMocker'

My dependencies are:
    "@storybook/addon-actions": "^6.5.0-alpha.44",
    "@storybook/addon-essentials": "^6.5.0-alpha.44",
    "@storybook/addon-interactions": "^6.5.0-alpha.44",
    "@storybook/addon-links": "^6.5.0-alpha.44",
    "@storybook/react": "^6.5.0-alpha.44",
    "@storybook/testing-library": "^0.0.9",

Can you try adding jest-mock to your optimizeDeps.include?

@IanVS Just tried, but the ModuleMocker error persists :(
I'm testing with a freshly scaffolded project, by the way. My Vite config is:
// vite.config.ts
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";

// https://vitejs.dev/config/
export default defineConfig({
  optimizeDeps: {
    include: ["jest-mock"],
  },
  plugins: [react()],
});

Experiencing this as well in a fresh project.

I need to make a change in storybook, but in the meantime, you should be able to add a .storybook/preview-head.html with contents of:
<script>
  window.global = window;
</script>

In the reproduction in https://github.com/eirslett/storybook-builder-vite/issues/242#issuecomment-1055040000, I also needed to update vite to 2.8.6, run npx sb@next upgrade --prerelease, and then rm -rf node_modules/.vite-storybook to clear the cache.  After that, I'm able to load stories in that reproduction.

I've opened https://github.com/storybookjs/storybook/pull/17614 to address the need to set global in my workaround above.

Just to add that I experience the above-mentioned issue on a fresh project:

Uncaught SyntaxError: The requested module '/node_modules/jest-mock/build/index.js?v=168864d3' does not provide an export named 'ModuleMocker'

npm create vite@latest epg-service --template react-ts
npx sb@next init --builder storybook-builder-vite

I was unable to fix things by following IanVS's steps of:

Add the mentioned .storybook/preview-head.html:<script>
  window.global = window;
</script>

Add the following to my vite.config.ts:import { defineConfig } from 'vite'
import react from '@vitejs/plugin-react'

// https://vitejs.dev/config/
export default defineConfig({
+  optimizeDeps: {
+    include: ["jest-mock"],
+  },
  plugins: [react()]
})

npm install --save-dev<EMAIL_ADDRESS>npx sb@next upgrade --prerelease
rm -rf node_modules/.vite-storybook
npm run storybook

... However, the problem still persists. Here's my final package.json:
{
  "name": "my-app",
  "private": true,
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "tsc && vite build",
    "preview": "vite preview",
    "storybook": "start-storybook -p 6006",
    "build-storybook": "build-storybook"
  },
  "dependencies": {
    "react": "^17.0.2",
    "react-dom": "^17.0.2"
  },
  "devDependencies": {
    "@babel/core": "^7.17.5",
    "@storybook/addon-actions": "^6.5.0-alpha.45",
    "@storybook/addon-essentials": "^6.5.0-alpha.45",
    "@storybook/addon-interactions": "^6.5.0-alpha.45",
    "@storybook/addon-links": "^6.5.0-alpha.45",
    "@storybook/react": "^6.5.0-alpha.45",
    "@storybook/testing-library": "0.0.9",
    "@types/react": "^17.0.33",
    "@types/react-dom": "^17.0.10",
    "@vitejs/plugin-react": "^1.0.7",
    "babel-loader": "^8.2.3",
    "storybook-builder-vite": "^0.1.17",
    "typescript": "^4.5.4",
    "vite": "^2.8.6"
  }
}

The only thing that I've found to improve the situation is kaminskypavel's suggestion to remove addon-interactions altogether (and I'm not sure what the consequences of that are):
module.exports = {
  "stories": [
    "../src/**/*.stories.mdx",
    "../src/**/*.stories.@(js|jsx|ts|tsx)"
  ],
  "addons": [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
-    "@storybook/addon-interactions"
  ],
  "framework": "@storybook/react",
  "core": {
    "builder": "storybook-builder-vite"
  }
}

@shirakaba Do you happen to have a reproduction that I could take a look at?

@IanVS I've made one now:
https://github.com/shirakaba/storybook-jest-mock-issue-repro
On the branch main, the latest commit shows the results of:
npm create vite@latest storybook-jest-mock-issue-repro --template react-ts
cd storybook-jest-mock-issue-repro
npx sb@next init --builder storybook-builder-vite

On the branch workaround, the latest commit shows the results of the further steps 1-6 that I specified in the comment above (https://github.com/eirslett/storybook-builder-vite/issues/242#issuecomment-1058016078).
In both cases, they meet the same error:

Uncaught SyntaxError: The requested module '/node_modules/jest-mock/build/index.js?v=168864d3' does not provide an export named 'ModuleMocker'

Thanks @shirakaba that was helpful.  There's one more piece you need in your workaround branch (until I can make a PR to fix it in this repo and release a new version).
// .storybook/main.js

module.exports = {
  //...existing config
  viteFinal: async (config) => {
    config.optimizeDeps.include = [...(config.optimizeDeps?.include ?? []), 'jest-mock'];
    return config;
  },
};

You should now be able to remove the explicit jest-mock if using 0.1.18.

just tested with the following deps
         ...

        "@storybook/addon-actions": "^6.4.19",
        "@storybook/addon-essentials": "^6.4.19",
        "@storybook/addon-interactions": "^6.4.19",
        "@storybook/addon-links": "^6.4.19",
        "@storybook/jest": "^0.0.10",
        "@storybook/react": "^6.4.19",
        "@storybook/testing-library": "^0.0.9",
        "storybook-builder-vite": "^0.1.21",
        "vite": "^2.9.0-beta.4"
         ...

im still getting
Uncaught ReferenceError: global is not defined
    at ../../node_modules/jest-mock/build/index.js (:6006/node_modules/.vite-storybook/deps/jest-mock.js?v=45d2dd06:597:37)
    at __require2 (:6006/node_modules/.vite-storybook/deps/chunk-3XETP6YP.js?v=45d2dd06:47:50)
    at :6006/node_modules/.vite-storybook/deps/jest-mock.js?v=45d2dd06:609:25

the error is still caused by @storybook/addon-interactions 🤷♂

This error is due to https://github.com/storybookjs/storybook/issues/15391.  Until we find a better way to solve it, you can create a .storybook/preview-head.html with contents of:
<script>
  window.global = window;
</script>


Add options for on-host wal_g backups

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I edited my comment with a different revision of the wording; happy to go with what you have here or that revision at your discretion. Otherwise lgtm.

@timabbott: This has more words in more places.  Give it another read-through?

Looks great, merged, thanks @alexmv!


Todo list?

I made a TODO list... useful?

yep!

I've updated it to say the umb-editor-footer-content-left/right and sub header ones are complete - as they are child elements of the footer/sub header with no attributes so they are 'just there' - without and extra class. (e.g https://github.com/KevinJump/UmbSense/blob/master/UmbSense/Completion/Directives/UmbEditorSubHeader.cs)

Cool. I wasn't sure whether we'd mark them as complete - or whether they'd need their own classes, but yeah there are no attributes or child elements for those, so are effectively "done".
Guess the same goes for umb-pane and umb-panel? (if you want to mark those off... otherwise I'll send a PR at some point)


Trust List

Show the list of users that a given user is trusting/trusted_by in their profile display.

Done.


IInstantiator.InstantiatePrefab always sets includeInactive to false

Is it possible to make this behavior configurable?

Added an optional parameter to InstantiatePrefab and its variants
Thanks for the report


Add WSL fallback to InteractiveBrowserCredential

InteractiveBrowserCredential relies on webbrowser.open to browse to the redirect URL. That doesn't work in all WSL environments, so this PR has the credential fall back to powershell.exe, which should be possible for all recent WSL builds. Closes #17615

/check-enforcer evaluate


Problems on Mac

I had a small problem starting Argo on Mac. I got error "env: node\r: No such file or directory"
The problem appears to be dos line endings on the javascript file.
The solution for Mac users is to run dos2unix on the argo-trading file in /usr/local/..../bin/
More details are here
This may apply to Unix installations as well.

I thought to have fixed it in #4.
I publish a new release in a few hours.

Published 2.6.0.
Thanks for the feedback.


crypto/evp/evp_key.c: #define BUFSIZ if <stdio.h> doesn't #define it

Fixes #8904
Commit 48feaceb53fa ("Remove the possibility to disable the UI module
entirely", 2017-07-03) made the BUFSIZ references in "evp_key.c"
unconditional, by deleting the preprocessing directive "#ifndef
OPENSSL_NO_UI". This breaks the build when compiling OpenSSL for edk2
(OPENSSL_SYS_UEFI), because edk2's <stdio.h> doesn't #define BUFSIZ.
Provide a fallback definition, like we do in "crypto/ui/ui_util.c" (from
commit 984d6c605216, "Fix no-stdio build", 2015-09-29).
Signed-off-by: Laszlo Ersek<EMAIL_ADDRESS>
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Ping -- can we get this merged please?
Indeed, I do not have a CLA completed. However, the policy at https://www.openssl.org/policies/cla.html writes, OpenSSL requires that all non-trivial contributors of ideas, code, or documentation complete, sign, and submit (via postal mail, fax or email) an Individual Contributor License Agreement (ICLA).
And I would argue this patch is trivial. Thanks.

@levitte @richsalz can you please comment on the above? Thank you.

For trivial commits, the commit message needs to include the following line, separated with an empty line from the rest of the commit message:
CLA: trivial

I agree this is trivial.

@levitte thank you, I can do that. What is the proper workflow for submitting an updated pullreq? (With a mailing-list based workflow, I would simply send a v2 patch.) Thanks.

What is the proper workflow for submitting an updated pullreq?

git commit --amend
git push -f

(with added arguments if you don't use the default remote for this branch, of course)

I am from the same company as Laszlo

No biggie.  If Laszlo was an official reviewer, yours and his approval would simply count as just one.

Merged to master, thanks.


Destroy player

Goal
When we tried to call the method destroy() from a player instance we had memory issues with  Core, FullscreenStateHandler and DragDetectorView that were not deallocated.
Before:

After:

How to test
Download the patch, and apply it by running the command git apply {patch file}
With this patch, you will be able to open Clappr sample, disable the option of enter fullscreen and play the video many times creating new instances with the button to make sure that everything is being deallocated.

 Leak de Memória no Player - Issue #49


Fix link to auth0.com in README

The README currently links to https://github.com/auth0/node-jsonwebtoken/blob/master/auth0.com rather than https://auth0.com.

Good catch @jas, thanks!


Missing ability to set text direction on html element (dir=ltr/rtl) of preview frame

Clear and concise description of the problem
Hi,
I'm developing in a project which relies on rtlcss to get correct text/page flow in arabic.
The stylesheets are transformed so that every property depending on right/left alignments have a selector like
For example:
.sel { margin-left: 16px; }

results in
[dir="ltr"] .sel { margin-left: 16px; }
[dir="rtl"] .sel { margin-right: 16px; }

This requires me to be able to set the dir attribute on the <html> element of the page the component is viewd in.
Suggested solution
The simplest solution could be to add a block htmlAttrs similar to nuxt to the histoire config.
This would allow to add other parameters linke lang, etc. as well.
Alternative
A premium solution ❤ would be to have a config option to enable "LTR/RTL" rendering which could allow the user to toggle text direction globally for all component previews.
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

As a temp workaround in our project I'm wrapping the component so that I have a button to toggle the text direction rendered below the actual component.
So I had the idea to another more flexible solution: Adding a dir attribute to a Variant
This could maybe enable a toggle button in the control panel to switch the direction on a per-component-basis like so:
<script setup lang="ts">
import LTRComponent from './LTRComponent.vue';
</script>

<template>
  <Story title="LTRComponent">
    <Variant title="default" dir="rtl" :allow-toggle="true" >
      <LTRComponent />
    </Variant>
  </Story>
</template>

A quick Sidenote: I found that some of our components (using external libraries) need to have the dir attribute to be present during mount and will not behave correctly if the attribute is changed later. So I'm forcing a re-render of the component as well in my wrapper by unmounting and remounting it.

We could have a button in the toolbar to toggle text direction, like Ladle:

This would be fantasic!

Please give a feature flag when adding that sort of thing, not everybody needs or wants this.
Thanks in advance.


Editor runs slowly when working with big maps

I've been using Ogmo Editor 3 to make a metroidvania-style game with a very large map (about 5000px by 13000px). As the map's gotten bigger and more populated, the editor has started to run so slow it's almost unusable. In particular, resizing large entities (e.g. an entity that's 500px by 6000px) causes it to hang for a long time. It seems to affect both PC & Mac builds.

I did a quick test with a dummy 5000px by 13000px map and it ran ok (tested a few tile operations + resizing huge entities). So either my level is too simple or my machine handles it better. To dig further:

Can you share the project and level? If privacy is a concern you can make a dummy version or replace assets by placeholders - as long as it causes the same lags on your end.
Is the entire Ogmo window running slow constantly, or does it only slow down during specific actions? Can you add more details?
If we still can't mirror the issue using 1 and 2 then we could use profiler reports (ex: https://help.figma.com/hc/en-us/articles/360041468414-Record-a-Chrome-Performance-Profile) to find the bottlenecks.

Sorry I didn't get back to this sooner. Here's the project file and map in question: https://drive.google.com/file/d/1k_enUCfh-H0YVblGXzW44vBoNrKtUExV/view?usp=sharing
It seems to slowdown the most when I resize objects and place nodes.


Changed default client to ANDROID_VR

Temporary fix for #220 #239 #242
YouTube is blocking some requests to the ANDROID_TESTSUITE client, returning the video unavailable error.
We still have several working clients, but at the moment ANDROID_VR seems to be working best for our purposes so it will be used as the default client.
Why use ANDROID_VR?
WEB-based clients need the signature cipher, we can do it but it is slow. IOS clients do not have progressive streams, that is, the audio and video are in separate files. Some ANDROID variations work well, but may cause false error detections. And the TV client does not play videos that cannot be embedded.
Changes to this PR

Changing the default ANDROID_TESTSUITE client to ANDROID_VR.
Changing the WEB login client to MWEB (due to the use of the WEB PoToken).
Now the user will receive a message informing the need for PoToken for clients who need it.

Tested here and it is working!

I have also tested this and it is working for me too!


[BUG] Storage: Confusing error message returned when user delegation key interval is invalid

Describe the bug
I am seeing this message intermittently with what should be a valid user delegation key period (exactly 7 days), but perhaps isn't due to clock skew. And I am also seeing it with a clearly invalid key key period (e.g., 9 days).
The error message could be confusing to customers as it doesn't indicate what the problem is. A few customers have been confused by this:
https://github.com/Azure/azure-sdk-for-net/issues/12595
https://www.nuomiphp.com/eplan/en/419091.html
Expected behavior
An error message that indicates that the user delegation key period is invalid.
Actual behavior (include Exception or Stack Trace)
{"The value for one of the XML nodes is not in the correct format.\nRequestId:6f914103-b01e-0132-539c-d826ec000000\nTime:2020-12-22T19:54:03.5264336Z\r\nStatus: 400 (The value for one of the XML nodes is not in the correct format.)\r\nErrorCode: InvalidXmlNodeValue\r\n\r\nAdditional Information:\r\nXmlNodeName: 2020-12-29T19:54:04Z\r\nXmlNodeValue: 2020-12-29T19:54:04Z\r\n\r\nHeaders:\r\nx-ms-request-id: 6f914103-b01e-0132-539c-d826ec000000\r\nx-ms-client-request-id: 18c14232-1b8c-4a6e-b334-b51dd6ddfc93\r\nx-ms-version: 2020-02-10\r\nx-ms-error-code: InvalidXmlNodeValue\r\nContent-Length: 348\r\nContent-Type: application/xml\r\nDate: Tue, 22 Dec 2020 19:54:02 GMT\r\nServer: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0\r\n"}
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

Create a user delegation key with an invalid period, e.g.:
     UserDelegationKey userDelegationKey =
         await blobServiceClient.GetUserDelegationKeyAsync(DateTimeOffset.UtcNow,
                                                           DateTimeOffset.UtcNow.AddDays(9));

Run and view error.

Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.7.0]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
IDE and version : Visual Studio 16.8.3

Thank you for your feedback.  Tagging and routing to the team best able to assist.  Please be aware that due to the holidays, responses may be delayed.

Unfortunately this is the exact error message we receive from the service and not from the SDK. I can see why that would be the correct error message for 9 days since you can only specify the key to be valid for a period of up to seven days. I think it would be more clear if the message was along the lines of "The set expirey time is not a valid value" since it would go over the amount. If they specify exactly 7 days it could get affected by the time skew so then it should also have a similar message.
I will log a backlog item for the 9 days message being confusing.
If possible if you received the error when you tried 7 days, could you send me the error log including the x-ms-request-id so I can properly see what's happening with the exact time we are sending and see why we're getting that error back? Thanks

Unfortunately this is the exact error message we receive from the service and not from the SDK. I can see why that would be the correct error message for 9 days since you can only specify the key to be valid for a period of up to seven days. I think it would be more clear if the message was along the lines of "The set expirey time is not a valid value" since it would go over the amount. If they specify exactly 7 days it could get affected by the time skew so then it should also have a similar message.
I will log a backlog item for the 9 days message being confusing.
If possible if you received the error when you tried 7 days, could you send me the error log including the x-ms-request-id so I can properly see what's happening with the exact time we are sending and see why we're getting that error back? Thanks

Received request-id offline. Looks like after some investigation that there's a time skew, and it might be causing it by a second. Which is why the error is being thrown because it thinks we are handing it a value over the 7 day limit. We can either try to round down DateTimeOffset by a second, but it might mess with the already successful 7 day conversion. So we will have to see if there's a way to have DateTimeOffset to round down instead of up when converting DateTimeOffset to the 7 day value from the current time and date.

Received request-id offline. Looks like after some investigation that there's a time skew, and it might be causing it by a second. Which is why the error is being thrown because it thinks we are handing it a value over the 7 day limit. We can either try to round down DateTimeOffset by a second, but it might mess with the already successful 7 day conversion. So we will have to see if there's a way to have DateTimeOffset to round down instead of up when converting DateTimeOffset to the 7 day value from the current time and date.

@amnguye - I'm not sure how to remove the no-recent-activity label. Adding activity so this doesn't get closed if you're still investigating.

Yeah I'm not sure why the bot did that, considering this isn't even a PR. but looks like commenting on the issue removes the tag :)

@tamram ,
Yes, we also ran into same issue and error message is clearly confusing. Ideally it should show "An error message that indicates that the user delegation key period is invalid."
rather than it's giving big message with xml....  and later narrowdown problem is caused by adding more than 7 days.
Below documentation which tells max duration is 7 days:
https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-user-delegation-sas-create-cli#use-microsoft-entra-credentials-to-secure-a-sas
Regards,
Vishwa

Hi @tamram, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


Avoid generating numeric null partition values on Databricks 10.4 [databricks]

Fixes #8727.
Databricks 10.4 is missing the fix from SPARK-39417, so test_column_add_after_partition can NPE even for a CPU-only Spark session if it generates null values in a numeric partition.  This updates the test to avoid generating numeric null partition values on Databricks 10.4.

build

Premerge failed due to #8726.  Verified that this test passed on Databricks 10.4, so admin merging to unblock Databricks CI for the fix for #8726.


Use try_from instead of as

This change is

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a7be26c) 70.92% compared to head (1b3be68) 70.81%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

...ve_blockifier/src/py_transaction_execution_info.rs
0.00%
3 Missing :warning:

crates/blockifier/src/fee/fee_checks.rs
75.00%
0 Missing and 2 partials :warning:

crates/blockifier/src/execution/entry_point.rs
88.88%
0 Missing and 1 partial :warning:

crates/blockifier/src/state/cached_state.rs
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   70.92%   70.81%   -0.11%
==========================================
  Files          59       59
  Lines        7346     7404      +58
  Branches     7346     7404      +58
==========================================
+ Hits         5210     5243      +33
- Misses       1722     1747      +25
  Partials      414      414

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Design proposal: Initiate withdrawals on the Stacks chain

Background
Marvin created a proof of concept for sBTC 0.1 in which withdrawals are initiated on the stacks chain here: https://github.com/Trust-Machines/stacks-sbtc/pull/595
For Mini it has turned out to be simpler to initiate withdrawals on Stacks, and we suspect that the final design would be simpler if that also were the case.
Let's explore the following three options

Option 0: Don't change the design
Option 1: Support initiating withdrawals on Stacks alongside bitcoin operations
Option 2: Only support initiating withdrawals on Stacks

Definition of done
We have decided on one of the options above and updated the design in line with that option, as well as provide an explanation in the design for the interested reader motivating the design.

I think for Mini it might make sense to do whatever is faster (taking the MVP approach of Mini).
For the final system, it will help to support just Bitcoin-only withdrawals. We should assume that there will be some custody providers or wallets that can interact with Bitcoin but can't interact with Stacks L2 (at least in the initial months/years after Nakamoto release). So supporting Bitcoin-only deposits and withdrawals helps increase the potential use case of sBTC (folks on such wallets/custodians can also participate).

sBTC DR 0.1 (alpha romeo) support Bitcoin-originated withdrawals only


Added button initializers

Added multiple initializers for SwiftUI Button.

Hi @StevenSorial. I see that some tests are failing. When I try to run them locally, I get "Command AppIntentsSSUTraining failed with a nonzero exit code". How can I run them on my machine to ensure everything is working correctly?

try to rebase your branch on the latest stable.

I just rebased on the latest stable branch and I’m still getting the same error.

I get "Command AppIntentsSSUTraining failed with a nonzero exit code"

This is the error I'm also seeing. seems to be a familiar issue.  https://forums.developer.apple.com/forums/thread/732535

@Rspoon3  I'm open to merging the PR if the test build issue is solved.
I've found that this piece of code is the problem:
    @available(iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0, *)
    struct OrderSoupIntent: AppIntent {
        static var title = LocalizedStringResource("Order Soup")
        static var description = IntentDescription("Orders a soup from your favorite restaurant.")

        init() { }

        func perform() async throws -> some IntentResult {
            return .result()
        }
    }

@StevenSorial I removed the problematic code. Seems like this is now good to merge in.

@Rspoon3 can you please look into #63 and see if we have the same issue with these new initializers?
if you take a look at /Applications/Xcode-15.4.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/SwiftUI.framework/Modules/SwiftUI.swiftmodule/arm64-apple-ios.swiftinterface you will see that some of these initialzers should be marked with @_disfavoredOverload

@StevenSorial Great callout, I had no idea about this. I just pushed the change.

@StevenSorial Is there anything else that needs to be done here? It would be great it we can get this merged in.


Sort variables based on the order in the code files

Hello,
Thanks for this tool, it really helps. What I would like to see as a feature is to be able to sort variables based on the order they are found in the code files eg. in the main.tf. There are sometimes where I want to "group" variables based on the resource type.
For example let's assume that I have an AWS S3 module. I might have a logical block inside main.tf that defines all IAM resources before the actual AWS S3 resource. Sorting variables in this order enhances navigation in the variables.tf file especially when you have multiple types of Terraform resources.
I understand this is a huge and time consuming implementation but if you think there is a fit in this project, I could help with that.

@sfenman I appreciate your idea and recognize the effort it would take to bring it to fruition.
However, given my current workload, I must prioritize my primary responsibilities.
If you have the opportunity and inclination to work on this initiative, I encourage you to do so, and I am open to any possible contributions you may have.

Hi @AlexNabokikh , I would like to work on this.


JsErrorScriptException (0x30001) "Debug Failure" upgrading to 2.7.1

Hello,
trying to upgrade the compiler from 2.6.2 to 2.7.1, tsc.exe is now crashing when compiling:

Script failed with error: 'JsErrorScriptException (0x30001)'.
Debug Failure.
Error: Debug Failure.
at fail (Unknown script code:2341:13)
at checkUnusedClassMembers (Unknown script code:35757:29)
at checkUnusedIdentifiers (Unknown script code:35643:29)
at checkSourceFileWorker (Unknown script code:37913:21)
at checkSourceFile (Unknown script code:37891:13)
at getDiagnosticsWorker (Unknown script code:37945:17)
at getDiagnostics (Unknown script code:37934:17)
at Anonymous function (Unknown script code:59858:17)
at runWithCancellationToken (Unknown script code:59834:17)
at getSemanticDiagnosticsForFileNoCache (Unknown script code:59848:13)

I see there are a lot of other threads about this error, but I don't see any relevant with my scenario.
I believe something broke with the new tsc.exe.
What information can I provide to help you finding the root cause?
Please, contact me privately (marcomu) since I can't paste internal code.
Thanks,
Marco

Duplicate of https://github.com/Microsoft/TypeScript/issues/21491. Fix should be in typescript@next today and in the upcoming<EMAIL_ADDRESS>expected in a week or so.

Ah cool, I can confirm that without noUnusedLocals it builds fine.
Thanks!


Route 2 viridian forest

See issue #108 and #120 (Only Route 2 is done as of now)

Both Viridian Forest and Route 2 are included in game as of the latest commit in this branch


Optifine Connected Textures Issue

When using Optifine with this mod, connected textures such as glass and sandstone will not connect. I only tested this on 1.16.5 and I'm not sure if it is an issue on other versions.

I have this problem too.


Fix for chmod for 777 for testrunner cleanup

This issue was originally reported by @suseclee:

After running chmod -R 777 {workspace} from "testrunner --cleanup",
all file permissions are changed under skuba, then git picked up on
777 changes.

iirc this is addressed so closing this here


login mock up complete and about us mock up in progress

i noticed my footer was not staying at the bottom so I think that is fixed now
I started on the about us page but I am not done yet

Still a Work in progress So i marked the PR as a draft!

I have not done vnu checks for my pages. I forgot the professor gave us the website version of the html checker too if you are having trouble with the command-line version. Check under week 4 for links.

Bookmark the W3C Markup Validation Service.
Install the command-line version of the Nu Html Checker.


Update browser test variables ID

What does this PR do?
Update variables IDs in config.variables for Synthetics browser tests. Currently this is not done and the tests creation fails when there is a global variables used.
Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
Manually building and testing the tool.
Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.

/merge

/merge -c


[Bug]: Trying to create-workload in Amazon OpenSearch Serverless results in a HTTP 404

Describe the bug
I'm trying to create a workload from an existing Amazon OpenSearch Serverless Collection. However the create-workload command fails with

[ERROR] Cannot create-workload. NotFoundError(404, '').

To reproduce

Create an Amazon OpenSearch Serverless Collection & Index some data
Verify that the data is there and the index exists:
GET https://<COLLECTION_ID>.us-east-1.aoss.amazonaws.com:443/vehicles/_count returns the correct number of documents
Verify that environment is setup correctly:

❯ env | grep OSB
OSB_SERVICE=aoss
OSB_AWS_ACCESS_KEY_ID=<REDACTED>
OSB_AWS_SECRET_ACCESS_KEY=<REDACTED>
OSB_AWS_SESSION_TOKEN=<REDACTED>
OSB_REGION=us-east-1

try to create a workload:

  opensearch-benchmark create-workload \
--workload="vehicles-serverless" \
--target-hosts="https://ffufobrvhubbt0xh7it7.us-east-1.aoss.amazonaws.com" \
--client-options="amazon_aws_log_in:environment" \
--indices="vehicles" \
--output-path="."

fails with

[ERROR] Cannot create-workload. NotFoundError(404, '').

Expected behavior
The workload gets created as it would be with a "non-serverless" OpenSearch Domain
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
❯ python --version
Python 3.11.7
❯ opensearch-benchmark --version
opensearch-benchmark 1.10.0
❯ sw_vers
ProductName:		macOS
ProductVersion:		14.7
BuildVersion:		23H124

Additional context
No response
Relevant log output
2024-10-16 14:33:00,308 -not-actor-/PID:12199 opensearch WARNING GET https://<COLLECTION_ID>.us-east-1.aoss.amazonaws.com:443/ [status:404 request:0.371s]
2024-10-16 14:33:00,308 -not-actor-/PID:12199 osbenchmark.benchmark ERROR A fatal error occurred while running subcommand [create-workload].
Traceback (most recent call last):
  File "<DIR>/.venv/lib/python3.11/site-packages/osbenchmark/benchmark.py", line 974, in dispatch_sub_command
    workload_generator.create_workload(cfg)
  File "<DIR>/.venv/lib/python3.11/site-packages/osbenchmark/workload_generator/workload_generator.py", line 39, in create_workload
    info = client.info()
           ^^^^^^^^^^^^^
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/client/utils.py", line 176, in _wrapped
    return func(*args, params=params, headers=headers, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/client/__init__.py", line 308, in info
    return self.transport.perform_request(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/transport.py", line 458, in perform_request
    raise e
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/transport.py", line 419, in perform_request
    status, headers_response, data = connection.perform_request(
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/connection/http_urllib3.py", line 308, in perform_request
    self._raise_error(
  File "<DIR>/.venv/lib/python3.11/site-packages/opensearchpy/connection/base.py", line 315, in _raise_error
    raise HTTP_EXCEPTIONS.get(status_code, TransportError)(
opensearchpy.exceptions.NotFoundError: NotFoundError(404, '')

Will take a look into this


SQLServer (%03) field name throws an error

(%03) filed returns an unsupported character ) error. This error is most likely thrown by the Python code

Error is identified. It is happening in pytds when formatting params 👉  operator % params. We have not identified an easy implementation that won't require some intricate logic.
It is also to be noted that as a best practice column names should not have spaces or special characters in their name.
We'll put this issue in the backlog to focus on higher priority.


Remove unnecessary didRegisterUserNotificationSettings implementation, which did break cordova-local-notifications-plugin as a side effect

Problem is due to conflicting implementations of didRegisterUserNotificationSettings that prevents cordova-local-notifications-plugin from being notified of successful calls to registerUserNotificationSettings.
If implementing didRegisterUserNotificationSettings does indeed become necessary, consider using some common notification mechanism such as the one at https://github.com/katzer/cordova-common-registerusernotificationsettings to avoid conflicts with other plugins.
Fixes phonegap/phonegap-plugin-push#183 and katzer/cordova-plugin-local-notifications#695

+1 for merging this! Having this same problem now that we are forced to use the new phonegap-plugin-push plugin.

Agreed. +1 to merge this ASAP.

Much thanks to @EdMcBane

Thank you for the quick merge!

That's what open source is all about.

:+1:


I want to add all the railway station of the india.

✨ Feature Request
Description of the Feature
I want to add all the railway station of the india in Station's section.
Problem Statement
It has limited stations.
Proposed Solution
I have data of all the station available in india.

[x] Yes

Want to work on this issue.

Also participating in hacktoberfest.

Please add level3 tag for the issue.

it will be great if you add this using API and also keep sorting according to state remains same

please add level3 tag to the issue!

please add level3 tag to the issue!

level on issue not matters that much


Overwrite console.log/debug/error/warn/info methods

This will allow to easily integrate this logger into an existing project

I don't know if it's a really good idea...


refactored review_filters and agencies_locations to point to api-redux

BM-119 #done
@purplyrocky can you give this a code review when you have a chance please?

👍


JF_USER is undefined

Describe the bug
I created a setup of yarn2 using the workflow you guys provided. And it's seems like JF_USER is undefined even tho it's set up.
To Reproduce
Just do your starter flow
Expected behavior
The run will go as planned
Screenshots

Versions

Frogbot version: v2.3.2
Operating system: Linux (runner)
JFrog Artifactory version:
JFrog Xray version (version 3.29.0 or above is required):

Additional context
I looked in your code I didn't see any place that you are setting up JF_USER in your env.
I also tried to supply JF_USER in:

workflow context
job context
action context

Hi @yarinsa, thank you for informing us about this issue.
Can you please share the YAML file that you used?

Frogbot workflow yml
name: 'Frogbot Scan Pull Request'
on:
pull_request:
types: [opened, synchronize]
permissions:
pull-requests: write
contents: read
jobs:
scan-pull-request:
runs-on: self-hosted
# A pull request needs to be approved, before Frogbot scans it. Any GitHub user who is associated with the
# "frogbot" GitHub environment can approve the pull request to be scanned.
environment: frogbot
env:
JF_URL: ${{ secrets.JF_URL }}
JF_USER: ${{ secrets.JF_USER }}
JF_PASSWORD: ${{ secrets.JF_PASSWORD }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
persist-credentials: false
  # Install prerequisites
  - uses: actions/checkout@v3
    with:
      repository: transmit-poc/setup-yarn
      token: ${{ env.GH_TOKEN }}
      path: setup-yarn

  - name: Setup Yarn
    uses: ./setup-yarn
    with:
      artifactory_user: ${{ env.JF_USER }}
      artifactory_password: ${{ env.JF_PASSWORD }}
      node_version: 16.13.1

  # - run: rm .yarnrc.yml
  - uses: actions/checkout@v3
    with:
      repository: transmit-poc/frogbot
      token: ${{ env.GH_TOKEN }}
      path: frogbot
      ref: v2

  - name: Run Frogbot
    uses: ./frogbot
    env:
      # [Mandatory]
      # The command that installs the dependencies
      JF_INSTALL_DEPS_CMD: 'yarn install'

      # [Mandatory]
      # JFrog platform URL (This functionality requires version 3.29.0 or above of Xray)
      JF_URL: ${{ secrets.JF_URL }}

      # [Mandatory if JF_ACCESS_TOKEN is not provided]
      # JFrog username with 'read' permissions for Xray. Must be provided with JF_PASSWORD
      JF_USER: ${{ secrets.JF_USER }}

      # [Mandatory if JF_ACCESS_TOKEN is not provided]
      # JFrog password. Must be provided with JF_USER
      JF_PASSWORD: ${{ secrets.JF_PASSWORD }}

      # [Mandatory]
      # The GitHub token automatically generated for the job
      JF_GIT_TOKEN: ${{ secrets.GH_TOKEN }}

      # Uncomment the below options if you'd like to use them.

      # [Optional, default: https://api.github.com]
      # API endpoint to GitHub
      # JF_GIT_API_ENDPOINT: https://github.example.com

      # [Mandatory if JF_USER and JF_PASSWORD are not provided]
      # JFrog access token with 'read' permissions on Xray service
      # JF_ACCESS_TOKEN: ${{ secrets.JF_ACCESS_TOKEN }}

      # [Optional, default: "."]
      # Relative path to the project in the git repository
      # JF_WORKING_DIR: path/to/package.json/dir

      # [Optional]
      # Xray Watches. Learn more about them here:
          https://www.jfrog.com/confluence/display/JFROG/Configuring+Xray+Watches
      # JF_WATCHES: <watch-1>,<watch-2>...<watch-n>

      # [Optional]
      # JFrog project. Learn more about it here: https://www.jfrog.com/confluence/display/JFROG/Projects
      # JF_PROJECT: <project-key>

      # [Optional, default: "FALSE"]
      # Displays all existing vulnerabilities, including the ones that were added by the pull request.
      # JF_INCLUDE_ALL_VULNERABILITIES: "TRUE"

We had to fork the bot to our organization as we are not installing actions that are not verified, so we security review and fork, but its the exact same code as you guys (no change)
Setup yarn for me is a custom action trying to deal with the difference of authenticating with jfrog:
For example:
using api_key & user (our local setup)
yarn config set npmAuthIdent user:api_key
using password & user (CI setup)
yarn config set npmAuthIdent (user:password | base64)
Setup yarn
# action.yml
name: "Setup Yarn"
description: "Initial setup for yarn with artifactory credentials"
branding:
  icon: "package"
  color: "gray-dark"
inputs:
  artifactory_user:
    description: "Artifactory user name (usually company email)"
    required: true
  artifactory_password:
    description: "Artifactory password (ApiKey can be used for fetching artifacts only)"
    required: true
  node_version:
    description: "Artifactory password"
    required: false
    default: 16.13.1

runs:
  using: composite
  steps:
    - name: Setup Node.js
      uses: actions/setup-node@v3
      with:
        node-version: ${{ inputs.node_version }}

    - name: escape undefined variables
      shell: sh
      run: |
        echo "JF_API_KEY=${{ inputs.artifactory_password }}" >> $GITHUB_ENV
        echo "JF_PASSWORD=${{ inputs.artifactory_password }}" >> $GITHUB_ENV
        echo "JF_USER=${{ inputs.artifactory_user }}" >> $GITHUB_ENV
    - name: Setup credentials # Currently tests and compatible with Yarn2+
      shell: sh
      run: |
        corepack enable
        yarn config unset npmAuthIdent
        yarn config set npmAuthIdent $(echo -n '${{ inputs.artifactory_user }}:${{ inputs.artifactory_password }}'| base64)
    - name: Retrieve Yarn Cache
      id: yarn-cache-dir-path
      shell: sh
      run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

    - uses: actions/cache@v3
      id: yarn-cache
      with:
        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
        key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
        restore-keys: |
          ${{ runner.os }}-yarn-
    - name: Install dependencies
      shell: sh
      run: yarn install --immutable

I didn't see any reference of you guys setting this up in the action env here

Thanks, @yarinsa for the detailed information. We do set this env here:
https://github.com/jfrog/frogbot/blob/9304d3b1d8e05a1b5fc0ba9ebf9ffbd495386250/commands/utils/params.go#L91
Could you please run this again with debug logs? Please add the following environment variable to Frogbot on Github:
JFROG_CLI_LOG_LEVEL
With value:
DEBUG

@omerzi I ended up using "yarn audit" which access jfrog x-ray anyway

@yarinsa I'm glad that it worked for you, and thank you for the feedback! It would be greatly appreciated if you could help us understand this issue better, so we can take the right steps moving forward. Have you used the JFrog CLI command 'audit yarn' to fix it?

nope. I fixed them manually , as for the log level, will do and update here


[BUG] Special French characters in HTML elements break Playwright

System info
Playwright Version: [v1.30]
Operating System: [All, Windows 11, macOS 13.2, etc.]
Browser: [Chromium]
Other info:
Source code
I provided exact source code that allows reproducing the issue locally.
Link to the GitHub repository with the repro
[https://github.com/your_profile/playwright_issue_title]
or
Config file
Library used for Playwright Object
import com.microsoft.playwright.Playwright;
In code below : playwrightObjects is a class which contains Playwright object
Page page = playwrightObjects.getPage();
Here addInitScript is a function of playwright that uses the JSON file to merge values in the document
page.addInitScript(Paths.get());
Below code specifies the addInitScript function of Playwright
@Override
public void addInitScript(Path path) {
withLogging("Page.addInitScript", () -> {
try {
byte[] bytes = readAllBytes(path);
addInitScriptImpl(new String(bytes, UTF_8));
} catch (IOException e) {
throw new PlaywrightException("Failed to read script from file", e);
}
});
Below code specifies the addInitScriptImpl function of Playwright
private void addInitScriptImpl(String script) {
JsonObject params = new JsonObject();
params.addProperty("source", script);
sendMessage("addInitScript", params);
}
Sample JSON file used
{
"Success_x0020_Factors": "<div class="ExternalClass4EC3B32FDF9E4AFD95F5327AD74B57B7">L’entente prévoit aussi un paiement forfaitaire unique de 2500 $ ouvrant droit à pension qui représente 3,6 % de plus du salaire du membre moyen.TEST Dans son propre communiqué, l’Agence du revenu du Canada déclare qu’avec le syndicat, elle a conclu une entente de principe sur le télétravail en dehors de la convention collective. Les deux parties entreprendront un examen de la directive sur les modalités de travail virtuel et vont créer un comité-conseil qui abordera les préoccupations des employés",
"Title": "Test PPB 1"
}
Expected
Playwight should provide support for french characters.
Actual
Special characters in French, such as è, é, è, ê, à, â, ë, ï, î, ô, û, ç, œ, ù, ÿ and >> are not recognized by Playwright.
It break the Playwright parser and make these elements on the page not accessible.
We do not get any exception here but the file that comes here is blank i.e without merging the JSON values.
Please Note : This issue is affecting the functionality, so it would be greatly appreciated if we could resolve it as soon as possible. We are expecting to close this issue by 3rd July considering the criticality of it.

Linked issue : https://github.com/microsoft/playwright-java/issues/1328

Unfortunately I have to close this one again since there was no minimal reproducible attached. We need a script / Java file which we can run locally. See here how to create one: https://stackoverflow.com/help/minimal-reproducible-example
Ideally by following our getting started and then do something / have steps which produces actual/expected outcomes.
Thanks for your understanding.


feat: introduce build assertions and validate passwd and group files

Add support for assertions to check the result of the build context.
As an example, two assertions are added to check whether /etc/passwd and /etc/group are (optionally) present.

This looks really nice!  Once you introduce the multierrors stuff, I think we can merge it.


Schema changes for 4/9 data

@glw Can you confirm?
trails
Added:

[ ] hiking
[ ] biking
[ ] cross_country
[ ] equestrian
[ ] no_dogs (will be included on 4/10 update)
[ ] dogs_leash (will be included on 4/10 update)
[ ] trail_subsystem_id
[ ] trail_name

trails_desc
Added:

[ ] hours1
[ ] hours2
[ ] season1
[ ] season2
[ ] special_hours

points_of_interest
Added:

[ ] fitness_stairs

Removed:

[ ] recreation_center

All done!

@glw Can you confirm?
trails
Added:

[x]  hiking
[x]  biking
[x]  cross_country
[x]  equestrian
[x]  no_dogs (will be included on 4/10 update)
[x]  dogs_leash (will be included on 4/10 update)
[x]  trail_subsystem_id
[x]  trail_name

trails_desc
Added:

[x]  hours1
[x]  hours2
[x]  season1
[x]  season2
[x]  special_hours

points_of_interest
Added:

[x]  fitness_stairs

Removed:

[ ]  recreation_center

all on staging


Review hero colliders and collisions

Review player colliders and collisions and move them to enemies

Related: https://github.com/maykelsb/Unstable/issues/28


Fix unreliable test behaviour when using hypothesis

On this PR the CI fails because the timing of the test execution is so variable. This fixes PR fixes the issue.
Also fixes a bug where some steps were no longer running since we introduced the new runners.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@bcdurak @safoinme sorry for the spam in this review... all the '2024' changes were pulled in from the templates update


introducing a help command

I was asked to add a help mechanism to list all currently supported scpi commands. Hopefully I haven't overlooked another implementation somewhere.  I'd love to hear your thoughts on the approach described below. I feel it's a trade-off between conformity and readability.
Here's what the user sees in a PuTTY session:

The implementation is rather straight-forward:
static scpi_result_t My_HelpQ(scpi_t * context) {
    int i = 0;
    for(;;){
        SCPI_ResultCharacters(context, "\r\n", 2);
        SCPI_ResultMnemonic(context, scpi_commands[i].pattern);
        if(scpi_commands[++i].pattern == NULL){
            break;
        }
    }
    return SCPI_RES_OK;
}

const scpi_command_t scpi_commands[] = {
    {.pattern = "HELP", .callback = My_HelpQ,},
    {.pattern = "HELP?", .callback = My_HelpQ,},
// ...

Now I would expect the pattern strings would need to be returned in quotes, but then again it's most likely a human operator that opened the connection exclusively, so one would in turn even want to do away with the comma separation.
Going one step further even, one might be tempted to add short description strings where commands are not completely clear to the new user, and print them next to the listed commands.
_scpi_command_t  would need to be changed to
    struct _scpi_command_t {
        const char * pattern;
        scpi_command_callback_t callback;
#if USE_COMMAND_TAGS
        int32_t tag;
#endif
#if USE_COMMAND_DESCRIPTIONS
        const char * description;
#endif
    };

SCPI-99 is standard with some fixed structure of requests and responses. Even if it has text commands, it is not supposed to be used by humans directly.
E.g. exactly one newline character at the end of the command is expected and exactly one newline character is expected in the response. Exception os only ARBITRARY COMMAND DATA which has special header to allow any binary data, but the header also specify how much data it will contains.
Of course, you can have any nonstandard modification in your product but it is unlikely that it will be part of the library itself.

I re-implemented the HELP mechanism with block data. Still working on it a bit and cleaning up.
The optional description mechanism is backward compatible and allows informing the user which arguments are expected. Short explanations can be added to describe the exact scope and use of each command.
Some PC tools allow sending raw SCPI commands. When a program uses HELP, it could use the returned list of commands to populate a drop-down box or show the command list as a table.
static scpi_result_t BSICS_HelpQ(scpi_t * context) {
    int i = 0;
    for(;;) {
        size_t pattern_len = strnlen(scpi_commands[i].pattern, 100);
        size_t block_len = 1 + pattern_len + 2;
#ifdef USE_COMMAND_DESCRIPTIONS
        size_t description_len = strnlen(scpi_commands[i].description, 100);
        block_len = 1 + pattern_len + 1 + description_len + 2;
#endif
        SCPI_ResultArbitraryBlockHeader(context, block_len);
        SCPI_ResultArbitraryBlockData(context, "\t", 1);
        SCPI_ResultArbitraryBlockData(context, scpi_commands[i].pattern, pattern_len);
#ifdef USE_COMMAND_DESCRIPTIONS
        SCPI_ResultArbitraryBlockData(context, " ", 1);
        SCPI_ResultArbitraryBlockData(context, scpi_commands[i].description, description_len);
#endif
        SCPI_ResultArbitraryBlockData(context, "\r\n", 2);
        if (scpi_commands[++i].pattern == NULL) {
            break;
        }
    }
    return SCPI_RES_OK;
}

After looking at the delimiter question some more I think it's appropriate to harmonize SCPI_ResultArbitraryBlockHeader() by making it insert a delimiter where needed.
https://github.com/j123b567/scpi-parser/pull/134 adds this behaviour, plus some minor clean-up.  https://github.com/j123b567/scpi-parser/pull/134 becomes a prerequisite for #129.

I might have to re-write strncasestrn(), but I've got a branch with a USE_SEARCH_FILTER feature which treats an optional string in
HELP? [<string>]
as a filter to narrow down the HELP? output:

@j123b567 the HELP? enhancement has served me well in recent months. It's really convenient in the lab when setting up and verifying configurations. I don't have to worry about versions of documentation to boards I've given to colleagues either.
The search function is also merged so you can review #135 directly. Hopefully we can conclude this PR in 2022 and I can get it out of my mind ;) Looking forward to your reply.


Theme request

If you have an idea for a theme and don't know how to code, make a picture mockup and post it here, someone will help you (maybe) :)

Just came here to say, really nice dashboard :)
9Mb compressed container size is impressive. I wish I'd used Go in mine, as Node.js, even just for the HTTP server is heavy AF.
Awesome work, keep it up!

Just came here to say, really nice dashboard :) 9Mb compressed container size is impressive. I wish I'd used Go in mine, as Node.js, even just for the HTTP server is heavy AF. Awesome work, keep it up! P.s. Mind if I link to it here?

Sure thing :))) I use Deno for the first version, 20mb still quite lightweight but then I find out Deno don't support ARM so I moved to Go, I think it was a correct choice :)))


Update UploadController.php

(optional) Issue number:
Summary of the change: Encode response with JSON for Dropzone success validation when upload a file

@streamtw please help this one for auto refresh after upload

Thanks @wiklog and @imunisasi !


Add the "tests" and "errors" attributes to the "testsuite" element

The testsuite element currently generated looks like this: <testsuite hostname="Foo" name="testResults" time="0.0" timestamp="2015-08-20T16:24:17">
However, according to the XSDs used by the Jenkins xUnit plugin (which is also responsible for parsing jUnit tests), the tests attribute (counting how many tests were executed, e.g. tests="10") is required: https://github.com/jenkinsci/xunit-plugin/tree/master/src/main/resources/org/jenkinsci/plugins/xunit/types/model/xsd
Therefore, the produced XML is rejected by the xUnit plugin (in its jUnit mode).
It is also probably a good idea to add the failures and/or errors attributes too (on the testsuite element as well) to make the job easier for the plugins to figure out the success rate.

In the meantime, we've worked around this issue by employing the following PowerShell script to add the missing attributes:
[xml]$xml = Get-Content $xmlPath

$testCases = $xml.testsuite.ChildNodes | where {$_.LocalName -eq "testcase"}
echo ("Test count: {0}" -f $testCases.Count);

$failures = @($testCases | where{$_.failure})
echo ("Failure count: {0}" -f $failures.Count);

$xml.testsuite.SetAttribute("tests", $testCases.Count)
$xml.testsuite.SetAttribute("failures", $failures.Count)

$xml.Save($xmlPath);


Vovoca logo looks different on different pages

The logo of vovoca looks different on different pages. For example in the home and the about us section it is in a stylized form, where as  in the other sections such as testimonials and teams it is just plain text.
See below video for more context :
https://github.com/Deveimer/vovoca-frontend/assets/76463001/0e3bdb03-bf3e-49a5-b2db-d2a6c2ffe655
Also see the attached screenshots:
On the home and about us section

On the testimonial and teams section

I think the logo should look the same throughout the website.
@varun-singhh , what do you think about this??

yes there is an issue with logo you can fix it. @mukul314

@mukul314 are you working on this issue?

@mukul314 are you working on this issue?

yes @sumitkr2000 !

@varun-singhh please assign this issue to me. since it's been 2 week and issue is not resolved. i can resolve this more faster.

Can i also work on this issue? @varun-singhh


Automated cherry pick of #2944: fix: 避免zstack高可用关机失效问题

Cherry pick of #2944 on release/2.12.
#2944: fix: 避免zstack高可用关机失效问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@0f4caab). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #2945   +/-   ##
==============================================
  Coverage                ?   7.06%
==============================================
  Files                   ?     477
  Lines                   ?   76389
  Branches                ?       0
==============================================
  Hits                    ?    5396
  Misses                  ?   70541
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.06% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4caab...0322563. Read the comment docs.

/approve
/lgtm


Validations and Model Specs Completed

I have completed implementing validations and models specs on branch 'validations-and-specs'

The following validations were added:

- For the User model:

Name must not be blank.
PostsCounter must be an integer greater than or equal to zero.

For the Post model:

Title must not be blank.

Title must not exceed 250 characters.

CommentsCounter must be an integer greater than or equal to zero.

LikesCounter must be an integer greater than or equal to zero.

Unit specs were added for model methods and validations.

All tests and linters passed

Thanks. 😄


binary string

I am no python whiz, however it appears to me a simple 'b' on line 44 of fping_mtr.py will match the correct binary string.
44             if host != b"*":

hi @helpdeskdan
We have pushed a fix for the issue at a separate spot in #135 - i missed that we are checking the host already and its not getting caught, thanks for pointing it out. Will revisit this ticket before we do the next release.

  Forgive me if I misunderstand, I will document for anybody else who runs across this.

>>> line = b'starswithjunk *'
>>> host = line.split()[1]
>>> host
b'*'
>>> host == '*'
False
>>> host == b'*'
True
>>>

The return is already anticipating that the string could be binary string or not, but the if statement does not.

        try:
            host = line.split()[1]
            if host != "*":
                try:
                    return host.decode("ascii")
                except AttributeError:
                    # No `decode` on `str` in py3
                    # assume already decoded str
                    return host

Thus, looking at the other bug, I suggest a more complete solution might be:

if not host in ['*',b'*','\n',b'\n']:

Thanks for your continued work on this project

                try:
                    return host.decode("ascii")
                except AttributeError:
                    # No `decode` on `str` in py3
                    # assume already decoded str
                    return host

This looks like left over cruft from when vaping was supporting py2.7, what version of vaping and what version python are you running @helpdeskdan ?

The fix pushed in https://github.com/20c/vaping/commit/fe9aada2d2cb1a7cbf95889c38a5b2c2161c29ed addresses an issue of mtr not playing well when "*"  is returned for the host (see #135), but that assumes py3+ which is all that python supports at this point.

There is much to remember in python2 vs 3.  I'm afraid you have it backwards - popen returns bytes in python3 and strings in python2.   By all means, don't take my word for it, throw a debug in there & print the host right after the split so you can see the 'b' yourself.

╭─dan@dan-OptiPlex-7020 ~
╰─$ python3 --version                                                     127 ↵
Python 3.8.10
╭─dan@dan-OptiPlex-7020 ~
╰─$ vaping --version
vaping, version 1.4.3
╭─dan@dan-OptiPlex-7020 ~
╰─$ python --version
zsh: command not found: python

Or, you know, just try it quick also works:

$ python3
Python 3.8.10 (default, Sep 28 2021, 16:10:42)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import subprocess
>>> print(subprocess.Popen("echo hi", shell=True,
...     stdout=subprocess.PIPE).communicate()[0])
b'hi\n'
>>>

There is much to remember in python2 vs 3. I'm afraid you have it backwards

Haha so i do - i stand corrected :) will take a look soon, thanks.


more than 64G  while the List partitions = mMassStorageDevices[0]. GetPartitions ();Partitions =null

When the storage space of the usb flash disk is greater than 64G, the List partitions = mMassStorageDevices[0]. GetPartitions ();Partitions =null, what happens?

Can you give some more information?
64GB should not be a problem. Make sure that it is FAT32 though