Perform browser tests

Hi,
I tried to implement browser tests with JSPM but couldn't manage to configure it.
I tried to use the Yeoman generator or use the code from other repos but I do not understand exactly how the tests are run. I think that I was able to compile the files and start a server, but then it errored with a TypeError (substr is not defined on undefined).
For the moment, I am only running the server tests.

Is there a reason to do browser test for this?
I can't find any browser specific behavior for https://github.com/peterolson/BigInteger.js

Effectively, there is no browser-specific behavior but one of the questions of the generator is about the environment. I answered that this can be used in the browser so it tried to create tests for the browser.
Even if it should output the same result as the server tests, I hoped to see how it is implemented with this relatively simple library so then I'll be able to implement it myself for other libraries without bothering you.
If you think that the server tests are enough for this library, we can leave it this way.

I see.
I would write browser test only if the library is intended to be run on browser only or if there are any browser specific behavior (one example is aurelia-logging-color.
How to run browser test depends on which test framework you use.
With blue-tape and many others, you will probably use karma-* and pair with phantomJS or electron to make it headless.
If you are into jspm, you can take a look at https://github.com/unional/karma-systemjs-sample
It's a bit old so things may have changed a bit.
Personally I'm using ava now and also finding ways to run browser test as smooth as possible.
karma-ava is not ready and I'm using browser-env/jsdomify but I'm running into a corner case that I working right now (literally, as I'm typing this. 😛 ).

Ok, thanks for information and links to examples. 🙂
I was using jspm with the typescript plugin and blue-tape/electron. It's the first time I hear about Ava: I checked its page and it looks good, I might give it a try for a personal project.

I would write browser test only if the library is intended to be run on browser only or if there are any browser specific behavior

Ok, so I'll close this issue for the moment.


Support Druid 0.10.0

Tranquality latest version doesn't support Druid 0.10.0 latest features like numeric dimensions. Please fix the same and let me know if I can contribute.

You can contribute by continuing development in this branch: https://github.com/druid-io/tranquility/pull/233


slightly change bank wallet image on site's home

[x] under the BANK WALLET title in the image subtitle instead of "decentralized cryptocurrency wallet" add "Control Your Money!"

[x] the BANK WALLET title make it standout a bit less as it currently overlaps with the text header title for the section

[x] add static Play Market / App Store labels below the text in the image


Update 1.1 - Quickfort and DFHack

Will need to be tested. The installer is attached to the pull request.
Stuff that needs to be tested before release:

[ ] Quickfort
[x] DFHack

Teste DFHack, and it works.

Tested Quickfort, it works.


[BUG] NullPointerException during Javadoc copy

Describe the bug
Lombok does not check if the source javadoc is null. This leads to a bunch of NPE as soon as lombok tries to create a regex matcher. The exception gets catched in one of the calling methods and does not lead to a compilation error.
To Reproduce

Add a breakpoint for thrown NullPointerExceptions
Run tests

Expected behavior
Obviously there should be no exception. I also noticed that there are javadoc copy methods in HandlerUtil that only add new javadoc lines (e.g. addReturnsThisIfNeeded). Right now these methods get never called if the input is empty because of the exception. Is this intended? If not, lombok could also create the javadoc, I added an example how the result could look like.
Input
@lombok.experimental.Accessors(chain = true, fluent = true)
@lombok.Setter
class Example {
	private int fieldName;
}

Current output
class Example {
	private int fieldName;

	@java.lang.SuppressWarnings("all")
	public Example fieldName(final int fieldName) {
		this.fieldName = fieldName;
		return this;
	}
}

Possible output
class Example {
	private int fieldName;

	/**
	 * @return {@code this}.
	 */
	@java.lang.SuppressWarnings("all")
	public Example fieldName(final int fieldName) {
		this.fieldName = fieldName;
		return this;
	}
}

Version info (please complete the following information):

Lombok version: latest
Platform: all

Additional context
I can provide a PR if you let me know how lombok should handle these cases.

Right now these methods get never called if the input is empty because of the exception. Is this intended?

It's not. Bad exception handling is one of my pet peeves but I think this is my code. Whoopsie!
Sounds like lombok should do a quick null check in general (avoid the exception chain, even if that leads to the same end result of nothing happening). and in the case of lombok making up javadoc because it has something to add (such as @return {@code this}), I think we might as well add that, right? (so, change the behaviour from the current: "Does not generate @return {@code this} unless there was already javadoc to copy" to a proposed: "Will generate javadoc with just @return {@code this} in that case".

Thats what I thought too but as that needs adjustments in a bunch of test cases I don't want to waste time changing everything without asking.


Website - add download for iOS section for mobile

Task opened in Website project

There is a problem with direct download in iOS
for now it shows - coming soon


langchain.core : Use shallow copy for schema manipulation in JsonOutputParser.get_format_instructions

Description :

Fix: Use shallow copy for schema manipulation in get_format_instructions
Prevents side effects on the original schema object by using a dictionary comprehension for a safer and more controlled manipulation of schema key-value pairs, enhancing code reliability.

Issue:  #17161
Dependencies: None
Twitter handle: None

@hwchase17
Thank you for your comment! I have added test code to demonstrate a specific example that underscores the necessity of this change. The example provThank you for your contribution. I will now provide a detailed example of the specific changes required, drawn from an actual case I have encountered. This involves the use of the same Base Class in two scenarios: one utilizing an OpenAI function call and the other employing a JsonOutputParser.
class Joke(BaseModel):
    setup: str = Field(description="question to set up a joke")
    punchline: str = Field(description="answer to resolve the joke")

joke_query = "Tell me a joke."

parser = JsonOutputParser(pydantic_object=Joke)

prompt = PromptTemplate(
    template="Answer the user query.\n{format_instructions}\n{query}\n",
    input_variables=["query"],
    partial_variables={"format_instructions": parser.get_format_instructions()}, #cause
)

chain = prompt | model | parser

chain.invoke({"query": joke_query})

openai_functions = [convert_to_openai_function(Joke)]

parser = JsonOutputFunctionsParser()

chain2 = prompt | model.bind(functions=openai_functions) | parser

chain2.invoke({"query": "tell me a joke"})

In this code, chain2 triggers an error stating: openai.BadRequestError: Error code: 400 - {'error': {'message': "'' does not match '^[a-zA-Z0-9_-]{1,64}$' - 'functions.0.name'", 'type': 'invalid_request_error', 'param': None, 'code': None}}. The root cause of this error is the direct deletion of variables from the BaseModel schema via the schema() function in the get_format_instructions function, as shown below:
schema = self.pydantic_object.schema()
reduced_schema = schema
            if "title" in reduced_schema:
                del reduced_schema["title"]
            if "type" in reduced_schema:
                del reduced_schema["type"]

The use of BaseModel's .schema() function in convert_to_openai_function results in default values of "" being assigned to the name and type, leading to the aforementioned error. Although this is the only case I have identified, I believe other functions utilizing BaseModel could similarly be at risk. Furthermore, the performance impact of not using the reduced_schema object directly is negligible, not affecting practical use:
            schema_str = json.dumps(reduced_schema)
            return JSON_FORMAT_INSTRUCTIONS.format(schema=schema_str)


Sort primary keys in PathMappingCollection only when necessary.

Hi,
At the moment every call to PathMappingCollection::add()+set() sorts the primary keys of the PathMappingCollection map.
On mapping a new path to an already large repository this ends up being the most time consuming operation after path canonicalization. This PR alters PathMappingCollection to mark the primary keys sorting status as dirty on each modification. On fetch operations whose ordering relies on the primary sorting, a function is called that checks if the primary keys sorting status is dirty and sorts them if so, marking the status as clean.
Please check over the methods containing calls to lazySortPrimaryKeys() to make sure I've added it to all the methods that are affected by the primary keys being sorted.
The puli/manager test suite is currently giving me 3 failures on a fresh checkout (after composer install). This PR doesn't cause any additional failures.
The failures present on fresh checkout give the following output:
There were 3 failures:

1) Puli\Manager\Tests\Config\ConfigJsonReaderTest::testReadConfigFileFailsIfDecodingNotPossible
Failed asserting that exception of type "Puli\Manager\Api\Config\NoSuchConfigKeyException" matches expected exception "\Puli\Manager\Api\InvalidConfigException". Message was: "The config key "plugins" does not exist." at
#0 /home/tolan/ttmp/pulitest/manager/src/Api/Config/Config.php(333): Puli\Manager\Api\Config\NoSuchConfigKeyException::forKey('plugins')
#1 /home/tolan/ttmp/pulitest/manager/src/Config/ConfigJsonReader.php(46): Puli\Manager\Api\Config\Config->set('plugins', Array)
#2 /home/tolan/ttmp/pulitest/manager/tests/Config/ConfigJsonReaderTest.php(101): Puli\Manager\Config\ConfigJsonReader->readConfigFile('/home/tolan/ttm...')
#3 [internal function]: Puli\Manager\Tests\Config\ConfigJsonReaderTest->testReadConfigFileFailsIfDecodingNotPossible()
#4 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestCase.php(866): ReflectionMethod->invokeArgs(Object(Puli\Manager\Tests\Config\ConfigJsonReaderTest), Array)
#5 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestCase.php(743): PHPUnit_Framework_TestCase->runTest()
#6 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestResult.php(610): PHPUnit_Framework_TestCase->runBare()
#7 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestCase.php(699): PHPUnit_Framework_TestResult->run(Object(Puli\Manager\Tests\Config\ConfigJsonReaderTest))
#8 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestSuite.php(731): PHPUnit_Framework_TestCase->run(Object(PHPUnit_Framework_TestResult))
#9 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/Framework/TestSuite.php(731): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))
#10 /home/tolan/ttmp/pulitest/manager/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(424): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))
#11 /usr/share/php/PHPUnit/TextUI/Command.php(186): PHPUnit_TextUI_TestRunner->doRun(Object(PHPUnit_Framework_TestSuite), Array)
#12 /usr/share/php/PHPUnit/TextUI/Command.php(138): PHPUnit_TextUI_Command->run(Array, true)
#13 /usr/bin/phpunit(42): PHPUnit_TextUI_Command::main()
#14 {main}.

/usr/share/php/PHPUnit/TextUI/Command.php:186
/usr/share/php/PHPUnit/TextUI/Command.php:138

2) Puli\Manager\Tests\Package\PackageJsonReaderTest::testReadPackageFileFailsIfDecodingNotPossible
Failed asserting that exception of type "\Puli\Manager\Api\InvalidConfigException" is thrown.

/usr/share/php/PHPUnit/TextUI/Command.php:186
/usr/share/php/PHPUnit/TextUI/Command.php:138

3) Puli\Manager\Tests\Package\PackageJsonReaderTest::testReadRootPackageFileFailsIfDecodingNotPossible
Failed asserting that exception of type "\Puli\Manager\Api\InvalidConfigException" is thrown.

/usr/share/php/PHPUnit/TextUI/Command.php:186
/usr/share/php/PHPUnit/TextUI/Command.php:138

Thanks for the PR @patternseek! Could you open an issue about the test failures and include some information about your system please?

Hi,
I've updated to Puli 1.0.0-beta5 and have seen a big increase in build times, just under 4 minutes now which means it times out during Composer updates / installs.
I profiled it and it seems to be down to the issue addressed in this PR, puli build is spending 82% of its time running ksort().
Any chance of merging this PR to help with the issue?
Cheers.

The "just under 4 minutes" is actually from my lower powered laptop, on my desktop it's about 2m45. With this patch it's 2 seconds.  :dash:

Thanks for digging this out again! I completely forgot about this. Merged :)


Add ebizzy workload

Add ebizzy to allow users to run a workload resembling common
web server application workloads.
Signed-off-by: Lisa Nguyen<EMAIL_ADDRESS>

The ebizzy workload should run on both Linux and Android.


Allow implicit iteration over the root context element

This fixes #154 and generally matches Mustache.js’s behavior. Since there’s no test for this in the Mustache spec (see https://github.com/mustache/spec/issues/87), I’ve added a unit test for it.
It’d be really nice to have this added in—I recently dealt with a confusing moment when transitioning some Mustache templates that used this pattern to Hogan. If the bug is any indication, it’s tripped up others, too.

Looks like the dependencies of some of the dependencies require Node 0.10+, so Travis is no longer able to complete a build on Node 0.6, which is what is specified in the .travis.yml. I can add that to this PR if you’d like.

Anything I can do to help get this merged in? It’s been sitting for a week and a half and would be really great to have fixed.

Hi there, just checking in on this PR. Is anybody maintaining Hogan anymore?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Taking that as a sign of some more attention here, but is this PR still relevant? (I haven’t really been using Hogan in the last couple years and may not be up to speed.) Happy to sign the CLA if so.


Homebrew serves old version

When installing rust-analyzer for macOS via homebrew the listed latest version is 2021-12-06 which is three weeks old at the time of writing.

Possibility because newer versions require 1.57, which is not available in brew.
And I know it's mentioned in the manual, but I don't think that recipe is maintained by us.


version+README: update LiT and Loop versions

This commit updates the integrated Loop version to v0.26.1-beta and
bumps Lit's version to v0.10.5-alpha

I think we may also need to include https://github.com/lightninglabs/loop/pull/617 in this release.

I think we may also need to include https://github.com/lightninglabs/loop/pull/617 in this release.

Ah - ok thanks. Will there be a loop release for this?

ok cool - I think this is ready now :)

oh dang - i was wrong 🙈

Ran into an issue with Loop when testing on my node, sorting out with the Loop team.


Rust SDK generate chunks function not returning an error when the using an invalid splitter id

We need to do some checking either in the query itself, or in Rust before we perform the query to check for an invalid splitter id. Right now the function does not return an error, but no chunking is done.

Closing as this is no longer an issue after switching to pipelines


node_modules with go code causing dep ensure to error

What version of Go (go version) and dep (git describe --tags) are you using?
go version go1.8.3 darwin/amd64 / v0.3.0-147-gedc545f
What dep command did you run?
dep ensure
What did you expect to see?
...
What did you see instead?
Found 1 errors:

import path github.com/user/project/node_modules/grpc/third_party/boringssl/ssl/test/runner had local imports: "./curve25519\", \"./newhope\", \"./poly1305"

Description
We've got a gRPC javascript client (and its node_modules including grpc) co-homed with our server that has dependencies managed by dep. It looks like a change to gps introduced this issue we're seeing.
(a working SHA compared with the current one)
https://github.com/golang/dep/compare/42374f182fa164ee3041436a2d651a80ba57d2d1...edc545f323920588a8ffa78143b01aa4000cbf60

Could you try the code from #997? It should solve your issue.

Fixed in #997 - You can see the issue in the verbose log, but execution continues

I still think I should be able to tell dep not to look at node_modules ... right?

#997 is merged now. :-)

Closing this for the moment. I remember seeing a discussion about being able to define skipped files in another issue, but if you think it's worth its own, please go ahead and open a dedicated issue for that. :+1:


Swap: Dont hardcode minimum input amount

In commit https://github.com/soroswap/frontend/commit/90d8007663bea4083b7e976ab8bc96f26a3c5183
I am adding 1000000 to the minimum input amount because we are having a problem calculating it.
This won't be used when implementing the Router contract, so this is just temporal.

We are now using Router


C# Makefile Error on Windows

The following happens:
C:\Users\abreucb\Downloads\or-tools>tools\make.exe third_party
ERROR: Invalid pattern is specified in "path:pattern".
makefiles/Makefile.csharp.mk:72: Extraneous text after `else' directive
makefiles/Makefile.csharp.mk:74: *** only one `else' per conditional.  Stop.

This can be fixed by replacing lines 70-76 in Makefile.csharp.mk with the following:
ifeq "$(SYSTEM)" "win"
	NETSTANDARD_RUNTIME_IDENTIFIER=win-$(NETPLATFORM)
else
ifeq ($(PLATFORM),MACOSX)
	NETSTANDARD_RUNTIME_IDENTIFIER=osx
else
	NETSTANDARD_RUNTIME_IDENTIFIER=linux-$(NETPLATFORM)
endif
endif

Thanks !


Add Rectified linear unit layer

Current coverage is 43.90% (diff: 26.66%)

Merging #14 into master will decrease coverage by 0.44%

@@             master        #14   diff @@
==========================================
  Files            25         26     +1
  Lines           478        492    +14
  Methods         467        483    +16
  Messages          0          0
  Branches         11          9     -2
==========================================
+ Hits            212        216     +4
- Misses          266        276    +10
  Partials          0          0

Powered by Codecov. Last update 2a61e70...52ddf51


new comment style

comment syntax has changed https://github.com/cooklang/spec/commit/6fbb891022aa098351b9146632c20f718b2e6d8c

dupe of #2


OssClient.DeleteObjectAsync() & OssClient.GetObjectDetailsAsync() NullReferenceException

Hello APS Team & @sajith-subramanian,
I can successfully create a new object in the specified bucket using a local file as shown. This can be verified using the OSS Manager Tool
.
But, I'm unable to get the details for that object or to delete that object. The call is being thrown with a 'System.NullReferenceException' without any details. I've tried using the name of the object, the objectId & the objectKey without success. Access token & bucket key are the same as shown in the upload image, so those are not null.

All scopes were added to the token to ensure that wasn't the issue, even though it would have thrown a different error for that.

What is the proper way to successfully execute these methods?
Thanks,
Tyler

This seems to be directly related to Autodesk.Oss Version 1.1.0, see StackOverflow post.

Hi @tylerwarner33, this issue has been identified and we will be updating the Oss package with the fix soon. Thanks for reporting!

Hi @tylerwarner33 , can you please test on the updated package (Link) and confirm if everything works as expected? Thanks!

Hello @sajith-subramanian, sorry for the delay. The project was put on hold. Yes, the new Nuget Package version works as expected, thanks!


File cannot be read in prod

Describe the bug
In the get function of a SvelteKit page endpoint I would like to read a file (with fs.readFileSync) which is inside the src folder and send the result to the client. This works fine in my local dev environment. But when I deploy the app to Netlify (for example) the following error shows up:
500

ENOENT: no such file or directory, open 'src/files/test.txt'

Error: ENOENT: no such file or directory, open 'src/files/test.txt

I have tried to

move the file elsewhere (for example in the static folder)
set the newest node version on Netlify (with the NODE_VERSION var)
create an alias for the path

Maybe this is easy to solve by changing the path of the file (how?), but I really wonder why this works in dev, but not in prod.
Reproduction

Create a SvelteKit skeleton project with npm init svelte. No typescript, no prettier, no ESLint, no playwright.
Create src/files/test.txt with some sample text.
Change index.svelte:

<script>
    export let text;
</script>

{text}

Add index.js:

import fs from "fs";

export async function get() {
    const text = fs.readFileSync("src/files/test.txt", "utf8");
    return {
        body: { text },
    };
}

Run npm run dev and open the app, it shows the sample text from the file.
Install the Netlify adapter as described here.
Deploy the site on Netlify.
Open the deployed site. It throws the error shown above (it cannot find the file).

Logs
No response
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
    Memory: 1.63 GB / 7.87 GB
  Binaries:
    Node: 18.2.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.11.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (102.0.1245.33)
    Internet Explorer: 11.0.19041.1566

Severity
serious, but I can work around it
Additional Information
No response

Reading from the filesystem is not encouraged as the build output won't match the desired path as you do in dev. It works in dev because files are left as-is (unbundled) through the dev server. Ideally you should import them, or save it in a database, etc. Marking as duplicate of #3535

Thanks! This clarifies the issue a bit. One question: what do you mean exactly by importing the files?
Also, why does the fs.readFileSync work in this project? Here markdown files are read from the file system and then rendered as html pages. For some reason there it works. But what should be the workaround here?

I think I have found a solution which works at least for Netlify and my toy example. It's similar to the solution at this stackoverflow question.

Create a folder for the files in the root, say files.
Put the files inside (for example, test.txt).
Now, we can read the file with fs.readFileSync("./files/test.txt").
We have to let Netlify know about the files folder. The whole server-side code of SvelteKit gets deployed as a Netlify function. Thus, in netlify.toml we add the following:

[functions]
included_files = ["files/**"]
It works :)

I am running into this same issue trying to call fs.readFileSync on Markdown files in my project.
@ScriptRaccoon do you know if there is a similar mechanism to include additional files/directories for Vercel deployments? When I log the directory contents on the Vercel deployment (i.e. fs.readdirSync('.'), it seems only the following files/directories are copied over from my source project:
.svelte-kit
___vc
node_modules
package.json

Right now, I'm having to resort to force-enabling SSG on my entire site (with @sveltejs/adapter-static), but it would be nice to leverage server-side capabilities.

Sorry, I have no experience with Vercel.

@ScriptRaccoon No worries! I ended up discovering that leverage VIte's import.meta.glob capability to achieve the best of both worlds, so I'm back to using adapter-auto now. Credit goes to a comment from the Stack Overflow post linked above.
Granted, using import.meta.glob is still effectively pre-bundling my Markdown files, but it restores to me the ability to have fully-server-rendered pages (since I'm able to use adapter-auto again).
Maybe in the future, SvelteKit will be able to expose the filesystem path to the compiled static assets directory. Because that would allow the file-reading to be real-time, rather than performed as a build step.


Updated Readme.md for V3

Hi,
I am trying out V3 for my analysis. It would be really helpful if you could provide an updated Readme.md for the new version and valid examples for it.
Thanks,
Anu Abraham

You can check my branch for a MWE, I believe it can help you out!

I couldn't find the link.
I wasn't not able to replicate the example in documentation with V1 of synth.
Can you please guide me to a proper documentation?

I was also trying it, but couldn't really apply it.  @anu37 Did you find any solution?

@Dfreckles I finally ended up using the synth package in R. Couldn't find any fix in python.

@anu37
Thanks for your reply. That is what I am doing right now, I am working in R, but I much rather use python.


Improve scrolling bar

The Scrolling bar is default and does not go with the theme(dark).
If you could change it.

i want to work on this issue...can you please assing me this issue?  and if possible please provide some description

@Nish251103 i have completed this task.....just before pushing it to your branch please check this out and please confirm me back is it ok or do i need to change anything more in the scroll bar:- MyPortfolio

@Nish251103 i have completed this task.....just before pushing it to your branch please check this out and please confirm me back is it ok or do i need to change anything more in the scroll bar:- MyPortfolio

Hey, It says invalid share key. I cant see it.

@Nish251103 i have completed this task.....just before pushing it to your branch please check this out and please confirm me back is it ok or do i need to change anything more in the scroll bar:- MyPortfolio

Hey, It says invalid share key. I cant see it.

just visit this link once again MyPortfolio

Just visit this link once again MyPortfolio

@mrvishalsharma It's perfect.
There were recent updates in other files, So Kindly open the PR with updated files, I could merge it right away.
Thank you 😃


Additional fields

The journal and publisher fields are for the same entity -- or rather, we only need the journal field, much like in citations.
# of citations -- nix it -- let's not have this at the top level, although it may be included within a dict from a specific API. In any case, it will change over time. Those kinds of metrics would be better to manage outside of the graph.
authors -- best to keep these under the dict from the specific API where they came -- since they'll be so many variations, and must be resolved at a later stage.
funder -- leave this out of the publications, and get more examples of it -- it can be added later, but there's a "0 or more" aspect to it, which may be better to model the way that we're going to handle customer entities.

Also, there should be notes about where to put the dict entries for APIs, such as:
"dimensions": {
  "foo": "bar",
  "citations": 5
},
"openaire": {
  "bar": "baz"
}

ok, lets discuss bc this gets into workflow. my thinking was that i was going to make a subdirectory of this repo where I work on enriching the kg with data from APIs. I wanted to have a simpler set of instructions just to get the linkages from the csvs that ben/marcos have been creating into json, then running the APIs on those partitions (stitched together?).


refactor(flat-pages): update preferences modal styles

move general settings label to first row's center
update theme picker styles

Hi, I have a suggestion that I think it might be better to reset index in onCancel useCallback. Of course, it doesn't matter if you don't set it, it's up to you. @hyrious

@syt-honey Ok.


Optional dependencies required even for environments which do not use them

I believe this is a problem with the init.py importing all of the sub-environments at the same time, meaning that to import one environment you need the modules to import all of them. For example, for the Umshini environments all you need is PettingZoo with no optional dependencies, but for the PettingZoo chess example you need pettingzoo[classic].
Simplest solution would be to have PettingZoo be a core requirement, if all environments importing will require that same init file which import them (https://github.com/chatarena/chatarena/blob/fa6b374bb62fa7070454962eec6a9c88bc584d63/chatarena/environments/init.py#L4), otherwise the init could be changed and they could be put in separate subfolders perhaps? I put the umshini environments in a separate folder as I wanted it to be clear that they are separate and don't require the same dependencies.
An alternative is to put the existing environments into a new directory called core or something like that? That would break backwards compatibility though, as it would require people to do from chatarena.environments.core import PettingZooChess or something. But it's probably good to categorize the environments in the long run if there are going to be others added.

This has been solved


Type declarations missing on single-spa-angular 7.0.0

Demonstration
I installed single-spa-angular on a clean new angular 14 project, but cannot compile and throws me an error with missing type declarations.
using single-spa-angular 7.0.0, angular 14.0.4
Actual Behavior
Cannot find module './single-spa-angular' or its corresponding type declarations.

I have the same problem. So, at the moment I have downgraded the version to angular 13 :(

Ok, this is really weird. I have created an issue in the ng-packagr repository, waiting for their reply and then will make necessary changes.

This is a regression in ng-packagr itself, I will republish a new single-spa-angular version once new ng-packagr version is available.

I have published 7.0.1.


E2E test fix

This is a work in progress for the e2e test for Poseidon.
Pulled in the few methods from k/test/e2e/framework.

/assign @dhilipkumars

@shashidharatd

refer PR #37


[5.9][interop] support 'default' mode for '-cxx-interoperability-mode' option

Explanation: The '-cxx-interoperability-mode' should support 'default' setting, which aligns the interoperability mode with the currently specified Swift language version. The old 'swift-5.9' setting is still supported for now, but will be removed shortly.
Scope: Swift's frontend option parsing for '-cxx-interoperability-mode' flag. No new options added.
Risk: Little. This flag is not yet adopted within Swift.
Testing: Swift unit tests.
Reviewer: @zoecarver

@swift-ci please test


only demand RSAKey from PrivateKey implementaton

MSAL4J adds a 2048 private key bitlength check.
It demands the key to implement java.security.interfaces.RSAPrivateKey to perform the bitlength check, but that is too demanding as java.security.interfaces.RSAKey (which is a sub interface of RSAPrivateKey) provides the bitlength() method .
Some hsm-box implementations implement RSAKey only thus MSAL4J is not useable with these hsmbox providers.
The later JDK signing algorithm runs fine without RSAPrivateKey being implemented.

@microsoft-github-policy-service agree

Hi, can I do anything to let the missing "MSAL Java CI Build" check run ?

@Avery-Dunn will provide an update. Current thinking is to remove that check altogether, although if tests pass this is ok too.

As of https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/749 in the latest 1.14.1 release, we no longer check the key size so this PR is no longer needed. Thanks for bringing this to our attention, and feel free to let us know about any other issues.


Deno example does not work

Issue workflow progress
Progress of the issue based on the Contributor Workflow

[ ] 1. The issue provides a minimal reproduction available on Stackblitz using the issue template.

Please install the latest @graphql-yoga/* packages that you are using.
Please makee sure the reproduction is as small as possible.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
The example https://github.com/dotansimha/graphql-yoga/tree/master/examples/deno does not work, trying to run this exact code on Deno 1.20.3 results in 80 errors by typescript.
To Reproduce
Steps to reproduce the behavior:

git clone git@github.com:dotansimha/graphql-yoga.git
deno run --allow-net graphql-yoga/examples/deno/index.ts

Environment:

OS: MacOS
NodeJS: N/A
Deno: 1.20.3
@graphql-yoga/* version(s): latest from skypack

Additional context

Could you try it now?

@ardatan Works fine on my end, we can close this issue.


Add SO_REUSEPORT for Android

The net2 crate currently fails to cross-compile to Android with error: unresolved name `libc::SO_REUSEPORT`
According to http://stackoverflow.com/a/14388707/1162888, Android is essentially the same as Linux for the purpose of socket features support, and the Linux kernel has supported SO_REUSEPORT since version 3.9.
According to http://android.stackexchange.com/a/51656, Android has had more recent kernels than that since version 4.4 Kit Kat.
(This blocks https://github.com/servo/servo/pull/8446.)

The CI here is failing which'll prevent this from landing, and I'd prefer o have constants like this verified on Android. If it's actually present then are there more recent Android compilers and/or headers which have the constants?

I’m not sure. FWIW, grep on my system finds SO_REUSEPORT under /opt/android-ndk/platforms/android-21, but not under android-19/ or earlier versions.
If in doubt, would you rather have the reuse_port methods on net2 not be there on android? I’d like to make net2 compile somehow.

Ok, I've updated our docker images to use API level 21 instead of 18 (I at least don't know of a reason to use an older one right now) and I'm in the process of uploading the new image tagged as 2015-11-22, and if you update this line to the new tag it should pick it up automatically and enable verification.
Note that it takes awhile to upload, so it may be ~15min before the image is available (travis may take awhile to get around to it though)

I’ve pushed a new commit but https://travis-ci.org/rust-lang-nursery/libc/requests doesn’t show a request for a new build.

Hm it looks like this PR doesn't yet include that change? (but seems referenced?)

I pushed to the wrong branche :)

https://travis-ci.org/rust-lang-nursery/libc/builds/92660417 failed with
2015-11-22: Pulling from alexcrichton/rust-slave-android

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Pushing the same commit again to trigger another build.

Same again. Any suggestion @alexcrichton ? 2015-11-22 does show up in https://hub.docker.com/r/alexcrichton/rust-slave-android/tags/ Could the 10 min limit be hit while Travis is downloading a 2 GB image?

I hit restart on this build but it may be time to use travis_wait when running docker

Looks like there was some trouble finding travis_wait?

Yeah, it looks like what I did is not correct usage, but I don’t know what is. Is travis_wait a magic string rather than an executable?

After trying a few random places to insert travis_wait:
The command "if [[ $TRAVIS_RUST_VERSION = nightly* ]]; then travis_wait sh ci/run-travis.sh; else cargo build; fi" exited with 1.
Log:

[…]

exec sh ci/run.sh arm-linux-androideabi
cannot enable tty mode on non tty input
/home/travis/build.sh: line 112:  5330 Terminated              travis_jigger $! $timeout $cmd

I believe this is just because docker is being run with -t  which says "Allocate a pseudo-TTY" which apparently travis_wait doesn't like. I'm gonna see if dropping that works -- https://github.com/rust-lang-nursery/libc/pull/74.

Trying a variation of #74:
before_script:
  - if [ "$TARGET" = "arm-linux-androideabi" ]; then
      travis_wait docker pull $(cat android-docker-image);
    fi

Timeout (20 minutes) reached. Terminating "docker pull alexcrichton/rust-slave-android:2015-11-22"

So I replaced travis_wait with strace -f and the raw log ends with:

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).
The job has been terminated

… but the job ran for 47 min 41 sec already, so even with another trick to have less output it’s likely to hit the 50 min timeout.

The raw log also contains "Layer already being pulled by another client. Waiting."

cc @edunham
I think perhaps it's time to bring in our ops team :)

Now that I merged https://github.com/rust-lang-nursery/libc/pull/88, could this be rebased? I think it should "Just Work" to add the constant now. (sorry for the runaround!)

Rebased.

Reverted version number bump, as it made tests fail to find libc at that version (presumably from crates.io?)
Travis failure on MIPS doesn’t looks related to this change?
error: linking with `mips-linux-gnu-gcc` failed: exit code: 1

note: "mips-linux-gnu-gcc" "-Wl,--as-needed" "-L" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/libc_test.0.o" "-o" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/libc_test" "-Wl,--gc-sections" "-pie" "-nodefaultlibs" "-L" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug" "-L" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/deps" "-L" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/build/libc-test-a6cd229ea2045071/out" "-L" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-Wl,--whole-archive" "-l" "all" "-Wl,--no-whole-archive" "-Wl,-Bdynamic" "/home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/deps/liblibc-f8fceda7be8f9ea9.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libstd-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libcollections-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/librustc_unicode-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/librand-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/liballoc-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/liballoc_jemalloc-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/liblibc-17a8ccbd.rlib" "/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libcore-17a8ccbd.rlib" "-l" "dl" "-l" "pthread" "-l" "gcc_s" "-l" "pthread" "-l" "c" "-l" "m" "-l" "rt" "-l" "compiler-rt"

note: /usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Warning: /home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/libc_test uses hard float, /home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libstd-17a8ccbd.rlib(fileline.o) uses soft float

/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Warning: /home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/libc_test uses hard float, /home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libstd-17a8ccbd.rlib(posix.o) uses soft float

...
/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Warning: /home/travis/build/rust-lang-nursery/libc/libc-test/target/mips-unknown-linux-gnu/debug/libc_test uses hard float, /home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/libcompiler-rt.a(mulodi4.o) uses soft float

/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Dwarf Error: found dwarf version '4', this reader only handles version 2 and 3 information.

/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Dwarf Error: found dwarf version '0', this reader only handles version 2 and 3 information.

/home/travis/rust/lib/rustlib/mips-unknown-linux-gnu/lib/liballoc_jemalloc-17a8ccbd.rlib(jemalloc.pic.o): In function `malloc_conf_init':

/buildslave/rust-buildbot/slave/nightly-dist-rustc-cross-linux/build/src/jemalloc/src/jemalloc.c:(.text.malloc_conf_init+0x94): undefined reference to `secure_getenv'

/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Dwarf Error: found dwarf version '0', this reader only handles version 2 and 3 information.

/usr/lib/gcc/mips-linux-gnu/4.4.5/../../../../mips-linux-gnu/bin/ld: Dwarf Error: found dwarf version '3072', this reader only handles version 2 and 3 information.

/buildslave/rust-buildbot/slave/nightly-dist-rustc-cross-linux/build/src/jemalloc/src/jemalloc.c:(.text.malloc_conf_init+0x98): undefined reference to `secure_getenv'

collect2: ld returned 1 exit status

error: aborting due to previous error

Could not compile `libc-test`.


Elaborate why one should use compilation options on cargo nextest archive and not while reading --archive-file

This could have saved me a lot of time.
I was getting the errors like (cc https://github.com/nextest-rs/nextest/issues/867)

error: the argument '--archive-file <PATH>' cannot be used with:
   --lib
   --bin <BIN>
   --bins
   --example <EXAMPLE>
   --examples
   --test <TEST>
   --tests
   --bench <BENCH>
   --benches
   --all-targets
   --package <PACKAGES>
   --workspace
   --exclude <EXCLUDE>
   --all
   --release
   --cargo-profile <NAME>
   --build-jobs <JOBS>
   --features <FEATURES>
   --all-features
   --no-default-features
   --target <TRIPLE>
   --target-dir <DIR>
   --ignore-rust-version
   --unit-graph
   --future-incompat-report
   --frozen
   --locked
   --offline
   -Z <FLAG>

And couldn't understand why.
It turns out that compilation options are kept in the metadata (which could've been mentioned in the above error) and are not expected when the archive is being read.

Hi there, missed this. Hoping to review it this weekend, thanks!

Actually, this looks great. Thanks so much for the contribution!


Problematic cmake target.

When I do:
make gazebo_build
it gives:
...
...
make[1]: *** No targets specified and no makefile found.  Stop.

I did some tracking and found in Makefile

gazebo_build:
        mkdir -p build_gazebo
        if [ ! -e $(PWD)/build_gazebo/CMakeCache.txt ];then cd build_gazebo && cmake -Wno-dev -G$(PX4_CMAKE_GENERATOR) $(PWD)/Tools/sitl_gazebo; fi
        cd build_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS)
        cd build_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS) sdf

it writes the build files to Tools/sitl_gazebo, but went to build_gazebo to perform the make.
Should change
    cd build_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS)
    cd build_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS) sdf

to
    cd Tool/sitl_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS)
    cd Tool/sitl_gazebo && $(PX4_MAKE) $(PX4_MAKE_ARGS) sdf

This problem cause all make command in this page does not work:
http://dev.px4.io/simulation-gazebo.html
After I use this method to fix the problem,  I get this error
[Err] [Plugin.hh:165] Failed to load plugin librotors_gazebo_multirotor_base_plugin.so: librotors_gazebo_multirotor_base_plugin.so: cannot open shared object file: No such file or directory
I solved this by make Firmware/build_gazebo a symbol link to Firmware/Tools/sitl_gazebo
I think you guys have unclear definition of Firmware/build_gazebo and Firmware/Tools/sitl_gazebo, I think here what you mean is to treat them as the same folder.
Please check it.

Cmake writes the build files to the current directory and you specify the source directory or an existing build directory. The gazebo targets (eg make posix_sitl_default gazebo) are currently working for me. I'm guessing you have leftover build files from before the build_gazebo directory was moved.
Can you try deleting build_gazebo, and cleaning Tools/sitl_gazebo (git clean -ff -x -d)? Then try make posix_sitl_default gazebo.

I carefully checked my clean, I found git clean -ff -x -d cannot really clean the folder (Tools/sitl_gazebo still have files which cannot be remove by git clean ).
I tried to clone the repo again, now it works, thank you :)

@intijk Next time, run make submodulesclean

I'm glad it's working.
I'm surprised git clean didn't work. Did you run it from Tools/sitl_gazebo? It's a submodule so running it in a directory above won't clean within sitl_gazebo.
I've updated make clean to also clean Tools/sitl_gazebo.

As @mhkabir mentioned.
make submodulesclean did the work :)


Style of ShareSheet on Android

Hi!
While the share sheet on iOS looks great, I was wondering if the styling on android could be improved to fit modern standards. I think the most common style is the following (screenshot taken from facebook app on Android 8.0 - sorry for it being German, but you should get the idea):

For comparison, this is how it looks like right now:

Thanks and keep up the awesome work!

My tip for you: Create the sharing link via Branch and then share it via the SocialSharing Cordova Plugin by https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin

+1 Dont want to have a additional cordova library to avoid the custom share screen of branch. A option to use the native share screen would be nice!


Allow log destination options on azure container apps environment

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
The only option on the log destination of an Azure Container App Managed Environment is "log-analytics", other supported values are "none" and "azure-monitor"
var environment = new ManagedEnvironment(name, new ManagedEnvironmentArgs
        {
            EnvironmentName = name,
            ResourceGroupName = args.ResourceGroup.Name,
            Location = args.ResourceGroup.Location,
            AppLogsConfiguration = new AppLogsConfigurationArgs
            {
                Destination = "log-analytics", // none, azure-monitor, log-analytics
            }
        });

Affected area/feature
Unable to create an azure container apps environment with desired log destinations

The SDK modells this property as a string (source). A couple of questions to help us understand the specific resource details:

What are you seeing that indicates other values won't work?
Where are you seeing that other values should be supported?


Does not work correctly with multiple cameras (VR)

When using a Virtual Reality headset (Vive) the outlines are shown slightly to the left of the object on the left screen and slightly to the right of the object on the right scene. This leads to two half transparent outlines on both sides of the object.

Ok, thanks for reporting, never tested in VR, will look into it.

Hi, I fix this for Google VR

@VadimTikhonyuk
Thanks!
Just to be clear, does this fix this issue specifically?
"The outlines are shown slightly to the left of the object on the left screen and slightly to the right of the object on the right scene. This leads to two half transparent outlines on both sides of the object."

@cakeslice
This works on Google VR, but I think on HTC Vive will work too, just same logic.

@VadimTikhonyuk
Ok, just committed your fix, but until someone tests with a Vive I'll keep this open.

This doesn't work for a Native unity camera with VR enabled, not a solution for VR on the Vive atleast.

If someone has


Helper Command to manage dependencies

Is your feature request related to a problem? Please describe.
On a large scale project, when delivered using mono repo, the number of packages are very high, mostly 30+ with dependencies on many other packages. Updating dependencies manually is very hard, especially when there is a breaking change in a package that is way up in the dependency tree, one has to carefully update dependencies one by one.
Describe the solution you'd like
A clear and concise description of what you want to happen.
An inquirer based guided experience would nice to have with option provided for developers to update all dependendency at once or selective packages by displaying the dependency of the particular package

@Caitlyn-Mills  can you work with @aly76  to create a decision record on this one?

This will be moved from sfpowerscripts to upcoming sfp-cli


Fails on kernel32-sys and advapi32-sys

cargo vendor-filterer  fails to replace certain crates, like  kernel32-sys or advapi32-sys, because cargo metadata fails on the vendored crates.
Steps to reproduce:
$ cargo new just-test
     Created binary (application) `just-test` package
$ cd just-test
$ cargo add local-encoding
    Updating crates.io index
      Adding local-encoding v0.2.0 to dependencies.
$ cargo vendor-filterer --platform x86_64-unknown-linux-gnu
Gathering metadata for platforms
   Vendoring fuchsia-cprng v0.1.1 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/fuchsia-cprng-0.1.1) to vendor/fuchsia-cprng
   Vendoring getopts v0.2.21 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.21) to vendor/getopts
   Vendoring kernel32-sys v0.2.2 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/kernel32-sys-0.2.2) to vendor/kernel32-sys
   Vendoring libc v0.2.135 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.135) to vendor/libc
   Vendoring local-encoding v0.2.0 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/local-encoding-0.2.0) to vendor/local-encoding
   Vendoring pulldown-cmark v0.0.3 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/pulldown-cmark-0.0.3) to vendor/pulldown-cmark
   Vendoring rand v0.4.6 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.4.6) to vendor/rand
   Vendoring rand_core v0.3.1 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/rand_core-0.3.1) to vendor/rand_core-0.3.1
   Vendoring rand_core v0.4.2 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/rand_core-0.4.2) to vendor/rand_core
   Vendoring rdrand v0.4.0 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/rdrand-0.4.0) to vendor/rdrand
   Vendoring remove_dir_all v0.5.3 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/remove_dir_all-0.5.3) to vendor/remove_dir_all
   Vendoring skeptic v0.4.0 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/skeptic-0.4.0) to vendor/skeptic
   Vendoring tempdir v0.3.7 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/tempdir-0.3.7) to vendor/tempdir
   Vendoring unicode-width v0.1.10 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.10) to vendor/unicode-width
   Vendoring winapi v0.2.8 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-0.2.8) to vendor/winapi-0.2.8
   Vendoring winapi v0.3.9 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-0.3.9) to vendor/winapi
   Vendoring winapi-build v0.1.1 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-build-0.1.1) to vendor/winapi-build
   Vendoring winapi-i686-pc-windows-gnu v0.4.0 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-i686-pc-windows-gnu-0.4.0) to vendor/winapi-i686-pc-windows-gnu
   Vendoring winapi-x86_64-pc-windows-gnu v0.4.0 (/crypt/iv/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-x86_64-pc-windows-gnu-0.4.0) to vendor/winapi-x86_64-pc-windows-gnu
To use vendored sources, add this to your .cargo/config.toml for this project:

[source.crates-io]
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"
Skipping just-test
Replacing unreferenced package with stub: winapi-x86_64-pc-windows-gnu
Replacing unreferenced package with stub: winapi-i686-pc-windows-gnu
Replacing unreferenced package with stub: winapi-build
Replacing unreferenced package with stub: winapi
error: Replacing with stub: winapi-0.2.8: Executing cargo metadata: Error during execution of `cargo metadata`: error: failed to load manifest for dependency `advapi32-sys`

Caused by:
  failed to read `/tmp/.private/iv/just-test/vendor/winapi-0.2.8/lib/advapi32/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

Same error, but with kernel32-sys vendored crate, happens when trying to vendor dependencies for https://github.com/mozilla/sccache checked out to  tag v0.3.0.

Oh, sorry, it was not  advapi, it was  winapi-0.2.8 in my test example which caused failure. Anyway, the problem is that crate dependencies (or dev-dependencies) have  path specified, and this path does not exist when the crate is vendored:
https://github.com/retep998/winapi-rs/blob/77588710a683e1a4ec085b0f3d6c8939ecc7f030/Cargo.toml

It looks like https://github.com/retep998/winapi-rs/commit/246dfcb3bd068ce354448877c4c59d8b10075285 is the commit that fixed this.
Working around this is going to be really hacky.  Perhaps we could just special case this crate?  Or maybe we could neuter all dev-dependencies by default?

One way to work around this is to remove all the dependencies (or just their paths?) in the same way [workspace] section is injected. It is convenient to do this using toml_edit crate. I have a working prototype for that and I can submit a pull request.
Another interesting option is to copy [package] section from original Cargo.toml as is (maybe dropping a few fields like build and links), without turning to cargo to parse it.
WDYT?

Hmm...my inclination here is to write code that targets this as a special case instead of trying to wholesale filter the Cargo.toml.  Unless we see evidence that this applies more widely.  (I guess we could write code that just compares success rate of cargo vendor versus cargo vendor-filterer on many projects)
Though, one thing is confusing me right now.  Looking at e.g. tokio, I see:
https://github.com/tokio-rs/tokio/blob/74a29be6077f4093373c647a2e3834bb5e2e9cd7/tokio/Cargo.toml#L144
So here we have a dev-dependency that uses path.  However...the published Cargo.toml is different.  https://docs.rs/crate/tokio/1.21.2/source/Cargo.toml
I wonder if something on the crates.io publish process ended up fixing this, but only for newer crates?

Ah, OK I see it's https://github.com/rust-lang/cargo/blob/810cbad9a123ad4ee0a55a96171b8f8478ff1c03/src/cargo/util/toml/mod.rs#L1349
There's a whole lot of stuff going on in that function, but I'd bet :money_with_wings: that at some point the logic in cargo changed to filter out dev-dependencies with path references or so.

OK I took a crack at this https://github.com/coreos/cargo-vendor-filterer/pull/38 but it's more complex than I thought because of the interplay between dev/build-dependencies and features.

Can you give https://github.com/coreos/cargo-vendor-filterer/pull/43 a whirl?  I think this approach is both simple and viable, and it fixes the case here.

@iv-m Hi, this is released in https://crates.io/crates/cargo-vendor-filterer/0.5.8 - please let me know if it doesn't work!

@iv-m Hi, this is released in https://crates.io/crates/cargo-vendor-filterer/0.5.8 - please let me know if it doesn't work!

cargo-vendor-filterer 0.5.8 works for me. Thank you so much, @cgwalters!


Resolves #109 - Add Gzip content encoding support for client requests

Using a buffer alone will not solve the problem, as at the end we'd have to
convert it back to a string anyway, and it's that string conversion that is
lossy, and prevents us from unzipping later on.
String concatenation and buffer concatenation will both yield the same
result.
On Mon., Jul. 5, 2021, 4:55 a.m. Artem Zakharchenko, <
@.***> wrote:

@.**** commented on this pull request.
In src/interceptors/ClientRequest/utils/getIncomingMessageBody.ts
https://github.com/mswjs/interceptors/pull/136#discussion_r663757647:

export function getIncomingMessageBody(res: IncomingMessage): Promise {
let responseBody = ''

let stream: Stream = res

if (res.headers['content-encoding'] === 'gzip') {
const gzip = zlib.createGunzip()

What implications do you see if we adopt your previous suggestion:
let responseBody = Buffer.from('')
I'm hesitant to bring gzip handling to this method, it may be a stretch
for its responsibilities.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mswjs/interceptors/pull/136#pullrequestreview-698949692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAER5O4P3R7UFSEET5SFSSDTWFXQNANCNFSM47YPDQMQ
.

Thank you for the explanation, @thomas-p-wilson!

Hey Artem!
Happy to help. I'll troll through the issue list in the coming days. I
really appreciate how this library has simplified my integration testing.
Happy to continue contributing!
On Wed, Jul 7, 2021 at 7:44 AM Artem Zakharchenko @.***>
wrote:

Merged #136 https://github.com/mswjs/interceptors/pull/136 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mswjs/interceptors/pull/136#event-4988628675, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAER5O26SODOXVNFWXMLJJTTWQ4ZZANCNFSM47YPDQMQ
.


Update the configuration to request an accountToken

Store the current window.location.href on load.

Internal note: do not merge this change until we run a migration for existing settings.

@f2prateek I've made this easier to merge by removing the need to migrate any data on segment's end. Instead I store the configuration value internally as the accountToken.


Inconsistency between pages CSS

Hi,
The theme used by Gogs is not always the same. For example, it won't be the same on the homepage of a repo and the page of a specific commit.

This is a fresh install of the latest version of Gogs (0.6.9) on Debian 8. Installed from binary and using nginx as a reverse proxy (if that matters).

Thanks your feedback!
But this is pretty much duplicated to #650
Quick answer is we are converting to new theme by page bases.


build with ninja

Windows 10x64
Meson 0.63.1
CMake 3.17
Pylon 7.2
log.txt

@OsuDesu ,
What was the reason of the failure on your side?
Maybe we can improve the README.


spring-boot-prow-9 to 0.0.14

Promote spring-boot-prow-9 to version 0.0.14

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix use of prefix in generated code

Currently, prefixes cannot be used because of a bug in GNAT [S910-025].

[x] Adapt code generator (integrate workaround if possible)
[x] Add prefix to generated code in unit tests
[x] Enable unit tests in CI

Fixed by #32.


How to generate the CodeGeneratorResponse.php file?

I want custom a generator ,but i cant find any solution to generate the codegeneratorresponse from complier/plugin.proto ?

You can use any available implementation to compile plugin.proto in a way you desire. You can use this project by adjusting a code generation.

Thanks @hjagodzinski !


Inherited hook is sometimes skipped on generics.

The following code shows that the inherited hook is sometimes skipped on generics.
abstract class A
  macro inherited
    puts "#{self.name} Inherited from A"
  end
end

abstract class B(X) < A
  macro inherited
    puts "#{self.name} Inherited from B(X)"
  end
end

abstract class C < B(A)
  macro inherited
    puts "#{self.name} Inherited from C"
  end
end

class D < C
end

When I run this, it emits "D inherited from C", and "D inherited from A", skipping B(X).
B(X) Inherited from A
C Inherited from B(X)
C Inherited from A
D Inherited from C
D Inherited from A

Reduced:
abstract class B(X)
  macro inherited
    puts "#{self.name} Inherited from B(X)"
  end
end

abstract class C < B(Int32)
end

class D < C
end

Output is:
C Inherited from B(X)

But output should be:
C Inherited from B(X)
D inherited from B(X)


[6674] - GET /trainees

Context
We need an API endpoint for trainee data belonging to a provider
Changes proposed in this pull request

adds a trainee route and controller
adds a metadata formatter
adds default params

Guidance to review

run locally and use insomnia to test out the trainee endpoint using various combinations of params

 Endpoint: GET /trainees


HSEARCH-1775: Avoiding references to engine "impl" classes from hibernate-search-infinispan

Hi guys, could you check out this one? That's what I have done to get rid of the "impl" dependencies from hs-infinispan to hs-engine:

Created an SPI service LockFactoryCreator for obtaining lock factories, which is consumable from within hs-infinispan
Created an SPI helper class DirectoryHelper providing the required functionality for dealing with directories
Duplicated some methods from ConfigurationParseHelper and JNDIHelper so hs-infinispan has these locally

My rationale was this:

LockFactoryCreator and DirectoryHelper seem generally useful and stable, so it seems reasonable to commit to an SPI for them; The former is a service as it consumes another service itself (I disliked passing the service manager through a method parameter), the latter is a simple helper as it's sufficient in this case
ConfigurationParseHelper and JNDIHelper seem awkward as general SPIs and we might not want to commit to them; As hs-infinispan is subject to relocation to ISPN anyways, I felt the duplication of these parts is the better choice (maybe there is even equivalent tuff in ISPN which may be used down the road)

I'm not 100% familiar with HSEARCH's packaging structure and philosophy, so if you have any better ideas for certain parts, please let me know and we can discuss. Thx!

I like :-)

Created an SPI service LockFactoryCreator for obtaining lock factories, which is consumable from within hs-infinispan

+1

Created an SPI helper class DirectoryHelper providing the required functionality for dealing with directories

Why not a service?

Duplicated some methods from ConfigurationParseHelper and JNDIHelper so hs-infinispan has these locally

+1 I think the simple solution of duplication would be applicable at other places as well (for example dependencies to our internal classes for the sake of avoiding some duplication). I think in some cases duplication is acceptable to keep other design goals (separation and isolation of modules).

I'm not 100% familiar with HSEARCH's packaging structure and philosophy, so if you have any better ideas for certain parts, please let me know and we can discuss

Looking good. Check out some of my comments.

Pushed an update based on your comments, @hferentschik. Only remaining this is the service discussion. I don't think we should do it, see my comment here: https://github.com/gunnarmorling/hibernate-search/commit/84439dcfda1fdd2f6f441da0fb8e1348c79d5b2a#commitcomment-9599030.

I am happy to merge. @Sanne, do you have more/any objections?

So Lucene uses "locks" today. OK.. so we have a LockFactory. We make that pluggable as a LockFactoryFactory ... :-/ starts to sound like a joke already.
We then evolve even further into a "LockFactoryFactoryService" abstraction to override these? What's the point?
And this seems like very inconvenient:
    try {
		return serviceManager.requestService( LockFactoryCreator.class ).createLockFactory( indexDir, properties );
	}
	finally {
		serviceManager.releaseService( LockFactoryCreator.class );
	}

guys I'm not happy about how everything is turning into a Service.
I tried to refactor the ClassLoaderService back in November and my PRs were refused as you all wanted it to be a Service but reality is that for an "aspect" like that one, the Service model isn't a good fit at all.
The Service contract was originally designed to solve some practical problems, let's please stick to that and not use it as a model to which all code needs to conform to.

I am happy to merge.

Not happy with those Service mantra spreading all over without reason

And this seems like very inconvenient ...

So what's so terribly inconvenient here?

guys I'm not happy about how everything is turning into a Service.

Are you not exaggerating a bit now?

The Service contract was originally designed to solve some practical problems,

It is not just there, because of a "practical problem", it is a pattern which helps us decoupling things. A very useful thing to have.

let's please stick to that and not use it as a model to which all code needs to conform to.

I don't understand what you mean here, but ok - what is your suggestion then?

I also find the service stuff cumbersome, that's exactly why I did not use it everywhere.
I did it for LockFactoryCreator because it depends on another service (for class-loading). Injecting dependencies seems reasonable to me, better than passing them via method parameters which would make APIs just ugly to use. You also wouldn't do that in a "normal" Spring or CDI application. I did not create a service for the directory helper as it doesn't have any dependencies.
Also see my original comment:

LockFactoryCreator and DirectoryHelper seem generally useful and stable [...] The former is a service as it consumes another service itself (I disliked passing the service manager through a method parameter), the latter is a simple helper as it's sufficient in this case

If the class loader stuff wasn't a service I'd be all for not having this service either.

I tried to refactor the ClassLoaderService back in November and my PRs were refused as you all wanted it to be a Service

I for my part didn't refuse anything. I'd be all for a simpler model for injecting dependencies.

The Service contract was originally designed to solve some practical problems

It would help if that purpose was stated somewhere (so something more than "Marker interface for services") giving advice when something should be a service and when not.

let's please stick to that and not use it as a model to which all code needs to conform to.

Again, that's exactly not what has been done. Not sure what makes you say that.

merged, thanks all!

Thanks!


CRYPTO-25: Add download_crypto.cgi to exclude list of rat check

Fixing: https://issues.apache.org/jira/browse/CRYPTO-25
@winningsix

Thanks @sundapeng for finding this. We could add license as annotation for source file.

Thank @winningsix for your review, I think the root cause is we didn't use the same version of rat with commons. Have rebased the patch.

+1

Committed to master. Thank @winningsix


Fix predictions method

Fixes #1

@pmaris, any interest in this? If you're not maintaining this anymore, any interest in adding me as a contributor?

Closing in favor of #8 since this is based on master.


Support building URLs programmatically

Would be cool if we could set fields on the built object that used existing fields.
Perhaps that gets at opening up some sort of plugin architecture here. Something to consider at least.
What I want to avoid against is having to write the same code within each project.

It's looking like we'll want to go the plugin route. Gatsby has a built-in mechanism to prevent types from being defined in multiple plugins at separate times. Therefore, if we want to enable extension of the schema for the types created by this plugin, we have to open that up somehow.

Moved to ample/gatsby-starter-ample#118


Race condition exception when accessing $Host.UI.psobject.Properties inside a runspace

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest version
[X] Search the existing issues.

Steps to reproduce
Environment:

PowerShell 7.3.6 on up-to-date Windows 10 22H2 x64
Pester 5.5.0
ThreadJob 2.0.3 and Microsoft.PowerShell.ThreadJob 2.1.0

Sporadic race condition exception when accessing $Host.UI.psobject.Properties inside a runspace started with Start-ThreadJob:

Start new session:
pwsh -nop

Paste following:

1..500 | ForEach-Object {
    Start-ThreadJob {
        1 | Should -BeExactly 1
        $supportsVT = $Host.UI.psobject.Properties['SupportsVirtualTerminal'].Value
    } -StreamingHost $Host
} | Wait-Job | Receive-Job | Remove-Job -Force

If you couldn't repro first time, start new PowerShell session, do not try in the same session.

More details here.
Expected behavior
There should be no exception.

Actual behavior
InvalidOperation: Cannot index into a null array.
InvalidOperation: Cannot index into a null array.
InvalidOperation: Cannot index into a null array.
InvalidOperation: Cannot index into a null array.

Error details
PS C:\> Get-Error

Exception             :
    Type        : System.Management.Automation.RuntimeException
    ErrorRecord :
        Exception             :
            Type    : System.Management.Automation.ParentContainsErrorRecordException
            Message : Cannot index into a null array.
            HResult : -2146233087
        CategoryInfo          : InvalidOperation: (:) [], ParentContainsErrorRecordException
        FullyQualifiedErrorId : NullArray
        InvocationInfo        :
            ScriptLineNumber : 1
            OffsetInLine     : 26
            HistoryId        : -1
            Line             : 1 | Should -BeExactly 1; $supportsVT = $Host.UI.psobject.Properties['SupportsVirtualTerminal'].Value
            PositionMessage  : At line:1 char:26
                               + … eExactly 1; $supportsVT = $Host.UI.psobject.Properties['SupportsVirtu …
                               +               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            CommandOrigin    : Internal
        ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
    TargetSite  : System.Object CallSite.Target(System.Runtime.CompilerServices.Closure, System.Runtime.CompilerServices.CallSite, System.Object, System.String)
    Message     : Cannot index into a null array.
    Data        : System.Collections.ListDictionaryInternal
    Source      : Anonymously Hosted DynamicMethods Assembly
    HResult     : -2146233087
    StackTrace  :
   at CallSite.Target(Closure, CallSite, Object, String)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute2[T0,T1,TRet](CallSite site, T0 arg0, T1 arg1)
   at System.Management.Automation.Interpreter.DynamicInstruction`3.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
CategoryInfo          : InvalidOperation: (:) [], RuntimeException
FullyQualifiedErrorId : NullArray
InvocationInfo        :
    ScriptLineNumber : 1
    OffsetInLine     : 26
    HistoryId        : -1
    Line             : 1 | Should -BeExactly 1; $supportsVT = $Host.UI.psobject.Properties['SupportsVirtualTerminal'].Value
    PositionMessage  : At line:1 char:26
                       + … eExactly 1; $supportsVT = $Host.UI.psobject.Properties['SupportsVirtu …
                       +               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.6
PSEdition                      Core
GitCommitId                    7.3.6
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Version
ThreadJob 2.0.3 and Microsoft.PowerShell.ThreadJob 2.1.0
Visuals

I cannot repro this in 5.1 or 7.3.6 with the above command using Microsoft.PowerShell.ThreadJob v2.1.0 as per my comment in the pester thread outside of WT though just about to test this in WT to see if this does repro as above.

Where can I get the 2.1.0 version, so I could test it on Windows 10 and PowerShell 5.1 and 7.3.6? On PowerShell Gallery there is only 2.0.3. The same on GitHub repo.

Install-Module Microsoft.PowerShell.ThreadJob installs the renamed and updated ThreadJob module

Thanks, sorry, I've missed the info about the new module name. Will test it tomorrow. I've just finished a 9 hour car drive for the holidays so I wasn't thinking clearly.

Adding this snippet from the Discord discussion yesterday from @seeminglyscience as another way to repro this
$event = [System.Threading.ManualResetEvent]::new($false)
$jobs = 1..500 | % {
    Start-ThreadJob {
        $event = $using:event
        $null = $event.WaitOne()
        $supportsVT = $Host.UI.psobject.Properties['SupportsVirtualTerminal'].Value
    } -StreamingHost $Host
}

Start-Sleep -Milliseconds 500
$null = $event.Set()

$jobs | Receive-Job -AutoRemoveJob -Wait

Based on the callstack, it appears that ListDictionary is being used somewhere which is not threadsafe.  In this case, this doesn't appear to be an issue with ThreadJob itself, but something the thread is accessing is not threadsafe and results in the race condition.
If the actual use case is to see within a thread if SupportsVirtualTerminal is true/false, then it would be best to capture that outside of the thread job and pass it in.

I would agree that I don't think it's a ThreadJob problem. My guess is that it's a race condition in how PowerShell is creating the internal PSMemberInfoCollection<> and caching it in the member resurrection table.
At a glance it looks like there's a lock around the creation of the underlying collection, but the collection itself is populated lazily with no lock.


Colmap pose

Hi, thanks for sharing the code!
I want to ask for detail about generating poses. I fail to obtain poses for some images by running colmap on each scene with train and test images together. Is that because the feature extractor should be run on all ScanNet images? If this is the case, can you share the scannet_sift_database.db? Otherwise, can you provide the code for generating camera poses? Many thanks!

Hi, it can be difficult to run SfM on very few images as in the example scenes. What usually works for me is to run Colmap in a loop until all images have been registed. Still, it is important to visually check that the resulting cameras poses are plausible.
As a reference, i attach a script that first runs SfM on all images (train and test) to obtain camera poses. Then, it repeats feature matching and point triangulationon on the train images alone to get the sparse reconstruction for NeRF optimization.
The script should lie in a directory containing images_all and images_train, where images_all contains all train and test images and images_train contains just the train images.
import os
import shutil
import subprocess

import sqlite3

def list_missing_rgb(rgb_dir, sparse_dir):
    expected_files = os.listdir(rgb_dir)
    found_files = []
    for line in open(os.path.join(sparse_dir, "images.txt")):
        for f in expected_files:
            if " " + f in line:
                found_files.append(f)
                break
    print("Missing: ")
    for exp_f in expected_files:
        if exp_f not in found_files:
            print(exp_f)

data_dir = os.path.dirname(os.path.abspath(__file__))
verbose = False
rgb_all_dir = os.path.join(data_dir, "images_all")
rgb_train_dir = os.path.join(data_dir, "images_train")

success = False

# run colmap sfm in a loop on all images (train and test) until all images are successfully registered
while not success:
    # delete previous failed reconstruction
    recon_dir = os.path.join(data_dir, "recon")
    if os.path.exists(recon_dir):
        shutil.rmtree(recon_dir)

    # run colmap with all images creating database db_all.db
    db_all = os.path.join(recon_dir, "db_all.db")
    sparse_dir = os.path.join(recon_dir, "sparse")
    os.makedirs(sparse_dir, exist_ok=True)
    extract_cmd = "colmap feature_extractor  --database_path {} --image_path {} --ImageReader.single_camera 1 --ImageReader.camera_model SIMPLE_PINHOLE".format(db_all, rgb_all_dir)
    match_cmd = "colmap exhaustive_matcher --database_path {}  --SiftMatching.guided_matching 1".format(db_all)
    mapper_cmd = "colmap mapper --database_path {} --image_path {} --output_path {} --Mapper.multiple_model 0".format(db_all, rgb_all_dir, sparse_dir)
    sparse_dir = os.path.join(sparse_dir, "0")
    convert_cmd = "colmap model_converter --input_path={} --output_path={} --output_type=TXT".format(sparse_dir, sparse_dir)
    colmap_cmds = [extract_cmd, match_cmd, mapper_cmd, convert_cmd]

    number_input_images = len(os.listdir(rgb_all_dir))

    for cmd in colmap_cmds:
        process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
        for line in process.stdout:
            if verbose:
                print(line)
        process.wait()

    # check completeness of reconstruction
    number_lines = sum(1 for line in open(os.path.join(sparse_dir, "images.txt")))
    number_reconstructed_images = (number_lines - 4) // 2 # 4 lines of comments, 2 lines per reconstructed image
    print("Expect {} images in the reconstruction, got {}".format(number_input_images, number_reconstructed_images))
    if number_input_images == number_reconstructed_images:
        success = True
    else:
        list_missing_rgb(rgb_all_dir, sparse_dir)

# transform the reconstruction such that z-axis points up
sparse_dir = os.path.join(recon_dir, "sparse", "0")
in_sparse_dir = sparse_dir
out_sparse_dir = os.path.join(recon_dir, "sparse{}".format("_y_down"), "0")
os.makedirs(out_sparse_dir, exist_ok=True)
align_cmd = "colmap model_orientation_aligner --input_path={} --output_path={} --image_path={} --max_image_size={}".format(in_sparse_dir, out_sparse_dir, rgb_all_dir, 640)
in_sparse_dir = out_sparse_dir
out_sparse_dir = os.path.join(recon_dir, "sparse{}".format("_z_up"), "0")
os.makedirs(out_sparse_dir, exist_ok=True)
trafo_cmd = "colmap model_transformer --input_path={} --output_path={} --transform_path=/home/barbara/data/y_down_to_z_up.txt".format(in_sparse_dir, out_sparse_dir)
convert_cmd = "colmap model_converter --input_path={} --output_path={} --output_type=TXT".format(out_sparse_dir, out_sparse_dir)
colmap_cmds = [align_cmd, trafo_cmd, convert_cmd]
for cmd in colmap_cmds:
    process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
    for line in process.stdout:
        if verbose:
            print(line)
    process.wait()

# extract features of train images into database db.db
db = os.path.join(recon_dir, "db.db")
extract_cmd = "colmap feature_extractor  --database_path {} --image_path {} --ImageReader.single_camera 1 --ImageReader.camera_model SIMPLE_PINHOLE".format(db, rgb_train_dir)
process = subprocess.Popen(extract_cmd, shell=True, stdout=subprocess.PIPE)
for line in process.stdout:
    if verbose:
        print(line)
process.wait()

# copy sparse reconstruction from all images
constructed_sparse_train_dir = os.path.join(recon_dir, "constructed_sparse_train", "0")
os.makedirs(constructed_sparse_train_dir, exist_ok=True)
camera_txt = os.path.join(constructed_sparse_train_dir, "cameras.txt")
images_txt = os.path.join(constructed_sparse_train_dir, "images.txt")
points3D_txt = os.path.join(constructed_sparse_train_dir, "points3D.txt")
shutil.copyfile(os.path.join(out_sparse_dir, "cameras.txt"), camera_txt)
open(images_txt, 'a').close()
open(points3D_txt, 'a').close()

# keep poses of the train images in images.txt and adapt their id to match the id in database db.db
train_files = os.listdir(rgb_train_dir)
db_cursor = sqlite3.connect(db).cursor()
name2dbid = dict((n, id)  for n, id in db_cursor.execute("SELECT name, image_id FROM images"))
with open(os.path.join(out_sparse_dir, "images.txt"), 'r') as in_f:
    in_lines = in_f.readlines()
for line in in_lines:
    split_line = line.split(" ")
    line_to_write = None
    if "#" in split_line[0]:
        line_to_write = line
    else:
        for train_file in train_files:
            if " " + train_file in line:
                db_id = name2dbid[train_file]
                split_line[0] = str(db_id)
                line_to_write = " ".join(split_line) + "\n"
                break
    if line_to_write is not None:
        with open(images_txt, 'a') as out_f:
            out_f.write(line_to_write)

# run exaustive matcher and point triangulator on the train images
match_cmd = "colmap exhaustive_matcher --database_path {}  --SiftMatching.guided_matching 1".format(db)
sparse_train_dir = os.path.join(recon_dir, "sparse_train", "0")
os.makedirs(sparse_train_dir, exist_ok=True)
triangulate_cmd = "colmap point_triangulator --database_path {} --image_path {} --input_path {} --output_path {}".format(db, rgb_train_dir, \
    constructed_sparse_train_dir, sparse_train_dir)
convert_cmd = "colmap model_converter --input_path={} --output_path={} --output_type=TXT".format(sparse_train_dir, sparse_train_dir)
colmap_cmds = [match_cmd, triangulate_cmd, convert_cmd]
for cmd in colmap_cmds:
    process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
    for line in process.stdout:
        if verbose:
            print(line)
    process.wait()

Hi, thanks for sharing the code! I want to ask for detail about generating poses. I fail to obtain poses for some images by running colmap on each scene with train and test images together. Is that because the feature extractor should be run on all ScanNet images? If this is the case, can you share the scannet_sift_database.db? Otherwise, can you provide the code for generating camera poses? Many thanks!

I also meet the same problem, how do you solve the problem?


automate-ui/projectsFilter: deleted projects still live in localstorage, are sent with requests

Reproduction steps

observe localstorage's projectsFilter.option for an a2 instance with no projects: there's no such key
create a project, "asdf" -- still no key in localstorage
pick both "(unassigned)" and "asdf", Apply Changes: we now have a setting:

[{"label":"(unassigned)","value":"(unassigned)","type":"CHEF_MANAGED","checked":true},{"label":"asdf","value":"asdf","type":"CUSTOM","checked":true}]

go to projects, delete the "asdf" project
notice that localstorage still has the same content
reload the page
same content in localstorage
in the network tab, notice that requests are sent with the old project id:

projects: (unassigned), asdf

Definition of Done
localstorage is in sync with deleted projects
Demo Script / Repro Steps

Q: Why do we need to use localstorage at all?

Q: Why do we need to use localstorage at all?
That provides the convenience of having the same set of projects selected the next time you open A2.

I think I dislike treating localStorage as a giant global variable. Could we thread it through ngrx' stuff? It's like a request, except that it's not sent to a backend.

I'll accept!
✅ Deleting a project via the UI, it disappears from localstorage.
✅ Deleting a project from the API, reloading the page, I don't find the project in localstorage or request headers.


fix: append .js extension if missing

Summary

Resolves #276
Do not show Script export successful toast when export is canceled

Todo

[ ] Add testing

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-05T14:22:59.122+0000

Duration: 10 min 35 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
6

Skipped
0

Total
6

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test all : Re-trigger the build for all the stages.

Also didn't have easy access to windows but as @vigneshshanmugam said your windows test vid looked good and code seems fine.


doc(plugins/plugin-kubectl): improved jobs guidebook

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[ ] All npm dependencies are pinned.

/check-cla

hmm, easycla is stuck


libernet plus issue

hi helmi. this is new issue regarding issue of #2 i've create before. i've done installing libernet plus. i'm compiling arm v8 firmware using immortalwrt as my source.
test my firmware and i can't see tun at my network interface. seems like creation of tun automatic script failed. i also need to run fixphp to make sure libernet plus is accessible. all the require package has been add to my config. i need your help to troubleshoot. tq helmi. thanks for your hard work.

hi helmi. this is new issue regarding issue of #2 i've create before. i've done installing libernet plus. i'm compiling arm v8 firmware using immortalwrt as my source.
test my firmware and i can't see tun at my network interface. seems like creation of tun automatic script failed. i also need to run fixphp to make sure libernet plus is accessible. all the require package has been add to my config. i need your help to troubleshoot. tq helmi. thanks for your hard work.

is tun0 interface installed?

Tun0 does not show up in network interface. I tried to manually set the tun0 but when try to use ovpn the is an error in system log show 'openvpn connection unavailable'. I check at openwrt system log error 'if config tun1 error fetching interface information : device not found

using this script ? /usr/sbin/openvpn --mktun --dev tun1

using this script ? `/usr

using this script ? /usr/sbin/openvpn --mktun --dev tun1

using this script ? /usr/sbin/openvpn --mktun --dev tun1

No this is not the correct way to use that command. Those command wasn't supposed to be in the installer/compiler script since it need openvpn to be installed at a running system. For your problem it seems the same as https://github.com/helmiau/HelmiWrt-OS/issues/31 this one, you may read those to fix your problem. And you can insert those command at boot if you don't want to run it over and over again every time your device shutoff

using this script ? /usr/sbin/openvpn --mktun --dev tun1

No this is not the correct way to use that command. Those command wasn't supposed to be in the installer/compiler script since it need openvpn to be installed at a running system. For your problem it seems the same as https://github.com/helmiau/HelmiWrt-OS/issues/31 this one, you may read those to fix your problem. And you can insert those command at boot if you don't want to run it over and over again every time your device shutoff, but for the love of god don't put that on the compiler script (Makefile)

Do pull request please

using this script ? /usr/sbin/openvpn --mktun --dev tun1

No this is not the correct way to use that command. Those command wasn't supposed to be in the installer/compiler script since it need openvpn to be installed at a running system. For your problem it seems the same as https://github.com/helmiau/HelmiWrt-OS/issues/31 this one, you may read those to fix your problem. And you can insert those command at boot if you don't want to run it over and over again every time your device shutoff, but for the love of god don't put that on the compiler script (Makefile)

i can't click the link. no

thanks i will look into it


Reducing Initial Spacing Affects X-Axis Label Position; Dot/Strip and Label Not Vertically Aligned

I'm facing an issue with the positioning of the X-axis labels and the vertical alignment of the dot/strip with the labels when using the LineChart.
I have set initialSpacing to 0 and adjustToWidth to true. The X-axis labels are automatically adjusted, but the alignment is not accurate. Specifically, the position of the dot/strip and the corresponding X-axis labels are not vertically aligned.
Here's the code snippet:
<LineChart
data={chartData[0]}
data2={chartData[1] ?? null}
data3={chartData[2] ?? null}
data4={chartData[3] ?? null}
areaChart
initialSpacing={0}
adjustToWidth={true}
xAxisLabelTextStyle={{
fontSize: 11,
fontFamily: fonts.fontRegular,
}}
xAxisLength={screenWidth - 30}
yAxisTextStyle={{
fontSize: 11,
fontFamily: fonts.fontRegular,
}}
color1={colors.MED_BLUE}
color2={"#FF7F7F"}
startFillColor1={colors.MED_GREEN}
startFillColor2={colors.MED_BLUE}
dataPointsColor1={colors.MED_BLUE}
dataPointsColor2={"#FF7F7F"}
dataPointsRadius={3}
curved={true}
focusEnabled={true}
showStripOnFocus={true}
stripWidth={1}
stripColor={'red'}
focusedDataPointColor={'red'}
delayBeforeUnFocus={30000}
onFocus={(item, index) => {
hanldeOnFocus(index);
}}
height={250}
/>

Hi @Rashid-Rcp
Try adding margins and/or alignments inside xAxisLabelTextStyle.
Note- You might need to add negative margins.

Thanks for the response. I was able to solve the issue with margins and width on labelTextStyle


Bug: Import Status - STAC validation errors not reported

Bug Description

I've noticed some JSON/STAC errors are not reported to the end user via the import-status endpoint. Can we ensure all errors are reported to the end user in some way?
e.g. When I try and import data with incorrect key like 'checksum:multihash' instead of 'checksum:file' I get this error in the logs.
[...]
	2021-04-14T10:23:34.853+12:00	File "/src/task/utils.py", line 124, in validate
	2021-04-14T10:23:34.853+12:00	asset_dict = {"url": asset_url, "multihash": asset["file:checksum"]}
	2021-04-14T10:23:34.853+12:00	KeyError: 'file:checksum'

But the import status looks lie this:
{
  "statusCode": 200,
  "body": {
    "step function": {
      "status": "FAILED"
    },
    "validation": {
      "status": "Pending",
      "errors": []
    },
    "metadata upload": {
      "status": "Pending",
      "errors": []
    },
    "asset upload": {
      "status": "Pending",
      "errors": []
    }
  }
}

No way for the end user to find out what is going on (beside asking someone int he product team to look in the logs.
Example STEP Funciton instance
https://ap-southeast-2.console.aws.amazon.com/states/home?region=ap-southeast-2#/executions/details/arn:aws:states:ap-southeast-2:632223577832:execution:nonproddatasetversioncreation8597518E-i9JA9Y04AIGV:a0e841439ca611eb84b027099ebdcf03
How to Reproduce

Do …
Run …

What did you expect to happen?
What actually happened?
Software Context
Operating system:
Environment:
Relevant software versions:

AWS CLI: <!-- include the output of aws --version -->
Poetry: <!-- include the output of poetry --version -->

Additional context

Could be resolved as part of #517


Killed : cd zero123/zero123, then python gradio_new.py, get Killed

cd zero123/zero123, then python gradio_new.py, the program gets Killed.
The code locates in ' zero123/zero123/ldm/models/diffusion/ddpm.py ',

def instantiate_cond_stage(self, config):
    if not self.cond_stage_trainable:
        if config == "__is_first_stage__":
            print("Using first stage also as cond stage.")
            self.cond_stage_model = self.first_stage_model
        elif config == "__is_unconditional__":
            print(f"Training {self.__class__.__name__} as an unconditional model.")
            self.cond_stage_model = None
            # self.be_unconditional = True
        else:
            model = instantiate_from_config(config)

instantiate_from_config gets error,  config is ' cond_stage_config:target: ldm.modules.encoders.modules.FrozenCLIPImageEmbedder'.
Did anyone else encounter similar situations？

Could be an issue related to installing environments for CLIP. Try running:
git clone https://github.com/openai/CLIP.git
pip install -e CLIP/


Update plugins_after.zsh

change
dircolors to gdicolors new installation in Mac will print command not found because the new installation process brew install coreutils adds "g" to dircolors.
Please refer to the following link: https://formulae.brew.sh/formula/coreutils

I use dircolors, not gdircolors. If you want this behavior, you can get it too.
$ brew info coreutils
...
Commands also provided by macOS and the commands dir, dircolors, vdir have been installed with the prefix "g".
If you need to use these commands with their normal names, you can add a "gnubin" directory to your PATH with:
  PATH="/usr/local/opt/coreutils/libexec/gnubin:$PATH"


Add consumption

Detailed Description
It would be nice to add generation into this package. This means you can add a consumption of a building, and then see how the battery should operate.
Possible Implementation

add consumption here https://github.com/openclimatefix/solar-and-storage/blob/main/solar_and_storage/solar_and_storage.py#L17
add to objective function
Problem: work out how to set up Linear Optimzation with Solar+storage + consumption
add example, with plots

We might be able to sove this by combing consumption and solar generation to be
generation = solar generation - consumption. Then we just use generation like we have before. This might work?

I'm testing a version in which net_generation = solar_generation - consumption which should definitely work in principle.  It does become a bit more complicated, the current constraints are set up with the expectation that solar_generation is >= 0, which of course is true with actual generation, but if we allow net_generation to be negative (due to consuming more than we're generating), then a bunch of the constraints need to be adjusted.  working through that now but it's going to take some thinking..

Ok I'm reconsidering if net_generation = solar_generation - consumption is the way to go.  Because we have to take into account a lot of different cases, like using power from the grid for consumption, using battery for consumption, charging the battery while using the grid for consumption, etc.

I'm pretty deep into this now, but I'm starting to have some questions..
Take this:
        profit = self.prices * (
            self.power_discharge_cp_variable.value - self.battery_power_charge_cp_variable.value
        )

Is "profit" supposed to mean only the money generated from selling from the battery?  Shouldn't profit include revenue from solar being sold directly to the grid as well?  Or do we want a separate "battery profit" and "solar profit"?

Thats great you are getting in to this.
if its possible to split it then, then do both yea. Is it possible to split them up easily? As in if some of the energy goes straight into the battery from the solar, where does that count?

Well, right now the profit var is actually just the battery profit, as it's counted as self.power_discharge_cp_variable.value - self.battery_power_charge_cp_variable.value (power_discharge_cp_variable represents
         # the amount of power going out of the battery
        self.power_discharge_cp_variable = cp.Variable(HOURS_PER_DAY)

solar profit would be self.prices * solar_to_grid, solar that goes to the battery would be part of battery profit.  solar profit is simply ignored in the code right now, so actually the current profit numbers are basically incorrect if it was supposed to represent both solar and battery profit.
But yeah, i can fix this..

Also I want to check my understanding.  I just noticed this:
            power_charge = (
                self.eta_charge * self.battery_power_charge_cp_variable[i]
            ) + self.power_solar_to_battery[i]

is the efficiency factor applied only to the grid charging because we assume DC to DC charging on solar to battery, which is assumed to be more efficient?
If yes I'll add some comments to clarify the reasoning..

yea, I think so, yea clarifying comments would be great


Missing prompt to save when opening a level

The user isn't prompted to save unsaved work when they open a map.

Users are now prompt to save when opening a level.


Infeasible model returns optimal

Describe the bug
When called with a clearly infeasible model -- an optimal solution is return.
Not sure, but I think this is a weird edge case.
To Reproduce

from cvxpy import *
p = Problem (Maximize (0), [Constant (0) == 1])
p.solve ()
0.0
p.status
'optimal'

Expected behavior

from cvxpy import *
p = Problem (Maximize (0), [Constant (0) == 1])
p.solve ()
0.0
p.status
'infeasible'

Version

OS: Ubuntu 20.04
CVXPY Version: 1.1.10

Great! thanks.


Failed to install 'jeppeandersen.vscode-kafka'.

Unable to install Extension 'jeppeandersen.vscode-kafka-0.5.2' as it is not compatible with Code '1.24.1'.
Not able to install this in mac, from the store.
Please ignore if the issue is fixed and I am unaware of this.

Hi @simplymanas
There is a requirement in the extension for Code '1.30' (November 2018). 1.24 is from May 2018 so unfortunately the version is unsupported. Is there a specific reason for not being on the latest stable?
Thanks,
Jeppe

Thank you @jlandersen , I have updated to the latest one and it worked.


Fix gossip service connection for Validator Keeper

Fixes the way that we connect to gossip service by using the method from solana-gossip to start the gossip service and passing in another IP.
Still unclear why it suddenly stopped working.

merged in when christian/keeper-branch was merged


Query Bean new QCustomer().id is null

I follow ebean-orm-examples/example-minimal.git, querybean works well,
but when i upgrade querybean-generator to 11.1.1, new QCustomer().id is null,
and use ebean-maven-plugin and querybean-maven-plugin also is null.
How can I make querybean work use the highest version of ebean and ebean-maven-plugin ?
Thank you !

Hi,
Ok, sorry I missed this. Note that in general it is better to ask questions on the Ebean forum ... https://groups.google.com/forum/#!forum/ebean
Your question will go to more people and it won't get forgotton if you ask it there.
As for the issue, yes I need to update the dependencies on the example ... I'll see if I can do that over the weekend.
Cheers, Rob.

I have updated both the minimal and example-java8 which is at https://github.com/ebean-orm-examples/example-java8
Note that the example-java8 ... has the QueryBean generation etc.
Cheers, Rob.

Ok, updated the minimal with query bean support.
To add query bean support ...

Make sure we have a ebean.mf ... with the querybean-packages specified
Modify the pom adding the dependency for ebean-querybean and querybean-generator (provided)

See https://github.com/ebean-orm-examples/example-minimal/commit/a535f8c85387c7ba811611a72d541a83e0550e63
Cheers, Rob.

I'll close this now.


Don't show choices with a large data set

I have some problems using ui-select with 172 items it's not a too large data set but when I used it the choices's panel don't appear, I can search into the component but the list of choices don't appear when   the dataset is small 20 items perhaps,  it work very well.

I think you are looking for the minimum input length option included as part of #1291
Closing for now, please update this issue with more information if you need it reopened.