Refactor TLSSocket based on review comments

Refactor TLSSocket based on review comments
Added getters & setters for all members that can be shared between TLSSockets
Moved all private structures to be a member variables instead of pointers to save RAM.
Moved some (but not all) initialisation code away from do_handshake() function

ping @kjbracey-arm Any other feedback that what was given in #2


fix: compile ElixirLS with Elixir v1.16

Release mix task has been deprecated for some time and fails to work with Elixir v1.16. The recommended mix task is release2

Can you figure out the failed test?

@mhanberg  The first one is because I did not follow the commit message style (sorry for that ). Should I create a new PR with a different commit message ?
The second one, I did not test it locally to see if it is working with Elixir v1.13 only tested it with v1.15 and v1.16.

You can just change the PR title, it'll re run the lint.
What's the lowest supported Elixir version for Elixir LS?

changed the PR title
The support matrix for ElixirLS is here
ElixirLS Support Matrix

@mhanberg I think I found the problem with the tests and found it when installing 0.18.1. The release2 task does not create the release path. Please can you run the tests again?

Tests look good. I think I just need to make sure the apple silicon runner in my closet is logged in. My power flipped recently I think


[bug] in big brain region, fetches unncessary url

fix https://hbp-kg-dataset-previewer.apps.hbp.eu/v2/minds%2Fcore%2Fdataset%2Fv1.0.0/f746514d-b79a-48e2-9c07-39f7c62459cf/undefined in big brain regions

fixed by 5b14cfce77113dcf709da780141fbc43ba1efa5a


Fixed Gradle minSdkVersions to 24 from 26

Max version on control hub is 25

@liambridgers, you mean from 26 to 24? But otherwise, yeah.


Update rollup to the latest version 🚀

Closes #15

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          73     73
=====================================
  Hits           73     73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcce3da...2474eb0. Read the comment docs.


Add information about all the tools used in the repo

Links to #11

Create more granular issues instead


how to use fine-tuned model?

I just updated it to the new API standard. You should be able to use:
openai.Completion.create({
    model: "YOUR_FINE_TUNED_MODEL OR ENGINE",
    prompt: "Original: She no went to the market.\nStandard American English:",
    temperature: 1,
    max_tokens: 64,
    top_p: 1,
    frequency_penalty: 0,
    presence_penalty: 1,
    n: 1,
    stream: false,
    logprobs: null,
    echo: false,
    best_of: 1,
    stop: null,
}).then((response) => {
    console.log(response);
});

To create a fine-tuned model visit OpenAI's documentation to use their CLI tool.


Enhancement:Ec2:Vpc End Point Services

Enhancement:Ec2:Vpc End Point Services

Superseded by the following PRs, which together contain the API endpoints that were to be added:
#3524
#4169
#5530


Use prettier for "Prettify" feature

Prettier is becoming the popular default when it comes to formatting code (including GraphQL queries). The "Prettify" button inside of the Playground should use prettier under the hood and should even be configurable in the setting.

Sadly not possible, because prettier is unable to run in browser right now

Would a server based solution with an API work in this case? Click here for the Unibeautify Playground which wraps Prettier. Note in the network requests the query is sent to a public API hosted by RunKit ( https://runkit.com/glavin001/unibeautify-playground ).


Depends on canvas-editor, which isn't in the npm registry

👌

@ismith Went ahead and published the editor.


Question regarding refferres API conformance tests for push

Hello!
With the release of v1.1.0 of the spec it seems there isn't the option to skip the conformance tests related to the referrers API alone.  From https://github.com/opencontainers/distribution-spec/blob/main/spec.md#backwards-compatibility it seems the referrers API is optional .
Is my understanding correct that the referrers API is optional (and clients of registries will be responsible to implement the fallback if the API is not available)? and if this is indeed the case can we expose a flag in the conformance tests to enable older registries (that don't implement the referrers API) to skip referrers API tests specifically and not just all the service-discovery tests?

The backward compatibility is for clients working with registries that implement the 1.0.x version of the spec. If you do not want to implement the latest APIs, and only want to support OCI 1.0.x, you can run older releases of the conformance tests.


[homeassistant.setup]  Error during setup of component smartthinq

This is a new one. I keep seeing this on other components (Awair but it went away - not sure why):
2020-06-27 14:55:20 ERROR (MainThread) [homeassistant.setup] Error during setup of component smartthinq
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/setup.py", line 190, in _async_setup_component
    result = await asyncio.wait_for(task, SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/smartthinq/__init__.py", line 69, in setup
    client = wideq.Client.from_token(refresh_token, region, language)
  File "/usr/local/lib/python3.7/site-packages/wideq/client.py", line 210, in from_token
    client.refresh()
  File "/usr/local/lib/python3.7/site-packages/wideq/client.py", line 192, in refresh
    self._auth = self.auth.refresh()
  File "/usr/local/lib/python3.7/site-packages/wideq/core.py", line 371, in refresh
    self.refresh_token)
  File "/usr/local/lib/python3.7/site-packages/wideq/core.py", line 299, in refresh_auth
    raise TokenError()

Config:
smartthinq:
token: 439535........................
region: US
language: en-US
I did execute the example to get a new token as well.

Used a wrong token :(


Possibility to intercept the Proxy response

Add the possibility to intercept the proxy response to eg filter out data, etc.

This issue was moved to aspnet/Home#2483


Change version number on README.md

Maintain changelog file with correct semantic versioning.

Changed in version 0.0.2


linux: Add hardened test kernel

Motivation for this change
Add hardened testing kernel, so we can test before the kernel releases become stable
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: linux
Partial log (click to expand)
while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14101:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14101:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14413:16, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14413:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:51:1

Success on aarch64-linux (full log)
Attempted: linux
Partial log (click to expand)
/nix/store/irj9m3mjyj1azy2f4379z4x4jz3ndsbp-linux-4.14.73

Success on x86_64-linux (full log)
Attempted: linux
Partial log (click to expand)
/nix/store/2ywmvpg90z4jbbd8p1mfjdn70vna1q7d-linux-4.14.73

likely to time out, let's try anyway
@GrahamcOfBorg build linux_testing_hardened

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: linux_testing_hardened
Partial log (click to expand)
while evaluating the attribute 'linux_testing' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14135:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14135:19:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14422:16, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing.nix:3:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14422:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:51:1

Success on aarch64-linux (full log)
Attempted: linux_testing_hardened
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/ggxphdkq3xx32586w7k7nlylvvl4zzgk-linux-4.19-rc6

One successful build :+1:


Extract Spark configuration, secrets, init_scripts and libraries into the config

What is being addressed
Extract Spark configuration and libraries into a separate section of the config.
How is this addressed

Add spark_config section to the config and move the single-node configuration there
Add databricks_libraries section to the config and propagate all types of libraries supported by databricks terraform provider: https://registry.terraform.io/providers/databricks/databricks/0.4.2/docs/resources/cluster#library-configuration-block
Add databricks_cluster section to be able to configure the size of the cluster
Add init_scripts section to the config and upload a dbfs file from local filesystem
Add databricks_secrets section to the config and create corresponding secrets in the secret scope

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5788025632 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

@jjgriff93 @stefpiatek  Re-requesting your reviews please as I've made significant changes (added support for init_scripts and databricks_secrets)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5799823200 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5799903763 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5800044005 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5800447936 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5806622753 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

@stefpiatek  I am happy to remove these, as you said, they aren't currently used. I've kept the jar as I just realised we'll need it for the MSSQL JDBC driver.

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5807523748 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5809501246 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/5809625616 (with refid 0a055ddf)
(in response to this comment from @tanya-borisova)


Refactor project

Hi @sabinaaledort @yuvalk @shirmoran @aabughosh please take a look on this refactor.
I will for the conflicts tomorrow morning


TSIH (Target Session Identifying Handle) is missing?

Hello,
I wonder to know about the commentary at https://github.com/sebastiangraf/jSCSI/blob/master/bundles/target/src/main/java/org/jscsi/target/TargetServer.java#L232
It says about TSIH that should be implemented at the future. I would like to help to implement it based at  http://www.ietf.org/rfc/rfc3720.txt:

TSIH (Target Session Identifying Handle): A target assigned tag for
a session with a specific named initiator.  The target generates it
during session establishment.  Its internal format and content are
not defined by this protocol, except for the value 0 that is
reserved and used by the initiator to indicate a new session.  It
is given to the target during additional connection establishment
for the same session.
Based on the RFC 3720 I should get the session IDs and build these actions:

+------------------------------------------------------------------+
|ISID      | TSIH        | CID    |     Target action              |
+------------------------------------------------------------------+
|new      | non-zero    | any    |     fail the login             |
+------------------------------------------------------------------+
|new       | zero        | any    |     instantiate a new session  |
+------------------------------------------------------------------+
|existing  | zero        | any    |     do session reinstatement   |
+------------------------------------------------------------------+
|existing  | non-zero    | new    |     add a new connection to    |
+------------------------------------------------------------------+
|existing  | non-zero    |existing|     do connection reinstatement|
+------------------------------------------------------------------+
|existing  | non-zero    | any    |         fail the login         |
+------------------------------------------------------------------+
Looks like the TargetSession has the ISID and TSIH but CID (ConnectionID) where is?
Am I correct? Could you give me any advice? Like if I have to create new classes? Which methods?
Thanks in advanced. Felipe

Hi, I have some thing I think is related to it. The original problem is that after 10 hours of my microsoft iscsi initiator connect to the jSCSI target, the initiator try to reconnect, maybe a connection reinstatement, and it can't. I think it is related to ERROR_RECOVERY_LEVEL https://github.com/sebastiangraf/jSCSI/blob/master/bundles/target/src/main/java/org/jscsi/target/settings/SessionSettingsNegotiator.java#L155 that is set to 0 (zero) at target and 2 (two) at microsoft iscsi initiator.
Is that possible? Should I set both to zero?


Bugfix for Optim.jl on models with different linked dimensionality

See the test for an example that is currently breaking.
TL;DR: immutable versions of invlink and link avoid the issues of changing dimensionality between linked and invlinked reps that was causing this issue.
Probably related: https://github.com/TuringLang/DynamicPPL.jl/pull/525
NOTE: The Optim.jl interface and everything is due a rewrite IMO, but that is beyond the scope of this PR (because time is finite :pray:)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ext/TuringOptimExt.jl
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
1367

💛  - Coveralls

@yebai this should be a quick merge


Uncaught Error: This TextEditor has been destroyed

Uncaught Error: This TextEditor has been destroyed
Atom Version: 0.161.0
System: Mac OS X 10.10.1
Thrown From: linter package, v0.7.3
Steps To Reproduce

Writing JSON-object inside a JS-file.
On every save (cmd+s) I get this error.

Stack Trace
At /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:989

Error: This TextEditor has been destroyed
  at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:989:15)
  at Marker.module.exports.Marker.getHeadScreenPosition (/Applications/Atom.app/Contents/Resources/app/src/marker.js:211:33)
  at new Marker (/Applications/Atom.app/Contents/Resources/app/src/marker.js:45:41)
  at DisplayBuffer.module.exports.DisplayBuffer.getMarker (/Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1224:20)
  at DisplayBuffer.module.exports.DisplayBuffer.markBufferRange (/Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1256:19)
  at TextEditor.module.exports.TextEditor.markBufferRange (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1251:59)
  at LinterView.display (/Users/samppavalkama/.atom/packages/linter/lib/linter-view.coffee:180:26)
  at LinterView.processMessage (/Users/samppavalkama/.atom/packages/linter/lib/linter-view.coffee:159:6)
  at LinterView.processMessage (/Users/samppavalkama/.atom/packages/linter/lib/linter-view.coffee:1:1)
  at /Users/samppavalkama/.atom/packages/linter/lib/linter-view.coffee:142:14
  at LinterJshint.Linter.processMessage (/Users/samppavalkama/.atom/packages/linter/lib/linter.coffee:151:5)
  at /Users/samppavalkama/.atom/packages/linter/lib/linter.coffee:127:8
  at BufferedProcess.triggerExitCallback (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:59:47)
  at ChildProcess.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:81:18)
  at ChildProcess.emit (events.js:110:17)
  at Process.ChildProcess._handle.onexit (child_process.js:1072:12)

/cc @atom/core

Please upgrade to the latest version


"All versions of Windows" really means Win7.  Right?

On this page:
"All versions of Windows (Legacy method)
To enable Remote Desktop using the legacy system properties, follow the instructions to Connect to another computer using Remote Desktop Connection."
(GREAT! I can buy a tiny appliance PC with no monitor.  It will have W10Home - of course.  I'll just RDP to it from my tablet!  FOOL!)
Follow the link and it says:   "Applies to: Windows 7" in shy grey text.
Come on, man.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71cfbf1a-c5b7-df0f-8194-6ebc03afcc7d
Version Independent ID: f36b567f-aa48-2c8f-4908-b1fe18cd2842
Content: Remote Desktop - Allow access to your PC
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-allow-access.md
Product: windows-server-threshold
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


[Bug] DataStore API shows a "NONE" table that leads nowhere

Is your feature request related to a problem? Please describe.
when i setup a DataStore API and head to amplify console, I see this:

Describe the solution you'd like
this thing should lead somewhere useful or not show at all.

note that you can replicate this very easily setting up a simple project with a datastore api and then amplify push and amplify console.

Hi @sw-yx could you share your appId/region, also is there a specific sample project with datastore api you are using that we can look into on our side?

@ganipcanot d1o0jsrzznz3bj us-east-1
no specific sample project - this is just the default experience i get when i set up a simple project with all the default datastore settings.
i work at AWS, feel free to @wanshawn on Chime if you would like more info


Adds new command flow owner add, Closes #4559

This PR adds the new command flow owner add.
Closes #4559

Nice work! We'll try to review it ASAP!

Merged manually, thank you for this great addition!


[Task]: Update Drools dependency

What needs to happen?
Dependabot has created 2 PR's to update our Drools dependency.
https://github.com/apache/hop/pull/3218
https://github.com/apache/hop/pull/3217
Issue Priority
Priority: 2
Issue Component
Component: Transforms

.take-issue


Bootstrap error: Unable to resolve plugin "useragent"; no corresponding plugin with that name

I am not sure why this issue Issue #92   that was reported in 2020  was closed, as the problem is still there,
the problem was initiated in this commit
PHP Fatal error:  Uncaught Zend_Application_Bootstrap_Exception: Unable to resolve plugin "useragent"; no corresponding plugin with that name in /usr/share/php/vendor/shardj/zf1-future/library/Zend/Application/Bootstrap/BootstrapAbstract.php:332
I have the following lines in the application.ini
; Zend UserAent settings
resources.useragent.storage.adapter            = "Session"
resources.useragent.wurflapi.wurfl_api_version = "1.1"
resources.useragent.wurflapi.wurfl_lib_dir     = APPLICATION_PATH "/../library/wurfl-php-1.3.1/WURFL/"
resources.useragent.wurflapi.wurfl_config_array.wurfl.main-file      = APPLICATION_PATH "/data/wurfl/wurfl-latest.zip"
resources.useragent.wurflapi.wurfl_config_array.wurfl.patches        = APPLICATION_PATH "/data/wurfl/web_browsers_patch.xml"
resources.useragent.wurflapi.wurfl_config_array.cache.provider       = "file"
resources.useragent.wurflapi.wurfl_config_array.cache.dir            = APPLICATION_PATH "/data/wurfl/cache/"
resources.useragent.wurflapi.wurfl_config_array.persistence.provider = "file"
resources.useragent.wurflapi.wurfl_config_array.persistence.dir.dir  = APPLICATION_PATH "/data/wurfl/cache/"
The problem happens on Linux environment (case-sensitive filenames).
Please rename the file UserAgent.php to Useragent.php in /shardj/zf1-future/library/Zend/Application/Resource/
directory. (The filename in original Zend framework is Useragent.php).
I have tested that renaming file fixes the issue.

Any opinions on this one? Are we going to revert, possibly getting notices by compser 2?
Imo that's always better, than error while bootstrapping.


Support for Additional Mods (1.16.5)

With Dynamic Trees for 1.16 being released, the door to 1.16 mod compatibility opens.
Following the same rules as the 1.12 suggestion list, comment under this post 1.16 mods that could have Dynamic Trees compatibility.
Suggestions from the discord server will also be added here.
Please please please include how many trees a mod adds when suggesting

DO NOT suggest the following types of mods as they will not be considered:

Mods without a public source (such as MCreator mods)

Those in bold were considered and/or are being worked on.
When a mod is finished and published, it is removed from this list.
The stars are a rough estimate of how likely it is for me (subjectively, anyone is free to pick any!) to choose that mod.
It is based on how popular the mod is, how many trees it has, how unique these are and how interesting I find them.
0 stars just means i do not know enough about the mod, not that i do not like it.
Update from 1.12: (add-ons from 1.12 that have yet to be updated)

★★★★★Integrated Dynamics (1 tree)
★★★★★Mystical World (1 tree)
★★★★☆Tech Reborn (1 tree)
★★★★★Pam’s HarvestCraft 2 (49 trees)
★★★★★The Twilight Forest (8 trees)
★★★★★The Aether (3 trees)
★★★★★Tinker's Construct (3 trees)
★★★★☆Fruit Trees (port of Cuisine) (9 trees)
★★★★☆Forestry (35 trees)

New addons:

★★★★☆Pokecube AIO (17 trees)
★★★☆☆Druidcraft (2 trees)
★★★☆☆Ars Nouveau (4 trees)
★★★★☆Atmospheric (6 trees)
★★★★☆Architect's Palette (1 tree)
★★★☆☆Better End Forge (7 trees, 1 cactus)
★★☆☆☆Croptopia (26 trees)
★☆☆☆☆Simply Tea (1 tree)
★★☆☆☆Enhanced Mushrooms (2 mushrooms)
★★★☆☆Greek Fantasy  (1 tree)
★★☆☆☆Silent Gear (1 tree)
★★★☆☆Rediscovered (1 tree)
★★★☆☆Premium Wood (7 trees)
★★★☆☆Simple Farming (9 trees)
★★☆☆☆Tofucraft (2 trees)
★★★★☆Terra Incognita (2 trees)
★★★☆☆Explorercraft (3 trees)
★★★★☆Environmental (6 trees)
★★★★★Omni (4 biomes, 1 cactus)
★★★☆☆The Endergetic Expansion (1 tree)
★★★★★Desolation (1 tree)
★☆☆☆☆Ice and Fire (3 branches)
★★★☆☆Ex Nihilo: Sequentia (1 tree (not yet implemented))
★★★★☆Fruitful (1 tree)
★★★☆☆Bayou Blues (1 tree)
★★★☆☆Abundance (2 trees)
★★★★☆Better Badlands (1 tree, 1 cactus)
★★★☆☆The Outer End (1 tree)
★★★☆☆Outvoted (2 trees)
★★★★☆Alex's Mobs (1 tree for missing banana drops)
★★☆☆☆Ultra Amplified Dimension (1 cactus, dimensional world gen)
★★★☆☆Terra World Generator (world gen, possibly new species)
★★★☆☆Infernal Expansion (1 fungus)
★★☆☆☆Caves & Cliffs backport (1 tree)
★★☆☆☆Darker Depths (1 tree)
★★★★★Maiden's Marvelous Materials (8 trees)
★★★☆☆The Undergarden (2 trees, 1 fungus, 4 mushroom)
★★★★☆Malum (1 tree)
★★★☆☆Apple Trees Revived (2 trees)
★★★☆☆Treemendous (25 trees)
★☆☆☆☆Lord of the Rings Mod Renewed (a lot of trees)
★★★★☆Better Default Biomes (2 trees)
★★★☆☆Occultism (2 trees)
★★★★☆More Minecarts (1 cactus)
★☆☆☆☆Chaos Awakens (3 trees)
★★☆☆☆Unnamed Animal Mod (1 tree)
★★☆☆☆Werewolves - Become a Beast! (2 trees)
★★★★☆Tropicraft (6 trees)
★★★★★Water Source (1 tree)
★★★☆☆Horticulture (4 trees)
★★★★☆Blue Skies (7 trees)
★★★★☆Feywild (4 trees)
★★★★☆Charcoal Pit (6 trees)
★★★☆☆Advanced Rocketry (3 trees)
★★☆☆☆Advent of Ascension (29 trees)
★★★☆☆Spheric (3 trees)
★★★★☆Hal's Exploration Mod (1 tree)
☆☆☆☆☆Twist (2 trees)
☆☆☆☆☆World of Wonder (2 trees)
☆☆☆☆☆Terrestria Reforged (5 trees, 1 mushroom)
☆☆☆☆☆Better Nether Reforged (13 trees, 1 cactus)
☆☆☆☆☆Wilder Wilds (world gen)
☆☆☆☆☆Prehistoric Fauna (7 trees)
☆☆☆☆☆Primal Winter (6 trees)
☆☆☆☆☆Project Rankine (8 trees)
☆☆☆☆☆Corundum Meadows (2 trees)
☆☆☆☆☆Dregora (245+ biomes)

please more abnormals and aurora support

Perhaps the Betweenlands?

Perhaps the Betweenlands?

The betweenlands is not on 1.16?

https://www.curseforge.com/minecraft/mc-mods/corundum-meadows
Corundum Meadows will be amazing to be supported

dregora
https://www.curseforge.com/minecraft/mc-mods/dregora

Project: Vibrant Journeys
https://www.curseforge.com/minecraft/mc-mods/project-vibrant-journeys

https://www.curseforge.com/minecraft/mc-mods/pixelmon
Pixelmon has officially updated to 1.16. With it, they phased out the cute abricot bushlike trees for actual, MC style trees. Please consider adding Dynamic Trees support for them! There are quite a few, but they all follow the same body plan, so it shouldn't be too difficult to make an addon for.

With as popular as Ars Nouveau is becoming I think it would be cool to see a dynamic trees version

+1 for Undergarden;
How about Industrial Reborn? It uses the same Rubber Tree as EUC, IC2/IC2 Classic, so might be little bit less of work


Serialize permissions

Is there a way to serialize a user's abilities into something that can be sent as json and used on the client?

I think you can look into this https://github.com/CanCanCommunity/cancancan/pull/208

Closed, continue conversation on #208 please :)


[Joy] Add tests for slots/slotProps for all components

[x] I have followed (at least) the PR section of the contributing guide.

:warning: This PR must be merged after ##36599 and #36540 are merged.

This is on top of #36540.
Here's a filter of relevant commits for easier review: https://github.com/mui/material-ui/pull/36828/files/01cb82b550c119222d5babde2c90dca12d5b3d64..8fcafb66f84476d179b298db46fe626f2051e782

Both #36599 and #36540 are merged. This is ready for merge.


Remove arrow-parens rule override

Fixes https://github.com/iamturns/eslint-config-airbnb-typescript/issues/19

Thank you @apust !

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updated startskript

Solves a problem when a user has a userfolder with a space in the name (like "John Doe")

It looks like the languagetool pre-install has been updated and there is a conflict.
https://github.com/ScoopInstaller/Extras/blob/master/bucket/languagetool.json#L15
If the error still remains, do open a new PR.


Add result and condition filters to test results list

Related Issue

Closes #6303

Changes Proposed

Adds condition and result filters for test results list
To enable filtering on these values, the test results list now queries the GraphQL endpoint for results rather than test events

Additional Information

This is a follow-up to #6104

This work unrolled individual multiplex results for a test event into separate rows on the result table
Filtering worked fine for values that do not change between results within a test (patient name, test date, etc)
However, since result and condition vary within a single test event, these filters had to be updated for more granular access

Adds a new resolver and associated GraphQL schema and query definitions
Adds new service code and Specifications to apply filters from user to database retrieval

Testing
Name filter
https://github.com/CDCgov/prime-simplereport/assets/27730981/76bdbbb0-897d-4d62-9956-535bc8c01ff9
Date filters
https://github.com/CDCgov/prime-simplereport/assets/27730981/6343bd53-e621-4923-b136-002931b7fc0c
Condition filter
https://github.com/CDCgov/prime-simplereport/assets/27730981/6bd8d993-4c87-4cd7-8fad-4086e302331a
Result filter
https://github.com/CDCgov/prime-simplereport/assets/27730981/8b8ad220-85cd-4b67-b34c-ccc53ae6755d
Role filter
https://github.com/CDCgov/prime-simplereport/assets/27730981/970c42c4-7bc0-4dfd-bf12-aebdf89b79d5
Facility filter
https://github.com/CDCgov/prime-simplereport/assets/27730981/efa57eb1-a5f4-451c-9f6a-b07f56215f5e
Multiple filters applied; clearing filters
https://github.com/CDCgov/prime-simplereport/assets/27730981/d5a23017-c28d-4d5f-9e32-9746023c890b

@nathancrtr I noticed something interesting with this new functionality... if we correct a result is it now expected that we see the previously corrected test in the results page along with the newly submitted result?
To repro:

submit a test
correct result -> click something like "Incorrect test result"
see that it is added to the queue
submit the corrected result
go to the results page and see both the previous test and newly corrected test in the results


Adds Phone to createUser

What kind of change does this PR introduce?
Adds phone to createUser Stumbled upon this while clearing out todos on another branch
What is the current behavior?
Passes empty string to createUser
What is the new behavior?
Passes generic phone number "+9112345678" to  method
Additional context
None

@kangmingtay sounds good -- let me update the PR to remove the todo then -- think the other tasks have been addressed by other PRs


connection error

constantly get  password incorrect when trying to make a lobby.

i think its cuz i dont have the latest version i have 1.37

You must purchase the game to use our mod. We don't support pirated copies.


Enable auto-gomemlimit by default

Enable the auto-gomemlimit feature flag by default.

Mark the feature flag deprecated.
Add command line flag --no-auto-gomemlimit to disable.

3.0 cherry-pick: https://github.com/prometheus/prometheus/pull/15373

Updated to match 3.0 change.


WebDataset no longer has a length argument (documentation)

In the docs, it's mentioned that "you can specify an explicit size using the length= argument to WebDataset"
https://github.com/webdataset/webdataset/blob/2eaa96e6a266ad0ae1a1433e86eb6c2d3b7c50f8/docs/sharding/index.html#L177-L179
This is no longer true, as there is no length= argument to WebDataset.
https://github.com/webdataset/webdataset/blob/45724cdfcc0935c63ac6952c5f6b0ada9fa44f37/webdataset/dataset.py#L29-L39
I'm not sure if the documentation is out of date in mentioning a removed parameter, or if the parameter should be there, but got removed accidentally.

Thanks for the report. The v1 documentation is a bit out of date. Use webdataset.FakeLength for setting the length in v1. If you want to force a specific epoch length, use .repeat().slice(num_samples)
(In v2, you can use .with_length(n))
The __len__ method had to be removed because PyTorch considers having a __len__ method on an IterableDataset to be wrong.

Updated the documentation.


Using Python3 in Azure Python Functions

Please provide a succinct description of the issue.
Repro steps

Create Python App Function

Observe it uses Python 2.7.8

Add runtime.txt with content: python-3.4 (python 34 being already pre-installed)

Expected behavior
Should use Python 3.4
Actual behavior
It still uses Python 2.7.8
Known workarounds
I tried to get python3 running largely because the docs suggested it would work, and I am trying to get azure-storage sdk to work with Azure Python Functions.
On 2.7.8 it however only returns
from azure.storage.blob import BlockBlobService

  File "D:\home\site\wwwroot\AccountSink\run.py", line 7, in <module>
    from azure.storage.blob import BlockBlobService
  File "../pylibs\azure\storage\__init__.py", line 21, in <module>
    from .models import (
  File "../pylibs\azure\storage\models.py", line 27, in <module>
    from cryptography.hazmat.primitives.keywrap import(
  File "../pylibs\cryptography\hazmat\primitives\keywrap.py", line 12, in <module>
    from cryptography.hazmat.primitives.constant_time import bytes_eq
  File "../pylibs\cryptography\hazmat\primitives\constant_time.py", line 9, in <module>
    from cryptography.hazmat.bindings._constant_time import lib
ImportError: DLL load failed: The specified module could not be found.

We don't yet support Requirements.txt for setting Python environment. We currently don't officially support running Python 3 with Azure Functions, today, but this is something we'll address when we move from Python Scripting (experimental) to a full Python Functions implementation.

Is there any timeline for full Python Functions implementation?

Will it happen

This discussion is best tracked in the new python worker. https://github.com/Azure/azure-functions-python-worker/issues/6


Refactor/extract cacao updated

The order matters for when we create a new object. Our parameters t, s, and m have to be in that order. To make it dynamic would add complexity that we won't really benefit from right now


overswipe not working on touchscreen

Framework7 version: 4.0.0-beta.35 (also .34)
React.js version: 16.8.1
Platform and Target: OpenEmbedded (Linux) with Electron 2.0.2

Describe the bug
I use a List and ListItem with a swipeout and one SwipeoutButton has overswipe set. This works as expected and used to work fine also with version F7v3. After deploying to the embedded hardware, ever since F7v4 (both beta 34 and 35) the overswipe action is not applied. I have to slowly swipe the menu open and manually tap one of the SwipeoutButtons. They also won't always activate on first tap either - sometimes I have to retry 3 or 4 times, until the action is executed. As stated, it works fine with F7v3x
To Reproduce
That's the hard part. It only breaks on the embedded device with a touchscreen. It works just fine, when I open the same compilation on any other browser or platform.
regards, Tilli

Can you try to enable touch.fastClicks: true app parameter?

added that to my Framework7Params - will test on next deploy and let you know. thanks for the tip!

Yep, that's the problem! When activating fastClick, overswipe works again! Thanks for the tip!


How to get pop-up window in htmlunit ?

I use the following code:
HtmlPage page1 = webClient.getPage("https://***");
HtmlForm form = page1.getFormByName("form");
HtmlTextInput user = form.getInputByName("User");
user.setValueAttribute("username");
HtmlPasswordInput pwd = form.getInputByName("Pwd1");
pwd.setValueAttribute("password");
HtmlParagraph paragraph = (HtmlParagraph) page1.getByXPath("//p[@class='txt_center b_mrgn9 t_mrgn9']").get(0);
DomElement dom = paragraph.getFirstElementChild();
HtmlPage page2 = dom.click();
log.info("page2网页html:{}", page2.asXml());

page2 is same as page1.
In actual operation, after clicking the submit button, a new window pops up. How do I get the information of the pop-up window?
Thanks a lot!

I think you will need to add a web window listener to your WebCLient.
To save the pop up window:
final static LinkedList<WebWindow> windows   = new LinkedList<WebWindow>();
Add this to your WebClient:
webClient.addWebWindowListener(new WebWindowListener() {
		@Override
		public void webWindowOpened(WebWindowEvent event) {
			windows.add(event.getWebWindow());
		}

		@Override
		public void webWindowContentChanged(WebWindowEvent event) {
			// TODO Auto-generated method stub

		}

		@Override
		public void webWindowClosed(WebWindowEvent event) {
			// TODO Auto-generated method stub

		}
	});

And finally you can get the window as follow:
private static  HtmlPage getPopupPage()         {                 WebWindow latestWindow = windows.getLast();                 return (HtmlPage) latestWindow.getEnclosedPage();         }
More details check this.

@diaowenyang does the WebWindowListener work for you - if yes please comment here an close this.

So response from the author will close this for now. Please give me a hint if you still have this problem.


Remove /api/v1/index/retrieve endpoint from prober checks since it's experimental

ref https://github.com/sigstore/rekor/issues/1021
cc @bobcallaway
Signed-off-by: Priya Wadhwa<EMAIL_ADDRESS>

I had brought this up a while ago, but can we differentiate between critical prober alerts that should result in pages and ones that should result in tickets? I think we should still have visibility into the search API, but it doesn't need to trigger a page.

can we differentiate between critical prober alerts that should result in pages and ones that should result in tickets

I'm not sure, I don't think GCP let's you differentiate between alerts so it would have to be done in PagerDuty.
For now I can keep the endpoint data but turn off the alert on this endpoint?

@priyawadhwa I think you might need to update the ko?
- uses<EMAIL_ADDRESS>   with:
       version: v0.12.0

Could've sworn there were some screwiness that resulted in badness and it looks like things have failed twice?

LOL :) You already did it :)


rpm build failed

What happened?
Per nightly build result, the rpm build flow is broken
https://github.com/sustainable-computing-io/kepler/actions/runs/7237585836/job/19717413710
go: cannot find GOROOT directory: /usr/local/go
go: cannot find GOROOT directory: /usr/local/go
rpmbuild packaging/rpm/kepler.spec --build-in-place -bb
make: rpmbuild: No such file or directory

What did you expect to happen?
rpm build should work
How can we reproduce it (as minimally and precisely as possible)?
seen in nightly build
Anything else we need to know?
No response
Kepler image tag

Kubernetes version

$ kubectl version
# paste output here

Cloud provider or bare metal

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Kepler deployment config

For on kubernetes:
$ KEPLER_NAMESPACE=kepler

# provide kepler configmap
$ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE}
# paste output here

# provide kepler deployment description
$ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE}

For standalone:
put your Kepler command argument here

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@vimalk78 PTAL

I suppose it got fixed https://github.com/sustainable-computing-io/kepler/actions/runs/7320712888/job/19940182496

@SamYuan1990 yes. @rootfs made a release also.

close is it fixed. please reopen if needed.


Feature request for range + disabled dates

I am using the disabled dates function feature. It would be nice to allow ranges to be selected across disabled dates. I realize that this functionality is desired for some use cases as well, but a toggle would allow me to create a datepicker where a user can select the "end" of a range regardless of disabled dates falling inbetween. My use case is forcing a user to pick a certain number of days "after" the start date, and disabling those days so that the user must pick a date later than this specific time.

I'm on this same scenario, I need to disable dates, like holidays but allow the user to still select a range with those values in between.

Hello,
Disabled dates are not selectable by definition.
This behavior is appropriate for the vast majority of use cases.
Allowing to select disabled dates in range mode should be possible by removing the disabled class name from the day elements. one could trivially implement it as a part of a plugin.

Hi. I know this seems to be closed but the requested feature (and what I come across in some use cases) is that the user won't be selecting any disabled date but selecting across them so that the disabled dates will fall into the range. So user will still be selecting enabled dates only but having the ability to let disabled dates exists within the selected range.

any updates on this? Did anyone implement it and have a code sample? I don't think this use case is that unusual.

nusual.

do you find solution ?

I finally ended with a working solution to enable select ranges incuding disabled days, using jQuery style but can easily be ported to vanilly js
var $fp = $( "input[name=date]" );
$fp.flatpickr( {
     mode: "range",
     disable: [
         function( date ) {
             if ( true === $fp.data( "in-range" ) ) return false; // when selected 2nd date, bypass disable callback
             // here is the standard disable days callback
             return ( 0 === date.getDay() || 6 === date.getDay() );
         }
     ],
     onChange: function( date, str, fp ) {
        if ( 1 < date.length ) {
             $fp.removeData( "in-range" );
             fp.redraw();
         } else {
             $fp.data( "in-range", true );
         }

     }
 });

I ended up using 2 pickers to get more flexibility, the first picker is set to single mode, the second picker is set to range mode. When the first picker input is changed it updates the second picker's first range date. This way the first picker min date, max date, disabled dates can all vary from the second ones.
Here is how it looks:
loadStartCalendar() {
				this.siflatpickrstart = flatpickr('#flatpickr',{
					mode: 'single',
					dateFormat: 'Y-m-d',
					altInput: true,
					altFormat: this.dateFormat,
					allowInput: false,
					onChange: this.onChangeStart.bind(this),
				});
			}

			loadEndCalendar() {
				this.siflatpickrend = flatpickr('#flatpickr2',{
					mode: 'range',
					dateFormat: 'Y-m-d',
					altInput: true,
					altFormat: this.dateFormat,
					allowInput: false,
					onOpen: this.onOpenEnd.bind(this),
					onChange: this.onChangeEnd.bind(this),
				})
			}

onOpenEnd() {

				if(this.siflatpickrstart.selectedDates.length  === 0){
					this.siflatpickrend.close();
				}

				if(this.siflatpickrstart.selectedDates.length > 0){
					// set start date of end date picker range to start date of first input
					this.siflatpickrend.setDate(this.siflatpickrstart.selectedDates[0],false);

				}
			}

updateInputValues() {
				const endDateInputVisible = $('#flatpickr2').next('.form-control');
				const endDateInputHidden = $('#flatpickr2');

				// update end date input values (to hide start date of range)
				if(this.siflatpickrend.selectedDates[1] !== undefined){
					let endDateNotFormatted = moment(this.siflatpickrend.selectedDates[1]).format('Y-MM-DD');
					let endDateFormatted = this.siflatpickrend.formatDate(this.siflatpickrend.selectedDates[1],this.siflatpickrend.config.altFormat);
					endDateInputVisible.val(endDateFormatted);
					endDateInputHidden.val(endDateNotFormatted);
				} else {
					endDateInput.val('');
				}
			}

I did something like this:
var fp = $('.flatpickr-calendar, .flatpickr-days, .flatpickr-prev-month, .flatpickr-next-month');
fp.on('mousemove click', function(){
  $('.flatpickr-day').removeClass('notAllowed');
  $('.inRange').css('background', '#e6e6e6');
});

It might need some style adjustments...

I finally ended with a working solution to enable select ranges incuding disabled days, using jQuery style but can easily be ported to vanilly js
var $fp = $( "input[name=date]" );
$fp.flatpickr( {
     mode: "range",
     disable: [
         function( date ) {
             if ( true === $fp.data( "in-range" ) ) return false; // when selected 2nd date, bypass disable callback
             // here is the standard disable days callback
             return ( 0 === date.getDay() || 6 === date.getDay() );
         }
     ],
     onChange: function( date, str, fp ) {
        if ( 1 < date.length ) {
             $fp.removeData( "in-range" );
             fp.redraw();
         } else {
             $fp.data( "in-range", true );
         }

     }
 });

And fix CSS for better readability sass-code :
.flatpickr-day.flatpickr-disabled, .flatpickr-day.flatpickr-disabled:hover, .flatpickr-day.prevMonthDay, .flatpickr-day.nextMonth\
Day, .flatpickr-day.notAllowed, .flatpickr-day.notAllowed.prevMonthDay, .flatpickr-day.notAllowed.nextMonthDay {
    &.inRange {
	background: #e6e6e6;
    }
}

will this work on flatpickr?

Another solution for disabling dates in a range calendar:
const fp = flatpickr(dateRangeElement, {
    mode: 'range',
    onDayCreate: (dObj, dStr, fp, dayElem) => {
        // your custom logic for date selection comes here
        const weekday = ((dayElem.dateObj.getDay() + 6) % 7) + 1;
        if (bookableDays.includes(weekday)) {
            dayElem.classList.add('disabled);
        }
    }
}

and the corresponding CSS might be like:
.disabled {
    pointer-events: none;
    color: #999 !important;
}


Gesture events seem to not be sent on PlatformViewLink on Flutter 3.13

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Install Flutter 3.13
On an Android device, run the code on this repo: main/example
Expand the Wallets section and then click on Google Pay item
Click on the Google Pay button
Nothing happens

Expected results
We should be able to click on the Google Pay button.
Actual results
Nothing happens, it seems that the tap gesture is not sent to the PlatformView.
It works with Flutter 3.7.12
I filled an issue on the flutter_stripe repo in case it's on the package's side (https://github.com/flutter-stripe/flutter_stripe/issues/1393) but I don't understand why it works with Flutter 3.7 and not 3.13 then.
Code sample
Run the code from this repo: https://github.com/flutter-stripe/flutter_stripe/tree/main/example?rgh-link-date=2023-09-04T12%3A04%3A25Z
Screenshots or Video
No response
Logs
Logs
[   +1 ms] Flutter run key commands.
[        ] r Hot reload. 🔥🔥🔥
[        ] R Hot restart.
[        ] h List all available interactive commands.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] A Dart VM Service on IN2023 is available at: http://<IP_ADDRESS>:65325/pQqHbaZ1ILQ=/
[ +401 ms] The Flutter DevTools debugger and profiler on IN2023 is available at: http://<IP_ADDRESS>:9103?uri=http://<IP_ADDRESS>:65325/pQqHbaZ1ILQ=/
[  +42 ms] D/OplusScrollToTopManager(16156): com.flutter.stripe.example/com.flutter.stripe.example.MainActivity,This DecorView@1804249[MainActivity] change focus to true
[+1966 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[        ] D/OplusSystemUINavigationGestureExtImpl(16156): regionString = null
[        ] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +32 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +68 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +6 ms] D/OplusInputMethodManagerInternal(16156): get inputMethodManager extension: com.android.internal.view.IInputMethodManager$Stub$Proxy@1c8cb04
[        ] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[+1460 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +7 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +6 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +33 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +40 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +66 ms] I/PlatformViewsController(16156): Using hybrid composition for platform view: 0
[  +58 ms] D/BufferQueueConsumer(16156): [](id:3f1c00000002,api:0,p:-1,c:16156) connect: controlledByApp=true
[        ] D/BufferQueueProducer(16156): [SurfaceView[com.flutter.stripe.example/com.flutter.stripe.example.MainActivity]#1(BLAST Consumer)1](id:3f1c00000001,api:1,p:16156,c:16156) disconnect: api 1
[        ] D/BufferQueueProducer(16156): [ImageReader-1080x2260f1m3-16156-0](id:3f1c00000002,api:1,p:16156,c:16156) connect: api=1 producerControlledByApp=true
[  +92 ms] I/.stripe.example(16156): Compiler allocated 5021KB to compile void android.view.ViewRootImpl.performTraversals()
[ +904 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +10 ms] D/ProfileInstaller(16156): Installing profile for com.flutter.stripe.example
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +32 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +49 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +15 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +6 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +379 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +29 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +131 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +3 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +257 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +102 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +32 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +51 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +8 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[        ] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +283 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +20 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +32 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +50 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +32 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[   +9 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +318 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +36 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +18 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +97 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[        ] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[ +291 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +20 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +33 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +18 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +16 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +15 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +17 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +33 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[  +33 ms] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[        ] D/VRI[MainActivity](16156): handleWindowFocusChanged mWindowFocusChanged false mUpcomingWindowFocus true mAdded true
[+2406 ms] DevFS: Deleting filesystem on the device (file:///data/user/0/com.flutter.stripe.example/code_cache/exampleMSSDGH/example/)
[   +6 ms] DevFS: Deleted filesystem on the device (file:///data/user/0/com.flutter.stripe.example/code_cache/exampleMSSDGH/example/)
[   +4 ms] executing: /Users/romain.rastel/Library/Android/sdk/platform-tools/adb -s 87950fce shell am force-stop com.flutter.stripe.example
[  +89 ms] Application finished.
[   +2 ms] "flutter run" took 19 006ms.
[   +8 ms] Service protocol connection closed.
[  +32 ms] ensureAnalyticsSent: 37ms
[        ] Running 1 shutdown hook
[        ] Shutdown hooks complete
[        ] exiting with code 0

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.2, on macOS 12.5.1 21G83 darwin-arm64, locale fr-FR)
    • Flutter version 3.13.2 on channel stable at /Users/xxx/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ff5b5b5fa6 (11 days ago), 2023-08-24 08:12:28 -0500
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/xxx/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode-14.0.0.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.75.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (4 available)
    • IN2023 (mobile)            • 87950fce                             • android-arm64  • Android 13 (API 33)
    • iPhone 13 Pro Max (mobile) • F7BD4E2B-91F5-47DA-9594-0D808C2C260C • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.5.1 21G83 darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 116.0.5845.140

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @letsar

I filled an issue on the flutter_stripe repo in case it's on the package's side (https://github.com/flutter-stripe/flutter_stripe/issues/1393) but I don't understand why it works with Flutter 3.7 and not 3.13 then.

Since you are also not sure if this is a package issue or not, I would recommend you follow up on your opened issue there for better support. Once it's verified as a Flutter framework issue, please try to provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code so that we may verify this properly.
I will close this issue. Please write in the comments when you have more information for us. Thank you!

Hi @huycozy, since it works with Flutter 3.7 but not in 3.13 with the same version of the package, it seems it's related to Flutter, isn't it?
I know I didn't provide a complete and minimal reproducible code sample, but it's not easy to see what's going wrong here, that's why I came for help to both sides.

since it works with Flutter 3.7 but not in 3.13 with the same version of the package, it seems it's related to Flutter, isn't it?

Hi. There will be cases where the framework API has some changes but the package has not been updated to be compatible with them yet. You can also look at the release notes and breaking changes here to see if there are any suspicious changes.

There is nothing about changes about PlatformViews which should be addressed in this version, and if there were they should be breaking in order to be in a situation where changes has to be made, to not having a runtime issue.
Moreover, the code seems to work on some devices but not all (the android version does not matter). It really looks like a regression that should be addressed.

Reopening this issue for further investigation. The issue should be actionable with clear steps with minimal sample code to reproduce it. As mentioned above, flutter_stripe is a complex package, you should narrow down to the issue and try to re-create it with a simpler sample code. You can folk my minimal repo here and elaborate on it for reproduction. Thank you!

@huycozy  thanks for looking into it I have created a simple reproduction scenario that shows the issue: https://github.com/remonh87/platform_view_test . What is very curious is that when tapping on the android icon the callback is not fired but what is curious once I comment out layout.initialize() (line 27 on NativeView.kt) and press in the center of the screen it does work. It seems like that when button.xml is rendered the clicks are not occuring anymore.
Hope this helps

@remonh87 Thank you for the sample code but it seems not the correct one. It also doesn't work on Flutter 3.7.12 as mentioned above.

@huycozy  thanks problem is that Stripe is a huge sdk and it is not easy to create a minimal reproducible example. Is there an easy way I can triage that the click events are being send to the native side ? e.g. by adding some verbose flag in flutter

@remonh87 I am not aware if there is such a flag. Looks like you can only debug this by adding your own log to framework/engine code and finding where the bottleneck is.
To make it simpler, please try to provide a minimal sample if that is possible. Thank you!


On each gobco run, gobco creates folders that it doesn't cleanup

ababu17$ ls /var/folders/dc/ffvyv57j5dzf20lp3tlqfpqw0000gn/T/gobco-
gobco-09af28b7-af8d-408d-9032-4bdc1ed38432/ gobco-47d0be85-f3a1-4c34-a5fa-1b869ed0a45b/ gobco-8544638a-b5fd-47a4-b4ae-24fdd65a4147/ gobco-c32b52d6-b1a0-4a18-8c21-95fbcf2386b3/ gobco-ef7fe756-a826-4f89-a982-bf5f306c3533/
gobco-2033001c-eceb-428c-a7be-fb516c8edf17/ gobco-48d6af0e-6ba8-4b74-8dbe-081259199655/ gobco-879c5e44-0c0f-46cd-9436-a249fcbedb34/ gobco-c6e1336f-20a6-447e-86a6-1a035ef60f8a/ gobco-f04d467e-30c4-42f9-8772-561bcb4dd239/
gobco-23b03285-d1ea-4d71-b000-a4966f35433c/ gobco-4e3d2212-158e-4192-af1e-4eaf347d6e1d/ gobco-93d14d79-7b1a-4ae5-9325-56031bc75261/ gobco-d36b5b71-616b-481b-89b8-0148087b687f/
gobco-255e2c5d-0559-4413-9524-3ac5ed9f233f/ gobco-6243a4aa-8bbf-4973-bfee-98d6937fcb84/ gobco-9e31fd2c-69bb-4bb7-bf4b-c027fd6223a3/ gobco-dd6c3847-3cfc-49c4-8f43-dbc57b60088b/
gobco-367efb29-538a-415f-b8db-af545b5771be/ gobco-70ca82db-1137-40e3-b295-375e7a42a852/ gobco-9ff8c0f3-9234-4938-9615-013f7d4f2be7/ gobco-e6652f9c-0687-4cf7-b45a-a7bb0aab2b41/ ```

Please provide more detailed instructions on how to reproduce the situation. When I run gobco, everything is cleaned up as it should.
Please try again by installing gobco commit d7b2b5dde951c1693fa98ea36b7f3acf98211815 and then running gobco -verbose.

Ack will retry once again
Also, just out of curiosity why does it create another directory under /var/folders/dc as above? Sorry I really don't know if same is the case even with go test I have atleast not realised it with go test so far

Still... I see folders not being deleted on failed runs

When I took over gobco, it modified and instrumented the source code in-place, which was a terrible idea from the beginning.
I later fixed this by creating a temporary directory where I copied all the files that could be modified. To make this as realistic as possible, I had to create a complete GOROOT directory structure. This is probably what you mean by the "another directory".
I haven't looked at either vendoring or modules, therefore I may have missed the latest developments there. For me, copying the directories works fine though.
Regarding the "folders not being deleted", you still have to provide more details. I added some more debugging output in the commit I mentioned, to help you track down the cause. Could it be that your tests open a file but forget to close it again? Or they Chdir into a directory and then stay there? All these could be reasons why the folders are still kept. In any case, I need to see the output of gobco -verbose to continue guessing.

Feedback timeout.

I have observed this too. I'm not 100% sure of the reason. It may be certain kinds of test failure short-cut the clean up.
You might also want to add a signal handler to ensure clean-up still happens if you press control ctrl-C.
Something like https://stackoverflow.com/a/11131948/1569204


Add thewchan as maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@maresb
@marcelotrevisani
@beckermr
@conda-forge/core
Another package I'm trying to get onto Conda-forge needs an older version of this one as a dependency. Please add me as a maintainer so I can do that

hey, no worries, just a friendly reminder that if you need an older version you should create a new branch and integrate the modifications to this other branch

@thewchan, please use conda-forge/core sparingly and contact us if the feedstock maintainers are unresponsive or they need help.


update the console-telemetry-plugin and dbaas-dynamic-plugin version to 0.1.4

update the console-telemetry-plugin and dbaas-dynamic-plugin version …0.1.4
Signed-off-by: Abdul Hameed<EMAIL_ADDRESS>Description

Verification Steps

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

@tchughesiv once the image is updated we need to merge this PR to get version 0.1.4 for the console and telemetry

@tchughesiv once the image is updated we need to merge this PR to get version 0.1.4 for the console and telemetry

saw you have already the PR here: https://github.com/RHEcosystemAppEng/dbaas-operator/pull/99 let me know if this needs to close this

@redhatHameed yes... let's use mine please


Fix wrong Package desciption text

Bug/issue #, if applicable:
Summary
As suggested in #4 by @franklinsch, we should "adding a comment such as<EMAIL_ADDRESS>It seems there is some accidental mistake on the text in that related PR. This is a fix to that mistake.

@swift-ci please test

@swift-ci Please test


Random y

I feel like there's a way to get rid of all those if statements but I'm not sure how so to heck with it!


Update display list documentation for AI2 (The trivial change here is…

… to force a re-push)

What do you mean by forcing a re-push?

Someone I thought I'd pushed this to github before, but it's not there.
So I'm trying again.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Tue, Feb 16, 2016 at 5:37 AM, Jos<EMAIL_ADDRESS>wrote:

What do you mean by forcing a re-push?
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/706#issuecomment-184617753
.

Are you in the right branch? There's only one file change in here, and it's the trivial change you pushed last (no other changes than a space added to displaylist.html).

Change already made


Matt/make or break

@sconover it works...
bazel run //:woot like 3 or 4 times. Though notice the big readme warning. See second PR into this branch with change that uses a cache in the local directory.

Ok, I actually kindof like this option the best, because it puts the working directory in your source tree, we could default it to bazel-tsc or something like that.... I know the readme says don't read this, but I'm thinking the problem would be if we read the workspace dir, and then went into bazel-out.


missing document to implement CI/CD for mendix application with Selenium test suite

Please provide document how to code shell script to test mendix application with Selenium test suite

Hi @Sandip2182 I will add this to our backlog. I will close this comment, but respond when this documentation has been published. Thanks.


Synchronize artifacts from build environment to VM

Blocked by #118
Create a VM that could potentially run a registry, but for now, the scope of this work is to simply create a small VM that can hold the artifacts and allow a synchronize from the build VM to the artifact VM. This adds the functionality we'll need in the next steps.

Found a bug that I'll also be fixing in the loading of auto-kube-dev role imports.


Probable memory leak in native memory with subscription data

When running the server and logging the amount of allocated physical memory by the process, the amount of javascript managed memory and CPU usage, I am seeing a steady increase in allocated physical memory while the javascript memory is stable. That seems to indicate a memory leak in native code which should be investigated.
For the test I used the test-example/testSocketIO.js script with 10 clients.
Note that in the graph there is a drop in CPU usage and a stabilization of memory usage, this corresponds to market close.

By the way, in the same kind of testing with request/response data, the process memory usage was stable.


[Snyk] Upgrade react-i18next from 13.1.2 to 13.2.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-i18next from 13.1.2 to 13.2.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-08-22.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-2.azurewebsites.net


Layouts inheriting area classes

In the page_theme.php file you can define classes to be applied to areas in the getThemeAreaClasses() function. If you add a layout to this area, the new area(s) within (subareas) inherit the classes from their parent area. However, if you add a second layout within this layout (so you have Area -> Subarea -> Subarea) they do not inherit these classes.
I located the code which results in this functionality:
// Use the area handle as the key to map against area classes
$areaHandle = $a->getAreaHandle();

// If its a SubArea, find the parent handle and use that
if ($a instanceof \Concrete\Core\Area\SubArea) {
    $areaHandle = \Concrete\Core\Area\Area::getAreaHandleFromID($a->getAreaParentID());
}

What do you think about using a recursive function here that traverses up the layouts until it reaches the root area to find the relevant area classes? I've opened a pull request with my implementation: 6893.

This deserves some discussion: it's not recommended to add nested layouts.

Oh okay, I didn't realise that. Is that because it affects functionality or just from a design point of view?
I understand how using nested free-form layouts could result in some very messy and inconsistent pages but the layouts defined in getThemeAreaLayoutPresets() are really powerful and I've increasingly found myself using these in favour of page templates. This is the first issue I've come across so far, have there been other issues raised that leads you to advise against nesting?


compiletime.uninitialized refuses to compile in local position

Compiler version
v3.3.3
v3.5.0-RC1
Minimized code
object Test:
  locally:
    var x: Int = compiletime.uninitialized //error

Output
`uninitialized` can only be used as the right hand side of a mutable field definition

Expectation
No error.

Hum, that error looks completely correct to me, and informative too. It tells you exactly what's wrong. You can only use for fields, not for locals.

Hum, that error looks completely correct to me, and informative too. It tells you exactly what's wrong. You can only use for fields, not for locals.

Oh, I thought locals are fields, as in local fields. Why should this be a limitation?

Because none of our targets accepts an uninitialized local variable. ;) We wouldn't be able to compile it.

OK, thanks for the clarification


Inconsistency between algod and indexer API result

Subject of the issue
it seems like algod removes empty values and indxer doesn't.
Steps to reproduce
https://indexer-mainnet/v2/assets/278022289
{
"asset":{
"created-at-round": 15042440,
"deleted": false,
"index": 278022289,
"params":{
"clawback": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ",
"creator": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"decimals": 0,
"default-frozen": false,
"freeze": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ",
"manager": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"metadata-hash": "RUFEREU0NTVBOUNBQjBGRUU2NzBEREI2MDNBQjUyNDg=",
"name": "Mask #7",
"reserve": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"total": 17,
"unit-name": "MTMASK7",
"url": "https://bit.ly/3xLUSV0"
}
},
"current-round": 15252300
}

VS
https://node-mainnet/v2/assets/278022289
{
"index": 278022289,
"params":{
"creator": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"decimals": 0,
"default-frozen": false,
"manager": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"metadata-hash": "RUFEREU0NTVBOUNBQjBGRUU2NzBEREI2MDNBQjUyNDg=",
"name": "Mask #7",
"reserve": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"total": 17,
"unit-name": "MTMASK7",
"url": "https://bit.ly/3xLUSV0"
}
}

Expected behaviour
I'd expect indexer to return empty values just when they have a meaning.
Actual behaviour
Indexer returns the 0 byte address here when the user probably didn't set it at all.
Acceptance criteria:
The following params (clawback, freeze, reserve) should not be returned if empty.
These params are currently optional.

Duplicate of #939


v3.5: STM32WBA: Do not enable Standby by default

Describe the bug
On Zephyr 3.5, STM32WBA has Standby low-power mode enabled by default. That can cause issues if Kconfig PM_S2RAM is disabled (which is the default state) since we could enter an unsupported low power mode.
Expected behavior
Standby mode shouldn't be enabled by default, to keep things consistent with Kconfig PM_S2RAM.

On Zephyr 3.5, ...

Did you mean to write 3.6 here and in the title?

On Zephyr 3.5, ...

Did you mean to write 3.6 here and in the title?

Yes sorry, I mixed things up. Fixed

Merged


Front Counter training

Describe the issue
The users need responsive customer service and the needs more people responding to users/prospective customers.
Additional context
Add any other context, attachments or screenshots
Definition of done

Attend 5 or more meetings with the PO to get to know the processes (apprentice approach to learning)
Cap to a 3

Attended second training session on Sep 29th. with. Julian trained Catherine to add three templates in outlook using Quick Parts. The templates are copied in Teams CPF Gov FTE Internal "Front Counter" folder.

Still ongoing but will close next sprint


enhancements: Improvements to ViewModel resolution and fixing tests.

Added ViewModelKey and ViewModelResolver for improved  ViewModel resolution.
Improved disposal pattern in TestNavigationBaseViewModel.
Switched icons in NavMenu.razor to Bootstrap Icons.
Enhanced test setup by adding necessary services to DI container.
Updated GetViewModel and IMvvmNavigationManager to use object for keys. - Refactored MvvmComponentBase and related classes for better ViewModel resolution.
Added MvvmNavLinkBase for navigation link components, managing state and resources effectively.

@gragra33 kindly review the improvements I made.

@gragra33 kindly review the improvements I made.

Your revised Keyed support is not working. I'm getting errors navigating. The VM is not registered error.

@gragra33 kindly review the improvements I made.

Your revised Keyed support is not working. I'm getting errors navigating. The VM is not registered error.
Also in CounterTests, there is a duplicate constructor. Looks like a merge issue with my update.

Ok cool, looking at it now.

@gragra33 kindly review the improvements I made.

Your revised Keyed support is not working. I'm getting errors navigating. The VM is not registered error.
Also in CounterTests, there is a duplicate constructor. Looks like a merge issue with my update.

@gragra33 fixed the issues. It was the sample code, sorted that out and the test.

...KeyedTest...s are now broken. The tests are for interfaces, not concrete classes. The samples were changed, but not the tests. Also, the samples should be using ITestKeyedNavigationViewModel. If I change the sample from concrete to interface, both the sample and the tests (still) fail. The implementation I created, which you want to replace, supported both interfaces and concrete VMs.
Also CounterTests still has a duplicate constructor causing the test project to not compile.

Hey @gragra33, not sure if you pulled the latest changes of my branch, but I did fix all of that.
I'm not sure why the changes are not showing up on your end, it this because it's on my fork?
I will close this PR and I will push my branch to this repo then we can review the changes. I will update the comments there.


Homepage: Searching with 'Enter'

Reason (Why?)
In addition to the search button the user should be able to search with 'Enter'.
Solution (What?)
After the user types something in the searchbar and an autosuggest exists, he or she can select the suggested value with the first 'Enter'. If he or she presses 'Enter' again the search should start and lead to the resultpage.
Not doing
The search algorithm is already implemented.
Relation to other Issues
#42
Acceptance criteria
If an autosuggest exists for the search, the user should be able to select it with the first 'Enter'. After he/she presses 'Enter' again the search should start and lead to the resultpage. If there is no autosuggest for the search value the first 'Enter' starts the search.

The same should happen when the user selects a location and then presses
P.S. avoid redundance in the issue description (DRY principle). Leave section “acceptance criteria” empty if there is nothing more than what has already been described.

Von: MaiThiD<EMAIL_ADDRESS>Gesendet: Donnerstag, 2. Juli 2020 12:16
An: hochschule-darmstadt/einander-helfen<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Betreff: [hochschule-darmstadt/einander-helfen] Homepage: Searching with 'Enter' (#131)
Reason (Why?)
In addition to the search button the user should be able to search with 'Enter'.
Solution (What?)
After the user types something in the searchbar and an autosuggest exists, he or she can select the suggested value with the first 'Enter'. If he or she presses 'Enter' again the search should start and lead to the resultpage.
Not doing
The search algorithm is already implemented.
Relation to other Issues
#42 https://github.com/hochschule-darmstadt/einander-helfen/issues/42
Acceptance criteria
If an autosuggest exists for the search, the user should be able to select it with the first 'Enter'. After he/she presses 'Enter' again the search should start and lead to the resultpage. If there is no autosuggest for the search value the first 'Enter' starts the search.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/hochschule-darmstadt/einander-helfen/issues/131 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYWHSZ7YD2YNO3GSHOUVXLRZRM5TANCNFSM4OOXT4BA .  https://github.com/notifications/beacon/ABYWHSZVIWSNDYOUITJXQEDRZRM5TA5CNFSM4OOXT4BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JV3LHBQ.gif


How to find albumart from metadata

@ErwinvanderZwart I created a separate issue for this discussion, so we don't notify the other users in the other thread.
Getting album art for streaming services is actually the same principle as for local media, you would receive a relative URL with the metadata that you can invoke against any of your players. See the CurrentMetaData DIDL:
<DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns:r="urn:schemas-rinconnetworks-com:metadata-1-0/" xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/">
    <item id="-1" parentID="-1" restricted="true">
        <res protocolInfo="sonos.com-spotify:*:audio/x-spotify:*" duration="0:05:18">x-sonos-spotify:spotify%3atrack%3a5qAFqkXoQd2RfjZ2j1ay0w?sid=9&flags=8224&sn=9</res>
        <r:streamContent></r:streamContent>
        <r:radioShowMd></r:radioShowMd>
        <upnp:albumArtURI>/getaa?s=1&u=x-sonos-spotify%3aspotify%253atrack%253a5qAFqkXoQd2RfjZ2j1ay0w%3fsid%3d9%26flags%3d8224%26sn%3d9</upnp:albumArtURI>
        <dc:title>Intermezzo No. 3 in C-sharp minor, Op. 117 - Andante con moto</dc:title>
        <upnp:class>object.item.audioItem.musicTrack</upnp:class>
        <dc:creator>Johannes Brahms</dc:creator>
        <upnp:album>Glenn Gould plays Brahms: 4 Ballades op. 10; 2 Rhapsodies op. 79; 10 Intermezzi</upnp:album>
    </item>
</DIDL-Lite>

As you can see, the upnp:albumArtURI tag contains a relative url that you can append to the player base url, which would be http://player_ip:1400/
This is the data that is evented, you are talking about TrackMetaData, are you polling that data? It might differ slightly.

Some services will return a full resolution image, others will just give you a 150x150 image. In order to get the full resolution, you would need to resort to the SMAPI that Sonos provided, but that will also require authentication. I resorted to direct integration against some popular services and their open APIs in order to get a full resolution image.

Hi Jishi,
Thank you for your comment.
Yes we are polling data from a controller running Linux and LUA scripting. From LUA we run a script
that uses LUA socket and we van do anything with UPNP.
We get albumart from UPNP when playing local data or from iPhone, but the hard part is getting albumart working from streaming media.
I don't want to use API keys or any other credentials to keep the scripts simple to include (plug and play) so i'm looking for a way to fetch the album art from a source that is working for longer period.
This to avoid having lots of questions from integrators when it stops working as we do not deliver services on updates / maintainence. The Sonos is just a free nice add-on feature for the controller.
I prefer to use SMAPI because this will excist as long as SONOS excists (;
The problem i have is that some services like tune-in don't gives a albumArtURI but only TrackURI and Track metadata. I get radio station, current artist but no ART url / uri.
What services / open APIs do you use to get the artwork in that case? (without API key)
Thanks for your help so far.
Best regards,
Erwin van der Zwart
Schneider Electric Netherlands

Hi, I'm not using anything special to get the album art, I use the one provided with the event data that I receive when the playback starts. Are you saying that my library has correct album art but it isn't included in the GetMediaInfo call? In that case, it is a difference between evented data and what you retrieve when polling for data.

@jishi  Hi Jimmy,
I don't know..  I'm just looking for a way to resolve my issue and somehow I think you already use the
correct service i miss / overloop. (:
Maybe i do something wrong. All I know is that I can get albumart from AVtransport service with GetPositionInfo call when playing local media.
When playing radio or Spotify / Deezer / Tune-in radio stream the Albumart URL is not showed in the
SOAP reply, there is no aac:... xxxx Uri where I can add / prefix http://IP:1400/ to get absolute URL. I think / assume i need to do a second (additional) http call and post a SOAP enveloppe with some previous recieved data. I'm kind of in the dank here.,
What service do you poll to get the get the CurrentMetadata Didl? It looks like it shows more data then the GetPositionInfo data
Do you poll the contentdir service for thIs? If yes how does your http post looks like?
I'm happy when I can get 150x150 image from player, higer RES is nice in a later stage..
Thanks again for your help!
BR,
Erwin van der Zwart
PS: If you need help on building automation topics feel free to ask, that's my origin specialty  (:
(KNX / BACnet / Modbus / Canbus / Enocean / Zigbee / BLE / Serial / TCP-IP / Web / Javascript / LUA)

Okay, did some investigation, and the albumart is indeed part of the event data, but not when you invoke the UPnP endpoints directly. Best way would be to act on the event data if possible, but that requires you to keep an HTTP endpoint available for Sonos to POST data into.
You can take a shortcut, bu instead composing the album art uri yourself. Invoke GetMediaInfo from the active player, then use the CurrentURI node from the response (this would look something like this: x-sonosapi-stream:s20308?sid=254&flags=32
Urlencode it (e.g x-sonosapi-stream%3as20308%3fsid%3d254%26flags%3d32), then use that value for the u option in the following url scheme: /getaa?s=1&u=x-sonosapi-stream%3as20308%3fsid%3d254%26flags%3d32, and send that to any player in your network on port 1400, like this: http://<IP_ADDRESS>:1400/getaa?s=1&u=x-sonosapi-stream%3as20308%3fsid%3d254%26flags%3d32
The album art scheme is fixed for these kind of images. Some services gives you high-res version here, other services requires direct invokation against the SMAPI to get a direct CDN url for the high res version.

Hi Jimmy,
It's finally working  (: Big thanks for your assist!
I was so close now that i see your solution.
I already tried this approach but I 'forgot' to do the urlencode
on the CurrentURI value. Stupid (: I could know by the invalid chars..
Current resolution is good enough for now.
Again thanks!
BR,
Erwin van der Zwart

Glad I could help!

Hi Jimmy,
I think you should know this in a second, but i browsed the complete UPNP and can't figure out where it is.
How can i get the next track uri that will be played next? Do i need to go through the queue and check what is playing now and grab the next track? In shuffle mode this won't work i guess. Where can i get this from the UPNP structure?
Thanks!
BR,
Erwin

Hi. When evented, you get both current and next track as part of the same
message. I believe that there is a similar service method which would give
you the same data (GetTransportInfo?) which I believe you already use?
Can't verify now, but check if the response where you get currenturi
doesn't contain info about next track as well.

Hi Jishi,
I think i know where the problem is comming from, i start a track with  SetAVTransportURI
This causes the system to play the track as single track and not as track from the queue, and thats why it doesn't show the next track.
DO you know the correct command to start playing from queue when playing a favorite? When i already play from queue the seek function is working like expected.
I have tried x-rincon-queue:RINCON....#0 but this is not starting the queue when radio is playing.
I hope you an help me out with this last item i have.. (;
Thanks!
BR,
Erwin

Hi Jimmy,
I want to create a SONOS doorbell function over UPNP, i can fetch the current queue, and i know the current track, to start playing again. after this i know how to seek correct position and start again.
But i don't know how to restore this fetched queue
Do you have any tips how to do this? (not by node.js API, i use pure UPNP SOAP commands)
Thanks!
BR,
Erwin

Hi.
I do this with the clip-command in the http-api. Basically what it does is:
Remember the state of the player (basically, the correct avtransport and metadata, and if queue playback, the track number and elapsed time).
Send a new SetAVTransportURI with just a url with the audio clip you want to play. It will take mp3, wav, flac or aac files, I think.
Wait for the clip to finish playing (easy if you have a fixed time clip, VERY hard if you need dynamic waiting, trust me on this one ;) )
Restore the previously stored avtransporturi and metadata (important if this was an online radio). If it was a queue (basically, if it started with x-rincon-queue), send the approriate calls for setting current track, and also elapsed time. Then call PLAY!

Hi Jimmy,
Got it (; Tracknumber was the thing i was strugling with, it's now working, Thanks for pointing to this!
You might have a answer to another item i have, when grouping players i stop the coordinator, get volume, set this volume to the slave, add slave to coordinator and snapshot the group. After this is set uri and metadata and set mute to 0 and play group again.
All is working but the volume of the slave is not equal to coordinator but is reacting to group volume.
Whatever i try i can't get the volumes in sync so they are all equal in the group.
Any idea what could cause that?
BR,
Erwin

My experience is that the volume stays put during grouping, so I find the behavior that you are describing to be odd.
How are you grouping them? what call do you make?
In my lib, I group them first and then set volume, but I don't think it should matter. And also, although Sonos has the notion of "group volume" calls, they aren't actually used by the official controller. The official controller sends individual volume calls, and so do I because the group volume is unpredictable.

I set them like this (it's lua so you don't see complete function but gives you info you need)
function Add_Player_To_Group(ip, uuid)
if ip and uuid then
--ip = slave
--uuid = master
	-- Get ip address of group master by uuid
	MasterData = Get_Current_Sonos_Player_UUID(uuid)
	MasterIP = MasterData.ip

	-- Stop playing on master
	--upnpavcmd(MasterIP, 1400, 'Stop')

	-- Get current master volume
	MasterVolume = upnpavcmd(MasterIP, 1400, 'GetVolume','<Channel>Master</Channel><DesiredVolume></DesiredVolume>')

	-- Wait 1/2 second to process changes
	os.sleep(0.5)

	-- Set volume on added player same as master volume
	upnpavcmd(ip, 1400, 'SetVolume', '<Channel>Master</Channel><DesiredVolume>' .. MasterVolume .. '</DesiredVolume>')

	-- Wait 1/2 second to process changes
	os.sleep(0.5)

	-- Get current uri from master
	position_info = upnpavcmd(MasterIP, 1400, 'GetPositionInfo')
	if position_info ~= nil then
		for i in string.gmatch(position_info, '<TrackURI.-</TrackURI>') do
			if i ~= nil then
				current_master_uri =  i:match([[<TrackURI>(.-)</TrackURI>]])
			else
				current_master_uri = 'UNKNOWN'
			end
		end
		for i in string.gmatch(position_info, '<TrackMetaData.-</TrackMetaData>') do
			if i ~= nil then
				current_master_uri_meta_data =  i:match([[<TrackMetaData>(.-)</TrackMetaData>]])
			else
				current_master_uri_meta_data = 'UNKNOWN'
			end
		end
	end

	-- Add new player to group
	uri = '<CurrentURI>x-rincon:' .. uuid .. '</CurrentURI><CurrentURIMetaData/>'
	upnpavcmd(ip, 1400, 'SetAVTransportURI', uri)

	-- Wait 1 second to process changes
	os.sleep(1)

	-- Make volume snapshot
	upnpavcmd(MasterIP, 1400, 'SnapshotGroupVolume')

	-- Set group volume
	upnpavcmd(MasterIP, 1400, 'SetGroupVolume', '<Channel>Master</Channel><DesiredVolume>' .. MasterVolume .. '</DesiredVolume>')

	-- Set mute on group as unmute to be sure all players are unmuted
	upnpavcmd(MasterIP, 1400, 'SetGroupMute', '<Channel>Master</Channel><DesiredMute>0</DesiredMute>')

	-- Start playing saved URI
	--MasterUri = '<CurrentURI>' .. current_master_uri .. '</CurrentURI>'
	--MasterMeta = MasterUri .. '<CurrentURIMetadata>' .. current_master_uri_meta_data .. '</CurrentURIMetaData>'
	--upnpavcmd(MasterIP, 1400, 'SetAVTransportURI', MasterMeta)

	-- Start playing again
	Play(MasterIP)

	return true
else
	return false
end

end
BR,
Erwin

It's hard to figure out from that part of the code. If you can make network captures somehow of what is actually sent, it would make more sense. But from the looks of it, I can't see anything concrete that differs from my process.