Not working on Win10 15063

Hi, hFireF0X.
Thanks for your sharing.
I have tested this patch with a simple NTFS FSD hook driver, but it seems that PatchGuard is not successfully disabled, while DSE seemed to be indeed disabled, since the driver which was only self-signed successfully loaded into the kernel, with testsigning disabled.
I did nothing in the FSD hook, except DbgPrint and calling original MajorFunction. Dbgview shows that FSD hook successfully intercepted IRPs.
The Bugcheck codes match following pattern:
Bugcheck 109 (0xa39f****, 0xb3b6****, 0xffff****, 0x1c)
Original comment:
I'm testing on a freshly installed Win10 15063 x64 in VBox.
Simply launched patch.exe, and then pressed ENTER to continue.
but the program just showed the following line:
Patch: Press any key to exit
Then, window just disappeared after I pressed ENTER.
After that, it seems that neither ntoskrnl.exe nor MBR was modified.

You need to type CONTINUE all uppercase and then press enter. You just cancelled everything.

Sorry... What a funny mistake I've made.
The patch has been done successfully. I'll look in to see what will happen.
Thanks!

BTW, is it possible to disable PatchGuard using a driver which loads on boot? (just like procmon23.sys?)

Everything is possible, but why. Such bypasses was already implemented (see Skywing link in readme.md) before and even in various malware (WinNT/Turla for example). And all of them were later succesfully patched by next patchguard update.
PatchGuard is in ntoskrnl and initialize at it load. Which mean you have to:

reverse it, for all required os, find a way to disable verification routines or patchguard timers.
manage to load your driver (I doubt that your legally signed driver for PatchGuard bypass will last longer before your certificate revocation)

As you see this way is much more complicated and basically almost useless, because MS will update PatchGuard in next Windows 10 update again and broke your public method.
While the goal of this patch is to not allow this Microsoft whatever DRM/pseudosecurity rootkit code to even start. Slightly longer "why not" is here in #1
However if you still want - do it, I completely support your startup.

bcdedit showed that "Patch Guard Disabled" is the {current} entry, and it has been set to default.
C:\Windows\System32>bcdedit
Windows Boot Manager
identifier              {bootmgr}
device                  partition=\Device\HarddiskVolume1
description             Windows Boot Manager
locale                  zh-CN
inherit                 {globalsettings}
nointegritychecks       Yes
default                 {current}
resumeobject            {d75c3dc6-26ad-11e7-9724-f3533f0ccaca}
displayorder            {d75c3dc7-26ad-11e7-9724-f3533f0ccaca}
{current}
toolsdisplayorder       {memdiag}
timeout                 10
Windows Boot Loader
identifier              {d75c3dc7-26ad-11e7-9724-f3533f0ccaca}
device                  partition=C:
path                    \Windows\system32\winload.exe
description             Windows 10
locale                  zh-CN
inherit                 {bootloadersettings}
recoverysequence        {d75c3dc8-26ad-11e7-9724-f3533f0ccaca}
displaymessageoverride  Recovery
recoveryenabled         Yes
allowedinmemorysettings 0x15000075
osdevice                partition=C:
systemroot              \Windows
resumeobject            {d75c3dc6-26ad-11e7-9724-f3533f0ccaca}
nx                      OptIn
bootmenupolicy          Legacy
Windows Boot Loader
identifier              {current}
device                  partition=C:
path                    \Windows\system32\osloader.exe
description             Patch Guard Disabled
inherit                 {bootloadersettings}
recoveryenabled         No
nointegritychecks       Yes
osdevice                partition=C:
systemroot              \Windows
kernel                  ntkrnlmp.exe
resumeobject            {a0a08b2d-2994-11e7-8278-806e6f6e6963}
nx                      OptIn
bootstatuspolicy        IgnoreAllFailures
C:\Windows\System32>fc ntoskrnl.exe ktkrnlmp.exe
Comparing files ntoskrnl.exe and NTKRNLMP.EXE
00000160: E7 A8
00000161: 0F 8E
004C748B: 28 00
004C748C: 04 00
004C748E: C0 00
0054C59C: 8B 31
0054C59D: CE C9
0073E0DC: 40 B0
0073E0DD: 55 01
0073E0DE: 53 C3

Version of both two files: 10.0.15063.138
ntoskrnl.exe is kept unmodified as a backup, so it has a valid digital signature.
https://www.virustotal.com/en/file/30360ff2a41ab8ce733280aedfe61c0bbcb76a82cdb3d6c1f2859767f3d20ea5/analysis/
Patch before PG is able to initialize is a good idea, but modifying winload and ntoskrnl on disk is not friendly to Windows Update, since the updates to the kernel won't be applied to the PG-disabled ntoskrnl. In other word, I'd better have to disable Windows Update as well?
Maybe the attempt to patch PG initializing function by loading a boot time driver is too naive. But, it seems to be possible while using a MBR or .efi bootkit, which will do the patch in the memory, instead of modifying files stored on disk, so no matter how ntoskrnl changes, it will be patched by the bootkit, so that PG won't be able to start.
I wonder if such a bootkit is possible? especially on EFI based systems.
Thanks for your help.

Thanks for update. I forwarded this issue to Fyyre.
Yes, you have to update manually in normal configuration and patch again. Yes EFI bootkit sound very good. However since ntoskrnl also changing in these updates - you will have to update your software too. Simple example - cummulative update arrived and turned your system to the bsod loop, just because they updated PG and there is no guarantee that method you use will work again. So if you going to develop something like this - never release it on public anywhere, not as source not as article.

Hello,
Would it be possible to acquire your NTFS hook for further testing?
Thanks

Regarding question -- is possible to disable PG using mbr code.  Answer is yes, my bootkit_fasm did just this.

@Fyyre
https://gist.github.com/andronoob/d5882c5e6d21f3dea534a68434abe040

Thank you, I will perform some testing.

Issue is now fix.  15063 fully running NTFS hook or DKOM.  Update of code to follow in some days.

Please try from the 'test' branch and report status.  Thanks!

Please re-checkout the main branch, perform test.  Report status here.
Thank you.

Still failing to download symbol files now.

Tested KeInitAmd64SpecificState patch on 14393.447, did NTFS FSD hook, no bugcheck in about 5hrs.

Thank you for feedback =)  Is excellent hearing this!

Tested KiFilterFiberContext patch on 15063.0, no bugcheck with NTFS FSD hook in about 7 hrs.
Unfortunately, symbol files of 15063.296 are still failing to download.

They failing to download to every newly updated system I tried because MS didn't pushed updated symbols to their symbols server yet.

Manually patched 15063.296 with a hex editor, using KiFilterFiberContext patched 15063.0 kernel as reference.
NTFS FSD hook driver has been loaded, no bugcheck happened till now.

MS released symbols for 15063.296 kernel.

Closing this issue.  No Pg bugchecks occur after extensive testing.

@adeelmunir I've just pasted the inf file. Please use that inf file to install.


Intermittent error causes notifications to be stopped

I noticed today during a small network issue that the MongoNotificationObserver seem to have stopped receiving notifications, after a quick look through the logs I saw the error message detailed here https://github.com/sergeyzwezdin/Hangfire.Mongo/blob/7c3ae992719a0747d71380f13c97af1ef0769660/src/Hangfire.Mongo/MongoNotificationObserver.cs#L103
From what I can see of the code in this scenario you block on the cancellation token and don't restart the observer. I think it would be better to retry (maybe with an exponential backoff) to account for intermittent errors (network glitches) and so that if the collection was re-created as per the message the observer could continue without the need to restart the hosting service

@gottscj
Here's the full error I received
Error observing 'hangfire.notifications'
interrupted at shutdown
Notifications will not be available
If you dropped the 'hangfire.notifications' collection you need to manually create it again as a capped collection
For reference, please see
   - https://docs.mongodb.com/manual/core/capped-collections/
   - https://github.com/sergeyzwezdin/Hangfire.Mongo/blob/master/src/Hangfire.Mongo/Migration/Steps/Version17/00_AddNotificationsCollection.cs

I was just looking at the commit you made for addressing this https://github.com/sergeyzwezdin/Hangfire.Mongo/commit/5ef482af7452087593bbf091e73f673f6696f58a
Querying to check if the notification collection exists in the catch will be a problem in the scenario of a network error ,where the network has not recovered at that point. The ListCollections operation will throw an exception which isn't handled.
Also waiting on the cancellation token if the collection is not found does not allow for automatic recovery if the notifications collection is manually recreated, if this is desired behaviour then it would be good if the error message noted that you need to restart the server after creating the collection

@mikenorgate,
thank you for the suggestion. I added a very simple back off mechanism delaying retry by 5s for each try, max timeout is 60s.
you can override almost all behavior in Hangfire.Mongo by overriding the MongoFactory and implement your own behavior.
If you need or would like different back off behavior, simply override the MongoNotificationObserver and return that in the MongoFactory.

@gottscj I think that looks good. I didn't know about being able to override using MongoFactory, that might be really useful in the future


HELP! low accuracy on once dataset using pointrcnn.

I trained pointrcnn on once dataset for 80 epochs with the default config.
But got very poor accuracy as follows:

I wonder where's the problem, did I set the config wrong?
could u please give me some advice on how to improve the performance?
Many thanks!

The scores are as expected and similar to what was reported in the paper.
To further improve, you may try changing to a smaller batch size or adjusting the ball query radius, which might help a little.

Hi, thanks for your reply, why smaller batch size would help? do you mean set a bigger batch size?

I didn't try but I heard using batch size 1 can boost the AP by 2%
https://github.com/PointsCoder/ONCE_Benchmark/issues/31#issuecomment-1311804549

I guess it is because the training set is small so different batch sizes bring some randomness on the performances.


Crashes upon search after running OS updates

Ahoviewer version:
1.6.5-231-g2eb22dd
OS:
Arch Linux, kernel 5.10.90-1
After I ran updates (had been a few months) and rebooted, now ahoviewer crashes upon searching any term after loading for a second.
I tried doing a git pull to get the latest sources, and then rebuilt with those per the steps on here (normally I just use the AUR package) and I still had the same problem after doing a fresh build as well.
I setup core dumps, and looked at it a little with gdb, and it seems like maybe it could be an issue with my version of libcurl?
If you'd like some different GDB output, or any other info, I would be happy to provide them. Here's the GDB output I grabbed from the core file I generated so far:
gdb.txt
https://ghostbin.com/eFqTF/raw
I have the core file too if you want it, but I'm not sure where the best place to upload it is.

Also segfaulting on libcurl here. Downgrading to 7.80.0 from 7.81.0 does prevent the crash, though. The issue was definitely introduced by that version.

I looked through curl's 7.81.0 changes and there were a few to the curl multi interface.  I'll have to do my own testing before I can see how to fix it, or if it's an upstream bug.

I think it's caused by this:
https://github.com/ahodesuka/ahoviewer/blob/master/src/booru/imagefetcher.cc#L52
In curl it can cause errors if you call some curl functions from a curl callback. Which happens here if the timeout_ms is 0.
diff --git a/src/booru/imagefetcher.cc b/src/booru/imagefetcher.cc
index 9e1e81f..0182422 100644
--- a/src/booru/imagefetcher.cc
+++ b/src/booru/imagefetcher.cc
@@ -45,11 +45,9 @@ int ImageFetcher::timer_cb(CURLM*, long timeout_ms, void* userp)
 {
     auto* self{ static_cast<ImageFetcher*>(userp) };

-    if (timeout_ms > 0)
+    if (timeout_ms >= 0)
         self->m_TimeoutConn = self->m_MainContext->signal_timeout().connect(
             sigc::mem_fun(self, &ImageFetcher::timeout_cb), timeout_ms);
-    else if (timeout_ms == 0)
-        self->timeout_cb();
     else if (timeout_ms == -1 && self->m_TimeoutConn)
         self->m_TimeoutConn.disconnect();

This fixes the issue for me, but maybe there's a better solution.

Okay this was certainly a bug in ahoviewer then. ce4f2ab should fix the problem and have no effect for anyone using older versions of curl.


Input.js does not set required on the underlying  element

The input component should pass required to the <input /> tag it renders. At the very least we need this for accessibility reasons: https://stackoverflow.com/questions/37974796/when-to-use-the-required-attribute-vs-the-aria-required-attribute-for-input-elem

Works for Input, TextField and TextArea.  Needs to be fixed for Checkbox.

fixed with PR #678


Created a success page for user flow after kids select an emoji

Added a success page after kids select an emoji after an event. They will be able to see a "Thank you for checking in" message as well as a cute picture of a dog that is randomly generated via dog.ceo API.

Everything looks good just like Louis stated I am wondering about the deletion of the package-lock.json file. Other than that we are looking good and the random dog image is a good idea can't wait to see it all together .


istio-agent: add checks for XDS root CA existence

Adding additional checks for the existence of root CA certs for the XDS
connection. This helps XDS initialization to fail early, instead of obscure
envoy errors.
Signed-off-by: Kailun Qin<EMAIL_ADDRESS>[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@kailun-qin: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
811756ce2ce4b86d35492c922e8404ed8700f1c3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Minor fix on README link to scale

Thanks a lot for this @wirednkod ! I guess this goes to show for how long I've been working on this sweat_smile Thanks again, much, much appreciated!

No worries - more will come


Added endOfDay to include the data of today

Added endOfDay() to now() to include data of the current day.
Related to issue #5

@timvandijck @freekmurze
Could somebody please check this? Thanks

Looks, good thanks for the contribution!


feat: use wasm-opt to decrease forwarder contract size

Applying the wasm-opt utility decreases the size of the aurora-forwarder.wasm contract from 173 to 152 Kbytes. This, in turn, allows to decrease the required balance for the forwarder account from 1.8 to 1.53 N.

@raventid yes. But it's about the main aurora contract.


How to enable tracking settings?

Hello, I just started using this SDK and I saw on the USE CASES file: https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/mail/USE_CASES.md#kitchen-sink---an-example-with-all-settings-used
That there is an object called "trackingSettings", but on this file there is no example on how to use it:

trackingSettings: {},

Can someone give me some tip on how to configure this object to get "Open" and "Click" event tracking enabled?

"trackingSettings": {
	"clickTracking": {
		"enable": true
	},
	"openTracking": {
		"enable": true
	},
	"subscriptionTracking": {
		"enable": true
	}
}

Done.


DRAFT: operators-installer - fix warnings about unset securitycontext configuration

What is this PR About?
fix warning messages about security context information not set in jobs when applying against openshift
Warning 1
Warning: would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "installplan-approver" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "installplan-approver" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "installplan-approver" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "installplan-approver" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

Warning 2
Warning: would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "installplan-complete-verifier" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "installplan-complete-verifier" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "installplan-complete-verifier" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "installplan-complete-verifier" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

How do we test this?
the built in tests should ensure no regression.
i manually tested applying against a 4.12 openshift cluster and checking that the warning messages went away.
cc: @redhat-cop/day-in-the-life

force a re-test with no changes as it seems the last round of tests failed due to random kind cluster time outs

there is an actual bug with the tests, kind is running the job pod as root so conflicting with the runasnonroot...

this is a bigger rabbit whole then i thought and i already waisted a bunch of time.
summery of the problem. kind does not have mutating admision controls that set the runAsUser like an openshift cluster does, so container runs as root since thats what hte image specifies. but the ssc is saying, dont run as root, so jobs fail to run on kind cluster.
i can set the runAsUser to something other then 0 and it runs fine on kind, but then it wont run on openshfit without "runasanyid".
could add in some flag to set the runAsUser when running tests, but that is annoying.
i went down rabbit whole of tyring to put an admission controller on the kind server which would set the uid. stakrox even has one. https://github.com/stackrox/admission-controller-webhook-demo. buuuuttttt.. it hasn't been udpated to work with the released spec of admission controller, its still on beta. someone has a PR to try and fix that, i tried that PR. that didnt work either.
no good answers here. so the warning on openshfit will stay for now.

and the same goes for this PR maybe @itewk? 👀 🙏

OBE / i give up.


cloud.redhat.com hostname mentioned inrepository insights-results-smart-proxy in file docs/io-pulling-crd-internal.svg

cloud.redhat.com hostname mentioned inrepository insights-results-smart-proxy in file docs/io-pulling-crd-internal.svg

REST API is not moved -> closing this on.


Eventmachine prevent compatibility with Ruby 2.2.0

Eventmachine is running 1.0.3 which is not compatiable for Ruby 2.2.0. EventMachine fixed this 15 days ago with https://github.com/eventmachine/eventmachine/issues/495 at release 1.0.4.
Suggesting to change gemfile to eventmachine 1.0.4 or restrict project to Ruby lower than 2.2.0.
em.cpp:827:9: error: use of undeclared identifier 'rb_thread_select'; did you mean 'rb_thread_fd_select'?
return EmSelect (maxsocket+1, &fdreads, &fdwrites, &fderrors, &tv);
^~~~~~~~
rb_thread_fd_select
./em.h:25:20: note: expanded from macro 'EmSelect'
#define EmSelect rb_thread_select

@achiinto fixed at https://github.com/peatio/peatio/commit/f0a0076094966c68ea9e6324565057fab98a3eec
But eventmachine is not the only issue for Ruby 2.2.0 compatibility, and support 2.2.0 is not our top priority at the moment, I suggest using Ruby 2.1.5 instead of it.

@lgn21st my idea is that it would be best to restrict the ruby version and documented somewhere.


[Mobile] Text Selection only preserves the last boundary update,  all previous updates are lost during the same session.

My issue is about [Android] on Quill Version 5.03 read only editor with enableinteractiveselection set to true
I have tried running example directory successfully before creating an issue here.
Issue Description and steps to reproduce:
Given text "... abcdefghijklmn ...", follow the following steps:

long press on character e, now text becomes  abcdEfghijklmn ...   [correct so far]
extend the starting boundary from before e to before d, now text becomes abcDEfghijklmn ...    [correct so far]
extend the ending boundary from after e to after f, now text becomes abcdEFghijklmn ...    [incorrect]

Desired behavior
should produce  abcDEFghijklmn ...    after step 3.
Analysis
The problem could be fixed in either

widgets/controller.dart [line 326] _updateSelection(textSelection, source) method
widgets/text_selection.dart [line 517] _handleDragUpdate(details)

changes to the text selection is originally generated in _handleDragUpdate, however when newSelection is generated, in line 531 and/or line 539, it does not take into account of the old selection's value because by the time execution reaches 529, the original value in widget.selection is already overwritten. So even though line 531/539 APPEARS to take into account of the old value on the supposedly 'not updated' boundary,
When the inaccurate newSelection is passed downstream at line 554, unfortuntely the important information of _TextSelectionHandlePosition is forever lost, hence controller.dart _updateSelection(textSelection, source) method does not have enough information at this stage to merge old and not-so-accurate-new-value into the correct new value at line<EMAIL_ADDRESS>Furthermore, I am not sure about the rationale behind line 327 to 331 in controller.dart _updateSelection method
void _updateSelection(TextSelection textSelection, ChangeSource source) {     _selection = textSelection;     final end = document.length - 1;     _selection = selection.copyWith(         baseOffset: math.min(selection.baseOffset, end),         extentOffset: math.min(selection.extentOffset, end));
simply by static analysis, at this stage the aforemetioned lines is just equivalent to
_selection = textSelection;
I propose either directly produce the correct newSelection value in text_selection.dart or modify the api to accomodate passing _TextSelectionHandlePosition flag info downstream so that _updateSelection in controller.dart can reconstruct the correct final value.

Please submit a PR to fix it.

You can go ahead with your proposal - looks good

Furthermore, I am not sure about the rationale behind line 327 to 331 in controller.dart _updateSelection method
void _updateSelection(TextSelection textSelection, ChangeSource source) { _selection = textSelection; final end = document.length - 1; _selection = selection.copyWith( baseOffset: math.min(selection.baseOffset, end), extentOffset: math.min(selection.extentOffset, end));

This is to deal with image/video, the offset could be off by 1

Check out https://github.com/singerdmx/flutter-quill/blob/master/CodeIntroduction.md

@singerdmx ,

Furthermore, I am not sure about the rationale behind line 327 to 331 in controller.dart _updateSelection method
void _updateSelection(TextSelection textSelection, ChangeSource source) { _selection = textSelection; final end = document.length - 1; _selection = selection.copyWith( baseOffset: math.min(selection.baseOffset, end), extentOffset: math.min(selection.extentOffset, end));

This is to deal with image/video, the offset could be off by 1

Thanks for the clarification, now that I understand the original intention surrounding the boundary check, let's suppose the offset is indeed off (by syntax we know the 'off' is an overflow) by 1 after crossing over some image/video, and suppose this is indeed corrected correctly by the boundary check when it is hitting doc.length, since regardless of hitting doc.length, off by 1 is a known post-condition of TextSelection crossing over image/video, then am I correct to deduce when there is media crossing and it did not hit or reach doc.length, this code would actually update to the wrong value?
On requesting PR, I would be happy to fix the issue, but given the massive refactorings, my limited experience with the code base and the limited scope my usecases, I am not sure if it is fit to be merged into the main branch as I don't know if I am  breaking other things and affecting other users. I was thinking someone from your dev team originally working on this feature with competent background knowledge and issue awareness could pick up the issue and locate the bug easily.
Based on my own finding, at the moment quill is one of the best open source rich text editor on the flutter platform, I don't think forking off quill to start a new project and dilute its user base is fair to the original dev team, but I do think the code base has some potential for improvement. It has the potential to become the single goto editor in flutter, I was hoping you guys have some plans for redesigning the code base to strip away all the technical debts and feature burdens and built a core library with no bullshit and just refactor the current quill to depend on the core library, the current quill then maintains expansion features building on top of the core, saving your userbase while making future bug-fixing and maintenance much easier.
I was hoping in the core library, these dependencies could be removed.

flutter_colorpicker: ^1.0.3
image_picker: ^0.8.5
photo_view: ^0.13.0
url_launcher: ^6.1.0
video_player: ^2.4.0
youtube_player_flutter: ^8.0.0
i18n_extension: ^4.2.1
gallery_saver: ^2.3.2

My argument goes like this, even though the inner API and message passing is a bit messy at this stage, the front facing API is well designed enough, to the extent that for whatever new features I needed in the past, I could easily build on top of quill without modding its source code, quill being a foundational infrastructure should not be too concerned with feature sets, especially when UI features and functions are so easy to implement in flutter.  Most of the libraries mentioned above are not production-grade, they are not adding value to quill. Colorpicker, photo-view, video-player, you-tubeplayer, gallery save are just trash. On the other hand, you already have functional embedBuilder, and urlLanch handler in your editor's  constructor arguments, why then import url_launcher and video players etc in quill, users making their own import can achieve the same goal with one line of code. For i18n, infrastructure library should not dictate users on what other infrastructure lib to use, just like you don't want to develop quill with getX, leave those decisions open to the user, depending on i18n 4.2.1 in quill would force some users to include multiple i18n solutions in their pubspec.

Regarding getting rid of those dependencies, you are welcome to replace the so-called trash with better one. Forcing users to implement their own is not ideal.
You are entitled to your opinion but not entitled to facts. Most uses just want a library that just works without needing to implement Additionally. You have to understand there are different people out there using this library. By making it better we should provide better color picker and etc.

The so easy to implement features should be included here and you are welcome to replace existing one with better. Your ask may be legit but most users are not like you.

when it is hitting doc.length
Off by 1 is subtracting 1, when would it exceed the doc length.
I think the root cause is not here

Why do you think this issue is related to video/image?

For example if you want to get rid of image_picker, please submit a PR replacing it with whatever you have to make it better. I am happy to accept your PR and then image_picker is gone.

The point here is that we provide the best implementation in this library for image picking, not forcing users to implement.

I think I misspoke about line 327 to 331 in controller.dart
Let me try to recall what logic is behind it.

 We probably can remove it

@singerdmx

I was hoping you guys have some plans for redesigning the code base to strip away all the technical debts and feature burdens and built a core library with no bullshit and just refactor the current quill to depend on the core library, the current quill then maintains expansion features building on top of the core, saving your userbase while making future bug-fixing and maintenance much easier

I think you misunderstood my point. I am not saying you ditch those libraries in quill

I was hoping in the core library, these dependencies could be removed

I am saying in there is a set of mission critical core functions which need to be correct with the highest priority, these can be isolated into a core package, so that when a bug is found in those mission critical core functions, it can be fixed faster, without meandering into mysteries whether my fix in core is going to break some video embed or color picker. On the other hand, because implementations of those expansion feature set in quill such as color picker now moves out of quill, it is forced not to rely on easy access to private state in core, but only publicly exposed apis, those additional features will be automatically more robust against core's internal changes.
Anyway feel free to close the ticket for now, I will reopen/link to this the issue when I get a fix ready, you can then take a look if you like those changes, then migrate, if not then so be it. It will be sometime in September.

Make sense.
Yeah we should track this seperately

BTW you mean we need to publish two packages in pub.dev, right?
One package for quill logic and second package for those dependencies.

On the other hand, because implementations of those expansion feature set in quill such as color picker now moves out of quill, it is forced not to rely on easy access to private state in core, but only publicly exposed apis, those additional features will be automatically more robust against core's internal changes.

I agree. I wanted to do this at one time. Then some users told it is ok... then I let it go :P

Thank you for the report, this issue has been open for a while and since there are no interactions with it, we had to close it
but if you still facing this issue, or other issues or you have any other questions, feel free to contact us anytime you want.


Fix filter_passwords for hash without a value

Some settings that we want to filter specify a set of properties to
collect and do not have a value.  The standard password filter skips
keys that don't have values which don't work for this case.

Ivanchuk backport details:
$ git log -1
commit 267dc50f10204db9ed976c1de09a958860b75126
Author: Jason Frey<EMAIL_ADDRESS>Date:   Tue Aug 13 14:36:55 2019 -0400

    Merge pull request #19144 from agrare/fix_filter_passwords_for_manifest

    Fix filter_passwords for hash without a value

    (cherry picked from commit 5300a96eb0a6ab95703b8f92589eeaa6322a67d5)

    https://bugzilla.redhat.com/show_bug.cgi?id=1744611


Deploy in a container

It would be good to be able to deploy Artemis as a container. To do this we need to be particularly wary of the dependencies it has and to make sure these are still accessible:

Artemis must still run local to the beamline (for reliability)
Currently Artemis needs access to the shared file system to read/write the following:

GDA lookup tables
Write log files
Zocalo config (might need to be gda2 user)
Ispyb config (might need to be gda2 user)

We must have Channel Access read/write permissions
We must be able to access the Artemis Flask server from GDA
We must be able to read/write to ispyb
We must be able to read/write the zocalo queue
We must be able to write to graylog

Acceptance Criteria

Artemis runs in a container
All of the above work

@coretl you asked for this list a few weeks ago

@bentom08 any other external dependencies I'm missing?

Closing as duplicate of https://github.com/DiamondLightSource/hyperion/issues/1367


ZString benchmarks are wrong and misleading

You never dispose the ZString instance which means that the pooled buffer is never returned. This will dramatically impact performance.
As an aside, is this library based off of the dotnet/runtime ValueStringBuiilder? It seems to be nearly the same implementation, just split up.

You never dispose the ZString instance which means that the pooled buffer is never returned. This will dramatically impact performance.

Fair point - I will correct that. Anyway I thought of leaving out that comparison in the first place.
Here are the results with the updated version:
|                         Method |      Mean |    Error |   StdDev | Ratio | RatioSD |   Gen0 | Allocated | Alloc Ratio |
|------------------------------- |----------:|---------:|---------:|------:|--------:|-------:|----------:|------------:|
|            DotNetStringBuilder | 164.03 ns | 2.256 ns | 2.000 ns |  1.00 |    0.00 | 0.2370 |    1488 B |        1.00 |
|             ValueStringBuilder | 114.84 ns | 2.138 ns | 2.000 ns |  0.70 |    0.02 | 0.0892 |     560 B |        0.38 |
| ValueStringBuilderPreAllocated |  91.68 ns | 0.815 ns | 0.680 ns |  0.56 |    0.01 | 0.0892 |     560 B |        0.38 |
|             ZStringBuilderUtf8 | 137.06 ns | 2.699 ns | 3.213 ns |  0.84 |    0.02 | 0.0892 |     560 B |        0.38 |
|            ZStringBuilderUtf16 |  69.58 ns | 1.377 ns | 1.586 ns |  0.43 |    0.01 | 0.0892 |     560 B |        0.38 |

As an aside, is this library based off of the dotnet/runtime ValueStringBuiilder? It seems to be nearly the same implementation, just split up.

No, it did start out as an experiment to play with Span and friends. I checked the ValueStringBuilder on dotnet/runtime, and it has way fewer functions than the one you can find in this repository. But yes the idea is the same obviously as this is a common pattern.

I appreciate the background and that looks much better! I was expecting your library to be in parity with ZString and it is great to see that they're roughly the same. All in all, your library is another great option in the space!

Thanks for the tip about ZString - interesting to see those differences. Much appreciated.
Is it fine if I close the ticket?

Yes please. Thanks!


Permission design question

(the eosc examples uses the last parameter as the permission level to authorize)
Suppose that we have the following permission structure over account1
owner<--active<--newperm
by doing
./eosc set account permission account1 newperm EOSxxxxxUxF active active
Then we set "newperm" as the minimum permission to call updateauth over account1 using eosc.
./eosc set action permission account1 eos updateauth newperm active
It is the expected behavior to allow us to change the "active" authorities (or any other parent permission authority) by just satisfying the "newperm" permission?
./eosc set account permission account1 active EOSxxxxxMuE owner newperm

In the latest code, this is not allowed anymore. I'm closing this issue


erlang: restructure docs

This is a restructuring the Erlang/Elixir docs to be similar to the other docs on the site.
I wanted to get this in before adding additional pages that expand on the content, topics like Resources and Exporters.

Preview: https://deploy-preview-2541--opentelemetry.netlify.app/docs/instrumentation/erlang/

@ferd can you take another look?

Thanks @tsloughter, these are very good changes

@cartermp Thanks for the review and merge! I have another one coming soon :)


Attach to Body, or as high in the DOM as possible

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[X] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

The overlay gets added inside the gallery component, but there's some other components that are rendered on top of the overlay, in particular flex based components
Expected behavior

The overlay should be the first element in the HTML if possible, so no need to fiddle with z-indexes or anything.
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

- Node version: XX
- npm version: XX
- Platform:
- Angular version: X.Y.Z
-

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

I never though about this, but It could be a good idea.
What are you trying to say is that I should attach the css class with semi-transparent background directly to the body tag of the document instead of a ?

I have this problem, too

Please could you explain me why this is a problem? Could you give me a scenario (if you want also on jsbin or plnkr.co)?
I tried to work on this, but changing the current behaviour created lot of issues.
I need a solution that shows a background over everything (also over things with really high zindex, as navbar in bootstrap 4).

I have the same problem. It e.g. occurs when I place the gallery inside a css grid (display: grid).

This could solve the problem with issue #95.
If its appended to body all the grid:css and modals do not block the gallery.

I'll investigate again in August, because I'm completely full until the beginning of August.
PS: if you have a resource or other stuff to do this, please share it.

Other libraries are using @angular/cdk/overlay to archive this.

Interesting, I'll investigate a bit next week. thank you.

Hello, do you have any update on this, I'm having the same problem, the preview of an image is shown inside a component and not over the whole screen viewport.

Another issue is that I can still use the scroll behind the overlay, here's an image of that:

sorry, no news at the moment

@domiSchenk can you share the name of some of those libraries to see how they are using cdk? Thank u.

Thank you @Ks89

Fully implemented (branch 800) and scheduled for 8.0.0-beta.1 that is coming soon.
I close this issue because already done and It will be available in a beta release in some days.


fix: attempt to fix the flaky SQL Lab test

https://docs.cypress.io/api/commands/clear.html#Syntax
doubling our chances to selectall and clear the text box, hoping this fixes the flaky test here https://travis-ci.org/apache/incubator-superset/jobs/582812283
CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[x] Build / Development Environment
[ ] Documentation

Codecov Report

Merging #8212 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8212      +/-   ##
==========================================
- Coverage   66.17%   66.14%   -0.03%
==========================================
  Files         479      480       +1
  Lines       22898    22982      +84
  Branches     2524     2549      +25
==========================================
+ Hits        15152    15202      +50
- Misses       7612     7645      +33
- Partials      134      135       +1

Impacted Files
Coverage Δ

...sets/src/dashboard/containers/FilterIndicators.jsx
81.81% <0%> (-18.19%)
:arrow_down:

...ts/src/dashboard/containers/DashboardComponent.jsx
92% <0%> (-8%)
:arrow_down:

.../explore/components/controls/DateFilterControl.jsx
37.9% <0%> (-2.97%)
:arrow_down:

.../src/dashboard/components/gridComponents/Chart.jsx
67.44% <0%> (-2.56%)
:arrow_down:

...dashboard/components/FilterIndicatorsContainer.jsx
77.58% <0%> (-0.99%)
:arrow_down:

.../assets/src/visualizations/FilterBox/FilterBox.jsx
5.93% <0%> (-0.68%)
:arrow_down:

...set/assets/src/dashboard/actions/dashboardState.js
40.24% <0%> (-0.64%)
:arrow_down:

superset/assets/src/chart/Chart.jsx
10.63% <0%> (-0.48%)
:arrow_down:

superset/assets/src/chart/ChartRenderer.jsx
7.14% <0%> (-0.22%)
:arrow_down:

...ssets/src/dashboard/components/FilterIndicator.jsx
100% <0%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b881922...3550fe4. Read the comment docs.


UofT-DSI | Sampling - Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Designing a survey to study the relationship between age and music taste.
What did you learn from the changes you have made?
I learned how to structure a survey, select a sampling strategy, and formulate questions that target specific research objectives.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered using cluster sampling instead of stratified sampling to simplify the process.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The main challenge was ensuring the survey questions were clear and unbiased. I overcame this by reviewing and revising the questions multiple times.
How were these changes tested?
I conducted a pilot survey with my family to test the clarity and effectiveness of the questions.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[X] I can confirm that my changes are working as intended

A2: INCOMPLETE
Please specify the sampling strategy (SRS/STRATA/CLUSTER, etc..) and justify it.

@Melokazz
Specifed the sampling strategy, added text:
Stratified sampling strategy should be used. The intention is to ensure that all age groups are represented in the survey, which is crucial for studying how music taste varies with age and increase the accuracy of the results by reducing sampling error within each age stratum.
Using stratified sampling, we can draw more reliable and generalizable conclusions about the relationship between age and music taste.

A2: PASS
Great work!


[RFP]: Granting of research, reports and education for SORA News, August

Proposal Due Date
24/08/2023
Proposal Overview
SORA News proudly presents its August grant RFP. We have consistently worked towards providing unbiased and in-depth news content for the SORA community, creating an informative and engaging space for all stakeholders. To continue our endeavors and amplify our impact, we are actively seeking community support to fund SORA News.
Transparency Report:
We invite you to view our August Transparency Report to understand our past endeavors, expenditures, and the results we have achieved: [Transparency Report - August]
Overall we achieved during August 101.4k Twitter impressions and wrote 6 Articles. More can be found in the transparency report!
Proposal Goals
The primary goal of this proposal is to secure the necessary resources and support for SORA News to significantly enhance its contributions to the SORA ecosystem.
This proposal outlines strategic initiatives and resource allocations to achieve the following objectives:
Delivering High-Quality Content:
The proposal aims to ensure the consistent delivery of high-quality news articles, blog posts, and educational materials related to the SORA project. By providing well-researched and insightful content, SORA News will keep the community well-informed and educated about SORA's developments and advancements.
Fostering Community Engagement:
To enhance direct communication and foster community engagement, the proposal advocates for the implementation of email marketing campaigns for monthly news updates. These initiatives aim to establish personal connections with community members and encourage active participation.
Promoting Inclusivity:
The proposal recognizes the need to reach a broader audience within the SORA community. To achieve this, the grant will be utilized to create a Spanish version of the website, catering to Spanish-speaking individuals.
Bridging the Educational Gap:
SORA News is committed to addressing the educational gap within the SORA ecosystem. By allocating funds for additional educational materials, the proposal seeks to empower community members with a deeper understanding of the SORA project, blockchain technology, and decentralized finance concepts.
Ensuring Content Quality and Consistency:
To overcome the challenges of maintaining content quality and consistency, the proposal advocates for the hiring of a dedicated full-time team member. This strategic addition will ensure that SORA News can deliver timely and accurate updates, improving the overall impact of the platform.
Building Credibility and Trust:
By securing funding and consistently delivering reliable content, SORA News aims to build credibility and trust within the SORA ecosystem. This proposal seeks to reinforce SORA News as a reliable and respected source of information, addressing concerns related to misinformation and fostering greater confidence among community members.
Scope of Work
Our proposal outlines a comprehensive scope of work that encompasses several key areas:
Content Creation:
The grant will support the creation of high-quality news articles, blog posts, and educational materials, ensuring consistent and valuable information reaches the SORA community.
Website Maintenance and Hosting:
A portion of the grant will be allocated to maintaining our website, optimizing user experience, and ensuring seamless accessibility for community members.
Collaborating with a Polkadot Influencer
To increase the communication outreach of the product launch of Synthetic assets we have an agreement with a top Polkadot influencer who will promote SORA synthetic assets.
Spanish Website Version:
To promote inclusivity, the grant will support the establishment of a Spanish version of our website, catering to Spanish-speaking SROA members.
Email Marketing and Community Engagement:
Funds will be used to implement an email subscription feature and consistent email marketing to foster direct communication with the SORA community.
Current Roadblocks and Barriers to Success
This is written in the last RFP: [here]
Evaluation Metrics and Criteria
This is written in the last RFP: [here]
Submission Requirements
This is written in the last RFP: [here]
Submission Method
Other
Project Due Date
30/09/2023
Budget Amount
As agreed in the last RFP discussion, we are seeking a budget of $6k in TBCD.

Paid in full (more information here)


WIP help-docs: Add information about email invite language.

Adds minimal descriptions for email and general invitation links, and documents that email invitations are translated into the organization's notifications language. See this CZO conversation for more context.
Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Screenshot of updated Send e-mail invitations intro:

Replaced by #22108.


ENYO-1360-updated logic for offset calculation for scrollTo method in sc...

...roll Math
DCO-1.1-Signed-Off-By: Rajyavardhan P<EMAIL_ADDRESS>

Closing PR per Rajyavardhan; no longer needed.


[wikijs] Add fsGroup and sort persistent volumes. Add DB_HOST.

Description of the change
This change adds a clearer persistentVolume config, fixes the fsGroup setting to make sure persistent volumes will be writeable, and makes it clear how to configure an external database.
Benefits
Better, more consistent deploy process.
Possible drawbacks
Possibly redundant disk layout if lsio is symlinking behind our backs
Applicable issues

fixes #

Additional information
Not tested but based on the config that I used to get it to work.
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

I'm curious, if someone updates the user and group id in the environment variables won't they need to update fsGroup too? I'm not sure the best way to solve this other than putting in a note in the custom config readme and leaving podSecurityContext out of the values yaml.

I'm also curious about the purpose of app-wiki-data, isn't this the same as data that we use in most of our other charts?

So the issue here is that the /data folder which is used for a cache among other things is only writable by root in the generic install:
root@wikijs-generic-69c84f776b-68ljj:/# stat /data
  File: /data
  Size: 4096            Blocks: 8          IO Block: 4096   directory
Device: 5000dch/5243100d        Inode: 259065721   Links: 2
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)

Here's the default user:
root@wikijs-generic-69c84f776b-68ljj:/# cat /etc/passwd | grep 911
abc:x:911:911::/config:/bin/false

root@wikijs-generic-69c84f776b-68ljj:/# ps aux | grep node
abc        288  1.1  0.1<PHONE_NUMBER>72 ?       Ssl  17:54   0:03 /usr/bin/node server
root       363  0.0  0.0   1580   736 pts/1    S+   17:59   0:00 grep node

However, that user can't write to the /data/cache/ path required:
root@wikijs-generic-69c84f776b-68ljj:/# su -s /bin/sh - abc
wikijs-generic-69c84f776b-68ljj:~$ whoami
abc
wikijs-generic-69c84f776b-68ljj:~$ mkdir /data/cache
mkdir: cannot create directory ‘/data/cache’: Permission denied
wikijs-generic-69c84f776b-68ljj:~$

When I provision PV's and set the fsGroup to 911, folders are created as expected:
root@wikijs-7fb4f666c-njhjl:/# ls -la /data
total 19
drwxrwsr-x 5 root abc   1024 Aug 22 20:31 .
drwxr-xr-x 1 root root  4096 Aug 22 20:25 ..
drwxr-sr-x 2 abc  abc   1024 Aug 23 10:47 cache
drwxrws--- 2 root abc  12288 Aug 22 20:23 lost+found
drwxr-sr-x 2 abc  abc   1024 Aug 22 20:31 uploads
root@wikijs-7fb4f666c-njhjl:/#

Meanwhile, /app/wiki/data/ is the default home of sqlite, meaning yes there is different data in the two paths:
root@wikijs-7fb4f666c-njhjl:/# ls -la /app/wiki/data/
total 277
drwxrwsr-x 3 abc  abc    1024 Aug 23 20:31 .
drwxr-xr-x 1 root root   4096 Aug 22 20:25 ..
-rw-r--r-- 1 abc  abc  262144 Aug 23 20:31 db.sqlite
drwxrws--- 2 abc  abc   12288 Aug 22 20:23 lost+found
root@wikijs-7fb4f666c-njhjl:/#

Unfortunately, by themselves neither assigning a persistent drive nor setting the fsGroup resolve this issue.
2021-08-24T18:53:50.056Z [MASTER] info: Connecting to database...
2021-08-24T18:53:50.058Z [MASTER] error: Database Connection Error: SQLITE_CANTOPEN undefined:undefined
2021-08-24T18:53:50.058Z [MASTER] warn: Will retry in 3 seconds... [Attempt 8 of 10]


Vec4 and Vec3 classes

All the changes requested for here in #11 have been incorporated along with creating a  shared folder with config.hpp file and updated CMakeLists.
Addresses #13

Could you please take care of the merge conflicts?


Fixed stopping of motors for penalized robots

Fixes #163.

I get following error when compiling the controller on this branch:

# make player
# compiling messages.proto
# updating messages.pb.d
# updating player.d
# compiling  messages.pb.cpp
# compiling  robot_client.cpp
# compiling  player.cpp
player.cpp: In member function ‘void PlayerServer::addMotorIfNeeded(webots::Motor*)’:
player.cpp:375:54: error: no matching function for call to ‘find(std::vector<webots::Motor*>::iterator, std::vector<webots::Motor*>::iterator, webots::Motor*&)’
 d(motors.begin(), motors.end(), motor) == motors.end())  // motor not in motors
                                      ^
In file included from /usr/include/c++/7/bits/locale_facets.h:48:0,
                 from /usr/include/c++/7/bits/basic_ios.h:37,
                 from /usr/include/c++/7/ios:44,
                 from /usr/include/c++/7/ostream:38,
                 from /usr/include/c++/7/iterator:64,
                 from /usr/include/google/protobuf/repeated_field.h:55,
                 from messages.pb.h:27,
                 from player.cpp:42:
/usr/include/c++/7/bits/streambuf_iterator.h:369:5: note: candidate: template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT> >::__type std::find(std::istreambuf_iterator<_CharT>, std::istreambuf_iterator<_CharT>, const _CharT2&)
     find(istreambuf_iterator<_CharT> __first,
     ^~~~
/usr/include/c++/7/bits/streambuf_iterator.h:369:5: note:   template argument deduction/substitution failed:
player.cpp:375:54: note:   ‘__gnu_cxx::__normal_iterator<webots::Motor**, std::vector<webots::Motor*> >’ is not derived from ‘std::istreambuf_iterator<_CharT>’
 d(motors.begin(), motors.end(), motor) == motors.end())  // motor not in motors
                                      ^
/media/marc/New/webots/resources/Makefile.include:544: recipe for target 'build/release/player.o' failed
make[1]: *** [build/release/player.o] Error 1
Makefile:20: recipe for target 'player.Makefile' failed

I did do a full clean build of webots. Did you maybe forget to push some changes?

I can compile it successfully. I will try on another system...

I can compile it successfully. I will try on another system...

okay. Mine is Ubuntu 18.04. We will also try it on another system.

I tested and it works on both Ubuntu 20.04 and Windows.

On Ubuntu 18.04 I get the same error.

adding #include <algorithm> fixes the compilation errors

@SammyRamone  and I tested this and the robot gets sent to its initial position continuously but on the bright side it does not move anymore.

We have tested it again after the merge and it seems to work correctly and the robot can not move its actuators anymore.

We have tested it again after the merge and it seems to work correctly and the robot can not move its actuators anymore.

Nice. @medrimonia: shall we merge this PR then?


Added iced topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Why the topic should be curated: Iced is one of the most popular GUI libraries for Rust and more and more repositories are starting to be tagged with this topic.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I love it.


Geometry test failing with Intel C++ compiler

Test 2 fails on v1.0, v1.1 and master.
v1.1 shows this error message. Is this a floating point number issue?
2/18 Testing: ArborX_Geometry_Test
2/18 Test: ArborX_Geometry_Test
Command: "/home/wyan/Workspace/Environment/ArborX/build/test/ArborX_Geometry.exe"
Directory: /home/wyan/Workspace/Environment/ArborX/build/test
"ArborX_Geometry_Test" start time: Oct 08 12:35 EDT
Output:
----------------------------------------------------------
Running 29 test cases...
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(35): [1;31;49merror: in "intersects_box": check !intersects(Ray{{-1, .5, .5}, {0, 1, 1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(38): [1;31;49merror: in "intersects_box": check !intersects(Ray{{2, .5, .5}, {0, 1, 1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(40): [1;31;49merror: in "intersects_box": check !intersects(Ray{{-1, 1.5, .5}, {1, 0, 0}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(44): [1;31;49merror: in "intersects_box": check !intersects(Ray{{-1, 1.5, 1.5}, {1, 0, -1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(46): [1;31;49merror: in "intersects_box": check !intersects(Ray{{2, -.5, .5}, {-1, 0, 0}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(50): [1;31;49merror: in "intersects_box": check !intersects(Ray{{2, -.5, 1.5}, {-1, 0, -1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(55): [1;31;49merror: in "intersects_box": check !intersects(Ray{{-1, 0, .5}, {0, 1, 1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(58): [1;31;49merror: in "intersects_box": check !intersects(Ray{{2, 0, .5}, {0, 1, 1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(69): [1;31;49merror: in "intersects_box": check !intersects(Ray{{-1, 1, 1}, {0, 1, 1}}, unit_box) has failed [0;39;49m
/home/wyan/Workspace/Environment/ArborX/test/tstRay.cpp(71): [1;31;49merror: in "intersects_box": check !intersects(Ray{{2, 1, 1}, {0, 1, 1}}, unit_box) has failed [0;39;49m

[1;31;49m*** 10 failures are detected in the test module "Geometry"
[0;39;49m
<end of output>
Test time =   0.04 sec
----------------------------------------------------------
Test Failed.
"ArborX_Geometry_Test" end time: Oct 08 12:35 EDT
"ArborX_Geometry_Test" time elapsed: 00:00:00

I'm using Kokkos from Trilinos-13.0.1, openmpi, intel compiler 2020, gcc9.3, and boost-1.77.

is there a particular reason why arborx internally works with float (maybe for GPU harddware?)? does it make sense to add a template parameter FP to arborx so user can specify float/double?

We saw performance benefits up to 50%, see https://github.com/arborx/ArborX/pull/235. What are you using ArborX for? Do you need double precision accuracy in the search itself (rather than callbacks or the like)?

is there a particular reason why arborx internally works with float (maybe for GPU harddware?)? does it make sense to add a template parameter FP to arborx so user can specify float/double?

We saw performance benefits up to 50%, see #235. What are you using ArborX for? Do you need double precision accuracy in the search itself (rather than callbacks or the like)?

Thanks for letting me know the benchmark.
We use arborx for collision detection. Using float works well most of the time but sometimes generates unexpected problems like this during testing. If the performance benefits is significant then I'll stick to float.


Secure API Gateways with authentication

Currently all ATI Gateway methods do not require authentication and can therefore be accessed publicly. We need to ensure the methods cannot be invoked in an un-authorized way.

A simple authorization can simply verify the JWT token coming from Teams. For that a lambda needs to import pyJWT, which can only be accomplished via lambda layer. To build a custom lambda layer in CFN, one requires a zip file with the requirements.
An idea is to create an S3 bucket, run a CodeBuild compiling the required dependencies and copy the output to the s3 bucket requires that CFN waits with the execution until the CodeBuild is complete, which can be accomplished as described here (or possibly using step functions) and then create the layer with the reference to the bucket. This all can be accomplished in CFN and would provide an neat little solution built into CloudFormation without the need for external dependencies.


Enable back test runs for Fedora RPM

Postgres make check tests were temporary disabled in Fedora RPMs. These tests pass fine on RHEL but fail on Fedora. These likely happens because of compiler flags on newer version of GCC, it needs to be investigated and fixed. Currently Fedora RPMs cannot be used for anything serious.

Test runs pass fine on the latest versions of Fedora on x86_64, the failure is still observed on aarch64:
make -j1  checkprep >>'/builddir/build/BUILD/postgresql-15-15.4+wiltondb3.3-3'/tmp_install/log/install.log 2>&1
echo "+++ regress check in src/test/regress +++" && PATH="/builddir/build/BUILD/postgresql-15-15.4+wiltondb3.3-3/tmp_install/usr/bin:/builddir/build/BUILD/postgresql-15-15.4+wiltondb3.3-3/src/test/regress:$PATH" LD_LIBRARY_PATH="/builddir/build/BUILD/postgresql-15-15.4+wiltondb3.3-3/tmp_install/usr/lib64"  ../../../src/test/regress/pg_regress --temp-instance=./tmp_check --inputdir=. --bindir=     --dlpath=. --max-concurrent-tests=20  --schedule=./parallel_schedule --max-connections=5
+++ regress check in src/test/regress +++
============== creating temporary instance            ==============
============== initializing database system           ==============
============== starting postmaster                    ==============
running on port 51700 with PID 16500
============== creating database "regression"         ==============
CREATE DATABASE
ALTER DATABASE
ALTER DATABASE
ALTER DATABASE
ALTER DATABASE
ALTER DATABASE
ALTER DATABASE
============== running regression test queries        ==============
test test_setup                   ... ok          141 ms
test tablespace                   ... ok          169 ms
parallel group (20 tests, in groups of 5):  char text varchar name boolean int4 int2 float4 int8 oid txid float8 uuid bit numeric regproc pg_lsn money enum rangetypes
     boolean                      ... ok           32 ms
     char                         ... ok           19 ms
     name                         ... ok           25 ms
     varchar                      ... ok           20 ms
     text                         ... ok           20 ms
     int2                         ... ok           24 ms
     int4                         ... ok           19 ms
     int8                         ... ok           31 ms
     oid                          ... ok           32 ms
     float4                       ... ok           29 ms
     float8                       ... ok           32 ms
     bit                          ... ok           46 ms
     numeric                      ... ok          171 ms
     txid                         ... ok           27 ms
     uuid                         ... ok           35 ms
     enum                         ... ok           45 ms
     money                        ... ok           26 ms
     rangetypes                   ... ok          191 ms
     pg_lsn                       ... ok           24 ms
     regproc                      ... ok           19 ms
parallel group (19 tests, in groups of 5):  line numerology lseg point strings path circle date polygon box time timetz interval timestamp timestamptz macaddr macaddr8 inet multirangetypes
     strings                      ... ok           58 ms
     numerology                   ... ok           21 ms
     point                        ... ok           27 ms
     lseg                         ... ok           24 ms
     line                         ... ok           17 ms
     box                          ... ok          111 ms
     path                         ... ok           15 ms
     polygon                      ... ok          105 ms
     circle                       ... ok           25 ms
     date                         ... ok           33 ms
     time                         ... ok           21 ms
     timetz                       ... ok           21 ms
     timestamp                    ... ok          332 ms
     timestamptz                  ... ok          345 ms
     interval                     ... ok           40 ms
     inet                         ... ok           32 ms
     macaddr                      ... ok           19 ms
     macaddr8                     ... ok           25 ms
     multirangetypes              ... ok          110 ms
parallel group (12 tests, in groups of 5):  tstypes horology type_sanity geometry regex unicode comments misc_sanity expressions opr_sanity xid mvcc
     geometry                     ... ok           74 ms
     horology                     ... ok           48 ms
     tstypes                      ... ok           33 ms
     regex                        ... ok          222 ms
     type_sanity                  ... ok           56 ms
     opr_sanity                   ... ok          160 ms
     misc_sanity                  ... ok           19 ms
     comments                     ... ok           14 ms
     expressions                  ... ok           38 ms
     unicode                      ... ok           13 ms
     xid                          ... ok           23 ms
     mvcc                         ... ok           36 ms
parallel group (5 tests):  copyselect copydml copy insert_conflict insert
     copy                         ... ok           47 ms
     copyselect                   ... ok           30 ms
     copydml                      ... ok           37 ms
     insert                       ... ok          155 ms
     insert_conflict              ... ok           86 ms
parallel group (7 tests, in groups of 5):  create_function_c create_operator create_misc create_procedure create_table create_type create_schema
     create_function_c            ... ok           18 ms
     create_misc                  ... ok           29 ms
     create_operator              ... ok           23 ms
     create_procedure             ... ok           37 ms
     create_table                 ... ok          183 ms
     create_type                  ... ok           25 ms
     create_schema                ... ok           27 ms
parallel group (5 tests):  index_including index_including_gist create_view create_index_spgist create_index
     create_index                 ... ok          370 ms
     create_index_spgist          ... ok          268 ms
     create_view                  ... ok          202 ms
     index_including              ... ok          130 ms
     index_including_gist         ... ok          144 ms
parallel group (16 tests, in groups of 5):  create_cast create_aggregate create_function_sql constraints triggers select drop_if_exists typed_table vacuum inherit errors hash_func roleattributes create_am updatable_views infinite_recurse
     create_aggregate             ... ok           33 ms
     create_function_sql          ... ok           55 ms
     create_cast                  ... ok           18 ms
     constraints                  ... ok           74 ms
     triggers                     ... ok          376 ms
     select                       ... ok           40 ms
     inherit                      ... ok          237 ms
     typed_table                  ... ok           50 ms
     vacuum                       ... FAILED      151 ms
     drop_if_exists               ... ok           47 ms
     updatable_views              ... ok          234 ms
     roleattributes               ... ok           30 ms
     create_am                    ... ok           50 ms
     hash_func                    ... ok           27 ms
     errors                       ... ok           23 ms
     infinite_recurse             ... ok          105 ms
test sanity_check                 ... ok           60 ms
parallel group (20 tests, in groups of 5):  select_distinct_on select_implicit select_having select_into select_distinct case union subselect join aggregates random transactions portals arrays btree_index namespace delete prepared_xacts update hash_index
     select_into                  ... ok           34 ms
     select_distinct              ... ok           60 ms
     select_distinct_on           ... ok           27 ms
     select_implicit              ... ok           29 ms
     select_having                ... ok           32 ms
     subselect                    ... ok           91 ms
     union                        ... ok           90 ms
     case                         ... ok           42 ms
     join                         ... ok          253 ms
     aggregates                   ... ok          285 ms
     transactions                 ... ok           58 ms
     random                       ... ok           19 ms
     portals                      ... ok           69 ms
     arrays                       ... ok          115 ms
     btree_index                  ... ok          673 ms
     hash_index                   ... ok          187 ms
     update                       ... ok          135 ms
     delete                       ... ok           27 ms
     namespace                    ... ok           24 ms
     prepared_xacts               ... ok           48 ms
parallel group (20 tests, in groups of 5):  brin spgist gist gin privileges init_privs security_label lock collate matview tablesample object_address replica_identity groupingsets rowsecurity drop_operator password identity generated join_hash
     brin                         ... ok          197 ms
     gin                          ... ok          364 ms
     gist                         ... ok          352 ms
     spgist                       ... ok          214 ms
     privileges                   ... ok          563 ms
     init_privs                   ... ok           14 ms
     security_label               ... ok           27 ms
     collate                      ... ok           56 ms
     matview                      ... ok          119 ms
     lock                         ... ok           35 ms
     replica_identity             ... ok           74 ms
     rowsecurity                  ... ok          203 ms
     object_address               ... ok           55 ms
     tablesample                  ... ok           45 ms
     groupingsets                 ... ok          123 ms
     drop_operator                ... ok           34 ms
     password                     ... ok           76 ms
     identity                     ... ok           93 ms
     generated                    ... ok          169 ms
     join_hash                    ... ok          891 ms
parallel group (2 tests):  brin_bloom brin_multi
     brin_bloom                   ... ok           56 ms
     brin_multi                   ... ok          109 ms
parallel group (16 tests, in groups of 5):  async alter_operator alter_generic misc create_table_like dbsize tsrf sysviews misc_functions merge collate.icu.utf8 tidrangescan tid tidscan incremental_sort create_role
     create_table_like            ... ok          126 ms
     alter_generic                ... ok           60 ms
     alter_operator               ... ok           23 ms
     misc                         ... ok           64 ms
     async                        ... ok           17 ms
     dbsize                       ... ok           17 ms
     merge                        ... ok          109 ms
     misc_functions               ... ok           65 ms
     sysviews                     ... ok           57 ms
     tsrf                         ... ok           28 ms
     tid                          ... ok           27 ms
     tidscan                      ... ok           35 ms
     tidrangescan                 ... ok           27 ms
     collate.icu.utf8             ... ok           18 ms
     incremental_sort             ... ok           72 ms
     create_role                  ... ok           26 ms
parallel group (6 tests, in groups of 5):  amutils psql_crosstab rules psql stats_ext collate.linux.utf8
     rules                        ... ok          168 ms
     psql                         ... ok          195 ms
     psql_crosstab                ... ok           31 ms
     amutils                      ... ok           28 ms
     stats_ext                    ... ok          686 ms
     collate.linux.utf8           ... ok           13 ms
test select_parallel              ... ok          816 ms
test write_parallel               ... ok           98 ms
test vacuum_parallel              ... ok           77 ms
parallel group (2 tests):  subscription publication
     publication                  ... ok          182 ms
     subscription                 ... ok           48 ms
parallel group (17 tests, in groups of 5):  portals_p2 dependency select_views cluster foreign_key combocid guc tsdicts tsearch bitmapops xmlmap functional_deps advisory_lock window foreign_data equivclass indirect_toast
     select_views                 ... ok           66 ms
     portals_p2                   ... ok           20 ms
     foreign_key                  ... ok          424 ms
     cluster                      ... ok          140 ms
     dependency                   ... ok           43 ms
     guc                          ... ok           39 ms
     bitmapops                    ... ok          147 ms
     combocid                     ... ok           28 ms
     tsearch                      ... ok          142 ms
     tsdicts                      ... ok           45 ms
     foreign_data                 ... ok          220 ms
     window                       ... ok          108 ms
     xmlmap                       ... ok           34 ms
     functional_deps              ... ok           38 ms
     advisory_lock                ... ok           40 ms
     indirect_toast               ... ok          155 ms
     equivclass                   ... ok           29 ms
parallel group (6 tests, in groups of 5):  jsonpath_encoding json_encoding jsonpath json jsonb jsonb_jsonpath
     json                         ... ok           64 ms
     jsonb                        ... ok          124 ms
     json_encoding                ... ok           16 ms
     jsonpath                     ... ok           30 ms
     jsonpath_encoding            ... ok           15 ms
     jsonb_jsonpath               ... ok           35 ms
parallel group (18 tests, in groups of 5):  limit plancache copy2 temp plpgsql prepare conversion truncate rangefuncs domain returning sequence rowtypes polymorphism alter_table with largeobject xml
     plancache                    ... ok           51 ms
     limit                        ... ok           43 ms
     plpgsql                      ... ok          239 ms
     copy2                        ... ok           71 ms
     temp                         ... ok           80 ms
     domain                       ... ok          108 ms
     rangefuncs                   ... ok          104 ms
     prepare                      ... ok           38 ms
     conversion                   ... ok           53 ms
     truncate                     ... ok           97 ms
     alter_table                  ... ok          589 ms
     sequence                     ... ok           74 ms
     polymorphism                 ... ok           89 ms
     rowtypes                     ... ok           82 ms
     returning                    ... ok           36 ms
     largeobject                  ... ok           96 ms
     with                         ... ok           91 ms
     xml                          ... ok          307 ms
parallel group (12 tests, in groups of 5):  hash_part reloptions indexing partition_join partition_prune partition_info explain compression partition_aggregate tuplesort memoize stats
     partition_join               ... ok          336 ms
     partition_prune              ... ok          535 ms
     reloptions                   ... ok           34 ms
     hash_part                    ... ok           25 ms
     indexing                     ... ok          320 ms
     partition_aggregate          ... ok          361 ms
     partition_info               ... ok           47 ms
     tuplesort                    ... ok          443 ms
     explain                      ... ok           54 ms
     compression                  ... ok          106 ms
     memoize                      ... ok           60 ms
     stats                        ... ok          129 ms
parallel group (2 tests):  event_trigger oidjoins
     event_trigger                ... ok           68 ms
     oidjoins                     ... ok          149 ms
test fast_default                 ... ok           75 ms
test serializable                 ... ok           18 ms
============== shutting down postmaster               ==============

========================
 1 of 213 tests failed.
========================


fix: Display error message for invalid status in filter command

Closes #124
Added validation to FilterStatusCommandParser to handle cases where an invalid status is entered. Now, an error message is shown when the user inputs an unrecognized status (e.g., 'applying') instead of displaying an empty list. This improves user feedback and usability.

Thanks for fixing this


Add PHPDoc (docblocks) with param and return types to all PHP methods and classes

This is related to #295. I've added the docblocks to all methods and classes. What I am missing in most of the places are method descriptions. So what I did is that I only added annotations @param and @return. Adding those method descriptions is a huge procedure and I need a lot of time to do that since I would basically have to briefly explain the whole systems' functionality. I am not giving up on that, I am just postponing that.
But first I would really love that we merge this one. I would also like to hear from you guys about these changes.

I think it's so much better to use type declarations instead of PHP doc blocks. It improves safety and decreases verbosity.

@yusufkandemir I agree, but for now, that could be really risky for the implementation. I wanted to prepare everything for doing strict type hinting because a lot of untested stuff could break to invalid type hinting. This way, we will have everything implicitly described so we can do the typehinting in a more "secure" way.

@stevanpavlovic I agree with that. Refactoring is best when done progressively.

Merged in 4f80c83d and reviewed in 6f4e9c92. Thank you so much @stevanpavlovic!


Upgrade jackson version to 2.9.7

Motivation
CVE-2018-7489 FasterXML jackson-databind before <IP_ADDRESS> and 2.9.x before 2.9.5 allows unauthenticated remote code execution because of an incomplete fix for the CVE-2017-7525 deserialization flaw.
So, upgrade jackson version to 2.9.7

@rdhabalia Can you also take a look at upgrading the other libraries reported in #2882

sure.. will do..it also seems I need to update LICENSE/NOTICE, will fix it as well.

rerun tests

rerun tests please

test this please


Update getFontScale to work in iOS App Extensions

Summary

Version
master

Affected OS
iOS

OS Version
any

Current behavior

Following up #408, we’ve patched the library to compile with iOS App Extensions, however getFontScale always returns 1.0 since the shared application cannot be accessed. A potential (iOS 10+) workaround is described in https://github.com/react-native-community/react-native-device-info/pull/408#issuecomment-462807763.
Expected behavior

getFontScale should probably return the font scale on iOS 10+ and fall back to 1.0 or use a different workaround with older versions.

Following up on this: the proposal in the linked comment was:
RCTSharedApplication() returns nil when ran in an app extension.
I suggest using the following:

NSString *contentSize = [[UIScreen mainScreen] traitCollection].preferredContentSizeCategory;

However it would imply dropping iOS 9 support. Or maybe we could just default the contentSize to 1 on that version?

I will not drop iOS 9 support until the main react-native platform does, and I have not heard of any dates where this will happen.
However, if this is a need for someone and they are motivated I will happily accept a PR (if it is possible) that ifdef's around the ios9 vs ios10 compatibility and includes the current implementation for ios9 only, and moves to the above proposal for ios10+
I personally do not need this so I will not implement it myself but I'll help land it if someone else is
Cheersy

@mikehardy,
Since the release of RN 0.63, support for iOS 13 has been dropped.
Currently, this project points to RN 0.62.2, so would this project have to upgrade to 0.63 to definitively say, "hey, we're in that iOS 10+ gang" ?  I'm not sure if that matters though. I think the link above, at the time of its writing, also states that iOS 9's market share is ~ 1%.
With that being said, I can work on this if need be.

I am okay with dropping ios9 now as a breaking change and just saying if you need to use ios9 stick with an older version of the library, with a possibly less drastic step being to say this API specifically only works on ios10+ and returns the default (or a fallback) on ios9

@mikehardy,
Would this technically be a breaking change since the lib won't be supporting iOS 9?
...Just trying to figure-out my commit messages.

if we drop ios9 it's breaking yes, I'm willing to do it - react-native dropped 9 in 0.63 https://github.com/facebook/react-native/commit/674b591809cd1275b5f1c4d203c2f0ec52303396 which has been out quite a while and I already have a couple other major packages which are 10+


Migrate Girder plugin log message handling to jobs notifications

@zachmullen what's your current take on this one? Would it be difficult to do?

For posterity, here is the code in question: https://github.com/Kitware/romanesco/blob/master/server/init.py#L231-L275
We could definitely achieve the same end result using the stuff in core, as long as the jobs sent to romanesco are properly using the jobInfo field to update status via the girder REST api rather than the celery backend.

Right now I believe the Girder server needs to see the celery queue and the celery worker needs to see the queue but the worker does not need to see the Girder server directly, unless using the Girder I/O plugin. Do we want to add this dependence - I could foresee it could require more configuration setup for Romanesco workers. Seems better to just have them communicate through the queue.

It's actually something we pass at runtime, the jobInfo kwarg to romanesco.run. It points back to a URL that should be used to update job information. Romanesco handles this using the JobManager instance that every celery task gets: https://github.com/Kitware/romanesco/blob/master/romanesco/main.py#L21-L23
When invoking the task, it looks something like this: https://github.com/zachmullen/climos_test/blob/master/server/init.py#L115-L120
It's not girder-aware on the romanesco side, but it does require a compliant HTTP interface that girder currently implements.

Ah ok, sounds more feasible then. If we'd consider this a breaking API change I'd vote for making this part of the 1.0 milestone.
This would also require a corresponding update to tangelohub.

One other thought - would this change make it easier or harder to implement a romanesco client executable that connects to celery and displays output to the console? For example I could envision supporting the following:
$ romanesco-worker
...
$ cat analysis.json
{
    "inputs": [{"name": "a", ... }, {"name": "b", ...}],
    "outputs": [{"name": "c", ...}],
    "script": "..."
}
$ romanesco-client run analysis.json -i a:first-input.csv -i b:second-input.csv -o c:output-file.csv
worker output text line 1
worker output text line 2
worker output text line 3
...
$ cat output-file.csv
The generated output data

I don't think it would affect that use case at all hopefully.

Ok then I think it would be good to target this for 1.0, adding the milestone now.


error while Valorant is running in the background

Traceback (most recent call last):
File "pypresence\baseclient.py", line 102, in read_output
File "asyncio\streams.py", line 621, in read
File "asyncio\proactor_events.py", line 370, in _loop_writing
File "asyncio\windows_events.py", line 474, in send
BrokenPipeError: [WinError 232] Die Pipe wird gerade geschlossen
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "src\presence\presence.py", line 35, in main_loop
File "src\presence\presence.py", line 65, in update_presence
File "src\presence\presences\menu.py", line 10, in presence
File "src\presence\presences\menu_presences\default.py", line 9, in presence
File "src\presence\presences\menu_presences\away.py", line 10, in presence
File "pypresence\presence.py", line 34, in update
File "asyncio\base_events.py", line 579, in run_until_complete
File "pypresence\baseclient.py", line 106, in read_output
pypresence.exceptions.InvalidID: Client ID is Invalid

ClientID of presence is invalid, try deleting config from %appdata%/valorant-rpc and try launching valorant-rpc again

looks like a pypresence error - make sure discord is open

Do you still get this error with newer RPC versions?


Save code locally in browser session

It would be nice if when you refreshed the page, your code didn't disappear, at least within a single browser session. We can do that by just saving the code in session-local cookies when you click Run, pretty easy.

Optionally, Ctrl + S could either save locally in the browser, or save as a file.

Does this still need to be implemented? I think I could do it and I would like to help.

Yep, still unimplemented. Happy to have some help!

Thanks! I will start working on it.

I can take a look if this is still not fixed. As soon as I get docker working on my PC :D

Pull requests always appreciated, but do keep in mind https://github.com/radian-software/riju/issues/168, I wouldn't want to waste your time!


set the maximum log msg size depending on the msg length

Before the change, the default size 1KB is used as the maximum length
of each single msg. So when the msg length exceeds that length, the msg
will be truncated.
With this fix, the msg size is dynamically set according to the msg length.
Signed-off-by: dyyang<EMAIL_ADDRESS>

lgtm


Aux Channel 2&3

Hi @wernerdaehn
is it possible to add additional aux channels to the controller? I use the existing AUX channel for focus control, and I would use additional channels for aperture and zoom also.
Great job!!!

Difficult. I am running out of Pins and Timers to use.
Can't you use the SBus output?
https://github.com/wernerdaehn/CC3D-CableCam-Controller/blob/master/docs/SBus Output for Gimbal.md

SBus is occupied with gimbal and camera LANC control function already. I have only one left, but I want all three function(zoom, iris and focus) in one place.


[WIP] Implement support bundle command

Add system.antrea.tanzu.vmware.com/v1beta1/bundles API
on both agent APIServer and controller APIServer for
generating support bundles.
Add system.antrea.tanzu.vmware.com/v1beta1/bundles/download
for downloading bundles
Implement antctl bundle command for collecting bundle via CLI

Separated into several smaller, closing it.


【Bug Report】Page resources repetitively requested

html2canvas version tested with: 1.0.0-rc.5
I found that calling html2canvas function would cause html page resource get requested again. The situation is I'm using html2canvas to convert html page that could be very long, so I have to consider about the canvas size limit. The solution for me is to break the page into multiple parts and convert each part into canvas:
function generateCanvas(element) {
  return new Promise((resolve, reject) => {
    html2canvas(element, {scale: 2, useCORS: true}).then(function(canvas) {
      resolve(canvas)
    })
  })
}

let generateCanvasPromiseList = []
// elementList is an array that contains the whole page
elementList.forEach(element => {
  generateCanvasPromiseList.push(this.generateCanvas(element))
})

Promise.all(generateCanvasPromiseList).then(canvasList => {
  // handle generated canvas
})

The result is html2canvas repetitively send page resource request:

Each request of my html page is requested as many times as html2canvas get called. After checking chrome initiator, it guides me to the DocumentCloner.toIFrame function of this line:
documentClone.replaceChild(documentClone.adoptNode(this.documentElement), documentClone.documentElement);

I think this line of code end up with attaching the cloned html page into iframe, thus sending resource request again. I'm not sure how to fix this yet, but i think send every request again is inappropriate.

https://github.com/niklasvh/html2canvas/issues/1284#issuecomment-652844658 I think this hack from @K-D-K is the best workaround right now, but
is it possible to specify elements that are needed to clone, rather than find out elments to ignore?  This might make things much easier.

@chenyiqiao actually we specifying the elements which needed to clone.
we ignoring elements which don't have white_list_class.


Query parameters

Hi,
I have a question, how can I pass query parameters to the endpoint? For example as mentioned on this documentation page:
http://developer.mailchimp.com/documentation/mailchimp/reference/lists/abuse-reports/
Kind regards,
Pim

It should be the same as everything else:
$MailChimp->get("/lists/$list_id/abuse-reports", [
    'count' => 1
]);

and so on.


Resolution quality

Hi @alexrainman
I'm unable to get the right picture quality from the first shot
Some of them (1st and 3rd) self improve on the second passage
The one in the middle still always the same
Please advise
Regards

@hadihashem hi
https://github.com/AndreiMisiukevich/CardView
try this

looks nice
will try it
thanks


Easy multiplatform support

Hey,
I have noticed that we can easily address this issue. Currently we only use two x86 SSE2 instructions - Sse2.CompareEqual and Sse2.MoveMask. Those two can be easily replaced with platform independent equivalents - the static method Vector128.Equal and the extension method Vector128.ExtractMostSignificantBits.
At run-time the JIT will replace them with SSE2 or their analogues on ARM, depending on which architecture the app is running on.
So basically code like this
https://github.com/Wsm2110/Faster.Map/blob/7e1fb1ee10443cb520ce3e2a1108be0990de304a/src/DenseMapSIMD.cs#L231-L235
can be changed to
int result = (int)Vector128.Equals(left, right).ExtractMostSignificantBits();

I've tried and replaced the SSE2 calls with Vector128.Equal  and  Vector128.ExtractMostSignificantBits and it started working on my brother's Macbook Air with M1 processor without x86 emulation.
To make it work, we also need to change this check
https://github.com/Wsm2110/Faster.Map/blob/7e1fb1ee10443cb520ce3e2a1108be0990de304a/src/DenseMapSIMD.cs#L153-L156
to
 if (!Vector128.IsHardwareAccelerated)
 {
     throw new NotSupportedException("Simd is not supported");
 }

Isn't that cool or what?

/

"At run-time the JIT will replace them with SSE2 or their analogues on ARM, depending on which architecture the app is running on."
Would love to see where you read this :)
The thing is i don't have a macbook or any arm related hardware. So it's really hard to test.

Don't need to read it, I've tried it myself on sharplab.io. Click on the link below to see it yourself. On your left-hand side is the c# code. On your right-hand side is the JIT-ted code. You can see that the code generated by the JIT compiler is identical. By the way, there is a nice VS plugin called Disasmo. You can use it on your methods to see the generated ASM code if you don't want to use sharplab.io. The downside is it only works for console apps
https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AXEBDAzgWwB8ABAJgEYBYAKGIAYACY8gOgCUBXAOwwEt8YLAMIR8AB14AbGFADKMgG68wMXAG4a9Jq049+ggJI8ZEMfKhKV6zY2btufASyMYovLrmXXatnQ/3OPG4eXiwAGgAcSBrUmgDMTKQMQgwA3jQMmVlZYm4K2BgwDABqMGAY0OSkEQA8uMAAnoUAfAyysgCipB0AjhzYkgAUpeWV1XWNLQwKZeRoJWUVUFW19U0wrTNgpACUGdnZ6dQHJ5nEAOxtuDCkwqJi2LC9/UNbc9NluzGnmQC++5kASdcrx8oUFqNluM1lMAAqSAoAM2g+CMABMYGIYFwMTxngNhosxqtJhsPmB3iMlisJutNp89scfkcfgcLhDqdUWPjJLhBm95lsvkCDv8mQcRdkQWCiu4MG1OqQALIQGZKvAAa0JkJpMLJW0ZrJZrKy7Nk11uKrVmv5ZR23x+YuykpyeQKsp4DHhSJR6Mx2NxGCtMHVuC1VOJtKmBpdmWNJqYl0Gcp2W25CFc2HKKtwGFkvAA5lxeIjlNgeAAhXgYPn22MMX4MGi/IA

By the way, M1 results for the Get benchmark is about the same as yours - "7.5 ms" (on a Macbook Air, without a fan) which is pretty impressive

If you are really interested to see the code where the JIT emits the instructions you can take a look in these two files
for x32/x64
https://github.com/dotnet/runtime/blob/968b4f8e46f78c19315cd2bd4240f47a368be11c/src/coreclr/jit/hwintrinsicxarch.cpp
for arm64
https://github.com/dotnet/runtime/blob/968b4f8e46f78c19315cd2bd4240f47a368be11c/src/coreclr/jit/hwintrinsicarm64.cpp
Search for NI_Vector128_Equals and NI_Vector128_ExtractMostSignificantBits

These are the default implementations of the methods.
https://github.com/dotnet/runtime/blob/7a0b0e138750b896b4ea0a8ac8fca77e266dcd56/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs#L1423-L1438
https://github.com/dotnet/runtime/blob/7a0b0e138750b896b4ea0a8ac8fca77e266dcd56/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs#L1466-L1480
However pay attention on the [Intrinsic] attribute they have. This hints the JIT compiler that if the hardware supports SIMD it should replace the implementation with the corresponding SIMD instructions - Sse2.CompareEqual (vpcmpeqb) and Sse2.MoveMask (vpmovmskb) on x86

FYI, just made my brother run the DenseMapSIMD tests, and all 26 of them has passed successfully on his Macbook Air M1

Ill take a look mate :)

FYI, just made my brother run the DenseMapSIMD tests, and all 26 of them have passed successfully on his Macbook Air M1. This is after replacing the Sse2 intrinsics with the platform independent ones.
However 6 DenseMap (non-SIMD) tests have failed both on his M1 and on my AMD Ryzen. Please take a look

not really sure why they are failing, they seem to work on my intel cpu

Sorry about that ... the failing tests are for FasterMap
This is one of them
        [TestMethod]
        public void AssertCustomEnumerators()
        {
            var map = new FastMap<uint, uint>();
            map.Emplace(202, 202); //13
            map.Emplace(131, 131); //15
            map.Emplace(597, 597); //15
            map.Emplace(681, 681); //14
            map.Emplace(893, 893); //14
            map.Emplace(516, 516); //14

            var count = 0;
            var count2 = 0;
            foreach (uint unused in map.Keys)
            {
                count++;
            }

            Assert.IsTrue(count == 6);

            foreach (uint unused in map.Values)
            {
                count2++;
            }

            Assert.IsTrue(count2 == 6);
        }

It fails on Assert.IsTrue(count == 6);

Should probably add a deprecated attribute. I like my robinhood hashmap implementation thats the only reason its still in here.

Did you manage to reproduce it on your machine?

yea thnx

Here's a sample run of GetBenchmark under M1 using "VisualStudio for Mac". The results of FastMap are debatable, considering that the tests for it fail
Apple M1, 1 CPU, 8 logical and 8 physical cores
.NET SDK=7.0.202
  [Host]     : .NET 7.0.4 (7.0.423.11508), Arm64 RyuJIT  [AttachedDebugger]
  Job-YUSQNG : .NET 7.0.4 (7.0.423.11508), Arm64 RyuJIT

InvocationCount=128  IterationCount=50  LaunchCount=1
RunStrategy=Monitoring  WarmupCount=10

|         Method |      Mean |     Error |    StdDev |
|--------------- |----------:|----------:|----------:|
|   DenseMapSIMD |  7.940 ms | 0.0127 ms | 0.0257 ms |
|       DenseMap | 11.415 ms | 0.0321 ms | 0.0648 ms |
|        FastMap |  7.046 ms | 0.0342 ms | 0.0691 ms |
| SlimDictionary | 14.283 ms | 0.0241 ms | 0.0486 ms |
|     Dictionary | 17.728 ms | 0.0582 ms | 0.1176 ms |

Actually was looking for something like this:
https://github.com/dotnet/runtime/issues/49397
https://github.com/dotnet/runtime/issues/63331
Anyhow, if you like you can submit a pull request :)

Done


chore: upgrade Node.js to 16.15.0 and NPM to 8.5.5

Coverage: 91.463% (-0.0%) from 91.463% when pulling 718ecfe4833dcce2111abbc46cf25e0e1f44c356 on pbredenberg:PB/chore-upgrade-node into 77804dc0d2ca9d62555bcf9f41502ddea3c2979a on silvermine:master.

Coverage: 91.463% (-0.0%) from 91.463% when pulling 718ecfe4833dcce2111abbc46cf25e0e1f44c356 on pbredenberg:PB/chore-upgrade-node into 77804dc0d2ca9d62555bcf9f41502ddea3c2979a on silvermine:master.

@onebytegone I'm afraid I've once again ruined everything by causing coverage to drop by a truly abysmal -0%


Add more best practices

Use applicative RequestReaders.

Current coverage is 90.85%

Merging #450 into master will decrease coverage by -3.21% as of 6bde24f

Powered by Codecov. Updated on successful CI builds.


Some Tag Info Missing

Some crucial tag info like Artist,Year,Track Nos,Genre are missing

official api has been changed