"scale" does not work with wildcard

output * works for some settings, but not other:
output * bg ~/.wallpapers/1.jpg fill  # Works
output eDP-1 scale 2.0  # Works
output * scale 2.0  # Doesn't work!

I found the inconsistency to be quite confusing (and undocumented). This was doubly annoying, because my initial scale attempt (See #1165) didn't work either way).
If this is too complex to work around, maybe just documenting the discrepancy will do.

Is this by design? Not-a-bug? Just wondering why the closure (not really a problem for me, since I've worked around it, just wondering).

Integral scaling only. Sorry, though that was clear from the other issue.

What I'm pointing out is that wildcard doesn't work:
output * bg ~/.wallpapers/1.jpg fill
#      ^ wildcard works here...
output * scale 2
#      ^ ... but not here.

It still doesn't work when you use 2 instead of 2.0? And can I see the full config please?

It works if I just replace * with eDP-1.
Fill config (lots of unrelated stuff):
# This file has been auto-generated by i3-config-wizard(1).
# It will not be overwritten, so edit it as you like.
#
# Should you change your keyboard layout some time, delete
# this file and re-run i3-config-wizard(1).
#

# i3 config file (v4)
#
# Please see http://i3wm.org/docs/userguide.html for a complete reference!

### SWAY-SPECIFIC-STUFF

# input "1452:657:Apple_Inc._Apple_Internal_Keyboard_/_Trac" {
#   natural_scroll enabled
# }

### / SWAY-SPECIFIC-STUFF

set $mod Mod4

### colour ###

# set $bg-color            #414959
# set $inactive-bg-color   #303641
# set $text-color          #b3bdcb
# set $inactive-text-color #9da3ad
# set $urgent-bg-color     #E53935

set $bg-color            #404552

set $focused-bg-color    #404552
set $active-bg-color     #373c48
set $inactive-bg-color   #2f343f
set $text-color          #c3cddb
set $inactive-text-color #9da3ad
set $urgent-bg-color     #E53935

set $indicator           #00ff00
set $separator           #757575

# class                 border              background         text                 indicator
client.focused          $focused-bg-color   $focused-bg-color  $text-color          $indicator
client.unfocused        $inactive-bg-color  $inactive-bg-color $inactive-text-color $indicator
client.focused_inactive $inactive-bg-color  $focused-bg-color  $inactive-text-color $indicator
client.urgent           $urgent-bg-color    $urgent-bg-color   $text-color          $indicator

# client.unfocused #3a3a3a #222222 #bbbbbb #292d2e

### /colours ###

# Font for window titles. Will also be used by the bar unless a different font
# is used in the bar {} block below.
# This font is widely installed, provides lots of unicode glyphs, right-to-left
# text rendering and scalability on retina/hidpi displays (thanks to pango).
# font pango:DejaVu Sans Mono 8
font pango:Open Sans 9
# Before i3 v4.8, we used to recommend this one as the default:
# font -misc-fixed-medium-r-normal--13-120-75-75-C-70-iso10646-1
# The font above is very space-efficient, that is, it looks good, sharp and
# clear in small sizes. However, its unicode glyph coverage is limited, the old
# X core fonts rendering does not support right-to-left and this being a bitmap
# font, it doesn’t scale on retina/hidpi displays.

 It is a wrapper around dmenu, so you need that
# installed.
# bindsym $mod+d exec --no-startup-id i3-dmenu-desktop

# change focus
bindsym $mod+h focus left
bindsym $mod+j focus down
bindsym $mod+k focus up
bindsym $mod+l focus right

# alternatively, you can use the cursor keys:
bindsym $mod+Left focus left
bindsym $mod+Down focus down
bindsym $mod+Up focus up
bindsym $mod+Right focus right

# move focused window
bindsym $mod+Shift+h move left
bindsym $mod+Shift+j move down
bindsym $mod+Shift+k move up
bindsym $mod+Shift+l move right

# alternatively, you can use the cursor keys:
bindsym $mod+Shift+Left move left
bindsym $mod+Shift+Down move down
bindsym $mod+Shift+Up move up
bindsym $mod+Shift+Right move right

# split in horizontal orientation
bindsym $mod+b split h

# split in vertical orientation
bindsym $mod+v split v

# enter fullscreen mode for the focused container
bindsym $mod+f fullscreen

# change container layout (stacked, tabbed, toggle split)
bindsym $mod+s layout stacking
bindsym $mod+w layout tabbed
bindsym $mod+e layout toggle split

# toggle tiling / floating
bindsym $mod+Shift+space floating toggle

# change focus between tiling / floating windows
bindsym $mod+space focus mode_toggle

# focus the parent container
bindsym $mod+a focus parent

# focus the child container
bindsym $mod+Shift+a focus child

# switch to workspace
bindsym $mod+1 workspace "1: "
bindsym $mod+2 workspace 2
bindsym $mod+3 workspace 3
bindsym $mod+4 workspace 4
bindsym $mod+5 workspace 5
bindsym $mod+6 workspace 6
bindsym $mod+7 workspace 7
bindsym $mod+8 workspace "8: 🔊"
bindsym $mod+9 workspace "9: "
bindsym $mod+0 workspace "10: "
bindsym $mod+Control+1 workspace 11
bindsym $mod+Control+2 workspace 12
bindsym $mod+Control+3 workspace 13
bindsym $mod+Control+4 workspace 14
bindsym $mod+Control+5 workspace 15
bindsym $mod+Control+6 workspace 16
bindsym $mod+Control+7 workspace 17
bindsym $mod+Control+8 workspace 18
bindsym $mod+Control+9 workspace 19
bindsym $mod+Control+0 workspace 20

# move focused container to workspace
bindsym $mod+Shift+1 move container to workspace "1: "
bindsym $mod+Shift+2 move container to workspace 2
bindsym $mod+Shift+3 move container to workspace 3
bindsym $mod+Shift+4 move container to workspace 4
bindsym $mod+Shift+5 move container to workspace 5
bindsym $mod+Shift+6 move container to workspace 6
bindsym $mod+Shift+7 move container to workspace 7
bindsym $mod+Shift+8 move container to workspace "8: 🔊"
bindsym $mod+Shift+9 move container to workspace "9: "
bindsym $mod+Shift+0 move container to workspace "10: "
bindsym $mod+Shift+Control+1 move container to workspace 11
bindsym $mod+Shift+Control+2 move container to workspace 12
bindsym $mod+Shift+Control+3 move container to workspace 13
bindsym $mod+Shift+Control+4 move container to workspace 14
bindsym $mod+Shift+Control+5 move container to workspace 15
bindsym $mod+Shift+Control+6 move container to workspace 16
bindsym $mod+Shift+Control+7 move container to workspace 17
bindsym $mod+Shift+Control+8 move container to workspace 18
bindsym $mod+Shift+Control+9 move container to workspace 19
bindsym $mod+Shift+Control+0 move container to workspace 20

# reload the configuration file
bindsym $mod+Shift+c reload
# restart i3 inplace (preserves your layout/session, can be used to upgrade i3)
bindsym $mod+Shift+r restart
# exit i3 (logs you out of your X session)
bindsym $mod+Shift+e exec "i3-nagbar -t warning -m 'You pressed the exit shortcut. Do you really want to exit i3? This will end your X session.' -b 'Yes, exit i3' 'i3-msg exit'"

# resize window (you can also use the mouse for that)
mode "resize" {
        # These bindings trigger as soon as you enter the resize mode

        # Pressing left will shrink the window’s width.
        # Pressing right will grow the window’s width.
        # Pressing up will shrink the window’s height.
        # Pressing down will grow the window’s height.
        bindsym h resize shrink width 10 px or 10 ppt
        bindsym j resize grow height 10 px or 10 ppt
        bindsym k resize shrink height 10 px or 10 ppt
        bindsym l resize grow width 10 px or 10 ppt

        # same bindings, but for the arrow keys
        bindsym Left resize shrink width 10 px or 10 ppt
        bindsym Down resize grow height 10 px or 10 ppt
        bindsym Up resize shrink height 10 px or 10 ppt
        bindsym Right resize grow width 10 px or 10 ppt

        # back to normal: Enter or Escape
        bindsym Return mode "default"
        bindsym Escape mode "default"
}

bindsym $mod+r mode "resize"

# Start i3bar to display a workspace bar (plus the system information i3status
# finds out, if available)
bar {
        status_command python $HOME/.config/i3/status.py
        colors {
          background $inactive-bg-color
          separator $separator
          #                  border             background         text
          focused_workspace  $focused-bg-color  $focused-bg-color  $text-color
          active_workspace   $focused-bg-color  $active-bg-color   $text-color
          inactive_workspace $inactive-bg-color  $inactive-bg-color $inactive-text-color
          urgent_workspace   $urgent-bg-color   $urgent-bg-color   $text-color
        }
        separator_symbol "|"

        # tray_output primary
}

#exec_always --no-startup-id feh --bg-scale $HOME/.wallpapers/1.jpg
output * bg ~/.wallpapers/1.jpg fill
output eDP-1 scale 2.0
# output * scale 2.0

new_window pixel
hide_edge_borders both

for_window [class="B2g"] floating enable
for_window [class="Upwork"] floating disable

input "1452:628:Apple_Inc._Apple_Internal_Keyboard_\/_Trac" {
  natural_scroll enabled
}

workspace_auto_back_and_forth yes

new_window pixel 4

Oh, sorry, the problem is obvious but I missed it in your initial post. You can't do two output commands for the same output - they overwrite. This is noted on the man page.

(including if that output is "*")

Ah, sorry for the noise then. 😅

No worries, it's all good


Remove specific protocol buffer dependencies from RRServer

Since RRServer is generic, we shouldn't have JobMaster protocl buffers inside it.

removed JobMaster protocols from RRserver


[Question] Using dynaconf, how would I go about getting the well known environment Linux variable "PATH"?

If I just wanted to get the well known environment Linux variable PATH, how should I fetch it using dynaconf?
I tried:
settings.get('PATH', 'Noooope')
and always get Noooope
I am hoping for a behavior similar to os.environ["PATH"]  but with all the (optional) dynaconf goodness, if they are present

https://github.com/rochacbruno/dynaconf/blob/b3aff91da5a17a6e4646d439e3477bb4d21369bf/dynaconf/base.py#L465-L481
settings.get_environ("PATH", "Noooper")

@rochacbruno I really appreciate you taking your time to read the details and helping me out! I don't know why I couldn't find this detail earlier and I tried to read the docs, look at the examples and Google as well.
I am assuming get_environ also supports dynaconf goodness, if they are present eg:
Setting DYNACONF_PATH would override the system PATH inside the dynaconf settings?

I think the idea of this issue is to provide an API to get a value from settings and fallback to envvars.
To be implemented.
from dynaconf import Dynaconf

settings = Dynaconf(
	fallback_to_environ=True,
	fallback_to_environ=["PATH", ...],
)

print(settings.PATH)
# if not available on `settings` would fallback to `get_environ` and follow all the dynaconf formatting etc...

Right now the workaround is.
settings.get("PATH", default=settings.get_environ("PATH"))

One thing to notice is that you can set envvar_prefix=False and then dynaconf will read all the environment variables from your system.


cSpell is activated before reading settings.

Hi @Jason-Rev
vscode: 1.15
os: Manjaro Linux KDE Gellivara
I set  "cSpell.enabled": false on settings.json but it keep analyzing files even when is disabled.
It only happens when I open a workspace with opened documents previously. If I open a empty workspace it won't happen. Seems that cSpell has a small delay reading settings.json so opened files are analized before.
Also I can see cSpell is always activated because this: #L31 (same issue as https://github.com/editorconfig/editorconfig-vscode/pull/159

BTW, thanks for this extension :smile:

Thank you.
Do you have an idea how long this has been happening?

Well, It happen from day one I installed the extension. :sweat_smile: , I didn't realize because the errors disappear when you open another file or close the open one.

I need to disable cSpell because I use it for specific workspaces only. By example: documents and papers in Markdown and Latex, or sometimes for Yaml and Json. Also I write in English and Spanish. So many configurations in differents workspaces. :sweat_smile:

Do you remember when you started using the extension? I am trying to determine when this behavior might have started.
I recently added a Spanish dictionary: Spell Checker for Spanish. I would appreciate any feedback on how well it works for you.

As a work around, you can disable cspell in your user settings, then only enable it in each workspace.

As a work around, you can disable cspell in your user settings, then only enable it in each workspace.

Exactly what I'm doing
BTW, Spanish extension works like a charm, npm package cspell-dict-es-es is not needed now :+1:

Got it. I can see how this could happen. It is a race condition on startup.

I have pushed out a new version that should help with this issue.
But there are some more things going on. VS Code opens some files in the background. Only it isn't easy to tell that these files are in the background. The settings.json file is an example.  So is package.json.

This bug is fixed with your latest version. Thanks you very much! :smile:


unable to solve warning 'Direct access in function makeError(ream::SyncError&&)'

How frequently does the bug occur?
Always
Description
xcode warning that I am not able to solve:
Direct access in function 'makeError(realm::SyncError&&)' from file '/Users/X/Library/Developer/Xcode/DerivedData/X/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/Realm.build/Objects-normal/arm64/RLMError.o' to global weak symbol 'realm::SyncError::c_recovery_file_path_key' from file '/Users/X/Library/Developer/Xcode/DerivedData/X/Build/Products/Debug-iphoneos/XCFrameworkIntermediates/Realm/librealm-monorepo.a(sync_session.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
I tried restarting xcode and deleting the DerivedData folder, but that did not help shutting down the warning.
realm version: 10.41 (installed via pod)
xcode version: 14.3.1
project target: iOS 16.5
swift version: 5.8
Stacktrace & log output
Direct access in function 'makeError(realm::SyncError&&)' from file '/Users/X/Library/Developer/Xcode/DerivedData/X/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/Realm.build/Objects-normal/arm64/RLMError.o' to global weak symbol 'realm::SyncError::c_recovery_file_path_key' from file '/Users/X/Library/Developer/Xcode/DerivedData/X/Build/Products/Debug-iphoneos/XCFrameworkIntermediates/Realm/librealm-monorepo.a(sync_session.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

Can you reproduce the bug?
Always
Reproduction Steps
No response
Version
10.41
What Atlas Services are you using?
Local Database only
Are you using encryption?
No
Platform OS and version(s)
16.5
Build environment
Xcode version: 14.3.1

I'm seeing this also with Xcode 15.0 and RealmSwift 10.43.1.
Is this something to worry about or can it be safely ignored?

any updates?


Project not available via Jitpack

This project seems to be currently unavailable via Jitpack. Due to the error message

Tag or commit '1.7.0' not found. Rechecking.

I assume that this is because this project, other than upstream, does not have any releases defined. I'm not sure if you actually want to start defining releases already - if not, having a small note in the Get Started section of README.md mentioning that including this project currently doesn't work could be an alternative.

Spoke too soon, please disregard. :) Project is available via the version "master-SNAPSHOT" or using the commit hash. That is even mentioned in README.md.


Camera sticks on "floor" after teleportation?

`float height = targetPosition.y;
targetPosition -= CameraCache.Main.transform.position - MixedRealityPlayspace.Position;
targetPosition.y = height;
MixedRealityPlayspace.Position = targetPosition;`
Source code copied from "MixedRealityTeleportSystem.cs", seems there is nowhere to adjust height after teleportation?

There's usually no need to adjust the height after this. The Camera is always a child of the MixedRealityPlayspace, usually with the correct offset from it, like 1,8 on y if that's how tall you are. Unless you're using teleportation on devices like the Hololens, which basically starts at the floor level, but is not supposed to use teleportation.

Is there a way to explicitly set this offset? I had some instances where the camera was stuck at floorlevel after teleporting in my VR application. I couldn't reliably recreate it. Maybe it was due to tracking loss or something, but it would be nice to rule  the possibility out entirely. Maybe set an allowed minimum height for the camera.

@Alexees It is supposed to have the correct offset on MixedRealityPlayspace, but so far the Main Camera is always sticking on the ground in my VR project, like the image below

Like @JSWorkspace1 mentioned, maybe it is due to tracking loss, I think to set an offset after teleportation or offer an entry to manually adjust the offset between MixedRealityPlayspace and Camera would be better.

The fact that the Main Camera's position is nearly 0,0,0 confirms the fact that it's not a MRTK issue but a tracking problem. As soon as tracking is back, at least the y value should jump to the correct height. The fact that a tracking loss causes this is bad enough and shouldn't be happening at all, since, in case of Microsoft's portal still manages to keep the head up when in the cliff house for example. For some reason it feeds 0 values to Unity...
Way back, I reported this but it did not seem to matter too much or was in the wrong place:
https://github.com/microsoft/MixedRealityToolkit-Unity/issues/1455
Maybe it's a Unity problem, or even a vendor software problem not feeding in correct values on lost tracking even though outside the software you're above floor level.

I still think it would be a good feature if the height Offset  was made accessible.
This would allow  developers to create fallbacks in case the other systems fail.


Promise of union types compilation error

TypeScript Version:  2.7.0-dev.201xxxxx
Code
const p = Promise.resolve(Promise.resolve('string') || 10)

Expected behavior:
p type to be inferred as Promise<string | number>
Actual behavior:
Compilation error
Argument of type '10 | Promise<string>' is not assignable to parameter of type 'string | PromiseLike<string>'.
  Type '10' is not assignable to type 'string | PromiseLike<string>'.

Notes:
const p2 = Promise.resolve(Promise.resolve('string') || '10')

works correctly. It's only when types are different that compilation breaks.

Note that if you have --strictNullChecks on you need Promise.resolve(1 ? Promise.resolve('string') : 10); to reproduce this error.
In case you didn't already know, you can work around this using an explicit type argument: Promise.resolve<string | number>(...).

When you pass a union type from the use site to a generic method, the behavior seems to be to follow some resolution rules to pick the most applicable component of the union type and apply it rather than combining the types.
`interface Wrap {
dummy:T
}
type genericWrap = (p: Wrap) => T;
type genericUnion = (p: T | Wrap) => T;
const f = {} as genericUnion;
const f2 = {} as genericWrap;
f({} as number | string); // correct
f({} as string | Wrap); // wrong  number | Wrap
f2({} as Wrap | Wrap);  // wrong Wrap`


Update Makefile to allow better configurability and use in single-account environments.

Currently, the Makefile does not allow using environment variables to specify its variables. However, this can be fixed using the ?= assignment instead of = for key variables. Change this and also add documentation for how to use these variables. This is useful for environments where there is only a single account UID, GID.
Also, the issue where spaces at the front of a string inside a Makefile can be addressed by placing the newline symbol at the front. This will make it easier to read.

Also silence the vs command with @.


[#6100] Remove unnecessary partial classes - Schema classes (1/2)

Addresses # 6100
#minor
Description
This PR removes the partial modifier from classes with only one definition in Microsoft.Bot.Schema.
Specific Changes

Removed the partial modifier from classes with only one definition.
Removed partial method CustomInit and the constructor that was using it.
Removed unnecessary using statements.
Added null validation for constructor's parameters in AttachmentData class.

Testing
This image shows the tests passing after the changes.

Promoted to MS in PR# 6252


(#93) A more surgical way to get the expected PATCH capability

@googlebot I signed it!

@jonasfj Can I get a review of this change?

Closing this as it is stale. Feel free to reopen in case you still want to land it!


execute-job/wrong-commit-sha-on-pr/becd265c-0d59-42d1-b95d-2595a434bcd4

PR for testing 6cfad88d93bea2b1005dc1e07e3a43a3bd5d68b2

/canonical/self-hosted-runners/run-workflows a556329d0f19affa608643d746ee6f7c818c627b


adding ability to specify placement group

Closes #353

What's the status on this? I just patched my local vagrant-aws plugin, and it seems to work fine.


[Epic] Add functionality to communicate from WSL(2) to the CRC VM on Windows

Although it is early day, WSL2 uses Hyper-V and provides a nice experience when it comes to coding (like remote-WSL from VSCode). Although for WSL2 there is no direct way to communicate from the WSL Virtual Switch to the Default Switch. A possibility would be to add the WSL switch tothe CRC VM once the environment is enabled, and configure accordingly so oc from WSL can communicate with the CRC VM.
Note: this behaviour is different from WSL(v1) where the Windows networking stack is shared between Windows and the Linux susbsystem

Enable forwarding for the vSwitch allows traffic https://github.com/code-ready/crc/issues/374#issuecomment-803580645 however, this only works with the legacy vSwitch mode, not vsock.

Hi there, currently I am trying the provision based on wsl2 ubuntu box(using the  crc binary of linux version). When I run crc setup inside wsl2 box, it shows some error messages:
david@XXXX:/mnt/c/WINDOWS/system32$ crc setup --log-level debug
INFO Checking if NetworkManager is installed
DEBU Checking if 'nmcli' is available
DEBU 'nmcli' was found in /usr/bin/nmcli
INFO Checking if NetworkManager service is running
DEBU Checking if NetworkManager.service is running
DEBU exit status 1 : System has not been booted with systemd as init system (PID 1). Can't operate.
FATA NetworkManager is required. Please make sure it is installed and running manually

I have done apt install network-manager and started the service manually to make sure it is running. It turns out that in the source code:
// https://github.com/code-ready/crc/blob/master/pkg/crc/preflight/preflight_checks_linux.go#L458
......
path, err := exec.LookPath("systemctl")
...
stdOut, stdErr, err := crcos.RunWithDefaultLocale(path, "is-active", "NetworkManager")
...

Currently the code is using the command systemctl is-active NetworkManager, which is not working now in WSL2 box, it should be like service network-manager status and check the result for "running".
Is it worthy of making a PR to cover the provision for wsl2 box? If so, I am glad to do it.
Looking forward to ur idea.

The issue here talks about communication between WSL(2) and CRC-VM, like using oc, but actually targeting the underlying Hyper-V to host the CRC-vm.
@nevermosby Note that the setup you tried would never be supported as that involves nested-virtualization in which the environment runs hyper-v -> kvm -> crc-vm  instead of hyper-v -> crc-vm or kvm -> crc-vm. Also note that WSL2 is a non-standard configuration that uses their own init system in-place of the distros (and modified kernel). This causes issues when something like systemd is expected. We might come back to this in the future.

Hi,
Where are we with this issue, now WSL 2 has been officially released?
Without this issue fixed I cannot use Quarkus to send s2i native builds to openshift because the quarkus-openshift extension uses OC under the wood.

I found a work around for this issue here -> https://github.com/microsoft/WSL/issues/4288#issuecomment-652259640
Basically you need to retrieve the switch IDs of the virtual switches for CRC and WSL and then enable forwarding support.
Open PowerShell (run as admin)
Retrieve IDs
Get-NetIPInterface | select ifIndex,InterfaceAlias,AddressFamily,ConnectionState,Forwarding | Sort-Object -Property IfIndex | Format-Table
Enabling forwarding for WSL - change MYvEthernetWSLID to the id number of your WSL switch from the previous command
Set-NetIPInterface -ifindex MYvEthernetWSLID -Forwarding Enabled
Enable forwading for CRC - change MYvEthernetSWITCHID to the id number of your WSL switch from the previous command
Set-NetIPInterface -ifindex MYvEthernetSWITCHID -Forwarding Enabled
Immediately after running this I was able to run oc commands in WSL2 without issue.

The above workaround worked for me - thanks @mageru!
My own poor-man's workaround:
Run oc proxy on the Windows host, bound to the WSL bridge, and access it via the bridge IP from within WSL.
This is rather more involved than @mageru's workaround, but doesn't require tampering with Windows networking:
Here's the details for anyone interested:
On the Windows host:
Retrieve WSL bridge IP address:
netsh interface ip show addresses "vEthernet (WSL)"

Login to the CRC cluster:
oc login -u kubeadmin -p <token> https://api.crc.testing:6443

Start oc proxy/kubectl proxy (accept firewall prompt):
oc proxy --port=8001 --api-prefix='/' --address=<WSL bridge IP> --accept-hosts=".*"

From within WSL:
Retrieve WSL bridge IP address:
WSL_BRIDGE_IP=$(grep nameserver /etc/resolv.conf | sed 's/nameserver //')

Configure an oc/kubectl context to access the CRC cluster:
oc config set clusters.crc.server $WSL_BRIDGE_IP:8001
oc config set contexts.crc.cluster crc
oc config use-context crc

And you're good to go.
Note: Hyper-V bridge IPs seem to change with each system restart, so automate this by putting the corresponding commands in a Windows startup script and in your ~/.profile in WSL.

@zcahana The solution does not work for me. Is there an new issue with WSL2?
On Windows host:
C:\xxx>crc config view
- consent-telemetry                     : no
- network-mode                          : vsock
- pull-secret-file                      : C:\xxx\pull-secret.txt
C:\xxx>crc daemon
INFO listening vsock://00000400-FACB-11E6-BD58-64006A7986D3
INFO listening \\.\pipe\crc-http
2021/03/16 07:05:50 tcpproxy: for incoming conn <IP_ADDRESS>:62444, error dialing "<IP_ADDRESS>:22": context deadline exceeded
2021/03/16 07:06:01 tcpproxy: for incoming conn <IP_ADDRESS>:62458, error dialing "<IP_ADDRESS>:22": context deadline exceeded
2021/03/16 07:06:02 tcpproxy: for incoming conn <IP_ADDRESS>:62459, error dialing "<IP_ADDRESS>:6443": context deadline exceeded
2021/03/16 07:06:12 tcpproxy: for incoming conn <IP_ADDRESS>:61351, error dialing "<IP_ADDRESS>:22": context deadline exceeded
INFO new connection from 47925440-0000-0000-0000-000000000000:ded05241-facb-11e6-bd58-64006a7986d3 to 00000000-0000-0000-0000-000000000000:00000400-facb-11e6-bd58-64006a7986d3
INFO assigning <IP_ADDRESS>/24 to 47925440-0000-0000-0000-000000000000:ded05241-facb-11e6-bd58-64006a7986d3

C:\xxx>crc status
CRC VM:          Running
OpenShift:       Running (v4.7.0)
Disk Usage:      14.23GB of 32.74GB (Inside the CRC VM)
Cache Usage:     25.26GB
Cache Directory: C:\xxx\.crc\cache
C:\xxx>netsh interface ip show addresses "vEthernet (WSL)"

Configuration for interface "vEthernet (WSL)"
    DHCP enabled:                         No
    IP Address:                           <IP_ADDRESS>
    Subnet Prefix:                        <IP_ADDRESS>/20 (mask <IP_ADDRESS>)
    InterfaceMetric:                      5000

C:\xxx>oc proxy --port=8001 --api-prefix='/' --address=<IP_ADDRESS> --accept-hosts=".*"
Starting to serve on <IP_ADDRESS>:8001

On WSL2:
> lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal
> WSL_BRIDGE_IP=$(grep nameserver /etc/resolv.conf | sed 's/nameserver //')
> oc config set clusters.crc.server $WSL_BRIDGE_IP:8001
Property "clusters.crc.server" set.
> oc config set contexts.crc.cluster crc
Property "contexts.crc.cluster" set.
> oc config use-context crc
Switched to context "crc".
> oc version
Client Version: 4.7.1
Unable to connect to the server: dial tcp <IP_ADDRESS>:8001: i/o timeout

I added a custom inbound rule to the Windows Defender Firewall:

After this I was at least able to ping the nameserver:
> ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=128 time=0.385 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=128 time=0.259 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=128 time=0.353 ms

But oc was still not able to connect to the server.

This is what I have been using since: https://github.com/gbraad/windows-dotfiles/blob/main/setup-wsl.ps1
# Allow traffic from Hyper-V VMs to WSL and vice versa
Set-NetIPInterface -ifAlias "vEthernet (WSL)" -Forwarding Enabled
Set-NetIPInterface -ifAlias "vEthernet (Default Switch)" -Forwarding Enabled

I almost wanna close this issue as this is NOT an issue with CRC, but the defaults of Windows. I have spoken to several of their engineers and they are aware of it and looking towards a solution. There is nothing we can do to improve this besides pointing out the forwarding rule.

@zcahana The solution does not work for me.

You are using vsock which binds port 22 for SSH to a local port anyway, which is 2222:
https://github.com/code-ready/crc/blob/899cffc759d8019f7993c978598641fd488c49e9/pkg/crc/constants/constants.go#L37

When I run crc setup inside wsl2 box, it shows some error messages:

Do NOT install or run CRC from the WSL2 environment. This requires nested virtualization; this is unsupported as it impacts performance. Plus, the used kernel did not originally come with this functionality enabled. Install as a native Hyper-V VM from the Windows host and merely use oc from the WSL2 environment.

@gbraad Still not working. Last try :). Do you see what's wrong here?

When you use vsock you can not use it as if you described by those before here.
Since i do not know where these IP addresses come from, I have no idea what to look for.
172. Indicate external,  do that is never gonna work as the endpoint.
With vsock you bind 2222 for ssh on localhost (and api, etc) so you need netsh to expose this for external use.

Greetings.
Maybe someone will find this helpful.
In my case changing port forwarding command did not help.
and after reboot adapter status returns to initial state = Disabled.
I meant this one "Set-NetIPInterface -ifindex MYvEthernetSWITCHID -Forwarding Enabled".
In my case helped to use "oc.exe" command under WSL2 shell
suddenly this command start to work
"oc.exe login -u developer -p developer https://api.crc.testing:6443"
Login successful.
after this step, I just crated a symbolic link to oc.exe
sudo ln --symbolic /mnt/c/Hyper-V/IBM-OpenShift/oc.exe /usr/sbin/oc
and now I'm able to use OC under WSL2 shell.
my previous attempts to use OC for Linux Download oc for Linux for x86_64
faced with issue
The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?

So essentially you arejust using a direct connection from windows. Since this isnt the Linux client zome things might not work or different

From: TarasHalakaItera @.>
Sent: Tuesday, May 3, 2022 1:40:10 PM
To: code-ready/crc @.>
Cc: Gerard Braad @.>; Mention @.>
Subject: Re: [code-ready/crc] [Epic] Add functionality to communicate from WSL(2) to the CRC VM on Windows (#374)
Greetings.
Maybe someone will find this helpful.
In my case changing port forwarding command did not help.
and after reboot adapter status returns to initial state = Disabled.
I meant this one "Set-NetIPInterface -ifindex MYvEthernetSWITCHID -Forwarding Enabled".
In my case helped to use "oc.exe" command under WSL2 shell
suddenly this command start to work
"oc.exe login -u developer -p developer https://api.crc.testing:6443"
Login successful.
after this step, I just crated a symbolic link to oc.exe
sudo ln --symbolic /mnt/c/Hyper-V/IBM-OpenShift/oc.exe /usr/sbin/oc
and now I'm able to use OC under WSL2 shell.
my previous attempts to use OC for Linux Download oc for Linux for x86_64https://downloads-openshift-console.apps-crc.testing/amd64/linux/oc.tar
faced with issue
The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?
—
Reply to this email directly, view it on GitHubhttps://github.com/code-ready/crc/issues/374#issuecomment-1115755699, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAAOZV33XKS7WQC6PGHLW3VIC33VANCNFSM4IJDNFNA.
You are receiving this because you were mentioned.Message ID: @.***>

So essentially you arejust using a direct connection from windows. Since this isnt the Linux client zome things might not work or different

Looks like so.
but so far so good. at least for my study-cases with CRC.
autocomplete also works under WSL2.

Actually, in my case, neither the IP forwarding nor the port forwarding nor using oc.exe within WSL2 really solve the problem. The two former never work, and the latter may work for oc commands but not for other tools like helm.
Essentially, crc is still UNUSABLE with WSL2, which is a shame as it defeats the purpose of having a working testing / development environment for OpenShift on a Windows system.
Are there any plans at all to resolve this? Maybe offer an option during crc install to use the WSL2 network instead of the Hyper-V Default switch (which is a rather lame implementation of a virtual network, compared to VirtualBox)?
Thanks.

With the latest WSL2 on Windows 11; I think the problem has changed. Even with the forwarding with between network switches; and with or without the kubectl proxy above a new error is
error: couldn't get https://<IP_ADDRESS>:6443/.well-known/oauth-authorization-server: unexpected response status 401

Where 172... is the IP of the windows host from the perspective of wsl2.

I've reproduced @TarasHalakaItera approach of using oc.exe rather than the Linux oc command.
Looking in the OC logs, there is a notable difference.
oc.exe uses
I0303 14:05:41.015011   25436 request_token.go:98] SSPI Enabled
where as oc
I0303 13:49:11.734592   61491 request_token.go:93] GSSAPI Enabled

Having OC working is ok-ish - but then if want to run any kubectl command I can't.

@mbwhite
What happens is that oc.exe is invoked outside the 'modified' network stack of Linux. This means that the comment works directly from the host, outside the network assignment.
SSPI is a Windows specific security provider, as the alternative to GSSAPI. This is not what causes the network related issues. The 401 might be returned as for authentication, it is not the expected endpoint and it concludes 'Unauthorized'. Would need more information what you have tried or set up.

To add another solution into the mix this worked for me:

In the wsl2 distro, edit /etc/hosts and replace <IP_ADDRESS> for the crc related entries with your host machine IP (e.g. <IP_ADDRESS>)
In powershell on windows run netsh interface portproxy add v4tov4 listenport=6443 listenaddress=<IP_ADDRESS> connectport=6443 connectaddress=<IP_ADDRESS> to listen globally for api connections and forward them.
Add a firewall rule to allow this traffic New-NetFirewallRule -DisplayName "CRC API from WSL2" -Direction Inbound -LocalPort 6443 -Protocol TCP -Action Allow -RemoteAddress <IP_ADDRESS>. Replacing <IP_ADDRESS> with your host machine IP.
In wsl2, run curl -k https://api.crc.testing:6443 to check connectivity.

This should be fixed when the new mirrored network mode becomes GA https://devblogs.microsoft.com/commandline/windows-subsystem-for-linux-september-2023-update/#new-networking-mode-mirrored

Can confirm @hoo29's solution works for me.
However, even though I'm using the latest version of crc, I still need to delete the port proxy with netsh before starting crc again, and then add it back again after.
i.e.
netsh interface portproxy delete v4tov4 listenport=6443 listenaddress=<IP_ADDRESS>
crc start
netsh interface portproxy add v4tov4 listenport=6443 listenaddress=<IP_ADDRESS> connectport=6443 connectaddress=<IP_ADDRESS>

Remember to regularly get the IP address for the host from /etc/resolv.conf and put it in /etc/hosts, as windows constantly regenerates both of those files.
At least the firewall rule only has to be added once!

@tim-stasse  - I don't use crc at the moment so not sure about the port proxy rules but I had this helper script to auto update my hosts file
#!/bin/bash
set -euo pipefail

NAMESERVER=$(grep nameserver /etc/resolv.conf | tail -n 1 | cut -d ' ' -f 2)
HOSTS_LINE=$(grep "api.crc.testing" /etc/hosts)
DOMAINS=$(echo "$HOSTS_LINE" | sed "s/\s\+/ /g" | cut -d " " -f 2-)
sed -i "/api.crc.testing/c\\$NAMESERVER $DOMAINS" /etc/hosts

Save this to /root/update_hosts.sh, chmod +x it, and then echo "@reboot root /root/update_hosts.sh >> /etc/crontab" to automatically run it on every reboot. I found it can take a couple of mins after a reboot to run but gets there eventually.

Mirrored mode networking appears to be GA (despite what the docs say).
With the below .wslconfig on Windows 11 23H2 build 22631.2715 and WSL 2.0.9, everything just works now 😄
[wsl2]
networkingMode=mirrored
firewall=true
dnsTunneling=true


Merchant combo : vaadin-overlay-behavior.html:105 Uncaught ReferenceError: unwrap is not defined

The combo for the merchant gives an error when running local .. maybe I amd doing something wrong. Any idea ?
Local I see this (and the combox box does not work) :

The Live demo shows :

In the console I have the error
vaadin-overlay-behavior.html:105 Uncaught ReferenceError: unwrap is not defined

When I put a breakpoint in the _setPosition function on the LIve demo, the function is not being called... ?

Hi, thanks for reporting. I suspect that you may have a newer pre-release version of combo-box. Can you check your bower listing and report what version you are on? Also try setting the version to 1.0.0.rc1 explicitly in bower.js and see if that fixes it.

I can see the same problem on my end. Filed an issue on vaadin-combo-box https://github.com/vaadin/vaadin-combo-box/issues/233

It works now with dependency :
"vaadin-combo-box": "^1.0.0-beta2"

This should now be fixed with the rc3 version of combo-box.


Prediction operator outputs String type, not original target type

Here the prediction column's value is integer, and it is integer during the model training. But the prediction operator's output is string, not integer

@yunyad is this fixed?


Can't change scan location

Hi everybody,
I installed PokemonGo on my PC (windows). Everything OK (i had to put javascript API on cause I had problems), but now I cannot change location by typing a new address, except thanks to the first menu, but close the app to change the address is very boring.
Need ur help plz

Can you drag the marker?

yes, I didn't know this trick ! Thks

Close this issue then.

Not possible to fix the problem despite everything ? Not easy to use for far away cities from me

ahah funny, I appreciate :)
But no, when I write something, nothing change, even if i press enter ...
I can only move the marker

I had the same issue happening. After waiting a few hours, it was working again. I'm not sure what fixed it.


🐞 [Bug]: Deployments number are not correct

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
The node 29 on Qanet shows that no workload or deployment is Zero, while the graphql shows the 2 contracts are deployed there!
Steps To Reproduce
No response
which network/s did you face the problem on?
QA
version
2.4.3
Twin ID/s
No response
Node ID/s
29
Farm ID/s
180
Contract ID/s
29280, 29282
Relevant screenshots/screen records

Relevant log output
.

@A-Harby I tried running the same query on graphql but couldn't find any active deployments on the node.

Can you verify if the issue still exists?

It doesn't show the contract anymore for some reason; it will close and reopen if it reoccur.


Made ReadProfilingKey method public and more generic

Related to work on https://github.com/knative/eventing/issues/2148

/assign mgencur

/lgtm

/lgtm
/approve

@vagababov does it looks good now?

/approve
/lgtm
Might need someone else to approve

/assign @mattmoor


Fix many-to-one relationships

This fixes the issue that many-to-one relationships couldn't be loaded and saved via the API (or through the GUI).
Fixes #96

@emilpaw, thanks for your contribution


Upgrade Profittrailer version

Hi Christoph, thanks for the updated docker file. As i am a newby on Docker and Synology, i don't have a clue how to update the docker container via Synology. Can you give me a brief instruction to update form version 2.5.2 to 2.5.6? Thanks in advance, Jeroen

@ofheroes The docker file is just the start. I hoped that @canecasama will publish a new image version to docker hub.

New docker version was published yesterday


Disclosure Component

Create a headless disclosure component and add a styled variant CollapsibleCard resembling the Card component.

Will implement a collapsible component and a refactored card component.


Separation of component identification and classification

Component identification should guarantee identifier uniqueness, but it should be also simple in order to be user friendly.
Classification could cover variable depth of additional categories in order to provide better navigation in available packs/components.

Could I suggest to follow that discussion with #23 ?

can this be closed


adds script to clone all repos

Signed-off-by: Josh Zarrabi<EMAIL_ADDRESS>

This seems to clone all the repos into a single workspace directory.
./workspace
├── bundler
├── conda
├── dep
├── dep-ensure
...

Instead, can we have this group the repos by org?
./workspace
├── paketo-buildpacks
│   ├── dep
│   └── dep-ensure
└── paketo-community
    ├── bundler
    └── conda
...


Fix DEPLOY page on mobile

Edits to the mobile responsiveness of the Deploy page. See attached screenshots and notes below each.

Reduce "Your Benefits" text/graphic by 30%-50% so that it matches the title text size for rest of the section titles
Increase title size to be larger than the text below it
Remove space between rows to make equal

Increase title size and text below it about 1.5x
Decrease icon sizes 50%
Add line space between "Exploration Mode" and the regular text that should go underneath

Decrease graphic size by 50%

Add line space after each column so that spacing is even — should be more 2 lines between last link in each column and the start of the next column

Decrease table size to fit the screen (doesn't need to scroll left-right)
Fix font sizes so that the table fits and is readable

Change line space for the text under the title Planet Friendly to 1x
Increase the size of the graphic to be readable on mobile

Remove extra spacing between sections

Remove extra spacing above "Your Benefits"
Decrease font size / graphic image by 30-50% to match title text sizes

Reduce image size by 50%

Increase header image size to fill the header space
Add white header bar so that ThreeFold logo is visible (like on desktop)
Increase title text size "Own 100% of your deployments...." so that it's larger than the text underneath it

over all fixed expect :
Decrease icon sizes 50% at DECENTRALIZE YOUR APPLICATION section it affect at border and not centered may be check it later
table cant fit at all image to responsive with all size  so I made sliding and small size ll not readable

Okay, thanks Ehab — for the icon sizes at Decentralize Your Application are you able to reduce at all? They should be centered and about 30-50% smaller.
For the table, just remove the row that shows "168" several times in boxes. Should also be removed from desktop version.
Additionally, in that same section please make the "Apply Now" button the same length as the App Store and Google Play buttons for consistency. The rest of it I think looks pretty good for this sprint!


problem of getting the length of the firebase array

In the abilitytest.js, I get an array of the quiz by using this line:
$scope.quiz = []
$scope.quiz = $firebaseArray(firebase.database().ref("quiz/java"));
it can help me to get the array and there is no problem.
However, if I create a variable like:
var aaa = $scope.quiz.length
this variable will be 0
But, if I directly show the length in the html like:
{{quiz.length}}
it can output the length of the array

It may be caused due to the asynchronous processing of firebase. When you run $scope.quiz = $firebaseArray(firebase.database().ref("quiz/java")); , you send a request to get the data from firebase. Then the program immediately go to the next line without waiting the arrival of the data. Therefore you can length 0


Datasets.datafiles resolve_pattern TypeError: can only concatenate tuple (not "str") to tuple

Describe the bug
in data_files.py, line 332,
fs,  _, _ = get_fs_token_paths(pattern, storage_options=storage_options)
If we run the code on AWS, as fs.protocol will be a tuple like: ('file', 'local')
So,  isinstance(fs.protocol, str) == False and
protocol_prefix = fs.protocol + "://" if fs.protocol != "file" else "" will raise
TypeError: can only concatenate tuple (not "str") to tuple.
Steps to reproduce the bug
Steps to reproduce:

Run on a cloud server like AWS,
import datasets.data_files as datafile
datafile.resolve_pattern('path/to/dataset', '.')
TypeError: can only concatenate tuple (not "str") to tuple

Expected behavior
Should return path of the dataset, with fs.protocol at the beginning
Environment info

datasets version: 2.14.0
Platform: Linux-3.10.0-1160.119.1.el7.x86_64-x86_64-with-glibc2.17
Python version: 3.8.19
Huggingface_hub version: 0.23.5
PyArrow version: 16.1.0
Pandas version: 1.1.5

Hi,
This issue was fixed in datasets 2.15.0:

#6105

You will need to update your datasets:
pip install -U datasets

Duplicate of:

#6100


adapter static+endpoint / adapter static + refresh page

Describe the bug
after last npm update after run build everythink is ok on npm run preview but if if deploy my site on hosting and refresh any not main page i got 403/404
also i need POST method on my form with endpoint and after run build on run preview its ok, but after deploy i got 404 on my index.json.js, index.js, api/, api/index.json etc have no idea what to do help pls
Reproduction
npm init svelte@next my-app // select test app
cd my-app
npm install
npm run dev -- --open
npm i @sveltejs/adapter-static
change adapter on svelteconfig
npm run build
npm run preview - everythink is ok
deploy on host - cant refresh pages and not todo app
Logs
No response
System Info
any, any, any

Severity
blocking all usage of SvelteKit
Additional Information
No response

npm i -D @sveltejs/adapter-static@next maybe to get the latest version of the static adapter ?

the same problem. when the page is reloaded, it gives 404

We're seeing this with the next-29 static adapter and '@sveltejs/kit': 1.0.0-next.294_sass<EMAIL_ADDRESS>deploying onto Cloudflare pages. pnpm run preview after build works absolutely fine, but when deployed to CF, we get consistent 404's. I don't see any root level index page inside the build folder when running builds locally.

@Maxim-and-Ko, @dulyas current build locally outputs
> Using @sveltejs/adapter-static
  You should set `config.kit.prerender.default` to `true` if no fallback is specified
  Wrote site to "build"

adding default: true to the svelte.config.js file does fix this issue
kit: {
    // hydrate the <div id="svelte"> element in src/app.html
    adapter: adapter(),
    prerender: {
      crawl: true,
      enabled: true,
      onError: 'continue',
      default: true
    },

You may want to try setting trailingSlash: 'always'

@benmccann tried that first and had the same 404 result, did that change recently?

The trailingSlash thing was a separate change that happened a couple of weeks ago (prior to that, prerendering would always generate page/index.html files instead of page.html files, but that means that the majority of static hosts would redirect /page to /page/, so the new behaviour ensures that your URLs are consistent between dev and deploy).
@dulyas you can't use adapter-static if your endpoints have post handlers`. We probably need to make that clearer at build time via an error.

Вы можете попробовать установитьtrailingSlash: 'always', если это то же самое, что и #3852

okay, it worked. And what to do with [slug] pages? Now dynamic pages don't open

You may want to try setting trailingSlash: 'always' in case this is the same as #3852

okay, it worked. And what to do with [slug] pages?

I don't know what it is you're facing @Maxim-and-Ko but you will need to open a separate issue with a reproduction if you want to get help — please don't hijack other people's issues. I would assume that /news/66 isn't being prerendered because the content isn't available at build time, in which case adapter-static is the wrong thing to use. If the content is available at build time then you need to ensure that either a) the crawler can find a link to it, or b) you specify it in config.kit.prerender.entries.

Right, the behaviour changed. That's why you saw this message:

You should set config.kit.prerender.default to true if no fallback is specified

yeah I just tried again with a fresh app and see the messaging now. Thanks @Rich-Harris 👍


updated copyrights

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/56707


Cosmetic edits

@hammertoe these are just some suggested edits on my part, hopefully this is useful

@hammertoe for some reason I can't add you as a reviewer to this


Updates to the inferface header file to fix typo errors

Also includes minor changes from auto-formatting to cleanup the code a little based on my local clang-format config.

I can share that format file as a separate PR if you would like as I have used it on all the EOSDAC contracts code but as a warning it does re-format quite a lot.

All the files within the contract are already formatted, but I have to admit it was a bit sloppy.
I wasn't aware of the AlignConsecutiveAssignments option in clang format until just now, which is why I didn't auto format tables. This required a bit of manual tweaking before formatting the code, and while testing this, I probably also replaced "TABLE" with "struct", which caused the typos ("immuTABLE_data").
I have now exported two different clang format files and also pushed them, one of which is used for the atomicassets.hpp and atomicassets-interface.hpp, and the other one which is used for the atomicassets.cpp, atomicdata.hpp, and checkformat.hpp.
So now that everything is properly formatted without any manual changes, it should hopefully be more consistent, and you will also be able to use the clang format files so that your future commits don't change dozens of lines in minor formatting.
 The interface is meant to be a single file header that people can use for their contracts, therefore you can't include any other files.
Thanks for the PR, it nudged me to take the formatting a little more seriously and we now hopefully have a relatively solid framework to work with. Also, it's good that the typos are fixed now :+1:


fix task tooltip in svg visualizer

Firstly I create patch to fix tooltip in dependency visualizer.
After fix tooltip looked like the following screenshot:

As you can see it expose sensitive information.
My TestTask:
# -*- coding: utf-8 -*-
import time
import luigi

class TestTask(luigi.Task):
    user = luigi.Parameter()
    password = luigi.Parameter(significant=False)
    def run(self):
        while True:
            time.sleep(4)

After that I decided to fix leak of significant=False parameters.
Final version of tooltip looks like:

By the way there is security issue.
RCPHandler expose significant=False paramerers.
Sample API response:
{"response": {"TestTask(user=e.iskandarov)": {"status": "RUNNING", "priority": 0, "params": {"password": "olololo", "user": "e.iskandarov"}, "name": "TestTask", "time_running":<PHONE_NUMBER>.611656, "worker_running": "Worker(salt=126792928, workers=1, host=eiskandarov.local, username=e.iskandarov, pid=51670)", "workers": ["Worker(salt=126792928, workers=1, host=eiskandarov.local, username=e.iskandarov, pid=51670)"], "start_time":<PHONE_NUMBER>.606572, "resources": {}}}}

As you can see password is present in response.

LGTM. Does anyone who knows the frontend code want to review? @erikbern @stephenpascoe @daveFNbuck

@toidi, it would still be nice to have the priority listed I think. No?

Priority do no display in d3 visualization type

But worker do.
I tried to mirror behavior, but there is no worker information on graph context :(.

Works for me.


treyBake: Watch<PHONE_NUMBER>

treyBake requests the watch of the watch_keyword<PHONE_NUMBER>. See the MS search here and the Stack Exchange search here.

(718) 571-8689 has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected in favor of equivalent !!/watch-number


Tests for educator

Create the unit tests for the main features of the educator user. Also, check that all the validations are correct, and the user can write where is supposed to write, and cannot where is not.

Story Points: 5
See the discussion in Backend S3
Powered by Parabol


Wrong in language pack for Swedish (SE)

When running the vCenter script with Swedish language, the script throws errors through the whole script:
PS C:\Script\vCheck2> .\vCheck.ps1
WARNING:
Begin Plugin körs
[08:30:10] ..startar beräkning Connection settings for vCenter av Alan Renouf v1.20 [1 av 12]
Error formatting a string: Input string was not in a correct format..
At C:\Script\vCheck2\vCheck.ps1:894 char:3
+         $pluginStatus = ($lang.pluginStatus -f $p, $vCheckPlugins.cou ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: ([{0} av {1}} {2}:String) [], RuntimeException
    + FullyQualifiedErrorId : FormatError

Write-Progress : Cannot validate argument on parameter 'Status'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
At C:\Script\vCheck2\vCheck.ps1:895 char:63
+ ... ss -ID 1 -Activity $lang.pluginActivity -Status $pluginStatus -Percen ...
+                                                     ~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Write-Progress], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.PowerShell.Commands.WriteProgressCommand

PS `C:\Script\vCheck2>`

This error does not occur when choosing English language. The error seems to be some mistakes in brackets and accents in line 21 and 23 in file Lang/sv-SE/vcheck.psd1.
Line 21, col 30 has an ' (should be `)
Line 23 col 32 has an } (should be ])

Verified with another working language file for en-US

As nothing seems to happend with my pull request, I choose to close this issue. Im really sorry, I only wanted to helop out with this project. To bad.


Received fatal alert: handshake_failure after changing MySQL RDS instance CA to rds-ca-rsa4096-g1

Description
After changing RDS Instance Certificate authority from "rds-ca-2019" to "rds-ca-rsa4096-g1"
Getting error on existing MySQL RDS connection which worked before:
Communications link failure

The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
  Received fatal alert: handshake_failure

Connection SSL settings:

DBeaver Version
Community Edition Version <IP_ADDRESS>309260508
Operating System
Windows 10 64 bit
Database and driver
MySQL 8.0.34
Steps to reproduce

Create successfull connection to RDS MySQL instance v8.0.34 with Certificate authority "rds-ca-2019" using mentioned SSL settings. (pem file was downloaded from here)
Change RDS Instance Certificate authority to "rds-ca-rsa4096-g1"
Test connection again

Additional context
No response

Only relevant recent entry from .log:
!ENTRY org.jkiss.dbeaver.model 4 0 2023-09-28 16:33:55.440
!MESSAGE Received fatal alert: handshake_failure
!STACK 0
javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.dispatch(Unknown Source)
	at java.base/sun.security.ssl.SSLTransport.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at com.mysql.cj.protocol.ExportControlled.performTlsHandshake(ExportControlled.java:347)
	at com.mysql.cj.protocol.StandardSocketFactory.performTlsHandshake(StandardSocketFactory.java:191)
	at com.mysql.cj.protocol.a.NativeSocketConnection.performTlsHandshake(NativeSocketConnection.java:101)
	at com.mysql.cj.protocol.a.NativeProtocol.negotiateSSLConnection(NativeProtocol.java:369)
	at com.mysql.cj.protocol.a.NativeAuthenticationProvider.connect(NativeAuthenticationProvider.java:205)
	at com.mysql.cj.protocol.a.NativeProtocol.connect(NativeProtocol.java:1433)
	at com.mysql.cj.NativeSession.connect(NativeSession.java:133)
	at com.mysql.cj.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:948)
	at com.mysql.cj.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:818)
	at com.mysql.cj.jdbc.ConnectionImpl.<init>(ConnectionImpl.java:448)
	at com.mysql.cj.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:241)
	at com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:198)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.lambda$1(JDBCDataSource.java:237)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.lambda$0(JDBCDataSource.java:250)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.openConnection(JDBCDataSource.java:269)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.openConnection(MySQLDataSource.java:456)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCExecutionContext.connect(JDBCExecutionContext.java:103)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCRemoteInstance.initializeMainContext(JDBCRemoteInstance.java:102)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCRemoteInstance.<init>(JDBCRemoteInstance.java:61)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.initializeRemoteInstance(JDBCDataSource.java:123)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.<init>(JDBCDataSource.java:107)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.<init>(JDBCDataSource.java:98)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.<init>(MySQLDataSource.java:98)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.<init>(MySQLDataSource.java:93)
	at org.jkiss.dbeaver.ext.mysql.MySQLDataSourceProvider.openDataSource(MySQLDataSourceProvider.java:151)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.openDataSource(DataSourceDescriptor.java:1278)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.connect0(DataSourceDescriptor.java:1117)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.connect(DataSourceDescriptor.java:950)
	at org.jkiss.dbeaver.runtime.jobs.ConnectJob.run(ConnectJob.java:77)
	at org.jkiss.dbeaver.runtime.jobs.ConnectionTestJob.run(ConnectionTestJob.java:103)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Could you please add this flag: -Djavax.net.debug=all to your Dbeaver .ini file and provide the full logs? Maybe we can find a reason in a full-log version.

This is the latest log entry with -Djavax.net.debug=all:
!SESSION 2023-10-10 16:34:01.582 -----------------------------------------------
eclipse.buildId=unknown
java.version=17.0.6
java.vendor=Eclipse Adoptium
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Framework arguments:  -eclipse.keyring C:\Users\Yoni_Sade\AppData\Roaming\DBeaverData\secure\secure_storage
Command-line arguments:  -os win32 -ws win32 -arch x86_64

!ENTRY org.eclipse.ui 2 2 2023-10-10 16:34:08.242
!MESSAGE Invalid preference category path: org.eclipse.debug.ui.ConsolePreferencePage (bundle: org.eclipse.ui.console, page: org.eclipse.ui.internal.console.ansi.preferences.AnsiConsolePreferencePage)

!ENTRY org.eclipse.jface 2 0 2023-10-10 16:34:12.485
!MESSAGE Keybinding conflicts occurred.  They may interfere with normal accelerator operation.
!SUBENTRY 1 org.eclipse.jface 2 0 2023-10-10 16:34:12.486
!MESSAGE A conflict occurred for CTRL+J:
Binding(CTRL+J,
	ParameterizedCommand(Command(org.eclipse.ui.edit.findIncremental,Incremental Find,
		Incremental find,
		Category(org.eclipse.ui.category.edit,Edit,null,true),
		WorkbenchHandlerServiceHandler("org.eclipse.ui.edit.findIncremental"),
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.textEditorScope,,,system)
Binding(CTRL+J,
	ParameterizedCommand(Command(org.jkiss.dbeaver.core.resultset.grid.gotoColumn,Go To Column,
		Jump to a specified column,
		Category(org.jkiss.dbeaver.core.rs,Result Set,Result Set Commands,true),
		WorkbenchHandlerServiceHandler("org.jkiss.dbeaver.core.resultset.grid.gotoColumn"),
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.jkiss.dbeaver.ui.context.resultset,,,system)

!ENTRY org.jkiss.dbeaver.model 4 0 2023-10-10 16:34:24.354
!MESSAGE Received fatal alert: handshake_failure
!STACK 0
javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.dispatch(Unknown Source)
	at java.base/sun.security.ssl.SSLTransport.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at com.mysql.cj.protocol.ExportControlled.performTlsHandshake(ExportControlled.java:347)
	at com.mysql.cj.protocol.StandardSocketFactory.performTlsHandshake(StandardSocketFactory.java:191)
	at com.mysql.cj.protocol.a.NativeSocketConnection.performTlsHandshake(NativeSocketConnection.java:101)
	at com.mysql.cj.protocol.a.NativeProtocol.negotiateSSLConnection(NativeProtocol.java:369)
	at com.mysql.cj.protocol.a.NativeAuthenticationProvider.connect(NativeAuthenticationProvider.java:205)
	at com.mysql.cj.protocol.a.NativeProtocol.connect(NativeProtocol.java:1433)
	at com.mysql.cj.NativeSession.connect(NativeSession.java:133)
	at com.mysql.cj.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:948)
	at com.mysql.cj.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:818)
	at com.mysql.cj.jdbc.ConnectionImpl.<init>(ConnectionImpl.java:448)
	at com.mysql.cj.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:241)
	at com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:198)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.lambda$1(JDBCDataSource.java:246)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.lambda$0(JDBCDataSource.java:259)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.openConnection(JDBCDataSource.java:278)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.openConnection(MySQLDataSource.java:456)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCExecutionContext.connect(JDBCExecutionContext.java:103)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCRemoteInstance.initializeMainContext(JDBCRemoteInstance.java:102)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCRemoteInstance.<init>(JDBCRemoteInstance.java:61)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.initializeRemoteInstance(JDBCDataSource.java:123)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.<init>(JDBCDataSource.java:107)
	at org.jkiss.dbeaver.model.impl.jdbc.JDBCDataSource.<init>(JDBCDataSource.java:98)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.<init>(MySQLDataSource.java:98)
	at org.jkiss.dbeaver.ext.mysql.model.MySQLDataSource.<init>(MySQLDataSource.java:93)
	at org.jkiss.dbeaver.ext.mysql.MySQLDataSourceProvider.openDataSource(MySQLDataSourceProvider.java:151)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.openDataSource(DataSourceDescriptor.java:1280)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.connect0(DataSourceDescriptor.java:1117)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.connect(DataSourceDescriptor.java:950)
	at org.jkiss.dbeaver.runtime.jobs.ConnectJob.run(ConnectJob.java:77)
	at org.jkiss.dbeaver.runtime.jobs.ConnectionTestJob.run(ConnectionTestJob.java:103)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

@yoni-yad2 Could you try to connect without verify server certificate?

Tried that.
Same error.

diegoy
I already fixed problem by following his answer. Thanks a lot

Hello,
I got the same Received fatal alert: handshake_failure error when using SSH Tunnel, but everything is ok with pgAdmin and the same connection settings.
Here is the error log:
javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.dispatch(Unknown Source)
	at java.base/sun.security.ssl.SSLTransport.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown Source)
	at org.postgresql.ssl.MakeSSL.convert(MakeSSL.java:41)
	at org.postgresql.core.v3.ConnectionFactoryImpl.enableSSL(ConnectionFactoryImpl.java:620)
	at org.postgresql.core.v3.ConnectionFactoryImpl.tryConnect(ConnectionFactoryImpl.java:191)
	at org.postgresql.core.v3.ConnectionFactoryImpl.openConnectionImpl(ConnectionFactoryImpl.java:258)
	at org.postgresql.core.ConnectionFactory.openConnection(ConnectionFactory.java:54)
	at org.postgresql.jdbc.PgConnection.<init>(PgConnection.java:253)
	at org.postgresql.Driver.makeConnection(Driver.java:434)
	at org.postgresql.Driver.access$100(Driver.java:61)
	at org.postgresql.Driver$ConnectThread.run(Driver.java:344)
	at java.base/java.lang.Thread.run(Unknown Source)

Can't reproduce on Postgre and MySQL instance with mentioned certificate authority

I've just ran into the same issue with multiple RDS MySQL instances using the CA rds-ca-ecc384-g1 (RDS MySQL 8.0.33).
I got some debug logs with -Djavax.net.debug=all in dbeaver-debug.log, here's a redacted version:
2023-12-21 1600 dbeaver-debug.log
I'm not fully versed in TLS negotiation let alone its Java implementation, but it seems to fail after reading just a few bytes from a "TLSv1.2 alert" reply just after sending its client handshake.
Could that be RDS explicitly rejecting the client because of a missing cipher/signature algorithms compatible with that kind of CA? (rds-ca-ecc384-g1 = certificate authority with ECC 384 private key algorithm and SHA384 signing algorithm)
Strangely, the same DBeaver connects just fine to Aurora MySQL instances with the same CA (8.0.mysql_aurora.3.02.0).
(DBeaver 23.3.0, Java Corretto 21 – had the same error on Java 11)

This sent me into a wild goose chase, but I eventually found my issue: for some reason, my DBeaver connections had enabledTLSProtocols set to TLSv1,TLSv1.1,TLSv1.2.
(Setting in the connection configuration → sidebar Connection Settings → tab Driver Properties → appeared in User Properties at the bottom for me).
As soon as I added 1.3 (recommendation: TLSv1.2,TLSv1.3), DBeaver succeeded to connect! ✅
I have no idea where my enabledTLSProtocols came from, I seem to have it on all my current connections. Default?
Hypothesis

RDS MySQL with the CA rds-ca-ecc384-g1 allows applicable ciphers only on TLS 1.3
(at least in the default ciphers in Java 21).

OP @yoni-yad2: it's been a while but if you still have the issue, maybe enabling 1.3 will work with the rds-ca-rsa4096-g1 CA?

Aurora MySQL with the same CA does accept TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 on TLS v1.2.

May be worth reporting this to AWS if we can confirm these; that's a somewhat confusing situation.

Troubleshooting notes that led me there:
re previous message: for comparison, I'm seeing the same ClientHello (different host & random) sent to those Auroras on the same CA, but the response is the expected handshake.
The Aurora ServerHello indicates it picks "cipher suite" : "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384(0xC02C)", which is advertised in both ClientHellos.
My problem may be different from OP – I've found a number of application issues with the ECC CA (examples: 1, 2, 3 ) that were allegedly fixed with the RSA one that OP is already using.
I searched some more, also puzzled about the logs stating Ignore unsupported cipher suite: TLS_AES_256_GCM_SHA384 for TLSv1.2, which means they're not supported on 1.2, likely only 1.3. Seems unrelated, if that ECDHE one above works for Aurora?
Out of ideas, I've troubleshooted a dummy Java application, and its handshake to MySQL succeeded with TLS_AES_256_GCM_SHA384… …on TLS 1.3.
When running DBeaver, I'm only seeing 1.2 in the ClientHello:
    "supported_versions (43)": {
      "versions": [TLSv1.2]
    },

A dummy Java 11 app advertises both 1.2 and 1.3.
And hindsight being 20/20, that dummy app used the cipher exactly matching that unsupported cipher ... for TLSv1.2 Java log from DBeaver… the rest is summarized at the top of this message.


Add properties to CharacterBody for more move_and_slide options

Implementation of the proposal 2982 that aim to fix and add more options to move and slide in 2D, see the proposal for details.
I made the following project https://github.com/fabriceci/move_and_slide_4.0 to test this PR easily.

Here are the tests I've made so far:

Test on ground and platforms
(from https://github.com/fabriceci/move_and_slide_4.0)

No regression spotted, everything seems to work well.

Test on curved floor
snapping_testing-4.0.zip
(converted MRP from #31097)

No regression.
Constant speed works well.
Possible issue: When setting motion on floor only (default move_max_angle) the character is able to climb a little bit on the curve at the 45 degree limit, and slide back a little bit, instead of just being stopped.
It's not a regression since it only affects the new settings, so not a requirement for this PR, but eventually it would be nice for curves to be handled with no glitch.

Test with basic sliding
using_kinematic2d-4.0.zip

Constant speed works well.
Possible regression: When setting move_max_angle to 180 degrees, the character is not able to climb the steeper slope anymore when moving right. It jitters on the edge instead. I would expect that it would work the same as before this PR in this case (the character was able to move on walls when their angle is low enough, and slide back when standing).

Before
With this PR

Test with low-res platformer game
simple--heart-platformer-master-4.0.zip
(partially converted MRP from #45259, I had to redo a tilemap and the pixelated low-res settings don't work well in 4.0)

No regression.
Next I'm going to convert physics tests from https://github.com/godotengine/godot-demo-projects/tree/master/2d/physics_tests to 4.0 in order to do the last remaining regression tests.

Possible issue: When setting motion on floor only (default move_max_angle) the character is able to climb a little bit on the curve at the 45 degree limit, and slide back a little bit, instead of just being stopped.
It's not a regression since it only affects the new settings, so not a requirement for this PR, but eventually it would be nice for curves to be handled with no glitch.

I struggled a lot on this. Note: there was a small problem in the test project you used, the gravity was not applied on the ground which causes issues.
For fix the bug, I had to use an arbitrary value (see https://github.com/godotengine/godot/pull/51027/files#diff-384d90fd698f09946049d099866faadfbb0ae0b1a0bed68296d7f5be45806b4eR1158), I don't see another way to handle that, this value should maybe be tuned in the future.

Thanks!


Add reference for dapr bot

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[X] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Adds a list of commands and labels supported by the dapr bot across dapr and contrib repo.
Issue reference
Please reference the issue this PR will close: #2979

/assign

@greenie-msft added the requested changes, thanks!

@hhunter-ms thank you! 🙂


Leading swipe actions

Note
This is targeting the robmaceachern/feature/swipe-action-updates feature branch.

This adds the ability to configure leading swipe actions to a cell.

Add the ability to configure leading swipe actions on Items.
Renamed Item.swipeActions to Item.leadingSwipeActions.
Renamed DefaultItemProperties.swipeActions to leadingSwipeActions.

Discussion
I was able to mostly plug into the existing swipe action configuration with some tweaks depending on which side the actions are presented from. Most SwipeActionState cases have been augmented with a Side associated value in order to keep track of the state of the swipe actions and we essentially filter for "relevant" states when updating the individual swipe action views.
This will probably be fairly challenging in terms of code review so thanks in advance for taking a look (I suggest you use the split diff). I would also really appreciate if someone would boot up the demo in the simulator or device to see what I've broken.
Demo
https://user-images.githubusercontent.com/430436/233661437-9c677dc9-dd31-40a7-930b-2acb0591c890.mov
Checklist
Please do the following before merging:

[x] Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

One thing I would test / add to the demo, is to ensure that cell recycling is working properly.

I've added a control in the demo that configures some rows without swipe actions (and some labels to view the config) and it all seems to be working properly in my testing.


Fluentbit connection refused

Describe the bug:
Fluentbit is not able to reach fluentd with default setup.
Logs from fluentbit pod:
2020-09-10T06:27:54.268412432Z Fluent Bit v1.5.4
2020-09-10T06:27:54.268449044Z * Copyright (C) 2019-2020 The Fluent Bit Authors
2020-09-10T06:27:54.268454259Z * Copyright (C) 2015-2018 Treasure Data
2020-09-10T06:27:54.268457953Z * Fluent Bit is a CNCF sub-project under the umbrella of Fluentd
2020-09-10T06:27:54.268461045Z * https://fluentbit.io
2020-09-10T06:27:54.268464262Z
2020-09-10T06:27:54.269581428Z [2020/09/10 06:27:54] [ info] [engine] started (pid=1)
2020-09-10T06:27:54.269592699Z [2020/09/10 06:27:54] [ info] [storage] version=1.0.5, initializing...
2020-09-10T06:27:54.269596303Z [2020/09/10 06:27:54] [ info] [storage] root path '/buffers'
2020-09-10T06:27:54.269599543Z [2020/09/10 06:27:54] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
2020-09-10T06:27:54.269602531Z [2020/09/10 06:27:54] [ info] [storage] backlog input plugin: storage_backlog.1
2020-09-10T06:27:54.40060536Z [2020/09/10 06:27:54] [ info] [input:storage_backlog:storage_backlog.1] queue memory limit: 4.8M
2020-09-10T06:27:54.400633782Z [2020/09/10 06:27:54] [ info] [filter:kubernetes:kubernetes.0] https=1 host=kubernetes.default.svc port=443
2020-09-10T06:27:54.400863924Z [2020/09/10 06:27:54] [ info] [filter:kubernetes:kubernetes.0] local POD info OK
2020-09-10T06:27:54.400877016Z [2020/09/10 06:27:54] [ info] [filter:kubernetes:kubernetes.0] testing connectivity with API server...
2020-09-10T06:27:54.42508188Z [2020/09/10 06:27:54] [ info] [filter:kubernetes:kubernetes.0] API server connectivity OK
2020-09-10T06:27:54.425135276Z [2020/09/10 06:27:54] [ info] [sp] stream processor started
2020-09-10T06:27:54.849997936Z [2020/09/10 06:27:54] [ info] inotify_fs_add(): inode=1316674 watch_fd=1 name=/var/log/containers/covergo-concierge-6857685ddb-lfvxn_default_covergo-concierge-c98cf90ab9de116de7a902cf9e701e50a82d4c71c7a152067bc5678ff312fe2c.log
2020-09-10T06:27:56.341047276Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1521344 watch_fd=2 name=/var/log/containers/prometheus-operator-grafana-c7689fcdf-hbwct_monitoring_init-chown-data-5140170d9cbc0a7bf8d8989e35fda734ae115084f58e6310ebbdc1205d963840.log
2020-09-10T06:27:56.444422117Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1209419 watch_fd=3 name=/var/log/containers/alertmanager-prometheus-operator-alertmanager-0_monitoring_alertmanager-44fcce19a1e40f554fdc01fc6ac17b544d8194eaad2d1e6fe11e143e9a02685e.log
2020-09-10T06:27:56.444448735Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1210044 watch_fd=4 name=/var/log/containers/alertmanager-prometheus-operator-alertmanager-0_monitoring_config-reloader-8d64b51f7f195835aeb37200265dfb56b5859862d505341941a04e0dbe5ac536.log
2020-09-10T06:27:56.444453226Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1259780 watch_fd=5 name=/var/log/containers/cert-manager-webhook-gandi-585f67dc4f-p987d_cert-manager_cert-manager-webhook-gandi-66be78e19276322b3bec069ad451bd5fba781091dcd7763c9a094969872e6363.log
2020-09-10T06:27:56.444457116Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1316794 watch_fd=6 name=/var/log/containers/cert-manager-webhook-gandi-585f67dc4f-p987d_cert-manager_cert-manager-webhook-gandi-b44fcd5a40c2b972fde2f1f1f5a92156dc85addfc6fd282dbe9e1b8e73b49041.log
2020-09-10T06:27:56.453071895Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1251499 watch_fd=7 name=/var/log/containers/covergo-apiwebsite-7f78844b8f-w8x6s_default_covergo-apiwebsite-0286a379ebdbdd7a6435776d5b654f202fbb6d65532cbc158ebcc0bed6fbe907.log
2020-09-10T06:27:56.460085367Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1316460 watch_fd=8 name=/var/log/containers/covergo-commissions-55b996669c-9rflc_default_covergo-commissions-5c2a800eb6ab5f5678bc355d14ba7432c88ecc1c8597441f56f1ed59d24b137a.log
2020-09-10T06:27:56.460102378Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1260194 watch_fd=9 name=/var/log/containers/covergo-commissions-55b996669c-9rflc_default_covergo-commissions-8e54bd8fbf6ca062b7d5102bad3ec0627a2339be74510508c63ac9b7c3dea85f.log
2020-09-10T06:27:56.470808035Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1316323 watch_fd=10 name=/var/log/containers/covergo-jetco-asia-7cd649567-cr9zv_default_covergo-jetco-asia-3db3c6154683c95b9d751b5dfeb499555671923c840f355809cb2eb8e51d3b10.log
2020-09-10T06:27:56.470824096Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=410285 watch_fd=11 name=/var/log/containers/covergo-jetco-asia-7cd649567-cr9zv_default_covergo-jetco-asia-8fd0963490b4ad3f858fc2d8fc04aa6d71d7a479afd2a86ab9405ef8f58fdf79.log
2020-09-10T06:27:56.47600301Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1069727 watch_fd=12 name=/var/log/containers/covergo-jetco-asia-uat-755dbd58b4-xdhnv_default_covergo-jetco-asia-uat-f5a60dab37fa67394a25941927bfca0e08824a5068a02507c5e036d7925e2d08.log
2020-09-10T06:27:56.476018983Z [2020/09/10 06:27:56] [ info] inotify_fs_add(): inode=1995624 watch_fd=13 name=/var/log/containers/covergo-logging-bd8bdcddd-b6bx6_default_covergo-logging-1-40ae0a9ca27a097a002fedbc3190e141982755e3f053cc78d6ac0198a64ef52f.log
2020-09-10T06:27:56.546883415Z [2020/09/10 06:27:56] [ warn] [input] tail.0 paused (mem buf overlimit)
2020-09-10T06:27:57.553905995Z [2020/09/10 06:27:57] [error] [src/flb_io.c:171 errno=111] Connection refused
2020-09-10T06:27:57.553944176Z [2020/09/10 06:27:57] [error] [io] connection #80 failed to: covergo-fluentd.logging.svc:24240
2020-09-10T06:27:57.553948584Z [2020/09/10 06:27:57] [error] [output:forward:forward.0] no upstream connections available
2020-09-10T06:27:58.557856778Z [2020/09/10 06:27:58] [error] [src/flb_io.c:171 errno=111] Connection refused
2020-09-10T06:27:58.557893674Z [2020/09/10 06:27:58] [error] [io] connection #80 failed to: covergo-fluentd.logging.svc:24240
2020-09-10T06:27:58.557906244Z [2020/09/10 06:27:58] [error] [output:forward:forward.0] no upstream connections available
2020-09-10T06:27:59.562471605Z [2020/09/10 06:27:59] [error] [src/flb_io.c:171 errno=111] Connection refused
2020-09-10T06:27:59.562498966Z [2020/09/10 06:27:59] [error] [io] connection #80 failed to: covergo-fluentd.logging.svc:24240
2020-09-10T06:27:59.562503855Z [2020/09/10 06:27:59] [error] [output:forward:forward.0] no upstream connections available
2020-09-10T06:28:00.565826848Z [2020/09/10 06:28:00] [error] [src/flb_io.c:171 errno=111] Connection refused
2020-09-10T06:28:00.565860127Z [2020/09/10 06:28:00] [error] [io] connection #80 failed to: covergo-fluentd.logging.svc:24240
2020-09-10T06:28:00.56588899Z [2020/09/10 06:28:00] [error] [output:forward:forward.0] no upstream connections available

Expected behaviour:
Steps to reproduce the bug:
Using those manifests after installing the operator:
apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: logging-operator
spec:
  fluentd:
    scaling:
      replicas: 1
    bufferStorageVolume:
      pvc:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 20Gi
          storageClassName: alicloud-disk-ssd
  fluentbit:
    filterKubernetes:
      tls.verify: "Off"
  controlNamespace: logging
---
apiVersion: logging.banzaicloud.io/v1beta1
kind: ClusterOutput
metadata:
  name: loki-sink
spec:
  loki:
    url: http://loki:3100
    configure_kubernetes_labels: true
    buffer:
      timekey: 1m
      timekey_wait: 30s
      timekey_use_utc: true
---
apiVersion: logging.banzaicloud.io/v1beta1
kind: ClusterFlow
metadata:
  name: loki-apps
spec:
  outputRefs:
    - loki-sink
  match:
    - select:
        namespaces:
          - default

Environment details:

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-26T20:32:49Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.9-aliyun.1", GitCommit:"4f7ea78", GitTreeState:"", BuildDate:"2020-05-08T07:29:59Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Cloud-provider/provisioner: Alicloud
logging-operator version: latest

/kind bug

Can you please confirm the error if you are not using Loki output?

I'm having a similar kind of issue.
I'm using a cloudwatch output. Logs works great at first when deployed, but at some point fluentbit is complaining about no upstream connections leading to no more logs in my backend.
logging-operator-logging-fluentbit-hft58 fluent-bit [2020/10/27 10:15:09] [error] [io_tls] flb_io_tls.c:356 NET - Connection was reset by peer
logging-operator-logging-fluentbit-hft58 fluent-bit [2020/10/27 10:15:09] [error] [output:forward:forward.0] no upstream connections available
logging-operator-logging-fluentbit-hft58 fluent-bit [2020/10/27 10:15:09] [ warn] [engine] failed to flush chunk '1-1603719773.125817609.flb', retry in 811 seconds: task_id=620, input=tail.0 > output=forward.0

I'm hitting this as well

I verified that disabling TLS prevents this behavior.

If you are using TLS you need to configure the certificates properly. You can use One Eye to simplify the install flow for fluentbit and fluentd.
$ one-eye cert-manager install
$ one-eye logging install
$ one-eye logging configure --secure

I'm not even sur TLS is the issue here, because I'm still having issue of logs not being forwarded anymore because of no upstream connections available errors:
[2020/11/12 17:03:21] [error] [io] connection #105 failed to: logging-operator-logging-fluentd.logging.svc:24240
[2020/11/12 17:03:21] [error] [output:forward:forward.0] no upstream connections available

Killing fluentbit and fluentd pods makes it work again, but then after a short time, the no upstream connections available errors happens again.

Sorry for not getting back to this, yes this is typically because of resource exhaustion. Fluentd does not handle a large number of chunks well when starting up, so that can be a problem as well. Feel free to reopen if you think this is something we should be able to fix on the operator side.


Use filter for azure virtual machines

When I try filter
terraformer import azure - R MuResourceGroup -r=virtual_machine -filter=virtual_machine=[resource_id]
All the VMs come, and the filter does not happen, am I using it the wrong way?

Waiting


feat(library): typesafe github context

The github context contains information about the workflow run and the event that triggered the run.
See https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
A particularity here is that github.event depends on the kind of event : Push vs PullRequest vs Release vs WorkflowDispatch...
Also it has too much properties to write them down manually
So instead I take from library/src/test/resources/payloads the event payloads available at  https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads
And I generate with KotlinPoet the corresponding PushEventContext / PullRequestEventContext / ReleaseEventContext / WorkflowDispatchEventContext inside library/src/gen/kotlin
More payloads could be added, but I think that's the four most frequent ones.

Shit we need to disable ktlint for library/src/gen/kotlin/it/krzeminski/githubactions/dsl/expressions/contexts/**

Generator moved to :wrapper-generator

@krzema12 I think I'm done


How to query single Type content ?

Hi everybody !
I am trying to use this plugin to pull some data from my Strapi.
I succeed to pull data from a contentTypes :
      resolve: "gatsby-source-strapi",
      options: {
        apiURL: "http://....:1337",
        contentTypes: [
          // List of the Content Types you want to be able to request from Gatsby.
          "article",
        ],
        queryLimit: 1000,
      },

query {
          allStrapiArticle {
            edges {
              node {
                id
                title
                test2
              }
            }
          }
        }

But now, I would like to query content from a Single Type content, here "accueil" :
      resolve: "gatsby-source-strapi",
      options: {
        apiURL: "http://.....:1337",
        contentTypes: [
          // List of the Content Types you want to be able to request from Gatsby.
          "article",
        ],
        singleTypes: ["accueil"],
        queryLimit: 1000,
      },

I tried to write my query asking allStrapiAccueil, strapiAccueil, accueil, but it does not work.
  query CampusQuery {
    allStrapiAccueil {
      edges {
        node {
          id
        }
      }
    }
  }

Which syntax should I use ?
I think that it could be nice to write the good syntax in the readme ;)
( I am tagging a colleague who is working on it too @knabeth )
Thank you :)

Your bottom query is the same as mine.
Does your singleTypes definition match your API ID :  ? for that page in Strapi?

Hi @mannp , thank you for your answer.
Yep, the ID match :

Ok, solved just here : #116
I was using the package version number 0.0.11.... :cry:
It works now, thank you manp ;)


feat: 5817 Product page: tab Data

What

Screenshot

Fixes bug(s)

Fixes:

Part of

#525

@g123k could you tell me please, if squash on merge is allowed on this project ?

info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_category_item.dart:98:26 • flutter_style_todos
   info • Unnecessary use of double quotes • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_element_item.dart:19:29 • prefer_single_quotes
   info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_element_item.dart:19:44 • flutter_style_todos
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:22:31 • prefer_const_constructors
   info • Unnecessary use of double quotes • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:22:36 • prefer_single_quotes
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:24:26 • prefer_const_constructors
   info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:24:63 • flutter_style_todos
   info • A value for optional parameter 'controller' isn't ever given • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:29:49 • unused_element
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:40:[11](https://github.com/openfoodfacts/smooth-app/actions/runs/12053739973/job/33610932110?pr=5953#step:8:12) • prefer_const_constructors

@AdrienMDevMobile don't hesitate to ping people in #mobile-app when a PR is ready, as most of us are a bit overwhelmed by github notifications !

@AdrienMDevMobile You still have issues with your PR: https://github.com/openfoodfacts/smooth-app/actions/runs/12238508540/job/34210431480?pr=5953


fix: Fix encrypted label icon and text alignment

This PR fixes the misalignment of the encrypted label icon and text in the datasource form controls.
Fixes #15711

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manual tests
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=fa2d28e


Handle .env when updating Quarkus properties

The .env file at the root of a Quarkus project can contain environment variables that configures Quarkus and so can contain env var version of the properties.
For instance QUARKUS_MY_PROPERTY or _DEV_QUARKUS_MY_PROPERTY for something that is only enabled for the dev profile.
The rule is basically that any letter will be uppercased, numbers will be left alone and anything else will be transformed to _.
Note that while simple cases might be manageable, I'm not entirely sure how we will be able to handle regexps. We might be able to handle the most common cases (and make sure we catch errors if the transformed regexp is invalid).
One difficulty will be that my-property has to be changed to MY_PROPERTY but [a-z] shouldn't be affected. Also - can be used at the end of a class of characters and in this case, it is just a - that should be replaced.

This requires changes on OpenRewrite: https://github.com/openrewrite/rewrite/pull/3993


Update libs and migrate to PackageRefereneces

Update libs
Update Xamarin Forms to 4.4.0
Migrate packages.config to PackageReferences

How can i see what check is failing?? can you assist here maybe @mierzynskim


Handle null bytes in encoding detection

Ref: https://github.com/ffi/ffi/issues/1081

Fixed in https://github.com/tachyons/charlock_holmes/commit/72836a99e2b98c02a5482845ae4ee05cbf21d866


How to get the progress report?

Could you give me an example of how to get the progress report?

The demo for progress report is available in the source code, the winform test project.
For wiki documentation, you can refer to the following:
Backup
https://github.com/MySqlBackupNET/MySqlBackup.Net/wiki/Using-Progress-Report-With-Export-Backup
Restore
https://github.com/MySqlBackupNET/MySqlBackup.Net/wiki/Using-Progress-Report-With-Import-Restore


Rust client generator

Is your feature request related to a problem? Please describe.
we should have multi languages
Describe the solution you'd like
https://github.com/paritytech/jsonrpc

just a note on that parity lib, its a server not a client

:tada: This issue has been resolved in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update minimatch

thanks @delphiactual, do you have any context to share here, what might have changed and/or broken between 1 & 3 that we might need to look out for?

[Latest commit[(https://github.com/isaacs/minimatch/commit/6944abf9e0694bd22fd9dad293faa40c2bc8a955) which brought him up to 3.0.2 fixes a DoS that can occur in older versions. Whether anything else changed between 1 & 3 I have no idea. Maybe @isaacs can give you more info.

merged, thanks @delphiactual


Add tests about writing empty table to ORC/PAQUET

Signed-off-by: sperlingxx<EMAIL_ADDRESS>Recently, a cuDF bug of writing empty table to ORC was found during the regression tests: https://github.com/rapidsai/cudf/issues/9783. It also revealed the lack of empty writing tests in automatic testing pipeline. Current PR is to add these tests.

build


updating readme from branch example

Updates
I updated the readme file. _Please_review and accept.

Thoughts
I probably shouldn't but ok.


cmd/server: wait to shutdown filetransfer.Controller until paygate quits

This was missed from earlier this morning. Reported by Ray

Codecov Report

Merging #270 into master will decrease coverage by 3.87%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   61.39%   57.51%   -3.88%
==========================================
  Files          43       43
  Lines        4810     4811       +1
==========================================
- Hits         2953     2767     -186
- Misses       1309     1519     +210
+ Partials      548      525      -23

Impacted Files
Coverage Δ

cmd/server/main.go
18.47% <0%> (-0.12%)
:arrow_down:

internal/accounts.go
10.95% <0%> (-69.87%)
:arrow_down:

internal/database/mysql.go
10.66% <0%> (-50.67%)
:arrow_down:

internal/ofac/client.go
38.65% <0%> (-35.3%)
:arrow_down:

internal/filetransfer/sftp.go
47.08% <0%> (-24.87%)
:arrow_down:

internal/microDeposits.go
64.03% <0%> (-1.48%)
:arrow_down:

internal/filetransfer/config.go
70.12% <0%> (-0.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50a0bc...a34608f. Read the comment docs.


Add qdrant - a vector similarity search engine

This adds qdrant - a vector similarity search engine with extended filtering support.
Categories are clustering and data-structures (analog to the crate faiss).
URL: https://github.com/qdrant/qdrant
The crate is not hosted on crates.io.

While Qdrant itself is not hosted on crates.io, the Rust client is: https://crates.io/crates/qdrant-client

@llogiq Oh, interesting! Normally, I don't say this, but: Thank you for the pointer (pun intended)! 😜


update ffmpeg support

Based on PR #5322
Migration have been done for these ffmpeg/libav changes:
2013-12-11 - 29c83d2 / b9fb59d,409a143 / 9431356,44967ab / d7b3ee9 - lavc 55.45.101 / 55.28.1 - avcodec.h
av_frame_alloc(), av_frame_unref() and av_frame_free() now can and should be
used instead of avcodec_alloc_frame(), avcodec_get_frame_defaults() and
avcodec_free_frame() respectively. The latter three functions are deprecated.
2012-10-08 - ae77266 / 78071a1 - lavu 51.74.100 / 51.42.0 - pixfmt.h
Rename PixelFormat to AVPixelFormat and all PIX_FMT_* to AV_PIX_FMT_*.
To provide backwards compatibility, PixelFormat is now #defined as
AVPixelFormat.
Note that this can break user code that includes pixfmt.h and uses the
'PixelFormat' identifier. Such code should either #undef PixelFormat
or stop using the PixelFormat name.

:+1:


Datacollection of volume mesh from mesh directory

I found that creating a data collection of volume meshes from a directory could only read vtk files while Scalismo can read up to three formats (vtk, vtu and inp). I have added other formats (inp and vtu)

Thanks for adding this. I changed the target branch to release-0.18, as we never directly merge anything into master.
Your PR has failed because the formatting is not correct. Please run
sbt scalafmtAll
and commit the corrected formatting.
You can instruct intelliJ to reformat your code correctly when saving. In this way you will never run into this problem again. See this link.

I removed myself as a reviewer as there are already two active on this PR.

@rassaire I fixed the issue with the PR, such that we can close it and move on. Unfortunately I don't seem to have permissions to contribute to the PR. Can you give me the rights to edit this PR?

Hi Marcel, I am wondering why you don't have rights to edit.

@marcelluethi  I have this from my side which should allow you to edit.

Thanks for adding this. I changed the target branch to release-0.18, as we never directly merge anything into master.
Your PR has failed because the formatting is not correct. Please run
sbt scalafmtAll
and commit the corrected formatting.
You can instruct intelliJ to reformat your code correctly when saving. In this way you will never run into this problem again. See this link.

Thanks, @marcelluethi . Sorry I didn't see your comment earlier. I'll check that out.