Parse Accessibility element for media type Subtitles in DASH

Have you read the FAQ and checked for duplicate open issues? - yes
Is your feature request related to a problem? Please describe.

I was on the fence should I open Bug Report or Feature Request.
Current problem is that Shaka does not recognize Accessibility element for Subtitle track. As the developer, you do not have enough signals/information to distinguish caption tracks from subtitle tracks.
Describe the solution you'd like

I think it should be an open discussion, but if somebody supports both CC and Subtitle in the media manifest (DASH), they should be equipped to analyze the data. For example, getTextLanguagesAndRoles could analyze Accessibility elements and return roles caption, subtitle. Or getTextTracks should be rich with the information about accessibility traits so the developer can build maintainable conditions to support CC + Subtitles use cases.
Describe alternatives you've considered

Trying to use methods like getTextLanguagesAndRoles or getTextTracks does not give enough metadata to operate on.
Additional context

I would like to share with you an example of how Role/Accessibility use-case looks like in DASH:
<AdaptationSet lang="en-US" mimeType="text/vtt">
    <ContentComponent contentType="text"></ContentComponent>
    <Accessibility schemeIdUri="urn:mpeg:dash:role:2011" value="caption"></Accessibility>
    <Representation id="subs-6535010" bandwidth="256">
        <BaseURL>../../texttrack/6535010.vtt?ptoken=c6dfa7a0c67abc3b03c299d9f3f0951348dd538f</BaseURL>
    </Representation>
</AdaptationSet>
<AdaptationSet lang="en-US" mimeType="text/vtt">
    <ContentComponent contentType="text"></ContentComponent>
    <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"></Role>
    <Representation id="subs-6534961" bandwidth="256">
        <BaseURL>../../texttrack/6534961.vtt?ptoken=ad14492a31b98482abfb6a0c0d069eccfcc42ef1</BaseURL>
    </Representation>
</AdaptationSet>

Shaka will parse such DASH manifest without any issues, but as a developer, you will not have enough information from Shaka API to distinguish tracks.
Here are examples, how results will look for the available Shaka API:
Method getTextLanguagesAndRoles
[
  {language: "en-US", role: "subtitle"},
  {language: "en-US", role: ""}
]

Method getTextTracks
[
    {
        active: false
        audioBandwidth: null
        audioCodec: null
        audioId: null
        audioRoles: null
        bandwidth: 0
        channelsCount: null
        codecs: null
        frameRate: null
        height: null
        id: 1
        kind: "subtitle"
        label: null
        language: "en-US"
        mimeType: "text/vtt"
        originalAudioId: null
        originalTextId: "subs-6534961"
        originalVideoId: null
        primary: false
        roles: ["subtitle"]
        type: "text"
        videoBandwidth: null
        videoCodec: null
        videoId: null
        width: null
    },
    {
        active: true
        audioBandwidth: null
        audioCodec: null
        audioId: null
        audioRoles: null
        bandwidth: 0
        channelsCount: null
        codecs: null
        frameRate: null
        height: null
        id: 3
        kind: "subtitle"
        label: null
        language: "en-US"
        mimeType: "text/vtt"
        originalAudioId: null
        originalTextId: "subs-6535010"
        originalVideoId: null
        primary: false
        roles: []
        type: "text"
        videoBandwidth: null
        videoCodec: null
        videoId: null
        width: null
    }
]

So it appears that <Accessibility> is supplying the same information that could be in <Role> (namely, captions vs subs).  Is that correct?

When Role is used for Adaptation Set of the media type Subtitle it does not have value caption.
Possible values for Role are:
- main
- alternate
- subtitle
- supplementary
- commentary
- dub
- description
- emergency

Source: https://dashif.org/docs/DASH-IF-IOP-v4.2-clean.htm#_Toc511040753 (Scroll a bit until media type Subtitle)

Ah, okay.  I see.  This should be straightforward enough to fix, then.

We'll add parsing of the <Accessibility> element in DASH.  Something of the form:
<Accessibility schemeIdUri="urn:mpeg:dash:role:2011" value="FOO">

will add "FOO" to the roles array in the track object.  If the value is "caption", it will also set the kind attribute of the track.


Walking through the files..

Mason want to take a look at this.... See if this how you want :)

+1


fix handling of @ + keyword

Codecov Report

Merging #78 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage    66.7%   66.94%   +0.23%
==========================================
  Files          39       39
  Lines        2799     2789      -10
  Branches       49       49
==========================================
  Hits         1867     1867
+ Misses        905      895      -10
  Partials       27       27

Impacted Files
Coverage Δ

src/tokentree/walk/WalkAt.hx
97.29% <100%> (+11.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5eb916...4b551ec. Read the comment docs.


feat: add custom fragment import helpers and remove @graphql-fragment…

…-import dependency

Added new helper modules for inlining and gathering GraphQL fragments:

gather-fragment-imports.ts to fetch and parse all direct and transitive imports from the source.
inline-imports.ts to inline import statements within GraphQL files.
match-import.ts to match import statements in GraphQL files.

Removed the dependency on @graphql-fragment-import/lib by implementing custom fragment import logic.
Updated inlineFragments function to utilize the new inlineImportsWithLineToImports.
Modified package-lock.json and package.json to reflect these changes.

The new implementation provides more control over the fragment import process and reduces external dependencies.

Thank you so much! I tested it locally and it works perfectly. I'm going to merge this as is and then see if it would be possible to reuse it to also handle the "automatic inlining", which I've now implemented in a (probably) not very efficient way.


Added Carthage support

What?
I've created a new project that compiles frameworks in order to be used for Carthage. I've also updated the README explaining how to integrate the library using Carthage.
Nice job @sebyddd :clap:

The demo project seems to not work anymore. Can you please keep the current structure of the files? :smile:

@sebyddd I tested the project and everything is working.

Can you please check the 3.0 launch (73a31454a362370875f3b18573f4133f7c7102f8) and integrate it into this one if you have some time?
Thanks! :)


Implement /hide_window in Sandboxie.start()

http://www.sandboxie.com/index.php?StartCommandLine#start
The parameter /hide_window can be used to signal that the starting program should not display its window:
"C:\Program Files\Sandboxie\Start.exe"  /hide_window cmd.exe /c automated_script.bat

ok


Set up read.me

It is good to get the site's important links in there:

the .page
the .live
the original site
any special instructions or call outs
a pre-made Sidekick link is nice too

Please add links to these pages as ones we plan to build out in Franklin:
https://www.freseniusmedicalcare.com/en/home
https://www.freseniusmedicalcare.com/en/patients-families-overview
https://www.freseniusmedicalcare.com/en/dialysis-options

newbie here, i want to contribute. Can you tell me what exactly to add?

I am taking this one, newbie here LOL.


Uncaught TypeError: t._reverse is not a function

Describe the bug
Build error at netlify the is this error happening in the node_modules\.vite\deps\jsonwebtoken.js file

Uncaught TypeError: t._reverse is not a function
    at index.1607bf8c.js:35:13236
    at index.1607bf8c.js:35:13634

Reproduction
https://deploy-preview-256--ethicaprod.netlify.app/
Steps to reproduce
No response
System Info
System:
    OS: Windows 11 10.0.26085
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 12.90 GB / 31.73 GB
  Binaries:
    Node: 16.20.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.19.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.65)
    Internet Explorer: 11.0.26085.1
  npmPackages:
    vite: ^2.2.1 => 2.9.17

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vite 2 won't be updated anymore.
https://vitejs.dev/releases.html#:~:text=The previous Vite Major will keep receiving important fixes and security patches. After that%2C it would only get updates if there are security concerns.


Uppercase File Extension Not Supported

gpx_converter version: 1.7.3
Python version: 3.8.10
Operating System: Windows 10

Description
It seems that the check for input_extension fails if your GPX file has an uppercase file extension.
What I Did
from gpx_converter import Converter

gpx_file = r"C:\Data\Test_GPS_Data.GPX"
Converter(input_file=gpx_file).gpx_to_dataframe()

Throws the following:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-13-d42e2417745d> in <module>
----> 1 Converter(input_file=gpx_file).gpx_to_dataframe()

~\AppData\Local\programs\Anaconda3\envs\gpx\lib\site-packages\gpx_converter\base.py in gpx_to_dataframe(self, lats_colname, longs_colname, times_colname, alts_colname)
     59         """
     60         if self.input_extension != ".gpx":
---> 61             raise TypeError(f"input file must be a GPX file")
     62
     63         if not lats_colname or not longs_colname:

TypeError: input file must be a GPX file

But running the following works:
from gpx_converter import Converter

gpx_file = r"C:\Data\Test_GPS_Data.GPX"
Converter(input_file=gpx_file.lower()).gpx_to_dataframe()

Should be as easy as changing that extension check to:
 if self.input_extension.lower() != ".gpx":

@CF-FHB-X Thanks for the hint ;)
You are right! do you want to fix this and make a PR or should I do it? I'm just asking because you basically posted the solution too :D, so feel free to make a PR if you want and I would happily review and accept it. If you don't want to then I will fix this myself ;)

Hey - sorry about that (been a busy last few days and missed the message!). Thanks for the fix!


Autodoc generated documentation overflow for python classes with a long import path

Problem
The documentation generated with the autoclass directive for python classes placed in a module with a long import path overflows the wy-nav-content div.
Reproducible Project
https://github.com/federicodabrunzo/render-issue-for-autodoc-generated-class-with-long-import-path/tree/main?tab=readme-ov-file
Error Logs/Results

Expected Results
The <dt> element containing the class import path should not overflow its containing elements.
Environment Info

Python Version: 3.11.9
Sphinx Version: 8.1.3
RTD Theme Version: 3.0.1

To fix just on your specific project, you could put the following line in your custom CSS. See the image at the end of this StackOverflow answer for the effect (look at "SomeLongModule.SomeLongClassName"). It breaks long identifiers (or any long word) but only if strictly necessary to fit everything within the width.
html.writer-html5 .rst-content { overflow-wrap: break-word }

This is not to say that this bug report is invalid. IMO, the theme should include that styling by default.
A disadvantage of this approach is that the break can be anywhere in the identifier. Perhaps ideally it would only break next to a dot (i.e. "foo.bar" becomes "foo.\nbar") but that would be a bigger change, but the only alternative I can think of wouldn't be great (but then, I'm no CSS/html expert): you could put a breaking zero-width space next to each dot. That would need to happen in the document generation step rather than in the theme. One problem is that it would also allow breaking there even in cases where it's not necessary to fit everything on one line (because the identifier just happened to be near the right hand side). It would also get included in the text if you copied and pasted it. So, overall, I still think the above CSS is probably the best fix.


Migrate from TravisCI to GitHub Actions

Final touches to officially move away from TravisCI.

@jekyllbot: merge +dev


Awesome! Yay! Push new release to Hex for Mac M1 fix?

Hey! So amazing! Just had minor issue on Mac M1 that is fixed if I pull from git:
  defp deps do
    [
      # {:rustler, "~> 0.22.2"}
      {:rustler, git: "https://github.com/rusterlium/rustler.git", sparse: "rustler_mix"}
    ]
  end

mix task mix rustler.new from {:rustler, "~> 0.22.2"} has the old .cargo/config file still there.
new native/[NIF_NAME]/.cargo/config (which fixes nif build errors on M1 Macs):
[target.'cfg(target_os = "macos")']
rustflags = [
    "-C", "link-arg=-undefined",
    "-C", "link-arg=dynamic_lookup",
]

Right now, the only warning I get when using the git rustler_mix is:
==> rustler
Compiling 7 files (.ex)
warning: variable "code" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/rustler/compiler/config.ex:85: Rustler.Compiler.Config.external_resources/2

Generated rustler app

I think this one can be closed. Version 0.23.0 was released with this fix.


Images not shown in "Aktuellt/News" view

Problem located:

item?.__media?.url is undefined in Blog.tsx:173 header image when it should be url link to image. No idea why this doesnt work. Note: Blog.tsx:162 does not impact what image is shown
console.log(item?.__media?.url) returns Undefined
Same problem in Gallery.tsx:112 but with firstItem?.__media?.url for the rest of the images. Note: Gallery.tsx:139 does not impact what image is shown
Potenital solutions
Find and replace firstItem?.__media?.url with firstItem?.__media?.formats.medium.url and item?.__media?.url with item?.__media?.formats.medium.url which does contain link to correct image. Note: medium can be replaced with large and small, i just chose one at random

Fix so that firstItem?.__media?.url and item?.__media?.url returns link to image, maybe something for @landeholt or @OliverMidbrink ?


Stat.ink shows 平成 instead of 令和

This is a known issue.
Yii Framework 2 uses ICU PHP Library (php-intl).
Remi's PHP 7.3 binary uses ICU 62.
ICU added Reiwa support in 64.2.

2019-04-17: ICU 64.2 released. This maintenance update for ICU 64 includes draft Unicode 12.1 update, CLDR 35.1 locale data and support for new Japanese era Reiwa (令和).

it works!

Top page's JavaScript: https://github.com/fetus-hina/stat.ink/commit/481b4983393caa8bf81241f80be62f530c222c1a#diff-7122664997b5222c4d25f34fbd797100
And replaced an RPM package for ICU 62 with my own build.

Finally, it fixed by https://github.com/remicollet/remirepo/issues/149


Font

Which font are you using in your preview images in README.md ?   Love the font almost as I love the theme!

I'm happy that you like it.
The font in the screenshots are actually 2 fonts glued together with Custom CSS. For normal style I used Hasklig  and for italics Cartograph Mono CF.
I think there is a beautiful synergy between the two fonts and they intertwine naturally together.
I will add this bit of info in the README file.

Hi,
I have installed both fonts but I still cannot see any changes to my current setup. Can you please let me know what I should be doing here?
Thank you in advance.

My pleasure.
The walkthrough is for a Windows OS. I assume that for Unix and MacOS you would have to change only the path.

IMPORTANT: Run as aministrator VS Code
install Custom CSS and JS Loader
download or copy the content of customvscode.css
copy the file in Users\yourusername\customvscode.css. This is what I have on my system c:\Users\liviuschera\customvscode.css
In settings.json add:  "editor.fontFamily": "Hasklig",
  "vscode_custom_css.imports":
    [
      "file://C:/Users/yourusername/vscodecustom.css"
    ],

press F1
Select Enable Custom CSS and JS
Reload VS Code (it doesn't have to be in administrator mode)

NOTES:

if Code complains about that it is corrupted, simply click “Don't show again”.
make sure that you comment out the optional CSS code if you don't want to change the UI's default font.

Have fun! :)

even after following all steps my fonts seem to be different than the one in the previews. :(

@Jado99kc
Hello, my friend. Try this:

I used the font "Cousine" cuz "Cartograph Mono CF" costs $40.
In settings.json add:

    "editor.fontFamily": "Fira Code",
    "editor.fontLigatures": true,
    "vscode_custom_css.imports":
      [
        "file:\\C:\\Users\\YourUserName\\customvscode.css"
      ],

P.S. ••• Hasklig is none relevent font, I recomended to you use Fira Code, PragmataPro or iosevka (these fonts supports 'ligatures').
Cheers! ✌👍

whats the font used in the comments ?

@commgina
I think it's Cousine.

Who wants paid fonts like Cartograph CF Mono and others for free??


ExpressionGenerator: support Struct and Array

On #625, the generator is currently unable to generate an expression of Struct and Array. Once that PR gets merged, we should consider supporting them.

Closing as we are retiring the known-value shader generator.


Vundle ignores changed github user in bundle line

If I have, for instance, Bundle 'sjl/gundo.vim' in my vimrc and then change that line to point to my fork (so to Bundle 'Valloric/gundo.vim'), Vundle doesn't see anything new.
 This is all after restarting vim.
Vundle should detect that the repo url has changed, even if the folder to which the repo needs to be cloned to has not.

closing this as it duplicates #48
thanks!


Adding search and count of result

@PeterDaveHello  Please review the changes for the total result and count with time.

Sorry! forget to attach snapshot. Here it is:-

@devarshad To add the search time looks very nice, however I think this PR has conflict with #177, I'll need to merge #161 first, them #177, then this one. I'll ping you to revise this PR later, thanks!

Oops, I'm sorry, forgot to ping you and that feature was implemented, my apologies.


wip: custom dialect types

Hey, and thanks for your contribution.
I know it's a draft PR, but since we kinda have a design idea for this feature, I'll comment here later this week to share our thoughts.
Sorry for the delay, we're mainly focused now on adding hooks and authorization support for ent.

@a8m Not a problem. I really like what you are doing with this library so I am excited so see the design you come up with. There PR's really help me get familiar with the guts of the project so I don't feel like its a waste if nothing comes from it.
Ciaran

Hey @cliedeman, sorry for the delay, I'm focused on the mutation and hooks layers and didn't have time to finalize the custom fields interface.
I thought about creating an interface that will provides the following values: database-type, Go-type and predicates (maybe create a separate package named fieldtype).
When creating a new fieldtype, a user needs to define its database type, Go-type (that implements the driver.Valuer, and the sql.Scanner interfaces). If the defined type is supporting predicates, they can be defined as well - we'll need to provide some interface for it as well (like UnaryOp, BinaryOp, etc).
IMO, we should migrate all existing fields to it (without breaking existing programs), and support the popular database types per dialect (like pg.hstore, mysql.datetime, etc).
One of the advantages of migrating existing types, is to allow users define database primitive types as Go typedefs. For example, use this Go type: type StatusCode string, and a string field in the database.


refactor(DC-26): renamed Systems of Record section

This PR has the goal of aligning all occurrences the System of Record label after the sidebar update from Projections. Additionally, some screenshot have been updated.

Can we merge this?


fix(aws-cloudfront): expose distributionId

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

cc @leepa


Sui Mainnet 1.15.1 panic issue

There is a panic issue in version mainnet-v1.15.1, could you help create a new release for the 1.15.2 please?
https://github.com/MystenLabs/sui/releases/tag/mainnet-v1.15.2

It was built as part of https://github.com/shinamicorp/sui-docker/pull/175, though the images were tagged with b4687af, not mainnet-v1.15.2 (identical git commit). We'll build the next mainnet release as it's officially released on github

Thanks, the b4687af is working fine for now


Include @ibm/type as a dependency for our font loading strategy

Currently, we're defining our own strategy for bringing in the new IBM Plex fonts that is inspired by how IBM/type was initially structured. Given that there is effort being invested into making IBM/type production-ready, we should try and integrate that dependency into our own project.
Initially, there might be some mismatches in terms of support but we should use this issue to try and provide feedback as a consumer of the IBM/type repo for the type of things we would need to consume the project.

@seejamescode's initial PR for this here: https://github.com/carbon-design-system/carbon-components/pull/353

Closing in favor of our elements type strategy!


Deployment scripts for website

The website deployment scripts broke during the port to an Ember app. Bring them back!

Fixed in https://github.com/bustlelabs/content-kit-editor/pull/165, should have been tracked against that repo.


The training process on custom data dies, what to do?

Versions:
Ubuntu 18.04
Cuda 11.2
Torch 1.11
I prepared data with COLMAP and started training on the custom dataset, dataloader loads data and its interrupts (seem's like I kill the process but I didn't press any button). Also, I tried on the Fox dataset, and everything works, but on custom, it dies, how fix it?

I tried it on wsl2 with Ubuntu 22.04, CUDA 11.3, Torch 1.12 and the situation is about the same. I installed all dependencies and built raytracing. On the fox dataset everything ok, but on my custom, it loads data and then prints "KILLED".
About the dataset it contains 325 images with 1080p resolution, I tested it on Nvidia instant-ngp, and it worked fine. Help please

Hello, i have meet same problem.would you solved this issue?

Hello, i have meet same problem.would you solved this issue?

Not yet, how about you?

It is because of out of memory issue of your GPU.
You can use the command dmesg to confirm it.
Solution:
Downscale the your images.
Line 133 in main_nerf.py. Update the dataloader line as follows:
train_loader = NeRFDataset(opt, device=device, type='train', downscale=16).dataloader()
Please not that I have added downscale=16. You might want to adjust it. 16 will downsample it by a lot. Hence fitting it in memory.


Remove fCheckDuplicateInputs flag from CheckTransaction

This removes the fCheckDuplicateInputs flag from CheckTransaction in consensus/tx_verify.cpp.
This flag was subject to a CVE in bitcoin (See the full disclosure posting in their blog: https://bitcoincore.org/en/2018/09/20/notice/).
Ever since the CVE was fixed this flag is never passed as false and you must not not check it. Also the behavior is not checked with the parameter false in any test, as can be seen from this pull request as no test had to be touched yet everything passes.
Signed-off-by: Julian Fleischer<EMAIL_ADDRESS>

Just want to share that such change is the most closed PR in Bitcoin https://github.com/bitcoin/bitcoin/search?q=fCheckDuplicateInputs&type=Issues
Before we approve, we should read the reasons why they close it (don't merge) and see how it's aligned with our code.

In bitcoin everything goes back to this comment:

NACK we'll probably re-introduce the optimization at some point, let's avoid the code churn.

Which I 100% do not agree with. There's an answer to that even which says:

IMO leaving unused code that can lead to bugs is worst than code churn. This can be reverted along with proper review/testing once and if necessary.

Which I a 100% do agree with.

but again, this is not applicable anymore since the community had time enough to understand what happened there, and in the end they just removed that.

Yepp. The blog post I am referencing in the description was also written after that.


onSliding not working

Hi,
I am trying to get the onSliding prop working but it does not seem to get called.
It looks as if it has not been added to the build/index.js file. If I run 'npm run-script build' it is called as expected.
I am new to the npm ecosystem so not quite sure what the exact fix is.
Thanks,
Stephen

Hi @stephenheron!
Which version of reat-native-side-menu do you use? I believe onSliding has been introduced in 1.1.0 and not supported in prior versions.

Hi @Kureev
In my package.json I have "react-native-side-menu": "^1.1.0".
I will try deleting the node_modules directory and reinstalling just to see if that fixes it.
Thanks,
Stephen

Probably you can also provide a code example so I can take a look? It is hard to debug an issue without any context 😞

Hi @Kureev
Deleted node_modules and reinstalled but no luck.
Here is my code:
<ReactNativeSideMenu                 menuPosition="right"                 isOpen={this.props.menuStore.isOpen}                 onSliding={(status) => console.log(status)}                 onChange={(isOpen) => this.props.menuStore.setOpen(isOpen)}                 openMenuOffset={Math.round(Dimensions.get('window').width * 0.75)}                 bounceBackOnOverdraw={false}                 disableGestures={true}                 menu={menu}                 >                 {this.props.children} </ReactNativeSideMenu>
I don't get any console.log entries when sliding however I run the commands below then it does work after reloading.
cd node_modules/react-native-side-menu/ npm run-script build
Thanks,
Stephen

You don't have to run these commands by yourself. Although, it shouldn't do any harm as well. I'll take a look on your code and try to come up with a solution from you 👍

I confirm it is a bug. I'm on it.

1.1.3 should fix it. Can you please give it a try?

Hi @Kureev
Nice one!
That seems to be working now when I upgraded to 1.1.3
Thanks for the help. I will let you do the honours of closing the issue. ;-)
Thanks,
Stephen

Haha thanks for reporting this, @stephenheron!


no rename action in the file tab's context menu

We even have this for the terminal in the editor area where it's less used/important

\duplicate https://github.com/microsoft/vscode/issues/127087

@lramos15 can there at least be an action to do this in the command palette?

two steps feels cumbersome and unnecessary IE focus file in explorer view then F2 or right clicking


Correct typo in McConnell's current leadership

This PR corrects what might have been a prior typo made when updating current leadership roles

Thanks!


Add bounds check to Name Scan

Add a simple bounds check before indexing into data.

Merged. Thanks!


docs: Put cargo-add change under nightly

I'm assuming we'll want to beta-backport this.

This was carried over into the rust 1.71 release notes where I noticed it.  See also rust-lang/rust#113541.

Thanks. I don't think this necessarily needs a backport since the release notes and blog posts all link directly to the master branch here. I don't think anyone sees the CHANGELOG from the release branches. Also, I believe the 1.71 stable release has already left the station.
@bors r+

:pushpin: Commit 642e0c38db8780be4dbe1273e78acf98158df237 has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit 642e0c38db8780be4dbe1273e78acf98158df237 with merge 445838d3ff244b56cd1f5cb43c752bccfb16ed07...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 445838d3ff244b56cd1f5cb43c752bccfb16ed07 to master...


[ENH] extension for electromyography (EMG) - BEP42

This is a very early WIP implementation to add EMG support. CIs are not expected to pass yet.
cc @neuromechanist @jwelzel @larsoner @arnodelorme @robertoostenveld feel free to push directly to this branch, I'll add you as repo collaborators on my fork

[!Note]
We meet regularly to discuss this BEP
Next meeting: 18 Dec 2024 on https://ucsd.zoom.us/j/96433382377
Communication channel on github repo / matrix / slack / discord : https://github.com/bids-standard/bids-specification/issues/1371

cc @agramfort


Look behind fails when calling Exec(Offset)

The following test should work.
 CompileRE('(?<=.A...)(X)');
 RE.InputString:= '_A123X3';
 IsTrue('Exec must give True', RE.Exec(2));

It does work, when called without offset.
But, with offset, it can still look back to before the offset, and therefore should find this.
The following modified version demonstrates the expectation: https://regex101.com/r/51WHvZ/1
The leading _| matches one char, the pattern is global, so it is matched a 2nd time at start-offset = 2. And the result for the 2nd match is success.

No idea how to fix, yet.

I will look later / lets concentrate on the big PR first.

This issue can be on hold / it will be closed as side product of implementing better support for all lookaround patterns (in progress)

@User4martin Is it solved? Then please close.


Release v1.21.0

@kcw-grunt conflicts fixed! Could you please do a review

@kcw-grunt conflicts fixed! Could you please do a review


Pes parsing and buffering

This pull request includes significant changes to the MPEG-TS payload handling and introduces a new PesBuffer structure. The key changes involve refactoring the PayloadType enum and adding a new buffer to manage PES packet payloads.
Refactoring and Enhancements:

common/src/mpegts/payload.rs: Refactored PayloadType enum to use PacketizedElementaryStream instead of PesPacketHeader.

New Features:

common/src/mpegts/pes/pes_buffer.rs: Introduced PesBuffer to manage PES packet payloads, including methods for adding fragments and removing payloads. Added unit tests to ensure functionality.


polemo2_in task error with datasets 2.16.1

polemo2_in task error with datasets 2.16.1:
Traceback (most recent call last):
  File "~/venv/bin/lm_eval", line 8, in <module>
    sys.exit(cli_evaluate())
  File "~/lm-evaluation-harness/lm_eval/__main__.py", line 231, in cli_evaluate
    results = evaluator.simple_evaluate(
  File "~/lm-evaluation-harness/lm_eval/utils.py", line 415, in _wrapper
    return fn(*args, **kwargs)
  File "~/lm-evaluation-harness/lm_eval/evaluator.py", line 122, in simple_evaluate
    task_dict = lm_eval.tasks.get_task_dict(tasks)
  File "~/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 275, in get_task_dict
    task_name: get_task(task_name=task_element, config=config),
  File "~/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 217, in get_task
    return TASK_REGISTRY[task_name](config=config)
  File "~/lm-evaluation-harness/lm_eval/api/task.py", line 619, in __init__
    self.download(self.config.dataset_kwargs)
  File "~/lm-evaluation-harness/lm_eval/api/task.py", line 714, in download
    self.dataset = datasets.load_dataset(
  File "~/venv/lib/python3.10/site-packages/datasets/load.py", line 2523, in load_dataset
    builder_instance = load_dataset_builder(
  File "~/venv/lib/python3.10/site-packages/datasets/load.py", line 2232, in load_dataset_builder
    builder_instance: DatasetBuilder = builder_cls(
  File "~/venv/lib/python3.10/site-packages/datasets/builder.py", line 371, in __init__
    self.config, self.config_id = self._create_builder_config(
  File "~/venv/lib/python3.10/site-packages/datasets/builder.py", line 592, in _create_builder_config
    raise ValueError(
ValueError: BuilderConfig 'klej-polemo2-in' not found. Available: ['default']

but it works better with datasets 2.15.0.

Hi ! klej-polemo2-in is not a valid subset for https://huggingface.co/datasets/allegro/klej-polemo2-in
I opened a PR to fix this issue in the yaml task file


Model caching with String

Hello,
I would like to know if it is possible to implement a custom String based model caching class like that :
public class StringModelCaching<ModelClass extends Model> extends ModelCache<ModelClass,         LruCache<String, ModelClass>> {

    public StringModelCaching(int size) {
        super(new LruCache<String, ModelClass>(size));
    }

    @Override
    public void addModel(Object id, ModelClass model) {
        if(id instanceof String) {
            synchronized (getCache()) {
                getCache().put(id.toString(), model);
            }
        } else {
            throw new IllegalArgumentException("A ModelLruCache uses an String");
        }
    }
    ....
}

But I have some problems, for example :
new Select().from(Model.class).queryList();

at com.raizlabs.android.dbflow.sql.SqlUtils.convertToCacheableList(SqlUtils.java:90)
because of :
BaseCacheableModel cacheable = (BaseCacheableModel)modelCache.get(Long.valueOf(id));
With FlowQueryList there is no problem, but I don't know if I doing it well..

@ndmt good find. Its actually a bug. so let me fix it.

resolved in 3.0+


Deprecated syntax in build

Starting on series/0.22, there is a bunch of deprecated syntax in the SBT build.  It's just warnings, but we don't want to live with them.  Convert to the new syntax.

@aeons got this in #4681.


Trajectories 1.7.0 not being picked up

It's on both github and spacedock. Not sure why it's not being picked up by ckan.
https://github.com/neuoy/KSPTrajectories/releases/tag/v1.7.0

Ah, it's being added without the "v"


req.session.destroy() does not remove cookies with the latest version of NextJS when hosting on Vercel

Hi, I have come across a very annoying bug recently. If you upgrade nextjs to the latest version, which is 10.0.3, and deploy the application on Vercel, the method req.session.destroy() does not remove the cookies.
Here is a repo to reproduce this issue, it's just a redeployment of the next-icon-session's nextjs example but with nextjs upgraded to 10.0.3.
Steps to reproduce:

login
logout (first time it will succeed with a 200 return)
login again
logout (this time it will fail to remove the cookie with a 304 return)

next-iron-session's nextjs example:

after upgrading nextjs to 10.0.3:

Additional information: This issue only happens when deploying on vercel, it works correctly when I run it locally.

Edit: After downgrading nextjs to 10.0.0, it works correcly on vercel.

Thanks for the detailed bug report and first analysis.
The failing version is 10.0.2. Now we need to:

understand if they fixed a bug, which in turn made our code buggy (and we should update our code)
or if they introduced a bug (and we need to find it, and they/we need to fix it)
find/identity the right change here: https://github.com/vercel/next.js/releases/tag/v10.0.2

I am doing some tests right now, let me know how it goes on your side

More info on the issue: this is because of the caching mechanism. Now why has it changed on the latest Next.js versions: I don't know and I think you should write to the Vercel support to know more.
A possible workaround for now would be to manually set caching headers (informing not to cache) on all your API routes that are setting up cookies like login and logout.

 Now why has it changed on the latest Next.js versions: I don't know and I think you should write to the Vercel support to know more.
A possible workaround for now would be to manually set caching headers (informing not to cache) on all your API routes that are setting up cookies like login and logout.

I have tried to manually set the headers res.setHeader('cache-control', 'public, max-age=0, must-revalidate')  and it does not seem to work. I'm not an expert on the http caching so I don't know if I'm doing the right way...

This might be the related change https://github.com/vercel/next.js/pull/18986/files

Hey there @dpyzo0o there's definitely something strange that changed between Vercel/Next.js, in the meantime you can set res.setHeader("cache-control", "no-store, max-age=0"); on your logout route and that should do it, even on Vercel.
Let me know!

@vvo Thanks, it works.

@dpyzo0o I just updated the next-iron-session repository and now recommend another solution: just make sure to call any route that uses destroy via a POST request. Most proxies and browsers (100%?) will never cache POST requests unless badly or weirdly configured.
The two solutions have the same effect, but using POST for logout is more common practice I think.
Thanks!

:tada: This issue has been resolved in version 4.1.11 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

🎉 This issue has been resolved in version 4.1.11 🎉
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot 📦🚀

Everything works on:
Google Chrome Version 88.0.4324.150 (Official Build) (64-bit) with
"next": "^10.0.6",
"next-iron-session": "^4.1.11"
on development and production on Vercel. Also sometimes it takes two clicks to login.
Does not work on Vercel with:
Firefox 85.0.2 (64-bit);
Firefox developer edition 86.0b8 (64-bit);

hey @Deivaras I believe this notification was long due sorry about that.
Are you using POST requests for logout routes now? I do have that double clicks to logout issue yup, did not investigate (not login though, login is always OK).

hey @Deivaras I believe this notification was long due sorry about that.
Are you using POST requests for logout routes now? I do have that double clicks to logout issue yup, did not investigate (not login though, login is always OK).

Yes, I'm doing POST request on logout fetch and also on Chrome sometimes when trying to login (after first click) I see the cookie and then you have to click login the second time, while cookie being replaced and only then you got logged in.

Hey there, I believe this is now fixed, have a look at the updated example: https://github.com/vvo/next-iron-session/commit/7ffc8bb6f3dc2262b06c765c625ea364a0839876
I cannot reproduce this bad behavior anymore.

Facing this issue now.
import { NextApiRequest, NextApiResponse } from 'next';
import { withSessionRoute } from '@utils/iron-router';

const handler = async (req: NextApiRequest, res: NextApiResponse) => {
    req.session.destroy();
    res.send({ ok: true });
};

export default withSessionRoute(handler);

We receive ok response but the session isn't destroyed when we try another api route straight after. Locally this works fine. On Vercel it doesn't for some reason.

Still seems to be an issue. Adding session.save() after session.destroy() seems to fix it though.

Changing my endpoint to POST seems to have fixed it now

work out with this
// ...
await new Promise<void>((resolve, reject) => {
      req.session.destroy((err) => {
        if (err) {
          reject(err)
        } else {
          res.clearCookie('ACCESS_TOKEN', {
            domain: '.xxx.com'
          })
          res.clearCookie('REFRESH_TOKEN', {
            domain: '.xxx.com'
          })
          res.clearCookie('connect.sid', {
            domain: '.xxx.com'
          })

          resolve()
        }
      })
    })
// ...

Version 13:
After 3 hours, changing the request to POST solved the problem. Shouldn't this have been more explicit?


Using custom DH groups

I recently noticed that bc-java can parse the java.security property for custom DH groups (jdk.tls.server.defaultDHEParameters), but then does not use it in DHE-based TLS connections. The feature may be useful to anyone who needs to connect to legacy devices or in environments with prescribed DH parameters. I created a little patch for ProvTlsServer that fixes this, and will provide it as a PR (see #1298). Let me know what you think, and if you need me to change anything.

Resolved by #1298 .


fix(inst): using module utils

:tada: This PR is included in version 1.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(tests): unit all the tests

Split controller to separate file.

Easier to reason about in tests.
Easier on the end user should he/she want to modify/extend said controller.

Add gulp karma #single-run
Add gulp watch:karma #no-single-run

Some issues/possible issues I found (read: created) while having some fun with tests;
implementation

I suppose the below points (barring the first) could all be design choices for all I know. Though the JSDOC would suggest otherwise.

module definition should probably happen in its own file now that there are multiple ones (opinion).
choice is not ensured in this.highligt.
choice is not ensured to follow the correct structure in this.label.
choice is not ensured in this.encode.
choice is not ensured to follow the correct structure in this.encode.
match is not ensured to be a regex.exec() in this.search.

specs

ctrlInstance is a sh*tty name. why did I go there.

$mention?
Subject?
ctrl?

Lines 294-317 of mentionController.es6 are completely untested.
keyboard events s-ck in phantomjs (switch to browser launchers?)
$element.scrollHeight testing is sort of wonky.
A lot of the tests could probably be simplified with the help of some more ES6.

build

Multiple use stricts s-ck, "Gee, thanks kasper..."

Figured I'd post this before spending too much time on taking care of the aforementioned points. Not even certain you would want to roll Mocha > Jasmine, so this may all have been a couple of hours of all-fun no-work. I'm cool with that!

Ain't nobody got time for that.

but but, I like testing... :hushed:

Doing a quick sanity check before going to bed here. Some of the tests are malicious in that they create expectations on the internal dependency between the exposed API methods.
Which is not good as it:

Is brittle.
Makes any sort of refactor harder.

input and ouput is the name of the game. Anything inbetween is silly. I'll give the suite a touch up in the morning.

@kasperlewau is this a one-time thing or would you be interested in becoming the repo maintainer?

@ProLoser I wouldn't say this is a one-time thing, as I have slowly started dabbling with #2 as well as handling the aforementioned issues in this PR. Got some more ideas floating around in my head as well that I would like to see handled at some point, they sort of tie into the idea of being able to customise the API.
I think this is a good starting point as I'm not (yet) fully up to speed with all the bits and bobs of the codebase, so having a reliable test suite will only ever assist me (and others) in future development.
With all of that said, I'm not necessarily interested in becoming the maintainer of the repo at this time, but I'm certainly not ruling it out for the future. I would have to have a little think about it.
I hope that's not the answer you were not looking for.

@kasperlewau i would test what the methods currently do to ensure they do their job properly. If people override the methods then those tests are isolated, so I don't really understand what the issue is too much.

@ProLoser I am all for testing what the methods are currently doing, what I am not for is what I previously did in testing the corrolation between the exposed API methods.
Take the following (somewhat silly example) for instance;
function a (wat) {
  b(wat);
}

function b (watwat) {
  watwat = `${watwat}something`
}

var bar = 'bar';
a(bar);

Instead of testing that function a called function b, the expectation should be that bar is now barsomething, if that makes any sense. If you take a look at my latest commit, a lot of spies were used to test the execution of another function, as opposed to testing the output.

The issue is not so much in regards to when and if a consumer modifies one of the exposed API methods, so much as it being a bad practice (from where I'm coming from) when one comes around to refactor any of these exposed methods.
So with that, I could put some more effort into it and write expectations on the result of calling another API method internally, as opposed to the actual call. That's just something not worth testing, and I'm sort of poking my head as to why I did that in the first place. Perhaps I got carried away.
I'm sorry, I'm rambling. I'm going to grab my friday beer and sit down with the specs in a wee bit. :beers:


Bug? Feature?: Start up pomodoro with IPC mode by specifying the option

Description
While using it, I found that I wanted to make ipc command but I sometimes typed pmdr by mistake. Then what it happened is running pomodoro's ipc socket is closed. (Because newly running pomodoro app - by pmdr command - deleted existing file..)
To prevent this, let's run pomodoro app with certain option if user wants IPC feature.
Maybe --ipc flag would be enough?

Maybe it's good to detect address is already used by other running pomodoro or not. So I proposed this

When start up pomodoro, make ping message to address. If pong is received, that means pomodoro is already running and using that address. So newly start up is done without ipc support. (Respect already running pomodoro applicaiton)
Message Ping and Pong is needed in this scenario
[ ] next step: provide connect and disconnect commands to dynamically use ipc feature


Incorrect parsing of ocamldoc, module doc gets attached to first declaration

This try reason link illustrates the issue.
I tried to document my module in .rei file and was unable to make odoc generate html which included module level documentation. I've refmt-printed my .rei to .mli, and found that documentation got attached to first declaration in my module. I've manually added doc comments to .mli, generated documentation and it included module level doc as expected.
dune version: 1.10.0
esy version: 0.5.6
refmt version: Reason 3.3.7 @ 43efc14

Looks like adding ; after module-level comment fixes parsing. I figured it out while trying to parse correct .mli back to .rei and noticed that refmt added that ;. Illustrated in this try reason link.

I've opened an issue in odoc project for this as well, as I'm not sure about the root cause of doc being ingnored.
If I try to generate doc from .mli which was printed from .rei with aforementioned workadound, module level doc gets ignored by odoc for .mli file as well. Looks like that [@@@ocaml.doc "..."] is not understood by odoc.

Glancing at output of ocamlc -dparsetree for both refmt printed .mli and hand-written .mli with semantically same content, there is difference in Psig_attribute, for native hand-written comment it's "ocaml.text" while for refmt generated one it's "ocaml.doc".

In case it's important,  I'm using OCaml 4.06.0.

For others running into this issue: workaround to get docs done:
<EMAIL_ADDRESS>"
{1 Overview}

This moduleimplements <....>
<....>
"];

/** This is some type t */
type t;

/* rest of your module <.....> */

Just to add to the findings...

The<EMAIL_ADDRESS>solution works! Thank you!
I can't seem to use {1 Heading} style comments in reason syntax at all unless I use<EMAIL_ADDRESS>...] instead of /** ... */

I believe that has nothing to do with Reason. ocaml.text is floating module level documentation, while /** ... */ that is attached to certain ast nodes is ocaml.doc, and the latter probably does not support multi-section formatting, which makes sense.
Btw, you could use<EMAIL_ADDRESS>{| ... |}] to avoid issues with escaping '"' inside the documentation (if you have a snippet of code inside for example).

Isn't the issue that you need a semicolon after the first comment?

I'm told there's two issues. One is the semicolon (that's easy to teach people) and the other is that we need to correctly translate free floating doc comments that have semicolons. Should be an easy fix.


Change text in backup reminders

Task description
The text in the backup reminders has to be changed a little bit. It affects the reminder on new account and the "Welcome back" reminder shown on update, the warning of the other reminders are dismissed and the banner shown, when accounts have not been backed up.  The new texts can be seen in the screenshots below, and can be copied here from within the  Figma link below.
If possible, we'd also like the exported backup file renamed to "concordium-backup.concordiumwallet".
https://www.figma.com/file/pUlYPsHRU0Hvm0NoGIvxrv/Mobile-Wallet?node-id=2860%3A13745
On new account:

On updating the wallet app:

[x] new account
[x] update
[x] rename file

Verified on CDD app 1.2.6(69), Android 9, Huawei Y6s


docs(README): fix typo

While v6 is just around the corner, I think it is still worthwhile to fix the current page.

Thanks you!


Bug: When using WindowsEx class, closed application crashes on launch when activated from notification.

If there is a WindowEx window in the project, the application that is not running crashes when the notification is clicked and also when the application is started with the argument ----AppNotificationActivated:.
When Native Code Debugging is enabled it gets me there:

Seems like m_activatedEventArgs and m_waitHandleForArgs are null.
Looks like the window object does not even have to be created for the bug to happen. This happens in packaged in unpackaged modes.
I'm also created issue in WinAppSDK repo (https://github.com/microsoft/WindowsAppSDK/issues/3535) before I knew about the WindowEx bug.

I think I've found the problem. When WebAuthenticator is initialized, it gets activated arguments:

However, as stated in the MSDN docs (https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/notifications/app-notifications/app-notifications-quickstart?tabs=cs#step-3-register-to-handle-an-app-notification), you cannot call GetActivatedEventArgs() before the AppNotificationManager is registered. If OnAppCreation is commented out in the Init method, everything works fine.

You cannot call GetActivatedEventArgs() before the AppNotificationManager is registered.

According to https://learn.microsoft.com/en-us/uwp/api/windows.applicationmodel.appinstance.getactivatedeventargs?view=winrt-22621 you can call it before even App.xaml gets called and samples shows it called in the main method:

I this the above statement only applies if you use app notifications.


wasmtime: Add libc as a dependency on FreeBSD in the jit-icache-coherence crate

👋 Hey,
This gets this package to build for x86_64, but does not include any cache clearing for aarch64-freebsd. Which will probably build, but not work.
As far as I can tell membarriers are still in the process of being added.
See: https://reviews.freebsd.org/D32360
Since FreeBSD is mirroring the Linux membarrier syscall we may be able to reuse the same implementation for both Linux and FreeBSD for AArch64.
I wasn't able to test FreeBSD directly but cg_clif builds and passes its tests with this commit applied to the v3.0.0 tag. (CI)
Fixes: #5308
cc: @bjorn3

Thanks!

I wasn't able to test FreeBSD directly but cg_clif builds and passes its tests with this commit applied to the v3.0.0 tag.

That is enough for my purposes :)


add output formatting for translation jobs

Currently, when the user requests translation they're forced to receive their translation in the srt format. For users consuming their Runpod worker and changing which key they respond with based on if a translation was ran, it is currently impossible to respond with easily human readable translations without implementing an srt parser.
To fix this I've added a new input, translation. Which allows the user to pass any of the same options they would to transcription.
I've also renamed the existing format_segments function to serialize_segments, as that's a more accurate name, and introduced my own format_segments in it's place.

Whoops :)
Wanted to rename main so that I can continue working on this fork without disrupting this PR, didn't work out the way I wanted it to... reopened.


esp32-hal-bt.h: No such file or directory

I'm having issues trying to compile NimBLE, but it works fine when I try using platformio/platform-espressif32 6.8.1.
I'm using the following repo https://github.com/h2zero/esp-nimble-cpp.
These are the steps I've taken:
-Extracted esp-nimble-cpp-master.zip to idf components directory
-Start with espidf-arduino-blink project
-Enabled Bluetooth (Menuconfig>Components>Bluetooth)
-Enabled NimBLE only (Menuconfig>Components>Bluetooth>Host)
-Verified ESP-NimBLE-CPP configuration is visible (Menuconfig>Components)
This is the error. I checked the include path and can see ".../.platformio/packages/framework-arduinoespressif32-src-98cb8087edcca5875bec152528484d34/cores/esp32" is there.
C:/Users/User/.platformio/packages/framework-espidf@src-4f6948c6ced199d051593b27bfeae287/components/esp_nimble/src/NimBLEDevice.cpp:52:12: fatal error: esp32-hal-bt.h: No such file or directory
Any idea on what I'm missing?
platformio.ini
[env]
platform = https://github.com/pioarduino/platform-espressif32.git#develop
framework = arduino, espidf

board_build.embed_txtfiles =
    managed_components/espressif__esp_insights/server_certs/https_server.crt
    managed_components/espressif__esp_rainmaker/server_certs/rmaker_mqtt_server.crt
    managed_components/espressif__esp_rainmaker/server_certs/rmaker_claim_service_server.crt
    managed_components/espressif__esp_rainmaker/server_certs/rmaker_ota_server.crt

[env:esp32-s3]
board = esp32-s3-devkitc-1

Blink.cpp
#include <Arduino.h>
#include <NimBLEDevice.h>

void setup() {
    Serial.begin(115200);
    NimBLEDevice::init("");
}
void loop() {
    Serial.println("Hello!");
    delay(1000);
}

Output
Processing esp32-s3 (board: esp32-s3-devkitc-1; platform: https://github.com/pioarduino/platform-espressif32.git#develop; framework: arduino, espidf)
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------Verbose mode can be enabled via `-v, --verbose` option
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/esp32-s3-devkitc-1.html
PLATFORM: Espressif 32 (51.3.3+develop.sha.2ebdc63) > Espressif ESP32-S3-DevKitC-1-N8 (8 MB QD, No PSRAM)
HARDWARE: ESP32S3 240MHz, 320KB RAM, 8MB Flash
DEBUG: Current (esp-builtin) On-board (esp-builtin) External (cmsis-dap, esp-bridge, esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES:
 - framework-arduinoespressif32 @ 3.0.3
 - framework-arduinoespressif32-libs @ 5.1.0+sha.ecdd485305
 - framework-espidf @ 3.50104.0 (5.1.4)
 - tool-cmake @ 3.21.3
 - tool-esptoolpy @ 4.7.5
 - tool-mklittlefs @ 3.2.0
 - tool-ninja @ 1.9.0
 - tool-riscv32-esp-elf-gdb @ 11.2.0+20220823
 - tool-xtensa-esp-elf-gdb @ 11.2.0+20230208
 - toolchain-esp32ulp @ 1.23500.220830 (2.35.0)
 - toolchain-riscv32-esp @ 12.2.0+20230208
 - toolchain-xtensa-esp32s3 @ 12.2.0+20230208
Warning! Arduino framework as an ESP-IDF component doesn't handle the `variant` field! The default `esp32` variant will be used.
Reading CMake configuration...
Warning! Flash memory size mismatch detected. Expected 8MB, found 16MB!
Please select a proper value in your `sdkconfig.defaults` or via the `menuconfig` target!
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 56 compatible libraries
Scanning dependencies...
Dependency Graph
|-- WiFi @ 3.0.3
Building in release mode
Compiling .pio\build\esp32-s3\src\main.cpp.o
Compiling .pio\build\esp32-s3\esp_nimble\src\NimBLEDevice.cpp.o
Compiling .pio\build\esp32-s3\esp_system\debug_stubs.c.o
Compiling .pio\build\esp32-s3\esp_system\task_wdt\task_wdt.c.o
Compiling .pio\build\esp32-s3\esp_system\task_wdt\task_wdt_impl_timergroup.c.o
Compiling .pio\build\esp32-s3\esp_system\port\cpu_start.c.o
Compiling .pio\build\esp32-s3\esp_system\port\panic_handler.c.o
C:/Users/User/.platformio/packages/framework-espidf@src-4f6948c6ced199d051593b27bfeae287/components/esp_nimble/src/NimBLEDevice.cpp:52:12: fatal error: esp32-hal-bt.h: No such file or directory

**********************************************************************
* Looking for esp32-hal-bt.h dependency? Check our library registry!
*
* CLI  > platformio lib search "header:esp32-hal-bt.h"
* Web  > https://registry.platformio.org/search?q=header:esp32-hal-bt.h
*
**********************************************************************

   52 | #  include "esp32-hal-bt.h"
      |            ^~~~~~~~~~~~~~~~
compilation terminated.
Compiling .pio\build\esp32-s3\esp_system\port\esp_system_chip.c.o
Compiling .pio\build\esp32-s3\esp_system\port\brownout.c.o
*** [.pio\build\esp32-s3\esp_nimble\src\NimBLEDevice.cpp.o] Error 1

This is not a good idea:
-Extracted esp-nimble-cpp-master.zip to idf components directory
This is not a Platform bug or issue! Your setup is "just" wrong!

@thekurtovic  Changed an example here https://github.com/Jason2866/platform-espressif32/tree/test/examples/espidf-arduino-littlefs
Don't get irritated by the folder name. It uses h2zero NimBLE as component and compiles a BLE scan example.

This was how I was doing it on arduino-esp32 v2, and platform 6.8.1.
I thought it would work since pioarduino adds arduino-esp32 v3 support. Shouldn't it work with pioarduino if platform 6.8.1 works?
What is the difference between jason2866/platform-espressif32 and pioarduino/platform-espressif32?
Your example works but now there's no WiFiClientSecure.

Yes, there are differences. No it will not work with pioarduino since there are incompatible BLE libraries in Arduino. This BLE libs and others, like WifiClientSecure are removed in my fork jason2866/platform-espressif32.
To use WifiClientSecure working pioarduino can be choosen and the Arduino framework needs to be replaced with a version where ALL BLE libs are removed.
In short, there is currently no existing fork where NimBLE and WifiClientSecure are both possible.

@thekurtovic  Solved :-). See example https://github.com/pioarduino/platform-espressif32/tree/develop/examples/espidf-arduino-h2zero-BLE_scan

I see, I think I understand now.
Thanks for the new example, helps a lot.
Off topic:
I'm wondering where all these other stuff inside managed_components is coming from. Looks like all the espidf-arduino-... examples have them after compiling. Is it possible to exclude the unused ones or is this how IDF 5 with core 3 is supposed to be? I tried to remove them from dependencies.lock but then build fails.

Exactly as you wrote in your Edit. The YML file is responsible for. The IDF component manager scans this file and install the listed parts.


Can't use a component called

Version
2.4.4
Reproduction link
https://jsfiddle.net/stowball/uchcrwt0/
Steps to reproduce

Create a component called 'filter'
Add it to a VM

Error in the console:
[Vue warn]: Do not use built-in or reserved HTML elements as component id: filter

var app = new Vue({
   el: '#app',
   components: {
       'filter': {
           template: '
:(
'
       }
   }
});

    <filter />

What is expected?
To be able to use any reasonable name for a component, of which 'filter' is one, and have it render.
What is actually happening?
The 'filter' component is not rendered.

Just as what the warning message said, <filter> is a valid SVG element and is reserved, you should use another name instead of filter.

D'oh! I was like "but there is no filter HTML element". SVG didn't even occur to me. Sorry!

I'm a bit surprised namespaces are ignored, but hey ho.


Set Dash.js log level depending on DebugTool log level

📺 What
Set the Dash.js debug player settings depending on the overall library log level.
🛠 How

Adds new getLogLevel() function to DebugTool and player API
Sets Dash.js player settings for debug based on the LOG_LEVEL set

INFO = { logLevel: 2} dashjs.Debug.LOG_LEVEL_ERROR - Log error messages.
VERBOSE = { logLevel: 5, dispatchEvent: true} // dashjs.Debug.LOG_LEVEL_DEBUG - Log debug messages.

Just realised tyou prolly hadn't opened for review yet 😅 I saw the PR in our Slack channel and autopilot assumed you were requesting review sorry!

One problem with this is that you will need to set VERBOSE before starting playback using Dash.js. This mechanism doesn't currently update player settings in Dash.js should the log level be set to VERBOSE mid-stream.
Options:

We could figure out a way to update the player settings (using dash.js updateSettings() function) whenever setLogLevel is called
Not do this PR and just rely on people knowing that in order to get Dash.js debug logs, you need to set log level to VERBOSE and set the player settings before starting the stream
Do this PR but people will need to know that if you set log level after setting up the media player, then the dash.js log output won't be logged.


Staff page, user block works after page reload

Goto staff page click block button of one staff, no effect.
after page reload it work properly.

Same problem occurred while staff delete


Sheet Approver doesn't update

We have an issue with the sheet approver in the QMC utilities. The data is stuck in a state from some time yesterday afternoon. Until then we can't recall any issues. Yesterday afternoons data must have gotten in there somehow as well, after all.
I imported an app yesterday and have since published it several times under various names into various streams. But the sheet approver still claims (and has done so all the time inbetween) that the app is stuck in the "work" area.
To clarify: in this particular case the app is published with all its sheets, but in the Sheet Approver it still shows with "Not approved" and "Not published".
What have we already tried?

reloading the page (obviously) :-)
restarting all the services (any Service that starts with Qlik)
removing the QMC Utilities (Uninstall.exe, sc delete QlikEAPowerToolsServiceDispatcher, remove "C:\Program Files\Qlik\Sense\EAPowerTools" path manually, restart server (the entire machine)) and reinstalling (both 2.0.0 and 2.0.1)

What else can I contribute?

the repository shows correct information (we have an app, which directly accesses the Repository DB)
the same data from yesterday afternoon was displayed again even after re-installation
the certificates are available at "C:\ProgramData\Qlik\Sense\Repository\Exported Certificates.Local Certificates"

P.S. A few app imports and days later (that's when I checked again) the information was indeed updated. So I have repeated the process with a different app now and we have the same issue. Publish app, see the app in the new stream, check Sheet Approver and be told that it is still in the work area.

@SandroK, can you send some screenshots?  what version of Qlik Sense?

The browser cache seems to have been the problem. Turning it off (by requesting new items on every website visit) has solved the issue. I'll leave this open, as maybe there is room for improvement to avoid this kind of problem in the future. If you still need screenshots, let me know. It's Qlik Sense 3.0.4

I'm surprised this was an issue, but we will look into it.

@SandroK, I've updated sheet approver to be app object approver.  Please try it and see if it resolves the updating problem.  I was not able to recreate this issue.
2.02 Installer


GitOps Script - if not nogged in the script run anyways.

Overview of the issue

Motivation for or Use Case

Reproduce the error

Related issues

Suggest a Fix

NubesGen Version(s)

Browsers and Operating System

This is fixed in the new NubesGen-cli project https://github.com/jdubois/nubesgen-cli


[WIP] Allow to load files from JS profiles from Lua scripts

This should fix https://github.com/scrapinghub/splash/issues/143.

Current coverage is 84.42%

Merging #292 into master will increase coverage by +0.17% as of f8e618d

@@            master    #292   diff @@
======================================
  Files           37      37
  Stmts         4085    4097    +12
  Branches       531     531
  Methods          0       0
======================================
+ Hit           3442    3459    +17
+ Partial        150     144     -6
- Missed         493     494     +1

Review entire Coverage Diff as of f8e618d

Powered by Codecov. Updated on successful CI builds.


Design QA - Report on this market Modal

Styles for the modal are different from design:

Figma Reference:
https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=8355%3A280825

@phoebemirman Figma link with interaction states https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=7396%3A94023

Different styles:

Tooltip is not aligned "?"

Outcomes are gray by default. Right now seems bigger than should be, and the text is not vertically-aligned.

Hover state is incorrect. Border should be dark gray. For full reference of this component, please check:

https://www.figma.com/file/42QoTLQcbObu7esoTPjWRv/Augur-Bet-Design-System?node-id=561%3A4371

Add space between Max / Clear buttons. 16px should be enough

The bottom margin should be bigger: 24px

Still need to fix the text styling here

Compare with design below:

Labels should be caps
space between resolution details label and text underneath need increasing
Font style of dates

Figma link https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=8355%3A280825

looks good


Light and Dark mode added

Description

...Light mode button is added.
...By clicking on the icon in the header, dark mode can be switched to light mode and vice-versa.

Related issue(s)
Resolves #69

Hey @tokyo3001 can you send a video or gif for the same ?

https://user-images.githubusercontent.com/84511419/194635874-eb33db62-fdad-4c05-a105-e7ec9c0f2527.mp4

Is it working fine for different size screens too?
Is the responsiveness working fine?
Will be glad to merge your pr.

Is it working fine for different size screens too? Is the responsiveness working fine?
Will be glad to merge your pr.

@VG-1  It is working fine for different screen sizes and responsiveness is also fine.

Great @tokyo3001 . It will be great if you can send a video for the responsiveness too. Inspect and try to change the screen sizes there. Will be happy to merge your PR.

https://user-images.githubusercontent.com/84511419/194707205-8991b7cc-c9cb-4a80-8b25-4d036fb4f1b8.mp4


Rename: java-build-system-cnb?

Perhaps helpful to prefix project title with java-? I think its a "build system" for java only? Sorry if I'm misunderstanding.

Well it won't be Java-specific (JVM-specific is more accurate), but I'm not inclined to make the change until we see another conflicting repository be proposed.


Update Java/Kotlin formatter and reformat codebase

A good moment to do this would be after the 0.27 release.

Aside from the license doc-blocks that have now been fixed; what are you expecting as the biggest changes?
Certainly for this.

Latest ktfmt version formats some files differently. I figured this should be a separate PR and didn’t bump the ktfmt version when I updated library versions in a recent PR.


"Disconnected from slack, trying to reconnect..."

I'm trying to get this set up, and I'm sure I'm just doing something foolish. I get this over and over in the weechat window. I've gotten an API token and /set it in the config.
14:15:55 SYSTEM | Disconnected from slack, trying to reconnect..
14:15:58 SYSTEM | Disconnected from slack, trying to reconnect..
14:16:01 SYSTEM | Disconnected from slack, trying to reconnect..                                                                          14:16:04 SYSTEM | Disconnected from slack, trying to reconnect..
14:16:07 SYSTEM | Disconnected from slack, trying to reconnect..
14:16:10 SYSTEM | Disconnected from slack, trying to reconnect..

Debug output is only: 14:15:54 | DEBUG: connected to pixar.slack.com
Thanks for any help.

give it another shot with the new version. there is also a chance that curl isn't installed on the machine. make sure you can run curl www.google.com successfully

The new version still had this problem. I did some sleuthing and traced this down to a old version of websocket-client (0.14.0). I updated to the latest (0.32.0) and it all works. Sorry for the trouble!

Oh! this is excellent info. I should mention a version of websocket-client in the README!

The except here: https://github.com/rawdigits/wee-slack/blob/master/wee_slack.py#L247 was masking the error. Weechat users on our team will love this! Thanks again.

much appreciated! printing the exception now: https://github.com/rawdigits/wee-slack/commit/48988c464e54bad25323487bc875f0f3d88b9b24

The new 0.34.0 version of websocket-client will not work either. I get the same error message, but no debug output with it. Downgrading to 0.32.0 works.

@Yavor-Ivanov you probably have the issue described here: https://github.com/rawdigits/wee-slack/issues/122


after upgrade ,ticdc changefeeds lag increase

What did you do?

rolling upgrade from 7.0 to master

What did you expect to see?
No response
What did you see instead?

changefeeds' lag increase

Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):
(paste TiKV version here)

TiCDC version (execute cdc version):
sh-5.1# /cdc version
Release Version: v7.1.0-alpha
Git Commit Hash: f5bd7d4743cc5df6a7f6bc84c2175f0129aa896c
Git Branch: heads/refs/tags/v7.1.0-alpha
UTC Build Time: 2023-03-29 02:58:15
Go Version: go version go1.20.2 linux/amd64
Failpoint Build: false
(paste TiCDC version here)

/severity critical

tidb sink downstream's pd is in disk default, causing tidb sink error, which is not releated to ticdc

/remove-label affects-7.1

/close


DB query caching

Currently we manually cache views of interest, e.g., workflows mined from the GitHub API, user profiles retrieved from GitHub and Terrain, stats & aggregations, etc. This doesn't include the DB yet though. Since it's a network hop it makes sense to cache DB reads too.
Seems like this might work: https://github.com/Suor/django-cacheops

Added in f27e694


Periodically check for context cancellation in WinHTTP transport adapter when uploading and downloading data over the wire.

Currently, from https://github.com/Azure/azure-sdk-for-cpp/pull/897, we are not always checking for the context cancellation during data upload.
It might be valuable to also leverage the winhttp options to pass-along the context timeout as part of the network I/O requests, as long as it cancellation is per request and not per connection/session.
https://docs.microsoft.com/en-us/windows/win32/winhttp/option-flags

WINHTTP_OPTION_RECEIVE_RESPONSE_TIMEOUT

Sets or retrieves an unsigned long integer value that contains the timeout value, in milliseconds, to wait to receive all response headers to a request. If WinHTTP fails to receive all the headers within this timeout period, the request is canceled. The default timeout value is 90 seconds.

This timeout is checked only when data is received from the socket. As a result, when the timeout expires the client application is not notified until more data arrives from the server. If no data arrives from the server, the delay between the timeout expiration and notification of the client application could be as large as the timeout value set using the dwReceiveTimeout parameter of the WinHttpSetTimeouts function.

WINHTTP_OPTION_RECEIVE_TIMEOUT

Sets or retrieves an unsigned long integer value that contains the time-out value, in milliseconds, to receive a partial response to a request or read some data. If the response takes longer than this time-out value, the request is canceled. The default timeout value is 30 seconds.

std::unique_ptr<RawResponse> WinHttpTransport::Send(Context const& context, Request& request)
{
  // TODO: Need to test if context has been canceled and cleanup, can't call ThrowIfCanceled.
  (void)(context);

  auto handleManager = std::make_unique<Details::HandleManager>(context, request);

  GetSessionHandle(handleManager);
  GetConnectionHandle(handleManager);
  GetRequestHandle(handleManager);

  SendRequest(handleManager);

  ReceiveResponse(handleManager);

  return GetRawResponse(handleManager, request.GetMethod());
}

@LarryOsterman this issue is likely relevant for the WinHttp work you are doing.


[REQUEST Membership]: New membership for zhaodiaoer

GitHub Username
@zhaodiaoer
Organization you are requesting membership in
openyurtio
Sponsors
@rambohe-ch
Requirements

[X] I have joined in the community Dingding and [WeChat]
[X] I often attend Openyurt Community Week
[X] I have reviewed the [community membership docs]
[X] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[X] I have checked my affiliation in devstats (if it's not correct, please fix in cncf/gitdm)
[X] I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

PRs reviewed / authored:
https://github.com/openyurtio/openyurt/pull/832
Issues :

Brief Introduction
Hello everyone, my name is zhaodiaoer, I am currently working on k8s & container releated work, I hope to become a member of openyurt community, thanks.

@zhaodiaoer Welcome you to apply OpenYurt community member. agree +1

agree +1

agree +1

agree+1

agree+1

agree+1

@zhaodiaoer Congratulations you to become a member of OpenYurt community. We have sent a github message to invite you as member of OpenYurt, please check the message. and after joining member of OpenYurt, you need to check two points in this issue https://github.com/openyurtio/community/issues/14

@rambohe-ch  I have completed these tasks, thank you all guys :D


ERROR: Unable to extract uploader id

Checklist

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dl version 2021.12.17
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

PS D:> youtube-dl --verbose https://www.youtube.com/watch?v=BaClCM45k3Q
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.youtube.com/watch?v=BaClCM45k3Q']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 5.1.2-essentials_build-www.gyan.dev, ffprobe 5.1.2-essentials_build-www.gyan.dev
[debug] Proxy map: {}
[youtube] BaClCM45k3Q: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 534, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
PS D:>
Description

WRITE DESCRIPTION HERE
Tried serveral videos, all the same.

https://github.com/ytdl-org/youtube-dl/issues/31530

Just got the same error, by adding the verbose flag I get:
youtube-dl "https://www.youtube.com/watch?v=iahcJPo9Dwg" --verbose [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['https://www.youtube.com/watch?v=iahcJPo9Dwg', '--verbose'] [debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8 [debug] youtube-dl version 2021.12.17 [debug] Git HEAD: 4d0154fa7 [debug] Python version 3.11.2 (CPython) - macOS-13.2.1-arm64-arm-64bit [debug] exe versions: ffmpeg 5.1.2, ffprobe 5.1.2, rtmpdump 2.4 [debug] Proxy map: {} [youtube] iahcJPo9Dwg: Downloading webpage ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last):   File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper     return func(self, *args, **kwargs)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info     ie_result = ie.extract(url)                 ^^^^^^^^^^^^^^^   File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 534, in extract     ie_result = self._real_extract(url)                 ^^^^^^^^^^^^^^^^^^^^^^^   File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/youtube.py", line 1794, in _real_extract     'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/opt/homebrew/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 1012, in _search_regex     raise RegexNotFoundError('Unable to extract %s' % _name) youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Also: #30839.


added restart handlers to look at the master-restart instead of the rpm version

@mbarnes approved #3851


Add support for topics in direct message conversations

Topics are great, and I often notice myself wanting them in a (possibly group) private message conversation with someone.
Currently, we don't support that, primarily because of UI design considerations.  For 1-on-1 PMs, it's pretty easy to figure out how to do this in the visual design, but with a group PM with a lot of people, it's not clear how to make this look right.
It'd be great to figure out a plan for how we can make this work.

#1186 tries to tackle the group PM problem from a slightly different angle, basically to try to create a notion of private streams.  If we could have topics on groups PMs, that would probably make #1186 more of a moot point.

This would be very useful for my organization; is there an ETA or has any progress been made on adding support for streams in PMs? Since 1-on-1 PMs are pretty easy, maybe implementing that part of it first would be possible? I can see a strong use case for topics in 1-on-1 PMs but less of a use case in Group PMs.

There's no ETA for this.  That said, it's worth mentioning that you can just create a private stream for the 2 people as a workaround.

There's no ETA for this. That said, it's worth mentioning that you can just create a private stream for the 2 people as a workaround.

In my opinion, this can be considered not as a workaround but as a right way (as a more general case): If you have talked with someone in a private stream (1-on-1) and assigned a topic, it means the conversation is mostly likely important and structured. Then some day you may want to add one more person to this conversation to collaborate. If it would be only PM channel, then it's not possible to invite someone else to the conversation in case of a need, right?

There's no ETA for this. That said, it's worth mentioning that you can just create a private stream for the 2 people as a workaround.

In my opinion, this can be considered not as a workaround but as a right way (as a more general case): If you have talked with someone in a private stream (1-on-1) and assigned a topic, it means the conversation is most likely important and structured. Then some day you may want to add one more person to this conversation to collaborate. Otherwise (in case of only PM channel), it would not be possible to invite someone else to the conversation in case of a need, right?

I think this is true in some conversations but not others. It is also worth noting that if your Zulip instance is configured to only allow administrators to create new streams, creating a private stream for the two people would require an administrator to get involved which is too much of an administrative delay in my use case.

Hi,
any news to this feature request? we would like it also ^^
Thx!
Erik

Thanks for noting your interest! We have no updates or short-term plans here.

+1 here.
A possible design approach as tool for thought: what (anything) can be a problem if we use the same model of streams to work on private channels/DMs?
The only difference I know of is that the latter are user created (not admin created), but the rest could be the same, including the possibility to create (or not) a message without topic.
WDYT?


Change the way we detect the beginning of a new student sheet to allow the insertion of extra pages if required for a set of student

https://stackoverflow.com/questions/70559776/tesseract-js-problems-recognising-numbers


Need config/frontmatter syntax

I opened an issue for config and comment syntax (#12), but then went off the rails and focused 100% on comments.
So, as for a config syntax, in order to meet what dart_style uses today, we should just provide a front matter parse, similar to Jekyll front matter, but with less ceremony.
How about: text that precedes the first >>> is front matter:
40 columns                              |
>>> split all chained calls if they don't fit on one line
input
>>>
output

Each DataCase yielded by expected_output for this data file can include a member, frontMatter, which is just the raw text found before the first >>> (40 columns                              |). This should work fine with dart_style's usage, although may slow down testing in that the test needs to parse 40 columns                              | once per test case, rather than per file (not a big slow down).

WDYT @munificent @pq

I'm slightly inclined to suggest something explicit like Jekyll's triple-dashes to make it super obvious that this is front matter and not a mistake but don't feel strongly either way.
PS: Neat!

If we do something more structured like that, we can maybe satisfy the nice readability of
40 columns                              |

and yield key/value pairs as config, and allow comments?
---
// 40 columns                           |
pageWidth: 40
---
>>> test case 1
input
<<<
expected output

which can add to a config member on each DataCase? {'pageWidth': '40'}.

I personally lean towards making the front matter implicit as any text before the first >>>. I'd like to minimize the amount of non-content text in these files to make them easier to read, write, and maintain if possible.
I haven't wanted any config properties yet, so allowing comments and key-values isn't useful to me. Maybe make that opt-in?


Added module dependence graph

Closes: #1635
What is the purpose of the change
As per the comment originally posted by @ValarDragon in #1621
We should make a visual dependency graph of the Osmosis modules in the x/README.md file.
Brief Changelog
Added a module dependency graph in the x/README.md file
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  [Osmosis docs repo](https://github.com/osmosis-labs/docs)   /   not documented)

Ah, I should probably go deeper on that then. Will revise & send a copy on by to you on slack, this is just a temporary edit / will be modified

I'm a bit worried about this being unmaintainable. Is there a way to make a link or source file other people can edit to update this in the future?

Yep, there is a way to make an editable copy - I exported the drawing as a loadable file (for future editing) that I will add to this PR

Suggestions:

Remove cfmm_internal - It has internal in the name!
Change Balancer tag line as "constant product AMM"
Change Stableswap tag line to just "stableswap AMM"
Change Gamm module tag line to "Swap, LP & CreatePool messages"
Change Superfluid staking tag line to "Allow Defi assets containing osmo to be used in staking"
Change epochs tag line to "On-chain timers, allowing modules to execute code once/day"

For Balancer and Stableswap, by chanigng the tag lines I meant the sub-text for it, its imo too long in the summary diagram. Balancer and Stableswap as the heading was good

Rendered link: https://github.com/osmosis-labs/osmosis/blob/xiangan/moddepgraph/x/README.md
Can we also reduce the vertical space used here?

Does anything come to mind for how to increase readability of the smaller text in the bubbles?
Beyond that, LGTM

I will be back after some dinner to try to make it less verbose and enlarge
the text / play with the formatting!
On Tue, Jun 21, 2022 at 5:40 PM Dev Ojha @.***> wrote:

Does anything come to mind for how to increase readability of the smaller
text in the bubbles?
Beyond that, LGTM
—
Reply to this email directly, view it on GitHub
https://github.com/osmosis-labs/osmosis/pull/1820#issuecomment-1162394824,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASH4FPRU5VNC5MYUE7I4Z43VQIZFBANCNFSM5ZCEKLXQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Fixed CS

Coverage increased (+0.05%) to 23.671% when pulling 7ce2d6c240b301d0a1dd73080d5ff55de360a18d on pierredup:cs-fixes into 9bbaa901f17d9e7539ac3927778f46525357c039 on CSBill:master.


Content validation for reactions.createForIssue has invalid regex

"^(+1|-1|laugh|confused|heart|hooray)$"
Need to escape the +.
"^(\\+1|-1|laugh|confused|heart|hooray)$"
Other might be affected too.
Example
https://github.com/mikedeboer/node-github/blob/d6aee8b1e8bfa56d536d9ebb094f9afc4ac59b20/lib/routes.json#L3619

This prevent usage of those apis.

Thanks. Fix pushed in 2.5.2 (https://www.npmjs.com/package/github). (forgot to reference issue in commit)


JWT validation pattern with jku and kid claims

Hi @nenaraab,
In SAP Cloud SDK, we're integrating your library to handle XSUAA authentication topics.
Currently, we're fixing JWT validation that fails because of this change: tenant specific JWT signing keys
In regard to this, I have a couple of questions to ensure our implementation is secure and compliant:

How do you ensure jku is from a whitelisted domain? Should we ensure it on Cloud SDK side?
As I understood from the sources you consider jku trusted after ensuring that issue is trusted by checking iss?
Does XSUAA always provide jku and kid to fetch the public key for token validation? Or it can also be only jku?
If a mocked or testing server is used to issue JWT how can we provide a URL of this issuer to make validation work for running tests locally or other use cases requiring to override XSUAA as s token issuer?

Thank you in advance for your help! I hope this makes sense.
cc @MatKuhr @newtork
Best,
Artem

Hi @artemkovalyov ,
thanks for your request! You questions make perfectly sense!

jku is only accepted for XSUAA tokens and its domain is validated as part of the https://github.com/SAP/cloud-security-xsuaa-integration/blob/master/java-security/src/main/java/com/sap/cloud/security/token/validation/validators/XsuaaJwtIssuerValidator.java (the domain is part of the VCAP_SERVICES service binding)
XSUAA always provides a kid but IAS doesn't. So, until IAS provides no kid we have to use the dummy kid for caching.
In the future XSUAA might not provide jku, so the token endpoint needs to be looked up from oidc configuration endpoint.
Please consider the following library: https://github.com/SAP/cloud-security-xsuaa-integration/tree/master/java-security-test and the following sample: https://github.com/SAP/cloud-security-xsuaa-integration/tree/master/samples/java-security-usage

Does this answer your questions?
Nena

Thank you for the quick reply and detailed answer, @nenaraab, it clarifies a lot! Let me a bit of time to regroup with my colleagues and see if we might have any follow-up questions about potential edge cases.

Thank you, some follow up questions from my side:

Does the domain that is checked against include or exclude the tenant subdomain?
From the code I deduce that the caching of token keys is not isolated on a tenant-level. Is that correct and does that mean that we don't need to worry about tenant isolation when storing & applying public keys for JWT validation?
What is actually the oidc endpoint? I haven't encountered this term before. Does it refer to the "normal" XSUAA endpoint which is defined in VCAP services url property, so e.g. xsuaa.url.com/token_keys?

the domain from VCAP_SERVICES does not contain the subdomain of the paas tenant
The tenant's key-id / key-algorithm is cached per tenant specific jku: https://github.com/SAP/cloud-security-xsuaa-integration/blob/master/java-security/src/main/java/com/sap/cloud/security/token/validation/validators/OAuth2TokenKeyServiceWithCache.java#L159
oidc endpoint: https://xs2security.accounts400.ondemand.com/.well-known/openid-configuration. it relates to the xsuaa base url.

Thank you so much for your help!
We were pointed towards this post which indicates that reading the token keys from the jku is mandatory in a multi tenant setup. Together with the information you provided above I believe the following behaviour would be correct and are implemented by the XSUAA Java library:

If the jku property is present AND it points towards a resource on the XSUAA domain -> we try to fetch the token keys from there.

The results are cached, isolated by tenant
If there is a kid present then it is used to select the correct public key

Otherwise we use the oidc endpoint

As Artem said we are replacing our own implementation for JWT validation with the XSUAA Java library and need to understand possible changes in behaviour so that we can communicate that to our consumers clearly.

Hi,
Almost correct.
Currently, there is a restriction to Option 1 for tokens issued by XSUAA (also because it provides the jku). See also here: https://github.com/SAP/cloud-security-xsuaa-integration/blob/master/java-security/src/main/java/com/sap/cloud/security/token/validation/validators/JwtSignatureValidator.java#L108
Best regards,
Nena

Thank you so Nena much for the detailed information, that helped us a lot.
With that we were able to integrate the XSUAA library to perform JWT validation and first consumers reported that it works, so I think we can close this issue. Thanks again for the great & fast help 👍

Okay, cool. Thanks.
Happy to join for a code review if you like.

Thanks, that would actually be great.
We currently use the library like this:
final Token token = new XsuaaToken(encodedJwt);
final OAuth2ServiceConfiguration xsuaaConfiguration = Environments.getCurrent().getXsuaaConfiguration();

if( xsuaaConfiguration == null ) {
    throw new AuthTokenAccessException("Unable to fetch XSUAA configuration from VCAP services.");
}
final CombiningValidator<Token> validator = JwtValidatorBuilder.getInstance(xsuaaConfiguration).build();

final ValidationResult result = validator.validate(token);
if( result.isValid() ) {
    return JWT.decode(encodedJwt);
}
throw new AuthTokenAccessException("The token is invalid: " + result.getErrorDescription());

In case this validation fails we fall back to our "old" implementation and try again. That way our own mocking still works and nothing can break for the consumer.
So far one of our consumers confirmed that this works. Next steps would probably be leveraging the mocking capabilites of the XSUAA lib to better test this and also to deprecate our custom implementation.

cool. Perfect and good migration idea :-)


when is the next release?

Eager to see the next release that supports latest Allure, Spock and Geb versions

Allure2 have own version of gradle plugin.
https://plugins.gradle.org/plugin/io.qameta.allure

but I think that Allure extension from qa meta does not support Geb

@rameshnatesan try to use Selenide - much better than Geb
https://github.com/selenide/selenide

@rameshnatesan Please try to add following to your buildfile with plugin io.qameta.allure
repositories {
    maven { url 'https://jitpack.io' }
}
configurations.all {
    resolutionStrategy {
        forcedModules = ['com.github.d10xa:allure-spock-geb:7f122b0a32']
    }
}
dependencies {
    testCompile "com.github.d10xa:allure-spock-geb:7f122b0a32"
}


[TF C API] Added TF_GetMutableOutput C API

C API to get the mutable output tensor is missing. This API is required by the TF Plugin for forwarding the input to output.
Signed-off-by: Chandra Kumar Ramasamy<EMAIL_ADDRESS>Reviewed-by: Aakar Dwivedi<EMAIL_ADDRESS>

@cramasam Can you please resolve conflicts? Thank you!

@cramasam Can you please resolve conflicts? Thank you!

I have resolved the conflicts. Thank you.

/cc @penpornk


Resolve interaction of "Normal Conditions" with other elements

All clear button
All clear ninja
Other incidents reported in the same station

Also maybe have a big plus in green to add those (instead of the regular report incident button)

Somehow related to #18 too?

Closing this, addressed with new decay feature. We can open up new issues to tweak it if we need to.


Tags and skills return data changed

Is your feature request related to a problem? Please describe.
The return data of the tags and skills is now serialized
# data presently returned
"tags": [
{
"name": "tag1"
},
{
"name": "tag2"
}

Describe the solution you'd like
I will be modifying the the mapping to adapt to the change

@itzomen please refer to the contributing guidelines before creating a PR or an issue.
You always forget to add them to the project board !!
https://github.com/divanov11/Mumble/blob/master/Project_Board.md

@itzomen please refer to the contributing guidelines before creating a PR or an issue.
You always forget to add them to the project board !!
https://github.com/divanov11/Mumble/blob/master/Project_Board.md

Oh Sorry, it always slip off my mind.

I think we are going to go forward with this schema.  The UI fix is here #409


Fuzzylite does not link with Visual Studio 2019

Describe the bug
The library Fuzzylite does not get reconised in visual studio. Get multiple errors about symbols missing.
Environment

OS: Windows
IDE: Visual Studio 2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install Fuzzylite
Copy example from their website: https://www.fuzzylite.com/cpp/
Fix their spelling error steer => mSteer
Compile
See error

Expected behavior
The program should repeatly loop though code with changed steer value. Works on Linux with non vcpkg.
Failure logs
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1120	3 unresolved externals	Fuzzylite_test1	C:\Users\mmaar\Google Drive\2.Skole\SDU-UNIVERSITET\5. semester\AI\Fuzzylite_test1\x64\Debug\Fuzzylite_test1.exe	1
Error	LNK2001	unresolved external symbol "private: static bool fl::fuzzylite::_logging" (?_logging@fuzzylite@fl@@0_NA)	Fuzzylite_test1	C:\Users\mmaar\Google Drive\2.Skole\SDU-UNIVERSITET\5. semester\AI\Fuzzylite_test1\Fuzzylite_test1\ObstacleAvoidance.obj	1
Error	LNK2001	unresolved external symbol "private: static int fl::fuzzylite::_decimals" (?_decimals@fuzzylite@fl@@0HA)	Fuzzylite_test1	C:\Users\mmaar\Google Drive\2.Skole\SDU-UNIVERSITET\5. semester\AI\Fuzzylite_test1\Fuzzylite_test1\ObstacleAvoidance.obj	1
Error	LNK2001	unresolved external symbol "private: static int fl::fuzzylite::_scalarFormat" (?_scalarFormat@fuzzylite@fl@@0HA)	Fuzzylite_test1	C:\Users\mmaar\Google Drive\2.Skole\SDU-UNIVERSITET\5. semester\AI\Fuzzylite_test1\Fuzzylite_test1\ObstacleAvoidance.obj	1

@Stretchyfish, thanks for reporting this issue!
I have summited PR #13807 to fix this issue.


Hyperparameter Tuning

Need to add in hyperparameter tuning for the VAE as well as the ability to hyperparameter tune the differentially private algorithm

Added in hyperparameter tuning notebooks for the SUPPORT set as well as the MIMIC set


Provide plain-text output

This is really great but for my use case I need a string output for hte words "thirty-seven"

Seconded, happy to open a PR to resolve this?