todoist-electron: 1.23.0 -> 1.24.0, update license, use desktop icon

Motivation for this change
Upstream repo added an MIT license. Also copies the icon over to $out so it's used in the .desktop file.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 101216 run on x86_64-linux 1

1 package built:

todoist-electron


Correctly escape single quote.

Replace ' with \(cq, as \' is different symbol. See smira/aptly#22 and rtomayko/ronn#21.

@rtomayko Would you please check this PR and merge?

We're also affected by this; we're using Ronn to generate ltsp.org man pages from markdown, and when we have a line like sed 's/one/two/', Ronn converts it to sed ´s/one/two/´, and users complain about syntax errors in man pages.

Hmm actually (cq isn't appropriate; this renders as RIGHT SINGLE QUOTATION MARK' (U+2019) which is still invalid code.
man ls on the other hand uses plain single quotes, NOT escaped, and they work fine.


Add synchronize_terminal_measurements transformer to replace SynchronizeTerminalMeasurements

Part of https://github.com/quantumlib/Cirq/issues/4722
Follows the new Transformer API https://github.com/quantumlib/Cirq/issues/4483
Supports no compile tags NoCompile Tag for optimizers #4253
Fixes #4907

@MichaelBroughton Added tests for CCOs which would fail for SynchronizeTerminalMeasurements but passes for the new synchronize_terminal_measurements


Add result of verify(jwt) to req?

So other middleware can use it? Would be nice to:
(req, res) => {
  doSomethingCoolWithUser(req.jwt.id)
  send(res, 200)
}

@tuckerconnelly would you consider make a pull request with the change?
Thanks

Boom https://github.com/kandros/micro-jwt-auth/pull/7


fix(italian): typo

tiny typo don't require a new build as can wait the next one when it will be.
I did a tiny video with a real GBA but I will do a video in a right way soon https://www.instagram.com/p/CRubfbDI2eO/
The game is very hard!

Sorry for the delay, I was on vacation.


Vault cannot be stopped/restarted with systemd

Pre-conditions:

os: Ubuntu 20.4
logging turned on

I cannot properly stop or restart Vault with systemd because it is executed in a subshell.
The command hangs util timeout is reached and the actual process is not stopped.
If I revert that back everything now works properly.
In my case I was able to revert back and add the following under [service] instead.
StandardOutput=file:{{ vault_log_path }}/vault-output.log
StandardError=file:{{ vault_log_path }}/vault-error.log

The above is a feature of systemd v236 and ubuntu 18.4 come with systemd v237 so that should be good on that front but Debian is a problem....
I don't know how to "fix" otherwise.
Here's the full template I ended up using:
### BEGIN INIT INFO
# Provides:          vault
# Required-Start:    $local_fs $remote_fs
# Required-Stop:     $local_fs $remote_fs
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: Vault agent
# Description:       Vault secret management tool
### END INIT INFO

[Unit]
Description="HashiCorp Vault - A tool for managing secrets"
Documentation=https://www.vaultproject.io/docs/
Requires=network-online.target
After=network-online.target
ConditionFileNotEmpty={{ vault_main_config }}
StartLimitInterval=60

[Service]
User={{ vault_user }}
Group={{ vault_group }}
ProtectSystem=full
ProtectHome=read-only
PrivateTmp=yes
PrivateDevices=yes
SecureBits=keep-caps
Capabilities=CAP_IPC_LOCK+ep
{% if systemd_version.stdout is version('230', '>=') %}
AmbientCapabilities=CAP_SYSLOG CAP_IPC_LOCK
{% endif %}
CapabilityBoundingSet=CAP_SYSLOG CAP_IPC_LOCK
NoNewPrivileges=yes
ExecStart={{ vault_bin_path }}/vault server -config={{ vault_main_config }} -log-level={{ vault_log_level | lower }}
ExecReload=/bin/kill --signal HUP $MAINPID
KillMode=process
KillSignal=SIGINT
Restart=on-failure
RestartSec=5
TimeoutStopSec=30
StartLimitIntervalSec=60
StartLimitBurst=3
LimitNOFILE=524288
LimitNPROC=524288
LimitMEMLOCK=infinity
StandardOutput=file:{{ vault_log_path }}/vault-ouput.log
StandardError=file:{{ vault_log_path }}/vault-error.log

[Install]
WantedBy=multi-user.target

P.S. logrotate would need to also be updated with the above since vault.err would also need to be rotated.

Please test and comment on this PR

Please test and comment on this PR

@bbaassssiiee the PR you mentionned does not work. Made one that's good.

@bbaassssiiee the PR you mentionned does not work. Made one that's good.

I'm not a maintainer or anything, but I think the PR from @DaazKu is the best way to fix this.

I'm not a maintainer or anything, but I think the PR from @DaazKu is the best way to fix this.


added code to set the refresh interval

Added code to change the refresh interval.
Some UI change might need to be made, but functionality is there.
#1

I've changed it to a select drop-down and aligned it right.
On load the select is populated (up to 600) for available options.
It might be a good idea to add another issue for another drop down to select seconds or minutes for the refresh rate.

I've made some minor adjustments, I hope you don't mind.
I felt that having the refresh rate at in the main container made it feel a bit out of place, and since the main purpose of the dashboard are the status of the services themselves, positioning the refresh interval setting in a more subtle location would give an overall better experience.
What do you think? @hurnhu

Released in v1.1.1


Add clear serial shortcut and menu item

Closes #527

Let's review the shortcut UI string as well as the shortcut command. It is currently Ctrl+Shift+L so it doesn't interfere with with navigating to the browser URL/search bar, but it could overwrite this shortcut if we wanted it to.

This isn't high enough value for us to put in at this point in the release. Closing.


fix: [Bug] When packaged with the maven-assembly-plugin plug-in under…

… the window, the files in the lib directory in the final tar file are truncated #1821

What changes were proposed in this pull request
Issue Number: close #1821

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)

hadoop3 handles this problem by adding the following configuration to the maven-assembly-plugin plugin:
<tarLongFileMode>gnu</tarLongFileMode>


[stable/node-problem-detector] add apiVersion

Adding the apiVersion for chart.yaml
to fix the issue: https://github.com/helm/charts/issues/13763
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @mattfarina

/lgtm


wifi support for board "arduino_uno_r4_wifi"

Is your feature request related to a problem? Please describe.

I'd like to know when the wifi functionality is comming for Arduino uno R4.
I have tried to use the ESP_AT modem driver but as soon as I include the CONFIG_NETWORING=y, the firmware does not fit in RAM. Is that the right way to do it?
Is there any alternative where I do not need to set the CONFIG_NETWORKING?
Describe the solution you'd like

I´d like the wifi_esp worked as a ¨proxy¨driver in the R7FA4 to avoid so much memory allocation.
Describe alternatives you've considered

A great alternative would be having another ¨UART¨ based RPC system which allows to communicate using any interface, it would allow having all wifi+server management in the ESP32 and then using the uart from a higher level communication. It would be great as well since the R7FA4 is provided with less RAM memory than the ESP32
Im new in zephyr and perhaps there is a way to do that? I did not find any
Additional context

Here is my stand-alone application. Just in case anyone ones to check my overlay/config files. I could be doing mistakes since I am not familiarized with devicetree.
https://github.com/urichess/chessboard

This is not really a wifi feature request but a board feature request. According to the maintainer file, the boards/arduino/uno_r4/ is maintained by @soburi / @KhiemNguyenT so reassigning the issue.
About the networking config option, it is needed in order to get any wifi working. You can certainly turn off various networking features to save memory.

32kb is quite small, but it should be possible to tweak networking to fit that, not sure how usable the device is after that. It very much depends on what services you want to use. You should run ram_report to get some ideas what to tweak. See https://docs.zephyrproject.org/latest/develop/optimizations/tools.html for details.

Ok, i'll play with that ram_report tool. Thanks @jukkar. I will probably consider changing board.
However, if I compile a web client example of Arduino IDE it uses 7140bytes of RAM (only 21%) whilst only enabling the zephyr CONFIG_NETWORKING=y uses the whole memory. it should be less consumming since there is the ESP32 which manages the wifi connections.
Well I will play a bit with that tool and see if I get any conclusion.


Support cookie hash

Fix #368

Codecov Report
Attention: 35 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

pkg/filters/proxies/loadbalance.go
84.50% <0.00%> (-1.21%)
:arrow_down:

pkg/filters/redirectorv2/redirectorv2.go
66.66% <66.66%> (ø)

:loudspeaker: Thoughts on this report? Let us know!


Update bundler before bundle install in travis ci builds

Travis CI Builds for factory_girl are broken because the bundler version that Travis CI automatically uses at this time (1.7.6) is coming across the following error/issue bundler/bundler#3558 that was fixed in a later version/release.
Having an outdated version of bundler in the Travis CI builds is an ongoing issue and this is currently the easiest work-around as seen in discussions at travis-ci/travis-ci#3531

@tute any thoughts on this? Should enable #838, #839, and #843 to be rebased and potentially merged.

Thanks for your work, @RochesterinNYC! This is a weird fix. Do you know if Travis will fix it soon-ish? If not, I'll merge. Thanks!

According to that linked issue in travis-ci, it seems they're wary of upgrading bundler to 1.10.x and don't seem to be in a rush to upgrade it anytime soon. They're suggesting this gem install bundler fix in the meantime. Hopefully, they'd update it soon honestly, but doesn't seem like they will?

Merged into master. Thank you! :clap: :smiley:

Thanks!

for googling people, just do:
.travis.yml
language: ruby
before_install: gem install bundler
rvm:
  - 2.1.0
  - 2.1.1
  - 2.1.2
  - 2.1.3
  - 2.1.4
  - 2.1.5
  - 2.2.0
  - 2.3.0
  - ruby-head

important part is that before_install: gem install bundler it will install current bundler source


configurable api uri

Added a configurable uri for the api to the node settings
Added bat file (for windows) so that Breeze nodes can be started easily for testing

yeah that's the plan. when we reshuffle it we'll make it better.
Jeremy Bokobza
<EMAIL_ADDRESS>https://volto.io
[image: Twitter]  https://www.twitter.com/volto_io[image: Facebook]
https://www.facebook.com/volto.io
On 20 June 2017 at 22:20, Dan Gershony<EMAIL_ADDRESS>wrote:

@dangershony commented on this pull request.
In Breeze/src/Breeze.Daemon/Program.cs
https://github.com/stratisproject/Breeze/pull/105#discussion_r123099079:

@@ -24,20 +24,31 @@ namespace Breeze.Daemon
{
public class Program
{

   private const string DefaultBitcoinUri = "http://localhost:5000";

I don't like this so much, this is network specific so it should probably
go in to the Network class when we bring it over the to fullnode
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stratisproject/Breeze/pull/105#pullrequestreview-45271466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByAZaq4M3RwZx0Eh5I9-ooWH5gb5ZDyks5sGDe4gaJpZM4N_48J
.


sort method does not support 'NULLS {FIRST|LAST}'

When using ORDER BY in SOQL, null values are sorted first by default. However, SOQL lets you specify 'NULLS {FIRST|LAST}' as part of the ORDER BY (https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/sforce_api_calls_soql_select_orderby.htm).
Can SOQLBuilder.createOrderByClause() be updated to support sort params which include NULLS FIRST and NULLS LAST?

I would also love this support.

Me too. will V3 support it?

Shameless plug :D
I maintain a SOQL parsing/composing library that supports this - it isn't quite the same builder pattern as JSForce but it supports all SOQL features - https://github.com/jetstreamapp/soql-parser-js


Use radio buttons instead of drop down for group #15

Change to radio buttons Member group field using class --minimal and unorder listing

Sure. I'll work on it and thank you for feedback 👍


Aurora metrics are not implemented

Aurora RDS CloudWatch metrics are not currently searchable. There is some overlap with RDS CloudWatch metrics, but it would be preferable to have access to all of them.
e.g.:
AuroraBinlogReplicaLag
AuroraGlobalDBReplicatedWriteIO
AuroraGlobalDBDataTransferBytes
AuroraGlobalDBReplicationLag
AuroraReplicaLag
AuroraReplicaLagMaximum
AuroraReplicaLagMinimum

...and more.
Thank you!

misconfig on my part 🤦♂

What was the fix?


Update Composer dependencies (2023-10-10-00-10)

Visual regression test passed!
View the visual regression test report


terraform plugin incorrectly requires optional (conditional) parameters as mandatory

AWS Lambda function definition.
Terraform plugin incorrectly highlights as error if handler and runtime are omitted, even though the package_type is set to Image. Terraform will perform the initial apply with handler and runtime incorrectly present, but delta processing will fail with a Terraform message to the effect of: "do not supply handler and runtime with package_type set to Image"
Installation details

[ ] IDE version
IntelliJ IDEA 2021.1.1 (Ultimate Edition)
Build #IU-211.7142.45, built on April 30, 2021
Licensed to Edward Statham
Subscription is active until November 28, 2021.
Runtime version: 11.0.10+9-b1341.41 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Linux 5.11.0-7614-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 16
Registry: documentation.show.toolbar=true, debugger.watches.in.variables=false
Non-Bundled Plugins: Dilbert (<IP_ADDRESS>), com.intellij.ideolog (<IP_ADDRESS>), com.pixelperfect.gitlab-ci (1.0.6-211), org.intellij.plugins.hcl (0.7.10), name.kropp.intellij.makefile (211.6693.108), org.toml.lang (<IP_ADDRESS>26-211), GrepConsole (<IP_ADDRESS>86.0), io.codearte.props2yaml (1.0.2), org.avaje.ebean11.enhancer (12.8.2), cucumber-javascript (211.6693.65), Dart (211.7233), org.jetbrains.kotlin (211-1.5.0-release-759-IJ6693.72), Pythonid (211.7142.45), net.ashald.envfile (3.2.1), ru.adelf.idea.dotenv (2021.1), org.asciidoctor.intellij.asciidoc (0.32.43)
Kotlin: 211-1.5.0-release-759-IJ6693.72
Current Desktop: pop:GNOME

[ ] intellij-hcl plugin version 0.7.10

[ ] Terraform version 0.14.2

Terraform Configuration Files
The handler and runtime properties should not be supplied with package_type set to Image. However if they are removed then the error highlight is triggered.
resource "aws_lambda_function" "lambda" {
  function_name = "${local.resource_prefix}-${var.lambda_name}"
  image_uri    = "${var.image_repository_ecr}:${var.image_tag}"
  package_type = "Image"
  handler     = var.handler
  runtime     = var.runtime
  timeout     = var.timeout
  memory_size = var.memory_size
}

Expected Behavior
plugin should correctly handle lambda definition without handler or runtime parameters in the case where the package_type is Image
Actual Behavior
error highlight on lambda definition complaining about missing properties, when they are not in fact allowed with package_type set to Image
Steps to Reproduce
Define a lambda function with package_type set to Image, and do not supply handler or runtime properties. Error highlight should appear. HCL snippet above should demonstrate this - place into a .tf file then remove or comment out the runtime and handler properties. The error highlight will (incorrectly) trigger.

anyone?

Running into this same one -- I've ended up disabling this inspection entirely for the meantime.

Fixed in 0.7.11


Supply DHCP options when using loadBalancerIP: <IP_ADDRESS>

By supporting options such as vendor-class-identifier (option 60) by the DHCP client in kube-vip you can assign specific ranges in your dhcp server.
It would be nice to support further DHCP options when using it to acquire the load balancer IP.
Maybe being able to configure a vendor-class-identifier (option 60) on the kube-vip manager itself and addicional options through annotations?
It can be useful, since I could assign load-balancer IPs from a given range to ease routing/debugging.
Also supplying additional options via annotations like which client-identifier (hostname) shoud be sent and/or mac-address to be able to use static leases. I believe the former requires no fancy logic to be added, as the macvlan interface doesn't care for the client-identifier being sent. The later would most likely require setting the hwaddr in the macvlan before the dhcp query.
Ref: https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml
Most options there are not relevant to kube-vip, as it only assigns an IP but it doesn't care about the network setup (that's the CNI job) of the pod. Anyways, options that can be send so the DHCP server can lease more precisely an IP to the load balancer is welcomed.

Not an expert here. From my understanding, kube-vip-cloud-provider chooses an appropriate IP, then kube-vip just implements it.


Improve ros2 code generator

Tested for several publishers, subscribers, service servers and service clients :+1:


3 setup environment and ci

Note that CodeCov report and publication is suspended for further investigation once the first code is pushed.


FDroid

Is this on the f droid store?

No and I didn't want to add it for a few reasons mainly

My code is terrible
No one releases FOSS apps as split APKs. Practically this app can only be used for merging closed source apks, I don't think it will make a lot of sense for F-Droid

Does it send a notification if there's an updated version to download from GitHub?

Does it send a notification if there's an updated version to download from GitHub?


Tobira only works with "public" schema

Tobira has the public schema hard coded (eg. https://github.com/elan-ev/tobira/blob/master/backend/src/db/query.rs) and does not work with other schemas.

If you set search_path = "$user" for the database user, Tobira automatically uses the schema named after its database username. This works for all queries where the schema is not explicitly mentioned in the query.

Yes, we use the schema tobira in our deployment as we do not trust the users in the public schema. In the public schema "EVERYBODY" can write, using the default PostgreSQL settings.
For details see: https://www.postgresql.org/docs/current/ddl-schemas.html

It would need changes in the following two functions:
https://github.com/elan-ev/tobira/blob/9aff8d7c0509e030c87bc7d4c48d79bc4ced2895/backend/src/db/query.rs#L6-L17
            "select table_name from information_schema.tables \
-                where table_schema = 'public' and table_type = 'BASE TABLE'",
+                where table_type = 'BASE TABLE'",

https://github.com/elan-ev/tobira/blob/9aff8d7c0509e030c87bc7d4c48d79bc4ced2895/backend/src/db/query.rs#L19-L30
        "select exists(
            select * from information_schema.tables
-                where table_schema='public' and table_name=$1
+                where table_name=$1
        )",

I finally managed to read up on schemas in PostgreSQL.
If I understand everything correctly, simply removing the where schema = 'public' condition is actually incorrect. Because then we would also list tables from other schemas that the user has access to. I think replacing 'public' with current_schema() is a better solution. I would do the following changes:

Document that current_schema() must always refer to the same schema over the lifetime of a Tobira installation. I think this is a reasonable requirement. All objects created and used by Tobira should be stored in one schema.
Replace all occurrences of 'public' with current_schema(). I am aware that current_schema is just the first schema in the search path which exists. But this is also exactly the schema where new objects are created. So I think it should all work out well.
Change the clear function to not drop the schema, but instead only drop all objects inside it. It is more work but it's the better solution IMO. For example, already saw installations where the user actually wasn't allowed to drop the schema.

This would also imply closing the PR by @geichelberger.
What do you think about this plan? Is my understanding of the situation correct?


add alerts

for issues: #218 #219 #220
Did you have something like this in mind @BugRoger ?

Yes. No metrics for groundctl.
Also deorbiter and launchctl expose kubernikus_deorbit_operation_latency_* metrics, which is missing for for routegc.  Also routegc does not track kubernikus_routegc_operation_total.


Create 20211124-model_card_component.md

Addresses https://github.com/tensorflow/tfx-addons/issues/82

/lgtm

/merge


Update Snapshot URL

Old URL is no longer up to date. Use https://ls.manapotion.io/latest-export.gz.bin or until a better option hosted by IF is available

IF updated the snapshots.... we will let this PR open some days to check if the IF snapshots stay up to date

@muXxer @luca-moser IF site is looking good. I will close this later today unless I hear otherwise


KAFKA-8538 (part of KIP-345): add group.instance.id to DescribeGroup

Include group.instance.id in the describe group result for better visibility.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

Retest this please

Retest this please

@ableegoldman @vvcephei Could you also take a look?

@ableegoldman Thank you!

Retest this please


Enable integration install flyout for other install buttons

Description
Turns out there's more than one place where the flyout has to render, I didn't realize. Here's the other two places updated to use the flyout instead of a redirect.
Depends on #1588
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is this going into 2.13? Could you add proper label?

Waiting on UX to get back about the integrate data text before merging.


remove leading % in dtx mode

@rultor release, tag is 0.3.1

@rultor release, tag is 0.3.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.3.1

@yegor256 Done! FYI, the full log is here (took me 4min)


InvalidRequestError: The model gpt-4-32k

I am not sure if this is the correct place to post this; if not, I apologize in advance. I like trying out different AI tools, and currently, I am experimenting with GPT_Author. I have followed all the steps and read as much material as I can find, but I still can't get it to work. I have paid for GPT-4 and for the GPT API. When I run GPT Author, I see the step cost for each section, but in the end, I encounter an error. I am not a programmer, so this is very confusing.
InvalidRequestError Traceback (most recent call last) Cell 7 line 5
3 num_chapters = 15
4 writing_style = "Clear and easily understandable, similar to a young adult novel. Lots of dialogue." ---->
5 novel, title, chapters, chapter_titles = write_fantasy_novel(prompt, num_chapters, writing_style, claude_true)
7 # Replace chapter descriptions with body text in chapter_titles
8 for i, chapter in enumerate(chapters):
Cell 7 line 2
266 chapter_titles = ast.literal_eval(storyline)
269 novel = f"Storyline:\n{storyline}\n\n" -->
271 first_chapter = write_first_chapter(storyline, chapter_titles[0], writing_style.strip(), claude_true) 272 print('first chapter written')
273 novel += f"Chapter 1:\n{first_chapter}\n"
Cell 7 line 1
135 response = openai.ChatCompletion.create(
136 model="gpt-4",
137 messages=[ (...)
140 ]
141 )
143 print_step_costs(response, "gpt-4") -->
145 improved_response = openai.ChatCompletion.create(
...
766 rbody, rcode, resp.data, rheaders, stream_error=stream_error
767 )
768 return resp InvalidRequestError: The model gpt-4-32k does not exist or you do not have access to it. Learn more: https://help.openai.com/en/articles/7102672-how-can-i-access-gpt-4.

I get the same error: InvalidRequestError: The model gpt-4 does not exist or you do not have access to it.
I have a paid openai subscription with an newly generated API key. Didn't work.
Tried it with again a new api key but still get this error.
I have other applications that succesfully use my openai key so that can hardly be the problem.
Anyone?

Replace all 'gpt-4-32k- with 'gpt-4'  .  The 32k is only available to a very small trial group and currently only being given out to the azure clients.

Did just that; replaced every instance but I get the same error...
Any other suggestion?

Thank you for replying back to this post. I also did the same suggestion with replacing all the "gpt-4-32K" with "gpt-4". I now got a different error.
KeyError                                  Traceback (most recent call last)
c:\Users\test\gpt-author\gpt_author_v2_1.ipynb Cell 7 line 5
3 num_chapters = 15
4 writing_style = "Clear and easily understandable, similar to a young adult novel. Lots of dialogue."
----> 5 novel, title, chapters, chapter_titles = write_fantasy_novel(prompt, num_chapters, writing_style, claude_true)
7 # Replace chapter descriptions with body text in chapter_titles
8 for i, chapter in enumerate(chapters):
c:\Users\test\gpt-author\gpt_author_v2_1.ipynb Cell 7 line 2
276 for i in range(num_chapters - 1):
277     print(f"Writing chapter {i+2}...") # + 2 because the first chapter was already added
--> 279     chapter = write_chapter(novel, storyline, chapter_titles[i+1])
280     try:
281       if len(str(chapter)) < 100:
c:\Users\test\gpt-author\gpt_author_v2_1.ipynb Cell 7 line 1
170     data = {
171         "model": "claude-2",
172         "prompt": prompt,
173         "max_tokens_to_sample": 5000,
174     }
176     response = requests.post(url, headers=headers, json=data)
--> 178     print_step_costs_anthropic(prompt, response.json()['completion'])
180     return 'Chapter ' + response.json()['completion'].strip().split('```')[0].strip()
181 else:
KeyError: 'completion'

I replaced gpt-4-32k with GPT-3.5-Turbo-16k and so far so good

I tried to replace gpt-4-32k with GPT-3.5-Turbo-16k and I get this error now. I am sure I am missing something.
InvalidRequestError: The model GPT-3.5-Turbo-16k does not exist

I tried to replace gpt-4-32k with GPT-3.5-Turbo-16k and I get this error now. I am sure I am missing something.
InvalidRequestError: The model GPT-3.5-Turbo-16k does not exist

can you paste/screenshot the full error code please?

This is what I am getting for an error.

This is what I am getting for an error.

can you try "gpt-3.5-turbo-16k" instead of "gpt-3.5-Turbo-16k"?

You need to use lowercase "gpt-3.5-turbo-16k" - it's case sensitive. Also, In order to access GPT-4, if your PAID (card linked to API billing**) account was created before August 2023, you must spend and have been billed at least $1.00 total in any given month to have been given access to GPT-4 APIs. After August, $0.50. Hope that helps!

I did use lowercase and still getting this error.
Step Cost (OpenAI): 0.1167
generated plots
Step Cost (OpenAI): 0.16626000000000002
selected best plot
Step Cost (OpenAI): 0.12078
plot improved
Step Cost (OpenAI): 0.03702
title generated
Generating storyline with chapters and high-level details...
Step Cost (OpenAI): 0.12096
Step Cost (OpenAI): 0.17178
storyline generated
Step Cost (OpenAI): 0.14802
Step Cost (OpenAI): 0.14802
first chapter written
Writing chapter 2...
KeyError                                  Traceback (most recent call last)
[c:\Users\zimba\gpt-author\gpt_author_v2_1.ipynb](file:///C:/Users/zimba/gpt-author/gpt_author_v2_1.ipynb) Cell 7 line 5
3 num_chapters = 15
4 writing_style = "Clear and easily understandable, similar to a young adult novel. Lots of dialogue."
----> 5 novel, title, chapters, chapter_titles = write_fantasy_novel(prompt, num_chapters, writing_style, claude_true)
7 # Replace chapter descriptions with body text in chapter_titles
8 for i, chapter in enumerate(chapters):
[c:\Users\zimba\gpt-author\gpt_author_v2_1.ipynb](file:///C:/Users/zimba/gpt-author/gpt_author_v2_1.ipynb) Cell 7 line 2
276 for i in range(num_chapters - 1):
277     print(f"Writing chapter {i+2}...") # + 2 because the first chapter was already added
--> 279     chapter = write_chapter(novel, storyline, chapter_titles[i+1])
280     try:
281       if len(str(chapter)) < 100:
[c:\Users\zimba\gpt-author\gpt_author_v2_1.ipynb](file:///C:/Users/zimba/gpt-author/gpt_author_v2_1.ipynb) Cell 7 line 1
170     data = {
171         "model": "claude-2",
172         "prompt": prompt,
173         "max_tokens_to_sample": 5000,
174     }
176     response = requests.post(url, headers=headers, json=data)
--> 178     print_step_costs_anthropic(prompt, response.json()['completion'])
180     return 'Chapter ' + response.json()['completion'].strip().split('```')[0].strip()
181 else:


Add GPG Sync

https://firstlook.org/code/project/gpg-sync/

I asked you less than a day ago to please follow the templates. It isn’t hard, just click the link. Your issues will continue to be closed without review until you do.
Please respect our time and efforts.


Using upstream outputs as inputs is broken on darwin

Given the following tasks running on darwin, in this order:

---
platform: darwin

inputs:
- name: some-input-from-a-resource

outputs:
- name: some-output

run:
  path: some-input-from-a-resource/some-script

---
platform: darwin

inputs:
- name: some-input-from-a-resource
- name: some-output

run:
  path: some-input-from-a-resource/some-other-script

The bottom task will fail to run because some-output has not been mounted in the container. It does not fail as you might expect, which is missing inputs: some-output.
Using the exact same tasks/scripts on a linux worker was successful.
There were no errors in the garden log associated with this.

issue is https://github.com/vito/houdini/issues/6

Moved to concourse/concourse#1141


Deprecate Python 2.7; added latest Pythons

Coverage remained the same at 87.838% when pulling cc8a0a1c7faca71da2f93c212df9b1591c945d34 on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling cc8a0a1c7faca71da2f93c212df9b1591c945d34 on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling cc8a0a1c7faca71da2f93c212df9b1591c945d34 on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Current coverage is 87.83% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files             6          6
  Lines           222        222
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            195        195
  Misses           27         27
  Partials          0          0

Powered by Codecov. Last update 9881679...cc8a0a1

Coverage remained the same at 87.838% when pulling 4230a8e1b837a94c986d07db9a6a19cedb74a97b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling 4230a8e1b837a94c986d07db9a6a19cedb74a97b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling 4230a8e1b837a94c986d07db9a6a19cedb74a97b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling 4230a8e1b837a94c986d07db9a6a19cedb74a97b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling 4230a8e1b837a94c986d07db9a6a19cedb74a97b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

Coverage remained the same at 87.838% when pulling dfc7196bd30ab0ab71f3c4bd6f80f7353df8415b on latest-pythons into 98816794a1ca6ee7639147bb210e80043cb8df15 on master.

This will help #11


Consider sorting user-secrets list result

I have a fairly long list of user-secrets entries for a particular project and it would be nice to see a sorted list of these items rather than having to search through the entire list to find related items. It appears items are grouped, but not sorted.
Current user-secrets list output:
xyzApi:item5
xyzApi:item6
xyzApi:item3
xyzApi:item2
xyzApi:item1
xyzApi:item4
Proposed user-secrets list output
xyzApi:item1
xyzApi:item2
xyzApi:item3
xyzApi:item4
xyzApi:item5
xyzApi:item6

This seems like it should be pretty simple to implement. I would take a PR to fix it, but as it's not really a high priority, this is going on the backlog for now.
In the meantime, you can always pipe output to sort if you're using powershell or bash.
dotnet user-secrets list | sort

I'm closing as we have no plans to implement this ourselves. We would still accept a PR for this. If you want to implement this feature, send a PR.


Load values from remote (YAML) files

Is your feature request related to a problem? Please describe.
Possibility to load values from a file by providing a file reference. File content would be parsed (as YAML) and its values injected into the form.
Describe the solution you'd like
Load directly from FE without going through the backend. Simply because there is no need for that.

Implemented in https://github.com/cyclops-ui/cyclops/pull/47


PR: Fix regex quoting

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

The regex that this PR fixes was not quoted correctly; this PR fixes the quoting.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @juliangilbey

I don't understand this change, so I have a couple of questions about it:
1. Isn't the `r` at the beginning of the string enough to make it a raw one?

No, it isn’t. String prefixes only apply to the immediate string literal. The syntax used here is called String literal concatenation, see Python’s documenation for details.
Technically, as far as the regular expression is concerned, the r is not required in the first line. However, it is required in the second.


Small layout and style issues

@phivk

CardItem get's displayed under spectrum:

CardItem displays correctly on my end, but i increased z index of the draggable so please try again

Buttons should have cursor: pointer to signal they are clickable:

They do have and display pointer on hover on my end


Works with React Native?

I highly doubt it. It would need to be executed within a WebView context rather than native. 👍


config-next: remove SetConfig and ResetConfig

This pull-request removes the mutable SetConfig and ResetConfig methods (along with the origConfig field, which was a collaborator) from the *config.Configuration type. They are no longer used anywhere throughout the LFS codebase 🎉

/cc @technoweenie @rubyist @sinbad

Tracking: #1425.

:metal:


Installed JAVA but @ installation it says its not available.

Hi,
I tried to install the wallet on a new PC. Setup Wizard told me to install Java - that i did. Restarted the system, tried to install the wallet again. Same error message.
No idea what to do.

CLOSED.
Another thread helped.
Download and install this:
https://javadl.oracle.com/webapps/download/AutoDL?BundleId=244065_89d678f2be164786b292527658ca1605


Use the lang page variable attribute

Hi!
Since the version 2.0 of 11ty, a lang attribute has been available in the page variable.
I am suggesting this PR to reflect this addition and use this handy attribute directly rather than inferring the lang from the URL.
Thanks in advance!

Thanks for this, @hjonin. Apologies this plugin hasn't seen much attention lately.
Hoping to revisit and bring a few of these modern improvements along.


Fix expat pin to match run_exports

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Diff is at https://gist.github.com/isuruf/3229c63ac740b83aa1b932aa03c5d712

@conda-forge/core, this is ready.

Feel free to merge. The diff has a bunch zlib arrow and tbb patches in it. I don't know why things are being patched again like this, but it is not great.
Not your problem though. Merge away.

Thanks


auth, etcdserver: make auth tokens consistent for all nodes

Currently auth tokens are generated in the replicated state machine
layer randomly. It means one auth token generated in node A cannot be
used for node B. It is problematic for load balancing and fail
over. This commit moves the token generation logic from the state
machine to API layer (before raft) and let all nodes share a single
token.
Log index of Raft is also added to a token for ensuring uniqueness of
the token and detecting activation of the token in the cluster (some
nodes can receive the token before generating and installing the token
in its state machine).

/cc @xiang90

@mitake Can you run ./scripts/genproto.sh -g when you generate proto files, so we keep the documentation up to date?
Thanks.

@gyuho OK, I'll add -g option

@xiang90 updated for the internal request, could you take a look? I kept the argument index of Authenticate() because I cannot imagine how jwt will be implemented. I'll revisit it later.

@xiang90 updated for the comments, PTAL

@xiang90 updated for context based argument passing, PTAL

@xiang90 updated for the comments, PTAL

lgtm


How to quickly join the whitelist

Use Microsoft Edge

Use Microsoft Edge. They get priority

Phone or computer? Cuz in the "access being faster" they asked you to download the phone app and sign in on the phone app.

Phone probably.
By the way: https://github.com/acheong08/EdgeGPT/releases/tag/0.0.10 allows you to access it without a cookie or authentication

New release so you guys can access it while you wait for your own tokens

ok thanks

New release so you guys can access it while you wait for your own tokens

 File "/Users/leolrg/Downloads/EdgeGPT/src/EdgeGPT.py", line 137, in __init__
    raise Exception(
TypeError: __init__() missing 3 required positional arguments: 'msg', 'doc', and 'pos'

Still not working in the new update?

What did you try to do?

pip3 install --upgrade EdgeGPT
python3 -m EdgeGPT
Don't try to run from the code directly

Is this program open source =>>bing.kpham.workers.dev worker.js

The source code was posted on Discord. It's just a basic proxy that injects a cookie. You aren't sharing any info with it so it's fine. It's only used to fetch conversation information

It's around 20 lines of code

Calling this interface too many times per day will fail

Yes. Please don't abuse it

thx


Adding QoL extensions to Transforms

I'd like Transforms to have some QoL methods (examples will follow), and would like to hear what the sentiment towards that would be (I know we want to be careful with implementing too many new features).
Here is my wishlist (much of these are influenced by Unity's Transforms:

Transform::forward() -> Vec3 Get the normalized direction pointing towards in model-space
Transform::look_at(&mut self, &Vec3) Rotate the Transform, so that it looks at a certain position
General methods to rotate the Transform e.g. around a certain axis, or orbit around a certain point. Those could be better kept as constructors for Quat, though.
Transform::face_towards(&mut self, ..) -> Self same as Transform::new(Mat4::face_towards(..)) but minimizes the amount of Mat4s the average user has to deal with
Transform::apply(&mut self, other: &Transform) transform your transform by another transform ;)
I'm sure more will come to mind later

The mutable methods would also only be implemented on Transform but not on GlobalTransform (although refining the difference between Global- and Transform could be another Issue).
If everyone's on board I'd like to use this issue to collect wanted features for Transforms and open a pull request to implement them.

There should definitely be both apply_before and apply_after. Also, I think rotation interpolation functions would be helpful such as rotate_angle_toward(angle: f32, target: &Quat) and rotate_fraction_toward(frac: f32, target).

Hey, I was looking to add some QoL methods to the Transform component too but then I saw your PR.
I think it would be nice to have the following (taken from Unity):
I know this one is on a Vec3 in unity but I figure it could just as easily be on the Transform?

// Vector3.MoveTowards
 public static Vector3 MoveTowards(Vector3 current, Vector3 target, float maxDistanceDelta)
 {
     Vector3 a = target - current;
     float magnitude = a.magnitude;
     if (magnitude <= maxDistanceDelta || magnitude == 0f)
     {
         return target;
     }
     return current + a / magnitude * maxDistanceDelta;
 }

Transform.TransformDirection(Vec3);

transform_direction(&mut self, directon: Vec3) {
   self.transform.rotation().mul_vec3(direction);
}

There should definitely be both apply_before and apply_after.

@GrantMoyer Could you elaborate what would be the difference?

@MarekLg Tranform composition is not commutative, so in generally AB != BA. For example, translating by 10, then scaling by 2 is not the same as scaling by 2, then translating by 10, since the scaling is always relative to the global origin.

You're right, but that's not why I'm asking. Transform::apply(..), in the original sense, was meant to come down to this:
pub fn apply(&mut self, other: &Transform) {
  self.value = *other.value() * self.value;
}

So I'm assuming Transform::apply_before(..) would be like this?
pub fn apply(&mut self, other: &Transform) {
  self.value = self.value * *other.value();
}

If I got that right: what would be the use of apply_before()?

Apply before could be used to, for instance, scale a model to half size before applying the current transform. Since these ops are in place, doing that with apply (apply_after) would require an extra copy.

I understand, thanks for the clarification! I'll put in both of the apply methods.

Another question: should transform.translate(translation) translate with or without the rotation of transform applied to translation?

I'm gonna add my two cents because I just ran into the ordering issue with Transform::rotate() for a Camera.
The naming of these applying methods seem to maximize the chance for misunderstandings. I would either remove the method when the multiply-left version is not allowed to exist or add an in-place multiply-left method.
In my opinion, though, the Transform::rotate method should be turned into multiply-left. That would be correct for the meaning of "rotate this current state".

Another question: should transform.translate(translation) translate with or without the rotation of transform applied to translation?

The "correct" way of doing this really depends on the context of application. For most things, I would expect a sequence of Translate -> Rotate and Rotate -> Translate to have differing effects. But in the context of a transform component that e.g. controls the camera, I want to iteratively change rotation and translation independent of each other. The latter use case may be the typical one for this framework. It should just be clearly communicated.

most of those methods now exist on Transform


Handle redirection for package download

We still to handle the redirection from wllbg.org to wallabag.org

nginx configuration updated:
    rewrite ^/latest-v2-package https://wallabag.org/latest-v2-package redirect;
    rewrite ^/latest-v2 https://wallabag.org/latest-v2 redirect;


fix(net/goai): cannot customize OpenAPIv3 type for request parameters

fixed #3135

@gqcn It's a test.


/github/workspace/src/video/ffmpeg/threaded_decoder.cc:292: [14:29:09] /github/workspace/src/video/ffmpeg/threaded_decode r.cc:218: Check failed: avcodec_send_packet(dec_ctx_.get(), pkt.get()) >= 0 (-11 vs. 0) Thread worker: Error sending packet.

请问这个问题怎么解决？感谢！

I cannot see the full code, but it usually comes from multiple GPU use setting. check the script file that you use and your GPU setting is allowed to run multiple GPU run.


[UI/UX] Code folding for tag that span on multiple lines

In #12521 @thehogfather change the behavior of code folding to match the CodeMirror one.
So now when a tag span on multiple lines you have two code folding triangles.

@redmunds proposed an alternative.
Another option would be to collapse both tag attributes and tag contents something like this:

For reference 1.7 behaviour:

Opening this to review this aspect.

/cc @larz0


runtime: implement global context object

Implement a global ctx object type for carrying around state, such as for access to accounts, TX, features, bank etc.

initial version implemented in this commit: https://github.com/Overclock-Validator/radiance/commit/64fefbf4062308900d6274ff0ae20a5730eeba3f


chore(README.md): remove obsolete square brackets

Looking at the README file, I noticed that there currently are obsolete square brackets around the code coverage badge. This PR removes them. However, it might make sense to also wrap the badge with a proper link (there is anything to link to here).

Thanks for the fix :smile:.
If we had some kind of page that shows the current coverage report of this CI run even outside of PRs, we could link there instead.
This would also have the advantage that we could see the current coverage state on the current state of main.
Maybe we could create a job summary for the coverage report (see https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/)?

@JKRhb Done, see #28


Replace the global.isMobileWidth-SessionVariable by css media rules

To distinguish between mobile and desktop sized screens we currently use a session variable called "global.isMobileWidth" which will be reset after every window size change. This intermixes styling with application logic because it displaces the style decisions from the css files into the template helper javascript files. Additionally this blows up our template helpers a lot.
The same can be done by using css media rules which can be defined within the css files directly.

Unfortunately, we cannot get rid of them at all. I did not found any possibility to replace the following three occurrences: https://github.com/4minitz/4minitz/blob/develop/client/templates/minutes/minutesedit.html#L163, https://github.com/4minitz/4minitz/blob/develop/client/templates/minutes/minutesAttachments.html#L21 and https://github.com/4minitz/4minitz/blob/develop/client/templates/minutes/minutesEditParticipants.html#L14

I could replace all three occurrences listed in my previous comment by improving the layout for mobile devices 👍


Feature/casmnet 2024  - Add additional loadbalancers to unbound for scaling

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?

Add additional loadbalancers to unbound for scaling
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix? y

Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
CSAMNET-2024
CAST-31858
Testing
List the environments in which these changes were tested.
Tested on:
NERSC Muller
NERSC Perlmutter
Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

manual testing with proper helm labels to allow upgrades and downgrades

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?n

Were continuous integration tests run? If not, why?n

Was upgrade tested? If not, why?y

Was downgrade tested? If not, why?y

Were new tests (or test issues/Jiras) created for this change?n

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?

none

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[ ] Copyrights updated
[x] License file intact
[x] Target branch correct
[ ] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

I don't think it would be easy since there is no data source to use dynamically at chart deploy time.  IE: SLS assumes all cabinets are populated.

Reason for additional loadbalancers is a workaround for a scaling issue to address:

not able to rely only on single Loadbalancer set to Local like previous solution for large systems
possible ecmp bug with bgp 8 peer limit on systems with more than 8 workers


Bug/fix reverse bits with isolated qubits

Summary
Fixes Issue #6731.
This fix allows the reverse_bits() method of the QuantumCircuit class to work with QuantumCircuits with only isolated Qubits (not in a QuantumRegister).
Details and comments
Added test to ensure functionality works as expected.

Thank you for taking this on!
This is a slightly trickier problem than it first seemed, because QuantumCircuit doesn't actually a keep a reference to loose qubits - QuantumCircuit.qubits (and clbits) are references to all bits, including those stored in registers. Consider this example, using this branch:
In [1]: from qiskit import QuantumCircuit, QuantumRegister
   ...: qregs = [QuantumRegister(2), QuantumRegister(3)]
   ...: qc = QuantumCircuit(*qregs)
   ...: for n in range(1, sum(len(reg) for reg in qregs)):
   ...:     qc.cx(0, n)
   ...: qc.draw()
Out[1]:

q0_0: ──■────■────■────■──
      ┌─┴─┐  │    │    │
q0_1: ┤ X ├──┼────┼────┼──
      └───┘┌─┴─┐  │    │
q1_0: ─────┤ X ├──┼────┼──
           └───┘┌─┴─┐  │
q1_1: ──────────┤ X ├──┼──
                └───┘┌─┴─┐
q1_2: ───────────────┤ X ├
                     └───┘

In [2]: qc.reverse_bits()
---------------------------------------------------------------------------
CircuitError                              Traceback (most recent call last)
<ipython-input-2-e7bc77090cef> in <module>
----> 1 qc.reverse_bits()

~/code/qiskit/terra/qiskit/circuit/quantumcircuit.py in reverse_bits(self)
    401                  └───┘
    402         """
--> 403         circ = QuantumCircuit(
    404             *reversed(self.qregs),
    405             *reversed(self.cregs),

~/code/qiskit/terra/qiskit/circuit/quantumcircuit.py in __init__(self, name, global_phase, metadata, *regs)
    193         self._ancillas = []
    194         self._calibrations = defaultdict(dict)
--> 195         self.add_register(*regs)
    196
    197         # Parameter table tracks instructions with variable parameters.

~/code/qiskit/terra/qiskit/circuit/quantumcircuit.py in add_register(self, *regs)
   1195                 self._clbit_set.update(new_bits)
   1196             elif isinstance(register, list):
-> 1197                 self.add_bits(register)
   1198             else:
   1199                 raise CircuitError("expected a register")

~/code/qiskit/terra/qiskit/circuit/quantumcircuit.py in add_bits(self, bits)
   1203         duplicate_bits = set(self.qubits + self.clbits).intersection(bits)
   1204         if duplicate_bits:
-> 1205             raise CircuitError(
   1206                 "Attempted to add bits found already in circuit: " "{}".format(duplicate_bits)
   1207             )

CircuitError: "Attempted to add bits found already in circuit: {Qubit(QuantumRegister(3, 'q1'), 2), Qubit(QuantumRegister(3, 'q1'), 1), Qubit(QuantumRegister(2, 'q0'), 0), Qubit(QuantumRegister(3, 'q1'), 0), Qubit(QuantumRegister(2, 'q0'), 1)}"

I've left a couple of comments inline for how you might look into fixing this, and some additional tests to help determine when everything's working correctly.

First of all, apologies for making a PR with broken code. Thank you for alerting me to these issues and your insight into fixing them! I'll take a closer look at how QuantumCircuits treat loose qubits and try to find a better solution.

Oh, there's absolutely no need to apologise!  It's easy to miss this sort of thing - that's what review is for.  Let us know on this PR if you've got further questions, and I think @TharrmashasthaPV may also be interested in seeing your solution.

Hi @apcarrik . Work nicely done. I just had a few pointers that I have replied in the review thread. I also saw that the CI test for lint is failing. You can fix that easily by blacking. Feel free to ping us if needed. 😃

I'm a bit confused as to how registers are supposed to be treated in reverse_bits(). I take the description of the function (changing from little-endian to big-endian) to mean, for an n-qubit circuit, keep all the gates where they are in the circuit diagram, but swap the 0th qubit with the nth qubit, swap the 1st qubit with the (n-1)th qubit ... etc. like so: ```>>>qr1 = QuantumRegister(3, "a")

qr2 = QuantumRegister(2, "b")
qc1 = QuantumCircuit(qr1, qr2)
qc1.h(qr1[0])
qc1.cx(qr1[0], qr1[1])
qc1.cx(qr1[1], qr1[2])
qc1.cx(qr1[2], qr2[0])
qc1.cx(qr2[0], qr2[1])
print(qc1)
┌───┐
a_0: ┤ H ├──■─────────────────
└───┘┌─┴─┐
a_1: ─────┤ X ├──■────────────
└───┘┌─┴─┐
a_2: ──────────┤ X ├──■───────
└───┘┌─┴─┐
b_0: ───────────────┤ X ├──■──
└───┘┌─┴─┐
b_1: ────────────────────┤ X ├
└───┘
print(qc1.reverse_bits())
┌───┐
b_1: ┤ H ├──■─────────────────
└───┘┌─┴─┐
b_0: ─────┤ X ├──■────────────
└───┘┌─┴─┐
a_2: ──────────┤ X ├──■───────
└───┘┌─┴─┐
a_1: ───────────────┤ X ├──■──
└───┘┌─┴─┐
a_0: ────────────────────┤ X ├
└───┘
or, alternativley:>>> print(qc1.reverse_bits())
┌───┐
a_0: ────────────────────┤ X ├
┌───┐└─┬─┘
a_1: ───────────────┤ X ├──■──
┌───┐└─┬─┘
a_2: ──────────┤ X ├──■───────
┌───┐└─┬─┘
b_0: ─────┤ X ├──■────────────
┌───┐└─┬─┘
b_1: ┤ H ├──■─────────────────
└───┘  ```
Basically, treating the circuit as a whole when swapping the order of gates.

However, what the function reverse_bits() is currently doing (and test test_reverse_bits_with_registers() is ensuring) is it just reverses the order of qubits per register, and keeps the registers in the same order relative to each other, like so:```>>> print(qc1)
┌───┐
a_0: ┤ H ├──■─────────────────
└───┘┌─┴─┐
a_1: ─────┤ X ├──■────────────
└───┘┌─┴─┐
a_2: ──────────┤ X ├──■───────
└───┘┌─┴─┐
b_0: ───────────────┤ X ├──■──
└───┘┌─┴─┐
b_1: ────────────────────┤ X ├
└───┘

print(qc1.reverse_bits())
┌───┐
a_2: ┤ H ├──■─────────────────
└───┘┌─┴─┐
a_1: ─────┤ X ├──■────────────
└───┘┌─┴─┐
a_0: ──────────┤ X ├──■───────
└───┘┌─┴─┐
b_1: ───────────────┤ X ├──■──
└───┘┌─┴─┐
b_0: ────────────────────┤ X ├
└───┘

or, eqivalently:>>> print(qc1.reverse_bits())
┌───┐
b_0: ────────────────────┤ X ├
┌───┐└─┬─┘
b_1: ───────────────┤ X ├──■──
┌───┐└─┬─┘
a_0: ──────────┤ X ├──■───────
┌───┐└─┬─┘
a_1: ─────┤ X ├──■────────────
┌───┐└─┬─┘
a_2: ┤ H ├──■─────────────────
└───┘

So, my question is this: is the 2nd option (the current behavior of `reverse_bits()`) correct? And if so, should isolated qubits between registers be treated like an individual grouping (kind of like pseudo-registers), as in their order is only flipped with respect to that grouping of qubits?

According to the documentation, reverse_bits reversed within the register and does not change the order across the  whole circuit:
            reverse_bits (bool): when set to True, reverse the bit order inside
                registers for the output visualization. Defaults to False.

The individual (qu)bits should not be reversed.

Ok, thanks @1ucian0 for clearing that up!

Hi @apcarrik looks like you have some linting errors, if you run tox -eblack it should clear them up 😄

Sorry I'm only now catching up here.
This function should reverse the entire circuit qubits, no matter which registers (or no registers at all) the qubits belong to. The reason it exists is to switch endian-ness, e.g. a circuit that prepares the state a|001>+b|110> now prepares the state a|100>+b|011>. It's because some people prefer to work in little-endian and some in big-endian.
I really don't see registers as fundamental to the circuit. The circuit should be defined on qubits. Registers are just pointers to a collection of qubits for easier human reasoning. They have no meaning in the circuit or execution of the circuit.

Thanks for double checking @apcarrik ! I'll add my 2c after reading through the thread.
I think this bug can be fixed without changing the previous behavior of reverse_bits (though there's a lot of previous discussion so it's possible I'm missing something) that was passed over during #5498 . Strongly agree either way that part of this fix should be updating the reverse_bits docs so it's clearer what it's intention is.
From @ajavadia 's comment, the existing reverse_bits:

reverses the order of circuit.{qu,cl}bits (this is significant, more significant than the changes to registers since the bit index is paramount) such that any Instruction previously on q[i] in a j qubit circuit will now be on q[j-i-1].
also reverses the order of bits within each register (this leaves the original registers but in reversed order on the circuit, which I think lead to @jakelishman 's comment above)

I haven't had a chance to test in depth, but something like
        circ = QuantumCircuit(
            list(reversed(self.qubits)),
            list(reversed(self.clbits)),
            name=self.name,
            global_phase=self.global_phase,
        )
        for reg in reversed(self.qregs + self.cregs):
            circ.add_register(type(reg)(name=reg.name, bits=list(reversed(reg))))
        ...

should preserve both of these behaviors for both the cases of registered and registerless bits.
(Separately, from @1ucian0 's comment on the reverse_bits visualization kwarg, we should check that its behavior is consistent with that of QuantumCircuit.reverse_bits as I think it has entirely it's own implementation.)

Closing this since it is stale. See Issue 7628 for an updated treatment of the issues discussed here.


expose zombie count and add alert

Monitor two types of zombie container:

container with log displaying USER COMMAND END but still exist for a long period.
those containers whose yarn container not exist but job container still exist.

We only send out alert email when the count above 0 for 1 hour, because we just want to find out the root cause of zombie container.

Coverage decreased (-0.01%) to 51.62% when pulling 3913b0bfe489db1079a9ec0f59e01ecd4ea51828 on dixu/zombie-count into fb83b0d5d9e32b4ef6468191506ebf15becb8306 on master.


Users Table

Dear Volcan,
Please I have an existing database which already has a users table. I want to use this table as my users table and NOT the one generated by serene. How do I ensure my already existing users becomes the users table for the application and not the serene one? Is there any configuration I am expected to do and how would it affect upgrades?
Regards,
George

this is the same issue as #2184
you should really close this before opening another with the same problem. check the response in #2184.


Allow server to download cache from another clio server

Config takes an array of clio peers. If any of these peers have a
full cache, clio picks a peer at random to download the cache from.
Otherwise, fall back to downloading cache from the database

Needs a bit more testing and some cleanup, but ready for review

This change is

@godexsoft can you give this one more review? This is ready to go now, did lots of testing


sha3/keccak

I would be happy to see test vectors for sha3/keccack.
Any ideas how this test vectors can be added or generated?

just for note: test vectors can be found in KeccakCodePackage

example of test vectors usage: https://github.com/cryptocoinjs/keccak/blob/master/test/vectors-sha3.js


Add data explorer feature

Summary

How to test

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Base: 83.93% // Head: 83.29% // Decreases project coverage by -0.64% :warning:

Coverage data is based on head (efddbc7) compared to base (3aa4742).
Patch coverage: 29.13% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #773      +/-   ##
===========================================
- Coverage    83.93%   83.29%   -0.64%
===========================================
  Files          174      179       +5
  Lines        22941    23236     +295
  Branches      4973     5017      +44
===========================================
+ Hits         19255    19354      +99
- Misses        2559     2751     +192
- Partials      1127     1131       +4

Flag
Coverage Δ

macos-11_Python-3.10
?

macos-11_Python-3.7
?

macos-11_Python-3.8
?

macos-11_Python-3.9
?

ubuntu-20.04_Python-3.10
83.25% <29.13%> (-0.60%)
:arrow_down:

ubuntu-20.04_Python-3.7
82.91% <29.13%> (-0.63%)
:arrow_down:

ubuntu-20.04_Python-3.8
?

ubuntu-20.04_Python-3.9
?

windows-2019_Python-3.10
?

windows-2019_Python-3.7
?

windows-2019_Python-3.8
?

windows-2019_Python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

datumaro/cli/__main__.py
88.77% <ø> (ø)

datumaro/cli/commands/__init__.py
100.00% <ø> (ø)

datumaro/components/hl_ops.py
63.93% <0.00%> (ø)

datumaro/components/searcher.py
13.63% <13.63%> (ø)

datumaro/plugins/searcher.py
20.18% <20.18%> (ø)

datumaro/components/dataset.py
82.33% <33.33%> (-0.68%)
:arrow_down:

...ns/openvino_plugin/samples/clip_ViT-B_32_interp.py
42.85% <42.85%> (ø)

datumaro/cli/commands/search.py
44.44% <44.44%> (ø)

datumaro/util/samples.py
50.00% <50.00%> (ø)

datumaro/components/launcher.py
71.66% <69.23%> (-2.34%)
:arrow_down:

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


BUG: As a user, if I hit "enter" on my keyboard on household question for relationship, it skips the rest of the page and continues to the next page

@CalebPena @ivonne-hernandez I'm closing this one out cuz I think adding in the insurance selection on the household individual member actually resolved this since they can't just skip the rest of the page now.


Report generation issue – stream.push() after EOF

There was an issue reported to me by one of our developers. They were able to provide a reproducible test report. I've attached it here: test.js.zip
In our production environment, we see a "stream.push after EOF" error, here are the notes from the developer

I do not receive an error when running this report manually, but my system cannot open the generated PDF. Changing the “-75” near the bottom to a “-200” results in a PDF that my system can open normally.

I cannot duplicate the issue with the latest version; but I suspect the issue was also fixed in #152 as it appears to hits the same edge case that #152 hit.  Which corrupted the output buffer.


[Feature Request] highlight diff lines in normal editing

Currently when a file is modified in a revision control context some highlights appear in the gutter :

But it would be great to have a mean to highlight lines instead, like that:

In the screenshot above I am using the diff Editor, would be great to have this "line highlight" feature in normal editing.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Qiime2 Phylo-RPCA ValueError

Hello,
Firstly, thanks for making such a cool statistical test!
Unfortunately, I'm having some troubles running the phylo-RPCA.
I'm importing my data from DADA2 that's been run through R and have followed KeyError when attempting phylo-RPCA with Gemelli. I've specifically looked into the qza artifacts so I don't think its a formatting error (but to be fair I am new to qiime2). Eitherway, when I run the phylo-RPCA I get the following Error:
Plugin error from gemelli:

  No requested tips found

Debug info has been saved to /tmp/qiime2-q2cli-err-a24gvsx5.log

The Debug info is as follows
Traceback (most recent call last):
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/q2cli/commands.py", line 520, in __call__
    results = self._execute_action(
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/q2cli/commands.py", line 581, in _execute_action
    results = action(**arguments)
  File "<decorator-gen-46>", line 2, in phylogenetic_rpca_with_taxonomy
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/qiime2/sdk/action.py", line 342, in bound_callable
    outputs = self._callable_executor_(
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/qiime2/sdk/action.py", line 566, in _callable_executor_
    output_views = self._callable(**view_args)
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/gemelli/rpca.py", line 82, in phylogenetic_rpca_with_taxonomy
    output = phylogenetic_rpca(table=table,
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/gemelli/rpca.py", line 252, in phylogenetic_rpca
    phylogeny = bp_read_phylogeny(table,
  File "/home/aball/anaconda/envs/qiime2-amplicon-2023.9/lib/python3.8/site-packages/gemelli/preprocessing.py", line 270, in bp_read_phylogeny
    phylogeny = phylogeny.shear(names_to_keep).collapse()
  File "bp/_bp.pyx", line 758, in bp._bp.BP.shear
  File "bp/_bp.pyx", line 800, in bp._bp.BP.shear
ValueError: No requested tips found

I've found a similar error in Greengenes2 taxonomy's forums, but I didn't see an obvious connection to this code.

Angus

Hi @AngusBall,
Thanks for the kind words and for using the tools!
That error means there are no IDs mapping between the tree tips and the features in your table. I took a look and it seems that your table is just transposed. So the features and samples were flipped, thus no overlap. I transposed it and ran it and everything ran fine for me: Qiime2inputartifacts.zip
Closing this issue but feel free to re-open it if the problem persists for you.
Thanks,
Cameron


Should all libraries be in the same repo?

I used to have everything in the 1 repository here but split it out for easily automating doc uploads.
Now we've got docs.rs so this isn't a problem anymore.
I'm a bit worried having everything split will put people off contributing because this layer is really just gloss over elastic_reqwest, elastic_types and elastic_responses. That's not obvious and it's not obvious how to get code from those repos into this one.
I'm open to the idea of pulling everything together, but it would mean more churn just to undo a change that I made 6 months ago. Sunk cost etc etc.
On the other hand having this strong split has made it possible to design each piece to stand independently and kept them fairly cohesive. There are a few leaks in the way we do custom derive, but overall I think the edges are pretty clean. If everything came back together I'd like to keep that.
So the question is: Should we move everything into 1 repo? Or write up a Contributing.md that describes the repos you should checkout and how code moves upstream?
cc: @stephanbuys

I'm starting to lean towards pulling everything in together, but am not considering it a priority.
If it's all under the one repository, with the one build process we can get much better coverage for cross-cutting tests, integration tests, benchmarks etc that are checked on each build.

@KodrAus I'd second moving everything into one repo with a Cargo workspace.

I also like consolidation, and one crate with "features".

Thanks for your insight @theduke and @stephanbuys :+1:
I'm convinced that consolidating the libraries here is a good way to go. Once we've got a basic async API (should be in the next breaking release) then I think it'll be a good idea to pull everything in and work on some decent integration tests and benchmarks.
Having everything under 1 repo suggests they'll have the same release cadence, so it'll probably be worth syncing the version numbers too. Maybe a logical next step from that is moving everything into a single crate, but I'm not totally convinced on that yet. At least it doesn't need to be done at the same time.

I've started a project to track this. I'll also work on some kind of cargo tool that uses a cargo workspace to keep version numbers in sync, or set them to local so it's easy to do releases.

We shouldn't actually need any kind of cargo tool, turns out the path field on dependencies in Cargo.toml can co-exist with crates.io dependencies.
Now that the async API is merged in I think it's a good time to go and pull these in before the next release. Then we can coordinate the versions going forward.

💥 I've merged all the repos in here, relicensed as dual MIT/APACHE and bumped the dependencies up to the next common version (0.20.0). I hadn't realised there was so much code in here 😄 There's some additional housekeeping before pushing a release to crates.io (we're waiting on reqwest anyways).
I'll update the OP with some next steps to track across the other repos to point back here, move issues etc. With cargo workspaces I think this change is worth the churn.


Simplify lsb_release output

The reason I made this PR is simple.
Some distro's output of lsb_release -d is way too long. For example:

Therefore, I simplified it to only show the distributor ID and the release number
(aka. lsb_release -sir)

Tested on Gentoo, Fedora 24, CentOS 7, and Debian 8.5.

Will merge when I get home today, thanks :+1:

Arch shows:
# lsb_release -d
Distro: Arch Linux

# lsb_release -sir
Distro: Arch rolling

Yeah, this is problematic for true rolling distros. Perhaps we can use a new option: distro_shorthand?

A new option called distro_shorthand sounds good. :+1:

Alright, I'll do it when I get home later.

RFC on the new commit, please.

:+1:


Revert "use stopImmediatePropagation instead of stopPropagation"

Reverts Pomax/react-onclickoutside#36 based on https://github.com/Pomax/react-onclickoutside/issues/35#issuecomment-147157982 and https://github.com/Pomax/react-onclickoutside/issues/40

see first comment? https://github.com/Pomax/react-onclickoutside/pull/42#issue-111282317


Deployment failed

I am unable to deploy my solution. The deployment fails on the "Resource provisioning" step with the following output:
Creating Databricks cluster and starting featurization streaming job | Failed |
Traceback (most recent call last): File "run.py", line 117, in

Tyler, do you know what was the commit ID of the code you deployed?
In the latest Databricks run.py, line 117 is blank, which makes me think you tried some older version.

I simply deployed whatever was available on 6/18. I dig into the databrick's jobs and it looks like a quota failure for my subscription. I'll look into cleaning up some resources.
featurization_task output:
Run result unavailable: job failed with error message
Unexpected state for cluster (job-4-run-1):  Could not launch cluster due to cloud provider failures. azure_error_code: OperationNotAllowed, azure_error_message: Operation results in exceeding quota limits of Core. Maximum allowed: 100, Current in use: 99, Additional requested: 4. Please read more about quota increase at http://aka.ms/corequotaincrease.

Provisioning in a location that allowed for more cores completed successfully. I'm closing the issue but please be aware that this issue will re-occur for other peoples deployments and it's difficult to diagnose.


System Error after HTTPS using deploy-secured-nifi-with-ldap-authentication-with-toolkit

I am getting below error after implementing HTTPS with ldap.
System Error
The request contained an invalid host header [<IP_ADDRESS>:32468] in the request [/]. Check for request manipulation or third-party intercept.
Valid host headers are [empty] or:
<IP_ADDRESS>
<IP_ADDRESS>:8443
<IP_ADDRESS>
<IP_ADDRESS>:8443
localhost
localhost:8443
[::1]
[::1]:8443
test-nifi-0.test-nifi-headless.test.svc.cluster.local
test-nifi-0.test-nifi-headless.test.svc.cluster.local:8443
test-nifi.test.svc
I guess in values.yaml below value needs to be set as true?
security parameters
secured: false

I have attache app-log, bootstrep-log file with this issue. Can we also use ingress to expose the service using DNS and add certificate in the TLS?
You help will be much appreciated. :)
https://github.com/nileshlange/EW/blob/master/app-log.txt
https://github.com/nileshlange/EW/blob/master/bootstrap-log.txt
https://github.com/nileshlange/EW/blob/master/describe.txt

You cannot access NiFi UI via that ip, you can access via hostnames.
Follow the suggestion from "Notes" when you deploy the chart.
helm status <release-name
Ingress could be used. Already working on that change, it would be soon published.


Wrong command 'az deployment group'

Hello,
I think there is an error In a command:
templateFile="{provide-the-path-to-the-template-file}"
az deployment group create
--name blanktemplate
--resource-group myResourceGroup
--template-file $templateFile
Should be:
templateFile="{provide-the-path-to-the-template-file}"
az group deployment create
--name blanktemplate
--resource-group myResourceGroup
--template-file $templateFile
Best regards,
Mikhail Rutman.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bf283cd-65c2-09ad-0af2-37bf95fe4d90
Version Independent ID: 46451ccf-174a-e4da-433f-aa8c5570557d
Content: Tutorial - Create & deploy template - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/template-tutorial-create-first-template.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@mrutman Thank you for bringing this to our notice, will review the feedback and update the document accordingly.

@mrutman - thanks for this feedback. The CLI deployment commands were updated to use the new pattern of az deployment . This change was needed after adding subscription, management group, and tenant as possible scopes. You're right that there is still the az group deployment option, but we are now recommending the new syntax.

@tfitzmac Thanks a lot for helping on this thread.
@mrutman Thanks again for taking time to share your feedback. Hope the information shared by @tfitzmac is helpful to clarify why the current documentation is using "az deployment group create" . Requesting you to please review the information shared and revert back if you have any queries.
Hope the above information helps. At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Add environment variable for allowed origins for CORS

Closes #150

Changes proposed in this pull request:

New environment variable NB_API_ALLOWED_ORIGINS replaces hard-coded wildcard allowing all origins for CORS

default value is an empty string

Add utility function to parse origins into a list
Raise warning if no allowed origins are specified
Tests added that specified origins are parsed correctly + warning raised appropriately

Checklist

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

31 of 31 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
369

Relevant Lines:
369

💛  - Coveralls


Wrong return value when implicit return variable gets assigned inside defer block

What version of Go are you using (go version)?

$ go version
go version go1.20.3 darwin/arm64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/krishna.birla/Library/Caches/go-build"
GOENV="/Users/krishna.birla/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/krishna.birla/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/krishna.birla/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/krishna.birla/go/go1.20.3"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/krishna.birla/go/go1.20.3/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/krishna.birla/GolandProjects/testProjGo/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3z/yk_jktzn7kn2f73cgf3rq97w0000gq/T/go-build1179941713=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I ran the following code snippet:
package main

import (
	"fmt"
)

func myFunc1() (err error) {
	err = fmt.Errorf("func error")
	newErr := fmt.Errorf("new error")
	defer func() {
		// nothing here
	}()
	return newErr
}

func myFunc2() (err error) {
	err = fmt.Errorf("func error")
	newErr := fmt.Errorf("new error")
	defer func() {
		err = fmt.Errorf("defer error")
	}()
	return newErr
}

func main() {
	err1 := myFunc1()
	fmt.Printf("Case where implicit return variable is untouched in defer: %s\n", err1)

	err2 := myFunc2()
	fmt.Printf("Case where implicit return variable is overwritten in defer: %s\n", err2)
}

Link to playground: https://go.dev/play/p/-dSxEenEDA1
What did you expect to see?
I expected the following output:
Case where implicit return variable is untouched in defer: new error
Case where implicit return variable is overwritten in defer: new error

Even though a different new error (newErr) gets returned in the function, the caller receives the implicit error (err) which was modified inside the defer. When the implicit error (err) is NOT modified inside the defer, then the caller receives the different new error (newErr) as expected.
What did you see instead?
Instead, I saw the following output:
Case where implicit return variable is untouched in defer: new error
Case where implicit return variable is overwritten in defer: defer error

The caller should receive the different new error (newErr) in both cases, irrespective of whether the implicit error (err) gets modified inside the defer or not.

Your expectation about how return values and defer interact doesn't seem to match the specification. A return newErr isn't bypassing the explicitly defined err return value; instead, it assigns the value of newErr to err and returns, triggering the defer handler(s). You proposed change would break a lot of existing code (not least several instances of my own code), because it would completely alter the behavior of setting or changing named function return values from defer handlers.

@thediveo I agree, this changes the defer handler behaviour in other scenarios.
@thediveo Is this: "The returned new error is assigned to the named variable" documented anywhere? Can you point me to some documentation.

@thediveo Thanks for the clarification. Please point me to the documented behaviour of "local variable getting assigned to named variable". Closing this for now.

StackOverflow's your parent: answer to How does defer and named return value work, with links to the specification on return statements and defer statements.

A "return" statement in a function F terminates the execution of F, and optionally provides one or more result values. Any functions deferred by F are executed before F returns to its caller.

For instance, if the deferred function is a function literal and the surrounding function has named result parameters that are in scope within the literal, the deferred function may access and modify the result parameters before they are returned. If the deferred function has any return values, they are discarded when the function completes. (See also the section on handling panics.)

Thanks!

For anyone who comes across this later, to make it absolutely clear:
package main

import (
	"fmt"
)

func myFunc1() (err error) {
	err = fmt.Errorf("func error")
	newErr := fmt.Errorf("new error")
	defer func() {
		fmt.Println(err)
		// nothing here
	}()
	return newErr
}

func myFunc2() (err error) {
	err = fmt.Errorf("func error")
	newErr := fmt.Errorf("new error")
	defer func() {
		fmt.Println(err)
		err = fmt.Errorf("defer error")
	}()
	return newErr
}

func main() {
	err1 := myFunc1()
	fmt.Printf("Case where implicit return variable is untouched in defer: %s\n", err1)

	err2 := myFunc2()
	fmt.Printf("Case where implicit return variable is overwritten in defer: %s\n", err2)
}

has the output:
new error
Case where implicit return variable is untouched in defer: new error
new error
Case where implicit return variable is overwritten in defer: defer error

The newErr gets assigned to err, and then the defer modifies and returns it. In both cases, the object err is the one to be returned.

Personally, I'm taking likewise questions first to the go-nuts google group, with usually helpful results.


Pending pull request for beets

https://github.com/beetbox/beets/pull/2050

Can this issue be closed?  The changes from 2050 were released in beets 1.4.1.

Uhm jup :)

Uhm, nope :D I haven't implemented the changes in music-cyclon yet. Should get next month some time to fix this :/

Thanks to @nico202 for the fix. This can be closed now.


Weird behavior in Rust with OpenCV

I wrote some code like this.
extern crate opencv;

use self::opencv::highgui;
use self::opencv::core::Mat;

fn main() {
    load("image/test.jpg");
}

fn load(path: &str) {
    let src: Mat = highgui::imread(path, 1).unwrap();

    if src.empty().unwrap() {
        println!("Img load error");
    }
    else {
        println!("Img load success");
    }
}

When I run cargo run it shows Img load error.
However, when I added a println! at first line in load function like
fn load(path: &str) {
    println!("whatever");
    let src: Mat = highgui::imread(path, 1).unwrap();

    if src.empty().unwrap() {
        println!("Img load error");
    }
    else {
        println!("Img load success");
    }
}

It shows Img load success.
But when I change it to other code like let a: i32 = 1;, it shows Img load error again.
I have no idea what's going on.
System info:

OS: Manjaro Linux
Kernel: 4.3.0
Rust: 1.4.0

I had asked the same question here.

I'll have a look tomorrow, it's probably a problem in the crate indeed.

ok. I can't reproduce it here :/ Could you tell me which one was the expected behaviour ? In other words, is test image there ?

also, are you building in debug or release ?

This is my folder structure.

cargo.toml
[package]
name = "test"
version = "0.0.1"
authors = [ "Knovour <email>" ]

[dependencies]
opencv = "0.2.1"

I just added imshow in the end of function and it all shows image window no matter empty() is true or false.
extern crate opencv;

use self::opencv::highgui;
use self::opencv::core::Mat;

fn main() {
  load("image/test.jpg");
}

fn load(path: &str) {
  let src: Mat = highgui::imread(path, 1).unwrap();

  if src.empty().unwrap() {
    println!("Img load error");
  }
  else {
    println!("Img load success");
  }

  highgui::named_window(path, highgui::CV_WINDOW_AUTOSIZE).unwrap();
  highgui::imshow(path, &src).unwrap();

  highgui::wait_key(0).unwrap();
}

And I recreate the folder structure in Mac OSX, the empty() function always false but can show the image window, too.

ok. let me try to sum this up:
1/ we're dealing with the "ok" case, we actually expect imread to find the image and load it.
2/ imshow works, showing the matrix is not empty and imread is actually working
3/ in some cases, empty() returns true instead of false.
4/ we have a 100% reproducibility on your linux system with the first version of the code
5/ neither you nor me managed to reproduced in on osx.
Are we good so far ?

Yes.

ok, i reproduce it too in with virtual machine running ubuntu. investigating.

Thank you.

ok, i think i nailed it. please try 0.2.2. nice catch :)

YES! Both Linux and Mac OSX work perfectly!
Thank you.


Can't run keyd-application-mapper -m without app.conf

I think it should be possible to run the python script with -m even if there is no ~/.config/keyd/app.conf:
$ ./scripts/keyd-application-mapper -m
ERROR: could not find app.conf, make sure it is in ~/.config/keyd/app.conf

Alternatively, if we do want to require app.conf, then maybe this should just be a "debug mode" rather than "monitor"? I think that would be useful, and a debug mode need not return on line 274:
    if args.monitor:
        print(cls)
        return

This helped me debug my app.conf.

Yes, this makes more sense. Monitor mode can't run concurrently with an instance of the daemon anyway since certain monitors (i.e gnome) only allow a single process to monitor changes at a time.


tonumber has a maximum of<PHONE_NUMBER> (UINT32_MAX) when base is not 10

Hi,
I didn't have time yet to verify this on a desktop environment, but I can confirm the issue on ARM (cross compiled).
I used version 2.20.6 as a single header file in a C++/GCC project on a ubuntu 18.04 build system.
My defines:
-DSOL_USING_CXX_LUAJIT -DSOL_CHECK_ARGUMENTS -DSOL_USE_BOOST -DSOL_SAFE_FUNCTION
int main() {
    sol::state lua;
    // should print something like 9,223372037e18 (INT64_MAX)
    // but will get the maximum of<PHONE_NUMBER>
    lua.script("print(tonumber('7fffffffffffffff', 16))");

    return 0;
}

The example above is with base 16, a common case, but all values other than 10 will produce the same issue.
Thanks in advance

The code there is basically the same as opening a lua interpreted and typing print(tonumber('7fffffffffffffff', 16)) to it. No sol required anywhere, so probably not related to sol.
Luajit is very strict about the manual from what I have read.
From lua51 manual https://www.lua.org/manual/5.1/manual.html#pdf-tonumber

In base 10 (the default), the number can have a decimal part, as well as an optional exponent part (see §2.1). In other bases, only unsigned integers are accepted.

Emphasis mine.
So basically only base 10 works with numbers higher than unsigned int max.

Yeah, what @Rochet2 said.
You should also consider that the most Lua 5.1 and LuaJIT do not have dedicated integers at all.
Lua 5.2 and Lua 5.3 do have integers, but are still subject to Lua's rules.
I can't help you here, I don't think...!

Ok, thanks for the explanation.
I tried online using repl where lua version 5.1 is used and the output is correct.
I can't tell if it's luajit so probably that's the difference?

repl.it implements its own lua. I think its made in javascript or something. In any case before some updates it couldnt even correctly parse hex numbers.
In real lua the behavior is the same.


Autoconfigure optimization

Add spring-boot-autoconfigure-processor to spring-cloud-stream
and spring-cloud-stream-reactive modules for auto configuration optimization.
Resolves #1410

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eea20be). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1411   +/-   ##
=========================================
  Coverage          ?   61.05%
  Complexity        ?      821
=========================================
  Files             ?      133
  Lines             ?     3965
  Branches          ?      565
=========================================
  Hits              ?     2421
  Misses            ?     1257
  Partials          ?      287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea20be...b7b9636. Read the comment docs.


Not localized on macOS (JVM)

Thanks for making this lib!
I like its API very much.
I noticed that on macOS (JVM) the FilePicker as well as the DirectoryPicker are not localized. They are always presented in English. On Windows the pickers are presented in the systems default language.
This is the same problem I currently encounter with compose-multiplatform-file-picker.

Thank you @StefanOltmann!
I was able to localize the picker by modifying the Info.plist of the project and adding the "Localizations" key and the different languages I wanted to support in the app:

After that, the picker is automatically localized if the language is supported in the Info.plist:

If you don't have access to the Info.plist because you're using Compose Multiplatform, you can use this documentation to modify the Info.plist like you want.
Does this solve your issue?

Thank you. I will look into that next week. :)


Fix failing tests when compiled on ubuntu

When compiled on Ubuntu, the following tests are failing (segmentation fault)

erase-element
flip-diagonal

Find the root cause and provide a fix if possible, otherwise create new issues accordingly.

The element erasion algorithm was buggy and has been fixed in rev. 19795af.


Redfish test automation

Sub task from https://github.com/openbmc/openbmc-test-automation/issues/1535
https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/17996/
https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/18124/

Initial cod work and discussion and test plans


Removing Windows 8.1 from build pipelines

Win 8.1 went EOL in January. We stopped building it, but still needed to clean up references to it.

/lgtm


[BUG]Nuclearcraft oxygen lakes spawning in moon

Version of Advanced Rocketry

1.12.2-1.7.0-204-universal

Have you verified this is an issue in the latest unstable build

[x] N/A

Version of LibVulpes

1.12.2-0.4.2-74-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

[x] N

Description of the problem

Nuclearcraft Oxygen is spawning in pool and lakes in the MoonDark biome. Oxygen is a fluid that flows up to the sky. When it spawns in pools and lakes the incredible number of flowing blocks causes the game to freeze and sometime crash.

This is a side effect of some of the planet generation code, due to Advanced Rocketry spawning liquid oxygen there. It's using NuclearCraft's block instead of Advanced Rocketry's. What needs to happen is to have a blacklist for NuclearCraft oxygen.

Is there a config where I can blacklist the nuclearcraft fluid? I spent a couple hours looking last night but wasn't able to find anything.

I found a closed issue from a while back that covers the conflict with nuclearcraft. https://github.com/zmaster587/AdvancedRocketry/issues/931#issue-272062389
In this Thutmose covers how when the fluid is getting registered twice and it is getting overridden. I have also confirmed in my testing that there is no recipes that use AdvRocketry Oxygen as well as it being impossible to spawn in to the world. Whenever I attempt to spawn the AdvRocketry it automatically spawns the nuclearcraft oxygen that flows up.

@EnderN3x The behaviour you're experiencing is a result of of #931.  Since two fluids cannot exist with the same name one or the other gets chosen.  For the most part that's determined by forge mod loading order.  If nuclearcraft is loaded before AR is, nuclearcraft's O2 will be used for all O2 in AR.  If AR is loaded before nuclearcraft, is nuclearcraft handles fluid correctly, then AR's fluid would be used for everything in nuclearcraft.

Is there a config where I can blacklist the nuclearcraft fluid? I spent a couple hours looking last night but wasn't able to find anything.

No, there's not, doing so would be a violation of convention (and was the whole reason for #931).
I suppose one resolution to the issue would be to create another O2 fluid (LOX or something?) and have that spawn instead.

I appreciate the fast response. Is there a way I can do that on my end? It isn't the end of the world or anything if I can't, but if possible I would like to allow the random generation of planets with all the normal biomes.

Idk if there's a mod out there that can let you mess with load order or not, but if that's a thing you can enforce AR loading before nuclearcraft.  Otherwise you may just have to remove all the O2 oceans from the planetDefs.xml.  That'll at least make it playable.  You could maybe replace it with nitrogen, it wouldn't be too far off from default gameplay since either have a chance to spawn.

I'll see if creating a 2nd O2 fluid is viable to prevent this issue again in the future.


[SPARK-9244] Increase some memory defaults

There are a few memory limits that people hit often and that we could
make higher, especially now that memory sizes have grown.

spark.akka.frameSize: This defaults at 10 but is often hit for map
output statuses in large shuffles. This memory is not fully allocated
up-front, so we can just make this larger and still not affect jobs
that never sent a status that large. We increase it to 128.

spark.executor.memory: Defaults at 512m, which is really small. We
increase it to 1g.

Merged build triggered.

Merged build started.

Test build #38039 has started for   PR 7586 at commit ce0038a.

Test build #38039 timed out     for PR 7586 at commit ce0038a     after a configured wait of 175m.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #38086 has started for   PR 7586 at commit ce0038a.

Test build #38086 has finished for   PR 7586 at commit ce0038a.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1159 has started for   PR 7586 at commit ce0038a.

Test build #1159 has finished for   PR 7586 at commit ce0038a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

FWIW LGTM

Alright, thanks for taking a look.


add authfile generation

Do we need to start/enable the authfile service or is just the timer sufficient?

Not sure.  But when I tried to start it in the order given, systemd complained about "dependency". (though, which dependency is not printed out)


LLaVA-OneVision for single-image, multi-image, and video

Thank you for the great work here!
LLaVA-OneVision seems to be the latest model from the LLaVA family of models that performs well out of open source LMMs. While it's still early, raising it here as others in the community may start to look at it.
https://llava-vl.github.io/blog/2024-08-05-llava-onevision/

Thanks for raising this. We've also noticed it and including it into lmms-finetune is part of our recent plan.

We will wait a bit until the model implementation is merged into the main branch of transformers.
https://huggingface.co/llava-hf/llava-onevision-qwen2-0.5b-ov-hf/discussions/1
https://github.com/huggingface/transformers/pull/32673

Are there any updates on this? It seems LLaVA-Onevision got merged into the main branch of transformers now: https://github.com/huggingface/transformers/pull/32673

We will include it once we are free, probably in 2 - 3 weeks.