Admin theme re-design.

Admin theme re-design.
Login page:
-removed top help link as it already could be found in the bottom one.
-moved go to main site link to the right.
-edited css to simplify the mess with positioning.
-made a new login button , with a little animation when clicked.
-added the themed blue line.
Admin panel:
-left menu is now hidden for a cleaner look.
-added dashboard link to the menu.
-top settings link is now settings only, and does not include theme settings anymore.
-removed the top navigation buttons for a cleaner look.
-added order/invoice/support buttons to the top menu with notifications.
-moved profile avatar to the right of the top menu.
-clicking profile name will also redirect to profile page now.
-edited display name for client in certain tables to show entire first name up to 15 characters, and then last name initial only. When a client register, it is asked for his first name only, therefore most of the clients will not update in profile their last name too and this will result into having your statistic tables filled up only with first name initials.
-edited display stats look.
-added the themed blue line.
CSS:
-minified to beautify.
NOTE:
-i haven't touched/checked if is responsive to different resolutions.
-expecting reports if any problem was introduced.

Hey, @xSido
Would you mind attaching some screenshots of the new look?
Thank you!

Hey, @xSido Would you mind attaching some screenshots of the new look?
Thank you!

Ofc not. Here they are.

I just pushed a slight change to center these icons

Also, It's not work that you did, but I'm not sure if we should have the orders icon link to orders that have failed setup

: I would like it if the entire thing here acted as the link, rather than just the numbers

yeah, thought the same, with next update :D

i haven't touched/checked if is responsive to different resolutions.
I tested it and the theme definitely isn't responsive. Mostly fine on larger screens (ipad or bigger probably), but not phones. It becomes unusable on a phone because the menu can no longer be expanded.

that will be the next step

Also, it's pretty minor but I think we should keep "min.css" minimized for production. Would be perfectly fine with you creating a new one that isn't minimized, but keeping it minimized is best practice for production.

i have no problem in doing that.

Looks nice except the togglable sidebar. I think it can be improved but I like the idea.

in future will be improved (design speaking) but atm is the base and need to be functional :D

Admin theme re-design - fix responsive.
Login page:
-fixed go to main site link (it was disappearing on mobile).
-added space under login panel (bottom was not visible under scroll).
-footer is now fixed (it was scrolling with the page).
Admin panel:
-top menu is now hided into a right panel in mobile view.
-fixed left menu submenu (were not responsive).
-fixed stats (were not responsive).
-reduced size of side menues.
Admin theme re-design - fix stats.
Stats:
-fixed size.
-fixed responsive size.
-entire list is now a link (istead just the number).
NOTE:
-expecting reports if any problem was introduced

.

Why do we use the same menu icon for two different sidebars?
Based on screenshots, I actually like the old sidebar better. The new one just looks like a list of links with no styling.
CodeFactor found 400+ issues. Haven't checked them individually yet though.

Why do we use the same menu icon for two different sidebars?
Because this is the first step in redesigning the admin panel. I doubt there will be anyone doing the entire work and then publish it in 1 commit. Especially when it need to be approved and it might not pass.

CodeFactor found 400+ issues. Haven't checked them individually yet though.
yes, there are some mistakes introduced by me.
6x  Unexpected unit (length-zero-no-unit)  while it worked the way i made, will correct this little problem.
3x Unexpected empty block - because i wanted to implement in future something there, but will remove them for now then.

but rest of them are from existing code.
most of them duplicated selector, maybe for cleaner look.

Seems like stoped work on this PR. I'd like to help finish redesign admin theme with migrate to SCSS, remove browser prefixes prefer Autoprefixer and build frontend with Npm. All like most modern projects. ;)
What do you think about it?

Seems like stoped work on this PR. I'd like to help finish redesign admin theme with migrate to SCSS, remove browser prefixes prefer Autoprefixer and build frontend with Npm. All like most modern projects. ;) What do you think about it?

Contributor activity is pretty much dead at this point but sure, why not? I think a complete frontend rewrite might boost the interest in the project and give it a completely new look. I'm looking forward to it.

Just give me a few PHP (or HTML) and (S)CSS files so I can change theming as I require it. I might throw out a few simple themes. For now, I have not yet read through the theming part of the docs - but judging the files by a first glance, it doesn't look as straight forward as I'd like it to be.
Also: Admin BackEnd needs a DarkMode. Really important! (I am using DarkReader but that's just looking urghs.)
It would also really help if not everything was on github - as, for example, the linked extensions.boxbilling.org seems down. Oh and if there was a few better explanations/previews (for mods and stuff). ;)

I know the backend sucks, and I don't think we can do anything with it in the short term. Everything is under bb-themes.

@xSido do you have any intentions of continuing work on this PR?

@andpavlenko @xSido This branch has conflicts that must be resolved
Use the web editor or the  command line  to resolve conflicts.
Conflicting files
src/bb-themes/admin_default/html/layout_default.phtml
src/bb-themes/admin_default/html/layout_login.phtml
src/bb-themes/admin_default/html/mod_client_index.phtml
src/bb-themes/admin_default/html/mod_invoice_index.phtml
src/bb-themes/admin_default/html/mod_invoice_transactions.phtml
src/bb-themes/admin_default/html/mod_order_index.phtml
src/bb-themes/admin_default/html/mod_support_public_tickets.phtml
src/bb-themes/admin_default/html/mod_support_tickets.phtml


[Camera][Android] Rendering is split in two

Steps to reproduce

Run the example code

Expected results
A full screen portrait camera preview
Actual results
A split screen with two camera preview (Real device: One Plus 6 Android v11)
Interestingly, on the Pixel 3a API 34 emulator, we also see two parts in the rendering.
However, it does work properly on iOS (all iPhones)
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:camera/camera.dart';

class TestPageContent extends StatefulWidget {
  const TestPageContent({super.key});

  @override
  State<TestPageContent> createState() => _TestPageContentState();
}

class _TestPageContentState extends State<TestPageContent>
    with WidgetsBindingObserver {
  CameraController? _cameraController;

  @override
  void initState() {
    super.initState();
    _onCameraInit();
  }

  _onCameraInit() async {
    debugPrint('_onCameraInit');

    setState(() {});
    final cameras = await availableCameras();
    if (cameras.isEmpty) {
      return;
    }

    try {
      CameraDescription camera = cameras.firstWhere(
          (camera) => camera.lensDirection == CameraLensDirection.back,
          orElse: () => cameras.first);

      _cameraController = CameraController(camera, ResolutionPreset.max);
      await _cameraController?.initialize();
    } catch (e) {
      print(e);
    }
    setState(() {});
  }

  @override
  void dispose() {
    _cameraController?.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    if (_cameraController?.value == null) {
      return Column(
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          Expanded(
            child: Center(
              child: Column(
                mainAxisSize: MainAxisSize.min,
                children: [
                  ElevatedButton(
                    onPressed: () {
                      _onCameraInit();
                    },
                    child: const Text("Initialize camera"),
                  ),
                ],
              ),
            ),
          ),
        ],
      );
    }

    return CameraPreview(_cameraController!);
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
I/Camera  (20005): startPreview
I/flutter (20005): [ROUTER]: /test
I/Camera  (20005): CameraCaptureSession onConfigured
I/Camera  (20005): Updating builder settings
D/Camera  (20005): Updating builder with feature: ExposureLockFeature
D/Camera  (20005): Updating builder with feature: ExposurePointFeature
D/Camera  (20005): Updating builder with feature: ZoomLevelFeature
D/Camera  (20005): Updating builder with feature: AutoFocusFeature
D/Camera  (20005): Updating builder with feature: NoiseReductionFeature
I/Camera  (20005): updateNoiseReduction | currentSetting: fast
D/Camera  (20005): Updating builder with feature: FocusPointFeature
D/Camera  (20005): Updating builder with feature: ResolutionFeature
D/Camera  (20005): Updating builder with feature: SensorOrientationFeature
D/Camera  (20005): Updating builder with feature: FlashFeature
D/Camera  (20005): Updating builder with feature: ExposureOffsetFeature
D/Camera  (20005): Updating builder with feature: FpsRangeFeature
I/Camera  (20005): refreshPreviewCaptureSession
W/Gralloc4(20005): allocator 3.x is not supported
W/Gralloc3(20005): allocator 3.x is not supported

Flutter Doctor output
Doctor output
➜  enter_train_me git:(master) ✗ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.19.0-9.0.pre.88, on macOS 14.4.1 23E224 darwin-arm64, locale en-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.88.0)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

@Jpec57

Channel master, 3.19.0-9.0.pre.88

You are on older version of master. Current master version is 3.22.
Also,  I checked your code sample using latest stable version (3.19.5) running on S10 and Pixel emulators and on both, I didn't see the split screen behavior.

Please upgrade to latest master or stable and re-run your scenario to confirm.

@darshankawar I am deeply sorry to have overlooked this. It is indeed working with the latest release. Thank a lot


Update changelog

There are new models for the tralü’s cave and school of magic too.

Also, you can now select bricks in iso scène editor (and see their properties)

Hey we actually got quite a lot of stuff done!
"Special implementation of the Dome of the Slate. You're going to be amused!!!" change that to "You're going to be amazed!!!"? amused is a bit of a weird word there.
other than that lgtm, lol @ you can punch FunFrock :D

About punching FF, maybe we should actually punch him in the trailer! That would be cool!

Yea should be doable! The reason I didn't for the video is because FunFrock isn't as easy a target as the casino guy and FunFrock is in an iso environment rather than an island which can look a bit weird in VR.

Oh right, I didn’t think about the iso env part, and making him appear and
behave properly in another scene would be too much work.
Le mer. 2 sept. 2020 à 22:03, Scott<EMAIL_ADDRESS>a écrit :

Yea should be doable! The reason I didn't for the video is because
FunFrock isn't as easy a target as the casino guy and FunFrock is in an iso
environment rather than an island which can look a bit weird in VR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/agrande/lba2remake/pull/360#issuecomment-685966291,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANHI53CFZVLDHKFT5LQ7BDSD2QJVANCNFSM4QTOZXRQ
.

Thanks for the updates, I will do them later today.

Changelog updated


[core] Fix outputlevel is still 0 in extreme scenarios

Purpose
Fix outputlevel is still 0 in extreme scenarios.
This may not be a common case, but it is indeed possible.
For a newly created paimon pk table, with default parameters for num-levels and
others, without adjusting the max-size-amp, size-ratio, and other
configurations, assuming all configurations are using default values.
For a specific bucket:
file1 (1kb) is written,
file2 (1kb) is written,
file3 (1kb) is written,
file4 (1mb) is written,
file5 (10mb) is written
The srS of level0 will be sorted according to
https://github.com/apache/incubator-paimon/blob/master/paimon-core/src/main/java/org/apache/paimon/mergetree/Levels.java#L58
In this situation, these five level0 files may not go through the pickForSizeAmp
function, outputlevel is 0. This may cause a larger file to appear in level0. I
think setting the outputlevel to 5 would be more ideal.

Linked issue: close #xxx

Tests
Add UT org.apache.paimon.mergetree.compact.UniversalCompactionTest#testExtremeCaseNoOutputLevel0

API and Format

Documentation

See UniversalCompaction.createUnit, we force picking to output level 1...

See UniversalCompaction.createUnit, we force picking to output level 1...

But actually, this result is 0.
`        UniversalCompaction compaction = new UniversalCompaction(200, 1, 5);
    Optional<CompactUnit> pick =
            compaction.pick(
                    6,
                    Arrays.asList(
                            level(0, 1),
                            level(0, 1),
                            level(0, 1),
                            level(0, 1024),
                            level(0, 1024 * 1024)));

    assertThat(pick.isPresent()).isTrue();
    long[] results = pick.get().files().stream().mapToLong(DataFileMeta::fileSize).toArray();
    assertThat(results).isEqualTo(new long[] {1, 1, 1, 1024, 1024 * 1024});
    // pick.get().outputLevel() -> the result is 0

`

@lipenglin You are right, see above comment.

@lipenglin You are right, see above comment.

done.
PTAL

Please fix tests.

Please fix tests.

done


Bug: scope-manager does not support the ecmaVersion option set to "latest."

Which packages are affected?

[ ] espree
[X] eslint-scope
[ ] eslint-visitor-keys

Environment
Node version:
npm version:
ESLint version:
Operating System:
What did you do?
Tried to set the ecmaVersion option to lastest in the scope-manager.
What did you expect to happen?
Since we selected the "latest" option, it should recognize the most recent ECMAScript version and support import declarations.
What actually happened?
Got the below error:

ImportDeclaration should appear when the mode is ES6 and in the module context.

https://github.com/eslint/js/blob/91d51d3da4273acaf2523a3b6d23a27a733c13cc/packages/eslint-scope/lib/scope-manager.js#L243
The above condition becomes false when the ecmaVersion option is set to latest.
Link to Minimal Reproducible Example
https://deploy-preview-31--eslint-code-explorer.netlify.app/
Participation

[X] I am willing to submit a pull request for this issue.

Additional comments
In Espree, the ecmaVersion option can be set to "latest" to support the most recent ECMAScript features.
https://github.com/eslint/js/blob/91d51d3da4273acaf2523a3b6d23a27a733c13cc/packages/espree/lib/options.js#L50
Should we maintain consistent handling and options for ecmaVersion in both Espree and eslint-scope?

This isn't actually a bug because "latest" was never intended to work in eslint-scope. In order to do that, we'd need to keep updating the package, which I don't think is worth the effort. espree already exports latestEcmaVersion that indicates which version "latest" corresponds to. Can you use that?

This isn't actually a bug because "latest" was never intended to work in eslint-scope. In order to do that, we'd need to keep updating the package, which I don't think is worth the effort. espree already exports latestEcmaVersion that indicates which version "latest" corresponds to. Can you use that?

Sure, I'll use espree to determine the "latest" version. Should we update the eslint-scope README file to recommend using espree for obtaining the latest version if the "latest" option is used for ecmaVersion?
Another option is to use the latestEcmaVersion exported by espree directly within eslint-scope to determine the latest version, rather than suggesting users utilize espree separately. If we choose not to update the eslint-scope package, we can ignore it.

Actually, we only care if it's greater than 5, we can do something like eslint did:
https://github.com/eslint/eslint/blob/8781e6f063e56438dc22346504ff637df3f84daf/lib/linter/linter.js#L919

We only care if it's greater than 5 right now. We don't know what scope changes might come in the future.

Sure, I'll use espree to determine the "latest" version. Should we update the eslint-scope README file to recommend using espree for obtaining the latest version if the "latest" option is used for ecmaVersion?

I don't think that's necessary. This package is used mostly by us, and for anyone else who's using it, I assume they know what ecmaVersion they want.

Another option is to use the latestEcmaVersion exported by espree directly within eslint-scope to determine the latest version, rather than suggesting users utilize espree separately. If we choose not to update the eslint-scope package, we can ignore it.

That would require that eslint-scope to have a dependency on Espree, which we don't want.

If there's no AI involved, we can close this issue.

Sounds good. And by AI, I think you mean action item rather than artificial intelligence. :smile:


startapp.start callback methods not working in Ionic 3

Hello lampa,
i am trying to open external app with some callback activity. so for that below is my code.
this.appStarter = (window as any).startApp.set({ "application": appId });

this.appStarter.start(function (){
    alert("Success Callback");// any other code also not working here.
}, function(){
    alert("Error Callback");// any other code also not working here.
});

In Above code success callback and error callback are not working in both method startApp.check() and startApp.start()
Note: external app is opening successfully.
Is there any other way to execute callback methods?

@pravinCignex Hi!. Alert not working in cordova, but callbacks should work exactly, check via console.log()


chore: Fix JSON schema strict validation error

Reason for This PR
type property is missing from metrics object.
Description of Changes
Added type property to metrics object.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.06%. Comparing base (c5a93ee) to head (9e19b6e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   40.06%   40.06%
=======================================
  Files          14       14
  Lines         936      936
=======================================
  Hits          375      375
  Misses        518      518
  Partials       43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update wasm-bindgen from 0.2.87 to 0.2.89

Any update on this one? seems like pinning 0.2.87 causes issues when trying to use other crates that already got updated (for example tracing/tracing-opentelemetry)

@dotansimha this repository doesn't seem to be maintained much, unfortunately.

Done in #450


Expand distributed_app example

This expands the distributed_app "alice" and "bob" example apps with Dockerfiles, a docker-compose file, and unit tests to assert the structure of one of the distributed traces it produces. It also adds a simple Node.js app "caroljs" as part of the stack as well.

[Current coverage][cc-pull] is 100%

Merging [#20][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #20   diff @@
===================================
  Files          13    13
  Lines         844   850     +6
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits          844   850     +6
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [232142d...d77e41f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/appneta/go-appneta/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/appneta/go-appneta/compare/232142db37994ec482ff8d40f059231e5c257b73...d77e41f87a05912d829dd27f84f9834c175e4e86
[cc-pull]: https://codecov.io/gh/appneta/go-appneta/pull/20?src=pr

Coverage remained the same at 100.0% when pulling d77e41f87a05912d829dd27f84f9834c175e4e86 on v1examples into 232142db37994ec482ff8d40f059231e5c257b73 on master.

Coverage remained the same at 100.0% when pulling c58468b5d12f03e259b7fe4cd4d1dd3b2c2df1be on v1examples into 232142db37994ec482ff8d40f059231e5c257b73 on master.


Dev

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 95.44554% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.42%. Comparing base (d987394) to head (e31350c).
Report is 9 commits behind head on main.

Files with missing lines
Patch %
Lines

project/docs/templatetags/integer_element.py
58.33%
5 Missing :warning:

project/docs/templatetags/char_element.py
63.63%
4 Missing :warning:

project/docs/templatetags/float_element.py
63.63%
4 Missing :warning:

project/docs/templatetags/image_element.py
42.85%
4 Missing :warning:

project/docs/templatetags/text_element.py
42.85%
4 Missing :warning:

project/docs/models.py
89.47%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   88.46%   89.42%   +0.95%
==========================================
  Files         115      125      +10
  Lines        4221     4575     +354
==========================================
+ Hits         3734     4091     +357
+ Misses        487      484       -3

Flag
Coverage Δ

unittests
89.42% <95.44%> (+0.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[GH-50] New element: Composite Element

The Composite Element is composed of a list of other elements. This is used for grouping spatial primitives into more complex individual objects.
Attributes may be defined on the Composite Element (these must correspond to each element - so if you have 5 elements, the attribute array must be length-5). Attributes may also be defined on each individual element.
Note - following up on the discussion here https://github.com/gmggroup/omf/issues/50 I chose to disallow nesting of multiple composite elements. I believe this is still general enough for most use cases, and it eliminates the requirement to implement arbitrarily deep nesting of composite elements when adopting OMF.

Codecov Report

Merging #88 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev      #88      +/-   ##
==========================================
+ Coverage   96.61%   96.69%   +0.08%
==========================================
  Files          11       12       +1
  Lines         502      515      +13
==========================================
+ Hits          485      498      +13
  Misses         17       17

Impacted Files
Coverage Δ

omf/__init__.py
100% <100%> (ø)
:arrow_up:

omf/lineset.py
100% <100%> (ø)
:arrow_up:

omf/base.py
95% <100%> (ø)
:arrow_up:

omf/surface.py
96.22% <100%> (ø)
:arrow_up:

omf/composite.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dc6a9...9dde162. Read the comment docs.

Looks good.
Being able to have per element data is something I didn't think about and seems quite useful.

Totally agree @dbrookes96, I am really excited about this element type!


Code Coverage seems to be not working

Take a look at https://github.com/opensearch-project/security/pull/1592 code coverage seems to not print the report.

Looking into this, I think we need to add coverage data configuration in the build.gradle

From https://github.com/opensearch-project/security/runs/5203912330?check_suite_focus=true
_____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.3

==> git version 2.35.1 found
==> curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets
==> GitHub Actions detected.
    Env vars used:
      -> GITHUB_ACTIONS:    true
      -> GITHUB_HEAD_REF:
      -> GITHUB_REF:        refs/heads/main
      -> GITHUB_REPOSITORY: opensearch-project/security
      -> GITHUB_RUN_ID:<PHONE_NUMBER>
      -> GITHUB_SHA:        21dd8ce2136fb847[45](https://github.com/opensearch-project/security/runs/5203912330?check_suite_focus=true#step:10:45)1e2cfa5872d8e[50](https://github.com/opensearch-project/security/runs/5203912330?check_suite_focus=true#step:10:50)6df82e3
      -> GITHUB_WORKFLOW:   CI
    project root: .
--> token set from env
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
--> No coverage report found.
    Please visit http://docs.codecov.io/docs/supported-languages


Symbols in password causes authentication errors

Environment:
Windows 7 64-bit
Python 3.5
Python dependencies look up to date.
python -m pip install --upgrade coursera-dl
Requirement already up-to-date: coursera-dl in c:\python35\lib\site-packages
Requirement already up-to-date: beautifulsoup4>=4.1.3 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: html5lib>=1.0b2 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: requests>=2.4.3 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: six>=1.5.0 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: urllib3>=1.10 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: pyasn1>=0.1.7 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: keyring>=4.0 in c:\python35\lib\site-packages (from coursera-dl)
Requirement already up-to-date: pywin32-ctypes; sys_platform == "win32" in c:\python35\lib\site-packages (from keyring>=4.0->coursera-dl)

Authentication occurs with some symbols such as !@#$%*
python dl_all.py -u username -p Easypassword1@#$%* -v -a -q --headless
https://class.coursera.org/androidpart1-014/ androidpart1-014
coursera_dl version 0.6.1
Downloading class: androidpart1-014
Starting new HTTPS connection (1): class.coursera.org
Starting new HTTPS connection (1): class.coursera.org
Starting new HTTPS connection (1): www.coursera.org
Logged in on coursera.org.
Found authentication cookies.

Authentication fails with ^ in the password.
python dl_all.py -u username -p Easypassword1^ -v -a -q --headless
https://class.coursera.org/androidpart1-014/ androidpart1-014
coursera_dl version 0.6.1
Downloading class: androidpart1-014
Starting new HTTPS connection (1): class.coursera.org
Starting new HTTPS connection (1): class.coursera.org
Starting new HTTPS connection (1): www.coursera.org
Could not authenticate: Cannot login on coursera.org.

Authentication with & in the password seems to ignore --headless option and tries to start Firefox which automatically updated itself to v47.
python dl_all.py -u username -p Easypassword1& -v -a -q --headless
https://class.coursera.org/androidpart1-014/ androidpart1-014
Traceback (most recent call last):
  File "dl_all.py", line 317, in <module>
    session = webdriver.Firefox()
  File "C:\Python35\lib\site-packages\selenium\webdriver\firefox\webdriver.py", line 81, in __init__
    self.binary, timeout)
  File "C:\Python35\lib\site-packages\selenium\webdriver\firefox\extension_connection.py", line 51, in __init__
    self.binary.launch_browser(self.profile, timeout=timeout)
  File "C:\Python35\lib\site-packages\selenium\webdriver\firefox\firefox_binary.py", line 68, in launch_browser
    self._wait_until_connectable(timeout=timeout)
  File "C:\Python35\lib\site-packages\selenium\webdriver\firefox\firefox_binary.py", line 98, in _wait_until_connectable
    raise WebDriverException("The browser appears to have exited "
selenium.common.exceptions.WebDriverException: Message: The browser appears to have exited before we could connect. If you specified a log_file in the FirefoxBinary constructor, check it for details.

'-v' is not recognized as an internal or external command,
operable program or batch file.

I think the best way to solve this problem is to change your password temporarily. U know today is June 27th... We don't have much time to waste on such easy-to-handle problem. Yet it is a bug as we know.

The way to get around this is by using quotes in your command line arguments. For example, if you do
python dl_all.py -u username -p "Easypassword1@%$&"
it should work.


Added notes for GCCH

[Enter feedback here]
On Step 7 for the setup, this does not account for connecting to a GCCH tenant for Exchange Online and needs to be updated or a link provided to the correct metadataurl:
https://login.microsoftonline.us/metadata/json/1

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d4a7165a-d7a7-fecd-3260-f6be07a6f331
Version Independent ID: aa92c5c1-3e94-ae45-5e0c-8d5edd4f4f5f
Content: Connect Exchange Online to Dynamics 365 Customer Engagement (on-premises)
Content Source: ce/customerengagement/on-premises/admin/connect-dynamics-365-on-premises-exchange-online.md
Product: d365ce-op
GitHub Login: @Mattp123
Microsoft Alias: matp

Thanks for your comment, @Ursangus. This issue has been assigned to the doc author for review.

@Ursangus - The article has been updated to include an alert with the URL for GCCH.
Closing issue.


Search beatmaps by hash

Proposed Changes
I have a tool relying on the search by hash that beatsaver used to offer (useful to connect with scoresaber). This very simple PR adds it back.
Platforms
This pull request modifies: (select all that apply)

[ ] Client
[x] Server

Types of Changes
This pull request is contains: (select all that apply)

[ ] Bug fixes (non-breaking change which fixes an issue)
[x] New features (non-breaking change which adds functionality)
[ ] Breaking changes (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the contribution guidelines
[x] I have checked the changes adhere to the project's style guide and all tests pass
[x] I have (to the best of my ability) checked for vulnerabilities, or any ways that my code could be abused and concluded that it is safe to run in production

Further Comments
I understand that the new version is taking a lot of effort and this might not be the priority. Hopefully that helps out.

I believe that already exists in /api/maps/by-hash/

https://github.com/lolPants/beatsaver-reloaded/blob/231427d0b2e27b99141cbc3c24332f8a2c604e7a/server/src/routes/maps.ts#L183

Woops. I need to learn how to search better. Thanks.

As a further clarification as to why it was moved away from being a /search endpoint, hashes are (and always have been) unique on BeatSaver so it didn't make much sense to report more than one.
Before it would return an empty array or an array of 1 map, now it returns one map or a 404.


Duration still incorrect

I'm still seeing, in 16.10, what was supposed to be fixed by
https://github.com/microsoft/vstest/pull/2739

Thanks, I will look into this.

@NinoFloris could you share more details please?
I am trying it here with normal and minimal output, and I have 2 test assemblies, each with 2 tests that take 4 and 5 seconds to run. The assemblies run in parallel and the tests as well so the run should report duration of roughly 5s, which it does. I also tried few other variations and it seems to behave correctly.

TestProject8.zip
vstest.console --parallel --logger:"console;verbosity=minimal" <dlls>

Sorry must have missed the notification, is it a cli runner bug fix or a test sdk fix? I tried upgrading the Ms test SDK but I didn't yet run it against dotnet 6 preview cli tools


[ci skip] adding user @anmyachev

Hi! This is the friendly automated conda-forge-webservice.
I've added user @anmyachev as instructed in #181.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #181

Sorry! Wrong feedstock :(

no worries, looks like I can


better vendor support / vendor page

page with contact info for vendors
maybe provide a link to their sign-up-for-a-time mechanism
page might include vendor videos/ads
talk to Allen Reichert to work out details

[ ] create layout/data format (Ken)
[ ] populate with data (Melissa)

https://2021.alaoweb.org/sponsors/


fix(tracing): makes sure tracing headers are being propagated when using forwardAuth

What does this PR do?
This PR fixes the propagation of tracing headers when using forwardAuth
Motivation
fixes #5774
More

[x] Added/updated tests

Additional Notes
This PR fixes the problems described in https://github.com/containous/traefik/pull/6009.
Important Note: While working on this I realized that tracing propagation will only work if tracing middleware happens before the forwardauth middleware, is this something we can guarantee?
Ping @ldez @aliksend

Hello, could you rebase on the branch v2.1. Thank you.

@ldez done

@ldez This PR it duplicate of my (#6009). Can you pls review it too because "There can be only one"

@aliksend yeah, so based on what you said

It looks like a bug. The line tracing.InjectRequestHeaders(forwardReq) already present in middlewares/auth/forward.go, but InjectRequestHeaders injects headers for context that present in provided request. But in case of forwardAuth request is new and have no context.

I think this is more like a bug because no unit test was added for checking that the context was propagated. This PR fixes that bug keeping the code mostly as it is now. I prefer this approach as the side effects are zero.

Any input on this @ldez ?

The approach with zero side effects seems better to me, so I will "choose" this PR.

@jcchavezs you don't need to "merge master", we have a bot for that :wink:

Awesome I did not know @ldez! Thanks.


JavaScript Code: Replacement of moment.js with Luxon

The JavaScript code in the samples uses the Moment.js library (https://github.com/moment/moment/). According to its project status the library is in maintenance mode and not recommended for new project (see: GitHub Project Status). In addition it comes with certain drawbacks compared to newer libraries (see https://momentjs.com/docs/#/-project-status/).
The project references alternatives for its usage and this pull request contains a proposal to adopt this by switching over to Luxon.
This would then be consistent with the changes made in PR #77016

@lechnerc77 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


RFP - 6: Smart Contracts on IPFS

Not exactly sure how we can apply for a grant but I'd like to present something I've been researching for a while.
I started researching a concept I call "e-contracts", which is an idea that leverages IPFS to emulate smart contract behavior off-chain similarly to a DAG, including timestamps for user data and updates to control ordering of events. So not only do we have decentralized storage off-chain but we can now have programmable and trustless stores on IPFS.
If Protocol Labs is willing to fund research like this can someone contact me by email?
My email is<EMAIL_ADDRESS>

Conversation moved to email.  Problems should be proposed in protocol/research, or in project repos (like IPFS notes), and submissions should be sent using the RFP application instructions


[CallBatch] Fail requests with top level error if top level call fails

At the moment, if a batch fails at the top level (e.g. no connection to the node) we fail each individual request with:

Web3Error::Transport("Batch has been dropped without executing".to_owned())

This is because we consume the batch upon execute_all but return early in case of a top level error, before notifying its inner requests.
This PR changes this behaviour to forward the specific top level error to all individual requests.
Test Plan
Unit test

want to mention that this feeling more awkward to handle is maybe some evidence toward making the individual futures hang forever

Again, I'm afraid that this would make accidentally deadlocking quite likely (as Transport errors are not something you necessarily test in your happy path).


Multi-series histogram

Feature Description
What would you like to see added to Evidence?
Goal of Feature
Compare two distributions
Current Solution
Make two histograms

Initial thinking here is to add a "series" prop to the existing histogram component.
<Histogram data=... series='column' />
Some additional complexity in that the hist does it's own aggregations for counting and binning.


what watchdog event extensionconfig do we have the doc is not saying any,config.core.v3.TypedExtensionConfig

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: One line description
what watchdog event extensionconfig do we have the doc is not saying any,config.core.v3.TypedExtensionConfig
Description:

Describe the issue.

config.bootstrap.v3.Watchdog.WatchdogAction[¶](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/bootstrap/v3/bootstrap.proto#config-bootstrap-v3-watchdog-watchdogaction)
[[config.bootstrap.v3.Watchdog.WatchdogAction proto]](https://github.com/envoyproxy/envoy/blob/0b769f6e299dac9115cba10008ce984d0ebf951a/api/envoy/config/bootstrap/v3/bootstrap.proto#L429)

{
  "config": "{...}",
  "event": "..."
}
config
([config.core.v3.TypedExtensionConfig](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/extension.proto#envoy-v3-api-msg-config-core-v3-typedextensionconfig)) Extension specific configuration for the action.

event
([config.bootstrap.v3.Watchdog.WatchdogAction.WatchdogEvent](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/bootstrap/v3/bootstrap.proto#envoy-v3-api-enum-config-bootstrap-v3-watchdog-watchdogaction-watchdogevent))

[optional Relevant Links:]

Any extra documentation required to understand the issue.

This is where the watchdog extensions are listed: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/watchdog/watchdog.html?highlight=watchdog


what is "The video contains {len(indices)} frames sampled at {sec} seconds. " added in text prompt for?

is it necessary?

Yes, I have the same question.


XML Comments make property invisible in swagger UI example json

Hello,
Using NSwag.AspNetCore 13.2.2, given an API controller that returns the following response model
    public class Hero
    {
        public string? FirstName { get; set; }
        public string? LastName { get; set; }
        public string? Alias { get; set; }
        public LoveInterest LoveInterest { get; set; } = new LoveInterest();
    }

    public class LoveInterest
    {
        public string? FirstName { get; set; }
        public string? LastName { get; set; }
    }

Will generate the following schema in the Open API doc
{
    "Hero": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "firstName": {
                "type": "string",
                "nullable": true
            },
            "lastName": {
                "type": "string",
                "nullable": true
            },
            "alias": {
                "type": "string",
                "nullable": true
            },
            "loveInterest": {
                "$ref": "#/components/schemas/LoveInterest"
            }
        }
    },
    "LoveInterest": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "firstName": {
                "type": "string",
                "nullable": true
            },
            "lastName": {
                "type": "string",
                "nullable": true
            }
        }
    }
}

This renders fine in the Swagger UI.  Specifically, the response example JSON includes the loveInterest property.
However, if I change the model to include an XML comment on the LoveInterest property:
        /// <summary>
        /// The love interest
        /// </summary>
        public LoveInterest LoveInterest { get; set; } = new LoveInterest();

Then the Open API doc includes this schema
{
    "Hero": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "firstName": {
                "type": "string",
                "nullable": true
            },
            "lastName": {
                "type": "string",
                "nullable": true
            },
            "alias": {
                "type": "string",
                "nullable": true
            },
            "loveInterest": {
                "description": "The love interest",
                "oneOf": [
                    {
                        "$ref": "#/components/schemas/LoveInterest"
                    }
                ]
            }
        }
    },
    "LoveInterest": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "firstName": {
                "type": "string",
                "nullable": true
            },
            "lastName": {
                "type": "string",
                "nullable": true
            }
        }
    }
}

And in this case, the Swagger UI will not render the loveInterest property in the response example JSON.  This means, given a very basic model, adding an XML comment causes the property to be invisible in the Swagger UI examples.
To Summarize:
Works as expected
When the schema is generated as
            "loveInterest": {
                "$ref": "#/components/schemas/LoveInterest"
            }

Property is missing from example
when the schema is generated as
            "loveInterest": {
                "description": "The love interest",
                "oneOf": [
                    {
                        "$ref": "#/components/schemas/LoveInterest"
                    }
                ]
            }

This seems similar to #2071, in which case it was the presense of the nullable attribute which triggered the generation of oneOf, however, it seems other attributes (in this case description) will also change from a simple $ref to oneOf
This seems quite problematic.  If Swagger UI has issues with oneOf, is there a way it can be avoided in this scenario?

We experience the same problem in our nested DTOs

public class Container
{
    [Required]
    public A A {get;set;}
}

public class A
{
    /// <summary>
    /// This results in the problem
    /// </summary>
    [Required]
    public B BDoesNotWork { get; set; } // Note: examples set in B it self would now work

    [Required]
    public B BDoesWork { get; set; }

    /// <summary>
    /// This works
    /// </summary>
    /// <example>
    /// { "Id": "1" }
    /// </example>
    [Required]
    public B BWithCustomSample { get; set; } //Note: this generates an example, but the example can be anything...

    [Required]
    public string Name { get; set; }
}
public class B
{
    /// <summary>
    /// THe Name
    /// </summary>
    /// <example>
    /// Some Name
    /// </example>
    ///
    [Required]
    public string Name { get; set; }
}

Results into the following:
 "A": {
        "type": "object",
        "additionalProperties": false,
        "required": [
          "bDoesNotWork",
          "bDoesWork",
          "bWithCustomSample",
          "name"
        ],
        "properties": {
          "bDoesNotWork": {
            "description": "This results in the problem",
            "oneOf": [
              {
                "$ref": "#/components/schemas/B"
              }
            ]
          },
          "bDoesWork": {
            "$ref": "#/components/schemas/B"
          },
          "bWithCustomSample": {
            "description": "This works",
            "example": {
              "Id": "1"
            },
            "oneOf": [
              {
                "$ref": "#/components/schemas/B"
              }
            ]
          },
          "name": {
            "type": "string",
            "minLength": 1
          }
        }
      },
      "B": {
        "type": "object",
        "description": " ",
        "additionalProperties": false,
        "required": [
          "name"
        ],
        "properties": {
          "name": {
            "type": "string",
            "description": "THe Name",
            "minLength": 1,
            "example": "Some Name"
          }
        }
      }

Both the custom sample and the one with just a descriptive name for the field generate as one-off.
This means I can have either incomplete swagger docs, or incomplete documentation of my DTOs

I think swagger ui cannot resolve the oneof reference, so maybe you need to set AllowReferencesWithProperties to true
https://apimundo.com/organizations/nuget-org/nuget-feeds/public/packages/NJsonSchema/versions/latest?tab=types&type=NJsonSchema.Generation.JsonSchemaGeneratorSettings


CLI for project maintainers to create new projects / categories

you'd pass it a key and project name to authorize, and then you'd be able to type commands like create version us, create category dog and it would make the api calls for you to do that

it does that


switch quoting library

fixing #487
The PR is replacing the generic approach in shell-quote library with a different one based on character-by-character tests I've made resulting in a different quoting library.

coverage: 99.136% (+0.002%) from 99.134%
when pulling 47cba343a6dbdac7bd352ba2e521d1c66ad93522 on cepharum:main
into 3dc909a9618f92cb8dae2fa62538af9db08a377e on open-cli-tools:main.

Hm, not sure about the open linter errors for running ESLint on my working copy presents that warning, only. In case it is fixing something locally, this does not result in a change accepted for commission by git CLI tool.


Allow setting cookie name by configuration

Allow configurations like:
lexik_jwt_authentication:
    ...
    token_extractors:
        split_cookie:
            enabled: true
            cookies:
                - jwt_hp
                - jwt_s
    set_cookies:
        jwt_hp:
            customName: '%env(JWT_COOKIE_PREFIX)%jwt_hp'
            ...
        jwt_s:
            customName: '%env(JWT_COOKIE_PREFIX)%jwt_s'
            ...

With Gesdinet, it's already possible with:
gesdinet_jwt_refresh_token:
    token_parameter_name: '%env(JWT_COOKIE_PREFIX)%refresh_token'
    ...

Hummm.. It's already possible, the attributes key is the name. ex : jwt_hp & jwt_s

lexik_jwt_authentication:
    ...
    token_extractors:
        split_cookie:
            enabled: true
            cookies:
                - '%env(JWT_COOKIE_PREFIX)%jwt_hp'
                - '%env(JWT_COOKIE_PREFIX)%jwt_s'
    set_cookies:
        '%env(JWT_COOKIE_PREFIX)%jwt_hp':
            lifetime: 2592000
           ...
        '%env(JWT_COOKIE_PREFIX)%jwt_s':
            lifetime: 2592000
           ...

works but IMO, when the cookie naming require a more advanced syntax like in my case, it's less conventional and clean than using a dedicated attribute.
My proposition is optional for ease some advanced cases only.
And the current and basic attribute key for basic naming remains useful for service naming  https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/DependencyInjection/LexikJWTAuthenticationExtension.php#L125 and in the token_extractors.[cookie|split_cookie] part.

For advanced syntax, I'd recommend using the parameters instead.
You can setting a customName and attributes key which have 2 different behaviors. The token extractors doesn't use the customName but the attributes key and the cookie name isn't the attributes key, it's a mix and imo these changes bring more complexity to the bundle.

I agree with @maxhelias this looks rather confusing. Thanks for the PR, I hope to see you again for another.


zn.deps order

The following two should be different:
Node(data=[data1, data2]) != Node(data=[data1, data2])

One Solution would be to add to the dvc.yaml file:
Node:
   data: [x.name for x in data]


Sidebar files pane - focus mode, to toggle show only selected subfolder

Sidebar folder/project explorer needs a "focus this folder" on right click - in 90% of time i work on some part of project, like admin module etc, so would love have features of whole project, like class definitions etc, but sidebar only show contents of selected subfolder, with option to toggle this focus on/off

See #141036 for an alternative that an extension can provide.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!

@gjsjohnmurray  thank you for tip, did not find it myself


Bug: errors from uglify are not reported by gulp-uglify

Seen in version 1.3.0:   uglify threw an error but in Gulp you don't get to see it.
Erroneous JS file wrong.js:
"use strict";
function render() {
	// note erroneous let
	let upEnabled = true;
	console.log(upEnabled);
}
module.exports = render;

gulpfile.js:
var gulp = require("gulp");
var uglify = require("gulp-uglify");

gulp.task("default", function() {
	return gulp
		.src("./wrong.js")
		.pipe(uglify())
		.pipe(gulp.dest("./out"));
});

Output
$ gulp
[09:31:56] Using gulpfile c:\Source\eXLent_master\exlent\temp\gulpfile.js
[09:31:56] Starting 'default'...

events.js:85
      throw er; // Unhandled 'error' event
            ^
Error
    at new JS_Parse_Error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:196:18)
    at js_error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:204:11)
    at croak (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:684:41)
    at token_error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:688:9)
    at unexpected (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:694:9)
    at semicolon (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:714:43)
    at simple_statement (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:894:73)
    at c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:767:19
    at c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:727:24
    at block_ (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:1007:20)

Actual error, which is not shown:
{ message: 'Unexpected token: name (upEnabled)',
  filename: '?',
  line: 5,
  col: 5,
  pos: 67,
  stack: 'Error\n    at new JS_Parse_Error (c:\\Source\\eXLent_master\\exlent\\node_modules\\gulp-uglify\\node_modules\\uglify-js\\lib\\parse.js:196:18)\n    at js_error (c:\\Source\\eXLent_master\\exlent\\node_modules\\gulp-uglify\\node_modules\\uglify-js\\lib\\parse.js:204:11)\n    at croak (c:\\Source\\eXLent_master\\exlent\\node_modules\\gulp-uglify\\node_modules\\uglify-js\\lib\\parse.js:684:41)\n    at token_error ....' }

The actual error can be shown if you attach an error handler to the stream,
rather than allowing it to bubble to node's uncaught exception handler.
A couple examples can be found in gulp's "recipe" docs, which I believe are
linked to from gulp-uglify's readme.
On Sep 18, 2015 12:35 AM, "Rogier Schouten"<EMAIL_ADDRESS>wrote:

Seen in version 1.3.0: uglify threw an error but in Gulp you don't get to
see it.
Erroneous JS file wrong.js:
"use strict";function render() {
// note erroneous let
let upEnabled = true;
console.log(upEnabled);
}module.exports = render;
gulpfile.js:
var gulp = require("gulp");var uglify = require("gulp-uglify");
gulp.task("default", function() {
return gulp
.src("./wrong.js")
.pipe(uglify())
.pipe(gulp.dest("./out"));
});
Output
$ gulp
[09:31:56] Using gulpfile c:\Source\eXLent_master\exlent\temp\gulpfile.js
[09:31:56] Starting 'default'...
events.js:85
throw er; // Unhandled 'error' event
^
Error
at new JS_Parse_Error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:196:18)
at js_error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:204:11)
at croak (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:684:41)
at token_error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:688:9)
at unexpected (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:694:9)
at semicolon (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:714:43)
at simple_statement (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:894:73)
at c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:767:19
at c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:727:24
at block_ (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:1007:20)
Actual error, which is not shown:
{ message: 'Unexpected token: name (upEnabled)',
filename: '?',
line: 5,
col: 5,
pos: 67,
stack: 'Error\n    at new JS_Parse_Error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:196:18)\n    at js_error (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:204:11)\n    at croak (c:\Source\eXLent_master\exlent\node_modules\gulp-uglify\node_modules\uglify-js\lib\parse.js:684:41)\n    at token_error ....' }
—
Reply to this email directly or view it on GitHub
https://github.com/terinjokes/gulp-uglify/issues/136.

This behavior seems to be weird. Gulp-uglify already throws an error, why not make its message clear?

The fact that my message isn't being displayed by Node is certainly a bug somewhere. Will follow up with other parties.

Not sure if you have resolved this or not, but I had the same issue. This was fixed when I used the 'var' keyword instead of the 'let' keyword. Not sure why this would cause it, but maybe it will help find a resolution.

The stack trace exhibited here is the documented and expected behavior from Node.js when the errors from streams are not handled.
As a result, I've modified the README to capture errors from streams, so that the more useful error message from this plugin is shown, rather than the stack trace from UglifyJS2.


Support setting email/login/email for registries in tag_and_push plugin

This is the same PR as https://github.com/projectatomic/osbs-client/pull/440 except it's been rebased so it can be merged.

Is there a reason not to use a "kubernetes.io/dockercfg"-type secret?
The advantage of the dockercfg secret type is that Kubernetes already knows about it, so we could use "oc secrets new-dockercfg ..." to create it, and "oc describe secret ..." to see it.

That's the type we should be using (at least, I tested it in previous PR). Haven't tested if this works yet though

Closing this one as #445 was merged


verify kubernetes target value

Codecov Report

Merging #717 (87c04f9) into master (84873ad) will increase coverage by 0.03%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   42.71%   42.75%   +0.03%
==========================================
  Files          47       47
  Lines        7203     7204       +1
==========================================
+ Hits         3077     3080       +3
+ Misses       4126     4124       -2

Impacted Files
Coverage Δ

...mblyline_core/scaler/controllers/kubernetes_ctl.py
11.09% <0.00%> (-0.02%)
:arrow_down:

assemblyline_core/scaler/scaler_server.py
27.80% <0.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Issue about Backbone Collections

Hi everyone!
I have likely found a bug concerning to backbone collections.
First, I have run the next code:
var Model = Backbone.Model.extend({idAttribute: '_id'});
var all = new Backbone.Collection();

var model = new Model({_id: 1});
all.add(model);

console.log(all.get(1) === model);

If you execute the previous code using latest Backbone version, you will get false. Consecuently, if you are using custom idAttribute and you add it in a collection, you won't be able to get it back through its id by means of the get method. Otherwise, in case you are using Backbone v1.0.0, it truly works as expected.

You need to tell the Collection what its model class is:
var Collection = Backbone.Collection.extend({
  model: Model
});
var all = new Collection;

We don't support using a Collection without setting its model class.


Can't build

Steps to reproduce the behavior:
after cloning
I run
npm install
then
npm run build
the I get this error at this task build:example:scripts
[13:50:38] Starting 'build:example:scripts'...
events.js:160
throw er; // Unhandled 'error' event
^
ReferenceError: [BABEL] $HOME/projects/react-images/src/Lightbox.js: Unknown option: $HOME/.babelrc.presets
at Logger.error ($HOME/projects/react-images/node_modules/babel-core/lib/transformation/file/logger.js:58:11)
at OptionManager.mergeOptions $HOME/projects/react-images/node_modules/babel-core/lib/transformation/file/options/option-manager.js:126:29)

I had some issue in my env, its working now


Update EXPLAIN with info about scans vs perf

Via @knz:

Clarify / over-explain in the reference docs (i.e. not only guides)
that the "spans" entry in EXPLAIN for a scan is about read
performance (it's not obvious), and spell out over and over that
"ALL" is not good

Closed in favor of #2362 (added this info to that issue)


Fix accent management

Waiting to see if someone has the same problem :)
https://github.com/amondnet/now-deployment/issues/37

https://augora-frontend-iqc5liqt8.now.sh/


[red-knot] Infer generator expressions

Adds a Generator type and infers the type of a generator expression as Generator[T, None, None] where T is the inferred type of the first comprehension.
Related to #12701.

This is my first one of these, so apologies if I'm way off!

Hey, thanks so much for the PR! So I should have added more color to #12701 to clarify some of these better; this is an example of one where we're kinda blocked on adding support for generics in order to do this correctly. The generator type should be derived from its definition in typeshed rather than added as a special case in the Type enum. And understanding its definition in typeshed requires that we understand type variables and generic classes, which we don't have. Sorry this wasn't clear in the issue, I've updated the text of the issue now to mark the ones blocked on this!
Going to close this since I think pretty much everything here would look different with the typeshed/generics approach, sorry about that! If you're interested in tackling an open expression kind, there are gaps in our unary/binary expression support, or for something a bit more complex, lambda expressions might be interesting. @chriskrycho is currently working on call expression inference, which will unlock a bunch more expression kinds where we should be resolving them as dunder method calls. Feel free to ping us on Discord or in the issue if you want to get a bit of direction before starting work on an issue!

Not a problem! Sorry for spamming the PRs 😅 I'll coordinate on the issue/Discord before taking another stab. Thanks!


intl package: replace Intl.plural with PluralFormat

 Issue by seaneagan
Originally opened as dart-lang/sdk#11076

The intl package has Intl.plural which currently just forwards to Intl.select.  It requires you to pass in "howMany" which presumably is either a plural category or number as described in:
http://unicode.org/reports/tr35/tr35-numbers.html#Language_Plural_Rules
But it does nothing to calculate the plural category for a given locale.  It also doesn't have any templating facility to allow including the actual number within the text selected for the given plural category.
The intlx package (http://pub.dartlang.org/packages/intlx) has PluralFormat which takes a Map of cases, each of which can contain a pattern to replace with the actual number, and a locale to use to calculate plural categories, and then formats integers accordingly.  The calculation of plural categories requires using a plural rules parser ahead of time to generate plural rules code for each locale which can be loaded into the application.
Demo: http://seaneagan.me/intlx/
Docs: http://seaneagan.me/intlx/docs/intlx/Plural.html
Proposal: move PluralFormat to the intl package and remove Intl.plural.

 Comment by sethladd

Added Pkg-Intl label.

 Comment by iposva-google

Added Area-Pkg, Triaged labels.

This comment was originally written by<EMAIL_ADDRESS>
The OP has explained the issues with Intl.plural, but I just wanted to emphasize that Intl.plural should be removed completely. The way this issue usually progresses is that someone unaware of i18n issues designing a library would come up with a form similar to Intl.plural where the message depends on a number argument. When the problems with this approach are pointed out to them, they add another form where the message depends on a locale and still keep their original flawed form. The issue here is not the inavailability of a locale dependent form, but rather the availability of a number dependent form that should not be available. When programmers use the latter in their code they create code that is not properly internationalized as it cannot be localized to all the languages that use a calculated plural form, while they are assuming that their code is properly internationalized as they are using a function or message form that is supposedly taking care of language dependent forms. (And for goodness sake, if you are designing a modern language that is supposed to run on client side all over the planet, get someone in the team with good understanding of i18n, so we don't keep recycling the same issues that have been argued over and over again)


Is Armchair still being maintained?

It seems the last commit is from 3 months ago and the master branch is still using Swift 2.3.
Is this repo still actively maintained ?

Yes. While I have been taking the back burner lately, pull requests are still checked and merged if appropriate. I will merge in the swift 3 branch soon


Implement vectored I/O for TcpStream

@carllerche I know you've said your not a fan of this approach but at least we can start using more nightly features on the crate without breaking the stable builds this way.
TODO:

[ ] Remove TcpStream::{read_bufs, write_bufs}.
[ ] Windows implementation, already uses IoVec so it shouldn't be too hard.
[ ] Remove iovec dependency.

Updates #957.

I want to take the same approach for #977.

@carllerche What do you think about it?

Well 1.36 was just released, so this doesn't have to work with nightly features any more. But this can still apply to peer_addr.

@Thomasdezeeuw my take is, let’s target a future rust release and use nightly until then. I just prefer avoiding the feature flag. I expect we won’t cut 0.7 until at least async / await is on stable.

Basically I’m fine with this change, just without the feature flag :-)

@carllerche Sounds good to me. Could you change the CI to use the nightly compiler only? I haven't figured out the Azure pipeline stuff.

I've forced push changes to just implemented {read, write}_vectored. But this will fail the CI on old stable compilers.

We can probably just switch stable to nightly in Ci for now. That is what we do for Tokio.

Looking at another build from earlier today (https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1324&view=logs), it seems 1.36 is only used for macOS builds, other OSes are still on 1.35. I'll wait off on a rebase when the other OSes also use 1.36.

Pr #1028 fixes the problems with the CI, so I'll wait for that to be merged before rebasing this.

I've rebased on master, @carllerche can you give this a final look over to see if I didn't mess anything up while merging?

Great, both min Rust version and Windows fails because they both use 1.35.


Updated the TLS / SSL issue section

openssl check to verify the status of the SSL certificate
grep config.json specific to TLS

Thanks @dannymohammad for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Thank you @dannymohammad!

You are welcome, @amyblais . Any time!


Add mock/synthetic implementations of Azure-related interfaces

** Please describe what you would like the feature to accomplish.**
This repo should contain mock/synthetic implementations of the Azure-related interfaces in the Microsoft.Azure.Quantum.Client package such as IWorkspace, IStorageHelper, and IJobStorageHelper.
** Describe the solution you'd like **
These mock/synthetic implementations should enable local end-to-end tests of code that consumes these interfaces.

@cesarzc @rmshaffer We might have something like that - could you please clarify whether what we currently have meets this need or what would be needed exactly and why?

This issue was opened because IQ# unit tests simply skip over calls to IWorkspace, IStorageHelper, and IJobStorageHelper because the "real" implementations of those can't be used in unit tests. It'd be slightly better if we could actually exercise those calls against mock implementations of those interfaces.
There are already mock implementations of those interfaces in qdk-private. I think the intent of this issue was to track moving those out of qdk-private and into this repo.


[USE] Double MBlw in Zanabazar Square

According to L2/15-337 section 4.10, Zanabazar Square “cluster-final letters may occur after each other in the penultimate and final positions in a cluster”. That means there can be two in the same cluster. However, because U+11A3B..U+11A3E are all categorized as MBlw, only one may occur in a USE cluster, which is insufficient.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 194a6d3c-4137-46e9-3a4b-44b990200986
Version Independent ID: a0c8e788-5228-aa28-670e-3ba1ac3faecd
Content: Creating and supporting OpenType fonts for the Universal Shaping Engine - Typography
Content Source: typographydocs/script-development/use.md
Product: typography
GitHub Login: @Anglass
Microsoft Alias: anglass

Should be fixed by microsoft/font-tools#48.


net_if_tx sends a 0 Reference counter(pkt->ref == 0) packet

Hi,
I am an engineer from ARM china, and I am using Zephyr for some network demo, and it seems I run into a zephyr network issue, please help to have a check.
My test is a socket API based stress test, descriptions as bellow:

On my PC, I ran a socket echo server, which simply did the following loop:
connect -> receive -> send -> receive -> send -> ... ... -> receive -> send -> close
On my board (nucleo_f429zi) I have implemented a sample echo client loop using socket APIs:
a. sock = socket(xxx) // using AF_INET and SOCK_STREAM
b. ret = connect(socket, xxx,xxx)
c.  while (1) {
ret = send(xxx)
ret = recv(xxx)
}
d. close(sock)
In the project configurations, I only enabled IPV4 (CONFIG_NET_IPV6=n), and enabled some net debug options(CONFIG_NET_LOG=y, CONFIG_SYS_LOG_NET_LEVEL=4), and some other configurations which I think it is not related with this issue.

And also I add a assert at
static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
function in net_if.c file :
**NET_ASSERT(pkt->ref != 0);
if (0 == pkt->ref) {
    while (1);
}**

and my stress test ran into the assert, UART log:

[net/ethernet] [DBG] ethernet_send: (0x200044f4): Found ARP entry, sending pkt 0x2000615c to iface 0x2000d6a0
[net/core] [DBG] processing_data: (0x200044f4): Consumed pkt 0x20005bb8
[net/pkt] [DBG] net_pkt_print: (0x200044f4): TX 13 RX 13 RDATA 32 TDATA 35
[net/if] [DBG] net_if_tx: (0x2000457c): Processing (pkt 0x2000615c, data len 40, prio 0, ref: 1) network packet
[net/pkt] [DBG] net_pkt_unref_debug: (0x2000457c): TX [13] pkt 0x2000615c ref 0 frags 0x20007708 (eth_tx():123)
[net/pkt] [DBG] net_pkt_unref_debug: (0x2000457c): TDATA (tx_bufs) [35] frag 0x20007708 ref 0 frags 0x00000000 (eth_tx():123)
[net/pkt] [DBG] net_pkt_frag_unref_debug: (0x2000457c): TDATA (tx_bufs) [35] frag 0x20007708 ref 0 (net_pkt_unref_debug():802)
[net/if] [DBG] net_if_tx: (0x2000457c): Calling context send cb 0x20003ac8 token 0x00000000 status 0
BG] find_entry: (0x20005004): [0] iface 0x2000d6a0 dst <IP_ADDRESS> ll 00:80:E1:D5:8F:62 pending 0x00000000
[net/arp] [DBG] net_arp_prepare: (0x20005004): ARP using ll 00:80:E1:D5:8F:62 for IP <IP_ADDRESS>
[net/ethernet] [DBG] ethernet_send: (0x20005004): Found ARP entry, sending pkt 0x2000615c to iface 0x2000d6a0
[net/if] [DBG] net_if_tx: (0x2000457c): Processing (pkt 0x2000615c, data len 268, prio 0, **ref: 0**) network packet
**[net/if] [ERR] net_if_tx: {assert: 'pkt->ref != 0' failed}**

Please have a check, thanks a lot!

@mazhenke : Any chance that you can reproduce this issue with existing socket samples in https://github.com/zephyrproject-rtos/zephyr/tree/master/samples/net/sockets ?

The socket samples in
https://github.com/zephyrproject-rtos/zephyr/tree/master/samples/net/sockets
are implementing a echo server in Zephyr, but my stress test case is implementing echo client loop in Zephyr.
Also I have attached my test code.
# I think I have found the root cause of this issue.
The TCP sends data flow is like this:
net_tcp_send_pkt(in tcp.c) -> net_send_data(in net_core.c) -> net_if_send_data(in net_if.c) -> net_if_l2(iface)->send(l2 layer send, in my case is ethernet_send)
I found that if ethernet receive interrupt occurred during net_if_send_data, then the kernel scheduled(swapped) to the receive thread and do the network receiving. The network receiving will take some time, and after receiving finished, the previous TCP has timed out (CPU somehow runs to  the tcp_retry_expired function in tcp.c). In tcp_retry_expired function, CPU send and unreference the previous package. But anyway kernel will scheduled back to the thread of previous net_if_send_data, and then we can see that an unreferenced package will be send.
I have generated a referenced workaround/fix on this issue:
https://github.com/mazhenke/zephyr/commit/fa4d39ce9a953bb4b4e75facd88cd83f93b82ac6

log.log
I have attached one log of my mps2+ board, and add comments in the log using:
/////////////////////////////////////////////////////////////////////////////////////////////////

I have generated a referenced workaround/fix on this issue:
mazhenke/zephyr@fa4d39c

IMHO that fix is not a proper thing to do inside IP stack. If some TCP timeout is too short, then I suggest you try to increase the corresponding TCP timeout and see if it fixes the issue.

@jukkar:

IMHO that fix is not a proper thing to do inside IP stack.

Actually, I had the same idea of using k_sched_lock(), at least as a debugging measure. And I'm not sure it's not the right solution (if TX and RX threads are cooperative, then why entire IP stack processing shouldn't be? And as a lot of this processing happens in calling thread (instead of the dedicated threads), ergo...) I describe my adventures in https://github.com/zephyrproject-rtos/zephyr/issues/8190#issuecomment-394971724

@mazhenke :

The socket samples in
https://github.com/zephyrproject-rtos/zephyr/tree/master/samples/net/sockets
are implementing a echo server in Zephyr, but my stress test case is implementing echo client loop in Zephyr.

The sockets samples are 5 different applications, which provide more or less good coverage of the IP stack functionality. And to fix this issue, other developers would need to reproduce it. And the best way to reproduce something is start to a common, well-known base, and that's socket samples.
I'm sure other developers will join with reproducing and looking for a fix to it. (For example, I'm eager to join in, but first need to work on issues, for which it's already known how to reproduce them on existing samples, e.g. https://github.com/zephyrproject-rtos/zephyr/pull/7831). So, in the meantime don't hesitate to extend your testing of this issue to the existing socket samples and/or provide a reproduction test case. Thanks!

https://github.com/mazhenke/zephyr/commit/cda18027157fd82a68ffd7213447dd57d15aef0a

@rveerama1 has been investigating #7423 which although totally different problem than this, is crashing in weird ways that look similar as what is described here.
After more investigation in that PR, we found out that the culprit is that the IP stack is entered in preemptive mode from main thread. This can lead to issues in IP stack which expects that all its functions are run in co-operative mode. One workaround would be to run the main thread in co-operative priority, so you could try to set CONFIG_MAIN_THREAD_PRIORITY=-1 if it solves the issue here.

This should have been fixed by the locking PR. Please re-open if this is still valid issue.


Added manual CSR approval flow

Signed-off-by: Sachin Kumar Singh<EMAIL_ADDRESS>What this PR does / why we need it:
It should be possible to approve CSR manually. For that, we will disable the ByoAdmission controller by applying it behind an environment variable. Now user can apply the variable MANUAL_CSR_APPROVAL=true to manually approve the CSR. By default, the controller will approve the CSRs.
File changes:

main.go: Put the ByoAdmission controller setup behind the MANUAL_CSR_APPROVAL environment variable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #557
Additional information
I've disabled the cyclometric complexity form main() due to lots of inevitable if conditions that might even increase in the future and thus increase the complexity further.
Another way is to refactor the controller and webhook setup out of the main.

Should I write an e2e test for this? I don’t see any tests for the manager otherwise.


SignUpWithEmail vs CreateUser Metadata

Hello, comparing the CreateUser and SignUp methods for metadata the implementation seems to be different.
CreateUser method signature expects an object to be bound to a "data" property and the SignUp method signature is expecting a Dictionary of <string, object> to be bound to the "data" property. Wasn't sure if this was a bug.
param: Dictionary<string, object> metadata
Dictionary<string, object> data = new Dictionary<string, object>             {                 {                     "email",                     email                 },                 {                     "password",                     password                 },                 {                     "data",                     metadata                 }             };
param: object userData
Dictionary<string, object> dictionary = new Dictionary<string, object>             {                 {                     "email",                     email                 },                 {                     "password",                     password                 }             };             if (userData != null)             {                 dictionary.Add("data", userData);             }

Oh my! Great catch. Yes, the CreateUser call is supposed to have a different format. I'll get that fixed and a test added. Thank you!

@acupofjose this is the metadata result for the new SignUp(). Is this correct?
 "userMetadata": {     "data": {       "full_name": []     },     "redirectTo": "https://google.com"   }


Implemented I18N::normalizeLocale() that noramlizes ICU or BCP47 locale into Yii translation language

Part of #7883 fix.
TODO:

[x] Better method name?
[x] Introduce method for getting fallback language to take script into account.
[ ] Adjust BaseFileHelper::localize().
[x] Adjust JUI DatePicker asset (https://github.com/yiisoft/yii2-jui/pull/15)
[ ] Adjust DbMessageSource.
[ ] Adjust PhpMessageSource.
[ ] Adjust GettextMessageSource.

Looks good to me and also fine with the name.

Adjust BaseFileHelper::localize().

Whould not this break a BC?
Developer may not stumble on the #7883 issue, while he might plac his localized files under 'en_us' instead of 'en-us'. Change will make them unavailbale.

Yes, that could break things in that case.

Won't be able to finish it before 2.0.4. Moving to 2.0.5.

Adjusted PR according to suggestions but not sure how to deal with BC in this case...

I'm for adding it into upgrade notes and proceeding with merging it. Any objections?

not sure, maybe it is time to start the 2.1 branch?

@samdark
https://github.com/yiisoft/yii2-jui/pull/15/files#diff-b21f181a007dbc219c5eca1f1e93d2d0R46
You normalize the language specified by user for the widget ($this->language) but not the language in the filename - where is the logic in this? In particular, your code won't find "/ui/i18n/datepicker-en_US.js" file if the user specifies "en_US" language for the widget.

Won't be merged into 2.0.


fix(test): remove sbom-json-check

Description
The advanced test path started to fail as sbom-json-check task was removed (PR#1330). Removing the task from tests too.

[test]

/lgtm


[AutoPR storage/resource-manager] Added feature revoke user delegation key

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5453

(message created by the CI based on PR content)

Codecov Report

Merging #4648 into restapi_auto_storage/resource-manager will decrease coverage by <.01%.
The diff coverage is n/a.

@@                            Coverage Diff                            @@
##           restapi_auto_storage/resource-manager    #4648      +/-   ##
=========================================================================
- Coverage                                  49.51%    49.5%   -0.01%
=========================================================================
  Files                                       6333     6332       -1
  Lines                                     177240   177177      -63
=========================================================================
- Hits                                       87758    87710      -48
+ Misses                                     89482    89467      -15

Impacted Files
Coverage Δ

...re/graphrbac/operations/applications_operations.py
35.98% <0%> (-4.72%)
:arrow_down:

azure-graphrbac/azure/graphrbac/models/__init__.py
56.25% <0%> (-2.34%)
:arrow_down:

...phrbac/models/application_create_parameters_py3.py
100% <0%> (ø)
:arrow_up:

...rbac/models/service_principal_object_result_py3.py

.../mgmt/containerservice/container_service_client.py
60.52% <0%> (+3.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d782b...58911f0. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/4585


Cumprod support

Works with CPU=1, but getting 0's for gpu/cuda. Need to find where 0 is being added to multiply list, but Idk where the code is compiled

@geohot Is this fine?

@chenyuxyz am I supposed to add anything else to the pr?

have you read this https://github.com/tinygrad/tinygrad/?tab=readme-ov-file#contributing? it also contains too many copy-pasted lines

@chenyuxyz I added tests, but they fail when ran on testing sever. It works on my system. Could it be because the new tests are being run on a precompiled version of tinygrad? Getting error that ReduceOs.PROD isn't a key, but made sure linearizer and ops_cpu have it in their respective dicts.

Ok I added the tests and made cumulative reduce a function. Is there anything I'm missing @chenyuxyz ?

Tests failing, seems stale. Can reopen if you still want it


Next Release v0.5.1

If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Makes adjustments for the latest release.
In addition: Closes #886. Closes #888.
How did you implement your changes
Adjusted the requirements files, and made changes w.r.t newer versions of seaborn. In addition, percent_var_exp is deprecated as it isn't in use currently. Made adjustments for KMeans in scikit-learn as n_init needs to be specified to either a value or to "auto". Set it to "auto".
Remaining issues

[x] Merge angelolab/tmi#18.
[x] Update the comp team wiki with docs on making a new release
[ ] Make a new release

In addition, will you migrate the stuff that's currently in the developer docs section to the computational team wiki, and make a separate section for each repo?
i.e. for TMI, update the release tag in pyproject; for mibi-bin-tools, just make a new release, etc etc.
As we start having different requirements for what needs to be changed for each repo, it'll be helpful to have it one place to make sure we don't miss anything,.

@ngreenwald Good to create and push the tag for a new release?


E3002 - NAT gateway secondary allocation throws error

CloudFormation Lint Version
cfn-lint 0.72.2
What operating system are you using?
Mac, Ubuntu and AL2
Describe the bug
Hello 👋,
When trying to add multiple IPs to NAT gateway following the official documentation.
Type: AWS::EC2::NatGateway
Properties:
  AllocationId: String
  ConnectivityType: String
  MaxDrainDurationSeconds: Integer
  PrivateIpAddress: String
  SecondaryAllocationIds:
    - String
  SecondaryPrivateIpAddressCount: Integer
  SecondaryPrivateIpAddresses:
    - String
  SubnetId: String
  Tags:
    - Tag

The linter throws an E3002 Invalid Property Resources/NATGatewayAZOne/Properties/SecondaryAllocationIds 💥
I have successfully updated the template and now my NAT GWs have extra public IPs, I just had to turn off the linting step in my pipeline.
Many thanks 😃
Expected behavior
This is a legitimate property of the NAT gateway and the linter should not throw the E3002.
Reproduction template
AWSTemplateFormatVersion: 2010-09-09
Resources:
  NATGatewayEIPAZOne:
    Type: AWS::EC2::EIP
    Properties:
      Domain: vpc

  NATGatewayEIPAZOneSecondary:
    Type: AWS::EC2::EIP
    Properties:
      Domain: vpc

  ProxyNATGatewayAZOne:
    Type: AWS::EC2::NatGateway
    Properties:
      AllocationId: !GetAtt NATGatewayEIPAZOne.AllocationId
      SecondaryAllocationIds:
        - !GetAtt NATGatewayEIPAZOneSecondary.AllocationId
      ConnectivityType: public
      SubnetId: !Ref NATGatewaySubnetAZOne # Subnet declaration ommited

This is resolved in cfn-lint>=v0.73.1.  You can do a pip update to get the newest version.
If you need to stick on the version you are at run cfn-lint --update-specs


Release 1.26

For now we only plan it for RaspberryPi line.
 Front conversations

I think you meant 1.26? edited just in case

Thanks @pcarranzav

@agherzan shouldn't this be closed now that 1.26 is in production? Just a heads up.

Good point. Thanks @dfunckt


Huabao808

Huabao VT808 protocol
This is a work in progress HUABAO implementation. Once I have some vendor details, it will be finished.
[Huabao 808 protocol] (https://dl.dropboxusercontent.com/u/22845186/huabao/Huabao-808-protocol-en.pdf)

Hi @tananaev. Could you please heck if the code is fine for merging?
About your questions:

What is the purpose of Huabao808 class? I think all the logic from that class should be directly in the decoder class.

I thought that might be better if all the rules from VT808 protocol were encapsulated. Beside this, VT808 protocol is "conversation based" and requires an answer in order to send the location.

Frame decoder is incorrect. Seems like you have some frame decoding functionality in protocol decoder, but it should be moved to frame decoder class.
I think it is unnecessary to save data in member variables. Instead you should put data directly into Position instance. Having so many variables makes the decoder more complicated and harder to understand and maintain.

I have made a big refactoring in order to keep it simple.  Please, let me know if there is some issues on it.
Best,

I thought that might be better if all the rules from VT808 protocol were encapsulated. Beside this, VT808 protocol is "conversation based" and requires an answer in order to send the location.

Decoder class is for the encapsulation. Why do you need another one?
Frame decoder is still incorrect.
Overall I don't see any major changes from the original version.

I have finally implemented Huabao protocol in Traccar.