Keep open on page refresh in a selected item

I wanna ask if its possible keep the menu open when the page refresh or if you select an item.
Maybe there is a way that i can retrieve the selected item and stored on a localstorage variable. there is a way to do that ?
Besides, it is a way that you can disable the offcanvas an used has a side bar ?

To open nav by default when page opens set expanded option to true.
Retrieving selected item currently isn't possible, but it would be a good feature, I'll try to implement it.
Could you clarify more the last sentence, I did not quite understood it.

Thanks for your response.
What i mean in the last sentence is if there is a possibility to use the same plugin without the hamburger button and using simple as a side menu.

Well it's not meant to be used like that but you could by using { expanded: true } and hiding the hamburger with simple css.

I've pushed a new plugin version. To store and retrieve the selected open level you can now do it like this:
// call our plugin
var Nav = $menu.hcOffcanvasNav({});

// attach events and store levels and indexes in local storage
Nav.on('open.level', (e, l, i) => {
  localStorage.setItem('NavLevel', l);
  localStorage.setItem('NavIndex', i);
}).on('close.level', (e, l, i) => {
  localStorage.setItem('NavLevel', l);
  localStorage.setItem('NavIndex', i);
}).on('close', () => {
  localStorage.removeItem('NavLevel');
  localStorage.removeItem('NavIndex');
});

// read from local storage and open specific level and index if there were any previously open
if (localStorage.getItem('NavLevel')) {
  Nav.open(localStorage.getItem('NavLevel'), localStorage.getItem('NavIndex'));
}

This is just an example, you can tweak it per your needs.

Nice add man, yep, something like  that i needed.
This is very useful
Thanks.


“Loop” is not working as expected when roundLengths is set to true

This is a

[x] bug

Swiper Version: 3.4.2 & 4.0.1.

What you did
var swiper = new Swiper('.swiper-container', {
autoplay: 1000,
speed: 2000,
loop: true,
slidesPerView: 5,
slidesPerGroup: 5,
spaceBetween: 16,
roundLengths: true
});
Expected Behavior
If a slider has 10 slides, then expected behavior is Page1->page2->page1->page2->….
Actual Behavior
But I got the wrong behavior page1->page2-page1->page1->page1->page1->….
P.S. If you can not reproduce the problem on your side, then set spaceBetween to 15 to try again.

Swiper 3.4.2
      slidesPerView: 3,       slidesPerGroup: 3,       loop: true,       roundLengths: true
total: 9 slides
loop was broken:
123
456
789
123
123
123
Can this be a loss of accuracy in the division?

That's the same problem as I reported, temporary solution is removing roundLengths:true Hope someone can get the problem fixed.


chore: change comment blocks with one line into single block

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
176

Relevant Lines:
176

💛  - Coveralls


Allow for xforwardedhostheader config

Allow configuration of the X-Forwarded-Host-Header down to the argo-url-helper

This relies on updates to argo-url-router and titan before review can start.

+1


Missing Data Notification: Send email only to EMAIL notifier subscrip…

…tions.

Current coverage is 36.50% (diff: 0.00%)

Merging #240 into develop will increase coverage by 0.03%

@@            develop       #240   diff @@
==========================================
  Files           260        260
  Lines         14181      14182     +1
  Methods           0          0
  Messages          0          0
  Branches       2385       2386     +1
==========================================
+ Hits           5172       5177     +5
+ Misses         8290       8286     -4
  Partials        719        719

Powered by Codecov. Last update 98b01f2...34fb501


test coverage

@vinisalazar wrote:

Test coverage seems very low. After running tests with coverage.py, there was only 6% coverage across the package code.

I suppose this is realated to the tests being implemented using pytest. I will look for this into more detail.
The solution is probably to use the pytest-cov module to measure the coverage, and not coverage.py.

installing pytest-cov by pip install pytest-cov and running
pytest --cov=fastsubtrees -v tests/
(I put both into a new Makefile goal, test-cov) returns the following:
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
fastsubtrees/__init__.py                                16      5    69%
fastsubtrees/_scripts_support.py                        50     50     0%
fastsubtrees/attribute.py                               37     28    24%
fastsubtrees/commands/__init__.py                        0      0   100%
fastsubtrees/commands/add.py                            25     25     0%
fastsubtrees/commands/attr_add.py                       41     41     0%
fastsubtrees/commands/attr_construct.py                 31     31     0%
fastsubtrees/commands/attr_delete.py                    26     26     0%
fastsubtrees/commands/attr_query.py                     33     33     0%
fastsubtrees/commands/construct.py                      31     31     0%
fastsubtrees/commands/delete.py                         16     16     0%
fastsubtrees/commands/query.py                          13     13     0%
fastsubtrees/error.py                                   10      0   100%
fastsubtrees/ids_modules/__init__.py                     0      0   100%
fastsubtrees/ids_modules/attr_from_tabular_file.py      16      1    94%
fastsubtrees/ids_modules/ids_from_database.py           12     12     0%
fastsubtrees/ids_modules/ids_from_tabular_file.py        9      1    89%
fastsubtrees/tree.py                                   222     31    86%
------------------------------------------------------------------------
TOTAL                                                  588    344    41%

It must be considered that the commands modules are all tested, using the pytest-console-script, since they are subcommands of the fastsubtrees script; that's probably not catched up by pytest-cov. For the library main files tree.py and attribute.py the reported coverage is, respectively 86% and 24%. However, this again does not take account of the CLI tests, which actually check the entire functionality of these modules.

The new version contains an almost complete coverage of the entire fastsubtrees code, which can be shown using make testcov.
The current output is:
---------- coverage: platform darwin, python 3.9.12-final-0 ----------
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
bin/fastsubtrees                                        22      0   100%
fastsubtrees/__init__.py                                15      0   100%
fastsubtrees/attribute.py                              184      0   100%
fastsubtrees/commands/__init__.py                        0      0   100%
fastsubtrees/commands/_support.py                       56      0   100%
fastsubtrees/commands/attribute.py                      62      0   100%
fastsubtrees/commands/query.py                          70      0   100%
fastsubtrees/commands/tree.py                           82      0   100%
fastsubtrees/edit.py                                   205      0   100%
fastsubtrees/error.py                                   16      0   100%
fastsubtrees/ids_modules/__init__.py                     0      0   100%
fastsubtrees/ids_modules/attr_from_tabular_file.py      16      0   100%
fastsubtrees/ids_modules/ids_from_database.py           12     12     0%
fastsubtrees/ids_modules/ids_from_tabular_file.py       18      0   100%
fastsubtrees/query.py                                   52      0   100%
fastsubtrees/tree.py                                   152      0   100%
------------------------------------------------------------------------
TOTAL                                                  962     12    99%

The ids_from_database is not tested; it is an example illustrating how to use a database table as a data source, it is not used in anything in the paper, benchmarks or example app, and including in the tests would again return to the dependency to a database, which I want to avoid.

Update: I decided to remove the fastsubtrees/ids_modules/ids_from_database.py completely.


Backport: Add pod locality in updateEDS (#14343)

Add pod locality in updateEDS

Without this change, new endpoints added in this method will be missing
the locality. This generally means only the first replica will get a
locality assigned to it. This means if locality LB is enabled, only one
replica will recieve traffic.

Correctly apply locality label override

Cherrypick of #14343
Justification for 1.2: This is a bug fix. Without this, users that enable locality LB are at risk of all traffic being sent to only a single replica of a service.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-release-1.2

/test integ-security-k8s-presubmit-tests-release-1.2

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

To be fair, should add a flag as #14377

I disagree.

This change has tests
This change is fixing an alpha feature and doesn't impact other areas (if locality is set wrong there is no impact to users who don't turn on the locality flag)

The change you linked has the potential to break a common functionality and is on the stable code path with no testing.
Not every bug fix needs a flag, only changes that are a risk to stable features.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-release-1.2

This thread is going to be a screen capture illustrating the definition of "flaky tests" in a dictionary.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

Attempting a rebase to fix the flakes since I dont see them on other ones

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
263db07096c51bc91d796172ba7688b4854acd01
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-pilot-k8s-presubmit-tests-release-1.2

prow/integ-security-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-security-k8s-presubmit-tests-release-1.2

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

prow/istio-pilot-multicluster-e2e.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio-pilot-multicluster-e2e-release-1.2

prow/integ-galley-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-galley-k8s-presubmit-tests-release-1.2

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-dashboard.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-dashboard-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e-simpleTests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-simpleTests-release-1.2

prow/integ-framework-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-framework-k8s-presubmit-tests-release-1.2

prow/e2e-mixer-no_auth.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-mixer-no_auth-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

prow/e2e-bookInfoTests-v1alpha3.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2

prow/e2e-bookInfoTests-trustdomain.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-bookInfoTests-trustdomain-release-1.2

prow/e2e-mixer-no_auth.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test e2e-mixer-no_auth-release-1.2

prow/e2e_pilotv2_auth_sds.sh
4316c5fe8e7a994cf1e31f605a0a0fe69d228e00
link
/test istio_auth_sds_e2e-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e-release-1.2

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fpesce all tests are passing now


ResAdapter doesn't unload properly

ResAdapter does not unload from a workflow once removed or bypassed. It continues to have an affect until you have fully restarted a given instance of ComfyUI.
This makes it quite difficult to create comparisons between On and Off.
If it's not possible to avoid the global-implementation (in contrast to a node-implementation) then perhaps a boolean toggle for On/Off to apply or remove effects on the node would be an alternative solution for the interim.

Thank you for your advice. We will fix this problem later.

That would be greatly appreciated. Not being able to unload it manually is distorting the recreation of previously generated images that turn out differently due to that, preventing fine-tuning with and without the model, unless restarting comfyui repeatedly, which is very inconvenient. Thank you for looking into this.


Linting Errors for ID

Generated code for "something_id" seems to result in SomethingId rather than SomethingID, which is what the linter wants.

Fixed with 3e74c98c9bcf4148db59b58e94ba545314ae9f61


Fix pull request link

I notice it's also incorrect on this page https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#class-property-inference

Thanks!


PoC: Use Redis for rate limiting/request counts

When running cc with multiple puma workers the in-memory approach for rate limiting & concurrent request limiting (service brokers) is not working anymore as the worker processes are independent. Furthermore Puma distributes requests by load and thus there will be no equal request distribution.
This change replaces the in-memory parts with Redis. This also simplifies the logic in some parts as Redis keys have a TTL. Redis is supposed to be deployed on each VM and thus no HA setup, networking etc. is required.
This is only a poc!
Following things are missing or should be investigated

Redis connection pooling
Thread/Worker safety when interacting with Redis
Redis integration into capi-release
Error handling (skip rate limiting if redis is not available)

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

This sounds similar to the synchronization issue with CC component metrics when running Puma. Would it be worthwhile to evaluate a similar solution here, namely using the filesystem, to sync state between workers?
cc @sethboyles

This sounds similar to the synchronization issue with CC component metrics when running Puma. Would it be worthwhile to evaluate a similar solution here, namely using the filesystem to sync state between workers?

We discussed this in the capi open office hour last week. Implementing rate limiting and concurrent service broker request limiting (counting semaphore) with redis is rather simple. I haven't looked yet too much into DirectFileStore but I think this would require more effort. Plus redis could be easily co-deployed on the API VMs like bosh used to do.

I'm not inherently opposed to the idea, but I think we should also consider the other options, before deciding on Redis. Ease of implementation isn't the only factor we should consider.
My concerns about Redis:

It adds another dependency to capi-release that we need to keep patched/updated and another job that we need to maintain.
It adds another running process to api instances, competing for system resources.
It adds another failure point for capi-release. Redis crashes or bugs could make CC unavailable, depending on how we integrate with it.

If we are using a co-located Redis for each api instance, it's basically just a heavier-weight abstraction for the filesystem. Not saying that that's definitely a bad thing, but we should consider the trade offs.
@rkoster do you know the history behind why bosh removed its Redis dependency?

@cunnie Do you have more context on why bosh moved away from Redis, given that you were involved in the above-linked commits.

I'm not inherently opposed to the idea, but I think we should also consider the other options, before deciding on Redis. Ease of implementation isn't the only factor we should consider.
My concerns about Redis:
1. It adds another dependency to capi-release that we need to keep patched/updated and another bosh job that we need to maintain.

2. It adds another running process to api instances, competing for system resources.

3. It adds another failure point for capi-release. Redis crashes or bugs could make CC unavailable, depending on how we integrate with it.

If we are using a co-located Redis for each api instance, it's basically just a heavier-weight abstraction for that instance's filesystem. Not saying that that's definitely a bad thing, but we should consider the trade-offs.

Instead of Redis we could also consider Memcached which is a simpler key/value store compared to Redis (plus it's in-memory).
Prometheus with DirectFileStore doesn't seem to be a good option as we would need a label for each user guid which is not recommended:

CAUTION: Remember that every unique combination of key-value label pairs represents a new time series, which can dramatically increase the amount of data stored. Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

Alternatives to Redis/Memcached:

Move rate limiting to Nginx
Implement a ruby process for managing request counts in-memory

We made a list of possible solutions: https://sap-my.sharepoint.com/:w:/p/johannes_haass/EYtAtWAm6Y1MjROPwlimSjIB-ERmZMNwJMCdCgi8zWADsA?e=28WwiK
@sethboyles @Gerg @stephanme Maybe we can discuss this in the next capi open office hour (on Dec 14th) and try to come to a decision.

Just two small remarks.

We would use Redis in a way that it does not persist data to the filesystem, so it would also be completely in-memory.
Redis can also be used as Custom Data Store for metrics, so we could use it for both rate limiting and metrics. See https://github.com/gocardless/prometheus-client-ruby-data-stores-experiments/blob/master/data_stores/redis.rb

Work is continued in #3290.


WIP: feat: add replay tests

note: my .json files doesn't have 'proof' in catalog and current github .json's don't have proofs in their jsons

I think we should run the replay tests conditionally in ci, like before every release or something like that. It's not efficient to run it on every push. But let's worry about it later.


tests/image: Test openstack images in OpenStack

We are already building this type of output images so need to start looking into actually uploading and booting them in OpenStack.

Agreed! Same considerations as for #338, we should add the upload functionality internally and following the work in #337, we should build tests on top of that.

If anyone doesn't mind I'll take a stab at this.


Communication Between Different Hosts

Hi,
We failed to enable a communication between sender and receiver on different machines. It seems MS APSI does not support the related issue.
We have tried to specify the receiver machine's ip address in sender machine's sender.cpp file, with the following modified code:

int remote_query(const CLP &cmd)
{
    APSU_LOG_INFO(__FILE__ << __LINE__);
    auto SenderKKRTSocket = coproto::asioConnect("<host_R_ipAddr>:1212",false);
    APSU_LOG_INFO(__FILE__ << __LINE__);

where <host_R_ipAddr> is receiver machine's IP.
Then we rebuilded the project, started receiver machine listening at <host_R_ipAddr>:1212, and next started sender's query. Unfortunately, both machines stuck there and returned no communication information.
PS: we have successfully tested localhost case via two opening terminals with cli.

Fine, this problem has been solved.  I have replaced all instances of the IP address with <host_R_ipAddr>.
please close the issue, thanks!

Fine, this problem has been solved. I just replaced all instances of the IP address with <host_R_ipAddr>.
Thanks!


GPTQ support

Can I run a model with GPTQ quantization like this one from hugging face?
https://huggingface.co/TheBloke/CodeLlama-13B-oasst-sft-v10-GGUF
from transformers import AutoTokenizer, pipeline, logging
from auto_gptq import AutoGPTQForCausalLM, BaseQuantizeConfig

model_name_or_path = "TheBloke/Llama-2-13B-chat-GPTQ"
model_basename = "model"

use_triton = False

tokenizer = AutoTokenizer.from_pretrained(model_name_or_path, use_fast=True)

model = AutoGPTQForCausalLM.from_quantized(model_name_or_path,
        model_basename=model_basename,
        use_safetensors=True,
        trust_remote_code=True,
        device="cuda:0",
        use_triton=use_triton,
        quantize_config=None)

I hope they add Exllama support

Is this not supported?

Hi,
If anyone wants try GPTQ quantizationo in vLLM.
Please use this repo QLLM to quantize model(LLama) and it would compatiable AWQ in vLLM.
And Of courcr you can select AWQ to quantize it as well.

Closing this issue as it is stale. We have added support both GPTQ and AWQ


fix: add the missing options argument for do_put

The options argument is required by the server to do authorization.

@crepererum Hi, do you have plans to release a new version? Although we can pass in the options manually such as:
        cmd = flightsql_pb.CommandPreparedStatementQuery(
            prepared_statement_handle=prepared_stmt.handle)
        desc = make_flight_descriptor(cmd)

        if binding is not None and binding.num_rows > 0:
            writer, reader = self.inner.client.do_put(
                desc, binding.schema, prepared_stmt.options)
            writer.write(binding)
            writer.done_writing()
            reader.read()

        flight_info = self.inner.client.get_flight_info(
            desc, prepared_stmt.options)
        ticket = flight_info.endpoints[0].ticket
        reader = self.inner.do_get(ticket)
        df = reader.read_pandas()
        return df

It's still more tedious than managing the options inside the FlightSQLClient.

https://pypi.org/project/flightsql-dbapi/0.2.2/ now is online and should includes this PR.


Moving a VM inside a vApp

Hello,
Is there an example of moving a VM inside of a vApp ? I'm trying to do it but I absolutely don't know how to do it and I don't see any example on the web.
(sorry for the newby post but I feel so lost about it)

a vApp (VirtualApp) extends a ResourcePool object.
One of the methods of a ResourcePool is moveInto.
"Moves a set of resource pools, vApps or virtual machines into this pool. The pools, vApps and virtual machines must be part of the cluster or standalone host that contains this pool."
So if you have your vapp object, and vm object, then you should be able to do:
vapp.MoveInto([vm])

Thank you for the information !
So I've made a script thanks to this information. It can be seen here.
https://github.com/cyrbi/python_examples/blob/master/move_vm_to_vapp.py


Should we try to clarify intent of Rust adoption at companies?

As pointed out here, tn the "To what extent is Rust currently being used by your company?" question, it may be useful to provide different options for "Rust is being used as a deliberate and strategic decision at my company" versus "Rust is being used incidentally at my company".

Personally, I find it a bit hard to fully get what this distinction is intended to convey.
What does "Rust is being used incidentally at my company" actually mean? That my devs use ripgrep instead of GNU grep? Or that we use axum instead of express because the local RESF is vocal about it?
I wil close this as not sufficiently actionable as it is formulated.  I'll link this suggestion to #188 because there is a nugget of interesting question we can ask the community


pyglove/backend.py: remove invalid characters after function decorator

Removes (what I think is) a bad edit introduced in https://github.com/google/vizier/commit/5aad0c02624006b7ef6c2d16615ce442a151a2bc#diff-f913e6960ace197c5499de1d7a0da89de6a4e5e567b18e11b963e3b38c094c2aR381:
  @functools.lru_cache(maxsize=None)d_property
  def _tuner_id(self) -> str:
    """Returns the tuner id of current ."""
    return self._tuner.get_tuner_id(self._algorithm)

d_property isn't defined anywhere and causes the interpreter to throw a SyntaxError
Traceback (most recent call last):
  File "/Users/connorbaker/Packages/ghc_hyperopt/./ghc_hyperopt/__main__.py", line 6, in <module>
    from vizier import pyglove as pg_vizier
  File "/Users/connorbaker/micromamba/envs/ghc_hyperopt/lib/python3.11/site-packages/vizier/pyglove/__init__.py", line 20, in <module>
    from vizier._src.pyglove.oss_vizier import init
  File "/Users/connorbaker/micromamba/envs/ghc_hyperopt/lib/python3.11/site-packages/vizier/_src/pyglove/oss_vizier.py", line 32, in <module>
    from vizier._src.pyglove import backend
  File "/Users/connorbaker/micromamba/envs/ghc_hyperopt/lib/python3.11/site-packages/vizier/_src/pyglove/backend.py", line 422
    @functools.lru_cache(maxsize=None)d_property
                                      ^^^^^^^^^^
SyntaxError: invalid syntax

CC @daiyip -- am I missing something?

Thank you Connor!
This was a bug in our release to github process, bundled with the fact that our Github tests for Pyglove were disabled and we didn't notice that.
This also caused https://github.com/google/vizier/issues/1031
Working on a PR to fix both issues properly, please stay tuned.
Thank you for reporting!
Best,
Sagi

Superseded by https://github.com/google/vizier/commit/dd72c5fe12aee304a58628d7e2be2fc180112c91


update pdf quality of sampl host structures

@davidlmobley Do these look any better? I increased the quality of the jpegs then exported to PDFs from there.
sampl_host_structures_1.pdf
sampl_host_structures_coded.pdf

I have a higher quality pdf from Katy that I'll add instead of these.


support PostgreSQL >= 9.5 upsert capability

:+1:

@xvrl what is the advantage of using upsert?

@fjy you could still run into deadlock issues if you're not careful about ordering.

👍

@xvrl did you test this with local postgres?

@fjy yep, tested it


Address bc changes from Symfony 2.8 to Symfony 3

Ref: https://github.com/silexphp/Silex/issues/1302
How is pre-Symfony3 documentation handled?  Is that a separate page or should notes on pre-Symfony3 usage be included on this page?

The Silex master branch currently depends on Symfony 2.7+. The easiest would probably to make it require 2.8+ instead, allowing to use only the new APIs.

:+1:  thanks, got these issues as well with the latest Silex version.

Is there anything else that needs to be done here? Does this need to be rebased off of master before we can merge in?

As 2.8 is a LTS, I'm going to remove support for 2.7 in Silex 2.0. That could make things easier for everyone.

This one can be merged after #1338

Thank you @bestattendance.


[firebase_dynamic_links] not working on my iPhone but yes on others

Hi! I don't even know how to start explaining this or how or where to start debuggin it but dynamic links are not working on my iPhone XR but they are working great on other iPhones like SE, 7 and 11 Pro...
AlfredoMBPro:apperto alfredo$ flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.14.6 18G95, locale es-AR)
    • Flutter version 1.9.1+hotfix.6 at /Users/alfredo/Desktop/flutter
    • Framework revision 68587a0916 (3 months ago), 2019-09-13 19:46:58 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/alfredo/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B53
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.38.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (3 available)
    • SM G900H             • 4d0070a74a4821bd                         • android-arm • Android 6.0.1 (API 23)
    • iPhone Alfredo       • 00008020-001A03CE1161002E                • ios         • iOS 13.2.3
    • iPhone SE de Alfredo • 1ef594b0026a2a873a22f86bfa4e3e768b66f9ca • ios         • iOS 13.1.3

• No issues found!

Hi @quetool
can you please provide your  flutter run --verbose
debugging on the device that shows the issue?
Thank you

Hi @quetool
can you please provide your flutter run --verbose
debugging on the device that shows the issue?
Thank you

Wich logs do I need to capture? Only flutter run? Debugger (Observatory)? All of them?

@iapicca there you go https://gist.github.com/quetool/75947a9a68f25ab2a9a6a49bef677181 I hope it helps!

I am still facing this issue

Hi @quetool
I cannot access your link above
could you provide your flutter run --verbose
and your pubspec.yaml
if the output doesn't fit could you please attach it as txt file
Thank you

Hi @quetool
I cannot access your link above
could you provide your flutter run --verbose
and your pubspec.yaml
if the output doesn't fit could you please attach it as txt file
Thank you

It was there for a while until I deleted, I thought you downloaded it. I am not confortable sharing those kind of logs. As soon as I go back to work I'll upload again.

Sorry! I stopped working with flutter a month ago! I switched back to native. As soon as I return to Flutter I'll update this issue if isn't solved.

Hi @quetool
given your last message I'm closing the issue for now
Thank you


feat: changed hash for key of http-cache and twig-cache to use xxh128 instead of sha256

1. Why is this change necessary?
sha256 is much slower than xxh128
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
Closes #4774
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Will be handled with https://github.com/shopware/shopware/pull/4779


Fixes user assembly resolving managed dlls

Currently if you use any kind of type in a ufunction or uproperty of such from another project it'll cause a weaver file lock. This fixes that by applying the same resolver the managed UnrealSharp project does before hand.
Let me know if you'd like me to also fix unmanaged dlls in this pr and will also work on that.

Sorry for the slow review. Been pretty busy fixing some serious issues with the plugin and packaging.
What do you mean with unmanaged dlls in this context?

Thank you for the pull request! I forgot to merge this last week when I looked into it :D


Does this framework support full parameter PPO tuning for the Qwen2.5-14B model on 8-A100 GPUs with 80GB memory each?

as mentioned in the title.

Hi @hljjjmssyh, I think our framework can support your needs. You can try using FSDP backend + vLLMRollout with tensor_parallel_size=8 and tune the gpu_memory_utilization and other hyper-parameters.
If you encounter OOM, you can turn on the param offload in reference and reward model similar to qwen2_7b example. And you can also try param/grad/optimzier offload in actor/critic model if you prefer a larger micro-batch size for training.


While updating with API (/api/pages/{id}) Revision-Counter increases, but not the Content and not the Revision List

Describe the Bug
We created a small Script, updating a Page with HTML Content.
function Change-BookstackPage {
    param(
        [Parameter(Mandatory=$true)]
        [string]$Html,

        [Parameter(Mandatory=$true)]
        [int]$pageID
    )

    # Create the data to send to the API
    $body = @{
        html = $Html
    } | ConvertTo-Json

    # Ready the HTTP headers, including our auth header
    $authHeader = "Token {0}:{1}" -f $tokenId, $tokenSecret
    $headers = @{
        "Content-Type" = "application/json"
        "Authorization" = $authHeader
    }

    # Send the request to our API endpoint as a POST request
    $url = "{0}/api/pages/{1}" -f $baseUrl, $pageID
    Invoke-RestMethod -Uri $url -ContentType "application/json" -Method Put -Headers $headers -Body $body
}

The HTML Content is around 200.000 Chars long...
It has seemed to work, so we continued but now to the Problem!
When we start the Script, everything looks good - no errors, no failure or any negativ result.
The Revision Counter increases, the Content does not Change and no entry at all is shown in the Revision Overview!
That is all through Powershell! When we test the same Request with Postman (same body-content) everything seems fine!
Revision Overview

Result from Postman (same result in Powershell)

Steps to Reproduce

Run a Powershell Script with that Function,
add Change-BookstackPage $longHTMLContent {pageID}
See no Change and increasing Revision Number

Expected Behaviour

Page Content updating
Revision Counter increasing
Revision Overview listing Changes

Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v23.12.1

When i set the same HTML Content with the Editor - everything works, too!

The only thing I can see in your code from a quick scan without running, is that the ContentType is set twice. Powershell 7.4 adds specific handling for that, but not sure what happens on previous versions. If using an older powershell version, might be worth removing one of these to see if things change.

Tried without before, had seen a Post about Powershell to set it... But it made no difference at all
Thanks for your check!
I dont understand it at the Moment!
Why does it not fail? Why is it increasing the rev-counter and why is there no content change?
Any Log, i can provide or look at?

Back to the Roots... Same Result!
It does not seem to be a Rate-Limit, there would be an error - or not?

Nevermind... I've found the Problem!
It is/was powershell!
Problem here and with the example, is this Function ConvertTo-Json!
Microsoft changed the behavior for escaping at some Version!
The tested 5.1 powershell Version failed, because of escaping html to
group\u003e \u003ctr\u003e\u003cth\u003eDisplayName\u003c/th\u003e\u003cth\u003eDepartment\u
with powershell 7 to
group>
DisplayName	Department
All these Characters brought bookstack out of mind!
Like i said, everything seems to work! No Error... Increasing Rev-Counter but no Entry in the Revision-List
Maybe, this helps someone someday - Probably it could / shoud get catched, as an error!

Thanks for sharing your findings @DarthDestroyer.
from my testing, BookStack should work fine with unicode escapes in JSON content, but it may have been something specific in the exact content you had, and/or the exact resultant formatting.
Since this is resolved I'll close this off.
If anyone finds a specific issue with unicode escapes in JSON, feel free to raise via a specific issue.
In regard to the revision count, that can occur. The page revision count increments on any change, whereas a revision is only stored when a change is made to the name/html, or a summary has been set. There's existing issue #2373 related to problematic revision numbering that I'd consider this to be part of, I'll reference this issue to make that part of revision numbering a consideration there too.

I just pushed html code and it has changed through the revisions... Thats what i've meant with "when i edit the page and change the html by hand" and it does change after that.


[Request] Add option to download multiple magnet

Hello,
This is great way to download torrent using google's computing power. However can you please make a way to download multiple magnet link at a time. As we're using google's server power, I think it will be a great way to use its resource to the full capacity.
Thank you for your time and consideration.

you can make a copy of the cell where you put the download link and run it
So the next torrent will be downloaded in the serial order after the previous one is finished.


V2

Hi,
I have refactored the code to be compliant with the new version of the ToxiProxy. I removed the REST client and use a standard HttpClient.
There are integration tests to cover all the features but it might be that we can find some other tests to add to increase the general coverage.
Every question/comment/suggestion is welcome.
Regards,
Federico

This looks great. Sorry its taken me so long to look at it - just got back from holiday.
Will merge and look at updating the nuget package as soon as I get myself settled back in.
Mark

Hi,
no problem, I'm still back home from holiday :-)
I think I should update the documentation, isn't it?
2016-08-21 20:17 GMT+02:00 Mark deVilliers<EMAIL_ADDRESS>
This looks great. Sorry its taken me so long to look at it - just got back
from holiday.
Will merge and look at updating the nuget package as soon as I get myself
settled back in.
Mark
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mdevilliers/Toxiproxy.Net/pull/8#issuecomment-241272677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJkhQPquM93nxuHYDCxSdL-A6fAo0P9pks5qiJYdgaJpZM4JjxdQ
.

--
Ing. Federico Orlandini
Tel.<PHONE_NUMBER>
skype: federico.orlandini


[Windows] Add Node.js v20

Description
This adds Node.js v20 to windows images
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022


scroll factor

Is possibile to reduce scroll factor to have a slower scrolling?

Use this function.
gyroscopeObserver.setMaxRotateRadian(Math.PI/9);

Thanks!


Better UX for constant output function for Sel.Hashing

Sel.Hashing uses a Maybe HashKey parameter to hashByteString.
However this is not fantastic in terms of readability.
I'd like to avoid Maybe-blindness by having a sum type like data KeyParma = Key <hashkey> | NoKey (or Constant).

@divarvel @kozross @a-02 your input would be appreciated. :)

I'm OK either way: I don't really feel this is confusing or less readable.

Key / NoKey does not improve readability compared to Maybe Key  imo.
Is there a canonical name for when the operation is ran without a key? (eg deterministic or something). Using this name in a sum type could make things clearer.
Also, if the presence/ absence of key changes semantics too much, then maybe two functions would work better by not conflating different operations.
That being said:

I haven't use these operations so I might be off the mark
I think Maybe is okay anyway, I understand it's a matter of making things better, but the existing state of things is not horrible either.

@divarvel Well, the change of semantics is "same input gives same output", which makes sense when one has been diving into this kind of API for a while. Not sure about outsiders though.

It appears that the Blake2 paper uses "Keyed"


Change pjax binding on links.

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
-

Very useful fix that bind pjax handler on all links, including links come via pjax.

I'm sorry to inform you that the core team has decided to stop with the support of PJAX. This implies that we are not accepting PR's for updating PJAX in the 2.0.x branch anymore. In the 2.1 branch it will be removed from the framework.
A lot has been said on this subject. Our conclusion is that the current state of PJAX does not meet our standards to properly support in the Yii framework. For this reason, we are also not moving it into a Yii2 extension. Of course the Community is free to fill this gap, but with a warning. It is very time consuming to support and in our humble opinion, it should be completely rewritten to properly meet the many usecases developers have with it.


Feature: support SARIF output

This enabled the Action to integrate with GitHub Security.

SARIF is supported - but the file is not uploaded by default to GitHub. I think SARIF should be the default and the upload should be performed by the action. But the following code works:
    - name: Checkov GitHub Action
      uses: bridgecrewio/checkov-action@master
      with:
        directory: .
        output_format: sarif

    - name: Upload SARIF file
      uses: github/codeql-action/upload-sarif@v1
      with:
        sarif_file: results.sarif
      if: always()


ipv6net cidr filtering

Co-authored-by: Angelo Puglisi<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@VadimZy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

484c2cf ipv6net cidr filtering

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: VadimZy
To complete the pull request process, please assign gnosek after the PR has been reviewed.
You can assign the PR to them by writing /assign @gnosek in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @VadimZy. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hey @VadimZy
Could you sign off your commits, please? :pray:

@VadimZy: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

will create a new with correctly signed commit


Can't access zip file

Dear CDrummond:
I failito install material skin on LMS and find following message
unable to download MaterialSkin from https://github.com/CDrummond/lms-material/releases/download/2.1.3/lms-material-2.1.3.zip - Connect timed out: Resource temporarily unavailable
while i cannot access this link in browser too
Thanks
jf7642

Works for me. However, an errors such as this would be a github issue, nothing I can do about it.

Works for me. However, an errors such as this would be a github issue, nothing I can do about it.


Implement .interruptible operation

Implementation for #706

Left old .uninterruptible (without .interruptible support) alongside with the new ZIO.uninterruptible.
ZIO.uninterruptible type inference works with 2.11 and 2.12, but fails with Dotty (hence the failed CI). Help would be appreciated. CC-ing @fkowal.
ZIO.uninterruptible(ZIO.unit.interruptible.interruptible): UIO[Unit] typechecks due to idempotent nature of with, so I made .interruptible idempotent to match that.

Implemented "localized catching" of interruptions. But making fiber that has recovered from interruption terminate after exiting uninterruptible block turned out to be tricky. Will spend more time tomorrow.

@jdegoes
Note that this is a version without "localized catching" of interruptions. I'm still working on that feature.

@mvv Can I steal the tests from this one?


Add JWT feeder

JWT feeder must be able to:

generate a jwt token from the template
parameterize some fields

need more specification

https://tools.ietf.org/html/rfc7519


Pull changes from master

The purpose of this PR is to reduce the delta between the update-datastore branch and master to facilitate easier merging into master when v1beta3 is released.  The last two commits include merge conflict resolution.

Noticed one issue: the merge didn't take the master's up-to-date ServiceOptions.Builder.projectId(String projectId) method, instead taking the update-datastore version.  Will fix in next commit.

In addition to fixing merge conflicts, the following changes were applied:

Change the retry codes from HTTP codes to gRPC ordinal codes.
Remove unnecessary "protected" modifier from two DateTime functions.
Set QueryResults.cursorAfter to be the batch's endCursor when we run out of results.
Fix update-datastore's ServiceOptions to accept null project ID.


VLAN

Hi rundqvist,
I can't get this to work in a container connected to a VLAN, only with the network in HOST mode. Is that intended?
In HOST mode it works like a charm!
Thank you!

Hi,
Have you entered the environment variable NETWORK?
I haven't tested it with VLAN, but it works fine in bridged mode if NETWORK is entered correctly.
Regards
/rundqvist

Hi Mattias,
Yes in bridge mode it works like a charm. Thank you for that. In a vlan is does not connect to the lan. It does to the vpn provider, but you cannot connect to the container.
Regard,
Harm
TypeApp voor Android downloaden
Op 5 sep. 2020 20:59, om 20:59, Mattias Rundqvist<EMAIL_ADDRESS>schreef:

Hi,
Have you entered the environment variable NETWORK?
I haven't tested it with VLAN, but it works fine in bridged mode if
NETWORK is entered correctly.
Regards
/rundqvist
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/rundqvist/docker-openvpn-tinyproxy/issues/1#issuecomment-687648718

Could you please provide your vlan settings (preferably in 'docker network create'-command line format), and I will investigate it.


JS implementation for String.copyTo doesn't copy some esoteric Characters correctly

I have been working on ceylon/ceylon-sdk#449, and found that this string: 𐀀􏿽􏿽 encodes fine on the JVM but is partially incorrect on JS (too short and distorted near the end). Single characters and longer strings of more common characters work fine.
I've traced this to CharacterBuffer.array, which is an Array<Character> populated from a String by a call to String.copyTo
Printing the String literal and printing CharacterBuffer.array after copyTo:
JVM:
𐀀􏿽􏿽
{ 𐀀, 􏿽, 􏿽 }

JS:
𐀀􏿽􏿽
{ 𐀀, 􏿽, � }

If I swap out string.copyTo(array); for:
for (i->c in string.indexed) {
    array.set(i, c);
}

Then JS returns (the same as JVM):
𐀀􏿽􏿽
{ 𐀀, 􏿽, 􏿽 }

The native JS implementation looks equivalent to the above Ceylon, but perhaps there's some subtle error?

@chochos I see you wrote the native JS for this, any thoughts?

Probably something to do with codepoints


had an odd issue concerning check(string $url)

receive a
[19-Jun-2017 00:36:10 America/New_York] PHP Catchable fatal error:  Argument 1 passed to Hedii\UptimeChecker\UptimeChecker::check() must be an instance of Hedii\UptimeChecker\string, string given, called in /home/bitveuba/bitp.in/functions.php on line 22 and defined in /home/bitveuba/bitp.in/vendor/hedii/uptime-checker/src/UptimeChecker.php on line 142  in error log at BITP.in/
the only I could resolve the error was to remove 'string' from line 142 in /home/bitveuba/bitp.in/vendor/hedii/uptime-checker/src/UptimeChecker.php

This package needs php >= 7.0
What is your php version?

7.0

Can't reproduce.
Everything is tested with php 7.0 (https://github.com/hedii/uptime-checker/blob/master/.travis.yml https://github.com/hedii/uptime-checker/blob/master/tests/UptimeCheckerTest.php) and tests are passing (https://travis-ci.org/hedii/uptime-checker/builds/244395477).
You may have to double check your configuration and/or code.


Problems to install in MAC

I have a problem, result the error:
<EMAIL_ADDRESS>start /Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic

tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"

error TS6053: File '/Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic/typings/index.d.ts' not found.
npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v6.6.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js" '.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ng-semantic package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ng-semantic
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ng-semantic
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic/npm-debug.log

My debug.log
sh-3.2# cat npm-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic/node_modules/.bin:/usr/local/bin:/Library/Frameworks/Python.framework/Versions/3.5/bin:/usr/local/sbin:/Applications/MAMP/Library/bin:/Applications/MAMP/bin/php/php5.6.10/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin/npm:/Users/farnetani/Library/Android/sdk:/Users/farnetani/Library/Android/sdk/tools:/Users/farnetani/Library/Android/sdk/platform-tools
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c',
11 silly lifecycle   'tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js" ' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 2  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"
14 verbose stack Exit status 2
14 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:242:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:877:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /Volumes/WINDOWS/Dropbox (Pessoal)/Dropbox - 2016/www-2016/Angular2/ngSemantic
17 error Darwin 15.5.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
19 error node v6.6.0
20 error npm  v3.10.3
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"
22 error Exit status 2
23 error Failed at the<EMAIL_ADDRESS>start script 'tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js" '.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the ng-semantic package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     tsc && concurrently "tsc -w" "npm run tsc:w" "lite-server -c dev.config.js"
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs ng-semantic
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls ng-semantic
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

It seems like the typings did not install properly! Try running the command manually: npm run typings

Yes...now work! Cool! Thanks a lot!

In fact, with typescript v2+, we should not use typings but install definition files from the @type npm scope instead. @vladotesanovic, need to also plan that. I create an issue.


Allow negative exptime values in memcached storage commands

Memcached allows negative exptime values in storage commands to immediately expire the stored values, but this wasn't very well documented until recently (here's the commit that adds the documentation from May 2016: https://github.com/memcached/memcached/commit/e7d4521cd8b27f7ebc6e4c1b9aee9eb3544f6af5).
This patch allows the memcached parser to support negative exptime values in storage commands. The server still responds with the usual STORED if the exptime is negative, so no additional response handling is needed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.voetsjoeba seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@voetsjoeba - Not sure if you're still active on GitHub. Years after this pr was created, twitter started requiring CLAs for contributions - To follow that as an external collaborator, I'm waiting for CLA signing before I look at the implementation