bug: changing neo-tree config

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.2
Operating system/version
ubuntu
Describe the bug
Not sure if this is the correct location for this issue, but here it goes.
I am trying to redo my neovim setup, taking lazyvim as the starting point. Now, I use htns for navigation (dvorak) so I want to disable/remap any plugin shortcuts that use those keys.
To that end, I added a neo-tree.lua file in the plugins folder, with the following contents:
return {
  "nvim-neo-tree/neo-tree.nvim",
  opts = {
    window = {
      mappings = {
        ["<A-h>"] = "prev_source",
        ["<A-s>"] = "next_source",
        ["l"] = false,
        ["s"] = "child_or_open",
        ["n"] = "",
        ["t"] = false,
        ["<"] = false,
        [">"] = false,
        ["_"] = "open_tabnew",
        ["|"] = "open_vsplit",
        ["\\"] = "open_split",
      },
    },
    filesystem = { filtered_items = { visible = true } },
  },
}

This does indeed work; e.g., t now moves up and does not do the default action (open in new tab).
(I tried using the keys key, as described here, but apparently neotree does not use that convention.)
However, the help no longer works. Pressing ? gives an error message. ("Error executing lua" in ~/.local/share/nvim/lazy/...).
Any ideas on why this is?
Steps To Reproduce

fresh lazyvim install
add file in .../lua/plugins/ folder with contents above
restart neovim
control-e to  go to neotree window
press question mark to see keymap info

Expected Behavior
the popup window with the keymaps for the neotree context is shown.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

I don't know if this will fix the help popup, but the neo-tree docs say you should map to "none" or "noop" to remove a default mapping.

Ah, thanks for that! Unfortunately, that didn't fix it...
E5108: Error executing lua: ...ud/.local/share/nvim/lazy/nui.nvim/lua/nui/line/init.lua:22: attempt to index local 'block' (a nil value)
stack traceback:
	...ud/.local/share/nvim/lazy/nui.nvim/lua/nui/line/init.lua:22: in function 'append'
	.../lazy/neo-tree.nvim/lua/neo-tree/sources/common/help.lua:62: in function 'show'
	...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:882: in function <...y/neo-tree.nvim/lua/neo-tree/sources/common/commands.lua:879>

But do let me know if I should ask neo-tree devs directly

return {
  "nvim-neo-tree/neo-tree.nvim",
  opts = {
    window = {
      mappings = {
        ["<A-h>"] = "prev_source",
        ["<A-s>"] = "next_source",
        ["l"] = false,
        ["s"] = "",
        ["n"] = "",
        ["t"] = false,
        ["<"] = false,
        [">"] = false,
        ["_"] = "open_tabnew",
        ["|"] = "open_vsplit",
        ["\\"] = "open_split",
      },
    },
    filesystem = { filtered_items = { visible = true } },
  },
}

This works for me. I removed child_or_open because it wasn't a valid command. Also, this is not a LazyVim bug, but a user configuration issue, since the default settings work out of the box. It would be better if you create a Discussion in the future for similar problems.

Ok, many thanks for looking into this. I'll create a discussion next time!


Optimize registry config for extends

Motivation:
Optimize registry config for extends
Modification:
you can see some changes in code, they are confused.
pls give some advice .
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

Codecov Report

Merging #86 into master will decrease coverage by 0.06%.
The diff coverage is 35.71%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     53.82%   53.76%   -0.07%
+ Complexity      382      381       -1
============================================
  Files            53       53
  Lines          1724     1726       +2
  Branches        308      307       -1
============================================
  Hits            928      928
- Misses          619      620       +1
- Partials        177      178       +1

Impacted Files
Coverage Δ
Complexity Δ

...fa/rpc/boot/container/RegistryConfigContainer.java
46.55% <35.71%> (-1.67%)
9 <6> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2477b...62d48c9. Read the comment docs.


Use event.buf directly to get bufnr

Due to the neovim's issue (https://github.com/neovim/neovim/issues/16416), using vim.fn.expand sometimes throws Keyboard interrupt error when pressing Ctrl-C (a common alternative to Esc).
This works around the above issue by simply getting the buffer number from event argument.

Ahhh of course, thank you!


Right click (Contextmenu) event

Can this event be added to a node. I would like to override the right  click event.

you have to use an external js, there is no such functionality.
read
http://bit.ly/1VP4cQx


Use syntax highlighting in readme code blocks

Yeah, it's a pretty lame little pull request but I just wanted syntax highlighting on your readme. 😀

This change is

Thanks!


browserpassFillForm - support sites that override Event such as dell.com

General information

Operating system + version: Ubuntu 18.10
Browser + version: Chrome and Firefox

Using inject.js directly injected via dev console.

Exact steps to reproduce the problem

Go to dell.com
Click log in
Attempt to autofill

What should happen?
Autofill successfully.
What happened instead?
Autofill does not work, instead we get Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.
The problem
The issue appears to be that some sites define their own Event. We can see easily by typing in Event in a browser dev console on dell.com's login and again on any other website. Event should be native code, but in dell.com (and presumably others using this questionable technique) it is not.  A search for the error finds others doing the same thing.
Suggested Fix
The click and focus events are not strictly required and only help in getting sites to revalidate the forms that were autofilled instead of typed by a person. As such, I recommend simply ignoring errors. This fix makes browserpass work on dell.com
     try{
        el.dispatchEvent(new Event(eventName, { bubbles: true }));
      }catch(e) {
        console.warn('Unable to dispatchEvent ' + eventName, e)
      }

This must be applied to both el.dispatchEvent lines. I'd be happy to submit a pull request but wanted to run this by someone first, as ignoring errors outright is maybe not the best solution.
Tangent
I found this while comparing the performance of browserpass's inject.js against other open source password managers. I compared Mitro's, which I'm using myself on Passit, and 1password (notable because bitwarden uses theirs). inject.js actually holds up very well despite being a much smaller and easier to read code base. I'd be happy to collaborate further if you'd like and set up a shared package to autofill login forms. This would make finding and fixing sites that do not work easier to do. In any case you may be interested to know I'm evaluating replacing my current solution (Mitro autofill, but with jquery stripped out) with yours. I'm also interested in trying to reproduce edge cases like these as unit tests.

I have only 2 tests right now here. It's not easy to write when the problem is interfering Javascript. My idea is to identify why form fill fails for any site that it has trouble with, then write a test as an approximation of what caused it to fail.
Thanks for pointing out v3, I didn't notice that. For now I'll continue to report any bugs I find (and fixes). That will also let me rebase my code off of it easily. If you'd like to contribute to testing, I'd be happy to set up a repo and CI that runs the tests.
Here are my test sites btw. Passit 1.11 should be good to go with browerpass's implementation. :smile:

Cool, and those 2 tests look quite interesting 👍 I'll get back to you when things clarify with v3 a bit...
By the way, just tested both browserpass v2 and v3 on these websites, and it is able to fill credentials everywhere just fine...

https://www.dell.com/Identity/global/LoginOrRegister
https://chase.com

Not sure what's wrong with your way of testing on dell.com, but with chase.com, browserpass is injecting the script in each iframe, that's how it manages to fill the form.

I understand the iframe issue (I was copying in the script manually thus not affecting every frame). I'm surprised version 2 is working for you on dell though. I'll look more into it later.

I can confirm it works from the actual extension but not when I copy it to console. I have no idea why. It very clearly errors with a TypeError when injected manually. I copied inject.js into the console. Then run window.browserpassFillForm({u: "username", p: "pass"}, false). Up to you if you want to just close this or look into why this happens.

Here's the answer 😉 https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Content_scripts#Content_script_environment

Content scripts can access and modify the page's DOM, just like normal page scripts can. They can also see any changes that were made to the DOM by page scripts.
However, content scripts get a "clean view of the DOM". This means:

content scripts cannot see JavaScript variables defined by page scripts
if a page script redefines a built-in DOM property, the content script will see the original version of the property, not the redefined version.


Correct IRC info in README

Also throwing in a forums link, because that's more active.

Thanks !!

@raucao, sorry, I'm not yet fully familiar with the yunohost-bot. The README and REAME_en files are automatically generated from the files in the "doc" folder... :confounded:
So, the modifications of your PR have been eaten by the bot...
If you want, you can make a new PR by modifying the DESCRIPTION and DESCRIPTION_en files, otherwise I'll do it soon... :slightly_smiling_face:

No worries. If you could do it, I'd appreciate it a lot!


Game states I'm dead, twice, with 9 HP

Hey Chris,

As you can see from the image, the game stated that I was dead. That was the second time. The other is already out of the screen.
Dunno how to give you any more help than this, sorry.
I really need to dive into your code!!
Cheers,
Gus

Hey Chris,
After discovering the map on the right upper corner, the game crashed.
Linking the saved game...
axes.data.txt
Cheers,
Gus

Hmm, from looking at the save file (thanks for including that, it's a big help) your health was actually -12 at the time. It looks like I'm not calling the UpdateHealth function in the UI enough. I'll take a look at that.
As for the game crashing, I think that's a 'range out of bounds error' that crops up intermittently. I think that it's caused by a glitchy FoV that extends outside the edge of the map. I'll take a look at that too.
Thanks for checking it out!

Hey Chris,
No probs, you're quite welcome.

... looking at the save file (thanks for including that, it's a big help) ...

Yeah, a habit I picked up from testing The Colonists

Thanks for checking it out!

Every time you commit stuff I take peek, no problem at all :)
BTW, I must apologise I haven't started the tests. I was a bit obsessed with the setup-lazarus Action that I forgot about everything else. I know have it at a point that I only need to muster courage to deal with macOS and the dreaded *.dmg.
Also, you not using OOP kinda makes it a rather interesting challenge I haven't had the courage to tackle, to be honest, ehehehe.
But I will !!!
Cheers,
Gus

Yeah, I've just come off a year of using Java where everything is an object and wanted to test myself to see if I could use advanced records instead. It's kinda simple keeping everything on the stack.
No problems with the testing, it's given me a little more time to do some refactoring anyway ;-)

Hey Chris,

... see if I could use advanced records instead ...

Yeah, that's something I'll have to deeply look into. For me a record with methods is quite odd, since that's, KINDA, how I see what objects are...

No problems with the testing, it's given me a little more time to do some refactoring anyway ;-)

Yeah, I was banking on that. Hence me not being terribly ashamed of not having the tests started, ehehe
Cheers,
Gus

Hey Chris
I'm closing this issue since I think you nipped in the butt with da4efed.
Cheers,
Gus


Update LA description to account for blocked tasks

After rolling out https://github.com/aptible/cadvisor-factory/pull/7, we'll want to update our copy to match reality.
cc @fancyremarker

👍


prevent connections to self

Now that we allow the 'standard Weave port' to be configured, there can be two Weave processes running on the same machine at different port numbers.
Suppose we have hosts <IP_ADDRESS> and <IP_ADDRESS>, and we are running Weave on ports 3000 and 4000 - four processes in all.
During start-up, <IP_ADDRESS>:3000 receives via gossip the information that <IP_ADDRESS>:4000 has a connection to <IP_ADDRESS>:4000.  It takes the endpoint <IP_ADDRESS>:4000 and tries to connect to the address formed by adding its own standard port number to the IP address, i.e. <IP_ADDRESS>:3000, which is itself.

The only problem that this causes is unnecessary connection attempts and the associated log noise.

Edited into the original comment.

It takes the endpoint <IP_ADDRESS>:4000 and tries to connect to the address formed by adding its own standard port number to the IP address

As of 61a5640a95dec850443af3d7406280bcedfd9f52 this only happens when that is the endpoint of an inbound connection. Which is of course possible.
The challenge in attempting to fix this is that weave peers generally do not know what their IP address is. Especially when running inside a container, which is the normal case.
We could look at what IP addresses other peers have seen for us. Or we could remember to never connect to a particular address once we have discovered that it leads to ourselves. So far we've deliberately avoided making any permanent associations between IPs and peers, since it is possible for that to change over time.
Overall, I don't think this is a pressing issue. -> icebox

subsumed by #1305.


Display user gravatar

Closes #22

Looks nice, but maybe a bit overkill to add a new dependency compared what is a one-liner in python.

True, but in minitwit.py they do a bunch of encoding which I don't really get, so I figured it was easier to implement and read by using a library.


Semantic File URLs

After switching over from Thumbor to Sharp, the URLs become hashed jibberish.
I was wondering if there is (or will be) an option to have a more semantic URL for these files?
The reason I'm asking is really for having meaningful filenames, and hopefully a little advantage on SEO as well.
https://webmasters.stackexchange.com/questions/102419/converting-default-normal-filenames-to-a-random-string-of-text-whats-better
Just for your reference, IMGIX makes use of query strings to achieve a similar effect. Something like this: https://www.example.com/some-file-name.jpg?w=1903&h=933&fit=crop
with the optional "signature" query string appended to the end like this to avoid spam abuse:
https://www.example.com/some-file-name.jpg?w=1903&h=933&fit=crop&s=V5kYnb7bdDaCfgeB
Your help is appreciated!
Thank you very much!

Thanks for your opinion, @bs-thomas
The solution is still supporting some Thumbor style URLs. You can refer to the implementation guide Appendix D: list of Supported Thumbor Filters.
Would it be enough to answer your question or you actually need a new feature?

Thanks for your prompt response @beomseoklee .
I understand that it supports the legacy Thumbor style URLs, but reading some previous issues it doesn't seem to be quite fully supported, and also thumbor's API and Sharp's API and methods seem very different.  In the long run in terms of sustainability, I feel that this structure is going to face some limitations and other unexpected issues.
I noticed that this project has switched from Thumbor to Sharp, and I could imagine that when there is a better library in the future, the default would be switched over to that new library.  That is a good move actually, and I fully support this, because packages come and go, and when there's a better vendor, we should use the better one.
However, what I thought is that we should keep the interface flexible, and consistent, regardless of which image resizing package we use behind.  That will minimize breaking changes caused to users of this package.  Does that sound reasonable to you?
My Recommendation
After giving a deeper thought, my recommendation is actually to not copy IMGIX's interface, because it does have some limitations.
For example, consider if I have two operations: (a) Rotate 45 degrees, (b) Flip horizontally, on Imgix, the query string would be "?flip=h&rot=45.0"
But note that depending on the sequence, there could be two different outputs:
(sequence 1) if you perform (a) first, then (b)
(sequence 2) if you perform (b) first, then (a)
So my recommendation is to use the following format (or any format with similar logic):
"?m[]=flip(h)&m[]=rot(45)"
How does the above recommendation sound?  And what do you think of this, in general?
=====
Also, I forgot to thank you and the team last comment, for making such a beautiful system for resizing images on-the-fly.  It's really a cost savings approach.  To be frank, I'm paying hundreds of dollars monthly just for IMGIX right now, just for resizing images.  Sounds ridiculous, and that's why I'm looking for alternatives like this one now.
Thank you very much!!

I would like to see this supported as well. Another reason is to allow CloudFront wildcard signed cookies.
In my scenario, all images are private. I would like to be able to generate a signed cookie for my users that grants access to the handler at a path like /companyABC/*. If I understand correctly, the only other 2 options besides signed cookies would be signed URLs (not practical when getting a list of thousands or even hundreds of images), or a Lambda@Edge authorizer. The Lambda@Edge would probably work well, but it's another moving part.
I'll check out the legacy Thumbor URLs as a stop gap.

This is something that we would be interested in also, as we currently are forced to keep using version 3.1 as it still supports Semantic File URLs for the serverless image handler function.
I can see that version 4.* supports some of the Thumbor style URLs, but this doesn't guarantee the longevity of it? It would be just as much of a risk to migrate to 4.* and have the support removed in later versions of the image handler.
Can you guarantee that the Thumbor style URLs, will be supported for further version of the image handler? If you cannot then can this be a feature, as the base64 encoded URLs just don't make sense for our use case.

I just switched over to using the legacy Thumbor format and they work fine and play nicely with signed cookies. But, I only need to do resizing, so very limited use case. And it's also worrisome that those could (and probably should) be pulled out in a future version.
@bs-thomas's suggestion of abstracting the URL format away from the underlying processing library is spot on. That's certainly the "right" software design choice (if there is such a thing).

The changing URL based on the underlying library and the hash in the URL is definitely an issue, especially for semantics and SEO. I would agree with @bs-thomas 's suggestion of abstracting the URL format from whatever library is being used. Keeping the Thumbor style URL from version 3.1 and allowing it in version 4.* could solve this problem. However, S3 bucket subfolders are not supported in version 4 from what I see in the docs. That would also need to be fixed if that style was used.

@Furytron actually the latest version, v4.2, supports image files in subfolder as a part of PR #130 . The document needs to be updated. I will ask to update the document.

Thanks @beomseoklee thats good news. Is there plans for long term support of Thumbor? Or at least the URLs?

@Furytron we are going to support Thumbor style URLs as many of users actually use Thumbor style URLs.
But for the original topic, we will think about what would be the best way to support.

I also wanted to mention that the current "hashed" URLs are creating issues for my Javascript components.
My javascript component is a "file uploader", and after uploading, it will read the "extension" of the URL, and depending on the extension, decides if the uploaded DIV should display a thumbnail image (eg. PNG, JPG, GIF), or not (eg. PDF, DOCX, ZIP).  Without the extension, it is unable to determined this.
I have also another advice regarding on Thumbor URLs.  While I think support of this should be continued (because many users are still using it), I would like to bring up the point that it actually modifies the "original URL" but changing the "path to the file".
I feel that mutations /variations of the image are supposedly "still the same image", and is only a "variation of the same image", so I personally feel that the URL should not be modified.  "Query strings" is a very good tool to define these variations / mutations, and thus my original suggestion as follows:
"https://example.com/some/path/to/s3/example-file.jpg?m[]=flip(h)&m[]=rot(45)"
Parsing the above URL requires close to zero effort.  Any tool can extract the query string away, and there is the actual file location.
Query string parameter "m" (standards for mutation) is an "array", and should be processed sequentially from first to last.  This allows the flexibility of applying the "same function" twice (like how Sharp allows you to "chain methods").
Then we can legitimately perform the following operation:
"https://example.com/some/path/to/s3/example-file.jpg?m[]=rot(90)&m[]=rot(90)&m[]=rot(-180)"
... and we get the original image back ;-)

Thanks for you guys comments all.
I've created a beta version which can include query strings on URL.

Template URL: https://solutions-features-reference.s3.amazonaws.com/serverless-image-handler/v4.2.1-beta.2/serverless-image-handler.template

The supported filters are same as legacy Thumbor style, so you can refer to the Serverless Image Handler documentation.
Here is the example usage:

Resize: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300
Resize + fit-in: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&fit-in
Resize + fit-in + grayscale: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()
Resize + fit-in + grayscale + rotate: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()&filter:rotate(90)

Since Amazon API Gateway supports multiple query string parameters that have the same name, every filter query string would be adapted. See the Amazon API Gateway documentation regarding multiple query string parameters on Amazon API Gateway.
As this is not the production version (experimental version), I would recommend you to test this version, and if it looks good to you, you might be able to use this one on your production environment. If not, please don't use this one on your production environment.
Please let us know if you have any feedback so that we can hopefully add this feature in the next update.

@beomseoklee Thank you very much for your prompt implementation of a beta.  Really appreciate it!
To be frank I haven't yet had a chance to try it out.  But I do notice one thing that may not be able to address.  (Or it could be that I have misunderstood something?)
Consider the following example:
"https://example.com/some/path/to/s3/example-file.jpg?m[]=flip(h)&m[]=rot(45)"
As you see, if I do a "flip horizontally" first, then do "rotate 45 degrees", the end result is different than if I do "rotate 45 degrees" first, and then do "flip horizontally".
So the "sequence" of these transformations do matter.
How would the new implementation address this issue, and how does it prioritize the transformations?
Thank you very much!

@bs-thomas I haven't tried the order of filters (Thumbor flipping seems available with -0x-0 size, but we don't have this feature), but I'm sure that edits JSON object will have keys with query strings order, so what you are asking would be fine.

@beomseoklee Sorry maybe I wasn't so clear on my question.
The original topic in this issue was related to have some sort of "common interface" (regardless if it were Thumbor or Sharp) so it could be used as an abstracted interface for this image handler.
You have came up with the new beta implementation, which uses this format:
https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()&filter:rotate(90)
But what I mean is, the above format does not present any sequence (which it could yield different results if the filters were different from the example you gave).
Your Example, you have:

width=300
height=300
filter:grayscale()
filter:rotate(90)

If we flip them around, yields same result:

width=300
height=300
filter:rotate(90)
filter:grayscale()

However, if we modify your Example slightly, so "filter:grayscale()" becomes "filter:flip(h)"

width=300
height=300
filter:flip()
filter:rotate(90)

If we flip them around, yields a different result:

width=300
height=300
filter:rotate(90)
filter:flip()

So, what I'm trying to say is, can the interface you have designed, but upgraded such that this flexible could be put into consideration?  (Previously, I had a recommendation for you, by using query string arrays.  I'm there are other ways, but just wanted this to be addressed, together along with the solution obeying the "semantic URL" rules).
Thank you very much!

@bs-thomas Thanks for your feedback again. Currently, every filter will be added in edits, and if you provide same filter twice, it will overwrite the first one. For example, https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:rotate(90)&filter:rotate(90) would return an image rotated by only 90 degrees.
I will look at the Thumbor filters more precisely so that our "technically supported" Thumbor URL could do exactly same with Thumbor.

I think even a way to 'escape' the hash so you can add your own filename would help here:
https://distributionName.cloudfront.net/base64encodedrequest

https://distributionName.cloudfront.net/base64encodedrequest/fileName.jpg

Thanks for you guys comments all.
I've created a beta version which can include query strings on URL.

Template URL: https://solutions-features-reference.s3.amazonaws.com/serverless-image-handler/v4.2.1-beta.2/serverless-image-handler.template

The supported filters are same as legacy Thumbor style, so you can refer to the Serverless Image Handler documentation.
Here is the example usage:

Resize: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300
Resize + fit-in: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&fit-in
Resize + fit-in + grayscale: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()
Resize + fit-in + grayscale + rotate: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()&filter:rotate(90)

Since Amazon API Gateway supports multiple query string parameters that have the same name, every filter query string would be adapted. See the Amazon API Gateway documentation regarding multiple query string parameters on Amazon API Gateway.
As this is not the production version (experimental version), I would recommend you to test this version, and if it looks good to you, you might be able to use this one on your production environment. If not, please don't use this one on your production environment.
Please let us know if you have any feedback so that we can hopefully add this feature in the next update.

@beomseoklee
Once again really thanks for spending the time responding and covering my issue.  I've had a chance to try your new beta, but for some reason, it seems like the "rotate" and "grayscale" filters are not working here.  Please see this URL:
https://d1spq9esmard59.cloudfront.net/clients/codebase.beam.style-local/public-default/some-relative-directory-to-public-default/test.jpg?width=300&height=300&filter:grayscale()&filter:rotate(90)
Not sure what's going wrong there.  Would you have any ideas?

@bs-thomas That was my mistake. It should be like this.
https://d1spq9esmard59.cloudfront.net/clients/codebase.beam.style-local/public-default/some-relative-directory-to-public-default/test.jpg?width=300&height=300&filter=grayscale()&filter=rotate(90)

@beomseoklee Thank you very much!  That seems to work.
Btw, is it really not possible to make the "filter=" "filter[]=" instead?
I use PHP, and because the query string is invalid (containing same key twice), calling this function to convert from array to query string returns the wrong output:
        http_build_query([
            'width' => '300',
            'height' => '300',
            'filter' => 'grayscale()',
            'filter' => 'rotate(90)',
        ]);

width=300&height=300&filter=rotate%2890%29
which is wrong, because it is missing "grayscale()"
Right now, I'm forced to use some manual method to convert from array to query string, but that is not robust, and is deemed to have unexpected problems later.
Would really appreciate you could make this change for me!  Thank you!

@beomseoklee With this new style of URL, would it then be possible to support multiple buckets while building the filters in the URL. Perhaps by passing a bucket parameter, if it's not possible to parse the bucket name from the path itself?

@beomseoklee Was the beta version with symantic filenames ever merged into production? It seems that the current version only supports the encoded string unfortunately.

Just reaching out to add my support for the design implemented in the beta by @beomseoklee
Is v4.2.1-beta.2 the only version with this feature or is it available in later versions?

@beomseoklee I have the same question, shame I cannot find this code anywhere. @haxiomic have you advanced on this since 2022?

Hi @javierlinked,
I've regenerated the template and uploaded it to the same link as in Beomseok's comment. I've made a couple changes to get the deployment functional (including a lambda runtime bump), but I haven't verified functionality.  You'll likely need to download the Lambda package and fix any issues created by modifying the runtime.
In the meantime, I've reopened this issue, and we'll re-evaluate if this is something that makes sense to add to SIH.

Thanks @simonkrol, @beomseoklee. It would be great to have this feature as part of the core package, instead of a customisation, also CloudFront needs to be configured to whitelist certain query string parameters, etc.

Hey @beomseoklee
I tried to parse the query string as you mentioned

Thanks for you guys comments all. I've created a beta version which can include query strings on URL.

Template URL: https://solutions-features-reference.s3.amazonaws.com/serverless-image-handler/v4.2.1-beta.2/serverless-image-handler.template

The supported filters are same as legacy Thumbor style, so you can refer to the Serverless Image Handler documentation.
Here is the example usage:

Resize: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300
Resize + fit-in: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&fit-in
Resize + fit-in + grayscale: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()
Resize + fit-in + grayscale + rotate: https://example.com/some/path/to/s3/example-file.jpg?width=300&height=300&filter:grayscale()&filter:rotate(90)

Since Amazon API Gateway supports multiple query string parameters that have the same name, every filter query string would be adapted. See the Amazon API Gateway documentation regarding multiple query string parameters on Amazon API Gateway.
As this is not the production version (experimental version), I would recommend you to test this version, and if it looks good to you, you might be able to use this one on your production environment. If not, please don't use this one on your production environment.
Please let us know if you have any feedback so that we can hopefully add this feature in the next update.

Hey @beomseoklee
I tried to parse the query string as you mentioned, but it is not working for me, I installed the latest version of the template, is this feature didn't get merged to production?

I tracked the request through Lambda logs and I got this log which appears that the query string is being parsed from the CloudFront after updating its origin request policy.
My request is like the following:
https://.cloudfront.net/web/images/636447403654622319.jpg?width=600&height=600&fit-in
And here is the lambda logs:
2024-05-20T21:59:39.843Z	2f758119-8101-424b-979c-221e95803b34	INFO	Received event:  {     "resource": "/{proxy+}",     "path": "/web/images/636447403654622319.jpg",     "httpMethod": "GET",     "headers": {         "Accept": "*/*",         "Host": "flrin2a29i.execute-api.eu-west-2.amazonaws.com",         "User-Agent": "Amazon CloudFront",         "Via": "1.1 13b0de485c7b13f6889ba5a1aa346de0.cloudfront.net (CloudFront)",         "X-Amz-Cf-Id": "d66OMmsAQtmvvMVWjtnayEpdxleZ2KFgy-LN2xzsUo1LkOTNCGjdTA==",         "X-Amzn-Trace-Id": "Root=1-664bc7cb-3d30cbea4b58d09e294f159f",         "X-Forwarded-For": "<IP_ADDRESS>, <IP_ADDRESS>",         "X-Forwarded-Port": "443",         "X-Forwarded-Proto": "https"     },     "multiValueHeaders": {         "Accept": [             "*/*"         ],         "Host": [             "flrin2a29i.execute-api.eu-west-2.amazonaws.com"         ],         "User-Agent": [             "Amazon CloudFront"         ],         "Via": [             "1.1 13b0de485c7b13f6889ba5a1aa346de0.cloudfront.net (CloudFront)"         ],         "X-Amz-Cf-Id": [             "d66OMmsAQtmvvMVWjtnayEpdxleZ2KFgy-LN2xzsUo1LkOTNCGjdTA=="         ],         "X-Amzn-Trace-Id": [             "Root=1-664bc7cb-3d30cbea4b58d09e294f159f"         ],         "X-Forwarded-For": [             "<IP_ADDRESS>, <IP_ADDRESS>"         ],         "X-Forwarded-Port": [             "443"         ],         "X-Forwarded-Proto": [             "https"         ]     },     "queryStringParameters": {         "fit-in": "",         "height": "600",         "width": "600"     },     "multiValueQueryStringParameters": {         "fit-in": [             ""         ],         "height": [             "600"         ],         "width": [             "600"         ]     },     "pathParameters": {         "proxy": "web/images/636447403654622319.jpg"     },     "stageVariables": null,     "requestContext": {         "resourceId": "v0k6br",         "resourcePath": "/{proxy+}",         "httpMethod": "GET",         "extendedRequestId": "YFwn5F6hLPEEGkg=",         "requestTime": "20/May/2024:21:59:39 +0000",         "path": "/image/web/images/636447403654622319.jpg",         "accountId": "378659857730",         "protocol": "HTTP/1.1",         "stage": "image",         "domainPrefix": "flrin2a29i",         "requestTimeEpoch":<PHONE_NUMBER>804,         "requestId": "1ab41033-62a8-4f6b-85cc-3f226e2912ff",         "identity": {             "cognitoIdentityPoolId": null,             "accountId": null,             "cognitoIdentityId": null,             "caller": null,             "sourceIp": "<IP_ADDRESS>",             "principalOrgId": null,             "accessKey": null,             "cognitoAuthenticationType": null,             "cognitoAuthenticationProvider": null,             "userArn": null,             "userAgent": "Amazon CloudFront",             "user": null         },         "domainName": "flrin2a29i.execute-api.eu-west-2.amazonaws.com",         "deploymentId": "cdx9tt",         "apiId": "flrin2a29i"     },     "body": null,     "isBase64Encoded": false }
It seems to handle the width and height parameters but the fit-in I think it is parsed incorrectly.
Can anyone please help me here?

Hi @yahiya-ayoub,
Can you confirm that you used the template from Beomseok's comment? While we're still evaluating this change, it isn't something we've decided to add yet and wouldn't be present in the latest template. As the generated template is a beta version that we don't currently plan to implement, we may not be able to provide support for issues that arise.
Thank you,
Simon

Hey @simonkrol , thank you for replying
Yes I tried to deploy the template but I faced this issue in the cloudformation creation task
Resource handler returned message: "Your access has been denied by S3, please make sure your request credentials have permission to GetObject for solutions-features-eu-west-2/serverless-image-handler/v4.2.1-beta.2/image-handler.zip. S3 Error Code: AccessDenied. S3 Error Message: Access Denied (Service: Lambda, Status Code: 403,


Use the tool offline

Hi.
I noticed that the tool requires downloading extra files to work.
Can I somehow download them offline and make them accessible to the tool?
I want to run it in an environment without internet access.
Regards,

What I did was to copy the text from the Framework sources into a .txt file and reference that in the OPAFRAMEWORKGet function in handlepullpolicies.go
Sources can be found here:
NSA: https://dashbe.eudev3.cyberarmorsoft.com/v1/armoFrameworks?customerGUID=11111111-1111-1111-1111-111111111111&frameworkName=NSA&getRules=true
MITRE: https://dashbe.eudev3.cyberarmorsoft.com/v1/armoFrameworks?customerGUID=11111111-1111-1111-1111-111111111111&frameworkName=MITRE&getRules=true

@ohadm2 Thank you for your feedback, this feature is in our roadmap.
In the meantime, I recommend you use the workaround @sachua suggested.

That's great!
Thanks a lot for the info and the very fast feedback!
:)

@ohadm2, @sachua We finally support offline scanning
Enjoy 😅

Thanks! :)


Setup turborepo, with injected dependency syncing

Supersedes: https://github.com/CrowdStrike/ember-headless-table/pull/44
Inspired by: https://github.com/CrowdStrike/ember-headless-form/pull/52
Presently blocked on: https://github.com/pnpm/pnpm/issues/6088
Unblocking PR to pnpm: https://github.com/pnpm/pnpm/pull/6135
I'm working on that pr to add pnpm sync to the pnpm CLI. -- once merged/released, The hope is that this PR is able to go green.
Once this is proven to work, I'm going to add an ember-apply template for easily applying these changes to any pnpm monorepo (and then add documentation to the v2 addon blueprint for folks that may be interested in adding turbo -- though, there is an argument for using turbo by default, as once pnpm sync exists, we can automate away all the issues with injected dependencies transparently from users)

What's the status of this?
My understanding is that without it we are not able to make changes in the ember-headless-table package and see those changes reflected in the docs-app and test-app?
I was able to remove the "dependenciesMeta": object from docs-app/package.json and get automatic reloads there as a workaround but removing it from test-app/package.json resulted in all the tests failing because "decorator is not a function"...

What's the status of this?

this particular implementation is blocked on my own adding a feature to pnpm (pnpm sync), which requires some spelunking on my part (see linked issues).
Simon and Tony have a strategy in ember-toucan-core and ember-headless-form for fixing this problem via in an in-monorepo extra package.

FYI CrowdStrike/ember-headless-form#140 improves the DX around the extra package approach - I think the same would be interesting here on top of #168

Reminder to myself to revisit: https://twitter.com/nullvoxpopuli/status/1662431120149848064


Dart 3 incompatible

Env info

I use Dart 3 to load the pubspec packages in Flutter, but this package is incompatible with Dart V3.
Bug info

The current Dart SDK version is 3.0.2.
Because flutter_icons 1.1.0 doesn't support null safety and no versions of flutter_icons match >1.1.0 <2.0.0, flutter_icons ^1.1.0 is forbidden.

I wondering why is this not supported yet? should be straight forward?

here is update version https://github.com/flutter-studio/flutter-icons/pull/58
hope owner will merge


Adding comment insertion points

There are instances where header tags need to be placed in other locations in the header other than the bottom. This code change will make it so that you can add comments to your header to dictate where you want react-helmet to insert tags.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Michael Morelock seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@cwelch5 it looks like this PR would be an alternative option to #484, it seems like people need this feature in one way or another, could you offer some insight as to whether you like either approach and what it would take to get an update?

 All committers have signed the CLA.


[UI] User preferences dark mode toggle button text

Current Behavior

In the user preferences section, when dark mode is active text is changed to "Light Mode".

Desired Behavior

"Dark Mode" should be displayed irrespective of the current mode.

Screenshots/Logs

Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Can I work on this issue, please?


Link element  causes strange DOM duplication

I randomly stumbled across this bug and I'm now 100% sure it's a maud bug. I made a tiny example to replicate this issue.
use axum::{routing::get, Router};
use maud::{html, Markup};

#[tokio::main]
async fn main() {
    let app = Router::new().route("/", get(handler));

    let listener = tokio::net::TcpListener::bind("<IP_ADDRESS>:3009")
        .await
        .unwrap();
    println!("listening on {}", listener.local_addr().unwrap());
    axum::serve(listener, app).await.unwrap();
}

async fn handler() -> Markup {
    html! {
        a #1 {
            div #2 {
                div #3 {
                    (inner())
                }
            }
        }
    }
}

fn inner() -> Markup {
    html! {
        div #4 {
            a href="/inner" {
                div {
                    "Inner div"
                }
            }
        }
    }
}

This creates a very strange DOM tree that results in 1) the contents of div#2 and below are not wrapped inside of a#1 and 2) the element a#1 gets duplicated.
Here is the resulting HTML:

Inner div

If you replace the a#1 with div#1 then everything works as expected:

Inner div

I don't understand why the  element specifically breaks in such a spectacular way, but I hope that the code and results I supplied make debugging this easy.
Tested with both version 0.26 and from the main branch at commit 0254fe1f

I debugged a little further but the only thing I was able to find out is that this must've something to do with the axum integration.
Wrapping the result of the html! macro in the handler function in a dbg! shows the correct HTML.

Ok, after further debugging I was able to conclude that this is not a bug in maud nor the axum stack. The HTML is in fact returned properly and this can be confirmed by curl-ing the running axum server in the above example.
So this must be a bug in the browser rendering that exists specifically to torment me.
Even if you make a simple HTML document with this content it WILL break:

Inner div

This is 100% reproducible in both Firefox and Edge. And the fact that these two completely separate and different engines can reproduce the bug in the exact same way leads me to believe that either I'm doing something wrong, or something exists within the HTML spec that I'm not aware of that would cause this behavior.

Oh my god. 2 seconds after writing this I found out what the issue is: The HTML specification forbids nested  tags.
Why did no one tell me this? And how did I not find this out until now?
Anyway it's kinda funny that I was able to pinpoint the error to the HTML spec before. Oh well, the more you learn


change resolution to 1x1 instead 0x0 to avoid unity crash

Fixing issue where Unity crashes when using this plugin n newer versions of Unity

thank you!


Feature completion

Summary
This adds a FeatureCompletion model and wires it into split visibility.
Notably this doesn't actually affect production behavior, and it's missing a piece before it would be safe. We also need to wire up modifications to the weighting registry for display to the same app (basically overriding displayed weightings to 100% false for feature gates on app versions that aren't in the feature-complete set).
Will mark up below.
/domain @Betterment/test_track_core
/platform @samandmoore @smudge

Alright, so I think the README might need a bit of a terminology injection at this point, to include "feature completions" and also to make it clear how deciding a split (and setting "decided_at") compares to removing a split (which soft-deletes using "finished_at"), especially w.r.t. how mobile clients interpret all of that (since older clients can effectively circumvent both split decisions and soft deletions).
Happy to do that here, or wait until you finish wiring things up.
Also curious if you have any thoughts -- I am sort of questioning the "completion" terminology, to avoid confusion with the other two termination-sounding states/column values ("decided_at" and "finished_at"). What about "feature launch", to imply that it's the start of the feature's availability, not the end. It's silly but I legit had about 5 minutes of confusion trying to figure out the use case for telling apps when a feature split has been "completed" (i.e. finished?).

<< platform LGTM && domain TAFN

Did another pass! Thanks for talking me through to arriving at the missing hyphen in my mental model.
domain LGTM aside from the one spec case.

Note to self: there's a future feature that will add to/modify this behavior. Once we have "hard" assignments (future PR), hard assignments more recent than a relevant feature_completion will win over those feature completions.

Re-upping the LGTM on the two recent commits 👍


Tests : Wait for stderr listener to complete

@meltsufin should fix that test..

Do we understand why this is happening? What's the rationale for 1000ms wait vs. some other number?

It's because the test thread ends before the "stderr" reading thread ends. It's a race condition in the test specifically. In normal use, stderr reading would just continue until it finishes writing to some console or window.

as for 1000 vs any other number, no real reason. I think 1000 is safe for this test though.

tests were also in the wrong package, so I moved those.


Sticky menus

I could not find any previous discussion about this subject.
I would suggest making the side-menus sticky in most themes.
The side menu usually holds the TOC, and when reading something at the bottom of a very long page (example), we need to scroll all the way up to find a link in the TOC. The default RTD theme has sticky menu, and I find this very convenient.
What do you think?

I've rejected this in the past because it adds a lot of complexity to the layout code, and when I've tried to implement it it's never behaved particularly well. See pallets/flask-sphinx-themes#10 and pallets/flask-sphinx-themes#11 for a previous attempt. Press the "Home" key, or "Shift + Space", to quickly return to the top of the page.
I am not really a CSS designer, and knowing all the corner cases that can happen, I wouldn't really trust / be able to review another person's implementation to be "correct" unless I already knew they were a CSS expert.

I'm going to close this, overall I don't think it's worth the added complexity.


More examples please

Hi Nico,
Could you please add some more examples?
I have trouble figuring out where param’s come from and where they go to ....
Thanks!!!

Hi,
I don't quite understand your question. What parameters are you referring to?
I added a simple environment sensor example that might help you getting started.
Cheers, Nico

Hi Nico,
Thanks for your prompt reply!
I’m not sure myself ...
My friend recently bought a house that is totally KNX wired.
I installed KNXD on a Raspberry and that works great as a KNX to ethernet gateway. Also installed Homebridge so he can switch lights with iOS devices.
But it’s a steep learning curve understanding KNX and exploring the possibility's.

I just don’t understand how the callback function works. Is the example the same as used in the video with the intensity changing LED?
Maybe I should first use the example and see what happens...
Are you still developing the library?
Great work!
Regards,
Willem Aandewiel
The Netherlands
gsm: 0653 - 499 551
www: http://willem.aandewiel.nl/
Thank God I'm Atheist
Verstuurd vanaf mijn iPad

Op 12 nov. 2017 om 14:43 heeft Nico Weichbrodt<EMAIL_ADDRESS>het volgende geschreven:
Hi,
I don't quite understand your question. What parameters are you referring to?
I added a simple environment sensor example that might help you getting started.
Cheers, Nico
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I don't know which video you are referring to.
Basically it works like this:

You register a callback function with register_callback.
Using the integrated webserver, you assign a group address to the callback.
Everytime a knx telegram is received, we loop through all registered callbacks and check if the recevier group address matches. If yes, we call that function.

This allows you to flash the same firmware onto multiple devices and then configure them differently over wifi. No hardcoded addresses are used.
Inside the callback you get access to the payload and the method, i.e., the type of telegram (write, read, answer) and can act accordingly.

Are you still developing the library?

Yes, every now and then I update something. Currently I don't have a KNX installation therefore development is a bit stalled, however this will change at some point next year.

My mistake,
I was referring to this video “https://youtu.be/CtPy1ornSok” .. but thats an other author. I mixed things. Sorry.
But thanks for the sensor example and the explanation. I will try it out tomorrow!
Regards,
Willem

Nico,
This is a great library!!!
Still some questions ...
I have programmed two ESP's

one as a sender (sends a telegram every 10 seconds)
one as a receiver

If I configure the same callback address and the same GA address the Receiver receives (most) of the packages send from te sender.
But not all .. Is there a way to transmit an "acknowledge" telegram to the sender so that he knows the telegram was received and processed and if there is no acknowledgement he can transmit the same telegram again?
An example of how to implement that (on both sides) would be fantastic!
As a side note: I realise those questions are part due to my little understanding of KNX (but it's growing!).
Thanks in advance!

If I configure the same callback address and the same GA address the Receiver receives (most) of the packages send from te sender.

Yeah, I had similar problems if I send too many telegrams in a short timespan. Sometimes the receiver would not get them, if it's currently handling a previously received telegram. I found that disabling debug serial output helped.

But not all .. Is there a way to transmit an "acknowledge" telegram to the sender so that he knows the telegram was received and processed and if there is no acknowledgement he can transmit the same telegram again?

That is a good question. I'm not an expert so my understanding of KNX is not that good but as far as I know telegrams are not acknowledged. There is a ACK type for telegrams, but I don't know how/when to use it. From the parts of the specification I've read, it seems to not be used for normal communication. But I could be wrong.

Yeah, I had similar problems if I send too many telegrams in a short timespan. Sometimes the receiver would not get them, if it's currently handling a previously received telegram. I found that disabling debug serial output helped.

This can hardly be the case as I only send 1 telegram every 10 seconds ... Even if the debug serial output is disabled ..

Hm, then I sadly don't know what happens. Do you have a delay() in your loop() or are you doing any other things in loop()? I sadly don't know what happens inside the ESP arduino framework when a UDP packet arrives. I found that sending from an ESP works quite reliable but receiving is sometimes weird. Maybe I'm missing some config options.

Hi,
there was the request for more examples.
Here is a forum having some examples already done.
@envy
Do you think there is a change to bring them to your repository?


docker-compose up failed with linux/tipc.h: No such file or directory

Hello, team.
Overview
docker-compose up requirements failed with exit code 1
netifaces.c:131:14: fatal error: linux/tipc.h: No such file or directory
error.txt
Wordaround (If Swift doesn't use)
addons/swift/requirements.txt
diff --git a/addons/swift/requirements.txt b/addons/swift/requirements.txt
index b282ab5631..585825b527 100644
--- a/addons/swift/requirements.txt
+++ b/addons/swift/requirements.txt
@@ -1,2 +1,2 @@
-python-keystoneclient==3.13.0
+#python-keystoneclient==3.13.0
 python-swiftclient==3.4.0

Problem

docker: Docker version 25.0.4, build 1a576c5
Docker Compose version v2.29.0
RDM-osf.io: bd5b4db5a262bdde900cd4813e77a3d37d31c30a (latest develop)
Ubuntu 22.04

requirements-1  | Requirement already satisfied: certifi>=2017.4.17 in /usr/lib/python3.6/site-packages (from requests>=2.14.2->python-keystoneclient==3.13.0->-r /code/addons/swift/requirements.txt (line 1)) (2020.12.5)
requirements-1  | Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3.6/site-packages (from requests>=2.14.2->python-keystoneclient==3.13.0->-r /code/addons/swift/requirements.txt (line 1)) (3.6)
requirements-1  | Using legacy 'setup.py install' for netifaces, since package 'wheel' is not installed.
requirements-1  | Using legacy 'setup.py install' for positional, since package 'wheel' is not installed.
requirements-1  | Installing collected packages: netifaces, netaddr, iso8601, debtcollector, stevedore, rfc3986, oslo.utils, os-service-types, msgpack, positional, oslo.serialization, oslo.config, keystoneauth1, python-swiftclient, python-keystoneclient
requirements-1  |     Running setup.py install for netifaces: started
requirements-1  |     Running setup.py install for netifaces: finished with status 'error'
requirements-1  |     ERROR: Command errored out with exit status 1:
requirements-1  |      command: /usr/bin/python3.6 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d_7us1js/netifaces_b7a96080fbc946c287b01df91362921d/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d_7us1js/netifaces_b7a96080fbc946c287b01df91362921d/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-rrxu5une/install-record.txt --single-version-externally-managed --compile --install-headers /usr/include/python3.6m/netifaces
requirements-1  |          cwd: /tmp/pip-install-d_7us1js/netifaces_b7a96080fbc946c287b01df91362921d/
requirements-1  |     Complete output (19 lines):
requirements-1  |     running install
requirements-1  |     running build
requirements-1  |     running build_ext
requirements-1  |     checking for getifaddrs...found.
requirements-1  |     checking for getnameinfo...found.
requirements-1  |     checking for IPv6 socket IOCTLs...not found.
requirements-1  |     checking for optional header files...netpacket/packet.h.
requirements-1  |     checking whether struct sockaddr has a length field...no.
requirements-1  |     checking which sockaddr_xxx structs are defined...in in6 un ll.
requirements-1  |     checking for routing socket support...no.
requirements-1  |     checking for sysctl(CTL_NET...) support...no.
requirements-1  |     checking for netlink support...no.
requirements-1  |     building 'netifaces' extension
requirements-1  |     gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Os -fomit-frame-pointer -g -Os -fomit-frame-pointer -g -Os -fomit-frame-pointer -g -DTHREAD_STACK_SIZE=0x100000 -fPIC -DNETIFACES_VERSION=0.11.0 -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETPACKET_PACKET_H=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_LL=1 -I/usr/include/python3.6m -c netifaces.c -o build/temp.linux-x86_64-3.6/netifaces.o
requirements-1  |     netifaces.c:131:14: fatal error: linux/tipc.h: No such file or directory
requirements-1  |      #    include <linux/tipc.h>
requirements-1  |                   ^~~~~~~~~~~~~~
requirements-1  |     compilation terminated.
requirements-1  |     error: command 'gcc' failed with exit status 1
requirements-1  |     ----------------------------------------
requirements-1  | ERROR: Command errored out with exit status 1: /usr/bin/python3.6 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d_7us1js/netifaces_b7a96080fbc946c287b01df91362921d/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d_7us1js/netifaces_b7a96080fbc946c287b01df91362921d/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-rrxu5une/install-record.txt --single-version-externally-managed --compile --install-headers /usr/include/python3.6m/netifaces Check the logs for full command output.
requirements-1  | WARNING: You are using pip version 21.0; however, version 21.3.1 is available.
requirements-1  | You should consider upgrading via the '/usr/bin/python3.6 -m pip install --upgrade pip' command.
requirements-1 exited with code 1

Use a self-build RDM-osf.io image instead of the original osf.io.


Updated deprecated jax.tree_map to jax.tree_util.tree_map

I recently started getting FutureWarning: jax.tree_leaves is deprecated,  and will be removed in a future release. Use jax.tree_util.tree_leaves instead..  Hence, I refactored the code to reflect this JAX update.

Hi @YigitDemirag, thanks for the PR and thanks for using brax! We just pushed out a fix for https://github.com/google/brax/issues/213 which had an internal update to use jax.tree_util.tree_leaves. Sorry for not syncing this change earlier!
Please let us know if there are any issues and please don't hesitate to contribute in the future!


running semantic-nerfw on custom data

Has anyone been able to generate the same data format required for semantic-nerfw from their own dataset ?

Has anyone been able to generate the same data format required for semantic-nerfw from their own dataset ?

I want to know how to generate cameras.json?

If you are interested in creating something with cameras.json format, you can reference this code and [this notebook](this notebook).
We recommend using nerfstudio if you want to do anything custom with semantics. You can copy the nerfstudio dataparser and then modify it to add semantics, like we do here.

I have the same question. Also the result of running semantic-nerfw on friends dataset using default settings doesn't look good.

I don't expect the results to look good until transient embeddings from NeRF-W are implemented. If you are interested in working on this and making a PR, you could reference nerf_pl.


memfd: keep file descriptor open during allocation lifetime

Otherwise checkpoint/restore cannot work without CAP_SYS_ADMIN,
since closed memfd's cannot be migrated by unprivileged users.
While at it, close the file when before returning from a
ftruncate/mmap failure.

Thank you for the nice patch. I've merged it into dev.

I've merged your patch at https://github.com/herumi/xbyak/commit/2a265d9d9f713fb4bdbaf33b050a32415537bfb5 , so I'll close this pull request.


Change Indentation Size is not enabled in the current context.

The Change Indentation Size command is disabled from the Command Palette after first change.

Open VS Code.
Open a file with indentation (spaces).
F1 | Change Indentation Spaces
Select Tab Width (say 6)
Try again: F1 | Change Indentation Spaces
Get Info message that Command Change Indentation Size is not enabled in the current context.
Try close, reopening the current file, opening another file, the command still can't be enabled.
Change Indentation Size is available if you launch the command from the Spaces/Tabs: on the Status Bar.

The Change Indentation Size command is removed with the March build.


Installation problem with watchdog module

Hi
I encountered the error below when I execute make.  My environment are:

dockerized centos 8
httpd 2.4.41
mod 2.2.0
apr 1.7.0
apr-util 1.6.1

[root@1d4cd16adc55 mod_md-2.2.0]# make
Making all in src
make[1]: Entering directory '/root/mod_md-2.2.0/src'
  CC       mod_md_la-mod_md_drive.lo
mod_md_drive.c: In function 'run_watchdog':
mod_md_drive.c:155:14: error: 'result' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         rv = md_job_save(job, result, ptemp);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mod_md_drive.c:74:18: note: 'result' was declared here
     md_result_t *result;
                  ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:901: mod_md_la-mod_md_drive.lo] Error 1
make[1]: Leaving directory '/root/mod_md-2.2.0/src'
make: *** [Makefile:497: all-recursive] Error 1

httpd status is ok.
Any idea what I may be doing wrong?
SO

If compilers could only agree on what to warn about and what not! ;-)
The analysis is half-correct. result may be uninitialized, but then also job->dirty is never true. But I just added explicit initialization there, does not hurt.
Thanks!

Fixed in v2.2.2.


[VEG-2314] Improve error handling and fix scaffolding bug

Description
This PR fixes the bug described in this slack thread.

52fdb09 Lock adm-zip due to regression
1b581b7 Improve error handling

Detail

Checklist

[ ] :guardsman: includes new unit and functional tests

@Shengming-Yan Yes it does


Add notify-errbot rule to ChatOps pack.

Add notify-errbot rule to chatops pack to simplify installation for err-stackstorm users. (transpartent for non err-stackstorm users).
Updated readme using pack2md as well as fix file permissions and the metadata for route field definition.

Anything else to get this merged to master?

@nzlosh can you force push to this branch to kick off e2e tests again please?

Looks like the e2e tests are failing for real in this PR.
st2 e2e tests failure:
ok 1 StackStorm's client connection
ok 2 npm directory exists
ok 3 some StackStorm aliases are enabled
not ok 4 chatops.notify rule exists
# (from function `assert_output' in file chatops/../test_helpers/bats-assert/src/assert.bash, line 239,
#  in test file chatops/test_hubot.bats, line 36)
#   `assert_output \"chatops.notify\"' failed
#
# -- output differs --
# expected (1 lines):
#   chatops.notify
# actual (2 lines):
#   chatops.notify
#   chatops.notify-errbot
# --
#
ok 5 hubot help command works
ok 6 chatops.post_message execution and receive status works
ok 7 complete request-response flow"

Here is the actual test case: https://github.com/StackStorm/st2tests/blob/6f384e7a03ac55d6b57d3036812b2fd01660ac3e/chatops/test_hubot.bats#L31-L42
@nzlosh Looks like more work needs to be done in st2tests repository as well. Can you provide a PR there?

I've updated the st2test repo to test for the presence of the notify-errbot rule in the chatops pack.

The contrib/chatops/rules/notify_hubot.yaml file was chmodded: 100755 → 100644 - was this intentional or can we undo that?

Tests should be partially fixed when we merge in StackStorm/st2tests#194.
Once that is merged and these tests are passing, we can merge this in.
Once this is merged in, we can merge in StackStorm/st2tests#195 to check for the additional chatops notification channel rule.

Hm, after re-running e2e tests after https://github.com/StackStorm/st2tests/pull/194 they still fail with the same error:
ok 1 StackStorm's client connection
ok 2 npm directory exists
ok 3 some StackStorm aliases are enabled
not ok 4 chatops.notify rule exists
# (from function `assert_output' in file chatops/../test_helpers/bats-assert/src/assert.bash, line 239,
#  in test file chatops/test_hubot.bats, line 41)
#   `assert_output \"true\"' failed
#
# -- output differs --
# expected (1 lines):
#   true
# actual (2 lines):
#   true
#   true
# --
#
ok 5 hubot help command works
ok 6 chatops.post_message execution and receive status works
ok 7 complete request-response flow"

From what I understand the tests for this PR are cloned from the master branch of https://github.com/StackStorm/st2tests/
@blag any ideas?

@blag contrib/chatops/rules/notify_hubot.yaml file was chmodded: 100755 → 100644, yes that was intentional on my part, yaml is not an executable file, so I corrected it.

EL7 end-to-end tests are now failing due to Python 2/3 issues:
not ok 36 packs.setup_virtualenv with python3 flag works
# (in test file cli/test_pack_python3.bats, line 88)
#   `RESULT=$(st2 run examples.python_runner_print_python_version -j)' failed
not ok 37 python3 imports work correctly
# (from function `assert_success' in file cli/../test_helpers/bats-assert/src/assert.bash, line 114,
#  in test file cli/test_pack_python3.bats, line 117)
#   `assert_success' failed
#
# -- command failed --
# status : 1
# output (19 lines):
#
#   {
#       \"action\": {
#           \"ref\": \"python3_test.test_stdlib_import\"
#       },
#       \"context\": {
#           \"user\": \"st2admin\"
#       },
#       \"end_timestamp\": \"2020-11-18T04:43:06.745006Z\",
#       \"id\": \"5fb4a65a4c2a7dcce5963bfe\",
#       \"result\": {
#           \"exit_code\": 1,
#           \"result\": \"None\",
#           \"stderr\": \"Traceback (most recent call last):\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/netaddr/compat.py\\\", line 91, in <module>\
    from importlib import resources as _importlib_resources\
ImportError: cannot import name 'resources'\
\
During handling of the above exception, another exception occurred:\
\
Traceback (most recent call last):\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/python_runner/python_action_wrapper.py\\\", line 53, in <module>\
    from st2common import log as logging\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/log.py\\\", line 32, in <module>\
    from st2common.logging.handlers import FormatNamedFileHandler\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/logging/handlers.py\\\", line 22, in <module>\
    from oslo_config import cfg\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/oslo_config/cfg.py\\\", line 336, in <module>\
    from oslo_config import types\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/oslo_config/types.py\\\", line 21, in <module>\
    import netaddr\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/netaddr/__init__.py\\\", line 18, in <module>\
    from netaddr.core import (AddrConversionError, AddrFormatError,\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/netaddr/core.py\\\", line 11, in <module>\
    from netaddr.compat import _callable, _iter_dict_keys\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/netaddr/compat.py\\\", line 93, in <module>\
    import importlib_resources as _importlib_resources\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/importlib_resources/__init__.py\\\", line 5, in <module>\
    from ._common import (\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/importlib_resources/_common.py\\\", line 9, in <module>\
    from ._compat import (\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/importlib_resources/_compat.py\\\", line 52, in <module>\
    from typing import runtime_checkable  # type: ignore\
  File \\\"/opt/stackstorm/st2/lib/python2.7/site-packages/typing.py\\\", line 782, in <module>\
    AnyStr = TypeVar('AnyStr', bytes, unicode)\
NameError: name 'unicode' is not defined\
\",
#           \"stdout\": \"\"
#       },
#       \"start_timestamp\": \"2020-11-18T04:43:06.273452Z\",
#       \"status\": \"failed\"
#   }
# --
#

I think the e2e tests should be fixed at this point.
@nzlosh please update the Changelog to fix the git conflict. That'll re-trigger the CI as well.


Don't cache metadata

Attempted fix/debug for CI failures

@isidentical - given that the metadata cache is completely independent of the general file info cache, I think we should not store both, and eat the cost of repeated lookups during set/getxattr.

Agreed. I don't think set/getxattr/metadata is that common anyway, so it should be fine.


Custom directories separator

Fixes the issue for directories separator which are not correct when the remote server and the local machine have a different OS (/ for Linux and \ for Windows).
The optional new option "dirSeparator" is created (default to "/").

Hi, I made some changes following your comment. I created a posix-path module which contains functions from the path module of Node for posix systems.
Could you review them ?

Hi, I made some changes creating a custom module "posix-path" which uses Node.js path module functions for posix platforms. Could you review it ?

I closed it in favor of https://github.com/neoziro/grunt-shipit/pull/38


Fix TypeError: object of type 'ShuffleDataset' has no len()

This simple pull request stems from a small type bug encountered during my learning at https://learn.microsoft.com/.
I take this opportunity to thank MS and its team for the nice material.
I have no previous experience of contributing to open source projects, I'm trying to be compliant with the code of conduct.
On the sandboxes kindly granted by Microsoft, the current version of tensorflow is 2.2, which is why I chose to use the https://www.tensorflow.org/versions/r2.2/api_docs/python/tf/data/experimental/cardinality method.
In later versions it has been integrated into the parent class tf.data.Dataset

@microsoft-github-policy-service agree

Any luck of getting this an approval? @shwars

Any luck of getting this an approval? @shwars

I am no longer with Microsoft, so bringing this to the attention of @bstollnitz

Hi, and thanks for reporting this issue and providing a fix! This has been fixed a while ago, before I was made aware of your fix. Let me know if the new code that is publicly available doesn't work for you. Once again, thank you so much!

Hi @bstollnitz, what do you mean by "publicly available"? The one hosted on MS?
Anyway I'll be happy to close the PR if merge is not allowed  :)


APEXCORE-397 Allow configurability of stram web services authentication

@davidyan74 please review

I'm good with the changes. Please squash the commits when ready to be merged.


kubernikusctl in headless mode

Currently it's not possible to run kubernikusctl from within a simple ubuntu image:
$ kubernikusctl auth refresh
An error occurred: exec: "dbus-launch": executable file not found in $PATH

This is a regression introduced by https://github.com/sapcc/kubernikus/pull/270

Can you confirm if
https://github.com/sapcc/kubernikus/releases/tag/v1.0.0%2B4cc8106fb5bd8859546762ba6a4bdee1d7c6597e fixes this?
It contains this change: https://github.com/sapcc/kubernikus/commit/0c614c6d34907b72ccb27fa6cd00e13741fce8cd

Hi, please ping me tomorrow, we can share a screen to resolve it

Yes, I can confirm that it is working with the mentioned version


Learner needs to respond vote requests.

So that if some voters fail, rest voters and learners can still form a quorum. Fix #57 .

@BusyJay @Hoverbear @overvenus PTAL thanks.

@hicqu I see that in https://github.com/pingcap/raft-rs/issues/57#issue-321442130 a candidate check was written about. In this PR I don't see an added candidate check. Was this already implemented, or found to be unnecessary?

@Hoverbear I  omitted the check, because voters only send MsgRequetsVote to known voters. So if a voter receive a MsgRequestVoteResponse, it must come from a peer in the voter's voter_prs, not learner_prs.

LGTM


Add keyboard shortcut for looking up symbol under cursor

This uses the existing functionality for looking up a symbol (go to
definition), which is currently only available with cmd/ctrl+click
on the symbol name in the script editor. This commit just makes
that functionality available with a keyboard shortcut as well.
 I'll be testing on my Windows machine soon. I did test a similar change on the 3.x branch and will be opening a PR for that too (it's not a simple cherry pick because of some renames on the functions it calls).

PR for 3.x version of this: https://github.com/godotengine/godot/pull/60157

Looks good! Could you squash the commits? See PR workflow for instructions.

Sorry, this isn’t actually ready yet. I haven’t worked on it for a while, but when I tested it, it didn’t work. There’s some bug I need to work out.


Text encoder

Very happy to see such an interesting work, I would like to ask if the trained clip's text encoder's will be stronger in encoding the text details in its text, such as orientation, color structure, etc.

Thanks for your interest! We have not yet explored whether the tuned CLIP's text encoder captures textual details more effectively, but since DIVA is purely image-driven, we speculate that the tuned CLIP's text encoder has not substantially enhanced its ability to capture textual details. This work is just the beginning in this direction, and we look forward to more scholars engaging in research in this field!

Thanks
---Original---
From: @.>
Date: Tue, Aug 6, 2024 13:41 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [baaivision/DIVA] Text encoder (Issue #2)
Thanks for your interest! We have not yet explored whether the tuned CLIP's text encoder captures textual details more effectively, but since DIVA is purely image-driven, we speculate that the tuned CLIP's text encoder has not substantially enhanced its ability to capture textual details. This work is just the beginning in this direction, and we look forward to more scholars engaging in research in this field!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

In fact, interestingly, while we anticipated upgrading DIVA, we discovered that despite ensuring the CLIP text encoder's weights were unfrozen during generative tuning, the CLIP text encoder did not require updating in our approach. Consequently, to ensure rigor, we refined the corresponding illustrations in our paper.


Fill in proposal : truly cross platform setup

I want to make a blog post about this at some point. I do not have a lot
of time to make it a priority I can give a deadline to. But if we are
missing articles for the advent I'll push this up my list and post it
there instead of my blog.

By the way @romainl there is no license on your gist that I cite in my code snippet ( and I will definitely leave the citation in the final article if possible) ; is that an issue license wise ?

By the way @romainl there is no license on your gist that I cite in my code snippet ( and I will definitely leave the citation in the final article if possible) ; is that an issue license wise ?

I've added a MIT license header just in case, but from the light reading I just made, it's validity in the context of a gist is not a sure thing.

OK, this needs to be fleshed out a bit but that's a pretty interesting topic and a good start.


Always On Top activates for current window during update

Microsoft PowerToys version
0.60.1
Running as admin

[X] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
Update PowerToys with AlwaysOnTop enabled
✔ Expected Behavior
Always on top should not activate for current foreground window
❌ Actual Behavior
Always on top activates automatically for whatever the current foreground window is (in my case Edge).
Disabling AOT does not disable the feature, so I have to keep it enabled, and manually toggle via the keyboard shortcut.
Other Software
Windows 11
Microsoft Edge

Just experienced this bug when updating from 0.60.0 to 0.60.1 on Windows 10. Also had this happen the last time I updated PowerToys.

I also had it the previous upgrade, but I didn't know what it was at the time. I thought it was a display driver issue, so I closed and reopened Edge to correct it then.
It was only this time I poke around PowerToys to figure out what it was.

@jaimecbernardo this is an annoying bug that I am alble to repro only on a computer (Windows 11).
I think this is related to the shortcut that is now using LLKH, but this is really strange.
Possible repro is:

Install 0.60.0
Update to 0.60.1 from settings
Wait for the update to finish
Close OOBE
Open settings from the system tray
Focus another window
The window is pinned by AOT
PT disappear from system tray
Only PowerToys.AlwaysOnTop.exe process still running

Runner is crashing but no errors in logs or event viewer and not able to generate a dump.


Clear interaction status even if there is no ongoing request

It appears application can get in a state where msal.interaction.status temporary cache value is present, but msal does not have an ongoing request. In this scenario, cleanRequestByInteractionType does not result in clearing interaction status. This ensures we always clear interaction status regardless.

Codecov Report

Merging #4314 (e3c6610) into dev (f36953b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.39% <ø> (ø)

msal-browser
87.71% <100.00%> (+0.12%)
:arrow_up:

msal-common
85.42% <ø> (ø)

Carriedforward from 24c1366

msal-core
77.07% <ø> (ø)

Carriedforward from 24c1366

msal-node
81.93% <ø> (ø)

Carriedforward from 24c1366

msal-react
94.27% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-browser/src/cache/BrowserCacheManager.ts
94.76% <100.00%> (+0.72%)
:arrow_up:


Figure out a way to hide TOC for coursera - maybe a version of the url?

This would be better so that students don't get lost on coursera and to show the course with full width.

Wow. We opened a zillion issues about this. Lol This is resolved! #177

Wow. We opened a zillion issues about this. Lol This is resolved! #177

lol


upgrade @expo/* deps

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
<EMAIL_ADDRESS>included a change that resulted in us detecting the presence of the push notifications entitlement differently in EAS CLI than when running the build. This problem arises from the fact that we depend on code in @expo/prebuild-config to detect this, and the version of that library can be different between the worker and developer's computer (because EAS CLI and Expo CLI can depend on different versions). The reason behind the push notifications entitlement change was to move away from this problem and delegate the logic instead of the expo-notifications package; however, we have to roll this out more carefully in the future by releasing EAS CLI, Expo CLI, and EAS Build with the updated Expo CLI version.
How
Republished @expo/prebuild-config and related packages with the entitlement change reverted, for now.
Test Plan
eas build will always enable push notification capability if it's not enabled on the identifier.

/changelog-entry bug-fix Fix push notifications entitlements


eswifi gets a deadlock on b_l4s5i_iot01a target

Describe the bug
samples/net/wifi dosen't work on b_l4s5i_iot01a target.
the program hangs after wifi related command, like wifi scan and wifi connect.
To Reproduce
Steps to reproduce the behavior:

cp -r samples/net/wifi ~/my-wifi-test && cd ~/my-wifi-test
west build -b b_l4s5i_iot01a
west flash
shell is hung after wifi scan command

[00:00:00.000,000] <dbg> wifi_eswifi.eswifi_init:
[00:00:00.000,000] <dbg> wifi_eswifi.eswifi_spi_init: success
[00:00:00.000,000] <dbg> net_core.net_init: (main): Priority 90
[00:00:00.000,000] <dbg> net_core.l3_init: (main): Network L3 init done
[00:00:00.000,000] <dbg> net_if.net_if_init: (main):
[00:00:00.000,000] <dbg> net_if.init_iface: (main): On iface 0x2000058c
[00:00:00.000,000] <dbg> wifi_eswifi.eswifi_iface_init:
[00:00:00.510,000] <dbg> wifi_eswifi.eswifi_spi_request: cmd=(nil) (0 byte), rsp=0x20000965 (1600 byte)
[00:00:01.000,000] <dbg> wifi_eswifi.eswifi_spi_read_msg:
uart:~$ wifi scan

using west debug, the code calls k_mutex_lock(&eswifi->mutex, K_FOREVER) at eswifi_lock waiting for an unlock in eswifi_mgmt_scan function.

if (atomic_get(&eswifi->mutex_owner) != (atomic_t)(uintptr_t)_current) {
		k_mutex_lock(&eswifi->mutex, K_FOREVER);
		atomic_set(&eswifi->mutex_owner, (atomic_t)(uintptr_t)_current);
		eswifi->mutex_depth = 1;
} else {

Expected behavior
The output should be the same as the example document.
shell> wifi scan
Scan requested
shell>
Num  | SSID                             (len) | Chan | RSSI | Sec
1    | kapoueh!                         8     | 1    | -93  | WPA/WPA2
2    | mooooooh                         8     | 6    | -89  | WPA/WPA2
3    | Ap-foo blob..                    13    | 11   | -73  | WPA/WPA2
4    | gksu                             4     | 1    | -26  | WPA/WPA2
----------
Scan request done

Impact
The WiFi connection doesn't work.
Logs and console output
see the step 4 in reproduce section.
Environment (please complete the following information):

OS: Ubuntu 20.04
Toolchain: zephyr-sdk-0.12.3
Zephyr version: v2.6.0 and main(d7368995048990744c6583f28a6f31078d225e94)

Additional context
A deadlock happens when calling wifi scan from the shell because of eswifi_iface_init doesn't release the mutex.
eswifi_iface_init locks the mutex waiting for initialization steps but eswifi_reset never returned.
eswifi_spi_request which is called by eswifi_reset keeps waiting for eswifi_spi_cmddata_ready.
Run till exit from #0  eswifi_spi_request (eswifi=0x200007f0 <eswifi0>, cmd=<optimized out>, clen=<optimized out>, rsp=0x20000965 <eswifi0+373> "", rlen=1600)
at zephyr/drivers/wifi/eswifi/eswifi_bus_spi.c:158

@loicpoulain Would you have time to have a look ?

@nandojve Would you have time to have a look ?

A deadlock happens when calling wifi scan from the shell because

Doesn't it timeout after a certain time?
Look like the 'data ready' pin is probably not correctly configured on that board, driver is waiting for that pin to be high.

A deadlock happens when calling wifi scan from the shell because

Doesn't it timeout after a certain time?
Look like the 'data ready' pin is probably not correctly configured on that board, driver is waiting for that pin to be high.

how long is the timeout? I waited for at least 2 minutes.
where I can change it?

It is normally about 1min: eswifi_spi_wait_cmddata_ready
But because we do a lot of short ksleep I would not be surprised it take much more time.
Anyway, even if you fix the timeout that will not solve the root cause, that the driver-data pin value is not correct, but that would be good to identify which call to eswifi_spi_wait_cmddata_ready is failing.

the timeout didn't fail but the code stuck in the while loop which it's no timeout.
https://github.com/zephyrproject-rtos/zephyr/blob/79a6c07536bc14583198f8e3555df6134d8822cf/drivers/wifi/eswifi/eswifi_bus_spi.c#L166-L170
the device tree looks right, not sure if I miss something?
https://github.com/zephyrproject-rtos/zephyr/blob/79a6c07536bc14583198f8e3555df6134d8822cf/boards/arm/b_l4s5i_iot01a/b_l4s5i_iot01a.dts#L146-L155

<&gpioe 0 GPIO_ACTIVE_HIGH>;

I think this is wrong, chip-select is usually active-low, try to set GPIO_ACTIVE_LOW instead.

<&gpioe 0 GPIO_ACTIVE_HIGH>;

I think this is wrong, chip-select is usually active-low, try to set GPIO_ACTIVE_LOW instead.

setting data-gpios to GPIO_ACTIVE_LOW, I got DATA ready timeout from eswifi_spi_wait_cmddata_ready.
[00:01:06.510,000] <err> wifi_eswifi: DATA ready timeout
[00:01:06.510,000] <err> wifi_eswifi: Unable to reset device
[00:01:06.510,000] <dbg> net_if.net_if_post_init: (main):
[00:01:06.510,000] <dbg> net_if.net_if_up: (main): iface 0x2000058c

according to GPIO API is should set to GPIO_ACTIVE_HIGH, but it depends on SPI driver design, I think.

oh, I got it. I changed chip-select pin to GPIO_ACTIVE_LOW, it seems to work. let me do more tests.
https://github.com/zephyrproject-rtos/zephyr/blob/79a6c07536bc14583198f8e3555df6134d8822cf/boards/arm/b_l4s5i_iot01a/b_l4s5i_iot01a.dts#L134-L135

@oopsmonk, good, could you submit the fix if you confirm it works. CS is active low for eswifi chips.

Thanks @loicpoulain for the great support!


Add documentation & examples

Documentation must be added to the classes.
References for the datasets must be included in the class definitions.
Existing examples must be updated and new ones should be added.

Hi,
Thank you for the project❤ I am the developer of WhisperPlus library. I want to add the Turno language model to the WhisperPlus library. When will you add inference codes?
WhisperPlus: https://github.com/kadirnar/whisper-plus

Dear Kadir,
Thank you for your interest in our model! The feature has been implemented and is currently under review. It will be merged soon. Please stay tuned!

Dear Kadir,
The PR has now merged. Please check out the inference notebook for reference. Let me know if you have any questions or need our support for integration.

Dear Kadir,
The PR has now merged. Please check out the inference notebook for reference. Let me know if you have any questions or need our support for integration.

Thank you for the fast development process 🚀 I will test the notebook file 🧪


Bug 2089827: use the metallb path for fetching the backward compatible tests patch

/retest

/retest

LGTM

/lgtm

Both lanes are failing on Should produce an error when deleting a profile used by a BGPPeer which is because the operator is not shipping the bfdprofile webhook (yet).
It's being added by https://github.com/openshift/metallb-operator/pull/87 which is failing because of the changes we are putting in this PR (specifically, fixing the patch of backward compatible tests)

/lgtm

/override ci/prow/metallb-e2e-metal-ipi

/override ci/prow/metallb-e2e-metal-ipi-ovn


Clear out expired routes

We should do something about items in iface::routes::Routes that are expired, or no longer "preferred".

This issue should be closed as the PR was merged in commit https://github.com/smoltcp-rs/smoltcp/commit/06d18130cd8b25edbcad207bbdbb157f1c1203df

I'm not sure? the current code will ignore expired routes, but it won't actually remove them from the route table.

Ahh yes, I saw the PR and didn't bother to check it thoroughly.


Change UI to use Capital Letters only for first letter (avoid to capitalize all) and Increase space above Save/Transfer button

Please change the UI to use Capital Letters only for first letter (avoid to capitalize all).

Increase space above Save/Transfer button in all views. It is currently very close to the above area.

Got it Sir

@yashk2000 Can you Please solve this issue

@adityastic sure.

Reopening this issue as it is only partly fixed. Many areas in this app and buttons still have capitals only.

They are in the saved section mostly. I'll fix it right now.

@mariobehling It's standard in Android to have button text in caps by default.


Getting Doubled Input In Windows

System Configuration:
Edition	Windows 11 Home
Version	23H2
Installed on	9/28/2022
OS build	22631.3880
Experience	Windows Feature Experience Pack 1000.22700.1020.0
Using EndBASIC 0.11.0, downloaded fresh from the website.
(I have used both cmd and ps, and I get the same result, and tried two different machines and got the same result)
Repro Steps:

Launch endbasic.exe from command line
Type something, for example edit

Expected:
I'm in the editor
Actual:
console shows:
eeddiitt
(or whatever i typed, but each character is doubled)
Note:
I did this on my twitch stream. I will amend this issue with a link to the VOD.
I sorta looked for a duplicate issue, but not very well. Apologize if dupe.

Further note: using the --console=graphics flag will not get this behavior.

Interesting. I had seen this bug report earlier, but when I tried to reproduce it, I couldn't because I assumed it only happened with the graphics console. So thanks for the clarification that --console=graphics makes it go away. I can see the problem now, but I do not know yet why it's happening.

Alright, sorry for the delay. I finally had a chance to look into it and the fix is trivial. It should be fixed on master in a moment and I'll try to push a dot release out this weekend.


Slightly flaky test DatagramChannelTests.testEcnSendReceiveIPV4

Discovered via internal tools
Test Suite 'Selected tests' started at 2022-05-13 16:28:40.627
Test Suite 'DatagramChannelTests' started at 2022-05-13 16:28:40.629
Test Case 'DatagramChannelTests.testEcnSendReceiveIPV4' started at 2022-05-13 16:28:40.629
/workspace/.logs/FA64A58E-D8A3-40BE-A7B9-8C06931AD7D6/repos/swift-nio/Tests/NIOPosixTests/DatagramChannelTests.swift:723: error: DatagramChannelTests.testEcnSendReceiveIPV4 : XCTAssertEqual failed: ("Optional(NIOCore.NIOExplicitCongestionNotificationState.congestionExperienced)") is not equal to ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportNotCapable)") -
/workspace/.logs/FA64A58E-D8A3-40BE-A7B9-8C06931AD7D6/repos/swift-nio/Tests/NIOPosixTests/DatagramChannelTests.swift:723: error: DatagramChannelTests.testEcnSendReceiveIPV4 : XCTAssertEqual failed: ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportCapableFlag0)") is not equal to ("Optional(NIOCore.NIOExplicitCongestionNotificationState.congestionExperienced)") -
/workspace/.logs/FA64A58E-D8A3-40BE-A7B9-8C06931AD7D6/repos/swift-nio/Tests/NIOPosixTests/DatagramChannelTests.swift:723: error: DatagramChannelTests.testEcnSendReceiveIPV4 : XCTAssertEqual failed: ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportCapableFlag1)") is not equal to ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportCapableFlag0)") -
/workspace/.logs/FA64A58E-D8A3-40BE-A7B9-8C06931AD7D6/repos/swift-nio/Tests/NIOPosixTests/DatagramChannelTests.swift:723: error: DatagramChannelTests.testEcnSendReceiveIPV4 : XCTAssertEqual failed: ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportNotCapable)") is not equal to ("Optional(NIOCore.NIOExplicitCongestionNotificationState.transportCapableFlag1)") -
Test Case 'DatagramChannelTests.testEcnSendReceiveIPV4' failed (0.009 seconds)
Test Suite 'DatagramChannelTests' failed at 2022-05-13 16:28:40.638
	 Executed 1 test, with 4 failures (0 unexpected) in 0.009 (0.009) seconds
Test Suite 'Selected tests' failed at 2022-05-13 16:28:40.638
	 Executed 1 test, with 4 failures (0 unexpected) in 0.009 (0.009) seconds
Command failed reason=exit, status=1

The ECN errors are simply relying on an incorrect assumption that datagrams sent on localhost will be received in-order on the other side.


Update to v3

Hi,
Thanks for the great plugin. Do you have any plans to migrate this to V3 or create a V3 version?
If not I will try and have a go myself when I have some free time 👍
Cheers

Hi,
Thanks for the great plugin. Do you have any plans to migrate this to V3 or create a V3 version?
If not I will try and have a go myself when I have some free time 👍
Cheers

Did you find some free time?

This now works with V3


Google gives oggm-edu link that does not work

Hi,
when "googling" mass balance gradient glaciers, the second entry (for me) is from OGGM-edu :-) . However it is a broken link  (https://edu.oggm.org/en/latest/notebooks/mass_balance_gradient.html). I think it links to the old webpage and does not work anymore. Maybe we can link the old links to the new webpage? By the way, the fourth entry in google links to the correct new webpage, (https://oggm.org/oggm-edu-notebooks/oggm-edu/mass_balance_gradients.html).

Thanks @lilianschuster good catch - I'd like to avoid making the effort of adding internal links, but we should be able to ask google to re-crawl our web. I don't have the means to verify edu.oggm.org, could you be of any help here @TimoRoth ?


Migration - the quote on Successful project generated a few weird characters + ignore the quote images

Please investigate why this quote is showing these markup characters:

--
PS. We should ignore the images used for quotes (this can easily be done via CSS). I've already fixed in SharePoint

I have removed the old quotes from all 4 pages we have found with it. It should not be a problem anymore. Closing the issue


Cannot import 'TemporaryDirectory'

I am currently trying to migrate from nanopb 0.4.5 to 0.4.7 and running into the following issue:
Traceback (most recent call last):
  File "...nanopb_generator.py", line 55, in <module>
    from proto import TemporaryDirectory
ImportError: cannot import name 'TemporaryDirectory' from 'proto' (unknown location)

For context, the way I am using nanopb is through a Conan package, and I am calling the generator directly with python (python nanopb_generator.py). The problem seems to be that the TemporaryDirectory import moved to __init__.py, which is not installed in CMakeLists.txt (the package install only has the following in the proto folder):
nanopb
└── lib
    └── site-packages
        └── proto
            ├── nanopb_pb2.py
            ├── nanopb.proto
            └── _utils.py

If I copy __init.py__ here then the generator runs without issue. I can work around this but would it make sense for this file be installed alongside _utils.py in CMakeLists.txt?

This fixes my issue, thanks! And yes seems like a workflow according to the README might make sense as well.

The main issue should be fixed in 0.4.8. I added separate issue #922 about adding a continuous integration test for the Conan build.