OpenAL integration

Continuation of #217 with git fixed

I see we will have to chose one of the three configurations:

Use OpenAL as shared library (even if rest of build is static) (open source, closed source on desktop)
Use OpenAL as static library (open source projects only)
Use MojoAL (all projects)

Im thinking to add URHO3D_SOUND_BACKEND with three possible values: OpenAL_shared, OpenAL_static, MojoAL. Default value would be MojoAL.
Anyone have any suggestions regarding this?
cc @eugeneko @ArnisLielturks

Is the target platform easy to detect? That way we could use MojoAL by default for Android and the web target (I believe iOS implements OpenAL as a system library, but I'm not certain) and dynamic linked openal-soft for every other target.

Rebase your branch on to https://github.com/rokups/rbfx/tree/rk/openal, OpenAL/MojoAL already linked into Urho3D target.

A little update. We decided against including entire OpenAL in ThirdParty dir and left only MojoAL. What does that mean:

Engine remains 100% free of any restrictions by default
To use official OpenAL user must explicitly opt in by passing -DURHO3D_USE_OPENAL=ON cmake parameter
Build system finds OpenAL version present in the system. Windows users may use official SDK installer and it should be picked up.
In order to use a custom OpenAL build (for example a static one) user should specify OPENALDIR env variable which points to OpenAL SDK dir.
You should not include any OpenAL/MojoAL headers in public engine headers. That probably is not required anyway.
You should use #include "al.h" instead of #include <AL/al.h> for best compatibility across platforms.

Speak up if you have any issues with my branch or any comments regarding this list :+1:

That's fine, I will push a few changes I'm making to MojoAL as it seemed to have a few small implementation differences from openal-soft.

Make sure you add comments informing that this is our custom change so we do not lose them next time MojoAL is updated.

Oh looks like i did not make these changes in time. You should rebase your branch on to rokups:rk/openal and force-push into tatjam:openal. Sorry for making it messy for you

I've marked all changes with // tatjam: [change]. I wrote a very simple function for stereo panning similar to the audio produced by OpenAL-soft, but without any of the HRTF effects. The stereo panning that came with MojoAL didn't seem to work properly.

Ooops I forgot to resolve a merge conflict.

The build is failing because I didn't write the non-SSE version of the stereo panning. Will get to it right now.

actually could you make it rbfx instead of tatjam? it is hard to remember names of all contributors and we may mistake it for official MojoAL content.

As I said on the commit, the ARM_NEON implementation is untested. It will probably work if it compiles but sadly I have got no device to test on.

Btw i pushed one more fix to rk/openal so you might want to rebase on that. Also make sure you lose ThirdParty/OpenAl dir as i see it is still in your branch.

Does MojoAL supports al OpenAL features? 3D Audio? Effects?

It only supports 3D audio (although it seemed to be broken, had to change a few pieces of code), effects are not implemented.

When compiling with URHO3D_USE_OPENAL set to ON all openAL symbols are not resolved. I could fix this by adding target_link_libraries(Urho3D PUBLIC ${OPENAL_LIBRARY}) in Source/ThirdParty/CMakeLists.txt, but I'm not sure if that's a good solution. @rokups

I just realized that MojoAL doesn't support pitching either. It may be a better idea to drop MojoAL and simply keep the legacy SDL mixer alongside the OpenAL code as implementing pitching into the MojoAL mixer seems like a quite difficult task.

Turns out it was easier than I expected!  And ${OPENAL_LIBRARY} should be removed from thirdparty dependencies array. I made a mistake there.

Alright, I believe that MojoAL does need to be on the thirdparty array as removing it leads to <al.h> not found, so the code I pushed seems to be correct. (Although it may break if we add more thirdparty libraries while OpenAL is enabled: Does it matter if the array has an empty space?)

There we go, MojoAL now supports pitching, although the implementation could have some improvements. If we enable the doppler effect on the Urho3D audio code it should be very easy to implement, but right now it's not used.
If the code gets cleaned up it could be shared with the MojoAL developers to get integrated into the library, but perfomance critical operations may want it disabled as it implies manually resampling all audio when pitch ≠ 1.0f. Other approaches are more complicated as they require rewriting most of the mixing code.

Hey @tatjam, how is this PR going? Do you consider it mostly done or is there any pending work that you had no time for?

This implementation already works but it may have some bugs. For the more advanced effects I believe it would be more appropriate to create another pull-request. I will do some testing when I get some time and fix any bugs that may appear!

dusts off this old relic from the past
https://github.com/boberfly/Urho3D/tree/openal/Source/Engine/Audio
Wow so long ago....


Error _uploadJobAssets after running cypress test

The problem
Test executes correctly and pass, but something happens that assets are not uploaded in saucelabs.
Environment
saucectl version 0.12.1
(build cfd517fbabbefcf005cbee6294029274560c763e)
using mac
Details
The test passes but I'm getting this final error, so when I go to saucelabs it doesn't show information nor logs of what happened
To reproduce I used the official repo example
$ saucectl new
I chose Cypress JS and I run the test without editing any file with
$ saucectl run
Preparing assets for cypress/integration/example.test.js
upload failed: TypeError: Cannot read property 'startsWith' of null
at SauceLabs._uploadJobAssets (/home/seluser/node_modules/saucelabs/build/index.js:296:64)
at exports.sauceReporter (/home/seluser/src/sauce-reporter.js:94:9)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async report (/home/seluser/src/cypress-runner.js:56:5)
at async cypressRunner (/home/seluser/src/cypress-runner.js:118:20)
at async /home/seluser/bin/cypress:4:3
Open job details page: https://app.saucelabs.com/tests/9abb4787592d4def97cfad3943461c90
Link to saucectl logs
https://app.saucelabs.com/tests/9abb4787592d4def97cfad3943461c90

@guillem-catala which version of stt-cypress-mocha-node image do you have set on your saucectl config?
Can you try again with the latest version? https://hub.docker.com/repository/docker/saucelabs/stt-cypress-mocha-node
We have released a new image with fixes on assets reporting.
https://github.com/saucelabs/sauce-cypress-runner/pull/30

In folder .sauce/config.yaml I was using
  base: saucelabs/stt-cypress-mocha-node
  version: v0.1.9

Now I updated to
  version: v0.1.11
Also updated
saucectl -v
saucectl version 0.14.0
(build 2aff2c2e9d66bcfaad4526faaa58b849c0d32991)

And I can confirm it works!
Thank you very much.

Awesome! Thanks for trying again.


Can't add data with addRow

I can access my spreadsheet correctly (using service account method), but wondering why i can't add a new row. Would be thankful for some input:
my code:
var GoogleSpreadsheet = require('google-spreadsheet');
var async = require('async');

var doc = new GoogleSpreadsheet('1DfcW1M4D4qyJr7WZw13AACeXaE-wCyus6cnC1I5SSZM');
var sheet;

var newrow = {
    title: 'banana',
    type: 'fruit',
    url: 'http://example.com'
};

async.series([
  function setAuth(step) {
    var creds = require('./fruits.json');
    doc.useServiceAccountAuth(creds, step);
  },
  function getInfoAndWorksheets(step) {
    doc.getInfo(function(err, info) {
      console.log('Loaded doc: '+info.title+' by '+info.author.email);
      sheet = info.worksheets[0];
      console.log('sheet 1: '+sheet.title+' '+sheet.rowCount+'x'+sheet.colCount);
      step();
    });
  },
  function addStuff(step) {
    // Add data
    doc.addRow({
      worksheet_id: 1,
      new_row: newrow,
    }, function( err, rows ){
      step();
    });
  }
]);

output:
Loaded doc: fruits by<EMAIL_ADDRESS>sheet 1: Sheet1 1000x26

@CRFullStack hey! yes i did. Do you have problems with this also?

function addStuff(step) {
  doc.addRow(1, newrow, function (err, rows) {
    step();
});

cc @CRFullStack
BTW: If you find out any solution it's always better to share it with others instead of just closing issue silently ;)

there was a solution?, I have the same problem

@reptily and have you tried my solution? Just above your comment ;)

@reptily and have you tried my solution? Just above your comment ;)

Yes, it did not help.
but I found a solution
first set header
_sheet.setHeaderRow(['id','name','body'],()=>{
//call
});

but it still did not help, then I started looking for a problem in the module, and it was discovered that the array is not read correctly and made changes.
fix
and now everything works great
_sheet.addRow({
      worksheet_id:1,
      new_row:{
       id:1,
      name:'Test',
      body:'ZZZZzzz'
    }
    },()=>{
//call
});


[1.12.2] Induction matrix doesn't show any input/output characteristics.

Didn't find any issues regarding this, so here it is.
Issue description:
Induction matrix doesn't show the input/output rates in any of the three places it is supposed to be showing it, main page, statistics page and the hover over energy symbol on the lower left.
It just reads "0" all the time, even though the energy buffer is rising.
Steps to reproduce:

Create an induction matrix of any tier (in creative mode) <= not sure whether there is any difference, blocks got through JEI.
Connect an energy input/output device into it.
Observe the energy levels rising/lowering and the matrix saying that it isn't inputting/outputting anything

Version (make sure you are on the latest version before reporting):
Forge:<IP_ADDRESS>6
Mekanism:9.4.2-327

Also seeing this issue with an induction matrix that worked before updating.  GUI showing no input / output data.  OpenComputers is also reading 0 on input and output.
Forge:  <IP_ADDRESS>6
Mekanism:  9.4.2-327

Is the InductionMatrix by any chance on a chunk border? There is a known issue somewhere that our multiblock structures do not play nicely when they cross chunk borders.

Seems to be fixed.
Mekanism 9.4.3-330
Forge:<IP_ADDRESS>9
Closing issue.


Compilation error, gcc 10.2

Archlinux GCC 10.2:
RecastDuring demo compliation:
../../Source/TestCase.cpp: In member function ‘bool TestCase::load(const string&)’:
../../Source/TestCase.cpp:158:32: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct TestCase::Test’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
  158 |    memset(test, 0, sizeof(Test));
      |                                ^
In file included from ../../Source/TestCase.cpp:23:
../../Include/TestCase.h:33:9: note: ‘struct TestCase::Test’ declared here
   33 |  struct Test
      |         ^~~~
../../Source/TestCase.cpp:172:32: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct TestCase::Test’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
  172 |    memset(test, 0, sizeof(Test));
      |                                ^
In file included from ../../Source/TestCase.cpp:23:
../../Include/TestCase.h:33:9: note: ‘struct TestCase::Test’ declared here
   33 |  struct Test
      |         ^~~~
cc1plus: all warnings being treated as errors

EDIT: Because I'm an absolute moron when it comes to C++ and i simply deleted the offending memset lines and thing worked.

If you met the "memset not defined" error, you should add "include <string.h>"in Sample.cpp, SampleInterface.cpp, and change "include " to "include <string.h>" in main.cpp. The error is not related with "Test", but "memset". Because "memeset" is defined in Windef.h in Windows platform, but in <string.h> in Linux platform.

Those are usually warnings, as the line cc1plus: all warnings being treated as errors suggests.
Removing arbitrary lines of code to "fix" warnings is definitely a bad idea.
But the warnings already recommend a potential fix: using value initialization, i.e. Test test = {};.
@footman136 the errors are not about undefined memset, and even in that case, the correct header would be <cstring>, and it's the same one on all operating systems. See https://en.cppreference.com/w/cpp/string/byte/memset -- <string.h> is a C header.


Hydrate trait

Provide a common trait around a hydrate function which uses a closure to retrieve referenced objects.

I don't think this is fully baked as some references, such as related_party, can point to many classes downstream. Currently I'm only passing a HREF into the closure, might need to pass more information so we can hydrate the correct object.

I think there's a two step process required here and thus two different traits.

Define a trait at the TMF object level which simply provides a function that will hydrate a single TMF Object, to be used by depth and expand query parametes.
Defined a trait at the TMF reference level , to be used by 1. to hydrate individual references.

Currently 'HydrateTrait' only addresses point 2. Suggest naming 2. trait as HydrateRef and 1. as Hydrate.

This needs some more work and ideally requires meta-fields implemented for the references.


Pol 501

Description
Created a hard value policy based off of the recommender policy from google. Adds Google Committed use discount recommender hard policy for use
Issues Resolved
fixes issue of recommender generic having separate outputs depending on recommender called. this will have output tailored to Google CUD recommender api response.
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

@lawrethao check the error there seems to be a space in the folder name.


python3Packages.pdfposter: fix build pin pypdf2

Description of changes
pdfposter is not compatible with pypdf3, but given its mainly used as application should be safe to overwrite pypdf
here is upstream MR to migrate to pypdf3
https://gitlab.com/pdftools/pdfposter/-/merge_requests/7
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240414 run on x86_64-linux 1

2 packages built:

python310Packages.pdfposter
python310Packages.pdfposter.dist

cc @laikq @mweinelt

We cannot use overrides within the python package set, as that causes conflicts when packages introduce different versions of the same package into the same python environment.

We cannot use overrides within the python package set, as that causes conflicts when packages introduce different versions of the same package into the same python environment.
While that might seem unlikely, we don't make exceptions in such cases.

yes, I understand.
From first glance it looks like pdfposter is mean to be used as application,  in which case it probably shouldnt be in python-modules. if thats the case then overrides should be fine.

Yep, looks like an application to me as well.


Add link and image to hosted website to README

Add a link to the website where this repo is hosted as well as a visual banner to make it clearer which site this is. It's hard to tell without this repo this is the 'realworld app' repo or whether this is something else just from the Readme.

@jennifer-shehane thank you 👍


I think we should try to avoid these entirely.
if they are necessary,  we should implement some kind of asynchronous abstraction or make requests synchronous.

Responses from exec's can be awaiting by calling #get on their result, which blocks until the Future resolves. One that I've defined run into (and had to insert a sleep to accomodate) is the initial init / settings load.
This change is definitely the correct thing to do, but will need to be synchronised with improvements to spec-runner.


Refactor monitor system

This change adds significant new functionality to the monitor system.

monitor statements such as SHOW STATS are now served by a dedicated query executor layer within the monitor module. Modeled on the meta package.
A PointsWriter has been added to monitor so it can store statistical data. Very similar to how http service gets its PointsWriter.
Since we decided that the monitor system will not be responsible for writing data to external InfluxDB systems, all support for that has been removed.
The monitor system now ensures that the target database exists before writing statistics to it.

More to do, including fleshing out the actual diagnostics support, and testing.

Looking good.  Can't wait to see more! +1.


[rcore] IsKeyPressed() not working for some keys on RPI (PLATFORM DRM)

Discussed in https://github.com/raysan5/raylib/discussions/3565

Originally posted by larry104 November 22, 2023
I notices that the block of keys (insert, delete home, end, pup, pdown) are not working. IsKeyPressed is not getting any event for these keys (I tried different keyboards and started the application from ssh terminal vs native terminal no difference). All other keys are working fine. Does anyone have an idea what is going wrong ?

Just to summarize: keys insert delete, home, end, page up, page down are not implemented in on the RPi (PLATFORM DRM in rcore_drm.c:
https://github.com/raysan5/raylib/blob/a3a73b9332d0ca0d7ec81044edce31dd13d7c916/src/platforms/rcore_drm.c#L1333-L1375
only 3 byte and 5 byte scan codes for F keys and cursor keys are implemented:  here are the missing 4 byte codes:
insert
^[[2~    27 0033 0x1b
91 0133 0x5b
50 0062 0x32
126 0176 0x7e
delete
^[[3~    27 0033 0x1b
91 0133 0x5b
51 0063 0x33
126 0176 0x7e
home
^[[1~    27 0033 0x1b
91 0133 0x5b
49 0061 0x31
126 0176 0x7e
end
^[[4~    27 0033 0x1b
91 0133 0x5b
52 0064 0x34
126 0176 0x7e
page up
^[[5~    27 0033 0x1b
91 0133 0x5b
53 0065 0x35
126 0176 0x7e
page down
^[[6~    27 0033 0x1b
91 0133 0x5b
54 0066 0x36
126 0176 0x7e

It doesn't work with raylib 4.5 ... is that something which might have been fixed in 5.x ?.
I tired from ssh shell as well as native shell. (bullseye, raspberry pi zero
./raylibtest1 INFO: Initializing raylib 4.5 INFO: Supported raylib modules: INFO:     > rcore:..... loaded (mandatory) INFO:     > rlgl:...... loaded (mandatory) INFO:     > rshapes:... loaded (optional) INFO:     > rtextures:. loaded (optional) INFO:     > rtext:..... loaded (optional) INFO:     > rmodels:... loaded (optional) INFO:     > raudio:.... loaded (optional) INFO: DISPLAY: No graphic card set, trying platform-gpu-card INFO: DISPLAY: Failed to open platform-gpu-card, trying card1 INFO: DISPLAY: Failed to open graphic card1, trying card0 INFO: DISPLAY: Selected DRM connector mode 800x600 (800x600p@60) INFO: DISPLAY: Upscaling required: Screen size (800x450) smaller than display size (800x600) INFO: DISPLAY: Device initialized successfully INFO:     > Display size: 800 x 600 INFO:     > Screen size:  800 x 450 INFO:     > Render size:  800 x 450 INFO:     > Viewport offsets: 0, 150 INFO: GL: Supported extensions count: 52 INFO: GL: OpenGL device information: INFO:     > Vendor:   Broadcom INFO:     > Renderer: VC4 V3D 2.1 INFO:     > Version:  OpenGL ES 2.0 Mesa 20.3.5 INFO:     > GLSL:     OpenGL ES GLSL ES 1.0.16 INFO: GL: VAO extension detected, VAO functions loaded successfully INFO: GL: NPOT textures extension detected, full NPOT textures supported INFO: GL: ETC1 compressed textures supported INFO: TEXTURE: [ID 1] Texture loaded successfully (1x1 | R8G8B8A8 | 1 mipmaps) INFO: TEXTURE: [ID 1] Default texture loaded successfully INFO: SHADER: [ID 1] Vertex shader compiled successfully INFO: SHADER: [ID 2] Fragment shader compiled successfully INFO: SHADER: [ID 3] Program shader loaded successfully INFO: SHADER: [ID 3] Default shader loaded successfully INFO: RLGL: Render batch vertex buffers loaded successfully in RAM (CPU) INFO: RLGL: Render batch vertex buffers loaded successfully in VRAM (GPU) INFO: RLGL: Default OpenGL state initialized successfully INFO: TEXTURE: [ID 2] Texture loaded successfully (128x128 | GRAY_ALPHA | 1 mipmaps) INFO: FONT: Default font loaded successfully (224 glyphs) WARNING: RPI: Failed to open Gamepad device, no gamepad available WARNING: RPI: Failed to change keyboard mode, an SSH keyboard is probably used INFO: TIMER: Target time per frame: 16.667 milliseconds INFO: TEXTURE: [ID 2] Unloaded texture data from VRAM (GPU) INFO: SHADER: [ID 3] Default shader unloaded successfully INFO: TEXTURE: [ID 1] Default texture unloaded successfully INFO: Window closed successfully

I'm closing this issue, it seems it refers to an old raylib version.

I compiled the test case using the master branch 5.1.-dev and it still does not work for those keys. I added a log for the BACKSPACE key and that works fine:
./raylibtest1
INFO: Initializing raylib 5.1-dev
INFO: Platform backend: NATIVE DRM
INFO: Supported raylib modules:
INFO:     > rcore:..... loaded (mandatory)
INFO:     > rlgl:...... loaded (mandatory)
INFO:     > rshapes:... loaded (optional)
INFO:     > rtextures:. loaded (optional)
INFO:     > rtext:..... loaded (optional)
INFO:     > rmodels:... loaded (optional)
INFO:     > raudio:.... loaded (optional)
INFO: DISPLAY: No graphic card set, trying platform-gpu-card
INFO: DISPLAY: Failed to open platform-gpu-card, trying card1
INFO: DISPLAY: Failed to open graphic card1, trying card0
INFO: DISPLAY: Selected DRM connector mode 800x600 (800x600p@60)
INFO: DISPLAY: Upscaling required: Screen size (800x450) smaller than display size (800x600)
INFO: DISPLAY: Device initialized successfully
INFO:     > Display size: 800 x 600
INFO:     > Screen size:  800 x 450
INFO:     > Render size:  800 x 450
INFO:     > Viewport offsets: 0, 150
WARNING: GetCurrentMonitor() not implemented on target platform
WARNING: GetMonitorWidth() not implemented on target platform
WARNING: GetCurrentMonitor() not implemented on target platform
WARNING: GetMonitorHeight() not implemented on target platform
WARNING: SetWindowPosition() not available on target platform
INFO: GL: Supported extensions count: 52
INFO: GL: OpenGL device information:
INFO:     > Vendor:   Broadcom
INFO:     > Renderer: VC4 V3D 2.1
INFO:     > Version:  OpenGL ES 2.0 Mesa 20.3.5
INFO:     > GLSL:     OpenGL ES GLSL ES 1.0.16
INFO: GL: VAO extension detected, VAO functions loaded successfully
INFO: GL: NPOT textures extension detected, full NPOT textures supported
INFO: GL: ETC1 compressed textures supported
INFO: RPI: Opening keyboard device: /dev/input/event2
WARNING: RPI: Failed to open Gamepad device, no gamepad available
WARNING: RPI: Failed to change keyboard mode, an SSH keyboard is probably used
INFO: PLATFORM: DRM: Initialized successfully
INFO: TEXTURE: [ID 1] Texture loaded successfully (1x1 | R8G8B8A8 | 1 mipmaps)
INFO: TEXTURE: [ID 1] Default texture loaded successfully
INFO: SHADER: [ID 1] Vertex shader compiled successfully
INFO: SHADER: [ID 2] Fragment shader compiled successfully
INFO: SHADER: [ID 3] Program shader loaded successfully
INFO: SHADER: [ID 3] Default shader loaded successfully
INFO: RLGL: Render batch vertex buffers loaded successfully in RAM (CPU)
INFO: RLGL: Render batch vertex buffers loaded successfully in VRAM (GPU)
INFO: RLGL: Default OpenGL state initialized successfully
INFO: TEXTURE: [ID 2] Texture loaded successfully (128x128 | GRAY_ALPHA | 1 mipmaps)
INFO: FONT: Default font loaded successfully (224 glyphs)
INFO: TIMER: Target time per frame: 16.667 milliseconds
INFO: KEY_BACKSPACE
INFO: TEXTURE: [ID 2] Unloaded texture data from VRAM (GPU)
INFO: SHADER: [ID 3] Default shader unloaded successfully
INFO: TEXTURE: [ID 1] Default texture unloaded successfully
INFO: Window closed successfully

This is super strange. I tested it on a RPi3 and RPi Zero and both don't work ... What locale do you have set on your RPi? I have no other idea why this does not work for these 6 keys

Keyboard is set correctly ...
KEYBOARD CONFIGURATION FILE
Consult the keyboard(5) manual page.
XKBMODEL="pc105"
XKBLAYOUT="us"
XKBVARIANT=""
XKBOPTIONS=""
BACKSPACE="guess"

I am fetching it with cmake but just to make sure ... I did exactly what you did and it does not work.  I even tried on bookworm . hmm

I just tried a different keyboard ... same exact issue ... and I added a control key BACKSPACE which works
the INFO message shows also correctly
INFO RPI: Opening keyboard device: /dev/input/event1

yes, I do. I boot directly into a terminal.
It seems the code never enters the while loop in line https://github.com/raysan5/raylib/blob/811abcb19faba710839a254ee3781a8d0ab23337/src/platforms/rcore_drm.c#L1691

In my caser there are no prints happening ...  platform.keyboardFd is 8.

Side-note: I'm really not sure if the SSH input was ever meant to be actually fully supported, or just some shortcut for basic testing.

@ubkp I created it for my convenience when I implemented RPI support first time, definitely not a priority and probably useless at this point.
@larry104 Could you verify if PollKeyboardEvents() is actually called? I'm afraid some printf-debugging is required on your side...

Yes, PollKeyboardEvents() is called but
https://github.com/raysan5/raylib/blob/811abcb19faba710839a254ee3781a8d0ab23337/src/platforms/rcore_drm.c#L1691
returns always -1 so it never enters the while loop

@larry104 could it be related to some kind of security reason? did you try running the example as root?

I tried as root no difference ... what I don't understand why other keys work just these 6 not ... that is all really strange

turning that option off causes all sorts of errors in terms of missing libraries. Eventually it compiled but now the keyboard does not work at all anymore.

The version for bullseye and bookworm I installed were both the 32 bit light (with no desktop environment). Let me try tomorrow the same version you have.  I report back in the morning. Thanks a lot for all your help so far ... this is really a strange problem.

Since I did this test on a RPi Zero I used a USB hub. But, I tried it without the hub as well. I also tried swapping this standard Microsoft keyboard with a Bluetooth keyboard. Same issue. I can try to get some other keyboards as well but I'm not confident it solves the problem. It's a mystery ...

this is a really strange issue...

I recompiled with SUPPORT_SSH_KEYBOARD_RPI disabled. There were no errors/warning during the compile. Now we are back to that no key at all works. What is super strange is I gave the code to a friend with a RPi 3 and he tested it but it was still based on the 4.5 version I was compiling against and he was having the same problems. That at least makes me believe it's not a HW problem.

Here might be the difference, can you try booting directly into CLI instead compiling it from X11?

wow, now I am literally going insane. I have no more ideas ... If you use the RPi Imager on Windows you can set locale, ssh, wifi etc. before you actually flash the image and this is what I did. Let me do it all over again and do it later from X11 .. I try one more time and then I buy a new RPi ;-)

I still used the Imager but didn't make any changes to settings ... flashing just done ...

ok ... that would really point to a HW issue. Let me finish that current setup and I try to find another keyboard, I think I have one more somewhere. If that doesn't work I order the latest RPi Zero 2 W.

oh wow ... this is awsome ... so I am not insane after all!!!!! Mine is a Microsoft Wired Keyboard 600 and the other one a Microsoft Wireless Desktop 900 Keyboard

I was about to say the same thing about MS ;-) Too bad I had two of them to test. Thank you so much for all your help to figure it out!!!! And people will find here now the best installation instructions of raylib on a RPi with bullseye or bookworm ;-)

But the input code I've been using doesn't have an issue with it because I poll all keyboard devices and combine their input into a single logical keyboard. But when I get back to working on the input stuff I'll be sure to see if my approach works here. It is possible I didn't test those keys because I don't press them a ton.

Oh! That sounds like a good approach. Please, let us know if you test it.... and feel free to open a PR for the inputs update when possible... ;)

btw/ I confirmed on my side I get the MS keyboard twice in /proc/bus/input/devices and I confirmed that my friend also had a MS keyboard. How are the odds having 3 MS keyboards ;-). I further confirm that my Logitech MS keyboard works without any problems.

@ubkp I found another issue with the keyboard. When using the keyboard through ssh the key repeat works without any problems. When using a keyboard connected directly to the RPi the key repeat does not work.


Fixing multiple mutually exclusive groups

Previous version would only ever merge in the first mutually exclusive group into the action list.

Could you give an example demonstrating the problem, and additionally write a few tests demonstrating the fix?

Sure:
import gooey

@gooey.Gooey
def main():
    parser = gooey.GooeyParser()

    parser.add_argument("--test")

    mutex_1 = parser.add_mutually_exclusive_group(required=True)
    mutex_1.add_argument('--choose-1', action='store_true', default=False)
    mutex_1.add_argument('--choose-2', action='store_true', default=False)

    mutex_2 = parser.add_mutually_exclusive_group(required=True)
    mutex_2.add_argument('--choose-3', action='store_true', default=False)
    mutex_2.add_argument('--choose-4', action='store_true', default=False)

    parser.parse_args()

if __name__ == "__main__":
    main()

When I run against current master I get:

When I run against my change I get:

What type of tests are you looking for?

Just your run of the mill unit tests should work. There's some prior art for argparse_to_json in the tests directory.
argparse_to_json is long overdue for a refactor. Writing a test for your bug will help me not introduce a regression whenever I get around to cleaning things up ^_^

Oh, additionally, this needs to target the release branch

Oh, that makes way more sense now. Was looking at the tests in master =P. I'll get on this.

Ok, I switched to working off of 1.0.3-release. I'll close this PR and open another one.


Add type definition for HTTP methods

For the issue https://github.com/facebook/flow/issues/5314

Closing due to no response. Feel free to reopen if you would still like to pursue this.

Hi @nmote, by API docs do you mean something like https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods ?

Something like that, but that looks to be the HTTP spec. I'm looking for something that documents the JS functions you've modified. In this case, I would expect those API docs to say that only a valid HTTP methods could be passed as the method argument.

https://fetch.spec.whatwg.org/#concept-method


First draft of Sustainable Software Manifesto

Very first draft of how a sustainable software development manifesto could look like. Format/inspiration has been taken from https://agilemanifesto.org, which I value strongly.

I like the start very much. Thank you very much for the time, effort and thoughts you put into it. I think it is the right time to start something like this.
What about adding something about operations in there like
***containerized application*** over virtualized hardware
to generate less overhead and allow higher usage for intended usecase.

I think it already greatly shows ways of "how" to implement better software from an ecological standpoint, I would also see something about the "what" we develop in here. Maybe
We only develop software that does no ecological and human harm.

What are your thoughts about that?

I like both. The latter one is a great generic one that can be used even 20 years, with new technology etc.
The first one is pretty detailed about specific technologies. This could be outdated some time. Maybe we can put that in more generic words?

I like both, especially the latter one. It is very generic and can be used even in 20 years.
The first one is very specific focusing at a specific technology, and might thus be outdated in a few years. Still I like the point. Maybe it can be put in more generic words?

Well it is kind of trying to reduce the organizational overhead?
**Sandboxed services** over Independent operational installations

Does that go into the right direction?


Extension doesn't work as expected

When I close and open my VS Code the extension doesn't work anymore.  I have to uninstall it and install it again.  The other issue is when I open a second instance of my VS Code, with it, the extension works in the 1st instance but not in the 2nd.
Please fix it.  It is a great extension.
I'm using:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic
And:
Visual Studio Code:
Version: 1.33.1
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:20:22.771Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-48-generic

Sorry that it isn't working for you, I cannot reproduce your problems.
Which other plugins do you have installed?


Copy/Paste from MdTable

It's not currently possible to copy from an MdTable and paste into an Excel (or similar) spreadsheet. This is standard for html tables. Is this something that will be added?
This can be seen simply by copying from the examples in the docs: https://material.angular.io/components/table/overview

The only possible solution would be to use the <table> element rather than a collection of divs, which is not compatible with our current and future feature set.


Show SCM changes in tree-like format

VSCode Version: 1.6.1
OS Version: Windows 10 10.0.14393

Steps to Reproduce:

I just want we could have an extra option to allow user to display git changes no matter stage or not in tree view, not only list all of them like now.

#178

@joaomoreno This doesn't seem like a duplicate of the referenced issue...

#178 talks about the color of the file in the list
#14582 (this one) asks to display the changes in a tree view instead of a flat list

Can it be re-opened/considered?  I find it much easier to look through changes in a tree (the same way I see my files in VS Code's Explorer and the same way Visual Studio shows them in Team Explorer>Changes).

I also want this 👍

I wished to add an example of why I would currently avoid vsCode clutter with console:

In this case, I just wished to check if there is nothing in changes besides the items visible in red in console.
Visual Studio Community has tree view, which could be taken as a good example. It distinguishes between staged and not staged files. Of course, I would like vsCode to do the same.

+1 here
I like going through my git changes before I make a pull request, to see if I forgot to remove some files, comments, debug code, etc. But doing so on a flat list of files is hard.

Question: Is this doable with an extension? I'm not yet familiar with extension api but if it can be accomplished with an extension I will try to works on this...

That's say, if I want to add all the file changes under python_RL2/, shown as below, currently I have to manually select them all. Is there a quicker way to do this? Which like tree view select or path filter select?

When will this be implemented as it's open since 2016 :)

+1.  Can we at least organize the changes by full path instead of filename?

+1 this is a reall need.

+1

+1

+1

+1

+1

+1

+1

PLEASE stop posting +1 and use the 👍 on the initial post at top
so owners can actually see how many people wants this feature.  (I'm surprised that they still couldn't realize how important this feature is)

FIX IT!

I started to use https://www.sublimemerge.com/ since it came out last week because I lacked a good visual solution on linux.
It is unbelievable disapointing how such a crucial but simple feature did not make it into vscode for so long.
Especially as a Golang developer I really need this because we use a checked in vendor directory causing a few hundreds of thousand changes when updating them.
I don't get how the vscode team can work with the current state as node_modules are in no way better.
Could somebody from the team at least provide a statement on where the problem resides?  I am barely a frontend dev and can't really imagine the complexity as there already is tree views in vscode.
I would do it myself if I could...

The GitLens extension can be an option for those who badly want this.

The GitLens extension can be an option for those who badly want this.

Unfortunately, the GitLens explorer only provides a "view" to the changed files. There are no Git actions (staging, committing, etc.) like in the built-in Source Control sidebar.

Has this feature be resolved already?

Usually I want to see the files in a tree view when I need to make a partial commit, like the content of one or more folders. It's hard to select each file, even with shift and stuff.
While this feature isn't ready, I'm using GitKraken or the good and old git command line tool: git add folder/*. If you focus the "Source Control" tab after this command you'll see the entire folder inside the "Staged Changes" area. It's not the best solution, but save me some time.

@andersgb1 I created a PR to add (un)staging an entire folder for gitlens #600

@andersgb1 I created a PR to add (un)staging an entire folder for gitlens #600

Very, very nice, @UziTech!

Almost 2 years passed and no visible solution yet!
Any plans or extensions to implement this?

@nash-ye gitlens allows you to stage files in a tree view

@nash-ye gitlens allows you to stage files in a tree view

Thanks for pointing this out, it does indeed, I have hid the default SCM window, switching to GitLens.

I think this should be considered as a core VsCode feature.
It also means one more place to utilize VsCode's new and improved "treeview" UI component (the one used in the file explorer).

I have done some exploration into supporting this feature.
Is this the general idea?

I think it would be better to reduce the number of folders to ones that have multiple files/folders in the in the view. (similar to what github does for empty directories)
something like:

The main point of making this a tree view format is so you can stage entire folder instead of only having the option to stage each file separately or stage all files.

I agree with @UziTech
The first screenshot would be a little too verbose and shows too much information that could be combined.

@UziTech Thanks for the input. I came up with something like this.

Sorry fo stupid question, but how I turn on TreeView for PullRequest changes for example?

@invis87 I added a setting called "Show changes as a tree view" under Features -> SCM. You have to build it from my branch if you want to test it.

@jmbockhorst i am not able to see "Show changes as a tree view" under Features -> SCM in VS Code. Can you please help me to find out.

Is there a PR for this already?  What are the chances of it being included any time soon?

I haven’t opened a pull request yet. Still working on the context menus and commands.

@jmbockhorst Would this tree view honor the workbench.tree.indent? It's a big accessibility benefit for some visual impairments. Thanks for the work on this feature in general.

@eightnoneone Yes, this tree would honor the tree indent setting as well.

I have finished adding the context menus and actions for the tree view. This includes the ability to stage and unstage an entire directory.

I think the next step would be a way to distinguish whether a change is staged or not, because right now there is no way to tell in the tree view. Let me know what you guys think.

Would it make sense to have the tree populate under the existing "Changes" and "Staged Changes" top level sections as they do now? Showing the subordinate lists in trees.

That is an option for sure, but I would be worried about it being too cluttered and redundant.

As @ghost mentioned in this post
Visual Studio Community could be a valid example. It distinguishes between staged and not staged files using 2 separate tree

Pros/cons I'm seeing on the two approaches:

The two top level sections of "Staged Changes" and "Changes"

similar to existing views
could get cluttered when all expanded,
collapse gets less length for whole dirs changed

A single tree with filters for the states Added, Modified, Untracked etc.

could cover many use-cases of 'i need less clutter'. Remember, my signal is your noise.
departure from existing view structure/behavior. Add to index doesn't remove from changed list (unless correct filter is on)

I looked at how Visual Studio Community does this, and I think it would work fine to have separate trees for the stages. It would also keep it consistent across Visual Studio products.
Also, how I have it now, it still shows the status (A, M, U), but that does not distinguish whether a file is staged or not.

Is it working with a big list of changes too? Today it shows only the top 5000 files. Try removing node_modules from .gitignore and renaming the src folder.
Maybe if there are too much files, it could default to show the folders collapsed. If not, would be fine to show the folders expanded.

I have finished the work to have separate trees for each resource group (Changes, Staged Changes). I think it is working nicely. Staging, unstaging, and discarding changes all works on directories as you would expect in each group.

@lmcarreiro I tested it like you said and it still works a big list of changes, it just shows the big tree. I like the idea of collapsing the a folder with too many files in it, just not sure how and when to best do that.

@jmbockhorst That looks really nice. I agree there's a threshold of a sane list to show before assuming one should start with a collapsed view. Is a "collapse all" icon like in the workspace tree view a reasonable feature-creep addition here? If it's a long list, It would give the user the option to start from the top and work through a tree in an ordered fashion. Best would be separate ones on Changes and Staged Changes.

@jmbockhorst does your exploration add twisties to the Resource Groups (i.e. CHANGES and STAGED CHANGES)? I recently opened #74280 because I'd like to do that for a source control provider implemented in one of our extensions. @joaomoreno linked my issue to this one and closed it.

@gjsjohnmurray Currently it does not, but it is something that could be added fairly easily.

@jmbockhorst thanks. I assume the changes you're proposing take account of how the SCM viewlet is generic, with Git being just one user of the generic framework. My #74280 request was to have expand/collapse of the resource groups implemented at the framework level so anything plugging into it gets the benefit.

This would be very nice to have. It's one of the main features I still miss from PHPStorm. The Gitlens extension for VS Code does have a similar view, so I started using that this week as a workaround as I had to work through a few hundred files and progressively stage & commit directory-by-directory.

Given the working example above, is there a way to currently activate this feature?

@jmbockhorst nice job! Looks fantastic.
When we could use this feature?

I just noticed this issue appear as work in progress for the Sep 2019 iteration cycle as "Adopt compressed trees in the SCM view" https://github.com/microsoft/vscode/issues/80591

Fixed by https://github.com/microsoft/vscode/commit/95d7625a2769bd3c7debdc69953e4e3900c448fd

This will roll out next monday on the Insider build. Let me know any feedback!


Dataviewer will now open immediately

For #6840
The checkForPandas was happening before even showing the data viewer. Now it happens after it shows up.

Codecov Report

Merging #9030 into master will decrease coverage by 0.36%.
The diff coverage is 6.45%.

@@            Coverage Diff             @@
##           master    #9030      +/-   ##
==========================================
- Coverage   56.65%   56.29%   -0.37%
==========================================
  Files         550      550
  Lines       28959    28599     -360
  Branches     4376     4377       +1
==========================================
- Hits        16407    16099     -308
+ Misses      11658    11599      -59
- Partials      894      901       +7

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)
:arrow_up:

...ascience/jupyter/liveshare/guestJupyterNotebook.ts
10.57% <0%> (-0.21%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
5.27% <0%> (-0.03%)
:arrow_down:

.../datascience/interactive-common/interactiveBase.ts
18.35% <0%> (+0.29%)
:arrow_up:

...ent/datascience/data-viewing/dataViewerProvider.ts
20% <8.33%> (-3.08%)
:arrow_down:

...nt/datascience/jupyter/invalidNotebookFileError.ts
0% <0%> (-60%)
:arrow_down:

src/datascience-ui/react-common/logger.ts
0% <0%> (-40%)
:arrow_down:

...jupyter/kernels/jupyterKernelPromiseFailedError.ts
0% <0%> (-33.34%)
:arrow_down:

...ent/datascience/jupyter/jupyterWaitForIdleError.ts
0% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
50% <0%> (-25%)
:arrow_down:

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2302553...82ba69f. Read the comment docs.


VSCode not to associate itself with any file type unless the user chooses so during installation

VSCode Version: 1.2.1
OS Version: win10 x64

Steps to Reproduce:

Install VSCode
Open Control Panel > Control Panel Home > Default Programs > Assosiate a file type or protocol with a specific program:
you'll notice that a hundred file types (in fact 101 !) are now associated with VSCode (screenshot 1).
There was no such option to opt in during the installation  (screenshot 2)
neither there's a way to remove the file associations inside the program preferences.
The only way remove the file associations is to uninstall VSCode altogether.

For reference, all other editors that I have installed: Sublime Text, Atom, Notepad++,  gVim, UltraEdit
don't associate themselves with any file type.

So, my suggestion:
VSCode not to associate itself with any file extension unless the user chooses so during installation.
Even better, to be able to configure file type associations with VSCode (enable/disable each one) , inside the program's preferences.

I think there's already a checkbox on the installer for this. It's checked by default though, it should probably be opt-in.

No, there's no such checkbox. Please check screenshot 2 from my 1st post, and the attached video capture of the install procedure: Video_2016-07-03_235157.zip
Also, the two checkboxes in the installer (esp. the 1st one) to Add "Open with Code" action to Windows Explorer file/directory context menuare unchecked by default, and even so (i.e. keeping them unchecked), the associations are made in spite of that.

My belief is that Code doesn't associate itself automatically, but simply registers as a possible editor for such files.

No, that's not the case.
Installer doesn't just add Code as an extra entry in windows explorer's rightclick|Open with menu for these file extensions:

I created various empty files with random extensions from my screenshot 1)
and all are associated with Code :

In other words, doubleclicking any of these files, opens them in Code.

Yes, but did you have any other application that was able to open those files before you installed Code?

The .js files open with Microsoft Windows Based Script Host by default.
Also, sh files

(sorry, closed the issue by mistake)
The .js files would open with Microsoft Windows Based Script Host (a windows component, it's by default).
After installing Code they become assosiated with Code.
On the other hand, sh files would open with Git for Windows.
After installing Code they are still associated with Git.

Got it, thanks for the info! I will attempt to reproduce on a brand new Windows box, see what we can do.

Investigation
VSCode simply registers itself as an application suitable to open a variety of file types, through the use of the HKEY_CLASSES_ROOT registry subtree. Every time an application adds itself as one able to handle a file type, Windows will do the following:

If the file type itself doesn't have an application association set by the user, it will pick VS Code since it is the only alternative available.
Otherwise, it will not overwrite the association.

The exception to the rule seems to be files like *.js which seem to respect some strange magic which I don't understand: they seem to be inherently associated with the Microsoft Windows Based Script Host through some other mechanism. As no one in their sane mind would actually expect to double click a .js file to run it in 2016, I'll let this slip. There may be others, but so far this is the one.
In conclusion, Code is doing the right thing, no change there.
The Rabbit Hole goes deeper
I've decided to experiment a bit more to find out how this works.
In a brand new VM, I installed Notepad++, created the following 4 files and associated *.config files to open with Notepad++.

Note that:

*.txt files are associated with Notepad.
*.sh files are not associated with any application, since there is no suitable application that can handle them.
*.js files are associated with the pesky Microsoft Windows Based Script Host.
*.config files are associated with Notepad++.

After, I installed the latest Insiders setup:

Everything is the same. Wait, what..? But Code did get registered to a few file extensions. Why?

After investigating why that is, it happens to be the PersistentHandler registry key. That seems to be the difference between *.sh and *.aspx files for example:

All the file extensions that were correctly associated with Code have this PersistentHandler set to some GUID, which was already there before Code's installation. I failed to understand where PersistentHandler comes from, and what its value actually means.
I stopped at this point, since I can think of more productive ways to spend my time.
Conclusion
I've added a checkbox during setup which will let users skip file associations: Register Code as an editor for supported file types.
@dbaeumer This is a new string that needs to be localised. The key is AssociateWithFiles, in build\win32\i18n\messages.en.isl.

VSCode Version: 1.4.0
OS Version: Win7 x64
After installing Visual Code, I don't know which file is .gitattributes, and which file is .gitignore ...

although I added 'AlwaysShowExt' in filetype, but not working...

Assigning back to @joaomoreno to react to comments.

I uninstall and re-install again, uncheck "Register Code as an editor supported file types", it is ok now.

If I update from previous version (1.2.x), installer will associate filetypes.
Thanks.

Thank you!

Please add more options to set VSCode as default code editor, specially when switching from Sublime Text.
Like in Control Panel\Programs\Default Programs\Set Default Programs

That box needs to spell out what it is going to do and it should show every association so we can untick ones we don't wnat. It is worded too vaguely.
The install removed my previously set up editor associations - they no longer appear under "open with". Very annoying.

I was testing out VSCode for the last couple of days (it's great!) and just noticed it had changed a bunch of default file associations... which is not cool - if you "earn my trust" I'll make you default by choice.
I know you probably don't care, but just thought I'd say I think you should re-think this policy!

...and it associates itself automatically with each and every file type it knows how to open on macOS. I love how VS Code thinks it is the only editor on my computer, but that's not the case.

How do I undo VSCode's damage on my Mac?

I still have this issue with macOS as well

Solution: Delete VSCode or move it away from /Applications

Yeah in the end I just deleted it and switched back to Sublime Text


feat: multiline ---@param description

Resolves #20

@mfussenegger I hope this will work for you :)

I had in mind that the annotations in the code keep using @class and so on, but that the generated documentation would look as if it it were inlined (maybe via an option).
But this should be fine as well.


wording of docs

The language and setup is written in away you are doing one project after another all at once. I was thinking of some re-writes so it easier to do each project separately but still one after the other. Ex. Long amount of time between projects. This is issue is to track writes for captions long.

List of dependences need for this project
Table of Contents

Love it, yeah let's do it


workers variable should be optional on bare-metal after #1295

Description
Thanks to #1295 and the worker module, the workers variable should default to an empty list so that it can be optional when defining the control plane
Steps to Reproduce
Using the example from #1295 results in a terraform validate error:
The argument "workers" is required, but no definition was found.
Expected behavior

No terrafom validation errors if workers is left undefined
No need to define an empty set of workers via workers = []

Environment

Platform: bare-metal
OS: fedora-coreos, flatcar-linux
Release: Git SHA 1caea3388c5dd306738661b56dbd2a3d484bf21b

Possible Solution

Add a default = [] to:

https://github.com/poseidon/typhoon/blob/main/bare-metal/flatcar-linux/kubernetes/variables.tf#L42-L55
https://github.com/poseidon/typhoon/blob/main/bare-metal/fedora-coreos/kubernetes/variables.tf#L43-L56

Thanks, agreed it should be optional now


Migrations error when updating kong from 0.10 to 0.14 using Cassandra as database

When we launch migrations command on a freshly created cassandra keyspace we see this error :
/usr/local/share/lua/5.1/kong/cmd/migrations.lua:37: [cassandra error] Error during migration 2018-03-27-002500_drop_old_ssl_tables: [Invalid] Index 'ssl_servers_names_ssl_certificate_id_idx' could not be found in any of the tables of keyspace 'xxxxxxxxx'
I think we can get rid of this error by changing these lines :
https://github.com/Kong/kong/blob/0.14.0/kong/dao/migrations/cassandra.lua:L744
up = [[       DROP INDEX ssl_servers_names_ssl_certificate_id_idx;       DROP TABLE ssl_certificates;       DROP TABLE ssl_servers_names;     ]]
to
up = [[       DROP INDEX IF EXISTS ssl_servers_names_ssl_certificate_id_idx;       DROP TABLE IF EXISTS ssl_certificates;       DROP TABLE IF EXISTS ssl_servers_names;     ]]
Steps To Reproduce

Launch Kong v0.10 (it will launch migrations with command start) on Cassandra Keyspace: kong_v_0_10
Launch migrations with a Kong v0.14 on Cassandra Keyspace: kong_v_0_14

Migrations/upgrade paths are generally meant to be following release-by-release (that is, upgrade from 0.10 -> 0.11, 0.11 -> 0.12, etc). There are breaking changes between each release that are not accounted for at the distance you're considering here, and I suspect such behavior will not be supported in the future either (this discussion has come up here in the past).

@Christophe-Ploujoux Hi,
You are welcome to contribute these changes in a PR if you wish to. Please first have a look at our CONTRIBUTING.md file :)
In the future, we will try to actively plan and communicate supported upgrade paths between releases with migrations (including jumps in major versions). For now, it really depends on which versions you are upgrading from/to, and deserves careful study of said migrations.
Thanks!

Sorry to re-open the track, but I'm facing some sporadic appearance of the exact same error mentioned by @Christophe-Ploujoux during a migration, either from scratch (new keyspace), or from an existing keyspace corresponding to a Kong 0.12 version (I did not try from another version).
While the correction of @Christophe-Ploujoux might work (not tested, but I guess it should), the reason of my post here is that the faulty dropping of the index is done in the down section of the migration, and not in the up section, i.e. in a piece of code that should normally not be executed at all when running a migration up, isn't it ?
I would be happy to push a PR to solve the issue, but there is something I don't understand here !

Sorry, my bad reading:

the up section of migration 2018-03-27-002500_drop_old_ssl_tables really contains the DROP INDEX ssl_servers_names_ssl_certificate_id_idx; (https://github.com/Kong/kong/blob/0.14.1/kong/dao/migrations/cassandra.lua#L745), but note the end of the index name: _id_idx
this is indeed migration 2016-12-14-172100_move_ssl_certs_to_core that has a down section doing a DROP INDEX ssl_servers_names_ssl_certificate_idx; (https://github.com/Kong/kong/blob/0.14.1/kong/dao/migrations/cassandra.lua#L266)... but note the end of the index name here: _idx only

I consequently think there is a bug in 2016-12-14-172100_move_ssl_certs_to_core.down because the name of the index in the DROP looks not good... but unfortunately, that does not solve the initial issue that is still present in 2018-03-27-002500_drop_old_ssl_tables.up :(


Correct typo in referenced function name (IDFGH-9496)

The functions uart_enable_pattern_det_intr and uart_disable_pattern_det_intr have been renamed to uart_enable_pattern_det_baud_intr and uart_disable_pattern_det_baud_intr, but a reference to these functions in the text was not updated.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

sha=b36dd1689d51ef32924649a20342da43ef7dd336

Thanks for contribution again, feel free to reopen.


[Keycloak Plugin] Catalog fails to read from Keycloak during deployment

Describe the bug
When using the Keycloak plugin as a dynamic plugin with RHDH, I encounter the following error:
2023-11-16T19:17:59.256Z catalog error KcAdminClient is not a constructor type=plugin class=KeycloakOrgEntityProvider taskId=KeycloakOrgEntityProvider:default:refresh taskInstanceId=32e953ad-9e50-41d0-ab16-eb87e0ba6cc5 stack=TypeError: KcAdminClient is not a constructor
at KeycloakOrgEntityProvider.read (/opt/app-root/src/dynamic-plugins-root/janus-idp-backstage-plugin-keycloak-backend-dynamic-1.7.1/dist/cjs/KeycloakOrgEntityProvider-9b3ad730.cjs.js:326:27)
at fn (/opt/app-root/src/dynamic-plugins-root/janus-idp-backstage-plugin-keycloak-backend-dynamic-1.7.1/dist/cjs/KeycloakOrgEntityProvider-9b3ad730.cjs.js:374:24)
at TaskWorker.fn (/opt/app-root/src/node_modules/@backstage/backend-tasks/dist/index.cjs.js:599:15)
at TaskWorker.runOnce (/opt/app-root/src/node_modules/@backstage/backend-tasks/dist/index.cjs.js:350:18)
at async /opt/app-root/src/node_modules/@backstage/backend-tasks/dist/index.cjs.js:298:31

This results in the prevention of users and groups from being read into RHDH.
Expected Behavior
The Keycloak plugin should function without failure and properly read in users and groups.
What are the steps to reproduce this bug?

Deploy RHDH using the Helm Chart
Add an app config file for Keycloak
Upgrade RHDH Helm Chart enabling the Keycloak Backend Plugin

Versions of software used and environment

The right fix for this issue should be https://github.com/janus-idp/backstage-plugins/pull/971.
However to avoid any disruption risk, this PR should only be merged after the showcase 1.0.x branch code freeze.


Update dotnet version in GH Actions

GH actions doesn't work, because project was updated to .NET 5
And second - in gh-pages.yml dotnet publish can publish only WebAsm project

Thanks @CAPCHIK


Make pc.SceneRegistry public

Fixes #1948
PR contains the following changes:

Rename undocumented pc.Application property _sceneRegistry to scenes
(just like pc.Application#assets which references pc.AssetRegistry).
Make pc.SceneRegistry and pc.SceneRegistryItem public.
Add documentation for pc.Application#scenes.
Add documentation  for pc.RegistryItem properties.

I confirm I have signed the Contributor License Agreement.

Updated PR based on feedback from issue thread:

Mark old scene functions (in pc.Application) as private and deprecated (to discourage new devs).
Add console warning (if debug build) in deprecated scene functions (to encourage switch).

Hey @vkalpias - I think your review is probably the most authoritative here. The one thing I'm thinking is that we'd have to update and deploy the Editor at the same time as this PR. Because we would want exported apps to use the functions on the pc.SceneRegistry instead of pc.Application. That said, exported apps use the release engine so no console warnings will appear.

Hey @vkalpias - I think your review is probably the most authoritative here. The one thing I'm thinking is that we'd have to update and deploy the Editor at the same time as this PR. Because we would want exported apps to use the functions on the pc.SceneRegistry instead of pc.Application. That said, exported apps use the release engine so no console warnings will appear.

Well this only seems to change the internal _sceneRegistry to scenes. Don't see any other changes that would affect the Editor.

Oh I see what you mean - all the new Deprecated messages. Yeah not sure we need those can't we just keep the old functions without deprecating them?

No, because they're duplicates and it makes for an ugly API. 😁  Like I say, I don't actually think it's a big deal because you can't publish with the debug engine. But we should, for correctness, update the generated app to use the new API.


[TASK] Bayesian Optimization

Issue Description
Is your feature request related to a problem? Please describe.
For some analyses, the model is computationally expensive to evaluate. This results in the existing optimizers (GA and Gradient Descent) within RAVEN exhibiting undesirably long run-times due to the number of model evaluations.
Describe the solution you'd like
For this class of problems, Bayesian Optimization is frequently recommended for its ability to conduct 'black-box' optimization with iteration efficiency. This is done by utilizing a surrogate model in the decision of sample points.
Describe alternatives you've considered
None

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ x] 1. Is it tagged with a type: defect or task?
[ x] 2. Is it tagged with a priority: critical, normal or minor?
[ x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Approved to close via #2123


Missing gene information

Hi,
I'm a bit confused. Is SanntiS only designed to predict BGCs themselves, without predicting the genes within these clusters? Because the output files appear to only contain information about the predicted BGCs, without any gene-related information. Many other BGC detection tools, such as AntiSMASH, DeepBGC, and GECCO, typically include one or more GenBank files that contain information about the genes within the predicted BGCs. Is there a way to get the gene information using SanntiS?

Hello,
Thank you for reaching out. Let try to clarify this
SanntiS does indeed predict BGCs and also provides information about the genes within these clusters. The main outputs you can expect from SanntiS are:
A GFF file which contains the coordinates of the predicted BGCs. This file includes details like the most probable class of each BGC and the most similar known BGC from the MIBiG database, which can give insights into the potential function of the predicted BGC.
Alongside the GFF file, SanntiS generates a file with a .prodigal.faa extension. This file contains the predicted genes within the BGCs and the sequences of proteins that these genes are expected to encode. So, while the GFF file gives you the location and possible function of BGCs, the .prodigal.faa file gives you the specifics on the genes and proteins that are part of these clusters.
Additionally, a .prodigal.faa.ip.tsv file is produced by running the protein sequences through InterProScan, which provides functional annotations of the genes predicted by SanntiS. This means that not only do you get to know what genes are present, but you also get information on the potential functions of these genes based on known protein domains and features.
So, in summary, SanntiS does cover both BGC prediction and gene/protein prediction within these clusters. If you're looking for gene-related information, you'll find it in the .prodigal.faa and .prodigal.faa.ip.tsv files.
I hope that helps.
Let me know if you have any other question.
Santiago

Thank you for the explanation, it helped a lot.


Make secrets client honor namespace

All other clients take the namespace from the constructed client, not the passed object.

I am afraid to ask how you found that bug, but good catch.  LGTM and will merge in morning if no other takes it before then

https://github.com/openshift/origin/pull/1208/files#diff-3999d64b0b8fa9423b47f9feb61db2b0R720 didn't work so well when the client ignored the namespace

@liggitt good catch


Prevent access to HttpContext throught HttpContextAccessor in TryRefreshAsync

Looks good, but need to figure out the destination branch.


Transfering ownership of image-core

Hi!
I have registered this crate after proposing image-rs/image#793. To whom should I transfer the crate ownership?

Could you transfer the ownership to be the same as the main image crate? Thanks!

Done! Note that I am not able to add girhub:image-rs:publish, so you will have to do it yourself


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2023-03-21)
Features

完成侧边栏数据、添加header (30da772)
完成左侧状态栏mock数据交互 (22898ba)

Styling

Format code with prettier (1211219)
Format code with prettier (f44be47)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/School-of-Website-Engineering/future-front-end/releases/tag/v1.2.0 :sunflower:


Getting 404 with example code

I'm evaluating this library and the examples work so far when I provide username and password on the commandline. But starting from example.js I don't have any success with my own 'code'
#!/usr/bin/env node
var teslams = require('teslams');
var util = require('util');

// Config
var config = {
    creds: {
        username<EMAIL_ADDRESS>        password: 'mypassword'
    }
};

// Generic callback function to print the return value
function pr( stuff ) {
    console.log( util.inspect( stuff ) );
}

console.log(config.creds);

teslams.get_vid( { email: config.creds.email, password: config.creds.password }, function ( vid ) {
    if (vid == undefined) {
        console.log("Error: Undefined vehicle id");
    } else {
        teslams.get_charge_state( vid, pr );
    }
  }
);

Results in:
{ username<EMAIL_ADDRESS>password: 'mypassword' }
[Error: 404: 404]
[Finished in 1.7s]

Any advice?
(Password and username changed for this report of course)

Your code is not setting the email parameter correctly. Change config.creds.email to config.creds.username. As it is now that is a null value, hence the 404 error.

This was an error with the bugreport only. Unfortunately my original statement was false. the examples/example.js gives me a 404. Does the example (still?)work for you?

example.js works for me as does the code you posted with the one change I suggested.


Sample app does not handle exit/quit/close

Hello,
The sample app does not seem to handle the phrases "Exit/close/quit" even though these are required for certification. Whats more, even if you do add these to the sample utterances and test out on developer.amazon.com, it does not seem to work at all:
AMAZON.StopIntent exit
AMAZON.StopIntent close
AMAZON.StopIntent quit

Also, just testing this on Lambda, with a Alexa End session with edited App ID fails with the message:
{
  "errorMessage": "No 'Unhandled' function defined for event: Unhandled",
  "errorType": "Error",
  "stackTrace": [
    "AlexaRequestEmitter.EmitEvent (/var/task/node_modules/alexa-sdk/lib/alexa.js:140:15)",
    "AlexaRequestEmitter.HandleLambdaEvent (/var/task/node_modules/alexa-sdk/lib/alexa.js:110:23)",
    "AlexaRequestEmitter.Object.defineProperty.value (/var/task/node_modules/alexa-sdk/lib/alexa.js:72:31)",
    "exports.handler (/var/task/index.js:34:11)"
  ]
}

EDIT: Similar to : https://forums.developer.amazon.com/questions/5938/error-with-utterances-quit-exit-remote-endpoint.html
EDIT2: The sample app does handle stop but apparently this is not sufficient for certification
What could the issue be?
@PaulCutsinger
@deegles

Hey @TDA @PaulCutsinger @deegles - I encountered this issue when trying something with the alexa skill sample at a hackathon, couldn't find a way out once I'd got into the error - are there any updates on this?

 There is an article on the forums for this, apparently this need not be supported: https://forums.developer.amazon.com/forums/thread.jspa?threadID=8941&tstart=0
But the reviewers dont seem to know that. :\

Your app might need to respond to an Unhandled option as a possibility for Intents.
Unhandled() {
    this.emit(':ask',
      `I\'m sorry, but I\'m not sure what you asked me.`
  },

I found this out when I misspelled an intent and the app didn't know how to process the request.

I have this function in the code, it still seems to be stuck!

I found the error in my code, I was missing:-
the "Unhandled" function at first then i was missing
module.exports = handlers;
in the intentHandlers.js

Exit is a command baked into Alexa.
If you receive this error when saying 'exit'

No 'Unhandled' function defined for event: Unhandled

You need to add a handler to capture exit:
'SessionEndedRequest': function () {
  console.log('session ended!');
 }

@JennJin I see that you have closed a bunch of issues today, is there an official way to handle this? I would like to see a response from the core team on what the right way to solve this is, before closing it out.

@TDA, sorry for the confusion. I've been asked to go through and close out 'old' open Issues.
I closed this one because it's not an issue with the sample code.
"Exit" and "Quit" are reserved words for a 'hard exit' on a Session. They route to a System Intent that immediately ends the current session. The skill will receive a "SessionEndRequest" with the 'Reason' = "USER_INITIATED".
"SessionEndRequest" Request Type
So you don't need to handle for "Exit" and "Quit".
Sending a response to a Request Type of 'SessionEndRequest' will result in Alexa replying back with an error that appears in your CloudWatch Logs.
It would be great to continue the discussion on the Alexa Developer Forum .

@JennJin Thanks for the detailed explanation :) That is pretty much what I expected, it appears that the certification team isn't caught up with that yet. I will continue the discussion on the forums. Thank you!

Hey Guys that's a very genuine question. I figured out if you add "SessionEndedRequest" intent before your "LaunchRequest" intent(You can put it anywhere though) and inside it just have "this.emit(':responseReady')" and nothing else. Works fine.


[Bridge] Is there a way to guarantee in what order set#propName will be called in a view

Currently implementing the solution for #1442 proposed by @brentvatne. Tried asking in IRC several times, but got no response.
While I'm at it, here's the current planned (and almost complete, barred by the interaction between changing from local urls to remote urls and etc.) api

// Will load the contents of index.html, with relative paths being resolved from /folder
<WebView baseUrl = {"/folder"} url = {"index.html"} />

// If the contents of index.html were '<script src="index.js"></script>' this would be equivalent.
// It will load folder/index.js
<WebView baseUrl = {"/folder"} html = {"<script src='index.js'></script>"} />

// Also equivalent to the above
<WebView url = {"file://folder/index.html"} />

For this I need baseUrl to be resolved before both url and html, and I have found no way to do this explicitly, either by ordering the exported macros or passing the props in the correct order(which is not ideal anyway)

Don't really see a way to implement this without explicit ordering of the props. Pausing development on this until someone can tell whether this is possible.

Was told there was no way to do this, there might be another solution though.

An example of how you might do this @JohnyDays:
- (void)setHtml:(NSString *)html
{
  _html = html;
  [self applyHtmlAndBaseUrl];
}

- (void)setBaseUrl:(NSString *)baseUrl
{
  _baseUrl = baseUrl;
  [self applyHtmlAndBaseUrl];
}

- (void)applyHtmlAndBaseUrl
{
  if (_baseUrl != nil && _html != nil) {
    // set them on the webview
  }
}

I need to deal with the transition between html/baseUrl to File/baseUrl to html/no baseUrl to file/noBaseUrl(in this case I am infering the base url from the file path) to remoteUrl
And having an html(inline) property defined makes url navigation broken, since I can't point the url to a file or remote uri

@JohnyDays - maybe it's easiest for us to collapse all of these options into a source prop?

@brentvatne That would be ideal, although it would change the current api. I'm not sure how much impact that would have

@JohnyDays - let's do that, leave the existing API in place and submit a PR then get some feedback on it - maybe we can leave those props in for a while and deprecate them after a few versions if we decide to go in that direction

My IRC isn't working properly, after a few minutes of being logged in I stop both being able to write and read messages, gonna try to fix it soon.
Anyway, I'm implementing it with a source object right now.

Thanks @brentvatne, your suggestions really guided me towards making this work properly. I was clearly overthinking it. However there's still a few edges to be roughed out, should I submit a working, but unpolished pull request to gather feedback?

@JohnyDays - sounds like a great idea :smile:


Add type-checking build step for Python code

Add a type-check step, such as with mypy, to check for common issues such as incorrect types/unused variables before building/publishing.

Added mypy type-checking in 993182780adc01eb50bfbc000bd049176f65eab0


check and log ulimits on startup

We would like to check the current ulimit for our Couper process. Especially in docker environments this information could be very helpful.
Check and log the current and max system settings. If the number is below a constant threshold, lets start with 4096, log as warn level.
Implementation could take place within the run command.

@malud the tests fails on my machine when i run make test even when i have not updated the codebase, are there any software/dependencies i need to install on my machine to make the tests pass ?

@malud the tests are still failing on my machine

@malud i just updated the PR, everything is now working fine


Can't require image with spaces, etc. in filename

Issue Description
React-native asset server struggles with images that have spaces in the filename; any non-URI characters I'm assuming. Obviously close if this is by design. Here's a recreation (index.ios.js only)..
Steps to Reproduce / Code Snippets
<Image source={require('./im/spaces in name.jpg')}/>
Expected Results
Server:
Error: Asset not found: im/spaces%20in%20name.jpg for platform: ios
    at _findRoot.then.then.res (/Users/alexpaterson/Desktop/testImage/node_modules/react-native/packager/react-packager/src/AssetServer/index.js:155:17)
    at tryCallOne (/Users/alexpaterson/Desktop/testImage/node_modules/promise/lib/core.js:37:12)
    at /Users/alexpaterson/Desktop/testImage/node_modules/promise/lib/core.js:123:15
    at flush (/Users/alexpaterson/Desktop/testImage/node_modules/asap/raw.js:50:29)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Additional Information

React Native version: 0.35.0
Platform(s) (iOS, Android, or both?): iOS
Operating System (macOS, Linux, or Windows?): macOS

Added PR

fixed in https://github.com/facebook/react-native/pull/10365


new(website): add v0.34.0 to params.yaml

Signed-off-by: Luca Guerra<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind content
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area documentation
What this PR does / why we need it:
Update the website for Falco 0.34.0
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
Once this PR has been reviewed and has the lgtm label, please assign issif for approval by writing /assign @issif in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 5534c73157d11c050be1d186a8d9c1a09973e9d3


redesign the frontend with react

it is teadious to implement firebase with vanila js, as need a webpack bundler and lots of configuration.
I suggest to redesign the frontend with reactjs, so it will be easy to implement the firebase backend

Hey @IswarPatro , thank you for the interest but @Bhanu-code has raised the issue first so I would like to know if he would like to work on it, if not I have no issues assigning the issue to you. :)

not a problem, assign him, if @IswarPatro is interested do this. I will make another issue for backend integration after he submits the PR for this issue.

Awesome, Assigning the issue to @IswarPatro, Good luck!

What is currently happening in this project?
Is redesigning the front end using react currently going on?

@IswarPatro Is currently working on it, Any update ? If the issue goes stale, I will reassign it to you if you want?

Ok


0.96 Inch was Ok But Wrong Operation on 1.3 Inch

I loaded SSD1306ClockDemo to ESP8266 with 0.96 Inch OLED based on SSD1306 driver. that was ok,
and i tried it to 1.3 Inch OLED based on SSD1306 driver. But It did not work properly. that is.
screen was distorted.
I think that resolution of display does not matched your library.
Please let me know how to solve it.

You need to add more information to let us help you. Please attach an example that is working on the 0.96 inch oled but noch on the 1.3 inch oled and please specify the used hardware some more. You can reopen this issue.


Improve rule files validity checking

Motivation
Currently, if some properties are misplaced within the rule's document (ie. the YAML file), no warning is emitted and non-obvious side effects can occur (here an example regarding required_engine_version property).
Feature
The rule loader should emit warnings or errors when a node in the document contains unexpected properties. Further validity checking is desirable too.
Alternatives
Do nothing?
Additional context
This problem was discovered by working on #1273. It was initially considered a bug ( #1315 ), but it can actually be considered a missing feature, IMHO.
/area engine

Interesting https://github.com/falcosecurity/falco/issues/1338

Another example :point_right: https://github.com/falcosecurity/falco/issues/1379

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/cc @mstemm

/cc @mstemm

/remove-lifecycle stale
/milestone 1.0.0

/remove-lifecycle stale
/milestone 1.0.0

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen
/remove-lifecycle rotten

@leogr: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen
/remove-lifecycle rotten

@leogr: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
/cc @jasondellaluce

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle rotten

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

@jasondellaluce

/remove-lifecycle stale
/milestone 0.34.0

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
/milestone 0.35.0

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/milestone 0.36.0

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/remove-lifecycle rotten
/reopen

@jasondellaluce: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cc @loresuso

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

can we define concrete next steps here?

cc @jasondellaluce

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
cc @LucaGuerra (since you recently worked on the rules override feature, perhaps you have some thoughts about this too)

/help

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

/assign
cc @LucaGuerra @FedeDP @jasondellaluce
Let me know if you have any ideas. I think this is somehow tied to https://github.com/falcosecurity/falco/issues/3149
If we have a schema, we can validate the rules file against it.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

More recent thoughts on this issue:
By autogenerating a JSON Schema file from Falco and using it for validation and linting, we can ensure that rules files adhere to the expected structure and syntax. This will help catch errors early and maintain high-quality, consistent rule files.
The schema file is also required by the Playground (see https://github.com/falcosecurity/falco/issues/3149 )
Thus, the goals of this issue should be:

Autogenerate a JSON Schema file from Falco.
Implement schema-based validation for rules files.
(optionally) Enable CI linting for rules files using the generated schema (see https://github.com/falcosecurity/rules/pull/238 )

/assign
/assign @FedeDP

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten


bugfix: [SEO/Shows] Fix 404 link back to inactive fairs

Addresses fairs portion of https://artsyproduct.atlassian.net/browse/GRO-208
We were running into an issue where after a fair has run and is no longer listed, links back to the fair from shows within the fair 404 leading to an SEO hit. This PR hides the link back.
cc @artsy/grow-devs

@The-Beez-Kneez - Gonna merge since you're out for the rest of the week!


[macOS] Install virtualbox on macOS-11

Description
Installation VirtualBox on macOS-11 via brew.
Added AppleScript to approve VirtualBox developer in security preferences of OS.
Execution of commonutils.sh moved to section before Xcode installation in macOS-11 template, because we need reboot system after VirtualBox installation.
Related issue:
internal #2672
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@Neilpang unfortunately, no. It's not yet ready

@miketimofeev   Thanks.
Is there anything can be done to make this PR merged earlier ?

some customers use macos runners to run UI tests and they need such an ability.

I believe it's much better to unblock some VirtualBox users (those who do not need UI tests) than to block 100% of your VirtualBox users.
Are you open to reconsidering the current approach of removing VirtualBox completely?


'upradable' typo for 'upgradeable_dependents'

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

In reference to #6712

looks like a minor bug was introduced in #6698
thanks for the fix!

Thanks so much again for your contribution!  You rock, @papz!

Thanks for the fix!