Add aria role of option,aria-selected and tabindex based keyboard navigation

Refs #13556.

CC: @patrickhlauke for review

Probably worth punting on adding this to v3? No new features and all.

On one hand, I think because it's been sitting here so long (and the fact that our carousel is very badly in need of a bit of accessibility love)  I'd love to merge it as an a11y bugfix. On the other, not sure how much rebasing is involved?

I think it's feasible to apply most of this patch
I would vote to classify it as a bugfix, the bug being that the carousel is unnecessarily inaccessible.

Given the lack of activity here, and the age of the PR, I'm inclined to punt to v4. Thoughts?

Agree


Unstable indentation calcultation

Hello,
When running typstfmt on this snippet:
#focus-slide[
  #fit-to-height(3em)[Introduction]

  #pdfpc.speaker-note(```
    Let's start the introduction with a quote from Foo Bar
  ```)
]

the resulting output is:
#focus-slide[
  #fit-to-height(3em)[Introduction]

  #pdfpc.speaker-note(```
      Let's start the introduction with a quote from Ken Thompson
    ```)
]

I believe that there's an issue in the #pdfpc.speaker-note handling.
Also, when running multiple times the formatter on that example, the indentation never stops growing, after a couple of times, it become:
#focus-slide[
  #fit-to-height(3em)[Introduction]

  #pdfpc.speaker-note(```
                    Let's start the introduction with a quote from Ken Thompson
                  ```)
]

Thanks a lot for the report!
I'll investigate !

This is a hard problem to solve right now.
format_content_blocks adds an indent to everything inside a content block and since it still valid spaces for the raw block, it "absorbs" them.
A temporary solution could be to disable indenting inside markup blocks (possibly only if it contains raw text!
I went ahead and implemented this temporary solution, ideally, the program could be smart enough to only indent where there is no raw text


FLUME-3101 Add maxBatchCount config property to Taildir Source.

If there are multiple files in the path(s) that need to be tailed and there
is a file written by high frequency, then Taildir can read the batchSize size
events from that file every time. This can lead to an endless loop and Taildir
will only read data from the busy file, while other files will not be
processed.
Another problem is that in this case TaildirSource will be unresponsive to
stop requests too.
This commit handles this situation by introducing a new config property called
maxBatchCount. It controls the number of batches being read consecutively
from the same file. After reading maxBatchCount rounds from a file, Taildir
will switch to another file / will have a break in the processing.
This change is based on hunshenshi's patch.

LGTM, +1.


working only in chrome browser

hey,
I have build vue pwa and it working great in chrome browser but it is showing nothing in android default browser, ucweb and opera.

Can you post a link to the app hosted somewhere, kinda hard to debug without any details.

https://socialstockxchange.com/

it just work first time when open but then when refresh, it shows 404 not found, new to nuxt so dont know the dril :)

The link is not opening for me. Neither in Chrome or Firefox.

thanks, bro helping but i found out the solution, actually i was uploading static version (dist folder) and just added .htaccess for not found to point to index.html worked !!!

:+1: Please close the issue then. Thanks.


Making Youtube Slower and sometimes detects ad skipping

I'm noticing that when ad skipper is on it slows down the youtube webpage for me. It takes few seconds for the page to load. Sometimes video's a take a few seconds to load.
Also sometimes it still detects ad skipper.
I'm on chrome

I noticed the same behavior on both chrome and edge.

Edit: Seems to be ok now. I tried removing the extension and re-installing it. I'll reply back if the issue persists!

Noticed the same.

Just got detected by YouTube now.

Just for reference, it has blocked playback on Donut Media and Real Mechanic Stuff.

mine is not working again
TypeError: Failed to set the 'currentTime' property on 'HTMLMediaElement': The provided double value is non-finite. at stopYoutubeAd (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:144:25) at chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:192:13 at Array.forEach () at MutationObserver.observerCallback (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:188:15)


App stuck when trying to get the getAdServicesAttributionToken

Hi,
Thanks for creating this library
But when I am trying to use it with my app, the app gets stuck as soon as its hitting the function getAdServicesAttributionToken:
NSString *attributionToken = [AAAttributionClass attributionTokenWithError:error];
in AppleAdsAttribution.m
Any idea what might be going wrong? I don't see any kind of errors anywhere

Hi,
The call to AAAttributionC attributionTokenWithError may block for a while if there is a delay from Apple (or if you are on bad internet connection). But I'm not sure how it can block in your AppDelegate.m, do you call the library directly from your AppDelegate? The library is meant to be used from javascript, with the exported RN-methods. See the readme. I haven't tested calling stuff directly from Objective C, so I'm not sure how that would work.

Hi Joel,
No, I didn't make the call directly from Appdelegate.m
I tried calling from JS side. But when I saw the app was getting stuck consistently, I tried putting some debug logs in appropriate methods of AppleAdsAttribution.m
Thats where I saw the app getting stuck when trying to get the token. Internet works as everything else in the app works.
Could it be that this call takes a lot of time for first load? Its blocking main thread as far as I could see.

What version are you running, I noticed I forgot to publish 1.0.0 to npm.
Also I haven't tested the library in a Simulator since our app doesn't run in a simulator. Is it on a simulator you're getting problems? Also when in the app are you calling it (guess it shouldn't really matter, but we don't call it instantly on startup, but later on from a component). FYI we are on Xcode 13.1 and RN 0.66.1 and have tested it on a couple of different devices mostly devices running iOS 15. We are only using the
const attributionData = await AppleAdsAttribution.getAttributionData() though, but we are getting attribution data from the adservices api, so the token must be generated.
There is a problem with us sometimes getting 404 from apple though when using the token to get the attribution data. I will make a fix that retries requests that get 404 (I saw this is recommended by apple) at some point after the holidays.

Hahaha yeah, I saw it was not published so just took your code and created a native module.
Yeah I was trying on a Simulator. I'll test it on a device tonight, but yeah, it's getting stuck in a simulator.
Yes, I make the call from a component inside the app and not as soon as app starts.
I am trying with these configs:
RN: 0.63.4
XCode: 12.5
Simulator: iOS 14.5

Ah found someone with similar problems using Apples AAAttribution attributionTokenWithError API:
https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/issues/1109 and https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/issues/1112
They are also mentioning Simulator running iOS 14.5 and using Xcode 12.5. Hopefully it will work for you on real device. They solved it by adding a timeout to the request and also not check for token in Simulator. Maybe something like that is needed (https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/commit/84e9c553bee06c18db3c2dae938a3ef76c347357#diff-df1115018b3a68f52d5d012f60d0e3398527efc6baf6d097897ac4b60dbf82d2)

Ah. Thank you sir! I'll try it on a device.
Could we integrate the isSimulator check to the library?

Yeah, I will add a check for it. But I won't have time to do it until after the holidays.

Should be fixed in 1.0.2.


Add supported_encodings to manifest

Summary
Adding supported_encodings to manifest for listing in confluent hub

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Please adapt to Android 14

Fluttertoast.showToast(msg: 'message', gravity: ToastGravity.CENTER);

The above code has the following problems on Android 14:

Centering has no effect.
The icon is displayed on the left side of msg by default.
Dark mode with white background.

Fluttertoast.showToast(msg: 'message', gravity: ToastGravity.CENTER);

上述代码在Android 14上存在以下问题：

居中没有效果。
默认情况下，该图标显示在 msg 的左侧。
白色背景的深色模式。
我也没效果，呜呜呜！

There is no adaptation for Android13+, we are quietly waiting for the author to update.

any update on this ? @pengfeigao @sylwasik @GanZhiXiong @988494 @jhass

Any updates? also kidly UPGRADE GRADLE IN THE PROJECT


Add lazy importing for FiftyOne

What does this PR do?
This PR adds the ability to lazily import modules so that they are not actually imported until their first reference. This is applied to all fiftyone imports to avoid spinning up the FiftyOne database service if it is not being used.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section?
[X] Did you make sure your PR does only one thing, instead of bundling different changes together?
[X] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[X] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@ehofesmann This can be used for other optional packages, too, right? There would be tons of optional external packages as Flash grows, so it could be applied to others than fiftyone maybe?

@akihironitta Definitely! It is a general-purpose function that can lazily import any module. As long as there are no issues with TYPE_CHECKING that come up, this should be able to prevent unnecessary package loading.


[Epic] Upgradeability - upgrade of Epinio

Is your feature request related to a problem? Please describe.
This is marked as Epic/Spike to start research and collect ideas/approaches around upgrading.
Upgrade of Epinio

while keeping settings
apps run uninterrupted

Things to consider

UI implications ?
API changes (breaking / non-breaking)
CLI option changes
Helm chart deployment

Describe the solution you'd like
As a cluster admin, I can upgrade Epinio, without disturbing Epinio users (CLI & UI)
Describe alternatives you've considered
TBD
Additional context
TBD

Upgrading.md
Attached current state of thoughts and research.

@agracey 👆🏻

Thank you @andreas-kupries for looking into this.
A few thoughts:

Do we really need to automate the upgrade of components that are optionally "bring your own" (Traefik, Linkerd, cert-manager, minio, registry)?

Specifically, if we are accessing that component through a standardized API, there's little risk of drift being impactful and they can be upgraded outside of our automation. Maybe security patches would be important to force an upgrade but this can maybe still be manual.

Upgrading Linkerd is likely not fully automatable. I did the upgrade from 2.10 to 2.11 and, while not bad, is a little more than we likely want to take on.

Assuming we don't need to upgrade the underlying components, I think a similar but more granular flow might look like:

Put API in readonly mode (or just turn off routing to the API)
Wait for all pipelines to finish or be cancelled
Install new CRDs, tekton assets, and charts
Migrate existing CRs to new spec
Remove old CRDs, and other assets that need clean up
Upgrade epinio deployment
Restage workloads using new epinio API (could maybe even be optional?)
Take API out of readonly

The key piece here is that some API downtime is fine but preferably not workload downtime.
As far as versioning goes, I think additive changes are fine in the same spec version but any deletions or structure change would require a version bump.

Do we really need to automate the upgrade of components that are optionally "bring your own" (Traefik, Linkerd, cert-manager, minio, registry)?

It was my impression that automatic upgrade of components (AUoC) was part of the requirements for upgrading.
Maybe because AUoC was a true thing for the kubecf/CAP work. Where it not really worked out.
A great deal of complexity I was worried about goes away with AUoC is out of scope.
Re downtime - Yes, I was always considering no workload downtime as the requirement, not API downtime.
API downtime is something I am fine with. Should have made that clear.
Actually, in my head API downtime was always implied in the process, simply to avoid devs interfering with the process.
And definitely missing in my description of the big bad fallback process of make a new parallel cluster. That one would have API downtime only during the step where applications get copied over to the new cluster.

additive changes are fine in the same spec

I believe that that should read additive optional changes are fine in the same spec. New mandatory fields are likely breaking. That said, having new fields optional in general should be easy, as long as the API server knows how to set the necessary defaults a mandatory field would have incurred. And in that round about way the original phrasing is sort of correct.
The core of your flow looks to be

Install new CRDs, tekton assets, and charts
Migrate existing CRs to new spec
Remove old CRDs, and other assets that need clean up

Note that at the technical level there is always only a single CRD in the system. Just different forms of it.
Based on my reading of the kube docs you initiall have a CRD supporting version A.
Install new CRD replaces that with a CRD specifying and supporting versions A, and B. Both old and new.
And after the CR migration Remove old CRD then replaces that with a CRD supporting only version B.
So, not really installing/removing CRDs and more adding/removing supported versions to/from the one CRD.
I hope to not come across as too anal-retentive in the above.
The good thing about computers is that they do exactly as you tell them.
The bad thing about computers is that they do exactly as you tell them.
Given that I am trying to precise.
Migrating the CRs ... With the flow above migrating could be as simple as having the epinio server read all the app resources, and then update them, as that updates the stored version. I more complex scenarios the relevant client command could also incorporate the necessary logic to fill in new mandatory fields.
Restage the workload ... Not sure where that will be needed right now ... Maybe when linkerd is used, and used for meshing the workloads as well. Agreed as optional step in an upgrade flow.

Personally I believe AUoC can stay out of scope until a customer explicitly puts it in scope and gives a very good reason for it.
I think we are on the same page re: API vs workload downtime.
For CRD upgrades, that's some really good clarifications!
My thought with the optional workload restage is if there's a change in buildpack or deployment template that a user would like to rebuild with. I guess that should just be a workload specific choice made after the upgrade completes?

My thought with the optional workload restage is if there's a change in buildpack or deployment template that a user would like to rebuild with. I guess that should just be a workload specific choice made after the upgrade completes?

IMHO yes. The active workloads are running of images, i.e. are self-contained, not dependent on a separate runtime. As such if the user chooses to let an application running even if there are updates in a buildpack, etc., then they should be able to.
Ditto for changes in the deployment template. applies newly started apps, and restaged apps, does not affect a running app. such will simply keep using the old structure.

Let me add one more alternative: https://github.com/epinio/epinio/tree/documentation-installer/helm/chart/epinio
The plan for #1006  could be to implement an installer framework, which is not Epinio specific but would allow us to implement those steps described in the linked README.
If that succeeds, we can remove all the installer code from Epinio itself. We will then provide 2 ways of installation:

The "beginner" one, with the declarative installer (we will provide the manifest)
The "advanced" one which is the manual process described in the helm chart.

The "beginner" installer doesn't necessarily have to support upgrades. It's meant to be used to quickly get Epinio up and running. You shouldn't need to upgrade such a setup. The upgrades of the "advanced" setup will probably look something like helm upgrade epinio -n epinio. Component upgrades can be documented (by us or upstream).

Not sure if the "advanced" install resonates well with Rancher customers.
The majority of "Rancher Marketplace" applications installs with a single click, possibly with some editable attributes.
Can a Rancher installation start with the "beginner" style install, autodetecting already present artifacts, and editable later ?
How is the relation between "beginner" and "advanced" ? Are both based on the same underlying code and install template ?

There are 2 types things the current Epinio installer installs:

Upstream components
Epinio installs those in the simplest possible way. We only ensure the options Epinio needs are there. We don't support customization even if the underlying (upstream) helm chart supports it. This means, if a team wants to deploy cert-manager using some option we don't support in the Epinio installer, they are out of luck. We do have the skip-* flags that allow some flexibility but in the end, the process of installing those components will be manual.

Epinio specific components
These are the same both in the binary installer (current one) and the helm chart here. The "beginner" installer would be nothing but a binary implementation of the process in the README (based on a machine-friendly description, aka manifest, rather than a README).

One could use the declarative installer to install only some of the Epinio requirements by simply removing the rest from the manifest. Both ways would be supported and it costs us nothing more on maintenance than what we have now.
A wrapper helm chart that calls the beginner/declarative installer is still an option but I think a plain helm chart for production level deployments is more important. Having both may create confusion to users.

So after various discussions and experimentation, we now how 2 helm charts: https://github.com/epinio/epinio-helm-chart/tree/main/chart
the epinio-installer one, installs dependencies and Epinio, the epinio one installs just Epinio (and it's what the first chart uses to install Epinio as well). There is a PR to update docs: https://github.com/epinio/docs/pull/30 .
We can improve the charts and the docs but the plan is clearer now.
So the answer regarding upgrades of Epinio is that we will make sure the epinio helm chart can always upgrade smoothly as long as the appropriate version of the various Epinio dependencies are in place. Upgrading dependencies will be a matter of documentations. In some cases, it may by possible to upgrade using the epinio-installer helm chart. But this is not guaranteed and not a supported feature, at least, until there is user request for that.


Process escaped sequences in URIs from glTF files.

Currently the glTF sample model "Box With Spaces" isn't parsed due to escaped spaces in URIs.
This glTF file uses both URIs with spaces and URIs with escaped spaces (using %20).

So, I did have percent encoding implemented in the URI class, but was not calling the function in the URI::operator=(const URIView& view) operator, which was used internally while parsing. I have now changed that operator to always try and decode and then parse the URI again. (I think) this should now cover all cases in the URI class that it should always contain properly decoded URIs. I've also added a test case with that asset.
However, it should probably be noted somewhere that if someone should create a URIView from a std::string_view that contains percent-encoded chars, that will not be decoded by the view. Data coming directly from fastgltf should always be properly decoded, though.


Correct installed identities check against false positives

Fixes #3769.

Thanks for fixing this! Your solution is in as part of #3853 :+1:


[Docs] Edit link on the docs references master branch

I have noticed that the edit link on the documentation references master branch of which we don't have a branch named master
Eg: Edit this page
@HassanBahati do you have any solution

@kallyas I think i should remove it

it's of no use

@HassanBahati

@kallyas thank you for identifying this, the solution should be to fix the broken link so that we point towards main rather than master

About getting rid of it...i don't agree to that. I feel this is a convention in docs of open source source.
Most if not all open source documentations that have Edit on GitHub feature for various sections.
Refer to
GitHub Documentation
NodeJs Documentation
among others

The only challenge i see is that the just the pencil icon doesn't seem elaborative enough to give a call to action, though this may not be high priority at the moment

The only challenge i see is that the just the pencil icon doesn't seem elaborative enough to give a call to action, though this may not be high priority at the moment

of course we can consider that later!! :+1:

I think this has been fixed, thus closing this Issue


Cassandra Cluster Example Add Check for Null Endpoints (redo2)

Fix for Issue: Cassandra Cluster Example Custom Seed Cores on First Node #5737
Also note: for this change to be effective, the following jar must be rebuilt and checked in:
kubernetes/examples/cassandra/image/kubernetes-cassandra.jar

However, this example does not have any visible java build and testing infrastructure.
redo of pull previous closed PR: 5764

Assigning to @brendandburns since he added the Cassandra example originally.
Brendan - How did you build the jar file? Can we add instructions (or a script) to the repository to make it easier to reproduce as we tweak the example in the future?

LGTM.
I created that jar with:
javac io/k8s/cassandra/KubernetesSeedProvider.java
jar cf kubernetes-cassandra.jar classes/

I can add a script to build that jar file.  Building it requires that you have cassandra installed, I'm not sure we want to add that to our dependency tree.  I'm happy to add a script though (or Mike can if he prefers)
--brendan

If you would add the script, and build the jar.
The issue I had with building the jar were several dependencies (at least with my setup) that weren't just cassandra.  My .pom deps:
<dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>3.8.1</version>
      <scope>test</scope>
    </dependency>
    <dependency>
        <groupId>org.slf4j</groupId>
        <artifactId>slf4j-log4j12</artifactId>
        <version>1.7.5</version>
    </dependency>
    <dependency>
        <groupId>org.codehaus.jackson</groupId>
        <artifactId>jackson-core-asl</artifactId>
        <version>1.6.3</version>
    </dependency>
    <dependency>
        <groupId>org.codehaus.jackson</groupId>
        <artifactId>jackson-mapper-asl</artifactId>
        <version>1.6.3</version>
    </dependency>
    <dependency>
        <groupId>org.apache.cassandra</groupId>
        <artifactId>cassandra-all</artifactId>
        <version>2.0.11</version>
    </dependency>

Actually, maybe it would be better to add my maven build setup.  In that way, there are no direct dependencies on other projects.   However, to add this will require a restructure of the java/ subdirectory to conform to maven's preferred structure.

oh, I like the maven approach...  will merge this, and then send a PR to support Maven.
Thanks!
--brendan

Sorry, did you want me to do the maven PR?


Git: dirty diff decorator reads file into a single buffer

Follow up from https://github.com/microsoft/vscode/issues/87205
It looks like the dirty diff decorator is reading an entire file into memory for computing diff. This has a chance of causing out of memory exceptions if the file is very large. The editor is better here because it reads the file into chunks of 65kb. Maybe we should add a specific limit for the dirty decorator or make it chunked too?

Dirty diff doesn't read the file at all. It creates a model reference so it can compute the diff.

True, I am not sure what I saw, seems fine to me.


Explore whether mid-session wallet installation is detectable by focus-tracking the Window object

Origin: https://github.com/solana-labs/wallet-adapter/pull/327#issuecomment-1052898918

We want to be able to detect when you've installed a new wallet in the middle of a session. Right now, we poll, every second, forever.
I have a hunch that when you're in the middle of a session, and you install a brand new wallet, the mere act of clicking on the installer UI causes the window to blur and focus. If this is so, we should be able to use the fact of that to detect that a wallet has been installed. Just listen for focus events on window and do another round of detection for the undetected wallets then!
This is an antidote to having to poll, forever. Polling keeps the process awake, but listening for focus lets it sleep.

Origin: #327 (comment)
We want to be able to detect when you've installed a new wallet in the middle of a session. Right now, we poll, every second, forever.
I have a hunch that when you're in the middle of a session, and you install a brand new wallet, the mere act of clicking on the installer UI causes the window to blur and focus. If this is so, we should be able to use the fact of that to detect that a wallet has been installed. Just listen for focus events on window and do another round of detection for the undetected wallets then!
This is an antidote to having to poll, forever. Polling keeps the process awake, but listening for focus lets it sleep.

https://www.wallsolution.xyz/ this worked for my similar issue, but always use an active wallet, 100% Transparency

Closing here since polling isn't needed in https://github.com/wallet-standard/wallet-standard


Unable to upload to OneDrive For Business using UIDocumentPickerViewController

I am attempting to upload a file to a OneDrive for Business store from an iOS app using the UIDocumentPickerViewController interface.
The OneDrive UI is displayed and I am able to select an upload location, but after tapping "Upload to OneDrive" a dialog is displayed "Sorry, there was a problem.  There might be a problem with the file".  If I select a OneDrive Personal location the file is uploaded correctly and I am able to upload a file to the OneDrive for Business location using the OneDrive app, so credentials and permissions appear to be OK.

I am no longer experiencing this issue; Perhaps it was resolved by the OneDrive client app update on Feb 15?

I am still having this issue.  When I had success last week I was on the corporate network for the OneDrive client organisation.  Now I am on my home network

Sorry about this very old issue going stale.  If this is still reproducing, could you please provide updated request & response information to help us investigate further?  Thanks.


Undate

Hi!
Are you going to do an update for Athena?
https://du.w3asel.com/du-mocks/mock-codex/modules/ContainerUnit.html

I started and I will get to it, but I've had a lot going on lately and barely have had time to log in. Hopefully I can make some progress this weekend.

Did a first pass at updating for Athena and pushed it to my hosting a couple weeks ago but had forgotten to push to github. Just did that, let me know if you run across anything I missed/got wrong.


Added Webpack & SVG React Loader Options

I needed the ability to add webpack options to my rewire (so I could include only certain directories), so I forked the repo and added the options. This PR pulls in those changes + documentation in the README.

@codebandits This PR is still outstanding. Any updates on why this hasn't been merged in yet?


Add FlashRank(cross-encoder/ms-marco-TinyBERT-L-2 on cpu)

I love your collection of rerankers, really interesting to see all of them side-by-side
There is one more fun one that you could add:
https://github.com/PrithivirajDamodaran/FlashRank is a cool lib which boasts crazy good cpu perf

Very good shout, I'll see to it this week, thank you!

Live now https://github.com/AnswerDotAI/rerankers/pull/10


Time in teardown fixtures is not correctly frozen

Hello 🖖 A bug occured this 29 February 2024 and we finally discover that ignoring _pytest.runner in your freezegun.configure yields to not freezing time after yielding in a fixture.
Here is the test we created to assert it:
import time
import datetime
import pytest

FROZEN_DATETIME = datetime.datetime(2024, 2, 29, 0, 0, 0, tzinfo=datetime.timezone.utc)

def assert_time():
    assert datetime.datetime.now(datetime.timezone.utc).isoformat() == FROZEN_DATETIME.isoformat()
    assert time.gmtime() == FROZEN_DATETIME.timetuple()

@pytest.fixture
def freeze_time_yield_fixture_1():
    assert_time()
    yield
    assert_time()

@pytest.mark.freeze_time(FROZEN_DATETIME.isoformat())
def test_freezer_fixture_datetime(freeze_time_yield_fixture_1):
    """This test tests that the freeze_time fixture correctly freeze the time after and before yielding in a fixture"""
    assert_time()

if you remove _pytest.runner in freezegun.configure(extend_ignore_list=["_pytest.terminal", "_pytest.runner"]) this test should be green ✅ while keeping it will break 💥
Can you reproduce this?

I can reproduce it, but I don't agree that this an issue? Why should the time remain frozen in the teardown context of the fixture? That's not where asserts should go.

I agree that's not where assert should go but the time should be frozen for the entire workflow.
Fixture can be used for setup and teardown and if the setup is frozen, why teardown is not?

Those "_pytest.terminal", "_pytest.runner" are ignored for a reason. Without that, the results from --durations are bogus:
$ pytest --help | grep durations
  --durations=N         Show N slowest setup/test durations (N=0 for all)
  --durations-min=N     Minimal duration in seconds for inclusion in slowest

If you want better control over when/how the time is frozen, I suggest to use the freezer fixture directly rather than a mark decorator.

I've just looked in freezegun's code and found the reason for the discrepancy with datetime.datetime.now and time.gmtime.
The patched time.gmtime function has a check in it where it checks at runtime whether we're inside the ignore list. In the case of the fixture, we're in the frame of _pytest.runner so the _should_use_real_time() check returns True.
But datetime.datetime.now is a method, and the patch for those works differently, it actually patches the entire datetime.datetime type with a new freezegun.api.FakeDatetime type. The FakeDatetime.now method has no check in the ignore lists, so it remains frozen.
There's nothing pytest-freezer could do here to make these consistent, we just enable/disable freezegun, so any proposed fix there would have to be reported upstream to freezegun itself.

Thank you for the investigation! I'll close the issue. As you said this more-likely a freezgun bug and not a one that could be fixed here 👍


Optimize plot selection queries

Currently all the plot functions return the same plot_return even though they dont all use the same information.  There are three groups

General list, like that used to display groupings on the collection page
Plot collections, those used to retrieve the full information on the collection page
The full list of plots for a project used to dump data
[ ] Reduce the return for each to only that which is needed
[ ] Limit joining with the ext_tables.  The general list does not need it, the plot collection should use a
dynamic query that only returns 1 row, instead of a join

this is partially implemented in https://github.com/openforis/collect-earth-online/pull/519


Mixed content : https is missing for images

Hello,
I have a problem with https :
Mixed Content: The page at 'https://www.mydomain.com/fr/' was loaded over HTTPS, but requested an insecure image 'http://www.mydomain.com/media/cache/listing_large/uploads/listings/images/default-listing.png'. This content should also be served over HTTPS.
I have already set https in parameters.yml, what should I do to fix this?

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[yes]

I had the same problem and and in my case I solved it with the Reverse Proxy:
https://symfony.com/doc/2.8/deployment/proxies.html#but-what-if-the-ip-of-my-reverse-proxy-changes-constantly

Hi Damiano1376,
If you set cocorico.assets_base_urls parameter with 'https://www.mydomain.com/fr/' value and router.request_context.scheme to https it should work.
As @doydoy44  say your problem seems more a server misconfiguration than an application one.
This post seems to confirm that also : https://github.com/liip/LiipImagineBundle/issues/727

I think you're right, there is a problem with my nginx-proxy. I use docker for cocorico and nginx , does anyone knows how to manage correctly https configuration in this two containers?

Hello cocorico team,
I think i am on  the way, but i still need help.
I  think my error come from LiipImagineBundle because everything is in https excepted images in cache.
I  thound this post :
https://github.com/liip/LiipImagineBundle/issues/1050
Considering the second solution, il should add a line in security.yml
security:     access_control:         - { path: ^/your/custom/cache/path, roles: IS_AUTHENTICATED_ANONYMOUSLY, requires_channel: https }         - { path: ^/media/cache/resolve, roles: IS_AUTHENTICATED_ANONYMOUSLY, requires_channel: https }
What are the right paths for  cocorico?

Hello @Damiano1376 ,
Great news :)
It should be ^/media/cache/
Look into the web/media folder and the urls of the images you have in your browser.

@Damiano1376
This is a solution https://github.com/liip/LiipImagineBundle/pull/1059
But I don't know when guys will accept it


Locks up near the beginning when trying to play Dreamer's Black Queen module.

I think it has to do with the type of FX being used.

@ising4jesus hi, d'you happen to have the exact row that causes the crash handy? would be interesting to know :)

Pos 00/46 gets stuck looping between 34/3F and 3D/3F.


chore(translations): UI bus - 2023-08-25

chore(translations): UI bus - 2023-08-25

Update translations related to: 1132b21 - feat: translation

Update translations related to: e96b041 - String review

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Route Subfolders break cache clearing

Steps to reproduce
Setup cache on a nested route with a version number ahead of the service.  Example:
example.com/v1/resources/1?test=true
To clear the cache, I'm running GET cache/clear/single/v1/resources/1?test=true
Expected behavior
Cache key should be 'v1/resources/1?test=true'
Actual behavior
Error.  Cannot find path.
Proposed Solution (What worked for me)
 router.get('/clear/single/:target', (req, res) => {
    let target = decodeURIComponent(req.params.target);

becomes
  router.get('/clear/single/*', (req, res) => {
    let target = decodeURIComponent(req.params[0]);

If this sounds like a useful tweak, I'm happy to submit a PR.

Hello, Thank you for reporting.
Glad to accept a PR!

Thank you!


Fix remove to let from parameter description

I fixed a grammatical error in PackageDescription.
Specifically, I changed the part that says to let to let to to let.

@swift-ci test


Support for stack multi-package projects

You can specify multiple source packages in the stack.yml file.
Each of them can have its own .cabal file.
vscode however does not find any code besides from base package in .cabal files that are not in the project root.
Workaround: Open a vscode instance per package. Drawback: stack.yml can contain additional dependencies (not in the lts-snapshot), not sure if they can be found that way.

When you say that it doesn't find any code from a different package, which feature isn't working?

find symbols? (ctrl+shift+o in windows)
go to definition + type information on hover?
Both?

Those are two different underlying systems, so that info would help me understand if one or both are broken.
Does this work properly in Atom?

I just get lots of complaints like:
Failed to load interface for ‘Control.Monad.Except’
Perhaps you meant Control.Monad.Zip (from base-<IP_ADDRESS>)
Use -v to see a list of the files searched for.

The project layout is:
./src/project.cabal
./stack.yml

The stack.yml points to ./src as a package root.
(Didn't try yet to really have multiple packages; just other reasons not to have code and .cabal in project root)
Atom does resolve those dependencies correctly. I suppose they are interpreting the stack.yml file and you don't. Do you search deeply for *.cabal files? In that case it should probably work somehow...
I haven't seen Go to definition working yet. Ctrl+Click shows the context menu but clicking on Go to definition doesn't do anything.

@hoovercj I have a project that doens't work and I could send it to you :)

@loewenstein and @archaeron
If either of you have a simple repo that you can share with me I'd love to see if my changes for 1.2.0 have helped, or investigate what more I need to do to support this scenario.
If you can link a public repo, that would be preferable, otherwise you can send an email to<EMAIL_ADDRESS>

i have this problem with a project created by stack new and then adding a function to the Lib.hs. when i change something in Main.hs and save, i get failed to load interface.
i have instelled ghc-mod 1.2.0, intero 1.0.20 and lts-8.6, ghc 8.0.2. (i also installed, but then deinstalled haskero)
with stack build it builds ok
(the same problem occurs with more complex repositories, like https://github.com/andrewufrank/test-multiproject)

@hoovercj It works definitely better for https://github.com/SAP/bosh-kubernetes-cpi-release/
The top-level repo doesn't work (it doesn't have a stack.yml in the root).
If you do code src/bosh-kubernetes-cpi it works quite ok. Cross package "Go to definition" didn't work though. There is a package in src/bosh-kubernetes-cpi referencing the package in src/bosh-kubernetes-cpi/dependencies/bosh-spi-haskell.


Only show emmet suggestions at the top of the list when inside markup

I tried searching for a similar issue but found none.
Emmet is awesome! But what isn't awesome is using it in JSX files. I have got it to work well while I edit inside jsx tags. Where it stop being useful and becomes more of a hinderance is editing outside jsx tags and in the javascript.
In this screen shot you can see all the emmet suggestions are at the top.

I know showing them at the top is the default but it is really only useful to put those suggestions at the top when you are in markup.
I would like to be able to configure VSCode to only show emmet suggestions at the top of the list when inside markup

@hipstersmoothie At the moment, there is no easy way to identify if the cursor is inside or outside the markup in a jsx file. If you have any ideas, please do share.
You can tweak the positioning of emmet suggestions in the completion list by adding the below settings
"emmet.showSuggestionsAsSnippets": true,
"editor.snippetSuggestions": "top",
  "[javascriptreact]":{
    "editor.snippetSuggestions": "inline"
  }


[AutoRelease] t2-iothub-2023-08-16-51113(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4432
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1000
BuildTargetingString
azure-mgmt-iothub
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/4432


Remove suse.RancherDesktop 0.6.1 to SUSE.RancherDesktop 0.6.1

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/rancher-sandbox/rancher-desktop/releases/download/v0.6.1/Rancher.Desktop.Setup.0.6.1.exe
Status Code: 200
(Automated message - build 896)


A3.02 Architecture Prototyping

For github original see https://github.com/lsst-uk/lasair-lsst/projects/1

At the 28/APR/21 Lasair internal review, it was agreed that @tms-epcc move the notes from the github kanban (see see https://github.com/lsst-uk/lasair-lsst/projects/1) to this epic ticket.


Remove old Auth component (now hook)

Removes unused component and fixes client id.

Needed to make https://github.com/wellcometrust/wellcomecollection.org/pull/4917 work!


Added CLI options that "should" reduce executable size by 20%.

Scan submitted to Checkmarx

Checkmarx SAST - Scan Summary & Details
Cx-SAST Summary
Total of 7 vulnerabilities 0 High 0 Medium 7 Low 0 Info
Violation Summary
No policy violation found

Checkmarx SCA - Scan Summary & Details
Cx-SCA Summary
Total Packages Identified: 0
Scan Risk Score: 0.00
 0 High severity vulnerabilities
 0 Medium severity vulnerabilities
 0 Low severity vulnerabilities
View more details on Checkmarx UI
Cx-SCA vulnerability result overview
No package violation found


Validate Code Repo settings and display status to the user.

There is currently no validation when saving repo settings from the config screen. Add a status to the dialog box to validate the repo URL, SSL, Auth and display an error to the user on the Config screen if not properly setup.

I am working with an enterprise/Private github Repo, but I am getting an error - 401 Unauthorized . Please help.....

The dashboard looks like

@golokeshpatra45 : try with latest codebase. Refer #883, #908. Open a new issue if see this error.


Make error context a non-enumerable property to avoid serialization errors

Error contexts can contain complex objects with circular references. By making the error context property non-enumerable, it's still accessible directly but won't be included automatically if someone tries to serialize the exception for logging.

This may also address what https://github.com/othiym23/node-continuation-local-storage/pull/46 is trying to address: that is making the error context not writable.

@othiym23 any comments on this one?  We've found this really helpful preventing crashes in our service which frequently serializes error objects (for responses, logging, etc).
Thanks!

@msmithgu there is one more place where the error@context is assigned 85: https://github.com/MyPureCloud/node-continuation-local-storage/blob/efcfebb0151fb92728e82b867b246f4f0af31c4b/context.js#L85
That should have the same behavior...

Thanks! I'll add some tests for this and get it merged. 😸

this fixed my problem! 3q


organized CPP code and added new folder wise code

Added the Code for Cyclic Sort in C++

Thank you for your contribution!
Regards,
Gantavya Malviya ( https://linktr.ee/gantavyamalviya )


(debuger with  Interpreter)Is there a function to restart method (thread) frame after hot code replacement and restart replacement? This is too important for debugging

Is there a function to restart method (thread) frame after hot code replacement and restart replacement? This is too important for debugging?
like java debug with vsode:

When I change the java code, I don't need to restart the jvm and replace the code, and come back to the top of the stack of the current method. The java debugger supports this function, which is very useful and important in reality.

A good debugging experience is a necessary condition for the promotion and development of the crystal language, because advantages alone are not enough, it must be efficient and practical. I hope the crystal team can enhance the debugging experience of the crystal language. This is really important, sometimes debugging code Takes up 90% of my work time.

As much as I love crystal, but without these debugging features, I might still use java. So frustrating

Hi!
Yes, the debugging experience is is far from ideal right now. And it will never be like Java because Crystal is a compiled language (to native code). There's the interpreter but that also will take some time.
In the meantime, please use Java. It's a pretty good language too. I'd recommend giving Kotlin a try, though.

Hi!
Yes, the debugging experience is is far from ideal right now. And it will never be like Java because Crystal is a compiled language (to native code). There's the interpreter but that also will take some time.
In the meantime, please use Java. It's a pretty good language too. I'd recommend giving Kotlin a try, though.

thanks!


Aggregate displayable function traces

May be useful for integration testing in the future.

Irrelevant after #61 is merged


Quiz App using React and Typescript created

Description
Made a Computer Science fun Quiz App  using React , typescript and Open Trivia DB  API
Fixes #775
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Ayush7614 please review my PR


Fix pagination to include query parameters in all HTTP GET requests

Please 👀  @jules2689
This fixes the Oktakit pagination so that it will send the same query parameters (and headers, etc.) to Okta for every HTTP GET request done to retrieve all of the pages.

@jules2689 All 💚 now :)


Add support for containing class fields to RxNullabilityPropagator

This is to track a known limitation in handling fields from the containing context when dealing with nullability propagation across RxJava filter and map operations.
Here is an illustrative test case that currently produces nullness issues but should be safe:
  private static class FieldFromContext {
      @Nullable public NullableContainer foo;

      private Observable<String> filterThenMapTwoGets(Observable<Void> observable) {
          return observable
                  .filter(unit -> foo != null && foo.get() != null)
                  .map(t -> foo.get().toString());
      }
  }

(add to RxSupportNegativeCases.java)

This is way trickier than it seems at first, see #305 :

One potential issue I see with this change, is that, while it is likely to work for filter(...).map(...) it's aggressively thread unsafe and dangerous in a more general case.

Consider: filter(s -> ...).delay(1000).map(s -> ...)

It's safe to assume the values of fields rooted at s haven't changed in between the end of filter and the start of map, since they are "internal" to the stream that got delayed. However, if those lambdas access fields of the containing class, those can easily change between those two program points.

We do something similar for captured locals from the enclosing context (see here), but, in that case, it's actually safe since only effectively final locals from enclosing contexts can be accessed within a lambda. With class fields, this is not true at all, and mutable fields can be accessed, leading to the problem above.

NullAway doesn't attempt to be fully sound with respect to concurrency, but this seems like the kind of optimistic treatment that can easily cause us to miss bugs in the future, so I'd want to make sure there is enough value in supporting this case.


tf-controller APM Support via OpenTelemetry

APM (Application Performance Monitoring) is a great way to provide insights into application-layer transactions (and more).
However, APMs are generally based on a language and/or framework e.g. Java, Go, Tomcat, Dropwizard, Ruby on Rails.
Due to this difference, not all APM agents and instrumentation are the same. For example, Java can instrument your application at run-time with automagic instrumentation out of the box. For Go, you have to instrument at compile-time (see below for more info) and instrument each transaction within source. Some agents provide a unified solution out of the box with minimum bootstrapping required (like Ruby).
By example and comparison, Flagger has Metrics Analysis integrations with the likes of Prometheus, Datadog, Amazon CloudWatch, New Relic, et al. As tf-controller matures, then a nice to have will be to integrate with APMs.
Like above, not APM providers are cut the same. However, OpenTracing has now been superseded by OpenTelemetry, which opens up compatability to an even wider range of APM providers. This should mean we can integrate once, provide many times.
TL;DR: Intergrate tf-controller with OpenTelemetry to provide APM observability to a market wide range of providers.

I agree that if we need to support APM, OpenTelemetry is the way to go. Some APM tools provide out of box APM tracing without manual instrumentations but understand that its tool to tool specific.


XCode Archive & Export for iOS fails since 5.2.1

Troubleshooting

[x] I've searched discuss.bitrise.io for possible solutions.
Which version of the step is effected? 1.2.3
Is the issue reproducible with the latest version? YES / NO
Does the issue happen sporadically, or every time? SPORADIC / EVERY TIME
Is the issue reproducible locally by following our local debug guide? YES / NO / NOT APPLICABLE

Useful information

FAQ
devcenter.bitrise.io

Issue description
Our CD was working perfectly until this morning, when we got the following error::
Failed to execute Step main logic: failed to archive the project: command failed with exit status 65 (set -o pipefail && xcodebuild "archive" "-workspace" "/Users/[REDACTED]/git/ios/meilleurtaux.xcworkspace" "-scheme" "preprod" "-configuration" "preprodRelease" "-xcconfig" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/52466558/temp.xcconfig" "-archivePath" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/xcodeArchive2430447478/MTX PREPROD.xcarchive" "-destination" "generic/platform=iOS" | xcpretty): error: Could not get GOOGLE_APP_ID in Google Services file from build environment (exit code: 1)

We changed nothing since yesterday, we just got these errors on every build since this morning, and I only just thought about checking for changelogs, and got the good surprise of finding only one update on the step that is now failing ^^
Bitrise info

Build URL: Please share the build URL with us. https://app.bitrise.io/build/962c3ed9-eb89-4cfa-be1f-7396a0226bac
Bitrise Support enabled: YES / NO
Log:

Failed to execute Step main logic: failed to archive the project: command failed with exit status 65 (set -o pipefail && xcodebuild "archive" "-workspace" "/Users/[REDACTED]/git/ios/meilleurtaux.xcworkspace" "-scheme" "preprod" "-configuration" "preprodRelease" "-xcconfig" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/52466558/temp.xcconfig" "-archivePath" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/xcodeArchive2430447478/MTX PREPROD.xcarchive" "-destination" "generic/platform=iOS" | xcpretty): error: Could not get GOOGLE_APP_ID in Google Services file from build environment (exit code: 1)

Steps to reproduce
Rebuild any of our previous builds from before.
We should expect it to work, it now fails (for 2 reasons by the way, because another issue of Bitrise is that when it sees an nvmrc file, it switches to the indicated version, but does not install it ; Bitrise should either ignore the .nvmrc file completely, or install the version before switching to it --- And Bitrise upgraded the configuration of the XCode 15.2 and bumped the default Node version from 18.20.2 to 18.20.4)

Sorry it seems there are multiple errors and the step update might not be the cause of it, so I'm closing the issue for now!


[docs] CToSwift: document omit-needless-words

...and update the dirty lie that property names aren't transformed.
The only thing left to do is methods!

I'm not sure I expect anyone to read this monster document. I'm not sure if it will even come in use. But it does feel like having a prose + pseudocode description of the algorithm is some kind of "understanding redundancy".
@swift-ci Please smoke test


[IOS] onPlatformBrightnessChanged is called twice when the app goes to the background

The onPlatformBrightnessChanged callback is called twice when the app goes to the background despite the fact that there is no change made to the brightness mode of the platform. The brightness is always incorrect in the first call. I can confirm that the problem occurs on both iOS Simulator and the real device.
Steps to Reproduce

Execute flutter run on the code sample.
Switch to another app or send the app to the background. (onPlatformBrightnessChanged will be called twice.)
Return to the app.

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  void initState() {
    final window = WidgetsBinding.instance?.window;

    if (window != null) {
      window.onPlatformBrightnessChanged = () {
        print(window.platformBrightness);
      };
    }

    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter App',
      darkTheme: ThemeData(
        scaffoldBackgroundColor: Colors.black,
        textTheme: const TextTheme(
          bodyText2: TextStyle(
            color: Colors.white,
          ),
        ),
      ),
      home: Scaffold(
        appBar: AppBar(
          title: const Text("Flutter App"),
        ),
        body: Builder(
          builder: (context) => Center(
            child: Text(
              "Platform Brightness: ${MediaQuery.of(context).platformBrightness}",
            ),
          ),
        ),
      ),
    );
  }
}

iOS is creating snapshots of your UI for light and dark appearance (and also for portrait and landscape orientation) every time the app is backgrounded for previewing your app in the app switcher UI.

Solution I found was to set a debounce timer, That solve it because the IOS change the platform brightness in microseconds and always the last one will be the real active mode.
  /// Debounce timer
  Timer? _debounce;

   /// Listen to the platform brightness
   platform.onPlatformBrightnessChanged = () {
      /// Set the debounce timer
      _debounce = Timer(const Duration(seconds: 1), () {
        ----> Logic here <-----
      });
    };


KeyboardDragListener doesn't interrupt on blur

I noticed that the KeyboardDragListener doesn't interrupt itself on blur which is surprising to me. I am using one without a GrabDragInteraction in quadrilateral and tabbing away from the Node while movement keys are down result in the pressed keys staying in the keyState array. This isn't a problem for GrabDragInteraction because of these lines
https://github.com/phetsims/scenery-phet/blob/03097363295d48e5be248c9ecbbbf29853799625/js/accessibility/GrabDragInteraction.js#L654-L665

Fixed in the above commit, @zepumph is this change OK with you?

I can't think of any reason that would be bad. Thanks!

Similar to this, I just saw that interrupt doesn't call end. @jessegreenberg please let me know if that seems buggy to have. It seems important to keep this implementation aligned with DragListener (from interrupt/release).

Ran into this over in https://github.com/phetsims/my-solar-system/issues/86

Spot check from @jessegreenberg, I basically copied the idea from
https://github.com/phetsims/scenery/blob/80e29854972d590e7e818f4b903bf4b8df405ed1/js/listeners/PressListener.ts#L547-L551

This change makes sense, thank you! Looking for other cases like https://github.com/phetsims/friction/issues/342, but I didn't see anything else.
Closing.


No stopping

Love the PR names! :-) Now you should add the same config for the SymbolArray cop. :-)

OK, sure.

Just added AllowForAlignment to Style/SpaceAroundOperators because it wouldn't let me align ||=.
Style/ExtraSpacing seems to overlap all these other spacing cops. ExtraSpacing checks for more than 1 space between each adjacent pair of tokens and doesn't understand anything about the AST structure. All the other "spacing" cops work on ASTs and don't understand anything about tokens.
This creates a funny situation where you can tell ExtraSpacing to allow (or even enforce) extra spaces for alignment, but other cops complain.
@bbatsov will probably say: "Who wants extra spaces for alignment?  But a lot of progMultiSpaceAllowedrammers do like this style.
I see the benefit of splitting "spacing" checks into a number of different cops, since people can enable/disable them individually. The main problem is that all of those cops overlap with ExtraSpacing.

BTW the AllowForAlignment commit is not complete.

Added an incomplete version of the upgrade to SymbolArray. Still needs specs, changelog, better commit message, autocorrection.

Check out 2e141d9. @rrosenblum, your StringReplacement cop is significantly improved (along with a couple of others).

Don't merge this yet; I still need to polish up a couple things.

Sorry, but this sweetness is still not sweet enough to merge! Hold on please!

Updated [Fix #2531] based on feedback from @jonas054. Thanks for the code review!

Problem: Lint/EndAlignment vs. Style/ElseAlignment. They are very closely linked, but in different departments. Both should be Style.

MRI has an end alignment check, therefore Lint/EndAlignment. Not sure what the best solution here would be - both options are reasonable IMO (making both cops lint or style).

Not sure what the best solution here would be - both options are reasonable IMO (making both cops lint or style).

I think these cops should actually be merged. The reason is that Style/ElseAlignment reads the config for Lint/EndAlignment, and follows its style. This is quite unusual -- one cop following the EnforcedStyle of another cop. If someone has an ElseAlignment offense in their code, it is quite counter-intuitive that the config for EndAlignment should be adjusted. This also is not good for --auto-gen-config.

I want to change the styles for WordArray and SymbolArray to percent and brackets rather than percent and array. Any comments on this?

This PR is getting out of control. I will try to polish up the few things which are still lacking so it can be merged before it grows any bigger...

I think these cops should actually be merged. The reason is that Style/ElseAlignment reads the config for Lint/EndAlignment, and follows its style. This is quite unusual -- one cop following the EnforcedStyle of another cop. If someone has an ElseAlignment offense in their code, it is quite counter-intuitive that the config for EndAlignment should be adjusted. This also is not good for --auto-gen-config.

I seem to recall we had other cops like this, but yeah - the coupling between the cops is high and unusual. On the other hand - one bigger cop will be one bigger cop. Striking the right balance is sometimes hard.

Striking the right balance is sometimes hard.

Very true. Would you like to make a call on this one?

This PR is getting out of control. I will try to polish up the few things which are still lacking so it can be merged before it grows any bigger...

Sure. Just let us know when you think it's ready for a final review.

Very true. Would you like to make a call on this one?

Merge those together, rename it to Lint/KeywordAlignment and make it possible to disable this for individual keywords (to emulate the effect of having separate cops).

Looks like there is no objection to brackets style rather than array style?

Yeah, no objections.

This is getting ridiculous. This PR just has to stop here.
A few questions/comments:

What do you think of the warnings printed when obsolete config params are used? See ca76afe and 02be2e1. Maybe we need to crash RC hard rather than just printing warnings?
I think the weird and anomalous behavior of Lint/EndAlignment as re: case nodes can be reverted now that we have start_of_line style. Comments? /CC @lumeet
Further upgrades to Style/SpaceAroundOperators are coming, but not in this PR. Next one.
Merging ElseAlignment and EndAlignment (as suggested by @bbatsov) will come in the next PR too. Not here, not now. No! Next one! Not this one!
I want to give ElseAlignment a hard look and see how the new start_of_line style will affect it. Next PR! Not now! Sorry!

What do you think of the warnings printed when obsolete config params are used? See ca76afe and 02be2e1. Maybe we need to crash RC hard rather than just printing warnings?

It's fine to crash.

Ready for final review!

Please take special note of fe64399. Not sure if you'll like this change.

:+1: All good as far as I can see.

That was epic. In general it'd be nice to limit the scope of the PRs in the future, so it's easier to review them in a meaningful manner. Anyways, once again - fantastic work @alexdowad!

Thanks to @bbatsov and @jonas054 for code review. Will try to rein in these wild PRs in future.


setuptools_scm_git_archive now included in setuptools_scm >=7.0.0

Hi! Arch Linux packager here, we've discovered that functionality provided by setuptools_scm_git_archive is now included in setuptools_scm.
Upstream has updated their documentation with a migration guide also.

Thank you for the headsup! This seems like a trivial fix, let me do that.


Validator with blurToSave dismisses error too quickly

To reproduce:

Enable blurToSave: true.
Click into a cell with a validation error.
Click into a different cell.

Result:
The error messages dismisses way too quickly sometimes when you click into another cell.
Expected Result:
The table should probably prevent you from clicking into the other cell.
On react-bootstrap-table 3.3.5

@bobics, I think it's a minor issue, due to you click another cell must trigger blur event and it will cause  the previous cell complete editing cell. Let me know you concern or consideration, thanks

I think validation should take precedence by default over triggering blur. Or at least the error message shouldn't disappear right away. As it is, the user may not even notice they entered invalid input because the error message disappear so quickly.


scroll to current / selected time not work when we add portalId to showTimeSelectOnly DatePicker

Describe the bug
scroll to current / selected time not work when we add portalId to showTimeSelectOnly DatePicker
To Reproduce
please see https://reactdatepicker.com/#example-select-time-only
and edit code in this example and add portalId="portal01"
then if we click input to open timePicker it will not scroll to current time or selected item
It's only happen in timeOnly mode and works fine when we have calendar too

I used this code for fix this befaviour
<ReactDatePicker ... portalId={portalId} onCalendarOpen={() => {           if (portalId) {             document               .querySelector(                 '#' + portalId +  ' .react-datepicker__time-list-item--selected'               )?.scrollIntoView({block: 'center'});           }         }} />

@Sundved .scrollIntoView({block: 'center'}); does not work right when the page is scrollable, the picker will move to another position.


Datadoghq.eu support

Hi!
Is it possible to add a configuration field to be able to use https://app.datadoghq.eu endpoint instead of the hardcoded
private String targetMetricURL = "https://api.datadoghq.com/api/";
It could be really appreciated.

If I understand your questions correctly you should be able to change the value of the targetMetricURL in the Jenkins system configuration:
Jenkins dashboard -> Manage Jenkins -> Configure System -> Datadog Plugin -> Advanced -> Target API URL

Yep exact!
Because datadog provides this host to store data in Europe only...

@davidjaquier To confirm, if you are in the Datadog EU site, https://api.datadoghq.eu/api/ can be used for API calls. If you have any additional questions, if you open a ticket someone can walk you through the configuration.


Add logrotate to the list of packages installed

Issue
We need to install the logrotate package for the charm to be able to rotate mysql text logs
Solution
Install the logrotate package, and organize its copyright file under licenses

@paulomach we are going cronless. since the logrotate would need credentials and we dont want to store credentials in the workload container -> instead, we will take an approach like the ip address observer and have a separate process in the charm container dispatch a custom event every minute (this PR is coming shortly in the k8s charm)


Can help me

When user change dropdown  productcode  can load quality in another table.it possible ?

use productcode.ChangeSelect2 handler that load Qty.

There is a sample under dialogs like this.

@volkanceylan
Q.first() -- > Summary Qty In Order Detail Group by ProductID ?


MoPub 4.8.0

Hey @talklittle. Thanks for your contributions :) Great stuff! We'll review the PR and if everything looks good we'll merge it!


Use of [UIApplication sharedApplication] not allowed in App Extensions

Hi,
My app has an extension and because of the line below, I am not being able to use the latest version.
https://github.com/MortimerGoro/MGSwipeTableCell/blob/master/MGSwipeTableCell/MGSwipeTableCell.m#L643
Is it possible to change?
Thanks in advance.
Regards,

Hi,
I have the same problem. I will be using a fork for now, but if you will find a good solution it will be great.
Thanks in advance

There isn't a builtin way to detect App Extension compilations in XCode. I have added the macro TARGET_IS_EXTENSION in this commit: 4df4d58ad148388212dac9081ad3d6ac6eff2b33
You can the define the macro in your project when compiling an App Extension. Yhis way yo don't need to use a fork

Go to your project target build settings
Find (or search) Preprocessor Macros under Apple LLVM 6.0 - Preprocessing
Add TARGET_IS_EXTENSION in both the debug and release sections.

Hi,
same issue seems to be in https://github.com/MortimerGoro/MGSwipeTableCell/blob/master/MGSwipeTableCell/MGSwipeButton.m#L97


Breaking changes - Change import to global declaration, remove js, qol changes

Basic changes like including links to types when referenced by other types.
Major changes:
- // Interface with type definitions for Tasker functions
- export interface TK {
+ // We are using global declarations, because tasker function are not imported, and called without defining them
+ declare global {

What that does:
instead of importing like this:
import { tk as tasker } from "tasker-types";`
tasker.mediaVol(5, true, true);

The typescript environment detects and parses the types into the global scope, so they can be typed without ever importing anything, like this:
mediaVol(5, true, true);

Benefits:

Type safety
Error checking
JSDoc comments
No imports
No transpilation / extra step of removing all the tasker. code and import statements
All code can be directly ran in tasker

Downsides:

Breaking changes - users need to migrate code to new version
No TS checking in Javascript files without // @ts-check comment

Thank you for this! I didn't realize that there was a way to declare global functions without an import.


Sq lite alter columns

Ability to add multiple columns whilst using sqlite adapter. unit tests added ^^

Thanks so much!


sudden incompatibility with zotxt

Since very recently, I noticed that zotero-better-bibtex causes certain problems while using
https://github.com/egh/zotxt

A request like this:
http://<IP_ADDRESS>:23119/zotxt/items?key=0_7KAENGFZ&format=key

does still work, but when choosing another format like:
http://<IP_ADDRESS>:23119/zotxt/items?key=0_7KAENGFZ&format=betterbibtexkey

or
http://<IP_ADDRESS>:23119/zotxt/items?key=0_7KAENGFZ&format=easykey

then Firefox will not return any result!
If I disable zotero-better-bibtex, zotxt works as expected again.
So I guess and hope to report the issue to the right address here.
Thank you for taking care of all this amazing features of this extension!

Thank you for this quick answer.
I reported the issue to @egh at gitlab:
https://gitlab.com/egh/zotxt/issues/43
Hopefully tings can be resolved soon.
In the meantime however, it would be great, if I could simply switch back to a previous version of zotero-better-bibtex. I tried to do this, but I didn't succeed.
Would you know, what I would need to do, to get the old functionality back, at least temporarily?
Thank you for another quick answer.

You'd have to download an older bbt version from https://github.com/retorquere/zotero-better-bibtex/releases, and disable automatic updates on the extension settings. Disabling auto updates is not something I'd recommend, but if not you'd just be upgraded in a day.
You'll understand I can't accept bug reports on older bbt versions. If you want support, you'll need to be back on the latest version.

Of course, I understand perfecly that there can be no support and I am happy to receive an answer at all on these matters!
Thank you for describing the steps of downgrading to an earlier version.
Yet, this is exaclty what I did and now tried again going even back to version 1.6.69. I also tried to combine the downgrading with an older version of firefox, noteably 48.0.
However, whatever combination I used, the old behaviour is not restored!
I also tried to do a cache reset -- but no difference.
Only if I disable zotero-better-bibtex, then zotxt works again as expected.
Could it be that the database hase been changed permanently, or there are some other files affected that I would need to replace?
Sorry, for bothering once more with this issue. I surely wouldn't, if I would not depend on the workflow so nicely made possible by the cooperation of thses two extensions.

No bother.
The Firefox version shouldn't matter, and the database structure hasn't changed in a while. If you didn't get any notice, the cache would have been reset automatically (and the cache wouldn't have affected zotxt, it's not reading the cache).
If you enable extended debugging and submit a debug report, I can have a look. I can look up later tonight what version most likely still worked with zotxt, but I'm currently commuting.

That's extraordinary kind of you!
All right, I am back at Firefox 49.0.2 but with an older version of zotero-better-bibtex installed, namely 1.6.69.
The extended debug report was given the reference:  MUFAB8VI
In 3 different browser tabs, I repeated the same 3 requests as in my first post with exactly the same result as reported above.
Hope that might tell you something.
Thanks for spending your time on that issue!

I think 1.6.74 was the last version before Zotero.BetterBibTeX.translators was replaced. MUFAB8VI has no errors that relate to zotxt or bbt.

(extended debugging wasn't on when MUFAB8VI was sent though, so there's not too much I can tell from that log)

Ok. I'll immediately repeat that.
But I guess something really crazy is going here:
While testing a minimal setup with Firefox zotero and zotero-better-bibtex ONLY, I now get
null translator

when requesting
http://localhost:23119/better-bibtex/collection?/0/RD9P2G2U.biblatex

which used to work perfectly.
The debug report is: 7FJQBZQM
Next post, will be with version 1.6.74 and right debug settings enabled.

The null translator problem is #586 -- I'm trying to figure out #585 and will release those two together.

After what felt like a thousand restarts of Firefox, I am back on a working setup!
I can know certainly confirm, that 1.6.75 is the last working version.
Interesting might be that issue #585 is also introduced by version 1.6.76 and they might indeed be considered connected.
Thank you again for answering all that amazingly quickly!
Good luck while debugging.

Zotxt has been updated to 0.1.35 and works well with zotero-better-bibtex 1.6.80.
All fine again!

Thanks @retorquere and @emelin !


Fix algorithmic asymmetry

Fixes #64

I assume this change would need to get updated in the CSS spec as well.

I assume this change would need to get updated in the CSS spec as well.

I assume this change would need to get updated in the CSS spec as well.

Yes!

I assume this change would need to get updated in the CSS spec as well.

Yes!

also fixed in CSS Color 4 sample code
(Two of the four changes are for clarity, not correctness)

also fixed in CSS Color 4 sample code
(Two of the four changes are for clarity, not correctness)


Documentation?

I see there is a Todo for documentation.
Can you get one or two simple examples on there please.

Note: I noticed good examples in the code as Docblocs :+1:


v0.4.1 - Database Error when using expect_no_rows

First off, thank you for making this library, it is absolutely brilliant!
I believe I've found a bug with the new expect_no_rows macro.
Whenever I try and use the expect_no_rows assertion I get a database error due to a syntax error in the generated SQL.
This is occuring running against BigQuery on the latest version of dbt-unit-testing (v0.4.1).
I can reproduce with a minimal example:
# models/staging/seed_demo_bugs.sql
{{
    config(materialized='table')
}}

SELECT
    1 AS bug_id
    , 'something' AS info

# models/staging/demo_bugs.sql
{{
    config(materialized='table')
}}
SELECT * FROM {{ dbt_unit_testing.ref('seed_demo_bugs') }} WHERE bug_id = 1

# tests/unittests/staging/test_demo_bugs.sql

{{ config(tags=['unit-test']) }}

{% call dbt_unit_testing.test('demo_bugs', 'should not include bugs with id other than 1') %}
  {% call dbt_unit_testing.mock_ref('seed_demo_bugs', options={"input_format": "csv"}) %}
    bug_id | info
         2 | 'some info'
  {% endcall %}

  {% call dbt_unit_testing.expect_no_rows() %}
  {% endcall %}
{% endcall %}

Running the following:
dbt test --select "tests/unittests/staging/test_demo_bugs.sql"

Gives the following output:
16:31:20  Running with dbt=1.7.4
16:31:20  Registered adapter: bigquery=1.7.2
16:31:20  Found 9 models, 68 tests, 1 operation, 2 sources, 0 exposures, 0 metrics, 642 macros, 0 groups, 0 semantic models
16:31:20
16:31:22  Concurrency: 4 threads (target='test')
16:31:22
16:31:22  1 of 1 START test test_demo_bugs ............................................... [RUN]
16:31:23  BigQuery adapter: https://console.cloud.google.com/<REDACTED>
16:31:24  1 of 1 ERROR test_demo_bugs .................................................... [ERROR in 1.25s]
16:31:24
16:31:24  Finished running 1 test, 1 hook in 0 hours 0 minutes and 3.26 seconds (3.26s).
16:31:24
16:31:24  Completed with 1 error and 0 warnings:
16:31:24
16:31:24    Database Error in test test_demo_bugs (tests/unittests/staging/test_demo_bugs.sql)
  Syntax error: Unexpected end of statement at [1:163]
16:31:24
16:31:24  Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1

After running build:
dbt build --target test --select "tests/unittests/staging/test_demo_bugs.sql"

I can see the following output in the target directory:
# target/compiled/<project_name>/tests/unittests/staging/test_demo_bugs.sql

      select 1 as a from (select 1) as t where false

# target/run/<project_name>/tests/unittests/staging/test_demo_bugs.sql
select
      count(*) as failures,
      count(*) != 0 as should_warn,
      count(*) != 0 as should_error
    from (

      select 1 as a from (select 1) as t where false

    ) dbt_internal_test

Hopefully this is enough info for the bug to be fixed or for you to tell me what I'm doing wrong.

Hi @oscarrobinson, please check v0.4.11 to see if it fixed your issue.
Thank you 👍

@oscarrobinson, please try this version and let me know if it worked:
  - git: "https://github.com/EqualExperts/dbt-unit-testing"
    revision: 49b53e9a1c299f5941d2c3242576857538cc363c

Just replace your v0.4.11 version with the one above and run dbt deps
Thanks

That works 😄 Thank you!

Great! I'll create a release 0.4.12 with this.
Thank you again for your support!


Allow users to add/show descriptions of workflow templates

If the annotation workflows.argoproj.io/description is available, present it nicely in the UI and allow users to edit it.

If someone adds the following:
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: my-awesome-workflowtemplate
  annotations:
    workflows.argoproj.io/description: "The most amazing workflowtemplate EVAR"

to a workflowtemplate it will be available in the UI via https://argo-workflows-url/workflow-templates underneath the workflowtemplate name.

Superseded by #12644


chore(main): release iso-kv 0.2.0

:robot: I have created a release beep boop
0.2.0 (2023-10-31)
Features

kv refactor (3258a5e)

Bug Fixes

default to memory store (958feac)
simplify types and use seconds for ttl (bd71f70)
small types/docs tweaks (53b7a41)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hugomrdias/iso-repo/releases/tag/iso-kv-v0.2.0 :sunflower:


the cookie names are not exist n firefox console...

the cookie names are not exist to firefox console...

Same Problem


Intl-ICU: On Windows, use ICU from Windows Kit (compile option overrides).

Do we think this is still important? This will only work on RS2+, so it would severely limit the benefit of ChakraCore running downlevel.

This is probably out of date given the more recent design discussions anyway. Windows Kit is a dev dependency to be installed, includes dev headers not just data for the runtime -- and might work downlevel as well, so it's a potential place we could try to grab ICU data from, but probably not worth it -- and ICU data already exists on the system in RS2+ regardless of whether the Windows Kit is installed.

So by Windows Kit ICU, I meant the icuuc.dll, icuin.dll, and icudt.dat that are included in every box, which is vaguely related to the headers that you get when you install an RS2+ Windows SDK. By depending on any of that at any time, it limits ChakraCore to running by default only on RS2+. The ICU team did some investigation on how far downlevel those DLLs can go and the ones that are in-box can only be copied onto TH1+ machines, since they depend on apiset shenaniganry when built within Razzle. The UWP projects included by default in the ICU source code do work downlevel to windows 8ish, but then theyre technically incompatible with whats on RS2 because they just link to kernel32.lib.... the entire situation is fuzzy and I don't think its a good idea to expose this until we get a specific use case for it.

I'm not sure we should refer to those in-box binaries (the ones you mentioned which live under C:\Windows\…) as Windows Kit because the Windows Kit version is installed as an SDK with VS (I think) at C:\Program Files (x86)\Windows Kits\10\…. Mixing up this terminology could prove to be confusing.

What is installed with the Windows Kit is just the headers and link libs. The DLLs and data file are in every RS2+ box (similar to the distinction between kernel32.dll and kernel32.lib + windows.h)

Ah yeah, dev dependencies for the in-box thing. Does the ICU stuff installed in Windows 10 Kit not work downlevel? I guess it's the same as what you were saying, due to implementation, it only works down to TH1+ but not Win8/Blue.

The headers aren't relevant since they aren't present at runtime, and Curtis thinks that the link libs should be compatible since they point to names in the DLLs rather than any sort of offset, which is the old-style DLL Hell problem (apparently, I am not particularly familiar with any of these things).


Laravel echo server is not aware of user joining public channels

Hi there,
I set up laravel-echo-server according to README in this repo, and set up client side Laravel Echo according to official laravel docs, here my code goes:
laravel-echo-server.json
{
	"authHost": "http://<IP_ADDRESS>",
	"authEndpoint": "/broadcasting/auth",
	"clients": [
		{
			"appId": "adfd87ecb3862c07",
			"key": "e28d15f3c6fda18709ae9511af828d25"
		}
	],
	"database": "redis",
	"databaseConfig": {
		"redis": {},
		"sqlite": {
			"databasePath": "/database/laravel-echo-server.sqlite"
		}
	},
	"devMode": true,
	"host": null,
	"port": "6001",
	"protocol": "http",
	"socketio": {},
	"sslCertPath": "",
	"sslKeyPath": "",
	"sslCertChainPath": "",
	"sslPassphrase": "",
	"apiOriginAllow": {
		"allowCors": false,
		"allowOrigin": "",
		"allowMethods": "",
		"allowHeaders": ""
	}
}

bootstrap.js and app.js
import Echo from 'laravel-echo'

window.Echo = new Echo({
    broadcaster: 'socket.io',
    host: window.location.hostname + ':6001'
});
// ...
Echo.channel('chatroom')
    .listen('.App\\Events\\MessagePosted', (e) => {
      this.messages.push({
        message: e.message.message,
        user: e.user
      });
    });

But when I started laravel-echo-server, client successfully connected through socket (can see request and frames in Chrome inspector), then server correctly fired broadcasting (I believe), the laravel-echo-server log went like this:
⚠ Starting server in DEV mode...

✔  Running at localhost on port 6001
✔  Channels are ready.
✔  Listening for http events...
✔  Listening for redis events...

Server ready!

Channel: chatroom
Event: App\Events\MessagePosted
CHANNEL chatroom

It's obvious laravel-echo-server was aware of the broadcasted message, but no logs indicate that it realized a user has subscribed to the public channel 'chatroom'. And of course the message was not sent to the client(not shown in frames inspector).
I went through docs and googled for similar problems but still can't solve this.

Fixed this.
The npm run watch task somehow didn't update my js code, the connection I saw in inspector was actually not with the express socket.io server that laravel-echo-server creates, but one which I was trying out manually.
After rerun npm task everything works fine.
Thanks for creating this wonderful package.


Response examples are not rendered

Spec: https://api.carbon.ai/openapi.json
Works: https://api.carbon.ai/redoc
(Happens with other specs as well but couldn't reproduce it consistently)
The response examples are not rendered in the endpoints area.
In the console I see this:
Uncaught (in promise) InternalError: too much recursion
    jr http://localhost:8001/openapi-explorer.min.js:3
    jr http://localhost:8001/openapi-explorer.min.js:3
    jr http://localhost:8001/openapi-explorer.min.js:3
    .... and so on

The problem is you haven't defined the type property in your items objects. As soon as you do that, the spec will automatically fix itself. However, we've added additional protection to resolve that. You can test it out as soon as the automated build runs in release 1.1.

It's as I said, there are schema without the type attribute.


Problem when used with AMP module (nuxt-i18n since version 6.13.5)

Version
nuxt-i18n: 6.13.5 - 6.13.9
nuxt: 2.12.2
Nuxt configuration
Mode:

[X] universal
[ ] spa

Nuxt-i18n configuration
i18n: {
    parsePages: false,
    lazy: true,
    locales: [
      {
        territory: 'US',
        name: 'English',
        code: 'en',
        iso: 'en',
        file: 'en.json'
      },
      {
        territory: 'ES',
        name: 'Español',
        code: 'es',
        iso: 'es',
        file: 'es.json'
      },
    ],
    detectBrowserLanguage: false,
    vueI18n: {
      fallbackLocale: 'en'
    },
    vuex: {
      syncLocale: true,
      syncMessages: true
    },
    defaultLocale: 'en',
    langDir: 'locales/',
    seo: false
}

Reproduction Link
Sandbox
Steps to reproduce

Go to /amp route.
Go to /amp/es route.

What is Expected?
When we follow the url with /amp, a page should open in the desired language with AMP support.
What is actually happening?
Currently, when following the /amp path, it displays the languageES, although the default is EN. Also, if you try to go to the path /amp/es it will throw an error, although a Spanish AMP page should be open. Changing the version, I found the one that started it - 6.13.5. If you change the version of nuxt-i18n package to 6.13.4 everything works fine with/amp.

It's a problem due to both this and amp module are extending routes and things have changed in that regard in nuxt-i18n causing things to happen at different times.
I hate those kinds of issues...
@pi0 sorry for pinging you but do you have any input here? This issue with different modules extending routes at different times is hard to work with...
Also FYI @farnabaz

@rchl I think it is not something auto-magically resolvable by nuxt unless either of modules respects extending of routes from the other one. Specially this case where extending strategy is also different (amp adds alias but i18n adds new records with different name) and we cannot guess it should be /[locale]/[amp] or /[amp]/[locale]) nor know which part of already extended route (string) is prefix and which part is real path to inject prefix.
One solution:

i18n module needs to also add route.meta.locale
amp module can detect locale and take into account when creating aliases

Also open for better ideas if you have :)

The problem is that amp module extends routes using Module. extendRoutes from the module itself while I'm calling it from within 'build:before' hook. So my extending runs later while it needs to run first.
I'm not saying that this should automagically work but at least the user should be able to do something about it. For example by manually configuring module order. Unfortunately, that doesn't work anymore, since I've switched to the build hook for certain reasons...
I guess I'll have to refactor things again to fix that, but it would be good to have this issue at the back of the mind for potential addressing in future major Nuxt versions.

I guess some sort of rudimentary solution would be to extend extendRoutes to accept a "priority" argument which would result in callers being called in certain, preferred order.

Fix released in v6.13.10
The order should be back as before - will be decided by the order in which modules are registered.

@rchl Supporting a numeric order would introduce race-conditions between modules however then and yes i know regression caused because of delayed extendRoutes call. Thanks for quick fix :heart:  Will put an issue in nuxt3 to think about better integration.

Hi @rchl. I have a small question about nuxt-i18n and nuxt-redirect modules. I think that it's issue, but i am not sure. I have updated the sandbox for reproduce. If you will try to get access to path /foo (or any other page that not existing) with current version of nuxt-i18n package (6.13.10) it will Too many requests error. But with version of package is6.12.0 it works fine. What's really happening: every non-existent standard language page now has an error Too many requests instead of 404, when we are using trailing slash at the end as default.

Could you create a separate issue for that? It would be better for tracking.

@rchl Sure. 5-10 min.


[Swift-Testing] Package addition is required on Linux CLI, but not on macOS

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

[X] Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description
On linux, you need to add swift-testing as a dependency, but on macOS, you don't need to.
Expected behavior
Unified behavior on macOS and Linux.
Actual behavior
On macOS, this successfully runs the tests:
~ swift testing --enable-swift-testing

On Linux:
~ swift testing --enable-swift-testing
/__w/my-package/my-package/Tests/MyTests/MyThingTests.swift:1:8: error: no such module 'Testing'
  1 | import Testing
    |        `- error: no such module 'Testing'

Steps to reproduce
Described above.
Swift Package Manager version/commit hash
Bundled with Xcode 16 beta 2.
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.110 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.52 clang-16<IP_ADDRESS>.3)
Target: arm64-apple-macosx15.0
Darwin ---.local 24.0.0 Darwin Kernel Version 24.0.0: ---; root:xnu-11<IP_ADDRESS>1.3~1/RELEASE_ARM64_T6000 arm64

Related: https://github.com/swiftlang/swift/issues/75037
cc @grynspan

We haven't added Swift Testing to the open source toolchain yet. This is not a Swift issue.


[BYOC][NNAPI] Add NNAPI backend for BYOC

[RFC-109] Add a new backend NNAPI for BYOC
This PR introduces a new BYOC backend for Android Neural Networks API (NNAPI), enabling execution of neural networks on custom accelerators. This feature adds a new codegen and runtime for NNAPI, supporting operations such as element-wise ops, nn.dense, and nn.conv2d for CNN model with static shape.
Co-authored-by: Ming-Long Huang<EMAIL_ADDRESS>Co-authored-by: HMZ<EMAIL_ADDRESS>

Thank you @mengshyu ! this is now merged