pvsyst cell temp docs for eta_m arg missing "area" from definition

Describe the bug
the definition for eta_m says:

But I think this should actually be: (total DC power) / (poa_global * (total active module area))
To Reproduce
Steps to reproduce the behavior:

Go to https://pvlib-python.readthedocs.io/en/latest/generated/pvlib.temperature.pvsyst_cell.html#pvlib.temperature.pvsyst_cell
Look at pvlib.temperature.pvsyst_cell parameters
Scroll down to eta_m
See definition

Expected behavior
I think this should actually be: (total DC power) / (poa_global * (total active module area))
Screenshots

Versions:

pvlib.__version__: v0.8.1
pandas.__version__: na
python: na

Additional context
see https://www.pvsyst.com/help/thermal_loss.htm

Effic  is the PV efficiency (related to the module area), i.e. the energy removed from the module. When possible, the PV efficiency is calculated according to the operating conditions of the module. Otherwise it is taken as 10%.

Does this mean that the Uc and Uv coefficients already take into account the active module area? but then eta_m will not be a number less than one, so I don't think so.

@mikofski can I work on this issue?

Yes, of course! thanks so much. If you need any help getting started check the contribution guide or you can at me here too.


Explicitly check for reference locals or fields in Name classification

Guess I'll rebase on top of #9567 once its merged

bors r+

bors r+


[SPARK-16940][SQL] checkAnswer should raise TestFailedException for wrong results

What changes were proposed in this pull request?
This PR fixes the following to make checkAnswer raise TestFailedException again instead of java.util.NoSuchElementException: key not found: TZ in the environments without TZ variable. Also, this PR adds QueryTestSuite class for testing QueryTest itself.
- |Timezone Env: ${sys.env("TZ")}
+ |Timezone Env: ${sys.env.getOrElse("TZ", "")}

How was this patch tested?
Pass the Jenkins tests with a new test suite.

Test build #63332 has started for PR 14528 at commit 9c4f02b.

Test build #63332 has finished for PR 14528 at commit 9c4f02b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class QueryTestSuite extends QueryTest with test.SharedSQLContext

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63332/
Test PASSed.

Hi, @rxin .
Could you review this PR please?

LGTM

Oh, thank you, @srowen !

Merged to master

Thank you, @srowen .


Add Richardson number diagnostic

Thanks @tomchor for Oceanostics.jl!
Resolves #81
Note: This PR depends on #85.

Per the discussion in https://github.com/tomchor/Oceanostics.jl/issues/1, it's best to wait until the signature of richardson_number_ccf! changes, before merging, no?

I'm happy to wait to make the change before merging. Otherwise I think the script will break on master without a future PR.

@ali-ramadhan Are you going to make that changes in Oceanostics.jl or should I? I might take a little while until I'm able to do it

I might be able to but maybe not for a couple of days.
I'll revisit this PR then and if the change hasn't been made I can open a PR on Oceanostics.jl.

Alright, leave it with me then! I think I can do it faster.


Update new event name and add link to ALA article

There was a recent spec and implementation change in the Window Controls Overlay feature.
One method name changed, and one event name changed. Our docs refer to the latter, so it needs to be updated.
I'm also taking this opportunity to link the Window Controls Overlay docs to the new third-party blog post I wrote, since it's a good tutorial on this topic.

Docs Build status updates of commit 1332ce9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/how-to/window-controls-overlay.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update DockerHub automatic building

Update due to new github repository URL
TODO: do we need -devel versions of images? Currently only master branch triggers image building

Once the images are running at a customer you might want to develop and test changes (i.e. run devel images in a test server) before merging to master.

Docker Hub Registry seems to require organization access.
See also https://docs.docker.com/docker-hub/builds/ for details

It is working again upon changes to devel branch


NotClaims Example had AndClaims

Updated Example to use NotClaims

@WhippsP : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.

#sign-off


Locked status not getting updated in home assistant

PROBLEM DESCRIPTION
After upgrading to 8.35 the lock state isn't updating in home assistant.
I had to do a factory reset during the install process for the lock state to how at all in either the nukihub webui or over MQTT.
You can see in the screenshot below that the lock state is actually published and correct over MQTT, but it is never updated in home assistant.
So I know MQTT is working. But for some reason home assistant never updates the status. Not sure if something has changed in the auto discovery or because I factory reset the ESP?
REQUESTED INFORMATION
Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

TO REPRODUCE

Update to 8.35
Factory reset
Re-pair device
Unlock from home assistant
Home assistant triggers unlock but never updates it's status

EXPECTED BEHAVIOUR
When unlocking in home assistant, it should update to status unlocked.
SCREENSHOTS
Locked

Unlocking

Unlocked

Home Assistant

ADDITIONAL CONTEXT
Nothing to add

Doh yes you're correct. Completely missed that! Think I was thrown slightly by the fact it was partially working.
All good now, thank you!


First batch of new input components

Description

DateAgg

ButtonGroup

Works with queries using the same interface as Dropdown
TextInput

Exposes the .search function, .sql was left in but no strong feelings here
Checklist

[x] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset
[ ] I have updated the documentation to reflect changes to component interfaces

These seem like great input component! All below comments are to do with semantics, not code review.
Was just thinking that the name for DateAgg feels a bit off. Triggered this slightly longer thought about names:
Would be great to think about future inputs when deciding names. Here are some I think we are likely to want to support (without any names):

Image
Input Type
Data Type
Aggregation?
Multi Select
Notes

Dropdown
Any / String
None
No
Existing

Dropdown
Any / String
None
Yes

Multi Button
Any / String
None
Possible

Text
Any / String
None
No

Date Picker
Date / Datetime
Possible?
No
Aggregation if the series is datetime not date

Text
Numeric
None
No

Checkbox
Bool
None
No
On / Off

Slider
Numeric, Datetime
None
Either Single Slider or Min/Max

I can think of a couple of options make sense for naming

Everything is an input, and then there are input types, and other props

<Input type=dropdown/>
<Input type=dropdown multiselect=true/>
<Input type=buttonGroup/>, <Input type=buttonGroup multiselect=true/>
<Input type=text/>
<Input type=date/>
<Input type=number/>
<Input type=checkbox/>
<Input type=slider min=input_min max=input_max/>

Everything is a named input component, with props to modify

<Dropdown/>
<Dropdown multiselect=true/>
<ButtonGroup/> <ButtonGroup multiselect=true/>
<TextInput/> / <Search/>
<NumberInput/>
<DateInput/>
<CheckBox/>
<Slider/> <Slider min=input_min max=input_max/>

For the above four components, this would either lead me to:

Everthing is an input
A. <Input type=buttonGroup preset=weekMonthYear/> // the date aggregation is a special case of the button group?
B. <Input type=buttonGroup/>
C. <Input type=text/>

Named Components
A. <ButtonGroup preset=weekMonthYear/> // I'd also imagine you might theoretically want other presets here in the future: weekMonth, dayMonthYear,
B. <ButtonGroup/>
C. <TextInput/>

I'm leaning towards option 2 as it aligns more closely with the chart library today. <BarChart/> LineChart etc.

Great feedback @archiewood
I think I'm leaning towards option 2 as well; it will be more difficult to add intellisense in the future with option 1 as well
I'll make the change to the preset prop, as that's a pretty easy win

I'm also not tied to preset as a name. More the idea of it being a prop vs a standalone new component.

Other prop name ideas:

config=weekMonthYear
custom=weekMonthYear
template=weekMonthYear
scaffold=weekMonthYear
grains=weekMonthYear
timeGrains=weekMonthYear

Or for a more flexible approach we could pass an array, but the syntax would be more horrible:
{[week,month,year]}

I'm open to workshopping it but I do think that preset makes sense - they don't all need to be dates for what it's worth
The granularity does look nice but I don't want to put that straight onto the ButtonGroup component, as there is not direct relation to time there

Don’t want to hold this up so preset fine by me!
[https://res.spikenow.com/c/?id=um5id4ocumv9yf83&s=48&m=c&_ts=2edjhk]           Archie - Chat @ Spikehttps://spikenow.com/r/a/?ref=spike-organic-signature&_ts=2edjhk [2edjhk]
On December 28, 2023 at 17:00 GMT, Brian D<EMAIL_ADDRESS>wrote:
I'm open to workshopping it but I do think that preset makes sense - they don't all need to be dates for what it's worth
The granularity does look nice but I don't want to put that straight onto the ButtonGroup component, as there is not direct relation to time there
—
Reply to this email directly, view it on GitHubhttps://github.com/evidence-dev/evidence/pull/1436#issuecomment-1871345700, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN3CLAVZDFO62TNQ6B6PCYTYLWQT7AVCNFSM6AAAAABBEYG3ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGM2DKNZQGA.
You are receiving this because you were mentioned.Message ID: @.***>
[https://bolt.im/t/?tYDCvq4nATKCz1B6NvCC5k3WmlZ1FmOQ73dTld2m2NnSkqpjsIMEQLoAIfAVau9nqQ7Xudc_dRsCnL3wsfATYw]

I might just do a reorg of these input docs a bit, and add to the all-components grid


[Bug]: Code is wrong reporting "operator towhee/select not found!" in face-landmark-detection for mobilefacenet

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
>>> towhee.glob('/Users/binbin/Towhee_projects/image.png') \
...   .image_decode.cv2() \
...   .face_landmark_detection.mobilefacenet() \
...   .select('img','landmark') \
...   .to_list()
2022-07-20 12:08:07,482 -<PHONE_NUMBER> - git_utils.py-git_utils:96 - ERROR: towhee/select repo does not exist.
Traceback (most recent call last):
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/operator_loader.py", line 134, in load_operator_from_cache
    path = fm.get_operator(operator=function, tag=tag)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/hub/file_manager.py", line 451, in get_operator
    git.clone(tag=tag, install_reqs=install_reqs, local_repo_path=repo_path)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/utils/git_utils.py", line 97, in clone
    raise ValueError(f'{self._author}/{self._repo} repo does not exist.')
ValueError: towhee/select repo does not exist.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/hparam/hyperparameter.py", line 198, in __call__
    return self._func(*args, **kws)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/functional/data_collection.py", line 156, in wrapper
    return self.map(op)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/functional/mixins/dag.py", line 11, in wrapper
    children = f(self, *arg, **kws)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/functional/data_collection.py", line 315, in map
    if hasattr(unary_op, 'is_stateful') and unary_op.is_stateful:
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/execution/stateful_execution.py", line 30, in is_stateful
    self.__check_init__()
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/factory.py", line 93, in __check_init__
    self._op = op(self._name,
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/factory.py", line 61, in op
    return loader.load_operator(operator_src, arg, kwargs, tag)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/operator_loader.py", line 162, in load_operator
    op = factory(function, arg, kws, tag)
  File "/Users/binbin/towhee-test-env-3.8-0.7.3/lib/python3.8/site-packages/towhee/engine/operator_loader.py", line 136, in load_operator_from_cache
    raise ValueError('operator {} not found!'.format(function)) from e
ValueError: operator towhee/select not found!

Expected Behavior
I think here ".select('img','landmark') " is wrong?
The following is correct with ".select'img','landmark' "
>>> towhee.glob['path']('/Users/binbin/Towhee_projects/image.png') \
...   .image_decode.cv2['path', 'img']() \
...   .face_landmark_detection.mobilefacenet['img', 'landmark']() \
...   .select['img','landmark']() \
...   .show()
<IPython.core.display.HTML object>

Steps To Reproduce
https://towhee.io/face-landmark-detection/mobilefacenet

Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):towhee 0.7.3.dev32 (models latest)
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

It has been fixed，please check the latest doc.


Case Studies into new template

please always squash commits when possible to keep the commit history on master as clean as possible!


Further improvements to curl rules

Description:
This adds the following improvements to the CURL rule. It closes #1589.

curl-auth-header matches provider-specific headers like X-AIO-Key or X-Octopus-ApiKey.
curl-auth-user no longer matches placeholders where individual segments are quoted (e.g., "${USR}":"${PWD}").

Checklist:

[x] Does your PR pass tests?
[x] Have you written new tests for your changes?


peer to peer code Review

-great work on the website it looks professional
-nicely designed
-codes well organized
-perfect accessibility feature
-one thing you need to fix is the typo on the form, it needs to be spelled correctly

i fix the errors of reviewed by peer to peer


Support built-in config types for Optuna

ppe's config supports custom types. It seems nice to prepare built-in types for related libraries like Optuna. In this PR, I added 2 features, optuna_types and load_path_with_optuna_types.
optuna_types
It returns types dictionary according to input trial. We need to update it when Optuna adds new types.
load_path_with_optuna_types
It's similar to Config.load_path. The difference is default types. It adds suggest_* according to input trial. If input types already has suggest_* key, it warns.

In pytorch_pfn_extras/config_types.py, Optuna is never imported so that it does not require to install Optuna if user doesn't use it. But for test, it requires Optuna. Then setup.py is updated.

@Hakuyume @yuyu2172 Could you take a look on this?

/test

/test

The test seems failing. (note that all warnings are treated as error via filterwarnings in pytest.ini)

Now, the code warns when user uses pre-defined keys for Optuna like optuna_suggest_categorical. I'll add lines to deal with the warnings. I hope I can learn how to deal with warnings.
https://github.com/pfnet/pytorch-pfn-extras/blob/master/tests/pytorch_pfn_extras_tests/training_tests/extensions_tests/test_plot_report.py

I checked that the latest commit catches all warnings in my local env. Can you test it?

/test

@dhgrs Could you check flake8 errors? LGTM otherwise :+1:
https://ci.preferred.jp/pytorch-pfn-extras/64793/#L513

Fixed it. I checked that flake8 succeeds locally. Although I'm not sure the version of flake8 for CI, it might pass. Could you run the test again?

/test

/test


[#869] Add DeRegKey generator & property

Closes #869.

Somehow I was able to merge this PR, after it passed CI, and now I believe that master is currently non-buildable. As of eaa4a10c I see:
$ cabal v2-test delegation-test

...

src/Delegation/Certificates.hs:83:13: error:
    • Expecting one more argument to ‘DCert h d’
      Expected a type, but ‘DCert h d’ has kind ‘* -> *’
    • In the type signature: isRegKey :: DCert h d -> Bool
   |
83 | isRegKey :: DCert h d -> Bool
   |             ^^^^^^^^^

src/Delegation/Certificates.hs:88:15: error:
    • Expecting one more argument to ‘DCert h d’
      Expected a type, but ‘DCert h d’ has kind ‘* -> *’
    • In the type signature: isDeRegKey :: DCert h d -> Bool
   |
88 | isDeRegKey :: DCert h d -> Bool
   |               ^^^^^^^^^
cabal: Failed to build delegation-<IP_ADDRESS> (which is required by
test:delegation-test from delegation-<IP_ADDRESS>).

I'm really confused how a kind mismatch of this basic a sort could possible not get caught, in developing, as well as CI.

Development could possibly be explained by different compiler versions. I’m surprised the CI accepts it though.
Sent from my iPhone

On 9 Oct 2019, at 20:13, Michael Hueschen<EMAIL_ADDRESS>wrote:
Somehow I was able to merge this PR, after it passed CI, and now I believe that master is currently non-buildable. As of eaa4a10 I see:
$ cabal v2-test delegation-test
...
src/Delegation/Certificates.hs:83:13: error:
• Expecting one more argument to ‘DCert h d’
Expected a type, but ‘DCert h d’ has kind ‘* -> *’
• In the type signature: isRegKey :: DCert h d -> Bool
|
83 | isRegKey :: DCert h d -> Bool
|             ^^^^^^^^^
src/Delegation/Certificates.hs:88:15: error:
• Expecting one more argument to ‘DCert h d’
Expected a type, but ‘DCert h d’ has kind ‘* -> *’
• In the type signature: isDeRegKey :: DCert h d -> Bool
|
88 | isDeRegKey :: DCert h d -> Bool
|               ^^^^^^^^^
cabal: Failed to build delegation-<IP_ADDRESS> (which is required by
test:delegation-test from delegation-<IP_ADDRESS>).
I'm really confused how a kind mismatch of this basic a sort could possible not get caught, in developing, as well as CI.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Some very rare advice for a promising programmer

Selectrum and prescient look very interesting, but they lack any defclass. Unless they are generated using an external defclass macro; If so, the first advice might not be very useful.
The advice: There is a book, which the advisor hasnt finished, titled 'The art of the metaobject protocol'. Anyone reading the book who is able to grasp as little as half of it will never want to program without its approach.
PS. On the human health issue, the authors to read are Wilhelm Reich and Alexander Lowen; they have discovered what the current society cannot acknowledge without being dissolved.
Good luck through the upcoming greatest human-made upheaval in history.
There will be no followup on GH.

The book "The art of the metaobject protocol" is a classic book about cl, describing the common lisp object system. So it is probably not a bad advice to read this. I haven't done so, since I am more of a fan of functional programming style. There is certainly some value in digging through how the oop system is structured, including smalltalk and the metaobject protocol :smile:

https://en.wikipedia.org/wiki/Metaobject#Metaobject_protocol
https://en.wikipedia.org/wiki/Smalltalk
https://en.wikipedia.org/wiki/The_Art_of_the_Metaobject_Protocol

I have no experience with CLOS, most of my programming experience is coming from Emacs/Elisp where it isn't often used. I'm interested to learn more about it though, so thanks for the book recommendation which goes to my always growing reading list :laughing:

I'm not a huge fan of CLOS and haven't used it in my projects. I prefer to use more basic data structures that can be mutated using the standard functions, since I generally find that makes code more hackable.
That said, there's definitely a use case for CLOS, and I've got no objection to pulling it in where it helps make things clearer.


MLOps reference list for models and pipeline implementations

Need to keep a better record of models and their usages / status. This information is available but not yet federated across pipelines deployed on different HPC, so would be useful for all collaborators to keep track of.
Especially useful if we come to publish any reference models and/or archive existing pipelines

[x] Basic spreadsheet implementation
[ ] Integration with tracking / MLOps service(s)

[ ] Evaluation of wandb
[ ] Evaluation of ... (forgotten the name of other services, there are many)
[ ] Contrast against self-storage approaches

A spreadsheet tracking the extant models is available for viewing here. - please request access from @JimCircadian if you need to edit it.
Unassigning myself as the progression to employing more integration / external services is not justifiable effort at present, we're really not at the position to establish clear enough requirements and even the spreadsheet is effectively duplicating the information from the pipeline configurations. Admittedly it makes it a bit more visible, so that's no bad thing, so that will do for now.

Wandb has been removed by default in the latest 0.2.4 release, as it was causing lots of people setup headaches. It's now completely optional.
In terms of alternate integrations / evaluation metrics, this can be approached on a case by case basis, but there's no overarching requirement in the project to spend time doing this just for the sake of additional integrations. Once a requirement is specified or warranted, it can be raised as an issue in the appropriate place. 😉


Modify import map after loading @jspm/generator

I'm successfully using @jspm/generator to generate my import map. Then adding that map to the document head and executing modules. This however only works with es-module-shims and the module-shim/importmap-shim script types. If I don't use the shim I get An import map is added after module script load was triggered.
Is there a way to use @jspm/generator in the browser without initializing a module so I can avoid the An import map is added after module script load was triggered. error?

@FallingSnow in this case you should use an iframe to handle it!

Sorry for commenting on this already closed issue, but it's the only information I've found about dynamic import maps. If it's not too much to ask, would you mind giving me some pointers, how one would implement dynamic import maps with an iframe? Thanks!

If I remember correctly (I might be wrong) but the An import map is added after module script load was triggered. is a limitation of the browser. Therefore the proposed work around is by guybedford is to use an iframe to workaround the issue, how to do that I'm not really sure. Perhaps you can load your generating modules, generate the dynamic import map, then load your site in an iframe. Although this seems kind of hacky and I'm not sure if there would be any context restrictions.
I do remember that the method I was trying to do proved to be too unstable and I reverted to just prebuilding the import map.

That iframe solution is not much better than just saving the importmap in localStorage and refreshing the page with a script that re-creates the import map from localStorage after the refresh. I thought there was a way to break out of the iframe and affect the parent scope. Thanks for the explanation!

I believe iframes have lower restrictions if they share the same domains, so that may be possible. But again to me it seems like a, all be it fun, but over complicated solution.


Use more common USB-C connector footprint & update to KiCad 8 w/ JLCPCB plugin

Connector in the original design was not available and have a rare footprint, so it was replace with another one with a more common footprint and plenty of alternative parts.
Fixes issue #65

Thank You for your pull request.
I am going to leave this idle for now, due to time constraints, but I will remember it when we will have supply chain problems again ;-)

@lexszero I tried to order your newer version, but the alignment of the USB-C connector doesn't seem right to me.

@lexszero I tried to order your newer version, but the alignment of the USB-C connector doesn't seem right to me.
Edit: U1 seems to be wrongly oriented, too.

Yeah, I had similarly misaligned parts on preview when ordering, after quick chat with support they assured me that preview is not very accurate and their engineers will check and correct the design files in DFM before assembly. They were right, and it turned out to be fine, I have received perfectly working PCBs. It seems that KiCAD JLCPCB export plugin has bugs, or I'm doing something wrong (I'm not an expert in KiCAD and if you're choosing to proceed, you're doing it at your own risk).

Thanks for getting back to me!
Yeah, I'm no expert either. I have yet to order a board that works first try. 😅
I'm still undecided whether I want to submit a seemingly broken version, but I do think that this should not be merged yet. We should at least document this problem.
Really appreciate your work, especially since there are out-of-stock parts in the official version. Once there's a less sketchy version available, I'll be happy to give it a try.

In remember editing the USB socket in the current design due to this issue...

@lexszero The gerber file you provided has one small error. The solder paste is not aligned with the holes of the USB-C connector:

Apart from that everything seems working, have ordered 50 boards with your gerber.
One improvement that could be made is changing MHT192UGCT to 19-217/GHC-YR1S2/6T, which is an "Extended Part 👍" type according to https://jlcpcb.com/parts/basic_parts, which could reduce the extended component fee.

I took over your changes from this PR into PR https://github.com/skuep/AIOC/pull/93
Thanks a lot for the suggestion, I ultimately decided on the same GCT part


feat(nodejs): table.search functionality

closes https://github.com/lancedb/lancedb/issues/1256

@wjones127

My main question is whether we want to have a new search() method, or are we fine just using query()? Or, put another way, why not just make nearestTo take the string/embedd-able data?

good question. We could instead make query take in the string parameter instead.
I think intuitively .query("some string") feels much more natural than starting the builder first. .query().nearestTo("some string").

I think intuitively .query("some string") feels much more natural than starting the builder first.

I think the idea is that query is more general than search. The query API can also be used to do a scan.

@wjones127 @westonpace Do we have any way to run CI without cache? It seems like it's using cached code

Error: lancedb/table.ts(146,7): error TS2663: Cannot find name 'schema'. Did you mean the instance member 'this.schema'?

lancedb/table.ts(146,7) has no reference to schema


Script broken

DCS: Mission script error: : [string "C:\Users\MARIOS~1\AppData\Local\Temp\DCS.openbeta\/~mis00002018"]:288: attempt to index field 'Logger' (a nil value)
stack traceback:
	[C]: ?
	[string "C:\Users\MARIOS~1\AppData\Local\Temp\DCS.openbeta\/~mis00002018"]:288: in main chunk

Please read the release descrption. This script requires the development version of MIST now. It's bundled with the .zip archive.


bug when using clientScripts in conjunction with clientScripts

What is your Test Scenario?
when using the clientScripts in a testcafe config, if you then try to use t.navigateTo an error occurs.  all details and repro steps can be found here: https://github.com/testing-library/testcafe-testing-library/issues/222
What is the Current behavior?

error
What is the Expected behavior?

no error
What is your web application and your TestCafe test code?

Execute this command...
See the error...

Your Environment details:

testcafe version:
node.js version:
command-line arguments:
browser name and version:
platform and version:
other:

Hello @benmonro,
Thank you for your report. I've reproduced this issue. We'll update this thread once it's fixed.


Upgrade to Astro 2.0

:tada: This PR is included in version 2.10.20 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bluetooth: Mesh: Node Reset Not Clear Bind Key Information

After receive node reset message, local node exec bt_mesh_reset
mod->flag will be fill in some values, but bt_mesh_comp_unprovision clear those mod->flag cause https://github.com/zephyrproject-rtos/zephyr/blob/b3da9efbec586bdac0c61671c189b1b6f13eb4ae/subsys/bluetooth/mesh/settings.c#L1556-L1577 not executed.
https://github.com/zephyrproject-rtos/zephyr/blob/43f833800ce9da195985133d070455bef8ddc5b0/subsys/bluetooth/mesh/main.c#L111-L154
https://github.com/zephyrproject-rtos/zephyr/blob/b3da9efbec586bdac0c61671c189b1b6f13eb4ae/subsys/bluetooth/mesh/access.c#L328-L340

CC @jhedberg

@LingoMeng so you're saying the model configuration doesn't end up being removed from flash although the rest of the network configuration is? Are you planning to submit a PR for this? Btw, I didn't see you quote the exact place where mod->flags gets cleared. Your second quote contains bt_dev.flags which is a different variable. @trond-snekvik FYI.

Sorry, maybe I initialized this value in the model initialization callback. model_init[i].init,


Removed "experimental" from Adapter API references

OK to be merged as soon as we no longer want to refer to Adapters/Adapter API as "experimental." (Now?)
Changes:

Page title in Left Sidebar (under Reference)
Warning on and title of Adapter API page itself (adapter-reference)
Link to the Experimental Adapter API from integrations-reference

LGTM! I did a fast "search and find" through all the pages and didn't found any other reference to the adapter API as experimental. 🚀


TextArea not supported.

Dear developers of the Dracula UI.
Unfortunately, the UI framework lacks lots of basic items, which I have to add manually each time. One of those is support for the HTML textarea element. Should I create a pull request manually for this? Or will this be implemented.
Thanks.

@skywa04885 looks like there is nothing about it on Discussions or another issue regarding Textarea, so I wonder if that could be a good chance for to you contribute to the project.

pull request submitted with textarea support https://github.com/dracula/dracula-ui/pull/154


The vue component library uses defineAsyncComponent, which is used in the project and reports an error component is missing template or render function.

Vue version
3.2.38
Link to minimal reproduction
https://sfc.vuejs.org/#eNo9j71uwzAMhF+F5eIWqCV0NZQA3foGXbikjpw40B9EOR0EvXspp8imu9N9OFb8TEndN4sTGp7zmgqwLVs6Ulh9irlAhWwXaLDk6GGQrwMFCnMMXMDzBQ49fx2+rHMRvmN255fhjYLRD5yARBTrkzsVKwrAXD+Ote7l1owWtbtrSFuB++jj2boDoeSEEhn9bOM7PlaN/pTUjWOQ3bW36T9gwgl2p3uytmvCaymJJ615mfu1N1YxX7S8VN5CWb1Vlv34k+Mv2yxgwo5oFBq2P3/sZE8=
Steps to reproduce
Use rollup to compile the component library and use the component in the project
component library version
{
    "rollup": "^2.77.2",
    "rollup-plugin-vue": "6.0.0",
    "@vue/compiler-sfc": "3.2.45",
}

What is expected?
Import display components normally
What is actually happening?
[Vue warn]: Component is missing template or render function
System Info
No response
Any additional comments?
No response

No reproduction provided

No reproduction provided

Let me see how to provide it, this link is a bit long, one is in the component library, and the other is the project.


Remove factory impl check in fork test

Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors.  This removes that check from the fork tests

Current dependencies on/for this PR:

main

PR #331   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 8, 6:27 PM: @oveddan merged this pull request with Graphite.


Feat/menu component

сreate new shared menu component
add no-tick option for dropdown-list item
create new demo-shared component for demostrating shared components

@yuriMalakhov There are some troubles with protractor. Can you have a look at travis console?

@dima716 Please, squash your 8 commits to up to 3 commits, so the history becomes cleaner.

@yuriMalakhov squashed into 2 commits. It seemed more logical to leave only two.

Let's squash again. Unnecessary empty commit https://github.com/aitarget/aitarget-components/pull/188/commits/ff8c8e90b42fb22717ebdd2e40c74fe31d8ca4ff


READ_PHONE_STATE permission required?

The UserVoice SDK adds the READ_PHONE_STATE permission, which prevents me from uploading an app to the Play Store without providing a privacy policy.
Excerpt from manifest-merger-debug-report.txt:
ADDED from [com.uservoice:uservoice-android-sdk:1.2.7] C:\[...]\.gradle\caches\transforms-1\files-1.1\uservoice-android-sdk-1.2.7.aar\9be21ba0ec6436245a941264c65a5fd8\AndroidManifest.xml:32:13-80 uses-permission#android.permission.READ_PHONE_STATE
As this is currently preventing me from uploading any new builds to the Play Store, I would appreciate a quick response as to why this permission is required  and if it is possible to remove it.

UVConfig *config = [UVConfig<EMAIL_ADDRESS>[UserVoice initialize:config];
[UserVoice presentUserVoiceInterfaceForParentViewController:self];


Add validation for functions existing

Closes #123
PTAL @rpaul-stripe

In the Stripe documentation, we compute the variables that we pass into the Markdoc environment per request because many of the values are specific to the individual user. That means we don't have the variables available in any of the places where we perform validation internally (CI or our VSCode extension). We would expect config.variables to be undefined in those environments and don't want that to be treated as an error.
Maybe we could make it so that variable validation only occurs if config.variables exists?

In the Stripe documentation, we compute the variables that we pass into the Markdoc environment per request because many of the values are specific to the individual user. That means we don't have the variables available in any of the places where we perform validation internally (CI or our VSCode extension). We would expect config.variables to be undefined in those environments and don't want that to be treated as an error.
Maybe we could make it so that variable validation only occurs if config.variables exists?

@rpaul-stripe this validation is only checking that the variables object has the property, not if the value is correct, so even if we keep this PR as is I believe it will still work.
Though I am totally peaceful with only validating if config.variables.

@rpaul-stripe just updated this to only validate if config.variables exists—PTAL


Rename StdAssertions.sol logs

This PR changes the Expected and Actual logs for assertEq functions in StdAssertions.sol to that of Left and Right, respectively.
This is done to match the assert_eq macro in Rust and improve readability.

Thanks @Sabnock01!
@d-xo would you accept a similar PR to ds-test upstream to keep the assertion logs consistent?

Hey, sorry for the delay.
Yes I would, think this is much nicer than what we have now actually :)

@Sabnock01 Do you mind submitting the upstream PR to https://github.com/dapphub/ds-test? The once that's merged we can bump the submodule version in this PR
(cc @mattsse @gakonst for awareness in case this breaks any tests upstream in the main foundry repo)

@mds1 upstream PR to ds-test has been merged by d-xo. We're good to proceed with this whenever.

Two things left before we can release:

There's still a few expected/actual changes in StdAssertions that were missed in this PR that we'll need to do in a follow up PR. I think the only ones are in the two assertApproxEqAbsDecimal methods and the two assertApproxEqRelDecimal methods, and a few comments still say expected/actual instead of left/right
Need to bump ds-test submodule

If anyone wants to tackle those in another PR that would be great, otherwise I should be able to get to it later this week

Two things left before we can release:
1. There's still a few expected/actual changes in `StdAssertions` that were missed in this PR that we'll need to do in a follow up PR. I think the only ones are in the two `assertApproxEqAbsDecimal` methods and the two `assertApproxEqRelDecimal` methods, and a few comments still say expected/actual instead of left/right

2. Need to bump ds-test submodule

If anyone wants to tackle those in another PR that would be great, otherwise I should be able to get to it later this week

I'll take care of it sometime today.


GH-44167: [C++][Acero] Add more row segmenter tests

Rationale for this change
See #44167 .

What changes are included in this PR?
More tests covering other fixed width types for row segmenter.

Are these changes tested?
Yes.

Are there any user-facing changes?
None.

GitHub Issue: #44167

Are there tests with non-constant input too?

Are there tests with non-constant input too?

There are individual tests with non-constant input, but they all assume int32 "array". So in terms of combinations of various data types x column shapes, no there are not.
But I assume the tests being touched in this PR are just the ones to complement this part. Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.

Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.

A non-constant batch (even with only two distinct values) would ensure the segmenting actually works :-)

Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.

A non-constant batch (even with only two distinct values) would ensure the segmenting actually works :-)

Makes sense. I'll see how to enhance this.

CI failures are unrelated, let's merge :-)


Database Query Generation - Nested Inserts

Implement the changes to generate the necessary database queries to successfully perform a nested create mutation
Related Issue: Database Query Generation Design - Nested Inserts

needs consolidation of code from AuthZ nested mutation pr and config-only defined relationship support.


Error generating gallery

I am trying process with my local directory. Process works fine till generation of thumbnails but Gallery is not generating.
Filenames:
Home_1Dec-win8.1-ie-11.0.png
Home_2Dec-win8.1-ie-11.0.png
Home_1Dec-win8.1-ie-11.diff
Home_1Dec-win8.1-ie-11.data
wraith 4.0.0
ruby 2.3.0p0 (2015-12-25 revision 53290) [x64-mingw32]
C:\wraith>wraith generate_gallery config
GENERATING GALLERY
C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:63:in `figure_out_url': undefined method `[]' for nil:NilClass (NoMethodError)
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:53:in `matcher'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:40:in `block (2 levels) in match'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:38:in `foreach'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:38:in `block in match'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:35:in `each'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:35:in `match'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:31:in `parse_directories'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:142:in `generate_gallery'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/cli.rb:114:in `block in generate_gallery'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/helpers/utilities.rb:4:in `within_acceptable_limits'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/cli.rb:111:in `generate_gallery'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/bin/wraith:5:in `<top (required)>'
        from C:/Ruby23-x64/bin/wraith:22:in `load'
        from C:/Ruby23-x64/bin/wraith:22:in `<main>

my config file below:
#phantomjs_options: --ssl-protocol=tlsv1

# (required) The domains to take screenshots of.
#domains:
#  dev: "http://dev.upf.sites.capitalnumbers.com"
#  live: "https://theupsstorefranchise.com"

# (required) The paths to capture. All paths should exist for both of the domains specified above.
#paths:
#  home:     /

# Type the name of the directory that shots will be stored in
directory: 'abc/win8.1-ie-11.0'

#Type screen widths below, here are a couple of examples
#screen_widths:
#  - 320

#Amount of fuzz ImageMagick will use
fuzz: '20%'

#Choose how results are displayed, by default alphanumeric. Different screen width are always grouped.
#alphanumeric - all paths (with, and without, a difference) are shown, sorted by path
#diffs_first - all paths (with, and without, a difference) are shown, sorted by difference size (largest first)
#diffs_only - only paths with a difference are shown, sorted by difference size (largest first)
mode: alphanumeric
verbose: true
threshold: 15

That is because wraith.domains is undefined (https://github.com/BBC-News/wraith/blob/master/lib/wraith/gallery.rb#L63)
If your YAML file does look like this, then domains is indeed undefined, because the # comments it out.
# (required) The domains to take screenshots of.
#domains:
#  dev: "http://dev.upf.sites.capitalnumbers.com"
#  live: "https://theupsstorefranchise.com"

Try removing the # from your config, i.e.
# (required) The domains to take screenshots of.
domains:
  dev: "http://dev.upf.sites.capitalnumbers.com"
  live: "https://theupsstorefranchise.com"

(and do the same everywhere else you have a # commenting a property out.

Did it. Still getting following error
C:\wraith>wraith generate_gallery config
GENERATING GALLERY
(erb):38:in block (2 levels) in get_binding': undefined method >' for nil:NilClass (NoMethodError)
from (erb):32:in each'         from (erb):32:in block in get_binding'
from (erb):31:in each'         from (erb):31:in get_binding'
from C:/Ruby23-x64/lib/ruby/2.3.0/erb.rb:864:in eval'         from C:/Ruby23-x64/lib/ruby/2.3.0/erb.rb:864:in result'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:158:in generate_html'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/gallery.rb:145:in generate_gallery'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/cli.rb:114:in block in generate_gallery'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/helpers/utilities.rb:4:in within_acceptable_limits'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/lib/wraith/cli.rb:111:in generate_gallery'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in run'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in invoke_command'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in dispatch'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in start'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/wraith-4.0.0/bin/wraith:5:in <top (required)>'
from C:/Ruby23-x64/bin/wraith:22:in load'         from C:/Ruby23-x64/bin/wraith:22:in '

I'm not sure how those filenames are getting generated?
Home_1Dec-win8.1-ie-11.0.png
Home_2Dec-win8.1-ie-11.0.png
Home_1Dec-win8.1-ie-11.diff
Home_1Dec-win8.1-ie-11.data

Wraith only supports Phantom and Casper out of the box, so I'd expect to see Home_1Dec-phantom.png, for example. How did you get it using IE 11?
I think the problem stems from the . in win8.1.

If you're naming them manually, try using filenames without . and - in them.

Yeah.. I am working with local image folders & so giving names manually. I just tried out commands crop_images, compare_images, generate_thumbnails & then generate_gallery on these folders. Now it works for filenames without . & - in them + commenting out domain property [though i didn't get why do we need domains!!!!]. Gallery generated successfully. Thanks.


Support reading of options from my.cnf for MySQL

Description
Support reading of options from my.cnf for MySQL
Issues Resolved
Similar to: https://github.com/chef-cookbooks/database/pull/33
Check List

[+] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[-] New functionality includes testing.
[+] New functionality has been documented in the README if applicable
[+] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

I cannot run tests on even on tag 5.1.2. I tried CentOs, Ubuntu, Debian. It fails to install mysql2 gem. Is it related to this cookbook or it is a problem with mysql2_chef_gem?
Personally I found that it is much easy to install required packages and then simply run:
chef_gem 'mysql2' do
  compile_time false
end

Please tell me something. It is very hard to write patches without tests. I want to contribute a few more things.

Sorry for rebase. Now it all works, description edited. Ready for merging.


support for iOS?

Just wondering where I could find the local.properties file?
Also, does react-native-secure-api work for iOS?

Hello @vbylen
No questions are dumb😊
You can find local.properties in your android folder
If not then you can create the file manually.
This package does not have support for iOS yet, but we will soon update it.


Display bug on Proposal Page

Colors are wrong and voting weight is running off screen

Closed in #149


Java code highlighting not working

Details
Java-Color-highlight is working fine locally, but not working on RTD.

Read the Docs project URL:  http://javaguide.readthedocs.io/en/latest/java/basic.html#hello-world

Build URL (if applicable): https://readthedocs.org/projects/javaguide/builds/7133222/

Read the Docs username (if applicable): pythondsp

Expected Result
A description of what you wanted to happen
Actual Result
A description of what actually happened

I think this is the same issue as https://github.com/rtfd/readthedocs.org/issues/4050

Thanks, it's working fine after adding "sphinx_rtd_theme>=0.3.1" in requirements.txt


BUG (likely): DBSCAN producing strange results on a geographical dataset

Describe your issue.
The issue has been described under this StackOverflow question: https://stackoverflow.com/questions/76774329/dbscan-producing-strange-results-on-a-ships-location-dataset
The dataset: https://pastebin.pl/view/86b44fe9
Reproducing Code Example
from sklearn.cluster import DBSCAN

file = open("86b44fe9.txt", "r")
lines = file.readlines()
x = []
for p in lines:
    poi = p.rstrip("\n").split(" ")
    x.append([float(poi[2]), float(poi[3])])

# Parameters of DBSCAN
min_samples = 42
eps = 0.001

dbscan = DBSCAN(eps, min_samples).fit(x) # fitting the model
labels = dbscan.labels_

out_file = open("clusters.txt", "w")
for p in range(len(lines)):
    poi = lines[p].rstrip("\n").split(" ")
    out_file.write(poi[0] + " ")
    out_file.write(poi[1] + " ")
    out_file.write(str(labels[p]))
    out_file.write("\n")

out_file.close()

Error message
There is likely a logic error.

SciPy/NumPy/Python version and system information
1.10.1 1.23.5 sys.version_info(major=3, minor=8, micro=3, releaselevel='final', serial=0)
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: c:/opt/openblas/if_32/64/include
    lib directory: c:/opt/openblas/if_32/64/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= PRESCOTT MAX_THREADS=4
    pc file directory: c:/opt/openblas/if_32/64/lib/pkgconfig
    version: 0.3.18
  lapack:
    detection method: pkgconfig
    found: true
    include directory: c:/opt/openblas/if_32/64/include
    lib directory: c:/opt/openblas/if_32/64/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= PRESCOTT MAX_THREADS=4
    pc file directory: c:/opt/openblas/if_32/64/lib/pkgconfig
    version: 0.3.18
Compilers:
  c:
    commands: cc
    linker: ld.bfd
    name: gcc
    version: 10.3.0
  c++:
    commands: c++
    linker: ld.bfd
    name: gcc
    version: 10.3.0
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 0.29.33
  fortran:
    commands: gfortran
    linker: ld.bfd
    name: gcc
    version: 10.3.0
  pythran:
    include directory: C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-yajwq4a4\overlay\Lib\site-packages\pythran
    version: 0.12.1
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: windows
  cross-compiled: false
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: windows
Python Information:
  path: C:\Users\runneradmin\AppData\Local\Temp\cibw-run-5o1gjg1j\cp38-win_amd64\build\venv\Scripts\python.exe
  version: '3.8'

This looks like a scikit-learn issue, not SciPy

Thank you @banbar for reporting. I agree with Andrew, hence I am going to close for now. I am happy to re-open if it turns out that there is indeed an issue with SciPy.


{Monitor} az monitor: Fix invalid escapes

Related command

Description

related issue: https://github.com/Azure/azure-cli/issues/28829
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Monitor


Add attribute disabled for button for accessibility. Ref #268

Reviewer:
@jagtalon

Description:

Add disabled attribute for submit button when the user have no input yet
Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

LGTM. Thanks @soleo!
(Fixes #268)


Guest clan color is same as regular clan

https://i.gyazo.com/18a9457b041ac73ea25aa2c02f8816da.gif
two // is dark red which is correct for my clan chat. three /// is the same color though for guest chat when it should really be green I think.

Since the latest update, this should work correctly. In my tests, // is green, while /// is blue, just like my in-game color settings. Let me know if it's still an issue.


Require for nested parameters is broken

Using current API, it's not really possible to do a sane check for a nested param. Consider the following check:
params.require(:user).require(:id)

If you now supply ?user=test as a param, the second require call will be sent to a string instance.
This could be solved if require would support nested syntax, i.e.:
params.require("user.id")

The above syntax would make code more readable for deeper nested params: params.require(:user).require(:book).require(:authorization).require(:token) becomes
params.require('user.book.authorization.token')
Any thoughts?

No one has had a need for requiring nested parameters since 2013?


Not FIPS compliant; breaks npm when FIPS-compliance compiled

When NodeJS is compiled for FIPS-compliance, fs-write-stream-atomic actually breaks NPM.
When NPM attempts to write the local cache file .cache.json using WriteStream from the library, it throws the following:
fips_md.c(146): OpenSSL internal error, assertion failed: Digest update previous FIPS forbidden algorithm error ignored
Aborted
Instead of hardcoding md5 hash for the temporary name, consider moving to something higher like sha1 at a minimum or check for FIPs compliance and make it variable. I tested by moving the function createhash() call to sha1 and it proceeds fine.

Since we're not using MD5 for anything other than a fast and convenient way to get some entropy into a filename to avoid collisions, I don't think we'd have any objection to landing a patch that switches to another hashing algorithm (pure-JS murmur would probably be a smart choice). If you wanted to put a patch together, it would probably get landed and released without too much delay. Thanks for bringing this to our attention!

@ayohrling This issue affects me as well.
@othiym23  Any reason why you prefer to introduce a dependency on a pure JS implementation of murmur? Hashes don't introduce entropy, that's given by the invocations counter and the filename as input.
Instead, we cam simply append crypto.randomBytes(16).toString('hex') to each filename. (If you want the same 128 bit length as MD5.)
Are you okay with that? If so, I'll do the pull request.

This code is hot enough (at least in npm) that I'd prefer to have an algorithm designed for speed involved. The problem with crypto.randomBytes(), I am learning, is that it can cause problems for users in some environments, depending on the size of their entropy pool and the version of Node they're using. You're right that it's not so much entropy we want there as an absence of collisions / even distribution of values, and murmur is both fast and fairly uniform in the distribution of its output. I'd strongly prefer that for this purpose.

@othiym23
That makes sense. I've done a pull request here https://github.com/npm/fs-write-stream-atomic/pull/6
I hope it's okay, I'm still new to JS! :)

I didn't have time to get to this this week, but I'll try to land and merge it early next week. I'll leave this tab open until it's done. Thanks for putting this together and for hanging in there with me!

Thanks to merging PR #6, this is now addressed. Thanks for your patience and for putting together the fix, @stefanmb!

(I like the murmur, but if we did want random bytes, crypto.pseudoRandomBytes provides a nice alternative to crypto.randomBytes for those times when you don't want to block and/or eat your server's entropy and you don't actually need those kinds of guarantees of non-repeatability.)


fix(groups): Make group friend filter case insensitive

What this PR does 📖

Makes the friend search for creating and editing groups case insensitive

Which issue(s) this PR fixes 🔨

Resolve #921

Additional comments 🎤
Should the same be done for the search bar at the top of the sidebar that filters for chats?

missing linter 🔨


Official Command Line Tool

Is your feature request related to a problem? Please describe.
There is no official CLI for eta.
Describe the solution you'd like
A CLI preferably written in Typescript using yargs. It should be able to facilitate testing to make sure it is working properly.
Describe alternatives you've considered
Not having a CLI.
Additional context
I could work on this, I just want to see what people think.

@nebrelbug Thoughts?

This is a great idea!
We should look at https://github.com/mde/ejs and https://github.com/pugjs/pug-cli for some examples of similar tools.
Ideally a CLI would accept configuration options through command line flags or through a config file like eta.config.js (maybe eta-vscode could use the same file?)
We'd need to think about how we'd handle partials and layouts.

I was thinking it would do the prerendering of templates and then add the ability to render templates.

Also, should we keep the CLI within this eta package or a new package such as etajs-cli (eta-cli) is already taken.

Just as a side note, it could also seem like a good idea to use a framework like oclif. It may add a little bit of structure.

@nebrelbug I think oclif is more built and structured for the CLI to be in its own package because of the complexity of it and how it may interfere with the current package.json build and other processes. I would prefer to just use yargs because it is simple but also testable. I think it is a more popular practice to keep the CLI code in a folder called /bin.

@shadowtime2000 my bad, /bin is better :smiley:
I think either option -- yargs in the main repo or oclif in a separate repo -- would be great.

@nebrelbug We could also just use yargs in a separate repo because it is a little simpler and user to test. I am going to start working on that but if you think that should change feel free to tell me 😃

I completed the CLI with basic compiling functionality and I have unit tests with Jest. Now I think it is time to decide the package name. Since eta-cli is taken the name I am using rn is etajs-cli. Any suggestions?

@shadowtime2000 great! etajs-cli sounds good to me; I'm thinking we should just have the script called eta.

I am going to close this now because the CLI has been published.


Improve CSS styles for Wizard Taxonomy control

#1527
Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[ ] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
Change Wizard Taxonomy control's styles so that it displays properly with different resolution.

Hmmm, looks like your commit hooks are broken @PenghaiZhang . This failed the CSS format check, which is normally formatted as part of the pre-commit hooks.


GH-151 Support path parameters in operationId generator

Following up the discussion in #151 and as an addentum to #152 , proper handling of path parameters is introduced in this PR.
Upon auto-generating operationIds, path parameters are prefixed by the keyword By. Basically replicating the successor plugin's behaviour and replacing their With by By.
Also added a corresponding unit test

Looks fine for me, thanks! It should be available as snapshot in 1-2mins :)

Great, thanks a lot ❤  . Unfortunately you were ever so slightly too fast 😅
I just did some research and realised that there is no restriction on hyphens in general parts of a path and thus, the hyphen-handling is at an improper location which I fixed in the latest commit. I'm fairly certain that one didn't get the merge...

Oops, sure, it's just a snapshot build, so nothing happened - at least you'll get more commits in this repository :)


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/36197

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/36606

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/37318

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/48698

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/56821

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/58357

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/59588

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73378


Fix for asar

Fixes https://github.com/atom/dalek/issues/8
/cc: @lee-dohm for :eyes:

Thanks for taking care of that :bow:


sap_hana_preconfigure: install package IBMinvscout on RHEL 8 and RHEL 9 ppc64le again

The package IBMinvscout is back in the RHEL 8 and RHEL 9 repos.
See also the corresponding bugs for RHEL 8 and RHEL 9.
Relates to https://github.com/sap-linuxlab/community.sap_install/issues/278.

What to do when using a role which does not have IBMinvscout defined in the vars file?
As per Ansible variable precedence rules, you can use --extra-vars or -e to redefine any internal variable. The following steps can assist you with this:

Copy the whole variable you want to redefine in a new file, e.g. ibm-power-package-list.yml. Example:

# cat ibm-power-package-list.yml
__sap_hana_preconfigure_required_ppc64le:
  - librtas
  - src
  - rsct.core.utils
  - rsct.core
[...]
  - ppc64-diag
  - IBMinvscout

Run the following command to convert this list into a proper argument list for the --extra-vars or -e argument to the ansible-playbook command:

# awk '/^__/{printf ("\047{\"%s\": [", $1)}/^  - /{printf ("%s,", $2)}END{print "]}\047"}' ibm-power-package-list.yml
'{"__sap_hana_preconfigure_required_ppc64le:": [librtas,src,rsct.core.utils,rsct.core,rsct.basic,rsct.opt.storagerm,devices.chrp.base.ServiceRM,DynamicRM,ncurses-libs,readline,sqlite,sg3_utils,libgcc,libstdc++,zlib,iprutils,lsvpd,libvpd,libservicelog,servicelog,powerpc-utils,ppc64-diag,IBMinvscout,]}'

Run your playbook as in the following example:

# ansible-playbook sap-hana.yml -l ppc64le_host_01 -e '{"__sap_hana_preconfigure_required_ppc64le:": [librtas,src,rsct.core.utils,rsct.core,rsct.basic,rsct.opt.storagerm,devices.chrp.base.ServiceRM,DynamicRM,ncurses-libs,readline,sqlite,sg3_utils,libgcc,libstdc++,zlib,iprutils,lsvpd,libvpd,libservicelog,servicelog,powerpc-utils,ppc64-diag,IBMinvscout,]}'

Note: The superfluous additional comma at the end will not do any harm.


Is the current code prepared for empty stacks by not thrown native errors?

Should be tested by IE whether doing new NativeError(new Error()) will cause any exception by Stack creation.

Yes it is: https://github.com/inf3rno/e3/blob/master/lib/stackAdapter/StackAdapter/non-v8/FrameStringSource.js#L47

Maybe I could add a single frame.

Note, that the current system tries to slice the empty array too, so it is not that optimal, but it does not really matter.

It is hard to add a Frame, since we are talking about frame strings. So it would be parsed again. Probably adding a new property to the results about being non-accessible or so would help.


feature/mx-1435 computed provenance fields

PR Context

Added

Changes

Deprecated

Removed

Fixed

Security

1. Could you create follow-up tickets for migrating the other repositories?

i'll prepare mex-extractors as well, but i'd leave the migrations in the other repos up to the respective repo owners. shouldn't be too bad anyway.

2. please add your changes to the changelog. Maybe even include a short info of the necessary update steps for dependent repos.

will do.

3. some tests fail locally

fixed.


Compilation error because of glaze/reflection/enum_macro.hpp

After updating glaze from v2.6.1 to v3.1.7, my project no longer compiles because of this error:
In file included from build/_deps/glaze-src/include/glaze/core/context.hpp:11,
                 from build/_deps/glaze-src/include/glaze/core/common.hpp:15,
                 from build/_deps/glaze-src/include/glaze/core/refl.hpp:6,
                 from build/_deps/glaze-src/include/glaze/json/write.hpp:12,
                 from net/http/message.hpp:10,
                 from net/http/response.hpp:5,
                 from net/http/response.cpp:1:
build/_deps/glaze-src/include/glaze/reflection/enum_macro.hpp:14:16: error: expected primary-expression before ‘(’ token
   14 |          nameof(T{})
      |                ^
In file included from build/_deps/glaze-src/include/glaze/core/context.hpp:11,
                 from build/_deps/glaze-src/include/glaze/core/common.hpp:15,
                 from build/_deps/glaze-src/include/glaze/core/refl.hpp:6,
                 from build/_deps/glaze-src/include/glaze/json/write.hpp:12,
                 from net/http/message.hpp:10,
                 from net/http/request.hpp:4,
                 from net/http/request.cpp:1:
build/_deps/glaze-src/include/glaze/reflection/enum_macro.hpp:14:16: error: expected primary-expression before ‘(’ token
   14 |          nameof(T{})
      |                ^

Clangd also shows similar error:
In included file: unexpected namespace name 'nameof': expected expression
enum_macro.hpp(14, 10): Error occurred here

Compiler version as this may be helpful:
➤ g++ --version
g++ (GCC) 14.1.1 20240720

Downgrading to v2.8.4 seems to resolve the issue, as enum_macro.hpp was introduced in v2.9.0
I was able to fix some of these errors by cleaning up my headers, but overall, it seems that something conflicts with glaze, as everything works in clean environment / after commenting out headers i include, and i don't see any pattern behind this problem, so not sure what can cause this behaviour. Any ideas?

Interesting, I'll have to do some experimentation to try to replicate an issue. nameof does use argument dependent lookup (ADL), so include order can matter. Will look into when I get a chance.

Can you try manually including glaze/reflection/enum_macro.hpp first in your Glaze includes? I have not been able to replicate this issue.

@Bolderaysky, I realized that the constexpr arrays these macros were generating were not declared inline. This may be your issue and may now be solved as of #1252 in v3.2.2

After updating to v3.2.2, issue is still here. However, i experimented a little bit with headers and it seems  glaze/reflection/get_name.hpp was the issue in my case. Mostly likely it was included accidentally by tooling, removing this header from my includes fixes issue for me. However, including it in clean environment doesn't reproduce issue for me, so it's possible that the problem is on my side.
I will check what can be the cause of this and will let you know if I find something

I'm going to close this for now, but definitely open it back up if you run into the issue again. Thanks!


Add support for latest release

Description
This PR closes #266 and supersedes #267; where I got a bit lost in the codebase.
Closes #266

[X] I have performed a self-review of my changes
[X] I have read and understood the contributing guidelines

Haven't read the code yet, but I had an unanswered question in the other pull request.
Let's say erlang/otp releases 24.2.5, but 24.2.4 is the one set to "latest". Shall a rule in setup-beam override that? Or where will the semantics reside?

Haven't read the code yet, but I had an unanswered question in the other pull request.
Let's say erlang/otp releases 24.2.5, but 24.2.4 is the one set to "latest". Shall a rule in setup-beam override that? Or where will the semantics reside?

Yeah, so if we want to provide a more true latest release then we need to do the reconciliation which would require a bigger refactoring, I tried walking down that path in the other PR but decided to bail out.
If there is a big interest in this we can certainly do it and we can leverage semver to do the heavy lifting by sorting the versions.
Regarding OTP and it’s branch versioning scheme, that can be treated as SemVer build meta and be sorted accordingly.
In the contribution guide it’s mentioned to keep changes to a minimum, so as a new contributor then I’m hesitant to rip apart most of this as it’s currently stand.

I have read and understood the contributing guidelines

This states "Execute npm run build-dist and fix any issues arising from that". I can't understand what failed that it didn't generate any artefacts that you'd need to push, for which CI complained later.

I don't know how that didn't get pushed the first round, but I've rebased and regenerated the dist. Hopefully, it will pass this time around.

In the contribution guide it’s mentioned to keep changes to a minimum, so as a new contributor then I’m hesitant to rip apart most of this as it’s currently stand.

I understand, and thank you for being patient and walking us through your thought process. The changes mostly seem sane to me (it's touching parts of the code that are somewhat sensitive), but I think I need other reviewers to pitch in.
In any case, tests are failing and it's probably due to latest being a moving target. You'll probably want to do static tests against a specific input list (and not reading from remote, as that'll surely fail as OTP keeps releasing patches and other versions on a given major branch).

In the contribution guide it’s mentioned to keep changes to a minimum, so as a new contributor then I’m hesitant to rip apart most of this as it’s currently stand.

I understand, and thank you for being patient and walking us through your thought process. The changes mostly seem sane to me (it's touching parts of the code that are somewhat sensitive), but I think I need other reviewers to pitch in.
In any case, tests are failing and it's probably due to latest being a moving target. You'll probably want to do static tests against a specific input list (and not reading from remote, as that'll surely fail as OTP keeps releasing patches and other versions on a given major branch).

Thanks, I've future proofed the tests.

Failing tests don't seem to be your responsibility; it's just that rebar3 nightly stopped supporting OTP 24; I'll update that in a separate pull request.

@Schultzer, it'd be important to mention this in the README, with all the discussed constraints. Basically:

mention that latest is available
mention that it's calculated locally by the action, not directly related to what's set as latest in the remote repositories
if there's any constraints regarding x.y.z.a.b.c versions in Erlang/OTP also mention those as an exception

When you squash your changes midway through a review it makes it harder on the reviewer to follow up 😕, since all the changes will now have to be reviewed again... No biggie, just letting you know how I feel it.

@Schultzer, it'd be important to mention this in the README, with all the discussed constraints. Basically:

mention that latest is available
mention that it's calculated locally by the action, not directly related to what's set as latest in the remote repositories
if there's any constraints regarding x.y.z.a.b.c versions in Erlang/OTP also mention those as an exception

Done, no known constraints, should be all cake from here. 🍰

When you squash your changes midway through a review it makes it harder on the reviewer to follow up 😕, since all the changes will now have to be reviewed again... No biggie, just letting you know how I feel it.

 Which ended up with me squeezing the changes. I’m a complete noob with regards to git.

@Schultzer, I don't think we have any more planned changes. I'm thus rebasing this onto the main branch to check if the error issues go away. If they do we can expect a squash+merge soon.

This is Ok ✅. I'm squash+merging. You can expect this change in the next release (we want to wait until #278 is done, so we can bump minor). Feel free to come back to this and ask for the release if it's taking more than, say, a week.


Fixed ruamel.yaml issue on Python 3.6 by pinning to <0.17.22

No review needed.

coverage: 33.911%. remained the same
when pulling 59d126643513e520f3b4261be9ff6463c1ad2c02 on andy/fix-ruamel-py36
into 3112b1a3c373d5254af64eb13f36faf14c63e073 on master.


Update to django 4.0

Issue is for tracking the progress of updating the platform from Django 3.2 to Django 4.1
We have a number of dependencies to update before we can take the newer django to production

Updating from Django 3.2 to 4.0
Dependencies that needed to be updated
django anymail
ImportError: cannot import name 'force_text' from 'django.utils.encoding'
update to 8.6 LTS
https://anymail.dev/en/v9.0/changelog/
django extensions
Update to 3.2.1
ImportError: cannot import name 'ugettext' from 'django.utils.translation'
https://github.com/django-extensions/django-extensions/blob/main/CHANGELOG.md

Another one
django_taggit_serializer
ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation'
The previou maintainer hasn't merged in the PR
https://github.com/glemmaPaul/django-taggit-serializer/pull/48
So I'm trying this one:
https://github.com/adriangzz/dj-taggit-serializer

update any use of url() to repath in the urls file
ImportError: cannot import name 'url' from 'django.conf.urls'
Deprecated in 3.1

Ah nuts. We'll need to update the version of python to run django 4.0 onwards as they require python 3.9 at least.

I think we'll need to park this until we have a nicely documented way to choose the python we want to use.
Using pyenv on the server was a bit of a pain in the neck last time, and I didn't have much luck with asdf, which is what I use locally.
It might be the time to bite the bullet and Just Use Docker.
Until we've made a decision, I think we're stuck at Django 3.2, and I'm off on holiday tomorrow.
@tortila  - I'm tagging you in case you end up having a discussion with Hannah about this. Django 4.0 and 4.1 have much better control over the markup used by forms, but the python version is a blocker.

Thanks for tagging me Chris. Is Django version a blocker for Hannah? What's the priority of this issue?
I think there's a straightforward solution to switching to Python 3.9. We're using Ubuntu 20.04 and even though 3.8.5 is the default Python version shipped with the distro, python3.9 is available in official package repository:
→ apt search python3.9
python3.9/focal-updates,focal-security,focal-updates,focal-security 3.9.5-3ubuntu0~20.04.1 amd64
  Interactive high-level object-oriented language (version 3.9)

We could also install a newer Python version if we added the deadsnakes PPA on the production servers.
I think that pyenv is great to use for development, but for production servers I would rather rely on a system package than build Python from sources.

It seems that Django 4.0 and 4.1 minimal requirement is Python 3.8: https://docs.djangoproject.com/en/4.1/releases/4.0/#python-compatibility

Hi @tortila, To complete the circle on this discussion as I know this has popped up in Trello card chat too. Having more control over the form html output would be ideal. I think its been mentioned that the current version only allows us to output forms as tables eg form.as_table
However, it looks as though we have found a way around these issues for now and I am able to style things in a way that is good enough.
So in short, no I don't believe this is a blocker for deployment of the new registration form 😄

We're no on django 5.x


Project list

@choonkending
Any interest in adding a completed and in progress project list to readme linking to project using this boilerplate? I built my first project using it (6 weeks part time). And I have another one on the way. So I think it might be useful for people to see what this boilerplate enables.

@caranicas Yes, that's a great idea. I'd be interested to see what people have done with this boilerplate so far :)


hull calculations

there are several ways to calc the extent, so far I have used:
concaveman::concaveman(ydat)
adehabitatHR::mcp(ydat, percent=99)
alphahull::ahull(ydat, alpha = dist) where dist is dist <- max(ydat$y_MTB)-min(ydat$y_MTB)
We should stick to the IUCN as much as possible, they say:
https://support.ala.org.au/support/solutions/articles/6000208436-area-of-occupancy-and-extent-of-occurrence
"Extent of occurrence can often be measured by a minimum convex polygon (the smallest polygon in which no internal angle exceeds 180 degrees and which contains all the sites of occurrence)"
but also
"The alpha hull value is used when calculating the Extent of Occupancy (EOO) for assessing conservation risk. It examines the distance between occurrence points and modifies the area to be included in the EOO based on a multiple (alpha - selected by the user) of the average distance between points. The lower the alpha value, the tighter the EOO will be around the occurrence points. For further information on alpha hulls, see:
ICUN Standards and Petitions Subcommittee. 2017. Guidelines for Using the IUCN Red List Categories and Criteria. Version13. Prepared by the Standards and Petitions Subcommittee. Downloadable from https://www.iucnredlist.org/documents/RedListGuidelines.pdf (pp. 46-47)"
can you help figure out which is the best R package to use?

Hmm. This is pretty interesting actually. And definitely a gray area based on my reading of the guidelines.
This part, specifically, seems a bit wishy-washy:

I guess the question becomes if you want to go down the road of dijunct polygons (referred to as discrete patches in the guidelines) summed up to make the EOO. I.e., alpha hulls. Which is what is 'recommended' to some extent. I guess it depends on how common this would be in the dragonfly data. I just looked through some of the 'data' of the maps on your app (the estimate doesn't seem to be displaying for the few species I tried initially) and it doesn't look like it is super common where, for example a range is clearly in two disjunct parts of Germany. PLUS, you did a ton of work smoothing over noise and bias to produce the occupancy maps, and this probably is more likely to lead to 'contiguous ranges' for the majority of species? And maybe this is even some sort of deep implicit assumption? No idea. But especially given the relatively small spatial scale of Germany, then alpha hulls are maybe not as helpful in this instance?
So, all that being said, I personally would vote against the alpha hull method of possibly more than 1 disjunct polygon for a species EOO.
And thus, I would go with either a convex hull or concave hull. But, as it mentions the convex hull can have biases associated with it when comparing time points. Which is why I actually really like the concave hull approach. To me it is a happy medium.
However, potentially if you want to be slightly more in line with IUCN guidelines, the convex hull is best. And our justification could be this sentence:

Nevertheless, given the paucity of practical methods applicable to all spatial distributions, and the need to estimate EOO consistently across taxa, minimum convex polygon remains a pragmatic measure of the spatial spread of risk.

Either way I would use the concaveman implementation. You can adjust the concavity, and calculate a convex hull at Inf.
Here is an example:
library(concaveman)
data(points)
plot(points)
plot(concaveman(points, concavity=1))
plot(points, add=TRUE)

plot(concaveman(points, concavity=4))
plot(points, add=TRUE)

# it doesn't actually take Inf as a value,
#but can just put some massive number
plot(concaveman(points, concavity=1000000))
plot(points, add=TRUE)

I guess a starting point would be to plot a scatterplot of concavity=2 and concavity=1000000000? I assume they will be strongly correlated in this instance.

I feel like that is a bit of a very classic Corey rambling non-answer... But maybe helpful for my 2 cents. idk.
I've used the mcp approach before too, but presumably these things would have little effect on your findings.


Complete Test Coherence for CashCtrlLedger

Description:
In this task, we will apply the base test suite developed for StandaloneLedger to validate the functionality of CashCtrlLedger. The goal is to ensure that the base tests cover key functionality and maintain consistency across different ledger implementations.
Tasks:

Apply the base test suite from StandaloneLedger to CashCtrlLedger.
Validate the behavior of CashCtrlLedger using the base tests to ensure coherence and consistency across ledger implementations.
Update any relevant tests to reflect any findings or adjustments needed after applying the base suite.

implemented when working  on entities


deploy to alternate account fails but command line shows success

Try to create a firebase account with a different google account.
Try to deploy to it after already logging in.  The deploy shows that it was successful, but it wasn't.

This is an old one, going to try and replicate with these steps:

Be logged into Account A.
Create a firebase with Account B.
Use Account B's firebase name when setting up deployment.
Run donejs deploy and see what happens.

Now that we've switched off of donejs-deploy this might already be fixed but I'll test it anyways.

This is no longer a problem, get an error message now:


[$1000] Update Emojis.js to make the default skin tone an int

Part of Add emoji reactions for all message types
Problem
Currently the default skin tone is the string default whereas the rest of the skin tones are ints 0-4. This means that in Auth we're going to need to account for 2 different data types instead of just one.
Why is this important?
It complicates the logic for adding and removing emoji reactions
Solution
Change the default skin tone to -1 instead of default
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c998df7aa9bfb1d5
Upwork Job ID:<PHONE_NUMBER>306051072
Last Price Increase: 2023-03-06

Job added to Upwork: https://www.upwork.com/jobs/~0158586f98d3dc7079

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

We don't need a C+ for this issue, unassigning @rushatgabhane

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15049

If no regressions arise, payment will be issued on 2023-02-23. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

There is regression after set emoji skinTone value as -1
Steps:

Open any chat room.
Click on Emoji picker from composer.
Click on change default skin tone.
Choose any skin tone exclude first one.
Now again click on choose default skin tone.
move the cursor from skin tone view.

It is happening because we are setting highlight index to -1 to reset it.
https://github.com/Expensify/App/blob/660e3892f8a8deace5e24497148a174ee8dde251/src/components/EmojiPicker/EmojiSkinToneList.js#L89
We can change it selectedEmoji.skinTone or just null / -2
https://user-images.githubusercontent.com/114683042/220277613-12e18bbb-c57a-4fd3-8326-4438beb412c3.mov
cc @mananjadhav, @stitesExpensify

Ok @stitesExpensify, are you going to create new issue ? If it can be external I can do It

I just created a new issue here https://github.com/Expensify/App/issues/15490. You will need to post the proposal just so we follow the process, but I will prioritize your proposal.

@stitesExpensify Can this be paid out for C+ review, by deducting the regression penalty? As we're resolving this as a separate issue and this has been in production for more than 7 days?

Job added to Upwork: https://www.upwork.com/jobs/~01c998df7aa9bfb1d5

Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

📣 @mananjadhav You have been assigned to this job by @stitesExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Yes, my apologies! @conorpendergrast can you please help me pay @mananjadhav for reviewing this pr?

I can indeed 👍

Ok, so the base pay for the C+ review is $1000. Then, because there was a regression reported within 7 days of this deploying to production, we reduce that by 50%, to make payment $500.

Each regression reduces the pay amount for C+ by 50% (only C+ gets reduced pay). Additionally, no efficiency bonus is paid for merging quickly if there are any regressions.

and

We don't want to pay until the regressions are fixed.

So, once https://github.com/Expensify/App/issues/15490 is fixed (merged and deployed to production) I'll pay https://github.com/Expensify/App/issues/15054.
Putting this on hold for https://github.com/Expensify/App/issues/15490! At that point, I'll pay $500 to @mananjadhav

Looks like https://github.com/Expensify/App/issues/15490 PR is in review, so we're still waiting here!

https://github.com/Expensify/App/issues/15490 is on Production, so I'm removing the hold on payment here

Offer sent via Upwork for $500. Will pay once that's accepted!

Paid, and all done. Closing.


Sticky element is flickering when scrollup - when sticking

For example in the demo site "http://stickyjs.com/", scroll using mouse wheel, when element is about to stick to top, it is disappearing for a moment and then displayed - this is causing a flicker effect, is there any solution for this sticking to happen in a smooth transition. But when, window is scrolled using mouse pointer, the transition is very smooth(this effect is required when scrolled using mouse wheel).

Looks line in Windows the mouse event on the scroll button is does not trigger an actual scroll event until the mousewheel has finished scrolling. You'll need to bind scroller to the mousewheel, example:
$window.bind("mousewheel DOMMouseScroll MozMousePixelScroll", function() {
    scroller();
});

If there is a more efficient method, someone please let me know!


Ambiguous operator == leads to nil comparisons being serialized wrongly

The operator == is defined twice, in ambiguous ways:
https://github.com/vapor/fluent/blob/f8378e392ed6d2b2f55c88d6c59ede96e74897fa/Sources/Fluent/QueryBuilder/QueryBuilder%2BOperators.swift#L36
https://github.com/vapor/sql/blob/9c8c19bd210b927ee52532d204e255efb11508a4/Sources/SQL/SQLBinaryOperator.swift#L180
The problem is that the second one does not serialize == nil comparisons as IS NULL.
The Model implementation of withSoftDeleted (see https://github.com/vapor/fluent/blob/f8378e392ed6d2b2f55c88d6c59ede96e74897fa/Sources/Fluent/Model/Model.swift#L379) uses the correct operator (the first one), while my own and.filter(\RefreshToken.deletedAt == nil) uses the second operator, which leads to something like "deletedAt" = NULL (or = <some object>) being encoded instead of "deletedAt" IS NULL.
A workaround is to use and.filter((\RefreshToken.deletedAt == nil) as FilterOperator<PostgreSQLDatabase, RefreshToken>), but that's clearly not how things should be.
I think this might be happening if I only import FluentPostgreSQL but not import Fluent, but the outcome is still very confusing.

@MrMage @tanner0101
I driled down the bug to BinaryOperators and corrected it by adding a condition to check for nil. SQL queries look as expected now.
PR: https://github.com/vapor/sql/pull/14

I feel like the underlying issue is that there are two different operators and it's unclear which one gets chosen in a particular solution. So I think the proper solution would be two merge these two operators to eliminate any ambiguity. @tanner0101, could you provide insight into the difference between these two operators at the moment?

That's what I observed as well. I think the reason the operators of QueryBuilder are not fired here is because nil is not of type Value and so the BinaryOperator takes that one.
I'm not sure why would not combine the two though, it is confusing.

@MrMage the problem here is this overload. That accepts the DB's generic filter type, in the case of MySQL, that's MySQLExpression.
vapor/mysql has it's own, lower level query builder based on vapor/sql. This query builder is similar to Fluent in some ways, for example you can do:
where(\Model.prop == foo)

More examples here.
This is of course based on operators that generate MySQLExpression. Because Fluent has an overload that accepts that, the ambiguity is happening.
My solution as recommended in https://github.com/vapor/fluent-mysql/issues/120 is to either remove that overload altogether or give it a prefix like .filter(raw: ...).

I agree that these two should be different to avoid any possible ambiguity. It's bad user experience that a statement might work differently depending on whether FluentPostgreSQL/FluentMySQL is imported or not. Also, both methods should be documented to make it clear which one is the recommended one (and how their behavior might differ).

Sorry, linked the wrong commit. Here it is: https://github.com/vapor/fluent/commit/c5c384a9af63a3c55e7ff164c39a5c037c6443d1#diff-0b1072a5a6a4f0127933ea67791ec0d8


Investigate test__login_flow flaky unit test

https://github.com/chanzuckerberg/single-cell-data-portal/actions/runs/3415194028/jobs/5684047420#step:7:4122
Determine whether this backend unit test can be made more robust, as it occasionally fails then succeeds on a retry

Doh! Apparently, logs from GHA expire! 😅
https://github.com/chanzuckerberg/single-cell-data-portal/actions/runs/3415194028/jobs/5684047420#step:7:4122
now shows: The logs for this run have expired and are no longer available.


Failure when creating resource dnacenter_wireless_rf_profile

Prerequisites

[x] Have you tested the operation in the API directly?
[x] Do you have the latest Terraform provider version?
[x] Review the compatibility matrix before opening an issue.

Describe the bug
Provider returns error when I attempt to create resource dnacenter_wireless_rf_profile:
dnacenter_wireless_rf_profile.this["custom-tf"]: Creating...
╷
│ Error: Failure when setting RetrieveRfProfiles search response
│
│   with dnacenter_wireless_rf_profile.this["custom-tf"],
│   on wireless.tf line 57, in resource "dnacenter_wireless_rf_profile" "this":
│   57: resource "dnacenter_wireless_rf_profile" "this" {
│
│ Invalid address to set: []string{"item"}
╵
ERRO[0016] Terraform invocation failed in /home/admmikshc/dev/dnac/minilab/.terragrunt-cache/1CSNjBdg1GHoveoEP3oiGPPj3Lk/6dl3eRSK6XeLPjg17O2JEUtNu2k/dnac-sandbox  prefix=[/home/admmikshc/dev/dnac/minilab]
ERRO[0016] 1 error occurred:
        * exit status 1

Terraform debug log:
tf.log
Expected behavior
Resource should be created successfully.
Screenshots
Not relevant
Environment (please complete the following information):

Cisco DNA Center version and patch: <IP_ADDRESS>-70045
Terraform version: 1.3.6
Cisco DNA Center provider version: 1.0.15-beta
OS Version: Ubuntu 20.04.5

Hi @mschedrin  could you please try it again with new provider version (1.0.16-beta) and update us if it works.

Yes, resource creation works now, thanks for quick fix. There is still problem with reading state. If RF profile has been deleted directly on DNAC, terraform fails to detect that and does not recreate RF profile. Here is relevant extract from terraform debug log:
2023-01-18T01:31:17.678-0800 [INFO]  provider.terraform-provider-dnacenter_v1.0.16-beta: 2023/01/18 01:31:17 [DEBUG] Selected method 1: RetrieveRfProfiles: timestamp=2023-01-18T01:31:17.678-0800
2023-01-18T01:31:17.896-0800 [INFO]  provider.terraform-provider-dnacenter_v1.0.16-beta: 2023/01/18 01:31:17 [DEBUG] [RESTY]
==============================================================================
~~~ REQUEST ~~~
GET  /dna/intent/api/v1/wireless/rf-profile?rf-profile-name=custom-tf  HTTP/1.1
HOST   : <IP_ADDRESS>
HEADERS:
  Accept: application/json
  Content-Type: application/json
  User-Agent: go-resty/2.7.0 (https://github.com/go-resty/resty)
  X-Auth-Token: <redacted>
BODY   :
***** NO CONTENT *****
------------------------------------------------------------------------------
~~~ RESPONSE ~~~
STATUS       : 200 OK
PROTO        : HTTP/1.1
RECEIVED AT  : 2023-01-18T01:31:17.896665619-08:00
TIME DURATION: 218.324359ms
HEADERS      :
  Bapiexecutionid: f248cd8b-f4be-4d0a-a0f7-04c3f5470c80
  Cache-Control: no-store
  Connection: keep-alive
  Content-Length: 22
  Content-Security-Policy: default-src 'self' 'unsafe-inline' 'unsafe-eval' blob: data:
  Content-Type: application/json
  Date: Wed, 18 Jan 2023 09:31:06 GMT
  Pragma: no-cache
  Server: webserver
  Strict-Transport-Security: max-age=31536000; includeSubDomains
  Via: api-gateway
  X-Content-Type-Options: nosniff
  X-Frame-Options: SAMEORIGIN
  X-Request-Id: d3a8772ce636777133d530291dba19bc
  X-Xss-Protection: 1
BODY         :
{
   "response": []
}
==============================================================================: timestamp=2023-01-18T01:31:17.896-0800
2023-01-18T01:31:17.897-0800 [INFO]  provider.terraform-provider-dnacenter_v1.0.16-beta: 2023/01/18 01:31:17 [DEBUG] Retrieved response {"response":[]}: timestamp=2023-01-18T01:31:17.896-0800

Hey @mschedrin , could you please try it again with 1.0.17-beta provider version and update us.

Perfect, now the resource works as expected 👍


Add deep-equal to check query variables

fix #84

Hey @vip30, thanks so much for this contribution! We have actually implemented a similar mechanism in our 2.0 release, which will likely be released today. Please keep an eye out for that along with an upgrade guide as there are some breaking changes (no need for _document anymore!).
In the meantime I am going to close this PR as it is redundant with our 2.0 release. Thank you again!


modify newsList function

Since there was a problem that an error occurred unless an option was passed to the newslist function, it was fixed

Published as v0.7.1 :tada:


move code to example: composition vs inheritance

As is mentioned in https://github.com/reactjs/reactjs.org/issues/246, I'm trying to move the code from docs/composition-vs-inheritance to /examples. Just want to send a small PR to see if I'm doing it the right way so that I could move on for the rest work.
There are several things that I noticed though:

I tried to convert codepen link to a codesandbox one, but the thing is: there is no global variable name React and ReactDOM in codesandbox. So I had to add it manually through import but it clearly adds noise to the previous compact example. Is there a quick fix about this? (I'm not quite familiar with codesandbox)
What if the codepen example contains css styles? How can I combine all of those to a js file? Or should I come up a new code example maybe?

cc @washingtonsoares @bvaughn

@bvaughn That sounds interesting. Could you show me the link to the gatsby plugin you wrote?

I'm thinking you could pass it a comma-separated list of files. This would be a backwards compatible change too.
So a single file would continue to be:
[codepen://components-and-props/rendering-a-component.js]

And multiple files would become:
[codepen://components-and-props/rendering-a-component.js,components-and-props/rendering-a-component.css]

Hello guys!
All the pull requests that refer to this pull request have already been merged.
I would be very happy if we could finalize this too! :smiley:
I can help by resolving conflicts and reviewing the code.
What do you think ? @cyan33 @bvaughn

@bvaughn @cyan33  Do you think it would be a good idea to continue this work? I think it will not be so difficult, since the PRs related in Gatsby have already been merged.

@washingtonsoares Hey Washington, hope you've doing well and thanks for following up on this pull request. I'll take a look after work!

Hello @cyan33!
I was walking through that part of docs and saw that the composition-vs-inheritance does no longer exists in the docs and I was unable to find any exact replacement. We already have a bunch of good examples in Passing Props to a Component page, so I don't think this PR you created is still required.
Let me close this as outdated, but thank you very much for taking the time to contribute to the docs! 👍


[Event Request] Codeunit 427 in function CreateOutboxSalesDocTrans

In Procede CreateOutboxSalesDocTrans(SalesHeader: Record "Sales Header"; Rejection: Boolean; Post: Boolean)
Please add event with Handler Pattern in begin of procedure
IsHandled := false;
OnBeforeCreateOutboxSalesDocTrans(SalesHeader, IsHandled);
if IsHandled then
exit;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update live with current master

Sry @BillWagner, I didn't know u were pulling the trigger on this when I was reviewing the last PR.

@GuardRex No worries. I want to get the VB Spec live today. We can publish again after more reviews.


WIP RAT-326: Fix javadoc errors and warnings in all of RAT modules

should we take this is small chunks?  I think we should merge these changes but leave RAT-236 open until we get a build that has no javadoc errors.  This way we can review smaller tranches of files rather than trying to do everything at once.

First batch of changes merged - we seem to run into https://bugs.openjdk.org/browse/JDK-8270866 when I run
mvn javadoc:javadoc inside of apache-rat-core.


Update production environment

Upgrade production environment to exoctk-3.6 including Python 3.6 since it is only running 2.7.5 right now!

We already did this today, right? Want to close this @bourque?
N.

Yep!