Need to add parameters at the top of main Bicep file to use parameters.json

Module path
https://github.com/Azure/bicep-registry-modules/blob/main/modules/lz/sub-vending/README.md
Bicep version
CLI 0.15.31
Describe the bug

When using the public registry module and the main.bicep you provide (e.g. the one for Hub&Spoke + peering), it's working fine when deploying with parameters directly in the main file but when trying to deploy with the parameter file, it fails because the main.bicep doesn't declare the parameters at the top of the file
I'm deploying using PowerShell with New-AzManagementGroupDeployment @inputObject
The fix is easy (adding parameters in main.bicep)

To reproduce

Deploy the landing zone vending with the main provided in example here
Add the parameter file when deploying with New-AzManagementGroupDeployment @inputObject

Code snippet
No response
Relevant log output
Line |
   9 |    New-AzManagementGroupDeployment @inputObject -WhatIf
     |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     |  InvalidTemplate - Long running operation failed with status 'Failed'. Additional Info:'Deployment template validation failed: 'The template parameters
     | 'virtualNetworkName, virtualNetworkUseRemoteGateways, subscriptionTags, disableTelemetry, subscriptionAliasEnabled, virtualNetworkResourceGroupLockEnabled,
     | existingSubscriptionId, virtualNetworkResourceGroupName, subscriptionManagementGroupAssociationEnabled, virtualNetworkLocation, virtualNetworkEnabled,
     | virtualNetworkTags, virtualNetworkPeeringEnabled, virtualNetworkResourceGroupTags, roleAssignments, hubNetworkResourceId, subscriptionManagementGroupId,
     | virtualNetworkAddressSpace, roleAssignmentEnabled' in the parameters file are not valid; they are not present in the original template and can therefore not
     | be provided at deployment time. The only supported parameters for this template are 'location'. Please see https://aka.ms/arm-pass-parameter-values for
     | usage details.'.'

Can you share the powershell command you invoked including all of the parameters?
@jtracey93 -- can you take a look at this one?

@gbeaud Can you share some repro steps here as all of those parameters have to be exposed, and are from my scan, in the main.bicep module file.
I note from your commands you shared you where deploying an Alz.bicep file in the deployment creation. Did you expose all the parameters there?
As I think this is actually where the issue lies and not with the module.
Happy to have a quick teams call on this to investigate further, as always 👍

Also @gbeaud the reason we don't suggest parameter files here as we are using a .bicep file itself and self contained values to deploy the module from the registry, instead of parameter files 👍
But we could add a note on here saying if you are going to use a parameter file you need to expose all the parameters in your calling module.
But to confirm this is not a bug in the module 👍
Cc: @alex-frankel

Hey @gbeaud,
No worries and likewise 👍
Do you want to create a PR on this topic on this repo that I can review?
Answers to your questions:

"I understand that if there is no logic in the main Bicep file (i.e. if it's just holding parameters and calling a module), then you would not use another .json parameter file, since the main Bicep file is somehow the parameter file, right?" - correct. Almost like a unofficial bicep parameters file by itself
"I was using .json parameter files all the time (e.g. with your ALZ-Bicep modules) but in the present situation I understand users would make a new main Bicep with new parameters for each new landing zone they want to create, and don't add a .json parameter file, correct? (I see it a bit of a pattern change compared to your other assets)" - if consuming from the registry then correct that would be my preferred approach. This is not meant to be a clone of ALZ approaches and to be more aligned with the TF module for sub-vending we have so they look and feel the same in all aspects.

Let us know
Thanks
Jack

@jtracey93 thanks for the feedback! Crystal clear and yes I'll be honored to make a PR and brag to my colleagues I've contributed to this repo (in a readme file 😂👍)
Cheers

Looking forward to the PR @gbeaud

@jtracey93 Not sure you got a request to review my PR since it fails a test, but it should not fail since I only edited a readme so that's weird?

@jtracey93 - Can I get a understanding whether this still persists?

this is being converted to AVM so will close


DynamoDB - Implement atomic counter

Fixes #1822
Fixes #2860
Implements the UpdateExpression: set x = x + 1
Supercedes PR #2870, which had some weird merge conflicts

Coverage decreased (-0.006%) to 94.285% when pulling 0974bad941e5b620e652ad1ef96f7e89b792b1ce on bblommers:feature/dynamodb_atomic_counter2 into 92b0586b8bea979e3ddc617604ab37f59a13dd3d on spulec:master.

Closing due to merge conflicts - will open a new one


REST API created that serves dataset metadata

Problem statement:
Currently any metadata about a dataset that is used by the explorer, is read through a "metadata TileDB array" that is created when converting a dataset's H5AD file to CXG. This makes it hard to change metadata associated with the dataset because the entire array needs to be rewritten.
Definition of Done:

[ ] Portal will offer a GET API that will return the metadata currently stored in the tileDB array (here's the start of the CXG conversion code). I leave it up to the implemented to figure out the exact API definition and would coordinate with implementer of [INSERT CELLXGENE TICKET NUMBER HERE] which will consume the API.
[ ] Correct Blish link as well :)

Closing as new issues will be created for a metadata API.


Consolidate script naming

There is a discrepancy in the script naming scheme:

Most of the scripts in the scripts directory and the buildGuide.sh scripts are named in camelCase.
scripts/deploy_launchpad_mission.sh and cico_build_deploy.sh are named using underscores.

Let's consolidate the naming conventions of the scripts. I suggest we use the all-lowercase, underscore-separated naming:
scripts/build_guides.sh
scripts/build_guides_ci.sh
scripts/deploy_launchpad_mission.sh

etc.

WDYT?

resolved in PR #500


Feature: major version

Hello,
This suggestion is not about a bug but rather a small change to be sure to use the last version.
Context:
In order to always have the latest updated major version, github suggest to use name-of-action:v unstead of specifying all major minor patch ver. I ve done such change on my workflows so i have the certitude of having all my workflows running with the latest versions.
I noticed that it didn t work for your action. After reading Using tags for release management on gh actions docs,  it appears the repo must have a v1 tag and this tag should moved to the last tag available. Let s say you have a tag v1. 0.1, the v1 would be at the same commit.
Would you be kind to place a v on latest tag published?
Thanks.

Hello,
This suggestion is not about a bug but rather a small change to be sure to use the last version.
Context: In order to always have the latest updated major version, github suggest to use name-of-action:v unstead of specifying all major minor patch ver. I ve done such change on my workflows so i have the certitude of having all my workflows running with the latest versions.
I noticed that it didn t work for your action. After reading Using tags for release management on gh actions docs, it appears the repo must have a v1 tag and this tag should moved to the last tag available. Let s say you have a tag v1. 0.1, the v1 would be at the same commit.
Would you be kind to place a v on latest tag published? Thanks.

Thank you, @edgd1er.
I've not read the page with recommended tag naming convention.
So, I've added the tag v1 just now.
v1.

@dmvict , Thanks you, Wokflows worked as expected with the new tag added. :+1:


Update themes/docsy submodule to latest tag

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest


+layout.server.ts load re-runs on every navigation

Describe the bug
Layout load function runs on every navigation
Reproduction
Log to console when layout load function is executed and it happens on every navigation.
import type { LayoutServerLoad } from './$types'

export const load: LayoutServerLoad = async ({ }) => {
  console.log('load /layout')

  return {
    name: 'My Site'
  }
}

Logs
No response
System Info
npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.64
    @sveltejs/kit: next => 1.0.0-next.415
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.0 => 3.0.8

Severity
blocking an upgrade
Additional Information
No response

Yep, reusing values is a TODO. We need to track whether load functions use url and params, just like they do on the client (in theory request and locals being different could also affect the output, but since that's always true I think we probably have to rely on explicit invalidation otherwise there's no point).
The hard part will be figuring out what to do if a +page.server.js or intermediate +layout.server.js calls await parent(), since the server, being stateless, won't have the parent values. There's basically two options:

re-run the load functions if a downstream load calls await parent(), even if it would otherwise not have been run
POST the parent data to the server in cases where await parent() is called, to simulate statefulness on the server

even if it would otherwise not have been run

This would still be a huge improvement compared to the situation now, which is layout.server.js just being a small boilerplate reducing helper.

An argument against posting data back to the server is that we may want to introduce the ability to send non-JSONable values from the server:
// +layout.server.js
export function load() {
  const map = new Map();
  map.set(map, map);

  return {
    map
  };
}

It's likely that we'd achieve that with https://github.com/rich-harris/devalue, which is only safe to use when sending data from the server to the client, not the other way around.

This vaguely reminds me of Cache Aware Server Push which uses a Bloom filter in a cookie to keep track of what the client already does or doesn't have to communicate to the server what needs to be sent.
I don't know enough about SK internals to know if that would be applicable or not.

we may want to introduce the ability to send non-JSONable values

I understand the concern and I'm probably lacking many knowledge to make a fair point but the two use cases the docs quote for using server.js rarely involve non-JSON values :

it needs to fetch data from a database
you need to access private environment variables

By the way "fetch data from an external API" could be another use case (which also can do pretty well already with JSON).
I still think it would be a huge win to be able to use layout.server.js like it seems it can be used at first glance. The introduction of non-JSONable values afterwards should not break anything anyway.

This Remix issue asking for loaders to use superjson has 37 👍 votes — it's definitely not an unheard of requirement to include things like Date objects etc.
Another case that JSON can't handle is this, if the referential equality matters (which it would in a <select bind:value> for example):
export function load() {
  const options = [
    { flavour: 'chocolate' },
    { flavour: 'strawberry' },
    { flavour: 'banana' }
  ];

  const selected = options[0];

  return { options, selected };
}

We don't plan on using superjson, because devalue is faster, produces smaller output, and doesn't force you to add a not-that-tiny client to deserialize on the client. But it does mean the data can only safely go one way. (Though we decided that sending data back to the server to simulate statefulness is a terrible idea anyway.)
(Re cache aware server push — the logic is on the wrong side. The server doesn't need to know what the client has, because the client is going to tell it. All the server has to do is tell the client 'this blob of data will be invalidated if params.foo changes' or whatever.)


tf.Transform support

tf.Transform is a library for doing data preprocessing with TensorFlow. It allows users to combine various data processing frameworks (currently Apache Beam is supported but tf.Transform can be extended to support other frameworks), with TensorFlow, to transform data.

Beam pipelines can be run on different runners. The PyPI package currently supports local DirectRunner and Google Cloud DataflowRunner.
When the data is fed from client, tf.Transform can be used directly as long as the package is installed. When the data is fed remotely (e.g. HDFS), where do we run the preprocessing pipeline ?

Is this library popular and does it needs computation framework runner support?


librsb

Is it possible to add the package librsb for sparse matrices?
Currently several packages are outdated eg. armadillo, gsl,  sundials mathgl. How can these package be updated to the actual releases?
Thank you for your help

Any update on this open issue?

Dear John,
I am a rather new user and don’t have much experience using cmake.
Thank you for your efforts. Is it possible do download/install the sundials library? Is it possible to install the libraries with vcpkg?
Alternatively is it possible to send me some info how you created the libraries?
Thank you, best regards
Chris Nabold
From: John Sheppard<EMAIL_ADDRESS>Sent: Friday, 11 September 2020 04:20
To: microsoft/vcpkg<EMAIL_ADDRESS>Cc: ChrisNabold<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/vcpkg] librsb (#12651)
Any update on this open issue?
https://user-images.githubusercontent.com/25817529/92844305-0e5c7c00-f429-11ea-8308-4ac7856e9e50.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/microsoft/vcpkg/issues/12651#issuecomment-690833083 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIE3ZGDWCEIM52TPKCQEIDSFGCNPANCNFSM4PN2XHAQ .  https://github.com/notifications/beacon/AEIE3ZCXTUEZXTNTK7DTVBTSFGCNPA5CNFSM4PN2XHA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFEWUNOY.gif

You don't need vcpkg to build and install any library/program.
Just download the source code and type the following commands:
a) cmake <whatever option you need/like> ..
b) make all
c) make install
There are plenty of online tutorials about cmake! So .... there is no excuse.

This issue is almost two months old! Any update on it?

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


The only tag for the cello-{$IMG} is latest, which causes the install script to fail

When I use scripts/master_node/download_images.sh to pull the image, the error occurs:
Pulling hyperledger/cello-dashboard:x86_64-latest from dockerhub
Error response from daemon: manifest for hyperledger/cello-dashboard:x86_64-latest not found: manifest unknown: manifest unknown
Error response from daemon: No such image: hyperledger/cello-dashboard:x86_64-latest
Pulling hyperledger/cello-nginx:x86_64-latest from dockerhub
Error response from daemon: manifest for hyperledger/cello-nginx:x86_64-latest not found: manifest unknown: manifest unknown
Error response from daemon: No such image: hyperledger/cello-nginx:x86_64-latest
Pulling hyperledger/cello-api-engine:x86_64-latest from dockerhub
Error response from daemon: manifest for hyperledger/cello-api-engine:x86_64-latest not found: manifest unknown: manifest unknown
Error response from daemon: No such image: hyperledger/cello-api-engine:x86_64-latest

After I checked the tags in dockerhub, I found that maybe you forgot to add this tag. The only tag for the below images is latest.

v1.0 is still under development and some images have not yet been uploaded.
You can use v0.9


Fixed Duplicate File Functionality

Description
Fixed Duplicate File Functionality
Fixed SwiftLint Error
Old PR:
https://github.com/CodeEditApp/CodeEdit/pull/728
Related Issue

#727

@lukepistrol Hi, sorry about that.. I fixed all of the problems (this is one of my first code-review pull requests so sorry about all of the errors)

@Blackhole1123 No problem 😉

Alright

@Blackhole1123 Do you need help with the merge conflicts?

@Blackhole1123 Do you need help with the merge conflicts?

Nope, I just have a bit of work I need to complete. Planning on pushing by the end of the week. Feel free to fix it if you want though (I have very little experience with pull requests, so not super sure on how that'd work.

@Blackhole1123 Do you need help with the merge conflicts?

Nope, I just have a bit of work I need to complete. Planning on pushing by the end of the week. Feel free to fix it if you want though (I have very little experience with pull requests, so not super sure on how that'd work.

I can have a look.

@Blackhole1123 Do you need help with the merge conflicts?

Nope, I just have a bit of work I need to complete. Planning on pushing by the end of the week. Feel free to fix it if you want though (I have very little experience with pull requests, so not super sure on how that'd work.

I can have a look but the changes are in your forked repo. I won't have push access for any changes. Will need to create a brand new PR with the changes. Unless someone knows a way around

@lukepistrol Should I close this PR then?

I'd say just fix merge conflicts and then we can work it out

this PR can be closed because of #736


Does this open source project support leveldb files in LDB format?

Hi all:
I want to use this open source project to parse the minecraft map database which is store in leveldb.but i find the db folder of map file only has db file which is endup with  .ldb not contain *.sst .as i kown  .ldb is the new format  leveldb is store.could you tell me how can i solve this problem ? thanks a lot

I had the same issue previously. .ldb is not supported by Dain's project. My recommendation: use https://github.com/fusesource/leveldbjni This project allowed me to parse through my DB

Thank you for your reply thanks  a lot! @UngratefulFool

@UngratefulFool  I found that the https://github.com/fusesource/leveldbjni is not support ldb type ,the reason is that the google leveldb is not support ldb type. we can reference the source file filename.cc in leveldb/db subfolder : in function ParseFileName
// Owned filenames have the form:
//    dbname/CURRENT
//    dbname/LOCK
//    dbname/LOG
//    dbname/LOG.old
//    dbname/MANIFEST-[0-9]+
//    dbname/[0-9]+.(log|sst)
but in  https://github.com/Mojang/leveldb-mcpe project which is overwite by mincraft  has support ldb type
we can reference the same filepath in leveldb-mcpe project:
// Owned filenames have the form:
//    dbname/CURRENT
//    dbname/LOCK
//    dbname/LOG
//    dbname/LOG.old
//    dbname/MANIFEST-[0-9]+
//    dbname/[0-9]+.(log|sst|ldb)


Update links with tenant id

When you click an engagement link on the home page it redirects to a 404. This is because we are missing a /:tenant_id in the link url. Investigate to see if there are any other artifacts as well.

Verified, the engagement links on the home page are working fine.


Added Elixir option to ThemeScaffold

Not sure if this is something you'd want for this module. I was planning to put it in a separate one but thought I'd check in first to see if you'd prefer to have it as part of the existing ThemeScaffold.
Added the option to include elixir as part of the theme scaffolding. During the setup you can choose to include elixir and specify the version if you like.
If you choose to include Elixir as part of the theme scaffolding it will be configured to look for source files in THEME_NAME/resources and generate your assets within your THEME_NAME/assets directory.
It also includes the 'stylistPublish' Elixir extension. An updated version of the snippet documented here: https://asgardcms.com/docs/themes/usage#elixir
New unit tests were added to make sure it's backwards compatible. No elixir files are created when you choose 'no' during setup. Tests were added to validate the elixir files get created as well when you choose 'yes' during setup.
To manually test:
php artisan asgard:theme:scaffold
// 1. 'vendor/themename' [Enter]
// 2. 'frontend' [Enter]
// 3. 'Yes' [Enter]
// 4. '*' [Enter]
// 5. '*' [Enter]
cd Themes/themename
npm install
// add a css or less file to be mixed in
gulp
// see the generated file in Themes/themename/assets
// see the published assets in public/themes/themename

The .php_cs file seems to be out-dated so I ran this (tried to match it up as best as I could)
php-cs-fixer fix . --rules=@PSR1,@PSR2,concat_with_spaces,ordered_imports,no_extra_consecutive_blank_lines,no_useless_return,no_unused_imports,no_whitespace_in_blank_lines --verbose --dry-run

Not sure if you're still following the PSR2 standards since most of the files failed the unix line endings test, so I left them as-is.

Thanks. But please use the .php_cs file to run php-cs-fixer.

@nWidart I'll tinker around with this some more tomorrow. Unfortunately when I run php-cs-fixer I see this:
vagrant@homestead:~/Code/AsgardCMS/Platform/Modules/Workshop$ php-cs-fixer fix . --verbose --dry-run
PHP Fatal error:  Uncaught Error: Class 'Symfony\CS\Finder\DefaultFinder' not found in /home/vagrant/Code/AsgardCMS/Platform/Modules/Workshop/.php_cs:3

Is there some other script I need to run beforehand?

do you have php-cs-fixer installed globally ?

Closing since I'm unable to run php-cs-fixer. If I find time to troubleshoot this I'll re-open in the future.
Tried running this (as described here: https://asgardcms.com/docs/getting-started/contributing#style-guide)
cd Modules/Workshop
php-cs-fixer fix . --config-file=".php_cs" --verbose

Error:
  [Symfony\Component\Console\Exception\RuntimeException]
  The "--config-file" option does not exist.

Corrected it to
php-cs-fixer fix . --config=".php_cs" --verbose

Error:
PHP Fatal error:  Uncaught Error: Class 'Symfony\CS\Finder\DefaultFinder' not found in /home/vagrant/Code/AsgardCMS/Platform/Modules/Workshop/.php_cs:3

Tried to run it a few ways and keep getting this error.  I have to get back to my project but will try and find time to look into this when I can.


Some questions about εmax

Hi, thanks for your excellent work!!!
I am confused about the εmax , which you have mentioned in chapter 4.3.
How to define and calculate the εmax , I can not find a explanation in your paper.
Could you please explain this? Thanks.

Thank you for your attention to our work. We have scaled the camera positions to a bounding box of [-1, 1] and set \epsilon_{max} to 0.1 on data of all scales (https://github.com/Open3DVLab/NeuRodin/blob/main/nerfstudio/fields/neurodin_field.py#L268).
We have not tuned this parameter because we believe it will not have a significant impact on the results—just ensuring it is not set too small (missing natural level set constraints of large-scale features) or too large (resulting in high variance in normal estimates for most regions).

Thanks for your reply!


xidel: 0.9.6 -> 0.9.8, refactor

Motivation for this change
Currently broken:
$ nix run github:NixOS/nixpkgs/c28262e2fe67c021c37e2e3532d4ebe77401be81#xidel -- --version
Runtime error 216 at $000000000054BDEB
  $000000000054BDEB

I've refactored the expression, now it's based on the source code and not from the binary deb package. Inspiration came from https://github.com/benibela/xidel/blob/Xidel_0.9.8/.travis.yml .
Should help #71689 if #108532 get done.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134267 at 90218b37 run on aarch64-linux 1

1 package built successfully:

xidel

3 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/text/xidel/default.nix:65:3:
   |
65 |   installPhase = ''
   |   ^

warning: patch-phase
patchPhase should not be overridden, use postPatch instead.
Near pkgs/tools/text/xidel/default.nix:40:3:
   |
40 |   patchPhase = ''
   |   ^

warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/tools/text/xidel/default.nix:73:3:
   |
73 |   checkPhase = ''
   |   ^

Thanks!


Explain AddCors and                 builder.AllowAnyMethod().AllowAnyHeader()

Explain this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0dd2991d-c22d-ad0f-80b6-bd1b503db8f3
Version Independent ID: 5e3fbe1d-c97f-9940-4f0c-067d4b2112b1
Content: Get started with SignalR on ASP.NET Core
Content Source: aspnetcore/tutorials/signalr.md
Product: aspnet-core
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Ok, multiple people have complained about this, we should either remove it from this basic sample, or point to https://docs.microsoft.com/en-us/aspnet/core/signalr/security?view=aspnetcore-2.1#cross-origin-resource-sharing

@anurse thoughts?

@tdykstra  and I chatted about this. The plan is to remove it from the sample and below the sample say something like
A real deployed app needs CORS to work.  For more info, see

Perhaps it's better to call out the code and say it's not required to run the app locally, but is required when  ...


Convert README to Markdown to enable table use in GitHub

Codecov Report

Merging #2 (ef3a394) into main (e58c70f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          207       207
  Branches        14        14
=========================================
  Hits           207       207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58c70f...ef3a394. Read the comment docs.


Added select type conversion test

This change is

Coverage remained the same at 74.697% when pulling d35575b164865dd453037dd86efc074c8a045759 on david-puglielli:type-conversion-for-ae into 45f422abbaffb4e8487e720053470120dd5c81e2 on Microsoft:dev.

Codecov Report

Merging #783 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #783   +/-   ##
=======================================
  Coverage   80.06%   80.06%
=======================================
  Files          25       25
  Lines        7323     7323
=======================================
  Hits         5863     5863
  Misses       1460     1460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f422a...d35575b. Read the comment docs.


fix this

i changed config.json and it's not working
Traceback (most recent call last):
File "C:\Users\windows\Desktop\Spotify-Account-Creator-main\creator.py", line 557, in
gen = Gen()
^^^^^
File "C:\Users\windows\Desktop\Spotify-Account-Creator-main\creator.py", line 58, in init
self.config_file = json.load(open('data/config.json', 'r', encoding='utf-8'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\windows\AppData\Local\Programs\Python\Python311\Lib\json_init_.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "C:\Users\imSkyDie\AppData\Local\Programs\Python\Python311\Lib\json_init_.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\windows\AppData\Local\Programs\Python\Python311\Lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\windows\AppData\Local\Programs\Python\Python311\Lib\json\decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
C:\Users\windows\Desktop\Spotify-Account-Creator-main>PAUSEn 25 (char 614)

{
"settings": {
"Threads": 3,
"Create_Username": "y",
"Create_Avatar": "y",
"Change_Avatar": "y",
"Use_Proxy": "n",
"Remove_Bad_Proxies": "n",
"Debug_Mode": "if you are not a developer, do not touch this value!! (if you're going to change you can just do 'y')"
},
"verification_settings": {
    "Verify_Mail": "n",
    "Services": {
        "Use_MailTM": "n",
        "Use_Emailnator": "n"
    }
},

"target_settings": {
    "Use_Target": "y",
    "Target_To": 3
},

"follow_ids": {
    "Account_IDs": ["account id1", "account id2", "account id 3 (u can put as many as you want)"],
    "Playlist_IDs": ["playlist id1", "playlist id2 (u can put as many as you want)"],
    "Artist_IDs": ["artist id1", "artist id (u can put as many as you want)"]
},

"follow_types": {
    "Profile": "n",
    "Playlist": "n",
    "Artist": "n"
},

"save_methods": {
    "SQLite": "y",
    "Text_File": "y"
}

}

What type of shipping is this? Throw it all in between the ```. Or take a screenshot

Just download the tool again and run run.bat. You will not get such an error.

still error


Undefined Method 'current_user' for controller class method 'render'

Rails: 6.0.2
Clearance: 2.0.0
When I have include the ClearanceController method in my ApplicationContrller(or subclass of)
and I call
ApplicationController.render(partial: "foos/bar", assign: { current_user: User.first })
I recieve an error from
/home/chris/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/clearance-2.0.0/lib/clearance/authentication.rb:39:in 'current_user'
The main issue here is that I can't add a helper method, I still get the above error:
def current_user
  @current_user ||= super
end

If I comment out the include, change the helper and assign the current_user in the render call everything works as expected.
class ApplicationController < ActionController::Base
  # include Clearance::Controller
  protect_from_forgery with: :exception

  def current_user
    @current_user
  end
end

This can easily be tested in the console.
A workaround is to create a RendererClass from ActionController::Renderer which may be a more pure way to achieve my goal but I still wanted to report this oddity.

Possibly related? https://github.com/thoughtbot/clearance/issues/848
Can you be a little more specific about what you're trying to do and how/where you're doing it? Also read through the linked issue and see if it's more or less the same problem.

After reading through the liked issues. It is related, I'm also rendering a template outside of the request/response cycle. However, Maybe I need to rephrase my issue because when using a controllers class method .render I should be able to assign the instance var @current_user via the assigns param in the render method.
ApplicationController.render(partial: "foos/bar", assign: { current_user: User.first })
Then add a helper:
# app/helpers/user_helper.rb

def current_user
  @current_user ||= super
end

However, Clearance seems to override this helper_method as I get the error above:
/home/chris/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/clearance-2.0.0/lib/clearance/authentication.rb:39:in 'current_user'
A better title for this Issue might be Clearance is not allowing a @current_user instance var to be set

I don't think this is actually the problem, but as a small note here - in the code you pasted you are using assign: ... but I think you actually want to use assigns: ....
That said, a few more things:

Is your goal just to override the view helper current_user method, or to actually have clearance "sign in" a user? The @current_user ivar you might be setting in your view or controller is probably not the same one clearance is using internal to track the user. But you might be able to call sign_in to have clearance sign in a user (with the caveats of the linked issue about renderers).
Can you paste the full error output you are seeing, and/or more of your code, and/or a minimal test case showing what you want to happen and how it's failing?

I'm going to close this on the assumption that my last comment, or the linked issue, might have helped resolve/explain this. If there's more to do here in terms of a bug fix or feature addition, re-open and comment please.


Implement Auth Integration Test

logout endpoint
test login wrong password
find user by id
find logged user
update password
update name
update role


spacebar was released before all of the fluid was drained

This text shows up when all of the fluid has been drained, and the robot has handed over the item successfully

Fixed


性能问题

缩率图scale系数改为1时  快速滑动列表明显感觉到卡顿

And found sample there also memory leak,Bitmap did not release after exit app.


Using gocode from command-line

Hi,
I'm interested in providing autocomplete support for the SciTE editor.  Passing the current cursor position and file, and parsing the output for a drop-down is not likely to be difficult.  But I have hit an immediate snag: I always get a panic in the server by invoking 'gocode autocomplete full-path-to.go cursor-pos' directly.
This appears in ripper.go, line 40, presumably out of range on the slice there.
(Using the latest Go release )
steve d.

It helps to pay attention to -h ;) So now I have
gocode -in="test.go" autocomplete test.go 14
and now we blow up in package.go, at parseExportedName (331)
panic: expected "@", got String (""os'"")
steve d.

Hi. As far as I can see you use the latest gocode version, but you haven't updated to the latest Go weekly. Latest Go weekly has a new package files format, it was changed due to preparation for adding inlining optimizations.
So, just update your Go to the latest weekly or checkout different gocode version (see gocode git repo tags, it has a lot of compatibility tags).

That was about the second panic. The first panic indeed may happen due to incorrect cursor position. I wasn't paying a lot of attention to checking the correctness of incoming data.

Thanks, man - that worked great - I was obviously not paying attention when trying to update to latest Go (it did feel like a file format change problem).


Support for all ASGI frameworks

One of the cool thing about ASGI is we can hook with asyncio loop easily and that allows us to implement background task not just to channels but any ASGI framework. I'm going to invest some time around this year to change the code to support for all the asgi applications.

Closing this temp because I don't think all of the ASGI frameworks will implement consumer calling func.


Update package.nls.zh-cn.json

Short description of what this resolves:
Update file 'package.nls.zh-cn.json' by human friendly.
Changes proposed in this pull request:

improve translation quality

Checklist:

[x] "ext.config.forceDownload.name": "Force Download"

[x] "ext.config.forceUpload.name": "Force Upload"

[x] "ext.config.quietSync.name": "Quiet Sync"

[x] "ext.config.autoUpload.name": "Auto Upload"

[x] "ext.config.autoDownload.name": "Auto Download"

[x] "ext.config.gist.name": "Gist ID"

[x] "ext.config.gist.placeholder": "Enter Gist ID"

[x] "ext.globalConfig.gistDescription.name": "Gist Description"

[x] "ext.globalConfig.gistDescription.placeholder": "Enter Gist Description"

[x] "ext.globalConfig.autoUploadDelay.name": "Auto Upload Delay"

[x] "ext.globalConfig.autoUploadDelay.placeholder": "Enter the amount of seconds to delay auto-upload"

[x] "ext.globalConfig.downloadPublicGist.name": "Download Public Gist"

[x] "ext.globalConfig.token.name": "Access Token"

[x] "ext.globalConfig.token.placeholder": "Enter Token"

[x] "common.button.yes": "Yes"

[x] "common.action.support": "Support This Project"

[x] "common.action.joinCommunity": "Join Community"

[x] "common.action.donate": "Donate Now"

[x] "common.action.openExtTutorial": "Open Tutorial"

[x] "common.error.gistNotSave": "Sync: Gist Not Saved."

[x] "common.error.tokenNotSave": "Sync: Token Not Saved."

[x] "cmd.howSetting.title": "Sync: How To Configure"

[x] "cmd.updateSettings.title": "Sync: Update/Upload Settings"

[x] "cmd.updateSettings.info.uploadingDone": "Sync: Upload Complete. GIST ID: {0}. Please copy and use this ID in other machines to download settings."

[x] "cmd.updateSettings.info.uploadingFile": "Sync: Uploading Files Data."

[x] "cmd.updateSettings.info.uploadingSuccess": "Sync: Uploaded Successfully."

[x] "cmd.updateSettings.info.uploadCanceled": "Sync: Upload Process Cancelled."

[x] "cmd.updateSettings.info.uploading": "Sync: Uploading/Updating Your Settings In GitHub."

[x] "cmd.updateSettings.info.newGistCreated": "Sync: New gist created."

[x] "cmd.updateSettings.error.newGistCreateFail": "Sync: Unable to create Gist."

[x] "cmd.updateSettings.error.gistNotSave": "Sync: GIST NOT SAVED"

[x] "cmd.downloadSettings.title": "Sync: Download Settings"

[x] "cmd.downloadSettings.info.downloaded": "Sync: Download Complete."

[x] "cmd.downloadSettings.info.gotLatestVersion": "Sync: You already have the latest version of saved settings."

[x] "cmd.otherOptions.title": "Sync: Advanced Options"

[x] "cmd.otherOptions.openSettingsPage": "Sync : Open Settings"

[x] "cmd.otherOptions.editLocalSetting": "Sync: Edit Extension Local Settings"

[x] "ext.config.syncExtensions.name": "Sync Extensions"

[x] "ext.config.removeExtensions.name": "Remove Extensions"

[x] "ext.globalConfig.askGistName.name": "Ask Gist Name"

[x] "ext.globalConfig.supportedFileExtensions.placeholder": "Enter one file extension per line"

[x] "ext.globalConfig.ignoreUploadFiles.placeholder": "Enter one file per line"

[x] "ext.globalConfig.ignoreUploadFiles.name": "Ignored Files"

[x] "ext.globalConfig.ignoreExtensions.name": "Ignored Extensions"

[x] "ext.globalConfig.ignoreExtensions.placeholder": "Enter one extension per line (full name)"

[x] "ext.globalConfig.ignoreUploadFolders.name": "Ignored Folders"

[x] "ext.globalConfig.ignoredUploadFolders.placeholder": "Enter one folder per line"

[x] "common.placeholder.multipleGist": "Gist Name (e.g.: Personal Settings)"

[x] "common.action.openExtPage": "Open Extension Page"

[x] "common.action.releaseNotes": "Release Notes"

[x] "common.info.gistSaved": "Sync: Gist Saved"

[x] "common.info.updateTo": "Sync: Updated to v{0}"

[x] "common.info.tokenSaved": "Sync: Token Saved"

[x] "common.info.updating": "Sync: Updating In Progress… Please Wait."

[x] "cmd.otherOptions.releaseNotes": "Sync: Release Notes"

[x] "cmd.otherOptions.joinCommunity": "Sync: Join Community"

[x] "cmd.updateSettings.error.readGistFail": "Sync:  GIST ID: {0} UNABLE TO READ."

[x] "cmd.resetSettings.info.settingClear": "Sync: Settings Cleared."

[x] "cmd.resetSettings.title": "Sync: Reset Extension Settings"

[x] "cmd.resetSettings.info.resetting": "Sync: Resetting Your Settings."

[x] "cmd.otherOptions.toggleForceDownload": "Sync: Toggle Force Download"

[x] "cmd.otherOptions.toggleForceDownload.on": "Sync: Force Download Turned On."

[x] "cmd.otherOptions.toggleForceDownload.off": "Sync: Force Download Turned Off."

[x] "cmd.otherOptions.toggleForceUpload": "Sync: Toggle Force Upload"

[x] "cmd.otherOptions.toggleForceUpload.on": "Sync: Force Upload Turned On."

[x] "cmd.otherOptions.toggleForceUpload.off": "Sync: Force Upload Turned Off."

[x] "cmd.otherOptions.openIssue": "Sync: Open Issue"

[x] "cmd.otherOptions.downloadCustomFile.done": "Downloaded {0}."

[x] "common.info.installed": "Sync: Settings created, thank you for installing!"

[x] "common.info.needHelp": "Sync: Need Help configuring this extension?"

[x] "cmd.downloadSettings.info.readdingOnline": "Sync: Reading Settings Online."

[x] "cmd.downloadSettings.error.removeExtFail": "Sync: Unable to remove some extensions."

[x] "cmd.downloadSettings.error.unableSave": "Sync: Unable to save extension settings file."

[x] "cmd.otherOptions.preserve.info.done1": "Sync: Done. {0} value will be removed from settings.json after downloading."

[x] "ext.config.title": "Code Settings Sync Configuration Settings"

[x] "ext.config.gist": "GitHub GIST ID for Settings Sync."

[x] "ext.config.autoDownload": "Set it true to Auto Download the settings on code start. [Code Restart Required]"

[x] "ext.config.autoUpload": "Set it true to Auto Upload on the settings change. [Code Restart Required]"

[x] "ext.config.forceDownload": "Set it to true if you want to download the settings even when you have the latest settings."

[x] "ext.config.forceUpload": "Set it to true if you want to upload the settings even when the GIST has newer settings."

[x] "ext.config.host": "Set it to your GitHub Enterprise host if you want to use GHE."

[x] "ext.config.quietSync": "When set to true, will show the result in status bar instead of summary page."

[x] "ext.config.removeExtensions": "Set it to false if you don't want to remove extensions while downloading."

[x] "ext.config.syncExtensions": "Set it to false if you don't want to upload/download the extensions."

[x] "cmd.updateSettings.info.shareGist": "Sync: Share the Id with other extension users to share the settings."

[x] "cmd.otherOptions.shareSetting": "Sync: Share Settings with Public GIST"

[x] "cmd.otherOptions.shareSetting.beforeConfirm": "Sync: This will remove current GIST and upload settings on new public GIST. Do you want to continue?"

[x] "cmd.otherOptions.downloadSetting": "Sync: Download Settings from Public GIST"

[x] "cmd.otherOptions.toggleAutoUpload": "Sync: Toggle Auto-Upload On Settings Change"

[x] "cmd.otherOptions.toggleAutoUpload.on": "Sync: Auto upload on Setting Change Turned On. This will take effect after restart.",

[x] "cmd.otherOptions.toggleAutoUpload.off": "Sync: Auto upload on Setting Change Turned Off."

[x] "cmd.otherOptions.toggleSummaryPage": "Sync: Toggle Show Summary Page On Upload/Download"

[x] "cmd.otherOptions.warning.tokenNotRequire": "Sync: Settings Sync will not ask for GitHub Token from now on."

[x] "cmd.otherOptions.error.toggleFail": "Sync: Unable to Toggle."

[x] "common.info.initAutoUpload": "Sync: Auto Upload Initiating In {0} Seconds."

[x] "ext.globalConfig.githubEnterpriseUrl.name": "GitHub Enterprise URL (optional)"

[x] "ext.globalConfig.githubEnterpriseUrl.placeholder": "Enter GitHub Enterprise URL"

[x] "ext.globalConfig.hostName.name": "Hostname (optional)"

[x] "ext.globalConfig.hostName.placeholder": "Enter Hostname"

[x] "common.placeholder.enterGithubAccessToken": "Enter GitHub Personal Access Token"

[x] "common.placeholder.enterGistId": "Enter Gist Id"

[x] "cmd.otherOptions.quietSync.off": "Sync: Summary will be shown upon download/upload."

[x] "cmd.otherOptions.quietSync.on": "Sync: Status bar will be updated upon download/upload."

[x] "cmd.otherOptions.customizedSync": "Sync: Add Custom Sync File path"

[x] "cmd.otherOptions.customizedSync.placeholder": "Enter an absolute path of the additional uploaded file."

[x] "cmd.otherOptions.customizedSync.done": "Sync: {0} has been registered."

[x] "cmd.otherOptions.preserve.info.done2": "Sync: Done. Extension will keep {0}: {1} in setting.json after downloading."

[x] "cmd.otherOptions.preserve": "Sync: Preserve Setting To Stop Override After Download"

[x] "common.error.invalidGistId": "Sync: Invalid Gist Id Entered. Verify your gist: https://gist.github.com/<your_userName>/<gist_id>."

[x] "common.error.invalidToken": "Sync: Invalid/Expired GitHub Token. Please generate new token with scopes mentioned in readme. Exception Logged in Console."

[x] "common.error.connection": "Sync: Internet Not Connected or Unable to Connect to GitHub. Exception Logged in Console"

[x] "common.info.donate": "Sync: Do you like this extension? How about writing a review or sending a donation? ;)"

[x] "common.error.message": "Sync: Error Logged In Console (Help menu > Toggle Developer Tools)."

[x] "common.info.setToken": "Sync: Now You can set your GitHub token manually in syncLocalSettings.json"

[x] "common.error.canNotSave": "Sync: Unable to Save Settings. Please make sure you have valid JSON settings.json file. (e.g.: No trailing commas)"

[x] "common.info.excludeFile": "Sync: You can exclude any file/folder for upload and settings for download."

[x] "ext.config.askGistName": "Ask gist name upon creating. Helps you to identify the gist if you have multiple gists."

[x] "ext.globalConfig.openTokenLink.name": "Open Token Link"

[x] "ext.globalConfig.supportedFileExtensions.name": "Supported File Extensions"

[x] "common.prompt.gistNewer": "Sync: Gist has a newer or identical version of your settings. Do you want to enable forceUpload to override this?"

[x] "ext.config.lastUpload": "Settings Sync last upload date. Set it as empty if you want to manually hit download."

[x] "ext.config.lastDownload": "Settings Sync last download date. Set it as empty if you want to manually hit download."

[x] "common.prompt.multipleGist": "Allows you to identify the settings if you have multiple gist."

[x] "cmd.updateSettings.info.readding": "Sync: Reading Settings and Extensions."

[x] "ext.config.pathPrefix": "Set it to your GitHub Enterprise API prefix if you want to use GHE. Normally '/api/v3'. Only used when host is set."

[x] "cmd.otherOptions.preserve.prompt": "Example: Write 'http.proxy' => store this computer proxy and overwrite it , if set empty it will remove proxy."

[x] "cmd.otherOptions.downloadCustomFile": "Sync: Import Custom Sync File to workspace"

[x] "cmd.otherOptions.triggerReset": "Sync: Do you want to reset the settings ?"

[x] "common.prompt.restartCode": "Do you want to reload to apply extensions and configurations?"

[x] "common.prompt.enterGithubAccessToken": "You also manually add a token (User Folder/syncLocalSettings.json). Press [Enter] or [Esc] to cancel."

[x] "common.prompt.enterGistId": "Enter Gist Id from previously uploaded settings. You can also set manually in code settings (sync.gist). Press [Enter] or [Esc] to cancel."

[x] "common.action.writeReview": "Write Review"

[x] "cmd.otherOptions.customizedSync.prompt": "(ex. /path/to/.eslintrc) will be uploaded and downloaded to the specified path."

[x] "cmd.otherOptions.downloadCustomFile.placeholder": "Select the file you want to download to the root of the workspace you are working on."

[ ] "cmd.otherOptions.preserve.placeholder": "Enter any Key from settings.json to preserve."

[ ] "cmd.updateSettings.warning.OSNotSupported": "Sync Pragma OS value {0} not supported at line {1}"

[ ] "cmd.updateSettings.warning.noToken": "Sync: Set GitHub Token or disable 'downloadPublicGist' from local Sync settings file."

There are conflicts, because cn is already been fixed and scheduled for v3.4.1

please close


HDFS-15447 RBF: Add top real owners metrics for delegation tokens

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 16s
trunk passed

+1 :green_heart:
compile
19m 23s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
16m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 40s
trunk passed

+1 :green_heart:
mvnsite
2m 17s
trunk passed

+1 :green_heart:
shadedclient
19m 33s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 44s
hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 41s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 51s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 31s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 20s
the patch passed

+1 :green_heart:
compile
18m 35s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
18m 35s
the patch passed

+1 :green_heart:
compile
16m 39s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
16m 39s
the patch passed

-0 :warning:
checkstyle
2m 38s
root: The patch generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46)

+1 :green_heart:
mvnsite
2m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 58s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 44s
hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 40s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 48s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
3m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 27s
hadoop-common in the patch passed.

-1 :x:
unit
8m 15s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

171m  3s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRBFConfigFields

hadoop.hdfs.server.federation.security.TestRouterSecurityManager

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2110

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8a06221d6636 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cd188ea9f0e

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/testReport/

Max. process+thread count
3141 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Please check the failed unit tests and checkstyle report by yetus.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  1s
trunk passed

+1 :green_heart:
compile
27m 52s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
18m  8s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 54s
trunk passed

+1 :green_heart:
mvnsite
2m 11s
trunk passed

+1 :green_heart:
shadedclient
21m  7s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 36s
hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 35s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 33s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 29s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 32s
the patch passed

+1 :green_heart:
compile
20m 36s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
20m 36s
the patch passed

+1 :green_heart:
compile
19m 57s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
19m 57s
the patch passed

-0 :warning:
checkstyle
3m  0s
root: The patch generated 3 new + 60 unchanged - 2 fixed = 63 total (was 62)

-1 :x:
mvnsite
0m 42s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 31s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 36s
hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 33s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 39s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
0m 39s
hadoop-hdfs-rbf in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
9m 55s
hadoop-common in the patch passed.

-1 :x:
unit
0m 36s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

212m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2110

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 8a17ef9069ae 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e8dc862d385

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/testReport/

Max. process+thread count
1458 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  7s
trunk passed

+1 :green_heart:
compile
23m  8s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
19m 20s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 49s
trunk passed

+1 :green_heart:
mvnsite
2m  4s
trunk passed

+1 :green_heart:
shadedclient
21m 20s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 36s
hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 33s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 42s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 48s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s
the patch passed

+1 :green_heart:
compile
23m 56s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
23m 56s
the patch passed

+1 :green_heart:
compile
20m  7s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
20m  7s
the patch passed

-0 :warning:
checkstyle
3m  2s
root: The patch generated 2 new + 60 unchanged - 2 fixed = 62 total (was 62)

-1 :x:
mvnsite
0m 36s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 52s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 40s
hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 34s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 37s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
0m 38s
hadoop-hdfs-rbf in the patch failed.

_ Other Tests _

-1 :x:
unit
11m 27s
hadoop-common in the patch passed.

-1 :x:
unit
0m 38s
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

186m 43s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2110

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 895a36dcf8fc 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e8dc862d385

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/testReport/

Max. process+thread count
1378 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks very much @sunchao @goiri  for the detailed review. I have addressed all comments and please give it another look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
21m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 13s
trunk passed

+1 :green_heart:
compile
19m 11s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
16m 35s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
3m 17s
trunk passed

+1 :green_heart:
mvnsite
2m 21s
trunk passed

+1 :green_heart:
shadedclient
20m 16s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 45s
hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 41s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 48s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 26s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 20s
the patch passed

+1 :green_heart:
compile
18m 25s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
18m 25s
the patch passed

+1 :green_heart:
compile
16m 36s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
16m 36s
the patch passed

-0 :warning:
checkstyle
2m 41s
root: The patch generated 1 new + 60 unchanged - 2 fixed = 61 total (was 62)

+1 :green_heart:
mvnsite
2m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  8s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 44s
hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 41s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 48s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
3m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 29s
hadoop-common in the patch passed.

+1 :green_heart:
unit
8m 15s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

191m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2110

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux a23c7d24a34e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55a2ae80dc9

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/testReport/

Max. process+thread count
3337 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Hmm @fengnanli it seems not all comments were addressed in the latest commit

I didn't know I have to click resolve conversation to publish the reply. Just resolved all of the comments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
21m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m  2s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
18m 59s
trunk passed

+1 :green_heart:
compile
20m  8s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
17m 22s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
2m 37s
trunk passed

+1 :green_heart:
mvnsite
2m  9s
trunk passed

+1 :green_heart:
shadedclient
19m 15s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 45s
hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 42s
hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 49s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 28s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 21s
the patch passed

+1 :green_heart:
compile
18m 30s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
18m 30s
the patch passed

+1 :green_heart:
compile
16m 34s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
16m 34s
the patch passed

-0 :warning:
checkstyle
2m 45s
root: The patch generated 1 new + 60 unchanged - 2 fixed = 61 total (was 62)

+1 :green_heart:
mvnsite
2m 21s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 33s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 39s
hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

-1 :x:
javadoc
0m 37s
hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
1m 35s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
3m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 16s
hadoop-common in the patch passed.

-1 :x:
unit
8m 15s
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 51s
The patch does not generate ASF License warnings.

191m 47s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2110

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 89c2dced6705 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f77bbc2123e

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/diff-checkstyle-root.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/testReport/

Max. process+thread count
3171 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2110/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

github screwed up a lot of my comments and I will reply again.

Thanks @sunchao @Hexiaoqiao for the review!

The test failure is relevant and it passed locally in my mac.

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
[INFO] Tests run: 49, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.51 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 49, Failures: 0, Errors: 0, Skipped: 0

Tests also passed locally. Merged. Thanks @fengnanli .


Pillow 10 compatibility

Pillow 10.0.0 came out recently and drops Image.LANCZOS as a symbol (was deprecated in 9?). The new symbol is Image.Resampling.LANCZOS
Also update Python and Django versions in pyproject.toml and test.yml

I created a PR instead of just reporting the issue that Pillow 10.0.0 drops Image.LANCZOS. Feel free to suggest/make changes.


/lib/moment.js not found

The file "/lib/moment.js" is not found in the project.
I get file on http://guillaumebiton.github.io/HackerNews7/lib/moment.js for run project

moment.js should be retrieve by npm when you install dependencies.
If you try :
npm install
or :
npm install moment
You should see moment directory into node_modules. Now gulp will be able to put the library into the lib directory.

no activity, so think it's fix


Unify logging interface

Sometimes it's logging sometimes logger
Proposal:
import logging
LOG = logging.getLogger(__name__)

@dodobas has this been addressed, and how exactly does this affect the service? Should it be considered as high priority or can I downgrade it for now?


shasum?

Can you provide a shasum and is there a signed version of the files with key?

What would be the benefit? This is not a binary distribution that can be modified without you noticing, it's just a text file.

Sorry thought this was for the tool. Thanks for the guidance!


Update qemu from 8.2.0 to 9.0.0

What this PR does
Before this PR:
We're using an older qemu version and make rpm-deps fails because the repository doesn't include qemu 8.2.0
After this PR:
Qemu is now at a recent version and make rpm-deps works again

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Qemu updated from 8.2.0 to 9.0.0

/test all

/cc @andreabolognani
Can you have a look? Thank you

/approve

@fossedihelm thanks for tagging me!
9.0.0-6 has already been made available so we could potentially pick that up instead of 9.0.0-5. That said, I'm going to prepare the usual "update the entire stack" PR once libvirt 10.5.0 lands in CentOS Stream, and there's probably going to be further QEMU builds between now and then, so it's likely fine to keep things the way they are.

@fossedihelm thanks for tagging me!
9.0.0-6 has already been made available so we could potentially pick that up instead of 9.0.0-5. That said, I'm going to prepare the usual "update the entire stack" PR once libvirt 10.5.0 lands in CentOS Stream, and there's probably going to be further QEMU builds between now and then, so it's likely fine to keep things the way they are.

Bumped! Thank you :)

/lgtm
/hold
Giving @andreabolognani possibility to check this again.
Feel free to unhold. Thank you

Is there a reason to not wait for update of the whole stack?

Is there a reason to not wait for update of the whole stack?

This was to unblock make rpm-deps. We can wait, but in the meantime no PR can make any change to the package tree.

Is there a reason to not wait for update of the whole stack?

This was to unblock make rpm-deps. We can wait, but in the meantime no PR can make any change to the package tree.

Yes, the question is if we have any changes coming. Maybe lets ask @andreabolognani , what is the ETA, if you have an estimate.

I'm waiting for libvirt 10.5.0 to hit the mirrors. IIUC an issue was found in the first build and is currently being addressed. I'm afraid I can't really offer an ETA though... Ideally it wouldn't take longer than a week or two, but we've had cases in the past where multiple circumstances conspired to make the delay much, much longer.

The missing qemu version is causing some of our bump automations to fail  - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/bump-kubevirt-rpms-weekly/1812811149503107072#1:build-log.txt%3A585
Is it ok to take this in without the full libvirt lift?

@brianmcarey I think we do, we can bump again later.
@andreabolognani @jean-edouard @xpivarc objections?

That CI job is pretty much guaranteed to start failing periodically.
I can see a couple of ways that we could potentially reduce the pain caused by the constant churn of packages in CentOS Stream.
The first one is to augment the artifact mirroring process that is already happening for RPMs added to KubeVirt's WORKSPACE so that, in addition so simply uploading them as-is to cloud storage, it also runs createrepo and publishes the output to a known location.
That way, we could have an additional entry in repo.yaml and we would simply start pointing directly to KubeVirt's cloud storage for packages that have disappeared from CentOS Stream, which is already happening as the build time fallback anyway. This will supposedly only really be relevant for the few packages for which we pin a specific version.
The other option would be to somehow make bazeldnf ignore the missing packages. I can't immediately see a way to make that work sensibly without potentially cause trouble for other usage patterns, but maybe further analysis would reveal one.
@alicefr I believe we have talked about the first option in the past. Do you remember the outcome of that discussion?
Anyway, that's for the long term. In the immediate, I don't have any specific objection to bumping QEMU on its own if doing so unblock things, with the assumption that CI passes and the understanding that we're going to follow that up with a full upgrade of the virt stack shortly afterwards.

That CI job is pretty much guaranteed to start failing periodically.
I can see a couple of ways that we could potentially reduce the pain caused by the constant churn of packages in CentOS Stream.
The first one is to augment the artifact mirroring process that is already happening for RPMs added to KubeVirt's WORKSPACE so that, in addition so simply uploading them as-is to cloud storage, it also runs createrepo and publishes the output to a known location.
That way, we could have an additional entry in repo.yaml and we would simply start pointing directly to KubeVirt's cloud storage for packages that have disappeared from CentOS Stream, which is already happening as the build time fallback anyway. This will supposedly only really be relevant for the few packages for which we pin a specific version.
The other option would be to somehow make bazeldnf ignore the missing packages. I can't immediately see a way to make that work sensibly without potentially cause trouble for other usage patterns, but maybe further analysis would reveal one.
@alicefr I believe we have talked about the first option in the past. Do you remember the outcome of that discussion?

We didn't reach a conclusion, but this problems regularly recurs, so yes, I think we could add the google storage for the rpm. The problem is that the storage contains all the rpms, so it will be a fallback for all the dependencies, not only the one with a pinned version. IMO, it is fine since it should firstly pick the official centos stream repo.

I have just opened #12452 which is a superset of this PR and as such should IMO supersede it.


undefined method `[]=' for nil:NilClass

There is an open issue that mentions this (https://github.com/jrgifford/delayed_paperclip/issues/129), but the remedies mentioned in that solution did not work for me, and this appears to be related to Paperclip v 5.1.0.  Paperclip v 5.0.0 and DelayedPaperclip v 3.0.0 work fine together.  Paperclip v 5.1.0 and DelayedPaperclip v 3.0.0 cause this error to occur whenever trying to reference model.attachment.url (model.attachment works fine).
I apologize, but I don't have time to spend debugging this, currently.

@jasonivers This should be fixed in 3.0.1 which is now released - can you please try it and confirm?

Yes, that seems to have done it.  Thank you for the prompt attention.


HHH-14346 Check declaredPluralAttributes for null before access

Fixes HHH-14346

Can one of the project team members please rerun the build? I believe the failure is unrelated to the changes. Please also let me know if this needs to be altered in some way.

Please create a PR against the master branch. I'll make sure that we consider to backport this fix to 5.4

Many thanks, I've applied it already and included @beikov 's suggestion, as we'll release a 5.4 soon :)


Cube Thunderwave

Either character is not moving or its being cast as if it has range

Seems ok in 3.50


Defined 2 more profiles for OKE runs, added support to run OKE tests in parallel and sequence runs

Defined 2 more profiles oke-parallel, oke-sequencial in addition to oke-cert.
Added more tests to run in OKE.
https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/767
https://build.weblogick8s.org:8443/job/wko-oke-nightly-parallel/80/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10955

if we want to verify all tests in OKE, we also need different profiles: I did same logic, moved tests which can't be run in parallel to oke-seq , added tests to oke-parallel and kept oke-cert for shorter version just to verify major fixes or certification.


Revise expectations in integration tests

Context
In the course of adding integration tests we have added a lot of different and specific assertions which can be replaced with more powerful combinators reducing the code.
Decision
Replace the myriad of assertions functions with more powerful combinators. For instance, we have expectFieldEqual, expectFieldBetween, expectFieldNotEqual etc ... which can all be expressed via expectFieldSatisfy ... Also, all of the expectEventually ... can be replaced by a combination of other expectation and the eventually combinator we introduced recently.
Acceptance Criteria

Development
In #1317:

Removed bunch of assertion functions which where replaced by only:

expectField
expectListField
expectCliField
expectCliListField

All of which take as an argument a function that is supposed to verify the condition we want to check (a -> Expectation). For instance:
expectField #migrationCost (`shouldBe` Quantity 0)
expectField id (`shouldSatisfy` (not. null))

greaterThan and (.>=) helper functions added to use with expectations.

Removed expectEventually and repaced with the combination of eventually_ and other expectations

In #1339, revise names of new functions.
QA
All tests are passing after the changes, no tests where removed or added.

lgtm! 🎉


NTR: regulation terms for GO:0061517 macrophage proliferation

Could I please have regulation (and +ve, -ve) for GO:0061517 macrophage proliferation.
Needed for annotation of PMID:27756793.
Please add GOC references GOC:rph, GOC:BHF and GOC:BHF_miRNA.
Thanks,
Rachael.

Here are your terms.
+id: GO:0120040
+name: regulation of macrophage proliferation
+namespace: biological_process
+def: "Any process that modulates the frequency, rate or extent of macrophage proliferation." [GOC:BHF, GOC:BHF_miRNA, GOC:rph]
+intersection_of: GO:0008150 ! biological_process
+intersection_of: regulates GO:0061517 ! macrophage proliferation
+created_by: kchris
+creation_date: 2017-05-10T20:38:19Z
+
+[Term]
+id: GO:0120041
+name: positive regulation of macrophage proliferation
+namespace: biological_process
+def: "Any process that activates or increases the frequency, rate or extent of macrophage proliferation." [GOC:BHF, GOC:BHF_miRNA, GOC:rph]
+intersection_of: GO:0008150 ! biological_process
+intersection_of: positively_regulates GO:0061517 ! macrophage proliferation
+created_by: kchris
+creation_date: 2017-05-10T20:45:01Z
+
+[Term]
+id: GO:0120042
+name: negative regulation of macrophage proliferation
+namespace: biological_process
+def: "Any process that stops, prevents, or reduces the frequency, rate or extent of macrophage proliferation." [GOC:BHF, GOC:BHF_miRNA, GOC:rph]
+intersection_of: GO:0008150 ! biological_process
+intersection_of: negatively_regulates GO:0061517 ! macrophage proliferation
+created_by: kchris
+creation_date: 2017-05-10T20:51:40Z


AutoFleet API: How to deal with expired refreshToken

Hi team,
I'm currently working with https://docs.autofleet.io/reference/post-v1-login-refresh API on Mobile app.
The first time I call the login/refresh API, I have used the refreshToken as a parameter (downloaded from the Admin page). I’m currently storing it as a constant in the app. This could lead to problems when the refreshToken expires after about three months.
I also noticed that the documentation suggests saving the new refreshToken from the response to avoid expiration. Yes, I understand, but the issue is that during the first login/refresh call, I am storing the refreshToken (downloaded from Admin) as a constant in the app, which causes the refreshToken to expire after some time.
Is there a way to handle this issue besides having to download a new refreshToken from Admin page?

Hi Jose,
I'm afraid that due to security purposes it is not possible to override the current process.
But it shouldn't expire too often as mentioned in the "Managing refresh tokens" instructions, about every 3 months.


test case code refactoring

In order to simplify the steps of writing test case, we probably need to do some refactoring. For example, we need to run tensorflow and generate idx file manually now. I think that we can write scripts to generate data before running test case automatically.
Then, we can just compare the result between tensorflow and utensor. It will be easier to extend other test case to increase test coverage.

@Knight-X The only test cases that truly need IDX files are the tensor ops tests and IDX loader. These are assumed to be fixed mathematical operators with well defined behavior as a function of their inputs.

@Knight-X @mbartling @dboyliao
Guys, while we are at it, we should replace idx file with ROM_tensor.

rom_tensor is fine. But we still need a tool to generate weight array or we have to do it manually. Compared to pushing weight files on github, I think that generating the necessary weight files before running all tests make more sense.


Replace questions with single row

Display a single row containing the category name and match in place of
the more detailed match report.
Signed-off-by: Ryan Y<EMAIL_ADDRESS>

Affects #91.

Screenshot, as requested:


[Notion] ...

Extension
https://www.raycast.com/notion/notion
Raycast Version
1.75.1
macOS Version
14.5
Description
Error:
FetchError: request to https://notion.oauth.raycast.com/token failed, reason: unable to get local issuer certificate

    at withAccessToken(MA)
Fr:index.js:11:2490
    at ray-navigation-stack
Io:index.js:11:2088

Steps To Reproduce

Macbook Pro M1 Pro 16 inch (16 gb ram)
Both on Hotel wifi and phone hotspot.
Same issue after rebooting

Browser (Arc - Chromium) shows a success message, after opening raycast I get an error.
Current Behaviour
Login into notion is successful in the browser but fails.
Expected Behaviour
No response

Are you using some kind of VPN/firewall/proxy?

Hi @thomaslombart I was indeed...
I tried to connect notion on my company laptop, which uses zscaler.
I should've thought about that, I tried about 15 times, without any luck.
Now I disabled zscaler and it worked right away.
Sorry to have bothered you!
(Maybe I shouldn't have tried to set this up at 11 at night...)
Thanks for you comment!

Hi Raycast Team,
I am having the same unable to get local issuer certificate error on my company mac (with zScaler). Even on dict.cc or google translate extension. Is there any workaround, because I can't turn off zScaler :(

same issue face with me

It works for me


Error in documentation about defaultTrigger

According to this line, defaultTrigger: 'click', but in documentation it's defaultTrigger: 'hover focus'

What about this line? :smile_cat:


Browser Back button doesn't work in Safari

i

It's an open bug in Angular 2. Hopefully, it'll be solved by the release.

chilling story

Looks like the original bug was closed. Removing the workaround.


Cannot read property then of undefined

Refs: https://github.com/Microsoft/vscode/issues/6655
I am right clicking on greeting and "Find All References" and I get: Cannot read property then of undefined.

@{ var myMessage =	"Hello World"; }

The value of myMessage is: @myMessage

@{
var greeting = "Welcome to our site!";
var weekDay = DateTime.Now.DayOfWeek;
var greetingMessage = greeting + " Here in Huston it is: " + weekDay;
}

The greeting is: @greetingMessage

Same for handlebars btw.

also happens in html

It is a problem in the UI code.
ReferenceWidget.setModel returns undefined in some cases.
index.html?config={"pathArguments"%3A[]%2C"programStart"%3A0%2C"enablePerformance"%3Afalse%2C"verbo…:31 TypeError: Cannot read property 'then' of undefined
    at file:///C:/Alex/src/vscode/out/vs/editor/contrib/referenceSearch/browser/referencesController.js:120:60
    at Object.notifySuccess [as _notify] (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1440:59)
    at Object.state_success_notify.enter (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1127:30)
    at Promise_ctor.WinJS.Class.define._run (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1343:29)
    at Promise_ctor.WinJS.Class.define._completed (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1311:18)
    at argDone (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:2072:37)
    at Promise.then.errors.(anonymous function) (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:2097:78)
    at Object.notifySuccess [as _notify] (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1440:59)
    at Object.state_success_notify.enter (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1127:30)
    at Promise_ctor.WinJS.Class.define._run (file:///C:/Alex/src/vscode/out/vs/base/common/winjs.base.raw.js:1343:29)

verifier: run a reference search that yields in no result.


CI on android-23 is frozen until Google fixes the corresponding system-images

The builds on Travis are failing on android-23. This is due to the android utility not returning the system-images for this platform.
The issue is reported on code.google.com and Android devs have been contacted on their G+ account. Until the system-images can again be installed with android, we should update the build matrix to target the remaining available platforms.

The issue has been reported on StackOverflow too:

sys-img-armeabi-v7a-android-23 is missing from the repository
Android sys-img-armeabi-v7a-android-23 not found


Caption drag

Just drag some tab 10 times and you get:

@spargo-protek does this repro with the TabView in the "XAML Controls Gallery" app?

No, subsequent drags do not lead to this bug in XAML Controls Gallery.

I can't reproduce this, no matter how much I try. Is the issue just that it gets stuck in drag mode?


Failing test test_blockwise_dataframe_io[True-None-hdf]

I got what I think is an unintended CI failure here: https://github.com/dask/dask/runs/5698232986?check_suite_focus=true
    @pytest.mark.filterwarnings(
        "ignore:Running on a single-machine scheduler when a distributed client "
        "is active might lead to unexpected results."

E   tables.exceptions.HDF5ExtError: HDF5 error back trace
E
E     File "H5F.c", line 620, in H5Fopen
E       unable to open file
E     File "H5VLcallback.c", line 3502, in H5VL_file_open
E       failed to iterate over available VOL connector plugins
E     File "H5PLpath.c", line 579, in H5PL__path_table_iterate
E       can't iterate over plugins in plugin path '(null)'
E     File "H5PLpath.c", line 620, in H5PL__path_table_iterate_process_path
E       can't open directory: /Users/runner/miniconda3/envs/test-environment/lib/hdf5/plugin
E     File "H5VLcallback.c", line 3351, in H5VL__file_open
E       open failed
E     File "H5VLnative_file.c", line 97, in H5VL__native_file_open
E       unable to open file
E     File "H5Fint.c", line 1898, in H5F_open
E       unable to lock the file
E     File "H5FD.c", line 1625, in H5FD_lock
E       driver lock request failed
E     File "H5FDsec2.c", line 1002, in H5FD__sec2_lock
E       unable to lock file, errno = 35, error message = 'Resource temporarily unavailable'
E
E   End of HDF5 error back trace
E
E   Unable to open/create file '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/popen-gw2/test_blockwise_dataframe_io_Tr11/h5'

This might be due to some inherent distributed flakiness going on (CI there isn't in a good state).  I would like to see dask/dask not fall victim to getting used to sporadic failures.

Thanks @mrocklin -- it looks like this issue started a few days ago and was reported over in https://github.com/dask/dask/issues/8816. Closing this issue in favor of continuing with https://github.com/dask/dask/issues/8816

Ah, great.  Great to have you back @jrbourbeau


refactor(batch): schedule with streaming mapping if serving is temporarily unavailable

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If the serving mapping of a fragment is temporarily unavailable due to asynchronous notification, we fallback to use the streaming mapping to schedule. Note that the streaming mapping must be available, even if the table is just created, as we guarantee its notification goes prior to the catalog.
The reason for this change is to enable support for per-fragment variable vnode count. If we lack information about a fragment's mapping, it can be challenging to create a dummy vnode mapping with an unknown length.
This is an alternative of https://github.com/risingwavelabs/risingwave/pull/10815.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#18505  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on  Graphite