fix: api error update full error object instead of only defined keys

Description
Earlier _.assign was being used to update the error response of the api call but post this change full object is being replaced to update all the existing keys from the error response of the api call. So when the header was being updated with invalid chars the response had some plugin details error which was persisting due to _.assign function on removal of invalid chars too, thereby persisting the wrong errored response.
PR fixes following issue(s)
Fixes #26941
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=05016f0

/build-deploy-preview skip-tests=true

@AmanAgarwal041 :tested the PR and observed that when we add the wrong header the API does not get validated and gets executed. I prefer we need to validate the header at the client end as well.
cc: @rohan-arthur

@prapullc , I move this issue back to QA after today's discussion, summarising below:

since this change adds value to the user, we should go ahead with this change
if we want to validate on illegal characters in the headers, this should be tracked in a separate issue

Moving it to the done state as per the above comment. We can go to Release

/ok-to-test


Release Google.Cloud.Optimization.V1 version 2.4.0

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Cloud.Optimization.V1-2.4.0


NoMethodError: mark_trait: undefined method has_prioritized_status? for nil:NilClass

Hi,
I'm trying to use this gem combined with parallel_tests gem. I'm taking the following steps but cannot make it through.
First, since in parallel tests, specs are run partially, I'm setting FactoryTrace configuration like below
FactoryTrace.configure do |config|
  config.path = "#{Rails.root}/trace_#{ENV['TEST_ENV_NUMBER'] == '' ? 1 : ENV['TEST_ENV_NUMBER']}.json"
end

so that the trace files would be generated based on the parallel test number. Then when running the tests;
$ FB_TRACE=trace_only PARALLEL_TEST_PROCESSORS=8 bundle exec rake parallel:spec

Afterwards I run the following commands to merge the partial results
$ trace=""
$ for i in {1..8}; do file=" trace_$i.json"; trace=$trace$file; done
$ FB_TRACE_FILE=fb_report.txt bundle exec factory_trace $trace

but I'm getting this error
/app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:88:in `mark_trait': undefined method `has_prioritized_status?' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:44:in `block (2 levels) in mark_as_used'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:42:in `each'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:42:in `block in mark_as_used'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:38:in `each'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:38:in `mark_as_used'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/lib/factory_trace/processors/find_unused.rb:11:in `call'
from /app/vendor/bundle/ruby/2.4.0/gems/factory_trace-0.3.2/exe/factory_trace:10:in `<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/factory_trace:23:in `load'
from /app/vendor/bundle/ruby/2.4.0/bin/factory_trace:23:in `<main>'

Do you happen to know what might be causing this?

Hey, could you please provide files you pass to bundle exec factory_trace?
BTW, thank you for pointing this out 👍

Thank you for your reply and sure no problem :)
I'm running the tests on a CI built with a limited access so I could only dump the JSON files in the build logs. Here is one json file but all are like this. It seems like they are misstructured.
{
"defined": {
"factories": [
{
"names": [
"access_token"
],
"traits": [

],

Also I fixed the brackets manually and run the factory_trace on my local and I got the below error this time
/Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:64:in `parse_collection': undefined method `each' for nil:NilClass (NoMethodError)
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:37:in `read'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:14:in `block (2 levels) in read_from_files'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:13:in `open'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:13:in `block in read_from_files'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:12:in `each'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/lib/factory_trace/readers/trace_reader.rb:12:in `read_from_files'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/gems/factory_trace-0.3.2/exe/factory_trace:9:in `<top (required)>'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/bin/factory_trace:23:in `load'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/bin/factory_trace:23:in `<main>'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/bin/ruby_executable_hooks:24:in `eval'
from /Users/onurkucukkece/.rvm/gems/ruby-2.4.5/bin/ruby_executable_hooks:24:in `<main>'

Why do you think they are misstructured? The writer and reader are well-tested.
Could you try to dump all of them and attach it here (in separate files please)?
Also, what gem version you are using? It's important to use latest one because it has bug fix: https://github.com/djezzzl/factory_trace/blob/master/CHANGELOG.md#032---20190612.
Also, be sure, you have the same version when trace usage and when run bundle exec factory_trace <files>

It seemed that the brackets are not closed in the json files but on the other hand I cannot be sure since  I'm getting the file contents using head command in CI built logs. And also there ~1K tests so it might be related to our tests as well. I extracted the file contents from the logs and created separate
files traces.zip

Oh, I see. If you're sure that you copy/pasted files from CI correct, then something is wrong.
Because for 1k+ tests, I assume you should have more then one access_token factory. Also, it's strange, but somehow the writer do not finish its printing, so there should be a closed brackets for sure.
Output, should be something like this.
So, your files won't help me. I'll try to play with parallel_tests gem.
In the meaning time, could you share how exactly you copy files content from CI? I don't think head is a good choice, I think by default it gets only first N lines, what is wrong, because I need full content of each file.
If it's possible to run tests locally, please do so, that you can check the full contents of generated files and send it to me.

Hi @onurkucukkece,
I did try to use the gem with parallel_tests and it works as expected.  You can try it yourself, just apply this diff to the gem:
diff --git a/rails-rspec-example/Gemfile b/rails-rspec-example/Gemfile
index 65ad002..aa52d33 100644
--- a/rails-rspec-example/Gemfile
+++ b/rails-rspec-example/Gemfile
@@ -3,6 +3,8 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }

 ruby '2.5.5'

+gem 'parallel_tests', group: %i[development test]
+
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
 gem 'rails', '~> 5.2.2', '>= <IP_ADDRESS>'
 # Use sqlite3 as the database for Active Record
diff --git a/rails-rspec-example/config/database.yml b/rails-rspec-example/config/database.yml
index 0d02f24..2a657aa 100644
--- a/rails-rspec-example/config/database.yml
+++ b/rails-rspec-example/config/database.yml
@@ -18,7 +18,7 @@ development:
 # Do not set this db to the same as development or production.
 test:
   <<: *default
-  database: db/test.sqlite3
+  database: db/test<%= ENV['TEST_ENV_NUMBER'] %>.sqlite3

 production:
   <<: *default
diff --git a/rails-rspec-example/spec/rails_helper.rb b/rails-rspec-example/spec/rails_helper.rb
index c2c1013..e7cb6b8 100644
--- a/rails-rspec-example/spec/rails_helper.rb
+++ b/rails-rspec-example/spec/rails_helper.rb
@@ -7,6 +7,7 @@ abort("The Rails environment is running in production mode!") if Rails.env.produ
 require 'rspec/rails'
 # Add additional requires below this line. Rails is not loaded until this point!
 require 'support/factory_bot'
+require 'support/factory_trace'
 # Requires supporting ruby files with custom matchers and macros, etc, in
 # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
 # run as spec files by default. This means that files in spec/support that end
diff --git a/rails-rspec-example/spec/support/factory_trace.rb b/rails-rspec-example/spec/support/factory_trace.rb
index e69de29..0fa5bbd 100644
--- a/rails-rspec-example/spec/support/factory_trace.rb
+++ b/rails-rspec-example/spec/support/factory_trace.rb
@@ -0,0 +1,4 @@
+FactoryTrace.configure do |config|
+  config.path = "#{Rails.root}/trace_#{ENV['TEST_ENV_NUMBER'] == '' ? 1 : ENV['TEST_ENV_NUMBER']}.json"
+  config.mode = :trace_only
+end

Setup databases: rake parallel:setup
Run: FB_TRACE=1 rake parallel:spec[2]
You will get two files generated:

{
  "defined": {
    "factories": [
      {
        "names": [
          "user"
        ],
        "traits": [
          {
            "name": "with_phone",
            "declaration_names": [

            ]
          }
        ],
        "parent_name": null,
        "declaration_names": [

        ]
      },
      {
        "names": [
          "special_user"
        ],
        "traits": [

        ],
        "parent_name": "user",
        "declaration_names": [

        ]
      },
      {
        "names": [
          "admin"
        ],
        "traits": [
          {
            "name": "with_address",
            "declaration_names": [

            ]
          }
        ],
        "parent_name": "user",
        "declaration_names": [

        ]
      }
    ],
    "traits": [
      {
        "name": "with_email",
        "declaration_names": [

        ]
      }
    ]
  },
  "used": {
    "factories": [
      {
        "names": [
          "special_user"
        ],
        "traits": [
          {
            "name": "with_phone",
            "declaration_names": [

            ]
          }
        ],
        "parent_name": null,
        "declaration_names": [

        ]
      }
    ],
    "traits": [

    ]
  }
}

{
  "defined": {
    "factories": [
      {
        "names": [
          "user"
        ],
        "traits": [
          {
            "name": "with_phone",
            "declaration_names": [

            ]
          }
        ],
        "parent_name": null,
        "declaration_names": [

        ]
      },
      {
        "names": [
          "special_user"
        ],
        "traits": [

        ],
        "parent_name": "user",
        "declaration_names": [

        ]
      },
      {
        "names": [
          "admin"
        ],
        "traits": [
          {
            "name": "with_address",
            "declaration_names": [

            ]
          }
        ],
        "parent_name": "user",
        "declaration_names": [

        ]
      }
    ],
    "traits": [
      {
        "name": "with_email",
        "declaration_names": [

        ]
      }
    ]
  },
  "used": {
    "factories": [
      {
        "names": [
          "special_user"
        ],
        "traits": [

        ],
        "parent_name": null,
        "declaration_names": [

        ]
      }
    ],
    "traits": [

    ]
  }
}

As you can see they both have proper JSON inside.

Run bundle exec factory_trace trace_1.json trace_2.json

You will get perfect output:
total number of unique used factories & traits: 3
total number of unique unused factories & traits: 3
unused factory admin
unused trait with_address of factory admin
unused global trait with_email

So I need more information about your case. Maybe I could pair with your for a while, if you want. Because I can't find any problem with gem itself.

Feel free to reopen an issue if needed.


Upgrade to go-grpc-middleware/v2

Right now, we are using both v1 and v2 of the grpc interceptors:
https://github.com/openfga/openfga/blob/5ac6f9b6be6b4d5efb55f3195e929df0557d2ab1/go.mod#L18-L19
But, v2 is the path forward: https://github.com/grpc-ecosystem/go-grpc-middleware#changes-compared-to-v1
We are also using github.com/grpc-ecosystem/grpc-gateway/v2.
This task is about migrating to go-grpc-middleware/v2.
Following the update, the following things relating to interceptors should be verified:

Logging fields for a Check request should remain the same
Exporting metrics should still work
Exporting traces should still work
If authentication is enabled in the service, it should still work
Auth0 FGA uses OpenFGA and so it should also still work

Hi @miparnisari,
I would be glad to help with this dependency upgrade.
However, I will need some help with the verification that this upgrade doesn't fail the functionality mentioned above

Sure thing @ilaleksin!

Logging fields for a Check request should remain the same

We have a test for this :) https://github.com/openfga/openfga/blob/ca5dde2b9574c1b7137881a852610d5bf8aa55e6/tests/check/check_test.go#L44

Exporting metrics should still work
Exporting traces should still work

Doing docker-compose up --build should start up OpenFGA and all the telemetry containers, so simply going to the Jaeger UI (localhost:16686) and the Prometheus UI (localhost:9090) should prove that traces and metrics are still being exported correctly. You can attach screenshots in the PR to prove this.

If authentication is enabled in the service, it should still work

We have tests for this too:

https://github.com/openfga/openfga/blob/1887ace6cbf54fbaf534834e28d1e6433b2bbf4e/cmd/run/run_test.go#L554
https://github.com/openfga/openfga/blob/0d38ae05f3de40773f6ba6afc66b18e59a5b9651/cmd/openfga/main_test.go#L433

And you can also run a sanity check using Docker: OPENFGA_AUTHN_METHOD=preshared OPENFGA_AUTHN_PRESHARED_KEYS=mykey docker-compose up
and then any call like
curl --location 'http://localhost:8080/stores' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer wrong' \
--data '{
  "name": "blah"
}'

should give unauthenticated.

Auth0 FGA uses OpenFGA and so it should also still work

I can test this on my end, since Auth0 FGA is closed source.

Hi @miparnisari and @willvedd,
This issue was without changes for some time so I prepared a PR to resolve it.
Basically, I copied removed middleware from grpc-go-middleware v1.4.0 to support upgrade to v2 without changes in log fields propagation.
I tried to explain the logic behind this solution in the PR. Briefly speaking, I couldn't migrate AuthorizationModel ID logging to logging.InjectField API.
Can you review the PR?


Add test data generator

Add test data generator and check visually if labels are assigned correctly.

closed by #6


What computer configuration is required to use this code

Maybe the requirements listed here can help: https://github.com/snap-stanford/SATURN/issues/63#issuecomment-2206738195


Add: Helper Cards for the charging configuration

THEN:

read charging configuration and provide the config as tokens
Active power limits
Deactivate power limits

AND:

max charging limit is higher than
max discharging limit is higher then
max charging limit is active
max discharging limit is active
any limit on the charging system is active

WHEN:

max charging limit changed
max discharging limit changed

ALL CARDS

add hints as documentation

implemented in 0.6.0


Create new organisation and fork repo there

After repo cleanup #1 and adding python scripts #3

done: https://github.com/Krakowska-Masa-Krytyczna/Wavelo-Stats


line.peak style now darker

(they were too light to be seen on older screens)
trying to resolve this issue.

Coverage remained the same at 94.382% when pulling 700e451ea8c84e6e8fb5e4e38a08290e7d7c787a on jspaaks:line-peak-style into 36913bf0de910856592cdbe18883aafae739e0ec on NLeSC:master.


Tutorial links in the left pane

Why are the links in the left pane taking me to different sites. Shouldnt it open a page within the same Azure docs. Please try clicking Power BI or AI builder links.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ffd6c661-3889-e5bf-0b33-d84eff80e8a3
Version Independent ID: 7b185544-3127-394d-c621-4eaa9088cd4a
Content: Tutorial: Integrate Power BI with the Text Analytics Cognitive Service - Azure Cognitive Services
Content Source: articles/cognitive-services/text-analytics/tutorials/tutorial-power-bi-key-phrases.md
Service: cognitive-services
Sub-service: text-analytics
GitHub Login: @aahill
Microsoft Alias: aahi

@parasharshah The Power Apps tutorial is actually from Power Apps doc set and we are just referencing that in TA TOC. Same with the tutorial for Databricks. The difference is that for Power Apps, the content is in a different Github repo while for Databricks it's in the same Azure docs repo. Because of that, when you click the Power Apps link, you are taken to a different doc site because the context cannot be maintained. However, the experience is slightly different for Databricks link.
This is expected behavior.
#please-close

Tank's


Upgrade netty version

Purpose
fixes https://github.com/wso2/apk/issues/1828

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (75ce98d) 29.24% compared to head (0395fb6) 80.18%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1829       +/-   ##
===========================================
+ Coverage   29.24%   80.18%   +50.93%
===========================================
  Files         198        9      -189
  Lines       20893      550    -20343
  Branches     5163      246     -4917
===========================================
- Hits         6111      441     -5670
+ Misses      14651      109    -14542
+ Partials      131        0      -131

Flag
Coverage Δ

admin-domain-service
?

backoffice-domain-service
?

common-controller
?

devportal-domain-service
?

idp-domain-service
80.18% <ø> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 176 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Develop Footer

Expected folder structure:
.
├── ...
├── components
│   ├── [ComponentName]
│       └── [ComponentName].tsx
│       └── [ComponentName].module.css
└── ...

Göktuğ and I want to undertake this task.

caution: a faulty fork, can you pull it to your repository just for checking purposes?
https://github.com/mertkama/website/tree/website-test


feat: improve deep equality check failing message for toBe

What does this PR do?
A PR for issue #1290.
We would like to have a message to remind users they should use deep equality checks, when object comparison fails with toBe. The error message would look like this now:

The implementation is similar to how jest does it.
How the change is tested?
Unit tests

Thanks for working on the issue that I opened, however I still prefer how Jest shows the error, the text is more aligned especially around the expectations of expected/received. Also I see you added square brackets around the "serializes to the same string" but I find that a little bit confusing, I didn't know (until I looked at your code change) that the bracket was something that you added, I wasn't sure if the text inside it was dynamic or not (it's not) and that made it confusing, it's also not an array so why use brackets and not double quotes? Nonetheless, it's a great improvement compare to current code, so I'd be curious to see what the core team will reply. Thanks again for working on the issue
I like how Jest shows it, everything is aligned and more readable
expect(received).toBe(expected) // Object.is equality

    If it should pass with deep equality, replace "toBe" with "toStrictEqual"

    Expected: [{"age": 30, "id": 123, "name": "John"}]
    Received: serializes to the same string

      at Object.<anonymous> (/src/index.spec.ts:34:50)

@ghiscoding @sheremet-va
Does the current error message look good to us?

@ghiscoding @sheremet-va
Does the current error message look good to us?

Yeah this is much closer to Jest message, love it


Add syllable number data and relatedness data

[ ] in .csv files?
[ ] Add to tests/data-for-tests/
[ ] or possibly add to package itself in src/songdkl/data, if these are lightweight .csv files -- a user could then test with them directly

@dgmets I realized that I do already have 'fath_offspring.csv' that lists relatedness -- I think this was in the Dryad dataset files?

@dgmets provided the sylno_out.csv by email and I added it in #43


Quick Open does not have an ideal approach when it comes to long file paths

In my opinion, either showing the end of the path or having a marquee approach would be better from a UX point of view.
I recently bought OniVim2 and I wish to make it my daily driver. I am super impressed by the editor but there are a few rough edges here and there. This is one of them.
A point to note is that this behaviour majorly happens for files that are out of the CWD of Oni. Thus forcing it to show the full path.

The same issue is literally 3 below yours

The same issue is literally 3 below yours

Oh. Thanks, I'll close it.


ext/git: Fix CanonicalRepoURL for go1.8.

Go 1.8 introduced changes to url.Parse, making it reject
urls of the format git@github.com:user/project.
Fix is to prefix these with ssh://.
See go 1.8 release notes: https://golang.org/doc/go1.8#net_url

Superseded by #394


Try to type ContextExclusionPlugin

@sandersn @sokra
We need to have a way of typing compiler hooks so we don't have to declare the types again when hooking into various compiler events. Do you have any suggestions?

We need to have a way of typing compiler hooks so we don't have to declare the types again when hooking into various compiler events. Do you have any suggestions?

@TheLarkInn did this in this PR: https://github.com/webpack/webpack/pull/7299/files#diff-7a14ca420cc4fa7cf55f788246117e7cR45


Fix the dpkg_parser cloudbuild.yaml.

I opened an internal bug asking for it a while back, but tl;dr it doesn't exist today.


Extended Jacobian calculation for CIGs from Seismic data.

Possible feature request but is an implementation of an extended Jacobian available through the API? Something along the lines of ImageGather.jl - Subsurface?
Alternatively, are there alternative forms of migration like Kirchhoff's available for easier retrieval of CIGs, I'm particularly interested in subsurface gathers. Thanks!

Possible feature request but is an implementation of an extended Jacobian available through the API? Something along the lines of ImageGather.jl - Subsurface?

Well  ImageGather.jl - Subsurface is implemented with devito so you can ust look at the source of it (implementation.py) for the details of the implementation
We do not currently have example of  Kirchhoff migration but it could be an interesting highlight, not sure if we'll be able to look into it anytime soon but we always appreciate contributions.


Insights and Highlights

This PR adds Highlights and Insights.
The insights are based on #745 .
The Request class had to be changed, but i hope this is ok.

 Thank you :) It would also be awesome to have the Promotion Insights as well. Is it possible?

@Nerixyz hello! How did you found request parameters for the /api/v1/highlights/${userId}/highlights_tray/ request? I can't find any way to get media from each highlighted tray item

Didn't mention that you're right. Thought it was ok


Send out wrapping-up email to speakers

Include

Thanking for presenting and participating
Link to survey https://forms.gle/CAKiGcK8JxpNWPD26
Request permission to share recordings on youtube
Request copy of their slides (drive folder: https://drive.google.com/drive/u/1/folders/1seezApNep0wSFD6aqD-ZqcF3fjFqBj4I)
Ask if they want to participate in writing the perspective

donezo :100:


Bar chart redraws upon dataset change

Bar charts redraw on dataset length update.  Unit test included.

This looks good. The build is failing because of an issue that is now fixed on master. Can you rebase from master to get the latest code? Thank you.

@aomra015 Thank you for taking a look.  Rebased and pushed.

Would be great if you can release a new version for this change.

@jgelens I've released v2.0.5 -- thanks for the reminder!

Thanks a lot!


chore: run github actions parallelly

Hi there
Github actions check not only build but also test, fmt and clippy so I divided into some parts.
It can run CI check parallelly and save time.
Question
I am reading about Revisiting the Nova Proof System on a Cycle of Curves.

Is $R1CS^{(2)} := (A_2,B_2,C_2 \in \mathbb F_2^{n_2 \times m_2})$ correct instead of $R1CS^{(2)} := (A_2,B_2,C_2 \in \mathbb F_1^{n_2 \times m_2})$?
Sorry if I am wrong.
I would appreciate it if you could confirm.
Thank you.

Thanks for the CI update, it looks great!
Regarding your question, yes, that is indeed correct. We will fix the typo.

Thank you for the review!


[Fix-6352] [ApiServer] fix process definition copy bug

close #6352
override the old process definition when  copy workflow
fix it

Codecov Report

Merging #6357 (4a3ab58) into dev (58eb20a) will increase coverage by 0.06%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##                dev    #6357      +/-   ##
============================================
+ Coverage     38.88%   38.94%   +0.06%
- Complexity     3219     3224       +5
============================================
  Files           637      637
  Lines         25452    25459       +7
  Branches       2770     2770
============================================
+ Hits           9896     9915      +19
+ Misses        14648    14635      -13
- Partials        908      909       +1

Impacted Files
Coverage Δ

...api/service/impl/ProcessDefinitionServiceImpl.java
35.87% <57.14%> (+0.20%)
:arrow_up:

...ache/dolphinscheduler/server/log/LoggerServer.java
78.26% <0.00%> (-8.70%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
:arrow_up:

...rver/master/processor/queue/TaskResponseEvent.java
100.00% <0.00%> (+6.45%)
:arrow_up:

...er/master/processor/queue/TaskResponseService.java
55.29% <0.00%> (+15.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eb20a...4a3ab58. Read the comment docs.


Add option to search for icons

This allows users to change icons and will try to find icons on steamgriddb.

This PR should fix this issue:
https://github.com/PhilipK/BoilR/issues/108


As a judge, I want to vote on videos

This story includes making a video submission component for the Judging Interface.
This includes integrating an embed video player and displaying the appropriate one (YouTube or Vimeo) based on the URL / provider that is included in the entry. The player should take up the entire size of the component, but still be a 16:9 aspect ratio.
The player should autoplay.

See:
https://github.com/pedronauck/react-video
https://github.com/CookPete/react-player

as easy as react-video looks like it is for our case, I'm not sure it's being maintained. So I'm using react-player

Ah, you're right. They still have "react": ">=0.12.2" listed as a peerDependency – that's pretty old in the React world. react-player sounds good.


Auto-create a changelist from a previous version

If a user supplies a previous version of an Ontology/Profile/Vocab alongside the new version being documented, then a changeset can be automatically made, just like this one: https://linkedearth.github.io/ontology/core/1.2.0/index-en.html#changes

For ontoflow I create this diff with bubastis and I will just add it to pylode's output.

I think you should keep doing that for the moment. I've been looking at
bubastis and yes, it's functionality could be recreated in Python for
inclusion in pyLODE or use elsewhere, but it wouldn't be a 5 min job!
I might try to see if one of our clients needs ont diffing capability.
Currently we use RDFDelta (https://afs.github.io/rdf-delta/) for RDF
diffing for our own RDF backup purposes and that's not too different.
Nick
On Mon, Aug 16, 2021 at 8:31 PM BonaBeavis @.***> wrote:

For ontoflow https://gitlab.com/kupferdigital/ontoflow/ I create this
diff with bubastis and I will just add it to pylode's output.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RDFLib/pyLODE/issues/150#issuecomment-899403277, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX3SEGBYDCPOUJU6Y7RLRDT5DSHBANCNFSM5CG45NYQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Do not rewrite node's id property?

https://github.com/bkrem/react-d3-tree/blob/1306492c9a1bd2bbae00d331a0277bf1c2fff4d2/src/Tree/index.js#L143
I am trying to make a remote network request with a node's id, but it seems that it's original value was rewritten by a random uuid.
How about replace id with _id or something else that will not affects the original value?

found the id in node.value 🤣

found the id in node.value 🤣

the value property is assigned by myself in redux when the same data is used by other components.
Although I can fix it manually by simply traversing it, I think preserve the id property is a better choice


How to use Volt::Boolean?

I have the following field definitions in my User class:
field :admin, Volt::Boolean
And for my user_seeds.rb file I have
store = Volt.current_app.store

user = store._users.buffer
# ...
user.admin = true
puts user.save!.inspect

When I run it produces:
$ be volt runner app/main/seeds/user_seeds.rb
Volt 0.9.6
D, [2015-12-30T17:59:34.178567 #21447] DEBUG -- : MONGODB | Adding localhost:27017 to the cluster.
#<Promise(47272688869560): #<Volt::Errors {:admin=>["must be true or false"]}>>

The following seems to do what I want:
field :admin, [TrueClass, FalseClass]

Hello @myknbani
Thanks for opening this issue, I do not know the answer to your question and it is not extremely clear to me either.  I saw the only example I could find of it here (https://github.com/voltrb/docs/blob/7a496e81ed547407fb57ef62eedf0c655afa27f5/en/docs/models.md#fields) which does not show it being populated via seeding.
If someone could chime in here on this it would be much appreciated.  Here are some points of interest in the code regarding Volt::Boolean..
https://github.com/voltrb/volt/blob/eae99c12c0b6cda5730303edefd3bc4da5d406f4/lib/volt/models/validators/type_validator.rb
https://github.com/voltrb/volt/blob/eae99c12c0b6cda5730303edefd3bc4da5d406f4/lib/volt/utils/boolean_patch.rb
https://github.com/voltrb/volt/blob/eae99c12c0b6cda5730303edefd3bc4da5d406f4/spec/models/validators/type_validator_spec.rb#L45
@myknbani Would you mind putting up on github an example project that reproduces this issue so that it can be easily investigated further?  I am sure that would help other people interested in determining what they need to do to implement the desired behavior.

@afaur Thanks for chiming in.
I think it's because of
if value.is_a?(type_rest)

true.is_a?(Volt::Boolean) is false.
A quick tinkering with the Volt console shows this  issue:
[2] volt(main)> class Foo < Volt::Model
[2] volt(main)*   field :cute, Volt::Boolean
[2] volt(main)* end
=> :cute=

[3] volt(main)> f = store._foos.buffer(cute: true)
=> #<Foo id: "5885..657b", cute: true>

[4] volt(main)> f.validate!
=> #<Promise(47396377599140): #<Volt::Errors {:cute=>["must be true or false"]}>>

[5] volt(main)> class Bar < Volt::Model
[5] volt(main)*   field :evil, [TrueClass, FalseClass]
[5] volt(main)* end
=> :evil=

[6] volt(main)> b = store._bars.buffer(evil: false)
=> #<Bar id: "f6d5..5c94", evil: false>

[7] volt(main)> b.validate!
=> #<Promise(47396380736960): #<Volt::Errors {}>>


Discontinuity in raw mag readings

I set the calibration coefficients to default for the external mag and then did a mag calibration while logging. When inspecting the log there is a discontinuity in the readings.

This was on modified firmware, however I remember seeing the same thing in this log reported here

Anyone know why this happens and if it is intended behavior?

@CarlOlsson is the discontinuity when you do the calibration? This would make sense because the offsets are set to 0 for the duration of the calibration and then the new offsets are applied.

For us it happens during calibration every time if you before set all mag0 cal parameters to default. However, I am just pulling in some changes from PX4 master and will see if that fixes it. For the log I posted above from the 1.6 RC I guess it could be a switch from external mag to an internal? Unfortunately the sensor_selection topic isn't logged so hard to tell

But that's expected, I'm confused.

I just pulled latest master, reset all mag0 calibration parameters to default, rebooted and did a calibration. Here is the plot from the log file

As can be seen in the plot there is a spike in the beginning of the calibration routine at around 60s. @julianoes is this expected?

Oh, you're saying it spikes at the very beginning of the calibration. Ok, no that doesn't seem expected.
@bkueng have you seen this?

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


lifting_channels passed to UNO is not used

Thank you for maintaining the library. I noticed that the hyperparameter lifting_channels is passed to the UNO model but never used. Only hidden_channels is passed to the Lifting class. Can you please clarify that?

That's a good point. This is something we need to do, make lifting and projection more generic and make them both MLPs by default, currently the lifting is just a single linear layer.

Fixed.


check stale dedup metadata when adding new records/segments

Check stale dedup metadata when adding new records/segments more promptly as the metadata is cleaned when starting next consuming segment which can be very late, e.g. after hours or days. If not checked, new records would be dropped by the existence of stale dedup metadata.

Codecov Report
Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (c00c80d).
Report is 911 commits behind head on master.

Files
Patch %
Lines

...up/ConcurrentMapPartitionDedupMetadataManager.java
0.00%
14 Missing :warning:

...local/dedup/BasePartitionDedupMetadataManager.java
0.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (c00c80d). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (c00c80d)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13848       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2501       +65
  Lines        133233   138508     +5275
  Branches      20636    21531      +895
=============================================
- Hits          82274        0    -82274
- Misses        44911   138508    +93597
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump llvm to 3.9

This would need to be redone in the mono-llvm.py script we have in the Mono repo now, closing.


Network Dialog stays there if WiFi turned on from pulldown menu

When user starts app with WiFi off, then the "Turn WiFi on" dialog comes up. But if the user turns on the WiFi from the pull down menu instead of going to Settings, then the download starts, but the "Turn WiFi on" dialog stays there.

I am not sure, if what you've done solves the issue but the ideal way to fix this is to listen for CONNECTIVITY_CHANGE broadcast. [Source ] (http://developer.android.com/training/monitoring-device-state/connectivity-monitoring.html).

Yeah I get what you mean. I'll update my PR.


Write a JavaScript program to check special character

Description
Write a JavaScript program to check special character
Check if given character is a special character (not a letter or a number).
Input  : @
Output : Special Character

How to contribute

Save the solution in program/CheckSpecialCharacter.js file
Add CheckSpecialCharacter.js file in check-special-character folder

!assign

Hey @suresh37,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign

Hey @harshraj8843 can I use regexp?

Sure


Add doc section to view SiddhiProcess

Purpose

Add doc section to view SiddhiProcess

Approach

Add SiddhiProcess names that can be used along with kubectl commands.

Codecov Report

Merging #1224 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1224      +/-   ##
============================================
+ Coverage     61.44%   61.47%   +0.03%
  Complexity       35       35
============================================
  Files           619      619
  Lines         24942    24942
  Branches       3909     3909
============================================
+ Hits          15325    15333       +8
+ Misses         8289     8283       -6
+ Partials       1328     1326       -2

Impacted Files
Coverage Δ
Complexity Δ

...ut/stream/state/AbsentStreamPreStateProcessor.java
86.61% <0%> (+1.4%)
0% <0%> (ø)
:arrow_down:

.../siddhi/core/util/event/handler/StreamHandler.java
74% <0%> (+12%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af01fb...5a062b9. Read the comment docs.


Add hidden date widget that returns the current date

- Do you want to request a feature or report a bug?
Feature
- What is the expected behavior?
Please add hidden functionality to the date widget so that the date of creating the post can be returned without bothering the user.

This centers around something that sort of happened by mistake imo - the date widget provides a default value that can only be generated by the widget control component while rendered in the editor - we need some way for this to work when hidden.

I have the same need – to store the post creation date on the post. Working locally with eleventy I was relying on file creation dates which it will work with but I came across problems they highlight as a common pitfall when working with Netlify – post creation dates end up out of order.
I did think I could just add a datetime widget that defaults to the current time and assume this won't be altered by the author.
However I need the time to be quite accurate (time not just date) and using a datetime widget the time is when the create new post page is opened, not when the post is created.

any update on this feature/request? I'm having the same need as this one.

Hi @henval2020, the best way to move this forward is a contribution.
As a workaround I think one could use the preSave event to manage dates (add an additional key value to the entry with the creation date if doesn't exist, or assume it's an existing entry if it does exist).

This can be achieved with custom widgets, so I'm closing this as not planned.


Request Microsoft to provide more details on Azure Compute categorization as container exclusive and container compatible on this page.

Request Microsoft to provide more details on Azure Compute categorization as container exclusive and container compatible on this page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 510808e8-db5d-6b07-9a04-6edb743a2dfc
Version Independent ID: 20d098aa-ef31-cb26-d677-765cfc9a7164
Content: Choose an Azure compute service - Azure Architecture Center
Content Source: docs/guide/technology-choices/compute-decision-tree.yml
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @stephen-sumner
Microsoft Alias: ssumner

This is indeed a bug in the diagram.  The blue-shaded services in the decision tree should be only the ones listed in the "Container exclusive services" box.  Looks like there are items in that blue box that are not correct and there are items missing from that blue box.  We'll open a work item to address this.  Thank you @suchitrab for bringing this to our attention!

@suchitrab
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@suchitrab when you see this work item get automatically closed, that means the change has been made and you should see the updated version within about 2 business days on the site.  I expect the issue will be auto-closed in the next few hours.  Thanks for spotting this and letting us know!


Request: Tidal support

Hello! Would it be possible to get support for Tidal too? They have better audio quality than Spotify and Deezer, even on the free (America-only) tier.
Pretty please? <3

Released in v2022.4.30, please give it a go and report back if you find any problems :)

Girls will surely send you wedding proposals for this. Thanks! Gonna go try it now, will report back.

@guihkx
So after trying it today (The Chrome store was slow to send me the update) I can report back that the song sometimes isn't unmuted properly after the ad is done playing
It doesn't seem to happen ever if you set a song to loop
It does however happen if you manually switch songs. Trying to figure out exactly what triggers it!

Thanks for testing, I'll try to take a look at this later today.

It happened again just now. Here's an overly detailed explanation for what I did:

Listen to some songs on my liked list
Switch to a mix, an ad plays the first thing that happens
Minimize Edge and read the news
Wonder where the music went and open Edge and see it's muted

Last night I left Edge playing songs for about 3 hours straight but I still couldn't reproduce this problem :(
When it happens again, can you please leave the tab muted, open the Developer console  (Ctrl Shift I) and screenshot the Console tab for me? Like this:

Thanks

Of course, will screenshot it the next time it happens :)
I find that it doesn't happen when it's playing constantly. It happens when you manually switch songs.

I see... When you say switching songs you mean by pressing the "next" button? Or picking a song on a different playlist/album and playing that? Maybe both?

It happens when I pick a different song in a different playlist or album, from what I've noticed

It happened again. I went for a walk and I left the music on, and when I came home a song is muted.

I waited for another ad to play, but it doesn't unmute after that either.
I'm using Edge with "Added security" if that matters

That's very helpful, thank you. I have been working on a different ad detection approach for TIDAL.
I'll try to publish it today. Last time it took you too long to get the update because SpotiShush got stuck on Google's new review process, but this time it should be faster. I'll let you know when I publish it.

v2022.5.9 is now published on the Chrome Webstore. Please test it.
Thanks

Oof :(
Can you also enable timestamps so I can have a notion of how fast this can happen. This is how you enable timestamps:

Timestamps now enabled! Will report back again when it happens next time.
I typically listen to music at work during Mondays to Thursdays so that's when it's the most likely to happen for me. It happens on my personal computer at home as well, but it's less likely since I listen to it less.
I started working around 2:30 hours before I posted the last message, but it typically takes longer than that to happen.

Thank you! If possible, in your next screenshot, please include the TIDAL website as well (including the tab indicator), like this:

SpotiShush detects ads by monitoring specific HTML elements, so I just want to make sure things are not visually off in that regard...

Hello again, I will make sure to add a screenshot the next time it happens :)
It might take some time though :D

Haha I was trying to reproduce this too and I just that error :S
I'll create another account

As requested!

And again today. Do you want me to try Brave to see if I can replicate it with that browser as well?

I don't think that's necessary, they both share the same engine so it probably affects all Chromium-based browsers. I still can't reproduce this locally, but judging from your screenshots everything looks normal. If I had to guess what the problem is, I'd say that at some point this element we're observing for mutations, gets removed:
https://github.com/guihkx/spotishush/blob/b9691d296f25c1df8d0b00a588200bab1e16c50d/src/spotishush.js#L114
It should be an easy fix, but I just want to make sure that's the actual issue.
Thanks for the help so far!

No problem man. I wonder why it never happens for you? It happens on two different computers for me, one is a budget company laptop and one is a not-so-budget gaming desktop, so there's nothing in common aside from me living in the same country on both computers (duh!)
Thanks for the great work!

No clue either :(
Nevertheless I'll continue trying to reproduce it anyway, I'm sure I'll hit this issue at some point

Let's hope that's the case! Nevertheless I'll leave this open for some more time.


Use major.minor (schema version) to identify snapshot compatibility

just major is not enough anymore since 13.1.
backport of https://github.com/input-output-hk/cardano-db-sync/pull/1354

bors r+


Questions on how it works-

Not actually an issue I was just curious about how this works and where the recording logic is in this project?

This is an issue tracker, not a support forum. You can easily find this out if you do some digging yourself.

This is an issue tracker, not a support forum. You can easily find this out if you do some digging yourself.


ec2: check subnet exists in vpc

Fixes #663
This also fixes the IP allocation eventual consistency.

This fixes my problem from #663 :+1:

@md5 PTAL

@md5 it should "fallback" safely.  It will only check for the default if there is more than one and will only set it if there is one marked.  Otherwise, it uses the first one it finds.

@md5 i'm not sure what you mean by log the err -- if an error occurs while waiting on the IP, it's returned.

It's possible to have more than one subnet with none marked as
defaultForAz, I believe.
Regarding my other concern, I misspoke. I meant the case where ip keeps
being "" and err is also nil.

Correct. In the case where one is marked as default it will use that one. Otherwise it will just use the one already set.
We need a retry and timeout function in the amz lib itself. I'll look into this for better retry and timeout support. Thanks!

Ah gotcha. Good point.

LGTM
I had missed the d.SubnetId = subnets[0].SubnetId in my first pass through the diff, so I see how it falls back now if there is no defaultForAz.


Add line to bottom of recyclerView: closes #228

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Evaporative cooling not working

Selecting evaporative cooling for the molten salt power tower results in negative annual energy.

Fixed with commit db93ac7 by calculating needed humidity values.

Forum conversation on this topic:
https://sam.nrel.gov/forum/forum-general/2770-mspt-cooling-system


[Feature Request] Webhooks message customization

I'd like Gitea has customized messages for Webhooks.
As for now, Gitea Webhooks messages are hardcoded and there is no way for customization.
I think that following things make Gitea Webhooks functionality much better:

on webhooks page (maybe even better in config file) add Custom message field where user is able to set own message for specific action
user should be allowed to have/use predefined "variables", like %repo% for link to org/repository with the name,%issue.title% - issue's title if the action type in scope of issue and so on.

And as result, I'd like to be able to set (e.g. for pull request) message like: %user% has submitted pull-request to %repo%.

This would be covered by #1089


gradle: 7.6 -> 7.6.1

Description of changes
Fixes CVE-2023-26053.
https://docs.gradle.org/7.6.1/release-notes.html

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

tl;dr: Stop using short ids for gpg keys. Nothing new.


desktop manager script: start properly

Adds a missing line feed when X is enabled to the start script name
and the appended if check. Resolves #160735

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

LGTM, thanks for fixing this!


Need to check existence of PCAP file in SetReceiverFile function

Also atomic increment should be removed from read function


How to remove/uninstall?

First, thanks for the time and effort it took to put this together.  I figure I may need it at some point (even though i dont at this instant)
I installed it just as a dry/test run and facepalmed since I didnt make a snapshot prior which would have saved me harassing you.
How does one uninstall/remove the pane?

yea, that was easy.  probably should have tried the easy thing before asking!

Need to add an "Uninstall" section to readme 😄

i mean... will save you the odd rare occurrence of a post like this,  but in all honesty i should have right clicked before posting.
but hey if it helped you flesh out/be more through with the information on the page.  Small win.  I'll take it lol.

@klepp0906, it's yours 🤪

Uninstall section added


Allow trusted administrative services to provision pods

CSS should allow trusted "administrative" services to provision pods in automated fashion. This was previously possible before the HTTP interface at /pods was removed in https://github.com/solid/community-server/pull/749.
This capability is valuable if secured properly. A simple approach would be to have an allowed list of trusted administrative WebIDs (e.g. as part of the server configuration), and let CSS check the WebID claim in the provided token of a provisioning request to see if it matches one of them. If there is a match, allow that trusted admin service to make a pod for a provided WebID. Further restrictions on the WebIDs it is permitted to provision pods for could be included in the configuration (e.g. only those associated with a given domain).

I actually don't even remember why I added a token check when provisioning pods. The only time this is really necessary is when registering with the IDP for security reasons, but there is not really a security risk to provisioning a pod for a specific WebID. Maybe that was added to make sure users didn't accidentally create a pod for a wrong WebID. We could just remove that check in case no registration with the IDP is needed.
FYI, in the versions/2.0.0 branch you can now use content negotation to have the /idp/register response be a JSON object with all the relevant fields, which would make API usage easier. We also want to have it accept JSON object soon-ish.

FYI, in the versions/2.0.0 branch you can now use content negotation to have the /idp/register response be a JSON object with all the relevant fields, which would make API usage easier. We also want to have it accept JSON object soon-ish.

👏  Agree that is much cleaner! Big +1 on that direction 👍

We could just remove that check in case no registration with the IDP is needed.

I think there's still a lot of value in maintaining configurable checks that let CSS determine whether a given agent can create a pod or an identity (for themselves or other webids). For example, at the moment I'm achieving my use case by using the NoCheckOwnershipValidator. This allows my trusted administrative agent to make pods, but it also means any other agent can do the same. In a lot of use cases this may be fine, but I'd still want to have a check that allows only permitted agents to do provisioning (for themselves or others), so that a malicious or poorly made agent can't write a script that creates an endless amount of pods until the server runs out of memory or storage.

Yea that makes sense. We could have an AuthorizedOwnershipValidator ("OwnershipValidator" might not be the best name anymore at that point). One question will be how to configure it. We could just hardcode some WebIDs in the config, but it would be nice to have a dynamic solution there. Perhaps a restricted RDF document containing valid WebIDs.

We should then also update the RegistrationHandler to use two different handlers, one for registration (for which we want an actual OwnershipValidator), and one for pod creation (which can be a new type).

We should then also update the RegistrationHandler to use two different handlers, one for registration (for which we want an actual OwnershipValidator), and one for pod creation (which can be a new type).

Agree - for pod provisioning I think its less about Ownership and more about capability to create (which could be due to ownership, but also to some other trust relationship.

One question will be how to configure it. We could just hardcode some WebIDs in the config, but it would be nice to have a dynamic solution there. Perhaps a restricted RDF document containing valid WebIDs.

Yep good question. My use cases don't require more than server-level hard-coding, but I certainly wouldn't complain about additional flexibility 🙂

One question will be how to configure it. We could just hardcode some WebIDs in the config, but it would be nice to have a dynamic solution there. Perhaps a restricted RDF document containing valid WebIDs.

Could we reuse WebACL?

Could we reuse WebACL?

I was also thinking of having something like /idp/registration.acl. Main issue is that since the pathing is completely different in the IDP part compared to the main LDP part we would have to figure out how to do that nicely there.
On the other hand, having a fixed list of supported WebIDs is also non-trivial since we would have to extract credentials in the IDP component and somehow get those credentials to the registration handler.

I was also thinking of having something like /idp/registration.acl. Main issue is that since the pathing is completely different in the IDP part compared to the main LDP part we would have to figure out how to do that nicely there.

Let's do that!

So happy to see this move its way through and get resolved so quickly @joachimvh @RubenVerborgh!!! Great work 🚀


Adding a Legend

Hello, I am trying to add a legend, I though about using the overlay view but I want something more like the example on here: https://developers.google.com/maps/documentation/javascript/adding-a-legend
Looks like that involves pushing to the current instance of map inmap.controls? So is there any way to do this? Thanks

Please refer to Getting Help section in the README (or #469).

Hey @jm90m, did you find a solution for adding a legend to the map? Would love to know if you did. Cheers.

@aldorl nope, I just made my legend through a custom react component outside this library.

@aldorl How you did that. Did you use overlay, or not?

@anubhav0fnu I never figured out how to do it, so I just added the legend outside of the map

Hi. i solve this based on https://developers.google.com/maps/documentation/javascript/adding-a-legend.

In onGoogleReady:

And it works great! The google prop we get from props is not the same as google, we should use google which is received from the second onReady parameter. Hope it helps y'all

Hi. i solve this based on https://developers.google.com/maps/documentation/javascript/adding-a-legend.  In onGoogleReady:  And it works great! The google prop we get from props is not the same as google, we should use google which is received from the second onReady parameter. Hope it helps y'all

Can you please share your code and the Legend component?


Bundle PDF for testing

Everytime I do  a 'git pull' and make server. The pdf.js tries to download the pdf documents. Why not just bundle few dummy pdf documents for testing.

Why not just bundle few dummy pdf documents for testing.

@arky, there are lots of PDF generators/editors. Some of them provide "compliant" output, some of them not. It's impossible to replicate the same output in all of the cases. One of the goals of the pdf.js is to render most of the documents on the web.
You as welcome to provide unique documents (that are not infringing copyright law) for testing, the pdf.js team will be glad to accept them :)

Evince: The default pdf viewer on gnome uses Red Hat Installation Guide (http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/6/pdf/Installation_Guide/Red_Hat_Enterprise_Linux-6-Installation_Guide-en-US.pdf)
The test case is here:
http://fedoraproject.org/wiki/QA:Testcase_evince_file_display

Wow, a though document to render :)
I get blank pages and crazy CPU usage after scrolling and viewing about the first 21 pages.
If I however closes the document and opens it again (at page 22) it renders just fine?
This is with the latest master branch (ergo with notmasteryet's concurrent loading stuff).
No error messages either?

A lot of the pdfs we use for regression tests have copyright issues, so we can't bundle them. We understand it is a nuisance for contributors, but we haven't been able come up with a more robust solution yet.

I can't finish make test because the PDF from http://www.sanface.com/pdf/test.pdf times out. Bundling (or hosting somewhere reliable) would help out here... but that doesn't get around copyright issues. :(


Creating a ref when overriding a component

When overriding a component, is there a way to generate a ref?
Context: I have generated a TOC from the h2s in my markdown file. Now I would like to create a feature that scrolls to the corresponding heading in the document when the TOC is clicked. I read ref is the way to go, so now I am trying to add refs to all h2s.
I have tried the below, but ref is not included int he resulting HTML? ("test" is, so I know the rest is working fine)
<Markdown
    children={md}
    options={{
        forceBlock: true,
        overrides: {
            h2: {
                component: Heading,
            }
        },
    }}
/>

export class Heading extends Component {
    render() {
        return (
            <h2
                id={this.props.id}
                ref={this.props.id}
                test="test"
            >
                {this.props.children}
            </h2>
        );
    };
}

Any updates on this?


rouny extra vision creates pvs popin

Description
no pvs popin without it
turn it on and run around (even without pheramones), pvs popin

seems ok now mustve just been lag


Add example to pass current decision to the google tag manager to the docs.

After some experiments i found this solution to pass the current decisions to the google tag manger where it is used to define the dimensions for GoogleAnalytics. This or a better pattern should/could be in the readme as way for evaluating the tests.
prototype(Vendor.Site:Integration.GoogleTagManager.DataLayer) < prototype(Neos.Fusion:Component) {

    data = Neos.Fusion:DataStructure {
    	ab_features = ${ Wysiwyg.ABTesting.Decisions.getAllDecisions() }
    }

    renderer = afx`
        <script @if.hasValue={props.data}>
            dataLayer = [{Json.stringify(props.data)}];
        </script>
    `

    @cache {
        mode = 'uncached'
        context {
            1 = 'site'
        }
    }
}

Hi Martin,
You are right, we didnt mentioned it right now - we  also have a script to read out the cookies via javascript.
Thank you for your example and integration-pattern this is an aspect we should add soonish

If you have a solution that reads the cookies in the tag manager that is probably better than my example.

If you have a solution that reads the cookies in the tag manager that is probably better than my example.

https://github.com/wysiwyg-software-design/Wysiwyg.ABTesting/blob/master/Resources/Public/JavaScript/AbTesting.js
We have to document this JS-Class..

Please note that we have to optimize this as the CookieName is currently hardcoded.

New path for the JS file:
https://github.com/wysiwyg-software-design/Wysiwyg.ABTesting/blob/master/Resources/Private/Script/AbTesting.js


[CT-2241] [CT-2240] [Bug] Docs don't allow selecting via a meta config

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
I'm trying to select models/sources/seeds upstream of high priority models (ideally exposures, but I can't even get it to list with exposures).  I can select via
dbt ls --select config.meta.priority:p0 --exclude test_type:generic

but it doesn't show up if I try to select with config.meta.priority:p0 in the documentation.
Expected Behavior
I want to be able to select via the meta.priority.  I'd love to help with this.
Steps To Reproduce
With this schema file
version: 2

models:
  - name: my_first_dbt_model
    description: "A starter dbt model"
    config:
      meta:
        priority: p0

run
dbt docs generate; dbt docs serve;

put config.meta.priority:p0 in the select box
it doesn't select anything
my_first_dbt_model is just
{{ config(materialized='table') }}

with source_data as (

    select 1 as id
    union all
    select null as id

)

select *
from source_data

Relevant log output
No response
Environment
- OS: windows 10
- Python: 3.9.12
- dbt-core: 1.3.2
- dbt-databricks: 1.3.2

Which database adapter are you using with dbt?
other (mention it in "Additional Context")
Additional Context
dbt-databricks: 1.3.2
Also tried it in dbt-athena-community==1.3.4

Thanks for opening this issue @VDFaller !
https://github.com/dbt-labs/dbt-docs/issues/305#issuecomment-1318722416 has a good explanation of the difference you are seeing.
If a motivated community member wants to implement the "short-term fix" described there, we'd be willing to review the PR!
In the meantime, I'm going to close as a duplicate of https://github.com/dbt-labs/dbt-docs/issues/305.

Crap sorry for dupe.  I'll see if I can look at it.

No prob @VDFaller


fix(Browser history): fixed NPE when navigating a study via browser history and history navigation is now available via the navigateHistory command

Context
The community reported that navigating to a different study was not working for window.history.pushState. Furthermore it was confirmed that both window.history.pushState and the npm 'history' API do NOT trigger the react-router-dom - the react-router-dom is what OHIF uses to react to history changes.
As a result, it was decided to expose the browser history navigation via a command.

Changes & Results

fixed an NPE when navigating to a different study via the URL/browser history
exposed browser history navigation via a command
now a study can be navigated to via the navigateHistory command

Testing

Add a button or hot key binding that will navigate to a different study. Something say like this (for a hot key binding)...

  {
    commandName: 'navigateHistory',
    commandOptions: {
      to:
        '/viewer?StudyInstanceUIDs=<IP_ADDRESS>.4.1.25403.345050719074.3824.20170125095722.1',
    },
    context: 'DEFAULT',
    label: 'nav study',
    keys: ['g'],
    isEditable: true,
  },

Launch OHIF to a study that is NOT specified in the button or key binding made in step 1.
Click the button or key that should change the browser history and study.

Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] OS: Windows 11
[x] Node version: 16.14.0
[x] Browser: Chrome 112.0.5615.138

As a sidenote, when doing it like this on current viewer it works fine using pushState, but one needs to manually dispatch the PopStateEvent too:
window.history.pushState({}, undefined, 'https://xyz.de/viewer?StudyInstanceUIDs=abc');
window.dispatchEvent(new PopStateEvent('popstate'));


fix several missing dependencies on the helper module

Fixes several missing dependencies on helper module
Fixes #1812
#1793 added the is-darwin, is-linux, is-bsd, is-cygwin functions to the helper module and referenced them in a few modules. However, these modules don't appear to declare a dependency on the helper module, so you may end up getting a 'command not found error' at module load for one of the above functions.
/home/char8/.zprezto/modules/python/init.zsh:25: command not found: is-darwin

I tried to work out if helper wasn't being loaded because I was missing a specific module load order. But looking at the git and utility  modules it appears that it needs to be specified as a dependency by the module?
I've only tested this fix to work when loading the python and homebrew modules.
Proposed Changes

add pmodload 'helper' declarations to modules that were missing them

Good catch! Thanks for doing this!


Log custom format placeholder "%tf-command-args" documented but not available

I am loving the new log formatting for run-all commands since recently upgrading. I tried customizing the log format using --terragrunt-log-custom-format and I noticed %tf-command-args is a documented placeholder but not available to use.
$ terragrunt --version
terragrunt version v0.69.13
$ terragrunt run-all init --terragrunt-log-custom-format "%time() %tf-command-args() %msg"
11:16:56.600 <tab>f-command-args() Initializing the backend...
...

Looks like the log formatter is just processing %t off the front of %tf-command-args. But %tf-path is working as expected, and it begins with %t. So I tried specifying %wrong to do a little more debugging:
$ terragrunt run-all init --terragrunt-log-custom-format "%wrong"

ERROR flag --terragrunt-log-custom-format, invalid placeholder name "wrong", available values: interval,time,level,msg,prefix,tf-path
Looks like %tf-command-args is not an accepted log format placeholder.
Unfortunately I dont know enough go to fix the issue, but I do see `tf-command-args is at least attempted to be registered here: https://github.com/gruntwork-io/terragrunt/blob/485ee371710c9da4b606a606f88147acae48c758/pkg/log/format/placeholders/field.go#L11
But here it doesnt see tf-command-args as registered in the rendered error message: https://github.com/gruntwork-io/terragrunt/blob/485ee371710c9da4b606a606f88147acae48c758/pkg/log/format/placeholders/placeholder.go#L208

Fix released in v0.70.2.


placement: add stringer for RuleOp

What problem does this PR solve?

If an operand implements method String() string, that method will be invoked to convert the object to a string, which will then be formatted as required by the verb (if any).

Due to this behavior, the line 388 in rule_manager.go:
 log.Info("placement rules updated", zap.String("batch", fmt.Sprint(todo)))

did not print all fields in RuleOp. This PR adds an explicit stringer interface for RuleOp to display all infomation.
Check List
Tests

Unit test
Integration test

Release note

No release note

Can you give an example after this PR?

@rleungx  after
[2020/08/13 17:10:45.326 +08:00] [INFO] [rule_manager.go:388] ["placement rules updated"] [batch="[{\"group_id\":\"pd\",\"id\":\"default\",\"start_key\":\"\",\"end_key\":\"\",\"role\":\"voter\",\"count\":3,\"action\":\"add\",\"delete_by_id_prefix\":false}]"]

before will look like:
[2020/08/13 17:10:45.326 +08:00] [INFO] [rule_manager.go:388] ["placement rules updated"] [batch="[{\"group_id\":\"pd\",\"id\":\"default\",\"start_key\":\"\",\"end_key\":\"\",\"role\":\"voter\",\"count\":3}]"]

/merge


_ Patch Compile Tests _

-1 :x:
mvninstall
2m 28s
root in the patch failed.

-1 :x:
compile
0m 15s
hbase-rest in the patch failed.

-0 :warning:
javac
0m 15s
hbase-rest in the patch failed.

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 12s
hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
0m 15s
hbase-rest in the patch failed.

13m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5974

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0d977b4daca2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f136f0ace8

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-rest.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-rest.txt

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-rest.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/testReport/

Max. process+thread count
67 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5974/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
compile
0m 39s
master passed

+1 :green_heart:
checkstyle
0m 15s
master passed

+1 :green_heart:
spotless
0m 56s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 35s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
3m 15s
root in the patch failed.

-1 :x:
compile
0m 24s
hbase-rest in the patch failed.

-0 :warning:
javac
0m 24s
hbase-rest in the patch failed.

-0 :warning:
checkstyle
0m  8s
hbase-rest: The patch generated 3 new + 23 unchanged - 0 fixed = 26 total (was 23)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
3m 45s
The patch causes 66 errors with Hadoop v3.3.6.

-1 :x:
spotless
0m 50s
patch has 59 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
0m 20s
hbase-rest in the patch failed.


WIP layers: Fix state tracking for vkFlushMappedMemoryRanges()

WIP
MarkL, please check this out. I don't think it's quite right yet, but I got a bug report related to this code and I think there are definitely some issues.
Checks for underflow and overflow when flushing mapped memory weren't properly handling
offset. Underflow check should go from the base of the shadow memory to the range offset.
The overflow check should go from the end of the mapped memory range to the end of the
shadow memory.
Finally, when copying the region, the start address of the copy should include offset.

Yeah, it looks OK.  Do you have a test case that I can try this with?  The issue that prompted the original changes was that the shadow-copy needed to follow the same restrictions as the device copy -- I'd like to double-check the loop that checks for overflow in the debugger, but if it's passing your repro case then it seems OK to me.

No test case, just complaints from a user of errors that he thought were invalid. Upon inspection I agree that there's something fishy so this was my attempt to fix it up.
With these changes I'm seeing some new errors on some android devices w/ LVL tests so if you don't see anything clearly wrong with my changes I'll dig into it a bit further.

@chrisforbes if you have some time take a look at this and let me know if you see any issues. Seeing new unexpected errors on one vendor with these changes that I'm investigating further but wanted to get insight from you if you're able.

From offline discussion: not convinced this is the right thing.

Tests?

@chrisforbes I added an additional case to NonCoherentMemoryMapping test to demonstrate that the previous bug with the flushed offset is no longer present. Force pushed update.


Split large blobs into chunks

Currently blobs are sent at once no matter the size. This is not ideal for massive files. We need to break massive content into chunks for transfer.

CreateBlob_DisconnectedDuringCreate test is disabled b/c of OOM


Removed code, redundant with line 428

Appears that this code is not needed.

Thanks for this! Can you sign the contributor agreement linked here please?

Alright, filled it out.

Thanks! 👍


[STM32F103] first I2C transaction always fails when PM_DEVICE_RUNTIME is enabled

Describe the bug
The first I2C transaction always fails when PM_DEVICE_RUNTIME is enabled on STM32F103.
I've stm32_min_dev_blue connected to the ssd1306 display.
To Reproduce
Steps to reproduce the behavior:

connect stm32_min_dev_blue to ssd1306;
enable CONFIG_PM=y, CONFIG_PM_DEVICE=y, CONFIG_PM_DEVICE_RUNTIME=y;
build and boot;

Expected behavior
ssd1306 should be initialized and ready to work.
Impact
Device driver error.
Logs and console output
D: stm32_i2c_msg_write: WRITE timeout
E: Failed to initialize device!
*** Booting Zephyr OS build zephyr-v3.3.0 ***
E: the device ssd1306@3c is not ready

Environment (please complete the following information):

OS: Linux, MacOS
Toolchain zephyr-sdk-0.15.2
v3.3.0 (07c6af3b8c35c1e49186578ca61a25c76e2fb308)

Additional context
I've workaround the issue by adding a retry:
diff --git a/drivers/i2c/i2c_ll_stm32_v1.c b/drivers/i2c/i2c_ll_stm32_v1.c
index 9a64fc7fcc..0edc61ff45 100644
--- a/drivers/i2c/i2c_ll_stm32_v1.c
+++ b/drivers/i2c/i2c_ll_stm32_v1.c
@@ -617,7 +617,9 @@ int32_t stm32_i2c_msg_write(const struct device *dev, struct i2c_msg *msg,
 			    uint8_t *next_msg_flags, uint16_t saddr)
 {
 	struct i2c_stm32_data *data = dev->data;
+	bool first_fail = false;

+retry:
 	msg_init(dev, msg, next_msg_flags, saddr, I2C_REQUEST_WRITE);

 	stm32_i2c_enable_transfer_interrupts(dev);
@@ -626,6 +628,12 @@ int32_t stm32_i2c_msg_write(const struct device *dev, struct i2c_msg *msg,
 			K_MSEC(STM32_I2C_TRANSFER_TIMEOUT_MSEC)) != 0) {
 		LOG_DBG("%s: WRITE timeout", __func__);
 		stm32_i2c_reset(dev);
+
+		if (!first_fail) {
+			first_fail = true;
+			goto retry;
+		}
+
 		return -EIO;
 	}

I've grabbed I2C pins by Logic Analyzer, it looks like a trash:

Simular issues,

https://github.com/zephyrproject-rtos/zephyr/issues/37414
https://github.com/zephyrproject-rtos/zephyr/issues/53834

@Oleh-Kravchenko Can you have a look to https://github.com/zephyrproject-rtos/zephyr/pull/59200 ?

This is likely due to idle thread device resume logic and application-called driver logic fighting for the bus mutex.
See https://github.com/zephyrproject-rtos/zephyr/pull/60939#issuecomment-1680796061

@Oleh-Kravchenko Can you have a look to #59200 ?

Could you please be more specific?
Look for what exactly?
P.S.
I'm fresher in the Zephyr Project, so I don't understand your request.

I believe that this could be related to this issue / PR: #62988. Is that possible @Oleh-Kravchenko ?

Issue is still present


Proper Name?

Somehow I managed to snag asset-builder in NPM, but is there a better name that better describes what this does?
It basically

reads a manifest file
reads third-party dependencies
places them all in the correct order
then gives you an object with a bunch of globs you can feed into gulp or whatever

Xylem? Or phloem? Keeping in the "roots" etc. theme, xylem carries water through a plant while phloem carries sugar. asset pipelines, water pipeline... I dunno, just a thought.


Error when creating dropdown

Hi dataarts, when i setup the dropdown, the following error comes: "labelInteraction.updateLabel is not a function" . In examples, the error occur too. This is my code:
gui.add(config, 'zoom',{ S: 100, M: 50, C: 0 } );
And the control, can't generate the dropdown. Thanks for your great work!

Will take a look thanks!


fix for double switching

I'd love to see this merged and published since it looks like it fixes #2. @ziscloud What can we do to get this moving?


fix: Fixed Hamburger

Title and Issue number

Title : Fixed Hamburger
Issue No. : #1093
Code Stack :
Close #1093

Description

The Hamburger now works in the Membership page
Video/Screenshots (mandatory)

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[x] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

[x] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

@sau-mili please kindly check the pr.

@itsekta @apu52 please kindly check this pr.

@itsekta @apu52 please kindly check this pr.


MSUnmerged T1 service crashing when pulling large storage json dump

Impact of the bug
MSUnmerged
Describe the bug
After bumping the resources limit to up to 8GB of memory RAM, ms-unmerged-t1 is still unable to load data into memory for T1_US_FNAL_Disk, which makes the service to crash every minute and repeat this in an endless mode.
In addition, several T1 storage forbid the WMCore robot certificate to delete unneeded data from the unmerged area. Identified RSEs so far are: CNAF and JINR.
How to reproduce it
Fetch the FNAL unmerged dump and load it into memory in python.
Expected behavior
Ideally, we should have a better control over the data that is loaded into memory, either streaming data or loading data in chunks.
We also have to follow up on those permission issues with the site admins.
Additional context and error message
We seem to be crashing this service at least since Mar 21st, 2024(!!!)
[21/Mar/2024:00:00:31]  WATCHDOG: server exited with exit code signal 9... restarting

Relevant tickets so far:
CNAF https://ggus.eu/index.php?mode=ticket_info&ticket_id=167706
PIC https://its.cern.ch/jira/browse/CMSDM-190

The main issue with big JSON is dictionary (nested) representation of the data. This leads any parser in any programming language to load it as one object into memory. Instead, the data should be represented as list of smaller objects. Here are two approaches to represent the same data:

Big JSON example

{
   "value1": {"abc": {...}},
   "value2": {"xyz": {...}}
}

The same data which allows low memory footprint (equal to the size of single record:

[
  {"key": "value1", ...},
  {"key": "value2", ...}
]

Here the memory footprint in parser can be equal to the size of one single record. Moreover, such data-representation allows data-streaming, e.g. usage of NDJSON data-format:
{"key": "value", ...}
{"key": "value", ...}

Observation I: quite often WM objects are represented (dumped from CouchDB) as nested dictionaries. There is no JSON schema, i.e. JSON is not defined with set of pre-defined keys, e.g. {"block#123": ...}, or {"T1_XXX": ...}. Instead, we should strive to define JSON schema with concrete keys, e.g. block, site, and then use it to define data-structure, e.g. {"block": "block1#xyz", "site": "T1_XXX"}.
Observation II: we often use CouchDB to store python dictionaries, and then look them up. Dictionaries  has no serialization, i.e. it should be loaded at once into the memory. Therefore, quite often the main problem is lack of data-representation schema. The CouchDB (or MongoDB) allows to store unstructured data but it doesn't mean that we should not cary about data-representation schema. We should put a layer (data-service) in front of any database which should consume and yield data in specific data format (JSON or NDJSON) and translate (if necessary) incoming/outgoing data in/to database. Instead, we often use database directly for data-storage and this leads to discussed problem when data size of stored objects increases and data is stored as dictionaries.

Valentin, I think we all are aware of these limitations and legacy/habit of storing nested dictionaries with non-static keys (which does not have only disadvantages btw).
Nonetheless, I see you have not even looked at the structure that is dealt with in MSUnmerged, which is actually responsible for this blow up of memory footprint. Just in case, we are talking about a flat list, e.g.:
[
 "/store/unmerged/GenericNoSmearGENBackfillBackfillBackfill/InclusiveDileptonMinBias_TuneCP5Plus_13p6TeV_pythia8/GEN/BACKFILL-v8/100145/7f41787f-105e-418c-aa93-9b99c8974dc1.root",
 "/store/unmerged/GenericNoSmearGENBackfillBackfillBackfill/InclusiveDileptonMinBias_TuneCP5Plus_13p6TeV_pythia8/GEN/BACKFILL-v8/100205/e6a94b98-9d31-4093-bc21-7162792d9933.root",

In addition, we do not control this data, as it comes from one of the Rucio services, as mentioned in the initial description.

If data is represented as flat list of strings, the amount of memory required to parse it is equal to the longest string in a list. If you do not control it, you can still write a parser to read it as one line at a time (instead of using JSON load(s)). This will reduce parser memory requirement to a single string size. That said, I doubt that long list requires 8GB ram size unless you deal with billions of such strings. Here is a basic proof:
python
>>> s1="/store/unmerged/GenericNoSmearGENBackfillBackfillBackfill/InclusiveDileptonMinBias_TuneCP5Plus_13p6TeV_pythia8/GEN/BACKFILL-v8/100145/7f41787f-105e-418c-aa93-9b99c8974dc1.root"
>>> import sys
>>> sys.getsizeof(s1)
224
>>> arr=[s1 for _ in range(10000)]
>>> sys.getsizeof(arr)
85176
>>> arr=[s1 for _ in range(1000000)]
>>> sys.getsizeof(arr)
8448728

So, in other words, single filename costs 224 bytes, the array of such strings has size of 85KB for 10K entries, and array of 1M entries will cost 8MB. But it is still 3 orders of magnitude lower then 8GB.

I just managed to resume working on this item and I tried to delete the following 2 directories:
    rseDirs = ["davs://***/dcache/uscmsdisk/store/unmerged/RunIISummer20UL17wmLHEGEN/TTHTo2B_TTToHadronic_M-125_TuneCP5_13TeV-powheg-pythia8/LHE/106X_mc2017_realistic_v6-v1",
               "davs://***/dcache/uscmsdisk/store/unmerged/Run3Summer22MiniAODv4/GluGluToContinto2Zto2E2Tau_TuneCP5_13p6TeV_mcfm701-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_v5-v2"]

from FNAL_Disk with the gfal2 plugin command ctx.rmdir(dirPfn).
Initially, this is the error I was getting inside the ms-unmer-t1 pod:
Error deleting: davs://***/dcache/uscmsdisk/store/unmerged/Run3Summer22MiniAODv4/GluGluToContinto2Zto2E2Tau_TuneCP5_13p6TeV_mcfm701-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_v5-v2, gfal code=112, gfal message: Result (Neon): Server certificate verification failed: issuer is not trusted after 1 attempts

It turns out the CAs are pretty old/stale in this POD. After copying them from lxplus inside the ms-unmer-t1 pod, the same command succeeded without any issues.
I will follow this up with Aroosha and see if we can start mounting /etc/grid-security/certificates into the backend pods (or at least the WM ones).

For my own record, the current snapshot from Rucio Consistency Enforcement from
https://cmsweb-prod.cern.ch/rucioconmon/unmerged/index says:
| RSE           | History | Last run | Elapsed time | Status | Files | Size |
| T1_US_FNAL_Disk |   | 2024/09/30 | 20m1s | done | 11670914 | 1.6P |

I decided to bump the resource requirements for the production ms-unmer-t1 from 2 to 7GB limit (according to Grafana, it peaked at 6.3GB then it stabilizes in 700MB), plus:

patched the production pod: ms-unmer-t1-56c5b575bf-jq74c with https://github.com/dmwm/WMCore/pull/12059
fixed the grid-security CAs with a copy from lxplus;
manually patched the manage script to https://github.com/dmwm/CMSKubernetes/pull/1532;
and enabled only FNAL in the configuration file with RSEEXPR = "(rse=T1_US_FNAL_Disk)"

The first ~100 deletions failed because I still did not have up-to-date CAs in the node, but after fixing those I see that directory deletion is successfully going through, example:
2024-10-01 01:48:49,970:INFO:MSUnmerged: Processing directory index 287 out of 13105
2024-10-01 01:48:49,970:INFO:MSUnmerged: Trying to remove the whole directory: davs://***/dcache/uscmsdisk/store/unmerged/Run3Summer22EEMiniAODv4/Zto2Nu-2Jets_PTNuNu-40to100_1J_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v1
2024-10-01 01:48:59,962:INFO:MSUnmerged: Directory successfully removed: davs://***/dcache/uscmsdisk/store/unmerged/Run3Summer22EEMiniAODv4/Zto2Nu-2Jets_PTNuNu-40to100_1J_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v1
2024-10-01 01:48:59,963:INFO:MSUnmerged: Processing directory index 288 out of 13105
2024-10-01 01:48:59,963:INFO:MSUnmerged: Trying to remove the whole directory: davs://***/dcache/uscmsdisk/store/unmerged/RunIISummer20UL16NanoAODAPVv9/VBF_LFV_HToETau_M125_TuneCH3_13TeV_powheg_herwig7/NANOAODSIM/106X_mcRun2_asymptotic_preVFP_v11-v3
2024-10-01 01:49:00,559:INFO:MSUnmerged: Directory successfully removed: davs://***/dcache/uscmsdisk/store/unmerged/RunIISummer20UL16NanoAODAPVv9/VBF_LFV_HToETau_M125_TuneCH3_13TeV_powheg_herwig7/NANOAODSIM/106X_mcRun2_asymptotic_preVFP_v11-v3


Add support for gistifying and sending off to jsonblob

Steps for this to work:

Add JsonBlob mixin to your shim

Create an instance of your shim s = Shimmy::Shims::JscImageCollection.new

Call update_blob on your shim

$ s.update_blog
=> "https://jsonblob.com/api/jsonBlob/560d3e36e4b01190df3a3ad7"

:rocket:


Compiling to Go?

I saw a comment in a ticket from a few years ago here:

https://github.com/glycerine/zygomys/issues/13#issuecomment-227044059

In particular, you say "This supports the eventual aim of enabling trivial compile-down to actual Go code" ... was progress ever made on that?
I would love to be able to write Lisp, have it compiled to Go, with all the speed benefits ;-)

As would I. Unfortunately I quickly realized that was impractical. Lisp is too weakly typed, in contrast to Go's strong typing.
However there is a partial solution for critical parts, if you "hand compile", so to speak.  So when invoked, your compiled components run at native Go speed.
https://github.com/glycerine/zygomys/blob/master/tests/event.zy  shows this (as does the main Snoopy and friends example https://github.com/glycerine/zygomys/blob/master/zygo/demo_go_structs.go).
Search for the central (togo) function and SexpToGoStructs inside the interpreter.
If you really need a full fledged lisp with JIT compiler, in a separate project, I made chez scheme bindings that let you invoke chez scheme from Go.  Chez is way more built out that zygo, but the integration with Go is very light.  At its best Chez is maybe 3x slower than compiled Go, in my quick and dirty benchmarks.  That may well be good enough for some things.
https://github.com/go-interpreter/chezgo

I'll leave this open as a question.

How does ferret-lang.org manage to compile to C++?

How did Stalin? Bigloo? Gambit?
Only with alot of work.


Improve flex list item padding

Replace #26761
It's better to keep children elements simple, and let parent containers layout the necessary padding/margin.
The old not(:last-child) and .flex-item + .flex-item are not easy to maintain (for example, what if the developer would like to use a "tiny height" item?)
The old approach also makes some UI look strange because the first item doesn't have proper padding-top.
In this PR, we just simply use .flex-item { padding: ... }:

Developers could manually set the item height they want easily
It's easier to make it work with various containers -- with padding (ui segment) and without padding (div)

And added more samples/examples.

Of course you manage again to fix my code faster than I'm able to take a look at it 😆 I'm unsure if this change will affect some existing flex-list layouts, and I will only be able to take a look tomorrow unfortunately.


add catchall/escaping to conventional routes

Maybe something like:

Escaping: routes/[foo.bar].tsx so the url will literally be "/foo.bar" instead of "foo/bar".

Catchall: routes/foo/$.tsx the same as react router path="foo/*"

Escaping & splat routes are now implemented.


Update Readme

It's pretty good but we should have more description + CI badges at the top.

Closing as we're not tracking this here.


Electron-142 (Prevents multiple instances of about window)

Fixes the issue where it prevents creating multiple instances of the about window.
@VikasShashidhar , @VishwasShashidhar & @lneir Please review. Thanks

LGTM 👍


Sweden Aidon 6534

Hi
I have a Aidon 6534 that I would like to get working.
It´s getting data from a ESPHome with streamserver, per documentation.
On the ESP i have another reader for the AMS, i that way I can see it´s not updated in the same intervall.
(https://www.hjemmeautomasjon.no/forums/topic/5141-han-til-home-assistant-over-esphome/)
Version of the custom_component
Latest version of component - 2022.10.2
Configuration
{
  "home_assistant": {
    "installation_type": "Home Assistant OS",
    "version": "2023.2.5",
    "dev": false,
    "hassio": true,
    "virtualenv": false,
    "python_version": "3.10.7",
    "docker": true,
    "arch": "aarch64",
    "timezone": "Europe/Stockholm",
    "os_name": "Linux",
    "os_version": "5.15.84-v8",
    "supervisor": "2023.01.1",
    "host_os": "Home Assistant OS 9.5",
    "docker_version": "20.10.22",
    "chassis": "embedded",
    "run_as_root": true
  },
  "custom_components": {
    "hacs": {
      "version": "1.30.1",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "amshan": {
      "version": "2022.10.2",
      "requirements": [
        "amshan[serial]==2.0.5"
      ]
    },
  },
  "integration_manifest": {
    "domain": "amshan",
    "name": "AMS HAN meter",
    "version": "2022.10.2",
    "config_flow": true,
    "documentation": "https://github.com/toreamun/amshan-homeassistant",
    "issue_tracker": "https://github.com/toreamun/amshan-homeassistant/issues",
    "codeowners": [
      "@toreamun"
    ],
    "requirements": [
      "amshan[serial]==2.0.5"
    ],
    "after_dependencies": [
      "mqtt"
    ],
    "iot_class": "local_push",
    "is_built_in": false
  },
  "data": {
    "config_entry": {
      "entry_id": "089ae0560814395e6088d33a52f5fe93",
      "version": 3,
      "domain": "amshan",
      "title": "Aidon  (network)",
      "data": {
        "connection_type": "network_tcpip",
        "connection": {
          "host": "<IP_ADDRESS>",
          "port": 6638
        }
      },
      "options": {},
      "pref_disable_new_entities": false,
      "pref_disable_polling": false,
      "source": "user",
      "unique_id": null,
      "disabled_by": null
    }
  }
}

Describe the bug
Issue is that data is getting to HA, but sensor in HA seams not be updated in the same interval as on the ESPHome AMS sensor.
In the log there are gaps, see below.
I guess you whant to see the raw data, is it possibel to view this via Home Assistant? Have only remote access to the installation, at the moment.
I guess the issue can be both from the ESP device to HA and in HA.

I also have an Aidon 6534 with the Aidon 6442 s HAN interface and my setup is working, using a standard FDTI USB-to-serial cable connected to my NAS that is hosting my Home Assistant server.

Hi!
I have an ESPHome that runs a serial to tcp forwarder, guess that is causing the issue. And from ESPHome version 2023.07 it did completely stop.
I guess I have to do a different set-up with serial cable to solve this.
Thanks, closing this case.