SCRUM-1711 API work for Disease Annotation creation

@markquintontulloch did this PR mess up the IT's?

yep - Unrecognized field "subjectCurie" (class org.alliancegenome.curation_api.model.entities.GeneDiseaseAnnotation), not marked as ignorable


Update Ember Model for Ember 3.0

Upgrade and release 2.18:

[x] upgrade to Ember 2.18
[x] verify on Intercom app
[x] release ember-model 2.18

[x] write release notes which point out breaking changes
[x] push to npm (we might need to get access to do this)

Upgrade and release 3.0:

[x] replace bower with npm /cc @patocallaghan
[x] Upgrade and fix any failing tests
[x] try out build on intercom app
[x] release ember-model 3.0

We'll need to find another way of accessing the CP meta:
https://github.com/ebryn/ember-model/blob/868550cc4c61c2364041ac4652555bb539ece1a9/packages/ember-model/lib/model.js#L135

https://github.com/ebryn/ember-model/releases/tag/3.0.0


Feat/1116 support iframe to render html

Description

Valgdirektoratet wants to show the election card as HTML in an iframe rather than today's solution where the raw HTML is fetched and embedded into the app. Valgdirektoratet wants to have full control over the HTML and the CSS, hence we have now created support to render this HTML within an iframe.
Related Issue(s)

closes #1116

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[x] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[x] I have tested with a screen reader/keyboard navigation/automated wcag validator
[ ] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[ ] No functionality has been changed/added, so no documentation is needed
[x] I will do that later/have created an issue

Changes/additions to component properties

[x] Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
[ ] No changes made

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[ ] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

I'm currently working on the documentation, but moved this PR to review meanwhile I'm writing the docs for it. :)


Allow percentage values for defaultValue

Simply allowing floats like 0.5 for 50% wouldn't work with the value 1.0 (100%) which is ambiguous to dmx value 1. Therefore, we could allow strings matching this pattern: ^([1-9][0-9]?|100|0)%$ ("0%", "1%", "99%", 100%")
For exporting, the percentage value should be multiplied with the max dmx value (255 in normal channels, 256^n - 1 with fine channels, see #122).

Could be handled by #149, as the model could translate back the percentage value into a DMX value.

@FloEdelmann that's a great idea! However, one difficulty is the default value for fine channels. "50%" could mean 127 in a mode containing only "Pan" and 32767 in a mode containing "Pan" and "Pan fine". Calling fix1.getChannelByKey("Pan").defaultValue doesn't give the model any information if this channel is used in a mode where its fine channel is used as well or not. Therefore, I'd return an array containing the default value for each fine grade:
get defaultValues() {
  // defaultValue === "50%"
  return [127, 32767, 8388607]
}

Then the plugin can decide which fine grade it uses (e.g., QLC+ would always use the first value, e:cue would check if fine aliases of this channel are used in the same mode and then use this value)


Ability to change the name of the object lists

Perhaps a feature that allows us to change the name of the object lists. We can keep the [0], [1], [2] for identification purpsoses. But having the ability to change the name would be amazing.

Good idea.
I could give the possibility to set a display name of each item based on the values of the children fields WDYT
Let's say you have an ObjectList "Attendees"
With children: "Name", "Position", "Company"
so in the ObjectList setting you would put:
Display label: {{Name}} - {{Company}}
And therefore the [0], [1], ... would be replaced with [John - ACME] , [Anne - NewCo], ....
WDYT

Yea this is perfect. Could there also be on option to only limit the name to just one of the children fields as well?

Will be released in 0.8.0


Added Necati ergin C ders notlari

Added Necati ergin C ders notlari
What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

TIP :writing_hand:: It's a good practice to fill Pull Request fields, even check taskslist items. It helps a bit we can understand your contribution better :hugs:. and then, increase maintainers productivity :rocket:

For academia.edu and researchgate.com, we can accept links only when the work is being shared by an author. So not for this one, unless I misunderstand. As these will become more common, we should probably add something in CONTRIBUTING. Also, for these site we would need to add an "account required" notation.


xADDomainTrust: Integration tests is missing for this resource

We should add integration tests for this resource.

I'm currently finishing up refactoring this resource and completing unit tests, I will look into adding integration tests when I'm at it as I already have a lab setup with two forests.


chore: automated PR to update VHDVersion for 123456.11.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 123456.11.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.409%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
2620

Relevant Lines:
3669

💛  - Coveralls


Chocolate Distribution Problem - Python

Is your feature request related to a problem? Please describe.

Python Solution for Chocolate Distribution Problem
Link to the question : https://practice.geeksforgeeks.org/problems/chocolate-distribution-problem3825/1

Describe the solution you'd like

Consider an array A , M students and N be the size of array

Sort the array

Maximum and minimum are the last and first elements of the array

Store the difference of max and min in min_diff

Iterate through the array

Since the difference has to be minimum , Find the minimum between min_diff and difference between A[i + M -1 ] and A[i]
and store it in min_diff

Return min_diff

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Please assign me this issue

Sure @dsrao711 , you can go ahead !


Work in progress: Multiclass possible now

Do we want to merge to main? @kbiniek

I havent finished replacing the visualizer yet so maybe id first clean up a little before merging @mlederbauer


[PLAT-8044] Network breadcrumbs for dart:io HttpClient

Goal
Capture network breadcrumbs when using dart:io
Design
Implements a wrapper around the HttpClient class.
Changeset
Adds a bugsnag_breadcrumbs_dart_io package that implements BugsnagHttpClient, which apps should as a replacement for dart:io's HttpClient.
Renames bugsnag_flutter_http to bugsnag_breadcrumbs_http .
Testing

Changelog entry?


vimPlugins.vim-sensible: patch vimrc detection

The vimrc detection won't work if you are using the vim_configurable package (which the nixos and home-manager module both do)
because vim-sensbile only checks for files in the users home matches ~/... but in our case it gets called from a wrapper script which looks something like: vim -u /nix/store/.../vimrc.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X} Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

I can try upstreamimg it but it will probably be rejected since it's a nix specific patch


For clarity, the Tests project should not be a 'web' project

Rather oddly, when opening the solution in Visual Studio 2017, the tests project displays as a form of web application project-type.  See the attached screenshot.  It should be displayed as a test project though, so something is probably wrong either with the .sln file or the .csproj file.

I can't reproduce this on MojoDevelop.  I can check again when I next get to a Windows machine.  It's not important though.  The tests work just fine.


How to size the div?

I am embedding a google map, but using the iframemanager the resulting maps is very small. I tried to set the width and height manually in the div, but it does not change size?

You can specify the data-autoscale attribute or use CSS.


Show correct revert reason data in priv_call

PR description
priv_call was showing incorrect error -"invalid params" even when execution is reverted. PR fixes to show correct error - "REVERT_ERROR" and show correct revert reason data
Fixed Issue(s)
https://github.com/hyperledger/besu/issues/5223

@macfarla Hey Sally, can you please review this?

the CI failures are network related so should be fixed on re-run

looks good to me. @NickSneo can you add a changelog entry for this please

Sure adding changelog entry for this

Let's get this 🚢 for 23.4.0 ! @macfarla


”Dalboșeț”, ”Bârz”, ”Boina” are listed in the drop-down menu

Description:
When user writes ”Dalboșeț”, ”Bârz”, ”Boina” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Dalboșeț"

Expected results
The location appears in the drop-down menu as "Dalboșeț, Caraș-Severin(Dalboșeț)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Bârz"

Expected results
The location appears in the drop-down menu as "Bârz, Caraș-Severin(Dalboșeț)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Boina"

Expected results
The location appears in the drop-down menu as "Boina, Caraș-Severin(Dalboșeț)".


Fix CKAN Adapter data pulling

CKANRestClient.get_datasets() method: some sites  doesn’t have query parameter include_private on /api/action/package_search API endpoint, so we need logic to remove it in case of failure. Also we are getting not all datasets as of rows argument restriction. We are getting only 10, maximum is 1000, so custom pagination implementation is needed.
CKANRestClient.get_resource_fields() method: CKAN API endpoint /api/action/datastore_info is available only via extension. Assumption: in case site does not have the extension we were getting 400 Bad Request and adapter logic parsed it into str object, so is_response_successful() was crushing during resp.get("success") as response was type = str. Logic should be fixed.
Adapter config was built with an assumption that CKAN API would be available after the host name, hence there can be a custom endpoint in between. In this case we have no possibility to pull the data (www.open_website.com/api/action/package_search - handled, www.open_website.com/additional/endpoint/api/action/package_search - not handled). We need additional config parameter for giving a proper endpoint route to CKAN API.
Some resources pulled from CKAN can not have resource.name. So we need some logic for this cases. If it has resource.name - than data entity will have it as a name, if not we construct it like "CKAN_{organization_name}_{resource.id}" for minimal human-readability.
With big data pulling via adapter this error: #20  appeared.

closed with #21


[CARBONDATA-2807] Fixed data load performance issue in Intermediate merger When number of records are high

Problem: Data Loading is taking more time when number of records are high.
Root cause: As number of records are high intermediate merger is taking more time.
Solution: Checking the number of files present in file list is done is synchronized block because of this
each intermediate request is taking sometime and when number of records are high it impacting overall data loading performance
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@ravipesala Please review

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6348/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7630/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7645/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7652/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6072/

@kumarvishal09  Can you describe the solution in PR description?

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6387/

@jackylk Currently I am checking if I can manage this change using exiting intermediate merge property. I will update once testing is done

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7823/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6545/

LGTM


Implement themes

Theme selector:

Light
Dark
High contrast
.NET style
Classic Minesweeper

Maybe use css variables for theming?


Hardcode Event Emotes in the Emote Menu to "Twitch"

Describe your issue
In #2905 we moved emoteset data loading directly to Helix, because of this, the event emotes stored on qa_tw_partner now show up in a section for that channel, instead of under twitch.
We should hardcode this to "Twitch" as discussed in the original PR.
Comments from #2905

Seems to work 👍
Only issue is the qa_TW_Partner user that twitch seems to use for some of the global emotes, which causes them to show under that user instead of under Twitch in the emote popup.
Could maybe handle this by manually moving emotes from that emote set to the Twitch set until this is changed by twitch or another fix is possible.

Screenshots

Here's how it currently looks. I dislike the qa_TW_Partner

OS and Chatterino Version
all versions from 002129009df0743e1edb9b1e8c659f3b621a9e60 to 2af9284de54306145eee4042dcff6090a3b821ca
@zneix

Minor Update: In an accidental change, but also being a more logical place for the emotes, in cd7758a most of these emotes existing under qa_TW_Partner have been moved to the Global tab.
Emotes that remain in the sub tab are resolved by ivr requests.
If we still plan to hardcode these together, we would now have to move them to the Global tab.

done via #5239


[Colab] MSA Files generated via Online MPI HHBlit application stops execution due to #A3M# header

Hello,
When using the Google's Colab Notebook, I have noticed that when the MPI HHBlits online server is used to generate the MSA alignments, the exported .a3m file cannot directly be uploaded to the colab's MoLPC pipeline.
The files exported by MPI HHBlits feature the string #A3M# in line 1, which halts the execution of the Subcomponents Prediction step in the Folding Pipeline.
I only manage to run my queries manually editing the .a3m files performing two modifications:
1st. Opening the .a3m file and deleting the first line containing the #A3M#  string.
2nd In case the "FASTA" header of the MSA file exported from HHBlits is different from the the convention ID_1, ..., ID_N , replacing the FASTA header of the sequence in the .a3m file with the corresponding >ID_N .
This is not a serious issue but it may be confusing for new users of the Colab. It would be great if this clarifications could be incorpored to the Colab's documentation.
Best,
Jorge.

Hi,
I am not sure if this is due to a change in the online hhblits tool, but we have not observed such changes being necessary. Can you please post the header here and how to reproduce the MSA?
Best,
Patrick

Surely!
It happened to my only when using the files exported from the online MPI application. Checking the .a3m files I was uploading and comparing them with the one used in the example test, the only difference was the #A3M# string in the first line of the file.

Left file is the MSA downloaded from HHBlits (Downloaded from Query Template MSA > Download Full A3M), the right one is the same one without the #A3M# header. (Sorry for the Note Block app, not in my PC now).
After deleting this first line in all the MSA files and re-uploading them to the same Colab Session, everything worked smooth and the code ran perfectly.
I am attaching both packs of MSA files I used last time, I ran the Colab using ST 1 for each chain.  The protocol was exactly the one described in the Colab Notebook, just pasting the sequence as follows
>ID_N XXXXXXXXXXXXXXXXXXXXXXXXX...XXXXXXXXXXXXXXXXXXXX
HHBlits_raw_msa_export.zip
Working_MSAs.zip

This was due to an update in the output format of the HHblits webserver and is now fixed.


Added user-readable ADP description in the third add-application-wizard

@rosogon  could you test it?

Hi @adriannieto . It's better than the current screen, but I would change, in order of importance:

The title of each offering is: seaclouds.Nodes.Platform - (No cost estimation). I guess you wanted to show here the name of the provider.

The field "Services" show sc_req.<modulename>. What do you want to show here? I guess is the module name. The right name is in the node template; you are retrieving the name from the node type.

I would place the Services field before the Properties.

Collapsible properties

The idea is fine, and I think we can merge and improve this in a later PR.
What do you think?

@rosogon let me answer you point by point:

I cant show the provider in a pretty way, I already suggested @PaoloCifariello to change the type to a more specific one, like seaclouds.Nodes.Platform.CloudFoundry. It requires the presence of this type on the ADP.
You're right, I can address this in next PR
IMO this doesn't make sense, the properties belong to the location not the services.
This would be nice, I can address later on.

As you already mentioned, we can merge it, and then open a issue with this ideas and we will work on it later.


Fixing race condition during cluster upgrade with kernel upgrade

The following scenario causes worker pods to be stuck during cluster upgrade:

kernel module is loaded into the node. NMC contains both spec and
status using the current kernel version
cluster upgrade starts. As part of the upgrade node becomes
Unschedulable
Module-NMC removes Spec from NMC, since the node is Uschedulable 4) Node becomes schedulable
NMC controller tries to unload kernel module using the NMC Status
confiration, which contains old kernel.
Worker unload pods get stuck in Error, since Node is running the new
kernel
Module-NMC updates Spec of NMC, but since worker pod exists, nothing
is done

Solution:
When processing orphaned NMC statuses (status exists but spec does
not), NMC controller should ignore modules that have statuses created prior to Node's Ready timestamp

/assign @ybettan
/assign @mresvanis

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.62%. Comparing base (fa23a9b) to head (e355589).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   79.09%   72.62%   -6.47%
==========================================
  Files          51       65      +14
  Lines        5109     4490     -619
==========================================
- Hits         4041     3261     -780
- Misses        882     1044     +162
+ Partials      186      185       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm


Space closes the file naming automatically.

Description
If I want to write a file name like "exercise 1.typ"  the web app will always proceed to finish the naming of the file and throw you out.
Reproduction URL
No response
Browsers
Chrome
OS
Windows

Duplicate of #1294


Toggle state is not preserved when going GitHub -> Sourcegraph

The Sourcegraph extension API does not let you update user settings when the extension is running on GitHub via the browser extension.

The intended behavior is solved by the communication between the browser extension and the Sourcegraph instance https://github.com/sourcegraph/sourcegraph/pull/13107
That doesn't provide the ability to change settings at different configuration levels, but if that becomes a need, let's open a new issue for it.


Live Share Terminal is invisible to participants

For both the initiator and the participant:

VSCode Version: 1.51.1
OS Version: macOS Big Sur 11.0.1

Steps to Reproduce:

Open a VSCode Live Share session
Initiator shares a terminal
Participant cannot see the terminals' text, but can type in it (the typed text is visible to the initiator)

Does this issue occur when all extensions are disabled?: Yes/No
No, because then There is no Live Share then.

Hi is this still happening?

Yes this is still happening

Yes this is still happening


Accept transactions by ID in pooledUserCommands

This allows pooledUserCommands to accept transactions encoded with either hashes or ids, to make them more consistent with transactionStatus.
This also can be used to get the hash of a transaction from its ID via GraphQL: you can send the transaction as an ID and query its hash in the output.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Closes #8244

!approved-for-mainnet


openRepositoryInParentFolders = false has no effect

I have a git repo in my home dir, tracking dotfiles.
I open some project with code Documents/Project, with Project being a git repo.
Now I open ~/.bashrc inside that window.
In the source control view my home repo is open.

VS Code Version:  1.84.0
OS Version: macOS 13.2

Steps to Reproduce (with openRepositoryInParentFolders = false in settings):

mkdir Documents/Project
cd Documents/Project
git init
code .
Open ~/.bashrc
Go to source control view

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Please try upgrading to the latest version and checking whether this issue remains

Yes. it's the same.

@memeplex, the git.openRepositoryInParentFolders setting only support the following values: always, never, prompt. Could you please try to set the value of the setting to never and let me know if you are still able to reproduce the issue. Thanks!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

@lszomoru It has been in never AFAICR. I believe that if at some point the repo was open (explicitly or not) for a project, it sticks with it until you deliberately close it. I'll be alert and report it if it happens again, thanks.


Wrap the error in user and product update

https://github.com/ardanlabs/service/issues/141

Do one more thing. Add your name and email to the contributors file. Keep things in alphabetical order please.

Do one more thing. Add your name and email to the contributors file. Keep things in alphabetical order please.

Funny, we should have ran the tests first. I had to make a change to the handlers to use errors.Cause. Missing this was a mistake as well.

Funny, we should have ran the tests first. I had to make a change to the handlers to use errors.Cause. Missing this was a mistake as well.

Funny, we should have ran the tests first. I had to make a change to the handlers to use errors.Cause. Missing this was a mistake as well.

I see. We probably should integrate tests in the CI/CD.

Funny, we should have ran the tests first. I had to make a change to the handlers to use errors.Cause. Missing this was a mistake as well.

I see. We probably should integrate tests in the CI/CD.

I do, that is how I knew there was a problem with the change. :)

I do, that is how I knew there was a problem with the change. :)

Maybe they are not being run outside of master?

Maybe they are not being run outside of master?

I don't see it run for PRs. We can do it for PRs.

I don't see it run for PRs. We can do it for PRs.

Ok, I will look for that setting!!

Ok, I will look for that setting!!

PR's are checked for the webhook. Uhm?

PR's are checked for the webhook. Uhm?

You can take a look at this https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

You can take a look at this https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

Ok Done!

Ok Done!


How to read frames of T265 in different rate?

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
T265

Firmware Version
<IP_ADDRESS>6

Operating System & Version
Raspbian

Platform
RPi4

Language
python

Segment
Robot

Issue Description
The output rate of fisheye frame and pose frame of T265 are 30Hz and 200Hz, respectively. However, when I enable both fisheye frame and pose frame, the output rate of pose frame drops to 30Hz. How can I read the fisheye frame and pose frame asynchronously? If it can, I want to read them in its own max rate in different process.
If you know about that, please help me, thank you!

Hi @miku39s3
I think callback example is what you are looking for


More of a question than issue: Subscriber handles the same message multiple times

I have a piece of code that takes an "event" and stores that event to CosmosDb.
I've verified that there is only a Singleton instance of my EventManagementService (constructor only runs once), and also that the publisher of the event only transmits the event once.
Here is the subscriber piece of code:
public void Initialize()
        {
            _hub.Subscribe<NoobEvent>(SaveMessageToEventStore);
        }

        private async void SaveMessageToEventStore(NbtEvent updateEvent)
        {
            _hub.UnSubscribe<NoobEvent>();

            _logger.Information($"Transmitting event to eventstore: {updateEvent.EventName} {updateEvent.EventType}");

            //TODO: (Pedro) Validate the updateEvent

            await _exceptionHandler.RunAsync(() => _eventStore.Write(updateEvent));

            _hub.Subscribe<NoobEvent>(SaveMessageToEventStore);
        }

If I do not unsubscribe while executing the "SaveMessageToEventstore()", then I see that it executes twice. Questions to this:

Why does the subscriber invoke twice? I only have a single publisher, and a single handler
By Unsubscribing at the beginning of the handler, does this run the risk of loosing any potentially queued messages, or will it resume where left off?
Is there a way to mark a published message as "completed" that I am missing?

In advance, thanks.

This definitely smells like a bug, I'll have to dig into it a bit and see what I can find


Add npm

https://github.com/nodejs/help/wiki/Installation

@Equanox  Is this still required? As we are using nix now we can just add it through nix.


Install removes all packages in the current project

How is this even possible?
When I try to add this plugin with "npm install react-native-scrollable-tab-view --save" it literally removes all packages from my project. I have tested it with a fresh react-native project.
What's wrong? Any way to install it manually?

use ' $ yarn add react-native-scrollable-tab-view ' to install


Use /10 instead of /9 for default iprange

... so it doesn't clash with CircleCI address
We were getting a lot of failures like this:
---= Running 150_connect_forget_test.sh =---
Connecting and forgetting routers after launch
network <IP_ADDRESS>/9 would overlap with route <IP_ADDRESS>/32
Default -iprange <IP_ADDRESS>/9 overlaps with existing route.
Please pick another range and set it on all hosts.

Proof that our check works!!!


Release v0.26.0

Adds

Exports the useCarouselStyles and useWindowSize hooks and adds documentation for all hooks in Storybook.
Adds additional semantic design tokens from fontWeights and fontSizes to the useNYPLTheme hook.
Adds a warning if a required id prop is not passed to one of the "Form Elements": Button, Checkbox, CheckboxGroup, DatePicker, Fieldset, Form, Label, ProgressIndicator, Radio, RadioGroup, SearchBar, Select, Slider, TextInput, Toggle.
Adds the isRequired prop to the Label component.
Adds the labelPosition prop to the Select component, so that the label can be styled inline with the select input.
Adds Chakra's "Style Props" functionality to every Reservoir component. For composed components, such as the SearchBar component, these style props are passed to wrapper element. This update also updates the snapshot tests for every component.
Adds the functionality to pass all valid HTML attributes to a Reservoir component, such as data-* props.
Adds semantic design tokens for spacing theme object.
Adds the isAlignedRightActions prop to the Card component to render CardActions components to the right of the main content area. This only works for the Card's row layout.
Adds styles to target native HTML basic elements inside the StructuredContent component.
Adds Reservoir branding to Storybook.

Changes

Updates the hex color value for ui.gray.light-cool, ui.disabled.primary and section.blogs.primary.
Updates the default background color used in the Accordion component.
Updates the default background color used in the Hero component.
Updates the background color used in the SkeletonLoader component.
Updates the background color used in the VideoPlayer component.
Updates the background colors used in the Tabs component.
Updates the colors for "secondary" and "pill" variants of the Button component.
Updates the color values used in the disabled state for the Checkbox, Radio, Select, Slider, TextInput and Toggle components.
Updates the Checkbox component to use "3px" for the border radius.
Makes the id prop required for all "Form Elements".
Updates how the Required text in the Label and Fieldset components is displayed. Instead of floating to the right of the label and legend elements, it is now displayed inlined as (Required).
Renames the optReqFlag prop to showRequiredLabel in the CheckboxGroup, Fieldset, RadioGroup, and Slider components.
Renames the showOptReqLabel prop to showRequiredLabel in the DatePicker, Select, and TextInput components.
Uses the design token "text.caption" variable for the Notification's font size.
Updates the styling for the HelperErrorText to be consistent for all components that use it
Refactors the Checkbox, CheckboxGroup, ComponentWrapper, DatePicker, Fieldset, Label, Radio, RadioGroup, Select, Slider, TextInput, and Toggle to better use the updated HelperErrorText styling.
Renames the Card's center prop to isCentered and border prop to isBordered.
Renames the SkeletonLoader component's border prop to isBordered.
Refactors the DS RadioGroup component so it internally implements Chakra's RadioGroup component rather than the useRadioGroup hook. The "uncontrolled" version of Chakra's RadioGroup is not working and will be investigated in the future. It is recommended to use the controlled component pattern.
Updates the Fieldset component to render the "Optional"/"Required" text in the legend element as pseudo CSS in the ::after rule.
Passes the isRequired prop in the RadioGroup and CheckboxGroup to the Fieldset wrapper component.
Updates the focus styles for the Radio, Select and TextInput components.
Updates the references of the <dl> element from "Definition" to "Description", as that's the official name in HTML5. This affects the List element and its ListTypes.Description enum value.
Updates styles for React Datepicker's calendar popup in the DatePicker component.
Updates storybook URL from /storybook-static/ to /reservoir/v0_26.
Updates all references to "design system" in the Storybook documentation to include "Reservoir" in the name of the design system.
Updates language on the Welcome page.

Removals

Removes the default Optional text displayed in the Label and Fieldset components.
Removes the optReqFlag prop in the Label component.
Removes the default autogenerated id for all components, as well as the uuid package.
Removes the HorizontalRule's height and width props from its prop interface in favor of Chakra's style props; the default values are still set for height and width.

Fixes

Fixes how the Button component gets rendered inside the Form and FormField component layout.
Fixes how the Select component is controlled in the SearchBar component.

Tugboat has finished building the preview for this pull request!
Link:

https://pr970-f9kiwfllmq3bicg1b0hrzdxwrts7ynin.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6262dac58a3b7b49de652395


'FightyPandemiccs' logo on 'Individual User profile create' page should be clickable.

Open "staging.fightpandemics.work"
Sign up as new user say 'Linkedin User'
On User profile creation page, scroll over 'FP' logo present in top left corner.

Issue: you will observe that FP logo is NOT clickable

Hi @rabbi08 - this does relate to my response to @idjevm  here: https://github.com/FightPandemics/FightPandemics/pull/1163#issuecomment-659019138
As well as the issue I created here #1164
I assume you are referring to this logo:

As best as I can explain and understand, what's happening is after authorizing OAuth is we are redirected to /create-profile in this RouteWithSubRoutes.js component due to some condition (I'd need to look it up) - but the same thing will redirect you back after you click on logo (home) link.
Allowing this without breaking the functionality we want wouldn't be easy (why I removed the label) and would probably require adding more mess & technical debt to something we definitely need to refactor.
Also, maybe this was desired when implemented? I don't know. We want them to complete their profile and not go somewhere else (but in such a case it shouldn't be a clickable link, or there should be message).
Anyways, since it is low priority and shouldn't be fixed in isolation of an overall refactor (IMHO) maybe let's close this? I can refer to this in my other ticket as reference.

Just to add on to @joshmorel, inRouteWithSubRoutes.js the line causing the redirect is specifically for the case where the user is authenticated but hasn't created a profile. Clicking the logo actually does take the user to the home page, but the home page then immediately redirects to the create-profile page to ensure the user completes their profile setup. I think this is the intended behavior and this issue should be closed.

Well @joshmorel same idea here, but for the verify email/email sent pages, I think there on those pages, we should allow the user to click on the logo and go back home, but for this page, it is ok to not have this logo clickable, enforcing the user to complete their profile which is what we want. Closing this issue as this behavior is ok for this page. @manualzuru feel free to reopen if you think otherwise.


room.lastMessages is Always null

I am streaming rooms using code below
FirebaseChatCore.instance.rooms(orderByUpdatedAt: true)
However it looks like lastMessages is always null
room.lastMessages
I am 100 percent sure that I have last messages on the rooms collection (Which is updated by cloud function)

i had the same issue, it could be that you didnt create a firestore index

Are you sure room at all is not empty? You need an index as described in the documentation comment for the orderByUpdatedAt or in the comment above. If you have it

I am 100 percent sure that I have last messages on the rooms collection (Which is updated by cloud function)

So you can see lastMessages inside the console but not in the dart code?

I did create an index. Hence the rooms are showing nicely and the recent active room always appear at the top... Which is awesome.
I can see however lastMessages is always null NOT empty

@mashegoindustries I understand, but is it null in the console? Why do you think this is a problem in the library and not in the cloud function which updates it?

From console, it looks like Cloud functions has successfully updated last message

Are you saying you don't see lastMessages at all? Update to the latest version

@demchenkoalex I started from scratch, followed the instructions , created firestore index. Using latest version of the plugins.
However I am still not getting any last messages. Isn't the attached screenshot not the issue? lastMessages is never set

LOL. How embarrassing :D sorry about that. You could have also done a PR with that so it would be released sooner. Will do now anyway.

I need this fix too. Running into error
flutter type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type....

I tried the highlighted lines in the screenshot above with
final lastMessages =  doc.data()?['lastMessages'] as List<dynamic>?;
and then while creating the room, I did
lastMessages: lastMessages != null ? lastMessages.map((e) => types.Message.fromJson(e)).toList() : <types.Message>[],
But issue is the lastMessage only has authorId and the toJson is failing because author property is null and it expected a types.User map

resolved author by setting it in cloud function for lastMessages but now it createdAt on lasts message is also failing because it expects an int and the value is DateTime. We may need to write a parser if one does not already exists.

That's correct. My thought is to create a json from the document data, replace fields like DateTime etc to match the underlying data, and the pass it to the fromJson function, after I'll replace that with some package for JSON serialisation, because library became too big to manually parse things + this dynamic issue is driving me mad, hopefully some packages work better with whatever values are passed inside, when we know they are correct.

Fixed in v1.3.0.


Local_auth Has No Haptic Feedback on iOS

local_auth has no haptic feedback on iOS, as far as I know, this is almost a default behavior on iOS. If this is not the case, can you at least add an option to add a haptic feedback to it (touch id and face id haptic feedback).

Hi @yekta
Are you still experiencing this issue with latest stable Local_auth?
Thank you

Closing as out of scope; the UX of authenticating is provided by the system, and anything additional behaviors would need to be provided by the plugin client.


SyntaxError on Python 3.2 using unicode u-prefix

(Original issue 1054 created by mmerickel on 2014-11-08T01:09:10.195606+00:00)
Using the latest on PyPI which is 2.0rc1.
#!shell

<< truncated traceback >>
    from pygments import highlight
  File "/Users/michael/work/oss/pyramid_debugtoolbar/.tox/py32/lib/python3.2/site-packages/pygments/__init__.py", line 37, in <module>
    from pygments.util import StringIO, BytesIO
  File "/Users/michael/work/oss/pyramid_debugtoolbar/.tox/py32/lib/python3.2/site-packages/pygments/util.py", line 217
    return u'[%s-%s]' % (unichr(a), unichr(b))
                    ^
SyntaxError: invalid syntax

(Original issue 1054 last updated on 2014-11-08T06:17:31.420195+00:00)
(Issue automaticaly closed due to status in Bitbucket: wontfix)

(Original comment by birkenfeld on 2014-11-08T06:17:31.432863+00:00)
Pygments 2.0 requires Python 3.3+.


can not get LocalAddr in stun package

// Client simulates "connection" to STUN server.
type Client struct {
	rto         int64 // time.Duration
	a           ClientAgent
	c           Connection
	close       chan struct{}
	rtoRate     time.Duration
	maxAttempts int32
	closed      bool
	closeConn   bool // should call c.Close() while closing
	wg          sync.WaitGroup
	clock       Clock
	handler     Handler
	collector   Collector
	t           map[transactionID]*clientTransaction
	// mux guards closed and t
	mux sync.RWMutex
}

there the “c” is a small letter
and find not a func to get “conn“

Hi, thank you for reporting the issue.
Please use the NewClient function to pass your own connection.
I can add the Connection and LocalAddr helpers for client so this is not needed, but seems like it won't help in common use case. Please share how you want to use the obtained local address value so I can understand the context better.

Use for create new net.Dealer with the LocalAddr.
And use it to ice NAT, deal with local and NAT  ports are different.
And I can’t know if it will works...
发送自 Windows 10 版邮件应用
发件人: Aleksandr Razumov
发送时间: 2019年8月9日 4:47
收件人: gortc/stun
抄送: lluck42; Author
主题: Re: [gortc/stun] can not get LocalAddr in stun package (#66)
Hi, thank you for reporting the issue.
Please use the NewClient function to pass your own connection.
I can add the Connection and LocalAddr helpers for client so this is not needed, but seems like it won't help in common use case. Please share how you want to use the obtained local address value so I can understand the context better.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Please take a look at cmd/stun-traversal example, that should help.
Also you can take a look at pion/webrtc project, it can handle NAT traversal automatically.


Update searching-the-console-view.md

unnecessary and confusing info removed

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:
House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Schema for wiring like the passive adapter

Hi, I would like test the wiring of the passive adapter but I don't found the schema like for the active adapter here :
https://github.com/hzeller/rpi-rgb-led-matrix/blob/master/img/active3-schematic.png
Can I just to connect them like the active adapter, without the four controllers ?
If no, could you share a schema of the wiring for the passive board ?
Thanks in advance.

Hi, have you raised this on the right repository? Not sure what this is to do with node-red.


Test more than one thing

The test should have tested two boundaries with different featurecla, but ended up being a copy/paste error. This fixes that.
Connects to #797.
@rmarianski could you review, please?

:+1:


Is there a way to get a list of files that weren't compiled into an entrypoint's bundle?

For example, if I tell webpack to compile an entry point, that entry point will require other files, etc. Is there a way for Webpack to give me a list of unused files, files that weren't require/imported into the bundle?

Nope, but feel free to write a plugin.

I found a solution: the compiler stats.toJson() object contains a list of modules that were compiled. I have the list of all the files, so I can just see which files aren't listed in the modules array, and those are the files that weren't used.


Make the config parameter of the loadModelFromUrl function optional

This is a suggestion for eliminating the need to fill it with {} when users want to use the default configuration.

I was unsure whether to include the built files in the esm folder while sending the changes with the pull request. I can remove the files if they are not required now.

LGTM. Thanks.
The esm directory will be removed soon (no need to worry about that). It's there because I wanted to have the pre-built esm for github pages, but we've moved github pages build to CI: https://github.com/ngxson/wllama/actions/workflows/pages/pages-build-deployment


Adapt setup to work on AWS

splits requirements to develop and master
works locally and on docker hub

why do the requirements need to be split?
Does it not make the tests less realistic if travis installs different requirements than the normal Dockerfile?

@stefanfoulis on travis we want the latest releases to pass, If there is an error we need to fix addons ASAP.
On docker and locally, we want the latest develop version to be installed so preview.django-cms.org shows our latest efforts. Optionally you can use make install REQUIREMENTS=master to also install latest releases on your local env.
I still need to adapt the requirements to use all develop versions, once the setup is up and running.

makes sense :-)
:+1:
as a later step it could be useful to use pip-compile (from pip-tools) to test all the requirements. That would also detect impossible combinations of dependencies (e.g one package says html5lib<0.10 and another html5lib>=0.999999). pip alone does not see such inconsistencies.

will keep that in mind @stefanfoulis thank you


Non local deployment

[x] expose network flag, change chain_id flag to network flag
[x] make client configuration base on network name
[ ] change everything to grpc instead of rpc
[ ] test it on testnet

cosmwasm.v2.Msg service is unimplemetned


Add documentation

Changes

Add files to generate the documentation using sphinx.

New

Configuration of the documentation
Example page about installation and the API

A few comments:

First, I hope that I included all necessary files and you can generate the documentation easily via make html.
While exploring the package, I noticed that the top-level __init__.py file is empty. If I haven't missed anything, this leads to the behavior that if I do import tradeseq, I cannot access the class tradeseq.gam.GAM. To access it, I need to do import tradeseq.gam. In general, I always need to import the submodule to use classes from it. Is this intended?
I was a bit unsure, which methods should be included in the API. For now, I decided to include all public methods and __call__() for the test classes, but this is easy to change. Since the content of the documentation of __init__() is important, I used the option to append this docstring to the class's docstring. However, it might be better to change this actually in the code.


对 with ... as ... 语句进行格式化时，生成的sql有缺失

版本 druid 1.1.13
with col_regid as (select first(regid) as regid, INID
                   from his.OPM_OTHER_INHOSAPPLY_INFO T32
                   where T32.EXT18 = '0'
                     AND T32.STATUS <> '3'
                   group by T32.INID),
     col_staticname as (SELECT staticcode, first(staticname) as staticname
                        FROM his.FIN_STATICCODE_LOCAL
                        group by staticcode)
SELECT a.orgcode,
       a.orgname,
       to_date(A.FEEDATE),
       first(T32.Regid),
       first(i.staticname),
       sum(A.TOTCOST - ifnull(A.FEE_DISCOUNT, 0))
FROM his.IPB_ITEMLIST A
         left join col_regid T32 on T32.INID = a.INID,
     his.OAM_OPERATION_APPLY t
         left join col_staticname i on i.staticcode = t.szbm
WHERE a.ORGCODE <> '122'
  and to_date(A.FEEDATE) between TO_DATE('2021-07-01') AND date_sub(now(), 1)
  and a.inid = t.inid
  and t.applystate = '3'
  and t.source = '2'
  AND t.ORGCODE <> '122'
GROUP BY a.orgcode, a.orgname, to_date(A.FEEDATE), t.szbm, a.INID

然后执行
System.out.println(SQLUtils.formatHive(sql));
生成的语句有错误

我在版本1.1.20中未重现问题，貌似已经解决
WITH col_regid AS (
		SELECT first(regid) AS regid, INID
		FROM his.OPM_OTHER_INHOSAPPLY_INFO T32
		WHERE T32.EXT18 = '0'
			AND T32.STATUS <> '3'
		GROUP BY T32.INID
	),
	col_staticname AS (
		SELECT staticcode, first(staticname) AS staticname
		FROM his.FIN_STATICCODE_LOCAL
		GROUP BY staticcode
	)
SELECT a.orgcode, a.orgname, to_date(A.FEEDATE)
	, first(T32.Regid), first(i.staticname)
	, SUM(A.TOTCOST - ifnull(A.FEE_DISCOUNT, 0))
FROM (his.IPB_ITEMLIST A
	LEFT JOIN col_regid T32 ON T32.INID = a.INID, his.OAM_OPERATION_APPLY t)
	LEFT JOIN col_staticname i ON i.staticcode = t.szbm
WHERE a.ORGCODE <> '122'
	AND to_date(A.FEEDATE) BETWEEN TO_DATE('2021-07-01') AND date_sub(now(), 1)
	AND a.inid = t.inid
	AND t.applystate = '3'
	AND t.source = '2'
	AND t.ORGCODE <> '122'
GROUP BY a.orgcode, a.orgname, to_date(A.FEEDATE), t.szbm, a.INID


Add a new section: API Changelogs

For the people who build solutions based on Adobe Analytics 2.0 APIs, they will need to guard against breaking changes of these APIs.
So there should be a place where they know they can look at. As far as I know, there isn't one currently.

Adobe is extra careful to not make any changes that would potentially break existing API workflows. For additions to the API, they are posted on the Analytics release notes page here: https://experienceleague.adobe.com/docs/analytics/release-notes/latest.html


utilities for writing files or interacting with different image output formats

maybe a separate mode of the image class? will need more time in the oven on this

image class has been adapted to this in #13
more util needed, so keeping issue open

using PIL/pillow for single images allows writing to whatever format from ndarray
using ffmpeg in multiimages allows gif saving, and will be easy to support other codecs
in the future can support multiple driver types for saving, but that's not relevant now and has no current use case


Gamma Utils(Fullbright)

Modrinth link
https://modrinth.com/mod/gamma-utils/versions
Source link
https://github.com/Sjouwer/gamma-utils
License
LGPL-3.0
Mod description
It's a fullbright mod for clients.
Why should it be in the modpack?
• Highly Customizable
• Actively Updated
• Rather then using a full bright texture pack this mod allows the user to change the gamma to their liking.
Why shouldn't it be in the modpack?
• Some players would say: This mod is a kind of cheat.
• Most users wouldn't even know if the mod was installed, as the settings for the mod are in the mod menu.
Additional details
There is a issue with Ryaomic Lights mod.
https://github.com/ThinkingStudios/RyoamicLights/issues/11

Some players would say: This mod is a kind of cheat.

Yeah, I don't think FullBright (or any xray, etc feature) is a good idea for the pack.
Closing this issue as "Not Planned".


dmesg test failing on the CI

The following test is failing
13:13:39 [1] • Failure [13.651 seconds]
13:13:39 [1] check dmesg logs errors
13:13:39 [1] /tmp/jenkins/workspace/kata-containers-tests-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:277
13:13:39 [1]   Run to check dmesg log errors
13:13:39 [1]   /tmp/jenkins/workspace/kata-containers-tests-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:294
13:13:39 [1]     should be empty [It]
13:13:39 [1]     /tmp/jenkins/workspace/kata-containers-tests-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:295
13:13:39 [1]
13:13:39 [1]     Expected
13:13:39 [1]         <string>: [    0.619595] systemd[72]: tmp.mount: Failed to execute command: No such file or directory
13:13:39 [1]         [    0.619844] systemd[72]: tmp.mount: Failed at step EXEC spawning /usr/bin/mount: No such file or directory
13:13:39 [1]     to be empty
13:13:39 [1]
13:13:39 [1]     /tmp/jenkins/workspace/kata-containers-tests-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:305
13:13:39 [1] ------------------------------
13:13:39 [1]

/cc @amshinde

@chavafg @GabyCT I guess this is in the clearlinux rootfs. I had tested this for centos rootfs, just because I find it easier to setup a debug console with it.
Looks like mount command is missing in clearlinux. I'll try to reproduce this issue first.

Set up a debug console for clearlinux.  So are commands like ls, cat.
I could not run a ls or systemctl cat tmp.mount at all.
(As the tmp.mount unit is autostarted, looks like the systemd dependencies are different in a clearlinux and centos mini-os, and those are the two that I ended up testing so far)
cc @jcvenegas

Looks like util-linux-bin (which contains the mount command among others) is not being pulled as a dependency for systemd in Clearlinux.  The  util-linux-bin package is listed as a dependency for systemd all other distros. This seems to be a clear nuance :)
I am going to add this package explicitly for Clear in os-builder to fix this issue. (This would add another 3204K to the image size)
I also noticed that coreutils-bin is not being pulled either(this should be a dependency for libc6 which should be pulled in by systemd). This explains the absence of commands such as ls, cat in the clearlinux rootfs.
Though I dont see this breaking anything today, we should probably be adding this as well.
If not atleast list this as a requirement for debug shell for clearlinux. Without coreutils, the debug shell is pretty useless for Clear.
Thoughts @grahamwhaley @jodh-intel ?

I wonder if using busybox would suffice as that provides ls, cat, and mount?
That said, although it appears to be packaged for Clear, it has not been updated for a long time:

https://github.com/clearlinux-pkgs/busybox/blob/master/busybox.spec

/cc @devimc who might have a view on increasiing image size :smile:

Maybe we should also consider attack surface as well as just footprint - if we don't need these tools in the mini-os to launch container workloads, then we should probably not include them in our base image. Yes, that might mean if somebody wants to get a useful debug console enabled then they will also have to build/use a fuller rootfs image to get some of the utils - but, our primary use case of the mini-os is to run containers. Debug console is a dev corner case, and (hopefully) not the norm.

Reading back up the issue - I presume that systemd mount fail is a real symptom of a real issue? Do we know what it failed to mount? I'm slightly confused - did the upstream Clear Linux change its packaging, which dropped mount for us, and thus has now started to fail our CI checks (nice check btw heh ;-) )

I know we've discussed this sort of issue ad nauseam a few times before guys. Adding coreutils and util-linux is going to add ~200 commands. A "full" busybox install would add more (my Fedora busybox provides 388 commands), but busybox could of course be configured to simply add the individual commands.
Another alternative would be to build with coreutils and util-linux but delete everything not needed by mount, ls, blah.

@jodh-intel - looking at that Clear Linux busybox package repo, does that imply that there is just a small subset of commands enable/built in that busybox (including mount)?
@bryteise - what's the deal with the CLR busybox package - I guess they don't auto update versions? Does that package have an owner who could bump/maintain/track the upstream?

@grahamwhaley - Looks that way to me. And that's why I was suggesting busybox as an alternative to the other two packages. We'd only need to add cat potentially if @amshinde thinks we need that. I believe that coreutils has grown similar multi-call binary abilities but I haven't looked at it. We can't use busybox from CLR if it isn't being updated though.

@grahamwhaley We don't build busybox any more.


LOTR - Resolve Ring overflowing and stuck

C2F response stuck on ring for eternity

fix : wrong signals on c2f module:

ABD resolved


ac-go-live

Docs Build status updates of commit 75b753c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/whats-new.md
:warning:Warning

Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/TOC.yml
:white_check_mark:Succeeded

msteams-platform/bots/how-to/authentication/add-authentication.md
:white_check_mark:Succeeded

msteams-platform/concepts/build-and-test/apps-localization.md
:white_check_mark:Succeeded

msteams-platform/concepts/deploy-and-publish/apps-publish.md
:white_check_mark:Succeeded

msteams-platform/concepts/deploy-and-publish/office-store-approval.md
:white_check_mark:Succeeded

msteams-platform/concepts/deploy-and-publish/office-store-checklist.md
:white_check_mark:Succeeded

msteams-platform/concepts/deploy-and-publish/office-store-guidance.md
:white_check_mark:Succeeded

msteams-platform/includes/landing-page.html
:white_check_mark:Succeeded

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded

msteams-platform/task-modules-and-cards/task-modules/task-modules-bots.md
:white_check_mark:Succeeded

msteams-platform/whats-new.md

Line 17: [Warning] Invalid link: 'Initiate actions with messaging extensions'. The file concepts/messaging-extensions/create-extensions.md doesn't contain a bookmark named 'request-to-install-your-conversational-bot'.
Line 18: [Warning] Invalid link: 'Get context for your tab'. The file concepts/tabs/tabs-context.md doesn't contain a bookmark named 'retrieving-context-in-private-channels'.
Line 20: [Warning] Invalid link: 'Respond with bot message from task module'. The file concepts/messaging-extensions/create-extensions.md doesn't contain a bookmark named 'respond-with-an-adaptive-card-message-sent-from-a-bot'.
Line 23: [Warning] Invalid link: 'Message Actions'. The file concepts/messaging-extensions/create-extensions.md doesn't contain a bookmark named 'action-type-message-extensions'.
Line 24: [Warning] Invalid link: 'Link unfurling'. The file concepts/messaging-extensions/search-extensions.md doesn't contain a bookmark named 'receive-requests-from-links-inserted-into-the-compose-message-box'.
Line 28: [Warning] Invalid link: 'Deep linking to a chat'. The file concepts/deep-links.md doesn't contain a bookmark named 'deep-linking-to-a-chat'.
Line 30: [Warning] Invalid file link:(~/scenarios/limited-tenant.md).
Line 33: [Warning] Invalid link: 'Deep linking to a chat'. The file concepts/deep-links.md doesn't contain a bookmark named 'deep-linking-to-a-chat'.
Line 38: [Warning] Invalid file link:(~/scenarios/lob-scenarios-landing-page.md).
Line 39: [Warning] Invalid link: 'Configuration page height'. The file resources/design/framework/tabs.md doesn't contain a bookmark named 'configuration-page-height'.
Line 40: [Warning] Invalid link: 'Adaptive card'. The file concepts/Cards/cards-reference.md doesn't contain a bookmark named 'adaptive-card'.
Line 40: [Warning] Invalid link: 'Adaptive card actions in Teams'. The file concepts/Cards/cards-actions.md doesn't contain a bookmark named 'adaptive-cards-actions'.
Line 46: [Warning] Invalid link: 'Updating your app'. The file publishing/apps-publish.md doesn't contain a bookmark named 'updating-your-app'.
Line 47: [Warning] Invalid link: 'The tab configuration page is significantly taller'. The file resources/design/framework/tabs.md doesn't contain a bookmark named 'configuration-page-height'.
Line 48: [Warning] Invalid file link:(~/troubleshoot/faq.md#teams-apps-and-authentication-with-guest-users-and-microsoft-teams-free).
Line 50: [Warning] Invalid link: 'Featured code samples'. The file samples/code-samples.md doesn't contain a bookmark named 'featured'.
Line 51: [Warning] Invalid link: 'Adaptive card'. The file concepts/Cards/cards-reference.md doesn't contain a bookmark named 'adaptive-card'.
Line 51: [Warning] Invalid link: 'Adaptive card actions in Teams'. The file concepts/Cards/cards-actions.md doesn't contain a bookmark named 'adaptive-cards-actions'.
Line 35: [Suggestion] Link 'https://docs.microsoft.com/en-us/adaptive-cards/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[FormRecognizer] Bring back Azure AD credential support

LGTM. Do we have tests to verify that AAD auth is working?

Not yet. Logged #8943


Remove GetAttributeOfType from Tweetinvi namespace

Whilst updating my code, I noticed resharper suggested a GetAttributeOfType method in Tweetinvi (as well as my local one). I added this for the LanguageAttribute, but it's only used by a Unit Test so could be moved to the unit test library if you want.

This is already located in the Tweetinvi.Core.Extensions namespace.


Vertx MailClient 'createShared' is broken as of 3.x (3.9?).

Questions
Hello,
It has been observed that the 'createShared' implementation of Vertx is broken - in that the client tends to mix-up (interleave) the SMTP commands - MAIL FROM / RCPT TO / DATA sections (with regard to the RFC) under shared socket scenarios.
Version
Which version(s) did you encounter this bug ?
3.x (Exact version is not known. Likely its 3.9. However, believe this should be reproducible in current versions - that is 4.x variants as well)
Need to look at - https://github.com/vert-x3/vertx-mail-client/blob/3.9/src/main/java/io/vertx/ext/mail/MailClient.java
Context
In particular it has been observed that a mail intended to be initiated from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>was instead delivered to<EMAIL_ADDRESS>(likely owing to the fact that one thread sent 'MAIL FROM' and 'RCPT TO' where as 'DATA' part was sent from another thread).
Do you have a reproducer?
Not as of now but the issue was clearly visible at around 30 Requests-Per-Second Approx.

Link to github project/gist

Steps to reproduce
Server-End

Set up a mail server in relay configuration to enqueue emails (source, destination, content) but not to deliver.

Client-End

Prepare a test case such that there is a specific set of senders and receivers and the payload that can be reviewed for discrepancies. Create about a hundred of these.
Initiate a load of around 30 RPS using a suitable test harness. A single system as client and a single system as a server should do the trick but more would be better ! Initiate a load for about 15 minutes.
Review the contents in the mail-server logs/queue. There would at least be a handful of discrepancies (where the intended combination of source and destination is different).

Extra

OS - Ubuntu 18 or 20 ?
JVM - JDK 1.8 ?

Created issue under vertx-mail-client !


Error: "connection string with the name MyDbConnection already exists"

Fails @ step 3 - Note that the first option is "Local user secrets file" now, not "Azure App Settings".
I tried to go back and set things up using an Azure Key Vault, but I assume there are other things I'm missing, because it doesn't work after publishing.  Also note in the error below that it references "Azure SQL Database mssql1."  I don't have a db with that mssql1 name, not sure where that comes from.
Configuring Secrets.json (Local) dependency secrets1 in the project...
Installing NuGet packages to project...
Installing package 'Microsoft.Configuration.ConfigurationBuilders.UserSecrets' with version '2.0.0'.
Serializing new Secrets.json (Local) dependency metadata to disk...
SuccessComplete. Secrets.json (Local) secrets1 is configured.
Verifying access to Azure SQL Server...
InformationFirewall rule added. In order to modify your rules, visit
Configuring Azure SQL Database dependency mssql1 in the project...
Installing NuGet packages to project...
Installing package 'EntityFramework' with version '6.4.0'.
Adding MyDbConnection to store LocalSecretsFile...
ErrorA connection string with the name MyDbConnection already exists.
ErrorFailed to configure Secrets store.
ErrorFailed to configure dependency Azure SQL Database mssql1.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72d855c6-51fd-a1da-5c44-8b44658c0211
Version Independent ID: 15c87b07-e89e-2b0c-6337-3940a5259101
Content: Tutorial: ASP.NET app with Azure SQL Database - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-dotnet-sqldatabase.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@msmarkma, Thanks for the feedback! We are taking a look into this and will get back to you soon.

@msmarkma, Thanks for the feedback! We are taking a look into this and will get back to you soon.

Mark, apologies for the delay! It would be from the downloaded sample. The tutorial steps works fine for me. Could you please share more info on this "but I assume there are other things I'm missing, because it doesn't work after publishing." Could you please re-try afresh (avoid duplicate/multiple entries, needs unquie name) and let us know if it is still the same problem.
The app uses a database context to connect with the database. In the sample, the database context uses a connection string named MyDbConnection. The connection string is set in the Web.config file and referenced in the Models/MyDatabaseContext.cs file. In the Database connection String Name, type MyDbConnection> This name must match the connection string that is referenced in Models/MyDatabaseContext.cs. Ensure that there is no multiple deployments/duplicates entries.

I walked through the tutorial twice before filing the bug.  I get to step 3 under "create a database...".  I press finish to publish to Azure.  I get the error described above.  Removed all of the Azure resources between attempts - are there other files I should delete/restore as well?
The tutorial specifically references that the connection string value will get pushed to Azure App Settings.  That is NOT an option in that UI anymore.  Per above, it is "Local user secrets file".
My comment about trying a Key Vault - I thought my issue might be that the secrets are not being pushed up to Azure (since they are in a local file).  So I tried the KV option in the menu in step 3 instead.  But there must be other changes needed elsewhere in the code to enable that, because that didn't work.  I do not expect you to make this tutorial work with key vault, unless that's NEEDED now that Azure App Settings has been removed as one of the options.

Thanks for additional details. I'm reviewing this further/discussing internally, will get back to you shortly. Apologies for any inconvenience with this.

After making some latest changes on my VS, I notice the same issue. We're reviewing this further and have also shared your feedback with the content author (@cephalin) to review and update the document as appropriate.
Apologies for all the inconvenience! Thanks again for the feedback.

is this solved? im still having this issue
Configuring Azure SQL Database dependency mssql1 in the project... Adding ConnectionStrings:PharmaceuticalProductConnectionString to store AzureAppSettings... Installing NuGet packages to project... Installing package 'Microsoft.EntityFrameworkCore.SqlServer' with version '5.0.1'. ErrorNuGet.PackageManagement.PackageReferenceRollbackException: Package restore failed. Rolling back package changes for 'PharmaceuticalProduct.Api'.    at NuGet.PackageManagement.NuGetPackageManager.<ExecuteBuildIntegratedProjectActionsAsync>d__82.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)    at NuGet.PackageManagement.NuGetPackageManager.<ExecuteNuGetProjectActionsAsync>d__79.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.PackageManagement.NuGetPackageManager.<InstallPackageAsync>d__48.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.PackageManagement.NuGetPackageManager.<InstallPackageAsync>d__47.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.VisualStudio.VsPackageInstaller.<InstallInternalCoreAsync>d__31.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)    at NuGet.VisualStudio.VsPackageInstaller.<InstallInternalAsync>d__30.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at NuGet.VisualStudio.VsPackageInstaller.<InstallInternalAsync>d__30.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()    at NuGet.VisualStudio.VsPackageInstaller.RunJTFWithCorrectContext(Project project, Func1 asyncTask)
at NuGet.VisualStudio.VsPackageInstaller.InstallPackage(String source, Project project, String packageId, String version, Boolean ignoreDependencies)
--- End of stack trace from previous location where exception was thrown ---
at NuGet.VisualStudio.VsPackageInstaller.InstallPackage(String source, Project project, String packageId, String version, Boolean ignoreDependencies)
at Microsoft.WebTools.Shared.VS.NuGet.NuGetPackageManager.d__29.MoveNext()
ErrorFailed to configure NuGet packages.
ErrorFailed to configure dependency Azure SQL Database mssql1.
`

Installing package 'Microsoft.EntityFrameworkCore.SqlServer' with version '5.0.1'. ErrorNuGet.PackageManagement.PackageReferenceRollbackException: Package restore failed. Rolling back package changes for

I am having this problem as well (although it seems different from the one initially reported in this issue)

@tnlthanzeel @improwise you're following a .NET Framework tutorial but your error messages indicate that you have a .NET Core app. And you're right it's not related to the original issue.


Fetch posts with credentials

Is this currently possible? I've tried looking in options couldn't find anything promising, this redirect thing they implemented is annoying.

We haven't explored that feature yet.

Would probably be good idea to help out on.

getThreadsLoggedIn was introduced in https://github.com/junhoyeo/threads-api/releases/tag/v1.6.2. Thanks!

getThreadsLoggedIn was introduced in https://github.com/junhoyeo/threads-api/releases/tag/v1.6.2. Thanks!

Why does it require user Id and not username?


Tutorial uses dhat rather than BarrierPotential in FrictionCollisions().build() (1.3.0)

The tutorial for 1.3.0 contains this code:
friction_collisions = ipctk.FrictionCollisions()
friction_collisions.build(
    collision_mesh, vertices, collisions, dhat, barrier_stiffness, mu)

But this fails as it expects a BarrierPotential rather than dhat.

Thank you for pointing this out. I fixed the main tutorial. It used to be able to implicitly cast between double and BarrierPotential, but I removed this feature (marked constructor explicit).


Replace fts-dev with musl-fts-dev under alpine

Package name for fts-dev in alpine is "musl-fts-dev", and musl-fts for fts.
And util-linux-misc is available in 3.17. At least there is no util-linux-misc in 3.14 repo.
Install mount and umont from repo, busybox version doesn't work for this script.

I hope that fixes proposed by sulisu will be included soon. This repo has one of the best and most recent zram-config solutions right now, despite not seeing any commits during the last year or so.

This seems like a great idea, I've been away for some time, and I also don't have a system to test these particular changes on. Would you be willing to open a pr for this @sulisu?

@sulisu @tux-ware does the proposed fix in #113 work for you on Alpine? I don't currently have a way to test.


[BUILD] Add caching to CMake

In this PR I add code to cmake/config.cmake and CMakeLists.txt to cache builds. This makes switching between branches less painful because you don't have to build from scratch every time you switch branches.
@mbrookhart @tkonolige @csullivan Please take a look!

LGTM. One tip: ccache-3.x doesn't support nvcc well, so CUDA kernels may never hit the cache and still need to be re-compiled every time. Using ccache 4.0+ can resolve this issue.

Can we add that to the documentation on the option?

@electriclilies this is great! thanks for adding this feature.

@mbrookhart Added it :)
@mehrdadh This snippet has been circulating for a while, I got it from @csullivan originally :) I figured I should put it in the codebase after it got wiped from my local config.cmake file when I built using docker and then I had to track down the snippet again 🤣

This PR has failed a few times on the windows build. I'm not sure if this is caused by this PR or not; we should keep an eye on it and perhaps set the default behavior to not cache if it is causing flaky tests.

Thanks Lily for the great work! Yeah I am using ccache a lot as well when working on the TVM project, but with a more global flag, like
set(CMAKE_C_COMPILER_LAUNCHER /path/to/ccache)
set(CMAKE_CXX_COMPILER_LAUNCHER /path/to/ccache)
set(CMAKE_CUDA_COMPILER_LAUNCHER /path/to/ccache)

What's the difference between your approach (set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ) and the one above?

Thanks @electriclilies . One thing that might be helpful here is to streamline the definition. The current proposed option is closer to AUTO mode(enable if found, but disable if not).
The general possible usages here:

AUTO: automatically detect and if found use it
/path/to/ccache: set the ccache to the correct ccache path being specified
OFF: disable ccache
ON: search and report an error if ccache is not found

We should also look a bit into which way is more standard, since I also see set(CMAKE_C_COMPILER_LAUNCHER /path/to/ccache) being used a bit more frequently.

I agree with @tqchen about the CI. It's better to always build from scratch in CI.

Thanks for the feedback @tqchen @junrushao1994. I'll change the default to AUTO, as suggested, and disable this option in CI.
Regarding which is more common-- I don't know which approach is more commonly taken. One advantage to the approach I propose is that the user doesn't have to enter the path to the ccache, so they can take advantage of it without editing the CMakeLists file.

Thanks @electriclilies , by standard options, I actually meant

set(CMAKE_C_COMPILER_LAUNCHER /path/to/ccache) vs  set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE  /path/to/ccache)

seems they are two ways to do the same thing, but we are not sure

After some thought, I think that it is actually better to model the options in this case after the options for ROCM runtime, which looks like this:
# Whether enable ROCM runtime
#
# Possible values:
# - ON: enable ROCM with cmake's auto search
# - OFF: disable ROCM
# - /path/to/rocm: use specific path to rocm
set(USE_ROCM OFF)

How does this sound for the possible options?
# Possible values:
# - ON: enable ccache by searching for the path to ccache
# - OFF: disable ccache
# - /path/to/ccache: use specific path to ccache

I agree, in the case of rocm runtime, an error will be raised if rocm is ON and we did not found the runtime. So the current behavior is still closer to AUTO.
···
Possible values:
- AUTO: search for path to ccache, disable if not found.
- ON: enable ccache by searching for the path to ccache, report an error if not found
- OFF: disable ccache
- /path/to/ccache: use specific path to ccache
···

@tqchen @junrushao1994 I updated the options and changed the method of setting the path to ccache to set(CXX_COMPILER_LAUNCHER /path/to/ccache).  I'm not sure if you meant that I need to do that in addition to 'set(CMAKE_C_COMPILER_LAUNCHER /path/to/ccache)'

@tqchen @junrushao1994 This is passing, could you take a look and make sure I addressed all the comments?

I think the PR is in pretty good state. Just one question: Is it intended behavior to disable ccache in our CI? I thought we are using it right now

@junrushao1994
@tqchen said:

The use of ccache will likely cause the history cache growing problem in the CI when the node disk space is limited. Because the cost of build is normally smaller compared to testing, we will likely want to disable ccache in the CI setups in the task_config_build_xyz.sh https://github.com/apache/tvm/blob/main/tests/scripts/task_config_build_arm.sh

Based on this, it is my understanding that we do want to disable ccache in CI. I'm not sure whether we are using it right now. I think it would be good to double check that this is the intended behavior before it goes in given all the issues we've had with CI in the last week 😎

@tqchen @junrushao1994 Additionally, if I do make this change and we don't update the CI docker images, will ccache just be enabled on CI until the docker images are updated? That might be suboptimal if it does cause the memory usage to go up

Thanks Lily for the explanation! The PR looks good to me :-)


Compression

Would be nice to be able to transparently read/write gzip and bz2 since they're in the stdlib.

Easy enough to do on I/O, so lets drop this feature unless there's a compelling need.


RSpec disable_monkey_patching! mode compatibility

RSpec has introduced with 3.0 a mode to avoid to monkey-patching. It's a configuration disabled by default (see https://www.relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/zero-monkey-patching-mode).
This PR makes our generated specs for actions and views to play well with it.
Actual:
describe ... do
end

Wanted:
RSpec.describe do
end

/cc @lotus/core-team

:+1:


Wallet API Docs Improvements

Something fishy is going on

Yeah, I know. I'll finish it and then ask for a review hahah

Something fishy is going on

Yeah, I know. I'll finish it and then ask for a review hahah

Nevermind, it was an old preview. Looks good so far.


Fix uncurried Pekko Stream ops in javadsl

So I discovered this when using the javadsl within a kotlin project but it appears that many of the stream functions in javadsl are using their curried equivalents (i.e. limitWeighted(n: Long)(costFn: function.Function[Out, java.lang.Long]) vs limitWeighted(n: Long, costFn: function.Function[Out, java.lang.Long]),
This appears to be a massive oversight, as not only is this currently entirely inconsistent in the codebase (see fold vs foldWhile in Flow javadsl or fold in Source vs fold in Flow javadsl) but Java has no real concept curried functions and so applying curried functions written in Scala is not idiomatic. For Java the standard practice is to just have a single parameter list with the function as the last arg (and Kotlin also expects this).
There is also the case of watchTermination which had a zero arg curried implementation i.e. def watchTermination[M]()(matF: function.Function2[Mat, CompletionStage[Done], M]). I don't know if the zero arg was doing anything meaningful (afaik curried function application is strict so its not suspending the future unless you partially apply it), in any case I added a def watchTermination[M](matF: function.Function2[Mat, CompletionStage[Done], M]) variant so check if this is indeed correct and I am not messing a behaviour (if the future is meant to suspended in a thunk then we should just use java function).
@He-Pin @jrudolph @raboof Maybe you want to have a look at this PR since you are more intimate with the codebase, particularly wrt watchTermination and if its arg needs to be suspended or not

When using it from Java, it works, does it cause problems when using it from Kotlin? IDEA/Comping error? Does that affect the kotlin's trailing lambda?

So TIL, curried functions written in Scala appear as single parameter lists within Java so there isn't any actual problem its just that it really messes syntax highlighting/code completion in cross Scala/Java projects. Updating PR so that we only have a single version of the function without any deprecation's aside from watchTermination

When using it from Java, it works, does it cause problems when using it from Kotlin? IDEA/Comping error? Does that affect the kotlin's trailing lambda?

So its not a compile issue (since both versions are the same after erasure and the curried version is compiled into a single parameter list) but it does mess with code completion/syntax highlighting in IDE.
In any case I think this change is valuable since it makes it a lot more clear

I agree with this. It's better to make changes as soon as possible.

Pull request is ready, since MiMa has passed we have verification that generated bytecode is exactly the same, rather this feature improves quality of life for users (i.e. reading code, reading snippets taken from source code, generated docs from source etc etc)

Does this affect the library which compiles with pekko 1.0.x but be used where only pekko .1.1x in classpath? eg a runtime NoSuchMethodException.

In theory no - because the Mima checks are happy that the change is binary compatible.

For those that are concerned about MiMa, breaking binary compatible or proof that any combination of implicits/currying in Scala just gets converted to a flat parameter list in JVM bytecode, with the current version of
final class Builder[+Mat]()(private[stream] implicit val delegate: scaladsl.GraphDSL.Builder[Mat])

This .java source file compiles
package org.apache.pekko.stream.javadsl;

public class Test {
    void raw() {
        org.apache.pekko.stream.scaladsl.GraphDSL.Builder<Void> delegate = new org.apache.pekko.stream.scaladsl.GraphDSL.Builder<>();

        new GraphDSL.Builder<>(delegate);
    }
}

And if you change final class Builder to
final class Builder[+Mat](private[stream] implicit val delegate: scaladsl.GraphDSL.Builder[Mat])

It also compiles without any changes to the .java source. As mentioned before if there was an issue MiMa would have picked this up anyways

btw, why you don't use the Kotlin flow in a Kotlin project:)

btw, why you don't use the Kotlin flow in a Kotlin project:)

We are, I actually noticed this when using Pekko javadsl in a Kotlin project

I'm using pekko stream because kotlin flow lack some operators:)


Weird high CPU usage

I'm seeing some weird behaviour on my machine where rbenv appears to be using a lot of CPU out of nowhere.

Running ps -ef | grep bash gives me a bit more details about those bash processes:
  501  2710 86703   0  4:22PM ??         0:00.01 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-which ruby
  501  2789 86698   0  4:22PM ??         0:00.01 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-which ruby
  501  2892  2710   0  4:22PM ??         0:00.24 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-hooks which
  501  2967  2789   0  4:22PM ??         0:00.17 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-hooks which
  501 86698  1528   0  4:22PM ??         0:03.41 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-exec ruby -wc
  501 86703  1528   0  4:22PM ??         0:03.36 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-exec ruby -wc

Versions:

homebrew: 0.9.5 (git revision e1301; last commit 2016-02-16)
rbenv: 1.0.0
ruby: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]
os x: 10.11.3 (15D21)
atom: 1.5.3

I seem to be able to replicate the problem by modifying and saving a ruby-file in Atom editor by which you could argue that the problem lies within Atom and not rbenv, but it seems weird to me that rbenv would use this much CPU regardless of how it got triggered and from what process.

Have you just switched to Windows 10?
I've been noticing some oddly high CPU use-rates since I switched.  Also,
two apps have acquired an unpleasant new behaviour: running at their usual
fast speed when they have the machine to themselves, but occupying all the
machine's RAM, and slowing themselves and everything else down to a crawl,
if they are invoked later.
Jury's still out, but I suspect Windows 10, which is why I ask.
-dlj.
On 16 February 2016 at 10:34, Thomas Dippel<EMAIL_ADDRESS>wrote:

I'm seeing some weird behaviour on my machine where rbenv appears to be
using a lot of CPU out of nowhere.
[image: screen shot 2016-02-16 at 16 26 46]
https://cloud.githubusercontent.com/assets/171490/13080702/20b59d6a-d4ca-11e5-9ca4-14a46a410ea8.png
Running ps -ef | grep bash gives me a bit more details about those bash
processes:
501  2710 86703   0  4:22PM ??         0:00.01 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-which ruby
501  2789 86698   0  4:22PM ??         0:00.01 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-which ruby
501  2892  2710   0  4:22PM ??         0:00.24 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-hooks which
501  2967  2789   0  4:22PM ??         0:00.17 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-hooks which
501 86698  1528   0  4:22PM ??         0:03.41 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-exec ruby -wc
501 86703  1528   0  4:22PM ??         0:03.36 bash /usr/local/Cellar/rbenv/0.4.0/libexec/rbenv-exec ruby -wc
Versions:

homebrew: 0.9.5 (git revision e1301; last commit 2016-02-16)
rbenv: 1.0.0
ruby: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]
os x: 10.11.3 (15D21)
atom: 1.5.3

I seem to be able to replicate the problem by modifying and saving a
ruby-file in Atom editor by which you could argue that the problem lies
within Atom and not rbenv, but it seems weird to me that rbenv would use
this much CPU regardless of how it got triggered and from what process.
—
Reply to this email directly or view it on GitHub
https://github.com/rbenv/rbenv/issues/872.

No, I'm on Mac OS X: El Capitan - 10.11.3 (15D21)

OK, noted.  Thanks.
-dlj.
On 16 February 2016 at 12:31, Thomas Dippel<EMAIL_ADDRESS>wrote:

No, I'm on Mac OS X: El Capitan - 10.11.3 (15D21)
—
Reply to this email directly or view it on GitHub
https://github.com/rbenv/rbenv/issues/872#issuecomment-184788063.

I ended up completely removing rbenv, ruby-build and all the installed versions of ruby, then re-installing, which appears to have solved the issue.

Glad you solved your issue, and sorry for the late reply. This smells like it could have been the work of a rogue plugin. Rbenv itself is implemented in very lightweight and short-lived bash, and can't possibly consume significant amounts of CPU unless some plugin causes recursion.


Story 001 yarong 240

@tompaana I figured I would submit this as a PR to at least put some kind of end to this branch. :) Obviously the file name for BluetoothConnectionLimits.js is wrong since that wouldn't kick off a perf test but that was intentional since we don't want it to be run until we have actual code there.

PR is added to the queue for testing as 1. task. (d291820)

Test (Success) 52445159 build is completed (d291820)
See https://github.com/ThaliTester/TestResults/tree/52445159d291820_Story_001_yarong_240_yaronyg/ for the logs

Test 52445159d291820(d291820) has failed
See https://github.com/ThaliTester/TestResults/tree/52445159d291820_Story_001_yarong_240_yaronyg/ for the fail logs

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Error when including kint.phar in php 8.1

Kint::trace();
 Fatal error: Uncaught Error: Undefined constant "Kint\KINT_PHP56" in /var/www/html/php/vendor/kint-php/kint/src/CallFinder.php:144 Stack trace: #0 phar:///var/www/html/php/kint.phar/src/Kint.php(677): Kint\CallFinder::getFunctionCalls() #1 phar:///var/www/html/php/kint.phar/src/Kint.php(459): Kint\Kint::getSingleCall() #2 phar:///var/www/html/php/kint.phar/src/Kint.php(492): Kint\Kint::getCallInfo() #3 /var/www/html/php/world.php(112): Kint\Kint::trace() #4 [internal function]: shutdown_handler() #5 {main} thrown in /var/www/html/php/vendor/kint-php/kint/src/CallFinder.php on line 144
This is from the kint.phar found at https://github.com/kint-php/kint/raw/master/build/kint.phar just now.

@ipsod Sorry I'm so late, my mail client died and I didn't realize it.
Your problem seems to be that you have included kint twice. Once at /var/www/html/php/kint.phar and once at /var/www/html/php/vendor/kint-php/kint/
Normally that wouldn't be a problem, but these are also different versions, with the composer version being 3.x I'd guess (The phar is 4.0-beta1 and doesn't support 5.5 and below any more)
I'm guessing while the phar's init has been loaded the composer autoloader is taking precedence and loading the older code.
Can you confirm that only using one fixes it?

Ah, I see, thank you.


Question: Is it possible to get an HLS streaming session URL from a WebRTC stream?

I am developing a React Native mobile application and I am trying to find a way to stream video from a mobile device's camera so that it can be consumed by a third-party via an HLS endpoint. I also would like to be able to save the media for later playback.
By combining the react-native-webrtc module with the examples provided here, I was able to set up a WebRTC stream to a KVS signaling channel and view a video feed in the AWS console. However, I'd like to take this a step further, if possible. I'd like to create a direct link to this stream for real-time playback in a video player in a third party application. I'm thinking I may have misunderstood the functionality of Kinesis Video Streams. Is it possible to take that WebRTC stream and somehow convert it to an HLS stream, or are those two distinct use cases for Kinesis Video Streams without overlap? I've seen other paid services that list this capability, but I'd much rather leverage AWS for this if possible.

Currently, there is no way to achieve this out of the box. You might want to either end up with dual-streaming from the device (KVS stream + KVS webRtc) or have a client that does webrtc with the device and it turn produces KVS stream for HLS and persistence

Currently, there is no way to achieve this out of the box. You might want to either end up with dual-streaming from the device (KVS stream + KVS webRtc) or have a client that does webrtc with the device and it turn produces KVS stream for HLS and persistence

Ok, thank you for the quick reply. I'll keep looking.


missing_fat_arrows is_strict flags constructors

# CoffeeLint says this should have a fat arrow
class Okay
  constructor: ->

# CoffeeScript parser indicates an error
class Erroneus
  constructor: =>

This rule should be ignored for constructors, which can't use fat arrows.

ping @Zolmeister

on it

Thanks

Awesome, thanks for the quick response!


Unsure of force close reason

Background
Im curious as to why my node force closed a channel. I was unable to see any expired HTLCs. I've provided logs below.
Im not sure what other info needs to be included to get insights into why the channel could have been force-closed.
Things that i've noticed:

A bunch of stopping/starting of channel link
Channel was disabled at some point?

Your environment

LND v0.7.1
ubuntu
bitcoind

Sep 28 21:52:21 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is stopping
Sep 28 21:52:21 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) has exited
Sep 28 22:14:16 lnd_btc INFO [INF] NANN: Announcing channel(<-channel-id>:0) disabled [detected]
Sep 29 05:44:33 lnd_btc INFO [INF] PEER: NodeKey() loading ChannelPoint(<-channel-id>:0)
Sep 29 05:44:33 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is starting
Sep 29 05:44:33 lnd_btc INFO [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(<-channel-id>:0)
Sep 29 05:44:33 lnd_btc INFO [INF] HSWC: HTLC manager for ChannelPoint(<-channel-id>:0) started, bandwidth=2337672000 mSAT
Sep 29 05:44:33 lnd_btc INFO [INF] HSWC: Attempting to re-resynchronize ChannelPoint(<-channel-id>:0)
Sep 29 05:44:33 lnd_btc INFO [INF] HSWC: Received re-establishment message from remote side for channel(<-channel-id>:0)
Sep 29 06:03:33 lnd_btc INFO [INF] NANN: Announcing channel(<-channel-id>:0) enabled
Sep 29 11:35:33 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is stopping
Sep 29 11:35:33 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) has exited
Sep 29 11:35:36 lnd_btc INFO [INF] PEER: NodeKey() loading ChannelPoint(<-channel-id>:0)
Sep 29 11:35:36 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is starting
Sep 29 11:35:36 lnd_btc INFO [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(<-channel-id>:0)
Sep 29 11:35:36 lnd_btc INFO [INF] HSWC: HTLC manager for ChannelPoint(<-channel-id>:0) started, bandwidth=2260190000 mSAT
Sep 29 11:35:36 lnd_btc INFO [INF] HSWC: Attempting to re-resynchronize ChannelPoint(<-channel-id>:0)
Sep 29 11:35:36 lnd_btc INFO [INF] HSWC: Received re-establishment message from remote side for channel(<-channel-id>:0)
Sep 29 13:13:36 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is stopping
Sep 29 13:13:36 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) has exited
Sep 29 13:13:50 lnd_btc INFO [INF] PEER: NodeKey() loading ChannelPoint(<-channel-id>:0)
Sep 29 13:13:50 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is starting
Sep 29 13:13:50 lnd_btc INFO [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(<-channel-id>:0)
Sep 29 13:13:50 lnd_btc INFO [INF] HSWC: HTLC manager for ChannelPoint(<-channel-id>:0) started, bandwidth=2260190000 mSAT
Sep 29 13:13:50 lnd_btc INFO [INF] HSWC: Attempting to re-resynchronize ChannelPoint(<-channel-id>:0)
Sep 29 13:13:50 lnd_btc INFO [INF] HSWC: Received re-establishment message from remote side for channel(<-channel-id>:0)
Sep 29 14:22:37 lnd_btc INFO [INF] CNCT: ChannelArbitrator(<-channel-id>:0): force closing chan
Sep 29 14:22:37 lnd_btc INFO [INF] HSWC: ChannelLink(<-channel-id>:0) is stopping

This was likely the case of an HTLC timing out, all the logging in that path occur at the debug and trace levels. Do you not see any pending HTLCs within pendingchannels?

Otherwise, the other party may have triggered data loss protection, meaning they can't continue with the channel.

@wpaulino usually I see logs for HTLC expiration but apparently I missed them. Do you know what subsystem those logs come from?
ty for the info

CNCT in debug/trace, but trace can be spammy.

Closing this as ill need to investigate on my own. thanks for help @wpaulino @Roasbeef


Fix HxResponseHeader

For some reason this commit wasn't added to the previous PR 😫

The previous was broken


[pod_lib_lint] Add "analyze" option

Feature Request
Add "analyze" as an option to the pod_lib_lint action that maps to the "--analyze" option in CocoaPods.  The "--analyze" option was added to CocoaPods v1.6.1 on 2019-02-17 and triggers Xcode's built in static code analysis tool to be run as part of the lint.
Motivation Behind Feature

While creating or updating shared code in pods, running static code analysis can help to find more issues with the code that can be fixed before shipping.
Feature Description

This would be a purely optional parameter to pod_lib_lint that is backwards compatible.  The default behavior would be to not run the static analyzer which is the same as the current behavior.
Invoking pod_lib_lint with analyze: true in addition to other desired parameters would run the static code analysis tool.
pod_lib_lint(analyze: true)
Alternatives or Workarounds

The only workaround is to use the sh action and run the whole pod lib lint --analyze (plus other parameters) command.

Sounds useful. Are you up to creating a Pull Request for this?

Yes, I should be able to get this one done.  👍