[Invitation] The information about the number of made rides is too close to the invitation separator.

Environment: Android 8.0, HUAWEI P8.
Reproducible: always.
Build found: v1.0.539
Preconditions:
User is logged in as a passenger and got an invitation for a ride. 'Ride Homepage' is opened.
Steps to reproduce:

Go to 'Notifications';
Tap on the 'Notificarions' tab to open it.
Open the recieved ride invitation by tapping.
Verify that information about the number of made rides is far enough from the separator.

Actual result:
The information about the number of made rides is too close to the separator.
Expected result:
The information about the number of made rides is far enough from the separator.
User story and test case links:
E.g.: "User story
Test case"
Labels to be added:
"Bug" ("bug"), Priority ("pri: low")

Implemented


GEODE-7369: Deprecate SystemFailure Class

GEODE-7369
Deprecate SystemFailure class.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Ah, I was too late!


How to set delete rules

I want maintainerr to look at radarr and delete all movies that are unmonited.
Can i achieve this?

Yes, there's a rule 'Radarr - Is monitored'.


Macro diagnostics fixes

Clean up and fix the handling of source locations in diagnostics produced from macros, and test by adding a Fix-It to the AddBlocker macro that replaces the + with a -. For diagnostics that come from a macro, append message text saying which macro it came from.

@swift-ci please smoke test

Huh...
C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\llvm-project\llvm\lib\IR\DebugLoc.cpp(79): error C2429: language feature 'init-statements in if/switch' requires compiler flag '/std:c++17'


[DPE-3964;DPE-4044] spark-test package alpha version

This PR creates a first skeleton and functionalities to be used when testing Charmed Spark. In particular, it provides fixtures for creating and managing the different resources, such as:

K8s namespaces
spark8t Service Accounts
Pods with the Charmed Spark
S3 Buckets

More information in the readme associated.
An example of how fixtures can be used are available in the integration tests.

I have added a bunch of documentation and addressed the points raised. In particular, I have added the ability to retrieve logs in the class.


Fix stuff

Description
Fix mistakes
Issues Resolved
Nothing
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

The android app is still dramatically, catastrophically broken. This doesn't cover the half of it.

:D
Thank you so much!

Unfortunately I have to revert this, since the app is not usable any more in this state (sync doesn't work and starting a task results in continuous notification sounds.

Actually it seems like syncing (for dropbox and google drive) was broken by the other PR, so I'll have to revert them both for now I am afraid.

@penn5 that would be great! Thank you very much!


Improve the publish workflow and format

This consists of several tasks:

Change the nytimes_output.py to use DOM rather than generating HTML manually
Do not automatically write the HTML and SVG output to files - return as strings
In webapp.publish_nytimes_screen(), create a .zip file with these two files
Return download link

Fixed most of this.  The action creates a .zip file and returns it to the browser, which automatically downloads it.
Remaining issue: Even though the file is downloaded, the puzzle chooser dialog remains.  I would like to redirect to the main screen after this.


feat: add authorization policy for spoke -> hub DNS access

Description
Create an authorization policy from the spoke vpc to hub vpc to authorize the spoke to receive the DNS information from the hub, more details on the issue in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/issues/757
resolves https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/issues/757
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

Also, you could update readme in examples and at the root module about supporting different accounts for hub and spoke vpcs.

The hub and spoke delegated example (weekly test) is failing with a different than the one seen that prompted this PR, error is as follows:
Error updating the custom resolver to disable before deleting
Not allowed to disable custom resolver on hub VPC which has DNS resolution bindings.

Not sure if this is an issue with the terraform or a problem on the provider side but needs more investigation

/run pipeline

/run pipeline

The hub and spoke delegated example (weekly test) is failing with a different error than the one seen that prompted this PR, error is as follows:
Error updating the custom resolver to disable before deleting
Not allowed to disable custom resolver on hub VPC which has DNS resolution bindings.

Not sure if this is an issue with the terraform or a problem on the provider side but needs more investigation

Would you like a create an issue please? I think there might be some update to the provider and we may need to investigate the deletion flow.

https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/issues/776 created to track the aforementioned issue with the destroy


Dropdown doesn't move when keyboard is open

Here is search bar:

When you click on input, it opens dropdown with new input:

When you click on "Search", modal moves, but dropdown doesn't:

)
Here is the code:

When the dropdown hits the bottom border, the list will rotate up, your issue is that the keyboard covers the search box.
I'm working on it.

Now dropdown also moves, thanks!

But one problem: when you click on item, it isn't selected. Only the keyboard closes:

And you have to click on item one more time to select it.

![Снимок экрана 2021-10-13 в 12 06 17](https://user-images.githubusercontent.com/86955927/137102771-718123e0-a93a-4547-b317-830938b6c48b.png

)

latest version is 1.3.3?
And where I have to add LogBox.ignoreAllLogs(true)?
Import LogBox like Dropdown:
import { Dropdown, LogBox } from 'react-native-element-dropdown'
or put into the component:

?

@Pavel-Ananich hey bro, please share code full done fixed.. thanks


[Feat]: RelativeBy functionality from Selenium 4

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. I have radio buttons and check boxes next to text that contains automation IDs it would be nice to tell my app left of instead of creating automation IDs for checkboxes.
Describe the solution you'd like
Selenium 4 brought RelativeBy functionality. I would love to use that in appium.
Describe alternatives you've considered
Automation IDs everywhere on everything.
Additional context
I see lots of deprecation for newer Selenium functionality but not a whole lot of new and added functionality that Selenium should bring.

These locators rely on the native implementation. In case of selenium/browser automation it is easy to do something like that since under the hood they have css location. As a result, relative locators could easily be transformed into native ones.
There is completely different story on mobile platforms though. Neither XCTest nor UIAutomator frameworks implement the concept of relative locators. For us, as backend developers, this means we'd need to map such locators into xpath ones, as it is the only locator type, which supports the idea of search axes. It's not only failry complicated task, but also a slow one, since xpath is the slowest location strategy (it's completely "artificial" and is not supported natively, especially in case of XCTest, where various XPath locators may take 10x to 100x more time in comparison to native ones)

static members, what are not considered as inheritable? In any case we are open for any non-breaking changes (as quick win). Please propose your ideas, I don't see barriers for changes (breaking changes?..).

Ah, forgot to answer on your question. RelativeBy will not be abstract in discoverable future, it is concrete type. I don't see problems to make some parts as virtual.


Concatenate all compiled templates in a single file

Is it possible to concatenate all compiled handlebars in a single file?
I have tried using sbt-concat with:
Concat.groups := Seq(   "templates.js" -> group((WebKeys.webTarget in Assets).value / "hbs" / "main" / "templates" ** "*.js") )
However, it is not able to generate the concatenated file, providing the following warning messages:
[warn] Unable to process about.js. Not found. [warn] Unable to process account.js. Not found. [warn] Unable to process demo.js. Not found. ...
Could you please integrate this feature as a setting or help me generating the concatenated file?
Thanks for your help.

Hi, i got the exact same issue. Did you ever solve it?


How to get panoptic-toolbox？

Same question
Looking forward to your reply

Repo of CMU Panoptic toolbox: https://github.com/CMU-Perceptual-Computing-Lab/panoptic-toolbox
As I know, because download server is recently down, it does not work.
But now is open again. Please try again.

Have you successfully downloaded? I still can't download it, can you send me a copy? thank you very much indeed
------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/voxelpose-pytorch"                                                                                @.>;
发送时间: 2022年11月22日(星期二) 下午2:12
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/voxelpose-pytorch] How to get panoptic-toolbox？ (Issue #45)
Repo of CMU Panoptic toolbox: https://github.com/CMU-Perceptual-Computing-Lab/panoptic-toolbox
As I know, because download server is recently down, it does not work.
But now is open again. Please try again.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Update odata-representation.md

Addition about many-to-many with links. Every link is a new call if you're using for example PowerBI. The result is that it takes a very long time to retrieve and is resource hungry. A better way is to publish the many-to-many through a RESTService. Thanks

@lightpeak please sign the CLA.

Signed the CLA!

@lightpeak please sign the CLA.

Signed the CLA!

@joostverhoog please add comments/content when possible.

@lightpeak Thanks for the suggestion, but we have decided to not merge this for the following reasons:

"Each link is a new call" is not accurate
This document is about representation of OData, but your suggestion is about implementation
We do not want to document for a specific user scenario in regards to a third-party tool like PowerBI
Cheers.

True but info on how to expose multiple multiple references to a BI tool is relevant and not only for Microsoft BI.

@RCatersels please see first point as main reason for not merging. We would push this info towards the Forum rather than documentation.


Fix logic that touches registry to be very robust

We need to install a .NET Profiler via the registry for some PerfView operations.
We were not being agressive enough to clean up even, if things are partly wrong.
This can leave stale state behind.  This improves the robustness.

Codecov Report

Merging #435 into master will increase coverage by <.01%.
The diff coverage is 1.4%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   17.53%   17.53%   +<.01%
==========================================
  Files         213      213
  Lines      122865   122876      +11
  Branches    11837    11837
==========================================
+ Hits        21541    21544       +3
- Misses     100465   100474       +9
+ Partials      859      858       -1

Flag
Coverage Δ

#2017
17.53% <1.4%> (ø)
:arrow_up:

#Debug
17.53% <1.4%> (ø)
:arrow_up:

#Release
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/PerfView/CommandProcessor.cs
0.17% <1.4%> (+0.04%)
:arrow_up:

src/PerfView/StackViewer/StackWindow.xaml.cs
24.14% <0%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf990...9d36ccc. Read the comment docs.

Codecov Report

Merging #435 into master will increase coverage by <.01%.
The diff coverage is 1.4%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   17.53%   17.53%   +<.01%
==========================================
  Files         213      213
  Lines      122865   122876      +11
  Branches    11837    11837
==========================================
+ Hits        21541    21544       +3
- Misses     100465   100474       +9
+ Partials      859      858       -1

Flag
Coverage Δ

#2017
17.53% <1.4%> (ø)
:arrow_up:

#Debug
17.53% <1.4%> (ø)
:arrow_up:

#Release
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/PerfView/CommandProcessor.cs
0.17% <1.4%> (+0.04%)
:arrow_up:

src/PerfView/StackViewer/StackWindow.xaml.cs
24.14% <0%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf990...9d36ccc. Read the comment docs.


Workflow run for .czi files is slow!

Reference: https://github.com/glencoesoftware/bioformats2raw#performance


RuntimeError: Caught RuntimeError in replica 0 on device 0.

Number of trainable parameters = 110197407
0%|          | 0/18140 [00:00<?, ?it/s]Didn't find an RNG file, if you are resuming a training that was launched in a distributed fashion, reproducibility is not guaranteed.
Traceback (most recent call last):
File "main.py", line 305, in
main()
File "main.py", line 202, in main
trainer.train(
File "/root/miniconda3/lib/python3.8/site-packages/transformers/trainer.py", line 1543, in train
return inner_training_loop(
File "/root/miniconda3/lib/python3.8/site-packages/transformers/trainer.py", line 1791, in _inner_training_loop
tr_loss_step = self.training_step(model, inputs)
File "/root/miniconda3/lib/python3.8/site-packages/transformers/trainer.py", line 2539, in training_step
loss = self.compute_loss(model, inputs)
File "/root/miniconda3/lib/python3.8/site-packages/transformers/trainer.py", line 2571, in compute_loss
outputs = model(**inputs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 171, in forward
outputs = self.parallel_apply(replicas, inputs, kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 181, in parallel_apply
return parallel_apply(replicas, inputs, kwargs, self.device_ids[:len(replicas)])
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 89, in parallel_apply
output.reraise()
File "/root/miniconda3/lib/python3.8/site-packages/torch/_utils.py", line 644, in reraise
raise exception
RuntimeError: Caught RuntimeError in replica 0 on device 0.
Original Traceback (most recent call last):
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 64, in _worker
output = module(*input, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/workspace/bin/multimodal_transformers/model/tabular_transformers.py", line 114, in forward
outputs = self.bert(
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/transformers/models/bert/modeling_bert.py", line 1012, in forward
embedding_output = self.embeddings(
File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/transformers/models/bert/modeling_bert.py", line 236, in forward
embeddings += position_embeddings
RuntimeError: The size of tensor a (1487) must match the size of tensor b (512) at non-singleton dimension 1

Hi @LinXin04 could you offer some context on this error? Is this the example code provided or is it your own? If the latter, could you share the snippet?

Closing due to inactivity.


Problem with .env when doing shopify requests by browser.

Hello guys.
I get stuck in the lesson 12   because the Shopify Graph Api was rejecting my requests:

After some investigation,  I notice  the "x-shopify-storefront-access-token" was undefined.
Next.js does not pass env variables to the browser now, except if it's prefixed with NEXT_PUBLIC_... everything works
after I changed the env to:
NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN
NEXT_PUBLIC_SHOPIFY_ACCESS_TOKEN

Hey thanks for that Guilherme!


Simple support for location

Currently just adds support for adding a location but nothing useful with them.
The next two steps are to support updating metadata from a location, then to support pulling files from a location.
There's technical debt added here in that we'll be assuming that all locations correspond to file paths.  That should be ok for the next bit while we get useful locations sorted and refine the interface that any location driver needs to support, leaving us to think about more interesting things like querying across them.

the happy path of outpack_location_add is only implicitly tested in "Can't add a location with existing name". Is this a deliberate choice to keep the test suite small/fast?

No, this is accidental from where I backed out the next steps (:facepalm:). Will add in some proper tests there.


BIGTOP-3877: add support for hadoop on openeuler

Description of PR
Add support for hadoop component, the point modifed is:

redhat-rpm-config should be instead of openEuler-rpm-config in openEuler.
The node-gyp 3.8.0 only support python2, but openEuler using the python3.

How was this patch tested?
docker run --rm -v pwd:/home/bigtop --workdir /home/bigtop bigtop/slaves:trunk-openeuler-22.03-aarch64 bash -c '. /etc/profile.d/bigtop.sh; ./gradlew hadoop-pkg'
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (BIGTOP-3877)
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@guyuqi
add the hadoop component

@MacChen01
Could you please add the JIRA number to the title of this PR like BIGTOP-3877: Add support for hadoop on openeuler ?
(https://issues.apache.org/jira/browse/BIGTOP-3877)

@MacChen01 Could you please add the JIRA number to the title of this PR like BIGTOP-3877: Add support for hadoop on openeuler ? (https://issues.apache.org/jira/browse/BIGTOP-3877)

ok, it's done.

LGTM, +1.

Merged to openEuler-support


feat: use simd if cpu supports

Major Changes

add vec version of distance_squared_l2, length, distance_cosine, distance_dot
add vectorization support check, if not supports, fall back to scalar compute

Vectorization support check
All vectorized operations rely on 128 bit register (f32x4), target feature should support it for vectorized operation

target_feature "neno" for arm and aarch64
target_feature "sse","sse2","sse3","ssse3","sse4.1", "sse4.2","sse4a" for x86 and x86_64

Test

Unit Test in mod distance_tests, difference between vec and scalar operation is less than 1e-5

Dependencies

portable_simd https://github.com/rust-lang/portable-simd

Compiler vectorization works on current codebase. Does it make sense to add a portable simd implementation?

Not sure is compiler vectorization enough for current use cases?

It generates compact AVX2 instructions on my platform. Not tested on a avx512 target or arm target so far.

I see. we could leave the pr for the future and did further investigation first.

The compiler struggles with auto-vectorize most of the time due to many constraints.
Let's take cosine distance for example:
I put the scalar version into godbolt (with -O enabled). The asm between line16 - line22 shows it did scalar op (ss) rather than packed op (ps). The main reason is bound checking for rhs (.LBB0_7) in every iteration. Additionally, lhs.len() can't be calculated up front, it also constraints auto-vectorization.
For performance, manual vectorization (portable-simd) might be necessary, but it's not an immediate necessity.
We can first optimize the current simd implementation. For example, can we substitute "a += b * c" with packed fma?
Let's try

@CyanPineapple
There are three reasons why your code is not vectorized.

You need perform a bound check manually, eg. assert_eq!(lhs.len(), rhs.len()).
You need use f*_fast intrinsics to allow optimizations based on algebraic rules.
You need add -Ctarget-cpu=x86-64-v3 to enable AVX2.

https://godbolt.org/z/hGWbTnP4r
You will see the main part of the code is compiled to compact AVX2 instructions.

Thanks. f*_fast did help. Applying the optimization to scalar version resulted in a 10x speedup in my benchmark.


fix(MOPLAT-490): Fix android unable to build issue

This PR resolves MOPLAT-490
Description

In summary: An update to RN (v0.71) caused lower versions to fetch 0.71 instead of their specified versions. Unfortunately our version still uses the gradle dynamic versioning pattern (i.e using + instead of specifying a specific version) so we ended up fetching v0.71. A patch for 0.66.* was released. This PR updates the version to that patch.

PR Checklist

[x] I tested my changes on iOS / Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[ ] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Fix android unable to build issue - kizito

Need help with something? Have a look at our docs, or get in touch with us.

Do we need Gradle clean and clean build folder on CI for the test-app-android and test-app-ios steps to pass?

Works fine at my ends. Will merge. We can always revert if folks find issues.


Performance issues in Database queries.

some Database queries are very slow causing app to slow down during I/O operations(as we noticed in schedule fragment before making is async) which need to be improved,
for example: DatabaseOperations.getSessionbySpeakersname()
no SQL joins were used in implementation and query count is very high.

@mananwason @the-dagger  check the commit 8268cd1 and let me know if its ok. will move ahead with the same code in other functions too.

@gogeta95 Looks good to me.
Did you face any bugs with this implementation of yours?
Also could you provide a sample apk for testing with your changes?

@gogeta95 Any Progress?

The app has moved to v2 in meantime. Open a relevant issue with reference to new app version if necessary.


TouchList is missing Symbol.iterator, can't use with 'for..of'

TypeScript Version:  3.6.0-dev.20190608

Search Terms: touchlist iterator
Code
let touches = new TouchList();
for (const touch of touches) {

}

Expected behavior:
Code compiles successfully.
Actual behavior:
Error on line 2:
Type 'TouchList' must have a '[Symbol.iterator]()' method that returns an iterator. ts(2488)
Playground Link:
N/A because the Playground complains due to for...of requiring --downlevelIteration--but there's no way to enable it.
Related Issues:
#2695, labeled help wanted but closed

Same thing happens for NamedNodeMap with --downlevelIteration:
for (let attribute of document.body.attributes) {
  console.log(attribute)
}

Type 'NamedNodeMap' is not an array type or a string type or does not have a 'Symbol.iterator' method that returns an iterator.

When evaluated in the Chrome console, the code successfully runs.

This is an old issue, but is this actually an issue given we have:
https://github.com/microsoft/TypeScript/blob/405251ebd2215f507bfd885d2519c52ffe2eda72/src/lib/dom.iterable.generated.d.ts#L308-L310
This was introduced by #24669, but that PR is a full year older than this issue, so I'm not sure what's going on here such that this error ever appeared.
(@fatcerberus I think you're still around, so I'm not gonna close this in case you recall what was actually going on and I'm just reproducing it wrong.)

@jakebailey I don’t recall; it might be that I didn’t have dom.iterable in my tsconfig or something (it was only recently that I found out that even existed).
It also seems weird that the playground required downlevelIteration for the for..of loop, for that matter… maybe in 2019 it only supported ES5 emit or something.

Ah, gotcha, yeah, one has to specify DOM.Iterable, it seems (the playground must). I guess I'm not well-versed enough to understand why that's not included by default, or if we should be hinting to users that "maybe you forgot this". @sandersn may know better than me, I'm just going over old issues looking for already fixed stuff!

I can't even repro this locally. What's the tsconfig look like? I tried target: "es5" and lib: ["dom", "es5"].

All I have is:
// @filename: tsconfig.json
{
    "compilerOptions": {
        "lib": ["es2016", "dom"],
        "target": "ES2015",
        "noEmit": true,
        "types": []
    }
}

// @filename: test.ts
let touches = new TouchList();
for (const touch of touches) {

}

I don’t think I have the project I was testing this in anymore, so I haven’t tested locally yet, but it’s still reproducible in the playground at least:
https://www.typescriptlang.org/play?downlevelIteration=true&target=1&module=0#code/CYUwxgNghgTiAEYD2A7AzgF3hpBXMAFiGgFzwAqehAMgJaYDcAUAGZIzwAUy6WtWSFtipE0ASngBvAL5MgA

Argh, I wrote for (const touch in touches). in

Anyway, there's a fixed list of constructors (Promise, Symbol, etc) in isES2015OrLaterConstructorName and in getCannotFindNameDiagnosticForName, some other values, that trigger a specific error. I didn't see anything smarter than that.
I don't know why dom.iterable is broken out from dom either. It was from before my time helping with DOM types.

Concretely, my questions are just:

Is this issue closable, given it works when you include DOM.iterable?
What's the deal with DOM.Iterable anyway?

Probably, it's because the DOM types are not split apart by ES versions as there's no mechanism to do so?

Yes, I guess so. We could do better on missing lib errors, but I'm not sure how (cheaply, at least).
I don't understand why iterable is the dividing line (or, a dividing line) though.

I always assumed the reason dom.iterable was split out is because it involves Symbol.iterator, which can’t (to my knowledge) by polyfilled correctly in ES5.

That's my guess, yeah, it's just that unlike setting say, es6 or es2017 or something, it doesn't actually get enabled automatically...

Concretely, my questions are just:
* Is this issue closable, given it works when you include `DOM.iterable`?

* What's the deal with `DOM.Iterable` anyway?

  * Probably, it's because the DOM types are not split apart by ES versions as there's no mechanism to do so?

Currently it doesn't seem to work even with DOM.Iterable in lib. 🤔


World generation noise is disconnected from the biome map, causing really bad world generation.

Version of Advanced Rocketry
AdvancedRocketry-1.12.2-1.7.0-208-universal.jar
Have you verified this is an issue in the latest unstable build
As stated above, I am using the as of the 14th march 2020 latest build, 1.7.0-208.
Version of LibVulpes
LibVulpes-1.12.2-0.4.2-74-universal.jar
Version of Minecraft
1.12.2-forge1.12.2-<IP_ADDRESS>47
Does this occur without other mods installed
Yes, it does.
Description of the problem
If I input several biomes, the vertical and horizontal noise scaling gets mixed. Like, if I have a plains biomes which uses dirt blocks, and a hills biome which uses granite blocks, dirt blocks will spawn in the hills biome and granite blocks will spawn in the plains biome. The vertical and horizontal scaling seem to be uncoupled from the biome. This means that only single biome planets make sense, or planets with biomes with the same biome height generation. It also makes creating modpacks with custom planets really really hard.
This has been a thing for many versions now. The only solution would be to use some kind of external dimension mod and dimmap it, but 1. you would loose the custom skybox that way, and 2. afaik there are no such mods, to my knowledge JED can't do that. And even if it could, it would still be a bandaid fix, it should be in AR by default.
If you don't know what I mean, here's an example:
(disregard the wrong blocks please, that's an issue with BiomeTweaker)

There are 4 biomes assigned to this planet (Mars) currently. Mars Plains, Mars Mountains, Mars Canyons, Mars Poles. In this case, as JourneyMap currently shows it, I'm in the Mars Poles biome. It's a custom BiomeTweaker biome, but it's based off of the plains biomes. It doesn't look like plains in the slightest. The vertical scaling is way too extreme...I don't need to explain how this isn't a plains biome.
Also, I am 100% sure that it's not a BiomeTweaker bug; it happens with vanilla, BOP and biomes from other mods too.
A similar bug report seems to exist already, but it's very old and has no replies besides an automated github reply telling that it is, indeed, an old thread.
While I usually am against duplicate bug reports, because they create more clutter, this is an exception; it's a bug that needs urgent fixing, because it removes the ability for modpack devs to be able to create good custom planets.
This needs to be fixed as quickly as possible.

This seems like a really bizzare issue.  I've created a ton of planets with multiple biomes and have never run into anything like this save a few bugs with the terraformer.
Can you replicate this with vanilla biomes and without biome tweaker?

I've mentioned this before in the linked issue with a world that uses only ocean, mushroom islands and mushroom shore, but I can test this with the latest version if you'd like

<planet name="Ross 128 b" customIcon="EarthLike">
			<isKnown>false</isKnown>
			<orbitalDistance>90</orbitalDistance>
			<orbitalTheta>20</orbitalTheta>
			<orbitalPhi>40</orbitalPhi>
			<skyColor>0.7,0.8,0.1</skyColor>
			<fogColor>0.7,0.8,0.2</fogColor>
			<atmosphereDensity>120</atmosphereDensity>
			<rotationalPeriod>250000</rotationalPeriod>
			<gravitationalMultiplier>110</gravitationalMultiplier>
                        <biomeIds>minecraft:mushroom_island,minecraft:mushroom_island_shore,minecraft:ocean</biomeIds>
			<OreGen>
				...
			</OreGen>
		</planet>

Testing with Advanced Rocketry 1.7.0-208 for 1.12.2 and LibVulpes 0.4.2-74.
It should be noted that beyond oceans there are a lot of biomes that have an effect on height in Vanilla Minecraft like Extreme Hills, Plains, Swamps, etc.
I did have Biome Tweaker installed, but it shouldn't be doing anything theoretically as I haven't configured any biomes. Just in case, however, I decided to run a second test without Biome Tweaker or Biomes O' Plenty.

Well, the good news is that AR is compatible with Biomes O' Plenty I guess.
(Offtopic but, the biomes on this planet seem really small for some reason. I feel like the ability to customize some biome noise parameters would be nice just so when you're making a planet with oceans you don't get tiny little lakes of Deep Ocean)

This.. uh... might be related.

Nvm, I remember why now

Narrowed the issue down to ChunkProviderPlanet somewhere.  Confirmed it's not ChunkManagerPlanet

getBiomesForGeneration vs getBiomes RIP.
It's fixed now so whatever.


Which version of Deep Layer Aggregation (DLA) was used?

From the code in model.py, I could not find out which version of the Deep Layer Aggregation architecture was used for the Sat2Graph model. In your paper I see only mentioned that you used residual blocks for the aggregation function.
Did you use one of the versions presented in the DLA paper or did you implement an architecture of your own?

From the code in model.py, I could not find out which version of the Deep Layer Aggregation architecture was used for the Sat2Graph model. In your paper I see only mentioned that you used residual blocks for the aggregation function.
Did you use one of the versions presented in the DLA paper or did you implement an architecture of your own?

We didn't use their source code, instead, we implemented the model in Figure 4 of their paper https://arxiv.org/pdf/1707.06484.pdf.
You can find the code here.
I didn't see too many implementation details in their paper about this architecture (maybe I missed it). In our implementation, we use residual blocks in the 'aggregation node' and we use deconvolutional layers for the '2x upsampling'.


Bump Go to 1.20

We're currently using go 1.18. See the release notes for the following versions:

1.19
1.20

My favorite tidbits:
Runtime

On Unix operating systems, Go programs that import package os now automatically increase the open file limit (RLIMIT_NOFILE) to the maximum allowed value; that is, they change the soft limit to match the hard limit. This corrects artificially low limits set on some systems for compatibility with very old C programs using the select system call. Go programs are not helped by that limit, and instead even simple programs like gofmt often ran out of file descriptors on such systems when processing many files in parallel. One impact of this change is that Go programs that in turn execute very old C programs in child processes may run those programs with too high a limit. This can be corrected by setting the hard limit before invoking the Go program.

Vet

The vet tool now reports use of the time format 2006-02-01 (yyyy-dd-mm) with Time.Format and time.Parse. This format does not appear in common date standards, but is frequently used by mistake when attempting to use the ISO 8601 date format (yyyy-mm-dd).

Errors

The fmt.Errorf function now supports multiple occurrences of the %w format verb, which will cause it to return an error that wraps all of those error operands.

Context

The new WithCancelCause function provides a way to cancel a context with a given error. That error can be retrieved by calling the new Cause function.

crypto

crypto/rsa now uses a new, safer, constant-time backend. This causes a CPU runtime increase for decryption operations between approximately 15% (RSA-2048 on amd64) and 45% (RSA-4096 on arm64), and more on 32-bit architectures. Encryption operations are approximately 20x slower than before (but still 5-10x faster than decryption). Performance is expected to improve in future releases. Programs must not modify or manually generate the fields of PrecomputedValues.

crypto/tls: Parsed certificates are now shared across all clients actively using that certificate. The memory savings can be significant in programs that make many concurrent connections to a server or collection of servers sharing any part of their certificate chains.

Core library

The sync/atomic package defines new atomic types Bool, Int32, Int64, Uint32, Uint64, Uintptr, and Pointer. These types hide the underlying values so that all accesses are forced to use the atomic APIs. Pointer also avoids the need to convert to unsafe.Pointer at call sites. Int64 and Uint64 are automatically aligned to 64-bit boundaries in structs and allocated data, even on 32-bit systems.

The new functions Bytes and String provide an efficient way hash a single byte slice or string. They are equivalent to using the more general Hash with a single write, but they avoid setup overhead for small inputs.

The new time layout constants DateTime, DateOnly, and TimeOnly provide names for three of the most common layout strings used in a survey of public Go source code.

I've updated the description a bit :)


TreeExplainer warning shows regardless of the perturbation setting

Describe the bug
When initializing a TreeExplainer without background data, a warning that the feature_perturbation setting is set to 'tree_path_dependent' shows regardless of whether the feature_perturbation setting is already set to 'tree_path_dependent'.
Setting feature_perturbation = "tree_path_dependent" because no background data was given.

Versions
Python 3.7.9
shap==0.35.0

I'll write up a PR over the coming days.

This is already addressed in PR #1267


feature: support multiple undo steps in drawing

How many undo steps do we want to store? The drawings are 3D volumes, so the RAM demands for each undo map is pretty extensive.

You could save the differences. Alternatively, drawings often compress well with one-pass run-length encoding like PackBits. Whatever method would be used to compress the data would need to be done very quickly, as one wants to save the current state when the user starts drawing a new line segment and we want to keep the drawing interactive.

@hanayik the latest commit to the drawing branch uses Packbits to compress undo maps. This supports 8-bit drawings (each voxel color 0..255). In practice this simple one-pass compression offers a factor x40 reduction in RAM usage.
The undo buffer is cyclical. The number of undo steps is set by maxDrawUndoBitmaps (currently 8). My analogy for this is the number of chambers in a revolver. Once you exceed this number of undo steps, you go back to the drawing prior to the initial undo selection. This allows the user to undo an accidental undo.


upgrade hyparquet to 1.6.0 and hightable to 0.7.1

I opened https://github.com/hyparam/hyparquet/pull/44 to fix the types. So: it will be 1.6.1, not 1.6.0

Approved hyparquet pr, also just published hightable 0.7.2 with a re-rendering fix.

Done

Still missing: upgrade in the demos

OK, demos updated


Realtime consumption halted if segment state transition fails

We observed some realtime ingestion lag on one of our Pinot clusters. After some investigation we determined that the lag was happening on a subset of the partitions for the Kafka stream we were ingesting from.
Analyzing the logs showed that this was caused by a temporary ZooKeeper connection issue that caused a cascade of InterupptedException and this caused some segment state transitions from OFFLINE to CONSUMING to fail.
Some relevant log messages:
2021/11/30 01:55:15.334 WARN [ZKHelixManager] [HelixTaskExecutor-message_handle_STATE_TRANSITION] zkClient to [redacted] is not connected, wait for 10000ms.

Exception while executing a state transition task [redacted segment name]
    ...
    Caused by: java.lang.RuntimeException: InterruptedException when acquiring the partitionConsumerSemaphore for segment: [redacted segment name]

2021/11/30 01:55:15.334 ERROR [HelixTask] [HelixTaskExecutor-message_handle_STATE_TRANSITION] Exception after executing a message, msgId: 76da755d-4ae3-4d61-84e6-11a946f6bffcorg.I0Itec.zkclient.exception.ZkInterruptedException: java.lang.InterruptedException
    org.I0Itec.zkclient.exception.ZkInterruptedException: java.lang.InterruptedException
            at org.apache.helix.manager.zk.zookeeper.ZkClient.acquireEventLock(ZkClient.java:1142)
    ...

The end result was that consumption stopped for the partitions represented by these segments that had failed state transitions.
In order to get the servers to start consuming for those partitions again we had to restart the servers hosting those segments. The expectation is that Pinot should be able to eventually recover and start consuming again once the ZooKeeper connection is available again.

+1 on this. We experienced this issue as well when there is a Zookeeper issue a couple of weeks ago. Tried to reset/reload the segment, but it went back into the bad state.

Ideally calling segment reset endpoint on controller should fix the problem and you shouldn't need to restart the server. I just looked into the code for consuming segments and found the issue that prevents segment reset doing its job. I'll create the PR for the fix soon.

PR for the fix: https://github.com/apache/pinot/pull/7886


[Feature]: .gitignore in the Nix Flake template

What's missing?
Thank you for jupyenv. It looks very awesome.
I'm new to Jupyter. Presently trying to setup a project to learn it. As I learn I use Git to track my progress. What should I put in the .gitignore file? I did some quick search and looks like .ipynb_checkpoints and */.ipynb_checkpoints/*. But should .jupyter/ directory also go there?
Possible solution
Once we can figure this out, I guess it would be nice to include a recommended .gitignore file in a template.
Alternatives
No response
Additional context
No response

PR is welcome!


[WIP] Sidebar/File Navigator

Currently a work in progress with a few things to get ironed out. I thought I'd open this PR just to get some initial feedback and/or suggestions regarding the UI, UX and the overall implementation.
Right now i'm just letting the user choose either a folder or file. If they choose a file, just open it as per usual, if they choose a folder then we render the contents of that folder into the sidebar.
The default system folder icon is being used, and the file icons are the specific icons for that file type using the NSWorkspace.shared.icon(forFileType: item.fileType) method. These can be changed to custom icons, along with the disclosure arrows next to the icons.
Still Todo

[ ] Sync the structure (expanded/collapsed/selected) of each windows sidebar. Currently when a file is opened in a new tab, the root folder is collapsed
[ ] Possibly restore sidebar folders when the app it quit and relaunched

Thoughts on behaviour
Currently when a file is clicked on it opens into a new tab (unless it is already open in the current tab). This mimics apps like Sublime Text and VS Code, although more native apps like Xcode (when tabs are open) open the selected file into the current tab. I'm not sure what a better user experience is, but since files aren't autosaved, opening a file into the current tab may not work the best.
Also, each window/tab has its own instance of the sidebar. This is a side effect of creating a new window per document and not much can be done at the moment about this. As a result, memory usage is increased for each new tab. Although, a singleton is used for the actual sidebar data so the complexity there is reduced slightly.
As discussed in #142 this is just a basic implementation to get a file tree rendering in a sidebar. Changes will probably have to be made later for when/if core gets support for workspaces.
Screenshot of current UI

Closes #142
Closes #156

Very cool @lukakerr, I'll give this a proper look in the next day or so. 🎊

What's the status on this?

The only thing left to do is sync the sidebar structure (which items are expanded/selected etc) across tabs. I haven’t had much time to work on it due to uni work though, but I haven’t forgot about it

Regarding general UX, one bit that I like in atom is that when I single-click on a file in the sidebar it opens a transient "preview" tab for it, or replaces the current "preview" tab if there is already one. Then, if I make an edit in that file, it turns that into a regular (persistent) tab. If I double-click instead, it opens a persistent tab directly. This is a nice way to avoid an unwieldy number of tabs cropping up quickly, as often I just want to skim through a few files to either find some section of the code or to look up details on something. Of course liberal use of ripgrep and RLS definitions could work to the same effect, but definitions require me to already know an exact name to type and ripgrep requires a context switch to a terminal (and is not necessarily the most intuitive solution for people accustomed to GUIs).
Just something that came to mind, perfectly fine with this getting ignored or postponed.

@lukakerr @cmyr, this is incredible! I'm with @nangtrongvuon, when this gets merged I'll be piloting xi as a vscode/atom replacement.
I built the project and have a few usability thoughts.
Single click/ Double click
Atom has an interesting strategy for this, the current tab is only replaced when the file previously open was also opened with a single click, otherwise the new file is opened in a single tab. Probably there are two modes for a tab: view and edit. Double click on the file in the sidebar or on the filename in the tab indicates the file is in edit mode. Edit mode tabs are never replaced by newly opened files, View mode tabs on the other hand are always replaced. Hope this helps.
Sidebar across tabs
Sidebar state should be synced, and if possible the data structure that indicates the status should be shared. Also, when a new folder is opened in the sidebar, it's default should be expanded.
Sidebar hide/show
The animation to show the sidebar cuts off part of the open file before it slides right.
Hopefully that's helpful, thanks for all your hard work!

any update?

@daleione I've been pretty busy at uni to work on this. That said, I've actually implemented the sidebar structure syncing between tabs in my own editor project Pine. So, i'll try to at least get the conflicts resolved and the sidebar structure syncing working in the next few days.
Apart from that, there are still a few minor things to fix up. Notably, the 'replace current document in tab' behaviour (similar to Xcode's behaviour) doesn't exist. This is because xi core doesn't (from my understanding) support file changes in the background without saving the file. So for the meantime, a new tab is created when a document is opened from the sidebar. This behaviour might also need to be worked on to iron the specifics out.

I'm interested in adding a request to this discussion, although I'm not sure if this belongs in a new feature request: having the file navigator on the right side instead of the left side.
The reason I personally like this is because when opening/closing the sidebar, instead of pushing the code to the side or pulling it back, it just cuts off or reveals the "back part" of the code.
I'm not sure how hard it would be to implement this, but it would be great if you could choose which side to have your sidebar on :)
Who knows, maybe someone likes it on the top of their window (although that might be getting a little out of hand 😬 ).


document options argument

fix #49

:+1:

@dbu Should we have an UnkownOptionException in the contract?


Paths aren't cleaned prior to adding

I keep on getting double slashes (//) in project paths being added, and then the same project with the correct path is also added when opening another file from within the same project.
See screenshot for neogit below:

I think it would be more robust to always clean the path prior to adding it to the list of projects. By "clean" I mean eg remove duplicate path delimeters, remove relative paths from within the path specification etc
eg: the following are all duplicate:

/home/steve//src/project
/home/steve/src/../src/project
/home/steve/foo/../src/project
/home/steve/src/project

Further details:
It seems to happen when I first use telescope-file-browser to open ${HOME}, from which I navigate to a new project.
I have a special on_input_filter_cb function set to automagically change to ${HOME} when I type ~/ in the file_browser input box:
    extensions = {
      file_browser = {
        on_input_filter_cb = function(prompt)
          if prompt == '~/' then
            file_browser_change_dir(vim.loop.os_homedir())                <--- here I change the directory
          elseif prompt == '/' then
            file_browser_change_dir('/')
          end
        end,
      },

This is the function to change the directory:
  local file_browser_change_dir = function(path)
    local prompt_bufnr = vim.api.nvim_get_current_buf()
    local current_picker = action_state.get_current_picker(prompt_bufnr)
    local finder = current_picker.finder
    finder.path = path

    fb_utils.redraw_border_title(current_picker)
    current_picker:refresh(finder, { reset_prompt = true, multi = current_picker._multi })
  end

Worked out this was an issue in plenary


Express search multiple keywords/multiple fields

Default Express Entry List search functionality does not allow for searching for multiple fields simultaneously.
Example: Searching for 'John Doe' does not return a result, while searching for either 'John' or 'Doe' does return results.

Are both your first name and last name attributes added to the search index? Then this should be possible.

Yes they were both added to the search index.  Still was not working.  The controller would search for 'John Doe' rather than 'John' and 'Doe'.  Obviously 'John Doe' didn't exist as either a first or last name, hence the issue.

Ah, yes. That makes sense. Hmm. This sounds like an enhancement - I'm not sure a good way to do this without custom code.

No problem - we've fixed it, and will submit a pull request for you!

#7972

Thanks!


Bug: ".../nimble/host/include/host/ble_uuid.h:97:9: error: expected primary-expression before '.' token"

Problem Description
Using static const ble_uuid128_t gatt_svr_svc_sec_test_uuid = BLE_UUID128_INIT(0x2d, 0x71, 0xa2, 0x59, 0xb4, 0x58, 0xc8, 0x12, 0x99, 0x99, 0x43, 0x95, 0x12, 0x2f, 0x46, 0x59); from the NimBLE bleprph example will produce the error:
In file included from C:/.platformio/packages/framework-espidf/components/bt/host/nimble/nimble/nimble/host/include/host/ble_hs_adv.h:24,
                 from C:/.platformio/packages/framework-espidf/components/bt/host/nimble/nimble/nimble/host/include/host/ble_gap.h:32,
                 from C:/.platformio/packages/framework-espidf/components/bt/host/nimble/nimble/nimble/host/include/host/ble_hs.h:33,
                 from src/Bluetooth/bluetooth.cpp:9:
C:/.platformio/packages/framework-espidf/components/bt/host/nimble/nimble/nimble/host/include/host/ble_uuid.h:97:9: error: expected primary-expression before '.' token
         .u.type = BLE_UUID_TYPE_128,    \

Reason
The macro uses the wrong structure format.
Fix
Change the macros to
#define BLE_UUID16_INIT(uuid16)         \
    {                                   \
        .u = {                          \
            .type = BLE_UUID_TYPE_16,   \
        },                              \
        .value = { uuid16 },            \
    }

#define BLE_UUID32_INIT(uuid32)         \
    {                                   \
        .u = {                          \
            .type = BLE_UUID_TYPE_32,   \
        },                              \
        .value = { uuid32 },            \
    }

#define BLE_UUID128_INIT(uuid128...)    \
    {                                   \
        .u = {                          \
            .type = BLE_UUID_TYPE_128,  \
        },                              \
        .value = { uuid128 },           \
    }

what toolchain is it?

but what compiler is used, GCC? clang?  and what version

It´s GCC and it should be version 8.4 if I´m correct.

Can be closed. The solution is accepted.


Add a toggle to switch between list and calendar views

Summary of changes
Asana Ticket: Add toggle between views to navigation
In desktop mode only, we can now switch between views:

Good catch! Fixing that.


Build fails with cargo xwin and a build script

I am not sure if this is an issue with cargo-auditable, or with cargo-xwin, but since the backtrace suggests the culprit is cargo-auditable, I have opened an issue here.
I am on Linux, with cargo/rustc 1.83.0, cargo-auditable 0.6.6, and cargo-xwin 0.18.2.
Trying to run cargo auditable xwin build --target x86_64-pc-windows-msvc fails with

error: linker flavor `lld-link` is incompatible with the current target
thread 'main' panicked at cargo-auditable/src/collect_audit_data.rs:79:9:
cargo metadata failure: error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/home/pigeonf/.local/share/rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc - --crate-name ___ --print=file-names -C linker-flavor=lld-link -Lnative=/home/pigeonf/.cache/cargo-xwin/xwin/crt/lib/x86_64 -Lnative=/home/pigeonf/.cache/cargo-xwin/xwin/sdk/lib/um/x86_64 -Lnative=/home/pigeonf/.cache/cargo-xwin/xwin/sdk/lib/ucrt/x86_64 --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
  --- stdout
  ___
  lib___.rlib
  lib___.so
  lib___.so
  lib___.a
  lib___.so
  /home/pigeonf/.local/share/rustup/toolchains/stable-x86_64-unknown-linux-gnu
  off
  packed
  unpacked
  ___
  debug_assertions
  panic="unwind"
  proc_macro
  target_abi=""
  target_arch="x86_64"
  target_endian="little"
  target_env="gnu"
  target_family="unix"
  target_feature="fxsr"
  target_feature="sse"
  target_feature="sse2"
  target_has_atomic="16"
  target_has_atomic="32"
  target_has_atomic="64"
  target_has_atomic="8"
  target_has_atomic="ptr"
  target_os="linux"
  target_pointer_width="64"
  target_vendor="unknown"
  unix

  --- stderr
  error: linker flavor `lld-link` is incompatible with the current target
    |
    = note: compatible flavors are: gnu, gnu-lld, gnu-cc, gnu-lld-cc, gcc, ld, ld.lld

  error: aborting due to 1 previous error

stack backtrace:
   0:     0x55f60f65764a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h304520fd6a30aa07
   1:     0x55f60f67bdeb - core::fmt::write::hf5713710ce10ff22
   2:     0x55f60f654c33 - std::io::Write::write_fmt::hda708db57927dacf
   3:     0x55f60f658f92 - std::panicking::default_hook::{{closure}}::he1ad87607d0c11c5
   4:     0x55f60f658bfe - std::panicking::default_hook::h81c8cd2e7c59ee33
   5:     0x55f60f65981f - std::panicking::rust_panic_with_hook::had2118629c312a4a
   6:     0x55f60f659507 - std::panicking::begin_panic_handler::{{closure}}::h7fa5985d111bafa2
   7:     0x55f60f657b29 - std::sys::backtrace::__rust_end_short_backtrace::h704d151dbefa09c5
   8:     0x55f60f659194 - rust_begin_unwind
   9:     0x55f60f5ce943 - core::panicking::panic_fmt::h3eea515d05f7a35e
  10:     0x55f60f6003c1 - cargo_auditable::collect_audit_data::compressed_dependency_list::hd31a25603145c6fa
  11:     0x55f60f5f5b04 - cargo_auditable::rustc_wrapper::main::h3f74493c52c04d0f
  12:     0x55f60f5fa93b - cargo_auditable::main::hb7812aa69da0b099
  13:     0x55f60f609083 - std::sys::backtrace::__rust_begin_short_backtrace::hc0e28afdd3f4133f
  14:     0x55f60f60a959 - std::rt::lang_start::{{closure}}::had016ce6569b8f7b
  15:     0x55f60f651510 - std::rt::lang_start_internal::h4d90db0530245041
  16:     0x55f60f5faa05 - main
  17:     0x7fdab583127e - __libc_start_call_main
  18:     0x7fdab5831339 - __libc_start_main_alias_2
  19:     0x55f60f5cf0be - _start
  20:                0x0 - <unknown>
error: could not compile `foo` (build script)

Caused by:
  process didn't exit successfully: `/home/pigeonf/.local/share/cargo/bin/cargo-auditable /home/pigeonf/.local/share/rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name build_script_build --edition=2021 build.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=262 --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=4a85d0794e518f95 -C extra-filename=-4a85d0794e518f95 --out-dir /tmp/tmp.zoyfG9Jc3O/target/debug/build/foo-4a85d0794e518f95 -C incremental=/tmp/tmp.zoyfG9Jc3O/target/debug/incremental -L dependency=/tmp/tmp.zoyfG9Jc3O/target/debug/deps` (exit status: 101)

I can only reproduce this when using a build script:

Create a new cargo project

cd $(mktemp -d)
cargo init --name foo

Verify that the command works without a build script

cargo auditable xwin build --target x86_64-pc-windows-msvc

Create a dummy build script and observe the command fail

$ echo "fn main() {}" > build.rs
$ cargo auditable xwin build --target x86_64-pc-windows-msvc
...
--- stderr
error: linker flavor `lld-link` is incompatible with the current target
  |
  = note: compatible flavors are: gnu, gnu-lld, gnu-cc, gnu-lld-cc, gcc, ld, ld.lld

error: aborting due to 1 previous error

I believe this issue resides with cargo-auditable interacting (or even just buildling?) the build script, but being unhappy with the linker set by cargo-xwin? I know nothing of either internals, but I found a weird workaround: running cargo-auditable once without cargo-xwin ensures that subsequent invocations of the full command work, at least until the build script is modified again.

In the same project as above (with the build script),  run cargo-auditable without xwin

cargo clean
cargo auditable check --target x86_64-pc-windows-msvc

Build with the full command again

cargo auditable xwin build --target x86_64-pc-windows-msvc # Works!
touch src/main.rs
cargo auditable xwin build --target x86_64-pc-windows-msvc # Works still!

After modifying the build script,  the full command fails again

$ touch build.rs
$ cargo auditable xwin build  --target x86_64-pc-windows-msvc
...
--- stderr
error: linker flavor `lld-link` is incompatible with the current target
  |
  = note: compatible flavors are: gnu, gnu-lld, gnu-cc, gnu-lld-cc, gcc, ld, ld.lld

error: aborting due to 1 previous error

I have confirmed that when using the workaround the created binary is actually runnable on windows, and cargo audit bin finds the auditable metadata in the binary, so it seems that the workaround actually works, and not just silently fails somehow.

Well, that looks like an intersection of cargo xwin, cargo auditable and Cargo's own caching. That's going to be fun to debug, I can already tell.
Could you also post the output of cargo +nightly config -Z unstable-options get in the sample project? I want to see if there are any local configuration values possibly affecting the build.

$ cargo +nightly config -Z unstable-options get
doc.browser = ["lemonade", "open"]
registries.kellnr.index = "sparse+http://kellnr.internal/api/v1/crates/"
# The following environment variables may affect the loaded values.
# CARGO_HOME=/home/pigeonf/.local/share/cargo

So nothing I think that is applicable


OCPBUGS-11119: Fixing the regexp used to get the correct GCC version.

The string representing the GCC version has changed between RHEL 8.6 and RHEL 9.2.
In 8.6 it looks like:
$ cat /lib/modules/<kernel version>/config | grep gcc
Compiler: gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-10)

In 9.2 it looks lie:
$ cat /lib/modules/<kernel version>/config | grep gcc
CONFIG_CC_VERSION_TEXT="gcc (GCC) 11.3.1 20221121 (Red Hat 11.3.1-4)"

Basically I have just removed the word Compiler from the regexp. All the rest is just cosmetics.

/jira refresh

/jira refresh

/retest
Looks like an infra error:
Error: error writing risk analysis json artifact: open /logs/artifacts/junit/risk-analysis.json: no such file or directory

/test ci/prow/e2e-aws

/test e2e-aws

/retest

/retest

/override ci/prow/e2e-aws-driver-toolkit-presubmit

/test e2e-aws

/test e2e-aws

/test e2e-aws


Remove Task#leftShift

Resolves #6266.

Yes!

I couldn't find a reference in the user guide, either. However, there's a warning about using it in https://guides.gradle.org/writing-gradle-tasks/ which, I think, we should just remove now.


[Migrate actions] Create edit release action

Description
As a maintainer, I need to edit a GitHub release, so that I can publish a draft release.
### Acceptance criteria
- [ ] I can call this action to publish an existing draft GitHub release

Impact to other teams
This impacts Adapters and Core since they are the primary consumers of these actions.
Proposals

named github/release/edit
inputs tag,is-draft

We have a PR with these contents already.


Remove unnecessary code.

See https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/937 on why this isn't needed anymore.

Isn't this still an issue for people who specify their own dockerfile?
On Wed, Sep 28, 2016 at 11:27 AM, João Martins<EMAIL_ADDRESS>wrote:

Merged #224
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224#event-805626377,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HaINCMNawcrhRgVyUYDZkqR5Pf3zks5quodXgaJpZM4KI7sL
.

Normally, the custom dockerfile users provide is based on one of the standard ones. So, it shouldn't be an issue for them.

Yeah but what about not normally?  Has anybody looked at the Docker issue
recently to see if they have a global fix for this coming?
On Wed, Sep 28, 2016 at 11:43 AM, meltsufin<EMAIL_ADDRESS>wrote:

Normally, the custom dockerfile users provide is based on one of the
standard ones. So, it shouldn't be an issue for them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224#issuecomment-250207058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HVoHZrYbvdhz21QRkaw13EplXvQiks5quostgaJpZM4KI7sL
.

It doesn't look like it's a Docker issue. My understanding is that it's just an issue with Jetty running under the jetty user that doesn't have access to the files.

https://github.com/jboss-dockerfiles/wildfly/issues/19
On Wed, Sep 28, 2016 at 12:05 PM, meltsufin<EMAIL_ADDRESS>wrote:

It doesn't look like it's a Docker issue. My understanding is that it's
just an issue with Jetty running under the jetty user that doesn't have
access to the files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224#issuecomment-250213950,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HeJJh_9gqDiszaQINmHRqitVQvF4ks5qupBAgaJpZM4KI7sL
.

Based off of that issue it seems like the right thing to do until it's
fixed is to continue to change the permission on the archive on the host
before we add it to the container.
On Wed, Sep 28, 2016 at 12:14 PM, Patrick Flynn<EMAIL_ADDRESS>wrote:

https://github.com/jboss-dockerfiles/wildfly/issues/19
On Wed, Sep 28, 2016 at 12:05 PM, meltsufin<EMAIL_ADDRESS>wrote:

It doesn't look like it's a Docker issue. My understanding is that it's
just an issue with Jetty running under the jetty user that doesn't have
access to the files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224#issuecomment-250213950,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HeJJh_9gqDiszaQINmHRqitVQvF4ks5qupBAgaJpZM4KI7sL
.

We're using the first workaround mentioned in that issue.

I still don't understand why this was triggered on windows though.

You are doing the 1st workaround by modifying the image.  We can solve this
problem for all our users by making sure we modify the file first.
On Wed, Sep 28, 2016 at 2:29 PM, Appu Goundan<EMAIL_ADDRESS>wrote:

I still don't understand why this was triggered on windows though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/224#issuecomment-250256689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5Ha3nL-3oaOWurYQhqeNWttKRsnqqks5qurH7gaJpZM4KI7sL
.

As a possible explanation, I found this: https://github.com/docker/docker/issues/783.  If I were to hazard a guess, perhaps the host OS for Flex did not have the AUFS fix earlier this year when we did our initial testing.


Add cancel button to cancel ion login

When the parameters for logging into Cesium ion are invalid, the login page does not redirect to the specified uri. This prevents the login page from resetting. Therefore, the cancel button simply navigates to the redirect uri.

Thanks for the pull request @joseph-kaile!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
Maintainers, here's how to check for a submitted CLA.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

Thanks again for your contribution @joseph-kaile!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.


Recommended articles block migration

Migrated block from adobe/blog to adobecom/milo
Refactored CSS
Refactored code

Resolves: Recommended articles
Test URLs:

Before: https://main--blog--adobecom.hlx.page/drafts/naguilar/recommended-articles?martech=off
After: https://main--blog--adobecom.hlx.page/drafts/naguilar/recommended-articles?milolibs=recommended-articles&martech=off

Hey @ninoaguilar
Two general things that I'm noticing right off the bat before reviewing.

Don't forget to add unit tests for your JS code
On first glance, it looks like you've copy-pasted the CSS code for the recommended articles off adobe.com. That's not something that we're really encouraging, so if you could just make sure that it's as concise as possible before the review, that would be great.

If you need any help getting tests set up btw, hit me up! :)

ok, I just talked with Chris and I hadn't realized you guys were on a bit of a time crunch.
Forget what I said about the CSS file - sorry for that!

Are we concerned with layout/styling details with this migration? Or, is the idea to migrate code then refine?
Just looking at the rendered blocks. They look like they need some love.

@saugatmalla you've got a few conflicts here.


fix(datepicker): fix dateFormat option generation

@cal-smith  was the console.log added on purpose?

That was definitely a mistake @imandyie ... I believe #612 removes that (in addition to a number of other fixes)


Bug: fatal crash from unhandled 'error' event

I'm submitting a ...
[X ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
When trying to connect to a Hyperdeck that does not exist at the specified IP address, an unhanded error is thrown, causing a crash.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
Error log:

`events.js:353
throw er; // Unhandled 'error' event
^
Error: connect ETIMEDOUT <IP_ADDRESS>:9993
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1146:16)
Emitted 'error' event on Hyperdeck instance at:
at Socket. (/Users/stephen/Developer/companion/module-local-dev/companion-module-bmd-hyperdeck/node_modules/hyperdeck-connection/dist/hyperdeck.js:53:45)
at Socket.emit (events.js:376:20)
at emitErrorNT (internal/streams/destroy.js:106:8)
at emitErrorCloseNT (internal/streams/destroy.js:74:3)
at processTicksAndRejections (internal/process/task_queues.js:82:21) {
errno: -60,
code: 'ETIMEDOUT',
syscall: 'connect',
address: '<IP_ADDRESS>',
port: 9993
}
`

This is kind of by design, try adding this to your code (I'll also update the README to clarify that this is needed), to catch any emitted errors.
myHyperdeck.on('error', (err) => {
    console.log('Hyperdeck error', err)
});

Hmm, I already have an error handler in our code:
https://github.com/bitfocus/companion-module-bmd-hyperdeck/blob/3da011613b536b0c8511c29028ca256ef7c7c5fb/index.js#L1011
Can you see any reason why this wouldn't be handling the error above?

When you recreate the socket you are also removing all the event listeners. It looks like we arent handling an in-flight connection attempt when doing the disconnect, and also you arent waiting for the disconnect to complete before removing the listeners, so an error can slip through there
https://github.com/bitfocus/companion-module-bmd-hyperdeck/blob/3da011613b536b0c8511c29028ca256ef7c7c5fb/index.js#L996 ?

The (or at least a) situation we have that is causing crashes is as follows:

Try to open a connection to a deck that does not exist on the network
Change the IP address, which causes the connection to be destroyed and re-created
Eventually, a timeout error comes back, but is not handled because the original connection was destroyed

I don't think there is any way that we can catch the error in 3, because we don't know that one will ever arrive. We can't wait for a disconnected event, because one of those will never arrive as a connection was never made.
So I think the hyperdeck-connection module needs to somehow handle the error in this scenario? Or when hyperDeck.disconnect() is called, any open connection attempts are terminated?
This is the code we are using to reset our connections:
		if (this.hyperDeck !== undefined) { 			this.hyperDeck.disconnect() 			this.hyperDeck.removeAllListeners() 			delete this.hyperDeck 		}

@sphlabs I have made a few changes to help with this:

the code now uses socket.destroy() rather than socket.end(). Hopefully that wont have side effects, the difference being we now fully close the socket, rather than close our half and let the other end gracefully do the same.
when disconnect() was called, if it hadnt reached the connected state, socket.end() was never called, which is likely why the error was being emitted. socket.destroy() is now always called here
Ive wrapped all the other emitted errors in a check to make sure that if disconnect has been called, they will be ignored

Please try with 0.5.0-nightly-latest-20220216-192753-87348bf.0

Great, that seems to have fixed things on this end -- at least for the scenarios I am aware of.


"No Such File Or Directory" On Step 2 of "Installing Tailscale" section of readme

Not sure if this was just my issue but I wasn't able to install tailscale following your instructions. I believe I followed the instructions accurately up through running the first script at \config\scripts\firstboot.d\tailscale.sh  when i tried to run the next script I got a "no such file or directory" error.
Router: EdgeRouter X
OS: EdgeOS v2.0.9-hotfix.7
notes: this is the first thing I did after factory reset + config via the basic setup wizard. connected over SSH from a windows11 cmd line.
Steps to replicate:

Follow steps 1 and 2 in the readme
hit enter on the last line from step 2 " /config/scripts/post-config.d/tailscale.sh"

I was able to get this installed after some troubleshooting.
I think the cause for the failure has to do with the certificate fix added in the last update to the script.
I started troubleshooting by trying to verify that the \config\tailscale\ path was created, which is one of the first step after the certs fix and the easiest thing to verify that any part of the script was successful The tailscale path had not been created despite not getting an error when running \config\scripts\firstboot.d\tailscale.sh.
Next I decided to run certificate fix outside of the script to see if I got an error and everything worked as it should despite the lines being identical.
Then I edited \config\scripts\firstboot.d\tailscale.sh to comment out the certificate fix section. the only other edit i made on the file was to change "set -e" to "set -x"  (the reason for that is I've got no real experience with shell and based on some quick + lazy googling I was hoping that would let me see more info on the output of the script so I could look for any errors)
start of the file after the edit was
#!/bin/sh

set -x

#sed -i 's|^mozilla\/DST_Root_CA_X3\.crt|!mozilla/DST_Root_CA_X3.crt|' /etc/ca-certificates.conf
#curl -sk https://letsencrypt.org/certs/isrgrootx1.pem -o /usr/local/share/ca-certificates/ISRG_Root_X1.crt
#update-ca-certificates --fresh

the rest of the file was unchanged.
Running the script again after those edits it worked the first time I ran it so unless nobody else can replicate this issue i think there may be an issue with the new section of the tailscale script
Please let me know if anyone is able to recreate this issue. attaching the SSH lines if anyone feels the need to check it for an embarrassing mistake on my part

Hey @JT-theDM, thanks for the incredibly detailed report! That's all very helpful.
It does sound like the changes for the certificate fix are causing set -e (which tells bash to exit when any command has an error) to exit the script early. An improvement here would be to add a trap to the script so it can output the error. It's odd that none of the commands are outputting an error of their own, though.
@haozhun would you mind taking a look at this as you said you tested the changes? Thanks!

In my original PR, I mentioned that I've verified that the fix is idempotent.
However, in reality, I did actually run into one issue when I repeatedly ran the steps.  However, it looks like that is not the case, considering that this report matched exactly the error that I ran into.
The issue is that /usr/local/share/ca-certificates/ directory somehow does not exist. As a result, curl fails.

It's odd that none of the commands are outputting an error of their own, though.

Indeed. Your commend reminded me to take a look at the curl options. Normally, one would do -sS in a script, so that curl is mostly silent if everything goes smoothly, but still print errors if something bad happens. In this case, I copy-pasted the command from the https://community.ui.com/questions/Fix-Solution-Lets-Encrypt-DST-Root-CA-X3-Expiration-Problems-with-IDS-IPS-Signature-Updates-HTTPS-E/0404a626-1a77-4d6c-9b4c-17ea3dea641d, and I didn't think about it. In this case, curl is ran with -s, so it's completely silent, which is a bad idea in general, and especially so in a script.
As I set out to change -s to -sS, I realize that the command is ran with -k (short for --inscecure). This bypasses https cert validation. That is a terrible terrible thing to put in this repo. It is understandable why it's there in the first place. The letsencrypt.org domain uses a TLS cert that is recursively signed by ISRG_Root_X1, therefore we need to break the circular dependency somehow. And adding -k is the simplest solution. Nevertheless, it is terrible.
Therefore, I request that you revert my previous commit.
I can think of two paths forward here:

(This is preferred if possible.) Is there a trusted 3rd party that hosts this pem file? If so, we should use that.
We can include the cert file in this repo. That means that all users are trusting you not to put some rogue cert file in here (so that you can MITM them). But if anyone is running your script anyways, they're probably trusting you already. And anyone who cared to read the script before running them can also check the file's authenticity by themselves.

Thank you very much for this detailed analysis!
You're right: -k is the simplest, but it's also terrible.
I think it would be acceptable to have a copy of the ISRG X1 root certificate in this repo and install it that way. It's a public certificate so it's easily verifiable.

Tried to install today to EdgeRouter 4 with EdgeOSv2.0.9-hotfix.7
Changed the curl command to this:
curl https://letsencrypt.org/certs/isrgrootx1.pem --create-dirs -o /usr/local/share/ca-certificates/ISRG_Root_X1.crt
Installed successfully.

I removed set -e from and it continued successfully. curl seems to work fine but returns non-zero, so the rest of execution is stopped.
Why doesn't set -e (or set -o errexit, or trap ERR) do what I expected?

In case anyone's still got a fresh enough system that can exhibit the problem can you help me verify if the curl is even needed?
On my ER4 it seems like the ISRG Root X1 cert is already present:
root@gw02:~# ls -l /usr/share/ca-certificates/mozilla/ISRG_Root_X1.crt
-rw-r--r--    1 root     root          1939 Jun  5  2020 /usr/share/ca-certificates/mozilla/ISRG_Root_X1.crt

And, as far as I can tell on this system (which is not a clean system), the sed and update-ca-certificates commands are enough, without fetching the newer X1 cert. On this system, the cert in /usr/share is identical to the one downloaded with curl.
If we can get away with removing the curl command from the setup script that will fix this.

I have that file as well
admin@EdgeRouter-4:~$ ls -l /usr/share/ca-certificates/mozilla/ISRG_Root_X1.crt
-rw-r--r--    1 root     root          1939 Jun  5  2020 /usr/share/ca-certificates/mozilla/ISRG_Root_X1.crt

Removed the curl completely and worked fine. EdgeRouter X v2.0.9-hotfix.7

Thanks for that confirmation. I've committed a change that removes the curl.


Selecting which sites to sync

Am i missing something, in the craft 2 version, you could select which locales to sync, whereas with the craft 3 version, as far as i can see, it syncs with all sites regardless, is that correct?
i have a scenario where i want to sync an entry only with one other site out of the 4 i have setup, is that possible? i need to be able to select which sites to sync.

@billymedia currently, content will sync with any sites that the current user has permission for, but there is no site-selection like in the Craft 2 version.
It is planned though, I just haven't had the need for it yet: https://github.com/timkelty/craftcms-site-sync/issues/19
You're the second person to ask, so I'll see if I can squeeze it in soon.
FWIW, you could approximate this by using different users, with different permissions. So when you want to sync 1/4 sites, log in as a user that only has permissions to the 2 sites (source and where you are syncing to). I know that's not what you want, but thought I'd mention it.
Follow along here: https://github.com/timkelty/craftcms-site-sync/issues/19


kapp uses wrong default namespace when run in-cluster (with explicit KUBECONFIG env var)

What steps did you take:

Prepare kapp/kctrl in a Pod of a Kubernetes cluster
set KUBECONFIG (and/or KAPP_KUBECONFIG) to another cluster where no default namespace is set
execute kapp ls or kapp deploy without a explicit namespace

What happened:
kapp will default to the namespace of the execution environment (pod it is running in), although the KUBECONFIG might point to a completely different cluster which doesn't have this namespace
What did you expect:
kapp will install the manifests into default namespace or the one explicitly configured inside the KUBECONFIG
Anything else you would like to add:
As a workaround it seems to explicitly unsetting KUBERNETES_SERVICE_HOST or KUBERNETES_SERVICE_PORT seems to fix this behaviour as https://github.com/kubernetes/client-go/blob/1517ffb8d37c99e6a3a2842bcdee0aa271f0332b/tools/clientcmd/client_config.go#L604-L609 seems to check for that (thanks to @cppforlife for pointing this out in Slack)
Environment:

kapp version (use kapp --version): kapp version 0.54.1
OS (e.g. from /etc/os-release): Debian 11 (doesn't seem to matter)
Kubernetes version (use kubectl version): not relevant

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

After some discussion in slack, it seems this is a behaviour introduced by the upstream k8s go client. kubectl shows the same behaviour as well. I'll close this as it is not really a problem of kapp


Feature request - auto dismiss.

Great app.
A small feature request - auto dismiss notification after playback ends.
If possible of course.
Thanks.

This is not possible because this module just enables it the way it is built into YouTube. YouTube includes background playback in your subscription of YouTube RED for $9.99 a month. It is just how it is. Please close this issue.


[Bug]-[1550]:When button group button or table column is deleted, linter does not pick up incorrect binding

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When a button group's button is used in a binding and this button is deleted, the linter does not recognize this incorrect binding
Steps To Reproduce

Use a button group's button (eg, button1) in a binding on a text widget like {{ButtonGroup1.groupButtons.Button1}}
Now delete this button on the button group widget - observe no error is picked up from this incorrect binding path and no lint error is displayed

Public Sample App
No response
Version
Cloud

@ramsaptami have you seen similar linting errors for other widgets?
Assuming 10% of users who update a button group widget face this issue
Stats

Stat
Values

Reach
75

Effort (months)
<>

This is probably the case even with a table widget's column @bharath31

Should users be using {{ButtonGroup1.groupButtons.Button1}} and {{Table1.primaryColumns.Column1}} ?
They are not exposed inside autocomplete because we do not want users to use them. They are just internal variables and they might change in future.

Agree with Satbir. Optional chaining would be the best way to handle failures here.


cdk8s synth - "ModuleNotFoundError: No module named 'constructs'

Description of the bug:
When we create a new folder, "cdk8s init python-app" (and if we add our code to create chart/webservice)  “cdk8s synth” works.. it creates dist/output.yaml
Whereas if we try to “cdk8s synth” on an existing folder (where we have main.py/webservice.py and cdk8s.yaml) we get imports error (ex: this example https://github.com/awslabs/cdk8s/tree/master/examples/python/web-service)
“cdk8s synth” on an existing folder (ex: download the above contents into a folder) we get imports error, if cdk8s synth would work only on a folder only when initialized
Getting ModuleNotFoundError: No module named 'constructs'
Detailed error:
$ cdk8s synth
Traceback (most recent call last):
File "./main.py", line 2, in
from constructs import Construct
ModuleNotFoundError: No module named 'constructs'
Error: command "pipenv run ./main.py " at /Users/REDACTED/Documents/Code/AWS/cdk8s/cdk8s/examples/python/web-service returned a non-zero exit code 1
at ChildProcess.child.once.code (/Users/REDACTED/.nvm/versions/node/v10.15.3/lib/node_modules/cdk8s-cli/lib/util.js:24:27)
at Object.onceWrapper (events.js:277:13)
at ChildProcess.emit (events.js:189:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
Reproduction Steps:

$ git clone https://github.com/awslabs/cdk8s
$ cd cdk8s/examples/python/web-service
$ pipenv install
$ cdk8s import --language python
$ cdk8s synth
Error Log:
Traceback (most recent call last):
File "./main.py", line 2, in
from constructs import Construct
ModuleNotFoundError: No module named 'constructs'
Error: command "pipenv run ./main.py " at /Users/REDACTED/Documents/Code/AWS/cdk8s/cdk8s/examples/python/web-service returned a non-zero exit code 1
at ChildProcess.child.once.code (/Users/REDACTED/.nvm/versions/node/v10.15.3/lib/node_modules/cdk8s-cli/lib/util.js:24:27)
at Object.onceWrapper (events.js:277:13)
at ChildProcess.emit (events.js:189:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
Environment:

Framework Version:
cdk8s --version - 0.27.0
python --version - Python 3.7.6
pipenv, version 2018.11.26

OS: MAC

Other:

This is :bug: Bug Report

The regular flow should be something like:
# install pipenv
pip install pipenv

# initialise virtual environment (inside the project's directory)
pipenv install

# run what you want from inside the virtual environment
pipenv run cdk8s synth

But seems that these examples are missing some required dependencies (fixed in the PR above.)

Thank you so much.
Tried another example with the fix.
Added the below packages (similar to your fix - commit)
[packages]
constructs = "==2.0.2"
cdk8s = "~=0.26.0"
Ran these:
$ pip install pipenv
$ pipenv install
$ cdk8s synth
dist/cdk8s.k8s.yaml


[FEATURE] able you to add bonus/penalty to Discipline rolls

if you have a temporary bonus to a discipline, You can’t add that to the roll.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This is planned to be added with issue #234


Add option to skip mounting tests

What do you think about giving the option not to mount the tests?
This came up because I have security scanners that are flagging the tests for XSS issues.  I haven't dug in to assess the specifics of those vectors, but in any case, I don't really want people running the tests on my production instance anyway.
Would this option be acceptable to you?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the pull-request! This is a sensible idea, I imagine lots of self-hosting users would prefer not to have the test-runner mounted.

Thanks for the quick turn around!


Add getops to script to provide user the ability to skip autoexpandin…

In the past I've commented out the part of the script that does the auto expanding using raspi-config.  I've updated the script to allow a user to skip this process by providing -s option using getops.
Let me know if you'd like me to change the copy in the README.md or the usage function inside the script.

👍

Thanks for the contribution!


Which specific coding standards are enforced?

Hello.  I realize WordPress Coding Standards is a set of rules for phpcs that can help detect violations of WordPress coding standards.  But to be clear, is your set of rules to help discover violations of just WordPress PHP coding standards?  Or WordPress PHP, JavaScript, and CSS coding standards?  Or something else?
phpcs claims to enforce violations of PHP, JavaScript, and CSS code standards.  And no part of your documentation seems to indicate otherwise.  So my assumption is that the rules set in WordPress Coding Standards also flags violations of WordPress PHP, JavaScript, and CSS coding standards.  But I just thought I'd ask before proceeding.
Thanks.

Your point is well-taken that it seems like CSS and JS are not well-represented explicitly here, even in documentation. Your inquiry here compelled me to spend an entire day researching exactly what WPCS does and does not do. It was time well-spent. Thanks. I'm hoping this thread can be a sort of "state-of-the-art" post from this point-forward. All of the other notes on this topic that I could find are 2+ years old.
;TL/DR; : It looks to me like WPCS does not and probably will not sniff for CSS or JS. The last recommendation in this tracker that I see is to use Stylelint and ESLint plugin.
From https://github.com/WordPress/WordPress-Coding-Standards/pull/1028#issuecomment-315245057 :

PHPCS is capable of sniffing PHP, JS and CSS files and has natively 70 sniffs available which can detect & fix issues in more than just PHP files (or specifically target one of the other types).
WPCS uses quite a few of these sniffs.
WPCS also contains a few sniffs which have specific features targetting JS and/or CSS ( VIP.AdminBarRemoval and the upcoming Classes.ClassInstantiation).

With a quick search I only found two sniffs that uses the CSS tokenizer, two for JS, and no reference to Squiz.CSS sniffs. However, it's possible that some of the sniffs being referenced from this codebase, but not themselves in this codebase, do use the CSS or JS tokenizers. Running a sniff from the command line with the -s option may help to reveal them.
I believe the following references would be of help (well, they were for me anyway) to clarify where this project is on the topic :
https://github.com/WPTRT/WPThemeReview rules (sniffs) to enforce WordPress theme review coding conventions
https://github.com/WPTRT/theme-sniffer plugin for WPTR plugin
Fascinating thread on what WPCS should include https://github.com/WordPress/WordPress-Coding-Standards/issues/1157 and a follow-up https://github.com/WordPress/WordPress-Coding-Standards/issues/1269. I include this because I don't see any mention of separating out PHP, JS, and CSS into their own set of sniffs within each proposed category - but I personally think that would be good.
From this blog referenced in this core.trac issue :

Working as a WordPress Engineer at Inpsyde—Germany’s biggest WordPress agency—I developed eslint-config-inpsyde, an ESLint config file specifically designed to follow current best practices and, at the same time, conform to the WordPress Coding Standards as best as possible.

Issue https://github.com/WordPress/WordPress-Coding-Standards/issues/39 was closed in 2013 on the note that "using a JavaScript-specific tool may be better, although it would require more configuration to get set up."
In 2017 https://github.com/WordPress/WordPress-Coding-Standards/issues/644 concluded:

I think we're better off deferring to Stylelint and ESLint, instead of trying to replicate all the checks in PHPCS, so I'll mark this as closed.

Stylelint is described:

Configuration rules to ensure your CSS is compliant with the WordPress CSS Coding Standards.

Stylelint is still active but the "WordPress-Coding-Standards/eslint-config-wordpress" repo has been archived, now recommending this NPMJS package: "ESLint plugin including configurations and custom rules for WordPress development."
My takeaway from this research:
It's great that there are standards defined for Core, but the tooling is prohibitively complicated. It's no wonder that so many plugin and theme developers don't follow standards. As much as I'd like some of my FOSS contribution to include reformatting some plugins to WPCS, I dare not do so, because it would impose a requirement for other developers to use the same tools that I adopt to format their code, which most people will simply not do.
What I'd like to see from the WPCS maintainers is a clear statement of recommended tooling so that more projects can get closer to the ideal. If recommendations for tooling change, so be it. But that would be done with the same consideration and care as any core change, with discussion about how it would impact developers and their existing code. The tooling is even largely unimportant. What's important is that non-core developers adopt their own preferred tooling which results in more consistent code across the industry.
Why would I like to see that? Clean and consistent code is easier for anyone to read. Consistency across packages reduces the burden of new developer interest in each new project and file. That can help with adoption of dead plugins, which an industry plague. The WPCS not only provides the core standards for improved security, it goes on to provide guidance on best practices. This is an excellent way to help non-core developers to learn how to code better. Better code can lead to plugin developers getting more help from others in the spirit of FOSS, whether in the form of code or code documentation. That collaboration might help to further encourage some of these plugin developers, and keep some plugins alive for longer. That tangibly serves this industry in the form of lower cost of ownership.

@TonyGravagno OK thanks for that.  I'll just quickly throw in a test I did.  In VSCode I activated phpcs and WPCS.  In my PHP files, I can many WPCS errors and warnings in VSCode.  In a CSS file, I made a change that violates one of the WordPress CSS coding standards (0 values should not have units unless necessary, such as with transition-duration), and no warning/error was displayed in VSCode.

Currently there are two WPCS sniffs that affect CSS:
I18nTextDomainFixerSniff and PrecisionAlignmentSniff.
For JS, besides the PrecisionAlignmentSniff there is also ClassInstantiationSniff.
There are probably more other sniffs from the PHPCS itself that is used in WPCS which cover CSS and JS.
What I found to be the best course of action is to set your ruleset in the project (so in the phpcs.xml.dist)
<arg name="extensions" value="php"/>

And use PHPCS to check only PHP files. For JS and CSS you can use eslint rules and stylelint rules that WordPress uses:
<EMAIL_ADDRESS>https://www.npmjs.com/package/stylelint-config-wordpress
CSS and JS checking in PHPCS will be removed once PHPCS 4.0.0 comes out anyways.

@dingo-d OK thanks for all that info.  I'll use WPCS for PHP, and use the other two rulesets for CSS and JS.  In light of that info, I guess we can consider this issue closed?  @TonyGravagno, anything objections to me closing this?

@dingo-d provided a clear statement about the current state-of-the-art in this area, which I hope will help others. Yes indeed, please close. Thanks again for initiating the discussion.