principle of TPS calculation

Recently I did some performance testing on fabric with caliper. However, I am confused about the principle of TPS calculation of caliper. Could you please give a brief specification about it? How it works?

@lenoAlex   hello, the throughout TPS  = Success Tx / time. you can look the function processResult and getResultValue at the  https://github.com/hyperledger/caliper/blob/master/src/comm/bench-flow.js

Caliper will record the submitting time and committing time (the time when the tx is committed on the ledger or when the failure occurred) for each tx.
So the send rate is calculated by (Succ+Fail) / (last submitting time - first submitting time).
The throughput is calculated by Succ/(last committing time - first submitting time), here only successful committed txs will be calculated.
@lenoAlex

Since the issue is a question, and it's answered, I'm closing it.


software management command not working

commands:

python manage.py software -g
python manage.py software -m

are not working. commands were added in MR !11
as part of running command, output more info to aid in tracing, i.e. total count found, when command started, and on command finished.
writing unit tests may be helpful too.

mentioned in commit 51e52e69a48fefc792b8556aa20d84652a53afe7

mentioned in commit 46af675f3c87d975a8dab3da70090fa3ab3f7033

added 5m of time spent

mentioned in commit 256d6e6c453f9e3d95ccb23074a24c205ee5d703


Update nfa1.json (Fixed github URL error)

Fixed github URL error.

Fixes Issue
Changes proposed
Fixed github URL error

Check List (Check all the applicable boxes)

[x ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x ] All new and existing tests passed.
[x ] This PR does not contain plagiarized content.
[x ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

fixed github url typo


Add Discord Server Settings

Each discord server should be able to set a number of settings, including:

Maximum number of plots per player
Role name for Admins and for Moderators
Default Realm name to use (if not specified) in commands
Default plot shape (square or circle)

Only Admins should be able to configure realm settings. Moderators should be able to view settings.
Most settings (other than Default Realm name) should be able to be overridden by Realm name (for servers with multiple Realms) and by specific user. The priority will go:
Default settings -> Discord server settings - > Realm settings -> user settings
For instance, Server 1 has Realms A and B. Realm A has 5 max plots, but B only has 1. On server A, player Bob has on override max of 6 (one more than default).
Bob's max plots on Realm A will be 6, but only 1 on Realm B.

Complete


Command to remove cached tasks

After using the command hcl tasks the task list is cached on the computer, so changes in Harvest are not reflected without manually finding the cached files and removing them.
I would really like a command such as hcl empty-cache to do this for me

+1 This would be a great addition to an awesome tool.

Just ran into this, would love to see it implemented.

Cache invalidation is hard. :( This is a good idea! I think this command should be paired with some heuristic that auto-updates the task list periodically.

Auto-update is also great, but in any case, a need to manually clear cache is first and foremost the need.

I'm new to this tool and I love it. I've been running into the issue this feature request is trying to solve. Is there any momentum on this issue/feature?


Autocomplete searches across newlines to close strings

Tested versions
v4.3.beta2.official [b75f0485b]
Every 4.x version I've used to memory
System information
Godot v4.3.beta2 - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>61) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)
Issue description
Triggering auto complete on strings (most commonly res paths) destroys everything between the string you opened and the next string in the file. Happens with double quotes / quotations and single quotes / quotations.
Code completion should probably just check up to the end of the same line instead of the entire file to close the string, though i don't particularly care if it closes the string at all; I just don't want it to change irrelevant lines.
This has probably been reported with how easy it is to trigger but I couldn't find a duplicate issue through search which is why I'm being particularly verbose. Sorry!
If it hasn't been reported then it's probably because most people use auto brace completion which adds both the opening and closing marks which prevents this issue.
Steps to reproduce
Open any project with any resource and trigger auto complete this code with the caret placed after the "r:
extends Node
var l := preload("r
var foo := "bar"

https://github.com/godotengine/godot/assets/3820082/e8359b3f-fa54-4631-aa56-c5ab7314e8af
Minimal reproduction project (MRP)
N/A

Can't reproduce it
https://github.com/godotengine/godot/assets/2223172/995641cd-327b-4c00-8f9e-e74230d11e38

Can't reproduce it
Godot_v4.3-beta2_win64_faXrvew508.mp4

That probably helps pinpoint it then; it seems to only happen with Tab, not Enter. Guess I've never hit enter there before.

Ok it happens when you use Tab.

Fixing this would probably make it not work as expected when trying to replace a valid multiline string.
But I think all autocomplete strings are one line only, so maybe it's fine?

@kitbdev you cannot have hints for multilines right now. More interesting thing is that common strings act like multiline strings:
func _ready():
    var a = "hello
    world
    "
    print(a)

They supposed to? If so, then replacing is expected behavior and it's not a bug. Personally I see bigger issue here, single double quotes string should act like single-line ones, for this particular issue it thinks that this part:
var l := preload("r
var foo := "

Is a valid string, more clear example:
func _ready():
    print("r
var foo := ")

I'd say this issue is not just about newlines, but about auto-completion swallowing code that is to the right of the caret in general.
let's say we write this code:
var node = Node.new()
node.get_path()

after writing it, we realize that we want to pass the return value of get_path() into another function, so we hit the Home key to move the caret to the beginning of the line and start writing the function name.
let's say we want to pass it into has_node() (nevermind it making no sense, just an example):

we hit tab and end up in this horrible situation:
var node = Node.new()
has_node(.get_path()

experiencing this multiple times a day makes me want to tear my hear off my beautiful bald head.


windows上使用在service中使用system权限截屏报错

调用screen.capture() 错误信息为：拒绝访问 , 0x80070005；

I have same issue in windows 11. any update how to fix this?

能给一个示例代码吗？我不是很了解windows开发

Was looking through the windows code and your supposed to wrap GDI calls in GdiplusStartup and GdiplusShutdown at least in C++ code.

The session of a Windows system user does not have a desktop station, therefore it is not possible to take screenshots.


Mantine refactor follow-up

Some issues remain open after merging #81, they should be addressed separately:

[ ] https://github.com/mantinedev/mantine/discussions/1759
[x] https://github.com/mantinedev/mantine/discussions/1966
[ ] https://github.com/mantinedev/mantine/discussions/2105

For the third task take a look at this https://rtivital.github.io/mantine-dates-6/

Done in 2c91f9baf3f08fab7181522346d3471c036f570d


Allow parentheses to be omitted around tuples where sensible

In Python, you don't need parentheses around tuples all the time. For example,
# Swaps variables
a, b = b, a

# Iterate over list with index
for i, item in enumerate(list_of_items_):

# Return a tuple
return None, False

Currently, N requires parentheses around tuple expressions/literals and types (but not patterns, I think). So, currently, the programmer has to write
let a, b: (char, float) = (\{π}, 3.14)

I feel like those parentheses around the value and type annotation aren't necessary, so instead, one can just write
let a, b: char, float = \{π}, 3.14

Parentheses will still be required inside type variables, lists, function arguments, and other tuples:
let wow: list[(char, float)] = [(\{e}, 2.72), (\{π}, 3.14)]

print((1, (2, 3)))

so I don't think allowing their omission should cause any problems.
(I'm adding the Python label because it's not in the Python implementation but it is in the JS implementation as of now; if this feature request gets rejected then I'll have to fix the JS impl.)

To implement this, I think we can first rename expression to nontuple_expression, and then replace the mentions of expression in listval, etc. with nontuple_expression. Then, we can define expression to be either a nontuple_expression or a tupleval.  We can then remove parentheses from tupleval. Because expression can also be boolean_expression, we probably should either require tupleval to have at least two items (changing * -> + should do that) or in scope.py check how many items there are before creating a tuple.
tupleval: nontuple_expression ("," nontuple_expression)+ (",")?
?nontuple_expression: ifelse_expr
           | boolean_expression
           | function_def
           | anonymous_func
           | function_callback_pipe
           | match
?expression: nontuple_expression
           | tupleval

And something similar for tuple types (tupledef).
We'd also have to relax the use of parentheses around tuples in the tests

Also, just to be safe, we should disallow a trailing comma unless it's inside parentheses

I think this is not that worth it for the number of edge cases it adds.

edge cases

Do you have any examples?

I still dislike this.


Problem with nether? HELP!

Server and plugins version:
Spigot 1.8.3
Multiverse-core 2.5 (#697) LATEST
Multiverse-portals 2.5 (#723) LATEST
Multiverse-inventories 2.5 (#335) NOT LATEST
Problem:
No create defaults portals in nether, always is the same.
Don't need Multiverse-NetherPortals because this is my default server world "world" and "world_nether".
VIDEO: https://www.youtube.com/watch?v=e_qC9nm2ozI&feature=youtu.be
Help pls. Thanks :)

I'm having the same issue. Only using multiverse Core and Portals, not Nether Portals.

Check https://github.com/Multiverse/Multiverse-Core/wiki/config.yml for "portalsearchradius: 16"

Yes, this is the default behavior of Minecraft. If there is a portal within 256 blocks of the intended location in the nether it will simply use that portal instead of making a new one. You can change this by installing Multiverse-NetherPortals and setting portalsearchradius to something small like 16. However, with portals that close together on the overworld that still may end up being the same portal.
Here's what it would be like with Multiverse-NetherPortals and a portalsearchradius of 16: Let's say the portals on the overworld are 32 blocks apart. That means the portals in the nether would be 4 blocks apart. Since 4 is less than 16 it won't make a new portal. That means the portals in the overworld would have to be at least 144 blocks apart for a new portal to be created in the nether.
The default without the extra plugin means they'd have to be a bit over 2000 blocks apart in the overworld.

Sorry, I think the OP perhaps wasn't expressing the problem well. Or I am misinterpretting him/her and we have different problems. The issue I'm seeing is that portals are NEVER linked-- each trip through a portal ALWAYS creates a new one on the other side, regardless of distance.

I've put together a short video demonstrating the issue. my config is in the video description https://www.youtube.com/watch?v=yK0EbBNfnIA

@dumptruckman This issue clearly isn't resolved. Please reopen!

I can guarantee you that there is nothing to resolve here. Multiverse-Core does not change the behavior of nether portals beyond blocking people from traveling to worlds they don't have permission. Multiverse-Portals doesn't use this type of portal creation behavior, so really it is ruled out as well. If this was a problem caused by the Multiverse suite, it is caused by Multiverse-NetherPortals, however, the OP was not using that plugin. Therefore, Multiverse is not the cause. Either the server software is bugged or there is another plugin that is the culprit.
If you are using Multiverse-NetherPortals and having an issue like this please open a ticket on it's issue tracker instead.

@dumptruckman I see, you have a very good point. I apologize.
I ran into the same problem, but now that I reread what OP wrote I came to realize that in contrast to him, I was also using Multiverse-SignPortals. That makes sense as it supports using signs in conjunction with nether portals, so it is able to interferes with nether portal functionality. I will look into it some more.


Remove the vpcctl binary from the IBM cloud controller manager

This is a preview of an internal PR that is still being tested
-- DO NOT MERGE --

/ok-to-test

Is there any update on the status of the internal tests? This looks pretty good so I'm hoping we can migrate to this at some point in the near future

@JoelSpeed The internal VPC regression tests completed successfully back in November.
Waiting on code review/sign off from Richard Theis and the IBM CCM/update squad.
Hopefully the upstream change can get reviewed by Richard in early January.

@JoelSpeed  The upstream PR has been fully tested since before Thanksgiving. However, Richard Theis does not like / agree with the design change and he will not review or approve the upstream PR. It looks like your current, ugly git submodule build process is going to be here indefinitely.

/close

I have to give credit where credit is due.  The whole idea to switch the VPC controller logic from a binary over to GO module/library came from the IKS networking team in Hungry.  They provided the first PRs to convert over to GO module/library back on: 6/18/2001.  I was skeptical at first, but looking back, this was great, unique idea that I had never even considered before.
Well over 50+ PRs were done during the summer and into the fall months to complete the work to get the repo setup so that it could be called as a GO library/module.  The design document to switch CCM to invoke VPC LB via GO module/library call was created in September 2021.
The first upstream PR to switch CCM to invoke VPC controller via GO module/library call was done back on: 10/21/2021.  This PR used the initial v0.1.0 release version of the VPC controller.  Despite this being the very first git release of the VPC controller, it did include all of the requested/required VPC IPI changes (known at that time).
Over the next few weeks, the CCM to VPC LB interface was tested, updated, optimized, re-tested, and simplified. A second upstream PR was created on: 11/15/2021.  This PR used the v0.3.0 version of the VPC controller.  More testing and then a week later on 11/22/2021,  the PR was refreshed to use the: v0.3.1 version of the VPC controller.  Lots more testing.
On 12/1/2021, this PR was created based on that second upstream PR.  Roughly 95% of what was done in the upstream PR was included in this PR.
On 1/5/2022, the VPC controller was updated to v0.4.0. I probably did not need to update the minor release.  There were no functional changes in this update. It was just a refresh of the dependencies.  (The last functional change/bug fix was back on 11/11/2021 with the v0.3.0 version.)
Yesterday, 1/25/2022, I updated this PR to use the new v0.4.0 version of the VPC controller.


Suggest Edit: Update benjaminoddou/emoji-wine

Gallery URL
https://alfred.app/workflows/benjaminoddou/emoji-wine/
Website
No response
Forum
No response
About
Update workflow to v1.4.0. See here. 😄
Notes
No response

Thank you. GitHub has been odd about feeds, not keeping them consistent. Yours and a few others seem particularly affected, which seems to be correlated with the use or emoji and/or images in the feeds, though I can’t say for sure yet.
Update is live.

You're the best @vitorgalvao ! Many thanks 🙏


Unbroken models

Hi, I want to know how to obtain the mesh files of unbroken models.  If we directly merge all the fractures together, there will be a lot of faces on the fracture surface.

Thank you for the valuable information. However I still have some doubts, if I want to get the original mesh files of the EVERYDAY dataset, should I just download the PartNet dataset? I find that PartNet offers three versions(datav0,  sem_seg_h5, and ins_seg_h5), which one should I download?

We use a PartNet variant called ACRONYM. You probably have to download it. I currently don't have access to this original dataset on the cluster, so I cannot confirm if the ID is exactly the same or under some naming conversion. But I think they should be very similar.


Fix rclc branch

It is correct, for  this repo main branch we use rclc master, for galactic branch we use rclc galactic


Add CodeMirror One Dark theme

I'd like to try tackling this request: https://discourse.joplinapp.org/t/plugin-macos-theme-for-joplin/18934/114
Could you provide the steps needed to incorporate the theme? I believe the source is this: https://github.com/codemirror/theme-one-dark

Hi @kristophercrawford , yes I think you should be able to transform this TypeScript file into a CSS-file like the ones in this folder. In order for it to show up as an option in the Joplin plugin settings it should be added to editorMarkdownThemeLught or editorMarkdownThemeDark here.

I would absolutely die out of happiness to see this colour scheme added to this project! My absolute favourite one and I am dreading not having it here.

Is there a specific version of Node that is used for development of this project?
On npm run dist I seem to be getting
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],   library: 'digital envelope routines',   reason: 'unsupported',   code: 'ERR_OSSL_EVP_UNSUPPORTED' }
I am getting exactly the same issue on both Windows and Fedora.

@mikicvi Yes, I think it's v16 as I need to update some dependencies. 😅

What I am finding is that the one-dark theme from here: https://github.com/codemirror/theme-one-dark/blob/main/src/one-dark.ts doesn't match the one-dark theme on HedgeDoc website. I copied the CSS from the HedgeDoc site and applied it to come up with this:

Using the seemingly official style I end up with the following:

So that leaves the question of should the one-dark theme be the seemingly official one or the HedgeDoc implementation of it?

@kristophercrawford I personally prefer the second one since it blends in better with the rest of the theme. I think that is also the one @mikicvi took as a base and  implemented in #119. That PR I just merged so should be available in 30 mins when the Joplin bot picks up the change. I assume this issue is solved, so closing this for now. Thanks again @mikicvi!


gtest gmock mix up

https://github.com/ros/catkin/blob/a9f6b62cddff3348a47e7f083a677d547e9bcdbc/cmake/test/gtest.cmake#L404
The file " catkin/cmake/test/gtest.cmake" seems to cause trouble on some machines in the latest catkin version (0.7.11) regarding the gmock / gtest pathes. Although the according lines were not changed during the last update; due to some specific configuration (additionally setting the according pathes at different places) these specific lines in this block were attracting attention and might be worth to be checked, It seems that some mix up might happen here:
For the following lines compare the sample code with the debug output were a simple test setup was created:
${GTEST_BOTH_LIBRARIES} and ${GMOCK_BOTH_LIBRARIES} seem to contain the same path, which leads to the output
Expected path to GTEST_BOTH_LIBRARIES:    ../libgmock.so/usr/lib/libgmock_main.so
Expected path to GMOCK_BOTH_LIBRARIES:    ../libgmock.so/usr/lib/libgmock_main.so
In my case the issue becomes clear if having a closer look at the execution of the tests.
gtest_gmock_bug.tar.gz

Hi @simon-rotter, thanks for creating the issue. I'm not sure what you mean by "cause trouble". Are you saying some packages are failing to build tests on some systems? How do I need to set my system up to reproduce the issue you're seeing?
It looks like the line of code referenced happens if there is a find module for GMock. The googlemock documentation says "Google Mock is implemented on top of the Google Test C++ testing framework, and depends on it. You must use the bundled version of Google Test when using Google Mock ...". It sounds reasonable to me that GTEST_... variables would get set to gmock locations.
Related PR #897

Closing due to no response.


raidboss: p8s add hints about which tower to take

Not sure if you're aware but in HC2, the people who need to merge for towers are actually fixed. Long alpha and long beta will always have to merge (to make the wind concepts that need to fuse with ifrits at the end of the phase) and similarly long gamma and the unused debuff (can be either unused alpha or unused beta, but never unused gamma) will have to fuse to take the final set of towers. This makes that mechanic deterministic unlike HC1 where there's some randomness depending on which tower spawns.

Not sure if you're aware but in HC2, the people who need to merge for towers are actually fixed. Long alpha and long beta will always have to merge (to make the wind concepts that need to fuse with ifrits at the end of the phase) and similarly long gamma and the unused debuff (can be either unused alpha or unused beta, but never unused gamma) will have to fuse to take the final set of towers. This makes that mechanic deterministic unlike HC1 where there's some randomness depending on which tower spawns.

My understanding was that the first tower was either water or lightning and that wind is always in the final set.  Is that not true?

So because there have to be two wind towers in the final set, you know that long alpha and long beta must always merge (to form wind). This also means that no matter which color the other two towers are (they can be water or lightning yes), the correct two people to merge are long gamma and whoever was unused from the very first set of alpha/beta/gamma debuffs. This means that in essence, you don't actually need to pay attention to the colors: the movement is static every time. Here are two diagrams to better illustrate (towers can obv be diagonal or left/right but this is just a matter of communicating who gets which):

Yeah, I think there's a lot of room for improvement here.  This callout is still good for the previous three towers, though.


Complete Server Crash

Running the latest release broker for 24 hours,
with various clients connecting, I suddenly got reports the server is down.
seeing this in erlang.log.1:
09:01:15.424 [info]  [alarm_handler: {:set, {:process_memory_high_watermark, #PID<0.3929.0>}}]
eheap_alloc: Cannot allocate<PHONE_NUMBER> bytes of memory (of type "old_heap").

Crash dump is being written to: crash.dump...done
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed^M

@syberkitten Do you create one subscriber to consume messages from many publishers?

What is your test scenario? How many publishers? How many subscribers? How many topics?

@grutabow
Not many clients connected, around 10.
each clients was creating between 500-3000 topics.

@syberkitten  What about qos? QOS2? QOS0?

@grutabow
QOS0.
We will run the test again on a stable version 2.2.0
and see how it goes....


Update minimal number of cores in setup.ps1

setup.ps1 script requires 8 cores available for Edsv4 machine, which has low availability. The same situation occurred in:
https://github.com/MicrosoftLearning/dp-203-azure-data-engineer/commit/20493dd2d8311d3172fbe07193f15d8b15556835
Module: mslearn-databricks
Lab/Demo: Explore Azure Databricks
Fixes # .
Changes proposed in this pull request:

Change minimal required number of cores from 8 to 4

The setup also needs to support other labs that require 8 cores


cmd/vet: warn about "// go:" comments (with space)

The embed.FS type added for #41191 documents the following behavior:

An FS is a read-only collection of files, usually initialized with a //go:embed directive. When declared without a //go:embed directive, an FS is an empty file system.

I expect that package authors essentially never intend to end up with an empty read-only filesystem in a production package. (In tests, perhaps, but not otherwise.) For the few cases where they do, they should be able to add an explicit //go:embed directive indicating that the filesystem is intentionally empty.
Otherwise, it is too easy for an unintentional typo in the //go:embed directive, such as the one discovered in https://github.com/golang/go/issues/43682#issuecomment-760344342, to result in a difficult-to-debug failure at run time.
I propose that cmd/vet should emit a warning when:

a package-level variable is declared with type embed.FS,
without any corresponding //go:embed directive (not even one with an empty pattern list),
in a non-test source file.

If this never makes sense, why not a build error?

If this never makes sense, why not a build error?

in a non-test source file.
Do we expect this restriction is necessary? Proposal restricts this to package level variables. The current draft of https://golang.org/cl/283852 does have an embed.FS at this level. Do we expect anyone else would have one intentionally?

in a non-test source file.
Do we expect this restriction is necessary? Proposal restricts this to package level variables. The current draft of https://golang.org/cl/283852 does have an embed.FS at this level. Do we expect anyone else would have one intentionally?

If this never makes sense, why not a build error?

I'd be ok with that too, but I suspect that a vet warning is an easier sell. 😅

If this never makes sense, why not a build error?

I'd be ok with that too, but I suspect that a vet warning is an easier sell. 😅

Do we expect this restriction is necessary?

I expect that it will catch a non-trivial number of real errors with few or no false-positives. I believe that meets the bar for a vet check.

Proposal restricts this to package level variables. The current draft of https://golang.org/cl/283852 does have an embed.FS at this level. Do we expect anyone else would have one intentionally?

Note that (a) the package-level variable in that CL is unnecessary (it could be a local variable instead), and (b) it would not trigger the proposed check anyway, because that variable is in a test source file.

Do we expect this restriction is necessary?

I expect that it will catch a non-trivial number of real errors with few or no false-positives. I believe that meets the bar for a vet check.

Proposal restricts this to package level variables. The current draft of https://golang.org/cl/283852 does have an embed.FS at this level. Do we expect anyone else would have one intentionally?

Note that (a) the package-level variable in that CL is unnecessary (it could be a local variable instead), and (b) it would not trigger the proposed check anyway, because that variable is in a test source file.

@timothy-king, Oh, I think I see what you're saying now. “Would it be ok to warn for package-level embed.FS variables in test source files?”
I don't actually know. I suspect that we could warn for those cases too..?

@timothy-king, Oh, I think I see what you're saying now. “Would it be ok to warn for package-level embed.FS variables in test source files?”
I don't actually know. I suspect that we could warn for those cases too..?

I expect that it will catch a non-trivial number of real errors with few or no false-positives. I believe that meets the bar for a vet check.

Agreed. I also think the cost of a false-positive is small. I believe var global *embed.FS=&embed.FS{} would be a decent workaround if you absolutely had to have an initially empty package level embed.FS.

@timothy-king, Oh, I think I see what you're saying now. “Would it be ok to warn for package-level embed.FS variables in test source files?”

Yep that was my question.

I don't actually know. I suspect that we could warn for those cases too..?

I also suspect warning on tests would be okay. Maybe I am not being clever enough, but I can't think of a good use case for test files either.

I expect that it will catch a non-trivial number of real errors with few or no false-positives. I believe that meets the bar for a vet check.

Agreed. I also think the cost of a false-positive is small. I believe var global *embed.FS=&embed.FS{} would be a decent workaround if you absolutely had to have an initially empty package level embed.FS.

@timothy-king, Oh, I think I see what you're saying now. “Would it be ok to warn for package-level embed.FS variables in test source files?”

Yep that was my question.

I don't actually know. I suspect that we could warn for those cases too..?

I also suspect warning on tests would be okay. Maybe I am not being clever enough, but I can't think of a good use case for test files either.

The spec in the adopted proposal was very clear that declaring an embed.FS with no //go:embed line is valid.
If we believe it is valid, then vet should not "warn" about it.
We don't warn about non-errors.
As implemented today, embed.FS are copyable, so that you can do things like
var fs embed.FS
if cond {
   fs = version1files
} else {
   fs = version2files
}

You don't want vet to complain about fs in that code.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc The proposal is only to warn on package level variables. I think fs would be function scope in your example. But you  make a really good point about the proposal:

Similarly, an embed.Files variable can be a global or a local variable, depending on what is more convenient in context.

It is not an error to declare an embed.Files without a //go:embed directive. That variable simply contains no embedded files.

That is saying fairly definitively that a strict reading of this proposal that it will warn on non-errors.
It does seem like there should be something we can do to help in cases like #43682 though. What about instead just warning when there is no //go:embed and there is also a likely misspelling like "// go:embed" (with a space)?

It seems fine to develop a vet checker that warns about "// go:" lines where "//go:" would have a meaning instead.
For example "// go:embed" right before an embed.FS or []byte or string declaration,
or "// go:noinline" right before a function.
We'd want to check for false positives in existing open-source Go code though.
Should we repurpose this issue for that, @bcmills?

Yep, that seems ok by me. A // go: check would probably help with other directives too.

It might be worth looking at the buildtag analysis pass, which may already do this for //go:build.

Does anyone object to the retitled proposal (a vet check to warn about "// go:foo" where "//go:foo" has a meaning)?

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

I've mailed out CL https://go-review.googlesource.com/c/tools/+/381914 which fixes the problem and is simple.


Recipes

Version, build 1626.
Using this event: 'on item recipe formed' I've just been having lots of issues.
on torch recipe formed:
- determine i@stone

Works totally fine and it changes the outcome into stone. However:
on i@torch recipe formed:
- determine i@stone

Doesn't work. Just using torch here as an example but this means any i@customitem doesn't trigger this event.
Trying to do: Make 3 custom items with the same item but their recipes would be in different orders.
For example SteelSword, SteelSword2 and SteelSword3 with 3 different recipes but then with that event I would determine SteelSword, so people don't walk around with numbers SteelSword2 or 3.
Next, I'm not sure if this is an issue or just not possible but I would think it's something normal to make a recipe using quantities instead of always using 1 of each item:
recipe:
- air|air|air
- air|air|air
- charcoal|iron_ore[quantity=5]|charcoal

This recipe works but only 1 iron_ore will be deduced and the outcome already shows up as soon as you put in 1 iron_ore, so quantities don't seem to work in recipes.

Don't use object identifiers in events (The i@ portion). For example, instead of on i@ItemScript blah, just use on ItemScript blah
Also, I don't believe Bukkit supports multiple items in one slot - they don't even support requiring lore or anything besides material, we have our own custom handlers for that. We may be able to add support for quantities if it's an important feature

SteelIngot:
  type: item
  material: iron_ingot
  display name: <&7>Steel Ingot
  recipe:
  - air|air|air
  - air|air|air
  - charcoal|iron_ore[quantity=5]|charcoal

For example I got this item that I've been testing with and it would be awesome if that [quantity=5] behind the item in the recipe would work. Up to you whether it's possible and worth implementing. For me it would safe a lot of time.
Right now I would have to make extra items such as iron_ore bundles or whatever which would equal to 5 iron_ore and use that instead. Kinda confusing but it's a workaround.
Anyway the real problem, if I understood correctly then I'm not supposed to use i@SteelIngot in the event but instead just use 'on SteelIngot recipe formed' but that too doesn't seem to be working.
on SteelIngot recipe formed:
- determine i@stone

Just gives the SteelIngot item and not stone.
Problem is with the determine if I tested it correctly just now:
ChangeRecipeItems:
  type: world
  events:
    on item recipe formed:
    - if <context.item.scriptname> == STEELINGOT determine i@stone[quantity=5]

This triggers fine but it doesn't change the outcome to stone.
If I use it with a torch, if <context.item> == i@torch[quantity=4] determine i@stone[quantity=5] then that works fine.
So I think the determine doesn't work with a custom item recipe as that overrides it somehow? No clue.

Fixed the determining issue. I'll open a new issue for quantities and stuff

#1482
Also, for the fix use the latest developmental build
http://ci.citizensnpcs.co/job/Denizen_Developmental/lastSuccessfulBuild/


Improved query ability

This provides some convenience methods for finding RelatedContent by the source and destination objects.

This looks like a good addition. +1


Visualize resource links better by focus on logical resource dependency's

Feature name
Visualize resource links better by focus on logical resource dependency's
Is your feature request related to a problem? Please describe.
It is not easy to create a nice visual of a simple resource dependency.
For Example: Route53, IGW, CloudFront (++WAF), ALB, Listener, Target Groups, Server (Network Interface, Disk, ...)
Also an ALB Listener seems not to link with Target Groups.
For Example: Visualize network connectivity within the VPC for Servers.
Describe the feature you'd like to see implemented
See attached examples from other software products that realize nice overviews without any diagram change.
Have to possibility to group links. For example. Group connection from ALB to Subnets or to server.
I like the way a resource group expand and the other resources stay visible.
Describe the value this feature will add to AWS Perspective
Out of the box usable diagrams (Templates).
Less time to find problems in the architecture.
Describe alternatives you've considered
Other products.
Additional context
Please see below.
fugue.co

Hyperglance

This seems to me be be similar to https://github.com/aws-solutions/workload-discovery-on-aws/issues/127, where we would have views with different granularities. This is definitely something we are interested in pursuing but obviously it involves a lot of redesign of the front end so we'd need to do a lot of planning to see how we would implement it.


UI fix code display for temporary modules

Temporary modules, most commonly generated in notebook cells, were throwing errors with the hamilton_sdk.adapters.HamiltonTracker. Then, the UI wouldn't properly display the registered code artifacts.
The fixes aim to solve the same issues as #855. Given the problems are related to the Hamilton SDK, it seems better to apply changes there than in the Hamilton library where module_from_source is used in contexts with different constraints (CLI, LSP, VSCode extension, Jupyter extension, and more)
Changes

_hash_module() doesn't expect for modules to have a __package__ attribute. Modules imported in a Jupyter cell wouldn't have this attribute set, for example pd in the following. This changes makes the HamiltonTracker fully functional.

%%cell_to_module
import pandas as pd

def A() -> pd.DataFrame:
  return ...

After change 1, the source code associated with each node wouldn't be displayed. This is because _slurp_code() looks for a file instead of the module object itself. If module.__file__ is None we now read the source code from the linecache (set by ad_hoc_utils.module_from_source(). Then, the path attribute in _slurp_code() needs to match the path attribute in extract_code_artifacts_from_function_grap()

How I tested this

hamilton tests ran successfully
hamilton_sdk tests ran successfully except two tests related to hashing
source code renders properly in the UI for script and notebook usage.

⛔ This makes two SDK test fail. It's probably sufficient to update the hash value, but wanted to double check
================================== short test summary info ==================================
FAILED tests/test_driver.py::test_hash_module_with_subpackage - AssertionError: assert '4466d1f61b2c...ef83e3d6c6bf8' == '9f0b697b6b07...d772b8bd392c7'
FAILED tests/test_driver.py::test_hash_module_complex - AssertionError: assert 'c22023a4fdc8...b789b80f19896' == 'fc568608a2f7...104c1ba2a5e1c'

Notes
Checklist

[ ] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.

if I change the jupyter magic to use the source version, it does not seem to work properly when I change the cell and update the code -- the source code tracked is still the same from the first iteration.

I believe I will need to edit line 52 https://github.com/DAGWorks-Inc/hamilton/blob/808f448b4dcb9ad4e325b473dd372257b24e4296/ui/sdk/src/hamilton_sdk/driver.py#L52

@skrawcz my understanding is that these changes won't be merged as we're rolling create_module() for the Jupyter magic v2. Feel free to close this branch if that's the case

While working on other things found this code. It shows the risk of constraints of a particular use case creeping to the main library.
    @functools.cached_property
    def version(self) -> typing.Optional[str]:
        # ...
        try:
            # return hash of first function. It could be that others are Hamilton framework code.
            return hash_source_code(self.originating_functions[0], strip=True)
        except (
            OSError
        ):  # TODO -- ensure we can get the node hash in a databricks environment when using jupyter magic
            logger.warning(
                f"Failed to hash source code for node {self.name}. Certain environments (such as databricks) do not allow it."
                " In this case, version will be None."
            )
            return None


set page property maximizable exception

from flet import (app, Page, FLET_APP_HIDDEN, ControlEvent)

def on_error(even: ControlEvent):
    print(even.data)

def main(page: Page):
    page.on_error = on_error
    page.window_maximizable = True
    page.window_visible = True
    page.update()

if __name__ == '__main__':
    app(name='master', target=main, view=FLET_APP_HIDDEN)

when I set the page property maximizable the page error event will exception callback occurs.
"type 'bool' is not a subtype of type 'List<dynamic>?' in type cast"

Although it does not affect normal use, but it looks strange.
I have no idea how to fix it.
Operating environment：

Window 10
Python 3.10.2
Flet 0.3.2

Will take a look.


Update ingest time feature

Ran the fmr crawler to get raw docs: s3://advana-data-zone/bronze/gamechanger/data-pipelines/orchestration/logs/crawler-downloader/Crawler-One-Off-Run.2023-07-27T17:42:01.log
Ran the parse here: s3://advana-data-zone/bronze/gamechanger/data-pipelines/orchestration/logs/core-crawler-ingest/Crawler_Ingest.20230727_180801.log
Sample output of a parsed file with new fields: s3://advana-data-zone/bronze/gamechanger/load-archive/parsed/2023-07-27T18:08:01/DoDFMR V10CH10.json"


Draft: Nt optimise position bandwidth.

Checks to see if value can fit into a short (rounded to 2 decimal places), if so, send that, else fallback to vector3 floats.
Is optional via bool.
If on, uses half the amount of position data, automatically switches to non-compressed position if user goes out of short.max unity range.
This PR should come first.
https://github.com/MirrorNetworking/Mirror/pull/3677

Cool feature, but would be better with var int and/or delta.
Which is a future step.


fix(vaults): cleanup pass with several fixes

Summary
I will collect in this PR different changes and fixes to Vault.

TODO: add changelog.


[Bitmex] API rate limit conflict among multiple accounts

When we create multiple BitmexExchange with different API keys for different account, each of them should have there own API rate limit independently.
The current implementation, however, fails to achieve this. Because these three properties -- rateLimit, rateLimitRemaining and rateLimitReset are static properties of BitmexBaseService, which would be globally shared.

Yeah, API rate limiting was done in some modules in an inconsistent and mostly faulty way.
I think we should throw out any rate limiting code for now and consider it out of the scope of this library until we design a more unified mechanism of implementing this and making it an optional feature.

Indeed rate limit is not mandatory for this library.
On Sat, 27 Jul 2019, 16:09 Adam Walczak<EMAIL_ADDRESS>wrote:

Yeah, API rate limiting was done in some modules in an inconsistent and
mostly faulty way.
I think we should throw out any rate limiting code for now and consider it
out of the scope of this library until we design a more unified mechanism
of implementing this and making it an optional feature.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/knowm/XChange/issues/3121?email_source=notifications&email_token=AHIWQ75ELUJ3JK3I6GYO7RTQBRCILA5CNFSM4H2MHXTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26LFIY#issuecomment-515682979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIWQ72SEJRJ6BJZOOYQEPLQBRCILANCNFSM4H2MHXTA
.

a new proposition in this regard: https://github.com/knowm/XChange/issues/3211

BTW. Binance also limits the API calls to methods that do not require any account (/api/v1/depth for example)
I don't think that having more then one account will allow you to call /api/v1/depth more often on a given IP. Could some one verify this? either by emailing Binance or doing an experimental test?

Hi,
the question is: why are they static?
I just checked out the code, removed the static keyword, and everything seems fine (I was expecting it cannot compile anymore).
Can it be so easy to simply remove the static keyword?
*Ciao
Piero

If limit rating is done on a per account level then why do they block you entire IP if you surpass it?
https://www.bitmex.com/app/restAPI#Request-Rate-Limits

If a large number of 4xx or 5xx responses are delivered in a short period of time, your IP may be banned for an hour.

If the rate limiting is bound to your IP then rate limiting should be static and the number of Exchange instances you create should no affect on it.
So before hacking anything I we need to know if:

rate limits apply to a given IP?
or to a given account?

Therefore I repeat my question: Could some one verify this? either by emailing Binance or doing an experimental test?

Hi @walec51,
good question: documentation is not clear.
In one place there is what you said above (so per IP ban) but just above they say

Requests to our REST API are rate limited to 60 requests per 1 minute. This counter refills continuously. If you are not logged in, your ratelimit is 30/1 minute.

Bold is mine ;)
So it looks like they have a per customer ratelimit and a per IP ban when the client is giving too much errors.
I have a client with multiple "customers"... I will enable trace and will report here :)
*Ciao
Piero

OK, I'm pretty sure the HTTP Headers returned by bitmex are per account: I clearly can see they "restart" from 60 for each customer.

ok, thank you for the research, I will take it into consideration in my new rate limiting implementation  #3211
for now feel free to add a PR with the change you suggested, it should work, please test it out

@walec51 The thing is when the API key is not provided (only public endpoints are accessible), the rate limit is applied to the IP, while the API key is provided, it is applied to the account.

Hi @ottuzzi ,
i think simply removing the static keyword would just create another problem: a conflict between different service types.
My understanding is that these fields are declared as static at the BitmexBaseService level so that they will be shared among the different service types (BitmexAccountService, BitmexMarketDataService, BitmexTradeService).
If you use more that one type of service, and each tracks the rate limits independently, that would lead to a similar conflict, with out-of-sync rate-limit information in each.


change import paths

part of #207

Any idea why some of the lines of the project file are painted with this bright red color?


Bug? in SkiaControl.Shared.AdaptCachedLayout is doubling Left/Top offsets. TBD under what circumstances.

I believe I have surfaced a latent problem in AdaptCachedLayout.
I need to determine exactly what in my layout of SkiaControls causes this.
This is when scrolling SkiaScroll. It has become a problem because on one path through DrawnUI code, the doubling occurs, BUT on a different path, the doubling does not occur. As a result, my content draws in one of two different positions (offsets), depending on ...[I'll add a comment when I know more]...
What I see so far:

AdaptCachedLayout is called for my custom SkiaLayout, which is Content of a SkiaScroll.
AdaptCachedLayout is called with destination that has Left, Top offsets.
ArrangedDestination ALSO has those offsets!
These lines result in the DOUBLED offsets:

var newDestination = ArrangedDestination;//.Clone();
newDestination.Offset(destination.Left, destination.Top);

Example:
+	destination	{{Left=-52,Top=-1,Width=∞,Height=∞}}	SkiaSharp.SKRect
+	ArrangedDestination	{{Left=-52,Top=-1,Width=∞,Height=∞}}	SkiaSharp.SKRect
=> `Destination` setter called with:
+	value	{{Left=-104,Top=-2,Width=∞,Height=∞}}	SkiaSharp.SKRect

Workaround:
I override AdaptCachedLayout to remove newDestination.Offset(...); line.

UPDATE
Given workaround, no longer have "doubled" values.
BUT my control is still drawn in two different positions, when it has been scrolled.
Now instead of "correct offset" and "doubled offset", the two positions are:
"zero offset", as if Scroll = (0,0), and "correct offset".
Investigating.

This code path gives correct offsets:

This code path gives doubled offsets:

Thanks, Steve! Sorry for slow reaction, sick these days, will get in ranks soon.

I believe I have surfaced a latent problem in AdaptCachedLayout. I need to determine exactly what in my layout of SkiaControls causes this.
This is when scrolling SkiaScroll. It has become a problem because on one path through DrawnUI code, the doubling occurs, BUT on a different path, the doubling does not occur. As a result, my content draws in one of two different positions (offsets), depending on ...[I'll add a comment when I know more]...
What I see so far:

AdaptCachedLayout is called for my custom SkiaLayout, which is Content of a SkiaScroll.
AdaptCachedLayout is called with destination that has Left, Top offsets.
ArrangedDestination ALSO has those offsets!
These lines result in the DOUBLED offsets:

var newDestination = ArrangedDestination;//.Clone();
newDestination.Offset(destination.Left, destination.Top);

Example:
+	destination	{{Left=-52,Top=-1,Width=∞,Height=∞}}	SkiaSharp.SKRect
+	ArrangedDestination	{{Left=-52,Top=-1,Width=∞,Height=∞}}	SkiaSharp.SKRect
=> `Destination` setter called with:
+	value	{{Left=-104,Top=-2,Width=∞,Height=∞}}	SkiaSharp.SKRect

Workaround:
I override AdaptCachedLayout to remove newDestination.Offset(...); line.
UPDATE
Given workaround, no longer have "doubled" values. BUT my control is still drawn in two different positions, when it has been scrolled.
Now instead of "correct offset" and "doubled offset", the two positions are: "zero offset", as if Scroll = (0,0), and "correct offset". Investigating.

I think I know where this might come from.
Is it possible you changed the measuring process for your custom scroll or for the content wrapper (hopefully a skialayout)? What type is your content actually?

One thing to know is that we land inside Arrange either when the parent measures us, either for "self-measure" that happens for top views on the canvas AND occasionally for any view when it's marked as dirty but for reason it's redrawing BEFORE the parent had the luck to measure it as due.

Failing to reproduce :/ Would need to see your custom SkiaLayout specifics that are causing this.

Related to https://github.com/taublast/DrawnUi.Maui/issues/102, at first approach reproducible with parent container not taking full canvas width and children centered.

Must be resolved with https://github.com/taublast/DrawnUi.Maui/pull/105/


Not able to switch the network in Trust wallet browser in mobile !

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.0.0
wagmi Version
2.0.0
Current Behavior
I have opened my site in Trust wallet internal browser in mobile.
I am trying to switch to other chains.
But, every time, I am selecting other chain from the switch chain modal, nothing happens.
Tried 3-4 times.
Expected Behavior
User should be able to switch to other chains.
Steps To Reproduce
I have opened my site in Trust wallet internal browser in mobile.
I am trying to switch to other chains.
But, every time, I am selecting other chain from the switch chain modal, nothing happens.
Tried 3-4 times.
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
https://github.com/rainbow-me/rainbowkit/assets/96103403/176d3277-d2b1-4554-a573-f66f2f649b49

@PearlSharma I just tried to reproduce your issue and for me the trust wallet in app browser works fine with chain switching. Can you try do it in here as well ?
Also can you provide your configuration setup for RainbowKit and wagmi ?

It’s 2.0.0 latest version.
On Thu, 22 Feb 2024 at 2:10 AM, Mago Khamidov @.***>
wrote:

@PearlSharma https://github.com/PearlSharma I just tried to reproduce
your issue and for me the trust wallet in app browser works fine with chain
switching. Can you try do it in here
https://rainbowkit-example.vercel.app/ as well ?
Also can you provide your configuration setup for RainbowKit and wagmi ?
—
Reply to this email directly, view it on GitHub
https://github.com/rainbow-me/rainbowkit/issues/1785#issuecomment-1957873079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5GX22BVPTJXNEZTBAGUW3YUZLUNAVCNFSM6AAAAABDSOJQ7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXHA3TGMBXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@PearlSharma Seems to be working on my end. Can you provide a small reproducible example ?
https://github.com/rainbow-me/rainbowkit/assets/53529533/fa4aa3a4-07ea-476a-8ca9-7cab68cef839

@PearlSharma Does it work for you in https://www.rainbowkit.com/ ? If it does then it seems like their project has some issues with projectId probably. Is that your project ?

@PearlSharma Any updates ?

Closing this issue for now since it's unknown what is going on and can't be reproduced on my end. Feel free to open a new issue if you're still facing this problem with a reproducible example 🙏


Custom form for profile page

Hi, I need to customize my frontend form for ProfileForm action (Actually setting proper blocks as there will be quite a lot of fields, adding custom jQuery validation, etc) , however i can't find a way how can I create a CUSTOM FORM TEMPLATE for ProfileForm ? As profile fields will be static (nothing will be changing on production) - any workaround would be fine.
Thanks

Hi,
Did U manage to solve the issue?
This is exactly what I need as well. Actually I need something like a tabbed form with jQuery.

If you provide a custom Layout template for the MemberProfilePage_profile (and the same for MemberProfilePage_register) you'll have access to the $Form variable in the template, which will represent the register/edit form for the profile. You can then work directly with the fields by referencing
<% with $Form %>

<% end_with %>

Thank You for the prompt response, I'll try it!

@nyeholt I think this one can be closed.
Another solution is to use the updateProfileForm extension hook on MemberProfilePage_Controller:
public function updateProfileForm($form)
{
        $form->setTemplate('MyAccountForm');
}

Thank you for your contribution here. I just wanted to let you know that we’re looking to improve our management of issues and pull requests, with a goal to providing clear direction on how Symbiote contributes to the open source community. As part of this ongoing effort:

issues and pull requests that have been open prior to December 2017 with no recent activity are being closed

this is included

if you can confirm this remains applicable for SS3.6+ please do open it again

remaining issues and pull requests will be

categorised

on a clear path to resolution (whatever the next step may be).

This ultimately brings us one step closer to our ambition; being able to prioritise current issues and contributions in a timely manner. If you have any questions, please see https://www.symbiote.com.au/contributing for further information.


Coturn to Kraken communication

Hi, Cedric. Thanks for your work on this! I've been troubleshooting my current setup pretty extensively. I was trying to mock up a production configuration for kraken while using the kraken.fm source code to test it out. I'm using the latest code from both projects, btw. And I'm using the "relay" option in the kraken.fm code. Could you embellish on a proper setup for coturn to get this working? Thanks!
Current status:

kraken.fm is able to connect to the api (I'm running the coturn server and the kraken service on the same ec2 instance, btw)
the coturn server is handling packets and mapping ports
after about 10 seconds I get these errors:

2020/09/21 14:18:16 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:aa8888df-fc40-4c6f-8df1-7b34d2e593b8) OnSignalingStateChange(have-remote-offer)
2020/09/21 14:18:16 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:aa8888df-fc40-4c6f-8df1-7b34d2e593b8) OnICEConnectionStateChange(checking)
2020/09/21 14:18:16 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:aa8888df-fc40-4c6f-8df1-7b34d2e593b8) OnSignalingStateChange(stable)
2020/09/21 14:18:16 RPC.handle(id: 4d007d8a-76ee-4d0a-aa63-14f535455aa6, time: 0.026520s) OK
2020/09/21 14:18:16 RPC.handle(id: 6b2ecad7-4984-4c19-afcd-4b1fa2a38db6, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:16 RPC.handle(id: 6b2ecad7-4984-4c19-afcd-4b1fa2a38db6, time: 0.000125s) OK
2020/09/21 14:18:20 RPC.handle(id: a2b36796-57b2-4c80-89d7-70057c4535ff, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:20 RPC.handle(id: a2b36796-57b2-4c80-89d7-70057c4535ff, time: 0.000121s) OK
2020/09/21 14:18:23 RPC.handle(id: defe36ab-20ae-4cd5-ad70-7a2cecd0be9c, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:23 RPC.handle(id: defe36ab-20ae-4cd5-ad70-7a2cecd0be9c, time: 0.000090s) OK
2020/09/21 14:18:26 RPC.handle(id: fda56f2d-7f59-43bf-b77a-bdf86c8c9c2d, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:26 RPC.handle(id: fda56f2d-7f59-43bf-b77a-bdf86c8c9c2d, time: 0.000139s) OK
2020/09/21 14:18:26 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:aa8888df-fc40-4c6f-8df1-7b34d2e593b8) OnTrackTimeout()
2020/09/21 14:18:26 PeerClose(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:aa8888df-fc40-4c6f-8df1-7b34d2e593b8) now
2020/09/21 14:18:26 PeerClose(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:CLOSED) with <nil>
2020/09/21 14:18:26 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:CLOSED) OnConnectionStateChange(closed)
2020/09/21 14:18:26 HandlePeer(testing:ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D:CLOSED) OnICEConnectionStateChange(closed)
2020/09/21 14:18:29 RPC.handle(id: 72e68ef2-b410-4a91-9d30-92130868cd01, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:29 RPC.handle(id: 72e68ef2-b410-4a91-9d30-92130868cd01, time: 0.000090s) ERROR {"status":202,"code":5002002,"description":"peer ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D closed in testing"}
2020/09/21 14:18:32 RPC.handle(id: cde4f29a-df09-4606-87b4-229bf817e67b, method: subscribe, params: [testing ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D aa8888df-fc40-4c6f-8df1-7b34d2e593b8])
2020/09/21 14:18:32 RPC.handle(id: cde4f29a-df09-4606-87b4-229bf817e67b, time: 0.000089s) ERROR {"status":202,"code":5002002,"description":"peer ca5a8823-64e2-4b0f-9851-8fc9cd9cfb75%3ASGV5dGhlcmU%3D closed in testing"}```

You should configure both coturn and kraken to listen on the IP that can communicate to each other.
Similar issues https://github.com/MixinNetwork/kraken/issues/9

Thanks Cedric! I was able to dig around some more and match my coturn settings similarly to the issue that you linked. I also was able to see that you included coturn.service, so that was helpful.


Fix deprecation warnings in Actions workflow

The Actions workflows produce several deprecation warnings. This PR fixes them.

Update actions/checkout@v2 and actions/cache@v2 to v3
Replace unmaintained actions-rs/toolchain@v1 with dtolnay/rust-toolchain

According to the results of the checks this indeed fixes all warnings.

Great, thanks!


Resolve minor grammar issues

Just noticed a few small things in the Contributing documentation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! These are all good changes.


feat: Implement TLS listener for webhooks

Codecov Report
Attention: Patch coverage is 42.50000% with 69 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/cli.rs
0.00%
41 Missing :warning:

src/web.rs
4.34%
22 Missing :warning:

src/bin/git-events-runner.rs
0.00%
3 Missing :warning:

src/bin/gitrepo-cloner.rs
0.00%
3 Missing :warning:

Files with missing lines
Coverage Δ

src/cache.rs
66.77% <100.00%> (+0.79%)
:arrow_up:

src/config.rs
92.57% <100.00%> (+0.07%)
:arrow_up:

src/controller.rs
46.15% <100.00%> (+0.54%)
:arrow_up:

src/lib.rs
100.00% <100.00%> (ø)

src/resources/action.rs
99.50% <100.00%> (+<0.01%)
:arrow_up:

src/resources/trigger.rs
79.62% <100.00%> (+0.15%)
:arrow_up:

src/bin/git-events-runner.rs
0.00% <0.00%> (ø)

src/bin/gitrepo-cloner.rs
0.00% <0.00%> (ø)

src/web.rs
82.03% <4.34%> (-1.32%)
:arrow_down:

src/cli.rs
18.98% <0.00%> (-20.49%)
:arrow_down:


Add TraPPE united-atom force field

A force field XML is added for TraPPE united-atom alkanes and alcohols (some alkene parameters are included as well although these are incomplete and commented out).  A library of small molecules has been added for atom typing unit tests.

I think to fix appveyor change this line to:
- foyer/tests/*.txt


[models] Switch default auto field to BigIntegerField

Reaching the limits of a IntegerField takes some time, for sure... but when it happens it can be quite painful. :grimacing:
An example of this crashing the production environment is described there:

https://m.signalvnoise.com/update-on-basecamp-3-being-stuck-in-read-only-as-of-nov-8-922am-cst/

Maybe it could make sense to make sure that this Django app is not exposed to such an issue on very big Wagtail instances?

Autofield was added in #38. This makes sense to me. I do want to see a project hitting that limit with wagtail-footnotes :D

Since #38 was merged, only awaiting to be part of a release, I'll close this MR :slightly_smiling_face:


Build numbers are not processed as documented

There is no way to NOT have a build number, yet in some scenarios, one does not want to have build numbers.
Therefore, the way build numbers are defined must be refined.

Fixed in 0.117.0


Query Notification before marking PROCESSED

Created field of critical Notification is always 0,
because the field is updated to 0 when marking its status to PROCESSED
fix #1279
Signed-off-by: Cloud Tsai<EMAIL_ADDRESS>

@akramtexas , please help review this PR.  Thanks.

@cloudxxx8 LGTM 👍 Please rebase and I'm ready to approve.

@akramtexas I've rebased.  Thanks for the review.


Rw ah locale stuff

Add an api method to set the locale to localize dates for axis and tooltip
Description
Uses Intl.DateTimeFormat to localize date formatting when passed a locale
Motivation and Context
All of our date formatting was not localized! :(
How Has This Been Tested?
ran the tests, added test too
Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

closes #227

got a 👍  from annie :) merging!


How to trigger the print event in viewer.js from viewer.html by clicking the external button

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version:
Is a browser extension:

Steps to reproduce the problem:
1.
2.
What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

You can put the print event on the event bus to trigger the printing action. That is also what the print button does on click (https://github.com/mozilla/pdf.js/blob/8512596508e31a72eb3d22e3a1c669e5d9ee4a7d/web/app.js#L1376).

@timvandermeij  Thank you so much... but what is the eventBus in pdf.js

It is defined here: https://github.com/mozilla/pdf.js/blob/master/web/ui_utils.js#L523
Basically it allows components to communicate in a generic way using events. If a component dispatches the print event, other components that listen for it can trigger and perform an action.

@timvandermeij  thank you so uch


[REQUEST] Ensure we are appending the chain certificate when using SSL

Is your feature request related to a problem? Please describe.
Currently when debugging hosts that Proksi handles, we get a B score from https://www.ssllabs.com/ssltest/analyze.html?d=proksi-cdn.dynoble.network&hideResults=on
Describe the solution you'd like
It seems that recently Let's Encrypt stopped including the chain cert in our cert requests and thus we have to make this an explicit step in the acme-client.
Describe alternatives you've considered
N/A
Additional context
N/A

Added E5 PEM based on https://letsencrypt.org/certificates/


methods / events

I always used vue-youtube-embed  which worked very well, but sadly doesn't work with Vue3.
This component has methods like playVideo and pauseVideo and also events like @ready, @playing, @ended and @paused.
Do you have plans to add these kind of features?

@wobsoriano it would be awesome if this component could emit the playing, ended and paused events. Is this on your roadmap or would you consider out of the 'Lite' scope?


fix: build fails with an resolve.alias called plugins fix #48

Please check the spacing.

@sokra we use 4 space?
Thanks

Please use tabs.

@sokra done

Thanks

No problems!
It will be nice to have it in npm


Translation of Attribute descriptions

How to translate an Attribute description text?

Hey there,
Descriptions are not yet implemented.
However I already thought about that, I could add this option as a new configuration dropdown.
It should not take that much time to implement, will add it soon.

Many thanks! I'll wait with impatience!
FV

Hey there,
I just released v2.7.0, with this release you can choose, which component you want to translate.
This is only for entities and attributes right now, where you can choose between display name and description.
Kind Regards,
Florian

Hi Florian!
Works fine! Many thanks.
Regards,
Firat


[Feature Request]: Add Leet Code Problem 2396

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
An integer n is strictly palindromic if, for every base b between 2 and n - 2 (inclusive), the string representation of the integer n in base b is palindromic.
Given an integer n, return true if n is strictly palindromic and false otherwise.
A string is palindromic if it reads the same forward and backward.
Use Case
Input: n = 9
Output: false
Explanation: In base 2: 9 = 1001 (base 2), which is palindromic.
In base 3: 9 = 100 (base 3), which is not palindromic.
Therefore, 9 is not strictly palindromic so we return false.
Note that in bases 4, 5, 6, and 7, n = 9 is also not palindromic.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

/assign

@Ajay-Dhangar please assign me the issue


connectHierarchicalMenu must forward items.items

Right now it sends items.children. While we have widgets like CurrentRefinements sending items.items when nested on nested data.
Always easier to have a single way of dealing with nested structures.
(connectors consistency)

@vvo should we settle for items.items? Or items.children?

@vvo should we settle for items.items? Or items.children?

items.items then


Add geolocation

It might be a good idea to add the geolocation of the company if it can be determined. This would help someone that might want to put the companies on a map.
{
  "location": {
    "lat": 33.738987255507,
    "lng": -116.40833849559
  }
}

Pull request accepted - thanks!


Added example of creating a system from a closure

Fixes #4262

Title suggestion for you @bytemuck (they show up in our commit history, so it's not just bikeshedding): "Added example of creating a system from a closure"

Awesome! I'll take a look for this tomorrow. I gotta sleep, I have school tomorrow. 👍

@bevyengine/docs-team can I get a second review here?

Wouldn't it be much more useful if you showed receiving a resource or entity query?

Wouldn't it be much more useful if you showed receiving a resource or entity query?

Without the ability to add systems dynamically, this isn't exactly feasible. None of the world's data exists at the time of system initialization. However, once #279 is solved, we should update this example to include that :)

bors r+

Wouldn't it be much more useful if you showed receiving a resource or entity query?

Maybe it would be more useful, but I think we should use simplicity over utility in this context, because usually, users will already have knowledge about how the engine works. It will most like not be the first example they will read.

Without the ability to add systems dynamically, this isn't exactly feasible. None of the world's data exists at the time of system initialization. However, once #279 is solved, we should update this example to include that :)

it should already work, you can use as a system: |query: Query<(Entity, &Transform)>| {... whatever}

Ah; I'd interpreted the request as "capture data from a resource, and then generate a new system that stores that data". But your read is much more reasonable.


HiveCPQ - Product Configurator (Certified Connector)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ x] I attest that the connector works and I verified by deploying and testing all the operations.
[ x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@microsoft-github-policy-service agree company="NimbleOps NV"

Hello!
While we await feedback from the review, would it be possible to see where we can find the issues the API properties validator finds? I couldn't find the correct place to view the results of why it fails.
Thanks in advance!

Hello @HiveCPQIntegration,
Thank you very much for your concern.
This issue is from our end and we are actively working on to fix the issue.
Thanks for your patience and understanding.

Hello @HiveCPQIntegration,
The pipeline was experiencing internal issues, we have resolved them. Could you please resubmit your PR/commit so that it can be triggered again and undergo validation? Thank you for your understanding. We apologize any inconvenience caused.


Mod Manager Not Opening

When I run the drg_mod_integration.exe the console pops up for half a second and than closes.

It worked fine before and I don't know what happaned that it doesn't work now...

Here are my Corrupted files:
config.json
mod_data.json

Also this:


test: add the test case for org.dromara.soul.plugin.sync.data.webosck…

…et.handler.AuthDataHandler

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #588 (3194f3d) into master (47dc629) will increase coverage by 3.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
+ Coverage     31.65%   34.67%   +3.01%
- Complexity      513      554      +41
============================================
  Files           198      198
  Lines          4669     4669
  Branches        497      497
============================================
+ Hits           1478     1619     +141
+ Misses         3064     2916     -148
- Partials        127      134       +7

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/dromara/soul/admin/page/PageParameter.java
82.35% <0.00%> (+5.88%)
6.00% <0.00%> (+1.00%)

...org/dromara/soul/admin/result/SoulAdminResult.java
80.00% <0.00%> (+6.66%)
8.00% <0.00%> (+1.00%)

...nc/data/weboscket/handler/AbstractDataHandler.java
8.33% <0.00%> (+8.33%)
1.00% <0.00%> (+1.00%)

...ava/org/dromara/soul/admin/vo/RuleConditionVO.java
66.66% <0.00%> (+66.66%)
1.00% <0.00%> (+1.00%)

...org/dromara/soul/admin/entity/RuleConditionDO.java
66.66% <0.00%> (+66.66%)
1.00% <0.00%> (+1.00%)

...mara/soul/admin/controller/MetaDataController.java
80.95% <0.00%> (+66.66%)
9.00% <0.00%> (+8.00%)

...omara/soul/admin/service/impl/RuleServiceImpl.java
95.12% <0.00%> (+86.58%)
17.00% <0.00%> (+16.00%)

...rc/main/java/org/dromara/soul/admin/vo/RuleVO.java
100.00% <0.00%> (+100.00%)
2.00% <0.00%> (+2.00%)

...ain/java/org/dromara/soul/admin/entity/RuleDO.java
100.00% <0.00%> (+100.00%)
4.00% <0.00%> (+4.00%)

...dromara/soul/admin/transfer/ConditionTransfer.java
100.00% <0.00%> (+100.00%)
1.00% <0.00%> (+1.00%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47dc629...3194f3d. Read the comment docs.

the code annotation is cool!

Thanks!


Minor UI Issue on Iphone - Temp (and Humidity) Offset + or -  - cant write +

I started testing the updated  version of the Temp/ Humidity sensors
There's a small UI issue with both the temperature and the humidity offset preferences at least on iPhone. The keyboard that comes up has a little + and - at top and the numbers under it. All cool. But you can't actually type a +3 the plus key is inactive. You can, however, type a '-' sign. Unless someone knows a way to 'activate' the plus key - I suggest we change the instructions to say '3' or '-3' rather than '+3' or '-3'.
Plus does nothing - doesn't type a +

Minus actually changes the value to a negative and put in '-' character

By the way, all of the revised preferences text for any DTHs with an offset setting now don't mention using + for positive offsets.
Still don't know what Android users see when they edit any of these settings marked as type: number or type: decimal.

I think we can close this for now then.  This is pretty minor.


Merge in rtorrent client_path fix

Merge in https://github.com/TiarnanRedmond/autotorrent/pull/1/files

I originally thought it was mostly putting rtorrent .torrent file in a specific location but it seems like it is designed to align paths in regards to e.g. docker?

In these situations, do you align the data path so soft links will work or do you use hard links ?

So you align the data path but not the store path? Is there a reason for that now autotorrent has dynamic store paths?

It was just confusing b/c I was using it in docker and I didn't realize the paths weren't lining up.  You can see others had issues too.  It's not a big deal for me now that I've solved it but I went months w/o getting at1 to work.  I'm sure the same issue with come up again soon


Show info about user on hover over on game table

Stuff like tier or rank
http://forums.halite.io/t/view-rank-of-other-users/380

I think this can be closed now, or is there additional/different information wanted?


Menu Bar

Hello,
I could not find a way to open the app without using the menut bar
I suggest that it opens like an app too.
Sorry to open this issue because I could not find the suggestion

Sorry I am having trouble understanding you.
If you meant: Can this be converted from menu bar app a windowed one?
Then the answer is yes! And is planned for v4


Data Site: possible problems with registration

In preliminary UI test of registration on Data Site, I seemed to have problems registering correctly. Needs to be revisited, and checked out.

Restested and workign


Progress bar is duplicated when used both as a context manager and as an iterable wrapper

Description
When used both as context manager (e.g. with) and as iterable wrapper, exhausting the iterable and exiting the with scope causes the progress bar to duplicate.
Code
Consider the following example code:
from time import sleep
from progressbar import ProgressBar
from progressbar.widgets import AnimatedMarker, SimpleProgress, GranularBar, Timer

def simple_iterator():
    for i in range(100):
        sleep(0.02)
        yield i

progress = ProgressBar(
    max_value=100,
    redirect_stdout=True,
    redirect_stderr=True,
    widgets=[AnimatedMarker("⡏⠟⠻⢹⣸⣴⣦⣇"), " ",
             SimpleProgress(), " ",
             GranularBar(markers="░▒▓█"), " ",
             Timer()]
)

with progress:
    for i in progress(simple_iterator()):
        pass

ASCIInema demo: https://asciinema.org/a/UEEc81s5GyrAR3QaqLDWGIMGX
Versions

Python version: 3.12.6 (main, Sep  8 2024, 13:18:56) [GCC 14.2.1 20240805]
Python distribution/environment: CPython
Operating System: Arch Linux, etc.
Package version: 4.5.0

I assume finish is invoked twice for some reason, because leaving in either a context manager only or iterable wrapper only, it works as expected.

Bumping because it's still an issue and was not solved.

Bumping because it's still an issue and was not solved.

Sorry about he inactivity, I've seen the issue but I've had very little time.
It's definitely a bug :)


[modify] make cookies more secure

Coverage decreased (-11.9%) to 72.541% when pulling 0182e6f60590ee2a2dfdeb2bd757e7998c4e360e on sunny4381:features/same-site into af0fbc6eff82cafd5e4a726ae4d494ea0bd45734 on shirasagi:master.


license

Hello,
I just came across your project, noting that it seems to support .Net Core but needs updates, porting from project.json to csproj and large amounts of docs. Would you be willing to add a license so that others can use this? Since it'll need a fair bit of updates, will you be likely to work on it? If not, I'd humbly ask that you consider a lenient license such as MIT, WTFPL, public domain dedication, or BSD since I tend to prefer MIT and would like to fork and continue this work.

Hey,
I haven't had a chance to work on this recently. I'm happy to dedicate it
to the public domain however. I'll also happily review any pull requests.
On Tue, 6 Jun 2017, 15:32 Dan Wolf<EMAIL_ADDRESS>wrote:

Hello,
I just came across your project, noting that it seems to support .Net Core
but needs updates, porting from project.json to csproj and large amounts of
docs. Would you be willing to add a license so that others can use this?
Since it'll need a fair bit of updates, will you be likely to work on it?
If not, I'd humbly ask that you consider a lenient license such as MIT,
WTFPL, public domain dedication, or BSD.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/benpye/sharpui/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbA_zCK1AhUxL30fMLyQwGmd6AgqaMvks5sBWLggaJpZM4NxbiU
.

Thanks for the quick reply. I'll keep an eye out for a public domain dedication or license and start some work once that's committed.

Committed in #42723f549cf00a96cc2d1d9fec233495eb35bd7b

Thanks again :)


chore: add TS Config for Cypress

Description

Adds a TS Config for Cypress, since IDEs would throw multiple errors (like JSON module import not being allowed).
The configuration consists of the folllowing:

Recommended Config: https://docs.cypress.io/guides/tooling/typescript-support#Configure-tsconfigjson
resolveJsonModule and esModuleInterop, both of which are required to import JSON files

Changelog

adds TS Config

Not an expert, but LGTM 👍


Feature request: Option to make Switch & PS4 layouts align better

The button that PS4 (#185) uses for taking screenshots is not, by default, the same button that Switch uses for the same. I understand there's probably a good reason for this (HID?), but I would like an option to change this behaviour, because the PS4 becomes a bit of a combo breaker, since every other input mode uses S1 as a "select"-like button.
When this option is enabled, the buttons should align as follows.

GP2040-CE
Switch
PS4

S1
Minus
Touchpad

S2
Plus
Options

A2
Capture
Share

In most cases, this will ensure that the physical layout of the controller stays more constant across input modes.
This could be set in webconfig only (or even at compile time), but there's an argument to create a runtime shortcut for it too: A user using an adapter device to play on PS4 using a different input mode on GP2040-CE will also have the problem of buttons swapping semantic meanings when compared to Switch, XInput, etc, so in such a case it would also be useful to be able to toggle the behaviour manually.

@henrebotha ,
This is a good argument.  There is nothing preventing this from being a thing.

@henrebotha we will be adding the option in web-config to switch these buttons around in PS4 mode.

This has been added - closing request


Debugging seems broken

I use gdb over ethernet. Early threads are not loaded together at the same time, it's really slow. I want to load only the thread that have breakpoint (the one I clicked on).
Popup messages with value of variable have wrong size, and some part of value is hiden and scroll bar is appeared. It's definetelly a bug

Please file against the debugger extension you are using.


fix spellcheck action

🚀 Deployed on https://66fc5aa10c21d7c9de4de9fb--cozy-fox-0defec.netlify.app


TypeError: train() missing 1 required positional argument: 'monitored_metrics'

OS:Win10,64/ Ubuntu18.04
python: 3.6
keras: 2.2.4
tensorflow: 1.13.1(win10), 1.12.0(Ubuntu18.04)
Hi , When I train my own datasets, I got the error like below:
Traceback (most recent call last):   File "D:\Files\python\MachineLearning\GAN\ISR_train_153_x2_images.py", line 46, in <module>     batch_size=16, TypeError: train() missing 1 required positional argument: 'monitored_metrics'
Can someone figure out?

It's a little hard to fix unknown custom code such as ISR_train_153_x2_images.py.
However, just as the python interpreter mentions, the train function is missing the argument monitored_metrics. Try adding this to the arguments of the train function:
monitored_metrics={'val_generator_PSNR' : 'max'}
or, if you are not using neither the VGG nor the Discriminator networks
monitored_metrics={'val_PSNR' : 'max'}
I updated the training tutorial, which was missing this parameter. Thank you.

It's a little hard to fix unknown custom code such as ISR_train_153_x2_images.py.
However, just as the python interpreter mentions, the train function is missing the argument monitored_metrics. Try adding this to the arguments of the train function:
monitored_metrics={'val_generator_PSNR' : 'max'}
or, if you are not using neither the VGG nor the Discriminator networks
monitored_metrics={'val_PSNR' : 'max'}
I updated the training tutorial, which was missing this parameter. Thank you.

Yeah，I just find the metrics defined in file "ISR/utils/utils.py", I also found a comment error in line 190 in file "ISR/train/trainer.py", I think it should be
the values are the mode that trigger weights saving ('min' vs 'max').
not
('mix' vs 'max')

Good. Yes, thanks for the spotting the typo.


x86/64 relative update, lvgl demo, up_disable_irq work for any CPU

Summary
arch/x86_64/intel64: add support for framebuffer
Add lvgl and fb examples for qemu-intel64.
simplify interrupt logic and allow any CPU
Impact
No impact for CI/online environment
Testing
CI-test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


unable to copy output

The user is still unable to copy the output

auto copy output Commit: 8303239


fbcp-ili9341 running but no desktop

Hello,
I'm a bit of a Raspberry Pi beginner (first project) and I'm not sure if this is the right place to chase up this issue.
First of all, I'm running Raspbian Buster  on a Raspberry Pi Zero W.
I've managed to get this driver running. I'm able to see the on screen statistics and have been able to display the output from raspivid but I can't seem to get the Desktop to appear. I've followed the README to start fbcp-ili9341 on boot and the Welcome to the Raspbian Desktop splash screen appears for a moment. During that time the statistics from  fbcp-ili9341 are visible. After a moment, the splash screen disappears and the screen is black barring the statistics. I am able to start raspivid/raspistill from an ssh terminal and I can see the output on the TFT but I can't see the desktop on the screen.
I haven't seen anything in the README about this nor in other issues but I apologise if I've missed something.
Cheers,
James

Fresh install of Raspbian this morning fixed the issue, must have been something else I had tried prior to this driver.


maven transitive groovy dependency

When pulling down the latest dialect artifact from maven central, it includes a transitive dependency on the groovy lib. I believe this should only be an artifact at compile time of the lib, but not for downstream consumers of the lib.

I may re-open this but this may be a local environment snafu. Closing for now.

Confirmed. See the pom file from maven central as seen here:
http://central.maven.org/maven2/nz/net/ultraq/thymeleaf/thymeleaf-layout-dialect/1.3.1/thymeleaf-layout-dialect-1.3.1.pom

I remember trying to check that it was a compile time only dependency, but remember a test where if I don't include it then I'd get NoClassDefFoundErrors.  Do you think you'd be able to confirm this if you're working on a Java project by excluding the dependency in your maven config and seeing if your program still runs?

It's working for me so far, but I haven't done any particularly exhaustive tests. No immediate explosions. If the downloadable 1.3.1 jar works, then it ought to work in maven as well without a transitive dependency. I'll post back if any issues come up, but I'll be on vacation for the next 10 days or so.

So I fired up the Thymeleaf + Spring PetClinic example app and added the layout dialect to the template engine config.  Upon startup I got exceptions in the startup log because it couldn't find org.groovy.lang.Object or something like that.  When you're back from your vacation, could you see if you get those too?
I'll try on a non-Spring project as well to see if that makes a difference.


Added Check for vertex edge being None

Please review:
@skhtet
@mannyrivera2010
@J-Fid
@rkenyon1969
@blynch11p
The change is needed to check for the possible None out_vertex_id that might result from calling add_edge with no outer vertex available.
Without the check, if the vertex_instance is None then an error will be thrown.
A warning log message will result in the situation, but should not cause issues with the code.
(To Test commented code in graph.py should be un-commented to see warning log messages and to see issue just un-comment the vertex_instance assignment)

The code itself is fine, however, how is this tested?
During the make dev process?  during reindex? While loading recommendations from the UI?
And which logs? ES? Backend?

@blynch11p The code was tested with Soe implementing on the staging.  In addition reproduced the error that he was seeing originally by un-commenting out line 231.
The issue appears during the make dev process in trying to write the contents due to a situation where one of the vertices may not be available and hence tries an incorrect assignment.
The logs are all on the backend side that appear in the logger commands.  You might be able to talk to @skhtet to see them.

Ok, then adding a
print("vertex_instance is None")
statement in the if(vertex_instance == None) block worked for me, after uncommenting the line prior.

:+1:

:+1:
Tested and passed on staging.


Fixed activity result handling on Android.

There was a little problem with the vuforia activity, the onBackPressed was returning the same result code than the error.
And in VuforiaPlugin.java, the only result you were treating was the image received one. Other results were considered as error.
So I just added some constants and cleaned this a bit.

Hey @Stending - reckon you could you rebase this?

Done!

Thanks again. We're gonna make a slight few changes/updates after merging and then we'll make a release.