Fixed Random seed somewhere

I think we need to set a random seed somewhere. Because for example, the transition matrix (that I plot in a notebook now but we will merge to the figures lastly) should be consistent with the emission observations, but even now that I import the fitted lineages from figure 11, but still I think it will run that file again to get the fitted lineages out. Automatically they won't match without a random seed.
We also wanted to find the lineage tree figure in figure4 constant.
Something I can think of instead of it is saving the transition matrix (and call for plotting T) and in the case of figure 4, I can plot one of the lineages from the data that I know shows censorship. @aarmey

Then I think we need to build in the capacity to fit it in these specific places. Where are the random number generators that are causing this problematic variation?

For figure 4 is those two functions that generate the censored and uncensored lineages.
and when we calculate the accuracy.
I tried np.random.seed() in both figure files and in two runs got the same figure. I think it is good. I'll make a PR right now.


Smoothing fix #1222

Thanks for the help :smile:
I walked through and may have gotten a complete fix, I'm a little unsure, though, of the smoothing values in canvas. Unlike Cairo (which does smoothing per image pattern), smoothing is global to the context, so we need to change the smoothing value when we are finished with a bitmap fill or stroke.
Let me know if you see anything else


Relation types not shown for type=superroute

URL
https://community.openstreetmap.org/t/beginners-guide-to-route-relations/105018/8
How to reproduce the issue?
Browse to https://www.openstreetmap.org/#map=20/54.27619/-0.39679
Edit with iD
Select way https://www.openstreetmap.org/way/1053144093
Scroll down to "choose a parent relation"
The relation type of the superroute is not shown, leading to lots of people accidentally adding ways to superrelations.  In the UK I regularly fish these out and add to the actual relation, like at https://www.openstreetmap.org/changeset/142663029 .
Screenshot(s) or anything else?
https://community-cdn.openstreetmap.org/uploads/default/optimized/2X/8/882ea1f84ee04954765a6dbf48dc44a96984b82d_2_651x500.jpeg
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.27.1
Which browsers are you seeing this problem on?
Firefox

“Relation” is the generic label for any unrecognized relation type. This label also appears in other places, such as the change summary in the save screen, and is localizable.
Incidentally, the superroute relation type seems to have been the result of someone mishearing “route superrelation” and transposing it as “superroute relation”. The wiki talk page has some strongly worded criticism. If there needs to be a separate relation type for this kind of nesting, I wonder why route_master was never considered.
The main alternative approach is to nest a route relation inside another route relation. To disambiguate the two similarly tagged relations, mappers commonly add a name containing a suffix such as “(super)”. This proposal would formalize this practice but in the description key instead. Either way, it isn’t as big of a deal when someone adds a way to a route superrelation as when they add it to a superroute relation. The few data consumers that recognize non–public transportation route relations get all the tags they need from the immediate route relation, which would have the same basic tags anyways. The one data consumer I know of that supports superroute relations, Waymarked Trails, prefers nested routes.
Even if there isn’t enough consensus yet to surface superroute relations as a first-class concept in iD, a hidden preset for this relation type would at least make the relation label more descriptive and harder to confuse with the nested route relations. The id-tagging-schema repository is the place to request a preset for a new relation type, searchable or not.

@1ec5 You've linked to quite a lot of wikinonsense there :)
The statement on https://wiki.openstreetmap.org/wiki/Super-relation that "Nested relations are virtually undocumented and rarely used" is ... just not true.  Even in my small corner of the world, a quick glance at https://github.com/SomeoneElseOSM/database_qa_scripts/blob/main/osm_ldp1 (and ldp2 and ldp3) finds quite a lot of relations split into parts because they are two big to manage.
It's probably best to draw a veil of the talk page argument between two of our more opinionated contributors that you link to too.
Let me ask the question another way.  Example that I wanted to add https://www.openstreetmap.org/way/1053144093 to "The Cleveland Way".  How would I know to add it to https://www.openstreetmap.org/relation/31112 not https://www.openstreetmap.org/relation/4087652 ?
When I recently split the adjacent Wolds Way into https://www.openstreetmap.org/relation/78028 and https://www.openstreetmap.org/relation/16327210 , with https://www.openstreetmap.org/relation/16327216 as the "superroute" (or whatever you want to call it), how would I have done that in iD?  FWIW I did that in Potlatch (see https://www.openstreetmap.org/changeset/141232629 ) because I'm not an utter masochist, but it would have been possible to do it in JOSM.

The statement on https://wiki.openstreetmap.org/wiki/Super-relation that "Nested relations are virtually undocumented and rarely used" is ... just not true.  Even in my small corner of the world, a quick glance at https://github.com/SomeoneElseOSM/database_qa_scripts/blob/main/osm_ldp1 (and ldp2 and ldp3) finds quite a lot of relations split into parts because they are too big to manage.

I agree. Superrelations may have been relatively rare globally in 2011 when that statement was added, but even then they were the preferred solution for modeling Interstate and U.S. Routes in the United States, which need a hierarchical structure due to state-level management and extreme overall lengths. I think superroute was just a case of the left hand not talking to the right hand, and when the hands finally talked, there was a miscommunication.

Let me ask the question another way. Imagine that I wanted to add https://www.openstreetmap.org/way/1053144093 to "The Cleveland Way". How would I know to add it to https://www.openstreetmap.org/relation/31112 not https://www.openstreetmap.org/relation/4087652 ?

I already acknowledged that the UI isn’t as intuitive as it can be. The solution at a minimum is to add an unsearchable preset for superroute relations to id-tagging-schema. But I wouldn’t rule out the continuing potential for confusion among less experienced mappers, since you would still need to know the difference between a “route” and a “superroute”, the latter being OSM jargon that sometimes conflicts with actual route names.

When I recently split the adjacent Wolds Way into https://www.openstreetmap.org/relation/78028 and https://www.openstreetmap.org/relation/16327210 , with https://www.openstreetmap.org/relation/16327216 as the "superroute" (or whatever you want to call it), how would I have done that in iD?  FWIW I did that in Potlatch (see https://www.openstreetmap.org/changeset/141232629 ) because I'm not an utter masochist, but it would have been possible to do it in JOSM.

It is possible to create a relation of an unrecognized type in iD: at the bottom of the “Select feature type” menu is a generic “Relation” preset. This is the one you were seeing labeled. Select that preset and set the Type field to the desired type=* value. Alternatively, you could create a Hiking Route with nested Hiking Routes.

As a workaround, why don't we add a changeset validation whereby a super-relation route may only contain other relations, not individual ways?
I have a feeling that changeset validation has been under-utilized, or rather, mis-utilized: it complains about quite mundane features such as ditch-path crossings or untagged objects, but lets through quite glaring errors that would be relatively easily to detect at commit time (#9154, #8167, just the ones I reported).

@DujaOSM As an aside, I wouldn't rely on the OSM wiki for documentation in this area at all.  I'd look instead about how these features are actually mapped and tagged.  A number of people have updated wiki pages based on their limited experience in their local area and the assumption that "everyone else everywhere else in the world also does it that way".
For routes and roles https://taginfo.openstreetmap.org/relations is a better place to get a global picture (e.g. search for relation types and search for "route" - 4 versions have > 1000 usage).
However, "Thus, there's no way to distinguish simple routes and super-routes only by tagging (since both can be type=route)." is correct, but that's not the original request here - that was to for the UI to show those that have been mapped that way.

To disambiguate the two similarly tagged relations, mappers commonly add a name containing a suffix such as “(super)”.

To avoid confusion, iD could add a special case to check if a route relation contains another route relation and append this bit the parent relation’s label (not the name tag) in the relation list.
https://github.com/openstreetmap/iD/blob/bb17d5c24eb6c58724b8be83c646bfe0aa9cf3ad/modules/util/util.js#L182


[THRIFT-5760] Update minimal version of php

Update minimal version of php to 7.1
I know that currently 8.* is main version, but current code has to much dependencies on version 5, so let's move step by step.

[X] Did you create an Apache Jira ticket? https://issues.apache.org/jira/browse/THRIFT-5760
[X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[X] Did you squash your changes to a single commit?  (not required, but preferred)
[X] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@pkvach

@sveneld
I noticed a few more places in the documentation where PHP 5 is mentioned.
Could you please update those as well?
https://github.com/apache/thrift/blob/3b1c30c5a7fd4f0142ef93bb6e0221e4a69dcf12/lib/php/README.md?plain=1#L24
https://github.com/apache/thrift/blob/3b1c30c5a7fd4f0142ef93bb6e0221e4a69dcf12/doc/install/README.md?plain=1#L35

Thank you, I missed it.
Pull request is updated

LGTM, thank you

@Jens-G let's merge this pull request


Lead

"You can use a parallel job in Azure Pipelines to run a single job at a time in your organization."
If you come here to learn more about parallel jobs, the very 1st sentence is so confusing as to be off-putting. A parallel job can be used to run a single job at a time? OK, but then what's parallel about it? Is this trying to say jobs may be run, and optionally, run in parallel? Maybe lead by hazarding an informal definition of parallel jobs. "Parallel jobs refers to the ability to run more than one job at the same time, with certain limitations" or some such. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c6a488b-88f6-dff6-e2ee-402167e17ad4
Version Independent ID: 9a4dedda-e82c-2833-f28c-5ab346fb1b38
Content: Parallel jobs in Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/licensing/concurrent-jobs.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

@HughDevlin Thank you for the feedback, assigning this to the author for review.

Taking a look to see if I can come up with something a bit more clear.


Relationship widget

Relation widget:
What is it:
A relationship wizard that let the user select one entry from another collection. For example: Select an Author for a post.
How would it work:
Behind the scenes, it would use a search mechanism. It would be configurable somewhat like this (just a rough idea, not an actual implementation example)
{label: "Author", name: "author", widget: "relation", collection: "authors", seachFields: ["first_name", ["last_name"]], display:["title"]}
What we need to figure out:

A way for a control widget to hook into search
A way for a control widget to set something else than just value (since the value will end up just being the “foreign key” while the preview widget will need access to the full relation object(s))
...

Please consider following use cases when designig and implementing it:
Author avatar in the entries list item
Right now we have an author in the front matter which comes as String in the format of FirstName LastName. It would really great to be able to display author of the post in the list of entries using avatar and being able to format the output as Andre O. for example.
Change the author on the entry page
When editing a post it would be great to be able to pick an author from the autocomplete dropdown component instead of typing it.
Categories
Manage categories as a separate collection and when assign a post to multiple categories with autocomplete widget on the edit entry page.

Another use case we're seeing right now is managing a list of curated posts. For example selecting 6 curated posts that will appear on the front-page.
Eventually I think these different use cases will require several different relation widgets, rather than a one-size fits all. So I think the core thing we need to get right is the abstraction layers when building control and preview widgets to make sure all of these variations are easy to build (and make it easy to even tailor custom made relations widgets for specific projects)


openSUSE requires SDL2_mixer

On openSUSE, SDL2 is split into a bunch of different packages:
$ zypper search sdl2
Loading repository data...
Reading installed packages...

S  | Name                    | Summary                   | Type
---+-------------------------+---------------------------+-----------
i+ | libSDL2-2_0-0           | Simple DirectMedia Laye-> | package
i+ | libSDL2-2_0-0-32bit     | Simple DirectMedia Laye-> | package
   | libSDL2_gfx-1_0-0       | SDL2 Graphics Routines -> | package
   | libSDL2_gfx-1_0-0-32bit | SDL2 Graphics Routines -> | package
   | libSDL2_gfx-devel       | Libraries, includes and-> | package
   | libSDL2_gfx-devel-32bit | Libraries, includes and-> | package
   | libSDL2_image-2_0-0     | Simple DirectMedia Laye-> | package
i+ | libSDL2_mixer-2_0-0     | Simple DirectMedia Laye-> | package
i+ | libSDL2_net-2_0-0       | Simple DirectMedia Laye-> | package
   | libSDL2_net-2_0-0-32bit | Simple DirectMedia Laye-> | package
   | libSDL2_sound2          | Sound Sample Library fo-> | package
   | libSDL2_ttf-2_0-0       | Simple DirectMedia Laye-> | package
   | python-PySDL2           | Python ctypes wrapper a-> | srcpackage
   | python38-PySDL2         | Python ctypes wrapper a-> | package
   | python39-PySDL2         | Python ctypes wrapper a-> | package
   | python310-PySDL2        | Python ctypes wrapper a-> | package
   | SDL2                    | Simple DirectMedia Laye-> | srcpackage
   | SDL2-devel              | SDL2 Library Developer -> | package
   | SDL2-devel-32bit        | SDL2 Library Developer -> | package
   | SDL2_gfx                | SDL2 Graphics Routines -> | srcpackage
   | SDL2_image              | Simple DirectMedia Laye-> | srcpackage
   | SDL2_image-devel        | Development files for t-> | package
   | SDL2_mixer              | SDL2 sound mixer library  | srcpackage
   | SDL2_mixer-devel        | Development files for t-> | package
   | SDL2_net                | SDL2 networking library   | srcpackage
   | SDL2_net-devel          | Development files for t-> | package
   | SDL2_sound              | Sound Sample Library fo-> | srcpackage
   | SDL2_sound-devel        | Development files for t-> | package
   | SDL2_ttf                | Simple DirectMedia Laye-> | srcpackage
   | SDL2_ttf-devel          | Header files for the Si-> | package

I had to install SDL2_mixer to get the appimage to run. Not sure what I already had installed that is packaged differently though...

that's interesting, I removed the sdl2 mixer dependency a long time ago, but I will check again.


test.py doesn't report failure in case of info-level issue and --fatal-infos

I'd expect that the following tests should be treated as failing by the test.py.
// SharedOptions=--fatal-infos

@deprecated
String variable = "x";

main() {
  print(variable);
}

This test is reported as paiing. But we have here info-level issue (use of a deprecated variable) and --fatal-infos analyzer option. With this option enabled analyzer's return code became 1 and test.py should report it as a failure. But it doesn't.

If you check the code of pkg/test_runner/lib/src/test_file.dart, it has a comment saying:
/// *   Flags can be passed to dart2js, VM or dartdevc by adding a comment to
///     the test file:
///
///         // SharedOptions=--flag1 --flag2
///

That at least suggests that the analyzer won't see the flags.
I'd have thought that they would, because experiment flags work, but experiments are parsed out
separately from the SharedOptions lines, so it's quite possible that the analyzer sees only those,
and not the remaining shared options.


NIFI-8515 Upgraded Apache Tika to 1.26

Description of PR
NIFI-8515 Upgrades Apache Tika dependencies from 1.24 to 1.26:

Upgraded tika-core from 1.24 to 1.26 in nifi-framework-bundle and nifi-standard-bundle
Upgraded tika-parsers from 1.24.1 to 1.26 in nifi-media-processors

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[X] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

LGTM, +1


No Swarm or Kubernetes options in Add Environment page

Rancher Version:
v1.2.0-pre4-rc7
Docker Version:
1.10
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 12.06 on EC2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single Node with MySQL
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
N/A
Steps to Reproduce:

Run new instance.
Enable Github Auth.
Click on Add Environment from the Manage Environments page.

Results:
Cattle is the only option:

Expected:
The options include: Cattle, Kubernetes, and Swarm

rc7 out of the box doesn't work, incorrect UI tag, an incorrect branch for library catalog, and no infrastructure services automatically started for the default environment.
In the next rc version, these issues should be fixed and hte default environment templates will be available.


Expose environment variables from database into build commands

Environment variables can be added from the Admin and they will be used when running build commands. All the variables for that particular project will be expose to all the commands.

This is the first approach for this feature. There are more decision that can be made around this and improvements. Although, this is the easiest way to implement this since all the environment variables are exposed to all the commands (by using existing code for this) and there are no checkings to be done when running each command.

I QA this under Docker and Local building and my custom env variable was exposed in both scenarios.

If this is the path that we want to follow, I'd add tests for this new code.

This doesn't close, #3992. It only wraps up the first phase.

:tada:


Add support for open generics in config.MapType

Fixes #560

Would that be possible to add an overload so schema factory function receives "Type" as a parameter?

Fixed in #1600


Loading a Model

Thank you for sharing this code base!  I have a trained BNN and am having some trouble defining my trained model after loading up the state dictionary for the trained model.  Specifically, I am getting an error when calling the getModel() function.  There is some code below which reproduces the error, which seems to be an issue with creating the path to save the means and variances.  If I turn off the saving feature, I get another TypeError related to the model and layer classes.  Can you provide an example of loading up a trained model or some additional insight?  Thanks again!
--
from future import print_function
import os
import argparse
import torch
import numpy as np
from torch.optim import Adam
from torch.nn import functional as F
import data
import utils
import metrics
import config_bayesian as cfg
from models.BayesianModels.Bayesian3Conv3FC import BBB3Conv3FC
from models.BayesianModels.BayesianAlexNet import BBBAlexNet
from models.BayesianModels.BayesianLeNet import BBBLeNet
from models.BayesianModels.BayesianFeedForward import BBBFeedForward
from main_bayesian import getModel
device = torch.device("cuda:0" if torch.cuda.is_available() else "cpu")
net_type = 'lenet'
trainset, testset, inputs, outputs = data.getDataset('MNIST')
net = getModel(net_type, inputs, outputs).to(device)

Hi @jprezioso!
Looks like you're using the previous version of the code. The repository is going through several changes lately.
Here's a code for loading an already trained model.
import torch

import data
import metrics
import config_bayesian as cfg
from main_bayesian import getModel, validate_model

device = torch.device("cuda:0" if torch.cuda.is_available() else "cpu")

dataset = 'MNIST'
net_type = 'lenet'

weight_path = f'checkpoints/MNIST/bayesian/model_lenet_lrt_softplus.pt'  # Your weights

trainset, testset, inputs, outputs = data.getDataset(dataset)

train_loader, valid_loader, test_loader = data.getDataloader(
        trainset, testset, cfg.valid_size, cfg.batch_size, cfg.num_workers)

net = getModel(net_type, inputs, outputs, None, cfg.layer_type, cfg.activation_type)  # priors could be anything, it's going to be replaced anyway
net.load_state_dict(torch.load(weight_path))
net = net.to(device)

# Here, you got your pre-trained model. Now, just validating..
criterion = metrics.ELBO(len(trainset)).to(device)
valid_loss, valid_acc = validate_model(net, criterion, valid_loader, num_ens=cfg.valid_ens, beta_type=cfg.beta_type)

print('Validation Loss: {:.4f} \tValidation Accuracy: {:.4f}'.format(valid_loss, valid_acc))

Hope this helps!

Yes, thank you!


If so, it sounds like you didn't setup the dependencies properly.
 If so, it sounds like you didn't setup the dependencies properly.
You need to do:
# Using dependency_overrides is necessary due to flutter_riverpod depending on riverpod
dependency_overrides:
  hooks_riverpod:
    git:
      url: https://github.com/rrousselGit/riverpod/
      ref: master
      path: packages/hooks_riverpod
  flutter_riverpod:
    git:
      url: https://github.com/rrousselGit/riverpod/
      ref: master
      path: packages/flutter_riverpod
  riverpod:
    git:
      url: https://github.com/rrousselGit/riverpod/
      ref: master
      path: packages/riverpod

Yes right. Thanks will check with latest. 👍


Don't close modal on backdrop click

Hey,
Before my users can access a special page, they must agree my terms. Those terms are showed in a modal automatically open (checking by cookie...) but I'dont know and can't find a solution to not close the modal when people click outside of that modal (backdrop)
Anyone have a solution?
Thanks folk!
Fred

There is an undocumented option 'backdrop': 'static'  or data-backdrop="static" check the source.

You can close this, its now documented in 2.0.2-wip


Base Wallet Using only first recipient key for unpack

Reference : https://github.com/hyperledger/aries-framework-go/pull/463#discussion_r333629568
As per current logic of baseWallet.UnpackMessage() we try to decrypt message from very first recipient key, if we can't decrypt then we throw error, if we can decrypt we return message.

Will be fixed in #456 and #459

Fixed in #459

@fqutishat close


[MRG] Updated psd_welch documentation

Clarifies psd_welch function
closes #4147

Codecov Report

Merging #4158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4158   +/-   ##
=======================================
  Coverage   86.14%   86.14%
=======================================
  Files         354      354
  Lines       63852    63852
  Branches     9724     9724
=======================================
  Hits        55007    55007
  Misses       6156     6156
  Partials     2689     2689

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd0c4f...77fbe99. Read the comment docs.

thx @ARudiuk


[AWS] Guide to install Meilisearch using ECS

it will be great if we get clear steps to install Meilisearch using ECS

As this issue has already been dealt with, I will close it.

Why did you depreciate this and close it?

I've deprecated the repo because we've moved all the cloud providers to this new repo I didn't deprecate the issue.
As we no longer offer as much maintenance on this repo we don't plan to change the scripts for the time being by adding new functionality, the aim being to keep the images as simple as possible, as there are far too many options that can be added via AWS. So I closed it


[Bug] Torchvision convnext Core Dump and the engine file larger than 3GB

Expected behavior
This model should run successfully and the generated engine file should be close to the actual size of the model.
Actual behavior
When loading the model using the torch front-end, the engine file generated after compilation is too large, and core dump will occur when loading and executing from the local machine. The onnx front-end does not have this problem.
Environment
OS: "Ubuntu 20.04.6 LTS"
CUDA SDK version: 12.2
TVM version: 7ae7ea836169d3cf28b05c7d0dd2cb6a2045508e
GPU: NVIDIA A10 24GB
Driver Version: 535.129.03
CUDA Version: 12.2
Torch Version: 2.2.1
Torchvision Version: 0.17.1
Onnx Version: 1.15.0

Steps to reproduce
I use the following code to get the engine:
import tvm
import torch
import torchvision
from tvm import relay

model = torchvision.models.convnext_base(weights=True)
model.eval()

dummy_input = torch.randn(2, 3, 224, 224)
trace_model = torch.jit.trace(model, dummy_input).eval()

mod, params = relay.frontend.from_pytorch(trace_model, [('input', (2, 3, 224, 224))])

target = tvm.target.cuda()

with tvm.transform.PassContext():
    lib = relay.build(mod, target, params=params)

lib.export_library("convnext.so")

and when i try to load this engine with:
module = tvm.runtime.load_module("convnext.so")

Core Dump!
I noticed that the size of the Engine file is: 3.8G, But the original model size is: 339MB. And I remember that there was a limitation that models larger than 3GB could not be loaded before. I guess this might be the reason.
Strangely, when I export the model to ONNX, I don't encounter similar issues, and the generated engine file size is 340MB:
import tvm
import torch
import torchvision
import onnx
from tvm import relay

onnx_path = "convnext.onnx"

model = torchvision.models.convnext_base(weights=True)
model.eval()

input_names = ['input']
output_names = ['output']
dummy_input = torch.randn(2, 3, 224, 224)

torch.onnx.export(
    model,
    dummy_input,
    onnx_path,
    input_names = input_names,
    output_names = output_names,
    opset_version=13
)

onnx_model = onnx.load(onnx_path)

mod, params = relay.frontend.from_onnx(onnx_model, {'input':(2, 3, 224, 224)})

target = tvm.target.cuda()

with tvm.transform.PassContext():
    lib = relay.build(mod, target, params=params)

lib.export_library("convnext_onnx.so")

module = tvm.runtime.load_module("convnext_onnx.so")

So I suspect that the Torch frontend might be incorrectly duplicating some constant weights when parsing certain Ops.
Triage

needs-triage

Seems like the torch.nn.Linear converter is the root of the problem.
Minimum repro.
import tvm
import torch
import onnx
from tvm import relay
import os

class LinearModel(torch.nn.Module):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.linear = torch.nn.Linear(in_features=128, out_features=512, bias=True)

    def forward(self, x: torch.Tensor) -> torch.Tensor:
        return self.linear(x)

def main():
    target = "llvm"
    dummy_input = torch.randn(2, 56, 56, 128)

    linear_model = LinearModel()

    # torch frontend
    trace_model = torch.jit.trace(linear_model, dummy_input).eval()

    mod, params = relay.frontend.from_pytorch(trace_model, [("input", dummy_input.shape)])
    with tvm.transform.PassContext(opt_level=3):
        lib = relay.build(mod, target, params=params)

    lib.export_library("linear_model_torch.so")

    # onnx frontend
    torch.onnx.export(
        linear_model,
        dummy_input,
        "linear_model_onnx.onnx",
        input_names=["input"],
        opset_version=13,
    )

    onnx_model = onnx.load("linear_model_onnx.onnx")
    mod, params = relay.frontend.from_onnx(onnx_model, {"input": dummy_input.shape})

    with tvm.transform.PassContext(opt_level=3):
        lib = relay.build(mod, target, params=params)

    lib.export_library("linear_model_onnx.so")

    print("File size")
    print("  linear_model_torch.so : ", os.path.getsize("linear_model_torch.so"))
    print("  linear_model_onnx.onnx: ", os.path.getsize("linear_model_onnx.onnx"))
    print("  linear_model_onnx.so  : ", os.path.getsize("linear_model_onnx.so"))

if __name__ == "__main__":
    main()

It seems that this line of code caused it: https://github.com/apache/tvm/blob/567eeed38bdbcefb68e36328af6ab1501a81d51e/python/tvm/relay/frontend/pytorch.py#L2049
In this case, the A matrix is four-dimensional, and the B matrix is two-dimensional. It seems that broadcasting is not required when performing Matmul. Am I understanding this correctly?
Similar situations might exist, and I think whether broadcasting is necessary may require stricter condition checks. @mshr-h


⚠ Bofrost.de has degraded performance

In 62aa991, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1133 ms

Resolved: Bofrost.de performance has improved in 462ba4e.


Incorrect Lyft result (London, UK)

I like this tool. I did notice a little bug though, we don't have Lyft in London but it's a positive result.
I guess it's related to checking if the query includes the string rather than matching it exactly? i.e. "New London" is a Lyft city, so a term like Londo is also a positive match.

Fixed in latest version: https://build-pmsovolbme.now.sh


Can't add songs to playlist from other playlists.

Sometimes I'm in a playlist and I want to add songs to another playlist (people will create playlists for game soundtracks and stuff like that). But, it seems that the only button that appears when I hold down is the add to library button. This creates an extra step where I have to go to the song's album page, then add it.
I'm not sure if this is a bug, intended behavior, or just a small thing that slipped through, so I will not mark it as such. This seems like a relatively simple issue, so I intend to make a PR for this if I have time.
Probably will also add save to library.

From what I saw in the code, this looks like intended behavior, sorry I didn't look before I didn't think I had time to go look for it. I know maintainers aren't really looking at issues like this rn, but I would like some feedback on this idea. I won't move forward on a PR if this isn't something that the maintainers would want.

I totally aggree with you on this, even if it is currently intended behaviour. Unfortunately, we're currently on a hiatus and new functionality is gonna take a while to be accepted, but if you would like to open a PR, I'm sure I would love to review it :)


Out of memory exceptions thrown by dashboard monitoring tasks

From last week bunch of dashboard tasks are throwing out of memory exception.
It could be related to #2485. But the orphaned processes doesnt consume any memory though.
We should look more in to it and optimize the monitoring jobs if required .Also the VM can be upgrades to D3.

@ryuyu please research and come up with a recommendation here (should we kill the jobs, fix the OOM, anything else?)

Closing this issue since the jobs are in the process of deprecation.


Title:Deletion in array

Description
Description:
I would like to add algorithm of deletion in array at given index in array folder with proper comments and will mention best and worst time complexity and space complexity.
the algorithm will be as follows-->
firstly we will store element at given index in a variable and start shifting of elements from given index to last index-1 with the help of for loop as array[i]=array[i+1]. and finally return the stored element at given index i.e. "our deleted element is  'this' ".
Domain
Data Structure
Type of Contribution
Enhancement
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign

I would like to work on this issue ,can you assign me this issue

/assign


Update local election content: Androscoggin county

Spreadsheet: https://docs.google.com/spreadsheets/d/1dk58MD0qBAM37BDOZwKIz10hp5AARAIX8u_qvuDnYaI/edit#gid=0
Instructions: https://github.com/OpenMaine/maineballot/wiki/Updating-Maine-Ballot-for-an-upcoming-election

All towns updated on Spreadsheet for June 2022


Crash when filtering sources

Steps to reproduce

'Browse'
'Sources'
'Filter' in the upper right corner.
When only the 'Chinese' option is turned on, the app crashes after clicking on 'Multi' language.
When only the 'Japanese' option is turned on, the app crashes after clicking on 'Chinese' language.

Expected behavior
No crash.
Actual behavior
Crash.
Crash logs
komikku_crash_logs.txt
komikku_crash_logs (1).txt
Komikku version
Stable 1.12.1/Beta r9576
Android version
Android 14
Device
Lenovo TB371FC
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.12.1.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

after clicking on 'Multi' language => is this still inside Browse/Source/Filter?
Because the crash log saying it's crashing inside Manga detail page.

is this still inside Browse/Source/Filter
Right.
I tried to record a video.
https://github.com/user-attachments/assets/d67ddf65-835f-4719-834f-7fa29f0fe6f0


Added worker slack_ids. Datamigration to port ids for existing users

Coverage decreased (-57.3%) to 35.011% when pulling c0a311a484a76adb23376b7da01580b0dd3186ca on worker_slack_id into f4ab126223864d3092e6d9533b711dcff13622bf on master.

Coverage decreased (-57.3%) to 34.999% when pulling de9cb20bcae7ac9823598bb7b7189717ed0b85d9 on worker_slack_id into f4ab126223864d3092e6d9533b711dcff13622bf on master.

Coverage decreased (-57.3%) to 34.999% when pulling de9cb20bcae7ac9823598bb7b7189717ed0b85d9 on worker_slack_id into f4ab126223864d3092e6d9533b711dcff13622bf on master.

Coverage decreased (-57.3%) to 34.999% when pulling de9cb20bcae7ac9823598bb7b7189717ed0b85d9 on worker_slack_id into f4ab126223864d3092e6d9533b711dcff13622bf on master.

Coverage decreased (-57.4%) to 34.923% when pulling 3a681a89f43d11f235b258f4cf55d194258c1070 on worker_slack_id into ac163f26a4e8b5f66643cbb2e077f0efd1fb3a3d on master.

Coverage decreased (-0.2%) to 92.095% when pulling b6fc10bd8dcdc228dc89eae5b312d73c1f4671be on worker_slack_id into ac163f26a4e8b5f66643cbb2e077f0efd1fb3a3d on master.

Coverage increased (+0.04%) to 92.367% when pulling a388ddf21fc39386c4989e3461722f4c8a3d77c7 on worker_slack_id into ac163f26a4e8b5f66643cbb2e077f0efd1fb3a3d on master.

Coverage increased (+0.03%) to 92.404% when pulling a5dd4391f7b0f798214aa9685d1781c58801b1a8 on worker_slack_id into 2550cf335d4327d9629131a7ee9ce491785aad9b on master.

Coverage increased (+0.03%) to 92.404% when pulling 5d9db4b56e79163a9322609711ce5e87d6ef280f on worker_slack_id into 2550cf335d4327d9629131a7ee9ce491785aad9b on master.

Coverage decreased (-0.09%) to 92.287% when pulling 8024ed979446488b7fbbb91a8127ad73486bceeb on worker_slack_id into 2550cf335d4327d9629131a7ee9ce491785aad9b on master.


Allow limiting the count of monsters in a randomly generated encounter

Add a 'total monster count', to allow for requesting random encounters with only 1 monster, or only 2 monsters, etc. Useful to find one interesting encounter for a party against one big monster, rather than getting a collection of smaller weaker monsters (even if that might be a more challenging encounter).

This is wicked. Love the idea.
This + picking a location and a difficulty really is a perfect random encounter tool

Some corrections are needed. I've left comments in the diff.

I've pushed minor fixes to each of those comments, I think; let me know if they're not right!

This is now merged and live. Thanks!


Enterprise cookbook gradio fixes

What does this PR do?
Fixes a couple of left-over issues from https://github.com/huggingface/cookbook/pull/133
Who can review?
@stevhliu.

cc/ @MoritzLaurer

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


TypeScript declaration files not being picked by VSCode in javascript projects

Describe the bug

Although TypeScript definition files *.d.ts are being bundled within this NPM package, VSCode is not recognizing them for code completion and code insights.
To Reproduce
Steps to reproduce the behavior:

Import this repo in a new or existing javascript (browser or node.js) project
Open a .js file and declare the usage of this package
Type a variable name and then a dot (.)

Expected behavior

The available API services should be suggested and auto completed
Screenshots

Desktop (please complete the following information):

OS: [e.g. macOS Catalina]

Additional context

Noticed that under <my-project>/node_modules/devopness-sdk-js/dist there are *.d.ts definition files.

After investigation conducted by @brunoro it was understood that the issue was caused by IDE-specific settings on the client app.
Closing as it's not a real issue in this project.


Detected object in TensorRT VS Darknet model

Hi, when I convert my YOLOv3 model to tensorRT, some objects that can be detected in YOLOv3 are not detected in TensorRT with FP32 mode.
Objects detected in Darknet YOLOv3

Objects detected in TensorRT YOLOv3

Should I modify the training data or modify some settings in TensorRT ?

Is this your own model? please try to check the yolo config  in "tensorRTWrapper/code/include/YoloConfigs.h" and the nms threshold.

I solved this by modifying the training data, and retrain the model.
Thank you.


Fix multi_match type name

This solves [match] query does not support [match_type]".
Ref. https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html

Thanks for this, it's so easy for these sorts of things to slip through the net.

Published as 0.4.1


Disallow current/parent folders inside module path

Fixes #624
This PR disallows references to current and parent directory (e.g. common/../other-folder/App).
This check doesn't depend on allow-siblings argument, and new error will be shown only if path passes checks for relative or parent references at the beginning.
I've removed Mocha tests for no-relative-imports rule, so this is first rule that fully migrated to TSLint format tests.

first rule that fully migrated to TSLint format tests.

Whoohoo!

Thanks!
To be honest - I was too lazy to add all cases to mocha tests, and just updated existing TSLint bases tests 😭

Ha, more evidence that the bases tests are the way to go for easier contributing! 😉


[Bug]: showAlert message pops up on page load although js function is not set to run on page load

Is there an existing issue for this?

[X] I have searched the existing issues

Description
ShowAlert message pops up on page load although js function is not set to run on page load
Steps To Reproduce

Create a new API (with an incorrect URL, eg. https://jsonplaceholder.typicode.com/post)
Create JSObject1 with the following content

export default {
	myFun2: async () => {
		//use async-await or promises
		await Api1.run()
		return Api1.data
	}
}

Create JSObject2 with the following content

export default {
	myFun2: () => {
		//use async-await or promises
		return JSObject2.myFun2().catch(e=>{
		showAlert(JSON.stringify(e))
		})

	}
}

Reload the page, and see toast messagean

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud
 Front conversations

Cause of issue
The toast is shown during the process of "dry running" a function to determine its nature (sync or async).

@ohansFavour I believe this issue should be resolved with the recent changes we have made. Could you please check and close this ticket ?


Plugin URL not accessible when logged out

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
I've got a situation here where I need to get a token without using the Inventree's standard URL.
KiCad will eventually define one root URL which points to a plugin which provides endpoints for data exchange. Those are fixed and can't change.
In my plugin I tried to duplicate the /api/user/token/ url but when accessing it, it redirects me to the proper one which kinda makes sense but I can't have that in this case unfortunately. Is there a way to set a decorator of some sort to make that URL accessible without redirection?
All I need is a second URL which I can call to authenticate.
Steps to Reproduce
none
Expected behaviour
get a token
Deployment Method

[ ] Docker
[X] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.12.0 dev
Django Version: 3.2.19
Commit Hash: 951eb04
Commit Date: 2023-06-28
Commit Branch: run-locally
Database: sqlite3
Debug-Mode: True
Deployed using Docker: False
Platform: Windows-10-10.0.22621-SP0
Installer: GIT
Active plugins: [{'name': 'KiCadLibraryPlugin', 'slug': 'kicad', 'version': '0.0.1'}]
Please verify if you can reproduce this bug on the demo site.

[ ] I can reproduce this bug on the demo site.

Relevant log output
No response

This is not available as standard, and introducing such changes would be potentially problematic as it is linked with the auth system.
@afkiwers I'll discuss this one with you in person :)

Is this still required or did you clear this in person @SchrodingersGat?

It could still need such an option to provide an automatic authentication mechanism for my KiCad rest api proposal but at the moment it looks like they want to be provided with a token only rather than getting on created automatically through basic auth.

@afkiwers are you happy to close this out?

Yep


css: Enforce input/textarea background only on dlang.org

Hotfix for forum.dlang.org.

Interestingly this also affected the runnable examples, but I actually like the new CSS a lot more :)

Before:

Err. Hmm. CSS specficity shenanigans?
Note that it might look that way only in your browser.

Err. Hmm. CSS specficity shenanigans?

More "precise" selectors have a higher priority.

Yeah, specificity is actually the official term I think :) My guess was correct then?


Next release?

Hi there,
I see some changes since the latest release (0.20.0). In semver these changes would require a major version (since it's dropping support for Python2) ; what is left in the way of django-waffle 1.0.0?
Thanks :)

You raise a valid point. There is nothing blocking a 1.0.0 release. I will work on that this week.

Hey @clintonb wondering if there's been an update on this?
Would love to see 1.0.0 released 😄

Thanks @clintonb 👍


Calculation w.r.t dates result in error.

function f()
{
var today: Date = new Date(),
yesterday: Date = new Date(),
tomorrow: Date = new Date(),
tomorrow_in_ms: number = 0;
today.setHours(0, 0, 0, 0);
tomorrow.setHours(0, 0, 0, 0);
yesterday.setHours(0, 0, 0, 0);

tomorrow.setDate(tomorrow.getDate() + 1);
yesterday.setDate(yesterday.getDate() - 1);

tomorrow_in_ms = tomorrow - today; // from today till midnight

}
results in error:
" The right-hand side of an arithmetic operation must be of type 'any', 'number' or an enum type "

This is actually one of the great features of TypeScript... I.e. Date + Date and Date - Date are now both illegal. Just add .getTime() to both operands. This makes the code clearer and restores the symmetry between the operators.

Thanks!

As @billccn said, this is intentional. You can use tomorrow.getTime() - today.getTime() or even +tomorrow - +today


Next Steps

The link of Next Steps should be the steps for the scopes of the application and not FHIR SMART. If user isn't using FHIR SMART since the beginning why add as Next steps the link to the tutorial of Azure API for FHIR SMART on FHIR proxy? Please provide a better sequence in the tutorials or follow the steps from the flow chart in the tutorial Register the applications for Azure API for FHIR. The flow of the tutorials and how-to-guides is confusing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7dff7a5-4535-9115-aa83-ab9895795f5a
Version Independent ID: 129cf972-dd8b-0181-9ab7-67793f90e746
Content: Register a public client app in Azure AD - Azure API for FHIR
Content Source: articles/healthcare-apis/register-public-azure-ad-client-app.md
Service: healthcare-apis
Sub-service: fhir
GitHub Login: @hansenms
Microsoft Alias: mihansen

Thank you for the feedback.
The main use for the public client is for Javascript applications and SMART on FHIR apps. Scopes are not currently enforced for the service, so it does not seem like a logical next step. We will consider whether the Javascript tutorial is the right next step, but for now, we will keep the suggestion the way it is.
#please-close

@hansenms Thanks for the quick response and clarification provided. 👍


Enable multiple workers cooperated on batch prompt

llm-inference support start multiple worker for one deployment.
the design expect to handle batch prompts, do load balance among workers. then to short the inference duration for a batch

It's ok for me.


Design a test template that generates an acceptor for a given grammar and applies generated input to it frequently

See this discussion for details.

Fixed with commit 648c14e.
Have fun! ✌


V3 BuildOrder - Not setting makerFeeAssetData & takerFeeAssetData on Polygon

I have a buildOrder setup on Polygon but it is not including makerFeeAssetData & takerFeeAssetData. I'm using WETH contract on polygon 0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619.
// My setup is similar to this...
const CHAIN_ID = 137; // Polygon Mainnet

const ASSET_420 = {
  tokenAddress: '0xb4....',
  tokenId: '420',
  type: 'ERC721',
};

const ASSET_421 = {
  tokenAddress: '0xb4...',
  tokenId: '421',
  type: 'ERC721',
};

const ONE_WETH = {
  tokenAddress: '0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619', // WETH contract address
  amount: '100000000000000000', // Wrapped-ETH (WETH is 18 digits)
  type: 'ERC20',
};

// User A Trade Data
const walletAddressUserA = '0x1e....';
const assetsToSwapUserA = [ASSET_420];

// User B Trade Data
const walletAddressUserB = '0x44....';
const assetsToSwapUserB = [ASSET_421, ONE_WETH];

// ............................
// Part 1 of the trade -- User A (the 'maker') initiates an order
// ............................
const nftSwapSdk = new NftSwap(provider, signerUserA, CHAIN_ID);

const order = nftSwapSdk.buildOrder(
  assetsToSwapUserA,
  assetsToSwapUserB,
  walletAddressUserA, {
              takerAddress: walletAddressUserB,
              expiration: Math.floor(Date.now() / 1000 + 3600 * 24 * 2), // 2 days
              chainId: CHAIN_ID,
              feeRecipientAddress: process.env.NEXT_PUBLIC_FEE_RECIPIENT_ADDRESS,
              makerFee: ethers.utils.parseUnits('0.005', 'ether'), // 0.005 WETH
              takerFee: ethers.utils.parseUnits('0.005', 'ether'), // 0.005 WETH
          }
);
const signedOrder = await nftSwapSdk.signOrder(order, walletAddressUserB);

The signature request will show:
makerAddress: 0x0a...
takerAddress: 0x41...
feeRecipientAddress: 0xe7...
senderAddress: 0x0000000000000000000000000000000000000000
makerAssetAmount: 1
takerAssetAmount: 2
makerFee:<PHONE_NUMBER>000000
takerFee:<PHONE_NUMBER>000000
expirationTimeSeconds: 1666461
salt: 1666...
makerAssetData: 0x0257179....92
takerAssetData: 0x0257179....96
makerFeeAssetData: 0x
takerFeeAssetData: 0x

Should I be including makerFeeAssetData and takerFeeAssetData in the buildOrder orderConfig?
If so how can I encode that data to bytes? to include the values in the orderConfig?

Alright, I tested and the options do work but I'm unclear what the following parameters mean:
makerFeeAssetData: 0x
takerFeeAssetData: 0x
senderAddress: 0x0000000000000000000000000000000000000000

Also, on Polygon can I change makerFee and takerFee to WETH instead of MATIC?

Did you figure this out? Curious what you did.

import { defaultAbiCoder } from '@ethersproject/abi';
import { hexConcat } from '@ethersproject/bytes';

/**
 * @param tokenAddress - The ERC20 token address
 * @return The tokenAddress encoded as a bytes
 */
// https://github.com/0xProject/0x-protocol-specification/blob/master/asset-proxy/erc20-proxy.md
export function encodeErc20AssetData(tokenAddress: string): string {
    return hexConcat(['0xf47261b0', defaultAbiCoder.encode(['address'], [tokenAddress])]);
}

const encodeWETHDataMaker = encodeErc20AssetData(
        chain?.id === 137
            ? (process.env.NEXT_PUBLIC_WETH_ADDRESS as string)
            : (process.env.NEXT_PUBLIC_ETH_ADDRESS as string)
);

const encodeWETHDataTaker = encodeErc20AssetData(
        chain?.id === 137
            ? (process.env.NEXT_PUBLIC_WETH_ADDRESS as string)
            : (process.env.NEXT_PUBLIC_ETH_ADDRESS as string)
);

// used this in BuildOrder
makerFeeAssetData: makerNfts.length > 0 ? encodeWETHDataMaker : '0x',
takerFeeAssetData: encodeWETHDataTaker,

I would prefer if the fee was paid in native token though? I saw in the discord you had mentioned that simply not setting the feeAssetData should work for native token but im getting an error when I do that on mumbai.
Order Data: Note that the taker fee is in wei (.1 matic)
{
  "expirationTimeSeconds": "2524604400",
  "feeRecipientAddress": "0x7890E24087e658978a4eC658a64890961CD98EF9",
  "makerAddress": "0xF4eD4499Eb725B713bEaA84B9c11c0D3B1834ebD",
  "makerAssetAmount": "1",
  "makerAssetData": "0xa7cb5fb70000000000000000000000002953399124f0cbb46d2cbacd8a89cf0599974963000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000001a1348c012fee81df544d0ee33d670d47813bf228000000000000010000000001000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000",
  "makerFee": "0",
  "makerFeeAssetData": "0x",
  "salt": "1682575019",
  "senderAddress": "0x0000000000000000000000000000000000000000",
  "signature": "0x1c611af34805060d40ed45e7723e819592d01c36a1ebcb191da23fbb4639650034439b659175cdfe9b0378d7707132b56ccd547388be21ac35d16970d8f943324c02",
  "takerAddress": "0x0000000000000000000000000000000000000000",
  "takerAssetAmount": "1",
  "takerAssetData": "0x0257179200000000000000000000000042cd9ba06cf66cb5faedf66b98a330a68fda09870000000000000000000000000000000000000000000000000000000000000001",
  "takerFee": "100000000000000000",
  "takerFeeAssetData": "0x"
}

Error:
caught (in promise) Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted", method="estimateGas", transaction={"from":"0x0445e028645a40697B5856954681BCD1aC0461FA","to":"0x9866C45224667061F8C9E66Db38D9316A8d68951","data":"0x9b44d556000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000440000000000000000000000000f4ed4499eb725b713beaa84b9c11c0d3b1834ebd00000000000000000000000000000000000000000000000000000000000000000000000000000000000000007890e24087e658978a4ec658a64890961cd98ef90000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000016345785d8a000000000000000000000000000000000000000000000000000000000000967a67f000000000000000000000000000000000000000000000000000000000644a0eab00000000000000000000000000000000000000000000000000000000000001c0000000000000000000000000000000000000000000000000000000000000032000000000000000000000000000000000000000000000000000000000000003a000000000000000000000000000000000000000000000000000000000000003c00000000000000000000000000000000000000000000000000000000000000124a7cb5fb70000000000000000000000002953399124f0cbb46d2cbacd8a89cf0599974963000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000001a1348c012fee81df544d0ee33d670d47813bf2280000000000000100000000010000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000440257179200000000000000000000000042cd9ba06cf66cb5faedf66b98a330a68fda09870000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000421c611af34805060d40ed45e7723e819592d01c36a1ebcb191da23fbb4639650034439b659175cdfe9b0378d7707132b56ccd547388be21ac35d16970d8f943324c02000000000000000000000000000000000000000000000000000000000000","accessList":null}, error={"code":-32603,"message":"Internal JSON-RPC error.","data":{"code":3,"message":"execution reverted","data":"0x488219a600000000000000000000000000000000000000000000000000000000000000001cca45e29647859a1cf7aebf5c8e40a82ab325d204d4162dec9aa2946c5165d900000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"},"stack":"{\n  \"code\": -32603,\n  \"message\": \"Internal JSON-RPC error.\",\n  \"data\": {\n    \"code\": 3,\n    \"message\": \"execution reverted\",\n    \"data\": \"0x488219a600000000000000000000000000000000000000000000000000000000000000001cca45e29647859a1cf7aebf5c8e40a82ab325d204d4162dec9aa2946c5165d900000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000\"\n  },\n  \"stack\": \"Error: Internal JSON-RPC error.\\n    at new i (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:14454)\\n    at s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:17394)\\n    at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:18004)\\n    at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:129727)\\n    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:130726\\n    at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-3.js:10:64901\"\n}\n  at new i (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:14454)\n  at s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:17394)\n  at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:21:18004)\n  at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:129727)\n  at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:130726\n  at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-3.js:10:64901"}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.2)
    at Logger.makeError (index.js:224:1)
    at Logger.throwError (index.js:233:1)
    at checkError (json-rpc-provider.js:76:1)
    at Web3Provider.eval (json-rpc-provider.js:575:1)
    at Generator.throw (<anonymous>)
    at rejected (json-rpc-provider.js:6:42)

Try this for the address variable for encodeErc20AssetData
ETH = 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
MATIC = 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee or 0x0000000000000000000000000000000000001010

Does this only work on V4? Im using v3 currently.

Ya sorry, I think only ERC20 are supported on V3.
https://github.com/0xProject/0x-protocol-specification/blob/master/asset-proxy/erc20-proxy.md

good to know thanks


Demo: useKeyPressEvent is decrementing ('[') twice

What is the current behavior?
At https://streamich.github.io/react-use/?path=/story/sensors-usekeypressevent--demo
When we try to decrement the count by pressing [ key. It decrements the count by two, instead of one.
Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use. Paste the link to your JSFiddle or CodeSandbox example below:
https://streamich.github.io/react-use/?path=/story/sensors-usekeypressevent--demo
Press [ , the count decrements by two, instead of one.
What is the expected behavior?
To decrement the count by one per key press
A little about versions:

OS: macOS Mojave (10.14.6)
Browser (vendor and version): Chrome Version 80.0.3987.163
React: 16.8.0
react-use:
Did this worked in the previous package version?

I have also looked into this issue. Looks like we have called the decrement method twice.
https://github.com/streamich/react-use/blob/2665eb526bdfdb810d99989d78d90d77716aafa8/stories/useKeyPressEvent.story.tsx#L20
This will fix the issue.
  useKeyPressEvent('[', decrement);

@streamich I have also fixed this minor issue, please review it whenever you get a chance.
https://github.com/streamich/react-use/pull/1132


Add: build workflows of Github action

Also, I updated the entry file of the plugin. Because there's a bug about .js entry. But it'll be fixed in next release.

@xyhp915 — Thanks.    I got it properly released.  I'm still thinking of dropping the index.html but that can be saved for another day.  Have a good night.  Thanks for the assistance!


chore: turn back on Fabric build gates

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

/azp run

Codecov Report

Merging #2121 (8d00852) into master (ef435a2) will decrease coverage by 75.72%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

:exclamation: Current head 8d00852 differs from pull request most recent head 4752d56. Consider uploading reports for the commit 4752d56 to get more accurate results

@@             Coverage Diff             @@
##           master    #2121       +/-   ##
===========================================
- Coverage   86.23%   10.51%   -75.72%
===========================================
  Files         312      312
  Lines       16466    16466
  Branches     1452     1452
===========================================
- Hits        14200     1732    -12468
- Misses       2266    14734    +12468

see 260 files with indirect coverage changes

/azp run

/azp run


[tests-only][full-ci]Added tests for creating link for a resource

Description
This PR adds the implementation for new v1beta1 graph-api to create a share link.
Related Issue:
https://github.com/owncloud/ocis/issues/7968

https://github.com/owncloud/ocis/issues/8008 can be done once this is approved and merged!


There is no Introduction to Azure Setup

This page says:
Go to the Azure Quickstart Center in the Azure portal, select Introduction to Azure Setup, and then follow the step-by-step instructions.
When I click the link to Azure Quickstart Center I do not see an Introduction to Azure Setup.
Please indicate the correct steps to find it or change the wording to indicate where to start within the Azure Quickstart Center.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ccae000a-e695-350b-e765-e7ae9b9dd67f
Version Independent ID: bae3228c-33d9-a9e4-9c26-840756d0f75e
Content: Azure setup guide: Before you start - Cloud Adoption Framework
Content Source: docs/ready/azure-setup-guide/index.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @timleyden
Microsoft Alias: kfollis

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#191178

This issue has been resolved. Thanks!


Not working in renderer process: on("will-download", ... item.setSavePath(...); ...)

Hello,
DownloadItem.setSavePath() is supposed to prevent the save dialog, which is exactly what I need. However, this doesn't work in a renderer process. The save dialog still appears. In fact, the "will-download" event handler is called after the save dialog appeared and had been closed. The code was contracted for this issue:
require("electron").remote.getCurrentWebContents().session.on("will-download",
        function(event, item, webContents) {
    item.setSavePath(`C:\\Path\\${item.getFilename()}`);
});

Although, this does work in allowing you to cancel requests:
require("electron").remote.getCurrentWebContents().session.webRequest.onBeforeRequest(
        function(...) { ... });

Also, DownloadItem.setSavePath() in the main process works as expected. It prevents the save dialog:
let window = new require("electron").BrowserWindow();
...
window.webContents.session.on("will-download", function(event, item, webContents) {
    item.setSavePath(`C:\\Path\\${item.getFilename()}`);
});

Further, having a "will-download" event handler function in both processes basically works, because you can successfully use the DownloadItem in the renderer process to print the download status every second.

Unfortunately, I couldn't think of a workaround. I don't think there's any possibility to call a function of the renderer process from the main process synchronously and get a result which, then, could be used for setSavePath() to be called from the main process. Is there still some way to get the setSavePath() logic into the renderer process while this bug persists?

This behavior is intended, you can find more about it at:
http://electron.atom.io/docs/v0.36.0/api/remote/#passing-callbacks-to-the-main-process
And unfortunately there is no way to fix this for now, the download API exposed by Chromium is synchronous, unless we did a big refactor of related Chromium code, we have to live with it.

Okay, thanks for the information!


Casting error, minus-sign mistaken for an operator.

Describe the bug
When trying to pass my code through Norminette i receive faulty errors.
It happens when casting -1 as size_t. I get the following errors:
SPC_AFTER_PAR        (line:  20, col:  31):	Missing space after parenthesis (brace/bracket)
SPC_AFTER_OPERATOR   (line:  20, col:  32):	missing space after operator
Erroneous code
#include <stdio.h>

int	main(void)
{
	size_t	i;
	int		num;

	i = (size_t)-1;
	printf("%zu\n", i);
	num = (int)i;
	num = (int) i;
	return (0);
}

Additional infos

OS: macOS Big Sur 11.2.3
python --version: Python 2.7.16 / Python 3.9.2
norminette -v: norminette 3.2.3 (edit - 3.2.6)

Additional context
I also remember stumbling upon some arbitrary rule for casting in general (see casting 'i' as an int).
Maybe this has something to do with it?
P.S. just now also tested with 3.2.6, same issue.

This also happens with dereferencing.
Error: SPC_AFTER_OPERATOR   (line:  25, col:  27)
>   if (flag->p > (size_t)*len)

As well as the bitwise NOT ~ operator.
Error: SPC_AFTER_OPERATOR   (line:  96, col:  42)
>   if (flag->bit & FLAG_LEADING_ZERO && ~flag->precision)


docs: Add explicit command to su to zulip from prod step 5 on.

I'm not entirely convinced by my wording here, so please feel free to enhance.

Merged with some tweaks, thanks @derAnfaenger!


⚠ Bofrost.be has degraded performance

In a903478, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1190 ms

Resolved: Bofrost.be performance has improved in c3347f1.


Windows are line up in vertical order, how can it be changed to horizontal?

Hello,
Thank you for your plugin.
I want to line up windows like you have https://github.com/christoomey/vim-conflicted/raw/master/images/tablabel-terminal.png
Your windows are from left to right, but mines are from top to bottom. Maybe, you know how can I fix it?
Thank you & best regards,
Artem

Hey @whitesiroi, I'm guessing this is related to fugitvie.vim functionality, discussed here. Looks like you should be able to set :set diffopt+=vertical to solve.

Aaa, @christoomey thank you very much for your help. It does work perfectly.


Improve convergence in pvsystem/v_from_i

Fix typing to handle series inputs

Cliff, I'm not sure if it was your intent or not, but the proposed changes here are the same as #260. I do see some merge cruft in the whatsnew diff on #266. The joys of git!
In any case, this still needs a call to np.max to handle array-like input. It's probably most efficient to make np.max the first function call: np.ceil(np.log10(np.max(w))).astype(int)
Do we need to set a minimum order value? If all w are less than 1, all log10(w) will be negative, and all ceil will return 0 or less. order = np.maximum(order, 1) might work for that.
I also think there should be a maximum order value so that we don't end up in a near infinite loop for erroneous input. order = np.minimum(order, 10) might work, though I don't know what value to recommend.
Or we could avoid all of the above by following @mikofski's suggestion to use one of the scipy.optimize routines. I still think we have to separately call the routine on each element of array-like input, though. Wrapping the routine with np.vectorize might be ideal since it would take care of broadcasting for us.
Here's an extension of @mikofski's example in #266 that works with array input:
In [84]: def func(w, logargW):
    ...:     return w + np.log(w) - logargW
    ...:

In [91]: def fprime(w, *args):
    ...:     return 1 + 1/w
    ...:

In [92]: def solveit(logargW):
    ...:     return optimize.fsolve(func=func, x0=logargW, args=(logargW), fprime=fprime)
    ...:

In [93]: solveit(5)
Out[93]: array([ 3.69344136])

In [94]: solveit_vec = np.vectorize(solveit)

In [95]: solveit_vec(np.array([.25, .75, 5, np.inf, 0, 100]))
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: invalid value encountered in subtract
  if __name__ == '__main__':
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: divide by zero encountered in log
  if __name__ == '__main__':
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: divide by zero encountered in true_divide
  if __name__ == '__main__':
/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/scipy/optimize/minpack.py:161: RuntimeWarning: The iteration is not making good progress, as measured by the
  improvement from the last ten iterations.
  warnings.warn(msg, RuntimeWarning)
Out[95]:
array([  0.66219508,   0.87898614,   3.69344136,          inf,
         0.        ,  95.44148665])

In [102]: test_array = np.random.randn(10000)

In [103]: %timeit solveit_vec(test_array)
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: invalid value encountered in log
  if __name__ == '__main__':
/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/scipy/optimize/minpack.py:161: RuntimeWarning: The iteration is not making good progress, as measured by the
  improvement from the last ten iterations.
  warnings.warn(msg, RuntimeWarning)
1 loop, best of 3: 720 ms per loop

In [104]: def manual(logargW):
     ...:     w = logargW
     ...:     order = np.ceil(np.log10(np.max(w))).astype(int)
     ...:     order = np.maximum(order, 1)
     ...:     order = np.minimum(order, 10)
     ...:     for i in range(0, 3*order):
     ...:         w = w * (1 - np.log(w) + logargW) / (1 + w)
     ...:     return w
     ...:

In [105]: %timeit manual(test_array)
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:7: RuntimeWarning: invalid value encountered in log
The slowest run took 6.19 times longer than the fastest. This could mean that an intermediate result is being cached.
1000 loops, best of 3: 454 µs per loop

I also tried the same approach with the newton routine. It seemed slightly faster than fsolve but threw exceptions for some inputs.

That wasn’t my intent, just me being clumsy with git.  I thought I’d started fresh but it looks like it’s all still connected.  I wanted to do this small change to learn how to use git, and for that, mission not accomplished.
Practically speaking, logargW is determined by Rsh*IL, which can be expected to be <10^6, so order<6.  Now that I think about it, I’d just skip this whole business and set range(0,8). We get roughly 2 digits in base 10 of precision with each iteration, so 9 iterations should get us double precision (53 bits) for the mantissa of w.
In Matlab, we only do the logspace calculations where argW is too large.  That filtering is not present in the python version; we calculate the logspace values for all inputs. If there’s need for a performance improvement, maybe that filter would help.
I’d rather not use scipy.optimize.newton in this instance because its stopping criteria is an absolute (not relative) tolerance on w (or a maximum number of iterations).  We want precision across such a large range of magnitudes that the tolerance has to scale with the argument, and it seemed simpler to scale the iteration count.  I also prefer explicit code over package references, but that’s more of a Matlab mindset I’m projecting onto python.
Cliff
From: Will Holmgren<EMAIL_ADDRESS>Sent: Tuesday, November 22, 2016 10:44 AM
To: pvlib/pvlib-python<EMAIL_ADDRESS>Cc: Hansen, Clifford W<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [pvlib/pvlib-python] Improve convergence in pvsystem/v_from_i (#268)
Cliff, I'm not sure if it was your intent or not, but the proposed changes here are the same as #260https://github.com/pvlib/pvlib-python/pull/260. I do see some merge cruft in the whatsnew diff on #266https://github.com/pvlib/pvlib-python/pull/266. The joys of git!
In any case, this still needs a call to np.max to handle array-like input. It's probably most efficient to make np.max the first function call: np.ceil(np.log10(np.max(w))).astype(int)
Do we need to set a minimum order value? If all w are less than 1, all log10(w) will be negative, and all ceil will return 0 or less. order = np.maximum(order, 1) might work for that.
I also think there should be a maximum order value so that we don't end up in a near infinite loop for erroneous input. order = np.minimum(order, 10) might work, though I don't know what value to recommend.
Or we could avoid all of the above by following @mikofskihttps://github.com/mikofski's suggestion to use one of the scipy.optimize routines. I still think we have to separately call the routine on each element of array-like input, though. Wrapping the routine with np.vectorize might be ideal since it would take care of broadcasting for us.
Here's an extension of @mikofskihttps://github.com/mikofski's example in #266https://github.com/pvlib/pvlib-python/pull/266 that works with array input:
In [84]: def func(w, logargW):
...:     return w + np.log(w) - logargW

...:

In [91]: def fprime(w, *args):
...:     return 1 + 1/w

...:

In [92]: def solveit(logargW):
...:     return optimize.fsolve(func=func, x0=logargW, args=(logargW), fprime=fprime)

...:

In [93]: solveit(5)
Out[93]: array([ 3.69344136])
In [94]: solveit_vec = np.vectorize(solveit)
In [95]: solveit_vec(np.array([.25, .75, 5, np.inf, 0, 100]))
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: invalid value encountered in subtract
if name == 'main':
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: divide by zero encountered in log
if name == 'main':
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: divide by zero encountered in true_divide
if name == 'main':
/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/scipy/optimize/minpack.py:161: RuntimeWarning: The iteration is not making good progress, as measured by the
improvement from the last ten iterations.
warnings.warn(msg, RuntimeWarning)
Out[95]:
array([  0.66219508,   0.87898614,   3.69344136,          inf,
     0.        ,  95.44148665])

In [102]: test_array = np.random.randn(10000)
In [103]: %timeit solveit_vec(test_array)
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:2: RuntimeWarning: invalid value encountered in log
if name == 'main':
/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/scipy/optimize/minpack.py:161: RuntimeWarning: The iteration is not making good progress, as measured by the
improvement from the last ten iterations.
warnings.warn(msg, RuntimeWarning)
1 loop, best of 3: 720 ms per loop
In [104]: def manual(logargW):
 ...:     w = logargW

 ...:     order = np.ceil(np.log10(np.max(w))).astype(int)

 ...:     order = np.maximum(order, 1)

 ...:     order = np.minimum(order, 10)

 ...:     for i in range(0, 3*order):

 ...:         w = w * (1 - np.log(w) + logargW) / (1 + w)

 ...:     return w

 ...:

In [105]: %timeit manual(test_array)
/Users/holmgren/miniconda3/envs/pvlib35/bin/ipython:7: RuntimeWarning: invalid value encountered in log
The slowest run took 6.19 times longer than the fastest. This could mean that an intermediate result is being cached.
1000 loops, best of 3: 454 µs per loop
I also tried the same approach with the newton routine. It seemed slightly faster than fsolve but threw exceptions for some inputs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pvlib/pvlib-python/pull/268#issuecomment-262311546, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFJNL9NZ14DBJ0qMiX3WRJAPD03K4egGks5rAynOgaJpZM4K4_LT.

That all sounds good to me.  Maybe with more iterations it becomes worthwhile, or maybe not.


Fix broken Markdown links check

check-modified-files-only can only be used for pull_request events (as
per the documentation for the action), and github.base_ref is not set
for push events.
At the moment the Github job is failing because it is run for push
events on the main and release branches.
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

A typo in commit description: oush -> push

thanks, fixed

/skip-all

Codecov Report

Merging #3671 (e52906b) into main (a566009) will decrease coverage by 20.76%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3671       +/-   ##
===========================================
- Coverage   64.58%   43.82%   -20.77%
===========================================
  Files         278      210       -68
  Lines       39363    35650     -3713
===========================================
- Hits        25421    15622     -9799
- Misses      11963    18893     +6930
+ Partials     1979     1135      -844

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
43.82% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


[sbom] Store generation duration and report it

What does this PR do?
Stores in workloadmeta the time that it takes to generate SBOMs so that the SBOM check can send them to the intake.
The PR also includes the generation duration in the telemetry (workloadmeta.sbom_generation_duration).
Describe how to test/QA your changes
Enable image metadata collection, sbom collection, the SBOM check, and the agent telemetry:

DD_CONTAINER_IMAGE_COLLECTION_METADATA_ENABLED=true.
DD_CONTAINER_IMAGE_COLLECTION_SBOM_ENABLED=true.
DD_SBOM_ENABLED=true.
DD_TELEMETRY_ENABLED=true.
Mount sbom.yaml with the default config.

Then:

Check that the SBOM generation duration is included in the telemetry. curl http://localhost:6000/telemetry and look for workloadmeta_sbom_generation_duration (histogram).
Check that the duration is included in workloadmeta: agent workload-list --verbose | grep SBOM.
Check that the duration is reported. For now, the best way to verify this is to check the payloads in our internal logs.

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@L3n41c I've added the logic to store and send GenerationTime.


Mass Obsoletion: focus on branch 'integumentary system disorder' (MONDO:0002051)

branch:  'integumentary system disorder' (MONDO:0002051)
Terms to obsolete:

obsoletion candidate ID
obsoletion candidate label

http://purl.obolibrary.org/obo/MONDO_0016434
acquired dermis elastic tissue disorder

http://purl.obolibrary.org/obo/MONDO_0019271
acrokeratoderma

http://purl.obolibrary.org/obo/MONDO_0015818
aggressive primary cutaneous B-cell lymphoma

http://purl.obolibrary.org/obo/MONDO_0015817
aggressive primary cutaneous T-cell lymphoma

http://purl.obolibrary.org/obo/MONDO_0017670
autosomal dominant diffuse mutilating palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0020093
autosomal dominant isolated diffuse palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0017270
autosomal ichthyosis syndrome

http://purl.obolibrary.org/obo/MONDO_0020096
autosomal recessive isolated diffuse palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0017922
deafness-onychodystrophy syndrome

http://purl.obolibrary.org/obo/MONDO_0019292
dermis elastic tissue disorder

http://purl.obolibrary.org/obo/MONDO_0020197
EEC syndrome and related syndrome

http://purl.obolibrary.org/obo/MONDO_0019277
epidermal appendage anomaly

http://purl.obolibrary.org/obo/MONDO_0035685
epidermolysis bullosa simplex with extracutaneous involvement

http://purl.obolibrary.org/obo/MONDO_0035684
epidermolysis bullosa simplex without extracutaneous involvement

http://purl.obolibrary.org/obo/MONDO_0021034
hereditary alopecia

http://purl.obolibrary.org/obo/MONDO_0033947
hereditary angioedema with normal C1Inh

http://purl.obolibrary.org/obo/MONDO_0957001
hereditary mixed dermis disorder

http://purl.obolibrary.org/obo/MONDO_0017263
inherited ichthyosis syndromic form

http://purl.obolibrary.org/obo/MONDO_0017262
inherited non-syndromic ichthyosis

http://purl.obolibrary.org/obo/MONDO_0015950
inherited skin tumor

http://purl.obolibrary.org/obo/MONDO_0017667
isolated diffuse palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0017673
isolated focal palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0019281
isolated genetic hair shaft abnormality

http://purl.obolibrary.org/obo/MONDO_0016518
isolated punctate palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0017676
marginal papular palmoplantar keratoderma

http://purl.obolibrary.org/obo/MONDO_0020181
mesenchymatous palpebral tumor

http://purl.obolibrary.org/obo/MONDO_0020178
palpebral lentiginosis

http://purl.obolibrary.org/obo/MONDO_0020180
palpebral piliary tumor

http://purl.obolibrary.org/obo/MONDO_0020176
palpebral sebaceous gland tumor

http://purl.obolibrary.org/obo/MONDO_0020177
pigmented palpebral tumor

http://purl.obolibrary.org/obo/MONDO_0020174
precancerous lesion of palpebral epidermis

http://purl.obolibrary.org/obo/MONDO_0019599
primary lipodystrophy

http://purl.obolibrary.org/obo/MONDO_0019286
sebaceous gland anomaly

http://purl.obolibrary.org/obo/MONDO_0018745
superficial pemphigus

http://purl.obolibrary.org/obo/MONDO_0019176
trichorhinophalangeal syndrome type I or III

spreadsheet

the entire spreadsheet is ready for review now

@nicolevasilevsky I reviewed this branch and left just a few questions for you :)

Thanks @katiermullen!
This should be ready for mass obsoletion now.

@katiermullen I updated some of the superclass assertions based on your comments, thank you!

Expert review feedback: https://docs.google.com/spreadsheets/d/1dKkp-rH-pmcIfm-nYz34tAy1vlAtZsnf/edit#gid=1660849274
TO DO:

[ ] add new parents ("ROBOT Reviewer-Curator Agree - Stay" Tab)
[ ] add new comments ("ROBOT Reviewer-Curator Agree - Leave" Tab) !!!!1 term comment will need to be added manually
[ ] add new parents ("ROBOT Reviewer-Stay Curator-Leave" Tab)

Note: Once the to-do list is done, 22 terms for which reviewers disagreed will remain to be assessed

There are some comments from the community that should be reviewed, but this is future work. This issue can be closed for now.


Add Scorer option to Query

Add support for using custom scoring functions in a Redisearch query.
Closes #35
TFIDF is the default scoring function but this PR allows users to attach custom scoring functions to a Query object.

TFIDF.DOCNORM
BM25
DISMAX
DOCSCORE
HAMMING

res = client.search(Query('foo').scorer('TFIDF.DOCNORM'))

https://oss.redislabs.com/redisearch/Scoring/

@emmanuelkeller please let me know if there's anything you'd like me to add to this PR. thanks!

Thanks @ashtul I've updated the PR with tests for all scorers with scores. Let me know if you want me to add anything else


Release memory which was allocated by native lib

My node module wraps a (C++) Windows DLL. The DLL has to allocate a buffer, fill it with content, and return to Node. What is the best way to implement that, so the buffer will be released when not used ?
Unfortunately I could not find any clear answer yet.
Thanks !

Just some ideas: Why not create the buffer node side? Than you can free it up there.
Alternatively: Create a function in the DLL, that can be called from node, and that function releases the buffer.

Thanks ! I have access to the DLL source, and have implemented a release function.
Will update this thread if any issue. I'm creating another thread to get help with handling multiple output buffers.


Xamarin iOS: not able to scan long linear 1d barcodes

Xamarin iOS: not able to scan long linear 1d barcodes . It either takes infinite time to scan or scan wrong value.
any solution?

Got into same problem. Have you found any solution.

Yes, i tried reducing the camera resolution along with landscape mode and
it worked
On Tue, Nov 20, 2018, 5:25 PM Narasegowda<EMAIL_ADDRESS>wrote:

Got into same problem. Have you found any solution.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Redth/ZXing.Net.Mobile/issues/754#issuecomment-440247669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMwdKGVS_mk6AQJFj1VKWV4mTh8NwCfOks5uw-3GgaJpZM4VQ9L2
.

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


[CORE] Fix zookeeper vulnerabilities.

What changes were proposed in this pull request?
The current code uses org.apache.zookeeper:zookeeper:jar:3.4.6 and it will cause a security vulnerabilities. We received some alerts like https://github.com/Qihoo360/XSQL/network/alert/pom.xml/org.apache.zookeeper:zookeeper/open
This Alert remind to upgrate the version of zookeeper to 3.4.14 or later.

LGTM


Balnk page because of page-break trough CSS

I don't know if the bug is in uiwebview or in this library. But I've put div's in my html-code with a class pagebreak. It does a page break, but with an extra blank page.
How do I get rid of the blank page.

    @media all {
        .pagebreak  { display: none; }
    }

    @media print {
        .pagebreak  { display: block; page-break-before: always; }
    }

May be relevant so posting it here, if this approach causes problems, how would one go about adding a page break correctly that works with NDHTMLtoPDF's approach?

Some time PDF generated got partially blank.
Please help.
Its urgent
Thanks in Advance!!!


orderBy should use secondary groupBy

The orderBy param of the details API should use secondary groupBy value when available

Codecov Report

Merging #437 (7e1f0af) into main (9cfecbf) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7e1f0af differs from pull request most recent head 02c49eb. Consider uploading reports for the commit 02c49eb to get more accurate results

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #437   +/-   ##
=====================================
  Coverage   4.51%   4.51%
=====================================
  Files         49      49
  Lines       2017    2017
  Branches     449     449
=====================================
  Hits          91      91
  Misses      1926    1926

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfecbf...02c49eb. Read the comment docs.


Editors for Nephio-specific resources (1st batch).

This PR adds three new editor UIs for resource types which are specific to Nephio:

infra.nephio.org/v1alpha1/WorkloadCluster
infra.nephio.org/v1alpha1/Token
req.nephio.org/v1alpha1/Capacity

At this moment, the Web UI project does not support GUI editor functionality for any of Nephio-specific resource types. This PR is the beginning of a bigger effort which aims to close this gap and provide graphical editors for all relevant Nephio resources.
Additional tweaks and fixes include:

Added LOCAL_PROXY configuration mode, which makes it possible for WebUI developers to connect application to a Kubernetes proxy. SSH port forwarding can be used to easily connect to a remote cluster.
Created useSetStateAndCall React hook which aims to limit undesirable usage of useEffect hook for reacting to state changes.

This time I'm publishing the PR from my private account (with linked Samsung email), so it seems I have to go through CLA authorization again. Hopefully it will be cleared soon.

/easycla

Note to the reviewers and approvers: please ignore result of GitHub action: 'Generate Dependabot Configuration / run_python_script (pull_request)' it has no impact and status was added by error.

Hi @liamfallon @efiacor
I created this PR in an unfortunate moment, when it went unnoticed, buried beneath the avalanche of auto-generated Dependabot PRs 🙂
Now that we have this matter sorted out, I would be grateful if you could take a look at it.

Hi @liamfallon @efiacor
I created this PR in an unfortunate moment, when it went unnoticed, buried beneath the avalanche of auto-generated Dependabot PRs 🙂
Now that we have this matter sorted out, I would be grateful if you could take a look at it.

Hi @kamilmadejek , this looks interesting.
Would you have an easy way to deploy these changes so we can take a look?

Hi @efiacor, sure, I'll try to prepare this for Monday.

Hi @efiacor, I managed to prepare a Web UI deployment with these changes. I will share access details using a private channel.
The work done in this PR is quite rudimentary - it adds three relatively simple editors for Nephio-specific resources. These new editors are implemented in a similar way to already existing editors, thus they share their drawbacks (code duplication, some pre-existing bugs and quirks etc.). This PR serves mostly as my introduction into the topic.
I am currently prototyping a new approach for implementing editors, which aims to make their development more streamlined and code more maintainable.

/approve


feat: Comparison based alerts

closes #4544
Uses #4793 to add comparison based alerts on the MetricsViewAggregation API

[x] Add support for comparison in create/edit alert forms.
[x] Extract comparison during edit alert.
[x] Add comparison to readonly pills
[x] Update formatting for MetricsAggregation for comparison.
[x] Fix MetricsAggregation in alerts when comparison is enabled.
[x] Refactor based on new mocks.

UXQA (some of which is out-of-scope of this PR, but want to document) –

The "Comparing with" pill looks like it's missing something. In this case, shouldn't it say it's "Comparing with the Previous Period"?

On the first page, using the keyboard's "escape" key triggers the "Close without saving" dialog (while the "X" and "Cancel" buttons correctly do not trigger it)

The table header's text (here "Number of contributors") spills across the header's bottom border

I'm seeing "% change from undefined" in the measure extension dropdown

When a criteria does not have a measure selected (see Criteria 2), the Next button is currently unresponsive. It should either be disabled or clicking on it should show an error.

The email recipients should not be initialized with an extra blank email address.

This criteria pill should say "[Measure label] % change > -10%", not "[Measure name] % change from > -10%"

Code – So far I've just skimmed it, but I'm seeing a few leftover console logs FYI.

Thanks for the review. Have fixed 1,4 and 7. The duration and label mapping was incorrect (delta was incorrectly 0).
Rest are out of scope.
2. I have disabled escape for now. There is a challenge here where escape is handled by a wrapper GuardedDialog, but isTouched is deeper inside.
3. Couldnt reproduce this. It is increasing the height of the header for me. Either way this is using the table components. I can see the issue in dimension table now and then as well.
5. Forms lib is not populating the error properly. It just has Required for criteria and no indication of which index the error is for. I have set the measure to a valid value for now.
6. Hmm this has been there since we added it for the 1st time. Are we sure we dont want an empty entry there? (It gets removed before submitting)

UX/Product Check on @ericpgreen2's first pass

Comparing with pill is now displaying previous time period

Keyboard "Escape" key doesn't trigger "close without saving" dialog anymore

Looks like the column spillover is still there

% change from undefined is now fixed

Adding a new criteria now preloads with a measure (instead of displaying the measure label). Works but not sure if this is intended behavior? A question I have is: would there ever be more than one measure available to select from the dropdown?

6.Email recipients still initialized with extra blank email input field

Criteria readout looks good now

New UXQA

For long measure names, looks like there's spillover in the criteria dropdown box

Selecting first measure from Alert data dropdown will autopopulate measure selection in Criteria step. Selecting other measures will not autopopulate measure selection

[URGENT] You have to click next button twice on Criteria step to get to Delivery step

Shouldn't say "% change from from previous day". Remove one of the "from"

Fixed the new items. Found the issue for incorrect column height. Fixed it when the column is not in the 1st place. For the case where it is in 1st place, the code is used in dimension table as well, so will do a follow up after confirming why we have that in dimension table.