bootc install to-disk --disable-selinux does not disable selinux when the host has selinux disabled

The purpose of the --disable-selinux command is to enable the creation of an image with selinux enabled from a host with selinux disabled. On my Fedora 39 machine, when I set selinux to disabled or permissive, this selinux_enabled check still returns true. This results in an image with broken selinux that won't fully boot. Would checking the output of getenforce be more reliable?

Yeah, that check is wrong - it only works on Ubuntu where it's load bearing because they don't compile in support at all.
OK so...this problem heavily overlaps with that of https://github.com/containers/bootc/pull/302
Basically what we want to change here is replacing parsing /proc/filesystems with checking for /proc/1/root/sys/fs/selinux.
That change alone is probably sufficient.

@bcrochet are you already working on this? If not I'd like to take a stab at it.

@bcrochet are you already working on this? If not I'd like to take a stab at it.

Sort of? I actually started on a different section of the code that will ensure that the selinuxfs is mounted inside the container. If you want to focus on the selinux_enabled check and getting that working properly, I'd appreciate that.
Feel free to assign yourself to this issue as it's not directly tied to what I'm working on.


Some of panels in node dashboard doesn't work

What happened?
After fresh installation of kube-prometheus with default grafana dashboards (and configuration), some of panels with new $__rate_interval feature doesn't work.
After entering Nodes dashboard it looks like this:

And few errors appearing in dev console:

after manual live-change of min step from $__rate_interval to $__interval, graph is showing up properly (but with errors from dev console in query window)
PanelQueryRunner Error Error: Invalid interval string, has to be either unit-less or end with one of the following units: "y, M, w, d, h, m, s, ms"

Did you expect to see some different?
Every panel in dashboard should work properly.
How to reproduce it (as minimally and precisely as possible):
as above
Environment

Prometheus Operator version:

latest from HEAD in kube-prometheus

Kubernetes version information:

1.20.5

Kubernetes cluster kind:

kubeadm

I can see the same problems, I think it was introduced by this PR: https://github.com/prometheus/node_exporter/pull/1995


[PE-D][Tester D] Limited character count for names

Character count for name is too low. CLInic only accepts up to 55 characters and is unable to account for very long names that are quite common in SG
e.g. Indian names that contain family name and parent's name together with their own names (Chandrasekaran Muthusamy Balakrishnan SO Chandrasekaran Sanjay)
e.g. Picasso's full name (Pablo Diego Jose Francisco de Paula Juan Nepomuceno Maria de los Remedios Cipriano de la Santisima Trinidad Ruiz y Picasso)

Labels: severity.Medium type.FeatureFlaw
original: delishad21/ped#7

Won't Fix as intended behaviour.
Singaporean names have a limit of 54 characters due to limited space on the physical IC. Clinic assistants use ICs to register patients.
Addressed in plans for future enhancements by @ThatGirlJam to accommodate foreign patients.


this is snappier

much better huh?

Maybe change to Me?

How about "3000" ?

FYI this was part of git/github class.

This makes a bit more sense now :)


Read light level returns 0

Originally raised by @crouse12 in https://github.com/bbcmicrobit/PythonEditor/issues/338
from microbit import *
while True:
    lightLevel = display.read_light_level()
    display.scroll(lightLevel)
    sleep(1000)

Returns 0 consistently on the display.
microbit v2.
Unique ID:<PHONE_NUMBER>434e45004a400e0000005f000000009796990b
HIC ID: 9796990b
Auto Reset: 1
Automation allowed: 0
Overflow detection: 0
Incompatible image detection: 1
Page erasing: 0
Daplink Mode: Interface
Interface Version: 0254
Bootloader Version: 0254
Git SHA: ec3fec91e815b1fe27cefb8bc4ffa85ca3317502
Local Mods: 0
USB Interfaces: MSD, CDC, HID, WebUSB
Bootloader CRC: 0x23cc2063
Interface CRC: 0xd0f0bacf
Remount count: 0
URL: https://microbit.org/device/?id=9904&v=0254
python editor
https://python.microbit.org/v/beta
OS: window 10
Chrome version: 86.0.4240.111

I have tried to reproduce and can't using either V1 or v2 board in python beta editor

@crouse12. Do you see the same MicroPython version when you click on Help in the editor?

As this should be a fairly standard CODAL pass-through and I happened to have a CODAL project open in the background and gave this a quick test and it doesn't work in that layer: https://github.com/lancaster-university/codal-microbit-v2/issues/14

2.1.0-beta.5 and 2.1.0-beta.6 have the same problem.

@crouse12. Do you see the same MicroPython version when you click on Help in the editor?

This has been fixed in CODAL, so it should be available in the next CI builds or the next Python Editor release.
We'll close here once we can confirm the original example script works.

@microbit-mark @martinwork this can be tested already in https://python.microbit.org/v/beta (beta.7)

Testing code below in:
Python Editor Version: 2.1.0-beta.7 MicroPython Version: 1.0.1/2.0-44a75bb
lancaster-university/codal-microbit-v2, branch master
lancaster-university/microbit#v2.2.0-rc6
MakeCode beta
With CPP:
V1 shows 255 first, followed by values that change according to light level.
V2 shows stable readings from reset, power up and download
With Python:
V1 shows a high first reading, then good readings
V2 shows a zero reading after pressing reset, but not after power up or download
With MakeCode beta:
V1 shows 255, then good readings
V2 shows good readings
from microbit import *
while True:
    lightLevel = display.read_light_level()
    display.scroll(lightLevel)
    sleep(1000)

// This tests the LEDs light level

#include "MicroBit.h"

MicroBit uBit;

void forever()
{
  while (true)
  {
    ManagedString s( uBit.display.readLightLevel());
    uBit.display.scroll( s);
    uBit.sleep( 0);
  }
}

int main()
{
    // Initialise the micro:bit runtime.
    uBit.init();

    create_fiber( forever);

    // If main exits, there may still be other fibers running or registered event handlers etc.
    // Simply release this fiber, which will mean we enter the scheduler. Worse case, we then
    // sit in the idle task forever, in a power efficient sleep.
    release_fiber();
}

basic.forever(function () {
    basic.showNumber(input.lightLevel())
})

With Python:
V2 shows a zero reading after pressing reset, but not after power up or download

Testing on the lastest master at 6565f16878b8b472c3b020f3bf0d8b3bf1a0a124, after pressing the reset button display.read_light_level() returns a non-zero value for me (as long as there is a bright enough light on the display).

With CPP:
V1 shows 255 first, followed by values that change according to light level.
V2 shows stable readings from reset, power up and download

This is now expected as there is an open issue in the DAL repo and this is the current CODAL implementation.

With Python:
V1 shows a high first reading, then good readings
V2 shows a zero reading after pressing reset, but not after power up or download

With this programme in V2:
from microbit import *
while True:
    lightLevel = display.read_light_level()
    print(lightLevel)
    display.scroll(lightLevel)
    sleep(1000)

I'm getting non-zero values after reset (with the phone flash light).
Could you try again Martin? If it works with the MicroPython version in https://python.microbit.org/v/2.1 we can close this issue.

V2 is OK. V1 starts with a high reading.

Thanks Martin!
The DAL behaviour is captured in https://github.com/lancaster-university/microbit-dal/issues/426, and MicroPython for V2 works as expected with CODAL, so we can close this issue.

Return 0 when I use microbit v2

Make sure you have a good light source on top of it, it will likely read 0 in normal ambient light.


[Question]: api get dataset id

Describe your problem
when i use api to get dataset id, I return it to another api so that i can use that dataset .But system cannot find this datasetid.

Could you paste your code and elaberate on the scenario.


Release 3.0.1

Any time scale for a 3.0.1 release, or any open defects or pull requests that need resolving before a 3.0.1 release is done?

release 3.1.0 is published


Adobe Scan Report -  Brightcove issues

Hi Team,
We have integrated Brightcove with AEM as a cloud service. We are seeing the issue in Adobe scan report which has been attached to this request. Could you please check on this issue as soon as possible.
Brightcove adobe scan report.xlsx

Please take a look at this release:
https://github.com/brightcove/Adobe-AEM-Brightcove-Connector/releases/tag/6.1.3-cloud

Hi, we have integrated the new package in our code, and it has solved only one issue showing in the above excel sheet for major severity. The remaining minor issue are still there. May I know when we can expect them to be fixed.

The other two issues in that list will need to be prioritized by the Brightcove team, but I would expect them in a release later this year. I suggest you raise an issue through their support portal to ensure it gets the proper attention.


Fixed broken links in Markdown Contributing and Readme files

Why make this change?

Fixes broken links in Markdown Contributing and Readme files

What is this change?

Fix broken links

@microsoft-github-policy-service agree

Thank you for contributing! Links to Learn.Microsoft.com should exclude locale (e.g. `en-us), since the browser will auto-resolve that value.

Thanks, excuse my oversight. I have changed the URL's without the locale.

/azp run


Section 3 - broken bullet list

Bullet list is broken in the section number 3:
It should look something like:
The audio driver sets the parameters to IoSetDeviceInterfacePropertyData as follows:

The SymbolicLinkName is the string returned from IoRegisterDeviceInterface.
The remaining parameters depend on the specific property being set.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81a30427-fc71-0347-7754-073fe22ba2d7
Version Independent ID: 19cd0d42-aeb7-7f8f-abd5-79c319f5f3e5
Content: Setting Properties and Registry Values
Content Source: windows-driver-docs-pr/audio/setting-properties-and-registry-values.md
Product: windows-hardware
GitHub Login: @DOMARS
Microsoft Alias: windowsdriverdev

Done. Thanks, @sahikon
Should be live shortly.
Feel free to edit the content and submit a pull request for fixes. We get a bonus for each PR submitted. Just kidding, but you get the bonus of contributing directly to the docs!

@EliotSeattle  - good to know, will try :-)


As a Wellcome content team member I need to be able to set the information for each stop type in the Video tour and add the relevant media content

Acceptance criteria
Clear field labelling
All fields are able to be completed by a content team member
Exhibition title - automatically?
Exhibition introduction content - automatically?
A content team member is able to set the title for each stop
Ensure that the audio is correct
The stop number
QR code URL
Ensure that a content team member is able to successfully upload and add content without having to use work arounds

Dev + @dannybirchall

Closing as this is in the Archive column on the Digital access board.


Commands for MRU-cycling tabs (Most Recently Used)

Check for existing issues

[X] Completed

Describe the feature
Since https://github.com/zed-industries/community/issues/451 (which can be closed) cycling tabs L+R has been implemented with pane::ActivateNextItem and pane::ActivatePrevItem.
But I'd like to request MRU-cycling through tabs, so I can quickly switch between non-adjacent tabs with cmd-tab and cmd-shift-tab. I often have a lot of files open, having to use the mouse to switch or performing 10 consecutive L or R operations is not efficient.
Basically how VSCode does it. Here's some pre-work describing the behavior hoping it can jump-start implementation:
Generic wishlist

two new commands, say

[ ] pane::ActivateMruPrevItem and
[ ] pane::ActivateMruNextItem

on command activation

show a popup list with all opened files sorted by MostRecentlyUsed (like Command Palette, without the text entry)
item m-1 (for Prev) or m+1 (for Next) is selected
popup list is shown as long as the first modifier-key is held

on subsequent command Prev or Next activations with first modifier-key still held

select the next or prev file in the popup list, m++ or m--

on release of first modifier-key

pane::ActivateItem m
close popup list

These commands can then be bound to for instance:
"bindings": {
    "cmd-tab": "pane::ActivateMruPrevItem",
    "cmd-shift-tab": "pane::ActivateMruNextItem"
}

Some UI thoughts

Have the file list control always show up at the same location, so your eyes can always directly jump to the same point on the screen. Command Palette already does this nicely by essentially "dropping down" below the tab bar.

If applicable, add mockups / screenshots to help present your vision of the feature

Big plus one to this: everything else about zed is great, but I just can't shake my muscle memory from other editors of ctrl+tab'ing in MRU order.


Tooltip pattern

Accessible tooltip pattern
Criteria

The tooltip typically becomes visible in response to a mouse hover, or after the owning element receives keyboard focus
authors should display the tooltip after a short delay (wai-aria suggests 1-5 seconds)
elements with the role tooltip are referenced through the use of aria-describedby before or at the time the tooltip is displayed
A mechanism is available to dismiss the additional content without moving pointer hover or keyboard focus (e.g. escape key)
If pointer hover can trigger the additional content, then the pointer can be moved over the additional content without the additional content disappearing;
The additional content remains visible until the hover or focus trigger is removed, the user dismisses it, or its information is no longer valid.

Refs
https://www.w3.org/TR/wai-aria-1.1/#tooltip
https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html
https://primer.style/view-components/components/alpha/tooltip
https://github.com/GoogleChrome/web.dev/issues/8959

Hello!
I've spent a bit of time today looking at this pattern and have an example of it running in a branch which matches the guidelines.  I've found a few issues with it though, and wondered if it's worth continuing.
I've been looking at this suggested implementation and running a version of it as one of our patterns:
https://www.w3.org/WAI/WCAG21/Techniques/client-side-script/SCR39
My WIP branch is here:
https://github.com/stormid/ui-patterns/tree/feature/52-tooltip
First and biggest issue is the lack of touch support for devices.  The critera from the w3c doesn't expect this, but if we don't have it - does that make this pattern redundant?  Tooltips have dropped out of favour almost completely since touch devices came along, and there's a big push for everyone to rethink their UX if they find they have to fall back on them.
If there are instances that we don't need to consider touch devices, the pattern works - but the requirement to have a delay causes issues.  If the tooltip panel needs to sit away from its trigger so as not to obscure it, then there is inevitebly at least a pixel gap between the element and its trigger.  The delay of the element appearing causes a flicker at 100ms.  The W3C's own example doesn't implement a delay at all, so it's not obvious that's the case.
I did have to put in an additional script to pass keydown events through to the embedded iframe, but that's more just a requirement from the way our docs are done.
Any thoughts on the branch and the above would be appreciated - very much not finished, tested, documented.. I just wanted to get other opinions before taking it to completion!

p.s.  I did also have a look around to see if there was a new and shiney way of doing tooltips for touch, but they all still seem to involve taking the touchstart/end events and doing something like sniffing out a double tap or a long press.  Both these feel like they would get in the way of OS functionality (certainly on iOS a long tap on a link/button has a context menu).

@sarah-storm as you say, the implementation you have is not finished - so critique seems out of place (but the pre-open delay feels really wrong, disconnecting the user action from the effect). More pertinent is your questioning of the use of this pattern at all.
It feels like the pattern doesn't have clear consensus over use (W3C and Git Hub threads), and the issues you raise regarding use with touch devices make me lean towards thinking it is a pattern we should be recommending against.

@sarah-storm @Nick-StormID  I raised this when the product team on a specific project were pushing for tooltips and I wanted to find the least worse implementation. Eventually I successfully pushed back and we didn't do tooltips.
I agree that we can park this for now but it serves as very useful research and a reference point when they arise again in designs.


Double slashes after hostname in URL causes all sort of weird behavior

If someone tries to hit /v1/chain API proxied calls via a POST there is a double trailing slash between the hostname and the path element of the URL, the HTTP response will be a 301 Moved Permanently```. However, returning a 301in case of HTT POST is problematic for client that respect the HTTP spec as a redirect 301 using aPOSTshould be retried using aGET` instead.
The HTTP code 307 was added exactly for this, so that client retry the request with the exact original request instead.
One would argue that it's easy to just remove the trailing slash, but sometimes it's kind of just hard to see it:
const rpc = new JsonRpc("https://kylin.eos.dfuse.io/")

In this case, when the developer will do rpc.get_block(...), the endpoint will be of the form https://kylin.eos.dfuse.io//v1/chain/get_block which is not spotted easily. For the record, it's probably the third time we got bitten by this problem.
This seems to be coming from github.com/gorilla/mux library and the StrictSlash handling that returns a 301 by default: https://godoc.org/github.com/gorilla/mux#Router.StrictSlash
We should instead send a 307 in those cases so there is no problem with POST request.

Issue being discussed on https://github.com/gorilla/mux/issues/561
Didn't know 308 was in proposal to be added to HTTP spec. Probably lots of client out there that does not handle it yet.
The mux issue talks about middleware, we could take this approach while it's available somehow in the upstream library.


Improve completion on :: and ::: (use R engine rather than docs as source of function names)

The list of objects I get on typing ::: is inconsistent. Without a package qualification, I get a popup list of all my global objects (which is expected). If I supply one of the packages loaded at startup like stats::: or graphics:::, I get a list of objects exported from that package namespace (which is also expected). If I supply a package loaded during the session, like dplyr::: (after I load dplyr), I again get the list of global objects (not expected). Something similar happens with (2) above; typing mutate( doesn’t pop up a list of arguments to the dplyr-exported function, whereas glm( does.

Now intellisense does use remote it should work properly


Cleaning : reformat all *.vue files

Description:
Changes below reformat all *.vue files.
This is the result  of

IntelliJ Reformat Code command
a few adjustments (some span clauses were missing and causing test break)

No sure this reformatting changes are required. Might be a bug in IntelliJ 2023.1.x.
Closing…


[Feature Request]generate sprite image with md5 file name  to prevent browser cache

We recommend using other gulp plugins to generate md5 filenames. This issue is a duplicate of https://github.com/twolfson/gulp.spritesmith/issues/26
I don't have any up to date plugin names but believe there should be something out there for this


Create presentation for DataFusion SIGMOD 2024 paper

Is your feature request related to a problem or challenge?
@JayjeetAtGithub  @Dandandan @yjshen @ozankabak @sunchao and @viirya wrote and submitted a paper to the SIGMOD 2024 conference
We need to  present our paper at 5PM June 11, 2024 in Santiago Chile at the conference: https://2024.sigmod.org/program_sigmod.shtml#industry (less than 1 month away! terrifying)

Session 1: Query Engines
Tuesday June 11 5:00 pm – 6:30 pm
Location: Europa
Session Chair: TBD

Apache Arrow DataFusion: A Fast, Embeddable, Modular Analytic Query Engine
Andrew Lamb (InfluxData); Yijie Shen (Space and Time); Daniël Heres (Coralogix); Jayjeet Chakraborty (UC Santa Cruz); Mehmet Ozan Kabak (Synnada); Liang-Chi Hsieh (Apple); Chao Sun (Apple)

Describe the solution you'd like
I believe we have a 30 minute presentation -- including questions, so that means we probably need to plan for a 20-25 minute presentation
Describe alternatives you've considered
No response
Additional context
See other tickets here

https://github.com/apache/arrow-datafusion/issues/6782
https://github.com/apache/datafusion/issues/8373

Here are the slides. I plan to keep refining them until presentation time, but I think the meat of the story is now in place. Comments / suggestions welcome.
https://docs.google.com/presentation/d/1gqcxSNLGVwaqN0_yJtCbNm19-w5pqPuktII5_EDA6_k/edit#slide=id.p

I got good feedback and I am feeling pretty good about the slides. I plan to practice a recording of the talk later this week and post the recording to youtube

Presentation is done, and I am presenting today. Closing this ticket
BTW here is a practice version I gave of the slides: https://www.youtube.com/watch?v=-DpKcPfnNms (though the actual conference talk is shorter)


[Feature Request]: Add Microsoft.DataProtection/backupVaults as a module

Description
We need to deploy backupvaults (for disk snapshot backups). You can assign it to me and I can make a PR for this.

Well appreciated @akata72, please go ahead :)


Is it possible to put "About" page as default?

This repo and the work is amazing! I forked it and imported some of my wordpress posts and it works like a charm. I only have one question as it in the title. Is it possible to change the default index.html to the "About" page instead of the "Blog" page?

This issue has already been resolved. I put index.html into a folder called "blog" and changed the permalink. The only thing is not working is the pagination from a pull request..


Use unique class name in tutorial nav tabs

What kind of changes does this PR include?

Changes to the docs site code

Description
We use a .content class on our main page content and instruct DocSearch to use this to find content. We don’t want to include the tutorial navigation tabs in search results and also don’t want styles from the global .content bleeding into them, so this renames .content to .panels.

LGTM! Thanks for being so diligent and attentive to this, @delucis!


support for querying redis/ES for step in case we haven't seen the metric yet

@woodsaj i'm happy with the first commit, been testing it in devstack, the 2nd commit has only been tested through unit tests so far, haven't played with it or tested performance yet. but this shows the direction I think we should take for https://github.com/raintank/graphite-api/issues/8 : metric-tank can fix up the data and graphite-raintank doesn't have to do any of that stuff anymore. thoughts?

@Dieterbe  Do you think we should just move nsq_metrics_to_elastic into metric-tank?

I've also been thinking about this.
The main reason that nsq_metrics_to_{kairos,elasticsearch} were designed as separate consumers was so that each would have their own channel and queue so that ES or kairosdb downtimes could be handled separately, i.e. kairosdb downtime would not prevent ES updates from propagating, and ES downtime would not prevent data being added into kairosdb.
If both were handled from the same consumer it doesn't seem sensible to send an ack if only one of the submit to ES or tsdb worked, so one would hold the other up.
Bringing both responsabilities into MT would make it simpler to run, especially for people who just want to run MT (and cassandra+ES) and expect things to work by sending their metrics into MT, perhaps via a graphite tcp input instead of having to worry about a separate metadata indexer service.
one thing that is different now though, is that "tsdb ingest" always succeeds because it's in process. it's only the external ES that is a liability. long term (once we get rid of the python graphite stack and do everything in go) we may want to have the primary index in memory if we can feasibly implement persistence and replication.
for now we could treat ES outages as rare exceptions and don't store the values in the chunkserver when ES is down so that we don't have the problems around acking but half-consumed messages. but that puts more pressure on upgrade procedures etc.

What if we just treat ES as an index'ing service and not the primary store for index data, and instead persist metric data to cassandra.  ES being down and not receiving data is not a problem as when ES comes back up the index will be populated as new metrics are ingested.  While ES is down, we cant query from graphite anyway.

TODO: make sure all targets requested in same request have same step.

just added some more commits with misc fixes.

just pushed 2 WIP commits. i'm working on a solver that can find the optimal step for all targets by scoring various solutions and punishing for cassandra lookups and runtime consolidation. it needs some mork work though.

so the multi-target step solver should work now, at least based on all the unit tests.  and i also went ahead and did the metrics_to_elasticsearch deprecation, see also https://github.com/raintank/raintank-docker/pull/51
unfortunately i've been having issues with devstack today, metric-tank is spewing errors like
2015/12/21 09:44:45 [metricdef.go:235 GetMetricDefinition()] [E] elasticsearch query failed. 2015-12-21 09:44:45.319853618 +0000 UTC: Error [ElasticsearchIllegalArgumentException[No feature for name [metric_index]]] Status [400] [400]

so i haven't been able to do my usual playing with zoom levels and verifying data returned looks proper.  no idea where this is coming from so suddenly.
I don't have enery anymore today to figure this out, hopefully @woodsaj knows what's up.

@woodsaj can you please review this, hopefully it's good to merge (or good enough with any needed fixes forthcoming).  i still haven't been able to find out what the ES errors are about (see above comment, but now on line 255 in metricdef.go) but i'm getting them consistently and querying http://localhost:9200/metric/_search?q=*:* works fine and returns plenty of metrics with  "_type": "metric_index", set. also this started happening after i moved the nsq_metrics_to_elasticsearch logic into NMT i think.

There is still a few changes needed here.  Mostly around the consolidation functions. They currently dont handle NaN values well, which are now being added by the fix() function. eg, Min consolidation of NaN points results in the value being set to math.MaxFloat64

Still seeing issues with some of the consolidation functions.
When querying for 7days of litmus.*.*.ping.avg with maxDataPoints set to 20, i get a result of 132 for one of the points.  This is not possible as the values are either 0 or 1.


Display error message when collection field references model that doesn't exist

Would be great if we could validate all collection definitions at startup using the following rules:

Fields that have refs should only reference existing models
singular and fields are required properties
singular must be a String
`fields
label and schemaType are required field properties

I have added validation at startup to check the above required properties/fields.
Still need to add validation for collection field model references


code bug 'UnboundLocalError: local variable '_tmp' referenced before assignment'

File "MotionDirector/utils/lora.py", line 532, in inject_trainable_lora_extended
_tmp.to(_child_module.weight.device).to(_child_module.weight.dtype)
UnboundLocalError: local variable '_tmp' referenced before assignment

Any suggestion？

Oh, it's due to diffusers version!


chore: bump clio from 0.3.1 to 0.3.2

This bumps clio to version 0.3.2
It needs a rust version bump as clio now use PathBuf::as_mut_os_string which is only stablized in 1.70.0.
Clio 0.3.2 added is_tty() which means that atty goes to being a transative dependency.

Hi, thank you for the PR!
Unfortunately, a bug in Rust prevents us from using 1.70 for CLI at this time.
See #2721

Is it ok to park this until the end of august when rust 1.72 will be out? I only pushed it as I know dependabot will create a similar PR and I wanted to fix up the is_tty.

Is it ok to park this until the end of august when rust 1.72 will be out? I only pushed it as I know dependabot will create a similar PR and I wanted to fix up the is_tty.

Of course we will leave this open. Thanks for the update!
(Just change to draft status to avoid accidental merging.)

Thank you v much @aj-bagwell !
For transparency, we will probably leave this open for a while, since we're trying to follow debian in our minimum version, which is currently at 1.65.

For transparency, we will probably leave this open for a while, since we're trying to follow debian in our minimum version, which is currently at 1.65.

Though on reflection, we could keep our MSRV for prql-compiler only; I don't think there's a need to keep it for prqlc.
For reference, it's tested at: https://github.com/prql/prql/blob/b53439fff265339bde136af89c44173e0545c778/.github/workflows/test-all.yaml#L144-L145
and specified at https://github.com/prql/prql/blob/87fffea52736284eb1637fa0db02f65c1da11d11/prql-compiler/prqlc/Cargo.toml#L10-L11

I have opened an issue to remove the dependency on the newer rust version.

Thank you @aljazerzen for updating clio to work with rust 1.63.0! I have updated this pull request to use clio 0.3.3 and removed the rust version bump.


Problem Loading Widget (Version 2.0.7, 84)

Widget displays as box with text "Problem Loading Widget"
I've tried disabling all extras like weather, calendar, etc, but the widget never displays.
I've tried removing and re-adding the widget, restarting the widget in the settings panel, and restarting my phone.
If there is a way to display logs or any other debug messaging, please let me know and I'll provide those logs.

Device: Google Pixel 2XL,
OS Version: Android 10
App Version (that you can find inside the advanced settings) [e.g. v2.0.5 (71)]

Running into the same issue, v2.0.7 (84) running on Pixel 2 and Android 10.
Tried enabling the permissions, reinstalling the widget, and putting in OpenWeather API key. Putting in the API key helped temporarily, but it's back to "Problem loading widget" now.

I'm getting the same thing. Latest version on Android 10e. Reinstalled, and tried a new API key but nothing has worked.

Is the problem still present in the latest release?

Is the problem still present in the latest release?

Thankfully it is resolved and now works wonderfully. Thank you!


fix #2535: Test failure in Microsoft.AspNet.Mvc.Core.Tests

cc @dougbu, @ajaybhargavb

cc @rynowak, @dougbu, @pranavkm

Looks good to me. :shipit: once @dougbu  \ @rynowak  sign off.

:watch:

Have you confirmed this works just as well after messing with the timezone on your machine?  If yes, :shipit: from me.

@dougbu : Yes I changed timezone on my machine and ran the test. It worked.

checked in - da740cd6a8e75895e72be28e367196aa3af9a6d4


Parking: Obtain and Review Feedback

Review feedback from our customer / RMP regarding our implementation of parking

Redundant Issue


Twitter Cleanup (see https://github.com/letsblockit/letsblockit/issues/269)

I did not check those rules. Just copied them from https://www.reddit.com/r/uBlockOrigin/wiki/solutions#wiki_twitter.
Note: some descriptions are vague and need improvement.

I changed the YT file, because we already have a "remove redundant/old rules" for Youtube.

Hello @JohnyP36, thanks for your contribution!
Sorry for not reviewing this earlier: life got in the way this week, and I'll be out of town until Monday.

I did not check those rules

As I wrote in https://github.com/letsblockit/letsblockit/issues/269, my main worry is the  ongoing maintenance, not the initial work. My target is for us to be able to proactively update the template when needed (like you and @BPower0036 do well for youtube), not react to users signaling breakages. I prefer quality over quantity for the time being.
I expect the Twitter interface to move a lot in the upcoming months, that's why I left the issue open in search of a regular Twitter user to step in. Not testing the rules signals to me that you might not be the best person to take over the ongoing maintenance burden. How do you feel about that?

I expect the Twitter interface to move a lot in the upcoming months, that's why I left the issue open in search of a regular Twitter user to step in. Not testing the rules signals to me that you might not be the best person to take over the ongoing maintenance burden. How do you feel about that?

I made the file, in order to help the person who wants to maintain the rules.
I'm indeed not the right person for this. Thus I hope someone else can maintain those rules.
As long there is no person, keep this PR open.

Heya @JohnyP36, as this is new template there's no need to rebase it regularly. I'm converting to draft to convey the current state of this work: we're not ready to merge it until someone steps up as maintainer.

Closing alongside https://github.com/letsblockit/letsblockit/issues/269, I think there are better uses of our energy.


Install for Dummies

Following your guide I was able to get GitLab-Pages up, however everything except the index throws a 404.
What works
Login
Enable Project
What doesn't work
/webhooks dir throws a 404
/pages dir throws a 404
I am sure I am just doing something wrong.

So when you enable a project, it does yet automatically pull the latest code. There is an issue for that #17.
So it may be that you need to push to your deploy branch and that should build the project page.
Let me know if that works or does not.

That was where I started. I got the webhook working. This does not like to be proxied, it will not work.
I pushed a change, and saw the webhook be called.. however
That does not work. I even put a index.html manually in the publicdir folder.... still get 404?

Could you take a look in the project's .tmp/ and pages/ directories? The .tmp is where clones go, and pages is where the final Jekyll static-content website goes.
I'd recommend taking a quick read through https://github.com/Glavin001/GitLab-Pages/issues/15#issuecomment-113696156
Another user found that one of the checks to see if a project is enabled would sometimes fail. That if statement would cause problems for their setup and found removing it was their workaround. See https://github.com/Glavin001/GitLab-Pages/issues/15#issuecomment-113965589
I currently do not have much in the way of debugging tools for GitLab Pages. I would highly recommend simply adding debug statements throughout https://github.com/Glavin001/GitLab-Pages/blob/master/routes/webhooks.js#L14 until you find where it stops executing and fails and then let me know where.


:memo: chore: Update runtime readme

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #615

PR #616   👈

This comment was auto-generated by Graphite.


Added description field to GHTeam class.

Fixes issue #460.

@bitwiseman Unit tests added. Could you please review?
 I'm not sure if you have the right permissions.


Feature request: heatmap chart

I found someone using a heatmap to chart solar data over time. Thought something like this would be a great addition to the dashboard.

https://enlighten.enphaseenergy.com/pv/public_systems/3J9a932010/overview

Thanks @matthew-pakulski !  We have the "Solar Year" graph but the heat map is very cool.  Do you know if this is a grafana panel?  If you can find the panel json for this, please post it!  Thanks!

This may not be possible using InfluxDB and InfluxQL. It might require using Flux as the query language since InfluxQL can't do anything like "datepart" to get the month or hour from the row data. Doing the heatmap would require having an 'hour' column on each row and a numeric 'month' column. Right now we only have the year and an alpha 'month' column.
I ran into this issue when I tried to make a chart like the one that shows the past month of home use (or solar, or powerwall use, etc), but I wanted it to show a year's data with one bar showing the total for each month.
I was able to get close...

I can use this query:
SELECT sum("home") FROM "daily"."http" WHERE ("month" != '') AND $timeFilter GROUP BY "month" tz('America/New_York')

The problem is I don't see any way to sort it in the correct order. Influx returns the totals sorted alphabetically by month and I can't see how to re-order it in Grafana.
Maybe we could update the Telegraf -> InfluxDB process to also store the month number, but a little Googling seems to say that isn't at all simple to do. The date processor in Telegraf appears to only do the month as a 3-digit alpha string. There may be a Telegraf plugin that would allow this, but it might be more trouble than figuring out how to make this work with Flux queries.
Then again, between typing the last paragraph and this one I spent about an hour trying to figure out Flux. I was able to get a query to return the month numbers, but it throws an error when trying to sum the values. Google search results say this might be a limitation of running it on the Raspberry Pi. I'm giving up for now.
This would be so much easier with a more standard SQL-type database (like MySQL). I know my way around those. InfluxDB seems to have so many limitations.

Thanks for trying @youzer-name !
I may not be following everything, but looking at the heat map, it is basically just time series data with quanta set to "per day" and then the block colored based on that daily value.  This is essentially the same thing we have in our "Solar Year" graph:

Which is based on the daily kwh data built by using InfluxDB continuous query:
CQ:
CREATE CONTINUOUS QUERY cq_kwh ON powerwall RESAMPLE EVERY 1m
BEGIN
    SELECT
        integral(home)/1000/3600 AS home,
        integral(solar)/1000/3600 AS solar,
        integral(from_pw)/1000/3600 AS from_pw,
        integral(to_pw)/1000/3600 AS to_pw,
        integral(from_grid)/1000/3600 AS from_grid,
        integral(to_grid)/1000/3600 AS to_grid
            INTO powerwall.kwh.:MEASUREMENT
    FROM autogen.http GROUP BY time(1h), month, year tz('America/Los_Angeles')
END

Grafana Query:
SELECT sum("solar")
    FROM "kwh"."http" WHERE ("solar" > 0)
        AND time >=<PHONE_NUMBER>667ms and time <= now()
        GROUP BY time(1d) fill(0) tz('America/Los_Angeles')
SELECT sum("home")
    FROM "kwh"."http" WHERE ("home" > 0)
        AND time >=<PHONE_NUMBER>667ms and time <= now()
        GROUP BY time(1d) fill(0) tz('America/Los_Angeles')

One thing to note here with the CQ's and how data is being stored in autogen, kwh, etc. is that all of the data points are being tagged with a "month" and "year" value.
This is created from the GROUP BY clause of the CQ:
FROM autogen.http GROUP BY time(1h), month, year tz('America/Los_Angeles')

A comma after the "time" period is used to add tags to the data. I've only learnt this recently while working on the Tesla history data import program, as I'm needing to replicate the behaviour with the imported data.
@youzer-name example is showing in his query, data is being grouped by the tag values, rather than specific time periods. If it could be done by time period instead, maybe it could work?
The month tag will be a short alpha of the month name, e.g. "Sep" which is also why it won't sort well.
I've noticed what seems to be an issue with tagging of data by "month" "year" etc. as well, in that it seems to tag them in UTC regardless of a tz('your/timezone') in the query.
Here's an example, where you see the "month" tag of my data is changing month at 10am, since my timezone is +10 (at the moment) 😞

@youzer-name I'm curious, do you see the same timezone issue with tagging by "month" "year" in your data?

Wow @mcbirse - that is odd.  Can you share all of the query?  I ran some tests against InfluxDB and it seems to honor timzeone (tz). I wonder if this is a Grafana 9 issue or did you see this before?

@jasonacox I don't think this is a Grafana issue (actually haven't got around to upgrading my production server to 9 yet!)
You can see the issue if you just query the InfluxDB directly.
Three query examples below:

First showing query using time format in my timezone (for start of Sep, note month tag shows "Aug")
Second query is the same, but used time format in UTC and added tz() just to ensure same data is output
Third query shows data returned for time from 9:55am to 10:05 am - you can see this is where the month tag changes over to "Sep"

InfluxDB shell version: 1.8.10
> SELECT * FROM autogen.http WHERE time >= '2022-09-01T00:00:00+10:00' AND time <= '2022-09-01T00:05:00+10:00'
name: http
time                from_grid          from_pw            home               host month percentage         solar              to_grid            to_pw url year
----                ---------          -------            ----               ---- ----- ----------         -----              -------            ----- --- ----
1661954400000000000 7.636363636363637<PHONE_NUMBER>636364<PHONE_NUMBER>9090907      Aug   56.326253953908726 -8.818181818181818 1.0909090909090908 0         2022
1661954460000000000 3.909090909090909<PHONE_NUMBER>7272725<PHONE_NUMBER>818182       Aug   56.281066425666516 -8.909090909090908 7.909090909090909  0         2022
1661954520000000000 8.363636363636363<PHONE_NUMBER>2727275<PHONE_NUMBER>818182       Aug   56.23587889742431  -8.727272727272727 2.272727272727273  0         2022
1661954580000000000 14.090909090909092<PHONE_NUMBER>4545456<PHONE_NUMBER>363636       Aug   56.19069136918211  -8.818181818181818 1.9090909090909092 0         2022
1661954640000000000 9<PHONE_NUMBER>818182<PHONE_NUMBER>7272725      Aug   56.1455038409399   -8.636363636363637 2.5454545454545454 0         2022
1661954700000000000 9.818181818181818<PHONE_NUMBER>2727272725      Aug   56.09278505799066  -8.636363636363637 0.6363636363636364 0         2022
> SELECT * FROM autogen.http WHERE time >= '2022-08-31T14:00:00Z' AND time <= '2022-08-31T14:05:00Z' tz('Australia/Sydney')
name: http
time                from_grid          from_pw            home               host month percentage         solar              to_grid            to_pw url year
----                ---------          -------            ----               ---- ----- ----------         -----              -------            ----- --- ----
1661954400000000000 7.636363636363637<PHONE_NUMBER>636364<PHONE_NUMBER>9090907      Aug   56.326253953908726 -8.818181818181818 1.0909090909090908 0         2022
1661954460000000000 3.909090909090909<PHONE_NUMBER>7272725<PHONE_NUMBER>818182       Aug   56.281066425666516 -8.909090909090908 7.909090909090909  0         2022
1661954520000000000 8.363636363636363<PHONE_NUMBER>2727275<PHONE_NUMBER>818182       Aug   56.23587889742431  -8.727272727272727 2.272727272727273  0         2022
1661954580000000000 14.090909090909092<PHONE_NUMBER>4545456<PHONE_NUMBER>363636       Aug   56.19069136918211  -8.818181818181818 1.9090909090909092 0         2022
1661954640000000000 9<PHONE_NUMBER>818182<PHONE_NUMBER>7272725      Aug   56.1455038409399   -8.636363636363637 2.5454545454545454 0         2022
1661954700000000000 9.818181818181818<PHONE_NUMBER>2727272725      Aug   56.09278505799066  -8.636363636363637 0.6363636363636364 0         2022
> SELECT * FROM autogen.http WHERE time >= '2022-09-01T09:55:00+10:00' AND time <= '2022-09-01T10:05:00+10:00'
name: http
time                from_grid          from_pw home               host month percentage        solar             to_grid            to_pw              url year
----                ---------          ------- ----               ---- ----- ----------        -----             -------            -----              --- ----
1661990100000000000 0.6363636363636364 0<PHONE_NUMBER>9999983      Aug   65.5294472059045  5994<PHONE_NUMBER>090909  4960.909090909091      2022
1661990160000000000 0                  0<PHONE_NUMBER>1818164      Aug   66.09429130893206 5899.909090909091<PHONE_NUMBER>727273  4904.545454545455      2022
1661990220000000000 2.272727272727273  0<PHONE_NUMBER>818182       Aug   66.58382286488929 6012.727272727273 1212.5454545454545 4420.909090909091      2022
1661990280000000000 0                  0<PHONE_NUMBER>181818       Aug   67.15619822262389 7179.272727272727 1797.3636363636363 4992.727272727273      2022
1661990340000000000 4.363636363636363  0<PHONE_NUMBER>9999994      Aug   67.72857358035849 6794.363636363636 1478.8181818181818 4934.545454545455      2022
1661990400000000000 0                  0<PHONE_NUMBER>636362       Sep   68.28588642867902 6869.181818181818 1483.8181818181818 4992.727272727273      2022
1661990460000000000 2.5454545454545454 0<PHONE_NUMBER>9999983      Sep   68.79048049405031 5788.454545454545<PHONE_NUMBER>090909  4585.454545454545      2022
1661990520000000000 5.909090909090909  0<PHONE_NUMBER>818181       Sep   69.33273083295677 5745.818181818182<PHONE_NUMBER>818181  4557.272727272727      2022
1661990580000000000 6.545454545454546  0<PHONE_NUMBER>1818176      Sep   69.80719987949993 4919.727272727273<PHONE_NUMBER>363636  4255.454545454545      2022
1661990640000000000 9.909090909090908  0<PHONE_NUMBER>5454544      Sep   70.2440126525079  3786.181818181818 9.545454545454545  3417.2727272727275     2022
1661990700000000000 5                  0<PHONE_NUMBER>090908       Sep   70.65070040668775 5927.909090909091 1192.2727272727273 4366.363636363636      2022

Because of this issue, grouping by month/year tags seems completely pointless and useless, unless you live in UTC timezone and do not have daylight savings!
Still curious to know if other people see the same issue here?
@jasonacox Can you do a similar check as above on your data. I think your timezone would be -7 from UTC?
If no else is seeing this problem, then there could be an issue with my set up somewhere....

Moved this to issue #80 as I may have discovered it is a problem with telegraf.conf?

After a lot of trial and error (mostly error) I was able to copy all of my InfluxDB data to MySQL and get a query of solar production by month. Still no luck on the heatmap because I'm not sure that a heatmap in Grafana is exactly the same thing as the heatmap in the OP's example. I'll probably keep playing with the heatmaps later...

The copy of the data was accomplished using a Python script, so it should be easy to schedule the script to run and keep the data flowing into the MySQL database.
If anyone is interested in doing something like this, I'll do a separate post under 'show & tell' as there were a bunch of steps needed to get to this result.

Nice work @youzer-name !  I definitely think we should add this MySQL data pipeline script to the tools folder for anyone wanting to do the same.

@jasonacox Ugh... I found something else amiss in my data as a result of getting it over into MySQL. The issue @mcbirse noticed with the timezones and month tags also spills over into the downsampled daily data.
Background info: I just updated the telegraf.conf file to add the TZ reference per the recent discussion and bug report. I recreated the stack after that. I am using America/New_York for my TZ, (== GMT -0400 in DST and -0500 standard time).
When I tried to set the datetime as a primary key in MySQL on the 'daily' table (to prevent duplicates being created) I got an error that the key couldn't be created as there were duplicate values in the datetime field.
Looking at the data, I have TWO entries for the last day of each month, each with a different value in the 'month' field.
2022-08-29T04:00:00Z 27.61983005411255   9.093889971139971    50.55084173656204       Aug   26.54738099927849      0.09192271464646465   12.595960317460316        2022
2022-08-30T04:00:00Z 19.71932777777778   13.123890782828282   41.86573716856061       Aug   20.400520580808077     0.11669671717171716   11.23269696969697         2022
2022-08-31T04:00:00Z 3.800571969696969   3.667393939393939    7.439026704545457       Sep   -0.0024954545454545455 0.018624242424242425  0.0024848484848484843     2022
2022-08-31T04:00:00Z 8.392989318181817   5.115769696969697    26.56693058080808       Aug   24.57233343434344      0.11186666666666668   11.380322474747475        2022
2022-09-01T04:00:00Z 46.81284646464646   3.8834981060606055   61.56610385416667       Sep   28.972736111111104     0.10087462121212122   17.993631944444445        2022

The entry showing the 'next month' (so in this case, the entry on 8/31 that shows 'Sep') never seems to show much in the way of solar, leading me to think this entry is always only using data from the night time.
When I sum up the hourly data from kwh using this query (in MySQL):
select sum(home) from kwh where datetime >= '2022-08-31 04:00:00' and datetime < '2022-09-01 00:00:00'

I get 26.56, which is the value in the daily table for 8/31/22 Aug
When I sum up the hourly data for the last four hours of the day (local time)
select sum(home) from kwh where datetime >= '2022-09-01 00:00:00' and datetime < '2022-09-01 04:00:00'

I get 7.43, which is the value in the daily table for 8/31/22 Sep.
I guess this is as a result of the downsampling to 'daily' happening every hour. In EDT timezone, for 20 hours on the last day of each month the process wrote the downsampled data to a row with the correct month, and for the last 4 hours of the day it was writing it to a new row with the wrong month.
This doesn't really create too big an issue if you ignore the month column (which was kind of the whole purpose for me trying to get this data into MySQL) except it means I can't create a primary key on the datetime field to prevent duplicate entries. I could make a multi-field index to prevent duplicates (for example: the combination of datetime and month must be unique), but then I realized that the way the downsampling occurs also creates an issue if I try to pull the daily data for today before the day is over. Since the daily entry for today is updated every hour and isn't a complete sum of today's data until the day is over, if I set it as unique, then the first entry for today's date will be the only one that makes it into the SQL database.
The two options I see for working around this are:

Just stick with the hourly data. It is 24x as much data, but may just be simpler
Set up the query in the python script to only pull yesterday's data. Never today's. Combined with a unique constraint that doesn't allow duplicates with the exact same datetime and month, that should result in accurate data in the MySQL daily table.

Given the above, I'm going to update my post in the show & tell section to have it pull both daily and hourly data, and make sure the query for daily data always lags by one day. I'll include notes about the multi-field unique key that needs to be created in the daily table to deal with the old data for anyone that was logging prior to the bug fix in telegraf.conf.

Good catch, @youzer-name  - I suspect the culprit is the downsampling CQs:
CREATE CONTINUOUS QUERY cq_kwh ON powerwall RESAMPLE EVERY 1m
BEGIN
SELECT integral(home)/1000/3600 AS home,
integral(solar)/1000/3600 AS solar, integral(from_pw)/1000/3600 AS from_pw,
integral(to_pw)/1000/3600 AS to_pw, integral(from_grid)/1000/3600 AS from_grid,
integral(to_grid)/1000/3600 AS to_grid
INTO powerwall.kwh.:MEASUREMENT
FROM autogen.http
GROUP BY time(1h), month, year tz('America/Los_Angeles')
END

CREATE CONTINUOUS QUERY cq_daily ON powerwall RESAMPLE EVERY 1h
BEGIN
SELECT sum(home) AS home, sum(solar) AS solar,
sum(from_pw) AS from_pw, sum(to_pw) AS to_pw, sum(from_grid) AS from_grid,
sum(to_grid) AS to_grid
INTO powerwall.daily.:MEASUREMENT
FROM powerwall.kwh.http
GROUP BY time(1d), month, year tz('America/Los_Angeles')
END

It is pulling the month and year  tags (set by telegraf) into the downsample series so prior to the telegraf.conf fix, that data is bad too.  Unless I'm missing something. The existing dashboard graphs won't care since they aren't using the tags, but this definitely creates a problem for anything using those tag.

@jasonacox I think this issue crosses over to some early work I'm doing on trying to get the power reporting to line up as near as possible to the Tesla generation data (which will help me solve an entirely separate problem of being to lazy to get up from my desk to do a reading from an unconnected inverter ...).
From the work I've been doing, I'm think that I can get the result I'm looking for by using a different version of the powerwall.kwh.xxx query, and I think this may also help with resolving heatmap and other downsampling issues on the kwh data.
The revised version I've got in my head (but haven't tested yet as I'm not quite ready to trash my database just yet) is along the lines:
# New retention policy - grab total kWh generated in a minute
CREATE RETENTION POLICY kwh_pm ON powerwall duration INF replication 1

# ...

# Query pulls minute of data by differencing last cumulative export/import reading between buckets.
# Needs all of  LAST, DIFFERENCE and GROUP BY <time> to work correctly.
# This approach eliminates drift from integral (1:1 correspondence with Powerwall source of truth) and *may*
# self correct for outages (as it is working on differences of cumulatives)
# Doing this allows easy accumulation of data during hour by sum. Not sure if resampling is needed?
CREATE CONTINUOUS QUERY cq_kwh_pm ON powerwall
BEGIN
SELECT DIFFERENCE(LAST(solar_energy_exported))/1000 AS solar,
DIFFERENCE(LAST(load_energy_imported))/1000 AS home,
DIFFERENCE(LAST(battery_energy_exported))/1000 AS from_pw,
DIFFERENCE(LAST(battery_energy_imported))/1000 AS to_pw,
DIFFERENCE(LAST(site_energy_imported))/1000 AS from_grid,
DIFFERENCE(LAST(site_energy_exported))/1000 AS to_grid
INTO powerwall.kwh_pm.:MEASUREMENT
FROM raw.http
GROUP BY time(1m), month, year tz('America/Los_Angeles')
END

# And then hourly becomes:
CREATE CONTINUOUS QUERY cq_kwh ON powerwall RESAMPLE EVERY 1m
BEGIN
SELECT sum(home) AS home, sum(solar) AS solar,
sum(from_pw) AS from_pw,
sum(to_pw) AS to_pw,
sum(from_grid) AS from_grid,
sum(to_grid) AS to_grid
INTO powerwall.kwh.:MEASUREMENT FROM powerwall.kwh_pm.http GROUP BY time(1h), month, year tz('America/Los_Angeles') END

# daily and monthly unchanged.

If this works as I think it does, it should be a bit a cleaner than the integral and should have a one for one correspondence to the tesla cumulatives as long as there is no downtime (and may work correctly even then if InfluxQL is smart enough about the interval differences).
I'll keep working this for the stuff I'm looking at and will report back, but I thought I would mention it here in case it helps with the current issue.


Escape for underscore, Add escaping to new parser, Refactoring/cleanup

Issue #231

Fixes escaping bug for _ when serializing text nodes
Add escaping logic in parser consistent with that used in markdown-common for serialization
Quite a bit of clean up of commonmark and parser generation rules

Coverage increased (+0.01%) to 90.772% when pulling 560bc25c83d3877b8f16d9850b59728478ac74ba on parserv2 into 371b31a03316479d912863485dbe178bddb03ac9 on master.


Introduce host services convert inputs

Host services are a way to provide functionality to stages that is restricted to the host and not directly available in the container, such as providing input to stages, devices access and mounting.
Convert inputs to use host services.
See individual commits for more details.

Converting to draft because I wanna change one small thing.

This is superseded by #651


Add function for downloading an uploaded file

Zulip's API has a pair of related URLs for accessing uploaded files that need better documentation and tooling:

GET /user_uploads/...
GET /api/v1/user_uploads/...

The former just downloads a file (possibly via a 302 redirect to a temporary access URL of the form /user_uploads/temporary/...).  The latter returns such a temporary access URL (basically what the former would have redirected to), which is useful for cases where a client's HTTP library doesn't support following redirects.  Neither is currently covered in our API documentation.
The consequence of this is background is that client.call_endpoint() in the Python bindings using logic like this:
    path: str = re.fullmatch(
        '\s*cat\s*\[[^\[\]]*\]\(([^\(\)]*)\)\s*', message['content']
    ).group(1)

    content = str(client.call_endpoint(url = path, method = 'GET'))

which is the most convenient way to provide authentication, may end up visiting /api/v1/user_uploads and returning a temporary access URL, rather than downloading the file.  What we need is an alternative to client.call_endpoint that doesn't prepend /api/v1/.  One option would be to refactor the call_endpoint system to require passing /api/v1 explicitly, which might be a better system in any case; then something like the code above would work.  (I'd want to provide an explicit client.fetch_upload(path | url) method in any case, but it could just call client.call_endpoint, and we'd have a clear mechanism for how to use API authentication to request other similar endpoints that don't have an /api/v1 prefix in the future -- which will largely be endpoints that serve images or other assets that need to be shared between web and mobile)
https://chat.zulip.org/#narrow/stream/49-development-help/topic/Bot.20download.20file/near/1027190 has more background

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Hey, I would like to work on this. So, the tasks involved would be -

Refactor the code to add another parameter to the call_endpoint function to specify the API version (with default being nothing prepended?).
Create another function fetch_upload to download an uploaded file which takes a url parameter and another path parameter to which it writes the file.

I was thinking the parameter could be a string called api_version, which we can check if it is valid, else use default (nothing prepended to url).
Please let me know if this sounds right so I can get started on working on this.

Hey, I would like to work on this. So, the tasks involved would be -

Refactor the code to add another parameter to the call_endpoint function to specify the API version (with default being v1).
Create another function fetch_upload to download an uploaded file which takes a url parameter and another path parameter to which it writes the file.

I was thinking the parameter could be a string called api_version, which we can check if it is valid, else use default as v1. For nothing to be prepended, they need to explicitly pass None or an empty string.
Please let me know if this sounds right so I can get started on working on this.

@zulipbot claim

@zulipbot claim

@zulipbot claim

claim

@zulipbot claim

@zulipbot claim

Hi there! 👋
I hope this finds you well. I came across this intriguing issue and I'm eager to contribute to the project. Could you please confirm if this issue is still open and available for work?
If it is, I'd love to take a shot at resolving it. Could you kindly assign this issue to me? I'm excited to get started and contribute to the project!
Thanks in advance!

@zulipbot claim


HTTP sessions needs to be closed explicitly in golang

Version information
0.1.44
Describe the bug
For a http session that is established in golang will stay open for a certain no response time. which is causing the http connections to be held and exceeding the connection limit.
Currently the close call is just a dummy and has no implementation
To Reproduce
Create http sessions till the limit gets exceeded.
Expected behavior
Close method shall close the http session
Additional context
will try the solution in below link
https://stackoverflow.com/questions/50637433/forcefully-close-http-connection-in-golang

resolved in #334


Constantly re-directing after successful authentication

Hello guys,
Currently i'm hitting with too many redirects issue, even after successful authentication with google.
My setup involves using Cognito, which allows to login via google.
I have configured my Cognito callBackUrls same as my site url https://xyz.test.com.
Has anyone had anything similar know why this could be?
Thank you!

I am trying to use a SAML provider, How are you able to pass different id providers from the code?

Basically using the same code as you @nagendrakumar02 https://github.com/awslabs/cognito-at-edge/issues/56

Hi @edas-smith ,
If that is not already the case, I suggest upgrading to the latest version of cognito-at-edge (1.3.1) as it fixes an issue with cookie parsing that could cause redirection loops in some cases.
If you are building a web app using AWS Amplify, you may want to try to authenticate to the Cognito userpool from within your app using Auth.federatedSignIn(). That would allow you to determine if the issue comes from your user pool configuration or from the Lambda@Edge function.

Hello @jeandek I have checked and it definitely is up to date. I think the error will likely be on my end somewhere, rather than an actual issue. Will close.


NIFI-7197 - In-place replacement in LookupRecord processor

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks for the review @markap14 - I pushed a commit to address your remarks and added an additionalDetails.html to document the processor with examples. Feel free to comment/suggest additional modifications. Thanks again!

All looks good to me here @pvillard31. Thanks for adding that additionalDetails.html. I think with that added, and the change to the more descriptive Allowable Values, it's much easier to understand how the processor operates. Very nicely done! +1 merged to master.


On the final leaderboard is a button which when clicked returns the player to the lobby screen

comment 3342d11f79b03bfdda0c409804890b47be86380f


Prp 204 - Details Page

Ticket
https://wicmtdp.atlassian.net/browse/PRP-204
Changes

Details page has a validator with error props for all fields
Add a participant button creates new cards
Remove Participant button destroys cards
Data validated on the backend
Loader repopulates form
Storybook supports add / remove buttons
Data in the database overrides the count variable (if you pass count=4 and there are 5 records, 5 cards will render and vice versa)
Removing the last ParticipantCard deletes the data, then renders a new blank ParticipantCard

Omitted AC

Page does not populate a card with name details when a participant clicks "Self" for relationship
Page does not check for duplicate "Self" fields (it's such a long story, i spent an hour on it and could get it to keep the page from submitting, but not propagate an error correctly about it)
Count page does not lock the field

Context for reviewers
So much manual testing; I feel confident that this page works in the way it was described, and is durable to page interactions of all kinds in any order. (Probably honing off those edge cases took 10 hours 😭)
Testing

Incredible work!
I pulled this up on my local environment, and I'm having an issue where the radio buttons are fixed when I go back/forward and then return to /details. So, for example, I can't switch the relationship type or adjunctive eligibility.

Are we able to change the validation pattern so each field doesn't get a message?

Also wondering if anything can be done about this (though maybe it will be fixed if we get a single error message across the 3 fields...)

i dislike the per field error appearance in this case due to space but that's how it works for any validated form.
we'd have to switch the error to be on the card and likely remove the validated form entirely. we'd need a new function in the server to interpret and intervene in the action response,  and we'd have to put onchange or onblur calls in every field that called a similar validation on the client
If it's just the date field, we'd have to have the field be a standalone component rather than a group of 3 fields, and the useField hook called there. It's doable and less work than managing all of the field error messages but will still take a bit of time to build and test

Incredible work!
I pulled this up on my local environment, and I'm having an issue where the radio buttons are fixed when I go back/forward and then return to /details. So, for example, I can't switch the relationship type or adjunctive eligibility.

This is a bug. I know where it's happening, and will fix it shortly

Pushed a fix tho this. Storybook now has one card with fake data in it; the Console would show an error before this change referring to your reported bug.


Pass embedding to Isolated label silhouette

As far as I got, now it's not possible to pass embeddings other than X_pca to isolated_labels when computing Isolated labels silhouette score? Is there a particular reason for using only PCA?
Thanks.

We do compute isolated label scores on adata.obsm['X_embedding'] as well. Why would you suggest only X_pca is allowed?

It looks like in metrics there's no embed parameter in the isolated_labels() function, so it's not passed to score_isolated labels() and to silhouette(), so embed='X_pca' is then used in the latter by default. Am I missing something?

Hmm, I see what you mean. @mumichae could you check this out? You wrote the function I believe.

Hi @alitinet, thanks for pointing that out. Indeed, the option to include was missing. A fix should be merged soon #213

@alitinet The PR is now merged. If it solves your issue, we can close this issue

Hi @mumichae, yes, it does, thanks!


I NEED HELP!!! Why do I get an error assertion message "invalid tokenin operation" when I sell ram?

the command operation is "cleos -u https://geo.eosasia.one system sellram aaasportsnba 1024"
but the response is odd:
Error 3050003: eosio_assert_message assertion failure
Error Details:
assertion failure with message: invalid tokenin operation
pending console output:
my other accounts on the mainnet and jungle testnet are fine, but the problem is only happened on this "aaasportsnba" account, so weird.
ps: this account is not mine, and I only have its active permission, and this account's owner permission is not same as its active permission. I'm not sure if this affect its sellram operation.

Hi @ashuralyk, I checked the eosio.system contracts in the mainnet and it doesn't have the above error message that you shared. eosio's sellram action is going to trigger inline action to eosio.token transfer, and eosio.token transfer is going to notify both the sender and recipient of the transfer. I checked aaasportsnba account in the mainnet and it has a contract deployed to it, so I suspect that the above error message is being emitted by aaasportsnba smart contract which reacts to the eosio.token transfer action.
By the way, owner permission and active permission is advisable not to be the same for security. This shouldn't affect the sellram operation.


2.1.7 Bricked Liquidity Mining and Swap Tether

So after the update there is no way you can add funds to liquidity mining and no chance to swap for tether.
After downgrading to 2.1.6 i could swap but could not provide liqudity either in 2.1.6 or 2.1.7.
In my opinion you bricked something with this upgrade. QA is the most important position in a software house :)

Hi @TheWeeezel , I suppose you're referring to this issue https://github.com/DeFiCh/app/issues/280. I'll proceed to close this issue as we would like to keep same issues in one thread. Unless your issue is different, you may reopen. Please send your app logs and screenshots if you do so. Thank you.

Hi @TheWeeezel , I suppose you're referring to this issue https://github.com/DeFiCh/app/issues/280. I'll proceed to close this issue as we would like to keep same issues in one thread. Unless your issue is different, you may reopen. Please send your app logs and screenshots if you do so. Thank you.


build error

error as follow :+1:
/home/lx/lanelet/ws/src/liblanelet/src/liblanelet/llet_xml.cpp: In member function ‘void {anonymous}::XMLParser::parse_nodes()’: /home/lx/lanelet/ws/src/liblanelet/src/liblanelet/llet_xml.cpp:403:50: error: ‘class pugi::xml_attribute’ has no member named ‘as_llong’          int64_t id = node.node().attribute("id").as_llong();                                                   ^ /home/lx/lanelet/ws/src/liblanelet/src/liblanelet/llet_xml.cpp: In member function ‘void {anonymous}::XMLParser::parse_linestrips()’: /home/lx/lanelet/ws/src/liblanelet/src/liblanelet/llet_xml.cpp:419:53: error: ‘class pugi::xml_attribute’ has no member named ‘as_llong’          linestrips_by_id[way.node().attribute("id").as_llong()] = new_linestrip;
and the lib versions are as follows:
libtinyxml-dev is already the newest version (2.6.2-3).
libpugixml-dev is already the newest version (1.7-2).

I figure out it by add
add_definitions(-D PUGIXML_HAS_LONG_LONG)
int https://github.com/fzi-forschungszentrum-informatik/liblanelet/blob/252e436ae9f705f8004d86b504be6a5f0c8bcc19/src/liblanelet/CMakeLists.txt#L103


docker v2 registry push repeat issue analyze

first I push my docker version and docker info
Client version: 1.7.0-dev
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 1b09ac5
OS/Arch (client): linux/amd64
Server version: 1.7.0-dev
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 1b09ac5
OS/Arch (server): linux/amd64

Containers: 0
Images: 10
Storage Driver: btrfs
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.12.35-100.el6.x86_64
Operating System: <unknown> (containerized)
CPUs: 24
Total Memory: 63.01 GiB
Name: 8168d9029f8f
ID: S5PV:25YJ:IKCF:OUUQ:FBWV:ZHGV:44VA:GOOT:NIOW:L6O4:YA3T:KVOI
Debug mode (server): true
Debug mode (client): false
File Descriptors: 13
Goroutines: 15
System Time: 2015-05-14T18:56:35.348407166+08:00
EventsListeners: 0
Init SHA1:
Init Path: /usr/bin/docker
Docker Root Dir: /var/lib/docker

i think docker push check image course is this:
client : docker push  order begin
ex:  docker push cents:6.6
docker client get /var/lib/graph/{image.id}/checksum is exist , if not exist , execute docker push this image, after push success, get push "digest" , and write it in /var/lib/graph/{image.id}/checksum.
second, docker push same image again.
docker get /var/lib/graph/{image.id}/checksum,and request v2 registry api , get registry blob digest, like
http://registry/v2/<name>/blobs/sha256:6547613252cf9a0a959575a4d22d99a9c91bcdc5bb4b5812a132d1fb757b6156

if response http code is "200" , docker think this image layer is exist .
so docker client echo "Image already exists".
so this is a import question:
ex :
I have a base image "centos:6.6"  , I push it to registry success .
this image layers is ：
f1b10cd84249
8b44529354f3
b0120c5afd0c
dfef3577fe68:
b0918483ae7c
and I docker build another image "app1", from "cents:6.6" in Dockerfile.
this image layer is
f1b10cd84249(inherit centos:6.6)
8b44529354f3(inherit centos:6.6)
b0120c5afd0c(inherit centos:6.6)
dfef3577fe68(inherit centos:6.6)
b0918483ae7c(inherit centos:6.6)
5cd06ab8d856(app1 image layer self)
69abefce2aff(app1 image layer self)
b5a3454eaa54(app1 image layer self)
94dce5816750(app1 image layer self)
I push app1 , docker client will request ，check image layer is exist。
http://registry/v2/app1/blobs/{digest}

this will get b0918483ae7c(inherit centos:6.6) checksum , and request
http://registry/v2/app1/blobs/{digest}

response 404 !.
because b0918483ae7c is  centos:6.6 image layer , if request
http://registry/v2/centos/blobs/{digest}

response 200 !.
so , if docker push app1 , it will repeat image layers inherit centos:6.6, and push success will rewrite checksum .
so, if you docker build a new image first , it will push whole image layers , from 0 to last , not to mind if not  inherit 。
this way is not efficiency 。

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

@stevvooe

@blackfader Efficiency-wise, the V2 protocol is biased towards pull rather than push. The behavior you've described is a side-effect of access-control in the V2 protocol. From a high-level, the image has a list of blobs that make it up. Currently, all of these blobs need to be "mounted" into a remote repository (ie "app1" or "centos"). When pushing these blobs (layers) for the first time into a new repository, the client must "prove" they have access to the blob by sending it. This gets verified and the blob then becomes available in the new repository. Even though data is sent "unnecessarily", data is only ever stored once.
We are working on cross-repository dependencies for V2 images as a part of docker/distribution#62 to address this. The caveat is that one must retain access to the dependent repositories to be able to continue running the image.

@stevvooe  thanks to your replay，in my scene to use docker：
a user will have a app1 self，so，the step of starting this app1 is ：
first ，create app1 dockerfile（from centos）。
second，build image by dockerfile。

I think ， “first push a new image” spend too much time，so ， Is there a way to save time ？

@blackfader The best way to save time is to keep the image name constant on each update. For example, if you have an image app1 based on centos, make sure that subsequent builds of app1 are tagged as app1 or you will have to push again (ie don't push app2, app3...) . This will reduce the likelihood that data needs to be re-pushed.
Optionally, you could just retag the centos image app1:centos-base as the first step, and let that run in parallel with the build. When the build is done, tag the image as app1:<some build>. By the time you push app1:<some build>, the layers should already be available.

@stevvooe thanks a lot , this way is good!
I think ，others also have this problem， so I suggest write in to document as FAQ 。

@blackfader No problem. I filed #526 to document this issue.


Update README.md

fix the choice of question (what's SHA256)

Thanks for the update / wrong answer fix. Keep it up. Cheers. Prost.


PDF export is missing first pages

In latest version PDF export has truncated top.
This might be due to handling of TOC depth in newest version 1.1.0 but removing toc with add_table_of_contents: false still doesn't fix it (that is, sometimes it does, I guess it depends on the size of the doc).
Here are some screenshots - on all front page is missing and depending on TOC depth there are different outputs. Removing TOC doesn't fix front page problem.
screenshots

This is with latest material (v7.1.0)

This actually seems to be due to mkdocs-material changes. I tested 1.0.0 with material 7.1.0 and there is the same problem.
Then I tested 1.1.0 with all latest mkdocs-material versions and got this:

last v6 (6.2.8) works
version 7.0.0 is the first one showing the problem and it is there in all subsequent versions.

https://squidfunk.github.io/mkdocs-material/changelog

thnx for all the updates this & other issues. I have planned some time next week to do another big iteration on this plugin.

It works. Thanks a lot :)


[Lint] N804 Stop enforcing cls for metaclasses' @classmethods first argument

Hello,
There are many discussions (e.g. #13698) about metaclasses and N804, some of which may require further inquieries. But I'm fairly certain we can already agree on the fact that enforcing cls for the first argument name of a metaclass' @classmethod if wrong.
class A(type):
    def a(self): ...  # Should FAIL: OK

    def b(cls): ...  # Should PASS: OK

    @classmethod
    def c(cls): ...  # Should FAIL: NOT OK

    @classmethod
    def d(mcs): ...  # Should PASS: NOT OK

Output:
tmp.py:2:11: N804 First argument of a class method should be named `cls`
  |
1 | class A(type):
2 |     def a(self): ...
  |           ^^^^ N804
3 |
4 |     def b(cls): ...
  |
  = help: Rename `self` to `cls`

tmp.py:10:11: N804 First argument of a class method should be named `cls`
   |
 9 |     @classmethod
10 |     def d(mcs): ...
   |           ^^^ N804
   |
   = help: Rename `mcs` to `cls`

Thanks for opening this issue. I'd prefer if we keep the discussion in as few places as possible and there's already https://github.com/astral-sh/ruff/issues/6017 (which also explains some of the reasons why it is the way it is today, not saying we shouldn't change).


Remove &feature=youtu.be from URL

The &feature=youtu.be segment is present in some edge cases, eg. when opened via UserScript.
It serves no purpose, should be automatically removed.

Fixed in a58e598a


pylint all the *.py things! (in tools/, ...)

Static analysis has brought us nice things. pylint now runs on the gRPC Python codebase and tests (#261).  In addition to running shellcheck on *.sh, we should aim to run pylint on all *.py in the project to catch bugs.

To the best of my knowledge this is still actionable.


Error executing POST request

give me the error
Error: Error executing POST request！
Received error code:401

Hi Juude,
Thanks for the feedback. Can you please give more details about what API (face, speech, etc) that you are using, or what sample gave you the error? Given more details, we will look into it. Sorry for the inconvenience.
Thanks,
Yung-Shin

hi @Juude !
is it possible that you did not provide the subscription key? usually 401 error is a permission issue

Please also note that subscription key is per service (face, speech, etc). Here is the updated page to get subscription key for free use: http://projectoxford.ai/subscription

Bump to @Juude, are you still having an issue with the API? Let us know so we can file a bug report or close out this issue.
Thanks!

Line 496 in code is misleading. It should read:
Authentication auth = new Authentication("Your ClientId goes here", "Your Primary Key for Speech API goes here");

This issue was moved to Microsoft/Cognitive-Speech-TTS#2

@Juude , Have u solved that issue regarding Error executing post request! ?


Pattern rotation direction- similar to issue #72

I have noticed the one corner of my table tends to lose sand faster than others. I believe it is due to the counterclockwise rotation direction of patterns.  For simplest example, start with a circle, starting size 10, and make 20 loops.  The pattern will start with the ball at the center of the table and expand outward, in an increasing counterclockwise spiral. You can reverse the path, which will then make it move clockwise, but it will start at the outside and move inward. There doesn't seem to be any way to make the pattern start at the center of the table and move the ball in a clockwise spiral.
Is there some way reverse the direction that I'm missing?

You're right, I don't have any mirror or counter clockwise options. But I'm not sure that would solve your sand gathering issue.
Regardless, I think that would be a simple option to add, and it makes some sense. Thanks for the idea.

I missed this issue. This is supported by setting Direction on the Circle layer, though looking at it, I think the labels are opposite what they should be.


1

Prerequisites

[ ] I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes
Description

1

1


where is the dataset？

where is the dataset？I would appreciate it if you can provide it for me and My mail is<EMAIL_ADDRESS>

Hey @1905215165 thanks for pointing that out!
Just updated the docs :)


chore: update repo by service bot

This is a routine update from cc-service-bot based on the service.yml in your repo. This PR
should be approved and merged as soon as CI passes.

CHANGELOG
FILE NAME - CHANGED BY - COMMIT MESSAGE
Makefile - framework - chore: update repo Makefile cc-mk-include v0.1135.0
cc-mk-include/compare/v0.1134.0...v0.1135.0


Add new tmux version to TravisCI matrix

Adding tmux versions 2.4, 2.5, and 2.6 to the
TravisCI matrix.

The test suite passes on my machine using the newly introduced versions of tmux. Any opposition to merging this?
/cc @adamstrickland @Soliah @rglassett

I don't have a problem with this, but I'm a bit surprised that we don't have an accommodation WRT to tmux v 2.5 & https://github.com/tmuxinator/tmuxinator/issues/536

Closing in favor of https://github.com/tmuxinator/tmuxinator/pull/579 (requires supported update)


Hidden Drawer doesn't update its visibility property accordingly

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior
In a xs-width viewport, clicking the menu button doesn't display the drawer.
Steps to Reproduce
https://codesandbox.io/s/3qol95n215

Reduce the viewport to hide the permanent drawer
Click the menu icon in the header to toggle the drawer
Notice the presence of the drawer in the HTML inspector, and it's visibility CSS property

Context
I'm trying to have a responsive drawer that would be modal in a xs-width
viewport, and permanent sm and above.
Your Environment

Tech
Version

Material-UI
v1.0.0

React
v16.2.0

browser
Google Chrome v66.0.3359.181

React 16.2.0 is not supported. Check the peer dependency installation warning in the console. Use React 16.3.0.

A lot of people have been raising this issue. Let's add a throw.

I don't know which warning  you are speaking of as I don't see anything in the console.
I have tried with React 16.3.0 as well as latest React with latest Material-UI. Still seeing the same results.

https://codesandbox.io/s/x7613j68vo

Looks like I forgot to update react-dom as well! Thanks
On Fri, Jun 8, 2018, 18:43 Olivier Tassinari<EMAIL_ADDRESS>wrote:

https://codesandbox.io/s/x7613j68vo
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/11770#issuecomment-395818523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFWUsP1w-q1hLwg2M-j6RJ9ELBetD8_Vks5t6qmUgaJpZM4UgAU7
.

--
Mathieu Marques


Does shepherd-theme-arrows work with angular-shepherd?

I am attempting to use shepherd-theme-arrows from the cloudflare cdn. It causes the model to look like this with the content missing but the arrow showing.

Is there something I am missing? Is the angular version compatible with the arrows theme?

I am using angular-shepherd. I wanted to use the arrows theme but it sounds like that is a legacy feature. I think that answers my question, thank you :).

@Buttars the arrows theme is built in. It is the default and all styles are shipped with the JS now. If you use angular-shepherd, you get the styles automatically.


Link symbols in the doc generator.

This PR:

Links symbols together in doc generator.
Add @doclink jsdoc tag which allows you to have types with a name link to others. Used to link Tensor1D => Tensor, and other subclasses which will become aliases.

This change is

 This is exciting. Amazing work

Reviewed 28 of 29 files at r1, 1 of 1 files at r2.
Review status: 28 of 29 files reviewed at latest revision, 9 unresolved discussions.

src/tensor.ts, line 121 at r1 (raw file):

 * that has a shape and a data type.
 *
 * See `tensor` for details on how to create a `Tensor`.

nice, just noticed that the first one (tensor) links to the method , and the second (Tensor) links to the class.  Small suggestion (not feeling strongly): if not too complex, can we render in the final html tensor as dl.tensor() to make it clear we are linking to a method, and also because that method is presented to the user as dl.tensor. So the documentation will read:
See `dl.tensor()` for details on how to create a `Tensor`.

src/ops/lstm.ts, line 73 at r1 (raw file):

   * @param data The input to the cell.
   * @param c Previous cell state.
   * @param h Previous cell output.

any reason why we remove @return? Can we add in the jsdoc somewhere that that tuple is [cellState, cellOutput], and not the other way around.

src/ops/reverse.ts, line 27 at r2 (raw file):

export class Ops {
  /**
   * Reverses a `Tensor1D.

closing backtick missing

src/ops/unary_ops.ts, line 201 at r2 (raw file):

   * Computes scaled exponential linear element-wise.
   *
   * `x < 0 ? scale * alpha * (exp(x) - 1) : x`

strange that alpha is in the jsdoc, but not a param. TF has the same problem: https://www.tensorflow.org/versions/master/api_docs/python/tf/nn/selu

website/api/index.html, line 156 at r2 (raw file):

      background: #f4f4f4;
      padding: 4px 6px;
      font: 500 90%/2 Roboto Mono, monospace;

90%/2 is interesting, first time seeing that :)

website/api/view.ts, line 38 at r2 (raw file):

export interface DocClass {
  symbolName: string;
  namespace: string;

namespace is a reserved keyword in Typescript, surprised compiler doesn't care, i guess since it's a property in an interface.

website/scripts/api-parser.ts, line 63 at r2 (raw file):

          name: 'Classes',
          pin: [
            'Tensor', 'Scalar', 'Tensor1D', 'Tensor2D', 'Tensor3D', 'Tensor4D'

we are not showing scalar/Tensor1D/... etc anymore, remove from the pin?

website/scripts/api-parser.ts, line 88 at r2 (raw file):

          name: 'Classes',
          pin: [
            'SGDOptimizer', 'MomentumOptimizer', 'AdagradOptimizer',

same here, not showing these classes anymore, remove from pin?

website/scripts/api-util.ts, line 362 at r2 (raw file):

/**
 * Adds markdown links for reference symbols in documentation, parameter types,
 * and return types.

add to comment that it uses the @doclink jsdoc tag

Comments from Reviewable

Review status: 22 of 29 files reviewed at latest revision, 9 unresolved discussions, some commit checks pending.

src/tensor.ts, line 121 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
nice, just noticed that the first one (tensor) links to the method , and the second (Tensor) links to the class.  Small suggestion (not feeling strongly): if not too complex, can we render in the final html tensor as dl.tensor() to make it clear we are linking to a method, and also because that method is presented to the user as dl.tensor. So the documentation will read:
See `dl.tensor()` for details on how to create a `Tensor`.

Done.

src/ops/lstm.ts, line 73 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
any reason why we remove @return? Can we add in the jsdoc somewhere that that tuple is [cellState, cellOutput], and not the other way around.

@return doesnt do anything with our docs right now, plus it's supposed to be @returns. I added a comment to this effect.

src/ops/reverse.ts, line 27 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
closing backtick missing

Done.

src/ops/unary_ops.ts, line 201 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
strange that alpha is in the jsdoc, but not a param. TF has the same problem: https://www.tensorflow.org/versions/master/api_docs/python/tf/nn/selu

Selu's alpha and scale are those magical constants

website/api/index.html, line 156 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
90%/2 is interesting, first time seeing that :)

Copy pasted from TensorFlow :)

website/api/view.ts, line 38 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
namespace is a reserved keyword in Typescript, surprised compiler doesn't care, i guess since it's a property in an interface.

Yeah it doesn't care since it's a property, e.g. a string.

website/scripts/api-parser.ts, line 63 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
we are not showing scalar/Tensor1D/... etc anymore, remove from the pin?

Done.

website/scripts/api-parser.ts, line 88 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
same here, not showing these classes anymore, remove from pin?

Done.

website/scripts/api-util.ts, line 362 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
add to comment that it uses the @doclink jsdoc tag

Done.

Comments from Reviewable


[BUG] - Comment Box Plugin has No Docs and Does Not Work By Default

Briefly describe the bug.
Cannot use the provided Comment Box plugin in its default state. All comments error. No documentation for fixing.
How can we reproduce the bug?

Go to your DAO's space
Click on settings
Go Advanced -> Plugins
Install Comment Box
Make a new proposal, comment box returns an error every time anyone attempts to comment.

What is the expected behaviour?
I should be able to leave comments or be given documentation on how to configure the plugin.
The documentation has nothing. https://docs.snapshot.org/user-guides/plugins/comment-box
Can you attach screenshots?

Can you provide your device specific details below?

Device Type - Macbook
Device OS - OSX
OS Version - OSX Latest
Browser - Chrome
Browser Version - ?
Wallet - Metamask
Space - SidewaysDAO

Hi, comment box has been deprecated for some time, and has now been removed


added reference to new sample files, improved pre-requisites and pointed to potential subsequent tutorials that might be relevant

Next time, prerequisites that are sentences end in periods. Please add periods next time you update

Done and pushed to QA

Marcus Behrens, Director Product Management, SAP IoT, +49 160 8896 474
I respond to SMS, Teams and WhatsApp in 1 hour, email in 1 day or never
From: Daniel Wroblewski<EMAIL_ADDRESS>Date: Wednesday, 7. October 2020 at 11:45
To: SAPDocuments/Tutorials<EMAIL_ADDRESS>Cc: Behrens, Marcus Conrad<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [SAPDocuments/Tutorials] added reference to new sample files, improved pre-requisites and pointed to potential subsequent tutorials that might be relevant (#5939)
Next time, prerequisites that are sentences end in periods. Please add periods next time you update
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SAPDocuments/Tutorials/pull/5939#issuecomment-704822318, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACKKGUDHEUA3ZFDBPR3PFQ3SJQ2DFANCNFSM4SHDSOPQ.


[BUG]: Video Data reload on basic video operation like play, pause

Version
6.6.2
What platforms are you having the problem on?
Android
System Version
Android 14
On what device are you experiencing the issue?
Real device
Architecture
New architecture with interop layer
What happened?
A bug happened! Performing video actions like play, pause, resize, select tracks cause video to reload data on new architecture.
Reproduction Link
repository link
Reproduction
Step to reproduce this bug are: build apk on new architecture and perform basic video operaions.

Can you please provide a repository with a sample app ?

Can you please provide a repository with a sample app ?

Ok , will provide in the weekend

I used basic sample on new arch to reproduce bug but couldn't until i disable cache first time. Btw i am not using cache in my project where i am facing issue.  Here is the video...
https://github.com/user-attachments/assets/c0b810d5-cb83-4589-a1b3-78e5a8444dd3

@mkbhdana I am not sure to understand. you mean that unable or disable caching restart playback ?
If that is your point, I know it, I will move cache configuration into source property (we need to configure cache before starting the playback)

@mkbhdana I am not sure to understand. you mean that unable or disable caching restart playback ? If that is your point, I know it, I will move cache configuration into source property (we need to configure cache before starting the playback)

on new arch in my project (**i don't use cache) i faced issue of restart playback on actions like play, pause that's my issue which i logged here.
***In order to provide repo as asked i used basic example  on new arch but, i faced no issue for what i logged until i found that cache disabling once can reproduce my logged bug.

@mkbhdana I don't think this is an issue with react native video... Please clean your same (remove all props on rnv), then ensure the source does not change and check if it fixes the issue... As you are the only one to have the issue I suspect an issue on your project...

@mkbhdana I don't think this is an issue with react native video... Please clean your same (remove all props on rnv), then ensure the source does not change and check if it fixes the issue... As you are the only one to have the issue I suspect an issue on your project...

yeah you are correct, when i removed enable disable cache functionlity in basic it works well, after that i debug my project again and i see removing bufferConfig resolves problem for me as temp fix. I am using flashlist and react native paper i suspect these two can be a problem, don't know exact reason.

@mkbhdana I don't think this is an issue with react native video... Please clean your same (remove all props on rnv), then ensure the source does not change and check if it fixes the issue... As you are the only one to have the issue I suspect an issue on your project...

yeah you are correct, when i removed enable disable cache functionlity in basic it works well, after that i debug my project again and i see removing bufferConfig resolves problem for me as temp fix. I am using flashlist and react native paper i suspect these two can be a problem, don't know exact reason.

Yep, changing the value of bufferConfig restarts playback, I think it is your issue. It cannot be changed for now, as I said, it will be moved into source property soon !


How to user wheelnav.js to create sub menu?

Hello,everyone,
I want to create sub-menu,is there hava some examples or API document?
Thank a lot.

Hi @deadliving
Basically the sub-menu is two wheelnav on each other.
You can find more information here: http://wheelnavjs.softwaretailoring.net/documentation/core.html#divMultipleWheel


Bootstrap 5 conflict

This style from bootstrap is conflicting with toasty
.toast:not(.showing):not(.show) {
opacity: 0;
}

I solved the problem for myself by redefining this css class .toast:not(.show)
It was:
.toast:not(.show) {     display: none }
Changed to:
.toast:not(.show) {     display: block; }


Add loadbalancer support

This PR adds support for loadbalancing across a group of endpoints that
share the same service configuration as passed in by
OptionService. The loadbalancer is implemented using ipvs with just
round robin scheduling supported for now.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM

LGTM

Gelivable!