Possible to change icon color for summernote

Everything working great but, wondering if simple way to change the svg icon color via css?
I am using a custom theme and happens to be black. The pencil and other icons are also black...
All other icons in summernote are now white but the libreicons are black making them invisble.
Thanks in advance.
Woody

Try using fill:<color>;, you can also use fill:currentColor; which will make the icon take on the color of it's parent element. I'm not sure if this works if the icon is pulled in via CSS as a background.

Thanks for input. I had already tried all the normal like fill:white, fill:#ffffff and fill:currentcolor, sorry, should have mentioned that.
Only thing I could come up with is background-color: white;
Not a perfect solution but prevents me from removing altogether.
Cheers

Yeah, I think that's a limitation of how SVG's work this way with CSS.
If the SVG were able to be inline, then it wouldn't matter. I haven't worked out a way to do so with Summernote, but in LibreCMS I have them injected into the page using PHP, which reads the SVG file into the document, which then allows changing the icons colours, and so on..
I'm wondering now, if there may be a function within Summernote that builds the toolbar, and if it can be overridden to change it's function to inject the SVG files, and in turn allows us to manipulate them further.
goes off digging through the Summernote code

Actually, if I can work that out, it will fix another issue I've been having with loading SVG through CSS. Sometimes the Icons don't appear in chrome in the toolbar.

Well, think you have done an excellent job and issues are very minor:)
I did notice that when using chrome, icons sometime fail to appear.  I have gotten so use to chrome quirks did not mention it.
For now using the background-color: <color>; works for me.
Thanks much.

Cheers, for the kind words.
I'll keep working on finding solutions though, as the Chrome bug annoys me at times, lol.

Have been scratching my head why chrome is so flaky with svg icons. Ran across this and it might help you:
https://bugs.chromium.org/p/chromium/issues/detail?id=580809

Looks like some sort of Cache issue from what I can tell. Though their test is loading the SVG through an element in the pages, we're loading the SVG via the background in CSS. Not sure if it's exactly the same, but seems to produce a similar issue.


Create new Rollbar wrappers

Do not merge before https://github.com/CartoDB/cartodb/pull/6779
Closes #6778
This is a work in progress, here to discuss over code. This creates a new wrapper function CartoDB.log that allows:

Report exceptions and/or messages. When both are specified, the exception shows up in Rollbar as <ExceptionClassName>: <message>, and the detail view shows the stacktrace.
Specify logging levels: "critical", "error", "warning", "info", "debug", "ignore"
Automatically adds person and request data. Person data can be overridden by passing the user parameter (for retrocompatibility). The same could be done for request but it does not seem to be any place in the code where request is anything other than current_request

The old wrappers have been rewritten to call this new one, to have a single point of access to the logging API (except for all Rollbar.* calls in the code). They behave exactly as before except for:

More context data is added when available (actually a consequence of new rollbar gem)
If specifying both message and exception to report_exception. Before, only the message was reported and the exception only showed in extra data. After, it will show the exception class and message in the listing, and the stacktrace in details.

cc @juanignaciosl @gfiorav

Looks great. I think that some places are passing user inside extra_options (or similar arguments) and that user won't be passed to Rollbar person, but I'm not 100% sure.
I've added a couple of comments as well.
Is there a visible difference within old and new Rollbar traces with this code? If it is, some links with old and new examples would be great.

Hey, sorry for the delay, I just read this.
Super luxurious to have this and it looks great, thanks :)

I think that some places are passing user inside extra_options (or similar arguments) and that user won't be passed to Rollbar person, but I'm not 100% sure.

It works with the new wrapper. The function calls with **additional_data convert the hash to keyword arguments, and the user is correctly detected and reported.
I have also added more info to console logging and added more info about the user object to rollbar reports. This works when the user is manually specified. If the user is not given, Rollbar automatically (and very magically) adds it to the report, but only the id, username and email fields.
I tried to imitate what Rollbar does so we could have the user object in all reports, but I don't think it's worth it. It adds too much complexity and metaprogramming and we can always pass the user object when we need it.
cc @juanignaciosl

:+1: :sparkles:

Another thing I'll add is to remove all the Rollbar calls in the code: #6611

Retest this, please

Make sure to retest this after deploying new rollbar gem to production.

Try to add server (rails) to this.

Retest this, please

Okay, I think this is ready to merge (pending tests after updating this branch to master). One last quick CR please @juanignaciosl

I added a stack trace to reports without one (only messages). I also added some debugging information in case sending the report fails (see https://rollbar.com/vizzuality/CartoDB/items/15914/).

Ping me again after the changes. I'll really love the CartoDB::Log module ^_^

I've moved the new logging functions to Carto::Logger (Carto::Log is the import log model). The new calls look like: Carto::Logger.error(exception: e, message: 'some message', extra: 'wadus')
cc @juanignaciosl

I've dropped a few comments. Nothing major, take into account what you consider and :+1:


Add actions workflow

Adds a GitHub Actions workflow to run the test suite on any push

@michaelklishin this should also fix the errors in Concourse CI

Thank you!


Object is not a constructor (evaluating 'new Croppie')

Hi,
I'm using Croppie via npm. In one of my files, I'm using require to load Croppie:
var Croppie = require('croppie');
Then I'm trying to create an Croppie instance:
self.croppie = new Croppie(document.getElementById('croppie'));
But I get the following error when I run my app:
Object is not a constructor (evaluating 'new Croppie')
Any ideas on what I'm doing wrong?

Look like https://github.com/Foliotek/Croppie/pull/71/files should address the npm issue.  I vote for this one.

#71 is part of the latest npm release now, thanks for interest.


Background Component discards children passed to it

Fixed by https://github.com/sircfenner/StudioComponents/pull/4


Random forest

Work in progress
The following pull request adds, fixes, and/or modifies:
Adding notebook to do a naive random forest without optimization
New requirements:

seaborn

Still to-do:

[x] add readme with results
[x] add futher steps plan
[x] add analysis pipeline step

I performed the following prior to filing this pull request:

[x] Tested that my change does not break the analysis pipeline
[x] Ran a linter through my code
[x] Update environment dependencies if my code introduces a new package

@mth-gsk and @gwaygenomics. I now done with the first version of random forest classification. Could you review it? Specially the results and future steps in the README.md

I think this PR is in need of a quick rebase! There is some nice rebase documentation here.
Here are some steps that might help:
# Figure out the commit hash at the upstream master branch
# (Make sure upstream is configured as a remote branch pointed to cytodata/single-cell-classifier)
git merge-base random_forest upstream/master

# Copy and paste the hash output
git rebase -i <$HASH>

This will send you into your text editor.
From here, you can edit commits
We should drop the following commits since they are duplicates of #12:

091a31e2b37771d457a719925a14c4f3745a3135 (this commit also includes training and test data before processing, which we currently have in the .gitignore 2c5589fd3caf91b72b42fac0b043be994ffdfc75)
4878294f6e7167bb9f454fabddd9730856c2ada3
c28018e6395381c3c6ce21bd2bebdd550a4e7784
d329fb629ba203f71dd0c55f916f0963d21ad749

After the rebase is complete (make sure not to delete commits you actually want!) run:
# force push (really important not to delete stuff you want b/c this rewrites history)
git push -f

A couple of other comments before merging:

Lets call this module 3.train-ebimage or something like that. I think 3.random-forest is too specific - we should leave room for other models (especially since random forests will only serve as an important baseline)
Make sure to restart kernel and run all in the jupyter notebook files. The notebooks should, ideally, all start at execution cell 1 and be executed sequentially. Doing this ensures that no variables were mistakenly referred to out of order. This is a big problem for future users.

@gwaygenomics  why the rebase? This branch is completely up to data with the current master branch

@gwaygenomics why the rebase? This branch is completely up to data with the current master branch

A couple of files are still included in this PR that might not belong.

Do you think we should have 2.process-data/data/test.tsv.gz and 2.process-data/data/train.tsv.gz?

I can totally see an argument to include them (they include all EBimage features and not many more files will be bigger).
If you think they should be included, please remove their mention in the .gitignore.

The change in 2.process-data/process-data-pipeline.sh should be removed.

These two additional changes should be all that's needed before merging.
Rebasing is one way to do this. It is definitely harder to do, but makes things easier to view later on. A quick (and definitely acceptable) alternative is to:

Remove files and commit (git rm 2.process-data/data/test.tsv.gz) or commit an updated .gitignore
change 2.process-data/process-data-pipeline.sh back to 100755 with:

chmod +x 2.process-data/process-data-pipeline.sh`

and then commit

@gwaygenomics I have solved the changes in 2.process_data the ugly way. I will look in to rebasing some day. Seems a bit complicated for just making the commits pretty


Do not create issue to upgrade on start.spring.io until the bits are available

A release process created an issue (https://github.com/spring-io/start.spring.io/issues/259) 12h ago and the bits aren't available.
I think it's confusing that an automated tool creates an upgrade issue for something that hasn't been validated as being available.
The sync to central could wait and check that the bits are available and create the issue once this has been validated.

this has been disabled


Display deprecated label when @[Deprecated] is used

Depends on #7652 (marked as draft until merged)
The last commit of the PR adds support of the doc generator tool to understand the @[Deprecated] and emit the same label that is currently emitted when a # DEPRECATED: ... comment is found.
Even before this PR the labels are only emitted for methods. But the implementation will be ready to handle them once other annotations are preserved by the parser/compiler.
Show me a sample (with screenshot)
Given the following code:
module FOO
  # DEPRECATED: Use `Bar` instead1
  @[Deprecated("Use `Bar` instead2", "sdfs")]
  class Foo
    # DEPRECATED: Use `VAL_B` instead1
    @[Deprecated("Use `VAL_B` instead2")]
    VAL_A = 10
    VAL_B = 20

    # DEPRECATED: Use `#bar` instead1
    @[Deprecated("Use `#bar` instead2")]
    def foo
    end

    # DEPRECATED
    @[Deprecated]
    def foo2
    end

    def bar
    end

    # DEPRECATED: Use `#qux` instead1
    @[Deprecated("Use `#qux` instead2")]
    macro baz
    end

    macro qux
    end
  end

  class Bar
  end
end

This is the generated output:

Yes @straight-shoota I agree. It's cheap.
Merging this will mean that the time deprecation does not need to be in the comments 🚀


[BIOMAGE-1363] Add api cleanup

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-1363
Link to staging deployment URL
Links to any Pull Requests related to this
Anything else the reviewers should know about the changes here
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[ ] Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

Created a new bucket in iac, this PR is for the management needs to do of it (just deleting the experiment's file in s3 when the exepriment is deleted). As can be seen in the design docs, all of the rest of the interaction with the bucket takes place in the pipeline

Looks good. Consider changing the file name to logger and default export to initLogger?

I don't know, I feel like it is both more representative and easier to find in the project if the file matches the default exported .
About changing function name, I don't feel like getLogger is wrong, regardless of whether the logger is initialized or not, what matters to someone using it is that they get the logger.
If in the future we changed to use some already initialized logger, initLogger would be wrong but getLogger would still be right (which means it hepls with decoupling).


style: add trailling comma option

Adds trailling commas to generated codemods/index.js file. This should align the style with the Biome configuration where trailing commas are enabled by default.
I noticed this small issue when I was resolving conflicts and I had to manually add the comma.

Nice, thanks :)


add support FutureValue for reduce

TODO:

[ ] Add details
[ ] Why is it failing with complicated types from thrust?

Thanks for working on this! Let me know when you're ready for a review or if you have any questions.
cc: @zasdfgbnm

Hey Allison,
Sorry this went under my radar. Will get on it in the coming week or two. (I think I will have a few doubts, will ping you once I have clarity). Thanks!

No worries -- there's no rush on this from our end.


Live stream freeze all time with reolink cameras

I cleared my browser cache and i used the latest version of Home Assistant.

Card diagnostic information:
card_version: 6.0.3
browser: >-
  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101
  Firefox/133.0
date: 2024-12-11T16:21:19.199Z
lang: fr
timezone: Europe/Paris
git:
  hash: 47fdfbc
  build_date: Wed, 11 Dec 2024 03:36:17 GMT
  commit_date: Tue, 10 Dec 2024 19:35:09 -0800
ha_version: 2024.12.2
integrations:
  reolink:
    detected: true
  frigate:
    detected: false
  hass_web_proxy:
    detected: false
  motioneye:
    detected: true
config:
  type: custom:frigate-card
  cameras:
    - camera_entity: camera.e1_zoom_salon_fluent
      title: Salon
      live_provider: ha
      engine: reolink
      dependencies:
        cameras:
          - camera.e1_zoom_salon_clair
      capabilities:
        disable_except: []
      ptz:
        presets:
          home:
            action: perform-action
            perform_action: button.press
            target:
              entity_id: button.e1_zoom_salon_guard_go_to
        service: button.press
        data_left_start:
          entity_id: button.e1_zoom_salon_ptz_gauche
        data_left_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
        data_right_start:
          entity_id: button.e1_zoom_salon_ptz_droit
        data_right_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
        data_up_start:
          entity_id: button.e1_zoom_salon_ptz_haut
        data_up_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
        data_down_start:
          entity_id: button.e1_zoom_salon_ptz_bas
        data_down_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
        data_zoom_in_start:
          entity_id: button.e1_zoom_salon_ptz_zoom_avant
        data_zoom_in_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
        data_zoom_out_start:
          entity_id: button.e1_zoom_salon_ptz_zoom_arriere
        data_zoom_out_stop:
          entity_id: button.e1_zoom_salon_arret_ptz
    - camera_entity: camera.e1_zoom_salon_clair
      live_provider: ha
      engine: reolink
      capabilities:
        disable_except:
          - substream
    - camera_entity: camera.e1_zoom_bureau_fluent
      title: Bureau
      live_provider: ha
      engine: reolink
      dependencies:
        cameras:
          - camera.e1_zoom_bureau_clair
      capabilities:
        disable_except: []
      ptz:
        presets:
          home:
            action: perform-action
            perform_action: button.press
            target:
              entity_id: button.e1_zoom_bureau_guard_go_to
        service: button.press
        data_left_start:
          entity_id: button.e1_zoom_bureau_ptz_gauche
        data_left_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
        data_right_start:
          entity_id: button.e1_zoom_bureau_ptz_droit
        data_right_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
        data_up_start:
          entity_id: button.e1_zoom_bureau_ptz_haut
        data_up_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
        data_down_start:
          entity_id: button.e1_zoom_bureau_ptz_bas
        data_down_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
        data_zoom_in_start:
          entity_id: button.e1_zoom_bureau_ptz_zoom_avant
        data_zoom_in_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
        data_zoom_out_start:
          entity_id: button.e1_zoom_bureau_ptz_zoom_arriere
        data_zoom_out_stop:
          entity_id: button.e1_zoom_bureau_arret_ptz
    - camera_entity: camera.e1_zoom_bureau_clair
      live_provider: ha
      engine: reolink
      capabilities:
        disable_except:
          - substream
  view:
    default: live
  live:
    preload: false
  menu:
    style: overlay
    buttons:
      microphone:
        enabled: true
      mute:
        enabled: true
      screenshot:
        enabled: true
      recordings:
        enabled: false
      frigate:
        enabled: true
      cameras:
        enabled: true
      substreams:
        enabled: true
        icon: mdi:high-definition
      live:
        enabled: true
      clips:
        enabled: true
      media_player:
        enabled: false
      image:
        enabled: false
      download:
        enabled: false
      ptz_controls:
        enabled: true
      camera_ui:
        enabled: true
      timeline:
        enabled: false
      snapshots:
        enabled: false
      expand:
        enabled: false
      ptz_home:
        enabled: false
      play:
        enabled: false

Description of problem:
Since version 6.0.3, my live freeze every time even in low quality.
In this version, I can also look into the past, as I have the impression that the card generates a buffer.
Here a GIF  showing the problem :

Additional information:
I use reolink E1 with Home Assistant integration (i'm not use frigate).
I rollback in version 6.0.2 and problem gone.

@Gamso Please use the new issue template, include at least the diagnostic information. I would be curious to see if your Home Assistant has been updated to the very latest.

Ho sorry for that i just edit my first message. Tell me if you need further informations.

If i watch the steam without the card i don't have the problem like the version 6.0.2.

If i watch the steam without the card i don't have the problem like the version 6.0.2.

Sorry, I cannot explain why this would be the case. The code between both HA, and the card with the ha live provider, is extremely similar (and v6.0.3 actually made it more similar). In general, it looks a bit like your stream might be HLS instead of WebRTC (I've seen buffering like that before with HLS streams), but I cannot explain why that would be.
Is there anything unusual in your Javascript console (F12 in Chrome), or in your HA logs?  ;-)

Yes i already restart HA. And yes with the version 6.0.3 i see HLS displayed !

And here some error show in console :

And yes with the version 6.0.3 i see HLS displayed !

Aha, ok.

And here some error show in console :

Most of them look like other ecards, although the lit-html one might be related. Seems like it's complaining about a backend error. Anything in your Home Assistant logs at the same time?

I just try and no any log about that.

OK. Sorry, I have no more ideas. Lets see if anyone else runs into 6.0.3 not working, but 6.0.2 working.

I just try and no any log about that.

Just to confirm: Are there any errors at all from Home Assistant when you open the stream in the card?

I just try again and no 0 logs.
if it helps, the browser console for version 6.0.3 :

And for the version 6.0.2 :

@copa80 Is the behavior the same for you? Works with v6.0.2?

The Problem is still the same. If I run the entity Inseln without frigate card it works fluently. In the Card there is only interruption and freezing stream. Even beweist 6.0.8. does Not help. All was fine before 6.0.0
Anything Must have changed. 10 cams all same freeze. No logs that could help.

I am wondering if your videos are somehow ending up in HLS, which might make this the same problem as #1755 .

Probably yes. Since v6.0.3 HLS is visible and network frame show a lot of request for this protocole.

Try v6.0.11, I have a suspicion/hope it will help those of you impacted -- but I'm not sure!

Seems to work now!

i confirm too. Work perfectly again !


country_bias parameter to Pelias is misleading

Hi! Pelias maintainer here.
The Pelias geocoder class in geopy includes a country_bias parameter on the search function:
https://github.com/geopy/geopy/blob/af0eedcfeb4e3eec88f19e2f822e7f14ac3468eb/geopy/geocoders/pelias.py#L112
However, Pelias only includes the boundary.country parameter, which is a hard filter. It will only ever return results from the countries listed in the parameter.
bias implies it might be a soft filter, that would include results from other countries under certain circumstances, so in this case it might be a bit misleading.
I'm happy to open a PR to update the documentation, but should we consider renaming the parameter? What's the process for that? Let me know if I can help with some PRs. Thanks!

Hi, this is a very good catch, thank you! I certainly agree that this naming is misleading given that the filter is hard.
I have added a new argument countries accepting a python list of strings -- the country names, and have added a deprecation warning for country_bias suggesting to use the countries arg instead.
Thank you so much for linking the relevant Pelias documentation section which made the change easier for me!


Delete Request is no longer been called

I updated the plugin and Delete Request is no longer been called when I remove the image?
deleteScript: '{!! action('XXX\JoyController@putSomeMethod') !!}',
deleteMethod: 'PUT',
fileDeleteOptions: {
_token: "{!! Session::getToken() !!}",
id : 1
},

you need to use jquery options, such as:
                deleteScript: '/images/delete',
                deleteMethod: 'POST',
                fileDeleteOptions: {
                    headers: {
                        'X-CSRF-TOKEN': Cookies.get('X-CSRF-Token')
                    }

Did you read the wiki about that new configuration https://github.com/orthes/medium-editor-insert-plugin/wiki/v2.x-Configuration ?

@j0k3r @jackyzhai I have read the docs, and added the configuration above as @jackyzhai mentioned, but request has not been called.

@ideadx it seems to work on my machine. can u post ur code here?

here is a code:
 deleteScript: '/post/method',
                            deleteMethod: 'POST',
                            fileDeleteOptions: {
                                headers: {
                                    'X-CSRF-TOKEN':  "{!! Session::getToken() !!}"
                                }

                            },

Is there a way to log when method is running or response comes back?
similar to
uploadCompleted: function ($el, data) {
                                console.log(data.result)
                            }

@ideadx idk. I think j0k3r would have better info.
just curious. what syntax is this?
{!! Session::getToken() !!}

@jackyzhai Thats  Laravel Blade (a php framework)

@j0k3r any idea to console log?

I'll have a look

Everything works great on my side.
I've tested on the example files (from this repo) with that config:
$(function () {
    $('.editable').mediumInsert({
        editor: editor,
        addons: {
            images: {
                deleteScript: 'delete.php',
                deleteMethod: 'POST',
                fileDeleteOptions: {
                    headers: {
                        'X-CSRF-TOKEN':  "TOKEN"
                    }
                },
                styles: {
                    slideshow: {
                        label: '',
                        added: function ($el) {
                            $el
                                .data('cycle-center-vert', true)
                                .cycle({
                                    slides: 'figure'
                                });
                        },
                        removed: function ($el) {
                            $el.cycle('destroy');
                        }
                    }
                },
                actions: false
            }
        }
    });
});

When I delete an image the ajax request is well sent with the additional token header:

Since it's an ajax request you might be able to debug it from your browser.

Here is my full code:
https://gist.github.com/ideadx/143b768d97ba4ef5f96d
Here is file upload:

when I remove this files (using backspace or delete), image get removed from content but no requests get fired.

I've no idea why this doesn't work for u. J0k3r may have better info.
However, one thing you can do is to set up a br here and see what's wrong. It's basically just jquery ajax request.
https://github.com/orthes/medium-editor-insert-plugin/blob/adb9e9d7e3a0d0af582c33a3f5e698c3e4f95198/dist/js/medium-editor-insert-plugin.js#L1923

@ideadx did you try to remove all option related to delete to use default one and see if the ajax request is launched?

sorry I double clicked on the wrong place

@j0k3r I have try removing all default options but the issue is still the same!

I tried 4 different requests

1. Set default options
fileDeleteOptions: {
    headers: {
         ''X-CSRF-TOKEN':  "TOKEN"
    }
},

2. Remove token option
fileDeleteOptions: {
    headers: {
         // 'X-CSRF-TOKEN':  "TOKEN"
    }
},

3.
fileDeleteOptions: {
    //headers: {
         // 'X-CSRF-TOKEN':  "TOKEN"
    //}
},

4.
//fileDeleteOptions: {
//    headers: {
         // 'X-CSRF-TOKEN':  "TOKEN"
  //  }
//},

```

One last idea, what happen if you try to delete an image that is already in the dom? I mean an image that you didn't just uploaded.

Same issue. Let's say I upload images, save the content and try to remove
it, nothing happens.
On 22 Jan 2016 11:06 PM, "Jeremy Benoist"<EMAIL_ADDRESS>wrote:

One last idea, what happen if you try to delete an image that is already
in the dom? I mean an image that you didn't just uploaded.
—
Reply to this email directly or view it on GitHub
https://github.com/orthes/medium-editor-insert-plugin/issues/265#issuecomment-173909385
.

I'm out of idea.
:wave:  @orthes, we need your help

@j0k3r Which version of jQuery you are using?  I am using: 2.1.4

@orthes

@ideadx When you say that you use backspace or delete, do you mean that you select image first and then press one of those two buttons? Or do you place caret after the image and then press backspace? Because it is a known issue that deleting image together with text doesn't trigger the plugin's delete function (#228).
But if you're selecting an image by clicking on it first, then it should work. I tried it myself and it also works for me.
The one last thing that remains here to do is to dive into the code and find out where it fails for you. Is keydown event triggered? Is Images.prototype.removeImage() called? Is Images.prototype.deleteFile() called after that?

OMG!
I was doing  Second: place caret after the image and then press backspace to delete image which doesn't work.
but I just selected image and try to delete and event did trigger. Oh Lorde....

@j0k3r @orthes

I think thats a critical issues (228). When you writing content  after the image and then press backspace to delete image is a natural scenario.

@j0k3r @jackyzhai @orthes Thanks boys.


Mimic bootstrap events for Collapse component

Fixes #81
Changes proposed in this pull request:

component emit show, shown, hide and hidden event like bootstrap component does.
update documentation accordingly.

@wxsms

Thanks!


Generic not widen when union and conditional are involved.

Bug Report
I've read #10676, but I'm failing to understand why there is no consistent widening accross the 3 examples mentioned below.
🔎 Search Terms

literal
widening
union
generics

🕗 Version & Regression Information
AFAIK not a regression.
⏯ Playground Link
Playground link with relevant code
💻 Code

class FormControl<T> {
  constructor(t:T extends undefined ? never : T) {}
}
const a = new FormControl('');
//   ^? FormControl<string>

class FormControl2<T> {
  constructor(t:T|string) {}
}
const b = new FormControl2("");
//    ^? FormControl<string>

class FormControl3<T> {
  constructor(t:T extends undefined ? never : (T|string)) {}
}
const c = new FormControl3("");
//    ^? FormControl<"">

🙁 Actual behavior
Non consistant behaviour between use-cases.
🙂 Expected behavior
Consistent behaviour.

The issue here is that the relatively simple check in isTypeParameterAtTopLevel doesn't recurse into conditional types since that would require guarding against infinite recursion. It would be pretty simple to at least allow a couple of levels of nesting.


make uninstall doesn't remove all files

/share/applications/i3-gnome-flashback.desktop is not removed by make uninstall

Thanks for the report! Fixed in c735695.


doc: OVN monitoring introduction

JIRA:OSPC-552

This attempts to provide an operational introduction to the Prometheus OVN monitoring and related Grafana dashboards with links to the upstream documentation and a brief elaboration of each dashboard.


machine.RTC().datetime for ESP8266 (wemos D1) not compatible

It seems that the library is not working correctly with the machine.RTC().datetime as a callback function in case the hardware is a wemos D1 mini board (ESP8266) and using the micropython board for the ESP8266 LOLIN_D1_MINI board.
The micropython doc states that the subsconds field for RTC().datetime is hardware dependent.
For the ESP8266 I observerd that the subseconds must be milli seconds (e.g. <1000). In case micro seconds are used, this is interpreted as seconds/minutes, ..., which sets the RTC to a completely false time during a rtc_sync
The same applies when applying drift_compensate. This can be fixed by defining the call back function as follows:
def datetime_callback(dt=None):
        import machine
        if (dt):
            # dt[7] are subseconds. In ntp these are us, for ESP8266 ms must be used
            dt = dt[0:7] + (dt[7]//1000,)
            machine.RTC().datetime(dt)
            return
        return machine.RTC().datetime()

I do not know, whether a genic fix in the ntp source code can be implemented?

Hi,
it's important to clarify that the callback function is designed to be user-defined and is not inherently a part of the library. This approach is intentional to ensure the library's compatibility with a wide range of hardware. The primary role of the callback function is to serve as a bridge between the specific RTC chip used in your hardware and the micropython-ntp library. This design choice allows for the micropython-ntp to remain chip-agnostic, providing broad compatibility and flexibility across various hardware platforms. For instance, you can create one callback function to synchronize a DS3231 chip, and another to sync the microcontroller's built-in RTC.
To address this, I will update the README file to include a note about this specific behavior on ESP8266 boards.
Thank you for highlighting this aspect.

Hi,
thanks for your quick reply:

it's important to clarify that the callback function is designed to be user-defined and is not inherently a part of the library.

Yes, I understand. Updating the README file would be nice and the issue could be closed.
My idea was to handle this a bit like the EPOCH case, where we have different implementions:
Defining constants for
e.g.
SUBSECONDSDIVIDER_MS = 1000
SUBSECONDSDIVIDER_US = 1000_000 # Could be the default for cls._subseconddivder

and using
cls._datetime((lt[0], lt[1], lt[2], lt[6] + 1, lt[3], lt[4], lt[5], ntp_us % cls._subseconddivider))

would allow to use the micropython native machine.RTC().datetime function for any board, provided the  _subseconddivder is set correctly.
IMHO this might be a bit more userfriendly than writing a wrapper for the native micropython function if using a wemos D1 mini board :-)
But I'm of course fine with updating the doc.
... and thanks for sharing this nice library.

I like you idea. That would make the library more generic but this change could introduce additional complexity.
I was wondering if using a decorator can provide a neat way of adding this new feature while keeping it optional and unobtrusive for users who don’t require it.

Yes, this sounds good.
Do you have a decorator e.g. use_subseconds_ms defind as below or similar in mind?
# This can be part of ntp.py
def use_subseconds_ms(func):
    def inner(dt=None):
        if (dt):
            # dt[7] are subseconds. In ntp these are us, for ESP8266 ms must be used
            dt = dt[0:7] + (dt[7]//1000,)
            func(dt)
            return
        dt = func(dt)
        return dt[0:7] + (dt[7]*1000,)
    return inner

# This would be in the user code
@use_subseconds_ms
def datetime_callback(dt=None):
    import machine
    return machine.RTC().datetime(dt)

# or for a native function
cb = use_subseconds(machine.RTC().datetime)

I have not fully tested this :-(

May I ask you to test this decorator:
SUBSECOND_PRECISION_SEC = const(1000_000)
SUBSECOND_PRECISION_MS = const(1000)
SUBSECOND_PRECISION_US = const(1)

def subsecond_precision(precision):
    if precision not in (SUBSECOND_PRECISION_SEC, SUBSECOND_PRECISION_MS, SUBSECOND_PRECISION_US):
        raise ValueError('Invalid parameter: precision={} must be one of SUBSECOND_PRECISION_SEC, SUBSECOND_PRECISION_MS, SUBSECOND_PRECISION_US'.format(precision))
    def decorator(func):
        def inner(dt = None):
            if dt:
                func(dt[0:7] + (dt[7] // precision,))
                return
            dt = func(dt)
            return dt[0:7] + (dt[7] * precision,)

        return inner

    return decorator

@subsecond_precision(SUBSECOND_PRECISION_MS)
def datetime_callback(dt=None):
    import machine
    return machine.RTC().datetime(dt)

Thanks. I've tested and corrected the code:
The following decorator and datetime_callback work for me:
def subsecond_precision(precision):
    if precision not in (SUBSECOND_PRECISION_SEC, SUBSECOND_PRECISION_MS, SUBSECOND_PRECISION_US):
        raise ValueError('Invalid parameter: precision={} must be one of SUBSECOND_PRECISION_SEC, SUBSECOND_PRECISION_MS, SUBSECOND_PRECISION_US'.format(precision))
    def decorator(func):
        def inner(*args):
            if (len(args) == 1):
                dt = args[0]
                func(dt[0:7] + (dt[7] // precision,))
                return
            dt = func()
            return dt[0:7] + (dt[7] * precision,)
        return inner
    return decorator

@subsecond_precision(SUBSECOND_PRECISION_MS)
def datetime_callback(*dt):
    import machine
    return machine.RTC().datetime(*dt)

NB: We need a *args, since e.g. machine.RTC().datetime(None) gives an error instead of returning the actual tuple. (My mistake in the code above. Sorry)

Hi,
I've pushed a new branch issue-7. May I ask you to test it and give me a feedback, so I can merge it into the main.
I've modified the set_datetime_callback to accept precision argument. This argument is the precision the callback works with.
Now you shall be able to do:
import machine
Ntp.set_datetime_callback(machine.RTC().datetime, Ntp.SUBSECOND_PRECISION_MS)

I think this is the most user friendly approach. No custom callbacks. Backward compatible.

Hi,
thanks a lot. I've tested the new code from the branch and it works as expected.
I agree that this is

the most user friendly approach. No custom callbacks. Backward compatible.

Thanks for implementing this.
IMHO this can be merged.

Merged.
Thank you!


Improve test coverage for ci models

Problably because I wrote some yesterday and the other today :D Let me change them all to the same format


Create Itemreminders plugin

This plugin takes ZoneID,ItemID pairs in the config and sends constant notifications if the player is in that zone without that item. It is intended to help you remember to take items into certain bosses and raids.

Rename the file in this pr please

How do I do that? Delete the commit from the other repo?

How do I do that? Not sure what you mean

How do I do that? Not sure what you mean

The exact same way to changed it from repositoryURL to repositoryurl, change it to item-reminders


About Parallel Axis feature request

What problem does this feature solve?
I'm a student and I'm currently using Echarts to develop my assignment. I appreciate those build-in functions. They are really helpful.
Thank you.
While I'm using the Parallel Axis, I found it has a brush feature and axisareaselected API event, but the axis cannot display the two boundary values (edge value) of the selected area. Besides, if I narrow the interval between each axis label, that's still hard to see the values on the axis. So, I'm thinking it would be better to have a feature to display the boundary values or even the gap value of a selected area. That will also help users to elaborate on the selected area, for example, there are how many lines pass through the value between 0.8 to 1.2.
Plus because parallel axis contains a lot of data and its corresponding lines, it is really hard to find which line is from which data. It would be better to show the name of the line when mouse hovers on it.

What does the proposed API look like?
It would be better to add a bit more features in event.axisareaselected or in the brush or even axisPointer.
var boundaryValue[];
chart.on('axisareaselected', function (event) {
       boundaryValue = event.intervals;
});

option = {
     parallel:{
         parallelAxisDefault: {
               boundaryValue: boundaryValue[], // to display the edge values of a selected area.
               // or boundaryValue1: boundaryValue[0],
               // boundaryValue2: boundaryValue[1]
}
}
};

Parallel tooltip feature request is at #9418 .
I don't think it's possible to show the distance between selected gap because there is no such feature as selecting a parallel graph. So does the tooltip feature fulfills your need?

Thank you for the reply. If the tooltip feature worked, it would be helpful. Do you mean the feature is currently available already? or are you still working on it?

No, it's not available yet.
If this issue is about parallel tooltip only, I think I can put #9418 to a higher priority.

Yes, please. Parallel tooltip can still be helpful. Thanks.


Use lineax for tridiagonal solve

Resolves #7

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.80%. Comparing base (1047afe) to head (6fb6495).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   97.79%   97.80%   +0.01%
==========================================
  Files           4        4
  Lines         635      639       +4
==========================================
+ Hits          621      625       +4
  Misses         14       14

Files
Coverage Δ

interpax/_spline.py
98.10% <100.00%> (+0.01%)
:arrow_up:


Pushing blocks with non-swap enabled node

Summary

I connect my node to the staging cluster. The config is:

config/staging_no_swap.yaml
debug-api-enable: true
debug-api-addr: :6061
api-addr: :8081
p2p-addr: :7071
swap-enable: false
data-dir: /tmp/bee/staging_no_swap
verbosity: trace
network-id: 2
bootnode: /dnsaddr/bootnode.staging.ethswarm.org
swap-endpoint: https://rpc.slock.it/goerli
welcome-message: "Welcome from Eknir without SWAP"

The node is splitting, but pushing doesn't work. Initially, only 3 chunks are pushed. After about 1 minute 600 additional chunks are pushed, now, it is already blocked for a long time at 600 chunks.

Steps to reproduce

Start node with provided config
It stops after a while

Expected behavior

It looks to me that this happened because accounting doesn't allow me to cross thresholds. I would expect at least a message (in the console), saying that it cannot continue pushing because I cannot write a cheque.
Actual behavior

@metacertain , could you try to reproduce this for me, add any additional information and then assign it to low priority?

Tried this again, with another node (config below). I can confirm that it is not because of the --no-swap flag.
debug-api-enable: true
data-dir: /tmp/bee/staging1
verbosity: trace
network-id: 2
bootnode: /dnsaddr/bootnode.staging.ethswarm.org
swap-endpoint: https://rpc.slock.it/goerli
welcome-message: "Welcome from Eknir"

https://app.zenhub.com/files/234530887/794adbe2-831a-467c-a57e-013f25eb2f64/download

Similar behavior was experienced by @wendydv1989 . I asked her to provide:
On a bee node which is just started up (empty --data-dir)

the version of bee
the configuration of the node
a config of the console output (use --verbosity=5 flag)
the exact command used to upload (and any other actions done before upload)
the output from http://localhost:6060/debug/pprof/goroutine?debug=1 (in a file).

@wendydv1989 , if you could all provide this here, that would be great.

This could not be reproduced by @janos (using the files of @wendydv1989).
What could have been the case is that, because you attempt to push multiple times, the tags communicate as if it didn't sync, whereas in fact it didn't attempt to sync, because it knew that it was already pushed before (on a different upload). The root cause on why the content was not retrievable is still under investigation.
@janos is still investigating the original issue (supposed block)

Not reproducible, or already fixed. Closing for now.


feat: navigate to course component from course dates tab

This PR adds support for navigating to the First Component ID, which is available from a block inside Course Dates, to the Course Unit screen.
https://github.com/openedx/openedx-app-ios/assets/5606473/baf1cd75-26c8-4dba-9b6b-ebed8168ebe9
Note: I didn't have write permissions on Umer's fork, so I'm taking over the PR and creating a new PR from the existing PR (https://github.com/openedx/openedx-app-ios/pull/185).
In the new PR, I've created it on the latest develop branch and fixed the case where on every hyperlink click blocks API was being hit.

@rnr You have already approved the old PR that Umer created. It would be nice if you could take a look at it and approve it as well. Thanks

@shafqat-muneer Here is the PR for dates hyperlink, could you please take a look?


Add quantized model download API for Neural Solution

Type of Change
feature
API changed or not: not
Description

add quantization model download api
replace the quantized model path with download link of the response to the submission request
Client downloads zip files(quantized_model.zip) without leaving temporary files on the server

Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
When installing fastapi, it will automatically install and update the strarlette.
zipfile is a built-in Python package.

Please add usage to one of the E2E examples.


Refactor the whole project

Short summary (3-5 sentences) describing the issue.
Recently, I got a lot of requirements, for example

I don't want to expand on certain element
I don't need this operation
I need this ...
etc..

Yes, we can meet all of these by modifying the codes, by adding settings, etc.
However, i'd think maybe it's time to refactor it in the next major release.
Design
I'd like to use the Dependency Injection to allow customer to customize the converting process.
We need figure out the working flow from OData to OpenAPI. The process steps are certain, at each step, we can create a service to work on it.
Services
We need figure out the services used during converting.
for example:

we should have a OData path provider service
we should have a OpenApi path generator service
We should have a convert engine

Extension methods
I think we need
public static IServiceCollection UseOpenApiOData(IServiceCollection services)
{
        services.AddSingleton<IOpenApiODataConverter>(); // converter or generator
        services.AddSingleton<IODataPathProvider>();
        services.AddSingleton<IODataOpenApiPathHandler>();
        services.AddSingleton<IODataOpenApiOperationHandler>();
.....
        service.AddSingleton<ODataOpenApiOptions>();
        return services;
}

Usage

you can create the OpenApiODataConverter instance (normal way)
you can retrieve it from service provider.

IServiceCollection services= new ServiceCollection();
services.UserOpenApiOData();
IServiceProvider sp = services.CreateServiceProvider();
IOpenApiODataConverter converter = sp.GetService<IOpenApiODataConverter>();
...

Advantage

It can be used in the ASP.NET Core pipeline, for example we can create a middleware to generate the OpenAPI description for a OData service.

It can support to customize the converting. For example, we can replace a certain service using customized service.

This library could be useful to us and we also have the need to customize the generation replace services.
However, the way you're describing it sounds more like service locator pattern, which is more commonly considered an anti-pattern.
In my understanding, in pure dependency injection, you would inject the services (usually as constructor parameters), not the service provider. Using the service provider makes it more like service locator. The main drawback of service locator is that it's hard to figure out what other services a class depends on. So if Operation handler depends on Path hander, then it's much more obvious if Operation handler receives IODataOpenApiPathHandler as constructor parameter. Then there can be a separate "activator" or "factory" class which constructs the services, possibly making use of the dependency injection library and service provider.

In general, making substantial breaking changes to the API surface of a library makes it less useful to Microsoft product teams consuming it, who simply can't rewrite their code to consume new, disruptive changes.
This simply stops us from consuming the new version and leaves us stuck on legacy versions.
Unless there is overwhelming new value, we should take the hit that the API surface which exists when a library becomes popular is the API surface for the forseeable future.  The idea that the existence of major versions means it's OK to regularly make breaking change is a fallacy as a consumer.


:package:  update dependencies

Description
update dependencies to latest revision
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

Coverage remained the same at 94.428% when pulling e43dbeea36eef1239db1cb1d808f08aa6115da60 on chore/update-dependencies into 1ca1c9b3f7247ef2ecb230cf74fe6fd1f55abadc on main.


99-com.rules: Update rules for BCM2711 based hardware

Update the rules as per
https://github.com/RPi-Distro/raspberrypi-sys-mods/commit/05cfe136f76677a891a0c77dc91d796913607c07

- What I did
- How I did it

So you mean adding 99-com.rules from https://github.com/agherzan/meta-raspberrypi/blob/master/recipes-core/udev/udev-rules-rpi/99-com.rules in https://github.com/agherzan/meta-raspberrypi/blob/master/recipes-core/udev/udev-rules-rpi.bb as SRC_URI and pull it from there?
What about https://github.com/agherzan/meta-raspberrypi/blob/master/recipes-core/udev/udev-rules-rpi/can.rules ? Would this be installed by the same udev-rules-rpi recipe?

@agherzan you were thinking something along the lines of https://github.com/agherzan/meta-raspberrypi/pull/1185 ?

Exactly. That looks better to me. And maybe in the future split that in its recipe with some deps (to maintain compatibility). So that the rpi udev recipe brings only custom ones and pulls in the raspberry-pi-sys-mods. But for now, this is a good step to avoid any surprises.

Superseded in favor of https://github.com/agherzan/meta-raspberrypi/pull/1185


[Select] Initial highlight sometimes flashes in Safari

Sometimes opening the Select in Safari briefly flashes the initial highlight and removes it until the next mouse move. Can't figure out any specific reproduction steps.
It doesn't happen often though, but I have been seeing this a lot while using the docs normally.
https://github.com/user-attachments/assets/61d69704-7f91-4059-a59b-6ab5019a17ea
Search keywords:

I just noticed this recently as well. Looks like Radix Select also suffers from this issue.


useSWRMutation cancels network request after 10s and is not configurable

Bug report
Description / Observed Behavior
useSWRMutation cancels network requests that has been pending for 10s, and it is not configurable
Expected Behavior
provide a api to allow custom wait time
Repro Steps / Code Example
make a post request with useSWRMutation and wait for 10s

works fine in safari, could be a chrome's issue...?


implement log model

attributes:

(predecessor)
distance (num)
absolute (bool)
recorded (datetime)
full (bool)
quantity (num)

can be split later.

done (raw)


Error Exporting Movies in ANY format after upgrading to 2.8.1

Version: 2.8.1
Build: 2016-06-15 19:06
OS: Windows 10 10.0
JDK: 1.8.0_73 amd64 Oracle Corporation
What is the actual behaviour?
Go to export movies, folder is created if needed, but no files are actually created.
What is the expected behaviour?
Exporting of movies adds index.html and other files based on the template.
Steps to reproduce:
Open up TMM, make sure movies are up to date, add movies if needed.  Select all movies to Export, right click and "Export selected movie(s)".  Select any template and output folder and click "Export".  No files are created, log displays
2016-06-23 10:49:12,373 ERROR [main] o.t.u.movies.dialogs.MovieExporterDialog:181 - Error exporting movies: illegal template
Additional
Have you attached the logfile from the day it happened? Yep
tmm_logs.zip
FYI, In addition, I'm hoping to submit a new export that I've been working on for awhile here and there for your review.

thanks for reporting.
We're already aware of this bug and that will be fixed for the next version.
you can send us the export template to<EMAIL_ADDRESS>for review when it is finished

Great!  Thanks!
On Jun 24, 2016 4:18 AM, "Manuel Laggner"<EMAIL_ADDRESS>wrote:

thanks for reporting.
We're already aware of this bug and that will be fixed for the next
version.
you can send us the export template to<EMAIL_ADDRESS>for
review when it is finished
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tinyMediaManager/tinyMediaManager/issues/48#issuecomment-228285380,
or mute the thread
https://github.com/notifications/unsubscribe/ATLjEqC3tAuC0iRAMFg0Ew6IAVix7CZOks5qO5K3gaJpZM4I85i8
.

FYI - I have now upgraded to <IP_ADDRESS> and still having this same issue?
Thanks,
Jen
On Sat, Jul 2, 2016 at 6:48 AM, Manuel Laggner<EMAIL_ADDRESS>wrote:

Closed #48
https://github.com/tinyMediaManager/tinyMediaManager/issues/48.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tinyMediaManager/tinyMediaManager/issues/48#event-711165840,
or mute the thread
https://github.com/notifications/unsubscribe/ATLjElA8Whgfy8j-q7P41PIErOpEAvDGks5qRkHlgaJpZM4I85i8
.

Do you have any actual log?

Here are all of the logs.
On Fri, Aug 19, 2016 at 1:29 AM, Manuel Laggner<EMAIL_ADDRESS>wrote:

Do you have any actual log?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tinyMediaManager/tinyMediaManager/issues/48#issuecomment-240931537,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATLjEk0UN-xBstbaSOAWon4rEVee-9N9ks5qhT9EgaJpZM4I85i8
.

sorry, no attachments were in your response..
you can also upload it to something like pastebin (only tmm.log is interesting here)

hm, ok.  here is just the tmm.log
On Fri, Aug 19, 2016 at 9:30 AM, Manuel Laggner<EMAIL_ADDRESS>wrote:

sorry, no attachments were in your response..
you can also upload it to something like pastebin (only tmm.log is
interesting here)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tinyMediaManager/tinyMediaManager/issues/48#issuecomment-241018668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATLjElfAVg4Stot6M7i1qqhf7SUp67PZks5qha_pgaJpZM4I85i8
.

Sorry, I was simply responding via my gmail instead of actually logging into github, so try this.
tmm.zip

do you have sufficient permissions to write the export to C:\inetpub\wwwroot\ ?
could you also send me your export template to<EMAIL_ADDRESS>for further analysis?

Ok,  thanks for that.  I had tried setting up the local server and didn't even think about that.  I've now got it back to working again, BUT when I go to export, it doesn't create the include folder and the images folder and all the files that belong in there export to the main directory.  I went ahead and attached the zip of the Mobile Movie Search template I've been working on over the last few years to see if you can duplicate, but I've also experienced similar problems with the other templates like SimpleConfluence.  I have moved away from using the wwwroot and just using a random folder in the c:\drive
Thanks,
Jen
MobileMovieSearch.zip

Copying is working here (MobileMovieSearch and SimpleConfluence).
Please check

all source files are available in your template folder
you have sufficient write permissions at your target folder

otherwise I need to create a special tmm version with enhanced debugging infos..


loading oscar-corpus/OSCAR-2201  raises an error

Describe the bug
load_dataset('oscar-2201', 'af')
raises an error:
Traceback (most recent call last):
File "/usr/lib/python3.8/code.py", line 90, in runcode
exec(code, self.locals)
File "", line 1, in
File "..python3.8/site-packages/datasets/load.py", line 1656, in load_dataset
builder_instance = load_dataset_builder(
File ".../lib/python3.8/site-packages/datasets/load.py", line 1439, in load_dataset_builder
dataset_module = dataset_module_factory(
File ".../lib/python3.8/site-packages/datasets/load.py", line 1189, in dataset_module_factory
raise FileNotFoundError(
FileNotFoundError: Couldn't find a dataset script at .../oscar-2201/oscar-2201.py or any data file in the same directory. Couldn't find 'oscar-2201' on the Hugging Face Hub either: FileNotFoundError: Couldn't find file at https://raw.githubusercontent.com/huggingface/datasets/master/datasets/oscar-2201/oscar-2201.py
I've tried other permutations such as :
oscar_22 = load_dataset('oscar-2201', 'af',use_auth_token=True)
oscar_22 = load_dataset('oscar-corpus/OSCAR-2201', 'af',use_auth_token=True)
oscar_22 = load_dataset('oscar-2201', 'af')
oscar_22 = load_dataset('oscar-corpus/OSCAR-2201')
with the same unfortunate result.
Steps to reproduce the bug
oscar_22 = load_dataset('oscar-2201', 'af',use_auth_token=True)
oscar_22 = load_dataset('oscar-corpus/OSCAR-2201', 'af',use_auth_token=True)
oscar_22 = load_dataset('oscar-2201', 'af')
oscar_22 = load_dataset('oscar-corpus/OSCAR-2201')
Sample code to reproduce the bug

## Expected results
loaded data

## Actual results
Traceback (most recent call last):
  File "/usr/lib/python3.8/code.py", line 90, in runcode
    exec(code, self.locals)
  File "<input>", line 1, in <module>
  File "..python3.8/site-packages/datasets/load.py", line 1656, in load_dataset
    builder_instance = load_dataset_builder(
  File ".../lib/python3.8/site-packages/datasets/load.py", line 1439, in load_dataset_builder
    dataset_module = dataset_module_factory(
  File ".../lib/python3.8/site-packages/datasets/load.py", line 1189, in dataset_module_factory
    raise FileNotFoundError(
FileNotFoundError: Couldn't find a dataset script at .../oscar-2201/oscar-2201.py or any data file in the same directory. Couldn't find 'oscar-2201' on the Hugging Face Hub either: FileNotFoundError: Couldn't find file at https://raw.githubusercontent.com/huggingface/datasets/master/datasets/oscar-2201/oscar-2201.py

## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.3.2
- Platform: Linux-5.13.0-37-generic-x86_64-with-glibc2.29
- Python version: 3.8.10
- PyArrow version: 8.0.0
- Pandas version: 1.4.3

I had to use the appropriate token for use_auth_token. Thank you.


replace depcreated import:dirs hook with rc9 addImportDirs helper method

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

After the introduction of the release candidate 9 from nuxt, there is a deprecation warning printed in the terminal in regards to the imports:dirs hook. There was a replacement wrapper method introduced addImportDirs which basically does the same. This PR changes the old hook to the new wrapper method
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

Hey @aaronschweig, thanks for the PR but I already have updated the hook from autoImports:dirs in favor of import:dirs. Here is the warning autoImports:dirs hook is deprecated. Use addImportsDir() from @nuxt/kit or imports:dirs with nuxt>=3.0.0-rc.9.  . Both import:dirs and addImportsDir are ok :)


Improve on readme  / some minor changes / added rubymine.sh

[x] Improve readme with a list of applications and command
[x] Some minor changes to correct grammar
[x] Aded rubymine.sh

This PR is really cool! Thanks @limatheus :smile: :+1:


Fix excluded escaped files

Fixes #39

Done! 🎉

Cool, looks great! I'll try to get a release out later.


Allow the Store to handle process death.

Since Android is unpredictable it would probably be a good idea to allow the Store to survive process death: https://medium.com/inloop/android-process-kill-and-the-big-implications-for-your-app-1ecbed4921cb
Currently device rotation works fine, however if the application is killed and you return none of the data remains, even worse if you are in an area of the app expecting data to be there the application will crash.
There are a few options out there:

Allow each responder notify the model when the activity has been paused, at that time the developer can decide if they need to persist that model through process death (as in they should store the data on disk).
Handle this automatically for the developer, this can be done through the Application class and registering ActivityLifecycleCallbacks to notify the Store of changes in the application state.

In either case these are the important callbacks in order of when they are called:

onActivityPaused
onActivitySaveInstanceState
onActivityStopped
onTrimMemory

onActivitySaveInstanceState would probably make the most sense since that's traditionally where you would want to save state.

You can see in HelloFlax that if you put app in background and terminate, then the integer gets cleared.
But that disobeys Activity contract. Some libraries claim handling process death is unnecessary, but they've clearly never used an Android phone to take a screenshot and share it through Skype.

Thanks @Zhuinden, as this issue outlines that's something which is going to be addressed better in a future release.


Make v0.0.28

Hi @venexia
The r image was updated last week, which included updating the readr package. This PR mainly changes readr::write_csv(path = ) to readr::write_csv(file = ). There are some other minor tweaks as well.

Great, thanks @remlapmot !


Updating repository links in README.md

Some links in README.md are outdated, changes after project renaming are still not reflected. Just updated those links.

Coverage remained the same at 84.728% when pulling cfde5c8c53abd8ff8f8dd4bbd76716c161c6cd45 on yaronius:master into 8ff139531068934b9191d83f654ff39c91952344 on go-bongo:master.

Build failed on non-stable Go version, is it ok to test on unstable versions?

I'm going to merge and change to the latest stable


Failing CI

https://travis-ci.org/perguth/peertransfer/builds/481908576#L492
It seems the provided token is not valid anymore.

Token updated, builds are running again! 🎆


Sema: Fix checkTypeWitness() for Objective-C protocol compositions

I forgot that a protocol composition (C & P) can satisfy a superclass requirement [T : D] in one narrow case implemented in TypeBase::isExactSuperclassOf():

D is a superclass of C
P is an @objc protocol
C is declared in Objective-C

This case was ruled out here because the code assumed the type witness had to be a concrete class or archetype to satisfy a superclass requirement.
Fixes rdar://problem/123543200.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please smoke test

@swift-ci Please test Windows


AVM8 callstack frames update

Looks good to me overall, but please address the nitpicks.

@geo2a There is some sort of issue in the CI with the python linting, although the python code was not modified in this PR. I was not able to replicate it locally. I wonder if the CI has a different pyk version than I do, but I'm not sure how to check that.

Sorry about that @nwatson22, the linting is fixed now. There's one spec that does not pass  though, please have a look.


Graph need to be locked when doing Gremlin request

There are races on Graph access on Exec function of traversal_parser.go
http://softwarefactory-project.io/jenkins/job/skydive-functional-tests-backend-gremlin-ws/3320/console

fixed : https://softwarefactory-project.io/r/#/c/6914/


redirect the request with the correct lang #1107

@zeke, Would you have a look at this new middleware to resolve the lang?

@zeke I have added the tests.

@zeke parseurl dependency was removed. This pull is ready to go ....


Break down big classes to smaller classes

With each addition of new features the size of the single class is increasing. May I suggest we break up a class in the following format.
+-- arrays/
|   +-- grouping/
|         +-- in_groups.cr
|         +-- split.cr
|   +-- grouping.cr

So that the code will be more organised. If people want to just include the grouping of array they can do crystal_on_steroids/arrays/grouping or if the one just a specific method they can do crystal_on_steroids/arrays/grouping/in_groups.
The above require is just an added benefit the main thing is to make the code more organised as we are going to add more methods.

I think this might be a good idea. I'm not sure how big array.cr could be, but I think by now is good.


Ineffective tx wont be removed from MemPool, blocking all following txs

I'm using Smapp 1.2.9 on Mac. Steps to produce:
1)I create a fully new address with no gas in it, then I build a spawn transaction to test my sdk. the transaction is broadcast successfully to the node and the SubmitTransactionResponse tells me that the state is in mempool
However, the transaction is still in the mempool and seems not removed.
2)  I transfer some smidge to this account ,after the tx is applied, the transaction is still in the mempool, neither removed or mined.
3)  I try to build another spawn tx, but its nonce from projected state is still 0, causing this tx fails, reporting:
"Failed to verify transaction: tx already exists"
4) Even if I use TransactionState api to check this transaction, it still show state "TRANSACTION_STATE_MEMPOOL"
.I think if the transaction does not have enough fund to pay balance/gas, it should be removed immediately and reporting states like "TRANSACTION_STATE_REJECTED"
Is this expected behavior? How to bypass it?

I've seen some similar behavior, not sure if it's the same issue or different:

generate and broadcast a tx that's valid aside from having an invalid counter (e.g., higher counter value already consumed)
tx gets mined into block (example: https://explorer.spacemesh.io/txs/0x2dee9b43ac885b2b013b93fa115ee36877d92935aef80c23d47d2821cfa765cd), likely because optimistic filtering wasn't working at the time - but isn't effective
tx continues to sit in mempool; API reports TRANSACTION_STATE_MEMPOOL. at present this tx will never leave the mempool.

There are definitely many such transactions in the mempool today

I'm beginning to understand what's going on here - although I'm also beginning to suspect that these are two separate (possibly related?) issues and that we might need more information to troubleshoot OP's issue.
The issue as I understand it is that transactions at present can only have three possible internal states in the node:
https://github.com/spacemeshos/go-spacemesh/blob/92b7762a6b4ce854af08c8cf6e2473442b5764b9/common/types/transaction.go#L123-L134
As soon as a tx has been parsed (its header has been read, i.e., it's syntactically valid), it's assigned state MEMPOOL:
https://github.com/spacemeshos/go-spacemesh/blob/92b7762a6b4ce854af08c8cf6e2473442b5764b9/sql/transactions/transactions.go#L171-L177
This doesn't mean it's contextually valid, e.g., its counter may be wrong. It also doesn't mean the tx is actually in the mempool. It may only be in the database -- and I guess we save all txs in the database, even ones that will never be effective. So there's also a question of whether we should drop these txs from the database, and on what logic. (Even a tx that appears that it'll never be effective because, e.g., a tx from the same principal with a higher counter has already been processed, could theoretically appear in a valid older block that a node missed, or due to a reorg.)

This issue is still actual and should be solved.
I've published some transactions which cannot be processed (except maybe the first one):

I've published self-spawn with nonce 0, but had zero balance
When I trying to publish again it returns "tx already exist"
So I've published a couple of self spawn transactions with other nonces (going out of order, e.g. 2, 100, 22222)
And published one spend transaction

All of them has mempool status, does not change nonce, and blocks from submitting tx.
And if they actually persist in a mempool, then it might be an attack vector.
Here is one of my transactions:
curl -d "{\"txid\":[\"Qdke0v/mYF5XZSuFQAKlTvQir2PpViEqHq6i8YtCttI=\"], \"include_state\": true, \"include_result\": true,\"limit\":1 }" -X POST https://wallet-api.spacemesh.network/spacemesh.v2alpha1.TransactionService/List

{"transactions":[{"tx":{"id":"Qdke0v/mYF5XZSuFQAKlTvQir2PpViEqHq6i8YtCttI=","principal":"sm1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcqcvr47","template":"sm1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqg56ypy7","method":0,"nonce":{"counter":"2222"},"maxGas":"100432","gasPrice":"1","maxSpend":"0","raw":"AAAAAADlDRp5GIQYXyQliftw3lWnYFE8fwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAG5IgTMkR8HdG1+KGb+Mclb5PwOdyHXo5ING3vu66DFeG63YoNkH5Vwri7llqIyQf5rwJCG/SSdPP6IBf4/gLFmMz1zPRo+DABnFO9+uXOCBK+UTu3RqSUzbohqOOAmwRL9rQc=","type":"TRANSACTION_TYPE_UNSPECIFIED","contents":{"singleSigSpawn":{"pubkey":"cc911f07746d7e2866fe31c95be4fc0e7721d7a3920d1b7beeeba0c5786eb762"}}},"txResult":null,"txState":"TRANSACTION_STATE_MEMPOOL"}],"total":1}%

Okay, I run another test on standalone network and published 2 self spawn transactions (with nonces 0 and 1) with zero balance. Once I got positive balance this transactions were applied, both are processed.
So I guess they are actually in the mempool, and somehow both of them become effective...
curl -d "{\"txid\":[\"X9YwBi7EoA5g5Ro7rfhsKzvzsgiYM99rE6v8GYB5XA0=\"], \"include_state\": true, \"include_result\": true,\"limit\":1 }" -X POST http://<IP_ADDRESS>:8080/<IP_ADDRESS>:9095/spacemesh.v2alpha1.TransactionService/List

{"transactions":[{"tx":{"id":"X9YwBi7EoA5g5Ro7rfhsKzvzsgiYM99rE6v8GYB5XA0=", "principal":"standalone1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcwe3cnj", "template":"standalone1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqg6me6zj", "method":0, "nonce":{"counter":"1"}, "maxGas":"100432", "gasPrice":"1", "maxSpend":"0", "raw":"AAAAAADlDRp5GIQYXyQliftw3lWnYFE8fwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEEBMyRHwd0bX4oZv4xyVvk/A53Idejkg0be+7roMV4brdiEw511ZDZXJFeLIQCcg66tiFDbllS0aA1jjvKRzg0iwO3BMNq9t36BNc/ff6DI39UlFT5++fFHRrg7NKQua6DAQ==", "type":"TRANSACTION_TYPE_UNSPECIFIED", "contents":{"singleSigSpawn":{"pubkey":"cc911f07746d7e2866fe31c95be4fc0e7721d7a3920d1b7beeeba0c5786eb762"}}}, "txResult":{"status":"TRANSACTION_STATUS_FAILURE", "message":"account already spawned", "gasConsumed":"100432", "fee":"100432", "block":"CUezL8kHOkimH00ipFJSwlnQOvE=", "layer":22, "touchedAddresses":["standalone1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcwe3cnj"]}, "txState":"TRANSACTION_STATE_PROCESSED"}], "total":1}%

curl -d "{\"txid\":[\"mpPfyNOSyXdtdBkGMPK7R3pY4zBzaDoQv9s2NuCfhZs=\"], \"include_state\": true, \"include_result\": true,\"limit\":1 }" -X POST http://<IP_ADDRESS>:8080/<IP_ADDRESS>:9095/spacemesh.v2alpha1.TransactionService/List

{"transactions":[{"tx":{"id":"mpPfyNOSyXdtdBkGMPK7R3pY4zBzaDoQv9s2NuCfhZs=", "principal":"standalone1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcwe3cnj", "template":"standalone1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqg6me6zj", "method":0, "nonce":{"counter":"0"}, "maxGas":"100432", "gasPrice":"1", "maxSpend":"0", "raw":"AAAAAADlDRp5GIQYXyQliftw3lWnYFE8fwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEABMyRHwd0bX4oZv4xyVvk/A53Idejkg0be+7roMV4brdimN8FJS5OKvkrGE9r5HK5JQYGeFDYnBwr1Yfl52zMbdGVbJriA2dOuIkgjV3Kyh99BjqrGEQbitZcyMZ9TMhuAA==", "type":"TRANSACTION_TYPE_UNSPECIFIED", "contents":{"singleSigSpawn":{"pubkey":"cc911f07746d7e2866fe31c95be4fc0e7721d7a3920d1b7beeeba0c5786eb762"}}}, "txResult":{"status":"TRANSACTION_STATUS_SUCCESS", "message":"", "gasConsumed":"100432", "fee":"100432", "block":"CUezL8kHOkimH00ipFJSwlnQOvE=", "layer":22, "touchedAddresses":["standalone1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcwe3cnj"]}, "txState":"TRANSACTION_STATE_PROCESSED"}], "total":1}

A few points. First off, there are three related but distinct issues/questions here:

the first involves the API, and the transaction states it returns. We should not discuss that here. CC @kacpersaw
the second is a UX/wallet question. It involves how the wallet monitors a user's submitted transactions, how it becomes aware of when a transaction is mined or dropped from the mempool, and the tx state/status/journey. It also involves the UX around RBF (replace by fee). We should also not discuss that here.
the third involves how the mempool in go-spacemesh works: what's the policy for inserting, updating, and dropping transactions. We should discuss this here.

It seems like our goals for the third are:

make sure we understand the mempool admission/eviction procedure, and make sure it's clear, and clearly documented. We should adopt a similar strategy to Bitcoin: set a fixed mempool size, allow the node operator to change this, be liberal with what we admit up to this limit, begin to drop txs with a low likelihood of inclusion once the mempool is full.
we should prioritize txs by fee. This applies both to duplicate txs from the same principal (to allow RBF), and also to a full mempool (drop lower fee-paying txs in favor of higher fee-paying txs).
handling the situation where an invalid tx blocks one or more valid txs (from the same principal, with higher nonces) is tricky. Really, this is not the responsibility of the node. It's the responsibility of the wallet/user. The user should not submit a tx that will never be valid, followed by a higher-nonce tx that is valid. And the wallet should allow the user to speed up or cancel a tx using RBF. Even if wallets prevent this, however, a user might encounter it if using multiple wallets. There's a potential DoS vector here if the node tries to get "too clever," e.g., by evaluating all txs from a given principal for validity before proposing/including them in a block. We should do something simple here: likely, wait maybe a single block, and then evict all txs that are still invalid. I need to do some more homework and see what, e.g., go-ethereum does.

Roughly speaking, once a user submits a tx to a node, these are the possible outcomes:

tx is admitted to the mempool and has a MEMPOOL state.
tx is mined into a block and has a CONFIRMED state (in the API this is currently split into MESH and PROCESSED).
tx is rejected upon admission. No txid is generated.
tx is initially admitted to the mempool but later evicted (due to RBF, or a full mempool). In this case, when the user queries the tx state via the API they should receive "tx unknown."

Am I missing anything?
I'll do a little more homework into how other nodes/protocols handle this.

One another case:

I've published spend tx with amount higher than I have and Nonce 19,
Then I've published another spend tx with proper amount and the same Nonce 19,
First transaction is still in the mempool, but I expect it to become rejected because of the Nonce.

On TestNet 13.
The tx that stuck in the mempool:
curl -d "{\"txid\":[\"4H3xp37Pq2YHDxiN6VVqwO6TDDC1VV6Q4SsXopkkiYU=\"], \"include_state\": true, \"include_result\": true,\"limit\":1 }" -X POST https://testnet-13-api.spacemesh.network/spacemesh.v2alpha1.TransactionService/List

{"transactions":[{"tx":{"id":"4H3xp37Pq2YHDxiN6VVqwO6TDDC1VV6Q4SsXopkkiYU=", "principal":"stest1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcad4mm8", "template":"stest1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqgf0ae28", "method":16, "nonce":{"counter":"19"}, "maxGas":"36218", "gasPrice":"1", "maxSpend":"99999999000000000", "raw":"AAAAAADlDRp5GIQYXyQliftw3lWnYFE8f0BMBAAAAADlDRp5GIQYXyQliftw3lWnYFE8fxMANu8heEVjAY+ppGvPx1hjTo0KGySkuhRvQc1iNVHkrxPg5yDouhH4vz5zhJdHilglCTpSVyEt0j/qHU7K3AD+vNPMKjcYVAI=", "type":"TRANSACTION_TYPE_SINGLE_SIG_SEND", "contents":{"send":{"destination":"stest1qqqqqq89p5d8jxyyrp0jgfvfldcdu4d8vpgnclcad4mm8", "amount":"99999999000000000"}}}, "txResult":null, "txState":"TRANSACTION_STATE_MEMPOOL"}]}

Processed one:
https://testnet-13-explorer.spacemesh.network/txs/0xb1ce27d3ffd99b2ddeb99b4d8f7d70851fdf93246f132d2a22a0a7c47e56ad18

I spoke to this in my previous comment. This is an antipattern and wallets shouldn't allow this - you should not be able to submit a spend for more than your account contains. If you do, the correct thing to do is RBF with a valid transaction.
Having said that, we still need to understand how other nodes/protocols handle this and we may just want to evict bad txs after some time, as I also said in my previous comment.

Completely agree. On the Wallet side we should definitely add validation for "not possible to send more than the current balance".
We definitely should do RBF, just because people can do mistakes. And one of the easiest thing to do when you want to cancel, is to replace it with transaction to yourself.
But additionally on top of that I think we need some auto expiry for mempool transactions. But it's my gut feeling not an educated suggestion.

@pigmej @lrettig I've added a PR #6164 to add a unit test for RBF which appears to be already possible so we can at least strike that one off the list (at least to the best of my understanding). As for the rest of the issues described above I'll have another look tomorrow.

That's good news. Thanks for taking a look.

Btw, another inconsistency in the behavior:

if I send spend tx with insufficient funds — it gets stuck in mempool
if I send drain tx trying to drain more funds than vault stores — it gets rejected with corresponding error message: https://testnet-13-explorer.spacemesh.network/txs/0x17ff1a80ca6d173bbb972b429d760a8d205403e6b47ee08f1ce1b7e5e4429315

I believe either both txs should be rejected or both should be accepted into the mempool.

Most of the issues here should be solved with the merging of #6185. @brusherru If you have other suggestions we could handle them in future issues.


fix: enabled multitenancy in tests

Which problem does the PR fix?

What's in this PR?

Checklist
Please make sure to follow our Contributing Guide.

Before opening the PR:

[ ] There is no other open pull request for the same update/change.
[ ] The commits follow our Commit Guidelines.
[ ] Tests for charts are added (if needed).
[ ] The main Helm chart and sub-chart are updated (if needed).
[ ] In-repo documentation are updated (if needed).

After opening the PR:

[ ] Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
[ ] Did all checks/tests pass in the PR?

We should add that part of the periodical tests not the PR tests unless MT is enabled by default.
There are a couple of cases were we need such periodical tests (e.g. minor version upgrade).

@jessesimpson36 what we can do now is allowing to test MT via GH labels so we don't change the default behaviour yet we allow users to test MT if they want.
we can do somthing like that:
https://github.com/camunda/camunda-platform-helm/blob/26a13e0f26be665166b7f23345b5c9da18ed1714/.github/workflows/test-integration-main.yaml#L74


Observation/BUG: order of IP is alphanumeric

Tiny issue.
On my default, the IP ordering is in alphanumeric, not natural.
Perhaps change the default?

Hi,
Sorry for late response, here (https://github.com/Chleba/netscanner/commit/2119562975f9ab9e06041960e6c089a6365f24d4) is implemented sorting for IP addresses as requested. Thank You for you interest and bug report.
Please hold on just a little while because next version will need to address more small features and bug fixes.


984 # Add change password form for logged in user.

https://app.zenhub.com/workspace/o/codeforpoznan/volontulo/issues/984

@magul I addressed your remark.

Codecov Report

Merging #1032 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master   #1032      +/-   ##
=========================================
- Coverage   90.92%   90.9%   -0.03%
=========================================
  Files         114     114
  Lines        2701    2704       +3
  Branches       31      31
=========================================
+ Hits         2456    2458       +2
- Misses        241     242       +1
  Partials        4       4

Impacted Files
Coverage Δ

.../volontulo/tests/views/api/test_password_change.py
100% <ø> (ø)
:arrow_up:

.../app/offers/create-offer/create-offer.component.ts
53.75% <100%> (ø)
:arrow_up:

backend/apps/volontulo/serializers.py
92.51% <100%> (ø)
:arrow_up:

frontend/src/app/auth.service.ts
92.42% <66.66%> (-1.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389fdc5...c8af8ba. Read the comment docs.


Transforms/axisym synthesis

This PR adds support for the following:

[x] Directional synthesis transform for complex spin-signals.
[x] Switches from 1D indexing to multi-dimensional arrays.
[x] Updates docstrings throughout.
[x] Updates to RNG generator for testing.
[x] Adds fixture to generate random wavelets.
[x] Adds tests for the above.

closes #12 #23

@alicjapolanska @JessWhitney I know we all worked on this together but it may still be useful for you to read through the code here to make sure everything makes sense before we branch off and work on independent issues :)


Format analyzer flags stack traces as bad log lines

This is due to the structure of the logic, as it was written before we had examples of stack traces. Since this is not the intended function, this should be changed.

And since I'm the one who wrote the format analyzer, I can work on this


CS servers in Chengdu, China

https://github.com/SteamDatabase/GameTracking-CS2/commit/e13577bb6387af1062e2fa84c2a26f35aa5029e7#diff-5a92baa87a9b95661bda6e243288baa4a150cbcf6110cc8cd26219bad4b47250R33088
Oh, not in the API data, waiting for an Valve update......

They're added when they're available.


fix incorrect bindings example in Next.js pages guide

we should also add js but lgtm

Yes I agree, but these bindings sections usually just present the typescript version (for example see qwik and remix).
Adding both js and ts could be quite verbose and I guess we'd need to have two different sections one for each or something like that...
I'm afraid it could increase the size of the guide and make it more overwhelming/intimidating... 🤷
We've discussed about the bindings sections with @deadlypants1973 and they should probably get overhauled at some point as now they are not too helpful/explanatory for newcomers.
So I am not really sure, I am happy to add a js section for this but my feeling is that these need to be improved anyhow at some point and for now we can at least make it correct in the most common case (typescript).
TLDR; let's see what @deadlypants1973 says, I'd be happy to add a js version of this but I am not sure how that'd look

Adding both js and ts could be quite verbose and I guess we'd need to have two different sections one for each or something like that...

We generally just do a code switcher as there isn't much content change between the two - https://developers.cloudflare.com/pages/platform/functions/bindings/

Adding both js and ts could be quite verbose and I guess we'd need to have two different sections one for each or something like that...

We generally just do a code switcher as there isn't much content change between the two - https://developers.cloudflare.com/pages/platform/functions/bindings/

Yes, but with in this case we need to mention the env.d.ts update for Typescript, so a code switcher wouldn't fully help, no? (unless we put all file contents in a single code snippet? 😕)

Yeah I'd just put both the env block and code block into TS switch and then just code for JS switch
Not the end of the world at all and not blocking but we should always push for JS first, not everyone uses TS (especially beginners!)

Yeah I'd just put both the env block and code block into TS switch and then just code for JS switch

I see 🙂
Putting both in a single block would be a bit ugly from my point of view but not the end of the world, I'm totally ok with making the change if you want, but I'd really like to see what Kate thinks as I mentioned she's has had opinions on these bindings sections 🙂

Not the end of the world at all and not blocking but we should always push for JS first, not everyone uses TS (especially beginners!) -- this was very much a note not a "pls change" :)

cool thanks 😁 , but either way I am totally happy with making the change here, applying the switch is going to be very straightforward anyways, it's no problem, I was just saying that I'm not sure what's best with the current structure we have 🙂

@WalshyDev regarding adding a Javascript version, I'll do that separately across the board for all the various meta frameworks (https://github.com/cloudflare/cloudflare-docs/issues/12041) 🙂👍


Is there a simple way to install rusftmt 2.0 rc without building from source?

Hey!
I'm new to the rust ecosystem and would like to try out 2.0. Is there a simple way to install and then uninstall the 2.0 versions?
From what I see the nightly versions on cargo are 1.4.x as well

hello @Kungitoo :wave: thanks for the question and welcome! :crab:

Is there a simple way to install rusftmt 2.0 rc without building from source?

No there's not. The primary distribution channel for rustfmt is via rustup and the associated rust releases.
https://github.com/rust-lang/rustfmt#installing-from-source
rustfmt is also available on crates.io (though it's several versions behind the latest version available via rustup), but there's really not must of a difference in the experience between installing from crates.io vs. installing from source: both involve building and both utilize the cargo install ...

Is there a simple way to install and then uninstall the 2.0 versions?

Think the installation bit was covered above, and cargo uninstall can be used to uninstall both an install from source or crates.io
Also regarding your question from https://github.com/rust-lang/rustfmt/issues/4437#issuecomment-741845052

can we know if 2.0 is planned for 2020 or is there a roadmap somewhere?

We were actually ready to ship the 2.0 release back in the spring, but as we were starting that process there were various concerns and objections about having a breaking/2.0 release for an official tool that ships with the main Rust distribution (which itself is on a 1.x version).
There definitely won't be a 2.0 release in 2020, and long term I'm honestly not sure what the plan is going to be. It's entirely plausible we may never be able to do so, or at least not until there's a hypothetical 2.0 release of Rust, due to the combination of how seriously Rust takes stability and rustfmt's own stability guarantee.
Here was the original milestone we had tracking the 2.0 release:
https://github.com/rust-lang/rustfmt/milestone/8

Could you release 2.0 version to be available under some flag? I know this would never pass, but could you bundle 2.0 code with the 1.x package and then when some flag is specified we use the 2.0 code which is completely separate so it doesn't interfere with the stable 1.x version?

If you only need rust-fmt, you can build rustfmt feature from source code, and then replace it from toolchains.

Windows

set CFG_RELEASE=1.45.0-nightly <--(Specify yours)
set CFG_RELEASE_CHANNEL=nightly

cargo build --bin rustfmt --features="rustfmt"

cp debug\target\rust-fmt.exe C:\Users\Francis\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\bin

Linux/MAC

export CFG_RELEASE=1.45.0-nightly <--(Specify yours)
export CFG_RELEASE_CHANNEL=nightly

cargo build --bin rustfmt --features="rustfmt"

cp debug/target/rust-fmt ~/.rustup/toolchains/nightly-***/bin

It's mine
> cargo fmt --version
rustfmt 2.0.0-rc.2-beta (2ce75b11 2020-12-09)

Could you release 2.0 version to be available under some flag?

No. I appreciate your interest in the potential 2.0 version, but it's not released right now by design for the reasons I shared above and that's not going to change any time soon. If you want to use the unreleased version of rustfmt from the source control repository, then you're going to have to work with the source control repository in your local and/or CI environments.
Going to go ahead and close this given that the question has been answered, thanks again for reaching out!

@francis-du - I'd advise against mixing and matching different major versions of cargo fmt and rustfmt, but even if you decide you want to take that risk, note that it'd be easier to utilize the RUSTFMT environment variable to specify the custom path to the rustfmt binary instead of hacking up rustup managed directories.
https://github.com/rust-lang/rustfmt#running-cargo-fmt
Please be aware that there's substantial differences in the 2.x version of rustfmt that the 1.x version of cargo fmt doesn't necessarily work with, notably, rustfmt 2.x is not recursive by default so if you run cargo fmt 1.x it will result in only the entry point files for the respective targets in your projects being formatted (main.rs, lib.rs, build.rs, etc.); all other files would be ignored unless you change your invocation to cargo fmt -- --recursive

@calebcartwright Thanks for reminding : )

@calebcartwright Thanks for reminding : )

Sure thing, thanks for sharing your findings!

There definitely won't be a 2.0 release in 2020, and long term I'm honestly not sure what the plan is going to be. It's entirely plausible we may never be able to do so, or at least not until there's a hypothetical 2.0 release of Rust

If rustfmt 2 is not going to be released, what does that mean for the added configuration options which were stabilised only in 2.0? Are those stabilisations going to get backported? Is there a blog or discussion thread somewhere with more insight into what is going to be happening here? I’d been holding off for an official v2 release to formally adopt rustfmt in a project I have been working on, so it would be nice to get a sense of what the plan is. A quick search did not surface anything about this on rust-internals or rust-users forums. Thanks!


epic: Move Docs back into Cortex repo

Goal

Continue.dev and others are able to refer to @docs
We are a small team and Docs should be part of Eng work

Added @urmauur  here to update all the website links, i.e. when user visits jan.ai/cortex/homebrew, adn clicks the "edit this page"

Thanks @hiento09 and @urmauur! Marking as complete


[Feature] get all message from a category

Q
A

Yii version
2.0.12?

Hi
i think this feature is need for big project that using internationalization(I18N).
but where is it used?
this is used in interaction between server I18N and client project like javascript.
i prepared a sample example.
Yii messages file in TreeView category
return [
    'Hello' => 'سلام',
    'Good' => 'خوب',
];

in javascript
var obj = new MyTreeViewClass();
obj->languages = '<?=yii::t('TreeView',null)?>';

in above js example i use null parameter for t method, because null means get all message from TreeView category.
also see
how i can get a category message in yii ?

While getting all the messages as an array could be useful, it should not be done via Yii::t() for sure. It could be added to MessageSource class as getMessages($category = null).

@yiisoft/core-developers opinions?

There is already a method, which returns a list of messages with translations per category:
https://github.com/yiisoft/yii2/blob/master/framework/i18n/MessageSource.php#L55-L68
However at current state it is protected, you can use ReflectionMethod::setAccessible() as hack to invoke it, if necessary, but you do this on your own risk.
Exposing it to the public interface is debatable: in general particular message source may store messages in the way fetching entire category is very complex or even impossible.
However interface for the MessageSource can be extended to return the all category messages - this will facilitate the possible translation user interface creation. Saving data should be added to MessageSource as well and be removed from yii\console\controllers\MessageController.

public function loadMessagesFromTranslator($category, $language)
{
$reflection = new ReflectionMethod(Yii::$app->i18n->getMessageSource($category), 'loadMessages');
$reflection->setAccessible(true);
return $reflection->invoke(Yii::$app->i18n->getMessageSource($category), $category, $language);
}


Exithook

sorry, forgot to commit everything...

This implementation does not work, unfortunately. Thanks though!

Wow, it's been a while. How's the family?

No kidding! The family is doing well. Having 1 kid meant that Mom had
to make real sacrifices to her free time. Having 2 kids means that Dad
knows what Mom was going through when there was just 1 kid :)
The family is doing well though. Miko is growing well and Noah is a
smiley little baby.  It's weird.
How are things with you and your family?
Cheers
sk
On Sun, Nov 6, 2011 at 4:47 AM, Tanzeeb Khalili
<EMAIL_ADDRESS>wrote:

Wow, it's been a while. How's the family?

Reply to this email directly or view it on GitHub:
https://github.com/sskirby/hydra/pull/2#issuecomment-2644317


Task/axdd comps1.0.6

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.065%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
584

Relevant Lines:
858

💛  - Coveralls


Maurader Mini tactile button

Hello Sir. I was wanting to ask how is the button programed. What does what. I cannot enter my wifi password correctly. It has skipped places and jumps 2 spaces. Flashed my esp 32 marauder mini I enjoy the options but not that one.

Hey friend, sorry for the delay..
It is actually configured to use as 3 btns interface
Moving leveler UP:

Short pulse: move the cursor down
Long pulse: move the cursor up

Moving cursor Down:

Short pulse: move cursor Right
Long pulse: move cursor Left

Center click: Select
It is very counterintuitive, I understand, but I will fix it in the next release ;)
To help you now, Launcher creates a file in the SD Card, called "config.conf".... Open it in the notepad, and change the MyWifiSSID and MyWifiPwd (or something like that) with your values... As it is a json, if you follow the structure you can add more networks i to it.. when connecting to a known network it will use this value

Thank you very much. There is no need to apologize for any delay.  I'll do what you said and change it. Muchas Gracias.

I'm finishing the new interface scheme for new boards, and tried to add side navigation for marauder mini devices.
Can you, please, test the Beta Release, to make sure that this build is ok? Web Flasher

After clicking Beta version then marauder then mini it refreshes page. no
option to connect or install
On Mon, Nov 25, 2024 at 8:04 AM Pirata @.***> wrote:

I'm finishing the new interface scheme for new boards, and tried to add
side navigation for marauder mini devices.
Can you, please, test the Beta Release, to make sure that this build is
ok? Web Flasher https://bmorcelli.github.io/M5Stick-Launcher/
image.png (view on web)
https://github.com/user-attachments/assets/50a9e3c6-e352-4acd-836b-958636497f55
—
Reply to this email directly, view it on GitHub
https://github.com/bmorcelli/M5Stick-Launcher/issues/83#issuecomment-2498108127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGW2VBV62FI4CNFLZKXU6KT2CMU4HAVCNFSM6AAAAABRPHAR2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGEYDQMJSG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

don't click the yellow letters lol.. I need to fix it.. hit the box

Got it. I'm in
On Mon, Nov 25, 2024, 8:04 AM Pirata @.***> wrote:

I'm finishing the new interface scheme for new boards, and tried to add
side navigation for marauder mini devices.
Can you, please, test the Beta Release, to make sure that this build is
ok? Web Flasher https://bmorcelli.github.io/M5Stick-Launcher/
image.png (view on web)
https://github.com/user-attachments/assets/50a9e3c6-e352-4acd-836b-958636497f55
—
Reply to this email directly, view it on GitHub
https://github.com/bmorcelli/M5Stick-Launcher/issues/83#issuecomment-2498108127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGW2VBV62FI4CNFLZKXU6KT2CMU4HAVCNFSM6AAAAABRPHAR2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGEYDQMJSG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

don't click the yellow letters lol.. I need to fix it.. hit the box

Fixed the btns.. now links are displayed only when available

Can you test the Marauder mini version from Beta Release? It is supposed to use Left and right for navigation..
If it keeps rebooting after show the bootscreen, keep the center btn pressed until it get into the Launcher, and tell me to what side the menu is going


Porting latest updates from cakesolutions/puppet-jenkins

…cs.puppetlabs.com/guides/templating.html#referencing-variables

Note :
I've created a new tag for this repo that needs to be created directly in McLarenAppliedTechnologies/puppet-artifactory
check http://stackoverflow.com/questions/12278660/adding-tags-to-a-pull-request
TAG : 1.0.5

:+1: LGTM