docs: add IMappableMember xml docs

Codecov Report

Merging #393 (15e5e76) into main (e5e2d1c) will increase coverage by 0.00%.
The diff coverage is 77.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff            @@
##             main     #393    +/-   ##
========================================
  Coverage   91.73%   91.74%
========================================
  Files         126      130     +4
  Lines        3931     4056   +125
  Branches      548      563    +15
========================================
+ Hits         3606     3721   +115
- Misses        214      221     +7
- Partials      111      114     +3

Impacted Files
Coverage Δ

src/Polyfills/Nullable.cs
0.00% <0.00%> (ø)

...k.Mapperly.Abstractions/MapDerivedTypeAttribute.cs
0.00% <0.00%> (ø)

...ok.Mapperly/Configuration/AttributeDataAccessor.cs
73.33% <66.66%> (-1.67%)
:arrow_down:

src/Riok.Mapperly/Emit/SyntaxFactoryHelper.cs
95.35% <93.93%> (-0.23%)
:arrow_down:

src/Riok.Mapperly/Configuration/MapDerivedType.cs
100.00% <100.00%> (ø)

src/Riok.Mapperly/Descriptors/Configuration.cs
95.00% <100.00%> (ø)

...Riok.Mapperly/Descriptors/MappingBuilderContext.cs
98.11% <100.00%> (+0.03%)
:arrow_up:

...ptors/MappingBuilders/DerivedTypeMappingBuilder.cs
100.00% <100.00%> (ø)

...erly/Descriptors/MappingBuilders/MappingBuilder.cs
100.00% <100.00%> (ø)

...apperly/Descriptors/Mappings/DerivedTypeMapping.cs
100.00% <100.00%> (ø)

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update Gradle Wrapper from 7.1.1 to 7.2

Update Gradle Wrapper from 7.1.1 to 7.2.
Read the release notes: https://docs.gradle.org/7.2/release-notes.html

The checksums of the Wrapper JAR and the distribution binary have been successfully verified.

Gradle release: 7.2
Distribution (-all) zip checksum: a8da5b02437a60819cad23e10fc7e9cf32bcb57029d9cb277e26eeff76ce014b
Wrapper JAR Checksum: 33ad4583fd7ee156f533778736fa1b4940bd83b433934d1cc4e9f608e99a6a89

You can find the reference checksum values at https://gradle.org/release-checksums/

🤖 This PR has been created by the Update Gradle Wrapper action.

Need help? 🤔

If something doesn't look right with this PR please file an issue here.

Unable to set all the PR reviewers, check the following usernames are correct:

@bigmichi1

Please refer to the documentation for the reviewers and team-reviewers input parameters.

🤖 This is an automatic comment by the Update Gradle Wrapper action.


Xcode 12 Beta Archive issue

[X] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

Same issue as reported here: https://github.com/Alamofire/Alamofire/issues/3240
What did you do?
Tried to build AlamofireImage with carthage.
What did you expect to happen?
Build sucessful.
What happened instead?
Archive failed with error:
Undefined symbols for architecture armv7:   "type metadata for Swift._StringObject.Variant", referenced from:       outlined init with take of Swift._StringObject.Variant in ParameterEncoding.o ld: symbol(s) not found for architecture armv7
Alamofire Environment
Alamofire version: 5.2.2, then the hotfix from "tattn/Alamofire" "hotfix-xcode12" as described here: https://github.com/Alamofire/Alamofire/issues/3240
AlamofireImage version: 4.1.0
Xcode version: 12 beta 2
Swift version: 5.3
Platform(s) running AlamofireImage: iOS
macOS version running Xcode: 10.15.6

I'm having this issue as well.

This should be fixed by Xcode 12b4.

final release updated on the App Store, not beta.
does not compile. was before running.


Update README.md

This PR adds my game engine to the list 😛

Sorry last few days were very busy :/


Enable re-using a video element after "emptied"

Reset state to initial state to allow a filter to be re used for consecutive plays.

Unsure if this is a good idea, it should be possible to re-use an old video element by simply creating a new media-event-filter instance with the old video element after it has emptied.


[Golang] Lots of identifier XXX may conflict with identifiers generated by CGO

I am using go 1.12.4 and when I run make this is the output:
./bytearray.go:54:20: identifier "_Ctype_char" may conflict with identifiers generated by cgo
./bytearray.go:77:58: identifier "_Ctype_char" may conflict with identifiers generated by cgo
./function.go:126:41: identifier "_Ctype_TVMFunctionHandle" may conflict with identifiers generated by cgo
./function.go:232:34: identifier "_Ctype_TVMFunctionHandle" may conflict with identifiers generated by cgo
./function.go:233:39: identifier "_Ctype_TVMValue" may conflict with identifiers generated by cgo
./function.go:234:39: identifier "_Ctype_int" may conflict with identifiers generated by cgo
./function.go:236:39: identifier "_Ctype_TVMValue" may conflict with identifiers generated by cgo
./function.go:237:39: identifier "_Ctype_int" may conflict with identifiers generated by cgo
./function.go:315:48: identifier "_Ctype_TVMRetValueHandle" may conflict with identifiers generated by cgo
./function.go:316:50: identifier "_Ctype_TVMValue" may conflict with identifiers generated by cgo
./function.go:317:50: identifier "_Ctype_int" may conflict with identifiers generated by cgo
./function.go:375:48: identifier "_Ctype_TVMFunctionHandle" may conflict with identifiers generated by cgo
./module.go:67:43: identifier "_Ctype_TVMModuleHandle" may conflict with identifiers generated by cgo
./module.go:120:41: identifier "_Ctype_TVMModuleHandle" may conflict with identifiers generated by cgo
./module.go:123:42: identifier "_Ctype_TVMFunctionHandle" may conflict with identifiers generated by cgo
./ndarray.go:51:38: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:69:17: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:130:36: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:153:17: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:225:23: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:231:33: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:242:15: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:249:15: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
./ndarray.go:270:38: identifier "_Ctype_long" may conflict with identifiers generated by cgo
./ndarray.go:277:38: identifier "_Ctype_TVMArrayHandle" may conflict with identifiers generated by cgo
./ndarray.go:346:39: identifier "_Ctype_TVMArray" may conflict with identifiers generated by cgo
make: *** [Makefile:40: all] Error 2

@advancedlogic   Thanks for reporting, I will check this.

@srkreddy1238 what is the status of this issue?

Will address it in coming weekend.

#3182


center text and move it to its respective positions in the image.

Added code structure to adjust xy positions of text based on which text box is used

added rough xy positions of all text for both basic and compact text boxes. This could need polishing later but for now for the rough demo, this will suffice


duplication of message box

Here message box is twice so i want to fix this issue.
Please assign this issue to me under gssoc-extd and hacktoberfest.

I have solved this issue @vishanurag . Please tag me under gssoc'24 extd and hacktoberfest.

Closed via #1027


Move translated expressions out of config to site.data

Moved translated expressions to a separate file leveraging site.data in previous PR.
Now updated all paths to use the site.data file instead of the config file.
This doesn't change anything with regards to the building of the site but allows for dynamic change of terms when coding.
Example:
The team name changes from Information Technology Strategy Team to Information Technology Strategy of Awesomeness Team
When running the site locally to debug, any change to the config file requires a restart of your local server. By using site.data, don't need to restart the server. Magic...

Could just be me, but doesnt seem to be working with WSL
I went into general.yml, head.title.en and changed it to
en: Information Technology Strategy Team 2
And nothing changed. I then stopped and restarted the server, and it refreshed
I know WSL has problems with live updated, but that's generally only if you are running against the Windows ifle system (mnt/d/whatever), but I copied all my files over to a native linux drive (/home/whatever), and I got the same behaviour in both places (no automatic refresh)


fix: bats test

Description
Add bats dependencies as submodules of the project.
Updated _common_setup.
PR Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added or updated tests that comprehensively prove my change is effective or that my feature works

Is there a reason homebrew isn't the best solution?

https://github.com/ztombol/bats-docs?tab=readme-ov-file#installation
Documentation says it is only for macOS users. Many people have Linux. Even if you can setup brew on your system, I am not happy to introduce another package manager to my system just to be able to install two supporting libraries.

Do they not ship bats-assert and bats-core?

Homebrew, npm and source code.


[mask_rom] Zero all RAM

We currently don't zero RAM because of the presence of the DV trigger for simulation termination. This needs to be resolved before shipping the Mask ROM image.

i just wanted to clarify, are we planning to 0 the ROM under all reset conditions?
It'll be important to separate the reasons why we've reached ROM.  As an example we don't really want to 0 the retention RAM unless its the right reboot reason.
I wrote this doc some time ago, it would be good to see what you think.

This issue is specifically tracking an issue where we don't zero a particular area of the main ram (but zero the rest), because writes to that area have effects in the DV testbench and verilator. I would prefer if we don't turn this into an issue that tracks all Ram Zeroing questions in the Mask ROM.
Yes we're aware of that document, and yes we're tracking the resolution (or not yet) of some of the questions in it.

sounds good. Thanks Sam.
On Thu, Oct 1, 2020 at 10:53 AM Sam Elliott<EMAIL_ADDRESS>wrote:

This issue is specifically tracking an issue where we don't zero a
particular area of the main ram (but zero the rest), because writes to that
area have effects in the DV testbench and verilator. I would prefer if we
don't turn this into an issue that tracks all Ram Zeroing questions in the
Mask ROM.
Yes we're aware of that document, and yes we're tracking the resolution
(or not yet) of some of the questions in it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/3619#issuecomment-702298858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSSEIW6WZG32MYLU77LSIS6YVANCNFSM4R44AGDA
.


feat: adds a function to indicate where successfully authenticated

:tada: This PR is included in version 2.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix: Internal "_id" primary key

Overview
The library creates _id primary key internally and doesn't let the user to create any more primary keys. It is then impossible to select by ID
Proposed Change
Allow the user to create primary keys.
Don't create the _id primary key internal and explain in the README file that needs creating for certain queries to work

You could use unique if you want to have unique keys to select from.

But I think I can't use unique autoincrement having already a primary key.
In my db table I select by ID, sometimes...
On Sep 6, 2016 23:04, "Heinrich Reimer"<EMAIL_ADDRESS>wrote:

You could use unique if you want to have unique keys to select from.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HeinrichReimer/android-inquiry/pull/11#issuecomment-245091037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGePUOjLONzspCOrKwqvQ2mtyOgQFk5gks5qndVegaJpZM4J19zB
.


Remove Punctuation

Hi there,
In pre-processing corpus, I think it is better if remove all punctuation in each passage because there are no-meaning punctuation

Hey @r1ckC139 ,
Thanks for using or repo!
IIRC we only consider alphanumeric spans to be recurring spans.


Cannot edit ACE Editor inputs

Extension does not work for https://gist.github.com

Thanks for reporting, I am going to check it out!

Seems ok to piggy back on this issue to say that it doesn't work with CodeMirror either:
https://codemirror.net/

Yep, it seems that the normal TextareaHandler
cannot be used for codemirror and ace, so I am going to add special
handlers for these.
Thank you for the report.

This is probably more accurate to be named "Cannot edit ACE Editor inputs"

Very excited to hear this bug is working on -- replacing the awful editor on GitHub Gists is definitely my #1 use case for this plugin.

I am working on this issue in the support-ace-editor, but I am not really sure why the first call to editor.getValue() returns some weird value.
If anyone familiar with ace would like to give it a look, it would be very nice!

If i load up gist.github.com or ace.c9.io, I'm able to run this in the console and get the value on the first call:
ace.edit(document.activeElement.parentElement).getSession().getValue()

And for codemirror:
document.activeElement.parentElement.parentElement.CodeMirror.getValue()
The CodeMirror element we eventually follow the ancestry too has the class CodeMirror by default I think.

@jtokoph
Thank you very much for your help.
Actually, it is a little more tricky than this here.
In both cases, this requires to use JS variables from the page,
but as Chrome plugins run in sandboxed environment, it is not possible
to access them directly, so what would work in the console will not work in the plugin.
I thought it could work by adding ace to the plugin,
but it seems that ace keeps some state when initializing editors,
so ace.edit creates a new editor instead of using the existing one.
I think the simplest way to do this is to inject a script in the main page
and send the actual CodeMirror, or ace editor back to the plugin.
I am going to see if this approach works.
If anyone has an alternative solution, I am of course opened.

I got a very basic prototype working in the support-ace-editor branch,
so I think I should be able to get this working by the end of the week.
The approach is to inject a script in the host page and add an extra
layer of message passing to get the value from the host page to the content-script.

@dlitvakb @jtokoph Thanks for the feedback and the help.
From 0.1.0, it should now work with ace and codemirror.
I would love if you could give it a try and give some feedback if you have any.

Works like a charm for both! Thanks so much for the extension!

Great, glad you like it! :smile:


Stream e2e log output

Streaming requires test verbosity and one package at a time, but still allows any number of parallel tests.

/lgtm
/approve


Modulith together with Gradle 'org.graalvm.buildtools.native' plugin causes strange problems

I have encountered a strange bug that made the modules.verify() always fail is there is a Spring component in an internal package, even if it is not used by another module, even for very simple Spring Boot applications.
My main development language is Kotlin with Gradle + Kotlin DSL. But I believe this also happens in Java. The issue seems to be with Gradle… maybe with the org.graalvm.buildtools.native plugin for gradle.
When using this plugin AND an application contextLoads() test, the modules.verify() test tails. Either removing the contextLoads() test or removing the native Plugin makes the test pass.
I struggle to understand how this happens, as I thought the plugin would only do thing when doing native builds.
I tried the same setup with Maven + Java and could not reproduce this bug.
Here is a minimal example project where you can test this behavior: https://github.com/dragetd/temp_modulith_graal_bug/tree/main

This seems to be caused by the compilation of the AOT generated code not seeing dependencies of scope runtime. spring-modulith-starter-core pulls in spring-modulith-core in runtime scope and some code generated in the AOT phase refers to types of that JAR. I'll have to investigate with our Gradle experts to find out how that can be fixed.

I filed a ticket with the Kotlin team.

Closing this as there's nothing we can do about this here.

Is there something to be done for the test failure that occurs with Java? The AOT processing seems to "corrupt" the state of the module such that the constraints are violated:
org.springframework.modulith.core.Violations: - Module 'root:com.example.modulithgraalbug' depends on non-exposed type com.example.modulithgraalbug.somemodule.internal.SomeThing__TestContext001_BeanDefinitions within module 'somemodule'!
Method <com.example.modulithgraalbug.ApplicationTests__TestContext001_BeanFactoryRegistrations.registerBeanDefinitions(org.springframework.beans.factory.support.DefaultListableBeanFactory)> calls method <com.example.modulithgraalbug.somemodule.internal.SomeThing__TestContext001_BeanDefinitions.getSomeThingBeanDefinition()> in (ApplicationTests__TestContext001_BeanFactoryRegistrations.java:56)
	at app//org.springframework.modulith.core.Violations.and(Violations.java:128)
	at java.base@17.0.9/java.util.stream.ReduceOps$1ReducingSink.accept(ReduceOps.java:80)
	at java.base@17.0.9/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base@17.0.9/java.util.HashMap$ValueSpliterator.forEachRemaining(HashMap.java:1779)
	at java.base@17.0.9/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:735)
	at java.base@17.0.9/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base@17.0.9/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base@17.0.9/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base@17.0.9/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base@17.0.9/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:657)
	at app//org.springframework.modulith.core.ApplicationModules.detectViolations(ApplicationModules.java:400)
	at app//org.springframework.modulith.core.ApplicationModules.verify(ApplicationModules.java:365)
	at app//com.example.modulithgraalbug.ModularityTests.verifiesModularStructure(ModularityTests.java:12)
	at java.base@17.0.9/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base@17.0.9/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base@17.0.9/java.util.ArrayList.forEach(ArrayList.java:1511)

In fact, there is. I didn't see that originally, as I assumed it'd be an intended violation. I think the culprit here is that the generated …__BeanFactoryRegistrations is located in the project root and Spring Modulith 1.1 tightened the verification to disallow code residing there to reach into the actual application modules' internals.
With manually written code this usually works well or at least can be worked around by configuration code in the application root package referring to an interface, gathering all beans of that type and the implementations hidden in the modules then implementing that interface.
I wonder if it makes sense to exclude the AOT generated files from the analysis. It looks like they all feature a double underscore in their classnames. Until we find a better means of identifying them, it might be a good enough way of detecting them?

I wonder if it makes sense to exclude the AOT generated files from the analysis

Yes, I think it does.

It looks like they all feature a double underscore in their classnames. Until we find a better means of identifying them, it might be a good enough way of detecting them?

Sounds reasonable to me given what's currently available.

Do you think we could annotate these classes with @javax.annotation.processing.Generated?

WDYT, @snicoll? There's also jakarta.annotation.Generated which, judging by the package name alone, is perhaps less tied to annotation processing but may not always be on the classpath.

Alright, with this being the second case for us to do this, I've triaged the existing issue and put a higher priority on it, see https://github.com/spring-projects/spring-framework/issues/30824
At face value, I am not a huge fan of using any of those annotations but we can discuss the pros and cons of a custom annotation of ours in the issue. Thanks!


Updated 'develop' to 'master'

I've started to work on issue https://github.com/jessesquires/JSQCoreDataKit/issues/11 and found that 'develop' brach don't contain fetching methods from 'master'. So I just copied them.

Thanks @artemkalinovsky !
I'll take care of syncing with master. In general, you can submit future PRs to develop, but currently you should probably submit to the release-2.0 branch.


Add support for conv_transpose2d on Metal backend

Adds support for the conv_transpose2d backend, opted to represent the list of parameters in a struct this time as the argument list was getting quite long.
Also added a benchmark test for this operation as I was toying with the perf of this operation while implementing.
The nice part of this one is that it seems to be the last "is metal" test flag that was required for the conv test suite!

Amazing thanks, will merge as soon as the CI is done!


generated projection missing t.timestamps

Not sure if this is intentional or not, but the generated projection migration doesn't seem to include the standard t.timestamps, null: false

Yeah, I guess I was thinking, since the projection is just a cache, the timestamps aren't very important. But do you think you might end up using them for something?

I will definitely use them when reading the projections - e.g.  updated_at being used for for fragment caching and http caching with stale?
But it's easy enough to add them to the migration myself, so no biggie if you don't want it in the gem.

Makes sense, and there shouldn't be any harm in having them for those people who never use them. I'll add this in a bit.


Quark & luggage arrow moving inventory support

Any way you could add support for the quark arrows for moving things in and out of inventories with the backpacked mod?

For them to appear in the backpacked gui

so from what I can see, there isn't a way for me to automatically add the buttons to my screen without a hard dependency on Quark, which I dont want to do. There is, however, a config option that allows you to add them yourself. Simply add "com.gizmo.luggage.client.LuggageScreen" to the "allowed screens" list in quark-common.toml. I'll look more if theres a different way, but this method does work so I would recommend using it for now.


brew formulae for macOS

Create brew formulae for installing it on macOS using http://brew.sh/

Is the installer not suitable?
curl -sS https://platform.sh/cli/installer | php

Generally, because this runs as just a single Phar (effectively just a PHP script), I want to keep the install as simple and generic as possible.

Also brew really dislikes auto-updating software. Which the CLI does. So you would want to turn-off autoupdating.. which sounds bad.

How does composer itself do? Is it even on brew?

There are brew formulae, apt packages,  etc. for Composer, but the more convenient way to install Composer is directly from their Phar, which can auto-update, etc. So I feel the other methods aren't useful.

Thank you very much for your feedback, I absolutely understand your point. There is a big PHP brew package repository, but it's true that managing composer and it's packages with brew isn't the best thing. It's like installing node.js with brew :-), it's fun at first, but after a while you update and do stuff and then it starts to break...


Online build failed - 25feb

ERROR: Failed to trigger build. by an hour
** build server status looks good

it seems that it throw that error when cordova .xml contain some 'error', but the config is validated. (my case: a plugin with spec param wrong)


[SPARK-12664] Expose probability in mlp model

What changes were proposed in this pull request?
Modify MLP model to inherit ProbabilisticClassificationModel and so that it can expose the probability  column when transforming data.
How was this patch tested?
Test added.

Test build #74965 has started for PR 17373 at commit 1f0da4e.

Test build #74965 has finished for PR 17373 at commit 1f0da4e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74965/
Test FAILed.

@WeichenXu123 are you keep working on this own or do you want me to take it over? I'm also interested in adding this feature. thanks!

@nicodri Hi, I am modifying this PR and will commit this week! Thanks!

cc @yanboliang thanks!

Test build #75835 has started for PR 17373 at commit 4cf8cee.

Test build #75835 has finished for PR 17373 at commit 4cf8cee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75835/
Test PASSed.

In which version this is going to be available on PySpark?

Test build #79374 has started for PR 17373 at commit 4cf8cee.

Test build #79374 has finished for PR 17373 at commit 4cf8cee.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79374/
Test FAILed.

I'd like to express my demand for this feature

@LeoIV sorry for delay! I will update code soon!

I checked out version 2.1.2-SNAPSHOT and performed your changes there (for me locally). It works, however the probabilites are not in range [-1,1]. Is this intended?

The probability should always between 0 and 1
Send me your test code and test data to help me find out where is wrong.
In my own test the result is ok.
Sent from my iPhone
On 12 Jul 2017, at 11:57 PM, Leonard Hövelmann <notifications<EMAIL_ADDRESS>wrote:
I checked out version 2.1.2-SNAPSHOT and performed your changes there (for me locally). It works, however the probabilites are not in range [-1,1]. Is this intended?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/17373#issuecomment-314989403, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASWEkm7B6dTvsgY3C9IZRrsPQTnFW_-1ks5sNb_KgaJpZM4MjfvG.

@WeichenXu123 I deleted my last comment because I wasn't quite sure, if I had no mistakes at other places. As I described above, I performed your changes in version 2.1. For small datasets, I get raw predictions, that are not in [0, 1]. You should be able to check it, using this small test case:
import org.apache.spark.ml.classification.MultilayerPerceptronClassifier
import org.apache.spark.ml.linalg.Vectors
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema
import org.apache.spark.sql.types.{IntegerType, StructType}
import org.apache.spark.sql.{Row, SparkSession}

/**
  * Created by Leonard Hövelmann<EMAIL_ADDRESS>on 14.07.2017.
  */
object TestProb {

  def main(args: Array[String]) = {
    val spark = SparkSession.builder().master("local[*]").getOrCreate()

    val rowSchema = new StructType().add("class", IntegerType).add("features", org.apache.spark.ml.linalg.SQLDataTypes.VectorType)

    val testData: RDD[Row] = spark.sparkContext.parallelize(Seq(
      new GenericRowWithSchema(Array(0, Vectors.dense(Array(0.1, 0.2, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
      new GenericRowWithSchema(Array(0, Vectors.dense(Array(0.1, 0.2, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
      new GenericRowWithSchema(Array(1, Vectors.dense(Array(0.1, 0.5, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
      new GenericRowWithSchema(Array(1, Vectors.dense(Array(0.1, 0.5, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
      new GenericRowWithSchema(Array(2, Vectors.dense(Array(0.1, 0.2, 0.8, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
      new GenericRowWithSchema(Array(2, Vectors.dense(Array(0.1, 0.2, 0.8, 0.4, 0.5))), rowSchema).asInstanceOf[Row]
    ))

    val testDataDf = spark.sqlContext.createDataFrame(testData, rowSchema)

    val mlp = new MultilayerPerceptronClassifier().setFeaturesCol("features").setLabelCol("class").setLayers(Array(5, 4, 3))

    val mlpModel = mlp.fit(testDataDf)

    mlpModel.transform(testDataDf).show(6)
  }

}

Using this, I get the following results:
+-----+--------------------+--------------------+--------------------+----------+
|class|            features|       rawPrediction|         probability|prediction|
+-----+--------------------+--------------------+--------------------+----------+
|    0|[0.1,0.2,0.3,0.4,...|[52.5097295377110...|[1.0,1.1880726027...|       0.0|
|    0|[0.1,0.2,0.3,0.4,...|[52.5097295377110...|[1.0,1.1880726027...|       0.0|
|    1|[0.1,0.5,0.3,0.4,...|[22.9478511752010...|[4.03649486150668...|       1.0|
|    1|[0.1,0.5,0.3,0.4,...|[22.9478511752010...|[4.03649486150668...|       1.0|
|    2|[0.1,0.2,0.8,0.4,...|[6.36424366031029...|[4.39122384367774...|       2.0|
|    2|[0.1,0.2,0.8,0.4,...|[6.36424366031029...|[4.39122384367774...|       2.0|
+-----+--------------------+--------------------+--------------------+----------+

Does this work in your code?

RawPrediction is not probability
It's range is from -inf to inf
Softmax(raw predictions) get probabilities
It's range is from 0 to 1
Thanks!
Sent from my iPhone
On 14 Jul 2017, at 6:38 AM, Leonard Hövelmann <notifications<EMAIL_ADDRESS>wrote:
@WeichenXu123https://github.com/weichenxu123 I deleted my last comment because I wasn't quite sure, if I had no mistakes at other places. As I described above, I performed your changes in version 2.1. For small datasets, I get raw predictions, that are not in [0, 1]. You should be able to check it, using this small test case:
import org.apache.spark.ml.classification.MultilayerPerceptronClassifier
import org.apache.spark.ml.linalg.Vectors
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema
import org.apache.spark.sql.types.{IntegerType, StructType}
import org.apache.spark.sql.{Row, SparkSession}
/**

Created by Leonard Hövelmann (leonard.hoevelmann<EMAIL_ADDRESS>on 14.07.2017.
*/
object TestProb {

def main(args: Array[String]) = {
val spark = SparkSession.builder().master("local[*]").getOrCreate()
val rowSchema = new StructType().add("class", IntegerType).add("features", org.apache.spark.ml.linalg.SQLDataTypes.VectorType)

val testData: RDD[Row] = spark.sparkContext.parallelize(Seq(
  new GenericRowWithSchema(Array(0, Vectors.dense(Array(0.1, 0.2, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
  new GenericRowWithSchema(Array(0, Vectors.dense(Array(0.1, 0.2, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
  new GenericRowWithSchema(Array(1, Vectors.dense(Array(0.1, 0.5, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
  new GenericRowWithSchema(Array(1, Vectors.dense(Array(0.1, 0.5, 0.3, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
  new GenericRowWithSchema(Array(2, Vectors.dense(Array(0.1, 0.2, 0.8, 0.4, 0.5))), rowSchema).asInstanceOf[Row],
  new GenericRowWithSchema(Array(2, Vectors.dense(Array(0.1, 0.2, 0.8, 0.4, 0.5))), rowSchema).asInstanceOf[Row]
))

val testDataDf = spark.sqlContext.createDataFrame(testData, rowSchema)

val mlp = new MultilayerPerceptronClassifier().setFeaturesCol("features").setLabelCol("class").setLayers(Array(5, 4, 3))

val mlpModel = mlp.fit(testDataDf)

mlpModel.transform(testDataDf).show(6)

}
}
Using this, I get the following results:
+-----+--------------------+--------------------+--------------------+----------+
|class|            features|       rawPrediction|         probability|prediction|
+-----+--------------------+--------------------+--------------------+----------+
|    0|[0.1,0.2,0.3,0.4,...|[52.5097295377110...|[1.0,1.1880726027...|       0.0|
|    0|[0.1,0.2,0.3,0.4,...|[52.5097295377110...|[1.0,1.1880726027...|       0.0|
|    1|[0.1,0.5,0.3,0.4,...|[22.9478511752010...|[4.03649486150668...|       1.0|
|    1|[0.1,0.5,0.3,0.4,...|[22.9478511752010...|[4.03649486150668...|       1.0|
|    2|[0.1,0.2,0.8,0.4,...|[6.36424366031029...|[4.39122384367774...|       2.0|
|    2|[0.1,0.2,0.8,0.4,...|[6.36424366031029...|[4.39122384367774...|       2.0|
+-----+--------------------+--------------------+--------------------+----------+
Does this work in your code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/17373#issuecomment-315360925, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASWEkjtBMz-Hk6Uujc-VS1Nn5fnsPOhhks5sN27_gaJpZM4MjfvG.

Alright, thanks. But have a look at the probabilities. They aren’t in [0,1] either.

They are, I think some values are something like 4.7532244532E-10 the display truncate them.
Thanks
Sent from my iPhone
On 15 Jul 2017, at 12:35 AM, Leonard Hövelmann <notifications<EMAIL_ADDRESS>wrote:
Alright, thanks. But have a look at the probabilities. They aren’t in [0,1] either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/17373#issuecomment-315516792, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASWEklwhRnYnSO_KDKASS09NLsaw_Aq2ks5sOGvZgaJpZM4MjfvG.

Right 🙈  That explains why it works perfectly fine in with my classifier :-)

cc @jkbradley @yanboliang

Test build #79806 has started for PR 17373 at commit fb83553.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79806/
Test PASSed.

Test build #79950 has started for PR 17373 at commit 14c4c6c.

Test build #79950 has finished for PR 17373 at commit 14c4c6c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class MultilayerPerceptronClassificationModel(JavaModel, JavaClassificationModel, JavaMLWritable,

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79950/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80371 has started for PR 17373 at commit 645fdc4.

Test build #80371 has finished for PR 17373 at commit 645fdc4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80371/
Test PASSed.

Test build #80409 has started for PR 17373 at commit bcb44af.

Test build #80409 has finished for PR 17373 at commit bcb44af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80409/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80411 has started for PR 17373 at commit 0b00908.

Test build #80413 has started for PR 17373 at commit df7439e.

Test build #80411 has finished for PR 17373 at commit 0b00908.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80411/
Test FAILed.

Test build #80413 has finished for PR 17373 at commit df7439e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80413/
Test PASSed.

Thanks for the changes @WeichenXu123. I don't have any other comments @jkbradley do you want to have a look?

I think this will change the output of summary on spark.mlp in R right?

@WeichenXu123  Can you please add "[ML]" to the PR title?

cc @jkbradley Code updated, thanks!

Test build #80684 has started for PR 17373 at commit eedc647.

Test build #80684 has finished for PR 17373 at commit eedc647.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80684/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, test this please.

Test build #80689 has started for PR 17373 at commit eedc647.

Test build #80689 has finished for PR 17373 at commit eedc647.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80689/
Test PASSed.

Thinking more about the proposal about separating the classification-specific logic out of the generic Topology, it's something we should definitely do at some point, but I'm OK with leaving it as is for now.  Adding new, unused classes is probably not worth the trouble right now.  Can you please document very clearly, though, that predictRaw and raw2ProbabilityInPlace are only for classification?  Thanks!

Test build #80762 has started for PR 17373 at commit 5369b08.

Test build #80762 has finished for PR 17373 at commit 5369b08.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80762/
Test PASSed.

@felixcheung How will this affect spark.mlp in R?

@felixcheung So it do not cause bugs in sparkR, we can leave it in a separated PR ?

We can open a JIRA to track

Oh OK makes sense.  @WeichenXu123 could you please open a JIRA (linked from this task's JIRA) and CC @felixcheung on it?  Thanks!
I'll rerun tests to be safe and merge this afterwards.

Test build #3894 has started for PR 17373 at commit 5369b08.

Test build #3894 has finished for PR 17373 at commit 5369b08.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins, test this please.

Test build #80946 has started for PR 17373 at commit 5369b08.

Test build #80946 has finished for PR 17373 at commit 5369b08.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80946/
Test PASSed.

Merged build finished. Test PASSed.

Thanks!  Will merge after rerunning tests

Test build #3895 has started for PR 17373 at commit 5369b08.

Test build #3895 has finished for PR 17373 at commit 5369b08.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merging with master
Thanks @WeichenXu123 !


✨ Add option for custom singleton model (#24)

Introduce a singleton flag to allow for singleton configurations.
This allows to wrap everything into a user-defined model, while eliminating the top-level configuration name.

Codecov Report

Merging #25 (8c27018) into main (948faee) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          501       508    +7
=========================================
+ Hits           501       508    +7

Impacted Files
Coverage Δ

argdantic/core.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Import Stellargraph Fills GPU Memory

Whenever I run the line "import stellargraph", it loads 30gb into the gpu memory on the first gpu, along with half a gb on every other gpu. I've tried uninstalling it completely and reinstalling it, but it is still loading 30gb on import. We have another person on the same server and when they run "import stellargraph", nothing is loaded into gpu memory.

Compared to the initial launch of the notebook without doing anything:

We found a workaround that prevents it from loading 30gb on the first gpu by running this cell every time I start a notebook (but if I don't run this, then I get the 30gb issue again):
import tensorflow as tf
gpus = tf.config.list_physical_devices('GPU')
for gpu_instance in gpus:
tf.config.experimental.set_memory_growth(gpu_instance, True)
And this is the result:

However, it is still loading half a gb on every gpu device, which does not happen to the other person when they run the import.
Is this a known issue and/or are there any configuration flags that could've led to this issue?

I have the same problem. The bug seems not fixed yet.


mouse-based drag 'n' drop takes 5-10 pixels to start

Steps to Reproduce

Download the flutter-go sample
Run
Drag a piece onto the board
Drag a piece around the board w/ the mouse

Expected results:
The drag should happen immediately on a click 'n' drag.
Actual results:
The drag doesn't start until the mouse is moved 5-10 pixels:

Logs
There are no exceptions shown in the Debug output.
There are no analysis errors.
➜ flutter doctor -v
[✓] Flutter (Channel dev, 1.21.0-9.0.pre, on Mac OS X 10.15.6 19G73, locale en)
    • Flutter version 1.21.0-9.0.pre at /Users/csells/flutter
    • Framework revision 7c6f9dd239 (4 days ago), 2020-08-09 10:31:03 -0400
    • Engine revision 6d86e67f04
    • Dart version 2.10.0 (build 2.10.0-4.0.dev<PHONE_NUMBER>)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/csells/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.2

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.6 19G73
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      84.0.4147.125

• No issues found!

cc @goderbauer

Looks like mouse gestures are using touch slop?

Duplicate of https://github.com/flutter/flutter/issues/36381?

yep. #36381 is the same. closing this as a dup.


Remove version: WinSCP.WinSCP version 5.21.7

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/winscp/files/WinSCP/5.21.7/WinSCP-5.21.7-Setup.exe/download
Status Code: 200
(Automated message - build 897)

Close with reason: Package still available.;


Added option to store raw html in metadata when transforming

Description: Adds a store_raw_html method to the Html2Text transformer, allowing quick storage of the raw_html for future use
Issue: NA
Dependencies: NA

The raw html should already exist in the documents you loaded from AsyncHtmlLoader. If you want to store the page content in your metadata, I would recommend just doing something like the following
from langchain.document_transformers import Html2TextTransformer
from langchain.document_loaders import AsyncHtmlLoader

urls = ["https://www.espn.com", "https://lilianweng.github.io/posts/2023-06-23-agent/"]
loader = AsyncHtmlLoader(urls)
docs = loader.load()

html2text = Html2TextTransformer()
docs_transformed = html2text.transform_documents(docs)

for d, dt in zip(docs, docs_transformed):
    dt.metadata["original_page"] = d.page_content


common: fix rendering failure

In case of a problem with loading font data, there is no paint inside a text that can be rendered,
but this should not interrupt the rendering process of other paints. Now fixed.
@Issue: https://github.com/thorvg/thorvg/issues/2468

I can confirm that it fixes the Godot error issue and PR is also in the 0.14.x branch:
0f2fe0c4d41a87439149aabc8d076cca77e51137


Cannot receive stream on JS alone. Works on iOS and Android

I have a version of webrtc sdk c streaming frames out from my computer. I receive the stream on the iOS app and the Android app. The JS example does not receive any frames but I see a writeFrame() going out from the C SDK (when I connect the JS version alone). The only issue I see is the resolution I'm streaming in. It's a 1024x1024 frame. Should I specify that somewhere on the JS side? I don't see any errors on the log while connecting to the sender either.  Is this issue reproducible on your side? I have tried running the C sdk as the master and the JS sdk as the viewer, and I didn't find any issue with it.
If it's reproducible, do you mind to share the steps? Also, it would be really useful if you could share more logs from the browser's internal tool,

Chrome: chrome://webrtc-internals
Firefox: about:webrtc

There was an issue with the amazon-webrtc-sdk-c which was not an issue with Android and iOS. But JS wasn't happy with it. Seems to be working now.


First time of running Finch command after installation triggered by Github action fails in arm64 runners

Describe the bug
First time of running Finch command after installation triggered by Github action fails in arm64 runners.
Only happens at the first time before any successful command call after installation. (Failed command call doesn't help so retry doesn't work)
Only happens when it is triggerd by Github action.
Only happens in arm64 runners.
See additional contexts for more experiments.
Steps to reproduce
Run the "release-installer" workflow, or restart the workflow to run the simplified version.
Currently only the members could run them. If you are interested in reproducing this but you are not member, you could add your own self-hosted runners to your forked repo and run with them.
Expected behavior
The command should succeed.
Screenshots or logs
Simplified workflow failure: https://github.com/runfinch/finch/actions/runs/3605504495/jobs/6075968565
Run finch version
/Users/ec2-user/ar/_work/_temp/1c6f50b2-a657-4625-99f4-4b80cce4f856.sh: line 1: 57022 Killed: 9               finch version
Error: Process completed with exit code [13](https://github.com/runfinch/finch/actions/runs/3605504495/jobs/6075968565#step:8:14)7.

Additional context
Confirmed the user used by github action is "ec2-user" by printing the user in Github action.
Confirmed the path of "finch" is from "/Applications/Finch/bin/finch" by running "which" and "readlink" commands in Github action.
Here are the experiements I did.
Succeeded scenarioes:

first time of runningfinch version after installation triggered by Github action in amd64 hosts with macOS version 10/11/12/13
running "ls" triggered by Github action in arm64 hosts
After installation (not matter triggered by Github action or manual action in ssh), ssh to the host and manually run finch version.
After installation (not matter triggered by Github action or manual action in ssh), ssh to the host and manually run finch version for one time. Then run an Github action that only runs finch version in arm64 hosts.

Failed scenarioes (by same 137 error):

first time of runningfinch version after installation triggered by Github action in arm64 hosts with macOS version 11/12/13 (arm64 is not supported with macOS version 10)
Set permissions:contents:write-all in yaml. Others are same as 1.
After installation (not matter triggered by Github action or manual action in ssh), ssh to the host and manually run finch version for one time. Then run an Github action that re-installs and then runs finch version in arm64 hosts.
Add 30s sleep before running finch version and after installation in yaml. Others are same as 1.
Add retry for finch version in Github action. Others are same as 1.

Some directions for further investigation:

Try to make Finch .app to see if it can resolve. https://superuser.com/a/28400
As finch version can already reproduce the issue, which doesn't require any deep dependencies, maybe we can minimize an application to reproduce this. For example, create a cobra application with version command only, and make it a macOS installer. Try to run the version command in the workflow to see if it can be reproduced. It can't, the cause must be in the incrementals from the minimum application to the full Finch. Slightly increment the features related to version command until it can be reproduced. If it can be reproduced with the minimum application, we can probably cut tickets to Github action or Cobra.

The issue was fixed in 0.3.0


Revert "Cleanup the Web UI"

Reverts PokemonGoF/PokemonGo-Bot#488
This is currently too buggy as it is to be merged.  UI breaks everytime the screen pans, and Trainer menu doesn't open or vanishes completely.  More testing needed.

Why would you make a PR if you didn't test the code..

It's a revert...  The other code was untested...

Oh okay. No worries then ;)


Repo ownership config is not detected when the artifact name and the repo name diverged

Noticed on tikal-multijob-plugin after the artifact was renamed to jenkins-multijob-plugin, but the repo itself and the developers team name remained tikal-multijob-plugin.

I don't think this is a bug in Plugin Health Scoring. This is the normal behaviour. We expect to see the plugin artifactId used in the team name.
The plugin has some misconfigurations:

https://github.com/jenkinsci/jenkins-multijob-plugin/blob/master/pom.xml#L13
https://github.com/jenkinsci/jenkins-multijob-plugin/blob/master/pom.xml#L42-L44
https://github.com/jenkinsci/jenkins-multijob-plugin/blob/master/.github/CODEOWNERS (even GitHub complains about its content)

All those points to the "old" name.

Thank you for pointing out the old names. The repo and the team have been renamed over the weekend to match the artifact name, which was changed years ago.
I should have probably mentioned this conversation that lead to me opening this issue.

Repository names and team names can evolve over time without the artifact id changing.
An example would be ssh-slaves where it is rebranded with agents in the name, the repository is renamed and likely the team as well

So you would argue that the team should be composed of the repository name not of the artifactId @timja?
That I can understand and we can tweak the code for it.
We need to change https://github.com/jenkins-infra/plugin-health-scoring/blob/1c950c801e5bce7f6a2941862431d6f9840424e0/core/src/main/java/io/jenkins/pluginhealth/scoring/probes/CodeOwnershipProbe.java#L63 to use context.getRepositoryName() (with some other management as the method returns a Optional<String> but that's feasible.
However, I don't know when I'll be able to work on this.


PR: Add support for other plugins in File Switcher

Changes to make the fileswitcher work with the notebookplugin https://github.com/spyder-ide/spyder-notebook/issues/45

What happens when you write @ in the file switcher associated with the Notebook? That probably gives an error so we need to deactivate it in this PR too.

@ccordoba12 About the @ nothing happens, it just shows nothing as an option to select:

@ccordoba12 @dalthviz we should change the name of the plugin to just Notebook, having jupyter just takes up space.

@goanpeca :+1:

About the @ nothing happens

Great!! Less work to do ;-)

we should change the name of the plugin to just Notebook or Notebooks

Since we're going to remove the notebook header, I think it's better to leave Jupyter notebook so that people can clearly identify see what's the notebook provenance.

@ccordoba12

Since we're going to remove the notebook header, I think it's better to leave Jupyter notebook so that people can clearly identify what's the notebook provenance.

I don't see us supporting any other type of notebook so why bother, it also goe sin line with the request I made about making shorter names for all plugins,

static analysis -> linter
Jupyter notebook -> Notebooks
Ipython console -> Console etc

I agree it's a good idea to rename Jupyter notebook to Notebook before releasing 0.1. @dalthviz, please do that.
We can do the reanames for Spyder 4.0


Fix escaping of HTML special chars (<, >, &) in .toc_tokens

This should fix the problem I found in https://github.com/mkdocs/mkdocs/pull/1970. I think the tests cover all the necessary cases. (I'm a little surprised that escaping where I did works though; I guess the etree.Element.text setter used for making the HTML TOC accepts escaped or unescaped HTML special chars.)
Sorry I didn't catch this the first time around!

Looks good. As per the contributing guide, this just needs a comment in the change log under 3.2.1.


Update sbt to 1.4.5

Updates org.scala-sbt:sbt from 1.4.4 to 1.4.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #27 (6a52e34) into develop (5808866) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #27   +/-   ##
========================================
  Coverage    82.35%   82.35%
========================================
  Files            3        3
  Lines           51       51
========================================
  Hits            42       42
  Misses           9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5808866...6a52e34. Read the comment docs.


Is it possible to document computed functions too?

The title says it all really. We have our methods all nicely documented, but would like to add this documentation to our computeds as well, so people can understand what they do. Is this an option / on the roadmap?
Thanks!

It would mean evaluating the code before documenting code.
That seems a hard task.

Just for my understanding please, why would you have to evaluate the code? The computeds are named functions under the computeds key, just like the methods are. I'm not disagreeing with you as I have no idea how it works, just asking to see if i can understand and maybe work out a useful alternative if this isn't possible.

Oooooooooh! my mistake! I understand now. You are talking about computed members.
I guess I was tired.
Do you use those computed members out of your component?
As you know we do not allow to document data for instance.
I invite you to still document the computed properties in the JSDoc. hopefully vetur will help you pick it up and show it in context.
I do not see any use case yet for this feature.

@elevatebart ,
It does, thanks. However I'm not sure I agree. we tend to use computed properties as a means of creating filtered sets of things in our data, or to remove logic from the template itself. They are automatically watched which is useful, but sometimes it isn't immediately obvious what the computed member is doing without then finding the context within the template, so I find documenting them useful.
So I guess the two questions I would have for you are, why do you see that as dangerous to document? And also why do you mixins or watchers would be faster?
Thanks!

I do not debate the fact that computed properties should be documented.
As internals (used only inside the current file) they are incredibly useful and can be hard to understand.
Documenting them is then absolutely crucial.
I do not think that a component should listen to computed properties of another.
Therefore documenting it as a published API would be my concern.
Would you share a component that would expose a computed property? Even simplified. This would help me understand your use case.
Thank you

Ok, so I think we are coming at this from slightly different directions, which is where the confusion may arise.
I completely agree that a component should not listen to the computed properties of another, this is only for within a single file component.
I think the key difference in what we are discussing, is that actually our use case is a large SaaS Single Page Application, and the documentation is for internal developer use only, not as a published API document. Its so new starters and existing devs can find out what everything does etc. I'll dig out an example later today unless this covers it?
Thanks!


3D Printers Infinite Dupe

It might be handy to mod the 3D printers to remove the randomly selected item from all players instead of the using player.

Thanks for bringing this to my attention, I completely forgot about 3D printers.

Absolutely! I'd throw in a pull request for it, but binary diffs are frustrating to me and dll edits are still a bit outside of my comfort zone, haha. Wouldn't mind picking up some pointers from you on that!

Go for it! I definitely recommend playing around with modding the game, it is quite fun, and not as hard as it seems.
You use DnSpy to edit the Assembly-CSharp.dll in the /managed folder. Most of the classes you need are in the RoR2 namespace. They're named like a dev would name them, but usually after a bit of searching you can find the class you need to edit. Dll edits are somewhat easier since you literally have the source code in front of you (unlike terraria's modloader API guesswork overrides)
I recommend joining the modding discord as well: https://discord.gg/hMdjd9y
As for the issue at hand, I'm currently looking at the best way to implement the fix. So far I have 2 possible ideas:

The item is taken from all players. This however can result in griefing, which was kind of the point of this mod
Only the player using the printer pays their item, and only they get the resulting printed item. This is a lot harder to implement, but the ideal fix imo

I've implemented #1, but haven't tested as of yet.

Huh, I hadn't considered #2. If you want to do that, bypass dropping the item and put it directly into the player inventory so you don't have to redo the on pickup. That'll save you the grief of working with that.
Otherwise, you can tag the item and check for existence of that tag to know if it should duplicate to all living players or not, in case you still want people to be able to use the printer for other players (I do this occasionally in unmodded play)

That is indeed another option, but it might have implications, such as confusing the player, or breaking some code. I'll have to see how it turns out. The tag was what I had in mind for #2, I'm not sure of another way to do it. I do like the idea of individual printers, but shared items from chests/tri-shops. Thanks so much for your input!

So a summary of my previous musings from Discord on how to go about implementing #2:
In PickupIndex, you'll need to add the boolean flag for whether the pickup is private / for just the specific player, and set the default value for the constructor, then you'll need an additional constructor that lets you specify a non-default value. Since only one player picking up the item is now the special case, you'll call the new constructor with the special case for 3D Printers.
You may need to modify WritePickupIndex and ReadPickupIndex in GeneratedNetworkCode and OnSerialize and OnDeserialize in GenericPickupController to include the flag for netcode sync. If it's being silly in multiplayer, that may be why.
In ShopTerminalBehavior, SetPickupIndex sets the item that the 3D printer will drop - call the PickupIndex constructor with the boolean flag here to set it as a property of the item dropped by the printer :)

Looks like I will probably port to BepInEx and continue from there, so that will mean new repo time!

Not just a new branch to eventually replace master? 😮

Could do that, but I feel like it needs a new mod entry in thunderstore rather than having v1 and 1.0.1 be assembly edits, and then 1.2 (or 2.0?) being a BepInEx-dependent mod 🤔 Think of the children end-users!

Hm, yeah, a new thunderstore entry is fair for that. :)


New github workflows for build, test, lint

What does this change do?
This changes the CI setup to github actions, which should ensure stuff keeps working in the boinkor-net org.
Tests for the change
This is tests.
Checklist for code changes

[x] Check project test coverage remains at 100%

bors merge

bors cancel

bors merge

bors merge

bors merge
This time, for sure!


params handling

@foxdonut
I tested a bit more :-)
one thing I noticed is that with the router's toPath functions all values that are not explicitly defined in routeConfig as path values or query params will be  dropped:
https://github.com/foxdonut/meiosis/blob/bf81a4b4d82f55e03c738a427dbeaeca95567882/helpers/routing/router-helper/index.js#L48
In practice this means that in the routing example this:
// adding-a-router/src/beverage/view.jsx
Brewer

...will result in id === undefined at the brewer component for route #/coffee/c2/brewer, as currently specified.
With pick in convertToPath we should probably pass the beverage id down as a prop.

So I am using an additional utility to extract all params from the current route array
export function getRouteParams (route = []) {
  let res = {}

  for (const segment of route) Object.assign(res, segment.params)

  return res
}

... and then in the brewer module
// brewer/service.js

import O from 'patchinko/constant'

import { findRouteSegment, getRouteParams } from '../util/routing-state-helpers'
import { whenPresent } from '../util'

export function service ({ state, update }) {
  const params = getRouteParams(state.route.current)

  whenPresent(
    findRouteSegment('Brewer', state.route.arrive),
    arrive => {
      const id = params.id
      console.debug('[service :: brewer]', 'Set beverage', id, ' brewer description')
      update({ brewer: O({ [id]: 'Brewer of beverage ' + id }) })
    }
  )

  whenPresent(
    findRouteSegment('Brewer', state.route.leave),
    leave => {
      const id = params.id
      console.debug('[service :: brewer]', 'Tear down beverage', id, ' brewer description')
      update({ brewer: O({ [id]: O }) })
    }
  )
}

... and then in the Brewer component
// brewer/view.js

import { createElement as el } from '../util/render'

export function Brewer ({ state, actions, routing, beverage }) {

  return (
    el('div',
      null,
      state.brewer[ beverage ],

      el('button',
        {
          className: 'btn',
          onClick: () =>
            actions.navigateTo(routing.parentRoute())
        },
        'x'
      )
    )
  )
}

... which gets passed the beverage id as a prop from the Beverage parent component
// beverage/view.js

import { createElement as el } from '../util/render'

import { Brewer } from '../brewer/view'
import { Route } from '../routes'
import { router } from '../router'

const componentMap = { Brewer }

export function Beverage ({ state, actions, routing }) {
  const Component =
    componentMap[ routing.childSegment.id ]

  const id = // beverage id
    routing.localSegment.params.id

  return (
    el('div',
      null,
      el('div',
        null,
        state.beverage[ id ]
      ),

      el('div',
        null,
        el('a',
          { href: router.toPath(routing.childRoute([ Route.Brewer() ])) },
          'Brewer'
        )
      ),

      Component &&
        el(Component, {
          state,
          actions,
          routing: routing.next(),
          beverage: id }),

      el('div',
        null,
        el('a',
          { href: router.toPath(routing.siblingRoute([ Route.Beverages() ])) },
          'Back to list'
        )
      )
    )
  )
}

🤔 an alternative would be to make the parent route params available on the child routes:
// helpers/routing/router-helper/index.js

export function createRouteMap (
  routesConfig = {},
  path = '',
  fn = () => [],
  acc = {},
  parentParams = [] // <- new
) {
  return Object
    .entries(routesConfig)
    .reduce((result, [ id, config ]) => {
      const [ configPath, children ] = getConfig(config)

      const routeParams = findPathParams(configPath).concat(parentParams, findQueryParams(configPath))
      const localPath = path + getPathWithoutQuery(configPath)

      function createRoute (params) {
        return fn(params).concat({ id, params: pick(routeParams, params) })
      }

      result[localPath] = createRoute

      createRouteMap(children, localPath, createRoute, result, routeParams) // <- routeParams as parentParams

      return result
    }, acc)
}

That way with an url path pattern like #/coffee/:id/brewer, :id would automatically also become available as a param for the brewer child route in state:
// state for location.hash === '#/beer/c2/brewer'
{
 /* ... */
  route: {
    current: [ { id: 'Beer', params: {} }, { id: 'Beverage', { id: 'b2'} }, { id: 'Brewer, { id: 'b2' } } ],
  }
}

I am not sure if auto insertion is what one would expect in all situations though. 🤔
After a bit more testing, everything else seems to be going very smooth. This routing solution is fantasic.
The only other thing that comes to mind, is that the routes and router modules could probably be consolidated into a single module. (not easy in this particular instance because of how you isolated the business logic in common-core - very clever btw)
Also router.locationBarSync could be a service function as well, couldn't it? That would keep the index.js a bit leaner.
Last but not least, also in index.js
/* ... */
import { createApp } from './app'
import { router } from './router'

const app = createApp(router.parsePath(window.location.hash))
/* ... */

... would land you right at your destination.
Also, ping me if you want help writing up the docs.

Alright, found one other gotcha when working with query params, in general:
When changing query params in the browser bar it is possible that state.route.arrive and state.route.leave both reference the same route at the same time. This may require to be more specific when relying on route states, e. g. in a service.
So for example leave assertion in case of the brewer service it would look something like this:
  whenPresent(
    ((!brewerArrive && brewerLeave) ? brewerLeave : null),
    leave => {
      const id = params.id
      console.debug('[service :: brewer]', 'Tear down beverage', id, ' brewer description')
      update({ brewer: O({ [id]: O }) })
    }
  )

Playing a bit more with automatically passing down params to child routes, I think the mechanism should only apply to path params and not include query strings
Here is an updated version of the createRouteMap functions that reflects that:
// helpers/routing/router-helper/index.js

export function createRouteMap (
  routesConfig = {},
  path = '',
  fn = () => [],
  acc = {},
  parentParams = []
) {
  return Object
    .entries(routesConfig)
    .reduce((result, [ id, config ]) => {
      const [ configPath, children ] = getConfig(config)

      // const localPath = path + configPath
      const pathParams = parentParams.concat(findPathParams(configPath))
      const routeParams =
        [ ...new Set(pathParams.concat(findQueryParams(configPath))) ]
      const localPath = path + getPathWithoutQuery(configPath)

      function createRoute (params) {
        return fn(params).concat({ id, params: pick(routeParams, params) })
      }

      result[localPath] = createRoute

      createRouteMap(children, localPath, createRoute, result, pathParams)

      return result
    }, acc)
}

@smuemd fantastic work. I am putting a lot of thought into these excellent points and I hope to have an update soon :)

@smuemd ok here is what I have:

one thing I noticed is that with the router's toPath functions all values that are not explicitly defined in routeConfig as path values or query params will be dropped
In practice this means that in the routing example this:
Brewer
...will result in id === undefined at the brewer component for route #/coffee/c2/brewer, as currently specified.

Good catch! After considering passing parent parameters down to child routes, I'm thinking it might be preferable to keep routes "deterministic", so to speak, in that each route segment indicates precisely which parameters they want.
So, I've added a way in the route config to indicate which parameters a route segment wants to receive from parent routes:
const beverageRoutes = {
  Beverages: "",
  Beverage: [
    "/:id",
    {
      Brewer: ["/brewer", ["id"]]
    }
  ]
};

An array of parameters to receive from parent routes. That way, you can still be precise with route parameters for each segment.
Now a config can be:

key: path
key: [path, childConfig]
key: [path, parentParameters]
key: [path, parentParameters, childConfig]

I like how concise that is, but perhaps it is a little bit too cryptic. A more verbose and explicit config may be preferable, such as
const beverageRoutes = {
  Beverages: "",
  Beverage: {
    path: "/:id",
    children: {
      Brewer: { path: "/brewer", parentParams: ["id"] }
    }
  }
};

With this, because the parameter is picked up from the parent, we don't need to specify it in the child route:
Brewer

When changing query params in the browser bar it is possible that state.route.arrive and state.route.leave both reference the same route at the same time. This may require to be more specific when relying on route states, e. g. in a service.

Without getting all parent params and instead just the ones you specify, that should help avoiding a false route change. It's still possible to get the same route in arrive and leave, but that is legitimate, such as when going directly from one brewer to another. The service can both clean up the id that we left, and the id at which we are arriving:
export const service = ({ state, update }) => {
  whenPresent(findRouteSegment(state.route.arrive, "Brewer"), arrive => {
    const id = arrive.params.id;
    update({ brewer: O({ [id]: `Brewer of beverage ${id}` }) });
  });

  whenPresent(findRouteSegment(state.route.leave, "Brewer"), leave => {
    const id = leave.params.id;
    update({ brewer: O({ [id]: O }) });
  });
};

The only other thing that comes to mind, is that the routes and router modules could probably be consolidated into a single module. (not easy in this particular instance because of how you isolated the business logic in common-core - very clever btw)

Indeed, my example is somewhat particular because of what you've indicated, that I'm isolating and re-using code in common-core. In an app where that is not necessary, some consolidation can certainly be done.

Also router.locationBarSync could be a service function as well, couldn't it? That would keep the index.js a bit leaner.

I did have it as a service initally, but then I ran into a chicken-and-egg problem. I think that is no longer the case, I'll verify if I can reorganize that.

Last but not least, also in index.js
/* ... */
import { createApp } from './app'
import { router } from './router'

const app = createApp(router.parsePath(window.location.hash))
/* ... */

... would land you right at your destination.

I already have
const app = createApp(router.initialRoute);

which arrives directly at the url... did I misunderstand?

After a bit more testing, everything else seems to be going very smooth. This routing solution is fantastic.

That is really great to hear. Thank you so much for trying this out, testing scenarios, and sharing your ideas, it's very helpful and much appreciated, keep them coming :)
Let me know what you think of the above. Cheers :beers:

So, I've added a way in the route config to indicate which parameters a route segment wants to receive from parent routes
An array of parameters to receive from parent routes. That way, you can still be precise with route parameters for each segment.

Brilliant. That works really well.

I like how concise that is, but perhaps it is a little bit too cryptic. A more verbose and explicit config may be preferable, such as

I would stick with the array based config. I think ledibility is fine, especially if you force yourself to always declare all three elements in an array, even if not needed
// routes/index.js

const beverageRoutesA = {
  Beverages: '',
  Beverage: [ '/:id', [], {
    Brewer: [ '/brewer?location?misc', [ 'id', 'type' ], {} ]
  } ]
}

export const routesConfig = {
  Home: '/',

  Login: '/login?returnTo',

  Settings: '/settings',

  Tea: [ '/tea', [], {
    TeaDetails: '/:id'
  } ],

  Coffee: [ '/coffee?type', [], beverageRoutesA ],

  Beer: [ '/beer?type', [], {
    Beverages: '',
    Beverage: [ '/:id?flavor', [], {
      Brewer: [ '/brewer?location?misc', [ 'id' ], {} ]
    }]
  } ]
}

☝ this is perfectly explicit

It's still possible to get the same route in arrive and leave, but that is legitimate

I agree. This is resolved by having increased the precision of passing params.

I already have const app = createApp(router.initialRoute);

Yes, I totally missed that one. False alarm here, sorry.

Thank you so much for trying this out, testing scenarios, and sharing your ideas

Yeah, a while back I was working on an app that had to heavily rely on the location bar as a data source and automatic processing (i. e. services). I felt compelled to run this against some of my pain points from then, that I still remember. The routing and service patterns have really come along way in accommodating those kind of more involved cases, without making you want to pull your hair out. It's very powerful and ergonomic, I think. Well done!

Actually, I could use some suggestions on what to use to document the API. jsdoc?

There is also ESDoc
...and Documentation.js (which uses jsdoc notation)
Mapbox uses Documentation.js. You may wanna take a look at this for inspiration. I haven't used it myself, but if I had to, I would start with consulting the mapbox implementation.


v3 mobile support

After the last update Media Extended doesn't work anymore on my Samsung S4 tablet. I tried reinstalling, but after deinstalling Media extended is not anymore compatible. I understand this might be due to technical advances. Is it possible to reinstall the prior version. This worked just great for me.
Thank you for a little help to overcome this problem in advance. And thank you for making this great piece of software.

Mobile support would be great!. Any ETA for mobile support?


cannot create docker client: unable to parse docker host /run/user/1000/podman/podman.sock

Running func deploy -b=s2i -v --build gives me the following error:
Building function image
Error: cannot create docker client: unable to parse docker host `/run/user/1000/podman/podman.sock`

here is he version I am using:
func version
v0.41.0-85-ge08155dd

Have you used unix schema? unix:////run/user/1000/podman/podman.sock

@matejvasek why was this closed? Was this fixed?

I think Matej is perhaps assuming that you have your docker host environment variable set to an absolute path rather than the one prefixed by unix:///, and that updating this would solve the issue?

@matzew did your DOCKER_HOST started with unix:// ?


Support to check whether "nonce" as a query parameter matches "nonce" claim in a request object and return appropriate error

According to FAPI-RW-5.2.3-8(https://openid.net/specs/openid-financial-api-part-2-ID2.html#public-client), FAPI-R-5.2.3-8(https://openid.net/specs/openid-financial-api-part-1-ID2.html#public-client), nonce is included in both query parameters and a request object and have the same value. keycloak need to check it and return an appropriate error.

related keycloak-jira ticket created : https://issues.jboss.org/browse/KEYCLOAK-11262

closed. https://issues.redhat.com/browse/KEYCLOAK-14204


[llvm] build failure

Host Environment

OS: Windows
Compiler: MSVC 16.9.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg install llvm[clang,clang-tools-extra,compiler-rt,default-options,default-targets,enable-abi-breaking-checks,enable-assertions,enable-bindings,enable-eh,enable-ffi,enable-rtti,enable-terminfo,enable-threads,libclc,lld,lldb,mlir,polly,tools,utils,target-all]
Failure logs
Computing installation plan...
The following packages will be built and installed:
    llvm[clang,clang-tools-extra,compiler-rt,core,default-options,default-targets,disable-abi-breaking-checks,disable-assertions,disable-clang-static-analyzer,enable-abi-breaking-checks,enable-assertions,enable-bindings,enable-eh,enable-ffi,enable-rtti,enable-terminfo,enable-threads,libclc,lld,lldb,mlir,parallel-libs,polly,target-aarch64,target-all,target-amdgpu,target-arm,target-avr,target-bpf,target-hexagon,target-lanai,target-mips,target-msp430,target-nvptx,target-powerpc,target-riscv,target-sparc,target-systemz,target-webassembly,target-x86,target-xcore,tools,utils]:x86-windows -> 11.1.0
Detecting compiler hash for triplet x86-windows...
Could not locate cached archive: C:\Users\Winterreise\AppData\Local\vcpkg\archives\0f\0fa29d11523be47a34fd14a3064bfec18d1b7300.zip
Starting package 1/1: llvm:x86-windows
Building package llvm[clang,clang-tools-extra,compiler-rt,core,default-options,default-targets,disable-abi-breaking-checks,disable-assertions,disable-clang-static-analyzer,enable-abi-breaking-checks,enable-assertions,enable-bindings,enable-eh,enable-ffi,enable-rtti,enable-terminfo,enable-threads,libclc,lld,lldb,mlir,parallel-libs,polly,target-aarch64,target-all,target-amdgpu,target-arm,target-avr,target-bpf,target-hexagon,target-lanai,target-mips,target-msp430,target-nvptx,target-powerpc,target-riscv,target-sparc,target-systemz,target-webassembly,target-x86,target-xcore,tools,utils]:x86-windows...
-- Note: llvm only supports static library linkage. Building static library.
-- Using cached C:/vcpkg/downloads/llvm-llvm-project-llvmorg-11.1.0.tar.gz
-- Cleaning sources at C:/vcpkg/buildtrees/llvm/src/org-11.1.0-a960fe6a14.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/downloads/llvm-llvm-project-llvmorg-11.1.0.tar.gz
-- Applying patch 0001-add-msvc-options.patch
-- Applying patch 0002-fix-install-paths.patch
-- Applying patch 0003-fix-openmp-debug.patch
-- Applying patch 0004-fix-dr-1734.patch
-- Applying patch 0005-fix-tools-path.patch
-- Applying patch 0006-workaround-msvc-bug.patch
-- Applying patch 0007-fix-compiler-rt-install-path.patch
-- Applying patch 0008-fix-libcxx-install.patch
-- Applying patch 0009-fix-tools-install-path.patch
-- Using source at C:/vcpkg/buildtrees/llvm/src/org-11.1.0-a960fe6a14.clean
-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
    Command failed: ninja -v
    Working Directory: C:/vcpkg/buildtrees/llvm/x86-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\vcpkg\buildtrees\llvm\config-x86-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:324 (vcpkg_execute_required_process)
  ports/llvm/portfile.cmake:198 (vcpkg_configure_cmake)
  scripts/ports.cmake:142 (include)

Error: Building package llvm:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: llvm:x86-windows
  Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

Additionally, attach any relevant sections from the log files above.

Additional context
The log file is here, it complains libffi is not found. However, libffi is installed by vcpkg successfully.
config-x86-windows-out.log

./vcpkg install llvm[clang,clang-tools-extra,compiler-rt,default-options,default-targets,enable-abi-breaking-checks,enable-assertions,enable-bindings,enable-eh,enable-rtti,enable-terminfo,enable-threads,libclc,lld,lldb,mlir,polly,tools,utils,target-all]
What happens when you run this?
If this works, then the issue is with enable-ffi and the bugreport can be made much smaller.
Is there a successful build with x64 BTW? If there is a successful build with x64 with enable-ffi, while it fails with x86, then we could further refine the issue

@pratikpc
I try to run vcpkg install llvm[enable-ffi] and vcpkg install llvm[enable-ffi]:x64-windows, they both fail with the same error. So I think the option enable-ffi does not work on Windows now.

@tan-wei does it get build without ffi?
Maybe it would get fixed or patched when it gets updated to 12

@pratikpc  Thanks, seems ok if enable-ffi is off. Thanks. The issue should be closed if LLVM 12.0.0 is out in vcpkg.

Hi @tan-wei and @pratikpc
llvm has been updated to 12.0.0 in vcpkg now, please try to update vcpkg to the latest commit to rebuild this.

@NancyLi1013 OK, thanks very much. I'll try it soon.

Confirmed. Thanks very much!


Remove credentials out of URLs from all conda output

When spark.conda.verbosity is more than 0, channel URLs might be printed unsanitised, which can include credentials / auth tokens.
We should preprocess the logs, parsing out any:

basic auth e.g<EMAIL_ADDRESS>tokens in the URL e.g. https://.../t/token-contents/

@dansanduleac Is this ticket closable with https://github.com/palantir/spark/pull/185?


Plans supported by prefetch_related

prefetch_related is helpful in many situations, is there a plan to support it?

You have select_related that works for both ForeignKey and ManyToMany relations. It's fetching the related models in the same query (same db call) and populating the result with nested models.

Is this something you mean? Maybe the documentation is not clear, let me know.

I need to try it later. Yes, the documentation could be clearer, because in Django select_related and prefetch_related are different.

Ah yeah, I think I will add prefetch_related (unless you want to create a PR, always welcome).
Right now select_related works in line with django meaning that one join is created and one query is run -> later all related models are extracted and you get a main model with populated nested models.
The difference is that in django select_related can be used only on ForeignKey relation while select_related in ormar can be used on a relation, reverse relation (so virtual foreign key -> second side of the relation) and on many2many relation. But select_related returns a QuerySet and is only run after you issue all(), get() etc.
prefetch_related should be probably implemented in a way that it's an end point (like all() - needs to be awaited).
But even without prefetch_related you can load related models for two out of 3 relation types:

for related ForeignKey item you can load related model by await Model.related_name.load()
for ManyToMany items the relation exposes most of the QuerySet api, so you can run await Model.many_to_many_name.all()
currently there is no way to load reverse relation (second side of the ForeignKey). You can add and remove items, but this is not persisted in a database and no way to load items like this. Was planning to add save_related or something that will go through all nested models and save them if they are not saved yet (status of save is also not yet implemented)

Good idea, thanks.

Thanks for the detailed answer, but i can't post a pr yet because I'm not familiar with the ormar implementation, or can you explain in the dev docs the proper way to get into the project and contribute?

OK, it took more time and was quite a lot more complicated than I initially thought but should be closed in #54.
In the end I decided to implement it working the same as django, so it's called exactly the same as select_related and returns a QuerySet.
It supports fields, exclude_fields and order_by QuerySet methods, others are called on the original/initial query anyway.
When select related and prefetch_related are called on the same related model always select_related prevails, as prefetch_related is called on a result returned from select_related.
More details in the docs.
Loading children of already loaded models will be handled in #50 (for reverse FK, other already working).

Wow, very efficient, can't wait to try it!


yearn-v2: Fantom transaction returns incorrect result if reverted

If a transaction contains a function-scoped revert, trace_transaction fails to calculate the output of the subtraces after the revert that are part of the same transaction. It also seems to be setting gasUsed to 0 for all traces after the revert. This issue applies to the other tracing calls as well.
Ref Issue: https://github.com/Fantom-foundation/go-opera/issues/288
Subgraph URL - https://thegraph.com/hosted-service/subgraph/messari/yearn-v2-fantom
Subgraph failed with non-deterministic error: failed to process trigger: block #21041413 (0x0000…b378), transaction
a44fa1857fa5448419ff94682de1ffeccaa74eb0d6dc9d0de8fe37c6c2a90746: Decoding function outputs for the call
Function { name: "withdraw", inputs: [], outputs: [Param { name: "", kind: Uint(256), internal_type: None }],
constant: None, state_mutability: NonPayable } failed, raw output: : Invalid name: please ensure the contract
 and method you're calling exist! failed to decode empty bytes. if you're using jsonrpc this is likely due to
jsonrpc returning `0x` in case contract or method don't exist

Is this still an issue? Seems like fantom closed their ticket

Tried this again and it failed again, so will be in the backlog


Rename docker-compose.{dev,make}.yml

This avoid the confusion that the docker compose file could be used for
development.

Merged via d8a41d5


Add SmartCoin

Thanks Joe Team!
Contract: 0xCC2f1d827b18321254223dF4e84dE399D9Ff116c
Logo: https://raw.githubusercontent.com/jeanclaudevanbammm/joe-tokenlists/add-smartcoin/logos/0xCC2f1d827b18321254223dF4e84dE399D9Ff116c/logo.png

added logo


documentation link is down

Hi, thanks for the code. The documentation link is broken, could you please update it?

It's broken because he updated his username, and the link is a github page with his username in the url.
The new link is this.

It's broken because he updated his username, and the link is a github page with his username in the url.
The new link is this.

Thanks!


Saving the output of detected objects in file

Click to expand!
Issue Type
Build/Install
Source
source
Tensorflow Version
tf 2.8
Custom Code
No
OS Platform and Distribution
Windows 10
Mobile device
Android
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I would like to save the output of detected objects in a .txt file in my android phone.
It should be like that whenever I detect some objects, they are saved in a file in android, what would be the best aproach to resolving this issue ?

Standalone code to reproduce the issue
How to save the output of the detected objects in android ?

Relevant log output
No response

Hi @DemoLV !
You can  append the prediction outputs into a  json file.  Attached relevant threads for reference. 1, 2 (Append to Json file).  Please post on TF forum for further assistance.
Thank you!

Yes, I posted this issue on TF forum.
Thank you for the assistance !

@DemoLV !
Could you close this issue here then.
Thank you!


Add example Apps in additional languages

Great thank you @dsharma522!!

Merged https://github.com/mattermost/mattermost-plugin-apps/pull/352

Reopening to use as a sticky issue

I don't know if there is a shortcut to pin/unpin that I pressed unintendedly, but I didn't want to unpin this xD

Moved this to https://github.com/mattermost/mattermost-plugin-apps/issues/351, but I'll keep this open for visibility


Adding nikolovlazar.com

Portfolio Author
Lazar Nikolov
Portfolio Link?
nikolovlazar.com
GitHub Link:
nikolovlazar/nikolovlazar.com
Tech Stack

Next.js
Chakra UI
MDX
Prisma
PlanetScale

Thanks, @Evavic44! I've resolved the conflicts 🙌


Fib 21849 update edge rewrite

Update node version, npm packages and serverless config
Add package-lock.json to version control

Apologies, sent to upstream instead of fork


drop privileges before running docker-run.sh

This PR includes #52 and additionally also reverts to dropping privileges instead of running the bridge as root.
In contrast to the old behavior it is possible to specify a custom uid via docker run --user to circumvent the hardcoded user.
See https://matrix.to/#/!uOjvskgRfNgksdiArw:sorunome.de/$4pIRr1ypKnlyWvu9mehn7E8GHsdqUItiMB5peubEajI?via=sorunome.de&via=matrix.org&via=privacytools.io for a more detailed discussion about it

@paulbdavis Does this work for you?


Docs: Add more documentation on creating API routes

Which scope/s are relevant/related to the feature request?
Docs
Information
The docs are pretty limited on what you can do with API routes.

API routes are file-based and support reload on changes
API routes support static paths, dynamic params, and catch-all routes
API routes support GET/POST/PUT/PATCH and more requests

Some examples in the Nitro docs
https://nitro.unjs.io/guide/routing#filesystem-routing
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

I can take it

hi @deepakrudrapaul are you working on this? if not i might have the time to put something together

Hi @luishcastroc, yes i am working on this


resultset displaying issue

Description
this is the actual, whole resultset of a query:

with the below settings:

if, by the time the query initially executed, the resultset window is smaller (the row count that fits into it) than as many row is set in the "ResultSet fetch size" config (and the full resultset is bigger than "ResultSet fetch size" (12<20<25):

and then you start scrolling down (fetch more records), then DBeaver keeps fetching records endlessly, and repeats the same records over and over again.

DBeaver Version
community, <IP_ADDRESS>404211624
Operating System
windows 11
Database and driver

Teradata <IP_ADDRESS>
Teradata JDBC Driver <IP_ADDRESS>

Steps to reproduce
see description
if any of the listed conditions don't meet the issue does not arise.
Additional context
No response

hi @ShadelessFox,
then I lose the possibility to fetch the records incrementally.

I believe the RECURSIVE clause causes this. Try putting the LIMIT clause in the outer query.

@ShadelessFox, this query was just for demonstrative purposes, it behaves like this with simple "select * from table" as well.

Sorry, I can't reproduce this exact scenario.
By default, DBeaver fetches rows until the entire screen is filled with data. This can be turned off as demonstrated here: https://github.com/dbeaver/dbeaver/issues/29930#issuecomment-2098279210
To be able to fetch next pages of data, you might need to enable such an option here:

So that you can access it from the toolbar:

well, according to my experience DBeaver fetches data until it reaches the record count that is set here (does not depend on window size):

yes, this Fetch Next Page equals with scrolling down with Auto-fetch next segment turned on and the issue appears with this as well.
However, I tried the same thing with an Oracle connection and it worked fine, so it is a Teradata related bug. Also what I noticed as a difference:

even with this setting turned on

with an Oracle connection the queries do not get extended with FETCH FIRST x ROWS ONLY (this is the oracle syntax for LIMIT)
while with a Teradata connection they do get extended with TOP x (Teradata syntax for LIMIT)


I 💗 your screenshot!

Thank you for posting a screenshot in your readme!
You did a better job than I did on the interface.  I too don't play Wordle so I'm pretty clueless about it.  You'll find a simple version I did here:
https://pysimplegui.trinket.io/demo-programs#/games/wordle
It doesn't include the fancy "used letter" portion of the interface like yours does.  Very nice touch in your UI!

To answer your license question....
You're free to redistribute PySimpleGUI with your code if needed.  Generally, it's not needed since you can make a requreiments.txt file that will install PySimpleGUI or provide instructions in your readme.
The only licensing requirement for using an LGPL3 licensed piece of open source software is around posting a notification.  The LGPL and most of the others include the statement:

Give prominent notice with each copy of the Combined Work that the Library is used in it and that the Library and its use are covered by this License.

Thank you for caring enough to ask!

Thank you for the input! I tried googling this but couldn’t find an answer, so: what would be the most appropriate place to include this notice? An about screen in the app’s UI? The readme? Somewhere else?

The readme is perfect


[stdlib] Fix assertion failures in SwiftRuntimeTests (aka unittests/runtime).

@swift-ci please smoke test


Wifi configuration interface

Hi, when I flash the WifiBlinky example, the example works but I can't ever see a wifi configuration interface, i.e. if I connect to the ESP8266's wifi, and then go to <IP_ADDRESS>, no website is loaded (empty page or no response). I was wondering if it would be possible to add something like the WifiManager (https://github.com/tzapu/WiFiManager/) in order to set up wifi when I go to a different place? Thanks.

I guess the wifi capture interface doesn't work, at least for me. So if I start Esparto in an environment with only unknown Wifi networks, I can connect to it, but the displayed website on <IP_ADDRESS> is completely blank. But when I insert the wifi credentials in the sketch, then it connects and if I then go to the ESP's IP, I can see the interface just fine. However, I was hoping not to need to re-flash every time I move the device.


Create a styleguide for our public API

Library Affected:
all
We need to decide on, for instance, positional vs. desctructured parameters for specific types of methods.
It would also be good to document our naming conventions.

WIP: https://docs.google.com/document/d/1YQFbCIAkN2mxROLbAG_sariUUx21jkAhCErbUdw98mY/edit

Everyone should be able to edit / comment.
I took a first pass, take a look and see what you think.

👍  to your first pass. Seems like a good approach.

Moved to wiki:

Styleguide: https://github.com/GoogleChrome/workbox/wiki/V3-:-Styleguide
Node Support: https://github.com/GoogleChrome/workbox/wiki/V3-:-Node-Support


lcov version 2.1 breaks coverage report

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (c8db1e4 2024-06-27T00:18:32.026850000Z)
What command(s) is the bug in?
forge coverage --report lcov && genhtml lcov.info -o report --branch-coverage
Operating System
macOS (Apple Silicon)
Describe the bug
When trying to generate an HTML coverage report based on the lcov.info that forge coverage --report lcov outputs, the following error occurs:
Wrote LCOV report.
lcov: ERROR: (inconsistent) "src/MyContract.sol":49:  function MyContract. found on line but no corresponding 'line' coverage data point.  Cannot derive function end line.  See lcovrc man entry for 'derive_function_end_line'.
 (use "lcov --ignore-errors inconsistent ..." to bypass this error)

This problem happens if you install lcov using Homebrew on MacOS, which currently installs lcov version 2.1.
When downgrading to lcov version 1.16, this problem goes away.
To reproduce error:
brew install lcov
forge coverage --report lcov && genhtml lcov.info -o report --branch-coverage

To get around the error:
Downgrade lcov to version 1.16.

I think you can just forge coverage --report lcov && genhtml lcov.info -o report --rc lcov_branch_coverage=1 derive_function_end_line=0 as derive_function_end_line is enabled by default in lcov 2.1

I've fixed the issue with the following command:
forge coverage --no-match-path 'test/invariant/**/*.sol' --report lcov && lcov --extract lcov.info --rc lcov_branch_coverage=1 --rc derive_function_end_line=0 -o lcov.info 'src/*' && genhtml lcov.info --rc branch_coverage=1 --rc derive_function_end_line=0 -o coverage
Locally I'm running:

lcov: LCOV version 2.1-1
genhtml: LCOV version 2.1-1

awesome, thanks for confirming, not sure if there's any code change we should do here or only document options to run coverage using LCOV versions > 1.16 (as lcov did for their tests backward compatibility https://github.com/linux-test-project/lcov/commit/2bfaf3da897bd8c97acbaa94bb5038fa4692c3f5#diff-bc9ca225569a229568d59f0551dc13b2fb4aa27b6815d0903adac1c17ba0899eR6-R8) @mattsse @DaniPopes @klkvr wdyt? thanks

makes sense to me!

Docs updated with https://github.com/foundry-rs/book/pull/1237

This is fixed with https://github.com/foundry-rs/foundry/pull/9438.


[PE-D] UG mentions command that does not exist

findtgall is not an actual command. Moreover, sentence does not end with a period.

Labels: type.DocumentationBug severity.Low
original: lawwm/ped#7

Same issue as #147