Functions added to Rectangle, and less verbose enums

Resolves #8
I experimented with using CTFE to generate new versions of the enums. Realizing that I can't add aliases to existing enum members this way, I ended up just directly writing shorter identifiers in package.d alongside the existing overly-verbose ones. I left the CTFE function in there just in case you want to see.
I also added functions to Rectangle for convenience. These are to get the corners of the rectangle as a Vector2. There are also operator overloads for offsetting a rectangle by a Vector2.
Originally, I was going to include some D ports of the official Raylib examples, before seeing the existing repository for these examples. Perhaps we should consider merging them into here, with a format that can be found in previous commits on my repository in the examples directory.
If I can figure out a way to generate them, I may later make a commit to add overloads of some functions. (#48)

Hi Liam, thanks for the PR. I'm not ignoring you, I just haven't had any time to look at this kind of stuff.
I promise I will take a look at some point...

I'm sorry to say Steven, but you're falling behind. With the commits I'm about to add, my own repository might as well be the "standard" D binding for Raylib if it doesn't get merged into yours. Unfortunately, the number of changes you will need to catch up on is about to increase.
If there's any D programmers that you trust with this repository, perhaps you should add permission for them to approve pull requests.

@schveiguy While the features added in this fork are so far rather small, I plan to make some more commits soon. If you don't merge it very soon, the number of changes are likely to pile up, and there will be more for you to review.
Do you need me to put the new changes on another branch with a separate pull request?
If you don't have time to review merge requests, perhaps you should add repo permission for an experienced D programmer who you trust with this.

I have some updates to share on what I have worked on. I haven't committed everything that I have tried, as I didn't want to make any commits that cause Raylib-D to to stop functioning, so much of it has remained on my own computer. However, you can see look in the string-overloads branch to see my almost-working attempt to add something new. I will explain what I have been trying to do on this branch, and the problems I faced.
The new thing I intended to add are overloads of existing Raylib functions which take D strings instead of C strings as arguments. A difficulty with this was that D string literals are already accepted by the existing C functions. This meant that when the functions were called using a string literal, the compiler would complain that the call matches both versions of the function. The solution I found was to change string in the function parameters to ref string, so that literals would go to the old function. However, this sometimes caused errors that I didn't know how to explain.
Most of the function overloads I added are generated using a CTFE function, which uses string concatenation to generate the new functions. The RayGUI example currently has betterC in the build options. Unfortunately, this results in string concatenation not being allowed; not even during compile-time function evaluation! This means that a build error would happen when building with betterC. It reports use of "TypeInfo" being the problem in the build output, but Rikki Cattermole told me that string concatenation is the problem. A temporary solution I added was to make the new overloads unavailable in the betterC builds using version (D_TypeInfo).
I just became aware of the betterC build option. I wonder how much benefit it adds. Would it be best to just remove it from the Raygui example? Right now I just made two separate build configurations for it; one with betterC and one without.
After all this trouble, I decided to make an attempt to simply port some Raylib functions into D. This is in the [port-function](https://github.com/LiamM32/raylib-d/tree/port-functions) branch. I know that @schveiguy has a "draylib" repository to port Raylib into D, but I think that instead of porting all of it, a better near-term goal would be to only port functions that involve strings, while not being equivalent to any Phobos functions. I already ported "DrawText" and "DrawTextEx" with good results from the little testing I have done.

Do you need me to put the new changes on another branch with a separate pull request?

So sorry for being late on this. I'll take a look tonight to see what you have done here. I know not having feedback is frustrating.

I just became aware of the betterC build option. I wonder how much benefit it adds.

This was requested by a user on the discord. Given that raylib-d is a simple wrapper around a C library, it makes sense that betterC is achievable (and it was with a couple of insignificant changes).
If there are things that you are using that are not betterC compatible, you can add them with version(D_BetterC) else {/* your code here */}. It would make sense that if you want to use a more D-like experience, you should have to eschew using betterC.

Unfortunately, this results in string concatenation not being allowed; not even during compile-time function evaluation!

There is one trick to make a function CTFE only -- assign the result of an immediately-called lambda to an enum:
string notGoodForBetterC()(string x, string y) {
    string result;
    result ~= x;
    restul ~= ", ";
    result ~= y;
    return result;
}

enum thisDoesntWork = notGoodForBetterC("hello" , "world!");

enum thisDoesWork = (string x, string y) {
    string result;
    result ~= x;
    restul ~= ", ";
    result ~= y;
    return result;
}("hello", "world");

So I like a lot of the stuff here. The enum changes are not exactly what I was looking for, and I think you should split this into a separate PR which we can discuss separately. The Rectangle functions are awesome, and I have wanted them many many times.
What I was looking for when I wrote #8 is something that provides an alternative to the existing enums (imported separately), not replacing the enums in the original file. In other words, the generated enum should be the "better" one.

Right. I understood that, but giving them the same name is my preference. My reasoning for putting the better enums directly in the file, and generating the old ones is to encourage use of the better ones, since they can easily be seen by someone reading the file.
I found D's restrictions on enum definitions to be a huge pain. It would be so great if additional members of the same enum could be defined in different places, but it's not allowed. Further, mixins can't be placed in enum definitions. This makes things hard.

I've been thinking of turning raygui into a subpackage, so that both 3.5 and 4.0 will later be available in separate configurations.

The enum changes might work this way, but you need to make it very simple to generate new bindings, which I don't think this does. Keep in mind, all the binding files that come from raylib are automatically generated using the instructions in generating.md.

Do you think it's likely that existing enums will change?
If not, perhaps all the enums can be placed in a separate file, and the instructions can be to remove them from package.d.

Do you think it's likely that existing enums will change?

Yes
https://github.com/raysan5/raylib/pull/3733/files

Do you think it's likely that existing enums will change?

Yes
https://github.com/raysan5/raylib/pull/3733/files

Well, that's just the old "menu" button on Android, which modern Android doesn't even use. But I may have a solution that can work even if enum values change.
Perhaps we can have a dedicated script to write the enum definitions based on the current Raylib version. I don't know if CtoD can be configured for specialized purposes like this, but I think the easier solution would be to use std.json to read the enum information from raylib/parser/output/raylib_api.json, and place them in their own file. I don't think this is beyond my skill level to do.

Well, that's just the old "menu" button on Android, which modern Android doesn't even use

It's just an example. The thing is, raylib changes stuff all the time, adding enum values, removing them, changing them, etc.

Perhaps we can have a dedicated script to write the enum definitions based on the current Raylib version

Something that is automated is OK, but I am very wary of a fragile tool that needs updating when things break.
I'm still confused why we can't just generate the new enums instead of editing the file? They will still be visible to the user.
Something like:
/// map a new enum `Key` such that `KeyboardKey.KEY_A` => `Key.A`
mixin(GenerateBetterEnum!(KeyboardKey, "Key", "KEY_"));

I'm still confused why we can't just generate the new enums instead of editing the file? They will still be visible to the user.
Something like:
/// map a new enum `Key` such that `KeyboardKey.KEY_A` => `Key.A`
mixin(GenerateBetterEnum!(KeyboardKey, "Key", "KEY_"));

Well, I originally wrote that function thinking of just that. But now I think we would be better off using the names of the existing enums. Unfortunately, D requires all enums to be defined in only one place, so we can't do alias KeyboardKey.A = KeyboardKey.KEY_A; in a seperate file.

Check out this new updater program I wrote and placed in a new branch. Right now it just generates the enums and places them in a separate module, but this approach can potentially be used to generate the rest of the bindings.
The function at the end may later be used to warn the user if they have uncommitted changes to their files before overwriting them.

I am OK adding anything that is not a direct translation of C code in a separate module, as long as the binding modules are generated, and look similar to the existing system.
We can't remove existing symbols (unless raylib removes them). We can't change the meaning of them. At its heart, this is a binding with some D niceties added onto it. It should be usable as a binding first. Someone who has code that says
import raylib;

KeyboardKey k = KeyboardKey.KEY_A;

it should continue to compile.
If you can produce a tool that is effective at generating these separate modules, then I'm fine adding it, as long as the core binding isn't affected. raylib-d can grow new features and niceties, but it must retain the existing features and API.
But I'd recommend at this point, separating out these ideas into a separate PR, and we can  add the Rectangle methods now.

So I also am not an expert on git. My usual solution is to just to create  new branch and copy in the changes I want.
One thing that is unfortunate is that you have made these changes on your master branch. You should always checkout a new branch when proposing changes to an upstream repository.
This is my recommendation:
# save the original file you want to keep
cp source/raylib/raylib_types.d x.d
# create a branch so this doesn't get lost
git checkout -b savemystuff
# make sure it gets onto github
git push origin savemystuff
# delete your local master branch
git branch -d master
# make sure the upstream remote is present (optional, if you haven't done it yet)
git remote add upstream https://github.com/schveiguy/raylib-d.git
# checkout the upstream master
git checkout upstream/master
# overwrite your master branch on github.
git push origin master --force
# checkout a branch to target with this PR
git checkout -b updaterect
# copy the code you kept
cp x.d source/raylib/raylib_types.d
# commit and push this branch (edit commit message)
git commit -a
# push to your github
git push origin updaterect

and now, you can go onto github and change the source branch to this new branch (instead of master)

I am OK adding anything that is not a direct translation of C code in a separate module, as long as the binding modules are generated, and look similar to the existing system.

Are you against putting anything that's not strictly a binding to a raylib symbol inside package.d?
Unfortunately, this would really limit us, as D requires that enums are defined in only one place, and all overloads of a function are defined in the same module. I think it would be optimal to have less verbose names for enum members while still giving the enum itself the same name. I also think it would be very helpful to have overloads of Raylib functions using the same names.
Perhaps the updater script can be designed in such a way as to leave in anything extra that's added to package.d, while replacing the parts where bindings to raylib symbols are declared or defined.
This can be made to work either in sections, where certain sections of package.d are dedicated to automatically-generated bindings, while other parts are for things that are added in manually, or it can be more detailed in deciding whether a certain line should be overwritten when doing the update.
A third option is we split package.d into multiple files (like I started doing in my port-functions branch), it may be rather simple to do this, as the end of each file after the extern(C) line can be dedicated to the automatically-generated functions, while the parts above will be left intact by the updater script.
I haven't managed to get comfortable with any of the D parsing libraries, so I would probably just write my own logic in the script to determine what's to be removed and what shouldn't on update, which of course may make it somewhat sensitive to formatting.

We can't remove existing symbols (unless raylib removes them). We can't change the meaning of them. At its heart, this is a binding with some D niceties added onto it. It should be usable as a binding first. Someone who has code that says
import raylib;

KeyboardKey k = KeyboardKey.KEY_A;

it should continue to compile.

I very much agree with this. Perhaps I should write a unittest to make sure all symbols are there, so that we know if the updater script removes anything. Maybe there can even be a test program with visual results to test if it's doing what it should. I can also go over the Raylib-D examples repository to test all the examples.

If you can produce a tool that is effective at generating these separate modules, then I'm fine adding it, as long as the core binding isn't affected. raylib-d can grow new features and niceties, but it must retain the existing features and API.

Alright. Would you rather package.d be split into multiple modules based on Raylib source files (like I started doing in my port-functions branch), or keep it all inside package.d?

Are you against putting anything that's not strictly a binding to a raylib symbol inside package.d?

Yes. But I'm not against package.d importing non-binding files (see for example https://github.com/schveiguy/raylib-d/blob/master/source/raylib/package.d#L87). But a module should be the exact translation of raylib.h, with basically nothing else in it.
What I don't want is to have to run the binding generator and then have to also write complex code in the same file. D has modules, we should use them.

Unfortunately, this would really limit us, as D requires that enums are defined in only one place, and all overloads of a function are defined in the same module.

I am not clear on the issue here. What are you trying to do with enums? Overloads of functions can cross module boundaries.
In response to your other points, I think we already have package.d split into other modules. package.d imports everything, and you can add more modules to that list if you want.
In terms of rewriting raylib functions in D, I am not interested for this project. That is my other project, draylib. Overloading to allow for proper strings is fine, but should be in a separate module, like raylib_d.d or something, that you can optionally import.
The goals here are: a simple binding, with basic niceties added on. I'm not looking for a raylib-cpp style API reimagining. At least for this project. For draylib, yes, I want to make everything D-friendly.

Are you against putting anything that's not strictly a binding to a raylib symbol inside package.d?

Alright then. I'll try to put new things in other modules. The latest commit I did in my new-updater branch has the start of a script that's supposed to make the necessary edits to package.d while leaving in anything that was added, but I can change course if you want.
What do you think of the idea of adding defaults arguments to functions (such as setting the default colour to Colors.WHITE in the texture-drawing functions)? Do you consider this too much of a new thing to put in package.d?

I am not clear on the issue here. What are you trying to do with enums? Overloads of functions can cross module boundaries.
Exactly what I've already done with enums in my master branch; have both the existing extra-verbose enum members (MouseButton.MOUSE_BUTTON_LEFT) and some new shorter ones that are equivalent (MouseButton.LEFT). As far as I can tell, there is no way to partially define an enum in two separate modules.

Overloads of functions can cross module boundaries.
Can they? I got an error when I tried doing that, and I figured that it's because I'm not supposed to do that. If this isn't true, than that makes things easier.

In response to your other points, I think we already have package.d split into other modules. package.d imports everything, and you can add more modules to that list if you want.

Yay! I suppose that means they should just be deleted from package.d every time you do the automatic update?


Add GraphQL route for fetching block data

Closes #3311. This is the type signature of the GraphQL route:
type Query {
  blockData(network: String!, blockHash: Bytes!): JSONObject
}

I'm also introducing a new Store trait which maintains separation of concerns between BlockStore and SubgraphStore while replacing some clutter of generics with associated types within index-node.

Rebasing and merging.


[DISCUSSION] Introduce convention to identify private methods

I've been reading through more of Hydrogen's code and I would like to introduce the convention that the names of private methods and properties start with an underscore _.
I'm going to use the Kernel class as an example to support this convention.
Currently, Kernel defines the following methods: stderr, connect, interrupt, _execute, execute, executeWatch, complete, inspect, addWatchCallback, onShellMessage, onIOMessage, getResultObject, destroy, getGrammarForLanguage.
As a user of an instance of Kernel, I'm not interested in methods like: stderr, connect,  onShellMessage, onIOMessage, getResultObject.
We could tell Kernel users what methods they're not intended to use, by renaming them as: _stderr, _connect,  _onShellMessage, _onIOMessage, _getResultObject.
This convention not only saves time to a person that needs to learn how to use Kernel, but also it helps the person that has to refactor Kernel, because it minimises the API exposed by Kernel.

:+1:

TODO

Add a minimal coding style guide


Displacement + rotation error

Hi!
First, I would like to thank you all for this amazing tool.
I am working on a displacement applied to a shape (PIXI.Graphics()).
When the container is rotated, the shape starts "moving" randomly.
Here is the pen I have been working on
I guess it is a PIXI bug, because it doesn't occur when the filter is not applied.
Thanks for your help!
Have a nice day.
PIXI 4.5.3
Google Chrome 59.0
Mas OS Sierra 10.12.5
EDIT : I updated the pen to be sure the map is overlaping the rectangle. You might need to resize the viewport a bit to see the glitch.

Just a small note: its not important whether its TilingSprite or Sprite in dispacelement, only its transform matrix and texture matters.

Absolutely, the TilingSprite is just a remaining of my previous full code before reducing to a simple case. I used it to have a debug sprite to see what was happening when moving the displacement texture map.
The pen is now updated, thank you for your feedback.

@jbjanot I know it's been a looooong time (sorry!) but is this still an issue in the latest PIXI?

Actually, did you see in ANY renderer displacement filter that can handle the rotations of sprites? just for reference to use.

Sadly, I did not work on the project for a year or so, and I erased my codepen.
I might open it again, and I'll be more happy to leave a feedback here.
Thanks for the help.


move to krustlet org?

krustlet has moved over to https://github.com/krustlet/krustlet. Should the same be done here?

Moved to our new home 🏠


Refix len 16807

Cherry-pick from develop to master for next release.
Passed staging test.

Uhh.. though I guess this PR is merging into master, so we'll need to merge master in to develop after?

Uhh.. though I guess this PR is merging into master, so we'll need to merge master in to develop after?

I think so. Any other better solution? :)

Uhh.. though I guess this PR is merging into master, so we'll need to merge master in to develop after?

I think so. Any other better solution? :)

Nope, just making sure I understand the process.


Adding Corsican on the list of supported languages

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.901
Problem you are trying to solve
Corsican is not yet available on the list of supported languages.
Suggested solution
Hello,
I would like to contribute to this very interesting project!
That's why I translated the Weblate files in Corsican (co). The localization is now complete!
I also noticed that @cketti prepared Pull Request #7912 to add this brand new language to the list of supported languages. Great!
I look forward being able to test the localization on my Android device ;-)
Best regards,
Patriccollu.
Screenshots / Drawings / Technical details
No response

@cketti
Hello,
I would like to know when Corsican will be distributed in a future release (which one?) so that I will be able to check the localization.
As I'm newbie on this repository, feel free to tell me if I need to open a new issue for that question or raise it on the K-9 Forum.
Best regards,
Patriccollu.

The Corsican translation should be included in the next beta version, K-9 Mail 6.902.

@cketti
Great! Thank you.
Patriccollu.


Upload content under _artifacts(cluster logs) to GCS

Adding changes to support uploading of cluster logs which is available under the _rundir directory to be uploaded to the bucket.
Ref: https://github.com/kubernetes-sigs/kubetest2/blob/4799c63b607af619efc614d976272c70b6bd27cc/pkg/app/cmd.go#L213

I see one file captured but its empty - https://gcsweb.k8s.io/gcs/ppc64le-kubernetes/logs/periodic-kubernetes-containerd-e2e-node-tests-ppc64le/1853814543898120192/artifacts/_rundir/edaadad5-40de-4cbe-8550-8681d7ecf58a/logs/, can you check what is wrong?


Update to Cosmwasm v1.0.0-soon

This does not support the new features (TransactionInfo and ContractInfoQuery), but updates all dependencies so those can easily be added in follow-up PRs. (I think TransactionInfo in #608 is ready once it rebases on this)

Merged. #608 is now unblocked


Create and trigger alerts

probably don't want to check in your KEYS :)

Ah, my bad, I wanted to push it against my master @brifordwylie .


Fix proxy handling for curl in the remaining charms

Fix proxy handling for curl in the remaining charms (contrail-agent and contrail-openstack).

also please update charmhelpers in contrail-keystone-auth charm. charmhelpers must be same version in all contrail charms

@Andrey-mp Thanks a lot for the review. I rebased the changes.


Fix multiple CSS problems, mostly reported by Firefox

typo: *zoom: ...; should be zoom: ...;
outdated prefix: white-space: -moz-pre-wrap; is not required as of Firefox 3.0
outdated prefix: -moz-border-radius: ...; is not required as of Firefox 4.0
outdated prefix: -webkit-border-radius: ...; is not required as of Chrome 4.0 and Safari 5.0
outdated prefix: for background -moz-radial-gradient, -webkit-radial-gradient and -webkit-gradient is not required as of Firefox 16, Chrome 26 and Safari 6.1
wrong attribute: word-break: break-word; should be word-wrap: break-word; (this makes sense because hyphens: auto; is set)
missing prefix: add -moz-hyphens: auto;, -ms-hyphens: auto; and -webkit-hyphens: auto; to hyphens: auto; (other browser do not support auto mode)

Forgot to mention that this fixes #154

Fantastic, thank you!


pass results from depends commands to root command

Example
commands:
  build-image:
    persist_checksum: true
    checksum:
      - requirements.txt
    cmd: docker build -t img:${LETS_CHECKSUM} -f Dockerfile .

  unpack-container:
    depends: [build-image]
    cmd: |
      if [[ ${LETS_BUILD_IMAGE_CHECKSUM_CHANGED} = true ]]; then
        cid=`docker create img:${LETS_BUILD_IMAGE_CHECKSUM}`;
        docker cp ${cid}:/usr/ ./local/usr
        docker rm ${cid}
      fi

In this example, we have build-image command with persist_checksum: true. If this command runs, it will generate env LETS_CHECKSUM_CHANGED and LETS_CHECKSUM.
It would be very convenient to pass this env vars to unpack-container as build-image is in it's depends so we could use those envs in root cmd.
env vars can be named by pattern LETS_<UPPERCASED_AND_UNDERSCORED_CMD_NAME>_CHECKSUM and so on.

as a workaround we can do like
commands:
  build-image:
    persist_checksum: true
    checksum: &build-image-checksum
      - requirements.txt
    cmd: docker build -t img:${LETS_CHECKSUM} -f Dockerfile .

  unpack-container:
    depends: [build-image]
    checksum: *build-image-checksum
    persist_checksum: true
    cmd: |
      if [[ ${LETS_CHECKSUM_CHANGED} = true ]]; then
        cid=`docker create img:${LETS_CHECKSUM}`;
        docker cp ${cid}:/usr/ ./local/usr
        docker rm ${cid}
      fi

but it has some limitation - we can not split these two commands into separate files as it will break anchors and aliases


Report 37585 does not display in the browser

Tried to view report 37585.  The browser responds like it is going to display the report.  But the browser becomes blank.
I asked two other ANET users to try and display the report.  Both of their browsers were also blank.
I checked the report in the database.  I didn't see anything wrong with the report data.  I did notice one of the attendees didn't have an end of tour date.  However, when I checked other reports where an advisor attendee didn't have an end of tour date, the browser displayed the reports.

Ran the F12 debugger when loading report 37585.
The error is: Unable to get property 'className' of undefined or null reference; File: vendors.be2848b7.js, Line: 34, Column: 3852

Agreed with Vassil to first remove the current progress bar functionality in order to fix this issue. Afterwards we will replace it with a different progress bar as part of #593 .


pl update mavlink submodule

it is fantastic that version 2 just came out few days ago, sadly the mavlink submodule is 2 years old however ...
it would be great if it could be updated to the latest and freshest :)
thx

Yep, I didn't do it before release because it will probably bring bugs with it, and I didn't want to delay the release.

many thx, this was swift :+1:


reconnecting event gone?!

Why was the 'reconnecting' event removed?  We used it to better control the reconnection timeouts and behavior.  Also we now have no visibility into wether SocketIO is trying to reconnect or not.  Please put it back.

Closing this for now. Feel free to reopen if something comes up! :)


Root finder for large problems

Alan sent me a copy of this which is a clever way to calculate eigenvalues of a companion matrix. They also provide their Fortran code which I have wrapped in an unregistered package, but I think it would make sense to merge it into this package. Any objections?

Any private progress on this topic? Would be interesting to compare the KU Leuven algorithm to a8c9302;
and if there were no performance penalty, I'd opt for the faster algorithm. If you have the Fortran code running, please test against a8c9302 and if the outcome will be positive, let's consider porting to native Julia.
Also, do you have any author feedback on licensing?

Just checked my email and Watkins replied that he is fine with MIT license for the AMVW code. There is no doubt that AMVW code can handle much larger problems and I think it is faster for all problem sizes. It would be great to use the AMVW functionality for finding roots in this package. It would either require that we find a way to supply binaries of the Fortran code or port the code to Julia. Right now, I don't have much time to do any of these but if you are interested in trying it out, I can try to help.

I'd definitely opt for porting to native Julia. I will await whether my other pull requests will find their way to the pkg, then I may consider investing some work into trying and porting the AMVW code. BTW, if you have the code running (outside of Julia), can you just run few tests, what will be errors of Fortran AMVW compared to  a8c9302 roots? I mean
r=something (randn, real, complex,...)
r1=roots(poly(r))
r=sort(r, lt=(a,b)->(real(a)<real(b)||imag(a)<imag(b)))
r1=sort(r1, lt=(a,b)->(real(a)<real(b)||imag(a)<imag(b)))
e=r1-r
maximum(abs(e))

or std(e).
It would be great to assure the AMVW will not give worse results, prior to replace the very standard way using full O(n^2) companion matrix. No doubt it will be faster, though.

Your other pull request will find its way in soon. I was going to ask you to add a test, but see you've already got there. This would be a good addition in my opinion, though it might be best in an independent package at the outset.

This  was done  in https://github.com/jverzani/AMRVW.jl


Update sample ima-policy to exclude overlayfs

Since this is almost always the right default if there are containers
Signed-off-by: Michael Peters<EMAIL_ADDRESS>

Maybe add a comment why we exclude it by default. Otherwise LGTM.


Remove java and UnityPlayer changes to the windowmanager so it can be…

… fully handled by Flutter
For rendering full screen Unity with Flutter widgets on top:
return Scaffold(
  body: Stack(
  children: <Widget>[
    UnityWidget(
      onUnityViewCreated: onUnityCreated,
    ),
    Positioned(
       /// ...

For rendering a flutter app with a Unity widget inside:
return Scaffold(
  appBar: AppBar(
    title: Text('Title'),
  ),
  body: Stack(
    children: <Widget>[
      Center(
        child: SizedBox(
          height: 300,
          width: 300,
          child: UnityWidget(
            onUnityViewCreated: onUnityCreated,
          ),
        ),
      ),
      Positioned(
        /// ...

This change fixes the status bar overlapping with the AppBar.

Thanks, @thomas-stockx I had plans fixing all these when I get the time, but so far you have been actively working on it. Promise to be back fully once I am done with my project, which should be soon


Update NAVIGATION.md

The names of the solution files are not correct in your lesson so it can't build.  If you make this change it should hopefully work.

thanks I forgot to change the .md file after renaming them


Integrate with username/password auto-fill

Was reading up on changes for Android P, and it led me to file this...
https://android-developers.googleblog.com/2017/11/getting-your-android-app-ready-for.html
https://code.tutsplus.com/articles/faster-logins-with-password-autofill-in-ios-11--cms-29096
@Hixie do you think this is the domain of the framework or plugins?

The built-in text field should just support this out of the box, though we should also expose the APIs to make it possible to make custom text fields to do this.

cc @HansMuller @cbracken

May be a duplicate of #13015.

Also noted on #13015 but we should ensure we integrate correctly with the password fill functionality on iOS 11 and the upcoming changes for iOS 12.

Any updates with this feature? With so many stable version have been released... 😞

So much time passes that auto-fill has got much more capabilities then only username/passwords. Now autofill can fill dates/lists/texts/toggles with authData/email/phone/addresses/paymentInfo/etc

any updates on this?

Closing as a duplicate of https://github.com/flutter/flutter/issues/13015.  Anyone who's following or added their thumbs-up to this issue, you'll want to do the same to https://github.com/flutter/flutter/issues/13015.


resource_control: consider default as a normal group

Currently we support to config the default resource group, relative https://github.com/pingcap/tidb/pull/41606. after remove resource group, we can see the metrics:

PTAL @JmPotato @glorv @Connor1996

duplicated with #708


Be able to set different RUSTFLAGS in config file

As alluded to here https://github.com/jonhoo/left-right/pull/91 this would allow for things like a loom config and a non-loom config and configurations changing between runs.
@jonhoo

I think also this should be exposed as a CLI arg for consistency as every config file entry is a CLI arg. The question now is do we need a flag to also disable looking at the rustflags in the users environment?


Remove usages of rxscala and replace with Java based code.

Description
RxScala has been abandoned: https://github.com/ReactiveX/RxScala/issues/244. To unblock the move to Scala 2.13, this removes all usages of it and replaces it with Java interoperable code.
Related issue and scope
Ref #4741
Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).

Codecov Report

Merging #4744 into master will decrease coverage by 6.58%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4744      +/-   ##
==========================================
- Coverage   84.96%   78.37%   -6.59%
==========================================
  Files         198      198
  Lines        8827     8829       +2
  Branches      618      611       -7
==========================================
- Hits         7500     6920     -580
- Misses       1327     1909     +582

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.23%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.85%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-92.31%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-77.78%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <0%> (-50%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e567280...dec6c2e. Read the comment docs.

@chetanmeh told me to merge myself so here we go!

Why not using https://github.com/reactor/reactor-scala-extensions?

@sinwe Not sure if that matches up with our usage of reactivex here. I mostly wanted to get rid of the one dependency I removed here without changing the code too much, so this was the quickest way.

@markusthoemmes if your usage of rxscala is not that much, it's not worth to add additional dependencies. However if you use rxscala extensively and you want to keep track as it progress, e.g: scala 2.13, etc, then it's better you invest some time to replace the dependency completely with another one. There are many libraries similar to rxscala, e.g: Monix, Reactor, etc.

The code here is purely adaptor code for the CosmosDB lib though, so we have no choice other than using what they use.
OpenWhisk itself uses plain Futures and various akka libs.

Then you've done the right thing :)


Fix test of multiprocess_parallel_updater

test_multiprocess_parallel_updater does not specify appropriate test marks.

Thank you for your fixing.
I will check this.

I think it is better to place the code string as a separate file, so that flake8 can be applied. (as long as there're no side effects)

I agree, but we need a uniform convention to place such files.
e.g.

What's the directory name / file name convention?
What if .PNG files are required instead of .py files?

I think it's better to postpone to another issue.

We already have *.png in https://github.com/chainer/chainer/tree/master/tests/chainer_tests/datasets_tests/image_dataset, but I think it's OK to do that in separate PR anyway.

Oh, I see...
Then we can follow that in some way.
Anyway I'd like to seperate that in another PR, because it's essentially different topic (and the change is not trivial).

jenkins, test this please.

LGTM. I will merge soon.


KAFKA-9168: Adding direct byte buffer support to rocksdb state store

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cadonna , @guozhangwang  I ran some jmh benchmarks on this. I ran the 2 tests with G1GC and prof gc=> 1 for putAll and the other one for range query. Here are the results for putAll:
Original AK codebase

Benchmark                                                                                Mode  Cnt        Score        Error   Units
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance                                   thrpt   15       60.489 ?      2.154   ops/s
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.alloc.rate                    thrpt   15      158.731 ?      5.651  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.alloc.rate.norm               thrpt   15  2889264.628 ?     26.474    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.PS_Eden_Space           thrpt   15      160.811 ?      9.073  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.PS_Eden_Space.norm      thrpt   15  2927507.100 ? 141145.743    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.PS_Survivor_Space       thrpt   15        0.251 ?      0.145  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.PS_Survivor_Space.norm  thrpt   15     4536.878 ?   2486.338    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.count                         thrpt   15      161.000               counts
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.time

DirectByteBuffer

Benchmark                                                                                Mode  Cnt        Score        Error   Units
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance                                   thrpt   15       97.908 ?      1.820   ops/s
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.alloc.rate                    thrpt   15      256.946 ?      4.777  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.alloc.rate.norm               thrpt   15  2889553.977 ?      4.331    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Eden_Space           thrpt   15      256.202 ?     51.550  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Eden_Space.norm      thrpt   15  2879662.678 ? 563793.832    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Old_Gen              thrpt   15        0.030 ?      0.039  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Old_Gen.norm         thrpt   15      336.245 ?    437.382    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Survivor_Space       thrpt   15        0.025 ?      0.105  MB/sec
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.churn.G1_Survivor_Space.norm  thrpt   15      285.618 ?   1182.589    B/op
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.count                         thrpt   15       33.000               counts
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance:?gc.time                          thrpt   15      308.000                   ms

And here are the results for range:
Original AK code
Benchmark                                                                                Mode  Cnt        Score        Error   Units
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance                                   thrpt   15      117.454 ?      2.620   ops/s
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.alloc.rate                    thrpt   15      290.118 ?      6.471  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.alloc.rate.norm               thrpt   15  2719700.009 ?     32.687    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Eden_Space           thrpt   15      295.066 ?     64.171  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Eden_Space.norm      thrpt   15  2768668.326 ? 613598.308    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Old_Gen              thrpt   15        0.002 ?      0.005  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Old_Gen.norm         thrpt   15       16.068 ?     47.296    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Survivor_Space       thrpt   15        0.051 ?      0.210  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Survivor_Space.norm  thrpt   15      466.034 ?   1929.591    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.count                         thrpt   15       38.000               counts
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.time                          thrpt   15      431.000                   ms

DirectBytBuffer

Benchmark                                                                                Mode  Cnt        Score        Error   Units
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance                                   thrpt   15      114.871 ?      4.080   ops/s
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.alloc.rate                    thrpt   15      284.127 ?     10.090  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.alloc.rate.norm               thrpt   15  2723428.297 ?     33.503    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Eden_Space           thrpt   15      286.413 ?     64.054  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Eden_Space.norm      thrpt   15  2743440.651 ? 593666.103    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Old_Gen              thrpt   15        0.007 ?      0.024  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Old_Gen.norm         thrpt   15       67.053 ?    224.086    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Survivor_Space       thrpt   15        0.025 ?      0.105  MB/sec
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.churn.G1_Survivor_Space.norm  thrpt   15      239.812 ?    992.929    B/op
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.count                         thrpt   15       37.000               counts
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance:?gc.time                          thrpt   15      515.000                   ms

Throughput wise, there was a jump of 30+ ops/s for the putAll case. range performed slightly worse in the original codebase. I can change the benchmark mode to AverageTime for range query.
One thing I am noticing is that the DirectByteBuffer tests are continuously clocking higher gc allocation /gc count and gc time. You can find the benchmark related code here: https://github.com/apache/kafka/pull/10842/files.
One of my guesses is that for this to actually show some gains, the application shouldn't be making use of byte[] and allocate directly. That doesn't seem possible with the way the State stores are exposed via the DSL because finally, everything is serialised into a byte[]. What do you guys think?

@guozhangwang / @cadonna  I made some tweaks to the code and also started testing with 1M keys. Now I see differences in terms of throughput for both range and putAll queries:
Here is the compaision:
testPersistentRangeQueryPerformance original

Benchmark                                                             Mode  Cnt  Score   Error  Units
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance  thrpt   15  1.131 ? 0.028  ops/s

testPersistentPutAllPerformance original

Benchmark                                                         Mode  Cnt  Score   Error  Units
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance  thrpt   15  0.919 ? 0.037  ops/s

testPersistentRangeQueryPerformance bytebuffer
StreamsPersistentStoreBenchmark.testPersistentRangeQueryPerformance  thrpt   15  1.442 ? 0.038  ops/s

Benchmark                                                         Mode  Cnt  Score   Error  Units
StreamsPersistentStoreBenchmark.testPersistentPutAllPerformance  thrpt   15  1.065 ? 0.041  ops/s

I needed to add ByteOrder after creating DirectByteBuffer object. And for putAll, i needed to flip before calling put to batch.
Next step for me would be to create a kafka streams app and test throughput. I will post them here once i have those as well.

You were referring to this commit https://github.com/apache/kafka/pull/10798/commits/68a947c0eb6a5cc4bdde24083c83f4638e708edb as for the tweaks right?
BTW it's bit interesting to see the improvement for range is around 1.442 / 1.131 = 1.27 while for putAll it is 1.065 / 0.919 = 1.15. Given the key length to be similar in the benchmarks I was expecting latter has a bigger benefit. @cadonna WDYT?

@guozhangwang , thats the commit i was referring to. Setting a byte order and seems to have an impact on performance. Also, earlier i was calling put first and then calling flip which is wrong. So, I tweaked that.
I have another update on this piece. I created a small kafka streams app which subscribes to a single partition topic and for every record consumed, it has 2 processors: 1) putAll processor which ingests 1M records into state store and then 2). range processor which does a range query for all keys inserted.
I pushed 100 records to the topic and these 2 processors got invoked each time. Here are the numbers from that run:
DirectByteBuffer ->

Operator: putAll, Real: 80.722 CPU: 273.690 GC: 6.974 GCCount: 36 avg throughput: 1269130.717 op/s p95 throughput: 1430952.065 op/s p99 throughput: 1453862.308 op/s
Operator: range, Real: 114.511 CPU: 271.410 GC: 5.501 GCCount: 26 avg throughput: 920462.473 op/s p95 throughput: 1234215.537 op/s p99 throughput: 1588364.216 op/s

Original ->

Operator: putAll, Real: 92.988 CPU: 288.550 GC: 6.900 GCCount: 53 avg throughput: 1088404.000 op/s p95 throughput: 1233248.141 op/s p99 throughput: 1252514.840 op/s
Operator: range, Real: 110.418 CPU: 268.070 GC: 6.105 GCCount: 40 avg throughput: 957558.135 op/s p95 throughput: 1277487.581 op/s p99 throughput: 1388059.720 op/s

The way I calculate throughput is for every iteration, I divided 1M by time taken for that iteration. You can find the relevant code here:
https://github.com/vamossagar12/kafka-streams-throughputbenchmarking/tree/master/src/main/java/com/bytebyffer/benchmarks
Let me know if you and @cadonna think we need other. kinds of benchmarks.

You were referring to this commit 68a947c as for the tweaks right?
BTW it's bit interesting to see the improvement for range is around 1.442 / 1.131 = 1.27 while for putAll it is 1.065 / 0.919 = 1.15. Given the key length to be similar in the benchmarks I was expecting latter has a bigger benefit. @cadonna WDYT?

Yeah range performed better on jmh. However, for one of the runs putAll clocked around 1.095 and above. Every run it tends to give slighly different number but it's on the higher side than non byte buffer..

@guozhangwang , @cadonna  did you get a chance to look at the numbers? Any tweaks/other tests you would suggest ?

hey @guozhangwang / @cadonna .. sorry for being nosey here but did you get a chance to look at these numbers?

@cadonna , @guozhangwang  plz review the numbers whenever you get the chance...

Sorry @vamossagar12 for the late reply.. I took a look at the current PR and it looks good to me. The throughput numbers seems promising as well. Could you clean up the PR a bit while I will ping @cadonna for another look at the PR as well?

Thanks @guozhangwang , I have made changes to the PR. I think it could be reviewed now and hence moved the PR from draft to Ready to Review.

Tests failed on compilation due to checkstyle warnings:
[2021-08-28T18:29:04.088Z] > Task :streams:streams-scala:compileTestScala

[2021-08-28T18:29:04.088Z] [Warn] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10798/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamSplitTest.scala:19: imported `Named` is permanently hidden by definition of type Named in package kstream

[2021-08-28T18:29:04.088Z] [Warn] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10798/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala:24: imported `Named` is permanently hidden by definition of type Named in package kstream

[2021-08-28T18:29:04.088Z] [Warn] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10798/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KTableTest.scala:21: imported `Named` is permanently hidden by definition of type Named in package kstream

[2021-08-28T18:29:05.982Z]

[2021-08-28T18:29:05.982Z] > Task :streams:checkstyleTest

[2021-08-28T18:29:11.170Z]

[2021-08-28T18:29:11.170Z] > Task :streams:streams-scala:compileTestScala

[2021-08-28T18:29:11.170Z] three warnings found

@guozhangwang , these errors are not due to the changes in this PR:
imported Named is permanently hidden by definition of type Named in package kstream

Okay, let me re-trigger the tests.

Okay, let me re-trigger the tests.

Thanks.. This time there's a compilation error due to benchmarks. I will remove that class.

Okay, let me re-trigger the tests.

Thanks.. This time there's a compilation error due to benchmarks. I will remove that class.

@guozhangwang , i removed that. class.

Hi @vamossagar12 Thanks again for your patience! I know it has been dragging a bit long, and I had some discussions with @cadonna and @vamossagar12 regarding how we can move forward to eventually merge-in your work to Apache Kafka. As a result of that I created this ticket trying to summarize what we want to do (which would incorporate this JIRA ticket):
https://issues.apache.org/jira/browse/KAFKA-13286
At the moment, our main concerns are that:

Direct bytebuffers, which is relied on native memory, is not fully managed by the JVM (GC) and hence we need to be very careful about its side-effects regarding memory pressures.
The current implementation without the API changes on serdes has a relatively small improvement on throughput, whereas in order to use the byte-buffer without API changes, we also would need to "guess" the allocated size before serialization.

So we think it's probably better to consider tackling the larger scope of https://issues.apache.org/jira/browse/KAFKA-13286 as a whole, which would mean we would hold on merging this PR after we have the serde / byte-buffer supplier works in place. Does that sound reasonable to you? Would love to hear your thoughts.

hey @guozhangwang , that makes perfect sense to me. Based upon the discussion me and @patrickstuedi  had on this thread, I think to reap the real benefits, the optimisations listed here and on the JIRA makes sense.
We can hold off on this PR till then. Thanks!

hey @guozhangwang , that makes perfect sense to me. Based upon the discussion me and @patrickstuedi had on this thread, I think to reap the real benefits, the optimisations listed here and on the JIRA makes sense.
We can hold off on this PR till then. Thanks!

Great, thanks @vamossagar12 !

@vamossagar12 Can we close this PR and the corresponding ticket since it seems we decided to look for a more complete solution?

@cadonna , done.


MTV-1536 | Use CDI for disk transfer in cold migration

Issues:

Allow migration of "unknow" guests [1]
Right now we can't migrate an unknown and unsupported operating system which is unsupported by the virt-v2v [2].

Unifying the process and potential speedup [3]
Right now we are using two different methods for the disk transfer virt-v2v cold local migrations and CDI warm and remote migrations. This brings additional engineering for maintaining two paths. It's harder to debug two different flows.
The virt-v2v transfers the disks in the sequence whereas using the CDI we can start multiple disk imports in parallel. This can improve the migration speeds.

Fix:
Start using the CNV CDI for the disk transfer instead of virt-v2v.
MTV is already using the CNV CDI for the warm and remote migration. We just need to adjust the code to remove the virt-v2v transfer and rely on the CNV CDI to do it for us.
Drawbacks:

CNV CDI requires the VDDK, which was till now highly recommended.
CNV CDI is not maintained inside the MTV and there might be problems escalating and backporting the patches as CNV has a different release cycle.
Because we will be migrating all disks in parallel we need to optimise our migration scheduler as we don't want to take too much of the hosts/network resources. I have already done some optimisations in [4,5,6].

Notes:
This change removes the usage of virt-v2v and we will only use the virt-v2v-in-place.
Ref:
[1] https://issues.redhat.com/browse/MTV-1536
[2] https://access.redhat.com/articles/1351473
[3] https://issues.redhat.com/browse/MTV-1581
[4] https://github.com/kubev2v/forklift/pull/1088
[5] https://github.com/kubev2v/forklift/pull/1087
[6] https://github.com/kubev2v/forklift/pull/1086

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 16.33%. Comparing base (bc87852) to head (419605d).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

pkg/controller/plan/adapter/vsphere/builder.go
0.00%
9 Missing :warning:

pkg/controller/plan/scheduler/vsphere/scheduler.go
0.00%
5 Missing :warning:

pkg/controller/plan/kubevirt.go
0.00%
4 Missing :warning:

pkg/controller/plan/migration.go
0.00%
3 Missing :warning:

virt-v2v/cmd/entrypoint.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   16.20%   16.33%   +0.13%
==========================================
  Files         112      112
  Lines       19882    19719     -163
==========================================
  Hits         3222     3222
+ Misses      16375    16212     -163
  Partials      285      285

Flag
Coverage Δ

unittests
16.33% <0.00%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@rwmjones This change removes the usage of virt-v2v for disk transfer and we will only use the virt-v2v-in-place. Not sure when we will get this in, I'm aiming for the next Y release (2.8.0) as it has some changes for the users. Just wanted to let you know.

We won't be able to support this.  We only support conversions using virt-v2v.  We don't support usage of virt-v2v-in-place at all, or recommend you use it.  Basically, if you do this, you're on your own with supporting v2v.


v5 docs: example shortcode regex

example shortcode: see if we can use a regex
Fixes #29351
Preview: https://deploy-preview-29489--twbs-bootstrap.netlify.com/
/CC @morrissey-ingenious to review the last patch.

I think it would help if we added a link to a https://regex101.com/ example as a comment

@morrissey-ingenious your thoughts about the last patch?

@morrissey-ingenious can you review my last patch?

I guess I'm gonna merge this as is.


Clarifying property group changes from 1.X to 2.X

The registry plugin docs shows two different property groups for the CRI plugin for 1.X and 2.X.
In containerd 2.X:
[plugins."io.containerd.cri.v1.images".registry]
  config_path = "/etc/containerd/certs.d"

In containerd 1.X:
[plugins."io.containerd.grpc.v1.cri".registry]
   config_path = "/etc/containerd/certs.d"

Is the old property group deprecated (or just a legacy way of referencing the old plugin)?
Should I be able to continue using the 1.X property group on 2.X releases?
Are these property group changes tied to config version changes?

CC @samuelkarp

@chrishenzie  Yes containerd 2.x introduces new Version 3 configs: https://github.com/containerd/containerd/blob/main/docs/containerd-2.0.md#daemon-configuration-version-3
The registry (or the overall cri) config you referenced is part of the change from Version 2 to Version 3.

Is the old property group deprecated (or just a legacy way of referencing the old plugin)?

Only fields explicitly called out deprecation are deprecated (https://github.com/containerd/containerd/blob/main/RELEASES.md#deprecated-features)
Version 2 continues to work with containerd 2.X. containerd automatically migrate version 2 to 3 on startup.
But suggest to run the migration command to convert it and use version 3 directly. (otherwise the migration happens every time containerd starts).
https://github.com/containerd/containerd/blob/e514bae935a24e78c1e66ae4d609040b9f14a8e4/cmd/containerd/command/config.go#L108

Should I be able to continue using the 1.X property group on 2.X releases?

If you use version 2 config, it will continue to work (because of the migration logic ^)

Are these property group changes tied to config version changes?

Yes, version 2 -> version 3

Thanks for the clarification.
My repro steps above were actually wrong. It did change the property group as expected, but I copy pasted the wrong property group into the version = 2 config above.


Fix Loan Item List

Before :

After :

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.87%. Comparing base (90cdc7d) to head (c5853af).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   54.87%   54.87%
=======================================
  Files         166      166
  Lines        3665     3665
=======================================
  Hits         2011     2011
  Misses       1654     1654

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[folding] go to region command

So if we have the ctrl + g to go to line, how about we have a shortcut that will allow us to go to certain region in our code?

@hansyulian What do you mean by region? We have a lot of outline, quick outline, breadcrumbs to help navigate within a file.

the one enclosing a certain part of code like this:
//#region properties
....
//#endregion

//#region computed

//#endregion

I wonder if these regions should appear perhaps in the outline... What programming language are you using?

We have a command to close all regions (Fold all regions).
No sure how we would do that for a 'certain' region.

yea well aware of the fold all regions, but wonder would it be feasible if we have a better way to navigate between region? for example a region navigator floating window, or shortcut to go to a certain region

From #51364, I'm in favor of adding built-in support for displaying regions in the outline view

I would also like to see regions in the outline view.

I also want it to apear on VS Code. I really need that of thing. It's make the code easier to navigate!

I want to be able to sort and go to the symbols in the symbol navigator by region (ctrl P + type @), perhaps typing "@>" or something like that, and have this support nested regions! 🙏

I want to be able to sort and go to the symbols in the symbol navigator by region (ctrl P + type @), perhaps by typing "@>" or something like that, and have this support nested regions! 🙏

We need more waiting seems like that

I'd also really like to see this implemented. In the meantime has anyone found an Extension that does this?

@adamerose I guess this hero finally took it upon himself? https://github.com/berabue/vscode-region-viewer
Right now it's allegedly only for C# regions, but I'll try extending it to JS.


feat(dateformat): add new date format for date date-time and time

PR part 1 for updating the date time utilities to use browser regions Date and time formatting should get now supplement region data from the browser.
This behavior is "feature toggled" using a cookie, called spark-enable-regional-dates. To test out the functionality, set document.cookie = 'spark-enable-regional-dates' in your console. I opened a separate browser and set the region to "en-GB"   in my system preferences. To check the region in your console, just type navigator.language. As expected, the date and time formats look different in my browser depending if I'm using en-US or en-GB regions.

PR looks good to me and tested it on different browsers 👍  I think you said you will be making changes in this PR so I will wait to approve.

Create an issue to remove the need for this new copy operation workaround.

COMUI-2598


Problems Saving Model with agent.save_model

I am implementing Tensorforce with the HalfCheetah-v1 environment in OpenAI. I was able to get the model to start learning using the sample code, but I am having some trouble using the agent.save_model and the agent.restore_model functions. I was able to get the program to start the learning, but I wanted to actually see the progress at the end of the learning period. I decided to save the model every 100 episodes using the below line of code (I have a folder named "models" in which I want to save my model files):
agent.save_model(directory=os.getcwd() + "/models")
I ran the program for 100 episodes. However, when I checked the models folder, I did not find anything, but I did find 3 files in the current directory, named models-20100.data-00000-of-00001, models-20100.index, models-20100.meta. In addition, the agent.restore_model function did not run because it did not find any files in the specified folder.
I also tried using:
agent.model.save_model(path=path, use_global_step=False)
But I got the following error:
AttributeError: 'PGProbRatioModel' object has no attribute 'save_model'
I also tried directly saving the model to a separate .ckpt file that I had already made named model.ckpt, but I still got the same three files stated above, and the .ckpt file remained empty.
My tensorforce version number is 0.3.3, and my tensorflow-gpu version number is 1.4.1.

So I just tried locally:
self.agent.save_model(directory=os.getcwd())
This creates a file for me called 'checkpoint' and the data, index and .meta files. Please verify if this file 'checkpoint' exists somewhere. If you then call restore model without a file given, it will use the checkpoint file to read from the other files, no .ckpt file is needed.

I am getting the 'checkpoint' file along with the other three files, but it is not saving it in the correct directory. I set it to save in the tensorforce-master/examples directory, but it saves it in tensorforce-master itself. I am only using agent.save_model(directory=os.getcwd); no string concatenation.

Maybe print os.getcwd and make sure you are getting the right path, alternatively explicitly specify the full absolute path to the directory you want?

The file was created in the correct directory. I used the following lines of code to save the model:
modelDir=os.path.join(os.getcwd(), "models") agent.save_model(directory=os.path.join(modelDir, "agent")) saved_agent = agent.restore_model(os.path.join(modelDir, "checkpoint"))
This worked to save the checkpoint file as well as the other three files. However, when I tried to load it, it returned with ValueError: Can't load save_path when it is None.. I checked the path, and the file is there. Do I have to put a file extension on the checkpoint file (like checkpoint.ckpt)?

I wasn't sure if it was looking for the file 'checkpoint' or the folder in which it was in. The agent.save_model seems to be creating the files, but the agent.restore_model is throwing an error: RuntimeError: Attempted to use a closed Session..
I am trying to visualize the trained model after it is done learning. Here is the code that does so:
saved_agent = agent.restore_model(os.path.join(modelDir))
env = gym.make("HalfCheetah-v1")
s = env.reset()
done = False
while not done:
env.render()
action = saved_agent.act(s)
s, r, done, _ = env.step(action)

I haven't looked into the problem yet, but could you check two things: First, if you restore the model, I don't think you have to specify the checkpoint (here: agent.restore_model(os.path.join(modelDir, "checkpoint"))). Second, the agent is not returned as a separate saved_agent value in saved_agent = agent.restore_model(os.path.join(modelDir)), but you create the agent via agent.Agent(...) and then call agent.restore_model(...) on it.

I redefined the agent again as agent007, like so:
 agent007 = Agent.from_spec(
spec=agent_config,
kwargs=dict(
states_spec=environment.states,
 actions_spec=environment.actions,
network_spec=network_spec
 )
 )
and instead of doing saved_agent = agent007.restore_model(modelDir), I did agent007.restore_model(modelDir. That seemed to work, and the model is being rendered now. Thanks for the help!

Ok, great - I will close this now then.

Can you post the lines of code for saving/loading? Is the model stored in the path you specify, i.e., are there the expected files?

Can you post the lines of code for saving/loading? Is the model stored in the path you specify, i.e., are there the expected files?

Thanks, I fix it. It's due to tensorflow version.

Great!

Can you post the lines of code for saving/loading? Is the model stored in the path you specify, i.e., are there the expected files?

Thanks, I fix it. It's due to tensorflow version.
WHICH VERSION OF TENSORFLOW YOU USED?

The latest version of Tensorforce is now using TensorFlow 2.0. Until very recently, for the last months the TensorFlow version was 1.13.1.


Update incompatible-protocol-version.md

add screenshot

@tzarebczan here you are

@ykris45 can you make it smaller (and wider), just to include the box with the warning (so that it doesn't take up a lot of real estate on the page?  Please add a screenshot too

@tzarebczan okay i'll today sir.

done


Clean on Training and use the information from that to clean on Test

I have a dataset wherein both test and training dataset have missing values.
Just like in sklearn where we train using fit_transform and use that later to transform test data.
I want to clean the training set and using that info test set should also be clean.
How to do this.?

@shwinnn Bump.

Hi @VikasNS, you will need to slightly modify the clean function for this use case. With the below changes:
-      def clean(dataframe, numerical_columns, categorical_columns, tune_rbm):
+      def clean(dataframe, numerical_columns, categorical_columns, tune_rbm, rbm=None):

and
-      rbm = train_rbm(preprocessed_array, tune_hyperparameters=tune_rbm)
+      if rbm is not None:
+          rbm = train_rbm(preprocessed_array, tune_hyperparameters=tune_rbm)

You will be able to do the following:
    import boltzmannclean
    import numpy as np

    numerical_columns = ['list', 'of', 'numerical', 'column', 'names']
    categorical_columns = ['list', 'of', 'categorical', 'column', 'names']

    numerics, scaler = boltzmannclean.preprocess_numerics(
        training_dataframe, numerical_columns
    )
    categoricals, category_dict = boltzmannclean.preprocess_categoricals(
        training_dataframe, categorical_columns
    )
    preprocessed_array = np.hstack((numerics, categoricals))

    pretrained_rbm = boltzmannclean.train_rbm(
        preprocessed_array, tune_hyperparameters=True # or False, up to you
    )

    cleaned_training_dataframe = boltzmannclean.clean(
        training_dataframe, numerical_columns, categorical_columns,
        tune_rbm=False, rbm=pretrained_rbm
    )
    cleaned_test_dataframe = boltzmannclean.clean(
        test_dataframe, numerical_columns, categorical_columns,
        tune_rbm=False, rbm=pretrained_rbm
    )


feat(flow): flow-operations tries to spread inexact objects #8000

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Flow-operations tries to spread exact/inexact objects into the same merged object which leads to flow errrors.
Related dotansimha/graphql-code-generator-community#198 (issue)

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):
https://flow.org/try/#0FAFwngDgpgBAJABQJYGMDWAeA8gJyQcyQDsAuGLAIwCsoUQAaGAaSjAGczKa6A+GAXnhcAsgEMISDC3aMprHgAo0ZaQEoBfOAFEANlAC2UIiAAqkKNjyEijaTx4BuYKHMwcUAGZR3RFLEEA3gA+ogD8ZBQA9pF6okRBAL7O4NAwHjqRAO5Y0DiiIEiRRGxmqYHAMDAAdDUBMAD69SlGooZkAOQASp7eRn7tMAn0FdU1iKiY7l4+fowjwTBhZABUMIk8wEnAKEVsIDAgUHtk6Vk53vmFxaX+MAGNzUStUGQARN3TfVCvjKJkIDgAK5QBJAA
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Environment:

OS: Linux
Flow: 0.181.2
@graphql-codegen/flow-operations version: ^2.2.13

Checklist:

[ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.

Community plugins:

@graphql-codegen/typescript-react-apollo
@graphql-codegen/typescript-graphql-request
@graphql-codegen/typescript-apollo-angular
@graphql-codegen/typescript-apollo-client-helpers
@graphql-codegen/typescript-react-query
@graphql-codegen/typescript-urql
@graphql-codegen/named-operations-object
@graphql-codegen/urql-introspection
@graphql-codegen/flow-resolvers
@graphql-codegen/typescript-vue-apollo
@graphql-codegen/typescript-rtk-query
@graphql-codegen/flow-operations
@graphql-codegen/typescript-msw
@graphql-codegen/typescript-mongodb
@graphql-codegen/typescript-type-graphql
@graphql-codegen/jsdoc
@graphql-codegen/typescript-vue-urql
@graphql-codegen/kotlin
@graphql-codegen/typescript-vue-apollo-smart-ops
@graphql-codegen/java
@graphql-codegen/c-sharp-operations
@graphql-codegen/hasura-allow-list
@graphql-codegen/typescript-stencil-apollo
@graphql-codegen/relay-operation-optimizer
@graphql-codegen/typescript-oclif
@graphql-codegen/java-resolvers
@graphql-codegen/java-apollo-android
@graphql-codegen/flutter-freezed

Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.
Community plugins:
Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

Thank you, but I got permission denied with these steps:
ath@ath-aurora:~/graphql-code-generator$ git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
ath@ath-aurora:~/graphql-code-generator$ git fetch codegen-community

remote: Enumerating objects: 765, done.
remote: Counting objects: 100% (506/506), done.
remote: Compressing objects: 100% (136/136), done.
remote: Total 765 (delta 362), reused 506 (delta 362), pack-reused 259
Receiving objects: 100% (765/765), 421.43 KiB | 592.00 KiB/s, done.
Resolving deltas: 100% (465/465), completed with 57 local objects.
From github.com:dotansimha/graphql-code-generator-community
 * [new branch]          community                  -> codegen-community/community
 * [new branch]          main                       -> codegen-community/main
 * [new branch]          renovate/auto-bind-5.x     -> codegen-community/renovate/auto-bind-5.x
 * [new branch]          renovate/babel-monorepo    -> codegen-community/renovate/babel-monorepo
 * [new branch]          renovate/change-case-all-1.x -> codegen-community/renovate/change-case-all-1.x
 * [new branch]          renovate/changesets-changelog-github-0.x -> codegen-community/renovate/changesets-changelog-github-0.x
 * [new branch]          renovate/lodash-4.x        -> codegen-community/renovate/lodash-4.x
 * [new branch]          renovate/major-graphql-tools-monorepo -> codegen-community/renovate/major-graphql-tools-monorepo
 * [new branch]          renovate/node-18.x         -> codegen-community/renovate/node-18.x
 * [new branch]          renovate/oclif-command-1.x -> codegen-community/renovate/oclif-command-1.x
 * [new branch]          renovate/reduxjs-toolkit-1.x -> codegen-community/renovate/reduxjs-toolkit-1.x
 * [new branch]          renovate/urql-introspection-1.x -> codegen-community/renovate/urql-introspection-1.x
ath@ath-aurora:~/graphql-code-generator$
ath@ath-aurora:~/graphql-code-generator$ git push codegen-community

ERROR: Permission to dotansimha/graphql-code-generator-community.git denied to Athelian.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.
Community plugins:
Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

Thank you, but I got permission denied with these steps:
ath@ath-aurora:~/graphql-code-generator$ git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
ath@ath-aurora:~/graphql-code-generator$ git fetch codegen-community

remote: Enumerating objects: 765, done.
remote: Counting objects: 100% (506/506), done.
remote: Compressing objects: 100% (136/136), done.
remote: Total 765 (delta 362), reused 506 (delta 362), pack-reused 259
Receiving objects: 100% (765/765), 421.43 KiB | 592.00 KiB/s, done.
Resolving deltas: 100% (465/465), completed with 57 local objects.
From github.com:dotansimha/graphql-code-generator-community
 * [new branch]          community                  -> codegen-community/community
 * [new branch]          main                       -> codegen-community/main
 * [new branch]          renovate/auto-bind-5.x     -> codegen-community/renovate/auto-bind-5.x
 * [new branch]          renovate/babel-monorepo    -> codegen-community/renovate/babel-monorepo
 * [new branch]          renovate/change-case-all-1.x -> codegen-community/renovate/change-case-all-1.x
 * [new branch]          renovate/changesets-changelog-github-0.x -> codegen-community/renovate/changesets-changelog-github-0.x
 * [new branch]          renovate/lodash-4.x        -> codegen-community/renovate/lodash-4.x
 * [new branch]          renovate/major-graphql-tools-monorepo -> codegen-community/renovate/major-graphql-tools-monorepo
 * [new branch]          renovate/node-18.x         -> codegen-community/renovate/node-18.x
 * [new branch]          renovate/oclif-command-1.x -> codegen-community/renovate/oclif-command-1.x
 * [new branch]          renovate/reduxjs-toolkit-1.x -> codegen-community/renovate/reduxjs-toolkit-1.x
 * [new branch]          renovate/urql-introspection-1.x -> codegen-community/renovate/urql-introspection-1.x
ath@ath-aurora:~/graphql-code-generator$
ath@ath-aurora:~/graphql-code-generator$ git push codegen-community

ERROR: Permission to dotansimha/graphql-code-generator-community.git denied to Athelian.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi,
yes sorry, you need to fork the new repo, I've updated the instructions above.

[Hey! this plugins has moved to our community repo https://github.com/dotansimha/graphql-code-generator-community/tree/main/packages/plugins/flow/operations
Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!](https://github.com/dotansimha/graphql-code-generator-community/tree/main/packages/plugins/typescript/generic-sdk)


feat: image protection from taking screen shot

Hi. Suzuki. First of all thank you for your code.
This PR is for protecting image from taking screenshot.
it works only on the device not simulator.
I add UITextField layer on the paginationView.
Because 'secureTextEntry' in UITextField
In detail below link is for you.
https://developer.apple.com/documentation/uikit/uitextinputtraits/1624427-securetextentry

@JuyeonYu sorry for the late reply.
lgtm! Do you have anything that needs to be added? If not I will try to test it and merge it this week.


add Lego to logos reel on homepage

Description
Lego logo added per https://github.com/pulumi/pulumi-hugo/issues/3204

I noticed this open PR is labeled with do-not-merge. Could y’all let me know if we still need this open or are we good to close this? @zchase @shughes26

@desteves I think there were issues with logo permission, I'll close it out


opentelemetrytracer: Added support to configure a Dynatrace sampler

Commit Message: Added support to configure a Dynatrace sampler
Additional Description: Given the OpenTracing deprecation, Dynatrace customers need a solution to migrate to the OpenTelememetry tracer in Envoy. We have contributed several features needed and the sampler is the last step. Please refer to the linked issue for more information/context.
Risk Level: Low
Testing: Unit, Integration, Manual
Docs Changes: Proto docs generated and verified locally
Release Notes: Added support to configure a Dynatrace sampler
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #32581]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@mattklein123 there was a conflict with the changelog.. solved it now :)

Working to improve the code coverage a bit

@mattklein123 need the approval again, sorry. There was issues with code coverage, but we added more tests and should work now. Thanks!


Add support controllerAs sintax

With the rule that put the dynamic routes, will allow use controllerAs the controllers. The angular uses this as good practice to isolate the scope. Now we can use the following in views:

name: ativacao
url: /ativacao/:chave
controller: AtivacaoController
controllerAs: ativacaoCtrl

I did not understand. This is a problem in travis?

This already exists you can use the format:
controller: AtivacaoController as ativacaoCtrl

Where is this in the documentation? @JoshEllinger .

Trial and error is your friend :) don't think it's documented.


[bug] Behavior editor on press keys Shift+Tab

VSCode Version: 1.3.1
OS Version: Windows 10

Steps to Reproduce:

Open a new document
Type "if () {}" (without quotes)
Press key Home (and cursor go to first column)
Press tab 2 times
Go cursor at |{ (| represents cursor)
Press tab 3 times
Press Shift+Tab (behavior expected woud be back only {, but he back all line, this is annoying)

up


Crash - Point me in a direction please

I am using using Alturos 2.64 (from Nuget)
I have 2 machines:
Windows 10 on  both
Cuda 10.2 is installed on both
I am using the same release installation package (which has been obfuscated)
Laptop has 1050Ti notebook 442.50 drivers
Desktop has 1060 441.22 drivers
On my development machine it is working flawlessly
On my laptop it crashes during the detection of GPU. The CPU version works but I need to tell it to not look for GPU card. It crashes on the GetDevicesCount() and it is a hard crash so I can't catch it.
I have the exact same files in my package but apparently something is different.
Any ideas how I can find what it is?
Best
Christian

We are use the dll of https://github.com/AlexeyAB/darknet in the background you can open the issue directly there.

Hi Tino
I was wrong. It was on the line GetDeviceName() line
On my desktop it works fine but on the laptop and at least on other lapotop it is  always crashes on that line. Same code. Since I am not using it, I just commented that line and it all solved. But it keeps my thinking that maybe there is a buffer size error there in the DLL you are calling.
The name of the laptop graphics card is longer than desktop
Geforce GTX 1050 Ti With  Max-Q Design
vs
Geforce GTX 1060 GB
Maybe that causes the hard crash. My work around works for me, but maybe interesting for you to look into. Since that is not necessary for the initialization, you can remove that call?
All the best
Christian


Add-in not functional

I am not getting any errors that I can see, but I am not getting any drones or vessels auto-assigned to the logistics centres when I place them.
Game version: <IP_ADDRESS>31
Plug-in version: 1.4.0
I have tried removing and reloading the addon, without success.  Is there anything further I should try to resolve it?

Do you have any drones in your inventory or in storage on the planet? Have you changed your config at all?

I have 200 drones and 50 vessels in my inventory.  I have tried adjusting the config to 50 and 10, but only tosay, and had seen the error for a while before.

Has it worked at all since you downloaded the mod? Can you upload the BepInEx log file? It's located at /Dyson Sphere Program/BeInEx/LogOutput.log

It had been working.  It has been in the last week or so that it stopped working (hadn't realised it right away, just when I was checking why some logistic centres were not moving materials.
Log is attached.
LogOutput.log

AutoLogisticsDroneSetup should log a message when it loads, but I don't see it in your log. Is it enabled in your mod manager?

Yes it is enabled.  I'll look into it at my end tomorrow.

I uninstalled it, made sure the files were gone, redownloaded it, and when launching it appears to be working.
Confirmed the log now has the line [Info   :   BepInEx] Loading [AutoShuttleSetup 1.4.0] in it.  Tested with placing a logistics centre, and had the facility come up correctly.
Thanks for the help.

Weird, but I'm glad it's working now


Add support for additional PointFinder organisms

Only salmonella is supported from the PointFinder database.  Add support for all other organisms - https://bitbucket.org/genomicepidemiology/pointfinder_db/src

[x] campylobacter
[ ] e.coli
[ ] gonorrhoeae
[ ] tuberculosis
[x] enterococcus faecalis
[x] enterococcus faecium
[ ] malaria
[ ] M. tuberculosis
[ ]  Staphylococcus aureus

Hello,
I'm interested to integrate staramr  into a national project for antimicrobial research. We are developing a complete workflow for research and clinical use. If I can help to develop the tool to be more integrative in term of pointfinder database.


osrm-backend: 5.15.0 -> 5.16.3

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-extract -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-extract --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-extract -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-extract --version and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-partition -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-partition --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-partition -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-partition --version and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-customize -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-customize --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-customize -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-customize --version and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-contract -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-contract --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-contract -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-contract --version and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-datastore -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-datastore --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-datastore -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-datastore --version and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-routed -h got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-routed --help got 0 exit code
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-routed -v and found version 5.16.3
ran /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-routed --version and found version 5.16.3
found 5.16.3 with grep in /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3
found 5.16.3 in filename of file in /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3

cc @erictapen for review

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: osrm-backend
No log is available.

Success on x86_64-linux (full log)
Attempted: osrm-backend
Partial log (click to expand)
shrinking /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-datastore
shrinking /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-contract
shrinking /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-components
shrinking /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-routed
shrinking /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin/osrm-partition
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/lib  /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3/bin
patching script interpreter paths in /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3
checking for references to /tmp/nix-build-osrm-backend-5.16.3.drv-0 in /nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3...
/nix/store/wbblcwq4la8pc5gmmwbzjr4zsq30dq8j-osrm-backend-5.16.3

Success on aarch64-linux (full log)
Attempted: osrm-backend
Partial log (click to expand)
shrinking /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin/osrm-contract
shrinking /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin/osrm-customize
shrinking /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin/osrm-partition
shrinking /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin/osrm-extract
shrinking /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin/osrm-components
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/lib  /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3/bin
patching script interpreter paths in /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3
checking for references to /build in /nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3...
/nix/store/90p0qb6vrlblck14y3zyz5x1fxkc6276-osrm-backend-5.16.3

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: osrm-backend
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: osrm-backend
Partial log (click to expand)
shrinking /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin/osrm-contract
shrinking /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin/osrm-customize
shrinking /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin/osrm-partition
shrinking /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin/osrm-extract
shrinking /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin/osrm-components
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/lib  /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3/bin
patching script interpreter paths in /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3
checking for references to /build in /nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3...
/nix/store/ndws1b6nhg8b6frrxiqdi34j6868jz9v-osrm-backend-5.16.3

Success on x86_64-linux (full log)
Attempted: osrm-backend
Partial log (click to expand)
shrinking /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin/osrm-contract
shrinking /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin/osrm-extract
shrinking /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin/osrm-customize
shrinking /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin/osrm-partition
shrinking /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin/osrm-routed
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/lib  /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3/bin
patching script interpreter paths in /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3
checking for references to /build in /nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3...
/nix/store/b45fal7hkanxxlmn81hbbw3ldln91whm-osrm-backend-5.16.3


Issue with vulcanized output of serialised JSON

On this page an example is given of passing a serialised JSON object to a web component. It uses this syntax:
<roster-list persons='[{"name": "John"}, {"name": "Bob"}]'></roster-list>

That works great (if I hint the attribute as a JavaScript array), but if I 'vulcanize' the page the output is:
<roster-list persons="[{"name": "John"}, {"name": "Bob"}]"></roster-list>

and the component doesn't work anymore. If you switch the single and double quotes, the vulcanized output is correct and the web component continues to work:
<roster-list persons="[{'name': 'John'}, {'name': 'Bob'}]"></roster-list>

(although that last syntax could also cause issues if you don't hint the variable and try to JSON.parse() it yourself: that won't work unless you replace the single by double quotes again)

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


How to make new env

How to make new env?

You can read https://github.com/ngoxuanphong/ENV/wiki/MakeENV

You can read https://github.com/ngoxuanphong/ENV/wiki