Convolutional networks

I'm playing around with a basic DQN working with backgammon, and having got this working with a FF network, would like to try this using a convolutional network instead. So far I've:

created a copy of the dqn.py algorithm called dqn_conv.py, which implements a simple conv network using Sonnet
created a version of breakthrough_dqn.py file, which points at backgammon instead, and the above dqn_conv algorithm instead of dqn

this currently fails (which I'd expect it to) as the backgammon state is output as (None, 198) of rank 2 which doesn't match the input I need for the conv net.
I'm presuming that I need to modify BackgammonState::InformationStateAsNormalizedVector in backgammon.cc to output the right tensor, but any advice on doing this in the right way would be appreciated.
I'm currently thinking I should add a game option which defines which output format the game returns, from the current one (default), perhaps a 1D conv format (as backgammon is essentially a 1D game) and a 2D conv format.
Does this make sense, and any issues with doing this?

Hi @jamesdfrost , ah yes, good point.
If you take a look at the formats of the breakthrough and tic_tac_toe InformationStateAsNormalizedVector (or ObservationAsNormalizedVector), they are flattened in a way that be reshaped to the appropriate size in numpy (3x3x3 for Tic-Tac-Toe, 3x8x8 for Breakthrough).
I had convnets working a long time ago using numpy.reshape but that code did not make it into OpenSpiel, and it is is gone now. But you're on the right track -- you basically need to reformat how the data is stored (by writing out channel/plane one after the other, each in row-major order). But it has not been tested for quite some time.
It would be great to have an example of running DQN or A2C self-play on, e.g. Breakthrough or Connect Four, that people could use as a reference... maybe you can start by trying that?

I'm happy to start with either Breakthrough or Connect4 if you think they are better general examples - I'll have a look at Connect4 first.

If I remember correctly, it can also be done with tf.reshape (providing the tensor of InformationStateAsNormalizedVector() and the shape as InformationStateAsNormalizedVectorShape().

@jblespiau - thanks for that tip, that helped me get this over the line. PR now submitted for a simple ConvNet example using Connect_Four.
One issue I had was I tried to stick to Sonnet for defining the network - as far as I can tell you can only have 2 layer Conv2d networks (https://sonnet.readthedocs.io/en/latest/api.html#conv2d), certainly couldn't get it to work with 1 or 3 layers.
The other issue as far as I can see with Sonnet is it doesn't currently support running on PC - would there be any objections to using Keras to define networks in future?

One other thought I had on this, is you may have games with additional information being passed as well as the board information. For example in backgammon you might have the board position, along with the current match score for P1 / P2, and whether the position is the first move in a double. This wouldn't then map directly to a 2D format.
e.g. the current backgammon board state is encoded in 4 * kNumPoints * kNumPlayers (kBoardEncodingSize) with an additional 3 * kNumPlayers making up kStateEncodingSize.
In this case I'd suggest that within the DQN_Conv example the board state is split into a 2D convolutional vector, with any additional information (if any) values being split into a separate 1D vector. The first part would feed into the convolutional network, whilst the second part would feed in after the flatten operation.
Will aim to update the example to take this into account.


Clipboard and drive redirection are broken when "Printers" is selected as a shared local resource

This but is just combining #308 and #312
When using the Microsoft Remote Desktop Connection Client.
If "Printers" is selected as a local shared resource under the "Local Resources" tab it somehow breaks both the clipboard and drive redirection through thinclient_drives.
It feels like something that could be addressed server side, or is not being account for on the server side.  Hoping for a fix.

I can also reproduce this.

This appears to be fixed in the latest master branch.

I've tried with the latest commit (7a7445fefd9a61535881ceedf5ed82febb52d2dc).
If you enable printer redirection in mstsc.exe (Win 10) drives are not redirected.

It can be reproduced with 0.9.16. Please reopen.

Drives are still not redirected with 0.9.16 if printer redirection is enabled. Please reopen.

Thanks for the feedback. Reopened.
BTW, xrdp doesn't support printer redirection so far. So enabling printer redirection takes no effect. Also disabling printer redirection has no disadvantage. Turn it off.
Anyway, the issue should be fixed.


request for nvim commands to remap as we see fit.

This plugin is obviously incredible. great job. so so cool.
The way the keymaps are handled circumvents the usual way keymaps are usually handled by most plugins.Typically, the plugin author exposes Commands that people can feel free to map to if they so choose. that makes them discoverable and usuable in other ways than you might have already thought of, and helps people create a more custom way these things are interacted with in different scenarios, like having them load only on attaching to certain buffer types, or under certain other circumstances like if something is building correctly or.. whatever.
The way keymaps are handled here (pointing at local functions within keymaps.lua
https://github.com/GustavEikaas/easy-dotnet.nvim/blob/11d48cce707756da73a4202f4985eefa6ad1f2c2/lua/easy-dotnet/test-runner/keymaps.lua#L289
) means that they aren't easily used outside of that local file's context.
you pass function that's assigned to the lhs of the require("easy-dotnet.test-runner.render").options.mappings but give no way to reference what that function does outside of that exact keymapping, so if I don't want to set those on config, I have to copypaste that function into some other place I do my keymapping, which is techinically doable, but not a great api for users. This may mean also that they are assigned to the keymap in an order that's unexpected by people, either reassigning that keymap to something they already have, or by being reassigned when they didn't expect those keymaps to be reassigned because they thought it was taken care of by another place in code, etc.
Would you mind making the mappings just call commands or public functions that are exposed publicly from your code? that would be amazing.
great work on all this, again, I'm thrilled about how incredible this all looks.

For a lot of the keymaps this does make sense but for a few it kinda doesnt.
exposing Dotnet testrunner refresh is no problem and it would make sense but for other keymaps like e.g keymap.go_to_file.lhs it doesnt? This keymap can only be invoked inside the testrunner buffer, I can technically make this a user command but im not sure I understand your usecase? Would you want to invoke the function for go_to_file not through a keymap?
Could you give me a specific example of something you want to do but cant?

hmm.. well.. maybe in that instance go to file could be come the other way around, like, go_to_test_in_runner? then that could be a quick way to hop back and forth..
other than that, I'm pretty sure I had it take over some of my maps that were there. even after the test runner was closed.. though I can't seem to reproduce that right now..I'm not sure, sorry! lol. but certainly some of them I think do make sense to be public, if not all of them.

Ill look into it, it makes sense to make commands for a lot of them atleast. Thanks for the suggestion!
If you manage to reproduce the testrunner affecting your keybinds outside the testrunner buffer, please let me know because it shouldnt
vim.keymap.set('n', key, function()
      local line_num = vim.api.nvim_win_get_cursor(0)[1]
      local node = translateIndex(line_num, M.tree)
      if not node then
        error("Current line is not a node")
      end
      value(node, M)
    end, {
    buffer = M.buf, --Buffer specific mapping
    noremap = true,
    silent = true })

Just to clarify, all the keybindings for the testrunner are 100% configurable. So your use case is for using them outside the buffer?

So I wanted to do something about this. As I see it I want my exposing commands be in sync with my exposing lua functions at all times. I made a structure that generates the same exposing functions as commands in this PR #191. it pretty much means that I have manually verified every single command and lua function previously exposed. Hopefully this will make it easier in the future to have everything in sync.
I would greatly appreciate if anyone could test out this branch and check for breaking changes before I merge it.🚀


A non-null String must be provided to a Text widget. 'package:flutter/src/widgets/text.dart': Failed assertion: line 285 pos 10: 'data != null'

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

@egnimos
Closing, as this isn't an issue with Flutter itself
Take a look at https://github.com/flutter/flutter/issues/40214#issuecomment-530587931


webhook-driven scaling not working as expected

using this YAML file for creating webhook driven scaling. Runners are not scaling up, the helm chart version being used is v0.20.2

apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
name: webhook-pull-scaler
namespace: re-github-actions
spec:
scaleTargetRef:
name: single-deployment
minReplicas: 1
maxReplicas: 10
# Uncomment the below in case the target is not RunnerDeployment but RunnerSet
#kind: RunnerSet
scaleUpTriggers:

githubEvent:
checkRun:
types: ["created"]
status: "queued"
amount: 1
duration: "300s"

@swathida-byte Hey! Would you mind sharing logs from ARC controller-manager and githubwebhookserver? Your config looks good and we haven't made any breaking change in the config spec so this is very likely due to your installation of ARC isn't working correctly.

controller-manager logs:
2022-03-29T05:25:13.646Z	DEBUG	actions-runner-controller.horizontalrunnerautoscaler	Calculated desired replicas of 1	{"horizontalrunnerautoscaler": "re-github-actions/webhook-pull-scaler", "suggested": 1, "reserved": 0, "min": 1, "max": 10}
2022-03-29T05:25:13.662Z	DEBUG	actions-runner-controller.horizontalrunnerautoscaler	Calculated desired replicas of 1	{"horizontalrunnerautoscaler": "re-github-actions/webhook-pull-scaler", "suggested": 1, "reserved": 0, "min": 1, "cached": 1, "max": 10}
2022-03-29T05:26:11.203Z	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/mutate-actions-summerwind-dev-v1alpha1-runner", "UID": "652bdc03-8516-4884-89d3-a4dbdec5ea66", "kind": "actions.summerwind.dev/v1alpha1, Kind=Runner", "resource": {"group":"actions.summerwind.dev","version":"v1alpha1","resource":"runners"}}
2022-03-29T05:26:11.204Z	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-actions-summerwind-dev-v1alpha1-runner", "code": 200, "reason": "", "UID": "652bdc03-8516-4884-89d3-a4dbdec5ea66", "allowed": true}
2022-03-29T05:26:11.210Z	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-actions-summerwind-dev-v1alpha1-runner", "UID": "2101e66c-6761-4141-8b9c-d7ea0679b20d", "kind": "actions.summerwind.dev/v1alpha1, Kind=Runner", "resource": {"group":"actions.summerwind.dev","version":"v1alpha1","resource":"runners"}}
2022-03-29T05:26:11.210Z	INFO	runner-resource	validate resource to be updated	{"name": "single-runner"}
2022-03-29T05:26:11.210Z	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-actions-summerwind-dev-v1alpha1-runner", "code": 200, "reason": "", "UID": "2101e66c-6761-4141-8b9c-d7ea0679b20d", "allowed": true}
2022-03-29T05:26:11.230Z	INFO	actions-runner-controller.runner	Removed runner from GitHub	{"runner": "re-github-actions/single-runner", "repository": "Kitchen/test-github-actions", "organization": ""}
2022-03-29T05:32:49.483Z	INFO	actions-runner-controller.runner	Deleted runner pod	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "repository": "Kitchen/test-github-actions"}
2022-03-29T05:32:49.483Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Runner","namespace":"re-github-actions","name":"single-deployment-79wsg-qbvp7","uid":"e5df5158-7d9c-4655-9c26-343cd2954859","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"2309200089"}, "reason": "PodDeleted", "message": "Deleted pod 'single-deployment-79wsg-qbvp7'"}
2022-03-29T05:32:53.526Z	INFO	actions-runner-controller.runner	Created runner pod	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "repository": "Kitchen/test-github-actions"}
2022-03-29T05:32:53.526Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Runner","namespace":"re-github-actions","name":"single-deployment-79wsg-qbvp7","uid":"e5df5158-7d9c-4655-9c26-343cd2954859","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"2309200089"}, "reason": "PodCreated", "message": "Created pod 'single-deployment-79wsg-qbvp7'"}
2022-03-29T05:32:53.603Z	DEBUG	actions-runner-controller.runner	Runner pod exists but the GitHub runner appears to be still offline. Waiting for runner to get online ...	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "runnerName": "single-deployment-79wsg-qbvp7"}
2022-03-29T05:32:53.603Z	DEBUG	actions-runner-controller.runner	Rechecking the runner registration in 1m10.028303083s	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7"}
2022-03-29T05:32:53.682Z	DEBUG	actions-runner-controller.runner	Runner pod exists but the GitHub runner appears to be still offline. Waiting for runner to get online ...	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "runnerName": "single-deployment-79wsg-qbvp7"}
2022-03-29T05:32:53.682Z	DEBUG	actions-runner-controller.runner	Rechecking the runner registration in 1m10.158328277s	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7"}
2022-03-29T05:32:53.694Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:33:53 +0000 UTC. Retrying in 58.305147664s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:32:53 +0000 UTC", "registrationCheckInterval": "1m0s"}
2022-03-29T05:32:56.064Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:33:53 +0000 UTC. Retrying in 55.935288524s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:32:53 +0000 UTC", "registrationCheckInterval": "1m0s"}
2022-03-29T05:32:58.513Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:33:53 +0000 UTC. Retrying in 53.486935187s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:32:53 +0000 UTC", "registrationCheckInterval": "1m0s"}
2022-03-29T05:35:55.015Z	DEBUG	actions-runner-controller.horizontalrunnerautoscaler	Calculated desired replicas of 1	{"horizontalrunnerautoscaler": "re-github-actions/webhook-pull-scaler", "suggested": 1, "reserved": 0, "min": 1, "max": 10}
2022-03-29T05:35:55.023Z	DEBUG	actions-runner-controller.horizontalrunnerautoscaler	Calculated desired replicas of 1	{"horizontalrunnerautoscaler": "re-github-actions/webhook-pull-scaler", "suggested": 1, "reserved": 0, "min": 1, "cached": 1, "max": 10}
2022-03-29T05:38:29.640Z	INFO	actions-runner-controller.runner	Deleted runner pod	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "repository": "Kitchen/test-github-actions"}
2022-03-29T05:38:29.640Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Runner","namespace":"re-github-actions","name":"single-deployment-79wsg-qbvp7","uid":"e5df5158-7d9c-4655-9c26-343cd2954859","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"2309212067"}, "reason": "PodDeleted", "message": "Deleted pod 'single-deployment-79wsg-qbvp7'"}
2022-03-29T05:38:37.034Z	INFO	actions-runner-controller.runner	Created runner pod	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "repository": "Kitchen/test-github-actions"}
2022-03-29T05:38:37.034Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Runner","namespace":"re-github-actions","name":"single-deployment-79wsg-qbvp7","uid":"e5df5158-7d9c-4655-9c26-343cd2954859","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"2309212067"}, "reason": "PodCreated", "message": "Created pod 'single-deployment-79wsg-qbvp7'"}
2022-03-29T05:38:37.108Z	DEBUG	actions-runner-controller.runner	Runner pod exists but the GitHub runner appears to be still offline. Waiting for runner to get online ...	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "runnerName": "single-deployment-79wsg-qbvp7"}
2022-03-29T05:38:37.108Z	DEBUG	actions-runner-controller.runner	Rechecking the runner registration in 1m10.059120651s	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7"}
2022-03-29T05:38:37.115Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:39:37 +0000 UTC. Retrying in 58.884451448s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:38:37 +0000 UTC", "registrationCheckInterval": "1m0s"}
2022-03-29T05:38:38.842Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:39:37 +0000 UTC. Retrying in 57.157191932s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:38:37 +0000 UTC", "registrationCheckInterval": "1m0s"}
2022-03-29T05:38:41.699Z	INFO	actions-runner-controller.runner	Skipped registration check because it's deferred until 2022-03-29 05:39:37 +0000 UTC. Retrying in 54.300707946s at latest	{"runner": "re-github-actions/single-deployment-79wsg-qbvp7", "lastRegistrationCheckTime": "2022-03-29 05:38:37 +0000 UTC", "registrationCheckInterval": "1m0s"}
webhook logs:
I0329 05:16:05.436063       1 request.go:668] Waited for 1.038129248s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/security.openshift.io/v1?timeout=32s
2022-03-29T05:16:08.338Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": "<IP_ADDRESS>:8080"}
2022-03-29T05:16:08.339Z	INFO	setup	starting webhook server
2022-03-29T05:16:08.439Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2022-03-29T05:16:08.439Z	INFO	controller-runtime.manager.controller.webhookbasedautoscaler	Starting EventSource	{"reconciler group": "actions.summerwind.dev", "reconciler kind": "HorizontalRunnerAutoscaler", "source": "kind source: /, Kind="}
2022-03-29T05:16:08.439Z	INFO	controller-runtime.manager.controller.webhookbasedautoscaler	Starting Controller	{"reconciler group": "actions.summerwind.dev", "reconciler kind": "HorizontalRunnerAutoscaler"}
2022-03-29T05:16:08.439Z	INFO	controller-runtime.manager.controller.webhookbasedautoscaler	Starting workers	{"reconciler group": "actions.summerwind.dev", "reconciler kind": "HorizontalRunnerAutoscaler", "worker count": 1}
even though there are many jobs in queue its calculating desired as 1

@swathida-byte I see no webhook events received by the webhookbasedautoscaler. How are you exposing ARC's githubwebhookserver to GitHub?

ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts:
- host: ""
paths:
- path: /
pathType: ImplementationSpecific
added this part in values.yaml file
so when I add this in yaml life not able to create runners getting internal error occured
these are the logs from runner
An Internal Error Occurred. Activity Id: 2fffcc7d-6241-46c6-b6d4-e86fa970efb3.
Configuration failed. Retrying
Configuring the runner.

@swathida-byte Creating an ingress resource doesn't automatically set up your external loadbalancer or DNS that is required for GitHub to contact your webhok server. You'd also need to update your GitHub App or repo/org webhook setting so that GitHub sends webhook events to the URL you've specified there.
Also, that runner log indicates your runner might have difficulty accessing GitHub Actions API. Are you sure your runner pod has internet access(or if you're on GHES it has access to the github API endpoint GHES provides

@swathida-byte You might have better experience asking your colleague (if any) because I have no knowledge on your internal infrastructure and access to your repo/org settings. AFAICS, it doesn't seem like your issues are coming from ARC.


Add srcUrl option

This PR adds a srcUrl option to the plugin options that updates the location of the rudderstack javascript library in the <script src=.... This is mainly to add a proxy between the location and the rudderstack source so ad blockers won't block fetching the javascript sdk. Together with the controlPlaneUrl and the dataPlaneUrl you can now hide rudderstack completely behind proxies.
I updated the docs so it is explained what it does and built the code so it has the new code.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code (already working in our codebase)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added unit tests for the code (<-- there aren't any)
[x] I have made corresponding changes to the documentation

@l-hendriks Thanks for raising the PR. Could you please resolve the conflicts?

Hi @l-hendriks, We have an option for that, sdkURL. Check it out here.


dots lost when dereferencing files with dots

Hello
Following fix for https://github.com/swagger-api/swagger-parser/issues/1865 the name of the schema lost the dots
The name of the schema being of importance in the code generation, I think the swagger-parser should keep the dots as per the referenced file name
This mean that at
https://github.com/swagger-api/swagger-parser/blob/master/modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java#L115
I expect to see #/components/schemas/foo.model
instead of #/components/schemas/foomodel

If you agree with this, I'll submit a pull-request for the change.

Ping @gracekarina  as you did the original fix on https://github.com/swagger-api/swagger-parser/issues/1865


Birth date selector - Adding a really old date (>150 years) gives incorrect error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to https://staging.new.expensify.com/bank-account/personal-information
On the birth date selector select a date over 150 years old
Click on save and continue

Expected Result:
There should be an error mentioning the user to enter a valid date.
Actual Result:
There's an error mentioning the user is not over 18 years old (lol wat)
Workaround:
N/A visual issue (error not shown)
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.5-0
Reproducible in staging?: yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

@AndrewGable Eep! 4 days overdue now. Issues have feelings too...

Issue reproducible during KI retests

I think it might be fine to just do nothing in this case

I agree, low priority. Let's close and reopen when we've fixed all the other bugs more important than this one.


How to contribute?

I like this project's principles and would like to help out with fixing some of the bugs and what-not.
I see in this thread that the whole project is being rewritten from the ground up. If this is the case, it seems like wasted effort to bother fixing bugs in the current version if those fixes won't get reflected in V2. I don't know how far along V2 is, but I'd love to be able to help out there as well, but it would need to be published somewhere, and maybe some issues thrown up explaining some of the work that still needs to be done.

Hey @theScottyJam.
Thank you a lot for your intention to help.
Soon, I will make a blog post about the V2, the current version, and the work to be done. I'll share it inside this PR, README.md, and other resources.

That would be great! Thank you

How soon is soon? We are avidly watching. 👀😃


Add an image overview panel.

Add controls to the overview.  Clicking recenters to that point.  Shift-left drag zooms to the selected rectangle (and unrotates).  Left drag pans.
There may be better controls.  Perhaps the left drag control shouldn't operate unless started in the view rectangle.  The view rectangle could have annotation-like handles.  The mouse wheel and pinch gestures could do zoom and rotate (and, if so, should zoom be animated)?
Closes #15.

@waxlamp One way to handle a high zoom factor is to permit dragging when near the rectangle rather than strictly within it.  If you only had to be within 5 pixels of an edge, then the drag region is always at least 10 pixels square.


Product example page uses semi-transparent navbar by intent?

Is it by intent, that the product example page (http://getbootstrap.com/docs/4.1/examples/product/) uses semi-transparent navbar?

Look at the source code—there's an rgba() background that can answer your question :).
(It's a yes, it's by design.)


Be more precise about the country in the product list

"Country where sold" should appear instead of "Country". Otherwise people will believe Mexican products sold in France are French products :-)

I 'll fix this.


Meta schemas have been updated.

The meta schemas for drafts 6 & 7 have been updated.  Need to reflect that change locally and ensure all tests still pass.

Found an issue with the changes in draft 7.  Working in Slack to have it resolved.

It looks the patternProperties schema doesn't recognize propertyNames as a property, so it's trying to validate format as {"$ref":"#"} at which point it fails because "regex" is not an object or a boolean.


Fix "Scenic Path Finding"

Paths returned are not anywhere close to shortest paths.
Fix Pathfinder::pathFind to find better paths.
Issue may be in the existing heuristic.

Pathfinder::chooseNextGridSquare was always selecting the last available square. This caused the "Scenic path finding".


Coreaudio fails building on mac

error: failed to run custom build command for coreaudio-sys v0.2.16
Caused by:
process didn't exit successfully: /Users/js/consulting_work/clients/trilogy/screenpipe/target/release/build/coreaudio-sys-c47eb2829d5a82bb/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-env-changed=COREAUDIO_SDK_PATH
cargo:rustc-link-lib=framework=AudioUnit
cargo:rustc-link-lib=framework=CoreAudio
cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS
--- stderr
thread 'main' panicked at /Users/js/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bindgen-0.70.1/lib.rs:622:27:
Unable to find libclang: "the libclang shared library at /opt/homebrew/Cellar/llvm/18.1.8/lib/libclang.dylib could not be opened: dlopen(/opt/homebrew/Cellar/llvm/18.1.8/lib/libclang.dylib, 0x0005): tried: '/opt/homebrew/Cellar/llvm/18.1.8/lib/libclang.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/llvm/18.1.8/lib/libclang.dylib' (no such file), '/opt/homebrew/Cellar/llvm/18.1.8/lib/libclang.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64'))"
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

@jsinge97 macos version? hardware?

@jsinge97 any news?


UI: bring the List EVCs to the top for better usability

Hello,
The "List EVCs" section is displayed at the bottom of the page, requiring us to scroll down to the end every time we want to see the EVCs which makes it not so good for usability.
Maybe we could bring the List EVCs to the top and also make the "primary constraints" and "secondary constraints" to be initially collapsed

Great suggestions, @italovalcy +1
I've also just noticed that the Request Circuit k-button ended up being included in a k-accordion-item, since it's always mandatory to click in button I don't think this should be collapseable, as it used not to be, let me know if you guys have discussed this as well. Otherwise we can also address this tiny change also in this issue's scope here:

cc'ing @rmotitsuki for his info as well.


[QUESTION] swarm node naming

When joining nodes in a swarm cluster will it be possible (or already possible) to specify a node name different from the hostname ? so when you ps on a swarm manage instance it display the nodename/containername and not hostname/containername.

Unfortunately, no. The node name is sourced from the docker daemon (docker info), and it currently outputs the hostname.
Changing that would require patching Docker itself.


Windows 10 : TaskBar Icon is very low quality

OS: Windows 10
GPMDP Version: 4.6.1
Issue Descriptions: The icon for Windows 10 Taskbar @ 1440p is very low quality.
Steps to Reproduce: Install the app- view the icon
Screencap with other icons next to it- showing the lower quality of the GPMDP:
https://photos.app.goo.gl/Mm35C29EQHzQmhrZ6

On review of the screenshot- it doesn't quite show how bad it looks- But compared to the other icons around it- it's noticeably '"fuzzier".
Obviously not the end of the world- it is just an icon- but figured I'd bring it up for the other 1440p users out there


Does not work in IE or Firefox

I am having a similar issue working with Aurelia and it not working in the other browsers,  and I knew the grid would be having the same issues.  I checked and it does not work.
I have a repo if my issues as well.
https://github.com/BringerOD/skeleton-navigation
Just go to the test1 tab and it does not work in IE and Firefox.
Is it a known issues that Aurelia does not work with Firefox or the latest IE?

Yes it was an issue that's been fixed in the latest framework release. I've updated the master branch with the changes required to support the new release so if you grab that version you should be good to go!

Thanks I will check it out.

Ok,  my repo is updated and synced with the latest and it is now not working in any browser.
https://github.com/BringerOD/skeleton-navigation
Go to the test1 navigation link.  It is suppose to open and close a row.

Chrome works the first time it opens.  Then the rows expand without error but are still hidden.
IE, Firefox, Edge, all just don't work.  They don't expand.

Please check it out.


Terraform Cloud Provider + Login

[x] Configure Terraform Cloud Block
[ ] Workaround for Terraform Login
[x] Migrate local state to remote state
[x] Create new Project and Workspace in Terraform Cloud

Did not use the workaround this time, as we were able to manually enter the "terraform login" credentials, and may set up that automation later


Feature request: Possibility to visualize the input of a specific layer

Feature request: Possibility to visualize the input of a specific layer. It is useful if you want to visualize
the activations (weights after the activation function, e.g., Relu) because the inputs to the next layer after the Relu are effectively the activation.

I'm sorry but I just don't have time to update this project unless there is a bug.


Fix logging for Transmission errors

Have you checked for any existing open/closed tickets that are the same or similar to your issue?

[X] I've searched far and wide!

I have gone to the Discord server for support and/or acknowledge that this is a bug and not a support issue

[X] I've tried to solve this already

What's happening surrounding the bug? (context)
https://github.com/cross-seed/cross-seed/blob/7ba8184ceb8e7cbd5f99ab1f8ee5e908597434e6/src/clients/Transmission.ts#L95
This is only checking for a TypeError, but if you receive an HTML response and try to parse it like this you're going to get a SyntaxError, which means this branch isn't trigger and you're not dumping the response body into the logs.
Trying to set up cross-seed and I'm getting some kind of error from Transmission, and this logging bug means I can't actually see what's going wrong in the logs
Reproducing the bug
You can repro this easily by changing your transmission URL to http://www.google.com
What should be happening?
code should check for SyntaxError
Your setup
n/a

config.js (REDACT SENSITIVE INFORMATION)
n/a
verbose logs
2024-06-02 01:58:47 error: [transmission] Transmission responded with an error
2024-06-02 01:58:47 debug: Unexpected token < in JSON at position 0
2024-06-02 01:58:47 error: Failed to reach Transmission at http://[REDACTED]:[REDACTED]@[REDACTED]:9091/transmission/rpc
Failure or refusal to provide the information we require to address bugs will result in potential closure of the issue.

[X] I acknowledge that i have searched existing issues, read the documentation and faq, read the logs to see if the answer was provided in error messaging, and attempted to get support via the Discord prior to submitting this issue.

Can you get on Discord and get my attention so I can try and help you troubleshoot this a bit more to find out how we can distinguish these errors that don't return ErrorType that you're experiencing?


chore(master): release 1.3.5

:robot: I have created a release beep boop
1.3.5 (2023-07-12)
Bug Fixes

🐛 npm-run-all missing (ad86b68)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/cht527/rolandBergerGraph/releases/tag/v1.3.5 :sunflower:


Fixed some general grammatical problems with README.md

Heya Twenti, i made some changes to README.md adding some commas where they should be, and changing the wording of things to make a little bit more sense.
Overall though, its looking pretty good!

recheck

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

recheck

recheck

recheck

recheck

I have read the CLA Document and I hereby sign the CLA


m2mfirmware: optionally constify the static structures

If the old API is disabled by MEMORY_OPTIMIZED_API define,
we can put the sn_nsdl_static_resource_parameters_s structs
to flash to save some precious RAM.

@anttiylitokola @karsev

LGTM


Multi-trait searches on collections don't work

Provide environment information

What

Describe the bug
Selecting two traits in a collection results in zero items appearing eg magical beast and tier 1
Link to reproduction
https://realms.world/collection/beasts?type=Magical&tier=1
To reproduce

Go to a collection (beasts)
Select two traits that you know will be relevant eg magical, tier 4

Additional information
No response

@LordSquiddy this should be fixed with https://github.com/BibliothecaDAO/RealmsWorld/pull/155


Remove securityContext log errors in OCP 4.11+

ACM Installer team is cleaning up our logs and ran into KupeAPIWarnings that the seccompProfile needs to be set to RuntimeDefault for our operands. Please add this conditional in the deployment yaml to fix the error.
issue: https://issues.redhat.com/browse/ACM-3072
Signed-off-by: Erin Murphy<EMAIL_ADDRESS>

hi @eemurphy the commit needs signoff, thanks!


 On the glider-js package, these fire in all the following three cases:

Horizontal scrolling (touch or mouse)
Horizontal scrolling (touch or mouse) with scrollLock: true
Clicking on the dots

On the react-glider project, the first scenario does not fire any events.
⚠ Horizontal scrolling (touch or mouse)
✅ Horizontal scrolling (touch or mouse) with scrollLock: true
✅ Clicking on the dots

Have your other PRs fixed this?

No not yet. I was going to look into it separately.

I investigated this and the root cause is on glider-js as it previously used to use _.scrollLeft and this should be _.ele.scrollLeft. This is fixed on glider-js: 1.7.7 so I have upgraded the package.json dependency to that version.
For more info on the bug on glider-js:

Introduced here: https://github.com/NickPiscitelli/Glider.js/pull/146
Reverted here: https://github.com/NickPiscitelli/Glider.js/commit/18ff90b38f22fc84a2f22fb115244a1a7f7e663b#diff-f4b8488a4d72712239240832f06f48a1aaf0e2ec4775c8f877a14e4e11f3d39e

:rocket: Issue was released in v2.2.1 :rocket:


question about released model

Thank for your job。
I have a question about the model  you released in this place "Download the model checkpoint (GoogleDrive)"
Is it a single application scenario of a label_id，for example ，only  for  9 ? Because in the fine tuning code, you need to set label_id.

Hi @xiaocaimmm ,
the direct answer is no.
you can pass the image and bounding box prompt to the pretrained model and obtain the segmentation results. the segmentation result is a binary mask and it doesn't have a category label.

Thank you for your reply.
I'm sorry I didn't make my question clear.
What I want to know is whether the model you released is based on a specific lableid training?

no.
You can find the training set on the readme page:)


Syndicate Bombs In Surplus Crates Too Early

Description

Dunno if it's possible to code them to spawn in Syndie Surplus/Super Surplus crates after 30 mins. Mass sabotage and the syndie bomb by itself aren't allowed before then, and the surplus crates still give a way to obtain them early, which usually forces an antag to either break the rule or waste part of their gear.

we can just remove them from the crates as well


issue707: returning null instead of empty json object

for empty XML nodes
I'm not sure how to write tests for this pull request so I would appreciate any help or suggestions on how to do so.

See request-response-samples.

I removed version bump per request and changed some of the tests to accommodate that change. Although I have problems with tests of such format:
<?xml version="1.0" encoding="UTF-8"?>
<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
   <soap:Header />
   <soap:Body>
      <Response xmlns="http://www.example.com/v1" />
   </soap:Body>
</soap:Envelope>

What would be the result of this? I assume maybe {} would make more sense than null but again not entirely sure....

see the other response samples under test/

@anvk can you update the tests?

Taking this up in https://github.com/vpulim/node-soap/pull/784.


chore: bdd-spring-1573134151 to 0.0.1

chore: Promote bdd-spring-1573134151 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Type-safe NSPredicates and SortDescriptors using #keyPath()

With Swift 4 it seems we are required to use the @objc attribute when using the dynamic modifier. Since Realm Object subclasses need their properties to be dynamic, it seems natural to use #keypath() to create type-safe NSPredicate and SortDescriptor for Realm queries.
Example:
class Person: Object {

    @objc dynamic var parent: Person?

    @objc dynamic var name: String?

    init(name: String) {
        self.init()
        self.name = name
    }
}

let grandparent = Person(name: "Bill")
let path = #keyPath(Person.parent.parent)
let predicate = NSPredicate(format: "\(path) == %@", grandparent)

I recently did some heavy restructuring/renaming that would have been much easier if the compiler could have checked these key paths. I don't see this approach mentioned in the documentation and maybe it's too soon to target Swift 4, but I think it would be good to add for Swift developers like myself who aren't accustomed to using #keyPath(). That being said, I'm not an expert so please let me know if there are drawbacks or other considerations.
This issue is partly a suggestion to include something about #keyPath() in the Realm Swift documentation and also a request for some discussion on type-safe key path usage with Realm.

@blwinters Probably https://github.com/kishikawakatsumi/RealmTypeSafeQuery is what you want? This library uses undocumented API because Swift's KeyPath doesn't provide an API to retrieve string representation. (https://bugs.swift.org/browse/SR-5220)
So we cannot use it in Realm public API for now, we provide the library as separated instead.

@kishikawakatsumi Yes, that's exactly what I had in mind. I'll be watching both that project and the Swift bug. I'd rather not have a separate library just for this behavior, but I'll definitely incorporate it when it's available natively.


(s)CSS ERROR

After the full installation of the sage theme, yarn run start, I add some CSS to _global.scss and save it. If I go to my localhost:3000 I get the following error on the screen (black overlay).
ERROR in
resources/assets/styles/common/_global.scss
1:4   ✖  Expected single space before "{"     block-opening-brace-space-before
2:2   ✖  Expected indentation of 2 spaces     indentation
2:13  ✖  Expected single space after ":"      declaration-colon-space-after
with a single-line declaration
3:1   ✖  Unexpected missing end-of-source     no-missing-end-of-source-newline
newline

please don't clear out the issue template when creating a new issue. please don't post personal support requests on github (as noted in the issue template that you cleared out).
please also simply read the error message as it is very specific and tells you what to fix.


Make repo public

[x] repo
[x] board
[x] protected branches

🎉
https://github.com/what1s1ove/whatislove.dev


Plugin Templates are Expected in default/ Not plugins/

Description
The documentation states:

Plugin templates live in the plugins folder of the folder specified by the Template prefix

But, I found them in the default folder of the folder specified by the Template prefix.
Steps to reproduce

Go through all the basic installation, successfully.
Have an automatically set up Blog config.
Have an article.
Set "Template prefix" to plugins/djangocms_blog/vertical
Add clone of nephila/djangocms-blog:/djangocms_blog/templates/djangocms_blog into /…/templates/plugins/djangocms_blog/ as vertical/, i.e.

from nephila/djangocms-blog:/djangocms_blog/templates/djangocms_blog
create (your installation):/…/templates/djangocms_blog/vertical

Add "Tags" plugin to an article.
Load article webpage that has tags plugin.

Versions

Python: 3
Django: 1.11.22
Django CMS: 3.6.0
Django CMS Blog: 1.1.1 (migrated from already installed 1.0.0)

Expected behaviour

See tags loaded on functional webpage.

Actual behaviour

See error.

relevant string
django.template.loaders.filesystem.Loader: /code/taccsite_cms/templates/plugins/djangocms_blog/vertical/default/tags.html (Source does not exist)
screenshot:

Workaround

Rename template prefix sub-folder:

from /…/templates/djangocms_blog/vertical/plugins
to /…/templates/djangocms_blog/vertical/default

Load article webpage that has tags plugin.
See tags loaded on functional webpage.

Additional information
Related ticket: #595

If you set Template prefix to plugins/djangocms_blog/vertical you will have to copy templates inside templates/plugins/djangocms_blog/vertical directory, as in cp -a nephila/djangocms_blog/templates/djangocms_blog/* /path/my/project/templates/plugins/djangocms_blog/vertical
Have you also set BLOG_PLUGIN_TEMPLATE_FOLDERS ?

Yes, I have set BLOG_PLUGIN_TEMPLATE_FOLDERS:
# Configure `djangocms-blog`
BLOG_PLUGIN_TEMPLATE_FOLDERS = (
    ('default', 'Default template'),    # i.e. `templates/djangocms_blog/default/`
    ('vertical', 'Vertical timeline'),  # i.e. `templates/djangocms_blog/vertical/`
)

This "bug" no longer exists for me (after some changes since its report). I believe it was caused by a mix of the following:

a misguided configuration of "Template sets"
a misplacement of templates for "Template sets" and "Plugin templates"

It may or may not be a bug; but, if so, then it is likely an edge case; and, my intent is to set up "Template sets" and "Plugin templates", which I have done (and can continue to do better) thanks to clarification from #595.

Postmortem
The # i.e. … comments in my BLOG_PLUGIN_TEMPLATE_FOLDERS are not accurate. Because I had set "Template prefix" to plugins/djangocms_blog/vertical and the "Plugin template" to default, the path to the "Plugin templates" was truly templates/djangocms_blog/vertical/default/, as was searched for (and not found) by the code.


enable 7.1 on travis

OK let's see, it worked for me locally with 7.1 but maybe travis will surface that same error.

OK well anyway we should build against 7.1 here so thanks for the PR :)


[Feature request] hidden decorators

In some cases I'd like the reloadium decorators to be outside of my source code, and it will be nice if there was a way to save it inside the plugin settings\ config file.
Advanced feature will be an indicator in the IDE of this, but not as important.

@adoxentor Could you explain it a little bit more? I'm not sure I understand the use case.
Which decorators are you using?

from: https://reloadium.io/documentation/decorators
reloadium: no_reload
I cant have this comment in git code, but I'd like a way in the IDE to mark lines like that


Better integration with a deployment pipeline

Hi all
I was wondering if this module has been designed with the idea of an external build/deployment pipeline in place.
If you have a custom atlantis image integrating several other tools and configurations that changes frequently, the idea of updating the terraform template and apply is not ideal. I am not an expert but it looks like there are several issue with this module in this regard.
Using AWS Codepipeline or Code Deploy is not possible, apparently, because it expects to find two target groups in the load balancer and use a blue-green deployment. The module only creates one target group.
Using external tools to create a new image and update the task definition still leaves the issue that the state file is out-of-date and will revert the deployment when terraform runs again. To avoid this we need the option to add lifecycle configuration inside the module code itself, that is outside our control.
I might have misunderstood or missed something, I would be interested in your feedback on this.
Best,
Luigi

hello @LuigiClemente-Awin - I'm not certain I follow what you are saying. Are you inquiring about how to use custom images with this module?

closing for now - please feel free to re-open if new information has been provided


Periodic backups of promise data to a json file

so that we don't lose anyone or anything in the event of a db reset, etc

Let's assume the access logs we have in papertrail suffice here. Closing.


Create: oai-pmh doc

For documentation sprint
What does this Pull Request do?
Adds an OAI-PMH doc page
What's new?
Adds an OAI-PMH doc page

pulled some content from @seth-shaw-unlv 's readme on https://github.com/Islandora/islandora_defaults/tree/8.x-1.x/modules/islandora_oaipmh
added additional info

How should this be tested?

read
check for typos/unclear wording
test links
fix incorrect statements/

Interested parties
@Islandora-CLAW/committers @seth-shaw-unlv @joecorall

@joecorall, I know you merged the plugin-based metadata profiles into the Kent State repo, but when do you expect that will be pulled into the Drupal project repo? It would be good to release that as a version so I can do a quick update to the Islandora sub-module config before we release Islandora 8-1.1.

@librarychik, any more feedback before we merge this? It looks fine to me.

Thanks @seth-shaw-unlv, looks good to me! 👍

The newest release of rest_oai_pmh uses plugins for the metadata mappings now, so I just issued a PR (linked above) to update the islandora_oaipmh module accordingly. Once that gets in we will need to make some small edits to the docs.
That stated, if you want to go ahead and just update the TOC in mkdocs.yml, @elizoller, we can simply merge this now and I can create a new PR once the module updates are merged.


NaCl support?

Many Chrome Apps don't work in this FydeOS. Specifically Zoom and VNC.
Reason: NaCl.
Many RPi users need a Zoom client, and the most viable option they have is the Chrome App.
Too bad it doesn't work, just because NaCl is not implemented!
Countless users would thank you if you released a version that had NaCl.
Ref: https://www.raspberrypi.org/forums/viewtopic.php?f=131&t=269833&p=1643325#p1643325

this is now solved in the latest r83 release.

Great to hear!
Some people will prefer to use Raspbian's Chromium to do Zoom calls. How difficult would it be to port your Chromium executable to Raspbian?

Great to hear!
Some people will prefer to use Raspbian's Chromium to do Zoom calls. How difficult would it be to port your Chromium executable to Raspbian?

That would be a god send!

Great to hear!
Some people will prefer to use Raspbian's Chromium to do Zoom calls. How difficult would it be to port your Chromium executable to Raspbian?

That would be a god send!

Actually, there's something even better than that. I have continued working with other devs for Zoom support for the RPi, and am pleased to announce that we've ported the full Linux version of Zoom onto the platform.
In addition, I've made it extremely easy to install, using a shiny new RPi app store called Pi-Apps.
For more info on the Pi-Apps Zoom installation, see https://www.raspberrypi.org/forums/viewtopic.php?f=63&t=287680

That was a very awesome thing @Botspot : We sorely needed it. I had tried it based on your comments at https://devforum.zoom.us/t/have-you-considered-building-zoom-for-the-raspberry-pi-4-linux-system/14257/11 , however, it is still very choppy and unusable on Pi3 with PiCamera and bluetooth headset.
Am I doing something wrong, or is there some optimization I can do, specifically for Pi3? (By my estimates, there should be around 15 million Pi 3's out of the over 30 million Raspberry Pi's in the world, so Pi 3 should be a big target segment)

I am a bit confused, @rahulraj80 .You said you "tried it" based on my devforum zoom comment link. But the link you sent does not provide any Zoom solution. Instead, it asked the Zoom devs to make a RPi Zoom solution. So what did you try?
As far as the Pi3 goes, there's not much I can do. I have many Pi3s lying around unused, and it makes me feel bad too. But the Pi4 is around 6 times faster for graphics-related stuff, so please consider upgrading for smooth video playback.
If you still want to use your Pi3, there's a few things you can do: overclock, enable ZRAM & swap to double your RAM, stick with a high-end sd card - don't use a usb ssd, and most importantly, enable Fake KMS OpenGL. After those 4 tweaks, my Pi3 could handle Facebook fairly smoothly.

Hi @Botspot :
With respect to the link, I meant Chills340 and your own hints regarding the Box86 approach. I followed the Novaspirit way first, but got choppy results. I thought I might have missed something like the pulseaudio/alsa thing, so re-flashed, and followed the Pi-Apps process (Should have done this in the very first go, it had no heartburn, unlike the long form method), but got same results.
Will try those 4 steps you shared (ZRAM is already live) and revert if I get stuck.


[New Scheduler] Add memory queue for the new scheduler

Description
This PR adds one of the core implementations of the new scheduler.
This queue is dynamically created for each action and buffer activations in an internal queue.
It provisions more containers according to the number of activations in the queue.
This process is called "scheduling" and it is handled by another component SchedulingDecisionMaker.
This queue is designed in a way that activations are not persistent.
But it could be improved in the future by taking a similar approach with what Kafka does.
My changes affect the following components

[ ] API
[ ] Controller
[x] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[x] Scheduler
[x] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[x] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[x] I added tests to cover my changes.
[x] My changes require further changes to the documentation.
[] I updated the documentation where necessary.

According to the order defined in the wiki, this component requires other components to be merged.
https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
But there is no big difference in the memory queue logic, so I opened it for reviews.
Since this logic is the core logic and changes on this component are highly likely to introduce huge impacts on the system, I will write down a comprehensive design document.
Once dependent modules are merged into the master branch, I would rebase this PR.

Need rebase.

This is probably the most complicated PR, but did the best I could to understand at a high level I think LGTM a part from my comments.
One comment on the persistence nature of the queue. I think queueing with kafka doesn't add anything to openwhisk if openwhisk does not provide at least once guarantee of activation execution. It's unnecessary overhead to queue up through kafka if the activation can get lost elsewhere anyways.

One comment on the persistence nature of the queue. I think queueing with kafka doesn't add anything to openwhisk if openwhisk does not provide at least once guarantee of activation execution. It's unnecessary overhead to queue up through kafka if the activation can get lost elsewhere anyways.

Agree.
I think the immediate next step could be removing Kafka from the critical path completely as currently, container creation messages and activation messages from controller to scheduler are delivered through Kafka.

This queue is designed in a way that activations are not persistent.
But it could be improved in the future by taking a similar approach with what Kafka does.

I mentioned above that if we really need to support the at-least-once semantic, we can consider this approach.

After rebasing this PR, it started failing to run compile compileScoverageScala.
It seems it works well with scala 2.13 but fails with 2.12.
Not quite sure the reason yet.

It’s ready to merge.


remove releases folder

it's not really required, the bundle of each release appears in git with the version tag

/lgtm


More on FastList is not thread-safe

I am getting similar Exception to issue #591. I am pretty sure my threads are not sharing the same connection at least not directly. As a matter of fact, the exceptions happen when two threads are trying to close their current connection and get a new connection from the pool. The application has over 512 threads running on a 16 cores machine. The process is IO intensive and CPU usage is not that high. Here are the two exceptions, the exceptions are coming from two different threads:
Exception in thread "MainWorker-171" java.lang.ArrayIndexOutOfBoundsException: -1 	at com.zaxxer.hikari.util.FastList.remove(FastList.java:136) 	at com.zaxxer.hikari.pool.ProxyConnection.untrackStatement(ProxyConnection.java:169) 	at com.zaxxer.hikari.pool.ProxyStatement.close(ProxyStatement.java:70) 	at com.xxx.fsmon.summary.DirectorySummaryDAO.close(DirectorySummaryDAO.java:194) 	at com.xxx.fsmon.summary.DirectorySummaryDAO.renewConnectionToDb(DirectorySummaryDAO.java:159) 	at com.xxx.fsmon.directory.ThreadByDir.DirectoryRunnableExtractor.extract(DirectoryRunnableExtractor.java:215) 	at com.xxx.fsmon.directory.ThreadByDir.DirectoryRunnableExtractor.run(DirectoryRunnableExtractor.java:454) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 	at java.lang.Thread.run(Thread.java:745)
and
[MainWorker-488] ERROR com.xxx.fsmon.summary.FileSummaryDAO: Could not prepare the statements! java.lang.ArrayIndexOutOfBoundsException: -1         at com.zaxxer.hikari.util.FastList.add(FastList.java:78)         at com.zaxxer.hikari.pool.ProxyConnection.trackStatement(ProxyConnection.java:189)         at com.zaxxer.hikari.pool.ProxyConnection.prepareStatement(ProxyConnection.java:312)         at com.zaxxer.hikari.pool.HikariProxyConnection.prepareStatement(HikariProxyConnection.java)         at com.xxx.fsmon.summary.FileSummaryDAO.<init>(FileSummaryDAO.java:116)         at com.xxx.fsmon.summary.DirectorySummaryDAO.renewConnectionToDb(DirectorySummaryDAO.java:171)         at com.xxx.fsmon.directory.ThreadByDir.DirectoryRunnableExtractor.extract(DirectoryRunnableExtractor.java:215)         at com.xxx.fsmon.directory.ThreadByDir.DirectoryRunnableExtractor.run(DirectoryRunnableExtractor.java:454)          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745)
Could this be caused by a race condition in HikariCP code where one thread closes a connection, but has not finished closing all its statements and the other thread somehow gets that connection and is trying to open a new prepareStatement on it?
I am going to synchronize my renewConnectionToDb() method and see if the exceptions go away.
Any suggestion is greatly appreciated.
Environment
HikariCP version: 2.6.3
JDK version     : 1.8.0_11
Database        : MySQL
Driver version  : 6.0.5

This looks like a legitimate cross-core  L2 cache issue. I'll fix right away.

@kooroshvak why such an out of date JDK 8?
JDK 8 introduced so many bugs before JDK 8u25, I would try to reproduce the issue using an updated version.

Thanks for prompt response.
FYI, since I have synchronized my method, renewConnectionToDb(), I haven't seen this issue yet.
As far as upgrading my JDK, I will look into it. Thanks for the suggestion.

It is my belief that synchronizing the FastList.clear() method will be sufficient to synchronize the L2 caches across physical CPUs. This change will be published in the next few hours.

@kooroshvak This actually looks to be different synchronization issue, not FastList.  Are statements are prepared on one thread, but closed on a different thread?
I am curious about the code pattern implied by the stacktrace above.  DirectorySummaryDAO.renewConnectionToDb() is responsible for creating new instances of FileSummaryDAO (which runs SQL), as well as closing instances of DirectorySummaryDAO?

No, there is a parent-child relationship between DirectorySummaryDAO and FileSummaryDAO objects. They share the same DB connection, but create their our specific SQL statements. When closing DirectorySummaryDAO, it would close all its statements and then calls the corresponding close() method on the FileSummaryDAO which do the same on its own SQL statements. Now that I am looking at my code closely, I believe I have found a bug, since I am closing the DB connection on DirectorySummaryDAO before calling FileSummaryDAO to close its SQL statements. Sorry, it looks like the bug is on my side. My apologies.

That alone should not cause the issue.  The way the code is written ensures that a Statement is only closed once.  So, whether all of the statements are closed as a side-effect of closing the connection or not should have no effect.  Later calls to close those same statements should be no-ops.
The issue I did find was that because the isClosed flag was neither volatile nor atomic, access to the same state via different cores could result in one core seeing the statement as still open.
The higher the core count, the higher the likelihood of that happening.
The change I committed synchronizes on the isClosed state and ensures cache-line flushing.


presenterm not respecting config.yaml

I'm on a linux machine, kitty terminal, and I added a config.yaml @ ~/.config/presenterm
but presenterm is not respecting it at all, no matter what I put there.

defaults:
  themes: terminal-dark
  footer:
    style: progress_bar

    # Optional!
    character: 🚀

options:
  footer:
    style: progress_bar

    # Optional!
    character: 🚀

What version of presenterm are you using?

The latest, 0.4.1
I just did more experiments, it seems to complain if the config file is corrupt, e.g. it says
invalid configuration: unknown field footer, expected one of defaults, typst, options at line 17 column 1
But when I fix it and put something like the config you see at the begining of this thread, it doesn't complain anymore but it doesn't respect the config at all.

The only fields you can use in your config file are these ones so yes, those complaints are real. I did make a mistake on the docs apparently, the key you want is defaults.theme, not defaults.themes, e.g.
defaults:
  theme: terminal-dark

I'll fix that in a bit. Looks like this is missing a lot of validations for unknown fields, pretty much everything in your example config file is unsupported and it should complain.


Connect.agent () is not getting initialized

Issue : I'm integrating Amazon Connect CCP panel in my organization's UI. I have integrated CCP and now i want to subscribe to events and perform some actions on trigger of events.  The UI is written in React, the following is the code written to achieve what i'm saying but for some reasons, the events are not getting subscribed and in turn call back functions are not triggering.  The error i'm getting is : 'agent::init' event handler failed.
Additional question : I learnt that till the recent version of streams - 1.6.0, the display of login page in the same iframe as CCP. It would be great if someone can confirm me the same.
import React, {Component} from 'react';
import 'amazon-connect-streams';
class CCP extends Component {
constructor(props) {
super(props);
this.containerDiv = React.createRef();
}
componentDidMount() {
connect.core.initCCP(this.containerDiv.current, {
ccpUrl: 'https://case-callcenter.awsapps.com/connect/ccp-v2#/',
loginPopup: false,
loginOptions: {                 // optional, if provided opens login in new window
autoClose: true,              // optional, defaults to false
height: 600,                  // optional, defaults to 578
width: 400,                   // optional, defaults to 433
top: 0,                       // optional, defaults to 0
left: 0                       // optional, defaults to 0
},
region: "eu-central-1",
softphone: {
allowFramedSoftphone: true
},
});
connect.agent(subscribeToAgentEvents);
function subscribeToAgentEvents(agent) {
logInfoMsg("Subscribing to events for agent " + agent.getName());
logInfoMsg("Agent is currently in status of " + agent.getStatus().name);
agent.onRefresh(handleAgentRefresh);
agent.onStateChange(handleAgentRefresh);
agent.onRoutable(handleAgentRoutable);
agent.onNotRoutable(handleAgentNotRoutable);
agent.onOffline(handleAgentOffline);
}
function handleAgentRefresh(agent) {
logInfoEvent(
"[agent.onRefresh] Agent data refreshed. Agent status is " +
agent.getStatus().name
);
}
function handleAgentRoutable(agent) {
logInfoEvent(
"[agent.onRoutable] Agent is routable. Agent status is " +
agent.getStatus().name
);
}
function handleAgentNotRoutable(agent) {
logInfoEvent(
"[agent.onNotRoutable] Agent is online, but not routable. Agent status is " +
agent.getStatus().name
);
}
function handleAgentOffline(agent) {
logInfoEvent(
"[agent.onOffline] Agent is offline. Agent status is " +
agent.getStatus().name
);
}
}
render() {
return (

);
}
}
export default CCP;

Hi @ashwinisajjan, the "XXX event handler failed" message means there was an uncaught error thrown within the callback function to XXX event. Adding a try catch block within the callback function should help you debug which line caused an error.

@ashwinisajjan I am having the same error, did you manage to  find solution to this?


Added: iszero_W field in for the 4 weights in ControllerWeights struct

After some real benchmarking, the noR̂u field was useful to save some computations
So I added similar information for the 4 weights

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.99%. Comparing base (a934f8e) to head (0e05920).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   98.99%   98.99%
=======================================
  Files          24       24
  Lines        3675     3696   +21
=======================================
+ Hits         3638     3659   +21
  Misses         37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MODE-2606 Updates the versions of some common ModeShape EAP7/WF 10 components

One question above, but otherwise looks good.


Add FinRL_Tensor_Environment.ipynb

A new environment based on torch.tensor is added. The new environment is much faster than the original numpy.array environment since data are processed on GPUs and most of the For loops are replaced by torch.where. This Tensor environment may shed some light on some even faster environments.

Good.
thanks for your effort.


Failed on first launch F21

True of both 0.1.9-2 and 0.1.7-1 on F21.
The verify command fails.
$ gpg --homedir ~/.local/share/torbrowser/gnupg_homedir/ --verify ~/.cache/torbrowser/download/sha256sums.txt.asc
gpg: assuming signed data in `/home/example/.cache/torbrowser/download/sha256sums.txt
gpg: Signature made Wed 25 Feb 2015 12:58:21 AM MST using RSA key ID F65C2036
gpg: BAD signature from "Tor Browser Developers (signing key<EMAIL_ADDRESS>
Am I missing an installation step? What is the genuine signature? I have publics for 'Tor Browser Developers (signing key)' and 'Erinn Clark' in the gnupg_homedir.

I have this same issues.
Fedora release 21 (Twenty One)
torbrowser-launcher 0.1.9-1 (from [github], and from some repo this same result)

This is a duplicate of #159


Chef won't run on jenkins-master

as detailed at https://github.com/scala/scala-jenkins-infra/pull/188#issuecomment-248793404

fixed by @adriaanm, see https://github.com/scala/scala-jenkins-infra/pull/188#issuecomment-253597071


Update faq.tsx

reviews faq.js for portuguese.

Thank you very much, because we don't have a dedicated translator some of the pages I did translate via google translate... really appreciated your help.


Update dependencies and format the code

What kind of changes does this PR include?

Changes to the docs site code

Description

What does this PR change? Give us a brief description.
Update dependencies and format the code

Hi @zihan-ch — thanks for trying this! In general it’s better to upgrade dependencies one by one (or in small related groups) as it can be harder to debug issues when updating everything in one go. I’ll close this PR, but let me know if there’s specific dependencies you think there’s a reason we need to update urgently and we can discuss updating those!


SmartFilterBar ignores Advanced mode

Hi!
I'm trying to use variant management for the Value Help dialog of a smart field.
What I noticed - SmartFilterBar doesn't create variant management. But it's not like a planned feature. It seems that behavior is more unplanned.
OK. When we use smart field with help list the behavior is like this:

we create smart filter bar in the value help provider

as a usual control first we call init method then applySettings. Which means in init method we don't have parameters applied to constructor.

While initialization of SmartFilterBar we call  _createVariantManagement where we try to initialize Variant Management for a advanced mode.

However in this case it's always false as this parameter will be applied with other settings.
What I suggest is to create toolbar only after applying settings.
What do you think?
Thanks!

Hi @ThePlenkov ,
Thank you for your findings. I have created an internal incident: #1770136152
Kind Regards,
Gery (github dispatcher)

Hi @ThePlenkov
Here is the answer from the internal tiket of the control owners:
" actually VariantManagment is not yet supported inside of the ValueHelp-dialog; so even this is not the best way to handle it, it works as currently implemented.
For the sake of stability, there will be no change  in the current code base. "
Kind Regards,
Gery (github dispatcher)


moved pg and sqlite in separate packages with optional dependencies

I have moved all but the last testsuite. The "where" suite needs saltcorn-data, and I didn't want to make circular dependencies.


Geniza i18n prototype QA deploy playbook

Extend default django settings
Remove template_path from geniza vars
Add group vars for geniza i18n QA
Add apache_app_url setting to configure_apache role
Update local_settings role to use default template_path
Add geniza i18n QA playbook

@rlskoeser ready for final review based on changes we made today, if you want

no longer needed since prototype complete


Use build tags for bin2img and copyimg

Use the same build tags for bin2img and copyimg that we use for ocid, and improve detection of the case where we need to use the "libdm_no_deferred_remove" tag.

LGTM

I'm hoping this'll fix the problems we're seeing with CI tests in #345.

LGTM. (will wait for tests to be green).


unit test writer package

Description
Added unit tests for internal/writer package
Type of change

[ ] Bug fix (non-breaking change to fix a bug).
[ ] Feature (non-breaking change to add functionality).
[ ] Breaking change.
[X] Other

Issues referenced.
https://github.com/stackql/stackql/issues/280
Evidence

Checklist:

[ ] A full round of testing has been completed, and there are no test failures as a result of these changes.
[ ] The changes are covered with functional and/or integration robot testing.
[ ] The changes work on all supported platforms.

Variations

Tech Debt

Cheers for this.  Running the checks now.  Please do one favour and run go mod tidy and then commit and push any changes.
Thanks again

Cheers for this. Running the checks now. Please do one favour and run go mod tidy and then commit and push any changes.
Thanks again

Done

The "Windows Build" CI job is failing. I sadly can't tell which of the introduced changes caused that

The "Windows Build" CI job is failing. I sadly can't tell which of the introduced changes caused that

@tomekz yes I shall look into it and also it is past time to make the testing failure dumps more useful.  Shall update when i can

@tomekz ok finally got into this.  It is some windows specific stuff we have done.  Have got it working and verified as per this CI action.  The changes are in commit 991c14a.  You can either cherry-pick this commit and add push again, or check the PR box to “Allow edits from maintainers”, or do something else I have not thought of; totally up to you 😎

Thanks a lot. I've applied the fix for my branch

@tomekz  cool cheers.  FYI, presuming this passes, I'm intending to squash and merge.  Much appreciate the good work

@tomekz all checks are passed and it is approved.  Please go ahead and squash and merge yourself... hopefully we have set things up so that is possible.

Thanks @general-kroll-4-life , I'm glad I could help.  Can I ask you to merge it as I don't have write access to this repo and can't merge it myself


Support DOCKER_HOST environment variable

Background & motivation
Most applications that integrate with Docker support the DOCKER_HOST environment variable. This allows for a unified approach to connecting to the docker socket.
In some cases, users might use something like Podman or other engines which shim a lot of their features over a Docker API.
In other cases, users might expose a non-root socket for docker, like this nixos home-manager interface, which exposes the socket as unix:///run/user/1000/docker.sock.
Anyhow, supporting this flag would allow Kurtosis to support Podman & Friends mostly for free.
Desired behaviour
Docker engine should respect the DOCKER_HOST environment variable, and allow a config for it in the Kurtosis cfg file.
How important is this to you?
Critical; Kurtosis is unusable for me without it.

@dndll Thank you for submitting this issue. We're having a look and will get back soon!

Thanks for filing this @dndll ; makes a ton of sense! Suppose that Docker clusters defined in the Kurtosis config file had a socket config file, analogous to the DOCKER_HOST variable. So something like this:
clusters:
  podman:
    type: docker
    socket: unix:///var/run/podman.sock

Full transparency, we only test with Docker and Kubernetes backends. If Podman has a Docker API endpoint shim though, I'd hope ( 🤞 ) that the Docker client we're using internally would Just Work on Podman (and I don't think this is far-fetched, since Podman focuses heavily on easy conversion from Docker).
Though I just realized you might be asking, "can I have my Kurtosis CLI linked up to multiple backends at the same time?" - if so, yes, Kurtosis can be aware of multiple backend clusters at the same time which can be accessed through the kurtosis cluster family of command (the default Kurtosis config has docker and minikube out of the box).
Re. implementing the above, I think this will be a few hours of work (we need to build some extra deserializing into the config); let me check with @tedim52 about his bandwidth.

@tedim52 is saturated for now as we're currently sprinting on trying to make enclaves persistent by Aug 31 (roadmap), but @dndll could you comment if your fork did indeed allow you to run Kurtosis on Podman? If it works with just the socket, that derisks for us (as we know the project isn't going to explode into something bigger).

I'm sorry to hear that 😞 As a temporary fix until we can allocate the proper fix, can you let me know what you'd like DockerSocketFilepath to be? I'll build it for you and send you the build artifacts so we can test if it solves your usecase

Datapoint: spoke with another user yesterday who's exclusively on Podman; this would be a hard blocker for them

https://github.com/kurtosis-tech/kurtosis/pull/1362 closes this

While this is technically complete, I'm not happy with the implementation as it makes Kurtosis now dependent on the DOCKER_HOST environment variable that we don't control, and many users won't know exists
I've opened https://github.com/kurtosis-tech/kurtosis/issues/1469 which I think is how this should really be driven home


Unable to get verbose debugging reports for Attribution Reporting API.

Hi,
We are testing the ARA and set up the verbose debugging endpoint as per instructions. We have tested it on Chrome and it works fine, however we couldn't receive any report when testing ARA on Android.
Based on the log we should have at least one successful source registration(please correct me if I misunderstood the log message), and we think we are suppose to receive the debugging report of 'source-success' type?

Any guidance on how to debug further would appreciated!
p.s.

We have put "debug_reporting":true in our server response.
We are using UpsideDownCake extension 6.

Hi Shen, verbose debugging for Attribution Reporting won't be available on Android until the end of June. You can find that information and other feature updates on this spreadsheet.


AWS Cluster AutoScaler

Would it be possible to add support for https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler in to the AWS reference architecture?

We're looking at adding this to the aws provisioning work that's landed in openshift-ansible (not openshift-ansible-contrib) but we're dependent on an origin auto scaler image.

Awesome thanks


drivers: watchdog: Rename CONFIG_WDT_SAM_DISABLE_AT_BOOT in comments

CONFIG_WDT_SAM_DISABLE_AT_BOOT was removed in commit 2e01e86bdc
("drivers: watchdog: wdt_sam: use the generic disable option"), but some
comments still talked about it. Replace it with
CONFIG_WDT_DISABLE_AT_BOOT.

Codecov Report

Merging #14574 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14574   +/-   ##
=======================================
  Coverage   51.96%   51.96%
=======================================
  Files         309      309
  Lines       45576    45576
  Branches    10554    10554
=======================================
  Hits        23683    23683
  Misses      17083    17083
  Partials     4810     4810

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a546d1...2052aca. Read the comment docs.


Use ts-node instead of bun to run db seed.ts script

Summary
Use ts-node instead of bun to run db seed.ts script.
Details
The current db seed.ts script uses bun, which readers may not have installed. Using ts-node instead will be more familiar to readers since it's part of the node ecosystem.
Changes made:

Replace bun prisma/seed.ts with npx ts-node --esm prisma/seed.ts across the project.

Notes
ts-node can be used to run esm modules via the following methods:
# pass the flag
ts-node --esm

# Use the convenience binary
ts-node-esm

# or add `"esm": true` to your tsconfig.json to make it automatic
ts-node

I chose the flag option so that we don't have to install ts-node as a dependency nor update the tsconfig.json. For more details, please see the ts-node docs.

Thanks for this PR! Really appreciate it! I would do a find-and-replace to implement this across all chapters unless you want to update the PR to do it yourself! :)

@andrelandgraf I updated the PR to make the change across the entire project and also included more info about ts-node in the PR description for clarification!

Whoops, it looks like my prettier changed the single quotes to double quotes in the markdown file. I'll fix that!

Fixed the prettier formatting and also caught another typo in the chapter 15 package.json. It's fixed as well in the latest commit.

Thanks a lot for doing this! Great improvement!


Modify Python Logging

TL;DR: At present, the way logging is done causes problems with newer versions of the Jupyter/IPython notebook, among other things.
When I installed MXNet on a new machine recently and ran some notebooks to test it out I was somewhat confused because none of the callbacks for reporting training speed/accuracy were printed as output.
For example, the tutorial notebook has messages printed like:
INFO:root:Start training with [gpu(0)]
INFO:root:Epoch[0] Batch [200]  Speed: 70941.64 samples/sec Train-accuracy=0.389050
INFO:root:Epoch[0] Batch [400]  Speed: 97857.94 samples/sec Train-accuracy=0.646450
INFO:root:Epoch[0] Batch [600]  Speed: 70507.97 samples/sec Train-accuracy=0.743333
INFO:root:Epoch[0] Resetting Data Iterator
INFO:root:Epoch[0] Train-accuracy=0.743333
INFO:root:Epoch[0] Time cost=1.069
INFO:root:Epoch[0] Validation-accuracy=0.950800
...

However, these weren't showing up for me (although I recalled seeing them on my other machine).
This behavior turns out to be due to changes made to Jupyter's logging, where messages to the root logger (which is what gets called when invoking logging.info, logging.debug, etc.) no longer print to stdout, or maybe stderr doesn't show up in the notebook anymore.
See the relevant Python docs
This can be fixed reasonably quickly via adding the following code at the top of the notebook:
import logging
import sys
root_logger = logging.getLogger()
stdout_handler = logging.StreamHandler(sys.stdout)
root_logger.addHandler(stdout_handler)
root_logger.setLevel(logging.DEBUG)

But it's somewhat inelegant, since the root logger may be used by other modules whereas we presumably just want the log output from MXNet and the callbacks we are using.
It also causes issues in the documentation, where the generated documents refer to objects by the full Python path, e.g.,
class mxnet.module.base_module.BaseModule(logger=<module 'logging' from '/usr/lib/python2.7/logging/__init__.pyc'>)

I am not sure about what the ideal fix ought to be, but maybe it would be better to define a specific logger for MXNet rather than just using the methods of the logging module directly.
If you guys want, I can put together a pull request at some point next week when I'm less busy.

Usually you put logging.basicConfig(level=logging.DEBUG) at the start of every program to see the log.
It's easy to forget this though.
@tqchen @antinucleon Maybe we should put logging.basicConfig(level=logging.DEBUG) into mxnet's init?

Maybe put all the logger default value of all methods to be None, and then have a internal mxnet.logging module defining some method like
def get_logger(logger):
    if logger is None:
        # construct or re-use some global default logger
    else:
        return logger

You might not even have to do that much.
With logging.getLogger(<name>), for the same value of name you're guaranteed to get the same logger object.
So in modules where you want to use logging, you could just have
...
import logging
...
# A module scoped reference to the logger named "MXNet"
_logger = logging.getLogger('MXNet')

def foo(x, logger=None):
    if logger is None:
        logger = _logger
    ...

# Or alternatively, you could call `getLogger()`
class Bar:
    def __init__(self, logger=None, *args, **kwargs):
        if logger is None:
            self.logger = logging.getLogger('MXNet')
        else:
            self.logger = logger

The logger named "MXNet" could be configured, as you suggested, in the package's __init__.py.
I've just been defining a separate logger object and then passing that as a keyword argument when appropriate, and so far it seems to work well.
I am pretty sure that this would be easy to set up, but I'd want to spend more time looking at the code to make sure I'm not inadvertently breaking something.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


[PE-D][Tester E] In User Guide, the command summary does not specify the optional fields appropriately.

In the User Guide, the add and edit commands for example did not specify the fields that can be optional with '[ ]'.
Screenshot:

Labels: type.DocumentationBug severity.Low
original: kangzongxian/ped#16

Accepted, will fix with #157.


Added num_cores argument to neuron

What does this PR do?
Added num_cores argument to optimum-cli export neuron
Fixes # (issue)
Was getting AttributeError: 'Namespace' object has no attribute 'num_cores' on optimum-cli export neuron
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

This parameter is not supported for neuron, only for neuronx.

It is used here and results in an AttributeError I've mentioned in the issue.
Should I stick to export neuronx? Is export neuron still supported?

It is also mentioned in the docs here in the section Exporting LLMs to Neuron.

@gaarutyunov I agree this is confuzing but really this all applies to neuronx export, even if the name is neuron.

Hi @gaarutyunov, are you using inf1 instances? The export of LLMs is not supported by inferentia 1, you might want to use inferentia 2 instances as an alternative.

Hi @gaarutyunov, are you using inf1 instances? The export of LLMs is not supported by inferentia 1, you might want to use inferentia 2 instances as an alternative.

Ok, thank you for clarifying this, it wasn't clear from the documentation. I will try inf2.


⚠ Fortnite has degraded performance

In 2843b4e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1779 ms

Resolved: Fortnite performance has improved in 5d622a7.


WIP: Enable gzip compression when unpacking bundles to ConfigMap

Signed-off-by: Zvi Cahana<EMAIL_ADDRESS>Description of the change:
This is a follow-up PR to operator-framework/operator-registry#685 which introduced Gzip compression support when unpacking bundle images to ConfigMap via opm alpha bundle extract command.
The current PR closes the loop by setting the corresponding -z/--gzip flag when spawning the bundle extract Job that runs the above opm command.
Motivation for the change:
Enable OLM users to install operator with bundles reasonably larger than the current 1 MiB limit.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

Setting this PR as WIP as there are a couple of open items I'd like to get the maintainers input on:

Should this be configurable at the catalog-operator level (i.e., add a catalog-operator flag to enable/disable gzip compression when spawning extract jobs)?
I'd like to add an e2e test that uses a large (> 1MiB) bundle and verifies it installs correctly. Which of the existing e2e tests would be a good candidate to extend with such a test case?

Thanks!
/cc @kevinrizza @joelanford @exdx @timflannagan @dinhxuanvu

Not all index images will have an opm version that supports the -z flag. I think that means:
a. All existing index images need to continue working with no changes required anywhere. So I don't think we can blindly add -z to the catalog operator's bundle unpacker job.
b. All existing versions of OLM should be able to handle index images that do support compression. Basically, we can't enable compression by default in the unpack command (we didn't so we're good here).
It seems like the ideal would be a technique that lets a new version of OLM attempt to use compression and then fall back to non-compression if the index image does not support compression.

Not all index images will have an opm version that supports the -z flag. I think that means:
a. All existing index images need to continue working with no changes required anywhere. So I don't think we can blindly add -z to the catalog operator's bundle unpacker job.
b. All existing versions of OLM should be able to handle index images that do support compression. Basically, we can't enable compression by default in the unpack command (we didn't so we're good here).
It seems like the ideal would be a technique that lets a new version of OLM attempt to use compression and then fall back to non-compression if the index image does not support compression.

The opm binary on catalog doesn't matter though. This binary is the one that OLM happens to pull down on cluster as part of the registry image it references when it starts up as a command line parameter.
The only backwards compatibility concern we need to deal with is, if a configmap already exists for a bundle before this change was applied on cluster, then the unpacker job needs to understand how to unpack both zipped an unzipped content

The only backwards compatibility concern we need to deal with is, if a configmap already exists for a bundle before this change was applied on cluster, then the unpacker job needs to understand how to unpack both zipped an unzipped content

This case is already handled as the configmap reading logic tries to decompress only if an olm.contentEncoding: gzip+basse64 annotation is present on the configmap, and otherwise falls to the previous (uncompressed) logic:
https://github.com/operator-framework/operator-registry/blob/eacb9a40431c56ae887e7696e4931e935e67e045/pkg/configmap/configmap.go#L59
Nevertheless, this might be worthy of a test. On what scenario does OLM try to install from a configmap without going through the extract job first. Does there happen to be an existing test that runs a similar scenario?

It seems like the ideal would be a technique that lets a new version of OLM attempt to use compression and then fall back to non-compression if the index image does not support compression.

The opm binary on catalog doesn't matter though. This binary is the one that OLM happens to pull down on cluster as part of the registry image it references when it starts up as a command line parameter.

Actually, since the registry image is configurable via the --configmapServerImage flag, a user might indeed set an image with an "old" opm (e.g. using a non-latest release tag). With the current approach, I'm not sure how easy it would be for a user to realize the actual failure reason. If you think this is a concern, we can use the fallback-to-non-compression suggested by @joelanford. or at least try to better communicate the failure reason.

The e2e test currently fails since the configmap-operator-registry:latest image includes an outdated opm binary that doesn't understand the new --gzip flag.
For my understanding, the configmap-operator-registry:latest image depends on the upstream-registry-builder:latest image which had last been successfully built more than 3 months ago, and ever since fails to build:

Any insights into why this is failing?

I think I figured out why upstream-registry-builder:latest fails to build; attempted to fix in operator-framework/operator-registry#697.

Note: this PR is currently blocked until the new opm lands in configmap-operator-registry:latest ; As of now, it seems most of the auto-built images are broken (here, here, here, and here  - all have recent build failures).
The attempted fix in operator-framework/operator-registry#697 may have addressed one issue with the images, but it appears that there are other issues still breaking the builds (see this comment). It'd be best if someone with a broader understanding of these images (as well as access to the build logs) can take a look at this.
Thanks! :-)

As a workaround to the upstream-registry-builder:latest failing to build, I've changed the default opm image used by catalog-operator to upstream-opm-builder:latest (configurable via --opmImage). For my understanding this shouldn't be breaking anything, but users setting a custom image via --configmapServerImage will need to set --opmImage now too (release note?).
Also, I've just realized I'll need to bump the module dependency on operator-registry since the configmap decompression logic is vendored from there. Is there a new operator-registry release planned to be cut soon?

As a workaround to the upstream-registry-builder:latest failing to build, I've changed the default opm image used by catalog-operator to upstream-opm-builder:latest (configurable via --opmImage). For my understanding this shouldn't be breaking anything, but users setting a custom image via --configmapServerImage will need to set --opmImage now too (release note?).
Also, I've just realized I'll need to bump the module dependency on operator-registry since the configmap decompression logic is vendored from there. Is there a new operator-registry release planned to be cut soon?

We actually just had a new operator-registry release today, https://github.com/operator-framework/operator-registry/releases

We actually just had a new operator-registry release today, https://github.com/operator-framework/operator-registry/releases

Awesome, I'll update the go.mod with it.

upstream-tests check fails with the following error:
GOOS=linux GOARCH=386 go build -mod=vendor -ldflags "-X github.com/operator-framework/operator-lifecycle-manager/pkg/version.GitCommit=fbbd87a49427add1edff0cde4b3b6c0211dfad20 -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.OLMVersion=`cat OLM_VERSION`" -tags "json1" -o bin/catalog github.com/operator-framework/operator-lifecycle-manager/cmd/catalog
vendor/github.com/operator-framework/operator-registry/internal/property/property.go:8:2: cannot find package "." in:
	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/io/fs
make: *** [Makefile:100: github.com/operator-framework/operator-lifecycle-manager/cmd/catalog] Error 1

I think this happens since the io/fs package has been introduced only with Go 1.16, and the build job probably runs with an older Go version; I'll update the job so that it'll explicitly use 1.16 as the others - if you prefer me to move that to a separate PR just let me know.

/retest

/ok-to-test

/approve

/lgtm

Is it possible for this support be be back ported to earlier version of OCP 4.x? I have heard this functionality is only slated to go into OCP 4.9 currently, is that correct?


Remove an unnecessary print statement

What does this PR do?

Removing a print statement leftover from debugging
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

I updated the branch and added the changelog since this will be shipped with the agent. Looks good to me, thanks!


scan enemies verbose function not working well

it only shows lootbugs... maybe due to other mods' creatures? i also felt quantum disruptor making enemies spawn significantly less

Enemy spawning is influenced by the time in the moon, so if you have something slowing down the moon's time, the enemy spawns will also be influenced.

It should still be able to grab their enemy type to know their name. However, just to be sure, I need the logs of when you decide to use scan enemies when a custom enemy spawned to know for certain.


Exception when exposing data through geoserver with more than two date fields

Exception (no stack trace handy) reported in this case

Might want to implement something similar to what elasticgeo has done for configuration of display feature type (this is assuming that's part of the issue here):
https://github.com/ngageoint/elasticgeo/blob/master/gs-web-elasticsearch/doc/index.rst#configuring-an-elasticsearch-layer

Agreed.  Cannot find the ticket for this enhancement, but it is the same panel described here: #72
In the mean time time.  I should fix this.

closing issue since bug is fixed.  However, the comment made by Chris is linked to #72.   This, ultimately, is the correct fix.  I am going to another ticket to add parameters to the ingest process as well.


CI-10511 and GCP creds technique

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6582100ae11f296c7c35c038--harness-developer.netlify.app


error while fetching inputs: TypeError: Cannot read properties of null (reading 'join')

This issue summarizes the open issue from #26 and #53 (also mentioned in #51 )
Describe The Bug:
Error appears when inputs aren't loaded yet and the python plugin return an empty response and no error.
Logs:
1/27/2022, 10:22:25 AMHisense Tv Remotenow BridgeHiSenseTVERROR An error occurred while fetching inputs: TypeError: Cannot read properties of null (reading 'join')

This issue will stay open till #50 is fixed and the bug is resolved in code.

Fixed.


[error] Maximum call stack size exceeded

Original message: Oops, something went wrong while comparing
System Info
Editor version: 1.85.1
Extension version: 0.20.1
OS: darwin 21.6.0
Stack
RangeError: Maximum call stack size exceeded
at String.match ()
at Object.readBufferedLines (/Users/riaanv/.vscode/extensions/moshfeu.compare-folders-insider-0.22.1/node_modules/dir-compare/build/src/fileCompareHandler/lines/lineReader/readBufferedLines.js:23:49)
at /Users/riaanv/.vscode/extensions/moshfeu.compare-folders-insider-0.22.1/node_modules/dir-compare/build/src/fileCompareHandler/lines/compareAsync.js:72:36
at Generator.next ()
at fulfilled (/Users/riaanv/.vscode/extensions/moshfeu.compare-folders-insider-0.22.1/node_modules/dir-compare/build/src/fileCompareHandler/lines/compareAsync.js:5:58)

Hi @legomanzeal
Thanks for reporting the issue
Can you give more details about the folders you're trying to compare?
How big they are? Are they regular folder or they or they have linked folders inside? Where are they located locally or remotely? Is the issue consistent in any pair folders comparing or only specific folders?
Any more details you can provide would help


Indentation problem eg. in python and margin in editor to line numbers

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Steps to Reproduce:

Find single space in Python code on any color template skin  ;]

Indentation is base and important in Python
if we can se space before save and compile we can safe time from debuger and finding spaces

Problem: short yellow is spacebar

Solution: just we must have always margin line next to line numbers

Other solutions

Unification of top bar, menu ehre can be in top putted main icons

@ManPython possible settings that might work for you:
"editor.renderIndentGuides": true

"editor.renderWhitespace": "boundary"

"editor.renderLineHighlight": "gutter",

"editor.rulers": [ 0 ]

Hopefully one of these settings can work for you.


Reachability shows as Private

Some public nodes shows the Reachability as Private (that should be incorrect)

Some public nodes shows the Reachability as Private (that should be incorrect)

@b00f I debug network with this configuration:
  public_addr = ""
  listen_addrs = []
  bootstrap_addrs = []
  max_connections = 300
  enable_udp = true
  enable_nat_service = true
  enable_upnp = false
  enable_relay = false
  enable_relay_service = true
  enable_mdns = false
  enable_metrics = false
  force_private_network = false

But give private event from network.

Here is an issue according to reachability status in libp2p2 and still not fixed in master branch
https://github.com/libp2p/go-libp2p/issues/2046


Mxstbr proxy collective header img

Now you have access to the codebase, you can run tests on this yourself :).


[Release] Add release 3.1.0

should not merge until https://github.com/apache/dolphinscheduler/pull/12227 merged