request buffer doesn't work with the new HTTP2 WINDOW_UPDATE sending logic

With https://github.com/apache/trafficserver/pull/6643/commits/16e093792acc639fe71d71e95fb80c7b1d25bf0c, the client can only send up to SETTINGS_INITIAL_WINDOW_SIZE bytes.
@masaori335 can share details of his test that reproduced this issue.

@masaori335
CONFIG proxy.config.http.request_buffer_enabled INT 1
CONFIG proxy.config.http.post_copy_size INT<PHONE_NUMBER>
- with HTTP/1.1, ATS buffers whole request body
- with HTTP/2, ATS stop accepting 73KB ( this is looks like 64KB + 8 KB )

Summary
After 50441b39e6631389ef95c4133f06bbf94544879c (#6643) change, if the request buffer feature[*1] is enabled, POST requests (over 65535) on HTTP/2 connection are stalled.
*1 : proxy.config.http.request_buffer_enabled
Root cause
ATS sends WINDOW_UPDATE frames only if the buffer is consumed & buffering data is small enough. However, when the request buffer feature is enabled, the buffer is not consumed intentionally.
https://github.com/apache/trafficserver/blob/50441b39e6631389ef95c4133f06bbf94544879c/proxy/http2/Http2ConnectionState.cc#L1303-L1307
Workaround Fix
A workaround fix is adjust proxy.config.http2.initial_window_size_in to the same value to the proxy.config.http.post_copy_size. For example in above, it will be below
CONFIG proxy.config.http.request_buffer_enabled INT 1
CONFIG proxy.config.http.post_copy_size INT<PHONE_NUMBER>
CONFIG proxy.config.http2.initial_window_size_in INT<PHONE_NUMBER>

We can use this workaround fix up to buffering 2^31 - 1 (2,147,483,647) bytes, which is the maximum value of HTTP/2 flow-control window size. ( rfc7540#section-6.5.2 )
However, we can't apply this on a specific remap, because proxy.config.http2.initial_window_size_in is a global config.
TODOs

[ ] Check the feature is enabled on the logic that stops updating window
[ ] Add test cases to cover this (#6901)


Self-hosted etcd could get operator stuck infinitely

Reference issue: https://github.com/coreos-inc/tectonic-issues/issues/259#issuecomment-304551949
Currently we are waiting in addOneSelfHostedMember() before jumping to reconcile loop:
	err = retryutil.Retry(5*time.Second, math.MaxInt64, func() (bool, error) {
		err = c.updateMembers(c.members)
		if err != nil {
			c.logger.Errorf("add self hosted member: fail to update members: %v", err)
			if err == errUnexpectedUnreadyMember {
				return false, nil
			}
			return false, err
		}
		if c.members.Size() > oldN {
			return true, nil
		}
		return false, nil
	})

The reason for this is that we need to make sure the member add command has succeeded.
This would cause confusion because operator isn't doing anything or printing anything.
We could move the guard out to reconcile loop. And we could further add more intelligence like tolerating how long this could be.

For this issue, the big problem is that it adds operational load -- manually restart the pod.
To solve it, we need operator to

resolve automatically any potential problem, e.g. understanding that the number of nodes is less than specified size;
recover if the problem is resolved, .e.g user reconfigure the size back.


Add Int/Float Enum

Cadl Ranch Contribution Checklist:

[ ] I have written a scenario spec
[ ] I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
[ ] I have written a mock API
[ ] I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

Enum is under design. Let's hold on now.


[Feature Request] add async [onAdding] and [onRemoving] hooks

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request
[ X ] question request

Current behavior
When my user deletes a tag, that tag is immediately deleted!
Expected behavior
When my user deletes a tag and the bound entity has a foreign key constraint, I want to intercept the onRemove event where I return true/false and THEN YOUR internal onRemove method is called or not depending on the true/false value.
Use Case
I want this because by intercepting the removal I can show the user a small dialog with a yes / no button saying do you really want to delete this entity with its related data? Depending on the users answer I return true/false.
I would therefore need an onRemoving hook.
What do you use to build your app? (SystemJS, Webpack). Please specify the version

angular cli (webpack)

Angular version: 2.0.X

angular 4.0.1

ng2-tag-input version:

v1.0.5

Have you tried already the output (onRemove)?

Actually I would also need to intercept the onAdd method. I know that other tags/chips like ngJS 1.x just work like your component work, but I want that the tag is ONLY added in the UI when the server request returns an Ok. All your functions like Add/Delete are executed inmemory immediately.
Just imagine, the user could add a tag in the UI, meanwhile server request is going on, but the user leaves the page. 2 seconds later the server request returns with a 400 bad data state or another error state. This can´t be handled anymore , because the user moved away from the page.
I can hardly believe that I am the first mentioning this problem... am I?
Or do you think I misuse your tags component?

The first could be implemented using an async validator (when the new attribute [asyncValidators] will be added). The second yeah could make use of the hook.
What you're trying to do is a little unconventional and maybe advanced, but I wouldn't really say "misuse" :)

Ok then I have this onAddingTag and onRemovingTag feature request, shall I still make 2 extra feature request for them so you can label and track them correctly? Or do you think this feature is nowhere going to be implemented :P

Don't worry, I'll just edit the title of this issue :) I think it's worthwhile doing, but I can't really say about a timeline for it being implemented :|

https://github.com/Gbuomprisco/ng2-tag-input/pull/377/files

Just published version 1.2.3

thanks for adding this feature - I also find it useful for what I'm doing ... I did notice that onAdding only gets called when you press Enter to add a tag. If you click on or a tag in the autocomplete list or use separatorKeyCodes to define additional keys that will cause the tag to be added ... it doesn't call onAdding.
Thanks again for all your work on this!

Hi @neilharding,
I created a new issue https://github.com/Gbuomprisco/ng2-tag-input/issues/398 :)


[Network] Deprecate route table V1

Description

Deprecate route table V1, please see details in: #15927
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


New Proposed schema

https://github.com/CommonWealthRobotics/Hardware-Purchasing/blob/master/json/capScrew.json
@sjkelly What are your thoughts?

"pricsUSD"
Whats the workflow?

These items should be mapping purchasing information from a server to an object for the user to manipulate. That data structure is a hashmap of quantities against price. The data in there is to make accessible volume discounts in users pricing display. For Odoo, this data will be up-synced from its pricing models, but other databases may not expose that data through an api. This field allows for the maintainer of a given vitamin tag to keep the downstream users up to date as the maintainer sees fit.


Check/uncheck with partial match via 'exact: false'

Add exact option to check/3 and uncheck/3 to allow (un-)checking by substring match.
Related to #118.
To do

[ ] consistent defaults for exact option - currently as a user of phoenix_test I don't know what to expect
[ ] document exact option for check/uncheck

I think it makes sense for the default to be exact: true in these cases.

Agreed, closing this


Is expo a required dependency to use this library?

Prerequisites

[X] I checked the documentation and FAQ without finding a solution
[X] I checked to make sure that this issue has not already been filed
[X] I'm sure that question is related to the library itself and not Bluetooth Low Energy or Classic in general. If that so, please post your question on StackOverflow.
[ ] I'm running the latest version

Question
Hi, is it possible to use this library on bare react-native (without expo)? When reading the installation guide in the README, it seems like we need to install the expo package first, and then list this library as a plugin in expo. On the yarn package site, it also lists @expo/config-plugins as a dependency.
A previous related question is here but it received no answer

Hi @EthanYeh, thanks for your question; we'll get back to you soon.

Hi @EthanYeh
In case of installation on react native CLI, you just installing the package and it’s works. In the case of installation on expo, additional configuration and prebuilding are necessary. That’s why you can find much more information about the expo in the readme.

Ah I see, I'm resolved. Thank you!


Optimize Site Images for Improved Load Time and User Experience

The images on the main site are absolutely massive. The initial load of the website is nearly 20mb. Improve the UX by compressing the images or resizing them to fit the size they are presented. See "resources.png" for example.

I have improved the images on both https://lazyweb.rocks and https://app.lazyweb.rocks
The intial load of the website now is decreased from 20mb to 2mb

Awseome. Such a great imporovement.


Fix definition of ossl_intmax_t and ossl_uintmax_t

These definitions were located away from our definitions of other
sized int and uint types.  Also, the fallback typedef wasn't quite
correct, and this changes it to be aliases for int64_t and uint64_t,
since those are the largest integers we commonly handle.

The build failures seem to be relevant.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

CIs are happy.  (VMS is happy too)

Merged.


Add better failure message when asserting

Let people know what emails were in the mailbox. If there are no emails in the mailbox, let them know that it could be because they are doing feature tests or calling deliver_* from another process. Let them know that they can set a specific test process to send to. Related to #105

If there are no emails.

This process did not receive any delivered emails. This could be because no emails were sent, or because you are sending from a different process. If you are sending from inside a `Task` or from a feature test, it may not be sent back to the test process.

1) If you are writing a feature spec, consider writing a controller spec
2) If you need to write a feature spec, set the :process_name option `use Bamboo.Test, process_name: :my_test`
3) Send the email from outside of a Task.

If there is at least one email, we can assume the processes are working correctly

No email matching #{matched_email}

Other email(s) were delivered:

* Email 1
* Email 2

Going to tackle this before #105 since #105 will require custom assertion helpers outside to get messages from processes other than self

Closed by #109


Shortcuts don't seem to work on Fedora 38

Describe the Bug
I have menus that simulate Super+up and Super+q. When activating those, nothing happens on my new install of Fedora 38. It worked on Fedora 37 (or maybe I was on 36.... not so sure anymore 😅).
Steps to reproduce the behavior:

Be on Fedora 38
Activate an item that simulates a shortcut
Nothing happens

Running journalctl -fo cat /usr/bin/gnome-shell produces the following when trying to activate an item:
Window manager warning: Overwriting existing binding of keysym ff53 with keysym ff53 (keycode 72).

Expected Behavior
The shortcut should be simulated.
System

Fedora 38
Fly-Pie version 19 (from EGO)
GNOME Shell version: 44.0

It appears GNOME Shell/Fly Pie now uses GTK4. So the cause for this bug appears to be https://github.com/Schneegans/Fly-Pie/blob/main/src/common/InputManipulator.js#L58. The first value of the returned array is a 'success' bool. Fixing that makes Fly Pie work again. I didn't open a PR though because I don't know if there are potentially other GTK3 vs 4 issues going on.

Hey there, thanks a lot for the report! And thank you even more for discovering the fix! There were indeed some more issues. I hope that everything is working now again. I'll soon release a new version on ego.


[2.1] Update yarn test snapshots

Signed-off-by: Kavitha Conjeevaram Mohan<EMAIL_ADDRESS>Description
Update yarn test snapshots due to library upgrade
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #950 (7b34adb) into 2.1 (9ef23dd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.1     #950   +/-   ##
=========================================
  Coverage     76.60%   76.60%
  Complexity      283      283
=========================================
  Files            38       38
  Lines          2154     2154
  Branches        228      228
=========================================
  Hits           1650     1650
  Misses          363      363
  Partials        141      141

Flag
Coverage Δ

opensearch-observability
76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

is this a backport of an existing PR or just updating snapshots for 2.1? if it's a backport could you mention it in the description? thanks

this is just updating snapshots due to a backporting PR (package upgrade) merged before this
https://github.com/opensearch-project/observability/pull/949


Adapting Form.io to the latest version of react

Hi,
I’m using Form.io for a project at work, and my team and I would like to keep using Form.io as well as being able to upgrade our react version.
I’m currently working on a POC to see what changes are necessary to make Form.io compatible. I’ll send a pull request as soon as I have something stable!
I didn't see any similar, ongoing projects, but please let me know if someone's currently working on the same subject. Thanks!

I am closing the issue as it was created too long ago and there are no new comments here. I hope it was resolved. If not, please reopen it. Thanks!


[2.14] Generate: Conflict between store and fetched payloads causing empty pages

In nuxt 2.13, but 2.14 also, it appears some store patterns will cause the payloads not to be correctly loaded when visiting some routes after hydrating a statically generated site into an SPA.
A parent component sets a category based on the slug, it then fetches some async data in the store for re-use in the SPA (eg. some category data from an api). Said parent component has a destroyed() hook to make sure that, when navigating away, the current active item is unset.
A child component, only loaded after $fetchState.pending === false, uses mapGetters to get the correct category data from the store, then fetches some articles belonging to the active category.
The resulting page(s) are working in SSR (nuxt dev) and the HTML is generated (nuxt generate) correctly.
Testing with nuxt generate and nuxt start yields the following issue however:
A hard load on the generated page works. But clicking a nuxt-link to navigate to an alternative category will result in an empty page.
I should note that Nuxt version 2.12.2 did not have any issues with the generated version of this page.
Versions

nuxt: 2.14.0 (likely also in 2.13)
node: 10.23

Reproduction
https://github.com/FreekVR/nuxt-static-repro
https://boring-swanson-0859c4.netlify.app/magazine
Steps to reproduce
Ran: yarn run nuxt generate && yarn run nuxt start
Navigate to /magazine/foo or magazine/bar, then click one or both of the links on the page. They should return empty content in the SPA.
What is Expected?
Server- and client side render the same output
What is actually happening?
Via SPA, briefly the correct content is visible, then disappears

Personally, for my project fetch() hook is completely broken. Every api call is made on that hook i get an error TypeError: Cannot read property 'toLowerCase' of undefined. With or without vuex, doesn't matter. Had to use middleware() but it's dissapointing.

I am also seeing this same issue.

nuxt v2.14.0
target is static
all component data is being loaded/set in fetch()
pages are generated properly (with fetched data) and look as expected on initial load
client-side navigation fetches payload (which contains fetched data) but renders page without data

nuxt v2.14.0
target: static
mode: universal
app generate with npx create-nuxt-app

The payload are not well generate it's like the version of the payload cache it's not the same after when generate / start.
I got everytime 404 on payload.
And locally i have the same behavior as @FreekVR.
It's hard to get where the error is. Should we try with nuxt 2.13 ?

Thanks @FreekVR for the issue reproduction. I just wanted to confirm that I'm experiencing the same issue. @f3ltron Same issue with 2.13, also with Nuxt Edge 2.15

Is this somehow related to this issue https://github.com/nuxt/nuxt.js/issues/7717 ?

I think my issues were due to my reliance on certain business logic running in fetch(). When nuxt uses the new payload.js-files, neither fetch() nor asyncData() is called. I'll close this now as this is just an oversight on my part, though it's not very clearly documented in the change notes.
However, I /am/ still running into #7799 which is related.

@FreekVR can you provide some detail on how you made it work? I would assume that, even if fetch() isn't called, the data object gets 'rehydrated' from the payload. In my case, I can see the fetched data in the payload file...it just doesn't get rendered in the app.

@papertokyo I was experiencing this exact issue - it turns out it was related to an obscure markup error in an unrelated component. So ymmv, but try simplifying your template to only the component you’re troubleshooting and see if that helps.

I had this error only on iOS Safari. In my case it was a phone number in my footer component Safari tried to convert into a clickable link. that broke the page (only client-side). Turning the number into a link manually fixed the problem.

I think I had the same issue where the generated site wouldn't return any content client-side but would server-side. I also was using fetch() to get my data. Tried changing it to asyncData() and for me, this was the solution.

Exactly the same issue for me :/

nuxt v2.14.7
target is static
all pages data is being loaded/set in fetch()
pages are generated properly (with fetched data) and look as expected on initial load
client-side navigation fetches payload (which contains fetched data) but renders page without data

But to be very accurate I have this issue only when I manually refresh the homepage "/" and then I navigate on another folder "/articles". If I refresh the "/articles" folder manually then I navigate on the homepage "/" and then on the folder page "/articles" it works !..

Closed in https://github.com/nuxt/nuxt.js/pull/8466. Would appreciate testing via nuxt-edge to confirm fix.


JsRunScript() doesn't exist in Linux.

Hi,
I have compiled ChakraCore in Linux but there is no function JsRunScript() in .so library. it is undefined! and it is declareted in ChakraCommonWindows.h how can we use in Linux?
Thanks for any advice...

@vbmacit90 JsRunScriptUtf8 is the temp. replacement on cross platform.

is the JsStringToPointerUtf8Copy  replacement for JsStringToPointer  on cross platform too?

Yes. Please keep in mind; these are temporary methods and soon we will update them. Updated versions will take a place in our documentation.

Closing this one. Feel free to open if you continue to have the problem.

Thank you for answers
const char *script = "(()=>{return 'Hello world!';})()";
// Run the script.
JsRunScriptUtf8(script, currentSourceContext++, "", &result);
// Convert your script result to String in JavaScript; redundant if your script returns a String
JsValueRef resultJSString;
JsConvertValueToString(result, &resultJSString);

// Project script result back to C++.
char *resultWC;
size_t stringLength;
JsStringToPointerUtf8Copy(resultJSString, &resultWC, &stringLength);//**Crashing here

whats problem here @obastemur  ?

What is the return value of JSConvertToString ? JsNoError ? and what crash says?


[Don't merge] Remove links from Rummager payloads

We don't need to send these to Rummager any more - indexing of documents
now includes a step to fetch document links from the publishing API.
trello https://trello.com/c/LbZA0i15/678-stop-apps-from-sending-mainstream-browse-pages-topics-and-organisations-to-rummager

👍


Add new site

Added my own resume site https:bennf.github.io.

Looks good, thanks for contributing!


feat: fixed for the issue (#12)

1. Description

1.1. Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

1.3. Related Issues

bors merge

Codecov Report

Merging #124 (dc25e4c) into main (44215aa) will increase coverage by 0.21%.
The diff coverage is 84.61%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   72.72%   72.94%   +0.21%
==========================================
  Files          99       99
  Lines        1056     1068      +12
==========================================
+ Hits          768      779      +11
- Misses        288      289       +1

Impacted Files
Coverage Δ

lib/src/core/client/client_context.dart
0.00% <0.00%> (ø)

lib/src/core/service_helper.dart
74.71% <ø> (ø)

lib/src/service/base_service.dart
90.58% <ø> (ø)

...b/src/service/v1/accounts/accounts_v1_service.dart
97.04% <100.00%> (+0.16%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Question: how to setup the theme properly for python?

Hi
Your theme is awesome it's the reason that I'm trying to switch from vim to nvim, I'm trying to get the same results as the images that you share, but at the moment (since I downloaded the theme) the name of the variables and most of the text is in gray, only the name of functions, objects , primitive types and keywords of the language are in colors, name of the variables and arguments of functions are in gray too.
Besides the vim plug part this is my config on init.vim file
`
" Vim Colors Configuration
syntax enable
syntax on
set cursorline
if exists('+termguicolors')
"let &t_8f = "<Esc>[38;2;%lu;%lu;%lum"
"let &t_8b = "<Esc>[48;2;%lu;%lu;%lum"
set termguicolors
endif
set t_Co=256
colorscheme onedarkpro
`

👋🏼 @rb-one! Hope you're great.
Have you installed Treesitter and enabled syntax highlighting?

Hi @olimorris, thanks for asking, I'm just recovering from covid this week, my bad, I did not install Treesitter, now everything is beautiful thanks for your advice and time.

Most importantly I hope you're recovering and feeling better! And when you get to try the theme out properly, I hope you really enjoy it.

Thanks a lot Oli, I will enjoy it 😃


Update: Olympic Medals: add option to track a specific country

This update adds a second display option to the app where the user can track the medals of a specific country.
Preview:

We need this 🥇


Save Physical Storage Model

This PR is able to save physical storage model into ManageIQ. Likewise Switches, Servers, Racks and Chassis, the Storage is a physical component, which is why I labeled it PhysicalStorage in model.
Depends on:

ManageIQ/manageiq-schema#196

LGTM @agrare Please review.  Note that there are no specs going through this yet, otherwise this would fail since I just merged the database change.  I expect that the provider refresh will ultimately test this.

It looks like the specs are here, https://github.com/ManageIQ/manageiq-providers-lenovo/pull/170/files#diff-98cc26e5e52ffafdabcfc6bd8f1ea1d3


API Call 'youtube#searchListResponse' return inconsistent results

Hi All,
I'm having an issue querying 'searchListResponse' with the same argument each call
Environment details

OS type and version: MacOS 14.5 (23F79)
Python version: Python 3.10.11
pip version: pip 21.3.1
google-api-python-client version:  2.138.0

Steps to reproduce

Run search() list as follows:

 search().list(
            part="snippet",
            q='my search query',
            type="video",
            pageToken=None,
            order='date',
            publishedAfter=earliest_date,
            publishedBefore=latest_date,
            maxResults=1
        )
        response = request.execute()

Observe results count
Run step 1 again
Observe again

Code example
for i in range(10):
    request = self.youtube.search().list(
        part="snippet",
        q=query,
        type="video",
        pageToken=None,
        order='date',
        publishedAfter=earliest_date,
        publishedBefore=latest_date,
        maxResults=1
    )
    response = request.execute()
    print(response['pageInfo'])

{'totalResults': 57238, 'resultsPerPage': 1}
{'totalResults': 81, 'resultsPerPage': 0}
{'totalResults': 57238, 'resultsPerPage': 1}
{'totalResults': 57238, 'resultsPerPage': 1}
{'totalResults': 57570, 'resultsPerPage': 1}
{'totalResults': 52429, 'resultsPerPage': 1}
{'totalResults': 81, 'resultsPerPage': 0}
{'totalResults': 57356, 'resultsPerPage': 1}
{'totalResults': 81, 'resultsPerPage': 0}
{'totalResults': 57849, 'resultsPerPage': 1}

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

Hi @dudio92 ! Thanks for reporting this. This does not look like a client library issue, but rather an issue with the YouTube service API. Could you report your issue with search.list to the service team as suggested in https://developers.google.com/youtube/v3/support? Thanks!


Do what's needed for a new version scheme and set the next version to 3.0.0

Ref: https://www.openssl.org/blog/blog/2018/11/28/version/

We have things like -DOPENSSL_API_COMPAT=0x10100000L documented in the CHANGES file, so we might want to deprecate that itself too.

Personally, I would rather get rid of the version-bound deprecation stuff entirely and simply have a macro DEPRECATED for the things we're deprecation now, and possibly FUTURE_DEPRECATION for things that are to be deprecated starting next release (and it's up to us to look for those and change them to DEPRECATED at each major release).

Regarding the handling OPENSSL_VERSION_PRE_RELEASE, I'm making it undefined when there is no pre-release information so that those who wish to detect that they're building against a pre-release can do so easily with
#ifdef OPENSSL_VERSION_PRE_RELEASE

The C preprocessor doesn't compare strings...

@t-j-h said thusly:

A range of comments:
Deprecation can only occur at a MAJOR version number - so the tests for 3_0 should be just 3.

Agreed...  when I wrote that branch and was thinking in terms of semantic versioning, I was thinking that we might want to support deprecating at any minor release, but since we're not going there, you're right. Will fix.

We should always use the API-level testing macro and not raw check a synthesized number - i.e. the macro that gets passed MAJOR,MINOR should be what we use in general.

Yeah.  There were some spots where it wasn't quite clear to me what the intent was.  Will fix.

If we need to test down at the MAJOR.MINOR.PATCH level we should have a macro for that purpose too - but raw 0x300000000 and 0x1010xxx should simply go from the code base so that we can in future change how we represent the version number in a single place. i.e. all usage of OPENSSL_API_COMPAT should be changed IMHO. We do not want users doing any of those sorts of tests in the future

Okie.  The reason I didn't touch OPENSSL_API_COMPAT is that there is a lot written in CHANGES on how to handle it, so I didn't want to break compatibility...  I will look at this.

There are multiple places where you token-paste to get strings which are in C files which should be in public header files so that others can refer to them at compile-time too rather than runtime.
The macros should not use meta_stuff and pre_stuff as names (especially if they are present in a public header file)

So basically, for any macro that can be undefined, we should provide a variant that's guaranteed to be a string?  Something like this?
#ifdef OPENSSL_VERSION_PRE_RELEASE
# define OPENSSL_VERSION_PRE_RELEASE_STR OPENSSL_VERSION_PRE_RELEASE
#else
# define OPENSSL_VERSION_PRE_RELEASE_STR ""
#endif

Could we change DEPRECATEDIN_X_Y(f) to DEPRECATEDIN(x,y,f) ???

No...  trying this would essentially mean trying to have CPP producing CPP code, and that's just not possible.

I believe I've addressed all expressed concerns so far at this point.

Remaining Travis's failing jobs seem to be caused by some Travis screwup (it says there's a .pod that shouldn't be there) in one case, and the missing fix from #7522 (I just commented on that)

It seems some folks are forgetting why we have the OPENSSL_API_COMPAT macros...
They make it possible for a user project to incrementally increase their base OpenSSL API, test disable all features deprecated prior to the oldest release they support, without breaking compatibility with later OpenSSL releases that deprecate even more features that the project may still be using.
A single boolean deprecated/not-deprecated fails to do provide what OPENSSL_API_COMPAT provides.
Furthermore, incompatible changes in a just-introduced compatibility interface are not a good idea.  We can introduce new macros that make it easier to construct the floor values, but please DO NOT remove the current mechanism controlled deprecation.

Uhmmmm, I do believe the code in openssl conf.h.in keeps the incremental nature of OPENSSL_API_COMPAT.

Remaining Travis's failing jobs seem to be caused by some Travis screwup (it says there's a .pod that shouldn't be there) in one case, and the missing fix from #7522 (I just commented on that there)

The last bit got fixed by #7738, which I just merged, and then rebase this PR on top of.  Travis should become a little happier.

Hmm... Travis Job 462359821 exited with error code 1, but I don't see any cause for the failure?

Ah, doc-nits failed:
5.12s$ if [ -n "$CHECKDOCS" ]; then if $make doc-nits; then echo -e '+\057\057 MAKE DOC-NITS OK'; else echo -e '+\057\057 MAKE DOC-NITS FAILED'; false; fi; fi
(cd .; /usr/bin/perl util/find-doc-nits -n -p ) >doc-nits
doc/man3/OPENSSL_version_text.pod:1: the following exist as other .pod files:
OPENSSL_VERSION_TEXT
make: *** [doc-nits] Error 1
+// MAKE DOC-NITS FAILED
The command "if [ -n "$CHECKDOCS" ]; then if $make doc-nits; then echo -e '+// MAKE DOC-NITS OK'; else echo -e '+// MAKE DOC-NITS FAILED'; false; fi; fi" exited with 1.

@levitte ... have you had time to verify that the incremental nature of OPENSSL_API_COMPAT is preserved, ...

No, not yet.  Nor was my earlier comment suggesting that anything was broken, I was just reacting a snippet of the comments made in this thread, without yet having seen the underlying changes.  It seems that the compatibility framework is being preserved, or at least is not intended to be broken, so that's great.
Presently, I am busy adding SNI support to Postfix, and finding some friction that really does need to be addressed, I hope to attract some attention to #7743 even with all the FIPs-related work going on.  SNI should not be that difficult. I am willing to contribute some of the implementation work once we decide what should be done, but I also need guidance on what can be with 1.0.2, in which SNI support will not change at this point, beyond perhaps better documentation...

No, not yet. Nor was my earlier comment suggesting that anything was broken, I was just reacting a snippet of the comments made in this thread, without yet having seen the underlying changes. It seems that the compatibility framework is being preserved, or at least is not intended to be broken, so that's great.

Message received, I will have a look at the comments.  I admit to not having given them my full attention.

Presently, I am busy adding SNI support to Postfix, and finding some friction that really does need to be addressed, I hope to attract some attention to #7743 even with all the FIPs-related work going on. SNI should not be that difficult. I am willing to contribute some of the implementation work once we decide what should be done, but I also need guidance on what can be with 1.0.2, in which SNI support will not change at this point, beyond perhaps better documentation...

I'll try to have a look...  libssl has never been my forte, though.

Also, you might be interested in #7742, where I specifically try to document OPENSSL_API_COMPAT

I wonder, is this possibly a comment that made you wonder?
 * For any version number up until version 1.1.x, <version> is expected to be
 * the calculated version number 0xMNNFFPPSL.  For version numbers 3.0.0 and
 * on, <version> is expected to be only the major version number (i.e. 3 for
 * version 3.0.0).

The reason for going with major versions only is that there's a policy decision to only introduce new deprecations at new major release boundary, so limiting the future of OPENSSL_API_COMPAT on major version number only should be incremental enough.  Note that the code still supports the 0xN0000000L style for a foreseeable future (at least until N == 0x7, which I expect to be quite far in the future :wink:).
I hope that's conclusive enough for an approval at this point.

Rebased and with modifications to doc/man7/openssl_user_macros.pod.in

 * For any version number up until version 1.1.x, <version> is expected to be
 * the calculated version number 0xMNNFFPPSL.  For version numbers 3.0.0 and
 * on, <version> is expected to be only the major version number (i.e. 3 for
 * version 3.0.0).

This issue I see with this is that new APIs may be introduced at almost any time (I'm thinking of minor version increments), and this would prevent anyone from checking for them. I think the minor version number should be included as well.

This issue I see with this is that new APIs may be introduced at almost any time (I'm thinking of minor version increments), and this would prevent anyone from checking for them. I think the minor version number should be included as well.

This is a whole other can of worms, as we have no marking at all to support this in the header files.  This is about compatibility backward, right?  I.e. check if source built around OpenSSL 1.1.1 can also be compiled against 1.1.0?  We have no special support for this, and introducing that is a lot of work.
The OPENSSL_API_COMPAT macro was introduced to incrementally check how far forward one can build some piece of software without getting errors for missing (deprecated) symbols.

Note that I'm not trying to dismiss the backward check off-handedly.  I just think that it doesn't belong in this PR.

But for this PR, I think:
 * For any version number up until version 1.1.x, <version> is expected to be
 * the calculated version number 0xMNNFFPPSL.  For version numbers 3.0.0 and
 * on, <version> is expected to be only the major version number (i.e. 3 for
 * version 3.0.0).

Should be:
 * For any version number up until version 1.1.x, <version> is expected to be
 * the calculated version number 0xMNNFFPPSL.  For version numbers 3.0.0 and
 * on, <version> is expected to be just the major and minor version number
 * (i.e. 3.0 for version 3.0.0).

It's a change to just the comment for this PR, and only a commitment to update the minor version too (which is not done all that frequently). The more information that can be provided, the better for the end-users.

Looking through the diff a bit more carefully, I realize that it's not quite as simple as I had presumed, but I still think the minor version is important, and if it is to be included, should be done in this PR.

Basically, am I compiling against a version of OpenSSL that contains this new API yet?

That being said, I think the documentation should be updated (but not in this PR!) with the minimum OpenSSL version that an API was introduced.

If you look at certain manuals, you will see that there's a HISTORY section...  we've been adding those as we go, more or less since we started working on the 1.1.0 release.
(BTW, should you find the time to dig into history and add a few lines to some manual you happen to look at, PRs welcome!!!  This can't be repeated enough)

Looking through the diff a bit more carefully, I realize that it's not quite as simple as I had presumed, but I still think the minor version is important, and if it is to be included, should be done in this PR.

For the current usage, the minor version has no meaning whatsoever, because it's our policy to only introduce deprecations at major release boundary, and our major release will be tied (again, finally) with the major version number starting with 3.0.0.

Basically, am I compiling against a version of OpenSSL that contains this new API yet?

I'm thinking of open-source programs that can take advantage of new OpenSSL features if available, rather than failing outright. Not dissimilar to programs supporting both OpenSSL 1.0.x/1.1.0.

If you look at certain manuals, you will see that there's a HISTORY section... we've been adding those as we go, more or less since we started working on the 1.1.0 release.

Yes, and it would be better if the value to be checked against were in the documentation; rather than having to dig for it... but again, too much for this PR.

For the current usage, the minor version has no meaning whatsoever, because it's our policy to only introduce deprecations at major release boundary, and our major release will be tied (again, finally) with the major version number starting with 3.0.0.

I'm not talking about deprecations... I'm talking about new APIs: function Xyz() added in 3.1, but not available in 3.0.

So, I'm quite frankly not very keen on supporting minor numbers... yet, I'm considering it.

Thank you, the more information we can give the user, the better.

I'm not talking about deprecations...

[sigh] I get that.  However, OPENSSL_API_COMPAT is designed for deprecation checks.
So when I think of this, it needs a redesign to support what you want, and I think that's too big for this PR.

If OPENSSL_VERSION_NUMBER remains consistent, then it should allow for the appropriate checks (since that's what it seems most apps are using to check for things, now). But I'm not sure OPENSSL_VERSION_NUMBER can really ever be deprecated

But I'm not sure OPENSSL_VERSION_NUMBER can really ever be deprecated

I'm pretty sure that by version 8.0.0, it will stop working correctly.  It should be removed by then.

Is there anything more blocking this?

Fixups look good.

@mspncp requested that another @openssl/omc member review and rubber stamp this.  I think that's a good idea in this case.

doc-nits failure reported by travis:
$ if [ -n "$CHECKDOCS" ]; then if $make doc-nits; then echo -e '+\057\057 MAKE DOC-NITS OK'; else echo -e '+\057\057 MAKE DOC-NITS FAILED'; false; fi; fi

(cd .; /usr/bin/perl util/find-doc-nits -n -p ) >doc-nits

doc/man3/OPENSSL_version_text.pod:1: the following exist as other .pod files:

OPENSSL_VERSION_TEXT

make: *** [doc-nits] Error 1

+// MAKE DOC-NITS FAILED

doc-nits failure reported by travis:

That has already been commented upon here, here (with followups).  It looks like a Travis screwup.

I think I've addressed everything but the OpenSSL_version question now.

@t-j-h, you were out of sync there, please look again.  The manuals still need fixing, though, that's entirely correct.

Squashed all fixup commits

@t-j-h, apropos CIs being green, it seems that one Travis job just won't.  See previous comments on the matter (I'm getting really tired of having to repeat this)

Gah, there was another nit, I had forgotten to fix up util/libcrypto.num.  Is re-approval needed?

Same with the manual after all the OPENSSL_info vs OpenSSL_version changes...

Ooooh, all CIs green!

What about @mattcaswell's red cross? Shouldn't it be dismissed at least?

As far as I can tell, all of @mattcaswell's concerns have been answered at this point.  I'm not in the habit of dismissing reviews.  Besides, it seems the better habit is to resolve each review conversation individually...  which has been done.

Looks ok other than the couple of comments I just added.

Looks ok with the latest small fixups?

Argh...  sorry :-/


Add Composite Purchase Orders to BatchPoster

Update BatchPoster to support composite purchase order objects.

@bltravis Did you say you had completed this? Should the issue be closed?


Amplify Automated Code Pipeline for Gatsby App in monorepo fails at the build step

I have a gatsby app with an amplify backend working locally.
I have connected the app in the Amplify console to my github repo for the master branch and on commit to master the deploy process starts.
The build step fails with this error log output
2020-09-25T20:41:55.570Z [INFO]: # Starting phase: preBuild
                                 # Executing command: yarn install
2020-09-25T20:41:56.130Z [INFO]: yarn install v1.16.0
2020-09-25T20:41:56.252Z [INFO]: [1/4] Resolving packages...
2020-09-25T20:41:56.858Z [INFO]: [2/4] Fetching packages...
2020-09-25T20:42:13.555Z [INFO]: info<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=v10.22.0". Got "10.16.0"
                                 info "<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
2020-09-25T20:42:13.556Z [INFO]: info<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=v10.22.0". Got "10.16.0"
                                 info "<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
                                 info<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=v10.22.0". Got "10.16.0"
                                 info "<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
                                 info<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=v10.22.0". Got "10.16.0"
                                 info "<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
2020-09-25T20:42:13.567Z [INFO]: info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
2020-09-25T20:42:13.568Z [INFO]: info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
2020-09-25T20:42:13.572Z [WARNING]: error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^10.17.0 || ^12.0.0 || >= 13.7.0". Got "10.16.0"
2020-09-25T20:42:13.583Z [WARNING]: error Found incompatible module.
2020-09-25T20:42:13.584Z [INFO]: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
2020-09-25T20:42:13.599Z [ERROR]: !!! Build failed
2020-09-25T20:42:13.675Z [ERROR]: !!! Non-Zero Exit Code detected
2020-09-25T20:42:13.675Z [INFO]: # Starting environment caching...
2020-09-25T20:42:13.675Z [INFO]: # Environment caching completed
Terminating logging...

The Gatsby app is ./demo
The build settings are:
version: 1
applications:
  - backend:
      phases:
        build:
          commands:
            - '# Execute Amplify CLI with the helper script'
            - amplifyPush --simple
    frontend:
      phases:
        preBuild:
          commands:
            - yarn install
        build:
          commands:
            - yarn run build
      artifacts:
        baseDirectory: public
        files:
          - '**/*'
      cache:
        paths:
          - node_modules/**/*
    appRoot: demo

It looks like the failure is at the install step.
Anyone seen a similar error?  How can I go about troubleshooting this?

I ran into this problem too. Amplify uses nvm to manage versions of node so you do something like this:
frontend:
  phases:
    preBuild:
      commands:
        - nvm install 12.0.0
        - nvm use 12.0.0
        - yarn install
    build:
      commands:
        - nvm install 12.0.0
        - nvm use 12.0.0
        - node -v
        - yarn run build

Thanks. That solves the issue for me and now I know about using nvm in Amplify!  I am going to close the issue since this seems to fix it.


Document APIs for the System.Composition.Hosting Namespace.

Add missing documentation for the System.Composition.Hosting Namespace
This namespace contains the following classes:
CompositionFailedException
CompositionHost
ContainerConfiguration
Information was pulled from the source code at:
https://github.com/dotnet/corefx/tree/master/src/System.Composition.Hosting/src/System/Composition/Hosting
Fixes #2389
Suggested Reviewers
@mairaw

@rpetrusha I checked the documentation against the MSDN topics and made adjustments accordingly.

@rpetrusha Thanks Ron. I made all of your suggested changes. This should be ready to go.


Feat: Remove SeverityLevel from ValidationNotice constructor

Closes #1472.
Cleans up ValidationNotice(SeverityLevel) constructor calls, as SeverityLevel is now read from the @GtfsValidationNotice annotation.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

Hi @bdferris-v2 , can we update the documentation located on NEW_RULES part of this PR?

@davidgamez done


Remove UUID deps from circe and add memeid4s-scalacheck project

What has been done in this PR?

Remove explicit dependencies as stated in #109
Add missing memeid4s-circe tests
Move Arbitrary instances to its own module memeid4s-scalacheck
Fix some return types in memeid.UUID class
Make version constructors private

Referenced issues
This PR closes #109
This PR closes #106

LGTM!


How to make the 2 columns in same section having the same height

Currently, I need to design an email with the border between two columns. Now i set the border-left to the right column. But if the first column 's height is bigger than the second column's height. It 's not correct at all
** Expected **

Screenshots and GIFs

MJML version:
4.1.0
<mj-section>
// this one 's height is bigger
<mj-column><mj-text>abc</mj-text></mj-column>
// this one 's height is smaller
<mj-column border-left="1px solid grey"><mj-text>abc</mj-text></mj-column>
</mj-section>

Any ideas how to do that? Please help me suggest ideas. Thanks all.

Hey, indeed columns are fluid so you can't force an absolute height. However there are workarounds, I'm thinking for example of one of those two:

setting a border-right on the left column as it's the highest
creating a gutter between the two columns and having the blue separator as a background-color instead of a border

Feel free to share your existing code so I can reuse it to show you how to use those workarounds.


Migrate to metav1 methods for manipulating controllerRefs

Fixes #1430

+100 for executing on this

The build is green.


Fix marker of ListAccessKeys()

It uses a marker of ListUsers as a marker of ListAccessKeys when it gets resources of IAM Users.
Invalid Marker Error is occurred by the problem if many users exist.
This pull request fixes it.

Nice find/fix. Thanks!


Fix histogram truncation.

Extracted from https://github.com/dmlc/xgboost/pull/7180 .
Along with some linter fixes.

Merging this to unblock the CI for #7185 and #7186


Is this Open Source

Hi Abhi,
Just curious, if this is open source and can be forked by me to be used commercially?
Thanks,
Krishna

Hi Krishna,
Thanks for showing interest.
It is under "do whatever you want with it" license. :) So go on!


Request bodies

Seems like it's using php://input as request body instead of the request body stream provided by ReactPHP. php://input is additionally a read-only stream.
https://github.com/NigelGreenway/reactive-slim/blob/701667b3c2b2538d2fe2eab9a0db3d09d4a36f4b/src/Server.php#L87

@kelunik I wasn't sure about the best practice on this as the React\Http\Request does not allow me to access the body, unless I am missing something?

@NigelGreenway It's an event emitter that emits "data" events on body chunks, but I guess you have to buffer it yourself.

That makes sense, so I would do the following:

$stream = new Stream('php://input', 'w')'

$request->on('data', function($body) use (&$stream) {
    $stream->write($body);
});

$stream->rewind();

// Hydrate new PSR7 Response object

You'll need a readable stream for PSR-7, so not just "w" and in your example $stream->rewind() will be called before any data has been received. You'll need something like:
$request->on("data", function ($chunk) use ($stream) {
    $stream->write($chunk);
});

$stream->on("end", function () use ($stream) {
    $stream->rewind();
    // dispatch
});

But if you use that, you always have to fully buffer any body. The ReactPHP guys might be able to tell you more.
The main problem is that PSR-7 has been designed for synchronous applications with blocking IO. It won't really work in an async context, no matter how hard you try it.

Hey @kelunik, can you check over this PR #10 as I think I've sorted it but wondered if I am missing something as I'm trying to understand how this process works.. :smiley:


ServiceFabricManagementClient for connecting to Secure Cluster

How do you use the ServiceFabricManagementClient class to connect to a secure service fabric cluster? The only documentation I have found is this:
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-connect-to-secure-cluster
but this documentation is for FabricClient?
Which class should one use for managing a service fabric cluster?

Hi @javaadpatel,
What operations are you trying to perform on the cluster?
To perform cluster operations from an application on the cluster. FabricClient will allow you to manage Service Fabric services and other entities on a cluster. Please see the FabricClient documentation for more details: https://docs.microsoft.com/en-us/dotnet/api/system.fabric.fabricclient?view=azure-dotnet
If you are trying to connect to a cluster to deploy an application or modify a cluster setting, you can use either the PowerShell or CLI modules as seen in https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-connect-to-secure-cluster. This documentation is not for the FabricClient class.
Please let me know if you need any futher information.

hi @peterpogorski ,
I am trying to list all the applications in the cluster, deploy new applications into the cluster and upgrade existing applications in the cluster.
I am currently using the powershell commands to do these actions but when i saw the ServiceFabricManagementClient class i thought that it was a way to do these actions using c#. because the methods on it like  serviceFabricClient.Applications.ListWithHttpMessagesAsync seemed like that was its purpose, is that incorrect?
I would ideally like to move away from the powershell scripting.

You can definitely complete those operations outside of PowerShell by using the FabricClient.ApplicationManagementClient class. Find more information here: https://docs.microsoft.com/en-us/dotnet/api/system.fabric.fabricclient.applicationmanagementclient?view=azure-dotnet
You can also complete these opeartions using the Service Fabric REST APIs which you can read more about here: https://docs.microsoft.com/en-us/rest/api/servicefabric/


fix: typo

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[ ] I have read the application guidelines.
[ ] Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
[ ] I understand that 30% of each milestone will be paid in vested DOT, to the Polkadot AssetHub address listed in the application.
[ ] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[ ] The software delivered for this grant will be released under an open-source license specified in the application.
[ ] The initial PR contains only one commit (squash and force-push if needed).
[ ] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

我已阅读并特此签署贡献者许可协议。

recheck

recheck


Properly Initialize Callbacks with Dummy Functions

Recent changes from "if (...callback)" to "CHECK(...callback)"
led to failed checks in the Fuzzers, as the callbacks were not
explicitly set.
Those callbacks were default initialized, which would lead to
an runtime exception being thrown on call.
This change initializes all callbacks with functions doing nothing,
but are save to call. Also it replaces the remaining "if"s with
"CHECK"s.
Bug: http://b/168770539
Test: Compile

As Ronald wrote in the bug, this renders the CHECKs useless. Either we accept it and remove the CHECKs, or the initialization to dummy functions should happen in the fuzzer(s).

As written in the bug. These checks are basically explicitly stating the assumption that the function is save to call. Yes, currently this will be the case, but they should prevent us from changes in the future.
However, if you both strongly argue to remove the checks, that would be also fine for me to remove them. I would however, strongly avoid setting the callbacks in the fuzzer.

As written in the bug. These checks are basically explicitly stating the assumption that the function is save to call. Yes, currently this will be the case, but they should prevent us from changes in the future.
However, if you both strongly argue to remove the checks, that would be also fine for me to remove them. I would however, strongly avoid setting the callbacks in the fuzzer.

On my side, the point is not about removing the CHECKs, but rather about the fact that they no longer guarantee that clients of OrbitApp set the callbacks and whether we are fine with this or not. So the question is, why

I would however, strongly avoid setting the callbacks in the fuzzer.

? Is it because they are many and it's messy to set them all for each fuzzer?

As written in the bug. These checks are basically explicitly stating the assumption that the function is save to call. Yes, currently this will be the case, but they should prevent us from changes in the future.
However, if you both strongly argue to remove the checks, that would be also fine for me to remove them. I would however, strongly avoid setting the callbacks in the fuzzer.

On my side, the point is not about removing the CHECKs, but rather about the fact that they no longer guarantee that clients of OrbitApp set the callbacks and whether we are fine with this or not. So the question is, why

I would however, strongly avoid setting the callbacks in the fuzzer.

? Is it because they are many and it's messy to set them all for each fuzzer?

I see your point. My point was basically, not messing up the fuzzer here, you are right. Still I have the feeling, that a controller (the app), should be in a well behaving state after just constructing it.

As for checks... someone could still set these to nullptr if I am not mistaken.. But I agree they look less useful now. Maybe move these CHECKs to Set*Listener functions?

As for checks... someone could still set these to nullptr if I am not mistaken.. But I agree they look less useful now. Maybe move these CHECKs to Set*Listener functions?

Just as a note, the callbacks are all value type functions. It is just that the default constructor of std::function will create a function that fails when it is called.
In general, I like the idea of moving the checks to the setter.

Thanks for your reviews so far. I moved the CHECKS to the setter methods

As written in the bug. These checks are basically explicitly stating the assumption that the function is save to call. Yes, currently this will be the case, but they should prevent us from changes in the future.

You are right that the CHECKs are still useful, but they lose a lot of what they were guarding us against before, which is: At some point between creation of the object and calling these methods, these callbacks have been properly initialized. That logic is potentially fragile and I'm not in favor of losing the guards against that. (Echoing what @dpallotti dpallotti said, I think.)
Moving the CHECKs to the setter as suggested by @dimitry- helps a bit, but it doesn't guarantee that the Set* methods are actually ever called (which is what we have as a guarantee now).
If possible, I'd prefer to fix the root cause in the fuzzer. Can you clarify why you don't like that approach?

I see your point. My point was basically, not messing up the fuzzer here, you are right. Still I have the feeling, that a controller (the app), should be in a well behaving state after just constructing it.

But is it even possible that the app is in a well behaving state just after constructing it? If the callbacks are default initialized to do nothing, then you can call them (in the places where we had the CHECKs), but the UI is broken (unless the Set* methods are properly called, which we would have no guarantee for anymore). I'd not consider that well behaving.

I see your point. My point was basically, not messing up the fuzzer here, you are right. Still I have the feeling, that a controller (the app), should be in a well behaving state after just constructing it.

But is it even possible that the app is in a well behaving state just after constructing it? If the callbacks are default initialized to do nothing, then you can call them (in the places where we had the CHECKs), but the UI is broken (unless the Set* methods are properly called, which we would have no guarantee for anymore). I'd not consider that well behaving.

I'd argue that this depends on the definition of well behaving. The whole idea of the callbacks is to decouple our controller (the app) from the UI. So a controller that has not called the Set* methods, can still count on the behaviours of functions, but with having no visual response. Which is especially true for the fuzzer, but might also be relevant for e.g. tests.
As I said, I also see your point. I would loop in @beckerhe, as this would basically affect the fuzzers.

I'd argue that this depends on the definition of well behaving. The whole idea of the callbacks is to decouple our controller (the app) from the UI. So a controller that has not called the Set* methods, can still count on the behaviours of functions, but with having no visual response. Which is especially true for the fuzzer, but might also be relevant for e.g. tests.

The case we care about the most is the behavior when the app is in front of a user. Maybe there is a different way to guarantee that callbacks have been properly initialized or maybe the fuzzer could use a different type of App class, etc. I don't have insight into all parts that are affected here, but I'd like use to carefully consider what we are giving up here.

I'd argue that this depends on the definition of well behaving. The whole idea of the callbacks is to decouple our controller (the app) from the UI. So a controller that has not called the Set* methods, can still count on the behaviours of functions, but with having no visual response. Which is especially true for the fuzzer, but might also be relevant for e.g. tests.

The case we care about the most is the behavior when the app is in front of a user. Maybe there is a different way to guarantee that callbacks have been properly initialized or maybe the fuzzer could use a different type of App class, etc. I don't have insight into all parts that are affected here, but I'd like use to carefully consider what we are giving up here.

Right. As I said, I have no strong opinion on this. So I changed the code accordingly (default initiazlization and checks in the App and Set* calls in the Fuzzer).

Done. Will merge now. Thanks for the review!.


Update dependencies on readme

Fix dependency on jsoup

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[ ] a bug fix -- which issue? #...
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix

Description
Please add details about your change here.
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.

[ ] Downloads all relevant content.
[ ] Downloads content from multiple pages (as necessary or appropriate).
[ ] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Hey, this repo is pretty much dead. All development has moved to https://github.com/RipMeApp/ripme

thanks

Was merged on the other repo.


detect if Mac's Metal Performance Shaders are available

Default to Torch's mps backend if available when cuda is not.

Closing as https://github.com/openai/whisper/pull/382 already exists.


Remove Pod Security Policies

PodSecurityPolicy (PSP) was removed in Kubernetes v1.25 in favor of PodSecurityAdmission (PSA) which is easier to use but less flexible.  I believe we can just remove all PodSecurityPolicy resources from the cluster setup Helm charts and eventually enable PodSecurityAdmission for our namespaces to tighten security.  I don't think we need to do that for the public NEONKUBE release though.
https://hackernoon.com/migrating-from-pod-security-policies-a-comprehensive-guide-part-1-transitioning-to-psa

DONE


[Bug]: Embedded DuckDB error with 0.3.21 (thought already fixed)

What happened?
Just an FYI I used docker to run Chroma, pulled 0.3.21:
docker run -p 8000:8000 ghcr.io/chroma-core/chroma:0.3.21
Still got this in the container which I believe was apparently fixed in 0.3.13?
2023-05-15 13:29:17 WARNING  chromadb        Using embedded DuckDB without persistence: data will be transient
I didn't create an env..yet!
Versions
Chroma 0321, Python 3.10.10, Windows docker desktop
Relevant log output
Also not sure why this is an error below when it looks literally just INFO/all good.

2023-05-15 13:29:17 INFO     chromadb        Running Chroma using direct local API.
2023-05-15 13:29:17 WARNING  chromadb        Using embedded DuckDB without persistence: data will be transient
2023-05-15 13:29:17 INFO     uvicorn.error   Started server process [76]
2023-05-15 13:29:17 INFO     uvicorn.error   Waiting for application startup.
2023-05-15 13:29:17 INFO     uvicorn.error   Application startup complete.
2023-05-15 13:29:17 INFO     uvicorn.error   Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

Not to be an annoy-a-tron but also see'ing the docker image trying to recreate the collection over and over again during ingestion.
f is not defined:
"   raise ValueError(f"Collection with name {name} already exists")
ValueError: Collection with name chroma-store already exists
2023-05-15 14:37:05 INFO     uvicorn.access  <IP_ADDRESS>:39236 - "POST /api/v1/collections HTTP/1.1" 500"
ValueError: Collection with name chroma-store already exists
2023-05-15 14:37:05 INFO     uvicorn.access  <IP_ADDRESS>:39236 - "POST /api/v1/collections HTTP/1.1" 500

Chroma with 0.4 has now dropped duckdb. Closing this issue.


chore: rename service files to exactly match service names

#184613881

question: Since we're renaming things, shouldn't we rename the terraform/* folders as well?


Why does the loop exit automatically

def drawRect(lineString):

    # lineString is a dictionary
    # len(lineString) = 40
    for j in range(0,len(lineString)):
        print(j)
        i = lineString[j]
        maxLat = max(i['y'])
        minLat = min(i['y'])
        maxLng = max(i['x'])
        minLng = min(i['x'])
        G = ox.graph_from_bbox(maxLat+0.01,minLat-0.01,maxLng+0.01,minLng-0.01,network_type='drive', truncate_by_edge=True,retain_all=True  )
        for k in range(len(i['x'])):
            G.add_node(-k, y=i['y'][k], x=i['x'][k], osmid=-k)
            if k != 0:
                G.add_edge(-(k-1), -k, weight=2/(k+1), length=0)
        fig,ax = ox.plot_graph_route(G, [-k for k in range(len(i['x']))], save=False, show=False, route_color="blue")
        fig.savefig("匹配前/"+str(i['id'])+".png")

I use this loop to draw road networks, but this loop will exit automatically. I tried to decrease the bbox, and it run more loops. Will it caused by the memory ?

This does not appear to document a bug with OSMnx. If this is a usage question, please ask on StackOverflow as per the issue guidelines and the contributing guidelines.


Using search causes mopidy to stop

Hello, I encountered an issue when trying to use containerized version of mopidy. Using the "search" feature of the web client crashes mopidy.
Here's the original issue: https://github.com/wernight/docker-mopidy/issues/7
I did some investigating, and it seems like mopidy-youtube caues the problem.
This is the last lines mopidy outputs before crashing:
DEBUG    2017-02-19 18:21:46,597 [1:HttpServer] mopidy.http.handlers
  Received WebSocket message from <IP_ADDRESS>: u'{"method":"core.library.search","params":{"any":["asdf"]},"jsonrpc":"2.0","id":56}'
INFO     2017-02-19 18:21:46,605 [1:YouTubeBackend-3] mopidy_youtube
  Searching YouTube for query 'asdf'

-o youtube/enabled=false fixes the problem, but I can't search for youtube videos :(
Tried playing with pafy and youtube-dl using pip, and also confirmed that I can get youtube video info using pafy. More details in linked issue.

When you say it crashes, do you mean it actually crashes? Do you have a stack trace or a core dump?

The docker container stops, as if the app was stopped

Turns out it was an issue with kernel security (PaX). Running this on linux alpine solves the problem:
sysctl -w kernel.pax.softmode=1


Is there any way to use blueprint without custom css attributes (bp-layout)?

I'm trying to use blueprint with react, which doesn't allow custom attributes to be used. Is there anyway to use this with class names?

If you use the Sass src directly you can set the prefix value in the config to data-bp-layout instead of bp-layout. That should allow it to be used with react.  I am working on adding more selector customization in the near future.
https://github.com/splintercode/blueprint-css/blob/master/src/_config.scss

For anybody having the same problem, here is how to compile it yourself with a custom attribute data-bp that will be accepted by React:

@import "~blueprint-css/src/_config.scss";
$prefix: 'data-bp';
@import "~blueprint-css/src/_base.scss";
@import "~blueprint-css/src/_column-generator.scss";
@import "~blueprint-css/src/_grid.scss";
@import "~blueprint-css/src/_util.scss";
@import "~blueprint-css/src/_spacing.scss";

Is there a particular reason you are using a custom css attribute? compared to just using class?


Add Font Awesome

Fixes Issue

Closes #1108
Changes proposed

I have added a font resource to the website.
Screenshots

Note to reviewers

This PR is part of GSSoC'23.

Thanks, @CBID2!

Done, @rupali-codes!


Event label not displayed after migrating to v4?

Bug or feature request?
Possibly a bug.
Description:
Event label not displayed in chart?
(Bug) Expected result:

(Bug) Actual result:
Timer is not displayed in chart
(Bug) Potential fix:
Downgrade to v3 has this fixed, maybe this is something configurable for v4 somewhere but not documented?

Is this for the old visualizer?

Yep, the screencap was from v3,  but thought it would be great for v4 to display the label too.

The new visualizer displays events inline with the state. The design may change in the future, though, but this is currently working as intended.

Wondering how does one display both CLOSE and ESC events on one state in v4? I tried the online editor but the second event will overlap the first one, hence not displaying two events at once.
Ps. The screencap below is from v3, as seen in the documentation.


The changes made in the In Flow section in the implement tab of the publisher is not working in the tenant mode.

Description: When we modify the In Flow section in the publisher and changes are not persisted in the UI and as well as in the file system (<WSO2AM_Home>/repository/tenants/<tenant_name>/synapse-configs/default/api/).  But it is working in the super tenant mode.
Steps to reproduce:- Create a tenant user in the carbon console.
Go to the publisher and create an API.
In the implement, tab make some changes in the In Flow section( Not the In Flow section in the message mediation). See the attached image for reference.
The changes made in the In Flow is not persisted in the UI as well as in the File system.

It is working in the super tenant mode.

what's the APIM version?

API Manager 2.2.0

public commit: #https://github.com/wso2/carbon-apimgt/commit/81bd4bfb85dde3d7685a26dc6d6036862d54b362


chore: show QR with lowercase invoice value

Describe the changes you have made in this PR
From unes on Telegram:

when generating an invoice using the extension then scan the qr code using a mobile app or a centralized exchange the invoice url is in uppercase and some apps does not allow this

Is there any reason why we use toUpperCase()?
Type of change
(Remove other not matching type)

fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?
Manually
Checklist

[x] Self-review of changed code
[x] Manual testing
[x] Added automated tests where applicable
[x] Update Docs & Guides
For UI-related changes
[x] Darkmode
[x] Responsive layout

Sorry for opening this. QRs should always have BOLT-11 in upper case. See requirements.


Update Release version;

Some dependencies package such as Go dep, reads the release version as v1 and it is very old;

Fixed


Add CLI parameters and VSCode settings for tracing

Is your feature request related to a problem? Please describe.
Currently, tracing is controlled by two environment variables, BICEP_TRACING_ENABLED and BICEP_TRACING_VERBOSITY, and there is no documentation for them. We always have to teach customers how to set environment variables when investigating Azure SDK related issues. It would be more convenient to add flags for Bicep CLI (e.g., --debug and --verbose) and VSCode settings to configure tracing for Azure SDK.

Related

https://github.com/Azure/bicep/issues/4841


Incorrect anchor tag pairing

When instancing new anchors the tags are not unique compared to other nodes that were created with the same name. This prevents noodles from being dragged onto anchors of other instances.

This is no longer relevant with the new noodle/anchor system.


Logger not available in Objective-C project

I'm using this SDK on an objective c project, however i cannot access the logger property of the PiwikTracker class, or any Logger class for that matter.
#import "PiwikTracker-Swift.h"
// (...)
[PiwikTracker configureSharedInstanceWithSiteID:siteId baseURL:piwikUrl];
[PiwikTracker shared].logger = (...) // compile error: Property 'logger' not found on object of type 'PiwikTracker *'
[PiwikTracker shared].dispatchInterval = 10;

Am I missing something here? Thanks in advance.

Hi @joaomvfsantos, this can very well be true. I will have a look into it.

Hi @joaomvfsantos, I just checked this out. Please try out this branch feature/185-logger-in-objc and use something like [PiwikTracker shared].logger = [[DefaultLogger alloc] initWithMinLevel:LogLevelVerbose]; to define your log level.
Please get back to me if you tried it.

Hello @brototyp I'll try to have a look at this in the next few days. I'll keep in touch.

@brototyp This seems to be working. Thanks

@joaomvfsantos Great. I will merge it soon. It will be part of the next release.

This just got merged and will be part of the next release

Just released version 4.4.0 containing this change.


Load search parameters doesn't clear parameters

I picked up the updates for Issue #7 that you implemented. They worked, but I may have found a bug:

If I load a saved search, parameters that aren't in the loaded search don't get cleared out. These screenshots show after I load the "exclude" : "Exclude" search, then the "author" : "Erik" and "query" : "BOOM!" parameters didn't get cleared out.

Yes, the current implementation of #7 will only add new parameters or change values of existing ones.

Fixed in 5d9063f


[RTM] fixing master merge

For some reason this was missing from merging master last night.

Looks good.


MatDatePicker subtracts 1 day from selected date

Description
This issue have been talked about before, but from what Im seeing the bug is still here. Its very simple: Add MatDatePicker component and select a date. The output is selected date - 1 day.
Using the ToLocale does not seem to fix the issue.
On my local machine it works fine but when I upload to Azure the bug starts to show. The number you select in the datepicker should reflect the output.
Steps to reproduce the behavior:

Create a new project and install the MatBlazor package.
Add MatDatePicker to a page.
Select a date

In this example I select the 23rd. The code was uploaded to an Azure web app so this example is not from my locale machine.
Screenshots

Can confirm too. Happens locally and on my server. I also tried overriding the Format property on MatDatePicker in multiple ways and always yields date -1.
I've tried stepping through some of the Flatpickr and matblazor JS and it looks like the correct date is being passed there; the pop-up shows the correct date and the text field is minus 1 day.

I am also getting this issue when selecting a date a -1 value is set on the bound field

For me it's always setting time to 10 PM (I have time picker completely disabled too, only date) and thus it also results in setting -1 day than selected. The date is set to UTC.
However in my case calling date.ToLocalTime() sets the time back to 00:00:00 (from 10:00:00 PM) so it kind of works around the issue. But definitely needs a long term fix ASAP

And there are two similar cases:

at MatBlazor site DatePicker yields selected date -1 and shows it with that new value;
in my proj DatePicker does things equal, but shows correct date (and sets yieded date to binded value)

Ладно, мой английский заставляет страдать, так что на всякий случай пишу ещё и так.
Наблюдаю два схожих случая:

на Вашем сайте MatBlazor DataPicker устанавливает значение со сдвигом на -1 и отображает его уже сдвинутым;
в моём проекте он всё так же устанавливает забинженое значение со сдвигом на -1, но отображает при этом корректную дату

for me in the datepicker(ui) it shows 2nd Feb but when I am fetching the value from formControl it subtracts 1 from days.
The display and the fetched values should be same.

In my case worked the following:

yourDate.toLocaleDateString() --> DD/MM/YYYY
yourDate.toLocaleString() --> DD/MM/YYYY HH:mm:ss

Still having this issue in 2024. Is there any news on an update to fix this without needing to add workarounds?

With no other option, I have written a wrapper for this component. ToLocalString() is in a package that is no longer available, and my use case is one where I need this component to work for a large number of date picker fields, that are part of larger objects and in lists. I know it isn't a perfect solution and there are likely improvements to be made, but it's an "it just works" solution. Depending on your specific use case you'll need to change the magic 3 to whatever you need to pass your time-zone difference. I have seen some solutions out there that calculate the offset for this, but they require other packages and more computing time.
I only need the date portion of the field and I have no idea how you'd go about editing what I've done to make it work with times.
We have the Wrapper component DatePickerField:

The UpdateDateProperty function:

it's use:

Removing the time stamp from date picker and then converting to localdate might work.


Integrates Hutch output with OpenSpiel.

What's the problem?
OpenSpiel is fed by JSON output from Explain which is like so:
[
  {
    "Plan": {
      "Node Type": "Sort",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 1047.14,
      "Total Cost": 1070.73,
      "Plan Rows": 9435,
      "Plan Width": 62,
      "Sort Key": ["d.d_city"],
      "Plans": [
        {
          "Node Type": "Nested Loop",
          "Parent Relationship": "Outer",
          "Parallel Aware": false,
          "Async Capable": false,
          "Join Type": "Inner",
          "Startup Cost": 3.23,
          "Total Cost": 424.25,
          "Plan Rows": 9435,
          "Plan Width": 62,
          "Inner Unique": false,
          "Join Filter": "(o.no_w_id = w.w_id)",
          <snip>
        }
       ]
    }
  }
]

while the output from Hutch (EXPLAIN (format tscout) ... ) is as follows:
[
  {
    "Tscout": {
      "node": "node-0",
      "tag": "ExecSort",
      "Sort_plan_type": 42,
      "Sort_plan_startup_cost": 1047.143336,
      "Sort_plan_total_cost": 1070.730836,
      "Sort_plan_plan_rows": 9435.000000,
      "Sort_plan_plan_width": 62,
      "Sort_plan_parallel_aware": false,
      "Sort_plan_parallel_safe": true,
      "Sort_plan_async_capable": false,
      "Sort_plan_plan_node_id": 0,
      "Sort_plan_targetlist": "<skipped>",
      "Sort_plan_qual": "<skipped>",
      "Sort_plan_lefttree": "<skipped>",
      "Sort_plan_righttree": "<skipped>",
      "Sort_plan_initPlan": "<skipped>",
      "Sort_plan_extParam": "<skipped>",
      "Sort_plan_allParam": "<skipped>",
      "Sort_numCols": 1,
      "Sort_sortColIdx": "<skipped>",
      "Sort_sortOperators": "<skipped>",
      "Sort_collations": "<skipped>",
      "Sort_nullsFirst": "<skipped>",
      "Plans": [
        {
          "node": "node-1",
          "tag": "ExecNestLoop",
          "NestLoop_join_plan_type": 37,
          "NestLoop_join_plan_startup_cost": 3.225000,
          "NestLoop_join_plan_total_cost": 424.253750,
          "NestLoop_join_plan_plan_rows": 9435.000000,
          "NestLoop_join_plan_plan_width": 62,
          "NestLoop_join_plan_parallel_aware": false,
          "NestLoop_join_plan_parallel_safe": true,
          "NestLoop_join_plan_async_capable": false,
          "NestLoop_join_plan_plan_node_id": 1,
          "NestLoop_join_plan_targetlist": "<skipped>",
          "NestLoop_join_plan_qual": "<skipped>",
          "NestLoop_join_plan_lefttree": "<skipped>",
          "NestLoop_join_plan_righttree": "<skipped>",
          "NestLoop_join_plan_initPlan": "<skipped>",
          "NestLoop_join_plan_extParam": "<skipped>",
          "NestLoop_join_plan_allParam": "<skipped>",
          "NestLoop_join_jointype": 0,
          "NestLoop_join_inner_unique": false,
          "NestLoop_join_joinqual": "<skipped>",
          "NestLoop_nestParams": "<skipped>",
          <snip>
          }
      ]
    }
  }
]

In a nutshell, the problem is that OpenSpiel expects fixed keys in JSON, while Hutch returns variably named keys.
What's the solution?
Three approaches were discussed to fix this problem:

Making changes to database.cc in OpenSpiel to do an "ends with" search to figure out the names of the keys.
Adding intelligence to OpenSpiel to "understand" the structure behind the name of the key
Adding intelligence to Hutch to spit out fixed keys.

As a first cut solution, we've implemented (1) which is what this PR addresses.
TODO:
Validate end-to-end that this doesn't break anything

@17zhangw - With the latest changes, I've verified that nothing breaks end-to-end.

In that case, you'll likely also need to modify demo/mvp.sh so it properly loads/installs Hutch as needed (there are already doit tasks for that). I believe we'll also need another OpenSpiel feature flag like use_hutch (similar to use_hypopg) that can ensure attempts to EXPLAIN (FORMAT TSCOUT) succeed.

Hutch still needs to be installed manually. There is a small discrepancy between the installation process for Hutch when its installed standalone vs when it is run with demo/mvp.sh. Will pick this up next.
About the flag - I thought that Hutch will be replacing the EXPLAIN (format json) output? Making this a flag would probably lead to a lot of if-elses in the code, both here in OpenSpiel and potentially in the build process.

Just saw the latest diff and it makes sense to me. Thanks!
About the issue with running through demo/mvp.sh, does doit noisepage_hutch_install not work?

About the issue with running through demo/mvp.sh, does doit noisepage_hutch_install not work?
Checked and validated that this indeed works. We're good to go!


sbp_rectangle_insert stopped working

I just noticed my sbp_rectangle_insert (hot key: ctrl-x, r, t) stop working. The text box appears when I hit the hot key but there is no effect after hitting enter. The text in my document is left unchanged. This hot key used to work fine and I am not sure when it stop working for me.
Any ideas?

Probably related to the multi-cursor work I did recently, where multi-cursors are supported for killing and yanking and setting and exchanging the mark.
Can you give me instructions from start to finish on how to use rectangles? I didn't implement it and I don't know how they work. I will look into the problem if you give me a quick tutorial.

Sure... you highlight a rectangular section of text, then use "ctrl-x, r, t" to replace everything in that section.
For example to replace all the 2's and 3's with 8's and 9's in the following text you would rectangular highlight all the 2's and 3's, hit "ctrl-x, r, t", enter 89 then hit enter.
01234
01234
01234
01234

Result:
01894
01894
01894
01894

I see the problem. If I create a branch can you test it for me?
BTW - your example can also by achieved by highlighting the rectangular selection as you have done, and then just type "89". Assuming you highlight the selection using the Option while selecting. The emacs rectangle code is for people who are not used to multiple cursors and would just set a mark at the first 2 and then move to the last 3 and THEN run your C-x, r, t command.

I pushed a branch called rectangle_fix. Let me know if you can make use of it to test the changes. If not, I will just push a new version with fingers crossed.

How do I install a different branch of a package in Sublime?

I actually made a release. Maybe you’ve already received it?

On 16 Mar 2015, at 04:43, rowoflo<EMAIL_ADDRESS>wrote:
How do I install a different branch of a package in Sublime?
—
Reply to this email directly or view it on GitHub https://github.com/grundprinzip/sublemacspro/issues/112#issuecomment-81410090.

Yes, I did and it works! Thanks!


Rescript snippets extending

Hi. Yesterday I've made a pull request with new snippets. https://github.com/rafamadriz/friendly-snippets/pull/121 for rescript.
I'm gonna to extend this little bit in the future.

Ok. Good. Thanks.


Update metatests to v0.2.2

Landed in https://github.com/metarhia/metasync/commit/839b8e6b9eab66752344e70c760f2898919ad0af.


Add common tests for ByteBufAllocator / AbstractByteBufAllocator impl…

…ementations.
Motivation:
We not had tests for ByteBufAllocator implementations in general.
Modifications:
Added ByteBufAllocatorTest, AbstractByteBufAllocatorTest and UnpooledByteBufAllocatorTest
Result:
More tests for allocator implementations.

unit tests FTW.

Cherry-picked into 4.1 (756b78b7dfcf235ea84450a741312d6292b2040b) and 4.0 (e6b9cf4)


Overriding deprecated methods

Describe the bug
2023-07-21 20:19:34.909 WARNING (MainThread) [homeassistant.components.number] custom_components.octopus_energy.intelligent.charge_limit::OctopusEnergyIntelligentChargeLimit is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom integration author.
Reproduction steps
Add this sensor.
Expected behaviour
Message should not apepear in the logs.
Tariff Code
No response
Integration Version
Latest
Home Assistant Version
Up-to-date
Fresh Install?
Not specified
Home Assistant Logs
2023-07-21 20:19:34.909 WARNING (MainThread) [homeassistant.components.number] custom_components.octopus_energy.intelligent.charge_limit::OctopusEnergyIntelligentChargeLimit is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom integration author.

Thanks for raising. Duplicate of https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/issues/313


Purpose of URLParameterEncoding.default?

I was wondering what the purpose of URLParameterEncoding.default is. It isn't a singleton allowing for sharing a single instance of a URLParameterEncoding. Likewise, initializing a URLParameterEncoding with default options seems to be better served by just calling the initializer with no parameters. This pattern also applies to JSONEncoding and PropertyListEncoding.

@cnoon designed this API, but I believe it was to match the previous enum implementation and assist people in transitioning to the new version. It also establishes the general pattern of convenience static properties for preset values. You're right, these could (and likely should) be singleton values, rather than generating a new one every time, but that rather minor refinement can be made at any time. @cnoon, anything to add?

Thanks for the response, @jshier!
I don't think the performance penalty of creating a URLParameterEncoding is too big of a deal. It more just caught me off guard when I wrote a unit test that essentially amounted to URLParameterEncoding.default === URLParameterEncoding.default and it failed. I had mistakenly assumed it was a singleton. When I dug into it I was curious what the reasoning was because it seemed like URLParameterEncoding() would be more idiomatic to create a new instance with default values. I figured it might be a legacy purpose. Thanks for satisfying my curiosity!

Closing this for now. @cnoon, if you have anything else to add please do so.


Add aria-labelledby tag to block if it does not have aria-labelledby or label tag

Fixing #11179
This pr tries to fix issue as mentioned .
Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

@lb- thanks for your review.For testing it properly shall I use bakerydemo ?

Closing as invalid.


(DotNext.Net.Cluster) Leader does not receive IRaftCluster.LeaderChanged event when downgrading to follower

Hello,
I am currently trying to run the 4.2.0-beta.1 version and I have come across a specific issue regarding the log entry writing with Raft and the events associated with it

Have a single node start a standalone cluster (first node)
Add a second member with AddMember (second node)
Kill the process of node 2
Start the process of node 2 again

After step 3 and inspecting my logs, it seems like the leader steps down to follower but does not fire the IRaftCluster.LeaderChanged event. IRaftCluster.Members will still report the local (Remote == false) node 1 as leader on node 1, but attempting to write to the log now will result in
      System.InvalidOperationException: The local cluster member is not a leader
         at DotNext.Threading.Tasks.ValueTaskCompletionSource`1.GetResult(Int16 token) in /_/src/DotNext.Threading/Threading/Tasks/ValueTaskCompletionSource.T.cs:line 272
         at DotNext.Threading.Tasks.ValueTaskCompletionSource`1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token) in /_/src/DotNext.Threading/Threading/Tasks/ValueTaskCompletionSource.T.cs:line 279
         at DotNext.Net.Cluster.Consensus.Raft.LeaderState.ReplicationCallback.Invoke() in /_/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LeaderState.Replication.cs:line 177
      --- End of stack trace from previous location ---
         at DotNext.Net.Cluster.Consensus.Raft.RaftCluster`1.ReplicateAsync[TEntry](TEntry entry, CancellationToken token) in /_/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/RaftCluster.cs:line 818

IClusterMember.MemberStatusChanged will correctly fire and set node 2 to Unavailable during step 3.
This behavior was not present before the upgrade to 4.2.0-beta.1.
After step 4 is done, (on node 1) IClusterMember.MemberStatusChanged will correctly fire and mark node 2 as available again. However, node 1 is still unable to write to the log as it seemingly isn't leader anymore.

@RyanTT , what kind of transport are you using? HTTP/UDP/TCP?

I am using HTTP transport.

@RyanTT , regression has been fixed.

I believe the issue is still present. I've updated my projects to beta.2 and the behavior has remained the same:
After step 3, node 1 is unable to write to the log System.InvalidOperationException: The local cluster member is not a leader.

@RyanTT , do you have a repro code for that?

Sorry for the late response. I'll attempt to write a test to reproduce this issue in the following days.

Hi @RyanTT , did you have a chance to reproduce the issue?

Closing this issue due to lack of activity.


UI Components: Documentation follow up

As ...
P.D. - Nautobot App Developer
I want ...

More before/after examples in migration tutorial
Well described ObjectsTablePanel and improved docstrings
Screenshots that are matching given example code

So that ...
I can follow appropriate best practices and ensure that my App will be forward compatible with Nautobot 3.x with a minimum of migration effort required on my part in the future.
I know this is done when...
Documentation is improved.
Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[ ] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[X] Apps (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[X] Documentation
[ ] Other (not directly a platform feature)

Database Changes

External Dependencies

This is just follow up task after #6275 was closed by merging #6457 with more improvements to the docs.


Update font-karla-tamil-upright to latest

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as 090184dea8e1b934b603661082c7e16e2ab74f17.


Release notes for 3.2.11-3.1

The release notes should have info that we are adding ubuntu yakkety packages. Also we didn't have binary tarballs for ubuntu xenial which were added also.
https://jira.percona.com/browse/BLD-556
This should be also added to release notes (HotBackup functionality was missing from ubuntu/debian packages): https://jira.percona.com/browse/BLD-560

@azhebel I had a discussion with @denis-protyvenskyi and we concluded that every bugfix and new feature should have a public ticket and they should be referenced in the release notes.
So for this "Added :ref:hot-backup to Ubuntu/Debian packages" I would like us to have a link to https://jira.percona.com/browse/PSMDB-92.
The other one (hang issue) currently doesn't have a ticket so unless Denis now want to open one let's leave it as it is.

Also I might add that Ubuntu Wily is removed from supported platforms as that distribution has reached end of life so you might want to put that somewhere.

Add note that the default configuration file has been changed/updated to include some of the options.


I have no problem to retrieve data from the plist
but in my dynamicModel, i have an array, how can I do to modify this array (adding and deleting items) programmatically?
Thank you,
Arthur

You can do it two ways.  If you declare it as a mutable array, you can add the objects like this:
[dynamicModel.mutableArray addObject:@"AnotherObject"];

Otherwise, you'll have to do like this:
NSMutableArray *arr = [dynamicModel.array mutableCopy];
[arr addObject:@"anotherObject"];
dynamicModel.array = arr;

Yes it does!
I thought i couldn't declare an NSMutableArray in the PlistModel class because nsmutablearray is not allowed in Plist.
Thanks!

Hi @mastermyx:
You are correct that a mutable array isn't allowed in a Plist, but this class does some stuff in the background, so you're dealing with it as a mutable array in memory, but it's persisted as an array.
Let me know if other problems come up :)


Sort directories by name when selecting the directory usage

Today, in an account setting, it's possible to select specials directories by usage (sent, trash, drafts...). To select the directory, a pop-up with a select list is displayed but listed directories are not sorted : It's quite complicated to select the right directory if the mailbox contains a lot of directories. Could you please sort entries of this list?

Fixed by #6521


Unexpected warning: Generating index html...2 rules skipped due to selector errors

🐞 Bug report
Command (mark with an x)

[x] build

Is this a regression?
Yes, the previous version in which this bug was not present was: 11.2.3
Description
After upgrade to Angular 12 and CLI 12 the following warning appeared:
✔ Browser application bundle generation complete.
✔ Copying assets complete.
⠋ Generating index html...2 rules skipped due to selector errors:
0 @@ .ui-grid -> Unmatched selector: @@ .ui-grid
✔ Index html generation complete.
🔬 Minimal Reproduction
It's unclear if it's possible to reproduce this behavior on a simple project.
Maybe related to https://github.com/angular/angular-cli/issues/20031?
🌍 Your Environment

Angular CLI: 12.0.0
Nx CLI: 12.3.3
Node: 14.17.0
Package Manager: npm 6.14.13
OS: win32 x64

Angular: 12.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, platform-browser
... platform-browser-dynamic, router

Package                          Version
----------------------------------------------------------
@angular-devkit/architect        0.1200.0
@angular-devkit/architect-cli    0.1200.0
@angular-devkit/build-angular    12.0.0
@angular-devkit/core             12.0.0
@angular-devkit/schematics       12.0.0
@angular-devkit/schematics-cli   12.0.0
@schematics/angular              12.0.0
rxjs                             6.6.7
typescript                       4.2.4

@mlc-mlapis, it appears something related to ui-grid, can you try to setup a minimal project using ui-grid and see if that reproduces the problem?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

@alan-agius4 Thanks. After a deeper exploration, we found some problems in the dependency package PrimeNG and its styles. After removing it, the warning disappeared.


[352]:... convert object tests to table driven style

PR for #352
Implemented table-driven style for:

[x] TestObject_ContainsKey
[x] TestObject_ContainsValue
[x] TestObject_ContainsSubset
[x] TestObject_HasValue

@gavv ready for review

Coverage: 95.636%. Remained the same when pulling dad9859e10c0a94862136849954adb6bcfeb1ac8 on Darrellbor:352-convert_object_tests_to_table_driven_style into 142f946c4430787f02b779b136f73bf427aea8f5 on gavv:master.

@gavv ready for re-review

@Darrellbor What do you think about this comment? https://github.com/gavv/httpexpect/pull/379#discussion_r1159973052

I checked and used this method, i think it made sense

Let's keep it as is. Thanks!