Server Sent Events don't work

1. What version of Caddy are you running (caddy -version)?
0.9.4
2. What are you trying to do?
Proxy SSE through Caddy
3. What is your entire Caddyfile?
:80
gzip {
    not /application/events/
}
maxrequestbody 200MB

log stdout
errors stderr

root html/

proxy /application <IP_ADDRESS>:9000 {
    transparent
    header_upstream X-Real-IP {remote}
    header_upstream X-Forwarded-Server {host}
    header_upstream X-Forwarded-Host {host}
}

4.  What did you expect to see?
I expected my SSE requests to establish a long-running connection that can send data to the client.
6. What did you see instead (give full error messages and/or log)?
The HTTP request does seem to work (returns a 200, and headers), and the connection is kept alive, but SSE frames don't arrive to the client.
7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
I've tried the https://github.com/jraedisch/go_sse_example to confirm the bug, but streaming does work with that setup. I suspect this error may be specific to interacting with the Java upstream I'm using. nginx, however, works well in the place of caddy, without additional changes to the upstream config. I'm using a python requests script as reference client.

Can you please build from source (go get -u github.com/mholt/caddy && $GOPATH/bin/caddy) and try again? We've made some changes recently that may resolve this.

I have just built master as you suggested, and it doesn't resolve my issue.

@rsdy Are you sure? People are saying in https://github.com/mholt/caddy/issues/677 that they work. Try with an older version perhaps? What is it about your scenario that causes this, what can we do to reproduce it? You say even that's only one upstream that causes it, what is it doing differently?

I can try and mock up a minimal example with Dropwizard + Jersey SSE to demonstrate/test this in the next few days. There's no intentional magic in how the application handles SSE, so I assume the difference is coming from the framework. For full reference, here's the nginx config that does work:
worker_processes  1;
user nginx nginx;

events {
    worker_connections  1024;
}

http {
    include       mime.types;
    default_type  application/octet-stream;
    client_max_body_size 200M;
    sendfile        on;
    keepalive_timeout 600s;
    send_timeout 600s;

    gzip  off;

    upstream backend {
        keepalive 100;
        server <IP_ADDRESS>:9000;
    }

    server {
        listen       80;
        server_name  localhost;

        location / {
            root   /var/www/html;
            index  index.html index.htm;
        }

        error_page   500 502 503 504  /50x.html;
        location = /50x.html {
            root   /usr/share/nginx/html;
        }

        location /application/ {
            proxy_read_timeout 24h;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header Host $http_host;

            proxy_http_version 1.1;
            proxy_set_header Connection "";

            proxy_pass http://backend;
        }
    }
}

I've tried tweaking the proxy keepalive parameter and the Connection header, but to no avail.

https://github.com/rsdy/caddy-dropwizard-sse is a project that demonstrates this issue with master. You'll need a working JDK8+maven, and caddy to run it.

Hi @rsdy , I have found the reason. There is a mistake in your CaddyFile, change this line
not /application/events/

to
not /application/events

no tail slash!

Thanks @tw4452852 for looking into this. Having made the modifications you recommended, I still can't see traffic coming through caddy. I'm trying the HEAD on master, using both Chromium and curl. Directly calling the Java server reliably works.
Even if I disable gzip completely, the SSE call just hangs through caddy.

Weird, Do you use the https://github.com/rsdy/caddy-dropwizard-sse environment? Could you please take a snapshot of response header in Chromium?

ctp:~/w/caddy-dropwizard-sse$ curl -D - localhost:8000/application/events
HTTP/1.1 200 OK
Content-Type: text/event-stream
Date: Thu, 19 Jan 2017 10:43:47 GMT
Server: Caddy
Transfer-Encoding: chunked

^C
ctp:~/w/caddy-dropwizard-sse$ curl -D - localhost:9000/application/events
HTTP/1.1 200 OK
Date: Thu, 19 Jan 2017 10:43:54 GMT
Content-Type: text/event-stream
Transfer-Encoding: chunked

event: config-change
id:<PHONE_NUMBER>858
data:<PHONE_NUMBER>858

event: config-change
id:<PHONE_NUMBER>860
data:<PHONE_NUMBER>860

Same in Chromium:

Everything seems right. Is there any logs after you started start.sh? What's go version? The Head of master you mean is ecf852e?

$ go version
go version go1.7.3 linux/amd64

I'm using Alpine Linux as a build box, and ecf852e.
There is nothing special popping up after running start.sh. The only thing I'm just noticing now is that I caddy leaves the connections open even if kill the client.

Run curl localhost:9000/application/events & pid=$! sleep 5 && kill $pid will print a few events and then log a Java exception indicating the connection is closed, as expected.

Run curl localhost:8000/application/events & pid=$! sleep 5 && kill $pid, and no Java exception is logged. Looking netstat -pn will list a TCP connection between caddy and the java process is still ESTABLISHED, and will only close after several minutes. Only then is the Java exception logged to the console.

I updated https://github.com/rsdy/caddy-dropwizard-sse with a Dockerfile and a caddy executable to help debugging. You'll need to swap the caddy executable and rebuild if you want to test a change.

Oh, they run with docker, I suspect this is same as #1281. Does it work w/o docker?

No, it doesn't.

On n19 Jan 2017, at 12:32, Tw<EMAIL_ADDRESS>wrote:
Oh, they run with docker, I suspect this is same as #1281. Does it work w/o docker?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

After some investigation, the reason is found. It's actually a bug in go 1.7...
Firstly, this issue doesn't happen if you build caddy with go tip which I use, however it happens if you use go 1.7 which @rsdy uses.
The bug is that the chunk reader will expect two more bytes which is \r\n after reading a chunk before it returns. So it will read until the offered buffer is full (which is 32K in our case, so big...). Some more details are in this issue.
So @rsdy , you could use the newer go (at least contains this commit) to rebuild the caddy, this issue should be fixed then.

Woah, great find @tw4452852!
I haven't tried working on this, but I'm convinced by looking at that, and I trust it works for Tw because he says it does. ;) @rsdy, you're welcome to try it with Go tip (1.8 is in RC2; stable will be coming out in a few weeks) and if it still happens -- make sure you verify you are using Caddy built on Go 1.8 -- then you can re-open this with more details. Thanks!

@mholt You're welcome.
Shall we add go version information in the issue template if the reporter build Caddy himself.

I can confirm the bug doesn't happen with Go 1.8rc2. Thanks @tw4452852 & @mholt for chasing this!

@tw4452852

Also in your https://github.com/rsdy/caddy-dropwizard-sse project, you should disable gzip for /application/events in your CaddyFile

Clould you please explain why disabling gzip is required?

@laszbalo
I think it needs some works on server side to implement sse with gzip.


Rca bucketization

Issue #:
Description of changes:
Tests:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Breaking this up into smaller PRs


Undust package page

[x] reduce size of approved box, reduced margins
[x] remove duplicated title, description
[x] rename  "fork me" to "github"
Before

Now


Exporting utils.js

Hey guys,
Would be nice if we could access the utils.js file, to use it when extending some of the methods instead of duplicating it. Or maybe it's already possible in another way than going to look for it through the path in node_modules ?
Thanks

Couldn't you just require('feathers-sequelize/src/utils')? Personally I don't think there is anything in there that should be needed externally on a regular basis so I'm not sure it needs to be exposed explicitly.

I tried it this way, but it's not working, i get this error : Error: Cannot find module 'feathers-sequelize/src/utils' (and i can load feathers-sequelize just fine).

Oh yes, it's feathers-sequelize/lib/utils

Yes, perfect. Thanks a lot.


ENH: Warn users if masks are not provided for registration and fitting

Warn users if masks are not provided for registration and model fitting.
Closes #10.

Will add testing whenever we have some testing data.


Add package safeseq

Seq that can safely add and remove elements while iterating.
https://github.com/avahe-kellenberger/safeseq

It is already in the packages list.


Merge download strategy specs.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Move specs for cask download strategies.

Sorry for stepping-in:
Is there any reason for having in the examples e.g. http://example.com/foo.tar.gz rather than the more secure https://?

No, @retokromer, feel free to update them to https://.


Still show total count of problems even when all problems are filtered out

Issue Type: Bug
From #85943
Repo

Create a few problems
In the problems view, filter them all out

Bug
If only some suggestions are shown, we show 4 out of 10 in the problems filter. However if all problems are filtered out, we don't show this.
I suggest we show 0 out of 10 in these cases as well
VS Code version: Code - Insiders 1.41.0-insider (97855786a014be2440751b038b373c3726e11fe8, 2019-12-03T05:35:54.992Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (2.05GB free)

Process Argv
-psn_0_7812979

Screen Reader
no

VM
0%

Looked into this and a message is shown in the content area appropriately for all cases. So felt showing no results or 0 out of x` again is redundant and also confusing especially for active file case. Hence doing no fix.


[Suggestion] Make Fluid Crafter work without fluids too

Industrial Foregoing Version: 1.12.11-235
TeslaCoreLib Version: 1.0.15
I really love the feature of the fluid crafter that you can/have to lock the items for it to actually craft. I however can't find anything similar for crafting without fluids and was surprised that I could not find a crafter or similar machine in Industrial Foregoing. Would it be possible to enable crafting of recipes without fluids in the fluid crafter or possibly create a different machine that simply craftes regular recipes? Possilby toggle this via configs?
All other crafting machines I can find in other mods tend to get clogged if they require more than one item as one would at some point in time fill the entire inventory preventing the other item from being inserted.
Generally just wanted to give you a heads up as I really love this mod and would never want to play a technical modpack without it as it greatly improves automation :+1:!

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.


Website: Dead/outdated links

on the Documentation page, several links point to /catalog/evancz-Elm/0.10.1/, which gives a 404. Links to the Maybe and Either library implementations point to https://github.com/evancz/Elm/blob/master/libraries/ rather than the repo in the elm-lang org.

Can you send PRs? It is difficult to hunt this kind of thing down. If not, let's close this one!

If not a PR, at least a link to the particular line number that is messed up?

The page in question doesn't even exist anymore, so I think this is obsolete :)

Another way to fix things :P Thanks for the report!


Fix "Stateful set integration when Single CQ should admit group that fits" test.

What type of PR is this?
/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:
To fix "Stateful set integration when Single CQ should admit group that fits" flaky e2e test.
Which issue(s) this PR fixes:

Fixes #3310
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/test all

/lgtm
/approve


[device_info] add PackageManager's SystemFeatures to AndroidDeviceInfo

Description
There's a variety of scenarios where checking at runtime which system
features are available is useful.  System features are device
capabilities that do not change at runtime (for example, FEATURE_BLUETOOTH
is always present if the device has a bluetooth radio, even if Bluetooth
is presently disabled), so DeviceInfo seems like the right place to put
this.
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

We have a breaking change for this PR. https://sponge2.corp.google.com/1b5a148c-8e14-4265-961d-b8cab9746303/targets/%2F%2Fnbu%2Fpaisa%2Fgpay%2Fapp%2Fauthenticated_service%3Atests_test_device_service_test.host. It happens when the receiver of the function fromList is null. Could you provide proper checks please?


MacOS M1 Manual Annotation Freeze

Running cellpose gui (non-napari) trying to add / delete masks causes freezing/crash of software. MacOS ventura up to date.

are the images very big / 3D? does the same image not crash on another OS?

closing due to inactivity, please let us know if you're still having problems


[Unified Fides] Missing Fidesops Docs in Index

Bug Description
The combined fides/fidesops mkdocs.yml file is missing references to manual_webhooks.md and connection_types.md

manual_webhooks.md
connection_types.md

Steps to Reproduce

Do this...
Then This...

Expected behavior
A description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Version:
OS:
Python Version:
Docker Version:

Additional context
Add any other context about the problem here.

since this is a docs issue I'm going to assign it to @conceptualshark , they handled the large bulk of the docs updates

This should be taken care of by https://github.com/ethyca/fides/pull/1236 - the connection_types docs were folded in elsewhere!

confirmed this is fixed elsewhere


Libbsd update Darwin patch

Motivation for this change
This updates the Darwin patch for libbsd. The latest update broke it but I've reworked it so it applies there now.

@GrahamcOfBorg build libtiger

@GrahamcOfBorg build libbsd

The bot has approved the PR those meta does not evaluate: f80a55ca37a6130784587bebb8f55718a62f3e69

That's is exactly one of the things I want to add to the bot, unless @grahamc beats me to it 😄


meet the issue KeyError: 'backbone.layers.0.blocks.0.attn.relative_position_bias_table'

when I train my own datasets, meet the issue as below:
KeyError: 'backbone.layers.0.blocks.0.attn.relative_position_bias_table
environment:
rtx3090 4 GPU(rtx3090) with cuda 11.1
swin-b
upernet_swin_base_patch4_window7_512x512.pth
may somebody give any clues?

Hi, "upernet_swin_base_patch4_window7_512x512.pth" is a model finetuned on ADE20K, not an ImageNet pre-trained model.
You would better use pre-trained models held in this page.

@panda-2014 Hello, could you tell me the run code when training on one gpu on windows(RTX 3090)? I need it as an example to train the model.

@panda-2014 Hello, could you tell me the run code when training on one gpu on windows(RTX 3090)? I need it as an example to train the model.

I run on linux, and the I have change to run on rtx8000x4 GPU, and occur some new issues. I still have no idea about the issue :(

Do you have to solve this problem?I also met the same problem

512 pretrained model can be found here: https://github.com/open-mmlab/mmsegmentation/tree/master/configs/swin


Introduce test runners (tox), and travis configuration for CI

Just some basic repository health imported from other Artefactual repositories.

Part 1: https://github.com/artefactual-labs/AIPscan/pull/36

I'll prepare a Travis commit but I think that should be added later as it will generate too much noise for the refactor at the moment, i.e. returning Flake8 bits n pieces we already know about.

Part 2: https://github.com/artefactual-labs/AIPscan/issues/35

Because circular imports, we haven't quite got here yet! But close:
AIPscan/__init__.py:10:1: E402 module level import not at top of file
AIPscan/__init__.py:10:1: F401 'celery.Celery' imported but unused
AIPscan/__init__.py:11:1: E402 module level import not at top of file
AIPscan/__init__.py:20:1: E402 module level import not at top of file
AIPscan/__init__.py:20:1: F401 'AIPscan.models' imported but unused
AIPscan/__init__.py:22:1: E402 module level import not at top of file
AIPscan/__init__.py:23:1: E402 module level import not at top of file
AIPscan/__init__.py:24:1: E402 module level import not at top of file
AIPscan/__init__.py:25:1: E402 module level import not at top of file

cc. @peterVG @tw4l I spent some time trying a few ways to get AIPscan/__init__.py to pass - and didn't quite find the right approach, so a second pair of eyes might help.
If that turns out to be too onerous, then a temporary approach might be to make a flake8 expception for this file, merge https://github.com/artefactual-labs/AIPscan/issues/35 and then we'll have CI available within GitHub for the rest of the project which will be beneficial for objective review, and generally keeping quality up.

Closed by https://github.com/artefactual-labs/AIPscan/pull/101/commits


Error booting up server with 0.7.1 installed

Title says it all; updating to 0.7.1 prevents my server from booting up. Reverting back to 0.7 fixed the issue.

Nevermind, found the issue


Add support for enableTranscoding

This is still pending on a protocol PR getting merged. How are protocol changes imported in the js SDK currently?

it's done by linking to the @livekit/protocol package that we publish from the protocol repo. I can cut a release for that now

ah wait, your change isn't merged into main yet, so we'll have to wait for that and then update the @livekit/protocol dependency in this repo.


Use TileDB 'OR' operator in WMG query logic

https://github.com/TileDB-Inc/TileDB/releases/tag/2.10.0 will have "OR clause support in Query Conditions". Once a TileDB-Py  pip pkg is available for TileDB 2.10, the WMG query() method can be simplified to use this query operator. Currently, the code used a work-around to implement this. Performance might just improve as well.

The "OR" logic code was actually removed a while back (2d81ef8e380f7e8ad569ae3821976ea5ec4968bb), making this issue is irrelevant!


fix(FMP-313): fix initial animation bugs

Current dependencies on/for this PR:

main

PR #29   👈

This comment was auto-generated by Graphite.


[Bug]: Eval is throwing type error for empty array

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When we receive the empty array as a response from the API and if the same is bounded to table or list widget we are getting Value does not evaluate to array eval error.
Steps To Reproduce

Create DB query with no data
Bind the data to table or list widget
Check the error in eval window

Environment
Production
Version
Cloud

@abhvsn this seems to be working. Can we get the actual response of the query here?

Closing this since we have no update


Add CC BY 4.0 license

This pull request adds a CC BY 4.0 license to the repository.

Related issue: #6


fix: prevent vertical scroll on thumb touch (#171)

May need a workaround or polyfill for browsers that do not support touch-action
Closes #171
Detailed explanation: https://github.com/zillow/react-slider/issues/171#issuecomment-626350678

This is great, thanks for looking into it!

<EMAIL_ADDRESS>


CRD generation not respecting "// +k8s:openapi-gen=false"

Bug Report
In the Jaeger Operator, we want to skip the generation of the CRD schema for some properties such as v1.Volume, as they cause the final CRD to be way too big. Adding // +k8s:openapi-gen=false to the fields does make the field to be skipped from pkg/apis/jaegertracing/v1/zz_generated.openapi.go, but the field does end up in the CRD.
What did you do?
From this branch (jpkrohling/jaeger-operator/763-Add-openapi-to-generate), run:

operator-sdk generate openapi
check that schema_pkg_apis_jaegertracing_v1_JaegerAgentSpec has no Volume node
the CRD gets updated and the agent node (starting on line 604) has a volume node (line 1416)
bonus point: check that the CRD file has 1.3 MB

What did you expect to see?

the CRD gets generated without the fields marked with // +k8s:openapi-gen=false in pkg/apis/jaegertracing/v1/jaeger_types.go, such as the Volumes field in the JaegerCommonSpec, embedded by JaegerAgentSpec (and by other types).

Environment

operator-sdk version: operator-sdk version: "v0.11.0", commit: "39c65c36159a9c249e5f3c178205cc6e86c16f8d", go version: "go1.12.7 linux/amd64"
go version: go version go1.13.4 linux/amd64
Kubernetes version information: not relevant
Kubernetes cluster kind:  not relevant
Are you writing your operator in ~ansible, helm,~ or go? go

Hi @jpkrohling,
I am sure that the annotation is supported for all spec such as the following example. So, could you let us know where you check that the annotation could be used to ignore specific fields and definitions? Could you please share this doc? Also, could you add here a piece of the code over how you are using it?
// Descripttion
// +k8s:openapi-gen=true
type KindStatus struct {

// Descripttion
// +k8s:openapi-gen=true
type KindSped struct {

We talked quite a bit in private, and I wanted to summarize the current status before leaving for the day.

looks like I left it out from the original description, but the actual problem is that the generated CRD cannot be applied, as Kubernetes complains about The CustomResourceDefinition "jaegers.jaegertracing.io" is invalid: metadata.annotations: Too long: must have at most 262144 characters
the CRD works when some fields are left out, like the volumes
the theory is that "something" is adding annotation data to the CRD during the apply process, which then makes Kubernetes refuse the final CRD

I understand that I cannot simply ignore fields in the CRD, as they would later fail to be passed to my controller's Go type. My current CRD does not specify a validation nor schema, which is why it works today.
Action item for me:

[ ] check how the annotation field looks like after applying the CRD without the volumes node (or a version of the CRD that gets accepted by the Kubernetes server).

@jpkrohling Are you doing kubectl apply to create the CRD? If so, the apiserver is probably adding the kubectl.kubernetes.io/last-applied-configuration annotation, which contains the entire content of the applied resource. With all of the validation metadata included, I wouldn't be surprised if that pushed that field above 262144 characters.

Seems related to https://github.com/kubernetes-sigs/kubebuilder/issues/1140

Hi @joelanford,
Yes. It may be the same scenario of kubernetes-sigs/kubebuilder#1140 since theire the say that solved te issue by using the create flag instead of applying. However, I'd like to do more tests in kubebuilder to ensure since there also many info can be used in the scaffolds which is not the case of SDK. For example, the name o the project is used to create the namespace.  Then, I'd like to ensure that there is not required to add more validations as it was done https://github.com/kubernetes-sigs/kubebuilder/pull/1173.

You are absolutely right, @joelanford. Using kubectl create instead of kubectl apply helps me move forward. I'm closing this, thanks!

Hi @jpkrohling,
To know more about see here doc over it: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/declarative-config/


hide not released

Is your feature request related to a problem?
As I'm a tutor and I'm doing some exercises in the tutorsessions. While screensharing it would be better if students can't see upcoming not released exercises.
Describe the solution you'd like
In Artemis there is already the option to hide full score and to hide overdue. My solution would be to add a third button for tutors to hide exercises that are not released.
Describe alternatives you've considered
Sometimes it would be also helpful to filter by tags for example in software engeneering I sometimes wanted to filter the exercises by type like "programming" or "modelling".
Additional context

I like both ideas. we should try to implement those.
I only fear that too many buttons for filtering would overload the user interface and make it rather complex for beginners.
I guess we need to find a nice way, maybe filtering needs to be done in a hidden section?
Then we would only show a status button, e.g. "Filtering active" vs. "No filters".
When students click on it, the hidden section appears, they can change the filters and clicking on the button again will close the section again.

Filtering active would need a strong color so that it is immediately clear that exercises are hidden due to it


Nifti files with non-orthonormal directional cosines should be read and the error changed to a warning.

Hi all,
In this PR - https://github.com/InsightSoftwareConsortium/ITK/pull/1868/files ITK introduced an additional constraint on NiFTI files being read.
This has affected users across a variety of technologies which use ITK such as TorchIO, TotalSegmentator, Nvidia AAIA, HD-BET, nnDetection and even ITK-SNAP (with some files working on < v3.6 but not on v3.8 >)
Given so many users see this as unexpected behaviour could the developers investigate whether the constraint is still a reasonable one?
Note:  In this issue this was discussed but the solution solved only one failure case related to small voxel sizes - https://github.com/InsightSoftwareConsortium/ITK/issues/2674 - this issue is still affecting users with larger voxel sizes across a variety of technologies
References:
https://github.com/MIC-DKFZ/nnDetection/issues/24
https://github.com/SimpleITK/SimpleITK/issues/1433
https://github.com/fepegar/torchio/issues/669
https://github.com/wasserth/TotalSegmentator/issues/32

People who use NIFTI a lot should weigh in. Candidates: @hjmjohnson @cookpa @vfonov @seanm. Maybe make the error/warning CMake configurable, with the default being a warning?

ITK does not support non-orthogonal images,  to read the images that are non-orthogonal invalidates all the requirements about processing and analyzing images.

Maybe we should add a flag that forces Nifti reader to convert the non-confirming non-orthogonal matrix to the closest possible orthogonal?

@tomvars please take a look at #4009.

I looked through the linked issues in the first post, but I didn't see any links to example data that reproduce the problem. Even the headers by themselves would be useful, these can be extracted with
head -c 352 image.nii > header.nii
If the sform checks are too strict, it would be good to fix them. Otherwise everyone is just going to turn on this flag at compile time and the end users will likely not even know about it

I think, it's possible that, other software is quietly fixing this issue by using nifti_make_orthog_mat44 , for example ITK NIFTI writer is doing it when saving NIFTI files: https://github.com/InsightSoftwareConsortium/ITK/blob/c44f9c1b39e627c5ef7fabec252232a92d570565/Modules/IO/NIFTI/src/itkNiftiImageIO.cxx#L2261

I looked through the linked issues in the first post, but I didn't see any links to example data that reproduce the problem. Even the headers by themselves would be useful, these can be extracted with

I created a file from another one by using nifti_tool to make sform non-orthogonal, but it is probably not representative of the real world problem.

I think there is some kind of bug with the implementation of this check anyway. I spent 4 days ripping my hair out when getting an error message indicating a non-orthonormal transform for nifti files generated using the dicom2nifti python package.
I found that the translation vector elements in the matrix ([1,4],[2,4],[3,4]) were causing this issue purely by being in the order of 1e2. I do not understand this since those elements are orthogonal in the Cartesian co-ordinate system, are independent of the rotational sub-matrix, and it is unreasonable to force a normal length constraint on the column vector of the translation anyway.

Following @mike-barrow analysis, I've uploaded couple of examples of the same (full-zeros) image which the only difference is in the translation vector. Note the rotation is orthogonal.
The rotation matrix remained the same.
Note that I'm observing this using the itk library directly, but only through the ITK-Snap app.
When I'm trying to read the same image with the python package (itk.__version__  # 5.3.0) seems to be working fine:
import itk
io = itk.NiftiImageIO.New()
io.SetFileName("fail_to_open.nii.gz")
io.ReadImageInformation()

I'm not sure what the differences are, maybe different build flags?
Examples (both work and don't work)
❌ fail_to_open.nii.gz (original affine)
[[   0.33203125    0.            0.          -84.83398438]
 [   0.            0.33203125    0.         -198.83398438]
 [   0.            0.            0.69999999 -318.3999939 ]
 [   0.            0.            0.            1.        ]]

❌ fail_to_open_1.nii.gz
[[   0.33203125    0.            0.            0.        ]
 [   0.            0.33203125    0.         -198.83398438]
 [   0.            0.            0.69999999 -318.3999939 ]
 [   0.            0.            0.            1.        ]]

✅ success_to_open_2.nii.gz
[[   0.33203125    0.            0.            0.        ]
 [   0.            0.33203125    0.            0.        ]
 [   0.            0.            0.69999999 -318.3999939 ]
 [   0.            0.            0.            1.        ]]

✅ success_to_open_3.nii.gz
[[0.33203125 0.         0.         0.        ]
 [0.         0.33203125 0.         0.        ]
 [0.         0.         0.69999999 0.        ]
 [0.         0.         0.         1.        ]]

✅ success_to_open_4.nii.gz
[[   0.33203125    0.            0.          -84.83398438]
 [   0.            0.33203125    0.            0.        ]
 [   0.            0.            0.69999999 -318.3999939 ]
 [   0.            0.            0.            1.        ]]

✅ success_to_open_norm.nii.gz
[[ 0.33203125  0.          0.         -0.22043331]
 [ 0.          0.33203125  0.         -0.51665181]
 [ 0.          0.          0.69999999 -0.82733309]
 [ 0.          0.          0.          1.        ]]

Thanks for these examples. I believe the translation issue was fixed by (this commit)[https://github.com/InsightSoftwareConsortium/ITK/commit/815d0f0531eaff6a9ee18e3f1a2bbb2e251eff12] as part of #4009.

Looks like ITK-SNAP is using an older ITK

Yes, ITK-SNAP is somewhat behind on ITK version.

The next major update of ITK-SNAP (v4.4.0) will be using ITK 5.4
On Tue, Aug 20, 2024 at 9:21 AM Dženan Zukić @.***>
wrote:

Yes, ITK-SNAP is somewhat behind on ITK version.
—
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/issues/3994#issuecomment-2298848529,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARDT6PVKDPDYYPFHY4HCA2TZSM7FTAVCNFSM6AAAAAAWSXMCJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYHA2DQNJSHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #416 (dd8a711) into main (019f473) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       42       42
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us.


Option to not escape embedded HTML

Is there an option to render embed HTML UN-escaped? For example I have the following string: "hello, my name is Miguel". I expect to see "Miguel" in bold.
Thank you,
Miguel
<EMAIL_ADDRESS>

I am trying to render a report generated by dynamicreports (a Java reporting library)
This line
error('Parent of  must be ')
causes the rendering to stop. I can't really modify dynamicreports in order to.
Is there a way to avoid validation and let the browser be responsible for it?

Unfortunately, if you are using JsViews (link method) and you have

...

  and you use data-link attributes or {^{...}} tags on or within that content, then behavior can be unpredictable, since browsers may or may not dynamically insert a body tag. So the nesting depth of elements and the results of stepping through will be different at the time of linking than it was at the time of rendering.
If you are using the render method - not doing data-linking, you will not get the error message. But if you are linking, you will - and this validation does need to be done by JsViews, not just by the browser...

That said, I will consider changing the code for the next update, so that by setting $.views.settings.noValidate = true; you can opt out of this validation. But in that case, depending on how you use data-linking within the invalid content, you may or not get other bugs occuring.

@larjohn: I have included this in the latest update. By setting $.views.settings.noValidate = true; you can opt out of the  validation.


Updating how to install via npm

I had problems trying to install without the double quotes, i got an error -> zsh: no matches found: Esri/calcite-web#v1.0.0-beta.30

thanks, @hhkaos


[SP-5134] Backport of PDI-17996 - Data validator 'Allowed values' lis…

…t-box omits scroll-bars, ignores mouse scroll (7.1 Suite)
@pentaho-lmartins

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/trans/steps/validator/ValidatorDialog.java


Authorizations are not listed under app role

Describe the issue:
When an App role is created, I should be able to add authorizations under that app role. (The ones that are related to subscribed APIs by that application).
But with the latest state (beta 3 snapshot which is built on 8th of December), none of these authorisations are getting listed under the application role.
Some times the authorizations are listed. But when you create it and later try to add more, the rest of the authorizations are not listed. @thanujalk also could reproduce this issue.
How to reproduce:
Create some API resources along with authorizations
Create an application and subscribe to API resources
try to create an application role through role view (not through application)
Authoriztions are not getting listed under the role to be selected.

This is tracked with https://github.com/wso2/product-is/issues/18525

Fixed in the new pack


Consider the addition of enum arguments for some commands

Consider adding enum arguments for some commands, such as:
say "This line doesn't require an advance" nowait
pause 0.5
say "And this line appears suddenly!

In this example, an enum argument nowait is being provided to the say command.
If a case can be made for the widespread, useful application of enum arguments, then this feature should be developed and made available. More examples of where this language feature would be useful would help in making this case.
(see: https://twitter.com/SenshiSentou/status/943220264132898816)

I realized earlier this evening that the clear command already uses an ClearType enum argument (#21). So, that is at least one place in the repository which already utilizes this language feature.

After more brainstorming, I have realized another possible enum argument use:
pause 0.5 ignore_input

I think I have enough examples now of where this kind of language syntax would be useful and it no longer feels applicable only to certain edge cases. I'll be implementing this syntax along with the compiler rehaul I am working on.

Awesome, good point! If I may just nitpick real quick though:

Since Rumor doesn't deal with input as such, perhaps something like ignore_advance or cant_skip would be better?
You've been calling these "enum arguments"; does that mean you're thinking of implementing these as some sort of ControlOption enum? If so, it might be worth future-proofing the design by using a param[], just so that a single line can contain multiple options.

Either way, they're really just that, nit picks. Very excited to see this in a future release!

I agree about ingore_input not really making sense for Rumor. I was thinking about doing ignore_advance, but it feels too technical for a writer. I think your suggestion of cant_skip is a good choice and self-explanatory. I'll update #56 to match.
Your other idea is interesting. The only problem is, most of these enum arguments are specific to the command being used. For example, it doesn't make any sense to do:
say "Hello world!" dialog

As a result, I don't think this idea would work.

Hmm, very true. My main reasoning was that, if in the future there are multiple options for any given command, it would make sense to easily allow for all possible combinations (A, B, A B, B A) that way. I guess it could still make sense if you were to use specific, dedicated enums (TalkOption{} for say and add, YieldOption{}, etc.), but I'm probably thinking too much about the implementation here already. ;)


Is there any IP alternative on debian.

Cannot locate ip executable when runned on debian, but there is no package named IP on debian

You need iproute2: https://packages.debian.org/bullseye/iproute2
Run:
sudo apt-get install iproute2


fix(DTFS2-6886): fix bug where user gets a 502 on requesting new sign…

… in link in some scenarios
Introduction :pencil2:
This PR addresses a bug in which all of the scenarios described in AC 3 of https://ukef-dtfs.atlassian.net/browse/DTFS2-6693 were returning 502 Bad Gateway. Note that I have only been able to verify that this fixes ACs 3a, 3b, 3c and 3f as I was never able to reproduce the 502 Bad Gateway issue locally for ACs 3d and 3e.
Resolution :heavy_check_mark:

Changed POST sign-in-link-expired to match POST check-your-email
Added logging for JWT validation
Added API test coverage for POST sign-in-link-expired

Miscellaneous :heavy_plus_sign:

Added logging for Notify email sending

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6da84ce) 21.88% compared to head (319d510) 10.57%.
Report is 138 commits behind head on main.

Files
Patch %
Lines

dtfs-central-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2457       +/-   ##
===========================================
- Coverage   21.88%   10.57%   -11.32%
===========================================
  Files        1132      922      -210
  Lines       27048    21380     -5668
  Branches     4447     3420     -1027
===========================================
- Hits         5920     2261     -3659
+ Misses      18403    16638     -1765
+ Partials     2725     2481      -244

Flag
Coverage Δ

api-test
0.48% <ø> (ø)

ui-test
64.22% <ø> (-0.92%)
:arrow_down:

unit-test
4.30% <0.00%> (+0.51%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Override of attr_json's

Hey, thanks for a useful gem and support of it!
I have a question regarding overriding attributes: it there some particular reason we try to prevent it here and here? Would it make sense to allow overrides when passing an option override: true?
Asking cause in our case we have modules that include batch of json_attr's though we want override defaults for some of the models. Will be glad to work on the addition of a feature.
Thanks in advance!

I can't recall for sure. Possibly I just didn't know what would happen, if it would actually be succesful or not. And rather than try to cover all possible places it could go wrong in test cases, I just disallowed it.  Just in general, the code here is complicated enough already, I sometimes try to keep it from getting more complicated by limiting edge case possibilities.
Also, if you are trying to override in a sub-class to have a different definition, I think it would violate the Liskov substitution principle.  If you have an ordinary ActiveRecord subclass, I believe you can't ordinarily redefine an attribute to be different than the superclass -- because it's normally backed by the same underlying table/column, right?
What is your interest/use case?

Our use case is the urge to 1) keep attributes of a feature in modules to ease inclusion in specific implementations 2) to override default without hurting LSP, cause in our case we want to preserve interface of superclass.
I'll give an example, let say we're trying to enrich several models with frequently changing interface of :
module ContactAttributes
  def self.included(base)
    base.attr_json :has_phone, :boolean, default: false
    base.attr_json :phone, :string
  end
end

class School < ApplicationRecord
  include AttrJson::Record
  include ContactAttributes
end

class Hospital < ApplicationRecord
  include AttrJson::Record
  include ContactAttributes
end

So I start to use those models to render form with defaults: so when creating both School and Hospital by default we have checkbox controlling has_phone disabled and thus not rendering phone, when has_phone is checked, we start to render phone input, everything works fine this far. Problems start when I want to make has_phone default to true for hospitals as it's not possible at the moment.
Earlier we've being using store_attribute gem and what we've done is separate wrapper for overrides which will only allow to set new default, so that we would not (hopefully) break LSP for a serialized column.
Of course we could go with some crazy stuff like
class AttributesWithCustomizableDefaults < Module
  def initialize(**options)
    @options = options
  end

  def included(base)
    base.instance_exec(options) do |custom_default:|
      attr_json :attribute, :integer, default: custom_default
    end
  end
end

class Model < ApplicationRecord
  include AttributesWithCustomizableDefaults.new(custom_default: 2)
end

This helps me stick to interface of whatever I'm trying to model here, but it's really an overkill IMO :)
Additionally, Rails attributes API allows me to do something like that:
class Model < ApplicationRecord
  attribute :some_attribute, default: 5
end

Thanks for the answer and let me know what you think

Thanks for explaining!
Hm, I'm not sure your second solution is that crazy. But you could also make it a method instead of a module at all. Something like:
class AttributesWithCustomizableDefaults
  def self.apply(base, has_phone_default: false)
           base.attr_json :has_phone, :boolean, default: has_phone_default
           base.attr_json :phone, :string
  end
end

class School < ApplicationRecord
  include AttrJson::Record
  AttributesWithCustomizableDefaults.apply(self)
end

It occurs to me you don't really want to override the value -- you want to "override" it right after setting it, it's not like you have a superclass with one value and a subclass with another. That you need to "override" it is just a consequence of trying to be like "first I apply a module, but then I immediately reset what the module set to be what I really want it to be"
In fact, you aren't even really applying the module at all, you're just using it as a hook for def included. I think maybe my above suggestion is very similar but maybe actually even simpler?

In fact, you aren't even really applying the module at all, you're just using it as a hook for def included
Yeah, thought of a case when we do have some methods around attributes as well, but haven't managed to express it well enough :) This way it could come in handy in terms of Ruby-like interfaces inclusion

Though we could use something like
class AttributesWithCustomizableDefaults
  module Interface
    # instance methods
  end

  def self.apply(base, has_phone_default: false)
    base.attr_json :has_phone, :boolean, default: has_phone_default
    base.attr_json :phone, :string
    base.send :include, Interface
  end
end

class School < ApplicationRecord
  include AttrJson::Record
  AttributesWithCustomizableDefaults.apply(self, has_phone_default: true)
end

and eventually achieve same result
Though API wise it would be less attractive for us cause in our case we do have around 6 of those School's and we're mixin in 5 those 'shared attributes' modules via shared interface
module InstitutionInterface
  include ContactAttributes
  include RatingAttributes
  # 3 includes more

  # class methods
  # instance methods
end

then it's simply included into "institution" and in 1 or 2 cases (attr_json) we do override default option:
class School < ApplicationRecord
  include InstitutionInterface

  serializable_attributes do |s|
    s.override :has_phone, default: true
  end
end

The idea I have now is to go with combo solution which will include having a list of attributes definitions :
module InstitutionAttributes
  def apply(
    base,
    has_phone_default:
    # couple defaults kwargs here as well
  )
    # Instead of 5 "shared attributes" modules with decoupled attributes we could define all of those here
    # so that we would not need to do N .apply's of something like ContactAttributes
    # in M 'institutions'
    base.attr_json :has_phone, :boolean, default: has_phone_default
    base.attr_json :phone, :string

    # Interfaces of such groups of attributes could reside in modules as well
    base.send :include, ContactAttributesInterface
  end
end

So we end up with single .apply in each 'institution'

I think I'm going to close this for now -- I see your use case, and how it could be more convenient with changes in attr-json, but to keep attr_json sustainable and low-maintenace on my end (so it will keep working for all y'all!), I am very cautious about code changes, and since you've found a good workaround for now, I'm going to avoid this one for now.
Btw: Another workaround, you could probably go into the json_attr_registry data structure yourself to mutate it to remove the previous registration -- then attr_json couldn't complain about a previous registration you were overwriting, it would be erased, and let you do it again!  I don't have exactly the code needed to do this in front of me, but I believe it should be possible.
Thanks for using attr_json and getting in touch! Glad you found a way to keep it working for you!


Use CF names in output when removing a CF

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
In the current version, when recyclarr removes a CF the output identifies it by the trash_id - i.e. a long JSON string. This is different to the output when a CF is added or updated, in which cases the name of the CF is used. The feature request is to use CF names when recyclarr removes a CF.

Fixed in v4.1.0


Fix #1321 - MorphiaLazyModel: Refactor in 14.0.0

@newk5 for review

Thanks! Sorry I haven't been able to look into this yet, I'm not familiar with the new LazyDatamodel refactor that was done recently in PF.
I was now looking through this commit and I agree with all changes except one in particular with the builder. I think we should rename the entityManager(etc..) to datastore(etc..) because morphia has no concept of entity managers, entity managers usually mean JPA related stuff. I understand this probably came from the JPALazyDataModel in PF, and wanting to normalize the API to be the same between the JPALazyModel and MorphiaLazyDataModel but for morphia users, the term "entityManager" will probably cause confusion, since morphia always refers to it as "datastore"

Yup, just an oversight

Be aware I couldn't test it (or we have a branch for that?)

We don't. This code was donated by @newk5 as he uses it heavily in his company.


Added log command

Implemented the log_server internal command for mimicking the shell command tail of server.log
Bumped version to 0.2.0

@lastguest Great! thanks.


Work toward compiling on .netstandard (1.6)

This fixes most (all the easy) compile errors when compiling on netstandard1.6. It doesn't actually enable such a compilation so that it can still be merged with master.
The changes consist of:

Use TypeInfo instead of Type where required.
Reference .netstandard compatible versions of NuGet packages.
Remove references to .NET MEF, which isn't available on .netstandard.
Replace use of Thread with the managed thread ID for purposes of detecting thread equivalence.

@AArnott,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #6 into master will increase coverage by 0.02%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   83.63%   83.65%   +0.02%
==========================================
  Files          70       70
  Lines        5333     5334       +1
  Branches      834      831       -3
==========================================
+ Hits         4460     4462       +2
  Misses        647      647
+ Partials      226      225       -1

Impacted Files
Coverage Δ

...lStudio.Composition/Configuration/NetFxAdapters.cs
79.72% <ø> (ø)
:arrow_up:

...osition/Configuration/AttributedPartDiscoveryV1.cs
94.79% <ø> (ø)
:arrow_up:

...rosoft.VisualStudio.Composition/ByValueEquality.cs
63.1% <0%> (ø)
:arrow_up:

...timeExportProviderFactory+RuntimeExportProvider.cs
95.74% <100%> (ø)
:arrow_up:

...rc/Microsoft.VisualStudio.Composition/Utilities.cs
60.24% <100%> (ø)
:arrow_up:

...Composition/Configuration/MetadataViewGenerator.cs
100% <100%> (ø)
:arrow_up:

...icrosoft.VisualStudio.Composition/PartDiscovery.cs
82.68% <100%> (ø)
:arrow_up:

...ft.VisualStudio.Composition/LazyMetadataWrapper.cs
62.58% <100%> (ø)
:arrow_up:

...Microsoft.VisualStudio.Composition/ComposedPart.cs
85.71% <100%> (ø)
:arrow_up:

...oft.VisualStudio.Composition/CollectionServices.cs
74.54% <100%> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6b511...e4e74a1. Read the comment docs.

The remaining work for .netstandard1.6 is harder. It involves changing the way we cache and invoke members using handles and metadata tokens.
As we look at making the cache more resilient against MEF catalog assembly changes, one option would take us significantly further away from reaching netstandard. But as I think we have a couple approaches we could take, I think reaching netstandard first, then fixing the cache issue, may make it more likely we can achieve both desirable ends instead of just one.

Ah right - I forgot the metadata tokens weren't supported in .netstandard as well.


Option for disabling (or simplifying) status bar output

tl;dr -- I don't like that SublimeLinter always prints the error text of the line the cursor is resting on to the status bar at the bottom of the window. I'd appreciate a setting that would allow for some control of this feature.
 I love SublimeLinter-annotations though, especially in files for which I'm not using more complex linters. When my cursor hits a line with a TODO or a FIXME, the entire text of that line (which Annotations considers an error) is pasted into the status bar, even though I can clearly read the line that my cursor is resting on. Like I said, I hate clutter.
I'd appreciate a setting -- preferably a boolean so that toggle_setting could be used with it -- that would allow me to control whether or not the text of the error gets displayed in the status bar. Perhaps something like...
{
    "user": {
        "status_bar_error_text": false,
        . . .
    }
}

(Edit: full_error_output was a terrible name. Updated.)
The salient code lives at
https://github.com/SublimeLinter/SublimeLinter3/blob/master/sublimelinter.py#L383-L403
Most specifically the status += '; '.join(line_errors) on line 401.

See #618


Implementing WaveOutEvent for Android

I am working on an MAUI Blazor application using NAudio, and NAudio is very helpful.
MAUI Blazor is cross-platform and I am expecting this application also works on Android (and maybe iOS in the future).
I understand NAudio WaveOut is just for Windows, and I try to make an Android implementation with Android AudioTrack which is available in Xamarin Android SDK.
However, reinventing the wheel has not been very successful, there are bugs here and there (my fault). So I thought I may as well just mimic WaveOutEvent.
I digged a bit into WaveOutEvent and find out WaveInterop seems to be the only thing Windows-specific, and I tried to replace it with Android AudioTrack. But I am now stuck because it works very differently to Android AudioTrack. To be more specific, I have no
idea how to get WaveOutBuffer work with Android AudioTrack.
Has anyone got an idea?

The key interface in NAudio for playing audio is IWavePlayer. To support NAudio on android, you'd need to adapt whatever the AudioTrack can do to the IWavePlayer interface. You wouldn't use WaveOutBuffer at all.

https://gist.github.com/SineVector241/58152564e615066132b081e8e2d00645 : Recorder Implementation
https://gist.github.com/neilt6/6d07322070470536ea0ba409c343c2a5 : Playback Implementation - Note: I have a comment on that gist with a more recent/updated version.


Search results display : the number of results displayed should be specified

Describe the bug
Only the total number of search results is specified. But I think the user should also know how many results on the total he is currently viewing (e.g. 50 of 193).
To Reproduce Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: macOS 10.14.6 (18G103), French
Browser Firefox
Version 70.01.1

Additional context
Add any other context about the problem here.

This issue has been resolved by implementing the paginator component from Angular Material.
I could not find the related PR, but here is a screen shot of a search result list:


Quest v0.2 / G6PD: Take a photo within a Questionnaire

[ONLY address this issue if all other work in this milestone is complete or accounted for. It is more important to deliver a stable version of the rest of this milestone than to include this one feature in the delivery.]
As part of the G6PD requirements, the user must submit an image of the test results that they have entered.
As an end user, I want to be able to open the G6PD form, fill in the data fields, take a picture, and submit the form.
Requested solution:
Determine how to properly capture an image within a questionnaire and add the supporting UI (as seen below).

@FikriMilano Check this out

@FikriMilano Check this out

Thanks!

Yeah I think that would be easier, thanks.
Also, I got this idea yesterday. So I plan to use attachment for this. Since there's no Attachment widget provided from the Android FHIR SDK. I think we can create a custom one for FHIRCore in the engine module. So that we can use it in other apps too.
We can create a CustomQuestionnaireFragment that inherits from QuestionnaireFragment which will override the getCustomQuestionnaireItemViewHolderFactoryMatchers. Then we can add the CustomAttachmentFactory in it by matching the QuestionnaireItemType.
FYI an example for attachment: http://build.fhir.org/ig/HL7/sdc/examples.html#using-mimetype-and-maxsize
@pld @f-odhiambo

@FikriMilano I think this is a nice idea to have this extensible to other apps and can be reusable, to which resource will the attachment be tagged to?

@FikriMilano I think this is a nice idea to have this extensible to other apps and can be reusable, to which resource will the attachment be tagged to?

To display it, I think it should be part of Questionnaire.
When saving, it will be QuestionnaireResponse.

What's the reason to store this, and what specifically would be stored, in the QuestionnaireResponse?

@pld Because we need image reference when uploading one. It could be base64Binary and/or url.
It may store as follows but not limited to:

contentType (required when there's data, optional when there's url - mimeType e.g. jpeg, png)

data (optional - base64Binary)

url (optional - url)

title (optional - string)

And by using QuestionnaireResponse we can store it as an answer in valueAttachment.
For more info:
https://www.hl7.org/fhir/datatypes.html#Attachment
https://www.hl7.org/fhir/questionnaireresponse.html#resource

Ah of course, that makes sense.
Could we embed the binary data directly in the QuestuonnaireResponse instead of involving another resource?

@pld If by resource you mean Attachment, then yes.
Since the binary data will be base64 encoded, which is a string data type. We can store it in valueString.
Although the size will be limited to 1MB, we can still do it as long the image got compressed.
https://www.hl7.org/fhir/questionnaireresponse.html#resource
https://www.hl7.org/fhir/datatypes.html#string
We couldn't directly use base64Binary data type, because QuestionnaireResponse doesn't support that.
https://www.hl7.org/fhir/questionnaireresponse.html#resource
https://www.hl7.org/fhir/datatypes.html#base64Binary.

@pld Also, I got this idea today.
We can just drop the idea of using Attachment and the use of QuestionnaireItemType itself for custom questionnaire widget.
Since it's custom, we can use an extension that has a specific url and valueString to match if it's a Photo Capture questionnaire widget or not.
The url may be the questionnaire widget documentation.
Should be something like this:
"item": [
  {
    "linkId": "1.1",
    "text": "Photo of device"
    "extension": [
      {
        "url": "http://doc-of-photo-capture",
        "valueString": "photo-capture"
      }
    ]
  }
]

As for the valueString that will be returned as QuestionnaireResponse, it can be handled inside the CustomPhotoCaptureFactory (the widget) itself.
The cool thing is, in the future we can create other custom questionnaire widgets the same way as that (with specific url and valueString as it's extension) and return any value as long it's supported by QuestionnaireResponse.
e.g. Location widget, VoiceRecorder widget, etc.
Since it's in the engine module, it can be easily reused across other apps too.
CC @f-odhiambo


add .gitignore (from Python.gitignore, github/gitignore.git)

Added in many other python-related file types, from the gitignore repo.

Already have a .gitignore so auto-merge doesn't seem to be available for this.


Puget options per request

It might be nice to allow overriding the puget options with a special key on the nrepl msg. My specific use case is that I would like to use the coloring option with lein repl but uncolored with cider.

This is supported now in 2.0.0! You can send custom :print-options in each nREPL message which will override the main options set in whidbey.repl/options.


Only two tabs work; additional new tabs just hang forever

Windows Version
Microsoft Windows [Version 10.0.22621.1555]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
No response
Other Software
No response
Repro Steps
My Ubuntu tabs reopen on restart. But only two tabs work. Any additional Ubuntu tabs I open simply lead to a fully black screen except a blinking cursor, inside which I can type anything but no prompt ever appears.
Expected Behavior
Each new ubuntu tab should open an ubuntu prompt
Actual Behavior
Fully blank tab with no prompt
Diagnostic Logs
No response

/logs


How do I build a new version of moco-runner-standalone.jar

Run the following command and a standalone jar will be found at runner directory
./gradlew proguard

When I use command ./gradlew proguard
There are following message：
Warning: com.jayway.jsonpath.spi.json.JettisonProvider$JettisonTokener: can't find referenced class org.codehaus.jettison.json.JSONException
Warning: com.jayway.jsonpath.spi.json.JettisonProvider$JettisonTokener: can't find referenced class org.codehaus.jettison.json.JSONArray
Warning: com.jayway.jsonpath.spi.json.JettisonProvider$JettisonTokener: can't find referenced class org.codehaus.jettison.json.JSONObject
Warning: there were 66 unresolved references to classes or interfaces.
You may need to add missing library jars or update their versions.
If your code works fine without the missing classes, you can suppress
the warnings with '-dontwarn' options.
(http://proguard.sourceforge.net/manual/troubleshooting.html#unresolved
class)
Warning: there were 2 unresolved references to program class members.
Your input classes appear to be inconsistent.
You may need to recompile the code.
(http://proguard.sourceforge.net/manual/troubleshooting.html#unresolved
programclassmember)
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':moco-runner:proguard'.

java.io.IOException: Please correct the above warnings first.

But when I use command ./gradlew uberjar
It shows BUILD SUCCESSFUL
So what happened?
And what is the difference between two commands?
Thanks!

The build has been fixed. Try again.


Update to flatpickr v4

Hello,
First, thank you for your work : flatpickr is one of the best open source date picker !
Is it possible to update react-flatpickr to flatpickr v4 ?
Thank you !

Sure, done in 3.6.0!

Thanks @jacobmischka !


FieldArray: Field property meta.InitialValue calculated using index

bug report
What is the current behavior?
Field property meta.InitialValue calculated using index.
I have forked the FieldArray demo with small changes:

Update the form to be connected component
Set the initialValues inside mapStateToProps of the connect method
Show the initial value of the field
The sample is available here:
https://codesandbox.io/s/3yon0zv9oq

Steps to reproduce:
1- Open the demo
2- Add new member
3- Delete the first member
4- The remaining member (added at step 2) will have initial value which is not correct.
What is the expected behavior?
Would it be possible to update FieldArray to support calculating the initialValue based on specific field or provide a function to be used to find initial value?
Sandbox Link
https://codesandbox.io/s/3yon0zv9oq
What's your environment?
Redux Form version: 7.0.1

It is almost two years and not interested in redux-form so closing the issue.


lnwire: implement cautious zlib decoding for channel range queries

In this commit, we implement zlib decoding and encoding for the EncodingSortedZlib encoding type. Before this commit, we only supported the sorted plain encoding. When decoding we utilize an io.LimitedReader to ensure that we can precisely (as much given the runtime+GC) control how much memory we allocate during decoding. On top of that, we also add a package level mutex to limit the total number of decoding instances to one. This ensures that we don't multiply our allocation limit across all peers.

nice work. however it doesn't seem to play nicely with ACINQ.
ACINQ: 03864ef025fde8fb587d989186ce6a4a186895ee44a926bfc370e2c366597a3f8f@<IP_ADDRESS>:9735
lnd ( moneni.com ): 03295d2e292565743a40bd44da227a820f8730877bc3dfadebade8785bcf355258@<IP_ADDRESS>:9735
2018-06-16 20:24:32.780 [DBG] PEER: Received ReplyShortChanIDsEnd(chain_hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f, complete=1) from <IP_ADDRESS>:9735                                                                                2018-06-16 20:24:32.784 [ERR] DISC: unable to reply to peer query: unknown message: *lnwire.ReplyShortChanIDsEnd

@robtex there's no issue there. Basically right now we don't also track that we sent out a query, they respond, but then we say we didn't send out the query. It's due to the fact that the gossiper doesn't tell the syncer that it has a new querying incoming. So that's just a logging issue.


avoid retries when any data was written to the backend

What does this PR do?
Fix issue where requests are retried even though one backend accepted and may be processing this request already.
Motivation
Right now it is possible that retries happen, even when the backend received the request already. An example scenario:

the timeout ResponseHeaderTimeout is configured to be 3 seconds
a request is issued against the backend and the backend starts processing it the backend takes overall 5 seconds to process the request
due to the timeout, go will abort the requests after 3 seconds and return a network error
Traefik would have retried that request as it is only checking for net errors so far

To avoid this, the approch is to use httptrace to disable retries as soon as there was anything written to the backend.
Websocket requests can't be retried at this point in time. This is due to the fact that gorilla/websocket doesn't use the request context and so we don't get httptrace information. Websocket clients
should however retry on their own anyway.
More

[x] Added/updated tests

I'm wondering whether I should change that PR to be against v1.6, as it's basically a bug fix. WDYT?

Thanks for the response @Juliens. I still think that websocket clients should be resilient to network failures and therefore, retries are not an important feature for them as they have to retry on their own. That's why I see the bugfix of potentially duplicated requests due to the retry logic more important than retries for websockets. jm2c

@marco-jantke after more discussion about this, and as my PR on gorilla/websocket seems stuck, we agree that we could merge this one without the websocket support, and we will do another PR as soon as things move on gorilla/websocket.
But as it makes some kind of regression on websocket retry support, we think we will merge it in the next minor release (1.7) and not in the next bugfix release. WDYT?

SGTM.


Fix capability option race and panic.

Race
With the following code:
var WithAllCapabilities = WithCapabilities(GetAllCapabilities())

All WithAllCapabilities option will share the same instance of capability list returned by GetAllCapabilities(). This means that dropping a cap will actually drop the cap for all WithAllCapabilities callers.
This is very bad, and we may want to cherry-pick this fix.
Without the fix, the newly added test will fail:
--- FAIL: TestDropCaps (0.00s)
    spec_opts_test.go:487: cap list 0 doesn't contain non-dropped cap
    spec_opts_test.go:487: cap list 1 doesn't contain non-dropped cap
    spec_opts_test.go:487: cap list 2 doesn't contain non-dropped cap
    spec_opts_test.go:487: cap list 3 doesn't contain non-dropped cap
FAIL
exit status 1
FAIL	github.com/containerd/containerd/oci	0.032s

Panic
When pushing the change, I found https://github.com/containerd/containerd/pull/3117 has already handled the panic.
But it seems better not to assume there is no duplicated cap.
Without the fix, the newly added test will panic:
--- FAIL: TestDropCaps (0.00s)
panic: runtime error: slice bounds out of range [recovered]
	panic: runtime error: slice bounds out of range

goroutine 13 [running]:
testing.tRunner.func1(0xc0000bcc00)
	/usr/local/go/src/testing/testing.go:792 +0x387
panic(0x635e60, 0xa43ad0)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
github.com/containerd/containerd/oci.removeCap(0xc0000bb080, 0x67743b, 0x9)
	/usr/local/google/home/lantaol/workspace/src/github.com/containerd/containerd/oci/spec_opts.go:778 +0x24e
github.com/containerd/containerd/oci.WithDroppedCapabilities.func1(0x0, 0x0, 0x0, 0x0, 0x0, 0xc0000baf80, 0x0, 0x0)
	/usr/local/google/home/lantaol/workspace/src/github.com/containerd/containerd/oci/spec_opts.go:826 +0x8f
github.com/containerd/containerd/oci.TestDropCaps(0xc0000bcc00)
	/usr/local/google/home/lantaol/workspace/src/github.com/containerd/containerd/oci/spec_opts_test.go:494 +0x7a0
testing.tRunner(0xc0000bcc00, 0x684ed0)
	/usr/local/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:878 +0x353
exit status 2
FAIL	github.com/containerd/containerd/oci	0.035s

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #3137 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
+ Coverage   43.58%   43.59%   +0.01%
==========================================
  Files         104      104
  Lines       11156    11159       +3
==========================================
+ Hits         4862     4865       +3
  Misses       5555     5555
  Partials      739      739

Flag
Coverage Δ

#linux
47.59% <100%> (+0.02%)
:arrow_up:

#windows
40.49% <100%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

oci/spec_opts.go
30.58% <100%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a7da8...808b223. Read the comment docs.

LGTM


Convert get_ and put_ to functions

This shaves off about 1 kB of flash usage from my client application.
It is also more type safe, which is nice.

Passing build here https://github.com/jonathangjertsen/nanoMODBUS/runs/7571588260

Hi, I was experimenting with the various automatic CI options, that's why this warning appeared. Can you merge/rebase your branch with master?

Thank you


R32.6.1-t194: Container doesn't work properly

Describe the bug
Testing on wip-dunfell-l4t-r32.6, jetson-agx-xavier-devkit, demo-image-full.
Docker container does't work on L4T R32.6.1, when running the docker container got the following issue
root@jetson-agx-xavier-devkit:~# docker run -it --rm --runtime nvidia --network host nvcr.io/nvidia/l4t-ml:r32.6.1-py3
docker: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"process_linux.go:413: running prestart hook 0 caused \\\"error running hook: exit status 1, stdout: , stderr: nvidia-container-cli: mount error: file creation failed: /var/lib/docker/overlay2/7386e75626ea397b81f50e58d83867856c546e7ca1e4d4afa26d458be3d243ba/merged/usr/lib/aarch64-linux-gnu/libvulkan.so.1.2.141: file exists\\\\n\\\"\"": unknown.
root@jetson-agx-xavier-devkit:~#

When using docker container with tag r32.5.0-py3 on the same L4T release, It works fine
Needs investigation.
To Reproduce
Steps to reproduce the behavior:

Use tegra-demo-distro, branch wip-dunfell-l4t-r32.6
Build demo-image-full
Load onto target (tested with Xavier AGX devkit)
try the following commands

$ sudo docker pull nvcr.io/nvidia/l4t-ml:r32.6.1-py3
$ sudo docker run -it --rm --runtime nvidia --network host nvcr.io/nvidia/l4t-ml:r32.6.1-py3

I tried the following command and it works fine.
$ sudo docker run -it --rm --network host nvcr.io/nvidia/l4t-ml:r32.6.1-py3

I think that the docker container with tag r32.6.1-py3 is not stable.

NVIDIA published a new 0.10-jetson version of libnvidia-container.  We need to adapt the patches we have for the older version onto the new version.

We'll also need to review the way we manage the CSV files, since one of the features in the new version is to allow for reduced mapping to the underlying OS by treating "base" mappings differently from others.

We should be compatible with the old version, I mean 0.9.0 of libnvidia-container, right ?

For R32.6 we need to update to the new version, since all of the NVIDIA R32.6-based containers will expect to be using the new libnvidia-container interface.

I'm working on it

#771 PR is ready for review

@madisongh
Should we upgrade the docker-ce as well to be aligned with L4T R32.6.1 ?

Should we upgrade the docker-ce as well to be aligned with L4T R32.6.1 ?

Let's focus on the NVIDIA-specific packages, not stock Ubuntu/upstream packages.

This error:
nvidia-container-cli: mount error: file creation failed: /var/lib/docker/overlay2/7386e75626ea397b81f50e58d83867856c546e7ca1e4d4afa26d458be3d243ba/merged/usr/lib/aarch64-linux-gnu/libvulkan.so.1.2.141: file exists

is due to that library being installed by the tegra-libraries recipe.  I think the solution is to remove it.

Ok,
I tried docker yesterday and it works fine when using Xavier AGX, I will double check later. Otherwise, I will remove the library.

I've pushed 7d2bc945e3735e010fc83734738d388765f10012 to the branch, and now the l4t-ml container starts with no errors.


Automated Package Upgrade

:tada: This PR is included in version 7.0.64 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add ability to modify properties before the data pipeline

Adds the ability for package users to inject logic into the process of their data object being created. More specifically, between normalization and the data pipeline.
The motivation for this is so that users may normalize the structure of their data.
Personally, we've had situations where data coming in from an API has a different structure than data coming in from a csv import, but they both need to be massaged into the same DTO.
This PR enables a natural way to do that without having to override the magic creation methods, which breaks all of the wonderful data pipeline functionality (mapping, casting, etc.) that makes this package so useful.

Thanks!


refactor: purge ids-multipart occurrences

What this PR changes/adds
Remove all the "ids-multipart" occurrences and related code
Why it does that
cleanup
Further notes

removed some @Deprecated methods in the ServiceExtensionContext

Linked Issue(s)
Closes #2442
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.03 :warning:

Comparison is base (88a8343) 64.46% compared to head (94a0830) 64.43%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
- Coverage   64.46%   64.43%   -0.03%
==========================================
  Files         936      936
  Lines       19170    19138      -32
  Branches     1030     1028       -2
==========================================
- Hits        12357    12332      -25
+ Misses       6425     6420       -5
+ Partials      388      386       -2

Impacted Files
Coverage Δ

...iation/ConsumerContractNegotiationManagerImpl.java
96.52% <ø> (-0.09%)
:arrow_down:

...iation/ProviderContractNegotiationManagerImpl.java
96.15% <ø> (ø)

.../connector/service/catalog/CatalogServiceImpl.java
100.00% <ø> (ø)

...tractnegotiation/model/ContractNegotiationDto.java
100.00% <ø> (ø)

...gotiation/model/NegotiationInitiateRequestDto.java
100.00% <ø> (ø)

...ment/transferprocess/model/TransferRequestDto.java
100.00% <ø> (ø)

...ava/org/eclipse/edc/spi/result/AbstractResult.java
87.09% <ø> (+2.72%)
:arrow_up:

...clipse/edc/spi/system/ServiceExtensionContext.java
0.00% <ø> (ø)

...sfer/dataplane/TransferDataPlaneCoreExtension.java
94.11% <100.00%> (ø)

...e/flow/ConsumerPullTransferDataFlowController.java
100.00% <100.00%> (+5.88%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


refactor: make deref intentions more straightforward

Just some little tweaks to make intentions of deref more straightforward.

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+
Thanks!

:pushpin: Commit dfe4e670b1d5a6aa981c9958d899e37ee58bfed1 has been approved by alexcrichton

:hourglass: Testing commit dfe4e670b1d5a6aa981c9958d899e37ee58bfed1 with merge adb35807a3643962f27b428a05485d9cc8fc0ae0...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing adb35807a3643962f27b428a05485d9cc8fc0ae0 to master...


Motion dataset: point order of polylines

Hi Waymo Team,
I wonder how the points in polylines are arranged since I can't find any document talking about this.
Polylines exist in LaneCenter, RoadEdge, and RoadLine features. For polylines in LaneCenter, I guess the direction of polyline[i+1] - polyline[i] is the same as the driving direction of the lane (correct me if I'm wrong). But how about the point order in road edges and road lines? Does the direction of polyline[i+1] - polyline[i] follow any specific pattern (e.g., the coordinates being oriented counter-clockwise if the road edge is a part of the drivable area's exterior)?

Sorry for the late reply,
The direction of road edges is defined such that the road area is always to the left of the boundary.  For road lines there cannot be a specific direction ordering as lines that divide opposing lanes can be defined in either direction.
Please let me know if you have further questions.

Thanks for the clarification! It makes sense.


Using @here for notifications

As per the title - is there a way to use @here for mentions?

Hi @andrewbelcher . You can use @here in the notification message.

I tried so many things, why didn't I think of that! :man_facepalming:
Thanks!


Django 3.0.1 support

In Django 3.0.1 there is a DeprecationWarning with the imp module in the env.py file.
django_assets\env.py:1: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
I would be very happy about a fix :)
Greetings

Is it fixed ? :)


drivers: sensor: lis2dw12: Add Power Domain Handling

The lis2dw12 accelerometer driver now supports power domains via CONFIG_PM_DEVICE. If the config is selected, the driver will be required to provide a power-domain and will initialize itself by enabling pm_device_runtime on this domain.
Tap detection can be enabled by setting the sensor_trigger_set callback to a valid callback function - which in turn gets the power domain and keeps it until sensor_trigger_set is called with a NULL callback. This way, interrupt based events can be caught, while the driver stays on a power domain - assuming that the detection is disabled once it is no longer needed.
Similarly, a sensor attribute for continuous measurement mode has been added to allow for an application to continuously fetch data from the sensor without having to power - and reinitialize - only during a fetch call. When set using sensor_value, the driver keeps the power domain and does not put it back until the attribute is reset again.
Additional flags have been introduced to handle any overlap of domain requesting/putting back. The ability to set the default fifo mode has also been added.
Clang formatting has also been introduced for previously incorrectly formatted source files

Please rebase. Sorry I missed this PR evolution


46 tier 1 create checkout pagecomponent

Warning: Failed prop type: Invalid prop spacingof value24supplied toForwardRef(Grid), expected one of [0,1,2,3,4,5,6,7,8,9,10].
Let's talk thru how Grid works in MUI! then you can make the needed changes.
We'll talk thru how to use spacing and columns
https://mui.com/material-ui/react-grid/

pls remember to remove hardcoded review section in another issue


Add revert error strings for TokenNetwork

Fixes https://github.com/raiden-network/raiden-contracts/issues/81
This is in work. The contract currently fails with Contract code size exceeds EIP170 limit of 24577.  Got code of size: 24781
We can either remove some of the error messages and keep the very important ones or delay adding them until we have some cleaner code with modifiers (this would remove some of the duplicate error messages).

@hackaugusto , my initial version was very similar to what you are suggesting above. That version did not compile, due to the mentioned error from my description, so I cut out every channel state etc. in order to make the error message as small as possible, but still trackable.
Still, compilation fails because of the size.
This is why I discontinued work on this PR for now.

This is why I discontinued work on this PR for now.

My bad, I didn't pay attention to the WIP tag.

my initial version was very similar to what you are suggesting above

Since we are here, we could either

Use number IDs instead of proper strings to identify the errors. Which makes the code a bit less readable but may fix the problem for now
Split the TokenNetwork in libraries

Use number IDs instead of proper strings

There are some discussions about status codes, as mentioned in https://github.com/raiden-network/raiden-contracts/issues/81#issuecomment-410663218
We can have our own. But we should remember that we cannot even use error strings at this point, so there is no rush to include them.

Split the TokenNetwork in libraries

Yes, I am thinking about this. I will open a discussion about this and the new cheap delegatecall proxy (no need to be upgradable), so we can discuss it.

There was a second attempt.  The bottleneck is the runtime code size.


Unicode error in setup.py

When make
buildozer android update

buildozer.spec:
requirements = python3,kivy,android,git+https://github.com/HeaTTheatR/KivyMD.git

Traceback (most recent call last):
    File "/home/andrew/diary-build/.buildozer/android/platform/build/build/venv/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
      main()
    File "/home/andrew/diary-build/.buildozer/android/platform/build/build/venv/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/andrew/diary-build/.buildozer/android/platform/build/build/venv/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 54, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/tmp/pip-build-env-luizt1is/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 146, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "/tmp/pip-build-env-luizt1is/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 127, in _get_build_requires
      self.run_setup()
    File "/tmp/pip-build-env-luizt1is/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 237, in run_setup
      self).run_setup(setup_script=setup_script)
    File "/tmp/pip-build-env-luizt1is/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 142, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 5, in <module>
      ver_file_data = open(VERSION_FILE, "rt").read()
    File "/home/andrew/diary-build/.buildozer/android/platform/build/build/venv/lib/python3.6/encodings/ascii.py", line 26, in decode
      return codecs.ascii_decode(input, self.errors)[0]
  UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 25: ordinal not in range(128)

file __init__.py has non-Latin characters like in string Andrés Rodríguez
Maybe better to use io.open instead open?

https://github.com/HeaTTheatR/KivyMD/issues/53

but I don't use python 2, it is python 3.6


UART input does not work on mps2_an{385,521}

Describe the bug
UART input does not work on mps2_an385 and mps2_an521 boards (in QEMU).
For example, the tests and samples that rely on the UART input functionality such as drivers/uart/uart_basic_api and shell are unable to accept any user input.
To Reproduce
In QEMU, run any tests and samples that require user input through the UART interface such as:

drivers/uart/uart_basic_api
samples/subsys/shell/shell_module

Expected behavior
UART user input is echo-ed on the input prompt.
Impact
Board usability is limited
Environment (please complete the following information):

OS: Ubuntu 18.04
Toolchain: Zephyr SDK 0.11.2
Commit SHA: 855b6c1a5ded091003d96a7b8d2b81662edbef70

Additional context
Broken UART driver suspected

Removing the priority, we will go through it later today.

@microbuilder can you try one of these tests/samples on a real MPS2 to see if this shows up on real HW as well.

Repeatable on actual HW as well (UART input also doesn't work, output from AN521 -> USB Serial does work fine, as is the case with QEMU).


Allow increasing text box font size

Is your feature request related to a problem? Please describe.
The output text is very small. It renders particularly small on my 4k display.
Describe the solution you'd like
Add configurable font size, or use editor's font size by default
Additional context
Example screenshot:

Thanks for reporting this issue.
It looks very strange, some UI glitches ;(
Can you please add some more infos:

the Godot version you used?
the OS/System
the used screen resolution

Thanks for all of your help so far!

the Godot version you used? 3.3.3
the OS/System. macOS Monterey version 12.0.1
the used screen resolution? 3840 × 2160


SSH Host-Key Pinning?

Hello,
we currently use the extra_user_data_content to specify a shell script that fetches host-keys from AWS secrets-manager to store them and effectively pin the ssh host key to avoid regeneration after AMI updates:
get_secret_string ${secret_arn_ed25519} | jq ".public" -r > /etc/ssh/ssh_host_ed25519_key.pub
get_secret_string ${secret_arn_ed25519} | jq ".private" -r > /etc/ssh/ssh_host_ed25519_key

get_secret_string ${secret_arn_ecdsa} | jq ".public" -r > /etc/ssh/ssh_host_ecdsa_key.pub
get_secret_string ${secret_arn_ecdsa} | jq ".private" -r > /etc/ssh/ssh_host_ecdsa_key

this does not work properly though, it seems we're missing the rsa key, a ssh-keyscan bastion does only respond with a changing ssh-rsa key after AMI updates.
Could you advise where to put keys of which algo and does it make sense to make ssh-host-key-pinning an actual first class feature of the bastion?
Thanks for the great work, Kai

double checked systemctl status sshd  which yields
Mar 15 09:51:00 ip-10-117-5-254.eu-central-1.compute.internal sshd[4699]: error: Could not load host key: /etc/ssh/ssh_host_ecdsa_key

so that's  on us...

@hotzen can you please share the rest of your user data content script? I am looking to implement a similar solution.


Usage as a library

Hi and thanks for the great job! Do you have an example of usage obj23dtiles as a library (run from JavaScript)? Thank you in advance!

@IgorGrechka
Are you mean this?

@PrincessGod
Oh! It was there! Thank you very much!


Add redundant control to avoid goroutine leaks

it's important to add a "emergency exit" to non native timeouts when running commands to avoid goroutine leaks. For instance, add a select statement on go func(){}() creation to default listen do the command return OR exit on a timeout channel sent by the caller function on timeout.

Fixed by #6


Make FieldType and @@ abstract

aka.

Also has the additional benefit of printing more nicely in the REPL.
This will always box however. Would that be a problem?
TODO: Check which bugs are fixed, reference them here and add regression tests:

[x] Should close #644 - check that value classes and arrays work (boxed)
[x] Should fix #584 in a different way than #797 - add regression test
[x] Should fix #557 - add regression test
[x] Fully fixes #309 - removed workaround
[x] Should fix #44 - similar to #644 (with boxing)

Progress!
The boxing issue is solved by scala/scala#8720 so we can have our cake and eat it too.
Dotty has better type inference and some simple cases that I tried work better than in Scala 2 with the current encoding of tagged types. I still need to come up with a better comparison (and also check how they are erased in dotty).
I agree that perhaps tagged types will not be completely replaced (because they are subtypes) but as a native solution I expect opaque types to become much more widely used, perhaps even as much as to make tagged types on shapeless 3 unwarranted.

Changed milestone to 2.5.0 which will be 2.13 only.
If scala/scala#8720 is merged (I see no reason why not) then this has no downsides.

Codecov Report

Merging #807 into master will decrease coverage by 2.01%.
The diff coverage is 10.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233047d...bf8c199. Read the comment docs.

Changed milestone to 2.5.0 which will be 2.13 only.
If scala/scala#8720 is merged (I see no reason why not) then this has no downsides.

In the end it was not merged. In Scala 3 we have opaque types.


Packages are missing after Upgrade from v3 to v4

While upgrading Vaadin from bower to npm mode I also upgraded this library from 3.0.0.beta5 to 4.0.0.rc4. However, many packages are now missing, such as:
com.github.appreciated.app.layout.behaviour
com.github.appreciated.app.layout.builder
com.github.appreciated.app.layout.notification
com.github.appreciated.app.layout.router
Apparently there were backwards-incompatible changes from v3 to v4? Are there any release notes or other docs on how to deal with that?

The release notes are on the directory page

Apparently there were backwards-incompatible changes from v3 to v4?
Yes there were.
Are there any release notes or other docs on how to deal with that?
You could remove the packages manually and use your IDE autocompletion.

Another option would be to checkout the demos.

Yes, autocompletion only got me so far, because some packages have no replacement and methods are missing / have different signatures. Looks like I'll have to reimplement this from scratch according to the demo. Thanks for your help.

Yes there were some naming inconsistencies, sorry for the inconvenience.
If I remember correctly every class has a replacement, but the name, the package, or the parameters might have changed slightly.
There should be no need for a "reimplementation".

Ok, I'll get it done. Just needed the info what I'll have to do and wanted to make sure I'm not barking up the wrong tree (such as having included the wrong dependencies or such).


Win/HEDO virus warning (AVG Free)

Just downloaded the plugin plgx (181d870), and copied it to the plugins directory. When starting KeePass, AVG immediately complains about the virus, and KeePass generates an error obviously because it can't access the KeePassBrowserImporter.dll temp file.
My virus definitions are up to date according AVG

Which file does it complain about?
I'm not really surprised an AV does complain about the functionality because every login stealer would work like this and use the files which are shipped with the plugin.

Here are virustotal scans of the main files:
KeePassBrowserImporter.dll (compiled with .NET4 and KeePass 2.44)
https://virustotal.com/de/file/00e27aff9d252362dfc2a2a45cb7c96b81f1795000b3c38e518c2ba06e778d59/analysis/
htmlagilitypack.dll
https://virustotal.com/de/file/6fd971f30d36ad09523dcde9c5008dd1331736b4207a1e9fe672d209991587e1/analysis/
system.data.sqlite.dll
https://virustotal.com/de/file/3c7a9267f520208bad23fa5de9508d42f0688869616346d6393414917b1886a7/analysis/
All have 0 positives.

It complained about KeePassBrowserImporter.dll in the temp directory. I
uploaded the dll to virustotal.com and got the same results as you. So most
likely a false positive, nevertheless annoying. I reported the file back to
AVG.
Note that this prevents me from using the plugin, unless i disable AVG.
Op 14 jun. 2016 21:11 schreef "KN4CK3R"<EMAIL_ADDRESS>
Here are virustotal scans of the main files:
KeePassBrowserImporter.dll (compiled with .NET4 and KeePass 2.44)
https://virustotal.com/de/file/00e27aff9d252362dfc2a2a45cb7c96b81f1795000b3c38e518c2ba06e778d59/analysis/
htmlagilitypack.dll
https://virustotal.com/de/file/6fd971f30d36ad09523dcde9c5008dd1331736b4207a1e9fe672d209991587e1/analysis/
system.data.sqlite.dll
https://virustotal.com/de/file/3c7a9267f520208bad23fa5de9508d42f0688869616346d6393414917b1886a7/analysis/
All have 0 positives.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KN4CK3R/KeePassBrowserImporter/issues/4#issuecomment-225985643,
or mute the thread
https://github.com/notifications/unsubscribe/AGXzc-Hzu3dL9-a9JPtOd4LEU0tyGiUqks5qLvzTgaJpZM4I1mVh
.


WIP: Standard decorators

This doesn't build yet. Unfortunately we need a separate compilation until for the standard decorator tests so that we can turn off experimentalDecorators. When I did that I ended up bringing in files from the main tsconfig, which is an error. Maybe project references will help?
As for the implementations, they're untested and were ported before decorator metadata was available, so @property() definitely doesn't work yet.
This is also only the main decorators, not any in labs.

Got the core decorators building and test passing locally.

We should address https://github.com/lit/lit/issues/1476 in this PR too

@rictic I forgot to push my changes last night - just pushed now.


#8: Sort Issue fix

#8: This PR resolves the issue with the sort package installation by cloning the repository and properly integrating it into the project. It ensures the sort functionality works seamlessly with the existing setup.

The code has been updated to python 3.10 and the README has been updated to fix the sort issue. Try it out and hopefully, the pull request wont be required.


feat: add nessie

Depends on:

https://github.com/TOSIT-IO/tdp-collection-extras/pull/25

Please, merge it first.
Which issue(s) this PR fixes:
Fixes #105
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004 and that you give permission to TOSIT,
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

@sergkudinov thank you for your contribution to TDP!
In a fully open-source approach, all Issues/Pull Requests are fairly examined for integration.
Your PR integrates a new technology to TDP. Can you please open a new discussion for validation before any implementation. See the TDP new component proposal guidelines for details on how to organize your request.
Thank you again for your contribution to TDP.

Closing as stale


Create foli8

(Put an X inside the [ ] to denote check mark [X].)

[ ] If creating a new file :

[ ] added links to it in the README files ?
[ ] included tests with it ?
[ ] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[ ] if done some changes :

[ ] wrote short description in the PR explaining what the changes do ?
[ ] Fixes #[issue number] if related to any issue

[ ] other

Hi @abd171256 . Sorry this repository only focus on Python programming language. Close it now.


Typo: worklow

What article on docs.github.com is affected?
https://docs.github.com/en/rest/reference/repos

What part(s) of the article would you like to see updated?
Search for worklow.

Additional information
I git grepped and found the same typo in several places.

This issue appears to have been opened accidentally.

Well, no, it's a legitimate issue. However, the source of the typo seems to be external to this repo, so :man_shrugging:

I have no idea why the bot closed this issue @2uasimojo Sorry about that! You're right, the typo is in our rest docs, which are autogenerated from an internal source. I'm going to reopen this issue, add a label, then some of our automation will copy the issue to our internal repo for a fix and close this issue out again.
Sorry about the confusion 💛


support KCell.min, KCell.min , Instance.xmin, INstance.ymin ... in um

How could we support xmin, ymin, in um both for KCells and Instances?

How would you even do that?

How about doing that gdsfactory side, by subclassing KCell and Instance?

I see, okay, maybe then we need to make a big tutorial and explan that people need to use Instance.d.xmin instead

I think it's a reasonable request, but whether we do it in kfactory or gdsfactory is about the same amount of work with gdsfactory having to do even more wrapping because you want to inherit

yes, im concerned about lots of people Pcells will break if we don't keep backwards compatibility

Can we just inherit from UMKCell?

Yes you can if you are willing to call .parent anytime you call anything kfactory which requires a KCell