[BEAM-498] Make DoFnInfo carry unspecified Serializable (DoFn or OldDoFn)

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This will allow consumers to prepare to accept DoFn while still accepting existing jobs that use OldDoFn.

R: @lukecwik

(74801b34c18d39d1): Exception: java.lang.NoSuchMethodError: org.apache.beam.runners.dataflow.util.DoFnInfo.getDoFn()Lorg/apache/beam/sdk/transforms/OldDoFn;
com.google.cloud.dataflow.worker.runners.worker.DoFnInstanceManagers$ConcurrentQueueInstanceManager.deserializeCopy(DoFnInstanceManagers.java:66)
com.google.cloud.dataflow.worker.runners.worker.DoFnInstanceManagers$ConcurrentQueueInstanceManager.peek(DoFnInstanceManagers.java:48)
com.google.cloud.dataflow.worker.runners.worker.UserParDoFnFactory.create(UserParDoFnFactory.java:71)
com.google.cloud.dataflow.worker.runners.worker.DefaultParDoFnFactory.create(DefaultParDoFnFactory.java:70)
com.google.cloud.dataflow.worker.runners.worker.MapTaskExecutorFactory.createParDoOperation(MapTaskExecutorFactory.java:256)
com.google.cloud.dataflow.worker.runners.worker.MapTaskExecutorFactory$1.typedApply(MapTaskExecutorFactory.java:160)
com.google.cloud.dataflow.worker.runners.worker.MapTaskExecutorFactory$1.typedApply(MapTaskExecutorFactory.java:147)
com.google.cloud.dataflow.worker.graph.Networks$TypeSafeNodeFunction.apply(Networks.java:55)
com.google.cloud.dataflow.worker.graph.Networks$TypeSafeNodeFunction.apply(Networks.java:43)
com.google.cloud.dataflow.worker.graph.Networks.replaceDirectedNetworkNodes(Networks.java:78)

Curious. I'll make another.

It was the alteration of the construction without leaving a deprecated one in place. Should be fixed now.

Doesn't that imply that you created a worker that still depends on that function which passes in an OldDoFn?

Yes, you are right. I read it wrong.

LGTM


WIP - feature completeness with 2.1.5

Pull Request (PR) description
feature-completness-with-2.1.5 tries to make puppet-keealived feature complete in a sense that all options keepalievd 2.1.5 provides, can be set via this puppet module.
This Pull Request (PR) fixes the following issues
Currently a lot of options are missing :/
State of the Pull Request
This is currently and at the moment Work In Progress. I just wanted to push early to have the change to get early feedback, too.
So far global_defs should be completely covered. Only a few options are missing in spec. Anyone reading this is invited to give me a pair of eyes and provide some hints how to cover the missing ones!
I had a talk with @ghoneycutt and he gave me the /ok/ to just do a large commit, as I do not change features, but just adding new options. As you can see in global_defs some options are now set to undef as they only reflect the implicit default state of keepalived. I'm not quiet sure if this is just some old stuff or if keepalived actually switched that in the last 3(?) years...
In the next days I want to try to do the same  with vrrp_instance. As I have no clue about LVS, I will quietly ignore this for now. I maybe will continue with vrrp_script then...
Anyway I have some "questions" aka I'm unsure about it, and like to get feedback:

I've set all params of global_defs to have a Data Type; I tried to reflect documentation from keepaliveds manpage as good as I could. Could someone have a look and give me a "go ahead"/continue or a "please stop and do it that way"?
Should the test in spec cover allowed vaues of an option? Like if when an Integer can only be set between 0 and 99, or where does this go?
How do I write a spec for situations with like nftables: it could be just set, (with puppet via true, but in the config without parameter) and it could also have one parameter or two, if the user wants to specify the chain.

Closing note for now:
I've ordered all options as they appear in keepaliveds documentation to make it easier to compare the state of "feature completeness".
Thanks.

@ghoneycutt could you do a first review, now that all checks are passing? Thanks.

Will this get done any time soon? Debian Bullseye will be shipped with 2.1.5 .

@sprd-bena hey, any chance that you can rebase this against our latest master branch?


Remote Monitoring local deployment not working - Device Simulation service

Type of issue

[ ] Bug
Device simulation service (running in docker for Windows) throws an exception that... not able to reach Storage Service.
[ ] New feature
[ ] Improvement

Description
Trying to setup local instance of Remote Monitoring application.
Followed the steps mentioned in...
All the services (except Device Simulation) are started in debug mode in Visual Studio 2017.
Device simulation (docker) throws an error saying not able to reach storage service which is running on host (http://localhost:9022/v1).
[Stated docker image without "--detach" in run.cmd to see logs]
My observation:
I see Device Simulation service is trying to reach Storage service using "http://localhost:9022/v1/" though the run.cmd has an environment variable for storage service with value "http://host.docker.internal:9022/v1".
Screenshot
Steps to reproduce

[First step]
[Second step]
[and so on...]

Expected behavior
...
Current behavior
...
Known workarounds
...
Possible solution
...
Context and Environment

Operating System: ...
GitHub branch: ...
.NET Runtime: ...

Followed steps mentioned in...
https://docs.microsoft.com/en-us/azure/iot-accelerators/iot-accelerators-remote-monitoring-deploy-local

Any update on this defect? please update. Thanks.

I am facing the same issue, I would appreciate help on the possible solution to this issue.

Note: As of December 10th 2020, Remote Monitoring solution accelerator is no longer supported. All supporting repositories have been archived.


Clicking on Cluster zooms map past maxZoom

Is there a way to set this up to when you click on a Cluster, it will not zoom past your maxZoom?
My maxZoom is set to 14, so I don't want clicking on a Cluster to zoom past that point, but the default when clicking on a Cluster is zooming the map to like 18.

Hi everyone, it looks like I was able to find a workaround for this by simply adding a maxZoomLevel={} to the  component (in addition to maxZoom={}).
maxZoom - This breaks up the Cluster at zoom level X
maxZoomLevel - This prevents the Cluster from zooming in all the way after breaking (which can be jarring).
Not ideal as it prevents the user from zooming in further past maxZoomLevel if they so desire, but it does prevent the Cluster from zooming in all the way.
If someone has a better solution, please let me know.


RemoveIgnored: Set names for removed members to AddPadding::MemberPrefix

This means they will be treated as padding, so CodeGen will not try to store any data for them.

Codecov Report

Merging #227 (4b6e530) into main (28b813c) will decrease coverage by 2.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   66.30%   64.08%   -2.23%
==========================================
  Files          90       90
  Lines        9940     9940
  Branches     1621     1621
==========================================
- Hits         6591     6370     -221
- Misses       2498     2706     +208
- Partials      851      864      +13

Impacted Files
Coverage Δ

test/test_remove_ignored.cpp
96.66% <ø> (ø)

oi/type_graph/RemoveIgnored.cpp
100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Strings detected as Enum

Im not sure when this happened, probaly when pre_analysis was made but now the most_common list is initialised after the type is defined so the most_common list is always empty. Thus all strings are classified as enum. Most_common needs to be called before define_type for string detection.
Also with variable enum_threshold values the most_common list must also be variable because of how enum is determined. ie it starts at 15 now when the threshold is 10 but must be more is the enum threshold is more @JJHedges

Problem was with all unique sets having most_common being set to empty


New version: Microsoft.DevHome version 0.601.285.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

[Policy] Needs-Attention

@wingetbot waivers Add Validation-Installation-Error


[WIP] OA failsafe

We need a way to trigger a failsafe in the case where the obstacle avoidance dies or does not provide input for any other reason.
Problem:
We are in Mission mode and the obstacle avoidance is enabled (MPC_OBS_AVOID = true). The planner provides setpoints to guide the drone around any obstacles which lie in the straight path between the mission points. If the planner dies, the regular mission is resumed without the planner input and the drone just flies straight to the next mission point. This can be very dangerous if it happens close to obstacles.
Solution:
If in Mission mode and OA is enabled, check if setpoints from planner are received. If there is a timeout on these points, take failsafe action.
Note: I'm not sure whether this is an acceptable way to solve this problem, or if the logic for that should go into commander. I'd be glad for any input on solving this issue.

FMI, what are the failsafe options you plan on offering?
Common options are: https://docs.px4.io/en/config/safety.html#failsafe_actions

@hamishwillee I'm not very familiar with the failsafe options and how to trigger them individually. What I did in the code was switch to the failsafe flight task. I thought it would choose and appropriate reaction automatically. When I tested this code in SITL the drone went into some kind of LOITER/HOLD state when I killed the planner. This would probably be the preferred reaction. To me it is most important that the drone aborts the mission and does not just continue on straight line (as this caused a crash lately).

@hamishwillee I'm not very familiar with the failsafe options and how to trigger them individually.

I'm not either. If I had to do this I would ask @bkueng what he thinks. Beat, that's what you get for knowing things :-)

What I did in the code was switch to the failsafe flight task. I thought it would choose and appropriate reaction automatically. When I tested this code in SITL the drone went into some kind of LOITER/HOLD state when I killed the planner. This would probably be the preferred reaction. To me it is most important that the drone aborts the mission and does not just continue on straight line (as this caused a crash lately).

FWIW IMO Hold mode is a fine default option because there is a good chance that with obstacle avoidance people will plan more risky missions "altitude-wise" than otherwise - so proceeding with the normal mission is dangerous. But I do think that this is something that you might want to offer as an option. As a user I would like the option to instead choose RTL - that is likely to be safe in most cases because it starts with ascending to a safe level.

I checked and apparently the failsafe when the update() function returns false is different which should not be the case. Let me find a fix for that. Then we can just trigger it.


Character string problem in JS

Special characters in strings are modified by v2.4.0. A line like
var a = "
anything
";
is converted to
var a="\x3cdiv\x3eanything\x3c/div\x3e";
Please leave character strings unchanged!

Hey, thx for the report. Will look at it soon :)

Fixed in 2.5.0


MudSelect does not show renderfragment when value is null and type is "bool?"

Bug type
Component
Component name
MudSelect
What happened?
MudSelect does not show renderfragment when value is null and type is "bool?"
Expected behavior
If a text has been provided for a value, then it should be shown, even if that value is null.
Reproduction link
Change the select to "Open and closed" and see that the select shows blank
https://try.mudblazor.com/snippet/QEGcEAEjSarGPlZx
Reproduction steps

...
Relevant log output
No response
Version (bug)
v6.0.10
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is a minor issue which can be worked around by using something else than "bool?" for tristate.

Not sure what it should show. Its null and it shows nothing, sounds not bad 🙂

The value is null, but the display value is not. Just like true and false does not show "true" and "false"

The value is null, but the display value is not. Just like true and false does not show "true" and "false"

I understand your issue correctly now. Im now preparing a fix for this. We can use ToStringFunc as a workaround for now.
https://try.mudblazor.com/snippet/cucQailhSaazvqJH
Type doesn't matter, if value = null, renderfragment doesn't show. So its the same issue for all nullable types.

I'm having a similar issue wen loading a MudSelect from a  list of nullable ints (or any nullable type really).  The null option, if selected or defaulted, does not render the correct text.
Off
Daily
Weekly
@mckaragoz, Will your fix be included in the next update?  Thank you!!

@mckaragoz, Will your fix be included in the next update? Thank you!!

With #5150 we will change the usage of MudSelectItem and replace renderfragment to text
<MudSelectItem Value="@((int?)null)" Text="Off" /> So it will show the text.
But thats not the only problem, when you click on null value item, it selected, but it doesn't have selected style (the light blue background), also needs a fix.

You guys are amazing!!  Thanks so much!

Now MudSelectExtended is released. It should fix your issue.
Ready on Nuget: https://www.nuget.org/packages/CodeBeam.MudExtensions/6.2.1
Try online: https://codebeam-mudextensions.pages.dev/mudselectextended

@mckaragoz this doesn't seem to work, when I add
<MudSelectItemExtended T="PaymentMethodDef?" Value="@(null)" Text="(Undefined)"/>
I cannot select items anymore because of NullReferenceException

We are having a similar issue to what @kyletinsley and @bugproof reported, but we're getting an InvalidCastException
The following code throws an InvalidCastException because AddForm.AddFileType is NULLable (full stack trace is below).
			<MudSelect Label="File Type" @bind-Value=_form.FileType Clearable=true>
				@foreach (var type in Enum.GetValues<AddForm.AddFileType>())
				{
					<MudSelectItem Value="type">@type</MudSelectItem>
				}
			</MudSelect>

Our workaround was to add the "T=" with the nullable type.
			<MudSelect Label="File Type" @bind-Value=_form.FileType Clearable=true>
				@foreach (var type in Enum.GetValues<AddForm.AddFileType>())
				{
					<MudSelectItem T="AddForm.AddFileType?" Value="type">@type</MudSelectItem>
				}
			</MudSelect>

Seems we didn't need to add the "T=" to the MudSelect, either.  Just on the MudSelectItem.
Does this sound like the same underlying issue?
System.InvalidOperationException: Unable to set property 'IMudShadowSelect' on object of type 'MudBlazor.MudSelectItem`1[[LotteryReconciliation.Web.Features.Upload.AddForm+AddFileType, LotteryReconciliation.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]'. The error was: Unable to cast object of type 'MudBlazor.MudSelect`1[System.Nullable`1[LotteryReconciliation.Web.Features.Upload.AddForm+AddFileType]]' to type 'MudBlazor.MudSelect`1[LotteryReconciliation.Web.Features.Upload.AddForm+AddFileType]'.
 ---> System.InvalidCastException: Unable to cast object of type 'MudBlazor.MudSelect`1[System.Nullable`1[LotteryReconciliation.Web.Features.Upload.AddForm+AddFileType]]' to type 'MudBlazor.MudSelect`1[LotteryReconciliation.Web.Features.Upload.AddForm+AddFileType]'.
   at MudBlazor.MudSelectItem`1.set_IMudShadowSelect(IMudShadowSelect value)
   at Microsoft.AspNetCore.Components.Reflection.PropertySetter.CallPropertySetter[TTarget,TValue](Action`2 setter, Object target, Object value)
   at Microsoft.AspNetCore.Components.Reflection.ComponentProperties.<SetProperties>g__SetProperty|3_0(Object target, PropertySetter writer, String parameterName, Object value)
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Components.Reflection.ComponentProperties.<SetProperties>g__SetProperty|3_0(Object target, PropertySetter writer, String parameterName, Object value)
   at Microsoft.AspNetCore.Components.Reflection.ComponentProperties.SetProperties(ParameterView& parameters, Object target)
   at Microsoft.AspNetCore.Components.ComponentBase.SetParametersAsync(ParameterView parameters)
   at Microsoft.AspNetCore.Components.Rendering.ComponentState.SupplyCombinedParameters(ParameterView directAndCascadingParameters)


Full test of tutorial and report issues

Extra Step for setup (if in Gitpod -> already done, skip)
A service is available port 3000 -> maybe notice to refresh
Java syntax highlighting broken (Configuration Dockerfile?)
Kill ports at first build
Step3 size to 20,20 in normal description
Build button on last step

@max-elia : Could you recheck the issues above if anything is still relevant and if so created dedicated issues and close this one please.


add headers to studies; expand chapter limits

Can you add headers to studies?  Space is at a premium with only 62 or so available chapters.  If we need to use some of the chapters for section headings that's a bit of a waste and may force us to have fewer chapters than we otherwise would like.
Somewhat related, is it possible to expand the amount of chapters beyond the current limit (62 max)
Cheers, D

I could try to add chapter groups, under a header title, but I feel it would be a very complicated feature that would benefit only people with LiChess Tools. The amount of chapters is strictly server side and I can't do anything about it.


Update installation instructions

Update instructions for per-user configuration instead of system-wide configuration

Imma merge this real quick, because that's a very reasonable change. c:


Feature: footer

sticky footer at the bottom of the page.

All checks passed :heavy_check_mark:
The part of the project is complete and nothing more to add
Good work :muscle:


Python 3 syntax error.

choice_box.py: line 76
except Exception, e: generate a syntax error in python 3.x
modify it to: except Exception as e

This issue has already been opened several times. See issue #97 #101 #100 -- Additionally, a pull request has already been made for this change. We're just waiting for the maintainers to act.


Consistent Markdown syntax

”How do you like to spend your evenings, @paulrobertlloyd?”

Space after YAML frontmatter
Descriptions end with full stop
Use * for bulleted lists
Whitespace fixes
Fix incorrect date on one entry

Can we use - for bullets? It's easier to type. ¯_(ツ)_/¯

Why all the full-stops added to descriptions?

You should write a linter 😉

Descriptions end with full stop

Because these are sentences and, I’d image, helps when page is read aloud. (Note that there is widespread inconsistency on this across government)

Use * for bulleted lists

I didn’t have a good reason until now, when reviewing entries, where a line breaks before a hyphen, the following line looks like it’s a bullet; * doesn’t appear in running prose (and for bold text, is not surrounded by spaces).

Space after YAML frontmatter

A concession!

You should write a linter 😉

I actually have one set up on my own site, using markdownlint-cli. I can create a PR to port that over to this site.


refactor(): common TypeScript style

Formatted all TypeScript code to match what style rules used in the tslint.json. Also removed all use strict statements from TypeScript files as unnecessary.
Closes #449.

Coverage remained the same at 97.594% when pulling 83449e5eb5bd91a5e208ae2867f720d9c3f5aa9a on andrewconnell:typescript-cleaning into 8829fc627cd19914293cfa64f9461cc801d5bead on ngOfficeUIFabric:dev.

Coverage remained the same at 97.58% when pulling 5c77bffd9b36c353542194d6f3d0ee84f69b1a14 on andrewconnell:typescript-cleaning into 100a280a31823c33e431f9e69643e3d3e1f3368c on ngOfficeUIFabric:dev.


Error in the call method of ImageOverlay

There is a minor bug in the call of augraphy.utilities.imageoverlay.ImagOverlay
Parenthesis are missing in image.copy.
image.copy should be image.copy()
Also,
the class returns the a RGBA image (H,W,4) instead of a 1 or 3 channels image. I'm not sure if it is the intended meaning.
cheers

Hi @btessore!  It's always great to see someone identify a bug, so now we can make things even better!
Would you be able to prepare a pull request, or even a code snippet identifying what fix is needed and confirm on your end that it resolves the issue?

Hi, ImageOverlay is an internal function and actually it's obsolete now.
The similar functionality is replaced by OverlayBuilder now.


Add lastUpdated

Having some kind of date or timestamp element/attribute to know how up to date the information is.
It'd be useful when using different tagging tools so as they know wether or not to refresh the information.

Good catch! So, this should most likely be a top-level element but I'm not sure what the element name should be LastUpdated or LastModified. I'm leaning towards LastModified, but what are your thoughts?

To me they're all interchangeable so they'd all work, but you're right lastModified seems a better fit than lastUpdated


editMessageText / editMessageReplyMarkup methods always return "bad request"

I try sync/async, try to write "chat_id" and "message_id", but its always return "bad request"
P.S. Didn't try to use in "Inline Mode".

In dev branch this works, @zmeyc i think you can close this issue

Thanks! @iyumeg please reopen if this is still reproduced.


typo in draft

I am not sure here is right place.
Please forgive me if I am at wrong place.
I found a typo in recently updated draft.
https://brycelelbach.github.io/wg21_p2300_execution/execution.html#spec-execution.syn
Here,
  template <class T>
    concept queryable = destructible;

The template argument for std::destructible is missing.

Also, I can see some out-of-order declarations in 11.1. Header  synopsis.
For instance, sender_to concept uses completion_signatures_of_t and connect which are declared/defined later.
I am not familiar with this kind of draft document so maybe I should not consider those declarations are actually compilable code. If you want me to report them too, please let me know.

Another typo: https://brycelelbach.github.io/wg21_p2300_execution/execution.html#spec-execution.senders.consumers.sync_wait
Here, sync-wait-type is defined as a alias template which takes only one parameter but it is mentioned as sync-wait-type<S, sync-wait-env>.


Install all Lua version in same root dir to simplify cache

Ok. What do you think of having the platform in there too? For instance:
c:\lua\x86\5.2.4
c:\lua\x64\5.2.4

This way, I can ran the full matrix locally.

I have no objection.
But really I think we need 2 separate config to debug and to release because appveyor really slow.
So in debug mode (on every commit we run only few jobs) and on release we run all matrix and upload releases on github. There exist example in deploy docs.
PS. Right now I have problem with pushing to github because DDoS.

Also you can put LuaRocks to %LUA_DIR%
set LUAROCKS_INSTALL=%LUA_DIR%\LuaRocks
set LR_SYSTREE=%LUAROCKS_INSTALL%\systree

call install.bat /LUA %LUA_DIR% /Q /LV %LUA_SHORTV% /P "%LUAROCKS_INSTALL%" /TREE "%LR_SYSTREE%"

Good. Merged this. I'll split the instalation dir by architecture and also put LuaRocks in there.

I'd like to ellaborate a little bit on this:

But really I think we need 2 separate config to debug and to release because appveyor really slow.
So in debug mode (on every commit we run only few jobs) and on release we run all matrix and upload releases on github. There exist example in deploy docs.

When you talk about debug and release, you are talking about regular development (debug) and run full tests and deploy artifacts (release), right?
I think that is best to left the full matrix enabled by default. If you need to develop and test using a single configuration you can work on a branch and edit appveyor.yaml to suit your needs (to clarify, by "you" I mean whoever ends up using this example scripts).
About pushing releases to Github, that would be the icing on the cake. Push the release to Github, deploy the rock on LuaRocks. We should continue this in a new issue, don't you think?


Feature: programmatically calculates percentages in donut-chart if none are defined in data-set

Description
Modifies the following files:
src/charts/donut.js
-changes donut-chart percentage parameter from required to optional
-adds helper function sumValues
-modifies cleanData function to calculate percentages if none are defined in data-set
src/charts/helpers/common.js
-adds function calculatePercent that returns percent with customizable number of decimal places
-documents API in JSDoc
-organizes helper functions in alphabetical order
test/json/donutDataFivePlusOtherNoPercent.json
-adds new donut-chart data-set with no percentage values
test/fixtures/donutChartDataBuilder.js
-adds this.withFivePlusOtherNoPercent method to DonutDataBuilder function
test/specs/donut.spec.js
-adds function that runs all existing tests for each donut data-set
-adds test verifying cleanData function uses existing percentages if declared otherwise calculates values, and checks that correct values are generated
test/specs/helpers.spec.js
-adds test verifying calculatePercent returns correct percentage
-adds test verifying calculatePercent returns percent with specified number of decimal places
Motivation and Context
This change adds a new feature to the donut-chart so it can programatically calculate percentages if none are defined in data-set. Help Wanted #242

How Has This Been Tested?

Passes all tests. Adds two new tests and runs all existing donut-chart tests for new data-set.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

This looks perfect, thanks a lot!!
You will need to run npm run docs in order to generate the updated docs (we are going to try to fix this detail with Travis), and this will be ready!!

Fabulous! Jumping into the codebase was a lot of fun and Britecharts is a great tool! All of your work over the past two years was definitely worth it!


Quality filtering removing major part of my read even at 0

hello, thanks again for you work on this amazing pipeline.
I am trying to process my CO1 metabarcoding amplification of eDNA sample using your pipeline. However I find that the pychopper is removing an extremely high amount of sequence even when the quality score is set to 0
rule quality_filtering:
    input: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/fastq/barcode01_A_1.tmp
    output: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq
    jobid: 12
    reason: Missing output files: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq; Input files updated by another job: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/fastq/barcode01_A_1.tmp
    wildcards: sample=barcode01, unit=A
    threads: 40

                cat /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/fastq/barcode01_A_1.tmp | chopper --quality 0 --minlength 600 --maxlength 900 --headcrop 0 --tailcrop 0 --threads 40 > /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq

Activating conda environment: /mnt/ebe/Natrix2/.snakemake/conda/f6c0cf70
Kept 75770 reads out of 96754 reads
Removing temporary output file /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/fastq/barcode01_A_1.tmp.
[Fri Dec 20 11:09:53 2024]
Finished job 12.
3 of 35 steps (9%) done
Select jobs to execute...

[Fri Dec 20 11:09:53 2024]
rule pychop:
    input: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/custom_primers.fasta, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/config_primers.txt
    output: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/output/normal/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/reports/normal/barcode01_A_R1.pdf, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/rescued/normal/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1_length_out.fastq
    jobid: 11
    reason: Missing output files: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/output/normal/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1.fastq; Input files updated by another job: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/custom_primers.fasta, /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/config_primers.txt
    wildcards: sample=barcode01, unit=A
    threads: 40

                pychopper -m edlib -b /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/custom_primers.fasta -Q 0 -z 600 -l /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1_length_out.fastq -c /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/config_primers.txt -r /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/reports/normal/barcode01_A_R1.pdf -u /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1.fastq -w /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/rescued/normal/barcode01_A_R1.fastq -t 40 /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/output/normal/barcode01_A_R1.fastq;

Activating conda environment: /mnt/ebe/Natrix2/.snakemake/conda/42e83c31
Using kit: PCS109
Configurations to consider: "+:SSP,-VNP|-:VNP,-SSP"
WARNING: No reverse complement for Y found, returning argument.WARNING: No reverse complement for Y found, returning argument.WARNING: No reverse complement for W found, returning argument.WARNING: No reverse complement for H found, returning argument.WARNING: No reverse complement for R found, returning argument.WARNING: No reverse complement for V found, returning argument.WARNING: No reverse complement for R found, returning argument.WARNING: No reverse complement for V found, returning argument.WARNING: No reverse complement for W found, returning argument.Counting fastq records in input file: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq
Total fastq records in input file: 75770
Tuning the cutoff parameter (q) on 10060 sampled reads (13.2%) passing quality filters (Q >= 0.0).
Optimizing over 30 cutoff values.

and here is my config .yaml for the filtering part
#Quality check and primer removal for Nanopore
nanopore:
        quality_filt: 0 # Minimum Phred quality score.
        min_length: 600 # Minimum length of reads.
        max_length: 900 # Maximum length of reads.
        head_trim: 0 # Trim N nucleotides from the start of reads.
        tail_trim: 0 # Trim N nucleotides from the end of reads.
        pychopper: TRUE # Boolean that indicates if pychopper should be used for reorientation, trimming and quality check of reads, if not done before.
        pychopqual: 0 #Minimum mean Q-score base quality for pychopper (default 7).
        racon : 3

thanks a lot for you help
cheers

Hi @smartise,
Thank you for your positive feedback on our pipeline! The issue might be related to the primer sequences, particularly with the pychopper/custom_primers.fasta file. It would be great if you could share this file for review.

Verify Primer Sequences
Check the primer sequences in pychopper/custom_primers.fasta and ensure they match the ones used in the experiment. The warning messages (e.g., No reverse complement for Y found) suggest that ambiguous IUPAC codes (like Y, W, etc.) might cause issues.

Check Filtered Files
Confirm that the quality_filtering/*.fastq files were successfully created and contain the expected reads, as they are used as input for PyChopper. Faulty input files are a common source of errors, so this step is critical.

Try with Test Data
Run the pipeline with test data or a smaller dataset to check if the issue is related to your configuration or the input data.

Let me know if you need further assistance or have any files or logs to share.
Wishing you happy holidays!
Best regards,
dustin

Hello, thanks for your reply and happy holiday.
for the sequence I have fixed the problem.
it seems that pychopper doesn't handle mutated nucleotide. I removed the mutated nucleotide and replaced it with "N" and don't have the error anymore.
I also updated Natrix to the dev version.
However the problem seems to persist
                pychopper -m edlib -b /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/custom_primers.fasta -Q 0 -z 500 -l /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1_length_out.fastq -c /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/config_primers.txt -r /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/reports/normal/barcode01_A_R1.pdf -u /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/unclassified/normal/barcode01_A_R1.fastq -w /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/rescued/normal/barcode01_A_R1.fastq -t 20 /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/pychopper/output/normal/barcode01_A_R1.fastq;

Activating conda environment: /srv/home/ocol0007/Natrix2/.snakemake/conda/ff8784ed
Using kit: PCS109
Configurations to consider: "+:SSP,-VNP|-:VNP,-SSP"
Counting fastq records in input file: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq
Total fastq records in input file: 66044
Tuning the cutoff parameter (q) on 9811 sampled reads (15.1%) passing quality filters (Q >= 0.0).
Optimizing over 30 cutoff values.
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 30/30 [01:15<00:00,  2.76s/it]
Best cutoff (q) value is 0.4828 with 88% of the reads classified.
Processing the whole dataset using a batch size of 3302:
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 66044/66044 [00:20<00:00, 3212.33it/s]
Finished processing file: /mnt/ebe/AmpliconSequencingONT/sard2_eDNA_natrix_CO1_test/results/quality_filtering/barcode01_A_R1.fastq
Input reads failing mean quality filter (Q < 0.0): 0 (0.00%)
Output fragments failing length filter (length < 500): 164

the quality filter still removes a big part of my sequence based on Q = 0.
I have tried to change the quality sequence filter but it doesn't change anything. even at Q = 15, it remove the same amount of sequence.
I haven't tried with the test data but I will.
Thanks and happy holiday  !

Hi @smartise,
Thank you for the update, and I’m glad to hear that you were able to resolve the issue with the mutated nucleotide.
Exactly! Start by testing your workflow with a known working dataset. This will help determine whether the issue is specific to your data or related to the configuration.
Another important step is to review the report generated by Pychopper. It often contains detailed information about primer matching and sequence classification. These insights could highlight patterns in rejected sequences and explain the filtering behavior.
It’s also possible that specific length settings used by Pychopper are affecting your data. Reviewing these could help identify if sequences are being filtered based on their length.
Additionally, I recommend running the Pychopper step manually with your data. This might provide further insights into the root cause of the issue.
If you have any further questions, please don’t hesitate to reach out to us. Wishing you a great start into the new year!
Best regards,
dustin


rebase: update dependencies in go.mod

Update all dependencies to the latest version in go.mod
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>This should update all dependencies in one go. we can drop other PR's if this is merged.

ci is failing @Madhu-1
https://github.com/csi-addons/kubernetes-csi-addons/runs/8085522382?check_suite_focus=true
This needs make manifests to be run
and i guess we need to update golang to 1.19
for other tests
https://github.com/csi-addons/kubernetes-csi-addons/blob/81fc0027358df61bc0b0b708cb76bf1f4984178a/.github/workflows/test-build.yaml#L20

ci is failing @Madhu-1 https://github.com/csi-addons/kubernetes-csi-addons/runs/8085522382?check_suite_focus=true This needs make manifests to be run
and i guess we need to update golang to 1.19 for other tests
https://github.com/csi-addons/kubernetes-csi-addons/blob/81fc0027358df61bc0b0b708cb76bf1f4984178a/.github/workflows/test-build.yaml#L20

golang 1.18 should be enough, updating 1.19 can create build problems in the forked repo's as 1.19 is the latest and everyone will not switch early. CI should be gree now


Proposal: Print output in pager

I have found it very convenient to print the output of cheat in a less-like pager enabling me to have longer cheats without  having to fill my terminal with long outputs. It also enables me to use the pager to search through the cheat-sheet more easily.
In my local installation to achieve that, in the utils.py file I added the import of pydoc
and in the colorise method I commented out return highlight(sheet_content, lexer, TerminalFormatter()) and then added pydoc.pager(highlight(sheet_content, lexer, TerminalFormatter()))

Going to close this one for now. Feel free to re-open it if there's more to discuss.


[Backtracing] Disable for the minimal preset.

Disable backtracing for the minimal preset.
rdar://106459980

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@swift-ci Please smoke test

@swift-ci Please smoke test

Ah, mentioning PRs on the same repo doesn't work. That's why.

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

OK. The remaining failure is not to do with this.

Can we merge this?
I would like to test https://github.com/apple/swift/pull/64252 with the minimal config


Create BackSlash functions (BSlash)

I wrote cleanFileSeparator. It replaces any / and \ by the file.separator.


Rust lexer chokes on #idents inside quote! macro

(Original issue 1357 created by None on 2017-06-18T14:22:25.731309+00:00)
Inside quote!( ... ) or quote!{ ... }, identifiers following an octothorpe (e.g. #my_var) should be highlighted.
Instead, it currently errors.
Examples:
let foo = "bar";
let bar = quote!(#foo);

Ok(quote! {
    let foo = #foo;
})

Reproduced 2021-03-05

Thanks!


manifest: Merge upstream changes from LineageOS

Give some life to Marshmallow users. :)

Everything is tested and working perfectly.
Vendor pull reuqest: https://github.com/ResurrectionRemix/android_vendor_resurrection/pull/74
frameworks/base: https://github.com/ResurrectionRemix/android_frameworks_base/pull/178
android_build: https://github.com/ResurrectionRemix/android_build/pull/25
Other repos are forked and I can't pull request to them so need some help to update them.
LockClock: https://github.com/HridayHS/android_packages_apps_LockClock/tree/marshmallow
PackageInstaller: https://github.com/HridayHS/android_packages_apps_PackageInstaller
ThemeManagerService: https://github.com/HridayHS/android_packages_services_ThemeManagerService
cm_platform_sdk: https://github.com/HridayHS/cm_platform_sdk/tree/marshmallow
system_core: https://github.com/HridayHS/system_core/tree/marshmallow
Telephony: https://github.com/HridayHS/android_packages_services_Telephony/tree/marshmallow
Telecomm: https://github.com/HridayHS/android_packages_services_Telecomm/tree/marshmallow
SetupWizard: https://github.com/HridayHS/android_packages_apps_SetupWizard
Messaging: https://github.com/HridayHS/android_packages_apps_Messaging/tree/marshmallow
InCallUI: https://github.com/HridayHS/android_packages_apps_InCallUI
CMFileManager: https://github.com/HridayHS/packages_apps_CMFileManager

link your repositories to rr m manifast  do pull request

if all working without issues

Ok

+1 @westcripp
merge those commits
it worked with me good from yesterday and stable till now
nice info to share bro @HridayHS

@GMCadiom they will have to make a pull request first .we can only merge them of that happens

@varund7726
so if i made it can u merge it to make the source alive again ??

Yes

Everything fine now. RR-MM live again. <3


RxJS error

I keep getting ERROR TypeError: __WEBPACK_IMPORTED_MODULE_5_rxjs_Observable__.Observable.fromEvent is not a function     at new ImageLoader
Seems it has to be with the latest rxjs update. Can you please look into it?

same issue happened to me as well

Any news?

Hi everyone,
I have the same error since i use @ionic-native 4.9.0. If i install old version 4.7.0, no more error.

Thank you!
You Are the BEST !!!
On 9 July 2018 at 17:57, Fred<EMAIL_ADDRESS>wrote:

Hi everyone,
I have the same error since i use @ionic-native 4.9.0. If i install old
version 4.7.0, no more error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zyra/ionic-image-loader/issues/166#issuecomment-403508461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXTEJ2VaX1OnY4S4eUCULlbRtHyH75Nfks5uE29kgaJpZM4U7ft8
.

--
Dan Dushinsky
CEO
Shtibel.com LTD
Office: +972-39196070
Mobile: +972-546761333
Email<EMAIL_ADDRESS>Site: www.shtibel.com

Issue solved thank you @fbrun  and @l1nknyto

it is still open. Please Provide a fix.
Same error on Angular 6

I still have this issue, despite being on 4.12.2 of ionic-native/core and rxjs 6.3.2. Import fromEvent (import { fromEvent } from 'rxjs' for v6+ (older syntax as mentioned above does not work either)) before Loader doesn't seem to fix it as mentioned either. Is there any update? Thanks

Posted an temporary workaround here:
https://github.com/zyra/ionic-image-loader/issues/178#issuecomment-419142139
While the fix is not sent to repository

closed with #180

here's workaround for this problem,
import rxjs/fromEvent before ionic-image-loader
import 'rxjs/add/observable/fromEvent';
import { IonicImageLoader } from 'ionic-image-loader';

Worked like a charm!! Thanks!!!!


Change license to match libpg_query

Hi @tdbgamer - thanks for creating these FFI bindings!
I was curious if you would be open to change the license to a BSD-type license, like pg_query has it (https://github.com/lfittl/libpg_query/blob/10-latest/LICENSE).
Whilst the Mozilla Public License is generally a great license, it has a few more restrictions that can make it complicated to use in certain situations, and it would be helpful if projects using the "pg_query" name match the license of the main project.

This is done in 0.1.3.


code.google.com is shutting down so update the dep

ping @tianon

Or review #16032 :)

the diff is so completely different idk

maybe we should just use something else :/

Yeah, that's why I suggested we should consider/test mattn's go-sqlite3
that we're already importing. :+1:

ooo yeah i will pop it out i didnt know if there is a reson we werent using it already

There was, but it's been shown to work successfully for packaging needs, so
I'm +1. :+1:

cool! updated!

it works!

omg @LK4D4 will be excited we only have 1 sqlite package now :confetti_ball:

LGTM

LGTM

There's a warning when running make binary.
---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev
# github.com/docker/docker/docker
/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

It's fixed in another pr
On Sat, Sep 5, 2015 at 9:07 PM -0700, "Shijiang Wei"<EMAIL_ADDRESS>wrote:
There's a warning when running make binary.
---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev
github.com/docker/docker/docker
/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
—
Reply to this email directly or view it on GitHub.

It is just a warning tho we do not use dlopen
On Sat, Sep 5, 2015 at 9:07 PM -0700, "Shijiang Wei"<EMAIL_ADDRESS>wrote:
There's a warning when running make binary.
---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev
github.com/docker/docker/docker
/var/tmp/go-link-pJY0ZF/000006.o: In function `unixDlOpen':
/go/src/github.com/docker/docker/vendor/src/github.com/mattn/go-sqlite3/code/sqlite3-binding.c:29925: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
—
Reply to this email directly or view it on GitHub.

I see. It's #16094
Thanks.


Capture file size in the database

Add fields to the surface the size of the downloadable asset:

[ ] Annotations (.ndjson, .mrc, .zarr)
[ ] Tomograms (.mrc, .zarr)
[ ] Tiltseries (.mrc, .zarr)
[ ] Frames (cumulative size)
[ ] Dataset (complete dataset)

Tasks:

[ ] Update db schema
[ ] Update import scripts
[ ] Run import scripts for all datasets
[ ] Update client
[ ] Update documentation

@manasaV3 i think this needs to go back to the priority backlog right?


Projections in posterior space

Codecov Report

Merging #321 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   73.30%   73.30%
=======================================
  Files          46       46
  Lines        2529     2529
=======================================
  Hits         1854     1854
  Misses        675      675

Flag
Coverage Δ

#unittests
73.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e70db...23ab84f. Read the comment docs.

@jan-matthis @janfb @meteore @ppjgoncalves
This is ready for review now. It does not yet contain the projections, I will move that to another PR. Instead, this only implements the conditional correlations we also used in the big paper. It's quite a lot, so I don't think you all have to review it, but if one of you could have a look, that would be great :) Thanks!

@ppjgoncalves and I just reviewed the tutorial notebook. No need to proof-read that notebook anymore.

17,320 lines added :D guess animations in jupyter notebooks add quite something here :D


HIVE-23256: Fix flaky test TestMiniLlapLocalCliDriver[schema_evol_par…

…_vec_table_dictionary_encoding.q]
HIVE-23256
Why are the changes needed?
Enable test
Does this PR introduce any user-facing change?
No
How was this patch tested?
qtest

Please find the flaky job result here:
http://ci.hive.apache.org/job/hive-flaky-check/662/

LGTM

Will try to check more details on this, thanks

Well I wasn’t convinced with going forward on this and seems it got merged.
Reverting so that it doesn’t become a practice for come commit and go without looking at other people comments

Sorry I missed your comment, only checked that the missing build part which I started yesterday was green.

hmm, no worries. @mayankkunwar can you still figure out the reason for the failure, why the data was same. If we figure that out and it is fixed, we can let this stay as is

This test is still flaky, and is failing here: #4433 Test with the error shared by @ayushtkn.
@ayushtkn can you please revert this, until the root cause is identified this can continue to be disabled IMO


Reference pages: routes and plugins; reference layout

Split out routes and plugins info into separate reference pages; create a placeholder reference layout (generic reference layout? vs a specific "entity reference" or something.)

@lena-larionova I can update the _kong_entities collection url to be gateway/entities/:name/, should we also rename the folder to app/_gateway_entities?

Should these pages live under /gateway/entities/routes/ ?

/gateway/entities/routes/expressions/
/gateway/entities/routes/routing/

They are related to the kong entity route, but I don't know if they should be nested that deep, what about

/gateway/routing/
/gateway/routing/expressions/

Unrelated to the above, but would you consider these pages to be "reference pages" or "concept pages"?


Malformed feed title can break rendering

Newsbeuter version (copy from newsbeuter -v): newsbeuter 2.10-a3a7
Steps to reproduce the issue:

add http://www.aerialmantis.co.uk/feed.xml which title is Gordon Brown on
C++, Gamedev, Heterogeneous Computing

go back to the feed list

rendering is broken by

Probably related: #554.
Thank you for the report, @gpakosz!


Scrollable Tabs with SlideBox

Is there any way to do this ? I'm talking about the scrollable tabs that mobile apps like Youtube have.
Here's an image if you're not sure what I'm talking about ..
http://material-design.storage.googleapis.com/publish/material_v_4/material_ext_publish/0B6Okdz75tqQsY1JuWnJGSHpiQkE/components-tabs-typesoftabs_scrollable_tabs_01_xhdpi_003.webm

+1


Let users choose if they want top pagination to always show, even on small entries

Adds a new column to users table, show_short_pagination
Adds a new settings form item,form.prefs.label.show_short_pagination:

If the user enables that option, this block is always skipped, top pagination controls are always shown:

[ ] I have only added the i18n key for English. Unit tests fail because of this. Are there translators available? Are online translation services an acceptable alternative?
[ ] Is this something acceptable to merge upstream? If not, I can maintain it in my fork. I like it so a Next link is always available in one spot.

Just realized pressing the n key is probably easiest... :sweat_smile:


Receive bufferSize should be configurable

goexpect fails when the client expects payloads larger than the default buffer size.
A dynamically growing byte slice will not work in this instance, due to the fact that the PTY File is not closed after receiving command output (i.e., does not receive io.EOF).  As such, something like ioutil.ReadAll(...) cannot be used in this context, and will eventually just timeout waiting for io.EOF or an error.
Support should be added to at least make bufferSize configurable, preferably per GExpect instance.

Resolved by #65


.ipynb support

Editing .ipynb doesn't show in Discord rich presence. It only states "Not in a file!"

#120


Implement Authentication via an HTTP Header

Fixes #79.
This PR introduced a new authentication method using HTTP Headers.
As we now have 2 different method to authenticate, the constructer of GitlabAPI includes another parameter AuthMethod which is a simple enum.
TokenType was extended with information needed for authentication like Header name and Header format.
The authentication was moved from GitlabAPI to GitlabHTTPRequestor.
Authentication information is passed using a fluent interface:
return new GitlabHTTPRequestor(this).authenticate(apiToken, tokenType, authMethod).method("POST");
Tested both using private tokens and access token.
The PR includes only minor compatibility changes:

getAPIUrl doesn't return the private token anymore.
Exceptions thrown doesn't include the private token anymore.

This PR sets the HEADER Authentication method as the default.
I think it is beneficial for everyone to hide the token from the request url, which is easily exposed.

This PR is not ready yet. Working on some adjustements.

This PR is ready to be merged.

Thanks @wikiwi! Looks good. Would you mind fixing up the whitespace and formatting issues?

I fixed your outlined formatting issues except the issues in TokenType.java. The file contains tabs instead of spaces. I suggest a follow up PR which reformats every file. I can do that. I'd use the integrated IDEA formatter.

Ah ok, no problem. I'll take care of the formatting issues.


loadFactor parameter overlooked

I noticed that you amended the code to set the loadfactor to the field
https://github.com/Wsm2110/Faster.Map/blob/1de97cb368aad2cdbc1acb9f3f10edbf231588f0/src/DenseMapSIMD.cs#L180-L183
however this line still uses the parameter and not the field
https://github.com/Wsm2110/Faster.Map/blob/1de97cb368aad2cdbc1acb9f3f10edbf231588f0/src/DenseMapSIMD.cs#L194
Thanks for getting time to fix it

silly mistake, fixed


Undoing the uppercasing

Apparently, these lines need to be lowercased. based on https://github.com/newrelic/infra-identity-client-go/pull/5#pullrequestreview-473223462

Hello! I changed line in yours PR, it was for api endpoint, not for documentation. Will close this PR. Thank you!


Returns 404 if attempt to toggle on the mem or syn

error: INFO:     <IP_ADDRESS>:45022 - "POST /v1/insight/neuron/synaptic_potential HTTP/1.1" 404 Not Found

INFO:     <IP_ADDRESS>:48724 - "POST /v1/insight/neurons/membrane_potential_set?state=true HTTP/1.1" 400 Bad Request
Using fix-clone branch atm.
Seems like It's still an issue.

Fixed


Upgrade CF-deployer to 1.3.1

Addressed in https://github.com/spring-cloud/spring-cloud-dataflow-server-cloudfoundry/commit/7df78ec5eee01bcbf45202aa34c42b0aa8dbed9b.


Pixelate Filter is Busted

If you see the demos, the PixelateFilter doesn't appear to be operating correctly. Shows up as a solid block instead of pixelated image. http://pixijs.github.io/pixi-filters/examples/

Hi!
I'd love to use your pixelate filter for PIXI, but it doesn't work. Either it shows a solid block - or maybe it displaces the element out of view? I can't tell if it is one or the other. It doesn't give the pixelate effect anyhow.
Do you have any fix ready or would you be able to help us fix it?
Martin

does anyone have a fix for the pixelate filter? really want to use this in a project.

i modified the Ascii filter to fix this.. you can replace the filter in filter.js with this as a quick hack
`function PixelateFilter()
{
PIXI.Filter.call(this,
// vertex shader
"#define GLSLIFY 1\nattribute vec2 aVertexPosition;\nattribute vec2 aTextureCoord;\n\nuniform mat3 projectionMatrix;\n\nvarying vec2 vTextureCoord;\n\nvoid main(void)\n{\n    gl_Position = vec4((projectionMatrix * vec3(aVertexPosition, 1.0)).xy, 0.0, 1.0);\n    vTextureCoord = aTextureCoord;\n}",
// fragment shader
"#define GLSLIFY 1\nvarying vec2 vTextureCoord;\n\nuniform vec4 filterArea;\nuniform float pixelSize;\nuniform sampler2D uSampler;\n\nvec2 mapCoord( vec2 coord )\n{\n    coord = filterArea.xy;\n    coord += filterArea.zw;\n\n    return coord;\n}\n\nvec2 unmapCoord( vec2 coord )\n{\n    coord -= filterArea.zw;\n    coord /= filterArea.xy;\n\n    return coord;\n}\n\nvec2 pixelate(vec2 coord, vec2 size)\n{\n    return floor( coord / size ) * size;\n}\n\nvec2 getMod(vec2 coord, vec2 size)\n{\n    return mod( coord , size) / size;\n}\n\nfloat character(float n, vec2 p)\n{\n    p = floor(pvec2(4.0, -4.0) + 2.5);\n    if (clamp(p.x, 0.0, 4.0) == p.x && clamp(p.y, 0.0, 4.0) == p.y)\n    {\n        if (int(mod(n/exp2(p.x + 5.0*p.y), 2.0)) == 1) return 1.0;\n    }\n    return 0.0;\n}\n\nvoid main()\n{\n    vec2 coord = mapCoord(vTextureCoord);\n\n    // get the rounded color..\n    vec2 pixCoord = pixelate(coord, vec2(pixelSize));\n    pixCoord = unmapCoord(pixCoord);\n\n    vec4 color = texture2D(uSampler, pixCoord);\n\n    // determine the character to use\n    float gray = (color.r + color.g + color.b) / 3.0;\n\n    float n =  65536.0;             // .\n    if (gray > 0.2) n = 65600.0;    // :\n    if (gray > 0.3) n = 332772.0;   // *\n    if (gray > 0.4) n = 15255086.0; // o\n    if (gray > 0.5) n = 23385164.0; // &\n    if (gray > 0.6) n = 15252014.0; // 8\n    if (gray > 0.7) n = 13199452.0; // @\n    if (gray > 0.8) n = 11512810.0; // #\n\n    // get the mod..\n    vec2 modd = getMod(coord, vec2(pixelSize));\n\n    gl_FragColor = color;\n\n}"
);
this.pixelSize = 4;
}
PixelateFilter.prototype = Object.create(PIXI.Filter.prototype);
PixelateFilter.prototype.constructor = PixelateFilter;
module.exports = PixelateFilter;
Object.defineProperties(PixelateFilter.prototype, {
/**
* This a point that describes the size of the blocks.
* x is the width of the block and y is the height.
*
* @member {PIXI.Point}
* @memberof PIXI.filters.PixelateFilter#
*/
pixelSize: {
get: function ()
{
return this.uniforms.pixelSize;
},
set: function (value)
{
this.uniforms.pixelSize = value;
}
}
});
},{}],9:[function(require,module,exports){`

@jeff-gold-marblemedia , you sir, are awesome. Thank you for the quick fix on the pixelate filter

@jeff-gold-marblemedia would welcome a Pull request if you could put something together.

hi maintainers, see #23 if this is something that you still want – hope to learn more about webGL and shaders in the near future.


Non workink link

Non workink link from https://evcc.io/en/ to https://docs.evcc.io/en/docs/devices/chargers/.

@petrsykora Is fixed. Thanks for reporting 🙌


Error requesting networks

I have been running 0.15 for over a week now and no issues, but yesterday it started to error on self.get_networks()
Traceback (most recent call last):
  File "scripts/grab-photo.py", line 9, in <module>
    blink.start()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 135, in start
    self.get_auth_token()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 176, in get_auth_token
    self.setup_params(self.login_response)
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 189, in setup_params
    self.networks = self.get_networks()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 195, in get_networks
    response = api.request_networks(self)
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/api.py", line 82, in request_networks
    return http_get(blink, url)
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/api.py", line 301, in http_get
    is_retry=is_retry,
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/helpers/util.py", line 104, in http_req
    if json_resp and "code" in response.json():
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/local/python3/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/local/python3/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/python3/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I thought it might be the version, so I updated to the latest dev build.  I had to enter in a new code but now i'm still getting a similar error:
Expected json response from https://rest-u003.immedia-semi.com/api/v3/accounts/XXXXX/homescreen, but received: 403: Forbidden
Enter code sent to<EMAIL_ADDRESS>XXXXXX
Traceback (most recent call last):
  File "scripts/grab-photo2.py", line 13, in <module>
    blink.start()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 114, in start
    self.setup_prompt_2fa()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/blinkpy.py", line 121, in setup_prompt_2fa
    result = self.auth.send_auth_key(self, pin)
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/blinkpy/auth.py", line 207, in send_auth_key
    json_resp = response.json()
  File "/var/services/homes/admin/.local/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/local/python3/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/local/python3/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/python3/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I think the API has been disabled / changed. I also get a 403 forbidden with another blink video download script. Everything was working fine until yesterday aftenoon

I'm getting the same traceback.
On further investigation I've found that POSTing to https://rest-prod.immedia-semi.com/api/v4/login is resulting in a an HTTP 404 error.

https://github.com/madshall/node-blink-security/issues/52
there are some comments in the nodejs version about errors.  mine stopped working yesterday at 5:17pm est.

The end points have moved from rest.___ to rest-____.
I was able to fix the nodejs version I am running in the above link.

so the code already connects to:
https://rest-prod.immedia-semi.com/api/v3/login
to log in and then when it calls those:
str: https://rest-u020.immedia-semi.com/networks
it gets back JSONDecodeError: Expecting value: line 1 column 1 (char 0)

yeah, the log in one is the only one that looks like it works to me.

My earlier debugging was off (it was late) - https://rest-prod.immedia-semi.com/api/v4/login is giving a 404, but https://rest-prod.immedia-semi.com/api/v3/login is giving a 200.
Once login has worked, GETting https://rest-prde.immedia-semi.com/networks is returning a 403.

ah. i apologize, looks like the nodejs api handler was using the old end points... which worked fine until yesterday.
perhaps a coincidence but its strange that on the same day the rest.___ end points stop working this python handler starts having issues...
regardless, using the nodejs version everything is working fine for me.

@anonymous-one that change happened almost a year ago. This library has been using that updated endpoint since then. The only endpoint currently working is login (at least based on my testing).

I was following @anonymous-one in the node-js api thread and he has found a fix!

Remove / comment out all instances of "Host: ..." for each of the request.post blocks.

I was able to do this in the dev build by editing auth.py:
Change Line 56 from:
        return {"Host": self.host, "TOKEN_AUTH": self.token}
to:
        return {"TOKEN_AUTH": self.token}
and it worked!!
I can submit a PR later tonight but need to get back to stuff I promised my wife would get done :)

I've just made the same change locally and it seems to be working. Thanks.

thanks for that info tsolid. I have also applied a fixed pull request to nayrk/Blink to fix the powershell version.


adding passthrough for custom pages inputs metadata file

this pr adds ability to copy file containing schma definitions for custom pages that are used by the app - this needs to be passed through for the app that uses Navigate function to navigate to other custom pages.

@milantomic6, can you add some details & an MSApp to repro the issue you are fixing? Also, can you add unit tests as a part of this PR?

Looks good, validated by testing against the battery and test apps. Passes all.


[design] Create "README button" to include in open source projects

Summary
Create a pretty "README button" that anyone can take and insert into their project README to ask people to write them a Happiness Packet
Background
I saw this implemented on the pipenv docs page first, but you can see another example in the saythanks.io README. The button does two things:

Encourages someone who enjoys an open source project to say thanks to the maintainer
Improves visibility and awareness of Happiness Packets by letting maintainers add a button to their README

The button becomes 2x more convenient if #39 is implemented, but #39 is not required for this to be useful.
Details
The button should follow the aesthetic design of other GitHub-style READMEs, so it would "fit in" with other buttons a project may already be using. I'm not sure if there any resources that standardize this design though.
Outcome
Project maintainers add Happiness Packets button to their READMEs, more people write Happiness Packets to awesome people, and more people learn about Happiness Packets!

I like it! I think we should really do #39 first though, to set the recipient automatically.

@mxsasha From my POV, this isn't blocked by #39, since I would envision it as a button with a link. A project maintainer could always later edit the link with pre-filled fields if support is implemented. I know I'd like to add a button to a few READMEs already today, and give a specific project email to list along with it.
I filed this separate because I wasn't sure if you would need longer time to get a design asset created or to work with the project designer or not. Either way, I thought it would be a cool way to build awareness of Happiness Packets. :slightly_smiling_face:


Activity Class Tests

We need better tests around Activities in general.

@cccyyyr whats the status on this


[Bug] XSS Vulnerability in /admin/users

Is this a support request?

[X] This is not a support request

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
There is a Cross-Site Scripting (XSS) vulnerability in the localhost.lugvitc.net/admin/users page. The application is not properly sanitizing user input, which allows attackers to inject arbitrary JavaScript into the page and execute it within the context of other users' browsers.
Expected Behavior
The input fields should properly sanitize all user input, especially special characters such as <, >, " and '. The application should escape any potentially malicious content to prevent script execution.
Steps To Reproduce

Navigate to the localhost.lugvitc.net/admin/users page.
In the input field (e.g., name or other parameters), input the following XSS payload:

Submit the form and observe that the alert XSS by amreal.in is triggered, indicating that the payload is executed.
This shows that the application is vulnerable to XSS and does not sanitize the input.

Environment
- OS: ubuntu
- Headscale version:  Headscale-Admin v0.1.12b
- Tailscale version:

Runtime environment

[X] Headscale is behind a (reverse) proxy
[X] Headscale runs in a container

Anything else?
No response

The vulnerability arises from
https://github.com/GoodiesHQ/headscale-admin/blob/main/src%2Flib%2Fcards%2FCardListPage.svelte#L7
Not headscale
Besides, this seems like a low severity issue since injection can only be done the user for the user or by the server

@AmrealAbhishek So your frontend clearly shows an error that it was unable to add a user and in the console there is a clear error of fetch execution, so the request did not reach the Headscale server. I agree with @WizzyGeek, it is unlikely that the error is related to headscale.

@hopleus this not the stored XSS, Its a reflected XSS!!

@hopleus this not the stored XSS, Its a reflected XSS!!

I understand, that's why I wrote that the bug is not related to Headscale, as Headscale itself does not contain UI!


Bug in the Uri class

There is a bug in the Uri class that hinders the proper construction of a URL in a specific edge case:
final uri = Uri(
  scheme: 'bankid',
  path: '/',
  queryParameters: {
    'autostarttoken': autostartToken,
    'redirect': encodeURIComponent(redirect),
  },
);

P.S: Not sure if I need to report this here or in the flutter engine ... I am a bit confused.
UPDATE
If I provide an empty host it works properly.
Expected result
bankid:///?autostarttoken=[TOKEN]&redirect=[RETURNURL]

Actual result
bankid:/?autostarttoken=[TOKEN]&redirect=[RETURNURL]

The issue arises as the first two forward slashes are omitted in the final constructed URL. Interestingly, adding more forward slashes does not result in the omission of the initial two slashes for the scheme.
Ref
dart:core lib: https://api.dart.dev/stable/3.2.3/dart-core/Uri-class.html
Dart version
Dart SDK version: 3.1.4 (stable) (Tue Oct 17 14:55:53 2023 +0000) on "macos_arm64"

@lrhn may have more context. I can confirm that this replicates across VM, Dart2JS, and DDC.

That is probably working as intended.
The bankid scheme is not known, so the Uri class doesn't know whether the URI needs an authority part or not (it knows that http needs one, and fx email does not).
So rather than guess, it does what you ask for, which is no authority part, unless you actively pass in some part of it. Like an empty host.
The solution is to pass in an empty host.

Yes that makes sense. I figured it out when I passed an empty host. I was also testing this in different languages and it seems to be the same story. I am closing this now and thanks for your help.


ls4: init at 1.0

Motivation for this change
Adds the ls4 solver.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers

@GrahamcOfBorg build ls4

Please investigate the build failure on ls4 on aarch64-linux .

@mmahut I was overly ambitious packaging this for unix since it requires FPU flags that glibc only has for x86. I've changed the platform.

@mmahut Just wanted to ping again on this; I can't send instructions to the build bot unfortunately.

@GrahamcOfBorg build ls4

@mmahut Argh sorry it looks like on Mac gcc needs to be an explicit dependency whereas this is not the case on Linux. Can you run build ls4 one more time? I don't have a Mac handy to test it unfortunately.

@GrahamcOfBorg build ls4

@GrahamcOfBorg build ls4

@mmahut It looks like everything finally built!

@mmahut Just wanted to ping on this to see if this could be merged.

Fixed up indentation.

@mmahut Let me know if there's anything else you want me to fix up.

@mmahut or @Ekleog it'd be great if either of you could take another look at this

@mmahut Will let you review if you can, as you already looked at the code, but overall it LGTM, with the exception that I wasn't able to easily confirm ls4 actually in general knowledge refers to this github repo -- ls4 does appear to be mentioned from the TLA+ github repo (as identified by the already-in-nixpkgs url), but without any link to this repo.

Yeah it was a bit tricky to ascertain whether this is the "real" ls4. I see the following as evidence for its authenticity:

The repo and username is mentioned in this email on the TLA+ mailing list: http://discuss.tlapl.us/msg01185.html (although everything before .com is filtered out as xs).
The creator of ls4 seems to be Martin Suda, based on http://ktiml.ms.mff.cuni.cz/~suda/ and quickbeam123 is mapped to Martin Suda on GitHub.

Hey @SuperSandro2000, I'd be happy to make those changes if those are what's blocking this PR. Do you think that's all it takes for this PR to get merged?

Hey @SuperSandro2000, I'd be happy to make those changes if those are what's blocking this PR. Do you think that's all it takes for this PR to get merged?

Hey @SuperSandro2000, I'd be happy to make those changes if those are what's blocking this PR. Do you think that's all it takes for this PR to get merged?

Yeah, basically.

Hey @SuperSandro2000, I'd be happy to make those changes if those are what's blocking this PR. Do you think that's all it takes for this PR to get merged?

Yeah, basically.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 65619 run on x86_64-darwin 1

1 package failed to build and are new build failure:

ls4: log https://termbin.com/f1nu

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 65619 run on x86_64-darwin 1

1 package failed to build and are new build failure:

ls4: log https://termbin.com/f1nu

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 65619 run on x86_64-linux 1

1 package failed to build and are new build failure:

ls4: log https://termbin.com/w8q0

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 65619 run on x86_64-linux 1

1 package failed to build and are new build failure:

ls4: log https://termbin.com/w8q0

Fails to build with:
Compiling: /build/source/core/Aiger2Spec.o
In file included from ../core/Aiger2Spec.h:25,
                 from /build/source/core/Aiger2Spec.cc:42:
../core/SolverTypes.h:50:16: error: friend declaration of 'Minisat::Lit mkLit(Minisat::Var, bool)' specifies default arguments and isn't a definition [-fpermissive]
   50 |     friend Lit mkLit(Var var, bool sign = false);
      |                ^~~~~
../core/SolverTypes.h:58:14: error: friend declaration of 'Minisat::Lit Minisat::mkLit(Minisat::Var, bool)' specifies default arguments and isn't the only declaration [-fpermissive]
   58 | inline  Lit  mkLit     (Var var, bool sign) { Lit p; p.x = var + var + (int)sign; return p; }
      |              ^~~~~
../core/SolverTypes.h:50:16: note: previous declaration of 'Minisat::Lit Minisat::mkLit(Minisat::Var, bool)'
   50 |     friend Lit mkLit(Var var, bool sign = false);
      |                ^~~~~
/build/source/core/Aiger2Spec.cc: In function 'void aiger_LoadSpec(const char*, int, int, int, int, int, int, int&, Clauses&, Clauses&, Clauses&, Clauses&)':
/build/source/core/Aiger2Spec.cc:605:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
  605 |     else ; // undefined = no constraint
      |     ^~~~
/build/source/core/Aiger2Spec.cc:608:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
  608 |    if (refs[lit])
      |    ^~
In file included from ../core/Aiger2Spec.h:24,
                 from /build/source/core/Aiger2Spec.cc:42:
../mtl/Vec.h: In instantiation of 'void Minisat::vec<T>::capacity(int) [with T = Minisat::vec<Minisat::Lit>]':
../mtl/Vec.h:128:13:   required from 'void Minisat::vec<T>::growTo(int) [with T = Minisat::vec<Minisat::Lit>]'
../mtl/Vec.h:86:48:   required from 'void Minisat::vec<T>::push(const T&) [with T = Minisat::vec<Minisat::Lit>]'
/build/source/core/Aiger2Spec.cc:135:32:   required from here
../mtl/Vec.h:112:54: warning: 'void* realloc(void*, size_t)' moving an object of non-trivially copyable type 'class Minisat::vec<Minisat::Lit>'; use 'new' and 'delete' instead [-Wclass-memaccess]
  112 |     if (add > INT_MAX - cap || ((data = (T*)::realloc(data, (cap += add) * sizeof(T))) == NULL) && errno == ENOMEM)
      |                                             ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../core/Aiger2Spec.h:24,
                 from /build/source/core/Aiger2Spec.cc:42:
../mtl/Vec.h:44:7: note: 'class Minisat::vec<Minisat::Lit>' declared here
   44 | class vec {
      |       ^~~
make: *** [../mtl/template.mk:72: /build/source/core/Aiger2Spec.o] Error 1

Fails to build with:
Compiling: /build/source/core/Aiger2Spec.o
In file included from ../core/Aiger2Spec.h:25,
                 from /build/source/core/Aiger2Spec.cc:42:
../core/SolverTypes.h:50:16: error: friend declaration of 'Minisat::Lit mkLit(Minisat::Var, bool)' specifies default arguments and isn't a definition [-fpermissive]
   50 |     friend Lit mkLit(Var var, bool sign = false);
      |                ^~~~~
../core/SolverTypes.h:58:14: error: friend declaration of 'Minisat::Lit Minisat::mkLit(Minisat::Var, bool)' specifies default arguments and isn't the only declaration [-fpermissive]
   58 | inline  Lit  mkLit     (Var var, bool sign) { Lit p; p.x = var + var + (int)sign; return p; }
      |              ^~~~~
../core/SolverTypes.h:50:16: note: previous declaration of 'Minisat::Lit Minisat::mkLit(Minisat::Var, bool)'
   50 |     friend Lit mkLit(Var var, bool sign = false);
      |                ^~~~~
/build/source/core/Aiger2Spec.cc: In function 'void aiger_LoadSpec(const char*, int, int, int, int, int, int, int&, Clauses&, Clauses&, Clauses&, Clauses&)':
/build/source/core/Aiger2Spec.cc:605:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
  605 |     else ; // undefined = no constraint
      |     ^~~~
/build/source/core/Aiger2Spec.cc:608:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
  608 |    if (refs[lit])
      |    ^~
In file included from ../core/Aiger2Spec.h:24,
                 from /build/source/core/Aiger2Spec.cc:42:
../mtl/Vec.h: In instantiation of 'void Minisat::vec<T>::capacity(int) [with T = Minisat::vec<Minisat::Lit>]':
../mtl/Vec.h:128:13:   required from 'void Minisat::vec<T>::growTo(int) [with T = Minisat::vec<Minisat::Lit>]'
../mtl/Vec.h:86:48:   required from 'void Minisat::vec<T>::push(const T&) [with T = Minisat::vec<Minisat::Lit>]'
/build/source/core/Aiger2Spec.cc:135:32:   required from here
../mtl/Vec.h:112:54: warning: 'void* realloc(void*, size_t)' moving an object of non-trivially copyable type 'class Minisat::vec<Minisat::Lit>'; use 'new' and 'delete' instead [-Wclass-memaccess]
  112 |     if (add > INT_MAX - cap || ((data = (T*)::realloc(data, (cap += add) * sizeof(T))) == NULL) && errno == ENOMEM)
      |                                             ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../core/Aiger2Spec.h:24,
                 from /build/source/core/Aiger2Spec.cc:42:
../mtl/Vec.h:44:7: note: 'class Minisat::vec<Minisat::Lit>' declared here
   44 | class vec {
      |       ^~~
make: *** [../mtl/template.mk:72: /build/source/core/Aiger2Spec.o] Error 1


version 0.4.23 is not compatible with .NET 4.5

It seems at some point it became required to use .NET 5.0 (https://github.com/Amoenus/PclTimer/commit/d2935a681a9020679ce39452400c10470043c9d6)
I am not even sure this .NET version already exists, but this is an backwards incompatible change, so technically a major version bump was needed (although most projects seem not to care really in the 0.X phase which makes sense).
I also am not sure why this is needed. Can this be reset again to v4.0 as it seems to have been before?

Seems like a great opportunity for a first PR. Haven't touched this one for a while as didn't have time to develop with Xamarin (main purpose why I created a package in the first place)


BLE lost connection and can't reconnect (IDFGH-3966)

Environment

Development Kit:      ESP32-Wrover-Kit
Kit version (for WroverKit/PicoKit/DevKitC): v1
Module or chip used:  ESP32-WROVER-B
IDF version: v4.1-249-g445635fe4 (release/v4.1 branch)
Build System:         [Make|CMake|idf.py]
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2020r2) 8.2.0
Operating System:     Windows
(Windows only) environment type: PowerShell.
Using an IDE: VSCode
Power Supply:         external 3.3V

Problem Description
ESP32 is GATT server. During heavy BLE usage (sending file from IPhone to ESP32) connection sometimes lost (file transfer stoped) and don't appears at scan until reboot (I've tried to scan from Android and IPhone).
...
D (571220) BLE OTA: Input chunk 4714, size=176
D (571300) BLE OTA: Input chunk 4715, size=176
E (573290) BT_L2CAP: L2CAP - CID: 0x0004 cannot send, already congested            xmit_hold_q.count: 21 buff_quota: 20
W (691300) BLE OTA: Update timeout
D (691580) BLE OTA: Sending OTA status: 0x01
I (712350) WB_GATTS: ESP_GATTS_DISCONNECT_EVT, disconnect reason 0x13

Expected Behavior
Don't drop connection, or, at least to be available for reconnect.
Actual Behavior
Can't reconnect until reboot

This happens when bluetooth controller and bluedroid modules where on different cores during spi slave heavy load (which is on core 1). Moving both bluetooth modules to Core 0 solved this problem.


When a proposal gets emptied from votes it renders it without data.

If all votes get removed on a proposal, it's rendered without data and looks wrong.

Hey @santisiri are you refering to this behaviour ?

No, to something different that it's just a CSS snafu.


Add regex to support ECR as OCI Helm registry

This change adds a new regex to parse AWS ECR OCI URLs when to allow URLs that point to the root of an AWS account's ECR registry, instead of forcing all repositories to contain a "/" character.
When accepted this will resolve https://github.com/fluxcd/source-controller/issues/905.
I've verified this change resolves the issue by rebuilding the source-controller image and deploying it to a Kubernetes cluster and verifying it can properly authenticate and pull from AWS ECR when given a URL like oci://<account>.dkr.ecr.<region>.amazonaws.com in a HelmRepository object.

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1203048932854531

This fix did not work on our end, for the record, after https://github.com/bnsfrt/fluxcd-pkg/commit/f7c66eb06aa7810e03f106131306574d192314c3. Still unable to pull Helm charts from root ECR repo.

@austinorth can you provide some more information? Error string, registry address, etc. Because this change also updates the test case for the code that was causing the failure for the initially reported issue.
A new issue with all the necessary details about what you tried, what you observed, version of flux controllers, etc would also be very helpful.

@austinorth @darkowlzz
We are in the same boat: Cannot pull from private ECR repositories for helm charts.

@cep21 you seem to have a different issue in https://github.com/fluxcd/source-controller/issues/951 . This fix was for invalid chart reference, which you did had initially in your issue. But now, you've authentication issue, which is not related to this PR.
You may have to follow the registry login IRSA setup instructions for using service account https://fluxcd.io/flux/components/source/ocirepositories/#aws . And also restart source-controller after that to ensure it's using the new token.

@darkowlzz I added opened #429 to add context that @austinorth  is pointing out.


Question about usage.

Is there support for parsing a query, rewriting values in the AST, and generating an OData query string again?

No yet, but that does sound like a cool use case!

Happy to say this was implemented in #27 and will be released in v0.7.0.
This release is ready to be published, but PyPI is currently in maintenance mode.
It works as follows:
from odata_query.roundtrip import AstToODataVisitor

transformer = AstToODataVisitor()
odata_string = transformer.visit(ast)

Example test cases can be found here:
https://github.com/gorilla-co/odata-query/blob/master/tests/integration/test_roundtrip.py
Thank you for this cool feature request!


Missing fonts with luahblatex

Description
TeXLive makes it possible to test the forthcoming version by invoking -dev versions of the latex engines.  For instance, in place of lualatex one can run lualatex-dev. The latter relies on luahbtex (Version 1.11.2) and the forthcoming version of the latex2e format (now  LaTeX2e <2020-02-01> pre-release-3 (develop 2020-1-14 branch) ). Conversely, lualatex gets you luatex (Version 1.10.0) and the current stable version of the latex2e format (LaTeX2e <2019-10-01> patch level 3).
The unicode-math package triggers font substitution warnings with the -dev combination. For instance:
LaTeX Font Warning: Font shape `TU/XITSMath(1)/m/up' undefined
(Font)              using `TU/XITSMath(1)/m/n' instead on input line 21.

LaTeX Font Warning: Font shape `TU/XITSMath(2)/m/up' undefined
(Font)              using `TU/XITSMath(2)/m/n' instead on input line 21.

LaTeX Font Warning: Font shape `TU/XITSMath(3)/m/up' undefined
(Font)              using `TU/XITSMath(3)/m/n' instead on input line 21.

and
 LaTeX Font Warning: Font shape `TU/SourceSansPro(1)/m/up' undefined
(Font)              using `TU/SourceSansPro(1)/m/n' instead on input line 62.

LaTeX Font Warning: Font shape `TU/SourceCodePro(1)/m/up' undefined
(Font)              using `TU/SourceCodePro(1)/m/n' instead on input line 62.

(./testo.incl.tex

LaTeX Font Warning: Font shape `TU/SourceSerifPro(1)/m/up' undefined
(Font)              using `TU/SourceSerifPro(1)/m/n' instead on input line 18.

The warnings appear to be always related to seeking up fonts, not finding them and substituting n fonts for them.
It is unclear to me whether the problem is in unicode-math being in need to catch up with newer engines/formats or real problems in the latex format or in luahblatex.
Add info or delete as appropriate:

Relevant for LuaTeX
Issue tracker has been searched for similar issues? Yes

Minimal example demonstrating the issue
The preconfigured test document is actually sufficient to show the issue, no need to invent anything new ;-) :
\documentclass{article}
\usepackage{unicode-math}
\setmathfont{texgyrepagella-math.otf}% filename only please!
\begin{document}
\[
  a = b
\]
\end{document}

looks like Will overlooked that he also has to adjust unicode-math: that is still using \updefault to set up the symbol fonts, but should use either explisitly "n" or \shapedefault.
It should be harmless, but, if you want to avoid the warning messages during testing, tryin
\let\updefault\shapedefault
\setmathfont{texgyrepagella-math.otf}% filename only please!
\def\updefault{up}

The trick works! Looks like I need to use the \let\updefault\shapedefault before setting the main, mono and sans font, otherwise I get the warning with those fonts too.
Thanks!

If you get the warnings with text fonts too, it could indicated that your fontspec version is not up-to-date.

Should be since I have run tlmgr update --all as of today. Interestingly, the warning with the text fonts appear to only occur if I load unicode-math. I'll try to test more as soon as I have some time for it.
The \let\updefault\shapedefault seems to break compilation with regular lualatex (hangs with high CPU usage after showing /usr/local/texlive/2019/texmf-dist/tex/latex/unicode-math/unicode-math-table.tex).

Use \def\updefault{n} instead not sure if the \let could produce a loop if some files are old and others new method, looks like it.

Weird enough, the latest trick still fixes the behavior with lualatex-dev and lets lualatex work without hanging, but creates the missing font issue with lualatex. In other words, with
\usepackage[mathup=sym]{unicode-math}
\def\updefault{n}
\setsansfont{Source Sans Pro}
\setmainfont{Source Serif Pro}
\setmonofont{Source Code Pro}[Scale=MatchLowercase]
\setmathfont{XITS Math}
\def\updefault{up}

everything is fine with lualatex-dev, but stable lualatex now gives me:
LaTeX Font Warning: Font shape `TU/SourceSerifPro(0)/m/up' undefined
(Font)              using `TU/SourceSerifPro(0)/m/n' instead on input line 64.

and
LaTeX Font Warning: Font shape `TU/SourceSansPro(0)/m/up' undefined
(Font)              using `TU/SourceSansPro(0)/m/n' instead on input line 65.

The other way round, without the first \updefault redefinition, I get the errors with lualatex-dev but not with lualatex.
Removing the final \def\updefault{up} seems to make both happy.

Thanks for the fix!


Release v0.2

The single transaction for CW20 token swaps change will be reverted, this will not be the official v0.2


Remove default UI elements

It would be great to have the ability to move/edit/remove the existing toolbar buttons for further flexibility.
Having these take up less space would be great.

I very quickly tried to just draw over it with the toolbar color. This "works", except for that the elements underneath still respond.
I'm pretty sure that what you're suggesting is possible, but it wouldn't have priority for me to do now, maybe you or someone else can do it!

How did you draw over the top of the existing buttons? I feel I'm missing something here

Made an example branch, here's the commit: https://github.com/marijnz/unity-toolbar-extender/commit/c44faf216120d381fbf70eecb520e4c000276a65

And, any progress? :)

I definitely was being silly, I can see that I just needed to expand the drawable area to draw over the buttons.
So far I've managed to prevent the tooltips from showing by setting GUIUtility.hotControl to a value other than 0(i.e 1000). This leads me to believe that these buttons completely circumvent the normal interface.
I'll keep toying with it in my spare time and see if there's a better solution using reflection.

Moving the buttons would be pretty useful, Im considering inserting new stuff, but keeping whats there by default (in the same order, etc) but displaced.
@marijnz in your opinion this should be feasible?

Looking quickly at the code, I guess it would be possible to take the children from the toolbar here: https://github.com/marijnz/unity-toolbar-extender/blob/9f4c9ba013f8e6cf3c21278e89bd450a16613a08/Assets/ToolbarExtender/Scripts/Editor/ToolbarCallback.cs#L49. Then either draw them or skip them. If somebody wants to try out..

Hi there.
I tried to select the m_currentToolbar scriptable object to see what's going on in there and guess what? the children list is empty!
I also managed to draw a rect over play button in center of toolbar and hooked up my own buttons but the main buttons have higher priority for mouse events and i also tried to tweak GUI.depth variable and also used event system to see if mouse is inside my button rects but there is no luck.
Any help would be appreciated.

FYI, this might be easier with 2021, using Visual Elements.

Thanks for chimming in! I gave this a try time ago without luck, will try again using VE, later this year after updating to U2021.


About resize photo messages.

Hi,jessesquires
I have some small images(like 24*24) to show on collectionView .
I think "-(CGSize)mediaViewDisplaySize" is the key function.I find "JSQMediaItem.m" implemented the protocol with static size(CGSizeMake(210.0f, 150.0f)).And in "JSQPhotoMediaItem.m" I can see something like "[self mediaViewDisplaySize]".I tried to implement "- (CGSize)mediaViewDisplaySize" in "JSQPhotoMediaItem.m" and it works.But It doesn't work when I implement it in my own controller.I'm
confused.Is there something wrong?

Could the photos display in your own controller? If you want a photo display on the collectionView, the message which contains the photo information must conform the protocol JSQMessageData, and the method - (BOOL)isMediaMessage should return YES, - (id<JSQMessageMediaData>)media should return an instance that conform protocol JSQMessageMediaData, such as JSQPhotoMediaItem.

Thanks @LatteCat !


Symbol for Photos in Overview

As editor
I would like to see a symbol for submitted photos in the overview to see pictures at a glance.

Closing this in favor of #157


Fixes Issue #15

Fixes issue #15 by using yum-config-manager rather than changing the .repo-file

The problem with this implementation is that it's not idempotent. A command module will be executed every time, causing a change when it hasn't actually changed anything. The previous version of this role did use yum-config-manager, but I removed it in favour of the config file change.
I'm thinking of another way of fixing #15 using the ini_file module.


Incorporation of proteus_tutorials into the testing environment

adding proteus_tutorial problem setups to the testing environment

I believe this was addressed in #1210. Thanks @jhcollins.


Indexable.each_cartesian can't be further processed

Bug Report
This code:
it = Indexable.each_cartesian([[1, 2], [3, 4]])
it.select { |pair| true }

doesn't compile:
In /usr/local/Cellar/crystal/1.2.1/src/iterator.cr:947:32

 947 | Select(typeof(self), T, U).new(self, func)
                                  ^--
Error: no overload matches 'Iterator::Select(Iterator::Singleton(Iterator::Stop), Iterator::Stop, Bool).new' with types Iterator::Singleton(Iterator::Stop), Proc(Array(Int32), Bool)

Overloads are:
 - Iterator::Select(I, T, B).new(iterator : I, func : (T -> B))

The reason is this line:
https://github.com/crystal-lang/crystal/blob/fdcbcf4149cda377070f0f1b41583f54bb24b3f0/src/indexable.cr#L388
Iterator.of(value) will return an iterator that includes Iterator(typeof(value)). But when you have Iterator(T), you never expect T to include Iterator::STOP. T always excludes the stop value. And with this implementation the compiler thinks "stop" could be returned.
The solution is simple: just don't do this optimization. Or maybe we need an Iterator(T).empty.

We could reject Iterator::Stop inside the typeof, or we could, as you suggest, have the empty iterator:
module Iterator(T)
  private struct Empty(T)
    include Iterator(T)

    def next
      stop
    end
  end

  def self.empty
    {% if @type == Iterator %}
      Empty(NoReturn).new
    {% else %}
      Empty(T).new
    {% end %}
  end
end

I think it makes sense to be able to do so, just as we can construct an empty Tuple or Array or Hash.

Feel free to send a PR with that. I'm taking some vacations starting tomorrow.

Actually, returning a union might be slower in the general case because every call to next will do a dispatch. I think we can at least start with my PR.