[SPARK-15296][MLlib] Refactor All Java Tests that use SparkSession

What changes were proposed in this pull request?
Refactor All Java Tests that use SparkSession, to extend SharedSparkSesion
How was this patch tested?
Existing Tests

Test build #58581 has started for PR 13101 at commit c181fa6.

Test build #58581 has finished for PR 13101 at commit c181fa6.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58581/
Test FAILed.

Test build #58582 has started for PR 13101 at commit 12ba028.

Test build #58582 has finished for PR 13101 at commit 12ba028.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58582/
Test PASSed.

cc: @andrewor14 @andrewor14

ping @andrewor14 @mengxr

Test build #58737 has started for PR 13101 at commit f3fa1f5.

Test build #58737 has finished for PR 13101 at commit f3fa1f5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58737/
Test PASSed.

ping @srowen @andrewor14 @mengxr

@techaddict can you run dev/lint-java locally? Jenkins doesn't run that.

Test build #58893 has started for PR 13101 at commit 92ae70b.

Test build #58893 has finished for PR 13101 at commit 92ae70b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class TaskMetricsUIData(
  case class InputMetricsUIData(bytesRead: Long, recordsRead: Long)
  case class OutputMetricsUIData(bytesWritten: Long, recordsWritten: Long)
  case class ShuffleReadMetricsUIData(
  case class ShuffleWriteMetricsUIData(
class DenseMatrix @Since(\"2.0.0\") (
class SparseMatrix @Since(\"2.0.0\") (
class DenseVector @Since(\"2.0.0\") ( @Since(\"2.0.0\") val values: Array[Double]) extends Vector
class SparseVector @Since(\"2.0.0\") (
class QueryExecutionException(CapturedException):
trait ObjectProducerExec extends SparkPlan
trait ObjectConsumerExec extends UnaryExecNode
case class DeserializeToObjectExec(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58893/
Test PASSed.

@andrewor14 comments addressed + ran lint-java locally and fixed all the issues.

@techaddict thanks. One more comment. The rest looks pretty good.

Great to see 900 lines were removed:)

Test build #58923 has started for PR 13101 at commit 65307c5.

Test build #58924 has started for PR 13101 at commit 56de3e4.

Test build #58928 has started for PR 13101 at commit 9d7a89c.

Test build #58924 has finished for PR 13101 at commit 56de3e4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58924/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58929 has started for PR 13101 at commit 138818b.

@mengxr @andrewor14 @srowen Addressed all comments. Thanks for reviewing.

LGTM pending Jenkins

Test build #58923 has finished for PR 13101 at commit 65307c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class MultivariateGaussian @Since(\"2.0.0\") (

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58923/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58928 has finished for PR 13101 at commit 9d7a89c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58928/
Test PASSed.

Test build #58929 has finished for PR 13101 at commit 138818b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaMultilayerPerceptronClassifierSuite extends SharedSparkSession

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58929/
Test PASSed.

Merged into master and branch-2.0. Thanks!


[Popover] followup tasks

Portal option to render to body

Needed to break out of scroll container, e.g. CAAC nav menu

activation type - click | hover | focus

Needed for Tooltip

Refactor arrow using standard CSS triangle technique
Add touch support to close Popovers on mobile?
Resize awareness?
Get off of custom react-popper fork

Check out react-resize-aware for rasize awareness 🙃


Compound shapes with position offset handles incorrect

If collision shape has compound parent and has position offset, then physic gots incorect offset. Seem's here is reused Vec3 as pool vector twice. pos = pos.clone(); https://github.com/playcanvas/engine/blob/a1f5765a199c9c42e7984373dab3a620163dbb9b/src/framework/components/collision/system.js#L805 resolves problem

Would you happen to have a small repro project that shows the issue?

https://playcanvas.com/editor/scene/1715165

I set here breakpoint and while debugger is at break point execute in console command pos = pos.clone(); And as the result seee next screeenshot

Yes, I see it. Thank you for the repro! Seems a bug.

Yep, definitely a bug. Great spot!


Add ability to filter schedule by event types

I added the ability to filter by event type on the schedule page in DS701.  Adding here too.
I suggest you test it out locally to make sure it works, but it should.
Created issue #2 to reference this.

I tried it locally and got the checkboxes, but they didn't seem to do anything. I'll poke at it later.

Did the page finish loading? Something was happening for me today that the pages took a while to load  and then they worked.

From: Jeffrey Considine @.>
Sent: Tuesday, September 3, 2024 5:00:51 PM
To: DL4DS/fa2024 @.>
Cc: Gardos, Thomas @.>; Author @.>
Subject: Re: [DL4DS/fa2024] Add ability to filter schedule by event types (PR #3)
I tried it locally and got the checkboxes, but they didn't seem to do anything. I'll poke at it later.
—
Reply to this email directly, view it on GitHubhttps://github.com/DL4DS/fa2024/pull/3#issuecomment-2327428759, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6KD6TF2CPTVPF4XMTNFR3ZUYPQHAVCNFSM6AAAAABNQ5KGZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGQZDQNZVHE.
You are receiving this because you authored the thread.Message ID: @.***>

@jconsidi -- a student found the issue. It was using a JS package that was deprecated. Just pushed the fix. Should be all good now.

@jconsidi -- a student found the issue. It was using a JS package that was deprecated. Just pushed the fix. Should be all good now.

@XThomasBU , @jconsidi  -- i suggest you merge this PR to fix your page loading issue.


[BUG] Multiple copies of message is being sent when one is expected

Describe the bug
When user sends a message and hits multiple times send button, app will send last message multiple times. Users do this when application is not responding and not expecting to actually send it multiple times.
To Reproduce

Type a message
Smash the hell of the send button
See the multiple occurences of the last message

Expected behavior
Only one occurence of message sent to server.
Logs
Nothing in logs.
Screenshots

Devices and Versions
Your Rocket.Chat.Android version:  3.2.0
Your Rocket.Chat Server version: 0.70.4
Mobile device model and OS version: Xiaomi Mi 5, LineageOS 15.1

Same issue here. I would suppose it is not necessarily rater limiting what is needed but to disable the send button while the message is sending. Because what it seems happening is that the message is not being delivered causing the user to tap, and then you see 6-7 messages.
There is also another issue that happens as a result of this one. You try to delete the message, but in the Android app, it gets deleted, and then it comes right back (it does show gone on the web/electron app, though).

Any updates on this? This appears to happen more when on mobile data. It pretty much renders the app unusable.

As the steps to reproduce are written, I'm not able to make it happen. Maybe there's something I can do to exacerbate the problem so I can experience it?

I suspect it appears more readily when the network connection from the client is not good. If you have a testing instance of RocketChat available, you could use the tc tool in Linux on that instance to simulate a shoddy connection to the listening port on the server.

can you please test the fix I just posted? I did eventually reproduce it but it would be great if you could verify that the fix addresses what you are seeing as well. Thanks!

Yes, I will test this fix ASAP, hopefully tonight.


Use DID Auth in cookies mode (2)

Move to DID Auth v1.0.6
Continuation of #74
The client module for authentication was tested with this app https://github.com/rsksmart/rif-data-vault-sample
Find there how to run it together with this PR

Codecov Report

:exclamation: No coverage uploaded for pull request base (cookies@399788f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             cookies      #80   +/-   ##
==========================================
  Coverage           ?   78.75%
==========================================
  Files              ?       21
  Lines              ?      513
  Branches           ?       61
==========================================
  Hits               ?      404
  Misses             ?      109
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399788f...926aa52. Read the comment docs.


Glowing Fluids don't glow in cauldrons

When a light-emitting fluid such as lava is placed in a cauldron, no light is produced by the fluid.  As well, the texture has no emission, and so will be darkened like any other block in dim light.

I am not sure if there is anything I can do about this, but I can look into it. One big detail is cauldrons are a block model rather than a tile entity, so I cannot make the fluid texture "glow" properly. I can look into making it emit light though as I am already triggering block updates when you change the fluid.

I just tested this and it appears the game does not like me having the light level based on the TE, despite sending block updates. I will have to look into this more at a later date but for now this is "can't fix"

Closing this as not planned for 1.16. 1.18 made each fluid its own block thus making them glow is trivial.


GraphQL Support

Describe the feature
I am wondering if GraphQL support can be added without going into too much detail.
const query = `
  query GetUser($id: ID!) {
    user(id: $id) {
      id
      name
      email
    }
  }
`;

const variables = {
  id: '123',
};

ofetch('https://your-graphql-endpoint.com/graphql', {
  method: 'POST',
  headers: {
    'Content-Type': 'application/json',
  },
  body: JSON.stringify({
    query: query,
    variables: variables,
  }),
});

### Additional information

- [ ] Would you be willing to help implement this feature?

Hi @mrnasil
here 's the way I create a basic graphql client in my utils folder
export const $graphqlClient = async (query: string, variables?: object) => {
  const  { data, errors } = await $fetch( ~SERVER_ENDPOINT~, {
    method: 'POST',
    headers: {
      "Content-Type": "application/json",
      "x-secret": ~SECRET-TOKEN~
    },
    body: {
      query,
      variables
    }
  })
  return { data, errors }
}

Hi @mrnasil
here 's the way I create a basic graphql client in my utils folder
export const $graphqlClient = async (query: string, variables?: object) => {
  const  { data, errors } = await $fetch( ~SERVER_ENDPOINT~, {
    method: 'POST',
    headers: {
      "Content-Type": "application/json",
      "x-secret": ~SECRET-TOKEN~
    },
    body: {
      query,
      variables
    }
  })
  return { data, errors }
}

"Thank you very much for your response. I also use it in the same way. However, I believe it would be more appropriate for it to be included within ofetch as an optional feature.

as much as tempting as the idea is, i think it is out of ofetch scope (could be a wrapper library that does the variable replacement, and more)


fixes for Grafana 7.0.0

panel_definition does not contain "option" attribute in Grafana v7.0.0

Added a fix for cases where a panel does not have an options field, the id updates are skipped. Available in v0.2.6


Info  Command Broken

The bot crashes when /info <bot> is used

Seems like embed.setURL() dislikes it if you pass in NULL or an empty string


Update dependencies

@kinosang all dependencies were updated to the latest possible versions in version 0.4.4-dev.1, try it


Grey out scene out of focus in background.

Make the scene which is not in focus grey out a little bit so that it is obvious to the user which scene they can interact with.
For example, when a "new task" window is opened the out of focus "main scene" should have a grey tint over it to show that you cannot interact with it in the present moment.

I think this is a good issue to address particularly in terms of user experience and usability. Approved.


Adding mMARCO dataset

Adding mMARCO (v1.1) to HF datasets.

Hi @albertvillanova we've made a major overhaul of the loading script including all configurations we're making available. Could you please review it again?

@albertvillanova :ping_pong:

Hi there, i got an error about mmarco:
ConnectionError: Couldn't reach 'unicamp-dl/mmarco' on the Hub (ConnectionError)
code:
from datasets import list_datasets, load_dataset dataset = load_dataset('unicamp-dl/mmarco', language='portuguese')
Any help will be appreciated!

Hi @catqaq, we updated the loading script. Now you can load the datasets with:
dataset = load_dataset('unicamp-dl/mmarco', 'portuguese')

You can check the list of supported languages and usage examples in this link. Feel free to contact us if you have any issues.

Hi @catqaq, we updated the loading script. Now you can load the datasets with:
dataset = load_dataset('unicamp-dl/mmarco', 'portuguese')

You can check the list of supported languages and usage examples in this link. Feel free to contact us if you have any issues.

Thanks for your quick updates. So, how can i get the fixed version, install from the source?

@catqaq you can load mMARCO using the namespace unicamp-dl/mmarco while this PR remains under review.

Thanks for your contribution, @lhbonifacio and  @hugoabonizio. And sorry for the late response.
We are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets
As you already created this dataset under your organization namespace (https://huggingface.co/datasets/unicamp-dl/mmarco), I think we can safely close this PR.
We would suggest you complete your dataset card with the YAML tags, to make it searchable and discoverable.
Please, feel free to tell us if you need some help.


Add public key for Jason Zaugg / @retronym

Review by @adriaanm

Would like to run jstack on the hung ivy resolve in https://scala-ci.typesafe.com/job/scala-2.11.x-release-smoketest/402/console before aborting.

Sorry about the delay.


test rust hub sync data with rust hub

need to verify rust version hubs data sync

I think we've done this already, not found any problem


Bring Identity to programmier.bar

We want to bring Identity to the programmier.bar website!
Users should be able to register with/login to the programmier.bar website via select 3rd parties (e.g. "Login with..." github/google/ ...)
For this to happen, several pieces need to fall into place:

[ ] The backend needs to define a user model and role that is suitable for external users aka "community members"
[ ] The website and backend need to support a registration/login workflow via 3rd parties (OAuth)
[ ] The website needs to have a UI to ...
[ ] ... login/logout and show current status
[ ] ... update a user's profile

Once this feature becomes available, we can start implementing our backlog of ideas...

Done.


Problem with video download

Arial_log.txt
iMac 4K
Catalina
Just main monitor
Got an error while downloading videos. Hope the log helps!
Cheers,
Hans

Hi @hansw1204
Can you clarify what happened exactly I'm trying to parse the log bug it's a bit hard to tell.
Looks like you queued a lot of videos, some seem to download (suspiciously fast, did they actually download ?).

So did it download anything at all, just failed some ?

	Thanks for the fast reply!I believe it did download some and then got stuck.  I have a Gigabit connection so they do come fast. Might just be a server problem.

On Thu, Oct 10, 2019 at 11:46 AM -0400, "Guillaume Louel"<EMAIL_ADDRESS>wrote:
Hi @hansw1204
Can you clarify what happened exactly I'm trying to parse the log bug it's a bit hard to tell.
Looks like you queued a lot of videos, some seem to download (suspiciously fast, did they actually download ?).

So did it download anything at all, just failed some ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

After restarting Aerial (please close system preferences and restart it), if you try to download just one, does it download (click the + sign next to one) ?
If it doesn't download anymore, can you try this in Safari : https://sylvan.apple.com/Videos/SE_A016_C009_SDR_20190717_SDR_2K_AVC.mov
See if it downloads at all (I did recheck here, this one does) ?
Looks like an issue with you reaching the server, maybe they didn't like that you pulled the videos too fast ? Never heard of that issue but maybe they added some throttling to their servers ? (each video is downloaded with 4 threads which never was an issue here either, with a gigabit connexion too).
Let me know what happens.

Thanks Guillaume!
It seems to be working fine, actually. I think the reason it stopped downloading was that I reset the preferences from 4K to 1080HVECand thus the 4K videos stopped downloading. The screensaver runs well. I do get a warning that location service may not be set on and that it cannot determine the sunset/sunrise time. I checked, Location Service is on, however. Not a big deal.
Cheers,
Hans
From: Guillaume Louel<EMAIL_ADDRESS>Reply-To: JohnCoates/Aerial<EMAIL_ADDRESS>Date: Thursday, October 10, 2019 at 11:57
To: JohnCoates/Aerial<EMAIL_ADDRESS>Cc: Hans Winkler<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [JohnCoates/Aerial] Problem with video download (#868)
After restarting Aerial (please close system preferences and restart it), if you try to download just one, does it download (click the + sign next to one) ?
If it doesn't download anymore, can you try this in Safari : https://sylvan.apple.com/Videos/SE_A016_C009_SDR_20190717_SDR_2K_AVC.mov
See if it downloads at all (I did recheck here, this one does) ?
Looks like an issue with you reaching the server, maybe they didn't like that you pulled the videos too fast ? Never heard of that issue but maybe they added some throttling to their servers ? (each video is downloaded with 4 threads which never was an issue here either, with a gigabit connexion too).
Let me know what happens.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks Guillaume! It seems to be working fine, actually. I think the reason it stopped downloading was that I reset the preferences from 4K to 1080HVECand thus the 4K videos stopped downloading.

That's definitely it ;) Those are different files so it probably pruned the cancelled the queued downloads.

The screensaver runs well. I do get a warning that location service may not be set on and that it cannot determine the sunset/sunrise time. I checked, Location Service is on, however. Not a big deal.

So under Catalina, we don't have access to location services for now because of the whole new sandboxing thing. I'll remove that warning in a next build since there's not much we can do about it.
Thanks for following up on this!


Fix a minor issue with Norwegian

Current:
"CustomChangeAddress": "Egendefinert endre adresse",
Change to:
"CustomChangeAddress": "Egendefinert vekslepenge adresse",

Something you can fix, @missmeowness?


"The following extensions want to relaunch the terminal to contribute to its environment: direnv"

I frequently get prompted by VS Code to reload the direnv extension with a message like so:

OS: macOS 13.6 (M2)
Editor: VS Code 1.84.0-insider
Extension: v0.15.2
Shell env: Nushell 0.85.0
My Nushell config:
# ~/.config/nushell/config.nu

# ...
$env.config = {
    # ...
    hooks: {
        # ...
        env_change: {
            # https://direnv.net/docs/hook.html#nushell
            PWD: { ||
                if (which direnv | is-empty) {
                    return
                }

                direnv export json | from json | default {} | load-env
            }
        }
        # ...
    }
    # ...
}
# ...

I'm not sure where the issue is, could you explain what you're expecting and how what you're seeing is different?

I guess I'd just like to avoid this popup, which currently shows up on every newly opened VS Code window/shell:

Personally I'd rather the extension just do the restart for me. Or perhaps that choice could be a config option?

Personally I'd rather the extension just do the restart for me. Or perhaps that choice could be a config option?

Perhaps this leads to a feature request: that pop up could have buttons for "Restart This Time" and "Always Restart (can be changed in settings)" which will toggle that setting or something. What do you think? 😄

I think that's a great idea :)


ceph-osd blocked with "No block devices detected using current configuration"

Ubuntu 16.04
Dell R510, H700 raidcard, 148G2 raid-1 for system, 1T4 raid-5 for data (zfs).
My LXD uses ZFS as backend.
I use conjure-up openstack and choose the first "OpenStack" option.
Tried 6 times in the past 48 hours, everytime I get the same ceph-osd error.
ceph-osd/0              blocked         idle        2.0-beta7.1 3                      <IP_ADDRESS>  No block devices detected using current configuration
ceph-osd/1              blocked         idle        2.0-beta7.1 4                      <IP_ADDRESS> No block devices detected using current configuration
ceph-osd/2              blocked         idle        2.0-beta7.1 5                      <IP_ADDRESS>  No block devices detected using current configuration

And nova-compute will also be affected
nova-compute/0          error           idle        2.0-beta7.1 14                     <IP_ADDRESS>  hook failed: "ceph-relation-changed" for ceph-mon:client
  neutron-openvswitch/1 active          idle        2.0-beta7.1                        <IP_ADDRESS>  Unit is ready
  ntp/2                 unknown         idle        2.0-beta7.1                        <IP_ADDRESS>
nova-compute/1          active          idle        2.0-beta7.1 15                     <IP_ADDRESS> Unit is ready
  neutron-openvswitch/0 active          idle        2.0-beta7.1                        <IP_ADDRESS> Unit is ready
  ntp/0                 unknown         idle        2.0-beta7.1                        <IP_ADDRESS>
nova-compute/2          error           idle        2.0-beta7.1 16                     <IP_ADDRESS>   hook failed: "ceph-relation-changed" for ceph-mon:client
  neutron-openvswitch/2 active          idle        2.0-beta7.1                        <IP_ADDRESS>   Unit is ready
  ntp/3                 unknown         idle        2.0-beta7.1                        <IP_ADDRESS>

I saw some error about /dev/sdb does not exist:
root@juju-41e580f0-0092-47f4-80a5-42a30929245e-machine-5:/var/lib/juju/agents/unit-ceph-osd-2/charm# grep -irn sdb /var/log/|grep -v libnss
/var/log/juju/unit-ceph-osd-2.log:1001:2016-06-10 21:11:27 INFO worker.uniter.jujuc server.go:173 running hook tool "juju-log" ["Path /dev/sdb does not exist - bailing"]
/var/log/juju/unit-ceph-osd-2.log:1002:2016-06-10 21:11:27 INFO juju-log mon:13: Path /dev/sdb does not exist - bailing
/var/log/juju/unit-ceph-osd-2.log:1094:2016-06-10 21:11:42 INFO worker.uniter.jujuc server.go:173 running hook tool "juju-log" ["Path /dev/sdb does not exist - bailing"]
/var/log/juju/unit-ceph-osd-2.log:1095:2016-06-10 21:11:42 INFO juju-log mon:13: Path /dev/sdb does not exist - bailing
/var/log/juju/unit-ceph-osd-2.log:1189:2016-06-10 21:11:58 INFO worker.uniter.jujuc server.go:173 running hook tool "juju-log" ["Path /dev/sdb does not exist - bailing"]
/var/log/juju/unit-ceph-osd-2.log:1190:2016-06-10 21:11:58 INFO juju-log mon:13: Path /dev/sdb does not exist - bailing

And I really don't have /dev/sdb in the container:
root@juju-41e580f0-0092-47f4-80a5-42a30929245e-machine-5:/var/lib/juju/agents/unit-ceph-osd-2/charm# ls /dev/sd*
ls: cannot access '/dev/sd*': No such file or directory

by juju get-config ceph-osd I saw a config about /dev/sdb
  osd-devices:
    description: |
      The devices to format and set up as osd volumes.

      These devices are the range of devices that will be checked for and
      used across all service units, in addition to any volumes attached
      via the --storage flag during deployment.

      For ceph >= 0.56.6 these can also be directories instead of devices - the
      charm assumes anything not starting with /dev is a directory instead.
    type: string
    value: /dev/sdb

Will be really really thankful if someone can give me some hints or instructions!
I'm new to this, spend 10 days trying to setup a simple single-host env, but didn't get luck.... no matter on 14.04 with openstack-install or 16.04 with conjure-up. with different errors.
I haven't sleep since Wednesday, try to solve the problem, and endless system reinstall.

The first OpenStack option is meant for a MAAS setup. If you just want to run a full private cloud on a single machine pick the Openstack with Nova LXD.


Nonalignedrw

Coverage increased (+0.04%) to 73.406% when pulling 9dc3eb8d3a51a163e815ddb1e7f0f472e419a894 on nonalignedrw into fdcce0f930de957ac4b6df1571ae94865b378782 on master.


Support of fresh browser versions

Hello, please let us know if you have plans to release support new brosers versions chrome 120+ in you future updates?

Hi, scrapy-impersonate depends on the curl_cffi project. At the moment there do not seem to be plans to add support for those versions: https://github.com/users/yifeikong/projects/1

Hi @VicZagranowski
In version 1.3.0 there are two new Chrome browsers available:
-chrome123 (123.0.6312.124)
-chrome124 (124.0.6367.60)

I made a mistake, these two versions will be available until version 0.7.0 of curl_cffi is released.

Yes, today I will update this. Thanks!

In version 1.3.1 there are two new Chrome browsers available:

chrome123 (123.0.6312.124)
chrome124 (124.0.6367.60)


Cannot quit console via Ctrl-D

Tried exit() as well, have to use ctrl-c to force quit on Linux

Hmm, ctrl-D works for me but it looks like you have to hit enter after (which is kind of weird).
The exit command comes from the standard library so won't be available if the standard library isn't loaded.

See https://github.com/IronLanguages/ironpython2/issues/156

Fixed by 199b562a.


GetMoviesAsunc issue

Hi
I get the error below a fair bit form using the following:
 TMDbClient client = new TMDbClient("c6b31d1cdad6a56a23f0c913e2482a31");
            var config = await client.GetConfigAsync();
            //get the full movie details
            var movieData = await client.GetMovieAsync(movieID, TMDbLib.Objects.Movies.MovieMethods.ExternalIds | TMDbLib.Objects.Movies.MovieMethods.Videos | TMDbLib.Objects.Movies.MovieMethods.Credits);

Newtonsoft.Json.JsonReaderException: 'Unexpected character encountered while parsing value: <. Path '', line 0, position 0.'
Perhaps you could shed some light in this for me
Many Thanks
Daniel

Sounds like a HTML response to me.

Maybe they have some problems because it is doing all over the application that I am writing now? Even where that part of the app is finished and has worked great before.

Yea. It does look like it would be html - so their gateway or front end is spewing out errors instead of api responses.
I would make a ticket with tmdb asking about it and asking if they could deliver a Json error instead of html.
Mike.

From: Afy65<EMAIL_ADDRESS>Sent: Monday, May 28, 2018 8:52:10 PM
To: LordMike/TMDbLib
Cc: Michael Bisbjerg; Comment
Subject: Re: [LordMike/TMDbLib] GetMoviesAsunc issue (#270)
Maybe they have some problems because it is doing all over the application that I am writing now? Even where that part of the app is finished and has worked great before.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/LordMike/TMDbLib/issues/270#issuecomment-392586319, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA-sJ34HJVeHxPNK0CPEi3khd_7vcjPeks5t3EdagaJpZM4UQfmW.

Could possibly be fixed with #194

Fixed in #275 - we should longer try to process HTML responses.


MultiColumn TreeView

The project is great. I have a little suggestion. Can you add a MultiColumn TreeView? There are columns on the tiewview. You can drag the column headers to display different data in each column.

Hey @vmtest888. I'm glad you liked the project!
What you're looking for is a TreeTable widget which I don't plan on supporting in this package. However, the Flutter team has plans for a new TreeTableView widget for the two_dimensional_scrollables package once they finish the 1D and 2D tree views that they are currently working on.


Make PIO IRQ IDs into ZSTs

This allows getting the IRQ with pio.irq::<IRQn>(), where IRQn is a type generic.
This is a minor breaking change. I struggled for a while trying to get something similar working with the existing const generic, without success.

Hello, thank you for the contribution.
Could you elaborate on your usecase/motivation for this change?

This allows me to write a module which uses PIO while being generic over the IRQ it uses. See https://github.com/redolution/cubane/blob/e35d1be482b2e81d074fc699efcec44f840ab4f3/src/exi.rs, in particular these two lines:

https://github.com/redolution/cubane/blob/e35d1be482b2e81d074fc699efcec44f840ab4f3/src/exi.rs#L166
https://github.com/redolution/cubane/blob/e35d1be482b2e81d074fc699efcec44f840ab4f3/src/exi.rs#L180

I can't use a match block over the const generic here because the two IRQs have different type signatures, type-level selection is the only option as far as I can tell.
I've tried several approaches to make this work while retaining the const generic, but to no avail. I'm not sure it's actually possible without the ability to construct the object myself, so I fixed it at the root.

I see, thank you :)
Only adding fn irq<const IRQ: usize>(&self) -> Interrupt<'_, P, IRQ> wouldn't be good as it'd allow to create an Interrupt with any value of IRQ where only 0 and 1 are valid.

Yup, hence I implemented the same construct as is already used for things like state machine and DMA channel IDs.

Actually I found a way to check for that that's transparent to the user:
pub fn irq<const IRQ: usize>(&self) -> Interrupt<'_, P, IRQ> {
    struct IRQSanity<const X: usize>;
    impl<const IRQ: usize> IRQSanity<IRQ> {
        const CHECK: () = assert!(IRQ == 0 || IRQ == 1, "Irq Index must be either 0 or 1");
    }

    let _test = IRQSanity::<IRQ>::CHECK;
    Interrupt {
        block: self.pio.deref(),
        _phantom: core::marker::PhantomData,
    }
}

Oh that's neat, although the error message is a bit weird.
Fwiw since it's a usize, IRQ <= 1 should be enough as the condition.

Updated with your suggestion, so this is no longer a breaking change.


chore: correct the error message in case of empty input for metrics

Since 'more than' is not inclusive, we should be explicit not to allow only empty labels/predictions.

@dcrescim Hmm, the prettier passes in my local machine. What's wrong with the metrics.test.ts? Can we get some hint for the format issue?


Integration with Nova Compute (in the vm creation scenario)

Integration Story
Currently OpenStack allows users to launch launch VM instance via Horizon Dashboard or run nova boot command via OpenStack CLI. When it occurs, Nova compute would trigger a few REST calls to Neutron to allocate necessary network resources. We would want to integrate Nova to support the same set of user operations, especially the vm creation scenario.
Requirements

Identify all necessary changes (configuration and/or codes) in Nova to call Alcor REST APIs, instead of Neutron APIs
Make a proposal that requires minimal Nova changes
Implement the code/configuration change
Deploy and test the change in a multi-node OpenStack cluster

@Gzure Are you interested in giving this item a try? Please respond to the issue so that we could assign it to you (per GitHub policy). Thanks in advance for your contribution.

I have try it. And I identify all necessary changes (configuration and/or codes) in Nova to call Alcor REST APIs.

Sorry,I repled in slack. I have try it.I have identifed all necessary APIS in Nova to call Neutron REST APIs.

I'm working on it.I have identifed all necessary APIS in Nova to call Neutron REST APIs.

That is very nice @Gzure Thank you.


Remove try/catch semantics in otherwise pure code

Handling #1578 and cleaning up code in general.

For expediency, gambling that Travis likes this one since it liked the last one except for scalafmt.


Gnome 3.32.1

Motivation for this change
Mostly translation updates and few minor fixes. gjs have a few fixes for some segfaults.
There's changelog links in the commit messages.
Might be just a bit too large for master, not sure.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

OK, pruned away libcroco and libsoup, I'll make PRs to staging for those.


how to make it available for velocity?

how to make it available for velocity?
The link:
https://github.com/animecyc/AtomLanguageVelocity

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30492670-how-to-make-it-available-for-velocity?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github).

Having information how to enable the default keybindings for emmet in other languages (php, vm, js, and other files that can include html) is very much appreciated

Thanks very much.
The Emmet in atom works different.I typed div#yahoo.test-class,
it cannot result in <div id="yahoo" class="test-class"> </div>

It looks like the selector I provided doesn't work for the keymap. In fact: no data- attribute selector works.
Still looking for a solution.

Thank you guys.^u^


Temporary warnings

Cliptok should have an option to warn people with a temporary duration, so the warn expires after a specific period. The warning gets removed after it gets expired.
By default, a warn should expire after a week or 4 days, and increases when the member has more warnings if the duration isn't specified manually. This can be left up for discussion, but ideally should be after a member is expected to behave.
Something like:
/warn [member] expires: [period (or any other string that isn't a valid period for making the warning permanent)]

This can ensure more fair-ness for moderation actions.

This would be a fundamental moderation policy change and should be raised in a modmail for wider discussion with the mod team, rather than being raised as a bot issue.


fix cli missing shebang & release

@ekalinin got a quick patch for you 4.0.2. Mind doing another release?

Done:

https://www.npmjs.com/package/sitemap/v/4.0.2


Add Rectum .... you know what it means ;)

https://tools.wmflabs.org/geohack/geohack.php?language=en&params=52_019_039_N_6_034_019_E_type:city_scale:25000_region:NL&pagename=Rectum_(village)
Very little village in the Netherlands.

Added as https://www.vaguelyrudeplacesmap.com/?id=283&lang=en


Validate and ingest adapter and template CRs [DO NOT REVIEW YET]

This PR ingests adapter and template kind CRs.

Validates
stores in snapshot.

Also adds a cmd tool to convert a proto file descriptor set into base64 encoded string.

Also, the existing encoder (config to bytes based on file descriptor) was implemented for yaml, which is not correct for our case. Kubernetes resources are JSON and therefore the unmarshalled types are different too. For example the unmarshalled yaml is map[string]interface{} instead of map[interface{}]interface{}. And there is no int type, instead all numbers are just float64. This PR fixes all those issues too.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: guptasu
Assign the PR to them by writing /assign @guptasu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
22574426b55617714a73f74022466ee994b69325
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
22574426b55617714a73f74022466ee994b69325
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
22574426b55617714a73f74022466ee994b69325
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog here you go
https://github.com/istio/istio/pull/5277
https://github.com/istio/istio/pull/5276
Let's review the above two before reviewing this current big one.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22574426b55617714a73f74022466ee994b69325
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
2b987354e4ff9316d1cf403efa73786fb6b3cbc4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2b987354e4ff9316d1cf403efa73786fb6b3cbc4
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
2b987354e4ff9316d1cf403efa73786fb6b3cbc4
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Progressbar, bounds not set when executing more than one task

There is one minor issue in progressbar. When executing more than one task, the bounds of progressbar is not reset (set) properly. This causes the progress not to work as expected.
A fix will be released in some days.

Issue is fixed in code.

fixed in 1.8.9.


sync: 0.10.1

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Sync of release branch for 0.10.1.
It ships:

https://github.com/falcosecurity/libs/pull/802
https://github.com/falcosecurity/libs/pull/804
https://github.com/falcosecurity/libs/pull/807
https://github.com/falcosecurity/libs/pull/818
https://github.com/falcosecurity/libs/pull/822
#814
https://github.com/falcosecurity/libs/pull/820
#833

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.10.1

I would try to go on and merge this; other 2 missing PRs will need some work before merging (all the test part will generate conflicts given that it is based on a new version of the driver testing framework (https://github.com/falcosecurity/libs/pull/783)

Partially merged #814, only first 2 commits, ie:

de17488d3b7221e17cbdddd67851856bb0378976
1c9935b094f758ef9e5f5fec995296d3f0162ca2

Last commit implemented some tests, that depend on multiple changes on the testing framework that we are not going to port back to 0.10.x.

I tried to merge also 29c2ed191096612c40a0a41e2a6834751805fc26 as it is needed to allow modern bpf tests to build.

30bb711494ca7d489f454977da10ac4619da1d7b is needed to fix build of modern bpf tests. It is not a cherry pick.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


rust-analyzer: "Function __wasm_bindgen_generated... should have snake_case name"

Describe the Bug
rust-analyzer complains about generated fn names.
Steps to Reproduce
#[wasm_bindgen]
impl Session {
    pub fn desktop_size(&self) -> DesktopSize {
    ...
  }
}

Expands to
    pub fn desktop_size(&self) -> DesktopSize {
        #[automatically_derived]
        const _: () = {
            #[cfg_attr(
                all(target_arch = "wasm32", not(any(target_os = "emscripten", target_os = "wasi"))),
                export_name = "session_desktop_size"
            )]
            pub unsafe extern "C" fn __wasm_bindgen_generated_Session_desktop_size(
                me: u32,
            ) -> wasm_bindgen::convert::WasmRet<<DesktopSize as wasm_bindgen::convert::ReturnWasmAbi>::Abi>

Expected Behavior
No rust-analyzer warning
Actual Behavior
rust-analyzer warnings are emitted, such as
Function __wasm_bindgen_generated_Session_desktop_size should have snake_case name, e.g. __wasm_bindgen_generated_session_desktop_size
Additional Context
Given that the fn have an export name, couldn't the fn symbol name be simply lowercased?

Given that the fn have an export name, couldn't the fn symbol name be simply lowercased?

Probably not, otherwise a different session::desktop_size() would collide.
I was unable to reproduce this issue, so it would probably be best if you could make a small but complete reproducible example.

I am having the issue with __wbg_instanceof_JsType from tsify (the issue) and weirdly I wasn’t able to repro in the playground either.
Tsify triggers the warning from this generated code:
https://github.com/madonoharu/tsify/blob/66cddfe680ae429be0063cf6e6b1b5be34bb7ce2/tsify-macros/src/wasm_bindgen.rs#L57-L61
I think this commit https://github.com/rustwasm/wasm-bindgen/commit/ddceac747876d67fe52dafc90964f95741ae467d is the fix for this.

Thank you for looking into this!
If this is ultimately not fixed by #4078, I'm happy to take a look again with a reproducible example.


make sure no sgx instructions in target binary

Checking if each insn disassembled from the target binary is not an ENCLU instruction.

Solved.


netty buffer overflow

Db db = new ConnectionPoolBuilder()
                .hostname("localhost")
                .port(5432)
                .database("mydb")
                .username("postgres")
                .password("admin")
                .poolSize(20)
                .build();
        Consumer<Throwable> onError = error -> error.printStackTrace();
        db.begin(transaction -> {
            transaction.query("insert into MoellerTab (ID,Name,Age,Rate,Sex) values ('1','The Moeller','13','1.50','M')",
                    result -> {
                        System.out.printf("Result is %d", result);
                        transaction.commit(() -> System.out.println("Transaction committed"), onError);
                    },
                    error -> System.err.println("Error:"+error));
        }, onError);

yields:
Error:com.github.pgasync.impl.netty.NettyPgProtocolStream$ChannelError: java.lang.IndexOutOfBoundsException: readerIndex(10) + length(1178945608) exceeds writerIndex(127): UnpooledUnsafeDirectByteBuf(ridx: 10, widx: 127, cap: 127)

table def
CREATE TABLE "MoellerTab"
(
  "ID" character varying(20) NOT NULL,
  "Name" character varying(20),
  "Age" smallint,
  "Rate" real,
  "Sex" character(1),
  CONSTRAINT "MoellerTab_pkey" PRIMARY KEY ("ID")
)
WITH (
  OIDS=FALSE
);
ALTER TABLE "MoellerTab"
  OWNER TO postgres;

postgres 9.4

Thanks for the bug report.

the statement actually should generates an sql level error (long time no sql ;) )

I'm unable to reproduce the error with postgresql 9.4.1, postgres-async-driver 0.6 and Ubuntu 15.04.
The supplied code prints an error (```Error:com.github.pgasync.SqlException: ERROR: SQLSTATE=42P01, MESSAGE=relation "moellertab" does not exist

Is there anything special about your environment?

Hm, was a windoze bugs. But anyway its kind of a very stupid error, so
maybe not worth investigating further :)
2015-07-06 20:26 GMT+02:00 Antti Laisi<EMAIL_ADDRESS>
I'm unable to reproduce the error with postgresql 9.4.1,
postgres-async-driver 0.6 and Ubuntu 15.04.
The supplied code prints an error (Error:com.github.pgasync.SqlException:
ERROR: SQLSTATE=42P01, MESSAGE=relation "moellertab" does not exist
) and runs fine after quoting the table and column names.
Is there anything special about your environment?
—
Reply to this email directly or view it on GitHub
https://github.com/alaisi/postgres-async-driver/issues/6#issuecomment-118947382
.

erm "windoze BOX"
2015-07-06 20:27 GMT+02:00 Rüdiger Möller<EMAIL_ADDRESS>
Hm, was a windoze bugs. But anyway its kind of a very stupid error, so
maybe not worth investigating further :)
2015-07-06 20:26 GMT+02:00 Antti Laisi<EMAIL_ADDRESS>
I'm unable to reproduce the error with postgresql 9.4.1,
postgres-async-driver 0.6 and Ubuntu 15.04.
The supplied code prints an error (Error:com.github.pgasync.SqlException:
ERROR: SQLSTATE=42P01, MESSAGE=relation "moellertab" does not exist
) and runs fine after quoting the table and column names.
Is there anything special about your environment?
—
Reply to this email directly or view it on GitHub
https://github.com/alaisi/postgres-async-driver/issues/6#issuecomment-118947382
.


Some delay in getting lates tx details in gateway service after submitting a signature to the transaction service

When confirming the tx with transaction service, then immediately requesting tx details with gateway service, the gateway service returns tx previous sate (1 owner signature less)
submitting signature to transaction service response time 2020-10-09 12:44:32.666000 --> status 201
requesting tx details from gateway response time 2020-10-09 12:44:32.786000 --> the submitted signature is missing
requesting tx details from gateway response time 2020-10-09 12:44:35.390000 --> all signatures are there
Not sure it this is a gateway issue.

Due to the nature of the cache invalidation in the gateway, currently, the only way to invalidate caches for updates in transaction states is via web hooks. There is a delay associated with the web hook triggering and the communication time between the transaction service API and the gateway.
Therefore, the behaviour of the gateway is expected. The feature request #162 should provide the means to invalidate caches immediately and supply the apps with the state updated  as required.


Request to add amigo.edu.co domain

File with Universidad Catolica Luis Amigó Domain.
Request to add domain and be able get student licences.

@danielrg97 Pull request merged. Thank you!


Set a minimum size for the buttons in the project manager

Since the "Remove Missing" button is wider than the others and also it sometimes doesn't appear, this means that currently the size of these buttons varies, which is a bit strange. This PR sets a minimum size so that the column of buttons will never get thinner than if "Remove Missing" was present.

The button width might still change for other languages, but there's not much we can do about that.

That won't work for languages where the translation for "Remove missing" is longer than 122px (or themes with a bigger editor font, though I'm not sure it applies to the PM). But it's better than nothing I guess :)

Another option I thought of is to make the button always exist but transparent, but then the transparent button still accepts mouse clicks... see #20234.

This is probably not the correct way to solve the problem. There is no reason why one button would disappear, this is a bug that should be fixed.

@groud This feature was added as part of #25713, cc @qarmin

In that case, you have two solutions:

disabling the button instead of hiding it,
Use the children node computed minimum width as the minimum width for the VBoxContainer (it should be computed automatically, not hardcoded)

disabling the button instead of hiding it,
👍

Disabling it instead seems like the best approach.

I changed it so that the button is disabled instead of hidden, but also, I kept a minimum size. I think it helps with UI consistency so that languages with really small translations won't have tiny buttons.

Thanks!

Cherry-picked for 3.2.4.


Review types used in instanceof checks

What
Review the types used in instanceof checks to verify that they are not overly specialised, especially if checks for HTMLElement could be simple Element and note:

where checks could use a more generic class due to the component not using any of the specialised class API
if there'd be ground to keep the generalised class to ensure some checks related to accessibility

Why
Using the correct class to check against (especially Element which is naturally returned by querySelector or querySelectorAll) would allow to be clearer on what our code is actually trying to achieve, and in turn possibly clarify some of our tests.
There's some grounds to discuss instanceof checks to validate accessibility concerns. That's a discussion we can open once we have a view of which of our components may already do that.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[x] We have a list of components where more specialised instanceof checks are used
[ ] We have a lined up a discussion for those where these checks could fullfil some accessibility validation

Worth having a look, while reviewing things, at whether instanceof checks (or sometimes just falsy checks) leading to early returns might be ommited in favour of leaving JavaScript to error further down the line. Especially for event listeners, a runtime error will not impact other listeners running for the same event, so we might have an opportunity to be a bit looser there.

Feels like the TypeScript team are watching our repo 😮
From the TypeScript 5.3 beta release notes we now have:

Narrowing types for booleans like 'a' in x
Narrowing instanceof types
Checks for super.XXX field access

TypeScript 5.3 now more-closely inspects super property accesses/method calls to see if they correspond to class fields. If they do, we’ll now get a type-checking error.

Will have to confirm if instanceof checks can be moved to the base class now

I've reviewed all the instanceof types in https://github.com/alphagov/govuk-frontend/pull/4325 and narrowed them down unless guarding required APIs such as:
$element.dataset
$element.click()
$element.focus()

ARIA attributes and element types
We may want to tighten our checks to confirm aria-* attributes match their required element types (or role)
At the moment we only do this for Radios and Checkboxes inputs:

Accordion section button

// $button instanceof Element
$button.getAttribute('aria-controls')
$button.getAttribute('aria-expanded')

Header menu button

// $menuButton instanceof Element
$menuButton.getAttribute('aria-controls')

Radios and Checkboxes inputs

// $input instanceof HTMLInputElement
$input.getAttribute('aria-controls')


Added MakeMeFish

Added MakeMeFish - fzf history-like navigation for Makefile targets.

Hi @OakNinja. Care to elaborate a bit more on your package? 👋

Hi @OakNinja. Care to elaborate a bit more on your package? 👋

Hi @jorgebucaran, I'd be happy to!
Makefiles is super useful to create cross platform, flexible, and language agnostic operations. However, in projects with more than just a handful of make targets, or with really verbose targets, it's really hard to know what make targets to run, even if you know what to look for. Using grep or just cat'ing the whole file is time consuming.
MakeMeFish solves the biggest usability problem with Makefiles by making it quick and easy to list all the make targets without any clutter, and provides type ahead to make it easy to find what you are looking for without the requirement of reading the whole Makefile.
You just type mm in the current working directory, and if there is a Makefile present in the cwd, MakeMeFish parses the file, puts all the make targets in a list, and pipes them to fzf just like how fzf-history/fzf reverse isearch does.
I've provided an animated gif in the repo at https://github.com/OakNinja/MakeMeFish,
I think it might be possible to show it here as well:

Thank you for all the info @OakNinja. I feel you could work a bit more on the presentation of the project (README), use console code blocks instead of inline code for instructions, use higher quality screenshots or GIFs and even add some of that information you elaborated on here to a new "Background" (or whatever name you prefer) section in your README.
I'd also like to suggest you share your project with the community, e.g., r/fishshell to get more traction and I'd like to see a few more stars before we merge here.

Thank you for all the info @OakNinja. I feel you could work a bit more on the presentation of the project (README), use console code blocks instead of inline code for instructions, use higher quality screenshots or GIFs and even add some of that information you elaborated on here to a new "Background" (or whatever name you prefer) section in your README.
I'd also like to suggest you share your project with the community, e.g., r/fishshell to get more traction and I'd like to see a few more stars before we merge here.

Thank you for your input - I'll revise and get back to you :)


Fresh install fix CEC issues in Kodi

After a fresh install, when using Kodi (flatpak) in GamerOS, Kodi can see my PulseEight CEC adapter without issue. However, after installation, Kodi fails to initialize the CEC adapter. I discovered that the Kodi users are required to be part of the uucp and lock groups in order for the PulseEight CEC adapter to properly initialize.
I setup SSH, logged in as gamer, and added gamer to uucp and lock groups via sudo usermod -aG uucp,lock gamer. After restarting GamerOS, Kodi can now initialize the PulseEight CEC adapter.
It would be nice if CEC was working out of the box. I'd recommend part of the install script should include the gamer user to the uucp and lock groups.

Is this relevant? Can #428 improve the situation?

Closing as inactive


/RTC compiler checks failures don't break into debugger

Running VSCode version 1.63.2
Windows version 20H2 19042.1415
Extension installed: Microsoft's C/C++ extension
I've attached a minimal app that reproduces this issue along with the cmake file to build it in src.zip. This sample can be built:

'cmake -S . -B build/'
'cmake --build build/ --config Debug'
launch.json must be configured to enable running and debugging the build executable through VSCode
In the Breakpoints UI toggle 'All Exceptions'
Run the sample through VSCode

Result
Run-Time Check Failure #1 - A cast to a smaller data type has caused a loss of data.  If this was intentional, you should mask the source of the cast with the appropriate bitmask.  For example:
	char c = (i & 0xFF);
Changing the code in this way will not affect the quality of the resulting optimized code.

is printed to the output console.
Expected
IIn addition to the above output, the debugger should break when the RTC failure occurs per documentation here. Specifically:

When you debug a program that has run-time checks enabled, the default action is for the program to stop and break to the debugger when a run-time error occurs.

TLDR:
The following code snippet:
        const size_t violate_rtcc = UCHAR_MAX + 1 + rand();
        const unsigned char bad_assignment = violate_rtcc;

Compiled with /RTCcs only prints a failure message to console and doesn't break into the debugger.

/extC++


run example server on http instead of https

Chromium-based browsers do not allow WebAuthn calls on https URLs that have certificate issues.
See https://lists.w3.org/Archives/Public/public-webauthn/2022Nov/0135.html
Changing this to http on localhost, which is considered a secure context in most browsers.
See https://groups.google.com/a/chromium.org/g/blink-dev/c/RC9dSw-O3fE/m/E3_0XaT0BAAJ

not ready yet, will create a new PR later

Obsoleted by https://github.com/Yubico/python-fido2/pull/218


coefficient

Hi all,
i think it could be an insteresting feature to add a coefficient on question attributes

@xibman SurveyJS allows to add/remove properties on the fly. The following code will add the coefficient property, just call it before creating the Survey.
//add a property to the base question class and as result to all questions.
//Property name is coefficient, type number and if the value is not set, the default value is 100.
Survey.JsonObject.metaData.addProperty("questionbase", {name: "coefficient:number", default: 100});

Here is the description with what you can do with properites.
However, you may need it the most of this, since it is related to the SurveyJS editor mostly.
Thank you,
Andrew

thanks a lot for your answer !


Adding EmpiricalDistribution and testing on MCMC

This adds the draft for the EmpiricalDistribution as discussed in #942, for discussion. Broadly the design is as follows:

EmpiricalDistribution holds a collection of data points with the same type and shape. These data-points are collected along the leftmost dimension. It provides a method called add to add a single datum to the existing collection. These are lazily collected into a tensor, so as to avoid repeated tensor copies per iteration. We can compute mean, variance and generate samples from EmpiricalDistribution for any arbitrary shape.
MCMC inherits off of TraceJoint that stores a bag of traces corresponding to the joint distribution of latents and observed. We can call .marginal(site=x) on this, to return the marginal for a given sample site (we can add other methods that condition, etc.). The return type is the EmpiricalDistribution.

What needs to be fixed:

There is redundancy between TracePosterior and TraceJoint. We need to merge the two, retaining performance when we do not need log_prob.
Using EmpiricalDistribution in Histogram, or generalizing it to support Histogram.
Other improvements.

cc. @eb8680, @fritzo - Let us discuss any requirements to generalize this for #915.
Tests: Tests added in test_empirical.py, and HMC/NUTS tests are modified.
PS: Let us restrict the review to discussing design requirements, if possible. I will change the label once this is ready for a full review.

Design looks reasonable so far.
For discrete enumeration it would be nice to support .log_prob(). I think it's fine to treat even continuous-valued EmpiricalDistributions as discrete sums of deltas; this gives us room to define a similar SmoothedEmpiricalDistribution with .log_prob() using kernel density estimation and with .sample() adding a bit of noise. Did you have specific reasons for not implementing .log_prob()?

Did you have specific reasons for not implementing .log_prob()?

I should have explained this in more detail. I discussed the main reason with @eb8680 in #845. The issue is with doing equality comparison on large tensors to compute their weights, even if most of these weights are in practice 1, specially with continuous samples (see the Histogram implementation).
The other reason is that most of the use cases (that I am familiar with and see in tests/examples) are around using EmpiricalDistribution to compute statistical properties of the existing sample rather than score new samples. My guess is that doing this for any non toy sized problem with continuous values will be fraught with difficulties until we have sophisticated KDE algorithms built in. Until we do so, I wanted to target the remaining 95% (currently) use cases which do not need to incur a performance penalty when they are not using log_prob. I would like to understand some of the use cases you might have in mind though!

For discrete enumeration it would be nice to support .log_prob()

I was thinking of EmpiricalDistribution in general terms as a collection of tensors with consistent shape/type. When you say discrete enumeration, do you mean any discrete sample site? Say we have a discrete sample site that generates a sample of shape [p, q, r] each of which is drawn from a categorical distribution with K categories. Would we then track the number of samples over the entire p x q x r x K space?

EDIT Note that it should be cheap-ish to compute .log_prob() from tensors via something like

Is this for discrete samples? Sorry, I didn't fully understand the example, but looking forward to chatting more on that.

@eb8680, @fritzo - With some minor tweaks (and @fritzo's suggestion above), I think we can extend this to support both importance weights, as well as not having to pay any book-keeping penalty for using .log_prob. Then we can just plug this into Histogram and TracePosterior.

@neerajprad One use case I'm interested in is in computing marginals of a discrete state HMM, say with one EmpiricalDistribution per time step. In this case we would have tensors of empty shape () and only a handful of total states (say 10) so .log_prob() should be cheap. For efficiency we may want to batch these over multiple time series so that .weights.dim() == 2 or more; that is,
weights.shape() == my_empirical_dist.batch_shape + (num_classes,)

@eb8680 has probably thought about this in more detail...

I think we can extend this to support both importance weights, as well as not having to pay any book-keeping penalty for using .log_prob

Yep, we should be able to use the same code for both.  As in the current version of TracePosterior, the sample weights in the MCMC case are all 1.

computing marginals of a discrete state HMM

Yeah, I was working on that yesterday and will try to open a PR today.  Getting batching over a global independence dimension working seamlessly has been a little more involved than I expected.

Getting batching over a global independence dimension working

Can you simply use iarange dimensions, similar to how we parallelized the models in test_enum.py, e.g. here?

@neerajprad let's split off a PR for Empirical and get it merged separately so we can get a version with weights working and clean up Histogram as well

@neerajprad let's split off a PR for Empirical and get it merged separately so we can get a version with weights working and clean up Histogram as well

Yup, I'll get on to it next.

and clean up Histogram as well

@eb8680 - Are you doing this as part of the refactor? Feel free to assign any related sub-tasks to me.

Addressed by #1019


rails-html-sanitizer: Add types for rails-html-sanitizer gem

This gem is responsible for sanitizing HTML fragments in Rails applications. Specifically, this is the set of sanitizers used to implement the Action View SanitizerHelper methods sanitize, sanitize_css, strip_tags and strip_links.
refs: https://github.com/rails/rails-html-sanitizer

/merge


Add fixtures for file downloads.

Add download_input_file fixture.

Provides a function to download files via /api/uploads/{id} route.

Add input_files fixture.

Downloads all input files from job.args["files"] and returns a dict mapping from file names to pathlib.Path.

Updates the .. autofixture sphinx plugin to render async in the return type for protocol fixtures.

Needs a section in https://workflow.virtool.ca/fixtures.html

It has been added!


ESP32 Support

This change attempts to add ESP32 support to the project, as well as abstracting some of the logic to a State class.

Note, the mDNS feature has not been tested yet.

Closing this out in favour of a clean up branch I'm working on that also adds support for the new pixel strips and will hopefully abstract some of the logic to make updating using it a little easier :D


Fix implementation of strncpy

The pointer arithmetics originally exist after the branch instruction. So they
will be omitted when n is greater than length of src, and the setting of zero
tails will not match the real strncmp.

Thanks for noticing the bug, though your code wasn't quite correct (x0 is fixed zero register).  I fixed with alternate code.


Update L1 based on design modifications

At the end of Q4 2019, the L1 title chip card was updated by design: spacing, type size and interactive states were finalized and tested.
Tasks

[ ] Design to provide dev with latest L1 design specs
[ ] Dev to implement design changes as per specs

@larahanlon2 @RobertaJHahn I'm wondering if we can attach this issue to epic https://github.com/carbon-design-system/ibm-dotcom-library/issues/2092? We don't have a dev issue for the L1 work yet for the October release as far as I can tell.

Things have changed since February 2020.  Closing this issue as the work is managed under (#4007)


Better error message when builder/controller API auth fails

If the authentication from the builder to the controller fails due to a wrong secret, deis push fails with Permission denied and the builder logs [ERROR] Failed handshake: EOF which does not give any indication of the actual error.
Instead the builder should log something like [ERROR] API authentication to controller failed which would be much more useful when debugging the problem.
I ran into this while debugging the problem described in deis/charts#303 where helmc generated a builder secret that began with a space and caused the API request to verify the ssh key between builder and controller to fail.
In order to find the cause for the above mentioned issue I had to read the source code for the ssh server, controller utils, the go ssh module docs and construct an API request using curl from inside the builder container…
The code that should be augmented is in sshd server.AuthKey() calling controller.UserInfoFromKey() without logging anything if this call fails.
This issue is related to #32 and probably others relating to the "Failed handshake: EOF" error.

I added a log message when authentication fails in #402.


Documentation recommendation, config:cache

Hi! Thanks for a great package.
A suggestion for the documentation. I found after following the composer installation and adding it to config/app.php, I had to also
php artisan config:cache for the vendor to show up on the vendor:publish list. Hope it saves someone some time.

can you send a pr please


Agpush 1421 double check on delete

To be merged after https://github.com/aerogear/aerogear-unifiedpush-server/pull/577
https://issues.jboss.org/browse/AGPUSH-1421

added confirmation for app/variant rename and app "renew master secret"
we had to reintroduce "renew variant secret" dialog as it wasnt implemented
in order to allow update snippets, impl of their directives had to be changed

:+1: All good

Landed :rocket:


[BUG] Double Click Voice Channels Plugin

The plugin dosn´t work you click one time and you´re connected so the plugin dosnt work
pls fix thx.
i press only one time and youre in if you double clickm the profilepic preview opens in voice channel

update the god damm plugin mate @QbDesu

The plugin was updated a few days ago and should be working now as soon as you update.

The plugin was updated a few days ago and should be working now as soon as you update.

thank you <3


Replace SVG for mobile image

https://trello.com/c/83GcYGcq/210-update-the-svg-iframe-for-mobile-preview
The current mobile image grey is the same as GOV.UK footer.
Updating SVG so it doesn't blend together.
Design approved by @markhurrell

@soniaturcotte you can request someone to review if you want, but sometimes people put them in slack too. Once it's approved, you can go ahead and merge :-).


Poor performance for Conv2D using "same" padding scheme

System information.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.8

Describe the current behavior.
When we set the "padding" scheme of tf.keras.layers.Conv2D as "same", the computation will usually take abnormally longer time (usually more than double) than the "valid" "padding" scheme with the same parameters.

The issue will be more severe when we set filter number to be a larger time.
Describe the expected behavior.
Although "same" "padding" scheme is expected to cost more resources to run, I am not confident whether the large time difference is acceptable
Standalone code to reproduce the issue.
https://colab.research.google.com/drive/19rK3voM4605PVyl1Sh91Xd-Ojyl1_1qK?usp=sharing#scrollTo=hHDoEjOF16mG

@kelvinlyy sorry for the late response!
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

@kelvinlyy sorry for the late response!
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

Hi, the code snippet for reproducing the issue is as below:
# initialize input_x
input_x = tf.random.normal((50000, 32, 32, 3))

# cov2d function with 'valid' padding
tf_conv2d_layer_valid = tf.keras.layers.Conv2D(filters=1, kernel_size=10, strides=(1,1), padding='valid', dilation_rate = (1,1))

# measure time taken for 'valid' padding conv2d
start_time = time.time()
result = tf_conv2d_layer_valid(input_x)
end_time = time.time()

print("Time taken:", end_time-start_time)

# cov2d function with 'same' padding
tf_conv2d_layer_same = tf.keras.layers.Conv2D(filters=1, kernel_size=10, strides=(1,1), padding='same', dilation_rate = (1,1))

# measure time taken for 'same' padding conv2d
start_time = time.time()
result = tf_conv2d_layer_same(input_x)
end_time = time.time()

print("Time taken:", end_time-start_time)

@kelvinlyy Thanks for the update! Could you please check with the latest stable version of TF 2.6.0 ,less time difference is observed while running your code on colab ?Please find the gist here for reference & let us know if it helps?Thank you!

@kelvinlyy Thanks for the update! Could you please check with the latest stable version of TF 2.6.0 ,less time difference is observed while running your code on colab ?Please find the gist here for reference & let us know if it helps?Thank you!

@kelvinlyy Thanks for the update! Could you please check with the latest stable version of TF 2.6.0 ,less time difference is observed while running your code on colab ?Please find the gist here for reference & let us know if it helps?Thank you!

@kelvinlyy Thanks for the update! Could you please check with the latest stable version of TF 2.6.0 ,less time difference is observed while running your code on colab ?Please find the gist here for reference & let us know if it helps?Thank you!

Sorry for the late reply. The times taken for running both the padding scheme are both shortened a lot in TF 2.6.0. But there is still a 3 times time difference observed on my machine.

FYI, the CPU and GPU I used was Intel Xeon Processor (Skylake, IBRS) and Nvidia GeForce RTX 2080 Ti respectively.

@kelvinlyy I am seeing different computational time when compared to you. Can you please check the gist here and let us know if I am missing anything here.
result = tf_conv2d_layer_valid(input_x)
Time taken: 0.005303621292114258

result = tf_conv2d_layer_same(input_x)
Time taken: 0.002894163131713867

@kelvinlyy I am seeing different computational time when compared to you. Can you please check the gist here and let us know if I am missing anything here.
result = tf_conv2d_layer_valid(input_x)
Time taken: 0.005303621292114258

result = tf_conv2d_layer_same(input_x)
Time taken: 0.002894163131713867

It is interesting. I ran the gist in your link but I got different results from yours.

But when I ran the second time, it replicated your given runtime.
I tried to restart the kernel and run again. It then took the approximate time I ran in the first time. I guess the problem can be reproduced if you first restart the kernel and then run the codes again. Can you please try that out?

@kelvinlyy I am seeing different computational time when compared to you. Can you please check the gist here and let us know if I am missing anything here.
result = tf_conv2d_layer_valid(input_x)
Time taken: 0.005303621292114258

result = tf_conv2d_layer_same(input_x)
Time taken: 0.002894163131713867

It is interesting. I ran the gist in your link but I got different results from yours.

But when I ran the second time, it replicated your given runtime.
I tried to restart the kernel and run again. It then took the approximate time I ran in the first time. I guess the problem can be reproduced if you first restart the kernel and then run the codes again. Can you please try that out?
FYI, I used "Factory reset runtime" to restart the kernel in Google Colab

I just spotted that if I run the conv2d with "same" and "valid" padding individually in 2 kernels, they took approximately the same time to compute. I guess the issue of performance difference should be fixed now. Thanks.


fix: Fixed flaky fork template test case

Description
Root Cause Analysis (RCA):
The issue stemmed from the use of hardcoded templates in our tests, which introduced inherent flakiness. This approach caused intermittent failures, particularly when the hardcoded template was not available or had changed.
Solution:
I have resolved this by implementing dynamic locators that select the first available template during the test execution. This ensures greater stability and reduces flakiness. The only scenario where this approach could fail is if no templates are available, which would be a product-level blocker rather than a test issue.
Fixes #36199
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/ci-test-limit-count run_count=20


Pass result into beforeSuccess callback along with request?

It would be nice if the result was passed in to this callback along with the request
https://github.com/SeasonedSoftware/remix-forms/blob/896ab6c5077918d19646f3f3c7017ac8f4c2b014/src/formAction.server.ts#L99
This would allow for something along the following lines:
export const action: ActionFunction = async ({ request }) =>
  formAction({
    request,
    schema,
    mutation,
    beforeSuccess: async ({ request, data }) => {
      const session = await getSession(request.headers.get("Cookie"));
      session.set("userId", data.userId);
      return redirect("/", {
        headers: { "Set-Cookie": await commitSession(session) },
      });
    },
  });

Would this be any better than just using performMutation directly? Seems like it might be a tiny bit nicer since by using beforeSuccess, the failure path doesn't need to be re-implemented.
export const action: ActionFunction = async ({ request }) => {
  const result = await performMutation({ request, schema, mutation });

  if (!result.success) {
    return json(result, 400);
  }

  const session = await getSession(request.headers.get("Cookie"));
  session.set("userId", result.data.userId);
  return redirect("/", {
    headers: { "Set-Cookie": await commitSession(session) },
  });
};

Edit: I think I do prefer to use performMutation directly for this case. I guess I am wondering what the ideal use-case for beforeSuccess would be but I'll go ahead and close this issue for now.

I'd also go for the performMutation option. I'm glad you were able to solve it!

Hey, @zkdiff! Thanks for creating this issue :D
I don't remember the exact use case I created beforeSuccess for, but it happened before we had performMutation available. After that, I've never used it again. Maybe we should deprecate beforeSuccess and recommend using performMutation anytime you need more fancy actions.
What do you guys think?

It does seem like beforeSuccess overlaps with performMutation but the latter provides more flexibility for sure. Would you also deprecate beforeAction? That would leave formAction for the "happy/simple path" and then if you need either an early response or need to do more fancy stuff, you can use performMutation directly.


fix(dashboard): Cross-filter search icon in filter bar

SUMMARY
Before, clicking the search icon in FilterBar to highlight cross-filter's source chart would grey out the whole dashboard and make it unclickable. This PR fixes that behaviour
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true

🏷 preset:2023.9


Change center and centerCanvas to defaultPosition and positionCanvas for more flexible placement options

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
The only option to control the default position of the canvas is the center prop. For my application, we would like the default position to be centered horizontally, but at the top vertically.
Issue Number: N/A
What is the new behavior?
The center prop has been replaced with defaultPosition, which can be center, top, left, bottom, or right. The centerCanvas function has been replaced with positionCanvas whose first argument is one of those 5 available positions. This can be expanded easily in the future as needed without additional breaking changes (e.g. adding top-right position).
Does this PR introduce a breaking change?
[x] Yes
[ ] No

Migration
Any users will need to replace center={true} with defaultPosition={CanvasPosition.CENTER} or defaultPosition='center'. Any calls to centerCanvas will need to be replaced with positionCanvas(CanvasPosition.CENTER) or positionCanvas('center').

Merged and release 5.0.4


SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports

Dear @crystal-lang team,
In first, I wish you a Happy New Year!

Note: @naqvis has already worked on a part here: https://github.com/naqvis/cr-xmpp
I think that he can added directly here:

SCRAM-SHA-1
SCRAM-SHA-256
SCRAM-SHA-512

Can you add in https://github.com/crystal-lang/crystal supports of:

SCRAM-SHA-1
SCRAM-SHA-1-PLUS
SCRAM-SHA-256
SCRAM-SHA-256-PLUS
SCRAM-SHA-512
SCRAM-SHA-512-PLUS
SCRAM-SHA3-512
SCRAM-SHA3-512-PLUS

You can add too:

SCRAM-SHA-224
SCRAM-SHA-224-PLUS
SCRAM-SHA-384
SCRAM-SHA-384-PLUS

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

SCRAM-SHA-1(-PLUS):
-- https://tools.ietf.org/html/rfc5802
-- https://tools.ietf.org/html/rfc6120

SCRAM-SHA-256(-PLUS):
-- https://tools.ietf.org/html/rfc7677 since 2015-11-02
-- https://tools.ietf.org/html/rfc8600 since 2019-06-21: https://mailarchive.ietf.org/arch/msg/ietf-announce/suJMmeMhuAOmGn_PJYgX5Vm8lNA

SCRAM-SHA-512(-PLUS):
-- https://tools.ietf.org/html/draft-melnikov-scram-sha-512

SCRAM-SHA3-512(-PLUS):
-- https://tools.ietf.org/html/draft-melnikov-scram-sha3-512

https://xmpp.org/extensions/inbox/hash-recommendations.html
-PLUS variants:

RFC5056: On the Use of Channel Bindings to Secure Channels: https://tools.ietf.org/html/rfc5056
RFC5929: Channel Bindings for TLS: https://tools.ietf.org/html/rfc5929
Channel-Binding Types: https://www.iana.org/assignments/channel-binding-types/channel-binding-types.xhtml
Channel Bindings for SCRAM over TLS 1.3: https://tools.ietf.org/html/draft-whited-tls-channel-bindings-for-tls13 -> https://tools.ietf.org/html/draft-ietf-kitten-tls-channel-bindings-for-tls13

LDAP:

RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

RFC7804: Salted Challenge Response HTTP Authentication Mechanism: https://tools.ietf.org/html/rfc7804

2FA:

Extensions to Salted Challenge Response (SCRAM) for 2 factor authentication: https://tools.ietf.org/html/draft-melnikov-scram-2fa

IANA:

Simple Authentication and Security Layer (SASL) Mechanisms: https://www.iana.org/assignments/sasl-mechanisms/sasl-mechanisms.xhtml

Linked to:

https://github.com/scram-xmpp/info/issues/1

Happy New Year to you as well!
Thanks for bringing this up. However, I can't make much sense of this largely uncommented collection of references.
I get that you propose adding a number of SCRAM-SHA algorithms to Crystal's standard library. I can find no comprehensible reason for that. Please detail why you think those should be added to the standard library (as opposed to being provided in a shard such https://github.com/naqvis/cr-xmpp).

@straight-shoota: Thanks for your reply and your wishes.
It is to replace old and unsecure DIGEST-MD5 included in this lib by SCRAM-SHA-* and SCRAM-SHA-*-PLUS.

https://github.com/crystal-lang/crystal/search?q=md5

I inform you that there are already 3 versions in cr-xmpp to help.
Of course you need to read, SCRAM informations are in this ticket and a list of libs/softs already compatible here:

https://github.com/scram-xmpp/info/issues/1

It is important to security because DIGEST-MD5 is obsolete and unsecure.

AFAIR Crystal's standard library does not implement CRAM-MD5 anywhere. The Digest namespace refers to hash digests in the general sense and is collecting different hash digest algorithms. What these then are then are applied for is outside the scope of the Crystal standard library. Removing any and all possibility to compute an MD5 hash digest does not seem reasonable. Likewise AFAIR there's no precedent for providing specific challenge response authentication mechanisms, so we need to have some actual good motivations brought forward to consider this.

Good comment from @konovod: https://github.com/crystal-lang/crystal/issues/11731#issuecomment-1008302600.
But here, the goal is to have SCRAM supports.
It is not possible to add?

It can be added if there's a good reason to have this in stdlib. I don't see such good reason. It's probably better placed in a shard.


Update Timeline “2022-06-16t15-40-38-831z-campaign”

Automatically generated by Netlify CMS

👷 Deploy Preview for 4shame processing.

Name
Link

🔨 Latest commit
02b192be77919aba12c67a1562a88fbb4e6989af

🔍 Latest deploy log
https://app.netlify.com/sites/4shame/deploys/6410af39a685ed0008771c22


Get click event of a Child Component under another one

Hi,
First of all, thanks for this wonderful job !
I have a child component for the user position and another one for a place.

I want to put the user over the place but that a problem because It catch clicks events.
What's the best way to let a click event pass through a child component?

Please read https://github.com/istarkov/google-map-react/blob/master/DOC.md#few-markers-with-hover-example-done-right
or to return infinite distance this part

@Titoine Let me know if you still need help with this.


Get constant of parent class even if child class is defined in signle…

…ton class; fix #3575

Thank you for fixing #3575.  But I found a variant of the issue and reported it as #3598.


Release notes for 3.0.0-alpha release.

Pull Request Test Coverage Report for Build 689

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.199%

Totals

Change from base Build 685:
0.0%

Covered Lines:
2494

Relevant Lines:
2796

💛  - Coveralls

Pull Request Test Coverage Report for Build 689

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.199%

Totals

Change from base Build 685:
0.0%

Covered Lines:
2494

Relevant Lines:
2796

💛  - Coveralls


Bump up delta lake version from 2.0.0rc1 to 2.0.0

Why are the changes needed?

https://github.com/delta-io/delta/releases/tag/v2.0.0
How was this patch tested?
Pass CI.

thanks, merged to master


Implement non_fast_start optimization in MP4 ISOM demuxer.

We need to wait until https://github.com/membraneframework/membrane_file_plugin/pull/40 is merged and new version of membrane_file_plugin is released, so that we can change the deps in this PR


improvement: substitute env variables in .fernrc

config:
   key: ${ENV_VAR}

Now ENV_VAR is substituted in the .fernrc.yml

This is epic!!


unused variable FP with forall syntax in signature

axiom Foo : ∀ (a : Nat), Prop
            -- ^ unused variable `a`

This warning does not happen when using the syntax axiom Foo : (a : Nat) → Prop. (This is supposed to be an exception to the usual unused variable rules because it is a function signature variable, visible in the docstring and also accessible via the Foo (a := 0) syntax.)
Occurs on latest nightly (leanprover/lean4:nightly-2024-11-24).

The linter actually ignores all dependent arrows. Seems a bit drastic but it would only be consistent if we ignored all forall binders as well then.


(225) Specification for a journey is shown as HTML

Changes in this PR
This is the first change to the codebase that starts to use the answers to the given questions to produce a specification document.
It is the first piece in what we imagine might be a series of changes. We would like the way specification documents are ordered, their show/hide logic and content to be controlled flexibly through Contentful. Right now, we are still working away on questions so the simplest first step was to prove we could do it when the Liquid was sourced from a local file. This reduces flexibility but enables us to start downloading documents to test with. It's imagined that we will eventually shed these files and replace them with calls to the Contentful API.
Currently we only have support for text and radio answers so I've picked those from the "Menus and Ordering" section from the documentation the content team have been preparing: https://miro.com/app/board/o9J_lb34sdM=/?moveToWidget=3074457352505653106&cot=14 and https://docs.google.com/document/d/1LAxX2ysWk3cBn3LOjkdjeKhx4S28p4pOSlk0EG2FLkU/edit#

we are starting with a basic HTML view of the spec, before moving onto other formats like .docx and .pdf
we use Liquid as a templating engine based on it's simple (relative to ERB) syntax which we believe the content team could pick up. The Ruby gem is also maintainted by Shopify and appears a mature and stable choice
the specification is rendered on the journey#show page for now as it was easy to implement given that's where the user ends their journey, it may have a different home in further iterations
we hard code Contentful entry IDs into the view templates, this introduces a problem because each environment uses a different Contentful environment. Each Contentful environment has unique entry IDs for its' steps. We will have to come back and create a catering.production.liquid when the entry IDs are all in place
to handle the case where specifications templates could be changed whilst a 'journey' was being progressed, we take a shallow copy of the template at the point the journey is started. This ensures the rendering of the spec should always be compatible with the questions presented to the user. It takes us toward our strategy of a forward facing world where users can build specifications but if they want the latest and greatest, they will get those changes in their next transaction. The dev team had a conversation about this before starting this work to agree that this was a good enough first pass
apply basic styling to HTML elements that appear in Liquid templates

This Liquid approach was first spiked in this branch.
Screenshots of UI changes

Next steps

wipe the test journeys from the staging and prod database to enable the migration to work
create a new catering.production.liquid file when the new entries are ready

@LornaHarwood @jacksonj04 I added a new commit here after noticing I wasn't doing any error handling in terms of receiving invalid Liquid.
As explained in the commit: I figured it would be best to check the validity of the Liquid template when the user attempts to start the journey. Failing loudly and sending another error to Rollbar. This is a blunt tool but ensures that we never have real journeys that are stuck in progress with invalid liquid templates that can never render.

@LornaHarwood @jacksonj04 I added a new commit here after noticing I wasn't doing any error handling in terms of receiving invalid Liquid.
As explained in the commit: I figured it would be best to check the validity of the Liquid template when the user attempts to start the journey. Failing loudly and sending another error to Rollbar. This is a blunt tool but ensures that we never have real journeys that are stuck in progress with invalid liquid templates that can never render.

The next step of adding the production template is going in because the entries have been created and are to use, just in time  🙌

The next step of adding the production template is going in because the entries have been created and are to use, just in time  🙌


feat(oauth2_provider): check for OAuth2ScopePermission on all APIViews

Add a check for OAuth2ScopePermission on all active views in an application.

ANSIBLE_BASE_OAUTH2_PROVIDER_PERMISSIONS_CHECK_IGNORED_VIEWS django setting
for setting ignores by class path.
Uses django's check framework, should be compatible with the related
functionality.
Set as a deployment check, so it will not block app startup.

AAP-26507

Manual testing info:
Start the test_app, run django-admin check --deploy --tag oauth2_permissions. Test this for any other client services you'd like. You will need to set ignores for non-DAB APIView's by appending to the ANSIBLE_BASE_OAUTH2_PROVIDER_PERMISSIONS_CHECK_IGNORED_VIEWS setting.


www not redirecting to /

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
arn:aws:amplify:eu-west-2:907988351006:apps/d202ti81rhqnnh
Region
eu-west-2
Step
Redirect
Status
Not Working
Issue or question
all www traffic is not redirecting to non www after having set up in rewrites and redirects. Is 200 the correct type for this use case?
Error message
No response
Additional information
No response

Hi @DeriDesign it looks like you properly configured the rewrite. For a 200 rewrite, the www url remains present but the content of the root domain is displayed: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html. Is this not the case for you?


update the documentation and UI of the quote-generator under react projects

I would like to update the documentation of the quote generator(under react projects) as well as its UI/UX. Kindly assign me this issue as this could be a great starting project for me and will also help future contributors to get started with the project. Thank you.

Sir I have made the changes to the UI and ReadMe.md file and made the pull request to the main branch of the  Dev-Geeks Repository.

@pranjay-poddar kindly review the PR that I have made and let me know if I need to make any changes or if there is anything wrong with the PR template.


Tools API: Prevent second OpenAI call when no tools used

Opt to return the initial model response directly.
During testing, it was observed that if the OpenAI model provides a high-quality response without utilising any tools, a subsequent call to the model tends to yield a significantly reduced quality in the "final" answer. To enhance efficiency and maintain response quality, this update avoids an unnecessary second invocation of the OpenAI model when no tools are engaged in the process.

The if statement in subsequent block (if (toolCalls.length > 0) {...} might not be necessary if this is accepted.

Perfect!


Okcurl upgrade and cleanup

Simpler nativeImage config with latest changes.

PS C:\Users\yuri\workspace\okhttp> .\okcurl\build\graal\okcurl.exe https://httpbin.org/get
Nov 13, 2020 8:03:46 AM sun.security.ssl.SSLLogger log
WARNING: Ignore impact of unsupported extension: ec_point_formats
Nov 13, 2020 8:03:46 AM sun.security.ssl.SSLLogger log
WARNING: Ignore impact of unsupported extension: application_layer_protocol_negotiation
Nov 13, 2020 8:03:46 AM sun.security.ssl.SSLLogger log
WARNING: Ignore impact of unsupported extension: renegotiation_info
{
  "args": {},
  "headers": {
    "Accept-Encoding": "gzip",
    "Host": "httpbin.org",
    "User-Agent": "okcurl/4.10.0-SNAPSHOT",
    "X-Amzn-Trace-Id": "Root=1-5fae3de3-439109d6618b209f3f9496af"
  },
  "origin": "<IP_ADDRESS>",
  "url": "https://httpbin.org/get"
}
Nov 13, 2020 8:03:46 AM sun.security.ssl.SSLLogger log
WARNING: SSLSocket duplex close failed

Curious about this "WARNING: Ignore impact of unsupported extension: application_layer_protocol_negotiation".  But I've seen it working.


Strict type checking and linting

Turned on strict mode in tsconfig
Added typescript linters to check unsafe type usages
Some changes are done by yarn lint --fix

This is very much needed. This bug in Diana should've been caught by TS or eslint. https://github.com/openspacelabs/diana/pull/4982