Add Github Action workflow to release a new version

Workflow to automatically increment the version (based on Changelog entries and current version in package.json), tag the commit, publish to npm and generate the Github release notes.
The Workflow is almost identical to our yospace integration: https://github.com/bitmovin/bitmovin-player-web-integrations-yospace/blob/develop/.github/workflows/release.yml
In the Yospace repo, the release workflow was already tested successfully, except for auto-generating the github release notes which was added after the last release.

@karpov-kir not sure what you mean regarding the tag 🤔
I can see the 5.1.0 tag:

as well as the release:

(I also always generate the release from the tag)


EndpointCertificate  does not support X509FindType="FindBySubjectName"

Hi,
In the EndpointCertificate of the ApplicationManifest file the attribute "X509FindType" is used.
  <Certificates>
    <EndpointCertificate Name="SslCertByTP" X509FindValue="FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF F0" X509StoreName="MY" />
    <EndpointCertificate Name="SslCertByCN" X509FindType="FindBySubjectName" X509FindValue="ServiceFabric-EndpointCertificateBinding-Test" X509StoreName="MY" />
  </Certificates>

However according to the schema this is not a valid attribute and the schema states that the findValue is "The thumbprint of the X509 certificate".
Schema:
https://github.com/microsoft/service-fabric/blame/master/src/prod/src/ServiceModel/xsd/ServiceFabricServiceModel.xsd#L274

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94aa1985-f344-537c-ba38-d5a9a1626a4d
Version Independent ID: 5d685dd3-dc6b-879c-202c-c20d1fe21066
Content: Specifying Service Fabric service endpoints - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-service-manifest-resources.md
Service: service-fabric
GitHub Login: @erikadoyle
Microsoft Alias: edoyle

@eoinwhelan
Thanks for your feedback! We will investigate and update as appropriate.

@erikadoyle
Can you please check and add your comments on this doc update request as applicable


the setPassword.sh script is not called from the install script

The copied setPassword.sh script is not called from the main install.sh.
I added the following line after line 82 to make it work:
sudo su - oracle -c "/home/oracle/setPassword.sh $ORACLE_PWD
I'm no script wizard, but this worked for me.

@taseroth The enhancement that allows the installer to run user-defined SQL and/or shell scripts after initial database setup is now available. If you clone this repository again (or merge the changes into your local repo), you'll see a new directory called userscripts under the 18.4.0-XE directory. Any SQL and/or shell scripts you put into the userscripts directory before running vagrant up the first time will be run automatically. So, you could add a create_users.sql script containing the SQL that you need. The functionality is described in README.md, as well as in a file called put_custom_scripts_here.txt in the userscripts directory.
I hope this helps!

We have also added clarification as part of PR #111


Default to port 443 for all vsphere actions, not just creation

Fixes #3150 and probably #3024 following the new gvmomi code in 0.5.5.
Signed-off-by: Tristan Keen<EMAIL_ADDRESS>

cc @frapposelli

LGTM

looks great :+1:


Prepare Config for Use in Chainlink Repo

Config Loading Options
We had a similar style to this config loading setup earlier on in the project; we moved away from it because it was annoying having to specify the config. Well, we're back. The idea is to move the test suite into the main chainlink repo, and in order for things like reading the config, and recording log files properly, there doesn't seem to be many ways around just providing the config path.
Other Attempts
I open the floor for discussion, as I've tried a few different ways to do this, and they didn't pan out. All attempts to automatically sense the directory from where the calls were being made led to one of the following.

It kept defaulting to the integrations-framework library
The root directory was assumed to be some compiled Ginkgo binary in a randomly generated var folder
The calling file was an internal Ginkgo runner
Getting the current working directory, which is obviously great if you are calling tests from the proper directory. Not such a great solution otherwise.

So I'm left at this option, which works fine, tests are running in the chainlink repo. But it feels icky.
Usage
Addition of this setup action
// DefaultLocalSetupSpecifyConfig gives a default testing environment setup with a specified config file path
func DefaultLocalSetupSpecifyConfig(
	envInitFunc environment.K8sEnvSpecInit,
	initFunc client.BlockchainNetworkInit,
	configPath string,
) (*DefaultSuiteSetup, error) {
	s, err := DefaultLocalSetup(envInitFunc, initFunc)
	if err != nil {
		return nil, err
	}
	specifiedConf, err := config.NewConfigWithPath(config.LocalConfig, configPath)
	if err != nil {
		return nil, err
	}
	s.Config = specifiedConf
	return s, err
}

Example usage in a BeforeEach block I've setup for the main chainlink repo:
BeforeEach(func() {
  confFileLocation, err = filepath.Abs("../") // Get the absolute path of the test suite's root directory
  Expect(err).ShouldNot(HaveOccurred())
  suiteSetup, err = actions.DefaultLocalSetupSpecifyConfig(
	  environment.NewChainlinkCluster(1),
	  client.NewNetworkFromConfig,
	  confFileLocation,
  )
  Expect(err).ShouldNot(HaveOccurred())
})

The example usage and code looks good. I think we should probably move your example usage into the readme.
Should we be adding unit tests to our test framework pieces like the config?

@tateexon Thanks, I agree on adding examples to the README, will put that in with this branch. Also yes on the unit tests, we've been holding off on large amounts of unit testing while the project is still in so much flux, but we're probably hitting a stable enough point now to start adding them.


Allows to edit data scan time in container configuration

Hi
Allows to edit data scan time in container configuration

Hi @truongbber ,
what do you need this for? It is just for the UI.
The backend has live updates to sync the status to matter.


PLFM-4937

give more reasonable error message when deleting a usergroup referenced by an existing object (like an ACL)

Good job!!


Race condition in debian initscript at least up to docker 1.5.0

For some system startups I get the following error output on rebooting my machine:
Mon Jul  6 11:00:46 2015: [....] Starting Docker: docker ok
Mon Jul  6 11:00:46 2015: [....] Starting OpenBSD Secure Shell server: sshd ok
Mon Jul  6 11:00:46 2015: [....] Starting MTA:Post http:///var/run/docker.sock/v1.17/containers/redis/start: dial unix /var/run/docker.sock: no such file or directory. Are you trying to connect to a TLS-enabled daemon without TLS?
Mon Jul  6 11:00:46 2015: Error: failed to start one or more containers

Docker is started ok, but not right when the initscript says: Starting Docker: docker ok. It is most probably not ready then, but a little bit later.
Sometimes when the filesystem on my VM is not yet cached by the host I experience this error.
On our production server with rotating disc memory I had to add a sleep 10 to the script that will setup our environment after a reboot. Otherwise docker would not be ready.
The start script is placing docker as a required dependency and seems to do the right thing:
#!/bin/sh

### BEGIN INIT INFO
# Provides:	dockermachines
# Required-Start:       docker
# Required-Stop:	docker
# Default-Start:	2 3 4 5
# Default-Stop:         0 1 6
# Short-Description:	docker web server environment
### END INIT INFO

# do the startup ...

Steps to reproduce:

/etc/init.d/docker stop
rm /var/run/docker.sock
/etc/init.d/docker start && ls /var/run/docker.sock

This should give the following output:
[ ok ] Starting Docker: docker.
ls: cannot access /var/run/docker.sock: No such file or directory

/var/run/docker.sock is created eventually.
 I did a quick check for 1.7.0. Startup seems to be much quicker now. When I can always reproduce with 1.5.0, I only get it every other try with 1.7.0. But the race condition still seems to exist in 1.7.0.

Thank you for your report. I'm sorry the issue didn't get much attention recently: can you please test again with the latest version of Docker and let us know if this is still an issue? Thanks!

I just ran it against docker 1.11.2 at home on a Debian Stretch VM on a 2016 MacBook with quite wide IO bandwidth. I can not reproduce the behaviour. I will check on a rotating media later this day.

On Debian jessie the behaviour is not reproducible. The problem still exists for Debian wheezy and  the most recent docker 1.12.1. So I guess the problem is tied to the shell init scripts and not present in systemd based boot environments.

The init scripts used for our packages can be found here; https://github.com/docker/docker/tree/master/contrib/init
ping @tianon is this something that can/should be addressed?


nivil.rb returns empty error message while running do-scan

bin/do-scan --workspace testscan -scan bigpoint.net -v
Starting scan 'mysystem.net' from workspace 'testscan'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/Nessus/scan --workspace 'testscan' --scan 'bigpoint.net' -s <IP_ADDRESS> -u seccubus -password '@PASSWORD' --policy default --hosts '<IP_ADDRESS>' --pw 'foobar'  -v
Lets see if you have Ruby on your system
Timestamp =<PHONE_NUMBER>1851
Attempting to find policy ID for policy default
Execuing /opt/seccubus/scanners/Nessus/nivil.rb -u 'seccubus' -p '@PASSWORD' -s '<IP_ADDRESS>' --port 8834 --show-policies
Could not find policy id for policy default at /opt/seccubus/scanners/Nessus/scan line 137.
error
Sending notifications for scan end...
0 notification(s) sent
cmd: /opt/seccubus/scanners/Nessus/scan --workspace 'testscan' --scan 'mysystem.net' -s <IP_ADDRESS> -u seccubus -password '@PASSWORD' --policy default --hosts '<IP_ADDRESS>' --pw 'foobar'  -v
Lets see if you have Ruby on your system
Timestamp =<PHONE_NUMBER>1851
Attempting to find policy ID for policy default
Execuing /opt/seccubus/scanners/Nessus/nivil.rb -u 'seccubus' -p '@PASSWORD' -s '<IP_ADDRESS>' --port 8834 --show-policies
error
Done
########
Running the ruby script manually and enabling to print the request returns:
/opt/seccubus/scanners/Nessus/nivil.rb -u 'seccubus' -p 'foobar' -s '<IP_ADDRESS>' --port 8834 --show-policies
{"login"=>"seccubus", "password"=>"foobar"}
error
I cannot get the Nessus Scan to run. Furthermore, I cannot see a button in the web frontend to run a scan. What do I miss?

Yes, this solved the issue. Many thanks. However, I found another bug:
https://github.com/schubergphilis/Seccubus_v2/issues/165
Kind regards. Will continue testing.


X509 error

We use github.com/jinzu/gorm to connect to cloudsql instances. It itself uses cloudsql-proxy. Without changing anything, as of a day or so, our instance names that are fed into the cloudsql proxy package have remained of the format: projectid:region:name. However, when trying to connect we get an error of the form:
x509: Common Name is not a valid hostname: projectid:name"

(real connection values omitted)
Notice that the region part has been stripped somewhere and I've checked what we feed into it and what gorm passes to the cloudsql-proxy package and they both contain the region.
Is anyone experiencing the same issue or can see what's wrong?

We're seeing that same and downgrading to Go 1.10 fixed the issue for us so it seems Go 1.11 is where the issue arrises

This was fixed; but, not yet released. We are downgrading to go 1.10 until the fix is released. Alternatively, you could try using master for cloudsql-proxy temporarily if you need to use go 1.11.

See #194 and #196.

@arbarlow, @forrestdix
Thanks for the info. I just set the docker image to use go 1.10 and as expected it works. I'll keep an eye out for the release. Given this is a kind of dupe of #194 and #196 I suppose this can be closed.


ci

Adding a simple github workflow. Main points:

remove the implicit dependency on /usr/bin/ld.gold. If we want that, it should be a config-like option in the Makefile. @mikesart can you help me understand why it's desirable in the first place?
fix the Dockerfile.
D_LIBCPP_DEBUG has been deprecated and replaced with D_LIBCPP_ENABLE_DEBUG_MODE in the clang version we use. I am not sure if we intend to run the debug build on ancient versions of gcc which do not have that option. Accepting feedback.

You can preview a sample workflow run here: https://github.com/motiejus/inotify-info/actions/runs/7842103734

I'm fine removing the gold linker entirely. I've used it in the past on other projects because it was significantly faster, but that obviously shouldn't matter for a project this small.
Would it be ok to just define _LIBCPP_DEBUG and _LIBCPP_ENABLE_DEBUG_MODE and have it work for old and newer versions?

I'm fine removing the gold linker entirely. I've used it in the past on other projects because it was significantly faster, but that obviously shouldn't matter for a project this small.
Would it be ok to just define _LIBCPP_DEBUG and _LIBCPP_ENABLE_DEBUG_MODE and have it work for old and newer versions?

Done.


Spaces appended on the certificate content in IAM management console service providers' edit functionality

To recreate the issue

Create an application in the store.
Log in to IAM management console.
Under service provider click the edit button of any service providers
You can see extra spaces appended at the end of the certificate content in Application certificate
Remove the spaces and update
Redo the above flows and you can see the spaces appended again

If the certificate is updated (by removing the spaces) in step 4 successfully the request flow works fine but if you click the edit button again the spaces are appended, which means every time the page loads on the edit function the spaces are appended at the end of the certificate content.

@DivyaPremanantha it is not reproducible with default IS 5.8.0 pack hence closing the issue.


Starting server plugin best practice doc

This is to cover docs for https://github.com/mattermost/mattermost-server/pull/10476

@hanzei please help with initial review.

@hanzei addressed some of the feedback, would you be open to helping with the first two?

Merging in preparation for June 16th release. Changes also merged to demo and sample plugin.


alpha version of xml2fdp

depend on xml2csv package
install:
$ git clone https://github.com/wk0206/xml2csv
$ npm install -g

@HimmelStein I see the tests for this change are not passing.
Can you take a look and see that they do? If needed, you can install dependencies in the .travis.yml file.

failures are due to the missing of xml2csv command
please run install xml2csv package on the local machine:
$ git clone https://github.com/wk0206/xml2csv
$ npm install -g

@akariv failed to run "npm install -g"
log message is that: Permission denied.  fatal: Could not read from remote repository.
however, I can execute "npm install -g" on my local machine.

Changes Unknown when pulling 3ad5bce7fe11011f27c37c0d03139e3817659369 on openbudgets:master into ** on openspending:master**.

Changes Unknown when pulling 52c64346d2b3e2a59fefc3b9bb95c185c16d5df3 on openbudgets:master into ** on openspending:master**.

Changes Unknown when pulling 2b307a2ef3aa1c2098b348e2b5690937ed4bd956 on openbudgets:master into ** on openspending:master**.

Changes Unknown when pulling 22373ea7d55602dca6c4798d600c6e0f5afdb1c2 on openbudgets:master into ** on openspending:master**.


Swift error: Failed to extract ServerMetadata from context

Hello,
I installed swift in my k8s cluster which is running Tiller version 2.7.0-rc1. When I try to call it I get the following error:
curl <IP_ADDRESS>:9855/tiller/v2/version/json`
{"code":4,"message":"context deadline exceeded"}

The pod logs show this:
1016 13:45:17.336235       7 server.go:89] [PROXYSERVER] Sarting Proxy Server at port [::]:9855
I1016 13:45:17.336282       7 server.go:168] Registering endpoint: RegisterReleaseServiceHandlerFromEndpoint
I1016 13:45:17.336327       7 server.go:120] Registering server: *release.Server
2017/10/16 13:46:10 Failed to extract ServerMetadata from context
2017/10/16 13:46:17 Failed to extract ServerMetadata from context
2017/10/16 13:46:29 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: dial tcp: operation was canceled"; Reconnecting to {tiller-deploy.kube-system:44134 <nil>}

So swift itself seems up and running, but the connection to tiller does not seem to work. The tiller endpoint (tiller-deploy.kube-system:44134) seems to be right.
What puzzles me though is the Failed to extract ServerMetadata from context part. Is this because I am running tiller 2.7.0-rc1 or is this not relevant?
FWIW, my local helm client runs just fine against tiller.
Thanks for reading,
-naivenut

@naivenut , what is the version of your Kubernetes cluster? I have tried Tiller version 2.7.0-rc1 with Swift 0.3.1 . It seems to work for me.

I have pushed 0.4.0-rc.0 for Helm 2.7.0-rc.1 . Please try that if you are still having issues.

Thanks for looking into this!
I've reproduced this on a different machine now which has the same setup. I am using swift 0.4.0-rc.0. Kubernetes version is 1.7.6.
I have deployed Kubernetes via Rancher 2.0, see http://rancher.com/docs/rancher/v2.0/en/quick-start-guide/ . It's basically running a single docker container that will create a system identical to mine.
Is there anything else I can do, e.g. running with debug flags or something?

Hmm, might this be related to https://github.com/rancher/rancher/issues/10105 or what does ServerMetadata exactly do?

You can increase log level by setting --v= flag. https://github.com/appscode/swift/blob/27d961dc386eef482127338d8000b3439085fb50/hack/deploy/without-rbac.yaml#L17
Raise the log level to --v=8 temporarily and show us me the detailed error message. I am not familiar with Rancher and how it affects Tiller/Kubernetes.

Closing, since there is no user response. Please reopen if the issue persists.

Just for the record, I found the solution. It seemed like DNS was not working inside the container thus it could not resolve "tiller-deploy.kube-system" to its IP.
After I installed kube-dns in Rancher and re-installed swift things started to work. I suspect that the DNS resolution Rancher 2.0 alpha has out of the box at the moment does not really work (or I did not understand things properly).
So thanks for creating Swift, it's cool to finally see the tiller json api :-)

@Nitrogenycs, glad that you identified the problem and fixed it! Thanks for letting us know.

I am having a similar problem (found this via a search on the pod log).  I can get it to work fine with a payload using curl but I am having problems when POSTing a payload via JS request.
Basically I think the problem is me manipulating the payload data submitted like so:
getReleaseConfig(releaseName, (data, err) => {
  if (err) {
    console.log(err);
  } else {

    let payload = {
        "chart_url": "<URL REDACTED>z",
        "namespace": newReleaseName,
        "values": {
          "raw": data
        }
      };
    console.log(JSON.stringify(payload));

    let postUrl = 'http://localhost:1337/tiller/v2/releases' + newReleaseName + '/json';
    request(
      {
        url: postUrl,
        form: JSON.stringify(payload),
        method: 'post'
      }, (err, httpResponse, body) => console.log(err, body));
    };
});

To be clear - I am extracting the deployment raw data via the swift API and then converting to a JSON object so I can extract the text for the particular deployment I want.  This is the callback for the request GET of the deployment (Hope that makes sense)


find: warning: you have specified the global option -depth after the argument -type, but global options are not positional, i.e., -depth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments. find: paths must precede expression: `2'

double post


Use response from one service as header value in another request.

I'm wondering if it is possible to use request response as header value in another request.
Exemplary use case:
User wants to communicate with Service A. User has auth token (from Auth Service, token is later called X-Token) which can be exchanged for different token that is respected by Service A.
User calls Service A with header X-Token, request goes to krakend and krakend exchanges in external Auth Service token for different token and then forwards this token with request to Service A.
Is it possible to do with krakend?

nvm, searching for whole day and couldn't find, 5 min after opening issue found this...
https://www.krakend.io/docs/endpoints/sequential-proxy/


[SUPPORT] flink sql write to hudi fail

no output from hoodie_stream_write
env: hudi 0.8.0 + flink 1.11.3
sql script
create table hudi_on_flink_test_source(
	uuid VARCHAR(20),
	name VARCHAR(10),
	age INT,
	ts TIMESTAMP(3),
	`partition` VARCHAR(20),
	WATERMARK FOR ts AS ts
)with(
  'connector' = 'kafka',
  'topic' = 'hudi_on_flink_test',
  'properties.group.id' = 'hudi_on_flink_test',
  'properties.bootstrap.servers' = '<IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092',
  'format' = 'json',
  'scan.startup.mode' = 'timestamp',
  'scan.startup.timestamp-millis' = '1631955600000'
);

CREATE TABLE hudi_on_flink_test_sink(
uuid VARCHAR(20),
name VARCHAR(10),
age INT,
ts TIMESTAMP(3),
`partition` VARCHAR(20)
)
PARTITIONED BY (`partition`)
WITH (
 'connector' = 'hudi',
 'path' = 'hdfs://hzwtest/tmp/bertram/hudi_on_flink_test1',
 'table.type' = 'MERGE_ON_READ'
);

insert into hudi_on_flink_test_sink select * from hudi_on_flink_test_source;

Hi, you may need to use the 0.9.0 with flink 1.12.2 or master with flink 1.13.1. You also need to open the checkpoint.

Hi, you may need to use the 0.9.0 with flink 1.12.2 or master with flink 1.13.1. You also need to open the checkpoint.

tks,i will try again,I think the official website suggests that version 1.11. X is supported

Oops, it is a mistake, i have updated the document.

@t822876884 Hi, did you manage to resolve your problem?

@t822876884 Hi, did you manage to resolve your problem?

This issue requires a checkpoint to work with, the flink sql checkpoint requires its own code changes


File ArchiveEvery Day/Minute... is ignored when using rolling numbering

Noticed another possible bug when trying to get around the issue with the wrong archive files getting deleted.
With version 4.0.1 using the following code the log archiving function ignores the rollover from one day to another and continues to write the new log messages into the file started the other day.
fileTarget.FileName = updateLogDirectory + logName + ".log";
fileTarget.ArchiveFileName = updateLogDirectory + logName + ".{##}.log";
fileTarget.KeepFileOpen = false;
fileTarget.ArchiveNumbering = ArchiveNumberingMode.Rolling;
fileTarget.ArchiveEvery = FileArchivePeriod.Day;
fileTarget.MaxArchiveFiles = 30;
fileTarget.ArchiveAboveSize = 1048576; // 1 MB
fileTarget.Layout = "${longdate}|${message}";

Thanks for reporting!
Can you give an example? I don't fully understand it. It this also an issue with ArchiveEvery minute (for unit testing)

It's the same using the minute option.
The created Log looks something like this (just a quick test application):
2015-08-17 22:54:59.9677|Something_Created : C:\*\*\28995.txt
2015-08-17 22:54:59.9887|Something_Created : C:\*\*\28996.txt
2015-08-17 22:54:59.9947|Something_Created : C:\*\*\28997.txt
2015-08-17 22:55:00.0177|Something_Created : C:\*\*\28998.txt
2015-08-17 22:55:00.0177|Something_Created : C:\*\*\28999.txt
2015-08-17 22:55:00.0317|Something_Created : C:\*\*\29000.txt

Just noticed that it works every other minute but not consistently or remotely predictable.

OK clear! Thanks!

Possibly related to #550

Thanks! They seem the same issues indeed


[question] where to place custom SCSS files?

Hey there,
The documentation states,

scss/foundation.scss: Imports for Foundation components and your custom styles.

What is the optimal/default location to place my custom .scss files? Should I place them directly into the bower_components/foundation/scss folder? wouldn't they be overwritten if I update Foundation in the future? What is the proper location?
Thanks! great work by the way :-)

Personally, I use the site folder.
scss/foundation.scss
When you open that file, there is a place at the bottom that says
/*
My custom styles:
Add your own folders and scss files for your project and import them below
*/
You can place your files anywhere that you feel is most optimal, and then just use @import and a relative path to access it, below that comment area.
I do everything directly in the scss/site folder since it is right there at the foundation.scss

Ahh, I was looking in the wrong foundation.scss file, that explains it. I think I'll follow your lead and keep mine in the scss/site folder as well, thanks.


No response on Apple devices

The Leaflet.fullscreen works as-expected on Windows and Android devices, however it does not work on Apple devices (iPad and iPhone) across multiple browsers (e.g. Safari and Chrome).
However, using developer tools in emulation mode the button works as-expected.
Anyone else encounter this as well, or know why this may be happening?

No one else has reported this issue; I assume it is something specific to your page. If you are still encountering it, please provide a minimal self-contained example that demonstrates the issue.

For future reference, make sure you checkout what fullscreen actually does on iPhone devices by visiting https://leaflet.github.io/Leaflet.fullscreen/ with your iPhone.
You will see that fullscreen mode only stretches the map to the edges of the webpage without hiding the status bar the tab bar etc...


PanDatFactory._same_data has a minor flaw

Just testing code, but if you the same set of rows are duplicated, then it thinks the data is the same, but really it isn't.
Study the implementation, you'll see why. It removes duplicates before checking

Fixed in here


State contracts

What changed

added state contracts importer
added seed/test data
tests

Issues

closes #392

Please add html5shiv.js to the .gitignore and repush


td-agent-v4: Drop Debian buster

It reaches EOL already.

It's already tested for td-agent-v4 branch in https://github.com/fluent/fluent-package-builder/pull/447.
To narrow the scope of https://github.com/fluent/fluent-package-builder/pull/447, I've separated the commit to this PR.


fix: fixed destroyOnComplete animation

Hi,
Notice that "destroy on complete" didn't keep the confetti particles when you changed its state. So, I've simply added two more CSS variables, which are "--destroy-opacity" and "--fill-mode". These variables handle the final opacity of the animation and set the fill-mode to "forwards", depending on whether "destroyOnComplete" is true or false, in order to keep the particles at the end of the animation.

Hi,
I have not understood the implementation you mentioned very well. I cannot see how the user could toggle between keeping the particles without altering the value of the "destroyOnComplete" prop. Could you please explain it to me a little more?
According to the documentation, it mentions that it is necessary to modify the value of the "destroyOnComplete" prop to "false" to keep the particles at the end of the animation since it is set to "true" by default.

In my implementation, the user would have to send the value "false" to "destroyOnComplete" to keep the particles at the end of the animation, and it only uses ccs variables and the ? operator to toggle the style, similar to the ones already implemented.
<Confetti destroyOnComplete={false} />

I hope this clears up a bit of what I did, but I would really like to hear more of the comment you gave me. :)

Your current implementation might lead to unexpected behaviour for people already using it. By using just css variables with the default value set to the current value it can be set independently from the destroyOnComplete property. You can then set it your own css using something like
.confetti {
 --destroy-opacity: 1;
 --fill-mode: forwards;
}

Closing as it's outdated


Expansion of args does not use temporary file

neomake#utils#ExpandArgs does not use any temporary file (when enabled and used).
This is OK for something like %:h where it should use the non-temporary file (which is usually in another directory), but we should provide a way to get to the actual (temporary) file being used.
I've thought about adding something like %f which would get expanded before any other expansions.
There is no way to use modifiers on it then though.

See https://github.com/neomake/neomake/pull/1192 for something that might help here.

Let's consider https://github.com/neomake/neomake/pull/1207 to be an appropriate / good enough fix for this for now.


Refactoring Wishlist

extract interface from class, module, or function
copy type from variable
implement stub (to enable "use first" programming flow).  doStuff(p1 : string) doesn't exist on MyClass - would you like to implement it?
"Declare this" refactoring on an instantiated variable.
Declare all refactoring on a constructor function

Courtesy @nycdotnet https://github.com/TypeStrong/atom-typescript/issues/59#issuecomment-73228618

Wishlist

[ ] rename file module (this is a big pain and the reason why we added ///ts:import transform in the first place)

I think I would volunteer for 'extract interface from class, module, or function'

Feel free if you want a challenge.  That'd be great!

:+1:

BTW: Any ides how to handle settings for the quickfixes. e.g. sort methods names yes/no ?

There is already a settings dialog for atom-typescript, though I would strongly suggest trying to avoid anything that would require using it.
In the situation you've provided - extract interface - perhaps have the interface members come out in the order they're declared (if that can be determined) and provide a new refactoring "sort interface properties alphabetically".

The ordering was just an example. I think that it should be possible to customize the behavior of the quickfixes and that it should be a per project setting. I would prefer a section in the tsconfig.json file, but I do not know if this is possible and (or) allowed.

Just wondering how the file path in a Quickfix result is supposed to work. If I return the following result test2.ts is opened and then I get an unhandled promise exception with TypeError: Cannot read property 'transact' of undefined.
 result = {
            span: {
                start: 0,
                length: 5
            },
            newText: "hello",
            filePath: "test2.ts"  // does not exist yet
};

Any ides how to handle settings for the quickfixes. e.g. sort methods names yes/no ?

Two solutions (neither implemented yet) :
1.) Allow the quick fixes to add a UI (https://github.com/TypeStrong/atom-typescript/blob/674ea18a76d9765d35bf9359269b2e73d3029113/lib/main/atom/commands/commands.ts#L423)
Basically run the quickfix code in the ui thread to generate a UI. Since creating atom UI's is a bit hard try not to do this :)
2.) Return multiple quick fixes from a single canProvideQuickFix. And then pass in the selected version to applyQuickFix.
I am leaning toward this because I already see need for this e.g. readonly vs read-write properties can come from same quickfix file.

I would prefer a section in the tsconfig.json file, but I do not know if this is possible and (or) allowed.

Not yet. I've already polluted tsconfig.json too much. Will clean up before I start adding more stuff (https://github.com/TypeStrong/atom-typescript/issues/324)

does not exist yet

This is not supported. It needs to be a file on the file system (that's how quick fixes have worked up until now). All the code is in here : https://github.com/TypeStrong/atom-typescript/blob/674ea18a76d9765d35bf9359269b2e73d3029113/lib/main/atom/commands/commands.ts#L33-L61
Currently it has "open files" and "closed files" : https://github.com/TypeStrong/atom-typescript/blob/674ea18a76d9765d35bf9359269b2e73d3029113/lib/main/atom/commands/commands.ts#L34-L39 Consider adding "new files" to this list as well.

Is there any progress on the extract interface feature?

Is there any progress on the extract interface feature?

Nope. However I would hold off on it since the TypeScript team is planing official support for quick fixes :rose:

@basarat So can we do this now yet?

@chriszrc if people add them to TypeScript, they will show up in all IDEs 🌹:
https://github.com/TypeStrong/atom-typescript/blob/master/README.md#quick-fix

@basarat So that's a no? I might actually have to finally crack open vs code :(

@chriszrc see if whatever you need is implemented in tsserver: https://github.com/Microsoft/TypeScript/tree/master/src/services/codefixes. If it is, ctrl+enter (if using intentions -- intentions:show command) or alt+a (if using atom-ide-ui -- diagnostics:show-actions-at-position command) when the text cursor is close to the thing you want fixed, a menu will pop up. If it does not work, open a new issue. If it's not implemented in tsserver, chances are it won't work in vscode either.


[BUG] Returning BlobItem from a REST call gives an Error due to Creation-Time is a non-Seralizable class (DateTimeRfc1123).

Returning a BlobItem from a REST call gives an Error due to Creation-Time type not being serializable. Values are there, but error when trying to return on API.
Sample Code:
@RequestMapping("/listblobs")
public @ResponseBody List<BlobItem> listBlobs(String containerName) {

    ContainerClient containerClient = getContainerClient(containerName);
    ListBlobsOptions options = new ListBlobsOptions();
    options.maxResults(10);
    Iterable<BlobItem> blobs = containerClient.listBlobsFlat(options, null);

    List<BlobItem> blobList = new ArrayList<BlobItem>();
    blobs.forEach(item->blobList.add(item));

    return blobList;
}

Error Message:
"message": "Type definition error: [simple type, class com.azure.core.implementation.DateTimeRfc1123]; nested exception is com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer found for class com.azure.core.implementation.DateTimeRfc1123 and no properties discovered to create BeanSerializer (to avoid exception, disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain: java.util.ArrayList[0]->com.azure.storage.blob.models.BlobItem["Properties"]->com.azure.storage.blob.models.BlobProperties["Creation-Time"])",

@millerna26 thank you for reporting this. Just to clarify, if you're seeing deserialization issues, I imagine that's happening on the line where you call listBlobsFlat?

@jianghaolu or @alzimmermsft any insight on this?

Everything actually works until the return. I believe it is a compatibility issue with Spring Boot framework. I see the value in debug up to the return call. When I turn the setting off per error message, I just get an empty date field on the return, but everything else works.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Rick Ley<EMAIL_ADDRESS>Sent: Monday, August 12, 2019 5:06:08 PM
To: Azure/azure-sdk-for-java<EMAIL_ADDRESS>Cc: Nathan Miller (CSE<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-java] [BUG] Returning BlobItem from a REST call gives an Error due to Creation-Time is a non-Seralizable class (DateTimeRfc1123). (#4936)
@jianghaoluhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjianghaolu&data=02|01|nathan.miller%40microsoft.com|11c01dbba1ac42fad78c08d71f820b6f|72f988bf86f141af91ab2d7cd011db47|1|0|637012517119149554&sdata=LChwX6nsmRIdK6zLCn3rv%2BlKmLt5uieDMUShsI7cy8w%3D&reserved=0 or @alzimmermsfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falzimmermsft&data=02|01|nathan.miller%40microsoft.com|11c01dbba1ac42fad78c08d71f820b6f|72f988bf86f141af91ab2d7cd011db47|1|0|637012517119149554&sdata=yupkwRenRU%2BsFb%2FGyUfkHpjP8SYDRoJNuv%2B41N3VbKU%3D&reserved=0 any insight on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-java%2Fissues%2F4936%3Femail_source%3Dnotifications%26email_token%3DAAMER5ULLWNUDYTNG5ED2DLQEH3HBA5CNFSM4IKYE5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4EFHSY%23issuecomment-520639435&data=02|01|nathan.miller%40microsoft.com|11c01dbba1ac42fad78c08d71f820b6f|72f988bf86f141af91ab2d7cd011db47|1|0|637012517119149554&sdata=36PUc6aV9nacODbyRXcHJuHlwM8SoNPB2M2PaF0xx2w%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAMER5SAVUXPPYJSNWIT33TQEH3HBANCNFSM4IKYE5EQ&data=02|01|nathan.miller%40microsoft.com|11c01dbba1ac42fad78c08d71f820b6f|72f988bf86f141af91ab2d7cd011db47|1|0|637012517119149554&sdata=IXsMwuwutGbtmAmwLDgzvB5XHhs97K92CaDRtfnvH68%3D&reserved=0.

@millerna26 Which version of azure-storage-blob are you using in this example?

@alzimmermsft 12.0.0-preview.2

I created this simple reproduction to investigate this issue, was this similar to what you were using?
Debugging Projects.zip

Yes, that looks very similar to the code I have.

@millerna26 Have you been able to make any progress on this? From some discussions over here, it looks like it might be an issue with Spring more than the Storage SDK, but if you think otherwise, we can take a look at this again tomorrow.

One workaround I did was to create my own class that I will be copying fields I need from BlobItem then use that class in the return.
custom class Blob:
import java.time.OffsetDateTime;
import com.fasterxml.jackson.annotation.JsonAutoDetect;

@JsonAutoDetect(fieldVisibility = JsonAutoDetect.Visibility.ANY)
public class Blob {
	private final String name;
	private final OffsetDateTime createDate;
	private final Long size;
…
Have public getters for each.

In API Controller Instead of this:
//List<BlobItem> blobList = new ArrayList<BlobItem>();
//blobs.forEach(item->blobList.add(item));

Load to Custom Class and return.
List<Blob> blobList = new ArrayList<Blob>();
blobs.forEach(item->blobList.add(new Blob(item.name(), item.properties().creationTime(), item.properties().contentLength())));
return blobList;

Hey, @millerna26. We're having some trouble repro-ing this issue. If you'd like to continue investigating this, could send us the output of mvn dependency:tree  so we can try to mimic your environment more exactly? If you are satisfied with this work around, we'll ask that you please close the issue.


Fastsync English spec for review

Codecov Report

Merging #208 into master will decrease coverage by 0.3%.
The diff coverage is 50.0%.

@@           Coverage Diff            @@
##           master    #208     +/-   ##
========================================
- Coverage    39.8%   39.4%   -0.4%
========================================
  Files          98      98
  Lines        3522    3546     +24
  Branches      559     566      +7
========================================
- Hits         1404    1400      -4
- Misses       1722    1748     +26
- Partials      396     398      +2

Impacted Files
Coverage Δ

tendermint/src/rpc/id.rs
0.0% <0.0%> (ø)

tendermint/src/lite/verifier.rs
69.3% <100.0%> (-0.7%)
:arrow_down:

light-node/src/application.rs
29.5% <0.0%> (-7.7%)
:arrow_down:

tendermint/src/serializers.rs
54.3% <0.0%> (-3.5%)
:arrow_down:

tendermint/src/signature.rs
30.0% <0.0%> (-1.6%)
:arrow_down:

tendermint/src/hash.rs
59.5% <0.0%> (-1.5%)
:arrow_down:

tendermint/src/chain/id.rs
62.6% <0.0%> (-1.0%)
:arrow_down:

tendermint/src/vote/power.rs
10.5% <0.0%> (-0.6%)
:arrow_down:

tendermint/src/amino_types/vote.rs
54.0% <0.0%> (-0.3%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21179b...4455595. Read the comment docs.

Other high level thoughts I'll try to summarize in advance of a discussion:

Is there convention on the definition names over what gets upper cased and what doesnt? Eg. SEQ vs Auth ...
Can we include some kind of legend to make the short forms more understandable, ie:

FM = Fault Model
A = Assumption
FS = Fast Sync
etc ...

Without the context of the VDD document, or even with it, some of the titles/headings are a bit confusing. For instance the Sequential vs Distributed problem statement and other document organization. We can do a better job with a table of contents and description of how the doc is laid out and how to follow it.
In our contract we distinguish between the "core" and "peer" state machines of a reactor. This is most notable in the consensus reactor, but we should make some effort to distinguish them here as well. For the fast sync, it's practically all "peer" state machine, though the verifycommit/execute logic would be the "core" state machine.

Is there convention on the definition names over what gets upper cased and what doesnt? Eg. SEQ vs Auth ...

No. We will fix a convention soon. For now, I changed all to upper case.

Can we include some kind of legend to make the short forms more understandable, ie:

FM = Fault Model
A = Assumption
FS = Fast Sync
etc ...

I added the most frequently used ones

Without the context of the VDD document, or even with it, some of the titles/headings are a bit confusing. For instance the Sequential vs Distributed problem statement and other document organization. We can do a better job with a table of contents and description of how the doc is laid out and how to follow it.

I added added a bullet list at the top of the document with pointers to the sections. Please, let me know what you think!


add custom error

Codecov Report

Merging #128 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   69.56%   69.53%   -0.04%
==========================================
  Files          74       74
  Lines        4501     4503       +2
==========================================
  Hits         3131     3131
- Misses       1005     1007       +2
  Partials      365      365

Impacted Files
Coverage Δ

plugin/awss3/awss3.go
9.13% <0.00%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cfe59...861a7e5. Read the comment docs.


K8SPXC-1028: Fix buffer pool autotuning

Our autotuning params didn't match with values take effect in database. We need to be sure:

innodb_buffer_pool_size needs to be multiple of innodb_buffer_chunk_size (default 128M).
If innodb_buffer_pool_size > 1G, we need to set chunk size to be multiple of its minimum value (10M).

@hors  do we plan include it to the release?

Test name
Status

storage
passed

big-data
passed

haproxy
passed

scaling
passed

cross-site
passed

recreate
passed

scheduled-backup
failed

upgrade-haproxy
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

limits
passed

demand-backup
passed

monitoring-2-0
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

smart-update
passed

affinity
passed

one-pod
passed

auto-tuning
passed

pitr
passed

proxysql-sidecar-res-limits
passed

users
failed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
failed

We run 31 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/412198559f90291ef80b05b547d9a7851180fed7
image: perconalab/percona-xtradb-cluster-operator:PR-1166-41219855

Test name
Status

scheduled-backup
passed

haproxy
passed

cross-site
passed

recreate
passed

big-data
passed

upgrade-haproxy
passed

scaling
passed

storage
passed

scaling-proxysql
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

self-healing
passed

self-healing-chaos
failed

upgrade-proxysql
passed

limits
passed

demand-backup
passed

monitoring-2-0
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

smart-update
passed

affinity
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

one-pod
passed

pitr
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
failed

tls-issue-self
passed

tls-issue-cert-manager
failed

We run 33 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/0e762a5b1e92a69dcbce487dd2729f6da7154fe8
image: perconalab/percona-xtradb-cluster-operator:PR-1166-0e762a5b

Test name
Status

haproxy
passed

cross-site
passed

upgrade-haproxy
passed

scheduled-backup
failed

storage
passed

big-data
passed

recreate
passed

scaling
passed

self-healing
passed

self-healing-chaos
failed

init-deploy
failed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

scaling-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

demand-backup
passed

security-context
passed

limits
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

smart-update
passed

monitoring-2-0
failed

affinity
passed

one-pod
passed

pitr
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

upgrade-consistency
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
failed

We run 33 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/0e762a5b1e92a69dcbce487dd2729f6da7154fe8
image: perconalab/percona-xtradb-cluster-operator:PR-1166-0e762a5b

Test name
Status

storage
passed

scheduled-backup
failed

upgrade-haproxy
passed

haproxy
passed

scaling
passed

big-data
passed

recreate
passed

cross-site
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
failed

init-deploy
failed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

demand-backup
passed

limits
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

smart-update
passed

monitoring-2-0
failed

affinity
passed

pitr
passed

one-pod
passed

auto-tuning
passed

upgrade-consistency
passed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
failed

We run 33 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/0e762a5b1e92a69dcbce487dd2729f6da7154fe8
image: perconalab/percona-xtradb-cluster-operator:PR-1166-0e762a5b

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
failed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-8-0
passed

scaling-proxysql-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/b5167aef2c15a4a61ce35a81c1b4927e4cc2afed
image: perconalab/percona-xtradb-cluster-operator:PR-1166-b5167aef

Test name
Status

We run 0 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/7c7a5800bd09dc1b2b5b657036f7f1b442000fca
image: perconalab/percona-xtradb-cluster-operator:PR-1166-7c7a5800

Test name
Status

auto-tuning-8-0
passed

demand-backup-8-0
passed

demand-backup-cloud-8-0
passed

one-pod-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-self-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

validation-hook-8-0
passed

We run 11 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/a406f9476219cf9ee3916e0d17ae3612f5497fb1
image: perconalab/percona-xtradb-cluster-operator:PR-1166-a406f947

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
failed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-8-0
passed

scaling-proxysql-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/1a176ec10e664aab61844bd637e036d18d7e46f9
image: perconalab/percona-xtradb-cluster-operator:PR-1166-1a176ec1

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-8-0
passed

scaling-proxysql-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1166/commits/1a176ec10e664aab61844bd637e036d18d7e46f9
image: perconalab/percona-xtradb-cluster-operator:PR-1166-1a176ec1


Fix typo in Cloud Pub/Sub topic path

Just a small typo in the topic path.

R: @aaltay Small typo fix


fix: Fixes 283

This PR supercedes #284.
The changes may seem massive, but I have ensured not to remove any content. It majorly tries to improve:

content flow
formatting
editing

Please find comments inline for specific discussions.

@naveenchkrvrthy  Closing this PR since it has been stale for a while. If you decide to take it forwards, lets work on changes in smaller iteration, one or two pages at a time. it will be simpler for the team to review and merge.
Also lets create an issue and discuss the changes if there are significant layout changes.


the height of the background is not fit with text when text style set with backgrounFill

Describe the bug
I'm setting a text label for a feature on a vector layer, and giving it a background fill to visually separate it from the background.
However, when I set the background fill, it does not span the entire height of the text label.The more lines, the greater the height of the background from the actual height.

To Reproduce
Steps to reproduce the behavior:

You can see the issued demo to codesandbox

The main code is below:

import GeoJSON from 'ol/format/GeoJSON.js';
import Map from 'ol/Map.js';
import VectorLayer from 'ol/layer/Vector.js';
import VectorSource from 'ol/source/Vector.js';
import View from 'ol/View.js';
import {Fill, Stroke, Style, Text} from 'ol/style.js';

const map = new Map({
  target: 'map',
  view: new View({
    center: [0, 0],
    zoom: 2,
    extent: [-13882269, 2890586, -7456136, 6340207],
    showFullExtent: true,
  }),
});

const labelStyle = new Style({
  text: new Text({
    //font: '13px Calibri,sans-serif',
    font: '13px Microsoft,Yahei',
    fill: new Fill({
      color: '#000',
    }),
    stroke: new Stroke({
      color: '#fff',
      width: 4,
    }),
    padding: [0, 0, 0, 0],
    overflow: false,
  }),
});
const countryStyle = new Style({
  fill: new Fill({
    color: 'rgba(255, 255, 255, 0.6)',
  }),
  stroke: new Stroke({
    color: '#319FD3',
    width: 1,
  }),
});

const vectorLayer = new VectorLayer({
  background: 'white',
  source: new VectorSource({
    url: 'https://openlayers.org/data/vector/us-states.json',
    format: new GeoJSON(),
  }),
  style: function (feature) {
    const id = feature.getId();
    const textStyle = labelStyle.getText();
    textStyle.setFont('13px Calibri,sans-serif');
    textStyle.setBackgroundFill(
      new Fill({
        color: 'blue',
      })
    );
    textStyle.setBackgroundStroke(
      new Stroke({
        color: 'red',
        width: 2,
      })
    );
    textStyle.setStroke(
      new Stroke({
        color: '#b4ebaf',
        width: 4,
      })
    );
    textStyle.setText([
      id,
      'bold 23px/23px Times,New,Roman',
      '\n',
      '',
      ` ${feature.get('name')}`,
      '900 11px/11px Times,New,Roman',
      '\n',
      '',
      `${feature.get('density')} people/mi²`,
      'italic 11px/11px Calibri,sans-serif',
    ]);
    return [countryStyle, labelStyle];
  },
});

map.addLayer(vectorLayer);

Expected behavior
The background height equal to the text height .

The codesandbox you provided does not work for me, but it looks like you're using fonts that are not available, which could be the source of the problem.

The codesandbox you provided does not work for me, but it looks like you're using fonts that are not available, which could be the source of the problem.

I have been paste the code，and find the problem is from the  function 'getTextDimensions'，which is in the js file 'ol/render/canvas.js'。The solution that i can think of is below:

Thanks @Frank-Chan, now I see the problem. You are right. Would you be able to create a pull request with your suggested fix?

Created pull#15717


Can't import report json into diff viewer anymore

It looks like commit 16730d65acb795805310dfb340b4fea1403ecbee introduced a regression.  The json output no longer includes the overview data for all nodes, which is a requirement for the diff viewer to work.  Specifically, the diff viewer tool looks for most_differences here:
https://github.com/camptocamp/puppet-catalog-diff-viewer/blob/master/catalog_viewer.js#L161
But with the latest commit of this module, that field is no longer present in the output reports that I've generated.  I get the following error in my browser developer tools:
Uncaught TypeError: Cannot read properties of undefined (reading 'length') catalog_viewer.js:161
Reverting to the commit prior to PR-50 brings back a valid report json again.

I have run into the same issue. Would be great if the PR can be reviewed!


Unclear how to add/configure integration

Hey there!
From the Readme it is unfortunately not clear to me how to install this integration. I have added the page as custom repository to HACS and installed the integration. When I attempt to add the integration afterwards, I only get the following screen:

I am using HA 2023.5.4. Bluetooth is enabled via an ESPHome bluetooth proxy, which works quite well with the Xiaomi BLE integration.
What am I missing? Does the integration still work with the latest version of Home Assistant?

The device is automatically discovered and added if supported.

@mihsu81 is correct, there is no configuration required as with other Home Assistant sensors that have autodiscovery.


Add docs about custom toolchains

I have found no documentation on how to use crate2nix with a custom toolchain.
After a bunch of fiddling I came up with an solution and thought I’d provide a PR to add this as documentation.
That being said: I am not sure this is the intended way to provide a custom toolchain. I am happy to adapt the PR if anyone is so kind to show me a better way to do this.

Thanks! I just merged another approach as well :)


add bug fix changes to release notes

Signed-off-by: Bhavana Ramaram<EMAIL_ADDRESS>Description
add bug fix changes to release notes
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #548 (5d3fbc4) into 2.x (a36d11a) will increase coverage by 1.32%.
The diff coverage is 68.85%.

@@             Coverage Diff              @@
##                2.x     #548      +/-   ##
============================================
+ Coverage     78.66%   79.98%   +1.32%
- Complexity      908      930      +22
============================================
  Files            92       92
  Lines          3515     3523       +8
  Branches        323      323
============================================
+ Hits           2765     2818      +53
+ Misses          628      583      -45
  Partials        122      122

Flag
Coverage Δ

ml-commons
79.98% <68.85%> (+1.32%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rg/opensearch/ml/plugin/MachineLearningPlugin.java
100.00% <ø> (ø)

...ain/java/org/opensearch/ml/task/MLTaskManager.java
60.41% <ø> (ø)

...va/org/opensearch/ml/indices/MLIndicesHandler.java
70.00% <45.71%> (+0.88%)
:arrow_up:

...arch/ml/action/forward/TransportForwardAction.java
81.81% <100.00%> (ø)

...h/ml/action/models/DeleteModelTransportAction.java
90.90% <100.00%> (ø)

...arch/ml/action/models/GetModelTransportAction.java
78.78% <100.00%> (ø)

...rch/ml/action/tasks/DeleteTaskTransportAction.java
100.00% <100.00%> (ø)

...search/ml/action/tasks/GetTaskTransportAction.java
78.12% <100.00%> (ø)

...arch/ml/action/upload_chunk/MLModelMetaCreate.java
87.50% <100.00%> (+0.26%)
:arrow_up:

...n/java/org/opensearch/ml/model/MLModelManager.java
82.53% <100.00%> (+0.10%)
:arrow_up:

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Animated Charts and potential Iced backend

Hello,
When creating an animated chart, does this simply mean recreating the chart every time new data comes in? The piston example seems to suggest that, but it doesn't seem supported anymore.
I'm working on creating a Iced backend with its canvas component. Drawing charts seems to work with the required DrawingBackend methods implemented. The optional methods shouldn't be a problem besides estimate_text_size and blit_bitmap.
estimate_text_size requires this issue to be implemented.
Does blit_bitmap help with anything besides the bitmap backend?
draw_text provides pos as the anchorpoint of the text, where is this located in relation to the text, the top left corner?
Would you be interested to add an Iced backend to the other supported backends?
My end goal is to create interactive charts where you can resize the shown data and get a "popup" showing the data the cursor hovers over. For the hovering think something like this.
In Iced, I think this could be achieved by comparing the cursor position to what's drawn on the canvas. For this to work I would need the position of the drawn elements of the chart. As a simple example, when drawing a histogram I would need to know where the bar's borders are located. For zooming with linecharts, I would probably need the border coordinates of the coordinate system, maybe the coordinates of the data points but those should be easy enough to calculate with the coordinate system borders. Is there any way to get this information or maybe to include optional Methods in the
DrawingBackend?
Thank you very much for your time and work.

Hi, I like the idea of having iced backend. Having integration to GUI framework seems amazing to me.
One reason of removing piston backend is there's some dependency issue and at that that piston-window seems poorly maintained. What make things worse is at that time core code and backend code are in the same crate, that makes maintaining a big pain. With plotters 0.3 there's no more concern.
Short answer to the backend implementation: The only needed function for a working backend is: ensure_prepared, present and draw_pixel. All other function is implemented with draw_pixel, although it may be inefficiently. Any overriding the provided trait method is most likely performance optimization.

When creating an animated chart, does this simply mean recreating the chart every time new data comes in?

Mostly, but there's one optimization: The problem can choose only redraw the data area, instead of the entire chart.
https://github.com/38/plotters/blob/8e120a12ad97cd8b204f311592e87a589243f273/examples/minifb-demo/src/main.rs#L83-L89
When you have multiple subplot, you can selectively update the changed plot as well.

estimate_text_size requires this issue to be implemented.
The estimate_text_size has default implementation - when TTF support is enabled, Plotters will use it's own font handling code to estimate text size, so I believe that won't be a issue. Let me explain why this is a backend API: For most backend, the default implementation can be used and Plotters handles all the text positioning for you. But in some case, for example backend targeting a text console, which doesn't support font we want the backend to determine what's the size of the text is. Other than that I believe there's no need for override this trait method.

Does blit_bitmap help with anything besides the bitmap backend?

blit_bitmap gives you an ability of drawing an image to the drawing area. See this example https://github.com/38/plotters/blob/master/examples/blit-bitmap.rs It has a default implementation, which calls the draw_pixel and render the bitmap pixel by pixel - however, this could be very inefficient - for example, for bitmap backend we copy the image buffer directly for this purpose; for SVG we use the the <image> element to implement this call, etc.

to create interactive charts

For interactivity, Plotters have been planning for this for a long time #13 . The planned of Plotters interactivity support is use Plotters as a event dispatcher, which doesn't directly gives you any interactivity - But it provides a toolkit that allows you query what logic component is involved. I believe if you have idea on interactivity chart, it would be a good chance for plotters start supporting the interactivity. Personally I am not a GUI/Web programmer, so I may need some help for the actual interactivity implementation.
Hope this answers your question and please let me know if you have any more questions.
Cheers!

Thank you very much for the in depth answers!
I created a seemingly working prototype here: https://github.com/arctic-alpaca/plotters_backend_iced
You made integration into new backends really easy.
Under iced_backend is the backend code. Do you have any recommendations on how to test this properly?
A simple working example with iced is under src, cloning the repository and running cargo run should be sufficient.
There is some blurriness and artifacts when resizing the window which seem to be related to https://github.com/hecrj/iced/issues/494.

For interactivity...

Using Plotters as an event dispatcher sounds like a great idea, especially from an ease of integration standpoint. What you wrote here  seems like a good aproach to me, but I'm also not very well versed in GUI/Web development. Am I right in thinking this would mean keeping an instantiated plot struct somewhere, similiar to animated charts optimization?
There seems to be two obvious options. Providing information about the location of plot element to allow the developer/user to implement interactivity themself or to accept event like click_at(coords) and hover_over(coords). I think allowing both could be useful for people who just want it to work and people who want to have fine control over the interaction. I guess the location information of plot objects (bars/lines/etc) needs to be saved anyway to allow dispatching of events so this information could be made accessible.
What events would you plan to support?
How could I help with implementing interactivity?

There seems to be two obvious options. Providing information about the location of plot element to allow the developer/user to implement interactivity themself or to accept event like click_at(coords) and hover_over(coords). I think allowing both could be useful for people who just want it to work and people who want to have fine control over the interaction. I guess the location information of plot objects (bars/lines/etc) needs to be saved anyway to allow dispatching of events so this information could be made accessible.

Currently we have limited ability of interpret the event. Plotters allows reverse coordinate mapping, which map the device coord to logic coord. https://docs.rs/plotters/0.3.0/plotters/chart/struct.ChartContext.html#method.into_coord_trans But I am still wanting a better version of this.

There is some blurriness and artifacts when resizing the window which seem to be related to hecrj/iced#494.

Finally get vulkan works on my side. And note more note on this: You are missing font rendering function, which means Plotters draws the text use it's own font handling code, use the iced text handling should give a better result.

But I am still wanting a better version of this.

What do you think a better version should look like?

And note more note on this: You are missing font rendering function, which means Plotters draws the text use it's own font handling code, use the iced text handling should give a better result.

I don't think the blurriness and artifacts are related to the text rendering. But I'll work on this as soon as I got some more free time.

About the text drawing, as far as I can tell, DrawingBackend::draw_text requires BackendTextStyle to be implemented. But I don't think this is possible until Iced can calculate the text size.

I looked a bit more into it, a way to estimate text size is definitly needed since plotters_backend::BackendTextStyle supplies an anchorpoint and without the textsize I can't calculate the top right corner needed for iced.
I looked into creating a backend for OrbTk and had some problems that will need sorting before it could be used. One thing that would make it easier would be to make plotters_backend::DrawingBackend::estimate_text_size also &mut self like the rest of the trait. Would that be possible?
As far as I can tell, OrbTk currently only supports loading supplied fonts, not system fonts so that's an issue too. I'm not sure how this is in Iced at the moment.

Hi, sorry for the delay, I was busy last week. Thanks for looking into this.

make plotters_backend::DrawingBackend::estimate_text_size also &mut self like the rest of the trait. Would that be possible?

This is possible, but only concern is this is a breaking change so that if we feel this is needed we are going to change in the next major release - the problem is we need to wait, since I don't think we want to ship any breaking change without bumping the version number.
So I am wondering if the RefCell works in this case?
Let me know if you have any thoughts!
Really appreciated for your contribution!
Cheers

So I am wondering if the RefCell works in this case?

I didn't think of that, it does indeed seem like it works. Thanks!
For a complete OrbTk backend, there are currently two things missing:

Font loading, currently the only options are supplying a font yourself or using the default OrbTk font, no system fonts are accessible as far as I can tell. This isn't necessarily a problem, just something that would need attention when using the backend.
Text rotation/translation

Here is my current code if you want to take a look.

Text rotation/translation has been added to OrbTk. The backend should work now, besides only supporting self supplied fonts.


Customer IO 4.x SDK Support

Hi Customer.io team, We are exploring migrating to Customer.io from Segment but hit a roadblock as the latest Customer.io React Native SDK is not supported by this plugin and we would like to use the latest CDP features. Is there an ETA on when this support will be added? Also, is the config plugin generally behind in support for the latest CIO React Native SDK releases?

Hi @itajenglish, we are currently finalizing updating our Expo plugin to support our CDP (Data Pipelines) feature set. Work has been progressing smoothly and we hope to have it released by the end of the year.
Since many features rely on the CIO React Native SDK updates to the Expo plugin sometimes come out a little later. When possible we try to keep them as in sync as we can.


Requirement is pinned for PyEssent 0.13: requests==2.22.0

This library supports an integration in Home Assistant.
The upcoming pip resolver will be more strict in resolving package version conflicts:
http://pyfound.blogspot.com/2020/03/new-pip-resolver-to-roll-out-this-year.html#what-will-change
To avoid future issues it would be good if this library would change its pinning to allow any higher version and just set a minimum version.

Thanks for your support of Home Assistant!

Interesting, I originally pinned it on this exact version because that was Home Assistant policy. Thanks for reaching out, so much happens with Home Assistant all the time it's easy to miss. I've created a commit for your request.

Thank you!


fixup: e2e test after merging #4195 (allow-lowercase-workload) (#4202)

Description
same as https://github.com/Dynatrace/dynatrace-operator/pull/4202/files
DAQ-3366
How can this be tested?
same as https://github.com/Dynatrace/dynatrace-operator/pull/4202/files

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.56%. Comparing base (9e97070) to head (43cab92).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.4    #4208   +/-   ##
============================================
  Coverage        64.56%   64.56%
============================================
  Files              400      400
  Lines            26818    26818
============================================
  Hits             17314    17314
  Misses            8143     8143
  Partials          1361     1361

Flag
Coverage Δ

unittests
64.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


slow/missing DNS server has huge effect on results

If I add a non-existent DNS nameserver to the top of /etc/resolv.conf (e.g. <IP_ADDRESS>), the resulting DNS slowness has a huge effect on the download/upload speeds.  I read that other people found the same DNS problems (#638, #381, #117) over the past five years.  I would hope that the script could be modified to do the DNS lookups first, before the timing loop, so that the server URLs would use IP addresses instead of host names and not require any DNS lookup?  The Ookla CLI client doesn't have this problem.
Here's a (correct) result without the bogus DNS server:
# bin/speedtest-cli_2.1.2 --server 16610
Download: 47.15 Mbit/s
Upload: 11.53 Mbit/s
I add the bogus DNS server to the top of /etc/resolv.conf and things go very wrong:
# bin/speedtest-cli_2.1.2 --server 16610
Download: 2.17 Mbit/s
Upload: 2.51 Mbit/s
The reason I found this, is that I have two Internet connections from two providers, with two DNS nameserver lines in my /etc/resolv.conf file, and the first provider went down last night and caused the speedtest results from the other provider to go wrong.  DNS look-up delays should not be part of the output results.

I have no intention of trying to implement DNS caching.


How can I build 1.7.4beta?

I tried to build a 1.7.4beta, because I get in QGC 3.2.2 error messages when I upload the latest 1.8 test version into the Pixhawk.
So I downloaded 1.7.4beta and tried to build it in the Directory /Firmware-1.7.4beta.
I get the error message "You have to use GIT to download this repository".
 How I can I do this?
Thanks for advises. Jakob

Hi @jstrebel , You should start here: https://dev.px4.io/en/setup/getting_started.html

This way worked for me.
Cloning the Repository:
git clone https://github.com/PX4/Firmware.git
cd Firmware
List the available tags:
git tag –l
checkout the desired tag (i.e 1.7.4beta)
git checkout -b tags/v1.7.4beta
Build the desired version:
make px4fmu-v2_default


Investigate possible improvements for MS Teams integration

Overview
Currently, starting notifications for MS Teams bot is a manual action. Also, it requires a public endpoint on the BotKube cluster side.
See related issue: https://github.com/kubeshop/botkube/issues/605
Acceptance Criteria

Investigate how we can improve the integration

Can we get rid of the required exposed endpoint in BotKube cluster? Maybe there's another way to enable watch for incoming messages, like with Slack?
Can we start notifications automatically?
Can we support channels property, with sources or executors bindings per channel, as it is for Slack or Discord?
Can we use different Go library? Should we write our own thin layer to integrate with it in a better way?
Any other ideas what we can do to make it better
How feasible is to add BotKube to the marketplace? Especially if the public endpoint on BotKube cluster side is necessary?

Outcome: notes + tasks + agreements

Reason
MS Teams integration should be on par with others (e.g. Slack or Discord) when it comes to the features. Also, the set-up should be as easy as possible.
Related issues
https://github.com/kubeshop/botkube/issues/469
Update (29.08.2022)

Microsoft introduced a new API for MS Teams as beta and I can see messages can be retrieved from graphql endpoint as you can see here
I searched for websocket support, but it seems It is not an option
If we continue with message retrieval from their endpoints, we may need to introduce a protection mechanism for rate limiting (Will search this more)
For the marketplace stuff, I am testing by adding redirect URI to app registration, I expect to grab an access token to access channel messages with our marketplace app.

Update (04.09.2022)

To eliminate messaging endpoint, we can use Azure Bot to handle some logic inside MS Team App
Azure Bot means, there will be an implementation for the Azure Bot business logic, and this bot will be responsible for retrieving oauth token for MS Teams App session and show to user.
In this case, MS Team App will be communicating with Azure Bot, and Azure Bot will print an access token to be used in BotKube deployment
Botkube deployment can use this token to access messages in a channel as I stated in previous update
You can refer here to see the long step by step doc about adding Oauth to bots.
We can publish our app to Marketplace so, once user started to use MS Teams App, it will print access token without calling any of our endpoints.

I have added my 2-stage analysis in the issue description, we can talk more on that once we feel ready :)

I created a follow up task here


fix: correct .coveragerc omitted files globs

See https://coverage.readthedocs.io/en/7.2.5/migrating.html & Ned's note in comments of this PR.

Via testing, I suspect that:

Coverage.py file patterns only matches entire directories if the file pattern ends with a slash and asterisk ("/*").

In addition to the rule above, Coverage.py file patterns that start with a wildcard character only matches entire directories if the file pattern starts with an asterisk and slash ("*/").

Example:
% python
Python 3.8.11 (default, Aug 23 2021, 18:14:59)
>>> import coverage
>>> coverage.version_info
(7, 2, 3, 'final', 0)
>>> from coverage.files import GlobMatcher
>>> GlobMatcher(["*migrations*"], "omit").match("/dir/project/migrations/0001_initial.py")
False
>>> GlobMatcher(["*/migrations/*"], "omit").match("/dir/project/migrations/0001_initial.py")
True
>>> GlobMatcher(["/dir/project/settings*"], "omit").match("/dir/project/settings/base.py")
False
>>> GlobMatcher(["/dir/project/settings/*"], "omit").match("/dir/project/settings/base.py")
True
>>> GlobMatcher(["*admin.py"], "omit").match("/dir/project/app/app_name/admin.py")
True

See:

InOrOut.check_include_omit_etc()
GlobMatcher in self.omit
Definition of self.omit
Coverage.py glob documentation

This PR corrects .coveragerc files so they omit files they intend to omit.

Merge checklist:
Check off if complete or not applicable:

[X] Changelog record added
[X] Documentation updated (not only docstrings)
[X] Fixup commits are squashed away
[X] Unit tests added/updated
[X] Manual testing instructions provided
[X] Noted any: Concerns, dependencies, deadlines, tickets

I wasn't sure what this line referred to, so I didn't change it. However, it looks like a directory, not a file, and thus may need correcting as well:
https://github.com/openedx/edx-cookiecutters/blob/581234957a14d96ce46f2bdf42ca4a0dc68d866d/python-template/{{cookiecutter.placeholder_repo_name}}/.coveragerc#L5-L6
>>> GlobMatcher(["tests"], "omit").match("/dir/base/migrations/tests")
True
>>> GlobMatcher(["tests"], "omit").match("/dir/base/migrations/tests/test.py")
False

Sorry for the churn.  Coverage.py changed in 7.x. This page is new as of two weeks ago: https://coverage.readthedocs.io/en/7.2.5/migrating.html

Oh, great to know & have confirmation! Thanks @nedbat.


Egui-winit/egui-wgpu samples

Working on a renderer and looking to add a debug/diagnostic UI for it. Would be nice to have some to the point examples of using egui-winit/egui-wgpu being used.

There's an example here, but it sure could be expanded a bit
https://github.com/emilk/egui/blob/master/crates/egui_demo_app/src/apps/custom3d_wgpu.rs

https://github.com/fralonra/wgshadertoy/ is a working example.
Hope it helps.


RTLIL::SigSpec::remove2() speedups

As described in #114, remove2() as used by Yosys::AST_INTERNAL::ProcessGenerator::removeSignalFromCaseTree() was doing a lot of memory allocations and causing a performance bottleneck.  These changes mostly remove unnecessary copies.  With these changes, read_verilog of the test module from #114 with COUNT=1600 improves from 160s to 4s.

Well done! Thanks!


Compiler freezes during docker image creation

Hi everyone! I stuck with an interesting problem. My application perfectly compiles and I can deploy it, but as soon as I add methods from one of the key class to my codable routes, the compiler freezes during the docker image creation. As far as I understand, the compiler compiles everything, regardless of the usage in the application logic. That means this class and its functionality is not an issue. Tried all Swift versions starting 5.0.2. Please find the project at git@us-south.git.cloud.ibm.com:chekanov/bridge.git or https://us-south.git.cloud.ibm.com/chekanov/bridge.git. Thank you in advance for your help!

I found the problem!
I have a Codable struct — Property, and this struct has Member, and the Member struct has [Property], which leads to a recursion. XCode compiler perfectly manages it, but Linux — freezes (and the main problem is not in the recursion itself, but in Codable conforming).
So, one of the possible solutions here is to use classes instead of structs — the Linux compiler works fine in that case.


added MCMC posterior_predictive_branch sampler

@perrydv @paciorek Added checking for jointly posterior predictive networks of nodes and a new posterior_predictive_branch sampler to be assigned to them.
I've tested this (what I believe to be) pretty well, although admittedly no new testing was added.  But I believe it's sound.  Code review or testing is welcomed.

@perrydv @paciorek I've reviewed all the failures carefully, because I was curious if the sampler assignment logic held up.
The first failures are cases where the new posterior_predictive_branch should be assigned, but in the tests, we're checking (usually) for the presence of either RW or conjugate samplers, to make sure the model inspection and sampler assignment works.
In test-trunc.R, in the test labelled "Test that MCMC with truncation avoids conjugate samplers".  I encourage anyone interested to look at this test, and understand what's going on, with the new assignment of the posterior_predictive_branch sampler.  Best fix might be making all the y terms into data.
Next failure is in test-dynamicIndexing.R.  There are two tests, labelled "Testing multivariate normal-Wishart dependency conjugacy detection with dynamic indexing", and all the failures are taking place there.  Maybe, a better fix for this one, would be just specifying the y as being "data", in both of the tests?  Then, we'd still check for (and should assign) conjugate samplers, which is what the test is trying to test for.  As is, with no data in the models, these nodes get the new posterior_predictive_branch sampler.
Finally, there are a bunch of failures again the "gold file" of exact MCMC results that I'm seeing, I think all from test-mcmc.R.  I haven't looked carefully at all of these, but of course it makes sense that we'd be getting different samples now.
Thought about how to proceed?

@perrydv @paciorek I fixed the testing failures.

In tests that check for certain sampler assignments, I added "data" to the models, so the old checking for particular conjugate or non-conjugate relationships still applies (rather than the new posterior_predictive_branch sampler).
In tests checking for exact sample results, or matching the MCMC gold file, I added a new system option MCMCusePosteriorPredictiveBranchSampler which disables use of this new sampler.  This option is turned off for the test-mcmc.R tests, and it now matches old results.

I'd welcome any review on this.  @perrydv also your careful eye for efficiency.

@perrydv I'm going to modify this PR to use node graph IDs instead.

@perrydv Unfortunately, some quick efficiency tests have shown this approach to be unusable.  Back to the drawing board.
I have an alternate idea for a "bottom-up" approach to the problem, using getParents.

@perrydv This checking and assignment is now "fast", and doesn't bog down the MCMC configuration process.
I'd welcome any code review, or to merge this into devel.

Many of our options are framed as "actions", i.e., they have a verb in them. If "Sample" here is a verb, then it should be "jointlySample" not "jointSample".  Obviously minor, but my two cents.

@paciorek I added your idea of avoiding any checking, when there's no possibility whatsoever of any posterior branches.  Indeed, in some cases this totally alleviates the checking time.  Good idea.

@danielturek Here are some suggestions on the code:

It would be nice to do model$getDependencies(thisCandNodeID, dataOnly = TRUE, downstream = TRUE, returnType = 'ids') once and re-use the results.  It looks like it is done up to five times redundantly.  One of those times has self = FALSE, which would need to be dealt with.
Could the three for loops be combined (which would help on the previous point)?  It looks like the indToKeep and nodeIDs steps could be done in the first for loop.
I think the direct use of the maps internals could be replaced with model$expandNodeNamesFromGraphIDs.

@danielturek Here is a possibly challenging benchmark case:
mu ~ dnorm(0, 1) # prior
y ~ dnorm(mu, 1) # data
for(i in 1:10000) {
  ypred[i] ~ dnorm(mu, 1) # predictive depth 1
  zpred[i] ~ dnorm(ypred[i], 1) # predictive depth 2
}

I think this will give 10000 posterior predictive branches, each with a (ypred[i], zpred[i]) pair.

@perrydv I've made some efficiency improvements to identifying posterior predictive branches.  Notably, I've combined the 3 loops into a single loop, which now only contains a single call to getDependencies for each candidate predictive branch node.  I've also added testing for the sampler assignments to predictive branches.
Also, the "possibly challenging benchmark case" you presented, the MCMC configuration time is nearly identical for using / not using the option MCMCjointlySamplePredictiveBranches, each are about 22 or 23 seconds on my machine, so I don't see any much of a performance hit.
Thanks for the careful code review.  I'd like to say this is ready to merge, but I welcome any further feedback.

Few more small changes, but again I consider this ready to merge.

:+1: Merging this is good with me.
Here is an idea for where we could go with this and also to avoid conditioning on any posterior predictive nodes in MCMC.
We could give the maps a predictive_IDs similar to (and not mutually exclusive of) top_IDs, latend_IDs and end_IDs.  Then getNodeNames could get a predictiveOnly and/or includePredictive option.  getDependencies already has an omit option, so one could omit predictive nodes using that.  Or it could get a new omitPredictive option to avoid what could become a lot of redundant steps otherwise.  Then the calls to getDependencies for every sampler could exclude predictive nodes.
This is still different from grouping predictive nodes into shared branches as this PR does.

@perry I fully support the idea of adding a predictiveNode flag to the maps.  The determination of that could use (via refactoring) the detection logic which this PR adds to the MCMC.  For now, I'm merging this PR.

I also like the predictiveIDs idea. Should we start a NCT issue?


[Feature] Request to Segregate Test Cases into Automated and Semi-Automated Sections Instead of FirstChipToolSuite

Feature description
Currently, test cases under FirstChipToolSuite are grouped together, regardless of their automation level. This makes it challenging to quickly identify which tests are fully automated and which require manual intervention or partial automation.
To enhance test management, reporting, and validation processes, I propose segregating test cases into distinct sections based on their level of automation.
Proposed Structure:
Automated Tests: Test cases that are fully automated and require no manual intervention during execution.
Semi-Automated Tests: Test cases that involve partial automation but require some manual input or validation steps.
Use Cases

Improved Clarity: Segregating test cases by automation level allows team members to easily identify which tests are fully automated and which require manual interaction.

Better Reporting: This structure would facilitate more accurate reporting of automation progress, showing clearly how many test cases are automated versus semi-automated.

Focused Validation: Segregating these test cases would streamline test execution and help focus on areas that still require manual validation, improving overall testing efficiency.

Test Cases
All the Automated and semi automated test cases

Additional Information
This segregation will help streamline testing processes, improve reporting accuracy, and provide clarity on the level of manual intervention required for each test case.

Revisit the TC grouping/classification in UI.


3D login-page using HTML,CSS and JS

Here I will create a 3D login page, where new user can sign up and existing member can sign In

@Vanshiii203 pls check this issue


refactor(jenkins/pipelines,pipelines): use the new dockerfile url location

They are compatible with the old locations.
Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve


Fix landscape orientation and other form factors

[x] character grid
[ ] char set menu
[ ] char tile font size?

Not perfect but close enough for beta


COVID-19 and R Blog Series

Thanks for contributing your submission to the e-Rum2020 CovidR contest.
For CovidR contributors:

[x] The title of this PR reflects your contribution
[x] The pull request only includes one new .yml file under contest/contributions
[x] Make sure "Allow edits from maintainers" is checked
[x] Send an email to<EMAIL_ADDRESS>(for further direct communication down the road)

Subject: "Submission to CovidR: PR #00", where #00 is the number of this Pull Request
Content: A full link to this Pull Request
Optionally include your social media profiles (Twitter, LinkedIn, Facebook): we will use them to @mention you while sharing the contribution through our channels.

For CovidR maintainers:

[x] Label the PR as "submission"
[x] Check the validity of the submission
[x] Assess completeness of metadata and possibly adjust the .yml file-name
[x] Check the integration of the new page in the website gallery (via Actions' artifact or locally)
[x] Make sure the email to<EMAIL_ADDRESS>was received
[x] Add a field with the current date and approx. merge time (e.g. 2020-04-01-16:30 for April 1st, 4:30 PM)
[x] Squash-merge the pull request (commit headline will be OK, consider cleaning-up the details)
[x] The initial comment should be automatically created, otherwise comment manually with the raw content of vote-comment.md and an initial like
[x] Provide here the link to the contribution as published to the gallery: https://milano-r.github.io/erum2020-covidr-contest/tim-churches-COVID-19-blog-posts.html
[ ] Instruct contributors on how to include their badge from the gallery page, share on social media, and get a free ticket.
[ ] Consolidate e-mailed information.

Requested changes have been made.

@timchurches, your submission is now accepted and visible at https://milano-r.github.io/erum2020-covidr-contest/tim-churches-COVID-19-blog-posts.html :tada:
You can click on the eRum2020::Covidr badge in the page to obtain the badge code you can embed in your repository.
Furthermore, feel free to spread your contribution on social media with the link above, using hashtags #erum2020 #covidr, and invite the community to like the contribution using the corresponding button.
Last but not least: You can get your free ticket for the pre-conference event at https://www.eventbrite.it/e/covidr-erum-2020-pre-conference-event-tickets-104133026686


Excluding custom resources via rules in Validating & Mutating web-hook configuration is getting overriden with default config

Excluding custom resources via rules in Validating & Mutating web-hook configuration is getting overriden with default config
we have tried to adding rules to apply the validating & mutating webhook of policy.sigstore.dev with namespaceselector policy.sigstore.dev/include label and rules were empty by default.
we tried to add the rules to go via admission controller only for well known k8s objects such as deployments, statefulsets, daemonsets, cronjobs, jobs, pods only but not for custom resources.  But when we add these objects explicitly in the rules they are getting overriden with default ones. Is there a way to exclude few resources since the Objectselector is not sufficient for our usecases.
namespaceSelector:
matchExpressions:
- key: webhooks.knative.dev/exclude
operator: DoesNotExist
- key: policy.sigstore.dev/include
operator: In
values:
- "true"
objectSelector: {}
rules:

apiGroups:

""
apiVersions:
v1
operations:
CREATE
UPDATE
DELETE
resources:
pods
pods/status
scope: '*'

apiGroups:

apps
apiVersions:
v1
operations:
CREATE
UPDATE
DELETE
resources:
deployments
deployments/status
scope: '*'
.....
Main usecase is, we want to start with image sign verification only for well known objects mentioned above not for the custom resources. The problem with object selector is when we use matchexpressions NOT IN condition then also it is taken into effect for custom resources but it is considered for the deployments or pods.

Could you please let us know if there is way to exclude the all the custom resources in someway. Let us know, if you need any further info required.

@rnachire Thanks for opening this issue. But you should create it in https://github.com/sigstore/policy-controller/issues.

Sure, I have added https://github.com/sigstore/policy-controller/issues/347 .. could you please provide some way for the same.

closing this issue! it is now opened in https://github.com/sigstore/policy-controller/issues/347


Quick Fix on pseudoStyle

Change to toPx ?
https://github.com/jxnblk/styled-system/blob/571a7b3e0aee61e74a87ec256e2ec559c4694af4/core/src/util.js#L150

Thanks! Fixed in #106


Make csv options configurable via $options

Make csv options configurable via $options, defaults are set to the PHP defaults.
Translations::fromCsvFile($destination, ['delimiter' => ';']);
$translations->toCsvFile(
    $pathinfo['dirname'] . '/' . $pathinfo['filename'] . '.csv',
    [
        'includeHeaders' => true,
        'delimiter' => ';'
    ]
);

I see the tests fail because of incompatibilty with the parameter count in older versions of PHP, any suggestions to fix this cleanly?

A way to make it compatible with php 5.5 is using version_compare and execute the function without the last argument if the php version is lower than 5.5.4

Yes, I was thinking about that, but thought that might be weird that some options won't be available and the code might get a little sloppy with version_compare's all over the place.
I'll have a little think about it and update the PR later :)

I added a function that wraps the csv functions with backward compatible versions.

Thank you 👍

Ok, I've changed a bit your code. The same options have been extended to csvDictionary (extractor and generator) and, althought there's support for the escape_char argument in fgetcsv since php 5.3, I think is better to use the same version than fputcsv, in order to maintain the same support in csv generation and extraction.

v4.4.0 released


Sd is not formatted for EmuNAND for Section V - Injecting FBI

when i try to dumb health & safety
2. Go to "SysNAND Backup/Restore", then select the "Health&Safety Dump" option to dump Health & Safety to hs.app (you can use Up and Down / Left and Right to change the name)
it says that the sd is not formatted for emunand
health & safety dumb failed!
i am using SanDisk 32 GB SDHC class 4 formatted to fat32 32k using the tool provided

you probably chose "EmuNAND Options" instead.

thank you


Unusual use of Sequence

Hi  Andrew,
I just wanted to show you this unusual use of the Sequence<T> object.
I had no easy way (that I know of) to create a ReadOnlySequence from a span, which is the real need here, and so I just used a span from the sequence and used the sequence.AsReadOnlySequence property:

This pattern isn't supported, and could break in the future. The only legit time to access a span while writing is between acquiring the memory and calling Advance. As it is, youre depending on an implementation detail of Sequence`.
Any "upgrade" of a Span<T> to a ReadOnlySequence<T> would involve a memory copy, since while you can get a span from a memory, you cannot get a memory from a span, and ReadOnlySequence is necessarily based on Memory<T>.
It also looks like you intend for the ReadOnlySequences to outlive an individual iteration of your for loop. But aren't you writing to the same location on the span each time? That will overwrite the same memory that is in use from a previous iteration.
Then, when you recycle the Sequence<T> itself, that memory will again get used for something else, causing apparent memory corruption in your Store.
Instead, why not allocate a unique byte[] for each memory you want to keep around, write to its span (using AsSpan), then use new ReadOnlySequence<byte>(array) to create your final object?

This pattern isn't supported, and could break in the future. The only legit time to access a span while writing is between acquiring the memory and calling Advance. As it is, youre depending on an implementation detail of Sequence`.

Good point.

Any "upgrade" of a Span<T> to a ReadOnlySequence<T> would involve a memory copy, since while you can get a span from a memory, you cannot get a memory from a span, and ReadOnlySequence is necessarily based on Memory<T>.
It also looks like you intend for the ReadOnlySequences to outlive an individual iteration of your for loop. But aren't you writing to the same location on the span each time? That will overwrite the same memory that is in use from a previous iteration.
Then, when you recycle the Sequence<T> itself, that memory will again get used for something else, causing apparent memory corruption in your Store.

Store[tileId].Set() involves a memory copy, so we are not expecting the ReadOnlySequences to outlive an individual iteration of the for loop. Do you think there's a better way to name the method so this is more obvious?

Instead, why not allocate a unique byte[] for each memory you want to keep around, write to its span (using AsSpan), then use new ReadOnlySequence<byte>(array) to create your final object?

It's on a hotpath - this method is called thousands of times per second, as the app scales, and it needs to be allocation-free.
Thanks for your feedback Andrew. With the brainstorming, I've decided to make the `Store[tileId].Set(ReadOnlySequence entireRawImageData) method take the entire raw data image and pick out its own tile data, thereby completely eliminating the interstial buffer sequence seen in that method. It will be much more efficient.


Prevent extra comma in tag list

I know it's stupid but that has been bothering me whenever I looked at the catalog...
Before:

After:

Thanks for the fix.  LGTM.


sshnp_raspberrypi_demo

Is your feature request related to a problem? Please describe.
Ssh into a raspberry pi without that device having any open ports
Describe the solution you'd like
A step-by-step tutorial/demo
Describe alternatives you've considered
No response
Additional context
No response

done by #143
Thansk @TylerTrott !