Does v3.0 support images out of box without CRA?

I saw there's some image loader code for CRA. Should images work without it too? If not, can I extend webpack configuration somewhere. That's a little bit unclear at the moment. Other than that, Catalog 3 is looking good.
Related: https://github.com/reactabular/reactabular/issues/323

Yes, Catalog uses a CRA-like webpack config also when CRA is not present.
BUT images referenced in Markdown files don't get compiled by webpack (it's on my list but it's a bit tricky). Only the ones that you import in your JS files. Images in <catalog-dir>/static are treated like CRA's public/ directory, so you should be able reference them anywhere.

Ah... Thanks for the tip. I'll try /static then. I had a relative lookup in place.

About processing images in Markdown, I solved it like this. Let me know if you need more info. I just rewrite the images to webpack require and that's it.

It probably would be good if you could expose webpack configuration somehow so that I can extend it. I would have to set a DefinePlugin and maybe some resolve rules. Do you want a separate issue for this?

Yes, parsing the markdown and replacing the image references is what's necessary to do it. Thanks for the example!
I'm not sure if I want to support extending the existing webpack config. To me that sounds like a hacky way of doing things (because you have to rely on rule ordering and also know the shape of the incoming config where I can't guarantee that it'll be stable). For now, I suggest to use a custom webpack setup (skipping the Catalog CLI entirely) instead.

But if webpack supported a way to safely compose different configurations, I'd be happy to support it. I don't want to build a custom mechanism for that though ;)

I'm not sure if I want to support extending the existing webpack config. To me that sounds like a hacky way of doing things (because you have to rely on rule ordering and also know the shape of the incoming config where I can't guarantee that it'll be stable). For now, I suggest to use a custom webpack setup (skipping the Catalog CLI entirely) instead.

Ok. I agree it's a can of worms. It would be perfect for my use case as the base configuration does 99%. It's only a thing or two I need to add. I guess I'll skip customization for now to keep this simple.
The way I would do this is like:
webpack.config.js
module.exports = (env, config) => { // pass your config as second parameter
  // env === 'catalog.build' or 'catalog.dev' for example

  ...  // now I do my stuff

  return modify(config); // modify as needed
};

This is very close to webpack's configuration mechanism. I only added that config parameter. The rest is same. So you would have to detect for the file, pass env and config, capture output, and then use that. This hook would be enough for me and easy to document too.

I opened a separate issue for the config problem: #304
I assume the image problem is solved, so I'm closing this issue.

I assume the image problem is solved, so I'm closing this issue.

Yeah, solved apart from the Markdown bit. Maybe you could open an issue to track that so I can do updates on my end later. You need two bits to solve it: 1. rewrite image links at your Markdown parser 2. rewrite those rewrites as require.


[ci] switch to a supported no-response bot

Description
This project uses probot/no-response to automatically close issues where the original poster has stops interacting with the issue.
I noticed today that that project is no longer supported.
As of July 2021, the README at https://github.com/probot/no-response reads as follows:

⚠ We no longer recommend using this app
Use the action instead: https://github.com/lee-dohm/no-response

This project should switch to https://github.com/lee-dohm/no-response, to limit the risk of this useful automation failing due to incompatibilities with future GitHub Actions changes.
Additional Comments
Noticed this while considering a contribution to https://github.com/dask/community/issues/60 and reading the discussion there.

Just re-opening to discuss one more thing.
I just saw this comment posted by the new action: https://github.com/microsoft/LightGBM/issues/5039#issuecomment-1091055784

🎉 this is great, it works!
...but I didn't realize that it would post as @guolinke , I think because the GitHub token used for this project's automation is tied to your account. @guolinke are you ok with this action posting those comments as you? If not, maybe @shiyu1994 could identify or create a service user (i.e. bot account) in Microsoft's GitHub organization.

@jameslamb It is okay for me, but bot account is better.

@jameslamb
According to the https://github.com/lee-dohm/no-response#inputs,

token — Token used to access repo information. The default GitHub Actions token is sufficient.

Docs: https://docs.github.com/en/actions/security-guides/automatic-token-authentication
We just need to replace ${{ secrets.WORKFLOW }} with ${{ github.token }} here
https://github.com/microsoft/LightGBM/blob/3798f8720f4fbc4f1249717fb8f2f037e0075a46/.github/workflows/no-response.yml#L23
and closing comment will be posted by github-actions [bot] account.
Example:
https://github.com/10up/ElasticPress/blob/ffb8eb61b915e73a9d0cdab87a14c262cdf36068/.github/workflows/no-response.yml#L20
https://github.com/10up/ElasticPress/issues/2674#issuecomment-1086151366

oh excellent find @StrikerRUS , thanks!!
Ok great, I'll put up a PR with that change. Then people won't respond to those comments by tagging @guolinke 😂

Closed by #5136.


use MIDDLEWARE from 1.10 on

Coverage increased (+0.01%) to 90.491% when pulling 545b68e7efe9a3c8c7ab686a0d57cb30f2e5c46a on django-2.0-more-fixes into 34c16f86665bd9cb05994ca952d10dc30d9ad9cb on master.

Looks good to me. The only thing I am not sure if we should drop supporting old Django versions: https://github.com/django-import-export/django-import-export/issues/681

this is resolved with 3ea43166150b5bef2f2d8422c301a865f8413db1


Correct the order for 'bottom' leaderboard rankings

This ensures that the list returned from the leaderboard
endpoint in the GeckoboardController is presented in the
correct order.
The head of the list will now yield the worst performer with
each consecutive element improving.
Prior to this fix the list was returned in descending
performance order(the worst performer would be the 10th element).

:boom:


check_PS1() won't return 1

check_PS1() won't return 1 and PS1 will still 0.

def check_PS1(line, Funcanno_flgs, Allels_flgs, aa_changes_dict):
'''
PS1 Same amino acid change as a previously established pathogenic variant regardless of nucleotide change
Example: Val->Leu caused by either G>C or G>T in the same codon
AAChange.refGene
NOD2:NM_001293557:exon3:c.C2023T:p.R675W,NOD2:NM_022162:exon4:c.C2104T:p.R702W
'''
PS1 = 0
PS1_t1 = 0
PS1_t2 = 0
PS1_t3 = 0
dbscSNV_cutoff = 0.6  # either score(ada and rf) >0.6 as splicealtering
cls = line.split('\t')
funcs_tmp = ["missense", "nonsynony"]
ACGTs = ["A", "C", "G", "T"]
line_tmp = cls[Funcanno_flgs['Func.refGene']] + " " + cls[Funcanno_flgs['ExonicFunc.refGene']]

for fc in funcs_tmp:
    if line_tmp.find(fc) >= 0:
        PS1_t1 = 1;
        # need to wait to check Same amino acid change as a previously pathogenic variant
        line_tmp2 = cls[Funcanno_flgs['AAChange.refGene']]
        cls0 = line_tmp2.split(',')
        cls0_1 = cls0[0].split(':')
        aa = cls0_1[4]
        aa_last = aa[len(aa) - 1:]
        keys_tmp2 = cls[Allels_flgs['Chr']] + "_" + cls[Allels_flgs['Start']] + "_" + cls[
            Allels_flgs['End']] + "_" + cls[Allels_flgs['Alt']]
        try:
            if aa_changes_dict[keys_tmp2]:
                PS1_t2 = 0
        except KeyError:
            for nt in ACGTs:
                if nt != cls[Allels_flgs['Alt']]:
                    keys_tmp3 = cls[Allels_flgs['Chr']] + "_" + cls[Allels_flgs['Start']] +\
                                "_" + cls[Allels_flgs['End']] + "_" + nt
                    try:
                        if aa_changes_dict[keys_tmp3] == aa_last:
                            PS1_t2 = 1
                    except KeyError:
                        pass
                    else:
                        pass
        else:
            pass
try:
    if float(cls[Funcanno_flgs['dbscSNV_RF_SCORE']]) > dbscSNV_cutoff or float(
            cls[Funcanno_flgs['dbscSNV_ADA_SCORE']]) > dbscSNV_cutoff:  # means alter the splicing
        PS1_t3 = 1
except ValueError:
    pass
else:
    pass

if PS1_t1 != 0 and PS1_t2 != 0:
    if PS1_t3 == 1:  # remove the splicing affect
        PS1 = 0
return (PS1)

fixed, PS1=1 was  there before
"if PS1_t3 == 1:  # remove the splicing affect"

Please check again,PS1 still be 1
if PS1_t1 !=0 and PS1_t2 != 0 :
    PS1=0
    if PS1_t3 ==1: # remove the splicing affect
        PS1=0
return(PS1)

typo, change the line PS1=0 to PS1=1


Hdi add autoscale support autorest

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Merge conflicts should be resolved.

Looks good to me. Just waiting for ARM feedback. Need to reassign this PR since I will be OOF, and this needs to be merged before I come back

@gaoxiaoning - New model types have been added to the swagger specification. I don't see any updates to the corresponding x-ms-examples in the operation where these types are being used. Please update the existing examples or add new examples that show the usage of newly added model types.

@gaoxiaoning - New model types have been added to the swagger specification. I don't see any updates to the corresponding x-ms-examples in the operation where these types are being used. Please update the existing examples or add new examples that show the usage of newly added model types.

@gaoxiaoning - New model types have been added to the swagger specification. I don't see any updates to the corresponding x-ms-examples in the operation where these types are being used. Please update the existing examples or add new examples that show the usage of newly added model types.

@amarzavery , could you please help merge the PR or let us know if you have other concerns:)


docs: add python server reflectlion link

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,663      Total (=)      1,980,663

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,811,592      Total (<)     10,811,595

 No significant differences in binary sizes


Spec Measure blank

Every time I open any option in sketch measure, it is blank. Doesn't matter what file I use. i have tried disabling all the other plugins and any open mac applications. Any way I can help troubleshoot this?

You can try update the plugin, and restart sketch.app

I am using the latest version, I have tried uninstalling and reinstalling and it still is blank.


Require continuation char to be last char in a line

While looking at #27039 I noticed that we allow for whitespace after
the continuation char (\) which is wrong. It needs to be the very
last char in the line.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

LGTM


Addresses oom_issue in data processing for large --ntimes

This closes #47.
Currently, the following command
python src/gz21_ocean_momentum/cmip26.py -85 85 -280 80 --factor 4 --ntimes 10
runs fine, but fails if we increase --ntimes to 100 (both on personal laptop and HPC job with 30GB RAM).
The data is meant to be processed using the function eddy_forcing , which takes as input the high-resolution dataset of surface velocities, and returns the
processed dataset lazily. The reason is that the whole dataset does not fit in the memory, but the computations are carried out along spatial dimensions only.
This means that Dask should be able to load in ram a few times slices, apply the function to those and write the corresponding partial result onto the disk in zarr format.

I have removed usage of xr.map_blocks which seemed to be the root cause of the issue.

New test is good. An additional test comparing map_block of eddy_forcing vs the eddy_forcing over grouped grid data is the same.

Brief status update:

code looks good and appears to solve the problem, but v
[ ] want another test to assert that removing map_block doesn't change-- see Dom's note above.
I'll do this.
[ ] Needs a rebase (no conflicts expected).

I'm finding that the original test from 8846ceac1f30b587ac32490ceab38a82fbcacbbd doesn't work e.g. issues with the numpy.stack and numpy.{zeros,ones} calls. I've fixed the syntax issues, but the test has more problems than that. @arthurBarthe could you provide any insight? (did this test work on your side?)

Following up on what @raehik said; I looked into the test too test_eddy_forcing_chunks and also couldn't get it working. I bashed the data around to get it into the right shape and got very close, but have some problems I cannot fathom.
I also started adding a test to compare the before- and after- of this refactoring here https://github.com/m2lines/gz21_ocean_momentum/commit/d48fcc92fc5e263029f425af6d6043a78a961300 (also on branch https://github.com/m2lines/gz21_ocean_momentum/compare/main...oom_data_processing_tests), but I need to figure out the test input first (something similar to the above).

Original test from Arthur now passes, and I adapted it for another test asserting that removing map_blocks is OK. Passes sensibly.

I've rebased on to main and fixed a small history issue -- anyone contributing will need to force pull this branch.


Versioning for the chart and exporters

As I mentioned in chat, chart versions don't need to be (and shouldn't be) in lockstep with the exporter version. This is because chart updates would bump the version, and then immediately be out of sync with the exporter code.
There is a larger question: what does it mean to have a tag in this repo, since we have both exporter code and the charts here?
Originally posted by @KevinMGranger in https://github.com/konveyor/pelorus/pull/366#pullrequestreview-880297079
We need to agree around 3 things

Exporters:
a.  Should exporters be on a separate lifecycle and versioning as an "exporters bundle"
b. Should each of the exporter be on a separate lifecycle and versioning and we should have compability matrix for them

Pelorus Chart versioning. Should this be synced with exporters or maybe separate one ?

Tagging. Does the new release and tag in the pelorus repo means synced tag with the Pelorus Chart? Currently github workflows do build and push containers to quay.io and retag them with the github pelorus tag, so it means each exporter will be at container version matching the tag, however it's not matching the version mentioned in Chart.

Converting to discussion as we need to agree on versioning of exporters/charts and now the pelorus-operator.


Network animator optimizations

This is an old pull request that I made in the UNET repo that never got merged:
https://bitbucket.org/Unity-Technologies/networking/pull-requests/21/cache-animator-parameters-to-avoid/diff

This is a simple optimization to minimize the amount of calls to the Animator.parameters getter which turns out to be an extremely costly operation.

Profiler before: https://i.imgur.com/2hDW2Lf.png
Profiler after: https://i.imgur.com/tjeb0Fi.png

Keep in mind that we could go with this even further and cache the parameters in the NetworkAnimator object to avoid allocations completely. However, I'm not sure how that would behave in practice, especially in development. The developer could tweak the parameters at runtime - maybe we could handle that separately as a specific #if UNITY_EDITOR case, and only optimize in builds (where we're guaranteed (?) that things don't change at runtime).

Codecov Report

Merging #55 into mirror will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           mirror     #55      +/-   ##
=========================================
- Coverage    3.86%   3.86%   -0.01%
=========================================
  Files          32      32
  Lines        6604    6606       +2
  Branches     1054    1054
=========================================
  Hits          255     255
- Misses       6344    6346       +2
  Partials        5       5

Impacted Files
Coverage Δ

Mirror/Runtime/NetworkAnimator.cs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40db215...fe1036c. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hand off Response object generation to most nested function

e.g. Alternates View RDF response

Completed in Ashley's recoding for recent release.


iOS Compilation error using 1.9.1 version

Hello,
Recently our push notifications stop working on iOS 10 so we decided to upgrade our version from 1.8.4 to 1.9.1.
After a hard time trying to install CocoaPods, we were able to install the plugin nevertheless, when we compile our iOS app and try to run it using Xcode v. 8.1, on a device or emulator, it throws an error (explained lines below)
Expected Behaviour
App should compile and run on a device or emulator
Actual Behaviour
"Apple Mach-O Linker(id) Error"
Ld /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Products/Debug-iphoneos/Wishfinity.app/Wishfinity normal arm64     cd /Applications/MAMP/htdocs/mobile-apps/platforms/ios     export IPHONEOS_DEPLOYMENT_TARGET=8.0     export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"     /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.1.sdk -L/Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Products/Debug-iphoneos -L/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GGLInstanceID/Libraries -L/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GoogleCloudMessaging/Libraries -L/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Wishfinity/Plugins/cordova-plugin-google-analytics -F/Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Products/Debug-iphoneos -F/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GoogleIPhoneUtilities/Frameworks -F/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GoogleInterchangeUtilities/Frameworks/frameworks -F/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GoogleSymbolUtilities/Frameworks/frameworks -F/Applications/MAMP/htdocs/mobile-apps/platforms/ios/Pods/GoogleUtilities/Frameworks/frameworks -FWishfinity/Plugins/cordova-fabric-plugin -filelist /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Intermediates/Wishfinity.build/Debug-iphoneos/Wishfinity.build/Objects-normal/arm64/Wishfinity.LinkFileList -Xlinker -rpath -Xlinker @executable_path/Frameworks -miphoneos-version-min=8.0 -dead_strip -Xlinker -object_path_lto -Xlinker /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Intermediates/Wishfinity.build/Debug-iphoneos/Wishfinity.build/Objects-normal/arm64/Wishfinity_lto.o -Xlinker -no_deduplicate -fobjc-arc -fobjc-link-runtime -ObjC -ObjC -lGGLInstanceIDLib -lGcmLib -lsqlite3 -lz -framework AddressBook -framework CoreGraphics -framework GoogleIPhoneUtilities -framework GoogleInterchangeUtilities -framework GoogleSymbolUtilities -framework GoogleUtilities -framework SystemConfiguration /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Products/Debug-iphoneos/libCordova.a -weak_framework MessageUI -lz -lc++ -framework SystemConfiguration -weak_framework Security -framework Fabric -framework Crashlytics -weak_framework ImageIO -framework CoreLocation -framework AVFoundation -lGoogleAnalyticsServices -framework CoreData -lsqlite3 -weak_framework Social -framework AddressBook -lsqlite3 -lz -lPods-Wishfinity -Xlinker -dependency_info -Xlinker /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Intermediates/Wishfinity.build/Debug-iphoneos/Wishfinity.build/Objects-normal/arm64/Wishfinity_dependency_info.dat -o /Users/diegocastillorios/Library/Developer/Xcode/DerivedData/Wishfinity-gnwzyutynojxfybuofvonuduyylq/Build/Products/Debug-iphoneos/Wishfinity.app/Wishfinity
ERROR:
ld: library not found for -lPods-Wishfinity clang: error: linker command failed with exit code 1 (use -v to see invocation)

Steps to Reproduce
Run:
$ cordova build ios
Open Xcode and run it on a connected device
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
phonegap-plugin-push 1.9.1 "PushPlugin"
ios: 4.3.0
cordova: 6.4.0

@diegocst90 did you open the project or the workspace? You need to open the workspace in order for XCode to find the cocoapods file.

Got the same error here.
Opened the .xcworkspace and it worked perfectly.

When using CocoaPods you have to close the .xcodeproj and open the .xcworkspace


Update README with info for zsh completion

Don't mind my messy commit history, still new to the whole colaboration thing

Awesome, I am really glad to see someone working on the ZSH completion - I felt bad about never getting further than the basic tool!

Checking it out now - something feels very great/wrong about using gh to do this!

Yeah, especially, since it didn't autocomplete for you ;)

It works great!
I only have one bit of feedback. Currently if Github returns an error message you get bad output from jsawk:
gh dsfasdfasdfasdfasdf /tmp/tmp.1XZtrG:1265: TypeError: RS.pop is not a function
/tmp/tmp.EicgeT:1265: TypeError: RS.pop is not a function
/tmp/tmp.Inyapv:1265: TypeError: RS.pop is not a function

I tried a bunch of things (for some reason when you get an object back from the server, it seems to come back as an array (I'm not very familiar with jsawk). That threw me for a while, but in the end I worked out if I check the first item for a message property, and then return an empty result set, it mitigates this issue (and ZSH just flashes).
javascript='return this[0].message ? [] : this.reduce(function(prev, cur, curI, array) {return prev + "\n" + cur.name + "[" + (!cur.description? cur.name + " has no description" : cur.description) + "]";}, "")'
_repos=(${(f)$(echo $repos | jsawk -a $javascript)})

Something like this would help make it run smoother.

You are right, forgot to test for that case.
Your solution works, was also the first thing that came to my mind, but I used a simpler and more general approach. I just added the --fail flag to curl which will return nothing to stdout if it receives an HTTP error code (like 404).
Fix should be up in a sec

Oh yeah, much better! I did wonder why nothing was happening with error
code - I figured surely Github do send one!
On Fri, 5 Aug 2016 at 17:15 Patrick Ziegler<EMAIL_ADDRESS>wrote:

You are right, forgot to test for that case.
Your solution works, was also the first thing that came to my mind, but I
used a simpler and more general approach. I just added the --fail flag to
curl which will return nothing to stdout if it receives an HTTP error code
(like 404).
Fix should be up in a sec
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dickeyxxx/gh/pull/15#issuecomment-237894109, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AElqXq0AQChD498laUaj5kGj-sgup5YPks5qc2GogaJpZM4Jdenb
.


ESP32S2: twai_self_test failure with CONFIG_COMPILER_OPTIMIZATION_SIZE=y (IDFGH-4158)

Hi, I'm working for Adafruit on the implementation of the canio module for CircuitPython using the ESP32S2's TWAI peripheral, and I've encountered a problem that's stopping me from completing the driver (https://github.com/adafruit/circuitpython/pull/3584).  I have demonstrated what appears to be the same problem but within the twai_self_test example that is bundled with esp-idf.
Software version used: esp-idf v4.3-dev-1561-g357a27760     (the latest at the time of writing; problem also affects v4.2-dev-2968-g8bc19ba89 used in circuitpython 6.0.0-rc.0)
Hardware used: ESP32-S2-Kaluga-1
Testing procedure:

Prepare hardware: Install jumper wire between pins 17 and 18. (NOTE: I do not believe the pin selection is important for reproducing, but it must match the menuconfig below; it's just what I happened to use)

Build working configuration:
cd examples/peripherals/twai/twai_self_test/
git clean -dxf
idf.py set-target esp32-s2
idf.py menuconfig

In "Example Configuration" set TX GPIO number to 17 and RX GPIO number to 18.  Save and exit
idf.py flash

Open terminal, press reset button.
Result: Test succeeds, printing many "Msg received" log lines and finally "Driver uninstalled"

Build non-working configuration (immediately following step 2):
idf.py menuconfig

In "Compiler options" set Optimization Level to "Optimize for size (-Os)". save and exit
idf.py flash

Open terminal, press reset button.
Result: Test fails, hanging after printing "TWAI Self Test: Driver started"

Note: With additional instrumentation added, it appears that when the compiler optimization is "-Os", writes to acceptance_filter.acr and .amr do not succeed, and incorrect values are read back.
Patch to add instrumentation: https://gist.github.com/1c90b383888ca40f3dbafd0b4d68ce9d
Typical instrumentation output when working properly:
I (325) TWAI Self Test: Driver installed
I (325) TWAI Self Test: f_config.acceptance_code = 0x00000000
I (335) TWAI Self Test: f_config.acceptance_mask = 0xffffffff
I (345) TWAI Self Test: f_config.single_filter = 0x00000001
I (345) TWAI Self Test: mode_reg = 0x0000000b
I (355) TWAI Self Test: command_reg = 0x00000000
I (355) TWAI Self Test: status_reg = 0x0000003c
I (365) TWAI Self Test: clock_divider_reg = 0x00000300
I (375) TWAI Self Test: acceptance_filter.acr[] =
I (375) TWAI Self Test:  00
I (375) TWAI Self Test:  00
I (385) TWAI Self Test:  00
I (385) TWAI Self Test:  00
I (395) TWAI Self Test:

I (395) TWAI Self Test: acceptance_filter.amr[] =
I (395) TWAI Self Test:  ff
I (405) TWAI Self Test:  ff
I (405) TWAI Self Test:  ff
I (405) TWAI Self Test:  ff
I (415) TWAI Self Test:

Typical instrumentation output when working improperly ("Optimize for size") - note incorrect values read back for acceptance_filter:
I (328) TWAI Self Test: Driver installed
I (328) TWAI Self Test: f_config.acceptance_code = 0x00000000
I (338) TWAI Self Test: f_config.acceptance_mask = 0xffffffff
I (348) TWAI Self Test: f_config.single_filter = 0x00000001
I (348) TWAI Self Test: mode_reg = 0x0000000b
I (358) TWAI Self Test: command_reg = 0x00000000
I (358) TWAI Self Test: status_reg = 0x0000003c
I (368) TWAI Self Test: clock_divider_reg = 0x00000300
I (378) TWAI Self Test: acceptance_filter.acr[] =
I (378) TWAI Self Test:  db
I (378) TWAI Self Test:  ff
I (388) TWAI Self Test:  0d
I (388) TWAI Self Test:  7f
I (398) TWAI Self Test:

I (398) TWAI Self Test: acceptance_filter.amr[] =
I (398) TWAI Self Test:  7e
I (408) TWAI Self Test:  77
I (408) TWAI Self Test:  fe
I (408) TWAI Self Test:  da
I (418) TWAI Self Test:

Additionally, marking just the function twai_ll_set_acc_filter in ./components/hal/esp32s2/include/hal/twai_ll.h as attribute((noinline,optimize("O0"))) causes the example to succeed when "Optimize for size" is selected.

@jepler Thanks for reporting this issue. I've been able to reproduce the issue. It seems like the root cause is that with size optimization enabled, the compiler is attempting to write to the register field with a s8 instruction instead of an s32 because the register field is 8 bits wide instead of usual 32bits.
For now, disabling optimization for twai_ll_set_acc_filter() seems to prevent the s8 instruction from being used. But a lot of the other register fields in TWAI are also 8 bits wide so I'd rather  the s8 instruction not be used at all when reading/writing to the TWAI registers.
I'll rework the twai_struct.h and twai_ll.h to prevent s8 from being used.

@jepler PTAL at commit 2e0ffbd543abc0226f0dbd2f725eb891235abe02 to see if it resolves your issue. The commit should prevent s8 access on all peripherals.

I won't be able to test it for 2+ weeks, so you're welcome to close this up if you prefer.

Closed on master branch by 874a720286b78e866684129ce18a6c948c8fa7fe and 14fe6dcaaf6d1bb9a1d1bb1d0e51a8fd184101e7 (for C++ workaround)


Read Data Out Characteristics

Somewhat naive question, but my understanding of the read characteristics of the generated macros wasn't clear from the documentation. After a read has completed, and the data has become available at the output, if there is no subsequent operation (or the clock is gated), does the output remain valid indefinately?

No, it will only remain valid for that read cycle. At the next clock, it will become invalid no matter whether the operation is a write, read or noop.

Does this apply too if the clock is gated once the data is available?

Yes, it does. The sense amps get shut off so the output will be invalid.


chore(types): generate a d.ts file for protocol types

This uses the /json/protocol endpoint to generate type definitions for the protocol.
Currently it is lacking protocol events and commands, but I will add those later.

في السبت، ٧ ابريل، ٢٠١٨ ٣:٤٧ ص JoelEinbinder<EMAIL_ADDRESS>كتب:

This uses the /json/protocol endpoint to generate type definitions for
the protocol.
Currently it is lacking protocol events and commands, but I will add those
later.
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleChrome/puppeteer/pull/2325
Commit Summary

chore(types): generate a d.ts file for protocol types

File Changes

M .gitignore
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-0 (1)
M lib/ElementHandle.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-1 (2)
M lib/ExecutionContext.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-2 (4)
M lib/FrameManager.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-3 (4)
M lib/NetworkManager.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-4 (6)
M lib/Page.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-5 (2)
M lib/helper.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-6 (6)
M package.json
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-7 (2)
A utils/protocol-types-generator/index.js
https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-8
(54)

Patch Links:

https://github.com/GoogleChrome/puppeteer/pull/2325.patch
https://github.com/GoogleChrome/puppeteer/pull/2325.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/puppeteer/pull/2325, or mute the thread
https://github.com/notifications/unsubscribe-auth/AT9vToLTZrHvxF0jrAjYs5FM8K-5TzSGks5tmAyGgaJpZM4TK3Uv
.


Compare performance of vector, list, and multiset in GK algorithm

Compare performance of vector, list, and multiset in GK algorithm

Measurements:
Win32 vector release x64:
epsilon: 0.1. # elems: 1000000. Duration (us): 6471000. #/microsec: 0.154536. #/ms: 154.536. #/sec: 154536
p50 = 52
epsilon: 0.05. # elems: 1000000. Duration (us): 1662000. #/microsec: 0.601685. #/ms: 601.685. #/sec: 601685
p50 = 50
epsilon: 0.01. # elems: 1000000. Duration (us): 184000. #/microsec: 5.43478. #/ms: 5434.78. #/sec: 5.43478e+06
p50 = 51
epsilon: 0.005. # elems: 1000000. Duration (us): 218000. #/microsec: 4.58716. #/ms: 4587.16. #/sec: 4.58716e+06
p50 = 51
epsilon: 0.001. # elems: 1000000. Duration (us): 2895000. #/microsec: 0.345423. #/ms: 345.423. #/sec: 345423
Win32 list release x64:
epsilon: 0.1. # elems: 1000000. Duration (us): 6500000. #/microsec: 0.153846. #/ms: 153.846. #/sec: 153846
p50 = 52
epsilon: 0.05. # elems: 1000000. Duration (us): 1763000. #/microsec: 0.567215. #/ms: 567.215. #/sec: 567215
p50 = 50
epsilon: 0.01. # elems: 1000000. Duration (us): 232000. #/microsec: 4.31034. #/ms: 4310.34. #/sec: 4.31034e+06
p50 = 51
epsilon: 0.005. # elems: 1000000. Duration (us): 312000. #/microsec: 3.20513. #/ms: 3205.13. #/sec: 3.20513e+06
p50 = 51
epsilon: 0.001. # elems: 1000000. Duration (us): 12671000. #/microsec: 0.0789204. #/ms: 78.9204. #/sec: 78920.4


Add 48hr filter for area counts

Add 48hr filter for area counts.
PR Checklist

[ x ] simple searchable title - [mds-db] Add PG env var, [config] Fix eslint config
[ x ] briefly describe the changes in this PR
[ ] mark as draft if should not be merged
[ ] write tests for all new functionality

Impacts

[ ] Provider
[ ] Agency
[ ] Audit
[ ] Policy
[ ] Compliance

Some feedback. Mostly pre-existing conditions.

I'm just gonna go ahead and merge -- I'll clean this all up when I get a chance to TS-ify things.


Update our project landing page

Update our project landing page as required by this week's project requirements

Codecov Report

Merging #170 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     68.92%   69.05%   +0.13%
  Complexity      613      613
============================================
  Files            96       96
  Lines          2095     2091       -4
  Branches        250      250
============================================
  Hits           1444     1444
+ Misses          543      539       -4
  Partials        108      108

Impacted Files
Coverage Δ
Complexity Δ

...quickcache/model/flashcard/FlashcardPredicate.java
90.90% <0.00%> (-9.10%)
7.00% <0.00%> (+1.00%)
:arrow_down:

...ain/java/quickcache/model/util/SampleDataUtil.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...a/quickcache/logic/parser/DeleteCommandParser.java
100.00% <0.00%> (+5.00%)
5.00% <0.00%> (-1.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb5f4d...3d11002. Read the comment docs.


BUG: Count samples by artifact visibility

A study can have multiple visibilities, and samples are counted per visibility per study. As a result, samples in studies that have multiple visibilities were counted multiple times.
I did not create a regression test as I don't believe the test data have a study where there is a prep that has multiple visibilities. If there is one, I'd be happy to use if for a regression test. If there isn't one, and if a regression test is important here, I may need some guidance on how best to create a mock study with artifacts spanning visibilities.

The failure is real and represents a possible logical flaw. The test study has two preps with the same samples represented twice so the count is 54 not 27. This is a valid scenario for resequenced samples, or samples with multiple preparations.
Are the sample counts on the stats page supposed to be the sum of the number of physical specimens or the sum of the number of unique preparations of the specimens?

I think they should be physical specimens rather than counting different amplicons, shotgun preps etc multiple times.
On Jul 26, 2019, at 12:18 AM, Daniel McDonald <notifications<EMAIL_ADDRESS>wrote:
The failure is real and represents a possible logical flaw. The test study has two preps with the same samples represented twice so the count is 54 not 27. This is a valid scenario for resequenced samples, or samples with multiple preparations.
Are the sample counts on the stats page supposed to be the sum of the number of physical specimens or the sum of the number of unique preparations of the specimens?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/biocore/qiita/pull/2928?email_source=notifications&email_token=AAPL2KO6V4AA4GQBJSW7IOLQBIYETA5CNFSM4IG6557KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23BHRI#issuecomment-515249093, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAPL2KPG2AVOF3TWDCZEMHLQBIYETANCNFSM4IG6557A.

Thanks, @rob-knight and @antgonza.
If counting primary specimen, which I agree is ideal, then I believe we have an issue with conflicting visibilities. Since state is controlled at the artifact level, it is possible for a physical specimen to be associated to a public artifact and a sandbox one. In that situation, we cannot readily determine whether to count the sample as public or sandbox. One possible solution is establishing an order of precedence over visibility for these counts.
This is not a hypotheical situation as I believe this corresponds to @adswafford's situation discussed in our email thread.

Precedence is we count the sample as the most “public” version of it that’s available ie “submitted to ebi” > “public” > “private” > “sandbox”
I wonder if this is a good time to consider implementing BioSample?
On Jul 26, 2019, at 10:38 AM, Daniel McDonald <notifications<EMAIL_ADDRESS>wrote:
Thanks, @rob-knighthttps://github.com/rob-knight and @antgonzahttps://github.com/antgonza.
If counting primary specimen, which I agree is ideal, then I believe we have an issue with conflicting visibilities. Since state is controlled at the artifact level, it is possible for a physical specimen to be associated to a public artifact and a sandbox one. In that situation, we cannot readily determine whether to count the sample as public or sandbox. One possible solution is establishing an order of precedence over visibility for these counts.
This is not a hypotheical situation as I believe this corresponds to @adswaffordhttps://github.com/adswafford's situation discussed in our email thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/biocore/qiita/pull/2928?email_source=notifications&email_token=AAPL2KJSLCRDMC5Q5RHXJCLQBMZCFA5CNFSM4IG6557KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25IBFI#issuecomment-515539093, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAPL2KIIYLUHA5HFGT34DUTQBMZCFANCNFSM4IG6557A.

Codecov Report

Merging #2928 into dev will decrease coverage by 0.02%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##              dev    #2928      +/-   ##
==========================================
- Coverage   95.21%   95.18%   -0.03%
==========================================
  Files          73       73
  Lines       13993    14016      +23
==========================================
+ Hits        13323    13341      +18
- Misses        670      675       +5

Impacted Files
Coverage Δ

qiita_db/test/test_meta_util.py
99.14% <ø> (ø)
:arrow_up:

qiita_db/test/test_study.py
99.78% <100%> (ø)
:arrow_up:

qiita_db/study.py
95.31% <100%> (+0.06%)
:arrow_up:

qiita_db/meta_util.py
88.54% <87.23%> (-1.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2395b...5040e5a. Read the comment docs.


Simplifies API per feedback

During #425, @neilalexander gave constructive feedback that the API is
both moving fast, and not good enough yet. This attempts to reduce the
incidental complexity at the cost of a little conflation.
odd presence of wasm and wasi packages -> api package
We had public API packages in wasm and wasi, which helped us avoid
leaking too many internals as public. That these had names that look
like there should be implementations in them cause unnecessary
confusion. This squashes both into one package "api" which has no
package collission with anything.
We've long struggled with the poorly specified and non-uniformly
implemented WASI specification. Trying to bring visibility to its
constraints knowing they are routinely invalid taints our API for no
good reason. This removes all WASI commands for a default to invoke
the function _start if it exists. In doing so, there's only one path
to start a module.
Reuse of Module for pre and post instantiation to Binary -> Module
Module is defined by WebAssembly in many phases, from decoded to
instantiated. However, using the same noun in multiple packages is very
confusing. We at one point tried a name "DecodedModule" or
"InstantiatedModule", but this is a fools errand. By deviating slightly
from the spec we can make it unambiguous what a module is.
This make a result of compilation a Binary, retaining Module for an
instantiated one. In doing so, there's no longer any name conflicts
whatsoever.
Confusion about config -> ModuleConfig
Also caused by splitting wasm into wasm+wasi is configuration. This
conflates both into the same type ModuleConfig as it is simpler than
trying to explain a "will never be finished" api of wasi snapshot-01 in
routine use of WebAssembly. In other words, this further moves WASI out
of the foreground as it has been nothing but burden.
--- a/README.md
+++ b/README.md
@@ -49,8 +49,8 @@ For example, here's how you can allow WebAssembly modules to read
 wasi, err := r.InstantiateModule(wazero.WASISnapshotPreview1())
 defer wasi.Close()

-sysConfig := wazero.NewSysConfig().WithFS(os.DirFS("/work/home"))
-module, err := wazero.StartWASICommandWithConfig(r, compiled, sysConfig)
+config := wazero.ModuleConfig().WithFS(os.DirFS("/work/home"))
+module, err := r.InstantiateModule(binary, config)
 defer module.Close()
 ...

cc @pims @pkedy @inkeliz @tonyhb @MutatePat @wdvxdr1123 @leighmcculloch @birros @wuhuizuo I'm usually in favor of less is best, so hope these changes are ok with you.

forked an issue about the spectest drift as that happens on main also https://github.com/tetratelabs/wazero/issues/428

ps after a shower I realized we no longer need an internal package for wasi anymore. This allows us to put the whole thing in the the top-level wasi package which is more intuitive, especially as we'll likely need one for assemblyscript if for no other reason to stop copy/pasting the same abort handler :D

OK I've isolated wasi into the top-level package "wasi" and unexported everything except this.
-wasi, err := r.InstantiateModule(wazero.WASISnapshotPreview1())
-defer wasi.Close()
+wm, err := wasi.InstantiateSnapshotPreview1(r)
+defer wm.Close()

So the good news is now there's only one place wasi is used and there's no coupling at all between that and wazero. It could even be in another repo (though here is far more convenient).

Thanks for the 👍 folks, and thanks especially to @neilalexander for speaking up.
I'll leave #425 open a bit though as there are some issues to address including better docs (ex the code snippets aren't tested).

ps our soft target for API stability (at least end of thrash even if little things have to change) is gluecon which is the first conference we'll talk about wazero.
We don't want to to advertise things generally too much when the API isn't stable, as it is not nice to lead too many into something that will cause them pain. This is why we are working so hard to figure out what is the best even if perfection will never happen.
We appreciate that folks are here using wazero knowing it is unstable as there's a chicken egg problem on api stability.. you want things to not impact too many on change, but still need different perspectives or else you can cement something not great!
I will continue raising PRs on drift to anything I know uses wazero unless someone says don't (because they don't need it etc). I feel it is important to have responsibility and it also teaches me a lot each time, and as a project maintainer, I have to understand what people are doing or things wander. I really appreciate that folks have been helping me update their code.
Anyway, we still have 6 weeks even under this schedule to knock out any other kinks, so please speak up!

PS here's a comprehensive example that uses all our recent API changes https://github.com/wapc/wapc-go/pull/21


Thread-safety for parallel calculations and reading results

Hi,
does the dss_sharp extension support multithreaded access to OpenDSS for parallel, separate circuits solve and reading element results? I know that the basic OpenDSS COM server doesn't.
Regards,
Maciej

Not yet, but most of the work for that is already done for the base library (DSS C-API) -- not released, still under testing but no major surprises so far. It's a different implementation that supports completely independent OpenDSS instances in the same process, which can be used in separate threads (you'd only need manual locking if you're sharing the same instance across multiple threads, etc.).
We should have a new release of DSS Sharp supporting both this new version of DSS C-API and error-to-exception mapping by the end of the year.

Finally merged!


Clean Up Dead outlines.integrations Code

What behavior of the library made you think about the improvement?
With all models other than exllamav2 having a single integration implementation via outlines.generate.api.SequenceGeneratorAdapter and outlines.processors, we don't need outlines.integrations.

outlines.integrations.transformers  has RegexPrefixAllowedTokens and JSONPrefixAllowedTokens which are now handled by outlines.processors
outlines.integrations.llamacpp has logits processors which are redundant with outlines.processors
outlines.integrations.vllm has logits processors which are redundant with outlines.processors
outlines.integrations.utils has adapt_tokenizer, useful for FSM construction, and convert_json_schema_to_str, used for the three model integrations listed above

After the vLLM integration, we no longer need outlines.integrations
How would you like it to behave?
Get rid of outlines/integrations/ and tests/generate/test_integration_*.py

Remove outlines.integrations.transformers, outlines.integrations.llamacpp, and outlines.integrations.vllm
Remove outlines.integrations.utils, but move def adapt_tokenizer(...) to outlines.models.tokenizer

We should do this once #1010 has been merged and then release 0.1.0


rename release project for packit from packit-master to packit-dev

https://copr.fedorainfracloud.org/coprs/packit/packit-master/
don't forget to update docs as well
TODO:

[ ] Ask the Copr team if it's possible to rename the project
[ ] Rename to packit-dev
[ ] Announce it to our users
[ ] also change it for ogr
[ ] update the documentation

Same with ogr as it appears.

Renaming doesn't seem to be possible—as we discussed it today.

There are no downloads in the last 7 days, I would probably bite the bullet :shrugs:


Unable to install AutoFixture

I am having issue wtih AutoFixture I can't figure out what the real cause of the issue is.
PM> Install-Package AutoFixture
Attempting to gather dependency information for package 'AutoFixture.3.48.0' with respect to project 'Tests\SquareConnect.Tests', targeting '.NETFramework,Version=v4.5.2'
Attempting to resolve dependencies for package 'AutoFixture.3.48.0' with DependencyBehavior 'Lowest'
Resolving actions to install package 'AutoFixture.3.48.0'
Resolved actions to install package 'AutoFixture.3.48.0'
Install failed. Rolling back...
Package 'AutoFixture.3.48.0' does not exist in project 'SquareConnect.Tests'
Package 'AutoFixture.3.48.0' does not exist in folder 'D:\Documents\GitHub\SqaureConnect.NET\packages'
Install-Package : '.', hexadecimal value 0x00, is an invalid character. Line 1, position 1.
At line:1 char:1
+ Install-Package AutoFixture
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

This looks more like a NuGet issue:

Package 'AutoFixture.3.48.0' does not exist in [...]

Do you use custom NuGet Package Source(s)?

I do, but I have it explicitly set to 'nuget.org'
http://image.prntscr.com/image/62c947d539d34db0a6683aff0cad55a4.png

The NuGet Package for AutoFixture has no dependencies. It still looks like a NuGet issue to me...

Makes sense.
Do you have any idea where I could go to correct it possibly?

Currently, I have no idea :neutral_face:

Was probably the VS Update 3 :(

I'm going to move this over tot he nuget people thanks!

If you find that it's not a NuGet problem after all , then please return here so that we can help you get this sorted out.

It is a Nuget issue after all, I manually edited the packages.config and pushed it out to CI and it no issues https://ci.appveyor.com/project/DarnellWilliams/sqaureconnect-net

Hey guys I am sorry to bug you again, I believe it is not entirely nuget's fault. After pushing the change I made to the packages.confg file, I was actually able to restore package tageting 4.5, bt the install failed always for 4.5.2 using Nuget 3.4.4, mayeb it has to do with a change that nuget.3.4.2 and above brought to fix a bug they used to have.
this was what happened when I set it to 4.5
PM> Install-Package AutoFixture -Verbose
  GET https://api.nuget.org/v3/registration1-gz/autofixture/index.json
  OK https://api.nuget.org/v3/registration1-gz/autofixture/index.json 169ms
  GET https://api.nuget.org/v3/registration1-gz/autofixture/page/2.0.0/3.6.2.json
  GET https://api.nuget.org/v3/registration1-gz/autofixture/page/3.6.3/3.24.6.json
  GET https://api.nuget.org/v3/registration1-gz/autofixture/page/3.25.0/3.47.0.json
  GET https://api.nuget.org/v3/registration1-gz/autofixture/page/3.47.1/3.48.0.json
  OK https://api.nuget.org/v3/registration1-gz/autofixture/page/2.0.0/3.6.2.json 137ms
  OK https://api.nuget.org/v3/registration1-gz/autofixture/page/3.6.3/3.24.6.json 173ms
  OK https://api.nuget.org/v3/registration1-gz/autofixture/page/3.25.0/3.47.0.json 271ms
  OK https://api.nuget.org/v3/registration1-gz/autofixture/page/3.47.1/3.48.0.json 317ms

Attempting to gather dependency information for package 'AutoFixture.3.48.0' with respect to project 'Tests\SquareConnect.Tests', targeting '.NETFramework,Version=v4.5'
Package AutoFixture from source nuget.org gathered from cache.
  GET https://api.nuget.org/v3/registration1-gz/autofixture.automoq/index.json
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'
  GET https://api.nuget.org/v3/registration1-gz/moq/index.json
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='moq'
  GET https://api.nuget.org/v3/registration1-gz/castle.core/index.json
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='Castle.Core'
  OK https://api.nuget.org/v3/registration1-gz/autofixture.automoq/index.json 157ms
  GET https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/2.0.0/3.6.7.json
  GET https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/3.6.8/3.30.2.json
  GET https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/3.30.3/3.48.0.json
  OK https://api.nuget.org/v3/registration1-gz/castle.core/index.json 278ms
  OK https://api.nuget.org/v3/registration1-gz/moq/index.json 366ms
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq' 389ms
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=40
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='moq' 421ms
  OK https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/2.0.0/3.6.7.json 266ms
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='Castle.Core' 468ms
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=40 220ms
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=80
  OK https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/3.6.8/3.30.2.json 584ms
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=80 142ms
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=120
  OK https://api.nuget.org/v3/registration1-gz/autofixture.automoq/page/3.30.3/3.48.0.json 663ms
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=120 181ms
  GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=160
  OK https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/FindPackagesById()?id='AutoFixture.AutoMoq'&$skip=160 133ms
Total number of results gathered : 22
Gathering dependency information took 1.13 sec
Summary of time taken to gather dependencies per source :
D:\Documents\GitHub\SqaureConnect.NET\packages	-	7.95 ms
C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\	-	0.31 ms
https://api.nuget.org/v3/index.json	-	1.5 sec
https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/	-	2.02 sec
Attempting to resolve dependencies for package 'AutoFixture.3.48.0' with DependencyBehavior 'Lowest'
One or more unresolved package dependency constraints detected in the existing packages.config file. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'AutoFixture 3.40.0'
Resolving dependency information took 0 ms
Resolving actions to install package 'AutoFixture.3.48.0'
Resolved actions to install package 'AutoFixture.3.48.0'
Retrieving package 'AutoFixture 3.48.0' from 'nuget.org'.
Removed package 'AutoFixture.3.40.0' from 'packages.config'
Removed reference 'Ploeh.AutoFixture.dll' from project 'SquareConnect.Tests'
Successfully uninstalled 'AutoFixture.3.40.0' from SquareConnect.Tests
Install failed. Rolling back...
Package 'AutoFixture.3.48.0' does not exist in project 'SquareConnect.Tests'
For adding package 'AutoFixture.3.40.0' to project 'SquareConnect.Tests' that targets 'net45'.
For adding package 'AutoFixture.3.40.0' to project 'SquareConnect.Tests' that targets 'net45'.
Package 'AutoFixture.3.40.0' already exists in folder 'D:\Documents\GitHub\SqaureConnect.NET\packages'
Added reference 'Ploeh.AutoFixture' to project 'SquareConnect.Tests'.
Added package 'AutoFixture.3.40.0' to 'packages.config'
For adding package 'AutoFixture.3.40.0' to project 'SquareConnect.Tests' that targets 'net45'.
Executing script file 'D:\Documents\GitHub\SqaureConnect.NET\packages\AutoFixture.3.40.0\tools\Install.ps1'
Package 'AutoFixture.3.48.0' does not exist in folder 'D:\Documents\GitHub\SqaureConnect.NET\packages'
Executing nuget actions took 639.78 ms
Install-Package : '.', hexadecimal value 0x00, is an invalid character. Line 1, position 1.
At line:1 char:1
+ Install-Package AutoFixture -Verbose
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Time Elapsed: 00:00:02.2901887

Maybe there is something that can be done to rebuild the packages?

How can I reproduce this issue? If I create a new C# project and add AutoFixture, it works:
PM> Install-Package AutoFixture
Attempting to gather dependency information for package 'AutoFixture.3.48.0' with respect to project 'ClassLibrary1', targeting '.NETFramework,Version=v4.5.2'
Attempting to resolve dependencies for package 'AutoFixture.3.48.0' with DependencyBehavior 'Lowest'
Resolving actions to install package 'AutoFixture.3.48.0'
Resolved actions to install package 'AutoFixture.3.48.0'
  GET https://api.nuget.org/packages/autofixture.3.48.0.nupkg
  OK https://api.nuget.org/packages/autofixture.3.48.0.nupkg 14ms
Installing AutoFixture 3.48.0.
Adding package 'AutoFixture.3.48.0' to folder 'C:\Users\mark\Desktop\ClassLibrary1\packages'
Added package 'AutoFixture.3.48.0' to folder 'C:\Users\mark\Desktop\ClassLibrary1\packages'
Added package 'AutoFixture.3.48.0' to 'packages.config'
Executing script file 'C:\Users\mark\Desktop\ClassLibrary1\packages\AutoFixture.3.48.0\tools\Install.ps1'
Successfully installed 'AutoFixture 3.48.0' to ClassLibrary1

The strange thing for me is that I create a new project as you did but it failed. to install.
PM> Install-Package AutoFixture
Attempting to gather dependency information for package 'AutoFixture.3.48.0' with respect to project 'ClassLibrary1', targeting '.NETFramework,Version=v4.5.2'
Gathering dependency information took 43.49 ms
Attempting to resolve dependencies for package 'AutoFixture.3.48.0' with DependencyBehavior 'Lowest'
Resolving dependency information took 0 ms
Resolving actions to install package 'AutoFixture.3.48.0'
Resolved actions to install package 'AutoFixture.3.48.0'
Retrieving package 'AutoFixture 3.48.0' from 'nuget.org'.
Install failed. Rolling back...
Package 'AutoFixture.3.48.0' does not exist in project 'ClassLibrary1'
Package 'AutoFixture.3.48.0' does not exist in folder 'D:\Documents\GitHub\PastorsSuite\packages'
Executing nuget actions took 108.94 ms
Install-Package : '.', hexadecimal value 0x00, is an invalid character. Line
1, position 1.
At line:1 char:1
+ Install-Package AutoFixture
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManag
   ement.PowerShellCmdlets.InstallPackageCommand

Time Elapsed: 00:00:01.2079268

Ugh the error means that there is an issue witht he encoding of the file somewhere...

It could be related to Visual Studio 2105 update 3, as you've already speculated. I'm still using Visual Studio 2015 update 2, since I haven't been presented with the option to update yet.

You that particular update is optional, it came about with the release of .net core 1.0.0 it adds support for creating .net core projects into VS 2015.
https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update3-vs

Now I feel even less inclined to install update 3 :disappointed:
It'd be interesting to see if the above error can be reproduced by other people with Visual Studio 2015 update 3.

I'm also on Update 2 so can't really help for the time being.

Issue in progress Nuget/Home#3078

I think you guys released a new package? The new one installed successfully for me.


Relax rubocop versioning

Personally, I think we don't need to lock rubocop to specific version.
With this PR, an user who wants to run pronto-rubocop with rubocop X.Y.Z, can specifies rubocop version in their Gemfile like this:
gem 'pronto-rubocop'
gem 'rubocop', '~> X.Y.Z'

What do you think? @mmozuras

Just ran into this issue and came here to see if there was a good solution. It would be really nice to be able to upgrade on my own schedule.

@juno @tscheffe pronto-rubocop is not using an official API, so they're not promising not to break it. In case they did, it might be inconvenient and confusing for users of pronto. But now there's a very real inconvenience of having update the gem whenever a new version of rubocop comes out.
Any other trade-offs we should consider?

It's a tough problem without a true, good solution.
One more issue to consider is that it's uncommon for Gems to be entirely forwards compatible with their core dependencies. As a new user I wouldn't expect to have to lock a version of Rubocop in my Gemfile along with pronto-rubocop. This is something that could be explained around with a big warning in the README but thats never a guarantee. As a power user this provides a great amount of flexability.
In this case I think I'm going to be in lock-step with Rubocop with or without Pronto, and so opening this up lets me do that on my own. I would expect most people who use this gem are also going to be on the "power user" end of the spectrum and would be okay with this.

Please do relax the version number requirement on rubocop.  Currently this gem forces running an obsolete version of rubocop, and that's not good at all.  I can always lock a version of rubocop other ways, but usually I just want to run the latest.

Done :smile:
https://github.com/mmozuras/pronto-rubocop/commit/ebe226866cee571133a9b8c0245e0701588885fa
Thanks for convincing me, I now truly believe this is for the better :bow:

Thanks!  Can you do the same for the other pronto-... gems?  That will make it easier to me to upgrade gems.

@david-a-wheeler every gem that was updated to depend on pronto 0.6.0 has relaxed versioning. Will be true for every one of them :smile:

@mmozuras - thank you so much. These updated gems have completely eliminated all my absolute Direct dependencies, and have enabled me to eliminate most of my obsolete indirect dependencies also.
Very awesome.

@mmozuras thank you very much and sorry for the long delay in my response.
pronto is really helpful and saves our team from flood of tech debt!
@david-a-wheeler thank you for follow-up this. :+1:


Cannot inherit training_step() or configure_optimizers()

🐛 Bug

A model will not run if the methods: training_step or configure_optimizers() are not explicitly defined and are instead inherited.
To Reproduce
TrainingStep and  ConfigureOptimizers are inherited in the BoringModel:

import os

import torch
from torch.utils.data import DataLoader, Dataset

from pytorch_lightning import LightningModule, Trainer

class RandomDataset(Dataset):
    def __init__(self, size, length):
        self.len = length
        self.data = torch.randn(length, size)

    def __getitem__(self, index):
        return self.data[index]

    def __len__(self):
        return self.len

class ConfigureOptimizers():
    def configure_optimizers(self):
        return torch.optim.SGD(self.layer.parameters(), lr=0.1)

class TrainingStep():
    def training_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("train_loss", loss)
        return {"loss": loss}

class BoringModel(LightningModule, TrainingStep, ConfigureOptimizers):
    def __init__(self):
        super().__init__()
        self.layer = torch.nn.Linear(32, 2)

    def forward(self, x):
        return self.layer(x)

    def validation_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("valid_loss", loss)

    def test_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("test_loss", loss)

def run():
    train_data = DataLoader(RandomDataset(32, 64), batch_size=2)
    val_data = DataLoader(RandomDataset(32, 64), batch_size=2)
    test_data = DataLoader(RandomDataset(32, 64), batch_size=2)

    model = BoringModel()
    trainer = Trainer(
        default_root_dir=os.getcwd(),
        limit_train_batches=1,
        limit_val_batches=1,
        num_sanity_val_steps=0,
        max_epochs=1,
        enable_model_summary=False,
    )
    trainer.fit(model, train_dataloaders=train_data, val_dataloaders=val_data)
    trainer.test(model, dataloaders=test_data)

if __name__ == "__main__":
    run()

https://github.com/PyTorchLightning/pytorch-lightning/blob/1c28f361d47257feb0bd34cbc8d41642a1f0a2ab/pytorch_lightning/trainer/configuration_validator.py#L54-L63
Expected behavior

No error should be raised.  I wanted my models to share the same training loop.
Environment

PyTorch Lightning Version: 1.5.0
PyTorch Version: 1.9.0
Python version: 3.9
OS (e.g., Linux): Linux

This is my work around for now:
import os

import torch
from torch.utils.data import DataLoader, Dataset

from pytorch_lightning import LightningModule, Trainer

class RandomDataset(Dataset):
    def __init__(self, size, length):
        self.len = length
        self.data = torch.randn(length, size)

    def __getitem__(self, index):
        return self.data[index]

    def __len__(self):
        return self.len

class ConfigureOptimizers():
    def my_configure_optimizers(self):
        return torch.optim.SGD(self.layer.parameters(), lr=0.1)

class TrainingStep():
    def my_training_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("train_loss", loss)
        return {"loss": loss}

class BoringModel(LightningModule, TrainingStep, ConfigureOptimizers):
    def __init__(self):
        super().__init__()
        self.layer = torch.nn.Linear(32, 2)

    def forward(self, x):
        return self.layer(x)

    def validation_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("valid_loss", loss)

    def test_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("test_loss", loss)

    def training_step(self, *args, **kwargs):                 #<------------------------
        return self.my_training_step(*args, **kwargs)         #<------------------------

    def configure_optimizers(self, *args, **kwargs):          #<------------------------
        return self.my_configure_optimizers(*args, **kwargs)  #<------------------------

def run():
    train_data = DataLoader(RandomDataset(32, 64), batch_size=2)
    val_data = DataLoader(RandomDataset(32, 64), batch_size=2)
    test_data = DataLoader(RandomDataset(32, 64), batch_size=2)

    model = BoringModel()
    trainer = Trainer(
        default_root_dir=os.getcwd(),
        limit_train_batches=1,
        limit_val_batches=1,
        num_sanity_val_steps=0,
        max_epochs=1,
        enable_model_summary=False,
    )
    trainer.fit(model, train_dataloaders=train_data, val_dataloaders=val_data)
    trainer.test(model, dataloaders=test_data)

if __name__ == "__main__":
    run()

@carmocca do you think we should extend the is_overridden function to support checking several parents?
Something like https://github.com/PyTorchLightning/pytorch-lightning/commit/40ac0b1a3f1f373e0f37ceb508dcc18a53772b90 (rough draft)

Yes

Ok thanks, just wanted to make sure I don't go in a completely wrong direction with this. Will send a PR and see if tests pass.

@Big-Tree @carmocca I looked at this again and realized this is just an MRO issue. You need to change
class BoringModel(LightningModule, TrainingStep, ConfigureOptimizers):

to
class BoringModel(TrainingStep, ConfigureOptimizers, LightningModule):

(LightningModule goes last).
If you have
class X(A, B, C)

Python will search for B.training_step only if A does not have one defined.

Hey @awaelchli,
Do you believe Lightning could introspect the mro from the user model and share a warning if not defined this way ?

That would lead to false positives, so I advise against it. Also, in most cases the use of multiple inheritance is not well justified, and if it is, the user is the expert anyway and has to know about these things.

https://github.com/PyTorchLightning/pytorch-lightning/issues/10377#issuecomment-966717846 Should solve this issue pretty well. Feel free to reopen the issue if further questions arise.


Removed unused code from bigtable_lib.cc

Warning fix:
tensorflow/contrib/bigtable/kernels/bigtable_lib.cc:24:8: warning: variable 'grpc_code' set but not used [-Wunused-but-set-variable]

already addressed in #25916

Thank you @joyalbin for investigating this! Fortunately @siju-samuel has the fix in #25916 (as he pointed out above). As a result, I'm going to close this PR.
All the best,
-Brennan


How to test websocket handlers without running a server?

The tests in test/aleph/websocket_test.clj all seem to set up a HTTP server.
It's pretty conventional to test ring applications without running a server, just by passing a mock request to the app routing, constructed using something like peridot or ring-mock.
How would I go about constructing a websocket mock request in tests, that would allow testing the websocket handler without running a full server?

It seems like you can emulate it with manifold.stream/splice - just use it in tests instead of the value returned by aleph.http/websocket-connection.
In my case this code solved the problem:
(def ws-conn
  (atom nil))

(defn with-ws [tests]
  (let [server->client (s/stream)
        client->server (s/stream)]
    (reset! ws-conn
            (s/splice server->client
                      client->server))
    (tests)
    (s/close! @ws-conn)
    (reset! ws-conn nil)))

;; then in the test namespace
(use-fixtures :each with-ws)

;; then pass @ws-conn to the websocket handler function and test by:
;; sending to WS
(s/put! (.source @ws-conn) :data)
;; and reading from WS
(s/take! (.sink @ws-conn))

Closing the issue. @sorsasampo, if you have more question or need more detailed example, feel free to re-open.


Fix: calendar filter divider

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #70
Fix: #80
Test URLs:

Before: https://main--accenture-newsroom--hlxsites.hlx.page/
After: https://59884-calendar-filter--accenture-newsroom--hlxsites.hlx.page/

@zozo-j can you please resolve conflicts with other changes that have already been merged. make sure the other changes are pulled into your branch and resolve anything you want to change based on that. Thanks!


Change is broken for segmented buttons

The new styling does not work yet for segmented buttons.

Fixed in rebased commit.


Dev to test

Overview
Links to jira tickets

{Include links to all of the applicable Jira tickets}

This PR contains the following changes

{List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

[ ] New feature (change which adds functionality)
[ ] Bug fix (change which fixes an issue)
[ ] Misc cleanup / Refactoring / Documentation
[ ] Version change

Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General

[ ] I have performed a self-review of my own code
[ ] My code follows the style guidelines of this project
[ ] New and existing unit tests pass locally with my changes

Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc and inform future developers

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation

Tests

[ ] I have added/updated unit tests for any new code I've added/updated
[ ] I have added/updated Postman tests to account for any new/updated code

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots, if applicable.

Moving in to test. Building out the full pipeline.

Moving in to test. Building out the full pipeline.


Fixes generate static variable and static function

BUG in release 5.1.1, code for example:
package {
	public class Main {
		public function Main() {
			Main.test|;
		}
	}
}

result after generating variable:
package {
	public class Main {
		private var test;//must be private static var test;
		public function Main() {
			Main.test;
		}
	}
}

BUG in developmnet version if setting generate explicit scope is true, code for example:
package;
public class Main {
	public static function main() {
		test|;
	}
}

result after generating variable:
package;
public class Main {
	static private var test;
	public static function main() {
		this.test;//must be Main.test
	}
}

@elsassph @Neverbirth please review this PR.

There doesn't seem to be unit tests taking into account the explicit scope case, aren't they? They could be added, what do you think?

I doubt that I understood correctly your 1st comment(( You could say, in more detail, what should I do?

I mean that you could make tests where you set the explicit scope setting to true, and then validate that everything is working correctly. I hope I explained myself better this time.
I don't think it's mandatory in order to approve the PR, but if you can do it it will be nice to have more coverture of the code.

Now I understand, thank you, I will refactor soon

I'll reopen this PR tonight


CARDS-1463: Computed questions should have a data type

Add an "entryMode" flag, with default mode "user" and secondary mode
"computed"
Add computed field support for most dataTypes:

boolean
date (year, date and datetime)
long
double
decimal
vocabulary
time (hh:mm, mm:ss)
text

Add tests for each dataType to ServersideComputedTest and ComputedTest

BUG: Navigating off ServersideComputedTest form brings the login dialog.

Previously reported problems are fixed, however both test forms: Computed Field Test and Serverside Computed Field Test have some text fields defined as computed. For example:

instead of:

Also all proms forms need to be adjusted. e.g.

QUESTION: Entry mode computed has the following 3 display modes:

input
formatted
hidden

The difference between input and formatted is minimal. input displays in gray fonts, has line below and limits the length of the field.
Is input mode needed?
If not, do we than need formatted mode? Can't we always assume that computed are formatted and have hidden as a property of boolean type?

Can we display the following together in the designer?

Data type , Entry mode and Display mode
Min answers and Max answers

Not sure if this is a problem.
When I opened the smoking-history-v2-referral-summary in edit mode and tried to save it without doing any changes I got this:

Once I put " " it stopped complaining.

Not sure about Unsupported computed displayed in red fonts for these 2 fields:

QUESTION: Entry mode computed has the following 3 Display modes:

input
formatted
hidden

The difference between input and formatted is minimal. input displays in gray fonts, has line below and limits the length of the field. Is input mode needed? If not, do we than need formatted mode? Can't we always assume that computed are formatted and have hidden as a property of boolean type?

The inputdisplay mode was originally the only one, since computed questions were developed before markdown integration (which allowed the introduction of the formatted display mode).
I don't really agree with removing it. For number answers that actually fit in an input, facilitates consistent alignment throughout the form, especially when there are units of measurement. I am, however, open to making formatted the default display mode instead of input. However, this is out of scope for 1463 and should be decided and implemented separately so as to not hold the merge of this PR.

Not sure about Unsupported computed displayed in red fonts for these 2 fields:

That's my bad, I forgot to update the Serverside Computed Field Test questionnaire and now the wizard doesn't understand dataType: computed. Fixing.

Not sure about Unsupported computed displayed in red fonts for these 2 fields:

That's my bad, I forgot to update the Serverside Computed Field Test questionnaire and now the wizard doesn't understand dataType: computed. Fixing.

Done in f98ea1b .

Can we display the following together in the designer?

Data type , Entry mode and Display mode
Min answers and Max answers

Not sure why they're scrambled like this. Please make a separate task and I'll look into it.

Not sure if this is a problem. When I opened the smoking-history-v2-referral-summary in edit mode and tried to save it without doing any changes I got this:
Once I put " " in the Text field, it stopped complaining.

That's because we're ignoring string values consisting of only white spaces: https://github.com/data-team-uhn/cards/blob/dev/modules/data-entry/src/main/frontend/src/questionnaireEditor/TextInput.jsx#L34.
Please make a task, it's an easy fix and hopefully won't have unwanted side effects (tbd by testing).

Can we display the following together in the designer?

Data type , Entry mode and Display mode
Min answers and Max answers

Because of how the presence of some properties depends on the value of others, we can't always display Data type , Entry mode and Display mode together. However commit 8985e50 ensures that at least Min answers and Max answers are always together. It also restricts the possible values of minAnswers to 0 and 1 for questions with entryMode=computed, to match the current implementation.

The problem described in CARDS-1552 is still present.
https://user-images.githubusercontent.com/23243244/146568178-ef4bdac6-7a0f-43af-acac-ab99c83b2c6c.mp4


There is no chain_id= 97 for 1.4.1 contracts

I want to test gnosis multisig creation on BSC testnet, but I can't do it, because there is no BSC testnet chain id for 1.4.1 version.
Please check: https://github.com/safe-global/safe-deployments/blob/v1.28.0/src/assets/v1.4.1/safe_proxy_factory.json
But in network contract is exist: https://testnet.bscscan.com/address/0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67

I want to test gnosis multisig creation on BSC testnet, but I can't do it, because there is no BSC testnet chain id for 1.4.1 version. Please check: https://github.com/safe-global/safe-deployments/blob/v1.28.0/src/assets/v1.4.1/safe_proxy_factory.json
But in network contract is exist: https://testnet.bscscan.com/address/0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67

Since the deployment process is trustless (anyone can deploy contracts), such things may happen. You create a PR to add the address to the list of deployments

@mmv08 the PR is waiting for review, thanks.

Closed by #372


Update summerschools.yml

Summer School on Artificial Intelligence in Health and Life Sciences

Summer School on Artificial Intelligence in Health and Life Sciences


iff and iif implemented

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@kashwy as discussed, merging after updating release notes.


Types of Searches

http://www.gliffy.com/go/publish/image/9208865/L.png
We know that we'll probably need more methods in the concrete strategies in order to fully implement the strategy. In the meantime, we were wondering how the SearchEngine will connect to the Services? Is it a dependency to the interface?

Did we resolve this issue in our last couple of meetings? The question is a bit outdated with respect to the system architecture that was decided upon.
Feel free to reopen this if it is still relevant.


My nimbus asks for a code

I tried 0000 and 9999 etc. but none work.

If you're going through the "Everything else" section of the Bluetooth "Add a device", it will ask for a code.  Instead, use the "Bliuetooth" section and it should find it automatically.
I got answers here:
https://jilaxzone.com/2019/09/23/use-ios-mfi-controller-to-play-games-on-windows-pc-pc-games-steam-emulator-or-anything-on-pc/

Hey Guys,
This information seems incorrect, I am choosing the "Bluetooth" option not the "Other Devices" option, yet it still asks for a code, and no code that I use works, how do I get it to connect without asking for a code?
Video Attached
Settings 2020-07-10 01-29-44.zip
Thanks In Advance
Aaron


UI: Add a line marking 0% on Funding Chart

Subject of the issue
Community members suggested to add a line at 0% to make the Funding Chart look less 'naked'.
Suggestion:

Deliverables

Design horizontal line on Funding Chart for 0% value
Implement horizontal line based on design

same grey that is already being used on light/dark mode


Added locale support

Support UTF-8 locales
Moved environment setup after locale installation to prevent warning

try this: https://github.com/infrastlabs/docker-headless/blob/dev/_doc/mannual/b1-locale.md
docker run -it --rm -e L=zh_CN --net=host infrastlabs/docker-headless


How to fill current user into context?

I'm using the StandardServer. Now I need to handle authentication and authorization. I figured that my field resolvers should most likely get some info about currently authenticated user in $context and perform the related authorization. it is also confirmed in your documentation that context should be used for this purpose.
My question is how do I get this information from where I call $this->server->executeRequest($operation); to the callback I pass to ServerConfig::setContext()?
The solution is obviously the OperationParams object since I create it right before calling executeRequest and it is passed to the context callback. But where exactly in the OperationParams should this be? I'm guessing $extensions? Something like this? Any convention how I should or shouldn't use the extensions array?
$user = $this->authenticator->authenticateUser($request);
$content = $request->getContent();
$queryData = json_decode($content, true);
// error handling
$queryData['extensions']['__authentication'] = $user;
$operation = OperationParams::create($queryData);
$result = $this->server->executeRequest($operation);

...

$config = ServerConfig::create();
$config->...
$config->setContext(
	function (OperationParams $params, DocumentNode $doc, string $operationType) {
		$user = $params->extensions['__authentication'];
		// create and return context value with $user.
	}
);
return new StandardServer($config);

As you can see I mostly solved it. Just asking if this is the "best practice" how to get the current user to the field resolvers.

In most cases you don't even need to use a Closure:
$user = $this->authenticator->authenticateUser($request);
$context->user = $user;
$config->setContext($context);

A closure is useful only if your context depends on the query. But even then you can just use for closure:
$user = $this->authenticator->authenticateUser($request);
$context->user = $user;
$config->setContext(
    function (
        OperationParams $params,
        DocumentNode $doc,
        string $operationType
    ) use ($context) {
        $context->propertyDependingOnQuery = $watever;
        return $context;
    }
);

Does it help?

Not at all, I'm running the server inside an event loop (using Amphp) which means the StandardServer instance is created way sooner than a request comes and it will need process many requests, possibly even at the same time. So I certainly can't call $config->setContext() based on the request data.

Oh I see. The StandardServer was written with the standard PHP environment in mind 😬 But it uses a Helper class under the hood which does most of the work.
The idea was that people in non-standard environments could re-use parts of the standard flow via Helper and define their own pieces of logic when needed. I'd suggest looking at this class and maybe adding changes that would make things easier for your case in a PR.

Actually the StandardServer works just fine for me. The only thing is that any metadata the request has (such as the authenticated user) need to be part of the $result = $this->server->executeRequest($operation); call, which means they need to be inside the Operation object (or so I think anyway...).
As I wrote above, using the ['extensions'] part of Operation works just fine for this. I just wasn't entirely sure if this is correct usage since it isn't exactly documented anywhere. But yeah it works fine...
If the 'extensions' key is meant for something different than maybe we should add 'metadata' key to the Operations object?

Ah I see... I could call Helper::executeOperation($config, $operation) instead and use different $config for every call. But... I really think the configuration should be one-time setup and metadata better be part of the OperationParams so I like my current solution better than using Helper directly.

For a bit more context - here is how extensions appeared in the code: #413 Technically they are coming from clients but I guess you can use them for your case (just make sure that users can't override your extensions via query/post params).

I see, I guess I'll use something like ['extensions']['metadata']['currentUser'] and make sure to unset($queryData['extensions']['metadata']) to prevent possible security issues. Thanks for your feedback!


Communication error when CP doesn't send 0xFF as the first character

I don't know if the 0xFF as first character is mandatory but the access control I'm using as CP sends it only after it has received it from the DP. I've resolved the problem adding it at the beginning of the buffer when the length of received buffer is 0 and the first character is not 0xFF.
I've done this also in an old library release.

The spec does mention that there must be 1 byte-width-time of channel inactivity between packets and the first byte of a packet must be 0xFF.
Nevertheless, I've seen some devices that don't follow this strictly. I'll add a compile time macro to disable sending/expecting the mark byte.

You can now pass -DCONFIG_OSDP_SKIP_MARK_BYTE=on to cmake to disable the leading 0xFF sent/expected in all packets.


Ability to set event timezone

User story
When creating an event, I can't set or edit the event timezone. The property exists in the API/database and is actively used. The timezone is currently guessed from the user environment and not editable.
Best solution for this problem
Add a timezone picker in the create and edit forms. Default to the the user timezone or collective timezone.

yes!  100% also referenced https://github.com/opencollective/opencollective/issues/2159

@piamancini We're actually working on https://github.com/opencollective/opencollective/issues/2159. This is when testing the fix that I realized timezone was not editable.

@znarf Can I work on this?

@leonardohof sure

Timekeeping certainly seems a general catalyst for syncronisation of mutual renumerations...

@znarf Hi! What is missing to close the issue? Is missing something from my side?

🏆 This issue was completed by @leonardohof  as part as our first Hackathon.
To claim the bounty, you can either:

Submit an invoice to https://opencollective.com/engineering/expenses/new (please mention the issue number in the expense's title)
Or ask for an Open Collective gift card of the same value (to donate to other collectives)


Add jenkins prefix to signer credentials

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
Add jenkins prefix to signer credentials
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2342 (ff69449) into main (d395d5f) will increase coverage by 5.38%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2342      +/-   ##
=============================================
+ Coverage     94.61%   100.00%   +5.38%
=============================================
  Files           209         6     -203
  Lines          4309       105    -4204
  Branches         29        19      -10
=============================================
- Hits           4077       105    -3972
+ Misses          226         0     -226
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/jenkins/Messages.groovy

src/system/console.py

src/assemble_workflow/dist.py

src/sign_workflow/signer_pgp.py

src/manifests/manifests.py

.../bwc_test/bwc_test_runner_opensearch_dashboards.py

src/jenkins/BuildManifest.groovy

tests/jenkins/jobs/RunBwcTestScript_Jenkinsfile

...RunBwcTestScript_OpenSearch_Dashboards_Jenkinsfile

src/manifests/build/build_manifest_1_0.py

... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d395d5f...ff69449. Read the comment docs.


Generalize */fun starting with a-chol2

Summary
Generalizes inputs to functions that start with a - chol2. chol2inv depends on mdivide_left, mdivide_left_tri and mdivide_left_tri_low so these were generalized as well.
Tests
assign() had different requirements wrt compile time size for Eigen matrices and Eigen blocks. I changed that so it accepts all assignments Eigen does (It previously did that for blocks. For matrices it required same compile time sizes). That also changed some tests.
Side Effects
None.
Checklist

[x] Math issue #1470

[x] Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@andrjohns This is ready for another review.


workaround for squash rm issues

@mfojtik ptal

@hhorak fyi

@bparees LGTM but still interested to hear from Marek what is the root cause of this

@bparees need extra step, this one breaks as well

@mfojtik thanks. updated.


Add test edr handler

Coverage increased (+9.3%) to 61.681% when pulling 611c81bec884f42a268dadfbbefb8a84e8a67f8f on add_test_edr_handler into 40777e3fe4eb9f1422676aead1e080467549b052 on bridge2.0.

Coverage increased (+9.3%) to 61.681% when pulling 611c81bec884f42a268dadfbbefb8a84e8a67f8f on add_test_edr_handler into 40777e3fe4eb9f1422676aead1e080467549b052 on bridge2.0.

Coverage increased (+10.3%) to 62.743% when pulling 6bc36bc05151acfda9d6f60b9c0e8814361390d4 on add_test_edr_handler into 40777e3fe4eb9f1422676aead1e080467549b052 on bridge2.0.

Coverage increased (+11.5%) to 63.895% when pulling fc1a32d1105dcb03abe5a34f739fb54fa36f17f3 on add_test_edr_handler into 40777e3fe4eb9f1422676aead1e080467549b052 on bridge2.0.


CLI: Linking must not replace existing file

A user can already have a legitimate file/link /usr/local/bin/hyper.
https://hyper.sh/
A notification should be issued instead of overwriting.

On Linux, even without Hyper CLI, a link is created by the package installation. A post-install script is run to point this link to cli shell startup script instead of Electron bin.
If a file/link exists, I think that installation would fail.
On macOS, the link is checked and added at each start. We can't show an annoying notification at each start. Or we need to add an option to disable this check/add. But it seems to be overkill.
A solution could be to silently fail at startup and adding an item menu to manually Install Hyper CLI command in PATH with a confirmation/error notification.

I agree with silent fail at startup. I'm not sure what else we could do, other than providing a different path and track that. Which might be too much


When user tabs through the modal dialog for the first time, focus goes out of the dialog to the Show Modal button

Clarity Version: 3.1.1
WCAG 2.1 Guideline: 2.4.3 Focus Order
Test Environment:

Test URL: https://clarity.design/documentation/modals
OS: Windows 10
User Agents/Assistive Technologies: Firefox 76.0
Screen reader: NVDA 19.3.1

Steps to reproduce:

Open the test URL.
Move focus onto to the first Show Modal button present under Angular modals.
Activate the button by pressing the enter or space key and perform tab navigation.

Expected result:
Focus should be trapped within the dialog.
Actual result:
For the first time with forward tab navigation focus goes out of the dialog and goes to the Show Modal button. If the user presses the tab key again, the focus comes back to the dialog and stays within the dialog window tab key navigation.
Note: This issue is not observed with arrow key navigation.
Reporter Email<EMAIL_ADDRESS>

Hi there, this is an automated message.
In an effort to dedupe and track accessibility reports consistently, this issue is being closed and tracked internally with our Accessibility team. It will still be triaged and addressed as part of ongoing work.


Deprecate push_unhandled_input

The functionality of push_unhandled_input has changed so that it no longer propagates input events to SubViewports.
This makes it less predictable and it should be deprecated in favor of push_input which provides the same functionality and more.
Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
Implement https://github.com/godotengine/godot/pull/76926#issuecomment-1545417632

Thanks, I wasn't aware of that flag.

LGTM, AFAICT. TIWAGOS, though,

Thanks!


Made it possible to render the album art on the left side of the text.

This makes it possible to render the album art on the other side of the artist/track-information. I do not check if albumArtLocation is set to right, but rather not left. This will make it so it always displays, just maybe not in the desired location if there is a typo in the config.

Thanks for the PR!

@all-contributors add @MagMar94 for code

@all-contributors add @Vaggan for ideas, code, research


Remove "/" from href="" on generated HTML

Hello, I am trying to create the link to styles.css with the URL: ../styles.css, being like:
<link rel="stylesheet" href="../styles.css" />
The problem is, even with me specificating the path, it generates with
<link rel="stylesheet" href="/../styles.css" />
I want to remove that first "/" on href, how can I do it? Here is my code:
const extractCSS = new ExtractTextPlugin('../styles.css');

module: {
    rules: [
      {
        test: /\.scss$/,
        use: extractCSS.extract({
          use: 'css-loader'
        })
      }
    ]
  },
plugins: [extractCSS]

Sorry for the noob question, but I'm really struggling with this.

I've actually figured out another way with NodeJS.
processedSource = fileHTML.replace(
    '<link rel="stylesheet" href="/styles.css"/>',
    '<link rel="stylesheet" href="../styles.css" />'
);

Just used this script after the build and voilá!


Mask Detection using EfficientnetB3

On an additional note, I'd like to add a Live Webcam Feature to detect masks using EfficientNetB3.
Architecture :
tf.keras.applications.EfficientNetB3(
    include_top=True, weights='imagenet', input_tensor=None,
    input_shape=None, pooling=None, classes=1000,
    classifier_activation='softmax', **kwargs
)

Project Pipeline :

I'd like to work on this issue as part of GSSOC-21 and this will be implemented into This Folder.

You can work upon it Go Ahead :)


Command to support importing an ovpn config file

Would be awesome if there were support for important an ovpn config file. My use case is that I hop on and off new VPNs throughout the day (generated for cloud infra), so I'm constantly having to import these.

Great idea. I've pushed a new install command.
It's a little hacky: the output for tunnelblickctl install is not very helpful at the moment. Tunnelblick prompts you for your password, which blocks tunnelblickctl. However, if you enter the wrong password, it unblocks the AppleScript. So the newly installed tunnel may or may not appear in the output.
I'm opening a new issue to add a symmetric uninstall command. This will require a bit more work. To do it properly and remove the shadow configurations as well, we need to script the Tunnelblick GUI.

I released install without uninstall in 0.2.0.


Fixing issue #404

Fix cv2 error when using laptop cam: passing and integer instead of String

THX  you fix my problem~ :)

Hi, it seems that this repo is inactive for a while... (more than a year :worried:)
Would you consider to pass your changes to this fork https://github.com/Borda/keras-yolo3 ?