Add Quilt support

This was based on the Fabric support, with the necessary changes made.

Thank you very much for the contribution!
If possible, please change the commit message to something along the lines of feat(quilt-servers): init, since that would better fit with the conventions I've used so far.

Another small thing I noticed, could you add to the README to change

along with versions for the Fabric loader

into

along with versions for the Fabric and Quilt loaders

?

Friendly poke to see if this is still being worked on, i can help with adding some commits to this if help is needed.

Superseded by #7


Add support for np.delete

WIP: adding np.delete support to Numba. Fixes #3854
Currently, the implementation only works with the first two parameters: np.delete(array, obj). I will work soon to add support for the axis parameter.

Thanks for the PR. Please leave a comment when you'd like it reviewed! axis support is often troublesome, if you have something you are happy with without it, this can be reviewed and then axis added in another PR as you see fit?

Ok, I can work on adding axis support on another PR, then! Can you please review the PR?
Regards

Great, thanks. I've queued it for review.

Hi @stuartarchibald
Thanks for the feedback. I've addressed almost all of your comments. I need to work a bit more on the last two comments above which were not marked as resolved.

@guilhermeleobas thanks very much for your contributions so far! I've left a few comments on the code.

Hi @stuartarchibald and @esc
I have addressed all the comments and suggestions and I think its ready for a review.

Hi @stuartarchibald, I have addressed all the comments and its ready for review.

@guilhermeleobas since you have just implemented a NumPy function with overload I would really appreciate ❤  your feedback on:
https://github.com/numba/numba/pull/3951
In short, I wrote some docs about using overload in general and with NumPy functions to ease this process for contributors.

Travis timed out again on this one, I think we can assume the tests would all pass.

Hi, I think it's ready for the review.

@guilhermeleobas we recently cleaned up test_np_functions.py and activated style checking with flake8. It seems like there are still some flake8 errors left in your code:
numba/tests/test_np_functions.py:34:1: E302 expected 2 blank lines, found 1
numba/tests/test_np_functions.py:37:1: E302 expected 2 blank lines, found 1
numba/tests/test_np_functions.py:351:14: W291 trailing whitespace

I am not entirely certain why they are only showing up with the Linux py35_np111_cov test, but in any case, it is advisable to fix them.

To avoid redundant checking, we only run the flake8 test in one of the configurations, which happens to be the Python 3.5 / NumPy 1.11 configuration.  (The _cov indicates that it used to also run the coverage test, but we haven't figured out how to upload results to a coverage tracking service from Azure without risking leakage of a private token.  As a result, we turned off the coverage tracking on Azure, but the name persists.)

All done! Ready for another round of reviews.

Done! Ready for another review

@guilhermeleobas thanks for all your work on this, in the interests of getting it merged I've made a small alteration (basically just moved a couple of functions about). Congratulations on your first contribution to Numba!


Allow user to get plugin config from client

Closes #839
The implementation fetches the plugin config by calling its factory function within the PluginPackage and extracting the config from the resulting object.

It seems expensive to construct a plugin instance to get the config. What are the pros and cons of changing the PluginPackage type to include a pointer to the config?
export type PluginPackage<TConfig> = {
  factory: () => PluginModule<TConfig>;
  manifest: PluginPackageManifest;
  config: TConfig;
};

@krisbitney The main con that came to mind when looking at this issue was that we would need to trust the developer that their implementation of the PluginFactory for their plugin actually assigns the config being used by the plugin to that field (or assigns it at all).
This does sound like something we could enforce though, so it could be considered a moot point. 😄
My main issue in general here has to do with the recent work of moving away from plugin configs and placing any configuration into Env. I have actually recently worked on an issue that's related to this: https://github.com/polywrap/monorepo/pull/1060
The question of "how much time we want to spend on this?" kind of comes to mind, and whether we are really moving away from configs into envs, making even my implementation obsolete at one point in the future. And in any case, do we foresee that we'll be using this getConfig often enough to warrant us making these significant changes in order to be able to fetch the config of a plugin.
I'm sure that I'm missing something important when considering all of this and I'd love to chat regarding this so feel free to hit me up on Discord and we'll come up with something smart!

All of that makes sense. Thanks!

I don't think this feature makes sense, since we are trying to phase out plugins from the client
Even if it did, why not do client.getPlugin() then get the config from there?
On your point of moving from configs to envs, that's not completely true, configs can do what envs can not (e.g. pass objects by reference) so they will always have their place.

I agree with Jure, I think we should instead just expose a helper client.getPlugin(uri) method.


[IPv6] Add CBMC test for prvCheckRxData and prvStoreRxData together with prvTCPHandleState.

[IPv6] Add CBMC test for prvCheckRxData and prvStoreRxData together with prvTCPHandleState.
Description

Add CBMC test for prvCheckRxData and prvStoreRxData together with prvTCPHandleState.

Test Steps

cd test/cbmc/proof/
python3 prepare.py
cd test_case
make

Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is this PR dependent on any other PR?


[YUNIKORN-1975] Move to Node.js 18

What is this PR for?
https://nodejs.org/en/blog/announcements/nodejs16-eol
Node 16 has Reached its End-of-Life as of September 11, 2023.
node 18.17 is the latest LTS version.
What type of PR is it?

[x] - Improvement

What is the Jira issue?
YUNIKORN-1974

@craigcondit Please approve the CI. I have successfully built the Docker on my local machine with Node 18.17.

@craigcondit  I have updated the comment. Please take a look.


Uncaught TypeError: exec is not a function

I'm getting the following error when attempting to require google-translate-api:

Uncaught TypeError: exec is not a function

I'm including it with the following code:

const translate = require('google-translate-api');

When I look at my console, here is the code snippet it's complaining about:
`var isWindows = process.platform === 'win32'
var path = require('path')
var exec = require('child_process').exec
var osTmpdir = require('os-tmpdir')
var osHomedir = require('os-homedir')
// looking up envs is a bit costly.
// Also, sometimes we want to have a fallback
// Pass in a callback to wait for the fallback on failures
// After the first lookup, always returns the same thing.
function memo (key, lookup, fallback) {
var fell = false
var falling = false
exports[key] = function (cb) {
var val = lookup()
if (!val && !fell && !falling && fallback) {
fell = true
falling = true
exec(fallback, function (er, output, stderr) {
falling = false
if (er) return // oh well, we tried
val = output.trim()
})
}
exports[key] = function (cb) {
if (cb) process.nextTick(cb.bind(null, null, val))
return val
}
if (cb && !falling) process.nextTick(cb.bind(null, null, val))
return val
}
}`
Anyone know what the issue may be?
Thank you.

I was trying to build a web application that used this package, and I ran into the same issue as you. I think it's because this package is meant to be used in a backend node.js service rather than from a browser. I found the snippet that was err'ing out from the osenv package, and I noticed that some other javascript users ran into similar issues
ref: https://github.com/wildbit/postmark.js/issues/1

@BriungRi good call, it seems to be from the configstore package:
`% npm ls osenv
/project
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
Doesn't seem like @matheuss is still maintaining this repo

@BriungRi good call, it seems to be from the configstore package:
`% npm ls osenv
/project
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
Doesn't seem like @matheuss is still maintaining this repo


Prevent server error when making unauthorized GET requests to RefreshTokenViewSet

Leverages the IsAuthenticated DRF permission class to prevent anonymous requests to this ViewSet. get_queryset() is called before rejecting the request (in the browseable API at least) so it also needs to check if a user is authenticated before modifying the queryset. Fixes #12

would you like to update the tests to fix coverage regression ?


feat: list of bad words

A list of words that are punishable on Hypixel

todo: add BlockedMessage.ts event file w/ regex to detect blocked words and log them via devHook


SAM-3131 re-do fill-in-the-blank accessibility

Line 52: #{question.answerCounter} will call the getAnswerCounter() method in the backing bean


Create websocket.java

#4234
Motivation:
Explain why you're making this change and what problem you're trying to solve.
Modifications:

List the modifications you've made in detail.

Result:

Closes #. (If this resolves the issue.)
Describe the consequences that a user will face after this PR is merged.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@omshukla05 HI, thanks for sending a PR. 😉
Could you describe what you are going to do and trying to achieve with this PR so that we can continue to talk whether if it's possible or it's the right way to do?

Let me close this because there's no response from the author. Please reopen when you get ready.


Precify starting time indicator for live events

This changes the indicator from "x timeunits ago" to "Live for x timeunits" for live events. In these cases, the prettyDate function in time.tsx now extracts and returns the relevant parts of the respective RelativeTimeFormat string. For the purpose of building the correct string, corresponding translation keys were added.
This might not be the most elegant solution - maybe something like "Started 30 minutes ago" (german sth like "Gestartet (or maybe "Angefangen") vor 30 minuten") makes more sense, and would need less changes as it could reuse the same and complete string used by regular events with a simple prefix.
Closes #508

So... I pushed the "Starting in..."/"Started..." variant here, but also did the "Live in..."/"Live for..." option and made a draft PR (#617). I think they should more or less work the same, but I'm somehow not in love with the nested translations used there and kinda prefer the convenience of the RelativeTimeFormat.

So... I pushed the "Starting in..."/"Started..." variant here, but also did the "Live in..."/"Live for..." option and made a draft PR (#617). I think they should more or less work the same, but I'm somehow not in love with the nested translations used there and kinda prefer the convenience of the RelativeTimeFormat.

I prefer the version in this PR, i.e. "started {{...}}". Didn't think of that idea.
I only left two comments above.


IllegalArgumentException: can't add a _parent field that points to an already existing type

I am using elasticdump to backup and restore an index with a parent child mapping, and it's causing an exception to be thrown by elasticsearch.
java.lang.IllegalArgumentException: can't add a _parent field that points to an already existing type
I noticed that the elasticsearch transport attempts to create the child mapping before the parent mapping by simply sorting the Array by the _parent field. https://github.com/taskrabbit/elasticsearch-dump/blob/master/lib/transports/elasticsearch.js#L154
However, I believe this is causing the exception to be thrown, because all of the requests are sent in a loop, without waiting for the child mapping to be created and the successful response from elasticsearch.
Is there any way to use promises to control the requests, so that only one mapping is created at a time?

Can you clarify?
To copy an index properly, you need to export the mapping, the settings and the data.  If you export all 3 of those (3 separate files), and then load them into your new index in the proper order, does it not work?    This is what multidump does, and it seems to work for others.

I'm was using multidump to export the mapping, analyzer, and data json files, and using elasticdump command to import the three in order:
elasticdump --input=./index1.analyzer.json --output=http://localhost:9200 --type=analyzer --output-index=index1
elasticdump --input=./index1.mapping.json --output=http://localhost:9200 --type=mapping --output-index=index1
elasticdump --input=./index1.json --output=http://localhost:9200 --type=data --output-index=index1

The problem is that in step 2, when the mapping is being imported, elasticdump splits the mapping json into chunks and sends separate requests for each mapping. An attempt is made to send the mapping requests in the correct order, however, in the manner implemented you really have no control over when the requests are processed on the other end by elasticsearch. For now, I have stopped using elasticdump for the mapping import, and started using the elasticsearch REST API directly. The elasticsearch REST API actually supports importing an entire mapping.json in one request, and automatically handling the parent/child relationships. I am not sure why this library is doing the extra work of splitting the mapping into separate requests.

Experienced this issue at least once running the test suite for this project. Not surprisingly it doesn't happen every time
.... (beginning of test output, normal)...
    ES to ES dump should maintain parent-child relationships
      1) "before all" hook
....
      ✓ works
    es to stdout
      - works
    stdin to es
      - works

  transform script should be executed for written documents
    ✓ documents should have the new field computed by transform script

  58 passing (4m)
  2 pending
  1 failing

  1) parent child ES to ES dump should maintain parent-child relationships "before all" hook:
     Error: the object {
  "reason": "can't add a _parent field that points to an already existing type, that isn't already a parent"
  "root_cause": [
    {
      "reason": "can't add a _parent field that points to an already existing type, that isn't already a parent"
      "type": "illegal_argument_exception"
    }
  ]
  "type": "illegal_argument_exception"
  "uncaught": true
} was thrown, throw an Error :)
      at process._fatalException (bootstrap_node.js:292:26)

npm ERR! Test failed.  See above for more details.


[Bugfix] Parse the routingTableID correctly

Current Behaviour:
kube-vip does not start.
time="2024-06-25T11:45:39Z" level=fatal msg="strconv.ParseInt: parsing \"2347908769\": value out of range"

With this fix it should start.
References:

rtnetlink.h
RT_TABLE_MAX=0xFFFFFFFF

@thebsdbox I am just waiting on some feedback from @schrej


Extract param issue

I have a route with param like /user/:id and on request with /user/5e9868c3fb322670da33ef0e%3Fscore%3D0 (decoded is /user/5e9868c3fb322670da33ef0e?score=0) I have got the params.id = 5e9868c3fb322670da33ef0e?score=0
node - v14.5.0
express - 4.17.1
const express = require('express')
const app = express()
const port = 3333

app.get('/user/:id', (req, res) => res.json(req.params))

app.listen(port, () => console.log(`Express - listening at http://localhost:${port}`))

$ curl localhost:3333/user/5e9868c3fb322670da33ef0e%3Fscore%3D0
{"id":"5e9868c3fb322670da33ef0e?score=0"}

What is the issue?

What is the issue?

I'd guess that @iovanom expects that url parameters won't be part of a path parameter: id should have value 5e9868c3fb322670da33ef0e (without ?score=0 at the end).

The user needs to not encode the ? character for it to be part of the query and not the URL. You can confirm this behavior with a web browser as well. Run these in a Google inspector console:
> new URL('http://localhost:3333/user/5e9868c3fb322670da33ef0e%3Fscore%3D0').search
""
> new URL('http://localhost:3333/user/5e9868c3fb322670da33ef0e?score%3D0').search
"?score%3D0"


Add files via upload

Add domain tukorea

@Cluster-Taek I am sorry, the domain tukorea.tukorea.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


[SPARK-14124] [SQL] [FOLLOWUP] Implement Database-related DDL Commands

What changes were proposed in this pull request?
First, this PR will issue an exception when location is not specified and HiveConf.ConfVars.METASTOREWAREHOUSE is blank.
Second, it replaces the scheme of a path with the scheme of the FileSystem that it maps to.
Third, the property value of java.io.tmpdir. On some plateform, the temporary directory  do not include a trailing slash. For example, what I got in the web:
Win NT  --> C:\TEMP\
Win XP  --> C:\TEMP
Solaris --> /var/tmp/
Linux   --> /var/tmp

Forth, a couple of test cases are added to verify if the commands work properly.
cc @yhuai @andrewor14 Sorry, I did not catch this issue when submitting the PR. Could you review this follow-up?
How was this patch tested?
Added a test case for it and correct the previous test cases.

Test build #54605 has started for PR 12081 at commit 7cd839e.

To verify if org.apache.hadoop.fs.Path works properly. I did the following verification:
    val m = new Path(new Path("/t/"), "a.db").toString
    val n = new Path(new Path("/t"), "a.db").toString
    val p = new Path(new Path("t"), "a.db").toString

In the above three cases, all of them can correctly put one and only one slash between two strings.

Test build #54605 has finished for PR 12081 at commit 7cd839e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54605/
Test FAILed.

The failed test cases clearly show the property value of java.io.tmpdir in the testing system does not contain the trailing slash. However, in my local macbook OS X, it has the trailing slash.
In the test cases, I do not want to use org.apache.hadoop.fs.Path. This is to ensure we are not hiding any issue. Thanks!

Test build #54608 has started for PR 12081 at commit a9ddedc.

Test build #54608 has finished for PR 12081 at commit a9ddedc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54608/
Test PASSed.

Merged build finished. Test PASSed.

Test build #54688 has started for PR 12081 at commit 16ac0b1.

Test build #54688 has finished for PR 12081 at commit 16ac0b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54688/
Test PASSed.

Please advise @andrewor14 @yhaui

Thank you @DeepSparkBot :100:

cc @andrewor14 @yhuai

retest this please

Test build #54996 has started for PR 12081 at commit 16ac0b1.

Test build #54996 has finished for PR 12081 at commit 16ac0b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54996/
Test PASSed.

This looks OK. @yhuai

Test build #55077 has started for PR 12081 at commit 3c03dbf.

Test build #55078 has started for PR 12081 at commit 8b6f86b.

Test build #55078 has finished for PR 12081 at commit 8b6f86b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55078/
Test PASSed.

Merged build finished. Test PASSed.

Test build #55077 has finished for PR 12081 at commit 3c03dbf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55077/
Test FAILed.

retest this please.

Test build #55092 has started for PR 12081 at commit 8b6f86b.

Test build #55092 has finished for PR 12081 at commit 8b6f86b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55092/
Test PASSed.

ping @yhuai do we need to create a directory for the database?

@gatorsmile Will metastore create the path for a new database?

Looks like metastore will do that (https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L847-L853).

@gatorsmile In our test, do we check if the database path exists after we create a new database?

Thank you for pointing out the source codes. In the test, we did not check if the path exists after creating a database. Let me add it. Thanks!

Test build #55321 has started for PR 12081 at commit b120b77.

Test build #55321 has finished for PR 12081 at commit b120b77.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55321/
Test FAILed.

Merged build finished. Test FAILed.

Test build #55331 has started for PR 12081 at commit b2cb03d.

Test build #55331 has finished for PR 12081 at commit b2cb03d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55331/
Test FAILed.

retest this please

Test build #55343 has started for PR 12081 at commit b2cb03d.

Test build #55343 has finished for PR 12081 at commit b2cb03d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55343/
Test FAILed.

Seems there are two legitimate failures?

These two failures are very interesting. After the last all-pass successful tests, I only changed the test cases. I expected it should not hit any failure. : (
A little bit strange. I need to investigate the root causes.  Thanks!

Test build #55456 has started for PR 12081 at commit 2ba5a73.

Unable to reproduce the errors in my local environments. The latest changes are just try to print out more info in the log for investigation.

Test build #55456 has finished for PR 12081 at commit 2ba5a73.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55456/
Test FAILed.

Merged build finished. Test FAILed.

Test build #55482 has started for PR 12081 at commit 4890c65.

Test build #55482 has finished for PR 12081 at commit 4890c65.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55482/
Test FAILed.

Test build #55483 has started for PR 12081 at commit 1618f50.

Test build #55483 has finished for PR 12081 at commit 1618f50.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55483/
Test FAILed.

Test build #55490 has started for PR 12081 at commit 924f132.

Test build #55490 has finished for PR 12081 at commit 924f132.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55490/
Test FAILed.

The query is cached???
select current_database()

It only evaluates current_database() once after we create a new session. Let me clear the cache and see if it works now.

Test build #55492 has started for PR 12081 at commit 04e1d83.

Test build #55492 has finished for PR 12081 at commit 04e1d83.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55492/
Test FAILed.

== Parsed Logical Plan ==
'Project [unresolvedalias('current_database(), None)]
+- OneRowRelation$

== Analyzed Logical Plan ==
current_database(): string
Project [HiveGenericUDF#org.apache.hadoop.hive.ql.udf.generic.UDFCurrentDB() AS current_database()#72958]
+- OneRowRelation$

== Optimized Logical Plan ==
Project [default AS current_database()#72958]
+- OneRowRelation$

== Physical Plan ==
WholeStageCodegen
:  +- Project [default AS current_database()#72958]
:     +- INPUT
+- Scan OneRowRelation[]

The root cause is found.

This is great! Why are we using Hive's udf?

Accidentally, deleted the previous post.
== Parsed Logical Plan ==
'Project [unresolvedalias('current_database(), None)]
+- OneRowRelation$

== Analyzed Logical Plan ==
current_database(): string
Project [HiveGenericUDF#org.apache.hadoop.hive.ql.udf.generic.UDFCurrentDB() AS current_database()#72979]
+- OneRowRelation$

== Optimized Logical Plan ==
Project [default AS current_database()#72979]
+- OneRowRelation$

== Physical Plan ==
WholeStageCodegen
:  +- Project [default AS current_database()#72979]
:     +- INPUT
+- Scan OneRowRelation[]

No clue... In my local environment, it is not using Hive's UDF.
== Parsed Logical Plan ==
'Project [unresolvedalias('current_database(), None)]
+- OneRowRelation$

== Analyzed Logical Plan ==
currentdatabase(): string
Project [currentdatabase(org.apache.spark.sql.hive.test.TestHive$@62de70e2) AS currentdatabase()#5]
+- OneRowRelation$

== Optimized Logical Plan ==
Project [default AS currentdatabase()#5]
+- OneRowRelation$

== Physical Plan ==
WholeStageCodegen
:  +- Project [default AS currentdatabase()#5]
:     +- INPUT
+- Scan OneRowRelation[]

Will continue the investigation.

I guess something is wrong in the function resolution in Analyzer.

Let me remove import org.apache.hadoop.fs.Path and make another try.

It does not sound right. It should be related to HiveSessionCatalog.

It should be caused by lookupFunction in HiveSessionCatalog. Based on Hive's UDF, it has the function with the same name current_database.

Is there any chance that the original current_database is not in the function registry when we call current_database?

Unable to find it. : (
Still unable to reproduce it in my local environment. Will upload a code change to print out a message when we adding Hive UDF current_database.

current_database is special because it is registered in HiveContext. So, it is not tracked FunctionRegistry.builtIn. I think HiveDDLSuite drops this function by calling sessionCatalogs.reset.

You can reproduce it by calling test-only *HiveDDLSuite *HiveQuerySuite. Yea, it is indeed the problem of reset.

For now, we can avoid of dropping current_database in SessionCatalog.reset.

Thank you for your investigation! Sorry, just came back. Will follow your idea to fix the issue.

I can reproduce it now. : )

Test build #55510 has started for PR 12081 at commit 9cf48e1.

Test build #55510 has finished for PR 12081 at commit 9cf48e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55510/
Test PASSed.

Merged build finished. Test PASSed.

This PR is to correct the generated database path when users issue the command Create Database. For example, when users specify the Location in the command, the generated path should be path/databaseName.db instead of path.

I took at the description again and I am not sure the above statement is correct.
I tried Hive 1.2.1, here is what I did
hive> create database db3 location '/tmp/test_db';
OK
Time taken: 0.028 seconds
hive> use db3;
OK
Time taken: 0.012 seconds
hive> create table table3 as select 1 as a;

When I look at the dir structure, I see /tmp/test_db/table3.

Yeah, you are right.
hive> describe database extended default;
OK
default	Default Hive database	hdfs://e391721442fb:9000/user/hive/warehouse	public	ROLE
Time taken: 0.013 seconds, Fetched: 1 row(s)
hive> create database db3 location '/tmp/test_db';
OK
Time taken: 0.051 seconds
hive> describe database extended db3;
OK
db3		hdfs://e391721442fb:9000/tmp/test_db	root	USER
Time taken: 0.02 seconds, Fetched: 1 row(s)

If users did not specify the location, it will have such a directory databaseName.db. For example,
hive> show conf "hive.metastore.warehouse.dir";
OK
/user/hive/warehouse	STRING	location of default database for the warehouse

hive> create database db2;
OK
Time taken: 0.191 seconds

hive> describe database extended db2;
OK
db2		hdfs://e391721442fb:9000/user/hive/warehouse/db2.db	root	USER

hive> describe database extended default;
OK
default	Default Hive database	hdfs://e391721442fb:9000/user/hive/warehouse	public	ROLE
Time taken: 0.013 seconds, Fetched: 1 row(s)

Can you update the description?Let's keep the summary of the problem up-to-date.

Sure, will do it. Thanks!

Test build #55554 has started for PR 12081 at commit 38130a8.

Test build #55554 has finished for PR 12081 at commit 38130a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55554/
Test PASSed.

Test build #55573 has started for PR 12081 at commit eeec2c1.

Test build #55573 has finished for PR 12081 at commit eeec2c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55573/
Test PASSed.

Test build #55588 has started for PR 12081 at commit 592ba1c.

Test build #55588 has finished for PR 12081 at commit 592ba1c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55588/
Test PASSed.

Test build #55620 has started for PR 12081 at commit 3353a39.

Test build #55620 has finished for PR 12081 at commit 3353a39.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55620/
Test PASSed.

Merged build finished. Test PASSed.

Test build #55779 has started for PR 12081 at commit 4989110.

Test build #55779 has finished for PR 12081 at commit 4989110.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55779/
Test PASSed.

retest this please

Test build #56032 has started for PR 12081 at commit 4989110.

Test build #56032 has finished for PR 12081 at commit 4989110.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56032/
Test FAILed.

retest this please

Test build #56324 has started for PR 12081 at commit 8a3e230.

Test build #56325 has started for PR 12081 at commit 8f185be.

Test build #56324 has finished for PR 12081 at commit 8a3e230.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56324/
Test FAILed.

Merged build finished. Test FAILed.

Test build #56325 has finished for PR 12081 at commit 8f185be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56325/
Test PASSed.

Merged build finished. Test PASSed.

Test build #56564 has started for PR 12081 at commit fa5f124.

Test build #56564 has finished for PR 12081 at commit fa5f124.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56564/
Test PASSed.

@gatorsmile Just left a few comments. For the third item in description (Third, the property value of java.io.tmpdi...), seems the explanation is not finished?

@yhuai Done. : )

Test build #56631 has started for PR 12081 at commit 44fdf83.

Test build #56631 has finished for PR 12081 at commit 44fdf83.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56631/
Test FAILed.

retest this please

Test build #56643 has started for PR 12081 at commit 44fdf83.

Test build #56643 has finished for PR 12081 at commit 44fdf83.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56643/
Test PASSed.

Merged build finished. Test PASSed.

retest this please

Test build #56872 has started for PR 12081 at commit 44fdf83.

Test build #56872 has finished for PR 12081 at commit 44fdf83.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56872/
Test PASSed.

Merged build finished. Test PASSed.

@gatorsmile the new DDLs shouldn't go to the Hive package. We should put all the DDLs in the sql/core package.

Also we should NOT depend on Hive config values.

Test build #56980 has started for PR 12081 at commit a2d71fd.

@rxin Thanks for the review!
So far, DDLSuite only contains the test cases for InMemoryCatalog. To verify the behaviors of HiveExternalCatalog, we add the test cases in HiveDDLSuite.
Feel free to let me know if the latest changes resolve all your questions. Thanks!

Test build #56980 has finished for PR 12081 at commit a2d71fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56980/
Test FAILed.

Merged build finished. Test FAILed.

Test build #57004 has started for PR 12081 at commit 375b692.

Test build #57004 has finished for PR 12081 at commit 375b692.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57004/
Test FAILed.

Many test cases called SQLConf.clear() and cleaned all the configurations. When we reloading the conf, we did not load the Hive-related configurations.

Test build #57059 has started for PR 12081 at commit 1da261a.

Test build #57059 has finished for PR 12081 at commit 1da261a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57059/
Test PASSed.

Test build #57480 has started for PR 12081 at commit 95d9a00.

Test build #57480 has finished for PR 12081 at commit 95d9a00.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57480/
Test PASSed.

cc @liancheng @yhuai It is ready for review. Thanks!

@cloud-fan Your PR https://github.com/apache/spark/pull/12871 is related to this. Could you please review this? Thanks!

@gatorsmile I took a quick look and I think the logic can be simpler. There are a lot of random checks that don't seem necessary to me. Actually I thought the original goal was to create the dir, but this patch doesn't seem to do that. I'm not sure what the non-test changes here achieve.

@andrewor14 You know, this PR has many changes since its initial version. Originally, the focus of this PR is to create a correct warehouse directory. Later, a few related PRs were merged. Thus, I removed the contents. : )
Yeah, sure. I can clean it and try to create the dir.

Test build #57717 has started for PR 12081 at commit 59a9805.

Test build #57722 has started for PR 12081 at commit b885f7b.

@andrewor14 I also think about creating directory in implementation of create database.
Metastore APIs created the directory for us no matter whether the provided location/directory exists or not. The following test cases verified it.
https://github.com/gatorsmile/spark/blob/mkdir/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala#L401-L411
Should we still create the database directory?
If yes, could we do it in a separate PR? This PR has a long change history. It has been rebased 8 times.
It is hard for the future readers to follow what we did in this PR.

Test build #57717 has finished for PR 12081 at commit 59a9805.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57717/
Test PASSed.

Test build #57722 has finished for PR 12081 at commit b885f7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57722/
Test PASSed.

: ) This one needs to be rebased again. 9 times

Test build #57772 has started for PR 12081 at commit 838eaeb.

Test build #57772 has finished for PR 12081 at commit 838eaeb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57772/
Test PASSed.

@gatorsmile Thank you for updating this. Can you address my comments? Then, let's get it in!

Test build #57830 has started for PR 12081 at commit 55cf518.

Test build #57831 has started for PR 12081 at commit b190b86.

Test build #57830 has finished for PR 12081 at commit 55cf518.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57830/
Test PASSed.

Test build #57831 has finished for PR 12081 at commit b190b86.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57831/
Test PASSed.

Alright, this is mainly just test changes now. LGTM merging into master 2.0.


[Question] Can i set Access-Control-Allow-Origin header for static files?

This would be useful for local dev environment (AWS S3 in production). Now i have to create additional container with nginx for this.

I'll merge your request with #336


Update the instructions to create the Containers App

Describe the Issue
The procedure to create/deploy the sample containers app has changed: the terraform token is not necessary anymore but a new token with the trust relationship between terraform and AWS need to be created
Part of te information appears in the ReadMe file, but may be confusing for most users to follow.
Acceptance Criteria

Ask Prabhu for input and resolve doubts
Redo the How To created a sample containers app document
Test the procedure so anybody following the steps can create a sample containers app
Save the document in the Teams folder

New document HowTo_deploy_Containers_Sample_App.pdf created and saved in the CPF Scrum Team> Quality Assurance > How-To section in Sharepoint


Fix index out of bounds error

Thanks for cool tool :)
When number of Gists is 1, index out of range error occurred in NewScreen method.
I created a new case for fix the bug.

Thank you!


Can reports show the field names in the result?

One of the first apps I write is a simple report viewer: a Windows Forms application allowing the user to set up a report, has a button Go and a GridView showing the results. Once succeeded it proves very helpful by allowing you to test combinations of fields, to see which values can occur in the response etc.etc.
Unfortunately the result of googleAdsService.Search() contains all possible fields, which are hundreds. Can a list of fields be published too?
Note: you would think parsing the query text should reveal the names. Unfortunately the query text uses different names than the resulting report, also see issue #12

Hi Zwitze,
I don't quite understand the issue. Just like in AdWords API, Google Ads API will only return fields that you requested.
E.g. See GetCampaigns.cs example. you get back only the fields you requested.
Is your ask for the server to return the list of field that were requested, as part of GoogleAdsRow? I assume, you are asking for the field_mask property in SearchGoogleAdsResponse?  If yes, I'll follow up with an example on how to retrieve it.

Hi Zwitze,
You could write the code like this:
// Issue the search request.
PagedEnumerable<SearchGoogleAdsResponse, GoogleAdsRow> searchPagedResponse =
    googleAdsService.Search(request);

foreach (SearchGoogleAdsResponse response in searchPagedResponse.AsRawResponses())
{
    Console.WriteLine(response.FieldMask);
    foreach (GoogleAdsRow googleAdsRow in response.Results)
    {
        Console.WriteLine("Campaign with ID {0} and name '{1}' was found.",
            googleAdsRow.Campaign.Id, googleAdsRow.Campaign.Name);

    }
}

Yes, method AsRawResponses() of the result is what I was looking for. And I do like that this result uses the same names as requested, meaning easier matching. Is SearchGoogleAdsResponse documented somewhere?
(I know, the package states HTML and XML docs are available, but I can't find it. Please help me out)

HI Zweitze,
Apologies for the delay, I didn't realize you were waiting on me for additional details. The online docs are here: https://developers.google.com/google-ads/api/reference/rpc/google.ads.googleads.v0.services#google.ads.googleads.v0.services.SearchGoogleAdsResponse


It would be nice to have a progress keyword for time estimation

It would be great to have a progress bar similar to DifferentialEquations https://docs.sciml.ai/DiffEqDocs/stable/features/progress_bar
Also, if this can be easily transferred from DifferentialEquations i can try to make PR for this.

It's a bit more difficult in this case because it's not clear how to measure the progress, since it's a convergence criteria not stepping across time and thus there's no clear percentage of the computation already done.

We can show percentage of convergence reached for both abstol and reltol separately, in such way user have some idea of what is happening and can estimate time for integration to complete.

That is a cool idea! Unfortunately, the libraries that Integrals.jl wraps do not support callbacks that would allow for this kind query of the estimated error. If your integrals take very long to converge, is there a better algorithm that could integrate them with fewer function evaluations?

I am using CubatureJLh() i tried also VEGAS but performance was not that great since I dont have big dimensions, only two, and need to integrate vectors, if you have any recomendation i am happy to try them out :)
Closing issue as can not be implemented.

@Yaraslaut In 2D I would recommend a quadrature or cubature for faster convergence. Other than that, the optimal algorithm will depend on your integrand. If it is very smooth, CubatureJLp() would be favorable, since it reuses function evaluations. However if you tried CubatureJLh() this would be because your integrand is localized somewhere. If it is localized around points, I would recommend CubatureJLh(). However, if it is localized around curves, then doing nested 1d integration will have better computational complexity because of the number of cubes versus intervals it takes to adaptively tile a nearly singular surface in many versus one dimension. The quadgk! routine may be your friend in the case of curves.

Thanks for pointing out to some usefull places, I will definitely try to use quadgk!
One of the drawbacks i see in it is the lack of parallel computing especially in the nested case


CASMTRIAGE-6983 - Fix docs for configuring an IMS remote build node.

Description
Clean up and fix the documentation for setting up a remote build node for IMS jobs. There was one command that didn't include the '--format json' required to make it work correctly, the rest is simplifying the process a little.
https://jira-pro.it.hpe.com:8443/browse/CASMTRIAGE-6983

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see [example][1]).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in [Cray-HPE][2].
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.5


Commit History: Unrecognized User

Wow, really nice work so far! Hope I'll have some free time soon to help you!
While I was reading thought the commits I saw a minor issue.
 Did you add your @outlook email address to your GitHub account?
Keep up your good work!
Regards

Thanks! And good catch! Just fixed, you were right, my outlook email was different than profile email. Changed, should be all set now.
-- Steve


Add impressionist to impress.js authoring tools

How about adding your project to the list of authoring tools in the impress.js wiki page ? :)

Yeah, given that Impressionist finally can save what you created, maybe now is a good time. Thanks for the nudge.


Update BR version to 1.5.3

Issue #, if available:
Description of changes:
Update BR version to 1.5.3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Implement Atoi()

Currently, array of which length is more than 9 cannot be compiled.

Done 1282b11b9fdf1d68619dd2ce48ff951ab0b9f5d9


Please add screenshots or snacks for each simple component

As a front-end react native developer, I spend a lot of time window-shopping for components to use from various libraries. All good libraries always have screenshots from both platforms (where applicable) for a component in its documentation. This would probably take an intern like one afternoon and would make the website pop much more.

You should see this in the /docs/next/ version of the docs right now and shortly Snacks will be included in all APIs and Components in the 0.62 version of the docs. We just completed #1579 to address this. Thanks so much for sharing how important these changes are!

(But it did take significantly more than one intern an afternoon to complete this challenge—we had 29 volunteers working over two months! Awesome folks, and I want to give their efforts a shout out!)


Add PodDisruptionBudgets

I'd love to see PodDisruptionBudgets for the gateway and brokers in this chart. These are especially important when performing cluster administration like draining nodes for maintenance.
As an example, the elasticsearch chart this one depends on includes a PDB for its Statefulset.

@pinkertonpg any chance that you send a PR for that?

I'll try to find some time to put up a PR this week :+1:


Use root context (/) for the WARs

Using root context is more user-friendly as users don't need to know the
specific context the app was deployed to.
@errantepiphany WDYT? Is this a good idea? Are there any disadvantages to this approach?

I actually think this is a great idea. However, we'll have to tweak the openshift derivative images also to remove its use of the context in the url path.

@errantepiphany good point, thanks. I will take a look at the openshift images as well.

This PR has been covered by work in https://issues.jboss.org/browse/CLOUD-1844 and thus can be closed.


Remove Google Dependecies in primary main

Inadequate bucket name
Change it to covid-helpline

remove saving and move subscribe functionality to dev environment.
Move sms analytics to twillio infrastructure. add links


fix: factory token decimals

Changes
This PR attempts to resolve the scenario mentioned in https://www.notion.so/injective/91856a6f88874b03b9098f6980e0414f?v=6d230a442a594f05af3667d8f32a5759&p=a51e702fce70471ba566ba90854f2aba&pm=s.

This is fine, but like I said there is no need for usage of this function in production as we can just directly use cw20.decimals.


ARM support

What would be necessary to provide a ARM version of this package as well?

I modified the CI workflow to upload artifacts built for the aarch64 target architecture. They can be found in version 0.2.1:
https://pypi.org/project/pyrlu/0.2.1/#files
Unfortunately, I don't have an ARM system to test them out. Let me know if you have any problems.


Update Dockerfile

I update the Dockerfile for the slimming image.
132 MB -> 109 MB

Thanks for opening this PR!
I like the multi-stage build change.
I'll run it manually and merge a little later today.

Actually, now that install happens in the builder, it would be best if the pip install in builder were a separate run step.
That way it will be a new layer, and the apk add can also cache if code changes

Remove tini package in build-stage. It makes more simple. :)


Tags to be used for security plugin releases

Versions of the security plugin were reset to 1.x after move to OpenSearch. It is necessary to agree on the tag naming convention as v.1.x.x.x scheme conflicts with the existing tags for ODFE releases. We can either switch to release-1.x.x.x scheme or use v1.x.x.x-OS scheme. Any other options?

Adding @peterzhuamazon @dblock to continue the discussion that started in GA release readiness.

I suggest opening a proposal into https://github.com/opensearch-project/.github/blob/main/RELEASING.md and discussing it there? There's some discussion on tags in https://github.com/opensearch-project/.github/issues/13, too.

The existing scheme for OpenSearch 1.0 will not work for the security plugin and I strongly recommend not to use it for other repos as well. The majority of open source projects use either v.x.x.x scheme or release-x.x.x scheme or project-x.x.x scheme.

The real issue is that the current scheme (n.n.n.n) makes it difficult if not impossible for GitHub CD pipeline in the security plugin to distinguish release tag from a tag. That pipeline today triggers builds on tags starting with v.

The issue is that the current scheme (n.n.n.n) makes it difficult if not impossible for GitHub CD pipeline in the security plugin to distinguish a release tag from any other tag.

To clarify, currently, security plugin's CD is triggered by tags starting with v . Tags not starting with v don't trigger CD with the configuration that security plugin currently has because they are not considered as release tags. If we decide to remove v from release tags, the format of tags to trigger CD will need to be changed like this (line 6 in cd.yml file), which means all tags will trigger CD workflow.
While almost all the tags that we currently have start with v , which means almost all the tags are considered as release tags, the concern mentioned above on this is that there might be tags that are not release tags at some point in the future, it'd be not easy to distinguish release tags from non-release tags without adding v as prefix in release tags.


unhold the binaries on the worker nodes during upgrade

Steps missing to unhold the binaries on the worker nodes during upgrade
Refs https://github.com/kubernetes/website/issues/14593

/release-note-none

/sig cluster-lifecycle

@neolit123 Thanks! let me know if i can help with upgrade documents in  dev-1.15

let me know if i can help with upgrade documents in dev-1.15

no problem, i'm working on those.


Teams login error

Application version: 3.0
OS: MacOS 14.4.1

I get an error when trying to login to Teams.
It uses the same credentials as my Outlook account and that works.
I tried to login with different methods but nothing works.

Same issue here (reported a couple of days ago as well on both Mac and Linux versions)
Wonder if issue is related to this:
https://learn.microsoft.com/en-us/microsoftteams/new-teams-web

I also have an issue where it is not finding my account when I try to login to Teams. I assume this is because I have an Office 365 for business account rather than personal?

Same for me. Created a custom app with this url https://teams.microsoft.com/v2/?clientexperience=t2 as workaround for now. For me it works.

Same for me. Created a custom app with this url https://teams.microsoft.com/v2/?clientexperience=t2 as workaround for now. For me it works.

Thanks for the workaround. I confirm that Outlook365 accounts are not recognized anymore in the official app.
Thanks in advance to the fixing team.


Split local ext host

The local ext host pulls all the code from the worker extHost into the main bundle
This PR make it optional
It's automatically registered when using import ... from 'vscode'
:warning: It relies on top-level await to not have to wait for a promise before using that api

@CGNonofr will look at this today

I have one question: Do you intentionally use monaco-editor in the demo, so you are able to test the treemending script or do you want to switch at one point to @codingame/monaco-editor-treemended?

It just wasn't changed when @codingame/monaco-editor-treemended was introduced. I'm still not sure what should be the recommended way :-\

@kaisalmen I've rebased (and added 8d78f220aabb18f5df126a4b1e6f6a540577f931) can you please approve once again?

It just wasn't changed when @codingame/monaco-editor-treemended was introduced. I'm still not sure what should be the recommended way :-\

@CGNonofr the extra package all in all is simpler, but when upgrading from one version to the next cleaning seems to be a must (node_modules and eventually package-lock.json)

It just wasn't changed when @codingame/monaco-editor-treemended was introduced. I'm still not sure what should be the recommended way :-\

@CGNonofr the extra package all in all is simpler, but when upgrading from one version to the next cleaning seems to be a must (node_modules and eventually package-lock.json)

I add the feeling it was the cons of the treemending script: it's not reapplied if monaco-editor version didn't change so you need to delete the node_modules.
Why whould we need to clean node_modules and package-lock.json using monaco-editor-treemended?

Why whould we need to clean node_modules and package-lock.json using monaco-editor-treemended?

That is some awkwardness of npm. E.g. when I upgraded from 1.83.12 to 1.83.15-next.0 this morning in monaco-languageclient monaco-editor was not consistently resolved. Only after cleaning and re-installing everything was fine again. Don't know if that is better with npm 10 / node 20


How you run the wp cli database related commands?

I wonder which container you are using for wp cli database related?
I tried the php but php dont have mysql...
Thank you!

@lusareal which CLI command you're trying to run?
Yeah I use the php container myself to run WP-CLI. From my experience, I only had issue with wp core config command, which I use --skip-check flag to skip the database check before creating the wp-config.php.
In any other scenarios, if you have a working WordPress site, wp-cli should be able to run normally inside the php container.

@lusareal which CLI command you're trying to run?
Yeah I use the php container myself to run WP-CLI. From my experience, I only had issue with wp core config command, which I use --skip-check flag to skip the database check before creating the wp-config.php.
In any other scenarios, if you have a working WordPress site, wp-cli should be able to run normally inside the php container.

Thank you!
But i cant understand how it possible?
php container dont have a mysql, and the mysql container dont have a php and wp-cli =)
I think you just never use commands such as wp db export/import =)
Can you explaine please?


Add initial draft for blosc codec

I have many questions:

should we provide a compression algorithm name, as in numcodecs?
there doesn't seem to be a reference document for Blosc. Is the reference the C implementation GitHub URL?
it looks like Blosc and Blosc2 are incompatible. Should we provide the version number in the meta data?
is the file format the raw storage of the memory compressed data?

Hi @davidbrochart, many thanks for doing this. On reflection I thought it might make our lives easier in future if we refactored all the codec specs into a single document, and so I have taken the content from this PR and refactored it into the proposed PR #102. Your thoughts on this would be very welcome.

Hi @alimanfoo, I agree, let's close this PR then.


[Crop and Lock]: Borderless thumbnail/reparent windows?

Description of the new feature / enhancement
I think there should be an option to have borderless reparent windows for aesthetic reasons.
Scenario when this would be used?
Whenever the cropped window's size is comparable to the titlebar height (eg. very small crops like an Address bar or Spotify music controls).
Also I don't know how minimizing/closing can be handled; maybe a shortcut or a floating button?
Supporting information
No response

/needsinfo
Would this borderless window mode exist for all windows on the desktop? I am confused with the mention of thumbnail too, is there any UX you can share that could help show the experience?
If not, it could help to have the UX flow written out in steps, such as:

I open Powertoys
I turn on "Borderless windows"
The nonclient areas of my application are then transparent (?)
When I go to close the window, a button appears to assist with closing

Thanks!

Ok this should make thing a little more clear (hopefully)
When creating a reparing window of let's say Spotify, it looks currently like this:

I think there should be an option in the settings paage or maybe a shortcut/button to enable borderless windows that should look like this:
(Forgive my poor Photoshop skills)

The close and move controls should appear as floating buttons when the mouse hovers over them.
I don't know how to elaborate further, I think it should be a good feature to have in PT

I agree, I would like to see something similar as well.

Is there any development on this issue/feature/improvement?

/dup https://github.com/microsoft/PowerToys/issues/29381


Cannot input with Chrome Extension Google Input Tool

monaco-editor version: 0.18.1
Browser: Chrome / Edge β
OS: Windows
Steps or JS usage snippet reproducing the issue:

Cannot input with Chrome Extension Google Input Tool.
Alphabet can be entered.
Japanese and Chinese etc are impossible
Install the extension and enter in Japanese or Chinese

@mouse484 Can you reproduce when using the editor at http://vscode-web-test-playground.azurewebsites.net/ ?

Yes, see picture please


Safely delete parameters and variables that have never been used

Make sure set the target branch to develop
What is the purpose of the change

Streamline code and increase readability

Brief changelog

Safely delete parameters and variables that have never been used
Related change files：DefaultRequestProcessor && KVConfigManager

Verifying this change

Verified

Coverage increased (+0.1%) to 54.212% when pulling e52fc184773b63d343cfbbfc1342eb5dd1d75d72 on pirateskipper:r-issues into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.

Codecov Report

Merging #3248 (e52fc18) into develop (5203d52) will increase coverage by 1.79%.
The diff coverage is 31.25%.

@@              Coverage Diff              @@
##             develop    #3248      +/-   ##
=============================================
+ Coverage      47.93%   49.72%   +1.79%
- Complexity      4564     5012     +448
=============================================
  Files            552      552
  Lines          36628    40169    +3541
  Branches        4844     5813     +969
=============================================
+ Hits           17558    19975    +2417
- Misses         16850    17815     +965
- Partials        2220     2379     +159

Impacted Files
Coverage Δ

...tmq/namesrv/processor/DefaultRequestProcessor.java
35.93% <26.66%> (ø)

...che/rocketmq/namesrv/kvconfig/KVConfigManager.java
59.18% <100.00%> (ø)

.../rocketmq/broker/pagecache/OneMessageTransfer.java
22.58% <0.00%> (-10.76%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...ketmq/client/impl/consumer/PullMessageService.java
75.55% <0.00%> (-4.45%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
52.15% <0.00%> (-3.83%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...rocketmq/broker/pagecache/ManyMessageTransfer.java
43.58% <0.00%> (-2.57%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
59.13% <0.00%> (-2.16%)
:arrow_down:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5203d52...e52fc18. Read the comment docs.


Add NextDNS extension

Description
Added extension for NextDNS with basic allowlist/denylist management for now.
Screencast
https://github.com/raycast/extensions/assets/13333578/f97670dc-8918-4153-98c7-2a62c52ef85c
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@itsmingjie are you still working on this?

I'll convert this to a draft for now, I still think it would be a very nice extension @itsmingjie

@itsmingjie I actually think it also could be fine to keep the two list commands, and inside them we could have the add domain, what do you think about that?

Hi @itsmingjie
Do you want to continue on this extension, or should I do it? I think we can keep the current commands, it actually makes sense 🙂

@pernielsentikaer I've been following this PR for a month or so as I have a "NextDNS" account. I think if it looks good to you you can get this merged and I'd be willing to act as a contributor/maintainer/owner whichever is required until the author can get back.

I was about to do the same @xmok and was waiting for it to get closed, but let's continue.
I added you as a contributor. I think the original author has been pinged enough 🙂

Anything you think we should look into before the initial release?

Anything you think we should look into before the initial release?

So far the few features are working perfectly fine. The only thing I'm missing right now is when running some actions e.g. removing a domain from Allowlist or adding a domain to Denylist, there's no loading indicator nor animated toast shown so there's a second or two before I get a success toast that action has completed.
But this isn't a blocker - probably the first feature I'd want to implement in the next version otherwise LGTM 🚀.

Regarding commands; we might want to change that before the release. I can look into merging them later this evening 🙂

So we're aiming for two commands, right?

I added you to my fork @xmok - feel free to catch me in Slack if you're there - didn't get that far yesterday as I wanted but let's do it 🙂

Closed in favor of #14259


Check if ping.py normally decodes output on the Russian versions of Windows

(Probably no)

Added a workaround, needs testing:
https://github.com/insolor/async-tkinter-loop/blob/2a74418e2c8cc21f57871cca373654c69a6463ee/examples/ping.py#L26-L33

It works


Fix TexLexer (#2637)

Closes #2637.

Test showed that this was causing the Wikitext lexer to lex <math>\log_k(x)</math> as a command \log_k. I've pushed a fix that makes it use the TeX lexer in math mode instead.
Looks good, could you add a test though? (I can try but I'm not TeX wizard.)

Test showed that this was causing the Wikitext lexer to lex <math>\log_k(x)</math> as a command \log_k. I've pushed a fix that makes it use the TeX lexer in math mode instead.
Looks good, could you add a test though? (I can try but I'm no TeX wizard.)

Thank you! Regarding adding a test: I'd love to, but I'm afraid I'm not familiar with how to write tests for the Pygments library (or pytest in general). I can describe the expected behavior, though, and give some examples, if that'd help (see also #2637, the issue this PR aims to fix):
TL;DR: A string is a LaTeX command if and only if it matches the regex (\\[A-Za-z_@:]+|\\\S?).
In LaTeX, @ (at sign), : (colon), and _ (underscore) can be used in the names of commands under some circumstances (usually outside of the document body, i.e., the content inside \begin{document}...\end{document}, since commands containing these special characters are often advanced, lower-level commands.
Strictly speaking, to make @ a valid part of a command name, the command definition has to be wrapped by \makeatletter...\makeatother (for : and _, the same is true but with \ExplSyntaxOn...\ExplSyntaxOff instead) — however, this should not be relevant to the syntax highlighting in my opinion, for the reasons mentioned in #2637.
Regardless, this basically just means that, for example, each of the following should be a valid command name as far as the lexer is concerned (and, as a matter of fact, these command names are taken from official documentation):
\toks@
\sixt@@n
\::N
\:::
\clist_set:Nn
\sort_return_same:
\@@_case:NnTF

Thank you! Regarding adding a test: I'd love to, but I'm afraid I'm not familiar with how to write tests for the Pygments library (or pytest in general).

See https://pygments.org/docs/lexerdevelopment/#how-to-test-your-lexer
In short, add a file with test TeX code, either tests/snippets/tex/testname.txt or tests/examplefiles/tex/testname.tex, and run tox -- --update-goldens.

@jeanas Thank you for the hint, I missed that :) I added some basic tests now (I was a bit surprised that, as far as I could tell, there weren't already tests for TexLexer).
Also, I made another small change in the TexLexer (see commit d40643e). I replaced . with \S?, for the following reason: previously, the strings \ , \\t, and \\n were each parsed as a single command, instead of \ plus the whitespace. In LaTeX, the \ command, on its own, just inserts a space; it just so happens that this command can only be invoked if it is followed by whitespace, since otherwise we're bound to invoke a different command, but the whitespace itself is not part of the command, at least as far as I know.

Sorry for the delay. Thank you for the tests, looks good!


async issue during p5.js reference test

if you run the p5.js reference tests in the browser (by running npm run docs:dev in the p5.js repo), aside from a bunch of 404-related issues, you'll see a pretty bad bug resulting from asynchronous operations completing after the p5 instance has been removed.
the timeline of the specific bug i'm seeing is this:

the 'pause documentation' sketch runs
the test framework instantiates a p5 instance
the test calls loadSound()
the test framework then calls p5.remove() to remove the instance

the SoundFile object is disposed, setting this.panner = null

the XMLHttpRequest inside p5.SoundFile.prototype.load completes

it atempts to access self.panner.inputChannels. since self.panner is is now null, this results in an exception.

i think this is a wider issue with the p5 library itself - it's not resilient to having remove() called at inopportune times. but this specif SoundFile instance is causing these tests to fail.

thanks for raising this issue.
Some of this should be resolved by your PR here, right? https://github.com/processing/p5.js-sound/pull/270
Can we come up with a more specific issue description if more can be fixed in p5.sound repo?

per the last comment, this issue was fixed by #270


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4532

Questions ?
Please refer to the Backport tool documentation


Use YTT instead of envsubst

Configure a dashboard to be used in the d.rymcg.tech_homepage-template repo. Have link to d.ry in github, and other common services,  widgets, and links that might be useful for d.ry. include a background image.

the default .env-dist has this repo : https://github.com/enigmacurry/d.rymcg.tech_homepage-template
I believe you have the rights to commit there

The new goal is to integrate Homepage more tightly with d.ry by having the default/template dashboard automatically configured with installed d.ry apps.

Makefile can detect installed d.ry apps in the same Docker context and ask the user if they want to configure them for Homepage
Use ytt instead of envsubst in start.sh so we can have templating logic in the .yaml files


README: Provide a complete example of what retryStrategy could look like

Also, modernize with arrow functions.

Pull Request Test Coverage Report for Build 69

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 67:
0.0%

Covered Lines:
125

Relevant Lines:
125

💛  - Coveralls


yii\rbac\DbManager Cache

Q
A

Yii version
2.0.8

PHP version
7.0

Operating system
Windows

yii\rbac\DbManager,line 119
public function checkAccess($userId, $permissionName, $params = [])
    {
        $assignments = $this->getAssignments($userId);
        $this->loadFromCache();
        if ($this->items !== null) {
            return $this->checkAccessFromCache($userId, $permissionName, $params, $assignments);
        } else {
            return $this->checkAccessRecursive($userId, $permissionName, $params, $assignments);
        }
    }

When Yii::$app->user->can(xxx), checkAccess will be called.
$assignments = $this->getAssignments($userId) will be excuted and generate a sql statement to select form db.
How to cache it ? The authManager cache is already set. But  don't work.
main.php:
'authManager' => [
  			'class'=>'yii\rbac\DbManager',
            'cache'=>'cache'
		],
'cache'=>[
            'class' => 'yii\caching\FileCache',
        ],

Duplicate of https://github.com/yiisoft/yii2/issues/7743


Give persistent block ids to variables in the flyout

Resolves
Persists the monitoring state of variables between flyout refreshes
Proposed Changes
Give a persistent id to each variable block in the flyout
Reason for Changes
Otherwise, the variable blocks get a new id each time the category is switched to/from, and the monitor checkboxes become unchecked (since they are keyed by flyout block id).

Late to the party, but: why are you using the variable name instead of the variable ID?

We had to because there is no concept of a variable ID in the VM, so if we used ID it wouldn't be stable across sprite changes

No concept of a variable ID in the VM--so do you just have explicit lists for each variable type?  Or do lists and variables get prefixes?  How do you distinguish between a list and a variable that are both named foo?

Correction: you can't name a list and a variable the same name, but you can name a variable and a message the same name.

Going to chip in here - I plan to change the VM so that it will use a variableMap and will have the concept of types and variables id's.
So I think after that we can use ID.


Updated regions

@neilpeterson : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.


Mandd/tournament edits for MOGA

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1592
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test qsubs on 501dbf6 : invalidated by @mandd

Checklist is satisfied, and this PR can be merged.


Product Grid Filters display incorrectly (in staging)

Summary
I'm seeing an issue where the filters that sit above the product grid are getting aligned-left instead of right and the margins are not correct.

When locally it looks fine, so it might be related to the production build.

Seems to be fixed in the new staging build. @spencern or @mikemurray can you confirm it's fixed for you, too?

OK weird. It was fine for awhile, I was testing some things on staging for 10 or 15 minutes, then suddenly it went back to being on the left side.

I'm pretty sure this issue is being caused by Source Sans font never being loaded on production. I'm pretty sure its related to this issue. If you have Source Sans installed locally you won't see an issue.

resolved with PR #275

Assigned to @rosshadden since the Material UI update assigned to him may fix this

I updated Material UI in #297, but I haven't seen this issue yet even before doing so. It has been said to be intermittent or perhaps font-dependent, so I will keep an eye out for it.

While testing something else, I had found that this was consistently recreatable:

load /
click Next
refresh

On another note, it seems to have been fixed by #309.


[BUG] Encre UI: UI Render Failure at SyntaxText.tsx when creating new node

What happened?
When I use context menu Add Node to add a new node, the node content body is blank. The console shows error log at SyntaxText.tsx. The error log is shown below
What was the expected behavior?
The node content should appear correctly.
Describe your environment
MacOS 10.14.6
node version 20.15.0
Relevant log output
chunk-5JCKZDCJ.js:14016 The above error occurred in one of your React components:

    at Lazy
    at div
    at div
    at Suspense
    at http://localhost:3001/src/components/descriptors/CodeDescriptor.tsx?t=1726100897014:16:107
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at div
    at KnownNodeContentBody (http://localhost:3001/src/components/NodeContentBody.tsx?t=1726100897014:94:40)
    at http://localhost:3001/src/components/NodeContentBody.tsx?t=1726100897014:32:66
    at ErrorBoundary (http://localhost:3001/node_modules/.vite/deps/react-error-boundary.js?v=504eb605:18:5)
    at div
    at div
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at http://localhost:3001/src/components/VisualNode.tsx?t=1726100897014:411:91
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at MyVisualNode (http://localhost:3001/src/components/VisualNode.tsx?t=1726100897014:272:154)
    at ErrorBoundary (http://localhost:3001/node_modules/.vite/deps/react-error-boundary.js?v=504eb605:18:5)
    at DraggableNode (http://localhost:3001/src/components/DraggableNode.tsx?t=1726100897014:18:33)
    at div
    at div
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at DndContext2 (http://localhost:3001/node_modules/.vite/deps/@dnd-kit_core.js?v=504eb605:24260:5)
    at div
    at NodeCanvas (http://localhost:3001/src/components/NodeCanvas.tsx?t=1726100897014:122:30)
    at ErrorBoundary (http://localhost:3001/node_modules/.vite/deps/react-error-boundary.js?v=504eb605:18:5)
    at NodeGraphBuilder (http://localhost:3001/src/components/NodeGraphBuilder.tsx?t=1726100897014:23:31)
    at div
    at Pane (http://localhost:3001/src/components/Pane.tsx:11:24)
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at SplitPane (http://localhost:3001/src/components/SplitPane.tsx:68:29)
    at div
    at div
    at http://localhost:3001/node_modules/.vite/deps/chunk-IYL5AZN3.js?v=504eb605:1666:49
    at EncreStudio (http://localhost:3001/src/components/EncreStudio.tsx?t=1726100897014:47:31)
    at AppInner (http://localhost:3001/src/App.tsx?t=1726100897014:52:45)
    at ErrorBoundary (http://localhost:3001/node_modules/.vite/deps/react-error-boundary.js?v=504eb605:18:5)
    at QueryClientProvider (http://localhost:3001/node_modules/.vite/deps/@tanstack_react-query.js?v=504eb605:2585:3)
    at RecoilRoot_INTERNAL (http://localhost:3001/node_modules/.vite/deps/recoil.js?v=504eb605:24375:3)
    at RecoilRoot (http://localhost:3001/node_modules/.vite/deps/recoil.js?v=504eb605:24493:5)
    at App

React will try to recreate this component tree from scratch using the error boundary you provided, ErrorBoundary.

Relevant screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This issue is fixed.
It occurs at utils/monacoEditor.ts, where it imports dataTypes from backend. DO NOT import any constant from backend, otherwise this issue will occurs again.


Error with readable-stream

When I use readable-stream with the rollup-plugin-commonjs it throws:
TypeError: The super constructor to "inherits" must not be null or undefined
    at Object.inherits (util.js:969:11)
    at Object.<anonymous> (/home/ttimm/dev/workspaces/rollup-readable-stream/dist/index.js:1129:8)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

at runtime.
I've created a repo and tested it with babel & typescript.
https://github.com/TobiasTimm/rollup-typescript-readable-stream

In case someone else stumbles into this issue.  This isn't really a problem with rollup-plugin-commonjs and more just an issue between rollup not supporting all circular dependencies and readable-stream not removing the circular dependency because they are valid under the ES module spec.  They both have issues tracking this:
https://github.com/rollup/rollup/issues/1507
https://github.com/nodejs/readable-stream/issues/348
There is workaround mentioned in the first issue by timdp which replaces readable-stream with stream and it works most of the time for me.

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer:


Link to Inflows and Budget Inspector Bug

Name of Defective Feature
Budget Inspector - "Link to Inflows"
System Settings (Required)

ToolKit Version: 2.16.0
Operating System (Mac/Windows/Etc): Windows 10 1903
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 78.0.3904.97
Other Extensions: uBlock Origin

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AutoDistributeSplits","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkManagePayees","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"ChangeEnterBehavior","value":false},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"CreditCardEmoji","value":true},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomFlagNames","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":true},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":false},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":true},{"key":"HideClosedAccounts","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HideTotalAvailable","value":true},{"key":"HighlightNegatives","value":true},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LinkToInflows","value":true},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"ResizeSidebar","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"0"},{"key":"SeamlessBudgetHeader","value":true},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":true},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"0"},{"key":"ToolkitReports","value":true},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":true}]

Steps to Reproduce the Behavior

Turn on "Link to Inflows"
Refresh YNAB and everything looks good.
Click on any budget category and then deselect it

Expected Behavior

I expected to be able to select the "Total Inflows" link inside the Budget Inspector
Actual Behavior

But the entire Total Inflows disappears along with the Display Total Monthly Goals

I'm not seeing this currently on OSX -- I will test again later on Windows. Are you still experiencing this issue consistently?

I'm not seeing this behavior on my Windows 10 machine.
@errantventurer can you verify the steps to reproduce? The part I question most is the last part of step 3. If you don't deselect the category then yes, all of the "totals" are covered up with information about the category, not just TOTAL INFLOWS and TOTAL MONTHLY GOALS sections. Maybe posting some screenshots would help us see the problem.

I have the same issue. After first refresh, works as intended, but whatever action I do afterwards (like go to Reports then go back to Budget, as well as selecting and deselecting any budget category, Total inflows (as well as "Total goals" which I also have turned on) links disappear.

Hmm, I still don't see the behavior @errantventurer and @MrTanguero are describing. It all seems to work OK with regards to the links being displayed. I'm stumped. Any chance one or both of you could post some screenshots (or movie) showing the behavior you're seeing?

@tharper374 I tried exactly what you did in your gif and I'm not seeing this issue. it's possible this has been fixed without us updating this issue, are you still experiencing this?

@joshmadewell The problem has been fixed. Thank you for your work.


Aggregations - Change Detection info dialog cosmetic issue

To reach dialog:

Click Aggregation icon (circle A icon)
In the aggregation result analyses section at the bottom of the window, click Change Detection tab
Click 'i' icon

Dialog title should be "About" instead of "info" to match up with other similar dialog boxes.

Fixed in #88.


Checkout clean schema says takes a boolean, but example uses "all"

schema:
steps:
- checkout: self  # self represents the repo where the initial Pipelines YAML file was found
  clean: boolean  # if true, execute `execute git clean -ffdx && git reset --hard HEAD` before fetching

example:
steps:
- checkout: self  # self represents the repo where the initial Pipelines YAML file was found
  clean: all

The Azure Pipelines extension for VS Code highlighted this for me when I tried to use clean: true

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7458d5b2-1bb7-7d87-7ce6-2b0c430b0155
Version Independent ID: edf5bbd3-a3f0-5426-e985-31290f8afd05
Content: YAML schema - Azure Pipelines
Content Source: docs/pipelines/yaml-schema.md
Product: devops
Technology: devops-cicd
GitHub Login: @vtbassmatt
Microsoft Alias: macoope

Heh. We had a bug in the parser schema, which flowed into VS Code and which I had erroneously copied into the docs. I have now fixed the docs and the parser, but the VS Code extension needs to be updated as well.

 Yes, I see I failed to update the example.

For what it's worth, "all" works in Azure DevOps, so right now I think it's the schema tab in the documentation that is wrong because it says it takes a boolean but it actually takes a string.

It takes a string because we support runtime expressions there. Then, through a serious of hilarious typecasts, it accidentally works (by treating any non-empty string as true).


Implement parser for AddAssignmentCommand

Codecov Report

Merging #83 (8cf2fc9) into master (bc04cf9) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     63.33%   62.43%   -0.90%
  Complexity      455      455
============================================
  Files            90       91       +1
  Lines          1609     1632      +23
  Branches        172      176       +4
============================================
  Hits           1019     1019
- Misses          548      571      +23
  Partials         42       42

Impacted Files
Coverage Δ

...ecord/logic/parser/AddAssignmentCommandParser.java
0.00% <0.00%> (ø)

...va/seedu/edrecord/logic/parser/EdRecordParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

...n/java/seedu/edrecord/logic/parser/ParserUtil.java
71.42% <0.00%> (-15.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc04cf9...8cf2fc9. Read the comment docs.


Replace Map with Bimap in the delegation state

The delegation map is now injective #292. We could be more explicit about this fact in our code by changing the type of the delegation map from Map VKeyGenesis VKey to Bimap VKeyGenesis VKey, where Bimap can be found here.
Another reason for wanting this is that the operation for finding which genesis key delegated to a given key becomes O (log n) instead of O (n).

Closed by https://github.com/input-output-hk/cardano-ledger-specs/pull/400


Diagnostics: When Pickler generation fails, it shows the wrong type in the Exception

I am currently trying to serialize a Roslyn compilation using FsPickler.
I have manually marked CSharpCompilation as Serializable using FsPickler.DeclareSerializable.
Serialization still fails with the Exception that it can't serialize 'CSharpCompilation'

Debugging shows the real non-serializable type, but this information was lost in the topmost exception:

Please pass the original exception through as an inner exception so it is possible to see for which type it failed without needing to attach a debugger.

Hi,
What is the precise exception that you are getting? I tried the following example:
[<AutoSerializable(false)>]
type Foo = { Foo : string }

type Bar = { Foo : Foo }

type Baz = { Bar : Bar }

FsPickler.GeneratePickler<Baz>()

which gives
Nessos.FsPickler.NonSerializableTypeException: Type 'FSI_0008+Baz' contains non-serializable field of type 'FSI_0008+Bar'.

This seems to contain sufficient debug information, since it points to the correct non-serializable field.

Hi, sorry for not providing a repro earlier.
This code
open Nessos.FsPickler

[<AutoSerializable(false)>]
type Foo = { Foo : string }

[<AutoSerializable(false)>]
type Bar = { Foo : Foo }

type Baz = { Bar : Bar }

[<EntryPoint>]
let main argv =
    FsPickler.DeclareSerializable<Bar>()
    FsPickler.GeneratePickler<Baz>() |> ignore
    printfn "%A" argv
    0 // return an integer exit code

fails with

If I add FsPickler.DeclareSerializable<Foo>(), then it works.
Actual Result: The exception says Bar is not serializable
Expected Result: An inner exception which contains a mention of Foo.

Wow that was fast.
Thank you!

  $exception	{"Type 'Program+Baz' contains non-serializable field of type 'Program+Bar'."}

  _innerException	{"Type 'Program+Bar' contains non-serializable field of type 'Program+Foo'."}

  _innerException	{"Type 'Program+Foo' is not serializable."}


BUG: MNE concatenate_raws duplicates loaded data if run in a loop

Description of the problem
The Raw object generated from the concatenate_raws method duplicates data if run on the same sequence of Raw objects more than once.
I first noticed this on my data which is using the .fif file format, but as can be seen below it occurs for edf files as well.
Steps to reproduce
import mne, mne.datasets.eegbci

if __name__ == "__main__":
    mne.set_log_level(verbose='ERROR')
    raw_fnames = mne.datasets.eegbci.load_data(1,  [*range(1, 15)])
    raws = [mne.io.read_raw_edf(f, preload=True) for f in raw_fnames]
    for i in range(5):
        sub = [x for x in raws[:5]]
        # if the line above is instead "raws[i:i+5]]" the error does not occur
        main = mne.concatenate_raws(sub, verbose='INFO')
        if len(sub) != len(main.filenames):
            raise Exception("Too many files in Raw object!")
        print('{} files loaded'.format(len(main.filenames)))
        del(main)
        del(sub)

Link to data
No response
Expected results
The concatenated Raw object should only include files specified the most recent collection of Raw objects
Actual results
The concatenated Raw object includes duplicate data.
Additional information
Platform:         Windows-10-10.0.19044-SP0
Python:           3.11.3 (tags/v3.11.3:f3909b8, Apr  4 2023, 23:49:59) [MSC v.1934 64 bit (AMD64)]
Executable:       C:\Users~\AppData\Local\Programs\Python\Python311\python.exe
CPU:              AMD64 Family 23 Model 113 Stepping 0, AuthenticAMD: 16 cores
Memory:           63.9 GB
mne:              1.3.1
numpy:            1.24.2 {OpenBLAS 0.3.21 with 16 threads}
scipy:            1.10.1
matplotlib:       3.7.1 {backend=TkAgg}
sklearn:          1.2.2
numba:            Not found
nibabel:          Not found
nilearn:          Not found
dipy:             Not found
openmeeg:         Not found
cupy:             Not found
pandas:           2.0.0
pyvista:          Not found
pyvistaqt:        Not found
ipyvtklink:       Not found
vtk:              Not found
qtpy:             Not found
ipympl:           Not found
pyqtgraph:        Not found
pooch:            v1.7.0
mne_bids:         Not found
mne_nirs:         Not found
mne_features:     Not found
mne_qt_browser:   Not found
mne_connectivity: Not found
mne_icalabel:     Not found

see the note section in
https://mne.tools/stable/generated/mne.concatenate_raws.html
can it explain what you see?

Message ID: @.***>

see the note section in https://mne.tools/stable/generated/mne.concatenate_raws.html can it explain what you see?
…
Message ID: @.***>

Ah yes, I think it does. Thanks for pointing that out.