[Event Request] codeunit 699 "Exch. Rate Adjmt. Process" - OnAdjustExchRateCustAfterCalcFields

Describe the request
Hello, can you please add a new Event OnAdjustExchRateCustAfterCalcFields in codeunit 699 "Exch. Rate Adjmt. Process"?
    procedure AdjustExchRateCust(GenJournalLine: Record "Gen. Journal Line"; var TempCustLedgerEntry: Record "Cust. Ledger Entry" temporary)
    var
        Customer: Record Customer;
        CustLedgerEntry2: Record "Cust. Ledger Entry";
        DetailedCustLedgEntry: Record "Detailed Cust. Ledg. Entry";
        PostingDate2: Date;
    begin
        PostingDate2 := GenJournalLine."Posting Date";
        if TempCustLedgerEntry.FindSet() then
            repeat
                CustLedgerEntry2.Get(TempCustLedgerEntry."Entry No.");
                CustLedgerEntry2.SetRange("Date Filter", 0D, PostingDate2);
                CustLedgerEntry2.CalcFields("Remaining Amount", "Remaining Amt. (LCY)");
                OnAdjustExchRateCustAfterCalcFields(CustLedgerEntry2);
                if ShouldAdjustEntry(
                        PostingDate2, CustLedgerEntry2."Currency Code", CustLedgerEntry2."Remaining Amount",
                        CustLedgerEntry2."Remaining Amt. (LCY)", CustLedgerEntry2."Adjusted Currency Factor")
                then begin

    [IntegrationEvent(false, false)]
    local procedure OnAdjustExchRateCustAfterCalcFields(var CustomerLedgerEntry: Record "Cust. Ledger Entry")
    begin
    end;

Additional context
We have additional values to calculate the Remaining Amount and need to recalculate it to get the correct output of ShouldAdjustEntry.
Internal work item: AB#546848

Availability update: We will publish a fix for this issue in the next update for release 25.
Build ID to track: 26180.


New version: Icons8.Lunacy version 9.3.3

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This PR omits these files that are present in the current manifest:

(Automated response - build 498.)


Day376

Resolves #758.

Pull Request Test Coverage Report for Build 1448

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1438:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


OpenSSL for OSX

Hi!
It is possible to add OSX Architectures to your build-libssl script?
When trying to build with a sperate OSX Build Target in my project results in several warnings:
ld: warning: URGENT: building for OSX, but linking in object file (/Volumes/***/openssl-ios/Core/lib/libcrypto.a(bio_lib.o)) built for iOS. Note: This will be an error in the future. ld: warning: URGENT: building for OSX, but linking in object file (/Volumes/***/openssl-ios/Core/lib/libcrypto.a(bss_mem.o)) built for iOS. Note: This will be an error in the future. ld: warning: URGENT: building for OSX, but linking in object file (/Volumes/***/openssl-ios/Core/lib/libcrypto.a(err_all.o)) built for iOS. Note: This will be an error in the future. ld: warning: URGENT: building for OSX, but linking in object file (/Volumes/***/openssl-ios/Core/lib/libcrypto.a(err_prn.o)) built for iOS. Note: This will be an error in the future. ld: warning: URGENT: building for OSX, but linking in object file (/Volumes/***/openssl-ios/Core/lib/libcrypto.a(p_lib.o)) built for iOS. Note: This will be an error in the future.
and so on...
Appreciate your work here since it is really hard to find a script like this which works convenient!
Cheers!

You could use the normal build scripts for OS X. No need for using special project like this.


Update macos script to include configs

[x] trackpad: enable app expose
[x] trackpad: use 4 fingers for app expose & mission control
[x] trackpad/accessibility: turn on ctrl/cmd+scroll screen zoom
[x] accessibility: turn on 3 finger drag
[ ] keyboard: default touchbar to function keys
[ ] keyboard: touchbar Fn key to "Show Control Strip"
[x] dock: move to right side
[ ] keyboard: clear keyboard shortcut using Shift-Cmd-A (Search man Page index in Terminal)

searchManPages

[ ] sound: Show volume in menu bar
[ ] time & clock: Show date in menu bar

for searchManPages from defaults read
    pbs =     {
        NSServicesStatus =         {
            "com.apple.Terminal - Search man Page Index in Terminal - searchManPages" =             {
                "enabled_context_menu" = 0;
                "enabled_services_menu" = 0;
                "presentation_modes" =                 {
                    ContextMenu = 0;
                    ServicesMenu = 0;
                };
            };
        };
   };


EpiOAuthUnauthorizedException error not in local but in subdomains..

EpiOAuthUnauthorizedException: . #0 /home/comiingl/.repo/htdocs/sites/default/modules/custom/comiingle_twitter/lib/EpiOAuth.php(404): EpiOAuthException::raise(Object(EpiCurlManager), false)
#1 /home/comiingl/.repo/htdocs/sites/default/modules/custom/comiingle_twitter/lib/EpiOAuth.php(53): EpiOAuthResponse->__get('oauth_token')
#2 /home/comiingl/.repo/htdocs/sites/default/modules/custom/comiingle_twitter/lib/EpiOAuth.php(60): EpiOAuth->getAuthorizeUrl(NULL)
#3 /home/comiingl/.repo/htdocs/sites/default/modules/custom/comiingle_twitter/comiingle_twitter.module(61): EpiOAuth->getAuthorizationUrl()
#4 /home/comiingl/.repo/htdocs/sites/default/modules/custom/comiingle_pages/includes/comiingle_pages.blocks.inc(245): _comiingle_twitter_wallpost()
#5 [internal function]: _comiingle_pages_twitter_ajax_login()
#6 /home/comiingl/.repo/htdocs/includes/menu.inc(503): call_user_func_array('_comiingle_page...', Array)
#7 /home/comiingl/.repo/htdocs/index.php(21): menu_execute_active_handler()
#8 {main}$_REQUEST:
Array
(
[Drupal_tableDrag_showWeight] => 0
[__utma] => 144383541.886879457.1323126003.1323275309.1323282960.3
[__utmz] => 144383541.1323126003.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none)
[__qca] => P0-1275361382-1323789814597
[Drupal_visitor_admin_compact_mode] => 1
[DrupalAdminToolbar] => expanded=0&activeTab=admin-menu
[has_js] => 1
[SESSc8219160ad9691d18afe162140797d7b] => kC5K63vo67fNGG5ZWngSM3iphDLbG5USWAUEyvMUCA8
)
REQUEST_URI:
/ajax/login-twitter
its the error my application has the read,write and direct messages permission, im sure that the keys are been sent to the twitter server...
this is my function for obtaining the url of twitter...
define('TWITTER_CONSUMER_KEY', '');
define('TWITTER_CONSUMER_SECRET', '*');
function _comiingle_twitter_wallpost() {
$twitterObj = new EpiTwitter(TWITTER_CONSUMER_KEY, TWITTER_CONSUMER_SECRET);
$validation = (object) null;
//$login = l('Tweet', $twitterObj->getAuthorizationUrl());
/*

THIS VALIDATION IS KIND OF WRONG, I DON'T UNDERSTAND
WHY IS CHECKING THE SAME VARIABLES TWICE???
*/
if (isset($_GET['oauth_token']) || (isset($_SESSION['oauth_token']) && (isset($_SESSION['oauth_token_secret'])))) {

if (isset($_SESSION['oauth_token']) || (isset($_SESSION['oauth_token_secret']))) {
  $twitterObj->setToken($GET['oauth_token']);
  $token = $twitterObj->getAccessToken();
  $_SESSION['oauth_token'] = $token->oauth_token;
  $_SESSION['oauth_token_secret'] = $token->oauth_token_secret;
} else {
  $twitterObj->setToken($_SESSION['oauth_token'], $_SESSION['oauth_token_secret']);
}
$user = $twitterObj->get_accountVerify_credentials();

} elseif (isset($_GET['denied'])) {
$validation->status = 1;
$validation->value = $twitterObj->getAuthorizationUrl();
}
if (!empty($validation->status)) {
return $validation;
}
$validation->status = 0;
$validation->value = $twitterObj->getAuthorizationUrl();
return $validation;
}
please would you help me?, as i said before, it works on my locals, but in the real server doesnt work :@

@jmathai help! :)

@archer247 can you try the proposed solution here: https://github.com/jmathai/twitter-async/issues/134#issuecomment-3198311

@archer247 are you using the latest code from Github?

im not sure..i think i am

Where did you download the code from?

@archer247 Unfortunately I'm short on time to really troubleshoot. You should give @Abraham's library a try.
https://github.com/abraham/twitteroauth

@jmathai We found the error after a loooot of time of finding the solution, the error was that the server time was 12 hours late, so twitter cannot authorize the token because of the server time!! so you can close this issue and someone that have this error should see if the server time is the correct one so twitter doesnt expire!...

Issue closed thanks!

@archer247 That's a pain to debug. It's listed under the known issues and here are some others you might run into later, http://www.jaisenmathai.com/articles/twitter-async-documentation.html#commonerrors
Glad you got it working.


Inner templates improvements

Find-JsonContent:  Fixing Underlying issue of #583 (2nd or more JSONPath in the same hierarchy would be returned corrupted)
Returning one result per inner template node (this cleans up reporting) (#580, #581)
Accepting return objects with a .JSONPath for easier line association
Adding exception handling around [Matches] (#583)
Adding additional context to Test-AzTemplate return value

Let's add tests from #580 #581 #582 since we expect to knock those out with this...


no persistend

recation.py:139: LangChainDeprecationWarning: Since Chroma 0.4.x the manual persistence method is no longer supported as docs are automatically persisted.
warn_deprecated(
what should we change in the code?

Just remove the .persist() call and it should be good

thanks


#titleupdated

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @GeekScholar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Follow guideline to create PR


Cmake build issue

To build current version I had to comment out the following in top level CMakeLists.tst
# set restrictive compilation warnings
#####################
#set_warnings(units)
#####################
https://github.com/mpusz/units/blob/master/CMakeLists.txt#L43
else complained
CMake Error at cmake/common/cmake/warnings.cmake:30 (message):
Unknown argument 'units' passed to set_warnings()

Did you update the git submodule?

Did you update the git submodule?

Yes.  I will re-read the install notes and see if I can find the issue.

Please check again and confirm that the following line is in your cmake module:
https://github.com/mpusz/cmake-scripts/blob/eb5fbd40d1cb765c5a8bf50866db86082c72ef73/cmake/warnings.cmake#L26

I copy pasted warning.cmake and everything builds but have weird warnings about cmake dir.
Anyway building OK again!

The only problem I am aware of is that linear_algebra Conan package often has stability issues and breaks our CI. Otherwise, everything seems fine at the moment. The CMake scripts in the latest version should work just fine (no manual copy-pasting needed). If it is not the case please let me know.

So  I deleted the cmake/common dir, then do git submodule init , git submodule update --recursive which makes my branch even with master but then on building, the original issue returns:
CMake Error at cmake/common/cmake/warnings.cmake:30 (message):
Unknown argument 'units' passed to set_warnings()
Call Stack (most recent call first):
CMakeLists.txt:43 (set_warnings)
-- Configuring incomplete, errors occurred!
See also "/home/andy/cpp/projects/mpusz_units/units/build/CMakeFiles/CMakeOutput.log".
make: *** No targets specified and no makefile found. Stop.

That is strange, I have no idea what can be wrong with your repository.
Our CI does not complain about CMake submodules (linear_algebra is another story 😉). Also, I just cloned a clear repo based on the instructions here: https://mpusz.github.io/units/usage.html#full-mp-units-build-unit-testing-and-documentation-generation and everything worked just fine. Could you please try again on a clean repo according to the provided instruction in our docs?

OK so I did
git pull upstream master
git reset --hard upstream/master
git submodule update
and that seems to have fixed it, so closing this


Convert all internal absolute links to relative links

Summary
I converted all internal absolute links to relative links in rst, html and markdown files.
Please let me know if you want any changes.
close: #5916

Hello @devXprite,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

Hello @devXprite,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

/check-cla

Thanks for this awesome work! Once you've signed the CLA we can move forward with the review. :)

/check-cla

Looks like this may have broke table on https://github.com/mattermost/docs/blob/master/source/upgrade/important-upgrade-notes.rst

Looks like this may have broke table on https://github.com/mattermost/docs/blob/master/source/upgrade/important-upgrade-notes.rst

+1 on that issue, had to look up github history to find out what to notes are

Looks like this may have broke table on https://github.com/mattermost/docs/blob/master/source/upgrade/important-upgrade-notes.rst

+1 on that issue, had to look up github history to find out what to notes are

Hii @erezo9 can i work this issue?

Looks like this may have broke table on https://github.com/mattermost/docs/blob/master/source/upgrade/important-upgrade-notes.rst

+1 on that issue, had to look up github history to find out what to notes are

Hii @erezo9 can i work this issue?

Looks like this may have broke table on https://github.com/mattermost/docs/blob/master/source/upgrade/important-upgrade-notes.rst

+1 on that issue, had to look up github history to find out what to notes are

Hii @erezo9 can i work this issue?

Ye, Go for it


Sketch a DOM-free API for laying out and painting text

Rather than using the DOM to upload text and styling information into the
engine, this patch begins sketching a more direct API that bypasses the DOM and
CSS. Currently, this API doesn't do anything, but it's a first step.
The approach is to have a ParagraphBuilder object that can record a tree of
style interior nodes and text leaves. The build() function then applies
container-level styling information (such as TextAlign) and returns a Paragraph
object that can undergo layout and paint.
The inputs to the builder process are immutable style objects constructed from
primitive values. These primitives are currently carbon-copies of the primitive
we use in the framework today. After this patch lands, I'll convert the frame
to re-expose these values instead of re-defining them.

@Hixie

Seems reasonable. LGTM.
Other things to consider are how we would do hit testing (e.g. positioning the cursor), painting the selection (iOS and Android have different expectations), and how to leave placeholder holes for "replaced elements" (e.g. inline images, though ideally we'd have an adapter that would enable you to stick any old RenderBox into a Paragraph).


Custom::SopsSync hangs up without errors

Hi, I have installed the library. As per instructions I generated a JSON file and encrypted with a KMS key I previously generated in my AWS account.
This is an example of the generated file by sops:
{
	"hello": "ENC[AES256_GCM,data:A7LFTpHHrotvqNeJfI345eIeNs97f4NVrgXATg3NzoYDKEfJwidKccW+dWnZvA==,iv:GveVHTMQZ6NyFpuy+TuxM/d06oxadozZjIJ/4XepeM0=,tag:Yl0RS13KYDf2qN8cEc2CzA==,type:str]",
	"test_key": "ENC[AES256_GCM,data:x8A5,iv:XL28xQQ3CD0uULJuE6YwhIotLXPRSN5/ut07S3hcFsw=,tag:EhWzD+qNnpp+KuQ2SFuLHw==,type:str]",
	"sops": {
		"kms": [
			{
				"arn": "arn:aws:kms:MY-REGION:MY-ACCOUNT:key/MY-KEY-ID",
				"created_at": "2022-05-12T09:05:19Z",
				"enc": "AQICAHhf6MaqzwqaE/mG7yyy0ccozx8eEFMvJBnN/7bdzW/DSAGG+6nbGzyLMPUbt2W4B3wsAAAAfjB8BgkqhkiG9w0BBwagbzBtAgEAMGgGCSqGSIb3DQEHATAeBglghkgBZQMEAS4wEQQMG5kPkwFFqke+Zmu/AgEQgDuPB1k9Nd1rF8V/SbWoZa18QfoBS1siAwu0PH8uCMUF6+N7pUf2xS13QUTFfQ7gxmlWpv9LVc8DnIMTVw==",
				"aws_profile": "MY-PROFILE"
			}
		],
		"gcp_kms": null,
		"azure_kv": null,
		"hc_vault": null,
		"age": null,
		"lastmodified": "2022-05-12T09:05:41Z",
		"mac": "ENC[AES256_GCM,data:h5Tq2hqzjb69dbDjCzmCnFeEEMrkiYTwUsh8lzQAuaIcvMkB5fUXw5RnhYH/5zm6+/nEBCkUfhl2CwrIxhOW24wSO/6pfHdCerb08z3XYvqwjegZI9vIimdNu+eEDzXNGLWyo7+wkscn6gAySVF0XMKFqQ6VVgggfJqeANxjT/E=,iv:5rIL+CQagC+ntkEUKTajcLTQO+BM0xd4/PHzC1DbD5Q=,tag:S1cfql2Y44We9wME7bEwSg==,type:str]",
		"pgp": null,
		"unencrypted_suffix": "_unencrypted",
		"version": "3.7.3"
	}
}

then imported in my CDK as below:
import { SopsSecret } from "cdk-sops-secrets";
...
const sops = new SopsSecret(this, "SopsSecret", {
      sopsFilePath: "sops/enc_file.json"
    });

When CDK comes to the step of executing the SopsSync custom resource, the execution fails and no further errors can be seen, neither in console nor in Go Lambda CloudWatch.

What could be the reasons?

First, thank you for trying this out. Can you please provide the full template generated? Maybe send it to my email address.
And which version of the construct are you using?
I will dig into it :-)

And which cdk version are you using.

Hi Markus thanks for your efforts on this plugin :) I ll send full template in email. See rest of info here:
"aws-cdk": "2.2.0",
"aws-cdk-lib": "2.2.0",
"cdk-sops-secrets": "^0.3.29",
"constructs": "10.0.122",

just tried to reproduce - with no success :-(
Runs on my machine ^^
But some things we should check:

There are no logs in the cloudwatch log group /aws/lambda/<YOUR-STACK-NAME>-SingletonLambdaSopsSyncProvider<SOMETHINGsomething1234>There should be output like

  | 2022-05-13T21:34:34.324+02:00 | 2022/05/13 19:34:34 Decrypting content with format json
  | 2022-05-13T21:34:34.943+02:00 | 2022/05/13 19:34:34 Decrypted
  | 2022-05-13T21:34:35.051+02:00 | 2022/05/13 19:34:35 Succesfully stored secret:
  | 2022-05-13T21:34:35.051+02:00 | {
  | 2022-05-13T21:34:35.051+02:00 | ARN: "arn:custom:sopssync:eu-central-1:<my-account-number>:secret:SecretFDB41899-3Az5AlEaKOnE-56D7rE",
  | 2022-05-13T21:34:35.051+02:00 | Name: "SecretFDB41899-3Az5AlEaKOnE",
  | 2022-05-13T21:34:35.051+02:00 | VersionId: "64687bc990e5a3a72f5f28634643748dd058d2dbca826f24acbb2974231d25f6",
  | 2022-05-13T21:34:35.051+02:00 | VersionStages: ["AWSCURRENT"]
  | 2022-05-13T21:34:35.051+02:00 | }
  | 2022-05-13T21:34:35.094+02:00 | END RequestId: ec28a3df-f4d1-4fc5-add8-a8467f931d21

In the cf template you send me, there was an kms key: WebAppSecretConstructKmsKey is this key used to encrypt the sops file? Was the stack deleted in between (so the key isn't active anymore)? But even then, there should be an invocation of the lambda function.

Hey Markus, just looked at lambda function and this is the log as it seems
task times out after 3 seconds:
The key is the same I used to encrypt the file
START RequestId: fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Version: $LATEST
2022-05-14T20:44:41.862+02:00 2022/05/14 18:44:41 Decrypting content with
format json
2022-05-14T20:44:44.865+02:00 END RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf
2022-05-14T20:44:44.865+02:00 REPORT RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Duration: 3004.22 ms Billed Duration:
3000 ms Memory Size: 128 MB Max Memory Used: 50 MB Init Duration: 195.20 ms
2022-05-14T20:44:44.865+02:00 2022-05-14T18:44:44.864Z
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Task timed out after 3.00 seconds
2022-05-14T20:45:42.103+02:00 START RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Version: $LATEST
2022-05-14T20:45:42.113+02:00 2022/05/14 18:45:42 Decrypting content with
format json
2022-05-14T20:45:45.112+02:00 END RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf
2022-05-14T20:45:45.112+02:00 REPORT RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Duration: 3004.57 ms Billed Duration:
3000 ms Memory Size: 128 MB Max Memory Used: 36 MB
2022-05-14T20:45:45.112+02:00 2022-05-14T18:45:45.112Z
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Task timed out after 3.00 seconds
On Fri, May 13, 2022 at 9:57 PM markussiebert @.***>
wrote:

just tried to reproduce - with no success :-(
Runs on my machine ^^
But some things we should check:

There are no logs in the cloudwatch log group
/aws/lambda/-SingletonLambdaSopsSyncProvider
There should be output like

| 2022-05-13T21:34:34.324+02:00 | 2022/05/13 19:34:34 Decrypting content with format json
| 2022-05-13T21:34:34.943+02:00 | 2022/05/13 19:34:34 Decrypted
| 2022-05-13T21:34:35.051+02:00 | 2022/05/13 19:34:35 Succesfully stored secret:
| 2022-05-13T21:34:35.051+02:00 | {
| 2022-05-13T21:34:35.051+02:00 | ARN: "arn:custom:sopssync:eu-central-1::secret:SecretFDB41899-3Az5AlEaKOnE-56D7rE",
| 2022-05-13T21:34:35.051+02:00 | Name: "SecretFDB41899-3Az5AlEaKOnE",
| 2022-05-13T21:34:35.051+02:00 | VersionId: "64687bc990e5a3a72f5f28634643748dd058d2dbca826f24acbb2974231d25f6",
| 2022-05-13T21:34:35.051+02:00 | VersionStages: ["AWSCURRENT"]
| 2022-05-13T21:34:35.051+02:00 | }
| 2022-05-13T21:34:35.094+02:00 | END RequestId: ec28a3df-f4d1-4fc5-add8-a8467f931d21

In the cf template you send me, there was an kms key:
WebAppSecretConstructKmsKey is this key used to encrypt the sops file?
Was the stack deleted in between (so the key isn't active anymore)? But
even then, there should be an invocation of the lambda function.

—
Reply to this email directly, view it on GitHub
https://github.com/markussiebert/cdk-sops-secrets/issues/67#issuecomment-1126410700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXL7RZYT5KXUHOXBIXYIOQLVJ2XZFANCNFSM5VX3YCXA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Also, my generated KMS key has this permissions:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Principal": {
"AWS": "arn:aws:iam:::root"
},
"Action": "kms:",
"Resource": ""
},
{
"Effect": "Allow",
"Principal": {
"AWS":
"arn:aws:iam:::user/"
},
"Action": [
"kms:Encrypt",
"kms:ReEncrypt*",
"kms:GenerateDataKey*"
],
"Resource": "*"
}
]
}
On Sat, May 14, 2022 at 8:52 PM Antonio Lagrotteri <
@.***> wrote:

Hey Markus, just looked at lambda function and this is the log as it seems
task times out after 3 seconds:
The key is the same I used to encrypt the file
START RequestId: fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Version: $LATEST
2022-05-14T20:44:41.862+02:00 2022/05/14 18:44:41 Decrypting content with
format json
2022-05-14T20:44:44.865+02:00 END RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf
2022-05-14T20:44:44.865+02:00 REPORT RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Duration: 3004.22 ms Billed Duration:
3000 ms Memory Size: 128 MB Max Memory Used: 50 MB Init Duration: 195.20 ms
2022-05-14T20:44:44.865+02:00 2022-05-14T18:44:44.864Z
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Task timed out after 3.00 seconds
2022-05-14T20:45:42.103+02:00 START RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Version: $LATEST
2022-05-14T20:45:42.113+02:00 2022/05/14 18:45:42 Decrypting content with
format json
2022-05-14T20:45:45.112+02:00 END RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf
2022-05-14T20:45:45.112+02:00 REPORT RequestId:
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Duration: 3004.57 ms Billed Duration:
3000 ms Memory Size: 128 MB Max Memory Used: 36 MB
2022-05-14T20:45:45.112+02:00 2022-05-14T18:45:45.112Z
fdbb3100-d8e3-4da0-bf9e-ae2c2b280dcf Task timed out after 3.00 seconds
On Fri, May 13, 2022 at 9:57 PM markussiebert @.***>
wrote:

just tried to reproduce - with no success :-(
Runs on my machine ^^
But some things we should check:

There are no logs in the cloudwatch log group
/aws/lambda/-SingletonLambdaSopsSyncProvider
There should be output like

| 2022-05-13T21:34:34.324+02:00 | 2022/05/13 19:34:34 Decrypting content with format json
| 2022-05-13T21:34:34.943+02:00 | 2022/05/13 19:34:34 Decrypted
| 2022-05-13T21:34:35.051+02:00 | 2022/05/13 19:34:35 Succesfully stored secret:
| 2022-05-13T21:34:35.051+02:00 | {
| 2022-05-13T21:34:35.051+02:00 | ARN: "arn:custom:sopssync:eu-central-1::secret:SecretFDB41899-3Az5AlEaKOnE-56D7rE",
| 2022-05-13T21:34:35.051+02:00 | Name: "SecretFDB41899-3Az5AlEaKOnE",
| 2022-05-13T21:34:35.051+02:00 | VersionId: "64687bc990e5a3a72f5f28634643748dd058d2dbca826f24acbb2974231d25f6",
| 2022-05-13T21:34:35.051+02:00 | VersionStages: ["AWSCURRENT"]
| 2022-05-13T21:34:35.051+02:00 | }
| 2022-05-13T21:34:35.094+02:00 | END RequestId: ec28a3df-f4d1-4fc5-add8-a8467f931d21

In the cf template you send me, there was an kms key:
WebAppSecretConstructKmsKey is this key used to encrypt the sops
file? Was the stack deleted in between (so the key isn't active anymore)?
But even then, there should be an invocation of the lambda function.

—
Reply to this email directly, view it on GitHub
https://github.com/markussiebert/cdk-sops-secrets/issues/67#issuecomment-1126410700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXL7RZYT5KXUHOXBIXYIOQLVJ2XZFANCNFSM5VX3YCXA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes - you are right - I think the problem is as you already wrote the default lambda timeout of 3 seconds. Never touched this limit in my tests (and it's somehow strange with such a small sops file). I will create a version with a much higher default timeout. I think 30 or even 60 seconds is ok.

So I am releasing a version with increased timeout, that will hopefully fix this Problem.
Maybe you want to give version 0.3.32 a chance?

Thanks Markus, just tried and timeout helped at least moving to the next issue :-P I got below not very helpful message, but smells as it could be some sort lack of permissions
2022-05-15T21:30:07.442+02:00	START RequestId: 0adf2bc8-79f3-41f5-88a8-c44302e52c32 Version: $LATEST
2022-05-15T21:30:07.483+02:00   2022/05/15 19:30:07 Decrypting content with format json
2022-05-15T21:30:13.804+02:00	2022/05/15 19:30:13 sending status failed: Decryption error:
2022-05-15T21:30:13.804+02:00	Error getting data key: 0 successful groups required, got 0
2022-05-15T21:30:14.327+02:00	END RequestId: 0adf2bc8-79f3-41f5-88a8-c44302e52c32
2022-05-15T21:30:14.327+02:00	REPORT RequestId: 0adf2bc8-79f3-41f5-88a8-c44302e52c32 Duration: 6884.77 ms Billed Duration: 6885 ms Memory Size: 128 MB Max Memory Used: 57 MB Init Duration: 203.35 ms
2022-05-15T21:30:56.457+02:00	START RequestId: 3953026a-b8d2-4c41-96bb-11817f8c0abf Version: $LATEST
2022-05-15T21:30:56.460+02:00	2022/05/15 19:30:56 PhysicalResourceID must exist on creation, copying Log Stream name
2022-05-15T21:30:56.538+02:00	END RequestId: 3953026a-b8d2-4c41-96bb-11817f8c0abf
2022-05-15T21:30:56.538+02:00	REPORT RequestId: 3953026a-b8d2-4c41-96bb-11817f8c0abf Duration: 78.97 ms Billed Duration: 79 ms Memory Size: 128 MB Max Memory Used: 57 MB

OK, I have an Idea. Can you please Share the key policy of the key you are using?
You can send it as E-Mail of you don't want top share it here.

Hi Markus thanks for the. The Key policy I was using has the below configuration, I can share it.
Initially I only had the root but then I tried adding another user with whom I ran the sops command as below:
sops --kms "arn:aws:kms:eu-west-2:<ACCOUNT-ID>:key/6182c0b5-3fd2-468f-9edd-123eda039639" --aws-profile <AWS-PROFILE> env_test.json
The existing key policy is also covering what you mentioned above:
{     "Version": "2012-10-17",     "Statement": [         {             "Effect": "Allow",             "Principal": {                 "AWS": "arn:aws:iam::<ACCOUNT-ID>:root"             },             "Action": "kms:*",             "Resource": "*"         },         {             "Effect": "Allow",             "Principal": {                 "AWS": "arn:aws:iam::<ACCOUNT-ID>:user/<NAME-OF-AWS-USER-WITH-WHOM-I-ENCRYPTED-THE FILE>"             },             "Action": "kms:*",             "Resource": "*"         }     ] }

Ok, now I think I understand!
You are using a profile in your sops file. Never tried this before - but I get the same error if I use it. In the Lambda environment there is no profile "MY-PROFILE". I think I have to configure not to use any profile inside the lambda - even if one is set in the sops file. Maybe you can try with a sopsfile without a proifle?

May I ask you how can I achieve that?
I am using ops 3.7.3 and upon providing the KMS arn, without the aws-profile with below command:
sops --kms "arn:aws:kms:REGION:ACCONT:key/KMS-KEY-ID" env_test_1.json
I get  Failed to call KMS encryption service: AccessDeniedException.
Is not aws profile mandatory?

Not if you have a default profile. The problem if you use the --profile flag, than everyone that wants to access this file needs this profile. But this is something personal - everyone can name a profile the way hew wants. So I would recommend in this case to use only the default profile (no option set) (credentials in the block [default] or the current runtime credentials like instance profile, container profile and so on)

and even better https://github.com/mozilla/sops/issues/634


Fill out array support

Basic array support is in, but it's not complete.  Need to be able to do more complex expressions like:
x[0].update();
x[1].g;
x[2].f = 4;

Fixed with 5ccfab87ce5212a250b8e78608cbc8caf4204740


Crash when playing spx-biocoresystem.it

I noticed that when playing this module, https://api.modarchive.org/downloads.php?moduleid=193837#spx-biocoresystem.it, it2play crashes consistently around order 61. There's also another crash that can happen around order 28, but that seems to be more rare. Tested with it2play.exe compiled under Visual Studio 2022.

Hi, thanks for reporting the issue! I have narrowed it down to being a problem with it2play on pingpong/bidi-loops played at an extremely high pitch. I am currently trying to find out if I forgot to add a special test case in the loop wrap handling. I'll come back to you eventually.

OK I fixed this issue now!

Confirmed, the module plays without crashes. Thanks!


supervisor_failure_test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.664%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1462

Relevant Lines:
2012

💛  - Coveralls

Closing in favour of #517


test

/remind me to see this in 2 ours

/remind me to see this in 2 ours

See bz-234

/remind me to see this in 2 hours

See bz-254

See bz-254

/remind me to see this in 2 hours

Testing

test

Close bz-345

Check bz-345

Check bz-345

Check !453


SecurityGroupRule adding additional cdirBlocks does not work

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)
SecurityGroupRule.ec2.aws.upbound.io/v1beta1
Resource MRs required to reproduce the bug
apiVersion: ec2.aws.upbound.io/v1beta1
kind: VPC
metadata:
  name: testing-vpc
spec:
  forProvider:
    region: us-west-1
    cidrBlock: <IP_ADDRESS>/16
    tags:
      Name: testingVpc
---
apiVersion: ec2.aws.upbound.io/v1beta1
kind: SecurityGroup
metadata:
  labels:
    testing.upbound.io/example-name: securitygroup1
  name: securitygroup1
spec:
  forProvider:
    description: test
    name: test
    region: us-west-1
    tags:
      Name: test
    vpcIdRef:
      name: testing-vpc
---
apiVersion: ec2.aws.upbound.io/v1beta1
kind: SecurityGroupRule
metadata:
  name: test
spec:
  forProvider:
    cidrBlocks:
      - <IP_ADDRESS>/16
    fromPort: 0
    protocol: tcp
    region: us-west-1
    securityGroupIdRef:
      name: securitygroup1
    toPort: 65535
    type: ingress

Steps to Reproduce

Create VPC
Create SecurityGroup
Create SecurityGroupRule which is attached to SecurityGroup with cidrBlocks:

    cidrBlocks:
      - <IP_ADDRESS>/16

Wait until all is ready
Add additional cidr to SecurityGroupRule:

    cidrBlocks:
      - <IP_ADDRESS>/16
      - <IP_ADDRESS>/24

What happened?
After adding an additional cidr block to the ready SecurityGroupRule, the rule is not updated and an error is reported.
Relevant Error Output Snippet
async update failed: refuse to update the external resource: cannot change the value of the argument "cidr_blocks.#" from "1" to "2"

Crossplane Version
1.14.5-up.1
Provider Version
0.47.1
Kubernetes Version
v1.28.3
Kubernetes Distribution
EKS
Additional Info
No response

@Donimax thanks a lot for the detailed reproducer!
To unblock yourself, could you try to use alternative resources https://marketplace.upbound.io/providers/upbound/provider-aws-ec2/v0.47.1/resources/ec2.aws.upbound.io/SecurityGroupIngressRule/v1beta1 and https://marketplace.upbound.io/providers/upbound/provider-aws-ec2/v0.47.1/resources/ec2.aws.upbound.io/SecurityGroupEgressRule/v1beta1 .
They might work better in this scenario.

@ytsarev
I am familiar with securityGroupIngress/EgressRule and understand that it may serve as a temporary solution. However, using securityGroupIngressRule would result in 54 rules in the our smallest setup, compared to only 10 securitygrouprule. This is because only one CIDR can be specified per SecurityGroupIngressRule. In a typical deployment from us, there would be 171 or much more rules.

@Donimax, the error output here is confusing, it looks like we cannot update cidrBlocks without resource recreation, see underlying https://github.com/hashicorp/terraform-provider-aws/blob/9e9a0fb71f3e25bd68d6dc9199c8913acc6b6f88/internal/service/ec2/vpc_security_group_rule.go#L50 where we have ForceNew on the field.

This is because only one CIDR can be specified per SecurityGroupIngressRule
It looks like it is in line with what is happening on the AWS API side where these requests are also granular https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CidrBlock.html, https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SecurityGroupRuleUpdate.html, https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SecurityGroupRuleRequest.html.

It is also in line with Crossplane Resource Model, High Fidelity concept: https://github.com/crossplane/crossplane/blob/master/design/one-pager-managed-resource-api-design.md#high-fidelity
I suggest abstracting SecurityGroupIngressRule creation with custom XRD + Composition. This way you will not directly be exposed to the mass number of Managed Resources.

Take a look here: https://github.com/upbound/configuration-aws-securitygroup


Cannot download entire video library - Youtube

Checklist

[ X] I'm reporting a broken site support
[ X] I've verified that I'm running youtube-dl version 2020.05.08
[ X] I've checked that all provided URLs are alive and playable in a browser
[X ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ X] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-i', '-v', '-f', 'mp4', 'https://www.youtube.com/user/DIYPerks/videos']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.05.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg git-2020-03-15-c467328, ffprobe git-2020-03-15-c467328
[debug] Proxy map: {}
[youtube:user] DIYPerks: Downloading channel page
[youtube:playlist] UUUQo7nzH1sXVpzL92VesANw: Downloading webpage
[download] Downloading playlist: Uploads from DIY Perks
[youtube:playlist] playlist Uploads from DIY Perks: Downloading 87 videos
[download] Downloading video 1 of 87
[youtube] V-vFtiDYiIw: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 429: Too Many Requests (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp4z7swgz7\build\youtube_dl\extractor\common.py", line 627, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp4z7swgz7\build\youtube_dl\YoutubeDL.py", line 2238, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Description

WRITE DESCRIPTION HERE

Did you figure out the problem?


Property-sort-order is missing convention-explanation

What version of Sass Lint are you using?
1.11.1
Please include any relevant parts of your configuration
Using it with vscode
What did you do? Please include the actual source code causing the issue.
What actually happened? Please include any error messages given to you by Sass Lint.

The errors above not very clear for a lot of users. It would be nice if we could at least see that the order is wront.
If you're using a IDE plugin have you tried the CLI too?
Yes, the output actually says the warning/error is about order:

I'm assuming you mean the lack of a rule name in the original screenshot/error message?
 It looks like the platform you're using to consume sass-lint with is not reporting the rule names to you. I would make an issue with the vscode plugin and ask if they could update their error reporting to show the rule name. As for the rest of the text this is pretty standard for a sort order rule. I believe @glen-84 made the vscode plugin originally over at https://github.com/glen-84/vscode-sass-lint if you'd like to make a suggestion.

This issue can be closed. The rule name (id) was added to the message in v1.0.0 (2017-11-12).


Graphics.addHole API doesn't work with CanvasRenderer

Found in #4177
It appears that addHole does not render correctly for CanvasRenderer.
WebGL example (works): https://jsfiddle.net/kr1ha29b/ 👍
Canvas example (broken): https://jsfiddle.net/LLk9nj00/ 👎
Correct render:

I have found a similar problem but for me the CanvasRenderer seems to render it correctly and not the WebGLRenderer when comparing it to a similar svg. In the SVG it doesn't matter if we draw the small or the large rectangle first, as long as the direction of the inner and outer rectangles are different. The CanvasRenderer behaves the same but the WebGLRenderer renders differently as you can see in my example:
Small rectangle first:
WebGL example (broken): https://jsfiddle.net/kr1ha29b/10/
Canvas example: https://jsfiddle.net/LLk9nj00/6/
SVG example: https://jsfiddle.net/LLk9nj00/7/
Large rectangle first:
WebGL example: https://jsfiddle.net/LLk9nj00/9/
Canvas example: https://jsfiddle.net/LLk9nj00/10/
SVG example: https://jsfiddle.net/LLk9nj00/9/

Any prediction of when this is going to be fixed?

@anticore Any ideas on how to fix it?

@ivanpopelyshev Unfortunately, no. I tried solving it but couldn't figure it out.

Do you need it for a mask?

@ivanpopelyshev Yes. We have a mask that's constructed dynamically by adding holes and we need it to work on both WebGL and Canvas.

Well, there's an idea that you have to make outer polygons counter-clockwise and inner clockwise. Let me see the code ...

I think I can try to implement that only for masks.

Fixed by #5202


[bug] Initial content doesn't render inside app macOS

Describe the bug
After executing cargo create-tauri-app and selecting rust/yew, the default content doesn't render inside the application window.
Reproduction

cargo install create-tauri-app
cargo create-tauri-app

Select Rust
Select yew

cd new-tauri-app
cargo tauri dev

Expected behavior
Application window opens and default template content is rendered.
Platform and versions
WARNING: no lock files found, defaulting to npm

[✔] Environment
    - OS: Mac OS 10.15.7 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-apple-darwin (environment override by RUSTUP_TOOLCHAIN)
    - node: 16.14.0
    - yarn: 1.22.10
    - npm: 8.3.1

[-] Packages
    - tauri [RUST]: 1.3.0
    - tauri-build [RUST]: 1.3.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: not installed!
    - @tauri-apps/cli [NPM]: 1.3.1

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:1420/

### Stack trace

```text
`Unhandled Promise Rejection: Error: WebAssembly.Module doesn't parse at byte 273`

Additional context
No response

Thanks for the report! This looks like something we should ask the yew devs about since i see the same issue in plain safari 13.1 :thinking:

Is there a way to change the version of safari used? When I navigate to the yew frontend in safari 15.6.1, the page renders fine.

Only by updating macOS itself.

Any ideas why I would see different behavior between the tauri app window and safari proper then?

Well, different webkit/safari versions. The webview on macOS is basically Safari 13 and that can only be updated via OS updates. Maybe yew uses some feature that wasn't available in Safari 13.

FWIW, this seems to be bigger than just Yew.
I'm using solidjs and any reload event or additional window event (like "alert('hi')") will not render on macos while developing.
If I tab to another workspace and back, then it renders the window, so this feels like the rust-level host of the webview isn't doing the right thing.

Same here, using Leptos.
Using Leptos alone fine,
Tauri fine,
Merging both, WASM initialization is failed.
Unhandled Promise Rejection: Error: WebAssembly.Module doesn't parse at byte 209: invalid opcode 195, in function at index 3

I was having some of this issue, then upgraded rust from 1.75 to 1.77 and was able to update main.rs (not app.rs) and things seem to render well.


How can i get uniform buffer members?

I'm accessing the shader_resources uniform_buffers members, how can I get members of given uniform buffer? How about type, size etc?
Thanks

Hi, you can use
const SPIRType &type = compiler.get_type(resource.base_type_id);

to get the underlying UBO type. For names,
compiler.get_member_name(resource.base_type, member_index);


More performant random channel/destination generation

(Rewrite of the commit history of #3687 , originally authored by @andrewgordstewart )
The affected test helpers do not require knowing the private key corresponding to the signing address that generates:
the destination; or
the channel id
When this is the case, it's much faster to generate a random hex string. Creating an ethers wallet is already slow; doing so in a jest environment is very slow (I believe it takes on the order of 100ms.)

@andrewgordstewart I can't approve this. But I approve this.


[Runtime] Fix call site for malloc_type_posix_memalign.

Seems I missed off the type ID.  Oops.
rdar://119137861

@swift-ci Please test

Explanation: Apparently I missed off the final argument in the previous PR. Seems the public CI doesn't actually build this code at all.
Original PR: #70447
Risk: Low.
Reviewed by: @mikeash
Resolves: rdar://119137861
Tests: There are now tests, but they aren't active in public CI at least because of availability.


Update qualities.py

add 540p support, as used by some anime releases (for whatever reason...)
Motivation for changes:
adds support to new quality 540p ( https://en.wikipedia.org/wiki/Graphics_display_resolution#960_×_540_(qHD))
Detailed changes:

adds 540p Quality

Addressed issues:
/
Implemented feature requests:
/
Config usage if relevant (new plugin or updated schema):
allows:
quality: 540p

Log and/or tests output (preferably both):
/
To Do:
/

ping

Sorry we let this languish so long! Thanks!


Use :before pseudo element to increase hit size of points

This makes it easier to drag and drop points, rather than entire shapes.
Gif demonstrating markers with larger hit targets

Gif demonstrating larger hit targets and :hover styling to emphasis active marker

Ref: #565

Oops, left some debug outlines in there. Will tidy this up and resubmit next week. Apologies for the noise 👁  Watchers


Added querying for blocks from time frame

for issue #106, added a way to get blocks from a timeframe and added an example endpoint /api/block/time/day/{MM-DD-YYY} to get blocks on an specific day,  /api/block/time/day/ returns blocks from the current day. Wanted a review before proceeding

@RogueElement Closing this since what we will summing the totals of all blocks in the range, rather then displaying a list of blocks for the range.


Log errors when flushes fail

There errors were getting silently dropped which might be hiding
problems.

+1.
Although for almost all of the underlying file operations in either the WAL or the index, I'd probably rather see it panic. By the time it gets to a flush, the only error that should be possible is a system error, from which I don't think we can recover.

I'm not really a fan of adding panics this low in the code.  I'd rather see the code gracefully handle the error, but stay running and respond with sensible errors.  Perhaps even log more detailed diagnostic information.  Ideally, the server would degrade or disable functionality but not crash.  For example, if the disk is full, a write could fail.  That is usually a transient issue as an automated job is in the process of freeing up space.  Why should we prevent queries and read-only operations  when only writes are failing?
My main issue with panics in low-level code, for errors that could be handled, is that it does not build trust that the software is robust.  A stacktrace is very useful, but we could log it and more context, keep running and recover in many of the situations where we currently panic.

The logging is working:
[tsm1wal] 2015/10/22 07:03:10 failed to flush to index: remove ids: permission denied
[tsm1] 2015/10/22 07:03:10 PerformMaintenance: WAL flush failed: remove ids: permission denied
[tsm1wal] 2015/10/22 07:03:10 failed to flush to index: remove ids: permission denied
[tsm1] 2015/10/22 07:03:10 PerformMaintenance: WAL flush failed: remove ids: permission denied

hmmm, I feel like this error should just panic the server because it's something that will cause bad problems if we just continue as though everything is ok.
Any ideas why you're getting a permission denied error?


dvtm + dtach is bad when $TERM changes

Hi,
when running dvtm inside a dtach session, it can validly happen that you're later attaching from a different terminal type than the one you initially used. This means dvtm will output invalid escape sequences. E.g. try attaching back and forth from TERM=linux and TERM=xterm. You'll notice corruption. Even worse on FreeBSD, as cons25w is quite different from xterm.
Also, dtach doesn't really have the ability of handling this either (it can't influence the environment of a child process, sure, but there also isn't another hook facility for something like this). Remember, unlike dvtm, dtach is a simple attach/detach program without any terminal conversion functionalities.
tmux and screen both handle this - so there should be a way for dtach/dvtm to handle this too, right?
My current workaround is running dtach inside each dvtm window, instead of dvtm inside dtach, but that approach clearly loses the layout each time I reattach and provides no scrollback. So instead I'm proposing this:

Give dvtm a command (e.g. via the commands FIFO) to update the value of $TERM and reinitialize ncurses.
Then I can write a script that uses this command to set the new terminal type before attaching using dtach.

Is this doable?

I already faced a similar issue with abduco,  at #23.  A workaround was setting the term to screen (or what works the best) before attaching dvtm.
To avoid to write everything by hand, I use a shell script, or an alias like this:
a='TERM=screen abduco'

Hope it helps.

Too bad TERM=screen isn't going to work well enough for my uses (e.g. it'll break heavily from FreeBSD's cons25w).
My "new" workaround is now running dvtm inside dtach inside dvtm. The outer dvtm is a mere terminal emulator to make the dtach safe; the inner dvtm is the actual window manager. Which also means the outer dvtm gets no modifier key. Kinda overkill, but works...

I'm glad it works, and it could be useful to me too some day.
dvtm permits to choose a different modifier with -m, and I did not imagine it could be this convenient: It suddenly makes

For reference, this is my current workaround script (which I call "dvtach"):
#!/bin/sh

export DVTM_PID=$$
exec dvtm -M -m ^@ 'dtach -A ~/.dvtach -r winch -z dvtm -M; kill $DVTM_PID'

Adding support for multiple sessions would be an easy exercise :)
(The kill command "hides" the second dvtm window with a command shell that the outer dvtm creates)


Pick first element from array doc.url

Hello,
in our company we are currently evaluating Datafari. Using it we found an issue in the SubClassResult.widget.js. It crashes when you get the field URL in line 38 an array. I changed the code so you always have a string, by picking the first element from the array.
Greetings
Imanuel Ulbricht

Hi,
First very sorry for the delay of the response !
And thanks for your interest in Datafari and for sending your contribution.
The code you sent is not necessary in standard Datafari because the Solr field url is not multivalued.
Thanks again and do not hesitate to send us new contributions !

To be more precise the code you submitted may be relevant the day we decide to have multivalued field for url. But as far as we know we have not planned in the coming future to use multivalue for this field.
In case you do need to have a multivalued field, I suggest to create a new custom field dedicated for that.

FYI, I have experienced a similar problem related the URL field (Solr crash when encountering a doc with multiple values for URL). While the design intent reasonably limits URL to a single value, I have seen rare cases where metadata for a document contains multiple URL’s. Since we have no control over the metadata in the documents we process, we need a way to gracefully handle receiving a multivalued field when a singal value is expected.


3.1.3 RE1 room 306 pc out of bound

Version
3.1.3
Seed
R710-FUCK-ZXPH40QZ4Z3CHQNV6XVM4L01J11RZZZZZZZZH2YYZZZZ
Scenario
RE 1 (Chris)
Player Character
regina
What happened?
room 306 pc out of bound
Chris_02_2023-09-19 01^41.01.zip

This may no longer be a problem in dev. builds as it is limited to one black tiger regardless of difficulty. I think what is happening is that the black tigers are so big that it pushes you out the room when you enter the door.


Allow SEO crawling from docs site

Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>Docker-DCO-1.1-Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>(github: nathanleclaire)
(cherry picked from commit de03f4797b614fb192a72c83812c2a04a1939c87)

Looks like we would not be able to merge this PR because of merge conflicts. Please fix them and force push to your branch.

ping @jfrazelle arrrgh it is dying because of those merge commits! Can I get an LGTM anyway? It builds locally.

LGTM
On Fri, Apr 10, 2015 at 4:07 PM, Gordon<EMAIL_ADDRESS>wrote:

Looks like we would not be able to merge this PR because of merge
conflicts. Please fix them and force push to your branch.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12285#issuecomment-91713066.

gotchu :)
On Fri, Apr 10, 2015 at 4:11 PM, moxiegirl<EMAIL_ADDRESS>wrote:

ping @jfrazelle https://github.com/jfrazelle arrrgh it is dying because
of those merge commits! Can I get an LGTM anyway? It builds locally.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12285#issuecomment-91713506.

thanks @moxiegirl sorry about this whole ordeal
On Fri, Apr 10, 2015 at 4:18 PM, moxiegirl<EMAIL_ADDRESS>wrote:

Merged #12285 https://github.com/docker/docker/pull/12285.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12285#event-278565592.

@jfrazelle no worries Jess. It is pretty cool Fanette caught it so quick! Good team those Docker folks!


Adds an openAbout action.

Just as it says on the label.
Closes #15986

nit: reword title to be in imperative form


Trying inherit Bahdanau monotonic attention for location sensitive attention but loss exploded

@Rayhane-mamah I am trying BahdanauMonotonicAttention as super class over location sensitive attention. I just replace the original BahdanauAttention with BahdanauMonotonicAttention and removing probability_fn parameter in the __init__ method. And the program began to run. However it quickly quited as an exception has been raised showing LOSS EXPLODED. I have no idea about it. Would you please do me a favor with it? Many thanks.
Tacotron training set to a maximum of 200000 steps
No model to load at logs-Tacotron/taco_pretrained

Generated 32 test batches of size 32 in 2.986 sec

Generated 32 train batches of size 32 in 3.032 sec
Loss exploded to nan at step 1 loss=nan, avg_loss=nan]
Exiting due to exception: Loss exploded
Traceback (most recent call last):
  File "/home/leoma/Tacotron-2/tacotron/train.py", line 184, in train
    raise Exception('Loss exploded')
Exception: Loss exploded

@begeekmyfriend I think the locative sensitive attention could capture the locality. But monotonic attention  also has the same feature which could maybe confict with the original code. Have you tried to replace the location sensitive attention with monotonic attention throughly?

Not yet. I want to do that just because some bad corpus can not be aligned in this project. So I tried but  not made any progress currenly.

@begeekmyfriend Have you solved this problem? I met the same problem.

Meanless because it has been implemented in the latest version. Closing it.


chore: bdd-gh-1586709975 to 0.0.1

chore: Promote bdd-gh-1586709975 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix regressions in transactions handler

A regression test suite was recently added in 86d8ac62a382352af70e07b04ac7f5d183c65353 (see #2). However, there are a lot of tests that are failing. This is a meta-issue to track them.
List of transactions regression tests to fix (as of e18e76d)

[x] 0xed6c2cc62eb0e07e31c1405d02718cdf6387a2f27414a8431d089baaf3e4be86

value field in one of the inputs was 0, resulting in negative fees.

[x] 0xb1bc074dfdd17d1f0280c8ed795b1f5c446e6d87e769add11adf079b77820b18

Block height was -1. The root cause is unknown due to lack of error handling.

[x] 0x5a33bac12d39b43bddd55b08c6dc4864ecfd3696a78c79dea8d1914d8634604c

Missing address fields on all inputs.

[x] 0xe48d60fd63547eafb16ce20c857841f292cdb2b93542ad4acc8f186b2594c849

value field in one of the inputs was 0, resulting in negative fees.
Missing address field in one of the inputs.

[x] 0x5c80ce7a3b0084e0ad9af0afdfe4277ec1cdbac00feb1a83452025766ae85270

Big mess with inputs. Nothing seems to match.

[x] 0x5e1930fe6aa4df278ec23e61a5eef252516b49d52334b25dd9875ce0ad4d0394

value field in one of the inputs was 0, resulting in negative fees.
Missing address field in one of the inputs.

[x] 0x670a6a5b792d2d4e968c52945fd7fe0d4266b4e285fc8a8ef9d4a5996d2572f1

inputs out of order.
Missing address field in one of the inputs.

[x] 0xe8d1ec4e24b1868411676d0ed5af4188bdbb6e0965dc95538a22bee86b3422ea

value field in one of the inputs was 0, resulting in negative fees.
Missing address field in one of the inputs.

[x] 0xc849478174f83b0544580dd6ae8bfd2d410e7e3f2f3a3f4096de1929ca24b095

inputs out of order.
value field in one of the inputs was 0, resulting in negative fees.
Missing address field in one of the inputs.

[x] 0x670a6a7bfff0fec3b6d6fe570b40bba2d1c075bf6f557709072f6d527b4ed717

inputs out of order.
value field in one of the inputs was 0, resulting in negative fees.
Missing address field in one of the inputs.

...and 34 other transactions.

0x5a33bac12d39b43bddd55b08c6dc4864ecfd3696a78c79dea8d1914d8634604c is an expected failure. See 6c2c417 for details.

Regression tests are now passing on CI. ✔


HomeBridge updated to 1.8.3 which updated Node.JS to 20.14.0 - Had to downgrade to 20.11.0 because of homebridge-eufy-security plug-in - getting a warning

Describe The Bug
HomeBridge updated to 1.8.3 which updated Node.JS to 20.14.0 - Had to downgrade to 20.11.0 because of homebridge-eufy-security plug-in - getting a warning
A bug happened!
HomeBridge updated to 1.8.3 which updated Node.js to 20.14.0
I have downgraded Node.js to 20.11.0 but getting this warning:
"[Homebridge UI] [homebridge-config-ui-x] Failed to check registry.npmjs.org for updates: "Cannot read properties of undefined (reading 'length')" - see https://homebridge.io/w/JJSz6 for help."
I checked the perviously mentioned URL and found the phrase "Failed to check registry.npmjs.org for updates" under "NPM Registry Issues".
Hiowever the keywords of "Cannot read properties..." are not listed.
I have not been able to determine what is causing this yet.
PlugIn Version v3.4.2
HomeBridge Version v1.8.3
cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
*** Homebridge Raspbian "homebridge/homebridge-raspbian-image-v1.1.0-(64bit)" - Raspberry Pi 3 Model B Rev 1.2 ***
Logs
[24/06/2024, 08:58:16] [Hubitat-v2] [Device Event]: (Basement - LG Sidekick) [POWER] is 0.735
[24/06/2024, 08:58:42] [Homebridge UI] [homebridge-config-ui-x] Failed to check registry.npmjs.org for updates: "Cannot read properties of undefined (reading 'length')" - see https://homebridge.io/w/JJSz6 for help.
[24/06/2024, 08:58:42] [Homebridge UI] [homebridge-config-ui-x] Failed to check registry.npmjs.org for updates: "Cannot read properties of undefined (reading 'length')" - see https://homebridge.io/w/JJSz6 for help.
[24/06/2024, 08:58:46] [Hubitat-v2] [Device Event]: (Basement - LG Sidekick) [POWER] is 0.774
Config
{
    "bridge": {
        "name": "Homebridge E75B",
        "username": "USERNAME",
        "port": 51114,
        "pin": "PIN",
        "advertiser": "avahi",
        "bind": [
            "eth0"
        ]
    },
    "accessories": [],
    "platforms": [
        {
            "name": "Config",
            "port": 8581,
            "auth": "form",
            "theme": "dark-mode",
            "tempUnits": "f",
            "lang": "auto",
            "platform": "config"
        },
        {
            "name": "Hubitat-v2",
            "app_url_local": "LOCAL_URL",
            "app_url_cloud": "CLOUD_URL",
            "use_cloud": false,
            "app_id": 187,
            "access_token": "TOKEN",
            "direct_port": 8000,
            "polling_seconds": 3600,
            "temperature_unit": "F",
            "round_levels": true,
            "adaptive_lighting": true,
            "adaptive_lighting_offset": 0,
            "consider_fan_by_name": false,
            "consider_light_by_name": false,
            "validateTokenId": false,
            "logConfig": {
                "debug": false,
                "showChanges": true
            },
            "platform": "Hubitat-v2",
            "_bridge": {
                "username": "USERNAME",
                "port": 59168
            }
        },
        {
            "country": "US",
            "language": "en-US",
            "auth_mode": "token",
            "refresh_token": "REFRESH_TOKEN",
            "username": "USERNAME",
            "password": "PASSWORD",
            "platform": "LGThinQ",
            "devices": [
                {
                    "id": "ID",
                    "name": "Pedestal Washer",
                    "type": "WASHER",
                    "washer_trigger": false
                },
                {
                    "id": "ID",
                    "name": "Washer",
                    "type": "WASHER",
                    "washer_trigger": true,
                    "washer_door_lock": false
                },
                {
                    "id": "ID",
                    "name": "Kitchen Range",
                    "type": "OVEN"
                },
                {
                    "id": "ID",
                    "name": "Dryer",
                    "type": "DRYER",
                    "washer_trigger": true,
                    "washer_door_lock": false
                }
            ],
            "thinq1": false,
            "refresh_interval": 60,
            "_bridge": {
                "username": "USERNAME",
                "port": 42665
            }
        },
        {
            "username": "USERNAME",
            "password": "PASSWORD",
            "country": "US",
            "deviceName": "",
            "platform": "EufySecurity",
            "_bridge": {
                "username": "USERNAME",
                "port": 50825
            },
            "cameras": [
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                },
                {
                    "serialNumber": "SERIAL_NUMBER",
                    "rtsp": false,
                    "snapshotHandlingMethod": 3,
                    "refreshSnapshotIntervalMinutes": 0
                }
            ],
            "ignoreDevices": []
        }
    ],
    "disabledPlugins": []
}

Homebridge UI Version
UI v4.56.2
Homebridge Version
v1.8.3
Node.js Version
v20.11.0
Operating System
Official Homebridge Raspberry Pi Image
Environment Info
None
Raspberry Pi Model
Raspberry Pi 3 B+

this is fixed with the latest version of Hombridge UI. v4.56.3
duplicate to #2070

Upgrading seems to have worked, thank you!


Make spaces dav endpoint aware of previews

Is your feature request related to a problem? Please describe.
While trying to retrieve a preview image in owncloud/web project via webDav:
https://localhost:9200/remote.php/dav/spaces/ef03e8c8-343e-44f4-b5f8-be8a18b2f396/Screenshot from 2021-09-25 18-56-48.png?a=1&c=9066a03071ce20d4b96e028252109259&preview=1&scalingup=0&x=36&y=36
I retrieve a 404 error.
Describe the solution you'd like
Provide a preview via the mentioned URI

FYI @micbar @C0rby


keyWords from objects to array of string type #300

You should get rid of:

meta-data action and states related to the KeyWord old functionality

2)key-word service

key-word model


Add option to push object ID(s) directly.

Adds a new option "--objectid" to the push command to upload objects generated by BFG. Click here for an example how to use it with BFG.
Note:
I am learning golang. Please point out to me anything that could be improved. Even if pedantic :smile:

Other than my comments above, I'm :+1: on this. Curious what others think though.

:+1: from me, seems like it'll be some useful tooling

Thanks for hanging in their, @larsxschneider :)

@larsxschneider Can you update docs/man/git-lfs-push.1.ronn accordingly?

@michael-k Thanks for the hint. I will fix it ASAP.

Since I'm prepping a new release, I went ahead and did it: #509
Though this makes me consider making it a boolean flag in v0.6.x:
$ git lfs push <remote> --object-id="oid1 oid2 oid3"


limbo: add intermediate-with-san-rejected-by-nc

This adds two additional NameConstraints testcases, testing variants of the "intermediate with SAN" scenario in https://github.com/pyca/cryptography/pull/8873#discussion_r1403517013.
Experimentally, it looks like each of OpenSSL, crypto/x509, and Rust's webpki correctly reject these: https://github.com/trailofbits/x509-limbo/actions/runs/6975969730

These look like good tests. I don't think they're the same as the case I flagged the bug on, which involved 2x NCs.

I might have misunderstood, but I thought you flagged two different bugs.
This PR covers this one: https://github.com/pyca/cryptography/pull/8873#discussion_r1403517013
I haven't started on this one yet (but will do it next): https://github.com/pyca/cryptography/pull/8873#discussion_r1403526232

Ah ok, I was just in the wrong headspace.


feat: pass accountId back with websocket txs

a backwards compatible change that allows us to greatly simplify tx subscription logic in web
by passing back the accountId with a transaction message, web is able to determine which account it
belongs to and index it correctly in the store
this also allows use to delete a quarter of the portfolioSlice which maintained a mapping between
accountIds -> address[], which solely existed to be able to do this lookup

closing after discussion with @kaladinlight - we have a better approach such that the restful getTxHistory and subscribeTxs return the same Transaction interface


Display server per channel in springwolf-ui

In a setup similar to your example ExampleClassLevelKafkaListener, I tried to use KafkaAsyncOperationBinding "type" in order to separate  listeners per server they listen to. But I'm getting "kafka" instead.
springwolf-kafka version 1.1.0.
@KafkaListener(topics = "${push-api.topic}", groupId = "${push-api.topic.consumer-group}")
public class PushApiListener {

    @KafkaHandler
    @KafkaAsyncOperationBinding(
            type = "kafka-external"
    )
    public void handleNotification(NotificationDto notification) {
        ...
    }

springwolf.docket.servers.kafka-external.protocol=kafka-secure
springwolf.docket.servers.kafka-external.host=...

Expected: In the UI listener will be shown with tag "kafka-external"
Actual: It is shown still as "kafka"

EDIT by maintainer:
Requested enhancement:

[ ] Display the server name in springwolf-ui. A starting point can be channels.component.html. This can be a simple tag next to the protocol badge.

According to the spec, a server can be present on the channel kafka-example. If not present, the channel is available on all servers defined in the servers block.
You, or anybody who is interested, is welcome to contribute.

To better indicate in the ui the difference between protocol and server name, https://github.com/springwolf/springwolf-core/pull/738 updates the examples
Help is still welcome to show the server name as part of the channel item

On this is being worked in https://github.com/springwolf/springwolf-core/pull/832


Move TDML processor cache from a global object to DFDLTestSuite instances

With the compiled processor cache stored in a global object, it meant
the cache would never be emptied. Although this avoids schema
compilation, it also meant TDML runners could use a large amount of
memory that could never be released. This changes the TDML runner so
that the cache is stored on the DFDLTestSuite. This means only tests
run from the same runner can share compiled schemas. This also means
once a test suite has completed and goes out of scope, so do those
compiled schemas. So re-running a test requires recompliation. To
ensure we only compile once even when parllel threads might access the
same Runner/DFDLTestSuite, we add syncrhonization during schema
compliation.

This also removes the existing SchemaCache. It had some logic that we
no longer need anymore (e.g. file change detection) since we now
recompile schemas more frequently. The new cache also supports caching
results from any implementation rather than from just the Daffodil
runtime1 implementation.

This also removes a ThreadLocal from the RunnerFactory to ensure
different threads using the same Runner do not recreate a dupliate
DFDLTestSuite. We want to share DFDLTestSuite's as much as possible.
This does now mean that parse/unparse can actually happen in parelell
using the same CompileResult. If an implementation does not support
that, they must implement their own syncrhonization during these
calls.

With runtime2 processor cached and shared among individual
parse/unparse tests, this revealed a bug where we cleaned up the
generated executable incorrectly. We should only delete the generated
executable when we were done with the CompileResult, but we instead
deleted it whenever we finished an individual test. This meant that if
two tests shared a processor, the first test would delete the
executable and it wouldn't exist for the second test. To fix this, we
add a new cleanUp method to the TDMLDFDLProcessor, which is called
when the DFDLTestSuite is reset to empty. The parse/unparse results do
not actually need to clean anything up for runtime2 since they clean
up their own temporary data.

Also adds prefixies to runtime2 temp files so that it's easier to know
which temp files belong to Daffodil.

Remove all uses of DFDLTestSuite and deprecate the only public
constructor. Replace all instances of the DFDLTestSuite with the
Runner and call reset to ensure temp files are cleaned up.

Remove the ability to pass in a schema node to TDML Runner functions.
This was only used for unit tests. This instead changes unit tests to
used things like embedded TDML schemas so that these unit tests use
the same code path as normal tests.

DAFFODIL-2520

Okay, now I see why the "Set the SONAR_TOKEN env variable" error message occurs.  When a pull request comes from a forked repository, the fork's job is not allowed to use any secret from the daffodil repository.  It still can use secrets.GITHUB_TOKEN (that's not really a secret because the forked repository has a github_token automatically) but it can't use secrets.SONAR_TOKEN.  We need to change the if condition for the Sonar steps to something like
        if: ${{ runner.os == 'Linux' && matrix.java_version == '11' && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == 'apache/daffodil') }}
If you make that change to two lines in main.yml (lines 150 and 156), the CI should skip the Sonar steps for your pull request and all your checks should pass.

When a pull request comes from a forked repository, the fork's job is not allowed to use any secret from the daffodil repository.

Does it make sense to move Sonarcloud back to it's own file? Our workflow pretty much always uses forks (except for the dependabot things which we can't change) so pull requests are rarely going to run for pull requests.
Also, this PR branched before the sonarcloud changes were merged. So this PR shouldn't even have updated main.yml? Do github actions the main.yml from the master branch now and not from the PR?

How does this impact running our basic 'sbt test', is it faster or slower?

I ran it a few times with and without the change, and sometimes it was quicker, sometimes it was slower. So I'm not sure it makes a difference.
I also tested back to back (e.g. sbt test test). My thinking was that before this change, compiled schemas would still be cached for the second test, so the second test wouldn't need to compile anything and should be faster than the first. But there really was no difference there either. I'm not sure if maybe there just weren't enough things being cached (I think we only cached file-based schemas before?), or if sbt is doing some magic to clean up and recreate objects inbetween tests, or if schema compilation just isn't the slow part of our test suite. Either way, the global cache didn't seem to help a ton.
I did run things through a profiler before and after this change and looked at the memory usage. Before this change, sbt had 0.26 GB of used memory before running tests and 0.43 GB after. So ~200MB of cached "stuff". After this change, it went from 0.26 GB to .33 GB so about ~100MB of cached "stuff". I think there's a lot of stuff other than our schemas, much of with is just Scala stuff. It's pretty surprising to see how many objects scala creates for things like lambdas that can just never be freed. So all in-all, it did save some space, but not a significant amount, and not enough to really make a big difference.

Can you run the whole dfdl-schemas 'sbt test' without running out of memory now?

Unfortunately no. I pretty quickly saw my swap getting used, so I think maybe I just don't have enough free memory on my system for what I've given to SBT. I might need to play around with things a bit.
That said, I'm not entirely convinced these leaks are the main culprit (thought it's good to fix).
One issue is I think a few schemas still use the DFDLTestSuite are they are never set to null, so those caches will still never be freed. I don't think there's enough that use that to matter.
I suspect the main issue is that our dfdl-schemas regression is just too parallel happy and tries to do too much at once. Even if we are freeing caches, when we load large tdml files, compiling them all, comparing results, etc. many at the same time, it just requires a lot of memory--we just can't do that much work at once.
We might also need to look at what other things the TDML Runner is "caching". One example, the document bits is stored as a lazy val in the Document. Even though it's lazy so we won't created until it's needed, once it's created, it's not going to be freed until the entire DFDLTestSuite goes away. We possibly do the same thing for the expected. So I think there's still some thought that needs to be put into what the TDML runner stores as a val, and what it just recreates every time a test is run. This way we only use memory for the life of a test rather than the life of the test suite.

Does it make sense to move Sonarcloud back to it's own file? Our workflow pretty much always uses forks (except for the dependabot things which we can't change) so pull requests are rarely going to run for pull requests.

It doesn't really make sense to move Sonar back to sonarcloud.yml.  The Sonar scanner needs to see the fully built source tree and we need to run tests for coverage information anyway, so we do that only once in main.yml and then call the Sonar scanner as an afterthought if appropriate.  We just have to avoid running the Sonar scanner when we don't have secrets.SONAR_TOKEN available.  I'll look for a way to make the if condition more concise later, but we're still benefitting from not having to duplicate anything between main.yml and sonarcloud.yml now.

Also, this PR branched before the sonarcloud changes were merged. So this PR shouldn't even have updated main.yml? Do github actions the main.yml from the master branch now and not from the PR?

The workflow definitely used the updated main.yml.  I believe GitHub must have merged the PR's changes into the master branch when checking out the source code for the workflow.  That's why secrets.GITHUB_TOKEN still works, but not secrets.SONAR_TOKEN.

I think I've addressed all comments, including the SonarCloud scan updates. I've made it slightly less verbose and more directly tied to the specific matrix combination that it should run as. I think this way if we ever update the matrix, it will be more obvious that we also need to update the sonarcloud matrix thing.


Please call it alpha not beta - [Windows Subsystem for Linux (beta)]

Yes, this is a test version inside a developer channel, but reading this bug list tends me to name it alpha, not beta.
sshd, /dev/null, top, |, symbolic links, etc...

Microsoft use different terms, for me it would be pre-alpha, but for em it is beta.
That's the editor choice.

Hardly a bug but rather an argument on semantics, but I'll comment anyway....
I disagree. Alpha is generally recognized as "very unstable and/or feature-incomplete", whereas beta is generally regarded as "mostly feature-complete but will be buggy". Even considering the list of known issues, I'd say it's still much more of a beta than an alpha.

I agree, for Beta fits best. The subsystem is there but it's not perfect.

Personally, I like the phrase "Developer Preview" or something like that.
That said, closing this from an issue perspective.


Retry connection if CCU is not available during startup of Home Assistant

I have already seen the issue regarding a reconnect if the CCU is restarted and Home Assistant is not.
But the reconnect service does not work when the CCU was not available during startup of Home Assistant:
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic.connection] HMConnection: Creating server object
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] ServerThread.__init__
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] __init__: Creating proxies
2018-06-29 10:00:54 INFO (SyncWorker_17) [pyhomematic._hm] Creating proxy ip. Connecting to http://<IP_ADDRESS>:2010
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] LockingServerProxy.__init__: Getting local ip
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] LockingServerProxy.__init__: Got local ip <IP_ADDRESS>
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] RPCFunctions.__init__
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] RPCFunctions.__init__: iterating proxy = homeassistant-ip
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] RPCFunctions.__init__: devices_raw = []
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] RPCFunctions.createDeviceObjects: iterating interface_id = ip
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] ServerThread.__init__: Setting up server
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] ServerThread.__init__: Registering RPC functions
2018-06-29 10:00:54 INFO (Thread-3) [pyhomematic._hm] Starting server at http://<IP_ADDRESS>:45831
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] ServerThread.proxyInit: init('http://<IP_ADDRESS>:45831', 'homeassistant-ip')
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] proxyInit: Exception: [Errno 111] Connection refused
2018-06-29 10:00:54 WARNING (SyncWorker_17) [pyhomematic._hm] Failed to initialize proxy
2018-06-29 10:00:54 CRITICAL (SyncWorker_17) [pyhomematic.connection] Failed to start server
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic.connection]
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] ServerThread.stop: init('http://<IP_ADDRESS>:45831')
2018-06-29 10:00:54 DEBUG (SyncWorker_17) [pyhomematic._hm] proxyInit: Exception: [Errno 111] Connection refused
2018-06-29 10:00:54 WARNING (SyncWorker_17) [pyhomematic._hm] Failed to de-initialize proxy
2018-06-29 10:00:54 ERROR (MainThread) [homeassistant.setup] Error during setup of component homematic
Traceback (most recent call last):
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 547, in proxyInit
    (callbackip, callbackport), interface_id)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1112, in __call__
    return self.__send(self.__name, args)
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 421, in __request
    return parent._ServerProxy__request(self, *args, **kwargs)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1452, in __request
    verbose=self.__verbose
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1154, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1166, in single_request
    http_conn = self.send_request(host, handler, request_body, verbose)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1279, in send_request
    self.send_content(connection, request_body)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1309, in send_content
    connection.endheaders(request_body)
  File "/usr/local/lib/python3.6/http/client.py", line 1234, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/lib/python3.6/http/client.py", line 1026, in _send_output
    self.send(msg)
  File "/usr/local/lib/python3.6/http/client.py", line 964, in send
    self.connect()
  File "/usr/local/lib/python3.6/http/client.py", line 936, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/local/lib/python3.6/socket.py", line 724, in create_connection
    raise err
  File "/usr/local/lib/python3.6/socket.py", line 713, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/connection.py", line 74, in start
    self._server.proxyInit()
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 552, in proxyInit
    raise Exception
Exception

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 568, in stop
    proxy.init(remote)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1112, in __call__
    return self.__send(self.__name, args)
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 421, in __request
    return parent._ServerProxy__request(self, *args, **kwargs)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1452, in __request
    verbose=self.__verbose
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1154, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1166, in single_request
    http_conn = self.send_request(host, handler, request_body, verbose)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1279, in send_request
    self.send_content(connection, request_body)
  File "/usr/local/lib/python3.6/xmlrpc/client.py", line 1309, in send_content
    connection.endheaders(request_body)
  File "/usr/local/lib/python3.6/http/client.py", line 1234, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/lib/python3.6/http/client.py", line 1026, in _send_output
    self.send(msg)
  File "/usr/local/lib/python3.6/http/client.py", line 964, in send
    self.connect()
  File "/usr/local/lib/python3.6/http/client.py", line 936, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/local/lib/python3.6/socket.py", line 724, in create_connection
    raise err
  File "/usr/local/lib/python3.6/socket.py", line 713, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/homeassistant/setup.py", line 146, in _async_setup_component
    component.setup, hass, processed_config)  # type: ignore
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/homematic/__init__.py", line 333, in setup
    homematic.start()
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/connection.py", line 79, in start
    self._server.stop()
  File "/config/deps/lib/python3.6/site-packages/pyhomematic/_hm.py", line 574, in stop
    raise Exception
Exception

The hue component does this for example:
https://github.com/home-assistant/home-assistant/blob/26590e244ced1b67792bac8fdd5fc81ac446dba1/homeassistant/components/hue/bridge.py#L60
Could this be implemented in pyhomematic or is that something the Home Assistant component should do?

This would be done in Home Assistant, pretty much the same way like the Hue component does it.

Okay, but this exceeds my python and asyncio skills, unfortunately.
Would this be an extensive rewrite of the component or is that more of a smaller change?

I acutally think this isn't even worth the effort. It won't be often that you restart HASS and the CCU at the same time. The only case I can think of is with a power outage and the CCU takes longer to reboot than the HASS machine.

The use case is there when running CCU and HASS in docker containers and you restart both (docker upgrade, server reboot). Even when first setting things up, wouldn't it be better to catch the Exception that the CCU is not reachable and not put the trace into the HASS log?

The exception is raised so HASS can react on it. If it wasn't raised, HASS would just passthrough the log and think everything is ok. We have an issue about custom exceptions, which would be pretty much what the hue component also raises. By controlling the exception type we could make HASS react better to whatever happens. It just hasn't been a priority until now since it doesn't matter in most setups. Of course it can be done somehow. But even with your setup I'm sure there's actually a way of telling Docker in which order containers should be started if they depend on each other. After all the problem is not HASS/pyhomematic. It's Docker that starts the containers with a timing that doesn't meet the requirements of HASS. Making HASS take care of such Docker-Problems doesn't fix the root-issue.

Unfortunately, there are no dependencies in Docker, you can't set up something as in init.d or systemd.
I have tried some hacks in init.py of the HASS homematic component, but catching the Exception there is not enough because pyhomematic reacts on the Exception and stops the proxies.
I have now a working state that does exactly what I need (https://github.com/danielperna84/pyhomematic/blob/649224c9b4ae4f75d2b807c2d706bcdc22f341fa/pyhomematic/_hm.py#L547):
`
tries = 0
        while True:
            try:
                proxy.init("http://%s:%i" %
                           (callbackip, callbackport), interface_id)
                LOG.info("Proxy initialized")
                break
            except Exception as err:
                retry_delay = 2 ** (tries + 1)
                tries += 1
                LOG.error("Error connecting to the CCU. Retrying "
                             "in %d seconds", retry_delay)

                time.sleep(retry_delay)

                continue

`
This will hold HASS startup for as long as the CCU comes back online, which is exactly what the zwave component does as well. When it cannot detect the USB stick, it cannot setup the component and HASS won't continue to start.
Waiting for the CCU to come online before setting up entities is also helpful if automations etc depend on it.

Does the zwave component have some sort of maxtries option? I understand why this can be important. But I don't thinks it is good to have a component that would block everything for an unlimited time. Waiting for 1-2 minutes could be acceptable. But personally I have devices from very different vendors. And I would definitely prefer a running subset of automations instead of everything to be dead just because the CCU got stuck. Imagine people having their home security system with Door-Sensors via the Xiaomi Gateway. It would be bad if those wouldn't do their job just because the HomeMatic thermostats don't work because the CCU has a problem.

I have put some thought into this. Starting with 0.1.46 there's no more exception HASS could work with. The result of this is, that the pyhomematic RPC-Server (and the Proxy-object that talks to the CCU) will be started no matter what.
I haven't tested it, but if I'm not mistaken it will be possible to startup HASS now without the connected CCU. But because of the existing server and the proxy-object being available, the homematic.reconnect service in HASS should be able to load the entities even after the HASS startup.
In the long run I thought of some architectural changes. The component should always just start the server, and then handle the Proxy-init based on the configuration itself instead of letting pyhomematic do all this. Right now pyhomematic does everything. By dividing this up into multiple independent tasks, we could eventually end up with an additional service like homematic.add_interface, where we could add a CCU even at runtime. And of course this would also enable us to add the logic to HASS what to do when a host is not up yet during startup.
I'll have to keep thinking about this. Just wanted to share the idea I currently have.

hahomematic includes the ability to detect disconnected clients, as shown here in the example.
Apart from that, the (new) Home Assistant integration has to handle the general connectivity-problems. This is required anyways for integrations that aim to receive the GOLD-status.
Closing this issue, as it will be handled in the new integration eventually.


i18n(es): update netlify.md

What kind of changes does this PR include?

New or updated content
Translated content

Description

Updates deploy/netlify.md

LGTM! ✅


Other datasets?

Thank you very much for your work and making the codebase public; it is very inspiring :)
I am planning to implement something similar and had the following questions:

Is there a specific reason why MATCH was not tested on other popular hierarchical datasets like WordOfSciences, NYTimes, or RCV1-V2?
Also, the readme says that experiments were done on NVIDIA GTX 1080. Can you please share the time it took for training?

Thank you very much for your interest in our work!

MATCH is specifically designed for metadata-aware text classification, which means documents in the dataset should have some metadata information. As far as we know, many popular datasets such as NYTimes and RCV1/2 do not have rich metadata, so we use two academic paper datasets instead. If your dataset has metadata information other than venue/author/reference (e.g., you have a product review dataset with the reviewer/product id), please refer to https://github.com/yuzhimanhua/MATCH#running-on-new-datasets about how to use our code for your dataset. If your dataset does not have any metadata information, I would recommend some other repositories:
https://github.com/yourh/AttentionXML
http://manikvarma.org/downloads/XC/XMLRepository.html

If you use two NVIDIA GTX 1080, the training time should be 15-20 hours.

Okay makes sense ; thank you very much!


⚠ ESPN has degraded performance

In 6f2c39c, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 3759 ms

Resolved: ESPN performance has improved in 699899b.


How to tweak rendered pictures?

Is there a way to set the min / max height of rendered pictures? Almost all mine end of getting rendered very tiny.

Any updates? People using my app are starting to complain about tiny picture sizes.

You can create a custom ImageLoader to be used inside MarkdownText.
https://github.com/jeziellago/compose-markdown/blob/d0a4c4eb6fcfc87611b9f8cda598d0f581387f40/markdowntext/src/main/java/dev/jeziellago/compose/markdowntext/MarkdownText.kt#L47

Thanks! I'll try this out once you get #25 working again.

A custom coil image loader doesn't seem to have the options I need... specifically I need two things.
The ability to scale a picture, I'd like it to fill my item width. This is done in coil like:
AsyncImage(
  model = ...
  contentScale = ContentScale.FillWidth,

I'd also like the ability to get a callback when the image is clicked, so I can do an action with it (such as loading it in an external browser)

There is a simple way to get this result with HTML:

My users are just doing proper markdown images, ie ![imglink](url) .


Video Recording Not Stopping

...or possibly not really starting. Pressing FAB to stop has no effect on FAB, no file shows up. Setting duration limit does not help. Reproducible on Nexus 5, Android 5.2 or 6.0 Final(?) Preview.

No longer reproducible.

Reproduced on Nexus 5 running Android 6.0.

Also reproduced on a Nexus 4 running Android 5.1, but not on a Galaxy Nexus running Android 4.3. State of the force-classic switch has no effect.

I'm not sure if this is the same issue, but once started the video can't be stopped on a Samsung SGH-I337M.
This is the exception generated when he stop button is clicked.
10-16 12:06:04.267: W/MessageQueue(31006): Handler (android.os.Handler) {1bb94f4b} sending message to a Handler on a dead thread
10-16 12:06:04.267: W/MessageQueue(31006): java.lang.IllegalStateException: Handler (android.os.Handler) {1bb94f4b} sending message to a Handler on a dead thread
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.os.MessageQueue.enqueueMessage(MessageQueue.java:325)
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.os.Handler.enqueueMessage(Handler.java:631)
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.os.Handler.sendMessageAtFrontOfQueue(Handler.java:623)
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.hardware.camera2.legacy.RequestThreadManager.quit(RequestThreadManager.java:941)
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.hardware.camera2.legacy.LegacyCameraDevice.close(LegacyCameraDevice.java:444)
10-16 12:06:04.267: W/MessageQueue(31006): 	at android.hardware.camera2.legacy.LegacyCameraDevice.finalize(LegacyCameraDevice.java:468)
10-16 12:06:04.267: W/MessageQueue(31006): 	at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:194)
10-16 12:06:04.267: W/MessageQueue(31006): 	at java.lang.Daemons$FinalizerDaemon.run(Daemons.java:177)
10-16 12:06:04.267: W/MessageQueue(31006): 	at java.lang.Thread.run(Thread.java:818)

@bpappin What version of Android is your SGH-I337M running? If it's 4.4 or earlier, you have a separate problem.

For Android 5.0 and higher, until issue #57 is addressed, we have to use the classic camera engine, and I misplaced my code to force Android 5.0+ devices to use that. This will be addressed in this weekend's update.

Addressed in v0.3.2.


Bring API docs together with source code

Currently our API docs are managed and hosted separately from this repo. E.g., Ag3 API docs are here.
It would be easier to maintain and keep up to date if the API docs were together with the source code.
Propose to bring API docs into this repo as a standard sphinx documentation site.
We'd then need to figure out the best way to automatically build and publish the API docs.

Options for hosting the docs:

RTFD
github pages

I personally quite like the idea of using github pages, as publishing can be set up with github actions.

Another question is whether we want versioned documentation (i.e., different versions of the documentation corresponding to different releases of the package can be viewed.)
This is supported by RTFD.
It can also be done with sphinx and self-publishing on github pages, but requires a specific sphinx theme (pydata-sphinx-theme and some configuration IIUC (see version switcher dropdowns).

Also I quite like how the numpy docs have a page with a listing of functions (e.g., array creation routines) as well as individual pages for each function (e.g., numpy.empty).
Looks like this is achieved using the sphinx autosummary extension. E.g., here is the source code for the array creation routines page. The individual pages for each function are then automatically generated.

I suppose we can close this off as soon as everything appears to be working as expected, i.e. soon after the next release is tagged, which I expect will be towards the end of this week. I'll also remove the proof-of-concept repo, which I've kept alive in case we need to debug or re-engineer.


⚠ Bofrost.lu has degraded performance

In f6a2d20, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1121 ms

Resolved: Bofrost.lu performance has improved in 175d021 after 6 minutes.