Ruby: Disambiguate mock credentials classes in tests.

Fixes #1643

Codecov Report

Merging #1644 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1644      +/-   ##
============================================
- Coverage     85.55%   85.55%   -0.01%
- Complexity     4789     4790       +1
============================================
  Files           458      458
  Lines         19187    19190       +3
  Branches       2062     2062
============================================
+ Hits          16416    16418       +2
- Misses         2143     2144       +1
  Partials        628      628

Impacted Files
Coverage Δ
Complexity Δ

...codegen/viewmodel/testing/ClientTestClassView.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...m/google/api/codegen/transformer/SurfaceNamer.java
76.37% <0%> (-0.21%)
202 <0> (ø)

...nsformer/ruby/RubyGapicSurfaceTestTransformer.java
100% <100%> (ø)
24 <0> (ø)
:arrow_down:

...api/codegen/transformer/ruby/RubySurfaceNamer.java
96.42% <100%> (+0.02%)
64 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0adc72a...548fb8d. Read the comment docs.


GHA check gas for 32 tx per block sometimes failing

Test check gas for 32 transaction per block sometimes failing with Error: socket hang up during the test


Remove the 10-block range limit for during sandblasting.

The improved performance provided by shardtree is sufficient to allow 100-block scan ranges throughout the sandblasted range, and limiting to 10 blocks results in significant overhead.
A future release will switch to an adaptive strategy which can dynamically adjust download and scan range sizes based upon observed output counts and scanning times to provide consistent throughput.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[ ] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

🎉


I believe the 'z' is a Typo after the '>' character as I receive the following error in AutoPkg

https://github.com/autopkg/bradclare-recipes/blob/3b7e4d97f633c088f0b076467861282510bc5866/RingCentral/RingCentralPhone.pkg.recipe#L76
WARNING: plist error for /Users/admin/Library/AutoPkg/RecipeRepos/com.github.autopkg.bradclare-recipes/RingCentral/RingCentralPhone.pkg.recipe: Error Domain=NSCocoaErrorDomain Code=3840 "Encountered unexpected character z on line 76 while looking for open tag" UserInfo={NSDebugDescription=Encountered unexpected character z on line 76 while looking for open tag, kCFPropertyListOldStyleParsingError=Error Domain=NSCocoaErrorDomain Code=3840 "Malformed data byte group at line 1; invalid hex" UserInfo={NSDebugDescription=Malformed data byte group at line 1; invalid hex}}
Please let me know if I am in error.
Removing the 'z' from my local copy resolves the error.

Cc @wegotoeleven, who last modified that recipe.


Added in 2 other tables with akalink support

Incase someone else wants to use other tables. The CottonFox uses the akalink shader as there is not a fur shader variant of the shader and would be nice.

I tested out the tables, I think I can make a variant of the shader I made with some vertex offset options. It it by no means close to what CottenFox had made, but it is better than it is currently. I am still developing it so I may be better than I am saying right now

I got it close with CottenFox, but yeah shader wise, I didn't attempt to try since shaders are out of my expertise.


Automated cherry pick of #5633: Check deletion event matches ClusterSet before Multi-cluster

Cherry pick of #5633 on release-1.14.
#5633: Check deletion event matches ClusterSet before Multi-cluster
For details on the cherry pick process, see the cherry pick requests page.

/test-multicluster-e2e
/skip-all


Account for mutagen.File returning None for unreadable files

It seems to be possible for a file to be detected as a music file by gmusicapi-wrapper but for mutagen to detect it as a non music file. This results in mutagen.File returning None which eventually is treated as a dictionary, causing an unhandled exception.
This change checks the return value of mutagen.File and handles None similarly to how exceptions are currently handled (filename is logged and added to the filtered files list).

Thanks for the contribution.
Can you post a file (or a few) that mutagen.File returns None for? I'd like to get a better idea of what is going on to get that result and see if another library handles them.
The solution will likely be different than what you've proposed; I don't think I'd want to pass along a file whose type can't be detected properly. And, if I did, I'd want it to be an option defaulting to False.

Sure. I did some further investigation and it came to my attention that the file... was literally empty. So to reproduce, just create an empty file and give it a supported extension.
Seems like mutagen does it's own file type detection, which may (as in this case) conflict with the filetype detection that gmusicapi-wrapper does (based on extension, in get_supported_filepaths). http://mutagen.readthedocs.io/en/latest/api/base.html#mutagen.File

The checking in get_supported_filepaths is a quick out. The mutagen.File call here is for checking validity.
I can't reproduce getting None returned from mutagen.File with an empty file created using touch test.mp3. It properly throws a mutagen.mp3.HeaderNotFoundError which is a subclass of mutagen.MutagenError and is properly caught by the except clause. So, please post a file that you know to cause this or possibly more details that might be pertinent.

Just from quickly testing the other supported extensions, it looks like Ogg and MP4 don't throw an exception. This seems like something that should happen with mutagen.


setImageAlpha() is not working

I'm programatically applying alpha values to the image like this:
mProfilePicture.setImageAlpha(100);
But it doesn't seem to do anything.
I've tried using the same line of code on a regular ImageView and it works just fine, but when applied to the CircleImageView it doesn't work :(
Any suggestions/alternatives?

Not a fix but a workaround -- I ended up putting the CircleImageView inside of a RelativeLayout and changed the opacity by doing this:
mRelativeLayout.setAlpha(0.5f);

Alpha is currently not supported - I might add it in the future though.

I have used @dsemelianov's workaround for now by calling .setAlpha on a dummy container view.
Would be nice to have this, though.

Alpha support has been merged in 7ad4632 and will be available with the next release.


Pr for failure group and tie-breaker node

Pr for failure group and tie-breaker node

@sasikeda As a part of IBM Catalog tile, we are making CES based deployment as a default deployment model so it can be easy for HPC customer to integrate with other HPC solutions. Hence we need to make the compute cluster (GUI username, Password) optional.
Also, we are introducing of tie breaker node and 3 FG based deployment for single zone.
Let me know if you have any concerns.
cc @mamuthiah


Notebook's pipeline should be collapsable

The pipeline steps should be collapsable to maximize space. When clicking a selected block, it should deselect (implemented) and also collapse the pipeline and show only an "expand" icon like "v". Ideally there should be an animation when the pipeline collapses to indicate the pipeline is still available.

Update from meeting: also wanted for hal9.com; not notebook-specific anymore

Animation not requested anymore, so this is complete


which one of ASL functions in the task of detection should be used?

In the task of ATSS detection ,  should we select which one of ASL  functions, ASLsinglelabel or AsymmetricLoss？， there are some problems when I directly use the AsymmetricLoss.

class AsymmetricLoss(nn.Module)
this is the multi-label variant.
detection is a multi-label problem, with extra localization data

start from the original focal loss, with exactly the same alpha as theirs (i thought it was 0.7, maybe i was wrong)
reproduce their results
introduce asymmetry

Ok, thank you very much.  if I have  better result,  I will show you my fixed things and configs.
@.***
From: mrT23
Date: 2021-10-30 14:07
To: Alibaba-MIIL/ASL
CC: y78h11b09; Mention
Subject: Re: [Alibaba-MIIL/ASL] which one of ASL functions in the task of detection should be used? (#70)
start from the original focal loss, with exactly the same alpha as theirs (i thought it was 0.7, maybe i was wrong)
reproduce their results
introduce asymmetry
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Add resources setting to kube-rbac-proxy

I realised that the version 1.1X del code , not helm, is wrong. The release that is running is the 1.0.24
I need to remove this code and merge 1.0.24 to master.


Do full inference test against test vectors for test_* models

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


add a debug command for UPAKs

This command shows it should not be a problem to reset users and check UPAKs. I'm pretty sure the case @mmaxim  found was due to a bad cached object from August
If we ever do see a problem, this is a useful debugging command to try; you can also query a particular KID to make sure it shows up in the previous incarnations

paving over CI failure, which doesn't look related


Inquiry

Where is the bundled code diff.js  as in the example
<script src="../dist/diff.js"></script>
if I just want to source the library and license in my project?

If you've installed the library with npm, you can find the standalone script in node_modules/diff/dist/diff.js.


[Feature Request] linux binaries

For those not using flatpack/snap/etc (i.e. most) it would be nice to have an alternative installation mechanism.
You can't support dozens of package managers, so even just the binaries (deb / rpm) in the releases page would be great. There are already binaries for windows/macos, so would be appreciated for linux too.
Thanks for continuing gitahead - I look forward to trying this out.

dublicate https://github.com/Murmele/Gittyup/issues/198


Clean exampleContracts folder

Fixes #836
What was wrong?
Currently, most of the contracts inside exampleContracts are used for tests. This folder should contain only useful examples for the user.
How was it fixed?

Extracted .sol contracts used in tests from exampleContract folder to a new folder tests/compilation
Renamed yarn script test:examples to test:compilation
Expected test results for contracts in tests/compilation are defined in tests/testing.ts (Default: 'Success')
All contracts in exampleContracts must successfully compile wit both Warp and Starknet-compile. (Tested during tests:compilation)

For contributors
For an important feature, you can write a simple solidity contract in exampleContract to show the usage of this feature.
For all specific test cases, you can add any contracts under tests/compilation and specify the result expectations in the expectedResults map (tests/testing.ts ).

Hi @julio4, great work. We detected some issues with dependency versions of cairo-lang that, as you see, make our tests to fail. If you merge develop into this branch it should be fixed.

Hey @julio4! Amazing. Thank you for cleaning this up a bit. There are many more interesting contracts that should be preserved and cleaned up in the examples folder.

Address sizes require different casts. It would be nice to keep a single file demonstrating and commenting on each case
asserts and reverts have slightly different semantics (the argument must be a literal string in all cases). A commented-out example which doesn't work would be great here
the unsupported cases should be preserved (with comments explaining what isn't supported)
dai is a cool one
include tests/behaviour/contracts/cairoStubs/proxy.sol, a cool example of proxies.

@JorikSchellekens
Maybe I can open a separate issue to clean and add more interesting example contracts ?
Additionally, all tests in the example folder are tested and must compile. If we add unsupported cases, should we move them to a dedicated unsupported folder, leave them as comments, or perhaps disable testing for contracts in this example folder? Let me know your thoughts.

Hey , Julio thank you for this PR 🙌. But unfortunately I have to close this PR, since I have added some changes in the PR: https://github.com/NethermindEth/warp/pull/1002 inspired from this PR to the cairo-1.0 branch , and eventually cairo-1.0 branch will be merged to the develop branch .
If you have some questions then you ask here. Are you okay with closing this PR?
Anyway thanks for your contribution !  🎉 Looking forward to see more contributions towards this repo from you 😊

@rjnrohit Ok I understand.
Can you please share what I could have improved so I can make a better contribution next time ?

@rjnrohit Ok I understand.
Can you please share what I could have improved so I can make a better contribution next time ?

What you have done is brilliant ! I just needed this changes quickly added to cairo-1.0 branch with cairo1 compatibility. So, I followed some of your idea.
For the contribution specifically, as long as you're following this guide :https://github.com/NethermindEth/warp/blob/develop/CONTRIBUTING.md, it should be good for us.
We're eagerly seeking external peoples contributions, so don't hesitate to open a PR. It'll anyway makes WARP better.

@rjnrohit Ok I understand.
Can you please share what I could have improved so I can make a better contribution next time ?

What you have done is brilliant ! I just needed this changes quickly added to cairo-1.0 branch with cairo1 compatibility. So, I followed some of your idea.
For the contribution specifically, as long as you're following this guide :https://github.com/NethermindEth/warp/blob/develop/CONTRIBUTING.md, it should be good for us.
We're eagerly seeking external peoples contributions, so don't hesitate to open a PR. It'll anyway makes WARP better.

Understood! Glad I could help, and I’m looking forward to contribute again!


requested an invalid redirect URL

THIS ISSUER TRACKER IS NO LONGER USED!
DON'T CREATE ANY NEW ISSUES AS THEY WILL BE CLOSED IMMEDIATELY AS INVALID!
QUESTIONS SHOULD GO TO THE MAILINGLIST AT<EMAIL_ADDRESS>

thanks for bringing this up


Adding skip artifact download

I'm working in a workflow which downloads the already build documentation from another workflow:
https://github.com/pyansys/pymapdl/pull/1707
Because I download the artifact from other workflow, the default actions/download-artifact does not work. Hence I would like to skip it in the current pyansys action.
Other option is for me to just copy this workflow but given the complexity of the latter steps, I would like to use this action as much as I can.

There is one concern:
The doc-artifact-name does not include file extension. I believe the actions/download-artifact does unzip the file. Then we need to add the zip extension at the run step and the unzip command.

From the changes you made in https://github.com/pyansys/pymapdl/pull/1707, I do not see any reason behind implementing this.
The pyansys/actions allow to download the artifact based on their name. If you need to point to a particular YML file, let us add that as an input rather than skipping the artifact download, @germa89.

From the changes you made in pyansys/pymapdl#1707, I do not see any reason behind implementing this.
The pyansys/actions allow to download the artifact based on their name. If you need to point to a particular YML file, let us add that as an input rather than skipping the artifact download, @germa89.

I think that is even better.
I will change this accordingly.

Closing because it wont be implemented.


It shouldn't be necessary to name the migrations alphabetically

For LLM I got into a habit of doing this:
@migration()
def m001_create_table(db):
    # db is a sqlite-utils Database instance
    db["creatures"].create(
        {"id": int, "name": str, "species": str},
        pk="id"
    )

@migration()
def m002_add_weight(db):
    # db is a sqlite-utils Database instance
    db["creatures"].add_column("weight", float)

Because I was using the function names as the primary key in the database and I wanted them to naturally be displayed in the correct order in Datasette.
I can do better than that.

This will likely require a schema change. That means sqlite_migrate needs to start using migrations to manage its own _sqlite_migrations table.

I'm really torn on this one. On the one hand, having sqlite-migrate manage its own migrations using itself is a really nice example of eating-own-dogfood, and a good demonstration of why the tool is useful.
But... I really don't like the idea that EVERY database in the world that uses this tool ends up with a row in the _sqlite_migrations table by default just for installing the library! That's a whole lot of bytes, and it's also a bit ugly for users of the tool who end up seeing an internal implementation detail every time they go to check their own migrations.
On that basis, I'm going to do this the non-SQLite-migrate way: I'll have ensure_migrations_table() apply the change if the column is missing. It has one change like that in there already!
https://github.com/simonw/sqlite-migrate/blob/613ecd5c4aa8493525879d2db7363fa5bfbe4ffb/sqlite_migrate/__init__.py#L89-L105

Does this need a schema change? I'm already recording the time the migration was applied. Maybe the logic is to find the most recently applied migration, then look at the list of migrations and apply any that follow that.
What should happen if you edit the source code and add a new migration function that's positioned earlier in the code than it should be (hence before another migration the user may have applied)?
You shouldn't do that, but what would happen if you did? Some options:

Throw a hard error
Show a warning message, skip that migration and continue
Show a warning message, apply that migration (though will it likely break if subsequent migrations depend on it?) and continue
Attempt to apply that migration, roll back if it fails
Threw an error but provide a CLI  mechanism that can be used to manually apply it

That last option may be the best thing here. Having the ability to apply migrations out-of-order would at least allow users to perform open heart surgery on their database schema if they really need to.

I'm going with the error mechanism: if it finds a migration that is previous in the sequence to one it has already applied it will halt with an error before running anything at all.

So to fix this I am going to need to add a column that records the order they were applied and that is part of the primary key.
So the new primary key would be ("migration_set", "sort", "name").
order is a reserved keyword. sort isn't, but I think I like sequence better.

I got a version of this working with sequence as the second column in the primary key:

The sequence integers are jumbled because the primary key sorts by migration_set first - grouping by migration set but not making it easy to see the order they were applied in.
Sorting by applied_at confirms that the sequence order is also the order they were applied:

Here's what it looks like with sequence in the first column instead:

But... if I'm doing that, why not just use an auto-incrementing id integer primary key instead?

I designed the primary key like that to help prevent the same migration (with the same name in the same migration set) from being applied more than once.
I could still enforce that with a unique key constraint even if that's no longer the primary key for the table.

Bonus: when I write the code to port existing tables to the new structure I could use their rowid as the value for the new id column.

One thing left to do: the README is out of date now with this old example: https://github.com/simonw/sqlite-migrate/blob/5ed0d50924efbf6dd39c07d0aa017ef3e0f1cfec/README.md#L141-L157

I'm going to test this with a fresh install of llm to make sure it doesn't break.
Although... here's an interesting callenge with LLM: I frequently run many different copies of it against the same llm.db database stashed away in my ~/Library/Application Support folder.
It's perfectly possible I'll run an LLM upgraded instance which will upgrade the database... but then re-run an older version against the same DB in a way that will break things.


Gonzales 3.2 - Fix space-after-bang rule

Fixes the space-after-bang rule to work with the latest version of gonzales.
Note: Travis will fail as there are broken tests on gonzales-3-develop branch. Verify by checking space-after-bang rule test success.
Fix was necessary as gonzales now doesn't break up ! default into separate nodes and instead considers it just one string node of ! default.
Also adds support global and optional.
Closes #305
Closes #56
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

As far as I'm aware \s is a special regex character that catches all white space (spaces, tabs, newlines etc) so it would work with Windows and Linux too.

Just a note - Now that https://github.com/tonyganch/gonzales-pe/issues/148 has been fixed support for global and optional (sass) has been fixed and pushed.

:


Pointer in Issue.Labels missing?

Almost everywhere pointers are used, but not here. The type is []Label. The similar struct for PRs has also a type of []*Label.
Is this intentional?

@gmlewis what about this issue, how can we proceed?

Actually, in light of #180 and all the breaking API changes we've been making lately, I think I will go ahead and fix this one myself.


Ask for API version when user associates pull request

Requirement:  SDK stakeholders have asked for the API Spec version data.  There is not a way to programmatically determine and validate the API version.  Update the API readiness milestone to ask the user to enter the API version and update the API Spec work item field API Spec version with the input by the user.
Proposed UI changes:

Also in the Release Planner app update the UI with:
API details - Add new field named "API version" with the value of the API version as indicated by the user.

I have looked at few TypeSpec spec projects and I don't see any easy way to auto detect API version. So for now, I think we can just ask user to provide API-version.

I have looked at few TypeSpec spec projects and I don't see any easy way to auto detect API version. So for now, I think we can just ask user to provide API-version.

Thanks for investigating! For now user input that is self-attested is better than no data.
We should open an issue and put in backlog. Perhaps we raise requirement to TypeSpec. API version is core metadata.

We may not need any user input for API version based on the discussion about TypeSpec based codegen. Let's revisit this change request and decide the plan accordingly.

We may not need any user input for API version based on the discussion about TypeSpec based codegen. Let's revisit this change request and decide the plan accordingly.

The requirement to map API version to SDK version is also applicable for SDKs generated using OpenAPI.  Should we have 2 issues - one for TypeSpec and one for OpenAPI?


FIX: maxfilter channel names extra space bug

Hi Eric,
Please review my changes to address extra space bug between old and new fif files.
Two files are changed, maxwell.py and test_maxwell.py as you suggested.

actually I tried running clean on both, but needs to be done much lower as bad channels are in other format as well as proj

And while you're at it, make Travis CI happy, too.

Thanks Erix and Alex, I learned a lot.

Current coverage is 87.40% (diff: 100%)

No coverage report found for master at a9723e8.

Powered by Codecov. Last update a9723e8...2336d88

Two last little things -- once the code appears good to go from your end, by convention we prepend (or replace FIX/ENH) with MRG in the title to make it clear it's ready to go. This prevents us from needing to ask the next question, which "is this ready for review/merge from your end?" But from our exchange and the scope of the change I think it's fairly clear that it is, so I would, except the truly last thing is to add an entry to whats_new.rst. This would go under the BUG section. If you can add that, I can merge.


Adds OpenSSL and bcrypt to nifi image

During the init phase of NiFi containers two additional tools are required to prepare the envionment:

OpenSSL to prepare the keystore used for TLS
bcrypt which is used to encrypt the admin password from a secret and insert it into the config file

As bcrypt tool I have chosen https://github.com/bitnami/bcrypt-cli mostly because it does not require python, node or any other heavyweight dependency.
I contemplated writing our own tool in Rust which would have been something like 50 lines, but saw no real benefit in this.

While that would work for the init container and openssl, it wouldn't for the bcrypt tool, because this is needed inside of the actual container that runs NiFi, since any in-place changes to the Configs are ephemeral across container restarts.

closed in favor of #38


Bug: Hiscore not auto filling after update

Hiscore does not auto fill from cc or nearby players. Also does not allow double click to auto fill username.

You can double-click the search icon inside the text field and it will lookup your own player name.

Ah ok fair enough, am i missing something with the other issue of nearby players and in cc?

duplicate of #3202


NumberedRuneNames: add option to highlight hi level runes

Highlight hi level runes (more than Starting Level 20 default) with purple color.

Good idea, but I think this would be a better fit inside of Custom Item Colors, allowing a user to specify different colors for LR vs MR vs HR.

Good idea, but I think this would be a better fit inside of Custom Item Colors, allowing a user to specify different colors for LR vs MR vs HR.

Hmm... OK. I'll try to implement this based on the 'Custom Item Colors' mod.
@olegbl please answer to another question. In another modification, which changes a large number of files for the Russian language, I need to process a fairly large array of data and it is not convenient to specify them directly in the mod code. How can I read the JSON mod that lies locally?

You can probably include the JSON file with your mod, copy it to the output directory with D2RMM.copyFile, then read it with D2RMM.readJson.
In a future release of D2RMM, you'd also just be able to run import, but support for multi-file mods and TypeScript isn't quite ready to be released yet.

You can probably include the JSON file with your mod, copy it to the output directory with D2RMM.copyFile, then read it with D2RMM.readJson.
In a future release of D2RMM, you'd also just be able to run import, but support for multi-file mods and TypeScript isn't quite ready to be released yet.

It not works :(

Mod RuLocalizationFix encountered an error! Error: API.extractFile: Failed to open file in CASC storage (local\lng\strings\item-names.diffs.json): (CascLib Error Code: 2) at mod.js:28:29 at mod.js:43:3 at VM.runScript (D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:287:18) at D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:511:1
11:23:43

Sample code:
D2RMM.copyFile(
  'local', // <mod folder>\local
  'local', // <diablo 2 folder>\mods\D2RMM\D2RMM.mpq\data\local
  true // overwrite any conflicts
);

const itemNamesDiff = D2RMM.readJson('local\\lng\\strings\\item-names.diffs.json');

Good idea, but I think this would be a better fit inside of Custom Item Colors, allowing a user to specify different colors for LR vs MR vs HR.

In _profilehd.json it is possible to specify only 'RuneColor' without dividing into levels:

It not works :(

Ah, because it doesn't realize that file already exists since it wasn't explicitly written.
Try something like:
D2RMM.writeJson('local\\lng\\strings\\item-names.diffs.json', {});
D2RMM.copyFile(
  'local', // <mod folder>\local
  'local', // <diablo 2 folder>\mods\D2RMM\D2RMM.mpq\data\local
  true // overwrite any conflicts
);
const itemNamesDiff = D2RMM.readJson('local\\lng\\strings\\item-names.diffs.json');

In _profilehd.json it is possible to specify only 'RuneColor' without dividing into levels

Yup. You'd have to stick the coloring into the localization files to separate LR/MR/HR colors. Runes is one of the item types that this is possible for though.

It not works :(

Ah, because it doesn't realize that file already exists since it wasn't explicitly written, so it tries to read it from the game files instead of the generated mod files.
Try something like:

But again error:
2024-02-20T18:42:18.133Z,debug,Mod RuLocalizationFix installing...
2024-02-20T18:42:18.133Z,debug,BridgeAPI.writeFile {"inputPath":"d:\\Games\\Diablo II Resurrected\\mods\\D2RMM\\D2RMM.mpq\\data\\local\\lng\\strings\\item-names.diffs.json","isRelative":false}
2024-02-20T18:42:18.133Z,error,BridgeAPI.writeJson {}
2024-02-20T18:42:18.133Z,error,Mod RuLocalizationFix encountered an error!
Error: BridgeAPI.writeFile: Failed to write file: Error: ENOENT: no such file or directory, open 'd:\Games\Diablo II Resurrected\mods\D2RMM\D2RMM.mpq\data\local\lng\strings\item-names.diffs.json'
    at mod.js:1:7
    at mod.js:45:3
    at VM.runScript (D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:287:18)
    at D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:511:1

Ah. It's a little awkward to do right now (I'll need to think about a way to improve the API for this use case):
// copy the file so that it exists
D2RMM.copyFile(
  'local', // <mod folder>\local
  'local', // <diablo 2 folder>\mods\D2RMM\D2RMM.mpq\data\local
  true // overwrite any conflicts
);

// overwrite it so D2RMM knows it exists in mod output
D2RMM.writeJson('local\\lng\\strings\\item-names.diffs.json', {});

// copy the file again to update its contents
D2RMM.copyFile(
  'local', // <mod folder>\local
  'local', // <diablo 2 folder>\mods\D2RMM\D2RMM.mpq\data\local
  true // overwrite any conflicts
);

// read the file
const data = D2RMM.readJson('local\\lng\\strings\\item-names.diffs.json');
console.log(data);

I should probably make D2RMM.copyFile mark all copied files as having been extracted.

Ah. It's a little awkward to do right now (I'll need to think about a way to improve the API for this use case):

The same error:
2024-02-21T04:20:44.986Z,debug,Mod RuLocalizationFix installing...
2024-02-21T04:20:44.986Z,debug,BridgeAPI.writeFile {"inputPath":"d:\\Games\\Diablo II Resurrected\\mods\\D2RMM\\D2RMM.mpq\\data\\local\\lng\\strings\\item-names.diffs.json","isRelative":false}
2024-02-21T04:20:44.986Z,error,BridgeAPI.writeJson {}
2024-02-21T04:20:44.986Z,error,Mod RuLocalizationFix encountered an error!
Error: BridgeAPI.writeFile: Failed to write file: Error: ENOENT: no such file or directory, open 'd:\Games\Diablo II Resurrected\mods\D2RMM\D2RMM.mpq\data\local\lng\strings\item-names.diffs.json'
    at mod.js:1:7
    at mod.js:45:3
    at VM.runScript (D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:287:18)
    at D:\Downloads\Games\D2\D2RMM 1.5.0\resources\app.asar\node_modules\vm2\lib\mod.js:511:1

@olegbl "It's a life!!!' 😁 Everything worked. Thank you very much! If you specify a place where to finalize the 'D2RMM.CopyFile', I will try to do it in a separate PR.

@olegbl what about updates in this PR? Can they be applied to the current mod?

I think this PR can be abandoned in favor of #16 (yes, with the localization file changes).
Basically, what I said earlier:

I think this would be a better fit inside of Custom Item Colors, allowing a user to specify different colors for LR vs MR vs HR.

i.e. I don't think Numbered Rune Names is the right place for this feature.

Ah. It's a little awkward to do right now (I'll need to think about a way to improve the API for this use case)

https://github.com/olegbl/d2rmm/commit/ab994f02bae945fc5c30194dbdbc08441fe30205 fixes this issue.


selector separator newline

Testing #145604
It's a bit verbose to have or not and unnecessary IMO since it's a checkbox. I think it would be cleaner to have:

[x] separate selectors with a new line
[ ] separate selectors with a new line

Hi! Would I be able to work on this issue? I am contributing to a GitHub project for the first time and this seems like a good first issue for me.

@hannahcoles Thanks for offering help. In this case I'd rather fix this myself as it's a new feature that we are still polishing, and I want to make these changes today.


[MPMD-186] Fix Windows-Specific Constants

Fixed a defect that caused certain PMD Violations to not be excluded
correctly on non-Windows computers.
See https://issues.apache.org/jira/browse/MPMD-186

Patch applied, please close this PR.

Awesome, thanks!


Multiple downloads

Open the web GUI and run several different transformations and then click on the download buttons. This will open several download dialogs instead of simply the latest one and all different outputs from all previous transformations can be saved. There should only be the download of the current transformation shown.

Duplicate of #93


Adding elements to 'My Account' pages within Shopify

Hey buddy,
The apps nearly ready to go live, love the repo as it's saved me so much time. However I'm looking for a pointer from anyone who can help me.
Basically, once someone installs my app, I want to add text input fields in the 'My Account > Order' page.  Which will communicate with my app.
Is this possible? if so can you point me in the right direction?

You can use scripttag feature to inject scripts into the shop which can use JS to add those inputs.
Other than that, you would need to do theme mods.
Those are really the only two ways.


missing instructions on how to develop with this extension?!

Hi there,
Thanks a lot for this really impressive looking extension!  I say "impressive looking" rather than just "impressive" because unfortunately I have not been able to use it yet.  On the first attempt I immediately ran into #250.  So then I thought, OK maybe I can fix this myself, so I forked the repo, and cloned it locally.  What next though?  The README says that I can install from the provided build.zip:

Use src/extension/build/build.zip for manual installation in [Developer mode] (https://developer.chrome.com/extensions/faq#faq-dev-01). Turn on 'Allow access to file URLs' in extension details page if testing locally.

but as far as I can see, it doesn't give any explanation at all about how to build and test Reactime directly from the source.
I find this fairly astonishing, because clearly a great deal of effort has gone into trying to make it as easy as possible for developers to contribute.  Indeed, the Developer README starts by saying

Our mission at Reactime is to maintain and iterate constantly, but never at the expense of future developers.We know how hard it is to quickly get up to speed and onboard in a new codebase.So, here are some helpful pointers to help you hit the ground running. 🏃🏾💨

and then goes on to provide gloriously helpful descriptions of the internals, which is absolutely fantastic!
But unfortunately all this effort seems mostly neutered by two crucial but simple and easily fixed flaws:

There is no link from the main README to the developer README, so I would expect that most developers will simply not even notice it exists.
There is no explanation of how to test any modifications to the source.

The first point is trivially fixed, so I guess I will submit a PR.
The second point seems a lot less obvious, but I think I have found the solution:

If you have already installed Reactime from the Chrome Web Store, disable or uninstall it.
Run yarn to install all dependencies.  (I guessed this is preferred to yarn due to the presence of a yarn.lock file and the absence of a package-lock.json file.  I also found that npm i actually failed the first time for me.)
Run yarn dev.  I guessed this by spotting it in package.json, and I can see that the --watch parameter there means that as soon as any source files are modified, it automatically rebuilds the webpack bundles under src/extension/build.
Go to chrome://extensions
Ensure Developer mode is enabled
Click Load unpacked
Select the src/extension/build directory

This seems to be working for me, so it would be great if someone could confirm that it's the correct procedure.

Hi,
Instructions for development with this extension has been updated as well as your contributions have been merged in.
Closing issue #253


Add Django 4 and Python 3.10 to test matrix, remove unsupported versions

Supercedes #45
Not sure why I needed to add pytz to the dev requirements. This worked fine on Django 4 alpha, beta and RC. It's depended on by DRF, I think.

django has been depending on pytz for a few versions.

django has been depending on pytz for a few versions.

And it doesn't any more as of Django 4? Why did it not fail in the alphas/betas then?

Ahh, thanks Hacker News:

Ah I see:
pytz was made non-optional in https://github.com/django/django/commit/414ad25b090a63eaaf297b1164c8f7d814a710a2 (django 1.11)
now it is replaced with stdlib zoneinfo https://github.com/django/django/commit/306607d5b99b6eca6ae2c1e726d8eb32b9b2ca1b


Can't add dependencies to a specific invocation of a recipe with arguments

I'm playing with just for the first time and decided to experiment by rewriting this simple Makefile I'm currently using:
default: ign/cluster-1.ign

ign/cluster-1.ign: ign/system.ign ign/ssh.ign ign/k8s.ign
ign/%.ign: %.butane | igndir
        butane -s $< -d $(@D) > $@

.PHONY: igndir
igndir:
        mkdir -p ign

This generates ignition files from butane files. It also encapsulates the dependency that the cluster-1 ignition imports the system, ssh, and k8s ignitions, so they must be built first. This was my Justfile attempt:
default: (ign cluster-1)

ign cluster-1: (ign system) (ign ssh) (ign k8s)
ign IGN: igndir
        butane -s "{{IGN}}.butane" -d . > "ign/{{IGN}}.ign"

@igndir:
        mkdir -p ign

Unfortunately this dies with:
error: Recipe `ign` first defined on line 3 is redefined on line 4
  |
4 | ign IGN: igndir
  | ^^^

This is idiomatic and very powerful in make, and consequently I use it extensively. I couldn't see an obvious way to do this in just. I don't want a new recipe; I want to declare that when this recipe is called for 'cluster-1' specifically it has some additional dependencies.
Is there some other more idiomatic way of doing this in just?

Neat, I've never seen that pattern in make before!
So when you call ign cluster-1, you want to add additional dependencies, but still run the same recipe body?
Does this do what you want:
default: ign-cluster-1

ign-cluster-1: (ign system) (ign ssh) (ign k8s) (ign cluster-1)

ign IGN: igndir
        butane -s "{{IGN}}.butane" -d . > "ign/{{IGN}}.ign"

@igndir:
        mkdir -p ign

It would, and I considered custom targets. However, I've been working on this project for an additional 24 hours now and the dependency tree is substantially more complex already 🙄
For example, there are many more butanes, and the top level one is no longer the only one with dependencies. Additionally some of the butanes are now generated by a generic templating rule. Despite this they are all still processed identically.
Unfortunately I don't think a custom target for ever one would be very ergonomic.
That said, neither is this 😬:
# Read node variables from nodes.yaml
nodevars := $(shell ../bin/get-node-env ./nodes.yaml $(NODE))
$(foreach var,$(nodevars),$(eval export $(var)))

Gotcha. You can use _name if you want to suppress a recipe from being shown in --list, if you have internal-only recipes.
I think it would be pretty confusing if we did this, it's kind of a wacky feature of make, although I'd definitely be open to alternative ways of doing this, like conditional dependencies:
ign cluster: ? if cluster == "1" { extra-deps }

Syntax will likely be heinous, since it's hard to add things to the dependency parser.


Saving

https://www.npmjs.com/package/java.io#2-writeobjectobj

yeah, I am going to add a buffer field for now, so you pretty much give it a buffer and it replaces it in the object. eventually though, I can add world.js functionality inside of minecraft-classic-anvil.


[Q] Performance

Hi,
from your experience, how is the performance, flow rate of conductor and with which hardware settings?
How many Workflows per hour?
How many Workers per hour etc?
How many downtimes? Did you manually fix things?
What are your hardware settings (How many dynomite DCs, Racks, Nodes? How many ES Nodes? How many Conductor Instances)?
vg Che

Stats from 2016 @ Netflix
Stats
https://medium.com/netflix-techblog/introducing-dynomite-making-non-distributed-databases-distributed-c7bce3d89404


Fix object type in opae-c tests

According to the OPAE C programming guide, Umsg and Reconfiguration API calls are not supported for Accelerator. These changes set the object type to Device in setup and variable renamed.

Coverage increased (+0.008%) to 80.359% when pulling 89000b9bed674a86cce1a5beede0268a473492e8 on jelonanx/opae-c_tests into 85e9c3c7786e3cd2b376e807399933072f03f394 on master.


Add volume to get data outside the container

Is there any way to do this?

There is a solution in fork of this project: https://github.com/MaksymBilenko/docker-oracle-xe-11g

Please add  VOLUME /u01 to the Dockerfile. A Database which loses all data on restart is quite pointless. Mariadb/Mysql do the same in their images.

@atamanroman This is not going to work. There is a tricky dependencies.

If you would add VOLUME /u01 - database wouldn't start cause of there would be no DB installation in there.
And if you would mount only oradata folder - this is not going to work cause of Oracle requires DB configuration that stores on the different folder.

Here is an example of working solution in entrypoint:
On the Docker build image step do this:
mv /u01/app/oracle/product /u01/app/oracle-product

On the entrypoint:
rm -f /u01/app/oracle/product       #Just to make sure that there is no files
ln -s /u01/app/oracle-product /u01/app/oracle/product    #Mound database installation to the Expanded VOLUME of container

ln -s /u01/app/oracle/dbs /u01/app/oracle-product/11.2.0/xe/dbs    #Link db configuration to the installation path form extended volume with DB data

And then start DB.
you can take a look on the implementation of this by link on my previous comment

I made /u01 a volume and everything seems to work fine. Data is persisted between container restarts. Why would there be no DB installation in that folder?
VOLUME /u01 does not empty that folder. On initial container start all content in /u01 is copied into the volume.

Add volume when running the container.
docker run --name oracle11g -d -p 49161:22 -p 1522:1521 -p 49163:8080  -v /oracle11g-data/:/u01/app/oracle/oradata/oracle11g-data/ -e ORACLE_ALLOW_REMOTE=true   --restart=always wnameless/oracle-xe-11g

Hi @cbdavide  @dragonbest520
For me /oracle11g-data/ is also empty. Did you solve it? Why would we mount /oracle11g-data/ if Oracle data (tables) are not stored there?

For me /oracle11g-data/ is also empty ~~ @cbdavide @dragonbest520


On mobile, tap tempo 2 times will cause issue in calculating tempo.

On the second tap tempo, metronome.uiData.tempo will be null or undefined (tempo box says the placeholder value beats per minute instead of tempo number. App freezes.
This does not happen on desktop.

The root cause of the issue was that, on start up audioContext likely isn't initialized, thus audioContext.currentTime returns 0. tempo is then inf.


disable hyperthreading?

@JiaweiZhuang , I would have thought that there would be a performance boost if hyperthreading was disabled, and that's now easy to do in the config file:
https://docs.aws.amazon.com/parallelcluster/latest/ug/cluster-definition.html#disable-hyperthreading
Did you look at whether hyperthreading helps, hinders, or doesn't matter for your use cases?

We don't see a visible impact for our model, but it is of course model-dependent. Another small benefit of disabling hyperthreading is that Slurm can correctly recognize the true number of physical cores (not vCPUs). so that you don't need something like srun --ntasks-per-node=36 to avoid oversubscribing the cores.
See more at https://aws.amazon.com/blogs/compute/disabling-intel-hyper-threading-technology-on-amazon-linux/, for example:

A good example of contention that makes HT Technology slower is an HPC job that relies heavily on floating point calculations. In this case, the two threads in each core share a single floating point unit (FPU) and are often blocked by one another.

In the case of LINPACK, the benchmark used to measure supercomputers on the TOP500 list, many studies have shown that you get better performance by disabling HT Technology. But FPUs are not the only example. Other, very specific workloads can be shown by experimentation to be slower in some cases when HT Technology is used.

@JiaweiZhuang , thanks for the detailed response!   We will try it out, see how it goes, and report back.


Record problem form

Add a modal form that is displayed over <PelleMap> when a user clicks 'Report a problem' at the bottom of InfoWindow and allows the user to enter details about the current marker.

While the project is small we could utilise Formspree - set email to a pelleglobe contact. Alternatively find some javascript email setup. Formspree avoids SMTP worries however.


teig:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: This plugin exposes a function that calculates eigenvalues of a given matrix. This can be useful to avoid accidental mistakes when writing about concrete matrices and their eigenvalues.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

Oops, forgot to make the repository public, that should be fixed now.

Thank you!

The authors key is missing, but it is required for submissions. For some reason, CI didn't catch that, but it causes problems in Typst Universe.
Package metadata can be changed through a minor fix PR. I've added authors = ["SolidTux"] for now, so that it works in Typst Universe. Feel free to make an adjustment PR to another name than your GitHub username.
@elegaanz Could you enforce the existence of the authors array in CI?

Oops, sorry I didn't catch that. I will make sure the review bot checks for that array.


Fire 'vrdisplayconnect' event when populating VRDisplays. Fixes #40

Note, vrdisplaydisconnect doesn't apply here as there's no way to remove a shim VRDisplay anyway.

LGTM


Consider keeping a changelog?

I noticed the project doesn't publish changelog notes in releases or keep a changelog.md file. I'd recommend keeping one, as it's hard to see what's in the last two releases (1.3 and 1.2) unless we grep commit history instead

That's fair. I'll add a changelog when I have some time.


Sideloaded connectors show up in section named "Sideloaded", not "Uploaded"

The text in our docs is incorrect (screenshot is ok though).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54780e5a-ca3a-5277-dc84-37f85d9ea1cb
Version Independent ID: 5f89865b-a9fd-ada5-72d2-6375357bba8c
Content: Upload your custom app in Microsoft Teams - Teams
Content Source: msteams-platform/concepts/deploy-and-publish/apps-upload.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@aosolis , Can you please point to exact section or text.

Hi @aosolis. Thank you for the callout! The document has been updated.


[Bug] Switching branches do not work reliable

There should be latest commit with: feature: Prepare extraction of main bucket (#3060)
This needs to be fixed in master before merging develop with bucket extraction into master.

I will not have time today, need to go sleep. I will look into it tomorrow if there will not be solution already.


question about std::launder

Hi, I find this project use std::launder in here and here. I read the cppreference and some blog posts about std::launder, but I still cannot understand it. My question is if removing the std::launder, is there any undefined behavior?

Because I cannot figure out when and where should I use std::launder. At first, I saw some examples about prevent the compiler from constant folding optimization, so I think the use case here may be unnecessary. But then I found the use case here, so I am very confused now......


Allow to change the font of the workbench

VSCode Version: 1.14.2
OS Version: Debian 9

Recently rebuilt my dev machine and installed VS Code. Did not have droid sans mono at first, so the text in the editor looked bad, finally fixed it to look like it should again.
The issue now is that all other elements are not using "Droid Sans Mono" or any other monospaced font.

Check the tab text at top and bottom.

Same here.
Reproduces without extensions: Yes

Duplicate of #519


Watermark and tooltip overlapping

Are you working on this issue? (Yes/No)
No

I would work on it 🙂


bug v3: Preview goes on inifinite error loop if buffer is deleted while symbols / definitions are open.

Did you check docs and existing issues?

[X] I have read all the trouble.nvim docs
[X] I have searched the existing issues of trouble.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.10.0-dev-3116+gc1396afa7
Operating system/version
WSL - Ubuntu 22
Describe the bug
When closing a buffer via buffer delete (:bd) when either LSP symbols or definitions window is open, Preview keeps trying to index a null value and goes on an infinite error loop.

Steps To Reproduce
1- Open any file with LSP symbols support
2- Toggle LSP Symbols window
3- Close buffer with  :bd
4- If it does not trigger on first try, navigate to one of the symbols and try again.
Expected Behavior
Either symbols / definitions windows close with the buffer or they stay open without errors.

This can also be triggered when attempting to open Symbols window when no buffer is open, e.g. from an Alpha Dashboard.


controlled component link

when clicking on the hyperlink of controlled components the page of uncontrolled components redirects to https://reactjs.org/docs/forms.html the correct would not be https://reactjs.org/docs/forms.html#controlled-components?

Seems like the whole article is about controlled components, isn't it?

yes, yes, I just thought it would make more sense if I went to the specific section


[SPARK-7763] [SQL] Persists partition columns into metastore

Merged build triggered.

Merged build started.

Test build #33148 has started for   PR 6285 at commit 2a38b5b.

Test build #33148 has finished for   PR 6285 at commit 2a38b5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33148/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #33184 has started for   PR 6285 at commit 7e02910.

Test build #33184 has finished for   PR 6285 at commit 7e02910.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33184/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33217 has started for   PR 6285 at commit 387153c.

Merged build triggered.

Merged build started.

Test build #33219 has started for   PR 6285 at commit 6733276.

Test build #33219 has finished for   PR 6285 at commit 6733276.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33219/
Test FAILed.

Test build #33217 has finished for   PR 6285 at commit 387153c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33217/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33247 has started for   PR 6285 at commit 44b283f.

Test build #33247 has finished for   PR 6285 at commit 44b283f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33247/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33248 has started for   PR 6285 at commit d677f7d.

Test build #33248 has finished for   PR 6285 at commit d677f7d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33248/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #33257 has started for   PR 6285 at commit bb2829d.

Test build #846 has started for   PR 6285 at commit bb2829d.

Test build #33257 has finished for   PR 6285 at commit bb2829d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33257/
Test PASSed.

Test build #846 has finished for   PR 6285 at commit bb2829d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I am going to merge it to master and branch 1.4.


Move tags to the bottom of a post

Dear Michael, thank you for the great jekyll theme. I was wondering if you could provide an example of how to move the tags to the bottom of the page?

That's pretty easy to do. If you look at _layouts/post.html on line 19 you'll see the code for the post tags. What you can do is grab the following and move it wherever you want in the layout.

    {% for tag in page.tags %}
{{ tag }}
{% endfor %}

I'd suggest placing it right after the {{ content }} tag on line 45. Moving it here will give you something like this:

Thank you!


How does Virtual Network Gateway treat packets with destination not found in its internal routing table?

A bit strange question:

Let's say, a VPN Gateway receives a packet with destination not found in its internal routing table (as shown by the Get-AzVirtualNetworkGatewayLearnedRoute command). The route wasn't learned by BGP, or from static entries of the connected Local Network Gateway, and it doesn't belong to the VNET the VPN Gateway is placed in, or to its peered VNETs.

How VPN Gateway is expected to treat such a packet? Silently drop it? Send it to some default destination (which one)?

I'm asking because I noticed that I'm able to direct such packets, received over IPsec, to destinations of my choice (let's say, an NVA or a LB fronting several NVAs) by applying a UDR to the GatewaySubnet. So the VPN Gateway does deliver the packets  to the VNET (where SDN handles it according to my UDR) - but why? I don't see route <IP_ADDRESS>/0 in the output of Get-AzVirtualNetworkGatewayLearnedRoute. Why aren't these packets discarded?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9882bb13-4b95-2780-4754-37e96564c73f
Version Independent ID: 6d9ea1aa-f6ca-b913-8eba-5b3e638a129d
Content: Get-AzVirtualNetworkGatewayLearnedRoute (Az.Network)
Content Source: src/Network/Network/help/Get-AzVirtualNetworkGatewayLearnedRoute.md
Service: virtual-network
GitHub Login: @mikefrobbins
Microsoft Alias: mirobb

@cat-mucius
Thanks for your feedback! We will investigate and update as appropriate.

@cat-mucius
Thank you for your feedback!
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


[Feature][Flink/Spark Operator] Flink/Spark Operator on Kubernetes

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Now, Flink and Spark has native Kubernetes integration ability by Flink/Spark Operator. So, ds also can provide this Operator Mode to use Flink/Spark on Kubernetes.For more detail information ,you   can click this url: https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-release-1.2.
Thanks.
Use case
DS can deploy Flink/Spark application by Operator,and DS alse monitor application status from Flink/Spark Operator.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @kezhenxu94 @nobolity

Anyone can reply?

Can we do this by submitting yaml to the k8s api Server using kubeconfig @SbloodyS @kezhenxu94 @nobolity

Can we do this by submitting yaml to the k8s api Server using kubeconfig @SbloodyS @kezhenxu94 @nobolity

There is Kubernetes task already, https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/task/kubernetes.html

Can't we write yaml for this k8s task? The spark-operator I expect is to submit tasks by writing yaml


Uncaught TypeError: Cannot read property 'type' of undefined at start of switch function

I'm trying to use move my app to redux-react from pure react. I made an action and reducer for onClick but after trying to start the app in dev mode I get this error
    Uncaught TypeError: Cannot read property 'type' of undefined at reducerDomMethods (manMethodsReducers.js:12)

which is this line
    switch (action.type) {

This is my code
reducer
    export default function reducerDomMethods(state={
    isClicked: false,
    }, action) {
    switch (action.type) {
        case "CLICK_OPEN": {
            return {
                ...state,
                isClicked: true
            }
        }

        case "CLICK_CLOSE": {
            return{
                ...state,
                isClicked:false
            }
        }

            return state;
      }
    }

action
    export function clicking(isClicked) {

    return function (dispatch) {

                if( isClicked === true){
                    dispatch({type: "CLICK_OPEN",isClicked: true});
                }else {
                    dispatch({type: "CLICK_CLOSE",isClicked: false});
                }
       }
    }

combine reducer
        import { combineReducers } from "redux"

        import cityName from "./apiReducers"
        import nameOfCity from "./apiReducers"
        import weatherDescription from "./apiReducers"
        import windSpeed from "./apiReducers"
        import temperature from "./apiReducers"
        import maxTemperature from "./apiReducers"
        import minTemperature from "./apiReducers"
        import isClicked from "./manMethodsReducers"

        export default combineReducers({
            cityName,
            nameOfCity,
            weatherDescription,
            windSpeed,
            temperature,
            maxTemperature,
            minTemperature,
            isClicked
        })

store
    import { applyMiddleware, createStore } from "redux"

    import logger from "redux-logger"
    import thunk from "redux-thunk"
    import promise from "redux-promise-middleware"

    import reducer from "./reducers/weather-apiReducers"
    import reducerDomMethods from "./reducers/manMethodReducers"

    const middleware = applyMiddleware(promise(), thunk, logger())

    export default createStore( reducer , reducerDomMethods, middleware)

connect
        import {connect} from "react-redux"

    @connect((store) => {

        return {
           nameOfCity:store.nameOfCity.nameOfCity,
           weatherDescription:store.weatherDescription.weatherDescription,
           windSpeed:store.windSpeed.windSpeed,
           temperature:store.temperature.temperature,
           maxTemperature:store.maxTemperature.maxTemperature,
           minTemperature:store.minTemperature.minTemperature,
           isClicked:store.isClicked.isClicked,
          }
         })

This is a usage question, and should be asked on Stack Overflow instead.
As a few side observations:

the Redux team discourages the use of connect as a decorator.  Use it as a function instead ( export default connect(mapState, mapDispatch)(MyComponent) ).
The duplicated state names in your mapState function are a bad sign.  That suggests you're using combineReducers wrong.
You're passing reducerDomMethods as the second argument to createStore.  The second argument should be an object that is the preloadedState, not another reducer function.

You can't dispatch directly through a function within your component.It should be like this----
dispatch((dispatch) => {
filmAction(dispatch);
});


Implements the changes of issue #824

Watch out for those trailing spaces!  It's picky but let's clean that up and then ship

Closes #824


Limit number of columns per row

I have a requirement to the limit number of columns returned from very wide rows.
I have forked this project and I am able to make this work by exposing the StoreLimit property which already exists in the Scan and Get structs.
Before I continue on with this, is there some reason why  StoreLimit and StoreOffset aren't already accessible?

is there some reason why StoreLimit and StoreOffset aren't already accessible?

no reason other than no one need the feature :)
Feel free to send the pull request with your implementation (with integration tests), would be happy to see your contribution. Remember to sign licensing agreement first: https://github.com/tsuna/gohbase#contributing

Hello,
I improved the api of Scan to be able to get a row a time and added an option to ask for partial rows in order to resolve a potential OOM issue if a row is too big: https://github.com/tsuna/gohbase/commit/45ae8893ad247be1559746a985f837db8bc1cdc5
When you create a scan, you can pass this option to tell regionservers to return partial rows so that they don't run out of memory. Not sure if the returned results are going to be small enough for your client. Would this option be enough for your case?

Sorry I missed your last question. The improved Scan API is very useful for us for some of our use cases. Our immediate problems was with gets.
We store events against a user key in a single column family and use the column qualifiers as keys to the event - sorted in descending order. We need to be able to limit the number of columns returned on any given request as some users have many thousands of events even when applying a timerange - and we don't want them all; just the latest n number very quickly.
I went ahead and added the functionality to both scans and gets while I had my fingers in there since the attributes already existed in the Get and Scan structs in Client.pb.go.


Add Jaeger setup instruction

Thank you for helping make the Dapr documentation better!
If you are a new contributor, please see the this contribution guidance which helps keep the Dapr documentation readable, consistent and useful for Dapr users.
Note that you must see that the suggested changes do not break the website docs.dapr.io. See this overview on how to setup a local version of the website and make sure the website is built correctly.
In addition, please fill out the following to help reviewers understand this pull request:
Description
Add instruction for using Dapr with Jaeger.
Issue reference
Please reference the issue this PR will close: https://github.com/dapr/docs/issues/693

@orizohar can you please help review?  thanks


Provide a way to cleanup recipes

After I started all the samples, I'd like a way to clean them up.

I agree.
I can stop an app:

But then it's not displayed in the AI Apps page anymore:

When it runs, I can stop it in the AI Apps page, but cannot delete it:

I feel like besides the ability to delete the App, it would also make sense to display not-running/stopped AI Apps in the that page.
@slemeur @axel7083 @lstocchi what do you think?

I agree.
I can stop an app:
But then it's not displayed in the AI Apps page anymore:
When it runs, I can stop it in the AI Apps page, but cannot delete it:
I feel like besides the ability to delete the App, it would also make sense to display not-running/stopped AI Apps in the that page.
@slemeur @axel7083 @lstocchi what do you think?

In fact, the Stop button has the effect to delete the pod, not stop it.
It has been discussed during an UX call, and we didn't want to have 2 buttons, one Stop button and one Delete button, to not confuse the user on which one to use, so it has been chosen to keep only the Deletion of the app (using a Stop button, which can be confusing, I would agree)

We wanted to hide the low-level and consider the app as either running or deleted. But it depends on if we really want to hide this low-level "complexity". It is not done for models services for example, so we could be consistent with it and have much more states for the app.
@slemeur WDYT?

@slemeur introduced by https://github.com/containers/podman-desktop-extension-ai-lab/pull/719 we have the delete action on a recipe. Does this resolve this issue, or you add something else in mind ?


Error Recovering Feature - WIP (Work in Progress)

I cherry picked some changes from my master branch where I worked on the basic error feature support. Now lark does not stop on the first error, but the old behavior can be set with:
json_parser = Lark(json_grammar, parser='lalr', debug=0)
json_parser.parser.parser.parser.error_recovering = False

I think the the error recovering strategy implemented on lalr_parser.py is not optimal because while running sometimes examples.error_reporting_lalr.py it reports 2 errors, other times 1 error only. For example, running  python -m examples.error_reporting_lalr, you got now:
Parsing example 1
Caught 2 exceptions:
Missing Closing at line 1, column 14.

{"example1": "value"
             ^

Unexpected token Token(<EOF>, Token(ESCAPED_STRING, '"value"')) at line 1, column 14.
Expected one of:
	* RBRACE
	* COMMA

Parsing example 2
Caught 2 exceptions:
Missing Opening at line 1, column 14.

{"example2": ]
             ^

Missing Opening at line 1, column 12.

{"example2": ]
           ^

But another time latter you can get:
Parsing example 1
Caught 1 exceptions:
Missing Closing at line 1, column 14.

{"example1": "value"
             ^

Parsing example 2
Caught 2 exceptions:
Missing Opening at line 1, column 14.

{"example2": ]
             ^

Missing Opening at line 1, column 12.

{"example2": ]
           ^

i.e., the first error is dangling between runs.

I also added a wrapper library for the python built-in logging module as an optional dependency. I wrote and use everywhere to help me understand the system and log messages. I tried to take care on how I affects performance, but still need to do some benchmarks. In any case, a quick find/replace/comment all can be used.
The debugging library usage is configured in 3 phases. The first one is on the file utils.py:
log = getLogger('lark', force=1)

This forces all loggers loaded after to be set with level 1 of log level. This keeps them quiet while lark does its static member initialization.
The second phase is on the lark.py file. Enabling it here, allows us to see all logging messages after the static initialization of the lark library components:
if debug: log.setup(force=debug)

This uses the same value passed to Lark() constructor for the debug level. But now, instead of accepting a boolean, debug is an integer for the debug level where 0 is completely disabled.
The third phase are all getLogger() function calls or log.debug_level = 1 assignments. When not instantiating a logger with kwarg force=1, each loggers level is controlled by the file they are in:
log = getLogger('lark', 1)

# or
log = getLogger(1, 'lark')

# or
log = getLogger('lark')
log.debug_level = 1

Creates a logger with the level 1 valid only for the current file. This allows fine grained logging output control for each file while developing.

Todo

[ ] Maybe disable lexical errors for the next lines after a syntax error because when a syntactical error happens, it can create some lexical errors on the following lines. (Perhaps they are induced by the contextual lexer?)
[ ] Try to move most error recovering code from error_reporting_lalr.py into lark
[ ] Allow to dynamically exchange the syntactical error recovering heuristics

[ ] Then, add a new alternative syntactical error recovering heuristic implemenation

[ ] Fix any regression Unit Tests broken
[ ] Unit Tests for Lexical Error Recovering implemented
[ ] Unit Tests for Syntactical Error Recovering implemented
[ ] Fixes #227 Error recovery: Can I add some error recovery strategy?

Hi @evandrocoan,
That's a really big pull request! Usually I prefer smaller PRs. That way I can discuss the different changes separately, and merge them in selectively.
Honestly, I was thinking about a very different interface.
My idea was to add a new parameter for Lark, like this:
parser = Lark(grammar, parser="lalr", on_error=my_on_error

And then the user can do something like:
errors = [ ]
def on_error(error):
    if len(errors) < MAX_ERROR:
         errors.append( error )
         return error.expected[0]
    else:
         raise TooManyErrors( )

Or alternatively, something like:
COMMON_MISTAKES = {",", "}", ";"}
def on_error(error):
     ok_mistake = set(error.expected) & COMMON_MISTAKES
     if ok_mistake:
          return list(ok_mistake)[0]
     else:
          raise error

It seems to me much simpler and flexible, and allows the user to easily do whatever they need.
What do you think?

Hi @erezsh,
I think it a very nice interface. I did not had though about using closures.
I can open a series of pull requests integrating all the features on this pull request.
I would have to start with the following sequence of difficulty:

[ ] Add .gitignore (easy)
[ ] Add the logger (medium)
[ ] Add Lexical Error Recovering + Unit Tests & Regression Testing (hard)
[ ] Add Syntactical Error Recovering + Unit Tests & Regression Testing (very hard)

Hi,
See my comments regarding .gitignore
I'm not too enthusiastic about adding a logger, but I'm willing to consider it.
Regarding the on_error interface, I'll add it myself in the upcoming days. If you want to add to it, or provides tests, that'd be great.

Closed by #296 comment.


Ensure uniqueness of diagnosis keys

Current Implementation
The uniqueness of diagnosis keys is neither guaranteed by the database, nor by validation logic.
Suggested Enhancement
Ensure that diagnosis keys in the database are unique (there are no duplicates).
What needs to be decided:

[ ] Is it sufficient to guarantee the uniqueness of the diagnosis key or should the uniqueness of diagnosis key + submission timestamp (+maybe even more fields) be guaranteed?
[ ] Should the duplicate check happen on the database (UNIQUE constraint) or in the server logic (e.g. during the validation of submitted keys)?
[ ] If the check happens on the database: Should the id column be removed and replaced with the diagnosis key (+submission timestamp) as (composite) primary key?
[ ] How should the server react when a duplicate diagnosis key is submitted (update, error, etc.)?

Decisions made:

Ensuring the uniqueness of the diagnosis key is sufficient
Duplicate check should happen on the database
id column should be removed
key_data column should become primary key
If we encounter problems with the current type (bytea) of key_data as primary key, then change the type to a base64 encoded String
When duplicate keys are submitted, the server should just ignore them (no update, no error).

@pithumke Was referenced back to here from a different issue, What would be the value of base64 encoding the UUID? it'll just take up even more space than even using char(32). there is a UUID type already in pg that'll give better seek performance and cost 16 bytes per entry instead of 32
About the risk of collision itself, with UUIDv4 that is quite unlikely even with billions of records, However if you don't want to suffer the occasional exception on the server side you can just add ON CONFLICT DO NOTHING to swallow the error

Hi @oiime, thank you for the remarks! Good point with the UUID type, I'll bring it up in the team discussions and report back. However, please note that, to my knowledge, the type of the diagnosis keys is not explicitly stated as UUID by the Google/Apple spec, but only as "Data" (see here) containing 16 bytes (see here). This can, in theory, be mapped to a UUID, but I would like to investigate if the PG UUID type implies any restrictions. For example, UUIDv4 reserves 6 of the 128 bits for version information, leaving only 122 bits for the payload - and this would cause major problems for us.
Regarding the collisions: we currently also don't see this as a major risk. Our current strategy, as you proposed, is to simply ignore duplicates.

@pithumke Well, you're the one defining both the client and the server side, the EN API is agnostic to its content to allow that freedom of implementation, so you can define that key to be whatever you want it to be, currently you are validating it as UUID in the server and the test case generates a UUIDv4. the UUID data type follows RFC 4122 as you would expect and would naturally cover UUIDv4. All UUID versions reserve a place for version information. please do not try to come up with your own UUID variant if that is what is suggested here

Hi @oiime, thank you for your comment.

Well, you're the one defining both the client and the server side, the EN API is agnostic to its content to allow that freedom of implementation, so you can define that key to be whatever you want it to be

Yes, we do specify and develop both the CWA server and client. However, we neither specify nor develop the on-device APIs - that is done by Apple and Google. Inside those on-device APIs is where the keys are being generated and that does not give us much freedom regarding data types on our end. In the specification it is stated, that the key data consists of 16 bytes (= 128 bits). Since the use of UUID would restrict that to 122 bits, we can not use it as the column type on postgres.

currently you are validating it as UUID in the server and the test case generates a UUIDv4

I am not aware of any UUID handling in our current code base, besides for TANs (which are not stored on the server). Can you please link which specific code you are referring to?

please do not try to come up with your own UUID variant if that is what is suggested here

I didn't mean to suggest that and we don't want to come up with an own UUID variant. This is why we decided to go for a base64 encoded string for now (if bytea turns out to cause problems).

@pithumke

However, we neither specify nor develop the on-device API

I guess I rely on looking at the API itself, perhaps apple or google or both have a specific implementation they mandate or suggest, if that is the case then using UUID is wrong anyway

I am not aware of any UUID handling in our current code base, besides for TANs

I am likely conflating the two, I have only skimmed through the code and what I recalled was the test generating UUIDv4

I didn't mean to suggest that and we don't want to come up with an own UUID variant. This is why we decided to go for a base64 encoded string for now (if bytea turns out to cause problems).

base64 seems like an unnecessary step that'll just take up more space and computation, you do it to avoid just storing it in a char(16) as-is? though I don't see why bytea wouldn't work as a PK, especially as you'd never update it

The postgreSQL UUID data type stores 128 bits of data and it is up to the user how to use them. So, the UUIDs provided by the API from Apple/Google fit into an UUID field without problems and without bytea conversion. I like bytea, but the conversion is a little bit tricky.
And UUID has two more advantages: bytea needs a length indicator (4 bytes) und requires, that each row/tuple has variable length, which makes some queries slower. Usually it is good practice, to avoid variable length columns or put them to the end of all columns (which would look weird here).
See documentation for UUID Type (and #451).


Don't Starve together commands don't answer

Hello,
first of all you are a Genius! I'm following this project since quite a while now, have played the three Borderland games and Resident Evil with my family thanks to you!
I am now having a problem with Don't Starve together, i've downloaded the Alpha 8 release and the steam_api.ini and .dll files, and got the two game screens to show up, but I have two issues, first of all the two displays are quite small but that's not a major issue, because I can't control anything not with the controllers and not with the keyboard.
I hope you can help me out with this one, i was really hoping to be able to play this together with a friend who is having a hard time and who loved this game when it first came out.
Again thank you for the great work. Keep it up bro!

Hello MrPicklesRick,
I'm glad you liked this release.
I added DST mod to Nucleus and faced the same problem as you on first screen.
This is likely due to the fact that controllers are disabled by the game.
You have two options here:

As mentionned in my reddit post when I released this (https://www.reddit.com/r/nucleuscoop/comments/6sl4k3/added_dont_starve_together_pc_split_screen/) "if you have any trouble with controllers not properly working when game is started, close games, ensure controllers are plugged, and delete the file in your documents folder here : Documents\Klei\DoNotStarveTogether\client.ini"

Go manually into the game (normal mode, without nucleus), enable controller support in options, save, quit the game.

It should work perfectly for you :)
Enjoy !
Regards,
r-mach

Thanks r-mach =D
If r-mach's solution has helped you warn us so we can clsoe the issue. If not we can keep on trying to help you fix it, just ask ;)

We should consider automaticaly configuring these files

Thank you guys It worked like a charm! I've actually deleted the client.ini file before, but I must have forgotten to start the game without nucleus afterwards.
Great Customer service, I will definitely donate at some point!

I reopen this as we need to automatically patch this :)

Hello there, I'm a first time user of nucleus and wanted to also play DST but for some reason, I can seem to start DST using nucleus. Nucleus can detect and DST and my gamepad but the arrow key and play button on its interface seem to not work

Hello there, I'm a first time user of nucleus and wanted to also play DST but for some reason, I can seem to start DST using nucleus. Nucleus can detect and DST and my gamepad but the arrow key and play button on its interface seem to not work

Actually I managed to make it play but it seems to say too many .dll files are missing,
Any help?


Conceptual Design Parity Fixes

This pull request helps to match the Conceptual Design document

We're all good for Page 1 of the design.

Page 2 seems to require some changes.

Fix for issue #70 is up, though with a caveat

Implement Issue #57

That should be enough changes for this PR

Fix Issue #63

Corrected the formula for issue #57.
While it is a major change, the parameters are currently set so that the top-level attention value will always remain at 0.5 (equal chance to Observe a buffer vs. Consider), so we dont have to worry about control instability at the moment

Initially there were 59 test case failures. After the control mechanism change, there were many more test failures (104) since the system is now doing less in each cycle, so it was less likely to complete each test.
To fix this, I added more cycles to all test cases to account for the change. Now the number of test cases passing is about the same as before (53)

@ccrock4t will review it this week.
This is a big PR touching many parts of the system so one suggestion I have for the future is to limit pull requests to 1-2 issues to isolate the changes and ease testing and review.


chore: add changeset for @flatfile/embedded-utils

Closed since a changeset was added in another PR


New steam update removing skins

https://steamcommunity.com/games/593110/announcements/detail/3687931965598323437
Steam Client Update - June 14th
https://steamcommunity.com/app/593110/eventcomments/5514142341086067567
And the update comment thread (as usual, a  mixed bag of praise and harsh criticism)
It seems like steam completely dropped support for skins, and had the gall to not even mention this in their so-called patch notes.
Does this mean the end for SFP? I hope Valve reverts some of this to give us skins back at least, but considering their track record I'm very doubtful.
It's a shame, too, I only set up SFP a week ago for a custom skin.

SFP still works. Skin authors are working on skins for the new client.
https://github.com/AikoMidori/SteamSkins has a few options


Fix the SRCCLR-SID-21682 vulnerability issue

Upgrade the async-http-client version from 2.5.2 to 2.10.4 to resolve the SRCCLR-SID-21682 vulnerability issue
Fixes #5956
The fix is based on this resolution report:  https://www.sourceclear.com/vulnerability-database/libraries/asynchronous-http-client/java/maven/lid-344614

Can one of the admins verify this patch?

@srnagar PTAL

Hi,
Can you please let me know when will we get a version with this fix available on maven repo? This security fix is on high priority on our side and we are waiting for it. Please provide us the ETA.
Thanks
Amol

@joshfree @srnagar , We have had multiple releases after this PR was merged. The servicebus pom doesn't specify any hard version dependency. Yet, the maven repository is showing version 2.5.2 instead of 2.10.4.
Can you help me understand where is the 2.5.2 coming from?

Do we have any update on this?

Looks like version 3.1.4 has the right version in pom. - https://mvnrepository.com/artifact/com.microsoft.azure/azure-servicebus/3.1.4


update images on console-debug-javascript

Docs Build status updates of commit 18f1bfc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/media/console-debug-displays-error.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-displays-in-sources.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-error-assert.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-code-error.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-code-line.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-fixed.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-network.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-network-detail.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-report.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-sources.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-network-error-url.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-debug-trace.msft.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 18f1bfc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/2105/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Change QP dynamically in RC_OFF_MODE

We are trying to use RC_OFF_MODE and control the QP value of every frame ourselves. We tried to use SetOption(ENCODER_OPTION_SVC_ENCODE_PARAM_EXT) to change the QP value in encParamExt.sSpatialLayers[0].iDLayerQp but nothing happened. Please check.
Further analysis of the codes has shown that the QP value is simply not copied to the original config, so I made this simple patch and it seems to work.
diff --git a/codec/encoder/core/src/encoder_ext.cpp b/codec/encoder/core/src/encoder_ext.cpp
index bf31c31..33119af 100644
--- a/codec/encoder/core/src/encoder_ext.cpp
+++ b/codec/encoder/core/src/encoder_ext.cpp
@@ -4607,6 +4607,7 @@ int32_t WelsEncoderParamAdjust (sWelsEncCtx** ppCtx, SWelsSvcCodingParam* pNewPa
       pOldDlp->iSpatialBitrate	= pNewDlp->iSpatialBitrate;

       pOldDlp->uiProfileIdc		= pNewDlp->uiProfileIdc;			// value of profile IDC (0 for auto-detection)
+      pOldDlp->iDLayerQp		= pNewDlp->iDLayerQp;

       /* Derived variants below */
       pOldDlpInternal->iTemporalResolution	= pNewDlpInternal->iTemporalResolution;

Created this PR: https://github.com/cisco/openh264/pull/1963

Thanks a lot for the finding, the PR is merged.


AppDomainUnloadedException when test runner exits

The first run is with 2.1.0, the second with 2.1.3.

https://www.nuget.org/packages/Xbehave.Core/2.1.4
https://github.com/xbehave/xbehave.net/releases/tag/2.1.4


[Spi host] New DIFS

This PR:

Add OT_WARN_UNUSED_RESULT to recently added DIFs.
Add an external function to access the spi_host.COMMAND register.
Add rx and tx watermark options to the dif_spi_host_configure function.

This looks good to me, although I don't know too much about the SPI host.


simplify code

What is the purpose of the change
simplify and beautify code, clearify logic, no behaviour changed.

he compiler will insert a call to valueOf() for primitive when autoboxing after java 5.

Codecov Report

Merging #4883 into master will decrease coverage by 0.02%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master    #4883      +/-   ##
============================================
- Coverage     63.97%   63.94%   -0.03%
  Complexity      452      452
============================================
  Files           769      769
  Lines         33157    33157
  Branches       5228     5228
============================================
- Hits          21211    21203       -8
- Misses         9525     9535      +10
+ Partials       2421     2419       -2

Impacted Files
Coverage Δ
Complexity Δ

...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java
80.79% <86.66%> (ø)
0 <0> (ø)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75% <0%> (-12.5%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyClientHandler.java
61.4% <0%> (-7.02%)
0% <0%> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
80.48% <0%> (-4.88%)
0% <0%> (ø)

...e/dubbo/remoting/transport/netty/NettyChannel.java
57.64% <0%> (-4.71%)
20% <0%> (-1%)

.../dubbo/monitor/support/AbstractMonitorFactory.java
78.37% <0%> (-2.71%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
64.7% <0%> (-1.18%)
0% <0%> (ø)

...g/apache/dubbo/registry/consul/ConsulRegistry.java
61.87% <0%> (-0.63%)
29% <0%> (ø)

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
90.65% <0%> (+0.93%)
17% <0%> (+1%)
:arrow_up:

...c/main/java/org/apache/dubbo/rpc/RpcException.java
83.33% <0%> (+3.33%)
0% <0%> (ø)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00653c3...b209769. Read the comment docs.


Fix jar versions problem

:shipit:

Comment accepted. Will treat it ASAP

Squashing and checks in progress.


training_buildout should avoid setuptools==46.1.3

When following the instructions in Mastering Plone Training to install Plone, after creating a virtual environment with python3.7 -m venv ., one should not ./bin/pip install --upgrade pip setuptools as the console output suggests. There be dragons!
To fix, downgrade setuptools:
pip install -U setuptools==42.0.2

This appears to have been removed from both Master Plone Trainings. Closing.


Feature: Verifying Docker Desktop license on an offline computer

Tell us about your request
A way for users to verify Docker Desktop licensing on an offline computer.
Which service(s) is this request for?
Docker Desktop for Windows and Linux
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
I have a Docker Teams license.
I have an offline computer that does not have Internet access.
I am trying to use Docker Debug but it is a feature that required login to Internet to verify Docker licensing.
As a result I am unable to use Docker Debug.
 Or if the Docker Debug command isn't paywalled by a login. Then I would be able to use Docker Debug.
Are you currently working around the issue?
No workarounds.
Additional context
Nil.

@cardin Thanks for the feedback. As we think about how to support these scenarios - is your offline computer connected to an internal corporate network or is it fully air-gapped?

@smnovick i have both types of computers: some are connected to an internal corporate network, while some are standalone fully airgapped.


fix: disable automatic eviction of diskcache at aggregation

Python diskcache, which we use for aggregating trainer updates, have its own automatic eviction policy, depending on its size_limit and cull_limit value. Updated it to disable automatic eviction, and added a logger debug line that tells you the number of updates in the cache.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #419 (4548f06) into main (e328ebf) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   14.86%   14.86%
=======================================
  Files          48       48
  Lines        2832     2832
=======================================
  Hits          421      421
  Misses       2382     2382
  Partials       29       29


Remove red bar when running in offline-mode branch [#177458105]

NOTE: this adds the offline-mode branch as a production url

@scytacki I've added a follow on PR here:  https://github.com/concord-consortium/activity-player/pull/195/commits/22e93ee62e6c1cd19e9a69581f93d26b719108fc
I should have called out in the PR description that I was "regularizing" the check as I saw that we checked version in one and not in the other.  I thought that was a bug and not a feature :)