Poor Publish & Debug (F5/Alt+F5) Performance on Large Database

Describe the bug
On a large Database (140GB with lots of history data) we have very bad performance when publishing Extensions from VS Code.

It does not matter if we use RAD or not (F5 / Alt+F5)
It does not matter if we use ForceSync or Synchronize SchemaUpdateMode
It does not matter what kind of change we do, even the change of a caption property results in this issue.

Publishing takes several minutes to execute. On a Cronus Database the same extension publishes within a few seconds.
While Publishing there is massive resource consumption on the sql server (CPU & Disk IO)
When looking at it with the profiler i can see that every table extension table is performed with some sort of data consistency logic:

INSERT with PK Values for non existent Records in the extension table
DELETE of any Record in the extension table that does not exist on the original Table

I understand the reason for this logic (to maintain data consitency across extension tables) but in my opinion it does not make any sense to do this if nothing has changed in the schema and we as a developer should have the possibility to prevent this consistency validation for increased performance (given the impact it can have on development speed)
To Reproduce
Steps and to reproduce the behavior:
Use a large Database with customization (TableExtension) on history tables like G/L Entry, Sales Invoice Header, Sales Invoice Line, etc.
Expected behavior
At least when using RAD and not changing anything table related (no fields added,removed,changed) the performance should be consistently fast no matter the size of the database.
Right now it is not possible to work with large databases...
Since this is a Upgrade Project, we need the data for validation
Screenshots
If applicable, add screenshots to help explain your problem.
5. Versions:

AL Language:
4.0.199169

Business Central:
CH Business Central 15.1 (Platform 15.0.37769.0 + Application 14.0.36457.0)

Go ahead and post this to our Ideas forum at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release. It will help us positively to prioritize the issues and address the most common ones more quickly.

@PooyaKharamesh this is not an idea this is a serious bug/issue!

@marknitek we agree that this is a problem and we appreciate very much that you have raised this issue. We are only asking you to post it on BCIdeas because it will give other partners the possibility to support your issue and if it raises a large number of votes, we will be able to allocate more time to improving this across multiple teams.

This should not be voted as an idea! It's a bug that should be fixed.


Error when run yarn deploy-storybook --ci in CircleCi

Hey guys,
I'm having an error while trying to deploy with CircleCi.
I don't know what's happening, because the problem began to appear now, and before that, it was already working.
my config:
version: 2 # use CircleCI 2.0
jobs:
  build:
    docker:
      - image: circleci/node:9-stretch
    environment:
      TZ: "/usr/share/zoneinfo/America/Sao_Paulo"
    steps:
      - checkout # special step to check out source code to working directory
      - run: sudo apt-get update
      - run: sudo apt-get install apt-transport-https
      - run: curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
      - run: echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
      - run: sudo apt-get update && sudo apt-get install yarn && yarn
      - save_cache: # special step to save the dependency cache
          key: dependency-cache-{{ checksum "package.json" }}
          paths:
            - ./node_modules
      - run:
          name: Run React Tests
          command: yarn jest --no-cache --runInBand

  deploy:
    docker:
      - image: circleci/node:12.2.0
    environment:
     GH_TOKEN: "MY_GH_TOKEN"
     NPM_TOKEN: "MY_NPM_TOKEN"
    steps:
      - checkout
      - run: sudo apt-get update
      - run: sudo apt-get install apt-transport-https
      - run: curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
      - run: echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
      - run: sudo apt-get update && sudo apt-get install yarn && yarn
      - run:
          name: Deploy Storybook
          command: yarn deploy-storybook --ci

  release:
    docker:
      - image: circleci/node:9-stretch
    environment:
     GH_TOKEN: "MY_GH_TOKEN"
     NPM_TOKEN: "MY_NPM_TOKEN"
    steps:
      - checkout
      - run: sudo apt-get update
      - run: sudo apt-get install apt-transport-https
      - run: curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
      - run: echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
      - run: sudo apt-get update && sudo apt-get install yarn && yarn
      # Run optional required steps before releasing
      # - run: npm run build-script
      - run: yarn semantic-release

workflows:
  version: 2
  test_and_release:
    jobs:
      - build
      - deploy:
          requires:
              - build
      - release:
          requires:
            - build

This is the error:

Can someone help me?

try to run npm run build-storybook. I think it will give you better error message

Have similar issue, this repo only works with npm ?

If it builds your storybook before deploying, it uses npm, even if you used yarn to run the deploy-storybook command.  Since I'm using nvm this causes other issues :-(


[Vmware/NGC] Datastore creation from plugin fails on createVmfsDatastore API call

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

/kind feature

What happened:
Datastore creation from plugin fails in the API createVmfsDatastore vmware API with exception
com.sun.xml.internal.ws.fault.ServerSOAPFaultException: Client received SOAP Fault from server: A specified parameter was not correct: spec.vmfs.majorVersion

What you expected to happen:
Plugin should try to create datstore with different vmfs version , and the operation should succeed.
How to reproduce it (as minimally and precisely as possible):
Try Datastore creation on vcenter trial  Version <IP_ADDRESS>000 Build 14368061
Anything else we need to know?:
This is happening only on vcenter trial version installed setup.
Environment:

NBP version: v0.6.1
OS (e.g. from /etc/os-release):Windows
Kernel (e.g. uname -a):
Install tools:
Others:
vcneter version : Version <IP_ADDRESS>000 Build 14368061

fix delivered #307


add a blog post about NR flow layout best practice.

LGTM, must admit I didn't check the rendered version. But the content I've reviewed twice now. (Gdoc and this PR)


Ability to list parent directories as a way to add projects?

I've been looking for a way to declare a list of directories that contain my projects so that telescope-project can add all (git-enabled) subdirectories, instead of manually needing to add all projects?
Is there any way to do this?

Not currently @hahuang65 but I'll add this to the roadmap

How about utilizing Telescope file_browser and telescope-project is able to inject a mapping in this builtin.
Interface doesn't exist yet but i thought about enabling extensions to inject mappings for a while now.


:buildSrc:javaCompile takes a long time but only the first time

Expected Behavior
:buildSrc:javaCompile should be very fast and also the same speed each time when I specify no caching.
Current Behavior
When my CI server spins up and runs my compile task, the :buildSrc:javaCompile task takes around 1m to 3m even though the buildSrc doesn't have any java code at all. I can reproduce the problem locally but only the first time I ran Gradle (I actually can't make it happen again - not sure what to delete in order to try!)
On the local run where I experienced the issue I ran ./gradlew clean assemble resolve but subsequent runs do not exibhit the problem. I am now running ./gradlew --rerun-tasks --no-build-cache --no-configuration-cache clean assemble resolve and not seeing any issue.
Also, when I run a build scan the task is listed as "This task is not on the critical path." even though it clearly is by the total running time and the timeline view.
Context
I am building 4 related projects using a conventions plugin and on the CI server the first build is taking much longer than expected.
Steps to Reproduce

Have a project with a few parts to it using the java conventions plugin pattern https://docs.gradle.org/current/samples/sample_convention_plugins.html
Build it on a new Amazon Linux 2 machine
Given that I can't reproduce the problem more than once on a machine, I'm not sure how to build a reproducer.

Your Environment
https://scans.gradle.com/s/emw3kulolg3u2/timeline?details=t2suyaslk3rhy
Linux 4.14.248-189.473.amzn2.x86_64 (amd64)
Amazon.com Inc. OpenJDK 64-Bit Server VM 17.0.3+6-LTS (mixed mode, sharing)

I think I've reproduced it locally using rm -rf ~/.gradle/caches/7.4.2/
I will try to create a reproducer project.

@mjaggard Thanks for providing the test project.
I can reproduce a long delay in building the test project in itself. My test case, even for a dry-run clean:
time ./gradlew --dry-run --no-daemon --rerun-tasks --no-build-cache --no-configuratio
n-cache clean

which reports to:
BUILD SUCCESSFUL in 1m 10s
9 actionable tasks: 9 executed
real	1m 11.17s
user	0m 1.87s
sys	0m 0.24s

A second attempt is much quicker:
BUILD SUCCESSFUL in 6s
9 actionable tasks: 9 executed
real	0m 6.61s
user	0m 1.22s
sys	0m 0.11s

But if I delete the contents of ~/.gradle/caches, then we go back to much higher times.
which seems to show most of the time for that build is spent fetching dependencies. Stack dumps  during a slow build show the only threads doing interesting stuff are retrieving remote content.

I haven't retested but I found that deleting the gradle version specific cache was enough to reproduce the slow performance, which I think means it's not about downloads because the shared cache seems to keep the artefacts.

Sorry for taking so long to get back to you, @mjaggard. Here is a report of my findings from today.
I could only reproduce long running builds for the test project related to the :buildSrc:compileJava task after I made these changes:

made the test project have actually 9 subprojects
created additional 8 copies of the test project (each with their own 9 subprojects)
deleted the entire ~/.gradle/caches structure (if I deleted only the 7.4.2 subdir, builds would complete quite fast)
then started the Spring build, followed by the 8 builds of the test-project copies, all in background
as reported by the OP, next builds are much faster

Modified run-builds.sh:
#! /bin/bash

rm -rf ~/.gradle/caches/

cd spring-framework
./gradlew --parallel --no-daemon --rerun-tasks -Porg.gradle.caching=false --no-build-cache --no-configuration-cache assemble --dry-run --console=plain --scan &

#cd ../test-project
#./gradlew --parallel --no-daemon --rerun-tasks -Porg.gradle.caching=false --no-build-cache --no-configuration-cache assemble --dry-run --info --console=plain --scan &

cd ../test-project-A
./gradlew --parallel --no-daemon --rerun-tasks -Porg.gradle.caching=false --no-build-cache --no-configuration-cache assemble --dry-run  --info --console=plain --scan &

...

cd ../test-project-G
./gradlew --parallel --no-daemon --rerun-tasks -Porg.gradle.caching=false --no-build-cache --no-configuration-cache assemble --dry-run  --info --console=plain --scan &

Example build scans:

https://scans.gradle.com/s/zz3erfmuoe5t4
https://scans.gradle.com/s/ae5rjdzf27j2g
https://scans.gradle.com/s/2fv43ugan4poq
https://scans.gradle.com/s/45duxtgryixm6
https://scans.gradle.com/s/vob46ck63y4ie

This proves there is contention between multiple builds running on the same machine.
Actually, I could get long running builds of the test projects even if omitting the call to build Spring Framework.

https://scans.gradle.com/s/254lwvg3n2oac
https://scans.gradle.com/s/o6a5kagbu5k5k
https://scans.gradle.com/s/bw6cfgp3flynm

(with a little less init and config time appearing under :buildSrc:compileJava)
Running the same number of builds one after the other OTOH was quite faster (less than 2 mins). The first project takes longer as it bears the brunt of init'ing the structures under ~/.gradle/caches, and the remaining builds run typically at around 5s:

https://scans.gradle.com/s/rtrkuqovcrlqs (first project)
https://scans.gradle.com/s/smma33a7jja7s (the remaining projects)

Note though that those scans show 0 task execution time. I guess that is because they were run with --dry-run. If you look at the Switches section for the scan provided by the OP, that was not a dry run, had build cache enabled etc, so it is not an apples to apples comparison.
20747.out.txt

@mjaggard I will need further help to reproduce your scenario, and build scans that matches your test case run (which does not seem to be the case here). You are on to something here about running multiple builds in parallel on a brand new machine resulting in lots of contention and worse init/config time than if the same builds run one after the other. But the behavior I have seen is different from what you reported, which can be attributed to the difference configurations showing in your build scan switches section.

@abstratt This happens to us without fail since we refactored our multi-project build using pre-compiled script plugins. I can dm you build scan urls.

@abstratt https://scans.gradle.com/s/k4sr4dd4ljuva

@niels1voo Thanks. Do you trigger one or multiple Gradle build calls (for different projects)? If multiple, are they triggered in parallel? If multiple, but sequential, do you see a performance penalty in all of the calls, or only for the first gradle call?
It may be worthwhile opening a new bug request that more closely describes your scenario, even if later we discover to be the exact same issue as the OP was seeing.

@niels1voo Thanks. Do you trigger one or multiple Gradle build calls (for different projects)? If multiple, are they triggered in parallel? If multiple, but sequential, do you see a performance penalty in all of the calls, or only for the first gradle call?
It may be worthwhile opening a new bug request that more closely describes your scenario, even if later we discover to be the exact same issue as the OP was seeing.

Also, are the precompiled build scripts fetched from a remote repository? Or are they (or can they be made) available locally in the base Docker image?

Nope, you used the term correctly.

Sorry for the late reply.
As one of the latest build scans shows

this might be an issue with ABI computation for incremental java compilation.


at_c: use atclient_connection_read in atclient_get_atkeys

Currently, we have a fixed read buffer of 4096 bytes. If scan outputs a larger output of 4096 bytes, then not all keys will be captured in the read.
Therefore, we should use the new atclient_connection_read implementation where a maximum buffer size can be specified through atclient_get_atkeys_request_options

Making this P2 because atclient_get_atkeys currently won't work for large scans


Enhancing Feedback for Training Purposes

Presently, training feedback is provided by unchecking 'done' for traced nuclei. Adding the following columns to the Region Table with checkboxes will help provide more detailed feedback:

Undertraced
Overtraced
Add New Region
Remove Existing Region

These columns would be a 'first part' of this enhancement request and would be great to incorporate with several ninjas-in-training this week. The second part is a longer term request for the ability to provide additional text annotations (like a comment appended to a nucleus ID). This could be especially useful for training modules or future developments.

Adding 4 more columns might make the region table a bit too big on smaller displays. We could potentially switch out some of the other columns when in "training feedback mode". Are there any columns that would be less useful in this mode?
Alternately we could keep the width of the region table fixed, and add a horizontal scrollbar to show more columns.
Any other ideas?

@JustKeepClimbing, just wanted to make sure you saw the comment above.

Is a pop-out window possible which would include only the following? ID | Undertraced | Overtraced | Add to Slice | Remove ID
Maybe we can add 'Training' as an additional dropdown heading, and when the user checks 'Feedback' in the dropdown, the pop-out window with feedback appears. What do you think?

I would also like to add one more option to the pop-out window: Correct from Split / Merge, since there are occasional regions that I split / merge for a ninja-in-training that s/he later corrects.

I think that seems reasonable.

Initial version implemented


Move to UNUserNotification now that UILocalNotification is deprecated

Since the base SDK is iOS 10 these warnings are showing up in Xcode. Probably a good idea to move away from the deprecated methods.

It probably makes sense to wait for #172 and #170 before doing this. Not sure.

Yeah, I'll mess around with #170 this week.

Covered by #240


Make waiter initializers public for mocking

Describe the feature
Mocking in Swift requires an abstraction layer and then an object that implements SDK functions' signatures but uses and returns mock data. This mostly works fine, but I've discovered it doesn't work with waiters, because, for example, I need to be able to create an error in my mocked implementation of waitUntilBucketExists(). But the following gets me a compiler error telling me that "'WaiterOutcome' initializer is inaccessible due to 'internal' protection level".
    public func waitUntilBucketExists(options: WaiterOptions,
                input: HeadBucketInput) async throws
                -> WaiterOutcome<HeadBucketOutputResponse> {
        let response = ClientRuntime.HttpResponse(
            statusCode: .ok
        )
        let output = try await HeadBucketOutputResponse(
            httpResponse: response
        )
        return WaiterOutcome<HeadBucketOutputResponse>(
            attempts: 1,
            result: .success(output)
        )
    }

Use Case
Mocking requires being able to create and return these types.
Proposed Solution
Make these types public.
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Shipped in AWS SDK for Swift 0.23.0


Returning Template Resource in TemplateDataResponse

Refactoring related to https://github.com/ignacio-chiazzo/ruby_whatsapp_sdk/issues/91.
Instead of returning templateData, TemplateDataResponse returns a Template.
The tests have not been implemented yet.

Thanks! this is exactly what I was looking for.
Are you planning to work on tests? I'm ok to merge it to the other branch now and work on test later; up to you.

Yes, I'm working on the tests now.

Thanks! this is exactly what I was looking for.
Are you planning to work on tests? I'm ok to merge it to the other branch now and work on test later; up to you.

I started working on the tests, but I won't have time to continue work this week, if you want to continue where I left off, feel free!

Thanks! I will merge it to the other branch and work on test separately


Strongly-typed S3 bucket website routingRules

I've been working on a program that adds some redirects for the GREAT WEBSITE MIGRATION OF 2019, and wished there were stronger types for this. Decided to go ahead and add these while it was fresh in my mind...
This augments the routingRules property to accept a strongly-typed array of objects, which helps to know which properties can be set and avoids the need to use JSON.stringify. This is especially helpful as some properties can only be set if other properties are not set.
Depends on a change in pulumi-terraform to allow JSON arrays in TransformJSONDocument: https://github.com/pulumi/pulumi-terraform/pull/393
Details:
https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#routing_rules
https://docs.aws.amazon.com/AmazonS3/latest/dev/how-to-page-redirect.html#advanced-conditional-redirects (scroll down for schema)

TBH, it feels a little overboard on trying to be typesafe instead of just having a single bag with a few optional properties that we just check that at least one is set...

Feedback addressed (using simpler TypeScript types and just documenting that at least one property must be set). Cleaned up the commit and adding one to use the latest pulumi-terraform with the necessary changes.

Travis PR test failure:
[ umi/pulumi-aws/examples/bucket ] Invoke '/home/travis/.pulumi/bin/pulumi preview --non-interactive' failed: exit status 255

[ umi/pulumi-aws/examples/bucket ] Previewing update (moolumi/p-it-travis-job-bucket-08395507):

[ umi/pulumi-aws/examples/bucket ]

[ umi/pulumi-aws/examples/bucket ]  +  pulumi:pulumi:Stack bucket-p-it-travis-job-bucket-08395507 create

[ umi/pulumi-aws/examples/bucket ] @ Previewing update.......

[ umi/pulumi-aws/examples/bucket ]  +  pulumi:providers:aws prov create

[ umi/pulumi-aws/examples/bucket ]     aws:s3:Bucket websiteBucket  error: could not validate provider configuration: 1 error occurred:

[ umi/pulumi-aws/examples/bucket ]     aws:s3:Bucket websiteBucket  1 error

[ umi/pulumi-aws/examples/bucket ]

[ umi/pulumi-aws/examples/bucket ] Diagnostics:

[ umi/pulumi-aws/examples/bucket ]   aws:s3:Bucket (websiteBucket):

[ umi/pulumi-aws/examples/bucket ]     error: could not validate provider configuration: 1 error occurred:

[ umi/pulumi-aws/examples/bucket ]     	* : invalid or unknown key: env_region

[ umi/pulumi-aws/examples/bucket ]

[ umi/pulumi-aws/examples/bucket ] Permalink: https://app.pulumi.com/moolumi/bucket/p-it-travis-job-bucket-08395507/previews/c95af275-a963-49b2-b85f-7c1e0f427f41

@CyrusNajmabadi, this looks related to the change you made in #614. Is this a bug or just a point-in-time thing that will be fixed-up subsequently?

@justinvp No.  you'll need to update any test you've created to make and pass along an explicit provider resource.  This is intentional so we can validate all our code works with non-default providers.  I can provide more info if you need it. However, you can also look at our other tests to see how this is done.

@stack72, this should be ready for a final review, FYI, if you'd like to take a look.

This LGTM! Thanks for this change @justinvp - a lot of interaction here for you to have had to drive though so 🥇


Fix/use rust crypto pr

Simple cargo update

@cronokirby - ack, pushed this to the wrong place.  Cancelling!


Strange behavior generating to a existing directory

🐛 Bug report
Describe the bug
When doing wrangle generate to a existing directory test, the behavior is strange. A TOML file is written to the existing directory but with the name field test-1. Everything other, plus another TOML file is written to a new directory test-1 but with the name field helloworld. The newly created directory's TOML's type field is also wrong.
Reproduce the bug
$ wrangler -V
wrangler 1.19.1
$ mkdir wrangler
$ cd wrangler
$ mkdir test
$ wrangler generate --type=webpack test
 Creating project called `test-1`...
 Done! New project created /home/Menci/wrangler/test-1
$ find
.
./test
./test/wrangler.toml
./test-1
./test-1/.gitignore
./test-1/.prettierrc
./test-1/CODE_OF_CONDUCT.md
./test-1/LICENSE_APACHE
./test-1/LICENSE_MIT
./test-1/README.md
./test-1/index.js
./test-1/package.json
./test-1/wrangler.toml
./test-1/.cargo-ok
./test-1/.git
<.git sub-directories omitted>
./test-1/.git/HEAD
$ cat ./test/wrangler.toml
name = "test-1"
type = "webpack"
route = ''
zone_id = ''
usage_model = ''
compatibility_flags = []
workers_dev = true
$ cat ./test-1/wrangler.toml
name = "helloworld"
type = "javascript"

account_id = ""
workers_dev = true
route = ""
zone_id = ""

Expected behavior
Wrangle should deny generating to a existing non-empty directory and success generating to a existing empty directory.
Environment and versions
Fill out the following information about your environment.

operating system: Manjaro Linux
output of wrangler -V: wrangler 1.19.1
output of node -v: v16.7.0

Hi @Menci  -
Thanks for reporting this. We'll do some further investigating.


Support merging multi providers into one artifact

I have several providers, and I want to subscribe them via a single url.
If it can be like the following, it might be better.
{
      name:'clash.yaml',
      template:'clash',
      provider: [ 'provider_1', 'provider_2' ]
}

I have several providers, and I want to subscribe them via a single url.
If it can be like the following, it might be better.
{
      name:'clash.yaml',
      template:'clash',
      provider: [ 'provider_1', 'provider_2' ]
}

you can add as recipe like this:
name: 'Clash.yml',       template: 'clash',       provider: 'shadowsocks',       recipe: ['shadowsocks','v2rayn','blinkload'],

It work! But  what is recipe different from provider?

@sorcererxw I might bring changes to the API in the future, so the feature is undocumented.

@geekdada Thx


regulation terms for GO:0007465 R7 cell fate commitment

Could I request positive/negative regulation terms for:
GO:0007465	R7 cell fate commitment
regulation of R7 cell fate commitment
Def: Any process that modulates the frequency, rate or extent of R7 photoreceptor cell fate commitment.
positive regulation of R7 cell fate commitment
Def: Any process that activates or increases the frequency, rate or extent of  R7 photoreceptor cell fate commitment.
negative regulation of R7 cell fate commitment
Def: Any process that stops, prevents, or reduces the frequency, rate or extent of  R7 photoreceptor cell fate commitment.
Ref for all:
PMID:22878552
GOC:ha

Somehow lost in email notice
+id: GO:0106396
+name: regulation of R7 cell fate commitment
+id: GO:0106397
+name: positive regulation of R7 cell fate commitment
+id: GO:0106398
+name: negative regulation of R7 cell fate commitment


Support emoji IMEs in the terminal

Right now the Windows emoji IME (win+.) seems to work fine but the macOS one does not (ctrl+cmd+space).
Upstream: https://github.com/xtermjs/xterm.js/issues/469
Related https://github.com/microsoft/vscode/issues/35266

🤩 great work! 🥳

🤩 great work! 🥳


BucketModel predict

Hello, I use bucketmodel for variable length squence, I have train a model(batch size is 50), but when I want forward, I can't change the batch size(For example, I want batch size is 1). How can I do it?

@pluskid

@MonkeyTang Yes currently the batch size cannot be changed even between different buckets due to an implementation limit that seem to be easy to change (see here, where the slices for data-parallelism is pre-computed and re-used for all buckets, so all of them must have the same batch size). Can you describe your use case? Do you need different batch size for training and testing? Or you need different batch size even during only the training stage?

Thank you, I need different batch size for training and testing, the batch size of training is same.

@MonkeyTang OK, then it is an easy case: you can just force rebind the module. And thanks for fixing the bug. Since it seems that you are now able to get it working properly, I am closing this issue. Please feel free to reopen this if needed. Thanks again!


Make compatible with Landsat Collection 2

Thanks for developing this nice toolbox for running SEBAL in GEE, it is very useful for remote sensing applications.
Collection 1 is now retired in GEE so the toolbox does not work anymore. The changes between Landsat Collection 1 and Collection 2 are documented in this GEE page https://developers.google.com/earth-engine/landsat_c1_to_c2 as well as in the USGS documentation.
Azeem Khan and myself from the Remote Sensing team at the NSW Department of Climate Change, Energy, Environment and Water edited the toolbox to work with Collection 2 and tested it to make sure it was producing the same results.
The following changes were applied :

point to Landsat Collection 2 in GEE collections
update metadata fields with the new fields (LANDSAT_PRODUCT_ID, SPACECRAFT_ID, SUN_ELEVATION)
update the band numbers to match the new organisation of the bands
apply the new scaling factors for optical and thermal bands (and remove old scaling by 10000 and 10)
update cloud masking based on new QA bits in Collection 2

We computed Evaporative Fraction (EF) using the existing Collection 1 toolbox and the new Collection 2 toolbox for an area in Australia and found negligible differences (of the order of 1-2%).

We hope this pull request helps users continue using the toolbox with Landsat Collection 2.
Kilian Vos and Azeem Khan

I want to know "var i_q_med in era5 = ee. ImageCollection (' projects/et - brasil/assets/ERA5 / hourly / 1030 / specific_humidity '), select (' specific_humidity) "should be input in what kind of A file? Can you give me an example?


ValueError: Error raised by inference API HTTP code: 500, {"error":"failed to generate embedding"}

          ValueError: Error raised by inference API HTTP code: 500, {"error":"failed to generate embedding"}

still I'm getting with the latest ollama docker

Hi folks this should be fixed now - please let me know if that's not the case

@jmorganca
only with the llama/ollama:0.1.32 version it works,
doesn't work with 0.1.28,37 and latest(as far as I checked)
Randomly it works, but most of the time fails
@mchiang0610, do you have any idea how to fix this?
Originally posted by @uzumakinaruto19 in https://github.com/ollama/ollama/issues/1577#issuecomment-2126700878

I'm getting the same error

I'm suffering this problem too.
After narrow down docker version, I can confirm that only the version before 0.1.32 can work normally in embedding time. Otherwise the latest layer to embedding can always get HTTP 500 error.

This seems like a problem in langchain? It should use the /api/embed endpoint and not /api/embeddings.
You can try it with:
curl http://localhost:11434/api/embed -d '{
  "model": "all-minilm",
  "input": "Why is the sky blue?"
}'

Also, you should check out the ollama python client. I have updated the README there to show how to use the new endpoint.

same problem here, running Docker container with ollama/ollama image.
2024-11-10 12:18:04 goroutine 54 gp=0x400020c540 m=nil [IO wait]: 2024-11-10 12:18:04 runtime.gopark(0x0?, 0x0?, 0x0?, 0x0?, 0x0?) 2024-11-10 12:18:04     runtime/proc.go:402 +0xc8 fp=0x40000a7550 sp=0x40000a7530 pc=0xaaaab8191008 2024-11-10 12:18:04 runtime.netpollblock(0x0?, 0xffffffff?, 0xff?) 2024-11-10 12:18:04     runtime/netpoll.go:573 +0x158 fp=0x40000a7590 sp=0x40000a7550 pc=0xaaaab8189468 2024-11-10 12:18:04 internal/poll.runtime_pollWait(0xffff9c617eb0, 0x72) 2024-11-10 12:18:04     runtime/netpoll.go:345 +0xa0 fp=0x40000a75c0 sp=0x40000a7590 pc=0xaaaab81bed80 2024-11-10 12:18:04 internal/poll.(*pollDesc).wait(0x40001ae080?, 0x400010f571?, 0x0) 2024-11-10 12:18:04     internal/poll/fd_poll_runtime.go:84 +0x28 fp=0x40000a75f0 sp=0x40000a75c0 pc=0xaaaab820e728 2024-11-10 12:18:04 internal/poll.(*pollDesc).waitRead(...) 2024-11-10 12:18:04     internal/poll/fd_poll_runtime.go:89 2024-11-10 12:18:04 internal/poll.(*FD).Read(0x40001ae080, {0x400010f571, 0x1, 0x1}) 2024-11-10 12:18:04     internal/poll/fd_unix.go:164 +0x200 fp=0x40000a7690 sp=0x40000a75f0 pc=0xaaaab820f240 2024-11-10 12:18:04 net.(*netFD).Read(0x40001ae080, {0x400010f571?, 0x0?, 0x0?}) 2024-11-10 12:18:04     net/fd_posix.go:55 +0x28 fp=0x40000a76e0 sp=0x40000a7690 pc=0xaaaab8275978 2024-11-10 12:18:04 net.(*conn).Read(0x40001b0008, {0x400010f571?, 0x0?, 0x0?}) 2024-11-10 12:18:04     net/net.go:185 +0x34 fp=0x40000a7730 sp=0x40000a76e0 pc=0xaaaab827f444 2024-11-10 12:18:04 net.(*TCPConn).Read(0x0?, {0x400010f571?, 0x0?, 0x0?}) 2024-11-10 12:18:04     <autogenerated>:1 +0x2c fp=0x40000a7760 sp=0x40000a7730 pc=0xaaaab828ac3c 2024-11-10 12:18:04 net/http.(*connReader).backgroundRead(0x400010f560) 2024-11-10 12:18:04     net/http/server.go:681 +0x40 fp=0x40000a77b0 sp=0x40000a7760 pc=0xaaaab8366f50 2024-11-10 12:18:04 net/http.(*connReader).startBackgroundRead.gowrap2() 2024-11-10 12:18:04     net/http/server.go:677 +0x28 fp=0x40000a77d0 sp=0x40000a77b0 pc=0xaaaab8366e38 2024-11-10 12:18:04 runtime.goexit({}) 2024-11-10 12:18:04     runtime/asm_arm64.s:1222 +0x4 fp=0x40000a77d0 sp=0x40000a77d0 pc=0xaaaab81c4604 2024-11-10 12:18:04 created by net/http.(*connReader).startBackgroundRead in goroutine 24 2024-11-10 12:18:04     net/http/server.go:677 +0xc8 2024-11-10 12:18:05 time=2024-11-10T11:18:05.015Z level=ERROR source=routes.go:453 msg="embedding generation failed" error="do embedding request: Post \"http://<IP_ADDRESS>:38233/embedding\": EOF"
@pdevine which is the latest version of Langchain working, in you opinion?
Reformulating the question: when (and if) has api/embed to api/embeddings changed?


add promise support

It would be nice to have Promise support instead of callbacks, here is what I'm using to monkey-patch it in, would be a lot easier if it was supported natively :)
waitForPlayers should be rather named waitForDiscovery or something (or the getPlayer() / getPlayerByUUID() should be async, too)
Additionally I add a Player.getGroup() function that returns all players in that group.
// monkey patch: wait for discovery to complete
Sonos.prototype.waitForPlayers = async function() {
    var self = this;
    if (Object.keys(this.players).length == 0) {
        await new Promise((resolve, reject) => {
            self.on('topology-change', (rooms) => {
                resolve();
            });
        });
    }
};

// monkey patch: get Player prototype and promisify
(() => {
    var promisify = (proto, name) => {
        var old = proto[name];
        proto[name] = function(...args) {
            var self = this;
            return new Promise((resolve, reject) => {
                args.push((error, result) => {
                    if (error) {
                        reject(error);
                    } else {
                        resolve(result);
                    }
                });
                old.apply(self, args);
            });
        }
    };
    var patch = (Player) => {
        patch = undefined;
        Player.prototype.getGroup = function() {
            var r = [];
            for (var uuid in this.discovery.players) {
                var player = this.discovery.players[uuid];
                if (player.coordinator.uuid != this.uuid) continue;
                r.push(player);
            }
            return r;
        };
        // Player.prototype.inspect = function() {
        //     return 'sonos.Player<' + this.uuid + ',' + this.roomName + '>';
        // };
        var proto = Player.prototype;
        for (let k in proto) {
            if (typeof proto[k] !== 'function') continue;
            let argnames = proto[k].toString().split('{')[0].split('(')[1].split(')')[0].split(',').map(x => x.trim());
            let i = argnames.indexOf('callback');
            if (i < 0) continue;
            if (k == 'groupSetVolume') continue; // buggy upstream.
            let old = proto[k];
            proto[k] = function(...args) {
                let self = this;
                if (!args[i]) {
                    return new Promise((resolve, reject) => {
                        args[i] = (error, result) => {
                            if (error) {
                                reject(error);
                            } else {
                                resolve(result);
                            }
                        };
                        old.apply(self, args);
                    });
                }
                return old.apply(self, args);
            };
        }
    };
    var _getPlayer = Sonos.prototype.getPlayer;
    Sonos.prototype.getPlayer = function(...args) {
        var res = _getPlayer.apply(this, args);
        if (patch && res) patch(res.constructor);
        return res;
    };
    var _getPlayerByUUID = Sonos.prototype.getPlayerByUUID;
    Sonos.prototype.getPlayerByUUID = function(...args) {
        var res = _getPlayerByUUID.apply(this, args);
        if (patch && res) patch(res.constructor);
        return res;
    };
})();

I'm actually in the midst of rewriting it completely to be promised based.
There is a branch available if you want to check it out.

I have now merged the promise based version. Haven't implemented waitForPlayers, and getPlayer is still synchronous atm.


Add source is iterable support

Sometimes we want use only processors avoid loading and parsing (for example bigquery/sql integrations can be improved to support dict data in import_resource function without boilerplate code after feature will be implemented).

This is a bit like adding file-like support right?

I mean pass into tabulator just python list for example we need to apply processors on:
[('id1', 'value1'), ('id2', 'value2')] -> processed by processors.Schema etc -> ...
It's kinda the last basic format tabulator doesn't support for now because we already support:

standard
text (load and parse from memory)
stream (avoid loading)

Ok got it, and I see the need. So, you probably intend so, but def. not only lists but also probably generators and any iterable that emits similar data (dicts or key-value pairs).

+1
I suppose I see how it can be implemented without any hack.

I'm about to finish - will be really helpful for https://github.com/frictionlessdata/jsontableschema-py/issues/78


Backport recent fixes to 1.. and 2..

Recent correctness fixes have only been released in version series 3.*.* but they are also applicable to historical versions too. They should be backported and released too.

Completed. We now have v1 and v2 and latest npm tags to track the different active versions.


New theme request: Code::Blocks and KDE Themes

GTK theme works well with GNOME, but an official KDE global theme would be awesome.
I'm also surprised Dracula doesn't have official support for Code::Blocks theme.

Hey @huoi, do you want to give it a try and create those themes?
Here are the instructions on how to create a theme: https://draculatheme.com/contribute

This is already built and added to the Dracula Theme organization, so I will close this Issue. 🦇


ElementHex2

The next element to be added under #23 is probably the 27-node quadratic three-dimensional ElementHex2.
Quadratic hexahedral elements were recommended over ElementHex1 by Benzley et al (1995), as consulted in #75.

The use of quadratic displacement formulated finite elements significantly improve the
performance of the tetrahedral as well as the hexahedral elements.

ElementHex2 will also be required for Taylor–Hood element for Stokes or Navier–Stokes problems on a MeshHex.

I'm now looking into implementing the p-version of the finite element method in scikit-fem, starting with ElementQuadP for arbitrary order. I'll probably change the reference element used for quads and hexes (from (-1, 1)^d to (0, 1)^d) because the book I'm using as a reference uses those and it seems that the notation for the basis functions will be slightly more concise.
Just a remark in case you already started working on this.

Great! As in potentially different p in each cell? Very exciting.
Which book?
+1 for relocating the tensorial elements to the first ray/quadrant/octant. I had briefly lamented when working in one dimension that the canonical line segment element was not both the one-dimensional simplex and the one-dimensional factor from which the quadrilateral and hexahedron are formed as products.

I'm now using Leszek Demkowicz books since I got a recommendation from a friend:
https://www.amazon.com/Computing-Hp-Adaptive-Finite-Elements-Vol/dp/1584886714
I'm also simultaneously studying the theory from
https://www.amazon.com/hp-Finite-Element-Methods-Applications/dp/0198503903

I'm not yet sure how $hp$-adaptivity would work in scikit-fem, but I'll know better after studying these books.


IRGen: Fix TypeInfo for witness_method SIL values.

@convention(witness_method) values were changed to carry a pointer to their source witness table, but the type info wasn't changed to match. Fixing this fixes rdar://problem/26268544.

@swift-ci Please test and merge

cc @swift-ci

cc @swiftix

@swift-ci Please test and merge

@swift-ci Please smoke test

The Linux failure looks unrelated—swiftpm's failing to find a Basic module of some sort. (cc @rballard @ddunbar)


'Skipping plantuml block' with plantuml block macro

Wanted feature
I would like to have my PlantUML-diagrams in seperate .puml-file, so I can reuse them in several documents. I first wrote a adoc with the plantuml inline and the works great.
After extracting an inline plantuml-diagram to a .puml-file and changing the adoc to use the plantuml block macro I get an error:
Skipping plantuml block macro. ENOENT: no such file or directory, open 'pumls/hello-world.puml'

Reproduced
I have a git repo, which demonstrates this issue:
https://github.com/mcbeelen/static-site-from-antora-with-search-and-diagrams/tree/broken/plantuml-block-macro

main-branch is working
broken/plantuml-block-macro is not working

Broken file is located at: docs/modules/ROOT/pages/index.adoc

Reading through the test code I found that the .puml-files will work if they are located in the partials-directory and not relative to the .adoc-file
It work both we an include in a block
[plantuml,class,svg,align="center"]
----
include::partial$plantuml/class-diagram.puml[]
----

As well as with the plantuml-block-macro work.
plantuml::partial$plantuml/sequence.puml[]

Note: The syntax with the plantuml-block-macro does NOT work in IntelliJ preview.
unable to render AsciiDoc document

org.asciidoctor.jruby.internal.AsciidoctorCoreException: org.jruby.exceptions.SystemCallError: (ENOENT) No such file or directory - asciidoctor: FAILED:

Failed to load AsciiDoc document - No such file or directory -

<<project_directory>>/docs/modules/ROOT/pages/partial$plantuml/sequence.puml

Question: Would you be willing to support relative includes where the .puml is located outside of the partial$-dir or do you prefer to have an update to the README?
@ggrossetie : Any thought on this?
I'll make a PR with an update to the README to reflect my findings.

Question: Would you be willing to support relative includes where the .puml is located outside of the partial$-dir or do you prefer to have an update to the README?

I don't think it's recommended to use relative paths in Antora (it defeats the purpose of resource IDs: https://docs.antora.org/antora/latest/page/resource-id/#important)


No module named 'g2pNp2g_simple'

Khi thực hiện run repos, tôi đã gặp một lỗi No module named 'g2pNp2g_simple'
Tôi phải làm như thế nào để giải quyết vấn đề này đây.

Khi thực hiện run repos, tôi đã gặp một lỗi No module named 'g2pNp2g_simple'
Tôi phải làm như thế nào để giải quyết vấn đề này đây.

bạn comment bỏ dòng đó đi. k cần import nữa là được nhé

Tôi đã gặp một vắn đề khác ModuleNotFoundError: BeamSearchDecoderWithLM requires the installation of ctc_decoders from nemo/scripts/install_decoders.py.
Tôi phát hiện ra rằng không có đường dẫn nào như vậy. Tôi nghĩ nó phải là nemo/scripts/install_decoders.sh
Tôi đã cố gắng cài đặt nó bằng cách bash nemo/scripts/install_decoders.sh hoặc sh nemo/scripts/install_decoders.sh.
Tuy nhiên tôi đã không thể khắc phục được vấn đề đó, tôi vẫn gặp lỗi ModuleNotFoundError: BeamSearchDecoderWithLM requires the installation of ctc_decoders from nemo/scripts/install_decoders.py
Tôi phải làm như thế nào đây.

I am not able to understand what you are talking about, but I got the same error messages. I spent about 7 hours of solving that issue and preparing dockerfile where I can run the model. I will share it after it is working perfectly.
@dangvansam98 Btw, many thanks for the model. If this is a demo are you thinking of making version 2 of it? Also if you have any suggestions for different speech2text or speech2vec models for VN I will be grateful! I would like to stay in contact, but I am afraid my background is stronger in ML rather than NLP.

Oh god, I built KenLM in docker about 15 times, it was painful, but I am finally able to set the environment for your model properly in docker. Now, I am preparing Dockerfile with https://github.com/PaddlePaddle/DeepSpeech as you have in your repo, looks like NeMo used this in scripts/install_decoders.sh as some kind of temporal solution, but I didn't know that until I found https://gitlab.nrp-nautilus.io/ar-noc/nemo/-/blob/master/scripts/install_decoders.sh, which is NeMo at v0.9.0. You have NeMo v0.10.0 in repo.
Now I have options

create setup with NeMo v0.10.0 as it is in your local setup
to try to setup it with NeMo latest, because I saw this notebook https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Offline_ASR.ipynb where they use https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/install_beamsearch_decoders.sh to install ctc_decoders

I will go for now with the updated version of NeMo, because there is probably no reason to do otherwise.

I am unable to create the exact same environment as you created in nemo folder, could you provide versions of python packages you have installed in connection with this folder?

This issue helped me to resolve _swig_decoders missing error from ctc_decoders_test.py from a newer version of NeMo (v1.5.3 to this date). The issue happens to be also, that while running python setup.py it doesn't install ctc_decoders globally. Copying decoders/build/lib.linux-x86_64-3.8/_swig_decoders.cpython-38-x86_64-linux-gnu.so into decoders folder solved this issue and while installing in docer pip install . has to be used rather than python setup.py.
https://github.com/PaddlePaddle/PaddleSpeech/issues/421
I think I am going to fork this repo and prepare everything there so that it can be installed locally and in docker.

Alright, this is Dockerfile for running this model on CPU. You can use it in order to make some kind of Installation.md instructions.

RUN rm -rf OpenSeq2Seq

# copy of install_beamsearch_decoders.sh
WORKDIR /home/root/speech2text/NeMo/scripts/asr_language_modeling/ngram_lm/decoders
RUN git clone https://github.com/kpu/kenlm.git
RUN wget http://www.openfst.org/twiki/pub/FST/FstDownload/openfst-1.6.3.tar.gz
RUN tar -xzvf openfst-1.6.3.tar.gz
RUN git clone https://github.com/progschj/ThreadPool.git

WORKDIR /home/root/speech2text/NeMo/scripts/asr_language_modeling/ngram_lm/decoders/kenlm
RUN mkdir build
WORKDIR /home/root/speech2text/NeMo/scripts/asr_language_modeling/ngram_lm/decoders/kenlm/build
RUN cmake ..
RUN make -j

WORKDIR /home/root/speech2text/NeMo/scripts/asr_language_modeling/ngram_lm/decoders/
# python setup.py doesn't work properly in docker
RUN pip install .
# _swig_decoders missing error while importing ctc_decoders
RUN cp build/lib.linux-x86_64-3.8/_swig_decoders.cpython-38-x86_64-linux-gnu.so .
RUN python ctc_decoders_test.py

WORKDIR /home/root/speech2text/demo_vietasr
# seems like it works with v1.5.1, also it installs all needed packages
# but we still have to use the locally cloned repo in demo_vietasr
RUN pip install nemo_toolkit[all]==1.5.1
RUN sed -i "s/placement=nemo.core.DeviceType.GPU,/placement=nemo.core.DeviceType.CPU,/g" infer.py
RUN sed -i "s/lm_path=\"NeMo/lm_path=\"nemo/g" infer.py

I am getting this error while trying to use latest stable NeMo
Traceback (most recent call last):
  File "model_test.py", line 3, in <module>
    from infer import restore_model, load_audio
  File "/home/root/speech2text/demo_vietasr/infer.py", line 7, in <module>
    from nemo.backends.pytorch.nm import DataLayerNM
ModuleNotFoundError: No module named 'nemo.backends'

I found out that there are no backends after v1.0.0 of NeMo and no DataLayerNM class, it was probably some kind of temporal solution. Probably it would be better to just stick to your clone of NeMo in the repository.
Also, I found out that apex can be cloned and installed locally as you probably did yourself. Also, when left in the repo, it just works.

I am getting this error while trying to use latest stable NeMo
Traceback (most recent call last):
  File "model_test.py", line 3, in <module>
    from infer import restore_model, load_audio
  File "/home/root/speech2text/demo_vietasr/infer.py", line 7, in <module>
    from nemo.backends.pytorch.nm import DataLayerNM
ModuleNotFoundError: No module named 'nemo.backends'

I found out that there are no backends after v1.0.0 of NeMo and no DataLayerNM class, it was probably some kind of temporal solution. Probably it would be better to just stick to your clone of NeMo in the repository.
Also, I found out that apex can be cloned and installed locally as you probably did yourself. Also, when left in the repo, it just works.

I apologize for the issue you were having; I haven't had time to update the repository I built for a very long time. I've currently upgraded to the most recent version, which fixes the issues that users had with installation and testing.


To update the Group logo from a file placed in SP Site

I'm trying to update a Team site logo from a image file placed in the same site.
Is this possible via Set-PnPUnifiedGroup?
I've tried something like this-
Set-PnPUnifiedGroup -Identity $group -GroupLogoPath "https://***sharepoint.com/sites/ProjectSite/SiteAssets/GreenBlock.JPG"

Hello @yahookevin Kevin, how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your issue with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @yahookevin Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


2FA not working

I can't log in cause there is no Two Factor Authorization Support in DiscordSharp :(

discordsharp outdated

So it's dead?

yes, https://github.com/NaamloosDT/DSharpPlus this is the successor

Would you update your app to use it?

no, i don't even have a Windows PC anymore. i'm full time OS X. if I ever decide to resurrect a PC again I may but as of right now I won't be.


[AVM Module Issue]:  Support for Flexible Server Database

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
(Optional) Module Version
No response
(Optional) Correlation Id
No response
Description
The Postgres DB should use the Terraform resource 'azurerm_postgresql_flexible_server_database'  instead of 'azurerm_postgresql_database'

https://github.com/Azure/terraform-azurerm-avm-res-dbforpostgresql-flexibleserver/pull/5

Duplicate https://github.com/Azure/terraform-azurerm-avm-res-dbforpostgresql-flexibleserver/issues/13


Swagger support in Azure Client Plugin

Library name
N/A
Please describe the feature.
We still need to support swagger input during the migration to TypeSpec for brownfield services since the migration progress might be long.
The general idea is to produce tspCodeModel.json from autorest.csharp(might be somewhere else since it will be deprecated). Then consume the output tspCodeModel.json in Azure Client Plugin.
So that, the main generation logic will be shared in Azure Client Plugin.

[ ] https://github.com/Azure/azure-sdk-for-net/issues/45740
[ ] https://github.com/Azure/azure-sdk-for-net/issues/45741

            M4                                       autorest.csharp(CodeModelConverter)                                           Azure Plugin

swagger -----> CodeModel.yaml --------------------------------------------------> tspCodeModel.json ------------------> SDK


Add --parallel-stmts flag to bank2

Using the new syntax introduced in https://github.com/cockroachdb/cockroach/pull/14188.

This change is

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

bank2/main.go, line 43 at r2 (raw file):

var contention = flag.String("contention", "low", "Contention model {low | high}.")
var balanceCheckInterval = flag.Duration("balance-check-interval", time.Second, "Interval of balance check.")
var parallelStmts = flag.Bool("parallel-stmts", false, "Should independent statements be run in parallel?")

"Run independent statements in parallel." apparently there are periods on these flags.

bank2/main.go, line 116 at r2 (raw file):

				suffix = ` RETURNING NOTHING`
			}
			insert := fmt.Sprintf(`INSERT INTO transaction (id, txn_ref) VALUES ($1, $2)%s;`, suffix)

you don't need these semicolons, so this can just be
insert := "INSERT INTO transaction (id, txn_ref) VALUES ($1, $2)"
update := "UPDATE account SET balance = $1 WHERE id = $2"
if *parallelizeStmts {
  insert += " RETURNING NOTHING"
  update += " RETURNING NOTHING"
}

bank2/main.go, line 132 at r2 (raw file):

				return err
			}
			writeDuration = time.Since(startWrite)

is this just a drive by fix?

Comments from Reviewable

TFTR.

Review status: 1 of 2 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

bank2/main.go, line 43 at r2 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
"Run independent statements in parallel." apparently there are periods on these flags.

Done.

bank2/main.go, line 116 at r2 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
you don't need these semicolons, so this can just be
insert := "INSERT INTO transaction (id, txn_ref) VALUES ($1, $2)"
update := "UPDATE account SET balance = $1 WHERE id = $2"
if *parallelizeStmts {
  insert += " RETURNING NOTHING"
  update += " RETURNING NOTHING"
}

Done.

bank2/main.go, line 132 at r2 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
is this just a drive by fix?

No, it's needed now because when using RETURNING NOTHING all of the writes will be asynchronous so we can't properly time them unless we wait for them all to synchronize on COMMIT.

Comments from Reviewable

Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Add info on Account Roles and device management

Information on Account Roles and how it relates to device management was added, based of of existing information from the Team based access page.
The information will need to be verified.
QA steps: Ran linter. Checked rendered output.
This commit addresses FFTK-2603
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
This is a basic attempt at addressing the issue, we may want to make additional changes.
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[x] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[x] Review for wordiness
[x] Match tone and style of page/section.
[x] Run make linkcheck.
[x] View HTML in a browser to check rendering.
[x] Use semantic newlines.
[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Comments
This should be verified to make sure all the information is correct.

Docs for d71aad5d694ec78b24e71ba65d04b258f52c4a8b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2333/docs/artifacts/html/index.html

Docs for 2161dd9a2d95d3e9b8c2c9c0fad258e9ca41d888 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2334/docs/artifacts/html/index.html


Would be good to support assigning error codes.

Consider supporting error codes, i.e.:
#[derive(Debug, thiserror::Error)]
pub enum Error {
    #[error("foo: {0}")]
    Foo(String) = 1,
    #[error("bar: {0}")]
    Bar(String) = 2,
}

I would prefer not to build this into this crate, but feel free to make a different library for this.


feature request: use numeric instead of lexicographical sort for multiple-file export

By default, Obsidian displays filenames sorted like this:

The problem is when I right click the parent folder -> export folder to pdf, it renders the files ordered lexicographically:
So the files are in the order of lecture 1, lecture 10, lecture 11, ..., lecture 18, lecture 19, lecture 2, lecture 20, lecture 21, ...
Let me know if this sounds like something we could change and I can submit a PR

Thank you for your feedback. The natural sorting is indeed unfriendly to your question.  Currently, This problem can only be solved by customizing the export page. If you want to solve this problem more flexibly, you can add a configuration to define the sorting function. If you are interested, welcome to submit a PR.


Offer factory plus test

Description:
Add offer factory
New imports / dependencies:
Unit Tests:

apps/volontulo/tests/views/test_auth.py

What tests do I need to run to validate this change:
Description of testing workflow and potential affected places.

Codecov Report

Merging #753 into master will increase coverage by 0.01%.
The diff coverage is 93.18%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   91.69%   91.71%   +0.01%
==========================================
  Files          93       93
  Lines        2781     2823      +42
  Branches        6        6
==========================================
+ Hits         2550     2589      +39
- Misses        224      227       +3
  Partials        7        7

Impacted Files
Coverage Δ

backend/apps/volontulo/tests/test_factories.py
100% <100%> (ø)
:arrow_up:

backend/apps/volontulo/factories.py
95.94% <91.89%> (-4.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a4824...4e6f114. Read the comment docs.


DPA data mover CRD update for batching

Codecov Report
Base: 33.79% // Head: 33.79% // No change to project coverage :thumbsup:

Coverage data is based on head (7ece1c1) compared to base (1200dc8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   33.79%   33.79%
=======================================
  Files          17       17
  Lines        3128     3128
=======================================
  Hits         1057     1057
  Misses       1979     1979
  Partials       92       92

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/retest

/retest

Any thoughts on adding CRD validation markers? https://github.com/eemcmullan/oadp-operator/pull/2

rip

Step operator-e2e-gcp-e2e succeeded after 47m20s.
INFO[2023-01-26T22:08:47Z] Step phase test succeeded after 47m20s.
...
deprovisioning failed

/override 4.11-operator-e2e-gcp
technically e2e succeeded.

/override ci/prow/4.11-operator-e2e-gcp


Documentation is out of date

The README.md is no longer reflective of changes that seem to have been made in the past few days. I can see the pull request that was merged suggests a "massive refactor"... it would be quite useful to know what has actually changed and how to update my code.

Sure. I will increment major version and push a new release asap. Docs and examples will be updated.


gulp e2e.watch and gulp watch.demos commands are not working as said in CONTRIBUTING.md doc

Short description of the problem:
The e2e.watch and gulp watch.demos commands are not working in RC0.
Also the e2e.watch command signature is not well documented (needs a -f componentname argument).
What behavior are you expecting?
To be executed successfully.
Steps to reproduce:

Clone the ionic repo.
Run npm install
Run gulp e2e.watch -f componentname (i.e. gulp e2e.watch -f checkbox)
Run gulp watch.demos command.

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
This is an example shell session:
$ gulp watch.demos
[00:40:09] Using gulpfile ~/src/ionic-msaelices/gulpfile.js
[00:40:09] Task 'watch.demos' is not in your gulpfile
[00:40:09] Please check the documentation for proper gulpfile formatting

$ gulp e2e.watch -f checkbox
[00:35:51] Using gulpfile ~/src/ionic-msaelices/gulpfile.js
[00:35:51] Starting 'e2e.copyExternalDependencies'...
[00:35:51] Finished 'e2e.copyExternalDependencies' after 6.51 ms
[00:35:51] Starting 'e2e.sass'...
[00:35:51] Starting 'e2e.fonts'...
[00:35:51] Finished 'e2e.fonts' after 27 ms
[00:35:52] Finished 'e2e.sass' after 1.81 s
[00:35:52] Starting 'e2e.watch'...
[00:35:53] 'e2e.watch' errored after 169 ms
[00:35:53] Error: Cannot find module '../../e2e/webpack.config.js'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at e2eWatch (/home/msaelices/src/ionic-msaelices/scripts/gulp/tasks/e2e.ts:259:18)
    at Gulp.<anonymous> (/home/msaelices/src/ionic-msaelices/scripts/gulp/tasks/e2e.ts:245:5)
    at module.exports (/home/msaelices/src/ionic-msaelices/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/msaelices/src/ionic-msaelices/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/msaelices/src/ionic-msaelices/node_modules/orchestrator/index.js:214:10)
    at /home/msaelices/src/ionic-msaelices/node_modules/orchestrator/index.js:279:18
    at finish (/home/msaelices/src/ionic-msaelices/node_modules/orchestrator/lib/runTask.js:21:8)
    at /home/msaelices/src/ionic-msaelices/node_modules/orchestrator/lib/runTask.js:52:4
    at f (/home/msaelices/src/ionic-msaelices/node_modules/end-of-stream/node_modules/once/once.js:17:25)
    at DestroyableTransform.onend (/home/msaelices/src/ionic-msaelices/node_modules/end-of-stream/index.js:31:18)
    at emitNone (events.js:72:20)
    at DestroyableTransform.emit (events.js:166:7)

Which Ionic Version? 1.x or 2.x
2.0-RC0

@msaelices  thanks! we are aware of this issue!
In the meantime, you can:
gulp e2e --folder component/test

and open the generated .html directly.

gulp e2e and gulp e2e.watch will now work. I haven't updated the demo task yet. Updated documentation here: https://github.com/driftyco/ionic/blob/master/scripts/README.md#building--running-e2e-tests

I updated the documentation and both the e2e and demo tasks should work fine now. Thanks!


import-azsentinelAlertRule error

This bug tracker is monitored by contributors and the community.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
installed ps6 and azsentinel powershell from wotell github. set subscription id and workspace id
Environment
prod
PowerShell version (if applicable):
6
Steps to reproduce
Expected behavior
the rules should be imported to sentinel workspace
i have used the set-Azsentinel to ensure im in the correct azcontext
Actual behavior
input
PS C:\Users\XXXXX\Downloads\sentinel-attack\detections> Import-AzSentinelAlertRule -WorkspaceName "XXXXXXX" -SettingsFile "sentinel_attack_rules.json"
result
`Import-AzSentinelAlertRule : Unable to connect to APi to get Analytic rules with message: The gateway did not receive a response from 'Microsoft.SecurityInsights' within the specified time period.
At line:1 char:1
+ Import-AzSentinelAlertRule -WorkspaceName "XXXXXXXX" -SettingsFile  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Import-AzSentinelAlertRule
`

i know this reeks of a permission issue but im stumped

Thanks for your feedback, set-azsentinel doesn't set your Azure context but enables Azure Sentinel on a existing Log analytics workspace.
Please check the following:

use set-azcontext to switch to the correct subscription or use the -subscription switch to provide the correct subscribtion where you have deployed and enabled Azure Log analytics and Azure sentinel
please see if you have permissions to access the log analytics workspace

I have just tested the module again and everything looks good from what I can see.
Please let me know if you need more help with this.
Greetings,
Pouyan

@ssi0202  please let me know if you need further assist, I am more than happy to help!

hi thanks for the beat back, i have not gotten it to work yet, but i'll try and get my azure "guru" to look at my commands tomorrow. I'm pretty sure it's at my end, just stomped. ;)

ok i fixed it.
i used this instead
Import-AzSentinelHuntingRule -WorkspaceName "XXXXXXl" -SettingsFile ".\sentinel_attack_rules.json"
so dont use the alert rule to import huntingrules. ;-)

thanks for the update, so you were using the import-azsentinelalertrule to import hunting rules? I will close this issue, please feel free to open new issue if you have any feedback, suggestion or question.

hi just to clearify
i was using Import-AzSentinelAlertRule to try and upload the files in the "detections" folder from the sentinel-attack github.
i can get everything running if i used the import-AzsentinelHuntingRule from this folder.
if i try to use the get-AzsentinelAlertRule or import-AzsentinelAlertRule this fails
below is the error when i try to get/list existing alertrules from the sentinel workspace
Get-AzSentinelAlertRule -WorkspaceName "XXXXXX"
Invoke-webrequest : {"error":{"code":"GatewayTimeout","message":"The gateway did not receive a response from 'Microsoft.SecurityInsights' within the specified time period."}}
At C:\Users\ssi.admin\Documents\PowerShell\Modules\AzSentinel\0.6.1\AzSentinel.psm1:365 char:23

... lertRules = Invoke-webrequest -Uri $uri -Method get -Headers $script: ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (Method: GET, Reques\u2026PowerShell/6.2.3
}:HttpRequestMessage) [Invoke-WebRequest], HttpResponseException
FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
ConvertFrom-Json : Cannot bind argument to parameter 'InputObject' because it is null.
At C:\Users\ssi.admin\Documents\PowerShell\Modules\AzSentinel\0.6.1\AzSentinel.psm1:366 char:56
... ite-Verbose "Found $((($alertRules.Content | ConvertFrom-Json).value) ...

                                             ~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidData: (:) [ConvertFrom-Json], ParameterBindingValidationException
FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.ConvertFromJsonCommand

if I use the corresponding command for huntingrules everything works fine, same with importing the sentinel-attack rules as huntingrules. which really puzzels me

hi @ssi0202  thanks for the update, which version of the AzSentinel module are you using? please try version 0.6.1 this one includes some bug fixes.
Can you also share your json file so that we can take a look at it?

hi thanks for getting back to me.
i reimported the azsentinel module below is the version nr
Get-Module azsentinel

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.6.1      AzSentinel                          {Get-AzSentinelAlertRule, Get-AzSentinelHuntingRule, Get-AzSentinelIncident, Import-AzSentinelAlertRule…}

sentinel_attack_rules - Copy_json.txt
i had to rename the json file til .txt to get it uploaded here. It's the one here
https://github.com/BlueTeamLabs/sentinel-attack/tree/master/detections

hi, so we do not know what happend, we litteraly tried again today with the exact  same commands and now it works. go ahead and close it. And thanks for making this public/sharing it in the first place

I am glad to hear that the problem is solved, please feel free to open new issue if you have any questions or feedback! Closing issue as requested


IRPane updates aren't reloaded in the project info

We need to track manual updates to the IR text such that any updates force reloading of the IR modules; this likely also needs a ctrl+s or Save option

We should probably resort to waiting for a "Save" or Ctrl-S command.  Otherwise, if we track the changes to the file (there is callback function for this) we could get into a weird state where the user has typed a bunch of stuff, but not yet finished describing a target node.

added a 'save file' attribute and functions to write the IR and reload the modules; 6f0b076

passed all devel tests


add hacbs release-service component and apiexport

Signed-off-by: Johnny Bieren<EMAIL_ADDRESS>

Depends on https://github.com/redhat-appstudio/release-service/pull/116

Depends on redhat-appstudio/release-service#116

I don't think so, redhat-appstudio/release-service#116 depends on this PR

@johnbieren @Michkov Do you know why the release-service component is added under components/hacbs, not components?  Because I notice it is mentioned the component is added like components/(component-name) in step 1 and 2 of https://github.com/redhat-appstudio/infra-deployments/#how-to-add-your-own-component, will be our components considered as hacba/* or other reason? Thank you!

@johnbieren @Michkov Do you know why the release-service component is added under components/hacbs, not components? Because I notice it is mentioned the component is added like components/(component-name) in step 1 and 2 of https://github.com/redhat-appstudio/infra-deployments/#how-to-add-your-own-component, will be our components considered as hacbs/* or other reason? Thank you!

@hongweiliu17 currently it's helper for APIExports templating, since some APIExports can have dependency on other APIExports which are not created yet, then they are pre-created just to generate IdentityHashes to be used by the APIExport. And for that I need to know that the service is HACBS so the APIExport is pre-created inside redhat-hacbs workspace.
Related magic code -> https://github.com/redhat-appstudio/infra-deployments/blob/4523b5821bbab53ec1c26bf8dc7181413cd86f20/hack/preview.sh#L96-L131

@Michkov can we merge this?


chore(package): update tap to version 10.2.1

Closes #59
https://greenkeeper.io/

Coverage remained the same at 19.048% when pulling a2c06c9838ded75e37277ea96a0c00df74f4ccc4 on greenkeeper/tap-10.2.1 into 6c86ef3562485536ca84b3e98c258c4824acdc29 on master.


[WIP][CVP-2052] Fix failures when running the midstream-cvp image within an OpenShift pod

the problem arise from the fact that the container runs within an OpenShift pod in more restrictive manner. For e.g., it doesn’t run as root.
For resolving this issue, we have discussed two alternative solutions:
Using product-ci-cd's entrypoint script:https://code.engineering.redhat.com/gerrit/plugins/gitiles/product-ci-cd/+/refs/heads/master/container/midstream/entrypoint.sh and also adding the following to the Dockerfile:

@samvarankashyap the script entrypoint.sh is written in a way it can be executed always
even for case where entry already exists in /etc/passwd.
But It is assumed users of the image will run it themselves. IMHO we can run it ourselves from the run_tests.py
We we can run even tests in gitlab action with passing uid to podman
e.g. podman run --user 314159:0

@lslebodn Do you mean invoking the entrypoint.sh from run_tests.py
with appropriate arguments ?
note: I have borrowed the script from the cpaas with no changes except for calling run_tests.py.

Do you mean invoking the entrypoint.sh from run_tests.py
Yes

@lslebodn
I tried switiching the logic to run shell script inside the python script run_tests.py
for reason unknown to me it caused a hungup in both local run and github actions ,
ref: https://github.com/redhat-operator-ecosystem/operator-test-playbooks/pull/152/commits/490b5b426d8f73717c35b3814b10564e93d1427b
However, When i switched it back to running python script inside the run_tests.py
it worked absolutely fine.
ref: https://github.com/redhat-operator-ecosystem/operator-test-playbooks/pull/152/commits/13c100e3895baf5aa312414a8a0fd18b2a423c0d
I have reverted few changes. However, I made changes to the shell script as requested.
Please review.
I will rebase and squash once its re-reviewed
Thanks.
Tagging @dirgim @jsztuka for review

for reason unknown to me it caused a hungup in both local run and github actions

@samvarankashyap because the cpaas sript was written in a way that would never finish. That was their use-case
Removing sleep inf will help
diff --git a/Dockerfiles/midstream/fix_etc_passwd.sh b/Dockerfiles/midstream/fix_etc_passwd.sh
index 44b768a..9562285 100644
--- a/Dockerfiles/midstream/fix_etc_passwd.sh
+++ b/Dockerfiles/midstream/fix_etc_passwd.sh
@@ -4,7 +4,6 @@ main() {
     local home
     home=$(mk_home "$username")
     setup_passwd "$username" "$home"
-    exec sleep inf
 }
 mk_home() {
     local username="${1:?}"

BTW do not add the script fix_etc_passwd.sh into root.
Install it to standard location /usr/bin or /us/local/bin.
It will simplify execution as well. because you will be able to get rid of logic with fix_etc_passwd_path
keep it simple and functional :-)


Custom parser support

Is your feature request related to a problem? Please describe.
It is currently impossible to use external parser like msgpack. Moreover, using msgpack as a parser is a way do solve issue #232 because binary packets with msgpack are sent in one ws frame.
Describe the solution you'd like

Add a boxed trait Parser that is held by the SocketIoConfig and set with the with_parser fn
The boxed trait parser is then held by the Client to encode/decode packets.

After considering all the possibilities to solve this issue I came to think that we should simply implement the msgpack parser as an enum based solution.
enum Parser {
    Common(CommongParser),
   #[cfg(feature = "msgpack-parser")]
    MsgPack(MsgPackParser),
}

/// Public API implemented for Parser and delegating the actions either to the
/// `CommongParser` or the `MsgPackParser` based on a flag in the configuration.

My other points for this solution are:

Currently there are only two real parsers implementation (maybe three):

https://github.com/socketio/socket.io/discussions/4934.
Meaning that exposing a public trait and having separated libs for each parser is not really worth because we can reduce parsers to a fixed set (2 or 3).

We won't loose any performance when using the Common parser by default because the enum will be reduced to only one variant (so no branching).
Here is a little comment on the two different solutions: https://users.rust-lang.org/t/performance-implications-of-box-trait-vs-enum-delegation/11957/4?u=totodore. It is quite nice to understand the advantages and drawback between these two.

@FabianHummel what are your thoughts on this? As you already started to implement something.

Using enums sounds good to me, especially because they are on the stack which is far bettern than trait objects. When people want to implement other parsers they could then simply open a PR and try to get them officially added to the parser list.
Honestly, I haven't worked on this PR for a while now, but I'll consider taking a look and try to come up with something that can be worked with. Thanks for the suggestion!


Issue/9

Updated rollDice to use the newer pasredTarget functionality so that marcos will work correctly.
All errors should be shot out as blind dm cards this way.
Closes #9

@EddieDover in my haste to merge your code I totally spaced testing out the macros.
I never use them myself so it slipped my mind. This PR should fix that issue so if you have a moment to double check that'd be great. If you see any issue let me know.

Looks good. Merge away!


Adding Gelato's VRF services to the oracle docs

This page is intended to provide an overview of the oracle functionality on zkSync, but is currently missing Gelato.  Gelato is important as it is the first VRF provider.
What :computer:

Adding Gelato to the Oracle docs page.

Why :hand:

This page is intended to provide an overview of the oracle functionality on zkSync, but is currently missing Gelato.  Gelato is important as it is the first VRF provider.

Evidence :camera:

@arose00 thanks! I'll fix spell checker and see this merged.


Armor rebalancing, Javelin & Stinger, SWEP improvements

Rebalancing and Javelin/Stinger base code provided by RDC, fixes provided by me.
Changes:

All armor types slightly rebalanced
General SWEP rebalancing
Added SLAM mines - can be placed at any angle, will stick to props, and can change delay with right click
Added Javelin and Stinger SWEPs

Just a few things to point out:
1.- Are there reasons to change RHA curve to 0.99? RHA was originally in that value, i changed to 1 to make the material a neutral mat and avoid most of the confusions when you use it as a comparator for penetration values and stuff like that (pointing that custom armor material is measured in RHA thickness too).
2.- Git 479 doesnt exist on main, but 478. Why assigning 480?
3.- I know this comes from RDC but.... MORE MISSILE ENTS!

Would have to ask RDC regarding the armor, I just added the changes he wanted to add


✨ React testing supports react 17

closes #1955
Description
This PR  adds support to react-17 to  @shopify/react-testing
Full breakdown

upgrades react-reconciler to latest
fixes a breakage with @shopify/react-testing using a renamed internal property by making it work for both React 16 and 17
adds tests to ensure we don't break 17.x consumers
widens react-testing's stated version support
updates docs

Tophatting
The tests should be sufficient, but if you want you can yalc this version of react-testing into another app (eg. Shrink-Ray) and run the test suite there to verify it works with React 16. Next upgrade that repo to React 17 and run the tests again. Things should work swimmingly there too.
You can also use locally upgrade to react-17 and then run yarn test react-testing and ensure that those tests work (though others in the repo will break)
Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

update I pulled the react 17 upgrade out of this PR as there were some non react-testing related issues I'd like to sort out separately. I'll be updating the description to be more reflective shortly.

update I pulled the react 17 upgrade out of this PR as there were some non react-testing related issues I'd like to sort out separately. I'll be updating the description to be more reflective shortly.

@BPScott

What's our plan for updating the version of react installed in development? Keep it at 16.whatever for now?
I originally had that rolled into this PR but it broke a couple other things, so my current plan is to fix those as individual PRs and then do one to upgrade.


Run tests with a forked network

Overview
RIght now, due to the way accounts are setup, I can't run tests on a forked network.
Specification
Here's how I think it would make sense to do:
ape plugins install alchemy foundry vyper
ape test --network --network :mainnet-fork:foundry

And now ape's accounts.test_accounts[0] would point to foundy's private key 0 so that tests work smoothly.
Otherwise, we have to somehow unlock the accounts during tests... which we can't.

Additionally, it would be great to be able to unlock any account when running tests. If I want to run staging tests on a mainnet or testnet, right now I have to do it as a script instead of in the test folder.

hmm, I am not sure I follow.
accounts.test_accounts[0] is the same whether you are using forked networks or not and already is usable.

I can run my tests using mainnet fork on Hardhat:

Really, that is the main use case for forked networks.

Ah- @PatrickAlphaC  because the foundry plugin does not work very well, I would not advise using it.
If you are going to use it, use the branch from this PR for now : https://github.com/ApeWorX/ape-foundry/pull/5
It should resolve the account issue you are seeing.
If it does not, open the issue in the foundry plugin, as it is likely only an issue there.

Gotcha, thanks!


chore(deps): update dependency @vue/test-utils to v2.4.4

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@vue/test-utils
2.4.2 -> 2.4.4

Release Notes

vuejs/test-utils (@vue/test-utils)
v2.4.4
Compare Source
What's Changed

fix: ignore prototype methods when using setData on objects by @Haberkamp in https://github.com/vuejs/test-utils/pull/2265
fix: always load cjs bundle in node environment by @danielroe in https://github.com/vuejs/test-utils/pull/2269
fix: experimentalVmThreads is now pool=vmThreads by @cexbrayat in https://github.com/vuejs/test-utils/pull/2275
feat: respect devtools definition by @webfansplz in https://github.com/vuejs/test-utils/pull/2311

New Contributors

@ArtemTropanets made their first contribution in https://github.com/vuejs/test-utils/pull/2267
@Haberkamp made their first contribution in https://github.com/vuejs/test-utils/pull/2265
@danielroe made their first contribution in https://github.com/vuejs/test-utils/pull/2269
@webfansplz made their first contribution in https://github.com/vuejs/test-utils/pull/2311

Full Changelog: https://github.com/vuejs/test-utils/compare/v2.4.3...v2.4.4
v2.4.3
Compare Source
What's Changed

types(setProps): setProps to Partial props by @pikax in https://github.com/vuejs/test-utils/pull/2241

Full Changelog: https://github.com/vuejs/test-utils/compare/v2.4.2...v2.4.3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

Closing this PR as we're going to focus on updating the swift-docc-renderer fork we use instead.


release: tracker for 1.27.0

This is the umbella tracker for 1.27.0.
Milestone: https://github.com/rkt/rkt/milestone/61
Estimated date: 2017-06-19
Pilot: @JulienBalestra (+ @squeed for review/signing)

Kind reminder for the PRs (#3607, #3710, #3705, #3589, #3674) registered on the 1.27.0 milestone.
We have an estimated date for the release around the 2015-06-19 (next week).
Would it be possible to achieve them during the next week ?
I'm concerned about #3695 and the current planning, do we postpone this one for a next release ?

Yep, it is ok to postpone some PRs in case they are a bit late for an upcoming release. I already proceeded to move most of them to the next milestone.
We just have the networking re-numbering which is ready to land but is having some CI issues, and I had to re-submit as https://github.com/rkt/rkt/pull/3718. Once that is merged, we can proceed with the release today/tomorrow.

@JulienBalestra it looks like we are ready to go!

While at it, I'm looking forward for a release pilot for 1.28 and an approximate schedule for it.
@tesujimath @fabiokung or anybody else interested in it?

@lucab yes, I'm definitely interested!

@JulienBalestra dates on comments here seem to be off. 2015? :-)

@fabiokung uoops, typo from my side :) I'd like to target somewhere mid-July, when are you available?

mid-July sounds good to me. Tentative date one month from 1.27.0?

Yup I'd say 11th or 18th, your pick.

@lucab 18th it is

Ref-chaining: https://github.com/rkt/rkt/issues/3721

@lucab I'm also definitely interested, and 18th July sounds as good to me as any other date.

@tesujimath thanks for the availability! I'll ping you for 1.29.0 then (toward the end of August).


support k8s 1.25.x and 1.26.1

k8s v1.25 does not support  Cronjob apiversion: batch/v1beta1 ，need upgrade to batch/v1 ；

CD support containerd
update node image with podman in jenkins-casc-config.yaml if container runtime is containerd


Playground

Have fun!

/gpt hello there!

/gpt hello there!

/gpt hello there!

/gpt hello there!

/gpt hello there!

/gpt how do I write a GitHub Action?

/gpt could you provide 3 official github docs about Actions?


Current project status?

Describe the bug
Is Hummingbot still actively maintained? There's a flood of open PRs with no engagement and the copyright year on the docs site is still 2023.
Steps to reproduce
N/A
Release version
N/A
Type of installation
Source
Attach required files
N/A

Check the development branch for recent commits if you're having issues. They're fixing the big stuff but are stretched thin.

Describe the bug
Is Hummingbot still actively maintained?

Yes, next release (2.0.2) is in November

There's a flood of open PRs with no engagement

All prs (except bug fixes) should go through governance process
https://hummingbot.org/governance/
https://hummingbot.org/governance/proposals/

and the copyright year on the docs site is still 2023.

Thanks for report this minor bug. will fix

Thanks @archnerd420 / @nikspz – do you guys accept PRs for minor docs issues (typos, etc.)? Would be happy to put up changes as I find.

yes sure, we have this PRs also to update docs
https://github.com/hummingbot/hummingbot-site/pulls


404 on parseArgs

https://docs.deno.com/examples/command-line-arguments/

The url now looks working to me


feat: make jest-preset-hops more flexible

Contains Breaking Change: babel-jest & ts-jest need to be installed additionally now in order to set up Jest for Hops.

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge

Had to change this again, because the underlying resolve-from-utility doesn't support module identifier… 🙄

bors merge

bors retry


miniz 3.0: "static const mz_uint s_tdefl_num_probes" defined twice

Hi,
since v.3.0 I cannot use miniz anymore. I'm including miniz.c/miniz.h from the ZIP archive from the release page in my project, but compilation fails:
../../master/application/./3rdparty/miniz/miniz.c:1254:22: error: default initialization of an object of const type 'const mz_uint[11]' (aka 'const unsigned int[11]')
static const mz_uint s_tdefl_num_probes[11];
                     ^
../../master/application/./3rdparty/miniz/miniz.c:2113:22: error: redefinition of 's_tdefl_num_probes'
static const mz_uint s_tdefl_num_probes[11] = { 0, 1, 6, 32, 16, 32, 128, 256, 512, 768, 1500 };
                     ^
../../master/application/./3rdparty/miniz/miniz.c:1254:22: note: previous definition is here
static const mz_uint s_tdefl_num_probes[11];
                     ^

With v2.2.0 everything is fine.
Edit: Just tested again with v3.0.1 -> still the same error.

To whom it may concern: I included miniz in my project as follows:
#define MINIZ_HEADER_FILE_ONLY
#include "./3rdparty/miniz/miniz.c"

Since it is mentioned as follows in miniz.h:
   * This is a header file library, like stb_image.c. To get only a header file, either cut and paste the
     below header, or create miniz.h, #define MINIZ_HEADER_FILE_ONLY, and then include miniz.c from it.

I know the miniz documentation is not the best, but it seems, that above comment is not correct (anymore). After including miniz.h instead (and adding miniz.c to the project), I was again able to compile and use  miniz in my project. I just don't understand why this issue now came up after miniz v3 release.


Scala 2 libray TASTy compatibility

We found that this library does not work with the current Scala 2 library TASTy

See error in: https://github.com/scala/scala3/pull/19588#issuecomment-1925463405
See what is the Scala 2 library TASTy in: https://contributors.scala-lang.org/t/scala-2-libary-tasty/6602

Please help us minimize this issue to see if it is something expected, a bug in this code base, or a bug in the compiler/library.

it is probably the augmentString from Predef (implicit conversion to StringOps). I wonder if this conversion is applied in the same way with and without the TASTy library.


401 Unauthorized always

I've moved my working API code to a PHP 7.2 server and now it won't authenticate. The prod server is using FCGI, but I've tried the fixes and still, it is not working.
My Code
`$app = new Slim\App();
$app->add(new Slim\Middleware\HttpBasicAuthentication([
'path' => '/*',
'realm' => 'Protected',
'users' => $systemUsers,
'secure' => false,
'error' => function ( $request, $response, $arguments ) {
$data = [];
$data['status'] = 'error';
$data['message'] = $arguments['message'];
return $response->withJson($data);
}
]));`
HTAccess File:
RewriteEngine on RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization},L]
Curl:
`HTTP/1.1 401 Unauthorized
Date: Fri, 19 Apr 2019 12:40:14 GMT
Server: Apache
X-Powered-By: PHP/7.2.17
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: GET, POST, OPTIONS
Access-Control-Allow-Credentials: true
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Pragma: no-cache
WWW-Authenticate: Basic realm="Protected"
Set-Cookie: PHPSESSID=34c28a724ca00e69a03e8c75c70841f3; path=/
Content-Length: 52
Content-Type: application/json;charset=utf-8
{"status":"error","message":"Authentication failed"}`
I know the code works because it works on the local dev environment just fine.

Look for differences in production server. First thing I would look is that does PHP see the Authentication header. You can do this by print_r($request) somewhere in the code. Another thing probably not related but path parameter does not need the *. You could use just 'path' => '/'.

Yeah, it's not seeing that header. I've already got those commands that work for others in my htaccess file though. What else can I try to make sure it is passing the auth headers? If I remove authentication it works.

There is some info in the PHP bug 35752.  You can also try tweaking the mod_fcgi configuration.

The PHP bug fix is what I've got in htaccess now but doesn't work. The fcgi fix I have in htaccess but haven't tried in apache directly. Will this make a difference?

Depending on Apache settings some configuration options cannot be changed in .htaccess so that is worth the try. There also seems to be several different ways to do the mod_rewrite rule too. First one claims to work with fcgi.
SetEnvIf Authorization .+ HTTP_AUTHORIZATION=$0

RewriteCond %{HTTP:Authorization} ^(.*)
RewriteRule .* - [e=HTTP_AUTHORIZATION:%1]

RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

You could also check if $_SERVER["REDIRECT_HTTP_AUTHORIZATION"] exists. If that is the case you can create an adhoc middleware before the Basic Auth middleware which takes the value of $_SERVER["REDIRECT_HTTP_AUTHORIZATION"] environment and injects it into the $request object as an Authorization header.


hack: remove push from operator build

operator build should only build operator binary not pushing it.

cc/ @hongchaodeng

lgtm

merge when green.


Add Registered Account to AddressBook

Right now it is asking for a public key when that should be automatically filled in when it is detected to be a registered account.

Already fixed https://github.com/BitShares/web_wallet/commit/a1fa5ba126753870e5e08b8337b16d931c626687


Question: Do we have support to Command Palette API?

Basically, I was a chrome user and, accidentally, I've found this feature in Edge recently (after my migration).
After a couple searches, it seems to have some functionalities, but in overall, it's not that great. Although, I was wondering that if you guys enable a simple API/doc, we could develop extensions to read from that bar and take actions basing in the selected suggestion. Some examples that we could do:

we could incorporate the ! from command bar (in devtools) directly in command palette, therefore, we could easily create and run snippets in every site (it's annoying using command palette just to open up devtools)
we could change focus or something like that.

Anyway, there are infinites possibilities that will boost that up. So, we could have something great just like VScode does with command center bar.

This is great feedback. Unfortunately, our team has decided to discontinue the Command Palette experiment and it will be removed from Microsoft Edge starting with version 123. Maintaining this experiment had become costly, usage was low, and it was also a lower priority for our team than many other things.
Thanks for your understanding.

The Arc browser has this feature being used like a hot potato!
It just makes things so much easier for power users


Adding default settings to support SDK container builds

Issue describing the changes in this PR
resolves #2617
Pull request checklist

[x] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[ ] My changes should not be added to the release notes for the next release

[x] Otherwise: I've added my notes to release_notes.md

[x] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[x] I have added all required tests (Unit tests, E2E tests)

Additional PR information
Because the tests associated with these changes require a docker daemon, I've moved them out of the default test set by setting a trait and applying a default filter which removes it. The relevant test can still be run by explicitly specifying the other runtime settings file included in the PR. Discussion may be needed around running this test within CI.
In addition to passes for the newly added tests, I have also manually tested the resulting output in both Windows and Linux, using .NET SDK 8.0.4 as per the discussion in #2641. The resulting images have no differences in included packages.
I would like to discuss the impact of these changes, as they would modify the default base image and some other settings for apps that are already using SDK container builds. Those would likely be unsuccessful today, so it is likely safe to do so. However, this still could be a change that warrants a major version revision. Edit: This now targets a new major version. See comment below.
If someone is setting the properties explicitly, those would continue to be honored. I also defined a new property (FunctionsContainerOmitDefaultEnvsVars) which can be used to suppress the environment variables being added should someone be customizing the other properties or have some other reason to modify them. It was not clear to me how I could otherwise conditionally avoid overwriting values that someone else had supplied for these.

Discussed briefly with @fabiocav, and we agree that this indeed makes sense as a 2.0 for the SDK. I will rebase and retarget the feature/2.x branch.

Pushing one more revision to fix the merge conflict on the release notes. Will then merge.


Question about the stellar-hd-wallet

Hi @chatch: Are there specific requirements to use the stellar-hd-wallet in an ionic-angular project?
I have tried a copule of things but none of them seems to work.

i've not used ionic-angular but it should work fine in most javascript projects. what's the problem?

Trying to do a small test of printing a mnemonic https://screencast.com/t/uDv2pEouRbSk. However, I get the following error: https://screencast.com/t/3CoZQGuT9ow.

this is not related to stellar-hd-wallet.  some problem in your recovery-phrase component there.

Yeah, that is what I thought first. But if I don't import the stellar-hd-wallet, the component renders just fine.
I also tried to add the stellar-hd-wallet to the angular.json file like I did with the stellar-sdk https://screencast.com/t/nbkXEpXWU. Then I declare it like this https://screencast.com/t/T0ndoerFZh1
which gives me the following error https://screencast.com/t/J4L2f1kE6. Will keep trying options..

did you fix this issue - closing for now as I don't think it was a stellar-hd-wallet issue ..


xterm (WebGL) tmux missing text in green status bar

I wasn't sure if this was an xterm.js bug or a terminus bug. When using tmux (in WSL) and xterm (WebGL) I don't see any text in the tmux status bar but if I switch back to normal xterm I do.
xterm:

xterm (WebGL):

Is the text visible with the non-webgl xterm frontend?

Yeah, the top screenshot in my bug is with non-webgl xterm and the bottom is the new webgl xterm. The top screenshot has the black text on top of the green bar but in the bottom screenshot there is no text.

This is still happening even with Alpha 102. Is there anything I can provide to help debug or diagnose?

Tracking in #2210


Could not be retrieve the active instances.

Commit 0d268994587b4722e864be03625bca3ce2eaabdc introduced lookup VMs as VSSD as default behaviour, but failed to add the necessary exceptions causing the code to fail, this patch fixes that

Thank you for contributing to openstack/compute-hyperv!
openstack/compute-hyperv uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.