Video is playing itself twice

Script version
What version is the script on eg 2.9 , 3.1 ect
Describe the bug
A clear and concise description of what the bug is.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or a video to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I've pushed an update to hopefully address this (v5.5)
Also, this is a duplicate issue. (https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/449)


How would you use showMappleIf for overflowing container?

Say we only want to use the tooltip if the contents are overflowing the container (say, in a table cell). Can showMappleIf be used to get element.clientWidth < element.scrollWidth ?
That's the one thing we need. Default Bootstrap-style Tooltips (white type, black background, static position relative to hovered element) would be fine; don't need the rest of your very nice component.

@L5eoneill the showMappleIf expects valid condition. If you can get the element reference and get  element.clientWidth and element.scrollWidth values, your condition element.clientWidth < element.scrollWidth is a valid condition condition which will return boolean.
Let me know if this doesn't answer your query.
For your style requirement of mapple you need to use the default mapple, which is black bg and static. You can also configure the style according to your needs. Are you facing any problem in getting your required style of mapple?


test: flash: add rt685 support for flash driver test

enable flash test for rt685
Signed-off-by: Hake Huang<EMAIL_ADDRESS>

@dleach02 add RT685 flash test to avoid issues reported in #43295


Incompatible third-party License

In freemarker-2.3.16.jar, located in Guice at https://github.com/google/guice/tree/master/extensions/struts2/lib, there exists a copy of a version of web-jsptaglibrary_2_0.xsd that contains the following license terms:
      This document and the technology which it describes are
      distributed under licenses restricting their use, copying,
      distribution, and decompilation. No part of this document
      may be reproduced in any form by any means without prior
      written authorization of Sun and its licensors, if any.

Unlike other Sun files with similar license terms, I don't believe that this version (1.17) of this file was re-issued under a different license. In Freemaker, this was a known issue (https://sourceforge.net/p/freemarker/bugs/173/) that was addressed in version 2.3.17.
Addendum: This issue has appeared in other open source projects, most notably as https://issues.apache.org/jira/browse/LEGAL-91. However, in that case, the same versions of the impacted files were available under open source license.

should be straight-forward to upgrade freemarker to fix this


ID's MUST BE A STRING - (SOLVED) (PR NEEDED)

When adding a track make sure you make the id into a string, otherwise none of the event handlers will recognize anything in the track player queue (lost a good couple hours over this).
BAD
TrackPlayer.add([{
      id: track.id,
      url: track.url,
      artist: track.title,
      title: 'LoveLstn',
      artwork: track.image,
    }]);

GOOD
TrackPlayer.add([{
      id: track.id.toString(),
      url: track.url,
      artist: track.title,
      title: 'LoveLstn',
      artwork: track.image,
    }]);

It currently just fails silently

This is already part of the documentation and if you use the Typescript bindings you'll get this safety. However, I've still added another additional check in https://github.com/react-native-kit/react-native-track-player/commit/fe89ec5a784a9830974f68e000a4a1a1302a299d.
So it'll be resolved in the next version.


[Feature] PR Slack notifier

Problem

We would like a way to see new Pull Requests in our PR slack channel. We don't want this integration to generate too much noise, these notifications are intended to be a quick, casual ping "hey, check out this new PR if you want!". The native GitHub Slack integration is not a good fit, it produces a "wall of text" response for each PR, with too much clutter.
Description

We could write a script in JS or Python in this repository, similar to @mkaz's work on TinkerNotifier, the bot for the tinker team (https://github.com/mkaz/octoack), that simply posts all new openverse-* repo pull requests to our slack channel, with a link.
We could use that bot, my initial thoughts for not using it are:

It's written in Rust, which isn't used by our other projects, so makes it more difficult to edit if needed
We'd have to host it, and I'm less sure about deploying/hosting/maintaining Rust applications, particularly as GitHub actions
It's a relatively simple piece of code to re-implement, and we already have similar scripts for working with the GitHub API
We might want to customize the output or emojis used 😆
We don't need user-level tracking, as is included in that script

I thought we might be able to have the Tinker Bot accomplish this - do we need to write our own tool or can we use that?

Just updated my initial comment with more detail @AetherUnbound 😄

I wish there was a way to do a condensed preview using the default integration, but alas it seems like it's been an open issue for a while :disappointed:

I see it as an opportunity to play with Rust :grin:
If you want to modify that existing script to support multiple accounts/repos/channels, I'll host it and run it on the same instance I'm running ours. I can help with any tweaks too, but also totally understand it's a simple easy script that rewriting in Python would be pretty quick.

I'll host it and run it on the same instance I'm running ours.

Well that sounds easy 😄 let's go for it!


Update all text items and field labels on Notebook images table

Goal
Make sure the text items and fields the same as the mock up listed as below
Dependency issue
Tracker: https://github.com/opendatahub-io/odh-dashboard/issues/1254
Itemized goals

Change the nav item title
Change the page description
Use the generic table component
Add a helper tooltip for the Enable field on the custom image table
Change the expandable section UI to align with the design

Aspects continued elsewhere
Update all text items and field labels on Notebook images modals (Import, Edit, Delete) - ticket TBD
Mocks

We will not add To change the order... in the description before we reach phase 2 because we will not implement the drag and drop feature in phase 1. cc @vconzola @kaedward Can we just set the description as Manage your notebook images. when we don't have drag and drop for now or do you think there are more descriptions we can add?

@DaoDaoNoCode Yes, omitting the rest of the description, leaving "Manage your notebook images." is fine for phase 1.

@vconzola Cool, thanks. BTW, what do we want to search in the filters? I think the Name, Description, and Provider should be enough, right?


Dependency conflict with ts-jest

Installing mockzilla-webextension with ts-jest leads to following conflict:
$ npm i -D ts-jest

added 4 packages, and audited 353 packages in 2s

25 packages are looking for funding
run `npm fund` for details

found 0 vulnerabilities

$ npm -D install mockzilla-webextension
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@types/jest
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/mockzilla-webextension
npm ERR!     dev mockzilla-webextension@"*" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/ts-jest
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

How can I resolve this? Shall I --force the installation?

I've been also having issues upgrading these libraries recently...
I've managed to make it work again by downgrading to jest 26 and then downgrading these:
"mockzilla": "^0.9.0",
"mockzilla-webextension": "^0.9.0",
"webextension-polyfill": "^0.8.0",
"webextension-polyfill-ts": "^0.26.0",

Please let me know if you managed to fix it somehow. Thanks!

Probably the safest way.
I forced it: $ npm i -D ts-jest --force
Result in package.json:
"@types/jest": "^26.0.24",
"jest": "^27.1.0",
"mockzilla-webextension": "^0.12.0",
"ts-jest": "^27.0.5",
"webextension-polyfill-ts": "^0.26.0"

Currently it works for my project.

Thanks for the report. Should be fixed now!


Update to reflect the support for DAP and MFA

Through this pull request details regarding the DelegatedOrganization parameter is being added. With the recent update this module now support DAP and MFA.

Docs Build status updates of commit c02e520:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c02e520:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1b47c88:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1b47c88:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 59ec860:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 59ec860:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


refactor(kv): set the default session length when not specified

At the moment, the default session length only gets set to the default
when no service config is specified. So if a service config is used and
it does not set a value for the session length, then the session length
will be zero.
This modifies the creation of the kv service so that it will set the
default session length if the session length is set to zero (the default
value) instead of only doing it when no service config is specified.

This change is intended to consolidate a change that was made on the feat/use-algo-w branch and another change that was made on master.


Expect a function to measure the distance between any two points on the screen in the "screen ruler".

Description of the new feature / enhancement
Expect a function to measure the distance between any two points on the screen in the "screen ruler".The current screen ruler function only includes distance measurement in rectangular, vertical and horizontal directions, but not in diagonal lines, or the distance between two points.
Scenario when this would be used?
This function is required for graphic design related work.Unfortunately, we have not been able to find any screen ruler on the web that does this, whether it is free or paid.
Supporting information
No response

@Jay-o-Way could be nice to show the whole triangle with both the direct distance between the points as well as the vertical/horizontal offsets. Or maybe there's two different tools one that's the direct line, and the other that's the full triangle, as sometimes you just want it all...


AMBARI-24383. A NPE occurs if a Kerberos identity descriptor is missi…

…ng a Keytab specification (amagyar)
What changes were proposed in this pull request?
Ambari fails with an NPE when it encounters a kerberos descriptor with no keytab.
How was this patch tested?

removed keytab field from kerberos.json of zookeeper
enabled kerberos in ambari
checked that kerberos operation failed with the expected error

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3387/
Test FAILed.
Test FAILured.

retest this please

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3399/
Test FAILed.
Test FAILured.

failure is not caused by this change


Add public on some visualizations views

Motivation:
I'm working on some recording visualizations and discovered:

SpectrogramView initializer was not public
NodeRollingView could benefit from more control on configuration for reuse.
Opened FloatPlot and FragmentBuilder so that people could their own components based on those two

Thanks!

@ipodishima - do those colors in the SpectrogramView need to be Bindings? My guess is that they can just be variables (not State or Binding)

Let me know if I'm off on this: https://github.com/AudioKit/AudioKitUI/pull/63

Those were states before, this is why I kept bindings. But I'm not sure this is useful even though it's not lost to have bindings @Matt54

@ipodishima I'm pretty sure I made them state when I had a "less than ideal" understanding of SwiftUI state management 😅 - I should probably do a full sweep through AudioKitUI and clean up my mess

Ahahaha no worries. I'm still trying to figure out the best practices for SwiftUI without being redundant, creating bug,s or having performance issues 🤣


Strings-Remove Duplicates

Hi, I might be able to do this task. Can you give me some more information? I dont have an overview in this project.

Hey @fms12 pleas assign me this task.

hey @fms12 @VARUNvk1729 assign me this task


Use of Volume and VolumeFrom

Use of Volume for volumes (-v) and VolumeFrom for --volumes-from. according to go-docker-client
The usage was mixed Volume with VolumeFrom in 0.4.0 rc4

Thanks!
Looks like a messed up with the flags the problem was that I couldn't find the flag Volumes flags on HostConfig
You PR is failing BTW
./docker.go:294: unknown docker.HostConfig field 'Volumes' in struct literal

https://github.com/mcuadros/dockership/blob/354948837c0170c9fddf0128d720f5cc3901e3b4/core/docker.go#L267
This is the place where you should add Volumes. Will be great if you can test it

dupe https://github.com/mcuadros/dockership/pull/20


What is the logic of this board

Thanks for posting your link on https://www.amazon.com/gp/product/B07XJSRY6B/
I'm not super familiar with MOSFETs so these questions may be misguided.
My impression was that by connecting the following...
1 - a 12vdc source to the Vin
2 - an ESP32 PWM (8bit running at 5000)
3 - a multimeter to the Vout
... would demonstrate an ability to control the voltage of Vout.  (also see attached diagram)
No doubt it's my lack of knowledge of MOSFETs, but I was expecting that by running the PWM duty cycle from  1 to 255 I'd see almost 0vdc - 12vdc on the Vout.  Instead there's no change whatsoever.  Setting the duty cycle to 0 does, in fact, turn the Vout off, but beyond that there's no control.
What am I not understanding?

CORRECTION -- I diagrammed the PWM / GND in reveres of how I wired.

The circuit needs a load for it to function. Using it to drive a LED and a
relay will be plenty of load.
Mosfet don't behave like proper valves. In a circuit I am using, I need to
use p- and n-channel mosfets together; one to turn a darlington pair on and
the other to shut it off. Simply "turning off" one of the mosfets isn't
enough for it to stop flowing.
Not sure how this email was sent or what happens with the reply 😆😁
On Mon, Nov 2, 2020, 8:28 PM communque<EMAIL_ADDRESS>wrote:

Thanks for posting your link on
https://www.amazon.com/gp/product/B07XJSRY6B/
I'm not super familiar with MOSFETs so these questions may be misguided.
My impression was that by connecting the following...
1 - a 12vdc source to the Vin
2 - an ESP32 PWM (8bit running at 5000)
3 - a multimeter to the Vout
... would demonstrate an ability to control the voltage of Vout. (also see
attached diagram)
No doubt it's my lack of knowledge of MOSFETs, but I was expecting that by
running the PWM duty cycle from 1 to 255 I'd see almost 0vdc - 12vdc on the
Vout. Instead there's no change whatsoever. Setting the duty cycle to 0
does, in fact, turn the Vout off, but beyond that there's no control.
What am I not understanding?
[image: Diagram]
https://user-images.githubusercontent.com/25211897/97936555-b8bd9500-1d30-11eb-82d0-82f1818e9d77.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/technerdchris/boards/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJC7SO33DDNOLQ6ZXZ7ZIOLSN5MC5ANCNFSM4TIFAHPA
.

Go and double check the schematic I made here:
https://github.com/technerdchris/boards/blob/master/D4184/D4184_board.pdf
The layout of the board doesn't make sense, really. The V+ connections are
straight through and are no part of the circuit.
Otherwise, think of it as one mosfet.
Vin- and GND are the same point and are the source. The pwm input is gate
and Vout- is drain.
On Mon, Nov 2, 2020, 8:28 PM communque<EMAIL_ADDRESS>wrote:

Thanks for posting your link on
https://www.amazon.com/gp/product/B07XJSRY6B/
I'm not super familiar with MOSFETs so these questions may be misguided.
My impression was that by connecting the following...
1 - a 12vdc source to the Vin
2 - an ESP32 PWM (8bit running at 5000)
3 - a multimeter to the Vout
... would demonstrate an ability to control the voltage of Vout. (also see
attached diagram)
No doubt it's my lack of knowledge of MOSFETs, but I was expecting that by
running the PWM duty cycle from 1 to 255 I'd see almost 0vdc - 12vdc on the
Vout. Instead there's no change whatsoever. Setting the duty cycle to 0
does, in fact, turn the Vout off, but beyond that there's no control.
What am I not understanding?
[image: Diagram]
https://user-images.githubusercontent.com/25211897/97936555-b8bd9500-1d30-11eb-82d0-82f1818e9d77.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/technerdchris/boards/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJC7SO33DDNOLQ6ZXZ7ZIOLSN5MC5ANCNFSM4TIFAHPA
.

Not sure how this email was sent or what happens with the reply 😆😁
Came through fine!

The circuit needs a load for it to function. Using it to drive a LED and a relay will be plenty of load.
Actually, the reason I put the multi-meter was that the LED wasn't responding in the way I was expecting.

Mosfet don't behave like proper valves. In a circuit I am using, I need to use p- and n-channel mosfets together; one to turn a darlington pair on and the other to shut it off. Simply "turning off" one of the mosfets isn't enough for it to stop flowing.
Ok, so this is curious.  From what I'm seeing, if I send 0vdc to the gate, it does shut off the LED (and the multimeter does read 0vdc).  The issue is that running the PWM at any duty cycle other than 0, from 1 to 255, results the full voltage passing through.

An answer to the question might be here

First, Thank you so much Chris for gathering the info, especially for reverse engineering the schematic. The schematic was extremely helpful to me.
You said "The layout of the board doesn't make sense, really. The V+ connections are straight through and are no part of the circuit." You are right, the schematic as drawn doesn't seem like it would do much. And indeed they could have left the V+ connections completely off the board and it would have functioned the same as long as you wired up the load correctly.
To make sense of the circuit, remember that there is a load, often a motor, attached between Vout+ and Vout-. That load is a path between Vin+ and the drain of the mosfets. So, as expected, the mosfets act as switches for the current running through the load.


Powertoys not appearing in the store

Hi,
This document states that Powertoys is available in the Microsoft Store, but I can't find it. When I click on the link in this page, it brings up a webpage for it, which has an "Install" button, and when I click on the Install button I get the option to open up the Store, which I do, and when the Store opens it isn't there. When I do a search of the Store it also doesn't show up there - only a "GPT Powertoys", which appears to be something else altogether (costs money, not free).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 329db15d-6ba6-3603-e8e2-e48762d25431
Version Independent ID: 56ad7882-244e-d3d6-efe6-ec5d38ffd394
Content: Install PowerToys
Content Source: hub/powertoys/install.md
Product: dev-environment
Technology: powertoys
GitHub Login: @alvinashcraft
Microsoft Alias: aashcraft

Hi @SmartmanApps. Can you try it again? Maybe there was a hiccup in the store listing. It seems to be working for me. I get a small Microsoft Store popup when I click the Install button the web store.

If you continue to have issues, I recommend filing a new issue on the PowerToys product repo because I'm pretty sure it's not a documentation issue. If they do determine that something should be updated in the docs, please circle back to this thread. I'll continue to monitor replies after the issue is closed.

Hi @alvinashcraft Sorry didn't reply earlier - I never got a notification that you had commented. In the meantime I wanted it installed so I did what you did - clicked on the link in the doco and it worked - but originally I just went straight to the store because I knew it was supposed to be there, but it didn't show up in any search, which is when I came back to the doco. Now that my computer knows about it it can see it regardless, though it still doesn't show up in my library.
If you have someone there who's never installed it get them to search the store and see if it shows up, cos that's the circumstances under which it wasn't showing up for me. I tried it multiple times and it never showed up. It's only when I clicked on the link in the doco that I was able to install it (but as I said, now that I've installed it it shows up in searches anyway, but not in my library).

Hey @alvinashcraft Just letting you know I just ran into the EXACT same thing when installing WSL/Ubuntu. I'm following a blog about installing WSA, and it included a link to install Ubuntu from the Windows store. When I clicked on that link it took me to the web version, same as the link for Powertoys in the doco did, but when I look for that same package directly in the Store it doesn't show up, same as I ran into before with Powertoys. See screenshots. Some of these developer tools are having visibility issues within the on-device version of the Store (and if I click on "Open Store app" then it opens the Store but NOT at the package required - same thing happened earlier when I tried with with Powertoys (which is why I was then searching the Store for Powertoys, but not seeing it). i.e. these installs are only working if you have a link for the Web Store in the first place.

@alvinashcraft To install WSA I had to set my region to U.S. - fortunately the blog mentioned this, but maybe that was the issue with the other packages that I couldn't see them in my search results?


⚠ Bofrost.be has degraded performance

In 4007c0b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2090 ms

Resolved: Bofrost.be performance has improved in 0cdaee5.


ApartmentNumberVerifier:NextActionEnum name can be simplified

Reported by Peter Csala in code review.

It is perfectly normal to have properties like this

public NextAction NextAction { get; set; }

I was worried about the recursive nature of this, I will consider addressing it.


Java language highlighting is not maintained anymore

The https://github.com/textmate/java.tmbundle project that provides java highlight support isn't maintained anymore it seems.
There is an issue regarding module-info.java highlight support that is open for more than a year now (https://github.com/textmate/java.tmbundle/issues/47, also mentioned in #3566).

It's probably still maintained, but Michael Sheets, being the maintainer of all (?) official TextMate grammars, kinda of lack time to answer everything :/
If you have a better grammar (Sublime Text, Atom, or TextMate grammar) to propose, we'd gladly accept a pull request. I'm closing this issue in the meantime, as unless you have a better grammar to propose, there's not much we can do.


[Doc Improvement][update device capabilities overview][2473202]

adding code sample

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
89
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 685750c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
89
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 11df549:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 858c795:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 557a7cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Playwright in Quarkus Native (not for E2E testing)

I understand that Quarkus supports Playwright for E2E testing, but I want to use it for web scraping. Specifically, I want to deploy Native Quarkus which uses Playwright to scrape websites.
Is this supported by this plugin? Does it work when compiled to Native?

I bet since its marked as a Test component its gets compiled out?  But go ahead and just try it and let us know?

@ia3andy mentioned here: https://github.com/quarkiverse/quarkus-playwright/issues/26#issuecomment-2122694441

It's not possible, it won't compile, because of a restriction on dependencies

But i would like to verify?

@all-contributors add @thomaswiradikusuma for idea

OK I have it working as a runtime: https://github.com/quarkiverse/quarkus-playwright/pull/95
Next is trying to make it work in Native mode.

@melloware I went to other direction (I use JavaScript and made it a micro service hehe), but I'll be happy to test this. I think wi

Ok got it working. Just waiting on some feedback from other devs before merging it.

@thomaswiradikusuma 2.0.0 is in Maven Central and I would love some feedback on your GraalVM testing to see if I missed anything.


[3.0-Triple] Support upper case method

What is the purpose of the change
Support upper-case method for native grpc client
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9181 (8ac85fa) into 3.0 (68381ba) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                3.0    #9181      +/-   ##
============================================
- Coverage     64.77%   64.70%   -0.07%
+ Complexity      313      311       -2
============================================
  Files          1185     1185
  Lines         51015    51017       +2
  Branches       7585     7563      -22
============================================
- Hits          33043    33012      -31
- Misses        14379    14399      +20
- Partials       3593     3606      +13

Impacted Files
Coverage Δ

...pc/protocol/tri/TripleHttp2FrameServerHandler.java
34.19% <0.00%> (-0.45%)
:arrow_down:

.../remoting/api/SingleProtocolConnectionManager.java
61.53% <0.00%> (-23.08%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...ian2/dubbo/AbstractHessian2FactoryInitializer.java
50.00% <0.00%> (-11.12%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
67.39% <0.00%> (-4.35%)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
:arrow_down:

.../org/apache/dubbo/qos/legacy/LogTelnetHandler.java
30.30% <0.00%> (-3.04%)
:arrow_down:

...egistry/kubernetes/util/KubernetesConfigUtils.java
89.18% <0.00%> (-2.71%)
:arrow_down:

...va/org/apache/dubbo/remoting/exchange/Request.java
91.22% <0.00%> (-1.76%)
:arrow_down:

...apache/dubbo/metadata/rest/RestMethodMetadata.java
48.57% <0.00%> (-1.43%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68381ba...8ac85fa. Read the comment docs.


Taking care of libyaml CVE-2014-9130

How can I build a ruby (2.1.5 would be best) with ruby-build that links to a libyaml that doesn't suffer from the above CVE: https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-9130 ?

You first install a version of libyaml that isn't vulnerable, then:
RUBY_CONFIGURE_OPTS=--with-libyaml-dir=/path/to/libyaml ruby-build ...

I.e. same approach you would take if you were building the version yourself. For security, having control over the build process and dependencies is important.


Chore 139349579 Integrate houndCI

What does this PR do?
Integrates HoundCI
Description of Task to be completed?
It integrates hound CI with the repository
How should this be manually tested?
Create a PR and houndCI lints and comments on the PR, if there is no violation it states it.
What are the relevant pivotal tracker stories?
#139349579 Integrate Hound CI

LGTM


Partially Load dMatrix Binary File with Given Indices?

Is it possible to load dMatrix binary file from disk partially, by loading only rows with specified indices? If that is not supported, how can I externally parse the binary file by finding the portion of data corresponding to a given row index?

for now, this is not supported, the only way to achieve this so far is to load everything into memory and then slice

new discussion questions are welcomed at https://discuss.xgboost.ai/


[BUG] Unable to Play YT or Spotify Link Songs

Bug Description
After using a play command for only songs if u try to use the normal search for songs it gives back a result while using a Youtube or Spotify Link it doesn't and it just ignores it not giving even the Queue has Ended event as back it just triggers the catch istantly since yesterday, and i didn't change anything on the relative code. I even tried to remove the catch part but still it doesn't work. In attachment my code example
Reproduction Steps
Steps to reproduce the behavior:

To replicate the bug just go to the link here and copy the code from line.40 to line.60 and put it inside a normal play command
Observe the result.

Expected Result
Searching for Songs it Plays it while Using a Link it Skips Directly to the queue.stop()
Attachments
If applicable, add screenshots to help explain your problem.
Versioning:

OS: Microsoft Windows 11
Node Version V16.10.0
Module Version 8.1.3

By the way that's the same play command code as the Documentation One

I will say, a silent catch is a bad practice, you are getting an exception, you should print the error

I don get anything, just the song doesnt play

Does every link fail? youtube explicit videos may fail because of the age restriction
Still don't know how to reproduce the problem.

Yes it fails with every single link

It's your code is the problem, for example  const arg = message.content.slice(prefix.length).trim().split(/ +/g); you split it, but never remove the prefix, I tried it and it gives a pseudo random song

oooow i totally ignored that part cause i thought it was another kinda problem ty so much


Updating nodes in tree with virtual scroll breaks tree - like load more nodes function

Minimal reproduction of the bug/regression with instructions:
Updating nodes and calling treeModel.update() with virtual scroll leads to a collapsing tree and finally a tree stuck in loading... This is only present in virtual scroll. Setting virtual scroll to false will fix the problem.
Stackblitz uses an example where the child nodes are loaded in steps with a load more functionality 100 nodes each time.
Link to Stackblitz reproduction
Repo steps:

Open root node
Click load more
Root node will collapse
If this is repeated multiple times tree is stuck in loading...

Expected behavior:
Tree behaves the same in virtual and non-virtual scroll.
Versions of Angular Tree Component, Angular, Node, affected browser(s) and operating system(s):
First noticed in version 8.5, still there in 10.0.0.
Other information:

Hi, what is the current status of this issue?
We are experiencing performance issues with the tree that's why we want to enable virtual scroll. If no one is already working on it I would like to take a look into it, if that's ok for you?

We disabled virtual scroll in our application and have not seen any big performance issues. But showing more than 200 nodes is an edge case for us. With that and all that 2020 madness happening this issue has not been our focus. Feal free to take a look into this if you like! That would be awesome!
I played around with it but did not get far. There is also the idea of moving from mobx to rxjs which would impact this issue.

I totally understand that it has not been your focus - having so many nodes is also an edge case for us but it still occurs sometimes and then it gets very slow.
I dug into it and I found that NOT adding the "scroll" event listener outside the angular zone "fixes" the issue.
In the tree-viewport.component.ts file in the ngAfterViewInit  just having
el.addEventListener('scroll', this.scrollEventHandler);
instead of
this.ngZone.runOutsideAngular(() => {       el.addEventListener('scroll', this.scrollEventHandler); });
helps.
I suspected that it had to do with the angular zone because when you click inside the container it renders it (in your reproduction). Unfortunately I cannot yet explain WHY this helps, but I will dug further into it.
Also I am not sure why this code was added in the first place, as it was added in the following pull request
https://github.com/CirclonGroup/angular-tree-component/pull/787
with the reason that it might negatively impact the performance (but probably not confirmed).
Anyway, if I find out why it helps and how I can fix it, I will create a PR.

@Cowraider -- Not sure if you've made any progress on this, but I can try to assist if necessary. I authored the linked PR that moved the scroll event handler outside of ngZone.
In our application, we were seeing abysmal performance when using virtual scroll with large trees. A performance audit revealed that the scroll events were causing a huge number of change detection runs. Moving the event handler outside of the zone seemed to help somewhat, but later on we discovered the same problem as you've described, where the tree can break when updated. So, I think my (attempted) fix may have caused more harm than good. 😞

Hi @alechemy, yes I have made progress, I got it to work by removing the this.ngZone.runOutsideAngular code for the scrolling. However, since I was not exactly sure why this helped (the statemanagement within the tree was not so easy to debug), which is why I wanted to wait until I was sure. For our project I forked the tree and reverted the this.ngZone.runOutsideAngular change and we didn't experience any problems since, and the virtual scroll feature makes the tree extremely fast - even with more than a few thousand nodes. Our plan is to move back to the original tree, once this is fixed.
If you want you could try to use my fork of the tree and see if it solves the performance problems as well as the loading problems for you (which I am confident it does).
And I would create the PR so that we hopefully can merge this into this repository.
The link for the fork would be Fork. The imports need to be adjusted

Can confirm that removing the ngZone fixes the update issue and has very good performance. @Cowraider, when you have your PR ready we will merge it into the repo.
Because this issue is in a few versions we will release this fix in all the mayor versions with the @circlon namespace (11, 10 and 9).

@tobiasengelhardt It seems that I don't have permissions to create a branch (and therefore am not able to create the PR). Is there anything I need to do, or am I missing something?

@Cowraider, you have to create the branch in the fork inside your account. With that branch you can open a PR against this repo. You probably need to update your fork to not have a conflict, because the tree-viewport had a recent change for the lodash removal.

🎉  Great work @Cowraider , and my apologies for inadvertently creating this issue.


Automated cherry pick of #8593: fix(region): prevent dirty data when syncing snapshot

Cherry pick of #8593 on release/3.4.
#8593: fix(region): prevent dirty data when syncing snapshot

/lgtm
/approve


Vendor Class Option seems not correct

Hello,
OptionVendorClass seems not respect RFC  3315, Section 22.16.
Cause the EnterpriseNumber is missing.
I have fix, plz see at:
https://github.com/jerome-laforge/dhcp6/commit/78927a18b545211ced8c2e832aadc36ae6ded11e
If it suitable for you, I can make PR.
thx

Yep, makes sense to me.  Feel free to send a PR.

thx


Minor connected client refactor

A few changes to have consistent naming. We use init_tick terminology on client and change_tick usually referenced as a Bevy's tick.

Codecov Report
Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.94%.

Files
Patch %
Lines

src/server_event/server_event_data.rs
66.66%
2 Missing :warning:

src/server/connected_clients.rs
92.85%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   90.94%   90.94%
=======================================
  Files          38       38
  Lines        2330     2330
=======================================
  Hits         2119     2119
  Misses        211      211

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CocoaPods could not find compatible versions for pod "FBSDKCoreKit"

i have updated facebook_app_events version then im getting error in ios flutter_facebook_login
`[!] CocoaPods could not find compatible versions for pod "FBSDKCoreKit":
In snapshot (Podfile.lock):
FBSDKCoreKit (= 9.0.1, ~> 9.0.0, ~> 9.0.1)
In Podfile:
facebook_app_events (from .symlinks/plugins/facebook_app_events/ios) was resolved to 0.0.1, which depends on
FBSDKCoreKit (~> 9.0.0)
flutter_facebook_login (from `.symlinks/plugins/flutter_facebook_login/ios`) was resolved to 0.0.1, which depends on
  FBSDKCoreKit (~> 5.5)

You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
changed the constraints of dependency FBSDKCoreKit inside your development pod facebook_app_events.
You should run pod update FBSDKCoreKit to apply changes you've made.`

1 - remove "react-native-fbsdk-next".
2 - pod install.
3 - install "react-native-fbsdk-next".
4 - pod install.


New pinpointer sprites

About the PR

Solves #22432 and provides two new sprites for nukie pinpointers and ninja pinpointers, while the universal pinpointer utilises an unused sprite in the files.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Ninja:

Nukie:

Changelog
:cl: Ubaser

add: Ninjas and Nukies now get new sprites for their pinpointers.

awesome

yay i fixed it

#22435
he did not fix it :trollface:

#22435 he did not fix it :trollface:

i posted a new issue for it since its being dumb and i cant fix it


Update MD file on new branch 2017-11-21_11-24-49

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


docs(book): update bindings' pages

Thanks on both the R updates and the rationalization of the others!


Generate Grpc Client with Constructor of setting CallInvoker

Currently, the generated client for Grpc doesn't have a way to set the CallInvoker, it is better to have this.
We are getting CallInvoker instead of Channel when applying client side interceptors to Channel.

Not a big change, https://github.com/Microsoft/bond/pull/951


gnomeExtensions.valent: unstable-2023-11-10 -> 1.0.0.alpha.46

Description of changes
https://github.com/andyholmes/gnome-shell-extension-valent
Closes #314868
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 318189 run on x86_64-linux 1

1 package built:

gnomeExtensions.valent

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2093


State pruner running even when on minimal mode

Restarted my dev node with some of the changes in master and saw this line come up.
{"@timestamp":"2024-10-18T05:20:37,165","level":"INFO","thread":"main","class":"StorageService","message":"State pruner will run every: 5 minute(s), retaining states for the last 0 finalized slots. Limited to 1 state prune per execution.","throwable":""}
I think we're enabling the state pruner even when we're running on minimal  mode, which doesn't make much sense since we don't even store more than 1 finalized states in that mode.
We can probably run some checks and find a way to not enable the state pruner when it's not needed.
I believe that was introduced intentionally for the use case where users migrate from Archive->Minimal but minimal->minimal won't benefit from this at all.

Current master behavior sounds good for me. It doesn't use any resources, it's something like 5ms/1 thread job. If there is something to cleanup, it will clean it up, if nothing, ok, go further, it's cheap.
There is no simple way to check whether we were using any other DB modes before and if there is something to cleanup other than trying to do the job. The only optimization possible here is to check on first run if there is something to cleanup, if nothing and the mode is MINIMAL, stop scheduling next pruner jobs, but I'd prefer simplicity over complexity as long as running this job is very cheap.

we're pruning to cleanup states that may have been left around from a previous Archive mode, so we want to be careful here


Update Deprecation Warnings text to reflect consolidated UI

Old deprecation warnings still reference "Cluster Explorer Apps and Marketplace"
Update all deprecation warnings to remove "Cluster Explorer" reference since we have 1 consolidated UI now. Most of the tools should refer to the new "Cluster Tools" location.
The following tools should reference the location being in "Cluster Tools" instead of "Apps and Marketplace"

Monitoring
Alerting Drivers
CIS Benchmarks
Istio
Logging
Longhorn
OPA Gatekeeper
Rancher Backups

The translations are located: https://github.com/rancher/ui/blob/master/translations/en-us.yaml#L1002

I didn't see any messages for Longhorn or OPA so let me know if they were missed. I did check the entire code base for Cluster Explorer and Apps and Marketplace to ensure they weren't there.
I also removed the cluster dashboard messaging of "dashboard: Try out the Cluster Explorer for a new way to view and manage your Kubernetes resources." since it doesn't seem relevant anymore.

Can we update the text so that for Istio, it doesn't reference Istio 1.7, but "newer versions of Istio" as Istio 1.7 will be EOL soon?

Cluster and project monitoring was showing up as a blue banner instead of yellow.

Updating messaging

Changed color

Validated with v2.6-head on Aug 4.


Fix "touchableProps" is read-only

Changing const touchableProps to let touchableProps.
=> Object.assign on #109 causes otherwise error "touchableProps" is read-only

Thanks! 👍


Docs : Android/iOS interactor capabilities

Adds interactor capabilities information in the README of all supported mesh delivery / cdn load balancer players.

Internally validated : merging.


Error: Client network socket disconnected before secure TLS connection was established

Hello,
i was using imap-simple until today when i got this error everytime i try to retrieve emails and crash my app " you can find the console error below "
Anyone have the same error ?
events.js:174
throw er; // Unhandled 'error' event
^
Error: Client network socket disconnected before secure TLS connection was established
at TLSSocket.onConnectEnd (_tls_wrap.js:1125:19)
at Object.onceWrapper (events.js:286:20)
at TLSSocket.emit (events.js:203:15)
at TLSSocket.EventEmitter.emit (domain.js:448:20)
at endReadableNT (_stream_readable.js:1145:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
at TLSSocket._onError (/usr/src/app/node_modules/imap/lib/Connection.js:151:10)
at TLSSocket.emit (events.js:198:13)
at TLSSocket.EventEmitter.emit (domain.js:448:20)
at emitErrorNT (internal/streams/destroy.js:91:8)
at process._tickCallback (internal/process/next_tick.js:63:19)

What port are you using? Did you use the TSL port and is tls set to true on your config object?


WIP: Associate Detector with Feature and Namespace

Conceptual change:

Detector now represents anything that extracts information from a layer blob. Detector has two different types for now: Namespace ( Detector to extract namespace) and Feature ( Detector to extract features )
Processor and Lister are renamed to Detector

Changes in API:

Add Detector message type, Namespace message type
Add detector field to Feature/Namespace to indicate which detector finds a specific feature or namespace
Change all scanned_* to be just detector

Changes in Database Model:

Every features and namespaces are associated with the detectors that found them.

Changes in Behavior:

Remove Clair side (dis)enable detectors in configuration. Now, every layer is scanned with every detectors.

Additional responsibility to Client:

Client should filter out the features that are not necessary by filtering the detectors ( This responsibility maybe moved to API level on server side in the future )

Please review clair.proto and models.go to confirm the expectation. Those are expected to not be changed in the following commits.

This is done:
detector type
rename column type -> dtype
change column to this enum: CREATE TYPE detector_type AS ENUM ('feature', 'namespace');


Replaced Math.random

Follow up on pull request #69, fixed probability of symbols being too low. Numbers ranging between 0.75-1 are now more common, more like the Math.random function.

Should I redo this since you accepted #74? @ashwin3005

No need, math.random works fine.
thanks a lot for your efforts

No need, math.random works fine.
thanks a lot for your efforts

I understand that math.random 'works fine', but the mdn docs clearly state that it should never be used for security-related applications:
Note: Math.random() does not provide cryptographically secure random numbers. Do not use them for anything related to security. Use the Web Crypto API instead, and more precisely the [window.crypto.getRandomValues()](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues) method.

It's your decision though.


📖 Rename our tech docs and update

User Story
As a member of the AP
I want to have technical documentation that describes what we look after
So that I can reference this information and can aid onboarding of new team members
Value / Purpose
What do we manage?
What do those services do?
What repositories do what for which
Useful Contacts
No response
User Types
No response
Hypothesis
If we have docs
Then we have things written down
Proposal
RENAME ALL the things
FIX ALL the things
Additional Information
No response
Definition of Done

[ ] Documentation has been written / updated
[ ] README has been updated
[ ] Another team member has reviewed

Have a new URL thanks @jacobwoffenden
https://docs.analytical-platform.service.justice.gov.uk/

Initial updates have been merged and services added #4475


Problem with the safe area when using a UITableView with static cells

Description
There is a very weird issue where the safeAreaInsets of the content controller isn't updated and stays .zero when the content is a UITableViewController with static cells, and only when using the release configuration.
Expected behavior
This is how it looks in debug mode:

Actual behavior
And this is how it looks in release mode:

I found the source of the problem after some debugging, and it's here:
https://github.com/SCENEE/FloatingPanel/blob/bed519f0c0152440aa75cf40813415e17fc0d5f7/Framework/Sources/FloatingPanelController.swift#L425-L427
What happens is that change.oldValue and change.newValue are always nil in release mode when the content is a table view with static cells. The value of view.safeAreaInsets is actually updated, but change.newValue stays nil!
I tried using dynamic cells instead of static cells and the problem is solved. So, it seems to be a bug in iOS itself.
As a workaround, I had to change the condition to the following:
guard change.oldValue != self?.view.safeAreaInsets else { return }
Steps to reproduce
You can run the project here in release mode: https://github.com/MhdHejazi/CoronaTracker/tree/62075763e830a10681b5038fe0aca1dbbb2e2d47
How do you display panel(s)?
Add as child view controllers
How many panels do you displays?

1

Environment
Library version
1.7.4
Installation method

Swift Package Manager

iOS version(s)
13.3.1
Xcode version
11.3.1

I'm so sorry I overlooked your issue. I will check this issue in detail and consider to merge the workaround to the library.

I tried to repro this issue using Xcode_11.3.1 + iOS 13.4.1 in your app, but it doesn't seem to reproduce in 13.4.1 now. (Unfortunately, I don't have an iOS 13.3.1 device, so I couldn't confirm it there).
However, your workaround is considered perfectly fine to apply to the lib, so I would change it to apply it.
Thank you very much for your report. I'm glad for you to use the lib on your excellent app.

I tried to repro this issue using Xcode_11.3.1 + iOS 13.4.1 in your app, but it doesn't seem to reproduce in 13.4.1 now. (Unfortunately, I don't have an iOS 13.3.1 device, so I couldn't confirm it there).

It could very well have been fixed in iOS 13.4, but I can't confirm that as I recently switched to using dynamic cells.
Thank you for the great library and glad you like the app!


Property name "healthCare" is not consistent with the spelling

The term healthcare is one word and also referred to the schema, for example "Nearby healthcare services". Should the property name be healthcare instead of camel casing it as two words?
https://github.com/Property-Data-Trust-Framework/schemas/blob/805b17bc5dab32e80b6553636d7b01feeeb15715/src/schemas/v2/pdtf-transaction.json#L655

this is a relatively new field addition, but changing the field name is a breaking change.
it needs a separate pr, and a proper version upgrade
@amolpednekar @edmolyneux


Tweak Maven scopes handling

Seems these were hard-coded in Resolution, making it impossible for users to customize some aspects of configuration handling

(Probably an oversight by 2015 me lol)

Might add a non-regression test later on


Purge proxy sources

Would you accept a pull request that adds purging for proxy sources? If so, would it be ok if I used fingerprinting (#207), or would you rather have it work via the imgix purge endpoint (https://api.imgix.com/v2/image/purger).

Hi,
Not sure I understand the use case. Automatic purging was added in 2.1.2, but is the problem that you're using a web proxy source, and it's currently not working with that?

Yep that's right. I solved it yesterday by writing a plugin specifically for the fingerprinting of assets. It looked like something that was better off in a separate plugin. I can put it here if it's published?


Ignore Exceptions in Laravel

Description
All the unhandled exceptions are send if we update the logging.php file. But sometimes custom exceptions or others like  NotFoundHttpException exceptions are sent, bu I don't want to send those one.
Describe the solution you'd like
I would like to be able to set an array of exceptions to don't send the report to Bugsnag.
Describe alternatives you've considered
I try to use app/Exceptions/Handler.php and removed the config from logging.php . But in that case, Log::error is not send to Bugsnag.
Additional context
I'm using Laravel 8

Hi @albertcito.
You are able to set a list of events to discard using the following configuration option: https://docs.bugsnag.com/platforms/php/laravel/configuration-options/#discard-classes
This is based on classname and sounds like it should fit your use case.

Perfect, looks like it's working properly now. I didn't have that option in my config/bugsnag.php file. I guess it's because I installed that version $ composer require "bugsnag/bugsnag-laravel:^2.0" that is display in the documentation.


update ttf2woff2 for node 4+ support

https://github.com/sapegin/grunt-webfont/issues/286

Hm, it’s not a support, it’s a requirement. We should require node 4+ for grunt-webfont too.

Not anymore with the last ttf2woff2 update, in fact it is now compatible with at least Node 0.12. In all cases though, when the build fails the emscriten fallback still works.

@sapegin can we bump grunt-webfont version and publish to npm also please?

We're about to make it build on windows too https://github.com/nfroidure/ttf2woff2/issues/13#issuecomment-155413000
Just wait a bit, we'll warn you asap.

@fernandopasik I’d wait for Windows support too.

Oh ok! Thanks @sapegin @nfroidure !

@nfroidure Hey is it ready? ;-)

Not yet, i'm changing the emscripten build to use bindings and maybe avoid the AVG antivirus warning.


chore(pie-modal): DSW-1203 fix modal ssr issues

Describe your changes (can list changeset entries if preferable)
Numerous changes to fix modal SSR issues:

"@justeattakeaway/pie-modal": minor
[Changed] - Move any browser-based references to lifecycle hooks that are not run on the server. This is to fix SSR issues seen in NextJS integrations where calling things like document.addEventListener in places such as the constructor (which is called during SSR and CSR) causes errors to occur.

"@justeattakeaway/pie-modal": minor
[Changed] - Defer importing the dialog-polyfill package to when the component is running in the browser. The package is not universal code, meaning it contains browser references and this code is run by simply importing the package. This breaks SSR in applications such as NextJS. Using a dynamic import (whilst not ideal) solves this issue by preventing the client-only code run running on the server.

"@justeattakeaway/pie-webc-core": minor
[Changed] - Rewrite RTL mixin to remove the dir property. The LitElement base class is a subclass of HTMLElement, so a Lit component inherits all of the standard HTMLElement properties and methods. This means that the dir property is already available on the component and we don't need to add it again. Reference. During SSR, if no dir is provided, it will be inferred from the document.documentElement once it's instantiated on the client.

"@justeattakeaway/pie-webc-core": minor
"@justeattakeaway/pie-modal": minor
"@justeattakeaway/pie-icons-webc": minor
[Changed] - Removed the DependantMap type and replaced all references with Lit's own PropertyValues helper. This provides exactly the same strongly typed map for a component's properties which makes our own type a little redundant. Reference

"pie-storybook": minor
[Changed] - Deleted the dir props and i18nargtypes helper as dir is no longer a Lit component property. It is simply a regular HTML attribute

looks really good 🔥


[Qt] update 6.2 to latest version

https://www.qt.io/blog/commercial-lts-qt-6.2.7-released

Looks like the automation configuration will have to be fixed.

Looked at it, this is not an issue with automation. The 6.2.7 release is only available for commercial users. This page could benefit from an extended support column.

@marcwrobel just to know , will  our automation redo this version change ? [because it wont be seen in the list] . if yes
we need to add a dont make change if the version is greater than check to our automation

I think @captn3m0 told me once that version are never downgraded by latest.py. So I would say no, this version change will not be undone.


[$250] mWeb - Chat-mweb-Copy to clipboard [] 4 + image, pasted& sent content goes out of screen

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9. 0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4968019
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Open a chat
Enter [] 4 + upload a image
Send the message
Long press the message sent and select copy to clipboard
Paste the content in compose box
Send the message
Note the content above error message, goes out of screen and not visible fully.

Expected Result:
Copy to clipboard [] 4 + image, pasted&
sent content must not go out of screen and must be visible fully.
Actual Result:
Copy to clipboard [] 4 + image, pasted&
sent content goes out of screen and not visible fully.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/0201856a-4099-46d2-b45c-f5686ed594bc

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836484063080797102
Upwork Job ID:<PHONE_NUMBER>080797102
Last Price Increase: 2024-09-25

Issue OwnerCurrent Issue Owner: @alitoshmatov

@greg-schroeder  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Pretty niche bug to encounter but it does seem broken for sure

Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Chat-mweb-Copy to clipboard [] 4 + image, pasted& sent content goes out of screen
What is the root cause of that problem?
onSubmitComment method invokes handleCreateTask which checks the string for task and since task strings starts with "[] " the square brackets in orginal message are mistaken for a task
https://github.com/Expensify/App/blob/539327dc2d0585624e5e0b990ca0d79f4e66e81b/src/pages/home/report/ReportFooter.tsx#L127-L137
What changes do you think we should make in order to solve the problem?
We need to modify the regex so it checks if the full string contains a attachment, i.e. "[]
!(https://www.expensify.com/chat-attachments/..........1024.jpg)" then it does not try to create a task
What alternative solutions did you explore? (Optional)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01f0c31b30aaa4d002

Next up is proposal review

Proposal
Please re-state the problem that we are trying to solve in this issue.
When copying a text that starts with [] but also has attachment markdown syntax behind that in the chat an error is shown that the task failed to create.
What is the root cause of that problem?
There are two things to consider here:

The text that is copied is a valid syntax for creating a Task since it starts with []. What comes after that would be the title of the task. That should not be considered a bug IMO as it is the users responsibility to know what they're pasting in the keyboard.
The actual root of the error. Since the syntax is for a task the pasted link is considered to be the title of the task but we are not applying any size limitations to it as we do when a task is created using the Create Task form. In the tested example we get an error from the backend the Task title is too long.

What changes do you think we should make in order to solve the problem?
We should add a validation for the task title in https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportFooter.tsx # handleCreateTask and show an error to the user for the use case as in the reported scenario.
My suggestion is to add a state for the error message:
const [error, setError] = useState<Errors>(null);
And in the handleCreateTask right after we check if the title is not empty we would add a check for the max length of the title right after that block: https://github.com/Expensify/App/blob/d009d8ed4830c7d0562c524c991b8a688e2b4869/src/pages/home/report/ReportFooter.tsx#L139-L141
As below:
            if (title.length > CONST.TASK_TITLE_MAX_LENGTH) {
                setError({taskCreationError: translate('violations.taskTitleLength')} as Errors);
                return false;
            }

I would actually like to split that callback in two functions with separated concerns

One that parses the message into TaskRequest object with the following property: isTask,title,asigne,mention. This one would also have the logic to validate the title length.
One that handles the creation of the task as the one currently.

That would improve the readability of those functions and of the onSubmit which would look like this:
  const onSubmitComment = useCallback(
        (text: string) => {
            const taskRequest= parseTask(text);
            if (taskRequest.isTask) {
                handleCreateTask(taskRequest);
            } else
                Report.addComment(report.reportID, text);
        },
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
        [report.reportID, handleCreateTask, error],
    );

And inside the SwipableView to add the message that will show the error:

                        {error && (
                            <DotIndicatorMessage
                                style={[styles.mh4, styles.mv3]}
                                messages={error}
                                type="error"
                            />
                        )}

The output of this would be:

We should probably check about the error message with someone from a product/UX perspective because till now the composer did not have error messages.
What alternative solutions did you explore? (Optional)

Updated Proposal https://github.com/Expensify/App/issues/49290#issuecomment-2363356092 to add two more options.

@alitoshmatov will review proposals shortly!

@skg0525 Thank you for your proposal. When we paste it it is being pasted as url link which should work as normal(you can test it by typing url manually).

@klajdipaja Thank you for proposal. You are right about root cause of the error it is showing, but the main issue in OP is still present even if we meet length requirement.

@alitoshmatov yes you are right.
We also need to check onSubmit that a user is pasting syntax that represents images or videos and if they do to consider that syntax instead of the Task. To do that we need to use the regex's from: https://github.com/Expensify/expensify-common/blob/75869597915c75812e85880c686294f12c112698/lib/ExpensiMark.ts#L55-60
And if the message matches one of them  we do not create a task.
From my proposal isTaskwould be false ifMARKDOWN_IMAGE_REGEX.test(text) || MARKDOWN_VIDEO_REGEX.matches(text) and on submit would not call handleCreateTask:
  const onSubmitComment = useCallback(
        (text: string) => {
            const taskRequest= parseTask(text);
            if (taskRequest.isTask) {
                handleCreateTask(taskRequest);
            } else
                Report.addComment(report.reportID, text);
        },
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
        [report.reportID, handleCreateTask, error],
    );

The regex matching would be great if we could expose as functions from ExpensiMark parser extractImagesInMarkdownComment and extractVideosInMarkdownComment similarly to extractLinksInMarkdownComment

@skg0525 Thank you for your proposal. When we paste it it is being pasted as url link which should work as normal(you can test it by typing url manually).

@alitoshmatov, I didn't paste the exact test strings, but I believe with some adjustments to the regex, we can meet all the requirements without overcomplicating things. The issue stems from how the regex currently treats anything that starts with '[]' as a task. Right now, it splits the string into three parts:
It checks for a task.
It identifies mentions or email addresses.
The remaining part is treated as the task title.
However, it's not accounting for cases where the third part should not be an attachment. When an attachment is long-pressed and copied, it takes the form of  or !(URL).
I've updated the regex with an explicit check to ensure URL attachments aren't considered as the third part (the task title).
Improved Regex for Task Rule Matching:
`const taskRegex = /^[([^]])]\s+(?:@([^\s@]+(?:@\w+.\w+)?))?\s([^!]*)/;
// Match the string against the regex
const match = taskString.match(taskRegex);
// Check if there's a match and group 3 (title) exists
if (!match || !match[3]) {
return false;
}
// Check if group 3 contains disallowed URLs
const disallowedUrls = [
"!([w|https].)",  // Matches URLs starting with "!" or "https"
"!\[([^\]])\]\(.*\)",  // Matches image markdown with links
];
for (const urlRegex of disallowedUrls) {
if (new RegExp(urlRegex).test(match[3])) {
return false;
}
}
`
I have tested this code with multiple different inputs, some of them are as follows:
const task1 = "[] This is a valid task";        --- This should VALID TASK const task2 = " @[email protected] This is another NOT a task";   ---NOT A TASK const task3 = "[] !([https://www.expensify.com/invalid-url])"; // Invalid - URL starting with ![]() ---NOT A TASK const task4 = "[] This is valid![image.jpg](https://www.valid-image.com)"; // Invalid - Image URL after title ---NOT A TASK

@klajdipaja Still, I think the main issue here should be that long texts are not correctly wrapped in android web, you can try similar thing on ios and it wraps correctly without overflowing.
I think we should solve this issue first. Then we can discuss if we should prevent creating tasks with invalid titles

Still, I think the main issue here should be that long texts are not correctly wrapped in android web, you can try similar thing on ios and it wraps correctly without overflowing.

@skg0525 You should also consider my point. The issue here is not that user is trying to create a task with invalid title.

@alitoshmatov Uh sorry, focused too much on the error and missed the actual expected result from the reporter.
That is a simple style change in the https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/TaskPreview.tsx component.
In this line  we need to add styles for word-wrap and change it to this one:
style={[styles.alignSelfCenter, styles.flex1, styles.flexRow, styles.breakWord, styles.preWrap]}

And we also need to align the arrow vertically by wrapping it in a view and adding styles.alignSelfCenter to it's style.
<View style={[styles.alignSelfCenter]}>
                    <Icon
                        src={Expensicons.ArrowRight}
                        fill={StyleUtils.getIconFillColor(getButtonState(isHovered))}
                    />
                </View>

The output is this:

@alitoshmatov my latest comment would be my proposal on how to solve the reported issue. Should I create another formal proposal for that? I feel like my initial proposal contains valuable information on the error that is seen in the video, unless there's another issue open for that already

#vip-vsb is now fully paused/closed, so I'm going to close this as it doesn't really fit in #newdot-quality or any other active project.


Angular - MSAL GUARD fails when path is exactly 3 characters

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
Latest
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.5
Description
Routes with a path length of 3 characters wont work with canActivate: [MsalGuard] I am pretty sure it stopped working after this change:
Link
Error Message
No Error, just wont route to the path.
Msal Logs
[Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - Guard - canActivate
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - MSAL Guard activated
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - handleRedirectPromise called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - getAllAccounts called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - handleRedirectPromise has been called previously, returning the result from the first call
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - getAllAccounts called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:39 GMT]<EMAIL_ADDRESS>: Verbose - Guard - at least 1 account exists, can activate or load
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Info - Guard - Hash contains known code response, stopping navigation.
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - Guard - canActivate
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - MSAL Guard activated
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - handleRedirectPromise called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - getAllAccounts called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - handleRedirectPromise has been called previously, returning the result from the first call
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - getAllAccounts called
app.module.ts:214 [Mon, 08 Nov 2021 15:00:43 GMT]<EMAIL_ADDRESS>: Verbose - Guard - at least 1 account exists, can activate or load
MSAL Configuration
{
    auth: {
      clientId: 'xxxxxxxxxxxxxxxxxxxx',
      authority: 'https://login.microsoftonline.com/xxx.onmicrosoft.com/',
      redirectUri: window.location.origin,
      postLogoutRedirectUri: 'https://localhost:44300',
      navigateToLoginRequestUrl: true
    },
    cache: {
      cacheLocation: BrowserCacheLocation.LocalStorage,
      storeAuthStateInCookie: isIE, // set to true for IE 11
    },
    system: {
      loggerOptions: {
        loggerCallback,
        logLevel: LogLevel.Verbose,
        piiLoggingEnabled: false
      }
    }
  }

Relevant Code Snippets
I am pretty sure the problem lies here: (line 282 in azure-msal-angular.js)

includesCode(path) {
        return path.lastIndexOf("/code") === path.length - "/code".length || //
            path.endsWith("/code")
            path.indexOf("#code=") > -1 ||
            path.indexOf("&code=") > -1;
}

Reproduction Steps

Create a route that has a path of 3 characters (e.g. 'abc')
Add  canActivate: [MsalGuard]
Try and go to the route.

Expected Behavior
Route routes to the path like it does for any other path that isnt 3 characters long
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox
Regression
its worked in the angular betas (the last version i used)
Source
External (Customer)

@whittssg Confirmed as a bug, apologies about that. Will be fixed in next month's release by #4249. For now, use 2.0.4, as this was introduced in 2.0.5.


How to config etcd cluster

I try to build up etcd cluster according to:
https://github.com/coreos/etcd/blob/master/Documentation/clustering.md
The static way.
I run following command on 2 machines:
/home/idcuser/HATest/etcd-v2.0.9-linux-amd64/etcd -name monitorserver1 -listen-peer-urls http://<IP_ADDRESS>:7001 -listen-client-urls http://<IP_ADDRESS>:4001 -initial-cluster-token monitorserver-cluster -initial-advertise-peer-urls http://<IP_ADDRESS>:7001 -initial-cluster monitorserver1=http://<IP_ADDRESS>:7001,monitorserve2=http://<IP_ADDRESS>:2380 -initial-cluster-state new &>> /home/idcuser/HATest/etcd.log &
/home/idcuser/HATest/etcd-v2.0.9-linux-amd64/etcd -name monitorserver2 -listen-peer-urls http://<IP_ADDRESS>:2380 -listen-client-urls http://<IP_ADDRESS>:2379 -initial-cluster-token monitorserver-cluster -initial-advertise-peer-urls http://<IP_ADDRESS>:2380 -initial-cluster monitorserver1=http://<IP_ADDRESS>:7001,monitorserver2=http://<IP_ADDRESS>:2380 -initial-cluster-state new &>> /home/idcuser/HATest/etcd.log &
But when I run client.machines. It will output
machines [u'http://localhost:2379', u'http://localhost:2379', u'http://localhost:4001', u'http://localhost:4001']
Seems it still find cluster machines from localhost.

the arguments you have shown above for monitorserver1 contain an error, namely the node name is spelt wrong in the -initial-cluster. monitorserve2= should be monitorserver2=
be aware that, as per the documentation: "The command line parameters starting with -initial-cluster will be ignored on subsequent runs of etcd"
be sure the cluster is clean by removing the data dir before running with new parameters, once this is done, run 'etcdctl member list' and you should see 2 entries with the corresponding IP addresses - not localhost.
Also be sure that the the IP's can reach each other on the required ports (no firewalls, etc..)

Hi.
I tried to modify monitorserve2 to monitorserver2, but it still not work.
etcdctrl member list still shows localhost ips:
[idcuser@docker-itm-agent-dal01 etcd-v2.0.9-linux-amd64]$ ./etcdctl member list
145f81b1e050b7c7: name=monitorserver2 peerURLs=http://<IP_ADDRESS>:2380 clientURLs=http://localhost:2379,http://localhost:4001
3260c3386e0bf9d8: name=monitorserver1 peerURLs=http://<IP_ADDRESS>:7001 clientURLs=http://localhost:2379,http://localhost:4001
I could ping each other successfully on each machine
And the port is working on each machine.
[<IP_ADDRESS>]$ netstat -ano| grep 7001
tcp        0      0 <IP_ADDRESS>:7001       <IP_ADDRESS>:*               LISTEN      off (0.00/0/0)
[<IP_ADDRESS>]$ netstat -ano|grep 2380
tcp        0      0 <IP_ADDRESS>:2380      <IP_ADDRESS>:*               LISTEN      off (0.00/0/0)
on monitorserver1 machine, etcd log as below:
2015/04/12 04:04:18 etcd: no data-dir provided, using default data-dir ./monitorserver1.etcd
2015/04/12 04:04:18 etcd: already initialized as member before, starting as etcd member...
2015/04/12 04:04:18 etcd: listening for peers on http://<IP_ADDRESS>:7001
2015/04/12 04:04:18 etcd: listening for client requests on http://localhost:2379
2015/04/12 04:04:18 etcd: listening for client requests on http://localhost:4001
2015/04/12 04:04:18 etcdserver: datadir is valid for the 2.0.1 format
2015/04/12 04:04:18 etcdserver: name = monitorserver1
2015/04/12 04:04:18 etcdserver: data dir = monitorserver1.etcd
2015/04/12 04:04:18 etcdserver: member dir = monitorserver1.etcd/member
2015/04/12 04:04:18 etcdserver: heartbeat = 100ms
2015/04/12 04:04:18 etcdserver: election = 1000ms
2015/04/12 04:04:18 etcdserver: snapshot count = 10000
2015/04/12 04:04:18 etcdserver: advertise client URLs = http://localhost:2379,http://localhost:4001
2015/04/12 04:04:18 etcdserver: restart member 3260c3386e0bf9d8 in cluster d32407294ef780c at commit index 313
2015/04/12 04:04:18 raft: 3260c3386e0bf9d8 became follower at term 7872
2015/04/12 04:04:18 raft: newRaft 3260c3386e0bf9d8 [peers: [], term: 7872, commit: 313, applied: 0, lastindex: 313, lastterm: 142]
2015/04/12 04:04:18 etcdserver: added member 145f81b1e050b7c7 [http://<IP_ADDRESS>:2380] to cluster d32407294ef780c
2015/04/12 04:04:18 raft: newRaft 3260c3386e0bf9d8 [peers: [], term: 7872, commit: 313, applied: 0, lastindex: 313, lastterm: 142]
2015/04/12 04:04:18 etcdserver: added member 145f81b1e050b7c7 [http://<IP_ADDRESS>:2380] to cluster d32407294ef780c
2015/04/12 04:04:18 etcdserver: added local member 3260c3386e0bf9d8 [http://<IP_ADDRESS>:7001] to cluster d32407294ef780c
2015/04/12 04:04:19 raft: 3260c3386e0bf9d8 is starting a new election at term 7872
2015/04/12 04:04:19 raft: 3260c3386e0bf9d8 became candidate at term 7873
2015/04/12 04:04:19 raft: 3260c3386e0bf9d8 received vote from 3260c3386e0bf9d8 at term 7873
2015/04/12 04:04:19 raft: 3260c3386e0bf9d8 [logterm: 142, index: 313] sent vote request to 145f81b1e050b7c7 at term 7873
2015/04/12 04:04:19 sender: error posting to 145f81b1e050b7c7: dial tcp <IP_ADDRESS>:2380: connection refused
2015/04/12 04:04:19 sender: the connection with 145f81b1e050b7c7 became inactive
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 is starting a new election at term 7873
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 became candidate at term 7874
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 received vote from 3260c3386e0bf9d8 at term 7874
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 [logterm: 142, index: 313] sent vote request to 145f81b1e050b7c7 at term 7874
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 received vote from 3260c3386e0bf9d8 at term 7874
2015/04/12 04:04:21 raft: 3260c3386e0bf9d8 [logterm: 142, index: 313] sent vote request to 145f81b1e050b7c7 at term 7874
2015/04/12 04:04:22 raft: 3260c3386e0bf9d8 is starting a new election at term 7874
2015/04/12 04:04:22 raft: 3260c3386e0bf9d8 became candidate at term 7875
2015/04/12 04:04:22 raft: 3260c3386e0bf9d8 received vote from 3260c3386e0bf9d8 at term 7875
on monitorserver2 machine ,etcd log as below:
2015/04/12 04:06:02 etcd: no data-dir provided, using default data-dir ./monitorserver2.etcd
2015/04/12 04:06:02 etcd: already initialized as member before, starting as etcd member...
2015/04/12 04:06:02 etcd: listening for peers on http://<IP_ADDRESS>:2380
2015/04/12 04:06:02 etcd: listening for client requests on http://localhost:2379
2015/04/12 04:06:02 etcd: listening for client requests on http://localhost:4001
2015/04/12 04:06:02 etcdserver: datadir is valid for the 2.0.1 format
2015/04/12 04:06:02 etcdserver: name = monitorserver2
2015/04/12 04:06:02 etcdserver: data dir = monitorserver2.etcd
2015/04/12 04:06:02 etcdserver: member dir = monitorserver2.etcd/member
2015/04/12 04:06:02 etcdserver: heartbeat = 100ms
2015/04/12 04:06:02 etcdserver: election = 1000ms
2015/04/12 04:06:02 etcdserver: snapshot count = 10000
2015/04/12 04:06:02 etcdserver: advertise client URLs = http://localhost:2379,http://localhost:4001
2015/04/12 04:06:02 etcdserver: restart member 145f81b1e050b7c7 in cluster d32407294ef780c at commit index 2124
2015/04/12 04:06:02 raft: 145f81b1e050b7c7 became follower at term 7893
2015/04/12 04:06:02 raft: newRaft 145f81b1e050b7c7 [peers: [], term: 7893, commit: 2124, applied: 0, lastindex: 2124, lastterm: 12]
2015/04/12 04:06:02 etcdserver: added local member 145f81b1e050b7c7 [http://<IP_ADDRESS>:2380] to cluster d32407294ef780c

@durzo
Please check my comments above.
Thanks for your help

2015/04/12 04:06:02 etcd: no data-dir provided, using default data-dir ./monitorserver2.etcd
2015/04/12 04:06:02 etcd: already initialized as member before, starting as etcd member...
You need to remove the data dir in order to create a new cluster.

it works. Thanks for your great help

please close this issue


schutzbot: akoutsou ssh keys

Content good, typo in the PR title bad.

At the cost of restarting CI, I had to fix the commit message as well

can you please rebase?

I guess we need one more rebase to include #1529? Sorry :/

I guess we need one more rebase to include #1529? Sorry :/

Yeah no worries.  Quick and easy.  Thanks for the reminder.


Investigate Exception When Increasing Font Size

Using the keyboard to zoom the font (Ctrl++). Report of an exception occurring.

The issue is probably trivial. This looks suspicious:
var fontSizeInPoints = value * 96d / 72d;
var style = new Style(typeof(StackPanel), _panel.Style);
style.Setters.Add(new Setter(TextBlock.FontSizeProperty, fontSizeInPoints));
style.Seal();

The style assumes the container is a StackPanel, which is no longer true. It's a <Grid>.
The constructor for Style should probably just be _panel.GetType().
There are two cases of this, one for font-face, one for font-family.
Test with the preferences dialog and with keyboard shortcuts.


[PDI-19187] Remove MongoDB steps from OSGi/Karaf, and place it as a r…

…egular /plugins plugin

:white_check_mark: Build finished in 3m 6s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 106, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 6m 48s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 106, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:x: Build failed in 9s
Build command:
mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!
:information_source:  This is an automatic message

:white_check_mark: Build finished in 3m 31s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 106, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 2m 14s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 106, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

PR 209 supersedes this one.


Add LICENSE?

Hi @kwea123
Nice impl! Is it possible for you to add a license for this? I'd love to feature it here too https://github.com/krrish94/nerf-pytorch

Thanks for your interest! I have added the license.


fontFamily  PingFang SC，TextField input Chinese display errors

Steps to Reproduce
import 'package:flutter/material.dart';

class MyTextField extends StatelessWidget {
//  MediaQuery
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TextField(
          maxLines: null,
        ),
      ),
    );
  }
}

void main() async {
  runApp(MaterialApp(
    theme: ThemeData(
      platform: TargetPlatform.iOS,
      fontFamily: 'PingFang SC',
    ),
    home: MyTextField(),
  ));
}

Logs

Flutter 1.5.4-hotfix.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7a4c33425d (4 weeks ago) • 2019-04-29 11:05:24 -0700
Engine • revision 52c7a1e849
Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

Environment

Display error

Looks like there is some very thin character inserted between each instance of f, likely an alphabetic space from font fallback, that has a different underline height than the rest of the text, which is using PingFang's version of the letter glyphs.

Hi @dansunhappy
in the hopeful assumption that these PingFang fonts are valid
code + yaml
import 'package:flutter/material.dart';

void main() => runApp(
      const MyApp(
        key: Key('app'),
      ),
    );

class MyApp extends StatelessWidget {
  const MyApp({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) => MaterialApp(
        theme: ThemeData(
          fontFamily: 'PingFang',
        ),
        home: const MyHomePage(
          key: Key('home'),
        ),
      );
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key key}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) => Material(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: [
            const Text('你好，世界'),
            TextField(
              controller: TextEditingController(text: '你好，世界'),
            ),
          ],
        ),
      );
}

name: master
description: A new Flutter project.

# The following line prevents the package from being accidentally published to
# pub.dev using `pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.7.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  # assets:
  #   - images/a_dot_burr.jpeg
  #   - images/a_dot_ham.jpeg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  fonts:
    - family: PingFang
      fonts:
        - asset: fonts/PingFang-Regular.ttf
          weight: 700
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

screenshot

doctor
[✓] Flutter (Channel master, 1.21.0-6.0.pre.90, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.21.0-6.0.pre.90 at /Users/nevercode/development/flutter_master
    • Framework revision 531ee9452a (8 hours ago), 2020-07-29 02:26:03 -0400
    • Engine revision 1ba310017c
    • Dart version 2.10.0 (build 2.10.0-1.0.dev 24c7666def)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (4 available)
    • Pixel 3a (mobile) • 965AY0WP5C • android-arm64  • Android 10 (API 29)
    • macOS (desktop)   • macos      • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 84.0.4147.105

• No issues found!

I cannot reproduce the issue with the latest master,
does this represent the issue you are describing?
Thank you

I fount something.When enting pingying ，iOS will add extra unicode \u2006 between  Chinese pingyin.
for example if I enter "nihao" . iOS system will add an text "ni\u2006hao" to skia .
That's mean when ust Text compont and specify textStyle which font is Pingfang and underline can reproduce this problem.
And the height and y-coordinate  of \u2006 's underline  are different with other character.

Text('ni\u2006hao',
style: const TextStyle(
                fontSize: 72.0,
                color: const Color(0xFF333333),
                decoration: TextDecoration.underline,
                fontFamily: 'PingFang SC'
),)),