Change month height calculation to be based on number of weeks instead of DOM calculations

Hello friends!
This is a precursor to getting https://github.com/airbnb/react-dates/pull/1106 merged in. I separated it out into its own change because it was fairly involved and I didn't want to pollute the code-change in #1106 with something not entirely related.
Basically, when playing around with the month/year selection I found an issue where if you jumped to a month of a different height (5 week month => 6 week month), the height wouldn't automatically adjust as expected. When I started trying to fix the issue, it became apparent that it wasn't possible to do without jank using the existing paradigms.
Before:

On render, each CalendarMonth component (including the two invisible ones for animation) would measure its own height in the DOM.
Each CalendarMonth would then call a callback prop, setMonthHeight, with this measured value.
The CalendarMonthGrid would add these values to an ordered array of CalendarMonth heights which it would then pass back up to the DayPicker via the setCalendarMonthHeights prop
Once the DayPicker would have all of the heights, it would calculate the expected height based on the max of the visible months and grow the calendar appropriately.
On month transitions, it would use this array of heights to grow or shrink the calendar appropriately while transitioning.

The important thing to note is that the only way it could change the height while transitioning was to use the self-calculations made by the invisible months that were already rendered to the DOM. When we want to transition to an arbitrary month or year, there's guaranteed to be jank in this system because we have to render the month before we know its height. The end result is that if you transition from July 2018 to July 2017, the 6-week month will be cut off before it grows. The other option is to hide the calendar in this interim, but that flash is also very apparent.
SO, this change is designed to amend that.
Now:

On the first render (and any time renderMonth changes), the CalendarMonth measures itself, subtracts out the height of the CalendarDay table (which is deterministic based on number of weeks and the daySize prop), and call the setMonthTitleHeight prop with the value.
The DayPicker receives this value and saves it in this.monthTitleHeight
The DayPicker also maintains an array of the number of weeks in each visible month.
On every month transition, the DayPicker uses the number of weeks in the month coming into view along with the daySize prop and the saved monthTitleHeight to calculate the expected height of the incoming month and adjusts the height appropriately.

I've tested this in both the vertical and the horizontal pickers and it seems pretty effective! Because we can pretty readily calculate the number of weeks in any incoming month, this should open the door to slick month transitions to any month. We also, tbh, could probably remove the invisible months from render until it's time to slide them in. That can wait for another time though.
Note, this does assume a pretty constant month title height, but tbh I think that was an implicit assumption before.
Would love some eyes! @ljharb @gabergg @GoGoCarl
These props that I'm changing are all what I would consider internal props (it would be weird if an outside consumer was relying on them for anything)... but are technically part of the API, so this change could be considered breaking. Idk.
TODO:
-[ ] Write tests for getNumberOfCalendarMonthWeeks
-[ ] reset month height when renderMonth changes

Coverage increased (+0.7%) to 85.505% when pulling bfd27c08059068c1b1938835b58325b7f64e9df2 on maja-calc-height-based-on-weeks-instead-of-DOM into 95b5dc8a51b06f8f85f62f4ff722d48e1fed490f on master.

Sweet! Okay, I deferred some of the heavier cloning logic from onPrevMonthClick/onNextMonthClick to updateStateAfterTransition. @GoGoCarl I think you're right that we'll likely want to abstract out that logic a bit in the month/year change. We can address that in your PR though, I think.
I'm gonna merge this in once everything passes.


DateTime to TimeTick

Is there any option to get direct c# timetick from the date? https://docs.microsoft.com/en-us/dotnet/api/system.datetime.ticks?view=net-5.0

Hi @dpatel
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


SystemJS installation instructions

I need help from someone with SystemJS experience.  How would you consume this library with SystemJS?  Do I need to change anything in the code to make that possible?

I think systemjs installation should be fixed in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Support kubeflow operator

What would you like to be added:
Support kubeflow training operator.
Why is this needed:
It is to track the status of kueue to support kubeflow training operator.

[ ] https://github.com/kubeflow/common/pull/196
[x] #65

Note that MPIJob latest version is not currently part of the training-operator https://github.com/kubeflow/training-operator/issues/1479

/lifecycle frozen

This is currently blocked on https://github.com/kubeflow/common/pull/196

/assign

As a first step, I opened a PR to add the PyTorchJob support, and then I will add the following framework support:

TFJob
MXJob
XGboostJob
PaddleJob

Also, I'm on the fence if we should support MPIJob v1 hosted on kubeflow/training-operator (currently, MPIJob v2 hosted only on kubeflow/mpi-operator)
Regarding MPIJob v1 wdyt? @alculquicondor @mimowo @kerthcet @trasc

I'm ok leaving it out if it's not trivial to support 2 API versions. I think the CRD objects themselves are not compatible.

1 to defer the work unless we receive strong demands.

+1 to defer the work unless we receive strong demands.

I agree.

Tasks:

[x] PyTorchJob: https://github.com/kubernetes-sigs/kueue/pull/995
[ ] TFJob
[ ] XGBoostJob
[ ] MXJob
[ ] PaddleJob


ApplicationInsights timesout in Azure DevOps build task (node js)

I have an azure devops task extension that is installed in our pipeline. This task sends telemetry to Azure App Insights to record metrics and events. App Insights js library is throwing this error in some of the builds.
ApplicationInsights:AzureVirtualMachine [ { Error: connect ETIMEDOUT <IP_ADDRESS>:80
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)
errno: 'ETIMEDOUT',
code: 'ETIMEDOUT',
syscall: 'connect',
address: '<IP_ADDRESS>',
port: 80 } ]
Does anyone know what could be the potential problem?

This doesn't sound related to vscode, and I can't help, sorry


[Question] FileOperations for other UWA

I have a question regard to the system file access. I developing an application which generating TOTP codes for two factor authentification (https://github.com/2fast-team/2fast). The account information will be saved und read in a encrypted json file. Currently I have activate the capability 'broadFileSystemAccess' to get the system access authorization to avoid later access problems.
'Files' relies on win32 com calls here as I have seen. For this I would like to ask which files are all needed to be used in another app and if the helper files could be packaged as nuget to simplify this for other developers.

Hi @jp-weber could you clarify what you'd need? If you have the broadFileSystemAccess you should be able to use StorageFolder/StorageFile methods on most locations bypassing the file picker.
Files uses Win32 methods from UWP to enumerate folder contents faster and including hidden files. Plus Files is a desktop bridge app that has a Win32 process running separately for handling file operations, but again for your needs you might be better off using StorageFolder+StorageFile.


Update nf-fltkernel-fltwritefileex.md

When an MDL is provided in Mdl, Length is the size of data that MDL describes.
#749

@lorihollasch - I think this is IFS - please re-assign if I have this wrong.


print verbose error if ofi provider not available

If initial fi_getinfo() fails, then query libfabric to determine if the desired provider is available.  If not, then display a more helpful error message.
I'm marking this PR as a draft, because the resulting error message is somewhat cluttered by the additional context (function, line number, etc.) prepended by the logging functions:
# NA -- Error -- /home/carns/working/src/mochi/mercury/src/na/na_ofi.c:1513
 # na_ofi_getinfo(): Requested OFI provider "verbs;ofi_rxm" (derived from
  "verbs" Mercury protocol) is not available.
# NA -- Error -- /home/carns/working/src/mochi/mercury/src/na/na_ofi.c:1517
 # na_ofi_getinfo(): Please re-compile libfabric with support for
  "verbs;ofi_rxm" or use one of the following available providers:
  tcp;ofi_rxm,tcp,sockets
# NA -- Error -- /home/carns/working/src/mochi/mercury/src/na/na_ofi.c:1526
 # na_ofi_getinfo(): fi_getinfo() failed, rc: -61 (No data available)
...

Is there a logging variant that doesn't do that, or should we make one?  Or just leave it as is?

Fixes #395

Thanks a lot Phil! I think it looks good! Just a few minor comments.

Ok, I refactored to a separate function and corrected the formatting (thanks for the tip!).
Thoughts on the error message format?  Just go with it as is?

Great thanks! I think the error message looks reasonable to me, we can still tweak it more later if needed.

Just a few more warnings to fix for you :) see https://mercury-cdash.hdfgroup.org/viewBuildError.php?type=1&buildid=851
/home/travis/build/mercury-hpc/mercury/src/na/na_ofi.c: In function 'na_ofi_provider_check':
[CTest: warning matched] /home/travis/build/mercury-hpc/mercuryna/na_ofi.c:1415:23: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion]
 1415 |             avail_len += strlen(cur->fabric_attr->prov_name) + 1;
      |                       ^~
[CTest: warning matched] /home/travis/build/mercury-hpc/mercuryna/na_ofi.c:1415:26: warning: conversion from 'size_t' {aka 'long unsigned int'} to 'int' may change value [-Wconversion]
 1415 |             avail_len += strlen(cur->fabric_attr->prov_name) + 1;
      |                          ^~~~~~
[CTest: warning matched] /home/travis/build/mercury-hpc/mercuryna/na_ofi.c:1421:30: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion]
 1421 |     avail = calloc(avail_len + 1, 1);
      |                    ~~~~~~~~~~^~~

You can see those warnings by going to mercury-cdash.hdfgroup.org and click on the number in the "Warn" column.

Oh man, that's tough!  I think I have it fixed now :)

;) right I know I have the whole scrutinizer set up

Alright it's merged now :)


use more advanced (non stdlib) globbing package

https://github.com/mattn/go-zglob

With the new Load mechanics, we will basically expand the globs before passing as entrypoints to Load


Possible bug in selection-buttons.js

Hello!
We've just started using eslint, and it's flagged up a possible issue in selection-buttons.js - I think it's correct.
The reported error is that $elms https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/selection-buttons.js#L9 is not used.
It's assigned a little further down https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/selection-buttons.js#L19 - but then this variable is never used.
I think it should be this.$elms if I'm following correctly.

This was fixed in  #303.

Thanks @glenjamin for raising 👍  😄


POLISH: change the red lettering on Dashboard  View-Up Next section for easier readability.

right now, that is hardcoded "inline html styling" in dashboard.handlebars as "color:red". feel free to either change the hardcoded, or change it to a class to build CSS


Adding .edgerc authentication functionality

Added accessors for host and section so users don't have to manually repeat them

Added a function to read from the edgerc file when address doesn't have a scheme (section), and for the actual setting of client tokens and client secrets

Updated the README to add a section on operating in this mode

Rake test still runs clean,and I'm able to run my sample code (the readme stuff) successfully

This should meet the goals you mentioned - and I added a separate test file for the edgerc stuff.
K

This looks good. Thanks for making those changes Kirsten.


[faucet] Improving observability and throughput

A number of changes to improve the quality of metrics we receive from the faucet, and also reduce bottlenecking at the core of the service, to achieve a higher transaction throughput:
Fixes to SimpleFaucet::prepare_gas_coin
This function had a confusing control-flow that hid a few bugs:

The consumer lock was held for its entire body, when it was only needed at the beginning (to recieve a Coin ID).  Fixed by factoring out the part of the function that needs to hold that consumer lock into pop_gas_coin.
If the consumer lock timed out, the function produced an error that was never used.  Fixed by deleting this unused error message.
The rest of the body is contained within an unconditional loop which always runs exactly once.  Fixed by removing the loop and simplifying the control-flow.
The control-flow path that discards a coin because it has insufficient balance did not update the total_discarded_coins metric.  Fixed by moving the logic for updating this metric to transfer_gases which is responsible for handling the return from prepare_gas_coin -- this is also the function that is responsible for recycling coins that should be kept.

Standardise format for Coin IDs in log messages

Output them as a coin_id label that can be parsed and queried against, rather than inline in the message.

Improvements to RequestMetrics middleware

Detect and count disconnects, printing their elapsed time in the logs.
Treat non-successful (2xx) HTTP Responses as failed requests

Test Plan:
Unit tests:
sui$ cargo nextest run

Test the various new features on a local instance of the faucet, by:
 # Starting validators
sui$ cargo build
$ rm -rf ~/.sui                        \
  && ~/sui/target/debug/sui genesis -f \
  && ~/sui/target/debug/sui start

 # Starting faucet (new terminal session)
$ ~/sui/target/debug/sui-faucet \
  --request-buffer-size 2       \
  --max-request-per-second 1

 # Sending a faucet request (excuse fish shell syntax)
$ set -l ADDRESS (yq -r .active_address ~/.sui/sui_config/client.yaml | sed 's/0x//' | string upper)
  curl --location --request POST 'http://<IP_ADDRESS>:5003/gas' \
      --header 'Content-Type: application/json'              \
      --data-raw "{ \"FixedAmountRequest\": { \"recipient\": \"$ADDRESS\" } }"

Test detecting request failure by replacing the body of SimpleFaucet::pop_gas_coin with None
Test load shedding by running multiple faucet requests in while loops (three is sufficient)
Test disconnection metrics by adding a sleep command within SimpleFaucet::prepare_gas_coin and interrupting the curl command before it finishes.

Thanks for the review @tnowacki!  I wrote the metrics layer stuff previously, so it should be okay (at least in the sense that the change isn't entirely without context).


support types without id: ID field.

[x] test optional ID
[x] test type with no ID

fixes #115

Codecov Report

Merging #116 (7b96ca4) into main (35ed5b1) will decrease coverage by 0.06%.
The diff coverage is 97.53%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   98.88%   98.83%   -0.06%
==========================================
  Files          24       24
  Lines        1349     1374      +25
==========================================
+ Hits         1334     1358      +24
- Misses         15       16       +1

Impacted Files
Coverage Δ

qtgql/codegen/py/compiler/query.py
98.61% <94.11%> (-1.39%)
:arrow_down:

qtgql/codegen/py/objecttype.py
98.78% <97.50%> (+0.17%)
:arrow_up:

qtgql/codegen/introspection.py
99.18% <100.00%> (-0.09%)
:arrow_down:

qtgql/codegen/py/runtime/bases.py
99.10% <100.00%> (+0.02%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix two small typos.

I noticed two small grammatical errors near the top of the front page while reading through the Bookshelf docs. Since these are on the main page and close to the top, I thought they might be worth correcting. Both should increase the readability of the paragraph in which they appear.

If you could get rid of that "Merge pull request..." commit I would gladly merge this.


test: Improve signal test coverage

https://github.com/dgtlmoon/changedetection.io/pull/2036#issuecomment-1852028368

also weird thing, I dont see the output from sigshutdown_handler() when running pytest, so pytest might be shutting it down in a weird way

What kind of reason did fail my PR? it's literally just checking the docker log after the container is shut down but the error comes when the CD is running

What kind of reason did fail my PR (https://github.com/dgtlmoon/changedetection.io/actions/runs/7257771185/job/19772065566)? it's literally just checking the docker log after the container is shut down but the error comes when the CD is running. Even my test code didn't run yet and is not related to the test-api. 😂😂

Dont worry about it, it's some random failure due to timing/slowness waiting for response etc

Current tests pass, can I merge this?


Pass includehidden= as string instead of boolean

Sphinx 7.2 changed its internal API for toctree().
See https://github.com/sphinx-doc/sphinx/issues/11607 Related https://github.com/readthedocs/sphinx_rtd_theme/issues/1463

This change was reverted upstream. So we don't need it anymore.


Include common templates for injecting diagnostic dylibs

Apps like Reveal allows additional data gathering by loading a dylib in the Application process at launch. DYLD_INSERT_LIBRARIES can be used to automate this from FBSimulatorControl. There could be some helper methods that do the right thing by looking in the right place.
There's also dylibs that Apple uses for Xcode debugging features like the View Hierarchy Debugger, ASAN & the backtrace-across-dispatches. These can be seen by printing the environment when launching Simulators from Xcode.

FBSIMCTL_CHILD prefixed environment variables make this pretty trivial on fbsimctl. The problem is now quite different on Xcode 8 since all dylibs are now required to be signed.


Fixed a spelling on Status Internal message.

The work occurred was misspelt.

Thanks!

You are welcome. Thank you for this awesome library.


doc: Include Typeform as a K8s user

This PR aims to include Typeform as a Spark Operator user - Article Spark Structured Streaming in K8s.

@googlebot I signed it!


Apply custom scroll bar in login and signup page, improve scroll to top button hover effect

Heyy , I am a LGM SOC'21 participant . Back to top has absolute position on the web pages . However it should be fixed on the bottom of view port and can't be disappeared on scrolling .
I would like to rectify this thing . Can I ?

Do it in all pages.
Also apply hover effect on it.

Okay . Thanks sir . I will .

@Sarthakjain594 scroll to top button is already fixed on the footer.
I misunderstood, I thought this issue is open in my other project. My apology.
Scroll to top button is fine.

You can still do one thing,
Make scroll to top button in signup and login page similar to that in other pages.
Also apply custop scroll bar in login and signup page as in other pages.
And change hover effect of the scroll button on all pages.
On hover - Background white, inside red

OKkk no worries ... I will do that .

But still I wanna ask one thing , correct me if I am thinking in some wrong direction .
The back to top button on all pages is gonna be on the footer itself .
Then how could it be managable to scroll so long to top again from the mid of  a page ,  if the button is in the end and not visible there in the mid ?

But still I wanna ask one thing , correct me if I am thinking in some wrong direction .
The back to top button on all pages is gonna be on the footer itself .
Then how could it be managable to scroll so long to top again from the mid of a page , if the button is in the end and not visible there in the mid ?

It is better this way, it was that way previously but changed because it was not looking nice.
Also, not all pages are too long, so it won't be that much difficult.

Okk I got it


Trigger viewWillAppear on mainViewController when SlideMenuController appears on screen

viewWillAppear isn't called on the initial mainViewController, so trigger it when SlideMenuController's view will appear.
When the main view controller is replaced while SlideMenuController is on screen, all callbacks work as expected.

hi
Thank you feedback and pull request.
Please try in version 1.2.1. Perhaps corrected in 1.2.1.

Just verified, the problem is still there. This pull request is still needed.

you are using master branch?

Could pls merge this?

@s0meone
I tried in the Sample project, but it is no problem
What does the case?

Hey dekatoro, can you please merge this? When the left or right side close, the main controller is shown again of course, and it needs to be trigger to update its view. Now I need to work around this issue every time. Rgds

I will check it tomorrow. If it's ok, i will merge this one.

All right, thanks in advance!

@mikefranken
Is it to want to call viewWIllAppear of mainViewContrller when leftSide or RightSide hide?
Though I think that you should use so beginAppearanceTransition,

I also highly recommend a merge of this. I had an issue where my constraints wouldn't be updated correctly on the first display of my main controller, since ViewWillAppear isn't triggered in this specific situation. The additional lines of codes fixed it for me and I've yet to experience side effects. Seems like the perfect solution.

Well, because I think that's the right process.
Thank you

Thanks


feat: added support for rpc node like infura

The current implementation only support of api calls for the local instance of etherum nodes, in this MR I have added support for remote RPC enabled API call.

@devrajsinghrawat I'm not sure how to reproduce the problem using an integration test as my integration test is passing.
describe('Infura JSON-RPC', () => {
  it('Tests ethereumLedger constructor and deploy', async () => {
    const mnemonicPhrase =
      'nest power ...';
    const provider = new HDWalletProvider({
      mnemonic: {
        phrase: mnemonicPhrase,
      },
      providerOrUrl:
        'wss://ropsten.infura.io/ws/v3/d92...',
    });
    const web3 = new Web3(provider);
    const ethereumLedger = new EthereumLedger(web3);
    expect(ethereumLedger).toBeTruthy();
    const accounts = await web3.eth.getAccounts();
    expect(accounts.length).toBe(10);
    expect(accounts).toEqual(expect.arrayContaining([expect.any(String)]));
    try {
      await ethereumLedger.initialize();
    } catch (e) {
      // eslint-disable-next-line jest/no-try-expect
      expect((e as Error).message).toBe(
        'insufficient funds for gas * price + value'
      );
    }
    provider.engine.stop();
  });
});

Closing the PR
Solutions:

The changes made in the Pull request

Or

Use of HDWalletProvider to initiate the web3 instance as mentioned below sample which had resolved our issue out-of-the box without any changes on sidetree.js side.

import Web3 from 'web3';
import { EthereumLedger } from '@sidetree/ethereum';
import HDWalletProvider from '@truffle/hdwallet-provider';
      provider = new HDWalletProvider(
        [applicationWalletPrivateKey],
        config.ethereumRpcUrl
      );

    const web3 = new Web3(provider);
    return new EthereumLedger(web3, config.elementAnchorContract);


I2S0 not found ESP32c3 & Arduino + Arduino Framework 2.0.0 (IDFGH-5859)

Is I2S0 support completed yet? I can see reference to IS20 in i2s_struct.h for the esp32c3, but using the latest arduino framework produces:
#include <soc/i2s_struct.h>
#include <soc/i2s_reg.h>

static i2s_dev_t* i2s_device          = &I2S0; // Device to use for this library, change if you want.

void setup() {
  // put your setup code here, to run once:

  i2s_device->reserved_0 = 0;

}

void loop() {
  // put your main code here, to run repeatedly:

}

=
c:/users/anonymous/appdata/local/arduino15/packages/esp32/tools/riscv32-esp-elf-gcc/gcc8_4_0-esp-2021r1/bin/../lib/gcc/riscv32-esp-elf/8.4.0/../../../../riscv32-esp-elf/bin/ld.exe: C:\Users\ANONYM~1\AppData\Local\Temp\arduino_build_905298\sketch\sketch_sep14a.ino.cpp.o: in function `setup()':
C:\Users\ANONYM~1\AppData\Local\Temp\arduino_modified_sketch_844489/sketch_sep14a.ino:16: undefined reference to `I2S0'
c:/users/anonymous/appdata/local/arduino15/packages/esp32/tools/riscv32-esp-elf-gcc/gcc8_4_0-esp-2021r1/bin/../lib/gcc/riscv32-esp-elf/8.4.0/../../../../riscv32-esp-elf/bin/ld.exe: C:\Users\ANONYM~1\AppData\Local\Temp\arduino_modified_sketch_844489/sketch_sep14a.ino:16: undefined reference to `I2S0'
collect2.exe: error: ld returned 1 exit status
exit status 1
Error compiling for board ESP32C3 Dev Module.

this likely should have been filed over on https://github.com/espressif/arduino-esp32/ but even then it would be a duplicate of https://github.com/espressif/arduino-esp32/issues/5578 and https://github.com/espressif/arduino-esp32/issues/5597 and https://github.com/espressif/esp-idf/issues/7114

Hello @mrfaptastic ,
As stated by @atanisoft , this is not linked to ESP-IDF but to arduino-esp32.
In fact, ESP-IDF does define I2S0 for ESPC3:
PROVIDE ( I2S0  = 0x6002d000 );

in esp32c3.peripherals.ld file.
This issue can be closed.


Document how to use docker-bake Composer command when using Drupal VM as a composer requirement

Issue Type

Documentation Report

Summary

When using attempting to run composer docker-bake it fails and tells me:
  [Symfony\Component\Console\Exception\CommandNotFoundException]
  Command "docker-bake" is not defined.

I am assuming this is because I am running Drupal-VM as a composer requirement and I am not using Drupal-VM directly. If this isn't the case then I will close this and open a bug issue.

After looking into this a bit, it is actually a much larger ask than I originally thought. After some very rough hacks I was able to get Docker to build, however, not with any of my local settings.
Here is what I did:

copied the composer command docker-bake into my root composer.json file.
Added some environment variables to the shell script that docker-bake is running to account for the /vendor/geerlingguy/drupal-vm subdirectory shenanigans.
Added those environment variables to the composer command that was being run. Example: DRUPALVM_MACHINE_NAME=example.local;DRUPALVM_HOSTNAME=example.com;DRUPALVM_IP_ADDRESS=<IP_ADDRESS>;DRUPALVM_DIR=/vendor/geerlingguy/drupal-vm/ ./vendor/geerlingguy/drupal-vm/provisioning/docker/bake.sh

After my initial discovery, it looks like this should be possible (and backwards compatible) by changing some key pieces to environment variables and adding a composer plugin that loads all these environment variables via the config yaml files, much like the Vagrantfile does now. Basically offloading the logic from the Vagrantfile to a composer plugin to make the VM/Container provider more portable. Which is kind of leading to a new issue.
Honestly, I am not a Docker or Vagrant adept and a better solution might be found by someone with more experience in both technologies.


Feature/improve conan recipe

Updates the conanfile.py to have a better package.
By setting it up to be a header only-package, maintaining it is much easier.
We might have to update the compiler flags in the package_info function, but this can easily be added now there is an example.

Is this one ready to go?

Is this one ready to go?

I'm happy with it, it should be generally usable, but I've only tested with GCC (my clang is not new enough and I'm on Linux so MSVC is kinda out)

Thanks


[scan] fix scan regression caused by not setting slack_default_payloads option

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Resolves https://github.com/fastlane/fastlane/issues/17915
Resolves https://github.com/fastlane/fastlane/issues/17898
Description

If we are passing nil from the scan's slack_default_payloads to slack action, then slack action is crashing.
Now using the default value inside slack action in case scan will pass the nil value

Testing Steps

Update Gemfile: gem 'fastlane', :git => "git://github.com/crazymanish/fastlane.git", :branch => "slack-issue-fix"
Run scan without passing slack_default_payloads  option.
Slack action should not raise exception and will send the slack notification successfully

cc: @rogerluan for code-review 😊

Hello @rogerluan
it is crashing and 💯 reproducible when the scan is invoking the slack action without passing payloads using ruby It more like slack unit tests are passing and integration test with the scan is failing 😱
Please find attached the demo Xcode project to see the crash and later you can also test the fix after applying the change in Gemfile.
Demo Xcode project
Demo.zip
lane :test do
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/XXXXXXX/XXXXXXXXXXXXX/XXXXXXXXXXXXXXXXXX"

    scan(scheme: "Demo")
  end

I am also checking the unit-tests if I can add one small unit test for this exception 👍

Hello @rogerluan
it is crashing and 💯 reproducible when the scan is invoking the slack action without passing payloads using ruby It more like slack unit tests are passing and integration test with the scan is failing 😱
Please find attached the demo Xcode project to see the crash and later you can also test the fix after applying the change in Gemfile.
Demo Xcode project
Demo.zip
lane :test do
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/XXXXXXX/XXXXXXXXXXXXX/XXXXXXXXXXXXXXXXXX"

    scan(scheme: "Demo")
  end

I am also checking the unit-tests if I can add one small unit test for this exception 👍

Thank you so much for taking time into providing a demo project @crazymanish !
By using the demo project I was able to figure out that the way the tests are run is different than how scan runs the slack action.
By using Fastlane::ConfigurationHelper.parse(Fastlane::Actions::SlackAction, { … }) to parse the options, I get the desired value (default value in case I'm sending nil) and everything works as expected 👌  However, this ConfigurationHelper is literally only used in slack_spec 😱  that's weird. There must be a more proper way to invoke actions and run tests that pick up default values when needed (hopefully). I'll continue investigating

Thank you so much for taking time into providing a demo project @crazymanish !
By using the demo project I was able to figure out that the way the tests are run is different than how scan runs the slack action.
By using Fastlane::ConfigurationHelper.parse(Fastlane::Actions::SlackAction, { … }) to parse the options, I get the desired value (default value in case I'm sending nil) and everything works as expected 👌  However, this ConfigurationHelper is literally only used in slack_spec 😱  that's weird. There must be a more proper way to invoke actions and run tests that pick up default values when needed (hopefully). I'll continue investigating

Lovely @rogerluan thanks for the investigation 🚀
Please let me know if you want any help or want me to improve this PR. Also please feel free to improve this PR if needed. (if its a big change, I will recommend let's have a new PR to improve the scan unit-tests)
I am going to sleep again, it's 6 AM here and ❄ 🥶 in Amsterdam. will follow up in the daytime 🙌

Lovely @rogerluan thanks for the investigation 🚀
Please let me know if you want any help or want me to improve this PR. Also please feel free to improve this PR if needed. (if its a big change, I will recommend let's have a new PR to improve the scan unit-tests)
I am going to sleep again, it's 6 AM here and ❄ 🥶 in Amsterdam. will follow up in the daytime 🙌

Hey @crazymanish, I finally figured things out and I ended up opening a new PR to fix it as you suggested, because there were many changes (and unrelated to yours) 🙇
I'm gonna close this one if you don't mind! 🤗 Here's the new PR: https://github.com/fastlane/fastlane/pull/17923

Hey @crazymanish, I finally figured things out and I ended up opening a new PR to fix it as you suggested, because there were many changes (and unrelated to yours) 🙇
I'm gonna close this one if you don't mind! 🤗 Here's the new PR: https://github.com/fastlane/fastlane/pull/17923


Add sample unit count to collection exercise on activation

Sample V2 Bug fix - set sample unit count on activation

/deploy baileyw


[RFR] Use GitHub API to get a nicer demo

[x] Updating EventDrops demo code to show commits
[x] Create a script to import commits from most starred marmelab repositories
[x] Update demo styling

Related live coding session:

https://www.livecoding.tv/jpetitcolas/videos/Wo4EQ-d3js-node-improving-eventdrops-demo-2
https://www.livecoding.tv/jpetitcolas/videos/b0MXL-d3js-node-improving-eventdrops-demo-3

Current demo with tooltips:

Switching to RFR.
Commit message is still not well formatted (using dashes instead of spaces), but let's fix it in another PR.


[CLOUD-1349] HTTPS_SECRET is required as the field can't be blank

Currently, HTTPS_SECRET parameter is not required but it has a default
value. If the default value is removed and the field is blank, the app
deployment will fail as it needs the value of the field. As a result,
the parameter should be marked as required to avoid users to remove
the default value.
The parameter is changed to required: "true" to enforce users to either
keep the default value or provide a new value and can't keep the field
blank to avoid failure.
JIRA: CLOUD-1349
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1418013
Signed-off-by: Vu Dinh<EMAIL_ADDRESS>

@rcernich As you requested. The PR is submitted to eap-wip branch :)

rebased and merged


Error: No artifacts found

Description
I am trying to initialize the development server of a New Relic application. I cloned the current repository and updated the version. It is currently in version 1.6.3. I have two profiles: account-3490120 and wigiboards. After cloning the project. I install the dependencies with npm install. At the end of the installation, I generate an id with the following command nr1 nerdpack:uuid -gf --profile=wigiboards. And continue to start the server with the command: nr1 nerdpack:serve. Its here where the problem born. I need a lot of help, screenshot:

Steps to Reproduce
Expected Behaviour
Relevant Logs / Console output
Your Environment

NR1 CLI version used: @datanerd/nr1/2.49.5 win32-x64 node-v14.15.1
Browser name and version: Edge 102.0.1245.39
Operating System and version: Window 8.1

Additional context

@Husdady can you still reproduce this with the latest CLI?

Closing this issue as there are no further updates. Please reopen as needed.
cc: @JimHagan


Slides Shift Halfway in Vertical

I'm using a vertical mode to slide through few images, one at a time. But the slider kinda displays them half way, for example the first slide appears shifted down a little bit and the bottom of the other slide is sticking out on top. When they change, they basically go half of the height, so space between the slides appears in the middle instead.
When they autoplay to the last slide, the first slide kinda jumps or pops in place trying to fit into the frame, but still the bottom of the last slide appears on top. Can anyone tell what kinds of sorcery is it?
Here is a code I use to initialize the slider:

	jQuery('.office-slider').slick({
autoplay: true,
  vertical: true,
    slidesToShow: 1,
 infinite: true,
    verticalSwiping: true,
    useTransform: true,
    cssEase: 'cubic-bezier(0.645, 0.045, 0.355, 1.000)',
    adaptiveHeight: true
	});

I just hit this issue too. I believe it's related to images/slides having unequal heights.
Here's a fiddle illustrating the issue:
https://jsfiddle.net/wflaschka/hLw4b9zf/


Migration from local path fails with "migrate from '' is not allowed: unknown hostname"

Gitea version: 1.13.2
Git version: 2.26.2
Operating system:
Ubuntu 16.04.6 LTS,
Docker image  gitea/gitea:1
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No

Logs:
[loads of SQL log entries]
2021/02/16 17:35:06 modules/task/task.go:51:handle() [E] Run task failed: migrate from '' is not allowed: unknown hostname

Description
In recent gitea versions importing from local files fails with the error "modules/task/task.go:51:handle() [E] Run task failed: migrate from '' is not allowed: unknown hostname".
This appears to be an artifact of #13610 which attempts to verify IP address range even for local files.
Consequently setting [migrations]ALLOW_LOCALNETWORKS = true works as a fairly non-obvious workaround

See:
https://docs.gitea.io/en-us/config-cheat-sheet/#migrations-migrations
ALLOW_LOCALNETWORKS: false: Allow private addresses defined by RFC 1918, RFC 1122, RFC 4632 and RFC 4291

I don't think this is resolved. The problem is the form file:///home/git/repository/a.git is not supported.

Ok well that's slightly different from what the report initially stated. I'll reopen.

I understand now! Sorry it took me so long to get what the problem was.


Ensure we clear the HTTP store on log out.

We needed to clear the cookie jar and any HTTP credentials on log out.
Rename OEXKeychainAccess to OEXCredentialStorage to reflect this broader
role.

@hanningni please review

:+1:


[ISSUE #4050] 5.0.0-alpha (Pop): Missing origin message id from dead letter message

What is the purpose of the change
Fix #4050
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.06%) to 49.435% when pulling 42d5422a275add4989be03736e529d6a4fc80296 on Git-Yang:client_bug_fix_v2 into a17fa7605cfbd266e4468e6fe2d6cf6711572111 on apache:5.0.0-alpha.

Coverage decreased (-0.06%) to 49.435% when pulling 42d5422a275add4989be03736e529d6a4fc80296 on Git-Yang:client_bug_fix_v2 into a17fa7605cfbd266e4468e6fe2d6cf6711572111 on apache:5.0.0-alpha.

Hi @Git-Yang 5.0-alpha has been released, should change to target branch to 5.0-beta.

👌


Some utf8 characters not rendered correctly on windows

In the topic overview, it seems that the ≈ character is not rendered correctly. We're using chrome or FF on windows 7.

topicList.ftl:

                                ≈ ${topic.getSize()}

Also similar issues in the login screen:

Seems to come from the CSS:

All using latest release, started via java -jar ...

sorry for spamming this issue but it's weird, after a restart the issues with the login screen are gone. Only the size column character issue ≈ remains. Not sure what is going on :/

Can you try with a simple curl on topic list page ?
The ≈ should be ok normally ?
(to be sure it's not a browser issue)

Also using curl the char is not rendered correctly:

                                â‰ˆ 855,221

                                193.4 mo

                        20
                        5
                        5

You can mark this as a windows issue, just verified that the issue disappears as soon as we deploy on a linux server.

ok, the bug on windows ...
Hope some one with windows could help :)

I think I found the cause of this issue!
The ftl templates are not setting the encoding as UTF-8, which results in using the system's default encoding (iso-8859-1 in Windows 10) . This causes UTF-8's chars not rendering properly. By setting the "encoding" parameter in each template I was able to fix this issue:
<#ftl output_format="HTML" encoding="UTF-8">

I will arrange a pull request for my solution :)

close in #172


Add True Sight as High Ground Bonus

Hello guys,
maybe it would be nice if the High Ground gave True Sight as the last Bonus Effect.
Just to prevent the duel from taking too long.
It would be the last effect to be sure it would only be active if the duel is long and the High Ground isn't defended.
What do you guys think ?

There is a shop with dusts and sentries on evry arena alredy


use absolute dir for tmp

build was failing with
FileNotFoundError: [Errno 2] No such file or directory: 'tmp/module_file.module'

somewhat hard to catch, since changing the script does not trigger a rebuild

changing /tmp to a local tmp folder is meant to fix issues with nix on macos, no rebuild being triggered on changes is a different issue that i should probably address at some point

oh sorry, I see that issue now, what about creating the "tmp" dir before using it?

that works for me, thanks!


update examples to use dataset_id and NlpModel

Before merging this PR, the graphgrid-python-sdk package needs to be updated so that the dataset_id changes are in place

Thanks for the changes/explanations on a few things. Approving this.


Fix path to js file in custom plugin demo

The custom plugin uses a path to the build directory which is not available in the normal download.

Thanks


Not defaults options not working in GoogleMap

Hi there! I just started to implement your library in a personal project. Its look great.
I'm trying to initialize a map with custom styles, but I've detected that when you use differents options that there are defined in optionNameList when calling to composeOptions in the _createdMap method they are ignored.
My GoogleMap initializer:
<GoogleMap ref="map" containerProps={{className: 'map-container'}}
    styles={mapStyles}
    defaultZoom={2}
    defaultCenter={{lat: -25.363882, lng: 131.044922}}>
</GoogleMap>

// when are calling to
composeOptions({
  defaultZoom: 2,
  defaultCenter: {lat: -25.363882, lng: 131.044922},
  styles: mapStyles
}, [
  "center",
  "heading",
  "mapTypeId",
  "streetView",
  "tilt",
  "zoom",
]);

// Its returning { zoom: 2, center: {...} } and ignoring styles prop

Thanks in advance :)

Put them into containerProps?

Sorry I refer to styles to change the map styles (https://developers.google.com/maps/documentation/javascript/styling#styling_the_default_map)
The same issue occurs if I use google.maps.MapOption draggable that its not applying to map initializer.
I think that it would fix updating options list in
// src/creators/GoogleMapsHolder line 55
return new google.maps.Map(domEl, composeOptions(mapProps, [
      // https://developers.google.com/maps/documentation/javascript/3.exp/reference#MapOptions
      "center",
      "heading",
      "mapTypeId",
      "streetView",
      "tilt",
      "zoom",
    ]));

Or changing the composeOptions method to returns all props that are not defined in defaults.

Got it. So in v2.x the API has changed to exclude collect options from this.props. If you like to set something that belongs to options, you should use options/defaultOptions property:
options={{style: mapStyle}}

The rule to expose them as optionNameList is only when those properties has exposed getter/setter on the API document. Since we don't have a google.maps.Map#setStyle method, you should change style inside the options property.

Its working!!
Thanks a lot, and congrats for you library :)
I think when you have time you should update the styledMap example to work well
PS: sorry if my english is bad :(

Glad it works! No problem @samuelsantia !
Sorry to confuse you with the outdated example :( Fix it soon...


Reproducing pure computation TFLOPs

Hi, I'm trying to measure attained TFLOP/s when training on v5-tpu-8. I believe this is done in MaxText/train.py, from lines 491 to 534, and with the current main branch as is I get numbers around 200-300 TFLOPs. But the current calculation sets last_step_completion = new_time on line 505, and thus the extra overhead of calls to record_scalar_metrics and write_metrics is included (assuming no checkpointing). To remove this overhead, I moved line 505 to below line 531, and changed to last_step_completion = datetime.datetime.now() to isolate just the forward and backward pass. I also made the following changes to MaxText/configs/base.yml:
enable_checkpointing: False
async_checkpointing: False
dataset_name: ''
eval_dataset_name: ''
dataset_type: synthetic
max_corpus_chars: 10_000
steps: 10
enable_dropout: False
enable_data_shuffling: False

then when I run train.py with this new base.yml I get very small times and high throughput numbers, around 0.001 seconds and<PHONE_NUMBER>00 TFLOP/s/device.
Is there something wrong with the small changes I made that's resulting in these measurements? Is there some other suggested way to remove any overhead and only capture the computation TFLOP/s?

Note: I also tried increasing steps to 10000 but observed similar numbers through all the steps

Interesting question! Jax is lazy by default so if there is no effort to extract the values output by the computation, jax will keep running ahead (and enqueuing more computations!).
So in this context, Jax is executing your lines of python for step 2 and 3 and so on before finishing the execution of step 1.
Emitting telemetry isn't taking time -- it is serving as a gate for the python execution!
Hope that helps!

@rwitten Got it that makes sense thanks! Just curious, is there a specific part or line of code in the telemetry logic that gates the execution?

Writing to tensorboard at some point requires outputs which serves as a gate.


chips  component upgrade

fyi, we dont use mat-chip anywhere in the component

Yeah took a look through the code to be sure and we aren't using chips at the moment. I'd say the better thing to do here is to remove it entirely

Yeah took a look through the code to be sure and we aren't using chips at the moment. I'd say the better thing to do here is to remove it entirely

For sure, MatChips has been removed


Enable HTML formatting in linguistic analysis pop-up

For presenting potentially complex lexical information that is shown in the linguistic pop-up, we'd need the ability to format, if simply, that information, cf.

For instance, we might want to present a HTML table with principal parts and associated information as follows:

Aspect
Theme
TAMA

Imperfective
nà=gu_di.tłod
0i

Perfective
nà=gu_di.tłòt
sii

Progressive
nà=gu_di.tłíł
yii

Imperfective + Repetitive
nàná=gu_di.tłiizh
0i

Imperfective + Repetitive
nìná=gu_di.tłiizh
0i

Of course, the row and column labels could be opened for relabeling!

The following is the format this could have in HTML:

AspectThemeTAMA
Imperfectivenà=gu_di.tłod0i
Perfectivenà=gu_di.tłòtsii
Progressivenà=gu_di.tłíłyii
Imperfective + Repetitivenàná=gu_di.tłiizh0i-IPFV
Imperfective + Repetitivenìná=gu_di.tłiizh0i

As a further note, the above table (using linguistic labels) could be relabeled according to any of the other two options, i.e. with plain English or (plain) nêhiyawêwin labeling, e.g.

Aspect
Theme
Chunk

Non-past
nà=gu_di.tłod
0i

Past
nà=gu_di.tłòt
sii

Ongoing
nà=gu_di.tłíł
yii

Non-past + Again and again
nàná=gu_di.tłiizh
0i

Past + Again and again
nìná=gu_di.tłiizh
0i

I know the word and the info in the table don't correspond, but how is this looking?
We need to come up with a name for this information. It's currently under "linguistInfo" as "analysis" but that doesn't seem quite right.

That looks like what I was expecting.
I think this does resurrect our discussion concerning the LinguistInfo field, and since it's contents are coming from the lexical database, it would make more sense to call it LexicalInfo of LexicographicalInfo instead.
One could think of the table being such lexical information, but there could be other types, e.g. concerning derivational morphological breakdown, etymology, etc., so one would want to have a distinct name. One option would be to call that PrincipalParts (which is what the content approximately is), but that pertains to a particular morphological tradition (https://link.springer.com/content/pdf/10.1007/s11525-007-9115-9.pdf) that might not always apply - but for now that might be good enough, though I'll try to consult some others if there could be a better term.

For right now, it relabels anything it can, and if that item isn't in the relabelling scheme, it leaves it as is. This assumes the specific and exact table definition above as there is a regular expression that looks for those tags. We can chat about this during our meeting tomorrow.

Ok - I'll add what I can concerning the codes in the paradigm parts, primarily for Tsuut'ina.


Meta: Provide a mechanism to receive periodic updates about tye

What should we add or change to make your life better?
Provide a link to an official announcements mechanism in README. Could just be GitHub Releases or a pinned Issue, either of which support subscriptions/notifications.
Why is this important to you?
I want to stay current with the latest developments without having to actively pore through the repo every so often.

What should we add or change to make your life better?
Provide a link to an official announcements mechanism in README. Could just be GitHub Releases or a pinned Issue, either of which support subscriptions/notifications.
Why is this important to you?
I want to stay current with the latest developments without having to actively pore through the repo every so often.

Awesome, this is great feedback. I'll discuss with the team and see what we want to do.
Our friends over at dotnet/efcore do the pinned issue: https://github.com/dotnet/efcore/issues/19549
We'll probably be doing a formal release every 4 weeks with:

Release notes
Blog post
More demos and docs
Some degree of testing
Packages on nuget.org 😆

Done. We're copying what EF is doing. 🥂 @ajcvickers  🎉
Find the pinned issue here: https://github.com/dotnet/tye/issues/251
I've also updated the root README to suggest subscribing to it. Thanks for the idea!

@rynowak I typically leave the most current update without the details expansion. Then add that in once there is a newer update. This way the newest update is always the most visible.

Good idea. Will fix.


Please apply README

Hey
Can you please apply A README file with at least the same comment as on Grails plugin page and hopefully with some demos of usage in UI

http://grails.org/plugin/image-tools#descriptionTab


merge calc_Ea_El_Edata_Eref_schedule and calc_Eprof_schedule

The functions calc_Ea_El_Edata_Eref_schedule and calc_Eprof_schedule are practically the same - except that the former handles some special cases. They should actually be the same function and could be called, idk... weighted_average_of_schedules?

already done.


Create domains for side projects on fvcproductions.com

https://github.com/search?q=stars%3A>1+user%3Afvcproductions&type=Repositories
https://analytics.google.com/analytics/web/?authuser=1#/report-home/a63190978w105319156p109597480
Transfer Google Analytics all to one place

[x] https://hire-me.fvcproductions.com
[x] https://applications.fvcproductions.com
[x] https://apprenticeships.fvcproductions.com
[x] https://cornell-tech-logos.fvcproductions.com

https://jamstack-hackathon.fvcproductions.com/


Plan design system backlog prioritisation exercise (April 2021)

What
Plan design system backlog prioritisation exercise.
Why
We need the community to know when and what is happening.
To do

[ ] Arrange a date
[ ] Set agenda
[ ] Send invites with the agenda

Possible criteria for prioritising:
Impact “How many designers/teams need this thing?”
v
Effort “How ready is this thing?”

Done. Closing this issue.


Feature/issue 513 - RPC Refactor

Refactored RPC Class methods using new generalized methods in RPCMessage.java and RPCStruct.java
RPC unit tests passing.

Codecov Report

Merging #536 into develop will decrease coverage by 1.46%.
The diff coverage is 90.68%.

@@              Coverage Diff              @@
##             develop     #536      +/-   ##
=============================================
- Coverage      39.71%   38.25%   -1.47%
+ Complexity      2665     2133     -532
=============================================
  Files            310      310
  Lines          16893    13766    -3127
  Branches        2088     1427     -661
=============================================
- Hits            6709     5266    -1443
+ Misses          9351     8306    -1045
+ Partials         833      194     -639

Impacted Files
Coverage Δ
Complexity Δ

...va/com/smartdevicelink/proxy/rpc/OasisAddress.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...com/smartdevicelink/proxy/rpc/HMICapabilities.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...martdevicelink/proxy/rpc/GetWayPointsResponse.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/smartdevicelink/proxy/rpc/OnWayPointChange.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...com/smartdevicelink/proxy/rpc/LocationDetails.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...java/com/smartdevicelink/proxy/rpc/Coordinate.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...m/smartdevicelink/proxy/rpc/StreamRPCResponse.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...java/com/smartdevicelink/proxy/rpc/DialNumber.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...va/com/smartdevicelink/proxy/rpc/GetWayPoints.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ava/com/smartdevicelink/proxy/rpc/OnStreamRPC.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c2062...070661a. Read the comment docs.


Null checking Subscription before unsubscribe

Subscribtion object should be checked for nullity before unsubscribe in ngOnDestroy methods
Without this fix unit test throws errors like this:
Chrome 54.0.2840 (Linux 0.0.0) Directive: shardisLarge should not make all elements yellow FAILED
	Error: Error in ./AppComponent class AppComponent - inline template:24:6 caused by: Cannot read property 'unsubscribe' of undefined
	TypeError: Cannot read property 'unsubscribe' of undefined
	    at Header.ngOnDestroy (webpack:///home/tomasz/dev/projects/shardis/~/clarity-angular/nav/header.js:73:0 <- src/main/typescript/test.ts:51016:27)
	    at Wrapper_Header.ngOnDestroy (/ClarityModule/Header/wrapper.ngfactory.js:14:16)
	    at CompiledTemplate.proxyViewClass.View_AppComponent0.destroyInternal (/DynamicTestModule/AppComponent/component.ngfactory.js:516:21)
	    at CompiledTemplate.proxyViewClass.AppView.destroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/view.js:143:0 <- src/main/typescript/test.ts:64598:14)
	    at CompiledTemplate.proxyViewClass.DebugAppView.destroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/view.js:371:0 <- src/main/typescript/test.ts:64826:38)
	    at CompiledTemplate.proxyViewClass.View_AppComponent_Host0.destroyInternal (/DynamicTestModule/AppComponent/host.ngfactory.js:33:19)
	    at CompiledTemplate.proxyViewClass.AppView.destroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/view.js:143:0 <- src/main/typescript/test.ts:64598:14)
	    at CompiledTemplate.proxyViewClass.DebugAppView.destroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/view.js:371:0 <- src/main/typescript/test.ts:64826:38)
	    at CompiledTemplate.proxyViewClass.AppView.detachAndDestroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/view.js:130:0 <- src/main/typescript/test.ts:64585:14)
	    at ComponentRef_.destroy (webpack:///home/tomasz/dev/projects/shardis/~/@angular/core/src/linker/component_factory.js:121:51 <- src/main/typescript/test.ts:30533:70)

This change seems fine by me, but I really believe the case where you have no subscription should absolutely never happen.
Even if it's in your unit tests, getting this error means you call ngOnDestroy() on your components but never ngOnInit(), which makes no sense. Either you don't call any of them because you're testing something that doesn't require the setup, of you call both of them because you're trying to test a compiled component.
I'm holding off on the :shipit: until someone else shares their opinion on this, because on one hand the change is innocuous, but on the other it encourages bad practice in unit tests by adding a safeguard where you shouldn't need one.

I've thougth that ngOnDestroy can't be called without ngOnInit but this error shows that I was wrong.
It makes no sense but it could happen.
After cleaning my tests and allways destroying fixture after tests they all pass now.
My fix can avoid false errors like this for others.

@kucharzyk I would still be worried about introducing the change considering the statement @youdz made:

It encourages bad practice in unit tests by adding a safeguard where you shouldn't need one.

What do you think?

@kucharzyk: The fact that the absence of safeguard forced you to destroy fixtures after tests is my whole point. You should've been doing that before even using Clarity, or you end up with side effects and memory leaks, which can result in bugs that are horrible to identify.
If we add your safeguard, people in the same situation as you will not see the error they already have, and they will only detect it much further down the line when it is harder to identify and fix.
Your answer pushes me towards not merging this in.

@youdz  You have right. Absence of safeguard forced me to properly destroy fixtuers.
On the other side some users may complain when stacktrace is pointing at error in Clarity class while real error is caused by improperly created test.
After all I think that You should't merge this. Creating safeguards for such situations makes little sense


tested password in user.spec.js

Is this good enough?

That looks like the start of what we want. Good enough for the lab. I know what's broken, thanks!


SKYDNS_PATH_PREFIX doesn't support multiple portion, like "/app1/skydns"

Hi,
I was trying to share one etcd/skydns with multiple applications. The procedure is to set SKYDNS_PATH_PREFIX like "/app1/skydns", "/app2/skydns".
The DNS A query to skydns is OK. But DNS SRV query response is incorrect, which includes  un-necessary “skydns” at the rightmost portion. Please see following SRV query output.
#################################################################
nnie@xubuntu:~$ dig +tries=1 +time=60 @localhost SRV stdn.rf.dtd.tas01.local
; <<>> DiG 9.10.3-P4-Ubuntu <<>> +tries=1 +time=60 @localhost SRV stdn.rf.dtd.tas01.local
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 16176
;; flags: qr aa rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1
;; QUESTION SECTION:
;stdn.rf.dtd.tas01.local.       IN      SRV
;; ANSWER SECTION:
stdn.rf.dtd.tas01.local. 3600   IN      SRV     10 100 3868 1.stdn.rf.dtd.tas01.local.skydns.
;; ADDITIONAL SECTION:
1.stdn.rf.dtd.tas01.local.skydns. 3600 IN A     <IP_ADDRESS>
;; Query time: 5003 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Sat Jul 02 07:23:46 CDT 2016
;; MSG SIZE  rcvd: 109
#################################################################
I tried the private code (github.com/skynetservices/skydns/msg/service.go) change to strip the 2 right most portions. Then SkyDNS SRV answer can return correct target hostname w/o “skydns”.
Can you help to check this issue?
Regards,
Neil

Take a look at TargetStrip in the README. That should do (partly?) what you need.

Hi Miek,
When I added targetstrip into value, the strip is from left-most side. 	IN	SRV
;; ANSWER SECTION:
stdn.rf.dtd.tas01.local. 3600	IN	SRV	10 100 3868 rf.dtd.tas01.local.skydns. <-the intention is to remove right most portion "skydns".
;; ADDITIONAL SECTION:
rf.dtd.tas01.local.skydns. 3600	IN	A	<IP_ADDRESS>
;; Query time: 1 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Tue Jul 19 20:32:57 CDT 2016
;; MSG SIZE  rcvd: 102
The source code also indicates that "// targetStrip strips "targetstrip" labels from the left side of the fully qualified name.".
Any other ideas?
Regards,
Neil

+1 for accepting and handling more than a single directory in the prefix config.
Especially considering etcdv3, where the keyspace is flat (no more directories as we knew them in etcdv2), it would be anyway more natural to strip off the whole prefix from the etcd entry.

[ Quoting<EMAIL_ADDRESS>in "Re: [skynetservices/skydns] SKYDNS_..." ]

+1 for accepting and handling more than a single directory in the prefix config.
Especially considering etcdv3, where the keyspace is flat (no more directories as we knew them in etcdv2), it would be anyway more natural to strip off the whole prefix from the etcd entry.

Can this be something that is better (and prolly less hacky) handled in CoreDNS?
(github.com/miekg/coredns)

Hmmm, does it mean that SkyDNS is not developed actively anymore? Should we consider it as an abandoned project?

Uhm, no.
On 21 Jul 2016 8:42 a.m., "Laszlo Janosi"<EMAIL_ADDRESS>wrote:

Hmmm, does it mean that SkyDNS is not developed actively anymore? Should
we consider it as an abandoned project?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/skynetservices/skydns/issues/285#issuecomment-234180415,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVkW50wscDD59mNl9KCZyDgzo80H9-aks5qXyLTgaJpZM4JJDeC
.

OK, cool :)

Can this be added to skyDNS enhancements lit:-)

[ Quoting<EMAIL_ADDRESS>in "Re: [skynetservices/skydns] SKYDNS_..." ]

Can this be added to skyDNS enhancements lit:-)

I'm not sure how cleanly this can be added. Please feel free to send a PR and
we can discuss actual code. If the patch is small I'm inclined to accept.


Build A Portfolio Website With Vite And Three.js

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

`This closes #5849

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@katungi
Hello, any update on the review

@hectorkambow @section-engineering-education/content-moderator-team
I would like to review this PR
cc @ahmadmardeni1 @Kayere @LinusMuema @WanjaMIKE @louisefindlay23

Hey @kimkimani Is this your first test review?

Hey @kimkimani Is this your first test review?

Yes @ahmadmardeni1

Added to the list of test-peer-reviewers.
cc @section-engineering-education/content-moderator-team

Apart from the boilerplate code, there appears to be several sentences in this article showing plagiarism. Please correct them. Thanks
New Scan 5_00 PM Copyleaks Report.pdf

Hello @WanjaMIKE, I made the changes. The ones left are just the regular lorem dummy texts.

Hello @oyedeletemitope, thank you for submitting your article. I will be reviewing your PR.
On a quick glance, your article looks pretty good. However, I found the GIf files a bit large. Is there is a way to trim down their size? If not, we can have them posted on YouTube and embed the URLs on your MD file.
Here is a guide to help you out in case you get stuck

Thank you for the observations and corrections. I've made changes according to all that you suggested.

i also reduced the size of the gif files

Changes made. Please let me know what other changes the article requires.

@oyedeletemitope Your article looks good now. Check the preliminary and technical reviews listed above before proceeding to the final review.

@kimkimani
Just noticing this PR - I believe you may be over extending yourself on the reviews - there is (hardly) a reason a pull request should have 100 comments.
This pull request may have been a good candidate to close - peer reviewers must be able to deduce when to close pull requests immediately!!
cc: @section-engineering-education/content-moderator-team

@kimkimani
Thank you for taking the time to review my article. You really helped a lot. I promise to be more careful when writing my next article.

@kimkimani
I believe the author has made the requested changes.
Consider reviewing it for a final time - check for grammar, correctness of the code snippets, and markdown formatting.
As Hector had mentioned already, we have taken this review too far with too many rounds of revisions. If it requires any more, you may close the PR and ask the author to make ready to be published PRs.
Let me know if you need any help.
Thanks.

@oyedeletemitope
Your article had numerous grammatical and flow errors. Please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra checks on grammar and 3rd party (vetted) resources to help improve overall technical writing.
Check all the comments suggested during the review process and make sure they are implemented in your upcoming articles. ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

@ahmadmardeni1 @hectorkambow @srishilesh
This article is ready for final review.

@kimkimani
Please add front matter and PRC line.
You can request your author to add them for you or you can ping me with all the details, I can do it for you.

Why is there over 100 comments on this PR ? @kimkimani
This would indicate the reviewer has been over exerting themselves.
This may have been a great candidate to close.!

Jumping on this one team 🚀

This is ready to be merged. Post change, we can merge it. Thanks :)

Hello @lalith1403. Its /engineering-education/authors/joseph-chege/

/engineering-education/authors/oyedele-temitope

@kimkimani Need your author folder name to add peer review contribution credit. @oyedeletemitope, double-check the author image that you have updated. Make sure to delete the previous one and rename this with the same file extension.

I'm going ahead with the previous image. I'll update it time


Load pubkeys before initializing ZPE client to avoid null exception

■Issue
ERROR com.yahoo.athenz.zpe.ZpeUpdPolLoader - loadDb Failed, exc: null

is outputted at the initialization of AuthZpeClient.
It's not critical (authentication / authorization process after the initialization works) but annoying.
■Detail

In the initialization of AuthZpeClient, ZpeUpdater is initialized.
In the initialization of ZpeUpdater, ZpeUpdPolLoader is initialized.
In the initialization of ZpeUpdPolLoader, loadDb is called
loadDb calls loadFile.
loadFile calls AuthZpeClient#getZtsPublicKey. However, since the public keys have not been loaded yet, null exception is thrown and caught here. As a result, the error log described above is outputted.

■Modification
I just reordered the statements to load the public keys before initializing ZPE client.

@nkurihar thanks for the PR.


Add rack-cors Gem and implement CORS to allow whitelisted Origins to …

…make HTTP requests.

@starkcoffee any chance u can take a quick look at this? You're the api queen :)

+1 Thx!

Actually is it necessary to whitelist sounddrop.audio? As our code will already be running under that domain? And the codepen.io api is not really needed as it isn't a general purpose api?

@starkcoffee they want to implement this b/c because they want to "make a black form in which a user or developer could type the api endpoint to see what she/he will get to make it easier to write the documentation and for us to understand how the api works"
They were using codepen to built it faster, and once it's done they can erase the codepen permissions.

@starkcoffee : Joe said that in one of his jobs he did this, because their own js couldn't access the requests.... so that is the reason and we could delete copen afterwards its only too build this sort of developer tool where you can see what each endpoint  will return and for us to write the documentation :)

ok, @starkcoffee and I chatted about it & it's cool. document away!


Make a light mode.

Please make a light mode for this number calculator, the dark theme is fine but the light theme would look much better.

Maybe later but not at the current stage of development. Thanks for the idea tho!


Deprecate the needsPasswordReset field of the JWTUser

Change-type: patch
See: https://github.com/balena-io/balena-api/pull/3665

@balena-ci I self-certify!


security update for openssl: 1.0.1l -> 1.0.1m

Errata: https://github.com/openssl/openssl/blob/OpenSSL_1_0_1-stable/NEWS
Major changes between OpenSSL 1.0.1l and OpenSSL 1.0.1m [19 Mar 2015]
o Segmentation fault in ASN1_TYPE_cmp fix (CVE-2015-0286)
o ASN.1 structure reuse memory corruption fix (CVE-2015-0287)
o PKCS7 NULL pointer dereferences fix (CVE-2015-0289)
o DoS via reachable assert in SSLv2 servers fix (CVE-2015-0293)
o Use After Free following d2i_ECPrivatekey error fix (CVE-2015-0209)
o X509_to_X509_REQ NULL pointer deref fix (CVE-2015-0288)
o Removed the export ciphers from the DEFAULT ciphers

This will break kde (cmake)

I might be to stupid to understand this. But how do I check for that ... I tried recompiling the other deps nox, however the output is too non-sensical.

Does anyone have a work-around for the KDE problem (on 14.12)? We shouldn't have broken KDE-4 on release.

I guess any package that detects openssl through cmake should break - I also see e.g. libgit and mysql55.

I been working on the KDE fixes since yesterday, taking some time given the size of KDE compilation.


bug: add platform to ionic

Type: bug
Platform: desktop browser
i'm new to ionic
i'm working on windows and i get this error when trying to add platform to ionic

Greetings @OussemosCh!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Are you using Node.js or io.js?

Can you try again, but pass the -d flag?
ionic platform add android -d

i get this ..


node-abi needs to be updated

Currently, running electron-forge start with electron version 4.x.x gives the error
An unhandled error has occurred inside Forge:
Could not detect abi for version 4.0.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
Error: Could not detect abi for version 4.0.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (C:\node_modules\node-abi\index.js:30:9)

Is there much that needs to be changed before electron-forge supports electron 4.x.x?
Electron changelog

For anyone else that runs into this problem and if you're using yarn: go into yarn.lock file, find entry for node-abi, delete it, then re-run yarn.
See https://github.com/yarnpkg/yarn/issues/4986#issuecomment-395036563

BTW: deleting the entry for node-abi works the same way for users of npm and the package-lock.json file.

I did a fresh installation with current version and I'm getting an updated version of this error:
An unhandled error has occurred inside Forge:
Could not detect abi for version 8.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

modifying the yarn.lock file is not helping

Had to delete node_modules and yarn.lock as well.


features/completion-suggestions differs from pressing TAB in subtle details

With features/completion-suggestions and strategy completion, the shown completion differs from that which is obtained by actually pressing TAB.
For instance, if /home is the only directory starting with /ho, then after cd /ho the suggested completion is cd /home while when pressing TAB would lead to 'cd /home/` (with a trailing slash). It would be much more convenient and less confusing to get the same result as with TAB.

It would probably also be helpful there would not be a longer suggestion shown than that which would be given by TAB (this even means no suggestion in the non-unique case).
Indeed, it is very confusing if after typing ls one receives the suggestion lsblk, or even worse after typing xma one receives the suggestion xmame.SDL (when also xmame.x11 and even xmame are binaries matching the same beginning), or if after typing ls /usr/bin/ one receives the suggestion ls /usr/bin/x11.
Especially if one is used to typing TAB frequently (or using auto-fu.zsh), this gives the wrong intuition that ls is actually not a complete command, that xmame.SDL is the only binary starting with xma (in particular, there is no xmame), or that x11 is the only  binary existing in /usr/bin/, respectively. (Note that x11 is not even the alphabetically first file there; in fact, the choice in the non-unique case seems to be random or depending on the disk hash function.)

I think #350 addresses all of your concerns here. Take a look when you can.

The “cd /home/” is now working, and also “/usr/bin/ ” is fine.
However, there is still “lsblk” and “/usr/bin/xmame.SDL” (despite xmame exists).
The latter is perhaps correct, because pressing 2 times tab shows indeed xmame.SDL before xmame in the completion list for some strange reason.

However, there is still “lsblk” and “/usr/bin/xmame.SDL”

Strange- this is fixed for me. When I type ls I do not get a suggestion. After typing a b, I do get a suggestion for lsblk.
Pressing tab when the buffer has just ls gives these results:
ls          lsblk       lsinitcpio  lslocks     lsmem       lsns        lspcmcia    lsusb.py
lsattr      lscpu       lsipc       lslogins    lsmod       lspci       lsusb

Note ls is first, so there is no additional suggestion shown.
I wonder if you have some option/zstyle set that is affecting the behavior for you. A couple questions for you:

What do you get when you press tab with just ls in the edit buffer (assuming you have zsh configured to list completions)?
What happens if you run zsh -f, initialize compinit, and source the plugin manually? Do you get different behavior?

The output was differently sorted for me. Binary searching in my .zshrc gave that the culprit was the line
zstyle ':completion:*' sort false

which is now rather unsurprising.
I am wondering why auto-fu.zsh does not extend ls to lsblk even with the above line.

I believe this ticket can be closed with #350 being merged to develop


ARIA-1 Parser test suite

This commit additionally fixes many parser bugs revealed by the test
suite, which includes adding validations that were missing.
A new "extensions" tox suite is introduced.
The /tests/parser cases were refactored into /tests/topology and
/tests/extensions.
The Hello World example was fixed and refactored, as it in fact had
invalid TOSCA (it previously passed due to a missing validation).
Parser performance was greatly improved by:

Switching to the YAML C library
Aggressive caching of parsed presentations
The ability to skip importing the TOSCA profile
A new deepcopy_fast util
A new BlockingExecutor that is much faster for single-threaded use

Unicode is now fully supported for all validation and log message. This
requires the use a unicode (u'' notation) for all .format specs.
Additionally, PyLint comment directives have been standardized by
pushing them to column 100.

Can one of the admins verify this patch?

BTW please don't squash your commits...


Could the file lookup path in ActiveYaml become a little more abstract?

While working on a gem that includes ActiveHash/Yaml as its data store, I wanted to be able to allow the consumer of my gem to override a default YAML file bundled within the gem, or keep on using the default if that's their preference. Because of the way that the file load is anchored to Dir.pwd (which in a Rails app becomes the app root directory), I couldn't work out a way to do this that didn't involve a generator to move the default data file into the parent app, rather than the customary "closest file wins" behavior that the load path usually exhibits.
I don't want to overload the file resolution code in ActiveYaml because I fear that may be a private API you could change at any time. Any suggestions where to look for a way out of this?
Thanks. And seriously, this is an excellent example of well-written code that does what it says on the tin.

@walterdavis Thanks for asking this question. I think we're open to making this more flexible if it would be helpful, but without more information about the problem you're trying to solve it's difficult for me to suggest an implementation.
Would you like to suggest something? Or share some code that demonstrates the problem you're having?
Specifically, I'm interested in knowing why ActiveYaml::Base.set_root_path doesn't allow you to work around this in the downstream library.

Sorry for the delay getting back to you about this. Here's what I'm trying to accomplish, and I may just be missing something in my own code, rather than there being anything missing in ActiveHash.
This gem (the one I wrote) contains a default "org tree" of the University of Pennsylvania. It's a single AH-backed model called Org, and each org knows it's parent (through a parent_id) and thus can also find its children.
class Org < ActiveYaml::Base
  set_root_path 'config'
  set_filename 'orgs'
  fields :parent_id, :name, :kind # (and others)

  include ActiveHash::Associations

  has_many :children, class_name: 'Org', foreign_key: :parent_id
  belongs_to :parent, class_name: 'Org'

  # etc.
end

I want to have all the orgs in a yaml file in the gem bundle, and I would also like to be able to "shadow over" that default file by adding a version of it in the Rails app that uses the gem, if needed. (Say, if the orgs need to be updated without revving the gem.)
What I found when trying to set this up was that I could not come up with a location within the gem for the yaml file that was also in the parent app's lookup path, such that the bundled version would be the last-ditch fallback, but anything more specific in the parent app would be preferred if it existed.
I know this is a feature I have seen in other gems, and I thought that it was pretty much something that railties gave you for free, as long as you put things in the correct nesting. (To that point, I have not included the module in my example code above, but I did have a properly nested mountable engine style gem as my test bed for this concept.)
What I ended up doing in the short term was writing an installer that would put the file into the parent app's config folder, and that got me to a working prototype. But I would still like to do this the way I wanted to initially.
If you have any suggestions, or if I haven't explained my problem thoroughly enough, please let me know.
Thanks as always,
Walter

On Oct 27, 2024, at 1:43 PM, Mike Dalessio @.***> wrote:
@walterdavis Thanks for asking this question. I think we're open to making this more flexible if it would be helpful, but without more information about the problem you're trying to solve it's difficult for me to suggest an implementation.
Would you like to suggest something? Or share some code that demonstrates the problem you're having?
Specifically, I'm interested in knowing why ActiveYaml::Base.set_root_path doesn't allow you to work around this in the downstream library.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@walterdavis Thanks for the thoughtful reply.

I know this is a feature I have seen in other gems

Can you give me a specific example? The only thing I can think of that does something like this is overriding Rails generator templates. In that case, the generator is carefully configured to look in a single place in a Rails app that matches the location of the template.
Equivalently, then, I would suggest your gem could do something similar:
class Org < ActiveYaml::Base
  if Rails.root.present? && File.exist?(Rails.root.join("config/orgs.yml"))
    set_root_path Rails.root.join("config")
  else
    set_root_path 'config'
  end
  # ...
end

Would that work for you?

Thanks, that's an interesting idea. I will give that a try. I'll also try to find a specific example of what I'm describing.
Perhaps it is more along the lines of how the view lookup paths work, where a resource can come from the app, or its vendor directory, or the combined app and vendor directories of any gems it bundles that include the Engine class. The effect I have noticed there is that if you have a "shadow" version of a gem's file in your app (including the gem module name in its path) then that file in your app is more authoritative than the one in the gem. It's effectively like you're monkey-patching that file. I've exploited that effect from time to time, when I needed to override something very specific.
Come to think of it, Devise views work this way. Also Kaminari pagination. You can just install the gem and get the vanilla view templates and partials, or you can use the gem's generator (or just write the files, if you know their names) to add the gem's assets to your app's views directory, and modify them there.
Walter

On Nov 2, 2024, at 5:40 PM, Mike Dalessio @.***> wrote:
@walterdavis Thanks for the thoughtful reply.
I know this is a feature I have seen in other gems
Can you give me a specific example? The only thing I can think of that does something like this is overriding Rails generator templates. In that case, the generator is carefully configured to look in a single place in a Rails app that matches the location of the template.
Equivalently, then, I would suggest your gem could do something similar:
class Org < ActiveYaml::Base
if Rails.root.present? && File.exist?(Rails.root.join("config/orgs.yml"))
set_root_path Rails.root.join("config")
else
set_root_path 'config'
end
...
end
Would that work for you?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

The point I'm trying to make in my reply above is that I believe path lookup logic belongs in your gem and not Active Hash.

Understood. Thanks very much.

On Nov 3, 2024, at 12:09 PM, Mike Dalessio @.***> wrote:
The point I'm trying to make in my reply above is that I believe path lookup logic belongs in your gem and not Active Hash.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


Add Nevada to list of approved states

Add Nevada to our list of live jurisdictions so NV facilities can sign up.

hehe was literally just making this pr as you pushed it. thanks!


How to handle https reverse proxy and resources

I have this error when I deploy my app to production :
webpack:///./~/react-helmet/lib/Helmet.js?:259 Mixed Content: The page at 'https://dev-app.domain.com/playground' was loaded over HTTPS, but requested an insecure stylesheet 'http://haltalk.herokuapp.com/explorer/vendor/css/bootstrap.css'.
This request has been blocked; the content must be served over HTTPS.

I could simply use https to access heroku, that would work. But after I will download resources over https in development while I don't need.
What is the appropriate approach ?

This is outside the scope of this project. Helmet itself is protocol-agnostic, it is up to the developer to request resources using the appropriate protocol.
I would suggest researching protocol-relative urls and choosing the best technique that fits your needs.


Setting Card.DueDate goes to the day before

Hi, I'm having problems setting the dueDate of a card.
var serializer = new ManateeSerializer();
TrelloConfiguration.Serializer = serializer;
TrelloConfiguration.Deserializer = serializer;
TrelloConfiguration.JsonFactory = new ManateeFactory();
TrelloConfiguration.RestClientProvider = new Manatee.Trello.WebApi.WebApiClientProvider();
TrelloAuthorization.Default.AppKey = "my app key";
TrelloAuthorization.Default.UserToken = "my user token";
var learningBoard = new Board("my board id");
string listId = learningBoard.Lists.First().Id;
var list = new List(listId);
var member = list.Board.Members.First();
var card = list.Cards.Add("test card 2");
card.DueDate=new DateTime(2016,07,21);

When running this snippet the dueDate on the card is changed to 2016,07,20 at 21:00. I tried with other Dates and it always gives the day before at the same hour. Is this expected and documented somehwere? Sorry if I missed something, just starting to use this API.

Tried getting the card and changing dueDate using the Card object resulted in the same issue.
var card = new Card("my card id");             var date = new DateTime(2016,7,19);             Console.WriteLine(date);             card.DueDate = date;

Hey there, @saulosag.  Sorry for the delayed response.
I'll create a test in my app to see if I can replicate what you're seeing.

Replicated.
Looking at the values that Trello is returning, it looks like they've changed their DateTime serialization format.  It used to be somewhat unformatted with an implied EST time zone, but now it looks like they're sending as UTC.  This is definitely part of the problem.  I'll get confirmation from Trello.

Thank you for replying, I'll wait further responses.

Please see Manatee.Trello.ManateeJson v1.5.1.


Which versions of swagger-core are actively supported?

Hi, hopefully this is an easy question. Is there documentation stating which versions of swagger-core are actively supported with security backports? For example, "only the latest v2.2 and v1.6 releases receive any type of update" or "security fixes are backported to the last n minor releases"?
Also, are there any published end-of-life dates for minor versions?
Thanks!

Thank you for reaching out, I don't think we have this explicitly documented.
For the Swagger Core project, we actively support and provide updates, including security backports, to the latest minor versions within both the 1.x and 2.x lines (currently 1.6 and 2.2). We do not backport security fixes to previous minor versions.

Hi, @frantuma! When will end support of 1.* versions?


Filter out deleted files before formatting

Without the filter when committing if a file was deleted the plugin tries to format it and fails with the message:
fatal: pathspec '<FILE>' did not match any files
More info on the filter: https://git-scm.com/docs/git-diff#git-diff---diff-filterACDMRTUXB82308203

Thank you !


Questionmark in content breaks syntax highlighting

As you can see, after Reset form fields?, the highlighting is broken, when I remove the questionmark it works fine

With the current implementation you'll have an ordinary JavaScript context between tags – the ? starts a ternary operator here (you can see this when typing ?:).
To fix this we should resolve text between tags to text like the HTML grammar does and only parse JavaScript inside curly braces. I have to check if it is possible to implement this.
As a simple workaround until then is wrapping the string in {'…'}, which is also recommend elsewhere:
<ActionDialog>
  {'Reset form fields?'}
</ActionDialog>

I have to check if it is possible to implement this.

Cool, in the meantime wrapping will do, thanks.

@koenpunt I still haven't figured out how to nicely change the scope inside pairing tags, but the latest update here together with the updated Javascript bundle should fix this behavior.

I still haven't figured out how to nicely change the scope inside pairing tags

You could ask on the TextMate mailing list, people on there tend to be very helpful: http://lists.macromates.com/listinfo/textmate

Thanks to @infininight this should be fixed and work like expected. Now a question mark isn't even highlighted anymore (as JavaScript is not parsed between tags, except inside braces).


Dictionary format

Hi,all
I want to konw the format of morfologik's dictionaries, I think it's not just like below:
Abe+I
Abel+J
Abelard+F
Abelson+E
Aberconwy+E
I want to know more detail about it, and how to use it.
Thanks advance.

The source code is the best documentation we have. Please do not open issues, use the mailing list<EMAIL_ADDRESS>for this type of communication.
https://github.com/morfologik/morfologik-stemming/blob/master/morfologik-stemming/src/main/java/morfologik/stemming/DictionaryLookup.java#L281

The encoder actually has some more information:
https://github.com/morfologik/morfologik-stemming/blob/master/morfologik-tools/src/main/java/morfologik/tools/SequenceEncoders.java

Thank you very much.


df to data

In edarf version 0.1 the argument for the data frame seems to be data rather than df.

yep thanks, saw that but was too busy to fix!


User git can login to server by ssh, but can not pull or push repository

Gitea Version
1.15.6
Git Version
2.31.1
Operating System
fedora 34
How are you running Gitea?
[root@fedora home]# cat /etc/systemd/system/gitea.service
[Unit]
Description=gitea

[Service]
Type=simple
User=git
Group=git
ExecStart=/usr/local/bin/gitea web --work-path /home/git/gitea/appData --config /home/git/gitea/app.ini
WorkingDirectory=/home/git/gitea/

[Install]
WantedBy=multi-user.target

with configure:
[server]
SSH_DOMAIN       = <IP_ADDRESS>
DOMAIN           = <IP_ADDRESS>
HTTP_PORT        = 3000
ROOT_URL         = http://<IP_ADDRESS>:3000/
DISABLE_SSH      = false
SSH_PORT         = 22
LFS_START_SERVER = true
LFS_CONTENT_PATH = /home/git/gitea/data/lfs
LFS_JWT_SECRET   = ********
OFFLINE_MODE     = false
START_SSH_SERVER = false

I create a user named git to run gitea.
Database
SQLite
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
I can log in the host by the user git via ssh.
# ssh<EMAIL_ADDRESS><EMAIL_ADDRESS>password:
Last login: Mon Nov  1 21:33:59 2021

But when I try to connect to the repository, I get  this error:
# git push origin master
<EMAIL_ADDRESS>password:
fatal: 'garfeng/hello_world.git' does not appear to be a git repository
fatal: 无法读取远程仓库。

请确认您有正确的访问权限并且仓库存在。

Please see, It let me to input password of git. I input the right passwd, but get the error
Screenshots
No response

I have get the answer from my friend， it was because of the path of local  ssh key is not ~/.ssh/id_rsa.
Following env value works.
export GIT_SSH_COMMAND="ssh -i ~/.ssh/id_rsa_example"


I find an ERROR of the ground truth pose processing!

Hi,
Thank you for sharing this wonderful work!
A lot of the current registration works follow your evaluation metrics. However, I recently find an error in "data_loaders.py". The line 467 "M2 = M @ reg.transformation" should be "M2 = reg.transformation @ M". I have done several tests and am pretty sure of this. Could you check this and tell if it is right.Thanks!

in open3d, PointCloud.transform(transformation) means transformation @ PointCloud

Definitely, so M2 should be calculated as transformation @ M.
施成浩
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "chrischoy/FCGF"                                                                                @.>;
发送时间: 2022年9月6日(星期二) 上午10:25
@.>;
<EMAIL_ADDRESS>主题: Re: [chrischoy/FCGF] I find an ERROR of the ground truth pose processing! (Issue #65)
in open3d, PointCloud.transform(transformation) means transformation @ PointCloud
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>