xGov-18 - coq-avm library

Clarification
The aim of the coq-avm library is to provide a toolset that helps developing
formal verification proofs for smart contracts in Coq.
A good overview on formal verification can be found here:
https://ethereum.org/en/developers/docs/smart-contracts/formal-verification/
(although it is Ethereum related, the main concepts still apply).
Dfferences to K framework
Runtime Verification Inc. created the K framework also
implemented an
AVM semantics module
that can be used to verify programs that target the AVM.
How K framework differs from Coq:

Coq is a general purpose interactive theorem prover
K framework is a specialized semantics framework
Coq is developed from the 1980s
K framework is fairly new, first publication is around the 2010s

Advantages/disadvantages of using Coq:

Coq is regarded as a highly trusted tool when used with the Coq standard
library (no additional axioms). (See also: https://github.com/coq/coq/wiki/Presentation#what-do-i-have-to-trust-when-i-see-a-proof-checked-by-coq, https://mathoverflow.net/questions/59520/how-true-are-theorems-proved-by-coq)
Coq was around for longer, used in more projects, hence inconsistencies/problems are
much more likely to have been discovered/fixed.
Since it was around longer, it is much more discussed in academia and in engineering
circles, hence it is likely that developers/researchers are more experienced in its
use.
Coq has plenty of useful libraries implemented over the years, more tooling and
also has general purpose mathematics modules.
The coq-avm library targets AVM byte code, not a specific language (TEAL, pyTeal,
etc.), thus language independent (any program that is compiled to AVM byte code
can be used as a source).

Advantages/disadvantages of using K framework:

Specialized framework, potentially more easy to develop executable sematics modules
targetting different languages.
Language specific implementation, it seems to me that KAVM targets the TEAL language
only.

Opportunities

An open source coq-avm library could help in designing new AVM instructions.
Possible to prove compiler consistency (e.g. all programs executed with version 7
provide the same results when they're executed with version 8).
Utilizing Coq program extraction would make it possible to generate AVM implementations
in the supported languages (e.g. OCaml, Scheme and Haskell). However, since the main
purpose of the library is precision not performance, the extracted programs may not
be the most effective.
Currently coq-avm provides a way to execute and "step through" (debug) 25 of the
AVM version 8 op codes. (Although using this tool might be unintuitive for developers not
familiar with Coq.)

Hi, i am programmer, but i dont know much about formal proofs.. Can you elaborate little more on the benefits? Who will benefit from this?
I did read

## Benefits for the community
- Executable semantics for TEAL programs.
- Formal verification of Algorand smart contracts using Coq.
- Development of formal specification on the behaviour of op codes.
- Potential to provide formal proofs on smart contract/logicsig execution consistency between
  different versions of AVM. Prerequisite: implementation of the interpreter for other versions.
- Providing alternative to the AVM semantic library of the K Framework.
- Toolset/tactics for developers to create formal proofs of AVM programs.

By "Executable semantics for TEAL programs" you mean that we will have nice flow charts on the teal apps?
By "Formal verification" you mean that if anybody writes any byte code, you tell true or false if it complies with specific standard of teal? Can you just decompile teal and compile and check if it produce same bytes?
By "Toolset/tactics for developers to create formal proofs of AVM programs"  you mean that developers have to write some proofs that their programs are really compiled to teal?
Or do you mean that you create some testing framework for algorand smart contacts/logic sigs that runs without the node?
Btw if you are deep into teal, please consider working on teal to pyteal decomiler. I think whole community would appriciate this. It would boost growth of the ecosystem as anybody could just decompile into more readable programs any applications out there, it would easy the audits and more..

Hi!
Coq is usually used to state and prove mathematical properties of programs through equivalent transformations (reductions based on semantic rules). This way of verfying programs is usually referred to as formal verification. The attached pdf can provide more details, I'm also available for an online discussion to clarify the concepts further.

Ok, let me rephrase the question..
The AMM algorighm is simple matematical formula which should be implemented in the smart contract.
Do you expect AMM providers to create "mathematical proof" that their smart contracts are valid? How would it look like?
What advantages would this type of proof would have in comparision with standard unit,integration and end2end testing?

I think there is a huge misunderstanding. I do not expect anyone to do anything, except myself.
Programs/functions are formally specified by providing formal pre- and post-conditions. There is a very good example on page 6 of the pdf present in this PR: https://github.com/algorandfoundation/xGov/blob/759447da9ab17807bfe4f26d0800358d755e0899/Proposals/coq-avm-introduction.pdf , please have a look.

The specifics of this proposal go beyond my understanding and I'd image similar applies also for many xGovs.
Therefore, if you hope to get the grant approved, I would suggest to:

Add more of your qualifications to deliver this, e.g. a link to your LinkedIn https://hu.linkedin.com/in/mark-petruska-1a611527, and links to similar projects you have developed/contributed to and how widely used they are.
How will xGovs be able to verify your deliverables? Can you for example get some developers experienced in the field to attest to your deliverables?
Can you tag some other developers that would use this tool once its built?
How will the grant be spent? Will ALGO be sold on the market? If yes, using DEXs or CEXs? Or will a loan be taken against it in DeFi/CeFi?

P.S. Perhaps @joe-p, @jannotti, @cusma, @FrankSzendzielarz could chime in to help xGovs understand the soundness of this proposal.


0.56 regression: jest.mock only works when defined in jestSetup.js, not in individual Snapshots tests

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
   System:
     OS: macOS High Sierra 10.13.2
     CPU: x64 Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
     Memory: 69.35 MB / 8.00 GB
     Shell: 3.2.57 - /bin/bash
   Binaries:
     Node: 8.11.2 - /usr/local/bin/node
     Yarn: 1.7.0 - /usr/local/bin/yarn
     npm: 5.6.0 - /usr/local/bin/npm
     Watchman: 4.9.0 - /usr/local/bin/watchman
   SDKs:
     iOS SDK:
       Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
     Android SDK:
       Build Tools: 23.0.1, 23.0.3, 25.0.2, 25.0.3, 26.0.1, 27.0.3
       API Levels: 23, 25, 26, 27
   IDEs:
     Android Studio: 3.1 AI-173.4819257
     Xcode: 9.4/9F1027a - /usr/bin/xcodebuild
   npmPackages:
     react: 16.4.1 => 16.4.1
     react-native: 0.56.0 => 0.56.0
   npmGlobalPackages:
     create-react-native-app: 1.0.0
     react-native-cli: 2.0.1

Description
Hi there, thanks for taking the time to read this and thanks for the many fixes in the 0.56 upgrade. Sadly I believe this is a regression. This was working fine on 0.55. I cannot afford the technical debt of not upgrading to the latest RN version as the upgrade procedure is too time-expensive.
I have jest mocks (mocked functions, modules and components) in my jestSetup.js file (pointed to from package.json), and I also have mocks in individual test files, including unit tests and snapshot tests.
In my individual snapshot tests, the mocks do not work anymore - the mocks exist (I can console.log them) but when the snapshot tests are run, the mocked functions are not called - instead the "real" functions are called. This is NOT the case for mocks defined the SAME way but placed in jestSetup.js - the snapshots call the mocked functions as expected when they are defined in jestSetup.js.
I have moved as many mocks as possible to jestSetup.js but unfortunately some tests require the functions to be unmocked (e.g. unit tests) so this cannot fix all my new errors caused by upgrading to
0.56.
Please let me know if there is a workaround and if a fix is on the horizon.
Reproducible Demo
Example snapshot test with mock that doesn't work unless moved into jestSetup.js
import 'react-native';
import renderer from 'react-test-renderer';
import React from 'react';
import sinon from 'sinon';

jest.mock(
  '../../src/components/common/ProfilePicture/StarredPicture/StarredPicture',
  () => () => { return ''; },
);

test('renders correctly', () => {
  const stub = sinon.stub(console, 'error');
  const tree = renderer.create(<Profile />).toJSON();
  const tree = renderer
    .create(<Profile />)
    .toJSON();
  expect(tree).toMatchSnapshot();
  // call count is one to reflect one required proptypes.
  expect(stub.callCount).toEqual(1);

package.json
"jest": {
    "automock": false,
    "preset": "react-native",
    "setupFiles": [
      "./src/jestSetup",
    ],
    "transform": {
      "^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
    },
    "transformIgnorePatterns": [
      "node_modules/(?!@expo)/"
    ],
    "collectCoverageFrom": [
      "src/**/*.js"
    ]
  }

We are experiencing the same issue after uplifting to RN 0.56 from 0.55.4

I ran into this issue after getting the tests working in 0.56.0. It looks like the React Native transformer doesn't include the jest-hoist babel plugin. This plugin is required for mocks to work correctly.
To fix it for now I added jest-hoist to my own .babelrc file.
{
  "presets": ["react-native", "@babel/flow"],
  "plugins": ["jest-hoist"],
  "sourceMaps": true,
  "retainLines": true
}

@StevenLambion according to the doc on jest-hoist

This plugin is automatically included when using babel-jest.

since react-native is using babel-jest im not sure how adding it would make a difference.
I could be wrong here because i dont understand it very well but adding it in babelrc did not fix the issue for us

Looks to me like a duplicate of https://github.com/facebook/react-native/issues/19859

Followed the advice of @StevenLambion and combined it with adding the below packages to yarn (as per the link kindly provided by @kelset). I then deleted node modules (paranoia) and yarn installed. This made all the tests pass.

"@babel/core": "^7.0.0-beta.47",
"babel-core": "^7.0.0-beta.47",
"babel-jest": "^23.2.0",
"babel-plugin-jest-hoist": "^23.2.0",

Good, I'll close this for now, and reopen if I have strong evidences it's actually something else.

thanks a lot @StevenLambion @TomJamesDuffy, this issue really made me pull my hairs out.

@StevenLambion @TomJamesDuffy - You guys just saved me at least a day of trying to figure this out. Thanks for your contribution.


[WIPTEST] Fix ensure_state fail when VM is in starting state

This PR fixes scenarios where method ensure_state(VmState.STOPPED) is called:
https://github.com/ManageIQ/wrapanapi/blob/ad764e7e5a50773a12e614f5a4f05e83d8e2bd93/wrapanapi/systems/rhevm.py#L182
If I understand correctly, the problem is that this method is sometimes called when the VM to be deleted is in state VmState.STARTING. Subsequently, this call doesn't wait for the VM to get to  VmState.RUNNIG and the self.stop action is called right away:
https://github.com/ManageIQ/wrapanapi/blob/ad764e7e5a50773a12e614f5a4f05e83d8e2bd93/wrapanapi/entities/vm.py#L282
The result is then the following exception:
Error: Fault reason is "Operation Failed". Fault detail is "[Cannot remove VM. VM is running.]". HTTP response code is 409.
This can be observed for example in PRT in test cases that remove the VM relatively shortly after provisioning is completed:
http://infra-trackerbot2.cfme2.lab.eng.rdu2.redhat.com/pr/run/25936

Lint report for commit abca47191a0d8c118e074c5f0c98475ee6358871:
wrapanapi/entities/vm.py:

:bangbang: Line 279:101: E501 line too long (104 > 100 characters)

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot


Cursor jumps around with completions

I have noticed an issue when using HTML where the cursor jumps away from where it should be. It also seems to corrupt the undo history making the change hard to undo. The issue is present in Vim and Neovim.
Here is a bare minimum vimrc to make testing easier:
" Saved as ~/minimalrc
set nocompatible

let install_cmd = []
call add(install_cmd, 'rm -rf /tmp/asyncomplete-test')
call add(install_cmd, 'mkdir -p /tmp/asyncomplete-test')
call add(install_cmd, 'git clone --depth 1 https://github.com/prabirshrestha/asyncomplete.vim.git /tmp/asyncomplete-test/asyncomplete.vim')
call add(install_cmd, 'git clone --depth 1 https://github.com/yami-beta/asyncomplete-omni.vim.git /tmp/asyncomplete-test/asyncomplete-omni.vim')
execute 'silent !/bin/sh -xc "' . join(install_cmd, ' && ') . '"'

let &runtimepath.=','.escape('/tmp/asyncomplete-test/asyncomplete.vim', '\,')
let &runtimepath.=','.escape('/tmp/asyncomplete-test/asyncomplete-omni.vim', '\,')

filetype plugin indent on

autocmd User asyncomplete_setup call asyncomplete#register_source(
  \ asyncomplete#sources#omni#get_source_options({
    \ 'name': 'omni',
    \ 'whitelist': ['*'],
    \ 'completor': function('asyncomplete#sources#omni#completor')
    \  })
  \ )

Use the command: vim -u ~/minimalrc a.html and then go into insert mode and type:
<div id="a

You should notice that after typing 'a' the cursor jumps to the beginning of the line.

I think htmlcomplete change cursor position.
https://github.com/vim/vim/blob/master/runtime/autoload/htmlcomplete.vim#L97

Interesting. I take from your response that it is not a great idea for a complete function to do that but I am not too familiar with them. Do you think I should look for a different complete function or that the problem should be handled by asyncomplete.vim/asyncomplete-omni.vim /cc @prabirshrestha
I searched the Vim source for call cursor and it comes up in phpcomplete.vim, rubycomplete.vim and sqlcomplete.vim so there may be potential problems there too.

It can't be fixed by in asyncomplete. The omni-func needs to be fixed. One temporary option would be to do this.
  There is a LSP for html but I haven't tried it yet. https://www.npmjs.com/package/vscode-html-languageservice
For php I reocmmend using LSP. https://github.com/prabirshrestha/vim-lsp/wiki/Servers-PHP. LSP adds support for things like go to def, rename, find symbols, linting, code completion and much more.
here is how my vimrc looks like. https://gist.github.com/prabirshrestha/279d8b179d9353fe8694/7a291666de64748efe32c24b13c9263198a4fe1c#file-vimrc-L178-L248.

@casr might be good to start the discussion on https://github.com/vim/vim about call cursor

Thank you both very much for your responses and suggestions. I think as the problem is isolated to a few filetypes I am quite happy to disable them for now.
I could not get the vscode-html-languageservice package to work. I think it might need a wrapper around it to launch a more LSP-y server.
@prabirshrestha thanks for a sharing your vimrc. Lots of useful things in there!


Allow comparing two different commits.

I love the ability to look up changes from previous commits. It would be great if we could compare two different commits and see what all has changed.

GitLens appears to have that: https://github.com/eamodio/vscode-gitlens/tree/master/#compare-view-


Replace state enhancers with components using render props

As the title says, this PR replaces the state enhancers (high-order components) with state components using render props.
I've been discussing this with some people on Twitter (https://twitter.com/diegohaz/status/978335493023821824) and after some feedbacks I decided to make this change.
It's important to note that this is a breaking change. State enhancers with HOCs will no longer work. So, of course, it will be released only on v0.7.0 (since we are at 0.x.x, minor version becomes the major one).
Also, that's the first step to add global state (with the new context API).

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          21     22    +1
  Lines         230    233    +3
  Branches       70     58   -12
=====================================
+ Hits          230    233    +3

Impacted Files
Coverage Δ

src/components/Tabs/TabsState.js
100% <100%> (ø)

src/components/Step/StepState.js
100% <100%> (ø)

src/components/Popover/PopoverState.js
100% <100%> (ø)

src/components/Hidden/HiddenState.js
100% <100%> (ø)

src/utils/mapStateToSelectors.js
100% <100%> (ø)

src/utils/mapStateToActions.js
100% <100%> (ø)

src/utils/getDerivedStateFromProps.js
100% <100%> (ø)

src/components/Hidden/index.js
100% <100%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6116ca2...67639ba. Read the comment docs.


[Feature 1.11.2] Compatibility to Storage Drawers

It's no bug or big deal and I don't know whether this has ever worked before. I checked that out yesterday.
Mekanism: <IP_ADDRESS>7 (latest release)
Forge: <IP_ADDRESS>6 (recommended)
StorageDrawers 4.2.10 (latest release)
Osmium seems not to be compatible with "Compacting Drawers", because it's not splitting into block, ingot, nugget within this drawer.
It works fine with metal parts from Thermal Foundation and Immersive Engineering.
I don't use a predefined modpack.

It seems to be working fine over here. Just the osmium ingots and blocks, as there are no nuggets.

Sidenote: you're not using the latest Mekanism version ;)

Aaah, I see what you mean. If I insert the block first, it doesn't work. If I insert the ingot first it does work.
Sounds like a problem with StorageDrawers.

ok, might be a problem elsewhere in my pack of mods... :) thx

No problem ;) If you've found it, would you let me know? Might come in handy

@thommy101 It could be partially our fault, depending on how the ingot/block recipes are registered. IIRC SD has an API call that we can use to ensure it can read our recipes

They check if the item inserted gives 9 of an other item back and the other way if 9 items of x result in 1 of another type. Think it's all automated without hardcoding.

/**
 * Recipe handlers are used by compacting drawers to find more-compressed forms of blocks and items.  If your recipe
 * to craft compressed items is a custom IRecipe implementation, you will need to register a handler for it.
 */

That would explain a lot, we use a custom IRecipe for almost everything (in 1.11, 1.12 has changed it a lot)


Fixing hres oriented runthrough

IceNet version: 0.2.1

Description
As they've not been in general use, it appears some HRES commands have not been correctly updated. These need fixing through running of an exemplar workflow
What I Did
icenet_process_hres -r processed/current_north/era5/north     $PROC_ARGS_ERA5 -v -l 1     -ts $DATE -te $DATE     hrestest_north north

[26-01-23 13:53:30 :INFO    ] - Writing configuration to ./loader.hrestest_north.json
Traceback (most recent call last):
  File "/data/hpcdata/users/jambyr/miniconda3/envs/icenet/bin/icenet_process_hres", line 33, in <module>
    sys.exit(load_entry_point('icenet', 'console_scripts', 'icenet_process_hres')())
  File "/data/hpcdata/users/jambyr/icenet/icenet.blue/icenet/data/processors/hres.py", line 52, in main
    linear_trend_days=args.forecast_days,
AttributeError: 'Namespace' object has no attribute 'forecast_days'

If this mapping is wrong, there'll likely be others, so will fix under this issue and get the HRES workflow running again.

Should have referenced it, but this is to enable further conclusion of the accumulated var issue in #52


Choosing a TypeScript style guide

We haven't yet chosen the TypeScript style guide, so the discussion of style in PR is growing unnecessarily.
Like this: https://github.com/yorkie-team/yorkie-codepair/pull/10#discussion_r528686623
We have to decide on a style guide.

It seems that Airbnb JavaScript Style Guide is referenced a lot these days. (but some say it is too strict 😉)

https://github.com/airbnb/javascript
https://github.com/typescript-eslint/typescript-eslint
https://www.npmjs.com/package/eslint-config-airbnb

How about starting https://github.com/airbnb/javascript ??

I agree because I prefer 'Airbnb style'.
For the features provided only in some TypeScript, I suggest the TS style guide of Typescript deep dive.
https://basarat.gitbook.io/typescript/styleguide#interface
https://basarat.gitbook.io/typescript/styleguide#type
https://basarat.gitbook.io/typescript/styleguide#type
https://basarat.gitbook.io/typescript/styleguide#enum
https://basarat.gitbook.io/typescript/styleguide#array
https://basarat.gitbook.io/typescript/styleguide#type-vs-interface

The opinions of the members seem to be gathered.
It would be nice to add TS style guide to the Airbnb style guide to introduce a linter and check it in CI.

I have a problem while this job work.
There was an import cycle between actions and reducers.
https://github.com/yorkie-team/yorkie-codepair/blob/master/src/reducers/docReducer.ts#L4
https://github.com/yorkie-team/yorkie-codepair/blob/master/src/actions/docActions.ts#L5
I moved it to actions, but please check🙇♀
https://github.com/ppeeou/yorkie-codepair/commit/8b3f617fa9eb8c4052a72070fd5579756df365e0
Except for this, there are no major changes.
First, only the basics were applied.

@ppeeou Thanks for the tip. If you create PR, it would be nice to look at the import cycle problem.


agglomerateByPrevalence: Unknown category

The function agglomerateByPrevalence (and agglomerateByRank) work fine but there is one shortcoming. When the agglomeration is done to the higher level ranks (e.g. from ASV to Genus), then the features (rows) with missing rank information (e.g. NA genus in our example) are ignored. As a result, the agglomerated relative abundance matrix does not sum up to 100%, for instance.
This is not incorrect but what remains missing is the information of the abundance of reads that were missing the rank information (see example below). This could be calculated as 1-colSums(assay(tse, "relabundance")). However, in some cases it would be handy to have a category that corresponds to unclassified reads. For instance, a row feature with the name "Unclassified". This would be handy for some methods.
Two possible solutions:

Add a function argument that allows the inclusion of "Unclassified" category during the aggregation for those reads that are missing the rank information at the given level; this argument could be off by default; or
Add an example that shows how to replace NAs in rowData with the category "Unclassified" before aggregation.

The latter solution might be preferred if the first one makes the function too complicated to understand and use.
At the same go, it would help to improve the manpage and examples of agglomerateByPrevalence, it is somewhat poorly documented currently. Consider a own dedicated manpage for this function.
library(mia)
data(GlobalPatterns)
tse <- GlobalPatterns
tse <- transformSamples(tse, "counts", "relabundance")

# Features with missing Genus mapping
inds <- which(is.na(rowData(tse)$Genus))

# Agglomerate the data to the Genus level,
# combine by prevalence but in practice do not filter anything
# with zero thresholds. This results in just aggregating the genera
# without filtering. Same as agglomerateByRank (which must be checked, too).
tse2 <- agglomerateByPrevalence(tse,
                             rank = "Genus",
                             detection = 0/100,
                             prevalence = 0/100,
                             as_relative = TRUE,
			     other_label = "Other")

# The read counts are the same between:
# 1) original (ASV level) assay data
# 2) agglomerated genus level data
# when reads with no genus mapping are ignored;
# (same would hold for relabundances)
range(colSums(assay(tse, "counts")[-inds, ]) -
      colSums(assay(tse2, "counts")))

# However, the aggregated data does not have 100% relative abundance sum
# because the agglomeration function did not count the ASVs with NA genera.
print(colSums(assay(tse, "relabundance")))
print(colSums(assay(tse2, "relabundance")))

Please read ?agglomerateByRank and have a look at the na.rm argument.
> data(GlobalPatterns)
> tse <- GlobalPatterns
> tse <- transformSamples(tse, "counts", "relabundance")
> tse2 <- agglomerateByRank(tse, rank = "Genus", na.rm = FALSE)
> range(colSums(assay(tse, "counts")) -
+           colSums(assay(tse2, "counts")))
[1] 0 0

Please read ?agglomerateByRank and have a look at the na.rm argument.
> data(GlobalPatterns)
> tse <- GlobalPatterns
> tse <- transformSamples(tse, "counts", "relabundance")
> tse2 <- agglomerateByRank(tse, rank = "Genus", na.rm = FALSE)
> range(colSums(assay(tse, "counts")) -
+           colSums(assay(tse2, "counts")))
[1] 0 0


dep on deno 1.40

We cannot apply this yet as deno 1.40 shouts about deprecation warnings in libpkgx that we cannot remove.

what a truly odd design choice. those should be compile-time emissions for 'compiled' output.


Automated cherry pick of #5017: Avoid ServiceCIDR flapping on agent start
#5495: Do not apply Egress to traffic destined for ServiceCIDRs

Cherry pick of #5017 #5495 on release-1.11.
#5017: Avoid ServiceCIDR flapping on agent start
#5495: Do not apply Egress to traffic destined for ServiceCIDRs
For details on the cherry pick process, see the cherry pick requests page.

/test-all
/test-ipv6-all
/test-ipv6-only-all
/test-windows-all


CreateService Example and Support

Add support to copy one FeatureService from one AGOL to another AGOL.  I believe CreateService is what is required.
http://resources.arcgis.com/en/help/arcgis-rest-api/index.html#/Create_Service/02r30000027r000000/

I'm curious if there has been any progress on being able to create a feature service. I was toying with publishserviceparameters but did not see a way to provide the service and layer definition in a single string of json. It would be awesome to create a service from just json, without needing to put that definition in an sd file.
Most of my services are nearly identical to each other with minor tweaks to domains, templates, and symbols. I don't need to use ArcMap for symbols since I define the drawing info from urls (i.e. {                 "value": "Ash, Green",                 "label": "Ash, Green",                 "symbol": {                   "angle": 0,                   "xoffset": 0,                   "yoffset": 0,                   "type": "esriPMS",                   "url": "http://dabuttonfactory.com/button.png?t=X&f=Droid+Serif&ts=31&tc=f0f&hp=8&vp=13&c=round&bgt=unicolored&bgc=cdff00",                   "width": 9,                   "height": 9                 }               }). The time savings would be huge if I could create new empty services from a single definition file. I wonder how a new service is made from an existing service as a template under the AGOL My Contents page?

These docs may be useful

Create Feature Service
Add to Layer Definition

punched up the sample tonight - https://github.com/Esri/ArcREST/blob/SecurityHandler_Token/samples/copy_feature_service_def.py
it is only in the security handler branch, which is functional, just not fully tested.


Change "gcloud" to "gcloud-ruby" in docs

refs GoogleCloudPlatform/gcloud-common#142
[fixes #725]

Wonderful!


⚠ Bofrost.de has degraded performance

In 9337e71, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 969 ms

Resolved: Bofrost.de performance has improved in cb4a010 after 6 minutes.


⚖ Register Validator: HoodRun

Network Choice
drunemeton-1
Who are you?
HoodRun is your go-to platform for top-tier testnet services and blockchain education. We provide specialized tools, promote participation in diverse testnets, and consistently support our user community. Simply put, HoodRun is your trusted guide in the complex blockchain landscape.
Delegator address
okp41zxyt0dnvzuhq24zmp4c7cwfwnzft40cqyj3y2d
gentx
{
  "body": {
    "messages": [
      {
        "@type": "/cosmos.staking.v1beta1.MsgCreateValidator",
        "description": {
          "moniker": "HoodRun",
          "identity": "D7F99CBB63FFFD9E",
          "website": "https://hoodrun.io",
          "security_contact"<EMAIL_ADDRESS>          "details": "Discover and Unlock the HoodRun Advantage; We make the Staking Experience the fastest and safest"
        },
        "commission": {
          "rate": "0.050000000000000000",
          "max_rate": "0.200000000000000000",
          "max_change_rate": "0.050000000000000000"
        },
        "min_self_delegation": "1",
        "delegator_address": "",
        "validator_address": "okp4valoper1zxyt0dnvzuhq24zmp4c7cwfwnzft40cq34pd5v",
        "pubkey": {
          "@type": "/cosmos.crypto.ed25519.PubKey",
          "key": "PQ3KZgFdJWEBv3/Kr9nSajkFn0vtFWfoyzhEsuDQMjQ="
        },
        "value": {
          "denom": "uknow",
          "amount": "10000000000"
        }
      }
    ],
    "memo": "1b0bf9ae98455ae45033c388b8c65629a7e5d454@<IP_ADDRESS>:26656",
    "timeout_height": "0",
    "extension_options": [],
    "non_critical_extension_options": []
  },
  "auth_info": {
    "signer_infos": [
      {
        "public_key": {
          "@type": "/cosmos.crypto.secp256k1.PubKey",
          "key": "AxYKW1lOEMLIOw3dJItXdZZw0+r54cW/NGmQF7R8EaiO"
        },
        "mode_info": {
          "single": {
            "mode": "SIGN_MODE_DIRECT"
          }
        },
        "sequence": "0"
      }
    ],
    "fee": {
      "amount": [],
      "gas_limit": "200000",
      "payer": "",
      "granter": ""
    },
    "tip": null
  },
  "signatures": [
    "sHaCh1GZz86PQoylbpaoNZHZu3jy/snvsL1IhPUU6yJnXDofqYh8ndPKUKM8IASMBy70bqvUgX4ZmyK2XyTMHA=="
  ]
}

😢 I couldn't process your request...


btctradeua: fetchBalance(): error handling added

@kroitor well, with the last python linting error I don't really know what to do.
Help needed.

@mkutny that is an unrelated error of mine ;)

@mkutny oh, and see how I do it for Python in the above commit - it requires checking the keys prior to accessing them, otherwise throws a KeyError.


Demo creation process

[ ] Write the guidelines for this process
[ ] Put it in the Demo repo.

References:

#430
@oluademola 's Notion page on updating demos (private link)
How to use Figma to design a demo (private link)

Add analytics to the code


[KOGITO-7228] Refactor jbpm-bpmn2 module

move xpath to builder as bpmn2 parser is not responsible to build
anything.

JEnkins test this please

Jenkins retest this please

Jenkins retest this

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@cristianonicolai why the message "Can one of the admins verify this patch?" is triggered ?


Storybook : Carrousel for similar products

User story
Who: As a developer
What: I want to have a carousel with 3 images to show similar products
Why: so that users can see similar products on one page when you select a product from the list.
Acceptance criteria
Create a storybook component as shown in the picture

Implimentation details
We can use the Carrousel component created for monthly arrivals to display with different props for similar products.

Repeated component. Issue#4 : https://github.com/HackYourFuture-CPH/fp-class18/issues/4

The carousel component is not showing images on Heroku. So fix is required.


[Bug] freeze column cannot come across merged cells

Initial checklist

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions

Steps to reproduce
从右键菜单或者拖拽来设置冻结行列
Expected behavior
如果穿越了一个合并单元格，要报错并禁止操作
Actual behavior
冻结行列穿越了合并单元格
Runtime
No response
OS
No response
Build and bundle tools
No response

Initial checklist

[x]  Is this really a problem?
[x]  I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions
Steps to reproduce
从右键菜单或者拖拽来设置冻结行列
Expected behavior
如果穿越了一个合并单元格，要报错并禁止操作
Actual behavior
冻结行列穿越了合并单元格
Runtime
No response
OS
No response
Build and bundle tools
No response

Excel 中是可以冻结是可以穿过合并单元格的，并且合并单元格也可以穿越冻结，是否不必要禁止这一点

Excel 中是可以冻结是可以穿过合并单元格的，并且合并单元格也可以穿越冻结，是否不必要禁止这一点

cc @DR-Univer What is your opinion?

Google sheet无法穿越冻结的，excel和microsoft365是可以的。反之在冻结场景下合并单元格跨域冻结同理

Closed as expected.


Tp2000 556 duplicate task id error in workbasket admin

TP2000-556 duplicate task id error in workbasket admin

Why

Currently when an empty rule_check_task_id value is provided to the workbasket admin form, this is saved as an empty string, which leads to a duplicate value error. We should instead save it as None.
What

Remove rule_check_task_id field declaration from form and add unit test.

Codecov Report
Base: 93.65% // Head: 93.65% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (4af4c44) compared to base (733354e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   93.65%   93.65%
=======================================
  Files         344      344
  Lines       22606    22615    +9
  Branches     1745     1745
=======================================
+ Hits        21171    21180    +9
  Misses       1107     1107
  Partials      328      328

Impacted Files
Coverage Δ

workbaskets/admin.py
82.50% <ø> (-0.22%)
:arrow_down:

workbaskets/tests/test_admin.py
84.41% <100.00%> (+2.32%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add support for default device name if not provided via Api

The cloud Api typically provides the device product name with the bind_devices response. However, this can be used only as site owner, not as shared member.
Furthermore the product name is not given for 3rd party devices such as Shelly smart meters.
There are various product list queries that can be used to get the supported product model types and names.
Those should be queries once and stored as list in the new account api cache. From there the default device name can be looked up if not provided via other Api responses.

Implemented in 2.3.0


[Bug] Fix bug with the open cabinet drawer task, drawers open on their own suddenly

closed by #630


Widget overlap fix

1st commit for the formatting , 2nd commit for the real change

The first commit its just ide formatting, the second one is the one that holds the changes to the library.


#update to 1.7.5

更新了代码输出
当你传入了一个不规范的QAAcoount的时候, 增加了QAPerformance的兼容性

Hello @yutiansut! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file QUANTAXIS/QAARP/QARisk.py:

Line 76:80: E501 line too long (81 > 79 characters)
Line 1038:33: E128 continuation line under-indented for visual indent
Line 1039:33: E128 continuation line under-indented for visual indent
Line 1040:33: E128 continuation line under-indented for visual indent
Line 1045:33: E128 continuation line under-indented for visual indent
Line 1046:33: E128 continuation line under-indented for visual indent
Line 1047:33: E128 continuation line under-indented for visual indent
Line 1052:80: E501 line too long (83 > 79 characters)
Line 1054:25: E741 ambiguous variable name 'l'
Line 1210:33: E128 continuation line under-indented for visual indent
Line 1211:33: E128 continuation line under-indented for visual indent
Line 1212:33: E128 continuation line under-indented for visual indent
Line 1217:33: E128 continuation line under-indented for visual indent
Line 1218:33: E128 continuation line under-indented for visual indent
Line 1219:33: E128 continuation line under-indented for visual indent
Line 1224:80: E501 line too long (83 > 79 characters)
Line 1226:25: E741 ambiguous variable name 'l'

In the file QUANTAXIS/QAIndicator/talib_indicators.py:

Line 31:5: E265 block comment should start with '# '

In the file QUANTAXIS/QAIndicator/talib_series.py:

Line 30:5: E265 block comment should start with '# '


Mark known buggy deployments

and somehow use the information in raiden-client.
This first needs discussion with the Raiden client team.  What kind of information is useful?

Perhaps we don't need to have a file with this, https://github.com/raiden-network/raiden/issues/1825 can be sufficient as long as we make a new release with the critical flag and handle the buggy networks automatically.

This "marking" should happen out of the raiden-contracts packages because people using a very old raiden-contract should also notice such bugs.

Perhaps we don't need to have a file with this

NVM, we need some sort of list because the user can deploy contracts of their own and at runtime we have to query the used contract's versions.

I would put "do-not-use": true in JSON documents, and show print a warning in stderr at least.  Maybe the deployment script would say "This version is known to be buggy, are you still deploying it?"


SdfGenerator_TEST failures on master

There have been several recurring UNIT_SdfGenerator_TEST failures on the master branch since the following build on August 21:

 https://build.osrfoundation.org/job/ignition_gazebo-ci-master-bionic-amd64/24/

The following test failure provides a clue of the difference:

https://build.osrfoundation.org/job/ignition_gazebo-ci-master-bionic-amd64/24/testReport/junit/(root)/ElementUpdateFixture/WorldWithModelsIncludedExpanded/

The original world file has the following uri:
<uri>https://fuel.ignitionrobotics.org/1.0/openrobotics/models/Backpack/1/files/meshes/Backpack.dae</uri>`

The generated world file appears to have 2 URI's concatenated together:
<uri>file:///root/.ignition/fuel/fuel.ignitionrobotics.org/openrobotics/models/Backpack/1/https://fuel.ignitionrobotics.org/1.0/openrobotics/models/Backpack/1/files/meshes/Backpack.dae</uri>

I added some debugging print statements to the test in https://github.com/scpeters/ign-gazebo/commit/a1490fbd896024e7083bc3c9629e5e79b7165469 that confirm the other failures are connected to this same issue.
I think this may be related to https://github.com/ignitionrobotics/ign-fuel-tools/pull/85

@ahcorde noticed this same thing in https://github.com/ignitionrobotics/ign-gazebo/pull/314#issuecomment-680980828

They should be fixed when #271 is merged forward, see #321

Latest master branch build is blue: https://build.osrfoundation.org/job/ignition_gazebo-ci-master-bionic-amd64/29/


[core] Define rules to modularize packages in Next.js

From https://github.com/mui/material-ui/pull/35457#issuecomment-1676416983

we can scale this (modularizing the icons package) to all the MUI npm packages, beyond @mui/icons-material. It could be done with special rules, like in https://github.com/vercel/next.js/blob/261db496f7cf04b70f078a6eae0c8baf6fe5c238/packages/next/src/server/config.ts#L738. I didn't have time in https://github.com/vercel/next.js/pull/51953 to do it right, there was an urgency to fix it before it was rolled from their canary release to stable. Then, the question is is the Next.js job to keep this up to date? Is there a similar opportunity with Vite, should we update the Vite example as well? At the end of the day, it's about improving the DX.

This option in Next.js is gone: https://nextjs.org/blog/next-13-5#optimized-package-imports.
We can remove it, e.g.
https://github.com/mui/material-ui/blob/7ee636b09bde358bcde7be236048933088bfd23d/examples/material-ui-nextjs-ts/next.config.js#L5


Implement fmt::Debug for Spinoso String with bstr to render conventionally UTF-8 strings

This also renders binary content with hex escapes.

Linking to https://github.com/artichoke/artichoke/issues/184.

Linking to https://github.com/artichoke/artichoke/issues/184.


Crypt Fiend Burrow model is bugged

Just shows up as a white square:

@SebastianTanoni This might be a good one for you to tackle as part of C'thun stage, otherwise I'll have to do it. I'm hoping it'll be something as simple as us accidentally overriding the Burrow model because obviously this isn't bugged in vanilla.

When I first discovered it I checked and couldn't find any model override.
Il check again when I get homr

We think this is due to the new tunnel model imported for Ahn'qiraj. Will probably take some modeling knowledge to fix.
Outcome we need is just that the Crypt Fiend burrow model shows as it does in vanilla with no workarounds needed for it.


Not recognize "p" element in "div" element

Challenge Waypoint: Nest Many Elements within a Single Div Element has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="radio" name="indoor-outdoor" checked> Indoor
  <input type="radio" name="indoor-outdoor"> Outdoor
  <input type="checkbox" name="personality" checked> Loving
  <input type="checkbox" name="personality"> Lazy
  <input type="checkbox" name="personality"> Energetic
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
</form>

Not recognize "p" element inside "div" element.

Things cats love:

cat nip
laser pointers
lasagna

Top 3 things cats hate:

flea treatment
thunder
other cats

this is how i completed the challenge. Does that help?

As @ArtGuru123 was saying, the challenge is asking you to wrap the provided paragraphs and lists about what cats like and don't like inside a div like so:

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

rather than creating a new paragraph and list at the bottom of the page and wrapping that.
Closing this as not an issue with the lesson, but please let me know if you need more clarification.
Thanks and happy coding!


[Feature request] Adding a Somaliland flag emoji using the "XS" user-assigned code

Both DHL  and the Jvectormap  library use the "XS" user-assigned code for Somaliland so I'd like to request a Somaliland flag emoji to be added in the library using the code. Before anyone refers me to Unicode consortium, I know about them but I meant to request it to be added in twemoji.

The readme states "We do not support custom emoji." If you want this to show up in Twemoji, you will have to go through Unicode.


Be more explicit about the exit status of the container

Description
Minor modification to build.py so the status of the container is more clear.
Changed the time to GMT in log output.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-label-bot add [pr-awaiting-merge]


db failed to initialize when db persistence is enabled

Bug report
Describe the bug
when enabling persistence on db, the db failed to start with the following error:
initdb: error: directory "/var/lib/postgresql/data" exists but is not empty
initdb: detail: It contains a lost+found directory, perhaps due to it being a mount point.
initdb: hint: Using a mount point directly as the data directory is not recommended.

To Reproduce
edit the values.examples.yaml and change the db persistence to true and install the helm chart:
db:
  enabled: true
  image:
    tag: <IP_ADDRESS>
  livenessProbe:
    exec:
      command:
        - pg_isready
        - -U
        - postgres
    initialDelaySeconds: 3
  persistence:
    enabled: true
    size: 2Gi

Steps to reproduce the behavior, please provide code snippets or a repository:

Go to '…'
Click on '…'
Scroll down to '…'
See error

Expected behavior
I expect a successful installation and initiation of all pods in the cluster
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: [e.g. macOS, Windows]
Browser (if applies) [e.g. chrome, safari]
Version of supabase-js: [e.g. 6.0.2]
Version of Node.js: [e.g. 10.10.0]

Additional context
Add any other context about the problem here.

initdb: detail: It contains a lost+found directory, perhaps due to it being a mount point.
Ah, I didn't foresee mapping volumes on Mac. PR looks good! 👍


Blog support

Description:
Currently its not possible to create Blog posts in Obsidian for Docusaurus.
Proposal:
Based on the first folder, check if name is "blog" or is ending "-blog" (for multiple blog support) -> start conversion and copy files to new location
Obsidian File - Frontmatter:
---
title: Welcome Docusaurus v2
description: This is my first post on Docusaurus 2.
slug: welcome-docusaurus-v2
authors:
name: Joel Marcey
title: Co-creator of Docusaurus 1
url: https://github.com/JoelMarcey
image_url: https://github.com/JoelMarcey.png
image: https://i.imgur.com/mErPwqL.png
hide_table_of_contents: false
---

best to create a template for this
Additional Information:
https://docusaurus.io/docs/blog
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-front-matter
Authors:
https://docusaurus.io/docs/blog#blog-post-authors

Blog & Multi Support added


add previewShowImageTitle option

i want to show the file names of the images. think it might be a useful feature. please let me know if there's anything else i can do. and Merry Christmas.

super old. closing


Enemy should do damage

Now it is more like a pet...

Enemy seems to do damage if you are next to it. Does not matter which direction the enemy intended to go to

Therefor the damage can go to another Component because it does not affect the direction decided by the AiComponent

Done https://github.com/JordyMoos/elm-pixel-boulder-game/commit/4241e68614b075e9c460830f974437843eeed142


Upgrade Gradle and AGP version to latest

Gradle to 7.4.1 and agp to 7.1.2

Done https://github.com/formatools/forma/commit/44200e44c923346873aa5169f81c761b06cc6ac0


ImageIO plugin

Provide an ImageIO plugin for rasterising svg files. Per the spec the <image> tag is expected to support svg files and treat them as if they were raster images. This is the most straightforward way of implementing it, as we are already loading images using ImageIO

Thank you! This is actually very helpful. I never got around to read into how the ImageIO api works. Seeing your implementation it looks like it is more straight forward than I thought.

That said it's a bit annoying to integrate with other swing code. E.g.  it doesn't work in a JEditorPane's image view because it doesn't use ImageIO.
However, using image IO directly should be fairly straightforward.


Add 0.1.2 to changelog

Description
Adds 0.1.2 to changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.986%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2990

Relevant Lines:
3692

💛  - Coveralls


Inaccurate Scores

So I'm taking a look at this package (randomly chosen) and the new Score matrix (awesome work btw!)

It cites that this package has a score of 65. Though I'm unsure of the accuracy of this.
Looking at the package itself SwiftPackageIndex states:
"This package depends on 1 other package.", and yet the score matrix says it "Has no dependencies.". It also says that having no dependencies = a score of 0, though the Score.swift suggests that a project with less than 3 dependencies should get a score bonus of 5.
The score matrix also says it has no contributors, but the main page says it was written by two people. That's not really clear.

I'm not sure if its the matrix, the score calculation, or something else which is broken - but this data doesn't add up.

Thanks for the report, @Sherlouk ! I'm taking a closer look.

I've re-analysed this package locally and it updated the score from 65 to 70 (via the dependency score → 5). The breakdown now also shows two contributors.
I can explain why the dependency score was off at first. This is a newly added package and we get dependency information from the build step. However, on the first pass of determining the score, the builds wouldn't have reported back in yet, so that's why the score is 0 until analysis updates the package again.
NB: This would also be the case when there's a new default branch version. We may want to trigger an out-of-cycle score update to shorten the gap until analysis comes around again. Alternatively, we could perhaps base dependency information off of release branches (if present). That would make the figure more stable and require fewer updates, and places where they're triggered from. That would need some care and thought.
What's odd is that the author count was off as well. That's something that's entirely determined within analysis and should be stable immediately.
I've spot checked other packages and didn't see any with author discrepancies. Did you have an further examples for those, James?

Hold on, I missed the very first commit is also yimajo, albeit with a different avatar. I'll need to check what the underlying author refs actually are.

Ok, I can reproduce this locally. I've deleted the swift-property-name package, then ran

reconcile
ingest
analyse

This correctly shows two authors on the package page but 0 contributors in the score breakdown. After running analysis one more time, the contributor breakdown is correct.
I wonder if this is due to the first analysis pass doing a clone vs subsequent ones doing a fetch or something like that.


:memo: Added Interaction guide

Changes

adds: Docs. Please read them since i need feedback, I'm not a very good writer lol.
fixed: Issue with @user_command and @message_command function signatures (now lines up with what i wrote in the docs)
improvements: ...

Check off the following

[x] I have tested my changes with the current requirements
[x] My Code follows the pep8 code style.

Im not sure whats up with codecov, it works on my machine, so im gonna ignore it and hope the problem goes away kekw.


[FEEDBACK] Add option to sort and group friends together in sidebar by location

Similar in appearance to the website or the friends wing when sorted by location, could have an option to sort the friends in the sidebar by location, and have those in privates sorted to the bottom. Maybe even have the friends sorted under a clickable header of the world instance each are grouped up in~

This is something I have had planned for over a year now as a separate "home" page but it would take a lot of work so it's always been very low on my todo list. Sidebar sorting could be doable though.


Move to new pane [enhancement] [ux]

Description
Maybe my work pattern is strange, but almost 100% of the time when I want a new pane (i.e. to split) I want to move an existing buffer to that new pane. Not duplicate it, and not create an empty pane.
Steps to Reproduce

Split pane right
Oh. Not what I wanted.
Move buffer to new pane

Expected behavior: I don't expect, but I desire the buffer to move to the newly created pane.
Actual behavior: The newly created pane is either empty, or the focussed buffer is opened there as well as remaining in existing pane.
Suggestion is to add 'split and move pane right/left/up/down'.
Versions
atom 1.5.3
apm  1.6.0
npm  2.13.3
node 0.10.40
python 2.7.10
git 2.7.2

Thanks for the suggestion! :smile: This looks like a duplicate of https://github.com/atom/atom/issues/2670 though, so I'm going to close this out in favor of that issue. Feel free to subscribe there for updates!

Oops! I confess I did see that when I searched, but from the title assumed it was purely about navigation.
Cheers.


Update v2 Job Specs docs.

This is the next iteration toward removing v1 JSON Jobs.

Escalate warnings on the v1 Jobs pages about upcoming removal of v1 jobs.
Keep "DEPRECATED" terminology for now.
Remove newlines from <{ }> entries, which were breaking v2 Jobs in the Node Operator UI.
Fix incorrect commenting in examples.
Change "get" HTTP tasks to use "GET", which is compatible with more data source URLs.

LGTM! Once v1.0.0 is out, we can ship.

These changes actually apply today and don't require v1.0.0. Changes for v1.0.0 release are moving to https://github.com/smartcontractkit/documentation/pull/427 eventually.


Code Splitting Example

Since preact is all about smaller Java Script it would be great if you can provide functionality to support Code Split for preact-router

It's unlikely to be a feature of preact-router itself, but I'd be happy to provide examples and recommended ways to do this.  The simplest way is to use a compositional component like <SplitPoint /> as a child of the router:
<Router>
  <SplitPoint path="/" load={require('bundle?lazy!./home')} />
  <SplitPoint path="/user" load={require('bundle?lazy!./users')} />
  <SplitPoint path="/users/:user" load={require('bundle?lazy!./users/user')} />
  <SplitPoint default load={require('bundle?lazy!./not-found')} />
</Router>

Thanks does preact-router support server side rendering ?
On Wednesday, November 30, 2016, Jason Miller<EMAIL_ADDRESS>wrote:

It's unlikely to be a feature of preact-router itself, but I'd be happy
to provide examples and recommended ways to do this. The simplest way is to
use a compositional component like
https://gist.github.com/developit/9f547d32b96f879b259be399a5dc0f01 as a
child of the router:

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-router/issues/96#issuecomment-263963882,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMtHiqqkMNRpIIHPt6aJMHcA9ycjaFTOks5rDckWgaJpZM4LAgXq
.

yup! you can pass any URL to the router and it will render the correct children accordingly:
import { h } from 'preact';
import renderToString from 'preact-render-to-string';

/*
// assuming you have an app defined like this:
const MyApp = ({ url }) => (
  <Router url={url}>
    <Home path="/" />
  </Router>
);
*/

// example: express
app.get( (req, res) => {
  let html = renderToString(h(MyApp, { url: req.url }));
  res.send(html);
});

I really liked preact-boilerplate is there a version of that with
code-split and server side rendering ?
That would be perfect for starting production quality apps with preact
On Wednesday, November 30, 2016, Jason Miller<EMAIL_ADDRESS>wrote:

yup! you can pass any URL to the router and it will render the correct
children accordingly:
import { h } from 'preact';import renderToString from 'preact-render-to-string';
/// assuming you have an app defined like this:const MyApp = ({ url }) => (    );/
// example: expressapp.get( (req, res) => {
let html = renderToString(h(MyApp, { url: req.url }));
res.send(html);
});
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-router/issues/96#issuecomment-263965900,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMtHikjiUK-xfrMChDkE6LGotuabDxrFks5rDcrPgaJpZM4LAgXq
.

There isn't one yet, but that sounds like a good idea!  I don't do much server rendering since I like to deploy all my stuff to a CDN, but there are lots of people who want it.  Perhaps a clone of preact-boilerplate that does SSR and shows how Code Splitting works would be ideal.  The code splitting could be in both, really.

Ya only reason for SSR is to support SEO
Most people like me hate webpack it too much mess to set it up right
specially for isomorphic apps
I will try to do this and will let you know if I need help
On Wednesday, November 30, 2016, Jason Miller<EMAIL_ADDRESS>wrote:

There isn't one yet, but that sounds like a good idea! I don't do much
server rendering since I like to deploy all my stuff to a CDN, but there
are lots of people who want it. Perhaps a clone of preact-boilerplate that
does SSR and shows how Code Splitting works would be ideal. The code
splitting could be in both, really.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-router/issues/96#issuecomment-263967380,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMtHii_3D4gHGsUXCaHFh2rstBvWQemVks5rDcwRgaJpZM4LAgXq
.

@developit I was trying to add code splitting too for js and css too.

Code splitting for CSS is super tricky. I'm not aware of any great ways of doing that with Webpack currently.  Usually you have to decide between loading all your CSS at once, or loading initial CSS but pushing less-used CSS into your lazy-loaded JavaScript modules.

It's because the the css order issue?

No, I just don't know of an existing way of doing it cleanly.  I guess the underlying reason would be that typically external stylesheets are created via ExtractTextPlugin in Webpack, and that plugin only supports extracting to a single external stylesheet.

Code splitting can be easily done once #135 is resolved.

for code splitting please and lazyloading components please visit
https://github.com/prateekbh/preact-async-route
can we close the issue @developit

Yup yup! Happy to close now that we have a great lib for this :)


Allow for custom display/rendered format

I believe the library should allow developers to display/render a date format that is separate from the internal format used in the code. Reason for this is to allow for custom, non-standard, format display... while at the same time maintaining a standard, internal, format that is easier to handle with code.
I didn't want to change too much code and wanted to stay aligned with the style used throughout the source.
Commit Notes:
Changes the getDateStr() signature to accept display boolean. This boolean paired with a given prop displayFormat allows for rendering the date as a separate format (breaking the lock between intended "display format" and date format used throughout the src)
Related Issues:
#30
#92
#29

Coverage decreased (-1.03%) to 95.745% when pulling 97b8cbb0ce2743f40f8a4c258cbdb2c8e005d48c on mdramos:master into 1b2aef97a6ffa71c01f4448ff5711a0f94d9ee7a on xgfe:master.

@mdramos what was the reason for closing this PR? I've forked your fork and rebased from this repo, and it seems to be working well

@samueljmurray I'm not entirely sure/don't remember. If it's still an issue feel free to use your own PR for this, thanks!


In the build container, change the config file location to /etc/docker/registry/config.yml

This makes it consistent with the new official image.
Paths in the docs were updated in
34067d7d43f282a67528764ba36527b800da25fa.
Fixes #843.

LGTM

LGTM


Support new, longer instance and reservation IDs

Currently this is an opt-in, but will be required by the end of the year. I propose that this is just a boolean kwarg defaulting to true on the mock_* functions that require it. Thoughts?
https://aws.amazon.com/ec2/faqs/#longer-ids

Thanks for opening!
I don't hate it, but am a bit worried about the amount of layers the boolean will need to travel, especially since we will undo all of the code at some point. I'm tempted to suggest reading an environment variable, but that feels hacky.
I don't have a strong preference either way. If someone wants to submit a PR, I will happily merge, but prefer they setup the code in a manner that will make it easy to remove at year end.

Thanks for the response @spulec, now that I've had more time to review the process in getting the longer instance IDs set up in the actual AWS API, I'm feeling like we should implement a "mock" of ModifyIDFormat that persists the boolean somewhere. I'll dig into this more later this week!

@JackDanger should be done, close please

@terrycain Many thanks for the help with issue triaging


The libary doesnt shows up

Hi,
I did the steps according to this article:
https://docs.microsoft.com/en-us/sharepoint/organization-assets-library
The command ran successfully but the folder doesn't show up in any office app.
For Get-SPOOrgAssetsLibrary command, it shows the site I added and OrgAssetType : OfficeTemplateLibrary.
I tried to restart, sing in out from office, delete the cache but still don't works.
Could you please advise?
Regards,
Gabor

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

It seems like we just had to wait. It took 2 days to work. CDN was really slow this time.
Thanks,
Regards,
Gabor


Add missing negative sign (typo), fixes #187

The answer should be -0.7666647...; somehow the negative
sign was missing.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

I have no idea why this build is failing.  I suspect a problem with Travis CI, in which case hopefully they'll fix it soon.  I can restart the build in a little while & see if it goes away.

@nmegill - all set now. There was a problem in an externally-downloaded file, now resolved.
Hopefully it's okay to merge this!


The staging pipeline pods are never deleted /  cleaned up.

See also #17.
In testing the latest PR around app methods (push, apps, delete) I noticed that the staging-pipeline-... pods are never deleted.
While they show up in the kubectl pod listing as completed, they do show up even after push has the app running.
Deleting the app does not delete them either.
Nore is any reuse happening.
For the moment (pre-demo) this should be ok. However for production, maybe even MVP, I can see these pods starting to clutter the low-level pod display as apps are created, updated, and deleted, with ever more staging-pipeline pods shown.
Confirmed that creating more apps creates more sets of staging-pipeline pods, no reuse.

In any case, when an application is deleted, the staging pods (from any staging process) are no longer needed and should be deleted.
Also, after a successful staging process, the previous staging pods are again not useful and can be deleted, unless we want the user to be able to access all previous staging logs but I don't see a valid use case for that.

#246 is also relevant because it affects how we decide which staging process is the current one.

See tickets #431 and #452, and the associated pull requests.


feat: Migrate Starknet : l1_to_l2_message_cancellations from "beerus_rest_api" to "beerus_rpc"

Feature Request
Describe the Feature Request
We are deprecating "beerus_rest_api" and now migrating all the api endpoints to "beerus_rpc".
Migrate l1_to_l2_message_cancellations and add tests on beerus_rpc.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

Hello there, may I take this one?


Missing description under title

Should be something like:
> UISwitch which paints over the parent view with the color in Swift 🔶

Good point, thanks.


Support removeProxies in the indexer

closes #283
This is non trivial to properly test, due to the way the indexer works. There are 3 types of scenarios:

it's a new event. Meaning that you call proxy.removeProxies now, on an old pure, that is already persisted in the DB
it's a recent event compare to the proxy creation, but we re-index the chain. Meaning that the proxy.removeProxies will be in a batch with potentially many other proxies creation/deletion
you create a proxy or a pure, then shortly after a proxy.removeProxies, and we re-index the chain (like on 2). Then the new proxy or the pure will never even touch the DB. The removal will happen in a batch array.

I've carefully tested all these scenarios. There is no easy way to test 2 and 3 because it requires a re-indexing, which happens every month, when we have changes in the indexer.
In any case the deployment of the test UI is now pointing to the new (v2) of the indexer that supports it. @LernaJ you should not see the pure proxies any more (the multisig are here still though)

Thanks. @LernaJ  will be able to test the behavior with re-indexing because she did call the proxy.removeProxies in the past.
Also just to be clear, I can manually launch those re-index, so I could test all these scenarios locally.

FWIW I hibernated the v2 to see if this is what's causing the slowness. As a result, this PR can't be tested any more, and obv shouldn't be merged before restarted.


It would be nice if the return_html option is present

Currently, the plot functions only generate HTML and do not return any images. This behavior makes it difficult (if not impossible) to download plotted images, especially if the plot is generated from a NumPy array. However, since the HTML contains the base64-encoded image information (or the URI to the image), downloading the image can be done easily with the BeautifulSoup library if the return_html option is present.

+1 I would like to be able to add a delete link under the images which will hit an endpoint to delete the image, or even just open it on the local file system so I can delete manually


Fix #7 issue, changing FacetOperatingSystem

I add all properties included in the OperatingSystemFacet class and adding the type checking.
  + os_advertisingID: str = None,
  + os_bitness: str = None,
  + os_isLimitAdTrackingEnabled: bool = None,
  + os_environment_variables: Union[None, Dict] = None

I also updated the example.py.

This report came in from the type-checking:

case_mapping/uco/observable.py:1123: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

(and again for each parameter)
I'm going to push two patches.

Thanks Alex,
I have a hazy idea of the error, I will check your changes after the pushes!

One more patch coming.

the PR It's fine, I'm only curious of the reasons why you added the parameters *args and **kwargs, did it mean for future extensions of the ontology?

the PR It's fine, I'm only curious of the reasons why you added the parameters *args and **kwargs, did it mean for future extensions of the ontology?

No, it's a Python syntax thing, possibly just my personal preference or confusion.
A Python function can have (1) positional arguments that require a value, (2) positional arguments that specify a default, (3) keyword parameters that require a value, and (4) keyword parameters that specify a default value.  If all 4 of those are specified for one function, they must be specified in that order.  If (3) is skipped, the syntax appears, to me, ambiguous on when positional-with-default arguments end and keyword-with-default parameters begin.  There's a behavior Python lets function-callers trigger that further makes this easier for callers when they use parameter names, but at a trade of some syntactic laxness.
*args is a marker for "There can be an arbitrary number of unnamed positional arguments here in the list; everything afterwards is a non-positional parameter."  Unfortunately, I have trouble recalling which PEP shored up this syntax, and further I think it used the harder-to-text-search sole * and ** spelling (vs. *args and **kwargs); I think it was incorporated in Python 3.8?
So, apologies for lacking the citation, but the short story is, using *args, a code-reader can't confuse when it's OK to start mixing up the order of the named arguments.  **kwargs does set up some future pass-through support, and I've found it handy for subclass design.

thanks a million for your explanation😊


Refactored the code around JobMetrics in MRJobLauncher

This pull request has the following changes:

JobMetrics is now wrapped in an Optional, just like in JobContext.
The setup happens and JobMetrics.startMetricReporting is called in the setup method.
HobMetrics.stopMetricReporting is called in the cleanup method.

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

@ibuenros can you review this? I just realized that JobMetrics.stopMetricReporting should be called somewhere soon after you merged in #156. Then I realized setup and cleanup are better places to start and stop metric reporting respectively. Also the Configuration object returned by context.getConfiguration() has all job configuration properties in it. So now the method JobMetrics.startMetricReporting(Configuration) gets used.

Hey @ibuenros can you review this?

@liyinan926 It looks good, but I would want to test that the expected properties actually get propagated to the mappers. It will take me some time to do that.

Sure. Let me know once you are done with the testing.

LGTM


New example and config changes

Added another example for the react wrapper with a pyright language server
Updated interfaces, types and configurations

@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.

@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.

I think this a good idea, will definitely make it easier to maintain going forward. Do you need me to look into this or will you do it as part of the next release you do?

Do you need me to look into this or will you do it as part of the next release you do?

I will test this (release new packages) with the json example and if that works you could rebase this PR and do the same with the python server.

@Stuey61296 Done. The server integrations for python and json LSs are already available on main. Please rebase the PR.

I performed the rebase here already: https://github.com/TypeFox/monaco-components/tree/react-python
You can reset your branch to there if you like. The changes look good already and it works as expected.

I now merged the rebased version as there were no changes required from you side. Your name is on the changes! 🎉 Thank you. I only removed what I wrote above. I will release the new major versions later today.

@Stuey61296 versions 3.0.0 and 2.0.0 are now available:
https://www.npmjs.com/package/monaco-editor-wrapper/v/3.0.0
<EMAIL_ADDRESS>


Improve code formatting

I noticed by contributing that almost every file has a different code formatting. Some files use line feed, some carriage return line feed. I saw a lot of PR's which had problem with this (me including).
I worked on an integration of the plugin spotless. Spotless checks at build time if all files are correct formatted. It uses the specified rules from the gradle configuration. I imported the eclipse-formatter file for the formatting rules. If the build fails because of wrong formatting, you can format the sources by typing gradlew spotlessApply. This makes it more comfortable for contributors.
TODOs:

[ ] Maybe add some rules (also for other file types)
[x] Wait for diffplug/spotless#412 because of wrong formatting of JSNI of GWT (eclipse formatter bug tracker)

Can be useful for a PR builder for new changes, but I would not like to run this on the entire project.

That will be a problem. But if the formatter would be run on bad formatted file with the wrong file ending, also this PR will have a lot changes which will lead to not getting merged.
Also gradlew build will check every time if all files a right formatted. The build will fail if not. So I don't think there's a way to avoid a big commit for formatting.

I don't think line endings are worth having as a strict rule.

I think that's the greatest benefit. I think almost every contributor had in a PR changed line endings because of the default setting of git to convert to line feed. It would really help to avoid messi PRs with a lot of changes because the line endings were converted by the os, idea or git. And it's always exhausting to revert the line endings

I agree. This tool wouldn't help with that though? It would just let them know why they are not following formatting guide.  Why don't we use .gitattributes and set a per-repo setting for unix style endings.  Then we wouldn't have this two stage process of someone pushing and only then seeing the problem.
This also would involve quite a big change as git will want to enforce the normalized line endings on all files that aren't subscribing to that, but probably less than if we were to run this plugin.

Off course does the plugin help. gradlew spotlessApply will change the line endings to specified ones. I set lineEndings 'UNIX' to use line feed as line ending. For sure we can also use .gitattributes. I would suggest only as addition and not as replacement for the spotless line ending configuration. Spotless warns the user and git does not, so without spotless it would be possible that someone pushes still the wrong line ending.

What I'm saying is that includes the additional step, which is not a huge amount different to just using your IDE to do it.
With git attributes, correct me if I am wrong, but git will always convert the files to the supplied line ending on checkout.  The only way someone would be able to push something with incorrect line ending would be to actively bypass this by manipulating the projects' gitattributes before checkout.

There is also a maven version of spotless. It's an additional step, yes. I think typing one command is not to much effort.
Yes, I think git does it like you described.

I would be willing to accept the one time pain of formatting all the source if we thereafter do it regularly and we have an IDE independent way of formatting the source. I have applied formatting to the entire source in the past, but it wasn't kept up.
I'm not sure about failing the build for not having the right format. I like the enforcement, but I worry it proves annoying in practice. The alternative is to regularly make commits to fix formatting, which adds some noise (which may not matter much, as our repo is relatively quiet anyway).
I tried applying this PR and ran gradlew spotlessApply. The initial formatting is pretty intense at 3722 files, but that's what we get for leaving it this long! It does appears to match the Eclipse formatter exactly. This makes me super happy and I would love to see it merged, especially since recently it was discovered that IDEA does not match the Eclipse formatting when importing the Eclipse formatter file. Spotless even applies missing copyright headers. The only issue I saw were comments like this one from AndroidAudio:
				soundPool = new SoundPool(config.maxSimultaneousSounds, AudioManager.STREAM_MUSIC, 0);// srcQuality: the sample-rate converter quality. Currently has no effect. Use 0 for the default.

Gets turned into this monstrosity:
				soundPool = new SoundPool(config.maxSimultaneousSounds, AudioManager.STREAM_MUSIC, 0);// srcQuality: the sample-rate
																																	// converter quality. Currently
																																	// has no effect. Use 0 for the
																																	// default.

There may be other situations that were not intended to be formatted and format poorly. These situations are probably rare and can be fixed up manually over time.

We can disable the enforcement with this line (see here):
spotless {
  enforceCheck false
}

sees 3722 lines <-- Oh, that's not so bad.
re-reads
sees 3722 files <-- Jaw drops.
Are they all Java files, none generated/JNI-related? Is there a way we can make sure JSNI for GWT is still working OK, as well as jnigen comments? I'm wondering if the AndroidAudio "monstrosity line" can be adjusted by changing the tab width; with tab ==  2-4 spaces it should be much closer to the area it should occupy. It would be amazing if this plugin can do the code-style changes correctly across-the-board, and it seems like it's within reach!

I read on the eclipse bugtacker https://bugs.eclipse.org/bugs/show_bug.cgi?id=222083 that the formatting is a problem which exists since 2008 and seem to get fixed. Mateusz Matela suggested there on comment eight to use custom on off tags for the formatter. /*-{ as off tag and }-*/ as on tag. The problem is, that we got already custom on and off tags:
https://github.com/libgdx/libgdx/blob/d765b94eed4503d8389ef97a770316bd4f4561f1/eclipse-formatter.xml#L5
https://github.com/libgdx/libgdx/blob/d765b94eed4503d8389ef97a770316bd4f4561f1/eclipse-formatter.xml#L87
I don't know, if it's possible to use multiple custom on off tags and if so, how to add the to the xml file.
I got no other ideas how we could fix this problem.
By the way, spotless can also format for example xml, gradle and  cpp files

It's some XML and CPP files, but I think just fixing spaces->tabs there (which is good).
The on/off tags are OK for the rare block where it's really needed, whether our current tags or something else. The current tags are maybe less cryptic that /*-{. It doesn't help the AndroidAudio problem. For that the comment should just be on its own line(s), not at the end of a long line. We could run the formatter for the first time, then before committing, search for "tabtabtabtabtabtabtabtabtabtab..." and manually fix things up.

Note:
As stated here, no multiple custom formatter tags are supported, we have to add // @off and // @on to almost every jsni block, else things get dirty.
Should I disable the forced formatting?
Should I add these tags to this PR? If yes, I would add it also to the mentioned SoundPool line.

Would it help if we change to the /*-{ and }-*/ tags?

Yes, but the current on/off tags are used for the jni-gen code (If I'm not wrong) and for some Shader declarations. I think replacing them with the jsni comments will let the IDEs freak out and make the whole developing a pain.
I don't see any other option to add off tags to every jsni block, but I'm happy to hear some ideas for easier solutions

My personal opinion: this is a priority.
This repository has seen an increase in activity and there are already problems with the formatting for a few PRs.

I think a much more pressing issue is getting a proper IntelliJ formatter setting. The idea-formatter.xml file in the repo produces differente results in Android Studio than eclipse-formatter.xml does in Eclipse, just see here:
Eclipse:

Android Studio:

And importing the eclipse formatter file in Android Studio (as is recommended on the libGDX homepage) doesn' work, because: "The file doesn't seem to be a valid Intellij IDEA XML scheme, it should contain 'code_scheme root' element, found 'profiles' instead."

There is an IntelliJ plugin for "eclipse-formatter", btw.
Anyways, I'm quite certain that I've seen something in IntelliJ formatting that allowed better customization of the comments.

Hey Payne, in the screenshots I used the idea-formatter.xml.
I couldn't get Android Studio to import the eclipse formatter files, even though that should be possible.

On the default capacities : https://stackoverflow.com/a/27035850/9768291
But anyways, I would suggest using the Eclipse-Code-Formatter plugin : https://plugins.jetbrains.com/plugin/6546-eclipse-code-formatter

you can make the "classes" task depend on the "spotlessApply" task so any time you run build, jar, or run tasks it automatically applies the formatter, and therefore we can leave it so it fails build if the style is incorrect for ci/cd purposes.

I'm a Spotless maintainer, I just noticed this issue link and wanted to share some thoughts.  If you want to avoid a "format everything" commit, you can use ratchetFrom so that only files which have changed since origin/master will get formatted.  It's the same no-bikeshedding apply / check workflow, but just more fine-grained (and faster!).  I think a "format everything" commit is still a good idea, but to each their own 👍
I see you have places where you want to disable formatting inline.  We're about to merge a piece of infrastructure which makes that possible for all formatters, not just eclipse, so if you want to ignore sections inside of XML or CPP, you can do that.  Once that gets merged, it becomes pretty easy to implement the javascript inside of java issue, ala
native static public void consoleLog(String message) /*-{
	console.log( message );
}-*/;

Lastly, Gradle's caching makes Spotless really fast.  So I've personally never felt much need for IDE support.  But, we do have an IDE hook, although so far only VS Code has a plugin for it.

Okay guys, here we are. I configured spotless so that only files which have changed since origin/master will get formatted like @nedtwigg suggested. I think that's the best currently to avoid a big formatting commit.
Another idea I had is a pre-commit hook but that's a different story....

The gwt formatting problem is also resolved

Great! It's merged! Are there any instructions to contributors about how to use this (so people don't have to go through this whole thread)?

Spotless is very self-explaining.
For example:
I changed something in DefaultGwtInput.
The following error appears because of a none matching format:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':backends:gdx-backends-gwt:spotlessJavaCheck'.
> The following files had format violations:
      backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/DefaultGwtInput.java

With this instruction at the end:
Run './gradlew :backends:gdx-backends-gwt:spotlessApply' to fix these violations.

After running the command is the file correct formatted and the project build successful.
It's very easy to use

Being the format now enforced on the build server any new commits will contain lots of format changes unrelated to the PR just for the build not to fail.
To avoid that, either we run it ASAP on the whole project as a one time thing (and break most open PRs) or we remove the enforcement check on the build server.
@NathanSweet How do you want to proceed?

I think many open PRs, at least the larger ones, are probably broken to some extent by the spotless requirement, unless the author already ran the spotless task. If we have the capability to edit PRs, any contributor interested in merging a PR can run the spotless task on it to allow it to merge cleanly, as long as spotless doesn't risk changing many unrelated files. It shouldn't run that risk if we've formatted the whole project with spotless.
.git-blame-ignore-revs was mentioned as a possible solution for hiding the changes spotless makes in one commit, but I don't know the specifics.

.git-blame-ignore-revs was mentioned as a possible solution for hiding the changes spotless makes in one commit, but I don't know the specifics.

https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame goes over it a bit, unfortunately github still doesn't support it.

any new commits will contain lots of format changes unrelated to the PR

It should be that only files which the PR has changed will get formatted. https://github.com/diffplug/spotless/tree/main/plugin-gradle#how-can-i-enforce-formatting-gradually-aka-ratchet
https://github.com/libgdx/libgdx/blob/0be3ba94aeb3fecd1c4c09deb3e95c154e8f2457/build.gradle#L66-L67

Yes, it only changes the touched files but it reformats the Whole file, not
just the changed lines. In many cases, just for changing a line in a PR it
will  reformat hundreds of lines on that same class.
On Sat, 11 Sep 2021 at 14:19, Ned Twigg @.***> wrote:

any new commits will contain lots of format changes unrelated to the PR
It should be that only files which the PR has changed will get formatted.
https://github.com/diffplug/spotless/tree/main/plugin-gradle#how-can-i-enforce-formatting-gradually-aka-ratchet
https://github.com/libgdx/libgdx/blob/0be3ba94aeb3fecd1c4c09deb3e95c154e8f2457/build.gradle#L66-L67
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/5698#issuecomment-917397996, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AANWDPGHFF6G744WUHG2S7DUBNCMRANCNFSM4H4K4JEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm OK with a one time format of everything. It does make the history a little annoying and cause some pain with PRs, but at least it's only once. We should first make sure the format is what we want. If it's the Eclipse formatter than that should be OK. The commit would also benefit from manual review, looking for areas that have formatted poorly and would be improved with // @off and // @on comments.


Configurer failing to enable engines after upgrade

After upgrading to 1.15.3 from 1.14.2, the configurer is trying to enable all secret engines I've already enabled: AWS, database, rabbit.
Expected behaviour:
Upgrade without configurer errors
Steps to reproduce the bug:
Upgrade to bank vaults 1.15.3 and vault image 1.10.4 with AWS, database and rabbit engines already setup.
Environment details:

Kubernetes version (e.g. v1.10.2): 1.22.6
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc): self managed AWS
bank-vaults version (e.g. 0.4.17): 1.15.3
Install method (e.g. helm or static manifests): Helm
Logs from the misbehaving component (and any other relevant logs):

{"level":"info","msg":"adding secret engine  (database)","time":"2022-06-16T20:43:30Z"}
9
{"level":"error","msg":"error configuring vault: error configuring secret engines for vault: error adding secrets engines: error mounting  into vault: Error making API request.\n\nURL: POST https://vault.vault:8200/v1/sys/mounts\nCode: 405. Errors:\n\n* 1 error occurred:\n\t* unsupported operation\n\n","time":"2022-06-16T20:43:30Z"}
/kind bug

I'm also getting this error just going to 1.15.0
{"level":"error","msg":"error configuring vault: error configuring auth methods for vault: error configuring managed auth methods: error while adding auth method config: error configuring kubernetes auth roles for vault: error putting external-dns kubernetes role into vault: json: unsupported type: map[interface {}]interface {}","time":"2022-06-17T14:15:30Z"}


Make the commands work in forge web as they match selected node by ke…

…y, so we needed a converter to match that.

[merge]


Missing prometheus_tsdb_wal_corruptions_total metric in newer versions of Prometheus

Bug Report
What did you do?
Started Prometheus 2.5.0 (or v2.6.0-rc.0) with default config:
./prometheus --config.file=prometheus.yml
What did you expect to see?
This internal metric:
# HELP prometheus_tsdb_wal_corruptions_total Total number of WAL corruptions.
# TYPE prometheus_tsdb_wal_corruptions_total counter
prometheus_tsdb_wal_corruptions_total 0

https://github.com/prometheus/prometheus/blob/e3bdc463fa7f8d8b5dffe02f35a03012d4213fb5/web/web.go#L626
What did you see instead? Under which circumstances?
We did not see the prometheus_tsdb_wal_corruptions_total metric.
We did see the metric in Prometheus version 2.3.2
Environment

System information:
Linux 4.15.0-42-generic x86_64

https://github.com/prometheus/tsdb/issues/471


✨[Feature Request]: redirect to appointment.html on choosing any doctor

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

redirect to appontment.html on clicking any doctor from list
Use Case
easy access to appointments,
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@varshith257

/assign