Series.value_counts() in new style

Hello @akharche! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file hpat/datatypes/hpat_pandas_series_functions.py:

Line 260:80: E501 line too long (111 > 79 characters)
Line 265:80: E501 line too long (96 > 79 characters)
Line 270:80: E501 line too long (99 > 79 characters)
Line 289:80: E501 line too long (102 > 79 characters)
Line 292:80: E501 line too long (105 > 79 characters)
Line 295:80: E501 line too long (99 > 79 characters)
Line 298:80: E501 line too long (109 > 79 characters)
Line 300:80: E501 line too long (82 > 79 characters)
Line 301:80: E501 line too long (95 > 79 characters)
Line 304:80: E501 line too long (102 > 79 characters)
Line 307:80: E501 line too long (128 > 79 characters)
Line 309:13: E115 expected an indented block (comment)
Line 339:80: E501 line too long (81 > 79 characters)
Line 343:80: E501 line too long (127 > 79 characters)
Line 349:9: E265 block comment should start with '# '
Line 350:80: E501 line too long (89 > 79 characters)
Line 353:80: E501 line too long (95 > 79 characters)

In the file hpat/tests/test_series.py:

Line 1577:80: E501 line too long (94 > 79 characters)
Line 1591:80: E501 line too long (96 > 79 characters)
Line 1628:80: E501 line too long (81 > 79 characters)

======================================================================
FAIL: test_series_sort_values_full (hpat.tests.test_series.TestSeries)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/miniconda3/envs/travisci/conda-bld/hpat_1572993959417/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/hpat/tests/test_series.py", line 3064, in test_series_sort_values_full
    pd.testing.assert_series_equal(ref_result, jit_result)
  File "/Users/runner/miniconda3/envs/travisci/conda-bld/hpat_1572993959417/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/pandas/util/testing.py", line 1145, in assert_series_equal
    obj="{obj}.index".format(obj=obj),
  File "/Users/runner/miniconda3/envs/travisci/conda-bld/hpat_1572993959417/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/pandas/util/testing.py", line 690, in assert_index_equal
    robj=right,
  File "pandas/_libs/testing.pyx", line 65, in pandas._libs.testing.assert_almost_equal
  File "pandas/_libs/testing.pyx", line 178, in pandas._libs.testing.assert_almost_equal
  File "/Users/runner/miniconda3/envs/travisci/conda-bld/hpat_1572993959417/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/pandas/util/testing.py", line 932, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: Series.index are different

Series.index values are different (77.77778 %)
[left]:  Int64Index([ 1, 19, 10,  2, 20, 11,  0, 16, 15, 25, 12,  9,  7,  6, 24,  3, 21,
            18, 22, 13,  4, 14,  8,  5, 23, 17, 26],
           dtype='int64')
[right]: Int64Index([ 1, 10, 19,  2, 11, 20,  0,  3,  6,  7,  9, 12, 15, 16, 18, 21, 24,
            25,  4, 13, 22,  5,  8, 14, 17, 23, 26],
           dtype='int64')

@shssf This test is not related to the current PR. I think, there is a problem in sort_values algorithm, it fails on changed global data with duplicated values


[GC stress] Add multiple DDSs to data stores in stress tests

Description
Added multiple DDSs to the leaf data stores. Updated the activity on it to changing none, one or both of them. This will give us coverage when between summaries some DDS re-summarize where as some use summary handles. With this change, we should have coverage of all these scenarios:

Data store changes and re-summarizes via a Summary tree.
Data store does not change and does incremental summary via Summary handle.
DDS in data store changes and re-summarizes via a Summary tree.
DDS in data store does not change and does incremental summary via Summary handle.

Reviewer guidance
This is for an experimental stress test in test/gc-stress branch. This is not in the main FF branch and does not affect its stress test

Data store changes and re-summarizes via a Summary tree

Does "Data store changes" happen if either DDS changes?  Or does the Data store only change when DDSes are created or something?

Data store changes and re-summarizes via a Summary tree

Does "Data store changes" happen if either DDS changes? Or does the Data store only change when DDSes are created or something?

It happens when it gets an op which includes any ops for its DDSes. So both of the scenarios you described above will result in data store changing.


Rails/HelperInstanceVariable: should not complain about using instance variables when directly extending FormBuilder

Expected behaviour
Rails/HelperInstanceVariable should not complain about using instance variables when directly extending ActionView::Helpers::FormBuilder class. It should have the same behaviour as inheriting from it.
# app/helpers/form_helper.rb
module FormHelper
  class ActionView::Helpers::FormBuilder
    def foo
      @object
    end
  end
end

Actual behaviour
RuboCop Rails will complain about usage of instance variables
RuboCop version
1.23.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.13.0, running on ruby 2.5.8 x86_64-linux)
  - rubocop-performance 1.12.0
  - rubocop-rails 2.12.4

Hi, its namespaced under FormHelper because its required, if not it raises NameError and complains that FormHelper, is expected it to be defined in helpers/form_helper.rb . The second question, in fact i've got a typo and the module has the same name as the file. How autoloading works for FormHelper::ActionView::Helpers::FormBuilderI do not know the answer, some kind of Rails magic? I can only say it works.
Working on a legacy Rails(v4.2) app, that has some +50 forms, i was tasked to change the behaviour of the submit button (JS is not an option). The idea behind this, was to directly extend the functionality of the submit method, so as to not have to create a custom FormBuilder and modify all form views in the app to add the :builder option

To my understanding, the original message:

Rails/HelperInstanceVariable should not complain about using instance variables when directly extending ActionView::Helpers::FormBuilder class

does not really apply to the FormHelper::ActionView::Helpers::FormBuilder class, or does it? How do you use FormHelper::ActionView::Helpers::FormBuilder exactly? Do you inherit form builders from it?
class MyFormBuilder < FormHelper::ActionView::Helpers::FormBuilder

How does it work? Does the class itself inherit from ActionView::Helpers::FormBuilder?
module FormHelper
  class ActionView::Helpers::FormBuilder < ActionView::Helpers::FormBuilder

That makes it something like ApplicationFormBuilder.
Please accept my apologies for building up assumptions upfront, I'm looking to understand your scenario.
Do you have many of those classes, or just one?
If it's just one, would it make sense to disable the cop for it?
module FormHelper
  class ActionView::Helpers::FormBuilder # rubocop:disable Rails/HelperInstanceVariable

Rails guides don't use instance variables in their form builder examples. Rails API docs do use instance variables, but only internal ones like @template/@object_name (even though object_name is accessible via an attribute).
It would make sense to relax this rule specifically for form builders to allow @template/@object and others. But it's a different course of action.
Form builders are not helpers, and I would put them all to app/form_builders. Do you follow a similar project structure?

How does it work? Does the class itself inherit from ActionView::Helpers::FormBuilder?

No, i'm actually monkey patching ActionView::Helpers::FormBuilder to change the behaviour of the submit method

Do you have many of those classes, or just one?
If it's just one, would it make sense to disable the cop for it?

Yes, i just thought it was a valid use case.

Form builders are not helpers, and I would put them all to app/form_builders. Do you follow a similar project structure?

You are absolutely right about this, maybe i should place it under app/form_builders.
Thanks for your time, really appreciated


Fail to start when second screen is clone of first

Exception caught initializing the UI:
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/screendimmer/tray.py", line 32, in __init__
    self.init_ui()
  File "/usr/lib/python3.10/site-packages/screendimmer/tray.py", line 41, in init_ui
    self._apply_connections()
  File "/usr/lib/python3.10/site-packages/screendimmer/tray.py", line 181, in _apply_connections
    [(i, monitor.triggered.connect(self._switch_monitor_func(i))) for i, monitor in enumerate(self.monitors)]
  File "/usr/lib/python3.10/site-packages/screendimmer/tray.py", line 181, in <listcomp>
    [(i, monitor.triggered.connect(self._switch_monitor_func(i))) for i, monitor in enumerate(self.monitors)]
  File "/usr/lib/python3.10/site-packages/screendimmer/tray.py", line 251, in _switch_monitor_func
    return switcher[index]
KeyError: 3

Appreciate the error report and thank you for the opening this issue. I will take into account cloned monitors in the next update.


Roll Plugins from 0cfbe1779ecb to 0f90d24f81ae (1 revision)

https://github.com/flutter/plugins/compare/0cfbe1779ecb...0f90d24f81ae
2021-11-10<EMAIL_ADDRESS>[webview_flutter] Implement loadRequest in iOS package. (flutter/plugins#4480)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Update Clojure(Script) & use tools.reader

All the tests pass for me, feel free to have a look and see if this might be worth pulling in.
A couple of things I'm not sure about:

the whitespace?/boundary? etc. predicates - I kept them the same as before, but inlined the #js lists
I wasn't able to get cljs.tools.reader/read-keyword to work, so I kept the previous version
I added "-SNAPSHOT" to the version in project.clj, I'm not sure how these things are normally handled

Tx a bunch !
The travis build fails, but I think it's just a small fix in the travis config so I'll fix that before releasing.


Low fps result

The paper reports that without tensorrrt it obtains 67.0fps and with tensorrt it obtains on RTX 2080 Ti. But I have tested the notebook without trt, the inference time is 0.26 seconds. I have checked Colab GPU and it was Tesla T4. I wonder why it performs so poorly.

How did you measure the FPS? Did you use the --benchmark option?

Thank you for your quick response.
I measured the runtime in the colab notebook as follows:
start_time = time.time()
with torch.no_grad():
    preds = net(batch, extras=extras)["pred_outs"]
end_time = time.time()
runtime = end_time - start_time

print("--- %s seconds ---" % runtime)

Please run the network forwarding op for multiple times (e.g. 100/1000), and average the runs.

I am sorry. you are right. I tested it with 1000 steps and computed the average value. As result, the runtime was 55seconds and the speed was 17fps on Tesla T4 (Colab).

Glad that you have the doubts clarified :)


View of board is periodically reset, occasionally undoes changes

When I'm looking at a board, and I have many tasks in a column, to the point where I need to scroll down to see them all, the page will periodically reset itself, scrolling to the top of the column.
This seems to happen every 12 - 15 seconds.
If I'm dragging a task when this happens, the task is dropped from my cursor, and returns to where it was.
Occasionally, after I have already moved a task, it will move back to where It was moved from. This seems to coincide with the reset of the columns.
This seems like an issue of synchronizing data to and from the server.

Yeah, this is planned for v0.4.0 (see #34).


Add TLS outside of Kubernetes (KubernetesIngress)

Feature
We use Traeffik with pre-made self-signed certs outside of Kubernetes.
Trying to use an HTTPS Endpoint, traeffik doesnt detect / find the secrets.
We would like a way to specify a default Certs so that the routing can be TLS detected?
ie: Using an HTTP endpoint it works, but using an HTTPS endpoint doesnt works since TLS isnt defined? It simply returns 404 for some reasons.

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


Inconsistent behaviour with insert() followed by saveDatabase()

const newApp = dbhelper.getFormattedApp(newAppInfo, function(newApp){
  db.loadDatabase({}, function(){
    db.getCollection('apps').insert(newApp);
    let nApp = db.getCollection('apps').chain().find({ 'application':newApp.application }).data();
    console.log(nApp[0].num + ' written to db $loki id reported as: '+nApp[0].$loki);
    db.saveDatabase(function(){
      req.session.assignment = helper.getOffName(newApp.assigned);
      res.redirect('/new');
      return;
    });
  });
});

In the above code I create a new object, insert into the database and then call db.saveDatabase as per the documentation. This works most of the time however sometimes the insert does not persist and upon a subsequent object being written the database reports the same id as the previous one. This is illustrated in the screenshot below:

As can be seen on the left the console.log reports the $loki id following the insert function call, but this does not persist consistently resulting in objects being missing highlighted on the right in yellow.

Can you tell if this is a timing issue?  How much time is elapsing between each load/insert/save.  I'm wondering if there are overlapping calls.
Ideally I would think you would not load every time, and additionally I would autosave on interval rather than explicitly to keep this handler efficient.
So you keep db instance global (outside handler), do you have a purpose for loading and saving manually or can we change that?
LokiJS supports load and save throttling so it should drain save queue before loading unless you have disabled throttled saves.
You aren't reinstantiating the db object elsewhere are you? Or are you just repeatedly reinvoking loadDatabase and saveDatabase on the same 'db' loki instance?

I reorganised the code so that there is now only one call to the loadDatabase function. This seems to have cleared the issue. Thank you for the feedback and the suggestions that help me better understand what I was doing wrong.


Update array-stack.rst

For input:
>>> data = [from_array(np.ones((4, 4)), chunks=(2, 2))
... for i in range(3)]

I get the following error:
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
NameError: name 'from_array' is not defined

I have proposed a small fix for this error.
Thank you!

This seems great to me.  Thank you @jiteshjha !
Will merge once the testing systems say it's ok (though of course this shouldn't change anything).


UA landing page UI

User Story
As a Web/Android Full Stack Developer, I will want to develop a very simple user authentication page. I will get in touch with the lead engineer should I have any questions or need support.
Story Points: 6-12
Screenshot Example

Related Examples

Android login screen using Jetpack Compose part 1
Android login screen using Jetpack Compose Part 2

References

Material Design for Android
Material Design
Material Design 3 in Compose

This Issues is complete, yes?

Yes, it is complete.


Fix issues to compile Yolov3-12

Fix issue https://github.com/onnx/onnx-mlir/issues/1722 (Yolov3-12 model cannot be compiled for NNPA by the latest main branch).
Stop conversion to enable onnx.LeakyRelu on NNPA when the stickified layouts of input and output are not the same.
(Most onnx.LeakyRelu of Yolov3-12 are still enabled on NNPA with this PR.)
Signed-off-by: Yasushi Negishi<EMAIL_ADDRESS>

Jenkins Linux amd64 Build #7756 [push] Fix issues to compile Yo... started at 20:50

Jenkins Linux ppc64le Build #6820 [push] Fix issues to compile Yo... started at 21:52

Jenkins Linux amd64 Build #7756 [push] Fix issues to compile Yo... passed after 1 hr 1 min

Jenkins Linux s390x Build #7772 [push] Fix issues to compile Yo... passed after 1 hr 25 min

Jenkins Linux ppc64le Build #6820 [push] Fix issues to compile Yo... passed after 1 hr 31 min


Start the SAM backend inference service in Anaconda Powershell Prompt

It looks like it's caused by you not downloading the weights to the corresponding paths.


For [Adding a new column for events #673]

Relates to #673

Added migration to updata activity log table to add event column.
Added event() & setEvent() method to the logger to set activity event.
Automatically set activity event based on model events.
Added test cases for event, and updated some of currents which used to handle events via properties.

Hey @AbdullahFaqeir
thanks for your time and work here.
At first I want to ask you to remove the .idea - from the gitignore but also from the repo/branch.
@sebastiandedeyne wrote an awesome article about it:
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
In addition to this: please fix the code style.
You can see what to do at StyleCI
And now I will review your changes in depth. =)

@Gummibeer
You're most welcome, I'm pleased to help =)
I've applied all your request changed.

👍🏻

https://github.com/spatie/laravel-activitylog/releases/tag/3.14.0


Fix cupy.ndarray document relating to subclass support

This PR fixes cupy.ndarray's documentation that #6716 has broken.

Let me include this change into #6746 as sphinx seem not to identify cupy.ndarray as expected without the renaming to be handled in #6746. It still emits 'alias of...' here.


Broken Role/SA/STS Deletion

Describe the bug
When trying to delete resources of types [role|serviceaccount|statefulset], the resource-type is wrongly passed as the name of the requested instance to delete, and the deletion itself fails.
To Reproduce
Run kor [role|serviceaccount|statefulset] --delete.
Expected behavior
The resources would be deleted.
Screenshots

OS version, architecture and kor version
Kor version: 0.3.3

@yonahd please assign this issue to me.
WIP in #201


ticdc openapi new parameter support

Is your feature request related to a problem?
ticdc openapi kafka  new parameter support
"enable-old-value":
"opts":
Describe the feature you'd like
in operation ticdc openapi， support opts enable-old-value modify
curl -X POST -H "'Content-type':'application/json'" http://<IP_ADDRESS>:8301/api/v1/changefeeds -d '{"changefeed_id":"test","sink_uri":"blackhole://","enable-old-value":"false", "opts":"tidb-domain=test-tidb.svc.local"}'
Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response

The enable-old-value param is set to true by default and we suggest not changing it.

Can another parameter   eg : "opts":"tidb-domain=test-tidb.svc.local" be supported?


Talk through doorbell

Thanks for the plugin, it's great to have the video from the doorbell in Homekit rather than using the Eufy app. Is it possible to add the functionality to talk to visitors through the doorbell like you can in the Eufy app? If so, that would be a great addition and much appreciated! Many thanks.

@jrb74 this is actually to do with the way Eufy have their audio.  Eufy use what's know as One-Way or Single-Way Audio, which is like a walkie-talky.  You push to talk, and that mutes the other person.  Only one person can be talking at a time.  HomeKit doesn't accept this, and there's no way to get it to.  HomeKit only works with what's called Dual-Way Audio, like a telephone, where both people can be talking at the same time.
This issue is actually the reason that the Eufy doorbell's don't have native HK support, according to Eufy.  They were trying to find a way to fix this earlier in the year, but it seems they might be looking more towards just releasing new hardware instead, unfortunately.  There was a leak of an optional doorbell chime that had a HK QR code on it, which implied that the were going to use that not only as the chime, but also as a way to override the audio settings to allow Dual-Way, but it doesn't look like that came to fruition.

We could implement it using “speak-to-chat” option.
Once a certain threshold is reached on the iPhone/ipad, in dB, the push to talk command would be sent. Once lower, it would stop.

Thanks both for the replies - makes sense now why it doesn't have native HK support. Sounds interesting that there might be a way to work around it!


How to get traceid while using Spring Cloud Gateway

Please answer these questions before submitting your issue.

Why do you submit this issue?
Bug

Bug

Which version of SkyWalking, OS, and JRE?
Skywalking 8.6.0

What happened?
I am using Spring Cloud Gateway 3.x in our project. I also add  apm-spring-cloud-gateway-3.x-plugin-8.6.0.jar and apm-spring-webflux-5.x-plugin-8.6.0.jar to the agent plugins directory. I want to print skywalking traceId in the log (logback).
The pom of apm-toolkit-logback-1.x has been added to the project. But I can't get the traceid. Is there any way to get traceid?
Thank you so muck!

Requirement or improvement

Please describe your requirements or improvement suggestions.

We never says, we provide this in Gateway always. If you want to learn why, you need to know how trace context propagates.

https://bothsavage.github.io/article/240121-skywaking


TimeOverlapFinder is not able to access in the main

print(TimeOverlapFinder.findOverlap(overlapParams));
Cannot access the TimeOverlapFinder function,
i have tried the import and also intellisense..
but not able to call or access the assembly.

@XeroDays I really appreciate if you can share the screenshot of the error which helps me to understand the issue much better


ose uri

Closing since this looks like it was opened by mistake

Closing since this looks like it was opened by mistake


virtualbox: Add option to build vboxwebsrv tool

vboxwebsrv, a.k.a, Virtualbox Web Service, provides a way to manage VMs via SOAP interface. This is very useful on headless servers.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Screenshot of phpVirtualbox running with building result showing my VMs in browser.


Minimap State needs to store array and serialize to database

Opening your map you'll see the "fog of war" or shadow over the map tiles. Moving around uncovers or reveals these map tiles. We need to store the array of tiles per map, and serialize them to the database in some form. Possibly under some kind of PlayerProgress struct that will include contact lists, clues, badges and souvenirs in the future.
MapInstance::on_minimap_state(...) in MapInstance is a place to start. That event has the following variables:

uint32_t tile_idx; - the index of the tile being uncovered

Steps to complete this feature request:

[ ] Get current map_idx for use in minimap_state
[ ] Store tile idx in nested array grouped by map_idx
[ ] Store array in PlayerData (maybe new struct called PlayerProgress? Is it necessary?)
[ ] Serialize minimap_state_array to database for cross-session persistence
[ ] Determine which opcode is used to receive map state upon map transfer or login (aka, how does the client know what parts of the map are revealed?)
[ ] Serialize array from database back to array stored in PlayerData
[ ] Send updated array to client upon log in, or map transfer based upon map_idx

Feel free to discuss or add additional features in the comments below. I'll add relevant info here.

I believe Banks(mlarney) started on this. I don't know the current status.

Our Packet 22 might look something like this in serializeTo()
    bs.sendPackedBits(1, 1);
    bs.sendBit(1, is_opaque);
    bs.sendPackedBits(1, num_cells);
    if(num_cells)
        bs.sendPackedBitsArray(num_cells, cells_arr);

where
    bool          is_opaque = false; // is_opaque only in mission maps where the fog is black
    uint32_t    num_cells;             // number of cells being updated (fog removed)
    std::vector<bool> cells_arr;    // array of "is_visible" flags. Could be expressed as 32x32 array instead

I'll take on this issue. I have the first 3 steps complete so far, in the middle of the 4th step. Unfortunately, it doesn't seem like we can make use of std::bitset due to issues with cereal, so I plan on storing the data in the following way:
"Progress": {     "VisibleMapTiles": // or "MapTiles"         {                 "12": [                     false,                     true,                     false,                     ...                 ]         } }
Each map having 1024 possible values, indices whose values are true will relate to revealed map tile ids.

Seems like a good way to go.


Enhancement/startwar easier reading

Start modularizing the bot in order to get it to be maintainable.
Just wanted to provide the first example.
The next step will be migrating all commands to this new structure.
Couldn't test it easily because of the neediness of auth tokens and several other files.

Couldn't test it easily because of the neediness of auth tokens and several other files.

This might help: https://github.com/BadWolf1023/MKW-Table-Bot/pull/78#issuecomment-1000575257
And this is important as well: https://github.com/BadWolf1023/MKW-Table-Bot/pull/78#issuecomment-1000652879
If you join the Discord server, https://discord.gg/K937DqM, Andrew (who is the new owner of Table Bot) might be willing to give you some real Table Bot data that could help you test.


Ready for a new release?

I see some commits that fixes some of the errors I'm seeing.
Specifically:

https://github.com/oney/react-native-webrtc/commit/22e4a3aae252fbe01f8305b4f113f900573d42cd
https://github.com/oney/react-native-webrtc/commit/1b3270f56bb1d4f42d57481ae60b68f3e650906b

Can we bump the version and have a new release? Is it ready? Thanks!

I'm fine with that. @zxcpoiu can you please cut a release when you can? Thanks!

yes of course, I was just not sure if it is stable yet.
done!


Use HTTPS link in MPL

Update the link in the MPL license text to match the official license text from https://www.mozilla.org/en-US/MPL/

Thanks

Please just merge this change

Thanks. I forgot about this, reminded by seeing https://github.com/spdx/license-list-XML/pull/2498 merged.


Set soft_wrap in console.print json  to prevent truncation

Type of changes

[X] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[X] Tests
[ ] Other

Checklist

[X] I've run the latest black with default args on new code.
[X] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[X] I've added tests for new code.
[X] I accept that @willmcgugan may be pedantic in the code review. (😏 )

Description
This PR adds soft_wrap=True to print_json to prevent the truncation of values longer than the width of the console.

Fixes #1653

Yep, thanks!


Signal handlers, clear terminal title on shutdown.

The signal handling code only gets compiled under Mono. The Console.CancelKeyPress code always does though.

Why does the title need to be cleared?

@psykzz if we don't clear it explicitly, it stays after the process exits:

See here my terminal tab title and window title (due to being the selected tab) being the title from the non-running server.

Makes sense, thanks.

@PJB3005 conflicts

@PJB3005  SS14.Server.Services/ServerConsole/ConsoleManager.cs conflicts


SAK-45511 Add time limit labeling in Test & Quizzes' Exceptions settings

https://jira.sakaiproject.org/browse/SAK-45511

@cargonm6 I am not seeing a CLA on file please read the contributing readme and submit a CLA.

Hi @ern, thanks for letting me know about the error. Yesterday I requested the CLA from the Apereo website, but it is still not listed (http://licensing.apereo.org/).

Carlos works for UPV which is in the CCLA list and provided an ICLA two times.


Prevents gfycat gifs/webms from displaying

Whenever the extension is active, anything on gfycat will not load. It simply displays a still image.
Disabling the extension and the problem is solved.

Thanks for reporting. Will check it.

Related to #60


Bump blake3 from v1.5.0 to v1.5.1

Problem
Recently blake3 made miri-compatible upstream by me: https://github.com/BLAKE3-team/BLAKE3/pull/387 and released https://github.com/BLAKE3-team/BLAKE3/releases/tag/1.5.1:

The Rust crate is now compatible with Miri.

However our dependabot doesn't spoil me for the chore for some reason. ;)
Summary of Changes
Update the crate manually.
Fyi, this unblocks cargo miri test -p solana-unified-scheduler-logic. ref: https://github.com/anza-xyz/agave/pull/129
cc: @apfitzge @alessandrod

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (b1919bd) to head (3235929).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #488     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%
=========================================
  Files         842      842
  Lines      228343   228343
=========================================
- Hits       186954   186952      -2
- Misses      41389    41391      +2


Except log target

What steps will reproduce the problem?
I want to limit sending to mail type of errors. Setting the config:
'log' => [
	'traceLevel' => YII_DEBUG ? 3 : 0,
	'targets' => [
		[
			'class' => 'yii\log\EmailTarget',
			'levels' => ['error', 'warning'],
			'except' => [
				'yii\web\HttpException:404',
                                'yii\web\HttpException:429',
				'yii\web\ForbiddenHttpException:403',
			],
			'mailer' => 'yii\swiftmailer\Mailer'
		]
	]
]

What is the expected result?
Excluded messages should not be sent
What do you get instead?
All messages are coming
Additional info

Q
A

Yii version
2.0.19

PHP version
7.3.3

Operating system
Linux

https://github.com/yiisoft/yii2/issues/17107 ?

It's very similar

Now I'm not sure it's a mistake. The fact is that if the constant YII_DEBUG is set to false, the sending does not occur. But, at the same time, if you do not handle specific exceptions, it does not work very well.
I think it's just worth pointing it out in the documentation.

6 Jun?

6 Jun?
@samdark
https://github.com/craftcms/cms/commit/34e1fef8ee10754014ab1bc986b682ef5f0fa4a9

That doesn't look like a fix...

this is an example)

This is my config and it works as supposed to
              [
                    'enabled' => !YII_DEBUG,
                    'class' => 'yii\log\EmailTarget',
                    'levels' => ['error', 'warning'],
                    'except' => [
                        'yii\web\HttpException:404',
                        'yii\web\HttpException:403',
                        'yii\web\HttpException:401',
                        'yii\debug\Module*',
                    ],
                    'message' => [
                        'from' => $params['email.error'],
                        'to' => $params['email.support'],
                        'subject' => $params['name'] . ' - error',
                    ],
                ],

404,403,401 really don't go over the mail.
Another thing is I created a target for every of those Exceptions like this:
                [
                    'class' => 'yii\log\FileTarget',
                    'levels' => ['error', 'warning'],
                    'categories' => ['yii\web\HttpException:404'],
                    'logFile' =><EMAIL_ADDRESS>                ],

Maybe this can be the difference.

Maybe this can be the difference.

No.

Since it's verified that it works, closing the issue. Thanks for posting, @OndrejVasicek.


fix: 修复合并单元格被grid边框覆盖的问题

👀 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[x] Solve the issue and close #1560

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description
原因：gridGroup用于绘制边框，绘制完成后会toFront，导致它被放在最上面的，把合并单元格给盖住了。
现在将所有的合并单元格收敛到mergedCellsGroup中统一管理，并且在drawGrid后，将mergedCellsGroup toFront，保证其不会被覆盖
🖼 Screenshot

Before
After

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.24.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.24.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The completion menu is not aligned correctly

System: Windows 10  20H2 19042.867
Version: nvim v0.5.0-dev+1157-g0ab88c2ea
Configs: minimal vimrc

As shown in the figure, the completion menu is not properly indented and aligned. How can i make them aligned?

seems like you're using a Neovim GUI client. Which one is it? (I'm guessing it's nvim-qt). Try disabling the GUI for the popup menu.


fix: enable strict null checks

This will help catch logical errors and make it more clear when we should refactor certain code to remove excessive null checks

:tada: This PR is included in version 0.295.26 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Looks like bbnpm leaked back in on this checkin...

Ah, damn. Thanks will fix


[EUWE] Do not stop and start evmserverd if it was not running

This change is only needed in, and should only be applied to, the euwe branch.
This PR simply ensures the evmserverd service is not manipulated after logfile
configuration changes are made, if the evmserverd service was not running.
To test this upstream:
add an extra harddisk to the test appliance,
disable evmserverd
attempt to use the appliance_console to add a new logfile disk volume.
To disable the evmserverd service upstream do:
  systemctl stop evmserverd && systemctl disable evmserverd
  systemctl stop $APPLIANCE_PG_SERVICE && systemctl disable $APPLIANCE_PG_SERVICE
  echo "rm PG data"
  rm -rf $APPLIANCE_PG_DATA/*
  vmdb
  rm -f REGION config/database.yml GUID

After executing the above commands use the appliance_console to configure a new
logfile disk volume, ensuring no traceback is produced.
Manually pulled commit ManageIQ/manageiq-gems-pending/commit/5bf80c831ea436c855e4ba1beccea3883a9aa174
https://bugzilla.redhat.com/show_bug.cgi?id=1393349

@simaishi This is the manual PR for https://github.com/ManageIQ/manageiq-gems-pending/pull/34#issuecomment-272190603

@carbonin Please review

@miq-bot add_label appliance/console, bug, euwe/yes

@carbonin Let me know when this is good-to-merge and I'll squash my commits.

Thank you @carbonin !
@simaishi I'll squash the commits.


Action_Button in Dashboard

Is it possible to render an action button in the dashboard.
I've tried adding:
action_item :only => :index do
link to "Home", root_url
end
but this leaves the error:
undefined method `action_item' for ActiveAdmin::Dashboards:Module
Any suggestions?

To my knowledge, this is not supported.  DashboardController technically inherits from ActiveAdmin::ResourceController, but the block you pass in to DashboardController.build {} is executed in the context of a module, and I could not find a way to get access to the actual instance of the controller (DashboardController).


Fix consistent events - accepting incoming requests working

There was a bug that―for incoming connection requests―unreadEvents[cnctUri].uri didn’t match any uri in the list of own events. The message handling was just using the first successful framing result―essentially yielding the remote counterpart of the own event, which of course had a different uri. A selector function in the feed-view was crashing as a result, while trying to access properties of an undefined event.
The code is now returning the correct event. What’s more, all events now also contain have property with their counterpart attached, as you can see in the state. Especially for incoming requests, this counterpart holds valuable information.

When additional text message is provided it is not included in the sent message. Otherwise Accept works - open message generated and sent and gui reacts.


Docs recommend pip install superset even though superset is superceded by apache-superset

The docs recommend pip install superset but Superset has moved to apache-superset on PyPi.
Describe the solution you'd like
Update the docs to point to the more recent version of superset.

Hi @metaperl,
Nice catch, are you wiling to submit a PR for this?

Perhaps the score of the variance between the 2 PyPi distributions should be widened? I wanted to install both superset and apache-superset from PyPI but both distributions write to /root/.superset/superset.db with the default config file.
It would be nice if each wrote to a unique default db.
As far a PR, I dont have that level of sophistication or free time at the moment.

Hi @metaperl,
Nice catch, are you wiling to submit a PR for this?

I find that the github document had been fix it ,but the doc not update,why that happend?

@zhouyao1994, I see that's included on 0.35.0 but the docs were not updated yet, we are waiting or 0.35.1 that will probably be out next week.

@dpgaspar ok,thanks~


Option to use vlc://url instead of mpv://play/url

Hi there, it would be really helpful if I could use a different url for opening things in mpv. I use a third-party web site that already has set up vlc://url buttons and seems too much of a challenge for me to do it alone...

I am not sure if I am allowed to share the name of the website, as they try to keep the community in a manageable size..

I am not sure if I am allowed to share the name of the website, as they try to keep the community in a manageable size..

Emm, so I can't help you anymore.
Because I don't know the vlc://URL format and its html element. Cannot write a userscript for you.
But you have other ways, you can use vlc to play videos from that site directly.
😅


ROI-based k-means

Is your feature request related to a problem? Please describe.
For markers that don't belong directly to cells, or combinations of cellular and acellular markers, it's not straightforward to generate summary statistics of how they interact with one another.
Describe the solution you'd like
One way of addressing this issue is by binning the image data into lower resolution, less granular ROIs, and then clustering those ROIs. For example, given an image dataset:

Load each image
Normalize based on the 99th percentile.
Divide the image into nonoverlapping bins of a user-specified size
Sum all of the signal within each channel, producing a vector of summed counts for each channel
Use this vector for kmeans clustering

Having a notebook to perform these tasks, as well as the subsequent visualization of the output and mapping back the vectors to the image they came from, would be quite useful.
This one should have a design doc.

Implemented in the TNBC repo


[proof-systems] update blake2 to fix build issue

@A-Manning reported that issue:
(cd _build/default/src/lib/marlin_plonk_bindings/stubs && $HOME/.cargo/bin/cargo build --release)
    Updating crates.io index
error: failed to select a version for the requirement `crypto-mac = "^0.5"`
  candidate versions found which didn't match: 0.11.1, 0.11.0, 0.10.1, ...
  location searched: crates.io index
required by package `blake2 v0.7.0`
    ... which is depended on by `commitment_dlog v0.1.0 (_build/default/src/lib/marlin/dlog/commitment)`
    ... which is depended on by `marlin_plonk_stubs v0.1.0 (_build/default/src/lib/marlin_plonk_bindings/stubs)`
make: *** [Makefile:100: build] Error 1

Looks like old versions of crypto-mac were yanked. Things still built if you had a Cargo.lock file in there, but the right thing is to update our dependency instead.

waiting for this fix: https://github.com/MinaProtocol/mina/pull/9298


Support non-standard sighash types

Just the third patch, first two are from #879.
Draft because this is still at the idea stage. Some obvious questions

Do we want to change the API to not use EcdsaSigHashType or would it be better to change the type to carry the raw int value around
Bitcoin Core uses an int which means, IIUC, a signed 32 bit value and this is serialized but we are using an unsigned 32 bit value in our API so we have to be careful that the sign bit gets correctly serialized along with the value
Because all the casting is so funky it would be nice to have some tests for non-standard transactions that pass in Bitcoin Core and pass in rust-bitcoin but the unit tests are opaque because its all hex. There are loads of python tests in Bitcoin Core that I have not yet groked - perhaps there is one in there?

This is wasting precious reviewer time.
ref: https://github.com/rust-bitcoin/rust-bitcoin/issues/777#issuecomment-1073034640


Support GitLab

GitLab is a free software alternative to GitHub. It would be nice if homu supported it out-of-the-box.

I'll go ahead and disagree rather strongly at the moment.
homu is a tiny tool that works very well. It works well because it's feature-set is currently very small, its architecture is simple, and its well written and maintained. While introducing support for GitLab would probably introduce some great refactoring opportunities (e.g., separating parsing of comments and interaction with a service) I think the project doesn't need to introduce a large scale refactoring at the moment (as much as I want more services to support both GitHub and GitLab).
A fork of homu should be made to support GitLab. Ideally, it would not introduce new features that homu hasn't introduced, but it would support GitLab instead of GitHub. If that proves popular enough, merging the two projects could then be done slowly through a series of pull requests that refactor pieces away from the platform it is supporting.
Does that make sense?

Actually I've thought from the beginning that Homu should probably support at least BitBucket. I admire GitHub, but at the same time I feel a vague sense that I should not contribute to the so-called GitHub monoculture. Unfortunately Homu didn't get much attention on supporting other source repositories. One of the obstacles was that the BitBucket API lacks direct Git manipulation that Homu requires, but thankfully Homu recently gained a feature to directly use the local Git command. I don't think adding support for BitBucket and GitLab is that much hassle. So I think it should be done someday.

Any news here? :newspaper:

Any news here?


Update vehicles with senses and ignore hardness

Vehicles with special senses and attacks which ignore hardness updated.
(Draft whose data changes depend on these architectural changes: https://github.com/wildj79/foundryvtt-starfinder/pull/331)

The files changed list contains a lot of files from an earlier pull request, can you please recreate this PR so I can see just the actual changed files?

@TimToxopeus fixed.  👍


Master

steps.zip

https://github.com/pippianders/bitrise-steps-script/pull/1#issue-1689624492

steps.zip

Yup


[client,file] add WebAuthN rdp file parsing support

is it me or there's just the setting and nothing more ?

@hardening currently just the settings and rdp parser stuff.


Travertine Kick

Hi, when a server crash, users dont be sended to hub, but they will be kicked out of the server. How i can solve?

There are plugins such as MoveMeNow and HubKick which attempt to achieve this, I believe that bungee itself doesn't have this built in because it's hard to determine crash/vs an actual kick

MoveMeNow dont work

I used movemenow a month ago, it worked for me. U probalby configured it bad.

It said that i'm already connected to this server....


Muting flaky tests in SegmentReplicationSuiteIT

Description
Muting these tests until #9499 is resolved
Related Issues
#9499
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for c53d505: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/11109
https://github.com/opensearch-project/OpenSearch/issues/10154
https://github.com/opensearch-project/OpenSearch/issues/5409

❌ Gradle check result for c53d505: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/10755
https://github.com/opensearch-project/OpenSearch/issues/10231

FAILURE

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':qa:wildfly:composeUp'.

Exit-code 1 when calling /usr/bin/docker-compose, stdout: N/A


docs: enabled blank issues

Description
Have enabled blank issues in the config.yml of ISSUES_TEMPLATE in order to allow blank issues.
Checklist:

[x] This pull request follow our contribution guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (postman and swagger)
[x] I have written tests for the code
[x] I have updated .env.example file for new .env variables

What is current behavior?
Unable to create blank issues
Closes #23
What is new behavior?
You should now be able to create blank issues
Additional information

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

@all-contributors please add @tharun634 for doc


Unsupported vector database: "azuresearch"

documentation mentions about azuresearch datastore, but when I run the server, getting 'Unsupported vector database: "azuresearch"

Odd, I see the entry for "azuresearch" in the match statement in factory.py is still there. Do you have a piece of code that reproduces the issue?

Okay, I see the problem. In the previous sentence, you set the environment variable with quotes, like this:
set DATASTORE="azuresearch"
However, you realized that the quotes were not necessary, so I removed them, and it worked fine
set DATASTORE=azuresearch.
Now, I am encountering another issue
azure.core.exceptions.ServiceRequestError: <urllib3.connection.HTTPSConnection object at 0x00000274C268EA50>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

Seems like an issue with your search service name (the error says it failed to resolve the DNS address of the search service endpoint). Your AZURESEARCH_SERVICE env var should we set to name of your Cognitive Search resource in Azure (just the name, not the full DNS address, the plugin will expand your  into https://.search.windows.net)


Support configuration via ppx-flags

When migrating to the current version of Migrate_parsetree I've removed ppx-flags based configuration (i.e ppx arguments).
This PR resolves #40 brings back configuration in ppx-flags in bsconfig.json and removes support for env variables. It's a breaking change and will result in "major" version bump (i.e minor because of pre 1.0.0 versioning we're using right now).

/cc @nirvdrum

woohoo @baransu great job on this

Nice one!!

I'll merge that and release it over the weekend.

Fantastic. Thanks!


Module parse failed: The top-level-await experiment is not enabled (set experiments.topLevelAwait: true to enabled it)

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I am trying to use RxDB on latest version of Angular but cli fails to compile anything that contains await in the code.
Minimal Reproduction
In this repository https://github.com/andreescocard/angular-tauri-rxdb is possible to reproduce the error using ng serve command.
Exception or Error
Error: Module parse failed: The top-level-await experiment is not enabled (set experiments.topLevelAwait: true to enabled it)
File was processed with these loaders:
 *<EMAIL_ADDRESS> *<EMAIL_ADDRESS>You may need an additional loader to handle the result of these loaders.
Error: The top-level-await experiment is not enabled (set experiments.topLevelAwait: true to enabled it)

Your Environment
Angular CLI: 16.0.0
Node: 18.16.0
Package Manager: npm 9.5.1
OS: win32 x64

Angular: 16.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1600.0
@angular-devkit/build-angular   16.0.0
@angular-devkit/core            16.0.0
@angular-devkit/schematics      16.0.0
@schematics/angular             16.0.0
rxjs                            7.8.1
typescript                      4.9.5

Anything else relevant?
Tried to install https://www.npmjs.com/package/@angular-builders/custom-webpack?activeTab=versions but is not compatible yet with Angular version 16 to add topLevelAwait using a custom webpack like specified on error.
Tried using ES2017 on tsconfig.json on target with no luck.

Hi @andreescocard, thanks for this feature request.
Top level await are problematic to support as they cannot be intercepted by Zone.js. Let's re-consider this in the future when Zone.js is not a hard requirement.

I loathe appending a note to a closed issue, but I have the same issue with a requirement for crypto which is now part of Node in "node:crypto" and requires the await for the import - so my question is - does this decision not to support top-level-await until Zone.js goes away mean that Angular will no longer support crypto and I cannot encrypt anything using Angular and Node:Crypto?  I think I understand the problem with prerequisites, but closing the issue without offering any guidance for alternatives makes me feel a bit stranded.  Can someone point me to a best practices alternative that works so that I can include crypto functions in my Angular project now that I have upgraded my project?

Using Node.JS specific APIs in general is a bad choice and should be avoided (Unless the API is being used in server.ts.
Cross-platform APIs like Web crypto API should be preferred instead.
Regarding top-level await, other than Zone.js when the bundled cose can cause some undesired/unexpected behaviour.
See: https://github.com/evanw/tla-fuzzer

Thank you for that.  Indeed - this is a server project.  I am looking at hapi/iron modules now and am trying to make a plan before I begin refactoring the authentication system.  At least I know I can stop banging my head against the node:crypto wall!


Add docker for DB, PHP and DB manager

Nice project, seems like a fun project to contribute to! 😄
At my job, we don't install MySQL/PHP/Web server on our local machines, we use docker. So I wasn't able to setup the project initially.
This PR adds a simple docker configuration (using the main MySQL image example yml file and a tag of the main PHP image which includes apache)
The PHP image doesn't have htaccess' rewrite module enabled by default, nor does it have mysqli extension, so those have been added via Dockerfile
A Makefile was added so all you need to do is run $ make to get the docker containers running
After running make:

To migrate the DB, run make migrate

To view the app in the browser, visit http://localhost:8100

To view the DB manager (Adminer), visit http://localhost:8081

The MySQL credentials have been left as default (root and example) but this can be changed/configured at a later time. The server or host is db (i.e. the name of the database container)

This is awesome, Sammy, thank you! I tested it and works like a charm. 👌


Remove inaccurate claim about operating systems

Operating system includes kernel, and singularity does not allow choosing a different kernel

"Distribution userland" might be more accurate, but pedantic and more difficult for the folks that message is intended to go to.


First is-booked in range disables itself when an available date is selected

This is on 1.5.7 from the CDN...

Date range selection
Booked dates defined in an array
Go to March/April view
Note the first dates in the booked(disabled) date ranges
Click on an available date
First dates in the booked date ranges are all of a sudden enabled

https://jsfiddle.net/e7ntyzo0/
https://www.loom.com/share/cdf8569285494e1ea888db95559d7cad
Thanks!
Jim

Perhaps the option lockDays will help with this.
https://jsfiddle.net/sod3cerw/

Perhaps the option lockDays will help with this.
https://jsfiddle.net/sod3cerw/

It's interesting how that the issue doesn't occur with that setting however that's not the user experience that my clients want.  The user cannot select backward and would have to close/reopen to reselect.

It's interesting how that the issue doesn't occur with that setting however that's not the user experience that my clients want.  The user cannot select backward and would have to close/reopen to reselect.

Use selectForward: false if you need to select backward, in the example it is true because hotelMode is enabled.
That is why I removed this option (hotelMode) in v2, because there are many cases for hotels and this option is misleading.

Use selectForward: false if you need to select backward, in the example it is true because hotelMode is enabled.
That is why I removed this option (hotelMode) in v2, because there are many cases for hotels and this option is misleading.

Now this does work for me.  I agree it is a bit confusing and combining these is a good move.  I didn't relate the lockedDays to my use case so consider that in the documentation.
Just to summarize
Kept - hotelModel: true
Replaced - lockDays in place of bookedDays
Added - disallowLockDaysInRange: true,
Added - selectForward: false so that user can select in either direction
I don't know if it's me but the calendar performance seems to be a little better as well.  It's a little bit snappier selecting.

Now this does work for me.  I agree it is a bit confusing and combining these is a good move.  I didn't relate the lockedDays to my use case so consider that in the documentation.
Just to summarize
Kept - hotelModel: true
Replaced - lockDays in place of bookedDays
Added - disallowLockDaysInRange: true,
Added - selectForward: false so that user can select in either direction
I don't know if it's me but the calendar performance seems to be a little better as well.  It's a little bit snappier selecting.


Do not fail if not support OomKillDisable

Fixes: #19278
The issue seems existed since we add support for OomKillDisable,
OomKillDisable support should not be hard request, we just
discard it if not support and move on.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

LGTM

LGTM, thanks!

LGTM

Hah, merged before I even had a chance to test it!  Doesn't the way this is written mean I'll have the warning printed to the console for every single container that my system launches? (WARNING: Your kernel does not support OomKillDisable, OomKillDisable discarded.)  Is this feature important enough for kernels to have support for to warrant a warning on every single container invocation? (IMO, docker info and a log during daemon startup really ought to be sufficient for bad kernels that don't support the feature)

$ docker run -it --rm s390x/debian:jessie
WARNING: Your kernel does not support OomKillDisable, OomKillDisable discarded.
root@4d636c801e2f:/#

Oh man, it's even worse if I specify the flag:
$ docker run -it --rm --oom-kill-disable s390x/debian:jessie
WARNING: Dangerous only disable the OOM Killer on containers but not set the '-m/--memory' option
WARNING: Your kernel does not support OomKillDisable, OomKillDisable discarded.
root@2236f7d43855:/#

@tianon It's wired, the warnings are supposed to be popped up when you use --oom-kill-disable, something else must be wrong, but this PR should be right anyway, I'll do more test.

Thanks @hqhq, I appreciate your help and diligence. :smile: :heart:

The problem with the added warning you see when disabling OOM directly on docker run  is that it is a client side addition from PR #17356. At that point in the code flow there is no knowledge of whether the server-side will find that OOM kill is not even a possible feature, making it, in your case @tianon, a spurious warning.  I don't know how many systems where this would be the case (disabling OOMKill on a system that couldn't have supported it anyway).
Seems there was general agreement that the warning is reasonable, I'm not sure we can fix that one, although we can fix the server-side "re-warning" you given you've already told it you don't want that feature.  That will still leave you with one warning every time :-/

Yeah, I'm OK with the additional warning when I explicitly specify, but I
don't think the server-side warning on every single container is really
warranted -- sorry for not being more clear on that. :smile:

Although if I explicitly specify and it's not supported, two warnings
is totally fine. :+1:


Better KtLintParseException error description

In case if code (somehow) has compilation issues (e.g. after merge conflicts), running lintKotlin will give this error:
lint worker execution error
com.pinterest.ktlint.core.api.KtLintParseException: 17:5 Expecting member declaration
	at com.pinterest.ktlint.core.internal.RuleExecutionContext$Companion.createRuleExecutionContext$ktlint_core(RuleExecutionContext.kt:137)
...

Which doesn't clear, what file cause this issue.

Yes, good point. Probably we should catch the error from running the ktlint library and wrap it in a better message indicating which file.


Make a briefs frontend

Replace buyer-frontend mentions with briefs-frontend
Replaces the docker container name, repository references and config
variable values.
Rename buyers blueprint to main
To keep it closer to the other apps, the majority of the routes
are under the main blueprint.
This also adds a copy of main/errors.py from the buyer frontend
with the common application error handlers.
Fix test login helper
Now that login view is not part of the app we need to use the same
approach supplier-frontend is using for logging in users during a
test run.
Add external blueprint for linking to pages from other frontend apps
Templates are using url_for with flask view names to generate links
to other application pages. After the split, some of these pages no
longer exist in the same application.
Normally, this would mean that we need to replace the url_for calls
with inline URLs. Instead, we add a new external blueprint without
the app's url prefix.
This allows us to copy the view definitions from the buyer-frontend
and keep using url_for with the new external.* view names.
The views aren't actually called, since the link will be routed to
a different app, but we get all the safety benefits of using url_for
instead of hardcoded URLs.
In the future, we could move the external view and blueprint to utils
so it can be shared between the apps.

Oh and good work on keeping the git history! How did you do that?

@idavidmcdonald we didn't do anything smart with commit history, it's a clone of the buyer frontend repo, so it also contains commits related to the removed files.


Request: Streetview availability layer toggle

I would like to request that if the Google Streetview tool is selected it could toggle on and off a layer called Google Streetview Availability. I can share the layer at your request.
Thank you for your consideration.

Hi @TheCre8r  this is a good idea. If you have an idea of how to do this I would definitely accept a pull request  or any code samples you could provide for the change.

After a preliminary search, these are the two things that pop out.
how-to-convert-layer-offon-python-code-to-a-script-too
turn-layers-off-in-arcgis-pro-using-arcpy
I have not looked at your code to see usefulness. I hope to look through it this week if I get some free time.


Issue connecting more than 255 UEs

Hi, I'm trying to connect many UEs using the load-test.
The free5GC v3.0.6 stops the Data Plane connection after about 10 devices.
The Open5GS v2.3.6 can connect exactly 255 UEs with the data plane before stops registering new devices.
I tried to update the free5GC to v3.2.1 (the latest stable version - I'm using this repository) and, after running the load-test with 1000 devices, it stopped connecting exactly after 255 successful connections, the same behavior as the Open5GS core.
Btw, the latest version of the free5GC WebUI allows us to insert a lot of IMSI at the same time.
Taking a look at the context.go file, I saw that you are using a uint8 variable to store the device ID on lines 34 and 50. Is it possible that this uint8 id could cause this weird behavior?
Also, I noticed that after near to 400 UEs, the tester crashes with a Broken pipe error in both cores.
Thanks :)

Hi, gabriel-lando!

I tried to update the free5GC to v3.2.1 (the latest stable version - I'm using this repository) and, after running the load-test with 1000 devices, it stopped connecting exactly after 255 successful connections, the same behavior as the Open5GS core.
Btw, the latest version of the free5GC WebUI allows us to insert a lot of IMSI at the same time.

Maybe you can share the logs of free5gc of AMF, SMF and UPF (latest stable version please) then I can investigate more deep the problem.

Also, I noticed that after near to 400 UEs, the tester crashes with a Broken pipe error in both cores.

Yes, I think it might be a problem with my5GRANTester as I haven't tested it with such a large number of UEs. The source of the problem, I think it could be this service.go file as well, maybe linux does not allow to create of  400 virtual interfaces for the 400 UEs, this explains the broken pipe error.

Hi baleeiro17, thanks for your answer :)
I'm using the code on the master branch (I changed this Dockerfile because of the code on the branch v1.0.0 crashes when I try to run the load-test with more than 1 UE during the creation of the data plane.
I'm using this startup string: ./app load-test -n 1000.
Follow the log for the execution using the free5GC v3.2.1 and the master branch of the tester.
Log: my5grantester-master_free5gc-v3.2.1.txt
On this execution, I could register and create the data plane for 255 devices, after that, I received a lot of errors and a few new UEs after, the tester crashed.
I'm running again the other tests (free5GC v3.0.6 and Open5GC) and I'll update this comment with the other logs as soon as I finish all executions.


Optimize code where necessary

I have to run some metrics on the code and optimize if necessary. I have to find the main bottlenecks.
The main targets of optimization are class extension, class instantiation, shallow and deep functions, etc... If it is easy to make them faster then I will do so, because this part of the framework affect every single class and object, so they have to be as fast as possible.
I have to find a way to emulate low speed tools, like mobile phones, etc... and check the speed on them. I have to determine the acceptable speeds as well.

I doubt there will be such bottlenecks, at least bottlenecks are usually related to resource usage and adapters which do that part will be in a different repo. I'll keep this open while I create that repo.


Make a single request for Google Fonts

Just noticed there were two HTTP requests when we can do it one :)

@brendo nice catch! 👍

I will release a new package tomorrow.

Sounds great, thank you!


Cannot call QueryInterface-like APIs with "NULL" for the ppv parameter

For example, many D3D12 APIs, such as D3D12CreateDevice, operate in a mode where the runtime validates parameters if NULL is passed for the ppv parameter.  Apps often use this to probe whether or not a particular adapter meets their needs, but without performing the heavy-weight, driver-loading, work required to construct and then destruct the object.
See for example https://github.com/microsoft/DirectX-Graphics-Samples/blob/cab614fc3b2ac880f1909c40a485423649940b0d/Samples/Desktop/D3D12HelloWorld/src/HelloWindow/DXSample.cpp#L97

I always forget about this case, sorry for not bringing it up earlier before #735 was completed.  I'd be interested what you think right bindings would look like to support this scenario - it's not obvious to me.

Yikes, I was not aware of this convention. Thanks for letting me know. I'll noodle on that.

In case anyone else encounters it, here is my workaround:
    // let mut adapter_: Option<IDXGIAdapter1> = ...

    // We need the variant where we pass in NULL for the outparam.
    #[link(name = "d3d12")]
    extern "system" {
        pub fn D3D12CreateDevice(
            padapter: ::windows::RawPtr,
            minimumfeaturelevel: D3D_FEATURE_LEVEL,
            riid: *const ::windows::Guid,
            ppdevice: *mut *mut ::std::ffi::c_void,
        ) -> ::windows::HRESULT;
    }

    // Check to see whether the adapter supports Direct3D 12, but
    // don't create the actual device yet.
    if D3D12CreateDevice(
        adapter.abi(),
        D3D_FEATURE_LEVEL::D3D_FEATURE_LEVEL_11_0,
        &ID3D12Device::IID,
        std::ptr::null_mut(),
    )
    .is_ok()
    {
        return Ok(adapter);
    }

As Rust doesn't support overloads, I'm thinking of adding an "overload" with a suffix like _query that simply provides the non-generic parameters. So you would be able to call the generic D3D12CreateDevice or the non-generic D3D12CreateDevice_query.

Bikeshed: maybe _validate for this case?
If we're willing to really special case this one, I think we'd still want the generic parameters, so I could write: D3D12CreateDevice_validate::<ID3D12Device2>(&adapter, D3D_FEATURE_LEVEL_11_0)
and avoid having to deal with IIDs.
One thing I'm not sure of is how universal this convention is.  QueryInterface, for example, does not behave this way.  We may be looking a another attribute for the metadata to identify functions following this pattern.

Yeah that's why I don't want to call it something specific like "validate" since that's DX-specific and there's no metadata to say that this is supported on any given API. I basically just want to have a fallback for non-generic/non-specialized call sites. I also plan to support things like retval so it may be useful to just have a non-specialized overload, perhaps _raw.

But if you want something more specific like the example above where there's an actual "validate" overload then you'll need to work with the win32metadata project to add such an attribute.

Although we don't have enough to know the "validate" versus "some other meaning for null" semantic, the metadata does already indicate that the ppv parameter is [Optional].  If we could come up with a generic word that means "don't return the interface" then maybe we already have enough?

Ah, I see CoCreateInstance and D2D1CreateDevice are not optional but D3D12CreateDevice is. That might work!


have infrastructure reviewed by security team

Contacted cloud support, waiting for feedback.

wont fixe because of #154


[ISSUE #3221]plugin snapshot api

about issue #3221
work list:

[x] add plugin snapshot api. it active plugin list

Codecov Report

Merging #3222 (b21521f) into master (2c428f0) will decrease coverage by 0.26%.
The diff coverage is 4.34%.

@@             Coverage Diff              @@
##             master    #3222      +/-   ##
============================================
- Coverage     57.57%   57.31%   -0.27%
+ Complexity     4544     4528      -16
============================================
  Files           730      731       +1
  Lines         20819    20834      +15
  Branches       1915     1913       -2
============================================
- Hits          11986    11940      -46
- Misses         7773     7833      +60
- Partials       1060     1061       +1

Impacted Files
Coverage Δ

...apache/shenyu/admin/model/vo/PluginSnapshotVO.java
0.00% <0.00%> (ø)

...org/apache/shenyu/admin/service/PluginService.java
100.00% <ø> (ø)

...e/shenyu/admin/service/impl/PluginServiceImpl.java
81.51% <0.00%> (-0.70%)
:arrow_down:

...ache/shenyu/admin/controller/PluginController.java
96.29% <50.00%> (-3.71%)
:arrow_down:

...admin/controller/ShenyuHttpRegistryController.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
50.00% <0.00%> (-12.86%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...in/disruptor/RegisterServerDisruptorPublisher.java
52.94% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-8.52%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c428f0...b21521f. Read the comment docs.


How to get the inside values of the python closure function def spatially_regular_gen() and def tf_map()?

Hi @HuguesTHOMAS
Thanks for sharing your code, which helped me a lot!
But I have some difficulties in understanding the data preparation details.
Could you tell me how to get the inside values of the python closure function def spatially_regular_gen() and def tf_map()?
It confused me for several days, hope you can help me with it!
Best regards!

Hi @Violetit,
Sorry for the late reply, spatially_regular_gen() function is a python generator so you should be able to use a simple python print to see the values in there. The tf_map() function is a Tensorflow function so it is part of the computational graph and you should use tf.print to see values in this function. Remember that the tf.map function is called in several threads by the input pipeline. The input value of this tf.map function ar the values yielded by the  spatially_regular_gen() generator.
I hope this helps. IF the Tensorflow input pipeline is too much of a trouble, you can always switch to the PyTorch version of the code. I implemented it especially for that reason.
Best,
Hugues


Calling Set Null no longer Compiles under NullAway

The following code no longer compiles:
Var<@Nullable String> var = Var.ofNullable(String.class, "Test");
var.set(null); // Does not compile
var.set(From.VIEW, null); // Also does not compile

We already encountered this problem in some form and I believe we
considered it a bug in the NullAway checker. Correct me if I am wrong but
it looks like NullAway can't handle generics properly...
It seems to be assuming that T is always non-null because the set methods do
no longer have explicit @Nullable annotations on specific parameters.
I believe this is supported by this issue: https://github.com/uber/NullAway/issues/83
For us, this is a bit of a problem in practice.
I tried to introduce the most recent sprouts changes in SwingTree
and encountered multiple compile errors.
It is possible to circumvent them using @SupressWarnings("NullAway")
in these few specific cases where a nullable object is passed to a set method...
...but I don't know if this is an acceptable approach for the Framework Tools.
On the other hand, introducing @Nullable would be a bit of a lie for most cases.
(Usually things don't need to be nullable, so why allow it?)

I found this in AbstractValue.java:27
    protected @Nullable T _value;

which is wrong. The nullability should already be encoded in T.
Maybe fixing this will solve your problem.
I will look into it.

I think we are doing it right and the problem is NullAway and I don't see a good solution to this problem :disappointed:
I think we should stick to JSpecify and if clients use a checker that does not implement JSpecify correctly, its the clients responsibility?
Maybe we could use the following workarounds in SwingTree / Framework Tools:
@SuppressWarnings("NullAway")
private static <T extends  @Nullable Object> Var<T> set(Var<T> var, @Nullable T value) {
    return var.set(value);
}

@SuppressWarnings("NullAway")
private static <T extends  @Nullable Object> Var<T> set(Var<T> var, From from, @Nullable T value) {
    return var.set(from, value);
}

I think we should stick to JSpecify and if clients use a checker that does not implement JSpecify correctly, its the clients responsibility?

I have been thinking about this a bit and also come to the same conclusion.
So I fully agree with keeping the sprouts API that way and then imposing the API
consumer to find a solution.
For now, I have used @SuppressWarnings("NullAway") everywhere directly in
SwingTree, but I like your proposal much more!
I guess for now we have to do it like that.


Sync installer charts

@ayj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mandiff_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mandiff_operator_release-1.4

lint_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test lint_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mandiff_operator_release-1.4

lint_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test lint_operator_release-1.4

mesh_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mesh_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mandiff_operator_release-1.4

lint_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test lint_operator_release-1.4

mesh_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mesh_operator_release-1.4

test_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test test_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test lint_operator_release-1.4

mesh_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test mesh_operator_release-1.4

test_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test test_operator_release-1.4

mandiff_operator_release-1.4
131f13e2194834a54980c69eb3e3c6876022dac2
link
/test mandiff_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator_release-1.4
4bae0538f8a0f1058162edf6271136aa8cddd958
link
/test lint_operator_release-1.4

mandiff_operator_release-1.4
131f13e2194834a54980c69eb3e3c6876022dac2
link
/test mandiff_operator_release-1.4

test_operator_release-1.4
131f13e2194834a54980c69eb3e3c6876022dac2
link
/test test_operator_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Done on https://github.com/istio/operator/pull/543


[FLINK-17941][sql-client] Switching catalog or database doesn't work …

…from SQL CLI

What is the purpose of the change
Fix the issue that users cannot switch catalog & database via SQL CLI.
Brief change log

Call executor.executeSql to process USE and USE CATALOG statements

Verifying this change
Manually verified since the E2E test cannot cover this case.
Does this pull request potentially affect one of the following parts:
N/A
Documentation
N/A

This has been addressed by #12431.


ROX-14619: fix metadata retrieval errors in scan time test

Manually cherry-picking d10b00fc6ac882d4a251bcaf1b625a1289fc31b0.

https://github.com/stackrox/stackrox/pull/4635
https://github.com/stackrox/stackrox/pull/4700

/retest


Fix bug relating to age_groups func

Issue is relating to the input for the function. Input needs to be converted to an array to be processed further.

Bug fixed in pull request https://github.com/lford93/se-summative-1/pull/30


Put package name in correct place in mix.exs

ExDoc couldn't find package name because it was specified under docs and not in the project function.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Code gardening: improved error messages

and you sneaked another fix in between

Hey, it's error-related :P


Duplicate testing - is Primary key considered?

I have a dataset republished at datahub.io. It has four fields that make up the primary key. These are not the first four fields in the table. When I test in GoodTables:

it detects duplicates (a fair enough guess)

it correctly ignores duplicates when I choose that option in the user interface

it detects duplicates when I use a json table schema without a primary key

it correctly ignores duplicates when I use a json table schema with a primary key and choose the ignore duplicates option in the user interface

it incorrectly detects duplicates when I use a json table schema with a primary key
"primaryKey": ["SITE_ID",  "MONTHS", "YEARS", "HOURS"]

Is the primary key in the schema considered when checking for duplicates?

Please use https://try.goodtables.io


Missing links on Fedora part

Hi, first off thanks for your awesome guide!
I notice the youtube video is missing on "fedora-btrfs", and the page "fedora-btrfs-raid1" is also missing.

Thanks for pointing this out, unfortunately, I did not have time to do such a video yet, so I updated the post.


[BEAM-13531] [Playground] Fetch example info (source, logs, outputs) only once

I added a check to prevent loading example info (source, logs, outputs) twice or more after switching to another one.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM thanks!


Tailwind prefix support for regenesis theme

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=Playground.vue&css-framework=genesis
Describe the bug
I have specified prefix in tailwind config as tw-
How to use regeneis theme (i.e. tailwind theme) with prefix option?
Currently when I ran npx formkit theme --theme=regenesis it generated the file, but the classes names are not prefixed with tw- hence they are not being generated.
Environment
• OS: Windows
• Browser: Edge
• Version: 1.5

Here too. We have a lot css classes from other locations and need to prefix our tailwind classes. The risk for override is high.

+1

My project uses UnoCSS, and I’m not sure how to configure it.

Currently I'm manually editing the formkit.theme.ts to add prefixes,


Package with project code is not added to PYTHONPATH if it is run from package

Thanks for a great project. I am currently testing the available ASGI servers and I found that granian behaves differently than other ASGI servers. I have no idea if this is correct because the directory structure of my application is a bit non-standard, but I'll describe it here anyway, maybe it will help someone.
My use-case is as follows: My project has the following stucture: C:\project_root\tests\django_test_application, where:

tests is a package (contains __init__.py)
django_test_application is also a package (contains __init__.py) and under that is asgi.py which I want to run
the code in django_test_application doesn't know that it is part of the tests package. So it uses the imports: from django_test_application.foo import bar.
From the C:\project_root\tests\ directory, I then run the individual ASGI servers and test if my application works correctly with them.

But under granian my application crashes on ModuleNotFoundError: no module named 'django_test_application'. I think it's because the prepare_import function (https://github.com/emmett-framework/granian/blob/master/granian/_internal.py#L13-L35) doesn't add django_test_application to PYTHONPATH when it's part of a package. I've prepared a minimal working project here that demonstrates the described problem: https://github.com/illagrenan/granian-app-in-package.
I tested uvicorn, hypercorn and daphne and they add the package django_test_application to PYTHONPATH.
A little background on why my project is structured this way: I'm writing a package that adds ASGI lifespan protocol support for Django. I'd like to have all the major ASGI servers running as part of the integration tests to make sure my code is compatible with all of them.

Hi @illagrenan, thank you for reporting this.
Would you be able to run Granian using the Python interface? If so, you can define a custom loader:
import importlib

def target_loader(target: str):
    mods, _, attrs = target.partition(":")
    instance = importlib.import_module(mods)
    for attr in attrs.split("."):
        instance = getattr(instance, attr)
    return instance

and pass it to the Granian.serve method.
I'm not able to test the upper code immediately: if you manage to, then I'll be happy to publish a patch revision of granian with the loader upgraded.

Sorry for the late reply. I can confirm that the latest version https://github.com/emmett-framework/granian/releases/tag/v1.1.1 works perfectly. 🚀  Thanks a lot for the great work!


Update test-file-03.md

@TinaLiuGirl : Thanks for your contribution to the Azure documentation! The author, @v-caxian, has been notified to review your proposed change.

#sign-off

@TinaLiuGirl: Only the author, @v-caxian, can sign off on this pull request.

@: Only the author, @v-caxian, can sign off on this pull request.


Manually stepping the simulation

Hi, please consider adding support for manual simulation stepping. It would be useful for faster-than-real-time simulations.
Currently, this can only be done in a hacky way with GUI and shared_memory modes:
pybullet.setRealTimeSimulation(0, physicsClientId=self._client)
...
pybullet.stepSimulation(physicsClientId=self._client)

Unfortunately DIRECT mode (which is the fastest one) does not allow for that trick as it always spawns a spinning thread for simulation stepping.

I agree, the user should be able to step manually in Direct mode (very useful to obtain deterministic behaviours). Some calls will have to be avoided while running qiBullet with the "DIRECT manual stepping" combo though, for instance a call to a synchronous moveTo.

This commit should allow you to manually step in DIRECT mode. It will be added to the qibullet package in the next release.
manager = SimulationManager()
client = manager.launchSimulation(gui=False, auto_step=False)
# stuff
manager.stepSimulation(client)
# more stuff
manager.stopSimulation(client)

Great news.
I would like to make a case for supporting manual stepping in GUI mode as well. In Reinforcement Learning (for which I use qibullet) it is desirable to visually examine learned policies by running them in the same way as during the training in DIRECT mode. That is, by manually stepping the simulation.

On 16 Nov 2020, at 19:49, Maxime Busy<EMAIL_ADDRESS>wrote:

This commit should allow you to manually step in DIRECT mode. It will be added to the qibullet package in the next release.
manager = SimulationManager()
client = manager.launchSimulation(gui=False, auto_step=False)
stuff
manager.stepSimulation(client)
more stuff
manager.stopSimulation(client)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Having that manual stepping in GUI mode could also be interesting (again especially for the purpose of being deterministic), I don't know if I'll add it to the simulation before the release of the 1.4.3 though (if you want to submit a PR adding it to qiBullet I'll review it). If manual stepping is allowed in GUI mode, it should also be allowed when using shared memory (here).
To circle back to your original comment, bear in mind that using "faster-than-real-time" simulation instances might give you weird physics behaviours (depending on the content of your environment, your simulation parameters etc). If your goal is to transfer your learnt policies on a real robot, that would render them pretty much useless. If you stay in simulation though (with the same parameters) it will work

#51


[CI] Fix label analysis using GH

What does this PR do?
It fixes the label analysis workflow not being able to get the actualized list of labels of a PR, preventing the devs from getting a green retry.

Motivation
Explanation:
In the workflow we're using github.event.pull_request.labels.*.name to get the PR's labels.
From Github doc, the github.event.pull_request.* variables are set when the workflow is triggered. This workflow triggers are:
on:
  pull_request:
    types: [opened, synchronize, reopened]

This means if someone changes the label and rerun the workflow it won't refresh the github.event.pull_request.labels.*.name unless the PR gets open (opened), a commit is pushed (synchronize) or the PR is closed and reopen (reopened).
Best solution would have been to use the labeled type for the workflow, but we have constraints:
Constraints:

The Merge Queue prevents us from using the labeled type for the workflow, else it'll create a race condition.
The developers should be able to rerun the workflow at anytime to check if they have the right labels.

This leaves us with only one solution: use Github API directly (here gh).

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I think Nicolas initially made the change to reduce the number of API requests we issue

Yes because we were being rate limited. This was because the workflow was not authenticated so we only had 60 requests/h per repo. That's why I set the GH_TOKEN env var I defined should allow us not being rate limited anymore (it's now 15000 req/h).

Oh damn I thought we were reaching the 15000/h request already and was worried about adding any new ones but if the threshold we reached war 60/h I can rest easy :joy:
Then by all mean keep both jobs :sweat_smile:

Might be a thousand instead, let's play it safe, I'll make a commit to run the request once only

/merge


added:: Meta Tags, Generate Sitemap, and Create robots.txt for SEO Improvement

Issue #12

hello bro the sitemap.xml and robots.txt is changing on build why ?

hello bro the sitemap.xml and robots.txt is changing on build why ?

sitemap.xml and robots.txt can change during builds because they are often dynamically generated based on your routes or content.

okay got it


execute-job/comment-from-wrong-user-on-pr/4c78fd95-eb5f-4d09-9586-abcf5907920d

PR for testing 811f3cc0d363f0cd2e83a4e075d932d6fd882b4f

/canonical/self-hosted-runners/run-workflows 811f3cc0d363f0cd2e83a4e075d932d6fd882b4f


Add line highlight on code blocks

Examples:
https://github.com/filoxo/blog/commit/3862bb4f5f5d4ebfafa3f773b7c1687fc8ca5bea
https://prince.dev/highlight-with-react
https://www.lekoarts.de/en/blog/adding-line-numbers-and-code-highlighting-to-mdx-code-blocks

note to myself 😅
the implementation of the code highlighting, will use meta string from mdx code blocks, see example below:
  ```js {1,6,9-10}


running the started guide,network didn't work and seconds exit in ubuntu 16.10

i am a newbie of rkt and i do testing follow this document:
https://coreos.com/rkt/docs/latest/getting-started-guide.html
but in first step,i meet the strange wrong,these are the details of my terminal:
image: using image from file /usr/lib/rkt/stage1-host.aci
image: using image from file hello-0.0.1-linux-amd64.aci
networking: loading networks from /etc/rkt/net.d
networking: loading network default with type ptp

UUID		APP	IMAGE NAME		STATE	CREATED		STARTED		NETWORKS
f909cf96	hello	example.com/hello:0.0.1	exited	4 seconds ago	3 seconds ago

root@xxxxxx:/home/xxxxxx/workspace/rkt# ll /etc/rkt
总用量 16
drwxr-xr-x   2 root root  4096 4月   2 02:42 ./
drwxr-xr-x 145 root root 12288 4月   2 02:29 ../

why is the /etc/rkt/net.d empty?

It's expected for the net.d configuration directory to be empty if you haven't populated it.
The default network should still work just fine in that case.
To help us figure out why it didn't work, please provide more information such as your distro, the rkt version, the rkt command you ran, etc.
One possibility is that your distro doesn't have a compatible selinux policy (e.g. fedora, see here), but there's really not enough information to tell.

you mean that net's config will not auto create,i should populated it by myself then it can work.my rsk's version is the latest one.the commands all i run follow that doc.

It's not that the networking file will be autocreated or that you need to create it. The default network works without needing any configuration and without creating one.
I suspect that the networking thing is a red-herring.
I followed exactly the commands in the getting-started guide on a fresh ubuntu 16.10 VM, after installing rkt, acbuild, and go, and everything worked as expected for me.
I noticed that your post includes the line image: using image from file /usr/lib/rkt/stage1-host.aci
If you install the .deb provided on the release page, it should default to stage1-coreos, not stage1-host.
How'd you install your version of rkt?
What exactly is the command you're running? If you run rkt run --insecure-options=image --debug docker://hello-world, what does it print?

i use this cmd "apt-get install rkt" to install rkt.Do you also use it?

i use this cmd "apt-get install rkt" to install rkt.

On 16.10 that installs version 1.5.1. The latest version is 1.25.0 and the installation guide points to the deb the project releases (see here).
Next time, follow the issue template so it's immediately apparent that you're using a very old version of rkt.
That being said, since hello-world ran correctly, it seems likely that the problem is with the aci you built. I recommend updating rkt as well, but it seems very likely to me that the aci image is not of a static binary.
This section of the instructions mention how to do that. Does ldd hello have the mentioned "not a dynamic executable" output?

ldd is output normal dependence of the cmd.my rsk's version is 1.5.1,is it not the latest one?

@ljohnny the getting started guide explicitly mentions that the binary built for it must be statically linked (specifically that ldd should say not a dynamic executable). I also said that no, the latest version is 1.25.0, not 1.5.0, again per my previous comment.

you are right.i run separately with CGO_ENABLED=0 go build -ldflags '-extldflags "-static"',sry


force layout implementation

Unable to get the d3 force layout to work with r2d3, details asked n stack overflow:
http://stackoverflow.com/questions/12785324/getting-d3-js-to-work-with-raphael-js

Hi there,
This project is no longer being maintained so this issue is being closed. Thank you for using r2d3 and taking the time to report this issue.


Add corsPolicy for kc service

Description
Changes proposed in this pull request:

Add corsPolicy to virtual service of kubeconfig service

Related issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


PDP- Share Social Media Platforms- Copy Link

Share section – Facebook, Instagram, Pinterest, & Copy Link button. Clicking on each social media icon should open the appropriate site. Clicking on the copy link allows user to copy the URL to share.
Expected Result
It should say its copied to the clipboard

Actual Result
However when I click on it it only darkens to burgundy and doesn't copy to the clipboard

@monicakarnes confirming Jen Wise is addressing this functionality with the dev and will oversee the styling before we resubmit updated pr.

and looks like it copies it for me, as when I paste I get this.
https://tastefully-simple-sandbox-2.mybigcommerce.com/test-product/
closing bug thanks!


Status field on entities should be enum

Should we use an Enum here?
Originally posted by @rtio in https://github.com/kdti/kdti-server/pull/14

@rtio Is there a common way to use enums with Doctrine?


⚠ ClamAV has degraded performance

In d45a23b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: ClamAV performance has improved in ded9e8e.