TestScratchDir.test_touch[*] fails on FreeBSD

==================================================================== FAILURES =====================================================================
_________________________________________________________ TestScratchDir.test_touch[Path] _________________________________________________________

self = <test_path.TestScratchDir object at 0x807069e80>
tmpdir = local('/var/tmp/portage/dev-python/path-py-10.3.1/temp/pytest-of-portage/pytest-3/test_touch_Path_1')

    def test_touch(self, tmpdir):
        # NOTE: This test takes a long time to run (~10 seconds).
        # It sleeps several seconds because on Windows, the resolution
        # of a file's mtime and ctime is about 2 seconds.
        #
        # atime isn't tested because on Windows the resolution of atime
        # is something like 24 hours.

        threshold = 1

        d = Path(tmpdir)
        f = d / 'test.txt'
        t0 = time.time() - threshold
        f.touch()
        t1 = time.time() + threshold

        assert f.exists()
        assert f.isfile()
        assert f.size == 0
        assert t0 <= f.mtime <= t1
        if hasattr(os.path, 'getctime'):
            ct = f.ctime
            assert t0 <= ct <= t1

        time.sleep(threshold*2)
        fobj = open(f, 'ab')
        fobj.write('some bytes'.encode('utf-8'))
        fobj.close()

        time.sleep(threshold*2)
        t2 = time.time() - threshold
        f.touch()
        t3 = time.time() + threshold

        assert t0 <= t1 < t2 <= t3  # sanity check

        assert f.exists()
        assert f.isfile()
        assert f.size == 10
        assert t2 <= f.mtime <= t3
        if hasattr(os.path, 'getctime'):
            ct2 = f.ctime
            if os.name == 'nt':
                # On Windows, "ctime" is CREATION time
                assert ct == ct2
                assert ct2 < t2
            else:
                # On other systems, it might be the CHANGE time
                # (especially on Unix, time of inode changes)
>               assert ct == ct2 or ct2 == f.mtime
E               AssertionError: assert<PHONE_NUMBER>.72502 ==<PHONE_NUMBER>.917741 or<PHONE_NUMBER>.917741 ==<PHONE_NUMBER>.917714)
E                +  where<PHONE_NUMBER>.917714 = Path('/var/tmp/portage/dev-python/path-py-10.3.1/temp/pytest-of-portage/pytest-3/test_touch_Path_1/test.txt').mtime

test_path.py:321: AssertionError
_______________________________________________________ TestScratchDir.test_touch[FastPath] _______________________________________________________

self = <test_path.TestScratchDir object at 0x8071716a0>
tmpdir = local('/var/tmp/portage/dev-python/path-py-10.3.1/temp/pytest-of-portage/pytest-3/test_touch_FastPath_1')

    def test_touch(self, tmpdir):
        # NOTE: This test takes a long time to run (~10 seconds).
        # It sleeps several seconds because on Windows, the resolution
        # of a file's mtime and ctime is about 2 seconds.
        #
        # atime isn't tested because on Windows the resolution of atime
        # is something like 24 hours.

        threshold = 1

        d = Path(tmpdir)
        f = d / 'test.txt'
        t0 = time.time() - threshold
        f.touch()
        t1 = time.time() + threshold

        assert f.exists()
        assert f.isfile()
        assert f.size == 0
        assert t0 <= f.mtime <= t1
        if hasattr(os.path, 'getctime'):
            ct = f.ctime
            assert t0 <= ct <= t1

        time.sleep(threshold*2)
        fobj = open(f, 'ab')
        fobj.write('some bytes'.encode('utf-8'))
        fobj.close()

        time.sleep(threshold*2)
        t2 = time.time() - threshold
        f.touch()
        t3 = time.time() + threshold

        assert t0 <= t1 < t2 <= t3  # sanity check

        assert f.exists()
        assert f.isfile()
        assert f.size == 10
        assert t2 <= f.mtime <= t3
        if hasattr(os.path, 'getctime'):
            ct2 = f.ctime
            if os.name == 'nt':
                # On Windows, "ctime" is CREATION time
                assert ct == ct2
                assert ct2 < t2
            else:
                # On other systems, it might be the CHANGE time
                # (especially on Unix, time of inode changes)
>               assert ct == ct2 or ct2 == f.mtime
E               AssertionError: assert<PHONE_NUMBER>.975006 ==<PHONE_NUMBER>.010455 or<PHONE_NUMBER>.010455 ==<PHONE_NUMBER>.010384)
E                +  where<PHONE_NUMBER>.010384 = FastPath('/var/tmp/portage/dev-python/path-py-10.3.1/temp/pytest-of-portage/pytest-3/test_touch_FastPath_1/test.txt').mtime

test_path.py:321: AssertionError

Well that's annoying. It doesn't fail on macOS (also BSD-based). There are probably other factors at play.
Would you be willing to investigate and characterize the cause of the failure and possibly suggest a more accurate test?

I would love to help but my plate is a big full right now. Could you give me some tips on what could I investigate? I have to say I find it hard to figure out what the assertion is supposed to mean.

Ok, I've added printing of various time in important points of the test (after first touch(), after writing, after second touch()), and that are the results:
{'atime':<PHONE_NUMBER>.028664, 'ctime':<PHONE_NUMBER>.028682, 'mtime':<PHONE_NUMBER>.028664, 'birthtime':<PHONE_NUMBER>.02862}
{'atime':<PHONE_NUMBER>.028664, 'ctime':<PHONE_NUMBER>.154694, 'mtime':<PHONE_NUMBER>.154694, 'birthtime':<PHONE_NUMBER>.02862}
{'atime':<PHONE_NUMBER>.165809, 'ctime':<PHONE_NUMBER>.165836, 'mtime':<PHONE_NUMBER>.165809, 'birthtime':<PHONE_NUMBER>.02862}

So, I think the assumption that fails here is that utime() with NULL argument sets the same value on all modified timestamps. However, apparently it sets them to the different values of 'now' in sequence.

This issue may in fact apply to MacOS as well, and may have emerged with recent builds of BSD as it emerged with recent releases of MacOS as seen in #132.


fix(ccf): webCompat update

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL:  https://app.asana.com/0/0/1204954313721678/f
iOS PR:
macOS PR: https://app.asana.com/0/0/1204954313721679/f
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Just bumping CCF for https://github.com/duckduckgo/macos-browser/pull/1327

Steps to test this PR:
1.
1.

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Current dependencies on/for this PR:

main

PR #402   👈

This comment was auto-generated by Graphite.

It looks good from my side.   We have a couple of tests failing though.  Looks like its CI failing?

@afterxleep those have been failing consistently lately I think - I'll check with @ayoy later before we merge


Add compilation tests to test driver

PR #47 revealed how it is easy to accidentally let a major bug split through because all compilation args are not tested. This needs s be remedied automatically by the new test suite being built.

should test mutliple compilers (clang and gcc) as well as multiple linkers (ld, gold, lld, mold)


refactor(RingTheory): generalize cotangent complex for arbitrary extensions

Though the diff is quite large, the Extension file is basically a copy of the original Generators file.

Thanks :tada:
bors merge


Can you show a sample of that using IBOutlets?

Please, I try use your approach with outlets and didn't works.

@RafaelPlantard You mean you created @IBOutlets of the Buttons on the main screen?

I mean @IBOutlets at first and second view controllers.

I am closing this issue. As it was some error from your end.


EPIC: Player mechanics Part2: Twig controls

Twig follows the player and can be used to fend off creatures, help solve puzzles and of course be petted! Very important that the player can pet him!

[ ] Follows Player #16
[ ] Stay #18
[ ] Come #19
[ ] Attack #20 #21
[ ] Defend #22
[ ] Go to area of interest (maybe) #23
[ ] Pet! (Very important) #24

[ ] Handle falling off the map


Neurad-Sim Release?

Hi authors,
Thanks for the great work. During the poster session, one of you said you would be releasing the simulator in the next one or two months. Do you have any estimated time on when you would release the full close loop simulator?

Thank you for the answer. I'll follow the NeuroNCAP repo.


❓ Understanding smoothed CrossEntropyLoss

❓ Questions and Help
I'm trying to understand the label-smoothed cross-entropy loss of Fairseq :
https://github.com/pytorch/fairseq/blob/d2b5265a60c4016d9fc3cbd55ad983dd86f1aa6f/fairseq/criterions/label_smoothed_cross_entropy.py#L12-L29
I compare the output of this loss with the output of TF2 smoothed cross-entropy loss (CategoricalCrossentropy) in this Colab notebook, but the results are differents...
Anyone know why ?

Did you use the same epsilon values?

Yes I same input and same parameters for both, as shown in the Colab notebook.
I don't think I did any mistake. I'm looking for a TF equivalent of the fairseq loss.

I found my mistake : I was comparing CrossEntropyLoss with NLLLoss...
Also, loss is summed in Fairseq.
By adding a log_softmax, it solves the problem.
Here is the Colab notebook with the fixed code.


Bug: Allow or Somehow Handle Recursion - Potential Data Loss

What you did:
collection|person|:insert[
  m{s|name|:s|Foo|},
  m{s|name|:s|Bar|}
]

Let's say these were generated with the ids:
Foo: f35dbd14-65e5-482f-a6e3-82c18b1aaaa7
Bar: b70fd0a3-a780-4b0c-a095-c832b4261809
I then inversely connected them together so that I could see that they were mutual friends
collection|person|:q[get[person|f35dbd14-65e5-482f-a6e3-82c18b1aaaa7|],update[set{value|friends|:v[person|b70fd0a3-a780-4b0c-a095-c832b4261809|]}]]
collection|person|:q[get[person|b70fd0a3-a780-4b0c-a095-c832b4261809|],update[set{value|friends|:v[person|f35dbd14-65e5-482f-a6e3-82c18b1aaaa7|]}]]

The updates were successfully applied, but then I tried to query them:
collection|person|:get[
  person|f35dbd14-65e5-482f-a6e3-82c18b1aaaa7|,
  person|b70fd0a3-a780-4b0c-a095-c832b4261809|
]

What Happened
But this created an error: Fetch recursion error

If I didn't know what to update to remove the recursion, I would have no way to research it. I can no longer query these nodes, and I would might as well delete them and start over.
Ideas:
I think loops should be allowable. I was thinking about this, and think the better way to handle it would be depth limiting. And why I think loops would be a good thing is when you get into graphs (looking at your roadmap) you will want to be able to traverse a graph up and down.

And fyi, I cannot even delete these nodes now


Decide how to model dividend options

according to discussion here: https://github.com/digital-asset/daml-finance/pull/501

Also consider whether it is possible to support a "default election"

When documenting this, include how an investor can choose several options (by splitting the holding?).

By default, this would result in fractional shares.

If we use contingent claims, we should probably use a European decision rule, since this matches the actual economics of the instrument. There is a similar discussion with subscription rights: https://github.com/digital-asset/daml-finance/issues/597

2. If div options are modelled using contingent claims: we probably need this: Implement rounding in contingent claims #653

Correction: this rounding would be in the claim rule, because only there the holding amount is known.


python312Packages.appthreat-vulnerability-db: 5.6.4 -> 5.6.6,  dep-scan: 5.2.12 -> 5.2.14

Diff: https://github.com/AppThreat/vulnerability-db/compare/refs/tags/v5.6.4...v5.6.6
Changelog: https://github.com/AppThreat/vulnerability-db/releases/tag/v5.6.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 300196 run on x86_64-linux 1

8 packages built:

appthreat-depscan
appthreat-depscan.dist
dep-scan
dep-scan.dist
python311Packages.appthreat-vulnerability-db
python311Packages.appthreat-vulnerability-db.dist
python312Packages.appthreat-vulnerability-db
python312Packages.appthreat-vulnerability-db.dist


Add CI test for connection with insecure broker, with library installed as dependency

Add an automated test in CI for connection and operation with an insecure broker, and with the library installed as a dependency, so that package-lock.json is disrespected.
This emulates a downstream user's environment.

I'm not going to do this. The grpc lib dependency is pinned. So when we update it, I will ask the Modeler team to test at their end.


Fix #4998 - Change lifetime of ViewComponentResultExecutor

This service has a scoped dependency so it should be scoped or transient.
This is a minimal fix for the 1.0.1 release. The actual fix will go into dev and will include adding functional test verification of our service lifetimes.

/cc @pranavkm

:shipit:


[Feature request] Open multiple specific tabs at startup

Continuance of kiwibrowser/android#180.
@mcarans Please subscribe to this issue for further updates.

Thx @KaKi87


Update _index.md

Clarify that a runtime license per environment is required. Customers tend to think that a runtime license per app is needed, while an app has several environments and each environment needs one.

Edited and reached out to the PC team for approval.


Cannot run after upgrade

Cannot run the project after upgrage my flutter! getting below error:(
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel unknown, v1.8.1, on Mac OS X 10.14.5 18F132, locale en-MY)
⣻ideviceinfo returned an error:
ERROR: Could not connect to lockdownd, error code -2

Does it work to unpair and re-pair the device?
Xcode > Window > Devices and Simulators > Ctrl-click device > Unpair Device
To re-pair:
Unplug and re-plug in device.  On device, hit the Trust button.

Tried lot of stuffs, meaning to say close and opened not working, Invalidate and caches/Restarted not working, then finally I just downgraded my update then it seems fine now! Thanks @jmagman  for your reply!


Kotlin 1.9 support

It seems like it does not work with Kotlin 1.9. I also tried explicitly using classpath("com.android.tools.metalava:metalava:1.0.0-alpha08") but I think they made a change which requires you to update the way you use their API.
See here: https://github.com/vanniktech/multiplatform-locale/pull/103/commits/9396c2a492b11baf24f319780f2fa3c30c9ef2ef - it can't resolve types any more with Kotlin 1.9 when running the metalavaGenerateSignatureDebug task.

I'm getting similar errors with error.NonExistentClass

Just pushed an update to use 1.9.10. Tested it on the kotlin-1.9 branch in https://github.com/vanniktech/multiplatform-locale as well. 0.3.4 should be published shortly!

There was an issue with the release. Looking into it.


How to initiate Onboarding without the context

I'm changing my code to use get as the navigation manager and screen controller and I'm looking for your suggestion, @talamaska on how is the best way to use your package.
Today, to open the onboarding sequence, i'm using Onboarding.of(context)!.show(); inside of WidgetsBinding.instance!.addPostFrameCallback((_) in the initState of a Stateful widget.
Using the GetxController to handle the functions part of my screen, I won't be able to have this context to call the onboarding.
I don't know if you already used this package and have a solution for this. If you need a sample code, I can generate one.

I'm not really sure how to do that without a context. I'd normally need the context for getting an overlay instance. If i figure out a way to do that without a context I could proceed exposing some  features to an OnboardingController. For I'm not aware a good way to do it. I'm open to suggestions and also would look at a possible PR.

I've solved the problem by passing the context when the controller is initialized:
class SecondController extends GetxController {
  SecondController({required this.contexto});
  final BuildContext contexto;

  void start() {
    Onboarding.of(contexto)?.show();
  }

  @override
  void onInit() {
    super.onInit();
    WidgetsBinding.instance!.addPostFrameCallback((_) async {
      start();
    });
  }
}

class Second extends StatelessWidget {
  const Second({Key? key, required this.focus}) : super(key: key);
  final List<FocusNode> focus;

  @override
  Widget build(BuildContext context) {
    final SecondController _editController = Get.put(SecondController(contexto: context));

    ....

Sharing the full code if someone needs it on the future
onb.zip
You can close this issue if you want, @talamaska

I will rename the issue to "Using Onboarding overlay with GetX" if someone else search for a receipt.


shannon feedback

buttons that say rules, sign up feel far apart
bricks feel to squatty (more padding on taller screens)
keeping width consistent
name starts on circle then sticks at mid point
make input go until button


Make the scripts in scorePages faster.

Right now 'scoreDocs' and  'runScript' are taking around 13 seconds and 24 seconds.

I think this has to be prioritized before other enhancements.

Absolutely! For a start, the wikiwoods.dm file should just be loaded once. At the moment, it gets loaded every time findBestPear is called -- and even worse, every time a pear is looked at in scorePages (so 3 more times). On my machine, it takes around 2s to load, so that's already 8s gone... :(

@minimalparts the wikiwoods.dm is created manually (using some tool) right?, what is your opinion about converting it into an sqlite table and querying it?

Yes, absolutely!

Same issue with the doc.dists files. See for example http://aurelieherbelot.net/pears-demo/pearone/doc.dists.txt. But I have no idea... can we also convert those to sqlite  and have them downloadable from a website?

Actually, I'm talking rubbish, wikiwoods.dm is only called once in scorePages, but that's also totally unnecessary, because it recalculates the distribution of the query, which has already been done in findBestPears.  Who wrote this thing? ;-)
I guess what we want is: load wikiwoods.dm when launching the application. Calculate the query's distribution (mkQueryDist) once, in findBestPears, and load the doc.dists files in scorePages.

PR #22 introduces an sqlite  database for wikiwoods.  lets see how this goes


The 'find and replace' result screen should have more features

After search when the result are shown, there should either be a checkbox for each result so you can pick which result you want to replace, or the user should be able to quickly replace each result so he doesn't have to go to each single result and manually replace the text. Either a right-click command on the result itself, or a little button next to the gutter for each result which replaces and lets you regret it.
It's really annoying when you have to replace something which occurs 99 times, but you want to replace only 75 of them.

:+1:
Something like that would be a dream

:+1:

+1

👎


Yatin: Watch ketoadvanced1500.splashthat.com

Yatin requests the watch of the watch_keyword ketoadvanced1500\.splashthat\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ketoadvanced1500\.splashthat\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Ryan M in Charcoal HQ


jupiter integration

clean up some dependencies but there are still a few problems

[ ] how to read and decode the woo oracle. this is important for not hardcoding the data on top.

clean up some dependencies but there are still a few problems

[ ]  how to read and decode the woo oracle. this is important for not hardcoding the data on top.

woo oracle decode as following:
    let token_a_wooracle = pubkey!("B9Rt3AEvFyha1CwdKbMGCacavHSoP81VTJhtdRqb518");
    let token_a_wooracle_data = client.get_account(&token_a_wooracle).await?;
    let token_a_wooracle = & Wooracle::try_deserialize(token_a_wooracle_data)?;
    let token_a_feed_account = token_a_wooracle.feed_account;
    let token_a_price_update = token_a_wooracle.price_update;

but previously token_a_wooracle is getting from following:
    let token_a_wooracle = get_wooracle_address(&wooconfig, &token_a_mint, &token_a_feed_account, &token_a_price_update, &program_id).0;

Please help verify what's the best way to handle this


Empty output file

Good afternoon,
When I try to generate musics, the output area in the webui is all gray with a download button (but no play button or anything else).

When I download the file using this button a 0kB mp4 file is downloaded. Of course i can't open it. Is it a known issue or something to fix it ?
output.zip
Thanks in advance for your help
Bests

You can try and use the demo here it works fine for me

Empty output file usually means you have not installed ffmpeg.

Thanks for your help !


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   93.93%   93.93%
=======================================
  Files           1        1
  Lines          33       33
=======================================
  Hits           31       31
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5943a4...f3017fa. Read the comment docs.

Coverage remained the same at 91.489% when pulling f3017fad85793b4e83b735e82a8e1941e1decd4a on template-sync-1 into a5943a45db47ab00bd053a7e34cdc874aff9c5ec on master.


Add Rust version requirements to the README

I have CI set up for many of my crates, and it broke when I updated some dependencies, because rust-fragile was included. The Rust version I use is too old, but finding the minimum supported version wasn't as quick as just reading the README here. I've seen this done for other crates and I think it'd be very helpful if it was documented here as well.

I thought it was 1.22 with the errors that I saw, but it looks to be 1.26.

Added


Suppress "No configuration found" error message

I constantly get this when opening a file. When there is no configuration, maybe we should just swallow the error and provide no linting at all.

This got fixed today already.


Develop a REST API to Delete a Product

As a user
I need a way to  delete a product
So that users can remove products from the system when necessary.
Details and Assumptions

The REST API should follow RESTful principles and utilize the DELETE HTTP method
The url should be /products/{product_id}

Acceptance Criteria
Given a valid product ID
When a DELETE request is made to the API endpoint for deleting a product
Then the API should delete the product associated with the given ID from the database and the
API should return a successful response with an appropriate message indicating the
successful deletion of the product

Currently, test using green will fail since API "read a product" is not completed.

I will double check again after "read a product" API is completed, if not working then, I will fix it


Can O' Spam: Watch KetovexKetoGummiesUS(?#facebook.com)

Can O' Spam requests the watch of the watch_keyword KetovexKetoGummiesUS(?#facebook.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

KetovexKetoGummiesUS(?#facebook.com) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by cigien in Charcoal HQ. Reason: 'watched a more general version'


Validate translation inputs

When we implement a proper recursive verifier of Goblin proofs, we must be sure to properly link the translation evaluations to values in the transcript.

Closed by https://github.com/AztecProtocol/aztec-packages/pull/3433


Looping Music on Android target is not seamless.

I am noticing that looping of ogg files are not seamless… I have a few 30 second or so music files that are seamlessly looped. They play back fine on flash and ios, but on android they seem to loop about a half-beat too soon, as in the last eighth of a second or so is chopped off.

This must be an issue with the Android OpenAL implementation, not sure I have an easy fix for this at our level. Perhaps we could keep an eye on the OpenAL ports for Android to see if there's a fix there. Thank you :smile:


Better integration with Tasmota features

Using the driver with a TMP117 sensor, I observed how the driver did not support features TempOffset, TempRes and SetOption8 (fahrenheit). Added this support, including allowing changes while running. Also made a couple of tweaks to take advantage of newer Tasmota features.
Another reason to avoid the global SENSOR_ADDR is that this could clash with other drivers using the same name. While this could have been handled prefixing the name of the global variable, the new feature of static variables is very nice for such fixed setup. Also made the temperature translation static, observed how the existing driver used the name "Temperatur", which fits some languages only :-)

Your changes look great, but i have a little problem. My Tasmota (official build: (Tasmota Version | 10.1.0(tasmota)) create cyclic exceptions.
BRY: Exception> 'attribute_error' - class 'TMP117' has no method 'temp_format'
stack traceback:
	<unknown source>: in function `event`

Did i need to start the driver in a special  way or link additional modules?
I start the driver with 'load("tmp117.be")'
First messages after startup:
load("tmp117.be")
I2C: TMP117 detected on bus 1
TMP117 TempRes:2 TempOffset:0 Fahrenheit:false
true
TMP117 TempRes:1 TempOffset:0 Fahrenheit:false
BRY: Exception> 'attribute_error' - class 'TMP117' has no method 'temp_format'
stack traceback:
	<unknown source>: in function `event`
TMP117 TempRes:1 TempOffset:0 Fahrenheit:false
BRY: Exception> 'attribute_error' - class 'TMP117' has no method 'temp_format'
stack traceback:
	<unknown source>: in function `event`
BRY: Exception> 'attribute_error' - class 'TMP117' has no method 'temp_format'

Should work better now, at least with current release version. I was not sure whether to leave the debugging message printed when the temperature formatting function is recreated, but saw no harm in such a low number of chatter.

With the new changes the driver work fine. Great work ;)


force conversion to UTF-8

OK. Thanks  @michaelshobbs. Could you add some tests?

My ruby skills are shoddy at best. If you want to point me in the right direction, I'm willing to take a stab at it though.
As a side note, I confirmed that this works in my OpsWorks situation.

OK. Don't worry.
Currently I'm not using SNS. Could you check whether SNS (mail?) messages are sent in UTF-8?

Looking at the headers I see this:
Content-Type: text/plain; charset=UTF-8

Thoughts on where to go from here?

Sorry @michaelshobbs. I want to merge this PR. But I want to add some tests before. Give me a couple of days.

no worries. i appreciate you looking at it for sure.

Hello @michaelshobbs,
I merged this in 712a5bc15aad45cfce2c11264ae43820b219bc4c. Then I improved it in e36a38ba22934db54d831a30c7197f71870d4a05, including some tests.
I just want to clarify that this fix works only for Ruby >= 2.1.0. Let me know if that is not enough.

Sounds good. I'll test it out ASAP

It looks like OpsWorks is using Ruby 2.0.0.
http://docs.aws.amazon.com/opsworks/latest/userguide/workingcookbook-ruby.html
root@host:/var/lib/aws/opsworks/chef# /opt/aws/opsworks/local/bin/ruby --version
ruby 2.0.0p645 (2015-04-13 revision 50299) [x86_64-linux]

Any way we can get support for that?

@michaelshobbs, thanks for your fast feedback :wink:
Fixed for Ruby >= 1.9.2 in 61e7b60a34e9968fdbc46b5c52887c458913eb2a.

Excellent! Is this in a release yet? If not I think I can just copy the new sns.rb into place over a chef-handler-sns-1.2.0 install, correct?

It's not released yet. But yes, you can test it by copying the sns.rb file.

Released in 2.0.0.


Fix Tag edit command with UUID copy

Update tests and command to ensure UUID has no change when updating a tag.

For rationale, see #74

Pull Request Test Coverage Report for Build 170

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 87.946%

Totals

Change from base Build 167:
0.007%

Covered Lines:
1627

Relevant Lines:
1850

💛  - Coveralls


Apply module/shared context inclusion to individual examples

This is an idea I'm toying with.  I lean towards including it but I'm not totally sold on the idea yet.

The problem
We have two different mechanisms for defining metadata-filtered shared context. On the configuration object:
RSpec.configure do |config|
  config.around(:example, :db_1) { |ex| DB.transaction(:always_rollback => true, &ex) }
end

...and as a shared context:
RSpec.shared_context "with a DB transaction", :db_2 do
  around(:example) { |ex| DB.transaction(:always_rollback => true, &ex) }
end

The latter is generally more useful because shared_context supports all rspec-core constructs, including let, helper methods, etc...where as the config object only provides the means to define hooks that way.  So I'd consider the latter form to be generally "better" but it has a downside:
RSpec.describe "Group with both approaches applied", :db_1, :db_2 do
  # examples
end

RSpec.describe "Group with an example that has both approaches applied" do
  it "does stuff", :db_1, :db_2 do
  end
end

Both forms work fine in the first example (where the metadata has been applied to the group), but only the config-based approach (:db_1) works in the second example.  The problem is that the shared_context is included (or not) in example groups, not individual examples, whereas the config can apply just fine.  A user might reasonably expect the 2nd example to work, but as things currently stand, it won't.  I myself have run into this a few times, where I had something that I had defined as a shared_context but thought I had defined on config, and I tagged an example and it didn't work.
Solution
I realized recently that ruby's object model (particularly the singleton_class) provides a means to very simply address this issue: we can include modules/shared contexts directly in the singleton class of the example group instance owned by an individual example.  This allows the contents of the module or shared context to apply to one example, but not others in the group.  I'm pleased with how simple the implementation was.
However, I'm not 100% sold on this, for a few reasons:

It's potentially surprising behavior for people that have a good mental model of example groups vs examples...those users probably wouldn't expect this to work.
It feels a little bit "magical" (even though in practice, it's actually really simple and is just leveraging ruby's object model).
It adds some additional processing to each example when it runs, potentially making RSpec a bit slower.
Including a module in an object's singleton class at run time busts the method cache, potentially having an even bigger affect on perf.  (However, every time rspec-mocks features are used, the method cache gets busted since it has to do similar things all the time).
There's some slightly odd semantics with before(:context)/after(:context) hooks that are defined in the shared context.  As currently implemented, when the context is applied to one example, these do not run.  However, they potentially setup and teardown some state that other parts of the context (such as an around hook) use, so not running them could cause problems.  I'm on the fence about whether or not they should be run.
This could be a breaking change for some folks. Although, I would not consider it a SemVer violation.
It's potentially confusing that config.extend modules aren't treated the same way.  I didn't think it made sense to apply those modules the same, since they generally define class-level helper methods (e.g. macros) that are called from within a describe or context block.  (But can anyone thing of a need or use to treat them the same way?)

TODO:

[x] Get the build to pass on all rubies (I want to discuss this before putting effort into that).
[x] Benchmark the perf difference this has.
[x] Decide how to handle :context hooks.
[x] Figure out how this should be documented.

Feedback wanted.
/cc @rspec/rspec

Rebased so this should be mergable again.

I'll try to review this tomorrow, I'm still a little concerned about that perf hit

@JonRowe I'd be curious to see how the benchmarks perform for you.  I'm getting better numbers now myself (partially due to rspec/rspec-support#140) and it'd be good to see what kind of numbers someone else gets, anyway.

bump @JonRowe

I started trying to run these yesterday but require_relative isn't working for me.

I started trying to run these yesterday but require_relative isn't working for me.

Odd, what error do you get?  FWIW, you have to add benchmark-ips to your Gemfile-custom and install that.  I also run the benchmarks through bundle exec.

Oh wait, I think I know what the problem is...I think it's this line:
https://github.com/rspec/rspec-core/pull/1749/files#diff-de6f446b75a88d3c7cc29859da747343R1
That requires the setup file generated by bundle install --standalone but if you don't use the --standalone option or you use an alternate --path you won't have that file.  We can remove that require and force the caller to get their environment setup (e.g. through bundle exec or -rbundler/bundle/setup or whatever).

benchmarks/singleton_example_groups/with_config_hooks.rb
-------------------------------------------------
No match -- without singleton group support
                        780.203  (±38.1%) i/s -      2.948k
No match -- with singleton group support
                        711.903  (±35.0%) i/s -      2.360k
Example match -- without singleton group support
                        752.003  (±38.0%) i/s -      2.700k
Example match -- with singleton group support
                        429.827  (±36.8%) i/s -      1.120k
Group match -- without singleton group support
                        614.148  (±32.7%) i/s -      1.944k
Group match -- with singleton group support
                        500.571  (±28.2%) i/s -      1.598k
Both match -- without singleton group support
                        657.000  (±30.9%) i/s -      1.980k
Both match -- with singleton group support
                        570.493  (±27.5%) i/s -      1.680k

benchmarks/singleton_example_groups/with_config_hooks.rb
No match -- without singleton group support
                        707.681  (±36.9%) i/s -      2.773k
No match -- with singleton group support
                        649.363  (±34.8%) i/s -      2.279k
Example match -- without singleton group support
                        700.023  (±37.6%) i/s -      2.438k
Example match -- with singleton group support
                        161.773  (±41.4%) i/s -    374.000
Group match -- without singleton group support
                        588.611  (±34.5%) i/s -      1.748k
Group match -- with singleton group support
                        461.789  (±31.0%) i/s -      1.365k in   5.256926s
Both match -- without singleton group support
                        593.820  (±35.4%) i/s -      1.530k
Both match -- with singleton group support
                        472.679  (±30.0%) i/s -      1.320k in   5.428863s

benchmarks/singleton_example_groups/with_module_inclusions.rb
No match -- without singleton group support
                        729.214  (±36.2%) i/s -      2.790k
No match -- with singleton group support
                        665.202  (±32.3%) i/s -      2.436k
Example match -- without singleton group support
                        731.884  (±38.1%) i/s -      2.565k
Example match -- with singleton group support
                        606.599  (±31.2%) i/s -      2.021k
Group match -- without singleton group support
                        727.859  (±37.2%) i/s -      2.262k
Group match -- with singleton group support
                        691.910  (±32.2%) i/s -      2.091k
Both match -- without singleton group support
                        716.281  (±39.2%) i/s -      1.976k in   5.285306s
Both match -- with singleton group support
                        624.883  (±29.4%) i/s -      1.776k in   5.261432s

benchmarks/singleton_example_groups/with_no_config_hooks_or_inclusions.rb
No match -- without singleton group support
                        743.302  (±37.5%) i/s -      2.835k
No match -- with singleton group support
                        739.835  (±35.3%) i/s -      2.714k in   5.529140s
Example match -- without singleton group support
                        763.097  (±38.9%) i/s -      2.679k
Example match -- with singleton group support
                        671.328  (±30.2%) i/s -      2.376k
Group match -- without singleton group support
                        762.491  (±37.5%) i/s -      2.400k
Group match -- with singleton group support
                        754.604  (±31.9%) i/s -      2.226k
Both match -- without singleton group support
                        793.465  (±37.3%) i/s -      2.120k
Both match -- with singleton group support
                        768.029  (±31.6%) i/s -      2.050k

benchmarks/singleton_example_groups/with_shared_context_inclusions.rb
No match -- without singleton group support
                        734.209  (±39.0%) i/s -      2.820k
No match -- with singleton group support
                        687.121  (±35.5%) i/s -      2.640k in   5.425344s
Example match -- without singleton group support
                        707.127  (±39.2%) i/s -      2.494k
Example match -- with singleton group support
                        193.853  (±43.8%) i/s -    480.000  in   5.508568s
Group match -- without singleton group support
                        615.113  (±38.9%) i/s -      1.850k in   5.530338s
Group match -- with singleton group support
                        510.581  (±37.4%) i/s -      1.568k
Both match -- without singleton group support
                        605.299  (±41.3%) i/s -      1.696k
Both match -- with singleton group support
                        555.050  (±32.6%) i/s -      1.558k

So it's consistently slower and in some cases (example matching) a lot slower?

You have benchmarks/singleton_example_groups/with_config_hooks.rb listed twice and the numbers on the 2nd one don't look right...
Anyhow, your numbers look pretty similar to mine, except your computer is apparently faster (or you have less background stuff running or something...)

So it's consistently slower and in some cases (example matching) a lot slower?

Yep.  I'm really not very concerned about the larger slowness for the example matching case because that's the one case where the user is actually leveraging the new feature here and, if we didn't merge this, would probably be surprised by the fact that the configured module/context/hook wasn't applied to the matching example.  I care more about minimizing the perf difference for all the other cases, which represent suites that don't leverage the new feature here.  For a feature-rich library like RSpec there's only so much you can do to keep new features from affecting perf for those who use them; what's more important, IMO, is that users who don't use the new feature aren't substantially penalized by the introduction of the feature, and I think that's what we're seeing here -- it's only about a 10% slower for all those cases.  Bear in mind that doesn't mean that end-user suites will be 10% slower; it simply means RSpec has 10% more overhead, which is likely to translate into a 1% or less slow down for real suites since RSpec's overhead is generally far outweighed by what the tests do.  Also, I tried to simulate something that's closer to a worse case than a typical case by adding 10 of each of the things (hooks, modules, etc), which in my mind is not typical.
The main outlier here is the perf of shared context inclusion for the example match case.  I profiled it and discovered that most of the time is being spent in RSpec::CallerFilter due to the changes in #1763.  Looking into that perf led me to rspec/rspec-support#140 and now it's not as bad as before but still bad.  I don't know if there's anything we can do about that.
Are you satisfied with the perf?  If not, what would it take to get you there?

I'm not satisfied with the larger difference in performance on the example matching, the rest I could live with, thats way more than 10%.

I'm not satisfied with the larger difference in performance on the example matching

For which benchmarks specifically are you dissatisfied?  I can focus my time on the specific one or ones that you care most about.  I'm also realizing that for some of these benchmarks, the degredation may be less about the added time of treating example groups in singleton fashion and more about the fact that doing so adds additional hooks, etc and given ruby's general method overhead that's going to add signficantly the time.  For example, with_config_hooks.rb adds 20 examples to the matching examples, and running 20 hooks plus 1 example is going to be noticably slower than running 1 example.

@JonRowe I did some more profiling and found something to optimize (see the last 3 commits).  The perf difference for the with_config_hooks benchmark is now much less.  I'll look some more into the others.

OK, I implemented another significant perf improvement, @JonRowe.  It solves the primary slow case we were seeing before.  Please take a look at the benchmarks now (and consider running them yourself for a 2nd data point) and let me know what you think.

FWIW, the build is broken due to a new aruba release (0.6.2) that removed a method we relied upon.  I started a conversation here about it:
https://github.com/cucumber/aruba/commit/5b2c7b445bc80083e577b793e4411887ef295660

We could always drop something like this into RSpec and include where necessary
module Conversions
  module Regexp
    module_function
    def Regexp(string_or_regexp)
      Regexp === string_or_regexp ? string_or_regexp : Regexp.compile(Regexp.escape(String(string_or_regexp)))
    end
  end
end

We could always drop something like this into RSpec and include where necessary

Yep, I was thinking that too, but wanted to hear from the aruba maintainer if the removal of the API was intentional and what their public API/SemVer policy is.

I rebased against master now that #1848 has been merged so hopefully this will pass now.

And it is indeed now green (including on AppVeyor).
@JonRowe, please let me know if what's here is insufficient.  If so, I can put some more time into profiling today, and I may choose to cherry-pick the last 4 commits to a new PR targeting master since they are general perf improvements that will help outside of this PR.

I'll rerun these later today to find out!

I'll rerun these later today to find out!

Did you get a chance to do this?

Doing it now

with_config_hooks.rb
No match -- without singleton group support
                        647.222  (±34.6%) i/s -      2.530k
No match -- with singleton group support
                        565.663  (±31.8%) i/s -      2.009k
Example match -- without singleton group support
                        637.552  (±34.8%) i/s -      2.303k in   5.473734s
Example match -- with singleton group support
                        475.289  (±32.0%) i/s -      1.560k in   5.302093s
Group match -- without singleton group support
                        622.463  (±32.0%) i/s -      2.162k
Group match -- with singleton group support
                        497.005  (±30.2%) i/s -      1.591k in   5.644785s
Both match -- without singleton group support
                        652.425  (±31.1%) i/s -      1.974k
Both match -- with singleton group support
                        494.419  (±27.9%) i/s -      1.470k

with_config_hooks_module_inclusions_and_shared_context_inclusions.rb
No match -- without singleton group support
                        648.157  (±34.4%) i/s -      2.438k
No match -- with singleton group support
                        569.331  (±32.8%) i/s -      2.050k
Example match -- without singleton group support
                        635.033  (±36.8%) i/s -      2.295k
Example match -- with singleton group support
                        411.128  (±31.4%) i/s -      1.248k
Group match -- without singleton group support
                        530.298  (±31.7%) i/s -      1.850k
Group match -- with singleton group support
                        440.181  (±31.1%) i/s -      1.470k in   5.744591s
Both match -- without singleton group support
                        587.389  (±30.0%) i/s -      1.845k
Both match -- with singleton group support
                        441.388  (±30.6%) i/s -      1.320k

with_module_inclusions.rb
No match -- without singleton group support
                        676.603  (±34.7%) i/s -      2.494k
No match -- with singleton group support
                        629.130  (±31.3%) i/s -      2.193k
Example match -- without singleton group support
                        652.903  (±37.1%) i/s -      2.300k in   5.450937s
Example match -- with singleton group support
                        564.873  (±32.4%) i/s -      1.764k
Group match -- without singleton group support
                        640.222  (±31.2%) i/s -      2.205k
Group match -- with singleton group support
                        597.270  (±32.8%) i/s -      2.024k in   5.974166s
Both match -- without singleton group support
                        663.392  (±33.2%) i/s -      2.050k
Both match -- with singleton group support
                        625.442  (±28.8%) i/s -      1.892k

with_no_config_hooks_or_inclusions.rb
No match -- without singleton group support
                        692.283  (±34.5%) i/s -      2.537k
No match -- with singleton group support
                        580.327  (±35.0%) i/s -      2.184k in   5.498542s
Example match -- without singleton group support
                        636.292  (±34.7%) i/s -      2.310k in   5.596156s
Example match -- with singleton group support
                        595.478  (±32.4%) i/s -      2.107k
Group match -- without singleton group support
                        628.846  (±35.5%) i/s -      2.052k
Group match -- with singleton group support
                        605.565  (±29.4%) i/s -      1.950k
Both match -- without singleton group support
                        668.727  (±33.6%) i/s -      2.040k
Both match -- with singleton group support
                        648.712  (±30.2%) i/s -      1.880k

with_shared_context_inclusions.rb
No match -- without singleton group support
                        687.075  (±34.3%) i/s -      2.520k
No match -- with singleton group support
                        641.615  (±32.9%) i/s -      2.184k
Example match -- without singleton group support
                        653.823  (±36.2%) i/s -      2.365k in   5.644462s
Example match -- with singleton group support
                        528.077  (±32.8%) i/s -      1.786k in   5.469866s
Group match -- without singleton group support
                        631.137  (±36.9%) i/s -      2.173k in   5.834991s
Group match -- with singleton group support
                        596.201  (±27.8%) i/s -      1.974k
Both match -- without singleton group support
                        648.851  (±33.0%) i/s -      1.968k
Both match -- with singleton group support
                        608.591  (±29.1%) i/s -      1.806k

Much better, it's still slower but I guess I'm ok with it if you are.


StartTrigger throws error: Method not found: Void Amazon.Runtime.Internal.IRequest.set_MarshallerVersion(Int32)

When running this code:
using(var client = new AmazonGlueClient(awsCredentials, region))
       {
           client.StartTrigger(
               new StartTriggerRequest {
                   Name = "test"
               }
           );
       },

the following error occurs:

Method not found: Void Amazon.Runtime.Internal.IRequest.set_MarshallerVersion(Int32).

The packages AWSSDK.Core(<IP_ADDRESS>) and AWSSDK.Glue(<IP_ADDRESS>) are used.
The following dependencies are also listed:
using Amazon.Runtime;
using Amazon.Glue;
using Amazon.Glue.Model;
using Amazon.Runtime.Internal;

Am I missing something? Or is this an issue?

Interestingly this works fine with this combination(different versions)
AWSSDK.Core - <IP_ADDRESS>
AWSSDK.Glue - 3.3.106

Nope didn't work
On Monday, September 9, 2019, Krithika<EMAIL_ADDRESS>wrote:

Interestingly this works fine with this combination(different versions)
AWSSDK.Core - <IP_ADDRESS>
AWSSDK.Glue - 3.3.106
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/1398?email_source=notifications&email_token=AMNKJE3DW6ZEDMQL7VMML6LQIZSVVA5CNFSM4IU4IFSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6H7O6Q#issuecomment-529528698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMNKJE4Y23WXSMQSWVIQGS3QIZSVVANCNFSM4IU4IFSA
.

--
null

Hi @krithikabalu, can you please try reinstalling your AWSSDK dependencies?  I wasn't able to reproduce this issue with the same versions you specified.

You’re invited to join Google Play Family Library
Hi<EMAIL_ADDRESS>Kevin Krabbe<EMAIL_ADDRESS>invited you to Family Library. If
you join, you'll be part of his family on Google. Together, you can share
your purchased games, movies, and more. Learn more about joining a family
group on Google Play.
https://support.google.com/googleplay?p=email_joinafamily
ACCEPT INVITATION
https://families.google.com/join/promo/BAXzydmgiWlceAE0qJYiozfEC76TUw
Have fun!
The Google Play team
Google LLC
1600 Amphitheatre Parkway,
Mountain View, CA 94043, USA

Kevin d Krabbe app won't download

Get Candy Beauty Camera from the Amazon Appstore. Check it out - http://amzn.eu/d/6qVYkBg

Rights owners wanting to notify us of an alleged rights infringement should complete and submit our Notice Form by clicking here.

You’re invited to join Google Play Family Library
Hi<EMAIL_ADDRESS>Kevin Krabbe<EMAIL_ADDRESS>invited you to Family Library. If
you join, you'll be part of his family on Google. Together, you can share
your purchased games, movies, and more. Learn more about joining a family
group on Google Play.
https://support.google.com/googleplay?p=email_joinafamily
ACCEPT INVITATION
https://families.google.com/join/promo/CamMbEhOrlPzVLrIu7dnt-0v6pI3Sw
Have fun!
The Google Play team
Google LLC
1600 Amphitheatre Parkway,
Mountain View, CA 94043, USA

Apologies for delay, Will try and let you know in a day.

I would also check to see if you have any versions of the AWS SDK in your .NET Global Assembly Cache (gac). If a version of AWSSDK.Core is in the gac then .NET Framework will load that version, which could be old and predate  set_MarshallerVersion property which is fairly new. instead of the version included with your application.
This page can help you inspect your gac: https://docs.microsoft.com/en-us/dotnet/framework/app-domains/how-to-view-the-contents-of-the-gac


Fix errors and crash with empty ConvexPolygonShape2D

Fixes crash mentioned in https://github.com/godotengine/godot/issues/45724#issuecomment-790620260, regression from #46291 and errors that were already present when trying to draw an invalid convex polygon.

@akien-mga This is important for the upcoming 3.2.4 RC, the editor currently crashes each time an empty ConvexPolygonShape2D is created.

Thanks!

Cherry-picked for 3.2.4.


Integrate email functions into text document

Related Issues

[x] #7
[x] #8
[x] #9

See also: https://github.com/jstedfast/MailKit

Implemented via #33 -- improved based on feedback in #42.


Create mockup

What issue is this solving?
Closes #28
Description
Created a simple mockup to begin a design for a home page and establish the theme of the community site. Everything is self contained in the new mockup directory.
I wasn't super picky just wanted to get quick concept on the web page. I leaned a little bit more into using the colors from the Discord logo a bit to experiment. I think a lot of things will be easier to fine tune when we implement the color scheme in Tailwind or even use HSL over hex colors.
Any helpful knowledge/context for the reviewer?

Feelings gif (optional)

Please make sure you've attempted to meet the following coding standards

[ ] Code has been tested and does not produce errors
[x] Code is readable and formatted
[x] There isn't any unnecessary commented-out code

The empty span in the header is for the purpose of me not feeling like screwing around with centering the navbar and I felt as if there could be some user avatar there potentially.

Converted @Cykotech's mockup to React components & tailwind classes.
Needs to be adapted to a Layout/Children pattern

Layout implemented!

Nice - let's hold off merging the code changes for the time until we've had more pairs of eyes on the design though 😄

Yes! I think the colour scheme can be improved.

I love the enthusiasm, and I think this is a great start!
That said, I don't think this PR is (or was ever intended to be) merge-able.
In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

Thanks for that tip! I didn't think about branching off a branch. My enthusiasm ran away with me 😂

In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

Thanks for that tip! I didn't think about branching off a branch. My enthusiasm ran away with me 😂

All good! Better to have people excited for a project than lack luser! :smile:


Modify text under local repository?

It says things like "ahead by ** commits" or "behind by ** commits" which isn't very clear at first glance. Can we make it more explicit?

Perhaps " is ahead/behind  by *** commits"?


enforce error

there is a error when use keymatch4 in model.conf
[request_definition]
r = sub, obj, act

[policy_definition]
p = sub, obj, act

[role_definition]
g = _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub) && keyMatch4(r.obj, p.obj) && regexMatch(r.act, p.act)

local Enforcer = require("casbin")

local e = Enforcer:new("/opt/openresty/nginx/conf/lua/casbin/rbac_model.conf", "/opt/openresty/nginx/conf/lua/casbin/examples/rbac_policy.csv")

local cjson = require "cjson"
local response = {}

local sub = "alice" -- the user that wants to access a resource.
local obj = "data1" -- the resource that is going to be accessed.
local act = "read" -- the operation that the user performs on the resource.

if e:enforce(sub, obj, act) then
  response['code'] = 200
  response['result'] = true
  response['msg'] = e:GetPolicy()
  ngx.say(cjson.encode(response))
end

2023/12/12 18:42:33 [error] 208585#0: *4 lua entry thread aborted: runtime error:
...openresty/luajit/share/lua/5.1/src/main/CoreEnforcer.lua:449: attempt to concatenate field 'message' (a nil value)
stack traceback:
coroutine 0:
        ...openresty/luajit/share/lua/5.1/src/main/CoreEnforcer.lua: in function 'enforceEx'
        ...openresty/luajit/share/lua/5.1/src/main/CoreEnforcer.lua:534: in function 'enforce'

@transtone it seems that your error doesn't match with your source code, the error shows enforceEx and a field called message, but your code never mentioned those. So why is that?


Update index.mdx

Update index.mdx
Please read contributing guidelines and remove this line.

This is incorrect


Godot is not removing a Camera Node

Godot version:

3.0.6 stable
OS/device including version:

Godot Editor, Windows 10
Issue description:

Changing the parent's node of the Camera is not working. Also when I toggle the visibility to off or set Current property to false the Camera stills render the scene.
Steps to reproduce:

I created a helper function to set parent of a Node (it would be nice if we can have a similar function in the Godot API)

func set_parent(parent, node):
	var nodeParent = node.get_parent();
	if (nodeParent == parent):
		return;
	nodeParent.remove_child(node);
	print(nodeParent.is_a_parent_of(node))
	parent.add_child(node);

Then in some script:

func _ready():
	var firstNode = get_node("/root/Game/");
	var mainCamera = firstNode.get_node("MainCamera");
	set_parent(self, mainCamera);

The camera node stills child of the firstNode...

Testing

Printing if the node is child of the previous parent outputs True
	print(nodeParent.is_a_parent_of(node))

If I just remove the Camera node with nodeParent.remove_child(node); it doesn't remove. It still rendering the scene.
Minimal reproduction project:

For this issue I'm sharing this project.

remove_child does not delete the node (and it will leak references), but it should reset the current camera on the viewport when the camera leaves the tree, I suppose.

Can anyone still reproduce this bug in Godot 3.2.1 or any later release (e.g. 3.2.2-rc2)?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


feat: on this page links of article for mobile/tablet

✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
Added on this page links for mobile/tablet devices for easily navigating between points.

Screenshots
Demo video
demo-video.webm
💯

Please run pnpm format

I like this a lot.
Just one suggestion: Does it really need to say the active section next to the dropdown? I think the user knows where they are because it's what's on the screen. Maybe a more helpful thing would be to highlight the active section in the dropdown, similar to what the current desktop sidebar does.

There's some layout shifting going on
https://user-images.githubusercontent.com/51714798/204095341-e89f21ad-adb4-445d-9712-6caad5525c29.mp4
Same one as the language selector

https://user-images.githubusercontent.com/8353666/204096148-55b9c68a-b6c6-4ff1-b7f4-70ad5cdbf45c.mov
Now getting layout shift on the language selector, but only in this pr, not in prod

Please run pnpm format

I ran this script but no file changes detected so i cant commit maybe i am missing something

I like this a lot.
Just one suggestion: Does it really need to say the active section next to the dropdown? I think the user knows where they are because it's what's on the screen. Maybe a more helpful thing would be to highlight the active section in the dropdown, similar to what the current desktop sidebar does.

This is also good idea we could also do this do you want me to change according to this?

Please run pnpm format

I ran this script but no file changes detected so i cant commit maybe i am missing something

Seems like there's some issue in the layout/docs file: https://github.com/t3-oss/create-t3-app/actions/runs/3554240486/jobs/5970216605#step:8:29

I like this a lot.
Just one suggestion: Does it really need to say the active section next to the dropdown? I think the user knows where they are because it's what's on the screen. Maybe a more helpful thing would be to highlight the active section in the dropdown, similar to what the current desktop sidebar does.

This is also good idea we could also do this do you want me to change according to this?

Yea I think highlighting in the dropdown makes sense

Not sure why format CI keep failing? ran the script twice still failing

Not sure why format CI keep failing? ran the script twice still failing

This is the diff I get when running it:

Maybe the highlighting should match the highlighting for the regular TOC as well as the sidebar? This is a bit subtle imo

Maybe the highlighting should match the highlighting for the regular TOC as well as the sidebar? This is a bit subtle imo

Added changes required for this

Maybe the highlighting should match the highlighting for the regular TOC as well as the sidebar? This is a bit subtle imo

Added changes required for this

Awesome, only the layout shifting bug left then.
Any idea on how to solve it? I'd guess it's the scroll padding but did you think there would be new consequences then?

In the local layout shift is not happing but in the deployed version it is happing so not sure about that
Will have to look in to it

Looks really good. Only thing missing now is breadcrumbs and we have it all :)
One thing, there's some layout shifting going on:
CleanShot.2022-11-26.at.15.59.51.mp4
Same one as the language selector

Not sure what fix this but from the layout shift from dropdown now when we click outside layout is not shifting. I have it checked on chrome, Firefox and edge. If you can confirm this on safari?
But, from language selector the issue still persist.
page-links-not-layout-shift.webm

@juliusmarminge @c-ehrlich I think that layout shift issue is fixed now


"extends": ["codelyzer"] is broken

The docs stated in https://github.com/mgechev/codelyzer/tree/4.1.0#custom-installation is some how invalid now.
the published package(download from npm) does not have index.js as https://github.com/mgechev/codelyzer/blob/4.1.0/index.js, therefore, extends feature is broken

This should fix the issue https://github.com/mgechev/codelyzer/pull/511/files


_PressIntensity was not found. Please provide a valid material property name. Oculus Quest Build.

This is the first time I write an issue so forgive if I don't explain myself well.
Describe the bug
When I build my application using the Android Platform to an Oculus Quest device and run it, I only get a black screen. Using the Android Logcat I saw that there's an error with a Material Property. This is the trace:
21/12/19 13:58:17.915 6011 6034 Error Unity Exception: The property _PressIntensity for reacting to pinch strength was not found please provide a valid material property name

2021/12/19 13:58:17.915 6011 6034 Error Unity Exception: The property _PressIntensity for reacting to pinch strength was not found please provide a valid material property name
2021/12/19 13:58:17.915 6011 6034 Error Unity   at Microsoft.MixedReality.Toolkit.Input.RiggedHandVisualizer.Microsoft.MixedReality.Toolkit.Input.IMixedRealityHandJointHandler.OnHandJointsUpdated (Microsoft.MixedReality.Toolkit.Input.InputEventData`1[T] eventData) [0x00583] in D:\Documents\Unity Development\Projects\Ictus Project\Library\PackageCache\com.microsoft.mixedreality.toolkit.foundation@f668f6c6655c-1631793666009\SDK\Features\UX\Scripts\RiggedHandVisualizer\RiggedHandVisualizer.cs:470
2021/12/19 13:58:17.915 6011 6034 Error Unity   at Microsoft.MixedReality.Toolkit.Input.MixedRealityInputSystem+<>c.<.cctor>b__244_44 (Microsoft.MixedReality.Toolkit.Input.IMixedRealityHandJointHandler handler, UnityEngine.EventSystems.BaseEventData eventData) [0x00008] in D:\Documents\Unity Development\Projects\Ictus Project\Library\PackageCache\com.microsoft.mixedreality.toolkit.foundation@f668f6c6655c-1631793666009\Services\InputSystem\MixedRealityInputSystem.cs:1969
2021/12/19 13:58:17.915 6011 6034 Error Unity   at Mic

I can't follow the error because the trace cuts on that line, and nothing else gets logged (just this error, continuously), I tried multiple things but I just can't get the full error message and the full stack trace...
The build completes without errors, and I get my APK without any problems. But when I run it, I get this.
To reproduce
I actually do not know how to reproduce it because until not long ago the build worked without any problems. I don't know if it's my fault or if is anything related to the Unity version (I had to switch to a newer one a few days ago).
Screenshots

Setup

Unity Version -> Version 2021.2.6f1
MRTK Version -> Version 2.7.2

Target platform

Oculus Quest

Additional context
In the editor, through Oculus Link, everything works. I tried to delete and rebuild the Package Cache by deleting the Library folder but that did not solve the problem.
I also tried to build a standalone Windows Build and test it through Oculus Link, then everything works fine, so it seems that is only a problem when I try to build to the Oculus device. By the way, not sure if it helps but I am using URP.

Huh, strange! @RogPodge, have you ever seen this? @iivvaannxx, can you please confirm which shader the RiggedHandVisualizer is using? You should be able to check the prefab under Controllers > Controller Visualization Settings, then looking in either Global Left/Right Hand Visualizer or a controller-specific override for Oculus.

I haven't seen this issue specificially, but I think it's related to the material we use for the rigged hands not compiling properly onto Android when using URP.
If you can't get the shader to work, you can comment these lines to work around the exception for now https://github.com/microsoft/MixedRealityToolkit-Unity/blob/f06939ebd47e1c200c83dcdc3e5d3928c90459cd/Assets/MRTK/SDK/Features/UX/Scripts/RiggedHandVisualizer/RiggedHandVisualizer.cs#L464-L471

Okay, so first of all, @keveleigh I looked into the Rigged Hand Visualizer prefab for both hands, out of play mode and also at runtime (during play mode, to make sure the material it's not somehow updated) and in both cases I saw the same material, called HandMeshOutline, which has the shader RimOutline. There wasn't any Oculus specific override.
Then, @RogPodge I did what you said and commented that block, then the application does not throw that error but instead I got this:

I don't know if it's related to this issue or to another but I thought I should mention it. While testing the app I still can't see anything else than a black screen, due to this another error I guess, but I noticed that the game is actually running, because I have some audio which is played when some objects are hovered with the rays (of either the hands or the head).
When I randomly move my head, I don't see anything, but I can hear sometimes the interaction sound playing. Don't know what can be happening but I certainly would appreciate a little help.

I recall that exception being a non-blocking one, thought the black screen issue is something I am not familiar with.
https://docs.microsoft.com/en-us/windows/mixed-reality/mrtk-unity/supported-devices/oculus-quest-mrtk?view=mrtkunity-2021-05
Do you have the same issues following these instructions and deploying to Unity 2020? I don't think we've done much development on Unity 2021 yet with MRTK v2.

@RogPodge I will take a look and give it a try. It may take a little because I can't downgrade to Unity 2020 easily as the project is not particularly little. Besides I am a little busy these days.
I will reply and tell as soon as I can, thanks!

@RogPodge Okay, so I apologize for such a late reply but I was too busy with a lot of other stuff. Today I tried to migrate the project to Unity 2020. It did not go quite well.
First I got a bunch of scripting errors because on the project I was using C# 9 features (I think) or at least features that are supported on 2021 but not on 2020, it took a little to fix. After I managed to get everything working I tried to run the scene on both editor and build, here's the problem now:
On the editor i keep getting this annoying error all the time:
The list of [SerializeReference] objects being deserialized is from a more recent version of Unity. This is not supported and objects will be skipped.
UnityEditor.AssetDatabase:LoadAssetAtPath<UnityEngine.ScriptableObject> (string)
Microsoft.MixedReality.Toolkit.Editor.ScriptableObjectExtensions:GetAllInstances<UnityEngine.ScriptableObject> () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Extensions/EditorClassExtensions/ScriptableObjectExtensions.cs:65)
Microsoft.MixedReality.Toolkit.Editor.SceneInfoUtils:RefreshSceneInfoFieldsInScriptableObjects () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Inspectors/PropertyDrawers/SceneInfoUtils.cs:298)
Microsoft.MixedReality.Toolkit.Editor.SceneInfoUtils:InitializeOnLoad () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Inspectors/PropertyDrawers/SceneInfoUtils.cs:231)
UnityEditor.EditorAssemblies:ProcessInitializeOnLoadMethodAttributes ()

It does not prevent me entering to Play Mode. If I try to execute, sometimes I get this:
NullReferenceException: Object reference not set to an instance of an object
Microsoft.MixedReality.Toolkit.XRSDK.Oculus.Input.OculusXRSDKDeviceManager.GetOrAddController (UnityEngine.XR.InputDevice inputDevice) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Providers/Oculus/XRSDK/OculusXRSDKDeviceManager.cs:109)
Microsoft.MixedReality.Toolkit.XRSDK.Input.XRSDKDeviceManager.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Providers/XRSDK/XRSDKDeviceManager.cs:114)
Microsoft.MixedReality.Toolkit.XRSDK.Oculus.Input.OculusXRSDKDeviceManager.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Providers/Oculus/XRSDK/OculusXRSDKDeviceManager.cs:221)
Microsoft.MixedReality.Toolkit.BaseDataProviderAccessCoreSystem.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Services/BaseDataProviderAccessCoreSystem.cs:51)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit+<>c.<UpdateAllServices>b__72_0 (Microsoft.MixedReality.Toolkit.IMixedRealityService service) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.ExecuteOnAllServicesInOrder (System.Action`1[T] execute) (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Services/MixedRealityToolkit.cs:1145)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.UpdateAllServices () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Services/MixedRealityToolkit.cs:1054)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.Update () (at Library/PackageCache/com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592/Core/Services/MixedRealityToolkit.cs:727)

But yet everything works fine and there aren't any problems (same as on Unity 2021).
Regarding to the build, I am not even able to build, I tried like 4 times, and it continuously keeps printing me this two errors:
Library\PackageCache\com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592\SDK\Experimental\SpatialAwareness\SurfaceMeshesToPlanes.cs(13,55): error CS0234: The type or namespace name 'Processing' does not exist in the namespace 'Microsoft.MixedReality.Toolkit.SpatialAwareness' (are you missing an assembly reference?)

Library\PackageCache\com.microsoft.mixedreality.toolkit.foundation@ad1fef596cc6-1642786332592\SDK\Experimental\SpatialAwareness\SurfaceMeshesToPlanes.cs(397,59): error CS0246: The type or namespace name 'BoundedPlane' could not be found (are you missing a using directive or an assembly reference?)

In order to make it clear, to migrate the project I followed these steps:
1. Create a new project with Unity 2020.3.24f1
2. Add the necessary packages and configure it.
3. Copy the Assets, ProjectSettings and UserSettings from the previous one (except for the ProjectVersion.txt)
4. Run, let everything to import, fix the scripting errors.
5. Test on editor and on build.

If you can help me get over these errors, then I could try to build again and see if the black screen disappears. If that doesn't help solve the issue neither, I would assume that is a problem with my Oculus Device and not with the MRTK. Thanks!

If it is helpful I also get the error:
Error Unity Exception: The property _PressIntensity for reacting to pinch strength was not found please provide a valid material property name
It occurs when I copy the RiggedHandLeft prefab into my project and use it in MixedRealityToolkit->Input->Controllers->Global Left Hand Visualizer. I also unassign the override model in Microsoft Articulated Hand Left Hand so that it uses the global hand.

I agree reassigning the material is causing the errors. I think we may call into that "_PressIntensity" property in code, even though in cases like this is optional.
Sorry for the late response on our end too, I'll try to look into this and get a fix out by our next pre-3.0 release


dev.open opens last url multiple times

What happened?
I have multiple urls defined for dev.open and when running devspace dev it opens the last url defined N times (N being the amount of urls defined)
What did you expect to happen instead?
To open all urls defined
How can we reproduce the bug? (as minimally and precisely as possible)
Define two urls urls and it will open the last one twice.
dev:
  open:
    - url: http://google.com
    - url: http://microsoft.com

Local Environment:

Operating System: linux
Deployment method: helm

Kubernetes Cluster:

Cloud Provider: minikube
Kubernetes Version:

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:14:22Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.9", GitCommit:"2e808b7cb054ee242b68e62455323aa783991f03", GitTreeState:"clean", BuildDate:"2020-01-18T23:24:23Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Anything else we need to know?
╰─$ devspace --version
devspace version 4.5.3

/kind bug

@chasebolt thanks for reporting! Yes that is true, I'll fix this.


[MB-12678] Add delete shipment button to prime simulator

Jira ticket for this change
Summary
This PR adds a button to the prime simulator for deleting a shipment (PPM only).
Note that this PR calls the API being developed in #8773, so this can't be fully tested until that PR is ready and merged (or we merge it into this PR).
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

make clean server_build client build db_dev_reset db_dev_e2e_populate
Using your favorite database console, find the COMBOS move and make it available to the prime (I just changed the available_to_prime_at field to some date.
Log in as a prime simulator user in gbloc KKFA.
Go to the COMBOS move. You should see a Delete Shipment button beside the PPM in that move.
Chick Delete Shipment and test out the modal, eventually confirming you want to delete the shipment.
You should get a notification that the shipment was deleted and no longer see it in the list of shipments for the move.

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Screenshots
The new Delete Shipment button:

The confirmation modal:

The alert that confirms the shipment was deleted:

Messages

:book:
:link: MB-12678

  Generated by :no_entry_sign: dangerJS against f83f05ff24013671496498d6aaa65cde8130f9ae


Unit tests

I'm not sure how best to test a library like this. Maybe making a stub ACME server? Deploying a local Boulder instance?

fixed long ago


feat: add token group extension in token

As mentioned in #6175, add support for token group extension to @solana/spl-token
Todo

[x] e2e tests
[ ] unit tests

Hi, I was having trouble fixing the groupMember test. I may not be able to finish this soon. It would be great if you could help commit to this branch directly


Maximum orders per interval NOT working

Expected behavior:
If I set limit orders per timeslot to 2, I expected to receive max 2 order for the same timeslot.

Actual behavior:
I'm able to make more than 2 orders for the same timeslot, as shown in the image below:

Reproduce steps:
Set limit orders per timeslot to 2, make several orders for the same timeslot.
Version:
v.3.0.4-beta.23.2
Additional Information:
The "error" is here in the status selection. Because we leave out all the new orders in pending status taking in account only processing_order_status and completed_order_status
https://github.com/ryanmitchell/ti-ext-local/blob/e3df9ac7b33c1518caf1119dae804fdf35a4ce86/listeners/MaxOrderPerTimeslotReached.php#L60

If as a restaurant I receive 5 orders for the first interval and my limit is 2 what i should do? accept only 2 and call the others and change interval for the others?

Yeah I noticed this when working on the max orders extension. @sampoyigi can you remember a reason for not including 'received' orders in the count?

i get an error on the frontend aswel.

@BlueRayNL check the latest commits on the local extension for a fix on that - it was fixed last week I believe.

when I enable this feature it closes the store.

@wakey18 can you provide more information as to what that means?

@ryanmitchell
Before I enable Limit Order Count

After

Does the same no matter what the limit is set to.

Also not sure if it is related but cannot schedule an order for later even though the lead time is 60 mins and the interval is 15 mins.
The last order time states 20:30 but can only order for asap.

@wakey18 the fix was this one: https://github.com/tastyigniter/ti-ext-local/commit/5ca6dea56c5ff6abdfb9bae52e509c21b4a898d4 - just making sure we're talking about the same thing. Other than that I'm at a loss to explain this one.

@wakey18 the fix was this one: tastyigniter/ti-ext-local@5ca6dea - just making sure we're talking about the same thing. Other than that I'm at a loss to explain this one.

Yes sorry copied the wrong URL

@ryanmitchell
Before I enable Limit Order Count

After

Does the same no matter what the limit is set to.

Check #553

@sampoyigi just a bump in case you missed  my comment:

can you remember a reason for not including 'received' orders in the count?

I hardly use the received status in any of my setup, orders are updated to a processing status after sucessful payment rather than the default status. You're right it should be included.

👍 I’ll open a PR

On 1 Nov 2020, at 15:47, Sam Poyigi<EMAIL_ADDRESS>wrote:

I hardly use the received status in any of my setup, orders are updated to a processing status after sucessful payment rather than the default status. You're right it should be included.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


rename xsd to skdownscale

closes #14

Merging despite failing tests. Will follow up with another PR shortly.


[WIP] Test that flutter run doesn't introduce new debug spew

⚠ Blocked on previous PRs:

[x] Refactor macOS test: https://github.com/flutter/flutter/pull/114645
[x] Refactor Android test: https://github.com/flutter/flutter/pull/115023
[x] Add Windows test: https://github.com/flutter/flutter/pull/116626

See: https://github.com/flutter/flutter/issues/111577
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Replaced by https://github.com/flutter/flutter/pull/116798


ENH Reuse TopK buffers

Before going forward on the KNN I'd like to add this enhancement for the TopK, this PR exposes a function _make_get_topk_kernel that returns a closure that will held references definitions of kernels AND to buffers that will be re-used if successive calls to _make_get_topk_kernel are performed.
The current top-k top level functions in main include an allocation and de-allocation at each calls. (The kernel definitions are still cached by the lru_cache).
This fit the usecase for the KNN that will consist in slicing the input data and running the same pairwise distance + TopK kernels for each slice, and aligns with the behavior of the sum and argmin reduction kernels in the reduction .

The unit test is a bit technical with the closure-style definition of things everywhere but it should be possible, I'll look into it.


Demo for using google api for searching addresses

Hi guylabs,
first of all thanks for the great work and also thanks to danny for the initial work!!
I was not able to find examples for working with google api. Did i overlooked this point in the docs?
thx!

Hi, it was an easy task to implement. Just used the geocode method for the items-method.

Hi @BioPhoton,
cool that you could easily implement it yourself. Could you maybe add the example as a codepen here such that I could add it to the documentation with a reference to you?
Thanks and regards,
Guy

Hi, i created a pull request with the implementation.
happy to contribute...

Hi @BioPhoton,
thanks a lot for the contribution. I already merged it :)
Regards,
Guy

wellcome!


No matching start tag

The following code gives an error of "Encountered end tag 'div' with no matching start tag. Are your start/end tags properly balanced?" on "
@for (var i = 1; i < 32; i++)
{
    @if (i % 7 == 0)
    {

    }

    <button @onclick="@(() => RandomEventName(i))" class="@IsSelected(i)">@i</button>

    @if (i % 7 == 0)
    {

    }
}

This also then causes issues with the } brackets for the rest of the page, almost like it's missing the brackets aftert . I'm sure there is a better way I can be doing this. I don't really like the way I did this anyways, so I'm going to change it, however, this is an issue. There will be circumstances where the opening and closing tags will be within seperate "if" blocks which is what seems to be causing this issue.

You can't split open/close tags between Razor code blocks like @if. Razor needs to be able to understand where the markup ends and the code begins and it does that by balancing markup tags.
Consider the markup in a Razor page just like any other C# block construct. You couldn't write code like this for example:
if(i % 7 == 0) {
    try {
}
Console.WriteLine("Foo");
if(i % 7 == 0) {
    }
}

Razor is the same, but the tags are part of the code and have the same impact on the parsing of the document.
Razor does provide an "escape-hatch" here though, in the form of the @: command. This tells Razor to consider the rest of the line as HTML markup, but ignore all the tags on it. Just that one line is considered markup. So for example, you could write your sample like this:
@for (var i = 1; i < 32; i++)
{
    @if (i % 7 == 0)
    {
        @:

    }

    <button @onclick="@(() => RandomEventName(i))" class="@IsSelected(i)">@i</button>

    @if (i % 7 == 0)
    {
        @:

    }
}

The docs on Razor code blocks does a pretty good job of covering all this and has a bunch of useful examples. If there are some things missing there that would help you understand better, please feel free to comment on the doc or even send a PR!
Hope that helps!

I hate logging a bug only to find out that you didn't read the documentation ;)
Thanks, that makes sense.

Hey, it also means our docs may not be as easy-to-find as we want :). Let us know if there are places you looked for docs about this and didn't find them!

html tags wrong. only .razor ,
code
@for (var i = 0; i < 4; i++)
{
    @if (i % 2 == 0)
    {
       @:

     }
    <button  >@i</button>

    @if (i % 2 == 1)
    {

      @:

    }

}

expect:

 cells

cells

BUT i got this:(RenderMode.ServerPrerendered or RenderMode.Server)

 cells

 cells
bug?

@anurse

I think your issue is the i % 2 == 1 in the second if. I believe it should be the same as the first. Also, where is the word "cell" coming from?

Please file a new issue if there is a problem/question here. Closed issues are not monitored during our regular triage process.


Convert Asp.net 4.5 MVC5 SimpleMembership Authentication to IdentityServer4

I have an Asp.net 4.5 MVC5 app using SimpleMembership for Authentication and Authorization with role in App. Now I need to integrate to use external IdentityServer4 for Authentication. Is this possible? Is there an sample I can follow?

This seems to be a general question - not a bug report or a feature request.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


fix: restore name attribute

this partially reverts #222, and fixes https://github.com/apache/superset/pull/19317#issuecomment-1161303805
@machow are you able to find the source which told you to remove this field at all?

Hey--I think this may be related to duckdb_engine registering the duckdb_engine module itself with sqlalchemy, rather than the dialect class?
I'm not totally sure, but I think this explains why I couldn't use sqlalchemy.dialects.registry with duckdb_engine, but had to account for it giving me a module back:
https://github.com/machow/siuba/blob/main/siuba/sql/utils.py#L59-L63
I'm not too familiar with the process, but it looks like sqlalchemy suggests registereing the dialect class:
https://docs.sqlalchemy.org/en/14/core/connections.html#registering-new-dialects