How do you add storage to the VM?

General information
OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes
CRC version
crc version: 1.6.0+8ef676f
OpenShift version: 4.3.0 (embedded in binary)
I want to create persistent volumes locally on the OC vm. How can I do that?
Or
Is there a way to expose my storage from host to the VM?
thanks

Is there a way to expose my storage from host to the VM?

At the moment there is no way to do this. It is also unlikely we will add a function that uses virtual host folders or similar. It would be preferred to use OpenShift/Kubernetes native solutions.

persistent volumes

These are created as part of the image creation:
https://github.com/code-ready/snc/blob/fcd8294c008a758b67f4b63ad20ed7c3d155e149/snc.sh#L54-L75
... numbered "pv0001" and up. Is this what you were looking for?

@gbraad
Yes that's what i was looking for. We wanted to create our own of the sizes we need. The virtual disk associated with this vm is not enough to support our cluster.
I can expand the dist on the Hyper-v side. But then I need a way to expand that internally.
In essence is there way to save a new, larger disk for the next crc setup/start?

If i run the same ssh I get permission denied (publickey,gssapi-keyex,gssapi-with-mic) on Windows (had to drop -o UserKnownHostsFile=/dev/null)

@gbraad
I looked at the script you provided. It looks like it creates 30 mnt volumes. This is not enough for our application. Could you parametrize this (and naturally expand the disk too)? thanks

We can not parameteruze this as images are precreated.
You can grow the disk following a page on the wiki (not up to date). Might be as ble to give more details during the week

Can you share the full command you used for ssh, and which executable? We switched to a go implementation as many ssh clients are faulty.

@gbraad
I think I'm just using the default ssh that comes with Windows. I don't recall having that installed additionally:
C:\crc-windows-1.6.0-amd64>ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=NUL -i "C:\Users\jesaremi.crc\cache\crc_hyperv_4.3.0\id_rsa_crc"<EMAIL_ADDRESS>Warning: Permanently added 'api.crc.testing,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey,gssapi-keyex,gssapi-with-mic).
C:\crc-windows-1.6.0-amd64>where ssh
C:\Windows\System32\OpenSSH\ssh.exe

The ssh does not work. So doesn't oc debug node:
C:\crc-windows-1.6.0-amd64>oc whoami
kube:admin

C:\crc-windows-1.6.0-amd64>oc get nodes
NAME                 STATUS    ROLES           AGE       VERSION
crc-w6th5-master-0   Ready     master,worker   22d       v1.16.2

C:\crc-windows-1.6.0-amd64>oc debug node/crc-w6th5-master-0
error: cannot debug crc-w6th5-master-0: unable to extract pod template from type *v1.Node

@gbraad
So I wanted to recap here:
Thanks to your instructions I'm able to access the node using SSH, expand the disk and create my own hostPaths for PVs.
The only thing that is not working is the oc debug.
thanks

"C:\Users\jesaremi.crc\cache\crc_hyperv_4.3.0\id_rsa_crc"

you are using the wrong key. After startup, this key is replaced with a
machine specific key that in your case should be
"C:\Users\jesaremi.crc\machines\crc\id_rsa"
On Sun, Mar 8, 2020 at 1:03 AM Jeff Saremi<EMAIL_ADDRESS>wrote:

@gbraad https://github.com/gbraad
I think I'm just using the default ssh that comes with Windows. I don't
recall having that installed additionally:
C:\crc-windows-1.6.0-amd64>ssh -o StrictHostKeyChecking=no -o
UserKnownHostsFile=NUL -i
"C:\Users\jesaremi.crc\cache\crc_hyperv_4.3.0\id_rsa_crc"
<EMAIL_ADDRESS>Warning: Permanently added 'api.crc.testing,<IP_ADDRESS>' (ECDSA) to the
list of known hosts.
<EMAIL_ADDRESS>Permission denied
(publickey,gssapi-keyex,gssapi-with-mic).
C:\crc-windows-1.6.0-amd64>where ssh
C:\Windows\System32\OpenSSH\ssh.exe
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/1075?email_source=notifications&email_token=AAAAOZUJA3VFDS6ZEXH67DTRGJ455A5CNFSM4LDLZLUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOD6LIQ#issuecomment-596108706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZQDFDKL655M46FCE5TRGJ455ANCNFSM4LDLZLUA
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

Why oc debug would not work is not clear to me either. Have to admit I
haven't tried this recently.
On Sun, Mar 8, 2020 at 4:36 PM Gerard Braad<EMAIL_ADDRESS>wrote:

"C:\Users\jesaremi.crc\cache\crc_hyperv_4.3.0\id_rsa_crc"

you are using the wrong key. After startup, this key is replaced with a
machine specific key that in your case should be
"C:\Users\jesaremi.crc\machines\crc\id_rsa"
On Sun, Mar 8, 2020 at 1:03 AM Jeff Saremi<EMAIL_ADDRESS>wrote:

@gbraad https://github.com/gbraad
I think I'm just using the default ssh that comes with Windows. I don't
recall having that installed additionally:
C:\crc-windows-1.6.0-amd64>ssh -o StrictHostKeyChecking=no -o
UserKnownHostsFile=NUL -i
"C:\Users\jesaremi.crc\cache\crc_hyperv_4.3.0\id_rsa_crc"
<EMAIL_ADDRESS>Warning: Permanently added 'api.crc.testing,<IP_ADDRESS>' (ECDSA) to the
list of known hosts.
<EMAIL_ADDRESS>Permission denied
(publickey,gssapi-keyex,gssapi-with-mic).
C:\crc-windows-1.6.0-amd64>where ssh
C:\Windows\System32\OpenSSH\ssh.exe
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/1075?email_source=notifications&email_token=AAAAOZUJA3VFDS6ZEXH67DTRGJ455A5CNFSM4LDLZLUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOD6LIQ#issuecomment-596108706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZQDFDKL655M46FCE5TRGJ455ANCNFSM4LDLZLUA
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]


Do you need help with the 4.0 release?

I see that 4.0 is currently in beta, but there is not a lot of activity in the repository lately. So I am wondering if there is anything I can do to help out with the release?
I might be starting a new project in a couple of weeks and I would like to be able to use a stable 4.0 version of Overcoat.
I've also seen that you are looking for maintainers and I might be interested in becoming a maintainer, since I have been using Overcoat for a while and I have been very happy with it.

sure. thanks. I've added you into the team.
I'm still quite busy in following weeks, but there seems to be some issues fired by others about 4.0. If those are not critical one, I think it's ok to release 4.0 now.


NOTICKET Corejs config

Prevent corejs from being transpiled by Babel

Will shove this into 3.8.2 now


Up the code coverage.

Add test and removed unnecessary code.

@MiniGod done! With this change we'll break through to >90% coverage! :)


HeaderSuffixContent set to grid with 74 width

By default the headersuffix will take up 74px of space for no understandable reason.
This leaves a 74px gap of useless space in a tabheader unless overridden.
The default should be a grid of no size to allow the tabcontrolheader to take up all the space without having to specify a suffix.
The code:

<Setter.Value>

</Setter.Value>

Should be:

<Setter.Value>

</Setter.Value>

The reason it's there is because I was having trouble with sizing/measuring of the tab header strip, tabs pushing up - and then over - towards the standard Window buttons & scroll bars, all cuasing a bit of a layout issue.
Yes...it's not right, but there is some history behind it.
I'll try and revisit it, resolve the underlying issue and remove the default.

gotya .. i'm kind of in the same position now.
I'm trying to get the dragablzitemscontrol to size properly, and I got it to work partly, but that kind of stuff is always a pita.

I'll try and improve...

@mrfrostfire which style and window are you using?

I only need the dragablz for the ability to drag tabs around, so i've tried to keep it as native as possible.
So i'm just using it as a tabcontrol with ability to drag tabs around if that helps.

Btw, I used the MaterialDesign style as the base and have modified it to what we need it for.
There's still problems with the sizing though causing limitations due to the meassureoverride etc.
I get that the canvas is causing issues due to it not reporting any size. But can't that be solved by specifying it's width/height based on the content inside instead of having a meassureoverride on the itemscontrol etc?

The MeasureOverride in DragablzItemsControl is a pretty fundamental requirement to figure out how big the content is, according to the IItemsOrganiser; which is plug-able.

ok, then just replacing it might be a bit hard.
So here's the issue i'm currently at:
We want to have the tabs inside a scrollviewer to be able to do horizontal scrolling if there's not enough room to fit all the tabs into the area.
While doing that, we want to have the defaultaddbutton flowing to the right of the tabs as it is per default.
The addbutton however should be outside the scrollviewer as it should always be visible.
I haven't been able to find any combination of that scenario that works, since either the addbutton is pushed out because the itemscontrol takes up too much space, or it gets aligned wrong.
Do you have any suggestions?

Can you post a sketch of that?
My intent is to remove the default suffix, and rework the style a bit, so when I do that I'll try and get your requirement working.

Here's a pic of the header using styled dragablz before the scrollviewer is activated and after.
I hope that helps

And thanks!

Nice theme :+1:

Thanks :)

So yeah, turned out to be a 1 liner, where I wasn't measuring the default add button when calculating the size of the header strip, so incoming will give you this:

GitHub auto-closes issue...but please let me know if this is OK with your style...

i'll try it out asap .. probably tomorrow

Thank you! Worked like a charm.
Since I have the scrollviewer around the dragablzitemscontrol, I moved the maxwidth binding to the scrollviewer and bound the dragablzitemscontrols maxwidth to its own ItemPresenterWidth.
This makes sure to compensate for any additional size the scrollviewer might take up.

:+1:


Add JinWen University Taiwan

add my school to JetBrains
"JinWen University of Science & Technology"
thanks!

add my school to JetBrains
"JinWen University of Science & Technology"
thanks!


Limit votes for one user

Currently one can vote endlessly. Need some way that a user can only vote once.

Let's try localstorage.

Found https://github.com/hashobject/react-count. Tried to use it but the JSX transpiling failes…

Simple solution now…


Clean up tox

Why remove 3.7.0 though ?

@ofek @gmmeyer Do you guys have an answer for the above comment?

Short answer seems to be that 3.7 is not well supported at this point. Should be fixed in another PR


Not able to build the project

getting No Java Mission Control found error

your jdk version is too high.
java mission is removed
jdk 1.8.0_202 is work for me.
And here is link to download
https://www.oracle.com/java/technologies/downloads/#jre8-macos


docs(examples): spelling Labelmap Segmentation Locking

Context
A small spelling mistake
There are two "Labelmap Segmentation Swapping"
One of which should be "Labelmap Segmentation Locking"

Changes & Results

Testing

Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

[x] I have run the yarn build:update-api to update the API documentation, and have
committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] "OS:
[x] "Node version:
[x] "Browser:

@sedghi up


Preview Environment error in file

@Ladvien are these error related to?
Originally posted by @Victsz in https://github.com/Ikuyadeu/vscode-R/issues/22#issuecomment-354221889
I'm coming up with this problem as well. how can I preview the dataframe?

I am encountering this problem when using R: Preview Environment, which I believe is the command that was used in the above screenshot. R: Preview Dataframe works fine.
Steps to reproduce:

Create a new file 'temp.R' containing just the text 'iris'

Run command R: Create R Terminal

Run command R: Preview Environment

R: Preview Dataframe DOES work. Also, if the file is completely empty, R: Preview Environment works.
Windows 10 Home, Version 10.0.18362 Build 18362
VSCode 1.38.1
vscode-R 1.1.3

Works fine in Linux:
Ubuntu 18.04.2 LTS
VSCode 1.37.1
vscode-R 1.1.3
It looks like the screenshot above is also Windows, so I'm guessing it's a Windows issue.

Can confirm R: Preview Environment has same issue in RHEL7.  Oddly when I first invoked this command it complained saying it needed an extension, would I like to install.  I clicked yes, it seemed to install something and then the error below.  Subsequent calls does not complain of a missing extension, but looking at my installed extensions nothing new has appeared.  I cant remember what it wanted to install unfortunately.

write.csv(data.frame(name=ls(),class=sapply(ls(), function(x) {class(get(x, envir = parent.env(environment())))[1]}),out=sapply(ls(), function(x) {capture.output(str(get(Error in file(file, ifelse(append, "a", "w")) :  T)[1]})), '/home/h03/hadsx/extremes/ukcp/18ukcp/code/pp/tasmax/.tmp/environment.csv', row.names=FALSE, quote = TRUE)
cannot open the connection
In addition: Warning message:
In file(file, ifelse(append, "a", "w")) :
cannot open file '/home/h03/hadsx/extremes/ukcp/18ukcp/code/pp/tasmax/.tmp/environment.csv': No such file or directory

vscode-R 1.1.8
VSCode: 1.40.1
Commit: 8795a9889db74563ddd43eb0a897a2384129a619
Date: 2019-11-13T16:49:30.162Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 3.10.0-1062.4.3.el7.x86_64

@simonmcbrown Thank you for reporting this. I had thought it was just a Windows issue but evidently it can happen on Linux too.
The extension it prompts you to install is https://marketplace.visualstudio.com/items?itemName=GrapeCity.gc-excelviewer That is odd that it’s not showing up as installed though.

hmm.  Well OK, now it is there, gc-excelviewer that is.  The preview environment bug has not changed.

Same issue as @simonmcbrown on linux, ubuntu 18.04.

While experimenting with the Preview command problems I also found that even after installing the gc-excelviewer the message about it not being installed kept appearing. The message went away after restarting VSCode, but this seems like a bug.

I'm having the same issue
Version: 1.47.3
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:08:29.692Z (2 wks ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0
can't open the iris dataframe after following all installation instructions

can't Preview the cars dataframe after following all installation instructions. I get the following message "This does not appear to be a dataframe."

Created issue #389 for this.

In addition R: Preview Environment results in the following error:
Command 'R: Preview Environment' resulted in an error (Cannot read property '0' of undefined)

@tbkw I think this is a different problem. Can you create a new issue for this with a reproducible example? Thank you.

This issue was created first but there's more info in duplicate #257, so closing in favour of that.


Interleaved 2 of 5 with bearer bar not recognised

Recognition of interleaved 2 of 5 codes with a bearer bar fails when the second END_PATTERN_REVERSED is used (this will be the case when the barcode's wide to narrow ratio is 3).
After some debugging I found that when searching the end pattern the calculation of the narrow line width is wrong in this case because the length of the pattern is 5 in this case and not 4.
I managed to fix the issue by replacing line 159 in ODITFReader.cpp:
int narrowLineWidth = (end - begin) / 4;

by the following:
int patternLength = 0;
for( int i = 0; i < pattern.size(); ++i )
{
	patternLength += pattern[ i ];
}
int narrowLineWidth = (end - begin) / patternLength;

Thanks for spotting and debugging this!


Disable Query String (Treat as separate cacheable item) option in MaxCDN

Last month our cache hit percentage was 99.57% (68,789,568,942)
Making our non-cache hits 0.43% or 297,179,793 requests going back to S3.

This will prevent requests like this going back to S3:
GET /bootstrap-cdn/public/font-awesome/4.7.0/css/font-awesome.min.css?refresh=226?refresh=298?refresh=395?refresh=478?refresh=568?refresh=658?refresh=740?refresh=823?refresh=897...
@petarpetrovic will be tailing the edge logs for any possible issues.
Steps:

[x] Disable option
[x] Purge Cache
[x] Tail CDN/edge logs
[x] Monitor Twitter
[ ] Check S3 Logs
[ ] Examine S3 Billing

I confirm the change didn't affect the CDN delivery on any edge location. The assets have been cached successfully after the purge.

Twitter looks good

We still need more data but so far it is looking good:

Comparing Yesterday (Tue. 11-28-2017) to last Tue (11-21-2017) there is a 90.78% decrease in cost.

Looks good. Closing.


Texture / Face Problem with "normals"

There is another problem with objects and ("wrong") "normals". It's hard to describe. I describe this as an example of a raising block. Ingame the textures are not displayed correctly. There is a texture square divided with triangles. Look here:
WadTool:

It's a raising block from this wad from TRSearch:
https://www.trsearch.org/item/3948
I put the RB in its own wad.
rb.zip
Ingame it is display like this:

It has to be said that it worked in OG / TR4. It was shown correctly there.
Why is that no longer possible? Something seems to be wrong here.
If u need an *.ten to reproduce:
https://www.dropbox.com/s/4wvk7piyhgvx95e/Jungle_Feaver_FACE_BUG.zip?dl=1

it is an asset issue.
When normals are fixed, it works properly.


fix: new tier3 and tier4 root-sync and additional permissions for tier3

adding specific root-sync for tier3 and tier4
Grant GCP Project IAM Admin to GCP SA on Client Host Project
Grant GCP role Compute Security Admin to tier3-sa GCP SA
enable logging and monitoring API
add securitycontrols.md

Thanks Dave, this one I will review a bit more - eta later tonight


Email accound

Challenge Name

Issue Description

Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

@frutsy007 thanks for the issue. Can you give more information on what your issue is with your email account is?


pretrained model

hello，can you provoid prerained model，thanks very much，the file last.pth seems can not load

I deleted the pretrained model. I'll glad if you give feedback after trying to download.


Add resource requests and limits to kafka-webhook

The horizontalPodAutoscaler fails without set resources.
Proposed Changes

Add resources (values taken from serving, similar to eventing webhook defaults)
:bug: Allows for hpa to work for kafka-webhook

Release Note
The kafka-webhook deployment now sets resource requests and limits to enable hpa

/retest

@lberk FYI: https://github.com/knative-sandbox/eventing-kafka/pull/711

/cherry-pick release-0.23

/cherry-pick release-0.23


add main nav font awesome icons

Top nav should be rendered like so:

Signed-off-by: cosmicBboy<EMAIL_ADDRESS>TL;DR
Please replace this text with a description of what this PR accomplishes.
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin
[X] Docs

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

I think you should sequence it with this change? - https://github.com/flyteorg/flyteidl/pull/169

@cosmicBboy now you might have to rebase - but this is good, its all on rsts

@wild-endeavor @kumare3 @EngHabu rebased onto recent changes, need a +2


I can't set up communication with the cloud

it is not possible to set up communication with the cloud, when you press the sync key, the device goes into reboot

Try master


feat: show grey triangle when fields have a comment

It took me a while to find a somewhat suitable way to introduce this. Therefore I have left some comments in the PR to explain some of the quirks I encountered.
Known issue
The fact that currently POSTing values, comments, etc. for a dataset with an AOC is broken, also affects this feature. You can test datasets with just a default AOC. Custom forms work too.

I returned this PR to draft status because I discussed a slightly more elegant approach with @Birkbjo yesterday. It will need to be reworked quite a bit.

I explored the alternative solution turned out to come with some complications of its own. After discussing again with @Birkbjo we did identify some possible avenues for refactoring this app, but we also realised that in the current state of the codebase the current context-based solution introduced in this PR probably makes sense.


Added Typescript Support for Storyblok Bridge

I have added typescript support for Storyblok Bridge.
The code implements Declaration merging with global class which helps to fulfill the requirement for useStoryblok hook in a typesafe way.
This is being tried and tested here

👋 Hey @fgiuliani @alexjoverm .
Please review and merge 😊

Hey @imabp, to add full Typescript integration will require more work. Let me give you a few pointers:

We prefer having the source code in Typescript. In that way, types are autogenerated, better typed, and easier to maintain
Types can be more sophisticated/elaborated
More steps are needed to integrate Typescript (like a few changes in package.json) and we'd rather keep it in 1 PR since is not much work

So we can't accept this PR as it is now, but if you feel like these changes is something you can and want to do, feel free to go for it.

Thank you so much @alexjoverm !!
I was also thinking the same, so we can extend support for both the languages.
I have created a new issue for migrating to typescript: #4
Feel free to assign the work, would love to work on it!


Add Git workflow trivia questions / answers

Add questions to deck titled “Git” related to good git workflow, including common best practices, commands, etc here
Potential resources list here: https://help.github.com/articles/git-and-github-learning-resources/

I can add a couple. :slightly_smiling_face:

I'll also add some.

I added a few questions in regards to managing commits.


[BUG] - Autocomplete does not work when the clear button is hit.

NextUI Version
2.2.9
Describe the bug
When the user clicks on the autocomplete field and then hits the clear button, the field stops working. The user must click outside the field and then click in the input again to restore functionality. If the user tries to search for something, the popover will not appear.
Your Example Website or App
https://nextui.org/docs/components/autocomplete
Steps to Reproduce the Bug or Issue
1.Go to an autocomplete field with an item already selected.
2.Click on the input field.
3.Click on the clear 'X' button.
4.Without clicking outside the input, try to type something.
5.Notice that the popover does not appear.
Expected behavior
As a user, I expect that when I clear the field and then try to search for something, the list of options should appear. However, currently, when I clear the field and attempt to type something, nothing happens.
Screenshots or Videos
https://github.com/nextui-org/nextui/assets/60948283/27648907-8cd6-44ac-9e28-7746fcf00c31
Operating System Version
Ubuntu 22.04
Browser
Chrome

Facing the same issue.
Easily reproducible in controlled autocomplete example: https://nextui.org/docs/components/autocomplete#controlled
Any updates on this?

No longer reproducible in prod doc & main branch (v2.3.5).
issue2146-demo.webm


chore: Remove unnecessary information from response

SUMMARY
This PR removes unnecessary information from API responses.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

We need username in owners in order to determine if the user is the owner of a dashboard or chart, eg see:
https://github.com/apache/superset/blob/674da1b2095ff74f7bf82be795b065e2d9f1760a/superset-frontend/src/dashboard/util/permissionUtils.ts#L45
I'll add it back.


feat(php_fpm): track maximum active processes

What does this PR do?
The PHP-FPM status page also provides the "max active processes" statistic, which translates to the maximum number of processes that can be executed at once. This is particularly useful in understanding saturation within the PHP-FPM container, in a manner that allows horizontal scaling in a more intelligent way than the built-in CPU and memory metrics in Kubernetes. This pairs well with the Datadog External Metrics functionality as well
Motivation
We turned on the External Metrics functionality with Datadog. I wanted to implement saturation-based scaling signals that the Datadog Agent provides through the various php_fpm.* metrics, but unfortunately there isn't a metric yet for detecting the maximum number of workers yet. So, here it is!
Additional Notes
I've been going off of the status pages for our internal PHP-FPM pods, an example of the /status output:
{
  "pool": "www",
  "process manager": "dynamic",
  "start time":<PHONE_NUMBER>,
  "start since": 8056,
  "accepted conn": 3006,
  "listen queue": 0,
  "max listen queue": 0,
  "listen queue len": 511,
  "idle processes": 4,
  "active processes": 1,
  "total processes": 5,
  "max active processes": 9,
  "max children reached": 0,
  "slow requests": 0
}

I went with php_fpm.processes.max but we could change this to php_fpm.processes.max_active to tie it closer to the actual name.
Lastly, a support ticket was opened for this feature request
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Changelog entries must be created for modifications to shipped code
[x] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Thank you @FlorentClarret 🙏


Add social cards editing

Converted and simplified from Scrivito Example App.
I tried to stick with the original as closely as possible.
The styles look slightly different and may need some adjustments or rework.
Content todo
* [ ] Fill in the missing descriptions that cause validation warnings. Could be a follow-up.

[ ] Set relevant pages to index: Yes.

provide a working copy, where robotsIndex is set by most (or all?) pages.

All:
https://edit-beta.scrivito.com/d0a154d76edf2a7bd991fc658e700a1d~https://dave-social-cards.scrivito-portal-app.pages.dev/en?_scrivito_workspace_id=p902f870e3545df7&_scrivito_display_mode=view

[ ] FYI there are now also five pages with a description > 175. I can fix this as soon as I can create more working copies. 😉


Allow admins to use site during maintenance mode

Description
Allow admins to use the site while maintenance mode has been enabled.

Implemented in 84cfb30


Added trim action for bounded_int.

This change is

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 421 at r2 (raw file):

                BranchSignature {
                    vars: vec![],
                    ap_change: SierraApChange::Known { new_vars_only: false },

it can be true for the case where trimmed_value == 0, right?
Code quote:
new_vars_only: false


added kill switch

Fixes #23
On start, the default value is set as true
On toggle, value of the extensionToggle variable is changed and based on it's value, tabs are opened on alarm.

@DarshitJain04 resolve conflicts

@hirenchalodiya1 resolved merge conflicts


Implement "CreatePinGroup" function

Description of the feature
If I'm not mistaken, the CreatePinGroup function from the layout editor is currently not implemented in pyAEDT.
Steps for implementing the feature
Implement new API function in pyAEDT, to create Pin Groups in HFSS 3D Layout.
Useful links and references
HFSS help -> Layout scripting -> Other creation methods -> CreatePinGroup

@Marcel0000 , you can create pin_group in layout directly. Then, load it into Hfss3dlayout for analysis.
import pyaedt
edb = pyaedt.Edb(edbpath="design.aedb")
edb.siwave.create_pin_group_on_net("U1", "1V0", "PG_V1P0_S0")
edb.save_edb()
edb.close_edb()

pyaedt.Hfss3dlayout("design.aedb")

@ring630 Thanks for your reply!
I found this function in the meantime as well.
Do I understand it correctly that the strategy/architecture for pyaedt is to have some functions only for the edb module and not for the Hfss3dlayout module?

@Marcel0000. Yes. It is recommended to set up layout in Edb, and then load Edb into Hfss3dlayout for analysis and post-processing.


Add featured-content block

Based on the Featured Authors block.
This block references a Thought Leadership article and pulls the title, summary, and author(s) from the article.
It also has a couple of override properties for the summary and CTA text.
Also add dom-helpers.js to /scripts. This makes constructing HTML much simpler.
Jira ID: https://jira.corp.adobe.com/browse/EXLM-1546
Test URLs:
Before: https://main--exlm--adobe-experience-league.hlx.live/en/featured-content
After: https://feature-exlm-1546--exlm--rrusher.hlx.page/en/featured-content

Merged! Please raise the PR from the adobe-experience-league feature branch to main instead of directly raising from forked repo. I hope we are following this process for PR Merges.


Question: Run only when needed?

Hey!
I'm looking into starting to use Yabai, looks awesome by the way!  It boils down to that while programming, I'd rather use something like Yabai, but for day-to-day I want the native MacOS experience.

This is a trivial problem, honestly.  You could just start and stop the Yabai service on-demand:
brew services start yabai - yabai on
brew services stop yabai - yabai off
Alternatively though, from personal experience I think you'll start to integrate Yabai into your workflow, and it's easier to just toggle a space to Floating rather than BSP.  If you start dabbling with stacking that can become an invaluably powerful alternative to cmd-tab'ing.

You can set a space or more to float. Put this into your yabairc: yabai -m config --space 4 layout float. Then you can enjoy the native macOS experience in space 4, and when you miss yabai, you could switch to other spaces.

I use Yabai like this:
yabai -m config layout                       float ~ /.yabairc
and then you can change the layout of the current space/desktop by adding to your ~/.skhdrc something like:
ctrl + alt - a : yabai -m space --layout bsp
ctrl + alt - d : yabai -m space --layout float


EditorNode not valid in initialize_*_module

Godot version
4.0
System information
Windows 10
Issue description
It is currently impossible to access the EditorNode in initialize_*_module. This is due to the EditorNode being created in Main::start while initialize_*_module is called in Main::setup2 for all values of ModuleInitializationLevel.
I noticed this while trying to register a custom platform exporter in my module. I did not find any initialization step where EditorNode is valid. Personally I think it should be valid at the point our module is called with MODULE_INITIALIZATION_LEVEL_EDITOR
Note that it was possible to add custom platform exporters in godot 3.x when the module was initialzied.
Steps to reproduce
Create a custom module and call EditorExport::get_singleton() in MODULE_INITIALIZATION_LEVEL_EDITOR
Minimal reproduction project
No response

Uhh sorry my mistake. I was actually using add_init_callback before but it was crashing because create_from_image is now a static method that returns the texture instead and I mistakenly assumed that was because I was calling it in MODULE_INITIALIZATION_LEVEL_CORE


yt-dlp finds ffmpeg, but ffmpeg reported as being not installed

Checklist

[x] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.06.29 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Europe
Provide a description that is worded well enough to be understood
First of all: Sorry for reporting this as a broken site. I couldn't for the life of me find a category for an ordinary bug report. Also the "choose a different type." link on top does not list any. This was the closest I found.
Also, I did the -U - update before, so it was the latest version as of today, as you can see in the log.
The issue: At first it looks like ffmpeg was found and versions checked:
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\ffmpeg" -bsfs
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\ffprobe" -bsfs
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\avprobe" -bsfs
[debug] exe versions: ffmpeg 5.0-essentials_build-www.gyan.dev (setts)
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3

But then this:
ERROR: You have requested downloading the video partially, but ffmpeg is not installed. Aborting
Also I could swear that I managed to download a piece before, with the same setup and versions. Alas, I don't have the output of that run anymore.
I tried different versions of ffmpeg, to no avail:
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19044-SP0
[debug] Checking exe version: "C:/Program Files/_media/ffmpeg/bin\ffmpeg" -bsfs
[debug] Checking exe version: "C:/Program Files/_media/ffmpeg/bin\ffprobe" -bsfs
[debug] exe versions: ffmpeg 5.0.1-full_build-www.gyan.dev (setts), ffprobe 5.0.1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3

(This was a somewhat earlier attempt, with a different ffmpeg and yt-dlp, however with the same result and error message.)
I also tried both backwards and forwards slashes with the ffmpeg-location.
Thanks in advance for any insights offered.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['--verbose', '--continue', '--download-sections', '*00:00:00.00-05:00:10.00', '--split-chapters', '--ffmpeg-location', 'C:/Program Files/_media/TwitchLeech', 'https://www.twitch.tv/videos/1515612408']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out cp1252 (No ANSI), error cp1252 (No ANSI), screen cp1252 (No ANSI)
[debug] yt-dlp version 2022.06.29 [9d339c4] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.19044-SP0
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\ffmpeg" -bsfs
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\ffprobe" -bsfs
[debug] Checking exe version: "C:/Program Files/_media/TwitchLeech\avprobe" -bsfs
[debug] exe versions: ffmpeg 5.0-essentials_build-www.gyan.dev (setts)
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] [twitch:vod] Extracting URL: https://www.twitch.tv/videos/1515612408
[twitch:vod]<PHONE_NUMBER>: Downloading stream metadata GraphQL
[twitch:vod]<PHONE_NUMBER>: Downloading video access token GraphQL
[twitch:vod]<PHONE_NUMBER>: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] v1515612408: Downloading 1 format(s): 1080p60
[info] v1515612408: Downloading 1 time ranges: 0-18010
ERROR: You have requested downloading the video partially, but ffmpeg is not installed. Aborting
  File "yt_dlp\__main__.py", line 17, in <module>
  File "yt_dlp\__init__.py", line 921, in main
  File "yt_dlp\__init__.py", line 913, in _real_main
  File "yt_dlp\YoutubeDL.py", line 3249, in download
  File "yt_dlp\YoutubeDL.py", line 3225, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1411, in extract_info
  File "yt_dlp\YoutubeDL.py", line 1420, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1504, in __extract_info
  File "yt_dlp\YoutubeDL.py", line 1561, in process_ie_result
  File "yt_dlp\YoutubeDL.py", line 2630, in process_video_result
  File "yt_dlp\YoutubeDL.py", line 3008, in process_info
  File "yt_dlp\YoutubeDL.py", line 962, in report_error
  File "yt_dlp\YoutubeDL.py", line 894, in trouble

--ffmpeg-location only works for postprocessing. Duplicate of https://github.com/yt-dlp/yt-dlp/issues/2191


incorrect model name

I've also left an issue in the code sample repo, but note that in the first code snippet, when refactoring the Jupyter notebook to a Python file, the last instruction (joblib) attempts to save a model named "reg" - but in the code the model is named "reg_model".
the last line should be modified to:
joblib.dump(value=reg_model, filename=modle_name)
Thanks, Eyas

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb8ff963-c433-280f-e4ea-19082ae9017d
Version Independent ID: 8c4e82f2-40e5-6481-c80b-d6201ad312b2
Content: Convert notebook code into Python scripts - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-convert-ml-experiment-to-production.md
Service: machine-learning
Sub-service: core
GitHub Login: @bjcmit
Microsoft Alias: brysmith

@eyast Thanks for the feedback! We will review and update accordingly.

@eyast Thanks for the feedback. Raised PR #https://github.com/MicrosoftDocs/azure-docs-pr/pull/145419 for model name update.

@eyast We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Build Error on getAttr

I thought I double-checked everything before posting this, but it looks like I was somehow on the wrong branch of llvm-project.  I just switched and am rebuilding.  Sorry for the noise here!

I'm trying to build onnx-mlir, and I'm getting the following error:
[ 59%] Building CXX object src/Dialect/ONNX/CMakeFiles/OMONNXOps.dir/ONNXOps.cpp.o
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp: In member function ‘mlir::LogicalResult mlir::ONNXPadOp::inferShapes(std::function<void(mlir::Region&)>)’:
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp:2012:23: error: ‘getAttr’ was not declared in this scope; did you mean ‘getAttrs’?
 2012 |   Attribute padattr = getAttr("pads");
      |                       ^~~~~~~
      |                       getAttrs
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp: In member function ‘mlir::LogicalResult mlir::ONNXCastOp::inferShapes(std::function<void(mlir::Region&)>)’:
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp:2220:13: error: ‘class mlir::ONNXCastOp’ has no member named ‘getAttr’; did you mean ‘getAttrs’?
 2220 |       this->getAttr("to").cast<::mlir::TypeAttr>().getValue();
      |             ^~~~~~~
      |             getAttrs
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp:2220:48: error: expected primary-expression before ‘>’ token
 2220 |       this->getAttr("to").cast<::mlir::TypeAttr>().getValue();
      |                                                ^
/home/dan/onnx-mlir/src/Dialect/ONNX/ONNXOps.cpp:2220:50: error: expected primary-expression before ‘)’ token
 2220 |       this->getAttr("to").cast<::mlir::TypeAttr>().getValue();
      |                                                  ^
make[2]: *** [src/Dialect/ONNX/CMakeFiles/OMONNXOps.dir/build.make:82: src/Dialect/ONNX/CMakeFiles/OMONNXOps.dir/ONNXOps.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3562: src/Dialect/ONNX/CMakeFiles/OMONNXOps.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

Do you have any suggestions for what I might be doing wrong?
For what it's worth, here is the result of cmake .. from the onnx-mlir/build directory:
cmake ..

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at third_party/googletest/googlemock/CMakeLists.txt:45 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at third_party/googletest/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Found PythonInterp: /usr/bin/python3.8 (found version "3.8.5")
-- Failed to find LLVM FileCheck
-- git Version: v1.5.1-1302d2ce
-- Version: 1.5.1
-- Performing Test HAVE_STD_REGEX -- success
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX -- success
-- Performing Test HAVE_STEADY_CLOCK -- success
-- pybind11 v2.4.dev4
-- Could NOT find Java (missing: Java_JAVA_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVADOC_EXECUTABLE Java_JAVAH_EXECUTABLE Development)
-- Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_JVM_LIBRARY JAVA_INCLUDE_PATH JAVA_INCLUDE_PATH2)
CMake Warning at src/Runtime/jni/CMakeLists.txt:31 (message):
  Java Development component or JNI not found, JNI targets will not work

-- incl dir/home/dan/onnx-mlir/third_party/onnx/home/dan/onnx-mlir/build/third_party/onnx
-- Found PythonInterp: /usr/bin/python3.8 (found suitable version "3.8.5", minimum required is "3")
-- Parallel backend tests  : OFF (install pytest-xdist to enable)
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dan/onnx-mlir/build

Thanks!

It looks like this was all caused by having the wrong version of mlir.  Sorry again for the noise.  To any admin, feel free to delete this issue.


README.md: update piston_window version in example

I noticed that the piston_window crate in the README was out of date, so this PR brings it to the latest version in the GitHub repo.
I tested the example code with the newer crate, and it compiles and runs without issue.

Thanks!


Updating steps for the guid

The guide originally stated that there were some files in the GitHub repo for the Bottle project that aren't there, specifically a solution file.
Also updated some of the steps of getting started with the Web App development for Windows about cloning and opening the project.
This may need someone to go through and re-work the guide and verify the steps needed to get the project started.

Hi @MattTatoczenko, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@MattTatoczenko : Thanks for your contribution to the Azure documentation! The author, @huguesv, has been notified to review your proposed change.

This doc is deleted. #please-close


Missing language entries in Plugin InsertAudio (ES, CA)

Here you have the missing translation into Spanish and Catalan for plugin InsertAudio:
es: {
    insertAudio: 'Insertar Audio'
}

ca: {
    insertAudio: 'Inserir Audio'
}

Thank you for your contribution :)
This will be available in the release 2.27.1!


Delete emptyBot.dialog

Fixes #3175
Proposed Changes
Removed empty dialog file

Will consolidate this with another sample PR.


OCPCLOUD-2643: Bootstrap new manager for migration and sync controllers

This is the first step towards OCPCLOUD-2643 and I've picked it up because it allows forking off into two streams working on migration and sync controllers separately.
This adds a new manager that will eventually register the migration and various sync controllers we have yet to build.
It currently waits to see if the migration feature gate is enabled, and, if it is not, waits to be terminated.
When the gate is enabled, it will start the manager, however, the manager currently has no runnables so is effectively a no-op.
I've added the manager as a separate container within the existing deployment as previously discussed.

E2E is showing this is doing what I expect it to do
/approve

/retest-required

One comment on the go.mod needs to be addressed, but otherwise this looks good

/lgtm

/retest


Better RSS title

Curretly it says First X objects from category Y. This doesn't sound very cool. Better would be bare name of category.

Maybe category "godlike JSONField", can be used for RSS title?

It would be better to keep this as an attribute on category itself as exports are already in Ella core and therefore always present.
Does someone have any complains against putting syndication_title directly to the Category model?

Finally solved by JSONField...


Whether pinpoint can track microservices based on ServiceComb architecture？

I want to monitor a microservice system based on ServiceComb by pinpoint. Do I need to re-write a  plugin for that?

Hello, @JangNum
I'm not sure. But after searching for ServiceComb, I noticed that the framework uses spring cloud. If it's the case, it' may have some shortage of tracing with Pinpoint.
refer #5267

Hello, @JangNum
I'm not sure. But after searching for ServiceComb, I noticed that the framework uses spring cloud. If it's the case, it' may have some shortage of tracing with Pinpoint.
refering #5267

Thanks for your reply.I hava solved it by writing a plugin for ServiceComb.


INFINITY-1806 Reenable documented support for custom ZK location for kafka

Updates Kafka tests to exercise the support as well

retest this please (test took too long)

Velocity is green, merging: looks like the build last time tested everything but then this time realized that only Kafka code changed, but the non Kafka statuses were regardless carried over in a pending state.

Yeah, there's no way to remove statuses :(


Add setTextAlignment Method

This PR adds the 'setTextAlignment' method to the MaterialSpinnerBaseAdapter.java class.
This method is convenient in that it does not require the developer to create an entire custom adapter just to set text alignment.

Closing as abandoned repo.


Matthew graph work

added axes labels that change based on mode
changed colors on the graph and added a custom legend

can we change the background color to be lighter? hard to see graph


Cocoon with single form?

Is there a way to use cocoon to use a single form and items to a list of items?
For example, if I had an "ORDER" and on my Order edit page I could have a single drop down form that displays ITEMS and then adds selected items as editable objects (e.g.: adjust quantity, pricing, discounts, etc)  to an ORDER_ITEMS page that is rendered all in the same view?

It is a bit unclear what you are asking, because cocoon always uses a single form. So I am guessing you mean something else?
Things I do not understand in your description:

"items to a list of items" ??
"a single drop down form" ??
an ORDER_ITEMS "page" but rendered in the same view?

But, if I understand correctly, instead of having a single button to add a new element, you first want to select an item from a drop down, and then edit that item?
Not entirely sure if cocoon is the best solution, but I can think of a few solutions.
1. Use a dropdown and a single link_to_add_association button

add a dropdown with all items that can be added
add a link_to_add_association button
add a before-insert callback, that will look-up and set the correct values upon inserting, depending on the selected item (use ajax)

2. Add a link_to_add_association per item
I have no idea how many "item-types" you have (your example is probably intentionally left unclear, but that never helps in thinking about a solution)

add a link_to_add_association per type, and use the wrap_object option to build the form. No ajax needed now.

3. Refinement of 2.

hide all those added buttons
add a drop down and upon change it triggers the corresponding button

Sorry, my thoughts were a little jumbled yesterday. I tried to find documentation on the link_to_add_association button as you mentioned but only found items pertaining to cocoon.
Essentially, what I am trying to build is a form that allows for the selection of a category, that category is then used to display a second select object with a list of products that fall under that pre-selected category. Then an "add item" button that adds that product to a list of items below it.
From Railscast episode #196 and your advice I am pretty close. I've used attr_accessor to allow my quote form to display the category and products dropdowns on my form now and I have a link_to_add_fields that adds the editable form objects. However, I need to figure out a way to grab the selected options in the form and carry those values and then reset the options... Am I going about this the right way? I know cocoon uses a single form but it generates that form with every click, I simply need the single form rendered only once... I hope this makes better sense and that I could buy you a beer as I've used cocoon many times other ways and it's become one of my favorite gems.

Nathan, sorry for the trouble, I just realized that I shouldn't reference the product in case it's ever removed or destroyed and should just copy the name into an item_name column. I appreciate all the help and apologize for the run around.

Yep, the link_to_add_association is the command, from cocoon, that renders a link/button to add a new nested item.
Actually your explanation is still very confusing to me. Cocoon does not generate the form, it just inserts the partial with the nested children, which is rendered only once, server-side and copied when the link is clicked.
Maybe you should show me some code. Or maybe you should ask this on stackoverflow, where more people can help you.

Closed due to inactivity.


Small updates

Update readme with basic usage
Rename locationWriter with locationInterface
Add permission support
Full width in tablet and phone device

I haven already updated the README & did some changes.
So resolve your conflicts first. ;)

So resolve your conflicts first. ;)

Done.


added loading panel to paraview visualizer fixes #448

accesshelper fix for unknown workflows

I tested this out, work good. However, I think we need something a little bigger for the processing screen. This is what I see:

I think making it a little bigger and centering it?

added some styles to make the "loading" larger and centered

Current coverage is 59.31% (diff: 100%)

Merging #461 into release will not change coverage

@@            release       #461   diff @@
==========================================
  Files            59         59
  Lines          2839       2839
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1684       1684
  Misses         1155       1155
  Partials          0          0

Powered by Codecov. Last update eed8f7c...f4b92db

LGTM


Build packages for osx-arm64 architecture

Comment:
We don't currently build packages for the osx-arm64 (Apple Silicon/M1) architecture.  I've tried a few times and run into linker issues.
Latest in https://github.com/conda-forge/vl-convert-python-feedstock/pull/6

Done


how to run on windows

I see an executable folder in the source code release package after unzipping it.
this contains a '3scale' file. Tried to rename to '3scale.exe' but WIN10 complains the executable is not compatible.

The issue you mention should be in packaging repo: https://github.com/3scale/3scale_toolbox_packaging
Can you please close this one and open a new one on appropriate repo?


not work in IOS

Hi, I try using the plugin, i follow the steps, in android work fine, but in IOs don't work
I add the nuget in project and client follow the instructions
in appdelegate.cs i have:
`public override bool FinishedLaunching(UIApplication app, NSDictionary options)
{
HtmlLabelRenderer.Initialize();
		global::Xamarin.Forms.Forms.Init();

		LoadApplication(new App());

		return base.FinishedLaunching(app, options);
	}`

in "global::Xamarin.Forms.Forms.Init();" give me this error when lauch:
System.TypeLoadException Could not load type Plugin.HtmlLabel.HtmlLabel, Plugin.HtmlLabel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null while decoding custom attribute: (null)
Im new in Xamarin and C#, as said before in android work all ok
I hope can help me
S2

So, I just uploaded a new version. There was a problem with the Nuget package. I created a new project and installed version 1.0.3 and everything works. Let me know.

With the new version all work ok!   Great job

Great!


Caps lock is not working with Ubuntu

I have installed VSCode (version 0.10.8) in Ubuntu via umake, I can't write capital letters even if caps lock is turned on. Caps lock works fine in all other apps.

@segmentationfaulter I cannot reproduce. Is there any input field in VS Code where Caps Lock is honored (e.g. the find widget input, the F1 input) or is it not working anywhere?
Also, do you run Ubuntu in a VM, or have a special version of Ubuntu... or any other customizations you've done that could help us reproduce the problem.

@alexandrudima I tested it, the problem was being caused by this vim extension https://marketplace.visualstudio.com/items?itemName=vscodevim.vim
After uninstalling this extension, caps lock is working fine.


Add-on Stopped working - Impossible to pull again

Hi,
Having an issue with my HassIO instance, I had to opt for a fresh setup and restore a snapshot.  Following this, Remote-Backup didn't work anymore.  I've uninstalled it and now when trying to pull the image again, home-assistant.log is displaying the following error:
1_9-03-22 20:12:15 ERROR (SyncWorker_2) [hassio.docker.interface] Can't install fixated/remote-backup-armv7:0.3.2 -> 404 Client Error: Not Found ("pull access denied for fixated/remote-backup-armv7, repository does not exist or may require 'docker login'")._
Any idea?
Thanks for you help and this really great add-on!! ;-)

Me to
19-03-26 08:57:34 INFO (SyncWorker_16) [hassio.docker.interface] Pull image fixated/remote-backup-armv7 tag 0.3.2. 19-03-26 08:57:35 ERROR (SyncWorker_16) [hassio.docker.interface] Can't install fixated/remote-backup-armv7:0.3.2 -> 404 Client Error: Not Found ("pull access denied for fixated/remote-backup-armv7, repository does not exist or may require 'docker login'").

Ok, good news, I'm not the only one :)
Could it be related to something missing on docker side ?

Same error here, sorry for duplicate Issue posted.

I'm getting something similar. Had to restore addon from backup but causing errors in logs

missing "arch" key from config.json in hassio-addons repo and the addon itself.
Think that might be the issue causing the inability to pull

If this great add-on is not maintained anymore (which would be a pitty) you can have a look at this fork
https://github.com/carstenschroeder/hassio-addons.

If this great add-on is not maintained anymore (which would be a pitty) you can have a look at this fork
https://github.com/carstenschroeder/hassio-addons.

@gerard33 Thank you for forking this, it's a no brainer to get these backups of the SSD card. I installed the add-on however getting the following error when starting the docker container running hassio:
/usr/bin/hassio: line 1: Not: command not found
Is it possible that "Not:" is referenced somewhere because I have the command hassio installed in /usr/bin/hassio:
a0d7b954-ssh:~/config# which hassio
/usr/bin/hassio
Docker logs:
Adding SSH key Creating local backup: "Automated backup 2019-04-07 05:55" /usr/bin/hassio: line 1: Not: command not found Backup created:  Copying .tar to /mnt/backupdir/ on **mybackup.remotehost.com** using SCP Warning: Permanently added '[mybackup.remotehost.com]:22422,[<IP_ADDRESS>]:22422' (RSA) to the list of known hosts. .tar: No such file or directory

@gerard33 I just realized you didn't create that add-on so I submitted an Issue to the repository owner @carstenschroeder

Hi all,
I am sorry that I haven't been active at all. My situation is that I formed my own company and are very busy doing that. And I don't use hassio at this point anymore.
If there are anybody that wishes to maintain this then please let me know.

@mr-bjerre I would like to take this over.  Please let me know how you'd like to proceed.

@overkill32 great! Now I don't have experience with that kind of process. I suppose something like this? Let me know if you have other suggestions.

@mr-bjerre I also have not done a transfer before, but I agree that seems like the right instructions.

Hi,
@mr-bjerre or @overkill32 to fix the remote backup addon with the latest version of Home Assistant, you just need to add the following line
"arch": ["armhf", "armv7", "aarch64", "amd64", "i386"],
in the "config.json"
It fixed the remote backup addon version 0.3.2 with my install of HASSOS running Home assistant 0.91.3 on an Arch64 based ODroid C2.
Hope this will help others ;)

@overkill32 great! Now I don't have experience with that kind of process. I suppose something like this? Let me know if you have other suggestions.

@mr-bjerre I'm ready when you are.  I think you have to initiate the transfer.

@overkill32 I should have initiated a transfer of this repo now together with hassio-addons. Feel free to keep me mentioned :)

Repository transfer complete.  Will take me a bit to dig through backlog issues.   Open to input and PRs.

Hello everyone, it's still broken because now the "config.json" points to the wrong url on the old repo. I suggest that you clone also the hassio-addons repo as well and update the documentation.

I've created a pull request for the documentation update, you can also fork the repo I just fixed, hope it helps.
https://github.com/gervaso/hassio-addons

#25

@overkill32 : Looks like this issue has re-surfaced. I just tried to install it and got the below error:
 Can't install fixated/remote-backup-aarch64:0.3.2: 404 Client Error for http+docker://localhost/v1.41/images/create?tag=0.3.2&fromImage=fixated%2Fremote-backup-aarch64: Not Found ("pull access denied for fixated/remote-backup-aarch64, repository does not exist or may require 'docker login': denied: requested access to the resource is denied")


Update control-flow-expression-language-functions.md

Added difference between availability of adding comments in expressions between dataflow and pipeline expressions

#reassign:jonburchel
@jonburchel Can you find an appropriate reviewer for this one?

This change is merged now.  Thank you for your commitment to help us improve the docs, @NandanHegde15.
#please-close


Fix: Add instructions for building from source

For those who would prefer to build from source, it will be good to include the details in the documentation

This project has been publicly archived. Please visit github.com/openclarity or openclarity.io to discover our other projects!


Added 0728_Self_Dividing_Numbers

IMPORTANT: Please do not create a Pull Request without an issue.
All Submissions:

[x] I have read the CONTRIBUTING document.
[x] My code is written in Python3 and is ending with .py
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have checked that my submission does pass the test on LeetCode.com
[x] Does your filename follow the naming Conventions?
[x] Have you linked your PR to an Issue?

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Extremely Pythonic Solution
LeetCode Stats:
Runtime: 24 ms, faster than 100% of Python3 online submissions for Self Dividing Numbers.
Kindly assign the issue to me.
#222

Not assigned to the linked issue - please consider Contributing Guidelines

Not assigned to the linked issue - please consider Contributing Guidelines

Ok. Thank you.


pull request for e2e test at 02/02/2017 08:15:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Slovenian language

Thanks @zipavlin for your contribution!
Available from version 1.44.0

Thanks @zipavlin for your contribution!
Available from version 1.44.0

@antoniandre thanks for your awesome work!


[BLOG] Add Pulsar Summit Asia 2022 CFP blog

Motivation and Modifications
Add the Pulsar Summit Asia 2022 CFP blog. Replace https://github.com/apache/pulsar/pull/17218
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

Preview:

@codelipenghui @Anonymitaet @urfreespace @tuhaihe I submitted a new pr. I think this time it is ok to be merged. PTAL. Thanks.


lxd/images: Fix crash when no "info" struct

This fixes a crash happening when all of those conditions are met:

Clustered environment
Image is downloaded using the LXD protocol
Source image is marked as private
Image was downloaded previously to the cluster
The server processing the download doesn't have the image

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

@tomponline good to go


Jupyter kernel job ignores conf.py's sys.path

The job that is run on the kernel to execute each cell is not aware of the settings of sys.path that could have been set in the sphinx's conf.py file.
In my case, I set an additional sys.path in my conf.py to be able to load a newly built module in it's build directory (it does not exist on the system)
sys.path.insert(0, '<build_dir>/openturns')

Then when the jupyter kernel worker runs to execute the cells this setting is not passed and it throws an ImportError which results in a CellExecutionError.
I saw there's an nbsphinx_execute_arguments options option to pass kernel options, would it be possible to work around this by passing an option to the kernel that adds my custom dir to sys.path ?

Am I understanding correctly that your notebook wouldn't work in the Jupyter Notebook app nor when executed with nbconvert --execute?
So why would you expect it to work with nbsphinx then?
If you need any path manipulations for running your notebook, you should do them in the notebook.

My notebook is working when my module is installed in the python prefix, ie when an user installs it, but the failure I'm facing is when I'm developing the module and it's being built and not available on the system yet, ie it's not it /usr/lib/pythonxy/site-packages.

I see.
Did you check the check box "Install your project inside a virtualenv using setup.py install" in the "Advanced Settings" on RTD?
If you use conda, you should use one of those:
python:
  setup_py_install: true

python:
  pip_install: true

See also http://docs.readthedocs.io/en/latest/yaml-config.html.
BTW, with that, your doctests should also work, no need to manipulate the path in conf.py.
This is normally only used to find local (i.e. not installed) Sphinx extensions.

I do not build my project inside a virtualenv because it's mainly a C++ project, that provides Python bindings.

But you could do it ...?

I could also override PYTHONPATH in the sphinx process so the kernel process inherits it, which is easier.

Sure, this might work.
But why don't you want to install your package on RTD?
This way you could also test if the installation works outside of your local setup, which is an added bonus.

what's RTD ?
We already have continous integration.
Anyways, thanks for your input.

With RTD I mean readthedocs.org. I was assuming you are talking about this, but apparently I was wrong ...

Yes did not mention rtd, I'm trying to build my documentation locally.

OK, I see.
If you build it locally, you can just install your package before that, right?

That's the point of my ticket, it's not meant to be installed in the system right away, but in a temporary build dir.

OK, I see.
Automatically taking sys.path from conf.py is still the wrong way to solve this.
Does manipulating $PYTHONPATH work for you?

yes

OK, great!


Pre/Post processing in KFServing

/kind feature
In the real machine learning user experience, the service side could not always assume the client has the ability to prepare the well-formatted data or handle the response from the service. In this case, we need to consider put the pre and post processing into the picture of the service side.
Here comes 3 personas I want to make things more clear:
High-tier client. This kind of client has the ability to prepare the structured data payload and know how to handle the response from the service. It knows everything about the model, could be easily updated according to model update (especially input/output schema update). In this case, the service side does not need to care about how the request data generated, just consume it and give the response.
Low-tier client. This kind of client usually has limited capacity, like an IoT device (e.g. washing machine), or a device with limited battery (e.g. a low end smartphone). In this case the device almost could do nothing except upload the data and waiting for the service telling it what to do (e.g. beep when something bad happening). The service has to take care the data cleanup/format/etc. for each request and similar operations for response.
Mid-tier client. Client in between the high-tier and low-tier. They have capacity to do data manipulation, but sometimes the company wants to make data processing in a centralized place, or actually the data processing has IP to be protected by putting it in the service.
So I would like to have the community take this scenario into consideration and see if we could make the orchestration supporting user defined/provided pre and post processing container(s). This will also impact the data plane contract from KFServing.
Please share any thoughts about this scenario. Thanks!

Thanks @NonStatic2014! We have been discussing pre/post processing and planning to add this to KFServing v1alpha2 CRD.

@yuzisun how do you think about server vs client responsibilities/contract for pre/post?
For what @NonStatic2014 calls high tier - the client actually knows what the models needs (e.g. tensors in and out) so it can understand a predict dataplane on request and response
For low - client doesnt understand any model details and requires pre/post to act as an adapter - so the data contract is in client/scenario terms not in ML terms
For mid - the client may have its own format on request but understands higher level response schema elements like classifications, expln etc. So the request may be in client/scenario terms while the response may have some ML details.

/assign @yuzisun


derive: allow split up template attributes

In generated code or macros, it might be useful to emit multiple #[template] attributes. E.g.
 #[template(source = "Hello!")]
 #[template(ext = "txt")]
 struct Hello;

Nice add! Can you add a test like this please:
#[derive(Template)]
#[template(source = "bla")]
#[template(source = "bla")]
struct Foo;

Just to confirm the parsing of attributes is taking duplicates into account when they are not in the same attribute.

Just to confirm the parsing of attributes is taking duplicates into account when they are not in the same attribute.

That's done in https://github.com/rinja-rs/rinja/pull/117/files#diff-d2f7c348bb75850b1706f0efcd72e6b6c82baff6803d2e0aa5ca0521fe159ad2. Before it failed because there were two #[template]s, now in fails because the source is given twice.

Oh wow, how did I miss that... Sorry for missing it. Thanks!

Oh wow, how did I miss that...

Hehe, don't worry. I could have made the it more explicit bei adding a new test instead of changing the meaning of an existing one.


[desktop] NPE at com.frostwire.gui.bittorrent.BTDownloadMediator.doRefresh

6.3.1 build 186
java.lang.NullPointerException
        at com.frostwire.gui.bittorrent.BTDownloadMediator.doRefresh(Unknown Source)
        at com.limegroup.gnutella.gui.tables.AbstractTableMediator.refresh(Unknown Source)
        at com.limegroup.gnutella.gui.GUIMediator.refreshGUI(Unknown Source)
        at com.limegroup.gnutella.gui.RefreshTimer.refreshGUI(Unknown Source)
        at com.limegroup.gnutella.gui.RefreshTimer.access$000(Unknown Source)
        at com.limegroup.gnutella.gui.RefreshTimer$1.actionPerformed(Unknown Source)
        at javax.swing.Timer.fireActionPerformed(Unknown Source)
        at javax.swing.Timer$DoPostEvent.run(Unknown Source)
        at java.awt.event.InvocationEvent.dispatch(Unknown Source)
        at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
        at java.awt.EventQueue.access$500(Unknown Source)
        at java.awt.EventQueue$3.run(Unknown Source)
        at java.awt.EventQueue$3.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
        at java.awt.EventQueue.dispatchEvent(Unknown Source)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
        at java.awt.EventDispatchThread.run(Unknown Source)

This should avoid any crashes from happening on this doRefresh() method.
However, this does not find the cause of what could be null here.
My guess is that it has something to do with the new transfer view when it's by itself.


Per project settings

I don't think that's currently possible for packages to have their configurations overridden by the project settings (according to the doc), but I wonder if there's anything you can do as the developer of the extension.
My question comes from the fact that there's a setting called "tailwindCSS.rootFontSize" which allows to specify the root font-size so that the pixel values gets calculated and shown in the tooltips. This root font-size changes widely depending on the project and I'd like to be able to fix that with the ".sublime-project" file. In VScode there's workspace configs, but in Sublime the doc specifically states

Note that only settings in the category Editor Settings may be controlled by a project.

I don't know if that refers only to the "settings" key at the root level or if there's actually a way for users to override package configs. 🤔

LSP-* package settings can be overridden per-project. This should work in the project settings.
{
   // ...
	"settings": {
		"LSP": {
			"LSP-tailwindcss": {
				"settings": {
					"tailwindCSS.rootFontSize": 16
				}
			}
		}
	},
}

POG. Thanks so much, I tried various naming to construct my settings and test if it would work, but I probably never landed on it. 🔥

With https://github.com/sublimelsp/LSP-tailwindcss/pull/4 PR integrated and LSP-json installed there will be validation and auto-completion of settings, also within a project file. So that helps with discovery.


CAs being finicky

In Daedalus, desert area is wetter than beach area. Beach area is too cold.

Should be fixed with d0ee899e6bc0a775ccfc1f672a93e7a82e5ae1a1.


http://tools.ietf.org/html/rfc3986 is no longer a valid URL

tools.ietf.org seems to have been sold to someone else since 2006. 2006!!!

It seems to work only with https, try this link instead:
https://tools.ietf.org/html/rfc3986

Change to https


BUG: New file immediate file conflict error dialog

It happens almost every time for me... a new file created, make the block and then a warning of a file conflict.
After that, it does not seem to appear again too often.
IDE: PhpStorm 2024.1.5  Build #PS-241.18968.24, built on August 3, 2024
Plugin version: 0.2.6
Operating System: (LinuxMint) Kernel: 5.15.0-118-generic x86_64 bits: 64 compiler: gcc v: 11.4.0 Desktop: Cinnamon 6.0.4

Also have the same error.
My config is:
PyCharm 2024.2.3 (Professional Edition)
Build #PY-242.23339.19, built on September 26, 2024
Plugin version: 0.2.6 (the same as issue creator)
Operating system: Microsoft Windows [Version 10.0.19045.4894]

To workaround this issue, just save your work, close your IDE and start it again.


Flagr-UI Cannot Resolve Static Assets when using FLAGR_WEB_PREFIX environment variable

Expected Behavior
It is expected that if FLAGR_WEB_PREFIX environment variable is used that the UI will be able to retrieve its static assets (js/css files)

Current Behavior
In the index.html, all static resources are being retrieved starting at the root (e.g. /static/some.js )

Possible Solution
Wondering if it's possible to either set base href value to the value of FLAGR_WEB_PREFIX or to make references to assets relative rather than absolute in the web pack config. e.g. static/some.js instead of /static/some.js.

Steps to Reproduce (for bugs)

Run docker run -it -p 18000:18000 -e FLAGR_WEB_PREFIX='/foo' checkr/flagr
Navigate in web browser to localhost:18000/foo (ensure cache is cleared)
Note that index.html resolves correctly but all of the js/cs files receive 404s

Context
We are unable to use the flagr-ui behind our load balancer where the uri looks something like
www.domain.com/foo/flagr

Your Environment

Version used (flagr version):1.0.13
Server type and version:
Operating System and version (uname -a): Windows
Link to your project:

Thanks for reporting, pr to fix: https://github.com/checkr/flagr/pull/223

Wow that was fast! Thank you for making something so great.


Combined ROS and control libraries images

As I'm using the combination of ROS and control libraries quite often now, it would be nice to have those images prebuilt and pushed (same for modulo btw).
On top of the ROS workspace, control libraries (source, protocol, and python) is installed in the Dockerfiles. The branch of control libraries can be specified for the build.
Opening this as draft PR because I'm waiting for #190 and #198 on control libraries. Also we could discuss the name of this image. Should this be called modulo-base or similar? Would be a bit more catchy but also less clear what it is :smile:

This should be ready now, see my fork for the result

Waiting for that now


MB-14292 MB-14337 Service counselor can review expenses

Jira tickets for this change: MB-14337 and MB-14292
Summary
This PR adds the ReviewExpenses component to the Office document review flow. A service counselor can review, edit some fields of, and approve/exclude/reject expenses.
On all expenses, the amount can be edited. On storage type expenses, the SIT start and end dates can also be edited.
I added a move with both expense types and no other document sets: Expenses, PPMCloseout (CLOSE3). This move should be able to test all the scenarios in this PR. Note that the AllDocs, PPMCloseout (CLOSE2) move will not yet work end-to-end until this PR is merged and both tickets for Pro-gear review, MB-14336 and MB-14339, are complete.
Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Access the office app
Login as<EMAIL_ADDRESS>Under PPM Closeout, select Expenses, PPMCloseout (CLOSE3)
Click "Review Documents"
Review, edit, and accept/exclude/review the packing materials expense, then submit
Review, edit, and accept/exclude/review the storage expense, then submit
Note that the review panel accurately reflects the changes, as does using the Back button or revisiting the expense from the overview

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Messages

:book:
:link: MB-14292, MB-14337

  Generated by :no_entry_sign: dangerJS against bcb053973cb6c04d379105b14e3f3716cd34f7eb

@rileyorr
Good call! Sorry to overlook that one again, it's easy to miss in the code.
Errors for an empty Reason field should be there now, and I added tests for them on Expenses.

@scottmries no worries at all! I did another review and was able to see the errors.
I took a look at the Happo diffs and noticed that the 'After' for the top 3 show an error. I've never seen that before while reviewing Happo diffs so I was wondering if you had insight as to why that's occurring

@scottmries no worries at all! I did another review and was able to see the errors.
I took a look at the Happo diffs and noticed that the 'After' for the top 3 show an error. I've never seen that before while reviewing Happo diffs so I was wondering if you had insight as to why that's occurring

Hey @rileyorr this seems like a server issue that Happo might have captured a screen shot of. I've seen this before, over a year ago, and I'm combing through slack to see if I can find any conversations about why it occurred.

@rileyorr I fixed the error in Storybook, and the only differences in Happo now should be either trivial or the character count change.
@NamibiaTorres FYI, the fix was wrapping the component in MockProviders in its story.

@NamibiaTorres thank you for that context!
@scottmries thanks for making that change in Storybook! I took another look at the Happo diffs and noticed that the scenario for no advance being requested is displaying without the PPM header information and numbered receipt. I couldn't find a use case for no advance being requested to test in the local deploy to verify if the PPM header and receipt number will display. Is that something we need to look into for this PR?
I added a screenshot below for reference:

Ok, @rileyorr, now we're down to just the character count diff. Thanks for pointing those others out.

When I was editing the amount field, I put in 6,000 and received this error (ss below). Is this a correct error for the user to see?

Quick question @bellex3 , did you type in the comma when writing 6,000 or just the number 6000? I wonder if it'll be better to update the error message to not include commas when typing in numbers if that's the case. The user may find the current error message confusing. What do you think @scottmries @bellex3 ?

When I was editing the amount field, I put in 6,000 and received this error (ss below). Is this a correct error for the user to see?

Quick question @bellex3 , did you type in the comma when writing 6,000 or just the number 6000? I wonder if it'll be better to update the error message to not include commas when typing in numbers if that's the case. The user may find the current error message confusing. What do you think @scottmries @bellex3 ?

@NamibiaTorres No, I didn't input a comma. I typed in "6000"

@bellex3 and @NamibiaTorres The issue with the amount input is caused by the validation wanting a number when it should look for a string. I'll update it in the next commit.

@rileyorr I made the approve/reject/exclude labels bold on ReviewWeightTicket and ReviewExpense to match Belle's update on pro-gear. Did you want to do another Happo approval?


Improve file uploads

This PR includes following improvements:

Respect max_file_uploads from php.ini if available
Override is_uploaded_file and move_uploaded_file when possible, with a workerman compatible implementations
Respect upload_max_filesize from php.ini since PHP 8.2
Clean up uploaded temporary files for exceptional cases
Clean up session for exceptional cases

More details about overriding is_uploaded_file and move_uploaded_file
Since PHP 8.0, if a built-in function is disabled by disable_functions, it's possible to implement them in userland. As the master branch requires PHP 8.1, I think it's a good time to introduce this change.
Cleaning for exceptional cases
I understand that there is cleaning for uploaded files during desturction. However, this is based on $_FILES. There is chance that a temporary file is creatd but not loaded into $_FILES.
Besides, this PR also includes a fallback cleanup for uploaded files and sessions.

Thank you for you pull request.
I don't think compatibility with is_uploaded_file move_uploaded_file in Workerman is a good idea. If developers do not disable them in php.ini, it will result in bugs that are difficult to find. Workerman provides a unified API for handling uploaded files, and there is no need to be compatible with PHP-FPM specific APIs.
If we need to be compatible with PHP-FPM specific APIs, I prefer to create separate projects such as adapterman, which not only overwrite is_uploaded_file move_uploaded_file, but also further overwirte functions such as header() cookie() .

Sorry for the late reply.

Workerman provides a unified API for handling uploaded files, and there is no need to be compatible with PHP-FPM specific APIs.

I don't think this is a PHP-FPM specific API. Actually all web SAPI implement these functions.
IMHO it's not a good idea to let third party library to implement these two functions. To implement these two functions, the internal states of file uploading needs to be maintained and accessed. In our case, workerman is the one doing the web server's job, including handling file upload. So either third party library rewrites the http handling part, like what adapterman is doing currently (which I don't really agree with -- don't try to reinvent the wheel), or workerman handle related functions.

I'll leave this PR as is. Feel free to close/cherry-pick/modify.
Understood that you prefer not to override the built-in functions in workerman. However, as I explained in my last comment I believe this is something should be handled together with the processing of file upload. This PR is one approach but there are other options as well, e.g. exposing necessary variable/functions for others to check, or some configurations for users to decide the behavior.

Don't get me wrong. Workerman is a great project and thanks for your work. I'm here because I was looking for a solution to keep my laravel application in memory, and I chose adapterman. However, now I decided to move to other solutions, so continuing my contributions here would hold little significance for me.

Thank you for your understanding.
Workerman's HTTP protocol parsing needs to consider concurrency situations, such as when using asynchronous or fiber. So it is necessary to process the corresponding request data(including uploading files) through a specific request instance, otherwise it will cause data confusion.
If in order to be compatible with third-party libraries, only overwrite is_uploaded_file() and move_uploaded_file() is not enough, it also requires rewriting a series of functions such as header cookie  session and the super variables $_GET $_POST $FILES etc. Adapterman is a good choice.


Fix edge routing for child/grouped nodes

Edge-routing to child/grouped nodes (i.e. nodes with a parent node) seemed to be offset - I believe this is because reactflow sets child node positions to relative values to their parent node. This change uses the positionAbsolute if it's defined (e.g. for child nodes), otherwise it uses position (e.g. for nodes without parents).

@a3ng7n Thank you for the PR :) I hadn't tested the scenario with grouped nodes previously. Appreciate your fix!


Break apart malloc interface and implementation

This should make it easier to replace the allocator implementation, and also to test and analyze.

I didn't move anything into amd64 that wasn't there already.  The malloc.c file contains functions that were in qmalloc.c.  Perhaps I'm looking at the wrong area?  Is this not the allocator you suggested replacing?

yeah you're right. OK, I guess this is fine at least for measurement. The 'always zero' behavior is something we did early on and I don't want to change it without testing.
Did you boot and test with this yet?

I've been testing in qemu.  So far seems fine.  If the intended behaviour is to always clear for both malloc and mallocz I can add that behaviour back in - I removed it because it looked like a typo.

I'd feel a wee bit happier if we had a solid regression test first. malloc changes can result in very weird bugs. Could you do a test? See the regression test device which should let you poke sticks at malloc in all kinds of ways.

I'd feel happier too - I'm looking at tests ATM, so it's good to get some feedback before going further down the path.


does query planning is a way to handle bad query planning by database ?

I was reading https://join-monster.readthedocs.io/en/latest/query-planning/
and wandered why making a two step request should be faster than a single step request with a correct query planning by the database.
Maybe I'm wrong, In an ideal world the query planer of the database should decompose the initial request in the same way that it is done in the two part request.
Of what I understand of RDBMS, if the one step request is slower than second one is because the database query planer fail for example because the statistics off the database are not good enough.

From https://join-monster.readthedocs.io/en/latest/query-planning/:

This mitigates the exponential increase in the number of rows per join

Using the same single join example, as the join starts from the user, suppose there are 20 followers and 10 posts for that user, with 5 comments per post and 2 likes per comment, you'll have 1x20x10x5x2 rows (users x followers x posts x comments x likes) in that query, 2,000 rows with 18 fields each so you'll end up with 36,000 cells in your result set.
In the split queries, the first query would return 1x20x10 (users x followers x posts) = 200 rows with 10 fields each so 2,000 cells and the second one would return 5x2 (comments x likes) = 10 rows with 9 fields each so 90 cells.
The example is small but as the quoted statement said: it increases exponentially.
I'm ignoring how the database query planner works because it's interesting to avoid all this footprint to reduce bandwidth, traffic, memory, data type conversions and so on.

I understand, it multiplies because there is n followers and m posts for each user. It is the fact you have to independent 1-n relation ship that bring the overload. Maybe such situations could be detected automatically by the software.


ArrayIndentationFixer - nested associative array issue

I've tracked it down to this refactor: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4878
@julienfalque any advice on how to fix this bug?

Thank you @kubawerlos.