Release a new major - v7.0.0

Todo:

[ ] set default entry point to sweetalert2.all.min.js (https://github.com/limonte/sweetalert2/issues/612#issuecomment-333306384)
[ ] useRejections should be false by default (https://github.com/limonte/sweetalert2/issues/485)
[ ] display: flex for buttons-wrapper (https://github.com/limonte/sweetalert2/issues/653)

@limonte What time frame are you looking at for this release?
It would be nice to have the expectRejections option also in the current major (v6) before changing the defaults for both to false, though not totally necessary.

I think it would be easier for users to adapt to both of these changes to default behavior in one step rather than 2, since they are very similar.

@mattbrunetti That could be implemented right into version 7, right? I guess we're not that hurry ;) (oh and uh, can you just edit your comment to a link about the discussion? Can't find anything about expectRejections here https://github.com/limonte/sweetalert2/search?q=expectRejections&type=Issues&utf8=✓)

@toverux You're right, I guess there is no need to implement it in v6 at all.
Great, if this release can wait a few days, I will plan to close off #485 this weekend :)
@toverux See my edited comment and let me know if it makes sense

Great, if this release can wait a few days, I will plan to close off #485 this weekend :)

Absolutely! Many thanks, @mattbrunetti!

@limonte note that .buttons-wrapper will transition to flex at the completion of #670

@samturrell @toverux @acupajoe

set the default entry point to sweetalert2.all.min.js

in the next major, should we set the default entry point to sweetalert2.all.js instead of sweetalert2.all.**min.**js? It would be easier for developers to debug and report issues.

Agreed. The main entry is, by convention, expected to lead to a non-minified file. You then minify yourself in the build process, in production mode.
.min.css and .min.js files are more likely to be used via CDNs and by users that don't use the npm package.

Agree with @toverux.

in https://github.com/limonte/sweetalert2/pull/693 we're discussing dropping useRejections in the new major, any objections?

Quick update: almost there, the only one remained PR I would like to be included in v7.0.0 is https://github.com/limonte/sweetalert2/pull/674
@mattbrunetti what do you think, will you have time to polish it accordingly to the @toverux's latest comment?

@mattbrunetti Absolutely, I'll do so at lunch today

oops, accidentally closed the issue :)
Many thanks @mattbrunetti!

:tada: :tada: :tada:
https://github.com/limonte/sweetalert2/releases/tag/v7.0.0
:tada: :tada: :tada:
All collaborators should have the edit permission for release notes, feel free to add/change if I forgot something to mention.
@zenflow you are the collaborator now, welcome! It's my pleasure to have you in this small but extremely efficient open-source team :sunglasses: Do you have a public email address so I can include it in the collaborators section of package.json?

Yeah! Thanks to the people who have contributed on v.7!

@limonte @toverux @birjolaxew @samturrell @acupajoe @patrickhlauke Thank you for accepting me on this very excellent team! It is really an honor. I very much look forward to working more with all of you! 😄
@limonte Awesome! You can use this email address -<EMAIL_ADDRESS>👍

Annnd I'm also happy to annouce that v7 allowed ngx-sweetalert2's v3 to do its coming out: https://github.com/toverux/ngx-sweetalert2/releases/tag/v3.0.0
It's quite of a big release too -- if you were wondering why I'm comitting so little on Swal2, that's because I prefer to give some help here (in issues, reviews, advices, etc) and focus my developement efforts on the Angular integration.
That v3 has an interesting feature, too: using dynamic, Angular-managed DOM in SweetAlerts:
<swal title="Fill the form, rapidly">
  <!-- This form will be displayed as the alert main content
       Targets the alert's main content zone by default -->
  <form *swalPartial [formControl]="myForm">
    ...
  </form>

  <!-- This targets the confirm button's inner content
       Notice the usage of ng-container to avoid creating an useless DOM element inside the button -->
  <ng-container *swalPartial="swalTargets.confirmButton">
    Send ({{ secondsLeft }} seconds left)
  </ng-container>
<swal>

Again, thanks again to all the contributors! This is a small library with a very limited scope, and yet, it helps many people (100K DL/mo), and federated a group of passionate contributors, thanks to our benevolent dictator for life @limonte :smile:

Congrats @toverux! The release notes for v3 looks professional :+1:

And, thanks again to all the contributors! This is a small library with a very limited scope, and yet, it helps many people (100K DL/mo), and federated a group of passionate contributors, thanks to our benevolent dictator for life @limonte

:laughing:


Multiselect plugin validation

Hi. I have a form with with several controls. One of them is a multiselect, for which Im using a plugin. I want to validate that at least one option is selected, so I implemented the following:
JS:
$.fn.validator.Constructor.VALIDATORS.validateMultiselect = function ($el) {
var arrSelect = $el.val()
return (arrSelect != null && arrSelect.length != 0);
}
HTML:

On a submit the validation is working, but I dont get the error message. I do get error messages for the other controls.
Pleasy any thoughts of what I am missing?
Gracias.

Sorry this is late, but the custom validator name doesn't get converted from dasherized-name to camelCaseName for you. You need to name it just multiselect and tag your element with data-multiselect="true"


[kubeflow 1.8] chore: add release team members to org

I would like to request the following members to be added to the Kubeflow org.

@Davidnet and @nohaihab, who are currently part of the release team as liasons
@helloericsf, who has been part of the release team since Kubeflow 1.7 and has participated in the integration between Kubeflow and BentoML.

I'm making this request because they have to be added to the release team (#603), but the CI is failing due to these people not being in the org.
cc: @jbottum @annajung

/lgtm
/approve


CU-861n12akt_self-signed-bugfix_Alok-Hom

self signed fix

Task linked: CU-861n12akt self signed bugfix


fix(*): SQLServerStatementImpl导入DbType

SQLServerStatementImpl未导入DbType导致编译不通过

Codecov Report
Patch coverage: 44.86% and project coverage change: -0.02 :warning:

Comparison is base (2de6148) 58.80% compared to head (a1d643d) 58.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5138      +/-   ##
============================================
- Coverage     58.80%   58.79%   -0.02%
- Complexity    26947    27033      +86
============================================
  Files          1279     1282       +3
  Lines        123242   123612     +370
  Branches      23200    23283      +83
============================================
+ Hits          72478    72682     +204
- Misses        41711    41849     +138
- Partials       9053     9081      +28

Impacted Files
Coverage Δ

core/src/main/java/com/alibaba/druid/VERSION.java
50.00% <ø> (ø)

...om/alibaba/druid/pool/DruidAbstractDataSource.java
81.18% <0.00%> (+0.31%)
:arrow_up:

.../com/alibaba/druid/pool/DruidPooledConnection.java
81.77% <0.00%> (ø)

.../src/main/java/com/alibaba/druid/sql/SQLUtils.java
40.13% <0.00%> (ø)

...ql/dialect/presto/visitor/PrestoOutputVisitor.java
26.66% <0.00%> (-13.34%)
:arrow_down:

.../main/java/com/alibaba/druid/sql/parser/Lexer.java
60.16% <0.00%> (-0.34%)
:arrow_down:

...a/com/alibaba/druid/sql/parser/SQLParserUtils.java
8.65% <1.28%> (-1.59%)
:arrow_down:

...n/java/com/alibaba/druid/pool/DruidDataSource.java
71.27% <8.33%> (-0.35%)
:arrow_down:

...alibaba/druid/sql/repository/SchemaRepository.java
59.09% <18.42%> (-2.71%)
:arrow_down:

.../com/alibaba/druid/pool/DruidConnectionHolder.java
74.15% <20.00%> (-11.37%)
:arrow_down:

... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Error Cannot read property 'nextSibling'

I see the following error in mattermosts log file since I started to use electron-mattermost (1.3)
[2016/02/14 10:04:41 CET] [EROR] /api/v1/admin/log_client:client code=500 rid=... uid=... ip=... msg: Uncaught TypeError: Cannot read property 'nextSibling' of undefined row: 53 col: 23 stack: TypeError: Cannot read property 'nextSibling' of undefined url: /Applications/electron-mattermost.app/Contents/Resources/app/browser/webview/mattermost.js [details: ]

It will be fixed at next release. Thanks.

Fixed at 75bfb11.


Android - OnAppering, OnDisappearing not working

This functions and event not working. When a pop-ups appear or disappear They are don't be triggered.
 `	public MyPopup()
{
	InitializeComponent();
	this.Appearing += LoaderState_Appearing;
	this.Disappearing += LoaderState_Disappearing;
}

private void LoaderState_Disappearing(object sender, EventArgs e)
{

}

private void LoaderState_Appearing(object sender, EventArgs e)
{

}

protected override void OnAppearing()
{
	base.OnAppearing();
}

protected override void OnDisappearing()
{
	base.OnDisappearing();
}`

Workaround
 `	public MyPopup()
{
	InitializeComponent();
	MopupService.Instance.Popping += Instance_Popping;
	MopupService.Instance.Pushing += Instance_Pushing;

}

private void Instance_Pushing(object sender, Mopups.Events.PopupNavigationEventArgs e)
{
	if (e.Page is MyPopup)
	{
                    //appering
            }
}

private void Instance_Popping(object sender, Mopups.Events.PopupNavigationEventArgs e)
{
    if (e.Page is MyPopup)
    {
                   disappering
    }
}`

@mbilalbenli
This is definitely an important one, i'll add it to the list thanks for that bug report

@mbilalbenli
I realised I added a commit to fix this, but never released, I'll do that ASAP my apologies


[Event Request] table 7003 "Price Asset" - OnElseUnitOfMeasureCode

We would like to add a new event OnElseUnitOfMeasureCode in the following trigger:
        trigger OnValidate()
        var
            ItemUnitofMeasure: Record "Item Unit of Measure";
            ResourceUnitofMeasure: Record "Resource Unit of Measure";
            UnitofMeasure: Record "Unit of Measure";
        begin
            if "Unit of Measure Code" <> '' then
                case "Asset Type" of
                    "Asset Type"::Item:
                        begin
                            TestField("Asset No.");
                            ItemUnitofMeasure.Get("Asset No.", "Unit of Measure Code");
                        end;
                    "Asset Type"::Resource:
                        begin
                            TestField("Asset No.");
                            ResourceUnitofMeasure.Get("Asset No.", "Unit of Measure Code");
                        end;
                    "Asset Type"::"Resource Group":
                        begin
                            TestField("Asset No.");
                            UnitofMeasure.Get("Unit of Measure Code");
                        end;
                    else
                        //Error(AssetTypeForUOMErr); //A101F0000.Event.o
                        OnElseUnitOfMeasureCode(Rec); //A101F0000.Event.n
                end;
        end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnElseUnitOfMeasureCode(var PriceAsset: Record "Price Asset")
begin
    //A101F0000.Event
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Didn't see the correct folder

there is only a folder name "incorrect" in the result folder,if there is anyone know what's happen?

My log.txt is follow:
2017-12-16 15:46:09,037 root  INFO     step_time: 0.036033, loss: 3.724525, step perplexity: 41.451547
2017-12-16 15:46:09,052 root  INFO     0.000000 out of 991 correct
2017-12-16 15:46:09,233 root  INFO     step_time: 0.180325, loss: 3.672713, step perplexity: 39.358533
2017-12-16 15:46:09,272 root  INFO     0.000000 out of 992 correct
2017-12-16 15:46:09,307 root  INFO     step_time: 0.034654, loss: 3.741922, step perplexity: 42.178996
2017-12-16 15:46:09,315 root  INFO     0.000000 out of 993 correct
2017-12-16 15:46:09,351 root  INFO     step_time: 0.035934, loss: 3.772001, step perplexity: 43.466967
2017-12-16 15:46:09,361 root  INFO     0.000000 out of 994 correct
2017-12-16 15:46:09,429 root  INFO     step_time: 0.064732, loss: 3.741543, step perplexity: 42.162990
2017-12-16 15:46:09,458 root  INFO     0.000000 out of 995 correct
2017-12-16 15:46:09,498 root  INFO     step_time: 0.038936, loss: 3.721210, step perplexity: 41.314354
2017-12-16 15:46:09,513 root  INFO     0.000000 out of 996 correct
2017-12-16 15:46:09,565 root  INFO     step_time: 0.050532, loss: 3.666165, step perplexity: 39.101668
2017-12-16 15:46:09,596 root  INFO     0.000000 out of 997 correct
2017-12-16 15:46:09,661 root  INFO     step_time: 0.055440, loss: 3.703670, step perplexity: 40.596020
2017-12-16 15:46:09,677 root  INFO     0.000000 out of 998 correct
2017-12-16 15:46:09,711 root  INFO     step_time: 0.033894, loss: 3.758518, step perplexity: 42.884833
2017-12-16 15:46:09,725 root  INFO     0.000000 out of 999 correct
2017-12-16 15:46:09,754 root  INFO     step_time: 0.027922, loss: 3.596800, step perplexity: 36.481293
2017-12-16 15:46:09,768 root  INFO     0.000000 out of 1000 correct
2017-12-16 15:46:09,817 root  INFO     step_time: 0.045393, loss: 3.715956, step perplexity: 41.097876
2017-12-16 15:46:09,834 root  INFO     0.000000 out of 1001 correct
2017-12-16 15:46:09,869 root  INFO     step_time: 0.034558, loss: 3.739633, step perplexity: 42.082537
2017-12-16 15:46:09,879 root  INFO     0.000000 out of 1002 correct
2017-12-16 15:46:09,911 root  INFO     step_time: 0.031293, loss: 3.674526, step perplexity: 39.429952
2017-12-16 15:46:09,923 root  INFO     0.000000 out of 1003 correct
2017-12-16 15:46:09,956 root  INFO     step_time: 0.031391, loss: 3.645304, step perplexity: 38.294411
2017-12-16 15:46:09,964 root  INFO     0.000000 out of 1004 correct
2017-12-16 15:46:10,014 root  INFO     step_time: 0.045758, loss: 3.685593, step perplexity: 39.868763
2017-12-16 15:46:10,026 root  INFO     0.000000 out of 1005 correct
2017-12-16 15:46:10,057 root  INFO     step_time: 0.030331, loss: 3.654885, step perplexity: 38.663058
2017-12-16 15:46:10,070 root  INFO     0.000000 out of 1006 correct
2017-12-16 15:46:10,100 root  INFO     step_time: 0.030195, loss: 3.647512, step perplexity: 38.379049
2017-12-16 15:46:10,110 root  INFO     0.000000 out of 1007 correct
2017-12-16 15:46:10,154 root  INFO     step_time: 0.042073, loss: 3.713620, step perplexity: 41.001973
2017-12-16 15:46:10,175 root  INFO     0.000000 out of 1008 correct
2017-12-16 15:46:10,211 root  INFO     step_time: 0.035314, loss: 3.659956, step perplexity: 38.859632
2017-12-16 15:46:10,218 root  INFO     0.000000 out of 1009 correct
2017-12-16 15:46:10,254 root  INFO     step_time: 0.035393, loss: 3.668833, step perplexity: 39.206117
2017-12-16 15:46:10,267 root  INFO     0.000000 out of 1010 correct
2017-12-16 15:46:10,305 root  INFO     step_time: 0.036534, loss: 3.826706, step perplexity: 45.911055
2017-12-16 15:46:10,319 root  INFO     0.000000 out of 1011 correct
2017-12-16 15:46:10,379 root  INFO     step_time: 0.058488, loss: 3.657184, step perplexity: 38.752050
2017-12-16 15:46:10,392 root  INFO     0.000000 out of 1012 correct
2017-12-16 15:46:10,428 root  INFO     step_time: 0.033963, loss: 3.701324, step perplexity: 40.500882
2017-12-16 15:46:10,442 root  INFO     0.000000 out of 1013 correct
2017-12-16 15:46:10,474 root  INFO     step_time: 0.030381, loss: 3.658771, step perplexity: 38.813604
2017-12-16 15:46:10,486 root  INFO     0.000000 out of 1014 correct
2017-12-16 15:46:10,520 root  INFO     step_time: 0.032638, loss: 3.768634, step perplexity: 43.320852
2017-12-16 15:46:10,528 root  INFO     0.000000 out of 1015 correct

I didn't change anything about the code,so it really puzzle me

I didn't change anything about the code,so it really puzzled me

Obviously,the picture in the incorrect folder didn't have any change,there is 30 pictures in the sample folder which is exactlly same

I got the same issue. Please Help

Obviously

Obviously you need then model  wget http://www.cs.cmu.edu/~yuntiand/model.tgz
tar zxf model.tgz


Fix cubic_slerp()

Co-authored-by: K. S. Ernest (iFire) Lee<EMAIL_ADDRESS>Co-authored-by: Pasi Nuutinmaki<EMAIL_ADDRESS>If the angle is very small or very large, the interpolation is approximated by directly interpolating the quaternion elements, and in all other cases, ExpMap is used to interpolate more closely to the slerp.
This hybrid method is a tentative compromise since we could not solve the problem of incorrect flips in the ExpMap when the angle is large, but it allows the rotation path to use the shortest distance consistently and provides a much improved interpolation than the current broken cubic_slerp().
Comparing the direct quaternion interpolation approximation with that using ExpMap, you can see in the video below that ExpMap correctly applies cubic interpolation to the rotation angles.
https://user-images.githubusercontent.com/61938263/180642977-574f1bc2-8323-4a0d-9bea-a2c7dacfb389.mp4
In the case of the sample project of https://github.com/fire/godot-40592, about 75% of the interpolation is done by ExpMax. I have not found any problems with switching between these interpolations so far.
Bugsquad edit:
Fixes: #57951
Fixes: #40592
Supersedes: #63287, #59707.

Okay, I think it is ready to go now.
@GNSS-Stylist This flip decision uses your approach, thank you very much for your help! Please check if there are no problems if you can.

Changed comment line and variable names to make them easier to understand.

Change some values type float to real_t in Quaternion.

Why to use different interpolation methods based on flipping as flipped quaternions represent identical orientations? Added a new animation track test project that is otherwise identical with the cubic_slerp-track, but the dot-product of subsequent quaternions is always <= 0 (manually flipped some quaternions): https://github.com/godotengine/godot-tests/pull/25 . This should cause the interpolation always use exp-map-version with the new animation track.
There seems to be some flipping problems with this new track:
https://user-images.githubusercontent.com/50438441/180715218-9d2d7af7-d179-4783-bbc2-99cc387af00c.mp4
When comparing with non-pre-flipped version the interpolation seems to take a different path:
https://user-images.githubusercontent.com/50438441/180715315-b649285b-8b25-4953-b762-85eca371b046.mp4
Component-wise cubic interpolation ( https://github.com/godotengine/godot/pull/63287 ) also takes different path but both paths are smooth (they can't be differentiated in this anim, however, but this can be seen when only showing one version at a time):
https://user-images.githubusercontent.com/50438441/180716165-588c5a7e-bf33-4502-b02c-422b49cd743b.mp4
I don't see the different path as a problem, though, as it only happens when the dot-product of the subsequent quaternions is exactly 0. The chosen path is kind of matter of taste in this case anyway.

Indeed, the flipped quaternions represent the same direction, but the logarithm of the flipped quaternion is a different value. Probably the main reason for path corruption is that the coordinates on the ExpMap suddenly change if Quaternions flipped during the animation.

@GNSS-Stylist I added the conversion to Basis once to prevent pre-flip and match flip. This should make it consistent.
I know this is a rare case, but if there is a possibility that you want to interpolate a pre-flipped quaternion, I am not sure if this is a good way to do it because of the implicit flipping that occurs.
But at least the rotations show the same direction, so it should be fine for most use cases.
When tested, slerp and cubic_slerp selected the same path except for the 180 degree rotation. Since both 180 degree rotations are correct and shortest paths, I don't see that as a problem.

Note: however, that pre-flip does not occur in normal use cases.
Quaternions are obtained by conversion from Basis in almost all cases of GUI operation, so unless the pre-flipped quaternion is entered directly on the key, there will be no problem.
So if @reduz decide that the preventing pre-flip process is unnecessary, the process can be removed.

Note: however, that pre-flip does not occur in most normal use cases.
Quaternions are obtained by conversion from Euler->Basis in almost all cases of GUI operation, so unless the pre-flipped quaternion is entered directly on the key, there will be no problem.

Flipping happens with quaternions converted from Basis as well. Quaternions are created from Basis' in https://github.com/godotengine/godot-tests -> tests/cubic_slerp/Main_only_script.tscn but flipping is needed even when subsequent orientations are close to one another.

The flipped quaternion itself is not the problem, but whether it flips after converting from Basis; I tried a method to determine flips only from the positive and negative of w, but it did not work correctly.
After testing, it seems that matching only to-quaternion flips in slerp and matching all quarternion flips in cubic_slerp is a good way to stabilize the rotation.
I think this removes most of the problems.

If this looks OK, I think we are ready to merge. @GNSS-Stylist Can you check and approve?

The flipped quaternion itself is not the problem, but whether it flips after converting from Basis is problem; I tried a method to determine flip phase only from the positive and negative of w, but it did not work correctly.

Well, if we allow the path to be different from cubic_slerp in the case of 180 degree rotation, there does not seem to be much point in unifying the flip phase with respect to slerp. So, I will keep the changes to a minimum for slerp.
However, for cubic_slerp, it seems necessary since without unification of flip phase hitch will occur.

Can't say I like the idea of switching between different interpolation methods on the fly as it may introduce sudden changes in path when changing a key just a bit to the other side of the limit.
Tried some ways to at least reduce the amount of approximate (component-wise cubic) interpolations but usually stumbled upon some weird kickbacks somewhere. But I think it is possible to somewhat reduce the number those approximations by changing the condition if (flip1 || flip2 || flip3) to if (flip2 && flip3). So it seems that at least with the data in the test project only performing a "double-flip" of subsequent quaternions causes a glitch. Don't take my word for this, though as this is something I just tried and it seemed to work.
This solution looks good too the eye so maybe it's better to end this nitpicking from my part.

Can't say I like the idea of switching between different interpolation methods on the fly as it may introduce sudden changes in path when changing a key just a bit to the other side of the limit.

Modifying keys during animation is not a problem since it does not normal use case.

Tried some ways to at least reduce the amount of approximate (component-wise cubic) interpolations but usually stumbled upon some weird kickbacks somewhere. But I think it is possible to somewhat reduce the number those approximations by changing the condition if (flip1 || flip2 || flip3) to if (flip2 && flip3). So it seems that at least with the data in the test project only performing a "double-flip" of subsequent quaternions causes a glitch. Don't take my word for this, though as this is something I just tried and it seemed to work.

I tried if (flip2 && flip3), but there were cases of kickbacks. I also tried the approach of adapting slerp to catmull interpolation with using Barry-Goldman method, but I gave up on it because it seems to be more sensitive about flips than ExpMap.
Currently, this is the most stable implementation so far, and the results look reasonable, so I think we can decide on this implementation.

I have to say cubic slerping quaternions is kind of odd. I aded the existing function for completeness knowing it was likely not much useful.
As I mentioned in another PR, cubic spline interpolation is only really useful in practice when the points interpolated are at equal or similar distance. This is why its used in things like audio and this is also why we bake equidistant points in the Path2D/3D class before interpolating.
I suppose if you want to use cubic spline interpolation in animation, you also need to disable the optimizer to ensure all keys are imported and this is why you most likely suggested a PR disabling it. Am I right on this?

@reduz Disabling cubic_slerp on import is not a problem, it makes sense. However, there is a case where a node added on Godot is keyed for animation on Godot and cubic interpolation is performed. In any case, this function is currently broken and needs to be fixed.

@reduz This PR is not related to the PR that disables the optimizer.
It was simply sent because the threshold is too large and frequently breaks motion-tracked, fine-keyed model animations such as Mixamo.
This PR is simply to fix a completely broken interpolation formula.

Thanks!


Added CA certificate authority attribute for DB instance

make hooks && make validate to re-generate docs please.


Android telegram client scroll down after callback

Hi! I have some problems with android telegram client. If I send a message with a link and callback button for this message, after press callback button client app force scroll down to the end of bot conversation.
This reproduce only in android client and only if a message has a link and callback button.
Maybe anyone one knows what I can do with this?

Hi! Sorry it took so long to answer, had some small vacations :)
This isn't an issue that you can solve with the bot api, so my suggestion would be to talk to either BotSupport or contact Telegram's support (you can contact them through the app) to either inform them of this bug or ask whether it's normal behaviour.
Because it is not something this api can fix, I'll close it for now. Feel free to reopen it at any time.
Greetings.


Do not allow login on read-only gallery

This addresses https://github.com/NuGet/Engineering/issues/200. Users already cannot log in on read-only mode when the user's failure count is greater than zero.
Some of the read-only functional tests don't make sense anymore since you can't log in.

Hi @joelverhagen, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Use eemont for Sentinel 2 preprocessing

check emmont library for simplified s2 preprocessing

https://github.com/davemlz/eemont
geedim might be useful for compositing

Some interesting features in there, e.g. closest image in time: ee.ImageCollection().closest('2020-10-15')

Some interesting features in there, e.g. closest image in time: ee.ImageCollection().closest('2020-10-15')

Yes, it also has simple functions for masking.
then geedim can be used for calculating median mosaics / composited (e.g. monthly) to avoid shitty data.


Windows 10 Home [not supported]

With a fresh install of Windows 10 Home from this tool (v1.6) doesnt appear to be supported.
Below is the system info. If you need more info, let me know.

Duplicate of https://github.com/stascorp/rdpwrap/issues/87


vm.label per fork

Component
Forge
Describe the feature you would like
I think would be useful to set forkId when labeling an address. It isn't rare to have the same address across chains and the ability to label them differently would help on debugging.
Additional context
No response

hmm, yeah in hindsight an integer was perhaps not ideal.
we could overload the functions so they take a label and change the identifier behind the scenes
this would be straight forward though, we just need an additional map for String to id here
https://github.com/foundry-rs/foundry/blob/cdba27348d8ac52e0e652d42c5154120f9bb11f8/crates/evm/src/executor/backend/mod.rs#L1461-L1461
and some overloaded functions that accept string instead forkid int
FYI @Evalir

@mattsse I'd love to take this up.
perhaps the fork labels could be stored in executor::inspector::cheatcodes::Cheatcodes as a BTreeMapinstead? this is symmetrical to the address labels flows that live in Cheatcodes as labels: BTreeMap<Address, String>
also along the same lines, a new vm.labelFork(uint256, string) cheat could help set these labels to complement vm.label(address, string)

It isn't rare to have the same address across chains and the ability to label them differently would help on debugging.

IIUC it sounds like the problem here could also be solved by simply showing fork IDs in traces (perhaps only showing this when more than 1 fork is used), without needing to change cheats/label/forkId approaches

My two cents as a user is that would be more meaningful and a better UX to have the contract's label shown in the trace

To clarify my suggestion is that we’d always show the label, and if the test uses multiple fork IDs we also show fork ID. It should be possible to autogenerate a human friendly fork identifier such from the chain ID returned by the rpc and mapping that to the chain name

iiuc the suggestion is to modify all test logs so that every occurrence of addressLabel in traces is replaced by forkLabel:addressLabel or similar, iff the test uses multiple forks?


Update urls on /campaigns

The path_alias from Solr doesn't have the appropriate prefix. Use URL instead.

duplicate of #5282


Function to copy entities (inside and between instances)

Such a function would make it way easier to create and translate big amounts of content based on the work already done in the german language-version (and would increase the connections between the language-versions). One could copy an article e.g. to the spanish-language-version and the authors could use the german article as a skeleton which only needs to be adapted, thus making content work far easier.

Moved to Google Doc https://docs.google.com/document/d/1rSkFo2JtsSwHHsbosQcgAN4EzeePXLnqi_eCFpUM3u4/edit#


Write a common database backend Interface

The database backends should have a common abstract interface for initialization, connection handling and querying. They should use the message interface (that have to be written solving issue #1) for data-exchange ith the Server.

Done.
Related commits:
60d60eec6876245a034d0491fc078d87818c7975
3757d4333aa446613cd985a00c130de61cac7365
Now we need documentation an tests


Dispose socket on Accept() error (#328).

We're leaking sockets when there's an error on Accept() on an incoming connection. The socket is only disposed when finalizers are run, which is non-deterministic.
#328
cc @halter73 @benaadams @migueldeicaza

We should probably do the same for UvPipeHandles in PipeListener.

Now we have it in all relevant places. ListenerSecondary was already doing the right thing.

Probably should have mentioned this before, but I think we should also move the calls to DispatchConnection into the try blocks.

In that case we wouldn't need the explicit calls to Dispose since DispatchConnection should (indirectly) take care of it, right?

@cesarbs It won't if it throws. Technically, double dispose shouldn't be unsafe anyway.

@halter73 Done.

:shipit:


support failed-first

Would like to be able to use this and --failed-first at the same time.

Thanks for reporting. I didn't know that there is such an option in pytest. Will implement in the near future.


Further README.md cleanup

With the merge of https://github.com/rusoto/rusoto/pull/417, does anyone have any ideas for anything else we should move to the GitBook from the README, or anything to add to the README?

I'm happy with where it is now, thank you for the great work.  🎉

You're very welcome :)


make_mocked_request now accepts dict as headers

What do these changes do?
make_mocked_request accepts dict instance as headers arg
Related issue number
#1068
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes

Current coverage is 97.48% (diff: 100%)

Merging #1073 into master will not change coverage

@@             master      #1073   diff @@
==========================================
  Files            28         28
  Lines          6532       6532
  Methods           0          0
  Messages          0          0
  Branches       1101       1101
==========================================
  Hits           6368       6368
  Misses           88         88
  Partials         76         76

Powered by Codecov. Last update b0231dc...bfa4cbf

LGTM, thanks!


Website menu

📇 User story
As a user, I want to have a website menu, so that I can find or browse to new topics without the need to return home.
✅ Definition of Done

[ ] Feature is in staging
[ ] Feature documentation is complete
[ ] Feature checked for accessibility violations

📜 Acceptance criteria

[ ]

📝 More info

Fixes needed:

[ ] #259 Topic / Menu not working locally (with npm run dev / on localhost:3000)

@dylanzheng94 @daine is it fair to say this issue is complete? might this be one we can close?

Done


Modify smart-dnn model

Maybe we could implement the util function makeDatasetFromGenerator in DataCook?

Maybe we could implement the util function makeDatasetFromGenerator in DataCook?

OK, we can make this method and wrap the next logic. Shall we merge this firstly and then modify the script later?


One of the two will be used. Which one is undefined.

*** Compiling /Users/xiaoyang/Desktop/ShenBianDian_busshop/ShenBianDian_busshop/ViewController1.m ***
Loading .dylib - Ignore any duplicate class warning...
objc[33577]: Class ViewController1 is implemented in both /Users/xiaoyang/Library/Developer/CoreSimulator/Devices/83AF8B2F-3254-4B54-9D6E-6BEE07E31BDF/data/Containers/Bundle/Application/FAFD7AD5-8944-42E9-A226-200C6D1DED3B/ShenBianDian_busshop.app/ShenBianDian_busshop (0x1012e8aa8) and /Users/xiaoyang/Library/Containers/com.johnholdsworth.InjectionIII/Data/eval101.dylib (0x122324ad0). One of the two will be used. Which one is undefined.
Direct collapse,
What should I do next?

The “sweep” to find objects to send the “injected” method is not working for your app. You’ll have to look for INJECTION_BUNDLE_NOTIFICATION notifications instead.


[Bug] Join ruins pagination

Summary
I have issue with pagination when join/preload additional association
Steps to reproduce
I have project schema with Flop
@derive {
    Flop.Schema,
    filterable: [
      :title,
      :number,
      :status,
      :type_id,
      :priority_id,
      :current_stage_id,
      :notes,
      :start_at_date,
      :finish_at_date,
      :inserted_at_date,
      :manager_id,
      :member_account_id
    ],
    sortable: [
      :number,
      :title,
      :target_budget_amount,
      :priority_order,
      :inserted_at,
      :start_at,
      :finish_at
    ],
    default_order: %{order_by: [:number], order_directions: [:desc]},
    pagination_types: [:page, :first],
    adapter_opts: [
      join_fields: [
        member_account_id: [
          binding: :assigned_members,
          field: :account_id,
          ecto_type: :binary_id
        ],
        priority_order: [
          binding: :priority,
          field: :order,
          ecto_type: :biginit
        ]
      ]
    ]
  }

i need to filter by assocated member_account_id and sort by priority_order
my query is
#Ecto.Query<from p0 in HQ.CRM.Project,
 left_join: a1 in assoc(p0, :assigned_members), as: :assigned_members,
 left_join: t2 in HQ.Organization.Taxon, as: :priority,
 on: t2.id == p0.priority_id,
 preload: [{:assigned_members, :account}, :manager, :priority],
 preload: [assigned_members: a1, priority: t2]>

flop params:
page: 1,
page_size: 20,

but response weired
Expected behaviour
It reutrns 20 items per page
Actual behaviour
It returns 5-7 items per page depends on joined assoc
Elixir/Erlang version
1.16
Flop and Ecto versions
ecto 3.11.1 (Hex package) (mix)

ecto_sql 3.11.1 (Hex package) (mix)
locked at 3.11.1 (ecto_sql) ce14063a
flop 0.25.0 (Hex package) (mix)
locked at 0.25.0 (flop) 7e4b01b7

Additional context
I know that it might be related to Ecto limit/offset with joined association, but how to deal with in Flop?

If you join on a one-to-many or many-to-many relationship, your database will return one row per relationship, so in your case, it will return one row for each project/member association. You can see what is actually returned by the database by removing the preloads and adding  a select that selects the project, member, and priority in a tuple or map. And that result is what the DB applies the limit on.
The preload query function just takes the query result (which would have 20 rows, with projects appearing multiple times because of their associations) after it is returned from the DB and nests the associations (after which each project would only appear once). So if you your query returns a project that has three members, before the preload, you have three rows ({project_a/member_a, project_a/member_b, project_a/member_c), and then the preload nests the members, which leaves you with a single row (project_a{members: [member_a, member_b, member_c}). And that's how you end up with pages that have fewer items than the requested page size.
You have to ensure that your database query only returns one row per project. So this is really about SQL, and not about Ecto or Flop. Some of the things that can be useful depending on the context:

lateral joins
window queries
selecting from a sub query
selecting a list of IDs using ARRAY_AGG and select the resources in a separate query

Ok. How can I combine pagination and filtering/sorting by the nested association in Flop? I always need to join the binding reference for these, but it leads to duplicates, so I preload, but it hurts pagination.

Flop only requires a named binding to be able to filter on that. You can join on a sub query that doesn't return duplicates, e. g. by using a group or distinct clause in it. Again, this is an SQL question, not a Flop question.

I 100% agree that this is SQL question, I just wonder how to resolve this issue without terrible workarounds. Cheat sheet example requires join_fields for filtering through associated schema, and I am wondering if its possible to rewrite it to case where limit/offset pagination will be respected.

In the end, Flop only adds where clauses to an existing query. So you have to write the query the same way you would do if the filter conditions were hard-coded. No workarounds, just plain SQL query design. I would probably first try to join on a sub query and ensure that the sub query doesn't return more than one row per project, e.g. by adding a group by or distinct clause, as already mentioned, and I also mentioned multiple other ways to go about this. If you need more detailed help with Ecto query design or SQL, I'd suggest to ask in the elixir forum or on other channels focused on SQL, where more people will be able to see your question.

I wounder just if it is possible to paginate and use adapter_opts/join_fields bindings. As I have to assign bindings with left_join but subquery does not resolve this as binding expecting to be part of the main query
I tried to do:
 project_ids =
        from(t in Project)
        |> join(:left, [p], a in assoc(p, :assigned_members), as: :assigned_members)
        |> join(:left, [p], a in assoc(p, :priority), as: :priority)
        |> select([p], p.id)

      from(
        p in Project,
        where: p.id in subquery(project_ids)
      )
      |> Flop.validate_and_run(params, for: Project)

it produces result without duplicates but I can not use sorting and filtering from adapter_opts as it's not part of the main query
adapter_opts: [
      join_fields: [
        member_account_id: [
          binding: :assigned_members,
          field: :account_id,
          ecto_type: :binary_id
        ],
        priority_order: [
          binding: :priority,
          field: :order,
          ecto_type: :biginit
        ]
      ]
    ]

You can make columns from a sub query accessible in the parent query, for example:
members_query =
  from(
    m in AssignedMember,
    where: parent_as(:projects).id == m.project_id,
    select: %{account_id: m.account_id}
  )

from(
  p in Project,
  as: :projects,
  left_lateral_join: m in subquery(members_query),
  as: :assigned_members
)
|> Flop.validate_and_run(params, for: Project)

Written that way, Flop can access the :account_id field on the :assigned_members binding. The example above still returns duplicates, so you'll need to add something like a group by or distinct clause to the subquery.
members_query =
  from(
    m in AssignedMember,
    where: parent_as(:projects).id == m.project_id,
    select: %{account_id: min(m.account_id)},
    group_by: m.project_id
  )

Or you can use a left join on the association as before and add a group by clause on the parent query. The best approach depends on the nature of the data you're working with and how you plan to use the results. With the group by in the sub query as used here, you will need to load the members in a separate query.
I'm going to close this now, since this is not the place to discuss query design.

I resolved this with 2 flops:
# only filter without order
sub_flop =
  params
 |> Flop.validate!(for: Project)
 |> Flop.reset_order()
 # May i add Flop.reset_pagination as a new helper?
 |> Map.delete(:page)
 |> Map.delete(:page_size)
 |> Map.delete(:limit)
 |> Map.delete(:offset),

# Now only order and paginate without filters
main_flop =
 params
 |> Flop.validate!(for: Project)
 |> Flop.reset_filters()

project_ids =
from(t in Project)
|> add_assigned_members()
|> Flop.query(sub_flop, for: Project, extra_opts: [ctx: ctx])
|> distinct([p], p.id)
|> select([p], p.id)

from(
  p in Project,
  where: p.id in subquery(project_ids)
)
|> preload(^preload)
|> Flop.validate_and_run(main_flop, for: Project)

Tricky, but works fine, and no duplicates 🎉


Added editproject

This adds the editproject method.  I've been using it to change visibility_level to 0.
I've bumped the version number, although not sure if this is what you would like.

looking good! thanks for the patch! :+1:


Broken usage of importlib

Impact of the bug
The whole system
Describe the bug
While  working with the python packaging system, I had to load the configurations for the wmagent package from a specified path, rather than the OS specified Python modules search path. This was badly broken and was giving me the following error: [1].  After some digging, I again passed through this recent PR: https://github.com/dmwm/WMCore/pull/11530 . It actually introduces the wrong behavior, which I am about to explain bellow.
As discussed in this comment: https://github.com/dmwm/WMCore/pull/11530#issuecomment-1497387140 there are 3 possible methods for loading these modules, and we have chosen the second one. So I am about to discuss only this one from now on:
At these lines here we load the module: https://github.com/dmwm/WMCore/blob/31d65166dc62c7251edd52890bc4ac2f0b79d7fe/bin/wmagent-mod-config#L46-L47
We first try to search for a modSpec and than load the module but here is what the result is if I take a particular filename:
In [128]: importlib.machinery.PathFinder().find_spec('/data/srv/wmagent/<IP_ADDRESS>/config/wmagent/config-template.py')
Out[128]: ModuleSpec(name='/data/srv/wmagent/<IP_ADDRESS>/config/wmagent/config-template.py', loader=<_frozen_importlib_external.SourceFileLoader object at 0x7fdb7ef0e760>, origin='/usr/local/lib/python3.8/site-packages/py/__init__.py', submodule_search_locations=['/usr/local/lib/python3.8/site-packages/py'])

From which is visible that the origin is indeed the OS defined python modules search path, rather than the base dir of the module file so in order to add this there is another form to call find_spec (splitting the module name and the base path):
In [126]: importlib.machinery.PathFinder().find_spec('wmcore_config_input', ['/data/srv/wmagent/<IP_ADDRESS>/config/wmagent'])

And as can be seen the result is None. And this is expected because the module name (similarly to what we are doing in the current code - see the two lines of code referred above) is basically wrong. The module name should not be 'wmcore_config_input but should be the filename stripped off the .py prefix as @vkuznet was doing it in his examples in the comments to the previous issue. So the correct way of calling this find_spec method  is the following:
In [127]: importlib.machinery.PathFinder().find_spec('config-template', path=['/data/srv/wmagent/<IP_ADDRESS>/config/wmagent'])
Out[127]: ModuleSpec(name='config-template', loader=<_frozen_importlib_external.SourceFileLoader object at 0x7fdb7fcc30a0>, origin='/data/srv/wmagent/<IP_ADDRESS>/config/wmagent/config-template.py')

Where one can see that the origin is indeed the desired module search path.
Long story short, this bug is definite, but may have been masked so far in central services, because of the way how they are deployed in K8, the OS python module search path overlaps with the current module search path during the call of the load_module.
How to reproduce it
Just try to load  a module from a with a search path specified in the module name, rather than the default OS defined path.
Expected behavior
To be able to load modules not only from the default search path but also from a custom provided:
Wrong:
In [129]: modSpec1 = importlib.machinery.PathFinder().find_spec('/data/srv/wmagent/<IP_ADDRESS>/config/wmagent/config-template.py')

In [130]: mod1 = modSpec1.loader.load_module()

In [131]: pprint(dir(mod1))
['_ApiModule__doc',
 '__all__',
...
 'apipkg',
 'builtin',
 'code',
 'error',
 'iniconfig',
 'io',
 'log',
 'path',
 'process',
 'std',
 'test',
 'version',
 'xml']

Correct:
In [132]: modSpec2 = importlib.machinery.PathFinder().find_spec('config-template', path=['/data/srv/wmagent/<IP_ADDRESS>/config/wmagent'])

In [133]: mod2 = modSpec2.loader.load_module()

In [136]: pprint(dir(mod2))
['Configuration',
 'PY3',
 '__builtins__',
 '__cached__',
 '__doc__',
 '__file__',
 '__loader__',
 '__name__',
 '__package__',
 '__spec__',
 'acdcDBName',
 'bossAirPlugins',
 'config',
 'contactName',
 'couchURL',
 'databaseSocket',
 'databaseUrl',
 'glideInAcctGroup',
 'glideInAcctGroupUser',
 'globalDBSUrl',
 'globalDBSVersion',
 'globalLogLevel',
 'jobDumpDBName',
 'jobSummaryDBName',
 'localDBSVersion',
 'logDBName',
 'os',
 'retryAlgoParams',
 'serverHostName',
 'submitScript',
 'summaryStatsDBName',
 'wmbsServicePort',
 'workDirectory',
 'workflowArchiveTimeout',
 'workloadSummaryDB',
 'workloadSummaryURL',
 'workqueueDBName',
 'workqueueInboxDbName']

Additional context and error message
[1]
In [8]: importConfigTemplate(inputFile)
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[8], line 1
----> 1 importConfigTemplate(inputFile)

Cell In[1], line 9, in importConfigTemplate(filename)
      2 """
      3 _importConfigTemplate_
      4
      5 Given filename, load it and grab the configuration object from it
      6
      7 """
      8 modSpecs = importlib.machinery.PathFinder().find_spec(filename)
----> 9 mod = modSpecs.loader.load_module("wmcore_config_input")
     10 config = getattr(mod, 'config', None)
     11 if config is None:

File <frozen importlib._bootstrap_external>:520, in _check_name_wrapper(self, name, *args, **kwargs)

ImportError: loader for /data/srv/wmagent/<IP_ADDRESS>/config/wmagentpy3/config-template.py cannot handle wmcore_config_input

This issue is also impacting the python based packaging and deployment issues: https://github.com/dmwm/WMCore/issues/11564 and https://github.com/dmwm/WMCore/issues/8797


Logger improvements

The "Request" logger only allowed requests to be logged if an error occured. This amends the error to be optional.

Codecov Report

Merging #3 (f06c2fc) into main (1de8465) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   84.74%   85.00%   +0.25%
==========================================
  Files           4        4
  Lines          59       60       +1
==========================================
+ Hits           50       51       +1
  Misses          6        6
  Partials        3        3

Impacted Files
Coverage Δ

logging/logger.go
92.00% <100.00%> (+0.33%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix typos

Hi,
This tiny PR will fix :

1 typo in src/Sentry/Laravel/EventHandler.php
1 typo in src/Sentry/Laravel/ServiceProvider.php

Cheers! :robot:

Thanks 👍


Changed install script to make it compatible for sh on linux

Works with default options, but if I set AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION then I get errors:
export AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION=v1.1.0-alpha
sh -c "$(curl -fsSL https://raw.githubusercontent.com/microsoft/artifacts-credprovider/ba93b5218249ec3792470f9b2f48c91bd930a016/helpers/installcredprovider.sh)"

still gives me an error sh: 19: [: v1.1.0-alpha: unexpected operator

If we're making this work for environments without bash, should we also update the file's shebang?

The issue customers faced is that on some environments, the customer had to first install bash before they could get the cred provider installed. The installation script should work whether bash is available or not.


Feature/find definition by urn

Ticket 107032674

Upgrades the AttributeDictionary to allow finding Definitions by URN
Upgrades the AttributeAdapter to allow returning a set of Attributes (an AttributeSet), containing name and URN representations of the attribute and its values

@rjkip, @DRvanR

Good points, will work on it.

@rjkip, @DRvanR :poultry_leg:

:+1: for me, @rjkip ?

I'll allow it


Any reason not to use Node 20?

This plugin is the one holding me back on 18 and wondering if it could be updated?

Version 1.1.0 removes this limitation


Feat: only pass 'name' and 'id' parameters in share link

Solved differently in another commit. Thanks!


Unable to ack "big" pubsub messages (>5mb)

Environment details

Specify the API at the beginning of the title (for example, "BigQuery: ...")
General, Core, and Other are also allowed as types

PubSub

OS type and version:

Dockerized Java pod running on GKE

Java version:

11

google-cloud-java version(s):

spring-boot 2.2.10
spring-cloud-gcp-pubsub 1.2.5
google-cloud-pubsub 1.108.0
google-cloud-core 1.93.7
gax 1.57.1
grpc-core 1.30.2
Steps to reproduce

Send a big message to pubsub (>5Mb)
Consume it.

Stack trace
There is no stacktrace. No exceptions. No error level messages.
External references such as API reference guides used
https://spring.io/guides/gs/messaging-gcp-pubsub/
Any additional information below
When trying to consume big messages from pubsub using refered stack, I cant.
1º Message never reaches my listener code
2º I get "Received data on closed stream" INFO message
3º PubSub keeps sending the message to my service (sent count metric keeps going) but message is never acked, never dequed, never dlq-ed, and never reaching my code (dumb log)
This might be related to
https://github.com/googleapis/google-cloud-java/issues/2668
Thanks!

Thanks for reporting this, I will take a look at this issue. Are you observing this issue using synchronous pull or streaming pull?

We are facing this same issue, using streaming pull.

Thanks @testower, I will try reproducing this issue - what java client library version are you running with?

Thanks! We are working on creating a fix for this issue - stay tuned

I was able to reproduce this same issue overriding the defaultTransportChannelProvider. Ex.
Subscriber subscriber = Subscriber.newBuilder(subscription, receiver)
        .setChannelProvider(
            InstantiatingGrpcChannelProvider.newBuilder()
                .setKeepAliveTime(Duration.ofMinutes(5))
                .build())
        .build();

If a custom channel provider is provided, and the maxInboundMessageSize is not set (using 'setMaxInboundMessageSize'), the grpc maxInboundMessageSize defaults to 4mb, and you will see the 'Received data on closed stream' error if attempting to consume a message >4mb. The default channel provider in our client library uses a maxInboundMessageSize of 20mb (the max message size allowed).
I am going to mark this as resolved, as I cannot reproduce this issue using the default transport channel provider in our client library.


Fix linux (script) update instructions for azd

The update script documentation currently incorrectly references the uninstall script.
Also, remove the duplicated text below upgrade. It is already listed on the same page.

FYI @alexwolfmsft .. couldn't set a reviewer.

@alexwolfmsft
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Node.js Usage

I have a current cardano-integrated application based on cardanocli-js (and a local cardano node), which I'd like to refactor to leverage Lucid for utxo input selection, but am having difficulty getting my head around the initial setup steps for a non-browser Node.js environment.
Would it be possible to get some pointers on the equivalent steps to this, but in a desktop environment where I have key files for the wallet generated by cardanocli (wallet.payment.vkey, etc.):
const api = await window.cardano.nami.enable();
lucid.selectWallet(api);

I've resolved this with the following setup:
lucid.selectWalletFrom({
    address:  WALLET_PAYMENT_ADDR,
    rewardAddress: WALLET_PAYMENT_ADDR
})


Symfony Flex

cf. https://symfony.com/doc/current/setup/flex.html#upgrading-existing-applications-to-flex

Wait for official release.


Staff cannot delete user content

I'm no longer able to delete offensive content posted by other users via users/curation. If I try to delete, say, an observation, I will be taken to the observation and see this banner:

Fixed in abf670939b986270dd119e5974c285d90ad10a9a


Merge commits from @gordonbondon

@gordonbondon has already applied these changes to his fork twice. At the same time I like them and I wouldn't want to force him to do it again

Hey! Thanks for noticing 🎉
I still had some issues with handling deletion of nested directories,  that's why I did not create a PR yet.
Filesystem would issue only one event for deleted directory, so I need to add logic to delete files by matching their path prefix.
But it should work well with a flat structure.

Hey! Thanks for noticing 🎉
I still had some issues with handling deletion of nested directories,  that's why I did not create a PR yet.
Filesystem would issue only one event for deleted directory, so I need to add logic to delete files by matching their path prefix.
But it should work well with a flat structure.

Hey! Thanks for noticing

Thanks for your code and issue #8 info :-)

Hey! Thanks for noticing

Thanks for your code and issue #8 info :-)


Fix issues with generated test cases

Renames constants to reflect their use
Fixes the constants used to refer to the Property() and TestingRun() methods
Removes an unused import

Coverage decreased (-66.8%) to 0.0% when pulling f2d9c07b353a3194eefc8a78db80b10fcfe89984 on fix/test-case-capitalization into 260ff02022ff5c8ca1dbae995a75dd9891d43c9d on master.


Moving forward: Active users?

I'll leave this open for a few days. (more than longer as I'll likely forget about it)
Anyone want me to pull in the current stable version of materialize?
What does everyone think about the templates?
Any additional discussion?
Sorry about the lack of activity, I've moved on from the flask world but am more than happy to maintain this as much as I can (and PRs are always welcome!!)

yep! really want pull in new version of materialize!
I'm using this templates for my new blog migrate from bootstrap, it's very nice, and sincere thanks.
pardon me poor english.
THX!

Seems pretty good!
I'm going to try to use it in its current form :) Thanks


[BUG] - Monitoring Health Check occurs even when monitoring disabled

OS system and architecture in which you are running QHub
NixOS
Expected behavior
I would expect disabling monitoring in qhub-config.yaml as shown below would disable the /monitoring/api/health check that occurs in stage 07.
monitoring:
  enabled: false

Actual behavior
Disabling monitoring does not disable the /monitoring/api/health, and of course it fails since monitoring is disabled.
How to Reproduce the problem?
N/A
Command output
End of my logs are shown below.

[terraform]: Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
[terraform]:
[terraform]: Outputs:
[terraform]:
[terraform]: service_urls = {
[terraform]:   "conda_store" = {
[terraform]:     "health_url" = "https://github-actions.qhub.dev/conda-store/api/v1/"
[terraform]:     "url" = "https://github-actions.qhub.dev/conda-store/"
[terraform]:   }
[terraform]:   "dask_gateway" = {
[terraform]:     "health_url" = "https://github-actions.qhub.dev/gateway/api/version"
[terraform]:     "url" = "https://github-actions.qhub.dev/gateway/"
[terraform]:   }
[terraform]:   "jupyterhub" = {
[terraform]:     "health_url" = "https://github-actions.qhub.dev/hub/api/"
[terraform]:     "url" = "https://github-actions.qhub.dev/"
[terraform]:   }
[terraform]:   "keycloak" = {
[terraform]:     "health_url" = "https://github-actions.qhub.dev/auth/realms/master"
[terraform]:     "url" = "https://github-actions.qhub.dev/auth/"
[terraform]:   }
[terraform]:   "monitoring" = {
[terraform]:     "health_url" = "https://github-actions.qhub.dev/monitoring/api/health"
[terraform]:     "url" = "https://github-actions.qhub.dev/monitoring/"
[terraform]:   }
[terraform]: }
INFO:qhub.provider.terraform:terraform apply took 27.367 [s]
INFO:qhub.provider.terraform:terraform=/tmp/terraform/1.0.5/terraform output directory=stages/07-kubernetes-services
INFO:qhub.provider.terraform:terraform output took 0.583 [s]
Attempt 1 health check succeded for url=https://github-actions.qhub.dev/conda-store/api/v1/
Attempt 1 health check succeded for url=https://github-actions.qhub.dev/gateway/api/version
Attempt 1 health check succeded for url=https://github-actions.qhub.dev/hub/api/
Attempt 1 health check succeded for url=https://github-actions.qhub.dev/auth/realms/master
Attempt 1 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 2 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 3 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 4 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 5 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 6 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 7 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 8 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 9 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
Attempt 10 health check failed for url=https://github-actions.qhub.dev/monitoring/api/health
ERROR: Service monitoring DOWN when checking url=https://github-actions.qhub.dev/monitoring/api/health

### Versions and dependencies used.

qhub==0.4.0

### Compute environment

minikube

### Integrations

Grafana

### Anything else?

_No response_

Added this to the 0.4.1 release. Thanks for bringing this up @Adam-D-Lewis . We will absolutely fix this. Should be a small fix to only check this endpoint when the monitoring endpoint is actually there.
Longer-term I'd like to make monitoring required since it will be needed by future features we develop in qhub. Especially around cost monitoring and determining if a user has permissions.

I've added a fix on the argo branch for this issue since I was adding a check for the argo server endpoint anyway

Yeah @costrouc, here it is https://github.com/Quansight/qhub/pull/1244

Thanks @Adam-D-Lewis!


/p:MergeWith does not merge but adds

I'm testing using coverlet over a solution that has 3 test projects which i want to combine into a single .opencover.xml file
Since there's currently no direct solution for this. What I tried to do is generate the coverage for one of the test projects, output its result into an "converage.json" file and then apply a MergeWith param in the following dotnet test commands to merge into that same json file and set the output format to opencover
Problem is, that since the first project(ProjectName.Api) includes other two as references (ProjectName.Application, ProjectName.Data), the report is generated as following:
Test run for /build/test/ProjectName.Api.Tests/bin/Debug/netcoreapp2.0/ProjectName.Api.Tests.dll(.NETCoreApp,Version=v2.0)

Results File: /results/_8e5df6e97674_2018-09-28_11_10_36.trx

Total tests: 15. Passed: 15. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.4645 Seconds

Calculating coverage result...
  Generating report '/results/coverage.json'

+----------------------+--------+--------+--------+
| Module               | Line   | Branch | Method |
+----------------------+--------+--------+--------+
|ProjectName.Api         | 24.4%  | 28.6%  | 33.3%  |
+----------------------+--------+--------+--------+
| ProjectName.Data        | 0%     | 0%     | 0%     |
+----------------------+--------+--------+--------+
|ProjectName.Application | 0%     | 0%     | 0%     |
+----------------------+--------+--------+--------+

So it includes two other coverages for the referenced projects with 0% coverage.
This wouldn't be a problem if /p:MergeWith param actually did a proper merge.
But when I run the next dotnet test (over the ProjectName.Application project) with the MergeWith param pointing to this recently generated coverage.json file, I get this:
Test run for /build/test/ProjectName.Application.Tests/bin/Debug/netcoreapp2.0/ProjectName.Application.Tests.dll(.NETCoreApp,Version=v2.0)

Starting test execution, please wait...
Results File: /results/_5d6c3e7d1c85_2018-09-28_11_10_47.trx

Total tests: 4. Passed: 4. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 1.7143 Seconds

Calculating coverage result...
  Generating report '/results/coverage.json'

+----------------------+--------+--------+--------+
| Module               | Line   | Branch | Method |
+----------------------+--------+--------+--------+
| ProjectName.Data        | 0%     | 0%     | 0%     |
+----------------------+--------+--------+--------+
| ProjectName.Application | 100%   | 60%    | 100%   |
+----------------------+--------+--------+--------+
| ProjectName.Api         | 24.4%  | 28.6%  | 33.3%  |
+----------------------+--------+--------+--------+
| ProjectName.Data        | 0%     | 0%     | 0%     |
+----------------------+--------+--------+--------+
| ProjectName.Application | 0%     | 0%     | 0%     |
+----------------------+--------+--------+--------+

So it just adds the recent coverage to the existing ones in coverage.json. Causing a duplicated coverage in ProjectName.Application and ProjectName.Data (because again, ProjectName.Application references ProjectName.Data, so it adds a coverage 0% report)
Any solutions to this? Or am I missusing something?
Or even a way for coverlet for avoid including referenced project coverage?

dotnet test ./tests/ProjectName.Api.Tests/ProjectName.Api.Tests.csproj -l trx -r /results /p:CollectCoverage=true /p:CoverletOutput=/results/coverage
dotnet test ./${SolutionName} -l trx -r /results /p:CollectCoverage=true /p:CoverletOutput=/results/coverage /p:MergeWith='/results/coverage.json'
dotnet test ./${SolutionName} -l trx -r /results /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:CoverletOutput=/results/coverage /p:MergeWith='/results/coverage.json'

Update: @tonerdo  Looking into the Merging code https://github.com/tonerdo/coverlet/pull/186/commits/45bc5bc8433d07df90cbda5a6f80bfe98898d83d
I see you merge by Module key, then by Document key, etc.
In this case the Module key will be different since the dll is referenced from different paths
So the coverage.json looks like:
"/build/test/ProjectName.Api.Tests/bin/Debug/netcoreapp2.0/ProjectName.Application.dll": {
    "/build/src/ProjectName.Application/Services/Provider.cs": {
      "ProjectName.Application.Services.Provider": {
                 "System.Void ProjectName.Application.Services.KeyProvider::.ctor(ProjectName.Data.Repositories.Contracts.IProjectRepository,Microsoft.Extensions.Caching.Memory.IMemoryCache)": {
          "Lines": {
            "18": 0,
            "19": 0,
            "20": 0,
            "21": 0,
            "22": 0
          },
          "Branches": []
        }
      }
  ...
 }
}

"/build/test/ProjectName.Application.Tests/bin/Debug/netcoreapp2.0/ProjectName.Application.dll": {
    "/build/src/ProjectName.Application/Services/Provider.cs": {
      "ProjectName.Application.Services.Provider": {
        "System.Void ProjectName.Application.Services.KeyProvider::.ctor(ProjectName.Data.Repositories.Contracts.IProjectRepository,Microsoft.Extensions.Caching.Memory.IMemoryCache)": {
          "Lines": {
            "18": 4,
            "19": 4,
            "20": 4,
            "21": 4,
            "22": 4
          },
          "Branches": []
        }
      }
   ...
  }
}

So module keys are different but they reference the same dll file. Any chance it can look into same dll names for merging instead of the whole key?

PR made
https://github.com/tonerdo/coverlet/pull/204

Pr created for this https://github.com/tonerdo/coverlet/pull/204

When this will be pushed to coverlet.msbuild nuget package?

@Tonvengo Hopefully after #211 is merged! haha (otherwise the mergeWith will break)
Hopefully @tonerdo sees this first :)

I will reopen until it's there on the pkg

:) nice

My PR #213 actually addresses this issue too, so I think we have overlap. Mine changed the merge behaviour to merge any files with the same name, regardless of path.

Great, thanks for the feature, hopefully it gets a release soon.
However, I'm wondering, wouldn't it be an even better solution to extend this feature into some kind of /p:AggregateResultsAt that would create the first file if it doesn't exist, append all other results to it, and then finally convert it to other formats if required.
In my use case (VSTS build with multiple test projects), I could have a single step that would look like this:
dotnet test **/[Tt]ests/.csproj
/p:CollectCoverage=true
/p:AggregateResultsAt=/somepath/
/p:CoverletOutputFormat=opencover,cobertura
Thank you guys for your work!

@vlef without doubts. That was my next step, because if the file doesn't exist it fails. And it's annoying because when running a dotnet test on a solution you want it to also generate the file for the first test run.
I haven't got the time to look into that TBH. But maybe @tonerdo can take a look when he is free. Or if you find it you can also make a pr for it :)
Cheers

Definitely sounds like a good idea @vlef @pape77. For starters I could just make the MergeWith parameter ignore when the specified file doesn't exist and just assume it's on a first run

Released

Where was this released? I'm not seeing a new version on the NuGet feed. Last version is 2.3.1, 5 days before this was merged. Can we get an updated package please?

I use the last pkg and it merges correctly now. Still i made a pr for correcting some bad branch coverage output (see #225) and it was merged but not released, the feature for not failing when merging and file doesn't exist (see #220)

I'm waiting on #220 to be released

@obtuse-whoosh and then you probably have the issue at #225 xD

🤔 I'm not sure about that. The issue I'm having is the error that crops up while running a test with the MergeWith parameter when the output file doesn't exist yet. Specifically the issue solved by #220. #225 doesn't affect my use case 🤷

@obtuse-whoosh had you check that your merge is not decreasing your branch coverage as stated in the issue i opened and referenced in #225?
If you use different test projects that test projects that reference each other, there's a chance that happens to you too.
Merging is properly done, but branch coverage percentage won't be accurate and different than when testing each project separately.

Wow  that's something I missed, thanks for the info @pape77 . Do you know when @tonerdo will release these changes?

@obtuse-whoosh no idea. Hopefully my pr will get merged first.
Then we have to wait for a release 😅

@obtuse-whoosh Seems like he won't release it :/
See #223
Still no reason why though

Any update here? I think it is quite a common use case to have more than one test project within the solution.
A way to aggregate it so a single output would be really nice.

@dragon160 actually as I've seen it went worse because it's now adding coverage for dlls that are not even part of your project, but some other libraries (at least last time i checked).
As mentioned. I forked away long time ago with my own coverlet version. On the issue above was the change i did for this back then

Hi, I am using coverlet 1.6.0 version and in my solution there are multiple test project but mergewith is not working
I am using below:
Coverlet "D:\Project\proj1.Test\bin\Debug\netcoreapp2.2\proj1.Test.dll" --target "dotnet" --targetargs "test "D:\Project\proj1.Test" --no-build"
Coverlet "D:\Project\proj2.Test\bin\Debug\netcoreapp2.2\proj2.Test.dll" --target "dotnet" --targetargs "test "D:\Project\proj2.Test" --no-build" --merge-with=”D:\Project\Coverage.json”
Coverlet "D:\Project\proj3.Test\bin\Debug\netcoreapp2.2\proj3.Test.dll" --target "dotnet" --targetargs "test "D:\Project\proj2.Test" --no-build" --no-build"  --merge-with=”D:\Project\Coverage.json” --format opencover

I have a unit-test-per-project structure and also having this issue. Coverlet replaces the correct coverage for an assembly with the coverage of the assembly in the current test assembly, instead of a merging coverage.
I am able to work around it by running coverlet per project and then letting report-generator do the merging, which it seems it does correctly.
here is a gist that may help you https://gist.github.com/ckarcz/180a9ddfd9bfe33b1e68e1634c0e599e#gistcomment-3132943
cheers 🍻

Other that @ckarcz you can try with https://github.com/tonerdo/coverlet/blob/master/Documentation/Examples/MSBuild/MergeWith/HowTo.md

@MarcoRossignoli i did that but still had the coverage results of a library replaced with a subsequent collection/merge, resulting in zero coverage for that library. same as @priyanka1112 describes. the merge should merge the result data, not just the result xml nodes in the files.

@MarcoRossignoli i did that but still had the coverage results of a library replaced with a subsequent collection/merge, resulting in zero coverage for that library

Can you provide a simple repro?I'm not sure to understand where is the problem.


Create onnx config using optimum exporters

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


There is rn 0.24 out

Could you update deps if it works for that version and release 0.0.11 with <0.25? Thanks.

(Is that '<xxx' needed at all? Isn't optimistic ">= only" with "we'll fix it once needed" easier solution for users? It stops my upgrade to rn 0.24 b/c npm shrinkwrap fails)

Yeah I think optimistic solution is better, thanks
New version is published


Group Duration

We feel it would make sense to move BT-536 duration start date up one level, as it is used both when users give a duration end date (BT-537) as when they provide a duration period (BT-36). BT-537 and BT-36 are meaningless without BT-536.
We also think that the codelist foreseen in BT-538 should appear before any other duration related fields: if the duration is still “unknown”, or “unlimited”, it makes no sense to ask for any more detailed duration details (BT-536, BT-537, BT-36).

According to Enrico some improvements have been done for this (either it was for SDK 1.8 or 1.9).

Fixed with SDK 1.8


SVG should take input from stdin and output to stdout if no files given

Current version 0.5.3 will write to stdout if no output file is given.  That half is already finished.

Fixed in version 0.5.14


[Feature request] Guilded.gg support

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
Add guilded.gg support
Describe alternatives you've considered
N/A
Additional context
guilded.gg is a Discord alternative that's turning some heads, but right now the bot api isn't available to the public. I think people would like this.

I should like to add that Guilded claims to support the Discord webhook API, as touted in the webhook scene of each channel's settings.


Test suite does not build from Hackage

Likely files missing in the sdist tarball:
Resolving dependencies...
Configuring hpc-coveralls-0.8.0...
Building hpc-coveralls-0.8.0...
Preprocessing library hpc-coveralls-0.8.0...
In-place registering hpc-coveralls-0.8.0...
Preprocessing executable 'hpc-coveralls' for hpc-coveralls-0.8.0...
Preprocessing executable 'run-cabal-test' for hpc-coveralls-0.8.0...
Preprocessing test suite 'test-all' for hpc-coveralls-0.8.0...

test/TestAll.hs:5:8:
    Could not find module ‘TestHpcCoverallsLix’
    Use -v to see a list of the files searched for.

test/TestAll.hs:6:8:
    Could not find module ‘TestHpcCoverallsUtil’
    Use -v to see a list of the files searched for.

I added hpc-coveralls to Stackage recently, as I used it for mutable-containers and found it incredibly convenient. Thank you!

Thank you very much for adding it to stackage, I was not really sure of the exact procedure.
Is there something I should do regarding the lower/upper bounds of the dependencies I use?
I'm still not sure of what is the best practice regarding this. Is there some recommended reading?
Regarding the issue with TestHpcCoverallsLix and TestHpcCoverallsUtil not being included, I'm going to fix this and will tell you once done.

If there are any issues in the future I'll let you know. Add it stands the
package seems to be in great shape.
On Sat, Jan 10, 2015, 2:36 PM Guillaume Nargeot<EMAIL_ADDRESS>wrote:

Closed #34 https://github.com/guillaume-nargeot/hpc-coveralls/issues/34.
—
Reply to this email directly or view it on GitHub
https://github.com/guillaume-nargeot/hpc-coveralls/issues/34#event-216952768
.


Add fingerprint protection module

Task/Issue URL: https://app.asana.com/0/488551667048375/1203179499015587/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2523   👈

This comment was auto-generated by Graphite.


what should i do if the train_batch_size has to be set to 64

you can try, I also had not tested like this.

@SOLARleisu my setting is same as your,  how is your training , have your succeed to train it now?

train_batch_size is depend on your gpu total memory size.
close. when it necessary will reopen.


Remote SSH forever keeps asking password

Does this issue occur when all extensions are disabled?: Yes/No

Platform 1
Version: 1.81.1 (user setup)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:22:42.175Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Platform 2
Version: 1.81.1 (Universal)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:20:33.924Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.3.0
Steps to Reproduce:
On Platform 1, Windows

Delete all the .vscode_server and .vscode from the remote server.
The remote server is Ubuntu, using Andrew File System
Ctrl+Shift+P to "kill vscode server on host", if necessary
Use Flock is True. I cannot recall whether Use Local Server was True then - I suspect this is irrelevant.
Click the left-bottom "connect remote" icon and connect - either entering the credential in the prompt or configuring with a config file brings the same issue.
The first time of connection will always (I believe) succeed. However, when I clicked "open folder", it keeps asking for password forever. The message is attached at the end of the thread.
When I failed to connect, I tried on Mac. The same thing happens.

On Platform 2, Mac
8. On Mac, I disabled Use Flock, doing step 1 and 3, it works!
On Platform 1, Windows
9. After successfully setting this up on Mac, with the original setting on Windows (Use Flock is True), I successfully connected to a folder using a cached link in the VScode Welcome - Recent page. That is, I didn't have the chance to connect to the root folder and see if it works.
10. When I disconnected and tried to connect again, the "forever password prompt" issue happens again.
11. Ctrl+Shift+P to "kill vscode server on host". Then I tried to connect to the folder, it works.  (Only once)
12. I repeated all steps of 11 but rather connecting to a folder from the link in VScode Welcome - Recent, it also works. (Only once)
13. I set "Use Flock" on my Windows to False without killing the server. The error persists.
14. I killed the server and kept "Use Flock" to False. It works - the error doesn't come again after disconnecting and re-connecting several times.
15. Message. This is the message from step 9, but I believe it's the same as in step 6.
One thing I would like to add is that other related issues have at least some kinds of error message, but the message I got didn't tell me what was failing.
[20:08:41.473] Log Level: 2
[20:08:41.480] SSH Resolver called for "ssh-remote+7b22686f73744e616d65223a22474843227d", attempt 1
[20:08:41.481] "remote.SSH.useLocalServer": false
[20:08:41.481] "remote.SSH.showLoginTerminal": false
[20:08:41.481] "remote.SSH.remotePlatform": {"xxx.edu":"linux","org.edu":"linux","GHC":"linux"}
[20:08:41.481] "remote.SSH.path": undefined
[20:08:41.481] "remote.SSH.configFile": undefined
[20:08:41.481] "remote.SSH.useFlock": true
[20:08:41.481] "remote.SSH.lockfilesInTmp": false
[20:08:41.481] "remote.SSH.localServerDownload": auto
[20:08:41.481] "remote.SSH.remoteServerListenOnSocket": false
[20:08:41.482] "remote.SSH.showLoginTerminal": false
[20:08:41.482] "remote.SSH.defaultExtensions": []
[20:08:41.482] "remote.SSH.loglevel": 2
[20:08:41.482] "remote.SSH.enableDynamicForwarding": true
[20:08:41.482] "remote.SSH.enableRemoteCommand": false
[20:08:41.482] "remote.SSH.serverPickPortsFromRange": {}
[20:08:41.482] "remote.SSH.serverInstallPath": {}
[20:08:41.485] VS Code version: 1.81.1
[20:08:41.485] Remote-SSH version<EMAIL_ADDRESS>[20:08:41.485] win32 x64
[20:08:41.486] SSH Resolver called for host: GHC
[20:08:41.486] Setting up SSH remote "GHC"
[20:08:41.489] Using commit id "6c3e3dba23e8fadc360aed75ce363ba185c49794" and quality "stable" for server
[20:08:41.492] Install and start server if needed
[20:08:41.496] Checking ssh with "C:\Windows\system32\ssh.exe -V"
[20:08:41.498] Got error from ssh: spawn C:\Windows\system32\ssh.exe ENOENT
[20:08:41.498] Checking ssh with "C:\Windows\ssh.exe -V"
[20:08:41.499] Got error from ssh: spawn C:\Windows\ssh.exe ENOENT
[20:08:41.499] Checking ssh with "C:\Windows\System32\Wbem\ssh.exe -V"
[20:08:41.500] Got error from ssh: spawn C:\Windows\System32\Wbem\ssh.exe ENOENT
[20:08:41.500] Checking ssh with "C:\Windows\System32\WindowsPowerShell\v1.0\ssh.exe -V"
[20:08:41.501] Got error from ssh: spawn C:\Windows\System32\WindowsPowerShell\v1.0\ssh.exe ENOENT
[20:08:41.501] Checking ssh with "C:\Windows\System32\OpenSSH\ssh.exe -V"
[20:08:41.520] > OpenSSH_for_Windows_8.6p1, LibreSSL 3.4.3

[20:08:41.523] Running script with connection command: "C:\Windows\System32\OpenSSH\ssh.exe" -T -D 1873 "GHC" bash
[20:08:41.525] Terminal shell path: C:\WINDOWS\System32\cmd.exe
[20:08:42.029] ><EMAIL_ADDRESS>password:]0;C:\WINDOWS\System32\cmd.exe
[20:08:42.029] Got some output, clearing connection timeout
[20:08:42.029] Showing password prompt
[20:08:49.273] Got password response
[20:08:49.274] "install" wrote data to terminal: "****************"
[20:08:49.313] >
[20:08:49.875] > c304672f0005: running
[20:08:49.937] > Acquiring lock on xxx.edu/usr4/user/.vscode-server/bin/6c3e3dba23e8fadc360aed75ce363ba185c49794/vscode-remote-lock.user.6c3e3dba23e8fadc360aed75ce363ba185c49794
> Installation already in progress...
> If you continue to see this message, you can try toggling the remote.SSH.useFlock setting
> c304672f0005: start
> exitCode==24==
> listeningOn====
> osReleaseId==ubuntu==
> arch==x86_64==
> vscodeArch==x64==
> bitness==64==
> tmpDir==/run/user/2687500==
> platform==linux==
> unpackResult====
> didLocalDownload==0==
> downloadTime====
> installTime====
> extInstallTime====
> serverStartTime====
> c304672f0005: end
[20:08:49.939] Received install output:
exitCode==24==
listeningOn====
osReleaseId==ubuntu==
arch==x86_64==
vscodeArch==x64==
bitness==64==
tmpDir==/run/user/2687500==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime====

[20:08:49.942] Server installation process already in progress - waiting and retrying
[20:08:50.956] Running script with connection command: "C:\Windows\System32\OpenSSH\ssh.exe" -T -D 1873 "GHC" bash
[20:08:50.958] Terminal shell path: C:\WINDOWS\System32\cmd.exe
[20:08:51.412] "install" terminal command done
[20:08:51.412] Install terminal quit with output:
[20:08:51.465] ><EMAIL_ADDRESS>password:]0;C:\WINDOWS\System32\cmd.exe
[20:08:51.465] Got some output, clearing connection timeout
[20:08:51.466] Showing password prompt
[20:10:06.345] Password dialog canceled
[20:10:06.345] "install" terminal command canceled
[20:10:06.347] Resolver error: Error: Connecting was canceled
	at m.Canceled (c:\Users\username\.vscode\extensions\ms-vscode-remote.remote-ssh-0.102.0\out\extension.js:1:584341)
	at c:\Users\username\.vscode\extensions\ms-vscode-remote.remote-ssh-0.102.0\out\extension.js:1:681195
[20:10:06.352] ------

using Andrew File System

I suspect this is causing an issue with acquiring a lock on the fs. I assume that if you always delete the file referenced in Acquiring lock on ... then it should work?

I believe I am having the same error since 1.81.1, I tried deleting the entire .vscode-server directory but then I just got the issue again the next time I needed to reload VS Code.
I have downgraded to 1.81.0 and I am no longer experiencing this issue.
Let me know if there's any information I can provide to help debug this issue.

Same error after I upgrade vscode to 1.82 and RemoteSSH plugin

Please open your own issues with the full log, if you are having trouble.
Closing due to no response from OP

FYI, upgrading directly to 1.83.0 fixed this for me.


Make sni.yaml errors cause an unrecoverable TS crash.

[approve ci Clang-Analyzer]

[approve ci]

Cherry-picked to v9.2.x


I can't isntall Chromely using nugget!

When I click on the installation. The error message is i use the wrong .net version (4.6.1)!

I believe you are referring to CefGlue lib on nuget. This is built against .NET Standard 2.0 and yes would require 4.6.1 client - https://docs.microsoft.com/en-us/dotnet/standard/net-standard.
Please see if you can run any of the demos -CefGlue or CefSharp and to see how the project setup is - Demos. I am still working on the documentation, but there should be enough info on CefGlue in Getting Started.
Please also note that you do not need to use the Chromely CefGlue in all situationns. This is only required if you want to build a .NET Core app. You can build afresh against other .NET CefGlue nuget libs.


BloodHound & hash_spider fixes

fail out right away if BloodHound is enabled and authentication fails to the BH API or if the URL isn't available
fix old db function call for hosts in hash_spider; fixes #221
update default bloodhound neo4j password, as the docker compose file from them uses a new password by default

Imo why shouldn't just exit when bloodhound fails to authenticate. In realworld pentests it would maybe be annoying if you get spammed with failed authentication messages, but still better than straight out shutting down your (potentially crucial) command execution over numerous hosts.
In the end it's just a connector trying to assist with bloodhound enumeration.
Rest looks good👍🏼

It throws tons of errors and will cause you to rerun it all again if you don't notice it at first. If we fail out right away they can fix the issue or just turn off Bloodhound integration, a much more simple step than potentially having to reauth against thousands of hosts.

Well okay, probably not such a big deal anyway.


Unknows in THD, I identified one

Left has "DRC default on" toggle set on in Dolby media encoder and right has it off.

Sample file please.

Downloads.zip
Here you go.


Missing tag for 2022-12-23 release

The commit a26edc6e1370f399894059c1fe96beee666eda7a updated the package version:
__version__ = '2022-12-23'  # ISO 8601 (YYYY-MM-DD)

But there isn't a new tagged release associated with the commit.

I tend to bump the version number with any reasonably meaningful change, but don't currently make a release every time this happens, as I don't really see the need. Is this causing any issues?

No issue, I just noticed the discrepancy as I was working on testing PR #114 and didn't realize it was intentional! Closing the issue.


Require image for ARM64 architecture

Hi Team,
I am trying to use the gliderlabs/docker-alpine image on arm64 platform but it seems it is not available for arm64.
I have successfully built the image using the command docker build -t image_name . on the arm64 platform by making some changes in the files .circleci/config.yml and builder/scripts/mkimage-alpine.bash.
I have used circle-ci to build and push the image for both the platforms.
Commit Link - https://github.com/odidev/docker-alpine-1/commit/8b435585b6ec1558e4776aeb74911ab26016ea02
Circle-ci link - https://app.circleci.com/pipelines/github/odidev/docker-alpine-1/2/workflows/87a58ce5-03bc-4d34-83d0-38a7b6cb2cd0/jobs/3
Docker Hub Link - https://hub.docker.com/repository/registry-1.docker.io/odidev/docker_alpine/tags?page=1&ordering=last_updated
Do you have any plans on releasing arm64 images?
Please have a look at the changes. If interested, I will raise a PR.

The official Alpine Linux docker images supports arm64:
https://hub.docker.com/_/alpine
https://github.com/alpinelinux/docker-alpine


Failure in point_pillars_test for DoInference

System information
Linux Ubuntu 18.04
Apollo 6.0
GTX 1060 3 Gb
Steps to reproduce the issue:
bazel test --config=gpu --test_size_filters=large //modules/perception/lidar/lib/detection/lidar_point_pillars:point_pillars_test
I am attempting to run the newer TensorRT version of the pointpillars algorithm and am getting CUDA out of memory errors with the current pfe and rpn files (Nov 12: #12974) which I tracked down to the RPN with some printline commands.
WARNING: Current optimization profile is: 0. Please ensure there are no enqueued operations pending in this context prior to switching profiles
ERROR: ../rtSafe/safeRuntime.cpp (25) - Cuda Error in allocate: 2 (out of memory)
ERROR: FAILED_ALLOCATION: std::exception
I1203 15:47:08.481616 15483 point_pillars.cc:471] []RPN_CONTEXT FAILED
E1203 15:47:08.481621 15483 point_pillars.cc:472] []Failed to create TensorRT Execution Context.
WARNING: Current optimization profile is: 0. Please ensure there are no enqueued operations pending in this context prior to switching profiles
ERROR: ../rtSafe/safeRuntime.cpp (25) - Cuda Error in allocate: 2 (out of memory)
ERROR: FAILED_ALLOCATION: std::exception
I1203 15:47:08.481616 15483 point_pillars.cc:471] []RPN_CONTEXT FAILED
E1203 15:47:08.481621 15483 point_pillars.cc:472] []Failed to create TensorRT Execution Context.
When I substitute an older version of the rpn I get a completed test but it fails by a large margin (Sept 17: #12561)
modules/perception/lidar/lib/detection/lidar_point_pillars/point_pillars_test.cc:654: Failure
Expected: (num_objects) >= (10), actual: 0 vs 10
[  FAILED  ] TestSuite.CheckDoInference (10329 ms)
[----------] 3 tests from TestSuite (33528 ms total)
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (33528 ms total)
[  PASSED  ] 2 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestSuite.CheckDoInference
Is the current point_pillars_test.cc up-to-date and should result in a passed grade or is it depreciated?  Also are the current pfe and rpn files the correct ones to pass this test?

@PGLF-EAP Because your GPU GTX 1060 has not enough CUDA memory for this test. The test has been verified under GTX 1080.

Hi @PGLF-EAP , you can try to run bazel test command with --config=opt to see if it's OK to pass this point_pillars_test.
I have a GTX 1070 machine, and It fails when running
bazel test --config=gpu --test_size_filters=large //modules/perception/lidar/lib/detection/lidar_point_pillars:point_pillars_test

with errors similar to yours, and when I run
bazel test **--config=opt** --config=gpu --test_size_filters=large //modules/perception/lidar/lib/detection/lidar_point_pillars:point_pillars_test

, the test passes.

@storypku When you say the test passes, do you mean you get to the point where you get an output from or that it actually passes with above 10 objects detected?  I still get "GPUassert: out of memory modules/perception/lidar/lib/detection/lidar_point_pillars/point_pillars_test.cc 437" when trying --config=opt with the current master pfe and rpn.
Though that could be because of what jeroldchen said about not having enough memory.  How much memory does your GTX 1070 have?
@jeroldchen when you say the test has been verified under 1080 do you mean that it should be expected that running the current point_pillars_test.cc should yield 10+ objects detected?

@storypku When you say the test passes, do you mean you get to the point where you get an output from or that it actually passes with above 10 objects detected?

Yep.

Though that could be because of what jeroldchen said about not having enough memory. How much memory does your GTX 1070 have?

GTX 1070 has also 8G mem. As can be seen from the following log:
$ nvidia-smi
Sat Dec  5 11:08:57 2020
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 455.32.00    Driver Version: 455.32.00    CUDA Version: 11.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  GeForce GTX 1070    On   | 00000000:01:00.0 Off |                  N/A |
| 27%   28C    P8     6W / 151W |    547MiB /  8114MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      1020      G   /usr/lib/xorg/Xorg                101MiB |
|    0   N/A  N/A      1885      G   /usr/lib/xorg/Xorg                374MiB |
|    0   N/A  N/A      2039      G   /usr/bin/gnome-shell               15MiB |
|    0   N/A  N/A     12520      G   ...AAAAAAAA== --shared-files       40MiB |
+-----------------------------------------------------------------------------+

@storypku Can you post the test output for the passed test with 10+ objects detected?  It would be nice to compare to when I can get my hands on a different graphics card.

@storypku Can you post the test output for the passed test with 10+ objects detected? It would be nice to compare to when I can get my hands on a different graphics card.

@jeroldchen will you please help @PGLF-EAP with your test output ？It's your expertise.

@PGLF-EAP Obviously, your test showed a failure result, with the message "GPUassert: out of memory" given. And that is because your free GPU memory is too limited to run DoInference function. If the test passed, it should directly return "PASSED" status as the other passed tests you have seen, without any other messages output. You can run nvidia-smi to check your GPU memory usage and kill other processes that are using GPU memory, in order to release more memory for testing PointPillars. If that still doesn't work, I am sorry but you might have to use a GPU with larger memory size.

@jeroldchen So I was able to get access to a higher GPU (GTX 2070 8gb) and was able to run the tests without any memory errors.  However, I did not pass the DoInference test using the current Apollo master branch or the Nov 12 Apollo master branch 295e13e9681c2a1776a60c6206437c61e2a176c8 when the change to TensorRT took place.
I did pass the test using the Apollo 6.0.0 release which uses the torch inference.
So my question is should the test fail for the current TensorRT based PointPillars?


[locale-fr] Fixed typo, added tests

I had left a single quote (') in a translation string. It's now fixed.
Also I took the tests for locale zn_CH from test.js and put them in a new file called fr-localeTest.js. I didn't reinclude all the tests for locale en as they are already in test.js. Feel free to do something different if you feel like it's better!
PS: Sorry for breaking your code with my original translation ^^
Also, please note I did not run the tests as I do not have an environment for JS dev.

nice work, I have change the locale test file here
and can run it with npm test, it just can test the locale js file's Grammatical errors.

Thanks!


Update Readme.md

Article on how to make a PostCSS plugin

Thank you for your contribution :smiley:


Chip text longer than maxWidth breaks chipView height.

I don't really know whats the specified behaviour but if you have a chip with a text longer than ChipView's measured width, chip gets (correctly) wrap into 2 lines, but the rest of the lines also get "overflowed", which results in blank lines following chip lines.
Something like this:

The same issue


Increase default message size limit to 256MiB

By default gRPC rejects messages over 4MiB.  However, Bigtable routinely produces messages much larger than that. Other Bigtable client libraries have change the default to 256 MiB, we should be consistent with them.

/cc: @sduskis


ci: Use branch coverage

Trying this to assess whether the drop in measured coverage is accurate

@PRQL/prql-team do we think this is more accurate? It's much stricter.
For example these are only tagged as partially covered, I guess because the Ok and Err aren't both covered:

...which feels maybe too strict?

For example these are only tagged as partially covered, I guess because the Ok and Err aren't both covered:

These cases will never be covered.
It is too strict.

Yeah agree; closing.


[otbn] Hook up ISS with top-level to give us a bus-functional model

We want to create a bus-functional model (BFM) for OTBN. We can do that by hooking up our in-development instruction-set simulator to the toplevel of OTBN.
General idea:

Have a otbn.sv toplevel containing IMEM, DMEM, the generated registers, and interrupts.
Add logic to this file to

Wait for the "start" signal
Write the contents of IMEM and DMEM to a file
Probably through DPI: call the simulator binary (as external application) and pass it the IMEM and DMEM contents. Before the simulator terminates, it dumps the final DMEM contents somewhere (stdout or a file)
If the simulator terminates, take the DMEM contents from it and overwrite the DMEM in the ibex_core.sv.
Trigger the "done" interrupt.

Note that all of that is possible because OTBN is run-to-completion and IMEM and DMEM are not accessible to the main CPU during the operation. Also, IMEM cannot be modified.
Note also that this model doesn't do any timing. We can add artificial processing time in the form of a delay cycles if we want, but that's non-essential as a starting point.
Dependencies:

[ ] Top-level file #2468
[ ] Simulator #2471

There is the PoC: https://github.com/wallento/opentitan/tree/bignum-model

Adding timing is a no-brainer, I can return the number of executed instructions from the simulator, which is number of cycles in OTBN, right?

Yes, each instructions == cycles is accurate for now.

I did have a quick look at the bignum-model branch, nice work! Can you

file a PR to master for the memutil change so we can get that out of the way?
The other changes are blocked on the #2468 going into master, which should happen in the coming days. I did create a otbn-dev branch here on lowrisc/opentitan that we can use as integration branch to collaboratively work on features which aren't ready for master yet. Once you're reasonably happy with the code, can you do a PR against this branch? That should be enough to call this issue "completed."


Implemented partial observable mode for laser tag

Hey Open Spiel team,
This pull request relates to adding a partially observable mode to the Laser Tag game based on the descriptions in the related papers.
Some things to note about the implementation:

by default the laser tag game still uses the fully observable mode and is unchanged,
partially observable mode can be activated by setting the game parameter fully_obs=false and the observation dimensions can be changed using the obs_front, obs_back, obs_side parameters (by default they are set to the same as for the PSRO paper: 17, 2, 10),
the returned tensor uses the tensor format currently implemented (with 4 binary planes), as opposed to returning an RGB tensor.

I should be easy to extend the proposed implementation to also support RGB observation tensors. Let me know if you think it would be useful to add.
Thanks for the awesome repo!

Thanks! We will try to take a look this week.

My pleasure. Thanks for the awesome library.