Minor change, improves performance of OR drastically.

On local tests, using this to "OR" 2000 equals checks took around 600ms compared to 170s taken by the original version.

@shubhamchopra Thanks for this. Only two minor comments.

LGTM. Merging to master/branch-1.6/branch-2.0. Thanks.


Check if user is sure they want to trigger processing

It's quite easy to accidentally start processing. Add a dialogue to check if they definitely want to do this, with the option to go back if not.

Resolved by #121


fix: Change ensuire to ensure

Found this file that was named wrong, so I fixed the spelling mistake
Fixes #2736

I forgot to add the "Fixes 2736" in the comment.
Is that why Add new issues to project / Add issue to project (pull_request) failed?
Is there a way to retrigger it xd?

Thanks!


[Command] The response code of Get Command should come from Device Service

🐞 Bug Report
Affected Services

 The issue is located in: core-command
Is this a regression?
No
Description and Minimal Reproduction
Currently, the response code of Get Command is always 200 OK if there is no error.
https://github.com/edgexfoundry/edgex-go/blob/729eb4739df12e156b446759f30c8b9b764bc7ef/internal/core/command/controller/http/command.go#L115
It should be passed by Device Service as what are doing in Set Command.
https://github.com/edgexfoundry/edgex-go/blob/729eb4739df12e156b446759f30c8b9b764bc7ef/internal/core/command/controller/http/command.go#L147

fixed by #3721


Converging too slowly while training

Context of the issue.
I'm training a new DNN on a big dataset(~10M images), however the LFW accuracy is only 0.8035 after 333 epoch. Is the convergence too slow ? or is there sth wrong with my parameter setting?@bamos
Expected behavior.
[Describe what you would expect to have resulted from this process.]
Actual behavior.

main Parameter
-nEpochs 1000
-epochSize 250
-peoplePerBatch 10
-imagesPerPerson 20
-modelDef nn4.small2.def.lua
-alpha 0.2
Steps to reproduce.
[Present a minimal example and steps to produce the issue.]
OS and hardware information.

Operating system: [ubuntu]
Torch version: [latest]
CPU architecture:[x86]
GPU type (if using): [Tesla k20C]

Hi,
Could you provide the plots/files which show Train Loss and LFW accuracy in epochs?
And it is strange behavior, as 333 epochs, each 1000*200 examplse give you 66M images. I think that accuracy should we higher.

Thank you  @melgor, the plots/files are provided. Is the imagesPerPerson too slow?
plotfiles.zip

Hi @cocoakeith, potentially the nn4.small2 model might not fit well to your data since it's an order of magnitude larger than what I tuned nn4.small2 for. Can you try retraining with the original nn4 model?
-Brandon.

I think that bamos have right.
And based on logs, it is making progress, so maybe you should wait longer.

Is the imagesPerPerson too small
I do not think so. But you current config use 20*10 images. If you have enough GPU memory, you can try increase imagesPerPerson (to 25 or even more)

Hi @bamos @melgor ,I try retraining with the original nn4 model, after one night training(56 epochs), the LFW accuracy has decreased, maybe I should wait longer. Besides, my dataset is noisy, but it's very big, is it necessary to do some data cleaning ?
lfwAcc
7.7200e-01
7.7250e-01
7.7050e-01
7.6180e-01
7.7180e-01
7.5400e-01
7.4580e-01
7.4450e-01
7.3650e-01
7.5180e-01
7.4930e-01
7.4170e-01
7.3180e-01
7.3320e-01
7.4520e-01
7.2450e-01
7.2800e-01
7.2420e-01
7.3450e-01
7.4750e-01
7.2980e-01
7.1880e-01
7.5070e-01
7.3800e-01
7.3170e-01
7.4770e-01
7.0950e-01
7.3970e-01
7.4120e-01
7.2570e-01
7.4200e-01
7.2630e-01
7.3980e-01
7.3250e-01
7.2420e-01
7.4300e-01
7.3530e-01
7.5220e-01
7.4650e-01
7.4020e-01
7.3480e-01
7.4730e-01
7.5030e-01
7.4330e-01
7.4050e-01
7.4900e-01
7.5230e-01
7.0770e-01
7.3070e-01
7.3750e-01
7.5170e-01
7.2130e-01
7.2080e-01
7.3520e-01
7.2330e-01
7.3170e-01
avg triplet loss (train set)
2.1304e-01
2.0462e-01
2.0219e-01
2.0321e-01
2.0260e-01
2.0206e-01
2.0186e-01
2.0201e-01
2.0157e-01
2.0200e-01
2.0117e-01
2.0161e-01
2.0176e-01
2.0140e-01
2.0180e-01
2.0118e-01
2.0118e-01
2.0128e-01
2.0045e-01
2.0146e-01
2.0138e-01
2.0141e-01
2.0083e-01
2.0108e-01
2.0093e-01
2.0134e-01
1.9996e-01
2.0190e-01
2.0030e-01
2.0112e-01
2.0026e-01
2.0152e-01
2.0157e-01
1.9998e-01
2.0007e-01
2.0129e-01
2.0088e-01
2.0061e-01
2.0090e-01
2.0106e-01
1.9957e-01
2.0089e-01
2.0083e-01
2.0049e-01
2.0124e-01
2.0042e-01
2.0047e-01
2.0062e-01
2.0109e-01
2.0124e-01
2.0071e-01
2.0023e-01
2.0104e-01
2.0026e-01
2.0082e-01
2.0127e-01

Yeah, your data might be too noisy and you might need to clean it. I was just able to re-train a model from scratch to 91.9% LFW accuracy, so I'm going to close this issue since it's not development-related or a bug. Feel free to continue this discussion on our mailing list.
-Brandon.


Refactor CosmosDB Instructions

Add setup for CosmosDB database

this is in lab 2, step 2. do we need to add something there?

@dstrebel i am going to adjust this later this evening.


Con::executef trampoline had mismatched argc values for the high end

Con::executef trampoline had mismatched argc values for the high end

T_T

good catch az ;)

mango caught it. just passing it along.


tests: drivers: display: fix filtering

Test was marked build only with filters in each scenario looking for
sdl-dc which is only available on native_sim, so cut the chase and use
platform_only to narrow things down to native_sim directly instead of
building the world to get information we already know.
reduces build/run time from 78s to 17s on invocation of twister with
default options, saves a ton more when running twister with --all.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

@nashif Can you please add an issue with details and link that issue to this PR. After RC2 only bug fixes with a Github issue will be merged into the upcoming 4.0 release.

@nashif Can you please add an issue with details and link that issue to this PR. After RC2 only bug fixes with a Github issue will be merged into the upcoming 4.0 release.

this is not a bug fix or a functional change, this is an optimization for CI.


3.4.1 compile errors on MacOS

This is on:
% uname -a
Darwin irving.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64 i386 MacBookPro11,1 Darwin

which is "10.12.3" in the "About this Mac" dialog.
I run perl Makefile.PL && make and it fails during the compile.
I reran make > out.txt 2>&1, and will attach the resulting file here: out.txt

Thanks @genehack for the bug report. Good news is that I can reproduce the issue on my Yosemite virtualbox machine (you have no idea how long it took me to get this working). Next good news is that you should be able to get a working version with perl Makefile.PL --no-plugins, as noted in the release notes at https://github.com/sass/perl-libsass/releases/tag/3.4.1.
None the less I would like to get this working by default also on Mac OSX. My problem here is that the perl build toolchain is not flexible enough to fully support this use-case. So I had to hack and hook into EUMM to get it working. It might have been a bit premature to release and enable this already and I appologize for the inconvenience, but I also hope you understand that this is the only way for me to really move this forward. I think once it also works on mac, you will be happy with the newly available plugins!
Since I can reproduce it here I'm positive that I can come up with a fix!

http://www.cpantesters.org/cpan/report/07d9547c-d95a-11e6-91f1-a230ca8448b3

The actual problem is that the build file invokes cc instead of g++ when linking the shared libsass library, therefore lacking the c++ symbols. The perl dll was always statically linked against libsass, but this is no longer "desired" with the additional plugins, because each plugins also needs to link against libsass. For now I kept the main perl module dll statically linked and only create a shared libsass dll for the plugins. That is why the default build currently fails on OSX when plugins are enables (which is the default ATM). Worst case scenario would be to just disable the plugins again if there is a wall I can't navigate around!

@genehack I've added a fix in https://github.com/sass/perl-libsass/commit/05d614442e97de2ba587fc5bba04e3a326781825. I hope this does not regress on any other platform. Can you try to build it from current development branch and verify that it works by calling psass --list-plugins after make install? You should get --glob-plugin and --math-plugin.
If you can confirm I will package a 3.4.2 release with these fixes!

Since all my test were positive I went on and released 3.4.2!
Hopefully http://matrix.cpantesters.org/?dist=CSS-Sass agrees with the fixes!

@mgreter Sorry, finally got a chance to go back and check this out - 3.4.2 installed cleanly here. Thanks!


requirement scandir conflicting on HPC

for some reason scandir==1.9.0 conflicts with teh previously installed packages in the list. It says something about python 3.7 being too high for it too...
installing scandir worked, but it installed scandir version 1.10      . Can we increase the requirement for the next release?

why not use python built-in os.scandir, available in python >= 3.5

interesting interesting. I shall check that out 💃

installed a new environment with python 3.8 and it's not crying about this, so no longer reproducible.


Could not find files for the given pattern(s)

Description
To ensure not same issue as #182

Rename .env.example to .env
Config .env file
Listed 8x stores in UK  --- hidden in below example by xx
npm run start

[17:34:28] info :: ℹ selected stores: xx, xx, xx, xx, xx
[17:34:28] info :: ℹ selected brands: yyy, yyy , yyy
[17:34:28] info :: ℹ selected series: zzzz
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
continue to run but only does stores first 1st, 2nd, 5th, 7th stores
Have checked store names as per list and copy/pasted the names as required.
Possible solution
Tried all solutions under issue #183 and check no file extension of .txt - its not, just .env file.

Has to do with sound notifications. Are you running Windows? Could be relevant: https://github.com/jef/nvidia-snatcher/issues/275

Thanks - yes running Windows and also installed the cmdmp3new.zip files into the code folder as detailed in the wiki,

UPD: I have just move the .env out of the folder to see if INFO: cant find files error stop.  Confirmed no messages and defaults used.
Next check is reset the .env file to the default one and run.

Continue to test.
PASS Brands = asus,zotac,evga,msi,gigabyte,palit
PASS UK Stores = amazon-uk,currys,aria,ebuyer,box
FAIL = nvidia (COUNTRY=great_britain) - hangs, does not scan
FAIL = overclockers - hangs, does not scan
FAIL = scan - hangs, does not scan
FAIL = ccl - fails with STATUS CODE ERROR 503
FAIL = novatech - hangs, does not scan
FAIL = very - hangs, does not scan
continuing to verify other changed settings to find INFO root cause.

ROOT Cause identified its the PLAY_SOUND setting on Windows.
PLAY_SOUND=swiftly.mp3
followed the Windows Audio Notification Guide therefore put the file in the folder of the code "nvidia-snatcher" as per wiki guide linked recommends.

FAIL = nvidia (COUNTRY=great_britain) - hangs, does not scan

Just as a heads up, this API is kind of deprecated. Not sure if/when it will be online again.

I also was facing this issue. I added the c files to play the sound which made that portion work. For me the warning is there only when I specify a sound file:
PLAY_SOUND=notification.wav

@jef
The PLAY_SOUND is set as above states
PLAY_SOUND=swiftly.mp3
If I remove the setting to:
PLAY_SOUND=
The warnings not longer appear.
So as a developer I be looking for code which detects a file set to play, then the code its validate players and exclude any players not for Windows if the execution OS is Windows.  As it does play the sound because I have installed the cmdmp3 binaries.

Use PLAY_SOUND=./sound.mp3 if sound.mp3 is in the same folder as streetmerchant.


NSArray type not supported

I'm using this for an iOS application and I'm having an exception thrown for:
*** Terminating app due to uncaught exception 'Type not allowed', reason: 'NSArray type not supported for ClubModel.memberships'
However, it's explicitly declared as an NSArray in the model:
@property(strong,nonatomic) NSArray<ClubMembershipsModel*><ConvertOnDemand> *memberships;
and the ClubMembershipsModel is also declared as a JSONModel:
`@interface ClubMembershipsModel : JSONModel
@property(copy,nonatomic) NSString *joined_at;
@property(copy,nonatomic) NSString *level;
@property(copy,nonatomic) NSString *member_id;
@property(copy,nonatomic) NSString *name;
@property(copy,nonatomic) NSString *picture_location;
@property(copy,nonatomic) NSString *added_by_id;
@property(copy,nonatomic) NSString *added_by_name;`
Because of security issues with Firebase, we have to initialize it in a slightly funny way:
       `NSMutableArray<NSDictionary*> *temparray = [[NSMutableArray alloc] init];
         for (id key in snapshot.value) {
             NSMutableDictionary *newdictmodel = [snapshot.value valueForKey:key];

             [temparray addObject:newdictmodel];
         }
         NSArray<ClubMembershipsModel*> *clubMemberships = [ClubMembershipsModel arrayOfModelsFromDictionaries:temparray error:&error];
          dict = [NSDictionary dictionaryWithObject:clubMemberships forKey:kClubMembershipsKey];`

Any guidance is much appreciated..
Thanks,
RM

ask the same question.. Any guidance is much appreciated..

@suqiang - do not continue this issue. Create a new one please, providing your model code and JSON.

thanks for reply. i have solve the problem. our server is not stable, some it give NSArray when I need  custom object...


Update thumbnail from "edit asset" screen

I've added support to the viewer component. Here's example usage:
function updateThumbnail() {
    let dataURL = viewer.captureThumbnail(512, 384);
    let imageBlob = viewer.dataURLtoBlob(dataURL);
    let img = document.getElementsByClassName('img-preview')[0];
    img.src = dataURL;
    let formData = new FormData();
    formData.append('file', imageBlob, 'thumbnail.png');
    fetch(window.location + '/updateThumbnail', {
        method: 'POST',
        body: formData
    })
        .then(response => response.json())
        .then(data => {
            console.log('Upload successful:', data);
        })
        .catch((error) => {
            console.error('Error uploading image:', error);
        });
}

This code should update the thumbnail preview on the page and also POST a blob to a (non-existent) endpoint.

Admins also need a way to do this for assets they don't own. Maybe the "edit" page can accept a superuser override?


Create a github action that builds the collector container.

See this workflow https://github.com/davidmaceachern/rust-web-template/actions?query=workflow%3ADocker for successful status.


[Disco] Propagate structlog/logging config to workers

This is a follow-up to #16618, which propagates the structlog configuration to disco worker processes.  For configurations that use structlog.stdlib to integrate structlog with the stdlib logging module, this integration must also be forwarded.

This seems straightforward enough, though I'm not aware of the wider context.

Thank you.  For context, some applications use structlog to provide more flexible logging than python's stdlib logging.  The structlog configuration determines what pre-processing is done for the log statements (e.g. appending contextual information to a log statement).  When starting child processes using multiprocessing, it would be useful for the child processes to format/save their logs in the same manner as the parent, but this doesn't occur by default.  In PR#16618, I added handling to forward the structlog configuration from the main process to the tvm.runtime.disco worker processes.
However, some configurations (example from structlog's documentation integrate structlog with the stdlib logging.  The previous implementation only forwarded the configuration held by structlog, and didn't forward the configuration within the stdlib logging.  This PR closes that gap.


assistant.py (404 error)

[2281:2302:ERROR:assistant_nupnp_client.cc(103)] Cloud discovery nupnp request failed: [404]
When I run python assistant.py it shows Hello  Python and this ERROR and when I run Magic mirror(npm start) black screen. Can anyone help me please?

I have configured Google SDK correctly and I am able to use Google push to talk for interacting with Google Assistant. I think I am unable to communicate with pubnub as when I removed Publish, Subscriber keys it still says subscription completed


Correction in the Navbar

Event is written Two times when we open a tab for Chapter.

Hey @laveenahub , thanks for stepping up. This issue has been resolved:)


community[patch]: Update doc-string in CloudBlobLoader

Update doc-string

cc @pprados  please feel free to send another PR if this is incorrect.


Bowtie alignment fails

The standard functionality seems to be working fine (see below).

(see 3rd command) When the left and right reads are supplied, (in this case it fails due to unpaired reads lumped in with the paired reads a la Trinity) no error is provided for the failure of bowtie. Including this output may help the user diagnose the problem with their reads through bowtie2's error report, as it's clear that this is not due to transrate.
Also, I noticed that there is no option for supplying unpaired reads to bowtie2. In my data set, close to half of my Trimmomatic processed read pairs resulted in unpaired reads so this could be a wonderful feature and very easy to implement. I wouldn't mind contributing to this. :)
(see 4th command) I've reached an error that I don't quite understand. Any ideas?

$ ls tranrate
total 2.2M
-rw-r--r-- 1 mrals class 1.2M Jul  9 10:13 CAC_proteins.fasta
-rw-r--r-- 1 mrals class 139K Jul  9 10:13 Trinity-GG.fasta
$ which bowtie2
/usr/local/bowtie2-2.1.0/bowtie2
$ transrate -a Trinity-GG.fasta --left ../tmp/left.fq --right ../tmp/right.fq -t 4
[ INFO]: Loading reference dataset
[ INFO]: Loading assembly: Trinity-GG.fasta
[ INFO]: Analysing assembly: Trinity-GG.fasta
[ INFO]: Calculating contig metrics...
[ INFO]: Contig metrics:
[ INFO]: -----------------------------------
[ INFO]: n seqs                          146
[ INFO]: smallest                        204
[ INFO]: largest                        5355
.
.
.
[ INFO]: at skew                        0.02
[ INFO]: cpg ratio                      0.47
[ INFO]: bases n                           0
[ INFO]: proportion n                    0.0
[ INFO]: linguistic complexity          0.16
[ INFO]: Contig metrics done in 0.4012817 seconds
[ INFO]: Calculating read diagnostics...
/home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/read_metrics.rb:91:in `analyse_read_mappings': samfile /home/mrals/ETP/tranrate/left.fq.right.fq.Trinity-GG.sam not found (RuntimeError)
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/read_metrics.rb:35:in `run'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/transrater.rb:93:in `read_metrics'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:157:in `block in <top (required)>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:123:in `each'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:123:in `<top (required)>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/transrate:23:in `load'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/transrate:23:in `<main>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/ruby_executable_hooks:15:in `eval'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/ruby_executable_hooks:15:in `<main>'
$ ls
total 19M
-rw-r--r-- 1 mrals class 1.2M Jul  9 10:13 CAC_proteins.fasta
-rw-r--r-- 1 mrals class    0 Jul  9 10:15 left.fq.right.fq.Trinity-GG.sam
-rw-r--r-- 1 mrals class  414 Jul  9 10:15 transrate.csv
-rw-r--r-- 1 mrals class 4.1M Jul  9 10:15 Trinity-GG.1.bt2
-rw-r--r-- 1 mrals class 260K Jul  9 10:15 Trinity-GG.2.bt2
-rw-r--r-- 1 mrals class 1.3K Jul  9 10:15 Trinity-GG.3.bt2
-rw-r--r-- 1 mrals class  33K Jul  9 10:15 Trinity-GG.4.bt2
-rw-r--r-- 1 mrals class 139K Jul  9 10:13 Trinity-GG.fasta
-rw-r--r-- 1 mrals class 4.1M Jul  9 10:15 Trinity-GG.rev.1.bt2
-rw-r--r-- 1 mrals class 260K Jul  9 10:15 Trinity-GG.rev.2.bt2
$ transrate -a Trinity-GG.fasta --left ../final/finalfastq/NS30A.fastq.1.gz --right ../final/finalfastq/NS30A.fastq.2.gz -t 4
[ INFO]: Loading reference dataset
[ INFO]: Loading assembly: Trinity-GG.fasta
[ INFO]: Analysing assembly: Trinity-GG.fasta
[ INFO]: Calculating contig metrics...
[ INFO]: Contig metrics:
[ INFO]: -----------------------------------
[ INFO]: n seqs                          146
[ INFO]: smallest                        204
[ INFO]: largest                        5355
.
.
.
[ INFO]: proportion n                    0.0
[ INFO]: linguistic complexity          0.16
[ INFO]: Contig metrics done in 0.3956906 seconds
[ INFO]: Calculating read diagnostics...
[ERROR]: reached the end of assembly enumerator while there were contigs left in the coverage results
[ERROR]: final assembly contig: GG30
[ERROR]: coverage contig: GG1|c0_g1_i1
/home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/assembly.rb:217:in `next': iteration reached an end (StopIteration)
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/assembly.rb:217:in `block in each_with_coverage'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/assembly.rb:205:in `each_line'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/assembly.rb:205:in `each_with_coverage'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/read_metrics.rb:216:in `analyse_coverage'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/read_metrics.rb:36:in `run'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/lib/transrate/transrater.rb:93:in `read_metrics'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:157:in `block in <top (required)>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:123:in `each'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/gems/transrate-0.2.0/bin/transrate:123:in `<top (required)>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/transrate:23:in `load'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/transrate:23:in `<main>'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/ruby_executable_hooks:15:in `eval'
        from /home/mrals/.rvm/gems/ruby-2.0.0-p247/bin/ruby_executable_hooks:15:in `<main>'

All these issues have either been solved, or are now redundant as we have moved to SNAP


As a developer, I need to provision shared Azure resources so that I can host and run an application.

Description
Shared Azure resources are resources or services that are managed by a different group/team and have a different management life-cycle than application-specific resources or services.
This pattern assumes the following shared Azure resources and services:

Azure Key Vault
Virtual Network

Requirements

Azure CLI
Terraform
Key Vault
Azure AD (AAD)

Acceptance Criteria:

A resource group is provisioned.
A Key Vault resource is provisioned in the resource group.
User can run a script from the command-line to deploy the template.

Given input company 'cblt'
and input location 'eastus'
when terraform apply is run
then a resource group in East US exists with the name 'core-infra-eus-cblt'
and a Key Vault exists with the name 'core-kv-eus-cblt' in resource group 'core-infra-eus-cblt'
Notes
The resource group created in #30 can be repurposed for the resource group needed here.

@rickrain  I think that instead of company we should use project to avoid collisions if two project groups within the same company implement this.

@rickrain  I think that instead of company as an input we should use project to avoid collisions if two project groups within the same company implement this.

@code4clouds Agree.  We have refined this thinking and documented the naming convention standard in the wiki for future work against user stories.  However, for this user story please follow the AC as it is written and we'll add another enhancement issue for the next sprint.


Handle pagination in student roster LTI requests

Motivation and Context

Canvas uses a links header similar to github to provide pagination information. we were not correctly handling paginated data so this PR fixes that behavior.
Additionally, this PR allows instructors to be synced via the sync function. Added a checkbox on the modal for instructor syncing, which is checked by default.
Your Changes

Description:
Moved acquiring roster information to its own method, and then repeatedly calls it as long as there is a next link in the headers.
Type of change (select all that apply):

[x] Bug fix (non-breaking change which fixes an issue)
[x] New Feature

Testing

Tested in browser by forcing canvas pagination (using ?per_page=1 as a GET param). Also added tests to ensure that when paginated data is present, all data is retrieved correctly from each page and appropriate records are created. Also tested syncing instructors in browser.
Questions and Comments (if applicable)

Checklist

[x] I have performed a self-review of my own code.
[ ] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[x] I have added tests for my changes.

Pull request to make documentation changes (if applicable)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

94 of 96 (97.92%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 91.815%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/controllers/courses_controller.rb
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

app/controllers/courses_controller.rb
1
86.11%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
39274

Relevant Lines:
42153

💛  - Coveralls


Update parchment.debug.js

Auto-scrolling for Chrome (fix issue https://github.com/curiousdannii/parchment/issues/50)

I'll add that I've tested this fix with Firefox, Chrome and Edge on Windows 10, plus Chrome and Firefox on Android, and auto-scrolling works fine on all of these.

I don't think this preserves the behaviour as it was meant to be: to scroll down but ensure the beginning of this turn's input is on screen.
Does anyone know why the current code doesn't work?
I'm still open to merging this, however you'll need to edit src/structio/input.js instead, and rather than intercepting the call to scroll(), please put the test inside that function.

line: 163 "parchment/src/structio/input.js"
self.scrollParent = /webkit/i.test( navigator.userAgent ) ? $body : $( 'html' );

If "self.scroolParent = $body", then "this.scrollParent.scrollTop()" always is 0.
For Chrome need "$( 'html' )", but Microsoft Edge need "$body".


Adding bdist_wheel in the list of distributions

#32

@AlexBulankou,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Can you retarget this PR to be against develop?


Load from QR: Electron cash was unable to parse your transaction

Hello,
When I attempt to load an Electron transaction from the QR scanner in Debian/Ubuntu, I get: "Electron cash was unable to parse your transaction".
I can load from QR using Electrum and Electrum-LTC, but Electron Cash is failing.
Details below:
Traceback (most recent call last):
File "/home/estevao/Downloads/Electron-Cash-2.9.4/gui/qt/main_window.py", line 1995, in tx_from_text
tx.deserialize()
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 588, in deserialize
d = deserialize(self.raw)
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 458, in deserialize
d['outputs'] = list(parse_output(vds,i) for i in xrange(n_vout))
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 458, in
d['outputs'] = list(parse_output(vds,i) for i in xrange(n_vout))
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 436, in parse_output
d['value'] = vds.read_int64()
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 109, in read_int64
def read_int64(self): return self._read_num('<q')
File "/home/estevao/Downloads/Electron-Cash-2.9.4/lib/transaction.py", line 147, in _read_num
(i,) = struct.unpack_from(format, self.input, self.read_cursor)
error: unpack_from requires a buffer of at least 8 bytes

Excuse me, I will test with the new release and get back to this issue.

This issue was solved in release 3.0.


Build and test with dist archive

https://github.com/tailix/libkernaux/commit/39aeb141ab9338fcdc179e46faed5adbcb125a17


onlyAnalyze does not consider subpackages

I'm using version 5.0.5 of the plugin.
With onlyAnalyze = ['com.something.*'] a class with package com.something will be analyzed, but not if the package is com.something.foo. I think it's more intuitive to have a recursive meaning for "*". If this is not possible, I'd love to see a warning and a possible workaround.

I think it should be com.something.- to also include subpackages:
https://spotbugs.readthedocs.io/en/stable/running.html?highlight=onlyanalyze#text-ui-options

the document already explains how-to, so I will close this issue.


vagrant: Default to NFS in the dev. VMs

This pull request defaults the development VMs to NFS and removes support for rsync. Rsync support has been broken for a few Go releases because it's too slow and now results in many interrupted system call errors.

@pchaigno time make precheck on the dev VM on OSX Catalina is 3-4 times slower with NFS than without NFS:
on master after this was merged, with NFS:
$ VM_CPUS=6 VM_MEMORY=8192 time ./contrib/vagrant/start.sh
...
      830.58 real        12.13 user         3.63 sys

$ time make precheck
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
contrib/scripts/check-log-newlines.sh
contrib/scripts/check-missing-tags-in-tests.sh
contrib/scripts/check-assert-deep-equals.sh
contrib/scripts/lock-check.sh
contrib/scripts/rand-check.sh

real	1m33.677s
user	0m5.644s
sys	0m8.044s

$ time make precheck
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
contrib/scripts/check-log-newlines.sh
contrib/scripts/check-missing-tags-in-tests.sh
contrib/scripts/check-assert-deep-equals.sh
contrib/scripts/lock-check.sh
contrib/scripts/rand-check.sh

real	1m20.231s
user	0m5.416s
sys	0m7.524s

Master on commit preceding this PR; no NFS, defaulting to VirtualBox file sharing:

$ VM_CPUS=6 VM_MEMORY=8192 time ./contrib/vagrant/start.sh
...
      658.12 real        11.71 user         3.38 sys

$ time make precheck
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
contrib/scripts/check-log-newlines.sh
contrib/scripts/check-missing-tags-in-tests.sh
contrib/scripts/check-assert-deep-equals.sh
contrib/scripts/lock-check.sh
contrib/scripts/rand-check.sh

real	0m29.998s
user	0m3.960s
sys	0m16.600s

$ time make precheck
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
contrib/scripts/check-log-newlines.sh
contrib/scripts/check-missing-tags-in-tests.sh
contrib/scripts/check-assert-deep-equals.sh
contrib/scripts/lock-check.sh
contrib/scripts/rand-check.sh

real	0m23.349s
user	0m3.456s
sys	0m17.600s

@aanm ^^^ IMO we should default to NFS only when running vagrant from Linux.


Reactive blaze data not updating.

If I write something like :

The data-tooltip attribute will update reactively but the the tooltip content won't. Is that the expected behaviour?

That's expected for now. I haven't figured out a nice, user friendly way of doing reactive tooltips yet, mostly due to Blaze limitations in regards to having reactive stuff in attributes.
This is for sure needed, so I'd love to have it. PRs are welcome too.

Replacing
$el.data('tooltip')

with
$el.attr('data-tooltip')

on line 81 does the trick! The reason is that jquery method .data() does not updates its data- cached objects when attributes change... which is a pitty... see this SO post. I didn't offer a PR since I didn't get exactly how your tooltip-element worked, and it woud have been awkward to have this feature half implemented!

Fixed in master.


Invalid GPIO references in the avnet_sk_demo app_manifest.json cause build issue

Hey @bawilless , I spotted a build issue with the avnet_sk_demo sample.
In the app_manifest.json file there are two references to
    "$SAMPLE_LSM6DSO_I2C_SDA_GPIO",
    "$SAMPLE_LSM6DSO_I2C_SCL_GPIO"

that are not present in the sample_appliance.json file.
Cheers Dave

Thank you Dave,
I reverted the accidentally committed changes.
I was trying to find a way to reset the i2c bus.  I’m not sure if you’ve ever seen this, but sometimes the i2c bus get hung and the application can’t access/read the on-board sensors.
I was not sure how the Sphere development environment would allow this because the application needs to declare the i2c ISU in the app_manifest and also two GPIOs that share the same pins.  I remember a long time ago, this was not allowed, but yesterday I was able to declare these resources and open the GPIOs the correspond with the SDA and SCL pins.
My attempt to clear the locked up bus failed, I tried to follow the guidance in this app notehttps://www.analog.com/media/en/technical-documentation/application-notes/54305147357414AN686_0.pdf.  The hang can be cleared by power cycling the device.
Brian
From: Dave Glover @.***
Sent: Tuesday, September 21, 2021 1:45 AM
To: Azure-Sphere-DevX/AzureSphereDevX.Examples @.>
Cc: Willess, Brian @.>; Mention @.***>
Subject: [External] [Azure-Sphere-DevX/AzureSphereDevX.Examples] Invalid GPIO references in the avnet_sk_demo app_manifest.json cause build issue (#5)
Hey @bawillesshttps://github.com/bawilless , I spotted a build issue with the avnet_sk_demo sample.
In the app_manifest.json file there are two references to
"$SAMPLE_LSM6DSO_I2C_SDA_GPIO",

"$SAMPLE_LSM6DSO_I2C_SCL_GPIO"

that are not present in the sample_appliance.json file.
Cheers Dave
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure-Sphere-DevX/AzureSphereDevX.Examples/issues/5, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ5SQW6BCV7RIQOPP3BOW7TUDALUJANCNFSM5ENROS6A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Fix the project web

broken links - mostly quick links to guides in the right side box
broken UI - some pages have eclipse theme, others jakartaee

something like this has to be done here

All I wanted to do today was to hit the merge button and send the announcement instead of doing last minute fixes (#76). I've been waiting too long for this already.


Explicitly require TLS 1.2

ApiPort already uses TLS 1.2 by default, this just makes that requirement explicit so that we're always sure to use the TLS 1.2 protocol.
The PR is slightly complicated by the fact the NetCore and NetFX have different ways of doing this.

It would be nice if the feature flags for this were inverses of each other - otherwise it's not transparent that they have mutually exclusive uses.

Yea, that's a good point. I made two #ifs since it's not the case that there's a "preferred way" and a fallback. There are two ways of doing this and both are unsupported in some .NET profiles. Since we only build for net46 and netstandard1.3, I could change this to just have a single #if (probably FEATURE_SERVICE_POINT_MANAGER) and replace #if FEATURE_CLIENT_HANDLER_SET_SSL_PROTOCOLS with #if !FEATURE_SERVICE_POINT_MANAGER.


Fix Ci/Cd

Problem
Gitleaks require a free License Key.
Key need to be re-generated from time to time.
Steps to reproduce
Commit on main
Expected behavior
When no leaks are present, expect a mirror on school repo
Commit SHA
2cf40f7f3747b9170e7965b792e6cd5ae66ef16e
Versions
Irrelevant
Previous tryes
Sent 2 requests to get new License Keys.
Awaiting response.
Expected priority
Should
Proper writing

[X] I agree.

Gitleaks came back to life, for some reason


fix issue #12

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Coverage increased (+1.0%) to 92.899% when pulling 653aacb462722b4ee61c06216b1615b93dc957b1 on dev into db405b2ec83882f0f427cb24f34b507d8d85763e on master.


Add squirrel event handling

So that once the app is packaged using squirrel, it doesn't wait ~10 seconds on every launch and then restart.

merged


Sync published with master

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit<PHONE_NUMBER>0e5a96180b7aaa70e41069eeb82eca
https://deploy-preview-8685--docsdocker.netlify.com


InterceptHandler doesn't work well on 3.11 (hashtag760)

On Python 3.11, logs now contain logging:callHandlers:1706 instead of the actual log location.
import logging
from loguru import logger

class InterceptHandler(logging.Handler):
    """Intercept logs from logging into loguru."""

    def emit(self, record: logging.LogRecord) -> None:
        """Emit the actual logrecords into logger."""
        hashtag Get corresponding Loguru level if it exists
        try:
            level = logger.level(record.levelname).name
        except ValueError:
            level = record.levelno

        hashtag Find caller from where originated the logged message
        frame, depth = logging.currentframe(), 2
        while frame.f_code.co_filename == logging.__file__:
            frame = frame.f_back
            depth += 1

        logger.opt(depth=depth, exception=record.exc_info).log(
            level, record.getMessage()
        )

logging.basicConfig(handlers=[InterceptHandler()], level=0)
logging.getLogger(__name__).info("foo")

Prints out 2022-12-04 09:59:55.016 | INFO     | logging:callHandlers:1706 - foo on 3.11, and 2022-12-04 10:00:09.067 | INFO     | __main__:<module>:31 - foo on 3.10

It looks like it's already been fixed on the master branch :)

I was also facing this while trying to intercept uvicorn logs...
I managed to fix it with the following change:
while (
    frame.f_code.co_filename == logging.__file__ or
    frame.f_code.co_filename == __file__
):
    frame = frame.f_back
    depth += 1


server: fix data race

This fixes the detected race.
Fixes #534

Codecov Report

Merging #536 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   39.09%   39.15%   +0.06%
==========================================
  Files         121      121
  Lines        6065     6055      -10
==========================================
  Hits         2371     2371
+ Misses       3510     3500      -10
  Partials      184      184

Impacted Files
Coverage Δ

core/dnsserver/server.go
0% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa3030...79736b3. Read the comment docs.


Update testutils to ignore trace headers

What does this PR do?
The PR add trace headers to ignore list.

Fix failing CI test on this PR: https://github.com/DataDog/datadog-api-spec/pull/355
If the headers are not ignored, the headers will never match and new test will fail
Additional Notes

Review checklist
Please check relevant items below:

[ ] This PR includes all newly recorded cassettes for any modified tests.

[ ] This PR does not rely on API client schema changes.

[ ] The CI should be fully passing.

[ ] Or, this PR relies on API schema changes and this is a Draft PR that includes tests.

Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

/azp run


[nrf fromtree] twister: scripts: Split lines before processing

Readline method sometimes receives more lines in buffer. Split them to avoid misinterpreting data in harness module.
(cherry picked from commit 79ef0b6b10dd97d8e734fe6a4104fe3bc5589640)

original PR: https://github.com/zephyrproject-rtos/zephyr/pull/77352
This change is required to pass tests from: tests/boot/mcuboot_recovery_retention

added also changes to fix CI on Python 3.12:
https://github.com/zephyrproject-rtos/zephyr/pull/76880
https://github.com/zephyrproject-rtos/zephyr/pull/77077


connectionString not honored when passing connection details

When attempting to establish a pooled connection using connectionDetails that specify a connectionString and not a server, the following code block fails:
https://github.com/OHDSI/ResultModelManager/blob/c1be23c5aa26508acb6b7f9d826aef285871db3e/R/PooledConnectionHandler.R#L46-L53
Perhaps the easiest path here is to validate that the connectionDetails object has all of these attributes set when the constructor is called?

I have removed the use of RPostgres as it was not being used and prevented this issue from being fixed, this is resolved in develop and will make its way into the next release


Moderation medium-term goals

To implement by end of Q4 2020
This section is for steps we should/could be taking in the moderation project that require a bit more thinking or discussion for how we can best implement it in the Open Collective way (or because they are more difficult to implement and will need more time to build).
1. Block account from contributing/interacting
As a next step beyond rejecting a contribution, we could give admins of a Host/Collective the ability to block certain accounts from interacting in any way (contributions, expenses, comments, etc). Blocking an account from any interaction is generally a basic moderation feature on most platforms, so it’s an important step for us in this project. This would essentially automate what is currently a manual job where Open Collective engineers limit certain accounts’ features in the database, except it would only pertain to a single Host/Collective.
Mechanism of action: On the Collective page in the contributors section, we could add a button which appears only to admins of the Collective (in the same way the ‘edit’ button appears only to Collective admins on the recurring contributions card). As an MVP it can just be a ‘Block’ button, which would prevent the contributor from interacting with the Collective any further.
Currently open issues:

Ban user: https://github.com/openCollective/openCollective/issues/2737

2. Allowing Collectives to pre-approve all contributions before they are made
While allowing Collectives to block certain accounts is important, as some have mentioned, for popular/high volume projects this could become a task in itself. Or, even for smaller projects who care a lot about vetting each and every donor, this could become an overwhelming task.
A potential solution would be to allow a toggle for the Collective to turn on saying that every contribution goes into a queue to be accepted or rejected before appearing on the page. It wouldn’t be on by default, so we don’t interfere with how Open Collective currently works. But it can be an important feature for Collectives or Hosts who desire more control over their contributors.
Additionally, this would help to prevent issues with having to give refunds. If we don’t take a contribution til it’s approved, then we don’t have to issue refunds if it becomes ‘rejected’. A further step would be that you can ‘approve once’ or ‘approve indefinitely’, but of course this can be rejected at any time if you decide that you no longer wish to receive contributions from a sponsor.
3. Allow Collectives to ‘filter’ the sponsors they show on their Collective page better
While some Collectives are okay with receiving contributions from certain sponsors, they might like finer control over who is shown in the ‘top contributors’ section. They may want to hide certain donors, or for a positive example spotlight a contributor because of a special arrangement who has given a low amount and wouldn’t normally show up in the top contributors. However, this would involve a quite fundamental change in the way Open Collective works, especially regarding our value of 'transparency', and this warrants further discussion into how, why, and if we should do it.
Mechanism of action: similar to above, on the Collective page contributor cards, admins would have a button to open a menu (like on recurring contributions card) or modal (like with paying expenses) to edit the member. This would include adjusting the tier of the sponsor and hiding the sponsor from the top contributor’s section. In order to make it easy to see all the ‘hidden’/filtered sponsors in one place, we could add an additional filter tag at the top of the contributor section (called “Hidden” for example).
Currently open issues:

Allow admins to edit Collective members: https://github.com/opencollective/opencollective/issues/2097

4. Reject contribution/block account interaction modal with more options
As an iteration on the block/deny from the short-term list, we can add to the reject contribution or block user UI and ask if you want to remove the member from Collective, hide past contributions/expenses/etc, report for moderation etc, and add a message to the account if necessary.
5. Automate stuff like @Betree’s ‘search and destroy spammers’ monthly job into a cron job:
If we are confident in certain keywords that we are removing each month, to reduce burden on the team and free up time to work on other parts of the moderation project. These accounts are usually true ‘spam’ (they sign up profiles and link to keto sites for the backlinks) and rarely interact (contribute, make expenses, etc) as Ben has pointed out, so we wouldn’t really have to limit their actions between the clear-outs.

Following the implementation of our short-term goals, we'll be seeing how these go in the first half of Q4 then reconsider these goals and see how we want to move forward.

I believe this issue is outdated and should be closed. Allowing Collectives to pre-approve all contributions before they are made can be moved to its own issue. @znarf any blocker?


Fix when bridging to Swift

// NSString+MDCCompare.h
+ (BOOL)mdc_sameCharacterAtLeft:(NSString *)left index:(NSInteger)leftIndex
                          right:(NSString *)right index:(NSInteger)rightIndex;

// NSString+MDCCompare.m
+ (BOOL)mdc_sameCharacterAtLeft:(NSString *)left index:(NSInteger)leftIndex
                          right:(NSString *)right index:(NSInteger)rightIndex {
	if (leftIndex >= 0 && rightIndex >= 0)
		return [@([left characterAtIndex:leftIndex])
                compare:@([right characterAtIndex:rightIndex])] == NSOrderedSame;
	else
		return NO;
}

Otherwise it bums out with an EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)

Cool--thanks, @cobysy! Could you submit this change as a pull request?

I have the strong feeling that this is already fixed by my codechange. I thought about correcting it the same way, but if x is an NSUInteger, x = 1 and x = x-2 => x == [pretty big integer - depending on 32 or 64bit platform]. Since mdc_sameCharacterAtLeft:... is called with a value of this kind, leftIndex >= 0 won't prevent the out of bounds exception.
You could maybe write something like (leftIndex >= 0 &&  leftIndex < left.length && rightIndex >= 0 && rightIndex < right.length but this might not work with special unicode chars. I'm not 100% sure, hence I corrected it at the x=1, x=x-2 section.


Implemented Named sessions so new-tab and other commands can be executed on an existing session

Description of the new feature/enhancement
The ability to defined a named sessionId to wt.   If the sessionId does not exist, a new session would be created. And if the sesssionId does exist, then the commands would be applied to the existing session.  This would allow users to minimize the number of wt windows.

Proposed technical implementation details (optional)
As an example, if I am working in Windows explorer I could type wt --sessionId="someSessionId"; new-tab -d . in the address bar (or wire this command into a context menu), and it would open a new tab at the end of my existing someSessionId and bring my existing wt session to focus with the new tab in focus.

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #4472 for more discussion.
/dup #4472


WIP GH-56 Refactor to use pointers for all fields.

Refactors fields to be pointers
Adds a few setters for common types.

Needs work to let acceptance tests TestCreateAndDeleteMonitor and TestCreateAndDeleteDowntime pass.
Needs discussion of getters next to the current setters.

@zorkian feel free to push changes to this branch, I've pushed it here with that in mind.

Made all acceptance tests pass too.

Should we switch from int to json.Number everywhere? In most cases it doesn't matter but it feels like it might be useful to standardize instead of having to guess/worry about getting it wrong.

I agree we should be consistent. I'll keep off doing that until we are sure what direction we are going.

For helpers, what do you think about the way protobufs create GetFoo helpers for each member and handles returning the language-default rather than a possibly-nil which is right most of the time, and if someone really wants to see if it's nil they can inspect the member. (The comma ok idiom is very verbose.) I'm interested in keeping the API simple to use, but correct. Any thoughts?

I don't have experience with protobufs, can you share a code snippet on how a client would use it, and how we would code those getters? Definitely a fan of finding a clean way of not having to use the comma ok idiom too.

I mentioned in one place but there is inconsistency around the deployment of omitempty or not. Maybe we should just put it everywhere and leave it up to the user to make sure they set the fields they need to set. Since the DD API will error if they do it wrong, it saves us from getting mismatched expectations -- i.e. if DD decides to make something optional and the library is forcing it, someone has to patch it before they can use it which is a bummer.

Agreed and implemented.

And as an aside, I'm going to do an experiment -- protobufs actually have a marshal-to-JSON option. I'm wondering if I write a proto definition for these API methods if it would Just Work or if the JSON it outputs can't be made compatible with DD's API? Worth a shot anyway.

Interested to see how you go! Will Norris started to port go-github to use protobufs but ended up reverting that and cherry picking some of protobufs functionality. See this comment https://github.com/google/go-github/issues/19#issuecomment-22976895 .

I don't have experience with protobufs, can you share a code snippet on how a client would use it, and how we would code those getters? Definitely a fan of finding a clean way of not having to use the comma ok idiom too.

I was thinking like this: https://play.golang.org/p/sh2M9cIs-2
That'd be pretty annoying to have to build ourselves though, but maybe some awk/sed/scripting can generate it appropriately. Or, actually, something like this:
https://play.golang.org/p/Cq9dWFqAd0
If we throw that in some autogen/ package it can import all the structs and then dump out the appropriate methods. If we were really fancy it could just automatically rewrite the source files or something. (Or possibly some magic with gofmt -r but I don't know how advanced that can get.)
Okay sorry, I've gone off a bit into the weeds here. I think easy-to-use is a noble goal if we can achieve it, but I'm not asserting that having Get... and Has... methods is the way to go. I kind of like the simplicity but it is a lot of work to maintain.

Am reaching out to Datadog folks if we could get a service descriptor from them.
Generating the whole library a la https://github.com/google/google-api-go-client or https://github.com/aws/aws-sdk-go would be an direction I'd be interested in to work on.
@zorkian thoughts?

Datadog is not going to work on publishing their API any time soon 😞
On a more positive note I've coded something up that generates HasXx, GetXx and SetXx. Using it would look like:
	m := datadog.Monitor{}
	c := datadog.Creator{}

        // Use SetXx:
        c.SetName("Joe Creator")
	m.SetName("Monitor all the things")
	m.SetMessage("Fat electrons in the lines")

	// Use HasXx:
	if m.HasMessage() {
		fmt.Printf("Found message %s\n", m.GetMessage())
	}

	// Or maybe you prefer a tuple with the value and a boolean if it was ever set
        // and use GetXxOk
	if v, ok := m.GetMessageOk() ; ok {
		fmt.Printf("Found message %s\n", v)
	}

I still like having the other helpers around, and keep support for doing:
	// You could still initialize the struct in one swoop
	_ = datadog.Monitor{
		Name: datadog.String("Monitor other things"),
		Creator: &datadog.Creator{
			Name: datadog.String("Joe Creator"),
		},
	}

I'll push up some changes to this PR hopefully today, else tomorrow.

@zorkian thoughts? This PR is getting a little large, and has been out for a while.
AFAICS this is good to go to v2. Keen to hear your feedback.

I did run the generator, not a 100% if it contains all the changes. All generated accessors are in datadog-accessors.go which did not show up as a diff as it is a new file. We could also chose to have the accessors closer to the code structs. Up to us.
Thanks for the review @zorkian! Yes code regeneration will have to be run manually, I imagine we could be smart about this and have a make target that verifies that code has to be regenerated. For now I will merge this and we can get fancier later.
I might have a stab at updating Terraform to use the new version of the library and see if I run into issues. We could also entertain adding instructions on how to use the new branch to master.


Track OSIE version information

Normally I'd create a file called VERSION that would get packaged up and could be read from, but since we're generating multiple containers, ensuring access to this file gets a bit complicated. So I thought it would be easier to template some variables in specific OSIE scripts that could be substituted at build time.
Consider this an RFC pull request and if we can get consensus on the technical approach for this, there are several more areas where we can make use of this version information - e.g, sending it to hegel on initial connection.

What do you think about just including it as args in the dockerfile and creating a .env file during build time that can just get sourced?

@mikemrm That's an interesting idea. I think I like it. That way those variables could be referenced in any of our scripts and not have to be set manually in each one. I'll hold off on going that route until @mmlb has chimed in with feedback too.


DIAnalysis doesn't work when you have only one dataset

When only one dataset is loaded the analysis will not work. You need at least two datasets before the analysis can occur.
Test was done when loading only example6a.txt

This issue was related to an error within the key identification routine which was not returning anything when only a single line of DI data is investigated. Issue is solved by commit 74b537a6e36b47d2647cb31e3730cabaf040376c. Version 1.1.3 will contain this correction


Move mocking from being global to local

Facilitates future system testing

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c8ff4a5) 84.63% compared to head (a6d42c6) 86.22%.

Files
Patch %
Lines

src/epics_containers_cli/dev/dev_commands.py
84.61%
2 Missing :warning:

src/epics_containers_cli/docker.py
87.50%
2 Missing :warning:

src/epics_containers_cli/ioc/k8s_commands.py
88.88%
2 Missing :warning:

src/epics_containers_cli/ioc/local_commands.py
91.66%
2 Missing :warning:

src/epics_containers_cli/shell.py
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   84.63%   86.22%   +1.58%
==========================================
  Files          18       18
  Lines         989      987       -2
==========================================
+ Hits          837      851      +14
+ Misses        152      136      -16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Getting null in exceptions when worker failed

Describe the bug
When a worker fails, wants to get an exception message but gets null.
Component
Fhir SyncWorker
To Reproduce
Steps to reproduce the behavior:

Pass wrong token while execute worker
run the worker
check Failed SyncJobStatus
See error

Expected behavior
Once a worker failed should get exceptions
Additional context
getting this from FhirSyncWorker:
Received result from worker Failed(exceptions=[ResourceSyncException(resourceType=List, exception=retrofit2.HttpException: HTTP 500 Server Error), ResourceSyncException(resourceType=Patient, exception=retrofit2.HttpException: HTTP 500 Server Error), ResourceSyncException(resourceType=Questionnaire, exception=retrofit2.HttpException: HTTP 500 Server Error)]) and sending output Data {StateType : com.google.android.fhir.sync.SyncJobStatus$Failed, State : {"timestamp":"2023-12-15T11:40:32.5007+05:30"}, }
while observing getting this:
Exceptions: Failed(exceptions=null)

@jingtang10
@fredhersch
@aditya-07
@santosh-pingle

closing in favour of #1654


Re-indent gRPC example

This is my first contribution!
This PR contains only re-indent :)

Nice catch! However, we don't directly modify this repository. The examples are copied from https://github.com/line/armeria/blob/10f1d3c1e5d3cac6402bc7d1dc9f8d86a96e5857/examples/grpc/src/main/java/example/armeria/grpc/Main.java#L47 when we release a new version. Could you send a PR to https://github.com/line/armeria?

Of course! Thank you for your comment :-)
I will send a PR to https://github.com/line/armeria

I sent the PR below, so I will close this PR :-)

https://github.com/line/armeria/pull/3738


Display readme.md in About page

@yongjun21

@yongjun21 take a look at the about.md and https://getaflat-pr-56.herokuapp.com/


changing generators to write out .md files again

Even though documentjs is not installed by default, we're still going to
write out .md files so if you decide to add documentjs later you won't
have to go back and add docs for everything you've generated.

Coverage remained the same at 97.473% when pulling b99d13473dc6ae62ea5f5e90a94b26f15a4996bd on restore-md-files into 3017fb5e364bb71eff6796996d2f4c919c76fdc1 on major.


NIFI-8320: Fix column mismatch in PutDatabaseRecord

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
There are two index mappings in PutDatabaseRecord, one for included record fields and a missing one for table columns. The code erroneously used the record field index which may not map to the same column index in the table. This change does a name lookup to get the column corresponding to the record at the field index, and uses that to determine data type.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@mattyb149 Can you please also include a testcase of incorrect column ordering while providing values. I ended up creating a duplicate PR https://github.com/apache/nifi/pull/5043. However, an important testcase can be included from there. Thanks.


Write a Java program to convert hexadecimal to decimal

Description
Write a Java program to convert hexadecimal to decimal
Hexadecimal is a base-16 number system. It uses sixteen digits: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, and F. The digits are called hexits. A hexit is the smallest unit of information in a computer. A hexit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, or F, or it can be used to represent a single state, such as on or off.
To convert a hexadecimal number to decimal, we can use the following algorithm:

Multiply the first hexit by 16^0.
Multiply the second hexit by 16^1.
Multiply the third hexit by 16^2.
Multiply the fourth hexit by 16^3.
Repeat steps 3 and 4 until the last hexit.
Add the results of all the multiplications.
The decimal number is the sum of all the multiplications.

Input  : A
Output : 10

How to contribute

Save the solution in ConvertHexadecimalToDecimal.java file
Add ConvertHexadecimalToDecimal.java file in convert-hexadecimal-to-decimal folder

!assign

!assign

Hey @Vignesh-dev07,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


Use withdrawal key rather than withdrawal credentials

The contract takes withdrawal credentials at https://github.com/ralexstokes/deposit-contract-verifying-proxy/blob/master/contracts/deposit_contract_proxy.sol#L8  It would be nice if it took the withdrawal public key instead, and carried out the hash/prefix operation in-contract to provide at least a minimal check of the withdrawal credentials.

The declaration given on line 8 is part of the language-level interface of the deposit contract.
We could take the withdrawalPublicKey as a parameter along with or in lieu of this https://github.com/ralexstokes/deposit-contract-verifying-proxy/blob/master/contracts/deposit_contract_proxy.sol#L413
input to verifyAndDeposit.
Pros:

increased "peace of mind" as it moves more logic into what should be an audited contract

Cons:

(minimal) increase in gas
A bug here does mean the validator can't withdraw so potentially even more downside than losing a single deposit of ETH

And an alternative to consider:
This has been surfacing in other offline conversation but one option would be to expose the code for this operation (calling a function prepareWithdrawalCredentials(bytes publicKey) public pure returns (bytes32)) and leave orchestration to the caller, i.e. not include this in verifyAndDeposit. I'm thinking it over but it likely makes sense to just have both options

Ah yes, wrong interface, sorry.  But yes, if you take the withdrawal public key in to the proxy contract it would catch any errors the user or code may have had in creating the withdrawal credentials.  If you really wanted to go to town then passing in a message signed by the withdrawal private key as well as the withdrawal public key could act as a crude form of proof of custody.  This would up the gas cost a fair bit, but would provide a much higher level of confidence that the submitter actually held the private key for the provided public key.
If you're thinking of having a verify() separate to a verifyAndDeposit(), where verify() does everything except pass the transaction on to the deposit contract, that would give people good flexibility to choose if they want to spend the extra gas verifying on-chain or not.  Perhaps if the proof of custody piece went in to prepareWithdrawalCredentials() that could (partially) solve the problem of verifying two signatures and significantly increasing the transaction gas costs as a result.

I would go with

Verify
Deposit
Verify and deposit

Just seems like a good fit, given this contract is explicitly for those who want the extra security.


Publicize conda-metadata-app through the conda-forge.org/packages page

https://conda-forge.org/packages lists all conda-forge packages and their feedstocks. We could also generate links to conda-metadata-app from that table so folks can explore the metadata in a detailed way.
In the future, we could also use a client-side implementation to query the backend directly. xref https://github.com/Quansight-Labs/czi-conda-forge-mgmt/issues/51

Added in https://github.com/conda-forge/conda-forge.github.io/pull/2086


onPress button function didn't get triggered with tap() function

 component is an alias for react-native Button (import {Button as RButton} from 'react-native')
react-native : 0.62.2
detox :18.12.0
react": 16.11.0,

How did u deal with it? I have the same problem with it


Add a Setter for X509_REQ_get0_signature.

This should resolve #10560

[x] documentation is added or updated
[ ] tests are added or updated

No worries !

Note to committers: this pull request cherry-picks cleanly, except for the usual conflict in libcrypto.num, which can be trivially resolved:
diff --git a/util/libcrypto.num b/util/libcrypto.num
index 1dde397bed..4d11ad9f46 100644
--- a/util/libcrypto.num
+++ b/util/libcrypto.num
@@ -4586,3 +4586,4 @@ EVP_PKEY_meth_set_digestsign            4539      1_1_1e  EXIST::FUNCTION:
 EVP_PKEY_meth_set_digestverify          4540   1_1_1e  EXIST::FUNCTION:
 EVP_PKEY_meth_get_digestverify          4541   1_1_1e  EXIST::FUNCTION:
 EVP_PKEY_meth_get_digestsign            4542   1_1_1e  EXIST::FUNCTION:
+X509_REQ_set0_signature                 4543   1_1_1e  EXIST::FUNCTION:

No - is totally fine as is.
If you want a justification; then this setter is used/was needed in https://redwax.eu / the RedWax project -- a set of apache modules that make up a miniature CA, scep-agent, etc.
And it is specifically to not need this code https://source.redwax.eu/projects/RS/repos/mod_csr/commits/de009d533c0b2927be9efcb6456a1e4cb23b84d8#openssl_setter_compat.h any longer.

Thanks for the background information. However, no extra justification is needed. Missing accessors for structures which were made opaque in 1.1.0 are considered a bug and qualify for backporting to 1.1.1.

BTW: git diff master... shows a lot of trailing whitespace.

Another thing came to my mind: currently there are three similar getters
https://github.com/openssl/openssl/blob/73ce68d4e1b525c3ce3f5769ab955e860632540b/include/openssl/x509.h#L576
https://github.com/openssl/openssl/blob/73ce68d4e1b525c3ce3f5769ab955e860632540b/include/openssl/x509.h#L692
https://github.com/openssl/openssl/blob/73ce68d4e1b525c3ce3f5769ab955e860632540b/include/openssl/x509.h#L746
and you are adding the setter counterpart for one of those three.
https://github.com/openssl/openssl/blob/73ce68d4e1b525c3ce3f5769ab955e860632540b/include/openssl/x509.h#L694
Wouldn't it make sense to add setters for the others, too?

@mattcaswell - so tried to make those changes - including a copy. This passes various tests; including valgrind on our sample code. But am not entirely sure that this is what you meant.

Is there a way to restart a CI test that failed on timeout ?

Is there a way to restart a CI test that failed on timeout ?

I just restarted the single travis job which was failing.

That job seems to run in slooow mootion. It took 700 seconds just to execute the ar commands and it is still working on the tests...
$ if ! $make2; then echo -e '\052\052 FAILED -- MAKE'; travis_terminate 1; fi;
ar: creating apps/libapps.a
ar: creating libcrypto.a
ar: creating libssl.a
ar: creating providers/libcommon.a
ar: creating providers/libfips.a
ar: creating providers/libimplementations.a
ar: creating providers/liblegacy.a
ar: creating providers/libnonfips.a
ar: creating test/libtestutil.a
...

Is there a way to restart a CI test that failed on timeout ?

I just restarted the single travis job which was failing.

Ah, correction: The sevenhundred seconds are probably for the entire build. I forgot that most of the commands are not echoed anymore but written to a file which is only shown on error.

Too slow again...
80-test_dtlsv1listen.t ............. ok
80-test_ocsp.t ..................... ok
80-test_pkcs12.t ................... ok
The job exceeded the maximum time limit for jobs, and has been terminated.

@mattcaswell Anything left for me to do here ? Any way I can re-trigger the CI build and hope that it does not time out this time without doing a fluff commit?

As there are merge commits could you please just apply your changes in a single commit to fresh check-out and force-push?

@t8m - got them all merged into one single commit at the head of master in a branch (https://github.com/dirkx/openssl/tree/setter-getter-x509-req-algo) & regression tested -- but am struggling to rebase this pull request -- I keep getting problems with conflicts in libcrypto.num.
Or is it wiser to close this PR and file above (https://github.com/dirkx/openssl/tree/setter-getter-x509-req-algo) as a new PR ?

... am struggling to rebase this pull request -- I keep getting problems with conflicts in libcrypto.num.

Instead of rebasing your branch, you can just reset it to the the tip of the new one (i.e. setter-getter-x509-req-algo) and force-push the result.
Here's the magic spell how to do it. (Don't forget to check first that you have no uncommitted changes!):
git checkout master
git reset --hard setter-getter-x509-req-algo
git push origin master --force

(assuming that 'origin' points to your public GitHub fork of openssl)

Or is it wiser to close this PR ... ?

It's a possibility, but it is not wiser ;-)

For the future, I recommand to always create a separate topic branch for a pull request, instead of (mis-)using the master branch for it. That helps keeping things simpler.

@mspncp agreed - my bad -- this started as small tiny temporary side tweak that turned out to be much more needed than expected.

@t8m, @mattcaswell I take it I should file a totally separate pull request for  1.1.1  ?

@dirkx your pull request has no conflicts with 1.1.1 except for the usual ones in libcrypto.num. Those conflicts can be trivially resolved by discarding the conflicting file, rerunning make update (and discarding unrelated date changes in other files.) IMHO one of the committer could do this when merging your pull request. Do you agree @t8m, @mattcaswell?
git cherry-pick ...
... conflict ...
git checkout --ours -- util/libcrypto.num
make update
git add -- util/libcrypto.num
git checkout crypto  # workaround: discard  unrelated date changes by make update
git rebase --continue

I have no problem with this unless this semi-automated conflict resolution in libcrypto.num somehow goes against the review/commit rules.

Anything I can do here ? Happy to re-submit the PR without libcrypto.num so it won't conflict with either branch - or split it into two PR's; one for each ?

@belmit : Anything I can do here ? Happy to re-submit the PR without libcrypto.num so it won't conflict with either branch - or split it into two PR's; one for each ?

The best strategy for conflicts in libcrypto.num is normally to just discard the incoming changes and rerun make update:
git rebase master
# <git stops on conflict>
git checkout --ours util/libcrypto.num
make update
git add -u
git rebase --continue

git checkout --ours util/libcrypto.num

(just in case you wonder: '--ours' == master, '--theirs' == the incoming changes from your branch being rebased)

Automated Ping: This issue is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This issue is in a state where it requires action by @openssl/committers but the last update was 61 days ago

@beldmit ping, can you please re-approve? I can resolve the libcrypto.num conflict when merging as that is a trivial conflict.

This pull request is ready to merge

Merged to master as c72e593

Merged to 1.1.1 as 4738d9e


This freaks me a lot: why does upstream repository received a notification of my commits in my forked repository?

As the title said: I pushed some commits into forked repository, but I did not pull request!!! How does upstream repository received a notification of my commits in my forked repository? It was terrible, I just want to keep up-to-date with upstream repository meanwhile keep some of my configs!!!

Could you attach links or screenshots of what you mean?

Could you attach links or screenshots of what notification upstream received?

But when I log github account off, this notification seems disappeared, so possibly it should be seen only by me?

Yes it's only for you. This is a github feature.

Oh my glob, thanks, this really freaks me out just now😶


Add comment to understand

I added a comment to describe the reason of preferredFont(forTextStyle: .body).
Cloud you review and correct my english sentences? 🙇♂

Thank you for the PR! Your English isn't bad, don't worry - slightly off, but I'll fix it.


Prevent tool configuration if there's no selected interpreter

Continuing on the work of #7750 , we should not let the user select a linter, discover tests or configure their test framework if there's no selected interpreter:

Suggestion from @karthiknadig : display the "no interpreter selected" prompt instead.

Done via https://github.com/microsoft/vscode-python/pull/19481


Hello

Challenge Say Hello to HTML Elements has an issue.
User Agent is: Mozilla/5.0 (iPhone; CPU iPhone OS 9_3_2 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/51.0.2704.104 Mobile/13F69 Safari/601.1.46.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Hello

What is the issue? You have given no description of what is wrong

if your looking to complete the assignment, you need to change the text to "Hello World".
At the bottom of the page, after clicking the "Run Tests" button, there is a description listing things you may want to look over if it doesn't pass and advance to the next lesson.

@vbXhaiden this what I see at the bottom, are you getting something else?
Mind sharing a screenshot.

@raisedadead What exactly are you having a problem with? Are you not able to advance to the next lesson?

umm everyone, nothing with with that challenge.   that code is incorrect.

Closing as not a issue with the website.
Happy coding.


Added Jedis(HostAndPort) and similar constructors

This helps to replace all the usages of 'new Jedis(HostAndPort.getHost(), HostAndPort.getPort())' and similar object creations in shorter and safer manner.

LGTM. @marcosnils Please review.

Merged into master, 2.10.


Update enabling-stream-support-b236d32.md

The current link to the CAP Documentation is broken. I have a updated with a proposed alternative

Hi @katansapdevelop, thanks for your contribution! We'll look into it and get back to you.

Hello @katansapdevelop,
Thank you for bringing this to our notice. Please know that we have now replaced the non-working link with the correct one. However, the reflection of the change may take some time. The documentation will be updated post our current release.
If in case you have any further concerns, please do let us know. If your concern is resolved, kindly go ahead and close this request or let us know if we can do so.
Thanks and regards,
Mishu Agrawal

Hello @katansapdevelop,
We have now updated the link and you can check it here: https://ui5.sap.com/1.127.0/#/topic/b236d32d48b74304887b3dd5163548c1
Kindly confirm if your concern is resolved and if we can go ahead and close this request.
Thanks and regards,
Mishu Agrawal

Hi @mishuagrawal , I've just had a look and link is now working perfectly.

Thanks for fixing it up

Hello @katansapdevelop,
Thank you for the confirmation. I am going to go ahead and close this request now. Please feel free to reach out to us if you have any further concerns in the future.
Thanks and regards,
Mishu Agrawal


Connection-monitor test-configuration cmdlet: need to add new parameter

Is your feature request related to a problem? Please describe.
We added a new parameter into TCPConfiguration interface. Need to do the same in cli cmdlet.
Here is swagger update
"ConnectionMonitorTcpConfiguration": {
  "properties": {
    "port": {
      "type": "integer",
      "description": "The port to connect to."
    },
    "disableTraceRoute": {
      "type": "boolean",
      "description": "Value indicating whether path evaluation with trace route should be disabled."
    },
    "destinationPortBehavior": {  **// Need to add**
      "type": "string",
      "description": "Destination port behavior.",
      "enum": [
        "None",
        "ListenIfAvailable"
      ],
      "x-ms-enum": {
        "name": "DestinationPortBehavior",
        "modelAsString": true
      }
    }
  },
  "description": "Describes the TCP configuration."
},

Updated swagger: https://github.com/Azure/azure-rest-api-specs/blob/network-june-release/specification/network/resource-manager/Microsoft.Network/stable/2020-06-01/networkWatcher.json
Describe the solution you'd like
The suggestion is to add new parameter to existing cmdlet:
az network watcher connection-monitor test-configuration add --connection-monitor
--location
--name
--protocol {Http, Icmp, Tcp}
--test-groups
[--frequency]
[--http-method {Get, Post}]
[--http-path]
[--http-port]
[--http-prefer-https {false, true}]
[--http-request-header]
[--http-valid-status-codes]
[--icmp-disable-trace-route {false, true}]
[--preferred-ip-version {IPv4, IPv6}]
[--subscription]
[--tcp-disable-trace-route {false, true}]
[--tcp-port]
[--threshold-failed-percent]
[--threshold-round-trip-time]
Name of parameter would be: -- destination-port-behavior

add to S174

@irrogozh I prefer to use --tcp-port-behavior, removing the term destination as I don't see any pair of source and destination in the concept of TestConfiguration. What do you think?


Adding Drop Index

Thanks for sending this in. @poojanilangekar will coordinate with @ChTimTsubasa to make sure that this works with our new plan cache.

Changes Unknown when pulling efc3bcf8043ca09942e8f804ed64413e8bc7e110 on pholanda:master into ** on cmu-db:master**.

Coverage decreased (-75.7%) to 0.0% when pulling efc3bcf8043ca09942e8f804ed64413e8bc7e110 on pholanda:master into 130a0bdf2e0204a3581deb33e72af73c1064bcb6 on cmu-db:master.


3.2.9 - System.out.println in SimpleFunctionRegistry

Describe the bug
Updated from 2021.0.5 to 2021.0.6 and found that SimpleFunctionRegistry had started sysouting something along the lines of "Invoking function: ...".

Yes there are two debug statements:
if (logger.isDebugEnabled()) {
logger.debug("Invoking function: " + this + "with input type: " + this.getInputType());
}
. . .

if (logger.isDebugEnabled() && !(input  instanceof Publisher)) {
logger.debug("Invoking function " + this);
}

So, adjust your logger configurations

Hi @olegz,
The problem seems to be on v3.2.9:
https://github.com/spring-cloud/spring-cloud-function/blob/v3.2.9/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistry.java#L930

Thanks @olegz & @carolmorneau!
I typed the issue up on my iPad so sorry it is so scant on details, but this is good in the main branch, and maybe just needs to be backported.

I could not successfully build the 3.2.x branch with ./mvnw clean install -DskipTests and received this error after forking and first trying to build:

[ERROR] Failed to execute goal on project function-sample-kotlin-web: Could not resolve dependencies for project io.spring.sample:function-sample-kotlin-web:jar:1.0: The following artifacts could not be resolved: org.springframework.cloud:spring-cloud-function-kotlin:jar:3.2.9-SNAPSHOT, org.springframework.cloud:spring-cloud-function-web:jar:3.2.9-SNAPSHOT, org.springframework.cloud:spring-cloud-function-context:jar:3.2.9-SNAPSHOT: Could not find artifact org.springframework.cloud:spring-cloud-function-kotlin:jar:3.2.9-SNAPSHOT -> [Help 1]

That said, its such a small change I figured if I was missing something you would know what to do @olegz.


Capture Still Photo from AVCaptureSession

When will it be possible to capture a still photo from a AVCaptureSession?

Just want to build a simple camera app to capture filtered images and preview the filter in realtime


Invalid user name and password error for special character in user name

when I want to connect to DB  because in my user name I have special characters
my user name is like arash[proxy] because having [ & ] I can not connect to DB
panic: ORA-01017: invalid username/password; logon denied

i got the same issue

duplicate see solution in #139


feat(eslint-config-angular): support eqeqeq

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

https://eslint.org/docs/rules/eqeqeq

@SuperOleg39 hello, could you see please?)


When getting to end of document, Reader should ask (unobstrusively) if you want to tag the document as read

[ ] Implement an operations tables for storing operations to be done on 100%
[ ] Implement the reading of said table and execution of operations when read gets to 100%
[ ] Implement interface for adding/removing operations


Upgrade to TS 4.8

Fixes https://github.com/clauderic/dnd-kit/issues/877

Upgrade from TS 4.6 to TS 4.8 (I could have upgraded to TS 4.9 but the rest of the ecosystem like typescript-eslint isn't ready yet for it, and also the major breaking change is from the 4.7 to the 4.8, so we should have just 1 release for the 4.8 update to smooth the upgrade)
Fix 2 type issues:

one regarding the generic in SensorDescription (it now extends Object)
another one regarding the previously untyped dependencies array in useLatestValue

Test
Those are only type changes, so it cannot break the runtime of the libraries.
Also I ran yarn tsc -p . --noEmit, before and after the updates, and

before I had 9 errors were reported in 6 files,
after the update (without the 2 fixes), I had 11 errors,
and after the update and the fixes, I'm back again at 9 errors
(as those are already here on master, I didn't fix them in this PR)

Release
As this is just a minor patch, this could either be a patch release.

cc @clauderic

🙇♂


[SP-5020] Backport of PPP-4294 - Use of Vulnerable Component: derby-1…

…<IP_ADDRESS>_1.jar (CVE-2015-1832) (7.1 Suite)
@RPAraujo

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


Link to demo in README.md

Work for this issue will begin begin on branch work-liquid-labs/react-window-context/22.


app.nit UI: Intro an attribute to toggle password entry on TextFields

The attribute TextField::is_password toggles hiding the content of the field using platform specific services. So on Android, not only is the text hidden but it also notifies the soft keyboard to behave accordingly.
In the future, we could add alternative modes for email entry and more.

+1


stages: gke-multitenant complains with IP_SPACE_EXHAUSTED error

Deploying the 3-gke-multitenant stage with this configuration:
clusters = {
  cluster-0 = {
    location = "us-east1"
    vpc_config = {
      subnetwork = "https://www.googleapis.com/compute/v1/projects/XXX-dev-net-spoke-0/regions/us-east1/subnetworks/dev-default-ue1"
    }
  }
}

nodepools = {
  cluster-0 = {
    nodepool-0 = {
      max_pods_per_node = 10
      node_config = {
        disk_type    = "pd-ssd"
        machine_type = "c2-standard-16"
        spot         = true
      }
    }
  }
}

fleet_features = null

fleet_workload_identity = false

This is using the default values already available in the 2-networking-d-separate-envs stage:
region: us-east1
ip_cidr_range: <IP_ADDRESS>/24
description: Default subnet for dev
secondary_ip_ranges:
   pods: <IP_ADDRESS>/24
   services: <IP_ADDRESS>/24

Hi @juliocc ,
By that time the subnet was empty as I had to recreate it to add the pods and services secondary IP ranges.
I managed to workarounf this by adding a max_pods_per_node = 50 and making the secondary subnet bigger. Based on the official documentation, and the defaults for 3-gke-multitentant the actual defaults on the networking just allows a single node, but nodes 3 nodes (HA) gets deployed by default.

@gustavovalverde I understand you fixed the issue. Can we close this?
Perhaps we should make the default subnet have a larger pod range. A /20 perhaps?

Closing this, feel free to reopen if you still think we should fix something.

Not a single example from this README can be deployed with the actual networking CIDR from https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/fast/stages/2-networking-d-separate-envs/data/subnets/dev/dev-dataplatform-ew1.yaml
I've fixed this on my side, but this will always impact newcomers even testing the stages with most defaults, as the multitenant-fleet examples deploy at least 3 nodes, which will always exhaust the IP address range.
I'd say that at least a /16 would be needed here for most example to work without further changes.

@juliocc  ran into this error while running stage 2-networking-a-peering on a test setup for a fresh org:
╷
│ Error: Error creating Subnetwork: googleapi: Error 400: Invalid value for field 'resource.secondaryIpRanges[1].ipCidrRange': '<IP_ADDRESS>/24'. Secondary range overlaps with another range in this subnetwork: <IP_ADDRESS>/16., invalid
│
│   with module.dev-spoke-vpc.google_compute_subnetwork.subnetwork["europe-west1/dev-dataplatform-ew1"],
│   on ../../../modules/net-vpc/subnets.tf line 132, in resource "google_compute_subnetwork" "subnetwork":
│  132: resource "google_compute_subnetwork" "subnetwork" {
│
╵

@juliocc ran into this error while running stage 2-networking-a-peering on a test setup for a fresh org:
╷
│ Error: Error creating Subnetwork: googleapi: Error 400: Invalid value for field 'resource.secondaryIpRanges[1].ipCidrRange': '<IP_ADDRESS>/24'. Secondary range overlaps with another range in this subnetwork: <IP_ADDRESS>/16., invalid
│
│   with module.dev-spoke-vpc.google_compute_subnetwork.subnetwork["europe-west1/dev-dataplatform-ew1"],
│   on ../../../modules/net-vpc/subnets.tf line 132, in resource "google_compute_subnetwork" "subnetwork":
│  132: resource "google_compute_subnetwork" "subnetwork" {
│
╵

This is what happens when you submit code without trying it ;)
Let me see what's going on and I'll get back to you.

@danielmahon we're addressing this with #1697. I'm waiting to hear from a couple of reviewers but in the meantime you can fetch the branch and give it a try.


add interaction types and update normalizer

Currently many entries in DGIdb are of type 'n/a' (e.g. #112), and many of value interaction type (see #136).
These interaction types need to be fixed in their respective issues, and then we should update Interactions to have types and update the normalizer to create/update those types after normalizing the interaction_claims.

I think this can be closed.


Not working on New York Times

 Issue by JohnChu101
Thu Aug 22 03:34:16 2019
Originally opened as https://github.com/codelucas/newspaper/issues/729

As mentioned in many issues: #645 #363 , newspaper doesn't work on New York times.
And I tested two versions of New York times, one is the English version, the second is the Chinese version (https://cn.nytimes.com).
The Chinese version doesn't have payment wall, so newspaper should be able to extract the full content of it. However in both cases, newspaper only extract like 3 or 4 paragraphs and they are not from the beginning.
Is there any way i can solve this?
Thanks.
My code:
from newspaper import Article, Config as NewspaperConfig
url="https://www.nytimes.com/2019/08/21/business/economy/jobs-growth-revision.html"
conf = NewspaperConfig()
article = Article(url, config=conf, keep_article_html=True)
article.download()
article.parse()
print(article.article_html)
print(article.text)

The urls i tested with:
https://www.nytimes.com/2019/08/21/business/economy/jobs-growth-revision.html
https://cn.nytimes.com/china/20190821/china-hong-kong-social-media-soft-power/
https://cn.nytimes.com/morning-brief/20190822/hong-kong-protests-british-consulate-us-sanctions-fentanyl/

The Chinese article does not work because is_highlink_density does not use the proper tokenizer to split non-european languages.
Therefore many divs appear as high link density
Must re-think the multi-language handling

fixed in 0.9.3


Support for synthetics tests

Describe the bug
Have a new CloudFormation resource for synthetic tests
Resource Name and version
It's a new resource.
Expected behavior
See here: https://docs.datadoghq.com/api/?lang=python#create-a-test

At this moment, we only support Users, Monitors, Downtime and AWS Integrations endpoints. More is in the pipeline, including Synthetics tests and more.

Closing this since we are not keeping feature requests as open issues anymore. See our contributing.md doc.
However more endpoints support is in progress. Unfortunately, I cannot provide an ETA.


Error: getUsedCollateral not implemented..

Using AppWallet to send transaction to unlock assets as in this example.
Then get this error:
Error: [Transaction] An error occurred during build: Error: getUsedCollateral not implemented..
    at Object.build (/root/meshapp/node_modules/@martifylabs/mesh/dist/mesh.cjs:1:51612)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Same as this topic in stackexchange.  Just put it here for reference.

I also encountered this problem, which made my project unable to continue.

I have to switch to Lucid. Not as user friendly as mesh but at least things can move forward.

I have to switch to Lucid. Not as user friendly as mesh but at least things can move forward.

I also tried to use Lucid, but I couldn't find a way to connect to the server wallet, can you tell me how to do it.

I also tried to use Lucid, but I couldn't find a way to connect to the server wallet, can you tell me how to do it.

You mean browser wallet? Like Nami? Checkout this example: https://github.com/spacebudz/lucid/blob/da661d0635bb31e700370391de62d28987eae06a/src/examples/mint_simple_NFT.ts#L21

@nft6666 @adam-young-dev
"Collateral" is something the light wallets (i.e. eternl, nami...) has as part of the wallet features. Thus using browser wallet component, you can get the collateral UTXOs "magically", and it will prompt error when its not set.
For App wallet, obviously it is very different purpose. You can literally build your own light wallet if you wish to.
For transactions with app wallet, the solution is as simple as tx.setCollateral(utxo), where you pick the UTXO you want to use as the collateral.

@jinglescode
Now I get a different error. Something about "...PPViewHashesDontMatch...".
Can you provide a detail example of a working implementation of app wallet interacting with a smart contract?

Make sure you update to the latest version, as valentine's day patch changed the network's cost model.


Update CONTORIBUTING.md

Description

ref https://github.com/nostalgic-css/NES.css/pull/363#issuecomment-540303671
I moved message about storybook from README.md to CONTRIBUTING.md.
Compatibility

none
Caveats

none

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The exported prerender property is not copied to files generated by sync

My /pages/index.astro
---
import { astroI18n } from "astro-i18n";
astroI18n.init(Astro);

export const prerender = true;
---
...

Generated file (/pages/ua/index.astro):
---
import Page from "../index.astro"

const { props } = Astro
// would be nice to have `export const prerender = true;`
---

<Page {...props} />

Of course, I can just edit them manually, but it would be great to automatically detect exported properties or to be able to enable copying them.

Thanks for reporting, I totally forgot about this, I'll add it asap.

fixed in v1.6.10


Fix bug with identifier_factory

Strings with multiple spaces in a row were not getting handled properly.

Pull Request Test Coverage Report for Build 116309346

0 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage increased (+4.2%) to 34.673%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 116261413:
4.2%

Covered Lines:
621

Relevant Lines:
1791

💛  - Coveralls


Add Overlay and Navigation tests for the Interaction design

Based on PR #1715
Full chain of PRs as of 2024-10-10

PR #1711:
wb/froeht/add-overlay-tests ➔ yiqunw/overlay_dismiss
PR #1715:
yiqunw/overlay_dismiss ➔ main

I am wondering how you made the "PR Chain"? Does github show that based on the description "Based on PR https://github.com/google/automotive-design-compose/pull/1715"?

I've been using something called "git machete", it's got a bit of a
learning curve, but it does have a plugin for Android Studio and it's been
mostly helpful :)
On Thu, Oct 10, 2024 at 1:29 PM yiqunw700 @.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/google/automotive-design-compose/pull/1711#pullrequestreview-2361115094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMM2SUKILCP7LLRDXR4O2LZ23BQ3AVCNFSM6AAAAABPMPZTWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGEYTKMBZGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Tim Froehlich
AAOS Customization Tools https://moma.corp.google.com/team/1556788105958
Located in Austin TX, GMT-5


ci: dependabot single cargo PR

#688  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Golang SDK support for Agent Locks

Is your feature request related to a problem? Please describe.
We're working on a feature at Square that requires Agent Locks within our Polyglot Golang hooks, but we currently don't have an API for locks yet.
Describe the solution you'd like
It would be amazing if we could get a Golang API for the agent locks in one of the buildkite go SDKs. This would be much more ergonomic than calling os/exec to run the lock commands. The os calls are workable but very crusty. It'd be much better to have an API baked into the SDK for opening and closing agent locks.

Hi @jmandel1027, do you mean something like https://pkg.go.dev/github.com/buildkite/agent/v3/lock ?

@DrJosh9000  Ahh finally got around to taking a closer look at this link. That is exactly what I was looking for, thanks! 🚀