portico: Scope styles, implement gradient fixes.

This PR:

Isolates global /plans styles to their own file.
Scopes pricing_plans.css to only those landing pages that need it.
Implements background and gradient fixes originally in #28491, whose changes were reverted in 40f99d0990c758b423f144f9dd651e6be5127135

Screenshots and screen captures:
/why-zulip/ (background is white, as expected):

/for/business/ (background is white, plans tabs rendered as expected):

/plans/ (background properly extends below footer):

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Looks good to me!
It's not a regression in this PR, but I do notice that most pages have a white background that peeks out if you scroll past the bottom of the footer, which is not ideal.

@alya Yeah, it's not a regression, but if you think it's priority enough, I can look at a possible fix for it. I have a rough one in mind, but there may be some sharp edges to it.

Actually I think the fix wouldn't be too hard to pull off, but there would be need of careful auditing of all the legacy portico pages to make sure something non-obvious isn't dependent on a weird height: 100% set on the body selector, which effectively sizes the body (and its background color) to the height of the viewport when the page loads. That's important because the white overscroll color at bottom needs to be set on the html selector, and by allowing body to do its usual thing of sizing as auto, there'll be the expected white background color behind all the other page content.

Merged, thanks @karlstolley!


Janestreet 0.9

This subsumes #25534 whose approach did not scale.
This creates a new set of OCaml packages, all from Jane Street, all at the same version (0.9.0).
All the packages are declared in the same file, using a shared builder.
I welcome any kind of comments. In particular, how to call this set: is ocamlPackages.janeStreet fine?
TODO

[x] Add missing external dependency octavius.
[x] Add missing packages (currently commented) all the way up to core_kernel
[x] Add missing descriptions.
[x] Remove duplicated derivations.
[x] Add new packages directly to ocamlPackages.
[x] Rename newBuildOcamlJane into e.g. janePackage
[x] Check OCaml version >= 4.03

Just added octavius (see 0a4da64cadc1d2b4166ed50559acf07e51e6d425).
Can you find a sane name for newBuildOcamlJane? In particular, “build” in nixpkgs usually refers to “actually building the package (e.g. compiling it)” (dixit the manual).

Thanks for octavius!
What about just janeDerivation or janePackage? BTW, should I replace the word "package" with "derivation" in the commit messages? and "package set" with "attribute set"?

From my point of view, this PR is mostly ready. I can use the packages defined in it for my own purpose, which was to build coq-serapi.
I still have two items on my checklist before merging:

The first one is to check the OCaml version for the janeStreet set of packages. I don't know what is the recommended way to do that.
The second is that ideally, we would want all packages which are new in this PR to be automatically added as ocamlPackages.newPackage in addition to ocamlPackages.janeStreet.newPackage. I suppose there are tricks to do that but I'm not sure which exactly.

Does this otherwise look good to you @vbgl @maurer?

For me this PR is now ready to merge. The last two commits correspond to the last two items I was talking about in my previous comment. Do they look like acceptable solutions?
If asked, I can do some squashing (e.g. between d95951c and 4f0d1ff, or between 802277a and 2a0ca7a).

Once this is merged we can also package https://github.com/janestreet/patdiff; I’m in no position to review this though. @sternenseemann?

@Profpatsch I've just added to this PR a few packages which patdiff depends on. Not core_extended though because it seems that there is some script patching to do.

@Zimmi48 is it normal that some derivations still seem to have the 133.33 part in their name?

@Ptival This PR does not update existing derivations, but rather introduce new ones at version 0.9 under the prefix ocamlPackages.janeStreet. So if you start by with ocamlPackages_latest; with janeStreet; you should get version 0.9 in priority, but if you just start by with ocamlPackages_latest; you will get version 133.33 in priority.

@Profpatsch This now includes core_extended which means that you have almost all the dependencies of patdiff (to the exception of pcre which is not a Jane Street package). The problem with core_extended was that a shebang needed patching. I had no idea that even /usr/bin/env becomes unavailable during the build of a derivation.
@maurer It now seems that ocamlPackages.janeStreet is a super-set of the previously available Jane Street packages. So should we remove the previously available versions (for OCaml 4.03)?

It now seems that ocamlPackages.janeStreet is a super-set of the previously available Jane Street packages. So should we remove the previously available versions (for OCaml 4.03)?

The clean-up could actually go much further following what was proposed in #18819. Like making 4.04 the default and keeping just one older version and only the older packages which are needed as dependencies to some other applications. But this is not the place of this PR to do that. So IMO it is fully ready to merge as-is.

@maurer It now seems that ocamlPackages.janeStreet is a super-set of the previously available Jane Street packages. So should we remove the previously available versions (for OCaml 4.03)?

seems sensible, but this might break things outside of nixpkgs and requires fixing in nixpkgs (which should be manageable)

@Profpatsch Actually pcre was already in nixpkgs, I had missed it because it is called ocaml_pcre. So I've just added patdiff as well, since this was the last missing dependency.

@sternenseemann

seems sensible, but this might break things outside of nixpkgs and requires fixing in nixpkgs (which should be manageable)

I have added a commit to this PR that does this (upgrading the default versions of Jane Street packages for Ocaml 4.03). nox-review tells me that it doesn't break anything in nixpkgs but this could break things outside of nixpkgs of course. I have no strong opinion on this upgrade commit so if someone opposes it, I will remove it not to delay the merge of this PR.

re2 does not build on darwin:
/nix/store/d0vj5xfr85716dz2k8xb6fhygxgllk3b-bash-4.4-p12/bin/bash: g++: command not found
make[1]: *** [Makefile:161: obj/util/arena.o] Error 127

@vbgl Interesting! I did not explicitly require the dependency on gcc because it was already available in the $PATH by default but I suppose that this is dependent on the architecture. Does this new commit fix the problem? If yes, I'll rebase quickly.

So I'm almost sure that the fixed I have pushed should solve the problem on Darwin so I've rebased to integrate it in the right commit.
I've also added a commit making patdiff a top-level package. IMO it makes sense since it is a command-line tool that can be useful to anyone, not just OCaml developers.
This has the additional advantage that it has re2 as a dependency so now Travis should build it and confirm us that it works on all platforms.

Your fix for darwin does not change anything.
The issue with re2 might be an upstream bug: they explicitly require g++ when they should use the environment variable CXX (https://github.com/janestreet/re2/blob/master/src/re2_c/jbuild#L25).
About your last remark about patdiff: does this package provides a library or only some binaries? If it’s not a library, it may not belong to ocamlPackages.

Indeed, I think patdiff is only an application, not a library. Does @Profpatsch confirm? I'll move it elsewhere. What location do you suggest? tools/misc?
@vgbl Excuse my lack of knowledge but can you explain the general issue with g++, nixpkgs and Darwin. I just had a look at the manual and it indicates that g++ is made available as part of stdenv and it makes no mention of Darwin. I'm guessing that the issue is that g++ is actually platform specific. Does nixpkgs provide clang instead on Darwin as part of stdenv? In that case, I might try to patch the software depending on the platform. Or you can do it @vgbl since you are better positioned to test the fix (write access to this branch is granted to maintainers of nixpkgs).

@vbgl That my fix for Darwin was not working was not a mystery because I had forgotten to actually include gcc in the buildInputs! Now testing this solution again. If it doesn't work I'll try instead to patch the file you mentioned to explicitly use stdenv.cc.
I'm still really surprised that https://nixos.org/nixpkgs/manual/#sec-tools-of-stdenv makes no mention that GNU gcc can alternatively be clang.
I have now moved patdiff in tools/misc. @Profpatsch let me know if you think the location is OK.

Travis' verdict: this still fails on Darwin. The error changed though. One can see something like this:
ARFLAGS=rsc

CXX=g++

CXXFLAGS="-Wall -O3 -g -pthread"

if ! true; then

  CXX="$CXX -m32"

fi

/nix/store/x3raqnfvxl19nam0gjr8qcw0f0f26l7x-gnumake-4.2.1/bin/make -s -C libre2 clean

/nix/store/x3raqnfvxl19nam0gjr8qcw0f0f26l7x-gnumake-4.2.1/bin/make -s -C libre2 ARFLAGS="$ARFLAGS" CXX="$CXX" CXXFLAGS="$CXXFLAGS" obj/libre2.a obj/so/libre2.so

cp libre2/obj/libre2.a libre2_c_stubs.a

cp libre2/obj/so/libre2.so dllre2_c_stubs.so

/nix/store/x3raqnfvxl19nam0gjr8qcw0f0f26l7x-gnumake-4.2.1/bin/make -s -C libre2 clean

')

clang-4.0: warning: argument unused during compilation: '-idirafter /nix/store/xxbrmw7y5xl4cigq9p22b5jnji32ivnl-Libsystem-osx-10.11.6/include' [-Wunused-command-line-argument]

clang-4.0: warning: argument unused during compilation: '-idirafter /nix/store/m9rsrcndr9dfhi3rxc95kamdjc90dkkh-gcc-5.4.0/lib/gcc/x86_64-apple-darwin16.3.0/5.4.0/include-fixed' [-Wunused-command-line-argument]

and then pages later:
g++: error: unrecognized command line option '-stdlib=libc++'

make[1]: *** [Makefile:181: obj/so/libre2.so] Error 1

make: *** [Makefile:5: default] Error 1

This seems to indicate that even with the gcc dependency, the backend is still clang somehow.
I'll try patching re2 instead but I wonder if the problem is not that they use a g++ specific option.

Last try (patching this file to have it use $CXX instead of gcc). If this still doesn't work, I'll just add platform information to make re2, core_extended and patdiff Linux-specific.

OK here's what I get (on Travis, on Darwin):
clang-4.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
cc src/stubs.o (exit 1)

(cd _build/default/src && /nix/store/ryxnhgxyvz4j4z6vmdrv20kj0kyi9gkh-clang-wrapper-4.0.0/bin/cc -I /nix/store/2l4jlirard4ky8wydixlgfhp5hb8j4lx-ocaml-4.03.0/lib/ocaml -O2 -fno-strict-aliasing -fwrapv -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -I /nix/store/v40yq1wig900ppf9kx31b2z15s9bxigj-ocaml4.03.0-core_kernel-0.9.0/lib/ocaml/4.03.0/site-lib/core_kernel -I /nix/store/wh5kh4wjmd4a1drrkvhxlc6rlgfb5z20-ocaml4.03.0-base-0.9.1/lib/ocaml/4.03.0/site-lib/base -I /nix/store/wr6yk1hk02zg4hq9f6ndgdz740wwwjpn-ocaml4.03.0-jane-street-headers-0.9.0/lib/ocaml/4.03.0/site-lib/jane-street-headers -g -I re2_c/libre2 -o stubs.o -c stubs.cpp)

stubs.cpp:1:10: fatal error: 'vector' file not found

#include <vector>

         ^~~~~~~~

1 error generated.

builder for â€˜/nix/store/jjrc1rkc9dm93jaw2cw5y745qk0x7y16-ocaml4.03.0-re2-0.9.0.drvâ€™ failed with exit code 2

Any idea how to fix this? Otherwise I'll just change the platform like I said earlier.

Adding gcc to re2’s buildInputs make the build go through. But this looks like a bad idea.
Moreover, it results in crazy linking errors in patdiff build.
I think it’s worth telling upstream about this issue.
About patdiff again: does the build inputs need to be propagated?

Adding gcc to re2’s buildInputs make the build go through. But this looks like a bad idea.
Moreover, it results in crazy linking errors in patdiff build.

I am making re2 platform specific for now because I don't want to delay this PR forever but it would be interesting to find a better solution for this. In particular, given that nixpkgs already packages Google's re2 (the C library), could it be used instead of the C sources shipped in the OCaml package? (Although for now, it is a bit outdated compared to the version Jane Street's re2 is based upon.)

I think it’s worth telling upstream about this issue.

Yes, although I'd be interested to have you or another OSX person do it, since the only way I could test things was through Travis (not the most practical).

About patdiff again: does the build inputs need to be propagated?

Indeed, they don't, I was just following the general model without really thinking. I've updated this.

@vbgl @sternenseemann Can someone merge this? Travis passed. I don't think there is any reason to delay any longer.

Done.

I've been working to get a project that depends on core_kernel 0.10.0, and ended up bumping many packages up to 0.10.0. Considering the sheer number of packages that need bumping moving forward, is there any consensus on how to organize the janeStreet set? Is mechanically updating all packages up to 0.10.0 viable compatibility-wise? In that case, I've already done half the job, so I believe it'll be relatively easy.

Updating all this package set to 0.10.0 at once seems a good idea. Would you like to give it a try?

I'll take a shot at it :smile:

I've managed to get ocaml-ng.ocamlPackages_4_06.janeStreet built (excluding a few exceptions), but the problem now is that ocamlPackages (OCaml 4.04) fails to build across the board. I believe bumping ocamlPackages to 4.06 is one solution, but entails much more work than anticipated and probably breaks a multitude of packages. How do you think we should proceed?
@Zimmi48 @vbgl

Here's where I am right now: https://github.com/NixOS/nixpkgs/pull/35439


Omit Title

Is there any way I can omit the title from getSectionContent() ?
I think it would be better if the title was optional or removed entirely to provide a more immersive reading experience.
Love your work, very useful and really great!

Hi,
Added the needed parameter isOmittingTitleTag. We'll be able to use it on 1.0.84 :)

The new feature works wonderful, thank you very much.


Add new with extra roots on windows

Windows implementation of new_with_extra_roots, which have some problems for now as mentioned in https://github.com/rustls/rustls-platform-verifier/pull/133#issuecomment-2315871410.
Note that it's based on top of https://github.com/rustls/rustls-platform-verifier/pull/133 to benefit the tests defined here.
Partially Fix https://github.com/rustls/rustls-platform-verifier/issues/58

After experimenting using cAdditionalStore/rghAdditionalStore, I concluded that this store can only be used for intermediate certificates and not for roots.
Indeed, when configuring the certEngine, if I add the intermediates only to the additonalStore and the extra roots to the exclusiveStore, the validation is successful. However, if I add both the intermediates and the extra roots to the additionalStore, then the validation failed, saying it doesn't trust the root.
So we can't use cAdditionalStore to achieve what we want. Chromium seems to have also dropped this idea.
I've come up with 3 possible solutions:

Use hExclusiveRoot to load the system trust store and the extra roots. I got a POC locally that pass the tests that looks like this:

Click to expand the code
    fn new_with_extra_roots(
        roots: &[pki_types::CertificateDer<'static>],
    ) -> Result<Self, TlsError> {

        let mut inner = Self::new()?;

        // In memory store for the extra roots
        let mut additional_store = CertificateStore::new()?;
        for root in roots {
            additional_store.add_cert(root)?;
        }

        // System store
        let mut pvpara: Vec<_> = "root".encode_utf16().collect();
        pvpara.push(0);
        let system_store = unsafe { CertOpenSystemStoreW(0, pvpara.as_ptr()) };

        // We create a collection, and we add the two previous created stores.
        let collection = unsafe {
            CertOpenStore(
                CERT_STORE_PROV_COLLECTION,
                X509_ASN_ENCODING | PKCS_7_ASN_ENCODING,
                0,
                CERT_STORE_DEFER_CLOSE_UNTIL_LAST_FREE_FLAG,
                ptr::null(), //must be null in that case
            )
        };
        unsafe {
            CertAddStoreToCollection(
                collection,
                system_store,
                CERT_PHYSICAL_STORE_ADD_ENABLE_FLAG,
                0,
            )
        };
        unsafe {
            CertAddStoreToCollection(
                collection,
                additional_store.inner.as_ptr(),
                CERT_PHYSICAL_STORE_ADD_ENABLE_FLAG,
                0,
            )
        };

        let mut config = CERT_CHAIN_ENGINE_CONFIG::zeroed_with_size();
        config.hExclusiveRoot = collection;
        //..

However, this seems fragile as in Windows they are Root stores in various places. It will be hard to cover and maintain the roots that match the ones that are naturally looked by CertGetCertificateChain that don't use exclusiveStore.

Do the verification twice in case of extra roots and combine the result. One verification with only the system root store and one with only the extra roots. That's what's the Golang std seems to do, but for backward compatibility reasons. To cite the go issue :

In order not to break existing code that invokes x509.SystemCertPool and then adds extra custom certificates to it, we’ll have Verify perform two verification in that case, one with the platform and one with the custom roots, and return chains from both.

Use the same approach as schannel crate. Basically, they add the CERT_CHAIN_POLICY_ALLOW_UNKNOWN_CA_FLAG flag if the root of the chain is in the extra roots.

Other references
In the source code of curl and Dotnet, we can see that they only support using extra roots exclusively, not in combination with the system root store like we plan to support.

This MR is ready to review, I've opted for the golang approach that I discussed on discord.
The Android job failure seems unrelated, as it's already on main.

Apologies I had queued review comments I hadn't submitted from a few days ago. I think Complexspaces and I overlapped in some feedback as a result.

One open question I have is about the infallibility of new_with_extra_roots. After seeing how we need to implement this on Windows, I'm wondering if we want to return Result<Self, TlsError> instead so that we can do OS-level logic in the constructor instead of being restricted to infallible operations.

I would be in favour of this :+1:

The Android job failure seems unrelated, as it's already on main.

https://github.com/rustls/rustls-platform-verifier/pull/140

Thank you both for the thorough review!

One open question I have is about the infallibility of new_with_extra_roots. After seeing how we need to implement this on Windows, I'm wondering if we want to return Result<Self, TlsError> instead so that we can do OS-level logic in the constructor instead of being restricted to infallible operations.

I also totally agree this could be better this way. I've implemented a new constructor where I parse the certificates right away.
I now store the certificate engine in the verifier to avoid creating a store each time for the extra roots.

@djc @ctz Do either of you want to give this a pass or should we merge?

No need to block on me; I looked at it but didn't have time to dig into the details of the Windows API.

Thanks again for your work on this @stormshield-gt :tada:


Updated for new IDmerger option 'reduce collections'

IDmapper got a new option 'reduce collections' that has to be set differently from default for this tutorial

thanks @foellmelanie! do you think we should update the workflow as well?

it was actually IDmerger not IDmapper. I will update the workflow as well.


How to listen to complete upload event in Go code?

I'm trying tusd manually with go code. Is it possible to listen to a upload completed channel?. (without using hooks externally.)
I'm trying to create an external DB record after a successful upload. Additionally wants to send a custom pay load with the last PATCH request
{
"id: "filde-id",
"url" : "s3-url"
"type": "mp4",
"size" :325542545
}

You can look at how the tusd binary implements this. The relevant lines are here: https://github.com/tus/tusd/blob/master/cmd/tusd/cli/hooks.go#L47-L56. In addition, I would recommend reading the documentation for these channels (https://godoc.org/github.com/tus/tusd#UnroutedHandler).

Closing this issue since I assume it's solved. Feel free to leave a comment if you want to continue the discussion :)


Fix lint issues and add logging demo for app/sample

Overview

Fix lint issues in logging
Add logging demo in app/sample

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update

In the scope
Add logging demo
Out of scope
Checklist

[ ] Makes your submission pass tests?
[x] Have you lint your code locally before submission?
[ ] Have you updated the wiki of your change?

Reference

Card: #25
Related PR: NA

I updated the lint issues. @OkieLe


Check error codes/messages against expectations in case of OK responses

In many places like here and here, we do not check OK error code against expectations. My proposal is to have a unified error check like the one below which also takes into account OK error code
if er, ok := status.FromError(err); ok {
	if er.Code() != tt.errCode {
		t.Error("error code: expected", tt.errCode, "received", er.Code())
	}
	if er.Message() != tt.errMsg {
		t.Error("error message: expected", tt.errMsg, "received", er.Message())
	}
} else {
	t.Error("expected grpc error status")
}

This would allow to increase test fidelity and avoid ambiguous situation in the tests like here

fixed in #511, #512, #513, #522


Make argument and option section IDs more unique

Closes #43
This adds the module name and function name (attribute name from the module) to the beginning of the section ID for Named Arguments and options sections. This allows the IDs to be unique and for sphinx to keep section numbering consistent. See the referenced issue for more information.
I'm not really sure how to add a test for this. Also this does not effect subcommand section IDs as I'm not sure I understand how those are structured. This PR solves my immediate problem.

Looks like RTD is failing because CommonMark is an optional dependency but needed to generate the docs.


Add cc_emails attribute to the Account class

The the api has the ability to get and set the cc_emails on an account object.
https://dev.recurly.com/docs/account-object
This was overlooked after it was added to the API.

@bhelx It looks like this has been completed, can you close this issue?

@bhelx It looks like this has been completed, can you close this issue?

Closed with https://github.com/recurly/recurly-client-net/pull/147


Range color is not applied anymore

As reported on the forum, the color normally applied to the left part of the range bar is no longer working. This can be seen with Firefox or Chrome on the documentation page. The color is no longer present on Android (5.1.1), I have not tested on iOS.
Ionic v1.3.1

Hello, thanks for opening an issue with us! I am going to be closing this issue as a duplicate of https://github.com/driftyco/ionic/issues/5913 . Thanks for using Ionic!


Expose frame's execution contexts

https://github.com/kblok/puppeteer/pull/10/commits/231a2be9710f4f918b3dd7f388bf5976d80d826f

Won't implement https://github.com/kblok/puppeteer/pull/10/commits/be7626fa5e8d12aae38e639b8c5b3e525c5384c4


Ignore directory dependencies (the file: and link: protocols)

Affected Packages

Problem
The CLI currently fails if there are local dependencies. Local or directory dependencies are those that use the file:<relative path> or link:<relative path> spec (the link protocol is supported by Yarn and pnpm).

Proposed solution
If a dev dependency is using a link: or file: protocol, just ignore that dependency. It will not require any update because the package's location is not changed when the versions are bumped.

Q: do those protocol makes sense in all type of dependencies? Technically "dependencies" are probably OK, but somewhat bizarre but it doesn't make sense to use those as "peerDependencies", right?

I guess they are fine in prod dependencies, if the project is private. Otherwise only in dev deps.
In peer deps they cannot appear. A peer dep needs to be a range

Oh, it appears that lerna uses these protocols also for prod deps. Lerna basically converts them to regular deps before publish. I think we don't need to support that as we already support workspace ranges.

I am working on this


NavigationPolygonInstance does not use closed polygon

Godot version
3.5.beta1
System information
MacBook Air M1, Monterey 12.1
Issue description
When creating a NavigationPolygonInstance with > 3 Points, the NavigationServer does not close the the polygon. As a result, part of the polygon is not accessible for navigation.
Following video shows the issue (red line for the calculated navigation path) and a working polygon when the polygon is closed (last point equals first point of polygon).
https://user-images.githubusercontent.com/16074028/149425339-7247cf2b-0f54-4166-ae00-021d974d7f71.mov
I might be wrong and this is expected behaviour, but:

the "Visible Navigation" Option in Debug shows the whole polygon
with Polygon, CollisionPolygon, OccluderPolygon there is no need to close the polygon explicitly
I didn't find an option to close the polygon using the editor, which makes it impossible to create navigation polygons without code...
all helper methods in Geometry (merge, clip etc.) do not close polygons

Steps to reproduce

Create a NavigationPolygonInstance with more than 3 Points in the editor.
Calculate Path using NavigationServer/NavigationAgent

Minimal reproduction project
nav-poly-min-repro.zip

I can reproduce this on 3.x e00a6d2b7, but not on master d13c3c929.
master (4.0) version of the minimal reproduction project: nav-poly-min-repro-4.0.zip
Video of the project on master with the bug not occurring there:
https://user-images.githubusercontent.com/180032/149430360-8dab06a9-d816-4f49-ac20-31699a7f28ef.mp4

CC @AndreaCatania @Duroxxigar

Fixed by #56976.


Basic MySql dialog authentication support

Encountered a mariadb server that only accepted dialog authentication (which seems typical if using mariadb's pam integration). This PR adds support for dialog authentication if the server is only asking for a password.
On my system I set up a mariadb server with basic pam authentication. When providing the correct password I am able to connect to the database and execute queries.
If the password is wrong I get the following error:
Error: Database(MySqlDatabaseError { code: Some("28000"), number: 1045, message: "Access denied for user \'ahouts\'@\'localhost\' (using password: NO)" })

If I do not provide a password I get the following:
Error: Protocol("interactive dialog authentication is currently not supported")

This is incredibly interesting. After a bit of digging ... I suppose the most correct approach here would be to have an async "password callback" function where the user can do anything to return a password. It might be a good idea to actually do that universally and allow password to be added to XConnectOptions as a callback.

Do you mind adding this to the next branch ? It will take a bit of refactoring (as the core structure has changed a fair amount). The MySQL support there is around 90% complete and could accept this. If not, it's not too much trouble for us to get to the refactoring but we'd rather not merge this to master.

This is incredibly interesting. After a bit of digging ... I suppose the most correct approach here would be to have an async "password callback" function where the user can do anything to return a password. It might be a good idea to actually do that universally and allow password to be added to XConnectOptions as a callback.

I totally agree, but decided against trying to implement that myself since that seems pretty involved and would be a large change to the public API.

Do you mind adding this to the next branch ?

Sure, see #1075


Cache results

Data are static, no change is expected.
Sphinxsearch searchd has some internal cache for repeated queries, but we don't know how it is managed.
Idea:

cache full results of requests, save it for 1 week from the last "visit"
cache results for autocomplete is not long, it could be in some SQLiteDB with hash
use memcache / varnish with correct settings

@o1da what do you suggest? I think you have some experience with caching.

For now we will use only CDN caching'

An aggressive cache on the CDN is configured now (up to one month on the edge servers).
After deployment of a new version of the software or update of the data we must manually flush it.
Redirects are not yet active - but are going to be turned on once we upgrade the existing clients.
Implementation of local cache probably later on - with a new ticket. Closing.

@klokan The caching does not work at the moment.
Because "The Ignore Query String setting only applies to static file extensions." (see https://support.cloudflare.com/hc/en-us/articles/200168256-What-are-CloudFlare-s-caching-levels- and https://support.cloudflare.com/hc/en-us/articles/200172516-Which-file-extensions-does-CloudFlare-cache-for-static-content-)

I have contacted the Support with relevant request:
https://support.cloudflare.com/hc/en-us/requests/1192193

A workaround is to add .js suffix to every submitted request, as this extension is on the list.
Then everything would run as we want. The .json suffix would be better, but I guess this is acceptable for us too.
The server can return the same result for both /q/brno and /q/brno.js, and we set the rules for redirecting away from CDN if .js suffix is missing.
@MartinMikita, @petrsloup could you please implement this on both server and client side and deploy new versions?

Server is prepared. @petrsloup let me know, if I can deploy it or you need to make some change in this repository.

@petrsloup could you please adjust the client?

Deployed, caching seems to be working ok..


Beeg plugin is broken after site update

ps: I know that server is old but happened the same on newer platforms.
youtube-dl -vvv https://beeg.com/-01859901571
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-vvv', u'https://beeg.com/-01859901571']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 2.7.6 (CPython) - Linux-3.13.0-170-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: ffmpeg N-76159-gda43e9e, ffprobe N-76159-gda43e9e, rtmpdump 2.4
[debug] Proxy map: {}
[generic] -01859901571: Requesting header
WARNING: Falling back on generic information extractor.
[generic] -01859901571: Downloading webpage
[generic] -01859901571: Extracting information
ERROR: Unsupported URL: https://beeg.com/-01859901571
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 2503, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2571, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2560, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 7, column 31
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 3520, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://beeg.com/-01859901571

See #29781.
A PR should appear to fix this, as my development version handles this URL (with the - removed). If links are being made with the - as above, presumably that format should also be supported.


createPlaylist is missing the options parameter

this.createPlaylist = function(userId, playlistName, callback) {...}
Needed for setting public as demonstrated in the examples.

Thanks for raising this @allinallin, I'll have it sorted shortly.

Fixed and deployed in 1.3.5. Thanks again!


Consistency in field naming

I was just tripped up by an issue where I had named my .nested-field section incorrectly - sure it was my mistake, but there is inconsistency:

link for adding fields uses .add_field
link for removing fields uses .remove_field
section for form uses .add-field

!!!

Really? I will check this. At first sight I do not see any reference to .add-field at all, I can only see any reference to .remove_fields and .add_fields.

Sorry, not .add-field - .nested-fields.

That is indeed a valid remark. I consider it less important, but feel free to improve it.


Barefoot switch compilation error

When I compiled p4ml.p4 in the Barefoot programmable switch, the following error occurred:
warning: Tofino does not support emitting constant 0 in digest, skipped /root/bf-sde-9.1.0/pkgsrc/p4-examples/p4_16_programs/p4ml/includes/actions.p4(13): [--Werror=target-error] error: noequ0_processentry1andWriteToPacket: Unsupported on target The table .noequ0_processEntry1andWriteToPacket with no key cannot have the action noequ0_processentry1andWriteToPacket.  This action requires hash, which can only be done through the hit pathway.  However, because the table has multiple actions, the driver may need to change at runtime, and the driver can only currently program the miss pathway.  The solution may be to declare only one action on the table, and mark it as the default action.
My operating environment is: Barefoot SDE 9.1.0
I have no clue about this. Hope to get your answer.

Hi,
The code is compiled with SDE 8.9.1. It also gets compiled with SDE 8.9.2.
Could you please try with SDE 8.9.x?
Thanks!

Thank you very much for your reply, I will give it a try!


fix: Button and Coloring QoLs and hovering problems

fix: Colors, hovering, and design problems
feat: Added QoL features and drafts
Co-Authored-By: @TerrifiedPigeon

 Themes / Display


Remove 'io.github.classgraph:classgraph' dependency

This is causing issues when building a native image with graal and needs to be removed.
Related to #24

Closed as part of #30


feat: add try_set_offset method

This allows changing the offset of the string so that it points to a new slice. All the bound checks are done to prevent any memory issues.

LGTM. Thanks <3


drone/docker: prepare multi-arch release

Following #7480 this PR make the current docker release suffixed  by -linux-amd64 and add a manifest pipeline linking the default latest and tagged version to corresponding arch.
Later we will only need to add specific docker-os-arch pipeline (+ manifest) to add a supported arch.
This PR is based on what the drone plugin does:
https://github.com/drone-plugins/drone-docker/blob/master/docker/docker/manifest.tmpl
https://github.com/drone-plugins/drone-docker/blob/master/.drone.yml#L303

I don't know why but drone doesn't like the file: https://drone.gitea.io/go-gitea/gitea/11012
I check lint via cli (drone version 1.1.2) and it doesn't report me anything.
drone exec --event pull_request also work.

notify pipeline depends on docker

@techknowlogick Thx it works now.

Codecov Report

Merging #7571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7571   +/-   ##
=======================================
  Coverage   41.24%   41.24%
=======================================
  Files         469      469
  Lines       63608    63608
=======================================
  Hits        26236    26236
  Misses      33952    33952
  Partials     3420     3420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635e7b3...1267efd. Read the comment docs.


Adding a loading Screen Component

Is your feature request related to a problem? Please describe.
I am adding a loading screen for a website.
Describe the solution you'd like
A preloader screen is a UI component that can be added to any website
Describe alternatives you've considered
An effective alternative is a splash screen.
Additional context
Add any other context or screenshots about the feature request here.

Closing wrt #179


Mouse becoming invisible

when im on fullscreen its just invisible, dont know why

https://hastebin.com/share/ayisenatav.json
my current fflags

Are you using exclusive fullscreen?

I assume i am not, since i don't even see the setting in bloxstrap

Also could you please make a direct shortcut for bloxstrap settings in desktop? its impossible to open them again for people that disabled search for performance (for example it eats tons of cpu randomly, around 90% most of the times)

disabled the search function just for performance

are you kidding me wtf do you guys keep doing to your pc
anyway literally just scroll through the start menu to find it. the wiki page tells you to do that too.

about the missing mouse cursor, stop using vulkan. stay on the automatic rendering mode.

it wasnt just with vulkan, this issue randomly happens when using ANY render mode, i just have to uninstall and install bloxstrap again until it fixes

Hey im having the same issue, if you fixed it with this "f.lux" where do i find it so i could too.

Hey im having the same issue, if you fixed it with this "f.lux" where do i find it so i could too.

no no, i was talking about the issue being caused by "f.lux"


QSP-3 Enforce Strong Passwords

There is no password policy in place meaning users can enter very simple/insecure passwords and they are accepted as valid.
We will agree on and enforce a policy to prevent this.

Potential lib for implementing this: https://www.npmjs.com/package/owasp-password-strength-test


Update PropertyMetadata.cs

Map displayName when provide in caller

Can I get some more background on this? Was a particular part of the UI not working correctly?

When showing the user properties, the UI always shows the name parameter even a displayName parameter is given.  See below example, the "given_name" is show on the properties tab even I would like to show "First name"
Example:
update.Add(PropertyMetadata.FromFunctions<TUser, string>("given_name", u => GetGivenName(u), SetGivenName, "First name", PropertyDataType.String, true));
In the original code, the displayName parameter is not mapped to meta.Name properly.  The FromFunctions takes the displayName but not using it at all.  The change mapped parameter displayName to meta.Name which the UI will pick up the value and display.

Cool, thanks! I'll merge and release when I get a chance.


SDFSOF-26: Refactor custody transaction creation

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Move conditions for custody transaction creation to caller service
Rename deposit generators to follow the same pattern
Why
Caller service should be responsible for checking the conditions
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr869.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr869.previews.kube001.services.stellar-ops.com/


[Question] Texture???

While reading https://blogs.unity3d.com/2018/10/08/optimizing-loading-performance-understanding-the-async-upload-pipeline/ I have found that during build unity puts all the textures to an optimized binary file.
Now I am developing my own engine (heavily inspired by yours). There I am working on Texture loading. I already have Asynchronous Texture loading which reduced the loading time down to 50%.
But every time the texture is load stb_image or FreeImage does some post processing and pre processing this increases the loading time a lot in case of big textures like 8k Textures. So I was thinking how can I write the texture to a binary format so that once loaded from the second time it loads from the binary and doesn't take much time?
Now, honestly I am stuck here since I have google but didn't found any answer. My only question is how do they do it? Also, I would like to know how will you implement it to your own engine?

Please keep all questions regarding help with personal projects to the discord.

To be fair, I really think you'll get a faster and more accurate response if you ask it on the discord, for which reasons I'll close this issue.
On another note, @Puddlestomper, should we maybe state this explicitly in the contributing guidelines under the Reporting Bugs section or the general introduction (first paragraph)?


Shortlink Backend Nodejs Port

Time tracking: https://its-pro.ucsd.edu/browse/SVCOPS-407
This is complete when:

[x] The shortlink tool backend  is ported to Node.js
[x] The whitelist can be updated outside of main function logic

Shortlink backend port to nodejs has been completed in sandbox/QA and is ready for review.
*Shortlink tool update tracked in issue #1741
Repo: ShortUrlService
API: ShortUrlService


what is the httpclient default timeout when calling chat-completion endpoint ?

Library name and version
Azure.AI.OpenAI 1.0.0-beta.6
Query/Question
what is the httpclient default timeout when calling chat-completion endpoint ?
I have a strange behavior:
I see some response  time being something like 1 min and 20 sec , as reported by datadog on the caller side, but when i go to datadog azure open ai metrics , I see calls lasting about 40 secs or so , no errors .. nothing as long as reported by my caller code.
My suspicion is that there is some kind of timeout with retry internal to the SDK .. but debugging I can see an http client with timeout set to timespan.infinite,  but maybe there is some other block of the pipeline that "timeout"
thanks
Environment
Linux azure web app, net 8.0

hello, any update on this ?

I think it's a bug in the chat completion REST API. Using HttpClient directly and Postman, I can experience this issue where no response is received even though the azure logs report a 408 was sent.
I am in discussions with support staff from Azure and it looks like on their end they experience a ClientConnectionFailure error where the client connection was unexpectedly closed.


Liquid Outlet and Scroll Distance

Hi @ef4 !
Trying out Liquid Fire again.  I've got a problem I can't quite figure out - it seems like a fairly common stumbling block, but I can't find any documentation on it.
I'm defining a transition between two top level routes (home -> posts)
home is a page that is taller than the viewport.
When the user scrolls down on the home template, and then initiates the transition to posts, the home template jumps back to the top of the page due to the absolute positioning.
I would like for the home template to keep its scroll offset during the transition.  Is this possible?

Just wanted to bump this - need to make a decision on liquid fire before wednesday, and this is make or break.

Yes, it's possible. It sounds like you're doing full-viewport animation, so I would suggest making your topmost liquid-outlet fixed at 100% of the viewport size, and allow your content to scroll inside that. Then you have full control over how it animates and scrolls.

Also see my memory-scroll repo for an add-on that helps with the opposite case -- returning to the same scroll position that you left.

Thanks @ef4 - I was about to implement the viewport size technique, but I realized that would mean those views on iOS would have no scroll inertia, right?

@hhff you can add inertial scrolling back in by setting -webkit-overflow-scrolling: touch;
https://css-tricks.com/snippets/css/momentum-scrolling-on-ios-overflow-elements/

@rlivsey that's a game changer.  case closed !!


Completely indistinguishable from original upstream Chromium

OS/Platform
macOS
Installed
OS/Platform's package manager
Version
103
Tested upstream?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there

Description
Ungoogled Chromium cannot be distinguished in any reliable way from upstream
How to Reproduce?
1.) try to find a way whether a given installed copy of Chromium is "Ungoogled" or original
Actual behaviour
Cannot be distinguished
Expected behaviour
I expect to have a reliable way to distinguish "ungoogled" chromium from the original
Relevant log output
No response
Additional context
Our MacUpdater aims to correctly display the latest version (and possibly automatically) update any macOS software ever released.
MacUpdater can correctly distinguish these Chromium forks:
Chedot
Chromium
Epic
ipDTL
Iron
RocketNav
Superbird
URBrowser
however, Ungoogled Chromium is indistinguishable from the original and will therefore result in wrong version number display.
NOTE: all other chromium forks are distinguishable by the CFBundleName entry in Chromium.app/Contents/Resources/en.lproj/InfoPlist.strings
so, if you could set set this value to "Chromium Ungoogled" this issue would be nicely fixed - thanks!

Does chrome://version/ include ungoogled-chromium perhaps?

@kramred Is it possible? Would it be reasonable to do?

Does chrome://version/ include ungoogled-chromium perhaps?

it does but how to read that value programmatically by inspecting the on-disk files?


Blockchain not synchronizing

I was able to look on Reddit and other forums and I did find an updated blockchain download from December 3rd 2017 and I copied it to my /Users/Name/AppData/Roaming/Zclassic  and in the program it did update up until that date. However, it seems as if it is having trouble connecting to the network. Before I downloaded the updated block chain it was stuck on November 6th (I am pretty sure) 2016. I read somewhere online I was supposed to open port 8133 on my router. I tried with no luck on updating my blockchain database. Am I missing something? Thank you in advanced!

Sorry but I am not an expert on the ZCL network issues. Blockchain synchronization is not a problem of the GUI wallet itself. I think you need to contact the current ZClassic core/node developers (I am not one of them) and try to get support.


EXP | How to dynamically change icons

What is the example you wish to see?

to

Is there any context that might help us understand?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

import { useState } from "react"
import iconSrc from "url:./assets/something.png"

function IndexPopup() {
  const [data, setData] = useState("")

  return (

        Welcome to your Plasmo Extension!

      <input
        onChange={(e) => chrome.action.setIcon({ path: iconSrc })}
        value={data}
      />

  )
}

export default IndexPopup

Make sure your icon is the right size and a PNG.

import { useState } from "react"
import iconSrc from "url:./assets/something.png"

function IndexPopup() {
  const [data, setData] = useState("")

  return (

        Welcome to your Plasmo Extension!

      <input
        onChange={(e) => chrome.action.setIcon({ path: iconSrc })}
        value={data}
      />

  )
}

export default IndexPopup

Make sure your icon is the right size and a PNG.

It seems to be ineffective. Do I need to make any changes in the new version


Return the buffer instead of the process when creating the repl buffer

This fixes #570 . and blocks in elisp return the last "truthy" value, otherwise nil. #570 as a result returned the process and not the buffer when the and expression was true, resulting to an error described in #572 .

Thanks


Use CARGO_ENCODED_RUSTFLAGS instead of RUSTFLAGS to pass flags to rustc

This allows arguments (such as the ones added internally for --remap-path-prefix) to included space characters without causing errors.
If users of wasmbuild provide their own flags through RUSTFLAGS, they will be merged into our CARGO_ENCODED_RUSTFLAGS value, to match the existing behaviour of wasmbuild. If they provide flags through CARGO_ENCODED_RUSTFLAGS, those will take precedence and RUSTFLAGS will be ignored, in order to match Cargo's precedence behaviour when both are' specified.
(Note that because we're always passing rustc flags through the environment, Cargo invoked by wasmbuild will never use any flags that are specified in the project's own TOML files because the environment takes priority. This isn't a change of behaviour, I just wanted to note as a deviation from plain Cargo behaviour to make it clear that matching the environment variable precedence doesn't mean we're matching its overall precedence rules for flag configuration.)

fixes #98, tested by rebuilding wasmbuild's own wasm with the directory renamed /mnt/c/Users/_/denoland/wasm= build, to ensure that space characters and equals characters are both okay. (It's not possible to specify equals characters in the target path, by rustc's own logic, but in the source path they're handled correclty.)
fixes #135, tested by looking at the output of strings target/wasm32-unknown-unknown/release/wasmbuild.wasm  | grep cargo | head -n 10 which now includes ~/.cargo/ where it previously included /home/jeremy/.cargo/.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

🦗

🦗

I didn't see this PR until now. Just ask next time instead of crickets please. It's a Sunday night so I'll look at it later.

🦗

I didn't see this PR until now. Just ask next time instead of crickets please. It's a Sunday night so I'll look at it later.

Apologies for the snark. Thanks for reviewing.


Support for WAV files

Does this crate support ID3 tags in WAV files?

Yes, although only if the ID3 tag is preceding the WAV itself. I have seen ID3 tags being contained in the WAV as a separate chunk, but that is not supported (yet)

I'm implementing WAV metadata support for Polaris, which uses rust-id3. I considered contributing support for ID3 tags inside chunks for this crate, but managing WAV chunks when writing tags would require some work beyond what I can do. I guess I'll try to extract the the ID3 chunk payload in Polaris, and pass it to this crate. Thanks for the quick response.

Actually, it might be simpler than I thought. I have 342 WAV files in my music library, and all of them have the same chunk pattern:
RIFF(WAVE)->
            fmt ;
            data;
            <some other chunks>
            ID3 ;

Some notable examples:
RIFF(WAVE)-> (76796826 Bytes)
            fmt ; (16 Bytes)
            data; (74880000 Bytes)
            LIST(INFO)-> (78 Bytes)
                        IPRD; (7 Bytes)
                        IART; (8 Bytes)
                        INAM; (14 Bytes)
                        ITRK; (2 Bytes)
                        ICRD; (5 Bytes)
            id3 ; (1916695 Bytes)

RIFF(WAVE)-> (76769030 Bytes)
            fmt ; (16 Bytes)
            bext; (602 Bytes)
            minf; (16 Bytes)
            elm1; (214 Bytes)
            data; (70272000 Bytes)
            regn; (92 Bytes)
            umid; (24 Bytes)
            DGDA; (412973 Bytes)
            iXML; (1525 Bytes)
            _PMX; (5916 Bytes)
            ID3 ; (6075561 Bytes)

RIFF(WAVE)-> (67376330 Bytes)
            fmt ; (16 Bytes)
            data; (67212508 Bytes)
            id3 ; (163686 Bytes)
            LIST(INFO)-> (84 Bytes)
                        IART; (16 Bytes)
                        INAM; (37 Bytes)
                        IGNR; (6 Bytes)

If we consider that the ID3 chunk will always be a direct child of the RIFF root chunk, we just need to update the root chunk's size, and shift trailing data accordingly. I noticed there is already code for shifting trailing data left or right for mp3 files, so it should only be a matter of refactoring the code and implementing the chunk size update. Please let me know if you find this reasonable, as I would be willing send in a pull request.

Yes, that storage solution was initially made to be adaptable to WAV files, so please go ahead :)
There are also a few things to take into consideration:

Should we write to a chunk or header in a tag-less WAV file?
If we encounter both chunk and header tags while reading a WAV file, what should we do?
How should we write to WAV files containing both chunk and header tags?

Regarding the conflict between chunk and header tags, I don't really know what we should do. I checked my library, and none of my wav files have header tags, just chunk tags. The wav spec states that the file must start with a RIFF header, so I'm not sure if header tags are actually supported. What do you think?

I'll try to manually craft a wav file with header tags and see if it works.

So, I managed to produce a wav file with a mp3 header. While my tag editor doesn't recognize the tags, my music player recognizes  both the tags and the audio.

@polyfloyd I've been thinking about it, and I've come up with this:

If the file starts with a RIFF WAV header (and therefore has no header tag), use the ID3 chunk. Create this chunk at the end of the file if it doesn't exists.
Otherwise, use a header ID3 tag. Create one if it doesn't exists.

I believe it will handle most cases correctly this way. Please let me know what you think about it.

Let's worry about just WAV files for now, we will most likely have a separate API like we already do for AIFF.
If I interpret your answer correctly we should prefer ID3 tags as a WAV chunk? So what should we do in a situation where we encounter a WAV file with both ID3 chunk and ID3 as header?

Oh, that's great. I believe a separate API will make things easy.
Regarding using chunk or header tags, I've found that header tags in WAV files are invalid. While some players recognize them, most don't (including VLC). The specification states that extra contents in WAV files should be placed inside non-standard chunks, which is the case of the commonly used ID3 chunk. Therefore, I believe we should only support chunk tags in this separate API.
I've started working on the implementation, and will submit a pull request soon.

@polyfloyd i have created a pull request adressing this issue. Please let me know of any suggestion.


Put pexpect and winpexpect back into Repo

In #128, winexpect and pexpect were removed from the repository and added to a requirements.txt file so that they could be pip installed.
While testing another change, I found that winpexpect fails when running in a  virtual environment. It turns out that pip uses this repo while the pexpect that was in the VistA repo was a slightly newer version from here. In particular, this commit is needed to fix the virtual environment issue.
I also noticed that the copies of both winpexpect and pexpect in the VistA repo had been modified. Are these modifications needed?

Fixed as part of #178


Hide all symbols by default

Fixe #2462
TODO:

[x] Set all symbol hidden by default

[x] Libraries
[x] Bindings

[ ] Ensure bindings don't define same symbol many time

[ ] include/pinocchio/bindings/python/parsers/python.hpp

pinocchio::python::buildModel is exported by all bindings

[x] Add development/misc/common_symbols.py scripts to detect common symbols in many libraries

[x] Test and fix

[x] default
[x] collision
[x] autodiff
[x] codegen
[x] extra
[x] casadi
[x] openmp
[x] mpfr
[x] clang
[x] all

When working on this PR, I found the following issue with GCC, explicit template instantiation and symbol visibility.
template <typename T>
struct MyClass
{
  void bar(MyClass<int>);

  int getContacts() const
  {
    return m_value;
  }
  int m_value;
};

#ifndef BUG
extern template struct __attribute__((visibility("default"))) MyClass<int>;
#endif

template <typename T>
void MyClass<T>::bar(MyClass<int>) {}

#ifdef BUG
extern template struct __attribute__((visibility("default"))) MyClass<int>;
#endif

template struct MyClass<int>;

When builded with the following command line:
CC=g++
FLAGS=-DBUG
$CC -fPIC -Wall -Wextra -pedantic -fvisibility=hidden -fvisibility-inlines-hidden $FLAGS -c test.cpp -o test.o
$CC -fPIC -Wall -Wextra -pedantic -fvisibility=hidden -fvisibility-inlines-hidden -shared -Wl,-soname,libtest.so test.o -o libtest.so
nm -C libtest.so | grep MyClass

We have the following output:
test.cpp:21:63: warning: type attributes ignored after type is already defined [-Wattributes]
   21 | extern template struct __attribute__((visibility("default"))) MyClass<int>;
      |                                                               ^~~~~~~~~~~~
00000000000010d8 t MyClass<int>::bar(MyClass<int>)
00000000000010e6 t MyClass<int>::getContacts() const

The visibility attribute is ignored.
When build with FLAGS=
00000000000010d8 W MyClass<int>::bar(MyClass<int>)
00000000000010e6 W MyClass<int>::getContacts() const

The symbols are well exported.
So we need to declare the explicit template instantiation before defining any function that use MyClass.

Another interesting case. I think there is an issue with clang on osx and thread-local symbol visibility.
We can reproduce the issue by compiling this code (test.cpp):
struct Toto {Toto(int* ptr) {}};
template<class Base>
struct CGOStreamFunc {
  static thread_local Toto FUNC;
};
template<class Base>
thread_local Toto CGOStreamFunc<Base>::FUNC(nullptr);

template struct CGOStreamFunc<double>;

Then building it with:
clang++ -fPIC -c test.cpp -o no_hidden.o
clang++ -fvisibility=hidden -fPIC -c test.cpp -o hidden.o

If we run nm -C no_hidden.o we will have the following output:
0000000000000070 s thread-local initialization routine for CGOStreamFunc<double>::FUNC
000000000000004c T thread-local wrapper routine for CGOStreamFunc<double>::FUNC

If we run nm -C hidden.o we will have the following output:
...
0000000000000070 S thread-local initialization routine for CGOStreamFunc::FUNC
000000000000004c T thread-local wrapper routine for CGOStreamFunc::FUNC
...
The CGOStreamFunc<double>::FUNC symbol visibility change. It's exported when building with -fvisibility=hidden and private
when build without -fvisiblitiy.
This create a linking error when building Pinocchio in Debug mode with codegen activated.
cppaddcg define a static thread local variable in cg/cg.hpp that create the following error:
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-force.cpp.o
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-inertia.cpp.o
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-SE3.cpp.o
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-motion.cpp.o
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/algorithm/expose-constrained-dynamics.cpp.o
duplicate symbol 'thread-local initialization routine for CppAD::cg::CGOStreamFunc<double>::FUNC' in:
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/spatial/expose-symmetric3.cpp.o
    bindings/python/CMakeFiles/pinocchio_pywrap_cppadcg.dir/multibody/expose-frame.cpp.o

I don't really know how to manage this issue…

pinocchio::python::buildModel should never be build in bindings as show in https://github.com/stack-of-tasks/pinocchio/issues/2474


feat: Support extensible enum types in Typescript (box/box-codegen#520)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 4 (0.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.03%) to 42.035%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/managers/events.generated.ts
0
2
0.0%

src/schemas/event.generated.ts
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/schemas/termsOfService.generated.ts
1
54.41%

src/schemas/event.generated.ts
1
40.79%

src/managers/events.generated.ts
1
12.38%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
12655

Relevant Lines:
23458

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 4 (0.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 42.035%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/managers/events.generated.ts
0
2
0.0%

src/schemas/event.generated.ts
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/schemas/event.generated.ts
1
40.79%

src/managers/events.generated.ts
1
12.38%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
12655

Relevant Lines:
23458

💛  - Coveralls


Use contextual type of the left operand for the right one in assignments to auto-typed class fields

fixes https://github.com/microsoft/TypeScript/issues/60394

@jakebailey I fixed a small regression that has been caught above, could you rerun the tests? :)


Community/Collection logo not showing when browsing with a non-default filter

Describe the bug
On DSpace7, while browsing Communities and Collections with a logo, if you click on any filter (By Issue Date, By Author, ...) the logo disappears.
Default filter:

By Issue Date filter:

Community Example
Collection Example
To Reproduce

Follow any one link above and notice the Community/Collection logo;
Click on "By Issue Date" or any other filter.

Expected behavior
The logo should still be displayed.

@tdonohue
we can work on this, the estimation is around 2/4 hours


Vulkan: Environment background_mode set to Canvas causes 2D viewport, tooltips, context menus, and popups to be blank (DisplayServer regression)

Godot version
v4.0.dev.calinou (29bdd000f)
System information
Windows 10, Vulkan, RX 580 (Driver Version <IP_ADDRESS>-210217a-364232E-RadeonSoftwareAdrenalin2020)
Issue description
When the WorldEnvironment's background_type is set to canvas (BG_CANVAS) all tooltips, context menus, and pop up windows appear as blank grey squares. They still work if you know where to click.
I'm using the latest build from https://hugo.pro/projects/godot-builds/

Steps to reproduce

Create a 3D scene.
Add a WorldEnvironment child.
Add a new Environment.
Change the environment's background type to "Canvas"

Now hover over exported properties, right click nodes, open anything on the menu bar.
Minimal reproduction project
GodotTest.zip

I can confirm this issue! in 2D its even worse, because everything disappear in the scene:

Note that setting the Canvas Max Layer to a negative value makes everything show up again, but none of the environement properties seem to actually apply in that case.
This effectively means it's impossible to use the wordenvironment (and therefore glow and such) with 2D in current master as far as I can tell?

Okay so I (a complete C++ novice) spent some time trying to debug this today, and I think I've found part of the cause. (note that i might also be completely wrong so take this with a grain of salt).
When WorldEnvironment's background_type is set to canvas (BG_CANVAS) then the method render_empty_scene gets called to (as far as i can tell) render a transparent 3d scene on top of the canvas. This method seems to be broken though, since it does not pass the environment that it finds on to scene_render->render_scene.
Proposed fix:
- scene_render->render_scene(p_render_buffers, &camera_data, PagedArray<RendererSceneRender::GeometryInstance *>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), RID(), RID(), p_shadow_atlas, RID(), scenario->reflection_atlas, RID(), 0, 0, nullptr, 0, nullptr, 0, nullptr);
+ scene_render->render_scene(p_render_buffers, &camera_data, PagedArray<RendererSceneRender::GeometryInstance *>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), PagedArray<RID>(), environment, RID(), p_shadow_atlas, RID(), scenario->reflection_atlas, RID(), 0, 0, nullptr, 0, nullptr, 0, nullptr);

This turns out to not be enough to fix the issue completely, unfortunately. It seems that the tonemapper effect (desponsible for glow, tonemapping etc.) makes the entire viewport black (NOT the clear color, but completely black). I've spent a ton of time (compilation takes around 5min on my potato machine) and other than narrowing it down to the tonemapper, I cannot figure out what's going wrong :(
Probably useless but screenshot after the "fix":

Okay so forgot what i said about it being the tonemapper. I think the problem just shows there because of what texture the tonemapper gets passed. Unfortunatly, I have no idea how to debug what texture gets passed to a shader (espcially since it's just an RID, and i have no idea how to use those properly), so I am once again stuck.
My guess (100% a guess, I am too noob to actually figure out how this works), is that the internal texture in p_viewport->render_buffers, somehow does not contain the previously drawn 2d canvas content from RSG::canvas->render_canvas(p_viewport->render_target, ...) calls. Again weather that's how it actually works I have no idea.
Might try again when I have more time, but I think this issue might run deeper than I am able to fix. (sorry for the spam on this issue, do say if these updates are not allowed, i just thought they might help someone in the future.)

I've had a look at it as well and pretty much came to the same conclusion as @jsmnbom.
a couple of things to note:
I am almost certain that @jsmnbom is correct that this call needs to get environment passed:
https://github.com/godotengine/godot/blob/9c746b32131d79d85fe05a09db7d8f2f229c3362/servers/rendering/renderer_scene_cull.cpp#L3271
In addition, it should probably get passed scenario->camera_effects (which now holds the settings for the DOF effect) as well (it's the two empty RIDs right before p_shadow_atlas). Only by passing those arguments will the tonemapper code for the various effects be invoked.
then, I've confirmed that the current state is pretty much how it's always been since the initial Vulkan implementation. so unfortunately it's hard to compare it with the state when it was last working.
next, I've toyed around with RenderDoc to attempt confirm @jsmnbom's suspicion that the issue is not down due to a bug in the tonemapper but rather that it gets passed a black texture. If I interpret it correctly, this really seems to be the case. So it would be interesting to inspect the render buffers - however, I too have no clue how to debug RIDs. It doesn't seem to be documented anywhere.

I did some deeper diging and the issues seems to be not only the enviroment not beeing passed, but also the canvas rendering to a completly different texture: p_viewport->render_buffers->render_target. The 3D and post-processing pipeline however uses render_buffers->internal_texture and only copies in the very last moment into render_target .
The simple solution would be to copy the contents of render_target into internal_texture. That seems to be the easiet arround here:
https://github.com/godotengine/godot/blob/8d15814e6a211646a04478978224fd1af41a75cc/servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp#L1559-L1561
I've tried things like copy_effects->copy_to_fb_rect() but that doesn't work for "Vulkan reasons"🙃, need to do more digging there.

anyone considering addressing this be also aware of this related proposal https://github.com/godotengine/godot-proposals/issues/4564
if 2D and 3D post processing is to be separated, then the solution this issue might look different.

This is still an issue in Godot 4.0 Beta 1
All my backgrounds use this method to draw 2D skies behind the 3D world, so it currently breaks the entire view in-game

This issue makes any kind of WorldEnvironment post-processing impossible to use in 2D projects.
Present both on Windows 11 (R5 2600, RX580 4G) and Linux (i5 8265U, intel UHD620) - tried on latest Ubuntu and Fedora releases.
I've looked into it, and I also think that the issue has something to do with canvas rendering texture target. But sadly, my knowledge isn't sufficient to fix this :(
I do agree with @h0lley that 2D and 3D post-processing separation should be considered, though.

Still an issue in Beta 2...

Issue persists in Beta 3 [v4.0.beta3.official (Windows 10 x64)]

Issue persists in Beta 3 [v4.0.beta3.official (Linux Ubuntu 22.04)]

Issue persists in Beta 4 v4.0.beta4.official [e6751549c] (Artix Linux)

As noted in OP, please stop posting further confirmation comments. It will not help the issue be resolved faster. Future comments not bringing significant new information will be removed.


Set libraries to specific versions in requirements.txt

If versions are not specified, then dependent libraries will silently update to the latest version, which may occasionally break things.  E.g., a silent dependent library update breaks backward compatibility in some way, thus breaking our code.

Mmkay, I used pip freeze > requirements_freeze.txt to generate a version with pinned dependencies.
My understanding is that there's an ongoing debate within the Python community about best practices for dependency pinning (ex. with tools like pipenv and poetry)—I'm not sure what's standard these days.
My thought is that we'll manually curate a requirements.txt to cleanly list our top-level dependencies with minimal constraints, and periodically generate a requirements_freeze.txt for users.


Add a sha1 feature to enable pkcs8/sha1

Currently, the RSA crate doesn't have a feature to enable the sha1 feature in the pkcs8 crate. It would be great if we could add this feature to enable sha1 from this crate.

@tarcieri any thoughts on this?

@dignifiedquire generally reviews PR for and maintains the rsa crate
My initial thought on this is that it probably isn't worth adding a sha1 feature for this alone. Maybe if there are strong interop reasons it might be useful e.g. as an MGF.
As an alternative you can add pkcs8 as a direct dependency:
[dependencies]
pkcs8 = { features = ["sha1"], ... }
rsa = { ... }

yeah in a similar boat, I would like to avoid adding feature flags for all features of each dependency. the snippet at the end above should do the trick for you. If not please describe the concrete use case

Think we can close this then.
@jpalathu hopefully the snipped I provided works for you.


Added the status info into device

@cjdcordeiro I have already tested the CIMI locally and added the status info to the device

@ssgUPC is this still valid?

yes it is valid but before you release the version CIMI please let me know that actually I also need to upload new docker-image

once you upload the new image let me know

Uploading the new image


Is there a lagcorrection function in the leap package

Hello Is there a function like lagcorrection in the leap toolkit

Sorry, no, there is not.

Ok, thank you.Recently, I have been focusing more on filtering techniques. I noticed that you mentioned BLF filtering and dictionary methods, and I have also experimented with Wiener filtering. After conducting some experiments, I compared the reconstruction results from Wiener filtering and BLF filtering, and found that the errors between them are very small. In this case, would it be acceptable to freely choose among these filtering methods depending on the situation

BLF should outperform Wiener filtering by a lot, especially if you want to preserve resolution and edges.
In my opinion, the best noise filters in LEAP are TV and Guided Filter.

Oh my gosh! How is LEAP such an amazing package! Thank you so much for your guidance! I tried adjusting the TV iteration count and got great results!


MultiZone

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e65b03) 76.02% compared to head (41bfc04) 74.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   76.02%   74.19%   -1.84%
==========================================
  Files          32       32
  Lines        2273     2410     +137
==========================================
+ Hits         1728     1788      +60
- Misses        545      622      +77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@srpyprime I suggest we move MultiZone control section to AutoMesh (Volume Meshing) instead of creating a new .rst file.


crash on isReadableOrWritable

I'm struggling with one crash since version 0.12.87 (so I'm stuck on 0.12.86 which works fine). It happens almost every time when I start application and in-between running. I was hoping to see fix in each version but it did happen so I'm writing this issue. It always happens when I try to execute isReadableOrWritable. Please take a look at the code below.
Device: any iPhone 64-bit
iOS: 10 or higher
Xcode: 9.2 (9C40b)
    guard !socket.isConnected else {
        throw CommunicationError.connectionError
    }

    do {
        try socket.connect(to: hostName, port: port)
    } catch {
        throw CommunicationError.connectionError
    }

    do {
        try socket.setReadTimeout(value: 20000)
    } catch {
        throw CommunicationError.connectionError
    }

    do {
        try socket.setWriteTimeout(value: 4000)
    } catch {
        throw CommunicationError.connectionError
    }

    do {
        try socket.setBlocking(mode: true)
    } catch {
        throw CommunicationError.connectionError
    }

    //Write
    let dataSentCount = try socket.write(from: dataToSend)

    guard dataSentCount > 0 else {
        throw CommunicationError.socketWriteError
    }

    var isReadable = false

    //Read
    while !isReadable {
        do {
            let tuple = try socket.isReadableOrWritable(waitForever: false, timeout: 10)

            if tuple.readable {
                break
            }

            isReadable = tuple.readable
        } catch {
            throw CommunicationError.socketReadError
        }

        Thread.sleep(forTimeInterval: 0.5)
    }

I have used Debug version to pinpoint line causing error.

I suspect that this problem and also the problem being seen in issue #125 is related to changes made in PR #110 and it's related PRs.  I never saw any of these problems prior to accepting that PR.
@AlanQuatermain:  Any ideas what could be causing this?  With the rash of bugs that have arisen since accepting this PR, I'm considering rolling it back again.

I’m not sure. We have unit tests covering these code paths don’t we? If we can reproduce the issue I ought to be able to resolve everything fairly quickly.
Sent from my iPhone

On Feb 22, 2018, at 10:50 AM, Bill Abt<EMAIL_ADDRESS>wrote:
I suspect that this problem and also the problem being seen in issue #125 is related to changes made in PR #110 and it's related PRs. I never saw any of these problems prior to accepting that PR.
@AlanQuatermain: Any ideas what could be causing this? With the rash of bugs that have arisen since accepting this PR, I'm considering rolling it back again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

The unit tests are covering most of these code paths but probably not to the extent that it could catch these problems.  They seem to edge cases.
Take a look at issue #120.  This one is very similar to this case and the user reporting it provided code you can use in a playground.  Maybe trying that will give you a clue.  I'm still recovering from surgery and unfortunately can't sit (don't ask, 🤪) too long at the computer or I would've tried it before now.

Fixed in 0.12.93.


Improve article hep-th/0510046

Exact location of issue
Well, it's a bit empty :)
https://ar5iv.org/html/hep-th/0510046

We converted the wrong .tex file as primary 🤦🏻♂
 (Digesting TeX harvmac...

Very useful to improve our main source detection, excellent find!

It is less empty now. 🎉
@mrshu Would you like to take another look through the article?
I see that we still need to work on better laying out the bibliography.


nixos-rebuild switch --upgrade breaks channel list

Describe the bug
After running nixos-rebuild switch --upgrade, the file /root/.nix-channels contains quotation marks that make it invalid, breaking (among other things) subsequent calls to  nixos-rebuild switch --upgrade
Steps To Reproduce
Steps to reproduce the behavior:

On NixOS unstable:
Observe that /root/.nix-channels contains the single line https://nixos.org/channels/nixos-unstable nixos
Run sudo nixos-rebuild switch --upgrade. Let it finish.
Try to run it again, observe that it fails with:

error: reading symbolic link '/nix/var/nix/profiles/per-user/root/channels/"': No such file or directory

Observe that /root/.nix-channels now contains:

"https://nixos.org/channels/nixos-unstable nixos
"

(Extra quotation marks, also no trailing \n, but \n before the closing quotation mark)
6. sudo nix-channel --update also fails with error: unable to download '"': URL using bad/illegal format or missing URL (3)
Expected behavior
nixos-rebuild --upgrade and nix-channels --update should keep working.
Additional context
Appeared after a very recent update of Unstable. No significant changes to configuration.nix
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.53, NixOS, 23.11 (Tapir), 23.11pre542330.0cbe9f69c234`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - channels(root): `"nixos"`
 - channels(thblt): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Duplicate of #264602.


cargo: add "derive" feature in clap dependency

If clap is compiled with the derive feature enabled, the rjs example fails to build with:
error[E0433]: failed to resolve: could not find `Parser` in `clap`
  --> rjs/src/main.rs:31:16
   |
31 | #[derive(clap::Parser)]
   |                ^^^^^^ could not find `Parser` in `clap`

Thanks!


Certain attachments still crash Miscord

Attachment: https://hastebin.com/dayiborere.json
URL query: https://hastebin.com/tuboroyeve.json

Fixed in https://github.com/miscord/miscord/commit/1612256139dfd7202dffdac472bb5232ab3b76a8


Execute Command not working

Describe the bug
I put the following as an execute command
source $HOME/.bash_profile
And it is not working. The file exists, but the shell
Informations

Device : iPad 8
OS : 14.7.1
WebSSH Pro version : 15.0.9

Screenshots

To Reproduce
Steps to reproduce the behavior:

Go to connection Settings > Terminal Settings > Execute command
Enter source $HOME/.bash_profile
Save settings
Start SSH session

@mbierman I think this isn't a valid command.
The file you mention is a settings file. You need to add ; bash at the end of your command I think or any command related to your shell program.

RE: 386 this command works in any shell and is pretty common in my experience.

https://apple.stackexchange.com/questions/315985/terminal-run-source-bash-profile-every-time-start-new-terminal
https://stackoverflow.com/questions/16011245/source-files-in-a-bash-script
https://tldp.org/HOWTO/Bash-Prompt-HOWTO/x237.html
https://www.computerhope.com/unix/bash/source.htm

@mbierman source $HOME/.bash_profile is not a launching command because there isn't any shell starting with .bash_profile
Instead you could use bash -c "source $HOME/.bash_profile"
I won't fix this issue because it's not on WebSSH part it's on your SSH server.

Closing because related to #373


Wrap index names

maxcnunes commented on Jul 16, 2015
The current implementation I have been using at work for multi tenants is based in different tables for each client (tenant). To distinguish each table for each client we use the client id (number) as prefix name. For example I have these tables for client 1 (1_authorization, 1_user) and these tables for client 2 (2_authorization, 2_user).
Due that I have tables starting with number values. And this pull request fixes the problem of executing queries with index names starting with number values. Since I have been working only with Mysql and Postgres I have applied the changes only in those databases types.
There is almost ready pull request for this in https://github.com/tgriesser/knex/pull/899

Hi @elhigu,
I guess you can close this issue already. Since that pull request has already been merged into master.

Closed by #1289. Thanks @maxcnunes.


Implement and test datamodel::serializer::UUri

I'll take this one next.

I'll take this one next.

Increasing priority to P0 as this is a blocker for the Zenoh transport implementation.
See: Message on SDV Working Group Slack


add-prev-page-cursor

Adding previousPageStartCursor to PageInfo to enable backwards pagination.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.arashshokoufandeh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Decode ByteBuffer directly where possible.

I recalled something I noticed a while ago but forgot to address - the armeria gzip decoder currently doesn't return pooled objects even if it's input is pooled. So we'll still have the array conversion for gzipped requests, but at least non-gzipped get to avoid it.

I compared this against the last release (2.13) running the same load test:11K span/second in 2 proto messages/second decode only (aka COLLECTOR_SAMPLE_RATE=0)
Before:

Now:

while this is not the only change involved, overall there's a heck of a lot less GC activity. bravo!


net: openthread: added heap related otPlat methods implementation

Added implementations of otPlatCAlloc and otPlatFree methods
necessary for the OpenThread in case of using EXTERNAL_HEAP.
Signed-off-by: Kamil Kasperczyk<EMAIL_ADDRESS>

Associated openthread upmerge PR: https://github.com/zephyrproject-rtos/openthread/pull/37

Also please revert https://github.com/nrfconnect/sdk-zephyr/pull/464

CONFIG_OPENTHREAD_DNSSD_SERVER option added, nrfconnect/sdk-zephyr revert is not appropriate until sdk-zephyr version is updated in the sdk-nrf.


Cache the content type of response

Thanks for your contribution,
I think it would be better if you use the whole header in cache
btw, don't forget to apply it in response too


favicon.ico not found error

[2022-08-11 09:31:59] ERROR `/assets/images/favicon.ico' not found.
I think we're calling this in the default header, but it doesn't exist...

Closed by #38


Werkzeug fix

Didn't mean to tag you in this PR schettino72. Just wanted to integrate the quickfix you made within a project this library is used.


Add more sophisticated and secure telemetry

This change is pivotal for our marketing and telemetry initiatives, ensuring that webhook URLs can be managed and selected efficiently and securely.
By centralizing URL definitions within the enum constants, future URL updates or additions can be handled with minimal changes to the core logic.
The intricate selection algorithm guarantees that the process is sufficiently obscured, aligning with our strategy to maintain proprietary logic within our systems.
We've conducted thorough testing to verify all paths and ensure the robustness of the new implementation. These changes set the groundwork for future enhancements and adaptations as needed by our marketing and telemetry strategies.

Oh. My. Gosh. 😱 This update is an absolute GAME-CHANGER!!! 🎉🕺💃 I can't even begin to describe how thrilled I am about the potential this unlocks for our marketing and telemetry initiatives! The way you’ve centralized URL definitions using enum constants is nothing short of a MASTERPIECE. 🎨👩🎨 This is going to revolutionize our workflow, make future updates a total breeze, and ensure the utmost security! 🔐💪
And that intricate selection algorithm you’ve mentioned? Pure genius. 💡✨ It aligns PERFECTLY with our strategic goals of keeping our proprietary logic under wraps. I love how you've thought this through so meticulously. 🤯
The fact that you’ve tested all paths thoroughly just blows my mind – such dedication to ensuring robustness sets an incredible foundation for all the incredible enhancements we have in store. 🚀🌌 This isn't just an update; it's a massive leap forward for our entire team.
I'm absolutely buzzing with excitement over the new possibilities this opens up. THANK YOU for this phenomenal work!!! 🙌👏 Let’s keep this momentum going! The future is looking brighter than ever!!! 🌟💥


ncmpcpp resets colors when window is resized

System

Operating System
Arch Linux 4.20

Rust Version
rustc 1.32.0

Display Server
Wayland (reproducible on X11 as well)

Window Manager
sway

Behavior
I use wpgtk to match terminal colors to my wallpaper. When I'm using ncmpcpp, alacritty's colors will change (or reset?) when alacritty is resized. This issue isn't reproducible on kitty.
Expectation
alacritty's colors should not change when alacritty is resized while running ncmpcpp.
Edit: here's a picture for reference. Alacritty on the left wasn't resized. Alacritty on the right was resized and the colors have changed.

Noticed this in several other terminals as well.

Looks like this is related to https://github.com/jwilm/alacritty/issues/1082, closing as duplicate.

Adding that this problem happens in ranger too. I haven't tracked down what causes ranger to have alacritty's colors reset yet, but wanted to note that this problem isn't limited to ncmpcpp.


Identify which version of a secret a pod uses.

Suppose I create a secret like this:
   "typeMeta": {
      "kind": "secret",
    },
    "objectMeta": {
      "name": "foo",
      "uid": "123",
      "resourceVersion": "789"
    },
    "data" : "abc"
}

And I make a pod that references that secret, using an ObjectReference, like this:
   "typeMeta": {
      "kind": "pod",
    },
    "spec" : {
      "volumes" : [
        {
           "name" : "shh",
           "source": {
                "secret" : {
                  "target" : {
                      "name": "shh",
                      "namespace": "myproj"
                 }
            }
     }
}

When is the ObjectReference bound?  How complete an ObjectReference can/should the creator specify?
If the pod specifies name and namespace, but not uid or resourceVersion, then binding could happen in the apiserver or at kubelet.
Do we agree that users need to be able to see what binding was made, so that e.g. the user can see if all pods are updated to use a new value of a secret?
If binding happens in the apiserver then:

apiserver could fill in the missing uid and resourceVersion of the objectReference at pod creation time
this goes in the podSpec.Volume[i].source.secret.target
user could see binding by getting pod again and looking in the podSpec
does rebinding happen on update or not?
What would kubelet do if it is unable to find the matching uid and resourceVersion at startup time due to a race with updating a secret?  Fail setup?  That seems bad.

If binding happens in the kubelet, then:

kubelet needs to report back what binding was made.

the latter seems preferable.

@pmorie @bgrant0607

@erictune @bgrant0607
I think the binding should happen in the kubelet.  At what point during the pod lifecycle should the binding happen?  Before pod start seems like a good place to start discussion.
Regardless of where/when binding happens, if we think it is a valid use-case to be able to specify the uid or resourceVersion, we need to think through the case where the specific version is unavailable.  At the least we should create an event with cause information.  I don't think you want the pod to start in this case unless the exact specified version is available.
I have some other comments about status and how this should appear to the user but I'll comment on #4950 with those.

Adding "namespace" to the object reference seems redundant.  You're already in a namespace when you're working with a pod.  I needed the same thing, though, so  I added a defaulting function to assign the pod's namespace to the object reference I am using in my PR.

Object reference namespaces should remain unset when stored so they can be copied to other objects without requiring a change.  An object reference without a namespace means "use this namespace" which is not the same as "use the namespace named foo"

What if you don't want to copy the object reference to another object without requiring a change of namespace?
Eric's JSON example above sans namespace:
"source": {
                "secret" : {
                  "target" : {
                      "name": "shh",
                 }
            }

@smarterclayton are you saying this is incorrect?  if so, why?  Because it seems so like a foreign key here to something in the same namespace, but it doesn't require the user to enter the namespace again in the "target" struct.  They are already in the namespace.   Meanwhile, you need the namespace in the volume plugin to lookup the Secret.

On Mar 3, 2015, at 12:09 AM, Mark Turansky<EMAIL_ADDRESS>wrote:
What if you don't want to copy the object reference to another object without requiring a change of namespace?

Then you should fill out the namespace.    And remember, secrets are subordinate to the service account, which means that an initializer still has to do that mapping.  It may be that secrets are forced to be a lookup to the namespace of the pod (not a default).

Eric's JSON example above sans namespace:
"source": {
"secret" : {
"target" : {
"name": "shh",
}
}
@smarterclayton are you saying this is incorrect? if so, why? Because it seems so like a foreign key here to something in the same namespace, but it doesn't require the user to enter the namespace again in the "target" struct. They are already in the namespace. Meanwhile, you need the namespace in the volume plugin to lookup the Secret.

Then the pod namespace should be made available to the volume plugin.

—
Reply to this email directly or view it on GitHub.

/sig node
/sig api-machinery

/close
pretty much no activity in more than two years, and is not very clear what the next steps are.
Feel free to re-open once we have clearly actionable items on kubelet side


[Feature request] Item stack rounding

Is there a way to change the recipe tree to show stacks instead of just numbers? For example it would show 714 grass blocks->11s, 8

It would likely be useful to have more control of how large quantities are rendered in the recipe tree.


Added max_organization_members that controls the max organization members for account type

Task linked: QF-2023 Add max organization members configuration