Dynamic routes not generated

Details
Hi, I'm assuming I'm doing something wrong, but I'm not sure what haha. I'm trying to generate a sitemap for dynamic routes. As in, the sitemap that is generated does not match what is defined in the sitemap-urls.
// server/api/_sitemap-urls.ts

import { getArticlePaths, getCareerPaths } from '~/router/routeGeneration';

export default defineEventHandler(async () => {
  const articlePaths = getArticlePaths();
  const careerPaths = await getCareerPaths();

  return [...articlePaths, ...careerPaths].map((p) => {
    return { loc: p, lastmod: new Date() };
  });
});

generated sitemap:
[{"loc":"/science"},{"loc":"/premium"},{"loc":"/philosophy"},{"loc":"/about"},{"loc":"/"},{"loc":"/articles/30-no-career-direction"},{"loc":"/articles"},{"loc":"/careers"},{"loc":"/articles/bad-reasons-to-quit-your-job"},{"loc":"/articles/advice-for-young-people"},{"loc":"/articles/am-i-getting-fired"},{"loc":"/articles/career-advice"},{"loc":"/articles/avoid-burnout"},{"loc":"/articles/best-career-advice-explore-exploit"},{"loc":"/articles/career-aptitude"},{"loc":"/articles/career-change"},{"loc":"/articles/career-change-40-no-degree"},{"loc":"/articles/career-change-for-teachers"},{"loc":"/articles/career-change-40"},{"loc":"/articles/career-change-impact-on-salary"},{"loc":"/articles/career-change-50-no-degree"},{"loc":"/articles/career-landscape"},{"loc":"/articles/career-change-quiz"},{"loc":"/articles/career-quiz"},{"loc":"/articles/disc-personality-type-c"},{"loc":"/articles/do-the-job-you-want-to-do"},{"loc":"/articles/dont-know-what-career-i-want"},{"loc":"/articles/fear-of-changing-careers"},{"loc":"/articles/do-what-you-love"},{"loc":"/articles/finding-your-passion"},{"loc":"/articles/enfp-personality-type"},{"loc":"/articles/hardest-majors-in-college"},{"loc":"/articles/hate-job-so-much-anxiety"},{"loc":"/articles/how-to-find-a-career-you-love"},{"loc":"/articles/how-to-be-productive-in-life"},{"loc":"/articles/how-to-make-a-career-choice"},{"loc":"/articles/how-to-get-things-done"},{"loc":"/articles/how-to-succeed-compound-yourself"},{"loc":"/articles/i-dont-want-to-go-to-work"},{"loc":"/articles/i-feel-like-quitting-my-job-everyday"},{"loc":"/articles/how-you-can-work-hard"},{"loc":"/articles/i-feel-stuck-in-my-job"},{"loc":"/articles/i-hate-my-job-100-reasons"},{"loc":"/articles/i-hate-my-job-but-cant-afford-to-quit"},{"loc":"/articles/i-hate-my-job"},{"loc":"/articles/i-hate-my-job-but-i-cant-quit"},{"loc":"/articles/i-hate-working"},{"loc":"/articles/i-hate-working-so-much"},{"loc":"/articles/i-quit-my-job-and-ruined-my-life"},{"loc":"/articles/i-hate-my-job-but-it-pays-well"},{"loc":"/articles/interest-trumps-discipline"},{"loc":"/articles/job-doesnt-align-with-your-values"},{"loc":"/articles/mindfulness-not-flow"},{"loc":"/articles/mixed-feelings-of-quitting-your-job"},{"loc":"/articles/most-regretted-college-majors"},{"loc":"/articles/myers-briggs-type-to-advance-career"},{"loc":"/articles/my-job-makes-me-miserable"},{"loc":"/articles/my-job-is-making-me-depressed"},{"loc":"/articles/myers-briggs-vs-big5"},{"loc":"/articles/myers-briggs-vs-enneagram"},{"loc":"/articles/myers-briggs"},{"loc":"/articles/no-passion-for-anything"},{"loc":"/articles/no-career-interests-me"},{"loc":"/articles/personality-career-test"},{"loc":"/articles/personality"},{"loc":"/articles/pursue-a-career"},{"loc":"/articles/quiet-quitting"},{"loc":"/articles/personality-types-at-the-workplace"},{"loc":"/articles/quit-job-without-another"},{"loc":"/articles/seven-signs-you-are-in-the-wrong-career"},{"loc":"/articles/signs-you-getting-laid-off"},{"loc":"/articles/risk-of-quitting-job"},{"loc":"/articles/signs-you-hate-your-job"},{"loc":"/articles/top-ten-high-demand-careers"},{"loc":"/articles/specialists-vs-generalists"},{"loc":"/articles/toxic-productivity"},{"loc":"/articles/twenty-five-and-dont-know-what-career-i-want"},{"loc":"/articles/value-professional-success"},{"loc":"/articles/unhappy-at-work-take-our-quiz"},{"loc":"/articles/web-of-knowledge"},{"loc":"/articles/what-drives-you"},{"loc":"/articles/what-should-i-do-with-my-life-quiz"},{"loc":"/articles/what-should-i-do-with-my-life"},{"loc":"/articles/what-is-a-vocation"},{"loc":"/articles/what-to-do-with-my-life"},{"loc":"/articles/what-should-i-major-in"},{"loc":"/articles/why-great-work-sucks"},{"loc":"/articles/work-life-balance"},{"loc":"/articles/workplace-personality-test"}]

there's no lastmod in the resulting sitemap and all the routes from the await getCareerPaths() are not there (there should be about 900 routes starting with /careers). I must be missing something.
I have no additional specific settings for sitemap in my nuxtconfig. I've tried putting this generation in sitemap.urls directly, but no dice.
Any tips would be appreciated
versions
<EMAIL_ADDRESS>with Nitro 2.6.3
<EMAIL_ADDRESS>

Same here

same question

I switched to the latest version of the plugin in my production project and the dynamic links disappeared. Guys, please save me.

I ended up using nuxt/content:
https://content.nuxt.com/recipes/sitemap & https://github.com/benoitdemaegdt/nuxt3-sitemap
That is make an api/routes/sitemap.xml.ts and put the content from benoitdemaegdt/nuxt3-sitemap in there.
I adjusted it slightly to patch my needs, but that seems to do the trick for me, hope that helps.

I ended up using nuxt/content:
https://content.nuxt.com/recipes/sitemap & https://github.com/benoitdemaegdt/nuxt3-sitemap
That is: make an api/routes/sitemap.xml.ts and put the content from benoitdemaegdt/nuxt3-sitemap in there.
I adjusted it slightly to match my needs, but that seems to do the trick for me, hope that helps.

I have error in string import { serverQueryContent } from '#content/server'

I ended up using nuxt/content:
https://content.nuxt.com/recipes/sitemap & https://github.com/benoitdemaegdt/nuxt3-sitemap
That is: make an api/routes/sitemap.xml.ts and put the content from benoitdemaegdt/nuxt3-sitemap in there.
I adjusted it slightly to match my needs, but that seems to do the trick for me, hope that helps.

is there any config in sitemap.xml.ts that could return all my sitemap if i do not use nuxt content ?

В итоге я использовал nuxt/content:
https://content.nuxt.com/recipes/sitemap и https://github.com/benoitdemaegdt/nuxt3-sitemap
То есть: сделайте и поместите оттуда api/routes/sitemap.xml.tsконтент .benoitdemaegdt/nuxt3-sitemap
Я немного скорректировал его в соответствии со своими потребностями, но, похоже, мне это помогло, надеюсь, это поможет.

In dev working but i build my project i have error
Failed to parse URL from sitemap.xml                                                                                18:38:31
at Object.fetch (node:internal/deps/undici/undici:11457:11)

I ended up using nuxt/content:
https://content.nuxt.com/recipes/sitemap & https://github.com/benoitdemaegdt/nuxt3-sitemap
That is: make an api/routes/sitemap.xml.ts and put the content from benoitdemaegdt/nuxt3-sitemap in there.
I adjusted it slightly to match my needs, but that seems to do the trick for me, hope that helps.

is there any config in sitemap.xml.ts that could return all my sitemap if i do not use nuxt content ?

You can treat the event handler as a normal nuxt server API, so you can use fs and async/await to generate all your routes

Sorry i write in my nuxt.config
nitro: {
prerender: {
routes: ['/sitemap.xml']
}
}
When i delete my project build)

Bottom line: I used another library for a working project
My steps:

npm uninstall nuxt-simple-sitemap
npm install sitemap
Create dicretory server/routes
Create file sitemap.xml.ts
Add this code in file:
`
import {SitemapStream, streamToPromise} from 'sitemap'

export default defineEventHandler(async (event) => {
// Fetch all documents
const sitemap = new SitemapStream({
hostname: 'YOUR URL'
})
      // The <changefreq> tag tells search engines how often you expect a page on your site to change. This can help them
      //decide how frequently to crawl the page. The possible values for this tag are "always," "hourly," "daily," "weekly,"
      //"monthly," "yearly," and "never."
sitemap.write({
        url: 'LINK',
        changefreq: 'daily',
        lastmod: 'DATE'
    })

//end
sitemap.end()

//return
return streamToPromise(sitemap)
})
`

Bottom line: I used another library for a working project
My steps:

npm uninstall nuxt-simple-sitemap
npm install sitemap
Create dicretory server/routes
Create file sitemap.xml.ts
Add this code in file:
import {SitemapStream, streamToPromise} from 'sitemap'

`export default defineEventHandler(async (event) => { // Fetch all documents const sitemap = new SitemapStream({ hostname: 'YOUR URL' })
      // The <changefreq> tag tells search engines how often you expect a page on your site to change. This can help them
      //decide how frequently to crawl the page. The possible values for this tag are "always," "hourly," "daily," "weekly,"
      //"monthly," "yearly," and "never."
sitemap.write({
        url: 'LINK',
        changefreq: 'daily',
        lastmod: 'DATE'
    })

//end
sitemap.end()

//return return streamToPromise(sitemap) })`

Yep, that's exactly what I ended up doing, thanks!

@GoudekettingRM Thanks bro, you saved my day from the customer

@palachX Can i have your full code of sitemap.xml.ts ?

@GoudekettingRM It seems to me that you closed the issue early, nuxt-simple-sitemap really isn't working as it should right now.

@palachX , yeah, you're correct, I'll reopen, but since I have my sitemap working, I don't really care anymore 🙊

@GoudekettingRM
Everything works fine, but the error was because I wrote the code below in the nuxt config.:
nitro: {
    prerender: {
                routes: ['/sitemap.xml']
       }
}

My application works via ssr so there is no need for pre-rendering

@GoudekettingRM Everything works fine, but the error was because I wrote the code below in the nuxt config.:
nitro: {
    prerender: {
                routes: ['/sitemap.xml']
       }
}

My application works via ssr so there is no need for pre-rendering. but the error has occurred before without using $fetch

@palachX interesting, I have the sitemap.xml in my nitro prerender routes and it works without any issues

this one works for me but it's only return 1 url, still finding ways to get all routes
import { serverQueryContent } from '#content/server'
import { SitemapStream, streamToPromise } from 'sitemap'
export default defineEventHandler(async (event) => {
// Fetch all documents
const docs = await serverQueryContent(event).find()
const sitemap = new SitemapStream({
hostname: 'http://localhost:3000'
})
for (const doc of docs) {
sitemap.write({
url: doc._path,
changefreq: 'monthly'
})
}
sitemap.end()
return streamToPromise(sitemap)
})

this one works for me but it's only return 1 url, still finding ways to get all routes
import { serverQueryContent } from '#content/server' import { SitemapStream, streamToPromise } from 'sitemap'
export default defineEventHandler(async (event) => { // Fetch all documents const docs = await serverQueryContent(event).find() const sitemap = new SitemapStream({ hostname: 'http://localhost:3000' })
for (const doc of docs) { sitemap.write({ url: doc._path, changefreq: 'monthly' }) } sitemap.end()
return streamToPromise(sitemap) })

If you format your code in triple backticks, it's easier to read. Did you check what the value of docs is?

Any updates on this issue? it can't seem to find _sitemap-urls.ts or just flat out ignores it..

Here is a workaround...use the hook sitemap:resolved et totally rewrite the sitemap...
hooks: {
  async 'sitemap:resolved'(ctx) {
    const urls = await urlsToGenerate();
    ctx.urls = urls.map(page => ({
       loc: page.slug,
       lastmod: page.modified
       changefreq: 'daily',
       priority: 0.8,
     }));
  }
}

In my case all logic for generating urls happens in urlsToGenerate as it only ouput what i need to put in the sitemap...

This does nothing.
On Fri, 10 Nov 2023 at 00:50, Khelil @.***> wrote:

Here is a workaround...use the hook sitemap:resolved
https://nuxtseo.com/sitemap/api/nuxt-hooks et totally rewrite the
sitemap...
hooks: {
async 'sitemap:resolved'(ctx) {
const urls = await urlsToGenerate();
ctx.urls = urls.map(page => ({
loc: page.slug,
lastmod: page.modified
changefreq: 'daily',
priority: 0.8,
}));
}
}
In my case all logic for generating urls happens in urlsToGenerate as it
only ouput what i need to put in the sitemap...
—
Reply to this email directly, view it on GitHub
https://github.com/harlan-zw/nuxt-simple-sitemap/issues/150#issuecomment-1804855605,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENTTE2ULHQSQKAOUQ6XJO3YDVT3JAVCNFSM6AAAAAA6AC2OV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUHA2TKNRQGU
.
You are receiving this because you commented.Message ID:
@.***>

Where did you add this code? I added the hook in
server/api/_sitemap-urls.ts but I get:
[nuxt] [request error] [unhandled] [500] Cannot access '_sitemapUrls$1'
before initialization
at  @.***/image/dist/runtime/ipx.mjs:22:3)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
at async Object.handler (./node_modules/h3/dist/index.mjs:1630:19)
at async toNodeHandle (./node_modules/h3/dist/index.mjs:1840:7)
at async ufetch (./node_modules/unenv/runtime/fetch/index.mjs:9:17)
at async $fetchRaw2
(./node_modules/ofetch/dist/shared/ofetch.00501375.mjs:219:26)
at async $fetch2
(./node_modules/ofetch/dist/shared/ofetch.00501375.mjs:261:15)
at async Promise.all (index 0)
at resolveAsyncDataSources
(./node_modules/nuxt-simple-sitemap/dist/runtime/sitemap/entries/sources.mjs:111:3)
at buildSitemap
(./node_modules/nuxt-simple-sitemap/dist/runtime/sitemap/builder/sitemap.mjs:5:19)
[nuxt] [request error] [unhandled] [500] Cannot access '_sitemapUrls$1'
before initialization
at  @.***/image/dist/runtime/ipx.mjs:22:3)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
at async Object.handler (./node_modules/h3/dist/index.mjs:1630:19)
at async toNodeHandle (./node_modules/h3/dist/index.mjs:1840:7)
at async ufetch (./node_modules/unenv/runtime/fetch/index.mjs:9:17)
at async $fetchRaw2
(./node_modules/ofetch/dist/shared/ofetch.00501375.mjs:219:26)
at async $fetch2
(./node_modules/ofetch/dist/shared/ofetch.00501375.mjs:261:15)
at async Promise.all (index 0)
at resolveAsyncDataSources
(./node_modules/nuxt-simple-sitemap/dist/runtime/sitemap/entries/sources.mjs:111:3)
at buildSitemap
(./node_modules/nuxt-simple-sitemap/dist/runtime/sitemap/builder/sitemap.mjs:5:19)
[nuxt] [request error] [unhandled] [500] Cannot access 'renderer$1' before
initialization
at  @.***/image/dist/runtime/ipx.mjs:22:3)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
at async Object.handler (./node_modules/h3/dist/index.mjs:1630:19)
at async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:1840:7)
On Fri, 10 Nov 2023 at 22:32, Niki Stohler @.***> wrote:

This does nothing.
On Fri, 10 Nov 2023 at 00:50, Khelil @.***> wrote:

Here is a workaround...use the hook sitemap:resolved
https://nuxtseo.com/sitemap/api/nuxt-hooks et totally rewrite the
sitemap...
hooks: {
async 'sitemap:resolved'(ctx) {
const urls = await urlsToGenerate();
ctx.urls = urls.map(page => ({
loc: page.slug,
lastmod: page.modified
changefreq: 'daily',
priority: 0.8,
}));
}
}
In my case all logic for generating urls happens in urlsToGenerate as it
only ouput what i need to put in the sitemap...
—
Reply to this email directly, view it on GitHub
https://github.com/harlan-zw/nuxt-simple-sitemap/issues/150#issuecomment-1804855605,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENTTE2ULHQSQKAOUQ6XJO3YDVT3JAVCNFSM6AAAAAA6AC2OV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUHA2TKNRQGU
.
You are receiving this because you commented.Message ID:
@.***>

I think overall there are a number of different issues in this thread. I'm going to close it with the release of v4.
If you had issues previously, please try v4 and read through the updated documentation. If you still are having problems, make a new issue and I'll help you out :)


bug: CVE-2022-37734 in graphql-dgs-extended-scalars v5.3.0

Expected behavior
graphql-dgs-extended-scalars should be upgraded to use com.graphql-java:graphql-java v19.0 or above to fix CVE-2022-37734
Actual behavior
graphql-dgs-extended-scalars v5.3.0 (latest release) is using com.graphql-java:graphql-java v18.3 which contains the vulnerability
Steps to reproduce
Include graphql-dgs-extended-scalars v5.3.0 as a dependency and run a trivy scan or similar

We just merged a PR pulling in the latest version of the extended scalars that used graphql-java v19.0. This is pending release, likely available early next week.

v5.4.0 is now available


Add all changed for csv enabled

fixes #469

This is a huge speed up if csv is not enabled. This entire green block doesn't get called.

Better version of #467

I have this fixed in https://github.com/JakeRoggenbuck/auto-clock-speed/pull/461. If we merge now it will cause conflicts. Sorry, I didn't realize yesterday.

I have this fixed in #461. If we merge now it will cause conflicts. Sorry, I didn't realize yesterday.

That's alright, I don't think it will cause because the area where we implement it only overlaps by a line but if you want to have the flag checked like this in your PR, that's alright by me.
We need to make sure that the flag gets checked before the function gets called.
if do_thing {
  thing();
}

and not something like this.
fn thing() {
  if !do_thing { return; }
}

thing();

The implementations are kinda different.

Fixed in #461


Validation messages not removed inside repeated groups

Description
Error message after validation on field inside repeating group is not removed.
To Reproduce
(Specific for our app)

Add new or edit an entry in a repeating group.
Trigger a validation error on a field that is validated depending on another field.
Address the validation error by changing the other field the validation is dependent upon.

Expected behavior
The validation error message is removed.
Screenshots

Additional info

The error-message is removed if i focus the field to remove the error as demonstrated in the GIF.
The dynamics causing the relevant field to hide and show seems to be irrelevant for the problem.
In this example its server-side validation that checks if the SSN is required or not. I have also tried setting the field to required in the layout and relying on the dynamic to remove and add the field, but this produces the same result.
Relevant slack discussion

I think this comment is also relevant to this issue: https://github.com/Altinn/app-frontend-react/issues/545#issuecomment-1280751207
The validation for fields shown when a question is answered is Yes, shows integer fields that are required (set as standard rule in Altinn Studio). If I answer No, the integer fields still validate even though the row is hidden by a filter. It seems to me that the problem might come from the fact that the field probably exists even if it is hidden.

@olemartinorg Is this fixed by https://github.com/Altinn/app-frontend-react/pull/627?

Should be, yes! :partying_face: Seems like #617 was a duplicate issue, sadly. @JohanGuntherKrogevoll, do you mind testing this? Assuming #617 was a duplicate, so let us know if closing this was a mistake.


fix: use the current scope

Use the current Sentry scope instead of creating a new one.

I apologise, I want to do some more research about this change


Bump tracing-tracy and tracing-subscriber to latest in simple example

Did not work anymore with latest tracy binaries

Happy to merge this, but please run cargo fmt so that CI will pass. The other CI issues should be addressed now. Thanks!


System XAML issue: ContentDialog not blocking keyboard interactions

Describe the bug
With ContentDialog open, user can use keyboard shortcut (either AccessKey or KeyDown event) to trigger UI behind the dialog box.
Steps to reproduce the bug

Create a button with AccessKey = "C" that does something
Open ContentDialog with ShowAsync()
With ContentDialog still open, press ALT then C
Observe that Button click event fires

Expected behavior
User cannot click a button while a modal ContentDialog is open
Screenshots

Version Info
This is happening in Microsoft.NETCore.UniversalWindowsPlatform v6.2.12
I was told to log it here as it is a system XAML issue
NuGet package version:
N/A

Windows 10 version
Saw the problem?

Windows 10 10.0.19042

Additional context
Sample project to demonstrate the issue is here: https://github.com/under3415/NavigationApp

@Austin-Lamb I'm not sure we have a way for modal popups to stop access keys from being invokable..


Weapon ESP Help

*Not an issue with the normal unmodified source
I've done something and now the weapon esp shows "#FIXME_LOCALIZATION_FAIL_MISSING_STRING"
If anyone could help me i'd really appreciate it

Probably your WeaponData struct is wrong or you're passing incorrect token to Localize::find.


Fix missing checkmark next to Total amount after paying request while offline

Details

WHen we pay a request, the code always mark it as partial payment even when there is no held request. The green checkmark will only show if it's a full payment, so this PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/39357
PROPOSAL: https://github.com/Expensify/App/issues/39357#issuecomment-2031100490
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: have another user request money to you

Open the IOU report of the request
Go offline
Pay the request
Verify a green checkmark is shown next to the money request total amount

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/201d30ec-7bbf-4a44-819c-429a59af137f

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/3fbbe3d3-7606-4d09-ae4b-8eace7bcec59

iOS: Native

https://github.com/Expensify/App/assets/50919443/09545083-b6ec-41b8-b344-a5a78ac39c68

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/a7cada1a-220e-4208-a216-9a96654f1c38

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/44d12af5-14ad-469d-9e01-766c353e853b

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/6860c400-2193-4e3c-a4c2-c7738d44db98

Will review it tomorrow

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59907218/38b3d807-11d1-492a-baa1-83256a196341

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/59907218/08070164-1b21-4b32-a903-cefeaff0ddb0

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59907218/6c7dec5b-d7ed-4859-8928-4a3bdb10e5ac

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/42008e0f-5df7-47d5-9574-ee81eaf7cd4e

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/85de4a17-762d-4b5e-8836-4e113bef3476

@bernhardoj could you try to merge main to fix performance tests please?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add a way to run rubocop-daemon, maybe with a new ruby.rubocop.command option

I just found the rubocop-daemon gem: https://github.com/fohte/rubocop-daemon
This starts a RuboCop process in the background and forks it whenever you run RuboCop. This provides a huge speed boost, and I really want to use this with the formatOnSave option in VS Code.
$ time rubocop app/models/user.rb
...
real	0m3.780s
user	0m2.604s
sys	0m0.841s

$ time rubocop-daemon exec app/models/user.rb
...
real	0m1.599s
user	0m1.170s
sys	0m0.384s

As well as ruby.rubocop.executePath, it would be nice to have ruby.rubocop.command.
I would like to set ruby.rubocop.command to: rubocop-daemon exec --

Wow, this is amazing!!! I created a rubocop-wrapper script in this PR, and created a symlink to it at /usr/local/bin/rubocop. Then I set ruby.rubocop.executePath to /usr/local/bin in VS Code. The difference is incredible, especially when using formatOnSave. Instead of waiting 5 seconds for the file to be saved and reformatted, now it only takes about 250ms.
I still think it would be nice if I could override the rubocop command, instead of needing to create a symlink. I would like to set something like: "ruby.rubocop.command": "/usr/local/bin/rubocop-daemon-wrapper"

This seems to be possible now by adding a symlink somewhere else. For example, create the following directory structure:
/test/rubocop-daemon-wrapper
/test/rubcop -> /test/rubocop-daemon-wrapper

  "ruby.rubocop.executePath": "/test/",


AutoRoute generator lack of support

I proxy the original issue here: https://github.com/Milad-Akarie/auto_route_library/issues/2052

Not a rearch issue (Not even related). Closing


CheckSupportSSE2: Fix sse flags unexpected propagation

Set function will affects all variables in current directory. If sse flags are added in CheckSupportSSE2.cmake, they will remain in Findminizip-ng.cmake which will cause liblzma cannot be detected. This patch keep CMAKE_REQUIRED_FLAGS being changed only in current file scope. This patch has been tested on riscv64.
Signed-off-by: Letu Ren<EMAIL_ADDRESS>This patch fixes build error on riscv64. Cmake output is listed below.
-- The CXX compiler identification is GNU 12.2.0
-- The C compiler identification is GNU 12.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Setting build type to 'Release' as none was specified.
-- Setting C++ version to '14' as none was specified.
-- Performing Test COMPILER_SUPPORTS_CXX14
-- Performing Test COMPILER_SUPPORTS_CXX14 - Success
-- Found OpenGL: /usr/lib/libOpenGL.so  found components: OpenGL
-- Found GLEW: /usr/include (found version "2.2.0")
-- Found GLUT: TRUE
-- GLVND supported
-- Performing Test HAVE_SSE2
-- Performing Test HAVE_SSE2 - Failed
-- Disabling SSE optimizations, as the target doesn't support them
-- Setting SOVERSION to '2.2' as none was specified.
-- Found expat: /usr/include (found suitable version "2.5.0", minimum required is "2.4.1")
-- Found yaml-cpp: /usr/lib/libyaml-cpp.so.0.7.0 (found suitable version "0.7.0", minimum required is "0.7.0")
-- Found pystring: /usr/include (Required is at least version "1.1.3")
-- Found Imath: /usr/lib/libImath-3_1.so.29.4.0 (found suitable version "3.1.5", minimum required is "3.0")
-- Found ZLIB: /usr/lib/libz.so (found version "1.2.13")
-- Found BZip2: /usr/lib/libbz2.so (found version "1.0.8")
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - not found
-- Looking for lzma_auto_decoder in /usr/lib/liblzma.so
-- Looking for lzma_auto_decoder in /usr/lib/liblzma.so - not found
-- Looking for lzma_easy_encoder in /usr/lib/liblzma.so
-- Looking for lzma_easy_encoder in /usr/lib/liblzma.so - not found
-- Looking for lzma_lzma_preset in /usr/lib/liblzma.so
-- Looking for lzma_lzma_preset in /usr/lib/liblzma.so - not found
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find LibLZMA (missing: LIBLZMA_HAS_AUTO_DECODER
  LIBLZMA_HAS_EASY_ENCODER LIBLZMA_HAS_LZMA_PRESET) (found version "5.2.7")
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindLibLZMA.cmake:89 (find_package_handle_standard_args)
  /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /usr/lib/cmake/minizip-ng/minizip-ng-config.cmake:39 (find_dependency)
  share/cmake/modules/Findminizip-ng.cmake:21 (find_package)
  share/cmake/modules/FindExtPackages.cmake:51 (find_package)
  CMakeLists.txt:261 (include)

-- Configuring incomplete, errors occurred!
See also "/build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeOutput.log".
See also "/build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeError.log".

CMakeError.log is listed below.
Performing C++ SOURCE FILE Test HAVE_SSE2 failed with the following output:
Change Dir: /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_7ec19 && [1/2] Building CXX object CMakeFiles/cmTC_7ec19.dir/src.cxx.o
FAILED: CMakeFiles/cmTC_7ec19.dir/src.cxx.o
/usr/bin/c++ -DHAVE_SSE2  -w -msse2 -std=c++14 -o CMakeFiles/cmTC_7ec19.dir/src.cxx.o -c /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp/src.cxx
c++: error: unrecognized command-line option ‘-msse2’
ninja: build stopped: subcommand failed.

Source file was:

    #include <emmintrin.h>
    int main ()
    {
        __m128d a, b;
        double vals[2] = {0};
        a = _mm_loadu_pd (vals);
        b = _mm_add_pd (a,a);
        _mm_storeu_pd (vals,b);
        return (0);
    }
Determining if the BZ2_bzCompressInit exist failed with the following output:
Change Dir: /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_24eb7 && [1/2] Building C object CMakeFiles/cmTC_24eb7.dir/CheckSymbolExists.c.o
FAILED: CMakeFiles/cmTC_24eb7.dir/CheckSymbolExists.c.o
/usr/bin/cc   -w -msse2 -o CMakeFiles/cmTC_24eb7.dir/CheckSymbolExists.c.o -c /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c
cc: error: unrecognized command-line option ‘-msse2’
ninja: build stopped: subcommand failed.

File /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:
/* */
#include <bzlib.h>

int main(int argc, char** argv)
{
  (void)argv;
#ifndef BZ2_bzCompressInit
  return ((int*)(&BZ2_bzCompressInit))[argc];
#else
  (void)argc;
  return 0;
#endif
}
Determining if the function lzma_auto_decoder exists in the /usr/lib/liblzma.so failed with the following output:
Change Dir: /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_7167f && [1/2] Building C object CMakeFiles/cmTC_7167f.dir/CheckFunctionExists.c.o
FAILED: CMakeFiles/cmTC_7167f.dir/CheckFunctionExists.c.o
/usr/bin/cc   -DCHECK_FUNCTION_EXISTS=lzma_auto_decoder -w -msse2 -o CMakeFiles/cmTC_7167f.dir/CheckFunctionExists.c.o -c /usr/share/cmake/Modules/CheckFunctionExists.c
cc: error: unrecognized command-line option ‘-msse2’
ninja: build stopped: subcommand failed.

Determining if the function lzma_easy_encoder exists in the /usr/lib/liblzma.so failed with the following output:
Change Dir: /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_d1708 && [1/2] Building C object CMakeFiles/cmTC_d1708.dir/CheckFunctionExists.c.o
FAILED: CMakeFiles/cmTC_d1708.dir/CheckFunctionExists.c.o
/usr/bin/cc   -DCHECK_FUNCTION_EXISTS=lzma_easy_encoder -w -msse2 -o CMakeFiles/cmTC_d1708.dir/CheckFunctionExists.c.o -c /usr/share/cmake/Modules/CheckFunctionExists.c
cc: error: unrecognized command-line option ‘-msse2’
ninja: build stopped: subcommand failed.

Determining if the function lzma_lzma_preset exists in the /usr/lib/liblzma.so failed with the following output:
Change Dir: /build/opencolorio/src/OpenColorIO-2.2.0/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_684ca && [1/2] Building C object CMakeFiles/cmTC_684ca.dir/CheckFunctionExists.c.o
FAILED: CMakeFiles/cmTC_684ca.dir/CheckFunctionExists.c.o
/usr/bin/cc   -DCHECK_FUNCTION_EXISTS=lzma_lzma_preset -w -msse2 -o CMakeFiles/cmTC_684ca.dir/CheckFunctionExists.c.o -c /usr/share/cmake/Modules/CheckFunctionExists.c
cc: error: unrecognized command-line option ‘-msse2’
ninja: build stopped: subcommand failed.

Good fix, thanks for the PR.


Support for Multiple Teams Accounts

It would be very useful, especially nowadays, to be able to login into more than one Microsoft Teams account instance in Station.
Also, each instance could have a small notification like icon (like the Google ones at the bottom right) to be immediately visible which account it is referring to.
As it is write now, you would need to logout of one account to be able to switch to another. I was thinking something along the lines of Firefox Multi-Account Containers if possible.

I started using Station only because I though this functionality was the sole purpose of the tool. I think this would be the killer feature if it gets done

I switched from Ferdium(it has multi account for teams app, but it started to freeze after latest update), and I'm also surprised that such a basic functionality isn't supported in Station app.


⚠ Bofrost.at has degraded performance

In f06d8b2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1316 ms

Resolved: Bofrost.at performance has improved in 85f09d0 after 30 minutes.


client calls should support subprocess options

There are use cases where defining stdout, stderr, stdin, etc. may be helpful for running clients via subprocess.  Allowing these to be run in renderapi.client.call_run_ws_client and called from client functions would facilitate code reuse.

I would also like this. The ingest output is overwhelming, and I would love to redirect it.

This is implemented in my fork and works such that something following the pattern
import os
import renderapi

with open(os.devnull, 'wb') as devnull:
    renderapi.client.import_tilespecs_parallel('MYSTACK', tilespecs, render=renderapi.connect(), stderr=devnull, stdout=devnull)

will send subprocess stdout and stderr to devnull and won't clutter up your stdout/stderr logging.  The other options can also be useful.

resolved in #71


Unable to move a user from SfB on-prem to Teams

Hi, I was unable to move only 1 user using Move-CSUser -Identity<EMAIL_ADDRESS>-Target sipfed.online.lync.com -MoveToTeams -BypassAudioConferencingCheck -BypassEnterpriseVoiceCheck A workaround I found was first move user to SfBO and then Teams... why does that happened if I verified all SfB 2015 CU8 requirements?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca38b93a-773e-3864-45b6-128dd3163f37
Version Independent ID: 7c32e933-94f2-196e-1163-3881df3aaf5a
Content: Move users from Skype for Business Server 2019 to Teams - Skype for Business Hybrid
Content Source: Skype/SfbHybrid/hybrid/move-users-from-on-premises-to-teams.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@SfBEngineer13 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


[Enhancement] Support ignore show external catalog privilege item in grantsTo system table

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 13 / 28 (46.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
13
28
46.43%
[142, 144, 145, 146, 147, 148, 149, 150, 151, 160, 161, 162, 187, 222, 223]

[FE PR Coverage Check]
:disappointed: fail : 13 / 28 (46.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
13
28
46.43%
[142, 144, 145, 146, 147, 148, 149, 150, 151, 160, 161, 162, 187, 222, 223]

[FE PR Coverage Check]
:disappointed: fail : 13 / 28 (46.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
13
28
46.43%
[142, 144, 145, 146, 147, 148, 149, 150, 151, 160, 161, 162, 187, 222, 223]

[FE PR Coverage Check]
:disappointed: fail : 13 / 33 (39.39%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
12
32
37.50%
[142, 145, 146, 147, 148, 149, 169, 171, 172, 173, 174, 175, 216, 218, 219, 220, 221, 222, 435, 487]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 28 / 33 (84.85%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
27
32
84.38%
[148, 174, 221, 435, 487]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

@mergifyio rebase

[FE PR Coverage Check]
:heart_eyes: pass : 28 / 33 (84.85%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
27
32
84.38%
[148, 174, 221, 435, 487]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 13 / 33 (39.39%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/system/sys/GrantsTo.java
12
32
37.50%
[142, 145, 146, 147, 148, 149, 169, 171, 172, 173, 174, 175, 216, 218, 219, 220, 221, 222, 435, 487]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Compile error esp_lcd_panel_io.h

ESP-IDF: 5.0.2
Micropython: Master (1.20)
Compilation terminated with following error:
/module/lcd/hal/esp32/esp32.c:10:10: fatal error: esp_lcd_panel_io.h: No such file or directory
   10 | #include "esp_lcd_panel_io.h"
      |          ^~~~~~~~~~~~~~~~~~~~

Turns out it has been mentioned in #4,
and now for the new Micropython version it's moved to /ports/esp32/esp32_common.cmake.
I suggest to update the documentation and add an important instruction to tell user for it.

Please refer to #4

Thanks, I'll update the docs later.


Paste with ctrl-v doesn't work properly

When doing a copy paste, the paste part on hyper only works if I right click + ctr-V. Only a ctr-v will never work.

Hyper 1.0.1
Electron 1.4.7
win32 x64 6.1.7601

Copy something (a text).  Try to paste using:

Ctrl+V => Doesn't work.
mouse right click => Doesn't work.
Menu - Edit - Paste => Works

** Note: There is a shortcut in Menu item for paste. And this shortcut doesn't work. (CTRL+V)

Hyper 1.0.1
Electron 1.4.7
win32 x64 10.0.14393

On Linux too, same behavior!

Yo @juicygoose @deyvisonrocha please test #1406 🙌

It's still no working =(


poetry dropped python 3.6 support from 1.2.0 version

poetry dropped python 3.6 support from 1.2.0 version (see https://github.com/python-poetry/poetry/releases/tag/1.2.0b1)
Now, in github main.yml workflow, pytest job with "Testing on python 3.6" breaks with an error. Error example - https://github.com/timeforplanb123/nornir_utils/actions/runs/3051796881/jobs/4925256514
What do you think about fixing the poetry version in main.yml? Example with fixed poetry version (1.1.15) - https://github.com/timeforplanb123/nornir_utils/actions/runs/3055010446/jobs/4927584794
Detailed from install-poetry action issues:

https://github.com/snok/install-poetry/issues/89
https://github.com/snok/install-poetry/pull/90

This issue has been resolved in #35, python 3.6 support has been removed from nornir_utils


Consider formatting partial files

GJF supports specifying specific lines (--lines) or offests (--offset) on a best-effort basis, which is helpful for partial commits in VCS. They even have a helpful python snippet to apply formats to changed lints from a diff (link). Would you consider supporting the same?
Their docs: https://github.com/google/google-java-format#from-the-command-line

Thanks for the suggestion! this looks like a duplicate of #218.


User Roles Bread builder

I'm having some difficulties grasping how would I add a field in /user/1/edit to add the relationship User - Roles, could you give me an example how I would achieve that?
Awesome package by the way !

From my understanding what @Melcus wish to achieve, is simply a method to assign a user a specific role within the "Edit User"/"Create User" formular.

Agreed.  There have a few discussions on how to implement relations.  I'm not aware of a consensus yet.

Relations have been added in v0.10


[Site] Implementing Chapters in the book

Signed-off-by: Kamal Nayan<EMAIL_ADDRESS>Description
Implementing Chapters in the book
This PR fixes #64
Notes for Reviewers
This is a WIP .
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit d9813807637b7ef9cb896fbdcfceb2c6964d5d81 at: https://63155a6b67cd5768aa0f776f--service-mesh-patterns.netlify.app

Marking the PR as draft, once completed you can update it


add support for custom element typeExtensions

In reference to https://github.com/ractivejs/ractive/issues/2043
This code change assumes the user will put a static string value for the "is" attribute. I don't think it makes sense to allow dynamic mustaches for "is", since the whole node would need to be deleted and a new node created with the different typeExtension. Maybe Attribute$init() could just print an error and treat a dynamic mustache as a static mustache to avoid that complication.
Note: this (https://github.com/ractivejs/ractive/blob/master/CONTRIBUTING.md#pull-requests) says to run grunt test, but when I try that I get "Fatal error: Unable to find Gruntfile."

Thanka! Seems reasonable to me.
We use the dev branch for dev, so that CONTRIBUTING is update to date with right build/test instructions: https://github.com/ractivejs/ractive/blob/dev/CONTRIBUTING.md
Also need to add a test, probably to elements. They're pretty easy-to-write API level tests.

I finally found some time to write the test code. Sorry for my inexperience, but I'm not sure how to run tests besides via npm run build (which in turn uses PhantomJS, but I'm not sure how to run that in a browser), and since only Chrome, Opera, and browsers polyfilled via webcomponents can register new elements, I can't really run this test. This is the test I wrote, but I haven't committed it, since I don't know how to really test it:
if ( 'registerElement' in document ) {
	test( '"is" attribute is handled correctly for custom elements (#2043)', t => {
        let XFoo = document.registerElement('x-foo', {
            prototype: Object.create(HTMLParagraphElement.prototype, {
                testMember: { value: true }
            }),
            extends: 'p'
        });
		let ractive = new Ractive({
			el: fixture,
			template: '

'
		});

		let p = ractive.find( 'p' );
		t.isTrue( 'testMember' in p );
	});
}

Build the project using the command gobble, which will create a server at localhost:4567. There you can navigate to the test folder, which will run the tests in the browser.

OK, thanks. I've committed the new test.

When I run "npm run build" on my computer, PhantomJS runs and all tests pass. Does anyone know what could be causing Travis CI build's PhantomJS to fail to run? This is what Travis CI's log shows:
PhantomJS timed out after 3000ms
Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file://scripts/phantom-runner.js. Domains, protocols and ports must match.

I only modified these three files, so I'm pretty sure it's not something I caused:
 src/utils/dom.js                                 | 19 ++++++++++++++-----
 src/virtualdom/items/Element/prototype/render.js |  5 +++--
 test/__tests/elements.js                         | 18 ++++++++++++++++++

@paulie4 I restarted Travis and it passed. Go figure :)

This is really cool – thanks @paulie4!


[fix]: Rarity validation in Submission flow

The type of this PR is: Bugfix
This PR resolves [SWA-249]
Description
This PR fixes the form validation in Artwork details step of submission flow. The bug is that when rarity field is selected as limited_edition, we should expect user to type in edition size and number before enabling the save button.
Videos
https://user-images.githubusercontent.com/42584148/155077812-a4ead876-08a0-4517-9cf4-cfe24915b462.mp4
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Dev changes
This feature is behind a feature flag, so the changes applicable only to developer for now.

This PR contains the following changes:

Dev changes (This feature is behind a feature flag, so the changes applicable only to developer for now.)

  Generated by :no_entry_sign: dangerJS against 539b495f435f5b219df2143472f21350ce8d4be3


external authorization adding data to body

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: external authorization adding data to body
Description:
Recently, we have been working on a decoupled access control mechanism for backend applications deployed on Kubernetes. Our solution is based on OPA and Envoy and the main goal is to fully decouple access control logic from beckend. This mechanism controls the access to resources on three different levels including action, resource and instance (ex. DB rows). Controlling access to actions and resources can be effectively done with Envoy external authorization paired with allow response from OPA but in order to control access to DB rows, we need to add extra data to the original request so that the backend application can include this data in DB queries.
OPA documentation has clear guidance for this case in the following link:
https://www.openpolicyagent.org/docs/latest/envoy-primer/#example-policy-with-object-response
Our initial assumption was to enrich original request body based on the data received from OPA and send the enriched request to upstream service. We tried different configurations and Rego files but none of them resulted in an enriched request being received to the upstream service.
As a result, we carefully studied Envoy documentation and found the following links:

https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/auth/v3/external_auth.proto
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/base.proto#envoy-v3-api-msg-config-core-v3-queryparameter

It appears that enriching body is only possible for downstream services with only string values and Envoy offers limited functionality regarding manipulation of original request. Also, it is clearly mentioned in Envoy document that we can set additional query parameters and headers for upstream. This solution also has its own limitations including adding too many values in query parameters and adding array data.
We would appreciate your time and would be glad if you help us come up with a suitable solution and also give us more information in case we have missed something.

cc  @esmet @gsagula @dio

@javid-dastgoshadeh how about leveraging https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/ext_proc_filter here? cc. @gbrail


Add swing support for HVAC units

Per sampsyo/wideq#39 and sampsyo/wideq#40, it looks like there's support for querying/setting the swing state on supported HVAC units. Therefore, it would be nice to be able to modify these settings from the component as well.
Some key things to consider:

How should this be exposed in the UI? The default mechanism for the fan speed seems to be sufficient, but is there a better way? (might be a noob-ish question, somewhat new to HA)
Not all HVAC units will support Swing configurations - do we have a way to determine if the HVAC unit doesn't support a swing setting?

Overall, great custom component here - if only the WLAN dongle for my AC was less buggy...

One obstacle for the implementation might be the swing mode API in home assistant. As far as I can see (https://developers.home-assistant.io/docs/core/entity/climate/#swing-modes) they only support to set a swing in the horizontal, vertical or both, but offer no option to set steps independently (e.g. set the vertical swing to auto and the horizontal to the left most swing).


Optimize getTvlProjects

Part of L2B-7570

[x] Not recreating the all projects array (-40ms)
[x] Removing the n^2 filter from the array (-150ms)
[x] Filtering sooner so we don't do useless computation (1.5x)
[ ] getTvlAmountsConfig doesn't require all the projects

filter 👏 before 👏 mapping 👏
maybe my university scala lessons were not so useless after all


onClick call back for intercom widget

Hi,
I see that currently there's no way to call a callback function when a user clicks on the intercom widget.
Is this something not possible with the current intercom library?
If it is possible, how hard is it to implement it for next-intercom?

Hi @Bhanukamax , you can use the Intercom('onShow') event to achieve this.
import { trackEvent } from 'next-intercom'

trackEvent('onShow', () => {
console.log('composer opened!')
})


fix name of max_rotation_angle in site form and add it to keys to par…

…se for single axis tracking_type
closes #61

datamodel and api have since been changed to max_rotation_angle


y623 Firmware update prevents hack from working

I bought the Yi Pro 2K Home in a 2 Pack. I connected one via app and updated the firmware to the latest version (a mistake!), 12.51.08_202403081746. The hack doesn't seem to work. The Factory.done file is created but it can't. connect.
For the second Camera I directly inserted the Hack SD and it worked. Now I wonder if I can somehow rewind to an older Firmware (e.g. by creating a copy from the hacked camera), does someone have experience with that?

I figured it out how to load the backup but it still can't connect

Did you restore the previous version?
The cam is connected to the app? Is it working?

I figured it out how to load the backup but it still can't connect

Could you please tell me how to restore the backup or downgrade the firmware?

I figured it out how to load the backup but it still can't connect

Could you please tell me how to restore the backup or downgrade the firmware?

Sure, so you got the mtdblock.bin files? If so you need to download the unbrick folder of this repo, add your mtdblock.bin files (-2, -3 & 4 are required) into the folder of your corresponding camera (in the case of the Yi Pro 2K Home it's the y623 folder). If you're on a Mac, make sure you have uboot tools installed (e.g. brew install u-boot-tools) then do: cd unbrick and run ./build.sh factory (as described in the documentation).
This should give you the 3 zip files in your folder /unbrick/y623/  backup_y623.gz, home_y623.gz & rootfs_y623.gz. Unzip all, add them onto your SD card which you insert into the camera and power it up, when it reboots the previous firmware should be restored. I also attached my backup files which you can directly put on the SD-Card (for y623, they are zipped since I can't upload the corresponding file type).
Hope this helps
Backup_Files.zip


Light Effect error ( opengl,win10 )

Material_sandbox app render sphere model with tangent data, the effect looks error.
Image A lit by directional ight,
Image B lit by spot light.

Could you please give more details about this? What model are you using? Here's what directional and spot lights look like with assets/model/sphere/sphere.obj.

I use this model :
EARTHMAP.zip

Looks fine to me when I convert it to .obj. Seems like an issue with your conversion?

i use assimp to direct load the model into Material_sandbox


Review Chia private key & wallet security best practices - implement and document for Machinaris.

We inherited the keys=/root/.chia/mnemonic.txt behavior from the official Chia Docker, but there needs to be a better way to handle the private key and/or keyring.
Some notes:

When mode=plotter, we can now just pass farmer_pk and pool_pk, so that's good.
When mode=harvester, we can import the farmer's ca and not require mnemonic.txt, so that's good.
But when mode=[farmer|fullnode], we need a better approach to private key security.  Currently, mnemonic.txt is required on first launch to initialize Chia services.
Best practice is to change the payout address to a cold wallet so that coins do not accumulate in the main wallet used by Machinaris.

Some references:

How To Create A Cold Wallet For Chia Coin and Chia Forks: great video tutorial by Digital Spaceport
https://thechiaplot.net/secure-farming/

I'm opening this thread and calling for discussion and assistance to find best practices and approaches.  Any contributions of wiki documentation and code pull requests are welcomed.   A "Security" discussion channel has also been opened our our Discord.  Come share good ideas!

Is mnemonic.txt needed more than once? Because having it deleted after startup would already be something

Thanks for the suggestion.  Back in late May, when I last tested starting an existing fullnode without invoking chia keys add, I was getting errors related to the wallet, perhaps due that Chia version.
However, based on your suggestion, I have just re-tested this scenario, without mnemonic.txt, and now things are working.  Farming is running and the wallet is available.  Obviously the private keys are still present on disk, but at least the mnemonic.txt is gone.
So I think this is a very good suggestion.  I'll work in the deletion of mnemonic.txt, after verifying the user has it recorded, into a Getting Starting workflow that I'll be adding soon.  Thanks!

I see more problems...
If forks, or (sorry) machinaris get access to the phrase ... even if I use a cold wallet, there is still an issue with manipulation with:

plot NFT (pool change/self pooling) -- So the attacker can change pool or even change to self pooling
communicate with a pool and change payout address

So, the cold wallet can save my already farmed coins. But the future of the plots and future rewards are compromised.
Am I wrong?
Are there any other options to solve those problems?
A cold wallet is not sufficient I think
I have also tried to open this question on official chia github..
See https://github.com/Chia-Network/chia-blockchain/discussions/9007

I see more problems... If forks, or (sorry) machinaris get access to the phrase ... even if I use a cold wallet, there is still an issue with manipulation with:

plot NFT (pool change/self pooling) -- So the attacker can change pool or even change to self pooling
communicate with a pool and change payout address
So, the cold wallet can save my already farmed coins. But the future of the plots and future rewards are compromised.

Hi.  Great points! Yes, you are absolutely correct.  The value of plots is tied to the private key encoded in the mnemonic.  For that reason, each person in this blockchain farming ecosystem must assess their own risk/reward position.  For some, that will mean:

Only running the official software, without any 3rd party tools.  They must also ensure their farming systems are not compromised by malware and remote exploits, as we all must do these days using Internet-connected systems.
OR not even running official farming software, instead using Flexfarmer to only harvest for example.
Others still will want to participate in the blockchain fork community, cross-farming the same plots to obtain those additional rewards.  This, by definition, will expand the exposure surface for one's mnemonic key.  Many will find that an acceptable trade-off, particularly when combined with a cold wallet.

Only each individual can determine their own risk tolerance in pursuit of blockchain rewards by farming plots.  Machinaris will continue to serve those interested in more than one blockchain in as secure a manner as possible.  Hope this helps answer your question!

I am not here to hate :-)
I just really want to find some safe way to do it.
I believe, there should be another way instead of sharing the keyphrase.
It should be possible to farm without a wallet sk.
What about not sharing the phrase but only map private keys needed for farming into the containers and keep unnecessary keys hidden?

Yes, good suggestion.  Like in the official Chia docker, it's possible to set the keys environment variable to persistent.  Then no mnemonic is required, but all key import and management is responsibility of the advanced user.


feat: 🔥 support OpenAI to generate commit message

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] UI changes have been reviewed
[ ] No UI review needed

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Run tests on mac and python 3.12

Our wrapping of "at" should run on macOS and with
python 3.12, so lets add these to the test matrix.

Actually - something isn't right here, we have three extra tests "build" that I don't understand.

Thanks! - I learn something every day


[2175] Add editing of alert email address

Context
Changes proposed in this pull request

Guidance to review

 [M] Editable Email alerts for new applications

Thanks for all the approval :+1:
Just noticed my <label> tags aren't matched with the form elements

also @fofr tells me I'm missing the red border on the permission when not ticked :sob:


Update docker image for k8s deployment

Related PRs:
https://github.build.ge.com/predix/uaa-k8s-deploy/pull/1
https://github.com/GESoftware-CF/uaa/pull/380
https://github.build.ge.com/predix/uaa-cf-release/pull/58

Dockerize pipeline build/test was successful: https://i.ci.build.ge.com/bjmjek1k/ci/job/UAA/job/Dockerize/view/change-requests/job/PR-381/


msal-browser - Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress: Interaction is currently in progress.

Library

[ x ]<EMAIL_ADDRESS>
Framework

[ x ] Angular 7

Description
I'm getting what seems to be a common error:  BrowserAuthError: interaction_in_progress. On initial login and redirection, everything works. However, when a second attempt is made, then the error appears. It seems that the initial promise is not resolving because of the redirect that is occurring. I've read a few issues about the same error being thrown. The app is currently Angular 7 but it will be upgraded to the most recent Angular soon, so I'd prefer to use the general MSAL library and not the Angular specific lib.
Error Message

Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress:
Interaction is currently in progress.
Please ensure that this interaction has been completed before calling an interactive API.
BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.

Reproduction steps
This is the current code:
        const msalConfig = {
          auth: {
            clientId: example-client-id,
            redirectUri: localhost:3000/example-redirect,
          },
        };

        const msalInstance = new msal.PublicClientApplication(msalConfig);

        msalInstance.loginRedirect();

        msalInstance
          .handleRedirectPromise()
          .then((tokenResponse) => {
            if (tokenResponse === null) {
              // If the tokenResponse === null, you are not coming back from an auth redirect.
            } else {
              // If the tokenResponse !== null, then you are coming back from a successful authentication redirect.
            }
          })
          .catch((error) => {
            // handle error, either in the library or coming back from the server
          });

Expected behavior
No errors when attempting to login for a second time.
Identity Provider

[ x ] Azure AD

Browsers/Environment

[ x ] Chrome

Regression

[ ] Did this behavior work before?
Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[ x ] Customer request

@pkanher617 Thank you.
Resolving handleRedirectPromise before the loginRedirect API is used solves this issue.


Using "~" in --cache-dir does not work properly

Steps to reproduce the problem:

Use "~" in --cache-dir like -  gptscript --cache-dir=~/testcache vision.gpt

tools: github.com/gptscript-ai/vision

Describe the picture in file /users/sangeethahariharan/Downloads/sunrise.jpeg for me

This fails with following errors:
17:39:46 started  [main]
17:39:46 sent     [main]
         content  [1] content | Waiting for model response...
         content  [1] content | tool call vision -> {"images":"file:///users/sangeethahariharan/Downloads/sunrise.jpeg","prompt":"Describe the picture in detail."}
17:39:48 started  [vision(2)] [input={"images":"file:///users/sangeethahariharan/Downloads/sunrise.jpeg","prompt":"Describe the picture in detail."}]
17:39:48 Cloning https://github.com/gptscript-ai/vision.git
17:39:49 Fetching 46ac5323baf9da743f238a313b5b78608b2d4dbf at https://github.com/gptscript-ai/vision.git
17:39:49 Checking out 46ac5323baf9da743f238a313b5b78608b2d4dbf to ~/testcache/repos/46ac5323baf9da743f238a313b5b78608b2d4dbf/node21
17:39:49 Downloading Node 21.x
2024/03/11 17:39:51 fork/exec ~/testcache/repos/runtimes/node/673f54c844864777b8630b9478e27283532f0d475ea502e114cdac1c75b75bad/node-v21.7.0-darwin-x64/bin/npm: no such file or directory

~ is not used as home dir and I see directory ~ created under the current working directory which gets used as the cache dir.
pwd
/Users/sangeethahariharan/gptscriprelease/gptscript/examples/~/testcache/repos/runtimes/node/673f54c844864777b8630b9478e27283532f0d475ea502e114cdac1c75b75bad
sangeethahariharan@Sangeethas-MacBook-Pro-2 673f54c844864777b8630b9478e27283532f0d475ea502e114cdac1c75b75bad % ls -ltr
total 0

Note - Using ~ with image-generation tool seems to not break the tool from working using ~ created under the current working directory .
Expected Behavior:
~ should be translated to home dir and we should be able to use the tools successfully .

gptscript version - v0.0.0-dev-a5a0538d-dirty
Able to use "~" in --cache-dir successfully.


fix: 4 new screens with a light status bar

Will fix #2140

Codecov Report

Merging #2175 (9b494d6) into develop (2ea0da3) will decrease coverage by 0.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2175      +/-   ##
==========================================
- Coverage     8.86%   7.88%   -0.98%
==========================================
  Files          161     177      +16
  Lines         6623    8661    +2038
==========================================
+ Hits           587     683      +96
- Misses        6036    7978    +1942

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
53.48% <0.00%> (-29.50%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
11.11% <0.00%> (-21.20%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
19.23% <0.00%> (-14.98%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
26.47% <0.00%> (-4.96%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

packages/smooth_app/lib/main.dart
15.74% <0.00%> (-2.16%)
:arrow_down:

...s/smooth_app/lib/pages/onboarding/next_button.dart
2.22% <0.00%> (-1.78%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c24f9b...9b494d6. Read the comment docs.


[STORM-3384] set-log-level command throws wrong exception if the topology is not running

cherry-pick from https://github.com/apache/storm/pull/3001

+1

The failure seems to be irrelevant .


Bump to v0.4.0

cc: @YuhanLiin Do you have any feedback/objections?

I've tested this locally, and the crate appears to work fine. If necessary, we can do a point release. But I need to get these crates released for now.

@YuhanLiin I think I addressed all comments. If you think everything looks good, I can release v0.4.1: https://github.com/rust-embedded/msp430/compare/v0.4.0...HEAD

Everything's good for release


Add area/localization label in content/bn/OWNERS

Feature Description

Add area/localization label in content/bn/OWNERS

other languages have area/localization label (ref. #42206 )

$ pwd
/path/to/website
$ grep -RIn "area/localization" ./content/**/OWNERS
./content/bn/OWNERS:13:- area/localization
./content/de/OWNERS:14:- area/localization
./content/es/OWNERS:14:- area/localization
./content/fr/OWNERS:14:- area/localization
./content/hi/OWNERS:14:- area/localization
./content/id/OWNERS:14:- area/localization
./content/it/OWNERS:12:- area/localization
./content/ja/OWNERS:14:- area/localization
./content/ko/OWNERS:14:- area/localization
./content/pl/OWNERS:14:- area/localization
./content/pt-br/OWNERS:12:- area/localization
./content/ru/OWNERS:14:- area/localization
./content/uk/OWNERS:14:- area/localization
./content/vi/OWNERS:14:- area/localization
./content/zh-cn/OWNERS:14:- area/localization

/cc @sftim (since #42206 was opened by Tim )

/cc sftim

/area localization

Sorry, I add empty line, so PTAL again @sftim

/assign asem-hamid
PTAL @asem-hamid to move forward this PR, thank you!!
(Since I know you are actively worked in the bn l10n team, let me assign)


Fix stuck client caused by blocking channel operation and wrong timeout value

longhorn/longhorn#7395

Do you think we should also change the following code? This should avoid adding a response channel of a command to the responseChans if it is not handled by the SPDK json-rpc server.
/pkg/jsonrpc/client.go#L151-L164
func (c *Client) handleSend(msgWrapper *messageWrapper) {
	id := c.idCounter
	c.idCounter++
	c.responseChans[id] = msgWrapper.responseChan

	if err := c.encoder.Encode(NewMessage(id, msgWrapper.method, msgWrapper.params)); err != nil {
		logrus.WithError(err).Errorf("Failed to encode during handleSend")

		// In case of the cached error info of the old encoder fails the following response, it's better to recreate the encoder.
		c.encoder = json.NewEncoder(c.conn)
		c.encoder.SetIndent("", "\t")

	}
}

:arrow_down:
func (c *Client) handleSend(msgWrapper *messageWrapper) {
	if err := c.encoder.Encode(NewMessage(id, msgWrapper.method, msgWrapper.params)); err != nil {
		logrus.WithError(err).Errorf("Failed to encode during handleSend")

		// In case of the cached error info of the old encoder fails the following response, it's better to recreate the encoder.
		c.encoder = json.NewEncoder(c.conn)
		c.encoder.SetIndent("", "\t")
        return
	}

    id := c.idCounter
	c.idCounter++
	c.responseChans[id] = msgWrapper.responseChan
}

We should ensure that there is a response channel so that we can confirm that the write command has been processed.

Do you think we should also change the following code? This should avoid adding a response channel of a command to the responseChans if it is not handled by the SPDK json-rpc server.
/pkg/jsonrpc/client.go#L151-L164
func (c *Client) handleSend(msgWrapper *messageWrapper) {
	id := c.idCounter
	c.idCounter++
	c.responseChans[id] = msgWrapper.responseChan

	if err := c.encoder.Encode(NewMessage(id, msgWrapper.method, msgWrapper.params)); err != nil {
		logrus.WithError(err).Errorf("Failed to encode during handleSend")

		// In case of the cached error info of the old encoder fails the following response, it's better to recreate the encoder.
		c.encoder = json.NewEncoder(c.conn)
		c.encoder.SetIndent("", "\t")

	}
}

⬇
func (c *Client) handleSend(msgWrapper *messageWrapper) {
	if err := c.encoder.Encode(NewMessage(id, msgWrapper.method, msgWrapper.params)); err != nil {
		logrus.WithError(err).Errorf("Failed to encode during handleSend")

		// In case of the cached error info of the old encoder fails the following response, it's better to recreate the encoder.
		c.encoder = json.NewEncoder(c.conn)
		c.encoder.SetIndent("", "\t")
        return
	}

    id := c.idCounter
	c.idCounter++
	c.responseChans[id] = msgWrapper.responseChan
}

The change looks good to me.


Could BufStream be flattened?

As currently defined, BufStream produces a stream of Buf values, which in turn may contain multiple [u8] slices. I was curious what the tradeoffs were around, instead, having BufStream yield AsRef<[u8]> directly, thus "flattening" these two layers. I'm pretty sure there are straightforward ways to translate in either direction, but I may be missing something.

If I have a buffer and need to provide two slices into it, (say, chunked decoding found a chunked header in the middle), being able to yield the buffer directly as an impl Buf where the middle is skipped would be more efficient than cloning the two parts into 2 owned things. Something like Bytes allows that to be done cheaply, but even then, it'd be more efficient to only need to poll once instead of twice.
Additionally, Buf allows people to know how much of the buffer has been "used", via advance, in case they want to record as data is written or consumed, or do something like flow control by releasing H2 window capacity.

@seanmonstar Yeah, I was imagining using something like Bytes to deal with that problem, and was imagining the state machine for polling would have a fast path for the case where you have several slices you're trying to produce. I was also thinking this could be wrapped in a transformation from Stream<Item = impl Buf> to Stream<Item = impl AsRef<[u8]> or some such. Granted, we could (probably more easily) set things up in the reverse direction; I was mostly looking to see if the core BufStream definition could be simplified.
cc @cramertj as well

There's not much, but I found https://github.com/hyperium/hyper/issues/1508


Schema Versioning

How can we do versioning for the schemas so that we know when there's breaking changes?

This is a very elegant schema versioning system but it's likely far too much work to actually implement: https://www.inkandswitch.com/cambria/
I think we'd want to do something that lines up with a standard format like json-ld or DID, may want to move to self-describing data format.

Will be wanting to use chain reg as a sub-module, so this seems increasingly important.

Will be wanting to use chain reg as a sub-module, so this seems increasingly important.

Interesting. Can you say more about your use-case? Like a git submodule?

yes, @hxrts , as a git sub-module to be used as a reference for chain and asset information, IBC channel info, token images, etc., and remove all local hard-coded information about tokens and chains. Any changes about a token, e.g., changing symbol of LUNA to LUNC, desired to take effect on Osmosis would instead be done on the chain registry, and anything we need to construct will be done so through lookups using only ( chain_name + coinMinimalDenom ) as primary keys, which are assumed to be immutable.


cannot install in python 3.12, perhaps port the module to 3.12

iaacornus@sysmain ~ [1]> conda install -c conda-forge dockstring
Channels:
 - conda-forge
 - bioconda
 - defaults
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: / warning  libmamba Added empty dependency for problem type SOLVER_RULE_UPDATE
failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package dockstring-0.3.2-pyhd8ed1ab_0 requires python >=3.7,<3.11, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ dockstring is installable and it requires
│  └─ python >=3.7,<3.11 , which can be installed;
└─ pin-1 is not installable because it requires
   └─ python 3.12.* , which conflicts with any installable versions previously reported.

I can help to port the module in python 3.12 if the authors would like

Hi @iaacornus , this is a consequence of #160. We tried to set the install requirements so that the values produced by dockstring will match our pre-computed dataset. These values depend on the rdkit version, and the last rdkit version which produces the same values seems to not be supported for python 3.12. That is why it is not supported.
Going forward, it probably is a good idea to support higher python versions in some form though. Do you have a suggestion on the best way to do it? Would it be to no longer try to match the dataset? Or to raise a warning?

Going forward, it probably is a good idea to support higher python versions in some form though. Do you have a suggestion on the best way to do it? Would it be to no longer try to match the dataset? Or to raise a warning?

well, it is not really my expertise so I cannot definitely say what will be the best course of action here. Although I can experiment on it during my free time and report my findings if it can be updated while still matching the dataset

Although I can experiment on it during my free time and report my findings if it can be updated while still matching the dataset

That would be really helpful, thanks @iaacornus ! I will try to look into this again too, although it might be a bit until I can get to it.

@iaacornus sorry I didn't mention this earlier, but if you are stuck you can always install it manually with your own dependencies. You can run:
 # can skip if these libraries are already installed
conda install -c conda-forge openbabel rdkit

# installs without dependencies
pip install --no-deps dockstring

The library should run fine if you do this, although conda might complain about package version conflicts later if you try to install anything else. Let me know if this workaround is helpful.


Make tar2ext4 deterministic with files without parent dir in tar

Problem to fix
./dmverity-vhd roothash is  not deterministic for some file docker images.
IMAGE=gcr.io/distroless/cc-debian11@sha256:d5a2169bc2282598f0cf886a3d301269d0ee5bf7f7392184198dd41d36b70548

docker pull $IMAGE > /dev/null

./dmverity-vhd -v -d roothash -i $IMAGE > bad-debian-1.txt
./dmverity-vhd -v -d roothash -i $IMAGE > bad-debian-2.txt

diff  bad-debian-1.txt bad-debian-2.txt

The above command shows a diff which suggest it's not deterministic.
This is causing a problem for az confcom tool that the generated security policy is not consistent for each run (./dmverity-vhd roothash  is called here).
Container deployment is blocked as well for C-ACI.
Cause of the problem
In the example image, there is a problematic tar file only  with a file etc/nsswitch.conf. For most of tar files there would be also etc/ directory as the parent of nsswitch.conf, but for this specific tar there isn't.
For the such files without parent, MakeParents() makes the parent directories for ext4, but it uses time.Now() and it's causing the non-deterministic behavior.
Fix
Change time.Now() to the child's value.
Test

diff  bad-debian-1.txt bad-debian-2.txt doesn't show any diff after the fix
go test ./ext4/tar2ext4/.... It includes new a unit test case.

Note
go test ./ext4/internal/compactext4/... is broken, but it seems to be the case even for main branch. Does anyone now the problem?
--- FAIL: TestBasic (0.01s)
    compact_test.go:221: e2fsck 1.45.5 (07-Jan-2020)
        Pass 1: Checking inodes, blocks, and sizes
        Pass 2: Checking directory structure
        Pass 3: Checking directory connectivity
        Pass 4: Checking reference counts
        Pass 5: Checking group summary information
        Padding at end of inode bitmap is not set. Fix? no

        testfs.img: ********** WARNING: Filesystem still has errors **********

                  26 inodes used (81.25%, out of 32)
                   0 non-contiguous files (0.0%)
                   0 non-contiguous directories (0.0%)
                     # of inodes with ind/dind/tind blocks: 0/0/0
                     Extent depth histogram: 9
                  16 blocks used (100.00%, out of 16)
                   0 bad blocks
                   0 large files

                   5 regular files
                   3 directories
                   1 character device file
                   1 block device file
                   1 fifo
                   1 link
                   5 symbolic links (2 fast symbolic links)
                   1 socket
        ------------
                  18 files
    compact_test.go:221: exit status 4

@anmaxvl  You might have already checked it, but as I mentioned in the PR description the tests under ./ext4/internal/compactext4/... seems to be broken both in this branch and main. Do you know anything about it?


Oh no, Record is already a thing

TypeScript has a built in concept of Record built into the language.  Unfortunately the Permanent backend uses the term Record to represent a file in the permanent system.
For the API interaction we're OK because it's actually not Record but RecordVo.  However, we're going to need to think of something else for our sdk side that isn't just Record.
Some ideas:

PermanentRecord <-- ugh.
File (this could be confusing since we have FileVo which is... different than RecordVo somehow)
Item <-- this has the same downside of File while also being very generic.
Document

Nothing's perfect.  I think File might be our best bet (as a partner to Folder).  I'm 99% sure that we're merging RecordVo and FileVo anyway; and if we need to keep track of whatever FileVo means we can think of a more specific name for the sdk (e.g. FileInstance or FileVersion or something).
Any thoughts?

I'm fine with File since we've discussed before that Record is initially a kind of confusing name. But I also agree with the fact that it can cause even more confusion with the whole FileVO vs RecordVO situation. If we're planning from never even exposing the FileVO type to the user to begin with, I think File is the best name.

I agree with @meisekimiu.

I've stewed for a while and here's where i'm landing:
Record should be File
File should be Derivative
(Files have file Derivatives)

Happy new year!
Following up -- derivative is a term of art in archival so I want to be careful.  In fact some of these files ARE derivatives from an archival perspective, but some of them are not.
Given that I'm leaning back to having Record just be Item (and an Item has Files, which have a DerivativeType -- which itself might be slightly inaccurate since technically original is not a derivative type but, so it goes)


 You're missing the tabs and top section as seen on the preview: https://react-step-3--carbon-tutorial.netlify.com/
Please try again!

I not sure if I follow.  I haven't started step 3 of the react tutorial, I've only submitted PRs for steps 1 and 2 so far?

👍 Looks good - 🎉 You are one step closer to completion of the Carbon React tutorial and earning the digital credential.


Fix for crash in BackdropMaterialState event callback

There's a crash we're seeing that's affecting Store where we are calling in to a BackdropMaterialState object that's already been deleted.
Based on the code I don't see how this could happen unless the m_themeChangedRevoker failed to revoke (which we've seen happen for things like XamlRoot Changed event when XAML implemented the 'managed peer' incorrectly). Since we won't be able to fix that downlevel and we can't change the lambda capture to be strong (that would create a cycle), the only way I see to address this capture the back pointer using a weak ref.
It means that we are "leaking" this callback on the target but this would only present as a true leak if someone was changing the BackdropMaterial attached property frequently during runtime, which we do not expect to happen. It should be a "set it and forget it" kind of thing.
I'm only changing this one particular handler where we are seeing the problem -- this pattern in general is safe.

/azp run


Missing character 's'

Under "Setup -> Kubernetes"
"Installation with Ansible. Install Itio with the included Ansible playbook."
's' is missing in 'Itio'

This has been fixed, will show up when 0.8 is published.


Failed to fetch with source-github command

I'm trying to setup auto update for https://github.com/platformsh/cli tool the updateScript was recently merged on https://github.com/NixOS/nixpkgs/pull/317185 but I still don't see update PR on https://github.com/NixOS/nixpkgs/pulls/r-ryantm
I've found out with the doc that github release can be used to fetch new versions.
I could generate the packages-to-update.txt for the package I'm interested about but when I run ./result/bin/nixpkgs-update source-github from latest commit 503f7b0 I got an error Failed to fetch.

Your update script ran last Friday; everything appears to be in order (there were no new releases at that time). It currently takes about a week before the bot gets around to re-checking packages it has checked recently.


Feature to dump models as JSON

Adds a dump_models method to the BayesDB class that writes JSON describing a population and its models, sufficient for simulation.
(@Schaechtle heads-up.)
(hmm, I guess we should put documentation for the JSON somewhere, but where?)
Replaces #633 - based on branch in this repository instead of branch in forked repository

I spent quite a while trying to figure out how to move the test from test_core.py to test_cgpm.py.  It's going to take a bit of work, up to an hour.  Should I bother?

I thought the temp file was deleted after the test?  How does the person doing the testing look at the json file?

I thought the temp file was deleted after the test? How does the person doing the testing look at the json file?

@jar398 Good catch, I added delete=False to NamedTemporaryFile.


Fix Axis size issues

Will hopefully fix #962

The CI failure is not related

@maartenbreddels @SylvainCorlay I suppose this is kind of critical. We might want to release 0.12.1 quickly with it. What do you think?

Thanks. Will make a 0.12.1 including this change as soon as possible.


AVX-512 build issue

When trying to run with AVX-512 flags (RUSTFLAGS='-C target-cpu=native -C target_feature=+avx512ifma,+avx512vl'.) build fails with these errors on Ubuntu 22.04.4
error: failed to run custom build command for proc-macro2 v1.0.87

Caused by:
  process didn't exit successfully: /home/oleksandr/nescience-zkvm-testing/sp1/simple_arithmetic_test/target/release/build/proc-macro2-c214c8408e8f4161/build-script-build (signal: 4, SIGILL: illegal instruction)
  --- stdout
  cargo:rerun-if-changed=build/probe.rs
warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for syn v1.0.109

Caused by:
  process didn't exit successfully: /home/oleksandr/nescience-zkvm-testing/sp1/simple_arithmetic_test/target/release/build/syn-b3a0969670dd4787/build-script-build (signal: 4, SIGILL: illegal instruction)
error: failed to run custom build command for thiserror v1.0.64

Caused by:
  process didn't exit successfully: /home/oleksandr/nescience-zkvm-testing/sp1/simple_arithmetic_test/target/release/build/thiserror-f50ef71e47a4bf72/build-script-build (signal: 4, SIGILL: illegal instruction)
  --- stdout
  cargo:rerun-if-changed=build/probe.rs
  cargo:rustc-check-cfg=cfg(error_generic_member_access)
  cargo:rustc-check-cfg=cfg(thiserror_nightly_testing)
error: failed to run custom build command for crossbeam-utils v0.8.20

Caused by:
  process didn't exit successfully: /home/oleksandr/nescience-zkvm-testing/sp1/simple_arithmetic_test/target/release/build/crossbeam-utils-7f5bb26c9c48ecce/build-script-build (signal: 4, SIGILL: illegal instruction)
  --- stdout
  cargo:rerun-if-changed=no_atomic.rs
  cargo:rustc-check-cfg=cfg(crossbeam_no_atomic,crossbeam_sanitize_thread)

This means your CPU does not support AVX512. You may want to try just RUSTFLAGS='-C target-cpu=native to enable AVX256 if available.


Subtitle in HLS media

Hi,
I used the same sample to develop a TV app but could not add subtitles when using exoplayer with lean back. Any help would be highly appreciated.

Having same issue. Did you find any solution?