runtime: fatal error: checkdead: runnable g

What version of Go are you using (go version)?

$ go version
go version go1.14.6 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/prime/.cache/go-build"
GOENV="/home/prime/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/prime/Code/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/prime/Code/go/src/a.yandex-team.ru/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build172964829=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I encountered the following error. Panic reliably happens in about one of 10000 jobs on a mapreduce cluster. My binary is built with CGO_ENABLED=0 and is started with GOMAXPROCS=1.
runtime: checkdead: find g 1 in status 1
fatal error: checkdead: runnable g

runtime stack:
runtime.throw(0xb1ac74, 0x15)
	/usr/local/go/src/runtime/panic.go:1116 +0x72 fp=0x7ffef3709728 sp=0x7ffef37096f8 pc=0x438e02
runtime.checkdead()
	/usr/local/go/src/runtime/proc.go:4407 +0x3c9 fp=0x7ffef37097a8 sp=0x7ffef3709728 pc=0x4457a9
runtime.mput(0xf2e7e0)
	/usr/local/go/src/runtime/proc.go:4824 +0x50 fp=0x7ffef37097c8 sp=0x7ffef37097a8 pc=0x446ee0
runtime.stopm()
	/usr/local/go/src/runtime/proc.go:1832 +0x7d fp=0x7ffef37097f0 sp=0x7ffef37097c8 pc=0x43f03d
runtime.exitsyscall0(0xc000000180)
	/usr/local/go/src/runtime/proc.go:3268 +0xc6 fp=0x7ffef3709820 sp=0x7ffef37097f0 pc=0x442b86
runtime.mcall(0xf2e280)
	/usr/local/go/src/runtime/asm_amd64.s:318 +0x5b fp=0x7ffef3709830 sp=0x7ffef3709820 pc=0x46919b

goroutine 1 [runnable]:
syscall.Syscall(0x1, 0x4, 0xc0000f4000, 0x1000, 0x1000, 0x1000, 0x0)
	/usr/local/go/src/syscall/asm_linux_amd64.s:18 +0x5 fp=0xc0000bc6e8 sp=0xc0000bc6e0 pc=0x48cb05
syscall.write(0x4, 0xc0000f4000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/usr/local/go/src/syscall/zsyscall_linux_amd64.go:914 +0xb9 fp=0xc0000bc768 sp=0xc0000bc6e8 pc=0x48ade9
syscall.Write(0x4, 0xc0000f4000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/usr/local/go/src/syscall/syscall_unix.go:214 +0x70 fp=0xc0000bc7c8 sp=0xc0000bc768 pc=0x488ff0
internal/poll.(*FD).Write(0xc000054600, 0xc0000f4000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/usr/local/go/src/internal/poll/fd_unix.go:268 +0x2b7 fp=0xc0000bc900 sp=0xc0000bc7c8 pc=0x4b0a77
os.(*File).write(0xc00000e7a0, 0xc0000f4000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/usr/local/go/src/os/file_unix.go:280 +0x81 fp=0xc0000bc978 sp=0xc0000bc900 pc=0x4bba21
os.(*File).Write(0xc00000e7a0, 0xc0000f4000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/usr/local/go/src/os/file.go:153 +0xe9 fp=0xc0000bc9f8 sp=0xc0000bc978 pc=0x4b89c9
bufio.(*Writer).Flush(0xc0000ee180, 0x0, 0x0)
	/usr/local/go/src/bufio/bufio.go:591 +0x141 fp=0xc0000bcaf0 sp=0xc0000bc9f8 pc=0x543a81
bufio.(*Writer).WriteString(0xc0000ee180, 0xc00047bfc2, 0x1a, 0x0, 0x0, 0x0)
	/usr/local/go/src/bufio/bufio.go:694 +0x24b fp=0xc0000bcbd8 sp=0xc0000bcaf0 pc=0x544b0b
a.yandex-team.ru/yt/go/yson.(*Writer).str(0xc0000ee1c0, 0xc00047bfb0, 0x2c)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/writer.go:242 +0x29e fp=0xc0000bcce0 sp=0xc0000bcbd8 pc=0x65292e
a.yandex-team.ru/yt/go/yson.(*Writer).String(0xc0000ee1c0, 0xc00047bfb0, 0x2c)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/writer.go:371 +0x107 fp=0xc0000bcd40 sp=0xc0000bcce0 pc=0x653aa7
a.yandex-team.ru/yt/go/yson.encodeAny(0xc0000ee1c0, 0xa57740, 0xc000222a38, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/marshal.go:200 +0x20c1 fp=0xc0000bd170 sp=0xc0000bcd40 pc=0x63faf1
a.yandex-team.ru/yt/go/yson.encodeReflectStruct.func1(0xc0000d5d00, 0xa, 0x10, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/marshal.go:463 +0x316 fp=0xc0000bd2b8 sp=0xc0000bd170 pc=0x656dc6
a.yandex-team.ru/yt/go/yson.encodeReflectStruct(0xc0000ee1c0, 0xaf1e40, 0xc000222a10, 0x99, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/marshal.go:487 +0x33d fp=0xc0000bd3d0 sp=0xc0000bd2b8 pc=0x6414ad
a.yandex-team.ru/yt/go/yson.encodeReflect(0xc0000ee1c0, 0xaf1e40, 0xc000222a10, 0x99, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/marshal.go:350 +0x71b fp=0xc0000bd4c8 sp=0xc0000bd3d0 pc=0x64045b
a.yandex-team.ru/yt/go/yson.encodeAny(0xc0000ee1c0, 0xaf1e40, 0xc000222a10, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/marshal.go:326 +0x9a4 fp=0xc0000bd8f8 sp=0xc0000bd4c8 pc=0x63e3d4
a.yandex-team.ru/yt/go/yson.(*Writer).Any(0xc0000ee1c0, 0xaf1e40, 0xc000222a10)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/yson/writer.go:668 +0x5d fp=0xc0000bd940 sp=0xc0000bd8f8 pc=0x655d3d
a.yandex-team.ru/yt/go/mapreduce.(*writer).Write(0xc0000e6630, 0xaf1e40, 0xc000222a10, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/mapreduce/writer.go:34 +0x89 fp=0xc0000bd988 sp=0xc0000bd940 pc=0x8cb2c9
a.yandex-team.ru/yt/go/mapreduce.(*writer).MustWrite(0xc0000e6630, 0xaf1e40, 0xc000222a10)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/mapreduce/writer.go:39 +0x43 fp=0xc0000bd9d8 sp=0xc0000bd988 pc=0x8cb363
a.yandex-team.ru/yt/jaeger.RebuildIndexJob.Do(0xbb5920, 0xc00006f940, 0xbbec80, 0xc0000b0480, 0xc00000da80, 0x2, 0x2, 0x0, 0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/jaeger/rebuild_index.go:28 +0x2e8 fp=0xc0000bdbf8 sp=0xc0000bd9d8 pc=0xa04998
a.yandex-team.ru/yt/jaeger.(*RebuildIndexJob).Do(0xf58688, 0xbb5920, 0xc00006f940, 0xbbec80, 0xc0000b0480, 0xc00000da80, 0x2, 0x2, 0x0, 0x0)
	<autogenerated>:1 +0xa9 fp=0xc0000bdc68 sp=0xc0000bdbf8 pc=0xa084e9
a.yandex-team.ru/yt/go/mapreduce.JobMain(0x0)
	/home/prime/Code/go/src/a.yandex-team.ru/yt/go/mapreduce/main.go:72 +0x9d1 fp=0xc0000bdf60 sp=0xc0000bdc68 pc=0x8c4d61
main.main()
	/home/prime/Code/go/src/a.yandex-team.ru/yt/jaeger/yt-jaeger/main.go:12 +0x35 fp=0xc0000bdf88 sp=0xc0000bdf60 pc=0xa0c6e5
runtime.main()
	/usr/local/go/src/runtime/proc.go:203 +0x1c8 fp=0xc0000bdfe0 sp=0xc0000bdf88 pc=0x43b4a8
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc0000bdfe8 sp=0xc0000bdfe0 pc=0x46b141

goroutine 2 [force gc (idle)]:
runtime.gopark(0xb3b238, 0xf2ccc0, 0x1411, 0x1)
	/usr/local/go/src/runtime/proc.go:304 +0xcb fp=0xc00003af88 sp=0xc00003af58 pc=0x43b86b
runtime.goparkunlock(0xf2ccc0, 0x1411, 0x1)
	/usr/local/go/src/runtime/proc.go:310 +0x53 fp=0xc00003afb8 sp=0xc00003af88 pc=0x43b923
runtime.forcegchelper()
	/usr/local/go/src/runtime/proc.go:253 +0xaa fp=0xc00003afe0 sp=0xc00003afb8 pc=0x43b70a
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00003afe8 sp=0xc00003afe0 pc=0x46b141
created by runtime.init.6
	/usr/local/go/src/runtime/proc.go:242 +0x35

goroutine 3 [GC sweep wait]:
runtime.gopark(0xb3b238, 0xf2d300, 0x46140c, 0x1)
	/usr/local/go/src/runtime/proc.go:304 +0xcb fp=0xc00003b780 sp=0xc00003b750 pc=0x43b86b
runtime.goparkunlock(0xf2d300, 0xba140c, 0x1)
	/usr/local/go/src/runtime/proc.go:310 +0x53 fp=0xc00003b7b0 sp=0xc00003b780 pc=0x43b923
runtime.bgsweep(0xc000052000)
	/usr/local/go/src/runtime/mgcsweep.go:89 +0x101 fp=0xc00003b7d8 sp=0xc00003b7b0 pc=0x427161
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00003b7e0 sp=0xc00003b7d8 pc=0x46b141
created by runtime.gcenable
	/usr/local/go/src/runtime/mgc.go:214 +0x5c

goroutine 4 [sleep]:
runtime.gopark(0xb3b238, 0xf2d2c0, 0xc000011313, 0x2)
	/usr/local/go/src/runtime/proc.go:304 +0xcb fp=0xc00003bf20 sp=0xc00003bef0 pc=0x43b86b
runtime.goparkunlock(0xf2d2c0, 0x2c99138c01313, 0x2)
	/usr/local/go/src/runtime/proc.go:310 +0x53 fp=0xc00003bf50 sp=0xc00003bf20 pc=0x43b923
runtime.scavengeSleep(0x928f8, 0x13b74e7)
	/usr/local/go/src/runtime/mgcscavenge.go:214 +0x83 fp=0xc00003bf80 sp=0xc00003bf50 pc=0x4255b3
runtime.bgscavenge(0xc000052000)
	/usr/local/go/src/runtime/mgcscavenge.go:337 +0x1ce fp=0xc00003bfd8 sp=0xc00003bf80 pc=0x4257ae
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00003bfe0 sp=0xc00003bfd8 pc=0x46b141
created by runtime.gcenable
	/usr/local/go/src/runtime/mgc.go:215 +0x7e

goroutine 5 [finalizer wait]:
runtime.gopark(0xb3b238, 0xf585d0, 0xf51410, 0x1)
	/usr/local/go/src/runtime/proc.go:304 +0xcb fp=0xc00003a728 sp=0xc00003a6f8 pc=0x43b86b
runtime.goparkunlock(0xf585d0, 0xb31410, 0x1)
	/usr/local/go/src/runtime/proc.go:310 +0x53 fp=0xc00003a758 sp=0xc00003a728 pc=0x43b923
runtime.runfinq()
	/usr/local/go/src/runtime/mfinal.go:175 +0x96 fp=0xc00003a7e0 sp=0xc00003a758 pc=0x41cec6
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00003a7e8 sp=0xc00003a7e0 pc=0x46b141
created by runtime.createfing
	/usr/local/go/src/runtime/mfinal.go:156 +0x61

goroutine 6 [GC worker (idle)]:
runtime.gopark(0xb3b0b8, 0xc0004340f0, 0x1418, 0x0)
	/usr/local/go/src/runtime/proc.go:304 +0xcb fp=0xc00003c758 sp=0xc00003c728 pc=0x43b86b
runtime.gcBgMarkWorker(0xc00002c000)
	/usr/local/go/src/runtime/mgc.go:1873 +0x119 fp=0xc00003c7d8 sp=0xc00003c758 pc=0x420659
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1373 +0x1 fp=0xc00003c7e0 sp=0xc00003c7d8 pc=0x46b141
created by runtime.gcBgMarkStartWorkers
	/usr/local/go/src/runtime/mgc.go:1821 +0x77

I'm unable to reproduce this issue locally, but I was able to collect a coredump. Binary and core dump are inside checkdead.zip archive. My binary is reading data from stdin and writing data to stdout, without spawning any additional goroutines.
I would be glad to hear any suggestions on how to futher diagnose this issue.

cc @aclements @mknyszek

Not reproducing with 1.13.14

cc @prattmic
@slon, can you try reproducing with GODEBUG=asyncpreemptoff=1?

Issue is reproducing with GODEBUG=asyncpreemptoff=1.

Can you reproduce it with the environment variable GODEBUG=schedtrace=1,scheddetail=1 ?

Dealing with gdb is a pain, but if I'm reading the stack correctly, I believe this G exited the syscall, failed to acquire a P, added to the global runq and then called stopm. That mput -> checkdead is the one throwing.
(gdb) p /x 'runtime.allgs'
$21 = []*runtime.g = {0xc000000180, 0xc000000600, 0xc000000780, 0xc000000900, 0xc000000d80, 0xc000000f00}
(gdb) p /x 'runtime.sched'.runq
$19 = {
  head = 0xc000000180,
  tail = 0xc000000180
}

Also of interest is that sysmon is blocked waiting on sched.lock:
Thread 3 (LWP 35):
#0  runtime.futex () at /usr/local/go/src/runtime/sys_linux_amd64.s:568
#1  0x00000000004350b6 in runtime.futexsleep (addr=0xf2dfb8 <runtime.sched+24>, val=2, ns=-1) at /usr/local/go/src/runtime/os_linux.go:45
#2  0x000000000040bb0c in runtime.lock (l=0xf2dfb8 <runtime.sched+24>) at /usr/local/go/src/runtime/lock_futex.go:102
#3  0x000000000043ca57 in runtime.mcommoninit (mp=0xc00003e700) at /usr/local/go/src/runtime/proc.go:616
#4  0x000000000043e43d in runtime.allocm (_p_=0xc00002c000, fn={void (void)} 0xc00004dec8, ~r2=<optimized out>) at /usr/local/go/src/runtime/proc.go:1390
#5  0x000000000043eb89 in runtime.newm (fn={void (void)} 0xc00004def0, _p_=0xc00002c000) at /usr/local/go/src/runtime/proc.go:1704
#6  0x000000000043f269 in runtime.startm (_p_=0xc00002c000, spinning=false) at /usr/local/go/src/runtime/proc.go:1875
#7  0x0000000000445b3a in runtime.sysmon () at /usr/local/go/src/runtime/proc.go:4539
#8  0x000000000043db71 in runtime.mstart1 () at /usr/local/go/src/runtime/proc.go:1097
#9  0x000000000043da74 in runtime.mstart () at /usr/local/go/src/runtime/proc.go:1062
#10 0x000000000046d333 in runtime.clone () at /usr/local/go/src/runtime/sys_linux_amd64.s:619
#11 0x0000000000000000 in ?? ()

At first glance this isn't surprising since checkdead is holding sched.lock during the throw. What is surprising is that it is stuck on the lock in mcommoninit. startm also takes sched.lock but releases it before calling newm. This implies that the startm call started before checkdead, which makes me rather suspicious of a race condition with sysmon (perhaps taking back the P from the syscall G).

I'm unable to reproduce it with GODEBUG=schedtrace=1,scheddetail=1.

I think I found sequence of events that might lead to that error.

G1 is blocked in syscall.
sysmon takes P and starts another M to run GC.
G1 returns from syscall and fails to acquire P.
GC is finished. Other M stops.
G1 calls stopm() and triggers the panic.

Is that plausible?

@slon The code in exitsyscall0 acquires the scheduler lock, then tries to get a P.  In this case it fails to get a P, so it adds the G to the global run queue.  So I think the only way that your scenario can lead to trouble is if when the M running GC stops it does not decide to run the G that is on the global run queue.  I don't yet see how that could happen.

For posterity, I've more explicitly walked the stack to confirm the call path in https://github.com/golang/go/issues/40368#issuecomment-663204851 is correct.
(gdb) set $start = 0xc00004fdf0
(gdb) while $start < $end
 >printf "start: 0x%lx, pc: 0x%lx\n", $start, *(void **)($start+8)
 >info symbol *(void **)($start+8)
 >set $start = *(void **)($start)
 >end
start: 0xc00004fdf0, pc: 0x44feaa
runtime.crash + 26 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004fe08, pc: 0x467d21
runtime.fatalthrow.func1 + 129 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004fe50, pc: 0x438fc7
runtime.fatalthrow + 87 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004fe88, pc: 0x438e02
runtime.throw + 114 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004feb8, pc: 0x4457a9
runtime.checkdead + 969 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004ff38, pc: 0x446ee0
runtime.mput + 80 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004ff58, pc: 0x43f03d
runtime.stopm + 125 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004ff80, pc: 0x442b86
runtime.exitsyscall0 + 198 in section .text of /home/mpratt_google_com/yt-jaeger
start: 0xc00004ffb0, pc: 0x46919b
runtime.mcall + 91 in section .text of /home/mpratt_google_com/yt-jaeger

@prattmic I think you've found the problem.  sysmon calls startm which acquires the only P and releases the scheduler lock.  exitsyscall0 acquires the scheduler lock, finds no P, puts the G on the global run queue, releases the lock, calls stopm which calls checkdead.  At this point there is no P available, because startm snagged it.  But there is also no M available, because startm hasn't yet made it to the line sched.mnext++ in mcommoninit, and it will never get there because checkdead is holding the scheduler lock.
In short, the problem is that sysmon -> startm -> newm can acquire a P before creating an M to run on that P.  When GOMAXPROCS == 1, we are in a situation where there are no P's and no M's, so things look bleak.

One fix might be for startm to say somewhere "I am starting an M" when mget returns nil, before releasing the scheduler lock.  Then mcommoninit would somehow remove that statement after it increments sched.mnext.

After spending too long on this, I'm able to reproduce the crash with a program racing syscall exit with timer expiration, plus strategically placed sleeps in the runtime to help increase the likelihood of racing properly:
package main

import (
        "syscall"
        "time"
)

func main() {
        t := time.NewTimer(100*time.Millisecond)
        defer t.Stop()

        ts := syscall.Timespec{
                Nsec: int64(100*time.Millisecond - 4*time.Microsecond),
        }
        for {
                if err := syscall.Nanosleep(&ts, nil); err != syscall.EINTR {
                        break
                }
        }
}

A program like this is going to have 3 Ms:

Running the main G in the nanosleep syscall.
Spinning M in the findrunnable netpoll waiting for timer expiration.
Sysmon M also waiting for timer expiration.

In order to trigger the crash, we need the race to proceed in this order:

Sysmon wakes up, calls startm to handle the timer.
startm takes the only P, but does not find an idle M. Releases sched.lock. (Does not make it to lock in mcommoninit)
netpoll in findrunnable completes, runs timer (chan send with no waiter), then goes to sleep (stopm, this ensures checkdead won't see this M as running).
Syscall completes, takes sched.lock, finds no P, adds to global runq and goes to sleep.
checkdead detects that there are no running Ms (because mcommoninit hasn't run yet). Panic!

Perhaps a more complex program could convince the spinning M to already be stopped, in which case this race would be much easier to trigger? As-is, it is very tricky. I'll try to send out a fix on Monday, but it will likely not include a test due to the difficulty of triggering.
runtime: checkdead: find g 1 in status 1
fatal error: checkdead: runnable g

runtime stack:
runtime.throw(0x48c091, 0x15)
        /usr/local/google/home/mpratt/src/go/src/runtime/panic.go:1116 +0x72
runtime.checkdead()
        /usr/local/google/home/mpratt/src/go/src/runtime/proc.go:4665 +0x548
runtime.mput(0x4f0680)
        /usr/local/google/home/mpratt/src/go/src/runtime/proc.go:5119 +0x9e
runtime.stopm()
        /usr/local/google/home/mpratt/src/go/src/runtime/proc.go:1947 +0x7f
runtime.exitsyscall0(0xc000000180)
        /usr/local/google/home/mpratt/src/go/src/runtime/proc.go:3490 +0x1c5
runtime.mcall(0x0)
        /usr/local/google/home/mpratt/src/go/src/runtime/asm_amd64.s:318 +0x5b

goroutine 1 [runnable]:
syscall.Syscall(0x23, 0xc000034750, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/google/home/mpratt/src/go/src/syscall/asm_linux_amd64.s:18 +0x5
syscall.Nanosleep(0xc000034750, 0x0, 0x7fcc503a2000, 0x1a099)
        /usr/local/google/home/mpratt/src/go/src/syscall/zsyscall_linux_amd64.go:640 +0x5f
main.main()
        /usr/local/google/home/mpratt/src/go/src/40368.go:31 +0x7e

@gopherbot backport to 1.14 please. This crash could affect any program running with GOMAXPROCS=1.

@prattmic the backport issue automatically has a 1.14.x milestone, so this would be 1.15 (and release-blocker?) or 1.16.

As networkimprov said the backport already has a 1.14.7 milestone, so I'm putting this one in 1.16 (move it to 1.15 if you think this is 1.15 material).

would this kind of backtrace be relaited to this issue ?
'''
(dlv) bt
0  0x0000000000465511 in runtime.raise
at /usr/local/go/src/runtime/sys_linux_amd64.s:165
1  0x0000000000449c7b in runtime.crash
at /usr/local/go/src/runtime/signal_unix.go:822
2  0x000000c0000098e0 in ???
at ?:-1
3  0x0000000000448b84 in runtime.restoreGsignalStack
at /usr/local/go/src/runtime/signal_unix.go:1156
4  0x0000000000448b84 in runtime.sigtrampgo
at /usr/local/go/src/runtime/signal_unix.go:455
5  0x0000000000465873 in runtime.sigtramp
at /usr/local/go/src/runtime/sys_linux_amd64.s:389
6  0x0000000000465960 in runtime.sigreturn
at /usr/local/go/src/runtime/sys_linux_amd64.s:481
7  0x0000000000449e0a in runtime.noSignalStack
at /usr/local/go/src/runtime/signal_unix.go:870
8  0x0000000001355bc0 in ???
at ?:-1
9  0x0000000000433c47 in runtime.startpanic_m
at /usr/local/go/src/runtime/panic.go:1277
10  0x00007ffc657265e8 in ???
at ?:-1
11  0x0000000000440a12 in runtime.checkdead
at /usr/local/go/src/runtime/proc.go:4386
12  0x0000000000439eb5 in runtime.startm
at /usr/local/go/src/runtime/proc.go:1851
13  0x000000c00003c000 in ???
at ?:-1
14  0x000000000043c03c in runtime.schedule
at /usr/local/go/src/runtime/proc.go:2485
15  0x000000000043cff6 in runtime.reentersyscall
at /usr/local/go/src/runtime/proc.go:2935
16  0x000000c00004c7c0 in ???
at ?:-1
17  0x0000000000463956 in runtime.goexit
at /usr/local/go/src/runtime/asm_amd64.s:1374
(dlv) frame 3

runtime.raise() /usr/local/go/src/runtime/sys_linux_amd64.s:165 (PC: 0x465511)
Warning: debugging optimized function
Frame 3: /usr/local/go/src/runtime/signal_unix.go:1156 (PC: 448b84)
1151: // before entering the signal handler.
1152: //go:nosplit
1153: //go:nowritebarrierrec
1154: func restoreGsignalStack(st *gsignalStack) {
1155:         gp := getg().m.gsignal
=>1156:         gp.stack = st.stack
1157:         gp.stackguard0 = st.stackguard0
1158:         gp.stackguard1 = st.stackguard1
1159:         gp.stktopsp = st.stktopsp
1160: }
1161:
(dlv) p st
Command failed: could not find symbol value for st
(dlv) locals
(no locals)
(dlv) args
(no args)
(dlv) p st
Command failed: could not find symbol value for st
(dlv) p gp
Command failed: could not find symbol value for gp
(dlv) frame 9
runtime.raise() /usr/local/go/src/runtime/sys_linux_amd64.s:165 (PC: 0x465511)
Warning: debugging optimized function
Frame 9: /usr/local/go/src/runtime/panic.go:1277 (PC: 433c47)
1272:         case 2:
1273:                 // This is a genuine bug in the runtime, we couldn't even
1274:                 // print the stack trace successfully.
1275:                 g.m.dying = 3
1276:                 print("stack trace unavailable\n")
=>1277:                 exit(4)
1278:                 fallthrough
1279:         default:
1280:                 // Can't even print! Just exit.
1281:                 exit(5)
1282:                 return false // Need to return something.
(dlv) args
(no args)

'''

@networkimprov @ALTree thanks, this is fine. If it doesn't make 1.15 it will probably want to be in the first minor release, but I don't think it needs to be blocking.
@apmattil it is difficult to tell from the stack trace. What was the panic message printed by that crash?

I'm sorry, did/do not get the ouput.. it is at our robot framework tests
that in this case does not save it.
It happened couple times.. got 6 same kind of cores.
Is there anything else I can get/check ?
I think it does not appear when I have non-optimized build.
On Mon, Jul 27, 2020 at 6:50 PM Michael Pratt<EMAIL_ADDRESS>wrote:

@networkimprov https://github.com/networkimprov @ALTree
https://github.com/ALTree thanks, this is fine. If it doesn't make 1.15
it will probably want to be in the first minor release, but I don't think
it needs to be blocking.
@apmattil https://github.com/apmattil it is difficult to tell from the
stack trace. What was the panic message printed by that crash?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/40368#issuecomment-664477777, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE42IFHUMEMYDQPOAENZWPDR5WO33ANCNFSM4PFU4FEA
.

@apmattil If you are running 1.14.6, then the line number in the stack trace indicates it is this case: https://github.com/golang/go/blob/go1.14.6/src/runtime/proc.go#L4386
That is different from this bug, so you should file a separate issue for that.

I used 1.14.4 compiler
I do get the sched variable at frame 11:
'''
(dlv) frame 11

runtime.raise() /usr/local/go/src/runtime/sys_linux_amd64.s:165 (PC:
0x465511)
Warning: debugging optimized function
Frame 11: /usr/local/go/src/runtime/proc.go:4386 (PC: 440a12)
4381:         run := mcount() - sched.nmidle - sched.nmidlelocked -
sched.nmsys
4382:         if run > run0 {
4383:                 return
4384:         }
4385:         if run < 0 {
=>4386:                 print("runtime: checkdead: nmidle=", sched.nmidle,
" nmidlelocked=", sched.nmidlelocked, " mcount=", mcount(), " nmsys=",
sched.nmsys, "\n")
4387:                 throw("checkdead: inconsistent counts")
4388:         }
4389:
4390:         grunning := 0
4391:         lock(&allglock)
(dlv) p sched
runtime.schedt {
goidgen: 0,
lastpoll: 0,
pollUntil: 0,
lock: runtime.mutex {key: 0},
midle: 0,
nmidle: 0,
nmidlelocked: 0,
mnext: 0,
maxmcount: 0,
nmsys: 0,
nmfreed: 0,
ngsys: 0,
pidle: 0,
npidle: 0,
nmspinning: 0,
runq: runtime.gQueue {head: 0, tail: 0},
runqsize: 0,
disable: struct { runtime.user bool; runtime.runnable
runtime.gQueue; runtime.n int32 } {
user: false,
runnable: (*runtime.gQueue)(0x1367030),
n: 0,},
gFree: struct { runtime.lock runtime.mutex; runtime.stack
runtime.gList; runtime.noStack runtime.gList; runtime.n int32 } {
lock: (*runtime.mutex)(0x1367048),
stack: (*runtime.gList)(0x1367050),
noStack: (*runtime.gList)(0x1367058),
n: 0,},
sudoglock: runtime.mutex {key: 0},
sudogcache: *runtime.sudog nil,
deferlock: runtime.mutex {key: 0},
deferpool: [5]*runtime._defer [
*nil,
*nil,
*nil,
*nil,
*nil,
],
freem: *runtime.m nil,
gcwaiting: 0,
stopwait: 0,
stopnote: runtime.note {key: 0},
sysmonwait: 0,
sysmonnote: runtime.note {key: 0},
safePointFn: nil,
safePointWait: 0,
safePointNote: runtime.note {key: 0},
profilehz: 0,
procresizetime: 0,
totaltime: 0,}
(dlv)
'''

On Mon, Jul 27, 2020 at 10:47 PM GopherBot<EMAIL_ADDRESS>wrote:

Change https://golang.org/cl/245018 mentions this issue: runtime: ensure
startm new M is consistently visible to checkdead
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/40368#issuecomment-664601739, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE42IFG7YNPCCURGXF7466TR5XKVFANCNFSM4PFU4FEA
.

@apmattil thanks, that's helpful. I opened #40434, as that is a different issue.


kinase regulation

normal regulation of catalytic activity
normal positive regulation of protein kinase activity
abnormal regulation of catalytic activity
decreased positive regulation of protein kinase activity
abolished positive regulation of protein kinase activity
PMID:11402029

abnormal regulation of catalytic activity FYPO:0004916
decreased positive regulation of protein kinase activity FYPO:0004917
abolished positive regulation of protein kinase activity FYPO:0004918
abnormal regulation of molecular function FYPO:0004919
normal regulation of catalytic activity FYPO:0004920
normal positive regulation of protein kinase activity FYPO:0004921

edit file: efec7cd516c8799b2c97b8f32feb60b54f957b00
release: 19d729c9796e57e7f473149f79135db5f54c5999


updated link to checkpoints and staging tables page

Merge request template: please remove the appropriate parts of this template.
Pre-merge request checklist (to be completed by the one making the request):

[X] I have performed a full review of this code myself.

For Python code in PySpark specific sections, all code should have been run in Jupyter notebooks.
For code in sections of the book containing both Python and R code, the page of the book should be constructed as described in the contributing guide and converted to a markdown file.

[X] I have formatted the outputs of code blocks correctly (to match other outputs in the book and in line with the style guide [coming soon])
[X] I have built the book as outlined in the contributing guide and confirmed that any additional/modified content is displaying as expected.

Details of this request (such as):

Updated link from persistence page to checkpoint-staging page

Requirements for review (such as):

No code needs to be run as persistence page is only markdown
Build book and check persistence page is formatted correctly

closes #82


[Bugs] AMF rejecting the registration if 5GMM Capability info missing

Describe the bug
Procedure rejected if 5GMM Capability info missing in Registration Request message.
Expected behavior
According to 3GPP TS 24.501, the 5GMM Capability info in Registration Request message is optional.
Environment

free5GC Version: v3.0.4
OS: Ubuntu 200.04.1 Server
Kernel version: 5.4.0-48-generic
go version: go1.14.4 linux/amd64

PCAP File
free5gc_Missing_Capability5GMM.pcap.zip
Log File
AMF.log

Hi @bertuola ,
How to reproduce this issue?

Hi. I understand you can reproduce the scenario generating a request with missing Capability5GMM in the request. At my side, I am using a commercial simulator provided by Ixia.

Hi.
Thanks for the return.
I agree the 5GMM Capability information shall be included in the registration. Now, checking the traces, I don't see this info in clear, so I understand it is contained in UplinkNASTransport message, which has the content encrypted. I tried to enabled debugging at core side to check if it is was possible to have visibility about the content of this message to verify if this information was actually missing or there is an issue in decoding it.
Is there any way at Free5GC side to see the encrypted content of the NGAP messages?

Hi,
If you use 5G-EA0 as the NAS ciphering algorithm,
then you can configure wireshark to decode EA0 NAS messages
Open wireshark then go through Edit->Preferences -> Protocols -> enable the option "Try to detect and decode 5G-EA0 ciphered messages"

Hello there in TS 124.501 section 4.4.6 says
"The 5GS supports protection of initial NAS messages as specified in 3GPP TS 33.501 [24]. The protection of initial NAS messages applies to the REGISTRATION REQUEST and SERVICE REQUEST message, and is achieved as follows: a)   If the UE does not have a valid 5G NAS security context, the UE sends a REGISTRATION REQUEST message including cleartext IEs only. After activating a 5G NAS security context resulting from a security mode control procedure: 1)  if the UE needs to send non-cleartext IEs, the UE shall include the entire REGISTRATION REQUEST message (i.e. containing both cleartext IEs and non-cleartext IEs) in the NAS message container IE and shall include the NAS message container IE in the SECURITY MODE COMPLETE message"
And in the same section we have seen that the cleartext IEs of REGISTRATION REQUEST message are:
"When the initial NAS message is a REGISTRATION REQUEST message, the cleartext IEs are:

Extended protocol discriminator;
Security header type;
Spare half octet;
Registration request message identity;
5GS registration type;
ngKSI;    -    5GS    mobile    identity;
-    UE security capability;
Additional    GUTI;
UE status; and -
EPS NAS message container. "

It can also be observed in TS 33.501 in section 6.4.6 where there is a message flow figure

As it is observable in the first Initial Message in step 1. The message should carry also the non-cleartext IEs so if the MAC fails the AMF should put the bit RINMR to 1 so the UE will retransmit the initial NAS message in the Security mode complete.
Step 3: After a successful authentication of the UE, the AMF shall send the NAS Security Mode Command message. If the initial NAS message was protected but did not pass the integrity check  (due either to a MAC failure or the AMF not being able to find the used security context) orthe AMF could not decrypt the complete initial NAS message in the NAS container, then the AMF shall include in the Security Mode Command message a flag requesting the UE to send the complete initial NAS message in the NAS Security Mode Complete message. "
The use case of the bit RINMR is in TS 24.501 <IP_ADDRESS> or in <IP_ADDRESS>:
"If, during an ongoing registration procedure, the AMF is initiating a SECURITY MODE COMMAND (i.e. after receiving the REGISTRATION REQUEST message, but before sending a response to that message) and the REGISTRATION REQUEST message does not successfully pass the integrity check at the AMF, the AMF shall include the Additional 5G security information IE with the RINMR bit set to "Retransmission of the initial NAS message requested" in the SECURITY MODE COMMAND message requesting the UE to send the entire REGISTRATION REQUEST message in the SECURITY MODE COMPLETE message as described in 3GPP TS 33.501 [24]."
"If, during an ongoing registration procedure or service request procedure, the SECURITY MODE COMMAND message includes the Additional 5G security information IE with the RINMR bit set to "Retransmission of the initial NAS message requested", the UE shall include the entire unciphered REGISTRATION REQUEST message or SERVICE REQUEST message, which the UE had previously included in the NAS message container IE of the initial NAS message (i.e. REGISTRATION REQUEST message or SERVICE REQUEST message, respectively), in the NAS message container IE of the SECURITY MODE COMPLETE message."

I verified the info you provided and I confirm the Ixia simulator is not sending the 5GMM Capability information element. I opened a ticket to them. Really thanks for your support. This issue can be closed.


Run on Apple Mac Silicon chip

I found that the current problem can only run on CPU  model on Apple silicon chip. I don't know if the GPU method which is 'mps' can be added.  I set the parameters as mps, but it didn't work.

Hey! This code was only tested using NVIDIA GPUs, I believe they have a guide for PyTorch here: https://developer.apple.com/metal/pytorch/ :)

Hey! This code was only tested using NVIDIA GPUs, I believe they have a guide for PyTorch here: https://developer.apple.com/metal/pytorch/ :)

Created a pull request to address this

I checked out the code from the pull request and tried to run it. It's been going most of the weekend on my Mac. :)
Specifically on these commands
# Prepare NanoGPT data
python data/enwik8/prepare.py
python data/shakespeare_char/prepare.py
python data/text8/prepare.py

Do these even need to be run? I am curious what is the actual minimal command set of most of the AI work is actual done through OpenAI, etc...

These commands run the baseline which should be machine dependent for things like training speed!

Right, but I am not using a machine with a GPU. I want to offload as much of this as possible to a third-party tool (Colab? Some other service that has a GPU?).
So the fact that this dependency exists is kind of a blocker for usage.
Maybe there's something else I am missing about what this is for?

I think modern machine learning is quite hard without a GPU. Later experiments will attempt dozens of runs which could take hours each without a GPU. I would recommend services like lambda where you can rent GPUs per hour.

Why not use GPT4o-mini/Claude instead of a local nanogpt? Not totally sure of the value here for a hybrid approach given the cost of cutting off mac users since we're already providing API keys. .

Additionally, is it REALLY a dependency? It looks like it creates an artifact that is used later when you’re using the GPT4o-mini.
Is that artifact actually a requirement for subsequent steps?

Why not use GPT4o-mini/Claude instead of a local nanogpt? Not totally sure of the value here for a hybrid approach given the cost of cutting off mac users since we're already providing API keys. .

GPT4o/Claude is the foundation model that proposes ideas. NanoGPT is the actual model that is modified and trained. This is a different model for different templates.

Additionally, is it REALLY a dependency? It looks like it creates an artifact that is used later when you’re using the GPT4o-mini.
Is that artifact actually a requirement for subsequent steps?

The preparation steps create the training data and baseline for comparison. Very much essential.


RequestPart annotation

Hello,
why RequestPart annotation  is not included for spring-web dependency?
Thanks

Because it's functionality isn't currently supported

Because it's functionality isn't currently supported


Add support for websocket_tail output

Would you consider to add WebSocket output with functionality alike https://github.com/allinurl/gwsocket (allowing message trashing in case there is not any client) to be able to watch/check stream output just from web browser please ?

Hey @muhlpachr, if there are multiple clients connected would you expect messages to be broadcast to all of them?
There's a possibility of adding an output mechanism to wrap http_server, where if it doesn't accept a transaction the message is dropped, which would get you partially there. However, I'd need to implement a different mechanism for publishing messages to N clients.

@Jeffail yes, if there are multiple clients connected, I would like to broadcast message to all of them like https://github.com/allinurl/gwsocket.
It would be nice to be able to do that without additonal component like gwsocket.
I do understand, that adding (publishing over http server) client JavaScript terminal together with WebSocket is not usual stream processing output. I consider it useful for troubleshooting and debugging.
Streaming through HTTP GET is limited by web browser timeouts for GET and it also do not reconnect autonomously from web browser in case of connectivity troubles.
What kind of wrap for http_server do you mean please ?


Add files via upload

It's a C implementation of NTRUEncrypt, this was a school project so surely it can be optimized or it may contained untested error that I didn't see. However it works fine.

The algorithm looks good. I am sure others will appreciate your code.
Suggested changes:

Can you update the README.md too by adding an introduction of this method in the "Algorithm Introduction section"?
Add a markdown file in your directory explaining the encryption method and how the code works.

That will be very helpful for others to understand your code.


Update CONTRIBUTORS.md

first open source pull request

Hey there,
Thanks for your PR & contribution :wave:!
Don't forget to join follow me, join our organization, & follow our organization to stay updated with the latest developments 💻
Thank you, and have a good day ahead 😊

Before you go, I have a little surprise for you :)
@holopin-bot @# do your thing 🤖


Mobile Engagement SDK release iOS 2.2.0 and WinRT 3.1.0

Hi there,
New ME SDKs release !
ME iOS v2.2.0 and ME Win Universal 3.1.0
Regards,

Hi @clpolet, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (clpolet). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Queries installed using installQueries = true are not included

Consider this overlay:
final: prev: {
  vimPlugins = prev.vimPlugins // {
    nvim-treesitter-parsers = prev.vimPlugins.nvim-treesitter-parsers // {
      nu = prev.vimPlugins.nvim-treesitter-parsers.nu.overrideAttrs {
        installQueries = true;
      };
    };
  };
}

Results into
$ ls /nix/store/n94w0bbsb1qpkjipqc726qkh4670l26g-vimplugin-treesitter-grammar-ALL-INCLUDED
/nix/store/n94w0bbsb1qpkjipqc726qkh4670l26g-vimplugin-treesitter-grammar-ALL-INCLUDED/parser

Looks like overlays for nvim-treesitter-parsers generally don't work, setting src to something illegal (e.g. hash = "") didn't produce an error

https://github.com/BirdeeHub/nixCats-nvim/blob/c1507cc417534ea657b03fcdb6859abe6a00c8d5/builder/vim-pack-dir.nix#L97-L110
^ What happens if you set the setting collate_grammars = false;
There are 2 ways grammars are processed by nixCats.

if collate_grammars is true, all grammars with a name matching (builtins.match "^vimplugin-treesitter-grammar-.*" "${lib.getName drv}") != null; will be combined via symlinkJoin like so

    ts_grammar_plugin_combined = symlinkJoin {
      name = "vimplugin-treesitter-grammar-ALL-INCLUDED";
      paths = map (e: e.outPath) collected_grammars;
    };

if collate_grammars is false, all grammars with a name matching (builtins.match "^vimplugin-treesitter-grammar-.*" "${lib.getName drv}") != null; will be simply added to pack/myNeovimGrammars/start with no modifications.

nu seems to not be throwing errors for me but it doesnt include queries either? I will do more testing myself but I would be interested to know what you see if you set collate_grammars = false for your package

This was a bug in nixpkgs, nvim-treesitter.withAllGrammars doesn't support overrides. Filing a PR rn


Lab2/bubblesort

Fixes #42
Changes proposed in this PR:
bubblesort implementation with unit testing

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #51   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      3    +1
  Lines           9     24   +15
=====================================
+ Hits            9     24   +15

Impacted Files
Coverage Δ

02_bubblesort/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f263dc...fc61d4a. Read the comment docs.

Click Update branch and locally git pull origin lab2 before adding new commits.
Please fix up PR description according to template
Fix broken build
Please edit your commits to follow recommendations

Capitalize the subject line
Use the imperative mood in the subject line
Fold fixup commits into previous ones with git rebase -i HASH

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


Set up semantic-release

Description of Issue
For the purposes of automatic release, set up semantic-release to automatically evaluate commits and create releases on github & npm.
Expected Outcomes

[ ] Add travis stages & jobs for lint/test/release
[ ] Set up GH_TOKEN and NPM_TOKEN on travis so that the releases can be automated.
[ ] Do our first automated release through semantic-release

Okay, I have been thinking about this quite a bit.  I think we should do this.  However, I wanted to see what you thought about having a separate release branch for the plugin to automatically run against?  Basically we make all of our commits to master as normal and then when we want to cut a release, we just fast-forward the release branch and let Travis and semantic-release do their thing.
For this repo, I think we could get away with releasing every time we push to master, but I am looking for a process that we can easily apply to cucumber-forge-desktop as well.  For CFD I don't think we want to be cutting releases super often (even if we get the process fully automated) because the updates are visible to the app users and we don't want to bombard them.

I don't think it makes sense, personally, for features to ever not be released. Or fixes, for that matter.

Okay, just want to record the results of an offline conversation that @TobiTenno and I had.  Basically the plan is to not use semantic-release on CFD.  We are concerned that it will not play well with electron-forge (e.g. not sure about the ramifications of the package.json version not getting updated).
For cucumber-forge-report-generator we can use semantic-release and run it as normal against the master branch.

:tada: This issue has been resolved in version 0.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implement Dark Mode for explanation.show_in_notebook method

Implement dark mode for explanation.show_in_notebook method by post-processing the formatted HTML.
Without this, in a notebook that is rendered in dark mode, the text is scarcely legible.
Example (from tutorial):

So is this resolved or not @ajwells128  ?

So is this resolved or not @ajwells128 ?

The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish.

hello
what's this about?

From: ajwells128 @.>
Sent: 20 December 2023 14:40
To: marcotcr/lime @.>
Cc: Subscribed @.***>
Subject: Re: [marcotcr/lime] Implement Dark Mode for explanation.show_in_notebook method (PR #728)
So is this resolved or not @ajwells128https://github.com/ajwells128 ?
The PR is still open and has been unreviewed as far as I know. The code worked just fine last I checked it, not sure if any changes have been made since then. I don't have permission to merge the PR, though. If you are interested in benefitting from dark mode yourself before the PR merges, you can install the package in the usual way and then make these changes to the library files if you wish.
—
Reply to this email directly, view it on GitHubhttps://github.com/marcotcr/lime/pull/728#issuecomment-1864588607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APH5BTK54AUXITSPKYX2Y5TYKL2HLAVCNFSM6AAAAAA3AFGJMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGU4DQNRQG4.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


STYLE: blackify, remove unused code/parameters

Removed a bunch of config parameters thatweren't used anyways and deleted an unnecessary loop in predict.py (line 236). And black did its thing.

🤘


imap: command not found

I'm stuck on this problem, could you tell me how to solve it?

I also run it outside the docker container.

The reason is you didn't install imap
Install imap first
pip3 install imap_box

Thanks, the problem is solved


SAML should set authority_id and lookup users by it

Describe the bug
With Accounts.authority_id in the database and CiviFormProfile.setAuthorityId() available, SamlCiviFormProfileAdaptor should call it with an appropriate ID that will never change for the logged in user.  As in OIDC #2049
Likewise SamlCiviFormProfileAdapter.java needs to search for auth primarily as in OIDC #2104

@shubha-rajan can you point me at how I can I get the unique ID for SAML in SamlCiviFormProfileAdapter as I do in OIDC here . and ideally to a SAML spec that identifies it as an unchangeable identifier.

@zaralouis-sf want to link your PR here?

Fixed by PR #2120

Fixed by PR #2120


basic GitHub Actions

https://github.com/peterbecich/codeworld/actions/runs/1207921115
This doesn't run the tests; I'll try to do that later

I am trusting you on this, because I know nothing about GitHub actions.


[BUG] List of Enum arguments have an extra wrong argument

Describe the bug
The parsed /docs page includes  a "--" option which leads to an invalid query when using an Enum derived class.
To Reproduce

Create a file with:

import enum
from fastapi import FastAPI

app = FastAPI()

class Fruit(str, enum.Enum):
    apple: str = "APPLE"
    pear: str = "PEAR"
    banana: str = "BANANA"
    strawberry: str = "STRAWBERRY"

@app.get("/fruit", response_model=List[Fruit])
async def list_fruit(fruits: List[Fruit] = Query(None)):
    return fruits

Then call the http method with the "--" option
Expected behavior
Would expect the same behavior of not having specified any query argument fruits at all.
Error
The error message:
{
  "detail": [
    {
      "loc": [
        "query",
        "fruits",
        0
      ],
      "msg": "value is not a valid enumeration member; permitted: 'APPLE', 'PEAR', 'BANANA', 'STRAWBERRY'",
      "type": "type_error.enum",
      "ctx": {
        "enum_values": [
          "APPLE",
          "PEAR",
          "BANANA",
          "STRAWBERRY"
        ]
      }
    }
  ]
}

Screenshots

Environment

OS: Windows
FastAPI Version 0.54.1
Python version: 3.7.4

Additional context
Add any other context about the problem here.

I may be wrong but this appears to be a Swagger UI issue, not anything specific to fastapi

Thanks for the help here @obataku !
Yeah, that would probably be an issue to report to Swagger UI, it doesn't really depend on FastAPI.

Here is a potential work around:
In your Enum add a new value called none (or something equivalent) that is set to an empty string ''. Now when you select the -- value in swagger the endpoint will perform as expected.
The only problem with this is that when you select the -- it now selects the empty string as well (so two options are highlighted).

While not breaking or anything this is confusing from a usability perspective.


Keep intersphinx objects.inv after build

Closes #153
It looks like ever since the HTML generation was "cleaned" to reduce upload size it has been deleting the objects.inv file. This is needed by any other sphinx project that would like to link to pyviz documentation more easily using the intersphinx extension.
This PR removes objects.inv from the delete list. I wasn't sure if you would like the entire loop to be removed so I made it an empty tuple for now.

Thanks, and sorry we didn't get to this sooner.

Looks like there's a test that needs updating. Happy to do it if you're too busy.

Done and did it through the github UI for style points.

Thanks!


Review annotation object plan

Do an exercise with annotation objects (not just annotation properties) and make sure that they work reasonably as we are expecting.

There is an example in libSBOL of an extension object here:
https://github.com/SynBioDex/libSBOL/blob/master/wrapper/unit_tests.py#L473


Don't use error output from prettier_d for fixing files

prettier_d has the same problem as eslint_d where errors are output via stdout instead of stderr.
This PR ports the eslint fix for #1178 to fix the problem for prettier_d.

Cheers! :beers:


Added more Flex-related styles.

Hello there!
First of all, thank you for awesome work!
By this PR I'm adding some more flex styles:
flex-grow, flex-shrink, flex-basis and flex shorthand.
There is nothing special in this changes, but I'd like to clearify one moment.
When I added flex shorthand and write tests on it, none of them was 'green'. It turns out, that setting flex shorthand value, for example, 0 1 250px would give output 1 1 250px. Flex-grow is being reassigned by flex-shrink value, because it is absolutly valid for it and their type and possible values are identical.
To resolve this confusion I decided to pass shorhand part's index as second parameter in subprop isValid function while runnig shorthandParser. Now it works fine. Tests prove it.
Nonetheless, if you'll see this solution as not clear enough, I'll gladly fix or rewrite this according to your advice :)
Hope it helps somehow.
Best regards

Thanks for the PR!
Moved to https://github.com/jsakas/CSSStyleDeclaration/pull/80 so I could resolve conflicts.


Added MSFT_xNetworkTeamInterface resource

Added the following resources:

MSFT_xNetworkTeamInterface resource to add/remove network team interfaces

Added conditional loading of LocalizedData to MSFT_xHostsFile and MSFT_xNetworkTeam to prevent failures while loading those resources on systems with $PSUICulture other than en-US

This change is

Hi @rakkhin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Are you able to create Unit tests as well for the xNetworkTeamInterface resource?
Are we able to add some examples of using this Resource (both in the Readme.md and in the Examples folder) - especially in conjunction with using the xNetworkTeam resource?
This is a great job BTW and a very long needed resource! Thank you very much for submitting it!

Reviewed 6 of 6 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

DSCResources/MSFT_xHostsFile/MSFT_xHostsFile.psm1, line 4 [r2] (raw file):

if (Test-Path "${PSScriptRoot}\${PSUICulture}")
{
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xHostsFile.psd1 -BaseDirectory "${PSScriptRoot}\${PSUICulture}"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xHostsFile/MSFT_xHostsFile.psm1, line 9 [r2] (raw file):

{
    #fallback to en-US
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xHostsFile.psd1 -BaseDirectory "${PSScriptRoot}\en-US"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeam/MSFT_xNetworkTeam.psm1, line 4 [r2] (raw file):

if (Test-Path "${PSScriptRoot}\${PSUICulture}")
{
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xNetworkTeam.psd1 -BaseDirectory "${PSScriptRoot}\${PSUICulture}"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeam/MSFT_xNetworkTeam.psm1, line 9 [r2] (raw file):

{
    #fallback to en-US
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xNetworkTeam.psd1 -BaseDirectory "${PSScriptRoot}\en-US"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 4 [r2] (raw file):

if (Test-Path "${PSScriptRoot}\${PSUICulture}")
{
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xNetworkTeamInterface.psd1 -BaseDirectory "${PSScriptRoot}\${PSUICulture}"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 9 [r2] (raw file):

{
    #fallback to en-US
    Import-LocalizedData -BindingVariable LocalizedData -filename MSFT_xNetworkTeamInterface.psd1 -BaseDirectory "${PSScriptRoot}\en-US"

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 95 [r2] (raw file):

                else
                {
                    Set-NetLbfoTeamNic -Name $Name -Team $TeamName -VlanID $VlanID -ErrorAction Stop -Confirm:$false -PassThru `

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 107 [r2] (raw file):

                if ($VlanID -ne 0)
                {
                    $null = Add-NetLbfoTeamNic -Name $Name -Team $TeamName -VlanID $VlanID -ErrorAction Stop -Confirm:$false

Is it possible to get this line down to less than 100 chars? Thank you! :smile:

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 117 [r2] (raw file):

            catch
            {
                $errorId = "TeamNicCreateError"

Could we move this code into the else block above remove the try...catch block entirely? It seems like we might be obfuscating any other possible errors that might occur here while creating the team.

Tests/Integration/MSFT_xNetworkTeamInterface.Integration.Tests.ps1, line 8 [r2] (raw file):

$Global:teamMembers        = (Get-NetAdapter -Physical).Name

#region HEADER

Can you please update the header to the latest version from the template here https://github.com/PowerShell/DscResources/blob/master/Tests.Template/integration_template.ps1

Comments from Reviewable

Review status: 4 of 9 files reviewed at latest revision, 10 unresolved discussions.

DSCResources/MSFT_xHostsFile/MSFT_xHostsFile.psm1, line 4 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xHostsFile/MSFT_xHostsFile.psm1, line 9 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeam/MSFT_xNetworkTeam.psm1, line 4 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeam/MSFT_xNetworkTeam.psm1, line 9 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 4 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 9 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 95 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 107 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Is it possible to get this line down to less than 100 chars? Thank you! :smile:

Done.

DSCResources/MSFT_xNetworkTeamInterface/MSFT_xNetworkTeamInterface.psm1, line 117 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Could we move this code into the else block above remove the try...catch block entirely? It seems like we might be obfuscating any other possible errors that might occur here while creating the team.

Done.

Tests/Integration/MSFT_xNetworkTeamInterface.Integration.Tests.ps1, line 8 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Can you please update the header to the latest version from the template here https://github.com/PowerShell/DscResources/blob/master/Tests.Template/integration_template.ps1

Done.

Comments from Reviewable

Nice work! Thanks @rakkhin! Really appreciate the work you put in here. @Tysonjhayes, this one is looking pretty good to me. Any chance you could give it a review when you get a moment and throw a merge our way? :smile:

Reviewed 9 of 9 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Hi @rakkhin - there are some merge conflicts to fix on this PR before it can be merged. Are you able to resolve so I can get @tysonjhayes to look it over and merge it for you? Thanks!

@rakkhin - are you able to take a look at the merge conflicts so someone can merge this for you?

Sorry it took me so long, should be ok now. Let me know if there's anything else I should do.

No worries @rakkhin - thanks for submitting the change! @Tysonjhayes, are you able to give this a once over and merge? Thank you!

Reviewed 1 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

I reviewed the schema and it looks good.

Reviewed 1 of 6 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Bug: Value is out of bounds when trying to connect to same peripheral twice

Noticed an interesting bug where if you try to connect to the same peripheral twice, noble generates an error in the buffer saying "Command Disallowed", and enters a state of non-action. HCI doesn't generate any other events after entering this state.

This also seems to happen when trying to connect to a non-existent peripheral.
Here's the stacktrace:
TypeError: value is out of bounds
at TypeError ()
at checkInt (buffer.js:705:11)
at Buffer.writeUInt16LE (buffer.js:722:5)
at Hci.disconnect (/home/root/badge-state-viewer/noble/lib/hci-socket/hci.js:290:7)
at NobleBindings.disconnect (/home/root/badge-state-viewer/noble/lib/hci-socket/bindings.js:57:13)
at Noble.disconnect (/home/root/badge-state-viewer/noble/lib/noble.js:164:18)
at Peripheral.disconnect (/home/root/badge-state-viewer/noble/lib/peripheral.js:57:15)
at disconnectPeripheral (/home/root/badge-state-viewer/lib/sync-manager.js:417:20)
at null._onTimeout (/home/root/badge-state-viewer/lib/sync-manager.js:352:13)
at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

also seeing this in the hcidump:
2016-03-13 09:11:25.260164 < HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:10:05:2E type 0
interval 96 window 48 initiator_filter 0
own_bdaddr_type 0 min_interval 6 max_interval 12
latency 0 supervision_to 200 min_ce 4 max_ce 6
2016-03-13 09:11:25.261513 > HCI Event: Command Status (0x0f) plen 4
LE Create Connection (0x08|0x000d) status 0x0c ncmd 1
Error: Command Disallowed

Actually realized it was my problem! I was trying to disconnect with a peripheral when there was no connection, resulting in an error. I have another question though, which is how to cancel a connection attempt by peripheral.connect()?

https://github.com/sandeepmistry/noble/issues/229 is currently tracking the ability to cancel a connection, it is not supported yet.


Failed to load the dill form

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Can you please provide more information about the error you're getting? Perhaps attach a screenshot to see what's going on?


[Bug]: SMTP: Mail is not getting sent while the response is "Sent the email successfully" in a certain case

Is there an existing issue for this?

[X] I have searched the existing issues

Description
SMTP: Mail is not getting sent while the response is "Sent the email successfully" in a certain case where the user gives some extra characters in the "to emails" text box.
Steps To Reproduce
Steps:

Configure a valid SMTP datasource
create a query
drag an input box on the canvas and put an email id into it
take the input box reference in the "to emails" text box {{Input4.text}}
Now, add a extra character like - {{Input4.text}}a
Run the query
Observe - The response is - {
"message": "Sent the email successfully"
}

However, the message is not sent.
Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/ac4c199579594274a6308a39eb0a5eae
Version
1.9.12

@AnandShahs123 please share an application where we can reproduce this by checking the credentials

@Nikhil-Nandagopal - Please find the application link. https://app.appsmith.com/app/smtp/page1-6415790d1d9c1f2f557b4cf0
password is - gmqecnsffqkgjvpq


Cannot import resources.sql

Windows 10
MySQL server 5.5 x64
Cannot install onlyoffice.resources.sql

MySQL server has gone away

Changing option like max_allowed_packet or wait_timeout does not help.

It looks like your server does not have enough hardware. Do you use ssd or hdd? And we supported only Windows Server OS, see our helpcenter https://helpcenter.onlyoffice.com/server/windows/community/compile-source-code.aspx

I have SSD.
Do you think this can be caused by OS?
Which version of MySQL server do you suggest to use? Your documentation state that supported from 5.5.
Per description and requirements for local compiling it looks that technically it's possible to run CommunityServer also on personal versions of Windows...

What utility do you use to run the sql scripts? Please try in MySQL Command Line Client, and take screenshot if something goes wrong.

I have tried Devart dbForge (some very old and latest versions) and MySql Command line client – same result.

Closed for a reason - there has been no activity for a long time.


Installation of Sourcery 2.1.4 with mise fails

Describe the bug
The installation of Sourcery 2.1.4 with mise fails with the following error:
asdf-sourcery: Expected /Users/jgonzalez/.local/share/mise/installs/sourcery/2.1.4/bin/sourcery to be executable.
asdf-sourcery: An error ocurred while installing sourcery 2.1.4.
mise ~/.local/share/mise/plugins/sourcery/bin/install exited with non-zero status: exit code 1
mise Run with --verbose or MISE_VERBOSE=1 for more information

Steps to reproduce
mise install<EMAIL_ADDRESS>
Expected behavior
Sourcery should be properly installed when the command finishes running. Please note that this problem doesn't appear with Sourcery 2.1.3, which can be properly installed using the same command:
mise install<EMAIL_ADDRESS>
Additional context
Running mise doctor doesn't show any error:

mise doctor ouput
mise version:
  2024.1.24 macos-arm64 (de37513 2024-01-20)

build:
  Target: aarch64-apple-darwin
  Features: DEFAULT, NATIVE_TLS, OPENSSL
  Built: Sat, 20 Jan 2024 02:49:42 +0000
  Rust Version: rustc 1.75.0 (82e1608df 2023-12-21)
  Profile: release

shell:
  /bin/zsh
  zsh 5.9 (x86_64-apple-darwin23.0)

mise data directory:
  /Users/jgonzalez/.local/share/mise

mise environment variables:
  MISE_SHELL=zsh

settings:
  {
    "activate_aggressive": false,
    "all_compile": false,
    "always_keep_download": false,
    "always_keep_install": false,
    "asdf_compat": false,
    "cargo_binstall": true,
    "color": true,
    "disable_default_shorthands": false,
    "disable_tools": [],
    "experimental": false,
    "jobs": 4,
    "legacy_version_file": true,
    "legacy_version_file_disable_tools": [],
    "node_compile": false,
    "not_found_auto_install": true,
    "paranoid": false,
    "plugin_autoupdate_last_check_duration": "7d",
    "python_compile": false,
    "python_default_packages_file": "/Users/jgonzalez/.default-python-packages",
    "python_patch_url": null,
    "python_precompiled_os": null,
    "python_patches_directory": null,
    "python_precompiled_arch": null,
    "python_pyenv_repo": "https://github.com/pyenv/pyenv.git",
    "python_venv_auto_create": false,
    "raw": false,
    "shorthands_file": null,
    "task_output": null,
    "trusted_config_paths": [],
    "quiet": false,
    "verbose": false,
    "yes": false,
    "ci": false,
    "cd": null,
    "debug": false,
    "env_file": null,
    "trace": false,
    "log_level": "info"
  }

config files:
  ~/.config/mise/config.toml

plugins:
  bun        (core)
  deno       (core)
  go         (core)
  java       (core)
  node       (core)
  python     (core)
  ruby       (core)
  scala      https://github.com/asdf-community/asdf-scala.git#6de4edb
  sourcery   https://github.com/younke/asdf-sourcery.git#1ddd8f1
  tuist      https://github.com/asdf-community/asdf-tuist.git#0b8a7dd

toolset:
  java@temurin-21, <EMAIL_ADDRESS>scala@latest, tuist@latest

No problems found

I just installed 2.1.7 and it worked properly. Maybe some problem with that specific Sourcery release?

@jgongo yeah, probably something with executable itself or mise checking routine
* Downloading sourcery release 2.1.4...
Archive:  /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4.zip
   creating: /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4/
  inflating: /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4/LICENSE
   creating: /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4/bin/
  inflating: /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4/bin/ejs.js
  inflating: /Users/username/.local/share/mise/installs/sourcery/2.1.4/sourcery-2.1.4/bin/sourcery


Improve performance when item is prepended to list

Elm solves this using keyed nodes, React using key attributes, but I didn't find anything similar in Fabulous. Did I miss something or is it not implemented yet?

No you are correct, nothing like this has been implemented.
Please see performance notes on current approaches to optimising performance - Currently list views are optimised for appending rather than prepending.
We accept PRs though if it something you need and fancy having a go at it 😄

The alternative is to play around with Layout.RaiseChild and Layout.LowerChild, but in an Elmish architecture that's something I don't really want to play around with.
I'll see if I have the time, energy and skills to put together a PR, thanks.

I think adding an equivalent to key nodes is an important part of "completing the picture" for Fabulous and bringing it on-par with React and Elm

With Fabulous and Fabulous.XamarinForms now separated, we will need to write a new framework agnostic view diffing algorithm.
It will lead to a lot of rewrite, we should take this chance to implement keyed nodes

For anyone looking for workarounds, using isVisible can achieve a partial effect.
Instead of:
View.StackLayout [
    if condition then
        View.BoxView Color.Aqua
    View.BoxView Color.Yellow
]

use
View.StackLayout [
    View.BoxView Color.Aqua |> isVisible condition
    View.BoxView Color.Yellow
]

So that the view will not be destroyed and recreated whenever condition changes.

Closing. It is now available in 0.55 (still preview), albeit performance still need improvements before releasing it as stable.


Why doesn't this class support division and modulus?

This class has addition ,subtraction and multiplication right now, but just out of curiosity, is there any reason that (integer) division and modulus are missing?

There's an open PR on division https://github.com/kasparsklavins/bigint/pull/18. Havent yet had the time to fully go through it and test it.


change version overview to compact

The version overview is currently a long list with a lot of noise (several mentions of "version").

[x] Compact the display to something like:

# cpp-devbox 1.0.4 (2024-07-04)

Name:  Debian 12 Bookworm with Vulkan-SDK
Image: ghcr.io/jakoch/cpp-devbox:bookworm-with-vulkansdk-latest

## Version Overview

GCC         12.2.0, 13.2.0
Clang       17.0.6
Vulkan-SDK  1.3.283.0
Ninja       1.11.1
cmake       3.30.0
ccache      4.10.1
vcpkg       2024-06-10-02590c43
Mold        2.32.1
ldd         2.36
lldb        17.0.6
valgrind    3.19.0
cppcheck    2.10
git         2.39.2

[ ] place a versions.md file into the devbox
[x] find out, if its possible to push this file as an artifact to Github

run script inside container and use output mapping?

docker run --rm -v $(pwd)/output:/output show-tool-versions.sh

Transition from using README.md files for version tracking
to a dynamically updated website that displays release tags, their images, and the versions.

[ ] Convert version information from Markdown to JSON format.
[ ] Create and push a static index.html to the gh-pages branch.
[ ] Implement JavaScript to load and display data from versions.json.

[ ] Ensure versions.json lists the filenames of the JSON files with version data.

[ ] Update versions.json post-image build to include the new tag-specific JSON file.

[ ] Ensure each tag-specific JSON file (e.g., version-tag.json) includes repository version tags, image tags, and version data.


fix: Some minor fixes for voting

Some proposal fixes for #28
This merges into #28 not MAIN!

Thanks for the recommendations, I included some of them in my branch, nonetheless:

All the controller integration tests fail when using hasItem instead of equalTo
I prefer not populating the database with scripts, I'd rather use the tests to configure my scenarios.


Missing information on Azure Backup Vault

I would expect this page to also show the support limits on Azure Backup Vault. Right now, it only shows the Azure Recovery Vault limits.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5f33a676-6bb6-949f-3bf4-bb0f9a8297d0
Version Independent ID: 9a31c4c4-f191-1298-cdbf-be70e59f4578
Content: Azure Backup support matrix - Azure Backup
Content Source: articles/backup/backup-support-matrix.md
Service: backup
GitHub Login: @AbhishekMallick-MS
Microsoft Alias: v-abhmallick

@sjoerdhooft
Thanks for your feedback! We will investigate and update as appropriate.

@sjoerdhooft  the maximum limit for Backup Vault is 500 per subscription similar to Recovery Services Vault.

@sjoerdhooft - We have updated the doc to mention the supported Backup vaults limit in a subscription. Closing this thread as the doc update is complete. Thanks.
@rajats22 - thanks for sharing the information.
#please-close


feat: implement whitelist fast node config osmosis side

Closes: #XXX
What is the purpose of the change
This PR implements the following config Osmosis side:

It allows us to realize the sync speed benefits of IAVL v1 w/o fast nodes, while keeping fast nodes for lockup so we still have a faster epoch.
NOTE: When backporting, some of these changes should be reverted, because this bumps the cosmos sdk fork version for main, which includes state breaking changes. So we need to ensure when backporting we use the respective v23 sdk branches.
Testing and Verifying
Tested against osmosis mainnet
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

Summary by CodeRabbit

Refactor

Updated test suite setup functions for improved testing capabilities.

New Features

Added support for IAVL fast node module whitelist settings.

@coderabbitai pause

Changelog entry already added here https://github.com/osmosis-labs/osmosis/blob/7d8c519b344458d0783d3e48fc9089ab353817fa/CHANGELOG.md#L76


Fix env search order

Description
The env() common function has a different order of searching environment variables as compared with DotEnv and BaseConfig. The latter two searches in the following order: $_ENV, $_SERVER, getenv. While for env() it searches this way: getenv, $_ENV, $_SERVER.
While this may be trivial for some, this may impact Windows systems with regard to resolving binary strings in the environment. Pending resolutions of PRs #3361 and #3362, this may affect Windows users getting the encryption key via env('encryption.key') and later will get an encryption failed error because it did not match with the configured encryption.key in .env file.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Travis error unrelated. Looks good. Merging.


Optimizer: remove the ArrayElementPropagation optimization

Instead, improve load-simplification and redundant-load-elimination so that those optimizations can do what ArrayElementPropagation did.
Therefore ArrayElementPropagation is not needed anymore.
ArrayElementPropagation also performed a second optimization: replace Array.append(contentsOf:) with individual Array.append calls. But the benefit of this optimization is questionably, anyway. In most cases it resulted in a code size increase. So makes sense to remove it without a replacement.

@swift-ci test

@swift-ci benchmark

@swift-ci test linux

@swift-ci test linux

@swift-ci test

@swift-ci benchmark

@swift-ci test


URLs cannot be clicked using "displayCommentAsIcon"

If  "displayCommentAsIcon" is being used I am not able to click URLs anymore.
Reproduceable (un)commenting "displayCommentAsIcon". Doesn't matter whether being used with "highlightSelectedText".
No error in log.
EDIT: packages installed: "ep_page_view" and "ep_comments_page". Removed everything else to avoid conflicting plugins

"ep_comments_page": {
  "displayCommentAsIcon": true
},

is totally broken.


Gssoc'23 previous and next button do not work properly

Give a brief about the bug ✍
at last page of games after clicking next button it should go to the first page.
and at begining when you press previous button it should go to the last game page.

What is the expected behavior? 🤔
at last page of games after clicking next button it should go to the first page.
and at begining when you press previous button it should go to the last game page.
Provide step by step information reproduce the bug 📄
assign it to me I will fix this issue
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @aditya-stoic-sharma! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .

Hey @aditya-stoic-sharma ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @aditya-stoic-sharma !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


feat: add new design for Our Team Section

Fixes Issue
resolves #2176
Changes proposed

Contributors

@rupali-codes
Done!
Just to let you know, we need to synchronize the dev branch from main. Otherwise, there will be huge conflicts.

The error is still there

The error is still there

It needs authorization to deploy.
@rupali-codes

I will do it after the exam (28th) :)

@rupali-codes
It was not even my fault. Definitely caused by someone else since overall height was somewhat higher resulting in scrollbar.

I only did because you requested.
Fixed:

@rupali-codes It was not even my fault. Definitely caused by someone else since overall height was somewhat higher resulting in scrollbar.

I only did because you requested.
Fixed:

How can the scrollbar be removed @Anmol-Baranwal?

How can the scrollbar be removed @Anmol-Baranwal?

For accessibility purpose, browsers tend to show scrollbars when there is space to scroll in the viewport height.
If the whole container occupies full height, there will be no extra gap, and no scrollbar :)
Mission accomplished!

How can the scrollbar be removed @Anmol-Baranwal?

For accessibility purpose, browsers tend to show scrollbars when there is space to scroll in the viewport height.
If the whole container occupies full height, there will be no extra gap, and no scrollbar :) Mission accomplished!

I see

@rupali-codes
Does this need any more changes?
Is there a deployment error. Let me know.


Better organize source tree to separate policy from mechanism

Looking through the source tree (especially at the top level) it can be rather hard to sort out at first glance what files are defining general mechanisms (e.g. Target, Expression, Way, Stage, Builder, etc.) and which are defining specific details of the build process. It would be nice if this were more evident from the source layout.

Thanks! Indeed, I'd like to do this before The Merge, so that users don't need to re-learn the source tree.
Do you have any advice on the best tree structure?
I think we should have two separate directories: one for the generic build infrastructure (expressions, etc.), and one for GHC specifics (build rules, command line templates, etc.).
One possible structure:

Context and Expression move to Hadrian.Context, Hadrian.Expression.
Rules and Settings move to GHC.Rules, GHC.Settings.

In this way Hadrian.* could eventually become a reusable library, although it may be hard to disentangle it completely from GHC.

Some of the command line templates, e.g. 'building a C object' could also be pulled into Hadrian.*, because they are GHC-independent and may be reused.

Andrey Mokhov<EMAIL_ADDRESS>writes:

Thanks! Indeed, I'd like to do this before The Merge, so that users don't need to re-learn the source tree.
Do you have any advice on the best tree structure?
I think we should have two separate directories: one for the generic
build infrastructure (expressions, etc.), and one for GHC specifics
(build rules, command line templates, etc.).
One possible structure:

Context and Expression move to Hadrian.Context, Hadrian.Expression.
Rules and Settings move to GHC.Rules, GHC.Settings.

In this way Hadrian.* could eventually become a reusable library,
although it may be hard to disentangle it completely from GHC.

This sounds like a reasonable structure to me. Of course, as you point
out, the line between the GHC. and Hadrian. namespaces may be a bit
blurry at times, but it sounds like a nice ideal to strive towards.
Cheers,

Ben

@bgamari Thanks, I'll give it a try.

what is the status of this issue now?

@izgzhen I've factored out quite a lot of code to a generic library that lives in the Hadrian subdirectory, but further work is currently on hold until we merge #445. Once #445 is merged, I'll continue working on this.


Dashboard: Stories no longer preloaded in PHP

Bug Description
This is a regression. Return to preloading stories.
Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@spacedmonkey can you take a look at this? Nothing changed in the dashboard that could be affecting this as far as I see. private stories are missing from preload path in Dashboard.php - i have a sad lil PR here to fix that (https://github.com/google/web-stories-wp/pull/6356) but i'm drawing a blank on why this would have stopped working, feels php centered to me.

@BrittanyIRL You're right, it's because we now support private stories in the dashboard but the preloading hasn't been updated to reflect that. The PR looks correct to me.

@BrittanyIRL You're right, it's because we now support private stories in the dashboard but the preloading hasn't been updated to reflect that. The PR looks correct to me.

huh, when i added it in to the preloading i still wasn't seeing the preloaded stories come through but perhaps that's just my tiny amount of stories (recently reset my env).


PDF Report Row Background Color

Hello!
If the PDF Reports of Serenity is a simple HTML with CSS, why the following HTML code does not make the color background will be Grey for a column, in the PDF file result.

DESCRIPTION:

The PDF file would be a table with a color column Gray, and not White, or the PDF Report Generator not accepts colors in the tables HTML code?
Thanks for your help.
Andres

Actually, it's bootstrap's css fault. You should override its css style...
something like
@media print {

  .table td {
    background-color: #999 !important;
    -webkit-print-color-adjust:exact;
  }
}

Best Regards

Thanks @edson


[3.6][Bug] CSS issue - tbody td is wider then thead td when relations are used

Bug report
What I did:
I noticed that in the table the tbody > td width is screwed up if I use relations. eg.
$this->crud->addColumn([
            'name' => 'user.name',
            'label' => 'User',
            'type' => 'text'
        ]);

What I expected to happen:
The width of the tbody > td should match the width of table > th > td
What happened:
It's not aligned. See: https://s17.directupload.net/images/190402/j39728ou.jpg The width of the tbody > td is greater than the width of the thead > td
What I've already tried to fix it:
The issue is in the file list.css at line ~188
This rule is causing the issue. I removed it and it was correctly displayed
#crudTable thead>tr>th, table.dataTable thead>tr>td {
	padding-right: 30px;
}

Backpack, Laravel, PHP, DB version:
"backpack/crud": "^3.5",
JS/CSS Related issue, i gues sno php and db version are needed

Hi @sheriffmarley ,
Thanks for bringing this up. Are you getting the same problem after the upgrade to 3.6?
I just tested it with 3.6 and it looks good for me - th>td and tr>td are aligned:

In this case I've used:
            [
               'label'     => 'Relationship',
               'type'      => 'text',
               'name'      => 'category.name',
            ],

Thanks!
PS. I'll close the issue for now since I couldn't reproduce it. I'll gladly reopen it if it's still occurring.


TimePicker in Edge has cropped 0

Steps to reproduce:

Open the demo in edge
Go to the  @time picker
Input several numbers in order (works well if you have numbers that make no sense as time like (99:99)

Result:
The minutes are cropped

@wtfil Please contact me if you have any questions
Thanks

@urik9 Hi, thank you for issue!
Can you pls check it once again? Yesterday I made some changes in styles, and now I can't see any bug in edge 15 and edge 14.
Tested with browserstack

@urik9 ping

fixed


Releaser can now build from another branch than environment

Sometimes you want to release an artifact from a different branch than the environment name, this adds a branch option to allow for that.

I'm not entirely sure about this since it lets you do things like branch: 'staging', environment: 'production'. I know I can't stop people from figuring out how to do that, but I also don't want that to be easy.
The problem is that branch names aren't reflected in the artifact name, the point of environment and branch being linked is that they are the same thing. It's called "environment" mostly because people tend to have a different name for their "production" branch than "production".
I would consider making it possible to change which branch was used to build a non-production artifact, but being able to build a production artifact from any branch should not be this easy.

Disabling the branch option for production artifacts seems fair enough, although is feels mostly like security by obscurity to me.

@iconara I just pushed an update disabling branch to be changed for production. Is this ok to merge?

Apart from the two comments this LGTM.

I've fixed the two comments @iconara. Could you merge and release, or give me access to do it myself? :)

You're now owner of the gem. Merge and release, and don't forget to add a GitHub release with the changes.


Do not attempt serf query when not initialized

Sometimes, the vxlan kernel code may generate miss
notifications for vxlan bound packets when serf is
not initliazed. In such cases we should not try
doing a query as it will create a panic. We should
error out which will generate a log message.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM

LGTM


Emply style element causes build error

Describe the bug
if there is an empty style element stubbed out i get a non descriptive build error
Module build failed (from ./node_modules/svelte-loader/index.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) [object Object]

To Reproduce
Add the line following line to a svelte project. Note this has been setup to use sass
<style type="text/scss"></style>

Notice that there are no spaces or line breaks within the style block. If you add a line break it fixes the build.
Expected behavior
build should not fail or give a better error
Stacktraces

Stack trace
ERROR in ./src/App.svelte
Module build failed (from ./node_modules/svelte-loader/index.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) [object Object]
    at runLoaders (C:\Users\user\Documents\my-app\node_modules\webpack\lib\NormalModule.js:313:13)
    at C:\Users\user\Documents\my-app\node_modules\loader-runner\lib\LoaderRunner.js:367:11
    at C:\Users\user\Documents\my-app\node_modules\loader-runner\lib\LoaderRunner.js:233:18
    at context.callback (C:\Users\user\Documents\my-app\node_modules\loader-runner\lib\LoaderRunner.js:111:13)
    at preprocess.then.err (C:\Users\user\Documents\my-app\node_modules\svelte-loader\index.js:178:12)
 @ ./src/main.ts 1:0-31 2:16-19
 @ multi ./src/main.ts ./src/styles/default-theme/all.scss

Information about your project:

Windows 10

svelte-preprocess version (Please check you can reproduce the issue with the latest release!)
3.2.2

Whether your project uses Webpack or Rollup
Wepack. based on my template i uploaded https://github.com/nitro52/svelte-typescript-sass-template. (might be slight tweaks to configs)

I think this seems like an issue with the svelte-preprocessor but if it's not let me know.

Hello! Yeah, this was happening because scss throws an error if passed an empty string as content, who would know hahahaha 🤷♂
Anyway, fixed on v3.2.5 🎉


Add DaVinci roles to documentation examples

Change Description

Testing Results

Testing Shell Command

Testing Results

@patrickcping I've followed the example in the PR but the plan throws an error, even though the validation passes
╷
│ Error: Cannot find role DaVinci Admin
│
│   with data.pingone_role.da_vinci_admin,
│   on dev.tf line 498, in data "pingone_role" "da_vinci_admin":
│  498: data "pingone_role" "da_vinci_admin"{
│
╵
╷
│ Error: Cannot find role DaVinci Admin Read Only
│
│   with data.pingone_role.da_vinci_admin_read_only,
│   on dev.tf line 502, in data "pingone_role" "da_vinci_admin_read_only":
│  502: data "pingone_role" "da_vinci_admin_read_only"{
│

using the same/identical example in the PR
data "pingone_role" "da_vinci_admin" {
  name = "DaVinci Admin"
}

data "pingone_role" "da_vinci_admin_read_only" {
  name = "DaVinci Admin Read Only"
}

On previous release 0.18.0. I've updated the pipeline to 0.18.1 to confirm this is not version related, unless this only works in 0.19.0?

An API call to list all roles returns
[
  {
    id: '1813bc13-8d13-4e88-a825-d40bfe82777b',
    name: 'Organization Admin',
    description: 'Organization Admin'
  },
  {
    id: '29ddce68-cd7f-4b2a-b6fc-f7a19553b496',
    name: 'Environment Admin',
    description: 'Environment Admin'
  },
  {
    id: '0bd9c966-7664-4ac1-b059-0ff9293908e2',
    name: 'Identity Data Admin',
    description: 'Identity Data Admin'
  },
  {
    id: 'b5057d0d-7281-47f6-9398-8a7e4cb71397',
    name: 'Client Application Developer',
    description: 'Client Application Developer'
  },
  {
    id: 'ce00e15f-f845-4df1-abf3-fdc4ff4e176c',
    name: 'Identity Data Read Only',
    description: 'Identity Data Read Only'
  },
  {
    id: '7aba580c-5ec7-4b26-987d-85f462767455',
    name: 'Configuration Read Only',
    description: 'Configuration Read Only'
  },
  {
    id: 'c65f13f5-f42c-4ffc-aa3a-4858d4ac3f6d',
    name: 'PingFederate Administrator',
    description: 'PingFederate Administrator'
  },
  {
    id: 'ec21ef32-0885-4210-8fe3-247bc2f40e7d',
    name: 'PingFederate Expression Administrator',
    description: 'PingFederate Expression Administrator'
  },
  {
    id: '03643153-e396-4c35-b527-ac05b43a64fb',
    name: 'PingFederate Crypto Administrator',
    description: 'PingFederate Crypto Administrator'
  },
  {
    id: '6f6793ad-4a5a-421b-8867-406ebee618de',
    name: 'PingFederate User Administrator',
    description: 'PingFederate User Administrator'
  },
  {
    id: 'b812ab8e-8fbc-45a9-b965-136849148040',
    name: 'PingFederate Auditor',
    description: 'PingFederate Auditor'
  },
  {
    id: '168d545c-8337-4a34-8426-9c173d60e331',
    name: 'DaVinci Admin',
    description: 'DaVinci Admin'
  },
  {
    id: 'e23fed81-8c98-4c20-b823-8d29514ab5f6',
    name: 'DaVinci Admin Read Only',
    description: 'DaVinci Admin Read Only'
  }
]

@dbryar You're correct, the provider needs a module update which will be in the next provider release (v0.19.0) because it's implemented as an ENUM for validation
One thing on my list is to review the ENUM strategy in the provider overall.  There is a balance between allowing items like this as "free-text" (automatically accepting new values as they are released on the API) and restricting them because the provider code may not expect certain values and needs adjustment based on new individual behaviours.
In this case, it could have accepted the new role values as-is, but there may be occasions in the future where a role may have special grantability rules that need extra provider code for.  I need to review over the coming weeks

So watchers of this change are aware, the general support of the DaVinci admin roles needs to be pushed into a later release.  This is because the roles cannot be re-granted from the worker app client that Terraform uses in the provider {} block.
The existing combinations of Environment Admin and Identity Data Admin will continue to work in the interim
Currently support for DaVinci admin roles is aligned to the v0.20.0 release of the provider, but this can change.  If we have the ability to pull the release of the DaVinci admin roles forward then we will

The required changes to the API were made at the end of last week so we're able to include DaVinci role support in the v0.19.0 release


refactor(mssql,postgresql): group tables by schema to load information schema

This changes MsSqlSchemaHelper and PostgreSqlSchemaHelper to group tables by schema name and use IN operator for table names instead of using OR for every schema/table combo, e.g.
WHERE (
  (ccu.table_name = 'seals' and ccu.table_schema = 'mammals')
OR (ccu.table_name = 'owls' and ccu.table_schema = 'birds')
OR (ccu.table_name = 'parrots' and ccu.table_schema = 'birds')
)

becomes
WHERE (
  (ccu.table_name IN ('seals') and ccu.table_schema = 'mammals')
OR (ccu.table_name IN('owls','parrots') and ccu.table_schema = 'birds')
)

This doesn't change the current behavior, yet it makes the entity generator faster (at least for large databases) when multiple tables belong to the same schema (which is almost always the case).

@boenrobot

Could you also add the same for MySQL and MariaDB?

MySQL/MariaDB already uses IN for table names (and, maybe incorrectly, always uses database() as a schema name).


Added tooltip on hover

Fixes #590
Describe the changes you have made in this PR -
Added tooltip on hover on each element
Screenshots of the changes (If any) -
Before -

After -

Coverage remained the same at 84.279% when pulling 586388c0e628c850f8fbd7cd58503242c0880dce on KaustubhDamania:small-text#590 into 80483a97cc419aee463a26605f00f91277533990 on CircuitVerse:master.

@nitin10s can you review this please?

@nitin10s Cool, I'll try that :+1:

@nitin10s here's the screenshot with downward tooltip.

However I'm facing an issue when the element is the bottommost, the tooltip is overlapping with the bottom menu items. I tried to fix using z-index but it didn't work, hence I had kept the tooltip at the center of the element.

I think we can close this PR as the current version seems to be alright.

@tachyons can we close this

@tachyons can we close this

@aayush-05 yes, I had asked on community channel on Slack that which one looks better, the current one or the one which I made. I didn't get any response on that, still I can improvise this PR if required.

We are going to revamp the simulator, so this will be implemented based on that design.


Certain (older) PHP versions ignore SSL option verify_peer=true

This issue is covered by our test suite. In other words, if you can run the test suite without any errors, then your installation is not affected.
This test DOES work correctly on ALL PHP versions tested via Travis (and everything I've tested locally on Ubuntu Linux).
This test does NOT work on PHP 5.5.30 on Mac, but DOES work with PHP 7.? on Mac.
As such, I'm not sure there's much to be done here. Also, PHP 5.5 is no longer officially supported by Zend, so you're recommended to upgrade anyway.
As such, I'm closing this for now and we can reconsider this if it affects other (supported) versions :+1:


Multiple ControlledAdvice is not working properly

I can't create multiple @ControlledAdvice classes without adding explicit @Order.
Example project: https://github.com/xmazu/spring-graphql-multiple-controller-advice
I have added tests that should work but with current AnnotatedControllerExceptionResolver implementation they won't 😢

Superseded by #902.


[19.03 backport] bridge: Fix hwaddr set race between us and udev

backport of https://github.com/docker/libnetwork/pull/2380 for the 19.03 branch
systemd and udev in their default configuration attempt to set a
persistent MAC address for network interfaces that don't have one
already systemd-def-link. We set the address only after creating the
interface, so there is a race between us and udev. There are several
outcomes (that actually occur, this race is very much not a theoretical
one):

We set the address before udev gets to the networking rules, so udev
sees /sys/devices/virtual/net/docker0/addr_assign_type = 3
(NET_ADDR_SET). This means there's no need to assign a different
address and everything is fine.

udev reads /sys/devices/virtual/net/docker0/addr_assign_type before
we set the address, gets 1 (NET_ADDR_RANDOM), and proceeds to
generate and set a persistent address.
Old versions of udev (pre-v242, i.e. without udev-patch) would then
fail to generate an address, spit out "Could not generate persistent
MAC address for docker0: No such file or directory" (see udev-issue,
and everything would be probably fine as well.
Current version of udev (with udev-patch) will generate an address
just fine and then race us setting it. As udev does more work than we,
the most probable outcome is that udev will overwrite the address we
set and possibly cause some trouble later on.

On a clean Debian Buster (from Vagrant) VM with systemd/udev 242 from
Debian Experimental, docker network create net1 up to net7 resulted
in 3 bridges having a 02:42: address and 4 bridges having a seemingly
random (actually generated from interface name) address. With systemd
241, the result would be all bridges having a 02:42:, but some "Could
not generate persistent MAC address for" messages in the log.
The fix is to revert the MAC address setting fix from 79b3e7761d249a6f,
as it is no longer necessary with current netlink netlink-addr-add,
and set the address atomically when creating the bridge interface, not
after that.
...
Do note that a similar race happens when creating veth devices as well.
I wasn't able to reproduce getting a wrong (non-02:42:) address,
possibly because the address is set by docker later, maybe only after
the interface is moved to another network namespace (but I'm just
guessing here). Still, different timings result in various error
messages being logged ("link_config: could not get ethtool features for
vethd9c938e" and the like) depending on when the interface disappears
from the primary network namespace. I'm not sure how to fix this and I
don't intend to dig deeper into this.
Signed-off-by: Tomas Janousek<EMAIL_ADDRESS>(cherry picked from commit 8710ffea0b06b2eeb66fd231b5a27fbf538377ac)
Signed-off-by: Sebastiaan van Stijn<EMAIL_ADDRESS>

ping @selansen @arkodg ptal

@thaJeztah when I merged actual PR in master branch, CI failed one time and I re apply for coz the error didnt seem to be related. we might want to just keep an eye.


README.md is not up to date

README.md: In "How to install this project", it's written make run instead of make start

Done.


Models custom annotation

Adds some optional properties to the jte-models extension, to enable adding an annotation to the generated interface or implementation classes. Added to test cases and README.

Looks like I will want to be able to specify distinct values for static vs dynamic template classes

When the extension properties are changed in build.gradle, gradle does not detect that inputs have changed. i.e. generated files were not rebuilt.