Rework Op

Currently Op is not extensible by 3rd parties who want to write their own ops. The main roadblock were the unexported methods, and the current remaining roadblocks is the type system.
The Ideal Op interface should be this:
type Op interface {
	// metadata
	Type() Type
	Arity() int
	InferShape(types.Shape...) types.Shape
	ReturnsPtr() bool
	CallsExtern() bool
	OverwritesInput() int

	// the actual op
	Do(...Value) (Value, error)

	// serialization and shit
	WriteHash(h hash.Hash)
	Hashcode() uint32
	fmt.Stringer
}

Further optional op types:
type SymDiffOp interface {
	Op

	DiffWRT(int) []bool
	SymDiff(inputs Nodes, outputNode, gradNode *Node) (Nodes, error)
}

How to Get There

[x] Export all the methods
[x] Add Arity() method
[x] Rework all the InferShape() methods
[ ] Rework anything that calls SymDiff() and DiffWRT to use SymDiffOp
[ ] Move type system to external package (see #26)
[ ] Clean up Value types and interface (see #44)
[ ] Move Op into its own package

000ffebde079 is the start of this process - all methods exported

942f4b93 fixes the InferShape methods

moving Op to its own package will significantly make things more complicated. For now that's shelved

b9e3f31 creates SDOp and handles all the issues

e9b364b marks the end of #26


Mj socail div alignment

Hi @slantz
We had an internal discussion over align attribute, it will now be applied as a text-align (almost as your previous PR, sorry about that) on the td of a column element.
It will be ok on the next release (2.0 for now I guess) !
Closing it, sorry for the delay


fix: adding a restart flag to all proxy services

Signed-off-by: Eldersonar<EMAIL_ADDRESS>adding a restart flag to all proxy services

Superseded by PR #17


Secondary buttons lose styling in new native window

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
The issue happens in MUI v5 but not in MUI v4.
MUI 4: https://codesandbox.io/s/sharp-curie-v3h9dh?file=/package.json:261-290
MUI 5: https://codesandbox.io/s/rc-dock-material-ui-data-grid-forked-y0rtfc?file=/package.json
Steps:
1.Without clicking on 'window 2', right-click the square at the top right of the window in the middle, this should open a new native window.
2. Click the 'toggle me' button.
Current behavior 😯
In MUI v5, the secondary button loses styling if you open a new native window without clicking on it first. If you click the toggle buttons before opening the new native window, the issue does not occur.
Expected behavior 🤔
The secondary button in a new native window should keep its styling.
Context 🔦
No response
Your environment 🌎
No response

@nicolewelch It's related to emotion, see this issue for more details!

Thanks for the answer!


Fixed validation unsupported provinces, EdgeCenterProvider removed

EdgeCenter and Gcore are 2 different and unrelated companies that temporarily have a similar API structure, but it will drastically change in the near future. If Edgecenter decide to support octodns integration I believe they will provide PR with their module implementation. Now we can not declare compatibility and commit to support their API

EdgeCenter and Gcore are 2 different and unrelated companies that temporarily have a similar API structure, but it will drastically change in the near future. If Edgecenter decide to support octodns integration I believe they will provide PR with their module implementation. Now we can not declare compatibility and commit to support their API

We'd want to deprecate this with error messages pointing to the location of the new & different provider for a while before completely removing it. That also means we'll want to wait until the differences have happened and a new provider exists.
Wouldn't expect/require you all to support a different company past the point at which the API are no longer compatible.
More generally this PR is probably best broken up into separate bits with a 1 PR 1 change approach, in this case that'd mean breaking out the validation changes.  Guess the gcorelabs -> gcore changes could be their own PR as well.

Is it really necessary to support edgecenter? They were added only recently https://github.com/octodns/octodns-gcore/commit/af03dda5140250bff28af0963ad6e356989bf096 and it looks like it was done on an mistaken assumption that it's the same company.
It's like adding Google DNS support to NS1 module :)

Is it really necessary to support edgecenter? They were added only recently af03dda and it looks like it was done on an mistaken assumption that it's the same company.

I thought the discussion was in an issue, but it appears I mis-remembered and it was actually an email from @mjekson, who was mentioned on the PR https://github.com/octodns/octodns-gcore/pull/14.
I wasn't under the impression that they were the same company, just that they used the same APIs and were interchangeable as far as the provider was concerned. He originally mentioned a new provider and I was the one that guided things towards using the same provider, with a refactor rather than having 2 effectively identical code bases.

It's like adding Google DNS support to NS1 module :)

If they had the same API I'd be perfectly happy to combine them and avoid identical/duplicated code and maintenance overhead. octoDNS isn't a commercial endeavor and isn't affiliated with any of the companies that it has providers for. It optimizes for the least code/effort in order to focus the donated time of myself and others on providing the most value to the most people.

hi, i totally agree with @ross . Edgecenter requires support for the OctoDNS module. I wanted to ask @ross to make a separate module for Edgecenter, but decided not to duplicate the code, but just make an additional class with the Edgecenter API.

@MarianaStrix don't remove please)))

@ross please change https://api.edgecenter.ru/id TO => https://api.edgecenter.ru/iam

This module is named "gcore". Edgecenter has no place here, so the only question is what is the correct procedure to remove it.
@MarianaStrix please do as Ross said and break the PR into 3.

PR with G-Core->Gcore rename
Fixed validation unsupported provinces
Edgecenter removal, we can continue the discussion about the correct approach there.

@jimaek OK. Let's make a separate module for Edgecenter API. We really need it, because our clients are heavily dependent on OctoDNS

@ross If you can fork this module to Edgecenter, so I can help you to review it

@ross If you can fork this module to Edgecenter, so I can help you to review it

I'll probably be a day or so before I get to sit down and do the terraform bits to create a new repo and copy things over. Will do so when I get a chance.

@ross You can invite me as a new member with role as developer to "octodns-ec" or invite to another group. I'll help you to support this module if I can create a new branch for your project.

Ok, I'm going to create 3 new PR. Thanks!

@ross please change https://api.edgecenter.ru/id TO => https://api.edgecenter.ru/iam

I fixed it in my PR


Xml Parse fails when Intacct Passes slash character in tag names.

Intact returned the following tag :
<GLDIMBuild/Disassemble_Kits_Transaction_Detail></GLDIMBuild/Disassemble_Kits_Transaction_Detail>
Needless to say, the C# Xml Parser barfs when it tries to parse the return message:
{System.Xml.XmlException: '/' is an unexpected token. The expected token is '>'. Line 1, position 2277.   at System.Xml.XmlTextReaderImpl.Throw(Exception e)   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(String expectedToken1, String expectedToken2)   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(Int32 pos, String expectedToken1, String expectedToken2)   at System.Xml.XmlTextReaderImpl.ParseElement()   at System.Xml.XmlTextReaderImpl.ParseElementContent()   at System.Xml.XmlTextReaderImpl.Read()   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r, LoadOptions o)   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)   at System.Xml.Linq.XDocument.Load(Stream stream, LoadOptions options)   at System.Xml.Linq.XDocument.Load(Stream stream)   at Intacct.Sdk.Xml.AbstractResponse..ctor(Stream body) in C:\projects\Rpb\SF2Rpb\intacct-sdk-net-master\src\Xml\AbstractResponse.cs:line 37}

This error occurs in the AbstractResponse.cs file on the first line of the Constructor for the AbstractResponse Class
xml = XDocument.Load(body);

So does this mean that we need to build a better XML parser, or does Intacct need to reform its tag construction ?

This is a known Intacct issue with user defined dimensions.  You need to talk to whoever the admin of this company is.  They need to go to the object definition and edit the lookup field Document Entries [GLDIMBuildDisassemble_Kits_Transaction_Detail] and remove the slash from the integration name.
Screenshot -- https://i.imgur.com/QD2OE4V.png

@seanmunson do you have access to create a support case at https://community.intacct.com ?  I want this fixed in the application and a case is the best way to do get it moving.

I see you have a case open now. I'm going to close this issue here on github.  Reference 00227890


VotingApp example yml returns "deploy failed" error

Problem description
On https://docs.docker.com/datacenter/ucp/2.1/guides/user/services/:
Copy/pasting the VotingApp yml returns an error (and red growl notification) that deployment failed:

--
But when I return to the Stacks & Applications page, I see VotingApp up and running :thinking:
Only one service was deployed, the VotingApp_db, when I expected (from the docs) to also see a VotingApp_visualizer service.

Project version(s) affected
UCP 2.1.1-pr5289

Ah nevermind, the issue if from test Stacks I created a while ago and forgot to remove #brainFart 😊


[Feature Request] input add IP address type

Existing Component
是
Component Name
Input
Description
支持IP地址的输入。
类似于：
<IP_ADDRESS>

I've created an IP address input using Element-UI.
Just put the code up and can be found here: https://github.com/tobybowers/element-ui-ipInput
Hope this helps.

@tobybowers THX


Integration button not showing even when it has been enabled in settings

It is also not visible if you are using SteamNite.

Resolved with current version and for custom theme, it's not supported in native.


feat: Anime Meme plugin dependency

Motivation
Closes #288
Related discussion #286

Removed all features already provided by the Anime Meme plugin.
Raised the minimum build version to mirror the Anime Meme plugin.
Left the asset fetching code for use in #92

❤🩹 Breaking Changes:

Removed titled notifications.
Only select notifications have sound the rest are silent.
Your previous configurations will be lost (Sorry!).
Haven't implemented Sayonara sound on project exit yet.
Haven't implemented Disable in Distraction Free Mode or Presentation Mode yet.
Motivate Me (alt+m) is now Show random Ani-Meme (alt+r)
Sound is either on or off, no granular control across events.

Other changes

Enhanced dynamic plugin install, shouldn't need to re-load project
Added the plugin icon to the update notification window.
Upgraded Sentry Client SDK to 3.2.1

Supporting information
Overrides
Obsoletes the need for the following PRs:

#277
#267
#261
Your effort is appreciated and thank you for your attempts at making the plugin better! :heart:

Related Issues
I kept track of some of the things that needed to be fixed, so I fixed them in the Ani-Meme plugin:

Closes #288
Closes #225
Closes #247
Closes #262
Closes #163
Closes #285
Closes #282
Closes #273

[ ] Updated AMII to be called Anime Memes to alleviate confusion on WMP install

EX:

[ ] Updated AMII to be called Anime Memes to alleviate confusion on WMP install

EX:

Aight, the Anime Meme plugin has been submitted for release that contains the less confusing stuff. Will merge once is available to the public.

Aight, the Anime Meme plugin has been submitted for release that contains the less confusing stuff. Will merge once is available to the public.

Look like it needs a soft dependency on the plugin, cause it does the big sad when the plugin is not updated through the manager.

[ ] Plugin has soft dependency with anime meme plugin install  on reload.

Look like it needs a soft dependency on the plugin, cause it does the big sad when the plugin is not updated through the manager.

[ ] Plugin has soft dependency with anime meme plugin install  on reload.

[ ] Plugin greet existing users differently than new users.

[ ] Plugin greet existing users differently than new users.

[ ] Remove/update show promotion action
[ ] Update build gradle

[ ] Remove/update show promotion action
[ ] Update build gradle

Existing Users

New Users

Existing Users

New Users

@zaerald You are more than welcome to take a look at this. However, I will merge it by this coming Sunday (if not sooner, I need to release a newer version of AMII with a bug fix.).

@zaerald You are more than welcome to take a look at this. However, I will merge it by this coming Sunday (if not sooner, I need to release a newer version of AMII with a bug fix.).


Pr reviewable test

This change is

Reviewed 2 of 5 files at r1.
Review status: 2 of 5 files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):
Testing comment feature from reviewable

Comments from Reviewable


Change to cfgov-refresh header and footer

Overall, things look pretty good, but someone who knows OAH better needs to test this to make sure that the header and footer styles aren't breaking anything major.
Notably, Explore Interest Rates looks a little busted. Not sure if that's just a local testing issue.
Review:

@cfarm
@virginiacc
@ascott1
@contolini

/cc @rosskarchner

Force-pushed an update that should hopefully fix the build/test issues. C'mon, Travis, don't fail me now!

PASSSSED! Anyone want to test, or are we just going for it? :)

Testing now

Looks good! Nice work all around

works for me! :+1:

Huzzah! :shipit:


Segmentation fault

Thanks for uploading code.
Which version of gluonnlp is used?
Because when importing gluonnlp, I came across segmentation fault.
-> import gluonnlp
(Pdb) unt

Segmentation fault: 11

zsh: segmentation fault (core dumped)  python3 -m pdb main.py

Replacing preprocessing with some another function solved this problems, so I close this issue.

P.S.
When torch 1.0.0 and gluonnlp coexist, segmentation fault happen, so I re-install pytorch 0.4.1 and the problem was solved.
Thanks


Add AnimatedInterpolation as possible type for toValue

Summary
AnimatedInterpolation should be a valid type to pass to toValue according to the documentation.
https://facebook.github.io/react-native/docs/animations#tracking-dynamic-values
Changelog
[General] [Fixed] - Add AnimationInterpolation as possible type for toValue
Test Plan
yarn flow works without errors.

Any idea why the tests fail? At first glance it doesn't look related to the changes, as they are happening with the native build and I've only changed the flow-types. @GummyGod

To be honest I am not sure, but, I think it might be a problem with the Polyfills. Someone from the core team might be helpful here.

If you look at all the recent pull requests they all fail the test_ios_framworks test :( So probably not something you've done.


It seems env-cmd not working with pm2

Hello,
I am using env-cmd in my typescript application.
for production I am creating node js build using tsc and after build when I tried to pass custom env file then it throws error like .env file could not found.

I am trying to run command npm run pm2:start:qa.
Thanks in advance.

Perhaps this could help. Create an pm2.config.js file, define your configs in there and access the ENV variables as show below.
module.exports = {
    apps: [
        {
            name: "app-namne",
            script: "./build/index.js",
            watch: true,
            ignore_watch: [
                ".git",
                ".md",
            ],
            time: true,
            env: {
                PORT: process.env.PORT,
            },
        },
    ],
};

qa start script should look something like this:
npm run build && env-cmd -f ./environments/.env pm2 start pm2.config.js",

Hi, could you please provide a minimal reproducible example for this issue?
this screenshot isn't enough information to help debug this issue


About the license notation of AlbumArtExtracor

Hi.
I'm the author of the AlbumArtExtractor library.
You are using the library below, but it is not listed in the README.md.
https://github.com/Speyd3r/MikuSharp/blob/master/MikuSharp/Commands/Music.cs#L704-L706
https://github.com/Speyd3r/MikuSharp/blob/master/MikuSharp/Commands/Music.cs#L850-L852
Could you tell me that I use AlbumArtExtractor in the  README.md？

Hi terribly sorry, I'll add it, I haven't looked in this repo in a while and it seems my notifications from GitHub decided to not show me this


task notify / handler listen on keyword

Proposal: task notify / handler listen on keyword
Replaces the #8 proposal
Author: René Moser <@resmo>
Date: 2016/04/19

Status: New
Proposal type: core design
Targeted Release: 2.2
Associated PR: N/A

Motivation
Based on the discussion and comments of #8 I reworked the proposal and avoid using the words publish/subscribe as different people associate different things with them.
This proposal extends the current notify handlers functionality. In addition to notify a handler by its name,  the proposal allows to notify a keyword which does not correspond to a handlers name.
Handlers listen to this keyword: listen: <keyword> will be notified and executed. If no handler listen to the keyword, no error should occur.
The scope is limited on play like the current notify: <handler_name>.
Problems
In the current notify: <handler_name> functionality, you need to know the handler names to be notified. But there are some use cases, especially in roles specified as dependency, in which you can not know the handler name or know if there are any handlers, one handler or a few handlers to be notified.
Use Case - Role and role dependency
We have a simple playbook using roles configuring services (httpd, postfix)
---
- hosts: web
  roles:
    - httpd

- hosts: mail
  roles:
    - postfix

As those services use SSL, we have a simple common ssl role managing all SSL certs/keys:
# role ssl
# ssl/tasks/main.yml
---
- name: include OS specific variables
  include_vars: "{{ ansible_os_family }}.yml"

- name: copy SSL certs defined
  copy: src={{ item }} dest={{ ssl_certs_path }}/
  with_items: ssl_certs

- name: copy SSL keys defined
  copy: src={{ item }} dest={{ ssl_keys_path }}/
  with_items: ssl_keys

In roles depending on SSL certs (e.g. httpd, postix) you configured the SSL role as dependency:
# meta/main.yml
---
dependencies:
  - ssl

In the tasks of the roles httpd,postifx we configued the SSL certs in templates, as we can be sure, they are available and notify our handlers to restart the services as usual:
# httpd/tasks/main.yml
- name: configure service with ssl
  template: ...
  notify: restart httpd

Role httpd handlers:
# httpd/handler/main.yml
---
- name: restart httpd
  service: name=httpd state=restarted

Same for our postfix role and notify our postfix service handler:
# postifx/tasks/main.yml
- name: configure service with ssl
  template: ...
  notify: restart postifx

Role postifx handlers:
# postifx/handler/main.yml
---
- name: restart postfix
  service: name=postfix state=restarted

Pretty straight forward.
As you know, certs are only valid for some time and we need to replace them once in a while.
Now the question is, how can we restart all services using SSL to make use of the new cert by notifying all handles in the roles depending on the ssl role?
Add the notify handler names to the task would work, right?:
- name: copy SSL certs defined
  copy: src={{ item }} dest={{ ssl_certs_path }}/
  with_items: ssl_certs
  notify:
    - restart httpd
    - restart postfix
    - restart xyz

Yes, this would work but remember, the SSL role is a common role and may be on galaxy. To keep it common you usually would not notify a handler not specified in this SSL role.
However there would be a few solutions to that problem with current ansible functionality but they make things unwanted complicate and regarding roles on galaxy, support for roles on galaxy is not as simple as it could.
Solution proposal
Coming back to our use case, we would add a notify to the tasks in our SSL role but just using a keyword event_ssl_changed not associated with a handler name.
# role ssl
# ssl/tasks/main.yml
---
- name: include OS specific variables
  include_vars: "{{ ansible_os_family }}.yml"

- name: copy SSL certs defined
  copy: src={{ item }} dest={{ ssl_certs_path }}/
  with_items: ssl_certs
  notify: event_ssl_changed

- name: copy SSL keys defined
  copy: src={{ item }} dest={{ ssl_keys_path }}/
  with_items: ssl_keys
  notify: event_ssl_changed

In roles depending on SSL certs (e.g. httpd, postix) you configured the SSL role as dependency like before:
# meta/main.yml
---
dependencies:
  - ssl

In the role httpd handlers main.yml we add a new param listen: <keyword> to listen for the notified keyword.
# httpd/handler/main.yml
---
- name: restart httpd
  service: name=httpd state=restarted
  listen: event_ssl_changed

The same in our postifx role.
# postifx/handler/main.yml
---
- name: restart postfix
  service: name=postfix state=restarted
  listen: event_ssl_changed

To show the solution in a simplified way in a playbook task play:
- hosts: webservers
  tasks:
    - name: copy SSL certs defined
      copy: src={{ item }} dest={{ ssl_certs_path }}/
      with_items: ssl_certs
      notify: ssl_certs_changed

  handlers:
    - name: restart httpd
      service: name=httpd state=restarted
      listen: ssl_certs_changed

    - name: restart postfix
      service: name=postifx state=restarted
      listen: ssl_certs_changed

Closing, as this feature has been implemented.


Bug: Error message upon Submit

When I filled out the form and hit submit it gave me this error screen:

Refreshing the browser does not help, I still get the same message and when I go to the dashboard, my application is still showing as Draft instead of Submitted.

@marcellmueller To reproduce the error on the Test environment, create a new application, go to the last page, and submit.
The error will show up, and the application status is changed to Submitted.

@eazeredo  were you able to reproduce the error with these steps?

@Mars Yes, I reproduce the error with that steps. But I'm trying again, and it didn't happen again. Happened only once.

Wrong Mars @eazeredo 🙏

Yes it happened to me again today.

@MarsRomer , @eazeredo I can't reproduce the issue, would you be able to provide some error logs from the browser console?

Happened again, here's the screenshot with the debugger

@matthieu-foucault did I hear you say you fixed this problem? if so can we please get it into test for tomorrows demo?

The cause of the problem was identified. It still needs a fix and a test

interestingly it's working for me now

The bug will be intermittent: the application doesn't wait for the CCBC Id and intake number to be assigned before navigating to the success page. Whether or not the bug happens depends on your browser and your network's speed

can we do something so that this doesn't happen? my network speed is pretty good most times and I'm mostly using chrome


Update the FITS functions

Fixes https://github.com/jeff-regier/Celeste.jl/issues/29<issue 29>.

Coverage decreased (-0.09%) to 82.05% when pulling 55c09468676de4adbd97afbf5612366582b7fdf5 on fits_temporary_fix into 5daa62dd382de35eeabd45de13ea8c32b67db6bd on master.

Looks good!


A minor issue. https://developer.mozilla.org/en-US/docs/Learn/CSS/Styling_text/Styling_lists

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

Just a minor issue. When you're on the page "styling lists" under "Learn Web Development", the menus to the left show a different version of the original menu. Check the images if you don't understand what i'm saying.
It happens that "Styling Boxes" and "Introduction to CSS" appears and "CSS first steps" and "CSS building blocks" disappears.

Hrm, this shouldn't be happening, as I updated the Learning area sidebar structure a while ago. It should look like it does here on every page: https://developer.mozilla.org/en-US/docs/Learn/CSS/First_steps.
@escattone, is there an easy way to regenerate all the pages under https://developer.mozilla.org/en-US/docs/Learn/, so we can make sure the correct sidebar is being shown in all places?

@escattone, is there an easy way to regenerate all the pages under https://developer.mozilla.org/en-US/docs/Learn/, so we can make sure the correct sidebar is being shown in all places?

@chrisdavidmills I created this issue and I'll talk to @tobinmori and @atopal about getting that work triaged.

@chrisdavidmills I created this issue and I'll talk to @tobinmori and @atopal about getting that work triaged.

cheers mate! I'll close this issue then, since it is now being tracked over there.


Extractor

I wrote a class EDGARExtractor. This class does two things:

Extract all the documents from a single .txt file downloaded from EDGAR. Suppose that the .txt file contains two <SEC-HEADER> with two <HEADER> under each of them. All the 4 documents will be extracted. The documents will be numerated X.Y, where X is the progressive index of <SEC-HEADER> and Y is the index of the <HEADER>.
The metadata for all those documents will be extracted. In particular, a JSON file will be created, which contains the metadata of , and, under the "documents" key, the metadata of every

[X] closes #60
[X] tests added / passed
I have added a test under SECEdgar/tests/test_extractor.py, but it gives an error

FileNotFoundError: [Errno 2] No such file or directory: '/media/raffaele/DATA/data/progetti_altrui/sec-edgar/SEC-Edgar-Data'

which is also given by pytest test_filings.py and is due to the
    shutil.rmtree(_crawler.data_path)

at line 29 of conftest.py

[X] passes git diff upstream/master -u -- "*.py" | flake8 --diff
This command gives the error
fatal: bad revision 'upstream/master'
but
git diff master -u -- "*.py" | flake8 --diff
runs without errors
[X] added entry to docs/whatsnew latest version

Thanks for sharing this! I will take a look at it and get back to you with any changes we might need. If you want to go ahead and see why flake8 is failing, you can look at the Travis logs to see what it is complaining about.

Thank you for your software. I should have solved all the problems reported by flake8 :)

@raffam would you mind creating a minimal example use case of the extractor (for the documentation)?

Well it can be used in conjunction with the Filing class
f = Filing(cik='0000320193', filing_type='10-k')
metadata = f.save("./data/original", True, "./data/extracted")

or standalone
from SECEdgar.filings import Filing
from SECEdgar.extractor.EDGARExtractor import EDGARExtractor
import os

os.makedirs("./data/original", exist_ok=True)
os.makedirs("./data/extracted", exist_ok=True)

f = Filing(cik='0000320193', filing_type='10-k')
f.save("./data/original")
metadata = EDGARExtractor("./data/original/0000320193/10-k/0000320193-19-000066.txt", "./data/extracted")

I don't know if I should put that as a comment in the source code

I don't know if I should put that as a comment in the source code

I don't think this needs to be added to the source code. I really like the Excel file that is created from this. It seems like this is the direction we want to head in. Is there an easy way to convert this into JSON? I still need to look deeper at what exactly you are doing, but I think that providing the extracted data as either an Excel file or as JSON would be a good start.

I think that providing the extracted data as either an Excel file or as JSON would be a good start.

I am not sure I understood your point. For "Excel file" you mean one the files that is extracted? An Excel file which is contained in the master .txt file?
The files contained in the master .txt file, that is, the files that are extracted, can be whatever, not only Excel files but also txt, html, images (jpeg, bmp), etc.
So honestly I would leave the format of the files as they are in the master .txt file. It would be possible for the user to convert an Excel file in a JSON file, or a jpeg file in a png file, but with other tools outside this one.
But I am not sure I understood you.

any update on this?

@raffam I am currently looking into ways to do this without relying on regular expressions. I think from a maintainability perspective it will be easier to parse the XBRL as XML.

I am not exactly an expert on XBRL :)
But I have tried to read the .txt files with a XML parser and failed due to two phenomena:

The file contains characters in their text (e.g. company's name) like "&" which I understand are not valid under XML
In the header sections are separated by tabs and not by XML tags

I also understood only some .txt files contain XBRL files, but not all?

I am not exactly an expert on XBRL :)
But I have tried to read the .txt files with a XML parser and failed due to two phenomena:

The file contains characters in their text (e.g. company's name) like "&" which I understand are not valid under XML
In the header sections are separated by tabs and not by XML tags

I also understood only some .txt files contain XBRL files, but not all?

I'm not too familiar with it either. The one drawback of the current proposed change is that it seems to produce lots of unnecessary documents still. How does it end up helping users extract the data they want in an easily readable format (other than the Excel file)?

I'm not too familiar with it either. The one drawback of the current proposed change is that it seems to produce lots of unnecessary documents still. How does it end up helping users extract the data they want in an easily readable format (other than the Excel file)?

Well I would agree that some documents are not necessarry, for example the company's logo especially if repeated over and over.
I am not sure if all documents other than the Excel file with the financial disclosure are always unecessarry either? For example:

An investor may want to actually read the 8-K in order to discovere whether some C-level has changed. Or somebody may want to actually read the 10-K

A researcher may want to do content analysis on the text of the disclosure, other than the financial numbers. For example, this paper seems to do content analysis on the 10-K. I myself chose to download the 10-K for a similar type of research project.

We can certainly have some way to let the user chose which documents to extract, for example, only Excel files.

I'm not too familiar with it either. The one drawback of the current proposed change is that it seems to produce lots of unnecessary documents still. How does it end up helping users extract the data they want in an easily readable format (other than the Excel file)?

Well I would agree that some documents are not necessarry, for example the company's logo especially if repeated over and over.
I am not sure if all documents other than the financial disclosure spreadsheet are always unnecessary either? For example:

An investor may want to actually read the 8-K in order to discovere whether some C-level has changed. Or somebody may want to actually read the 10-K
A researcher may want to do content analysis on the text of the disclosure, other than the financial numbers. For example, this paper seems to do content analysis on the 10-K. I myself have to download the 10-Ks for a similar type of research project.

We can certainly have some way to let the user chose which documents to extract, for example, only Excel files.

@raffam can you send me an email (you can find my email address on my GitHub profile)? @coyo8 and I have been discussing the scope of this project and I think getting your ideas on this would be helpful.

I did cleanup the code a bit

@coyo8 can you review this PR?

I am going to close this for now, as it seems to be stale. Please let me know if you would like to continue working on this feature @ghost. I appreciate your contribution and will be sure to come back to this PR when implementing the parser.

This would be great!

This would be great!

@reteps if you are interested in helping with this one it would be much appreciated. Haven't had time to work on this, as it is a somewhat large undertaking.

I do not like the way that this is currently implemented. The regex and everything seems fine, but the fact that the data needs to be downloaded FIRST then parsed? It should be able to be downloaded, parsed, and only the parsed data saved.
How's this for a game plan:

Add an instance of FilingExtractor to the base Filing class
Add a save_extracted, save_raw booleans to the save method. If save_extracted, The instance of FilingExtractor is called, and data is saved.

When I start working on this, I will open a new PR and reference this one @jackmoody11.

When I start working on this, I will open a new PR and reference this one @jackmoody11.

Awesome! Thank you @reteps!

I will be able to work on this once #149 is merged, as otherwise, a merge conflict between this PR and that one will arise.

I will be able to work on this once #149 is merged, as otherwise, a merge conflict between this PR and that one will arise.

If you want to get started on this one, once #149 is merged you can just resolve the merge conflicts. But if you don't want to go through that we can just focus on getting #149 merged.


Patch smoothing utility to handle short signals (for backfill)

Mostly documentation fixes, confrm to pydocstyle, add missing documentation for the argument boundary_method.
But also I removed the len(signal) < window_length constraint I added at the last minute; I forgot I wrote boundary methods to handle that case a few months ago.

Should probably be merged before @chinandrew's refactors go live, so that backfill is handled properly.

Cool. You know, I'm running into issues where JHU tests are giving the smoother an array full of NANs. That makes me want to change the nan handling to be a bit more permissive (a full array of nans should pass through, an array left-padded with nans should start imputing only once the first value is seen, etc.), so I think I'll handle that in this PR too.

Cool. You know, I'm running into issues where JHU tests are giving the smoother an array full of NANs. That makes me want to change the nan handling to be a bit more permissive (a full array of nans should pass through, an array left-padded with nans should start imputing only once the first value is seen, etc.), so I think I'll handle that in this PR too.

If it's independent of this change, I'd recommend making it another PR just to keep things clean.

Noted. I'll do that.


Skype buttons are disabled while they work fine in Messenger for hero cards

I've been checking the hero cards in Messenger and for openUrl type they seem to be working without issue. On Skype, the buttons show up but are not clickable (they are greyed out).

what skype client you are referring to? is it the skype web client? https://web.skype.com/en/?ecsoverride=developer
as detailed on the doc  you ought to be using the web client for the cards to work until they have released the updated skype clients which they said it will end of July

@MironV can you verify now that the new client is RTM?

@danmarshall On the web client I'm not seeing the disabled buttons at all. "tel" works fine. The buttons are just URL's and work fine in Messenger. On my Mac, on the latest version of Skype I see the buttons but they are disabled.

The latest Skype clients on desktop and mobile all have support for cards now. Please could you confirm you are using HTTPS for your open URL links as this is required in Skype.

Aha, that's probably it, I'll check in a bit!
However, this seems pretty extreme. I use a bunch of 3rd party APIs (Yelp, VFRMap, etc.) that don't provide HTTPS URLs in their APIs and some don't even have a HTTPS url to link to. What is the suggested approach there?

Perhaps you can use a URL shortener?

@danmarshall @nickcordrey If I can work around this by using a URL shortener why is this restriction in place?

In the example of signin card for Skype https://github.com/Microsoft/BotBuilder/blob/master/Node/examples/demo-skype/app.js
var msg = new builder.Message(session)
            .attachments([
                new builder.SigninCard(session)
                    .text("You must first signin to your account.")
                    .button("signin", "http://example.com/")
            ]);

url is http while http url is not working.
as@MironV said - some third party APIs are not providing https, is there any way to use http for openUrl.

Closing because of age.  If you are still having an issue please raise the issue again.

Hi guys,
Skype signin button not working (it's, there, but it's not clickable) for me on the desktop version.
Version:  <IP_ADDRESS>
It works just fine on my Android.
Any fix on this?

@andrecarlucci You are commenting on a closed issue.
If you have a question or problem, please open a new issue.


Streaming MySql ResultSet

Hi,
I wanted to use MySQL proxy for big data analytics which sometimes takes a couple of hours to finish the execution have a full result. Is it possible to stream the ResultSet while the query is executing?

Hello, @SananGuliyev.
In my fork there is Conn.ExecuteSelectStreaming which call callback for every row instead of saving the whole Resultset in memory.
Maybe this is what you want?
Unfortunately, I cannot apply any PR to this repo.

Hello, @SananGuliyev.
There is Conn.ExecuteSelectStreaming which call callback for every row instead of saving the whole Resultset in memory.
https://github.com/go-mysql-org/go-mysql/blob/master/README.md#example-for-select-streaming-v111
Maybe this is what you want?

@atercattus it's what I need. I will test it. I do not know how I missed that. Thanks a lot.

Got it. Then the functionality requires improvement from my side.
We use streaming with "repacking" to another protocol :)
I'll make PR for you in the near future.

Thanks a lot. Looking forward to your PR.

Hi @atercattus is there any plan regarding to that enhancement? I could contribute in case you share your ideas how you plan to implement it.

I changed my work and didn't do this task when I was going to...
Thanks for your patience and this reminder. I will think over the issue before the end of the year. it's ok?

Yes, sure. It's totally ok. Thanks for update.

Hi @atercattus,
is there any update?


Adding CrazyCoin

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Hi there bit lost on what I need to do next as when I check solscan it
still shows unrecognised token
On Tue, 18 Jan 2022, 10:37 token-list-automerger[bot], <
@.***> wrote:

Closed #14572 https://github.com/solana-labs/token-list/pull/14572 via
cad0844
https://github.com/solana-labs/token-list/commit/cad0844fff7df70419a794347613da4b1a2f4c31
.
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14572#event-5909559565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKP7DDYJAF5KSH64KVEB4DUWU7HFANCNFSM5MGWSVLQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Running simple visual basic script for unzipping a zip file throws Unspecified Error

Describe the Bug
I would like to run a visual basic script inside the docker container that places zipped content into a destination inside the docker container. It appears there may be something missing in the base image I am using: mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-ltsc2019, as any attempts to do this yield an unspecified error.
Steps to Reproduce

Clone https://github.com/christopher-watanabe-snkeos/dotnet-framework-docker-batch-file-issue
Create a testZip.zip with some dummy content inside.
Build the docker container; e.g. docker build . -t test-dotnet-batch-issue
Run the docker container in interactive mode. e.g. docker container run -it test-dotnet-batch-issue
Try to run the .vbs script with cscript ./test.vbs

From these steps, I notice the following:

The zip folder and test.vbs are copied successfully to the docker container.
Running cscript ./test.vbs yields the following output:

destination: C:
zipFilename: C:\testZip.zip
Creating Shell.Application Object
Creating objShell.NameSpace of testZip.zip
C:\test.vbs(12, 1) (null): Unspecified error

It seems the hangup is this line in the .vbs file:
set zipFiles=objShell.NameSpace(zipFilename).items
Other Information
I know I can work around this by writing for example a powershell script that uses Windows native Expand-Archive. In the scope of another project, the unzipping is accomplished by a .vbs script however, so I would like to understand more about why this is happening.
Output of docker version
Client:
Version:           20.10.9
API version:       1.41
Go version:        go1.16.8
Git commit:        c2ea9bc
Built:             Mon Oct  4 16:11:10 2021
OS/Arch:           windows/amd64
Context:           default
Experimental:      true
Server: Docker Engine - Community
Engine:
Version:          20.10.9
API version:      1.41 (minimum version 1.24)
Go version:       go1.16.8
Git commit:       79ea9d3
Built:            Mon Oct  4 16:06:39 2021
OS/Arch:          windows/amd64
Experimental:     false

[Triage]
This is better suited for the Windows-Containers repo which the .NET Framework container images are based on. The use of cscript is native to the base Windows image so that's the place to start an investigation from. You'll need to log a new issue there as this issue can't be transferred to that repo unfortunately.


i have to constantly reconnect to last.fm

seems  that every time i start the browser, a pop-up asks me to authenticate the application

Same issue.
Ubuntu Xenial
Google Chrome 51.0.2704.106-1

Isn't it a duplicate of #981 ?

Yes, could be a duplicate...
About the issue, it seems to drop access on one browser (for instance my home pc), when I login in my other computer.
I have stopped login in in all except for one computer, and then it stops asking for access to last.fm.

Closed in favor of #981


IOS: Strip simulator architecture on Archive task

This issue is related to #81
We recently changed how our iOS library is distributed, from static FAT library, to a static framework. Meanwhile, I had to change that for once more to a dynamic framework, due to fact, that static fw cannot be linked to another dynamic fw. This kind of transitional dependency is forbidden (by cocoapods, but it's rational, you don't want to have linked static library multiple times in multiple dynamic frameworks)
So, once I changed PowerAuth2.framework to a dynamic, I've soon realized that our customers will not be able to publish their applications to iTunes Store, due to forbidden architectures still present in precompiled framework (check for example this question on SO). Carthage guys had the same problem.
I personally feel, that switch to the dynamic framework is a good thing for PowerAuth. It allows us to develop a libraries on top of PowerAuth while application's code can still use all PowerAuth features. This is for example the only one way how make LimeAuth library possible.
So, we have several options how to solve this problem.
Carthage way
We can adopt for example a Carthage way, when the developer must add some pre-archive script into the application's project, which removes x86 architectures from all dynamic frameworks.
This is quick solution.
Split library
We can split PowerAuth mobile SDK into two separate projects:

Low level core, (c++, openssl + thin objc wrapper) which will be distributed as static FAT library
High level code, which will be distributed in pod as source code

This is a good solution, because cocoapods will manage that PowerAuth2.framework will be fully debuggable (#76) and will be compiled only for an actually required architectures (e.g. Archive task will compile just ARM code, build for simulator will use x86, etc..). Linking static fat library against another target is correct, because the target dictates which architectures has to be added to the final executable (or library).
Unfortunately, I'm not sure if this is doable right now (see my comment in issue 76)
Extensions & watchOS
We don't have this problem on app extensions or watchOS. That frameworks are static and therefore can be linked only to extensions' target.

Fixed by PR #96


createConfigGetter tries to stringify route causes 'Converting circular structure to JSON'

This line in createConfigGetter https://github.com/react-community/react-navigation/blob/master/src/routers/createConfigGetter.js#L68 tries to call JSON.stringify on the route is problematic. It prevents users from passing javascript object params. This sometimes results in the error: Converting circular structure to JSON

Having this same issue as well. For now to resolve the issue I have to flatten my params object.
this:
{
  param1: "value 1",
  param2: {
    param2_1: value 2
  }
}

become this:
{
  param1: "value 1",
  param2_1: value 2
}

The problem doesn't happen for me on the initial route pushed, but the next route.

this issue has been blocking me for the past week. I thought I did something wrong and re-installed different versions of my dependencies, but I am now convinced that this code is bugged. createConfigGetter shouldn't call JSON.stringify on an object as complex as a route and it is sad that the code is evaluated every time even if the invariant() call is ok.  I've had to modify the source code of the module to bypass that.
Note: I'm using react-native-router-flux, so maybe it's not 100% the fault of react-navigation but I think this comment is still relevent 😄

I'm getting this issue using pure react-navigation (not using react-native-router-flux like @m-vdb).
@mikemurray did you flatten the params object programmatically?

One workaround is to override toJSON in the object that is being passed as a navigate param.

@farhanmannan Sorry for just seeing this. No, I flattened them manually if the problem occurs. Most of my data is in redux, so I can get away with less complex structures in navigation.

I don't control exactly "what is passed as a navigation parameter" because i use a library on top of this one. But I truly believe that debug code shouldn't try to convert objects to JSON. That's just bad practice and decreases performances

I was having this problem because I store my component in SetParams.  This allows me to access component state, props and methods from within my header which is really convenient but I worry about passing in complex objects.  For now using the toJSON method of dealing with this specific issue.  Most of my data is also in Redux.

What's currently on master is no longer an issue for me now. https://github.com/react-community/react-navigation/blob/1b761cf9d1a82a62255976080c81612e25bc896f/src/routers/createConfigGetter.js#L68 JSON.stringify is no longer called on the route unless !route || !routes || index == null.

AMAZING!

you don't need to use master, just the latest release. this was fixed in https://github.com/react-community/react-navigation/pull/2693


Fix email comparisons to be case insensitive

Fixes #24899 (comment)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.758%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/accountManagement/browser/accountManagementService.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30827

Relevant Lines:
69081

💛  - Coveralls


[PyTorch] Debug dtype casting in operation-based API

Description
Some users initialize model dtypes using module casting functions like torch.nn.Module.float. However, we experience weird errors when casting fusible operations, largely because the module casting functions don't properly handle Float8Tensor. This PR monkey-patches some module casting functions (float, half, bfloat16) so they properly handle Float8Tensor. This PR also adds logic in the linear operation to respect PyTorch autocasting.
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes

Support setting Float8Tensor.data to arbitrary tensors
Monkey-patch module dtype cast functions (e.g. torch.nn.Module.float) to handle Float8Tensor
Respect PyTorch autocast dtype in linear operation

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch

/te-ci pytorch


Broken urls to samples in MIVisionX documentation

On index page of documentation - https://rocm.docs.amd.com/projects/MIVisionX/en/latest/doxygen/html/index.html
When we scroll to Applications all urls in this section return  404 error

If we click from left menu Applications we get page with working urls.

@pibesk thanks for bringing this to our attention. We will get this issue fixed.

@randyh62 let me know if this issue is resolved; we can close this issue.

It is fixed.

@pibesk -- thanks for bringing this to our attention; we have resolved the issues. Please reopen this issue if you find any other unexpected behavior.


Add can_push option to deploy key creation

Closes #264
The can_push option is set to false as default like the GitLab API behavior.
IMHO, it should be released on a patch version because it's a missing option fix.

Thank you!

@fbourigault Thank you for the merge! Any ETA for a release?

I just released 9.5.0. Enjoy!


CLI Crashing when creating new app after the release of new prisma-store-adapter version

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
App
Expected behavior
It should create a new app with latest versions
Actual behavior
I think it is because of the new version release.
Peer dependency error when shopify runs npm install in the creation process of the app
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@shopify/shopify-app-session-storage-prisma
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
image
Verbose output
── external error ──────────────────────────────────────────────────────────────────────────

Error coming from `npm install`

Command failed with exit code 1: npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: efficient-conversion-app@undefined
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@shopify/shopify-api
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@shopify/shopify-app-session-storage-prisma
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/shine18/.npm/_logs/2024-01-10T20_56_50_148Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/shine18/.npm/_logs/2024-01-10T20_56_50_148Z-debug-0.log

────────────────────────────────────────────────────────────────────────────────────────────

Reproduction steps
1.Run the command npm init @shopify/app@latest
2.Follow all the steps to create an app in Remix and Javascript
Operating System
Mac OS
Shopify CLI version (check your project's package.json if you're not sure)
3.32.1
Shell
No response
Node version (run node -v if you're not sure)
No response
What language and version are you using in your application?
No response

I have the same issue.

Sorry, on the newest version and
❯ npm --version
9.2.0
❯ node --version
v19.4.0
works fine now.

I am getting the same error... and currently on below:
❯ npm --version
10.2.4
❯ node --version
v21.6.0
is there a quick way to update these dependencies on an ongoing basis, like do a routine check? something like npm update @shopify/app@latest or something........


Mdiedrich rz master

Code is good and works fine - while not solving the directory separator problem in a windows environment it should be merged to master :).

Try the updated branch now.


No documentation on Containerized Build Agents

Document does not cover an alternate method of deploying an agent which Microsoft provides, which is via Docker Container.  https://github.com/Microsoft/vsts-agent-docker

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23328b13-f079-ad21-5d7a-6c640f25391c
Version Independent ID: 4a39889d-fa00-ae2b-aa43-f358631b7b1a
Content: Deploy a build and release agent on Linux - Azure Pipelines
Content Source: docs/pipelines/agents/v2-linux.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

This is in progress. I need to get it moved into the docs repo once it's ready.

Dupe of #1494


Move to Crystal Community org?

@crystal-community @benoist objections?

Nope go ahead!

Awesome, thanks


when does the editor update the p5.js library files?

Apologies if this is already implemented or discussed elsewhere, but a quick search did not reveal.  When does the editor update the p5.js library?  Does it do this only with new editor releases?  Should we have an option to "check for new p5.js library" on a per project basis?  Or just for the editor to use when making new projects?  We certainly shouldn't override library files in existing projects unless the user asks to.  A simple behavior might be to just check each time on launch and ask "do you want to update p5.js?"  How can we make this clear to the user that this is different than updating the p5.js editor itself?

+1

expected change! it really not convenient for  to update p5.js manually.

+1

+1 This caused much confusion while using p5.js to teach.


Installers could offer to download and install images tarball

For each release, we create a ddev_docker_images tarball, for example https://github.com/drud/ddev/releases/download/v1.11.2/ddev_docker_images.v1.11.2.tar.xz
This is very easily loaded and much faster than the docker pull that happens in the normal course of ddev start.
It would be nice if our installers (Windows, homebrew, other)? Could at least optionally offer to download and install this. Or install it if it's already found.

We no longer build the images tarball, and this never got any traction, so closing.


CLN: Simplify the logging module

Python - Question on logging in __init__.py

Added class-based loggers with https://github.com/Jython1415/zolltools/commit/3a8e926969c10bad04173b48ff980a1811ac4486.


phraze: 0.3.12 -> 0.3.13

Description of changes
https://github.com/sts10/phraze/releases/tag/v0.3.13
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 331142 run on x86_64-linux 1

1 package built:

phraze


:sparkles: Combined Status User-Spec-API Result API & Calculation

Summary
This PR is the 2nd of the ones planned in epic #2143. This PR:

Introduces API updates to Bindings that reflect association with StatusCollectors
Extends and modifies the Binding controller to calculate these associations

TODO: documentation
Notes:

I chose to save a list of all used StatusCollectors at the Binding's spec flat level, then reference the list through indices per selected object (if was selected by a test that has StatusCollectors)

I have no strong preference over keeping the API this way or duplicating references. Opinions are welcome.

TESTING:

I have not extended the current tests because we practice testing the expected end state, and at the moment we only have the intermediate state of calculated Bindings. I have manually covered the following:

BindingPolicies selecting objects without StatusCollectors
BindingPolicies selecting an object with multiple StatusCollectors

Modifications to the latter

BindingPolicies selecting two objects with all possible variations on 2 objects x 2 StatusCollectors

If @MikeSpreitzer or anyone else believe that tests that check for Binding states are essential at this step, I will execute. Though recall that #2150 should cover automated testing and is a completion criteria of the epic

Related issue(s)

#2143
#2140

Closes #2140

/cc @ezrasilvera
/cc @pdettori
/cc @MikeSpreitzer
/cc @nirrozenbaum

@MikeSpreitzer thanks and apologies for the delayed response. Addressed your comments.
The force-push rebases on main.

@MikeSpreitzer thanks, addressed all.


Replace csv.reader with pd.read_csv

This PR replaces csv.reader with pd.read_csv to avoid the "field larger than fied limit" error.

The pandas docs state the C backend is faster while the Python/csv.reader backend is more feature-complete.


PARQUET-1586: [C++] Add --dump options to parquet-reader tool to dump def/rep levels

Codecov Report

Merging #4385 into master will increase coverage by 0.97%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4385      +/-   ##
==========================================
+ Coverage   88.35%   89.33%   +0.97%
==========================================
  Files         781      636     -145
  Lines       98748    87370   -11378
  Branches     1251        0    -1251
==========================================
- Hits        87250    78052    -9198
+ Misses      11262     9318    -1944
+ Partials      236        0     -236

Impacted Files
Coverage Δ

cpp/src/parquet/printer.h
100% <ø> (ø)
:arrow_up:

cpp/src/parquet/printer.cc
88.74% <100%> (+4.6%)
:arrow_up:

cpp/src/parquet/reader-test.cc
100% <100%> (ø)
:arrow_up:

cpp/src/parquet/column_scanner.h
95.6% <100%> (-0.87%)
:arrow_down:

cpp/src/plasma/thirdparty/ae/ae.c
70.75% <0%> (-0.95%)
:arrow_down:

go/arrow/ipc/writer.go

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/ipc/file_reader.go

... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184b8de...2d5c9e3. Read the comment docs.

The unit test that was added here appears to have trailing whitespace at line ends, which makes things very difficult in text editors that are configured to strip trailing whitespace. I will try to fix

I'm going to disable that particular output check and open a JIRA. Having trailing whitespace in files is not a good idea

I'm going to disable that particular output check and open a JIRA. Having trailing whitespace in files is not a good idea

I'll fix this as part of ARROW-5433 by adding column separator '|'


collector losed elasticsearch

Question
The skywalking service has ran a few days and everything seemed normal. A sudden error came over the weekend. the version of elasticsearch is elasticsearch-5.6.6,and it runs normaly.The following is the error message
Caused by: org.elasticsearch.transport.NodeNotConnectedException: [node-198][<IP_ADDRESS>:9300] Node not connected
at org.elasticsearch.transport.TcpTransport.getConnection(TcpTransport.java:654) ~[elasticsearch-5.5.0.jar:5.5.0]
at org.elasticsearch.transport.TcpTransport.getConnection(TcpTransport.java:116) ~[elasticsearch-5.5.0.jar:5.5.0]
at org.elasticsearch.transport.TransportService.getConnection(TransportService.java:530) ~[elasticsearch-5.5.0.jar:5.5.0]
at org.elasticsearch.transport.TransportService.sendRequest(TransportService.java:506) ~[elasticsearch-5.5.0.jar:5.5.0]
... 44 more
2018-05-27 11:16:55,870 - org.apache.skywalking.apm.collector.cache.caffeine.service.ApplicationCacheCaffeineService -55218578 [grpc-default-executor-1374] ERROR [] - None of the configured nodes were available

Have you checked your elastic search status? Look like your elastic search is out of service.

elasticsearch is ok.

maybe you can give me a statement that i can query

I think the ElasticSeach client controls the connections by itself. @peng-yongsheng Do you have, or should have, any mechanism to control connection?

If the connection is not available, you should report a timeout error. This can be restarted by SW to verify.

Take a look at this issue. Elastic Search Project Issues 28062

sorry.  One more es service was started.


Copyright claim in HFactoryTest.java?

Hi,
The following file in the repository contains a copyright claim:
https://github.com/hector-client/hector/blob/6c75206381f8b4987fecfc37f4aa944730c9495a/core/src/test/java/me/prettyprint/hector/api/HFactoryTest.java

Here is the reference to the similar issue for another file - https://github.com/hector-client/hector/issues/129
I request you to confirm if this file can be fixed as well if the header was placed by mistake.
Thanks,
Yash

Hi Yash,
Please refer to the following line in the README:
https://github.com/hector-client/hector/blob/master/README#L3
Cheers,
-Nate
On Fri, Feb 11, 2022 at 3:32 AM yashkohli88 @.***>
wrote:

Hi,
The following file in the repository contains a copyright claim:
https://github.com/hector-client/hector/blob/6c75206381f8b4987fecfc37f4aa944730c9495a/core/src/test/java/me/prettyprint/hector/api/HFactoryTest.java
[image: image]
https://user-images.githubusercontent.com/94100498/153427209-8912c8f4-eeff-439b-9e8a-139f9b409982.png
Here is the reference to the similar issue for another file - #129
https://github.com/hector-client/hector/issues/129
I request you to confirm if this file can be fixed as well if the header
was placed by mistake.
Thanks,
Yash
—
Reply to this email directly, view it on GitHub
https://github.com/hector-client/hector/issues/679, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABNJYXX5WWAGNERFYKQFM3U2PD7HANCNFSM5OA5BNLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Benchmark tests after implementing order promotions.

Issue: https://github.com/saleor/saleor/issues/15350
The PR adds benchmark test after implementing order promotions.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[ ] All indexes are added concurrently in migrations
[ ] All RunSql and RunPython migrations have revert option defined

Unsubscribe
On Wed, 7 Feb 2024, 4:53 pm Piotr Zabieglik, @.***>
wrote:

Merged #15359 https://github.com/saleor/saleor/pull/15359 into
feature/gift-promotions.
—
Reply to this email directly, view it on GitHub
https://github.com/saleor/saleor/pull/15359#event-11731316077, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKN7GDK7SFSHD447Z5H4RTYSNTK7AVCNFSM6AAAAABC2VR6G6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG4ZTCMZRGYYDONY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Bug: Lexical adds word-break and white-space properties which cause different rendering

By default lexical adds white-space: pre-wrap and word-break: break-word to the editor element to function properly. We are planning to use Lexical in a visual editor, where you can inline edit texts with Lexical. After the editing done, we destroy Lexical. The problem is when we init or destroy the Lexical editor, there is a moment of change in the text as the default white-space and word-break value is different. You can see on the following video when entering/leaving Lexical, there is a small horizontal jump in the first line of text.
Screen recording: https://youtu.be/AjeoYTn5Tgg
        requestAnimationFrame(() => {
            blockElement.style.removeProperty('white-space'); // We must remove Lexical white-space:pre-wrap to give identical result during editing.
            blockElement.style.removeProperty('word-break'); // We must remove Lexical word-break: break-word to give identical result during editing.
        });

If we remove those two properties the editor fails to create space-s after specific blocks. For example if your cursor is after an  tag, then you can not create space after that, but you can type.
Related to: https://github.com/facebook/lexical/issues/71

Can you replace spaces with   on lexical destruction and roll it back when user tries to focus back?

@nextend I am unable to reproduce the issue. Do you have any demo or code-sandbox link ?

https://github.com/facebook/lexical/blob/main/packages/lexical/src/LexicalEditor.ts#L976 has a default value for word break. The best way I found to overwrite was to write a plugin and do:
editor.registerRootListener(root => {
  if (!root) return;
  const style = root.style;
  style.wordBreak = 'break-all';
});


feat(pubsublite): publish and subscribe samples for Pub/Sub Lite

Adds samples for publishing and subscribing using Pub/Sub Lite.

@hongalex Can you please review these. I haven't been granted access to this repo and can't add reviewers. Thanks!


Which port number to access after startup

npm install
npm start

You can check localhost:3000

After I started using npm again, I saw the prompt of port number 3000, as if it was not there for the first time. Thanks.

 Happy coding :)

Sign in with Google will flash back, and there is no prompt in the background.Can not log in.

After clicking "sign in with google", it will start the program that pops up the google login box, but it disappears without popping up. I have tried Google, Firefox, and Safari browsers, but the login box cannot pop up normally and then disappears.

that's because in firebase you didn't add your domain as authorized i guess, or else check the firebase config

It may be the problem you mentioned. I created a new application in Google's firebase, added the Authentication function, and replaced the generated firebaseConfig with the content in ~/src/firebase/config.js, but it is still an old problem. A dialog box pops up showing invalid operations, and then The login box will not pop up.There is no error when running in the background

Did I describe clearly, is there any problem with this configuration? I set my firebase config info in config.js.


Add RadioButton components

Fixed Issues
Needed by https://github.com/Expensify/App/pull/7813#discussion_r819489038
Tests
Tested in https://github.com/Expensify/App/pull/7813#discussion_r819489038
PR Review Checklist
None
Screenshots
Web

Looks pretty good, but maybe we want just a little bit less space between the radio button and the text? I think we want something like 12px between them.

Ok, changing the margin for checkbox labels too then.
Before:

After:

Updated!

Updated!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.1.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check.
We've also updated the item in the checklist with this PR to avoid this issue in the future.


Tag release build with SDK version for pre-VMR releases

Brought up by https://github.com/dotnet/release/issues/864#issuecomment-2018589513
Currently the release builds are tagged with the Release version, which normally corresponds to the runtime version being released.
This can be confusing for pre-VMR releases that mostly use the SDK version for tagging / artifact naming purposes.

Yeah, this isn't relevant anymore since it was specifically for pre-VMR releases.


merge to nginx 1.7.2

still working merge to current stable version.

found have someone merged to 1.8.0 to master


Tor v3 neutrino backend support

Background
Tor v3 Bitcoin Core address is not resolved when passed in neutrino.connect=
Your environment

lnd v0.13.1
Linux raspberrypi 5.10.60-v8+ aarch64 GNU/Linux
Bitcoin Core version v22.0.0
RaspiBlitz v1.7.1rc2

Steps to reproduce
add a Tor v3 address to lnd.conf with the options:
[Application Options]
feeurl=https://nodes.lightning.computer/fees/v1/btc-fee-estimates.json

[Bitcoin]
bitcoin.active=1
bitcoin.node=neutrino

[neutrino]
neutrino.connect=longaddressxxxxxxxxxxxxxxxxx.onion

[tor]
tor.active=true
tor.v3=true
tor.socks=9050
tor.control=9051

Expected behaviour
Bitcoin Core has moved to Tor v3 addresses by default in v0.21.0 and the Tor network is deprecating the v2 services as well.
LND should be able to connect to a v3 neutrino enabled backend.
Actual behaviour
Error in lnd.log:
[WRN] BTCN: unable to lookup IP for longaddressxxxxxxxxxxxxxxxxx.onion: invalid onion v2 host: longaddressxxxxxxxxxxxxxxxxx.onion

Closing as a duplicate of: https://github.com/lightningnetwork/lnd/issues/4973


Update soroban examples

Preview is available here:http://developers-pr516.previews.kube001.services.stellar-ops.com

Yeah, I think extracting a component would be a great idea. I didn't want to prematurely try to add a new abstraction, but I get down to it once every single article is converted (there's just one left but will require a new soroban-cli release because it doesn't work on Windows at all).


nixos/xsslock: wait until pgrep xlock succeeds

Motivation for this change
Please refer to the conversation in the original PR (#40619) for further
reference: https://github.com/NixOS/nixpkgs/pull/40619#issuecomment-390437845
It takes some time after the standby to trigger the locker which might
break the test on Hydra.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The x86 failure is unrelated. I've seen these several times before. Looks like a sporadic issue on the hydra builder  - the VM doesn't find its primary disk.


Document the process of locally developing Dev deployments when we make changes to the base images

Right now Dev Deployments use the daily-dev tag from the quay.io repo by default, making impossible to test new changes to the dmn-dev-deployment-base-image image without publishing a build somewhere else and altering the env vars.
Think about:

Build:dev and Build:prod
Development workflow with

Local K8S
Remote K8S/OpenShift

Questions:

How do I test my local changes when developing to a local K8s?
How do I test my local changes when developing to a remote K8s/OpenShift?
How do I merge my PR without breaking the main branch when I made changes to the base images?

Notes:
Cross-compiling images: E.g., I’m on an Arm-based macOS but want to use my image on OpenShift, which only supports x86. We need to use Buildkit to do that.
Have a script ready on package.json to do that. Configuring Buildkit needs to be done prior.

lnbc1400u1pnkatccpp50qv23c8usfz9gu3dne4m5htvn265fdhauemgxc3qgtcne97s272qdxj2pskjepqw3hjqnt9d4cx7mmvypqkxcm9d3jhyct5daezq2z0wfjx2u3qf9zr5grpvd3k2mr9wfshg6t0dckkyv3kx33kzd33xcenwvmz8pjxgvphx5ekydesve3nvc33xvmxzcnrxqenxep3xp3kydrrvf3n2en9xajrxwfnvvuxzetxvsenvwpkvcknzdenx5enqdesxvcn2ve49ycqzpuxqz6gsp5jurwwxr2tdv76g7896nhd9tur7curx4lqq7ts27r80x5yyy4wptq9qxpqysgqpfvhfjj2xwmhklcxpw4xlajes5lw8fpakz452g98k52qwcpcqq2jffd55hnh6fpequ8fujy6aeaq6v80hff9jey5v6y0mnrsk7ah87qqg6fuey of that new id _


Ansys OB Downloads Legacy

https://main--zemax--hlxsites.hlx.page/pages/ansys-ob-downloads-legacy

The highlighted text needs to be shrunken down to be just regular bold text.

@Anthony-Hopkins-star - Some of these changes does not need any code modification rather simply getting to the document , changing the text style , preview and publish should fix it.
In this case , this is what i have done

Opened the document ( the path in sharepoint is 1:1 with page urls in the browser)  -> https://adobe.sharepoint.com/:w:/r/sites/HelixProjects/_layouts/15/Doc.aspx?sourcedoc={FFE0FC31-2EF1-400A-981B-4E53D7877CEA}&file=ansys-ob-downloads-legacy.docx&action=default&mobileredirect=true

Highlighted the text "Before downloading, please note the following: "

Changed the test style from H4 to Normal and Bolded. the text

Preview from side kick to verify the desired results

And published


Forest integration and unit tests

Issue summary

[ ] Locally runnable unit and integration tests
[ ] No test scripts
[ ] Segregated network tests

Other information and links

Are you not able to run the tests locally?

Not our integration tests - they fetch gigabytes from the web, and take ages, hence wanting segregated tests with a single test runner

Could you please elaborate on how those would those segregated tests look like? Unless you're on cellular, they shouldn't take long, even locally.

Updated the description :)

Maybe I should simply get a better PC
        PASS [  10.530s] forest_key_management keystore::test::test_generate_key
        PASS [  10.707s] forest_key_management keystore::test::test_read_write_encrypted_keystore
        PASS [  36.846s] forest_utils io::writer_checksum::test::file_writer_fs_buf_writer
        LEAK [  53.346s] forest_libp2p_bitswap::go_compat tests::bitswap_go_compat_test
        SLOW [> 60.000s] forest-cli::config test_download_location_of_proof_parameter_files_default
        SLOW [> 60.000s] forest-cli::config test_download_location_of_proof_parameter_files_env
        SLOW [> 60.000s] forest-daemon::import_snapshot_tests importing_bad_snapshot_should_fail
        PASS [  77.934s] forest-daemon::import_snapshot_tests importing_bad_snapshot_should_fail
        PASS [ 117.726s] forest-cli::config test_download_location_of_proof_parameter_files_env
        PASS [ 118.712s] forest-cli::config test_download_location_of_proof_parameter_files_default
------------
     Summary [ 118.753s] 227 tests run: 227 passed (3 slow, 1 leaky), 0 skipped


NPE check for empty dashboard components.

For empty dashboard components, a NPE is thrown. Modified code to handle that situation.

Mergred


Fix most clippy::pedantic lints

🐙 Consider merging this with Create a merge commit or Rebase and merge rather than Squash and merge (documentation), as squashing would destroy the separation between individual commits whose messages provide context for each change.

This appeases all clippy::pedantic lints except the following.

9 implicit_hasher: probably unhelpful for us
5 inline_always: have these been benchmarked?
121 match_same_arms: maybe some of these should be merged, further investigation needed
29 missing_errors_doc: possible documentation improvements
17 missing_panics_doc: possible documentation improvements
13 module_name_repetitions: unclear what a better alternative would be
72 must_use_candidate: maybe worthwhile, but noisy
82 semicolon_if_nothing_returned: opened rust-lang/rust-clippy#9929
6 similar_names: meh, they are as different as they should be
29 too_many_lines: we write lots of code I guess
16 unnecessary_wraps: some of the Result<> wrappers detected as unnecessary are places where we’re ignoring errors that we probably shouldn’t

Wow, respect! Will rebase + merge.


Incorrect code for detecting whether functions gui is open in functions_common.py

https://github.com/knausj85/knausj_talon/blob/master/lang/tags/functions_common.py#L28
https://github.com/knausj85/knausj_talon/blob/master/lang/tags/functions_common.py#L55
tags.add and tags.discard don't exist, because tags is a frozenset; we can't mutate it. Instead we have to set it to a new list. This code could use a re-examination for other bugs. I think this only affects the command to close the functions gui, and even then only if we have left a programming context, because in a programming context the command is defined anyway.

Sounds reasonable to me

@rntz Looks like this problem is solved now. Correct?


ValuePlug : Reject children which are not ValuePlugs

Previously we accepted all children because the CompoundPlug derived class needed that for backwards compatibility. We now only provide the compatibility when we detect that we are actually a CompoundPlug. This closes a loophole that allowed abuse of ValuePlugs, and will allow us to detect any problems before we finally remove CompoundPlug at a later date.
@ivanimanishi, I think Jabuka is still mostly using CompoundPlugs and should be unaffected, but you'll probably want to test this PR just to be sure. Getting this merged isn't particularly urgent, but it is an important step in getting things tidied up, so it'd be nice to get it out of the way.

I've added the ability to subclass ValuePlug in python, in an attempt to entice @ivanimanishi to take a look at merging this :) The subclassing is just to create new compound types, not to store a value directly, so it's equivalent to the old CompoundPlug subclassing. I did implement full subclassing ability but I haven't included it in the PR because I want to encourage the use of C++ for that kind of thing. It's here if anyone wants to experiment with it at any point though.


Chore - TypeScript 5 upgrade

"typescript": "4.9.5" = > "5.3.3"
"@typescript-eslint/eslint-plugin": "5.62.0" => "6.21.0"
"@typescript-eslint/parser": "5.62.0" => "6.21.0"
"update-ts-references": "2.6.1" => "3.2.1"
"ts-jest": "29.1.1" => "29.1.2"
"ts-node": "10.9.1" => "10.9.2"
Adapt code for newer eslint and TS.

Thanks all.


Added "empty array" to what will return a false

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

[] is coerced to true, not false.


chore: promote cucumber-test to version 0.0.3-SNAPSHOT

chore: promote cucumber-test to version 0.0.3-SNAPSHOT
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign q1323829945
You can assign the PR to them by writing /assign @q1323829945 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add negative ammount of items to basket [⭐]

:star: Challenge idea
Description
I' able to add negative ammount of items to basket. (-100)
Underlying vulnerability/ies
Expected difficulty
Very easy, just call api with negative ammount.

[ x] :star:
[ ] :star::star:
[ ] :star::star::star:
[ ] :star::star::star::star:
[ ] :star::star::star::star::star:
[ ] :star::star::star::star::star::star:

Possible attack flow
This should be trouble in some billing-refunds or cashback systems.
I.E. shop is refunding back to your account rest of money. If you have -$100 , then please send me back.

A challenge for this API issue already exists: https://pwning.owasp-juice.shop/part2/improper-input-validation.html#place-an-order-that-makes-you-rich


[WIP] server: export unique identifier for instance

The change provides a plugin for the containerd instance to export a
unique id for each containerd instance. The id is such that if the
entire root directory, such as /var/lib/containerd, is removed, the
instance will get a new id. This is also a solid place to export other
values that describe the configuration of the containerd instance.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>Closes #1862

Looking for feedback here.

@dnephin Looks like a pretty nasty false positive:
server\server.go:331:2:warning: unused variable or constant randomIDEntropyBytes (varcheck)
Makefile:65: recipe for target 'check' failed
mingw32-make: *** [check] Error 1

Im not sure this should be a plugin.
Can we move this to the Version service API?
(And maybe rename Version service to DaemonState API)

Looks like a pretty nasty false positive:

Yup, looks like this is fixed upstream in https://github.com/opennota/check/commit/3891eb67f20ecc6c5411d90fe9aa516648b6cffc. I'll get this fixed in the gometalinter vendor. You can whitelist it with // nolint: varcheck if you need to get this in before Monday.

@AkihiroSuda What does this have to do with the daemon Version?

Btw, here is the output after this PR:
~/g/s/g/c/containerd ❯❯❯ sudo ctr plugins -d id==instance                                                                                ⏎ export-unique-id ✭ ✱ ◼
Type:        io.containerd
ID:          instance
Exports:
             id      ijoafi9xdx71dx1t1tgpvk6cd

Moving this to 1.1, as it may require more discussion.

lint failure will be fixed when https://github.com/alecthomas/gometalinter/pull/403 merges

What does this have to do with the daemon Version?

Nothing, but both the version and the ID are singleton.
So I'm not sure whether we should have the "instance" plugin, while the plugin model is (IIUC) designed for non-singleton stuff.
At least, I think we should explicitly prohibit registering multiple "instance" plugins.

What's current status?

@AkihiroSuda I'm luke warm on whether or not this is actually required. It seems like bloat to me.

It seems like bloat to me.

I agree, we shouldn't have a new API just passing down a single value. Can we export this on the introspection or version plugins?

I am going to close this for now. We seem in agreement that if we set such an identifier, it should be part of another service. Additionally we have moved away from a requirement for entropy on startup, so we likely need to figure out a different solution for this.


Add node-to-node encryption option

Corresponding Issue(s) or trello card(s):
None (I thought I had seen one for this but cannot find it for looking)
Summary of change(s):
Add node-to-node encryption option
Will the change trigger resource destruction or replacement? If yes, please provide justification:
You have to enable encryption at creation, as long as you don't try to change this setting for an existing resource it won't try to replace.
Does this update/change involve issues with other external modules? If so, please describe the scenario.
No
If input variables or output variables have changed or has been added, have you updated the README?
Yes
Do examples need to be updated based on changes?
Yes and done
Note to the PR requester about Closing PR's
Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.
This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

would it be useful for encryption variables to mention limitations? (e.g. encryption on storage is only works for >= 5.1 and encryption in transit only works for >= 6.0

Good call out.  Don't think any logic checks are necessary, but a note in the description wouldn't hurt.

Thanks gents, update pushed


Deprecate and clarify docs and specs location

Deprecation notice
After a discussion in the issue https://github.com/huggingface/model_card/issues/5 it seemd that this is the next move.
If you all are OK with that, we could merge this and archive this repo.
I'm not the best at writing documentation, so feel free to patch my writing.

cc @mmitchellai


Problem with 1Password 6.3?

sudolikeaboss no longer works for me.
I've recently upgraded iTerm2 to 3.0 and 1Password to 6.3.1.
This is from the 1Password helper log:
08/06/16 10:56:46,929 2BUA8C4S2C.com.agilebits.onepassword4-helper[2524]: 631006 [EXT:(Secondary Thread 0x7ff77ee25160):<OP4ExtensionHTTPConnection: 0x7ff77ee8c940>] M webSocketForURI: | [ES4] Extension connected Chrome-Extension 'chrome-extension://aomjjhallfgjeglblehebfpbcfeobpgk / (null)'
08/06/16 10:56:47,008 2BUA8C4S2C.com.agilebits.onepassword4-helper[2524]: 631006 [EXT:(Secondary Thread 0x7ff77ee25160):<OP4ExtensionClient: 0x7ff77eea3190>] E findExtensionProcessForPort: | Failed to find extension process for 'chrome-extension://aomjjhallfgjeglblehebfpbcfeobpgk:63185', my PID: 2524, invalid output: '2524 27055 ', apps found: ( )
08/06/16 10:56:47,008 2BUA8C4S2C.com.agilebits.onepassword4-helper[2524]: 631006 [EXT:(Secondary Thread 0x7ff77ee25160):<OP4ExtensionClient: 0x7ff77eea3190>] E findExtensionProcessForPort: | Stopping connection since no PID was found to validate the other side of the connection.

See #19.

@thejandroman Thanks. Didn't think to look at closed issues.


Add events?

What about dispatching an event after sms sending?
We could easily inject an optional Psr\EventDispatcher\EventDispatcherInterface.php object to Client constructor.
If object is not null, we could dispatch an event with useful information (recipient, content, response).
This can be back-compatible: if object is null, we can just ignore it.

Hey there, @garak! Sounds good to me, interesting feature. Can you  make a PR for this one?

Of course, I'll do it in the next days

Thank you 😄 🚀


Support enum is codegen

Handling enum types can be useful, like for generating cheatsheet for langs mapping enum to json

see: https://github.com/vert-x3/vertx-web/issues/125

another use case is generation of Ceylon enums.


Issue with TCPRoute Informer not Syncing

having some issues with TCPRoute Informers not Syncing.
The following code:
package main

import (
	"context"
	"fmt"
	"time"

	specsv1alpha1 "github.com/deislabs/smi-sdk-go/pkg/apis/specs/v1alpha1"
	fakeSMISpecs "github.com/deislabs/smi-sdk-go/pkg/gen/client/specs/clientset/versioned/fake"
	specsInformer "github.com/deislabs/smi-sdk-go/pkg/gen/client/specs/informers/externalversions"
	"k8s.io/client-go/kubernetes/scheme"
	"k8s.io/client-go/tools/cache"
)

func init() {
	err := specsv1alpha1.AddToScheme(scheme.Scheme)
	if err != nil {
		panic(err)
	}
}

func main() {
	client := fakeSMISpecs.NewSimpleClientset()

	specsInformerFactory := specsInformer.NewSharedInformerFactory(client, 0)

	httpRouteGroupInformer := specsInformerFactory.Specs().V1alpha1().HTTPRouteGroups().Informer()
	tcpRouteInformer := specsInformerFactory.Specs().V1alpha1().TCPRoutes().Informer()

	httpRouteGroupInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{})
	tcpRouteInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{})

	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
	defer cancel()

	specsInformerFactory.Start(ctx.Done())

	for t, ok := range specsInformerFactory.WaitForCacheSync(ctx.Done()) {
		if !ok {
			fmt.Printf("timed out waiting for controller caches to sync: %s", t.String())
		}
	}
}

When run:
% go run test.go
timed out waiting for controller caches to sync: *v1alpha1.TCPRoute

With the TCPRoute informer commented out:
% go run test.go
%

and with the HTTPRouteGroup informer commented out:
% go run test.go
timed out waiting for controller caches to sync: *v1alpha1.TCPRoute

Not sure where to go from here.

As a follow up, referencing the dependencies with the following versions:
	github.com/deislabs/smi-sdk-go v0.2.0
	k8s.io/client-go v0.0.0-20190819141724-e14f31a72a77


add docker-environment

This is the same as #1079, but got closed there automatically, because your master seemed to have rebased/changed.
This really got me fast up and running again, if you see no value in this just close, I'll keep it as single commit in my repo.

@kurahaupo ah seems like you added this as a new branch to your project:
https://github.com/jberkel/sms-backup-plus/commits/cyber1000-docker/
if you don't want this in the master the best may be to squash these 3 commits and just have a single commit you may apply with cherry-pick when needed.

Then it seems you may close this new PR.

Thanks for this. I'll have a look