[2022-05-01] Update parameter name of Database ARM API swagger changes for vbs enclaves

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. September 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 9/2
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@vidit-msft - Please set your PR to Open and ping the current ARM reviewer on-call when your PR is ready for ARM review.

@xiaoxuqi-ms can you help to review and merge this PR? thanks~

@xiaoxuqi-ms Please approve and merge this PR. It's been waiting for final approval for almost a week. We want to get this in as part of 2022-05-01 ARM API release, the deadline for its code check-in is tomorrow 9/13 EOD.


Break down resource usage and request throughput in pod Live View by container name.

We want to be able to show the proportional contribution of each container on a pod's resource usage and request throughput.  This change adds that support to do so in the pod Live View.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Natalie Serrino seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] Fix magnetic symmetry

@simonpintarelli Hamiltonian is not guilty. It was a test for hermitian Hamiltonian that wasn't updated. I'm looking into collinear symmetry. Still puzzled.

The only thing I've found so far was a typo in the docstring, it should be dot(R^{-T} G, t} instead of R^{-T}*t, but in the code it is correct...

bors try

bors try

bors try

bors try

bors try

The documentation for symmetry has been updated

@simonpintarelli @mtaillefumier can you have a quick look at it?

The rotation operator is missing in the last formula: It should be
    \f[
       f_{\mathrm{sym}}(R {\bf G}') = \hat{\bf S}f_{\mathrm{sym}}({\bf G})e^{-i R {\bf G'}{\bf t}}
    \f]

I'll rewrite as matrix times G-vector everywhere

Updated page


Create handle using CreateWindowExW always gives "0" as value

This is the code for simple window for unicode I tried:
use bindings::{Windows::Win32::SystemServices::*, Windows::Win32::WindowsAndMessaging::*};
struct Window {
    hwnd: HWND,
}

impl Window {
    fn new() -> Self {
        Window { hwnd: HWND(0) }
    }
    fn run(&mut self) {
        unsafe {
            let instance = HINSTANCE(GetModuleHandleW(None));
            debug_assert!(instance.0 != 0);
            let wnd_class = WNDCLASSW {
                style: WNDCLASS_STYLES::CS_HREDRAW | WNDCLASS_STYLES::CS_VREDRAW,
                hCursor: LoadCursorW(None, IDC_HAND),
                lpfnWndProc: Some(Self::wnd_proc),
                hInstance: instance,
                lpszClassName: PWSTR("window\0".as_ptr() as *mut _),
                ..Default::default()
            };
            RegisterClassW(&wnd_class);
            let hwnd = CreateWindowExW(
                Default::default(),
                "window",
                "Simple Window",
                WINDOW_STYLE::WS_OVERLAPPEDWINDOW | WINDOW_STYLE::WS_VISIBLE,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                None,
                None,
                instance,
                self as *mut _ as _,
            );
            //hwd always get a 0 value when using CreateWindowExW
            //debug_assert!(hwnd.0 != 0);
            let mut msg = MSG::default();
            ShowWindow(&hwnd, SHOW_WINDOW_CMD::SW_SHOW);
            loop {
                let pm = GetMessageW(&mut msg, hwnd, 0, 0);
                if pm == TRUE {
                    TranslateMessage(&msg);
                    DispatchMessageW(&msg);
                } else {
                    break;
                }
            }
        }
    }
    extern "system" fn wnd_proc(hwnd: HWND, msg: u32, wparam: WPARAM, lparam: LPARAM) -> LRESULT {
        unsafe { DefWindowProcW(hwnd, msg, wparam, lparam) }
    }
}

fn main() {
    let mut win = Window::new();
    win.run();
}

NOTE: Tried using Ansi method and it work, but there are some issue with window name
Please give any resourse for dealing unicode PWSTR with rust.

The problem is here:
lpszClassName: PWSTR("window\0".as_ptr() as *mut _),

The API is expecting a wide string but you're providing a pointer to a UTF8 string.


Per-index Memfile Locking Contention

After #2615, we lock a shared in-memory file for string keys in the hash index. Though this works, it is likely (?) a point of contention when strings are long. As mentioned in this comment, one solution is to let each thread grab a page at a time.

For the InMemFile used by the builder, reading concurrently isn't really an issue anyway, so I don't think grabbing a page at a time (if I understand what that means correctly) is really the optimal solution.
There are some ways we can avoid/reduce locking when reading (see here), but I'm thinking that a better way would be to have an overflow file for each concurrent index so that we can do parallel writes. They could even share the same file handle (meaning there would still be some locking for assigning new page numbers, but that's the same as for the main index file), as long as the page index of the next page is stored at the end of each page so that strings broken up between multiple pages can still be pieced back together.
There will of course be a similar amount of unnecessary size overhead with small databases as with the main index file.
Or we could stick with the current serial append (ideally without locks for reads), and limit locking to updating the nextPosToAppend cursor before writing the string (adding new pages at that point) so that the locks are held for as little time as necessary and the actual writes can be done as parallel as possible.

The latter one seems easier and I think we should give a try on that first?

I just realised that my test in #2776 wasn't even using long strings, so our performance is currently really bad even when we don't actually need the memfile (part of the issue is that we're always locking when writing/comparing short strings as well as long strings). The same test with strings of a length of ~29 (random integers with a 21 character string appended) took 239s, which is 108x slower than integers, and 7x slower than short strings.
Note that without reserving strings, the performance on master has changed to 2.2s for integers and 30s for short strings (the extra read/write when rehashing for short strings is evidently more costly than the cost of reading the number of rows ahead of time).
I did a quick test of parallel writes (without actually making sure that the subsequent strings are readable if they cross page boundaries by writing the next page at the end of the file since that's really the only complicated part) and it improved the short string copy to ~6s and the long string copy to ~14s.
Locking only when pre-allocating space to write strings, the short string performance improved to about 6s again (as expected, since we no longer lock for short strings) but the long string test took 159s, which is better than it currently is, but still far worse than with parallel writes.


Update MD file on new branch 2017-29-11_23-12-10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Features/evelyn

Added background image and CSS for background image.

code seems to be good but foot still broken so i'll pull anyway


I have added contributors page issue #343

#481
Description
I have added all the contributors whoever has contributed more than or equal to 5 contributions
Screenshots / videos (if applicable)

Checklist

[x ] I have gone through the contributing guide
[x ] I have updated my branch and synced it with project main branch before making this PR
[ x] I have performed a self-review of my code
[x ] I have tested the changes thoroughly before submitting this pull request.
[x ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
I wanted you to provide me level in asignee so that my contributions get counted.

@priyachau12 it is already added.
Not required.

I have again updated it please review it
As you told me
On Sun, 13 Oct, 2024, 7:55 pm Lakshmi Pavananjali, @.***>
wrote:

@priyachau12 https://github.com/priyachau12 it is already added.
Not required.
—
Reply to this email directly, view it on GitHub
https://github.com/Anjaliavv51/Retro/pull/502#issuecomment-2409000237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A53F6UW7QMC543KNF657WUDZ3J7EVAVCNFSM6AAAAABP3PPDEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGAYDAMRTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

As I have been told to add profile photo instead of adding a hard code
dummy profile picture.
I have updated a code please review it!
On Sun, 13 Oct, 2024, 7:56 pm Priya Chaurasiya, @.***>
wrote:

I have again updated it please review it
As you told me
On Sun, 13 Oct, 2024, 7:55 pm Lakshmi Pavananjali, <
@.***> wrote:

@priyachau12 https://github.com/priyachau12 it is already added.
Not required.
—
Reply to this email directly, view it on GitHub
https://github.com/Anjaliavv51/Retro/pull/502#issuecomment-2409000237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A53F6UW7QMC543KNF657WUDZ3J7EVAVCNFSM6AAAAABP3PPDEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGAYDAMRTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


FN - Tornado cash

Hi @Vxatz:
I wanted to ask about this FN of tornado cash funding.

Exploit transaction: https://bscscan.com/tx/0xde59f5bd65e8f48e5b6137a3b4251afbb9b6240d1036fa6f030e21ab6d950aac
Attacker was funded by TC in several opportunities: https://bscscan.com/address/0x65bba34c11add305cb2a1f8a68cecbd6e75089cd#internaltx
For some reason I ain't see any TC alert: https://app.forta.network/alerts?agents=0xa91a31df513afff32b9d85a2c2b7e786fdd681b3cdd8d93d6074943ba31ae400&limit=15&sort=desc&text=0x65bBA34C11aDd305cB2A1f8A68ceCbd6E75089Cd

Same here:

Exploit transaction: https://bscscan.com/tx/0x86262260db802b391d61d1034f7fbd3571c06208a22dc6b914cacae7165003ed
Attacker was funded by tx a while ago: https://bscscan.com/address/0xb60bc196e0e62b090ff67aa0ab77d159bd707e57#internaltx

@Ivan1905, in both cases I'm getting an alert locally, which makes me think it's a network issue (often happens with BSC nodes I'd say)
One note is that after an account initiates one transaction, it's not considered "new" anymore, so there would be no alert for future funding txs

"One note is that after an account initiates one transaction, it's not considered "new" anymore, so there would be no alert for future funding txs"
What happens when the funding transaction from TC is not new? does it receive a lower score? or it does not fire?
I see that for first case the address received native tokens from an EOA, then was funded by TC. Finally deployed the contract and invoke it.
What would happen for such case?


Please include files from the project in the list of recently opened files.

Issue Type: Feature Request
When there are many files in a project, it can be difficult to find the previously closed files again.
Please add at least one configuration option for setting.
VS Code version: Code 1.49.3 (2af051012b66169dde0c4dfae3f5ef48f787ff69, 2020-10-02T17:56:11.027Z)
OS version: Linux x64 5.4.50-amd64-desktop

In particular, switching back and forth between directories can be a pain to open a file.

Forwarding to @sbatten as I believe he owns the recently opened list. Sorry if I am mistaken.

Ctrl+P shows recently touched files within the project already

Thanks a lot.
But why not put them together with open history?


Add missing SHINE bank

I tried to use the registry to find out the BIC from the couple ("FR", "17418") but couldn't find it in the registry.

@mdomke do you know if there is a way for us to update the generated banks for France?


Added suppliers for loggers

Added overloaded methods for logging.
https://github.com/Azure/azure-sdk-for-java/issues/19523

@ahsonkhan, when you talked about logging in C, I think we discussed the approach taken in this pr as one of the options; tagging you FYI given java now officially supports it.

@jianghaolu @hemanttanwar Can you please check the merge request?

@alzimmermsft  Can you help me to progress to the next steps with this pull request?

@tozsvath thank you for making these changes! Really appreciate your contributions :)


Mention cert-manager-verifier in the docs

@meyskens let me know if you want to move it to different place or word a bit differently :)
Thanks!

@meyskens let me know if you want to move it to different place or word a bit differently :)
Thanks!

Hey @alenkacz
Thanks for this!
We're releasing cert-manager 1.2 soon (next week) so if you have a moment, please test the latest alpha release with your verification tool:

https://github.com/jetstack/cert-manager/releases

Please address the comment by @munnerz so that we can get this merged in.
And I think cert-manager-verifier would make a great addition to the https://cert-manager.io/docs/usage/kubectl-plugin/ so come and join one of our standup meetings if you feel like chatting about that.
/assign @alenkacz

/ok-to-test

@wallrj thank, I fixed the position in the docs and also added tests for 1.2.0 - everything is working, yay.
Yeah I think it would be great addition to that kubectl plugin!

/lgtm

/approve


improve escape sequence handlig in string literal

support following escape sequence

octal number (\023)
hexadecimal number (\x34)

also support echo and ps_intrp command

need to check octal or hexadecimal number format of string literal

change echo and ps_intrp in commit 07b55423fd8d4e2b4d71afb515d26ebae72bc5b2


"Osica de Jos" is listed in the drop-down menu

Description:
When user writes "Osica de Jos" the location appears in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Osica de Jos"
Expected results
The location appears in the drop-down menu as "Comuna Osica de Jos, OLT"


App: do not spawn double the workers when using the launch script

app.js already is the main module when using the launch script due to
the way the module's required. This also removes exports.listen from
app.js, since the launch script was the only place where it was used.
Sockets.listen no longer takes a bind address and number of workers to
use, since those parametres were entirely unused.

Moderate disapproval.
PS should be able to be included as a module without automatically doing anything.

So exports.listen should still be kept?

In hindsight, the changes other than the comments I made seem fine.

Brought back app.listen, made the changes to the comments

Also: "imported as a module"?

Made the other fixes mentioned. I left out the code for allowing bindAddress and workerCount to be passed through process.argv, but if it's something you think would be worthwhile I can add it in.

Works for me.


Expose kubevirt_vmi_vcpu_delay_seconds metric.

What this PR does / why we need it:
Add vcpu delay domain metrics, which reports amount of seconds VM spent in  waiting in the queue instead of running.
According to libvirt docs:
vcpu.<num>.delay - time the vCPU <num> thread was enqueued by the host scheduler, but was waiting in the queue instead of running. Exposed to the VM as a steal time.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Expose kubevirt_vmi_vcpu_delay_seconds reporting amount of seconds VM spent in  waiting in the queue instead of running.

/ok-to-test

Sure!
/lgtm

rpc error: code = Unavailable desc = error reading from server: EOF

timout issues.
/retest

/retest
[FAILED] Timed out after 60.001s.

@0xFelix Sorry for bothering you again. But I had to add exception for this new metric in tools/prom-metrics-collector/metrics_collector.go and I have also added unit test to make sure kubevirt_vmi_vcpu_delay_seconds is exposed. This time all checks are green 😄

@PiotrProkop Thank you for addressing it. I'm not sure about adding new metrics which do not follow the metrics linter rules though. Can't you name it so the linter is satisfied without an exemption?

@PiotrProkop Thank you for addressing it. I'm not sure about adding new metrics which do not follow the metrics linter rules though. Can't you name it so the linter is satisfied without an exemption?

I just kept it in the same manner as other metrics exposed by libvirt(all of them are in exempt list) e.g. :
"kubevirt_vmi_storage_write_times_ms_total"
"kubevirt_vmi_vcpu_seconds"
"kubevirt_vmi_vcpu_wait_seconds"

Yes, those pre-date the metrics linter and need to be changed in the future. Can you change the name of the new metric?

Yes, those pre-date the metrics linter and need to be changed in the future. Can you change the name of the new metric?

Of course, would kubevirt_vmi_vcpu_delay_total name would be alright?

@sradco Can you advise?

We will be fixing the other metrics that failed the linter. We don't plan to keep them in the exception list.
In your case the metric should be called
kubevirt_vmi_vcpu_delay_seconds_total since it is a counter

/retest

Timeouts again:
 [FAILED] Timed out after 60.001s.

/retest

/retest

@sradco @0xFelix I have renamed the metric to kubevirt_vmi_vcpu_delay_seconds_total and all checks are green now.

@xpivarc Can you take a look at this PR?

/cc


BindTo(...) within inherited class constructor does not populate properties

The following illustrates the issue:
using System;
using Nancy;
using Nancy.ModelBinding;
using Nancy.Testing;

namespace Question
{
    public class BaseNancyHandler
    {
        protected BaseNancyHandler(INancyModule nancyModule)
        {
            nancyModule.BindTo(this);
        }
    }

    public class ExampleHandler
        : BaseNancyHandler
    {
        public ExampleHandler(INancyModule nancyModule)
            : base(nancyModule)
        {
            // nancyModule.BindTo(this); // <-- works when this is enabled

            if (string.IsNullOrEmpty(UserName))
            {
                throw new ArgumentNullException(nameof(UserName));
            }

            if (string.IsNullOrEmpty(Password))
            {
                throw new ArgumentNullException(nameof(Password));
            }
        }

        public string UserName { get; set; }
        public string Password { get; set; }
    }

    public class ExampleModule
        : NancyModule
    {
        public ExampleModule()
        {
            Post["/login/"] = _ => new ExampleHandler(this);
        }
    }

    public static class TestExample
    {
        public static void Main()
        {
            Run();
        }

        public static void Run()
        {
            var bootstrapper = new DefaultNancyBootstrapper();
            var browser = new Browser(bootstrapper);

            var response = browser.Post("/login/", (with) => {
                with.HttpRequest();
                with.FormValue("username", "badusername");
                with.FormValue("password", "badpassword");
            });

        }
    }
}

That's because BindTo is generic (public static TModel BindTo<TModel>(this INancyModule module, TModel instance)) and the type is inferred to BaseNancyHandler (which this is). There's no way you'll get that to work because you don't have enough information about the derived type in the base class.
I'm not really sure what you gain by doing this. Why are you returning a handler, which in reality is just a DTO that has the resposiblity to deserialize itself using a Nancy module? It all sounds very weird.

Like @khellang said, this is not a Nancy "problem". There is no way that the base class could know which sub-class this would reference. I'm closing this issue, but feel free to continue with the discussions

See #2102


GSG for Spring Cloud Netflix Hystrix

Doesn’t show the Hystrix Dashboard—just Hystrix (wasn’t sure whether including the Dashboard might make it a bit lengthy).

Based on https://spring.io/admin/projects, I'd put in spring-cloud-netflix as a project tag.

@gregturn Done! :smiley:

Is this superseded by https://github.com/spring-guides/gs-circuit-breaker?

Yes


test(ssl): add tests for ssl/tls #162

fixes https://github.com/coreos/jetcd/issues/162 https://github.com/coreos/jetcd/issues/164

Will rework the pr

@fanminshi anything more I need to change ?

@lburgazzoli looks good in general. I just have few questions.

fixed

lgtm

@lburgazzoli thanks for the fix! appreciated

merge when green.


[FEATURE] Logging of token generation and validation

This adds logging of token generation and validation as well as sending
of activation mails.

@kitsunet Rebased this on master, feel free to check…


Rename components for consistency

closes #133

@youda97 you might need to rename components in tests too.


HAA0102 false positive fixed

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JarLob sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Lol


doc for blank value.

add somewhere in the doc, the include_blank option.
:include_blank => 'Please choose...'

https://github.com/stefanpenner/country_select/commit/c83c550e3e4585c3e9c1b749df65619428aa985d
If you want more examples check out the example app view files linked in the README


Change default retries of benchmark from 5 to 10

This as already be done

This as already be done


Incorrect keys and times in generated error docs

The keys of the error docs generated to record business errors while processing collected usage should include the input usage key and time. To allow this, the error key generation functions should be passed the input key and input time, like the output key generation functions.
Also, it looks like the error docs generated by the usage collector service are missing the usage space id.

For example here:
https://github.com/cloudfoundry-incubator/cf-abacus/blob/46fcfc48beac16e477d355c57d64b11db39c0bd9/lib/metering/collector/src/index.js#L92
The etime(udoc) function should have an additional parameter like this time(udoc, time).
Same idea for the ekey function.

Hi,
I believe #330 will address the issues mentioned here. It also includes a bug fix on the output get api due to 6402cc426fd0d6a1d3929f620d41d07650adb4b2.
The one thing to mention here is that adding the collector's itime(seqid) at the collector's etime will allow duplicate of error docs.


bilibili: allow more arguments

Description of changes
allow extra arguments
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4373

Merge it please.

Be patient. I'm not a committer, and you should wait for the OfBorg checks to finish. Once everything passes, OfBorg will automatically label your PR, and it'll be merged.

What's the point? Can't you define a shell alias?

What's the point? Can't you define a shell alias?

This is most likely needed for the same reason as other Electron/Chromium apps. They're wrapped, and you can't pass arguments to the wrapped binary through the shell, as they'd be sent to the wrapper program instead.
There is a precedent to doing this with google-chrome.

They're wrapped, and you can't pass arguments to the wrapped binary through the shell, as they'd be sent to the wrapper program instead.

I doubt that's true. Do you have an example of a command that doesn't work?

I doubt that's true. Do you have an example of a command that doesn't work?

Not with this package, but I have once tried using google-chrome --proxy-server=<IP_ADDRESS> before I switched to a system-wide proxy. As you're supposed to overlay the package with that argument instead of calling it in the command line, Google Chrome never received that argument, and thus didn't use my proxy.

@dotlambda What do you mean? I just pass the argument to electron instead of pass to bilibili app itself. I work on wayland and fcitx5 can't work properly without --enable-wayland-ime

To be honest, shell wrapper do pass the argument. However, many of chromium based apps do include this.

That's why I think it's unnecessary.
But feel free to ping someone who introduced this overriding possibility elsewhere so they can review your PR.

If I'm understanding this right, this PR would add the ability for the user to override via overrideAttrs inside their config and define a specific set of arguments that are sent to the bilibili instead of creating an alias?
If that's the case I don't see any issue with accepting this PR.

@kashw2 Acutally It's pass to electron. electron-based package always do these things.

@kashw2 Accept it please.

We need a committer.😅

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1894

@SigmaSquadron @kashw2  Please hold on. I recieve a hash mismatch during nixpkgs-review. Anyway, let's update to the newest version by the way.

Result of nixpkgs-review pr 332733 run on x86_64-linux 1

1 package failed to build:

bilibili

Only bilibili will be rebuilt. Already tested.
I test it myself. nixpkgs-review is too slow without ofborg.

Result of nixpkgs-review pr 332733 run on x86_64-linux 1

1 package built:

bilibili

@SigmaSquadron All right.

@SuperSandro2000 We just do some nixfmt in the first commit. I don't think it should be described in the commit message.

Some button can't be clicked in electron 31. It's ok in electron_29. Let's switch to this temporily.

Might as well shorten the PR title to bilibili: refactor now.

Why fail ofborg?

@SigmaSquadron Done.

Do anyone have any advice? This PR makes bilibili out of date too long.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4504

Some button can't be clicked in electron 31. It's ok in electron_29. Let's switch to this temporily.

Ideally, this package will eventually track the unpinned electron once again. Pinning dependencies cause a bunch of issues when dropping said pinned versions in the future.

@SigmaSquadron Report to upstream. Even it won't work. We can copy electron from pacakge. However, it is always the worst choice.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1944


API_KEY exposed in Travis logs

Actual Behaviour
GITHUB_API_KEY exposed in Travis logs
Expected Behaviour
Shouldn't be logged
Steps to reproduce it
LogCat for the issue
Screenshots of the issue

Would you like to work on the issue?
@the-dagger Could you look into it?

Ok sure
Thanks for the heads up.
On Sunday, April 9, 2017, Vivek Singh<EMAIL_ADDRESS>wrote:

Actual Behaviour
GITHUB_API_KEY exposed in Travis logs
Expected Behaviour
Shouldn't be logged
Steps to reproduce it
LogCat for the issue
Screenshots of the issue
[image: screenshot from 2017-04-08 20-15-52]
https://cloud.githubusercontent.com/assets/12713808/24834991/548996e6-1d12-11e7-9150-c1ab1dc66b8c.png
Would you like to work on the issue?
@the-dagger https://github.com/the-dagger Could you look into it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-android/issues/1399, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGQtlsYc4-JU5oS7VorXs4Kd5Df2uRz0ks5ruGq8gaJpZM4M37Ri
.

--
Best,
Harshit Dwivedi


Login failed for user 'User Manager\Container Administrator'

All I've done is take the docker file is update "/FEATURES=SQLEngine" to be "/FEATURES=SQLEngine, FullText". I haven't changed anything else.
The image builds just fine:
docker build -t chunter/sqldev C:\DevOps\CustSQLDevImage
I run the image with:
docker run -d -p 7000:1433 --name sqlDev -e 'sa_password=SqlDocker!!' -e 'ACCEPT_EULA=Y' -v C:/sqlDev/:C:/sqlDev/ chunter/sqldev
I keep getting: Sqlcmd: Error: Microsoft ODBC Driver 13 for SQL Server : Login failed for user 'User Manager\ContainerAdministrator' when it tries to alter the sa password.
I'm completely stumped. When I use microsoft/mssql-server-windows-developer  everything works just fine.
Any thoughts?

Try using double quotes around your parameter values instead of single quotes on the docker run command.

Unfortunately, single, double, and no quotes make no difference. Same error.
Here's the docker file I'm using, Sorry should have included it last time. Also, I have docker for windows version 17.09.1-ce.

FROM microsoft/windowsservercore
LABEL maintainer "Chunter"
Download Links:
ENV exe "https://go.microsoft.com/fwlink/?linkid=840945"
ENV box "https://go.microsoft.com/fwlink/?linkid=840944"
ENV sa_password _
ENV attach_dbs "[]"
ENV ACCEPT_EULA _
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
make install files accessible
COPY start.ps1 /
WORKDIR /
RUN Invoke-WebRequest -Uri $env:box -OutFile SQL.box ;
Invoke-WebRequest -Uri $env:exe -OutFile SQL.exe ;
Start-Process -Wait -FilePath .\SQL.exe -ArgumentList /qs, /x:setup ;
.\setup\setup.exe /q /ACTION=Install /INSTANCENAME=MSSQLSERVER /FEATURES=SQLEngine, FullText /UPDATEENABLED=0 /SQLSVCACCOUNT='NT AUTHORITY\System' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS ;
Remove-Item -Recurse -Force SQL.exe, SQL.box, setup
RUN stop-service MSSQLSERVER ;
set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.MSSQLSERVER\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpdynamicports -value '' ;
set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.MSSQLSERVER\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpport -value 1433 ;
set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.MSSQLSERVER\mssqlserver' -name LoginMode -value 2 ;
HEALTHCHECK CMD [ "sqlcmd", "-Q", "select 1" ]
CMD .\start -sa_password $env:sa_password -ACCEPT_EULA $env:ACCEPT_EULA -attach_dbs "$env:attach_dbs" -Verbose

Are you building it such that the start.ps1 script gets built into your image?

Yes, I have verified that the start.ps1 is being executed. The start.ps1 is where it executes the sa password change. I have not modified anything within the start.ps1 script (https://github.com/Microsoft/mssql-docker/blob/master/windows/mssql-server-windows-developer/start.ps1)

If you docker run with -it do you see some output that is helpful?

I also have same issue,
VERBOSE: Starting SQL Server
VERBOSE: Changing SA login credentials
Sqlcmd: Error: Microsoft ODBC Driver 13 for SQL Server : Login failed for user 'User Manager\ContainerAdministrator'..
VERBOSE: Started SQL Server.

I have managed to fix this after the change it as follows, "/SQLSVCACCOUNT='NT AUTHORITY\NETWORK SERVICE' "
:)

I had these same symptoms. The fix in my case was changing the dockerfile "FROM microsoft/windowsservercore" to "FROM microsoft/windowsservercore:1803", matching the version number of the Windows host.

Following @guzmanda I got it working, however I need to build the image on Windows Server 2016 14393. When I specify a version of microsoft/windowsservercore other than the build my own PC runs the authentication fails on changing the sa password with the following error:
Microsoft ODBC Driver 13 for SQL Server : Login failed for user 'User Manager\ContainerAdministrator'
This is very annoying as I need to generate an sql script from a dacpac file against a blank DB, which I cant log into when it is built with the longer term support version of 2016 which is required based on this compatibility matrix https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility

I didn't find anything smarter than granting ContainerAdministrator user sysadmin role:
RUN stop-service MSSQLSERVER ; \
        net start MSSQLSERVER /m ; \
        sqlcmd -E -S. -Q 'CREATE LOGIN [USER MANAGER\ContainerAdministrator] FROM WINDOWS WITH DEFAULT_DATABASE=[master], DEFAULT_LANGUAGE=[us_english]' ; \
        sqlcmd -E -S. -Q 'ALTER SERVER ROLE [sysadmin] ADD MEMBER [USER MANAGER\ContainerAdministrator]' ; \
        stop-service MSSQLSERVER ;

It looks like I finally found the root cause and managed to solve it.
The short answer is - you need to run docker build command with parameter -m 4GB (maybe 2GB also will work, but I have't try).
The root cause is that SQL server installation crashes during instance configuration due to not enough memory. Therefore BUILTIN\Administrators group is simply not added as SQL sysadmin role.
You can double check this if you connect to the container with PowerShell and execute command more 'C:\Program Files\Microsoft SQL Server\140\Setup Bootstrap\Log\Summary.txt'.
Most likely first few rows will be something like this:
Overall summary:
  Final result:                  Failed: see details below
  Exit code (Decimal):           -2061893606
  Start time:                    2019-03-03 14:11:16
  End time:                      2019-03-03 14:15:58
  Requested action:              Install

Then you need to examine error log which will be located in "C:\Program Files\Microsoft SQL Server\140\Setup Bootstrap\Log<installationdate_time>\SQLServer_ERRORLOG_<installationdate_time>.txt". Most likely you will find a record that states Failed allocate pages: FAIL_PAGE_ALLOCATION 1
I suppose this is not reproduced when you build the image in Windows 2016 or higher because it doesn't uses Hyper-V isolation mode by default. Which, to my mind, is the root cause of this problem.
I suggest to add corresponding information to corresponding readme.md

I tried to create the image on a Windows Server 2019 (process isolation);
First, it looks  like the docker refuse to download, expand the archive and start-stop the service without the admin rights
I have to add the line:  USER ContainerAdministrator
Now, the install works and  service start.

Detailed results:
Feature:                       Database Engine Services
Status:                        Passed
Feature:                       SQL Browser
Status:                        Passed
Feature:                       SQL Writer
Status:                        Passed
Feature:                       SQL Client Connectivity
Status:                        Passed
Feature:                       SQL Client Connectivity SDK
Status:                        Passed
Feature:                       Setup Support Files
Status:                        Passed

The blocking issue is :

VERBOSE: Changing SA login credentials
Sqlcmd: Error: Microsoft ODBC Driver 13 for SQL Server : Login failed for user 'User Manager\ContainerAdministrator'

It's not a memory issue, I already that at build.
Any help ?
txs
-v

also during install, no database are installed in the DATA folder.
I had to copy manually the files from the "template data" folder.
Is this normal ?
txs
-v


[QUERY] "Invalid Audience" error instead of "Entity Not Found"

Library name and version
Azure.Messaging.Servicebus 7.14.0
Query/Question
Previous Issue 36838
Regarding the previous issue, I should expect " 404 messaging entity not found" but I am starting to get "401 Invalid Audience". Did something change at the service level where the exception is reported differently now?
This used to work until yesterday when the exception was "messaging entity not found" and I handled it in my code and it has changed to "Invalid Audience". Note that this happens if I use SasToken generated for a particular queue. Previously, this worked for both connection string and long-lived-sas-connection-string generated for a given queue.
Need inputs on whether the service level exception behaviour and if the return error codes have changed.
Environment
No response

Hi @arunprakashn.  Thaks for reaching out and we regret that you're experiencing difficulties.   This is normal and expected behavior.   For security reasons, the service performs authorization before it checks for the existence of an entity, ensuring that callers without permissions cannot probe the service to find out what entities may or may not exist.   Because your call was unauthorized, it is rejected before the service attempts to locate and connect to the entity.

Hi @jsquire
If you refer to the other issue that I have linked, you said the other way round when I asked you why it should be "EntityNotFound' instead of "Unauthorized". Also, this behaviour has been observed only since yesterday. Has something changed at the service bus level?

/unresolve

@arunprakashn:  At some point, the Service Bus team changed the ordering on the service.  My statement above was confirmation from them directly.   The client has no direct insight nor influence over the behavior.   If you'd like to discuss further, you'll need to engage with the service team directly.    To do so, you'd need to open an Azure support request or inquire on the Microsoft Q&A site.

/unresolve
It is difficult if the behavior changes abruptly without any intimation. Are there any release notes or any other communication regarding this? Because I wrote the logic based on what you had told in the other issue and now since yesterday its the other way around.

To reiterate:  this is a service behavior and not something that the Azure SDK package has insight into nor influence over.   The maintainers of the Azure SDK are unable to assist with questions about service releases, unexpected service behaviors, nor other service issues.   You will need to engage the Service Bus service team, as discussed in my previous comment.

Thanks @jsquire
Could you please confirm that when getting this "Invalid Audience" error the SDK has established AMQPS with Azure Service bus? I am interested in checking if the source machine can establish AMQPS successfully.

@arunprakashn:  Yes, a connection has been established for you to see that message.  The error is generated by the service; the client does not parse or validate audiences.


Prototype: New Upload System

Multi page forms
Staged and partial uploads

Closing as this will likely never be merged, but picked up again in the future in a different implementation.


Increasing timeout and allowed mem usage for integration tests

./gradlew build && ./gradlew test succeeded

Codecov Report

Merging #992 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #992      +/-   ##
============================================
- Coverage     67.96%   67.91%   -0.06%
+ Complexity     4573     4570       -3
============================================
  Files           377      377
  Lines         29422    29422
  Branches       3725     3725
============================================
- Hits          19998    19981      -17
- Misses         8400     8414      +14
- Partials       1024     1027       +3

Impacted Files
Coverage Δ
Complexity Δ

...b.ambry.network/BlockingChannelConnectionPool.java
62.6% <0%> (-3.05%)
7% <0%> (-1%)

.../main/java/com.github.ambry.store/HardDeleter.java
80% <0%> (-2.59%)
41% <0%> (-2%)

...github.ambry.rest/AsyncRequestResponseHandler.java
87.62% <0%> (-0.98%)
23% <0%> (ø)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
89.74% <0%> (ø)
81% <0%> (-1%)
:arrow_down:

...in/java/com.github.ambry.store/BlobStoreStats.java
69.92% <0%> (ø)
80% <0%> (ø)
:arrow_down:

.../java/com.github.ambry.router/DeleteOperation.java
93.38% <0%> (+1.47%)
44% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c17d7f...510dd57. Read the comment docs.

@pnarayanan @jsjtzyy tests passed locally


Initiation extremely slow

Creating 4 buttons:
NSArray *buttons = @[_quizButton1, _quizButton2, _quizButton3, _quizButton4];
    for (HTPressableButton *button in buttons){
        CGRect frame = CGRectMake(30, 150, 260, 50);
        HTPressableButton *rectButton = [[HTPressableButton alloc] initWithFrame:frame buttonStyle:HTPressableButtonStyleRect];
        rectButton.buttonColor = [UIColor ht_grapeFruitColor];
        rectButton.shadowColor = [UIColor ht_grapeFruitDarkColor];
        [rectButton setTitle:@"Rect" forState:UIControlStateNormal];
        [self.view addSubview:rectButton];
    }

I logged the times. They add up to almost half a second for initiating 4 buttons. This is way too slow. Am I doing something wrong?
2015-02-23 16:38:11.784 [8769:2165117] executionTime = 0.075211
2015-02-23 16:38:11.876 [8769:2165117] executionTime = 0.085640
2015-02-23 16:38:11.973 [8769:2165117] executionTime = 0.091672
2015-02-23 16:38:12.080 [8769:2165117] executionTime = 0.102649

After further investigation, the culprits are setButtonColor and setShadowColor. Removing these two methods greatly speeds up execution time.

@xiaoxu193  Interesting issue. Thank you for pointing this out! I will take a look into this over the weekend.

@tandavas look here: https://github.com/herinkc/HTPressableButton/blob/master/Classes/HTPressableButton.m#L38-L44
There's no need to recreate the entire button when setting buttonColor and shadowColor. This is why it's slow.

you're right. I will come up with a fix for this.

@xiaoxu193 hey there!
I tried many test here and there and didn't encounter the "slowness".
Creating buttons:
for (int num = 0; num < 100; num++)
    {
        CGRect frame = CGRectMake(30, 460+(num*20), 260, 50);
        HTPressableButton *rectButton = [[HTPressableButton alloc] initWithFrame:frame buttonStyle:HTPressableButtonStyleRect];
        rectButton.buttonColor = [UIColor ht_grapeFruitColor];
        rectButton.shadowColor = [UIColor ht_grapeFruitDarkColor];
        [rectButton setTitle:@"Rect" forState:UIControlStateNormal];
        [self.view addSubview:rectButton];
    }

Some output:
2015-03-28 15:19:02.733 HTPressableButton[821:17997] Execution Time: 0.009438
2015-03-28 15:19:02.742 HTPressableButton[821:17997] Execution Time: 0.008688
2015-03-28 15:19:02.751 HTPressableButton[821:17997] Execution Time: 0.008345
2015-03-28 15:19:02.760 HTPressableButton[821:17997] Execution Time: 0.008630
2015-03-28 15:19:02.769 HTPressableButton[821:17997] Execution Time: 0.008956
2015-03-28 15:19:02.779 HTPressableButton[821:17997] Execution Time: 0.010643
2015-03-28 15:19:02.788 HTPressableButton[821:17997] Execution Time: 0.008704
2015-03-28 15:19:02.797 HTPressableButton[821:17997] Execution Time: 0.008462
2015-03-28 15:19:02.807 HTPressableButton[821:17997] Execution Time: 0.010017
2015-03-28 15:19:02.816 HTPressableButton[821:17997] Execution Time: 0.008366
2015-03-28 15:19:02.824 HTPressableButton[821:17997] Execution Time: 0.008380
2015-03-28 15:19:02.835 HTPressableButton[821:17997] Execution Time: 0.010659
2015-03-28 15:19:02.845 HTPressableButton[821:17997] Execution Time: 0.009744
2015-03-28 15:19:02.854 HTPressableButton[821:17997] Execution Time: 0.008387
2015-03-28 15:19:02.863 HTPressableButton[821:17997] Execution Time: 0.008770

If you are still encountering this issue, please provide me more information :)


Upgrade org.apache.maven.plugins:maven-resources-plugin 3.2.0 -> 3.3.0

This PR contains the following updates:

Package
Type
Update
Change

org.apache.maven.plugins:maven-resources-plugin (source)
build
minor
3.2.0 -> 3.3.0

[ ] If you want to rebase/retry this PR, click this checkbox.

Suggested commit message:
Upgrade maven-resources-plugin 3.2.0 -> 3.3.0

See https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.2.0...maven-resources-plugin-3.3.0


Prevent missing ICAOs from failing update jobs

When updating jobs, if the server's icaodata file is not up-to-date, there could be a job in a location that doesn't exist, causing the update to fail.
Fixes #14

For the record this does fix #14 for me when I run it locally.

Thanks a lot for your help with this, @icykoneko, it is very much appreciated. However, I have to close your pull request, as I prefer to fix the root cause of the issue (i.e. add the missing MN24 airport).

Thanks a lot for your help with this, @icykoneko, it is very much appreciated. However, I have to close your pull request, as I prefer to fix the root cause of the issue (i.e. add the missing MN24 airport).


[staging] Revert "python39: 3.9.6 -> 3.9.7"

Motivation for this change
This reverts commit d003f75d7888cd92993107b5a1d6e3a8d340bf68.
Causes an unnecessary amount of breakages due to a DeprecationWarning
regarding the loop argument in asyncio, that is going to be deprecrated
in Python 3.10.

'The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.'

The ecosystem needs more time to catch up here. Broken packages are for
example aiohttp, argh and by extension alot of other packages.
https://github.com/aio-libs/aiohttp/issues/6066
https://github.com/neithere/argh/issues/148

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

We might be able to apply https://github.com/python/cpython/commit/c967bd523caabb05bf5988449487d7c1717f3ac6 instead of reverting.

Applied the patch. Results are as follows:

aiohttp down from 610 test failures

= 47 failed, 2464 passed, 29 skipped, 1 deselected, 3 xfailed in 240.14s (0:04:00) =

Merging so I can continue with #141037.

A downside of this revert is that this patch is not included (the first release containing it is Python 3.9.7). Which means pkgs.python39 can't really be used reliably on macOS Big Sur right now.

@bergkvist PTAL https://github.com/NixOS/nixpkgs/pull/146477


Change units depending on value in pretty

Currently --pretty will show something like this:
foo/bar
  Bench time:<PHONE_NUMBER>252747ns

It'd be good to have the units adapt depending on the value (this result would be easier to read in us/ms for instance)

I'm happy with the solution merged with #20 .


NamedOperations are not executed when "@graphql-mesh/merger-federation" is used

when using a graphql federation with graphql-mesh i only get
{
  "errors": [
    {
      "message": "Unknown operation named \"allCases\".",
      "locations": [
        {
          "line": 8,
          "column": 3
        }
      ],
      "path": [
        "serviceCases"
      ],
      "extensions": {
        "code": "INTERNAL_SERVER_ERROR",
        "exception": {
          "message": "Unknown operation named \"allCases\".",
          "stacktrace": [
            "GraphQLError: Unknown operation named \"allCases\".",
            "    at Object.buildOperationContext (abc/node_modules/@graphql-mesh/merger-federation/node_modules/@apollo/gateway/src/buildQueryPlan.ts:940:13)",
            "    at ApolloGateway.executor (abc/node_modules/@graphql-mesh/merger-federation/node_modules/@apollo/gateway/src/index.ts:638:30)",
            "    at executor (abc/dist/mergers/federation/src/index.js:39:20)",
            "    at delegateRequest (abc/dist/delegate/src/delegateToSchema.js:97:33)",
            "    at Object.delegateToSchema (abc/dist/delegate/src/delegateToSchema.js:19:12)",
            "    at abc/dist/wrap/src/generateProxyingResolvers.js:80:47",
            "    at abc/dist/wrap/src/generateProxyingResolvers.js:76:16",
            "    at abc/dist/runtime/src/resolvers-hooks.js:122:38",
            "    at field.resolve (/Users/mueller/workspace/Symmedia.Gateway/node_modules/graphql-extensions/src/index.ts:274:18)",
            "    at field.resolve (abc/node_modules/apollo-server-core/src/utils/schemaInstrumentation.ts:103:18)"
          ]
        }
      }
    }
  ],
  "data": {
    "cases": null
  }
}

if i use schema stitching it works but i lose the advantages of my federation.

Could you share a reproduction with CodeSandbox?

Anyway, https://github.com/Urigo/graphql-mesh/pull/616 PR fixes the issue. You can try the canary version in that PR.

Sorry, the initial project i could not share. i could try to reproduce in a simple showcase if you still need it. but i will definetly try your fixed version

works like a charm now in canary build
thanks a lot

Let's keep it open until it gets released

Available in v0.2.13 !


Support varargs in JSO objects

Example:
public interface DOMTokenList extends JSObject {
        void add(String... tokens);
        void remove(String... tokens);
}

After it https://github.com/konsoletyper/teavm/pull/867 can be merged.

What if I implement it in 10 years? Should mentioned PR wait 10 years then?

Definitely no. I will try to investigate and implement it myself. Will ask questions if something.


bugs me 🤔

There's anything else I don't know how to do.

Hi! What's the bug? @BertAnthonyRochester

I'm trying... have patience with me 😇
Sent from Yahoo Mail on Android
On Mon, Aug 31, 2020 at 4:15 AM, Nishant<EMAIL_ADDRESS>wrote:
Hi! What's the bug? @BertAnthonyRochester
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

GET DAD HOME

<EMAIL_ADDRESS>


Search() problem

Please ask user questions on the vim_use mailinglist or use vi.stackexchange.com. This here is a bug tracker for problems with Vim. We cannot provide individual help here. Closing.

You cannot search because the '+' is just matched a charactor '+', so
you should search like \d+-\d+. Also, [0-9]{1,}-[0-9]{1,} will
work.
On Wed, 2018-06-13 at 13:06 +0000, premysljordak wrote:

Hello, search function doesnt respect repetition of regexp. In my
case i want to search for \d+-\d+. That matches 123-12, 1-1, 123-
1234, 0-1234 etc. Doesnt work for [0-9]{1,}-[0-9]{1,} either.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Regards!
:-)
Arno Luo
mobile	：<PHONE_NUMBER>5


improve style

Great! Just one problem. You removed the section about gitter, but didn't remove the link to the section in the navbar. It should probably either be removed, or be linked with the gitter page.

@mrmaxguns it's not completed yet, more changes to come
there are several tasks to be  completed like cleaning up the codebase and removing bootstrap if we can(because of CDN's  they increase the overall load time), all organize SVG's
that's why I was asking what wrong with the current homepage, any idea

@mrmaxguns Please submit a PR to restore the functionality that was removed.

@itsvinayak okay, do as you see fit


Adding test_imports. Issue 12110

Summary
Issue #12110 discussed adding a test for imports in the keras/keras and keras/tests directories, where imports should be relative and absolute respectively. This PR is not in a merge state yet, but I am looking for guidance/advice on further steps. Currently the tool works as a stand alone, as I have yet to figure out integration with Travis CI.
The challenge is checking only import statements relevant to the keras function and classes, so currently the tool uses an ignore list which is not very efficient. The issue seems to be dead so I am hoping this PR can bring some attention to this.
Any advice, comments, or questions are welcome
Related Issues
PR Overview

[x] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Sorry, I judt saw you comment in the issue. I belive we should work with an AST to do that. It's much more robust. Can you look into this? https://breadcrumbscollector.tech/writing-custom-checkers-for-pylint/

Closing this PR as another approach would be better suited. @JoshuaRM don't hesitate to contact me in the issue.


User-Test ytt Schema Validation

With the core validation rules implemented, let's get usability and suitability feedback from users.
The goal is to vet our assumptions so that we can either confidently adjust or move forward with our implementation towards General Availability of this feature.

📝  ytt Validations Usability Testing Plan (Google Doc)
Plan:

[x] Identify use-cases and create interview materials for each:

[x] Conduct exploratory testing to surface questionable UX use cases.

Explore: create different combinations of inputs, run them and scrutinize the output
Capture questionable UX'es in the Testing Plan doc; frame it as a "claim" to make about a proposed change in the UX

[x] Prioritize and scope the claims that we'll test
[x] For each "claim" that is in-scope, produce an example and instructions that would place the user in that scenario.
[x] Test-drive the example to ensure:

it works (and that all the needed resources/information are provided);
it will create the desired situation; and
that there are as few anchor biases as possible in the materials.

[x] Identify Candidates

[x] Identify people whom we might interview
[x] Determine who is willing to be interviewed

Interview:

[x] Interview 1 — Vijay

[x] schedule
[x] conduct

[x] Interview 2 — Clemens

[x] schedule
[x] conduct

[x] Interview 3 — Robert

[x] schedule
[x] conduct

[x] Interview 4 — Jay

[x] schedule
[x] conduct

[x] Interview 5 — Scott

[x] schedule
[x] conduct

[x] Interview 6 — Pradnya (CNR)

[x] schedule
[x] conduct

Results:

[x] Synthesize results of interviews
[x] Author User Stories describing improvements

While there's some ongoing previews/interviews; we've completed the scope of interviews required to validate/confirm the requisite API claims. 👍🏻


Can't type ~ with Spanish Keyboard

[X] I am on the latest Hyper.app version
[X] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: macOS Sierra 10.12.1
Hyper.app version: 0.83 (<IP_ADDRESS>3)
Link of a Gist with the contents of your .hyper.js: N/A
Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere):

Uncaught dead key on international keyboard KeyboardEvent {isTrusted: true, key: "Dead", code: "Semicolon", location: 0, ctrlKey: false…}

The issue is reproducible in vanilla Hyper.app:

Issue

When you try to type alt + Ñ = ~ You have this warning and ~ not typed.
GIF:

Will be fixed with the next release. 😄 #26

And when is it expected to be released? Can't type backticks either.

@iovis9 All I can say is that it'll be really soon. I haven't heard any solid date yet, but I think the majority is done and we're just waiting to be organised for release.


Slate Shipyard

Your Discord Name
Locochoco#8523
Mod uniqueName
Locochoco.SlateShipyard
Mod name
Slate's Shipyard
GitHub repository URL
https://github.com/ShoosGun/SlateShipyard
Tags
library, gameplay, tool, content
Author display name
Locochoco
Parent uniqueName
No response
Utility mod
Is utility
Alpha Mod
No response

To add the gameplay tag


[Bug report]: Unwanted extra space appears to the right of an collapsed side menu item in desktop

Requirements before reporting

[X] No duplicated issue reported.
[X] I have checked the latest version if the bug exist there. See all available packages at npmJS.com
[X] I have followed the installation guide.

Package versions
@scania/tegel 1.8.2
Browser
Chrome
Framework
React
Version
React 18.2.0
Reproduction steps

Add component Side Menu.
Set collapsed and persistent to true.
Look at it in desktop.
An unwanted space of 1px appears to the right of the menu items.

Code example
<tds-side-menu collapsed persistent aria-label="Side menu" id="demo-side-menu"><tds-side-menu-item>   <button>           <tds-icon name="star" size="24px"></tds-icon>           Values         </button>       </tds-side-menu-item></tds-side-menu>
Screenshots

Expected behaviour
That extra space of 1px should be removed.
Console errors
No response
Contact information
<EMAIL_ADDRESS>

Merged, closing the issue.


Update links to Ansys help site to 25R1

There are links to the Ansys help site in places, for example:

https://bomanalytics.grantami.docs.pyansys.com/version/dev/api/sustainability/index.html
https://recordlists.grantami.docs.pyansys.com/version/dev/user_guide/index.html

These all target the 24R1 version of the product documentation and need to be updated.

We should probably write a script to do this, or maybe a github action to make the update if the pages can be resolved.


HTTP: Wrong Connection header value in WebSocket upgrade request

According to RFC6455:

The request MUST contain a |Connection| header field whose value MUST include the "Upgrade" token.

So the correct case is Upgrade. Netty's WebSocketClientHandshaker currently sends upgrade instead. See https://github.com/netty/netty/pull/8558.
Some WebSocket server implementations expect the proper case and crash.

Actually, the spec says those are case insensitive


build: Update to Go 1.20 and linter v1.51.2

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-messaging/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions
make sure v1.51.2 of linter is installed
make test
verify no format or linter issues
New Dependency Instructions (If applicable)

Codecov Report

Merging #234 (362e614) into main (71e996e) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   71.34%   71.34%
=======================================
  Files          24       24
  Lines        1040     1040
=======================================
  Hits          742      742
  Misses        266      266
  Partials       32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: catch ObjectDisposedException in IconTintColorBehavior

This PR ensures ObjectDisposedException is caught in IconTintColorBehavior, instead of bringing the whole app down. The previous PR related to this behavior reduced the frequency of the exceptions and prevented easy reproduction, but they still occur.
Definitely a suboptimal solution - ideally the use-after-dispose would be fixed in the first place, but this pattern occurs in other CommunityToolkit.Maui behaviors, e.g. TouchBehavior, and should mitigate the crash completely.

@ScottyLightnin thoughts on this?


scanning of files differs between rubocop gem and cc cli

rubocop gem on the command line only scans my app folder for *.rb files.
rubocop -R  --format files

while codeclimate cli will scan image files in app/assets and files in the root of my rails apps like .travis.yml or Gemfile.
AllCops:
  DisabledByDefault: false
  RunRailsCops: true
  Include:
    - 'app/**/*.rb'
  Exclude:
    - 'bin/**/*'
    - 'config/**/*'
    - 'coverage/**/*'
    - 'db/**/*'
    - 'docs/**/*'
    - 'features/**/*'
    - 'lib/**/*'
    - 'log/**/*'
    - 'public/**/*'
    - 'script/**/*'
    - 'spec/**/*'
    - 'test_site/**/*'
    - 'tmp/**/*'
    - 'vendor/**/*'

---
engines:
  rubocop:
    enabled: true
ratings:
  paths:
  - "**.rb"
  - "**.coffee"
  - "**.js"
  - "**.jsx"
  - "**.css"
  - "**.scss"
exclude_paths:
- bin/**/*
- config/**/*
- db/**/*
- features/**/*
- log/**/*
- public/**/*
- script/**/*
- spec/**/*
- test_site/**/*
- tmp/**/*
- vendor/**/*
- ".codeclimate.yml"
- ".csslintrc"
- ".eslintrc"
- ".rubocop.yml"
- ".gitignore"

Is my codeclimate config file correct?

Hi @prosanelli that should be fixed with this commit, which I've just released to docker hub. Can you run codeclimate engines:install and try again?

:+1:  that worked. thanks.


Allow getting raw JSON responses from REST methods

Could probably just do XAsJson variants or similar, eg. createMessageAsJson, but that sort of naming may be misleading.

Maybe have methods as both X and XRaw

Sounds good to me :+1:

If we do this, then the X methods can just call the XRaw methods and apply some stuff to the future I think, which is nice.

then the X methods can just call the XRaw methods and apply some stuff to the future

Basically the same as we do for paginated endpoints


Example Beancount file with usage pattern

After reading the Beancount mailing list, the Fava Issues post, and this post about envelope budgeting for ledger I gather there are many opinions on how envelope budgeting should be done on top of a double-entry bookkeeping system.
@bryall, in order to understand your vision for this extension and its correct usage it would be very helpful to have a basic example Beancount journal with some transactions in it, and perhaps a few screenshots with some brief commentary.

I agree, I have been focusing on some other projects and will add those as soon as I can

One situation I don't understand how to handle is the following: I want to see that I'm investing 100 USD a month. The transactions might look like:
2020-08-01 * "Investing"
 Assets:Bank                  -100 USD
 Assets:Investing:Cash   100 USD

2020-08-01 * "Buy investment vehicle"
 Assets:Investing:Cash    -100 USD
 Expenses:Investing              1 USD
 Assets:Investing:TICKER    10 TICKER {99 USD}

So really a deposit into Assets:Investing:Cash should count towards the monthly 100 USD "budget". The problem is that the USD comes and leaves the account, so it will always look like nothing happened.

I have added an example file to the repo, with a link to repl.it to see it in action.
with your example, if you set the "Assets:Bank" as the only budget account , the second journal entry will not be processed. then you can map the  100 USD to a budget envelope.
All the design decisions have been for me so far, but I am very open to change and discuss alternatives to make this better, let me know if you have any other questions

I have added an example file to the repo, with a link to repl.it to see it in action.
with your example, if you set the "Assets:Bank" as the only budget account , the second journal entry will not be processed. then you can map the  100 USD to a budget envelope.
All the design decisions have been for me so far, but I am very open to change and discuss alternatives to make this better, let me know if you have any other questions


Should be able to maximize objectives and support lower-bound constraints natively

Currently, ParMOO minimizes all objectives and treats all constraints as upper bounds (<= 0), which is the convention in multiobjective optimization.
For problems involving maximization and lower bounds, users are recommended to multiply their true objective by -1.
This is the standard recommendation, and a reasonable workaround, but is still undesirable for many reasons.
Ideally, ParMOO would offer an option when adding objectives/constraints, to specify whether they are min/max and upper/lower bounds respectively (with the default being to minimize all objectives and treat all constraints as upper bounds).
This should be done by quietly inverting all maximum objectives/lower-bound constraints on input, then transforming back on output.

@thchang function fmincon requires an inequality constraint with boolean output. It relaxes the requirement "lower or equal than".


Bot thinks it can travel diagonally when blocked by other blocks

The bot thinks it can use the block on the right (that is one block high) on the right to get to the block in front (that is two blocks high). The bot thinks it can travel diagonally, but it can't since it is surrounded by other blocks.
To reproduce: Put the bot in an enclosure as shown on the screen shot with clearance above the block on the right (that is one block high) and the block in front (that is two blocks high). Set parkour to false. Set the goal so that the bot's feet are on the block in front (that is two blocks high). This is tested in Minecraft 1.18.1.
Result: The bot infinitely jumps without finding an alternate path.
Possible Fix: Allow the user the option to disallow bot to jump and travel diagonally in the Movements class.
Edit: It happens mainly when the bot is mining in the Nether. Sometimes it gets stuck while other times it doesn't, so I think the bot is getting stuck on a block when it tries to jump and travel diagonally simultaneously.

I think this issue is with the 1.18.1 physics implementation. The issue is that it does not match vanilla physics causing the bot to get stuck inside the block. I don't know how to work around this. You can overwrite the getNeighbors method in Movements to remove the diagonal move tho.

The real fix would be to fix prismarine-physics for 1.18

mineflayer-pathfinder simulates jumps before it attempts them. If it detects that the simulation does not work it won't jump at all. If the bot jumps it means the bot thinks it can make the jump. If it fails it should be because the server resets the bots position making it fail the jump.

Thank you for the quick solution. Hopefully prismarine-physics can be fixed.


Redacted logging fixes

Several fixes identified while investigating #93 although the precise crash could not be replicated by test cases.
This fixes the redacted logging code to actually allow redacted DSN logging - had that code ever worked, it would have led to a crash under normal circumstances.

Coverage increased (+1.7%) to 52.508% when pulling 4231ba210f2d2c934e7e5ddb247b79bace43d8a3 on redacted_logging_fixes into 1afbd62ab194c045a88488d77de2f116400dedb7 on master.

Coverage increased (+1.7%) to 52.508% when pulling 4231ba210f2d2c934e7e5ddb247b79bace43d8a3 on redacted_logging_fixes into 1afbd62ab194c045a88488d77de2f116400dedb7 on master.


Cannot stack binary and trinary Atmos pumps and devices. 5x Filter rate boost

About the PR
Atmos Technicians were creating stacks (5-20!) of filters and similar devices on the same tile. That wasn't the intent of the system and it makes their designs visually unreadable which is not what we want.
However the main reason for stacking was because the gas filter is woefully underpowered at only 200 Litres / Sec which is especially bad for hot gasses like Tritium from a plasma fire pipe.

Gas Mixers, Filters, pumps and similar devices are all tagged as unstackable and this is enforced with a new construction rule NoUnstackableInTile
There is a matching check when anchoring to prevent stacking through re-anchoring structures.
Filters now have a 5x max volume to compensate for no more stacking, so a max filterrate of 200 L/S
Filter UI no longer enforces the max rate, as this was already enforced in the GasFilter system, the UI wasn't reading the actual max from the GasFilter component.
Filter UI has a large enough region to type 1000 L/S into.
Flipped Gas Filter and Gas Mixer are in the construction menu to aid discoverability

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

remove: You cannot stack Gas Filters, Mixers or several other Atmos devices like pumps and valves. Pipes can still be stacked.
tweak: Gas filters can now filter 5x faster (up to 1000 L/S) to compensate for no more filter stacks. This is their new default rate
tweak: Gas Filters and mixers now have a flipped version visible in the construction menu. Hint: You can still right click on an un-anchored filter / mixer and choose rotate -> Flip

oh very nice, got tired of seeing this bug abused, filter rate increase is probably fine too given how often blockages happen

make sure theyre not anchorable on top of each other either, which is what people were doing also

Good catch! I'll need to add that check.

make sure theyre not anchorable on top of each other either, which is what people were doing also

would you rather see this instead?

would you rather see this instead? (but with more heaters)

Yes.

would you rather see this instead? (but with more heaters)

You've pictured 28 filters here, but with this PR filters are 5x as powerful so you only need 6 to get this level of filtering
You don't need a heater once the plasma fire has begun. Just introduce more oxygen than you need initially and then feed a 1:100 ratio of plasma / oxygen into the reaction. It will remain plenty hot without the heater.

Yes.

i'm saying this won't make atmos a lot more readable, but only a bit more in any case, good PR

Well, it means a screenshot will show all the relevant devices, if not their settings.

Thanks for the review @metalgearsloth


Expression syntax for rule conditions

Current behavior:
Currently, conditions need to be written in Go code
Expected behavior:
What is the motivation / use case for changing the behavior?
It is much easier to author rule conditions using an expression syntax such as, for example,"$n1.name == 'Bob'" instead of writing Go code for the same
Additional information you deem important (e.g. I need this tomorrow):

Closing this PR as there are significant changes to the expression API in project-flogo/core and this PR is not valid anymore

Re-opening this issue, as this was closed by mistake. (Its associated PR was to be closed)


cloud-init: Could not unmarshall userdata: invalid character '#'

Version (k3OS / kernel)
k3os version v0.11.1
5.4.0-48-generic #52 SMP Sat Sep 26 08:27:15 UTC 2020
Architecture
x86_64
Describe the bug
During boot the following error message is logged:
Could not unmarshall userdata: invalid character '#' looking for beginning of value
The cloud-init userdata looks like this:
#cloud-config
fqdn: k3s2.example.com

k3os:
  server_url: https://k3s1.example.com:6443
  token: "HIDDEN"

To Reproduce
Spin up a k3OS instance on a cloud which supports cloud-init userdata (e.g. OpenStack) and use the above documented userdata.
Expected behavior
The userdata script is unmarshalled without error message.
Actual behavior
Error is logged - but unmarshalling seems to still work as the configured options are properly applied.
Additional context
This was tested on cloudscale.ch which runs OpenStack behind the scenes.

This is expected behavior. Linuxkit metadata copies the raw, unmodified user-data content to /run/config/userdata and then attempts to process it, expecting JSON. An error from metadata at this stage is informational. If it happens to be a script, k3os config will end up executing it. If it is YAML k3os config will parse it and apply it to your system.


python3Packages.hvplot: add colorcet dependency

Motivation for this change
noticed it was broken reviewing another package
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @
[3 built, 4 copied (45.0 MiB), 9.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74435
3 package were built:
python27Packages.hvplot python37Packages.hvplot python37Packages.intake

@GrahamcOfBorg build python27Packages.hvplot python37Packages.hvplot python37Packages.intake

darwin failure unrelated to pr


Original import url should be added at least to the import log

Closes #3439
@lbosque CR please

Frontend tests were OK :+1: (details)

@ethervoid just in case @lbosque is lazy, CR you too please :smile:

LGTM :+1:


How do I target NPU for quantization?

I can provide the execution provider like this:
config.StaticQuantConfig(calibration_data_reader=data_reader, quant_format=QuantFormat.QOperator, execution_provider="DmlExecutionProvider"), but there's no way to specify the device as NPU?

Hi, if you use ONNX Runtime to run the quantized model on NPU, providing execution provider is enough.

How does it select between GPU and NPU if using DmlExecutionProvider?

Hi, since currently we only provide limited support and do limited test for DML EP, we don't expose many parameter about this EP.
You can check this PR of onnxrutnime about device selecting for DML EP https://github.com/microsoft/onnxruntime/pull/17612.
Actually you can quantize the model first, and then select device during later inference.


Cleanup FM_DEVIMINT_DISABLE_MODULE_LNV2 in upgrade and back-compat tests

We needed to disable lnv2 and ldk logic to get upgrade tests and back-compat working for the 0.5 release. We should cleanup this disabled logic so we're testing 0.5 in back-compat while developing 0.6 and beyond.
cc: @m1sterc001guy (capturing our out-of-band chat)

Ack. IMO we need to get the LDK Gateway and LNv2 working on upgrade tests and backwards compatibility tests for v0.5 and up.

Oops, this was a bad copy/paste. Didn't mean to close this since we still need to address.


Added trace_sampler function in app.py and sentry_sdk in app.py and requirements

Description:
added trace_sampler function of code in app.py and added sentry_sdk in requirment file

Could you merge the new main branch in, and then tests should run?

Thanks @Plomo-02 for this, we deinfately used this PR as inspiration, and now we have a this feature in


fix: run libreoffice once during wolfi image build

Summary
Closes #3105. Runs libreoffice once in the wolfi image to avoid the "cold start" problem where libreoffice fails on the first run. Reenables a test that was turned off due to this problem. Thanks @micmarty-deepsense for the solution!
Testing
Reenabled test should run in test_dockerfile.

Closing in favor of fixing upstream in https://github.com/Unstructured-IO/base-images/pull/22


Add anagrams.io to sites built

I added a website that uses react-static under the hood to the "Sites Built"-section: anagrams.io.
Description
Anagrams.io tries to be the best anagram generator ever built, react-static helped me to make it even faster and SEO friendly.
Changes/Tasks

[x] Adds anagrams.io to "Sites Built"

Motivation and Context
It adds a website that's different than all the other "Sites Built" websites and shows that SVG generation and animations are no problem at all.
Screenshots (if appropriate):

Types of changes

[x] Extend documentation

Checklist:

[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

@tannerlinsley Thanks for the kind words! I'm really loving react-static, moving anagrams.io to react-static took me only about 1 hour. Thanks for all the awesome work!


Refactor EtcBuiler to propagate type error explanations

The builder we use to construct ETC types does not propagate the recently introduced attribute to represent a type error explanation for that type. We did this propagation manually for some instances (see this comment), but we should ensure that, for every builder method that takes a EtcExpr as parameter, the error explanation of that EtcExpr is replicated to the EtcExpr being built.

Is this issue partially closed?


Add My Submissions page

Added My Submissions item to the header (only shown when the user connects the wallet).
No submissions:

With submissions:

closes #77

Thanks for tackling it so fast @damianmarti !! I've pushed some small tweaks to:

Add some padding for small devices, tried to set same paddings as /submissions
"My Submissions" was jumping to 2 lines in some screen sizes + hamburger

I was having problems when trying to access /my-submissions in a new tab, or reloading /my-submissions when it was already loaded. It was redirecting me to homepage.
Tried to add a quick fix, but started fixing some other small issues I found (double notification when no connected account, flickering before showing your submissions, flickering when disconnecting after loading the submissions) so I probably ended up pushing some really dumb code.
So I'd love if you could review 46913d9 (feel free to undo and fix it properly if it's too messy)

Thanks @Pabl0cks !!
I took a different approach (I think it's simpler) showing a connect button instead of redirecting the user to the home.
Please, take a look at https://github.com/BuidlGuidl/extensions-hackathon/pull/83/commits/dd1041ce77a7a7ed5e7f0b69ed671758d1c5a844 and let me know what you think.

I took a different approach (I think it's simpler) showing a connect button instead of redirecting the user to the home.

I think this approach makes much more sense! 🙌 Even the /my-submissions header link could be always shown with this approach.
Did some testing, found some issues, mostly flickerings:

When I go to /my-submissions manually, I get infinite loading (not normal use case but if it's easy I'd handle it, specially if we decide to show /my-submissions when disconnected)
When I connect with a wallet with submissions, I go to /my-submissions and it shows the "No submissions msg"+ submit button for a couple of seconds on the first access. If I reload, I get the "Connect" button for a second, then "No submissions" for another second, then the submissions load normally.
When I disconnect having the /my-submissions opened, I get some flickering with the Loading... and "Connect Wallet msg + button"

Suggestion: Maybe we could check if the submissions are open to show the "Submit an Extension" button normally, or show "Submissions closed" and disabled otherwise, like we do in /submit

I took a different approach (I think it's simpler) showing a connect button instead of redirecting the user to the home.

I think this approach makes much more sense! 🙌 Even the /my-submissions header link could be always shown with this approach.
Did some testing, found some issues, mostly flickerings:

When I go to /my-submissions manually, I get infinite loading (not normal use case but if it's easy I'd handle it, specially if we decide to show /my-submissions when disconnected)
When I connect with a wallet with submissions, I go to /my-submissions and it shows the "No submissions msg"+ submit button for a couple of seconds on the first access. If I reload, I get the "Connect" button for a second, then "No submissions" for another second, then the submissions load normally.
When I disconnect having the /my-submissions opened, I get some flickering with the Loading... and "Connect Wallet msg + button"

Suggestion: Maybe we could check if the submissions are open to show the "Submit an Extension" button normally, or show "Submissions closed" and disabled otherwise, like we do in /submit

@Pabl0cks thanks for the testing!
I added the submissionsEnabled check and I refactored to use useQuery.
It works much better now!

I added the submissionsEnabled check and I refactored to use useQuery.
It works much better now!

TYSM Damu! useQuery is handling the flickering muuch better ♥.
The only use case that has some flickering is disconnect while you are in /my-submissions, either with a user with submissions or  without submissions.
If it's a PITA to fix, we could merge and document the flickering in issues. Not like it's going to be a very common use case (maybe some user that connected with the wrong address?)

I added the submissionsEnabled check and I refactored to use useQuery.
It works much better now!

TYSM Damu! useQuery is handling the flickering muuch better ♥.
The only use case that has some flickering is disconnect while you are in /my-submissions, either with a user with submissions or without submissions.
If it's a PITA to fix, we could merge and document the flickering in issues. Not like it's going to be a very common use case (maybe some user that connected with the wrong address?)

Thanks!!
Yeah, there are some flickering issues when disconnecting, but I checked, and it's not so easy to fix. I think this can be left as a known bug for now.

Yeah, there are some flickering issues when disconnecting, but I checked, and it's not so easy to fix. I think this can be left as a known bug for now.

Ok! Merging


Encoded auth logic for the OAS identity POST methods

Testing codegen project to enable Authorization: "Basic " + base64encode(client_id + ":" + client_secret) definition

Closing this as it was a spike, but will revisit branch in the future.


Why is Input Node not "Cast"? Is there a difference between "Mul" and "Mul:0"?

Even though TensorFlow For Poets 2 does not warrant the running of "strip_unused.py", the app still runs with a retrained+optimized+quantized model.
However, during the optimization step to skip the "DecodeJpeg" node, we redirected the input node to "Cast". But the app works only when the input node specified is "Mul" or "Mul:0".
My first question is, why is the input node not "Cast"?
My second question is, what is the actual difference between "Mul" and "Mul:0" in ClassifierActivity.java, since both of these input nodes make the app work with the retrained+optimized+quantized model.

Also don't know

I also have the same questions. It should be clarified

There are a few questions here.
The difference between "mul" and "mul:0" is that "mul" is the name of the operation, and "mul:0" is the name of a tensor, output "0" of the operation. Only tensors have values, not operations. But, If you ask tensorflow for the value of an operation, it assumes you want the value of output "0". So they are equivalent.
The app is feeding to the mul node, see diagram, because it is doing the resize and centering in the app. I think that code is included for compatibility with other networks.
But if you want to feed directly to the cast node, I think you would just need to skip the java code that implements those operations.
The normalization and conversion to float is done here, and it looks like the cropping is happening around here.
Just remember that if you're feeding to "Cast" that's the output of cast you're feeding to. So you at least need to keep the conversion to float.
Give it a shot!
Send a PR if you can get it to work, maybe it will be more efficient.

Hello everyone,
I have a question. Which is I used MobileNets for classification purpose and implemented it on android and PC, the problem is I get different prediction values on android and PC (linux) for the same picture and model. The difference is on average magnitude of 5%.   What cause this difference ?

I've recently upgraded this repo to use MobileNets so the Mul/Cast nodes no-longer exists.
@bis-carbon I don't know what it is, consider investigating to narrow it down (any idea which op?), and if you figure it out, maybe send a bug to the tensorflow repo.


cloudstack: bump to use <IP_ADDRESS> systemvmtemplate

Use new <IP_ADDRESS> systemvmtemplate, that addresses many new pkgs with security/improvement fixes.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Kicking a build on jenkins;

Will consult and upload the systemvmtemplate builds first on download.cloudstack.org @weizhouapache @DaanHoogland before we run pkg with this PR

Uploaded at https://download.cloudstack.org/systemvm/4.18/ pl check @DaanHoogland @weizhouapache - and suggest if we need to mirror them in the jenkins/staging server before we use BO to build pkgs/kick tests?

@blueorangutan package

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6706

@blueorangutan test matrix

@rohityadavcloud a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-7325)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38925 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7325-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-7327)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7327-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
79.85
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
55.53
test_vm_life_cycle.py

[SF] Trillian test result (tid-7326)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52358 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7326-vmware-67u3.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_deploy_vm_on_specific_host
Error
13.60
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3602.08
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.33
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.33
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
1.33
test_vm_deployment_planner.py

test_deploy_vm_multiple
Error
72.64
test_vm_life_cycle.py

test_09_expunge_vm
Failure
425.73
test_vm_life_cycle.py

@rohityadavcloud , I'm currently trying to build the systemvm template for 4.18 and it's failing because  apt package 'python' does not exist anymore. should it be replaced by 'python-is-python3' and update python-netaddr by python3-netaddr ?

Hi @pdion891 thanks for the review, are you using Debian 11 or 12 (bookworm) ISO or which distro as the host?
This uses Debian 11 ISO and for building the systemvmtemplate, I used a Ubuntu 20.04.6 server + Jenkins + packer v1.8.5

@blueorangutan package

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6718

Hi @rohityadavcloud ,
so I've just tried to build a systemvm template from 4.18.0 today using https://cdimage.debian.org/mirror/cdimage/archive/11.7.0/amd64/iso-cd/debian-11.7.0-amd64-netinst.iso, and python package was not found. so there must be something off on my side since your build log do not complain and fail the same way.
Using Packer v1.9.2
I'll retry the build with rebased 4.18 branch with this new iso url...
Cheers,

My build server is based on old Ubuntu 20.04 so it’s possible python meant python2, perhaps you could put a symlink to python2 for python and try again ?

sorry for the confusion,
I'm referring to python package installation in the systemvm in packer: https://github.com/apache/cloudstack/blob/main/tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh#L56
I had package not found issue but changing it to 'python-is-python3' and changing 'python-netaddr' by 'python3-netaddr' was fixing building error during the package installation. But I've just retest the systemvm build from the community 4.18 branch using this updated URL for the ISO and it work just fine, so please ignore my issue :-)

@blueorangutan test matrix

[SF] Trillian test result (tid-7347)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35161 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7347-xenserver-71.zip
Smoke tests completed. 103 look OK, 1 have errors, 4 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_07_arping_in_vr
Failure
5.17
test_diagnostics.py

all_test_vpc_router_nics
Skipped
---
test_vpc_router_nics.py

all_test_vpc_vpn
Skipped
---
test_vpc_vpn.py

all_test_host_maintenance
Skipped
---
test_host_maintenance.py

all_test_hostha_kvm
Skipped
---
test_hostha_kvm.py

@blueorangutan test centos7 xenserver-71

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

[SF] Trillian test result (tid-7348)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7348-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan test rocky8 kvm-rocky8

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[SF] Trillian test result (tid-7360)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38018 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7360-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-7372)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45340 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7828-t7372-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

all look good
Checked the log, the md5sum of system templates are correct.
Merging


Question: Any suggestion on how to handle sass + postcss

First off the book is very good! Been really enjoying the examples.
Tailwind is a good example but another library that has been a requirement is USWDS which is built with USWDS Compile, which is a sass solution.  So wonder if you have any suggestion on when/how to use both sass + postcss?
Is it bad to actually use both?

Hi, Tailwind has been chosen to simplify the CSS part of the book.
You can, of course, use whatever CSS preprocessor you want. Usually, you want to use Sass or Postcss, not both; you have to adapt the Webpack configuration to your needs.


I only need to crawl the DOM, so should I use:   waitUntil: 'domcontentloaded'  ?

I only need to crawl the DOM, so should I use:   waitUntil: 'domcontentloaded'  ?
Is there any other similar options ?
waitUntil: 'domcontentloaded' seems to have : Timeout: 30000ms , so sometimes I get error of Timeout Exceeded.

I only need to crawl the DOM, so should I use: waitUntil: 'domcontentloaded' ?

@orlandobloom19 yeah that's the right one to use.

so sometimes I get error of Timeout Exceeded.

This might happen if server didn't stop sending document body.