Use DMD in CyclomaticComplexityCheck

It seems that you are modifying the tests in a way that is hard for me to follow. Which tests are kept exactly as they are? Which tests are added? Which tests are modified and why?
Can you maybe keep the tests exactly as they were (but modify only the surrounding function call) and then at the end add the new tests?

The previous tests were not covering all AST elements that increase complexity. In order to keep behaviour between DMD and libdparse, I've first created unit tests for all nodes with libdparse, noted down the complexities and then replace libdparse with DMD. I've reset the commit history on this branch to keep this PR sane.
I could keep the old tests and add new ones at the end of the file, however some old tests are redundant and more tests are required to assert the same complexity calculations between libdparse and dmd

Added old tests back. Ready for review!


Invalid content /en/testnets/cardano/get-started/creating-a-stake-pool/

Where does the issue occur?
Link to the file or location on the website where the issue occurs. Optionally add screenshots for context.
A link is not working to the register a pool.
Describe the issue
A clear and concise description of what the issue is.
This link is not working:
https://docs.cardano.org/projects/cardano-node/en/latest/stake-pool-operations/register_stakepool.html#generate-stake-pool-registration-certificate
Expected changes
A clear and concise description of what you expected to change.
Link it properly.
Additional context
Add any other context about the problem here.

Thanks for your feedback! #734 addresses this issue


dcm to png setting

We have a batch of dcm ct images in hand, and I want to convert them into domain like the png you released. How do I set the super parameter during conversion? (e.g. windowing level and windowing width)

Hi @gaohailiang520, we do not use pngs in our study.  Can you please elaborate where you find the pngs?


Added an overloads-separate-docs option in completed-docs

PR checklist

[x] Addresses an existing issue: fixes #4416
[x] New feature, bugfix, or enhancement

[x] Includes tests

[x] Documentation update

Overview of change:
Opt-in (false by default) boolean flag that can be applied to functions and methods to require their overloads each receive their own documentation comment.
 I should have removed them when converting it to TypeScript.
CHANGELOG.md entry:
[new-rule-option] completed-docs: overloads-separate-docs option

This assertion is unnecessary since it does not change the type of the expression. (no-unnecessary-type-assertion)
  593 |     }
  594 |
> 595 |     return parent.getChildren()!;
      |           ^
  596 | }
  597 |
  598 | function isGetAccessor(node: ts.Node): node is ts.GetAccessorDeclaration {

🤔


Add new area labels for ops and Traceflow

area/ops
area/ops/traceflow

/skip-all

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6ec79a7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1918   +/-   ##
=======================================
  Coverage        ?   41.23%
=======================================
  Files           ?      116
  Lines           ?    14625
  Branches        ?        0
=======================================
  Hits            ?     6031
  Misses          ?     8079
  Partials        ?      515

Flag
Coverage Δ

unit-tests
41.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Bump Docker to 19.03.14

Checklist

[ ] I've run make from the root directory to see all Dockerfiles are created successfully.
[ ] I've updated the documentation if necessary.

Motivation and Context
Bring Docker current (addressing CVE)
Description

https://github.com/docker/docker-ce/releases/tag/v19.03.14

Unchanged staging fails similarly https://github.com/circleci/circleci-images/pull/543

The failed builds are unrelated. Thank you for the PR, apologies for the delay.

@felicianotech anything else you would like to see on this PR?


In-Memory cache provider does not correlate IDs to inResponseTo values

On line 1469 and 1470 of the SAML 2.0 spec it states:

The values of the ID attribute in a request and the InResponseTo attribute in the corresponding response MUST match.

Currently the built in cache provider does not check this. It only checks for the existence of the key.

Thanks for the spec reference. It sounds like we are not being spec-compliant here, so a PR is welcome.

https://github.com/bergie/passport-saml/pull/286 it's been up for a while, reviews welcome :D

@rupertbg #286 doesn't address this. #286 only adds a check if InResponseTo is missing. The passage quoted here from the spec calls for additional validation that The values of the ID attribute in a request and the InResponseTo attribute in the corresponding response MUST match.
#286 could be updated to cover both cases.

@markstos that's not what I'm trying to solve. The IDs matching isn't the issue. The bug is that if the key doesn't exist it doesn't fail. The IDs matching when the key does exist is already working fine as far as I can tell.

https://github.com/bergie/passport-saml/blob/a869d25e7dc1b8a62b5b92c1f863de9aead59571/lib/passport-saml/saml.js#L558-L561
Here the lack of the ID existing in the inResponseTo cache means it fails. I guess only really saved by the fact that it is extremely unlikely that the cache would have another ID the same as yours for a different request..

First, I want to return to the the Issue Title and initial summary. What does this have to with the built-in cache providers? Cache providers simply get and save values. Their job is not to compare or otherwise validate values. Also, the related PR doesn't touch the in-memory cache provider.
Second, I think your patch is essentially correct and beneficial. The current logic claims that the "InResponse" will be validated, but then skips the validation if InResponseTo is missing. The original logic required InResponse to be present if validation was enabled, but this changed when @ploer commit da912ea9e78d1268286bc back in 2014. As part of that commit, InResponseTo  started to be checked conditional on it being present.
As noted in the related PR, the patch needs a clearer commit message and ideally some automated test coverage, then I think it's ready to merge.

Addressed by #300.  Closing.


Add UI extension

WHAT is this pull request doing?
Mainly: Introduce the new UI Extension
But also:

Adapt esbuild to use stdin instead of entryPath
Update the UIExtension to expose more data.
Move some extension specific configuration to each extension file instead of hardcoding types in the code.
Update the info command to handle errors from the new ui extension
Fix and add some tests
Cleanup

PENDING for a future PR:

More tests
More Cleanup

How to test your changes?
You can generate/dev/build/deploy any extension

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@isaacroldan :  @vividviolet and I were pairing.  We were not able to deploy a checkout_ui extension using this branch.  We think something might be broken with this branch, happy to pair on this tomorrow if it's helpful

🎩
I tophatted the flow generate -> build -> info -> dev -> deploy for all ui extensions.
Everything works except deploying ui-extensions, but that's ok since it's still WIP

Awesome thank you Isaac, I'll take a look at the code see what e are missing, log issues and merge.


Bug: Deleting causes unmarshal panic

Describe the bug
Running the example from the README fails with panic: cbor: cannot unmarshal map into Go struct field connection.RPCResponse[github.com/surrealdb/surrealdb.go/pkg/models.RecordID].result of type []interface {} on SurrealDB 2.1.2.
Steps to reproduce

Start a SurrealDB instance
Copy the example from the README into a new Go project
Run the code
It crashes with panic: cbor: cannot unmarshal map into Go struct field connection.RPCResponse[github.com/surrealdb/surrealdb.go/pkg/models.RecordID].result of type []interface {}

Expected behaviour
It shouldn't crash
SurrealDB version
2.1.2 for linux on x86_64
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for raising this @TheDevMinerTV. The example was of an earlier iteration. Fixed here


Redirects to newer WebPerf content on web.dev

We've discussed redirecting older WebPerf content we wrote here to web.dev. I'd like to propose we do this for at least a few more of the guides in /performance.
CC: @petele @philipwalton
Pete, feel free to let me know if there are other steps needed here (I think you may have once mentioned needing to remove the content from the corresponding directories, but I may be wrong...)

:+1:

Hey @addyosmani & @philipwalton - DevSite redirects only work if the requested content does not exist. So in addition to creating the redirect, you must delete the content as well. Be sure to check that you've deleted all languages as well.
I'll file a PR to fix now, but please keep this in mind for the future.


Prot vs Teff/color: add Rebull+ comparison

This is a note that to show the CQV sample is rapidly rotating rotating, we need to compare against the Prot distributions measured by e.g. Rebull+ in the Pleiades.  (Or perhaps Sco-Cen?)

resolved by https://github.com/lgbouma/cpv/commit/80405b6aaf9bebedbf2bf1b4090b565a8fea7111


rs-convert unable to convert to PLY

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10 Home

Platform
PC

SDK Version
2.18.0

Issue Description
I recorded a video using the camera and when I try to extract the frames using rs-convert, it works as expected when trying to convert to PNG but if I specify the -l option to convert to PLY nothing happens. It executes for a few seconds and then exits without saving anything. Generated log files are also empty. Same behaviour is observed when trying to convert to BIN or CSV with the only difference being it outputs the number of frames processed but nothing is saved.

I already tried it by saving the file in different locations so it does not look like a permissions issue.

I think that's a bug, we will look into it.

+1. Having the exact same issue with conversion to bin and csv. My camera model is SR300.

I have the exact same issue using a D435. Converting to all the other formats works just fine.

+1 no file

@dorodnic  I cloned the repo to a new folder and I still have the same issue with the ply conversion.

It should work as well as v2.19.0. Are we missing something?
build$ rs-convert -i ./20190308_113002.bag -l out/
100%
PLY converter
 90  frame(s) processed

build$ ls -l out/
total 1153144
-rw-r--r-- 1 12570346 Mar  8 11:32 _817.ply
-rw-r--r-- 1 13009133 Mar  8 11:32 _818.ply
.
.
-rw-r--r-- 1 13174367 Mar  8 11:35 _949.ply
-rw-r--r-- 1 13668060 Mar  8 11:35 _950.ply

build$ git log
commit 43e30ddeccdfd01641e4da6e2748760dc472df01 (HEAD)
Merge: 3dae1c41 7e91ffcc
Author: Sergey Dorodnicov<EMAIL_ADDRESS>Date:  Mon Mar 4 21:39:43 2019 +0200

    Merge pull request #3318 from dorodnic/bug_fixes

    Bug fixes

@amaanda Do you record RGB as well as Depth ?
I had the same issue and have solved it by recording both.

@ynakayji no, I only had Depth and Infrared channels. Didn't think of that. Thanks!

It could also work with depth and the Infrared channel if the infrared is outputting RGb8 format on the D415 camera.

NO file +1
Jetson tx2 ubuntu 16
viewer v2.16.0
nvidia@tegra-ubuntu:/usr/local/bin$ rs-convert -i '/home/nvidia/Documents/20190412_142928.bag' -l '/home/nvidia/Documents/ply.ply'
100%
PLY converter

nvidia@tegra-ubuntu:/usr/local/bin$ rs-convert -i '/home/nvidia/Documents/20190412_142928.bag' -l out/
100%
PLY converter

Hi, having the same issue and, I don't have the ability to recapture with RGB channels. Please help.

Also, not sure why this issue was closed when no solution was ever found.
If we need to have texture data in the .bag file in order to extract depth data, it's obviously a parsing issue. Telling people to adapt their workflows to sidestep the problems in the code isn't usually how we fix problems in software.


cannot unmanage device, stuck at first

It used to work, no idea why it suddenly stop working
This is the command I use
sudo create_ap --driver rtl871xdrv wlx8416f91127a8 eno1 hotspotname testpassword --no-virt
It stucks at
Network Manager found, set wlx8416f91127a8 as unmanaged device...
OS: ubuntu 16.04

I'm having the same issue on Ubuntu 16.04, with a USB network adapter. It used to work, and then started to hang up at the exact place

I had this suddenly start happening and resolved it by running create_ap once with the --fix-unmanaged flag. After that I can run create_ap like normal again (ie. without that flag). Worth a shot to see if it fixes your issue.

Yes, it fixed the problem. Thank you very much!


[Event Request] Database::"Purchase Line" - Function Quantity - OnValidate - OnValidateQuantityOnBeforeInitOutstanding

We like to request the following Event:
Object: Database::"Purchase Line"
Function: Quantity - OnValidate
Publisher Event: OnValidateQuantityOnBeforeInitOutstanding
Reason: To implement custom business logic
Where is the event placed:
if (Type = Type::"Charge (Item)") and (CurrFieldNo <> 0) then begin
if (Quantity = 0) and ("Qty. to Assign" <> 0) then
FieldError("Qty. to Assign", StrSubstNo(Text011, FieldCaption(Quantity), Quantity));
if (Quantity * "Qty. Assigned" < 0) or (Abs(Quantity) < Abs("Qty. Assigned")) then
FieldError(Quantity, StrSubstNo(Text004, FieldCaption("Qty. Assigned")));
end;
if "Receipt No." <> '' then
CheckReceiptRelation
else
if "Return Shipment No." <> '' then
CheckRetShptRelation;
DoInitOutstanding := (xRec.Quantity <> Quantity) or (xRec."Quantity (Base)" <> "Quantity (Base)") or ("No." = xRec."No.");
OnValidateQuantityOnBeforeInitOutstanding(Rec, xRec, CurrFieldNo, DoInitOutstanding);
if DoInitOutstanding then begin
InitOutstanding;
if IsCreditDocType then
InitQtyToShip
Event Code:
[IntegrationEvent(false, false)]
local procedure OnValidateQuantityOnBeforeInitOutstanding(var PurchaseLine: Record "Purchase Line"; xPurchaseLine: Record "Purchase Line"; CurrFieldNo: Integer; var DoInitOutstanding: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add skip_delayed_by document

Follow-up #782
@muga Please take a look when you have time.

@hiroyuki-sato thank you! will take a look

@muga Thank you! I close this PR.


Content-shell renderer process not exiting in Dartium

On one of our two Dartium windows bots, there are content_shell.exe renderer processes that don't die when the parent does.  The thread that is exiting (calling kernel32dll ExitProcess) is getting stuck waiting for Lock@Mutex@dart in OnDartThreadExit.  This causes our taskkill step to fail, because it detects these stuck processes (about 30 of them) and kills them.  I would not call this a blocker for releasing Dartium, since it only happens (and rarely) in content_shell.
The thread is: (most recent function call at top)
ntoskrnl.exe!KeWaitForMultipleObjects+0xc0a
ntoskrnl.exe!KeAcquireSpinLockAtDpcLevel+0x712
ntoskrnl.exe!KeWaitForMutexObject+0x19f
ntoskrnl.exe!PoStartNextPowerIrp+0xbb4
ntoskrnl.exe!PoStartNextPowerIrp+0x185d
ntoskrnl.exe!KeAcquireSpinLockAtDpcLevel+0x91d
ntoskrnl.exe!KeWaitForMutexObject+0x19f
ntoskrnl.exe!NtWaitForSingleObject+0xde
ntoskrnl.exe!KeSynchronizeExecution+0x3a23
wow64cpu.dll!TurboDispatchJumpAddressEnd+0x6c0
wow64cpu.dll!TurboDispatchJumpAddressEnd+0x4a8
wow64.dll!Wow64SystemServiceEx+0x1ce
wow64.dll!Wow64LdrpInitialize+0x42a
ntdll.dll!RtlUniform+0x6e6
ntdll.dll!EtwEventSetInformation+0x1da09
ntdll.dll!LdrInitializeThunk+0xe
ntdll.dll!NtWaitForSingleObject+0x15
kernel32.dll!WaitForSingleObjectEx+0x43
kernel32.dll!WaitForSingleObject+0x12
content_shell.exe!?Lock@Mutex@dart@@AAEXXZ+0x10
content_shell.exe!?RemoveThreadFromList@OSThread@dart@@CAXPAV12@@Z+0x11
content_shell.exe!??1OSThread@dart@@QAE@XZ+0xa
content_shell.exe!?CreateOSThread@OSThread@dart@@SAPAV12@XZ+0x72
content_shell.exe!?RunDestructors@ThreadLocalData@dart@@SAXXZ+0x6b
content_shell.exe!?OnDartThreadExit@@YGXPAXK0@Z+0x1d
ntdll.dll!RtlQueryEnvironmentVariable+0x245
ntdll.dll!RtlUlonglongByteSwap+0x7fc
ntdll.dll!mbstowcs+0x600
ntdll.dll!RtlExitUserProcess+0x74
kernel32.dll!ExitProcess+0x15
content_shell.exe!__crtExitProcess+0x15
content_shell.exe!doexit+0x119
content_shell.exe!exit+0xf
content_shell.exe!__tmainCRTStartup+0x10c
kernel32.dll!BaseThreadInitThunk+0x12
ntdll.dll!RtlInitializeExceptionChain+0x63
ntdll.dll!RtlInitializeExceptionChain+0x36

The task_kill.py command is changed not to report this as a failure in CL https://codereview.chromium.org/2875043002
Please revert this when the issue is fixed.


pull request for e2e test at 12/05/2016 21:45:00

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Is there an attack option?

First thanks for this code - makes everything far simpler.
Having two issues however:

-sc is hitting a timeout error waiting for the daemon to launch, this could just be a limitation of the under powered machine its running on

I am unable to have a full attack run. Is this a limitation of Zap-Cli or the API?
The active-scan just seems to run the zaproxy quick start scan, but not the full attack scan which is where I would find most High risk issues.

Am I missing something here?
Again awesome piece of work here.

Hi @McMatty! I'm glad you've found the tool useful! :)

-sc is hitting a timeout error waiting for the daemon to launch, this could just be a limitation of the under powered machine its running on

The zap-cli start command and the -sc option with quick-scan both wait 60 seconds for ZAP to start right now and otherwise raise a timeout error. We can increase this timeout time to something longer or make it configurable. Do you have an idea of roughly how long ZAP takes to fully start up on your machine?

I am unable to have a full attack run. Is this a limitation of Zap-Cli or the API?
The active-scan just seems to run the zaproxy quick start scan, but not the full attack scan which is where I would find most High risk issues.

The active-scan command should be the same as using "Attack" -> "Active Scan" via the GUI. Can you give examples of what parts of a full attack are not currently happening when running the active-scan command so I can look into what might be missing/broken? And are you using the recursive option (-r) with it (i.e. zap-cli active-scan -r http://<IP_ADDRESS>/ with any other options as needed)?

Just following this up.
Issue 2 was the result of the way I built the command up, I hadn't copied pasted the supplied example and as such the full attack was not running correctly.


kie-issues#1527: DMN Editor: Create new overlay option 'Highlight evaluation results'

Closes: https://github.com/apache/incubator-kie-issues/issues/1527

Other than that ^ looks good to go! :)

Border looks a little off, and the tooltip says (beta), but it isn't.
Also, I think the idea of having this as a https://www.patternfly.org/components/label/ instead of a "Button" is important to give it a different look compared to the other buttons, since this this is not really a button, but more like an indicator that the Evaluation highlights are turned on.
Same is true for the toggle on BEE.
We also need to be mindful of the case we choose when writing text on-screen. I always prefer to capitalize only the first word, not all words, so the label would read "Evaluation highlights: on/off", instead of "Evaluation Highlights: On/Off".
Another thing that caught my eye was the little displacement that happened when the I toggled between on and off on BEE, because of difference in text size. Being mindful of layout shifts is also very important for a good experience when using a web app.
Please consider my feedback, and let me know if you have questions!

@tiagobento good feedback, I will try to incorporate it.

Border looks a little off, and the tooltip says (beta), but it isn't.

I will remove the "(beta)". Oh, you are correct, I haven't noticed the border off placement. It is an example that author eyes are focused on other things than reviewer eyes. Thank you for spotting.

Also, I think the idea of having this as a https://www.patternfly.org/components/label/ instead of a "Button" is important to give it a different look compared to the other buttons, since this this is not really a button, but more like an indicator that the Evaluation highlights are turned on.

Ok, probably this I didn't understand from mockup. There it seemed to me as UI element with same semantic as other elements in that area, that is why I used the button. I will incorporate your proposal.

Same is true for the toggle on BEE.

Sure.

We also need to be mindful of the case we choose when writing text on-screen. I always prefer to capitalize only the first word, not all words, so the label would read "Evaluation highlights: on/off", instead of "Evaluation Highlights: On/Off".

I do not have preference about this. I don't mind follow your suggestion.

Another thing that caught my eye was the little displacement that happened when the I toggled between on and off on BEE, because of difference in text size. Being mindful of layout shifts is also very important for a good experience when using a web app.

WIll try to fix the size of the new toggle/label. However, that will probably won't work with potential i18n in future.

Changes pushed:

@jomarko The code looks great, but I found an issue in the UI. Using the toggle makes the overflow Y appear. This only happens when the Overlay panel is close to the bottom of the Editor, which is the case for me in the default zoom (100%).
https://github.com/user-attachments/assets/2c0a0c2d-5106-48c6-b19b-11216cc57eac
BUG (100%):

OK (90%):


ZEPPELIN-2161 Nested Group Support in LdapRealm for AD

What is this PR for?
A common use case in LDAP/AD setup is the hierarchical structuring of
groups - a.k.a. adding groups to other groups. Such nesting groups can
help reduce the number of roles that need to be managed.
Current zeppelin realm implementations doesn't have support for looking
up memberships throughout nested group structures.
E.g. consider the following nested group scenario:
acme_employees
 \__department_a
     \__sub_department_x

User 'bob' is in Group 'sub_department_x'.
Notebook 'note1' has a Reader Role assignment for 'department_a' or
'acme_employees'.
Then access must be granted for 'bob' on 'note1'.
In AD enviroments this scenarios can be efficiently implemented using
the so called LDAP_MATCHING_RULE_IN_CHAIN operator
'1.2.840.1135<IP_ADDRESS>1'.
This PR introduces a property 'groupSearchEnableMatchingRuleInChain' to
org.apache.zeppelin.realm.LdapRealm which defaults to false. If enabled,
all roles of potential nested group hierarchies will be resolved using
the LDAP_MATCHING_RULE_IN_CHAIN operator.
What type of PR is it?
Improvement
Todos

What is the Jira issue?
[ZEPPELIN-2161]
How should this be tested?
Set groupSearchEnableMatchingRuleInChain = true for the ldap realm.
Screenshots (if appropriate)
Questions:

Does the licenses files need update? n
Is there breaking changes for older versions? n
Does this needs documentation? y

any idea why the build has failed? I don't get the error.

Thanks @weand for improvmenet.
Have you turn on "Build Pushes" in travis-ci settings?

Can you update the doc (https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap) as well, so user reading http://zeppelin.apache.org/docs/0.7.0/security/shiroauthentication.html#ldap can leverage this feature.

@prabhjyotsingh There isn't any documentation for org.apache.zeppelin.realm.LdapRealm yet.
@Leemoonsoo Any special reason why LdapRealm wasn't documented in 0.7.0 yet?
Can anyone help me why the build is failing. I don't see, why these tests now fail, they have no obvious reference to changes of this PR:
NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[CJ4Y6RZ]> but was:<2C[ADXZJ8N]>
NotebookTest.testAuthorizationRoles:759 expected: but was:

@weand So far, we have a section for LdapRealm in shiroauthentication.md.

NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[CJ4Y6RZ]> but was:<2C[ADXZJ8N]>
NotebookTest.testAuthorizationRoles:759 expected: but was:

This problem has been fixed in current master branch. Could you rebase or merge master and see if test passes?

Rebased and green now. Thanks for your help.
Would you mind merging that into branch-0.7 as well?
Regarding docu:
The LDAP Realm section in the docu shiroauthentication.md only mentions LdapGroupRealm implementation. This change is related to the undocumented LdapRealm, which was introduced in 0.7.0.
Should we document two LDAP Realms, or should we mark the old one deprecated?
Because of that, I would prefer an separate Issue for the missing piece of documentation.

Okay, LGTM.
Merge master and branch-0.7 if no further discussion.
Regarding documentation, if LdapGroupRealm and LdapRealm are superset/subset relation, we can mark one deprecated. If not, i think we should have document two LDAP Realms.


package request: rclone-browser

This isn't in gentoo, but it sure makes using rclone a lot easier
https://kapitainsky.github.io/RcloneBrowser/  Is the webpage.
When you get a chance.

This one http://gpo.zugaina.org/net-misc/RcloneBrowser ?

Added, please check!

It works.  100%.   Thank you SO much!!!!!

Sure, no problem!


Allow sync origins containing paths

From GothenburgBitFactory/taskwarrior#3361, we should allow the sync server to be configured by URL, not just origin. This will require

changing the name of the sync.server.origin config to sync.server.url, but keeping backward compatibility
parse it as a URL, and generate the paths for the various requests by appending to the configured path

This will involve some minor changes in taskchampion/taskchampion/src/server/sync/mod.rs as well as updating everywhere that sync.server.origin occurs to prefer sync.server.url.

I'd like to give this a try :) !

Great! In this repo, I think we'll want to update
https://github.com/GothenburgBitFactory/taskchampion/blob/5168f0b86415826aa84f70d1e072b6364dd431aa/taskchampion/src/server/config.rs#L23-L33
to use url instead of origin but still as type String. Then follow the compiler errors to everywhere that's set or used. Within
https://github.com/GothenburgBitFactory/taskchampion/blob/5168f0b86415826aa84f70d1e072b6364dd431aa/taskchampion/src/server/sync/mod.rs#L12-L17
you can store an actual Url type, and then append to the path on that URL as needed elsewhere in that file.
This will be a breaking change to the library, and there will be some follow-up in the Taskwarrior repo to accommodate it, but that's OK. I expect a few breaking changes in the short term.

Nice work on this! The work on the Taskwarrior side will require the remainder of taskwarrior/taskwarrior#3209 - using TC as an external dependency.


different between do_not_specialize and tl.constexpr

When using triton, I often wonder what are the essential differences between the two and what are their respective usage scenarios? Can one give a specific scenario example to clearly show their differences?

A tl.constexpr variable is a compile time constant so it gets baked into the compiled program; that means if the value changes the program needs to be recompiled. tl.do_not_specialize is a value that will never be baked-in, so can change freely from run to run and will never trigger a recompile.
The default is somewhere in between where certain assumptions may be baked in like alignment for pointers and strides, which allows us to generate better code but at the cost of needing to recompile if an input doesn't meet the same alignment.
If you have more questions consider directing asking in the triton channel on the GPU Mode discord server.


fix: table kind should not change over the fse code trailing bits

table_kind for FSE decoder should remain the same if trailing bits row was encountered. After this trailing bits row, we might encounter another FSE table, for which the table_kind value is checked via FSE table transition lookup over the fixed table.

picked to v0.11 branch. Releasing.


Loading an image directly from S3 Storage

Hello, first of all, thank you for the great tool!
I have a question and hope you could help me.
I have a minio server and two buckets in it, the first one is named source, the second one is result
I upload a random image into source bucket, and it is directly accessible via this link, for example http://localhost:9000/source/ship.jpg
So my question is, is it possible to pass only an image name (or its directory + image name) as an argument to imagor and the image will be fetched directly from S3 and after processing stored in result bucket?
For example, like this: http://localhost:8000/unsafe/200x200/ship.jpg
These are my docker env parameters
    environment:
      - 'PORT=8000'
      - 'AWS_REGION=us-east-1'
      - 'AWS_ACCESS_KEY_ID=***'
      - 'AWS_SECRET_ACCESS_KEY=***'
      - 'S3_ENDPOINT=http://minio2:9000/'
      - 'S3_STORAGE_BUCKET=source'
      - 'S3_RESULT_STORAGE_BUCKET=result'
      - 'SERVER_ACCESS_LOG=1'
      - 'IMAGOR_UNSAFE=1'
      - 'DEBUG=1'

The env setting should result the processed image stored result bucket of path 200x200/ship.jpg

You are right, but it seems it does not try to  fetch an image directly from the file system S3 source bucket.
Here is the log:
2022-04-28T08:17:13.672+0300 DEBUG imagor/imagor.go:328 load {"key": "200x200/ship.jpg", "error": "RequestCanceled: request context canceled\ncaused by: context deadline exceeded"}
2022-04-28T08:17:13.672+0300 DEBUG imagor/imagor.go:374 suppress {"key": "img:ship.jpg"}
2022-04-28T08:17:23.671+0300 INFO server/handler.go:98 access {"status": 408, "method": "GET", "uri": "/unsafe/200x200/ship.jpg", "ip": "<IP_ADDRESS>", "user-agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.22 Safari/537.36", "took": "30.0005656s"}
2022-04-28T08:17:23.671+0300 DEBUG imagor/imagor.go:227 load {"params": {"path":"200x200/ship.jpg","image":"ship.jpg","unsafe":true,"width":200,"height":200}, "error": "context deadline exceeded"}
2022-04-28T08:17:23.671+0300 DEBUG imagor/imagor.go:328 load {"key": "ship.jpg", "error": "Get \"https://ship.jpg\": context deadline exceeded"}
2022-04-28T08:17:23.674+0300 DEBUG imagor/imagor.go:374 suppress {"key": "res:200x200/ship.jpg"}

What about adding the following env?
S3_FORCE_PATH_STYLE=1

By default, S3 SDK prepend bucket name as subdomain to the endpoint.
The can be disabled by forcing the path style, so the resulting url becomes http://minio:9000/source/...
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html

Yes, it works now, thank you!
I believe that this parameter need to be included in documentation, since it's quite common situation. Especially on dev environment.
Anyway, thank you for your help and for such a grat tool!

Added custom endpoint section https://github.com/cshum/imagor#custom-s3-endpoint


Dataset Default URL Field Not Working

Bug description

Create a dataset
Edit the dataset
Go to the Settings tab
Fill in a value for the Default URL field and save changes
In the Dataset list, click the Dataset title

Expected:
User gets redirected to the Default URL
NOTE: There is a config PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET: https://github.com/apache/superset/pull/22038
If the config is set to true, then the user should get an error message if the URL isn't a relative URL
Current behavior:
The URL in the browser changes but doesn't redirect. Refreshing the page shows a 404
Screenshots/recordings

Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

I'll like to work on this if its not assigned yet

I'll like to work on this if its not assigned yet

Thanks @Myestery we are still defining the last details for this before attaching a bounty. Keep an eye on this for updates.

Closing - this works when using a relative URL


Nullability: verify ReferenceCount(null) GetHashCode

This was highlighted as potentially incorrect, verify it works as expected.

coverage: 99.164% (-0.08%) from 99.242%
when pulling aff784197f252019eab3a64aea5d1cf81273fa47 on users/alexpeck/nullability3
into ef211dd22c834d3b2693193c580ed87819f65dca on main.


added mapToSignal + changed project layout for swift test

Codecov Report

Merging #3 into master will decrease coverage by 1.53%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   87.89%   86.36%   -1.54%
==========================================
  Files           7        7
  Lines         471      484      +13
==========================================
+ Hits          414      418       +4
- Misses         57       66       +9


project: no license / not licensed

Hello,
I was just about to use your project, when I saw that it isn't licensed anywhere in writing. I the country I reside, that means I don't have a license and can't use it.
If this was intended to be an open source / freely available, I would recommend putting a license within the project.
Thanks, -Daniel

Good point, thanks for pointing that out @kardianos  👍

Thats done @kardianos
https://github.com/cheynewallace/tabby/blob/master/LICENSE


bump transformers dependency to < 0.6

now builds with cabal and GHC 8

Bumped the dependency separately. Thanks.


Elementwise Sum (add_n) for rowsparse on GPU

@eric-haibin-lin thanks for resolving conflicts!
@reminisce @piiswrong @bhavinthaker
See original PR + code review: https://github.com/eric-haibin-lin/mxnet/pull/173

@stefanhenneking could you update your branch with mxnet master? The test failed (not caused by your changes)


Request: /log clear

It would be nice to be able to clear the log and messaging window from within the client.

there is /clear which clears the messaging window. the (possible, by default off) logging to disk cannot be removed from within the client (even /log off does not remove files), because I couldn't find any intuition/how it should be done by now (too many use cases, and various expectations, which lead me to the fact that the log file should be preserved, and manually removed).


Hide "Checks" tab on Pull request page

Checks tab is not related directly to the pull request workflow, would be helpful to have a feature that will disable this tab.

It should only be hidden if there are no checks. It can be useful if there are: https://blog.travis-ci.com/2018-05-07-announcing-support-for-github-checks-api-on-travis-ci-com

Can we leave this around for a while? It’s useful for people to learn about it

Let's wait a bit as it's still not finalised in my observations. E.g. If you have successful checks from before launching the feature on a PR, you could find them in the Checks tab, but the counter says 0.

Yeah, I think GitHub took care of that. 🙌 We can reopen if this is not right somewhere.

I still see it. I think it's time to drop it when empty

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

@sindresorhus has rewarded $36.00 to @janat08. See it on IssueHunt

:moneybag: Total deposit: $40.00
:tada: Repository reward(0%): $0.00
:wrench: Service fee(10%): $4.00


LICENSE file missing

appropriate license file for Apache 2.0 license is missing in repo

License File added.  Issue closed.


Edit Data column shifts editing back to the first column selected if editing on the null row.

If you attempt to edit another column after editing the first column you selected on the last row, the resulting refresh and addition of a new row, causes the editor focus to shift back onto the first column and any changes made to the second column to disappear. This is very unintuitive and needs to be better handled. This will require some changes as to how the table is re-rendered and how adding a new null row is done, which will take some time.

Closing as it's already been merged into main and won't be going to June release


add more types

What kind of change does this PR introduce?
types

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

Thanks


Pagination throw 500 error with large page value

Laravel Version: 5.3.29
PHP Version: 7.1.0
Database Driver & Version: PostgreSQL 9.6.1

Description:
If you would try to open page<PHONE_NUMBER>99999999 using paginate method it will throw 500 error:
SQLSTATE[2201X]: <<Unknown error>>: 7 ERROR: OFFSET must not be negative
It works the same for others website, e.g. laravel.io: https://laravel.io/forum/?page=999999999999999999
Steps To Reproduce:
Create a route with the paginate method somewhere in it:
Route::get('users', function () {
    return App\Users::paginate();
});

Then open the page<PHONE_NUMBER>99999999 and you'll get 500 error.

TL;DR: You're seriously proposing that a page
nine hundred ninety nine quadrillion ,
nine hundred ninety nine trillion ,
nine hundred ninety nine billion ,
nine hundred ninety nine million ,
nine hundred ninety nine thousand ,
nine hundred ninety nine

this can't be realistic.
Correct me if I'm wrong, but an't database that would get close of storing that.
said that, i would recommend won't fix for this.
P.S.
On some logic of why that happens, PHP can't handle that number as integer, it will depend on platform and php version but PHP 7.1 on x64 limits integers to PHP_INT_MAX being<PHONE_NUMBER>854775807
This,<PHONE_NUMBER>854775807 is kinda max number of records that will be parsed correctly on the offset.
Why? Numbers after that will be treat as float, that have a whole different representation, when too large (aka base 10).
so on those lines here
https://github.com/laravel/framework/blob/5.3/src/Illuminate/Database/Query/Grammars/Grammar.php#L579-L582
the framework is forcing the result as int, since that cannot be represented as int, it will reset on the max value and start on negative (really poor dumb explanation), that's why you got a negative number on the query.
There is a way of fixing it, but I do believe that the offset on MySQL also limits the max number to on offset approximately the same number.
So, give up or explain better why the hell you need this

@hernandev Ok, it's obviously this could happen very rarely. Anyway, I don't like when anyone can throw 500 error on my website, especially If I have an alerts system that will wake me up at night.

@pbelyaev what do you suggest?

especially If I have an alerts system that will wake me up at night.

Probably a bad idea to be alerted of every exception that occurs. Perhaps check out an error monitoring solution. I'm not going to suggest one here, but there are plenty that have laravel support.

Throwing an exception when this happens is actually correct, however, the nature of this exception is undesirable, we should probably add another check and throw an exception before the db query fails. Alternatively, you could implement a middleware in your app to truncate page numbers on the request.

@GrahamCampbell there are two easy solutions, but since Laravel does not cares on int size anywhere else (that I know), I would recommend just leaving it as it is.
Solution 1:
Just make any offset bigger than max int, max int itself
protected function compileOffset(Builder $query, $offset)
{
    // limit the max offset as being the max int size on the platform
    $offset = ($offset > PHP_INT_MAX) ? PHP_INT_MAX : $offset;

    return 'offset '.(int) $offset;
}

Solution 2:
Throw a custom exception that will be handled nicely or ignored on the ExceptionHandler
protected function compileOffset(Builder $query, $offset)
{
    if ($offset > PHP_INT_MAX) {
         throw new PaginationOutOfRangeOrWhatheverException("Page is out of max range")
    }

    return 'offset '.(int) $offset;
}

While doing some negative testing some endpoints on my application I came across this too. For me the biggest issue is that (int) (or intval()) overflows on large numbers and can thus returns large negative numbers - which causes the code to throw database exceptions. Since the current solution is to 'just' cast it and deal silently with stuff like ?page=foo (and/or actual SQL injection), I would suggest to just make sure its always positive after casting.

While doing some negative testing some endpoints on my application I came across this too. For me the biggest issue is that (int) (or intval()) overflows on large numbers and can thus returns large negative numbers - which causes the code to throw database exceptions. Since the current solution is to 'just' cast it and deal silently with stuff like ?page=foo (and/or actual SQL injection), I would suggest to just make sure its always positive after casting.


Update Ruby to 2.5.0 (with branch coverage)

Update Ruby to version 2.5.0 (released December 25, 2017).  This should have a very modest performance improvement (5-10%).  It improves Ruby's built-in ERB support, but I believe Rails uses a different implementation so our template speeds probably won't be affected.  I don't see anything else that would help us, and there's no security vulnerability that it fixes, so this isn't a "rush" update.
This will have a bigger affect than you might think, because this adds support for branch coverage measurement.  That's great, but if our branch coverage is low, we'll need to add more tests to stay at gold.  (Currently we're exempt from the branch coverage requirement because our tools don't support it, on the Ruby upgrade that won't be true.)
It would probably be wisest if we wait a while to let other people take the arrows in the back first :-).

The good news is that Ruby 2.5 adds low-level capabilities to measure branch coverage.  However, higher-level test tool drivers will need to be modified so that we can take advantage of this new Ruby capability.
So this might split into two separate actions: (1) upgrading to Ruby 2.5, and (2) separately (and later) adding a branch coverage measurement (if we can).
Here are some relevant links:

Simplecov would need to be enhanced to output the branch coverage information
Codecov's service would also need to be updated - here's their Ruby example
Ruby trunk issue #9508 (original) and #13901 (later updated version)
deep-cover might be relevant.


Error: Prefilter died

I'm running easy-search for a set of fasta files. For the majority of files everything is fine, for a small subset i'm getting the same error after prefiltering.
That's an example of my command: ../bin/mmseqs/bin/mmseqs easy-search s01_complete_refseq_representative_fasta_DEVIDED/mmseqs_rep_d_2.fa  mmseqs/mmseqs_clu_rep_db/DB mmseqs_test.tsv tmp1 --format-mode 4 --num-iterations 5 -e 1e-5 --format-output query,target,fident,alnlen,mism atch,gapopen,qstart,qend,tstart,tend,evalue,bits  --max-seqs 1000000  -s 6
MMseqs Output (for bugs)
MMseqs Version:                         b22d5f6d02cb27ebc2cd931d8d20fe92ff54b8a8
Substitution matrix                     aa:blosum62.out,nucl:nucleotide.out
Add backtrace                           false
Alignment mode                          3
Alignment mode                          0
Allow wrapped scoring                   false
E-value threshold                       1e-05
Seq. id. threshold                      0
Min alignment length                    0
Seq. id. mode                           0
Alternative alignments                  0
Coverage threshold                      0
Coverage mode                           0
Max sequence length                     65535
Compositional bias                      1
Compositional bias                      1
Max reject<PHONE_NUMBER>
Max accept<PHONE_NUMBER>
Include identical seq. id.              false
Preload mode                            0
Pseudo count a                          substitution:1.100,context:1.400
Pseudo count b                          substitution:4.100,context:5.800
Score bias                              0
Realign hits                            false
Realign score bias                      -0.2
Realign max seqs<PHONE_NUMBER>
Correlation score weight                0
Gap open cost                           aa:11,nucl:5
Gap extension cost                      aa:1,nucl:2
Zdrop                                   40
Threads                                 16
Compressed                              0
Verbosity                               3
Seed substitution matrix                aa:VTML80.out,nucl:nucleotide.out
Sensitivity                             6
k-mer length                            0
Target search mode                      0
k-score                                 seq:2147483647,prof:2147483647
Alphabet size                           aa:21,nucl:5
Max results per query                   1000000
Split database                          0
Split mode                              2
Split memory limit                      0
Diagonal scoring                        true
Exact k-mer matching                    0
Mask residues                           1
Mask residues probability               0.9
Mask lower case residues                0
Minimum diagonal score                  15
Selected taxa
Spaced k-mers                           1
Spaced k-mer pattern
Local temporary path
Rescore mode                            0
Remove hits by seq. id. and coverage    false
Sort results                            0
Mask profile                            1
Profile E-value threshold               0.001
Global sequence weighting               false
Allow deletions                         false
Filter MSA                              1
Use filter only at N seqs               0
Maximum seq. id. threshold              0.9
Minimum seq. id.                        0.0
Minimum score per column                -20
Minimum coverage                        0
Select N most diverse seqs              1000
Pseudo count mode                       0
Min codons in orf                       30
Max codons in length                    32734
Max orf gaps<PHONE_NUMBER>
Contig start mode                       2
Contig end mode                         2
Orf start mode                          1
Forward frames                          1,2,3
Reverse frames                          1,2,3
Translation table                       1
Translate orf                           0
Use all table starts                    false
Offset of numeric ids                   0
Create lookup                           0
Add orf stop                            false
Overlap between sequences               0
Sequence split mode                     1
Header split mode                       0
Chain overlapping alignments            0
Merge query                             1
Search type                             0
Search iterations                       5
Start sensitivity                       4
Search steps                            1
Prefilter mode                          0
Exhaustive search mode                  false
Filter results during exhaustive search 0
Strand selection                        1
LCA search mode                         false
Disk space limit                        0
MPI runner
Force restart with latest tmp           false
Remove temporary files                  true
Alignment format                        4
Format alignment output                 query,target,fident,alnlen,mismatch,gapopen,qstart,qend,tstart,tend,evalue,bits
Database output                         false
Overlap threshold                       0
Database type                           0
Shuffle input database                  true
Createdb mode                           0
Write lookup file                       0
Greedy best hits                        false

createdb s01_complete_refseq_representative_fasta_DEVIDED/mmseqs_rep_d_2.fa tmp1/1465312676443513838/query --dbtype 0 --shuffle 1 --createdb-mode 0 --write-lookup 0 --id-offset 0 --compressed 0 -v 3

Converting sequences
[910] 0s 184ms
Time for merging to query_h: 0h 0m 0s 44ms
Time for merging to query: 0h 0m 0s 35ms
Database type: Aminoacid
Time for processing: 0h 0m 0s 296ms
Create directory tmp1/1465312676443513838/search_tmp
search tmp1/1465312676443513838/query mmseqs/mmseqs_clu_rep_db/DB tmp1/1465312676443513838/result tmp1/1465312676443513838/search_tmp --alignment-mode 3 -e 1e-05 -s 6 --max-seqs 1000000 --num-iterations 5 --remove-tmp-files 1

prefilter tmp1/1465312676443513838/query mmseqs/mmseqs_clu_rep_db/DB.idx tmp1/1465312676443513838/search_tmp/12840997425876760019/pref_0 --sub-mat 'aa:blosum62.out,nucl:nucleotide.out' --seed-sub-mat 'aa:VTML80.out,nucl:nucleotide.out' -s 6 -k 0 --target-search-mode 0 --k
-score seq:2147483647,prof:2147483647 --alph-size aa:21,nucl:5 --max-seq-len 65535 --max-seqs 1000000 --split 0 --split-mode 2 --split-memory-limit 0 -c 0 --cov-mode 0 --comp-bias-corr 1 --comp-bias-corr-scale 1 --diag-score 1 --exact-kmer-matching 0 --mask 1 --mask-prob
0.9 --mask-lower-case 0 --min-ungapped-score 15 --add-self-matches 0 --spaced-kmer-mode 1 --db-load-mode 0 --pca substitution:1.100,context:1.400 --pcb substitution:4.100,context:5.800 --threads 16 --compressed 0 -v 3

Index version: 16
Generated by:  bb0a1b3569b9fe115f3bf63e5ba1da234748de23
ScoreMatrix:  VTML80.out
Query database size: 1000 type: Aminoacid
Estimated memory consumption: 101G
Target database size: 33611651 type: Aminoacid
Process prefiltering step 1 of 1

k-mer similarity threshold: 118
Starting prefiltering scores calculation (step 1 of 1)
Query db start 1 to 1000
Target db start 1 to 33611651
[=================================================================] 100.00% 1.00K 53s 841ms
tmp1/1465312676443513838/search_tmp/12840997425876760019/blastpgp.sh: line 139: 3819000 Segmentation fault      (core dumped) $RUNNER $PREF "$QUERYDB" "$2" "$TMP_PATH/pref_$STEP" ${TMP}
Error: Prefilter died
Error: Search died

Context
I thought maybe it's due to some special symbols in sequences in the failed fastas or larger size of proteins. Seems not, since "X" symbols where in completed fastas as well, as well as protein length ~30K or short. dividing these fasta files to a set of smaller solves this problem for a subset of new, but still leaves some with the same error. I can send an example fasta if it's needed.
Your Environment
Include as many relevant details about the environment you experienced the bug in.

Git commit used (The string after "MMseqs Version:" when you execute MMseqs without any parameters):
Which MMseqs version was used: MMseqs2 Version: b22d5f6d02cb27ebc2cd931d8d20fe92ff54b8a8, got with wget, avx2
Node info:
2 x NVIDIA Tesla V100 SXM2 GPU with 32GB RAM, connected by nvlink
2 x 8 core Intel(R) Xeon(R) Gold 6244 CPU @ 3.60GHz (total 16 cores)
768GB DDR4 RAM
387GB SSD scratch disk

(however, run on different machines, the same problem)

Yep, it also crashes wo --max-seqs parameter and search with these proteins does not crash with search against DB.fasta.


Pdf rendering problem. Colors are not rendering properly.

Attach (recommended) or Link to PDF file here:
PAC4629 (2.2)_low (1).pdf
Configuration:

Web browser and its version:
Window 10 Chrome (Version 88.0.4324.182), Mac High sierra Chrome(Version 86.0.4240.111)
PDF.js version: v2.3.200, v2.5.207

Steps to reproduce the problem:

Open original pdf in browser
Open same pdf in pdf js sample demo

What is the expected behavior? (add screenshot)

In original document you can see line draw by pencil is with color. Please find attached for the original pdf screenshot.

What went wrong? (add screenshot)

In original document you can see line draw by pencil is with color. But in rendered pdf it shows only with blue color. Please see attached for issue.

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

The pencil scribble is a stroked path with a shading pattern as the color. Looks like a duplicate of #10955.


Symmetry TODO list

Write tests

generate_symel_class_map
rotate_symels_to_mol
get_euler_angles
dc_mat
get_atom_mapping
where_you_go
symtext_from_file

Come up with better names for function, and standardize abbreviations (e.g. ctab vs. chartab)
Add symtext functions for cubic point groups
Pretty printing for symels and symtext
Adjust to changes in Molecule struct (going from Vector{Atoms} to Fermi like thingy)

Chartab! tf is ctab

I already changed all the functions to take in Vector{Atom} if that's what you mean. You can make them compatible with molecules as well, it would be nice, but not crucial.


Masking behavior is not working with crf

System information

debian
2.1, pip
TensorFlow-Addons version and how it was installed (source or binary): 0.6.0
Python version: 3.6.8
Is GPU used? (yes/no): no

Describe the bug
crf is not correctly masking the predicted decode_tags with respect to sequence_lengths as compared to the previous implementation in tensorflow contrib.
Code to reproduce the issue
In tensorflow 1.15 using contrib
import tensorflow as tf
import numpy as np

tf.__version__

np.random.seed(1)

inputs = tf.constant(np.random.normal(1,size=[2, 10, 5]), dtype=tf.float32)
transition_params = tf.constant(np.ones([5, 5], dtype=np.float32))
sequence_lengths = tf.constant(np.array([5,2], dtype=np.int32))

out = tf.contrib.crf.crf_decode(inputs, transition_params, sequence_lengths)

with tf.Session() as sess:
    sess.run(tf.initialize_all_variables())
    print(sess.run(out))

Out[1]:(array([[0, 1, 0, 4, 1, 0, 0, 0, 0, 0],
       [0, 2, 0, 0, 0, 0, 0, 0, 0, 0]], dtype=int32), array([15.558804 ,  4.2312727], dtype=float32))

with the sequence_lengths set to [5,2] respectively, all values beyond these lengths are set to 0
In tensorflow 2.1.0 using tensorflow_addons
import tensorflow as tf
import tensorflow_addons as tfa
import numpy as np

np.random.seed(1)
inputs = tf.constant(np.random.normal(1,size=[2, 10, 5]), dtype=tf.float32)
transition_params = tf.constant(np.ones([5, 5], dtype=np.float32))
sequence_lengths = tf.constant(np.array([5,2], dtype=np.int32))

out = tfa.text.crf_decode(inputs, transition_params, sequence_lengths)
print(out)
Out[1]: (<tf.Tensor: id=6982, shape=(2, 10), dtype=int32, numpy=
 array([[0, 1, 0, 4, 1, 4, 4, 4, 4, 4],
        [0, 2, 0, 0, 0, 0, 0, 0, 0, 0]], dtype=int32)>,
 <tf.Tensor: id=6984, shape=(2,), dtype=float32, numpy=array([15.558804 ,  4.2312727], dtype=float32)>

the first row of the output tensor is not masked after a sequence_length of 5. This is reproducible across various inputs and sequence lengths.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

I think that the difference is that in 1.15, dynamic_rnn was used in the _multi_seq_fn.  This zeros its outputs past sequence length by default according to docs.
To do this for the TFA version, the RNN layer has to be created with zero_output_for_mask = True (by default this is False).
I tested this by monkeypatching the method:

Maybe @squadrick can weight in on that?

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


[docs] Reword unsupported material components notes

The issue
As mentioned in #16513, some visitors to the docs might read the alerts about "no longer documented" components and think that MUI will stop supporting those components. However, the alert only means to warn users that the Material Design specifcation is no longer supporting the components in question.
The solution
Update the wording to be more clear that MUI will continue to support these components:

Steppers
Expansion Panel
Text Field (without variant)

Visuals

Area
Before
After

Steppers

Expansion Panels

Text Field (without variant)

To test

Get this code.
Ensure that you see alerts for the changed areas as expected.

@eps1lon Good call. PR updated along with updated screenshots in the Description above.

@joshwooding Thanks. I wasn't sure how the translated pages were handled. All updated now.

@m2mathew 👌


Handle Login

Would you handle login?

Yes, I will but probably next week. Let the bot play with a friend today and we found some bugs on the Yuumi behaviours. Once I fix those for good will start working on login.

Can share endpoints if needed.
Also should add random champ from free game rotation to play intro
Sent from my iPhone
On Apr 10, 2024, at 10:12 PM, Svetlio02 @.***> wrote:

Yes, I will but probably next week. Let the bot play with a friend today and we found some bugs on the Yuumi behaviours. Once I fix those for good will start working on login.
—
Reply to this email directly, view it on GitHubhttps://github.com/SvetoslavDoychinov/yuumi-bot/issues/1#issuecomment-2048808199, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGCWZ34VDEZMIFRCDMC7UK3Y4XWSPAVCNFSM6AAAAABGBM5PDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYHAYDQMJZHE.
You are receiving this because you authored the thread.Message ID: @.***>

Yumi becomes fluid, heals.
And staying still in the well


useAtomsDevtools causes react warnings with latest version of jotai

After upgrading to jotai version 2.9.0, which introduces the new store implementation, I'm getting react warnings for any components that uses the useAtom jotai hook.

Warning: Cannot update a component (AtomsDevtools) while rendering a different component (Counter). To locate the bad setState() call inside Counter, follow the stack trace as described in https://reactjs.org/link/setstate-in-render

The error seems to be caused by the use of useAtomsDevtools in our AtomsDevtools component, which apparently seems to trigger an update when atoms connect to the store.
No issues with jotai version 2.8.4

Thanks for reporting! Could you please help me reproduce this?
It seems to work fine for me locally in our Storybook playground. I'm using<EMAIL_ADDRESS>and the latest version of dev tools.

Sure, created a reproduction branch at https://github.com/axel-havukangas-tt/jotai-devtools/tree/158-repro where I updated to jotai version 2.9.1.
Interestingly, in the jotai-devtools sandbox, the warning message doesn't appear for all atoms. But at least appears when pressing the "TOGGLE RESULT" button:
https://github.com/user-attachments/assets/14377e65-91a6-42e3-9213-4862f7ccfce4
Our app has a lot of async initialisations, so might be that the warning messages actually only comes in situations where an async operation updates an atom.

Investigated the issue a bit more, and seems to be somehow related to https://github.com/jotaijs/jotai-devtools/blob/main/src/utils/useAtomsSnapshot.ts#L110 where the hooks state update is not deferred when the store subscription triggers a callback. Not sure what change has caused the warnings to trigger here though.

Okay, after some more investigation it seems that the culprit is the different implementations of the composeWithDevTools for the v1 and v2 stores. The v1 store doesn't emit any events on atom get, while the v2 implementation calls subscribes on get events.
Not sure what the reasoning is behind the extended store subscription in the v2 implementation, but one possible solution would be to skip the atom read events in the useAtomsSnapshot hook store subscription.

If I can get some confirmation that my investigation is sane, and this is a reasonable approach to fix the issue, then I could make a PR next week that would add some event filtering to the store subscriptions so that the atomsSnapshot isn't unnecessarily updated on atom reads (which obviously shouldn't affect the returned value).

Thank you so much for your thorough investigation, @axel-havukangas-tt! I believe we can completely remove this line, as it seems unnecessary now.
Initially, I thought it was required for TimeTravel to sync the history for async atoms, but with async-get in place, it's no longer needed.
Would you like to open a PR?

Yeah, if it seems like the whole get callback isn't needed then it is probably cleaner to just remove that from the v2 store composition implementation.
Created a PR at https://github.com/jotaijs/jotai-devtools/pull/160


PDF preview does not render text

Insomnia Version: 6.5.3
Operating System: Ubuntu 18.10

Details
When an endpoint returns a PDF the preview does not render any text.
This is from Insomnia

This is the PDF saved using the Save response body option.

This PDF was generated from PHP using FPDF and this code
$pdf->SetDrawColor(0, 0, 112);
$pdf->SetFillColor(0, 0, 112);
$pdf->RoundedRect(5, 5, 200, 5, 2, "DF", "12");
$pdf->SetFont("arial", "b", 9);
$pdf->SetTextColor(255);
$pdf->Text(6.5, 8.5, "Such text, very missing, wow");

RoundedRect here is a function we added but the same thing happens when using Rect.

Can you attach the PDF file to this issue?
There isn't much we can do here either way. Insomnia uses pdfjs to render PDFs so, if this is in fact an issue, it should be reported on that project instead.

Sure here's the file. example_file.pdf
If I upload it to the demo viewer page the text renders correctly.
Could it be something to do with the font not being available?

This worked for me in previous version, today auto-updated and got not text pdf.

PDF generated with iText also appears "blank" when displayed inside Insomnia. When opened via browser (both Chrome and Firefox) everything shows as expected.

I have this same issue, PDFs generated by Pentaho.
More information - when sending these PDFs via sendgrid API, the emails are also missing the text - but downloading via a browser on the same API has text. 🤔

Same issue here, PDFs are generated using Jasper (iText).

Still an issue here.

Not stale ya'll

I am getting this when loading a PDF.

I am getting this when loading a PDF.

I am with the same problem in version Insomnia Core 2020.4.0.

I am getting this when loading a PDF.

I am with the same problem in version Insomnia Core 2020.4.0.

Guys, I updated to version 2020.4.1 and it is working perfectly.
=)

We shipped #2645 in 2020.4.1 which resolves the last few comments, but I'm not sure if it resolves the initial bug report yet. Could somebody validate and report back, please?

I tested the PDF on 2020.5.2 and the text renders correctly. We can close this issue perhaps.

I tested the PDF on 2020.5.2 and the text renders correctly. We can close this issue perhaps.

Thanks @ranjan-purbey! 🙏🏽 Closed as resolved!

Thanks @ranjan-purbey! 🙏🏽 Closed as resolved!


the colors in the legends are not showing

A user has a case where she opens the map created with the editor, the legends are shown but they don't have the colors. This problem happens when she opens the map with Internet Explorer 11.( in other browsers it works).

This is duplicated: https://github.com/CartoDB/cartodb.js/issues/431. I'll fix it in the current milestone.


Version 1.97 breaks my pointclouds

Hi,
Bit hard to demonstrate with all my data locked behind firewalls, but has the rendering of pointclouds changed? I've tested all versions from 1.87 till 1.96, all fine, but 1.97 breaks them all. Has there been a change in formats, etc that I missed? I can see the "CesiumJS has switched to a new architecture for loading glTF models and tilesets" message, but in what way has this affected pointclouds? They're all pretty much version 1.0, and I use 3DTILES_draco_point_compression. I see some scattered dots, but nothing you'd understand as a pointcloud. What should I look into, what has changed with pointcloud rendering?
Cheers,
Alex

@ptrgags Would you be able to talk to anything that changes with point cloud rendering during the past few releases?

Hi @shelterit,
The introduction of the new Model architecture affects all the 3D Tiles 1.0 formats, including point clouds. The new architecture unifies the implementation, so b3dm, i3dm, and pnts all can use the same model code we use for glTF models.
The change was actually implemented much earlier in 1.90 when the new architecture was still called ModelExperimental, see this older changelog entry
The new implementation does support 3DTILES_draco_point_compression, for example, Draco is used for the tileset in this Sandcastle so maybe there's some other corner case here.
Are you using any CesiumJS features like point cloud attenuation, styling, or anything else beyond just loading the tileset?
I know you mentioned you're not able to share an example due to firewall restrictions, but if you want to inspect things on your own, these are the places in the code that are specific to point clouds:

Scene/Model/PntsLoader.js -- this handles transcoding .pnts to ModelComponents (which is based on glTF concepts)
Scene/Model/PointCloudStylingStage -- this code is relevant for styling and point cloud attenuation

Oh, @shelterit Since you can't post an example publicly here, would you be able to send example data (and/or an asset ID if you tiled through Cesium ion) to<EMAIL_ADDRESS>If so, please include this CesiumJS issue number

@aixiaodeyanjin are you able to share your tileset?

Hi there, thanks for the reply. I've turned off pretty much anything I could find (any transforms, tweaks or settings, so it's pretty raw) making me believe that maybe its a format thing? Has anything in the parsing of the files changed?
I popped the object out so you could see it (I've shot some relevant stuff);

I've stripped it bare, still no show. In my app I have a plugin I can attach to the tileset with a bunch of controls, and I've played around with all of them without seeing any changes;

I've got a screenshot for you here. The red polygon is usually clamped to a rich pointcloud, however now you only see, if you squint, a few dots here and there;

What should I investigate next in terms of the files? We use MetaShape to generate most of them, I'll see if I can pull one out for you to try.

@shelterit thanks for the info. My first guess is that something about the quantization code is wrong. That might explain why the points are so far apart. I noticed that the Draco code is slightly different in PntsLoader compared to the old implementation in PointCloud (see here vs. here)
I pushed a fix to this branch: https://github.com/CesiumGS/cesium/tree/draco-quantization-type. Could you try it out?
If that doesn't work, a MetaShape example would be really helpful.

Sure, I'll give it a try. I usually use npm packages, but I'll try to set up a Cesium build later today. But that's good that we're seeing something that worth chasing.

I've eliminated the Las file itself, it's definitely in the 3D tiles from MetaShape. Do you support Cesium Zipped tiles uploads in Ion?

You can grab the npm package published by CI if that's easier: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/draco-quantization-type/cesium-1.97.tgz

Do you support Cesium Zipped tiles uploads in Ion?

Yes

I get a 404 on that one. Anyway, don't worry, I'll give a Cesium build a try. I should have one, but it's nice sometimes not to have complete control over everything and have someone else to blame for a change ... :)

O, I've uploaded the tileset to Cesium Ion. It views in the Ion admin tool (which uses Cesium 1.91);

But if I view it in Sandcastle (which is latest 1.97), then it's blank;

You can see the assetId in the screenshot as well;
Cesium.IonResource.fromAssetId(1314334)
Let me know if you need anything else. I couldn't get Cesium to build, but that's a problem with my current environment (remote virtualbox on rubbish hardware over rubbish lines). Might be able to pull it off next week when I get back.
Hopefully that's at least enough to do a quick test. Let me know if there's anything else I could chase/try.

Ah... sorry about the 404, we'll look into that.
Good news is that the branch fixes the bug. I'll open a PR.

PR here: https://github.com/CesiumGS/cesium/pull/10794

Awesome, at least it was reasonably easy to find and fix. If only all bugs could be more like that. :) Thanks for all your help.

@aixiaodeyanjin are you able to share your tileset?

PR here: #10794

not work for me


Create 2.3.0 release?

Hi, I see https://github.com/cisco/openh264/commit/2e637867315ffeda3cd8970825ec86acc3fc4a30 and https://github.com/cisco/openh264/commit/8fe55e3f4accac7fd1af4262bcd6eff5d008396d and even http://ciscobinary.openh264.org/libopenh264-2.3.0-linux64.6.so.bz2, but there is no 2.3.0 release available at https://github.com/cisco/openh264/releases or https://github.com/cisco/openh264/tags. Recommend creating a 2.3.0 release.

yes please.

Ping? Can't be difficult to an v2.3.0 tag.

ping @justaugustus

Another ping here @GuangweiWang . Is there a specific reason for the missing tag, or was it just forgotten?

the lasted release for openh264v2.3.0 has been created.


Updated rdfe banner note type

Docs Build status updates of commit 0b9ddc7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

includes/rdfe-banner.md
:white_check_mark:Succeeded
View (azuresmps-4.0.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


The .adapt() method should be called .fit() for TextVectorization

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 2.4
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
Currently, to train or fit a text vectorizer in tf.keras.layers.experimental.preprocessing.TextVectorization, we have to call a weird .adapt() method which no one use this name in standard machine learning. It is more commonly to use the name .fit() like in scikit-learn. I suggest to name the method as .fit() so it will be more familiar to people who just came to tensorflow.
Will this change the current api? How? Yes, there will be a new .fit() method which is exactly the .adapt() method.
Who will benefit with this feature?
New beginner to tensorflow who are familiar with other ML framework but just came to tensorflow to use this awesome framework.
Any Other info.

Thanks for reaching out. fit() is already used for model training (via backprop), and the usage of adapt() in preprocessing layers is quite different. During the design phase of the preprocessing layers API, we discussed with exact question, and we decided that using a different name for adapt() would be clearer than using fit(), which would lead to confusion.


Fix vSphere management cluster API test

Issue #, if available:
Description of changes:
This PR fixes the TestVSphereKubernetes124UbuntuUpgradeAndRemoveWorkerNodeGroupsAPI e2e test that throws the following error during an upgrade:
admission webhook "validation.vspheremachineconfig.anywhere.amazonaws.com" denied the request: VSphereMachineConfig.anywhere.eks.amazonaws.com "release-i-08f80-5465421-cp" is invalid: spec.resourcePool: Forbidden: field is immutable
--- FAIL: TestVSphereKubernetes124UbuntuUpgradeAndRemoveWorkerNodeGroupsAPI (829.46s)

Some changes were made recently to ClusterE2ETest object's UpdateClusterWithKubectl method designed to upgrade self-managed clusters using the API in this PR. Previously, it parsed the cluster config from the full cluster config file generated by the CLI and replaced the ClusterConfig on the test object with it. However, this was undesirable in the context of an e2e test performing multiple updates on the self managed cluster, as it overwrote the ClusterConfig to it's initial state each time, so it was changed to only override the BundlesRef.
The problem is, this full cluster config file also contains other defaults and/or modifications of the initial input values to create the cluster, therefore, not present in the test's input ClusterConfig object. So in this case, the resourcePool value on the VSphereMachineConfig applied when its time to run the update did not have the same value used when creating the cluster object initially.
Therefore, this PR addresses the issue by decoupling loading the full cluster config generated by the CLI from the upgrade step in the e2e tests. Rather than overriding the ClusterConfig on the test object before every upgrade, the full cluster config file is loaded to the test object once after the self managed cluster is created to preserve the CLI's defaults.
Testing (if applicable):
--- PASS: TestVSphereKubernetes124UbuntuUpgradeAndRemoveWorkerNodeGroupsAPI (830.28s)

--- PASS: TestDockerKubernetes124UpgradeAndRemoveWorkerNodeGroupsAPI (866.36s)
PASS

--- PASS: TestCloudStackKubernetes123RedHatAPI (2020.32s)
    --- PASS: TestCloudStackKubernetes123RedHatAPI/add_and_remove_labels_and_taints (409.98s)
    --- PASS: TestCloudStackKubernetes123RedHatAPI/scale_up_and_down_worker_node_group (136.79s)
    --- PASS: TestCloudStackKubernetes123RedHatAPI/replace_existing_worker_node_groups (107.19s)
PASS

--- PASS: TestCloudStackKubernetes124RedHatAPI (1986.36s)
    --- PASS: TestCloudStackKubernetes124RedHatAPI/add_and_remove_labels_and_taints (471.74s)
    --- PASS: TestCloudStackKubernetes124RedHatAPI/scale_up_and_down_worker_node_group (144.10s)
    --- PASS: TestCloudStackKubernetes124RedHatAPI/replace_existing_worker_node_groups (137.98s)
PASS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.16

/lgtm

/lgtm

/approve


⚠ Bofrost.de has degraded performance

In 07c04b7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1834 ms

Resolved: Bofrost.de performance has improved in ce79b13 after 25 minutes.


Regenerate checksum when chunks are to be sliced

This GH ticket is probably not a good long-term place.

Exactly. I tried to describe the definition in a @doc manner in machi_util.erl and machi_dt.erl in the last commit push 0e4ae81 . As well as I defined macros of atoms to avoid typo bug (I made so many bugs with atom typo).

Hm.
==> machi (dialyzer)
machi_file_proxy.erl:665: The pattern <[], _, _> can never match the type <[any(),...],non_neg_integer(),non_neg_integer()>

Two compiler & Dialyzer warnings fixed. +1, thanks!

Oh, sorry.  I'll keep running dialyzer next time.


[Feature Request] Add Container Component

Existing Component
No
Component Name
Container
Description
The existing grid components are very nice. The only thing I miss is a container component to center the whole page and limit to a certain width.

This should probably be done using the Card component. However, I must say that the Card component has a lot of limitations right now.

@BigChief45 semantically, the Card component wouldn't be a good fit.
@element-bot just a basic container, like from bootstrap or from your documentation page. Centering the whole content (grid) and providing some margin on mobile if needed.

@PhillippOhlandt I think the container is just a "class"? So it's not a component

@PhillippOhlandt Ah I understand what you mean now. And yes, I believe this should be included.

@BigChief45 @PhillippOhlandt
.container {
  width: 1100px;
  margin: 0 auto;
}

I'm not sure what you mean.
But if it's just a class like above,
i think it's should be maintain in your project

@baiyaaaaa Bootstrap and many other frameworks come with classes similar to container. This eliminates the need to constantly define it like you did above. I believe this should be included in Element's layout's CSS.

@BigChief45 One thing Element is different from Bootstrap is that Element is just a component library, you can see we don't provide any classes.

@Leopoldthecoder I understand. But this means that additional frameworks will have to be added to a project just to have control of a layout and basic typography styles.
Is there no plan to include these kinds of things into Element?

@BigChief45 To have control of a layout is, in my opinion, not too much work, especially when you're already using el-row and el-col. Like what we discussed in this issue, the container has only two lines of CSS. So no, we have no plan to include such things.
Plus, I think other modern component libraries don't provide these things either. Please let me know if you find some of them do, and I will take a look.


Added a Linear Chain CRF layer and a text chunking example (parallel PR)

Adds Linear Chain Conditional Random Fields, the data set CoNLL 2000, and a text chunking example.
This PR is the parallel to https://github.com/fchollet/keras/pull/4621. The discussion startet originally in issue https://github.com/fchollet/keras/issues/4090.
Contributions and comments so far from:

@linxihui
@fchollet
@nreimers
@tboquet
@napsternxg

I would be very happy to receive more feedback! :smile:

Does it support class_weight/sample_weight right now? (seems not). Will the support be added in the future?


Create streamlit page for alignment phase

Including:

outer contour extraction (in different colors to enable comparison)

add options to control the alignment process

add option to draw feaure point links to examine succes of matching

add normalization features

add several alignment procedures to choose from:

-- FFT phase correlation
-- Enhanced Correlation Coefficient (ECC) maximization
-- Fourier-Mellin
-- Feature based registration
-- orb or sift

add degree of rotation underneath images

Closed by #35


Burn permit spending requires the right role

Add restrictions that "burnFromWithPermit" spender has to have the burner role
Add unit test for it
Restructure burn tests so regular burning and permit burning are separated

Fixed. Please re-review


Updating Scripts in Website and implementation of search bar

Problem
The website is almost ready to be showcased. One thing we still need to implement is script updation in the website. The current implementation is hard-coded HTML. The file scripts.html contains the scripts information but all has been done manually. Also, we need to implement a search bar where one can search for a script name.
Solution
The main branch contains a folder called master script and there you will find a file called datastore.json. Your task is to create the scripts to fetch that data onto the scripts.html and also implement the search functionality. For now, you can simply copy the JSON file to this branch, and later on, the GitHub action will automatically update this file.
P.S: I have little knowledge about JS so anyone who takes this issue, kindly explain if this thing is possible or not

@kaustubhgupta I would like to work on this

@Ayushjain2205 I want to know that the JSON file is sufficient for this searching?

@kaustubhgupta we want to search based on name of script right? searching can be implemented based on anything contained in the JSON file. So yes this JSON file is sufficient for searching

Okay cool, assigned to you!


Array of event handlers in config

In common\config\main.php i'm use this config for :
   'components' => [ /* ... */ ],
   'on beforeRequest' => function () {
        \Yii::$container->set('yii\widgets\LinkPager', ['maxButtonCount' => 5]);
    },

But in frontend\config\main.php i'm need use second handler for styling Html:
   'components' => [ /* ... */ ],
   'on beforeRequest' => function () {
        Yii::$classMap['yii\helpers\Html'] =<EMAIL_ADDRESS>    },

Common config does not apply, because it uses ArrayHelper::merge() and on beforeRequest is overwrite.
Suggestion for improvement
It would be nice if as values could be to use an array:
   'components' => [ /* ... */ ],
   'on beforeRequest' => [
      function () {
         \Yii::$container->set('yii\widgets\LinkPager', ['maxButtonCount' => 5]);
      }
   ],

Q
A

Yii version
2.0.7

create your own behavior
class MyBehavior extends Behavior
{
    public $events = [];
    public function attach($owner)
    {
        $this->owner = $owner;
        foreach ($this->events as $handler) {
            $owner->on('beforeRequest', $handler);
        }
    }
}

common/config/main.php
'as xxx' => [
    'class' => 'common\classes\MyBehavior',
    'events' => [function(){ ... }],
]

frontend/config/main.php
'as xxx' => [
    'class' => 'common\classes\MyBehavior',
    'events' => [function(){ ... }],
]

Thank you for this decision, but it is ugly. I need to create behavior, and use two different names to connect as xxx and as yyy.

Common config does not apply, because it uses ArrayHelper::merge() and on beforeRequest is overwrite.

This is valid usecase. Its hard to merge.

Separate behaviors that provide handlers for specific events contains more semantic, so it's more preferred.
Considering problem is not popular and in PR #13199 we have not find a reliable way to do it, I'm closing this issue. Thank you

@SilverFire

Separate behaviors that provide handlers for specific events contains more semantic, so it's more preferred.

Behaviors has much more overhead and there are also plans to remove them (or at least prefer events over behaviors where possible): https://github.com/yiisoft/yii2/wiki/Plan-for-next-major-versions#core

Considering problem is not popular and in PR #13199 we have not find a reliable way to do it

I've already proposed solution (checking if value is array of closures) - what is unreliable in it?

I've already proposed solution (checking if value is array of closures) - what is unreliable in it?

that sounds like a possible solution, had not seen that comment.

I've already proposed solution (checking if value is array of closures) - what is unreliable in it?

That comment is about at least, that usually brings inconsistency.

Hm... We can use Closure::fromCallable()

That comment is about at least, that usually brings inconsistency.

There are many places where closures are supported and other callable types are not. The only way to fix this is force Closure everywhere.

@SilverFire fromCallable is PHP 7.1+ so 2.1 only.

Won't be implemented in 2.0.


don't mutate linelist when filtering it, store a new filtered version

This tiny PR fixes a small bug.

It’s good to keep in mind that making a copy is potentially a high-memory operation, but I want this to work in cases where the linelist has “gaps”.


benefits - include equity weighted benefit calculation

I commited some changes in the test_database in this pull request, which do not need to be reviewed since we use the SVN.


Opening hotkeys closes game

When opening the hotkey window, either through settings window or /tb hotkey, the game freezes and closes shortly after.

Fixed in 5.7 (0592bb4)


panel addon: when replacing the only existing panel, the new panel also is removed.

When calling addPanel with the option replace and the panel that will be replaced is the only panel, the whole panel container is removed, including the just newly created panel.
this bug can also be observed on the demo page (https://codemirror.net/demo/panel.html), steps to reproduce:

delete panel no. 2. There should be now only panel no. 1
click on "replace panel no. 1" button
now panel no. 1 disappears (as expected), but panel 3 does not show up.

I have narrowed it down to the following behaviour:
when calling addPanel(panel3, {replace: panel1}), panel 3 gets created and appended, but info.panel counter is not yet increased by one. (this is done at the end of addPanel.)
now panel1.clear() gets called, the counter which is still at 1 even though it should be 2, gets decreased to 0 and thus removePanels() is called inside the Panel.prototype.clear() funtion

Fixed via #5519


Remove sentry tracking from the assessments-develop environment

We want to remove sentry from the development environment doesn't track errors from the bugs during development.

@warrensearle I don't think Sentry is tracking development, this is the code I've found in main.js:
if (process.env.NODE_ENV !== 'development') {
  Sentry.init({
    dsn: '[removed]',
    environment: process.env.NODE_ENV,
    release: process.env.npm_package_version,
    integrations: [new Integrations.Vue({ Vue, attachProps: true })],
  });
}

Yes, that's the place.
When we're running the apps on localhost we are using NODE_ENV = 'development' - which enables hot reloading and recompiling.
Whenever the site is running on a url, be that production, staging or develop, we are using NODE_ENV = 'production'.
We need to include an additional check in there so that Sentry is not initialised for URLS matching -develop.
This will mean that Sentry only logs errors from our staging and production servers.


idea:  Refactor the README to be more user-oriented

Hi, iceberg-rust is going to release 0.3 and trying to attract users. I feel like it's the time to refactor the README to be more user-oriented.
The goal is to attract users of using iceberg-rust instead of treating it's still WIP.
I feel like we need to:

Move roadmap to issues or projects, and just leave a link in README.
Most content in README should be user-oriented that includes

Quick Start: 10 lines code to show how iceberg-rust works.
Examples: links to existing examples for more complicated use cases
Documentation: links to API documentation
Contribute: How to contribut to this projects, may be a link to contributing guide.
Users: Lists of iceberg-rust users.
Other stuffs like licenses, trademark and so one.

I'm happy to handle this issue. I enjoy writing in markdown and coding in rust. 😄

Quick Start is not ready yet, I will start another PR to add it.

Hi, @liurenjie1024, could you start a tracking issues for all features that we lack compared to java impl?

Currently I have grouped features into these components in this project, so I'm not sure what kinds of issue you want? Maybe you can start with one and I can help to edit?

Understood.
I'd like a comparison between iceberg-rust and iceberg-java. It's a frequently asked question: what are the differences, and to what extent does iceberg-rust have the same features as the java implementation?
I will try to start one and invite you to join the edit.

I think eventually we will reach feature parity as iceberg-java to implement iceberg spec, but integration with engines with be different.

Oh, I see. I got your point. The full java impl is not just about the iceberg table spec, it contains a full engine.


React 0.14 migration and better support for new react-draggable version

Removed deprecated cloneWithProps module in favor of React.cloneElement
Updated usage of React.getDOMNode with ReactDOM.findDOMNode
Updated GridItem.mixinDraggable to wrap child element with intermediate  wrapper (per react-draggable docs). NOTE: this solved a lot of issues for me in terms of layout/positioning.

Thanks! Reviewing shortly.
On Nov 19, 2015 11:39 PM, "Adam Weber"<EMAIL_ADDRESS>wrote:

Removed deprecated cloneWithProps module in favor of
React.cloneElement
Updated usage of React.getDOMNode with ReactDOM.findDOMNode
Updated GridItem.mixinDraggable to wrap child element with
intermediate wrapper (per react-draggable docs). NOTE: this solved a lot of
issues for me in terms of layout/positioning.

You can view, comment on, or merge this pull request online at:
https://github.com/STRML/react-grid-layout/pull/128
Commit Summary

Removed deprecated cloneWithProps module in favor of
React.cloneElement

File Changes

M dist/react-grid-layout.min.js
https://github.com/STRML/react-grid-layout/pull/128/files#diff-0
(30)
M dist/react-grid-layout.min.js.map
https://github.com/STRML/react-grid-layout/pull/128/files#diff-1 (2)
M lib/GridItem.jsx
https://github.com/STRML/react-grid-layout/pull/128/files#diff-2 (5)
M lib/mixins/WidthListeningMixin.js
https://github.com/STRML/react-grid-layout/pull/128/files#diff-3 (5)
M package.json
https://github.com/STRML/react-grid-layout/pull/128/files#diff-4 (1)
M webpack.config.js
https://github.com/STRML/react-grid-layout/pull/128/files#diff-5 (2)

Patch Links:

https://github.com/STRML/react-grid-layout/pull/128.patch
https://github.com/STRML/react-grid-layout/pull/128.diff

—
Reply to this email directly or view it on GitHub
https://github.com/STRML/react-grid-layout/pull/128.

Thanks @aweber1, I've merged this in https://github.com/STRML/react-grid-layout/commit/b9a5c5026b629e073f5ae29bf53e6a1bf2d4ef0d. I wanted to exclude the dist files and merge style since we're no longer getting auto-merge from cloneWithProps.
I'm still seeing what looks like an offset problem related to the vertical positioning of the grid. I'll work to get it fixed and we can release.


over-indentation on loop control statements

If you have e.g.
for {
    if {
        break
    } else if {
        continue
    } else {
        // something...
    }
}

We can dedent the last else block. We warn for returns in that situation, we should also warn for control flow statements inside of a for loop.

On that note, if ... else if blocks should probably recommend they be swapped to a switch, since most style guides (and the Tour of Go) recommend using switches over elseif chains.


Added hover close functionality

RE #6
Added close functionality, and added some documentation on how to use both pretty_hover.hover and pretty_hover.close

I just split some long lines with tables into multiple lines. Thanks for the edit.


Release 1.0.0

Description
Release the new version of the SDK, 1.0.0
How to test
Nothing to test
Merging
Automatic

 Release


Check/command multiline copyrights string fix

Fixed check and modified fix command accordinf last requirements agreement

Please adjust unit tests


Logo proposal for DecisionTree

Hi! @juliangaal
I'm interested in collaborating with this project by delivering a series of logotype options that fits this project for the best!
If interested let me know so we can get started!
Cheers!

Sure, what's the kicker? What's your motivation?
I am not sure if this project will ever become more than my hobby project, but good logos are always nice :D

Hi @juliangaal
It motivates me to contribute with open source projects in addition to refining my design skills and improving my portfolio.

@juliangaal
It would be very useful if you would provide me with the most information and if you want some features or specific colors.

I have a doubt about the license of your repository?

it should be minimalistic. Take a look at the tree in the readme. Maybe you could design a logo of an actual tree, with the nodes and edges like in the decision tree?
I don't mean to be rude, but what does the license mean for you? why does it matter?

Hi @juliangaal
Perfect soon my logo proposal will be presented.
With respect to the license, I refer to copyright policies.
Good day.

Well, that's nice that you "refer to them". Tell me, Why does the license matter to you?

@juliangaal  Because it must be free.

Thanks for the suggested help, but am I no longer interested, as you couldn't concisely answer my questions. Closing now.


Fix __contains__ on tuple pk searches

As lists cannot be added to tuples and vice-versa, we cast pk_values to a list.
Python 3.10.6 (main, Dec 12 2023, 14:13:45) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> [] + ()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: can only concatenate list (not "tuple") to list
>>> () + []
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: can only concatenate tuple (not "list") to tuple

Thank you!


Type hint all gdscript

I've type hinted every GDScript var I could find (Hopefully I didn't miss any) for a few reasons:

GDScript runs faster in Godot 4 when it's type hinted
You get to take full advantage of intellisense
You had most of it type hinted already, so doing the rest made the code more consistent

Thanks for the contribution! I didn't know about the positive impact on performance :+1:


there is message that is dispalyed all the time when i am debugging my app

THIS IS THE ERROR THAT I AM FACING AND THERE IS NO SOLUTION I CAN FIND ON THE INTERNET!!
PLEASE HELP.
WHAT TO DO???

When the exception was thrown, this was the stack
#0      Quiz.build..
package:flutter_tuto/quiz.dart:21
#1      _InkResponseState._handleTap
package:flutter/…/material/ink_well.dart:706
#2      _InkResponseState.build.
package:flutter/…/material/ink_well.dart:789
#3      GestureRecognizer.invokeCallback
package:flutter/…/gestures/recognizer.dart:182
#4      TapGestureRecognizer.handleTapUp
package:flutter/…/gestures/tap.dart:486
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#edfd9
debugOwner: GestureDetector
state: possible
won arena
finalPosition: Offset(205.4, 296.0)
finalLocalPosition: Offset(205.4, 19.0)
button: 1
sent tap down
════════════════════════════════════════════════════════════════════════════════
════════ Exception caught by gesture ═══════════════════════════════════════════
type 'List' is not a subtype of type 'int' of 'score'

The Github issue tracker is for bugs and features requests for the Flutter SDK. Help and support questions like these are better suited for Q&A sites like StackOverflow or on one of the flutter community sites at https://flutter.dev/community .

thanks, appreciate ur help!


add Piecewise Parabolic Method discretization method

Reference: https://www.sciencedirect.com/science/article/pii/0021999184901438?via%3Dihub
Currently tests/demo_ppm_runs.jl shows that it's usable as a substitute for WENO, and tests/demo_parker_singular.jl shows that it can create a SingularException that I'd like to try and chase down.
PPM is explicitly dependent on the timestep, so only fixed-timestep methods should be used. I think the best ones are forward/implicit Euler, since that's what past astro codes that use PPM have used.
PPM is also compatible with varying dx, which I'd like to try out with the Parker wind problem (which has a logarithmic x axis that I analytically transformed to be uniform) once the fixed-dx case works.

For sure, these are more notes on what I'd like to implement that'd be useful for my own research than on inherently how useful the method is