Mechanism to easily perform cone searches based on current widget view

We want to provide an interface to the Astrolabe archive through (py)WWT in Jupyter, and the natural way to exchange data between the frontend and the backend is with the appropriate VO protocols. So, it should be drop-dead easy to get data into a pywwt view through VO queries, and to visualize VO query results in pywwt.
We have astroquery and related libraries to actually do the VO querying, so this issue is much more about working out a smooth and easy overall workflow rather than necessarily adding a bunch of code to pywwt. Some specialized functionality might be needed to smooth that workflow, but my intuition is that it would not be a large amount.
This work should coordinate with the Astrolabe team to make sure that we have a smooth and intuitive workflow for accessing that particular repository from a pywwt/Jupyter frontend.

An update from the Astrolabe team: looks like the main use case they're currently targeting involves table queries using Simple Cone Search and asynchronous Table Access Protocol.

This issue was a bit broad. I'm narrowing this one down into the more specific concept of having pywwt provide a nice mechanism to help the user easily perform a VO cone search based on the current field of view of a WWT widget. Naively, I'd expect that this would involve something like taking a template query and filling in the cone-search specifics based on the current viewport settings.


reduce docker image size

we can build binary and put it into alpine docker.

We can use https://hub.docker.com/r/frolvlad/alpine-glibc/
I test binary built in CentOS 7 and 6.6, both are OK. @iamxy

Can we close it now?  @iamxy


set this.value conditionally

Move setting this.value into the value changed branch for boolean attributes

Ping @justinfagnani


Class 'Caffeinated\Modules\Support\ServiceProvider' not found

Not work with Modules in my app

sorry - wrong repository!


Benchmark RAML designers and other API design tools

From @kyyberi on November 3, 2015 16:59
RAML spec versio 1.0 is out and in the same time tools have been put out.
"API Designer is a standalone/embeddable editor for RAML (RESTful API Modeling Language) written in JavaScript using Angular.JS. By default, the editor uses an in-browser filesystem stored in HTML5 Localstorage."
https://github.com/mulesoft/api-designer
Copied from original issue: apinf/platform#576
Goal
Benchmark 1-2 other API designer tools
List the benefits and pros and cons
Create enhancement issues based on existing wireframes

Succeeded by #119


drawOnCanvas.html 报错：Cannot read property 'querySelectorAll' of undefined

npm start 后打开 http://<IP_ADDRESS>:8080/tests/drawOnCanvas.html 页面报错：
Uncaught TypeError: Cannot read property 'querySelectorAll' of undefined
    at Player._init (player.js:20)
    at Player (player.js:15)
    at new Player (svga.min.js:11699)
    at drawOnCanvas.html:12

看了下具体的原因是 var player = new SVGA.Player() 中没有指定 container，所以导致 player.js 中的 this._container 为 undefined

https://github.com/yyued/SVGAPlayer-Web/commit/d12087b2d829dccea92d5d0c3ad2324e5bf80b69
Fixed. Thank you!


fix: update image origin information index

Image Search Fix
Description
The image search feature wasn't working and was always returning an empty array.
Fixes
It seems that the index that refers to the origin changed from 9 to 22, so I just changed that.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas (it wasn't necessary)
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (it wasn't necessary)
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

Tried the code, it now returns links and fixes the current bug, but the results are completely different that what searched.

Awesome, thanks for contributing!
@alexandrosmagos
Are you sure? I did a few tests and all results were relevant to the query used. But maybe I'm missing something or we need more context here.


Save Issue

Error: Forbidden
Error: Forbidden
    at Request.<anonymous> (https://homebrewery.naturalcrit.com/homebrew/bundle.js:73934:19)
    at Request.Emitter.emit (https://homebrewery.naturalcrit.com/homebrew/bundle.js:1898:20)
    at XMLHttpRequest.xhr.onreadystatechange (https://homebrewery.naturalcrit.com/homebrew/bundle.js:74243:10)
{
  "status": 403,
  "method": "POST",
  "url": "/api?transferToGoogle=true"
}

Likely your google credentials have expired on the site. Try logging out of Homebrewery and back in with your google credentials.
As of March 28th, there is a new Logout button that can be found by hovering over your username in the top right of the screen.  Or follow the steps in #1580.


Bolded quick links don't show up as bolded in live preview mode

This appears to be a different problem than #3.


Add jest 28 support

I updated peerDependencies for jest-environment-jsdom 28

Thanks, @Connormiha! I'll release this shortly.

@Connormiha Latest release (3.1.0) should work with Jest 28. Had to do a bit more work, though, because the underlying package changed a little bit. Let me know if it works for you, please!

@simon360 thanks


native-tls so that wss:// type urls will work

Problem
couldn't connect to holium's staging comfyui server via websockets lib because it needed wss:// instead of ws:// (tls)
Solution
include tls in the binary

@dr-frmr is this the correct way to print now? https://github.com/kinode-dao/kinode/pull/349/files#diff-3d22168e645c4d6513c023acf9ed57ed3d5950d1b0ae3f5ba48644c8bf2457d9R222


Having a hard time to start using twine, can someone help?

The problem I am facing right now, for which I would love to have your help is that whenever I try to use twine in the command prompt I get this error “Unable to parse line 1 of strings.txt>[[General]]”
Approach #1: Since our current project is already half complete I thought I could just import keys from our existing .xml files to a blank strings.txt file (values-ja.xml > strings.txt) but after running (apparently with success) this option in twine_ui, the strings file remains blank (strings.txt in in another folder than the .xml files).
Approach #2: After trying that without success I decided to try the other way around (strings.txt > values-ja.xml) through the command line by using the example in your git page:
[[General]]
[yes]
en = Yes
es = Sí
fr = Oui
ja = はい
[no]
en = No
fr = Non
ja = いいえ
Still when I run generate-string-file it keeps giving a parse error and I can’t go from there.
I would really appreciate some help on this because I already spent some hours trying to setup twine and would be inglorious to leave it at this point (and mostly because I really think it is a great tool).
What do you think I am doing wrong?

I am not very familiar with twine_ui and am not sure how old it is or how well it currently works. That said, where exactly are you having trouble? Creating strings.txt from your Android XML file? Or from using your strings.txt file that you already created from the Android XML file? If the former, a command like this should work:
touch strings.txt
twine consume-string-file strings.txt PATH_TO_XML_FILE --developer-language YOUR_DEV_LANG  --consume-all --consume-comments

If the latter, could you post a sample strings.txt file that isn't working for you?

I got it working! Thank you very much, basically I was tring to use notepad for new strings.txt files but it creates Unicode instead of UTF-8 files. It was all about the wrong encoding from the beginning.
Regards ;)
Jorge André Pereira
Product Owner
Tlm: +351 916 996 270
From: Sebastian Celis<EMAIL_ADDRESS>Sent: terça-feira, 21 de Julho de 2015 18:12
To: mobiata/twine<EMAIL_ADDRESS>Cc: Jorge André Pereira<EMAIL_ADDRESS>Subject: Re: [twine] Having a hard time to start using twine, can someone help? (#85)
I am not very familiar with twine_ui and am not sure how old it is or how well it currently works. That said, where exactly are you having trouble? Creating strings.txt from your Android XML file? Or from using your strings.txt file that you already created from the Android XML file? If the former, a command like this should work:
touch strings.txt
twine consume-string-file strings.txt PATH_TO_XML_FILE --developer-language YOUR_DEV_LANG  --consume-all --consume-comments
If the latter, could you post a sample strings.txt file that isn't working for you?
—
Reply to this email directly or view it on GitHubhttps://github.com/mobiata/twine/issues/85#issuecomment-123405609.


[Doc] TOTP configuration guide needs to match IS v5.8.0 defaults

Purpose

Doc its say to skip 1-3 steps for new product versions but  when it comes to step 4 it wont match for IS v5.8.0. as the TOTP authenticator config section is already there in v5.8.0. But with different values.

<AuthenticatorConfig name="totp" enabled="true">
    <Parameter name="encodingMethod">Base32</Parameter>
    <Parameter name="timeStepSize">30</Parameter>
    <Parameter name="windowSize">3</Parameter>
    <Parameter name="authenticationMandatory">true</Parameter>
    <Parameter name="enrolUserInAuthenticationFlow">true</Parameter>
    <Parameter name="usecase">local</Parameter>
    <Parameter name="secondaryUserstore">primary</Parameter>
    <Parameter name="TOTPAuthenticationEndpointURL">totpauthenticationendpoint/totp.jsp</Parameter>
    <Parameter name="TOTPAuthenticationEndpointErrorPage">totpauthenticationendpoint/totpError.jsp</Parameter>
    <Parameter name="TOTPAuthenticationEndpointEnableTOTPPage">totpauthenticationendpoint/enableTOTP.jsp</Parameter>
    <Parameter name="redirectToMultiOptionPageOnFailure">false</Parameter>
</AuthenticatorConfig>

Field explanation table content should sort to match configuration code block

Should explain why we need to comment out <module ref="addressing"/> line

Should elaborate more about the sample app path

E.g. After following sample app build guide you can find the .war file in the path: product-is\modules\samples\sso\sso-agent-sample\target\travelocity.com.war and can be deployed it in the tomcat server as instructed in the previous step.

Cannot find option to enable/disable SaaS Application as guide. That option comes only after you click register

Travelocity screenshot needs to update

Whats there in the doc

Whats there in v5.8.0

Environment

Windows 10

Steps to reproduce

Follow the guide: https://docs.wso2.com/display/ISCONNECTORS/Configuring+TOTP+Authenticator

This information also has to be included in the doc.
https://github.com/wso2-extensions/identity-outbound-auth-email-otp/blob/master/docs/html-support.md


Making first PR to Typescript branch (WIP)

Making PR as said in https://github.com/adonisjs/adonis-framework/issues/871#issuecomment-394612963.
This PR adds TS support for migrations. In order to make this work, just use branch typescript of "adonis-lucid" repo, change migration file's extension to TS and edit its code as in screencast: https://github.com/adonisjs/adonis-framework/issues/871#issuecomment-394148021
Marked as WIP because, it's only first step out of many in order to completely add TS support to AdonisJS.

Hey @thetutlage Seems Appveyor cannot build because there is conflicting package-lock.json.
I've edited package.json (standard section) to add TS support to it (according to https://standardjs.com/#typescript).
I think you should resolve conflict, then appveyor and travis can proceed.

Coverage increased (+0.06%) to 96.422% when pulling 1e5011550d1397b6e08b731c745862aa46723fbe on anurbol:ts into e4442b129d3b0a440b12e72e0afca9f2103ba029 on adonisjs:typescript.

@thetutlage I've mastered rebase command finally, thanks to you :+1: I guess now everything is OK. You should compare old .js files with new .ts files, though it's hard in github, i guess.

Cool, lemme do it

I know, you have your own tools, but just in case, I found this useful and easy to use: https://www.diffchecker.com/diff


Use redux?

Do we really need to use redux with this library? We don't really need the flexibility to add more and more actions and our state mutations are pretty simple. Perhaps we could get away with not using redux at all. If users want this library to fire RESOURCE_FETCH, RESOURCE_RECEIVED, or RESOURCE_ERROR actions, we could provide a straightforward way for them to subscribe to these types of events. I think we'd need to provide some sort of subscription or hook for users to use to cause a re-render in their application anyway.
Furthermore, this connect-to-redux functionality could also be a little smarter about when we trigger a "store change" event. Currently, any update to a resource (even ones not currently used by any components) will cause a redux store mutation and trigger a re-render. But if we didn't use redux under the hood, we could be a little smarter, running the mapResourcesToProps function and comparing the output to the previous output and only triggering a "store change" if the outputs differed.
Also, anything we can do to limit our dependencies and the technologies that users would have to adopt to use this library is a win.
Definitely curious to hear others' thoughts.

Seems like the most useful part of this library is
    const { user } = props;

    // user <-- This is a resource object. It has a few special properties:
    // user.status <-- this is the status of the request. It can be one of these three values:
    //                 ('pending' || 'fulfilled' || 'rejected')
    // user.retry <-- if a resource's status is 'rejected', this will be a function that a component
    //                can use to retry the request
    // user.result <-- if the resource's status is 'fulfilled', this will be the value returned from
    //                 the api

    if (user.status === 'pending') return <Loader />;
    if (user.status === 'rejected') return <RetryButton retry={user.retry} />;

   // render etc
}

The redux part would be handy if you needed to trigger actions in other parts of your app based on API loading state where a global store with the state could give you that information, otherwise usually just the components care about having the data.
 Said high-order component could take redux actions (or any func) as props and fire them on loading events if needed, otherwise you can just use it as a pure react component.
Interesting library that's doing similar things: react-resolver

Looking through react-resolver thanks to your rec!

The redux part would be handy if you needed to trigger actions in other parts of your app based on API loading state where a global store with the state could give you that information

I think this is where the "subscription" part might be able to help out. Would giving users a way to fire actions on RESOURCE_FETCH, RESOURCE_RECEIVED, and RESOURCE_ERROR be sufficient you think? Maybe you could pass them in optionally when creating the resource manager?:
createResourceManager({
  onFetch: (requestParams) => dispatch({ type: 'FETCH', requestParams }),
  onReceived: (requestParams, data) => dispatch({ type: 'RECEIVED', requestParams, data }),
  onError: (requestParams, error, retry) => dispatch({ type: 'ERROR', requestParams, error, retry })
})

Or if we wanted to be able to optionally connect the resource manager to a redux store for some smarter integrations, maybe the API is simply:
connectResourceManagerToStore(resourceManager, store)

// or

connectToStore(resourceManager)(store)

I could see this just being a high-order component with a built in place for a "loader" and some settings for retrying, caching, timeouts, error handling, etc (all the crap no one wants to re-invent).

The DataRequired component that we use internally on the LT team at BF basically does all this (with the exception of timeouts). I've struggled with whether or not it should just come as part of the higher order component that connectResourceManager wraps a component with. I found that there were times when we wouldn't necessarily want to show a loader - and times when we did want to show a loader but only until a certain subset of the resources had returned. It ended up being useful for the components to have the option of examining resource.status themselves and doing something custom if it was pending or rejected.
If we did decide to combine DataRequired into the higher order component we wrap the Component with in connectResourceManager, perhaps it could take a number of options that would (a) allow developers to pass through resources unwrapped (keeping their fields: status, result, retry, etc), (b) show a custom Loader or Error component, (c) show these components or children when certain resources have loaded (this could just be a shouldShowLoader function supplied by the developer that receives the resources as args and expects a boolean return value).
Also, the connectResourceManager could easily take the form of a decorator (which results in a syntax I quite like!).
Whew - that was a lot of stuff. Did any of that make sense? Hahaha

One other piece of functionality I like about the resource manager is that definitions for the resources can live in one place - even if you end up using that resource in several unrelated components. I think there's something powerful about this. Since the resources definition really has more to do with the endpoints than with the client application itself, these could be shared across many applications which use the same APIs.
For example, imagine if we just needed to maintain a single resources.js definition for all of the internal endpoints at BF. Applications could just name the bf-resources definition as a dependency and start using getResource.users() or getResource.videos() right away. You could do the same for other public APIs.
Also, also: I like that even if multiple components are wrapped with this connectResourceManager, they still use a common cache. I didn't see this functionality in react-resolver, though it wouldn't be too difficult for the developer to implement some sort of cache in the function passed to @resolve.
Also, also, also: I'm loving react-resolver's docs!

Agreed that it seems useful to define all your resources in one place that can be shared across a teams / apps. Kind of like CSS Modules but for data. Taking everything mentioned above maybe something like
import {manage} from 'resource-manager'
import resources from 'resources';
import Loader from './Loader';
import Error from './Error';

@manage("video", function(props) {
  const totallyOptionalConfig = {
    params: {videoId: props.params.videoId},
    request: { },
    cache: '5m',
    onFetch: () => {},
    onReceived: () => {},
    onError: () => {},
  };

  return resources.video(totallyOptionalConfig)
});
class VideoDetail extends React.Component {
  render() {
    const { video } = this.props;
    // this could be handled by the component however they wish
    // but maybe provide an optional wrapper that does this in a standardized way
    if (video.status === 'loading') return <Loader />
    if (video.status === 'error') return <Error />
    if (video.result) return <Video video={video.result} />
    ...
  }
}

Ohhh, I'm liking this!
A few thoughts:

In order to share a cache across multiple components wrapped with manage, I think we'd have to have a createResourceManager that would take the resources definition (and perhaps some options for "connecting" to a Redux store) and would return the manage function we could use to wrap components.

Do you think the cache TTL should be defined per component? Or just per resource? If just per resource, this could be included in the resources definition. FWIW, this is how we're doing it now.

We could let manage take some options for defining Loader and Error components so it could do the job of checking a resource's status.

Maybe by default manage would pass down just the resource's result, but could also take an option to have it pass down a resource as is (with status, result, retry, etc).

Working off what you've got, maybe it would become something like this?:
In manager.js:
import createResourceManager from 'resource-manager'
import resources from 'bf-resources'
import store from './store'
import { RESOURCE_FETCH, RESOURCE_RECEIVED, RESOURCE_ERROR } from './actions'

const { manage } = createResourceManager(resources, {
  onFetch: (params) => store.dispatch({ type: RESOURCE_FETCH, params }),
  onReceived: (params, data) => store.dispatch({ type: RESOURCE_FETCH, params, data }),
  onError: (params, error, retry) => store.dispatch({ type: RESOURCE_FETCH, params, error, retry })
})

export default {
  manage
}

Meanwhile, in the Component:
import { manage } from './manager'
import Loader from './Loader'
import ErrorBar from './Error'

@manage(
  'video',
  (props, getResources) => getResources.video({ videoId: props.videoId }),
  {
    LoaderComponent: Loader,
    ErrorComponent: ErrorBar
  }
)
class VideoDetail extends React.Component {
  render() {
    // video comes unwrapped by default (i.e. it is just the value of video.result)
    const { video } = this.props
    // when given a LoaderComponent & ErrorComponent, the `manage` wrapper takes
    // care of `pending` and `rejected` statuses, and unwraps and passes the result
    // when the status is `fulfilled`
    return <Video video={video} />
  }
}

Do you think the cache TTL should be defined per component? Or just per resource? If just per resource, this could be included in the resources definition. FWIW, this is how we're doing it now.

Yeah I was just firing off things I think you would want to "configure" like cache ttl or request options, but it probably makes more sense to just bundle those options with the resource.
I like the above proposed spec, esp since you could call createResourceManager without the 2nd arg if you werent using redux. Abstracting out the "load status" to be handled by the manager seems nice but probably makes it harder to do custom rendering based on how many resources have loaded or which specific ones have loaded. Probably more edge case than norm but im just thinking how you do it so you can easily create progress loaders or just not block render if some resources load before others.

Abstracting out the "load status" to be handled by the manager seems nice but probably makes it harder to do custom rendering based on how many resources have loaded or which specific ones have loaded. Probably more edge case than norm but im just thinking how you do it so you can easily create progress loaders or just not block render if some resources load before others.

Yeah, I think you're right. If we were to include the "load status" handling in the manager, we'd have to also provide some hooks whereby developers could pass a shouldShowLoader function. I'm also realizing that even if we didn't provide those hooks, developers could still choose to have the manager pass through the full request objects untouched so they could handle them however they want. You could also create a higher order component to wrap the manager component to encapsulate your custom Loader-showing logic.


Revert the revert

Reverts MystPi/ninetails#68

Reminds me of how @JaydenDev 's first browser went. Reverts were so common!


Replaced download url  due to certificate issues

Description
Bug fixing:
Replaced download url "https://win.rustup.rs/x86_64" to "https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-msvc/rustup-init.exe". The "https://win.rustup.rs/x86_64" has download issues due to certificate problem (in corporate environments).

Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

Hello!
We do not observe any problems in our builds (https://github.visualstudio.com/runner-images/_build/results?buildId=130882&view=logs&j=747417c8-a650-5aed-afed-d9b52dbd7d24&t=f245de8a-85db-5d11-6f6b-a3b45c2b2a6a as example) so we would not like to change the link overall in main.


CMS Pages?

Why is CMS Pages needed?
Can this thing run without django CMS?

Yes. Instead of creating a CMS page and using a CMS app, you can create the View directly, for instance such as:
class MyOrderView(order.OrderView):
    renderer_classes = (ShopTemplateHTMLRenderer, JSONRenderer, BrowsableAPIRenderer)

Note: the difference here is that you use the ShopTemplateHTMLRenderer instead of the CMSPageRenderer.
Afterwards attach this view to your urls as:
    url(r'^order/$',
        MyOrderView.as_view(),
        name='shop-order'),

    url(r'^order/thanks-for-your-order/?$',
        MyOrderView.as_view(many=False, is_last=True),
        name='shop-order-last'),

    url(r'^order/(?P<slug>[\w-]+)/?$',
        MyOrderView.as_view(many=False),
        name='shop-order'),

@rizplate forgot to mention, that you should use the branch releases/0.11.x.


Errors not being raised when errors are logged

There are a bunch of places in magql that log the error but do not raise an appropriate error type. Find the instances where errors are logged to magql and raise an appropriate error type

And remove the logging, since that would be redundant.

#41 removed logging and changed the one place that actually appeared to be an error into an error, so closing this.


Add support for reading full memory dumps

If you write a full memory dump on Windows by calling MiniDumpWriteDump with MiniDumpWithFullMemory you get a dump that's just different enough that Breakpad and this crate can't do anything useful with it. The main difference is that since the dump includes all memory from the process, the memory is written in one continuous block at the end of the dump, and the dump contains a Memory64ListStream instead of the usual MemoryListStream:
https://docs.microsoft.com/en-us/windows/win32/api/minidumpapiset/ns-minidumpapiset-minidump_memory64_list
To handle full memory dumps we'd have to add support for reading this stream, and also probably refactor things a bit so that things that currently deal with the existing memory list stream can handle either type of stream. For example:
Additionally, some structs that currently reference a memory region (like MinidumpThread) will need to deal with reading and handling either type of memory region:
https://github.com/luser/rust-minidump/blob/e9c864c5222b2753af9ec8866d4634f3d147f72f/src/minidump.rs#L160
We can probably make MinidumpMemoryList and MinidumpMemory handle both types of memory regions, since fundamentally you just wind up with a virtual address + a slice of bytes, but we might need to provide a helper method on Minidump to get the memory list that tries each stream in turn and returns whichever one succeeds.

@Gankra just something that popped into my head thinking about 1.0 API stability. I don't think this is critical for Mozilla's usage, since crash-stats is not accepting full memory dumps and it can't currently interpret them anyway, but as a general-purpose tool it'd be nice if we could read them. AFAIK the memory storage is the only difference. It's annoying, but we could just have an enum that wraps the two possible memory list formats and another for the two possible memory region formats? Alternately, it seems feasible to translate individual MINIDUMP_MEMORY_DESCRIPTOR64 entries into MINIDUMP_MEMORY_DESCRIPTOR with the data available while reading the dump.
I looked into this a while back but my memory is fuzzy now. I think the MINIDUMP_MEMORY64_LIST stream is written after all other data in the minidump, and then all of the process memory regions are appended at the end so it'd look something like:
[header]
[stream directory]
[all other streams]
[memory list 64:]
  number_of_ranges: u64
  base_rva: u64
  [array of MINIDUMP_MEMORY_DESCRIPTOR64, number_of_ranges entries in size, each like:]
    start_of_memory_range: u64
    data_size: u64
[memory contents follow, offset of this data is base_rva from above, in matching order of descriptors above]
[base_rva + 0: memory region 0]
[base_rva + region 0 data_size: memory region 1]
[…]

We would need to experimentally verify this. IIRC we had some environment variable in the Firefox crashreporter code that would cause it to write out a full dump, we added it for analysis of tricky crashes from CI/local dev.

Ended up thinking about this just now. I've already introduced UnifiedMemoryInfo to abstract over different kinds of MemoryInfo. Maybe a similar approach is right for MemoryLists as well. Although I'm actually now thinking of tweaking the API so there's just methods hanging off of minidump to directly compute them, instead of making you know about and request all the streams individually. Encourages users to Do The Right Thing more often. Hmm..


Fix SyntaxError while building v1.16.0 release on Ubuntu 17.04 i686

Fix SyntaxError while building v1.16.0 release on Ubuntu 17.04 i686 with ./script/build --create-debian-package
~/atom/script/lib/code-sign-on-mac.js:13
  let certPath = process.env.ATOM_MAC_CODE_SIGNING_CERT_PATH;
    ^^^

    SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

Thank's to @yvan-sraka for it's helpful debug!

Node 6+ is required to build Atom.

Currently, the Node version offered by the official APT sources of the latest version of Ubuntu is 4.7.2: http://packages.ubuntu.com/zesty/nodejs ; and this change of 3 characters is the only thing we need to support this legacy version of Node, so why not?

We want to keep the Node we program against in Atom's build process as close as possible to the Node we program against in the rest of the Atom project. It makes our lives as maintainers simpler.


Enhancement: Improving the status center UI

Is your feature request related to a problem?
Files app is great but the only thing is that its file transfer UI is not that great, official windows UI is much better and easy to work with.

Capability
Priority

Show overall progress of all file operations in a progress ring on the status bar
Must

Show additional details for file operations in the status center
Should

Display badges on the status bar to indicate the status of file operations
Should

Additional comment
Thanks the Files App is the best in terms of UI I've ever seen just this one thing I had an issue with.

While we don't have plans to make this change, one of the things we are looking at is an option to pin the status center UI in Files. Please let us know what you think of this idea.

I too like this idea I would much prefer a reskinned version of windows 10 default one. It gives all the information needed and could allow users to see files transfers while the main window is minimized or and a different display.

I think we should ditch the Status Center UI that I built. It has proven to be unintuitive and could be better served by a window displaying information.

I think we should ditch the Status Center UI that I built. It has proven to be unintuitive and could be better served by a window displaying information.

@duke7553 Personally, I find the status center as it is is much less intrusive than the Windows explorer one, especially for smaller/shorter file operations. I think having a separate window can be helpful (eg. #4627), but more often than not I find the Windows explorer method of managing operations to be inconvenient and just gets in the way. Not to mention, Windows explorer's use of windowing to show operation progress goes against Microsoft's own design guidelines for utilizing multiple windows.
I think the current design could instead be improved upon by adding more management options, like pause, cancel, and maybe even an undo operation button. I also think having progress badges/indicators on the status center button would make it easier to identify the status of ongoing operations. Perhaps similar to how the Edge team does it with their downloads flyout.
Here's a few rough mockups I made for progress indicators/badges:

Edge ones:

I think we should ditch the Status Center UI that I built. It has proven to be unintuitive and could be better served by a window displaying information.

@duke7553 Personally, I find the status center as it is is much less intrusive than the Windows explorer one, especially for smaller/shorter file operations. I think having a separate window can be helpful (eg. #4627), but more often than not I find the Windows explorer method of managing operations to be inconvenient and just gets in the way. Not to mention, Windows explorer's use of windowing to show operation progress goes against Microsoft's own design guidelines for utilizing multiple windows.
I think the current design could instead be improved upon by adding more management options, like pause, cancel, and maybe even an undo operation button. I also think having progress badges/indicators on the status center button would make it easier to identify the status of ongoing operations. Perhaps similar to how the Edge team does it with their downloads flyout.
Here's a few rough mockups I made for progress indicators/badges:

Edge ones:

@winston-de This is spot on with what I discussed with Luke around an hour ago. A lot of users don't even have the latest changes, and the changes you mentioned above will further improve the current design.

In any case features like to and from file paths, current speed, what type it is (copy, move, recycling, perm deleting), how many files/folders are left and what file/folder it currently doing should be added.

An idea to discuss. Replace the Status Center by a new page, and the current button opens a tab with that page (like the chrome download center).

I think we should ditch the Status Center UI that I built. It has proven to be unintuitive and could be better served by a window displaying information.

@duke7553 Personally, I find the status center as it is is much less intrusive than the Windows explorer one, especially for smaller/shorter file operations. I think having a separate window can be helpful (eg. #4627), but more often than not I find the Windows explorer method of managing operations to be inconvenient and just gets in the way. Not to mention, Windows explorer's use of windowing to show operation progress goes against Microsoft's own design guidelines for utilizing multiple windows.
I think the current design could instead be improved upon by adding more management options, like pause, cancel, and maybe even an undo operation button. I also think having progress badges/indicators on the status center button would make it easier to identify the status of ongoing operations. Perhaps similar to how the Edge team does it with their downloads flyout.
Here's a few rough mockups I made for progress indicators/badges:

Edge ones:

@winston-de This is spot on with what I discussed with Luke around an hour ago. A lot of users don't even have the latest changes, and the changes you mentioned above will further improve the current design.

Nice idea, but the current design is too small & I am kinda person who likes to see the whole process plus the window from native windows shows a progress bar which is big and also shows me the transfer speed,<< this makes file transfer in "Files" app feel slow, and since it's a separate window we can minimize it & reopen it through shortcut keys if say I am anther app (I've shortcut keys on my mouse to switch between apps) not only that hovering mouse on taskbar icon it shows me the realtime progress plus progress is also shown by green gradient on taskbar icon which is very underrated but very useful features so that the main reason for me to want that native transfer UI.
Thanks.

I would like to add additional idea. Currently it seems that in status UI only active transfers are visible.
It would be great to see at least few last file transfers to verify that something was completed.

I think that might be better as a windows notification as then there's a sound and popup on the main display. Action centre on windows could log it and users can see the ones done there.
I think the status page should pop out like the preview pane. that way the users could adjust the width and it more consistent with the rest of the app.

TBH, having a progress indicator is the best solution as it grabs the user's attention.
The way it works currently involves unnecessary navigation and it can be reduced by something like this :
This is a concept I had made for a personal project which had status in the side-bar but you can adjust that to your liking

TBH, having a progress indicator is the best solution as it grabs the user's attention.
The way it works currently involves unnecessary navigation and it can be reduced by something like this :
This is a concept I had made for a personal project which had status in the side-bar but you can adjust that to your liking

This concept is very beautiful. It would be interesting to see something like that in the Files.

Thanks.

If you are still open to ideas on this one, I hope you would still consider taking inspiration from the Downloads UI in web browsers, from showing a progress UI at the bottom to having a full page that can be accessed from menus or keyboard shortcut (ctrl+j)

Im fairly new to files, and its superb
I agree with comments above, something on its own page, would be sensible, showing speed, number of, number left
I will point out, i missed the fact that it was copying, so what happens when you initialize a copy needs to highlight to the user that it is underway and they can inspect it by clicking 'here'
ITs one of those things, as a new user I hold the real feedback of missing it - and i would def stress that while making a 'status of copies' is maybe future dev, ensuring that a user knows that the copy is at least underway a critical issue.

We can make window tab change color (fill with light transparent green) like a progress bar. Similar idea is implemented by chrome at app icon on taksbar for downloads.

That proberly wont be possible since WinUI doesnt support that by default and would invole a custom tab interface witch would be difficult to maintain. Plus theres already the progress ring and icon that browers use.

We can make window tab change color (fill with light transparent green) like a progress bar. Similar idea is implemented by chrome at app icon on taksbar for downloads.

This is already supported

I presume they mean the actual tabs in Files.

I presume they mean the actual tabs in Files.

I indeed meant the tabs within the files window.

New thing I notice is that when lots of files are being discovered to run an operation, Explorer will show that and how many have been found with Files it just looks like it frozen at 0%.

Merging with #11265


MI-337 - corrected variable name

Backend error can only be seen when debug turned on in wordpress wp-config.php

Commit not informative enough, please explain what it does and why it's needed as per the style guides.
Fix the commits that don't belong to you by rebasing


ValueError('Failed to load delegate from {}\n{}'.format( ValueError: Failed to load delegate from edgetpu.dll)

Description
Just purchased a Coral USB Accelerator and cannot run the demo on a Windows 11, Mac, or Raspberry Pi machine. Once we installed 20221024 runtime and PyCoral library, we cloned the GitHub repository. When we try to run the example, we get the following error on Windows 11:
Traceback (most recent call last):
  File "C:\Users\acct\AppData\Local\Programs\Python\Python39\lib\site-packages\tflite_runtime\interpreter.py", line 160, in load_delegate
    delegate = Delegate(library, options)
  File "C:\Users\acct\AppData\Local\Programs\Python\Python39\lib\site-packages\tflite_runtime\interpreter.py", line 119, in __init__
    raise ValueError(capture.message)
ValueError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\acct\Documents\GitHub\pycoral\examples\classify_image.py", line 121, in <module>
    main()
  File "C:\Users\acct\Documents\GitHub\pycoral\examples\classify_image.py", line 71, in main
    interpreter = make_interpreter(*args.model.split('@'))
  File "C:\Users\acct\AppData\Local\Programs\Python\Python39\lib\site-packages\pycoral\utils\edgetpu.py", line 87, in make_interpreter
    delegates = [load_edgetpu_delegate({'device': device} if device else {})]
  File "C:\Users\acct\AppData\Local\Programs\Python\Python39\lib\site-packages\pycoral\utils\edgetpu.py", line 52, in load_edgetpu_delegate
    return tflite.load_delegate(_EDGETPU_SHARED_LIB, options or {})
  File "C:\Users\acct\AppData\Local\Programs\Python\Python39\lib\site-packages\tflite_runtime\interpreter.py", line 162, in load_delegate
    raise ValueError('Failed to load delegate from {}\n{}'.format(
ValueError: Failed to load delegate from edgetpu.dll

Received similar errors in the mac and raspberry pi environments. I do not see Coral USB listed once performing the install
Click to expand!
Issue Type
Support
Operating System
Windows 10
Coral Device
USB Accelerator
Other Devices
No response
Programming Language
Python 3.9
Relevant Log Output
No response

Hi can you please try  the demo adding  the  below lines at: https://github.com/google-coral/pycoral/blob/master/examples/classify_image.py#L41 and share the logs..Thanks!
from pycoral.pybind._pywrap_coral import SetVerbosity as set_verbosity
set_verbosity(10)

Here are our logs from a Raspberry Pi 4:
I tflite/edgetpu_manager_direct.cc:453] No matching device is already opened for shared ownership.
I driver/driver_factory_default.cc:31] Failed to open /sys/class/apex: No such file or directory
I driver/usb/local_usb_device.cc:944] EnumerateDevices: vendor:0x1a6e, product:0x89a
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[2] port[0]
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[1] port[1]
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[1] port[0]
I driver/usb/local_usb_device.cc:944] EnumerateDevices: vendor:0x18d1, product:0x9302
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[2] port[0]
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[1] port[1]
I driver/usb/local_usb_device.cc:979] EnumerateDevices: checking bus[1] port[0]
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (PCIe) is available.
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (USB) is available.
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (Reference) is available.
I tflite/edgetpu_manager_direct.cc:502] Failed allocating Edge TPU device for shared ownership.
Traceback (most recent call last):
  File "/home/user/project/lib/python3.9/site-packages/tflite_runtime/interpreter.py", line 160, in load_delegate
    delegate = Delegate(library, options)
  File "/home/user/project/lib/python3.9/site-packages/tflite_runtime/interpreter.py", line 119, in __init__
    raise ValueError(capture.message)
ValueError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/user/coral/pycoral_test/examples/classify_image.py", line 122, in <module>
    main()
  File "/home/user/coral/pycoral_test/examples/classify_image.py", line 72, in main
    interpreter = make_interpreter(*args.model.split('@'))
  File "/home/user/project/lib/python3.9/site-packages/pycoral/utils/edgetpu.py", line 87, in make_interpreter
    delegates = [load_edgetpu_delegate({'device': device} if device else {})]
  File "/home/intelligentmedicine/circulate/lib/python3.9/site-packages/pycoral/utils/edgetpu.py", line 52, in load_edgetpu_delegate
    return tflite.load_delegate(_EDGETPU_SHARED_LIB, options or {})
  File "/home/user/project/lib/python3.9/site-packages/tflite_runtime/interpreter.py", line 162, in load_delegate
    raise ValueError('Failed to load delegate from {}\n{}'.format(
ValueError: Failed to load delegate from libedgetpu.so.1

Thanks for the logs. Does the LED light is on USB accelartor? Please share the output of lsusb command.

Here is the output from lsusb command:
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 002: ID 2109:3431 VIA Labs, Inc. Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
The LED light is on but it blinks.

It should blink when running the Edgetpu Model. The device is defective since its blinking without running any TPU model and not listed under lsusb, please return the product to original seller and get the new one. Thanks!


Missing sourcemaps in @react-aria and other deps causing log spam

NextUI Version
2.3.6
Describe the bug
Adobe just released a patch to react-spectrum to address missing source maps, which causes lots of errors while debugging locally:

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Run debug mode of an app using source maps with nextUI
Expected behavior
No errors :)
Hopefully the dependency can be updated and all will be good.
Screenshots or Videos
No response
Operating System Version
Windows
Browser
Edge

Thanks for the issue! I think we can address this once the next version of react-aria is released.

mark this on hold first. I think there is some changes we may need to do if we bump react-aria versions.


Twitter plugin

Logging this task to add Twitter(X) plugin
Check this discussion

Closed via
https://github.com/hlxsites/sunstar/pull/123


Avoid replacing escapes globally, refactor ASTBuilder and support tuple

Avoid replacing escapes in the source code file, which will impact the performance;
Refactor ASTBuilder for better readability;
Support tuple;
Improve ASTComparatorCategory to handle cast exception properly;
Change the precedence of declarationRule in expression;

I really don't like the "expected exception" handling, just to support comparison. Can't we fix DeclarationExpression so it doesn't cast indiscriminately?

OK. You're right. I'll refine the DeclarationExpression and revert the change of the test rig.

@jespersm I pushed some commits just now, please check them again. Thanks.


Autograph could not transform <function Model.make_test_function..test_function at 0x14ec9d430> and will run it as-is.

System information

Have I written custom code:
OS Platform and Distribution : MacOS 11.5.2
TensorFlow installed from TensorFlow_MacOS
TensorFlow version (use command below): 2.4
Python version: 3.8.10
GPU model and memory: Using apple M1 CPU

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

**Occasionally will return during training:
WARNING:tensorflow:AutoGraph could not transform <function Model.make_train_function.<locals>.train_function at 0x14c680d30> and will run it as-is.
Please report this to the TensorFlow team.

**
Describe the expected behavior: no error message
Standalone code to reproduce the issue
Training fashion-MNIST:

DefaultConv2D = partial(keras.layers.Conv2D,
                        kernel_size=3, activation='relu', padding="SAME")

model = keras.models.Sequential([
    DefaultConv2D(filters=64, kernel_size=7, input_shape=[28, 28, 1]),
    keras.layers.MaxPooling2D(pool_size=2),
    DefaultConv2D(filters=128),
    DefaultConv2D(filters=128),
    keras.layers.MaxPooling2D(pool_size=2),
    DefaultConv2D(filters=256),
    DefaultConv2D(filters=256),
    keras.layers.MaxPooling2D(pool_size=2),
    keras.layers.Flatten(),
    keras.layers.Dense(units=128, activation='relu'),
    keras.layers.Dropout(0.5),
    keras.layers.Dense(units=64, activation='relu'),
    keras.layers.Dropout(0.5),
    keras.layers.Dense(units=10, activation='softmax'),
])
model.summary()

model.compile(loss="sparse_categorical_crossentropy", optimizer="nadam", metrics=["accuracy"])
history = model.fit(X_train, y_train, epochs=10, validation_data=(X_valid, y_valid))
score = model.evaluate(X_test, y_test)
X_new = X_test[:10] # pretend we have new images
y_pred = model.predict(X_new)

Sorry if I have not included the information correctly. I have never submitted a bug before.

@Loganpi In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here.Thanks!

Here is my full code:
import tensorflow as tf
from tensorflow import keras
import numpy as np

(X_train_full, y_train_full), (X_test, y_test) = keras.datasets.fashion_mnist.load_data()
X_train, X_valid = X_train_full[:-5000], X_train_full[-5000:]
y_train, y_valid = y_train_full[:-5000], y_train_full[-5000:]

X_mean = X_train.mean(axis=0, keepdims=True)
X_std = X_train.std(axis=0, keepdims=True) + 1e-7
X_train = (X_train - X_mean) / X_std
X_valid = (X_valid - X_mean) / X_std
X_test = (X_test - X_mean) / X_std

X_train = X_train[..., np.newaxis]
X_valid = X_valid[..., np.newaxis]
X_test = X_test[..., np.newaxis]

from functools import partial

DefaultConv2D = partial(keras.layers.Conv2D,
                        kernel_size=3, activation='relu', padding="SAME")

model = keras.models.Sequential([
    DefaultConv2D(filters=64, kernel_size=7, input_shape=[28, 28, 1]),
    keras.layers.MaxPooling2D(pool_size=2),
    DefaultConv2D(filters=128),
    DefaultConv2D(filters=128),
    keras.layers.MaxPooling2D(pool_size=2),
    DefaultConv2D(filters=256),
    DefaultConv2D(filters=256),
    keras.layers.MaxPooling2D(pool_size=2),
    keras.layers.Flatten(),
    keras.layers.Dense(units=128, activation='relu'),
    keras.layers.Dropout(0.5),
    keras.layers.Dense(units=64, activation='relu'),
    keras.layers.Dropout(0.5),
    keras.layers.Dense(units=10, activation='softmax'),
])
model.summary()

model.compile(loss="sparse_categorical_crossentropy", optimizer="nadam", metrics=["accuracy"])
history = model.fit(X_train, y_train, epochs=10, validation_data=(X_valid, y_valid))
score = model.evaluate(X_test, y_test)
X_new = X_test[:10] # pretend we have new images
y_pred = model.predict(X_new)

Is this what you wanted?
Thanks, Logan

@Loganpi I tried to run your code on colab using  latest stable version of TF 2.6.0 and didn't face the error reported.Please find the gist here for reference .Please try to execute your code using TF v2.6 and let us know if the issue still persists ?Thank you!

Hey thanks, I actually can't get a newer nervation of TF because I'm on an M1 Mac. I guess ill just use collab until my pc comes.
Thanks, Logan


PMG Support?

The Proxmox Mail Gateway API requires the name of the authentication cookie to be PMGAuthCookie instead of PVE's PVEAuthCookie.
I've added an extra option to the credentials object to support this.
I'm not sure if this is still within the scope of this library. If it is I'm happy to create a PR for it.

Awesome!, if it's backwards compatible we'll take it.

It is. I've added an entry to the readme file to show using it for the MailGateway API. Tests are included as well.

@ZzAntares could you take a look at the PR?

Merged, apologies for the time hehe I really don't care much about PHP anymore 😛


User status always stays offline in Settings ignoring status changes made in the app or in other clients

Describe the bug
User status under Settings always stays offline, even though it has been changed in the app or in any other client and the actual status is reflected when you find the user by searching or see the user's details in any room.
To Reproduce

Login to Android native app.
Go to Settings - the user status is offline.
Go to Settings->Profile->Status
Change it to busy, tap Change status.
Tap on the back arrow.
The user status under username still shows offline

Expected behavior
A user's actual status should be reflected in Settings
Screenshots

Devices and Versions
Your Rocket.Chat.Android version: 3.5.0
Your Rocket.Chat Server version: 1.4.0-develop
Mobile device model and OS version: Samsung SM-J530F Android 8.1.0

That info is retrieved from LocalStorage (a SharedPref) which does not seem to observe tre actual value of the status. I've mitigated by using the value retrived from the RCClient
rocketChatClientFactory.get(currentServer).me().status

Closed by https://github.com/RocketChat/Rocket.Chat.Android/pull/2481


Create DiscreteController

This PR is the first step toward decoupling controls from actuators; #372.
Goals like MocoControlGoal and MocoControlTrackingGoal depend on control signals. Previously, the goals obtained these controls via the Model, which provides controls at stage Velocity. However, the control signals we use don't actually depend on stage Velocity; they are provided by the solvers.
With this PR, we can access controls without going through the Model. Additionally, goals now specify which stage they depend on, which should allow us to avoid unnecessary calculations; we need not handle constraint forces if the goal does not depend on them. I was hoping this could help with performance, but the speed improvements are modest to nonexistent.
Nonetheless, this is a first step towards further decoupling the problem's controls from the model's actuators.
Previously, we were setting controls on the model via Model::setControls(), which is not the proper way to provide controls. The proper way is to use a Controller object, which we now do.

This change is

Thanks for the thorough review. I should be able to respond to these comments within a week.


Light cannot turn on/off on button card

Ciao Clooos,
I'm tried your plugin because is very interesting but i have strange problem with toogle service, in detail the light not turn on/off.
type: vertical-stack
cards:
  - type: custom:bubble-card
    card_type: pop-up
    hash: '#cameraa'
    name: cameraa
    icon: mdi:bed-double
    state: sensor.camera_all_count
  - type: grid
    columns: 1
    square: false
    cards:
      - type: custom:bubble-card
        card_type: separator
        name: Faretti
        icon: mdi:lightbulb-multiple
        styles: |
          .separator-container div:last-child {
            opaticy: 1|important;
          }
      - type: grid
        columns: 2
        square: false
        cards:
          - type: custom:button-card
            name: Faretto 1
            icon: mdi:lightbulb
            label: Camera Matrimoniale
            show_label: true
            show_state: false
            entity: light.faretto1cm
            tap_action:
              action: toogle
            hold_action:
              action: more-info
            state:
              - value: 'on'
                styles:
                  card:
                    - background: >-
                        linear-gradient(50deg, rgba(241,201,59,1) 30%,
                        rgba(250,227,146,1) 100%)
              - value: 'off'
                styles:
                  card:
                    - background: '#ffffff'
            styles:
              icon:
                - width: 24px
                - color: black
              image_cell:
                - justify-self: end
                - width: 30px
                - height: 30px
              name:
                - justify-self: start
                - font-size: 18px
                - line-height: 40px
                - fond-weight: 600
              label:
                - justify-self: start
                - font-size: 14px
                - font-weight: 500
              card:
                - padding: 18px
                - background: '#ffffff'

For checking in below the error logs:
 Logger: frontend.js.latest.202312082
Source: components/system_log/__init__.py:300
First occurred: 19:30:03 (48012 occurrences)
Last logged: 20:37:32

    Uncaught error from Firefox 120.0 on Windows 10 TypeError: e is undefined entities (src/common/entity/compute_state_display.ts:48:17) formatEntityState (src/common/translations/entity-state.ts:38:26) n (/hacsfiles/Bubble-Card/bubble-card.js:1:8774) set hass/K< (/hacsfiles/Bubble-Card/bubble-card.js:1:18944)
    Uncaught error from Firefox 120.0 on Windows 10 TypeError: undefined has no properties entities (src/common/entity/compute_state_display.ts:48:17) formatEntityState (src/common/translations/entity-state.ts:38:26) n (/hacsfiles/Bubble-Card/bubble-card.js:1:8774) set hass/K< (/hacsfiles/Bubble-Card/bubble-card.js:1:18944)
    Uncaught error from Firefox 120.0 on Windows 10 TypeError: element is null addStyles (/hacsfiles/Bubble-Card/bubble-card.js:1:4019) n (/hacsfiles/Bubble-Card/bubble-card.js:1:18381) set hass/K< (/hacsfiles/Bubble-Card/bubble-card.js:1:18944)
    Uncaught error from Firefox 120.0 on Windows 10 Error: Pop-up card must be placed inside a vertical_stack! If it's already the case, please ignore this error 🍻 set hass/< (/hacsfiles/Bubble-Card/bubble-card.js:1:19061)

Could you check?
i'm using lasted hassio version.

Hi. Is it possible that you have a wrong entity name?

Ciao Clooos,
I'm solved change configuration but the entity was correct, because when turn off from cloud app the lights the state was detected by styles (on/off), by the way if you want can close the request, thanks very much to spent your time to respond!!! :)

@rcavezzale how did you solve it?
I have the same issue (entity name is correct.)

@Clooos should I open a new ticket or use this one?

@poiromaniax have you tried with the new 1.6.0 beta?

I just tried - it still doesn’t work 😞
On Thu, 21 Dec 2023 at 11:49 AM Cloos @.***> wrote:

@poiromaniax https://github.com/poiromaniax have you tried with the new
1.6.0 beta?
—
Reply to this email directly, view it on GitHub
https://github.com/Clooos/Bubble-Card/issues/230#issuecomment-1865961294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZMJQ4OBRTX4IOD4NITPV3YKQA4FAVCNFSM6AAAAABAN754N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVHE3DCMRZGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you show me the YAML of the button you have an issue with?

@Clooos sure:
type: custom:bubble-card card_type: button button_type: switch entity: switch.1000bfd0c7 name: Lounge Light icon: mdi:white-balance-sunny show_state: true tap_action:   action: toggle

@Clooos did you get a chance to look at it? This still doesnt work for me

Hi, can you tell me if this issue is still here in the v2 beta?
Here is the full changelog:
https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0-beta.1


Bug: install fails behind proxy

Bug report
The installation curl command fails when I run Git Bash behind my company proxy.
To reproduce
When I open Git Bash and I run the installation command curl -s "https://get.sdkman.io" | bash than nothing seems happen.
So I've run again the curl installation without the silent mode option -s, running curl "https://get.sdkman.io" | bash then I get the error curl: (35) OpenSSL SSL_connect: Connection was reset in connection to get.sdkman.io:443
System info

Microsoft Windows 10 Enterprise, version 10.0.19042 N/D build 19042
Git Bash installed with git version 2.37.3.windows.1

A partial solution
Before  running the curl installation command I've run export https_proxy="user:password@proxyhost:proxyport"
Clearly, every time I open Git Bash I have to run export https_proxy="user:password@proxyhost:proxyport" before any sdkmen command.
Best regards,
taringamberini

Hi @taringamberini,
This isn't a bug, but rather a limitation of your corporate proxy and how curl works.
In future, please follow the contributing guidelines before opening a bug report here.

In future, please follow the contributing guidelines before opening a bug report here.
Sorry, in the future I'll do.

Best regards


Api analyzer does't recognize ApiConventionType on a base controller

Is this a Bug or Feature request?:
Bug.
Steps to reproduce:
[ApiConventionType(typeof(DefaultApiConventions))]
public abstract class MyBaseController : ControllerBase

public class SomeController : MyBaseController
{
	[HttpGet]
	public async Task<ActionResult<SomeDto>> Get(string id)
	{
		var result = await GetData(id);
		if (result == null)
		{
			return NotFound(); // WARNING: undocumented
		}

		return Ok(result);
	}
}

Description of the problem:
In child controllers, the analyzer doesn't realize that there is an api convention being applied and it produces warnings. A workaround is to apply the convention on assembly level.
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
Using Asp.Net Core 2.2.

Thanks for contacting us, @mrahhal.
@pranavkm, please have a look.
Also, this may be relevant: https://github.com/aspnet/AspNetCore/issues/4410


Fix eclipse classpaths and application that maintains them.

Problem was being caused by duplicate entries in bundles and jars
subdirs of lib_managed.
sbt populates same jars into both bundles and jars directories
for a number of dependencies.
Duplicates removed, and tool now checks and excludes duplicates.
DFDL-1866

+1


More classifiers

Add classifiers to match logs produced by SimpleConsoleFormatter https://github.com/dotnet/runtime/blob/6a889d23/src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs#L142-L154
The Windows Forms designer in Visual Studio emits diagnostics logs, and I'm making sure these logs are correctly categorised (and prefixed). The prefix strategy is the same as employed by SimpleConsoleFormatter.
This will help developers who build Windows Forms .NET applications (and obviously use your wonderful extension) to read the diagnostics output.
Before:

After:

I've tested it manually by applying the changes in the installed extension, and then applying the changes to the code.

@mike-ward thanks for merging. When do you think you may publicly release this?

Gosh, I thought I did.

Hah, I think I totally missed it. Sorry :)


User Guide Updates In App

Feedback from NASA testers

The nav title of "Help" was not descriptive enough. "User Guide" would be better
Since the user guides are so long, it can be easy to get lost in the user guide.
After finding the information they need, users have to scroll all the way back to the top to navigate somewhere else. This is time consuming.

Acceptance Criteria

[x] The nav element and page header should say "User Guide"
[x] The sub-page nave element that currently says "User Guide" should say "APT"
[x] Users are able to quickly navigate to different sections of the user guide (i.e. accordion, floating table of contents, or some other solution)
[x] Once users have found their information, users are able to quickly navigate to somewhere else in the app
[x] Updated text in this document is shown in the APT user guide
[x] "Documents" nav element (for users not logged in) should instead say "ATBDs"

From the conversation today, one option would be to use the sidebar table of contents in the ATBD view page. (screenshot below)

According to Daniel, this might be quite a bit of work, especially considering the User Guide is currently just a markdown file which is not conducive to this table of contents feature. We could explore other options here that are lower level of effort. If I had to prioritize the user navigation actions on this page, here would be my first guess:

Being able to navigate away from the user guide (aka go to other pages available to them)
Being able to easily find/navigate to a specific section in the user guide

@deborahUAH can you take a look at this ticket and my comment here and provide any feedback?

Once users have found their information, users are able to quickly navigate to somewhere else in the app

This is vague. What is the expectation? Should there be links from the help page to the relevant part of the app, ie. in section 2.2.1 Contacts Page, there would be a link to the contacts page?

@oliverroick I more had in mind the top nav elements. So if somebody is midway through the user guide, finds the info they need, it should be easy for them to navigate to another page. I could see how the solution you suggested would solve this need as well, though.
I think in general we are looking for the least cost, most widely used solution. so making the top nav sticky might solve more use cases, in my mind. However, if we implement an accordion type functionality or table of contents sidebar, maybe the top nav doesn't need to be sticky.

@oliverroick the text in the document linked above is not quite ready, so we can hold off on that for now. we can update the text later on using the markdown file.

remaining work in #530


Detect color-scheme onload

Hi @kepano, thanks for this plugin!
I noticed that the theme doesn't update if the OS color scheme changes while obsidian is closed. This PR fixes that by checking the scheme when obsidian loads.

+1


On demo page, clicking Result button says swal is not defined

Expected Behavior
I see the cropped image
Actual Behavior
Nothing happens in the window, and the console says "ReferenceError: swal is not defined"
Steps to Reproduce the Problem

Click on a "Result" button on https://foliotek.github.io/Croppie/

Example Link
Please recreate your issue using JSbin, JSFiddle, or Codepen.

Link: https://foliotek.github.io/Croppie/

Specifications

Browser: Firefox (on Ubuntu 16.04)
Version: 67.0

seems bower_components were deleted from gh-pages in ab4c4361194c77d4b515efff9df96a94268b6d00

Same problem on August 2019.
This is not serious, it still not fixed.

Almost a year later, issue still not fixed.

Sorry - there was an issue deploying the last release to github pages. Fixed now.


Architecture diagram

Ticket to track completion of an architecture diagram.

Diagrams uploaded here https://drive.google.com/drive/u/0/folders/1q50cwOEFraYMr4bcBhlTUWEm_JWDSz-K


[REVIEW] hilalsidhic

GitHub Profile Link
https://github.com/hilalsidhic

Hey @hilalsidhic !
Thankyou for sharing your profile with us, I liked it a lot but it needs some improvements I had opened a pull request with some minor changes, please consider that

Hi there 👋 I have a few suggestions and improvements for your profile
📝 Suggestions

[ ] This svg has know issues on safari, I would suggest removing it

[ ] The left section of your profile is empty, you can add much more there
[ ] Unsure why 2 horizontal rules

[ ] You can make these widgets come side by side:

🚀 Appreciation

[x] The banner looks good and the profile is concise!

Reviewed on live stream...
Looks good, some thoughts:

ideally use a profile picture of yourself
maybe the widgets could be side by side to make better use of the space
contributing graph is very commit heavy, I suggest trying to also do issues, pull requests and reviews


sybilhunter command not find

I am new to go, can you help me with this?
$ go get -v github.com/NullHypothesis/sybilhunter
git.torproject.org/user/phw/zoossh.git (download)
github.com/DataWraith/vptree (download)
github.com/NullHypothesis/mlgo (download)
github.com/arbovm/levenshtein (download)
github.com/mcgrew/gostats (download)
github.com/NullHypothesis/mlgo
github.com/arbovm/levenshtein
github.com/DataWraith/vptree
github.com/NullHypothesis/mlgo/cluster
github.com/mcgrew/gostats
git.torproject.org/user/phw/zoossh.git
github.com/NullHypothesis/sybilhunter

$ sybilhunter
sybilhunter: command not found

It seems like I need to build first...


Update: Add Navi Request Preview Component

Description
We want to work towards the new design for Navi's report builder. The first step is implementing the request preview. This will just add the component to Navi, but not actually instantiate it anywhere.
Proposed Changes

Add navi-request-preview component
Add navi-request-column-config/base component to use as a base for upcoming column configs

Screenshots

License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

small things 👍
do we want to actually render it if enableRequestPreview is turned on?

@daniellevinson The plan for this PR was just to add the component to the addon. There will be a future PR when the rest of the request-preview functionality is included to actually expose it in the report view.


tofi: 0.5.0 -> 0.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/philj56/tofi/releases.
meta.description for tofi is: "Tiny dynamic menu for Wayland"
meta.homepage for tofi is: "https://github.com/philj56/tofi"
meta.changelog for tofi is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.0 in filename of file in /nix/store/r6dc3v95wnaf5lflfwnchyz11lpjklxs-tofi-0.6.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tofi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r6dc3v95wnaf5lflfwnchyz11lpjklxs-tofi-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tofi https://github.com/r-ryantm/nixpkgs/archive/cb58762715d2551dd21faca4ec4447f67421458c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r6dc3v95wnaf5lflfwnchyz11lpjklxs-tofi-0.6.0
ls -la /nix/store/r6dc3v95wnaf5lflfwnchyz11lpjklxs-tofi-0.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tofi

Maintainer pings
cc @fbergroth for testing.

Result of nixpkgs-review pr 191057 run on x86_64-linux 1

1 package built:

tofi


Syncing of extensions not working in portable mode

🐛 When installing VS Code in portable mode with local data directory, extensions are not (fully) synced
VS Code can be installed in portable mode (download ZIP file and extract in some random directory). If you create a folder with the name "data" in the main directory, VS Code will save all settings and extensions into this subdirectory (see https://code.visualstudio.com/docs/editor/portable).
With this mode, Sync is ignoring most of the extensions. Out of five installed extensions, only one was synced to the file extensions.json in GIST. Even code-settings-sync itself is not synced as extension. As a result, downloading the settings on another installation only installs the one synced extension.
Doing the same setup with a regular installation works.
🌴 Visual Studio Code Version : 1.30.2
🌴 Code Settings Sync Version : 3.2.4
🌴 Standard or Insiders : Standard
🌴 OSS or Portable : Portable
🌴 Operating System : Win 10
🌴 Occurs On: Upload
🌴 Proxy Enabled: No
📰 To Reproduce
Steps to reproduce the behavior:

Install VS Code Portable
Create 'data' directory in VS Code folder
Start VS Code, download code-settings-sync
Install some extensions (e.g. prettier, vetur, they did not work for me)
Upload settings
Check gist (extensions.json) or download settings on another machines: extensions will be missing

💪 Expected behavior
All extensions uploaded

can you show an image of the following:

data folder
Image of the console log from the vscode, to see any exception being logged over there.

Same problem here:
The only "Error" in the console was:

And the portable folder has:

Its fixed with new version v3.2.6
let me know in case of issue.

I just got updated to Version: 3.2.6. of Settings Sync on my portable vscode instance.
I uploaded my settings and now the extensions array is completely empty. Meanwhile I have about 30 extensions installed.
Before the 3.2.6 update extensions were only noted partly, as described by OP.

@LuisUrrutia can you look into this.
Feel free to send PR, i will release in new version ( if there is still something missing )

@KolyaKorruptis can you open the developer tools of VSCode

Try to upload again and share the console log?

@KolyaKorruptis cool! Now I know what the problem is. Are you sure that this extension worked before in the same VSCode portable and in the same OS?

Yes, I'm sure. It worked partially, as OP describes in the first post.

@shanalikhan can u re-open this issue and assign it to me?

It's reopened
U can send PR

I have the same issue as @KolyaKorruptis
My extensions now are an empty array and autodownloading the settings from other computer removed all extensions

@gsabater windows, right?

@LuisUrrutia yes, on both machines

Same problem here, everything working fine except extensions.json file always empty.
I'm on Windows 10, Visual Studio Code 1.31.1
It was working fine some weeks ago.

same problem with the empty extensions.json ....

Same problem here

Same issue on my PC.
environment:
Windows 10 Pro 64bit
Settings Sync v3.2.6
Visual Studio Code v1.31.1 (User Installer)
settings:
	"sync.autoDownload": true,
	"sync.autoUpload": true,
	"sync.gist": "xxx",
	"sync.quietSync": true,

It should be fixed in new version v3.2.7.
Let me know if there is any problem.

@shanalikhan Looking good.
All active extensions were uploaded. One inactivated extension wasn't. I guess that's expected behaviour.

It looks like no problem. Thanks!


Pilot statusz pages to reflect multi-cluster status

Design doc: https://goo.gl/3x4Ade
POC:
https://github.com/gnirodi/pilot/blob/hybrid-multi-cluster/bridge/mesh/statusz.go
https://github.com/gnirodi/pilot/tree/hybrid-multi-cluster/bridge/data/templates
Basic requirements:

Http handler for statuz, related CSS etc.
Hooks to provide sections for various modules of code

Gautam - can you tell me more about the plan here or pointers to any material on what you might be thinking about for design.  We have one person that has been exploring UI improvements especially related to Pilot debug-ability.   It is all pretty preliminary so we couldn't offer a concrete proposal,  but if there is already a solid plan in this direction maybe it's an area we could contribute to.

@john-a-joyce  I've updated  https://goo.gl/3x4Ade with my thoughts and references to POC code for you to take a look at. Please note that this design doc is just my riffing atm. I'd love to get your thoughts and make it more robust.


Can you add a LICENSE file?

Hi, I'm planning to submit a pull request to Chocolatey's ag package that uses your Windows builds. I noticed that Chocolatey packages require linking to a LICENSE file. Can you add a LICENSE file to this repository?
Thank you.

Added.


Add Ekleog to the reviewer team

https://github.com/timokau/marvin-mk2/issues/34#issuecomment-732306385

You're welcome, I'm happy it helped :)

Hmm it's weird, I haven't seen any notification from marvin yet, despite the fact that the latest PR that involves me was more than a week ago.
Was marvin re-deployed since this change, or is it possible that it's currently broken? Or is it possible that there are just not enough PRs that are marvin-enabled? (in which case I guess it'd mean that it may be time to consider auto-enabling it for eg. 1% of all new incoming PRs, if it currently has such a high success rate in practice despite whatever shortcomings it may have left)

Oh, or another idea: if the rate of incoming PRs is just lower than the rate of PR acceptance of people above me in the list, maybe it'd make sense to just shuffle the list of reviewers before trying to find a reviewer to assign the PR to? (not sure whether it's worth filing an issue for such an improvement yet, as it may be completely unrelated to the point at hand)

Hmm it's weird, I haven't seen any notification from marvin yet, despite the fact that the latest PR that involves me was more than a week ago.

Marvin looks for PRs which were updated within the time frame, not just those that were opened. So it is something like this query, which would be 3 PRs.

Was marvin re-deployed since this change, or is it possible that it's currently broken?

Yes, it was deployed: https://github.com/nix-community/infra/commit/7b07e215121a67277240f7aaaf4973d3c2ef6c2b

Or is it possible that there are just not enough PRs that are marvin-enabled? (in which case I guess it'd mean that it may be time to consider auto-enabling it for eg. 1% of all new incoming PRs, if it currently has such a high success rate in practice despite whatever shortcomings it may have left)

That's it :) It used to hover around ~10-20 needs_reviewer PRs, but right now its 0. It assigned reviewers to two PRs yesterday, otherwise the queue is currently empty. Here are all the marvin-managed PRs.
As I said, this is unusual though. I think its probably in part because of some drive-by reviews triggered by this, and in part due to SuperSandro2000's current attack on the backlog in general :smile:

Oh, or another idea: if the rate of incoming PRs is just lower than the rate of PR acceptance of people above me in the list, maybe it'd make sense to just shuffle the list of reviewers before trying to find a reviewer to assign the PR to?

It already works that way: https://github.com/timokau/marvin-mk2/blob/34c1b7fa98dd48044c4819f84f5fc98617a8c49b/marvin/team.py#L155
For example
Nov 30 11:29:22 marvin-mk2: Selecting reviewer from candidates: ['turion', 'symphorien', 'bennyandresen', 'kisik21', 'timokau', 'fgaz', 'Ekleog', 'glittershark', 'kevincox']
Nov 30 11:29:22 marvin-mk2: Testing timokau
Nov 30 11:29:25 marvin-mk2: Limit (1/1d) exceeded until 2020-12-01 10:15:04+00:00.
Nov 30 11:29:25 marvin-mk2: Testing kevincox
Nov 30 11:29:29 marvin-mk2: Limit (7/7d) exceeded until 2020-12-02 07:15:29+00:00.
Nov 30 11:29:29 marvin-mk2: Testing bennyandresen
Nov 30 11:29:32 marvin-mk2: Requesting review from bennyandresen for #82584.

Got it, thank you! It's right that the message you linked is also the one that made me discover marvin :)
Just to check I understood correctly what you meant, when you linked my “involves” as seen by marvin, you forgot is:pr which would result in 1 PR… am I understanding correctly? Or does marvin also count issues as counting against the rate limit?

Or does marvin also count issues as counting against the rate limit?

It does, although you could argue that it shouldn't. It's kind of in line with the intention of estimating the total "nixpkgs notification load", but it is probably not the behavior you would intuitively expect. You can see the exact query here: https://github.com/timokau/marvin-mk2/blob/34c1b7fa98dd48044c4819f84f5fc98617a8c49b/marvin/team.py#L56

Got it, thank you! I've just opened #102 with ideas for potential improvements, though I don't think it's any kind of emergency and putting the current marvin algorithm in production is much more important :)

Thanks, always nice to hear encouragement :)


glide install seems to require private repository to be downloaded.

$ glide install
[WARN]	Lock file may be out of date. Hash check of YAML failed. You may need to run 'update'
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Found desired version locally github.com/Azure/go-ansiterm 388960b655244e76e24c75f48631564eaefade62!
[INFO]	--> Found desired version locally github.com/btcsuite/btcd 7de7bddba9d9a8b0b7490931e346e8f10d0bdb7f!

...

[INFO]	--> Found desired version locally gopkg.in/tylerb/graceful.v1 ecde8c8f16df93a994dda8936c8f60f0c26c28ab!
[INFO]	--> Found desired version locally gopkg.in/yaml.v2 a83829b6f1293c91addabc89d0571c246397bbf4!
[INFO]	--> Fetching github.com/eris-ltd/common
[INFO]	--> Fetching github.com/eris-ltd/eris-logger
Username for 'https://github.com': Username for 'https://github.com':

The packages github.com/eris-ltd/common and github.com/eris-ltd/eris-logger are not listed among your public repositories, so I suspect you haven't made them public.

rather they have been deprecated somewhat prematurely; we'll revive them

@emanuelpalm can you try again?  We have resurrected the dead.  Please re-open if it has not solved your problem! Hope this helps (thanks to @silasdavis for the dark magic)

It works! Thank you for being quick about it!


Updates to multi-lang Java quickstart

Updates the supported version to be consistent for all runners.
Adds instructions for running with the portable DirectRunner.
This fixes #22916

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @bvolpato
cc: @pcoet

@chamikaramj Thanks! New details are looking good, I'll give it a new run and keep you posted.

Run Whitespace PreCommit

Run Whitespace PreCommit


URGENT fix needed - unable edit location info

Issue: Unable to manually edit the location information. I was trying to enter information of someone's parents and not able to edit.
Environment: Firefox on mac os - not tested on other browsers.

You can edit the Location in top. This is auto fetched GPS location.

Yeah, this is an a show stopper. On the map were getting other countries as the source.
If the form is edited we need to calculate the gps location from the address

Maybe we should hide the GPS location boxes as it might cause confusion.

Yeah that seems nice there is no need to display that.

@sidharthv96 Rather a better idea would be if we just remove the focus from the form field and add a disabled cursor over it. This way it will be seen to the user but at the same time do not give appearance to be editable.

Steps to reproduce:
scenario 1:

Allow browser to Access GPU location

The location details are auto filled

Unable to edit to the location

This is the case in Chrome and FF
Scenario2:

Don't allow browser to access location
The location details are hidden

Please refer #127 as well.

People are using to report others, so please take care of this in priority. Thanks volunteers.

#122 already hides the input field for Geo co-ordinates when user is requesting for others.
Should we add the ability to fill in location data manually?

I have solved the issue but facing problem creating the PR. Please someone help me with this  @bobinson

@littlestar642: What's the issue you are facing?

Made a PR. Please review.

@littlestar642 I have commented in your issue. For others, If you make it editable, please add the required location format for GPS in the label, and also validate it.

@naveenpf the popup map with draggable marker is a good for this as others usually use this..

@mevinbabuc How convenient is this for mobile phones users?

First step for fix is to get a basic text area working with editable option. Other things like exact GPS co-ordinates is not something people in emergency can do.

Please rebase everyone

Which pull request we should take ?

@littlestar642 - please check this.

Someone look into both #266 and #286. One of these should be selected based on usability and after testing and merged sooner.

@alokbabu works great on mobile!


[T3A5][T13-A1] Aloisius Stephen

Add Formatter class, an extraction of the responsibility of TextUi class in formatting text for display

@aloisiusStephen why did you close this yourself?
in any case, I have added a few comments, please take a look.

@okkhoy
I understood your instruction during the tutorial was to close the PR if i were to re-attempt this activity
So I did another PR for this Activity [T3A5] under PR #557
I apologize if i misunderstood the instruction

ah! i did not remember to whom i said that :-P
thanks for clarifying.
-Akshay
On Fri, Sep 2, 2016 at 10:37 AM, aloisiusStephen<EMAIL_ADDRESS>wrote:

@okkhoy https://github.com/okkhoy
I understood your instruction during the tutorial was to close the PR if i
were to re-attempt this activity
So I did another PR for this Activity [T3A5] under PR #557
https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/557
I apologize if i misunderstood the instruction
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/453#issuecomment-244268524,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-eBh_SmRAygQAOTq5VwkEX0-HrTs9hks5ql4vngaJpZM4Jxpbj
.


CLI should default to showing help when zero args are provided

Background & motivation
When you're exploring the cli, you often run into a relatively unhelpful error:
% kurtosis service shell
Error:  accepts between 2 and 2 arg(s), received 0

You then run it again with the -h flag to see what it wants from you.
Desired behaviour
If the command expects args that aren't given, show the relevant help, i.e.:
% kurtosis service shell
Starts a shell on the specified service

Usage:
  kurtosis service shell [flags] enclave service

Flags:
  -h, --help   help for shell

Global Flags:
      --cli-log-level string   Sets the level that the CLI will log at (panic|fatal|error|warning|info|debug|trace) (default "info")

(maybe include the error note too)
How important is this to you?
Nice to have; this feature would make using Kurtosis more enjoyable.
What area of the product does this pertain to?
CLI: the Command Line Interface

Re. the "show help when no args are provided" - Galen hit a pain point with this where some commands do this (e.g. kurtosis, kurtosis enclave) but not all (e.g. kurtosis service shell). I'm actually wary of simply enabling "no args == help", because it encourages people to just run the command, and it might actually accept no arguments and do something they don't expect. I'd prefer that we disable all instances of "no args == help", in favor of explicit "pass -h to see help".
That said, I think the spirit of this ticket is actually subtly different: when the user doesn't provide the right number of args, we should throw an error (like we need to) but ALSO show the possible args. This I agree with; it's a convenience in case you mess up the arguments rather than "the default for checking helptext is pass no args".

@omar711, adding to what Kevin mentioned above: what do you think of the below behavior?
% kurtosis service shell
Error:  this command requires 2 arguments: the $ENCLAVE_IDENTIFIER
followed by the $SERVICE_NAME. Read more about this command [here](link-to-docs)

@leeederek yeah that would be cool, although I don't think we need to interpret user input too much.  Simply noting they've not given the correct args and showing some help on usage, would be plenty.
Examples:
% mv 1
usage: mv [-f | -i | -n] [-hv] source target
       mv [-f | -i | -n] [-v] source ... directory

Or docker, which shows a succint usage in case of missing args, and a full usage when --help is passed in:
?1 kurtosis-portal % docker exec
"docker exec" requires at least 2 arguments.
See 'docker exec --help'.

Usage:  docker exec [OPTIONS] CONTAINER COMMAND [ARG...]

Execute a command in a running container
?1 kurtosis-portal % docker exec --help

Usage:  docker exec [OPTIONS] CONTAINER COMMAND [ARG...]

Execute a command in a running container

Aliases:
  docker container exec, docker exec

Options:
  -d, --detach               Detached mode: run command in the background
      --detach-keys string   Override the key sequence for detaching a container
  -e, --env list             Set environment variables
      --env-file list        Read in a file of environment variables
  -i, --interactive          Keep STDIN open even if not attached
      --privileged           Give extended privileges to the command
  -t, --tty                  Allocate a pseudo-TTY
  -u, --user string          Username or UID (format: "<name|uid>[:<group|gid>]")
  -w, --workdir string       Working directory inside the container

I just hit this again personally with:
$ kurtosis package init
Error:  accepts between 1 and 1 arg(s), received 0

Found out that this is coming from Cobra itself, the library we use for command-line args: https://github.com/spf13/cobra/blob/5c962a221e70fd6b12296e5d7075f28b422f98b2/args.go#L107

The work for this ticket is probably to:

Disable Cobra's vague args-handling
Use our own args-handling, and probably print the helptext when missing a required arg

There's a PR at https://github.com/kurtosis-tech/kurtosis/pull/369/files#diff-df91c4aa5f0e159b2964285857f6b5378b210ebef569c10451a54bd843a50e7eL87 which sets SilenceUsage, that may be related.  Looks like we did it to supress excess usage though so might need to find the right sweet spot.  Here's the cobra flag too https://github.com/spf13/cobra/blob/5c962a221e70fd6b12296e5d7075f28b422f98b2/command.go#L231


Switch Capacitor Filter has routing errors

One of our driving testcases is completing with routing failures. We should fix these.
To duplicate, try:
CI_LEVEL=checkin pytest -vv --runnightly -k switched_capacitor_filter -- tests/integration

Resolved by checkins before #941
#941 makes sure CI checks that it continues two work.


the link is active which is present only at the last slide if only one slide is shown

the link is active which is present only at the last slide if only one slide is shown.
at the same time, the text and images are switched correctly
in the html code of the page, the links are shown correctly, but when you click on the link, the address of the last slide is activated

qq1
 const settings = {     autoplay: true,     autoplaySpeed: 5000,     fade: true,     dots: true,     arrows: false,     speed: 500,     infinite: true,     slidesToShow: Math.min(1, banners.length),     slidesToScroll: 1,     pauseOnHover: false,     pauseOnFocus: false,     appendDots,     customPaging,   };  <Slider {...settings} ref={ref}>           {banners.map((banner) => (

                     {banner.name}

           ))}         </Slider>

i solved it


Wild idea: use prototypes to structurally share non modified properties

i have a immature idea
if we have a large obj , such as
var obj = {
a1:1,
a2:2,
a3:3,
...
a1000000:1000000
}

now, immer looks like it's going to copy the object all key again, like{...obj}, it's will slow
how about just like this:
var objProto = {_proto_:obj}
then, we can access property like objProto.a1,
and we can modify property like objProto.a1 = 2,( and we Not modify origin data obj )
Originally posted by @zhangenming in https://github.com/immerjs/immer/issues/462#issuecomment-554613735

Thoughts: might safe time and space!
Might mess up iteration since a lot of properties won't be "own".
Could be an experimental opt in option?

I tried something like that before. At first it may seem to work but you eventually end up with a very nested prototype chain:
obj.__proto__.__proto__.__proto__
This means a few things:

Property lookup becomes slow
No garbage collection since the new object will have a reference to its old version in prototype
Only "safe" as long as the object in __proto__ is frozen

An alternative way could be to force objects with > 32 property keys to become "Fast Properties" instead of letting them fall to "Slow/Dictionary based". Check here: https://github.com/v8/v8/blob/6.0.122/test/mjsunit/fast-prototype.js#L48-L63
And a lib that already does this: https://github.com/sindresorhus/to-fast-properties/blob/master/index.js
The basic idea is that, every object that is in prototype is optimized  as "Fast Properties" once ICs (Inline Caches) find them. Thus, this line that doesn't seem to make any sense but in fact just makes ICs find them:
  function ic() { return typeof receiver.foo; }
  ic();
  ic();

So, maybe as a flag, option, or something, Immer could just do this:
DoProtoMagic(obj, objKeys.length > 32)

Why 32? Last time I checked, this is the max number of allocated fast properties an object can have before falling back to dictionary based. In any case, there is no much or not at all performance gain with these small objects but we could try if there is any gain in .. idk, 500 - 5000 props? 🙈
Ref: https://v8.dev/blog/fast-properties

Another problem: can't use this trick is there are keys being deleted (unless those are still created, but undefined and non-enumerable, but still that is not not entirely the same).


[9.x] Split Conditionable into package

This is a potential solution to #38389.
Realistically, anything that illuminate/collections depends on (that's also used elsewhere in the framework) is going to bump into this same issue. It's the same reason the Macroable trait had to be moved into its own package.
The other approach would be to just move Conditionable into the Collections package, but that just feels wrong to me. In the end, I decided to PR this as a solution. If you decide it's not worth breaking out another package, I'll happily re-submit the other solution.

Where does it end though? The HigherOrderCollectionProxy also doesn't really have anything to do with collections. It should really be called HigherOrderProxy, and accept any generic type.
Wouldn't it make more sense to have some catch-all package, like Traits or Helpers or whatnot, where we can store these lower level things? So Macroable and Conditionable and HigherOrderProxy and HigherOrderWhenProxy can all live in the same package together?

illuminate/utils?

I like that. But at what point are  we just re-creating illuminate/support?
Would a better approach be to extract some things out of that package, and then make the collections package depend on it again?
It feels like illuminate/support is exactly the right place for this kind of code.

I firmly believe illuminate/support should be a dependency for other packages. It's okay for illuminate/collection to require it.

It's okay for illuminate/collection to require it.

The entire point of illuminate/collection was that it didn't depend on illuminate/support.
Honestly I'm beginning to think splitting illuminate/support was a mistake and we should just move everything back into one component.

At this point, for a code to have their own package, it should comply with the following:

Does not depend on illuminate/support functionality.
The dependent functionality can be replicated by just copy-pasting one or two methods.

For the case of Conditionable, if you replicate on Collection without the trait, it will break the trait check for conditions:
if (in_array(Conditionable::class, class_uses_recursive($object)) {
    $object->when(true, ...);
}

In that case, you're bound to create a Conditionable contract. Seems very over-engineered to me.
Again, if a single part of the code requires illuminate/support to work, is no sin, as long is big enough (like Collections). Conditionable is merely a trait, not a class comprised of enough code that can't fit one screen. To me, illuminate/support is like a global toolbox for small utilities that can be dropped-in my project.

@inxilpro can you resolve the conflicts on this?

@taylorotwell what are your thoughts on this https://github.com/laravel/framework/pull/38457#issuecomment-902295865?
I would really like to eventually rename HigherOrderCollectionProxy to HigherOrderProxy. I've had many generic use-cases for it in the past.

I've resolved the conflicts. I think there are two viable paths:

Bring everything back into illuminate/support
Commit to "support" functionality getting split into smaller chunks over time. I don't think there's anything wrong with this, and it could be nice to have the option to just install illuminate/proxies and illuminate/macroable if that's the only "support" functionality that you need in your app.

After thinking about it a bit longer, it feels like moving away from a catch-all "support" package into more tightly scoped feature packages is a good thing. In fact, I think that in relationship to @JosephSilber's comment, it makes a lot of sense to introduce an illuminate/proxies package, too, that holds generic versions of various proxy objects (something like, HigherOrderMethodProxy, HigherOrderObjectProxy, HigherOrderEnumerableProxy, and HigherOrderConditionableProxy).

Yeah I don't see what the big controversy is with splitting this out into a package.

Thanks @inxilpro