Feature Request on pixracer Dshot and OSD

Hi I'm Lance from Yuneec:
Feature Request on pixracer
the Racer Must support the new ESC protocol multishot, Dshot600 and Dshot1200 ( BLheli 32
firmware)
If you can support OSD like how beta flight does ( rssi and voltage is very important for us )
Able to config through OSD is a very nice feature, and able to connect smartaudio from TBS unify
pro to change channel and output also come really handy.
Issues :
250 size race drone is totally out of date , Most of the Race size are 210 ( full size ) , 140 ( mini) , 100 ( micro)
( Accord to what I see in betaflight ) gyro update in up to 32KHz, depends on what esc you can support it 8kHz with blhelis and 32kHz with blheli32

Could you recommend an ESC to use for development?
Faster gyro updates have been discussed in detail and planned, but there's no firm timeline for implementation.
It probably makes sense to add more generic quad airframe configurations (different frame sizes) even if the actual configuration is minimal.
@MaEtUgR @rolandash @nkhoit FYI

@LanceFung have you configured PX4 on racers in those sizes (210, 140, 100, etc).
If so let's look at safe default parameters for each size class and create airframes.

As for the OSD it would be helpful to create another issue to document exactly what's needed, but a developer is going to need that hardware.

Currently, most needed :
For ESC Blhelis Dshot 600 & multishot  protocol: FlyColor Raptor BLS Pro BLHeli-S 30A ESC (2-4S DShot)
In the Future there everyone will move to
For ESC Blheli32 Dshot 1200/Proshot 1000 :
https://www.undergroundfpv.com/collections/escs/products/32bit-6s-30a-esc

I have put one on the 210 not 140  yet. ( but it could be a good side project :) )  did not tune the PID perfect yet.
Current mounting pixracer 30.5mm X 30.5mm hole with only fit. size 210-140.
size 110 will need to redesign the board.

@LanceFung Good to hear from you again, interesting requests for racing with PX4!
I personally support making PX4 support racing because there is big potential. It could get the racing FC software which has all the extra features of a "smart drone".
Here is the test build with the Pixracer board I did for this: https://docs.px4.io/en/frames_multicopter/qav_r_5_kiss_esc_racer.html
My point of view:

Dshot would be useful, I use it on my racer but I'm not 100% sure how much difference it makes to OneShot142. Would need to test the difference (with KISS FC you can switch very easily)
For OSD I have no idea what it takes because I never used it before. I use FrSky telemetry to my Taranis remote and the taranis speaking to me on switch flip which is supported by PX4: https://docs.px4.io/en/peripherals/frsky_telemetry.html
Still most racers I still see have 6 inch props -> 250mm frame, 5 inch props -> ~210mm or 4 inch props -> ~180mm but I'm not sure what you're refering to with the very small quads. I think it will not happen very soon that the pixracer like it is right now will be produced in a much smaller size simply because there is a lot of hardware on that board to support all the features.
The gyro update rate was in discussion a lot before. One thing is clear: we need a faster rate control loop (at least 1kHz) but how fast is effectively needed is up for discussion. 32kHz control loop sounds like total overkill to me but @priseborough told us before that reading out the sensor faster and filtering in software can allow to get rid of some aliasing effect caused by high frequency vibrations and I see potential there. Maybe we can even learn something from betaflight how to do this in practice...
About the ESCs selection I agree BLHeli with DShot support is likely always the better choice. I personally use KISS ESCs which also support DShot until now but I'm keen to switch because they are closed source and pretty impractical to solder like you can see in my build tutorial linked above. Thanks for the links.

@MaEtUgR I don't have much to add to what's already been said, except for:

Dshot would be useful, I use it on my racer but I'm not 100% sure how much difference it makes to OneShot142. Would need to test the difference (with KISS FC you can switch very easily)

Dshot Is definitely the way to go. Lower latency, digital communication, and as far as I know there are still some unused bits in the protocol that could be used for motor feedback in the future (RPM and whatnot).

For OSD I have no idea what it takes because I never used it before. I use FrSky telemetry to my Taranis remote and the taranis speaking to me on switch flip which is supported by PX4: https://docs.px4.io/en/peripherals/frsky_telemetry.html

In Betaflight you can open the OSD menu and navigate it with specific control stick combinations. Similar how you can configure arming and disarming with control stick combinations in cleanflight/betaflight/px4. So I guess this would be easy to implement. As for the OSD functionality itself, I am not in the loop of what px4 currently is capable of.

Still most racers I still see have 6 inch props -> 250mm frame, 5 inch props -> ~210mm or 4 inch props -> ~180mm but I'm not sure what you're refering to with the very small quads. I think it will not happen very soon that the pixracer like it is right now will be produced in a much smaller size simply because there is a lot of hardware on that board to support all the features.

Can confirm. Most of the pilots in the last Swiss Drone Nationals a few months ago were flying 5 and 6 inch props. This has not changed at all compared to 2016.

The gyro update rate was in discussion a lot before. One thing is clear: we need a faster rate control loop (at least 1kHz) but how fast is effectively needed is up for discussion. 32kHz control loop sounds like total overkill to me but @priseborough told us before that reading out the sensor faster and filtering in software can allow to get rid of some aliasing effect caused by high frequency vibrations and I see potential there. Maybe we can even learn something from betaflight how to do this in practice...

Many pilots will tell you they feel the quad is more responsive with higher rates. True or not, it will be hard to convince them, that your 1khz loop performs the same, even if it does...

Here's a well known fpv guy doing a blind test dshot vs oneshot and he can't tell the difference: https://www.youtube.com/watch?v=0hDi-NRZq9Y I know it's not academic and people will look for the buzz word anyways but it's probably not the most important feature for end user performance. In fact according to him the ESCs you use or rather the Firmware version for him because he uses KISS ESCs makes the real noticable difference.

The advantages of Dshot (as described by Felix on rcgroups) compared to the most used analog signals like PWM as also oneshot125 or 42 are:

no signal jitter.. if the FC sends 1375 the ESC will receive 1375.

high resolution (2048steps).

no oscillator drift (nomore calibrateing ESC's).

more robust against spikes.

safer as every singnal has a CRC (cyclic redundancy check).

possibility to set motor spin direction via SW.

BLheli and KISS ESC are supporting this "new" protocol already.
-> https://www.rcgroups.com/forums/showthread.php?t=2756129
Since KISS ESC have some nice features and are available with high Amp reading they are of interest for bigger multikopter as well.

I did some more research regarding this topic and honestly, I am not too convinced with DSHOT. Here's why: You still need one UART Tx per ESC on the flight controller. Some boards don't even have that, others have four of these and you could not fly in configurations with more than four motors. I presume DSHOT had to be implemented like that if they wanted to remain backwards-compatible to PWM and all other analogue protocols, which obviously need one channel per ESC. On top of that I am not sure how DSHOT envisions motor feedback to be incorporated. As things are standing now, each motor would again require its own UART channel on the flight controller, resulting in 4x2 UART channels for four motors. DSHOT is in my eyes only the first step towards digital motor control and still a compromise.
What might make much more sense, is to have all ESCs connected on the same UART port of the flight controller. This means, that ESC commands for all ESCs are sent to every ESC. Knowing its own id or number, every ESC knows what command to listen to and which ones to ignore. Motor feedback needs a bit more caution, as only one ESC should be sending feedback at any time. Otherwise there would be cross-talk. Some ESC protocols with proprietary firmware, for instance the Qualcomm ESC work exactly that way, so it's definitely possible.
I believe at one point we (the whole flying community, not just px4 community) will have to make a move and use a more efficient ESC protocol that is not backwards-compatible. What would be really nice is to see open source ESC firmware as part of px4, including a new and open digital protocol. What do you guys think?
By the way, we do already have a driver in px4 for the Intel Aero that uses a digital protocol: https://github.com/PX4/Firmware/tree/master/src/drivers/tap_esc
But as far as I know, the ESC firmware of the Aero is not open-source, not sure if there even exist binaries for the public. Probably not.

@potaito nice write-up! I'm not sure if you already know, but something like you describe already exists and is even integrated to PX4: Sapog ESC's which use UAVCAN (a bus which is by design better suited to attach multiple devices): https://github.com/PX4/sapog. There's also open reference HW: https://github.com/PX4/Hardware/tree/master/sapog_reference_hardware. I'm not sure if it's THE solution, but it's definitely worth looking into.

@bkueng No I have not seen this before, thanks! Looks promising..

@bkueng thank you for pointing that out. But for many users in the hobby domain UAVCAN is no issue because of the price. 79$ of a Sapog ESC compared to a 20$ BL_Heli or 25$ KISS ESC makes a difference.
I fully agree that UAVCAN is the better choice for (commercial) multiple ESC UAV designs. But leaving out the nice developments of the hobby market i disagree. From a user experience the simple advantage of no need to do ESC calibration makes a difference.
I have seen many fails of users simply not doing ESC calibration correct. With Dshot such kind of issue can be avoided. And not only for racers. There are a lot of ESC supporting DSHOT that are capable of 6S and >30A current.

Sounds like we need to work harder on a low cost UAVCAN option.

@LorenzMeier i guess so. Or at least the UAV CAN enabled ESC's need to become cheaper. Whatever comes first ;)

Let's go back to the original topic of @LanceFung:
We do support all of the critical interfaces already - so rather than ticking arbitrary boxes it would be good to get to real measurements. That means I'd love to see sensor-to-output latency specs that are relevant and alike optimisations.
What is the best current racing ESC out there?

Hi,
is there any update on this?
I can provide full development unit for this task.
https://www.uvify.com/draco-drone/
The drone we made is fully compatible with PX4 now.

The adupilot folks are making progress on dshot --> https://github.com/ArduPilot/ardupilot/issues/5300 When will PX4 follow?

Independent of the actual merit of DShot I would be interested to push for top-of-the-line racing performance and I've pinged Hyon via email to arrange hardware.

Dshot is now implemented on the first boards.

Cool  :-) , however besides  Dshot there was also the request for "smartaudio from TBS unify
pro to change channel and output also come really handy.....". Was there any progress on this topic?

Update: Dshot is now supported with #12854


Block-level settings not showing - duplicate nonce warning

Block-level Coil Monetization settings not showing. Using a default theme with correct CSS selectors. Disabled all other plugins. The only console message was a warning about a duplicate nonce.
Email with additional details attached to Accelo ticket #1270.

This is expected behaviour i think.
The block level configuration setting show only when the document level settings are set to 'Split content'. Which makes sense no?

@pragmatic-web David, thoughts on this?

Hi @melissahenderson @praghavaji sorry for the slow response. Confirmed - this behaviour is as expected.
@praghavaji might be worth adding this to the QA test plan to ensure it's captured?

Apologies again for the delay here. I've not been receiving notifications from Github nor Zenhub. Investigating that presently.
Ok, I'll get this added to the test plan and move this ticket to done.
Thanks!


Popular Post by Location

Description
Download / Get the top Instagram media from the Location
Fixed #(169)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added screenshots(if any) that prove my fix is effective or that my feature works

Great. Wonderful bro. Well done.

Thanks Sir


RISC-V: schedule more IO

This PR gives a noticeable flashing speedup with an ESP32-C6 and espusbjtag

Nice :) What's the speedup in percent? :)

It depends on a lot of factors. I'm seeing 12KiB/s -> 15-16 so let's say 20%, but that's only while the download is bottlenecked on the JTAG transfer.


Add support for multiple target addresses in CloudFlare provider

This is an attempt to fix #887.
I took a bit of a lazy route to implement this, instead of trying to manage equivalence state for record updates and/or refactoring most the provider, I simply took the same solution rancher/external-dns's CloudFlare provider took, and implemented updates as a sequence of delete + create for all records matching the combination of name and type.
CloudFlare does not seem to support records with real 'sets' of targets in basic DNS - it seems to do so in the additional-cost 'load balancing' product - though this should work well in theory.

Forgot to gofmt as I assumed my IDE did it for me, it didn't - did a force-push to update this.

Fixed a test failure by changing the unit test to match the new package-internal interface.

/lgtm
/approve


Add explanation about Swagger documentation in our project

You should describe the general practices and patterns we use. The explanation should be in the Wiki. Here are some theses:

write about the main decorators
write the order of their location in the controllers
how to properly describe errors
describe endpoint structure on the web page
focus on describing fields and adding default values

Swagger prickol


Update README to include steps for deploying ELK on Swarm

https://github.com/SapInnovation/docker-elk/pull/7


Add link to download NVIDIA's preview driver

@crahrig : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update to LameDuck mode

Increase grace period to 10sec
Make default 2min
Reject config with value less than 30sec
Don't wait more than 1sec between clients if there are much
less than alloted time
Stop after last one (was still sleeping after last client was
closed)

Signed-off-by: Ivan Kozlovic<EMAIL_ADDRESS>/cc @nats-io/core

Coverage decreased (-0.08%) to 92.183% when pulling cfc5ec4d44f89a4329c4229a17cfa19826c737cc on fix_ld_mode into 7ef7fdfc23cf20c9932f3e9320a8a08d2d041647 on master.


Text converter based on set tables with the ability to act on the selected text with a shortcut

Description of the new feature / enhancement
When typing texts anywhere, and especially in chats, a person writes for a long time without looking, and then realizes that he was in capital letters or did not switch the keyboard to the other language. Then it is necessary to select the wrong text and apply the shortcut that Power Toys will provide and quickly and easily replace the text with the selected conversion.
It should have the following quick conversions:

Text to capital letters
Text to lowercase letters
Text inversion (lowercase letters in the text to uppercase and uppercase to lowercase)
Text to transliterated text
Ability to user input conversion tables that are specific to his needs (because there are many keyboard switching options)
Each of the above can be mapped to shortcuts

The implementation of the above will save billions of hours of humanity :-)
Scenario when this would be used?
In every editing control in Windows.
Supporting information
No response

I was about to suggest the same thing, I wish if some of the Dev make us an Alternative to SnipDo that is based on PowerToys and  that support add-ons or scripts that everyone can toggle, download to fit their requirements, such things are tremendous time saver and amazing productivity addition to almost every user, it would be great if it works in similar fashion to SnipDo but more robust and versatile... I can make a list of tools and contribute to the scripts later ( I wish if I have the skills and knowledge to make it myself but unfortunately I don't )
Right now PowerToys add some new features but they are slowly implanted since but with some scripting support that allows interaction with content and UI then it could be easy for many to make all sort of tiny tools that exists already but requires the installation of several freewares or visiting many websites (and having bookmark list well maintained)...
I cannot stress enough how this can be time saver, even to transform a text to a hashtag it shouldn't take more than selecting the text and having a bubble to do that by replacing spaces or eliminating them (matter of taste) and adding the # at the begging of the sentence...
Notepad++ can offer a lot of inspiration of how many tiny tools, script that can be created, but since they can be a lot then having the ability to organize them in a menu with representative icons (in same Windows 11 design) would be great.
Imagine a bubble who dynamically change if you select a text then it will show several icons to transform the text organized in groups and categories (that end users can specify themselves) ... if it is a URL then another menu would show up...
SnipDo is great in term of what it does, but it is paid, closed source and maintained by only one person so it wouldn't be many productive people would install on their workstation.


Way to run large job on server

Hi and thank you for this amazing plugin. I work at a university with some dedicated GPU nodes, but my laptop doesn't have an NVIDIA GPU. I can run small areas locally, but I was curious if you had a recommended workflow to run a large job on a remote machine.
Two ideas I had were:

A way to export the inferencing command using the current extent and model configuration as a copy-paste friendly command line command you can run on a server (you just have to change the paths to point to your data)
Run a server like https://github.com/microsoft/onnxruntime/blob/main/docs/ONNX_Runtime_Server_Usage.md and integrate a remote server option into the plugin UI so you can do remote processing

Hi,
Thanks for your feedback. Batch running on a server with a script sounds like a nice idea! Unfortunately we do not have a ready solution to share, at least for the time being, but we will consider adding it in the future. Though, if you would like to contribute I can give you guidelines how to achieve it. It shouldn't be to complicated, as we have already unit tests that process the file without QGIS UI. Let me know if you are interested!
Cheers,
Przemek

Hi @cognitiveRobot ,
could you describe how would you want to use the plugin on a server? Then the better you describe it, the easier it will be for us to manage your expectations.
My reflections:

It should be a separate CLI for processing on the server (data, models and results on the server) or simply a daemon that receives data from QGIS and transmits the results to it. The second option is possible to create using sockets, but even the best transmission option involves delays.
Do you think that creating a docker container is a good option for less advanced users?

Developing a QGIS plugin with considerations to include it in Processing Framework will simplify the transition to make it server-ready, particularly as a WPS (Web Processing Service) in QGIS Server.
Advantages of Using Processing in QGIS Server:
- Scalability: Automate geospatial tasks without user interaction.
- Performance: Offload complex GIS tasks to server infrastructure.
- Customization: Dynamically process requests based on client parameters.
https://docs.qgis.org/3.34/en/docs/user_manual/processing/scripts.html

Plugin as processing framework allows to develop plugin to test in desktop. This makes it easier to debug and ensures the algorithm will run properly before adapting it for server use.
QGIS Server can expose Processing Algorithms as WPS services. By developing your plugin with the QGIS Processing Framework in mind, you can easily make it server-ready. The same plugin will then be usable both in QGIS Desktop and via QGIS Server as a WPS service.


eltype not implemented for JldDataset

eltype is not implemented for JldDataset, which means eltype(::JldDataset) always returns Any.  This should be fixed, following a similar definition in HDF5.jl.

Fixed in #33.


Add a changed phone number flow to be able to login using email address and access funds

Create flow to be able to log into account via email if phone is lost or changed.
Potentially make this action a sweep funds action, moving all funds to the new phone number. (dangerous)

handled by galoy-mobile


Indent built-in IP tags

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: triddell sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@triddell : Thanks for your contribution! The author, @rkarlin, has been notified to review your proposed change.

@rkarlin - can you check the GitHub view of this change and see if the bullets are rendering the way you want them. It looks good to me, but want you to check. thanks!


removing vagrant

Hey @ychaker are you cool with this PR?

@ychaker thoughts on this PR?  I'd like to merge it before the 2.5.1 release of Splainer goes out...


I can put in Pattern into disconnected MutliBlock Crafter

Issue description:
I can put in Pattern into disconnected MutliBlock Crafter
What happens:
I see disconnected MutliBlock Crafter in Crafter Manager
What you expected to happen:
I was expecting in step 4. that I would not see him
Steps to reproduce:

Plug MultiBlock Crafter to your system

Look into Crafter Manager

Unplug MultiBlock Crafter
Look into Crafter Manager

Try to put a Pattern

Is in MutliBlock Crafter

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: 2613
Refined Storage: 1.6
Reborn Storage <IP_ADDRESS>
EnderIO 5.0.541-nightly
EnderCore 0.5.33

Does this issue occur on a server? [yes/no]
I don't know
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

Does the item appear as craftable in your Grid?

I did not check it because this error does not work anymore :/

What? This conduit is disconnected

Here, where is cobble, i placed RS Conduit, and I break it

But your screenshots in the initial posts show an RS cable, not an EiO cable? So you can reproduce this with both?

But before I placed in the same place Refined Storage Conduit

It works that way:
https://youtu.be/EMiTQeel0Co
Reborn Storage has nothing to do with it and Refined Storage Cable

Lol! And you can't reproduce this with just RS cables? It only happens with EiO conduits?

yes, i think this is a bug with conduit

Then I would suggest reporting this to the EiO devs on their issue tracker! :)


Using menus closes them

Os: Linux Raiku 5.11.21-hardened1-2-hardened #1 SMP PREEMPT Fri, 14 May 2021 21:06:07 +0000 x86_64 GNU/Linux
Miratope version git hash: 70811e1
Problem:
Whenever browsing through a menu it closes even if it isn't a leaf.
VIdeo: https://youtu.be/iHyF1gcDy4g

Seems like this is a problem with bevy and not miratope

This is indeed a limitation of egui. I've proposed some ideas to solve it in this issue thread: https://github.com/emilk/egui/issues/335


Make Writer::stream_writer(_) take ownership of the underlying Writer or provide a Writer.into_strea_writer()

Hey everyone,
I'm currently trying to use StreamWriter and Actix's SyncArbiter to calculate some pretty big images. The problem I run into is that StreamWriter borrows the underlying writer making it hard to use across threads. This would be a lot easier if I could get a StreamWriter that owns the underlying Writer.

Tagging this as hard as it potentially requires revising the data model if we want to avoid a breaking release. Since most of the internals are private we might be able to cheat our way and enable an owned writer that itself with the lifetime parameter 'static.

As a general concept, we could take inspiration from Cow::Owned. Since it owns the object, the lifetime parameter can be chosen arbitrarily as it is only used in the borrowed state. We could introduce a similar enum internally, only requiring some matching on use which should be negligible overhead compared to the IO.

Going a route similar to the standard library might be a good idea: Vec::iter() borrows the vector Vec::into_iter() owns the vector. So there would - from my perspective - be no need to change any of the existing code. Add a 'into_stream_writer()' method to Writer and create a OwnedStreamWriter. I don't know how much work this would be, but it seems to avoid some of your concerns.


Attention weight logging

Proposed changes:

Closes https://github.com/RasaHQ/research/issues/73

Status (please check what you already did):

[x] added some tests for the functionality
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)
[ ] List this as experimental feature here

@JEM-Mosig what's up with this PR?

@JEM-Mosig what's up with this PR?

The corresponding project is on hold due to deadline for dataset collection. Should continue mid June.

how is the implementation going, is this still relevant @JEM-Mosig ?

how is the implementation going, is this still relevant @JEM-Mosig ?

I'm still on this. It's a side project and might take a bit more time. Not critical for 2.0 or anything. I only created a draft PR so its easier for others to see the code changes when we discuss.

@JEM-Mosig I just had a look and it's making me wonder what the easiest way might to go about visualising this. Your PR opens up the attention weights but there's also some other vectors that I'd love to get a hold on too.

I'm wondering what is practical here. I'd love to make DIET more "peekable" but doing so might add unwanted complexity.

@JEM-Mosig why do we need special ..._with_diagnostic methods? I don't see where it is called in processor. Can we just reuse normal predict and process methods?

@JEM-Mosig why do we need special ..._with_diagnostic methods? I don't see where it is called in processor. Can we just reuse normal predict and process methods?

If we output the attention weights (and maybe other data) with the predict / process functions, then messages get a lot bigger. Though we could add a parameter that decides to add or not to add the diagnostic data. I think I'll change it to be parameters @koaning .
Right now, the _with_diagnostic functions are only called by rasalit.

I see. @wochinge what do you think would be the best approach here?

@wochinge Especially with TED threading the information that we want to store diagnostic data through to the model and then propagating the diagnostic information back is a nightmare. Could we create something like a "bucket" that any model of core or nlu can send diagnostic information to? But then I don't know where that would live or how one could access it. Another problem is that we'd want to associate the model inputs with the diagnostic information.

Aren't they weights stored in the TensorFlow checkpoint files anyway and can be visualized using TensorBoard?

no, tensor board doesn't work well here

why not / what's the limitation?

why not / what's the limitation?

@wochinge For once, @koaning has already built some cool tools to visualize these tensors and other things for any nlu or core input, and it relies on having those tensors exposed by some function such as this. Also, tensorboard is messy when you just want to display single images during inference and want to associate them with the input in a readable way.

@JEM-Mosig would it be possible to add the output embedding for the __CLS__ token as well? If that's exposed then I can add it to whatlies and that might do a lot of good in terms of "explaining what DIET is thinking".

@koaning Diagnostic data for DIET now also includes the tensor you asked for, I think. :smile:

@wochinge I am not sure what I should add in terms of documentation.

@JEM-Mosig after looking at it the solution is inconsistent to me. You don't add diagnostic data to a message, because it might be a lot of numpy arrays, but you add it to Prediction. Prediction kind of serves similar purpose to Message in core, and it is passed around a lot

I'd argue that for consistency, either both in nlu and core we add it to some object, or return separately from prediction method. @wochinge what do you think?

@JEM-Mosig I've just tried this branch locally and it seems like there's a bug in the code.
When I run this code;
msg = Message({'TEXT': 'hello world'})
for e in interpreter.pipeline:
    print(f'{e}')
    e.process(msg)
msg

I get this trace;
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py in _convert_inputs_to_signature(inputs, input_signature, flat_input_signature)
   2687         expand_composites=True,
-> 2688         check_types=False)  # lists are convert to tuples for `tf.data`.
   2689   except ValueError:

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/util/nest.py in flatten_up_to(shallow_tree, input_tree, check_types, expand_composites)
    951                            check_types=check_types,
--> 952                            expand_composites=expand_composites)
    953   # Discard paths returned by _yield_flat_up_to.

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/util/nest.py in assert_shallow_structure(shallow_tree, input_tree, check_types, expand_composites)
    869                                check_types=check_types,
--> 870                                expand_composites=expand_composites)
    871

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/util/nest.py in assert_shallow_structure(shallow_tree, input_tree, check_types, expand_composites)
    853             _STRUCTURES_HAVE_MISMATCHING_LENGTHS.format(
--> 854                 input_length=len(input_tree), shallow_length=len(shallow_tree)))
    855       elif len(input_tree) < len(shallow_tree):

ValueError: The two structures don't have the same sequence length. Input structure has length 0, while shallow structure has length 7.

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
<ipython-input-15-cbf790f70f5b> in <module>
      2 for e in interpreter.pipeline:
      3     print(f'{e}')
----> 4     e.process(msg)
      5 msg

~/Development/rasa/rasa/nlu/classifiers/diet_classifier.py in process(self, message, **kwargs)
    897     def process(self, message: Message, **kwargs: Any) -> Optional[Dict[Text, Any]]:
    898         """Augment the message with intents and entities and return diagnostic data."""
--> 899         out = self._predict(message)
    900
    901         if self.component_config[INTENT_CLASSIFICATION]:

~/Development/rasa/rasa/nlu/classifiers/diet_classifier.py in _predict(self, message)
    793         model_data = self._create_model_data([message], training=False)
    794
--> 795         return self.model.predict(model_data)
    796
    797     def _predict_label(

~/Development/rasa/rasa/utils/tensorflow/models.py in predict(self, predict_data)
    302
    303         self._training = False  # needed for eager mode
--> 304         return self._predict_function(batch_in)
    305
    306     def save(self, model_file_name: Text, overwrite: bool = True) -> None:

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py in __call__(self, *args, **kwds)
    778       else:
    779         compiler = "nonXla"
--> 780         result = self._call(*args, **kwds)
    781
    782       new_tracing_count = self._get_tracing_count()

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py in _call(self, *args, **kwds)
    812       # In this case we have not created variables on the first call. So we can
    813       # run the first trace but we should fail if variables are created.
--> 814       results = self._stateful_fn(*args, **kwds)
    815       if self._created_variables:
    816         raise ValueError("Creating variables on a non-first call to a function"

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py in __call__(self, *args, **kwargs)
   2826     """Calls a graph function specialized to the inputs."""
   2827     with self._lock:
-> 2828       graph_function, args, kwargs = self._maybe_define_function(args, kwargs)
   2829     return graph_function._filtered_call(args, kwargs)  # pylint: disable=protected-access
   2830

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py in _maybe_define_function(self, args, kwargs)
   3169     if self.input_signature is None or args is not None or kwargs is not None:
   3170       args, kwargs = self._function_spec.canonicalize_function_inputs(
-> 3171           *args, **kwargs)
   3172
   3173     cache_key = self._cache_key(args, kwargs)

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py in canonicalize_function_inputs(self, *args, **kwargs)
   2620           inputs,
   2621           self._input_signature,
-> 2622           self._flat_input_signature)
   2623       return inputs, {}
   2624

~/Development/rasa/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py in _convert_inputs_to_signature(inputs, input_signature, flat_input_signature)
   2690     raise ValueError("Structure of Python function inputs does not match "
   2691                      "input_signature:\n%s" %
-> 2692                      format_error_message(inputs, input_signature))
   2693
   2694   need_packing = False

ValueError: Structure of Python function inputs does not match input_signature:
  inputs: (
    ())
  input_signature: (
    (TensorSpec(shape=(None, 3), dtype=tf.int64, name=None), TensorSpec(shape=(None,), dtype=tf.float32, name=None), TensorSpec(shape=(3,), dtype=tf.int64, name=None), TensorSpec(shape=(None, 3), dtype=tf.int64, name=None), TensorSpec(shape=(None,), dtype=tf.float32, name=None), TensorSpec(shape=(3,), dtype=tf.int64, name=None), TensorSpec(shape=(None,), dtype=tf.float32, name=None)))

I'm assuming this branch is still work in progress but I figured I'd mention it just in case.

@koaning This is odd, as it is exactly what is tested in this test. How do you load the interpreter?

@JEM-Mosig This is what I am using;
from rasa.cli.utils import get_validated_path
from rasa.model import get_model, get_model_subdirectories
from rasa.nlu.model import Interpreter

def load_interpreter(model_dir, model):
    path_str = str(pathlib.Path(model_dir) / model)
    model = get_validated_path(path_str, "model")
    model_path = get_model(model)
    _, nlu_model = get_model_subdirectories(model_path)
    return Interpreter.load(nlu_model)

interpreter = load_interpreter(model_folder, model_file)

I'd argue that for consistency, either both in nlu and core we add it to some object, or return separately from prediction method. @wochinge what do you think?

I agree 👍

@JEM-Mosig how big are your numpy arrays?
@wochinge since we might add significantly more arrays in the future, I suggest separate return or set a self variable after every prediction, than rasalit can extract this updated self variable every time after prediction

since we might add significantly more arrays in the future, I suggest separate return or set a self variable after every prediction, than rasalit can extract this updated self variable every time after prediction

Why not adding it to message?

I guess the concern is that passing around all these numpy arrays would increase memory consumption drastically

I guess the concern is that passing around all these numpy arrays would increase memory consumption drastically

They'd only be used by rasalit
We pass around references, right? So should be fine in my opinion.

We pass around references, right?
I don't know, in this case - yes

@JEM-Mosig how big are your numpy arrays?

For default DIET: 8 * (number of tokens + 1)^2 entries per message

We pass around references, right? So should be fine in my opinion.

I didn't know that numpy arrays are passed as references. I'll add the arrays to the messages then.

@JEM-Mosig I've just tried this branch locally and it seems like there's a bug in the code.
When I run this code;
msg = Message({'TEXT': 'hello world'})
for e in interpreter.pipeline:
    print(f'{e}')
    e.process(msg)
msg

I get this trace;
...
I'm assuming this branch is still work in progress but I figured I'd mention it just in case.

@koaning This fails on master branch as well. The trace is created during the call of load_interpreter, but I don't know yet why.

@wochinge Is this good now?

where the model is seen as not-finetunable because pipeline fingerprints differ.

Why is the model configuration affected by this? Seems to me that the config is updated inplace rather than doing a copy and then updating it. hence, your update to the config affects the fingerprinting which takes place after the model training.

where the model is seen as not-finetunable because pipeline fingerprints differ.

Why is the model configuration affected by this? Seems to me that the config is updated inplace rather than doing a copy and then updating it. hence, your update to the config affects the fingerprinting which takes place after the model training.

where the model is seen as not-finetunable because pipeline fingerprints differ.

Why is the model configuration affected by this? Seems to me that the config is updated inplace rather than doing a copy and then updating it. hence, your update to the config affects the fingerprinting which takes place after the model training.

That did it!

where the model is seen as not-finetunable because pipeline fingerprints differ.

Why is the model configuration affected by this? Seems to me that the config is updated inplace rather than doing a copy and then updating it. hence, your update to the config affects the fingerprinting which takes place after the model training.

That did it!

@wochinge If the last master-merge didn't break anything, this is all green now. Can you please review one (hopefully) last time?

@wochinge If the last master-merge didn't break anything, this is all green now. Can you please review one (hopefully) last time?


[Bug] Workshop_data replaced at modbuild

Description
When a mod is built it removes everything including Workshop_data.json
Result:
Updated settings and config is lost that mod was uploaded.
Example Solution:
When a mod is built before the mod folder is cleared it should check and import existing Workshop_data.json to Project Data folder.
This way any config and settings is retained automagical.

Fixed alognside #1 changes


Added Shroomloin Variations and Warpbeetle Chorus Variation.

[ ] Added shaking feature (just like when curing zombie villager)

I'm going to wait until the shaking feature is implemented before merging.


Make sure the methods in c module return NULL when there's error.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (49e7d3d) 100.00% compared to head (a80a5a3) 93.89%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #404      +/-   ##
===========================================
- Coverage   100.00%   93.89%   -6.11%
===========================================
  Files           21       21
  Lines         2293     2293
===========================================
- Hits          2293     2153     -140
- Misses           0      140     +140

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[security] Enforce Branch Protections

This is an issue generated by (for-internal-use-only)github-tools
Description
This repository has exceeded the development grace period, and the repo owner must decide if branch protections should be enforced.
If this repository houses code used in production in any capacity, branch protections must be enforced. Read (for-internal-use-only)here for more details
What do I need to do?

You can control whether or not branch protections are enforced by exclusively creating either of the labels:
'enforce-branch-protections: true' or 'enforce-branch-protections: false'
If there is no branch protection control label, this issue will be recreated.
Once you have created either label, you can close this issue.
If you have issues or questions, please reach out to #internal-security-n-compliance on slack.

@MarcL, the repo is already configured for branch protection. I think this issue popped up because I hadn't added the label to the repo. I've gone ahead and added the enforce-branch-protections: true label to the repository.

I added the `enforce-branch-protections: true label to the issue to indicate that the label was created.


how to Render a 3D hand in world Space

Plugin Version or Commit ID
v0.11.0
Unity Version
2021.3.18f
Your Host OS
windows 10
Target Platform
Android, iOS
Description
I want to create a 3d hand in unity world space and track it considering the camera position. I do have some rough idea on how to do this but need some pointers.

how can i convert these normalized values into real world coords?
there is world hand landmarks as output can they be used? if so then how bcs i tired attach a proller but didnt work

Code to Reproduce the issue
No response
Additional Context
No response

maybe duplicates #857

возможно дубликаты #857

could you help me with the example of Samples/Scenes/HandTracking to explain how I can get the position of hands in 3D space, I tried your tutorial from the wiki, I develop for Android, and nothing was displayed for me, although everything works on your demo scenes


material design css?

possible to use the styling like in this demo, css here

Yes, possible
Just provide the following css in your html
`
  @keyframes slideDown {
    0% {
      transform:  translateY(-10px);
    }
    100% {
      transform: translateY(0px);
    }
  }
  .auto-complete input {
    outline: none;
    border: 2px solid transparent;
    border-width: 3px 2px;
    margin: 0;
    box-sizing: border-box;
    background-clip: content-box;
  }
  .auto-complete ul {
    background-color: #fff;
    margin: 0;
    width : 100%;
    overflow-y: auto;
    list-style-type: none;
    padding: 0;
    border: 1px solid #ccc;
    box-sizing: border-box;
    animation: slideDown 0.1s;
  }
  .auto-complete ul li {
    padding: 2px 5px;
    border-bottom: 1px solid #eee;
  }
  .auto-complete ul li.selected {
    background-color: #ccc;
  }
  .auto-complete ul li:last-child {
    border-bottom: none;
  }
  .auto-complete ul li:hover {
    background-color: #ccc;
  }
`

@allenhwkim i will try this asap and report back, im waiting to update my app to rc5 so i can use this package.

0.6.3 released for MD. Please test.

wohooo, im on it, will report back shortly.

@allenhwkim
so i've tested it, there are no errors but looks like its not using material design. i've attached screen shots for your review.  Also on clicking the item from the dropdown, it doesnt do anything, doesnt even display "200" on the value input.
{{ myData | json }}
                        <md-input ng2-auto-complete
                                  [ngModelOptions]="{standalone: true}"
                                  [(ngModel)]="myData"
                                  [source]="arrayOfNumbers"
                                  placeholder="amount" align="end">
                            $
                            .00
                        </md-input>

arrayOfNumbers: number[] = [100, 200, 300, 400, 500];

That part I do not know about material design. MD says we can use [(ngModel)], but I did not dig into deeper. You still can use (value-changed)="myCallback($event)" to make the value changed.

@allenhwkim actually if i use the arrow keys to select the item from drop down, it doesnt highlight the values.either

@allenhwkim sorry my bad the select from arrow keys work.

@allenhwkim
so i tried (value-changed)="onSelected($event)" and i can get the value from event.target.value but it does not show the value inside input field. it remains empty.

@allenhwkim were you able to try out the issue i mentioned?

Made some changes, could you try again?

Closing this for inactivity. Please create an issue again if not resolved


Create Function with Type generates "typeof" when used with Enums

Describe the bug
When executing hocusPocus.createFunctionWithTypes on code like this:
enum Bla {
	A = 1,
	B = 2,
}

function bla() {
	doSomething(Bla.A);
}

It generates typeof <Enum> instead of <Enum> as the parameter type in the created function:
function doSomething(param1: typeof Bla) {
  // Implement
}

TS will then complain about the argument not being assignable to the type of the parameter at the call site.
How to reproduce
Define an enum and pass a enum value to an unknown function, execute the extension.
Expected behavior
The extension should instead declare the parameter as the enum type, like this
function doSomething(param1: Bla) {
  // Implement
}

Additional information

Version of the extension impacted: v1.4.0

Thanks for reporting, that's helpful to catch different patterns and edge-case (we still need to battle test this new feature!).
This is now fixed.


examples: add screenspace texture shader example

Adds a new shader example showing how to sample a texture with screenspace coordinates, similar to the end portal in minecraft.
https://user-images.githubusercontent.com/22177966/156031195-33d14ed8-733f-4d9e-b1da-0fc807c994a5.mp4
I just used the already existent models/FlightHelmet/FlightHelmet_Materials_LensesMat_OcclusionRoughMetal.png texture but maybe we should use a dedicated texture for the example. Suggestions welcome.

bors r+

(example readme name doesn't match the example name)

bors r+


Cannot receive email using Taskt UOB

When working with taskt and attempting to use email commands (Both Send Email and Send Email SMTP), I encountered the following issue:
Despite using the same command configuration that works for my colleague, I received an error when trying to send emails using my own email credentials. The error message stated:
Error: System.Exception: Fail Send EMail MailKit.Security.SslHandshakeException: An error occurred while attempting to establish an SSL or TLS connection.
To troubleshoot, my colleague tested the same configuration but replaced my email with his own while using my passkey. The command executed successfully for himand he received the email but it does not work for me.

Hi! This error is described in the MailKit FAQ.
Please check this URL or check your anti-virus software settings.
https://github.com/jstedfast/MailKit/blob/master/FAQ.md#ssl-handshake-exception


Introduce versioning for postee

Hello everybody,
would it be possible to introduce versioning of postee images - versions e.g. 1.0
Thanks a lot!
Cheers,
Jan

@krol3 can you help with this? Once we release a new Postee it needs to be tagged with the release version.

This seems to be resolved,
(https://github.com/aquasecurity/postee/releases/tag/v1.1.4)
so thanks a lot !
Cheers,
Jan


Exporter displaying traceback on target weblink

Hello, when i start the exporter and go to http://<IP_ADDRESS>:9221/pve?target=<IP_ADDRESS> (ip is of my proxmox host and the exporter as well, i get the following traceback:
  File "/usr/local/lib/python2.7/dist-packages/pve_exporter/http.py", line 44, in do_GET
    output = collect_pve(self._config[module], target)
  File "/usr/local/lib/python2.7/dist-packages/pve_exporter/collector.py", line 207, in collect_pve
    return generate_latest(registry)
  File "/usr/local/lib/python2.7/dist-packages/prometheus_client/exposition.py", line 63, in generate_latest
    for metric in registry.collect():
  File "/usr/local/lib/python2.7/dist-packages/prometheus_client/core.py", line 97, in collect
    for metric in collector.collect():
  File "/usr/local/lib/python2.7/dist-packages/pve_exporter/collector.py", line 84, in collect
    del node['online']
KeyError: 'online'```

Thanks for the report. I pushed a fix for this into branch bug/master/1-cluster-key-error. Would you mind checking whether that fixes the problem and report back here?

I'm seeing the same error against the branch (did a pip uninstall . followed by a pip install . --upgrade) logs are printing the following on the host: /usr/local/bin/pve_exporter /opt/prometheus-pve-exporter/pve.yml <IP_ADDRESS> - - [09/Oct/2017 08:53:55] "GET /pve?target=<IP_ADDRESS> HTTP/1.1" 500 - <IP_ADDRESS> - - [09/Oct/2017 08:54:04] "GET /pve?module=default HTTP/1.1" 500 - <IP_ADDRESS> - - [09/Oct/2017 08:55:04] "GET /pve?module=default HTTP/1.1" 500 -
Heres my prometheus.yml just to be helpul, its running via docker
  - job_name: 'pve'     static_configs:       - targets:         - <IP_ADDRESS>:9221  # Proxmox VE node with PVE exporter.     metrics_path: /pve     params:       module: [default]

Sorry for that, I currently only have access to a single-node pve. Apparently the output from a cluster is a bit different. Do you see the same trace or is it a different one this time?

Found another place where that could be a problem. Do you mind pulling and trying again?


How to align depth and color images from a ORIG.BAG file

Hello! I am having troubles aligning the color and depth images. I have a Rosbag with data from a RealSense Depth Camera D435i (and other sensors). I only have the rosbag and at the moment I do not have the camera Here is the hardware info:

Required Info

Camera Model
D435i

Firmware Version
-

Operating System & Version
Ubuntu 22.04

Kernel Version (Linux Only)
6.8.0-48-generic

Platform
PC

SDK Version
-

Language
Python

Segment
Robot

Issue Description
I have read about how to align RGB images and Depth images using the RealSense library and pipeline, also from a rosbag.
However, when I try to use config.enable_device_from_file(rosbag_path) I get the following error:
Failed to create ros reader: Invalid file format, file does not contain topic "/file_version" nor "/FILE_VERSION"
I also read that some Rosbags cannot be used for the enable_device_from_file() method.
I can extract both images from the Rosbags (I also do this manually because I need to get the data from other sensors) and when checking them I can see they are not aligned. I need them align because I need to identify objects in the images and then check the distance of these objects to the robot.
In the image can be seen the difference between both images and parameters I get from the topic: /camera/color/camera_info'.

I am wondering then, how can I align both images to extract depth information from objects in the RGB image?
Thanks :)

Hi @FelipeZerokun  If your rosbag was recorded in ROS with a RealSense camera and also non-camera devices - the 'other sensors' that you mention the bag contains data from - then the librealsense SDK may be unable to read the bag.  This is because librealsense's bag support is only designed for camera data.
A RealSense user created a rosbag parser at https://github.com/IntelRealSense/librealsense/issues/2215 to read bag files using the rosbag API directly.  It is in C++ language rather than Python though.

@MartyG-RealSense Thanks, I am checking it out now. I saw that both cameras have Intrinsics and Extrinsics parameters. I guess those parameters are different for the RGB and Depth cameras? Because in my ROS files I can only get the  '/camera/color/camera_info' topic with K, D, R and P values, I don't find any depth/camera_info

On the D435-type camera models such as D435i, the five distortion coefficients are all set to zero, as advised at https://github.com/IntelRealSense/librealsense/issues/1430
Yes, each stream type has its own unique intrinsic and extrinsic values.
You can list all of the intrinsic and extrinsic values of a camera with the librealsense SDK's 'rs-enumerate-devices' tool by launching it in calibration information mode with the command below.
rs-enumerate-devices -c

Ok, so I imagine I need the actual camera to find these values, right? I don't find these values anywhere in the Rosbags.
And, once I have these values, I think I can do camera calibration and image alignment without the actual hardware, correct?

Ideally you would read the intrinsics and extrinsics from the actual camera that was used to record that rosbag file.
If you do not have access to the real camera though, my research indicates that when recording a rosbag in ROS, intriniscs should be stored in a topic called Camerainfo
https://stevengong.co/notes/CameraInfo
https://docs.ros.org/en/melodic/api/sensor_msgs/html/msg/CameraInfo.html

Ok, I couldn't find the values mentioned in the links  for the stereo camera (It's like only the mono-camera was recorded in the Rosbags)
D = [ 0.0 , 0.0 , 0.0 , 0.0 , 0.0]
K=
[ 604.867 , 0.0        , 320.659 ]
[ 0.0         , 604.944, 232.351  ]
[ 0.0         , 0.0        , 1.0         ]
R =
[ 1.0, 0.0, 0.0]
[ 0.0, 1.0, 0.0]
[ 0.0, 0.0, 1.0]
P=
[ 604.867 , 0.0        , 320.659, 0.0 ]
[ 0.0         , 604.944, 232.351, 0.0 ]
[ 0.0         , 0.0        , 1.0        , 0.0 ]
From all this, it means:
fx  = 604.867
fy = 604.944
cx = 320.659
cy = 232.351
tx = ty = 0
Is it possible that the camera was configured in a different way?
Anyway, I will try to understand why I am getting these values from the Rosbags, and not Stereo intrinsics, and then I'll perform manual calibration and alignment.

Each individual camera has unique intrinsics due to the manufacturing process at the factory, so no two cameras will have the same values.


Improve labeling of SPEND transactions between 2 accounts from the same wallet (sending/receiving).

Connected with this node issue https://github.com/aeternity/aeternity/issues/4405


Remove dependence on mkdocs-simple-hooks

Since mkdocs v1.4, the hooks are a native feature

Very cool thanks!


Password validator to match backend regex

Steps to Reproduce
Go to register page
add the special characters, such as -

is accepted in the backend, but not in the frontend

Observed Results

is accepted in the backend, but not in the frontend
Therefore, you get an error validation saying that we still need to include one special character

Expected Results

Should allow special characters allowed from the backend

PR: GH-3254

For QA:

go to register page,
create an account with the usual password as before, but for the special character, test using the - instead.

For more extra testing, try creating an account with each of those special characters shown above.

Waiting for confirmation from Tobias and Bill.

The validation in storefront should match the OCC rules

Test successful 👍


Update: Expose all cdk objects created by the construct as pattern properties

Issue:
AWS Solutions Constructs currently expose limited number of CDK objects created by the constructs, for example, aws-apigateway-lambda exposes the apiGateway and lambdaFunction as Pattern Properties. But there are other related objects (e.g. CloudWatch LogGroup, IAM Role, etc.) created by the construct, which are not directly accessible to the user as Pattern Properties
Solution:
Add the other related CDK objects created by the Construct and expose them as Pattern Properties

Enhancement implemented in v1.53.0


Update signature generator to new branding

We need to use a non-gradient version of the logo because we don't want the gradient on a whitebackground (the yellow part of the gradient gets washed out).
Side-note: I can't remember how this setup is affected by light mode / dark mode in email clients?


Expenses can be filed by any account on any project

Describe the bug
Expenses can nowadays be filed by any account on any project.
This is being abused already.
To Reproduce
Go to any project when logged in and click submit expense.
Expected behavior
I tink it used to be that way that they have to be at least a Team member of the project.
There seems to be no option to restore the old behaviour.
Additional context
https://opencollective.com/advancedfx/expenses/26740

This is not a bug and it's always worked this way.
However, I do understand why allowing just anyone to submit an expense might be problematic. We are aware of spam issues and have been working hard to create ways to combat them (see #2741).
We are also working on new functionality to enabling inviting someone to submit an expense, where you fill out some details and then they are notified to confirm everything and submit it finally. Perhaps we should consider a Collective-level setting where you can switch off the submit expense button for the public and only have expenses via being invited by an admin.
This might go against some of Open Collective's ideals about open participation, but it could be worthwhile in some situations.

My team and me thought it was different before the expense interface update, sorry.
Also seems like a duplicate issue then.

I raised #3623 about only allowing invited expenses.


Create sniff to enforce registration of scripts and stylesheets

Scripts and stylesheets should not be hard-coded in templates. On the contrary, they should be registered using wp_register_script() and wp_register_style() during the wp_enqueue_scripts action. If a stylesheet <link> is hard-coded in the <head> then they are doing it wrong, or if a <script src="..."> appears in the footer, they are doing it wrong.

Fixed by #135, which is present in 0.3.0. Not sure why this wasn't automatically closed.


Jar file is incompatible on java 8

Hi,
We run into an issue while using the jar file below because it is compatible with java 11 or above. However, we are using java 8 on implementing the application. Do you have any maven dependency for the google-walletobjects that we can use? Or any jar file that is compatible with java 8.
google-walletobjects-v1-rev_20221109-java.zip
Thank you!

Hello!
Unfortunately we do not have a Java 8-compatible JAR at this time. I will bring this up to the Engineering team to take a look at! In the meantime, you can continue to use the Google Wallet API, however you will need to instead build the API requests as JSON strings instead of using the object types defined by the library. An example can be found below:
HttpTransport httpTransport = GoogleNetHttpTransport.newTrustedTransport();
HttpRequestFactory httpRequestFactory = httpTransport.createRequestFactory();

GenericUrl objectUrl = new GenericUrl(String.format("https://walletobjects.googleapis.com/walletobjects/v1/genericObject/%s.%s", issuerId, objectSuffix));

// Build a payload for an object
// Make sure to include all required properties
// for this object type
String objectPayload = String.format(
    "{"
  + "  \"id\": \"%s.%s\","
  + "  \"classId\": \"%s.%s\""
  + "}",
  issuerId, objectSuffix, issuerId, classSuffix);

// Check if the object exists already
// Build a GET request
HttpRequest objectRequest = httpRequestFactory.buildGetRequest(objectUrl);

// Add auth to the request headers
objectRequest
    .setHeaders(new HttpHeaders()
        .setAuthorization("Bearer " + credentials.getAccessToken().getTokenValue()));

// Invoke the GET request
HttpResponse objectResponse = objectRequest.execute();

if (objectResponse.getStatusCode() == 404) {
  // Object does not yet exist
  // Send POST request to create it
  // Include the JSON payload
  objectRequest = httpRequestFactory.buildPostRequest(
      objectUrl,
      new JsonHttpContent(new GsonFactory(), objectPayload));

  // Add auth to the request
  objectRequest
      .setHeaders(new HttpHeaders()
          .setAuthorization("Bearer " + credentials.getAccessToken().getTokenValue()));

  // Invoke the POST request
  objectResponse = objectRequest.execute();
}

System.out.println("object GET or POST response: " + objectResponse.parseAsString());

Additional examples can be found in this repo in earlier commits (before we updated it to use the Walletobjects library). Check out this link for instance.
I hope this helps!

Hello again,
We haven't heard back from you in a while regarding this issue. I will go ahead and close this out for the time being. If you're still running into any problems, please feel free to reopen and add any additional details!


feat!: replace HADMap with Lanelet

Signed-off-by: kosuke55<EMAIL_ADDRESS>PR Type

New Feature

Related Links

universe

https://github.com/autowarefoundation/autoware.universe/pull/2356

autoware_common

https://github.com/autowarefoundation/autoware_common/pull/133

port PR of auto_msgs to autoware_msgs

https://github.com/autowarefoundation/autoware_msgs/pull/33
Rename to Lanelet

https://github.com/autowarefoundation/autoware_msgs/pull/41

Add uuid to Lanelet

https://github.com/autowarefoundation/autoware_msgs/pull/42

Description

Replace HADMap of autoware_auto_planning_msg with Lanelet of autoware_planning_msgs.
LaneLetRoute has uuid and I want to use it in planning modules. Please refer to https://github.com/autowarefoundation/autoware/discussions/2983 for details.
Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

(changed commit message)


Update README

Sorry, small fix. PlutoStaticHTML used to have some precompute capability but I removed it because you told me of all the many edge cases which would be very difficult to get it right. I'm now waiting for https://github.com/JuliaPluto/PlutoSliderServer.jl/pull/29 and seeing after that whether it will be possible to get an nice integration between the packages going

Okay! Can you change it instead of removing it?

Change what exactly? :slightly_smiling_face: Re-install the thing that I deleted you mean?


Hello guys , does any one know how to solve this issue ? Thanks in advance!

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Describe the expected behavior
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

My code is here :+1: #!sur/bin/python3
--coding:utf-8 --
Author: Wang Quan
@Time:2021/1/2 7:46
import tensorflow as tf
import matplotlib.pyplot as plt
from tensorflow import keras
from tensorflow.keras.models import Sequential
import numpy as np
import math
(x_train,y_train),(x_test,y_test)=keras.datasets.mnist.load_data()
print(len(x_train))
print(len(x_test))
print(x_train[0].shape)
plt.matshow(x_train[0])
plt.show()
print(y_train[0])
print(x_train.shape)
x_train=x_train/255.0
x_test=x_test/255.0
x_train_flattened= x_train.reshape(len(x_train),2828)
x_test_flattened= x_test.reshape(len(x_test),2828)
print(x_train_flattened.shape)
print(x_test_flattened.shape)
print(x_train[2])
print(x_train_flattened[2])
model=keras.Sequential([
keras.layers.Dense(10,input_shape=(784,),activation='sigmoid')
])
model.compile(optimizer='adam',
loss='sparse_categorical_crossentropy',
metrics=['accuracy'])
model.fit(x_train_flattened,y_train,epochs=5)
model.evaluate(x_test_flattened,y_test)
plt.matshow(x_test[2])
plt.show()
y_predict=model.predict(x_test_flattened)
print(np.argmax(y_predict[2]))   #打印7
y_predicted_labels = [np.argmax(i) for i in y_predict]
print(y_predicted_labels[:5])
# y_test[:5]
cm=tf.math.confusion_matrix(labels=y_test,predictions=y_predicted_labels)
print(cm)
import seaborn as sn
plt.figure(figsize=(10,7))
sn.heatmap(cm,annot=True,fmt='d')
plt.xlabel('predicted')
plt.ylabel('truth')
plt.show()
I got error :Tensor("confusion_matrix/SparseTensorDenseAdd:0", shape=(10, 10), dtype=int32)
Traceback (most recent call last):
File "C:/Users/Administrator/Desktop/光学系统/Keras Code/mnist read.py", line 53, in
sn.heatmap(cm,annot=True,fmt='d')
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn_decorators.py", line 46, in inner_f
return f(**kwargs)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn\matrix.py", line 537, in heatmap
yticklabels, mask)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn\matrix.py", line 101, in init
plot_data = np.asarray(data)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\numpy\core_asarray.py", line 83, in asarray
return array(a, dtype, copy=False, order=order)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\tensorflow_core\python\framework\ops.py", line 736, in array
" array.".format(self.name))
NotImplementedError: Cannot convert a symbolic Tensor (confusion_matrix/SparseTensorDenseAdd:0) to a numpy array.

My code is here :+1: #!sur/bin/python3
--coding:utf-8 --
Author: Wang Quan
@Time:2021/1/2 7:46
import tensorflow as tf
import matplotlib.pyplot as plt
from tensorflow import keras
from tensorflow.keras.models import Sequential
import numpy as np
import math
(x_train,y_train),(x_test,y_test)=keras.datasets.mnist.load_data()
print(len(x_train))
print(len(x_test))
print(x_train[0].shape)
plt.matshow(x_train[0])
plt.show()
print(y_train[0])
print(x_train.shape)
x_train=x_train/255.0
x_test=x_test/255.0
x_train_flattened= x_train.reshape(len(x_train),2828)
x_test_flattened= x_test.reshape(len(x_test),2828)
print(x_train_flattened.shape)
print(x_test_flattened.shape)
print(x_train[2])
print(x_train_flattened[2])
model=keras.Sequential([
keras.layers.Dense(10,input_shape=(784,),activation='sigmoid')
])
model.compile(optimizer='adam',
loss='sparse_categorical_crossentropy',
metrics=['accuracy'])
model.fit(x_train_flattened,y_train,epochs=5)
model.evaluate(x_test_flattened,y_test)
plt.matshow(x_test[2])
plt.show()
y_predict=model.predict(x_test_flattened)
print(np.argmax(y_predict[2]))   #打印7
y_predicted_labels = [np.argmax(i) for i in y_predict]
print(y_predicted_labels[:5])
# y_test[:5]
cm=tf.math.confusion_matrix(labels=y_test,predictions=y_predicted_labels)
print(cm)
import seaborn as sn
plt.figure(figsize=(10,7))
sn.heatmap(cm,annot=True,fmt='d')
plt.xlabel('predicted')
plt.ylabel('truth')
plt.show()
I got error :Tensor("confusion_matrix/SparseTensorDenseAdd:0", shape=(10, 10), dtype=int32)
Traceback (most recent call last):
File "C:/Users/Administrator/Desktop/光学系统/Keras Code/mnist read.py", line 53, in
sn.heatmap(cm,annot=True,fmt='d')
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn_decorators.py", line 46, in inner_f
return f(**kwargs)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn\matrix.py", line 537, in heatmap
yticklabels, mask)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\seaborn\matrix.py", line 101, in init
plot_data = np.asarray(data)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\numpy\core_asarray.py", line 83, in asarray
return array(a, dtype, copy=False, order=order)
File "C:\Users\Administrator\Anaconda3\envs\pythonProject\lib\site-packages\tensorflow_core\python\framework\ops.py", line 736, in array
" array.".format(self.name))
NotImplementedError: Cannot convert a symbolic Tensor (confusion_matrix/SparseTensorDenseAdd:0) to a numpy array.

Please:

Fill in issue template
Use proper markdown formatting so code and error are easy to read
Give a minimal reproducing example, not a large piece of code
Give the issue a relevant title.

Please:

Fill in issue template
Use proper markdown formatting so code and error are easy to read
Give a minimal reproducing example, not a large piece of code
Give the issue a relevant title.


Allow placement of map widgets by relative coordinates

Note this is currently technically possible by setting placement to fill and providing positioning info to the style css dict. This task is to make that interface less painful

Closed with last lonboard fork bump - params for relative widget placement are placement_x and placement_y


Implement ParetoNBD with covariates

Description

This PR includes commits from #555, #564 and #565 that need to be merged first
Related Issue

[x] Supersedes and closes #463
[ ] Related to #

Checklist

[ ] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

[ ] MMM
[ ] CLV

Type of change

[ ] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--545.org.readthedocs.build/en/545/

I think an updated UML diagram would be a helpful addition to CONTRIBUTING.MD to better understand all these new class inheritances:

Here are some instructions on how to create one:
https://github.com/pymc-labs/pymc-marketing/issues/178

Code is certainly cleaner than the IF statement jungle of the PR I posted haha. Best way I can contribute is to create a child branch and work in parallel in the dev notebook for user-oriented feedback.

Code is certainly cleaner than the IF statement jungle of the PR I posted haha. Best way I can contribute is to create a child branch and work in parallel in the dev notebook for user-oriented feedback.

It's always easier to refactor than write the first pass. The notebook would help a lot!
I'll be testing the covariate model today, and fix stuff I've certainly broken

@ColtAllen finally pushed my last changes. I broke the pre-existing methods API very much, but we can:

Go back and make it like it looked before, plus optional argument for covariates in all methods
Use a new API but support old API with deprecation warnings
Something else. I don't like asking for a whole dataframe in cases where the user is only changing one variable, but for covariates it makes sense to request a dataframe anyway, so it makes sense that other variable also comes in the same dataframe

I'm in favor of 2.
Finally, the slow TestParetoNBDModelWithCovariates::test_inference is failing badly. I used synthetic data from fixed true parameters (so I could control the covariate coefficients), but it is not recovering those at all. Should I use different true parameter values?

@ColtAllen finally pushed my last changes. I broke the pre-existing methods API very much, but we can:

Go back and make it like it looked before, plus optional argument for covariates in all methods
Use a new API but support old API with deprecation warnings
Something else. I don't like asking for a whole dataframe in cases where the user is only changing one variable, but for covariates it makes sense to request a dataframe anyway, so it makes sense that other variable also comes in the same dataframe

I'm in favor of 2.

Yes, let's do option 2.

Finally, the slow TestParetoNBDModelWithCovariates::test_inference is failing badly. I used synthetic data from fixed true parameters (so I could control the covariate coefficients), but it is not recovering those at all. Should I use different true parameter values?

Yes - the true parameters you're using are for a model fit without covariates. When I fit a covariate model in the dev notebook of my previous PR, all parameter values changed.
Also, only the covariates were synthesized, and were tacked onto an existing dataset. If we're to test with parameter recovery, we'll need to generate a full dataset from the parameters used for testing.

No, I'm generating new observations (recency and frequency) in that test as well

Buy why is only a single prior predictive sample being taken?

No, I'm generating new observations (recency and frequency) in that test as well

Buy why is only a single prior predictive sample being taken?

One draw is enough, it contains an observation for each synthetic customer

No, I'm generating new observations (recency and frequency) in that test as well
One draw is enough, it contains an observation for each synthetic customer

I see. The new frequency column name is misspelled though, so it's testing on the original column rather than what was generated for the test.

Is the user API still a work in progress? All predictive methods require arguments to be converted into dataframe columns beforehand, which seems rather cumbersome.


Force save file on server

Hi.. there
I want the generated pdf file to be immediately saved in directory on server..
Any possible ways :)
Regards

for all those struggling with the same issue here is what I have done to achieve this:-
First I created a facade object
$facade = $this->get('ps_pdf.facade');
                    $response = new Response();

Then I passed all the required variables to twig template:
```
$this->render('print/printAgreement.pdf.twig', array(
'vision' => $vision));

Then added any necessary stylesheets, generated xml content response, added the response to facade object

$stylesheet = $this->renderView('PsPdfBundle:Example:pdfStylesheet.xml.twig', array());
$xml = $response->getContent();
$pdf = $facade->render($xml, $stylesheet);
Instanctiated a new file object
                  `  $fs = new Filesystem();
`
Finally, called dumpfile() function of file system object
`$fs->dumpFile('versions/'.$vname.'.pdf', $pdf);`

It will dump/store the generated pdf file to the given path on the server. Given that proper write permission are there on the folder.

Thanks


Use shared libraries when building on Travis

This should reduce memory consumption and build time.

Comparing Travis run times for this PR (https://travis-ci.org/apache/incubator-quickstep/builds/136474629) with one from earlier today (https://travis-ci.org/apache/incubator-quickstep/builds/136370961), almost all the run times have gone down to a certain extent. It's particularly helpful for the GCC runs with copy elision (>10% speedup).


Generic autocomplete for proxy models

AutocompleteGeneric can't validate choice when using proxy models.

Please provide more information.
http://django-autocomplete-light.readthedocs.org/en/master/faq.html#how-to-report-a-bug-effectively

Released in 2.3.0


Add fill and fill_with

Utility functions to fill the grid with a given value

Your changes are in new release 0.7.0. Thx!


OPNsense 23.1.5_4-amd64 Failed to install the following 1 package(s): https://pkg.freebsd.org/FreeBSD:13:amd64/latest/

Hi running on a ZBOX with Intel(R) Core(TM) i3-4130T CPU @ 2.90GHz (2 cores, 4 threads)
OPNsense 23.1.5_4-amd64
FreeBSD 13.1-RELEASE-p7
OpenSSL 1.1.1t 7 Feb 2023
The script stop but  i dont know what is missing.
root@Smartnet:~ # fetch -o - https://git.io/j7Jy | sh -s

                                                7687  B 6666 kBps    00s

sh: mongod: not found
Mounting new filesystems... done.
Removing discontinued packages...
Usage: pkg lock [-lqy] [-a|[-Cgix] ]
pkg lock --has-locked-packages
pkg unlock [-lqy] [-a|[-Cgix] ]
For more information see 'pkg help lock'.
Usage: pkg delete [-DfnqRy] [-Cgix]  ...
pkg delete [-Dnqy] -a
For more information see 'pkg help delete'.
done.
Installing required packages...
packagesite.pkg                                       6712 kB 8799 kBps    01s
x packagesite.yaml.sig
x packagesite.yaml.pub
x packagesite.yaml
Package png-1.6.39 already installed.
Package brotli-1.0.9,1 already installed.
Package freetype2-2.12.1_2 already installed.
Package fontconfig-2.14.2,1 already installed.
Package alsa-lib-1.2.2_1 already installed.
Package mpdecimal-2.5.1 already installed.
Package python37-3.7.16_2 already installed.
Package libfontenc-1.1.4 already installed.
Package mkfontscale-1.2.1 already installed.
Package dejavu-2.37_1 already installed.
Package giflib-5.2.1 already installed.
Package xorgproto-2022.1 already installed.
Package libXdmcp-1.1.3 already installed.
Fetching : 100%    2 KiB   2.3kB/s    00:01
pkg: archive_read_open_filename(/tmp/.XXXXX): Unrecognized archive format
Failed to install the following 1 package(s): https://pkg.freebsd.org/FreeBSD:13:amd64/latest/
root@Smartnet:~ #
can help me someone Please.

#311 please try some of the other firmware
if those would work

i remark the error Paket (#AddPkg libpthread-stubs) out, and the install complete, but i cant login to my Ubiquiti Account, local all work fine.

even if remote is enabled? maybe something blocking the ports?

Having the same issue on opnsense

you may want try the newer firmware #311

Isn't it 7.4.156? That's what the script pulls in.

#319 should pull 7.4.154
#311 should have  7.4.156
will try to integrate that in #319 for testing


Preview issue while using x.com

Having an issue while generating a preview for,
https://x.com/premierleague/status/1690778132922396673?s=46&t=71tXBSvhA7KzNBMe05rQ4w
::::ERROR::::
AnyLinkPreview - Error in https://x.com/premierleague/status/1690778132922396673?s=46&t=71tXBSvhA7KzNBMe05rQ4w response (ClientException: Redirect loop detected, uri=/premierleague/status/1690778132922396673?s=46&t=71tXBSvhA7KzNBMe05rQ4w)

Twitter links are broken @sur950

Error while retrieving cache data => type 'Null' is not a subtype of type 'String'
AnyLinkPreview - Error in https://twitter.com/Add00w/status/1684578272464744453?t=xKHi896H3xg3o-4lXjVLPg&s=19 response (Redirect loop detected)

Same error here

It seems twitter changed something 😀

Same error here

It seems twitter changed something 😀

elon musk playing with us

Twitter links are broken @sur950

Error while retrieving cache data => type 'Null' is not a subtype of type 'String'
AnyLinkPreview - Error in https://twitter.com/Add00w/status/1684578272464744453?t=xKHi896H3xg3o-4lXjVLPg&s=19 response (Redirect loop detected)

Hi, It seems working for me. Can you give a try with the latest version & let me know the observations
any_link_preview: ^3.0.2

I am hoping the issue is resolved in the latest version. I am closing the bug with the same expectations.
Feel free to log a new one if the issue persist, Thanks!


Capability to manage sessions from the Dashboard

The user portal should have the capability to

view the active sessions
delete a selected session

Fixed with https://github.com/wso2/product-is/pull/6197


Demo body mesh result with FastMETRO-S-R50

Thank you for sharing your work.
I followed your instruction in the Demo section and I got the same result with FastMETRO-L models.
However, predicting the body mesh with FastMETRO-S models is very strange.
I changed args.model_name to FastMETRO-S before running the demo.
Do I need to change anything else? Can you please take a look at it?

ah I found that I need to change the backbone to resnet50.


Theconfig.json

How to use config.json in jar? I don't want to configure it outside, like in the Src / main / resources directory


Supportig a hidden model functionality

Dear @nevadskiy
Thank you for your package!
Amazing job!
I use it in my project, and it very useful for me!
I have an issue about supporting a hidden model option
My example is:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

use Nevadskiy\Translatable\Strategies\ExtraTableExtended\HasTranslations;

class OrderType extends Model
{

   protected $translatable = [
		'name',
		'description',
	];

  protected $hidden = ['description'];
}
?>

A almost of times I don't need to have a description field in the json response.
But sometime I need it.
The first question is:
Can I change dynamically a $translatable attribute?
The second question is: is your package support a $hidden  models attribute?

Thanks buddy, @mcmc4519.

You actually do not need to dynamically set $translatable attributes.
My package should work fine with $hidden attributes, however, I recommend you to do it in another way.

Take a look at Json Resources: https://laravel.com/docs/eloquent-resources.

@nevadskiy  thank you a lot, man!
I solved my task by json resource!


Add Python support

Bringing Python support from original Dropbox-managed repository almost as-is and added some integration tests for it.

Since this is required for https://github.com/cross-language-cpp/djinni-support-lib/pull/24, I would say we pull it in and prepare a new release. I have some success on my local mach with that, for both,  Linux and Mac.
I think these PRs should be done in a way leading us to 1.0.0,
maybe a 0.99.0 , and once everything is fine we change both , generator and support lib , to 1.0.0 .. ?

We haven't talked about a versioning concept in djinni yet but I think we should stick to semantic versioning. I would be fine with making an exception to send a signal that "we are feature complete now", but personally I'd like to wait with that until C# support is also in master.

First of all: Super cool, @freitass! Thanks for your contribution!!!
I am missing documentation on about how the djinni integration works:

"Interface Definition Language (IDL)":

Updated example listings to include +p modifier
Datatypes: How do C++ types map to Python types (date, map, ...)?
Exceptions: How does the Python integration handle Exceptions?

"Using the generator": Documentation of existing command line parameters (basically the same information that is output by djinni --help.
"Use generated Code":

What files are generated?
A bit of background how the Python <-> C++ interaction works. I am aware that this is new for us all so I think it cannot be super in-depth, but a few sentences would help me and hopefully others to understand what is going on.

You can find the Markdown-files that generate the documentation in docs.

At a first glance the only missing feature in the generator seems to be the ability to set a header import prefix for the support-lib (equivalent to --jni-base-lib-include-prefix. Do you plan to add it?

We don't have any new features planned for Djinni, but it'd be cool to have that option to make it similar to the other languages!

I am migrating the C# support in parallel and I have a feeling like the python integration is so much more complex... 😮

Indeed! It'll be much harder to document Python in https://djinni.xlcpp.dev/djinni-generator/generated-code-usage/. I believe that's our only big piece of documentation missing right now.

Hi.
First, good job man, very thanks for that. Im reading the files changes to review and have two questions:

The cwrapper output files can be work with other things like flutter or is specific for python?
The yaml files can be used with python generator too?

Thanks.

@jothepro I believe we've improved all points mentioned in this comment, can you confirm?

and I agree, let's bring that to master, we then can enable uint tests for the support lib and start iterating over the states of both.
maybe we will also get additional testers when its there to use ....

👍 ok, @freitass I'll wait for you to merge my PR and answer my question. Once I got your response I will merge into master and make a release. Then we can start focusing on the support-lib.

what we would need would be something like a latest generator build, to download, because now the support lib still doesn't have any way to get it (accept, getting the code and building it at every PR, what is not optimal)
@jothepro , do you see an easy way to always have a latest to download after a merge into master?

I don't see a problem there (yet). I think it is a good design decision to make the support-lib depend on a specified release version instead of an undefined 'latest' state of the generator.
No, I do not have a decent idea for that right now.

this means, we need a release now to run the unit tests ....
and if we (would) need one or 2 fast iterations for fixing things in the generator/support lib , this would mean one or 2 fast releases for nothing ... I think  I need to think about that
.... latests would not be undefined, it's the latest .... maybe attaching it as artefact to a gh action , we will see

Do you know wether record extension is supported in Python? It's not mentioned in the docs.
I found some more autogenerated headers that were still missing a "was". I've made a PR for this.

Check and check! ✅


fix: Landing page is cropped

Landing page is not fully visible.

@Buddhad  would you mind tagging this issue with hacktoberfest and assigning this to me?

Need to fix this issue

Content in the upper header is not visible


Right click context menu is causing app to hang.

Description
Full freeze when right clicking on any item in the item view (sidebar works fine).
Steps To Reproduce

Right click on an any item in the item view

Requirements
Should open context menu.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.2283
Log File
debug.log
debug.txt
debug_fulltrust.txt

Thanks for the report, Can you send a screenshot of Windows File Explorer full (in the Show more) context menu

Is this still an issue in the preview version? https://files.community/download/preview

Preview appears to be working

Great! The fix will be included when v3 is released.


x/tools/gopls: cannot import public symbols defined behind build tags

Please answer these questions before submitting your issue. Thanks!
What did you do?
I created a proof of concept repo for this, https://github.com/perrito666/goplshatestags
I find this being reproduced on VSCode (the way I use gopls) I basically have a file inside a package that has a build tag // +build unit that declares public test helper functions

When importing said package from the tests of other packages, gopls complains about the functions not being declared in the package
When using things from one test file into another within the same package, everything declared behind the tags also fails to be found by gopls.
I added the tag to every possible configuration where it fits and the problem persists, I suspect gopls is at fault

I also suplied the log in https://github.com/perrito666/goplshatestags/blob/v0.1.1/goplslog.log
What did you expect to see?
At least "go to definition" of my functions defined behind tags
What did you see instead?
I think the actual error is:
[Error - 4:48:17 PM] Request textDocument/definition failed.
  Message: getting file for Identifier: no PackageHandles
  Code: 0

Build info
golang.org/x/tools/gopls 0.4.0
<EMAIL_ADDRESS>h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
<EMAIL_ADDRESS>h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
<EMAIL_ADDRESS>h1:DUwLyMDMUauGMd9kSLIlhhYJNELm06HuxeBdkFkeax4=
<EMAIL_ADDRESS>h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
<EMAIL_ADDRESS>h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=
<EMAIL_ADDRESS>h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=

Go info
go version go1.13.8 darwin/amd64

Fixed by adding GOFLAGS=-tags=unit to the config


Document usage with combineReducers

I have a store that is made with combineReducers, sometimes more than one level deep, which looks  something like
{
    a: ...,
    b: ...,
    c: {
         c1: ...,
         c2, ...
    }
}

where each of the named entries is made from reducers that generally look like
(state, action) => ({
     ...state,
     foo: action.payload
});

So if I have a selector that look at state.a.foo or state.c.c2.bar, will the memorization work correctly here?  The top of the state is new objects, but those hold old objects.  Since I am creating new objects, I was initially concerned that this would result in frequent recalculations, even when the state did not change.  Thinking about it some, I am pretty sure that what happens in the equality check is the selected parts of the state are compared, so if one state.a.quz changed, then the above selector would not run.
Since this is (I think) a common style, it would be useful to include an explicit mention of it as a technique that does (or does not) work.

I don't think combineReducers is relevant to use of selectors, really.  It's just a question of whether all parameters to the selector function are === to the last time it was called, or not.


S3 actions right after bucket creation: handle 307 redirects

As seen in #28: if you create a bucket anywhere but us-east-1 and immediately try to upload objects to it, you'll get a 307 temporary redirect.  Hyper appears to follow that but the message body does not get re-sent, hence the errors I saw where AWS calculated a body payload of empty string.
This ticket is for reproducing this behavior locally and verifying it's a bug in Hyper, then giving them an easy repro in a ticket.

Confirmed it's a bug in Hyper's client: https://github.com/hyperium/hyper/issues/641

While we may be able to get around some of these issues by implementing S3's expect 100-continue behavior, it may not help with, say, changing bucket settings.
If we don't get a fix from Hyper we'll have to manage the retry ourselves.  Which means explicitly not following the redirects and handling that in signature.rs.  That'd be a good candidate for refactoring signature into the signing part and the request part.

The "retry ourselves" mechanism is the way to go.  Using boto as an example, the python httplib they use does not follow 307 redirects.  I tested this with the local Go server mentioned in the Hyper issue above and this Python 2 code:
import httplib, urllib
params = urllib.urlencode({'spam': 1, 'eggs': 2, 'bacon': 0})
conn = httplib.HTTPConnection("localhost:8080")
conn.request("GET", "/", params)
response = conn.getresponse()
print response.status, response.reason
data = response.read()
conn.close()

This means the boto library is handling it instead of its client.

Copy/paste from Slack: response body will look like this:
Error>TemporaryRedirect<Message>Please re-send this request to the specified temporary endpoint. Continue to use the original request endpoint for future requests.</Message><Bucket>rusoto1441045966</Bucket><Endpoint>rusoto1441045966.s3-us-west-1.amazonaws.com</Endpoint><RequestId>08DB1CC6602DEFA2</RequestId><HostId>lZYOlF9QwVQS2ach8RWVWxvFmfbX+HvNT0K/DgDN2d+qMQO7KFcPIn3YnqY2knbH96FMrN3JX7o=</HostId></Error>

This code got removed - this should be retested, as I think this issue is happening again.  Reopening to test again.

We're still good: I bet the DNS-compatible bucket name changes covered this by sending to a different endpoint.  See https://github.com/rusoto/rusoto/pull/422 .