Ensure that mean and standard deviation are broadcastable in standardization preprocessors

Description
This PR adds functionality that aims to catch situations where the mean and standard deviation are not broadcastable w.r.t. to the input batch. It then reshapes the mean and standard deviation such that addition and division operations in the standardization preprocessors work properly.
Fixes #268, #569
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)

Testing
Test Configuration:

Fedora 33
Python 3.8.7
ART 1.6.0 development

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #839 (414f5a5) into dev_1.6.0 (4b769ad) will decrease coverage by 14.04%.
The diff coverage is 75.75%.

@@              Coverage Diff               @@
##           dev_1.6.0     #839       +/-   ##
==============================================
- Coverage      65.63%   51.58%   -14.05%
==============================================
  Files            176      177        +1
  Lines          17105    17120       +15
  Branches        3157     3159        +2
==============================================
- Hits           11227     8832     -2395
- Misses          4635     7391     +2756
+ Partials        1243      897      -346

Impacted Files
Coverage Δ

...tors/certification/randomized_smoothing/pytorch.py
46.42% <ø> (ø)

...s/certification/randomized_smoothing/tensorflow.py
34.69% <ø> (ø)

art/estimators/classification/GPy.py
71.42% <ø> (ø)

art/estimators/classification/blackbox.py
83.87% <ø> (ø)

art/estimators/classification/catboost.py
67.34% <ø> (ø)

...t/estimators/classification/detector_classifier.py
90.47% <ø> (ø)

art/estimators/classification/ensemble.py
66.25% <ø> (ø)

art/estimators/classification/keras.py
57.86% <ø> (-17.22%)
:arrow_down:

art/estimators/classification/lightgbm.py
75.32% <ø> (ø)

art/estimators/classification/mxnet.py
14.70% <ø> (-40.69%)
:arrow_down:

... and 63 more

Codecov Report

Merging #839 (414f5a5) into dev_1.6.0 (4b769ad) will decrease coverage by 14.04%.
The diff coverage is 75.75%.

@@              Coverage Diff               @@
##           dev_1.6.0     #839       +/-   ##
==============================================
- Coverage      65.63%   51.58%   -14.05%
==============================================
  Files            176      177        +1
  Lines          17105    17120       +15
  Branches        3157     3159        +2
==============================================
- Hits           11227     8832     -2395
- Misses          4635     7391     +2756
+ Partials        1243      897      -346

Impacted Files
Coverage Δ

...tors/certification/randomized_smoothing/pytorch.py
46.42% <ø> (ø)

...s/certification/randomized_smoothing/tensorflow.py
34.69% <ø> (ø)

art/estimators/classification/GPy.py
71.42% <ø> (ø)

art/estimators/classification/blackbox.py
83.87% <ø> (ø)

art/estimators/classification/catboost.py
67.34% <ø> (ø)

...t/estimators/classification/detector_classifier.py
90.47% <ø> (ø)

art/estimators/classification/ensemble.py
66.25% <ø> (ø)

art/estimators/classification/keras.py
57.86% <ø> (-17.22%)
:arrow_down:

art/estimators/classification/lightgbm.py
75.32% <ø> (ø)

art/estimators/classification/mxnet.py
14.70% <ø> (-40.69%)
:arrow_down:

... and 63 more

@beat-buesser Thanks for your feedback. I have added your proposed change. Especially the addition of lazy attributes for broadcastable mean and standard deviation. PR has been rebased accordingly :rocket:

Hi @hesseltuinhof Thank you very much! This will make a long standing issue easier to solve!


Use maven wrapper completly in travis builds

Pull Request Test Coverage Report for Build 263

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.827%

Totals

Change from base Build 260:
0.0%

Covered Lines:
220

Relevant Lines:
237

💛  - Coveralls


Add BearLibTerminal backend

See TODOs in diff for questionable stuff :P

OMG it works

Why wouldn't it? :P


Constraint Name Length

Recently one of the emrestjs test cases start failing and it is showing a 409 error. After investigating the problem, it seems like the constraint name for key has a maximum length.
After changing the constraint name to something shorter, the request passes successfully and doesn't throw the 409 error.

Here's the CURL request for the same.
curl -X POST \
-d '{"comment":null,"kind":"table","entityCount":0,"keys":[{"comment":null,"annotations":{},"unique_columns":["column_without_display_annotation"]}],"foreign_keys":[],"table_name":"table_with_titlecase_without_underlinespace","schema_name":"schema_with_underlinespace_without_titlecase","column_definitions":[{"comment":null,"name":"column_without_display_annotation","default":null,"nullok":false,"type":{"typename":"serial4"},"annotations":{}},{"comment":null,"name":"column_with_underlinespace_without_titlecase","default":null,"nullok":false,"type":{"typename":"serial4"},"annotations":{"tag:misd.isi.edu,2015:display":{"name_style":{"title_case":false,"underline_space":true}}}}],"annotations":{"tag:misd.isi.edu,2015:display":{"name_style":{"title_case":true,"underline_space":false}}}}' \
-H "Cookie: webauthn=23PHiyiZx0WIewUdiUeyjNvx" \
https://dev.isrd.isi.edu:443/ermrest/catalog/18093/schema/schema_with_underlinespace_without_titlecase/table

RESPONSE
409 Conflict
The request conflicts with the state of the server. cannot drop index schema_with_underlinespace_without_titlecase.table_with_titlecase_without_underlinespace_column_without_disp because constraint table_with_titlecase_without_underlinespace_column_without_disp on table schema_with_underlinespace_without_titlecase.table_with_titlecase_without_underlinespace requires it
HINT:  You can drop constraint table_with_titlecase_without_underlinespace_column_without_disp on table schema_with_underlinespace_without_titlecase.table_with_titlecase_without_underlinespace instead.

OK, it sounds like the name is being truncated and so what we think will be distinct names are instead colliding.
This will take some ugly revisions to how ERMrest names indices and constraints if we want to fully insulate ourselves from this.  I'm not sure it is worth it, as we still expose many other Postgres identifier length limitations as well.
Since you have a workaround (use shorter names) I am going to leave this as a low priority bug...

FYI I've developed some fixes for this but as part of an ermrest feature branch that will not be merged for a while yet.  It seemed like it would interact with too many lines of code that have changed for this branch, so I didn't want to do it in master and then sort out the ugly merge conflicts...
The new code will reject user-supplied identifiers that exceed 63 bytes after UTF-8 encoding, and our internally-generated identifiers for DB indices will also adapt to make sure we don't exceed 63 bytes when concatenating several names together.  It will fall back to using truncated hashes of names if necessary to save space.

The fixes described above are part of PR #152

I don't think there is anybody around who really plans to review this, and the ID length enforcement is now tested in the new test/resttest/degenerate.py LongIdentifiers test class, so I am just going to close this old issue...


Call winLoad directly if document is loaded

When using RequireJS the document may already have loaded everything when this script gets executed. This will cause the load event to never be triggered, bypassing the whole initialization. This PR adds a check for the document's ready state and calls the winLoad method directly if the document has already loaded.

Thank you 👍


Rainbow colours program in c language

@Amber-Mishra-2003 contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


Increase resolution of favicon

Ours is pretty low res compared to others

This was fixed. Icons looking good!


Revise abstract

Closes #91

Oops, sorry I was reading the lines removed, not the lines added.  You're right that wording is no longer there.  However the new wording has the same issue - "A WebID is a way to identify oneself".  How about changing that "to identify a person or organization"?


Added Google Finance Integration

This PR ports the Google Finance Tool from LangChain Python to LangChainJS. Google Finance Tool allows your agent to utilize the Google Finance API to retrieve financial data, such as stock prices, market trends, exchange rates, and other investment-related information from Google Finance. We've added/modified the following files:

docs/core_docs/docs/integrations/tools/google_finance.mdx: Site docs
examples/src/tools/google_finance.ts: Example usage
libs/langchain-community/langchain.config.js: Added entrypoint for our tool
libs/langchain-community/src/tools/google_finance.ts: The Google Finance Tool
libs/langchain-community/src/tools/tests/google_finance.int.test.ts: Integration tests for the tool

Example Usage:
import { GoogleFinanceAPI } from "@langchain/community/tools/google_finance";
import { OpenAI } from "@langchain/openai";
import { initializeAgentExecutorWithOptions } from "langchain/agents";

export async function run() {
  const model = new OpenAI({
    temperature: 0,
    apiKey: process.env.OPENAI_API_KEY,
  });

  const tools = [new GoogleFinanceAPI()];

  const financeAgent = await initializeAgentExecutorWithOptions(tools, model, {
    agentType: "zero-shot-react-description",
    verbose: true,
  });

  const result = await financeAgent.invoke({
    input: "What is the price of GOOG:NASDAQ?",
  });

  console.log(result.output);
}

Sample Output:
{
  "markets": { … },
  "summary": {
    "title": "Alphabet Inc Class A",
    "stock": "GOOGL",
    "exchange": "NASDAQ",
    "price": "$89.23",
    "extracted_price": 89.23,
    "currency": "$",
    "price_movement": {
      "percentage": 1.6750242,
      "value": 1.4700012,
      "movement": "Up"
     }, … },
  "graph": [ … ],
  "knowledge_graph": { … },
  "news_results": [ … ],
  "financials": [ … ],
  "discover_more": [ … ]
}

Hey @jacoblee93 , sorry to bother you but do you think you could review this when you get a chance? Thanks in advance!


Support FP16 CpuAdam + Zero Stage 3

Add support for FP16 CpuAdam + Zero Stage 3

@microsoft-github-policy-service agree

@lz1oceani, thanks for the PR. Can you please some description of the motivation and content of this PR? Thanks!

Motivation: Zero-stage3 requires all data to be stored in fp32 on the CPU, including weights, gradients + accumulated version, and optimization states. A 7B model needs 7 * 5 * 4 = 140GB of CPU memory, and this doubles for a 13B model. However, our cluster's memory is not often sufficient, as it typically runs additional jobs. To address this, I developed a fp16 version for Zero-stage3, providing robust optimization states, drawing inspiration from this paper.
Implementation: The original CPUAdam code partially supported fp16 weights but had bugs. I've added support for fp16 optimization states and corrected the fp16 weight support issue. For details, it is better the check the code.
I have check the code by fine-tuning Llama-7b. It can successfully converge.

@lz1oceani, thanks. I have moved the description to the OP.


[BUG] README should not reference timeout/retries

The problem
README still references timeout/retries
It should instead reference appiumRequestTimeout/implicitWaitTime
Environment

Conductor-Mobile Version: 0.19.1

Fixed in 9b5f7eca175e31df05cf0651dcd0ca501e2805c3

Merged in #136

Fully fixed in ec5791aa9336bc2ca708ee1c434ef628734ed6d9


fedoraware crashing with new update

Fedoraware Version Date:
latest
Description:
i inject and it just crash!!


Follow and Unfollow nostr contacts

Closes #1068
This has the base functionality needed for following and unfollowing. Tried to do my best to prevent us from deleting a follow list. ~One thing with this is there is potential race conditions if you call follow/unfollow in rapid succession. Could add a mutex around adding follows but that feels a little overkill, maybe will have to bite the bullet though~
@futurepaul I imagine you'll want some extra utility around this. I was thinking of adding is_followed to TagItem. Is there anything else I could add that you can think of?

Added is_followed to TagItem and added a get_follows_sorted to mutiny wasm for @futurepaul


Support of PostgreSQL 10

Q
A

Bug?
no

New Feature?
yes

Sulu Version
1.6.21

Browser Version
-

Actual Behavior
Sulu doesnt support PostgeSQL 10. Its not possible to update doctrine/dbal to at least 2.7.0.
If you try to use Sulu with PostgreSQL 10 you get error because of the new sequence-structure:
An exception occurred while executing 'SELECT min_value, increment_by FROM "ca_categories_id_seq"':
SQLSTATE[42703]: Undefined column: 7 ERROR:  column "min_value" does not exist
LINE 1: SELECT min_value, increment_by FROM "ca_categories_id_seq"
^
Expected Behavior
Sulu should also support the newest version of PostgreSQL/ doctrin/dbal2.7.0 at least

Hello @ichdertobi,
there where breaking changes in the doctrine/orm 2.6 release, which will keep us using doctrine/orm 2.5 for the 1.x series (#3696). So if you needed postgresql 10 you should wait for 2.0 release or try a current alpha version of sulu 2.0. As we can't change this for the 1.x series I will close this issue.


[DOCS-43] Set up pentest checklist

After user "Save and Exit", before "Submit for Review"

Reviewed internally over Slack by<EMAIL_ADDRESS>


Unable to edit description on my resource

Observed/problematic behavior
Edit button is not displaying on my resource
Expected behavior
Edit button should display on my resource
Steps to reproduce
Create a resource. I used the Markdown to BBCode converter, I think that might have caused the issue since this does not happen on my other resource which I did not use it for.
Other

https://github.com/HangarMC/Hangar/blob/master/backend/src/main/java/io/papermc/hangar/model/common/roles/ProjectRole.java#L19

I still don't have an edit button – can anyone reproduce? 🙂

Update: Mini and I discovered I have the permission string 111 for that resource page.
Link to conversation on the Hangar Discord

https://hangar.papermc.dev/api/v1/permissions?author=lokka30&slug=WWWWWWWWWWWWWWWWWWWWWWWWW
misses edit perm

fixed

Thanks, fixed on my end 👍🏻


ISPN-4123 Remote Query tests random failures

Jira: https://issues.jboss.org/browse/ISPN-4123

Tests continue to fail randomly. Investigating ...

pulling...


Create README.md

Dear Richard, I noticed you have no README file, so I thought I'd at least start one, so people might know what this does. I did link it in the blog, so there should be some information.

thx!


feat: edition in reorganize-line dialog

@yannick-aneo I update how button render in the dialog in order to have something more readable.


Bluetooth: controller: Decorrelate address generation from resolution

Changes related to Bluetooth TSE 11068.
Fixes BT LL TS 5.1.0 test:
LL/SEC/ADV/BV-03-C [Privacy - Non-connectable Undirected
Advertising, Resolvable Private Address]
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

Do we need to back-port this @cvinayak @carlescufi ?

Do we need to back-port this @cvinayak @carlescufi ?

Should already be part of the Conformance Fixes backports


Fix bug with @-ms-viewport

Currently @-ms-viewport gets the selector nested inside of it, i.e.
@-ms-viewport { width: device-width; }

compiles to
@-ms-viewport { .selector { width: device-width; } }

Moreover, if the selector is empty then it compiles to invalid CSS:
@-ms-viewport { { width: device-width; } }

This PR adds failing test cases for this. However, I could not see how to fix it. Hopefully somebody who knows the codebase a bit better can contribute this part.

@thysultan Any pointers on where to start looking to fix this?

We do something similar for @font-face and other "flat" at rules.

@thysultan do we want to support this non-standard rule in v4? I've checked and we have a similar issue when parsing @-webkit-keyframes because of those two hitting currently this case rather than the default one

Fixed in https://github.com/thysultan/stylis.js/commit/1a852159966f7078b43e0ae0918526425f8f0d6f


[BUG] 1.7.3 throws exception in queue

1.7.3 throws exception in queue:
System.ArgumentException:  Invalid priority .
   at Crestron.SimplSharpPro.CrestronThread.Thread.set_Priority(eThreadPriority value)
   at PepperDash_Essentials_Core.Queues.GenericQueue..ctor(String key, eThreadPriority priority)
   at PepperDash_Essentials_Core.Queues.GenericQueue..ctor(String key)
   at Epi.Display.Lg.LgDisplayController..ctor(String key, String name, LgDisplayPropertiesConfig config, IBasicCommunication comms)
   at Epi.Display.Lg.LgDisplayControllerFactory.BuildDevice(DeviceConfig dc)
   at PepperDash.Essentials.Core.DeviceFactory.GetDevice(DeviceConfig dc)
   at PepperDash.Essentials.ControlSystem.LoadDevices()
   at PepperDash.Essentials.ControlSystem.Load()
   at PepperDash.Essentials.ControlSystem.GoWithLoad()
   at PepperDash.Essentials.ControlSystem.StartSystem(Object obj)
   at Crestron.SimplSharp.CTimer.a(Object A_0)
   at System.Threading.Timer.ring()

Originally posted by @ngenovese11 in https://github.com/PepperDash/Essentials/issues/560#issuecomment-768454318

see #560 for discussion on what priority to set

see #560 for discussion on what priority to set

@ngenovese11 Please check build 1.7.4-hotfix-1096 once it's complete to verify that this is the fix.

@ngenovese11 Please check build 1.7.4-hotfix-1096 once it's complete to verify that this is the fix.

k loading now

k loading now

@ngenovese11 any updates?

@ngenovese11 any updates?

just loaded it up and no exceptions

just loaded it up and no exceptions


python3Packages.pywemo: init at 0.6.4

Motivation for this change
Python module to discover and control WeMo devices
https://github.com/pywemo/pywemo
This is a Home Assistant dependency.
Depends on https://github.com/NixOS/nixpkgs/pull/113382
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116256 run on x86_64-linux 1

2 packages built:

python38Packages.pywemo
python39Packages.pywemo

Result of nixpkgs-review pr 116256 at 872740b9 run on aarch64-linux 1

2 packages built successfully:

python38Packages.pywemo
python39Packages.pywemo

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116256 run on x86_64-linux 1

2 packages failed to build and are new build failures:

python38Packages.pywemo: plain log  |  pretty log
python39Packages.pywemo: log was empty

Result of nixpkgs-review pr 116256 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pywemo
python39Packages.pywemo

Result of nixpkgs-review pr 116256 run on x86_64-linux 1
2 packages failed to build and are new build failures:
* python38Packages.pywemo: [plain log](https://termbin.com/iym3y)  |  [pretty log ](https://htmlpreview.github.io/?https://gist.githubusercontent.com/SuperSandroBot/83931d74950335faf92df6c93ddba669/raw/index.html)

* python39Packages.pywemo: log was empty

Cannot reproduce this test failure.

@build python3.pkgs.pywemo

ofBorg can repro that test failure as well. Can you look into why that could happen?

@GrahamcOfBorg eval

Please rebase onto a more recent version of master.

Can't repro on rpi4 nor any x86_64 box I have here. Maybe time for an upstream report?

Result of nixpkgs-review pr 116256 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pywemo
python39Packages.pywemo

@ofborg eval

Result of nixpkgs-review pr 116256 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pywemo
python39Packages.pywemo

@GrahamcOfBorg test home-assistant


[Feature request] Support search tags that do not have value for AMI lookup

What is this about?
It is a good practice to use the latest_ami_by_tags feature to look up one AMI by its tag. For example:
web_ami:
  latest_ami_by_tags: role=web,application=myapp

However I learn that if you have a tag pair that has no value and the stack definition you omit the value part, the parser would error:
web_ami:
  latest_ami_by_tags: a_valueless_tag

It would be nice if the above format is accepted

As a workaround this will probably work:
web_ami:
  latest_ami:
    filters:
      tag:a_valueless_tag: ""


Add created keychain to search list in create_keychain action

New keychains need to be added to the search list if you want codesign to find the identities they contain. I don't know any reason not to add the new keychain to the search list, so I think this should be done by default.

security list-keychains -s /path/to/my.keychain

this is not a safe way of adding additional keychains to the search list.
It will simply replace the current login.keychain with my.keychain in the keychain search list.
A simplier way to do that is to run:
open /path/to/my.keychain

this will keep login.keychian in the search list and add the new keychain to the search list.

The keychain is appended to the search list and doesn't replace the current contents.
Using the open command and launching the Keychain Access application is unnecessarily intrusive in my opinion and won't work on a headless system.

That is a good point, I'm concerned of losing the login.keychain from the search list, see my tests below:
# initially
$ security list-keychains
    "/Users/ngh/Library/Keychains/login.keychain"
    "/Library/Keychains/System.keychain"

# add the keychain
$ security list-keychains -s /path/to/my.keychain

# list the result
$ security list-keychains
    "/path/to/my.keychain"
    "/Library/Keychains/System.keychain"

The safe way to do it is to add the login.keychain with the new keychain.
# initially
$ security list-keychains
    "/Users/ngh/Library/Keychains/login.keychain"
    "/Library/Keychains/System.keychain"

# add the keychain
$ security list-keychains -s /path/to/my.keychain ~/Library/Keychains/login.keychain

# list the result
$ security list-keychains
    "/path/to/my.keychain"
    "/Users/ngh/Library/Keychains/login.keychain"
    "/Library/Keychains/System.keychain"

What do you think ?

Yes, we need to keep the current keychains in the search list. That's what the pull-request does. It first gets the current list, then adds the new keychain the array, then set the the search list to the result.

Excellent job :+1: Thanks for pointing that out, I missed missed that line of code.

I tested your action, it seems the code that joins the array of keychains is not creating the desired command arguments:
In my case it was running this command in the end
security list-keychains -s \[\"/Users/ngh/Library/Keychains/login.keychain\"\] /Users/ngh/Library/Keychains/test

expected to be:
security list-keychains -s /Users/ngh/Library/Keychains/login.keychain /Users/ngh/Library/Keychains/test

or I'm missing something ?

Instead of this
keychains = []
keychains << Fastlane::Actions.sh("security list-keychains -d user", log: false).shellsplit unless Helper.test?

use
keychains = Fastlane::Actions.sh("security list-keychains -d user", log: false).shellsplit unless Helper.test?

You're right. I used the wrong operator when refactoring my code. My bad.

@KrauseFx please review this patch for the create_keychain action

Thanks, added some comments, let me know once it was updated :+1:
Thanks for your contribution @baarde

@baarde could you please make the proposed adjustments, your changes are too good to be left here :)

Thanks @baarde. @xfreebird Could you confirm this works for you?

@KrauseFx it works for me :+1:

Great, thanks everyone! :+1:


CI continue falling on "Failed to install: hg is not installed"

You need to install mercurial to make it works.

Can you link to a failing job? Maybe is a matter of adding what ever is missing in the *.packages file?

@ifireball http://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/138/


Change logout request to use POST

Changes logout to do a POST request and removes the need for LogoutRoute.
How to verify

Checkout this branch.
Build it ($ npm run build).
Link it ($ npm link).
Checkout the feature-login-should-be-post branch of express-stormpath.
Link it ($ npm link).
Checkout the the React example app.
Link to our React SDK feature branch ($ npm link react-stormpath).
Link to our Express feature branch ($ npm link express-stormpath).
Open up app.js.
Remove the LogoutRoute from the router.
Start the app ($ npm start).
Navigate to /login.
Login as an existing user.
Open up the network console.
Click the logout button.
Verify that you're redirect to the home route and that a POST request to /logout is made.
Verify that you're logged out.

Fixes #40.

I've verified that everything works as it should, but please see my comment regarding sending null to the server.

@timothyej This is now fixed. Please review/merge :)

@timothyej Thanks! Merging this in now! :)


disallowCommaBeforeLineBreak incorrectly errors on a function declaration

This bug applies to current latest master as of time of writing. I believe it was introduced by this commit: https://github.com/jscs-dev/node-jscs/commit/cd8ce2e36b4c7fece12ad33cc7e7709ff71fd561 (PR #1410).
Last seen working in version 1.9.0.
With the disallowCommaBeforeLineBreak rule set to true, jscs tells me that there is a style error with a a function declaration, see the following screenshot:

Or more simply:
function a(b,c) {
}

I have written a failing test case here:
https://github.com/bengourley/node-jscs/commit/e12bfb3b0f87e1a38be302f758f31c2cbc1f8a94

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26392657-disallowcommabeforelinebreak-incorrectly-errors-on-a-function-declaration?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

cc @dreef3

@bengourley Can you check if https://github.com/jscs-dev/node-jscs/commit/6571ebbbf29e5b96be45ade585e4676de3c2817d fixes it? We'll try to release 2.3.0 tomorrow.

@hzoo Thanks for the update. I tried this and it doesn't appear to have changed the behaviour in my case.

Always weird to have a rule using tokens. Also odd to have added that and no tests fail

I can make a simple fix for function params but I think we need this rule is really brittle after adding errors.assert.differentLine({ and counting on canSkip @dreef3


adding footer

I have added the footer
before:

after:

did the changes as asked
before:

after:

I've moved the base.html file in #177 so you will need to rebase/merge - sorry!


In the wiki's Filter Expressions "Quick Start" guide, due needs a trailing colon

Bug Report
Important
App Version: v2.0.8
Platform: Linux
Installation Method: deb
Bug Description:
Most of the examples in the wiki's Filter Expressions "Quick Start" guide don't work. It appears that they work if you add a trailing colon after due, though.
For example, this is what's in the guide, but doesn't seem to work: +bills and due < tomorrow. Here's how I'm pretty sure it needs to be currently +bills and due: < tomorrow
Solution (easy, preferable): update that guide to include the colon suffix.
Solution (hard, maybe better? probably not though): make it so that due date filters work without a colon after due.
Guide in question: https://github.com/ransome1/sleek/wiki/Filter-Expressions-for-Advanced-Search

Good catch, @DeflateAwning .  The original syntax of the filter expression language used due and t as keywords, and so it was documented that way.  Then I modified the syntax in PR #435 to require the colon after the keyword, because people were having trouble matching freeform text that started with t (issue #311).  Unfortunately, we didn't update the filter expressions doc.  The right thing to do now is to update the doc.

@DeflateAwning I just made a pass to update the wiki page with the correct new syntax.  Please let us know if you still see any broken examples in there.  Thanks for spotting this issue!  Please close this if you agree that the wiki page is now fixed.

@zerodat I scanned the wiki page quickly. As of now most of the attributes can be used in a consistent way such as due: > today or rec: == d.
However for the priority we're going a different route, if I'm not mistaken. Instead of pri: == A, which would be consistent I'd say, users have to type pri == A without the colon.
I cannot recall all our past discussions but was this a deliberate choice?

Regex matching doesn't seem to work for me, example: /.*window.*/. This matches nothing, but I have four todos with the word window in them. If I just type window into the search field, I catch them all.

Another example: window +sleek matches nothing, but I have three todos with the word window in them that have project +sleek assigned to them. window and +sleek doesn't show anything either.

And here's a third: due: <= tomorrow+1d doesn't match todos that are due the day after tomorrow. due: <= tomorrow works as expected.

Thanks for updating the wiki! This resolves my issue (as presented here), so I'm going to close this issue.
I'll propose that @andrei-a-papou opens a new issue if there are any related remaining issues with functionality (as opposed to documentation).

@ransome1 I noticed that pri(ority) doesn't have a colon as well.  This was the original syntax, and it didn't get changed when I changed t: and due:.  I think the justification is that pri: is not a tag in todo.txt, but rather part of the built-in syntax (A) etc.  So it seemed odd to put a colon after it like we did with the tag keywords.  You can match priorities just using (A) and so on, but if you need to check for inequality, like pri < D you would need the pri (or priority) keyword.  Personally, I don't care which way we do it, but that is the argument for leaving it as is.

@andrei-a-papou I've tried some of the tests that you described and it does seem to be broken in 2.0.  I think this worked properly in the later 1.x versions.  I'll take a look when I get time and try to figure out why it is broken.  It would be helpful if you could file a new issue about it, as @DeflateAwning suggested.  Thanks.


Merchant Token

Hi there
I have managed to get a response to create a merchant token by using curl instead of the library as it just doesn’t seem to work as expected. $getToken = $client->createToken($tokenOptions); does not return a pairing code if the façade is set to merchant. When I curl the same token options post fields I get the expected JSON response.
$token = $client->createToken(
array(
'facade' => 'merchant',
'label' => 'You can insert a label here',
'id' => (string) $sin,
)
);
The response I get from this if I var_dump($token) is…
object(Bitpay\Token)[12]
protected 'token' => string '9hR4TLG4pNrKfcNisKQCaPUGQaoJfGk751WobWDzaYXk' (length=44)
protected 'resource' => null
protected 'facade' => string 'merchant' (length=8)
protected 'createdAt' => float<PHONE_NUMBER>267
protected 'policies' =>
array (size=1)
0 =>
array (size=3)
'policy' => string 'id' (length=2)
'method' => string 'inactive' (length=8)
'params' =>
array (size=1)
...
Bitpay\Token Object
(
[token:protected] => 6ZTCn8eGSUxkN2DKj6gQWwJomBDWs3iAdpuwTZCvxsSe
[resource:protected] =>
[facade:protected] => merchant
[createdAt:protected] =><PHONE_NUMBER>057
[policies:protected] => Array
(
[0] => Array
(
[policy] => id
[method] => inactive
[params] => Array
(
[0] => TfGxA6bAyLC57CWEJ8U4dZc1SZinuqSRrEW
)
            )

    )

)
Where is the pairing code please??

Hi,
The pairing code will be in the client response, as in:
$response = $client->getResponse();
echo (string) $response.PHP_EOL.PHP_EOL;

It is not. I have posted the response received. There is no pairing code.

You posted the $token contents, but the pairing code will be in the $client->getResponse().


Geiger

Add Geiger to player
It should beep when based on proximity to a hazard.

Geiger added, need to add functionality to beep

Beep done. Needs a check to see if theres no barrels left and if so play nothing.


[FEATURE] Support referencing modules via git urls

Is your feature request related to a problem? Please describe.
Multiple teams using seed-farmer as the deployment mechanism would require a way to reuse modules from each other across different git repositories.
Describe the solution you'd like
Allow referencing modules via git urls including version/commit hash pegging. For example, see how terraform does this (https://www.terraform.io/language/modules/sources#github)
Allow specifying the module path as a git URL in the manifest:
name: networking
path: git::https://example.com/network.git//modules/vpc?ref=v1.2.0
parameters:
  - name: internet-accessible
    value: true
---
name: buckets
path: modules/optionals/buckets
parameters:
  - name: encryption-type
    value: SSE

Describe alternatives you've considered
Git subtrees can be used to get around this, although it bloats the code and adds much more complexity.

Proposal
rather than reusing the path attribute to reference either a local or git path, propose instead we add an optional git attribute to the Module Manifest
name: networking
path: git-modules/network/modules/vpc
git:
  repository: https://example.com/network.git
  branch: v1.2.0
parameters:
  - name: internet-accessible
    value: true

on seedfarmer apply the bundling and deployment of modules will:

check the local, relative path for the module code, if directory exists and is not empty, bundle and deploy the module
if the local, relative path directory does not exist or is empty, peform a git clone of the repository into top-most directory referneced in path (in this example git-modules)
reattempt to locate the module code by checking the local, relative path. if the directory exists and is not empty, bundle and deploy, else ERR

utilizing this workflow has a few advantages:

during module development the local, relative path will contain the module code being developed and tested. performing seedfarmer apply will utilize the local code
cloning into the top most directory referenced in path (here git-modules) and locating modules within sub-directories enables the git repository to contain more than one module. the repository will be cloned once when the first module references the directory
varying versions/branches of the same repository can be used for different modules by adjusting the top most directory, for example:name: networking
path: git-modules-1/my-repo/modules/networking/vpc
git:
  repository: https://example.com/my-repo.git
  branch: v1.2.0
parameters:
  - name: internet-accessible
    value: true
---
name: buckets
path: git-modules-2/my-repo/modules/buckets
git:
  repository: https://example.com/my-repo.git
  branch: v1.3.0
parameters:
  - name: encryption-type
    value: SSE

Interesting approach. I can see the appeal for adding local development support, but just to challenge some assumptions 😅😅😅😅😅😅😅😅 :

If we planned a module to be referenced via git, would that module not be developed in the referenced git repository directly? Why add the complexity of both local and remote support in one reference? As a developer, if I would like to develop locally in the same repo, I would just clone the module repo into the modules folder (as a git subtree) and work from that, changing the reference to be local instead of git.

Is the approach above truly code first & declarative? Since what gets deployed depends on what is available on a developer's local machine, there will be side effects which might be unexpected. Instead of declaring exactly what we expect to happen in the manifest, there is now branching logic built in so we can't be sure if what got deployed was something local or something remote.

The Terraform example above also supports having multiple modules in one git repo. The target module is specified using the double slash // notation followed by a path, for instance git::https://example.com/network.git//modules/vpc?ref=v1.2.0 which would expect the repo to contain a modules folder at the root and then a vpc subfolder.

- modules/
   | - vpc/

Why tie modules together (version/branch etc.) to the topmost directory if they get deployed independently on CodeBuild? Doesn't this remove a lot of flexibility? Why not just allow each to have its own path, making things much simpler? It means more clone requests, but each clone could reference whichever tag/version/branch they'd like.

What do you think?

unfortunately, due to the way deployment change sets, module roles, modulestack.yaml, and the deployspec.yaml are processed, all git referenced module code must be cloned locally to the CLI execution environment before being bundled and passed to CodeBuild. we are unable to simply clone the repository during CodeBuild execution. the proposal was an attempt at optimizing the CLI performance and module builder experience. though I agree it adds some complexity and ambiguity.
because we need to clone locally, a local path to clone into is required. we can either reuse the path attribute to determine where to clone into, or hide the cloned repository in the codeseeder.out/ directory. without a mechanism to declare and reuse the path to clone into, the CLI will have to locally clone the entire repo for each module. cloning would need to occur immediately so that we can dynamically determine which modules need to be deployed, this also includes a --dry-run. using the top most directory of the path was an attempt at reducing the number clone operations and cleanups locally. i suppose we could reduce this impact by limiting (or enabling restriction of) the cloning depth to 1.
from a module development perspective I was trying to reduce the round trips on the development cycle. if we don't enable an option to test deployment of a module from local source, then all changes must be added, committed, and pushed remotely before any integration/regression testing can occur. but I can see what you mean about changing the way development is done and doing a clone of the repo into the modules folder or another git-modules folder.

it might be possible to cache checkouts/clones per repository/ref in our codeseeder.out/ directory enabling some reuse of optimization. with that and shifting how i was thinking about the builder workflow, i think you've convinced me.


Fix header styles

Fix #772

@benekex2 Please rebase with master

As we discussed on the meeting - Mobile header view needs some improvements:

Add Menu string to Hamburger button
Reduce padding around Salor logo, to give more space to search button

Current coverage is 55.22% (diff: 100%)

Merging #783 into master will decrease coverage by 3.61%

@@             master       #783   diff @@
==========================================
  Files           111        110     -1
  Lines          5861       5816    -45
  Methods           0          0
  Messages          0          0
  Branches        718        708    -10
==========================================
- Hits           3449       3212   -237
- Misses         2273       2474   +201
+ Partials        139        130     -9

Powered by Codecov. Last update 2956dfc...70b10b1


Keyboard grinds to a halt when using Zulip

When using Zulip on two separate Android phones I have found that eventually the keyboard slows down to the point at which it is completely unusable.
I have tried clearing all background apps, or using a 'RAM booster' (Avast) but because the keyboard is a system app (I assume), it isn't 'cleared'.
It also affects other apps, I can't use the keyboard anywhere else after Zulip causes this issue, I have to restart the phone(s).
Android 10 & 11
Both OxygenOS
Both latest Zulip.
Stock keyboard (Gboard?)
It's only Zulip that causes this. If I use other apps, even for a long time (like google docs) there are no issues.
Does anybody have any suggestions? Has anyone come across this before?
I can only assume it has to do with the Zulip Drafts or something else taking up some system cache that I can't clear (easily).
Thank you.

Thanks for the detailed report, @easaw!
This reminds me of an upstream issue in React Native that we reported in 2018: https://github.com/facebook/react-native/issues/20119. But there are some symptoms that I think would be surprising if that's what's going on: I wouldn't expect it to affect keyboard performance in other apps, and I wouldn't expect it to be necessary to completely restart the phone.
Here are a few things I'd be interested to know, to help diagnose the issue:

You have probably already tried this, but would you please confirm that the keyboard is still slow in Zulip after closing Zulip completely (without restarting the phone) and then opening it again?

Does the keyboard slowdown only seem to happen after actually using the keyboard in Zulip? Or does it happen just after spending some time doing other things in Zulip that don't involve the keyboard, like reading messages?

It sounds like you run into a keyboard slowdown in all the apps you open after using Zulip for a while. Are you pretty certain that it really is all apps, and not just some (for example, those that were built with React Native)? How about Google Docs, which you've noticed doesn't seem to cause any keyboard problems itself?

Hi @easaw! Thanks for reporting this. I started seeing this as well recently, and will try to debug it. It seems pretty likely that this is react native triggering some sort of Gboard bug, similar to the one @chrisbobbe mentioned above — this problem seems to have gotten significantly worse after a recent React Native upgrade.
In the meantime, a workaround is that you can go to your phone's settings, go to "Apps", scroll down to "Gboard", and press "Force stop". For me, that gets the keyboard working smoothly again, until I type more in Zulip. I understand that that's pretty annoying, though, so hopefully we'll be able to fix this soon — we'll keep this issue updated as we investigate.

It'd be helpful to know if any of the following workarounds can help:
Greg said:

This thread may or may not be about Gboard, but two people report these workarounds:

I found the solution. I disabled the keyboard sound. that's what causing the lag

Yep, after you disable the sound and or [haptic?] feedback, it stops.

Greg said:

Oh, and back on [a Reddit thread], someone reported:

for me, disabling the pop-up on keypress seemed to be the important bit. I also disabled predictive search and the voice input key. Earlier I had disabled suggest contacts, personalized suggestions and spell check.

Possibly related, from a quick skim:

https://github.com/facebook/react-native/issues/35590


Poll preview overlapping patch review

In the poll editor, the poll preview covers the patch reviewing interface:

This bug is probably a feature right now, because the poll patch reviewing is really janky and errorprone, so let me handle the poll patches–else we may lose votes or other translations.

Ok. I didn't actually accept or reject patches. Just withdrew some I made for mistake.


more_like_this query: specify documents instead of text

First of all thanks for providing this great library :-)
I'm currently working on a more_like_this query and I noticed that your implementation might be slightly off compared to the documentation: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-mlt-query.html
Your NewMoreLikeThisQuery requires a likeText argument. However, following the documentation, the like_text argument in the ES query is optional, since it is possible to provide a list of docs too (ES 1.7.x). Or did I miss something?

Thanks for the kind words.
Yes, you're right. Seems I have to back-port the MoreLikeThisQuery from elastic.v3 ... it has all the latest changes to the MoreLikeThisQuery.
Notice that Elastic documentation is very good, but I use the Java source as the definite "source of truth" (insert Linus quote here :-)). Here's MoreLikeThisQueryBuilder for reference.

Thanks for your quick respond and fix!

I backported the majority of MoreLikeThis as implemented in Elastic v3 (targeting Elasticsearch 2.x).
Notice that MoreLikeThis has changed significantly in ES 2.x. E.g. you can have "unlike" and more than one "like text".


Add --deploy-key parameter

This adds a --deploy-key parameter for syncing the deploy keys of a Github repositories.
You can use it in combination with the --user and/or --organization parameters.
To be able to access deploy keys through Githubs API requires an access token with the public_repo or repo (for private repository) scope.
The test case is in its own file because of the dependency on a token use the build tag to test: go test -tags=deploy_key ./...

The test case runs against my Github fork where I have added a deploy key. Maybe it should be changed to your repo and a deploy key (a fake one where you throw away the private part) could be added and used in the Travis test.

The build failed. Looks as if the Github library has changed (again). I will look into that later.

Ping, @ernoaapa.

Thank you and no worries about the delay -- I've got a lot on my plate too :smile:


Refine package exports to fix Jest 28 out of box compatibility

Currently, @vue/test-utils doesn't work with Jest v28 + JSDOM out of the box, requiring the following workaround to prevent trying to read the browser export where CJS is expected:
jest.config.js
moduleNameMapper: {
	'^@vue/test-utils$': require.resolve('@vue/test-utils'),
},

Cleanup
What should be cleaned up or changed:
Refine the package.json exports declarations for the browser to offer the ESM and CJS editions in case of import and require being used. To do so would allow the package to work out of the box with Jest v28 + jest-environment-jsdom
Provide any links for context:

Jest v28 changelog entry about respecting package exports -> See examples of problematic packages
Comment about a package missing the require export for browsers

Yeah - this lib is quite old and pre-dates ESM as a thing. We should probably support it, now that it's more widely used. Care to make a PR?

https://github.com/vuejs/vue-jest/issues/479#issuecomment-1295074840
An explanation about this problem, dunno if it's fixable on vue-test-utils side, using customExportConditions seems to be the official solution

A possible solution could be to export a Jest config preset and use it to set everything correctly, but I guess that's more a problem for vue-jest than vue-test-utils

Just hit this one while migrating my app to vue@3. My initial thought was "maybe is something with @vue/compat" and only after some search, I've hit this issue + SO thread.
@IlCallo  I understand it's not a @vue/test-utils issue per se (https://github.com/vuejs/vue-jest/issues/479#issuecomment-1295074840,) but a reference on the migration guide page could save time for less experienced users — by experience I mean google search skills, because I have experience and It would take me a lot of time until I suspected about jest, since it was working fine with vue@2 @vue/test-utils@1. (Btw thank you for the explanation 🙏 )
@vue/test-utils is is framework agnostic, but the installation guides + demo examples suggest jest and friends, so probably worths a mention in the Migration guides docs? I can make a PR if you agree willing to @lmiller1990

PRs to make docs better are always a good idea :pray:
Note this code base is for VTU v1 (Vue 2). You might want https://github.com/vuejs/test-utils for the Vue 3 version.

@lmiller1990 done https://github.com/vuejs/test-utils/pull/1923, feel free to edit and make the writing/formatting style more aligned with the rest of the docs.

Closed in #1923

@lmiller1990 I'm not sure why you said 'closed' to an open issue

My mistake, is this still  a bug? I think it was fixed, I might have tagged the wrong issue.

#1923 has a reproduction link but hasn't been reviewed by anyone. This one seems closed. What I didn't fully indurstand is the relation. Maybe you wanted to link a PR. I guess it's fine for now.


Request Quote Modal - Duplicate Description

The form description is duplicated on: https://main--shredit--stericycle.aem.page/forms/modals/request-quote

This happened because there is a fragment in the form and the decription is present in the doc as well.
I've fixed it in the doc

@ravise5 thanks for confirming and fixing. Will keep in mind for future occurrences


Exit early from onLayout if not changed & state is transitioning

Exiting early based solely on changed was causing issues as described in this PR #39.  Removing the early exit entirely was causing the CollapsedMenuViewController to set the active tab translations before the collapse animation was started.  This caused the animation not to run.
Adding a check mVisualState == TRANSITIONING to this block prevents both issues.  New tabs get laid out correctly as expected, and we don't set the position of the active tab while transitioning/animating.

Issue #34


add auth support for calling resources

For codegen support, we need to support passing headers when fetching resources.

added in 1.0.0


MDTopAppBar crash app

Description of the Bug
MDTopAppBar: - code in kv file crash the app if kivymd version set to kivymd==1.1.1 in buildozer.spec file
I have changed the version to kivymd==1.0.2 then it doesnt crash anymore.
Specially in Xiamoi note models. For ex: MI Note 8
Code and Logs
from kivy.app import App
from kivy.lang import Builder

kv = """
<Interface>:
    Screen:
        MDBoxLayout:
            orientation: "vertical"
            valign: "top"
            MDTopAppBar:
"""

class MainApp(App):
    def build(self):
        self.root = Builder.load_string(kv)

if __name__ == '__main__':
    MainApp().run()

Screenshots
Add images to explain us this bug. Paste urls here.
Remove this section if no images here
Versions

OS:
Python:
Kivy:
KivyMD:

Use KivyMD from master branch


Improve guide about adding decoders/crackers

Improve guide about adding decoders/crackers with experiences we've had ourselves & problems we've encountered.

I would say one key thing missing from the docs is that currently (AFAIK) anything that does not have a well defined 1-1 mapping when decoding needs to be implemented as a cracker. For instance #412 - the Soundex encoding has a 1-N mapping when encoding, so this needs to be a cracker when decoding.
This is particulary confusing since the definition of encoding is "Any form of encryption that doesn’t use a key", but there are many decoders that need to be crackers in Ciphey even though the encoding does not have a key, for the sole reasons that they need to return multiple candidates.

I would say one key thing missing from the docs is that currently (AFAIK) anything that does not have a well defined 1-1 mapping when decoding needs to be implemented as a cracker. For instance #412 - the Soundex encoding has a 1-N mapping when encoding, so this needs to be a cracker when decoding.
This is particulary confusing since the introduction to Adding your own ciphers has a definition of encoding which is is "Any form of encryption that doesn’t use a key". But there are many decoders that need to be crackers in Ciphey even though the encoding does not have a key, for the sole reasons that they need to return multiple candidates.

Edited! :) https://github.com/Ciphey/Ciphey/wiki/Adding-your-own-ciphers


Scheduling Notification Free Blocks

Is there any way to turn off all the services at once via the API?
I'm imagining a plugin where you could say from 9-11am on Wednesday, no messages can be received or sent.

This can be done using automator in osx.


Ready & Restart text on Services Page for Kubernetes is on two lines

Version - v1.0.1-rc1
Steps to Reproduce:

Setup kubernetes environment
Add the WP catalog
On the main Services page clicko n wpfrontend, then the pod name to see the containers

Results: The Ready and Restart text are on two lines

Expected: Should be on same line.  This looks fine in v1.0.0

Version - v1.0.1-rc5
Verified fixed


run on the windows 7.

Hi! I tried to run it on the windows 7. But got the problem that I can't install git+https://github.com/openai/baselines (it fails during installing atari-py). Did someone win it?

You can remove atari as a dependency from baseline's setup.py. I don't know if it breaks somethings in run-time but I was able to run the examples in this repo.

I fixed this by cloning atari-py, at

https://github.com/openai/atari-py

then doing

pip install -e .


Tooltip: issues with hover and 'i' symbol

The tooltip 'i' symbol is not showing
When we hover the tooltip rectangle, the tooltip does not show immediately

Screen recording below and test link here: Portal page one Column
https://github.com/international-labour-organization/designsystem/assets/22772102/07593633-e150-47cd-8a12-83adb872f8af

This could be related to #692


fix: lets annotate resources with the helm release

so that we can more easily determine which resources come from which charts
and versions

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Call for collaborators!

Hi @just-boris, @dhoulker, @pazone.
I've only just discovered Allure, and have seen the thread you've started here: https://github.com/webdriverio/webdriverio/issues/532. I had a play with creating a basic reporter for v4.0 of Webdriverio, and it works great.
I'd very much like your involvement in this project, to make an officially-supported reporter. As far as I can see, there's no need to couple it to Mocha - using the reporter system we have set up in the project, we should be able to get all the information we need from the BaseReporter without using Mocha hooks. This means it should work with any test framework!
A word of warning - v4.0 is not yet in beta, and some of the subprojects aren't fully published yet. So here's what I'm using:

Use #framework branch of webdriverio: https://github.com/webdriverio/webdriverio/tree/framework
symlink this repo as webdriverio/node_modules/wdio-allure-reporter
symlink #junit branch of wdio-mocha-framework: https://github.com/webdriverio/wdio-mocha-framework/tree/junit as webdriverio/node_modules/wdio-mocha-framework
Add the allure reporter in wdio.conf.js:

		framework: 'mocha',
		reporter: ['allure']

If you have a chance, could you give that a try? I was able to get a decent looking report instantly.
I have a number of questions for you regarding the allure-js-commons library, and how to get the full features described in the Java annotations documentation. Let me know when you're ready for them!

cc @klamping

I pushed my initial work here: https://github.com/just-boris/wdio-allure-reporter
It can be moved when I will have got a working prototype. Since you are interested, I can take more time to work on it.

Awesome. If you're happy, I'd like to merge any features of yours into mine, as the BaseReporter has now become a little more useful.

We are going to do it as soon as possible, thanks.

I'll be trying this out this week to see how it works for the set up at my work. Hope to help out with this however I can.

I'll add some questions as they occur to me.

How are labels exposed in the Allure report? I can see them correctly added to my XML:

			<labels>
				<label name="specId" value="7ab016a71b4c3140e3a825217e668700"/>
				<label name="capabilities" value="chrome.latest.mac"/>
			</labels>

...but don't see them in the report anywhere. Is this not yet implemented?

Labels are not designed for any custom values. It is a kind of container to store some internal Allure data.
Also, we have a public container named <parameters></parameters> but it has not implemented in JS-plugins. Once you have the following in your XML
<parameters>
    <parameter name="specId" value="7ab016a71b4c3140e3a825217e668700" kind="argument" />
    <parameter name="capabilities" value="chrome.latest.mac" kind="argument" />
</parameters>

You will see the following in the report:

I created an issue for allure https://github.com/allure-framework/allure-js-commons/issues/8
I am going to implement this soon.

Thanks - that sounds perfect.

Ok, I did something that can work: https://github.com/just-boris/wdio-allure-reporter
Test code is here
And then I got the following report

Then I am going to implement steps, attachment features.
Also, you can see an issue here: I can't see a difference between failed assertions and unknown exceptions, so both of them are broken tests.

I've got this far with my copy:

It's using this repo, but the dependencies on webdriverio, wdio-mocha-framework and wdio-sync are quite complex. I'm currently using the following:
    "wdio-allure-reporter": "georgecrawford/wdio-allure-reporter#my-working-branch",
    "wdio-mocha-framework": "georgecrawford/wdio-mocha-framework#my-working-branch",
    "webdriverio": "georgecrawford/webdriverio#my-working-branch",

Want to try it out? We should be collaborating on the same repo if possible!

@georgecrawford yes, we definitely should!

@just-boris, @dhoulker, @pazone added you guys as collaborator to this repo

My allure reporter is working great, but I have some work to do to get the required code into webdriverio v4.0. When that's done, I'd love some collaborator feedback from you guys.

Well, we all team are on vacation now. I can take a look on it at the next week.

I think we can close this now.
@just-boris feel free to reopen if you want though.


Relax Hashable trait constraint to use Clone instead of Copy

This PR relaxes Hashable trait constraint to use Clone instead of Copy.
Background: most of the data structures under mina-rs are not deriving the Copy trait, for better visibility of performance overhead and to avoid implicit copy-on-move,  so it's hard for us to implement this trait when it requires Copy.  Please let me know your feedback and concerns, thanks!
P.S. In this PR, I did not make changes to any structs that implements Hashable in the signer crate (e.g. Transaction) so they are still deriving Copy.

looks like circleci tests are blocking. If you want you can remove the .circleci folder as part of this PR, since we don't need circleCI anymore (the checks in the github actions are actually better). cc @mrmr1993 we'd need to enforce the github action tests in the protected branch master though.

Sure, .circleci folder removed

humm... not sure why it still shows the circleci tests. cc @mrmr1993 since I can't investigate this myself

The current CI for github actions doesn't run cargo test. We want the CircleCI tests to run those, at least until we change the github one to do so.

Wow... Good catch. I was convinced it did. @hanabi1224 can you add cargo run test to the .github/workflows/rust.yml?
thanks for catching that @mrmr1993

@mimoo I've enabled tests in GitHub CI. Plz note that I changed build&test to release mode because tests are very slow in debug mode
@jspada Plz let me know if I still need to restore the .circleci folder in this case.


 But this was not working for non-upstream Docker Hub accounts. This patch should fix that.
Symptoms:

The push refers to a repository [docker.io/kinvolk/scope] (len: 1)
error getting tags for kinvolk/scope: Tag does not exist for
master-b89e9ec

Also, ensure that the Docker tag name does not include any '/'.
Symptoms:

docker tag weaveworks/scope weaveworks/scope:alban/hub1-ef739d9
repository name component must match "[a-z0-9]+(?:[._-][a-z0-9]+)*"

Nice one @alban, this should fix #1652 too!

The failure is due to our test scheduler getting your circle runs confused with our cicrle runs.  Looks like the owner of the repo should be included in the test schedule name.

@tomwilkie where is that test schedule name defined?

https://github.com/weaveworks/scope/blob/6d527821e71a8b8550ef3c4a740985df0fe549d5/experimental/in_parallel.sh#L21 the second argument to this is the schedule name.  It should be update to include the full repo path or something.
Note experimental has gone away now.  But the same problem probably exists for other uses of the scheduler (ie unit tests).  They are run by this script https://github.com/weaveworks/build-tools/blob/master/test.

@tomwilkie thanks! This time, CircleCI passed fine.
/cc @krnowak @alepuccetti

Branch updated. CircleCI passed here but of course it didn't run the deployment for the master branch. So I tried on another repository on the master branch and it also passed here.

LGTM!


Feat/add auto release ci

:tada: This PR is included in version 0.1.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove the builtin import code

The builtin import code is a hack and it's starting to be an issue.
With the more recent compiler_builtins which implements the math builtin functions in Rust, we can get conflicts between the GCC imported builtins and the Rust builtins:
libgccjit.so: error: : gcc_jit_function_new_block: cannot add block to an imported function
thread 'rustc' panicked at /home/user/.cargo/git/checkouts/gccjit.rs-13c2e290f2fb9e4d/f1545d7/src/function.rs:183:17:
gcc_jit_function_new_block: cannot add block to an imported function (cos)

if it's not being used anywhere else in the code, it shouldn't be a problem


to get this to run on windows

comment out:
if 'PYOPENGL_PLATFORM' not in os.environ:
os.environ['PYOPENGL_PLATFORM'] = 'egl'
in the following 2 files
hmr2/utils/mesh_renderer.py
hmr2/utils/renderer.py
excellent work by the way!!

Thanks, @21pl. We will add these changes to make the repo windows-friendly :)


Alert KubevirtVmHighMemoryUsage if memory available is less than 10%

Alerting on 20MB free space margin is too close, and late alert for the consumers. Instead of 20 MB, a 10% free space margin would be more helpful.
Signed-off-by: João Vilaça<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Alert KubevirtVmHighMemoryUsage if memory available is less than 10%

/retest

/retest

/hold

@machadovilaca  Hi, I don't think we should move to percentages. We can try increasing from 20MB to a higher number.

/hold

@sradco I updated it to alert if less than 50MB available
/unhold

/lgtm

@machadovilaca @sradco Hi, can you please elaborate on the method you've used in order to decide about 50MB, for example shouldn't it be relative to the VM RAM that was requested in the resources section of the VM YAML?

@machadovilaca @sradco Or even should we make it configurable?

@enp0s3 Please see discussion here: https://issues.redhat.com/browse/CNV-21883
We created this alert to be able to tell if we assigned enough memory to the virt-launcher container. We want to observe this in Telemetry.
At first we set it to 20MB and we see that the container is evicted before this alert is triggered. In our tests we see that it is evicted after it reaches around ~40MB. We want to see how many alerts we get and decide if we should increase the requested memory for the virt-launcher container, so that the containers will not be evicted due to this issue.
Using % or making the margin configurable will not help us for this purpose.

/approve

/cherry-pick release-0.58


us-east-1 region seems to have wrong endpoint

Hello
I am having bucket on us-east-1 and it doesn;t work.
after checking debug output I could see that key_manager tries to query
https://[BUCKET].s3-us_east_1.amazonaws.com
while on AWS docs it say that following endpoints are available:
s3.amazonaws.com
s3-external-1.amazonaws.com
us-east-1 doesn't have region subdomain added to an endpoint.

sorry region what misstyped..closing...


.NET Guidelines TODOs

[x] Add more justifications and code samples
[x] Make internal links work
[x] Principles
[x] Fold-in general guidelines
[x] HttpPipeline Usage Guidelines
[x] Authentication Guidelines
[x] Packaging Details
[ ] Compatibility Details

@adrianhall is this done?

Not complete yet - needs more details around compatibility details.

Actually, this is complete.  #148 has remaining compatibility requirements.


Add native limit support

Currently we only have PaginatedCriteriaBuilder which supports limiting but it just uses the underlying limit functions. We can implement general purpose limit support for subqueries and other builders through the limit functions.
Subqueries and the insert statement will benefit from this.

Limit support for insert statements is outstanding


np.int deprecation error in numpy

np.int is deprecated since numpy 1.20.0 and results into an error in the LVQBaseClass:
https://github.com/rickvanveen/sklvq/blob/4fba52a14ed37b0444becb96ef09c40d38d263ff/sklvq/models/_base.py#L691
np.int should be changed into int

Thanks! fixed it.


[BUG] Replay Proxy Hanging

Not exactly sure what is going on here, but seems like the replay-proxy hangs if the method is POST as it works fine with GET
HTB Box: CrossfitTwo
Requires crossfit-club.htb in host file.
test.txt
signup
login

feroxbuster -u http://crossfit-club.htb/api/ -w test.txt -m POST -k --no-state --replay-proxy <IP_ADDRESS>:8080 --replay-codes 200,301,302,401,403 -vvvv
Appears to be hanging in process_response of /src/event_handlers/outputs.rs

thankfully, this is an easy one.
in addition to -m POST, you need to add --data some-value . Burp gets upset at posts without a body (or at least the (lack of)body that gets produced by feroxbuster.
Might be good to dig a little at what the request looks like with -m POST and no --data to see where it's malformed/weird, and then fix it up when the user specifies a post request without data.

After much digging / dinking around with different reqwest settings, I'm at a loss for a fix that doesn't require setting an arbitrary body payload when one isn't provided. I filed an issue here to see if there's any help to be had.

Pending a better solution, when --proxy or --replay-proxy is used, and --method=POST and --data isn't used, then \r\n is appended to the request body as a (hopefully) temporary workaround.


"Object reference not set to an instance of an object" (2.9.2) and/or "Bootloader locked" (3.0 Pre2)

Description
I've been trying to get my Lumia 950 (RM-1104) back to stock to try out a newly released Android ROM.
As a few days ago the official servers have been turned off I've downloaded (hopefully) the right FFU and emergency files and tried flashing those. I also found an old backup dump I made a few years back and tried to flash that, however the same error "Object reference not set to an instance of an object" comes up.
Using the new 3.0 Pre2 version shows "Bootloader locked", however I'm certain that's not the case as I already ran Windows 11 on this device, further the 3.0 version is constantly waiting for the device to be in Flash mode despite it already being in Flash mode. On 2.9.2 it does recognize the device in Flash mode, however it still throws the reference error.
Choosing "Flash original FFU" just freezes WPI, then closes it a few seconds later.
Steps To Reproduce

Connect device
Try flashing FFU, a backup or unlocking Bootloader
Either "Object reference not set to an instance of an object" error occurs or the tool crashes

Expected behavior
Functions should work as described :(
WPinternals Version
2.9.2 and 3.0 Pre2
Windows Version
Windows 11 22H2
Phone model
Luma 950 (RM-1104)
Relevant Assets
No response

Can you please attach a clean log file of either versions?

Wipe C:\ProgramData\WPinternals\WPinternals.log
Start WPinternals version 2.9.2
Reproduce the issue
Backup C:\ProgramData\WPinternals\WPinternals.log to C:\ProgramData\WPinternals\WPinternals_2.9.2.log
Wipe C:\ProgramData\WPinternals\WPinternals.log
Start WPinternals version 3.0 Prerelease 2
Reproduce the issue
Backup C:\ProgramData\WPinternals\WPinternals.log to C:\ProgramData\WPinternals\WPinternals_3.0.log
Wipe C:\ProgramData\WPinternals\WPinternals.log

Send both WPinternals_3.0.log and WPinternals_2.9.2.log
Thank you.

Heya, I fixed the issue meanwhile and it seemed to be device related. So the only logs I'd have are the ones still being left behind after all my tests, tho I guess they would be huge to share here. If there's anything specific I can share tho or a specific section that would help can of course provide then :)
I had Windows 11 flashed on it before, somehow it was stuck in a somewhat "limbo state" of WPI telling me my bootloader is locked but it... wasn't? After using thor2 directly to flash a FFU for my device it flashed just fine, however was then stuck at a red flash recovery screen. WPI at that point picked it up again and suddenly the bootloader unlock steps started working :)
After like 20 failed attempts from WPI to try and unlock it it threw an error that it couldn't do so, however at that point Windows Mobile started booting...
So yeah, I think my Lumia was just in a somewhat weird semi-bricked state which confused WPI, would be my guess.

Here are some sections from the log that I think are the interesting bits, if you need more please tell :)
2024-09-22 03:07:55.034: Flash app: 2.75
2024-09-22 03:07:55.034: Flash protocol: 2.41
2024-09-22 03:07:55.034: SecureBoot: Disabled (Platform Secure Boot: Enabled, UEFI Secure Boot: Enabled)
2024-09-22 03:07:55.034: Flash app security: Enabled (FFU security: Enabled, RDC: Not found, Authenticated: False)
2024-09-22 03:07:55.034: JTAG: Disabled
2024-09-22 03:07:55.034: Bootloader: Lumia Bootloader Spec B
2024-09-22 03:07:55.034: ProductCode: 059X4X7
2024-09-22 03:07:55.034: ProductType: RM-1104
2024-09-22 03:07:59.997: FFU not added, because it was already present in the repository.
2024-09-22 03:07:59.997: Emergency files not added, because they were already present in the repository.
2024-09-22 03:07:59.997: Unlock Bootloader
2024-09-22 03:07:59.997: Processing resources:
2024-09-22 03:07:59.997: Profile FFU: C:\Users\epicl\Downloads\RM1104_1078.0053.10586.13169.13842.034EA5_retail_prod_signed.ffu
2024-09-22 03:07:59.997: EDE file: C:\Users\epicl\Downloads\MPRG8992_fh.ede
2024-09-22 03:08:00.160: Assembling data for unlock
2024-09-22 03:08:00.161: Assembling data for unlock
2024-09-22 03:08:00.189: Attempt patch: SecureBootHack-V2-EFIESP
2024-09-22 03:08:00.193: Pattern: 0, 0
2024-09-22 03:08:00.193: Pattern: 1, 0
2024-09-22 03:08:00.193: Pattern: 2, 0
2024-09-22 03:08:00.193: Pattern: 3, 0
2024-09-22 03:08:00.193: Pattern: 4, 0
2024-09-22 03:08:00.193: Apply: 10.0.10586.318
2024-09-22 03:08:00.197: Edit BCD
2024-09-22 03:08:00.267: Enabling Test Signing
2024-09-22 03:08:00.267: Enabling Test Signing
2024-09-22 03:08:00.274: Error: Object reference not set to an instance of an object.
2024-09-22 03:08:00.278:    at WPinternals.LumiaUnlockBootloaderViewModel.LumiaUnlockUEFI(PhoneNotifierViewModel Notifier, String ProfileFFUPath, String EDEPath, String SupportedFFUPath, SetWorkingStatus SetWorkingStatus, UpdateWorkingStatus UpdateWorkingStatus, ExitSuccess ExitSuccess, ExitFailure ExitFailure, Boolean ExperimentalSpecBEFIESPUnlock, Boolean ExperimentalSpecAEFIESPUnlock, Boolean ReUnlockDevice)
2024-09-22 03:08:00.278: Object reference not set to an instance of an object.
2024-09-22 03:08:10.678: Error: Object reference not set to an instance of an object.
2024-09-22 03:08:10.678:    at WPinternals.LumiaFlashRomViewModel.<>c__DisplayClass13_0.<FlashFFUTask>b__0()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ThreadHelper.ThreadStart()

Sometime later in the log:
2024-09-22 03:10:11.058: Edit BCD
2024-09-22 03:10:11.125: Enabling Test Signing
2024-09-22 03:10:11.125: Enabling Test Signing
2024-09-22 03:10:11.132: Error: Object reference not set to an instance of an object.
2024-09-22 03:10:11.138:    at WPinternals.LumiaUnlockBootloaderViewModel.LumiaUnlockUEFI(PhoneNotifierViewModel Notifier, String ProfileFFUPath, String EDEPath, String SupportedFFUPath, SetWorkingStatus SetWorkingStatus, UpdateWorkingStatus UpdateWorkingStatus, ExitSuccess ExitSuccess, ExitFailure ExitFailure, Boolean ExperimentalSpecBEFIESPUnlock, Boolean ExperimentalSpecAEFIESPUnlock, Boolean ReUnlockDevice)
2024-09-22 03:10:11.138: Object reference not set to an instance of an object.
2024-09-22 03:10:24.889: Initializing flash...
2024-09-22 03:10:24.941: Error: Object reference not set to an instance of an object.
2024-09-22 03:10:24.943:    at WPinternals.LumiaV2UnlockBootViewModel.LumiaV2FlashPartitions(PhoneNotifierViewModel Notifier, String EFIESPPath, String MainOSPath, String DataPath, SetWorkingStatus SetWorkingStatus, UpdateWorkingStatus UpdateWorkingStatus, ExitSuccess ExitSuccess, ExitFailure ExitFailure)
2024-09-22 03:10:24.943: Object reference not set to an instance of an object.
2024-09-22 03:13:26.265: Effective Bootloader Security Status: False
2024-09-22 03:13:35.741: Effective Bootloader Security Status: False

Bonjour, comment allez-vous ? J'ai un problème sur mon lumière 950. Je n'arrive pas à déverrouiller le chargeur du démarrage s'il vous plaît. Aidez-moi comment faire pour flasher mon téléphone merci vous voyez à chaque fois que j'ai essayé de flasher j'essaie qui s'affiche

@EpicLPer these log sections could be useful but only if i knew what version of the app they matched for, could you try to fetch this? thank you.

@Cheikhabbas44 this is a separate issue you are having and is also offtopic and not in english, i would advise you to file a separate issue properly on this repo. thank you.

Hello, how are you? I have a problem on my Lumia 950. I can't unlock the bootloader please. Help me how to flash my phone thank you you see every time I tried to flash I try that is displayed

@EpicLPer Please try to gather logs with preview 3 (https://github.com/ReneLergner/WPinternals/releases/tag/3.0-preview3)
Delete the old log file before, we added a lot more debug logging in this preview update. This should enable narrowing down the issue

I sadly cannot reproduce the issue anymore or test the new release as I've managed to flash my Lumia already, so it's essentially "back to stock" and then flashed with an Android ROM :( Whatever weird partition layout or other issues my Lumia had with WPInternals is therefore gone now.

Alright if you ever get the issue again please let us know via a new issue then, good to know it got solved on your side thank you!


Training cost too much

@ZikangZhou Hi Zhou! I noticed that when I train this code, it utilizes 32GB of GPU memory per GPU instead of the 20GB mentioned in the README.md. Could you please explain what might be causing this discrepancy in this repository?

It didn't happen right at the beginning of training. As the training progresses, the GPU memory usage increases. In the first epoch, it occupies 20GB per GPU, but by the 30th epoch, the GPU memory usage reaches 32GB per GPU.

I encountered a similar phenomenon. The GPU memory grows with traning. Maybe the code has a memory leak problem.

Hi, are you watching the result of nvidia-smi?

Yes, while using RTX 3090, I noticed that the program quickly ran out of GPU memory by epoch 2. However, when I switched to A100, I observed that it consumed nearly 33GB of memory per GPU during training about 40 epochs.

Hmm... I noticed a similar phenomenon during training. I think there may be several reasons. First, if the number of agents/map elements within a batch happens to be extremely large, then the peak memory cost will blow up. Second, there exists a memory leak in the code (but I can't identify it, maybe someone can help). Lastly, the memory usage displayed by nvidia-smi is not that accurate (I think it is merely showing the buffer size created by the program).
I usually use four A40 (48GB memory) to train models with batch size=8 per GPU. The memory usage shown by nvidia-smi varies from 30GB to ~40GB per GPU.

Thanks for your response! I will investigate the underlying cause of the memory leak issue.

@zaplm @flclain @ZikangZhou Hi, I encountered similar problem, have you investigated the underlying cause of the memory leak issue? I train the model with batch size=4 per GPU on 4 RTX 4090(24GB), it's normal and costs 20GB per GPU at the beginning, but run out of GPU memory by epoch 3. I try to reduce batch size=2 per GPU, but still run out of GPU memory later.

@Qingfeng800, you can also attempt to decrease the radius, which will also result in lower GPU memory usage.

@Qingfeng800, you can also attempt to decrease the radius, which will also result in lower GPU memory usage.

Yes, adjusting hyperparameters can reduce graphics memory, but it may affect accuracy. As the GPU memory gradually increases with model training, there must be bug within the code.

@zaplm @flclain @ZikangZhou Hi, I encountered similar problem, have you investigated the underlying cause of the memory leak issue? I train the model with batch size=4 per GPU on 4 RTX 4090(24GB), it's normal and costs 20GB per GPU at the beginning, but run out of GPU memory by epoch 3. I try to reduce batch size=2 per GPU, but still run out of GPU memory later.

I used two A800(80 GB) to train the model with batch size 16. The problem of memory leaks is fine for me, so I didn't check this problem.
Maybe you can decrease your batch size and choose a smaller learning rate, if you are concerned about reducing the model performance.

Thanks for your response! I will investigate the underlying cause of the memory leak issue.

Hi @zaplm, have you been able to figure out the underlying memory leak issue? Otherwise we could maybe reopen the issue.

Thanks for your response! I will investigate the underlying cause of the memory leak issue.

Hi @zaplm, have you been able to figure out the underlying memory leak issue? Otherwise we could maybe reopen the issue.

Maybe you can try  setting the parameter persistent_workers of Dataloader to false;

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

I tried to use model = torch.compile(model) and it reports the error:

RuntimeError: CUDA error: misaligned address
Is there any version mismatch or something wrong?

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

I tried to use model = torch.compile(model) and it reports the error:

RuntimeError: CUDA error: misaligned address

Is there any version mismatch or something wrong? These are my environment setup:
* PyTorch version: 2.0.1

* CUDA available: True

* CUDA version: 11.8

"I am currently using PyTorch version 2.1.0 (with CUDA 11.8 support) and PyTorch Lightning version 2.1.2. I've encountered an issue related to 'self.log' conflicts. A similar issue has been discussed in this GitHub thread: PyTorch Lightning GitHub Issue #18835."

"I am currently using PyTorch version 2.1.0 (with CUDA 11.8 support) and PyTorch Lightning version 2.1.2. I've encountered an issue related to 'self.log' conflicts. A similar issue has been discussed in this GitHub thread: PyTorch Lightning GitHub Issue #18835."

Thanks for your sharing. I reinstalled the pytorch version to match yours, the original problem is gone, but a new bug appears:

torch._dynamo.exc.TorchRuntimeError: Failed running call_function torch_cluster.radius(*(FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), 30.0, 301, 1), **{}):
The tensor has a non-zero number of elements, but its data is not allocated yet. Caffe2 uses a lazy allocation, so you will need to call mutable_data() or raw_mutable_data() to actually allocate memory.
from user code:
File "/home/lww/anaconda3/envs/QCNet/lib/python3.8/site-packages/torch_cluster/radius.py", line 82, in
return torch.ops.torch_cluster.radius(x, y, ptr_x, ptr_y, r,
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
You can suppress this exception and fall back to eager by setting:
import torch._dynamo
torch._dynamo.config.suppress_errors = True

$ pip list | grep torch
pytorch-lightning        2.1.2
pytorch-triton           2.1.0+e6216047b8
torch                    2.1.0+cu118
torch-geometric          2.3.1
torch-scatter            2.1.2
torch2trt                0.4.0
torchaudio               2.1.0+cu118
torchmetrics             1.2.0
torchvision              0.16.0+cu118****

This is my complete setup for the PyTorch-related environment. I've developed a straightforward radius function that filters indices based on calculated distances. In case this approach is not effective, feel free to create your own implementation of this function.

"I am currently using PyTorch version 2.1.0 (with CUDA 11.8 support) and PyTorch Lightning version 2.1.2. I've encountered an issue related to 'self.log' conflicts. A similar issue has been discussed in this GitHub thread: PyTorch Lightning GitHub Issue #18835."

Thanks for your sharing. I reinstalled the pytorch version to match yours, the original problem is gone, but a new bug appears:

torch._dynamo.exc.TorchRuntimeError: Failed running call_function torch_cluster.radius(*(FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), 30.0, 301, 1), **{}):
The tensor has a non-zero number of elements, but its data is not allocated yet. Caffe2 uses a lazy allocation, so you will need to call mutable_data() or raw_mutable_data() to actually allocate memory.
from user code:
File "/home/lww/anaconda3/envs/QCNet/lib/python3.8/site-packages/torch_cluster/radius.py", line 82, in
return torch.ops.torch_cluster.radius(x, y, ptr_x, ptr_y, r,
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
You can suppress this exception and fall back to eager by setting:
import torch._dynamo
torch._dynamo.config.suppress_errors = True

with more environment setups:
* pytorch-lightning             2.1.2

* pytorch-triton                2.1.0+bcad9dabe1

* torch                         2.1.0+cu118

* torch-cluster                 1.6.3+pt21cu118

* torch_geometric               2.4.0

* torch-scatter                 2.1.2+pt21cu118

* torch-sparse                  0.6.17

* torch-spline-conv             1.2.2+pt21cu118

* torchaudio                    2.1.0+cu118

* torchmetrics                  0.11.4

* torchvision                   0.16.0+cu118

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

I tried to use model = torch.compile(model) and it reports the error:
raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}")
TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule
sorry, I want to know where to add this command?

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

I tried to use model = torch.compile(model) and it reports the error: raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}") TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule
sorry, I want to know where to add this command?

In the train_qcnet.py
model = QCNet(**vars(args))
Then add this code after it.
model = torch.compile(model)

Anyone encountering a situation where the GPU memory is insufficient can reduce memory usage significantly by using the command model = torch.compile(model). In my experimental setup, this approach reduced GPU memory consumption by approximately 70%.

I tried to use model = torch.compile(model) and it reports the error: raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}") TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule
sorry, I want to know where to add this command?

In the train_qcnet.py model = QCNet(**vars(args)) Then add this code after it. model = torch.compile(model)

I also added this line of code where you mentioned it, but it still reported an error：raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}") TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule

I also added this line of code where you mentioned it, but it still reported an error：raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}") TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule
I believe it would be beneficial to verify the versions of PyTorch and PyTorch Lightning that were previously mentioned.

"I am currently using PyTorch version 2.1.0 (with CUDA 11.8 support) and PyTorch Lightning version 2.1.2. I've encountered an issue related to 'self.log' conflicts. A similar issue has been discussed in this GitHub thread: PyTorch Lightning GitHub Issue #18835."

Thanks for your sharing. I reinstalled the pytorch version to match yours, the original problem is gone, but a new bug appears:

torch._dynamo.exc.TorchRuntimeError: Failed running call_function torch_cluster.radius(*(FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(561, 2)), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), FakeTensor(..., device='cuda:0', size=(9,), dtype=torch.int64), 30.0, 301, 1), **{}):
The tensor has a non-zero number of elements, but its data is not allocated yet. Caffe2 uses a lazy allocation, so you will need to call mutable_data() or raw_mutable_data() to actually allocate memory.
from user code:
File "/home/lww/anaconda3/envs/QCNet/lib/python3.8/site-packages/torch_cluster/radius.py", line 82, in
return torch.ops.torch_cluster.radius(x, y, ptr_x, ptr_y, r,
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
You can suppress this exception and fall back to eager by setting:
import torch._dynamo
torch._dynamo.config.suppress_errors = True

with more environment setups:

pytorch-lightning             2.1.2
pytorch-triton                2.1.0+bcad9dabe1
torch                         2.1.0+cu118
torch-cluster                 1.6.3+pt21cu118
torch_geometric               2.4.0
torch-scatter                 2.1.2+pt21cu118
torch-sparse                  0.6.17
torch-spline-conv             1.2.2+pt21cu118
torchaudio                    2.1.0+cu118
torchmetrics                  0.11.4
torchvision                   0.16.0+cu118

I have the same trouble as yours, are you solving it?

I also added this line of code where you mentioned it, but it still reported an error：raise TypeError(f"Trainer.fit() requires a LightningModule, got: {model.class.qualname}") TypeError: Trainer.fit() requires a LightningModule, got: OptimizedModule

I believe it would be beneficial to verify the versions of PyTorch and PyTorch Lightning that were previously mentioned.

Thanks for your ansys, yes, it is my fault, and I update the pytorch-lightning, but so said, I have the same trouble as the before one?

You can suppress this exception and fall back to eager by setting: import torch._dynamo torch._dynamo.config.suppress_errors = True"""

You can try to follow https://github.com/pytorch/pytorch/issues/95791#issuecomment-1595237235, or write your custom radius function, just calculate the distance and select the distance less than radius.

@SunHaoOne Could you provide some Code for your custom radius function? Did you replace the whole radius_graph function from torch-cluster or did you integrate your radius function into torch-cluster?

@SunHaoOne Could you provide some Code for your custom radius function? Did you replace the whole radius_graph function from torch-cluster or did you integrate your radius function into torch-cluster?

Hi, @kennethweitzel
For example, I didn't use the 'r' parameter to calculate the distance. Instead, you can adjust the topk approach to incorporate radius parameters. The radius_graph function calculates the radius relation within itself, so it can serve as an approximation instead of using the conventional radius function
def radius_topK(xy_A: torch.Tensor, xy_B: torch.Tensor, k: int) -> torch.Tensor:
    """
    Find the top k nearest points in set A for each point in set B and return their indices.

    Args:
        xy_A: Coordinates of points in set A, shape [N, 2].
        xy_B: Coordinates of points in set B, shape [M, 2].
        k: The number of nearest neighbors to find for each point in B.

    Returns:
        A tensor of shape [2, M*k] where the first row contains repeated indices of points in B
        and the second row contains indices of the nearest points in A for each point in B.
    """
    device = xy_A.device
    N = xy_A.shape[0]
    M = xy_B.shape[0]

    # Expand xy_A and xy_B to compute pairwise distances
    xy_A_expanded = xy_A.unsqueeze(0).expand(M, N, 2).to(device)  # Shape: [M, N, 2]
    xy_B_expanded = xy_B.unsqueeze(1).expand(M, N, 2).to(device)  # Shape: [M, N, 2]

    # Compute the Euclidean distance between each pair of points
    rel_dist = torch.norm(xy_B_expanded - xy_A_expanded, dim=-1)  # Shape: [M, N]

    # Find the indices of the k nearest neighbors in A for each point in B
    nearest_idx_A = torch.topk(rel_dist, k, largest=False, sorted=True).indices  # Shape: [M, k]

    # Generate repeated indices for points in B
    idx_B = torch.arange(M, device=device).unsqueeze(-1).repeat(1, k).view(-1)  # Shape: [M*k]

    # Flatten the indices of nearest points in A
    nearest_idx_A_flat = nearest_idx_A.view(-1)  # Shape: [M*k]

    # Combine the indices of B and nearest points in A
    combined_indices = torch.stack((idx_B, nearest_idx_A_flat), dim=0)  # Shape: [2, M*k]

    return combined_indices

Hi, @kennethweitzel

What do you use for k in this case?

Since we aim to deploy the model, using radius can cause dynamic dimensions due to non-zero elements, which leads to increased computation time. Therefore, we limit this using topK. Through data analysis, for example, by taking some coordinates from datasets to calculate connectivity relationships, we can identify a balance point that enables us to establish a correlation between the values of r and k. For instance, in my scenario, we use k = 15 but you can adjust k according to different r values, from r = 50, 100, 150.

And also the function you provided seems like it can't handle batches. How did you handle that?

To simplify for inference, we removed the batch dimension. My understanding is that the Batch data structure in torch_geometric is obtained by stacking each graph's relationships. Similarly, you can iterate over the batch dimension, calculate their connectivity relationships for each dimension, and then merge this dimension in the results.

hello, @SunHaoOne
How to utilize the features of the previous frame for online deployment???

Hi, @kennethweitzel

What do you use for k in this case?

Since we aim to deploy the model, using radius can cause dynamic dimensions due to non-zero elements, which leads to increased computation time. Therefore, we limit this using topK. Through data analysis, for example, by taking some coordinates from datasets to calculate connectivity relationships, we can identify a balance point that enables us to establish a correlation between the values of r and k. For instance, in my scenario, we use k = 15 but you can adjust k according to different r values, from r = 50, 100, 150.

And also the function you provided seems like it can't handle batches. How did you handle that?

To simplify for inference, we removed the batch dimension. My understanding is that the Batch data structure in torch_geometric is obtained by stacking each graph's relationships. Similarly, you can iterate over the batch dimension, calculate their connectivity relationships for each dimension, and then merge this dimension in the results.

radius() radius_graph() can be calculated in data processing stage.

radius() radius_graph() can be calculated in data processing stage.
You are right.The edge radius can be calculated offline. However, during online inference, this procedure cannot be accelerated by TensorRT. I think tt is recommended to use this function in the ONNX file.

radius() radius_graph() can be calculated in data processing stage.

You are right. The edge radius can be calculated offline. However, during online inference, this procedure cannot be accelerated by TensorRT. I think tt is recommended to use this function in the ONNX file.


Hugging face Space - No Space Left on Device - TPU memory leak?

@sanchit-gandhi  - return of TPU memory leak?
Err 28 Not Enough Space on Device Error on Hugging Face Whisper Jax Space
Possibly a reccurence of issue 188
The error had been getting more and more frequent, however all requests are now erroring
Would be eternally grateful if you could work your magic to fix as you did before please.
Thanks!

@sanchit-gandhi - please can you look at this , I Imagine it's a quick fix if it's the same problem as issue 188
Do you need any other information in order to troubleshoot?
There are dozens of reports of this not working on Huggingface. Have also tried Twitter to reach you. Please could you have a look at look at it.


Drag Drop Files between folders

Hello,
Firstly I would like to congratulate for making such a good treeview.
How can we use the drag and drop to move files around.
Thanks,
Deepak

@d3ep4k Yes, this would be a pretty cool feature. I'll experiment and add it into the next major release

Any progress with this? :)

@alexcurtis I'd choose this component if it would drag & drop

waiting for this feature as well.

waiting +1

waiting +1

@alexcurtis I modified treebeard with drag and drop. Would you like me to do a PR with this?

@shindigira You can always make a PR, so we can review it and maybe add it afterwards. :-)

@shindigira any update on the PR?

@shindigira I'm looking into adding DnD capabilities using react-dnd, but if you've already done so, I'd love to leverage what you've got.

I'm evaluating tree components to pair up with a react-table.  What I need is DnD support within the tree and from the tree to the table.
I really like the design decision of react-table to allow component overrides
https://github.com/react-tools/react-table#component-overrides
It looks like this project already does this to some extent.  Is there any opposition to expand this to allow the TreeNode, etc. to be overridden in a manner like react-table?
Having DnD  built into the tree would certainly be nice as well.  But I'm guessing others have the same requirements I'm faced with.

@asifmom @firetiger77 Apologies for not responding for this many moons ago. Would you still like me to PR this? I have it still as WIP and not flushed out.

Same story: I'm looking to add dnd support, and I can't seem to find any existing plugins or examples of react-treebeard using react-dnd. Does anyone have any links they could share to save me writing it from scratch myself?

Hi! I'm going to start work this issue.

Any luck @maximilianoforlenza ?

@maximilianoforlenza  These guys made it, maybe you can see how they handle it https://github.com/react-component/tree 👌

I am a developer from samsara.com . We're interested in using this component and want to give back to the community. I can help if you need it  @maximilianoforlenza

any progress? :)

any update about this? i am interested to help if necessary


peerswap-plugin binary is 0 bytes

When bringing up the containers, it appears the peerswap-plugin binary is actually a 0-byte file and seems to be causing issues with the CLN container.

Oh, that not correct indeed. Let me compile again


Closed source updates

@TobyRoseman These changes went into the closed-source repo. Cherry picking them back into SFrame.


build(deps): updated dependencies

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.67%. Comparing base (23bdad6) to head (e04931c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   95.66%   92.67%   -2.99%
==========================================
  Files          21       22       +1
  Lines        1706     1939     +233
==========================================
+ Hits         1632     1797     +165
- Misses         61      129      +68
  Partials       13       13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.