Race in async producer

This is the stacktrace from go test -race:
WARNING: DATA RACE
Write by goroutine 58:
  runtime.closechan()
      /usr/local/go/src/runtime/chan.go:257 +0x0
  gopkg.in/Shopify/sarama%2ev1.(*asyncProducer).shutdown()
      /go/src/gopkg.in/Shopify/sarama.v1/async_producer.go:808 +0x431
  gopkg.in/Shopify/sarama%2ev1.*asyncProducer.(gopkg.in/Shopify/sarama%2ev1.shutdown)·fm()
      /go/src/gopkg.in/Shopify/sarama.v1/async_producer.go:217 +0x34
  gopkg.in/Shopify/sarama%2ev1.withRecover()
      /go/src/gopkg.in/Shopify/sarama.v1/utils.go:46 +0x47

Previous read by goroutine 31:
  runtime.chansend()
      /usr/local/go/src/runtime/chan.go:83 +0x0
  gopkg.in/Shopify/sarama%2ev1.(*syncProducer).SendMessage()
      /go/src/gopkg.in/Shopify/sarama.v1/sync_producer.go:66 +0x244

Our CI already runs with -race so I'm assuming this is not in our test suite (if it is in our test suite, please provide test name and go version).
Off the top of my head this does not look like a sarama bug: something is calling SendMessage after Close on a SyncProducer.

@dim It may happen if you are running test with coverage analysis enabled. If that is indeed the case then make sure to specify -covermode atomic.


base-equal-to-over-spray-condition-fix

getting base id and over id on the control map can occur when spraying, and then rolling the same id over the same area.
then, if base == over and useing the spray tool for another texture, it behaves like the roller tool instead.
this corrects that behaviour.

Thanks!


node_announcements are sent in format violation of BOLT 7

BOLT 7 states:
"The origin node:...MUST NOT include more than one address descriptor of the same type.", however, lnd happily relays along such node announcements (see, eg, the node with alias "BallLightning" which has two IPv4 entires).

$ lncli getnodeinfo 02b813dcf53442e2ba8ac0b7911dc31ab0b62fda5e55b30388efb6c39a8ee54d3c
{
    "node": {
        "last_update":<PHONE_NUMBER>,
        "pub_key": "02b813dcf53442e2ba8ac0b7911dc31ab0b62fda5e55b30388efb6c39a8ee54d3c",
        "alias": "BallLightning",
        "addresses": [
            {
                "network": "tcp",
                "addr": "<IP_ADDRESS>:9735"
            },
            {
                "network": "tcp",
                "addr": "<IP_ADDRESS>:9735"
            }
        ],
        "color": "#ff0000"
    },
    "num_channels": 1,
    "total_capacity": "200000"
}

@Roasbeef @TheBlueMatt
I think about to change the following line in BOLT-7
MUST NOT include more than 21 address descriptor.
https://github.com/lightningnetwork/lightning-rfc/commit/2719d878d4c585e6684db48fd7a5dbccb5d0fba7

Based on the above and my reading of the current spec, it seems this is allowed.


Adding Hippocratic License Version Number: 2.1

This license is from https://firstdonoharm.dev/ and I think it would make a great addition.
This license is on the SPD list https://spdx.org/licenses/
It is included on the GNU list as well https://www.gnu.org/licenses/license-list.en.html.
It is used 426 times on Github. I know this isn't 1,000, but I think it is used enough for consideration and it is becoming more relevant as ethics in software become more of a concern in open-source. Thank you.
https://github.com/search?q=HIPPOCRATIC+filename%3ALICENSE&type=Code

It is used by We transfer (https://github.com/wetransfer/zip_tricks), Ruby Gems,
(https://rubygems.org/gems/rack-read_only), and Gryphon (https://github.com/vinivendra/Gryphon Gryphon).

It shows up on the "Non Free Software" license section https://www.gnu.org/licenses/license-list.en.html#NonFreeSoftwareLicenses not as an endorsement

As @nschonni says and see the note in https://github.com/github/choosealicense.com/blob/gh-pages/CONTRIBUTING.md#adding-a-license

GNU's list of free licenses (note: the license must be listed in one of the three "free" categories)

There is a test for this, but I it's not reached in this PR because the added file doesn't have any metadata -- from the same link (for future reference):

Each license has both required and optional metadata that should be included.


Create ru_ru.json

i am not sure of its quality, but it is a translation to Russian

Thanks for the translation! I'll add it in the next update in a few hours on Modrinth. I am working on the textures together wirh a friend and I am waiting for my Friend.


Fix kafka consumer offset lag of at least 1 by using offset + 1 when committing.

Pull request
Description
We have been doing it wrong all the time. We manually committed offsets when enable.auto.commit: false has been configured the wrong way by taking the kafka record offset and using it in the commit call.
I found out one is expected to add 1 to the offset to denote "I consumed this message, don't give it to me again.".

Note: The committed offset should always be the offset of the next message that your application will read. Thus, when calling commitSync(offsets) you should add one to the offset of the last message processed.

https://kafka.apache.org/10/javadoc/org/apache/kafka/clients/consumer/KafkaConsumer.html
There is currently no cool way to test this. We need to setup some more involved end to end tests for this.
But wanted to get this out quickly.
Related
Checklist

[x] The RFC, if required, has been submitted and approved
[x] Any user-facing impact of the changes is reflected in docs.tremor.rs
[ ] The code is tested
[x] Use of unsafe code is reasoned about in a comment
[x] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[x] The performance impact of the change is measured (see below)

Performance

Coverage remained the same at 81.657% when pulling 1ffaa603cd0113ba5a19f962ad85ad25ad32c2a7 on kafka-source-offsets into 927bc54259ce74c1be84c0ecc50fbf5989c861bc on main.


In Multiple Swipable List renderRight/LeftHiddenRow rowId and secId type is string instead of integer

This is not exactly an issue, but I figure out in Multiple Swipable Lists, the type of rowId and secId that pass in renderRight or renderLeftHiddenRow as parameters are string instead of Integer. As they are Id I consider they are integer but they return string.
renderRightHiddenRow={(marker, secId, rowId, rowMap) => {
    console.log(typeof(rowId)); //"string"
    console.log(typeof(secId)); //"string"
}

@liamse the value of secId is string. This is as designed


maintenance - Wrong Enum Value of rebootSetting

When specifying rebootSetting to Never as shown in the swagger below, service returned it as NeverReboot
https://github.com/Azure/azure-rest-api-specs/blob/8335066d60a43a53d23eb483bc283c8c4a1c730d/specification/maintenance/resource-manager/Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L2106-L2112
PUT https://management.azure.com/subscriptions/***/resourceGroups/***/providers/Microsoft.Maintenance/maintenanceConfigurations/***?api-version=2022-11-01-preview
{
    "location": "eastus",
    "properties": {
        "namespace": "Microsoft.Maintenance",
        "extensionProperties": {
            "InGuestPatchMode": "User"
        },
        "maintenanceScope": "InGuestPatch",
        "maintenanceWindow": {
            "startDateTime": "5555-12-31 00:00",
            "expirationDateTime": "6666-12-31 00:00",
            "duration": "02:00",
            "timeZone": "Pacific Standard Time",
            "recurEvery": "2Days"
        },
        "visibility": "Custom",
        "installPatches": {
            "rebootSetting": "Never",
            "windowsParameters": {
                "kbNumbersToExclude": [],
                "kbNumbersToInclude": [],
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            },
            "linuxParameters": {
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            }
        },
        "configurationType": "Regular"
    }
}

GET https://management.azure.com/subscriptions/***/resourceGroups/***/providers/Microsoft.Maintenance/maintenanceConfigurations/***?api-version=2022-11-01-preview
Response:
{
    ...
    "properties": {
        ...
        "installPatches": {
            ...
            "rebootSetting": "NeverReboot"
        },
    }
}

Reported in https://github.com/hashicorp/terraform-provider-azurerm/issues/20684

@myc2h6o Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@myc2h6o I have shared the feedback with the Product Group team. They have created a workitem internally to track the fix from the service side.

@myc2h6o I am still waiting for the updates from the Product Group team for the fix. I will update this thread once I hear from them.

@navba-MSFT any update on this one, looks like the associated PR has been closed due to waiting for a response?
Could you clarify what's needed to get this one fixed, given the API isn't returning the values defined in the Swagger?
Thanks!

@navba-MSFT any update on this one, looks like the associated PR has been closed due to waiting for a response?
Could you clarify what's needed to get this one fixed, given the API isn't returning the values defined in the Swagger?
Thanks!

@tombuildsstuff The fix should be provided from the service side and not from the swagger side. Hence the PR is closed. As mentioned above, I am waiting for the updates from the Product Group team. I will update this thread once I hear from them.

@myc2h6o @tombuildsstuff  The fix for this issue would be released by end of May23.

@myc2h6o @tombuildsstuff Due to some configuration issue in the test build, the fix is not yet released. We are still working on this. We will keep you posted.

I have involved the service team and they are still working on this. There is no ETA for the fix. Removing CXP attention label and adding Service-attention labal.

can you prio this one? I assume more and more people will start using Update Manager and this bug can be quite annoying

Hi @navba-MSFT , any update on this?

It seems still an issue with the latest stable and preview API. Never is configured in the PUT request for rebootSetting as described in the API Spec, however NeverReboot which is not in the API Spec is returned from the GET response. Below is thet test I made:
PUT https://management.azure.com/subscriptions/xxx/resourceGroups/test/providers/Microsoft.Maintenance/maintenanceConfigurations/test_config?api-version=2023-04-01

Request body:
{
    "location": "eastus",
    "properties": {
        "namespace": "Microsoft.Maintenance",
        "extensionProperties": {
            "InGuestPatchMode": "User"
        },
        "maintenanceScope": "InGuestPatch",
        "maintenanceWindow": {
            "startDateTime": "5555-12-31 00:00",
            "expirationDateTime": "6666-12-31 00:00",
            "duration": "02:00",
            "timeZone": "Pacific Standard Time",
            "recurEvery": "2Days"
        },
        "visibility": "Custom",
        "installPatches": {
            "rebootSetting": "Never",
            "windowsParameters": {
                "kbNumbersToExclude": [],
                "kbNumbersToInclude": [],
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            },
            "linuxParameters": {
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            }
        },
        "configurationType": "Regular"
    }
}

GET https://management.azure.com/subscriptions/xxx/resourceGroups/test/providers/Microsoft.Maintenance/maintenanceConfigurations/test_config?api-version=2023-04-01

Response:
{
    "location": "eastus",
    "tags": {},
    "properties": {
        ...
        "installPatches": {
            "rebootSetting": "NeverReboot",
            ...
        }
    }
}

PUT https://management.azure.com/subscriptions/xxx/resourceGroups/test/providers/Microsoft.Maintenance/maintenanceConfigurations/test_config_preview?api-version=2023-10-01-preview

Request body:
{
    "location": "eastus",
    "properties": {
        "namespace": "Microsoft.Maintenance",
        "extensionProperties": {
            "InGuestPatchMode": "User"
        },
        "maintenanceScope": "InGuestPatch",
        "maintenanceWindow": {
            "startDateTime": "5555-12-31 00:00",
            "expirationDateTime": "6666-12-31 00:00",
            "duration": "02:00",
            "timeZone": "Pacific Standard Time",
            "recurEvery": "2Days"
        },
        "visibility": "Custom",
        "installPatches": {
            "rebootSetting": "Never",
            "windowsParameters": {
                "kbNumbersToExclude": [],
                "kbNumbersToInclude": [],
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            },
            "linuxParameters": {
                "classificationsToInclude": [
                    "Critical",
                    "Security"
                ]
            }
        },
        "configurationType": "Regular"
    }
}

GET https://management.azure.com/subscriptions/xxx/resourceGroups/test/providers/Microsoft.Maintenance/maintenanceConfigurations/test_config_preview?api-version=2023-10-01-preview

Response:
{
    "location": "eastus",
    "tags": {},
    "properties": {
        ...
        "installPatches": {
            "rebootSetting": "NeverReboot",
            ...
        }
    }
}

It's been over a year since this was opened and the bug is very annoying. Any updates?


[hold for #20486] [$1000] Money Request - no tooltip shown for the "To" email address

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Request money from any user, which will create a new report for that request.
Hover over the "share code" option.
Open the new owes report.
Hover over the email written under "to".
The tooltip does not appear for that user

Expected Result:
The tooltip should appear for both users.
Actual Result:
The tooltip does not appear for the user whose email is written under "to".
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/aa7dcb66-a1ed-48aa-9445-e6a0f0d0006a
https://github.com/Expensify/App/assets/43996225/c7e1d0cc-6ccd-4027-a447-feac9b81d059
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684346461913589
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ee8291cc04f7b5cf
Upwork Job ID:<PHONE_NUMBER>213466112
Last Price Increase: 2023-05-29

Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
The tooltip is not appearing in the Money Request/Owes header for the user who owes money or whose email is written under "to".
What is the root cause of that problem?
Money request header for payee is rending via text component as shown code block below:
https://github.com/Expensify/App/blob/737862677811acc2b05c68209a56ecd58bee59f3/src/components/MoneyRequestHeader.js#L120-L125
There is not no tooltip used with this text component. So it will not show tooltip. This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
To solve this we can wrap Text component with tooltip, but it will not work because text component is extend up to right end due to its parent component has flex1 set here.
So within src/components/MoneyRequestHeader.js we have to replace Text component (line. 120-125) with DisplayNames as shown in code below. It will provide tooltip. We are using DisplayNames for payer name also.
<DisplayNames
    fullTitle={payeeName}
    displayNamesWithTooltips={[{displayName: payeeName, tooltip: moneyRequestReport.managerEmail}]}
    tooltipEnabled
    numberOfLines={1}
    textStyles={[styles.headerText, styles.pre]}
    shouldUseFullTitle={isExpenseReport}
/>

This will solve the isse and shows tooltip for payee header name as shown in result video.
What alternative solutions did you explore? (Optional)
None.

Results
https://github.com/Expensify/App/assets/7823358/0298aa3a-8e13-43e9-af1b-fd0f1d6d6bb7

not overdue!

Hey @sobitneupane, it looks like we have enough proposals. Can you please review them? Thanks!

@isabelastisser Can you please clarify what is the expected behavior here?
As of now, only Display Name on the first row has tooltip. Do we want to add tooltip just to Display Name on the second row or to avatars as well? Unlike ChatHeaders in normal messages, header in money requestor page is not clickable.
https://github.com/Expensify/App/assets/25876548/91474c14-8170-4b47-ad8c-b3d0511fdbf8

@sobitneupane It seems like in chats we show the tooltip on both the avatar and the display name. Let's keep it consistent and do the same here.

Proposal from @allroundexperts to introduce tooltip on both the avatar and display name goods to me. Implementation details can be tweaked in PR if required.
🎀👀🎀 C+ reviewed
cc: @youssef-lr

Is https://github.com/Expensify/App/issues/19774 a dupe? I feel like the same PR should address this all :think

@allroundexperts @sobitneupane @youssef-lr what do you think?

You mean "update the test steps" in this GH specifically?

Understood! Done.
My recommendation for next steps:

Keep this GH open and handle both bugs. They could be separate but it feels like high overlap like @allroundexperts mentioned :)
Close the other GH https://github.com/Expensify/App/issues/19774
Double bounty to $2000 (for added scope - it would've been 2 separate jobs worth this amount anyway)
Pay 2 bug reporting bonuses here to each individual that reported (updated GH body to include that)

Ok... I am realizing this was a mistake. These issues are slightly different and we need to figure out the desired behavior for the hover/interactiveness of Amount/Description/Date
I'm going to undo everything I just did

@isabelastisser sounds good to me!

@allroundexperts replied!

Summary:
A contributor is assigned, and PR is created!
I'm reassigning (SO) because I will be OOO until June 14. Thanks!
`Once I return from OOO if the chore is still outstanding, I will take over any remaining action items.

@allroundexperts replied in your PR.

Taking this back!

No updates, PR is not merged yet.

No updates, PR is not merged yet.

I will be OOO until July 5, so assigning another team member. SO for reference.

Looks like PR is pending review from @youssef-lr

@joekaufmanexpensify @youssef-lr  We are going to update the money request header in https://github.com/Expensify/App/issues/20486. I don't think this issue will be any longer valid with the new money request header.

Ah, interesting. Are you thinking we should just close this one then?

Yes, I think we can close this or hold this issue and recheck after https://github.com/Expensify/App/issues/20486 gets resolved.

Cool, yeah let's hold for that issue. Then, once it's done we can test and close if this is fixed!

Making this weekly since it's on hold!

On hold still.

I'm back. Thanks @joekaufmanexpensify !

This is on hold pending progress here.


Third/booster doses

DOH has started reporting number of people with 3 or more doses of COVID-19 vaccine.  As of 9th November, the only number reported is a national figure for 16+.

From 12 November, this figure will be reported in this feed:
air.csv and air.json

AIR_AUS_16_PLUS_THIRD_DOSE_COUNT
AIR_AUS_16_PLUS_THIRD_DOSE_PCT

If state-by-state breakdown is provided in the future, these values will be populated in air.csv/json and air_residence.csv/json as well

Implemented by https://github.com/jxeeno/aust-govt-covid19-vaccine-pdf/pull/24


fix: updated NodeSet fixes #239

@DrHaraldWeber please take the changes also to your main version as you are the editor.


main: Bump search LIMIT from 10 to 50

RediSearch default is 0..10 but, since we don't support paging, let's simply increase the amount of results. Otherwise, a lot of valid results are missing e.g. "sugarlabs" only brings 10 results.

@barthalion not sure if 50 is too much either, but I suppose we can simply reduce if it is.

I think 50 is fine, I never connected the dots why there's only 10 results.

(Also, thanks!)


Could you explain the meaning of data block_r?

The item block_r in data file.

These are free bonds where chemical building blocks would attach


Add Code of Conduct

@pseudotensor Is this being closed because you don't want a CoC in this project?  (I didn't see one added, so I was confused as to why this got closed).  Adding @init27 @parulnith because they should be able to help you add the CoC; you could easily copy the one from here: https://github.com/h2oai/wave/blob/master/.github/CODE_OF_CONDUCT.md


JDBC H2, CHAR(10) column read as Char? instead of String?

@zaleslaw
From an H2 database, a CHAR(10) column is read as Char? instead of String?
This issue can be reproduced easily by editing the fun `read from huge table`() in h2Test.kt by adding the line:
schema.columns["characterCol"]!!.type shouldBe typeOf<String?>()
The column contains ["ABC", "DEF", "GHI"] so I gotta agree it's not supposed to be a Char.
I discovered it by exploring whether the DataColumnImpl.type actually matches the types found in DataColumnImpl.values, which mismatches in this case. It might be a good check to do for all type conversions :).

@Jolanrensen what kind of dialect is set by default for H2 in your example?

@zaleslaw not sure, I just ran your read from huge table test in h2Test.kt, so looking at that file, the connection URL is created like this: https://github.com/Kotlin/dataframe/blob/e781bf7de70a20513b190b959967195fa4795d7f/dataframe-jdbc/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/h2Test.kt#L21


Testing for SVG and CANVAS elements have text equivalents

Need tests for SVG and CANVAS for text equivalents, just like IMG element

This will be part of Version 1.1 of the OAA library

Check with Fred Esch and Steve Faulkner about implementation of text equivalents for SVG and Canvas


Query: Disallow client evaluation of queryable methods in projection

If subquery in projection fails to translate we try to client eval outside of Select in subquery. Which is against the design. (As a where which did not go to server will fetch extra data).

This may have been fixed by @ajcvickers changes for client eval exception. Relevant tests are in BuiltInDataTypesSqliteTest tagged with issue #15249

Also this needs to go in 3.0

Taking a look.

After re-thinking, realized that existing change wouldn't fix this.
https://github.com/aspnet/EntityFrameworkCore/blob/ba5c3f768bb2cefcf6d84e0a6edc7dc1a12c6649/src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs#L298-L313
Above block is supposed to throw when failing to translate. (It is bit different pattern though we are also short-circuiting using queryable method translator when translating queryable methods)


How to handle timezone issue with moment-from-now?

Hello,
I have a time that is ahead a few hours in timezone that is being displayed improperly, how could I resolve this?
Example: The time should be displayed as "a few seconds ago" but instead it is "in 3 hours"
moment: {
  includeTimezone: 'all'
},

I added that per the docs but no effect,
thanks!

Are you setting the timeZone globally or passing it in as an attribute?
https://github.com/stefanpenner/ember-moment#configure-default-runtime-localetimezone

I a similar issue. I have a server date which is represented in UTC "Tue Jun 20 2017 08:02:35 GMT+0200" but my local time is +2. Ember moment still shows UTC.
My setup:
package.json:
"ember-moment": "^7.3.1"
env~.js
moment: {
includeLocales: ['de'],
includeTimezone: 'all'
},
application router:
moment: Ember.inject.service(),
beforeModel() {
this.get('moment').setTimeZone('Europe/Berlin'); //with or without, same result
}
in my template:
{{moment-from-now regionRolesChange.created_at hideSuffix=false}}
--OUTPUTS UTC
{{regionRolesChange.created_at}}
-- OUTPUTS  "Tue Jun 20 2017 08:02:35 GMT+0200"

I got it running with this transform https://github.com/thoughtbot/ember-utc-transform

If anyone can replicate the issue and push an example somewhere please do and reopen.


Site changes

Adds general structure for best practices site.

General site structure
/content/en/community/contribute/_index.md includes instructions for previewing the site locally with Docker. Setup with Netlify for automated previews pending.
/content/en/community/contribute/style-guide.md has some lightweight style guidance, including using SVG for diagrams

"Landing a 5000+ file change, no problem!"
:)


Move StringManager to its own component

Test: build, run StringManagerTests

To get some more context:
I assume this change is because the class will be used by multiple modules?
And do we not want this class in OrbitBase? What would be the downsides of that?

To get some more context:
I assume this change is because the class will be used by multiple modules?
Yes, it is going to be use in CaptureDataProvider

And do we not want this class in OrbitBase? What would be the downsides of that?
We will probably end up removing it at the end of the 2nd stage. This is why I did not want to move it to OrbitBase

We will probably end up removing it at the end of the 2nd stage. This is why I did not want to move it to OrbitBase

Sounds good, but then I would suggest a TODO and a bug explaining when the class should be removed (or moved to OrbitBase if it can't be removed at the time you assume it would be removed).

We will probably end up removing it at the end of the 2nd stage. This is why I did not want to move it to OrbitBase

Sounds good, but then I would suggest a TODO and a bug explaining when the class should be removed (or moved to OrbitBase if it can't be removed at the time you assume it would be removed).

It seems to be a bit early for a TODO... todo is something that could probably be addressed independently. This is part of long capture project and cannot be done before we finish with 2nd stage.

It seems to be a bit early for a TODO

Why do you think it's early? It would explain what you just explained to me, but we would have a reference with a bug and in the code instead of just in a code review.

we are going to end up doing this for CaptureData, DataManager and some other number of classes. I think this is not a todo for the current state of the project. If we end up not removing them but refactoring them this todo will prove itself invalid. too early to tell.
"TODO: This will probably be removed at some point in the future" applies to almost everything :)

we are going to end up doing this for CaptureData, DataManager and some other number of classes. I think this is not a todo for the current state of the project. If we end up not removing them but refactoring them this todo will prove itself invalid. too early to tell.
"TODO: This will probably be removed at some point in the future" applies to almost everything :)

Ok, from what you had said I had understood that the plan on when to remove this was clearer than apparently is.


Setup CITATION.cff

This PR adds a basic setup for citation metadata powered by CITATION.cff, as discussed in #210.  (Please note that any papers citing this project using these information are yet to be written. 😉)

The next step is to discuss the actual implementation of the update automation for the CITATION.cff.  The update steps are rather straightforward:  replacing the old version with the new one and updating the release date to "today".
Is there any workflow I can put the two required sed commands or do you use cargo-release?

The next step is to discuss the actual implementation of the update automation for the CITATION.cff. The update steps are rather straightforward: replacing the old version with the new one and updating the release date to "today".
Is there any workflow I can put the two required sed commands or do you use cargo-release?

I have just been doing it manually and thinking that I should find a tool to automate it. Rather than adding sed commands let's do that now...? Maybe cargo-release is a good choice. It looks like we could configure it to update this file. Filed #213

@sourcefrog
You can go ahead and merge this PR.  I will submit a separate PR for the automatic maintenance (#213).

The tests are not running because the Docker image for the validation tool is not a trusted Action, yet.  How to fix this problem, @sourcefrog?

Thanks for diagnosing it. I can add it to the allowlist.

I will close and reopen this PR to have the tests run once again.

I looked at the Actions docs and I couldn't see how to allow Docker containers.
On the whole this doesn't seem like a file that is likely to be edited very often at all (other than version bumps) and so it's not really important to have it automatically validated. So, could you remove that for now and we'll just add the file?

Yes, no problem.  I will remove the test. :+1:

I just updated the version and date-released fields to refer to today's release.  You can go ahead and merge this PR, I removed the test as you requested.


Word is only comprised of latin characters.

This fixed that autowrap does not work with Chinese or other languages.

fixed a autowrap bug when word is too long.

I fixed these.


Integration Test - Release - 2019/05/16 16:32:36

Auto create for integration test. IssueCommandFlow

@adunndevster : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Support Android Test Orchestrator

Describe the solution you'd like
Give support for Android Test Orchestrator.
Additional context
https://github.com/microsoft/appcenter/issues/1208

As we do not have plans to add support for this feature in the next year, I'm closing the issue.


Only add dependency if file really exist.

This might be a fake filename, eg by NOT IMPORTED prefix by compass-import-once.
Fixes issue here: https://github.com/Compass/compass/issues/1951

@craigmcnamara I created a new PR. Do you have a hint on how to fix the specs. Seem to be broken due to ruby version... version 2.2 required...

@f1sherman: Since @craigmcnamara is not responding. Do you have any suggestions on how to bring this into master?

@fpellanda sorry I'm not sure, I don't have push permissions to this repository. You may already be aware of this but it appears that the parent compass library has been deprecated.
https://github.com/Compass/compass


error

Fatal error: Uncaught exception 'Exchanger\Exception\ChainException' with message 'The chain resulted in 2 exception(s): Http\Client\Exception\RequestException: cURL error 60: SSL certificate problem: unable to get local issuer certificate (see http://curl.haxx.se/libcurl/c/libcurl-errors.html) Http\Client\Exception\RequestException: cURL error 60: SSL certificate problem: unable to get local issuer certificate (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)' in F:\phpStudy\WWW\rate\vendor\florianv\exchanger\src\Service\Chain.php:66 Stack trace: #0 F:\phpStudy\WWW\rate\vendor\florianv\exchanger\src\Exchanger.php(56): Exchanger\Service\Chain->getExchangeRate(Object(Exchanger\ExchangeRateQuery)) #1 F:\phpStudy\WWW\rate\vendor\florianv\swap\src\Swap.php(91): Exchanger\Exchanger->getExchangeRate(Object(Exchanger\ExchangeRateQuery)) #2 F:\phpStudy\WWW\rate\vendor\florianv\swap\src\Swap.php(51): Swap\Swap->quote('EUR/USD', NULL, Array) #3 F:\phpStudy\WWW\rate\index.php(13): Swap\Swap->latest('EUR/USD') #4 {main} thr in F:\phpStudy\WWW\rate\vendor\florianv\exchanger\src\Service\Chain.php on line 66

Use this certificate root certificate bundle:
https://curl.haxx.se/ca/cacert.pem
Copy this certificate bundle on your disk. And use this on php.ini
curl.cainfo = "path_to_cert\cacert.pem"


Documentation improvements - November 18, 2023

Description
In CONTRIBUTING.md, a reference URL to one of the pre-requisite tools (golangci-lint) takes the reader to the wrong link for the site. It directs the user to https://pre-commit.com/ rather than https://golangci-lint.run/
In README.md, there is a warning applicable to all project contributors. As a reader, I thought it would be helpful to include an emphasis around the warning to make it stand out to the reader.
I have a submitted a PR to address both of these document changes here: https://github.com/acrlabs/simkube/pull/82

Merged, thanks for the fix!


React vite webview

Hello Ola, this is me Akmal again.
I'm making this PR that implements React with Vite for Codebuddy extension webview.
I was actually following this simple video here
Related repos mentioned in the video as references are:

vscode webview ui toolkit
vscode webview ui toolkit getting started guide
vscode webview ui toolkit hello-world-react-vite
vscode extensions new project release by rxliuli at dev.to

Also, I have this video of mine here that shows that the extension webview is indeed using React now.
The video is made unlisted, so only those who have the link can view it.
(Video link here)[https://youtu.be/2D6g_15--hc]
Issues
The only issues that I had was that apparently, I cannot make use of getConfigValues, or rather cannot make use of anything from the "vscode" library for building the React with Vite webview, because if you see on the package.json file itself, the "vscode" library is NOT an npm package but rather like an internal library that works inside vscode only.

Hence, that is why you will see that in the base web provider file, I added setInterval of 3 seconds that will post message back to the React webview if any changes in the configuration styles for the extension.

HI @darkelfs56, Akmal, I appreciate this contribution. I will look into the PR. Good job buddy!


Can't import Bestiary 4 - Giraffe (Herd Animal)

Can't import statblock:
Giraffe (Herd Animal)      CR 3
XP 800
Giraffe (Pathfinder RPG Bestiary 4 150)
N Huge animal
Init +2; Senses low-light vision; Perception +8
Defense
AC 16, touch 10, flat-footed 14 (+2 Dex, +6 natural, -2 size)
hp 30 (4d8+12)
Fort +7, Ref +6, Will +2
Offense
Speed 50 ft.
Melee 2 hooves +6 (1d8+5), slam +1 (1d8+2)
Space 15 ft.; Reach 10 ft.
Statistics
Str 20, Dex 15, Con 16, Int 2, Wis 13, Cha 7
Base Atk +3; CMB +10; CMD 22 (26 vs. trip)
Feats Endurance, Run
Skills Acrobatics +2 (+6 to jump with a running start, +10 to jump), Perception +8
Ecology
Environment warm plains
Organization solitary, pair, or herd (3-10)
Treasure none
Special Abilities
Endurance +4 to a variety of fort saves, skill and ability checks. Sleep in L/M armor with no fatigue.
Low-Light Vision See twice as far as a human in dim light, distinguishing color and detail.
Run Run 5x your speed in light/medium armor or 4x speed in heavy armor and keep Dex when running.

Used your latest module that was available as of about 10:30 am. I used Hero Lab to produce this statblock. For greater accuracy, you might want to use one of the online resources. Hero Lab can truncate some of the text -- or inject errors due to a lack of data. All the other statblocks from Bestiary 4 imported -- a total of more than 85% imported!


units other than "px" ?

💬 Questions and Help
From the example of the home page it is unclean which unit types are used for things like padding, margin, & font-size (which isn't shown in the demo)
While the theme page provides a very shallow explanation to what's shown on the home page (I think it should explicitly write on the home page which units are used) the theme page does not explain how to use other unit types, such as em or rem.
For margins or paddings, should this:
space: [0, 1, 2]

become this?
space: [0, "1em", "1em"]

Thanks!

Inside space array you specify indices from 0 to n (desired):
  space: [0, 2. 4. 8. 12, 24]

and it becomes your theme constraints, so if your use xstyled and types:
.header {
  padding: 2
}

xstyled deals with this value as with index of the space array, so 2 becomes space[2] -> 4, and css-in-js libriaries (styled-components or emotion) convert numbers to pixels, so it becomes '4px'
if you specify this array like
  space: [0, '2em', '3em', '4em']

2 becomes space[2] -> '3em', and css-in-js libriaries (styled-components or emotion) don't convert it, as it is a string, so it will be '3em'

So, if you use a raw value like '2' or '4' as the value of the css property xstyled deals with it like with index according to which theme group the specific css propery is related.

maybe it will be nicer if you set the units of the Array outside of it, in your theme, like so:
space: [0, 2, 4, 8, 12, 24]
space.units = "rem"

And your wrapper would use the units value, if specified, else default to px

Hello all, this is solved by transformers, it is available in v1.8.0.


Add CoinZark to exchange listings

CoinZark needs to be added to the buy-navcoin page.
https://www.coinzark.com/nav
Acceptance Criteria
Add exchange to exchange listings

[ ] Title
[ ] Link
[ ] Logo (400x400)

claimed by @roast-nav

Resolved by https://github.com/navcoin/navcoin-org/pull/205


How to use TracerAwareInstrumentation

Hi,
I'm trying to instrument HTTP Kit client so that it would include headers needed for distributed tracing.
I figured that best way to do this would be to instrument HttpClient#exec. My idea was that I could add the header in RequestConfig.headers Map with onMethodEnter on exec.
I planned on using TracerAwareInstrumentation and added elastic-apm-agent as dependency with provided scope, but my IDE doesn't seem to find bci package for some reason.
Anyway, is the approach possible and correct for HTTP Kit or is there a better way?

I was able to get the bci package loaded. I guess proper dependency refresh helped. When using the SDK, I guess we are not supposed to use the agent or tracer or other such "inner" libraries in a plugin.
I also noticed that RequestConfig is quite (package) private and as such doesn't easily give anything to get or set. I could probably use byte code manipulation to achieve my goal, but that doesn't really seem like the proper way.
As such, this is all too complicated and taking more time than I'm willing to spend on this at the moment.

Hi, the community plugin is targeted at using the public APIs - either the Elastic APM Java agent or the OpenTelemetry one - not the internals of the agent. For example OTel context propagation would be the recommended option to set distributed tracing headers

Ok, thank you for the clarification.


Can i draw road map in this controller?

I want draw road map with this contoller,how can i do that?

What do you mean by "Road Map" do you have any sample?

Ping :)

I will close this issue now. Feel free to reopen it if you want to address it again.


[FR] Remove double click → Editing

I force the pop-over to be in reading mode, but when I double-click on the hover, it switches to editing mode. So, I broke file when I miss clicks.
Could you add an option to change this behavior?
It's seems the "double click behavior" is caused by the core parameters for the new pane view. If used with Live preview.

There is no double click behavior built in to Hover Editors. Can you provide a video of what you're referring to as I'm not really following the issue here.

Here a record of this strange behavior : https://www.loom.com/share/2a46535092eb433a9520fd0fcf756631?from_recorder=1&focus_title=1


don’t warn about running as root within Podman and Kubernets container

It's a small improvement to ignore warnings in Kubernets and Podman.
It doesn't seem so elegant to me to have so many conditions inside an if but I just followed the existing pattern.
If you instruct me, I can reimplement anything in another way.
closes #140330
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thank you for contributing, however I am closing this as I've already closed the tracking issue as won't fix.


Learning resources

As a newcomer, I find the readme lacking in resources to learn the framework (this starter project is a good start). The assumption that the user knows how to use React is a barrier to entry, at least for me.
Links to tutorials/blog posts/projects using Inferno without a React background would be great.
In the meantime, I'm assuming that learning React then jumping to Inferno is the way to go?

@Nepoxx Hey, sorry for making the entry barrier hard. This isn't actually intentional. It was assumed that people coming into Inferno pre 1.0 would be coming from React. There is a huge ambition to add docs/website in time for 1.0 release so that people can understand and learn Inferno independently from knowing React. The issue has always been around the API – we knew the API was going to change for the first stable Inferno 1.0 release – so we backed off pushing docs/website until we were happy with the state of the API.
On a side note: we have a Slack and we're super happy to help with issues/guidance/support and if you have any suggestions or want to help us on this project in any way, I'd be more than happy to get you involved. Let me know by emailing me at<EMAIL_ADDRESS>so I can send you an invite :)

The new docs site should fix all these issues. :)


nuxt-i18n types (refering #132)

Fixes #132

Thank you @kevinmarrec

@paulgv I'm working on https://github.com/nuxt/nuxt.js/pull/4164 since few weeks, and on the way I figured out I've some improvements to do around nuxt-i18n.

TypeScript Convention (it's just about dobule quotes and some semi-colons)
Add tests (There will be tests regarding types around nuxt, so having typing tests around here should be nice too)

So I'll open a new issue and PR soon


when

The code is:
strtypeE = '/ukey/libshuttle_p11v220.so.1.0.0'
so_file = strtypeE.decode('gbk')
lib = pkcs11.lib(so_file)
print(list(lib.get_tokens()))
But when i run python code ,i has error is below:
Traceback (most recent call last):
File "pkcs11_test.py", line 10, in
print(list(lib.get_tokens()))
File "pkcs11/_pkcs11.pyx", line 1313, in get_tokens
File "pkcs11/_pkcs11.pyx", line 1298, in pkcs11._pkcs11.lib.get_slots
File "build/bdist.linux-x86_64/egg/pkcs11/types.py", line 118, in init
File "/virtualenv/detect_env/lib/python2.7/site-packages/aenum/init.py", line 2042, in call
return cls.new(cls, value)
File "/virtualenv/detect_env/lib/python2.7/site-packages/aenum/init.py", line 2414, in new
raise exc
ValueError: 7L is not a valid SlotFlag


Cow: Watch safwanp.com

Cow requests the watch of the watch_keyword safwanp\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

safwanp\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Add methods to the request object

It would be nice if we could add the following methods to the HttpRequest interface to allow for easier handling of requests.

[x] json
[x] text
[ ] formdata

Formdata can be handled using the npm library https://www.npmjs.com/package/parse-multipart-data


How to Integrate with swagger

I'd say there's no real difference.
In this example, after invoking MapGet, we could add the same metadata as we see in the docs: https://learn.microsoft.com/en-us/aspnet/core/fundamentals/minimal-apis/openapi?view=aspnetcore-7.0


update to electrum-cash/network v4 or electrum-cash/protocol

Jonathan recommended updating to electrum-cash/network v4 or electrum-cash/protocol

you might want to update to electrum-cash/network v4 or electrum-cash/protocol - did a major update recently after about 8 months or so, which no longer needs manual polyfills for node stuff when run in a browser.

CashScript currently uses "electrum-cash": "^2.0.10"
Upgrading might solve issue #147 'Allow for config-free usage in browser (e.g. Next.js)'

It looks like the ElectrumCluster was removed from the new packages. From checking the BCH Devs telegram group, this should get re-added into the @electrum-cash/application package in the future. If we wanted to migrate now, that would be a breaking change since we go from a cluster to a single client.
So either way, we postpone this to the next major release (v0.11). If by that time, clusters are working again, we'll use a cluster, otherwise we'll make the breaking change to a single client.

we found the documentation at https://electrum-cash.gitlab.io/protocol/index.html
the release notes (and breaking changes) are at https://gitlab.com/electrum-cash/network/-/tags/v4.0.0
and there's also a telegram at https://t.me/electrumcash


Set the sonarqube language

Seemed SonarQube was doing a Java analysis and failing, trying to set it javascript explicitly to see if that works

CI change only


error: address in subscriptions won't run the callback function in production

Hi teams!
I have run below code to dispatchupdateUserAddress function to save the wallet address into redux state.
However, this function is working with no issue in localhost:3000, but it won't work in deployed URL. (I have deployed to Vercel)
Kindly please help to advise I know if I missed any settings for deploying.
"bnc-onboard": "^1.16.0"
Plan: Prototype (Or maybe prototype plan can only work in localhost??)
export const initOnboard = (subscriptions) => {
  return Onboard({
    dappId,
    networkId,
    hideBranding: true,
    subscriptions,
    walletSelect: {
      wallets: [{ walletName: 'metamask' }],
    },
    walletCheck: [
      { checkName: 'derivationPath' },
      { checkName: 'connect' },
      { checkName: 'accounts' },
      { checkName: 'network' },
      { checkName: 'balance', minimumBalance: '100000' },
    ],
  });
};

useEffect(() => {
    const updateUserAddress = (address: string): void => {
      dispatch(setUserAddress(address));
    };

    const onboardData = initOnboard({
      address: updateUserAddress,
      wallet: (wallet) => {
        console.log('wallet', wallet);
        if (wallet.provider) {
          window.localStorage.setItem('selectedWallet', wallet.name);
        } else {
          window.localStorage.removeItem('selectedWallet');
        }
      },
    });
    dispatch(setOnboard(onboardData));
  }, [dispatch]);

  const previouslySelectedWallet =
    typeof window !== 'undefined' && window.localStorage.getItem('selectedWallet');

  useEffect(() => {
    if (previouslySelectedWallet !== null && onboard) {
      onboard.walletSelect(previouslySelectedWallet);
    }
  }, [onboard, previouslySelectedWallet]);

I found solution for this issue.
Just make a login function which run walletSelect and walletCheck function inside.
const login = async () => {
    await onboard.walletSelect();
    await onboard.walletCheck();
  };

  return (
      <button
        onClick={async () => {
          await login();
        }}
      >
        Connect Wallet
      </button>
  );


New with spread

Implements #2369. Adds ES5 support for spread operator in new expressions. ES3 targets should still output warning as before, because it doesn't support Function.prototype.bind which I use in this ES5 implementation. I refactored some of the code from previous call with spread implementation #1931 so I could reuse it to on my implementation.
I have also manually tested the permutations of the outputted JavaScript.

I had some serious trouble with crlf and lf line endings.
I have to turn off autocrlf:
git config --global core.autocrlf=false

In order for my test to pass. Have there been any experiencing the same problem as me? using Mac?

Yes.  Don't use autocrlf :)   It's not appropriate for our project because line endings are an important thing we track and use in our tests.

:+1:
@vladima  and @JsonFreeman can you take a look.

I probably should re-style my tests to use foo, bar, baz, x, y, z and A, B, C.

Revision 2
I've just updated the function name to emitCallTargetAndAccessor to reflect the accessor too. It optionally emits and optionally returns the call target and accessor. I also added some comments about some very specific cases with the implementation. This also addresses a bug I found.
Bug1 (accessor is a string literal)
new object["a-b"](1, 2, a..)

new (a_ = object)["a-b"].bind.apply(a_."a-b", [null]); // should be a["a-b"];

Bug2 (accessor is an numeric literal)
new object["a-b"](1, 2, a..)

new (a_ = object)[1].bind.apply(a_.1, [null]); // should be a[1];

Old comments:
.gitignore
emitter.ts
.types.ts

@JsonFreeman I addressed the problems in the old revision.
I only use Function now and it works.
Also there was no wrong with the new expression call syntax new object.Array()(). But I added a test for it just in case.
Travis is pulling in a wrong commit that's why it is failing. But this one has the right commit https://travis-ci.org/tinganho/TypeScript/builds/62332258. (I think I can only fix this with a new PR though) I contacted travis to address this.

@tinganho Thanks for iterating on this implementation so well. One thing that would be helpful in the future is when you change something, push the changes as new commits instead of amending your old commits. That way it is very easy to see what changed over the course of the discussion.

The one caveat with using Function as I suggested is that there could be a local declaration called Function that shadows the global function. Maybe the Function idea won't work then :disappointed:. Unless we emit some sort of capture, which is overkill I think. Do you think we should go back to the temp idea? Sorry to be fickle.

Do you think we should go back to the temp idea? Sorry to be fickle.

No problem, Ok I can change to your other idea with using temp for "target+accessor".
I will push them as new commits instead of cleaned ones.

Thanks. In terms of the implementation code, I guess my suggestion is that instead of using emitCallTargetAndAccessor, you just call emitCallTarget (the already existing one), and pass in node.expression as the argument (where node is the new expression).

I think that is not so good idea because we want it to emit the accessor to?
For new object.array
it will set the temp to
(a_ = object)

instead of:
(a_ = object.array)

So my suggestion is to emit with a new emitTempExpression or something like that?

hmm, I will try it out and see if there are any problem.

I think it should still give you (a_ = object.array) as the temp

@JsonFreeman yes, I was little bit too fast with commenting without checking it out.

@JsonFreeman should we handle new (...args)() calls because the type checker only handles void functions right now?
Interestingly, I haven't got any error warnings about it when I pass arguments to a void function.

I just pushed a new fix. (Excluding a fix on the type checker. And Travis is still pulling the wrong commit.)

I don't quite understand what you mean in this comment https://github.com/Microsoft/TypeScript/pull/3066#issuecomment-101898274

@JsonFreeman When you do:
function f(...a): () => void {}
let a: string[];
new f(a...)()// error can only new a void function

But in my tests I only define the function as a void function:
function f(...a){}

Right, if you define f as a void function, you cannot call it after you new it. But if you define it as a non-void function, you cannot new it in the first place.
It's okay that you get an error in these cases, the important thing here is that the emit is correct.

Ok I just pushed a fix to always emit a pair of parens ()

Beautiful!! Thanks for doing this, and great work.
So the only thing in the way now is Travis. It says there's a compile error. Are you seeing this locally as well?

@JsonFreeman this is the same commit but on my repo https://travis-ci.org/tinganho/TypeScript/builds/62635340
Travis is pulling in the wrong commit.

I think Travis is saying that if your fork was merged into the main repo on master, it would fail. Can you try pulling the latest from upstream/master and see if that fixes it?

@JsonFreeman it is still pulling in the wrong commit bde2491 instead of b88d542

Let's ask @DanielRosenwasser, since he knows more about Travis

@tinganho I pulled down your branch and I'm getting the same error:

node bin/tsc.js --module commonjs -noImplicitAny --preserveConstEnums --out built\local\tsc.js -sourcemap -mapRoot file:///C:\Users\drosen\tinganho\built\local src\compiler\core.ts src\compiler\sys.ts src\compiler\types.ts src\compiler\scanner.ts src\compiler\parser.ts src\compiler\utilities.ts src\compiler\binder.ts src\compiler\checker.ts src\compiler\declarationEmitter.ts src\compiler\emitter.ts src\compiler\program.ts src\compiler\commandLineParser.ts src\compiler\tsc.ts src\compiler\diagnosticInformationMap.generated.ts

src/compiler/emitter.ts(1916,21): error TS2346: Supplied parameters do not match any signature of call target.

This is related to some recent changes; you need to add the parameter alwaysCopy for emitListWithSpread.
Either way, you'll need to merge in recent changes.

@DanielRosenwasser I could get the errors now. Let me just fix it.

Oh wait, I noticed that
new f(...a, ...b);

will emit as
new (f.bind.apply(f, [void 0].concat(a.concat(b)))();

And with alwaysCopy set to true, it would do
new f(...a)

as
new (f.bind.apply(f, [void 0].concat(a.slice()))();

Can you confirm that this is what happens? This is not what we want, we don't want the slice or the second concat.
Can you add tests for this if it is not already affected?

I think the reason the tests did not catch this is because all the tests have at least one non-spread argument before the spread.

@JsonFreeman I was a little bit fast with the the push button. I think alwaysCopy should be set to false instead of true. Because it was false before.
I can add a test for it.

Sure, but you will still have the double concat problem.

@JsonFreeman is that doable to do f(...a, ...b)? It throws an error now that a spread parameter can only be at the end of argument.

Regarding f(...a, ...b). It is not legal to define a function with a rest parameter that is not at the end. So you can't define a function like this:
function f(...a, ...b) { }

But I meant if you have a function called f, and you call it with two spread arguments:
function f(...p: any[]) { }
var a: string[];
var b: string[];
f(...a, ...b);

And that is legal.

@JsonFreeman I just tested this and it is outputting:
new (f.bind.apply(f, [void 0].concat(a.concat(b)))();

I can't see what's wrong with it? What is the proposed emit?

That emit works, but I think it's nicer to emit:
new (f.bind.apply(f, [void 0].concat(a, b))();

You can achieve this by passing a boolean to emitListWithSpread to make it suppress the concat.

Ok I fixed it on a new commit.

Sweet! Thanks @tinganho! I sign off. Please fix my one nit, and then I can merge it in.

OK @JsonFreeman I fixed it on a new commit. Sorry for not seeing it earlier.

Thanks @tinganho!


chore(README.md): update badges to point to controller

After deis/workflow was changed to deis/controller, the badge images and links broke
cc/ @bacongobbler

if you close and re-open this PR, travis should run again. Feel free to merge though :)

@bacongobbler not sure I know what you mean. Travis seems to still be running?

travis never started a job. I just had to re-jigger travis due to some webhook delays from github about a half hour ago. All is good

Ok, cool. This looks like it needs a rebase anyway...

Current coverage is 83.03%

Merging #514 into master will increase coverage by +0.02% as of 2d4d86e

@@            master    #514   diff @@
======================================
  Files           32      32
  Stmts         1914    1916     +2
  Branches       270     270
  Methods          0       0
======================================
+ Hit           1589    1591     +2
  Partial         61      61
  Missed         264     264

Review entire Coverage Diff as of 2d4d86e

Powered by Codecov. Updated on successful CI builds.


Provide Decoder to turn JSON into Decodable

Hej, it is nice to have JSON as an intermediate correctly-typed abstraction over same JSON data, but at some point I might still want to work with some dedicated data class. However, at that point I might only have the JSON left and I can not make use of some Decoder to turn my JSON into an appropriate Decodable for the task at hand.
I have a concret use case for that, where the concrete structure of my JSON is only clear at a later point in time.
Thus, I would suggest to provide a GenericJSONDecoder to turn a JSON into a Decodable. Analogous to JSONDecoder and Data.
The solution proposed here solves the issue in the meantime, but is really wasteful and rather just a short-time fix:
func decode<T: Decodable>(from json: JSON) throws -> T {
    let data = try JSONEncoder().encode(json)
    return try JSONDecoder().decode(T.self, from: data)
}

Do you dislike the workaround via JSON data in principle (since it is a hack), or does it have particular technical problems for you?

It is not a technical problem, but rather a concern that this is not ideal and can get wasteful for larger JSON structures, as we have to convert back to a JSON string and than into a proper Decodable.
As we have done the JSON parsing already, it makes sense to not redo this work. Also it seems that I am not the only one missing that feature. It is basically a feature request. :)


Can I create a vue component for sonner ?

Hello! 👋,
I as just wondering if I could create a Vue Component for this, either I can integrate with current repo but downside is It would have to be restructured for Vue and React components but also setting up a monorepo. Either way just let me know thanks.
Once it's in Vue it then can compiled down into a Custom Element which would be framework agnostic.
Thanks!
CP
PS. Thanks for creating this amazing toast!

Looking forward to the Vue Component!

Let's not integrate with current repo, feel free to port it tho!


x-* attributes aren’t allowed in schemas

Element implicitly has an 'any' type because expression of type '"x-internal"' can't be used to index type 'OpenAPIV3.SchemaObject | OpenAPIV3_1.SchemaObject | OpenAPIV2.SchemaObject'.
Property 'x-internal' does not exist on type 'OpenAPIV3.SchemaObject | OpenAPIV3_1.SchemaObject | OpenAPIV2.SchemaObject'.

Fixed in the next release. See #166. :)


Sqlite error

Hi, your code compiles correctly, except for some "warnings" on "3rdparty / sqlite3 / sqlite3.c".
However, when I run it, it gives me the following error:
[felice@plasma build]$ ./ed2kd
[nfo] using libevent 2.1.11-stable. available methods are:
[nfo]     epoll
[nfo]     poll
[nfo]     select
[err] (/home/felice/ed2kd/src/db_sqlite.c:134): failed to execute database init script (no such module: fts4)
[err] (/home/felice/ed2kd/src/main.c:141): failed to create database
[felice@plasma build]$

My installation provides SQLITE version 3.30.1.
FTS4 module was enabled:
COMPILER=gcc-9.2.0
ENABLE_COLUMN_METADATA
ENABLE_DBSTAT_VTAB
ENABLE_FTS3
ENABLE_FTS3_TOKENIZER
ENABLE_FTS4
ENABLE_FTS5
ENABLE_JSON1
ENABLE_RTREE
ENABLE_STMTVTAB
ENABLE_UNKNOWN_SQL_FUNCTION
ENABLE_UNLOCK_NOTIFY
HAVE_ISNAN
MAX_EXPR_DEPTH=10000
MAX_VARIABLE_NUMBER=250000
SECURE_DELETE
THREADSAFE=1

Any ideas?
PS: I've tried to input entire "query" string from your code to create database directly from sqlite console. All seems work, no error returned.

Solution: open CMakeLists.txt ad find following rows. The add -DSQLITE_ENABLE_FTS4.
add_definitions(
        -DSQLITE_THREADSAFE=1
        -DSQLITE_ENABLE_FTS5
        -DSQLITE_ENABLE_FTS4
        -DSQLITE_OMIT_LOAD_EXTENSION
)


Support for ArcGIS 10.8

Please provide an installer for ArcGIS Desktop 10.8. Thanks!

Second that. Needs upgrading.

Through contact: ESRI is working on it.

@Chaz6
You probably already saw it (I had missed it myself though), but a 10.8 version is now available:
https://www.arcgis.com/home/item.html?id=2f58a77a65c546149dd1ea425a680ad3
@ThomasEmge , shouldn't this issue be closed?

Thanks for the update!


Dart VM leaks memory on unregistered command line flags

Dart SDK revision: ac3bc9f6351ac0a9c7f6b2dc3db735bd5b9fa2c5
Flutter engine base revision: df619c6a5237c2f82fd48806be2cfaf621024759
Environment: gLinux

[!] Flutter (Channel main, 3.14.0-13.0.pre.60, on Debian GNU/Linux rodete 6.3.11-1rodete1-amd64, locale en_US.utf8)
    • Flutter version 3.14.0-13.0.pre.60 on channel main at /[redacted]/dev/flutter
    ! Warning: `dart` on your path resolves to /usr/lib/google-dartlang/bin/dart, which is not inside your current Flutter SDK checkout at /[redacted]/dev/flutter. Consider adding
      /[redacted]/dev/flutter/bin to the front of your path.
    • Upstream repository git@github.com:flutter/flutter.git
    • Framework revision 956999a4b9 (57 minutes ago), 2023-08-31 16:23:44 -0700
    • Engine revision 10e2df60b0
    • Dart version 3.2.0 (build 3.2.0-126.0.dev)
    • DevTools version 2.27.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /[redacted]/Android/Sdk
• Platform android-31, build-tools 30.0.3
• Java binary at: /opt/android-studio-with-blaze-2020.3/jre/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• Debian clang version 14.0.6
• cmake version 3.25.1
• ninja version 1.11.1
• pkg-config version 1.8.1
[✓] Android Studio (version 3.5)
• Android Studio at /[redacted]/src/android-studio
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Android Studio (version 2020.3)
• Android Studio at /opt/android-studio-with-blaze-2020.3
• Flutter plugin version 65.2.1
• Dart plugin version 203.8452
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[✓] VS Code (version 1.78.0)
• VS Code at /usr/share/code
• Flutter extension version 3.70.0
[✓] Connected device (2 available)
• Linux (desktop) • linux  • linux-x64      • Debian GNU/Linux rodete 6.3.11-1rodete1-amd64
• Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.140
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.

When the Dart VM parses a flag, if the flag is not registered, then the name is captured by Flag but is never disposed, and eventually leaked.
Following is the leakage reported by ASAN:
=================================================================
==132854==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 27 byte(s) in 1 object(s) allocated from:
    #0 0x557aef9e2fdd in operator new[](unsigned long) ../llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/../llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/compiler-rt/lib/asan/asan_new_delete.cpp:98:3
    #1 0x557af52f0573 in dart::Flags::Parse(char const*) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/dart/runtime/vm/flags.cc:400:22
    #2 0x557af52f09d8 in dart::Flags::ProcessCommandLineFlags(int, char const**) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/dart/runtime/vm/flags.cc:447:5
    #3 0x557af5e2a301 in flutter::DartVM::DartVM(std::_LIBCPP_ABI_NAMESPACE::shared_ptr<flutter::DartVMData const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<flutter::IsolateNameServer>) /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/runtime/dart_vm.cc:430:23
    #4 0x557af5e28bb0 in flutter::DartVM::Create(flutter::Settings const&, fml::RefPtr<flutter::DartSnapshot const>, fml::RefPtr<flutter::DartSnapshot const>, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<flutter::IsolateNameServer>) /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/runtime/dart_vm.cc:274:11
    #5 0x557af5e387e4 in flutter::DartVMRef::Create(flutter::Settings const&, fml::RefPtr<flutter::DartSnapshot const>, fml::RefPtr<flutter::DartSnapshot const>) /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/runtime/dart_vm_lifecycle.cc:78:13
    #6 0x557af5f1d29f in flutter::Shell::InferVmInitDataFromSettings(flutter::Settings&) /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/shell/common/shell.cc:154:13
    #7 0x557aefc3ec04 in flutter::(anonymous namespace)::RuntimeControllerContext::Create(flutter::Settings, flutter::TaskRunners const&, flutter::RuntimeDelegate&) /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/lib/ui/window/platform_configuration_unittests.cc:109:35
    #8 0x557aefc3fe48 in flutter::testing::PlatformConfigurationTest_DuplicateRenderCallsAreIgnored_Test::TestBody() /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/lib/ui/window/platform_configuration_unittests.cc:544:7
    #9 0x557af829386f in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2631:10
    #10 0x557af8270920 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2686:12
    #11 0x557af8242dcd in testing::Test::Run() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2706:5
    #12 0x557af8244090 in testing::TestInfo::Run() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2885:11
    #13 0x557af8245200 in testing::TestSuite::Run() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:3044:30
    #14 0x557af825d6cc in testing::internal::UnitTestImpl::RunAllTests() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:5913:44
    #15 0x557af829c5af in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2631:10
    #16 0x557af8274e6d in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:2686:12
    #17 0x557af825cb34 in testing::UnitTest::Run() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/src/gtest.cc:5482:10
    #18 0x557af01821f0 in RUN_ALL_TESTS() /[redacted]/dev/engine/src/out/host_debug_unopt/../../third_party/googletest/googletest/include/gtest/gtest.h:2497:46
    #19 0x557af0181ded in main /[redacted]/dev/engine/src/out/host_debug_unopt/../../flutter/testing/run_all_unittests.cc:71:17
    #20 0x7fd90fbc36c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

The leaked string is disable-service-auth-codes\0, which Flutter has been assigning but I suspect Dart has recently removed. Removing this flag from Flutter's code also eliminates leakage warnings.
Analysis
The leakage message leads us to the following code in flags.cc:
void Flags::Parse(const char* option) {
  // ...
  Flag* flag = Flags::Lookup(name);
  if (flag == nullptr) {
    // Collect unrecognized flags.
    char* new_flag = new char[name_len + 1];     // <-- HERE
    strncpy(new_flag, option, name_len);
    new_flag[name_len] = '\0';
    Flags::Register_bool(nullptr, new_flag, true, nullptr);
  } else {
    // Only set values for recognized flags, skip collected
    // unrecognized flags.
    if (!flag->IsUnrecognized()) {
      if (!SetFlagFromString(flag, argument)) {
        OS::PrintErr("Ignoring flag: %s is an invalid value for flag %s\n",
                     argument, name);
      }
    }
  }

The new_flag is allocated here, passed into Register_bool, and never deleted. Register_bool stores the string in a Flag, but  Flag doesn't deallocate this string either, probably because normally Flag receives a constant string.
FYI, we can't immediately delete new_flag after Register_bool, apparently since it's used in Flag later.
Reproduction
The leakage can be reproduced by running the unit tests introduced in my PR when compiled with --asan. (I understand that having to compile the entire Flutter engine for it might be too much, but honestly I think the analysis above should be convincing enough that a repro is not needed. Let me know if a more isolated repro is wanted.)

Set up the Flutter engine development environment
Check out my PR:

git checkout -b dkwingsmt-enforce-rendering-rule main
git pull git@github.com:dkwingsmt/engine.git enforce-rendering-rule
git checkout 151ed777ca244f187588945f9b2f29012ca8869d

Compile.

gn --asan --unoptimized
ninja -C $ENGINE_SRC/out/host_debug_unopt

Run test:

../out/host_debug_unopt/exe.unstripped/ui_unittests --gtest_filter="*RenderCalls*"

cc @zanderso

Triage: We can close this on our side after https://github.com/flutter/engine/pull/45356.


Added syslog port

Codecov Report

Merging #84 (395d21e) into master (53d6b80) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   62.82%   62.80%   -0.03%
==========================================
  Files         116      116
  Lines        9943     9936       -7
==========================================
- Hits         6247     6240       -7
  Misses       3696     3696

Impacted Files
Coverage Δ

assemblyline/common/log.py
50.68% <50.00%> (ø)

assemblyline/odm/models/config.py
99.42% <100.00%> (+<0.01%)
:arrow_up:

assemblyline/datasource/alert.py
84.61% <0.00%> (-7.70%)
:arrow_down:

assemblyline/common/heuristics.py
87.03% <0.00%> (-1.86%)
:arrow_down:

assemblyline/remote/datatypes/__init__.py
69.49% <0.00%> (-0.51%)
:arrow_down:

assemblyline/remote/datatypes/queues/comms.py
77.77% <0.00%> (-0.49%)
:arrow_down:

assemblyline/odm/randomizer.py
93.39% <0.00%> (-0.48%)
:arrow_down:

assemblyline/odm/random_data/__init__.py
90.04% <0.00%> (-0.42%)
:arrow_down:

assemblyline/datastore/stores/es_store.py
70.26% <0.00%> (-0.05%)
:arrow_down:

assemblyline/run/pubsub_reader.py
0.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d6b80...395d21e. Read the comment docs.

Codecov Report

Merging #84 (395d21e) into master (53d6b80) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   62.82%   62.80%   -0.03%
==========================================
  Files         116      116
  Lines        9943     9936       -7
==========================================
- Hits         6247     6240       -7
  Misses       3696     3696

Impacted Files
Coverage Δ

assemblyline/common/log.py
50.68% <50.00%> (ø)

assemblyline/odm/models/config.py
99.42% <100.00%> (+<0.01%)
:arrow_up:

assemblyline/datasource/alert.py
84.61% <0.00%> (-7.70%)
:arrow_down:

assemblyline/common/heuristics.py
87.03% <0.00%> (-1.86%)
:arrow_down:

assemblyline/remote/datatypes/__init__.py
69.49% <0.00%> (-0.51%)
:arrow_down:

assemblyline/remote/datatypes/queues/comms.py
77.77% <0.00%> (-0.49%)
:arrow_down:

assemblyline/odm/randomizer.py
93.39% <0.00%> (-0.48%)
:arrow_down:

assemblyline/odm/random_data/__init__.py
90.04% <0.00%> (-0.42%)
:arrow_down:

assemblyline/datastore/stores/es_store.py
70.26% <0.00%> (-0.05%)
:arrow_down:

assemblyline/run/pubsub_reader.py
0.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d6b80...395d21e. Read the comment docs.


miniogre run fails on RT-DETR

After cloning https://github.com/lyuwenyu/RT-DETR miniogre fails to run with the error shown below

Attached is the full log

Apparently the full log wasn't attached to the previous message.
I am working on reproducing the error.

Fix provided in new release v0.10.2: https://github.com/ogre-run/miniogre/releases/tag/v0.10.2
Install v0.10.2 via pip or pipx:
pip install miniogre
pipx install miniogre


votenet-sunrgbd visualization error

There is a problem with the visualization, it seems to be related to the rotation angle
mmdetection3d = mmdetection3d-1.0.0rc1
python demo/pcd_demo.py ./data/sunrgbd/points/000015.bin configs/votenet/votenet_16x8_sunrgbd-3d-10class.py ./work_dirs/myvotenet_16x8_sunrgbd-3d-10class/epoch_14.pth --device cuda:1  --score-thr 0.3   --out-dir ../demo_result --show --snapshot

open3d                        0.15.2
opencv-contrib-python         <IP_ADDRESS>
opencv-python                 <IP_ADDRESS>

2022-04-25 17:08:14,658 - mmdet - INFO - Epoch [14][1600/1652]	lr: 8.000e-03, eta: 7:55:24, time: 0.792, data_time: 0.012, memory: 8130, vote_loss: 3.5798, objectness_loss: 0.3804, semantic_loss: 0.4283, center_loss: 0.5644, dir_class_loss: 0.9547, dir_res_loss: 0.7032, size_class_loss: 0.4283, size_res_loss: 0.2672, loss: 7.3063, grad_norm: 7.8146
2022-04-25 17:08:54,242 - mmdet - INFO - Epoch [14][1650/1652]	lr: 8.000e-03, eta: 7:54:45, time: 0.792, data_time: 0.013, memory: 8130, vote_loss: 3.6214, objectness_loss: 0.3990, semantic_loss: 0.4534, center_loss: 0.5275, dir_class_loss: 1.0011, dir_res_loss: 0.6844, size_class_loss: 0.4534, size_res_loss: 0.3061, loss: 7.4464, grad_norm: 8.4020
2022-04-25 17:08:55,907 - mmdet - INFO - Saving checkpoint at 14 epochs
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 5050/5050, 12.0 task/s, elapsed: 420s, ETA:     0s

2022-04-25 17:16:32,371 - mmdet - INFO -
+-------------+---------+---------+---------+---------+
| classes     | AP_0.25 | AR_0.25 | AP_0.50 | AR_0.50 |
+-------------+---------+---------+---------+---------+
| bed         | 0.7831  | 0.9184  | 0.3601  | 0.4971  |
| table       | 0.4491  | 0.8130  | 0.0954  | 0.2632  |
| sofa        | 0.4614  | 0.8102  | 0.0952  | 0.2568  |
| chair       | 0.6985  | 0.8595  | 0.2875  | 0.4797  |
| toilet      | 0.4144  | 0.8690  | 0.0143  | 0.1586  |
| desk        | 0.1554  | 0.7561  | 0.0240  | 0.1849  |
| dresser     | 0.1229  | 0.5734  | 0.0071  | 0.1239  |
| night_stand | 0.2153  | 0.6588  | 0.0003  | 0.0353  |
| bookshelf   | 0.0699  | 0.4397  | 0.0006  | 0.0390  |
| bathtub     | 0.4588  | 0.8367  | 0.0733  | 0.2653  |
+-------------+---------+---------+---------+---------+
| Overall     | 0.3829  | 0.7535  | 0.0958  | 0.2304  |
+-------------+---------+---------+---------+---------+
2022-04-25 17:16:32,811 - mmdet - INFO - Exp name: myvotenet_16x8_sunrgbd-3d-10class.py
2022-04-25 17:16:32,812 - mmdet - INFO - Epoch(val) [14][5050]	bed_AP_0.25: 0.7831, table_AP_0.25: 0.4491, sofa_AP_0.25: 0.4614, chair_AP_0.25: 0.6985, toilet_AP_0.25: 0.4144, desk_AP_0.25: 0.1554, dresser_AP_0.25: 0.1229, night_stand_AP_0.25: 0.2153, bookshelf_AP_0.25: 0.0699, bathtub_AP_0.25: 0.4588, mAP_0.25: 0.3829, bed_rec_0.25: 0.9184, table_rec_0.25: 0.8130, sofa_rec_0.25: 0.8102, chair_rec_0.25: 0.8595, toilet_rec_0.25: 0.8690, desk_rec_0.25: 0.7561, dresser_rec_0.25: 0.5734, night_stand_rec_0.25: 0.6588, bookshelf_rec_0.25: 0.4397, bathtub_rec_0.25: 0.8367, mAR_0.25: 0.7535, bed_AP_0.50: 0.3601, table_AP_0.50: 0.0954, sofa_AP_0.50: 0.0952, chair_AP_0.50: 0.2875, toilet_AP_0.50: 0.0143, desk_AP_0.50: 0.0240, dresser_AP_0.50: 0.0071, night_stand_AP_0.50: 0.0003, bookshelf_AP_0.50: 0.0006, bathtub_AP_0.50: 0.0733, mAP_0.50: 0.0958, bed_rec_0.50: 0.4971, table_rec_0.50: 0.2632, sofa_rec_0.50: 0.2568, chair_rec_0.50: 0.4797, toilet_rec_0.50: 0.1586, desk_rec_0.50: 0.1849, dresser_rec_0.50: 0.1239, night_stand_rec_0.50: 0.0353, bookshelf_rec_0.50: 0.0390, bathtub_rec_0.50: 0.2653, mAR_0.50: 0.2304


gradle opens thousands of files and exceeds the file limit

Project using gradle: https://github.com/broadinstitute/gatk
Most likely you forget to close files.
Version: gradle-4.6
Gatk report: https://github.com/broadinstitute/gatk/issues/5499
Failure log: http://beefy11.nyi.freebsd.org/data/head-i386-default/p486731_s341608/logs/gatk-<IP_ADDRESS>.log
OS: FreeBSD

The issue is unlikely to be in Gradle itself, as we have thousands of tests verifying that Gradle and its core plugins do not leak files. However, the build you linked uses a highly outdated Gradle version (3.1). So the first step should be upgrading to Gradle 4.10.3 or 5.0.
If the problem persists, please use the file-leak-detector on your build. If the leak is actually in Gradle, please attach the leak report.

This happens with gradle-4,6.


fix(executor/docker): fix random errors with message "No such container:path". Fixes #6352

Fixes https://github.com/argoproj/argo-workflows/issues/6352
Root Cause
After docker wait exits 0, there is a chance the container is still in "Created" state.
I'm not sure why that happens, but it now happens stably on GKE per my observation.
Fix
the fix is a workaround to check container status after docker wait and do docker wait again if we found some containers haven't finished yet.
Verification
I reproduced the issue in #6352 stably as explained in https://github.com/argoproj/argo-workflows/issues/6352#issuecomment-892523099.
Then I verified with this PR, the issue never shows up again.
Checklist:

[ ] My organization is added to USERS.md.

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

Thanks,
/hold
Let me fix the unit tests

I might need some help here, I cannot understand why my change relates to the new unit test failure.
How can I run these e2e tests locally?


Multilang: Chinese (Traditional) offroad alerts translation

CHT translation for offroad alerts + minor changes to punctuation marks

Thanks!


Fix the cgroup 2 process attaching problem

What this PR does / why we need it:
Fix the problem when attaching the process to another cgroup when using cgroup 2.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Fixed this issue.
https://github.com/litmuschaos/litmus/issues/3902
Special notes for your reviewer:
Checklist:

[x] Fixes #litmus/issues/3902
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

Hello @kbfu, thank you for your contribution through the pull request.
I would like to inquire about the specific cluster environment and container runtime where you have conducted your tests. We encountered an issue when running it on a GKE cluster with containerd and cgroupv2. Here's the error we observed:
could not get cgroup manager --- at /litmus-go/chaoslib/litmus/stress-chaos/helper/stress-helper.go:134 (prepareStressChaos) --- Caused by: Error in getting groupPath,nsenter: unrecognized option: C BusyBox v1.35.0 (2022-08-01 15:14:44 UTC) multi-call binary. Usage: nsenter [OPTIONS] [PROG ARGS] -t PID Target process to get namespaces from -m[FILE] Enter mount namespace -u[FILE] Enter UTS namespace (hostname etc) -i[FILE] Enter System V IPC namespace -n[FILE] Enter network namespace -p[FILE] Enter pid namespace -U[FILE] Enter user namespace -S UID Set uid in entered namespace -G GID Set gid in entered namespace --preserve-credentials Don't touch uids or gids -r[DIR] Set root directory -w[DIR] Set working directory -F Don't fork before exec'ing PROG

Hi @uditgaurav , I rebuilt the image and replaced the base image from alpine to debian. I believe nsenter command from busybox was outdated.
This is the version I am using now.
nsenter from util-linux 2.38.1

Thanks for your response. I'm wondering if we can integrate this capability within the Alpine-based image itself, as this would help in maintaining a smaller image size.
The corresponding version of util-linux package in Alpine is 2.38-r1.
For your reference, the experimental Dockerfile is located here - litmus-go Dockerfile. It uses the base image litmuschaos/experiment-alpine, sourced from this Dockerfile. Perhaps we can consider adding the required functionality in this Dockerfile.

Hi @kbfu, I've created a test experiment image using the same Alpine-based image, which includes package util-linux 2.38-r1. The image can be found at docker.io/uditgaurav/go-runner:stress.
Current Output:
/ # nsenter --version
nsenter from util-linux 2.38

Previous Output:
~ $ nsenter --version
nsenter: unrecognized option: version
BusyBox v1.35.0 (2022-08-01 15:14:44 UTC) multi-call binary.

It works well with containerd + cgroupv2 🙌. Moving forward, I plan to conduct further tests under these scenarios:

[ ]  containerd + cgroupv1
[ ] docker + cgroupv2
[ ] docker + cgroupv1
[ ]  Recursive experiment execution in both parallel and serial formats

Tagging @ispeakc0de, I would appreciate any input or suggestions for additional tests or use cases for nsenter.


Module system: "jig"

Description
Don't we all want better control over modules, and better performance?
In this issue, I propose a function which I think is feasible to implement: mkJig

A device in manufacturing, woodworking, or other creative endeavors for controlling the location, path of movement, or both of either a workpiece or the tool that is operating upon it. (wiktionary)

This would be a function that, given some settings, transforms a module into a module.
mkJig :: { ... } -> Module -> Module
         ^^^^^^^ some settings
                    ^^^^^^ passed module
                              ^^^^^^ returned module

The settings restrict the structure of the returned module, and perhaps also restrict or alter the module arguments available to the passed module.
Doing this is ambitious. This function is effectively an alternate (simpler?) evalModules that functions as a proxy instead of computing its own fixpoint.
This kind of transformation has the potential to solve a number of issues:

Loading rarely used modules lazily. Only the jig is loaded, but it can cut evaluation short, because the interesting bits weren't needed. Consider for example:
mkJig {
  inputs = ["services" "postgresql"];
  outputs = ["systemd.services"];
} ./postgres.nix

This would translate to a module that declares options.services.postgresql to be a submodule with options forwarded from ./postgres.nix's options.services.postgresql.
A definition config.systemd.services = mkIf options.services.postgresql.isDefined x where x comes from ./postgres.nix's config.
As long as no definitions are given for options.services.postgresql, there's no reason to load postgres.nix.

Ideally services.postgresql wouldn't have to be a submodule, but any option tree. However, isDefined is currently only available for actual options; not for all option trees.
This is particularly valuable if postgres.nix comes from a yet to be fetched source, such as a flake input.

Restricting "side effects". As you can see in the example above, mkJig won't let postgres.nix affect environment.etc.

Altering the environment. mkJig could have its own specialArgs argument, replacing https://github.com/NixOS/nixpkgs/pull/230588 in a way that the args are automatically forwarded to imported modules: nicer DX

Make sure duplicate imports are caught!

Replace partitions which currently require separate evalModules fixpoints for each "use case" or partition. This can be inefficient.

Caveats

Increased complexity in the module system
Overhead unknown
No isDefined for option trees yet

Context

The potential performance improvement overlaps a little with https://github.com/NixOS/nixpkgs/pull/267111, but that PR also solves the problem of having multiple instances of a service, and it is a more elegant solution because it models the domain better with existing means, instead of further complicating the module system.

Notify maintainers
@infinisil @roberth

Add a :+1: reaction to issues you find important.

I thought so before, but then the to-do list was too long so I didn’t raise this issue again.
It is easy to design a fancy new module system, but what we should think about is how to design one that is good enough but also allows us to easily migrate from the current state (just requiring some simple tidying up work or even automatic treewide changes).
Also CC @GTrunSec who did a lot of experiment on module system related works.

how to design one that is good enough but also allows us to easily migrate from the current state

Absolutely.
I think you're responding to:

This function is effectively an alternate (simpler?) evalModules that functions as a proxy instead of computing its own fixpoint.

Not the best phrasing of mine. It won't be a types type or an actual alternative to evalModules; just an implementation of something that has a resemblance to evalModules. The goal is for it to produce modules that are compatible with evalModules.


Added cache expiration

HI, I can reproduce the problem. 😢
Anyway I tried to figure out the problem.
I saw that the serviceWorker is correctly disabled so I added cache expiration in index.html.
Pls give a try. 👍

Hi, @gioboa Thank you for your contribution. I am also not able to triage the exact problem. I will sure try out the caching solution. I am merging the code PR and will test if this solves. Thanks


Update ProvisioningSchema-2019-03.xsd to support VerticalSections on ClientSidePages

Add additional Enum Values to CanvasSectionType and the ability to store LayoutIndex and ZoneEmphasis to CanvasControl

This has been included in schema 201909. Thanks for your contribution.


[Bug]: rag_object.retrieve() issue error

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

RAGFlow workspace code commit ID
000000
RAGFlow image version
0.13
Other environment information
Ubuntu

Actual behavior
Traceback (most recent call last):
File "/Applications/PyCharm.app/Contents/plugins/python-ce/helpers/pydev/pydevconsole.py", line 364, in runcode
coro = func()
File "", line 1, in
File "/Users/shuaihan/miniconda3/envs/X/lib/python3.10/site-packages/ragflow_sdk/ragflow.py", line 181, in retrieve
raise Exception(res.get("message"))
Exception: datasets is required.
Expected behavior
No response
Steps to reproduce
本地按照https://ragflow.io/docs/dev/正常调用该函数

Additional information
No response

Use dataset_ids instead of datasets. It's a bug in 0.13 version.


exporter: Instrument node reimaging success/fail

This job reimaged three nodes, running this branch, and caused this to show up on the exporter's endpoint - even though the exporter itself is still running main!
# HELP teuthology_reimaging_results_total Teuthology Reimaging Results
# TYPE teuthology_reimaging_results_total counter
teuthology_reimaging_results_total{machine_type="smithi",status="success"} 3.0

I don't understand how the exporter could have gained a new metric without having code that knows it, and that makes me think I don't understand how this code works.  Let's discuss this Wednesday.

We are using multiprocess mode, which uses the filesystem: https://github.com/prometheus/client_python#multiprocess-mode-eg-gunicorn


Can you make a tutorial on how to deploy this on pythonanywhere?

Alright. Would add that to the readme


[Google Maps] Marker Cluster

Added marker clustering for Google Maps, aswell as two demos inside the /google-map showcasing how it works and how its done. Let me know if something looks amiss or if anything needs changing, I tried to test it as much as possible to make sure it works as intended. I tried adding the script src below to the other projects, but could only do WebAssembly for some reason.
Be wary that this is crucial for it to work:
<script<EMAIL_ADDRESS>

Changes made:
blazor.boostrap.js

Made it so that if a "content" of a marker contains <svg, it will add a class that fixes the misalignment that is specifically only for SVGs.
Made changes to initialize, updateMarkers and addMarker to support clustering, making sure it happens the most optimal way possible.

blazor.bootstrap.css

Added .bb-googlemaps-marker-fix that fixes the misalignment of SVG markers.

GoogleMap.razor.cs

Added OnClusterClickJS (works the same way for markers, except for clusters instead)
Added ClusterOptions to the initialize (see RefreshAsync and and OnScriptLoad)
Added ClusterOptions
Added OnClusterClick EventCallback

WebAssembly/wwwroot/index.html

Added script src for marker clusterer.

+ Models/Maps/GoogleMapClusterOptions.cs

Added GoogleMapClusterOptions with: Renderer, Algorithm, ClusteringEnabled and EnableClusterClick
Added GoogleMapClusterAlgorithm with Type and GoogleMapClusterAlgorithmOptions (pardon if the names seem excessive)
Added GoogleMapClusterAlgorithmOptions that contains MaxZoom (this may expand in the future)
Added GoogleMapClusterRenderer that allows for custom rendering of a cluster (SVG, TextColor, TextFontSize, ShowMarkerCount)
Added GoogleMapClusterClickEvent, should work the same way as a MarkerClickEvent.

+ Enums/GoogleMapAlgorithmTypes.cs

Added supported algorithm types for clustering. Use enum combined with ToString() to select the different types.

+ RCL/Components/Pages/Maps/GoogleMap_Demo_07_Dynamic_markers_with_clustering.razor

Added demo for simple clustering

+ RCL/Components/Pages/Maps/GoogleMap_Demo_08_Dynamic_markers_with_custom_clustering.razor

Added demo for advanced clustering with custom icons, algorithm definitions etc.

@Aadlei Thank you for the PR. I'll check this.


Simtext

Hi galaxy team, I created some training material for the SimText toolset that I would like to add to the galaxy training website.
@bgruening Because you have been reviewing the tools before it might make sense that you have a look at it (if you have a bit of time). Thank you!

Just a general question: do you anticipate enough text-mining tutorials to justify having its own topic? Or should we add it to e.g. the "Statistics & Machine Learning" topic?

@shiltemann I do not anticipate many tutorials in the near future, so I think your suggestion to add it to "Statistics & Machine Learning" for now makes sense. Should I do the change in this PR or open a new one for it?
Also, do you know what the problem in the "Lint and Build GTN / build-site" is? To me, it looks like a problem with the snippets but I think they have the same syntax as in other tutorials.
Thank you so much!

@dlal-group sounds good, it would be great if you could do the moving in this PR
About the snippets: yes, we very recently overhauled how snippets work, I will update your branch to the new snippet syntax, so don't worry about the test for now :+1:
And above all: thanks for your contribution!

Thanks @dlal-group! Good luck with your paper.
Thanks @shiltemann @hexylena for the review!


Use Object as the type in case schema property contains mixed types

Closes #1425

Yes, you're right.


#5 added dark-light mode for texts

Added dark and light mode for the readable text for each anime characters !

Hey there's a merge conflict with this pull request. Kindly sync your Fork and open pull request.


[PLUGIN REQUEST] crates.nvim

Field
Description

Plugin
crates.nvim

Homepage
https://github.com/Saecki/crates.nvim

Nixpkgs
vimPlugins.crates-nvim

Extra Information
The plugin has been partially added already but only as a completion source for cmp. It is currently lacking the overlays that show the current versions of the crates when editing a Cargo.toml as you can see in the video on the repo page: https://github.com/Saecki/crates.nvim

The overlays are working for me:

The overlays are working for me:

Can you verify you don't have plugins being loaded from an old ~/.config/nvim or ~/.local/share/nvim folder? Those are likely polluting your Nixvim install.


build multi-arch image

Description of the PR
Fixes: #887
Put it as draft for now to seek your feedback

use docker buildx bake to build multi-arch image: "linux/amd64", "linux/arm64", "linux/arm", "darwin/amd64", "darwin/arm64". we can build the complete list if you want  ["linux/amd64", "linux/386", "linux/arm64", "linux/arm", "linux/ppc64le", "linux/s390x", "darwin/amd64", "darwin/arm64", "windows/amd64", "windows/arm64", "freebsd/amd64", "freebsd/arm64"]
Switch from ubuntu to cgr.dev/chainguard/static:latest-glibc as base image for that sweet 0 CVE count.

PR Checklist

[x] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[ ] All new changes are covered by tests
[ ] If GraphQL schema is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

Hi @tuananh, I'm actually working on building and releasing binaries #904 using goreleaser. As part of the build, goreleaser supports packaging bins into container image and support for multi-arch build. This way we can get all the building/packaging/releasing work done once and for all.
It does use buildx like you suggested here.

Thanks for all the hard work on this @tuananh! Sorry for the miscommunication on our part.

No problem :)


Random Thread Creation

Hi,
I'm using typhoeus (1.3.1) on ruby 2.5.3 and came across a (presumably random) thread being created (but not killed) by typhoeus. Consider the following:
root@2b885cef4144:/# irb -r typhoeus
irb(main):001:0> Thread.list
=> [#<Thread:0x0000563e19b24b68 run>]
irb(main):002:0> Typhoeus.get 'http://txti.es'; nil
=> nil
irb(main):003:0> Thread.list
=> [#<Thread:0x0000563e19b24b68 run>, #<Thread:0x0000563e1a333408 sleep>]

I believe the 2nd thread in Thread.list is erroneous and shouldn't be alive/sleeping. It's fine for libraries to create additional threads, but only if they're properly handled after use.
What's interesting is that the thread is only created on the first get request. If you run subsequent gets etc. no additional threads are created; but the erroneous thread lingers.
Has anybody got any ideas on what's going on here? Should typhoeus be creating threads under the hood? Why is this one still alive? What does it do?
Thanks in advance!

Bump! ^^^

Bump! ^^^

Bump! ^^^


Boolean get_input_single(0, true) always returns true

A BOOLEAN input set to false, with get_input_single(0, true) will always return true.

I thought I fixed that a while ago, I'll look into it

Fixed in 61b3be28260128b587c038e02af03e66095faa0e


deleting project member is processed asynchronously.

[Enter feedback here]
Deleting a project team member is done asynchronously and takes several minutes from the time the delete operation is performed until the deletion is complete.
see the discussion in IcM 403438859

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9502f48e-90cb-bee1-c312-d545e61e9d94
Version Independent ID: 17d7eb54-a1c4-f42f-c402-deb4b947959d
Content: Project team members
Content Source: articles/project-management/project-team-members-overview.md
Service: dynamics-365-project-operations
GitHub Login: @ruhercul
Microsoft Alias: ruhercul

Thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 community page to get help with your questions from the Dynamics community.


exercism/dart:  Address Dart analyzer errors due to Dart 2.0 strong typing

The Dart Analyzer has been giving some errors when casting some variables or values.
They did not prevent the tests or other scripts from running successfully, but I still wanted to address them to prevent confusion.
I've addressed them and formatted the files I changed.
Additionally, I added the .dart_tool directory to the ignore file.

This would be one of the first PRs towards a Dart 2.0 migration. I recommend adding avoid_as as a warning in analysis_options. Which might surface more places that need updating + give static linting in future.

@devkabiir In the analysis_options.yaml file, we have implicit-cast and implicit-dynamic as false.
That is intended to make the typing in the repo scripts as well as the exercises stronger and more explicit.
However, in order to keep using implicit-cast and implicit-dynamic set to false we need to use as otherwise it will be very hard to work around dynamic return types from the Dart API.


Clean up Google Analytics setup documentation

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1904
Originally created by @DouweM on 2020-03-26 22:47:36

[x] Clarify that the expected action is to enable both APIs
[x] Clarify that client_secrets.json should be uploaded
[x] Suggest getting view ID from UI/URL instead of Account Explorer tool

View 7 previous comments from the original issue on GitLab


collide is aware of fixed positions of the nodes

If you have fixed position nodes (fx,fy !== null) that possibly overlap, the collision keeps these nodes fixed and we don't collide with a shadow version at d.x + d.vx, d.y + d.vy

this will fix #213