Comments

Registered users should be allowed to comment on content.

Commenting can be enabled or disabled on any page.
Users can post comments.
Users can reply to comments.
Users can 'like' comments.
Moderators can review, filter and export comments.
Moderators can provide custom or canned responses to comments.
Community moderators can flag inappropriate comments.
Moderators should be alerted to flagged comments.

Covers #33 , #34 , #35 , and #37

Before commencing development it would be useful to discuss the proposed approach and whether it may be useful to make use of django-contrib-comments.
There are two forks of the original Wagtail packages for intergration with django-contrib-comments and neither has a recent release (although there is some active development).
We should also discuss possible future requirements with @volloholic. The intention in the future is for the comments system to be part of a wider "safe space" for users within IoGT.

@isedwards  using django-contrib-comments lib to this wagtail project can be a wrong decisions, coz, you will get in trouble to custom wagtail admin for moderator.
So custom solution would be good idea.
As they mentioned following functionality:

Commenting can be enabled or disabled on any page.

Users can post comments.

Users can reply to comments.

Users can 'like' comments.

Moderators can review, filter and export comments.

Moderators can provide custom or canned responses to comments.

Community moderators can flag inappropriate comments.

Moderators should be alerted to flagged comments.

It would be very easier to handle all these with wagtail very smartly.

@MySecondLanguage would you elaborate on what kind of trouble you expect from using django_contrib_comments?

@istride  You know you can customize wagtail admin from directly models class, like you can implement editing panel fully customized based on your situation. in this case, you will not get such privileged very easily if you use django_contribe_comments. It may be possible in some other way but that's will not be straight forward solution.
I admit django_contrib_comments is great solution if you use vanilla django

@istride  You may be have different approach. by the way, If you want it strictly to use, i will use it as i am hired already for this issue. Thank You

Can you please tell me which one is reply form?

@MySecondLanguage I don't have strong opinions about how this is implemented, however, what is important is that it be easy to maintain. If you think this is best achieved by avoiding existing packages and implementing something from scratch, then I'm happy to go along with that.
With regard to the "reply form", I can see a link that says, "Click here to reply". I think the intention is that the link is clicked and an input appears to capture the reply. One thing to note about this is that this website is intended to be fully functional even in a no-JS environment, so we have to be careful with dynamic behaviour such as this.

@MySecondLanguage Are you saying that some of the moderator requirements below are not possible with django-contrib-comments? We would prefer to use something already made for maintainability reasons, but we can consider implementing something from scratch if there's a good reason, as @istride mentioned.

Moderators can review, filter and export comments.
Moderators can provide custom or canned responses to comments.
Community moderators can flag inappropriate comments.
Moderators should be alerted to flagged comments.

Is it safe to assume that comments will only be for Articles and not Surveys, Quizzes, Sections etc.?
@dannyparsons @volloholic

Initial research on the ticket suggests that there are two ways to do this:

Fork https://github.com/joyider/wagtail_comments_xtd and add functionality that we need, for example:

Report
Add Moderator Reply
Canned responses
Import/Export

I feel that the unicef/wagtail_comments_xtd package could end up being the de-facto comments package for Wagtail
Note: I'm not sure why this package has a lot of requirements. So we'll have to audit them before going with this approach

Use https://github.com/danirus/django-comments-xtd as a baseline for nested comments. This package is built on top of django-contrib-comments and has support for threads. The wagtail part is missing which can be developed. This approach gives us slightly more "control" on the admin panel and the commenting architecture.

I don't have a very strong opinion on either of the approaches. Approach 1 helps the community but might not be the fastest way to implement. Approach 2 gives us more control but doesn't help the community.
p.s there is an even further low level approach that can be taken with using django-contrib-comments and https://github.com/django-treebeard/django-treebeard. Nested comments tend to be computationally expensive and tree based storage is very efficient for such problems.
Happy to go over the options on a call too @istride @dannyparsons

Safe to assume for articles only. Login *should *be required to login, but
can be unchecked as a requirement in site settings to enable anonymous
comments. I would think replies would work like a Facebook reply, where all
replies associated with the original post sit under each other.
On Wed, May 26, 2021 at 2:37 PM Ehmad Zubair @.***>
wrote:

Is it safe to assume that comments will only be for Articles and not
Surveys, Quizzes, Sections etc.?
@dannyparsons https://github.com/dannyparsons @volloholic
https://github.com/volloholic
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/unicef/iogt/issues/56#issuecomment-848696483, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARYZHTT4SLT66RIWPQUGFXDTPTMQZANCNFSM43KMWRLA
.

--
Laurie Markle

Thanks. Facebook is a good model to follow here. It allows for one level of replies which I think is sufficient and clearest from a user experience perspective.

In addition to the requirements above, this feature also needs to have a comments list page where comments can be paginated. The first page of the comments will show up on the Article page. If the user wants to see all the comments, they will be navigated to a comments list page.

Agreed, this is consistent with current v1 sites.

Regarding

Moderators should be alerted to flagged comments.

How do we want to alert the moderators? the library we're using has the functionality to send email alerts.
@dannyparsons @istride

From here: https://github.com/unicef/iogt/issues/34#issue-815417719

Reported comments appear as an alert in the CMS.

So I think a way of viewing all flagged comments in the CMS would be sufficient. Email notification could be an optional additional way as well, but a moderator would have to turn this on.

Also would be nice to have a "My Comments" page where you can see all the comments you have made.


Set project version to UE 5.2

We no longer support UE 5.1, so let's upgrade the base version of the samples to 5.2 as well.

Thanks @j9liu.


Documentation for named maps static images + view option in templates

information about named maps static image endpoint
new view element in named maps templates

Looks great to me! :eggplant: :tomato: :tofu:

Do you want me to do any tests on the views parameters?

If you can play around a bit it would be awesome! :poultry_leg: :beer: :smile:

@ohasselblad Did you get the time to test it a bit?

I can do some testing today!
On Mon, Jun 8, 2015 at 10:07 AM, Raul Ochoa<EMAIL_ADDRESS>wrote:

@ohasselblad https://github.com/ohasselblad Did you get the time to
test it a bit?
—
Reply to this email directly or view it on GitHub
https://github.com/CartoDB/Windshaft-cartodb/pull/304#issuecomment-110007358
.

--
Andy Eschbacher
Map Scientist
CartoDB http://cartodb.com
<EMAIL_ADDRESS>

If you find the documentation part OK I prefer to merge it and later create new issues if you find any problem, does that work for you?

Yep, fine with me!


[Bug] unique_name vs name in older version of System.IdentityModel.Tokens.Jwt

Which version of Microsoft.IdentityModel are you using?
System.IdentityModel.Tokens.Jwt 6.10.0 & 6.10.1
Where is the issue?

[ ] M.IM.JsonWebTokens
[ ] M.IM.KeyVaultExtensions
[ ] M.IM.Logging
[ ] M.IM.ManagedKeyVaultSecurityKey
[ ] M.IM.Protocols
[ ] M.IM.Protocols.OpenIdConnect
[ ] M.IM.Protocols.SignedHttpRequest
[ ] M.IM.Protocols.WsFederation
[ ] M.IM.TestExtensions
[ ] M.IM.Tokens
[ ] M.IM.Tokens.Saml
[ ] M.IM.Validators
[ ] M.IM.Xml
[x] S.IM.Tokens.Jwt
Other (please describe)

Is this a new or an existing app?
a. The app is in production and I have upgraded to a new version of System.IdentityModel.Tokens.Jwt
Repro
  <ItemGroup>
    <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="6.10.0" />
  </ItemGroup>

using System;
using System.Collections.Generic;
using System.IdentityModel.Tokens.Jwt;
using System.Security.Claims;
using System.Text;
using System.Text.Json;
using Microsoft.IdentityModel.Tokens;

var claims = new List<Claim>
{
    new Claim(ClaimTypes.Name, "<some name>"),
    new Claim("aud", "some audience"),
};
var key = new byte[1024];
new Random().NextBytes(key);
var securityKey = new SymmetricSecurityKey(key);
var signingCredentials = new SigningCredentials(securityKey, SecurityAlgorithms.HmacSha256Signature);
var tokenDescriptorSystem = new SecurityTokenDescriptor
{
    Subject = new ClaimsIdentity(claims),
    Issuer = "some issuer",
    Expires = DateTime.UtcNow.AddMinutes(10),
    SigningCredentials = signingCredentials
};

var tokenHandler = new JwtSecurityTokenHandler();
var token = tokenHandler.CreateToken(tokenDescriptorSystem);
var tokenString = tokenHandler.WriteToken(token);

Expected behavior
The following program will create a JWT token with the following payload for version 6.5.0 -> 6.9.0 and from 6.10.2 ->
...
"unique_name": "<some name>",
...

Actual behavior
But for version 6.10.0 and 6.10.1 it will create the following payload:
...
"name": "<some name>",
...

Possible solution
This seems like a critical enough regression that I think that version 6.10.0 and 6.10.1 should be unlisted from nuget.org.
It's especially easy to be bitten by this bug since this package is often included as a transitive dependency and it's not obvious which version that ultimately gets included in the final binary.

@havarnov i checked in 6.9.0 this commit changed the claim type: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/commit/183c04ad613b1c0355b68ad3278d5a45e5c8835b
It was removed in 6.10.2 in this commit: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/commit/d6f2b66d788195b50f2b1f700beb497851194c73
I will speak to the team about delisting the packages 6.9.0 -> 6.10.1.

Thanks!
You might be right about the error being introduced in 6.9.0, but the repro program I posted above works as intended with version 6.9.0 (i.e. "unique_name": "<some name>",).

@havarnov thanks for bringing this to our attention.

@havarnov is this repro'ing on the 7x versions as well?

@havarnov we are closing as we are only fixing security issues on 6.x


DNM: emit kubernetes message in repo

instead of just logging inside the controller, emit a kubernetes event
message into the user namespace to make it easy for user to investigate.
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

recreated this pr with a few updates https://github.com/openshift-pipelines/pipelines-as-code/pull/868


Studio Migration

Options

Port entire functionality as a "Studio Widget"
Each studio becomes project, each workspace becomes an activity, each dashboard becomes its own widget
Studio becomes an activity, with a workspace and dashboard as nested activities
Keep it insides Admin "subapp"
Studio Legacy subapp that lives aside Admin and Studio (v2)

To be reviewed with NSE/DKE.


fuel consumption graphs keep on expanding in height.

After I entered some random values, the fuel consumption graph keeps on expanding in height, apparently one pixel at a time. Maybe related, the cpu resource consumption is very high when the dashboard is displayed.
Bug occurs on firefox 52.7.3. Is it because my browser is too old ?

Actually the monthly cost graph has the same bug.

I'd observed this issue before and had assumed I'd fixed it! Using random data with a large range seems to have been a good way of driving this bug back out. I've spotted your PR so will try to review it when I can. Thanks.


[FactorioModPortal] services

Saw this https://github.com/badges/shields/issues/8582 issue and thought I'd take a crack at closing it. I'm new to open-source contributions so I'm eager to hear any feedback/changes.

API: https://mods.factorio.com/api/mods/{name} where {name} is the name of the mod, e.g.
https://mods.factorio.com/api/mods/rso-mod
No authentication is required.
API is documented here: https://wiki.factorio.com/Mod_portal_API#/api/mods/

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @kuanoni!

  Generated by :no_entry_sign: dangerJS against ddcfd86b5935f3451fcc75af5fd1902bdc9785bb


Cooking station not showing up correctly

I Have both the datapack and the resource pack installed, but when i place the cooking station it shows up as a normal furnace?

Do you have any other datapacks, mods, plugins? Perhaps something messing with your advancements?

Hey,
I have the same problem, do datapack like blaze and cave can mess with it as it fully advancement based?
Thanks in advance.

This was tested before, and I tested it again to make sure
That specific datapack does not interfere with the More Foods datapack. Do you have any other datapacks/mods? Are you on vanilla, paper/spigot, modded? Which version is this on?


Will FolioReaderKit support Swift 4.0?

thanks for your great FolioReaderKit firstly, and will it support Swift 4?

Wondering the same! 👍

Yeah, it will, but I have not started yet

Hi @hebertialmeida, We're still waiting.

Hi, thanks for creating this amazing reader/parser!
It would be nice if you create some plan for refactoring so that we can help.
Cheers! :)

@wedranb Hey, yeah I will need help on that, the first step is to fully fix it for iOS 11 and iPhone X, then migrate to swift 4.
There is a discussion here https://github.com/FolioReader/FolioReaderKit/issues/261 and also https://github.com/FolioReader/FolioReaderKit/pull/270 that is going on. We definitely need help because I think the ideal implementation is to use the new safe layout guides.

Hi, thanks for this library!
How is going Swift 4 support update ? @hebertialmeida


VT thinks that all TRVs are turned off and must be turned on at startup

When I restart HA, VT always assume that all thermostats it controls are turned off and must therefore turned on, e.g.:
VersatileThermostat-MZ: Smart Thermostat-climate.mz_thermostat - The hvac mode is ON, but the underlying device is not ON. Turning on device climate.mz_thermostat
The underlying devices, however, were ON all the time, which can be asserted by the logs.

I'm seeing this too, the log details states the following source: custom_components/versatile_thermostat/underlyings.py:144

ok. Is that a problem or just an observation ?

For me Ii‘s just a line in the logfile, no issue.

As far as I can see, only a line in the log file, too. However it seems to indicate a somehow erroraneous state detection at least when starting.

Fix is published on https://github.com/jmcollin78/versatile_thermostat/releases/tag/3.7.0.beta3
if you want to test. The release will come soon.


[#noissue] Refactor kafka plugin dependency.

@koo-taejin PTAL...

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@724143e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4811   +/-   ##
=========================================
  Coverage          ?   40.82%
=========================================
  Files             ?     2590
  Lines             ?    78766
  Branches          ?    10665
=========================================
  Hits              ?    32156
  Misses            ?    43628
  Partials          ?     2982

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724143e...3a9a432. Read the comment docs.


Fixing defects on tickets 6233, 6342

Fixing defects on tickets 6233, 6342

An insert from the CAMDECMPSWKS UNIT table into the CAMD UNIT table should never occur. Each of these scripts for the copu_monitor_plan_from_workspace_to_global should only perform updates of the following:

NON_LOAD_BASED_IND
USERID
UPDATE_DATE

Additionally, the changes should be compiled and tested in the Dev database before a merge can concern, and before PR if possible.

Updated per comment.


add discussions to contribution graph

Why:
Documentation is out of date! Discussion activity shows up on the contribution graph.
What's being changed:
adds "opened a discussion; answered a discussion" to list of activities that show in contribution graph.
Check off the following:

[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

thank you for opening this PR! 🙌

Thanks folks! I'll update the branch and get this merged in soon ⚡


World wont load after i used some multi-page chests!!

Ok  i decided to try the multi-page chest on a asteroid mining mission and everything was going great until it started to descend back to the overworld. IT then said the was a fatal error and it shutdown a mythical multiplayer server because i play single player. I tried reloading the world but it then said disconnected from server connection and bring back to the multiplayer screen.

Zmaster i was trying to replicate ennekpl problem with the rocket and ran into another issue! when i launched a space station in this new test world i created to test some of these bugs. the rocket released the space station around it. and when i visit the space station the rocket is sitting in dead middle of it!

As github apparently didn't get the email...  "What is a multipage chest and would it be possible to paste the fml-server/client-latest.log files?".
with regard to the space station issue, did you have anything on the rocket besides the satellite bay with the space station inside?
Also there really is no need to add another '!' to the end of the title, I can see it perfectly fine with just the one '!', but I am very busy throughout the day and can only check back so often.

I added the extra "!" by accident. really sorry about that. and i understand that ur busy and didnt mean anything by that extra exclamation point.
Now on with the issues. is like a chest but but u can scroll through different pages. visit this link for more info! https://minecraft.curseforge.com/projects/multi-page-chest?gameCategorySlug=mc-mods&projectID=78779
Now about the space station i had the satellit ebay and a guidance cpu

It's all good.
but anyway, would it be possible to upload the log from when you got the fatal error?
Ok, so the email's not going through again, but anyway.  Did you have anything in the guidance computer or was it empty?

Yes there was a space station id chip in it! i cant upload the latest log because i went to a backup

alright, investigating

wait i just duplicated the fatal error again. ill post that log file in a second

the log file is so big it it exceeded the 512 kb limit on pastebin

try uploading it to git

Ok i had to Zip the folder but it should hopefully be it!
fml-client-latest.zip

It appears to be being caused by something trying to send too large a packet.

Could it be the ores that the mining mission is bringing back?

It shouldn't be, there's an upper limit of a few chests, so the remainder should be empty

Would you be able to upload the region file the rocket took off from?  Here's a coord to file converter if you need it: https://dinnerbone.com/minecraft/tools/coordinates/

Where are the region files located? and for which rocket? the one that did the asteroid or the one stuck in the spaces station?

saves//region/something.mca
And the one for the asteriod mining rocket, I'm fairly sure i know what happened with the space station rocket.

Never minnd about the region files.

ok

i got it where do i upload it to?

or do i just give u the region info

you should be able to upload here in a zip , or you could upload to dropbox or google drive

oh ok and removing extra ultilties didnt work.

sorry have to step away from the cpu for a min my gf / soon to be fiance is calling!

huh, that one's only got 7 chunks generated and none of them have any entities, you sure you got the region the rocket was launched from?
can you also send the /advrocketry/temp.dat on the offchance it's not returned from it's mission before the world saves or something?

might have loaded wrong file and if u mean the original spawn point of the game yes i moved headquarters to a base in the desert and the nearest one i could find was nearly twen thousand blocks away!

Yep uploaded wrong this one should be it!

Guess you beat me to it, was gonna ask if you were off by one or something

i type in my location into the chunk one instead of the block one!

You sure that's right?  That one has a single unpopulated chunk in it.  A region file with any kind of base should be at least 100KB.

Ill just duplicate the dang error again so i exactly which region file to go it! brb in about 5 or so mins

or wait would one with 4k KB be it?

r.-19.11.zip
r.-19.11.zip
r.-19.11.zip
r.-19.11.zip
r.-19.11.zip

No rush, I need to sleep anyway as its 3am here

Did you have anything in the guidance computer or was it empty?

What is a multi page chest and would it be possible to paste the
fml-server/client-latest.log files?

Alright, so all the emails arrived at once... interesting... Looking through the region files...

I set a test to run in the background, fully filled asteriod chip, 4 drills, guidance computer, 1 multipage chest, the results I got was it brought back way more ore than it should, but the game didn't crash... still looking through the region files though...

Wait, so are you able to get back into the world after the crash occurs?

if you change miningMissionMultiplier to 0 and launch a new mission does this bug still occur?  (also for the sake of testing I'd suggest making a copy of a full asteriod chip in creative until we can sort this out)

My current theory of what happened is that due to the limit for the amount of ore generated by an asteroid mining mission was way too high, coupling that with the assumption you had a larger rocket/more chests? than the one i was testing with the amount of ore generated + the rocket was over 1MB in size.  I've since fixed the limit to be something much more reasonable (100 stacks of ore max), but I'd like to you test the theory by changing the conig such that 0 stacks are generated which would either confirm or rule said theory out.

Ok many things here!
First im not able to get into the world that crashed it loads normal but as soon its done it flashes and like it wants to be played but the shuts down!
Second how do u duplicate a full asteroid chip?
third ill wont be able to test ur theory until later tonight as im currently driving my gf to the airport.
The rocket that caused this whole mess was decent size with a lot of thrust. it also had about 50-60 chest on it.
1/3 multi page
1/3 vanilla chests
1/3 crystal chests from iron chests

That makes sense. You can duplicate the chip by going into creative and middle clicking it in the inventory, like any  other item or block.

oh ok!

Setting the multiplier to 0 brought back nothing!

and didnt crash with 25 chests moving up to 50 chest now!

No crash with over 100 chests i got carried away

"Setting the multiplier to 0 brought back nothing!" that was the point, I was trying to rule out the number of items being the cause.
"and didnt crash with 25 chests moving up to 50 chest now!" this with the multiplier still at 0?

yup

what happens if you do the same with it set to 0.01?

Ok ill try that real quick

do u have to reload minecraft or just the world if i change the configs?

You'd have to relaunch the game.

ok it brought back ores

so i didn't crash?

nope!

alright, then the fix I committer earlier will solve this for next release, thank you very much for your patience with this issue!

no problem one question.

when i link the rocket unloader it says that the linker is now set to the fueling station.

I forgot to update the strings

ok


Method not found: 'Void Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.SqlColumnEncryptionAzureKeyVaultProvider

I am trying to encrypt Azure SQL Database Columns Using Azure Automation Run Book. Code is written in power shell and is failing when trying to execute this command
$serverName = $serverName
$connStr = "Server = " + $serverName + "; Database = " + $databaseName + ";Persist Security Info=False;Authentication =Active Directory Managed Identity;Encrypt=True;TrustServerCertificate=False;"
$database = Get-SqlDatabase -ConnectionString $connStr
Write-Output $database
Set-SqlColumnEncryption -ColumnEncryptionSettings $EncryptionSettings -InputObject $database -LogFileDirectory . -KeyVaultAccessToken $keyVaultAccessToken
Error I get is as follows:

Failed
Method not found: 'Void Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.SqlColumnEncryptionAzureKeyVaultProvider..ctor(Azure.Core.TokenCredential)'. (Method not found: 'Void Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.SqlColumnEncryptionAzureKeyVaultProvider..ctor(Azure.Core.TokenCredential)'.)
You can reference this existing issue on GitHub.
https://github.com/microsoft/SQLServerPSModule/issues/45

Hi @Tbablani72 ,
The issue is most likely a duplicate of another one which is going to require a complete rewrite of the module, sadly. But maybe there is hope that we can patch it up somehow...
Would you happen to know what thos "Automation Run Book" are setup and run? I have no clue... (well, I think I did something a while back, but I completely forgot).
It would be nice to know how the environement this script runs in is setup... i.e. what modules are loaded before the sqlSERVER cmdletes are executed...
Best option for me would be to have a repro that does not involve the Automation Run Book...
if that is not possible, could you at least have the script temporarily updated to dump the output of:

$PSVersionTable
Get-Module (before and after running the script fragment that is failing)
Get all the loaded assemblies before and after running the script fragment that is failing)[System.AppDomain]::CurrentDomain.GetAssemblies() | Where-Object Location | Sort-Object -Property FullName | Select-Object -Property FullName, Location, GlobalAssemblyCache

A description of the setup (I see there's an AVK, a DB, a managed identity, ...): how would I go about setting up an environment similar to that?

This looks a lot like #45
@DBarmanMS - can you take a look at these issues and see if there's anything that we can suggest as workaround?
The ALC work is big and hardly coming any time soon... but perhaps we could play with our assembly resolution logic or maybe avoid this dependency in the AE cmdlet...

Hi @Tbablani72 ,
Could you please share a stand-alone script to reproduce this issue?  I'm not able to reproduce this in my setup following the cmdlet article.

Easiest solution is to run the script in powershell 7. Please try it out and let me know if you face any issue.

You can also add your own module instead of using the gallery and specifically use the 21.1.18256 version of SQLServer instead of 22 and above. Ran into the same issue with both RunBooks and normal scripts in the past when mixing in Az, PnP, or Graph modules and 21 never runs into the conflict for me.

We were facing the same error when trying to run PowerShell script from our Jenkins pipeline. Only thing that worked was to change the SQLServer version to 21.1.18256. Seems using the latest version throws the error.

This worked for us in our release pipeline when toggled it to use 'powershell core'

A mitigation for this issue should become available in v22.3+, which I hope to release soon.

Please, give v22,3.0 a try. It has some mitigation in this area...
Log a new issue if you still see something ugly...


Raise exceptions if incorrect types are passed into new

Currently, no checks are done when passing attributes to new/2. This means that it's possible to pass incorrect types or sub-messages while constructing a new struct. In most cases these errors won't be caught until the message is decoded since the encoder doesn't perform validations while it's encoding. To make this more concrete let's say that we have these definitions:
defmodule Foo do
  @moduledoc false
  use Protobuf, syntax: :proto3

  defstruct [:id]

  field :id, 1, type: :int32
end

defmodule Bar do
  @moduledoc false
  use Protobuf, syntax: :proto3

  defstruct [:id]

  field :id, 1, type: :string
end

defmodule Baz do
  @moduledoc false
  use Protobuf, syntax: :proto3

  defstruct [:foo]

  field :foo, 1, type: Foo
end

It's currently possible to do this:
Baz.new(foo: Bar.new(id: "test")) |> Baz.encode()
<<10, 6, 10, 4, 116, 101, 115, 116>>

Errors like this won't be caught until the client attempts to decode the message on the other end.
Proposal
I'd like to suggest that we check inputs as part of new and raise an exception if the value doesn't match the correct type. I believe that raising is the correct approach here because calling new with invalid data is equivalent to an ArgumentError. I don't believe that there's any recovery the user could take if they pass the wrong arguments to the function and its better to raise loudly so they're aware of the issue.
Obviously this would only work if the user calls new and doesn't work if they build the struct themselves. I'm not sure if that's an acceptable tradeoff or not.
I'm happy to work on submitting a PR for these changes if you believe that the idea has merit. But I wanted to make sure you thought this was a reasonable addition before I did the work on it.

Obviously this would only work if the user calls new and doesn't work if they build the struct themselves. I'm not sure if that's an acceptable tradeoff or not.

This is how most things in Elixir work, so I strongly suggest that this is an acceptable tradeoff :)
@keathley we also don't check the field names in new/1, FWIW 😄

I always wondered why aren't the defaults filled out when you just make the raw struct? You could feed default values to defstruct based off protobuf types?


Type of expression is ambiguous without more context

I'm trying to init using the following code:
let bold = Style("bold", {
                $0.font = .bold(size: 16)
                $0.color = .black
})

Using Xcode 10/Swift 4.2 I get the following error:
Type of expression is ambiguous without more context

Tried that but got the same problem, @malcommac . Still trying to figure out where's the problem. I think it's related with the "bold". It works fine this way:
let bold = Style({
                $0.font = UIFont.boldSystemFont(ofSize: 16)
                $0.color = UIColor.black
})


Fix the Trix editor on "Get help with an issue" page

We should go through each available option of the Trix editor and see if we can make them display correctly.
Here is what I noticed:
Issues already present before we added Tailwind:

we need to style the options that appear when trying to add a link because it looks really raw
quotes don't look like quotes
the difference between a code block and the rest is unclear

Issues added after adding Tailwind. This seems to be a known issue, we might have to override some styles: https://github.com/basecamp/trix/issues/648, https://github.com/tailwindlabs/tailwindcss/issues/989

bullet points don't show a bullet anymore
buttons don't look like buttons anymore

Screenshots
Adding a link with no Tailwind:

Bullet points and buttons not displayed with Tailwind:

Quotes and code not showing a style that really makes them standout from the rest (same behaviour regardless of whether Tailwind is present or not, and it looks the same whether we're in the middle of writing a message or reading it after it's been published)

@ClaireDMT's PR #18fixed these issues (thank you so much Claire!):

buttons now are styled as buttons
adding a link looks good

But there are still some display issues left to work on:

bullet points are not shown as bullet points
ordered lists are not shown as ordered lists
when typing a message, users cannot see quotes styled as quotes
when typing a message, it is unclear how code blocks will be styled. Once the message is created, code blocks are hard to read because it displays a white font on a pale background

If anyone wants to look into this, feel free to assign yourself to this issue :)

Also, for reference, for some reason the bullet points/ordered lists do display a bullet point or a number on the index page:

I've opened a PR to fix the issue with the li elements in ordered lists and unordered lists: https://github.com/Contributees/First-Ruby-Quest/pull/37
So I think the last 2 issues left with the Trix editor are these:

when typing a message, users cannot see quotes styled as quotes
when typing a message, it is unclear how code blocks will be styled. Once the message is created, code blocks are hard to read because it displays a white font on a pale background

The fix for blockquotes and code blocks is now merged:
https://github.com/Contributees/First-Ruby-Quest/pull/38
I have opened a new issue about other Tailwind styles that need to be overridden: https://github.com/Contributees/First-Ruby-Quest/issues/41


docs: clean up basecoin-basics

first part of #192
small fixes for flow (no need to start guide with a big warning, esp since it's the beginner guide)

Looks good.
One thought.  Rather than all the magic ~/.basecoin and ~/.basecli cleanup, one could use BC_HOME there to create separate dirs.  But maybe that is too confusing.  Anyway, it is better than it was before.

i think it's too confusing yeah. advanced options for advanced users/guides and not the "basics" one


Enhancement Wishlist ...

Here is a list of features that would be good to have in julia eclipse plugin ...

[x] JDK 1.7 support
[ ] Auto Complete feature
[ ] Navigation feature
[ ] pre-configured julia interpreter (say, based on an environment variable ?)
[x] Having Julia REPL inside eclipse
[x] Plotting
[ ] debugger

Any updates here?

Obviously, having IDE access to Gallium would be great advertisement for the 0.5 release.

The plan is to have debugger support in both Eclipse and Juno for the 0.5 release or soon after. We are waiting on a bit more API shaping and stabilization.

We are waiting on a bit more API shaping and stabilization.

Certainly Base's inner guts are evolving rapidly, and that makes it hard for Gallium to keep up.

Without an efficient developing tool with a debugger, it is extremely difficult to use Julia in large project.  I love Julia language very much. However, I am starting to thinking about using Python again after using Julia for about one year. I encountered many problems as mentioned in the blog of Philip I. Thomas.I think many Julia users are facing these problems. I hope these problems could be solved before many users leave Julia.
"Retro on the Julia Programming Language"
https://blog.staffjoy.com/retro-on-the-julia-programming-language-7655121ea341#.nilmra4vg


Last known good config rollback

Wireframe should create a known good copy of the config when it detects that BIRD reconfigured successfully, and if it detects that a subsequent config run fails, it can automatically rollback by copying the known good config.

Added in v4.0.0


Asterisk in ubuntu to configure Voip in the same network

Topic Suggestion
The use of Asterisk Server to configure Voip
Proposed article introduction
Asterisk is a server, ubuntu based server that can be used to deploy and configure Voip phones. Voip phones are types of phones, the ip addressed phones that are configured to a certain server for communication amongst each other. The article is aimed to help understand the procedure to setting up asterisk in ubuntu and configurations for phones in the same network for communication purposes.
The phones in the same network must be managed from a central point of management and are assigned ip addresses for easy routing of their traffic. The phones then need to have applications installed in them for the ease of registration and authentication purposes.  Asterisk server then is able to manage all the operations showing their action logs on the other side of its manage.
Key takeaways
1.What asterisk is
2.How to set up asterisk in ubuntu
3.The functioning of Asterisk
4.What are Voip
5.The functioning of Voip
6.The configuration of Voip in asterisk
Article quality
This article will help users to use open source server to manage Voip phone calls other than the proprietary server systems.
References
N/A

Thank you for submitting your topic suggestion. There seems to be many articles that already cover this topic. Can you tell me how yours will build upon them and be unique to add value to our readers?

I will show how  to connect smartphones, such that, as long as they are connected to the same  wireless network, without the physical connection of the ethernet cables, they are able to call to each other. I am also going to show how we can route the smartphones traffic to act as though they are coming from a single server. Such that, if the dialed number is  not found in their local call manager, then they can fetch data from the core call manager server and try to locate the number in the larger call manger. I will show how we can link Asterisk traffic to the core call manger of choice.


Exeption during Metadata access from CMEM … description could not be fetched or is empty

I now have a setup where the autocompletion works but still I'm not able to publish a dataset.
I have created the dataset on the databus at https://databus.coypu.org/narndt/coypu/example/ and the plugin is configures as follows:

But I get the following error, when I try to execute the workflow.

"Exeption during Metadata access from CMEM task example_bda8d144593b759e: description could not be fetched or is empty"

The Databus enforces a description for its Datasets, so the databus-plugin tries to fetch the desription from the chosen KnowledgeGraph. If this description is empty, you get this error.
But I shold probably extend the message so the user knows WHERE the descrion should be updated.


including proxyHealth path

The common endpoint /health/${server.serviceId} must validate BOTH proxy and backend to return "OK" otherwise it will return "ERROR"

@DiogoFKT Based on our conversation, I have added the rate limit handle to the proxy health endpoint with the serviceId as a path parameter. Please review and let me know if you have any questions.


Multiple Flightpath option resulting in an error

Steps to Reproduce:-
-> python mslib/msui/msui.py
->open top view, we can see that the Web Map Service is open but in the drop-down menu (select to open control) is shown.
Even on changing the control, the text does not change
https://user-images.githubusercontent.com/93277471/225754881-9fe3fa21-1d26-410a-afea-5a9853f2340e.mp4

I get this one
@Jatin2020-24 please have a look
Fatal error in MSS 7.0.8 on Linux-5.4.0-144-generic-x86_64-with-glibc2.27
Python 3.10.8 | packaged by conda-forge | (main, Nov 22 2022, 08:23:14) [GCC 10.4.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/reimar/PycharmProjects/MSS/mslib/msui/topview.py", line 359, in openTool
    widget = mf.MultipleFlightpathControlWidget(parent=self, view=self.mpl.canvas,
  File "/home/reimar/PycharmProjects/MSS/mslib/msui/multiple_flightpath_dockwidget.py", line 130, in __init__
    self.color = self.ft_settings_dict["colour_ft_vertices"]
KeyError: 'colour_ft_vertices'

I am not sure if I understand what the Bug you describe in the movie is. We don't change the name of the combo box what is loaded, we keep there the Text  (select to open tool) because all opened widgets are tabs, see bottom of window.

I thought it was a bug and was meant to change when we move between the options as it does with the region cbChangeMapSection ComboBox.

When we would only open one then we could obviously name it to this one, but we can do also something like this

Yes, I recently learned about this. It's really cool.

https://user-images.githubusercontent.com/93277471/225779592-b20c3b9b-2166-4f57-9fac-14358b2a0398.mp4
I think this is the error you saw.

this needs now also a fix, I guess that is in the docking widget itselfs.

I will give it a try tomorrow.
Good Night :)

Good night :)

Hi, I think your issue is a misunderstanding about how the interface was designed, maybe in a non-ideal manner.
The test "(select to open control)" indicates that the drop-down-menu is used to open new controls, even though this is a mis-use of this UI element, which typically selects one of many options. Here, it kind of "compresses" several buttons into a list. We also do not remove already open elements from the selection - for simplicities sake.
One could and maybe shoudl redesign the UI to better follow common conventions.
Is this what you refer to in your original issue?

Yes! I misunderstood how the user interface was supposed to operate.
I was able to comprehend how the drop-down menu is supposed to function thanks to @ReimarBauer.
We can modify the user interface; I will investigate how exactly that will function and create a new issue later after suggesting the modifications in the Slack channel.
I'll try to fix the Multiple Flightpath option that produces an error for the time being in the issue.

I get this one
@Jatin2020-24 please have a look
Fatal error in MSS 7.0.8 on Linux-5.4.0-144-generic-x86_64-with-glibc2.27
Python 3.10.8 | packaged by conda-forge | (main, Nov 22 2022, 08:23:14) [GCC 10.4.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/reimar/PycharmProjects/MSS/mslib/msui/topview.py", line 359, in openTool
    widget = mf.MultipleFlightpathControlWidget(parent=self, view=self.mpl.canvas,
  File "/home/reimar/PycharmProjects/MSS/mslib/msui/multiple_flightpath_dockwidget.py", line 130, in __init__
    self.color = self.ft_settings_dict["colour_ft_vertices"]
KeyError: 'colour_ft_vertices'

I've checked it, but not able to reproduce this error. On my PC multiple_flightpath_dockwidget is opening with any error.

I can reproduce the problem also when I remove msui-core.conf or set export MSUI_CONFIG_PATH=/tmp
The second movie by @sratslla also shows it.

@joernu76 https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/topview.py#L496
when we have no qsettings file to load then  it crashes. I think we have just to initialize it with the default color.

@sratslla @Jatin2020-24 I also added a first unit test for that module.


A __new__ method should be considered a 'static method', not a 'class method'.

This is a subtle tweak: The __new__ method is currently causing class method warnings (e.g., ARG003). However, it should actually be causing static method warnings (e.g., ARG004).
https://play.ruff.rs/204c57b4-a35e-48d5-8f92-ca2e109dd2cd
class A:
    def __new__(cls, unused_static_method_arguments):
        return 42

A.__new__(A, 1)  # It works!!  If __new__ is treated as a class method, it should be `A.__new__(1)`

NOTE: According to the official Python documentation, the __new__ method is a static method that takes the class itself (cls) as its first argument.
Reference

Called to create a new instance of class cls. __new__() is a static method (special-cased so you need not declare it as such) that takes the class of which an instance was requested as its first argument.

https://docs.python.org/3/reference/datamodel.html#object.__new__

Thanks for opening the issue! There's some pretty interesting questions here.
__new__ defies normal classification. On the one hand, you're absolutely correct -- __new__ is a static method at runtime, not a classmethod, and this is true whether or not it's explicitly decorated with @staticmethod. On the other hand, it behaves much more like a classmethod than a staticmethod because of how heavily it's special-cased by the interpreter. In your example here, it's true that the cls argument is strictly-speaking unused, and so perhaps it would be strictly-speaking correct to emit two ARG004 diagnostics on the __new__ method there. But in practice, the vast majority of the time __new__ is called implicitly rather than explicitly -- and in those situations, you do need to have at least one __new__ parameter, even if it's unused, or instantiating your class isn't going to work. In that sense, it's much more like a classmethod than a staticmethod:
>>> class A:
...     def __new__():
...         return object.__new__(A)
...
>>> A()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: A.__new__() takes 0 positional arguments but 1 was given

Regardless of whether we think ARG003 or ARG004 should apply to __new__ methods, though, we should definitely fix the discrepancy here in the following snippet. A and B have identical semantics at runtime, but one ARG003 diagnostic is emitted for A, while two ARG004 diagnostics are emitted for B:
class A:
    def __new__(cls, unused):
        return 42

class B:
    @staticmethod
    def __new__(cls, unused):
        return 42

https://play.ruff.rs/57d4f602-c444-4b54-9f68-fe21215582b4

Hmm, I'm not sure what the right answer here is:

I think whether a __new__ method is explicitly decorated with @staticmethod or not, it should probably have the same error code for the diagnostic, because it will have the same runtime semantics
I think even though a __new__ method is technically a staticmethod at runtime, it behaves more like a classmethod, so it makes sense to apply "classmethod rules" when considering whether it's necessary for the method to have at least one argument or not. That implies that we should apply ARG003 to __new__ methods, even if they're decorated with @staticmethod
But the message emitted by ARG003 is "Unused class method argument", and I think it could be really confusing for users if that message is emitted on a method explicitly decorated with @staticmethod

class A:
    def __new__(cls, unused):
        return 42

class B:
    @staticmethod
    def __new__(cls, unused):
        return 42

@carljm can I ping you for a second opinion? I wonder if __new__ methods should just be their own rule entirely. It seems like we already have quite different rule classifications to the original flake8-unused-arguments flake8 plugin.

I think we should treat __new__ as a static method, and the argument code and message should not reference classmethods; referencing a classmethod when __new__ is definitely not a classmethod is just too confusing (regardless of whether there is an explicit @staticmethod decorator on it or not.)
I could go either way on whether we should complain about an unused first argument on __new__. On the one hand, it's probably a mistake to have an unused first argument, even though the first argument is required. On the other hand, that logic would also suggest that the classmethod rule should also still complain about unused first argument, too -- it's generally a mistake to have a classmethod that doesn't use the first argument, it should be a staticmethod instead.
If we prefer not to ever emit ARG003 or ARG004 for an argument that is required to be present, I don't see any problem with using the ARG004 error code for __new__, but also excluding the first argument from it as a special case. I think that even though that makes __new__ handling somewhat unique, it's much better than emitting any code mentioning classmethods for __new__.

I also agree with carljm's opinion.
For the first time, like AlexWaygood, I thought this issue was quite subtle.
https://github.com/astral-sh/ruff/blob/3463683632b0af2457f4449f7daef77d5527cd9c/crates/ruff_python_semantic/src/analyze/function_type.rs#L28-L37
However, __new__ is internally being treated as a classmethod. Considering that new rules applied to staticmethods might not be applied to __new__ in the future, I think __new__ should be treated as a staticmethod.


Bugfix 1.6.17

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: vinllen:x: arugalYou have signed the CLA already but the status is still pending? Let us recheck it.


fix(docs): remove hidden from front matter

This PR removes hidden: true from the front matter documentation.

Shout out to @cwcowellshah for finding this issue in our docs!


[Bug Report]: target: "es5" will panic when update code

System Info
System:
OS: macOS 13.1
CPU: (10) arm64 Apple M1 Pro
Memory: 1.13 GB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
Yarn: 1.22.18 - ~/.nvm/versions/node/v16.15.0/bin/yarn
npm: 8.6.0 - /opt/homebrew/bin/npm
Browsers:
Chrome: 112.0.5615.49
Firefox: 103.0.2
Safari: 16.2
Details
 [webpack-dev-middleware] [Error: error[internal]: should run render_chunk hook.
 Raw: panicked at 'should run render_chunk hook', /Users/runner/work/rspack/rspack/crates/rspack_plugin_javascript/src/plugin.rs:224:8
 This is not expected, please file an issue at https://github.com/web-infra-dev/rspack/issues.

    0: _napi_register_module_v1
    1:
    2: _napi_register_module_v1
    3: _napi_register_module_v1
    4: _napi_register_module_v1
    5: _napi_register_module_v1
    6: _napi_register_module_v1
    7: _napi_register_module_v1
    8: _napi_register_module_v1
    9: _napi_register_module_v1
   10:
   11:
   12:
   13:
   14:
   15:
   16:
   17:
   18: _napi_register_module_v1
   19: _napi_register_module_v1
   20: _napi_register_module_v1
   21: _napi_register_module_v1
   22: _napi_register_module_v1
   23: _napi_register_module_v1
   24: _napi_register_module_v1
   25: _napi_register_module_v1
   26: _napi_register_module_v1
   27: _napi_register_module_v1
   28: _napi_register_module_v1
   29: __pthread_deallocate

 ] {
   code: 'GenericFailure'
 }
Reproduce link
https://github.com/B1anker/rspack_render_chunk_panic.git
Reproduce Steps
pnpm install
pnpm serve
update any code

I'm seeing this issue occur if the target is set to anything other than web (i.e. browserslist, es2021, etc.).
I tried running the latest nightly as I thought #2744 might solve for it.  The error reported by @B1anker is not being emitted any longer, but instead I am now seeing:
thread 'thread 'thread 'thread 'tokio-runtime-workerthread 'thread 'thread 'thread 'thread 'tokio-runtime-workertokio-runtime-workertokio-runtime-workerthread 'thread '' panicked at 'tokio-runtime-worker' panicked at '' panicked at 'tokio-runtime-workertokio-runtime-worker' panicked at '' panicked at 'should run render_chunk hooktokio-runtime-workerthread 'should run render_chunk hooktokio-runtime-workerthread 'should run render_chunk hooktokio-runtime-workershould run render_chunk hookthread '' panicked at '' panicked at 'tokio-runtime-worker' panicked at 'tokio-runtime-worker', should run render_chunk hooktokio-runtime-worker' panicked at '', tokio-runtime-worker' panicked at 'D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs', ' panicked at '' panicked at 'should run render_chunk hook' panicked at 'should run render_chunk hookshould run render_chunk hook' panicked at 'should run render_chunk hook', ', ', D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rsshould run render_chunk hook', D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs', D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs:D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rsshould run render_chunk hook::should run render_chunk hookshould run render_chunk hookD:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rsD:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rsD:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs:233:', ', thread '', should run render_chunk hook::', 233thread ':', 233233D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs:233233:', tokio-runtime-worker8D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rstokio-runtime-worker233D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs::' panicked at '::D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rsD:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs:233should run render_chunk hook82338::',
8
233' panicked at '
:D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs
8should run render_chunk hook8::D:\a\rspack\rspack\crates\rspack_plugin_javascript\src\plugin.rs',
:ote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

8233::
8:23388:
833:

[rspack-cli] [Error: error[internal]: should run render_chunk hook.
Raw:
This is not expected, please file an issue at https://github.com/web-infra-dev/rspack/issues.

] {
  code: 'GenericFailure'
}

you can set ['web','es2021'] to avoid this problem, we need to add check logic to avoid set target to esx without set target to 'web' or 'node' etc, which webpack did

you can set ['web','es2021'] to avoid this problem, we need to add check logic to avoid set target to esx without set target to 'web' or 'node' etc, which webpack did

@hardfist Wouldn't setting it that way defeat the purpose of trying to set es2021?  With use of web, wouldn't it just downlevel to es2015 and not provide any support for es2021?  It might avoid the error, but I'm trying to understand what benefit it might provide to configure that way.

The caused by rspack set chunkLoadingPlugin & chunkFormatPlugin by target platform at previous implement, #2792 will aligin to webpack.

@hardfist Wouldn't setting it that way defeat the purpose of trying to set es2021? With use of web, wouldn't it just downlevel to es2015 and not provide any support for es2021? It might avoid the error, but I'm trying to understand what benefit it might provide to configure that way.

no, web is used to control chunkloading & chunkFormat but esx is used to control runtime code syntax, so they're seperate options to control different things, it will not cause to downlevel to es2015 when you set target to [web,es2021]

closed at #2792


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 769

Questions ?
Please refer to the Backport tool documentation


Workflow Execution History exists in DB but Conductor API doesn't pickup after restart

Scenario-
A workflow was run hourly for a month.
DB used is MySQL.
All the workflow executions were returned by Conductor API until the Jar restart.
Conductor server is able to retain to show workflow def taskdef etc in API but execution history is not being returned.
I confirmed this by execution workflow once, then checked conductor API for getting the workflow executions and the details were there. Jar restarted, API returns will. I have verified the data exists in DB.

This is definitely an odd scenario, something that we have not seen before (albeit we use Conductor backed by Dynomite and C*). I wonder if this is related to how the MySQL implementation is wired up. Can someone from the community using MySQL persistence backed Conductor help out in this case?


[SRGSSR] Failed to download m3u8 or f4m

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.11.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.rts.ch/play/tv/le-bazar-de-la-charite/video/episode-7-episode-78-saison-1?id=10897634']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.11.28
[debug] Python version 3.6.9 (CPython) -<EMAIL_ADDRESS>[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[SRGSSR] 10897634: Downloading JSON metadata
[SRGSSR] 10897634: Downloading HTTP-HLS-HD token
[SRGSSR] 10897634: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[SRGSSR] 10897634: Downloading HTTP-HLS-SD token
[SRGSSR] 10897634: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[SRGSSR] 10897634: Downloading HTTP-HDS-HD token
[SRGSSR] 10897634: Downloading f4m manifest
WARNING: Unable to download f4m manifest: HTTP Error 403: Forbidden
[SRGSSR] 10897634: Downloading HTTP-HDS-SD token
[SRGSSR] 10897634: Downloading f4m manifest
WARNING: Unable to download f4m manifest: HTTP Error 403: Forbidden
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib64/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib64/python3.6/site-packages/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/lib64/python3.6/site-packages/youtube_dl/extractor/srgssr.py", line 95, in _real_extract
    self._sort_formats(formats)
  File "/usr/lib64/python3.6/site-packages/youtube_dl/extractor/common.py", line 1327, in
_sort_formats
    raise ExtractorError('No video formats found')
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Unfortunately the video will not be online for a long time, but this issue may happen for other videos.
SRGSSRIE extractor is able to download episode 6 but not episode 7; I checked the asset_url and the only relevant difference is the presence of the ?caption=... in the query string of the episode 7.
To solve it I changed the line in _real_extract:
asset_url = asset['text']

to
asset_url = re.sub('\?caption=[^,?]*', '', asset['text'])

A bit sloppy, maybe we should prevent any addition of query, but this did the trick.

No longer accessible.


[Refactor] Fix PubMedQA

Same as #889 but for the big-refactor branch. Closes #886

Thanks very much for the PR! Was not aware of the other dataset's existence.


fix: fix the informer panic issue

What type of PR is this?

Which issue(s) does this PR fix?

Fixes #378
Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/lgtm
/approve


Add Support to "Need help? Contact us." section in settings

Should be as follows so 1:1 support requests do not land in Telegram community chat. Suggested changes highlighted in bold below.
Status Page
Telegram (Community)
WhatsApp (Support)
Email (Support)

there are been some changes here, closing this ticket as probably not relevant any more
but @pretyflaco feel free to re-open if needed.


chore: create a code of conduct

Adds a code of conduct for the project

@jreadey I added a code of conduct. More information about its purpose can be found here
Is<EMAIL_ADDRESS>the correct email to use for any reports of violations?


IE10 fails to load data for infowindow that's already been viewed.

This happens in IE10 Windows 8 (it may happen in other windows versions as well) cartodb.js 3.11.23  while viewing a map that has data added to the infowindow, it can be replicated on a cartodb provided example: http://docs.cartodb.com/tutorials/custom_interactivity.html
To replicate, in IE10:

click a marker that opens an infowindow, then close it
click another marker that opens an infowindow, close that.
click the original marker (The response generated from re-clicking the original marker should cause a response with a 304 status code to be returned)

In the example above, you'll notice that there's no city name included in the infowindow the second time that it's displayed.
In our case, we fixed this by overriding SQL.prototype.execute, wrapping the triggering of callbacks following an ajax callback in a setTimeout() (seen here - https://github.com/jlandfried/cartodb.js/commit/1706934388156405ad5fd3a338c0ebd6c3f3cc88).
I'm filing this as an issue, not a pull request, since I'm not that this something you even want to consider fixing since the issue seems to lie in IE10 and not the repository's code, and if you do want to fix it this may not be the approach you want to take, but I thought it should at least be brought to your attention.
Let me know if you could use any additional information.

current supported versions are  3.11.36 and 3.12.0 but I don't think that fixes that issue. Thanks for the diff, we will check it

Thanks,
Fwiw, I'm just using what's being served at http://libs.cartocdn.com/cartodb.js/v3/cartodb.js
The demo that I linked to is using  cartodb.js 3.11.36

Thank you very much @jlandfried for your feedback.
setTimeout(…,0)
The explanation is in this [StackOverflow post](http://stackoverflow.com/questions/779379/why-is-settimeoutfn-0-so
metimes-useful) :
Recaping: (there's a more large explanation in that post)

what setTimeout does is add a new event to the browser event queue and the rendering engine is already in that queue (not entirely true, but close enough) so it gets executed before the setTimeout event. .

Also, it was 'hard' to reproduce. I was using Windows 8.1 and InternetExplorer 11 emulating IE 10, but it was working correctly. So, I had to use a virtual machine from modern.ie with Win8/IE10. There, I could reproduce the problem, but it wasn't happening always. I think that the Internet connection and speed in events are related.
But, I exectued tests and one test failed "should call promise"
@javisantana , what do you think about this issue?

I think there is no other way to manage that than deferring the calling for a tick.
that test can be fixed increasing the timeout in that setTimeout for sure so I'd include @jlandfried 's patch including a link to this ticket.
thanks @jlandfried for you explanation, it's really good to get bug reports with this level of detail

great!
Pull request done

Fix merged.


refactor:eventhub/_eventprocessor:type hint added

Description
issue #25471
Changed \eventhub\azure-eventhub\azure\eventhub_eventprocessor directory with type hints
Will work with other dir too, later :)
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

@swathipil  applied your reviews!

/reopen

/azp run python - eventhub - tests

/azp run python - eventhub - tests

/azp run python - eventhub - tests

/azp run python - eventhub - ci

/azp run python - eventhub - tests


gather_data: replace comma in tag values

InfluxDB and Grafana see the comma different ways, so we can't use the
filter in Grafana when the comma in the job names and runner labels.
Resolves #137

Also, check code-style (flake8 has been failed)