solve memleak in parquet numpy reader

Is there memleak for parquet/numpy reader as well ?

I don't know
I would think no or we would have saw it in autofaiss

I didn't ran out of memory actually, so maybe it's just that the gc is not running for some reason until it's needed (but it did use more than 200GB of ram..)

I am not sure if this is same as what I have faced..
I am running into OOM when running the NSFW model example from the PR https://github.com/rom1504/embedding-reader/pull/16
I ran it with all the defaults, 10 parallel processes, except that the embeddings are already on file system(not form a cloud storage)
I see that memory keeps increasing as more batches are being processed, it eventually leads to OOM.
VM has 128 GB ram, all of it is available and no other process is contesting RAM
After doing some debugging using profiler.
Root cause seems to be somewhere in read_piece function from https://github.com/rom1504/embedding-reader/blob/main/embedding_reader/parquet_numpy_reader.py
Most specifically from reading the metadata it seems

I did a small modification to read_piece method to move out the metadata part so that I can apply @profile to it.
 None of them changed the behavior.
One thing to note is that, we are reading all the metadata using pyarrow and then picking the relevant columns. I see that pandas has a read_parquet method where we can specify the columns we want to read. Maybe using pandas read_parquet is elegant? Note that pandas internally uses pyarrow as a default engine.
I have tried with change also and I didn't see any difference, it leads OOM eventually.

probably the same problem
embeddings are there now https://mystic.the-eye.eu/public/AI/cah/laion5b/embeddings/laion1B-nolang/
fsspec supports https as well, so I'm going to use that to reproduce and fix

ok so after testing some more, it seems the problem is very related with the fact that it doesn't make much sense to read parquet files in arbitrary pieces because the disk serialization doesn't allow retrieving only these pieces. At best splitting in row groups could make sense.
I will test some more and maybe simply change the default such that the parquet+numpy and the parquet reader read whole file at once.
Another way to solve the problem in a more general way could be to keep the piece fetching logic, but instead of using it to load pieces of embedding files, use it to prepare on disk (or in memory) pieces of files at the byte level, and then load the batch all at once using numpy/pyarrow

solved now


Fix incorrect Snackbar render caused by updates

This fixes #315 by making Snackbar a pure component, checking if states/props are changed before updating.
I'm not sure whether I should move util the function like shallowDiffers() to a separate file, but other components might also have similar problem.
Also, this can be done by importing preact-compat/PureComponent, but I'm not sure if it worth it importing a dependency only for a fraction of code.

BTW I somehow couldn't run the pre-commit hook, it always says ./node_modules/pre-commit/hook: line 49: : command not found, so I manually ran lint and copied the linted file to submit on Github web.
Also the version of preact-material-components in package-lock.json seem to be outdated.


README sample code is broken (upstream also)

The setup instructions in the README are broken (and they are broken in the upstream repo as well).

Incorrect const assignment, copy/paste error from another plugin, invalid plugin (not @hirusi/...
Incorrect plugin config, extra closing brace, incorrect plugin const name

Should be:
const safeExternalLinks = require("@hirusi/eleventy-plugin-safe-external-links")

module.exports = function (eleventyConfig) {
  ...snip...

  eleventyConfig.addPlugin(safeExternalLinks, {
    pattern: "https{0,1}://", // RegExp pattern for external links
    noopener: true, // Whether to include noopener
    noreferrer: false, // Whether to include noreferrer
    files: [
      // What output file extensions to work on
      ".html",
    ],
  })

  ...snip...
}

Most of these issues also apply to the README in the upstream repo where these issues seem to have originated:
https://github.com/chromeos/static-site-scaffold-modules/blob/master/modules/eleventy-plugin-safe-external-links/README.md

Hi @grempe! 😊
Thank you for pointing this out! Would you like to open a PR or are you happy for me to fix this?
Personally I hand-wrote my config as follows, and didn't think to test this from the README:
        config.addPlugin(require("@hirusi/eleventy-plugin-safe-external-links"), {
		pattern: "https{0,1}://", // RegExp pattern for external links
		noopener: true, // Whether to include noopener
		noreferrer: true, // Whether to include noreferrer
		files: [
			// What output file extensions to work on
			".html"
		]
	});

Happy to have you resolve.
I think my use of require is more idiomatic.
I'm not sure if setting both values to true as the default is necessary.
https://pointjupiter.com/what-noopener-noreferrer-nofollow-explained/
Cheers

...and we're good - thanks @grempe!


FamilyInstance.ByGeometry - Multiple Entities

This is a great node. Period!

I would like it to put multiple geometries in one family if we feed a list of geometries.
Input for origin of the family so the family has a decent origin and the node later translates the instance into the correct location in the project. (I think you're working on this one)

Again this is great thinking and coding Dimitar!

Thank you, Mehmet.
It is possible to put multiple geometries inside the same family with the current implementation of the node. However, they have to be heterogeneous (all surfaces or all solids) and that is purely thanks to the forgiving nature of Dynamo's (and to extension Revit's) shape manager.
In Dynamo you can create discontinuous poly-surfaces and "poly-solids" that will be treated as a single entity:

I've used this method a few times already without any major repercussions. You will not be able to edit the shape of the family manually and you will not be able to get correct material areas. However, volume seems to still be reported correctly for the "poly-solids.

I was thinking about doing sat import multiple times when in the famdoc. So we can have individual geometries in the same family.
I'm trying to modify your code but I have to spend some time to understand the operations in the famdoc.
Very inspiring node!

https://www.youtube.com/watch?v=a_1m1S3Mwrw

Good job !

As always, great work.. Two questions / suggestions:  1. Is it possible to assign multiple materials to the multiple geometries put into the family instance(s)?  This would make creation of bespoke families containing >1 material much easier.  2. Is it possible to allow referencing an .rfa instead of an .rft?  I currently use a Generic Model master template that has every parameter/material I may want to use, but an .rfa would streamline updates to the master (since the user wouldn't have to save a copy of an .rfa and rename the extension each time a change is made down the pipe.). -Best

Hi @Curty102,
Thanks. This node has actually been converted and will be available with Dynamo 1.3 by default. (it's already available in the dailies as "FamilyType.ByGeometry")
Both options are possible from the context of the API. However I feel that, adding any more inputs and complexity to the current node would deter an already fragile workflow. Because the whole process is ran entirely in the background, I can't rely on Dynamo's built-in associative lacing and have to handle all of that in my script. Ensuring that the user always provides a matching list of inputs or replicating the inputs automatically will be a challenge.
It sounds like you have a very specific task in mind, that might be handled better by a workflow specifically designed around it.

https://www.youtube.com/watch?v=a_1m1S3Mwrw

Hi all,
ist there a way to get the *.dyn from the video above? Currently I´m working on a scrypt to convert multiple solids to familyinstances. When I do this, I only get a high number of family types with only one instance. In the video there´s only one family type for multiple individual instances.
Thanks for your help.
Best regards

Did someone manage to getmultiple solids into one family.. i am dying out here please help

Did someone manage to getmultiple solids into one family.. i am dying out here please help

Hello, i'm new here but today i tested the Node FamilyInstance.ByGeometry, i had the same issue, to create a single generic model composed by multiple solids.
I have Revit 2021. I used the node Solid.ByUnion which is a native dynamo node, i placed the list with all my solids in input and i connected the single solid output into "Geometry" input of the Spring Node.
It worked. I have a single family, a generic model, composed by multiple and disconnected solids.

@DamianoDP Hey, would you please share a screenshot of your Dynamo script, and{or the sources if you are using pytho code?
The thing is, the FamilyInstance.ByGeometry node (and other ondes using SAT import in code behind) got somewhat broken in Revit 2022.1. I've tried kind of your method of using Solid.ByUnion as a workaround, but that is a Dynamo node and returns Autodesk.DesignScript.Geometry.Solid not Autodesk.Revit.DB.Solid which other nodes in dynamo need. I'm not sure how to correctly wire the script together to end up with a new FamilyInstance of consolidated solids.

@DamianoDP Hey, would you please share a screenshot of your Dynamo script, and{or the sources if you are using pytho code?
The thing is, the FamilyInstance.ByGeometry node (and other ondes using SAT import in code behind) got somewhat broken in Revit 2022.1. I've tried kind of your method of using Solid.ByUnion as a workaround, but that is a Dynamo node and returns Autodesk.DesignScript.Geometry.Solid not Autodesk.Revit.DB.Solid which other nodes in dynamo need. I'm not sure how to correctly wire the script together to end up with a new FamilyInstance of consolidated solids.

Hello, I can not provide you the script because it has stopped working, I was using Revit 2021, and with that everything was working perfectly, sadly in revit 2022 is not working anymore and I have created manually my solids :(

Hello, I can not provide you the script because it has stopped working, I was using Revit 2021, and with that everything was working perfectly, sadly in revit 2022 is not working anymore and I have created manually my solids :( (But if you are still working in 2021 I go search the working 2021 files hoping I have not deleted them)

Hey,
it seems to be all the same problem - Document.Import imports Mesh instead of Solid in Revit 2022.1.
I tried to describe the problem in following Revit API Forums thread and am hoping for finding a workaround to sort this problem out. I'm primarily a programmer and am not that much experienced in Revit. I'd appreciate support or further information on that forum to hopefully drive attention to it.
https://forums.autodesk.com/t5/revit-api-forum/document-import-of-sat-file-behavior-changes-in-2022-1-imports/td-p/10833349

Hello
I have upgraded to Revit/Dynamo 2023, and the Family.Instance.ByGeometry seems to be working now, I gave up on Revit 2022. However, I am trying now to create a single Revit family with multiple geometries (Solids) with materials assigned. Has anyone else got this to work or can suggest a method?
Thank you!
Tim


Password fields should have the option to display password

Description
Textfields with type='password' are great for obscuring the password. However, in non-shared environments people commonly want to be able to see the password. I would like to request an option to have the textfield include a "show" button for passwords.
Images & references
While this could always be built separately, the difficulty is in consistently styling it to lie inside the textfield to the right.

This needs to be implemented in user land. Not something we'll add to the core of the lib.

@pathsny My suggestion would be to identify the fixes required to make this easier to implement yourself. What are you thinking?


No model with name 'User' registered in app 'diff_models'

After installing (from the dev branch) and setting up fastapi-admin, I attempted to run aerich migrate, which failed with the error:
tortoise.exceptions.ConfigurationError: No model with name 'User' registered in app 'diff_models'.

But I didn't register any app named diff_models, and I don't see it in the code for this repo... so I'm pretty stumped as to how to fix this. If you could please point me in the right direction, that would be amazing.

fastapi-admin provide builtin auth and permissions control, which include builtin model User,Permission and Role, if you don't need it, just set permission=False when call admin_app.init(), otherwise you need add fastapi_admin.models into tortoise config,such as:
TORTOISE_ORM = {
    'connections': {
        'default': os.getenv('DATABASE_URL')
    },
    'apps': {
        'models': {
            'models': ['examples.models', 'fastapi_admin.models'],
            'default_connection': 'default',
        }
    }
}

My current config does contain fastapi_admin.models:
TORTOISE_ORM = {
    "connections": {
        "default": {

            },
        },
    },
    "apps": {
        "models": {
            "models": ["app.models", "fastapi_admin.models", "aerich.models"],
            "default_connection": "default",
        },
    },
}

Is this incorrect, or maybe I did something else wrong?

I found that, which is a bug and I fixed it.Now you update fastapi-admin from dev branch, then if you want use builtin auth and permissions control, you should inherit fastapi_admin.models.AbstractUser and add you own fields,must contains
is_active and is_superuser as the REAMDME.md said:
from fastapi_admin.models import AbstractUser

class User(AbstractUser):
    last_login = fields.DatetimeField(description="Last Login", default=datetime.datetime.now)
    is_active = fields.BooleanField(default=True, description="Is Active")
    is_superuser = fields.BooleanField(default=False, description="Is SuperUser")
    avatar = fields.CharField(max_length=200, default="")
    intro = fields.TextField(default="")
    created_at = fields.DatetimeField(auto_now_add=True)

    def __str__(self):
        return f"{self.pk}#{self.username}"

Then aerich will work correctly.

I installed the latest fastapi-admin. Unfortunately, it still doesn't work, but I'm now thinking that this has nothing to do with fastapi-admin, and I must have done something that aerich doesn't understand. Fortunately, I can get it working with just aerich init-db, for now.


added goal visualization to planner_manager

Changed the unused bound_pub to be goal_pub and publish a marker at the goal state upon MaybeRequestTrajectory() call. Updated the position-velocity manager launch file to reflect the change of bound_pub to goal_pub (and corresponding topics).

Updated software_demo.launch with the param and args and removed prints and made changes to VisualizeGoal() function.

Fixed const issue.

Software demo runs!


feature: Add YAML schema selection functionality to YAML extra

Did you check the docs?

[X] I have read all the LazyVim docs

Is your feature request related to a problem? Please describe.
Sometimes the incorrect YAML schema is automatically selected, which causes errors to show which aren't correct.
Describe the solution you'd like
In this scenario, it would be great to have the functionality to select the YAML schema manually. It would also be nice to add some information to the statusbar showing which schema is currently being used.
Perhaps something like: https://github.com/someone-stole-my-name/yaml-companion.nvim.git
Describe alternatives you've considered
Looked if there was a way to do it with the current plugins for the YAML lazy extra but did not determine a solution on my own
Additional context
No response

Related #2907

https://github.com/LazyVim/LazyVim/pull/2907#issuecomment-2150180952


Standardize Entity type

Description
Let's use type Entity = number instead of directly using numbers for clarity.
Acceptance Criteria
Tasks
Use this section to keep track of work

QA Notes
Environments
Steps

Also fixed #381 in this ticket.


No cleanup on window

listenForSubmit(window) && listenForNavigate(window) both return cleanup functions that are never run.

Yeah, Alpine has an undocumented destroy hook that these cleanup functions were intended for, but I was waiting to get some more clarity there before implementing them.
Do you have a case where you’re needing those listeners cleaned up?

Yes they are creating garbage events that are part of the tab session.  They is no guarantee when they'll be cleared, both if you used Alpine directive it has an explicit cleanup function

My hesitation with making x-target a directive is this:
It's fairly common to have hundreds of x-target's on the page when building dashboard UIs. If x-target was a directive, there would be at at least one event listener on the page for every x-target. Right now, for performance reasons, Alpine AJAX only registers 2 event listeners on window and all x-target elements delegate to those listeners instead of registering their own.
What if I added a global cleanup function on the Alpine object for those listeners? Something like Alpine.ajax.disable(), calling it  would clean up the listeners and disable all x-target behavior on the page.

We've talked OOB but I think there is a definite trade-off.  Right now you have a global function that is executing a full query on any update.  A listener closure will cost more memory but will be only executed on trigger.  The directive approach is more inline with normal usage of Alpine such as x-on.  Maybe an example with 1000s of divs with addEventListener would prove it out either way.  But seems like optimization for the wrong metric (cleanup and GC being already handled by the directive)

Yep, I'm warming up to the idea of making x-target a real directive. I think talking through more x-data uses will get me there.


DW1000 Configuration need help !

I hardly get ranging above 10 meter, and my currently used configuration are:
mode: MODE_LONGDATA_RANGE_ACCURACY
rate: TRX_RATE_110KBPS
frequency: TX_PULSE_FREQ_64MHZ
preamble length: TX_PREAMBLE_LEN_2048
DEFAULT_REPLY_DELAY_TIME :  3000 us
DEFAULT_TIMER_DELAY: 50
These are the things that i changed from the source, any help would be much appreciated

@hle92294 Please use the template for issues https://github.com/thotro/arduino-dw1000/blob/master/.github/ISSUE_TEMPLATE.md . Thanks.
Please reopen a new reworked issue. Closed due a lack of information (no information about used micro controller, used board, compiler, library version, what source used for ranging... ).


Check that the candidateObject is an object and has a candidate property

Description
Purpose

lgtm on "src/web_app/js/peerconnectionclient.js".
We are going to do another pull request for the other fix.

that is mostly used for ?it=relay, right? If so lets drop the code in favor of setting iceTransport

I will create a more complete PR later, closing this for now.


Updating from couter-up

Hello,
I was using Counter-up in my site, I just updated jQuery version in the site to 3.3.1. Can you please in a demo where a user who is using jQuery can use this. too. Something similar to https://github.com/bfintal/Counter-Up/blob/master/demo/demo.html

Hi, unlike the old counter-up, this one doesn't require jQuery.
The usage is available in the readme: https://github.com/bfintal/Counter-Up2


New release: 2.2.4

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description
Bump of jwcrypto package for security alert purposes.

[x] Add a summary of the changes and the related issue

Type of change

[x] Security Alert fix

Checklist:
General

[x] Changelog: New row added. Not needed when PR includes only tests.

Repository / Releases

[x] Blocking PRs have been merged
[x] Rebase / update of branch done
[x] PR to master branch (Product Owner / Scrum Master)

[x] The version is updated

Checks

[x] Formatting: Black & Prettier checks pass
[x] CodeQL passes
Tests

[x] The tests pass

@valyo Ready for review (not in detail) and approval


Expanding Test Suite

Right now I am using Guavas Test-suite to ensure the quality of Primitive Collections.
But that right now only covers Javas Collection functions and only generics.
While Generics delegate to primitives, this isn't perfect either.
Since we have 7 implementations and a lot of custom functions, that means we don't have the coverage that I would like.
The end goal would be to have a Library like guavas Test-suite but for primitive collections.
Where a lot of features are supported and adding to that would be a lot easier.
This will most likely be its own library with maybe a dependency on Primitive Collections.
How would we get there is now the question.
Fairly easily actually.
Since Guava provides a lot of the base that we actually want, we can start with it.
Then we just append our features on top of that.
Because we want to keep the Java Class Type to primitive type checks anyways that would ensure a Dual Check System.
Now since that still is a lot of work this isn't going to be completed anytime soon.
But it is here and it allows me to document progress properly.
So lets throw in a todo-list of what needs to be done.

[x] Design a Framework that runs on top of Guavas Test Suite or makes use of it.
[x] Write the designed Framework

[x] Collections
[x] Collections Template
[x] Lists
[x] Lists Template
[x] Sets
[x] Sets Template
[ ] Queues
[ ] Queues Template
[x] Maps
[x] Maps Template
[ ] Extras
[ ] Extras Template

If anyone wants to help with this you are welcome to do so.
Even with providing inputs or Sources how to improve this even more.

Small Progress Update for anyone who is following.
I started implementing a whole UnitTest System that is testing as much as possible.
it is cloning a lot from guava and implementing primitive Variants.
Now that the Lists/Sets/Collections are implemented means I can now start writing templates for them.
Once these templates are written I can basically have for each implementation their own dedicated UnitTest.
Though the Object implementation isn't thought out yet.
Same with Maps.
But overall this is a good but slow process.
Without Maps this will get into the 50-70k unit tests which should improve the coverage a lot.

Small Progress Update
The Improvements on code coverage are actually less then I expected. The Areas that are now covered were from 0 to +50% covered. A bit less then I expected. I was hoping for 80% but eh you can't have everything and it is only the start.
But I think the 0.6.2 version should be soon published since there were actual bugs found with the system and I was able to fix them thanks to this coverage.

So after finally adding the Map unit Tests its time for a bit of recap.
I added Roughly 7 Million Unit tests to Primitive Collections with the Map Tests.
Which move the Coverage from 4.73% to 34.76% Coverage. Which is still below the Amount I am wishing for.
But I can't finish everything in a bulk process. This was so much work that I need to take a break from it.
But before I do I am going to make a new version since there were a lot of issues fixed.
Oh yeah by the way everything that is tested is at 40-50% coverage on average. Though there is exceptions in either direction.

Coverage Tracker

So I couldn't stop myself.
I added a couple more unit tests. Just like 100 or 200 and they resulted with a couple new implementations being added into 55.26% coverage. So we reached half way point in the testing department.
So it is growing.

A bit more work done.
I added Support for the CollectionWrappers (SynchronizedX, UnmodifiableX, EmptyX, SingletonX) and that added a bit more coverage. Its not as much as the last one but we are now 62.94% Coverage.
The goal is 70-80%. Over time that might increase but the average should be around that.

Another day another increase in Coverage.
We have reached 71.16% Coverage. Which is within the goals range but there is some things I still want to do.
Queues are not tested yet but that comes when i am done with maps.
Thanks to Guavas Test Library I was able to get a really good coverage.

Well a bit more work done.
With the help of maps we are now at 80% coverage and 70% branch coverage (basically if all if statements are tested)
Which is the goal I had, but there is a bit more to do.
Sets/Lists are on average by 60% coverage, which is not the amount I want, and Queues aren't tested at all yet.
So the next thing I am going to work on is the Set/List implementation to get them up to 80% coverage at the very least too.
And that should also increase Map coverage a tiny bit too since there is a lot of tests that "sets" do that are included in "maps" too.

Also since @@ben-manes was interested in notifications if I do some more.
To give you a small overview on what i did:
Basically I templated Guavas TestUnits and Created Primitive Variants on them (Generated automatically) and increased the test suite insanely.
(Not done yet though)

Congrats, you beat Caffeine's test suite size which is a mere 8.9 million. 😉
I know you can extend Guava's testing framework to plug in more scenarios. It sounds like that is what you did?
For mine, I used TestNG's parameterized tests (@DataProvider), which generates the permutations from an method annotation (@CacheSpec), and passes in the instance to test and a context object describing the scenario (as sometimes needed by the test logic). Not externally reusable but very nice for my own needs.

I know you can extend Guava's testing framework to plug in more scenarios. It sounds like that is what you did?

Yep after looking into the options this was just very smooth to use.
While it is nice to use I am telling you it is not perfect solution either. It has some growing pains. Especially with "BooleanSets/Maps"

Congrats, you beat Caffeine's test suite size which is a mere 8.9 million. 😉

😆 I am honest here. That wasn't even the plan. But thank you.

For mine, I used TestNG's parameterized tests (@DataProvider), which generates the permutations from an method annotation (@CacheSpec), and passes in the instance to test and a context object describing the scenario (as sometimes needed by the test logic). Not externally reusable but very nice for my own needs.

That is also a fine way to do it. But sadly not applicable for the coverage I was aiming for. (I wanted to do tests for all permutations and have a very little impact on my templating process)
But believe me reaching the 80% wasn't easy... AT ALL....

Complexity Coverage basically is "Branch Coverage" and as you can see the moment the tests were effectively applied that went up crazily xD

And to update further notice to anyone reading this kinda semi blog.
Coverage is now at 83% average, where the average is slowly balancing to 85% and other packages slowly getting there too.
Queues still weren't started since the Lists/Sets aren't finished yet. Maps can only be completed by actually deleting duplicated code.
Misc is basically a wildcard that means anything that doesn't fit.

Ok Reached 85% coverage, with each implementation of collections having a average coverage of 80-100% for each implementation. (Though queues are 60% average, but 90% of that is constructors)
But at this point I have to stop. I have been working on this for roughly 3 weeks now and need to stop and work on other projects.
Further tests come as I work on this project but a 85% coverage is healthy enough and makes sure everything works!
Some stats:
Primitive Collections on its debug branch has 11.382.503 Tests (11.3 Million Tests)
Which give it a coverage of 85.27% and a branch Coverage of 75.17%.
For everyone who just reads this comments: Branch Coverage is basically how many ifs are fully checked.
Out of 661.688 (662k) lines. (~81k per type)
564198 (564k) lines are fully tested. (~70k per type)
34943 (35k) are partially tested. (~4.2k per type)
62547 (63k) are not tested at all. (~7.2k per type)
So this is a huge project and now we have the stability and insurance everything is backed by unit tests.
 Make sure you use templates. Otherwise you are crazy.

Anyhow now pushing out the 0.7.0 update since this is not a patch anymore.

And update 0.7.0 is out.
I have to thank you again @ben-manes. If you didn't suggest the Guava Test Lib to @vigna then I would never have started this and reach a coverage that should ensure the quality I wanted to have for my competing library.
@vigna you are free to look into the debug branch and try to improve the quality of FastUtils stability too if you want to.
To be fair, thank you for basically ignoring my want to improve the library, because this actually helped me to get a lot more invested in this kind of stuff and grow also as a coder but also as a person.
So thank you very much for that.


Added reference name in clone options for git clone

Fixes  https://github.com/numaproj-labs/numaplane/issues/226
Modifications
This PR modifies the GetReferenceName and cloneRepo functions to better handle branch names that are not the default main. Changes include:

Updating the GetReferenceName function to more accurately determine and return appropriate plumbing.ReferenceName for any given branch or tag  name (Commit hash has been not included).
Adjusting the cloneRepo method to use the updated reference name handling, ensuring that the cloning process supports all types of reference  names without throwing a "Reference Not Found" error.

Verification
The changes were manually tested by  running  existing tests by make test .

Closing as raised another PR

I believe fetchUpdate() function should also need to be updated for referencing branch/tag/commit ?

i guess its not required if we are cloning the particular branch or tag the Head by default would point to the  that branch or tag and we can take pull or fetch without mentioning the branch or tagname in pull options


Feature Request: User-Defined Profiles for Panel Configs

Currently, there is no way to save a default or user-defined panel configuration. When one selects a configuration to emulate Windows, Mac, XFCE, etc. the current configuration is overridden and seems to be non-recoverable (no back or default settings button). It would be great to be able to create user-defined configurations so that one can save theirs and go back to it. Or at least a default profile saved along with the windows, xfce, mac, etc options so that a user can return to default settings if they decide to.

Update: work is almost finished on this feature: https://github.com/trueos/lumina/commit/ca225b7bd525ea961bf5aec2fa3f8c05e8307e4e#diff-a9efb41c2cf98ccc76f2f18849f74832

Done!
https://github.com/trueos/lumina/commit/909e7594e9e817c8602e8eade20ac2ade87deb44


Parallelize ctest by default

Would it make sense to parallelize the ctest target by default ("make test" or "cmake --build . --target test") using a method similar to this https://cmake.org/cmake/help/latest/module/ProcessorCount.html#module:ProcessorCount? On some platforms these tests can take a long time to run serially, so it might be nice to let each test run on a different core (as opposed to making multiple cores available to each test as in the above link).
Before I submit this change, I wanted to confirm that the current serially behavior isn't preferred. Thanks!

@NathanielMcVicar Not sure I follow what you are saying. Can you elaborate?
@sstamenova make test not running in parallel by default really is a make behavior. People who don't use the dockerfiles obviously need to run the command themselves and might be expecting the default behavior.

The issue is that other tools (such as ninja) will not run in parallel either. So ninja test does not run in parallel even though the default behavior for ninja is to run in parallel.

The issue is that other tools (such as ninja) will not run in parallel either. So ninja test does not run in parallel even though the default behavior for ninja is to run in parallel.

I'm not following. Why doesn't ninja test run in parallel if the default is to run in parallel? Also I don't see how it is related to the make behavior?

I'd like to better understand the thought process here. In general, there is some default behavior for parallelizing (across unit test tools like ctest, pytest, etc. and build tools ninja, make, msbuild, etc.). Typically for most of these tools this is the number of cores. On platforms where that behavior isn't appropriate it can be overridden. If ONNX MLIR instead defaults to serial or small constant numbers of threads, and requires overrides for more parallel builds, that makes sense, but I would like to understand better. The current approach seems slightly inconsistent (for example, using full parallel builds by default with ninja).
As an aside, the issue with ninja vs. make is that ninja (by design) doesn't provide a way to pass arguments to targets (other than using the environment) like make does. See: https://github.com/ninja-build/ninja/issues/1387

Yes $(nproc) was fine most of the time, until we ran into problem with a Jenkins CI server that kept getting killed because it had 128 CPUs (SMT) but only 32GB memory. That was why the algorithm to compute a better NPROC mentioned in https://github.com/onnx/onnx-mlir/issues/669#issuecomment-839293610 was introduced. All build processes and tests have been changed to use the computed NPROC, including building llvm-project by ninja in docker/Dockerfile.llvm-project. Outside of the Jenkins CI docker environment, you are obviously free to do whatever you prefer.

Just to close the loop on this, we have gone with forcing parallel test count using the environment for our own CI. It would be nice to have a consistent approach across the project, but given all the different CI systems that need support, it may not be practical as discussed here.

Actually, how about this - what it we added a cmake option to set the parallelism of the tests but had it default to 1? Then for anyone who is not expecting it, the behavior would not change, but for someone who wanted to add parallelism to all of the tests, they could specify it.

Actually, how about this - what it we added a cmake option to set the parallelism of the tests but had it default to 1? Then for anyone who is not expecting it, the behavior would not change, but for someone who wanted to add parallelism to all of the tests, they could specify it.

I'm not sure why you need a cmake option for it. make test already behaves that way. It defaults to serial tests. If you want parallel tests, you just do make ARGS=-j$(nproc) test.

I think we are recovering ground from above now, but this solution doesn't work with ninja (https://github.com/ninja-build/ninja/issues/1387)

So I'm not sure what we are trying to achieve here. Making parallel tests work for ninja? Isn't it a ninja problem? I don't want to start a make vs ninja war. People use whatever tool they prefer. I just don't see how this is onnx-mlir's business.

The goal is to have a consistent way of building and running tests that works cross-platform and cross-tool. llvm has mostly achieved this using lit to run the tests and with clever cmake defaults, so we would like to have the same experience with onnx-mlir as well.
Coming back to the tests specifically, ninja, make and Visual Studio ALL behave differently when you try to invoke a target and run the tests in parallel from the command line. At best we can achieve parity by setting environment variables such as CTEST_PARALLEL_LEVEL but that again breaks with the llvm convention of not polluting the environment with settings that one has to remember to set every time or that can impact other builds (setting CTEST_PARALLEL_LEVEL impacts all ctest runs from all projects). On the other hand, we can add a cmake variable that will control this behavior consistently across tools and platforms, will not pollute the environment , will be saved across runs and will provide parallelism for the tests (and unsurprisingly running tests in parallel is the llvm default, though there's a cmake option for lit to change that).
In an ideal world, all of the onnx-mlir tests would move to using lit (which can be used to run all sorts of tests, not just the kind of tests in check-onnx-lit) and then the settings would be controlled consistently for all of the test targets in onnx-mlir, but that is a bigger task than adding a cmake variable for parallel test execution.

In an ideal world, everybody would be just using ARGS=-j$(nproc) cmake --build . --target test and be done with it. The problem is that everybody thinks they can write a better build tool so we end up with 100s of them doing pretty much the same thing.

Except ARGS=-j$(nproc) cmake --build . --target test does not work for ninja or Visual Studio only for make. And even if it did work for ninja or Visual Studio, it still wouldn't work on Windows because it's not valid syntax for the Windows command line. This is a very make-oriented approach while the most common way to build llvm is ninja (look at all the buildbots, for example), so I think ninja is the tool onnx-mlir should optimize for, not make which has been falling out of favor in general.
Building on all the work that has been done in llvm for build and test is going to be much more flexible and well-supported long-term.

Of course it does not work for ninja, that's the whole point. On a specific system, if make works perfectly fine, why would I mess with ninja? If it doesn't work on another system (e.g., windows), that's a separate issue (I know the command doesn't work on windows. It's meant to be an illustration, not meant to be taken literally).
Sorry I'm not sure where you get the idea that make is falling out of favor in general. cmake by default still generates Makefiles on Unix-like systems including Mac OSX. And most Linux distros don't even install ninja by default.
Having said all these, if you want to reuse whatever LLVM did with ninja to do parallel tests, that's fine with me. As I mentioned in one of the posts above, outside the Jenkins CI environment, you can do pretty much whatever you want to build and test.


windows上Brotli要怎么安装

PS C:\Windows\system32> choco install brotli --execution-timeout 10000
Chocolatey v2.2.2
Installing the following packages:
brotli
By installing, you accept licenses for the packages.
brotli not installed. The package was not found with the source(s) listed.
Source(s): 'https://community.chocolatey.org/api/v2/'
NOTE: When you specify explicit sources, it overrides default sources.
If the package version is a prerelease and you didn't specify --pre,
the package may not be found.
Please see https://docs.chocolatey.org/en-us/troubleshooting for more
assistance.
Chocolatey installed 0/1 packages. 1 packages failed.
See the log for details (D:\ProgramData\chocolatey\logs\chocolatey.log).
Failures

brotli - brotli not installed. The package was not found with the source(s) listed.
Source(s): 'https://community.chocolatey.org/api/v2/'
NOTE: When you specify explicit sources, it overrides default sources.
If the package version is a prerelease and you didn't specify --pre,
the package may not be found.
Please see https://docs.chocolatey.org/en-us/troubleshooting for more
assistance.

看看这个可以用不 https://strontic.github.io/xcyclopedia/library/brotli.exe-CD02E5A2AC0FA8CF23C0E1AF3F22222D.html

看看这个可以用不 https://strontic.github.io/xcyclopedia/library/brotli.exe-CD02E5A2AC0FA8CF23C0E1AF3F22222D.html

这个要怎么下载


0.24.2 - error String contains null byte when running in path with non ASCII chars

Error:
$ cd ~/Документы/Проекты
$ echo 'puts "123"' > test.cr
$ crystal run test.cr
String contains null byte
???
???
???
???
???
???
???
???

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

All is ok:
$ cd /tmp
$ echo 'puts "123"' > test.cr
$ crystal run test.cr
123

I can reproduce this, but using a built compiler seems to make it go away. Investigating more...

Narrowed it down to this: https://carc.in/#/r/3p2k
p "/home/rx14/Документы/Проекты/test.cr".gsub('/', '-')

"-home-rx14-Доку\xD0-ент\xD1-/Про\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000"

triggered by https://github.com/crystal-lang/crystal/blob/92c3d42315760c08bdeca9d414188bb633299d10/src/compiler/crystal/codegen/cache_dir.cr#L34

Looks like a duplicate of #5348 which didn't make it into 0.24.2.

Thanks for investigation :)

It's odd that old issue is closed and bug was still there in 0.24.2 release.

@ZaWertun 0.24.2 was released from a different branch with cherry-picked bugfixes. Unfortunately this bugfix wasn't cherry-picked for 0.24.2.

Ah, got it

@RX14 This is really sad considering that you explicitly recommended to include #5348 in 0.24.2 :(

I always suggest to keep moving forward with breaking changes and releases in master and forget about hot fixes and bug fixes releases until we hit 1.0. It's simpler, and this kind of issues don't happen. But it seems they don't like it (I think everyone except Manas liked the old way)


'podman system reset' shouldn't nuke unrelated things in $XDG_RUNTIME_DIR

/kind bug
Description
I tried resetting the rootless Podman storage using podman system reset a few times over the last week. On at least one occasion it tried to remove almost everything inside $XDG_RUNTIME_DIR, and not just the container bits like $XDG_RUNTIME_DIR/overlay-* or $XDG_RUNTIME_DIR/containers. Among the things that disappeared were the session D-Bus, Pipewire and Wayland sockets. The attempt to remove $XDG_RUNTIME_DIR/doc which is a FUSE mount point for Flatpak even led to:
Error: unlinkat /run/user/1000/doc/by-app/org.gnome.Documents: function not implemented

Additional information you deem important (e.g. issue happens only occasionally):
This didn't happen on every podman system reset run, though. Other times it seemed to restrict itself to the relevant container-specific directories.
Output of podman version:
Version:            1.7.0-rc2
RemoteAPI Version:  1
Go Version:         go1.13.5
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.13.5
  podman version: 1.7.0-rc2
host:
  BuildahVersion: 1.12.0
  CgroupVersion: v2
  Conmon:
    package: conmon-2.0.2-1.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.2, commit: 186a550ba0866ce799d74006dab97969a2107979'
  Distribution:
    distribution: fedora
    version: "31"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    name: crun
    package: crun-0.10.6-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.10.6
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: journald
  hostname: kolache
  kernel: 5.4.7-200.fc31.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.3+dev
      commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e
  uptime: 50m 25.39s
registries:
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /home/rishi/.config/containers/storage.conf
  ContainerStore:
    number: 1
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.7.2-2.fc31.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.7.2
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /home/rishi/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 1
  RunRoot: /run/user/1000/containers
  VolumePath: /home/rishi/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.7.0-0.4.rc2.fc31.x86_64

Strange.  I thought we had fixed it, with a PR to containers/storage.

@QiWang19 PTAL

@QiWang19 Reminder.

I can't replicate this issue. For me podman system reset only removes /run/user/1000/containers
Do we need to make these changes, to not remove /run/user/$UID/containers in system reset?

I think we need to just delete the c/storage directories, instead of the entire temporary directory - we still have a lot of old installs with /run/user/$UID as tmpdir, not a subdirectory

The problem is if our temporary directory is set to /run/user/1000 - which it was, on some older systems. In that case, we remove all the contents of the directory - including things that are definitely not Podman.

@mheon So what do we do?  Is this an upgrade issue?  New versions of podman all use the containers subdir.  Did we record something in the database that causes us the issues?

Yeah, upgrade issue - older installations use /run/user/$UID/ with no subdirectory for one of the tmpdirs (I forget if it's c/storage or Podman... Might actually be c/storage?)

Yes it is in container/storage.  But would a reboot fix the /run directive or only a full clean?

Only a full clean - it's potentially in both the database and libpod.conf

Ok lets check to see if the director == $XDG_RUNTIME_DIR, and not remove it in that case.  If it is containers then it should be removed.


[Bug]: Postgres plugin: fix idle connection issue with Supabase

Is there an existing issue for this?

[X] I have searched the existing issues

Description
ref: https://theappsmith.slack.com/archives/C03P17RSW6S/p1695106039593359?thread_ts=1694542897.484119&cid=C03P17RSW6S
Also, tracking it on Supabase here: https://github.com/supabase/supabase/issues/17549
Steps To Reproduce
https://theappsmith.slack.com/archives/C03P17RSW6S/p1695106039593359?thread_ts=1694542897.484119&cid=C03P17RSW6S
Public Sample App
No response
Environment
Production
Issue video log
https://theappsmith.slack.com/archives/C03P17RSW6S/p1695103878482639?thread_ts=1694542897.484119&cid=C03P17RSW6S
Version
cloud, self hosted

Does your driver do pooling for you?
If so you can set the max connection count, otherwise use the pooler provided by Supabase (pgbouncer or Supavisor) by using the provided connection string in the Supabase dashboard.
Maybe there are some things you could do to default users to using a Supabase connection pool.

I believe this now works with the new supabase changes


NameError: name 'password' is not defined

Describe the bug
The tunnel does not start and gives a "not defined error"
To Reproduce
Steps to reproduce the behavior:

Create new code cell.
Paste this:

# Install colab_ssh on google colab
!pip install colab_ssh --upgrade

from colab_ssh import launch_ssh_cloudflared, init_git_cloudflared
launch_ssh_cloudflared(password)

Run the cell.

Expected behavior
Client machine configuration prompt should appear.
Screenshots

Run like that:
from colab_ssh import launch_ssh_cloudflared, init_git_cloudflared
launch_ssh_cloudflared(password="YourPassword")

Hello @thegreatestminer,
Welcome to the colab-ssh Community :)
I think @attacker007 answered your question. Thank you @attacker007, for clarifying that.
We should probably clarify that in the Getting Started guide.

Hi @WassimBenzarti  it will be much more easier if you make short tutorial. As I am also having some confusion.
Thanks !!

@attacker007 Works perfectly, thank you!!
@WassimBenzarti Thank you :D


integration: move cap enabling to init

Fix #5367
Fix #5469
We have multiple functions that can setup v3 cluster. So just enabling v3 in init for simplicity.
/cc @heyitsanthony

lgtm


This block of commented-out lines of code should be removed.

Issue
A block of commented-out lines of code should be removed, according to a code smell found by Sonarqube. For maintainability to increase, this problem must be fixed.
Screenshot

Filename
src/main/java/de/storchp/opentracks/osmplugin/MapsActivity.java


Invalid Aurora version is hardcoded

Hello,
Currently, when deploying a stack with this Keycloak construct, I get this error:
Cannot find version 5.7.mysql_aurora.2.09.1 for aurora-mysql

Looks like 2.09.1 is no longer listed in the dropdown for creating a new Aurora instance (2.11.2 is the latest).  Gonna try to tweak via patch-package, and if I find a fix that works, can open a PR.

+1 getting same error when I use this too.


March update: Several buttons missing labels, accessibility severely broken

I use VS Code Insiders. Just got a report from a user that in the latest update buttons like New File and New Folder in the Explorer view are not labeled anymore. Just updated myself and I definitely can confirm that with JAWS 2022.
If you go to the Explorer view (Ctrl+Shift+E) and tab through the buttons, you'll hear just "button button" instead of the correct labels.
That does break accessibility in quite a severe way. CC @isidorn

I will add.

It's hardly a matter of labels. NVDA buttons reads correctly. Problem when working with JAWS 2021, 2022.
Buttons in all panels are not readable. For example, the same is observed with the "Structure" section and in general in all sections that are displayed in my interface.
I apologize for the google translation. I don't write in English :-(

Thanks @velimudrvelimudr! Really had no time for a good thorough testing, I must travel today. Anyway @isidorn it's a VS Code problem as it was totally OK in the previous version.

I can confirm this problem with March 2022 update. I use JAWS2022, and usualy I develop in docker. The button labels are missing which makes some development processes less smooth.
I must use workarounds, e.g. navigate to the parent folder in explorer, open the context menu and click to new file instead use new file button that label is invisible with the mentioned screen reader.

Thanks for filling this, but it sounds like a duplicate of https://github.com/microsoft/vscode/issues/146658
So let's close this issue and continue the discussion there


Update docs

The reference chapter of the docs does not display right, this is due to this error in pdocs: https://github.com/timothycrosley/pdocs/issues/35
Let's just accept that for now.


#gomobile reverse bindings for iOS "invalid source position: <scratch"

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.5 darwin/amd64
gomobile version +60b0aaa Tue Jan 31 20:25:16 2017 +0000 (android,ios)
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/cmanus/code"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/hg/0q7ssn096673q40j5__9lvr40000gp/T/go-build466990415=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
Ran gomobile bind -target ios
Directory contains single file see gist
https://gist.github.com/cmanus/fbd91968eddaf660db02acfb62d545e3
What did you expect to see?
Sucessful creation of the ios Framework
What did you see instead?
gomobile: Foundation: invalid source position: "<scratch"
mentioning @eliasnaur

@eliasnaur Let me know if there is anything I can do to help with this.  I'm working on getting set up to be a contributor.

I failed to reproduce this. I put the content of your gist into $GOPATH/src/gomobile19086/goreverse.go and ran gomobile bind -target ios from the $GOPATH/src/gomobile19086 directory, which resulted in a Goreverse.framework. I'm running macOS 10.11.6 with Xcode 8.0.
Please try go get -u golang.org/x/mobile/... and then go install golang.org/x/mobile/cmd/... before trying again. If possible, try Go 1.8 as well. Thank you.

Thanks I'll test again but this was reproduced for me on 2 different Macs.
Neither one has been upgraded to Sierra, so I suspect that to be a
variable.
On Feb 21, 2017 11:32 AM, "Elias Naur"<EMAIL_ADDRESS>wrote:

I failed to reproduce this. I put the content of your gist into
$GOPATH/src/gomobile19086/goreverse.go and ran gomobile bind -target ios
from the $GOPATH/src/gomobile19086 directory, which resulted in a
Goreverse.framework. I'm running macOS 10.11.6 with Xcode 8.0.
Please try go get -u golang.org/x/mobile/... and then go install
golang.org/x/mobile/cmd/... before trying again. If possible, try Go 1.8
as well. Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/19086#issuecomment-281416144, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMTVXVABim6yWNQTZ_q69sDdGFFpB0FEks5rex-OgaJpZM4MA1k6
.

--
The information contained in this message and any attachments is intended only
for the use of the individual or entity to which it is addressed, and may
contain information that is privileged, confidential and exempt from disclosure
under applicable law. If you have received this message in error, you are
prohibited from copying, distributing, or using the information. Please
contact the sender immediately by return e-mail and delete the original
message. ID442

Still occurs after an update to Go version 1.8 on OS X 10.11.5

@eliasnaur After updating to sierra and Xcode 8.2.1 this error is gone.


Call-graph related data structures have been moved.

Minor change required after data structures have been moved.

Depends on https://github.com/fasten-project/fasten/pull/354

While I have fixed all compilation issues in the latest commit, the MojoTest.testSecurity test does no longer pass. I have disabled the test and can then successfully build the plugin and and run it on the "Guava" test project that you have provided me with, but unfortunately,  the "Guava" build does not report any kind of vulnerability related problem.
Does the test rely on vulnerability information in the KB? If so, the problem is likely the DB reset... it would be wise to refactor the test to run independent of the KB and with local information. While this does not help with the Guava project not being fit for presentation, it helps to make the test suite self-contained.
@ashkboos could you double check that I have adopted the classes correctly?
@tmortagne I have added TODOs to all places where I felt like you should have a second look. :)

Does the test rely on vulnerability information in the KB?

Yes.

If so, the problem is likely the DB reset..

Is that recent ? The module I sent you was still failing because of a vulnerability on Monday.

it would be wise to refactor the test to run independent of the KB and with local information

I definitely agree with you on the long run, but so far this test was more here for me to make sure the metadata coming from the actual server was properly understood, since it still changes from time to time. Anyway, better disabling it as you did (even when it works).

Is that recent ? The module I sent you was still failing because of a vulnerability on Monday.

I just retried it and I keep getting the vulnerability error with the version of fasten I indicated. If you only tried with your refactoring this might indicate a regression somewhere, I will debug it.

I just updated the test to do the same as the module I sent you and it fail as expected so you should be good to go with Guava in theory (unless your don't have access to https://api.fasten-project.eu/api/ during your presentation ?).


change the atom.sh script to launch the local build

The atom.sh script (which gets copied to the out/ directory during the build process) seems to be looking in common system-wide locations for an installed Atom version before looking for a local binary, which makes it impossible to use the script to run the locally built atom from the out/ directory.
According to @50Wliu, the batch file on Windows is set up differently and always runs the relative Atom binary. It would be nice if the atom.sh script did the same.

Same answer as last time.

I don't really care anymore.


refactor: switch to biome for formatting

refactor: switch to biome for formatting
chore: remove eslint

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#189  👈
#187
#186
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite


Card element payment issues on android

Describe the bug
When using the "stripe-react-native-example" application (https://snack.expo.dev/@charliecruzan/stripe-react-native-example) on android, the WebhookPayment (Card element only) payment does not work. After I enter an email address, the credit card information, and press pay, I get an error with the following information:
"You must provide cardDetails, token or paymentMethodId"
Entering the same information on an iPhone 8 Plus works fine and the payment is successful
To Reproduce
Steps to reproduce the behavior:

Open the application in the expo go app
Select "Accept a payment"
Open "Card element only"
Enter an email address, the credit card information e.g. (4242 4242 4242 4242, 08/25, 555)
Press pay

Expected behavior
I would expect the payment to succeed, without any errors
Smartphone (please complete the following information):

Device: Samsung S8
OS: Android 9

That example uses "@stripe/stripe-react-native": "0.1.1", have you tried a newer version?

Hey @charliecruzan-stripe,
thanks, I missed checking the version, as it was mentioned in the expo documentation I didn't check the version. A newer version is working fine on android as well. Therefore I'm closing this issue.


[Feature Request] Return the id of topK matches of a given query

Hi @veralauee, I'm thinking about checking the best matches suggested by the provided retriever, is there a way for me to access the retrieval results of a given query instead of just getting the topK recall? I think such a feature would be helpful for me to analysis the visual and semantic consistency of the query and topK suggestions, and provide useful guidance to the design of embedding extractor and similarity metric.
Much appreciated!

Basically we compare the features of two clothes and decide whether they match or not. Thus, if you'd like access the features as the retrieval results, you can save the embeddings of query and gallery.
Please modify mmfashion/apis/test_retriever.py as follows:
`def _non_dist_test(model, query_set, gallery_set, cfg, validate=False):
model = MMDataParallel(model, device_ids=cfg.gpus.test).cuda()
model.eval()

query_embeds = _process_embeds(query_set, model, cfg)
gallery_embeds = _process_embeds(gallery_set, model, cfg)

query_embeds_np = np.array(query_embeds)
gallery_embeds_np = np.array(gallery_embeds)

**# save embeddings
np.save('query_embeds.npy', query_embeds_np)
np.save('gallery_embeds.npy', gallery_embeds_np)**

e = Evaluator(
    cfg.data.query.id_file,
    cfg.data.gallery.id_file,
    extract_feature=cfg.extract_feature)
e.evaluate(query_embeds_np, gallery_embeds_np)`

@veralauee Thanks for the help. By the way, is the order of the embedding identical to the order in query list (and gallery list)?


add merge node

refactor interfaces to common pkg
add query plan, define plan nodes
implement resultMerge logic

Codecov Report

Merging #197 into master will decrease coverage by 0.55%.
The diff coverage is 50.32%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   74.56%   74.01%   -0.56%
==========================================
  Files         137      143       +6
  Lines       18909    19125     +216
==========================================
+ Hits        14100    14155      +55
- Misses       3769     3926     +157
- Partials     1040     1044       +4

Impacted Files
Coverage Δ

query/aql.go
100% <ø> (ø)
:arrow_up:

broker/handler.go
0% <0%> (ø)

broker/schema_manager.go
0% <0%> (ø)

broker/query_plan.go
0% <0%> (ø)

broker/executor.go
0% <0%> (ø)

query/aql_compiler.go
76% <100%> (ø)
:arrow_up:

broker/result_merge.go
90% <90%> (ø)

memstore/backfill_manager.go
87.12% <0%> (-4.96%)
:arrow_down:

memstore/cuckoo_index.go
90.26% <0%> (-1.01%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a944a...ea18385. Read the comment docs.


t-sne

帅哥，你好，能请教一下t-sne的代码？具体如何使用？十分感谢，感激涕零！

I already left NTU, so the t-sne codes have been wiped out.
You could use open-sourced t-sne implementations.


WebSocket connection is broken.

Recently, it appears an update has broken my config of the reverse proxy I use to access the web socket for the config UI – it looks as though there is a security issue although the WebSocket issue is at the same URL as the page.
Any ideas?
Refused to connect to wss://[redacted]/wsocket?token=[redacted] because it does not appear in the connect-src directive of the Content Security Policy.

Hi,
You'll need to proxy the Host header.
UseCanonicalName on
ProxyPreserveHost on

https://github.com/oznu/homebridge-config-ui-x/wiki/Reverse-Proxy:-Apache

I've added a proxyHost config option to make running behind a reverse proxy easier, and allow the UI to still work in cases where the reverse proxy cannot set the real host header.
"platforms": [
    {
      "platform": "config",
      "name": "Config",
      "port": 8080,
      "proxyHost": "my-domain.com:5000"
    }
]

proxyHost should match the domain shown in the browser, including a custom port if not using 80 or 443.

I might have a similar problem. I have a URL pointing to my server with an nginx reverse proxy. If I load homebridge-config-ui-x directly on my server using localhost:8151, everything works as expected. If I load it over the domain, homebridge-config-ui-x still loads, but cannot access HomeBridge:

The console shows this error too:
WebSocket connection to 'ws://[redacted]/wsocket?token=[redacted]' failed: Error during WebSocket handshake: Unexpected response code: 200

@randybruder - are you proxying the web socket in your nginx vhost config block?
  location / {
    proxy_pass                  http://<IP_ADDRESS>:8080; # replace 8080 with the port the ui is running on
    proxy_http_version          1.1;
    proxy_buffering             off;
    proxy_set_header            Host $host;
    proxy_set_header            Upgrade $http_upgrade;
    proxy_set_header            Connection "Upgrade";
    proxy_set_header            X-Real-IP $remote_addr;
    proxy_set_header            X-Forward-For $proxy_add_x_forwarded_for;
  }

All I had was:
location / {
	proxy_pass http://localhost:8151;
}

So obviously I was missing your fancy extra lines (sorry, I'm really new to nginx.) I added all the additional lines, rebooted nginx, and it's all working as expected.
Thank you so much for your help! I appreciate it.


#SPARK-2808 update kafka to version 0.8.2

https://issues.apache.org/jira/browse/SPARK-2808 update kafka to version 0.8.2. Kafka 0.8.2 is in beta still.

Waiting for kafka 0.8.2 to move to GA, still beta

Kafka 0.8.2 is now listed as latest stable.

Aah cool. However 0.8.1 and 0.8.2 have pretty big changes between them, so lets merge this for the next release. We are already doing a lot of experimental Kafka stuff in this release (feature merge window has closed).

@tdas what shall I do with this PR to complete it then?

The first step would be to see whether upgrading to 0.8.2 passes the
inbuilt unit-tests or not (including the new Kafka stuff).
In addition, is there are documentation somewhere that talks about the
compatibility of 0.8.2 with 0.8.0 / <IP_ADDRESS> kafka clusters? We can figure
out the path accordingly. In any case, it will be in the next release cycle
(1.4).
On Wed, Feb 4, 2015 at 6:02 AM, Helena Edelson<EMAIL_ADDRESS>wrote:

@tdas https://github.com/tdas what shall I do with this PR to complete
it then?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/3631#issuecomment-72858529.

All streaming-kafka sbt tests and  /dev/run-tests passed in my initial push as beta, and with the GA update all still pass.  Should I resubmit this PR against another branch?
I am getting cluster backwards compat docs..

Jenkins, this is ok to test.

Then for the new API (which does not store offsets externally) may need to be updated to ensure compatibility. I am not sure whether the current unit tests will catch such issues. This will require a bit of manual testing. Will do after 1.3 release rush. :)
Thanks for the link!

Test build #26849 has started for   PR 3631 at commit 2e67c66.

This patch does not merge cleanly.

NP, I think manual may not be necessary, just the addition of tests that automate testing the version or testing all and handling the execution path properly. I can add that when merged.

Test build #26849 has finished for   PR 3631 at commit 2e67c66.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26849/
Test PASSed.

@helena I too would like to update to Kafka 0.8.2 as it does have a number of good improvements. can you rebase? @tdas are you OK with merging this for only master / 1.4.0?

Hi @srowen, will do.

This will need some changes to KafkaCluster and possibly other things related to the new api... let me know if you want a hand.

@koeninger Yes, there consumer offset and some other minor changes to make.
I'm finding it hard to carve out time for this, high ticket load this week. Go for it if you want, otherwise I'll do it later in the week.

@koeninger this is a definite blocker for me, I'm upgrading the connector to scala 2.11 with a cross build. Let me know if you have time, otherwise I will get back to this tomorrow morning.

@helena I updated it, pr is at https://github.com/apache/spark/pull/4537

Great I'll close this.


Enhance Token Data with Cryptofonts API

I noticed you're still relying on own token list for managing token information and logos.
I've been using the Cryptofonts Token Icon API, and it's been a game-changer, offering several benefits.
If you're curious, check it out here: https://cryptofonts.com/api.html

Thank you! We'll check it out.


Provide way of disallowing certain values

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)

Subject

The schema argument is like an allowlist. I'd like a way of disallowing certain things.
Problem

My problem is that I'd like to support custom protocols in  elements in the rendered HTML. I'm using this plugin through remark-html, together with the default github.json schema along with some minor customisations.
In a nutshell:
Input
This is a [custom protocol](acme://deep/link)

Expected

This is a custom protocol

Actual

This is a custom protocol

Solution

I'd like to keep the existing behaviour of disallowing malicious javascript: prefixes in the href attribute.
But at the same time allowing all other protocols.

Essentially:
{
   "protocols": {
      "href": {
        "allow": "**,
        "disallow": "javascript:"
      }
   }
}

Currently, it's not impossible to specify allows/disallows at the same time in this plugin.
Alternatives

But at the same time allowing all other protocols.

And that’s the insecure part. E.g., data: URIs are also insecure. And so many others.
By definition, disallowing certain stuff is unsafe.
So you shouldn’t do it. On the other hand, passing an empty array is as allowing everything, currently.

Thanks for the quick reply. We'll have a think about what route to take here. We'd like to be safe, but at the same time allow custom protocols from the user.
I totally get that you want to have this library not allowing unsafe strategies. We can close this if you fundamentally disagree with my use case.
(This issue perhaps should've been a question, sorry about that.)


Add story data to nlu and e2e actions to domain

Proposed changes:

add E2EImporter which

adds actions and intents to the NLU training data
adds e2e actions to the domain

add field e2e_text to ActionExecuted so that we can distinguish between regular actions and end-to-end actions
this implements steps 1 and 5 of the e2e implementation proposal

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

will merge despite the failing tests as these are caused by the base branch. Happy to fix anything which comes up (it's a bit hard to see at the moment, if I destroyed anything else)


Add an option section to API reference page

Closes #406
WIP

I think we should include a CORS subsection here. There used to be one in a past version: https://postgrest.org/en/v3.2/api_reading.html#cors.
(@laurenceisla you could just copy that)
I'd say this should go first in the OPTIONS section, we've had some questions about this before.


Re-export prelude of / whole crate avr-hal-generic in mcu/*-hal crates

Why ?
Currently, when working with the crates of this repository, doing anything more than a blinky requires adding a bunch of dependencies that are already present in the upstream crates, just hidden.
For example, in a very basic app that uses only the serial and logs panics to it, I need all of these:
[dependencies]
# For interrupt::disable
avr-device = { version = "0.3", features = ["atmega1284p"] }
# For the uart hal
atmega-hal = { git = "https://github.com/icanwalkonwater/avr-hal.git", features = ["rt", "atmega1284p"] }
# For its prelude (uWrite + void)
avr-hal-generic = { git = "https://github.com/icanwalkonwater/avr-hal.git" }
# For uwriteln!
ufmt = "0.2"

Each one of these crates is already in the dependency tree of atmega-hal and is thus prone to version conflicts. The goal of this issue is to propose a solution for this.
Reexport avr-hal-generic's prelude
The prelude of avr-hal-generic currently reexports traits from embedded-hal, ufmt and void, which are compiled either way and are useful to have in downstream crates.
The proposal is to create a prelude for the mcu/*-hal which reexports avr-hal-generic::prelude::*.
Something like
// mcu/atmega-hal/src/lib.rs

pub mod prelude {
    pub use avr-hal-generic::prelude::*;
}

And maybe the same things in further downstream crates like arduino-hal.
This will also prevent version conflicts related issues as well. #303 #282
Reexport avr-hal-generic
In addition to that, reexporting the whole avr-hal-generic crates will be great, this was discarded as useless #98 but I'd argue that this is a similar case to the pac reexport in mcu crates and the hal one in arduino-hal, it allows users to drop down a level (or up in this case) and get access to all the traits and reexports of this crate to write more generic code.
This is similar to what they do on the stm32-rs project, for example in stm32f3xx-hal, the nb crate traits are implemented a bit everywhere and reexported at the root.

I want this too in arduino_hal.
Yesterday I wrote a struct for handling a seven segment led. This element is used to display a single digit and has segments named A through G. With arduino_hal it looks a little something like this
struct SevenSegmentLed<A, B, C, D, E, F, G>
where
    A: PinOps,
    // Shortened for brevity.
{
    segment_a: Pin<Output, A>,
    // Shortened for brevity.
}

The problem is, that the Trait bound PinOps can only be found in avr-hal-generic.

Reexport avr-hal-generic's prelude

:+1: from me. I'm actually surprised this isn't the case already...  It probably got lost at some point during the refactoring.

Reexport avr-hal-generic

Hm, I'd rather see the pieces from avr-hal-generic re-exported in the appropriate locations.  To some degree, this is already happening: For example in the adc module or in the i2c module:
https://github.com/Rahix/avr-hal/blob/eeef51bde41ab1a5ca846229e77c981d68897f5a/mcu/atmega-hal/src/adc.rs#L4
https://github.com/Rahix/avr-hal/blob/eeef51bde41ab1a5ca846229e77c981d68897f5a/mcu/atmega-hal/src/i2c.rs#L3
I think it is more sensible to add the missing re-exports in this way than to expose the entire avr-hal-generic crate's structure to the outside.  It will make downstream code much more ugly if they have to pull in imports from all over the place rather than a single import for all i2c related items, for example.
From a quick glance, it does seem that these re-exports are missing in places, though.  To begin, PinOps isn't re-exported in the port module in either atmega-hal nor the BSP arduino-hal crate.  I think the end-goal should be having all items from avr-hal-generic re-exported somewhere appropriate in the HAL crates.

I think it is more sensible to add the missing re-exports in this way than to expose the entire avr-hal-generic crate's structure to the outside.

I agree, seems like more work but if well done would be the better solution.

I started with fixing the prelude and PinOps in #350.  If you stumble over any other missing re-exports, please either report them here or, even better, send a PR :)

I think this is all solved now, if not, let me know!


Sk/uploader pw change

@kentquirk
This PR changes the password reset link for Blip which will take a logged in user to their account password to update their password, while taking logged-out users to the password reset request.
I didn't have a great way to test this in my local dev environment, so we'll need to do some testing on devel to ensure this is all working as designed.
Resolves: https://trello.com/c/ilkdLJKh

LGTM. Checked to make sure it agrees with blip, and it does, so I'm merging.


Improve DOM Event serialization

While working on https://github.com/phetsims/phet-io/issues/995, https://github.com/phetsims/phet-io/issues/1693 and especially https://github.com/phetsims/phet-io/issues/1720, @jessegreenberg, @samreid and I found that Input.deserializeDOMEvent wasn't supporting a field, relativeTarget, that was needed to support PhET-iO playback for Input.js
This issue is to try to improve on the serialization strategy of our DOMEvents. Right now there are a couple of problems:

Silent fallback into default/falsey values if we aren't opting into setting a particular property.
deserialization generally creates a window.Event, which doesn't necessarily support subtypes that may have usages of specific subtype API. Like for KeyboardEvent when adding a listener to keydown.

We thought that it may be nice to formalize the Event that we create in deserializeDOMEvent. We could make this a Proxy, such that if we access something that isn't in the white-list, it can fail loudly and we can catch it early.
The above solution will still only support us as long as we exercise behavior with PhET-iO playback enabled. As an extra step we could wrap all domEvents coming into scenery input with the same Proxy algorithm. Thus we will know immediately, in any brand, when we hit a case that PhET-iO playback wouldn't support. This could help build out our coverage.

[ ] Another thing to do for this issue. I think we should serialize Event.target back into an HTML element, and not into an object literal like it is now (which is what I did for relativeTarget in https://github.com/phetsims/phet-io/issues/1720). This is what it looks like now:

  if ( key === 'target' ) {
          domEvent[ TARGET_SUBSTITUTE_KEY ] = eventObject[ key ];
        }

Even without Proxy, I think that the Event constructor could take much with options instead of trying to mutate after construction.


WIP: Plot rework for the interaction-graph-plot

Adapts the interaction_graph plot to the click CLI.
Merges with the f-PlotRework branch.

Currently untested due to an error in the generation of CommitReport reports:
...benchbuild/environments/entrypoints/cli.py", line 15, in <module> rich.traceback.install() AttributeError: module 'rich' has no attribute 'traceback'


how to return a List after Pick some from Gallery?

Hi!
How to return a List after Pick some from Gallery?
Thank you!

Not sure what you are asking, please fill out a full report.

I mean picker 2 or 3 image from Gallery in 1 time and show it in a ListView


tangara-cli: init at 0.4.3

tangara-cli is a command-line tool for flashing firmware for a Tangara music player.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Additional info/questions

This is my first new package, please do not hesitate to offer feedback if I have made any mistakes or if things could be done better
PR is based on the work done in #365308, so any changes done here should probably reflect there, and vice-versa
Based on comments on that PR, this was made into a separate package, but if they are better suited to be packaged together, that's totally fine
This package requires access to the serial port to flash firmware, which I believe is done by adding the user to the dialout group. Based on grepping around the nixpkgs repo, my hunch is that the solution for this is "this is the user's problem, not the responsibility of the package", but if there's a way to communicate that (via comment in the package or some other thing) or some other precedent for this, I can include that.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367227

x86_64-linux

:white_check_mark: 1 package built:

tangara-cli

Shame it needs all the deps to build.

Shame it needs all the deps to build.

Yeah, I'm not sure if that's a byproduct of how the project is constructed or if the command I'm using is building more than just the executable.

Thanks for doing this @stevestreza! I don't mind either way about being added as a maintainer - though I guess it makes approving version updates easier.


Bot can't connect on one server on discord.

This has been an ongoing issue with discords voice servers, change your server region to fix it, is the best we have for a fix so far.


Implement data collection node

Description

Resolves #46

Verification

[x] Manually tested by launching the boat simulator with data collection enabled.

@eomielan I added some comments and some logic to store output data in a fixed location. Can you take a look and let me know what you think?
I will approve this PR once the requested changes in https://github.com/UBCSailbot/sailbot_workspace/pull/222 are addressed.

@eomielan I added some comments and some logic to store output data in a fixed location. Can you take a look and let me know what you think?
I will approve this PR once the requested changes in https://github.com/UBCSailbot/sailbot_workspace/pull/222 are addressed.


RISCV: rework and cleanup interrupt controllers support

The RISCV code regarding the interrupt controllers is messy and confusing and it is currently almost impossible to add new interrupt controller drivers for RISCV without spaghettifying the code even more.
There are several problems:

We have a RISCV_HAS_PLIC symbol for platform supporting PLIC but there is no RISCV_HAS_CLIC symbol for CLIC support
We have instead a HAS_NUCLEI_ECLIC for no reason whatsoever
There is no standard interface for PLIC or CLIC drivers
The arch code is directly calling a specific driver code without any wrapper or interface
There is no possibility to add new PLIC or CLIC drivers without directly modifying the arch code and its ifdef madness
The arch code is assuming that the only CLIC driver is the Nuclei one

This PR is trying to cleanup a bit the mess.

@fkokosinski @kgugala can you take a look please?


Update PULL_REQUEST_TEMPLATE.md

Objective
Explain in non-technical terms WHY this PR is required.
E.g.: What feature it adds, what problem it solves...
This section will be used in the release notes.
Related information:
Related issue(s): #< GitHub ticket number > (optional)
Description of change
A general description of WHAT changed in the codebase, but short of an English version of the diff. Assume that people reading this will also be looking at the output of git diff and guide them to the highlights.
Additionally add the reasoning for change details if they're complex or abstract.
How Has This Been Tested
Specify where and how you tested this and what further testing it might need.

Types of changes

[x] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional Notes
Any further information that you would like to add.

Yyee


WIP: arte config api v2

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[ ] Searched the bugtracker for similar pull requests
[ ] Read adding new extractor tutorial
[ ] Read youtube-dl coding conventions and adjusted the code to meet them
[ ] Covered the code with tests (note that PRs without tests will be REJECTED)
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

I hope you don't mind. I've updated this from a working WIP extractor bac-ported from yt-dlp.

I hope you don't mind. I've updated this from a working WIP extractor bac-ported from yt-dlp.

Not at all, go ahead. I forgot this even exists.
Thx for finishing it.

Great, thanks.
I see that somehow the yt-dlp code didn't need to get the Bearer token, which makes things easier.


Apache 2.0 License or a License of some kind.

Is your feature request related to a problem? Please describe.
Currently this repo does not have license. I'd like to recommend Apache 2.0 License. This idea came about when writing readme, usually license is the footer of such documentation and knowing the license status is better than not. If no License than License should be UnLicensed.
Describe the solution you'd like
When I land on the repo, I want to understand what the License is by discovering the License document in the code or reference in the Readme.
Describe alternatives you've considered
If no License than repo should state Unlicensed.

agreed. maybe a new ticket that is pristine this repo, will get us Pristine which gets us Apache 2 license and contributor files, all that stuff.

I just made this one on the docs-react repo: https://github.com/open-rpc/docs-react/issues/13