Downstream test: temporarily exclude escope

Its tests are falling apart for no particular reason.

Codecov Report

Merging #1771 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1771   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files           1       1
  Lines        4032    4032
  Branches      712     712
======================================
  Hits         4032    4032

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106e289...bdf8da4. Read the comment docs.

:+1:
Mike Sherov

On Feb 27, 2017, at 12:20 AM, Codecov<EMAIL_ADDRESS>wrote:
Codecov Report
Merging #1771 into master will not change coverage.
The diff coverage is n/a.
@@          Coverage Diff           @@
master   #1771   +/-
======================================
Coverage     100%    100%
Files           1       1
Lines        4032    4032
Branches      712     712
Hits         4032    4032
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106e289...bdf8da4. Read the comment docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ariya You should report the issues you're having with escope.

@ariya You should report the issues you're having with escope.

Of course, I'm still investigating where the problem lies.


[Patch] update distillery to 1.5

Coverage remained the same at 89.268% when pulling 10ec46587a106a88539de98663ade32dfb49a32f on update-distillery into a1eba8808e4303c875f0db3005124e8b432e1f8f on master.

Changes Unknown when pulling 57ee08161438215fb1aee44b27ea7b1495506438 on update-distillery into ** on master**.


Error: Performance.mark is not a function

Hi,
What am I doing?
I'm trying to migrate from react 15 to react 16, consequently migrate from enzyme v2.x to v3.x. I have about 500 unit tests in which I use enzyme to mount my component. I followed Migration Guide and faced this error in over 100 tests:
The error I hit:
FAILED TESTS:
  MyComponent
    ✖ title of my test
      HeadlessChrome 0.0.0 (Mac OS X 10.13.0)
    TypeError: performance.mark is not a function
        at beginMark (webpack:///node_modules/react-dom/cjs/react-dom.development.js:7406:0 <- src/tests.js:93987:17)
        at startWorkLoopTimer (webpack:///node_modules/react-dom/cjs/react-dom.development.js:7618:0 <- src/tests.js:94199:7)
        at performWork (webpack:///node_modules/react-dom/cjs/react-dom.development.js:12787:0 <- src/tests.js:99368:7)
        at batchedUpdates (webpack:///node_modules/react-dom/cjs/react-dom.development.js:13244:0 <- src/tests.js:99825:9)
        at performFiberBatchedUpdates (webpack:///node_modules/react-dom/cjs/react-dom.development.js:1646:0 <- src/tests.js:88227:10)
        at stackBatchedUpdates (webpack:///node_modules/react-dom/cjs/react-dom.development.js:1637:0 <- src/tests.js:88218:10)
        at batchedUpdates (webpack:///node_modules/react-dom/cjs/react-dom.development.js:1651:0 <- src/tests.js:88232:10)
        at Object.batchedUpdatesWithControlledComponents [as unstable_batchedUpdates] (webpack:///node_modules/react-dom/cjs/react-dom.development.js:1664:0 <- src/tests.js:88245:12)
        at webpack:///node_modules/react-dom/cjs/react-dom-test-utils.development.js:1216:0 <- src/tests.js:189114:14
        at Object.simulateEvent (webpack:///node_modules/enzyme-adapter-react-16/build/ReactSixteenAdapter.js:250:0 <- src/tests.js:184077:15)

I've tried to fix the issue reducing the number of tests I run every time, it doesn't seem to help.
Application specs:
react: 16.0.0
react-dom: 16.0.0
Enzyme: 3.1.0
react-test-renderer: 16.0.0
Any help would be appreciated.

I would recommend not migrating two things at once. Get react 15 and enzyme 3 working first; then upgrade to react 16.

@ljharb We've migrated react first, application is working without any issues. the migration was smooth and easy.

Right, but if you don't have enzyme 3 passing on react 15 first, then we can't know if it's react 16 breaking things (which might be expected), or if it's enzyme 3 breaking things.

Unit tests passing are much more important than e2e tests anyways.

I'm subscribing to this thread as having the similar issue. I haven't figured out how such error is even possible given the defensive check React is using: https://github.com/facebook/react/blob/v16.0.0/src/renderers/shared/fiber/ReactDebugFiberPerf.js#L42.

Ok, I have found the root cause. It's coming from the usage of useFakeTimers from 'sinon'.

I think that we can close this issue. Here is another one: https://github.com/sinonjs/lolex/issues/136.

@reyraa are you also using sinon and useFakeTimers?

@ljharb Yes we're using fake timers in multiple tests


[Storage] Added empty and null checks for storage client names

Resolves https://github.com/Azure/azure-sdk-for-net/issues/31955

API change check
API changes are not detected in this pull request.


[5.7] Update metadata mixin to expose pageURL computed property and allow overriding it

Rationale: Updates API of metadata mixin to be more flexible and allow overriding the page URL
Risk: Low
Risk Detail: Small, additional JS API introduced
Reward: High
Reward Details: Allows for overriding of URL metadata
Original PR: https://github.com/apple/swift-docc-render/pull/379
Issue: rdar://94575097
Code Reviewed By: @dobromir-hristov, @marinaaisa
Testing Details: Updated unit tests, manually inspected <meta> tags of rendered output to verify no regressions are introduced with example content

@swift-ci test


Codable conformance added to some CG types

This PR mirrors some changes from https://github.com/apple/swift/pull/10404

Added conformances + unit tests for

CGPoint
CGSize
CGRect

Not mirrored from https://github.com/apple/swift/pull/10404

CGVector 📝
CGAffineTransform 📝

📝 I've stumbled across this, which leads me to believe that CGVector is not supposed to be implemented in swift-corelibs-foundation.
I suppose same goes for CGAffineTransform, since we already have AffineTransform/NSAffineTransform implemented.

@swift-ci Please test


Add meshery to landscape

Signed-off-by: Aisuko<EMAIL_ADDRESS>Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
x ] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

 Please use a pure svg file
No cached entry, and Meshery has issues with twitter: https://twitter.com/, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}

Deploy preview for landscape failed.

Detailed rules: https://github.com/cncf/landscape#logos

Oh, sorry about that. I think what its saying is “If you have an all-white logo, use a transparent background”. I will change to the white background

@dankohn Please kindly check the logo.Thanks a lot.

Build failed because of:
https://github.com/layer5io/meshery/ does not look like a github repo
https://github.com/layer5io/meshery/ does not look like a github repo

@dankohn Please kindly check the logo.Thanks a lot.

@Aisuko Trailing slash is there in URL.

Done

LGTM

Looking good, gents. Thank you.

@dankohn Sorry to bother you, sir. Please take a look at the PR.  I believe it was ready to be merge.

@dankohn If I can be of assistance on this PR, please task me. A version of the Meshery logo with transparent background has been supplied now. I think we're good to go here.

Apologies for the delay.


Add Validation + Checks to markdown PRs

We need to create a github action that does validation on the markdown files when we PR them. This way we can merge with confidence.
I've done this in the past with my uses.tech site: https://github.com/wesbos/awesome-uses/blob/master/.github/workflows/data-validate.yml
So, things that should be checked:

Publish date is in the future
mp3 url is valid (Fetch with HEAD to ensure file exists)
Show number is not overlapping with any existing shows
All links in markdown resolve 200 OK
Perhaps some sort of spellcheck?
Youtube url is a real youtube url (we had them mixed up once)
all timestamp links adhere to HH:MM:SS or HH:MM

Just trying to think of others

Is this something you are working on or just documenting.

Just documenting, feel free tot take it on ! Github actions are pain. Worth checking out https://github.com/nektos/act

A few more from this morning's scramble:

If a file is committed to the shows folder, it should have a .md extension
Any URLs should resolve  - we had some file://Users/.... paths from copy + pasting markdown from VS code
The markdown should parse and be valid - we had an extra --- added to the frontmatter
Youtube links should be full youtube.com links and not youtu.be - not sure if this is a big deal or not, just thought I'd mention it. I feel like linking straight to the video is better than a shortlink - probably some SEO juice there.

Making these into a todo list

[ ] mp3 url is valid (Fetch with HEAD to ensure file exists)

[ ] Show number is not overlapping with any existing shows

[ ] All links in markdown resolve 200 OK

[ ] Perhaps some sort of spellcheck?

[ ] Youtube url is a real youtube url (we had them mixed up once)

[ ] all timestamp links adhere to HH:MM:SS or HH:MM

[ ] If a file is committed to the shows folder, it should have a .md extension

[ ] Any URLs should resolve - we had some file://Users/.... paths from copy + pasting markdown from VS code

[ ] The markdown should parse and be valid - we had an extra --- added to the frontmatter

[ ] Youtube links should be full youtube.com links and not youtu.be

Going to merge the first 2 of these checks and then add on the others.
Here is the test runs https://github.com/syntaxfm/website/pull/1543

Just merged timestamp validation

Another thing we should add is making sure the mp3 is only 128kbs bitrate, and/or the file size is not over ~70mb. We had released one that was 128mb and it was causing timeouts on the transcript generation.
We already have ffmpeg wasm package installed, so we could check that way, but honestly checking the filesize would be good enough too.

@stolinski This markdown:
* **[32:15](#t=32:15)** Is ChatGPT Plus worth it? I'm trying to avoid death by 1000 subscriptions.
* [Mozilla’s vision for Firefox MV3](https://blog.mozilla.org/addons/2022/11/17/manifest-v3-signing-available-november-21-on-firefox-nightly/

is thinking those numbers in the urls are timestamps

@stolinski  happened again here

Will examine 🤔

I think the regex might be wrong on purpose for testing? https://github.com/syntaxfm/website/blob/main/scripts/merging-show-validation.js#L31
IMO I'd parse the show notes, and then feed it into linkedom, then you can just document.querySelector([href^="#t="]` to get all the correct links instead of regexing everything

Def not wrong on purpose. Just too broad
Scott Tolinski
www.scotttolinski.com ( http://www.scotttolinski.com/ )
On Fri, Mar 1 2024 at 1:59 PM, Wes Bos < @.*** > wrote:

I think the regex might be wrong on purpose for testing? https://github.com/syntaxfm/website/blob/main/scripts/merging-show-validation.js#L31
IMO I'd parse the show notes, and then feed it into linkedom , then you can
just document.querySelector( [href^="#t="]` to get all the correct links
instead of regexing everything
—
Reply to this email directly, view it on GitHub (
https://github.com/syntaxfm/website/issues/1538#issuecomment-1973910268 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAFDNR23Z635AEVNG7P6PZ3YWDT2BAVCNFSM6AAAAABC6NYW52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTHEYTAMRWHA
).
You are receiving this because you were mentioned. Message ID: <syntaxfm/website/issues/1538/1973910268
@ github. com>

That said query selector all is probably the right call because it’s so targeted
Scott Tolinski
www.scotttolinski.com ( http://www.scotttolinski.com/ )
On Fri, Mar 1 2024 at 1:59 PM, Scott Tolinski < @.*** > wrote:

Def not wrong on purpose. Just too broad
Scott Tolinski
www.scotttolinski.com ( http://www.scotttolinski.com/ )
On Fri, Mar 1 2024 at 1:59 PM, Wes Bos < @.*** > wrote:

I think the regex might be wrong on purpose for testing? https://github.com/syntaxfm/website/blob/main/scripts/merging-show-validation.js#L31
IMO I'd parse the show notes, and then feed it into linkedom , then you can
just document.querySelector( [href^="#t="]` to get all the correct links
instead of regexing everything
—
Reply to this email directly, view it on GitHub (
https://github.com/syntaxfm/website/issues/1538#issuecomment-1973910268 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAFDNR23Z635AEVNG7P6PZ3YWDT2BAVCNFSM6AAAAABC6NYW52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTHEYTAMRWHA
).
You are receiving this because you were mentioned. Message ID: <syntaxfm/website/issues/1538/1973910268
@ github. com>

Yeah, plus rendering the markdown will also tell us if the markdown will render on the site. Easy way to detect any issues


How to push source to Scratch org if project code exceeds 50mb limit?

Is your feature request related to a problem? Please describe.
When trying to push an org to salesforce, the 50MB limit is making our lives miserable. Please remove the size limitation and allow developers to be productive. We have to resort to all sorts of workarounds that are not well proven. At the very least, SF should provide and document the workarounds step by step.
What are you trying to do
I was trying to push an org that is about 400MB in size. It has about 40MB of static resources.
Describe the solution you'd like
As a developer, I should be able to call "sfdx force:source:push" and expect to get a 'success' message. SF should handle everything under the hood.
Describe alternatives you've considered
I've considered the solution in this topic (https://github.com/forcedotcom/cli/issues/109), but it still doesn't work for me because my issue isn't just static resources.
Additional context
SalesForce, please consider removing the size limits. It makes developing on your platform a real pain! Please check around and see if any other development platform has this size limitation (specifically, traditional development platforms: .net/java/etc).

Are there any plans to increase 10 000 metadata components limit as well for force:source:push/deploy?


Extend Prefill functionality

Pressing the "Prefill" functionality should override & copy-paste the test card number into the Dropin/component.
This also covers the scenario in the case of clicking on the wrong card while prefilling.

@Kwok-he-Chu This seems to work in the latest version, please verify.

Verified, prefilling works. Closing this issue.


feat: generate InternalFetch signature

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR reworks how our internal API routes are typed. This aims to do more of the work at build time rather than asking typescript to do it. Testing in our fixture showed type-checking speed improvement of up of 45%.
Note: The reason that this is so much faster is that we use function overloads, which means that we do not yet support all the matching patterns that our existing type-only algorithm does. It matches only one result so if you have multiple overlapping patterns, like /api/test/**/thing and /api/test/bob/thing then if you request $fetch('/api/test/${someUnknownString}') then we won't be able to give a union of the two return times as before.
It adds the following type-safety functionalities:

[x] it will throw a type error if you make a request that needs a specific method without an options object with that method defined
[x] it will throw a type error if you make a request that needs specific input types without those values
[x] type error if you make a request that needs specific input types without an options object
[x] when $fetch.create is called with a baseURL, the result is not strongly typed but just a normal external $fetch

Further enhancements needed:

[ ] auto-completion when used with endpoints with typed inputs (this would be very desirable for better DX)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Note: The reason that this is so much faster is that we use function overloads, which means that we do not yet support all the matching patterns that our existing type-only algorithm does. It matches only one result so if you have multiple overlapping patterns, like /api/test/**/thing and /api/test/bob/thing then if you request $fetch('/api/test/${someUnknownString}') then we won't be able to give a union of the two return times as before.

Will this be possible in the future with the function overloading approach?

Will it be possible with the way it is implemented in this PR to augment the OpenAPI documentation #1162?

This PR has been outstanding as a draft for a year now, are there any updates you can share?

This is taking longer than expected because we are working on a better standard ecosystem-wise and better testable solution.
I have created a tracker issue: https://github.com/unjs/nitro/issues/2758
(closing this one mainly for triage, lets keep track via issue)


Audio delay after long time operation

Problem:
When the game is running for a long time (over 24 hours) without loss of power (either in a game or on the title/score screens) the audio starts to delay noticeably (about half a second after 24 hours).
Desired behavior:
The audio is not supposed to delay.
Possible causes:

Fmod software library
Buffering in the Raspbian OS (Alsa?)
Audio DAC

If no cause can be found or the solution is too complicated, an alternative solution would be to reboot the system after the game has not been used for a few hours. This only solves the problem if it is not hardware related.


Search Icon is not coming instead text "Search is coming"

please add Material Icons webfont to your index.html
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
as it is described in the installation guide

@sumitsitesh As I did not get any further response from you, I will close this issue. If you have further issues, let me know.


Add explicit description of fields

From a user perspective, there is a big benefit if a specification
is self-contained and very explicit (even if redundant).
To improve the specification in that direction this patch:

clarifies the value of SYSTEM (opcode field)
adds a description of each field

CC: @ptomsich @ved-rivos


Action macros should support skill substitution feats

In GitLab by @Shandyan on May 26, 2021, 05:29
Feats like Versatile Performer let you Demoralize using Performance instead of Intimidation. This is currently not reflected in the action macros included in the system.

This has been possible from the start.

Can someone explain how you can do this?


use correct act_as for existing groups

Coverage decreased (-0.3%) to 38.61% when pulling 65f324383824fc02f7ba5c42eed7f118c164c5e2 on bug/act-as into 1211f42547d5680944d29eb058f56cc916ceade5 on master.


Sidechain Block Number must be written to state

In order for some pallets to work, we need frame_system::Number to be set to the sidechain block number
in stf_sgx.rs, we should be able to
	pub fn set_layer_two_block_number(ext: &mut State, number: BlockNumber) {
		ext.execute_with(|| {
			let key = storage_value_key("System", "Number");
			sp_io::storage::set(&key, &number.encode());
		})
	}

And call this function upon start of a new sidechain block, before executing tops

same should be done for : block hash and timestamp

Closed by #451


Could not sanitize molecule ending on line 68

Dear mordred users
when i run the following command line:
python -m mordred -t sdf clusters.sdf -o clusters.csv
the error is
[10:58:35] Explicit valence for atom # 11 B, 4, is greater than permitted
[10:58:35] ERROR: Could not sanitize molecule ending on line 68
[10:58:35] ERROR: Explicit valence for atom # 11 B, 4, is greater than permitted
WARNING:root:mol read failure: clusters
The following is the sdf file
clusters
OpenBabel01042310313D
30 33  0  0  1  0  0  0  0  0999 V2000
-1.5093   -3.2766    0.6653 O   0  0  0  0  0  1  0  0  0  0  0  0
-1.2712   -2.1184    0.4200 C   0  0  2  0  0  3  0  0  0  0  0  0
0.0521   -1.6942    0.3007 N   0  0  0  0  0  0  0  0  0  0  0  0
0.4728   -0.4370    0.0305 C   0  0  2  0  0  3  0  0  0  0  0  0
-0.4104    0.5272   -0.1484 N   0  0  1  0  0  0  0  0  0  0  0  0
-1.7723    0.2605   -0.0605 C   0  0  2  0  0  3  0  0  0  0  0  0
-2.7232    1.2681   -0.2460 C   0  0  0  0  0  3  0  0  0  0  0  0
-4.0685    0.9799   -0.1540 C   0  0  0  0  0  3  0  0  0  0  0  0
-4.5139   -0.3091    0.1234 C   0  0  0  0  0  3  0  0  0  0  0  0
-3.5936   -1.3146    0.3094 C   0  0  0  0  0  3  0  0  0  0  0  0
-2.2277   -1.0413    0.2199 C   0  0  2  0  0  3  0  0  0  0  0  0
0.0653    2.0379   -0.4730 B   0  0  0  0  0  0  0  0  0  0  0  0
-0.4754    2.3781   -1.6869 F   0  0  0  0  0  0  0  0  0  0  0  0
-0.4206    2.8370    0.5306 F   0  0  0  0  0  0  0  0  0  0  0  0
1.5032    2.1309   -0.5280 O   0  0  0  0  0  0  0  0  0  0  0  0
2.3278    1.1339   -0.3398 C   0  0  2  0  0  3  0  0  0  0  0  0
3.7066    1.3956   -0.4267 C   0  0  0  0  0  3  0  0  0  0  0  0
4.6246    0.3948   -0.2401 C   0  0  0  0  0  3  0  0  0  0  0  0
4.2009   -0.9055    0.0405 C   0  0  0  0  0  3  0  0  0  0  0  0
2.8612   -1.1854    0.1302 C   0  0  0  0  0  3  0  0  0  0  0  0
1.8909   -0.1819   -0.0558 C   0  0  2  0  0  3  0  0  0  0  0  0
0.7462   -2.4201    0.4344 H   0  0  0  0  0  0  0  0  0  0  0  0
-2.4090    2.2729   -0.4615 H   0  0  0  0  0  0  0  0  0  0  0  0
-4.7852    1.7733   -0.3009 H   0  0  0  0  0  0  0  0  0  0  0  0
-5.5704   -0.5168    0.1918 H   0  0  0  0  0  0  0  0  0  0  0  0
-3.8909   -2.3292    0.5265 H   0  0  0  0  0  0  0  0  0  0  0  0
4.0066    2.4078   -0.6444 H   0  0  0  0  0  0  0  0  0  0  0  0
5.6798    0.6103   -0.3096 H   0  0  0  0  0  0  0  0  0  0  0  0
4.9263   -1.6901    0.1868 H   0  0  0  0  0  0  0  0  0  0  0  0
2.5714   -2.2028    0.3489 H   0  0  0  0  0  0  0  0  0  0  0  0
2  1  1  1  0  0  0
3  2  1  0  0  0  0
3 22  1  0  0  0  0
4  3  1  6  0  0  0
5 12  1  1  0  0  0
5  6  1  0  0  0  0
5  4  1  0  0  0  0
6  7  1  1  0  0  0
6 11  1  0  0  0  0
7  8  1  0  0  0  0
8  9  1  0  0  0  0
9 25  1  0  0  0  0
9 10  1  0  0  0  0
10 26  1  0  0  0  0
11 10  1  1  0  0  0
11  2  1  0  0  0  0
12 14  1  0  0  0  0
13 12  1  0  0  0  0
15 12  1  0  0  0  0
16 15  1  6  0  0  0
16 21  1  0  0  0  0
17 16  1  0  0  0  0
17 18  1  0  0  0  0
18 19  1  0  0  0  0
19 20  1  0  0  0  0
19 29  1  0  0  0  0
20 30  1  0  0  0  0
21  4  1  0  0  0  0
21 20  1  6  0  0  0
23  7  1  0  0  0  0
24  8  1  0  0  0  0
27 17  1  0  0  0  0
28 18  1  0  0  0  0
M  END
$$$$

@xiaoboy185 Boron is valence 3, so your molecule is charged. Can you add the SMILES code for the molecule? Because in the way you posted the SD you posted it is broken.
http://www.cheminfo.org/Chemistry/Cheminformatics/FormatConverter/index.html

Dear tobigithub
Thanks very much for your message.
The smile code for this molecule is O=c1[nH]c2n+B-(F)Oc1ccccc1-2
To generate the descriptor by using this smile code, the results are alright:
mol = Chem.MolFromSmiles('O=c1[nH]c2n+B-(F)Oc1ccccc1-2')
mol=Chem.AddHs(mol)
AllChem.EmbedMolecule(mol,randomSeed=1)
calc = Calculator(descriptors,ignore_3D=True)
df1=calc(mol)
While, I want to optimiaze this structure firstly, and then generate the descriptors
My procedure is as following:
(1) The xyz file of this molecule is obtained by using this smile code via rdkit. (in this step, the charge information is lost)
(2) the structure optimization was carried out by using xtb, then the 3D .xyz structure of this molecule is obtained.
(3) the openbabel is used to convert the above 3D .xyz file to .sdf file
(4) mordred is used to generate descriptors.
In this sdf file, there is no information about the charges on B and N atom. I do not know how to add the charges in the .sdf files.
I am looking forward to your message.
Thanks in advance.

@xiaoboy185 mm, something completely different from the SDF you showed earlier, the SMILES code is not a standard SMILES check here: https://marvinjs-demo.chemaxon.com/latest/demo.html
"O=c1[nH]c2n+B-(F)Oc1ccccc1-2"
Can you just attach the SDF and XYZ as file via drag and drop?

Dear tobigithub
Thanks for you reply.
The smile code with standard form is
[H]c1c([H])c([H])c2c(c1[H])OB-(F)[n+]1c-2n([H])c(=O)c2c([H])c([H])c([H])c([H])c21
The corresponding xyz and sdf files are attached.
Thanks
test.zip

Well, so Boron valence=4 thats ok, but there is also a carbon with valence=3.
Is that where you want to have the negative charge? Or is the whole molecule positively charged, then you need to correct the valence state for the carbon somehow. Anyway, there is a bond missing, you could make the nitrogen positive and add a double bond ([H]N1C(=O)C2=C(C([H])=C([H])C([H])=C2[H])[N+]2=C1C1=C(O[B-]2(F)F)C([H])=C([H])C([H])=C1[H])
I think you have to fix your molecule first and then check again. The question is if the fix is actually the molecule you want or something else. With the proposed charged (not sure of that is feasible) Mordred will calculate. So its not a Mordred issue, i think although maybe it does not cover the specific atom types and valence states for Boron. See attached SDF, upload here: https://mordred.phs.osaka-u.ac.jp/

Fixed molecule mordred:

Once thats done, it will calculate.

fixed sdf
test.xyz
  Mrv2219<PHONE_NUMBER>3D

 30 33  0  0  1  0            999 V2000
   -1.7167   -3.2073    0.3418 O   0  0  0  0  0  0  0  0  0  0  0  0
   -1.3384   -2.0314    0.2074 C   0  0  0  0  0  0  0  0  0  0  0  0
    0.0058   -1.7858    0.1462 N   0  0  0  0  0  0  0  0  0  0  0  0
   -0.4035    0.4999   -0.0851 N   0  3  0  0  0  0  0  0  0  0  0  0
   -1.7408    0.2745   -0.0261 C   0  0  0  0  0  0  0  0  0  0  0  0
   -2.6572    1.3022   -0.1107 C   0  0  0  0  0  0  0  0  0  0  0  0
   -4.0105    1.0569   -0.0491 C   0  0  0  0  0  0  0  0  0  0  0  0
   -4.5221   -0.2072    0.0981 C   0  0  0  0  0  0  0  0  0  0  0  0
   -3.6128   -1.2376    0.1832 C   0  0  0  0  0  0  0  0  0  0  0  0
   -2.2414   -0.9986    0.1218 C   0  0  0  0  0  0  0  0  0  0  0  0
    0.0417    1.9307   -0.2497 B   0  5  1  0  0  0  0  0  0  0  0  0
   -0.9506    3.1727   -1.4915 F   0  0  0  0  0  0  0  0  0  0  0  0
    0.4422    3.1659    0.8914 F   0  0  0  0  0  0  0  0  0  0  0  0
    1.5210    2.0762   -0.2994 O   0  0  0  0  0  0  0  0  0  0  0  0
    2.3843    1.0225   -0.2106 C   0  0  0  0  0  0  0  0  0  0  0  0
    3.7485    1.2891   -0.2734 C   0  0  0  0  0  0  0  0  0  0  0  0
    4.6508    0.2537   -0.1875 C   0  0  0  0  0  0  0  0  0  0  0  0
    4.1704   -1.0309   -0.0403 C   0  0  0  0  0  0  0  0  0  0  0  0
    2.7913   -1.2908    0.0221 C   0  0  0  0  0  0  0  0  0  0  0  0
    1.9006   -0.2586   -0.0637 C   0  0  0  0  0  0  0  0  0  0  0  0
    0.6672   -2.5465    0.2094 H   0  0  0  0  0  0  0  0  0  0  0  0
   -2.3054    2.3271   -0.2284 H   0  0  0  0  0  0  0  0  0  0  0  0
   -4.7033    1.8955   -0.1196 H   0  0  0  0  0  0  0  0  0  0  0  0
   -5.5967   -0.3839    0.1451 H   0  0  0  0  0  0  0  0  0  0  0  0
   -3.9835   -2.2559    0.3007 H   0  0  0  0  0  0  0  0  0  0  0  0
    4.1108    2.3105   -0.3900 H   0  0  0  0  0  0  0  0  0  0  0  0
    5.7225    0.4468   -0.2350 H   0  0  0  0  0  0  0  0  0  0  0  0
    4.8877   -1.8488    0.0274 H   0  0  0  0  0  0  0  0  0  0  0  0
    2.4081   -2.3046    0.1384 H   0  0  0  0  0  0  0  0  0  0  0  0
    0.6270   -0.6445   -0.0851 C   0  0  0  0  0  0  0  0  0  0  0  0
  2  1  2  0  0  0  0
  3  2  1  0  0  0  0
  4  5  1  0  0  0  0
  5 10  2  0  0  0  0
  6  7  2  0  0  0  0
  6  5  1  0  0  0  0
  7  8  1  0  0  0  0
  8  9  2  0  0  0  0
 10  9  1  0  0  0  0
 10  2  1  0  0  0  0
 11  4  1  0  0  0  0
 11 13  1  0  0  0  0
 12 11  1  0  0  0  0
 14 11  1  0  0  0  0
 14 15  1  0  0  0  0
 15 20  2  0  0  0  0
 16 15  1  0  0  0  0
 16 17  2  0  0  0  0
 17 18  1  0  0  0  0
 18 19  2  0  0  0  0
 20 19  1  0  0  0  0
  3 21  1  0  0  0  0
  6 22  1  0  0  0  0
  7 23  1  0  0  0  0
  8 24  1  0  0  0  0
  9 25  1  0  0  0  0
 16 26  1  0  0  0  0
 17 27  1  0  0  0  0
 18 28  1  0  0  0  0
 19 29  1  0  0  0  0
  4 30  2  0  0  0  0
 20 30  1  0  0  0  0
  3 30  1  0  0  0  0
M  CHG  2   4   1  11  -1
M  END
$$$$

fixed.zip

@tobigithub Thanks very much, the above fixed sdf is exactly what i want.
Actually, i am dealing with many many such kind of molecules.
Now, I have obtained their 3D .xyz files, it there any convenient method to covert the .xyz file to the above fixed .sdf file?
Thanks

Chemaxon standardizer
https://docs.chemaxon.com/display/docs/standardizer.md

@tobigithub Thank you very much!


Nagios

So, this looks like a Nagios-like monitoring system...am I right?  Pretty great stuff!
Just curious what your roadmap is, if you have this running production anywhere, etc.
Obviously it's a pretty rudimentary toolkit at this point, but with enough stock plugins and probes and so on, this could be really awesome because of Go's easy cross-platform and deployment features.
:)

Hi, thank you for questions!
Yes, goma is a tool like nagios, yet it is quite clean and portable thanks to Go.
We are deploying goma on all hosts (1000+) in our data center.  Just FYI,
we are behind https://www.kintone.com/, a cloud service for business users.
Our primary use-case is to bundle miscellaneous in-house monitoring
tools into this one.  We plan to add built-in security features shortly to ease
deployments.  We will also add plugins on our demands, or course.
I'd like to hear from community what features should goma implement.


chore,refactor(egen): formats and edits notebooks/official/training/tpuv5e_llama2_pytorch_finetuning_and_serving.ipynb notebook

following are the changes as part of the PR:

Removes boilerplate
renames REGION to LOCATION
Edits according to template

REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[ ] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

[ ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

[ ] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
[ ] The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

Rectified issue. Please re run to check. Thanks

/gcbrun

the check is failing with an error: "Training is not complete and is in state JOB_STATE_FAILED". Not sure of the reason for the pipeline to fail as we do not have access to the pipeline logs as it is run in a different project.


Analyse number of epochs for DIET

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

/modeltest
dataset_branch: "banking77_tests"
include:
 - dataset: ["Private 3"]
   config: ["BERT + DIET(bow) + ResponseSelector(bow)", "BERT + DIET(seq) + ResponseSelector(t2t)", "Sparse + BERT + DIET(bow) + ResponseSelector(bow)", "Sparse + BERT + DIET(seq) + ResponseSelector(t2t)", "Sparse + DIET(bow) + ResponseSelector(bow)", "Sparse + DIET(seq) + ResponseSelector(t2t)"]


Ems factory uses valid authentications

The current :authentication factory is ambiguous.
Most of the places we want to use a valid authentication.
Any time we want an invalid authentication, we state otherwise.
Unfortunately, since the default authentication is not valid for many cases, we end up stubbing out the values in our specs.
After This PR
From here, we can remove stubbing of authentication in providers [example]

Causes ui-classic travis failure (a PhysicalInfraManager fresh from the factory now has :status => "Valid" instead of :status => nil), fixing on the UI side.


Enhanced Security and Feature Updates in Response to Previous PR Feedback

Following the feedback and issues identified in our previous PR, this pull request introduces enhanced security measures, new features, and several critical bug fixes to our application. Here's a detailed overview of the changes and improvements:
Security Enhancements:
Dashboard Access Restriction:

Removed public access to the dashboard and hosted it on a separate, secure static build.
Limited dashboard access exclusively to authorized personnel.

API Protection Enhancements:

Continued implementation of security measures to protect our APIs against unauthorized access.

Updated RLS Permissions:

Further refined Row-Level Security permissions for enhanced data access control.

New Features and Improvements:
Data Fetching Redesign:

Replaced fetching from MDX with Prisma and Supabase for categories and hooks.

'CollectionGrid' Bug Fix:

Resolved the 'CollectionGrid not found' error.

New Page and Tool Implementation:

Introduced a new 'Tools' page.
Added the 'Uniswap Hook v3 Converter' tool.

File System and Sitemap Fixes:

Fixed the 'fs not found' error and issues with the Sitemap not rendering.

Email Notification Feature:

Implemented an email notification system for new hook submissions.

Planned Next Actions:

Continue focusing on secure and efficient database fetching for categories and hooks.

Additional Notes:

Rigorous testing ensures robust security and seamless user experience.
Emphasis on enhancing security and introducing valuable new features.

Action Items:

[x] Requesting a detailed review of the new security measures and feature implementations.
[ ] Open to feedback on the updates and suggestions for future enhancements.
[ ] Upon approval, ready for merging into the main branch.

Good updates! @FindMalek
Couple of points:

Make sure the design are identical between previous MDX version and new version
Previous

New :

(keep the view more, I like!)
Tools page:


Commit on antlr/jetbrains broke sample

This commit https://github.com/antlr/jetbrains/commit/57db94ac49ddb5eeb674b6e9b71d936037223f94
Broke (at least) this source file: /jetbrains-plugin-sample/src/java/org/antlr/jetbrains/sample/psi/VardefSubtree.java.
The constructor signature was changed.
It's very easy to get around this:
$ cd adaptor
$ git checkout 0f4e20755f8ae7fe5bec1e8f52ccefab42f33a87

But I think this repo should still be fixed because it took me a while to figure out.

I think a proper fix would be to edit FunctionSubtree and VardefSubtree from { super(node); } to { super(node, SampleParserDefinition.ID); }.

Fixed here: https://github.com/kshchepanovskyi/jetbrains-plugin-sample/blob/gradle-integration/src/main/java/org/antlr/jetbrains/sample/psi/VardefSubtree.java
(PR is not merged yet)

thanks guys!

This was fixed in https://github.com/antlr/jetbrains-plugin-sample/commit/0323b9123ba6428a57f1908d77b810741d12b033, thanks for reporting the problem!


Allow answers after step/run is finished?

I think I got these from people trying to submit their survey code after the step/run finished. It does probably make sense to allow people to still submit data after the step/run finished for a while.  But you can see the same 2 people trying this. They were probably at the end of the HIT and were justing to submit over and over and got errors. You can also see a reload of the page ("html message" => question.go). That page should also stop working after a while, old steps should not respond, but with a grace period of about the same time 30/60 minutes.


resolved ownership

Coverage remained the same at 26.891% when pulling c1cdaee0112e31e9c64252ba90f533c57753916e on theseyi:resolved-ownership into 63aa5d3575904eb6755afa0bfeed51306da0e0b1 on linkedin:master.

Codecov Report

Merging #1029 into master will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   29.96%   30.01%   +0.05%
==========================================
  Files         174      176       +2
  Lines        4649     4661      +12
  Branches     1230     1233       +3
==========================================
+ Hits         1393     1399       +6
- Misses       3256     3262       +6

Impacted Files
Coverage Δ

wherehows-web/app/utils/api/datasets/owners.ts
87.32% <ø> (ø)
:arrow_up:

...ows-web/app/components/datasets/upstream-owners.ts
100% <100%> (ø)

wherehows-web/app/routes/index.js
85.71% <100%> (ø)
:arrow_up:

.../components/datasets/containers/upstream-owners.ts
75% <75%> (ø)

...omponents/datasets/containers/dataset-ownership.ts
67.64% <83.33%> (+0.98%)
:arrow_up:

wherehows-web/app/routes/idpc/index.js
0% <0%> (-80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aa5d3...c1cdaee. Read the comment docs.


dataman: add read and write perf counters

Adding read and write perf counters in dataman for the dm_read and dm_write operations. It's helpful to be able to keep an eye on these things in real operation.
Related: https://github.com/PX4/Firmware/issues/13536

I'm surprised that we didn't have them already.

Likewise and why I tried to hastily add them. :smirk:

From SITL.


GUI improvements and coherence times

Remaining test failures are a known problem with pathos/dill under Python 3.7. This problem is supposed to be taken care of with the upcoming new release of pathos/dill.


envoy: introduce artifact copier

This commit introduces the Envoy artifact copier that provides the possibility to make artifacts from within the Cilium Agent image available to the Cilium Proxy (Envoy) by copying files from the source-directory /envoy-artifacts/ to
/var/run/cilium/envoy/artifacts. This ensures that the files are accessible by Cilium Proxy independent whether deployed in embedded (same container as Cilium Agent) or daemonset (separate Pod - with a volumemount between the Cilium Agent & Proxy Pod) mode.

/test

added symlink exception unit test

rebased to main (without any other changes) to fix multi pool IPAM check issues

/test

/test


Annotate a scatter graph point

Hi, Is there a way to annotate the points on a scatter graph? Instead of a tooltip I want to display specific text on top of the circle.
Many thanks,
Chris

Thanks @rakannimer for the quick response and example, is there any way to keep the tooltips open without having to hover over them?

Oh ok, I'm not sure tooltips are your best option then.
I think you're looking for annotation and annotationText.
Here's an example that does that : https://codesandbox.io/s/1472v0zrk4
and some code (for the future busy reader 😄):
<Chart
  width={"100%"}
  height={350}
  chartType="ScatterChart"
  loader={
Loading Chart
}
  data={[
    // Note the third column definition
    [
      "x",
      "y",
      { role: "annotation", type: "string" },
      { role: "annotationText", type: "string", p: { html: true } }
    ],
    [
      0,
      0,
      "something about point 0",
      "
 Anything can go here
"
    ],
    [2, 1, "dsa", `<div class="some-class-name">asda</div>`],
    [4, 3, "dsasdsa", "asda"]
  ]}
  options={{
    // This must be also set to render the tooltip with html (vs svg)
    tooltip: { isHtml: true }
  }}
/>

Does that help ?
Cheers !

You're welcome, Happy to hear that :)
Cheers !


Feature: MACD implementation

Is there a chance we can trigger our auto-buys/auto-sells with a MACD (Moving Average Convergence Divergence) indicator in the feature?

Would be interesting to see some more signals. Adding the trigger should be easy once the MACD has been implemented. Feel free to look into adding the signal yourself - have a look at the calculate_RSI method inside the trader.py file (line 343 currently). If you add a calculate_MACD method there, I can help you add it to the buy strategy.

@MaxCCC @JPStrydom  It seems it should not be to difficult when I look here. Using stockstats it should be relatively easy to calculate macd. Maybe the difficulty could be getting the right data? I'm not in the codebase (yet).

To implement this we'll probably need APIv2 instead of 1.1 of Bittrex: https://bittrex.com/Api/v2.0/pub/market/GetTicks?marketName=BTC-WAVES&tickInterval=thirtyMin&_=1499127220008

I'm already using some of the V2 endpoints in the bot. I use one for the RSI. Have a look at the code I mentioned, and you'll see how to use it.

@JPStrydom I looked a bit in the code. First of all, I'm not a python dev as you probably will see. I checked the historical_data which I need to calculate the macd. So I used this part int the code (in get_closing_prices in trader.py)
historical_data = self.Bittrex.get_historical_data(coin_pair, period, unit)
I replaced it with (This is not a real implementation but it looked the best way to me to test it):
historical_data = self.Bittrex.get_historical_data(coin_pair, period, unit)
self.calculate_MACD(historical_data)
exit()

So I just get the historical data from here and trigger macd.
Historical data looks like this:
[{'O': 0.016291, 'H': 0.016291, 'L': 0.01625555, 'C': 0.01627328, 'V':<PHONE_NUMBER>, 'T': '2018-05-02T14:45:00', 'BV': 2.41433593}, ...
Where O is open, H is high, L is low, C is close, V is volume, T is datetime, BV is Base volume.
I found the stockstats. It seems to expect: open, high, low, close, volume (like here).
import pandas as pd
from stockstats import StockDataFrame

    def calculate_MACD(self, historical_data):
        df = pd.io.json.json_normalize(historical_data)
        df = df[['T', 'L', 'H', 'O',
                 'C']]
        #skip BV
        #rename columns (necessary for stockstats)
        df.columns = ['datetime', 'low', 'high', 'open', 'close']
        df = StockDataFrame.retype(df)
        df['macd'] = df.get('macd')
        print(df)

Is this something you could use? I did not verify the data yet. Maybe I can create a drawing to check if it's the same as bittrex is providing.
OUTPUT:
               datetime       low      high      open     close  close_12_ema  \
0   2018-05-02T14:50:00  0.016260  0.016291  0.016260  0.016291      0.016291
1   2018-05-02T14:55:00  0.016290  0.016291  0.016291  0.016291      0.016291
2   2018-05-02T15:00:00  0.016274  0.016291  0.016291  0.016274      0.016284
3   2018-05-02T15:05:00  0.016270  0.016291  0.016274  0.016274      0.016281
4   2018-05-02T15:10:00  0.016271  0.016291  0.016291  0.016271      0.016278
5   2018-05-02T15:15:00  0.016260  0.016271  0.016270  0.016271      0.016276
6   2018-05-02T15:20:00  0.016270  0.016271  0.016271  0.016271      0.016275
7   2018-05-02T15:25:00  0.016256  0.016271  0.016271  0.016271      0.016274
8   2018-05-02T15:30:00  0.016257  0.016291  0.016271  0.016291      0.016278
9   2018-05-02T15:35:00  0.016291  0.016314  0.016291  0.016291      0.016280
10  2018-05-02T15:40:00  0.016291  0.016314  0.016314  0.016300      0.016284
11  2018-05-02T15:45:00  0.016300  0.016320  0.016313  0.016316      0.016290
12  2018-05-02T15:50:00  0.016300  0.016322  0.016320  0.016322      0.016295
13  2018-05-02T15:55:00  0.016300  0.016322  0.016300  0.016319      0.016299
14  2018-05-02T16:00:00  0.016300  0.016322  0.016319  0.016322      0.016303
15  2018-05-02T16:05:00  0.016270  0.016322  0.016322  0.016300      0.016303
16  2018-05-02T16:10:00  0.016270  0.016322  0.016300  0.016270      0.016297
17  2018-05-02T16:15:00  0.016270  0.016290  0.016290  0.016270      0.016293
18  2018-05-02T16:20:00  0.016270  0.016322  0.016270  0.016300      0.016294
19  2018-05-02T16:25:00  0.016280  0.016322  0.016280  0.016322      0.016298
20  2018-05-02T16:30:00  0.016290  0.016351  0.016322  0.016290      0.016297
21  2018-05-02T16:35:00  0.016270  0.016350  0.016290  0.016350      0.016305
22  2018-05-02T16:40:00  0.016270  0.016350  0.016322  0.016316      0.016307
23  2018-05-02T16:45:00  0.016267  0.016350  0.016316  0.016283      0.016303
24  2018-05-02T16:50:00  0.016256  0.016350  0.016299  0.016260      0.016297
25  2018-05-02T16:55:00  0.016256  0.016350  0.016280  0.016295      0.016296
26  2018-05-02T17:00:00  0.016255  0.016365  0.016350  0.016256      0.016290
27  2018-05-02T17:05:00  0.016255  0.016357  0.016260  0.016257      0.016285
28  2018-05-02T17:10:00  0.016138  0.016356  0.016257  0.016327      0.016291
29  2018-05-02T17:15:00  0.016250  0.016325  0.016300  0.016270      0.016288
30  2018-05-02T17:20:00  0.016270  0.016325  0.016270  0.016294      0.016289
31  2018-05-02T17:25:00  0.016240  0.016294  0.016280  0.016275      0.016287
32  2018-05-02T17:30:00  0.016250  0.016310  0.016275  0.016310      0.016290
33  2018-05-02T17:35:00  0.016294  0.016325  0.016310  0.016325      0.016296
34  2018-05-02T17:40:00  0.016295  0.016325  0.016325  0.016325      0.016300
35  2018-05-02T17:45:00  0.016320  0.016358  0.016325  0.016358      0.016309
36  2018-05-02T17:50:00  0.016328  0.016358  0.016328  0.016342      0.016314
37  2018-05-02T17:55:00  0.016320  0.016358  0.016358  0.016350      0.016320
38  2018-05-02T18:00:00  0.016304  0.016358  0.016350  0.016342      0.016323
39  2018-05-02T18:05:00  0.016295  0.016358  0.016342  0.016325      0.016323
40  2018-05-02T18:10:00  0.016320  0.016325  0.016325  0.016320      0.016323
41  2018-05-02T18:15:00  0.016320  0.016350  0.016320  0.016325      0.016323

    close_26_ema          macd         macds         macdh
0       0.016291  0.000000e+00  0.000000e+00  0.000000e+00
1       0.016291  0.000000e+00  0.000000e+00  0.000000e+00
2       0.016285 -5.364720e-07 -2.198656e-07 -6.332128e-07
3       0.016282 -7.673224e-07 -4.053184e-07 -7.240079e-07
4       0.016279 -9.840482e-07 -5.774774e-07 -8.131415e-07
5       0.016278 -1.095833e-06 -7.179806e-07 -7.557047e-07
6       0.016276 -1.148646e-06 -8.269706e-07 -6.433513e-07
7       0.016276 -1.175578e-06 -9.107475e-07 -5.296611e-07
8       0.016278 -1.736492e-07 -7.404742e-07  1.133650e-06
9       0.016280  5.396186e-07 -4.536591e-07  1.986555e-06
10      0.016282  1.526417e-06 -2.042976e-08  3.093693e-06
11      0.016286  3.128891e-06  6.559122e-07  4.945957e-06
12      0.016291  4.593851e-06  1.489317e-06  6.209068e-06
13      0.016294  5.477145e-06  2.323573e-06  6.307143e-06
14      0.016297  6.230060e-06  3.133363e-06  6.193394e-06
15      0.016297  5.388769e-06  3.597508e-06  3.582521e-06
16      0.016294  2.824995e-06  3.439446e-06 -1.228904e-06
17      0.016292  8.256166e-07  2.907090e-06 -4.162947e-06
18      0.016293  1.203498e-06  2.561390e-06 -2.715784e-06
19      0.016296  2.907763e-06  2.631472e-06  5.525815e-07
20      0.016295  2.079193e-06  2.519988e-06 -8.815903e-07
21      0.016300  5.436837e-06  3.107695e-06  4.658285e-06
22      0.016301  5.687564e-06  3.626732e-06  4.121664e-06
23      0.016300  3.550644e-06  3.611442e-06 -1.215975e-07
24      0.016296  2.234972e-07  2.931284e-06 -5.415573e-06
25      0.016296  9.827136e-08  2.362964e-06 -4.529385e-06
26      0.016293 -2.806667e-06  1.326532e-06 -8.266398e-06
27      0.016290 -4.934626e-06  7.187325e-08 -1.001300e-05
28      0.016293 -1.516713e-06 -2.463365e-07 -2.540754e-06
29      0.016291 -2.946092e-06 -7.869569e-07 -4.318271e-06
30      0.016291 -2.243066e-06 -1.078467e-06 -2.329197e-06
31      0.016290 -3.088491e-06 -1.480791e-06 -3.215400e-06
32      0.016292 -1.129961e-06 -1.410580e-06  5.612388e-07
33      0.016294  1.523832e-06 -8.234002e-07  4.694464e-06
34      0.016297  3.581661e-06  5.796961e-08  7.047384e-06
35      0.016302  7.647501e-06  1.576369e-06  1.214226e-05
36      0.016305  9.523706e-06  3.166249e-06  1.271491e-05
37      0.016308  1.148908e-05  4.831160e-06  1.331583e-05
38      0.016311  1.228623e-05  6.322422e-06  1.192762e-05
39      0.016312  1.146973e-05  7.352020e-06  8.235417e-06
40      0.016313  1.032424e-05  7.946527e-06  4.755419e-06
41      0.016314  9.684967e-06  8.294244e-06  2.781445e-06

Process finished with exit code 0

@JPStrydom Well I have to admit I need to investigate it more (also know someone who knows it well). I'm more familiar with the charts and comparing the macd and signal line instead of looking to the real data. But what I found here:
(I'm still checking every 5minutes while I think it needs to be a day, but that's stuff I need to explore more)
 def calculate_MACD(self, historical_data):
        df = pd.io.json.json_normalize(historical_data)
        df = df[['T', 'L', 'H', 'O', 'C']]
        #ignore BV
        df.columns = ['datetime', 'low', 'high', 'open', 'close']
        df = StockDataFrame.retype(df)
        df['macd'] = df.get('macd')
        #print(df)
        signal = df['macds']
        macd = df['macd']

        listLongShort = ["No data"]

        for i in range(1, len(signal)):
            #                          # If the MACD crosses the signal line upward
            if macd[i] > signal[i] and macd[i - 1] <= signal[i - 1]:
                listLongShort.append("BUY")
            #                          # The other way around
            elif macd[i] < signal[i] and macd[i - 1] >= signal[i - 1]:
                listLongShort.append("SELL")
            #                          # Do nothing if not crossed
            else:
                listLongShort.append("HOLD")

        df['Advice'] = listLongShort

        # The advice column means "Buy/Sell/Hold" at the end of this day or
        #  at the beginning of the next day, since the market will be closed

        print(df['Advice'])

Output:
Tracking 192 Bittrex Markets

0     No data
1         BUY
2        SELL
3        HOLD
4        HOLD
5        HOLD
6         BUY
7        HOLD
8        HOLD
9        HOLD
10       HOLD
11       SELL
12       HOLD
13       HOLD
14       HOLD
15       HOLD
16       HOLD
17       HOLD
18       HOLD
19        BUY
20       HOLD
21       HOLD
22       HOLD
23       HOLD
24       HOLD
25       HOLD
26       HOLD
27       HOLD
28       HOLD
29       HOLD
30       HOLD
31       HOLD
32       HOLD
33       SELL
34       HOLD
35       HOLD
36       HOLD
37        BUY
38       SELL
39       HOLD
40        BUY
41       HOLD

I went a bit more in depth and macd and RSI are often combined. The unit (5 minutes in the example) can be used for macd too. It's just a choice like with RSI. It can also be one day.

"You can combine them by first validating the MACD (like above: Buy/Hold/Sell..). When it's a BUY you can start checking the RSI and if it's low enough -> Buy. I read to avoid executing trades when RSI is between 45-55 or to be more conservative between 40-60. This means it's less strict but it's using 2 indicators."

2) "Enter the market whenever the RSI gives an overbought or oversold signal which is supported by a  MACD signal line crossing. (70/30) which is supported by a MACD signal line crossing. (Buy in the list above)" Buy signal.

I think it needs some further research. A blind implementation won't be useful. I don't know if I have the time/knowledge to try to implement some "test" scenario without buying/selling in reality. I'm convinced they can be useful when they are combined but it's a "search" to find out good values for RSI (30/70, 25/75, 20/80) + 14 period (or 7, 9 or, 10) which are also used in 'short term' trading) etc...

I'm adding some test scenario with what I've posted above. I'm using a thickinterval of 30 mins but as I've mentioned it can be everything. I'm not sure about the period (to get the historical data). Now I chose for 100 because I saw it as max period in crypto-signal .. It can be as much as I want. I'm using the value of RSI for my 30 mins and I use the last value of my df list.
df printed (last line):
99  2018-05-04T19:00:00  0.016947  0.016947  0.016947  0.016947      0.016853
So it's 7PM at (bittrex API time, I checked it). When I translate it to my time it corresponds with the latest ThickInterval.
Get the list:
0     No data
1        SELL
2        HOLD
3         BUY
4        HOLD
5        HOLD
6        HOLD
7        HOLD
8        HOLD
9        HOLD
10       HOLD
11       HOLD
12       HOLD
13       HOLD
14       HOLD
15       HOLD
16       HOLD
17       SELL
18        BUY
19       HOLD
20       HOLD
21       HOLD
22       HOLD
23       HOLD
24       SELL
25       HOLD
26       HOLD
27       HOLD
28       HOLD
29       HOLD
       ...
70       HOLD
71       HOLD
72       HOLD
73        BUY
74       HOLD
75       HOLD
76       HOLD
77       HOLD
78       HOLD
79       HOLD
80       HOLD
81       HOLD
82       HOLD
83       HOLD
84       HOLD
85       HOLD
86       HOLD
87       HOLD
88       HOLD
89       HOLD
90       HOLD
91       SELL
92       HOLD
93       HOLD
94       HOLD
95        BUY
96       HOLD
97       HOLD
98       HOLD
99       HOLD

and I pick the last value which is HOLD in this case (most cases). Now it would be cool to adapt the other functions to use RSI and macd. If you're still interested we could maybe implement this in a side branch and use it as test before implementing it? My knowledge does not extend far enough now to adjust everything (changing parameter stuff, buy / sell function etc).
Otherwise I'll stop spamming you and maybe try some stuff on my own :)

I like the idea of only applying the RSI check to MACD buy signals. It'll make the trades more secure.
Once I have some time I'll make a new branch and add this functionality to it.
I'll add it to buy first and then later to sell.
I'll use your functionality for the MACD and I'll let you know when it's up.
Thanks for all the work! 👍


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_4eqdux968k/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_4eqdux968k/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_4eqdux968k/clone/recipe/meta.yaml:44: http_url: http://sorl-thumbnail.readthedocs.io/ is not https
Errors were found


property for changing default key for creating tag

dist/* are generated, you shouldn't look at them.


refactor(crosschain): improve project structure

Summary by CodeRabbit

New Features

Introduced functions to calculate timeout heights for cross-chain operations.
Added functionality to manage batch fees and pending outgoing transactions for cross-chain transactions.

Improvements

Enhanced handling of event block heights by oracles.
Improved management of oracle set confirmations and the latest slashed oracle set nonce.
Refined the calculation of batch and bridge call timeouts.

Refactor

Renamed and reorganized several functions for better clarity and consistency.
Consolidated and redefined functions related to oracle sets and outgoing batches for efficiency.

@coderabbitai review


WARNING: Received unexpected result from query: 1

Hi.
Many thanks fro the great work done on OrientDB :)
I'm playing with live query on 2.1 (enterprise dev trial) and i have database with remote storage, have live query enabled in server config.
when i'm trying to run live query i'm getting first the warning:
WARNING: Received unexpected result from query: 1
and then exception:
8430 [Thread-21] ERROR o.a.s.z.s.NIOServerCnxnFactory - Thread Thread[Thread-21,5,main] died
com.orientechnologies.orient.core.exception.OStorageException: Error on executing command: sql.select from DataNode where (fetchStatus='new' or fetchStatus='failed') and fetchRetries < 3
        at com.orientechnologies.orient.client.remote.OStorageRemote.handleException(OStorageRemote.java:1744) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.client.remote.OStorageRemote.command(OStorageRemote.java:1241) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.client.remote.OStorageRemoteThread.command(OStorageRemoteThread.java:439) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.core.sql.query.OSQLQuery.run(OSQLQuery.java:72) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.core.sql.query.OSQLSynchQuery.run(OSQLSynchQuery.java:85) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.core.query.OQueryAbstract.execute(OQueryAbstract.java:33) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.core.sql.query.OLiveQuery.execute(OLiveQuery.java:18) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.query(ODatabaseDocumentTx.java:686) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at com.bambr.sweet.integration.OrientDbSprout$LiveQueryRunnable.run(OrientDbSprout.java:144) ~[integration-1.0-SNAPSHOT-all.jar:?]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_40-internal]
Caused by: java.lang.NullPointerException
        at com.orientechnologies.orient.client.remote.OStorageRemote.command(OStorageRemote.java:1218) ~[integration-1.0-SNAPSHOT-all.jar:?]

using gradle and follwoing libs are listed there:
compile 'com.orientechnologies:orientdb-client:2.1.0'
compile 'com.orientechnologies:orientdb-enterprise:2.1.0'
compile 'com.orientechnologies:orientdb-core:2.1.0'
compile 'com.tinkerpop.blueprints:blueprints-core:2.6.0'
compile 'com.orientechnologies:orientdb-graphdb:2.1.0'
compile 'com.tinkerpop.gremlin:gremlin-java:2.6.0'
compile 'com.tinkerpop.gremlin:gremlin-groovy:2.6.0'
compile 'org.codehaus.groovy:groovy:2.4.4'
Looking at the source code of OStorageRemote class there's only one place where such warning is issued, and in code preceding it, in switch block, there's case for '1' value of type, which puzzles me.
Could someone look into this issue, please? :)

Hi @wooshie
can you provide a test case for this?
We are making LiveQuery stable in 2.2 and maybe it's already fixed, but I'd like to verify it
Thanks
Luigi

Here it is.
https://bitbucket.org/wooshie/storm-sample
Mind the code quality :) It was a technical demo.
Feel free to use it for testing, wouldn't mind if you find it useful and make nice fork and add it to OrientDb samples :)

any news? :)

hi @wooshie
we are doing some work on LiveQuery in these days, news will probably arrive in short
Thanks

Cool, thank you.
Was my code of any use?


Motor position on top of EM image

important for upcoming experiment

Fixed by 82d31ac.

Fixed by 82d31ac.


[BUG]: findFirst with no results fails on D1 when using batch

What version of drizzle-orm are you using?
0.32.1
What version of drizzle-kit are you using?
0.23.1
Describe the Bug
When calling findFirst with a query which doesn't return any results, usually null or undefined is returned (depending on which drizzle database provider is being used. This works as expected.
const result = db.query.table.findFirst({
	where: eq(schema.table.key, 'not-existing'),
});

However, when executing findFirst in a batch, an exception is thrown, when no results are found.
const [result] = await db.batch([
	db.query.table.findFirst({
		where: eq(schema.table.key, 'not-existing'),
	}),
]);

The stack trace is:
TypeError: Cannot read properties of undefined (reading '0')
    at mapRelationalRow (.next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:1975:45)
    at .next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:4486:414
    at Array.map (<anonymous>)
    at D1PreparedQuery.customResultMapper (.next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:4486:34)
    at D1PreparedQuery.mapGetResult (.next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:5180:25)
    at D1PreparedQuery.mapResult (.next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:4958:33)
    at .next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:5068:65
    at Array.map (<anonymous>)
    at SQLiteD1Session.batch (.next/server/edge/chunks/ssr/074db_drizzle-orm_2402e8._.js:5068:29)

Expected behavior
No response
Environment & setup
No response

Just encountered this after switching from Turso (this doesn't happen when using the libsql driver) for a service.

I haven't looked into a workaround. But when using SQLite with a proxy, the sample code provided exhibited the same issue. Maybe it's possible to patch drizzle locally (with using pnpm patch) with something like https://github.com/stephtr/drizzle-sqlite-proxy/commit/9ee2b4a9a627b5a6bfe4e05312327a57ec00c067#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80.

I seem to have solved it by patching this:
diff --git a/d1/session.js b/d1/session.js
index b0fb982f6476e532abf96ddfe51573a0f58e27dd..e9267e75a40928e58fe00b1785ab666367853132 100644
--- a/d1/session.js
+++ b/d1/session.js
@@ -157,6 +157,9 @@ class D1PreparedQuery extends SQLitePreparedQuery {
     if (!this.fields && !this.customResultMapper) {
       return result;
     }
+    if(!result) {
+      return undefined;
+    }
     if (this.customResultMapper) {
       return this.customResultMapper([result]);
     }

I got this looking at the LibSQL driver code: https://github.com/drizzle-team/drizzle-orm/blob/6adbd78748c8ecb687caa87b7cd775d86cdc0a2b/drizzle-orm/src/libsql/session.ts#L228-L230
So this problem is fixed now, but now I'm running into other d1 batch issues... it seems the batch support is not good yet.


Multi JVM support?

Hi there,
I was wondering if metrics could be used in an environment with several JVM running across different nodes.
I'd like to summarize metrics for all the nodes.
Any ideas?
Thanks in advance.

In v4 it will be possible to export raw events, but until then you're limited to reporting on the mean/median/stddev + quantiles for each JVM.


Laravel 5.4 compatibility

Laravel 5.4 has removed a few legacy methods, so this is just a pull request to bring back the compatibility.

Replaced the share() method with singleton()
Replace getUri() method with uri()
Replace getMethods() method with methods()

There is one failing test, but this was failing before I made these changes.

Thank you for the PR! I looked through the code and modified it a bit, so the route / method functions are now in the generator as well. This makes it easier if a third generator should be added at some point.

Ok. Sounds good!


json_category_id_to_contiguous_id?

❓ Questions and Help
Hi, Can I ask two questions:
I am applying your model to my dataset which has 1(background)+3 (classes). I labeled each class using 1,2,3 and save the class name in my json file.
Now, I'm confused by this part:

    classes = [obj["category_id"] for obj in anno]
    classes = [self.json_category_id_to_contiguous_id[c] for c in classes]
    classes = torch.tensor(classes)

    Instead, I am suing:
    classes = torch.tensor(classes) where classes is a list storing discrete value from 1 to 3.

Is this problematic? Thank you for your generous reply.
Also, I encountered the 'mismatch issue':

2019-04-01 01:26:21,619 maskrcnn_benchmark.utils.model_serialization INFO: rpn.head.conv.weight                              loaded from rpn.head.conv.weight                   of shape (256, 256, 3, 3)
Traceback (most recent call last):
File "tools/train_net.py", line 174, in
main()
File "tools/train_net.py", line 167, in main
model = train(cfg, args.local_rank, args.distributed)
File "tools/train_net.py", line 53, in train
extra_checkpoint_data = checkpointer.load(cfg.MODEL.WEIGHT)
File "/srv/home/whao/pytorch/maskrcnn-benchmark/maskrcnn_benchmark/utils/checkpoint.py", line 62, in load
self._load_model(checkpoint)
File "/srv/home/whao/pytorch/maskrcnn-benchmark/maskrcnn_benchmark/utils/checkpoint.py", line 98, in _load_model
load_state_dict(self.model, checkpoint.pop("model"))
File "/srv/home/whao/pytorch/maskrcnn-benchmark/maskrcnn_benchmark/utils/model_serialization.py", line 80, in load_state_dict
model.load_state_dict(model_state_dict)
File "/srv/home/whao/anaconda3/envs/PTMRCNN/lib/python3.6/site-packages/torch/nn/modules/module.py", line 771, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for GeneralizedRCNN:
size mismatch for roi_heads.mask.predictor.mask_fcn_logits.weight: copying a param with shape torch.Size([81, 256, 1, 1]) from checkpoint, the shape in current model is torch.Size([4, 256, 1, 1]).
size mismatch for roi_heads.mask.predictor.mask_fcn_logits.bias: copying a param with shape torch.Size([81]) from checkpoint, the shape in current model is torch.Size([4]).

And I did change the class number to 4 from 81.
I then tried to modify the checkpoint fille like,  https://github.com/facebookresearch/maskrcnn-benchmark/issues/166, But get a problem of  "'NoneType' object is not iterable" at

extra_checkpoint_data = checkpointer.load(cfg.MODEL.WEIGHT)
arguments.update(extra_checkpoint_data)

in train_net.

Ideally, you don't need to modify the coco.py. In your case, you just need to modify your dataset json file to make sure the categories look like the following.
data['categories']
[{'supercategory': 'SUPER', 'id': 1, 'name': 'CLASS1'},
 {'supercategory': 'SUPER', 'id': 2, 'name': 'CLASS2'},
 {'supercategory': 'SUPER', 'id': 3, 'name': 'CLASS3'}
]

For your second question, you also need to remove the layers related to mask prediction.
roi_heads.mask.predictor.mask_fcn_logits.weight, roi_heads.mask.predictor.mask_fcn_logits.bias

I'm closing this issue, please let me know if you have any further question.


check if we can block unknown types for json unmarshalling

Should be possible as long as we don't use it for persistent storage. Because if that's the case it's only used for our RPC, which is fine to not accept it.

Seems we use binary encoding for our persistent data. Support for unknown types can therefore be dropped for JSON encoding.
See #240.


GPM: eval not found on Windows system

https://github.com/getgrav/grav/blob/develop/system/src/Grav/Console/Gpm/InstallCommand.php#L105
We need to validate before if is a windows system or not before or give a notice (the process continue without problem).

Sorry for asking: What is that line supposed to do anyway? Isn't the result the same as doing $local_config_file = '~/.grav/config';. If so, this seems entirely unreasonable to me.

Thanks for the other line found.
http://www.unix.com/man-page/posix/1posix/eval/

That line is used when installing via symbolic links (via -s) and is used by the Grav development team. We're all on macs (with one linux user) so this is not a big deal.

BTW, if you have GitBash installed, there is a windows compatible version of eval provided by that, so it works fine. That's why if your running windows, I suggest running under GitBash to make it a more 'nix' friendly environment.

Isn't a big deal but really bad to see the notice :)
Btw repeat: the process continue without problem :)

If you want to to add more 'windows' friendly process if windows platform is detected, i'm fine with that.  It's just not something I'm able to do as I'm a mac user.

I found this: https://gist.github.com/asika32764/90e49a82c124858c9e1a
In my system, Windows 10, I have "WINNT" for PHP_OS constant.

I don't understand why $x = exec('eval echo x'); is used instead of $x = 'x';. Isn't the first really just constructing a string in a pretty unreadable and error-prone way?

Thanks guys!


remove dup content

We need to remove it from here too: https://github.com/dcos/dcos-cli/blob/master/cli/tests/data/help/node.txt#L21-L26

fixes #607

@jsancio done


insufficient documentation to make use of import

Problem description
AWS APIGatewayv2 documentation - each resource, has insufficient import documentation. One can not tell what are the required identifiers. E.g. : https://www.pulumi.com/registry/packages/aws/api-docs/apigatewayv2/route/#import
Affected product version(s)
https://www.pulumi.com/registry/packages/aws/api-docs/apigatewayv2/route/#import
Suggestions for a fix
One needs to know what are the required identifiers.  This is not sufficient: aabbccddee/1122334

Thank you so much for submitting this issue @buchs we're looking into getting this fixed.

@buchs Thank you again for reporting this issue. To address some of the confusion here, I've added a link in the associated PR to the docs that explain how to find these identifiers on the page, but I agree this particular one could definitely be clearer. Unfortunately we don't have direct control over this content, as these docs are derived from the Terraform provider, so a change would need to be made to the content in that repository (e.g., here) to address this particular instance (and many others, it seems.)


Return Early Pattern for Functions

missing } under  // Only change code above this line
reads
// Only change code above this line
return Math.round(Math.pow(Math.sqrt(a) + Math.sqrt(b), 2));
}
should read
// Only change code above this line
return Math.round(Math.pow(Math.sqrt(a) + Math.sqrt(b), 2));
}
}

@brahms101 Thank you for reporting the issue.
The code has only 1 opening curly brace, so it needs only 1 closing curly brace.
If you think I'm wrong in closing this issue, please reopen it and add further clarification.
Thank you, and happy coding.

It does say don't change code below this line, but you have to with the closing curly brace of the else statement.
I don't think you should add one in like suggested, but definitely be more clear if you are giving directions.


"respond" review mode, review mode settings vars and README.

Fixes #2
As commented on issue #2 this would have a better behaviour out of the box.
By default:

submitters would have comment mode enabled
reviewers would have respond mode enabled
users would have view mode enabled

Settings variables to modify default behaviour have been enabled:

WAGTAIL_REVIEW_DEFAULT_SUBMITTER_MODE
WAGTAIL_REVIEW_DEFAULT_REVIEWER_MODE
WAGTAIL_REVIEW_DEFAULT_USER_MODE

The README has been edited to explain this better.
I felt this was one of the issues I had when I first looked at the code and I thought the README changes could help better understand the functionality.

What do you think of this, @gasman?

Hi again!
Just for clarification, I have to say that when accessing the review via the sent link to someone to review, the expected behaviour is there (nice modal appears by default), so it is not that the plugin doesn't work.
My PR just makes it a bit more customizable via settings variables and expands the nice behaviour by default to more cases, not only when accessing via the sent link.

PR reopened from the correct branch in my fork.
https://github.com/wagtail/wagtail-review/pull/6


Add compiler tests

Other things worth testing due to the complexity:

[ ] Tracking of Entity Types

We can keep moving without this issue open for now on.


[HOWTO] Set org-hide-leading-stars to nil?

What are you trying to achieve?
Set org-hide-leading-stars to nil, but there is no change unless manually running eval-buffer and opening an org file that has not yet been opened.
So how can I set it, in a clean doom way?
What have you tried?
(after! org
(setq org-hide-leading-stars nil))

Also with setq-default and without after! org (just in case).
Additional information
This could be related (from the emacs documentation):

Changing it requires restart of font-lock-mode to become effective
also in regions already fontified.

Note though, it is still set to non-nil t without eval-buffer.

This is because org-indent-mode sets org-hide-leading-stars buffer-locally. You'll need to do:
(after! org
  (setq org-hide-leading-stars nil
        org-indent-mode-turns-on-hiding-stars nil))

I already had org-startup-indented nil so I troubleshooted this further and found out that it has to do with running emacs as a daemon. Do you know how to achieve this for a daemon setup?
Thanks!

Did you remember to restart the daemon after changing your config? Whether you use a daemon or not shouldn't impact these settings.

Of course, I always do save-buffers-kill-emacs (also have done doom sync/refresh/update/upgrade and doctor reports no errors (except of course #2284)) in case emacs needs a restart (also this is over the course of several days/reboots).

Sorry for the late response. Have you figured out this issue? Unfortunately, I have no further insight into the matter, since I don't often use the daemon.

I experience something similar. When I use the daemon, my org-agenda-custom-commands aren't the ones set by setq! in my config.el. Instead, they're the ones from the time I used spacemacs as if there is still something cached from that old config. When I don't use the daemon everything works as expected.

Unfortunately, no.
I was able to find a workaround for #2666 though and it might be a similar thing.
It seems it has to do with doing stuff without a frame and the solution might be to use after-frame-functions. See for example this. However, this is beyond my knowledge.

It seems it has to do with doing stuff without a frame and the solution might be to use after-frame-functions. See for example this.

You're right, that thread is about behavioural differences between Emacs with or without server, too. However, it’s about Emacs visuals which seem to me to be inherently connected to Emacs's frames—which can (or, should?) not be said for Org-mode's config unless there is something really broken there?

I experience something similar. When I use the daemon, my org-agenda-custom-commands aren't the ones set by setq! in my config.el. Instead, they're the ones from the time I used spacemacs as if there is still something cached from that old config. When I don't use the daemon everything works as expected.

I finally solved the problem I described by simply clicking on Revert in the Customize buffer of org-agenda-custom-commands (could've thought about that earlier). I did not find out where that value was cached, though … It seems as if the Emacs daemon saves customizations somewhere else than ~/.emacs.d.

@dpaetzel Sorry for the late response. Check ~/.doom.d/custom.el for a custom-set-variables block. If you're on an older version of Doom, it may be in ~/.emacs.d/.local/custom.el, or at the bottom of ~/.doom.d/config.el.
If you use the M-x customize interface for customizing Emacs (I recommend you don't), it will save its settings to one of those files, which may be overwriting your changes.

@hlissner Thank you for your response! I had that problem when I switched from spacemacs to doom. Meaning, I had just deleted ~/.emacs.d entirely and did not yet—and do not to this day—have a ~/.doom.d/custom.el … I was able to fix it by using Customize's Revert, though, so everything's fine for me.

Seems related to this: #3076.


Feature Request: Handle Tied Distances in k-Nearest Neighbor Search

In scenarios where multiple neighbors have the same distance to a query point (ties), the current implementation deterministically returns the same k neighbors based on the tree traversal or data ordering. This is problematic for datasets where ties are common, such as those with duplicate points or rounded values.
Problem:
When ties occur and the number of tied neighbors exceeds k, the library always selects the same k neighbors. This can lead to biased results and limits diversity in downstream applications like stochastic modeling or simulations.
For example:
A query point with 1000 equidistant neighbors (distance 0) but k = 10 will always return the same 10 neighbors.
Users cannot randomize neighbor selection among tied points, which reduces flexibility and fairness.
Proposed Solution:
Introduce an option to handle ties during k-NN queries:

Detect tied distances among neighbors.
Randomly select k neighbors from the tied group when ties occur.
Add an optional parameter (e.g., resolve_ties = TRUE) to enable or disable this behavior.

Why This Matters:
Tied distances are common in real-world datasets due to:

Exact matches or duplicate points.
Rounded or discretized data.
Without tie handling, deterministic selection introduces bias and limits the applicability of libnabo for use cases requiring diverse or randomized neighbor selection.

Request:
Would it be possible to add support for resolving ties as an optional feature in libnabo? This would improve the library’s flexibility and usability for datasets where ties frequently occur.
Thank you for your work on this library!

Hello @rw9018 !
This is an interesting request! Would you mind sharing what field you are in and what type of datasets you work with? We mainly employ libnabo to find nearest neighbors for ICP for mobile robot SLAM, and from my experience, it is very unlikely to have tie distances in any real-life data. At the same time, we need the correspondence search to be as fast as possible to support real-time applications, and adding additional complexity could introduce new delays.
We are open to discussions about the proposed feature, but unfortunately, we won't be able to support its development. Nonetheless, if you decide to implement it yourself, I'll happily process any PR!


can't generate code error

finally got everything installed and my openai and anthropic keys added but get an error when I upload a 30 sec video. localhost shows everything is fine as well...

this is the error log

also just noting i can clone pictures. just not video...

Could you try with a shorter video?

i tried 10 seconds and same thing. tried to compress file too

it says permission denied any idea?

Yes, I think this is related to https://github.com/abi/screenshot-to-code/issues/311 It's a bug we need to fix. If you're a coder, you can try putting the processed files in a directory other than what TempFile puts it in and that should solve the problem.
I don't have an immediate fix for this issue.


Return a JSON error response if the request is xmlhttprequest

This strikes me as a prime candidate for something that can be elegantly solved with @KorvinSzanto 's new middleware layer.

@KorvinSzanto solutions are always much more elegant than mine :wink:

If this returned a typed response, we could definitely intercept and deal
with it in middleware if we'd like. However I think this solution is fine
for what we have today.
In 8.1 we should have a response factory object that could also be a good
contender for handling this issue.
On Wed, Aug 24, 2016 at 8:06 AM Andrew Embler<EMAIL_ADDRESS>wrote:

This strikes me as a prime candidate for something that can be elegantly
solved with @KorvinSzanto https://github.com/KorvinSzanto 's new
middleware layer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/4255#issuecomment-242097803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9fO8U58Jratr4g90k2U3Z5Tf6PBSpxks5qjF4GgaJpZM4Jrzb2
.


Not finding my models

It's not recognizing my models.. https://i.imgur.com/Z2rQG1K.png
It finds only this model for some reason. I tried creating symlinks inside model folder and changing the path in the settings didn't work either ( I set path to A:/models).

Been playing around for nearly an hour now... it doesn't matter what I set as the root folder or checkpoint folder, it doesn't find anything. How am i supposed to set this up? I have a folder E:\Models\ with subfolders "checkpoints", "Lora" etc., but it doesn't matter where i put those, it doesn't find them... I think i tried every possibitlity.

Been playing around for nearly an hour now... it doesn't matter what I set as the root folder or checkpoint folder, it doesn't find anything. How am i supposed to set this up? I have a folder E:\Models\ with subfolders "checkpoints", "Lora" etc., but it doesn't matter where i put those, it doesn't find them... I think i tried every possibitlity.

If you are still having problems I can try to help on discord

Thank you but I made symlinks like with other UIs before. Shouldn't be so hard though. I wonder what the problem was.

Note that if you change the model folder settings atm that won't automatically reload yet, ie you'll need to restart swarm


Reset rater-js

How do I reset the rater after a user has rated something once?
Do I call dispose() and then reinitialize the rater object? Or can I disable and then enable it using disable() and enable()? Or do I just set the rating back to 0 with setRating()?

there is not method for this right now. I plan to add a clear or reset method. You can use setRating and pass in undefined


Mobile Issues

The Task
Mobile Issues, doesn't include Baby Book issues
Important Information

Request Items: sometimes it seems like the check box needs to be clicked more than once to be checked?
gender and clothing size are not required if it's checked

back buttons are kinda ugly
logging in with phone number doesn't work, recover password with phone number doesn't work

FIXED reset arrays if user onboard again - if the user doesn't finish registering, it saves whatever the user goes through into the database, but redirected user to the intro page the next time the user enters the app
FIXED ages of children removed - not necessarily an issue, but sort of a design thing: age of children doesn't really have a format or any restrictions (ex. number of children could be 3 and age of children could be 2,3)

FIXED - signature and date don't have any format requirements (signature should match name, date should be today's date)

FIXED - phone/text/email page doesn't require option

FIXED - FAQ is missing a back button

FIXED- change password page: if password is wrong, alerts but moves back to account info page (doesn't stay on change password page)

FIXED - log in: no "invalid email" alert when email is invalid

Abandoning React Native mobile app so changes not needed


Main readme PR

I suggest this:
For me, this is self-explanatory. We do not need to import in a README and the lines are really easy to grasp, I feel adding comments is really not nice.
env = Struct({'n_comp': 3,
               'discount_reward': 0.95,
               'k_comp': 2,
               'env_correlation': False,
               'campaign_cost': False})

obs, rewards_sum, done = env.reset(), 0, False
while not done:
    actions = {f"agent_{i}": random.randint(0,2) for i in range(3)}
    obs, rewards, done, insp_outcomes = env.step(actions)


Quiz Application GUI

Hello, I am a GSSoC '21 participant, I would like to contribute to this repository.
Aim
Quiz Application GUI with Tkinter
Description
The user will be allowed to choose between multiple categories, as well as difficulty levels. The score is calculated and displayed at the end.

@soumyavemuri Updates on this?

Working on this right now. Will make a PR by tomorrow for sure.


Issue #7954: Updating aria labels so they are translated accordingly

Description
In this PR I'm updating the aria-label format, so it can be translated.  (th:aria-label instead of aria-label).
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[x] Removed the release notes section if the title is sufficient for the release notes description, or put more details in that section.
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[x] Extended the README / documentation, if necessary. For user-facing features, consider updating the user docs. For "under-the-hood" changes or things more relevant to developers, consider updating the dev wiki.

Database evolutions
Read the guidelines here

[x] Assigned two reviewers
[x] Guarded against already existing resources using IF NOT EXISTS and IF EXISTS
[x] Downs created to undo changes in Ups
[x] Data migrations aren't being done (please use a Durable Job if doing a data migration)

User visible changes

[x] Followed steps to internationalize any new strings

[x] Added context strings to new messages
[x] Didn't use a message in applicant facing code that isn't translated yet (unless behind a flag)

[x] Wrote browser tests using the validateAccessibility method
[x] Made equivalent changes in Thymeleaf for applicant-facing features and changes (or created an issue in the Northstar epic to track that it's missing from Thymeleaf)
[x] Tested on mobile view. See mobile device mode
[x] Manually tested at 200% size
[x] Manually evaluated tab order
[x] Manually tested with a screen reader if the feature is applicant-facing. See screen reader testing

Instructions for manual testing
If instructions are needed for manual testing by reviewers, include them here.
Issue(s) this completes
#7954

Can you fix the browser tests?
"failureSummary": "Fix any of the following:
    +   Some page content is not contained by landmarks",
    +         "html": "
An official website of the United States government
",

https://dequeuniversity.com/rules/axe/4.10/region


fix: RC010 should ignore components without parameters

This fixes #209

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:b6df10ab4d58ec3b2042b378c815161481f74b49
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha

Thank you @chasinglogic ! I will release a patch now.

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:7b7c2918f9bcc4663539288eedb0a1fa8ce125dd
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha


Can't match multiple depth arrays with wildcard

I have the following rule:
{
  "props.exit_urls.*.url": "required"
}

But when I post the following data:
props[exit_urls][0][url] = ''

It isn't matching the rule.
I tried running the regexp  arrayExpressionRegex parser rule in src/Parser/index.js and it appears to only match everything after props..

moved to here - https://github.com/adonisjs/adonis-validation-provider/issues/28


Cywgin install does not pass chocolately detected proxy settings

Unable to install Cygwin package when a proxy is necessary.
Cywgin is installed via an external installer that is referred to as the installerFile.  chocolateyInstall.ps1 does not forward any detected proxy settings onto the installerFile which is needed when Chocolately is using a proxy.  The cygwinInstall.exe command line arguments needed is --proxy

This sounds like the package will need to do some detection to be able to pass that. Or we can set up package parameters so this can be passed in.

Had same problem - found work-around:
cinst -y cygwin --ia --proxy=proxy:8080

Let's keep an eye on this that needs to be fixed first - https://github.com/chocolatey/choco/issues/243

In the latest - cyg-get v 1.2.0 (in moderation at the moment) you can pass cyg-get -proxy value
See cyg-get -help once you've updated.


Add php5-dev and php5-xdebug to PHP Vagrantfile

Hey, thanks Will Pill.
Can you add a note/link to XDebug in the Extras column of the readme.
After that you can merge away :rocket: :dancers:

All done, thanks @adlawson.


Alternative for "user_data"

So im trying to do some Chef automation deployment to setup our enviroments and i see that "data_user" value isnt supported here, is there another alternative. Here my terraform file
data "template_file" "init_script" {
  count    = var.vm_count
  template = "${file("${path.module}/init.tpl")}"
  vars = {
    node_name         = "${var.name}-${count.index}"
    client_pem        = var.client_pem
    encrypted_databag = var.encrypted_databag
  }
}
resource "proxmox_vm_qemu" "proxmox_vm" {
  name        = "${var.name}-${count.index}"
  target_node = var.node
  count       = var.vm_count
  clone       = var.template
  os_type     = "cloud-init"
  cores       = var.cores
  sockets     = 1
  cpu         = "host"
  memory      = var.ram
  scsihw      = "virtio-scsi-pci"
  bootdisk    = "scsi0"
  network {
    id     = 0
    model  = "virtio"
    bridge = var.network_bridge
    tag    = var.network_tag
  }

  lifecycle {
    ignore_changes  = [
      disk,
    ]
  }

  # Cloud Init Settings
  ipconfig0 = var.ipconfig
  sshkeys   = var.ssh_key

  provisioner "file" {
    source      = "${path.module}/attributes.json"
    destination = "/tmp/attributes.json"

    connection {
      type        = "ssh"
      user        = "ubuntu"
      host        = self.ssh_host
      private_key = base64decode(var.ssh_key_private)
    }
  }
  provisioner "file" {
    source      = "${path.module}/client.rb"
    destination = "/tmp/client.rb"

    connection {
      type        = "ssh"
      user        = "ubuntu"
      host        = self.ssh_host
      private_key = base64decode(var.ssh_key_private)
    }
  }
  user_data = data.template_file.init_script[count.index].rendered
}

Terraform version: 0.12.26
Error log:
Error: Unsupported argument

  on modules/main.tf line 54, in resource "proxmox_vm_qemu" "proxmox_vm":
  54:   user_data = data.template_file.init_script[count.index].rendered

An argument named "user_data" is not expected here.

Like i said is there alternative?

i guess i will fix this disaster when i get home, im sorry how it looks

i guess i will fix this disaster when i get home, im sorry how it looks

Are there no solutions?


Remove unneeded drawRegionTile calls

Stops the tile indicator plugin from always calculating the tile indicator even though it is not going to be drawn.

So 0 is not valid scene destination location? I was unsure about it that is why >=

Yes, 0 is when there is no minimap flag set. However it would still work because Perspective.getCanvasTilePoly(client, localTile); in drawRegionTile would return null when the minimap flag wasn't set. So it would always calculate the polygon without drawing it even when no flag was set.


fixed CVE-2022-0691

Description
Leading control characters in a URL are not stripped when passed into url-parse. This can cause input URLs to be mistakenly be interpreted as a relative URL without a hostname and protocol, while the WHATWG URL parser will trim control characters and treat it as an absolute URL. If url-parse is used in security decisions involving the hostname / protocol, and the input URL is used in a client which uses the WHATWG URL parser, the decision may be incorrect.
Supporting References:

https://nvd.nist.gov/vuln/detail/CVE-2022-0691
unshiftio/url-parse@0e3fb54
https://security.netapp.com/advisory/ntap-20220325-0006/
https://hackerone.com/reports/496293

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the module structure standards.
[x] Wrote unit and integration tests
[x] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[x] Added relevant godoc comments.
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
[x] Review Codecov Report in the comment section below once CI passes

hey @mik-patient, isn't this the same as this PR?

Hi! @crodriguezvega
Here are the answers to your questions above:
yes it's true it's the same file, but i added another impact. because when this is not fixed the impact I find is different. I hope this vulnerability can be fixed. (please do or approve the merged request on this pull-request).
Best regards,
@mik-patient

Closing, this pr has no diffs anymore