Reduce driver package footprint?

These are the dependencies I get by including the driver in my project: close to 10Mb of additional bytes:
{{{
[INFO] +- com.microsoft.sqlserver:mssql-jdbc:jar:6.1.0.jre8:compile
[INFO] |  - com.microsoft.azure:azure-keyvault:jar:0.9.3:compile
[INFO] |     +- com.microsoft.azure:azure-core:jar:0.9.3:compile
[INFO] |     |  +- com.sun.jersey:jersey-client:jar:1.13:compile
[INFO] |     |  |  - com.sun.jersey:jersey-core:jar:1.13:compile
[INFO] |     |  - com.sun.jersey:jersey-json:jar:1.13:compile
[INFO] |     |     +- org.codehaus.jettison:jettison:jar:1.1:compile
[INFO] |     |     |  - stax:stax-api:jar:1.0.1:compile
[INFO] |     |     +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
[INFO] |     |     |  - javax.xml.bind:jaxb-api:jar:2.2.2:compile
[INFO] |     |     |     - javax.xml.stream:stax-api:jar:1.0-2:compile
[INFO] |     |     +- org.codehaus.jackson:jackson-core-asl:jar:1.9.2:compile
[INFO] |     |     +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.2:compile
[INFO] |     |     +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.2:compile
[INFO] |     |     - org.codehaus.jackson:jackson-xc:jar:1.9.2:compile
[INFO] |     +- org.apache.httpcomponents:httpclient:jar:4.5.2:compile
[INFO] |     |  - org.apache.httpcomponents:httpcore:jar:4.4.6:compile
[INFO] |     +- javax.inject:javax.inject:jar:1:compile
[INFO] |     - com.microsoft.azure:adal4j:jar:1.0.0:compile
[INFO] |        +- com.nimbusds:oauth2-oidc-sdk:jar:4.5:compile
[INFO] |        |  +- net.jcip:jcip-annotations:jar:1.0:compile
[INFO] |        |  +- org.apache.commons:commons-lang3:jar:3.3.1:compile
[INFO] |        |  +- com.nimbusds:lang-tag:jar:1.4:compile
[INFO] |        |  - com.nimbusds:nimbus-jose-jwt:jar:3.1.2:compile
[INFO] |        |     - org.bouncycastle:bcprov-jdk15on:jar:1.51:compile
[INFO] |        - com.google.code.gson:gson:jar:2.8.0:compile
}}}
Is there a way to make the azure-keyvault an optional dependency considering that the mssql-jdbc.jar is only 766093 bytes and we are not going to use it with azure keyvault?

@ydewit - which version of the jar are you including in your project?

Hi @ajlam, that is great. I am using com.microsoft.sqlserver:mssql-jdbc:jar:6.1.0.jre8. I did see the 6.1.4, but the -preview turned me away from it. Should I use 6.1.4 instead?

I just tried 6.1.4 and the extra dependencies are gone. Assuming that it is ok to use the preview release, I am good here and this issue can be closed.

I just tried 6.1.4 and the extra dependencies are gone. Assuming that it is ok to use the preview release, I am good here and this issue can be closed.


Add scala-java-time deps for testing on Scala.js

Codecov Report

Merging #1161 into master will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage    85.7%   86.01%   +0.31%
==========================================
  Files          88       88
  Lines        2868     2868
  Branches      119      115       -4
==========================================
+ Hits         2458     2467       +9
+ Misses        410      401       -9

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Decoder.scala
86.71% <0%> (+0.5%)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
80.36% <0%> (+0.61%)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
96.51% <0%> (+5.81%)
:arrow_up:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
100% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a27b32...a02d138. Read the comment docs.


Inability to access custom properties

I'm not sure how to explain this fully, but it has become a nasty stumbling block for me; that is the inablity to access special properties that are only available via the __get() magic method.
I have been using a simplified model that only fetchs data if and when it is needed - (see below for an example). As it stands, Twig is unable to see the properties normally accessed in this way as uses Reflection to examine the class directly.
With small models, this is not a problem, however the largel models accesing tables with many fields and deep references to other tables this becomes a task I cannot see how to elegantly overcome using Twig in its current form.
<?php
/**
  * CREATE TABLE users
  * (
  *     id      INT UNSIGNED  NOT NULL,
  *     name    VARCHAR(20)   NOT NULL,
  *     born    INT UNSIGNED  NOT NULL,
  *     gender  ENUM('M','F') NOT NULL,
  *     partner INT UNSIGNED  NOT NULL DEFAULT '0',
  *
  *     PRIMARY KEY(id)
  * );
  *
  * INSERT INTO users (id, name, born, gender, partner)
  *    VALUES
  *       (1, 'Alice', 329821200, 'F', 2),
  *       (2, 'Bob',   289422295, 'M', 1);
  **/
class User
{
    private static $instance;
    public  $id;
    private $data = null;

    public static function instance( $id )
    {
        if (!isset(self::$instance))
            self::$instance = array();

        if (!array_key_exists($id, self::$instance))
            self::$instance[$id] = new User($id);

        return self::$instance[$id];
    }

    public function __construct( $id )
    {
        $this->id = $id;
    }

    public function __get( $key )
    {
        if (is_null($_data))
        {
            // data hase not yet been loaded,
            // load from the database

            $rs  = mysql_query('SELECT * FROM users WHERE id = ' . $this->id);
            $row = mysql_fetch_array($rs, MYSQL_ASSOC);

            $this->data = $row;

            mysql_free_result($rs);
        }

        // check for calculated fields and
        // special fields returning objects

        switch ($key)
        {
            case 'age':
                return time() - $this->data['born'];

            case 'partner':
                // Lazy loading of partner only occurss *if* the
                // calling process actually needs access to it.
                if ($this->data['partner'])
                    return User::instance($this->data['partner'];
                return null;
        }

        if (array_key_exists($key, $this->data))
            return $this->data[$key];

        throw new Exception('Property "' . $key . '" not found');
    }
}

$loader = new Twig_Loader_String();
$twig   = new Twig_Environment($loader);
$user   = User::instance(1);
$html   = <<<EOF

ID

{{ user.name }}

Name

{{ user.name }}

EOF;
echo $twig->render
(
    $html,
    array
    (
        'user' => $user
    )
);

/**
  * Ideal Result
  * ============
  *

  *
ID

  *
1

  *
Name

  *
Susan

  *

  *
  *
  * Actual Result
  * =============
  *

  *
ID

  *

  *
Name

  *

  *

  **/

Twig can handle magic. Could you try to define an __isset method and see if it works?

@suhana See the doc for it: http://twig.sensiolabs.org/doc/recipes.html#using-dynamic-object-properties

Oh :"> I missed that one - Thanks for the heads up.


Bump collector version to 0.104.0

Bump collector and adjust the env vars in configuration to adhere to the expected convention (see notes in https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.104.0)

cc @coralogix/team-observability


add invite dojo feature

add invite dojo feature

This already exists as the Share button?

This already exists as the Share button?

Oh! Sorry, it's my fault. Just saw the share function.


OTA blocks retransmission

Describe the bug
The OTA agent has continuous receiving of duplicate OTA blocks.
In parallel to OTA agent task MQTT communications I send data to another topic every 5 seconds, and even if I disable the transmission this duplication occurs.
The communication is through greengrass
System information

Board : ESP32
Operating System : Windows
08.2019
Project [Greengrass+OTA]

Screenshots or console output

Thank you!

Hello,
Thank you for reporting this issue and sharing logs.
Please set the request timer to a higher value in the OTA agent config using the config parameter  otaconfigFILE_REQUEST_WAIT_MS . From the logs you shared it seems the request are being sent faster than the data blocks being received. You can also control the number of blocks requested by lowering the OTA config otaconfigMAX_NUM_BLOCKS_REQUEST . Please let me know how this works for you and if you have further questions.

Hello,
Please reopen this issue if you have more questions related to this or post a new issue for questions on other topics. Closing this issue now.


returned wrappers for subclasses are incorrect

PairRDD is a subclass of RDD (and PairDStream is subclass of DStream).  Since the subclasses do not implement the functions of the base class, the wrong wrapper class (the base class wrapper) will be created when calling one of the functions on the base class.
For instance,  rdd.mapToPair( ...).setName().sortByKey() would fail because setName (a base class function) would return the RDD wrapper class which does not have the sorByKey() function.
Instead of explicitly creating the wrapper class instances,  the Serialize.javaSparkObject  should be used to create correct wrapper class based on what the returned java object is.

Still a problem for PairDStream

What is the problem?

No problem with anything you did, I just need to make the same changes to PairDStream that you did for PairRDD

fixed PairDStream via commit 8157b705e70627d54cd62b6e03a3d588dd98dcca


Math Magicians

In this Project, I:

Installed React app
Added the calculator UI and functionality
Used React hooks (UseState)
Fixed linter errors

Hi @Rachelwebdev,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

App was already built with functional components :heavy_check_mark:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Test the verilog primitives

We should start separately testing our primitives written in verilog:

[ ] verilator --lint-only <file.sv> gives a bunch of warnings for most files. We should fix all warnings.
[ ] Add tests starting with complex primitives like std_sqrt and the signed primitives.

bdd8275e5813643e2b69f619cf99c28f22684217 adds a simulation "self-test" for the complex primitives (mod and div) which ensure that the generated outputs match the ones that would be generated by the behavioral primitives.


port GenotypeGVCFs

The requirement is to port the GenotypeGVCFs tool and tests. Test data should be made public whenever possible.

closed by https://github.com/broadinstitute/gatk-protected/pull/553/


Typo in "React Redux 04: Use Provider to Connect Redux to React"

The first sentence:

In the last challenge, you created a Redux store to handle the messages array and created actions for adding new messages.

-created actions for adding new messages.
+created an action for adding new messages.

Only a single action was created.

Got it.


Ignore frames from <anonymous> from anything except explicit Raven.captureException

This appears to only be from Chrome, and it's triggered from someone digging around in their local dev console.
So we should ignore this and don't even send it.
BUT, it's semi common to use Raven.captureException from within someone's console to test that it's working.
tl;dr, we want to continue capturing is someone does this explicitly, but we want to ignore if this was captured from something that was wrapped or window.onerror.

Chrome no longer triggers onerror if you throw errors in the console. You have to at least wrap it in setTimeout now, which feels like someone has to at least go out of their way to make trouble (and I'm not sure we ought to stop them, since people legitimately test Raven.js this way).
Closing unless I'm missing something.


Pictures are missing in this document.

https://github.com/apache/rocketmq/blob/master/docs/cn/design.md
Pictures are missing in this document.
I really hope there are pictures in this document for us to understand.

@htf1129 there is pictures as bellow, maybe network problems.

I'm sorry. It's my fault that the image is missing due to my browser plugin.


Add ip address to any interface on node restart microk8s

Summary

Assigning an IP address to any interface on the node restarts microk8s cluster.
It kick starts CSR generation and restarts all microk8s daemons.
What Should Happen Instead?

Any network changes to interfaces not used by microk8s should not affect microk8s cluster.
The CSRs should not get regenerated and services should not get restarted.
Reproduction Steps

Deploy microk8s on single node
Assign IP to one of spare interface
sudo ip a addr br-ex <IP_ADDRESS>/24
Check for microk8s.kubectl get po -A the pods get recycled

Introspection Report

Logs:
$ sudo snap logs microk8s.daemon-apiserver-kicker -f
2022-11-18T14:26:19+05:30 microk8s.daemon-apiserver-kicker[6655]: CSR change detected. Restarting the cluster-agent
2022-11-18T14:26:19+05:30 microk8s.daemon-apiserver-kicker[6655]: CSR change detected. Reconfiguring the kube-apiserver
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760604]: Signature ok
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760604]: subject=C = GB, ST = Canonical, L = Canonical, O = Canonical, OU = Canonical, CN = <IP_ADDRESS>
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760604]: Getting CA Private Key
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760609]: Signature ok
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760609]: subject=CN = front-proxy-client
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[1760609]: Getting CA Private Key
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[6655]: CSR change detected. Restarting the cluster-agent
2022-11-18T14:29:42+05:30 microk8s.daemon-apiserver-kicker[6655]: CSR change detected. Reconfiguring the kube-apiserver

Caused by change in rendered CSR file csr.conf.rendered [1].
Apparently this is because of hostname -I returns additional IP which makes rendered file different from previous.
[1] https://github.com/canonical/microk8s/blob/master/microk8s-resources/actions/common/utils.sh#L447-L471
Can you suggest a fix?

I think the CSR need not get regenerated if an additional IP is added and all previous IPs are not changed.
If user really wants the extra IP to be part of CSR, user can run refresh-certs command.
Are you interested in contributing with a fix?

Just to provide a little more context; as part of the microstack configure step for deploying an all-in-one OpenStack cloud we add an IP address to one of the openvswitch bridges to allow north/south traffic routing to instances.
As soon as this happens, K8S gets kicked resulting in the OpenStack API services deployed to K8S disappearing for a bit just at the point where we need to actually use them for configuration of the cloud.
If we could have a way to exclude IP's or disable this behaviour that would be great.
we're running with 1.25-strict at the moment.

Thank you for bringing this up. This is a side-effect from single-node MicroK8s automatically adjusting to IP address changes (e.g. in developer machines where IP addresses are assigned by DHCP).
We will look into it and see what middle-ground we can come up with. Perhaps ignoring new IP addresses might be a solution, perhaps not (e.g. adding a new VLAN after deploying MicroK8s should probably not be ignored for the API server).

@ktsakalozos thanks for your response, we're also seeing this issue using charm-microk8s, what would be the correct step forward in your opinion ?


Get tests to pass

Got all RSpec specs to pass (completely wrote a few complicated feature tests as view tests).
Downgraded rubocop to 0.52.1 to avoid the dependency on jaro-winkler which requires native compilation and complicates running tests in docker.

Meant to do the PR against develop.


Authentication Failed with Rubrik 5.0 alias Andes

It seems that Rubrik has changed the Authentication in Version 5.0.0. The Exporter is not able to create a Session token.

Anyone fixed this?

Maybe it's our configuration, but this exporter is working for us on 5.1.0-p1


Code Tab Examples

📚 Documentation
On this page there is no information about code based tab examples. There should be some information about how to use tabs with different code snippets. Especially for different languages this would be really helpful.
Have you read the Contributing Guidelines on issues?
Yes

Oh sorry. Found it here. Was expecting it to be under the Tabs header. Not sure if that is just me or if it should be moved.

There's nothing special about code tabs because it's just an example of how to use the Tabs for code. The tabs section is use-case agnostic and can be left as such.


add Capability.TableLastModifiedMetadataBatch support

resolves #https://github.com/dbt-labs/dbt-snowflake/issues/965
docs dbt-labs/docs.getdbt.com/#

Problem

dbt-snowflake adapter metadata-based freshness can be computed in batch by using the base adapter implementation of calculate_source_freshness_from_metadata_batch, but the capability has not yet been enabled

Solution

enable capability + add tests (continued with pattern of individual test (not inherited) in this file)

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

The verify packages CI check is failing on Check wheel distrubutions with:
AttributeError: TableLastModifiedMetadataBatch. Did you mean: 'TableLastModifiedMetadata'?

It seems like the branch setting of batch-metadata-freshness on dbt-adapters does not propagate to that step. It should be resolved once https://github.com/dbt-labs/dbt-adapters/pull/127 is merged.


Trailing spaces on include where breaking css imports

Super simple one - just removed the spaces in material_css.html. Not sure how this hasn't been a problem for everyone else?
Now you can do:
{% include 'material/includes/material_css.html' %}

and it will work

Thanks, Fixed same fix in #163


mesh view example

Here is a simple example that can display simple triangle meshes (in the .obj format). I'm new to GitHub so if there are things that I've done that don't conform to standard practice please let me know and I'll fix my mistakes.

I'm no expert on Git either.
Great to have another contributor.
I'm guessing its OK to merge this into my master.
In the long run it will need to be reviewed by flyx.
Perhaps it might be helpful to open an "issue" in flyx/OpenGLAda to "advertise" this new example.

Thanks for this contribution Leo,
From my comments on GitHub you'll gather that I'm not quite sure how to handle it.

Regards,
Roger

On 28 Sep 2017, at 7:28 pm, Leo Brewin<EMAIL_ADDRESS>wrote:
Here is a simple example that can display simple triangle meshes (in the .obj format). I'm new to GitHub so if there are things that I've done that don't conform to standard practice please let me know and I'll fix my mistakes.
You can view, comment on, or merge this pull request online at:
https://github.com/rogermc2/OpenGLAda/pull/1
Commit Summary
• added sources for mesh_view example
• created local copy of examples/common in mesh_view to avoid breaking existing examples
• updated meshview.gpr to use local common directory
• updated README.txt for mesh_view example
File Changes
• M .gitignore (2)
• A examples/ogl_tutorials/mesh_view/Makefile (19)
• A examples/ogl_tutorials/mesh_view/README.txt (40)
• A examples/ogl_tutorials/mesh_view/common/controls.adb (95)
• A examples/ogl_tutorials/mesh_view/common/controls.ads (9)
• A examples/ogl_tutorials/mesh_view/common/initialize.adb (57)
• A examples/ogl_tutorials/mesh_view/common/initialize.ads (4)
• A examples/ogl_tutorials/mesh_view/common/load_dds.adb (212)
• A examples/ogl_tutorials/mesh_view/common/load_dds.ads (8)
• A examples/ogl_tutorials/mesh_view/common/maths.adb (227)
• A examples/ogl_tutorials/mesh_view/common/maths.ads (47)
• A examples/ogl_tutorials/mesh_view/common/program_loader.adb (76)
• A examples/ogl_tutorials/mesh_view/common/program_loader.ads (23)
• A examples/ogl_tutorials/mesh_view/common/quaternions.adb (81)
• A examples/ogl_tutorials/mesh_view/common/quaternions.ads (21)
• A examples/ogl_tutorials/mesh_view/common/utilities.adb (228)
• A examples/ogl_tutorials/mesh_view/common/utilities.ads (36)
• A examples/ogl_tutorials/mesh_view/maps/16x128.png (0)
• A examples/ogl_tutorials/mesh_view/maps/bwr.png (0)
• A examples/ogl_tutorials/mesh_view/meshes/cube.obj (47)
• A examples/ogl_tutorials/mesh_view/meshes/lattice.obj (18665)
• A examples/ogl_tutorials/mesh_view/meshes/suzanne.obj (2580)
• A examples/ogl_tutorials/mesh_view/meshes/wave.obj.gz (0)
• A examples/ogl_tutorials/mesh_view/meshview.gpr (26)
• A examples/ogl_tutorials/mesh_view/src/COPYING (14)
• A examples/ogl_tutorials/mesh_view/src/README.txt (4)
• A examples/ogl_tutorials/mesh_view/src/libcli.adb (21)
• A examples/ogl_tutorials/mesh_view/src/libcli.ads (7)
• A examples/ogl_tutorials/mesh_view/src/libobj.adb (295)
• A examples/ogl_tutorials/mesh_view/src/libobj.ads (39)
• A examples/ogl_tutorials/mesh_view/src/libpng.adb (244)
• A examples/ogl_tutorials/mesh_view/src/libpng.ads (33)
• A examples/ogl_tutorials/mesh_view/src/meshview.adb (52)
• A examples/ogl_tutorials/mesh_view/src/meshviewlib.adb (567)
• A examples/ogl_tutorials/mesh_view/src/meshviewlib.ads (59)
• A examples/ogl_tutorials/mesh_view/src/png/PNG_IO download | SourceForge.net.webloc (0)
• A examples/ogl_tutorials/mesh_view/src/png/gpl.txt (674)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adam7.adb (185)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adam7.ads (80)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adaptive_filter.adb (95)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-base.adb (102)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-base.ads (169)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-chromaticity_data.ads (78)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-chunk_ordering.adb (109)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-gamma_encoding.adb (79)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-gamma_encoding.ads (44)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-generic_image_dump.adb (170)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-generic_image_dump.ads (75)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-open.adb (847)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-standard_rgb_encodings.adb (90)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-standard_rgb_encodings.ads (55)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_0.adb (193)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_2.adb (142)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_3.adb (209)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_4.adb (141)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_6.adb (145)
• A examples/ogl_tutorials/mesh_view/src/png/png_io.adb (1418)
• A examples/ogl_tutorials/mesh_view/src/png/png_io.ads (602)
• A examples/ogl_tutorials/mesh_view/src/shaders/Colour_Fragment_Shader.glsl (66)
• A examples/ogl_tutorials/mesh_view/src/shaders/MVP_Vertex_Shader.glsl (41)
• A examples/ogl_tutorials/mesh_view/src/zlib/ZLib for Ada thick binding. download | SourceForge.net.webloc (0)
• A examples/ogl_tutorials/mesh_view/src/zlib/readme.txt (65)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-streams.adb (205)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-streams.ads (105)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-thin.adb (141)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-thin.ads (486)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib.adb (662)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib.ads (317)
Patch Links:
• https://github.com/rogermc2/OpenGLAda/pull/1.patch
• https://github.com/rogermc2/OpenGLAda/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello Leo,
I decided to make a new branch mesh_view_example.
Please, if possible, commit your code to this branch and PR which I will merge ASAP.
Hope this helps,
Roger

On 28 Sep 2017, at 7:28 pm, Leo Brewin<EMAIL_ADDRESS>wrote:
Here is a simple example that can display simple triangle meshes (in the .obj format). I'm new to GitHub so if there are things that I've done that don't conform to standard practice please let me know and I'll fix my mistakes.
You can view, comment on, or merge this pull request online at:
https://github.com/rogermc2/OpenGLAda/pull/1
Commit Summary
• added sources for mesh_view example
• created local copy of examples/common in mesh_view to avoid breaking existing examples
• updated meshview.gpr to use local common directory
• updated README.txt for mesh_view example
File Changes
• M .gitignore (2)
• A examples/ogl_tutorials/mesh_view/Makefile (19)
• A examples/ogl_tutorials/mesh_view/README.txt (40)
• A examples/ogl_tutorials/mesh_view/common/controls.adb (95)
• A examples/ogl_tutorials/mesh_view/common/controls.ads (9)
• A examples/ogl_tutorials/mesh_view/common/initialize.adb (57)
• A examples/ogl_tutorials/mesh_view/common/initialize.ads (4)
• A examples/ogl_tutorials/mesh_view/common/load_dds.adb (212)
• A examples/ogl_tutorials/mesh_view/common/load_dds.ads (8)
• A examples/ogl_tutorials/mesh_view/common/maths.adb (227)
• A examples/ogl_tutorials/mesh_view/common/maths.ads (47)
• A examples/ogl_tutorials/mesh_view/common/program_loader.adb (76)
• A examples/ogl_tutorials/mesh_view/common/program_loader.ads (23)
• A examples/ogl_tutorials/mesh_view/common/quaternions.adb (81)
• A examples/ogl_tutorials/mesh_view/common/quaternions.ads (21)
• A examples/ogl_tutorials/mesh_view/common/utilities.adb (228)
• A examples/ogl_tutorials/mesh_view/common/utilities.ads (36)
• A examples/ogl_tutorials/mesh_view/maps/16x128.png (0)
• A examples/ogl_tutorials/mesh_view/maps/bwr.png (0)
• A examples/ogl_tutorials/mesh_view/meshes/cube.obj (47)
• A examples/ogl_tutorials/mesh_view/meshes/lattice.obj (18665)
• A examples/ogl_tutorials/mesh_view/meshes/suzanne.obj (2580)
• A examples/ogl_tutorials/mesh_view/meshes/wave.obj.gz (0)
• A examples/ogl_tutorials/mesh_view/meshview.gpr (26)
• A examples/ogl_tutorials/mesh_view/src/COPYING (14)
• A examples/ogl_tutorials/mesh_view/src/README.txt (4)
• A examples/ogl_tutorials/mesh_view/src/libcli.adb (21)
• A examples/ogl_tutorials/mesh_view/src/libcli.ads (7)
• A examples/ogl_tutorials/mesh_view/src/libobj.adb (295)
• A examples/ogl_tutorials/mesh_view/src/libobj.ads (39)
• A examples/ogl_tutorials/mesh_view/src/libpng.adb (244)
• A examples/ogl_tutorials/mesh_view/src/libpng.ads (33)
• A examples/ogl_tutorials/mesh_view/src/meshview.adb (52)
• A examples/ogl_tutorials/mesh_view/src/meshviewlib.adb (567)
• A examples/ogl_tutorials/mesh_view/src/meshviewlib.ads (59)
• A examples/ogl_tutorials/mesh_view/src/png/PNG_IO download | SourceForge.net.webloc (0)
• A examples/ogl_tutorials/mesh_view/src/png/gpl.txt (674)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adam7.adb (185)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adam7.ads (80)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-adaptive_filter.adb (95)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-base.adb (102)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-base.ads (169)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-chromaticity_data.ads (78)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-chunk_ordering.adb (109)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-gamma_encoding.adb (79)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-gamma_encoding.ads (44)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-generic_image_dump.adb (170)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-generic_image_dump.ads (75)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-open.adb (847)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-standard_rgb_encodings.adb (90)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-standard_rgb_encodings.ads (55)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_0.adb (193)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_2.adb (142)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_3.adb (209)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_4.adb (141)
• A examples/ogl_tutorials/mesh_view/src/png/png_io-write_png_type_6.adb (145)
• A examples/ogl_tutorials/mesh_view/src/png/png_io.adb (1418)
• A examples/ogl_tutorials/mesh_view/src/png/png_io.ads (602)
• A examples/ogl_tutorials/mesh_view/src/shaders/Colour_Fragment_Shader.glsl (66)
• A examples/ogl_tutorials/mesh_view/src/shaders/MVP_Vertex_Shader.glsl (41)
• A examples/ogl_tutorials/mesh_view/src/zlib/ZLib for Ada thick binding. download | SourceForge.net.webloc (0)
• A examples/ogl_tutorials/mesh_view/src/zlib/readme.txt (65)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-streams.adb (205)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-streams.ads (105)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-thin.adb (141)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib-thin.ads (486)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib.adb (662)
• A examples/ogl_tutorials/mesh_view/src/zlib/zlib.ads (317)
Patch Links:
• https://github.com/rogermc2/OpenGLAda/pull/1.patch
• https://github.com/rogermc2/OpenGLAda/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Actually, I have an excellent instruction sheet from flyx concerning git usage.
Unfortunately I can't locate the original e-mail but, if you like, I could copy it and send it to you.

The other alternative is to make a new branch off your master.
I thought I suggested that but I must have "lost" the comment.
This is from flyx's advice:

update your clone of my repo: git fetch upstream.
2.create a new branch based on the master branch of my repo:
git checkout -b mesh_view_example upstream/master
commit your changes to the new branch.
4 push the new branch to your remote:
git push origin mesh_view_example.
You should now be able to create a PR from the mesh_view_example branch.
 This is important for our versions to not converge.

I'm not sure that even this is the right approach unless I can pass a PR from you onto the flyx repo.
The problem is that if I merge a PR from you then it will merge into my master which would violate the "don't EVER commit to my master branch" rule.
If passing the PR on to the flyx master is not possible an alternative solution may be for you to fork my mesh_view_example then  PR on this would merge your forked branch into my mesh_view_example branch. I could then PR flyx master when appropriate.
I remain unsure of the best solution.
Another "simplest" solution would be for you to fork flyx/OpenGL then create a mesh_view_example on your forked master. But that would tend to put the review onus directly onto flyx rather providing me the opportunity for a preliminary review thus, hopefully, reducing the review effort required from flyx. An advantage is that I am aware of many of flyx's preferences and we could at least fix these prior to bothering him.
I imagine there's a simple solution not obvious to us git novices!

I've just had a quick look at your code and doubt that I can offer much in the way of review comments so, it seems to me that the best solution would be to fork flyx/OpenGL then create a mesh_view_example on your forked master.
Based on all of my comments the final solution is yours which I'll be happy to support.

flyx has asked not to submit any more PRs until he has set up a new development branch.

Hi Roger,
Thanks for the e-mails.
I'm currently reading through tutorials on git to make some sense of the
multitude of workflows that seem possible. I'm still finding my feet, so
please bear with me if I seem to ask silly questions are do silly things
(not intentionally but more out of ignorance).
Yesterday I did the following.

On my GitHub page I forked your master of OpenGLAda.
On my desktop I did a git pull from my GitHub page.
I made local edits of the local files.
I pushed those edits back to my master on GitHub.
I sent a pull request from my GitHub to you.

That's as far as I've got. Now comes the problem (as you've noted). Here ar
few of my current questions:

How do I update my GitHub master to keep in step with yours?
You mentioned never committing to the master. So that means creating a
branch. Do I do that from your master or from mine.
Should I start again by first deleting my master, then re-forking yours
and then create a branch (all in GitHub)?
Am I right in assuming that the GitHub web pages are we we exchange our
files?
I'm very comfortable with the command line and really would prefer to do
as much Git stuff from there. But I guess I'll have to click some buttons
on the GitHub pages.

You mentioned that you had a great summary of git commands from Felix. If
you could find those that would be a great help.
I'm not planning on making any significant changes to the mesh viewer but
I'm very happy to clean it up and make it ready for anybody else who want
it. So my investment in git will probably be just for this project (I'm not
a developer). I wrote the mesh viewer as bit of fun and its something I use
in my work (maths at Monash Uni).
I did send the code as a tgz archive to Felix some weeks ago and he
suggested it was better for all of us if I went down the git road. He also
suggested that I should include a copyright notice in each file. At present
I've only gone as far as placing a COPYING file in the main directory.
Sorry for the long ramble. On a final note, you're the only other person in
Australia that I know of who codes in Ada (but I'm suer there are others).
I do my best to convince my colleagues that it's (in my opinion) hands down
the best language around for scientific computing (my research is black
holes). But my advice falls of deaf ears -- they prefer the old Fortran
codes and their bug ridden C and C++ codes.
Cheers,
Leo
On 29 September 2017 at 07:17, Roger<EMAIL_ADDRESS>wrote:

flyx has asked not to submit any more PRs until he has set up a new
development branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rogermc2/OpenGLAda/pull/1#issuecomment-332966556, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADxPtdSeJ_lFuzeWvP2oFyIe5e0CNrkfks5snAzWgaJpZM4Pm-kJ
.

I'll respond to your message in separate comments for each section.
"I'm currently reading through tutorials on git to make some sense of the
multitude of workflows that seem possible. "
Yes I find git a real headache.
I originally got into a real mess using the GUI app and decided that was best avoided.
I'm not a command line fan, but for git I find it the only reliable method.
My current method involves using a set of instructions provide by flyx which I intend to provide you with a complete copy tomorrow.
My next line of action is to google operations that I need. I can usually find good instructions this way.
I do have the Progit book which is quite good. In fact I have two copies, so if you give me your address I could send you one. I thin there's a website that provides it only that I used to find fairly good.

I'll slot in comments based on  my flyx instruction sheet:
"Yesterday I did the following.

On my GitHub page I forked your master of OpenGLAda.
This your leo-brewin/OpenGLAda (remote) repository
On my desktop I did a git pull from my GitHub page.
According to flyx, you should have a clone of the remote repository on your desktop generated using git clone git@github.com:leo-brewin/OpenGLAda.git. But perhaps you've achieved this another way?
By cloning from your GitHub repository, git will automatically setup a remote called origin which points to your GitHub repository. Flyx provides a lot more detail which I hope to provide tomorrow.
I made local edits of the local files.
I pushed those edits back to my master on GitHub.
This is where I think you went wrong. You should have created a new branch based on the master branch of my repo. then added, committed and pushed those edits to the new branch using git push origin .
I sent a pull request from my GitHub to you."
I'm not sure what happened to that PR which I did accept then revert yesterday. The PR itself seems to have disappeared.
I note the situation at present is that your mesh_view is in your master but not in mine.
I think it should be in a separate branch off your (or my master).
Hopefully the flyx instructions will help you sort this out tomorrow.

Here are few of my current questions:

How do I update my GitHub master to keep in step with yours?
This will be covered in the  flux document.
You mentioned never committing to the master. So that means creating a
branch. Do I do that from your master or from mine.
The Flyx instruction says do it from mine.
Should I start again by first deleting my master, then re-forking yours
and then create a branch (all in GitHub)?
This is probably what I would do (in fact I'd almost say "its the story of my life - make a mess, wipe it up, repeat n times, make a fixable mess then keep cleaning until I'm satisfied.)
But, probably best wait for the Flyx instructions before taking further action.
Am I right in assuming that the GitHub web pages are where we we exchange our
files?
I'm not sure if this is the right description. As I understand it files are exchanged between repositories; the web pages probably provide a mechanism for doing this.
I'm very comfortable with the command line and really would prefer to do
as much Git stuff from there. But I guess I'll have to click some buttons
on the GitHub pages.
I find I mostly operate via the command line (say 99%) and occassionallly get to click buttons.

OK, first job for me tomorrow is send you that "great summary of git commands from Felix"!
After that I plan to comment on the rest of your message.

Actually, I think you should be forking off flyx/OpenGLAda.


LHN - Avatar for 1:1 DM report disappears from requestee view when IOU request is received

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.90-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/29101
Action Performed:

Go to staging.new.expensify.com
User A sends a few messages to User B.
User B opens chat report with User A.
User A creates a money request in 1:1 DM with User B

Expected Result:
The avatar for 1:1 DM report will not disappear from User B's view
Actual Result:
The avatar for 1:1 DM report disappears from User B's view for a moment when the IOU request is received
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] Windows: Chrome
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

https://github.com/Expensify/App/assets/78819774/cb0122ff-5da6-4b7d-a22d-1458e19bd45c

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012491fd05ba5481ac
Upwork Job ID:<PHONE_NUMBER>805659648
Last Price Increase: 2023-10-25

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is a deploy blocker for Web-Expensify but not App cc @deetergp

Not an App issue so gonna unassign @narefyev91

This should be fixed now.


Add pytests for ephys_chronic module

Closing this individual issue as we are working to improve overall test coverage.


a certain unexpected result occures when use native back gesture to pop a viewController.

when I use native back gesture to pop a vc, the tabBar will show at the initial time of the popping animation, covering the vc I am popping,this situation is not expected. so I set the tabBar hidden in the 'will disappear' function, it dose not work.Next, I set the tabBar hidden in the target vc's 'will appear' function.This time, the tabBar was totally disappeared, even the popping animation has run out.
Is there any way for me to use RDVTabBarController and native back gesture both?
I have also tried to change RDVTabBarController's code, like to add the TabBar at the contentView etc, none of those attempts work.
Please help!

need a method like: 'self.hidesBottomBarWhenPushed=YES;'


Fixes for 8.0.1-rc1

This patch addresses two changes in template-haskell-<IP_ADDRESS>:

It looks like the layout of the GadtC constructor has changed since support was originally added for template-haskell-<IP_ADDRESS>. The old constructor had four fields, one of which was a single name, though now there is only a list of names present. The problem seems only present with the definition of constructorName which isn't used outside of the Internal module.
The Fixity field present on DataConI turned into Maybe Fixity

I addressed 1 by always taking the head of the name list present on GadtC. As this function is only ever used in a context where the data type is assumed to be plain or a newtype, this seemed like an OK compromise. One caveat is that the gadtError function from Generics.Deriving.TH.Internal will only ever list the constructor from the head of that list, but maybe that's alright.
2 is addressed by just processing the promoted type as though the fixity information was not present. This might not be the right behavior, so it would be nice to have someone else check that :)

Hi @elliottt, sorry that I've been slow to update generic-deriving for GHC 8.0. I just pushed a pretty big update which happens to encompass the changes made here, so I'll go ahead and close this.

Alright, it should be ready to work with GHC 8.0 now, so I'll merge this.
Expect a new Hackage release soon.

Oops, commented on the wrong one.


Wrong version of Swinject on podspec

Please fix podspec. Currently it's pointing to Swinject 2.7.1 instead of 2.8.1

Hope it will be merged soon !

Hey, I still have this issue. If I put the latest versions into my Podfile:
github "Swinject/Swinject" "2.8.1"
github "Swinject/SwinjectAutoregistration" "2.8.1"

I get this error message:
[!] CocoaPods could not find compatible versions for pod "Swinject":
  In Podfile:
    Swinject (= 2.8.1)

    SwinjectAutoregistration (= 2.8.1) was resolved to 2.8.1, which depends on
      Swinject (= 2.7.1)

Is it possible that something is still wrong? :D The only way for me to get this work is to use github "Swinject/SwinjectAutoregistration" "2.7.0"

@norbert05 use master branch to perform your tests. Although the fix had been merged it is yet to be released.

+1

I have finally found some time to do the release, sorry for the long wait.
If someone would like to help with maintaining the repo I would be happy to invite them to the project.


ESO graphics corruption since builds after 3cb3c05

With the current commits, the graphics in ESO are all messed up (see attached sacreenshot)  as I generally still play with Wine-staging 3.3 with the vulkan stuff from staging 2.21 I thought I'd test with a proper install of wine-vulkan as well, and the issue was present there also. I had skipped a few versions, so went back and tested...3cb3c05 was the last one that worked properly, every version since has this issue, fo rme at any rate.
Hopefully I attached the log files right, anything else needed let me know? :)

System information

GPU:Geforce GTX 1050
Driver:390.25
Wine version: wine-vulkan
DXVK version:  ba2c478

eso64_d3d11.log
eso64_dxgi.log

Please run with DXVK_DEBUG_LAYERS=1 and post the full console output.
Guess I'll have to disable image mapping again.

Please let me know if e6814332e741ac7222fe1c372fda7aed86ce657b fixes the issue.

e681433 fixes the issue, nice work :)   In the interest of testing, as requested I attempted to run ba2c478 with DXVK_DEBUG_LAYERS=1 but ESO will hang after login and before character select, so unable to test properly.

I'll give it another try, I did leave it 20 min or so but maybe not long enough.  I agree not 'nice' work as such but only nice as in the game works.  I'd say perhaps I should just switch to an AMD card, but that doesn't really fix the issue

It's currently been running for an hour, memory usage has been frozen at 1.3gb and disk read total is staying at 732kb CPU usage sits at 2%.  The ingame music still plays but the loading indicator froze over 45 min ago...I'll keep it going longer.

Well, it might take long to load, but not quite that long. Thanks for trying though.

I gave it another hour after that, as left it when taking dog for a walk, still nothing so just killed wine :D

What are the other games affected by the reverted performance optimisation?  I would be happy to test but don't own ESO myself.

@thirdeyefunction Most Cryengine games and The Witcher 3 are known to benefit significantly from this optimization.
@schtufbox I created a new branch direct-image-mapping which re-enables the optimization by default. I also fixed two issues that may have been the reason for the missing textures in ESO. Please test and let me know if it works.

May be it can be toggled with some environment variable, in order not to require building different branches?

For what is worth, ESO works on vega+radv with the direct-image-mapping branch, as expected.
I may test it later on my wife's laptop (Windows 10 + some NVIDIA GPU)

@doitsujin I 'attempted' to compile the direct-image-mapping' but due to the messed up mingw in AUR I was unable to do so...which is why I usually wait for https://haagch.frickel.club/files/dxvk/  as he does daily builds from github.  I had hoped that it was working by now, but alas no.

@schtufbox , have you tried the methods suggested in the AUR page?
https://aur.archlinux.org/packages/mingw-w64-gcc/
That's how I managed to install a working crosscompiler...

That's how I managed to get it installed, but it won't compile

Most Cryengine games and The Witcher 3 are known to benefit significantly from this optimization

I was wondering more which games break from the feature, rather than which are helped by it. Other than ESO that is, although I ended up picking it up on sale so I can test it sometime later.

@schtufbox you can also use blackarch repos for precompiled mingw-w64

@schtufbox  or use mine: https://thaodan.de/home/bidar/home-thaodan/x86_64/

Thanks guys, I'm just building a new version of wine-vulkan then I'll give it a go.

In the end I installed a VM of tumbleweed and compiled from there...test results?
@doitsujin with the direct-image-mapping build  ESO works flawlessly with the changes you made.
I played for about 5 hours (on and off, not in one sitting!) and noticed no additional issues over the normal branch of DXVK

Thank you for testing this. This confirms that at least part of the issue was caused by DXVK not checking whether the driver actually supported host-mapped images of a given type.


feat: add navigate through the arrows to previous commands

#2

Nice!

@MatheusKProt Please submit functional changes only.
I added prettier config that might help your IDE pickup the correct code style used in the project.

@m4tt72 sure!

@m4tt72 done!

Thanks @MatheusKProt, merged 🚀


lib: #![allow(clippy::needless_borrow)]

In my experience this is far and away the clippy lint that is:

Most common to trigger (especially when refactoring code)
The least valuable to fix; there's no performance or correctness concerns really

There's also clippy::needless_borrows_for_generic_args which is similar and also has an instance fixed by #236, so we might want to include both.

There's also clippy::needless_borrows_for_generic_args which is similar and also has an instance fixed by https://github.com/containers/bootc/pull/236, so we might want to include both.

Makes sense probably to add (as a followup to not rerun CI I think), but I don't think you're correct that there is an instance in that PR.

There's also clippy::needless_borrows_for_generic_args which is similar and also has an instance fixed by #236, so we might want to include both.

Makes sense probably to add (as a followup to not rerun CI I think), but I don't think you're correct that there is an instance in that PR.

It's this one:
error: the borrowed expression implements the required traits
  --> lib/src/mount.rs:28:23
   |
28 |     let o = Task::new(&desc, "findmnt")
   |                       ^^^^^ help: change this to: `desc`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D clippy::style`
   = help: to override `-D clippy::style` add `#[allow(clippy::needless_borrows_for_generic_args)]`

Ahh I figured it out, I was on 1.73, it looks like in 1.74 they split this lint into two.

Ahh I figured it out, I was on 1.73, it looks like in 1.74 they split this lint into two.

Stuff like this BTW is another reason not to hard block on "style" clippy lints; requiring every contributor to match the exact Rust version run in CI for clippy in the general case gets annoying.


x/website:

share
google chrome
uintptruintptr
What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

What did you expect to see?
What did you see instead?

Please stop filing blank issues. Thanks.


Wrong 1-n relation nullable inference

Hello there :)
Giving this schema on Prisma 2.23.0, posts always have an author. An an author (user) have many posts (typical 1-n relation). But when generating prism client and using it for creating posts, the author is considered as nullable which is incorrect.
It means this guide is broken :/
model User {
  id       Int     @id @default(autoincrement())
  posts    Post[]
}

model Post {
  id        Int      @id @default(autoincrement())
  author    User     @relation(fields: [authorId], references: [id])
  authorId  Int
}

context.prisma.post
  .findUnique({
    where: { id: post.id },
  })
.author() // it returns Prisma.Prisma__UserClient<User | null> instead of Prisma.Prisma__UserClient<User>

@MikaStark 👋
This seems like an issue. I would suggest creating one here so that we can look into this.

Hello @ryands17
Issue posted here : https://github.com/prisma/prisma/issues/7348


Add more or less standard header for the Python3 script

The script is using Python 3 interpreter and also it's good to have internal encoding defined. Taking all these into account, add a more or less standard header to the script.

Now it's signed. I dunno what GitHub wants from me. Probably a bug in GitHub.

Please could you explain why you think these are necessary? UTF-8 is the default for Python 3, and vim is one editor amongst many others. I don't currently see the need for these, so it would have to be a pretty strong argument to add them.

Now it's signed. I dunno what GitHub wants from me. Probably a bug in GitHub.

This is not a bug; the repository has a rule to require signed commits.

Without this change vim may break PEP-8, but that's just one editor, and it's not the one I use to maintain this project. As a result I really don't see any particular reason to add it – I'm sure all sorts of other editors have their own configuration comments like this, but that's not a concern if people who use them aren't actually maintainers of the project.
As the Python 3 documentation clearly explains, If no encoding declaration is found, the default encoding is UTF-8.

Why the commit is still in Unverified state?

The error message explains this (emphasis mine): "The base branch requires all commits to be signed".


Ore crabs should be weak to structural

Description

they are walking ore
Reproduction

Screenshots

Additional context

Implemented in #25390

This can be closed.

this should be closed


Keybinding: should not block or trigger when more modifiers are used than assigned to the keybinding

Blish core: 1.0.0
expected behavior:
blish hud keybindings only trigger  (.Activated)  for their keybinding and do not interfer with other keybindings.
actual behavior:
blish hud keybindings are triggered  (.Activated)  when more modifier keys are pressed than are part of the keybinding. This can cause keybindings to trigger in unwanted situations and it can block other unrelated keybindings from working.
Examples:
(2 cases, one with sending to game and one with not sending to game option enabled. BlockSequenceFromGw2?)
blocking other keybindings:
when a blish hud keybinding like alt + t is assigned in a blish hud module, it will block alt + shift + t, too. e.g. in this case it would prevent arcdps from receiving alt + shift + t. This currently happens with the trading post module (not 100% sure if it used .Activated):
https://discord.com/channels/531175899588984842/534492173362528287/1084984576293740634
Probably happening too: When a keybinding for "A" with BlockSequenceFromGw2=true is setup, it will block any key presses that include an "A". e.g. it will block "A" and "CTRL+A" and "ALT+A" and so on.
triggering on wrong keybinding
same issue the other way around: when a hotkey with multiple modifier keys (e.g. arc dps alt + shift + t) is pressed it will also trigger blish keybindings for alt + t. this happens with the gathering tools module
https://discord.com/channels/531175899588984842/534492173362528287/1086462037397352458
Solution
discussion starts here https://discord.com/channels/531175899588984842/536970543736291346/1086615020105891841

This issue seems to happen more often as of lately. (More users are asking)
I got about 3 cases via dm or support server.


Chain wont resync after producer goes down

How to reproduce

3 block producers  A, B and C  running with   latest commit 4f29311 .
The block producers work perfect and the net is in sync.
We vote out A and B, so only C is producing blocks
The chain is in Sync
Producer C   gets disconnected  ( crash or network problems,etc)
Producer A and B start waiting for connections
Producer C starts with replay
Producer A and B rejects the blocks C sends.

What we think it happens
The error seems to be that the disconnected nodes ask for the first block that is missing (in screens 1321) but when compares the id and the previous block, shows data for  the block that is missing +1 (in screens block 1322)
Error Log Producer B
1558159ms thread-0   net_plugin.cpp:1489           recv_block           ] block not accepted, try requesting one more time
1558159ms thread-0   controller.cpp:755            push_block           ] 10 assert_exception: Assert Exception
prior != by_id_idx.end(): unlinkable block
    {"id":"0000052aba54123c48349df507fdb62034250b1a29fd45842d0d965be3c45749","previous":"0000052936566f8f45f98245f562c897e444d3da2b3cd2e4ba83474ed0041fc4"}
    thread-0  fork_database.cpp:153 add
1558160ms thread-0   net_plugin.cpp:2475           handle_message       ] unable to accept block on assert exception Assert Exception (10)
prior != by_id_idx.end(): unlinkable block
rethrow
 from xps15:9876 - e18b454
1558160ms thread-0   net_plugin.cpp:1495           recv_block           ] second attempt to retrive block 1321 failed
1558160ms thread-0   net_plugin.cpp:2074           operator()           ] Error reading message from connecting client: Bad file descriptor
1579976ms thread-0   net_plugin.cpp:703            connection           ] accepted network connection
1588313ms thread-0   controller.cpp:755            push_block           ] 10 assert_exception: Assert Exception
itr->second <= result.block_num - h.confirmed: producer double-confirming known range
    {}
    thread-0  block_header_state.cpp:168 next
1588314ms thread-0   net_plugin.cpp:2475           handle_message       ] unable to accept block on assert exception Assert Exception (10)
itr->second <= result.block_num - h.confirmed: producer double-confirming known range
rethrow
 from xps15:9876 - e18b454
1588314ms thread-0   net_plugin.cpp:1489           recv_block           ] block not accepted, try requesting one more time
1588316ms thread-0   controller.cpp:755            push_block           ] 10 assert_exception: Assert Exception
prior != by_id_idx.end(): unlinkable block
    {"id":"0000052aba54123c48349df507fdb62034250b1a29fd45842d0d965be3c45749","previous":"0000052936566f8f45f98245f562c897e444d3da2b3cd2e4ba83474ed0041fc4"}

Screens Producer B

Screens block producer C

We have a similar problem here testing the producer_api_plugin. We pause BP node 1, resume BP node 2, which works. We then pause BP node 2, and resume BP node 1. Then, BP node 2 goes down from this error and it can't resync with the chain.

Thanks for sharing your detailed example @notchxor

If someone is trying to fix this in their testnet setup. We end up booting again.

#3442 I filed a separate issue for the scenario where I encountered the assertion exception. It's a milestone to be fixed for version 1.0.

Anyone know how to setup Mainnet ?

We haven't received any update for this. If you still have the problem and wish to discuss further, please post it in https://eosio.stackexchange.com


security/acme-client: deploy error results in certificate stuck in state validation error

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] The title contains the plugin to which this issue belongs

Describe the bug
I had an disabled automation of type "Upload certificate to Synology DSM" in my config. It was obviously executed anyways and exited with an error. The certificate was stuck in state "validation failed". The certificate has been properly renewed. The import to the system trust was not executed.
Workaround:

Delete the failing Automation
Manually execute "(Re-) Import Certificate"
Manually execute "Run Automations"

To Reproduce
Steps to reproduce the behavior:

Go to 'Services --> ACME Client'
Configure Accounts, Challenge Types, Certificates an Automatons
Add an Automation of type "Upload certificate to Synology DSM", that will fail. Disable it.
Wait for the cron job to run for the certificate that needs renewal
See error

Expected behavior

Complete the ACME Run with error "automatons failed' instead of 'validation failed'.
Don't run disabled Automations.

Screenshots

Relevant log files
System Log
2022-08-31T04:12:00	Notice	opnsense	AcmeClient: issue/renewal not required for certificate: [***]
2022-08-30T04:12:00	Notice	opnsense	AcmeClient: issue/renewal not required for certificate: [***]
2022-08-29T04:14:29	Error	opnsense	AcmeClient: validation for certificate failed: [***]
2022-08-29T04:14:29	Error	opnsense	AcmeClient: domain validation failed (dns01)
2022-08-29T04:12:00	Notice	opnsense	AcmeClient: using challenge type: [***]
2022-08-29T04:12:00	Notice	opnsense	AcmeClient: account is registered: [***]
2022-08-29T04:12:00	Notice	opnsense	AcmeClient: using CA: letsencrypt
2022-08-29T04:12:00	Notice	opnsense	AcmeClient: renew certificate: [***]
2022-08-29T04:12:00	Notice	opnsense	AcmeClient: certificate must be issued/renewed: [***]
2022-08-28T20:51:53	Notice	php	(system local trust) skip intermediate certificate /C=US/O=Internet Security Research Group/CN=ISRG Root X1 from R3 (ACME Client)
2022-08-28T20:51:53	Notice	php	(system local trust) skip intermediate certificate /C=US/O=Let's Encrypt/CN=R3 from R3 (ACME Client)
2022-08-28T04:12:00	Notice	opnsense	AcmeClient: issue/renewal not required for certificate: [***]
2022-08-27T04:12:00	Notice	opnsense	AcmeClient: issue/renewal not required for certificate: [***]

ACME Log
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Deploy error.
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Error deploy for domain:[***]
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] SYNO_Username & SYNO_Password must be set
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Installing full chain to: /var/etc/acme-client/certs/[***].[***]/fullchain.pem
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Installing key to: /var/etc/acme-client/keys/[***].[***]/private.key
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Installing CA to: /var/etc/acme-client/certs/[***].[***]/chain.pem
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Installing cert to: /var/etc/acme-client/certs/[***].[***]/cert.pem
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] And the full chain certs is there: /var/etc/acme-client/home/[***]/fullchain.cer
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] The intermediate CA cert is in: /var/etc/acme-client/home/[***]/ca.cer
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Your cert key is in: /var/etc/acme-client/home/[***]/[***].key
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Your cert is in: /var/etc/acme-client/home/[***]/[***].cer
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:29 CEST 2022] Cert success.
2022-08-29T04:14:29	acme.sh	[Mon Aug 29 04:14:28 CEST 2022] Le_LinkCert='https://acme-v02.api.letsencrypt.org/acme/cert/[***]'
2022-08-29T04:14:28	acme.sh	[Mon Aug 29 04:14:28 CEST 2022] Downloading cert.
2022-08-29T04:14:27	acme.sh	[Mon Aug 29 04:14:27 CEST 2022] Le_OrderFinalize='https://acme-v02.api.letsencrypt.org/acme/finalize/[***]/[***]'
2022-08-29T04:14:27	acme.sh	[Mon Aug 29 04:14:27 CEST 2022] Lets finalize the order.
2022-08-29T04:14:27	acme.sh	[Mon Aug 29 04:14:27 CEST 2022] Verify finished, start to sign.
2022-08-29T04:14:27	acme.sh	[Mon Aug 29 04:14:27 CEST 2022] Removed: Success
2022-08-29T04:14:25	acme.sh	[Mon Aug 29 04:14:25 CEST 2022] Deleting record
2022-08-29T04:14:24	acme.sh	[Mon Aug 29 04:14:24 CEST 2022] Removing txt: [***] for domain: _acme-challenge.[***]
2022-08-29T04:14:24	acme.sh	[Mon Aug 29 04:14:24 CEST 2022] Removed: Success
2022-08-29T04:14:22	acme.sh	[Mon Aug 29 04:14:22 CEST 2022] Deleting record
2022-08-29T04:14:20	acme.sh	[Mon Aug 29 04:14:20 CEST 2022] Removing txt: [***] for domain: _acme-challenge.[***]
2022-08-29T04:14:20	acme.sh	[Mon Aug 29 04:14:20 CEST 2022] Removing DNS records.
2022-08-29T04:14:20	acme.sh	[Mon Aug 29 04:14:20 CEST 2022] Success
2022-08-29T04:14:18	acme.sh	[Mon Aug 29 04:14:18 CEST 2022] Pending, The CA is processing your order, please just wait. (1/30)
2022-08-29T04:14:17	acme.sh	[Mon Aug 29 04:14:17 CEST 2022] Verifying: [***]
2022-08-29T04:14:17	acme.sh	[Mon Aug 29 04:14:17 CEST 2022] Success
2022-08-29T04:14:15	acme.sh	[Mon Aug 29 04:14:15 CEST 2022] Pending, The CA is processing your order, please just wait. (1/30)
2022-08-29T04:14:13	acme.sh	[Mon Aug 29 04:14:13 CEST 2022] It seems the CA server is busy now, let's wait and retry. Sleeping 1 seconds.
2022-08-29T04:14:12	acme.sh	[Mon Aug 29 04:14:12 CEST 2022] Verifying: [***]
2022-08-29T04:12:12	acme.sh	[Mon Aug 29 04:12:12 CEST 2022] Sleep 120 seconds for the txt records to take effect
2022-08-29T04:12:12	acme.sh	[Mon Aug 29 04:12:12 CEST 2022] The txt record is added: Success.
2022-08-29T04:12:10	acme.sh	[Mon Aug 29 04:12:10 CEST 2022] Adding record
2022-08-29T04:12:10	acme.sh	[Mon Aug 29 04:12:10 CEST 2022] Adding txt value: [***] for domain: _acme-challenge.[***]
2022-08-29T04:12:10	acme.sh	[Mon Aug 29 04:12:10 CEST 2022] The txt record is added: Success.
2022-08-29T04:12:05	acme.sh	[Mon Aug 29 04:12:05 CEST 2022] Adding record
2022-08-29T04:12:04	acme.sh	[Mon Aug 29 04:12:04 CEST 2022] Adding txt value: [***] for domain: _acme-challenge.[***]
2022-08-29T04:12:04	acme.sh	[Mon Aug 29 04:12:04 CEST 2022] Getting webroot for domain='[***]'
2022-08-29T04:12:04	acme.sh	[Mon Aug 29 04:12:04 CEST 2022] Getting webroot for domain='[***]'
2022-08-29T04:12:02	acme.sh	[Mon Aug 29 04:12:01 CEST 2022] Getting domain auth token for each domain
2022-08-29T04:12:01	acme.sh	[Mon Aug 29 04:12:01 CEST 2022] Multi domain='DNS:[***],DNS:[***]'
2022-08-29T04:12:01	acme.sh	[Mon Aug 29 04:12:01 CEST 2022] Using CA: https://acme-v02.api.letsencrypt.org/directory
2022-08-29T04:12:00	acme.sh	[Mon Aug 29 04:12:00 CEST 2022] Renew: '[***]'

Additional context
None
Environment
now: OPNsense 22.7.4-amd64
at the time of the error: OPNsense 22.7.2-amd64

Thanks for reporting this issue!
acme.sh saves the previously used deploy hook in it's own configuration files and uses these recorded deploy hooks on it's next run. Of course, this is not what we want.
I've modified the plugin to remove Le_DeployHook= from all .conf files after running a deploy hook. A debug message is also logged. This should automatically solve the issue where the certificate state gets stuck.
I've tested multiple configurations and the deploy hook was reliably removed from acme.sh's config files.
Since this cleanup is only done after running a deploy hook, you may have to (manually) run the automation once in order to clear the saved deploy hook from acme.sh's configuration file.
The patch may be tested like this:
opnsense-patch -c plugins c3b6d586

(The patch is part of a larger changeset, so I'm not sure that it applies cleanly.)


alpah08 - ipad pro :  do not record anything :-(

Your Environment

Plugin version: alpha 8

Platform: iOS

OS version: 9.3

Device manufacturer and model: ipad pro

Cordova version (cordova -v): 5.x

Cordova platform version (cordova platform ls):

Plugin configuration options:
var optionsBackgroundDev = {
desiredAccuracy:    0,          // Possible values [0, 10, 100, 1000].
stationaryRadius:   1,          // Stationary radius in meters. When stopped,
// the minimum distance the device must move beyond the stationary location for aggressive background-tracking to engage.
debug:              false,
distanceFilter:     1,          // The minimum distance (measured in meters) a device must move horizontally before an update event is generated
stopOnTerminate:    false,      // Enable this in order to force a stop()
// when the application terminated (e.g. on iOS, double-tap home button, swipe away the app). (default true)
// ANDROID
startOnBoot:        true,
startForeground:    true,
interval:           4000,
fastestInterval:    4000,
locationProvider:   backgroundGeolocation.provider.ANDROID_ACTIVITY_PROVIDER,
activitiesInterval: 4000,
stopOnStillActivity: false,
              // IOS
              activityType:       'Other',
              saveBatteryOnBackground: false,
              pauseLocationUpdates: false,

              // add the version it might be the pb
              version: "1.1.0",

              // those can not be modified - android notification

              notificationTitle:  "Position recording",
              notificationText:   "Battery friendly recording",
              notificationIconColor: '#ff4081',
              notificationIconLarge: 'icon_48_48',
              notificationIconSmall: 'mappointer_small',

              // URL RECORDING

              //maxLocations:100,
              url:baseUrl+'rawgeo?normal=1&userId='+_self.getUserIdToRecord(),
              syncUrl:baseUrl+'rawgeo?offline=1&userId='+_self.getUserIdToRecord(),
              // deprecated
              httpHeaders: { 'X-USER': _self.getUserIdToRecord() },
              //
              maxLocations: 100,
              syncThreshold: 10,
          };

Link to your project:

Context
starting the plugin, stationary.
I have checked that location is enabled I have the small icon on the top right of the device.
The same code running on the simulator did not produce any issue :(
The location settings is : Always I have tried also while using, same error
Expected Behavior
no error
Context

Debug logs
2016-09-14 11:24:11.333 Mydelivery Driver[341:47001] DiskCookieStorage changing policy from 2 to 0, cookie file: file:///private/var/mobile/Containers/Data/Application/B636752A-5407-414B-B07C-1F719A24E392/Library/Cookies/Cookies.binarycookies
2016-09-14 11:24:11.408 Mydelivery Driver[341:47001] Apache Cordova native platform version 4.1.0 is starting.
2016-09-14 11:24:11.408 Mydelivery Driver[341:47001] Multi-tasking -> Device: YES, App: YES
2016-09-14 11:24:11.460 Mydelivery Driver[341:47001] Using WKWebView
2016-09-14 11:24:11.460 Mydelivery Driver[341:47001] [CDVTimer][handleopenurl] 0.048995ms
2016-09-14 11:24:11.462 Mydelivery Driver[341:47001] [CDVTimer][intentandnavigationfilter] 1.370013ms
2016-09-14 11:24:11.462 Mydelivery Driver[341:47001] [CDVTimer][gesturehandler] 0.051975ms
2016-09-14 11:24:11.514 Mydelivery Driver[341:47001] Serving asset bundle version: a8feb266d733bd600511eb7d198119c35395361a
[INFO] GCDWebServer started on port 12496 and reachable at http://localhost:12496/
2016-09-14 11:24:11.515 Mydelivery Driver[341:47001] [CDVTimer][webapplocalserver] 53.530037ms
2016-09-14 11:24:11.525 Mydelivery Driver[341:47001] [CDVTimer][statusbar] 9.514987ms
2016-09-14 11:24:11.549 Mydelivery Driver[341:47001] [CDVTimer][splashscreen] 23.597002ms
2016-09-14 11:24:11.570 Mydelivery Driver[341:47001] [CDVTimer][backgroundgeolocation] 20.833015ms
2016-09-14 11:24:11:569 Mydelivery Driver[341:47001] LocationManager iOS9 detected
2016-09-14 11:24:11.573 Mydelivery Driver[341:47001] [CDVTimer][keyboard] 3.112972ms
2016-09-14 11:24:11.574 Mydelivery Driver[341:47001] [CDVTimer][localstorage] 0.536025ms
2016-09-14 11:24:11.574 Mydelivery Driver[341:47001] [CDVTimer][TotalPluginStartup] 113.664031ms
2016-09-14 11:24:12:016 Mydelivery Driver[341:47001] LocationManager didChangeAuthorizationStatus 0
2016-09-14 11:24:43:916 Mydelivery Driver[341:47308] LocationManager stop
2016-09-14 11:24:43.920 Mydelivery Driver[341:47283] DB Error: 1 "no such table: __META"
2016-09-14 11:24:43.920 Mydelivery Driver[341:47283] DB Query: SELECT db_version FROM __META
2016-09-14 11:24:43.920 Mydelivery Driver[341:47283] DB Path: /var/mobile/Containers/Data/Application/B636752A-5407-414B-B07C-1F719A24E392/Library/cordova_bg_geolocation.db
2016-09-14 11:24:43.935 Mydelivery Driver[341:47283] INSERT INTO __META (id,db_version,created,last_updated) VALUES (1,0,datetime(),null) failed code: 0: message: not an error
2016-09-14 11:24:43.936 Mydelivery Driver[341:47283] Current db version: 0
2016-09-14 11:24:43.936 Mydelivery Driver[341:47283] Error inserting batch: no such table: location
2016-09-14 11:24:43.936 Mydelivery Driver[341:47283] DROP TABLE location failed code: 1: message: no such table: location
2016-09-14 11:24:44.425 Mydelivery Driver[341:47001] THREAD WARNING: ['GoogleMaps'] took '350.446777' ms. Plugin should use a background thread.
2016-09-14 11:27:20:664 Mydelivery Driver[341:47001] LocationManager didChangeAuthorizationStatus 4
[INFO] GCDWebServer stopped
2016-09-14 11:27:29:071 Mydelivery Driver[341:47001] CDVBackgroundGeoLocation paused
2016-09-14 11:27:29:071 Mydelivery Driver[341:47001] LocationManager switchMode 0
[INFO] GCDWebServer started on port 12496 and reachable at http://localhost:12496/
2016-09-14 11:27:37:964 Mydelivery Driver[341:47001] CDVBackgroundGeoLocation resumed
2016-09-14 11:27:37:964 Mydelivery Driver[341:47001] LocationManager switchMode 1
2016-09-14 11:27:42:127 Mydelivery Driver[341:47933] LocationManager will start: 0
2016-09-14 11:27:42:127 Mydelivery Driver[341:47933] LocationManager switchMode 1
2016-09-14 11:27:42:135 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 1)
2016-09-14 11:27:42:135 Mydelivery Driver[341:47001] Location age 12.378579
2016-09-14 11:27:44:766 Mydelivery Driver[341:47001] LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
2016-09-14 11:27:44:782 Mydelivery Driver[341:47581] CDVBackgroundGeolocation onError
2016-09-14 11:27:44.793 Mydelivery Driver[341:47581] Invalid callback id received by sendPluginResult
2016-09-14 11:32:21:245 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 1)
2016-09-14 11:32:21.250 Mydelivery Driver[341:48764] Invalid callback id received by sendPluginResult
2016-09-14 11:32:21:245 Mydelivery Driver[341:47001] Location age 0.018994
2016-09-14 11:32:21:246 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:247 Mydelivery Driver[341:47001] LocationManager queue Location: id=0 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:249 Mydelivery Driver[341:47001] LocationManager#sync Location: id=-5764607523034234861 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:250 Mydelivery Driver[341:48764] CDVBackgroundGeolocation onLocationChanged
2016-09-14 11:32:21:271 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 1)
2016-09-14 11:32:21:271 Mydelivery Driver[341:47001] Location age 0.011527
2016-09-14 11:32:21:271 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5780291392 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:271 Mydelivery Driver[341:47001] LocationManager queue Location: id=0 time=5780291392 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:276 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 1)
2016-09-14 11:32:21:276 Mydelivery Driver[341:47001] Location age 0.010347
2016-09-14 11:32:21:277 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5827111616 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:21:277 Mydelivery Driver[341:47001] LocationManager queue Location: id=0 time=5827111616 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[INFO] GCDWebServer stopped
2016-09-14 11:32:23:468 Mydelivery Driver[341:47001] CDVBackgroundGeoLocation paused
2016-09-14 11:32:23:468 Mydelivery Driver[341:47001] LocationManager switchMode 0
2016-09-14 11:32:24:603 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 0)
2016-09-14 11:32:24:604 Mydelivery Driver[341:47001] Location age 1.120436
2016-09-14 11:32:24:606 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5828182416 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
2016-09-14 11:32:24:608 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 0)
2016-09-14 11:32:24:608 Mydelivery Driver[341:47001] Location age 1.125266
2016-09-14 11:32:24:609 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5761364656 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[INFO] GCDWebServer started on port 12496 and reachable at http://localhost:12496/
2016-09-14 11:32:32:177 Mydelivery Driver[341:47001] CDVBackgroundGeoLocation resumed
2016-09-14 11:32:32:177 Mydelivery Driver[341:47001] LocationManager switchMode 1
2016-09-14 11:32:32:199 Mydelivery Driver[341:47001] LocationManager didUpdateLocations (operationMode: 1)
2016-09-14 11:32:32:199 Mydelivery Driver[341:47001] Location age 1.972412
2016-09-14 11:32:32:199 Mydelivery Driver[341:47001] Better location found: Location: id=0 time=5780044048 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
The log from the js console :
[Log] [2016/09/14 11:39:09] :CDVBackgroundGeolocation onError
[2016/09/14 11:39:09] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:39:09] :LocationManager switchMode 1
[2016/09/14 11:39:09] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:38:03] :CDVBackgroundGeolocation onError
[2016/09/14 11:38:03] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:38:03] :Better location found: Location: id=0 time=5889208256 lat=13.69329592834367 lon=100.6209972772992 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.2966585457324982 type=current
[2016/09/14 11:38:03] :Location age 27.978216
[2016/09/14 11:38:03] :LocationManager didUpdateLocations (operationMode: 0)
[2016/09/14 11:38:02] :LocationManager switchMode 0
[2016/09/14 11:38:02] :CDVBackgroundGeoLocation paused
[2016/09/14 11:37:50] :CDVBackgroundGeolocation onError
[2016/09/14 11:37:50] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:37:30] :Better location found: Location: id=0 time=5912125568 lat=13.69329592834367 lon=100.6209972772992 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.2966585457324982 type=current
[2016/09/14 11:37:30] :Location age 0.006802
[2016/09/14 11:37:30] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:37:30] :Location age 0.006380
[2016/09/14 11:37:30] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:37:30] :LocationManager switchMode 1
[2016/09/14 11:37:30] :LocationManager will start: 0
[2016/09/14 11:37:26] :LocationManager switchMode 1
[2016/09/14 11:37:26] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:37:21] :LocationManager switchMode 0
[2016/09/14 11:37:21] :CDVBackgroundGeoLocation paused
[2016/09/14 11:37:09] :LocationManager didChangeAuthorizationStatus 3
[2016/09/14 11:37:09] :LocationManager iOS9 detected
[2016/09/14 11:36:38] :CDVBackgroundGeolocation onError
[2016/09/14 11:36:38] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:36:38] :LocationManager switchMode 1
[2016/09/14 11:36:38] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:36:29] :LocationManager didChangeAuthorizationStatus 3
[2016/09/14 11:36:12] :Location age 222.301332
[2016/09/14 11:36:12] :LocationManager didUpdateLocations (operationMode: 0)
[2016/09/14 11:36:03] :CDVBackgroundGeolocation onError
[2016/09/14 11:36:03] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:36:02] :LocationManager switchMode 0
[2016/09/14 11:36:02] :CDVBackgroundGeoLocation paused
[2016/09/14 11:35:55] :CDVBackgroundGeolocation onError
[2016/09/14 11:35:55] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:35:55] :Location age 204.924406
[2016/09/14 11:35:55] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:35:55] :LocationManager switchMode 1
[2016/09/14 11:35:55] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:35:54] :Location age 203.865014
[2016/09/14 11:35:54] :LocationManager didUpdateLocations (operationMode: 0)
[2016/09/14 11:35:44] :CDVBackgroundGeolocation onError
[2016/09/14 11:35:44] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:35:44] :LocationManager switchMode 0
[2016/09/14 11:35:44] :CDVBackgroundGeoLocation paused
[2016/09/14 11:34:38] :LocationManager will start: 1
[2016/09/14 11:32:45] :CDVBackgroundGeolocation onError
[2016/09/14 11:32:45] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:32:32] :Better location found: Location: id=0 time=5780044048 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:32] :Location age 1.972412
[2016/09/14 11:32:32] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:32:32] :LocationManager switchMode 1
[2016/09/14 11:32:32] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:32:24] :Better location found: Location: id=0 time=5761364656 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:24] :Location age 1.125266
[2016/09/14 11:32:24] :LocationManager didUpdateLocations (operationMode: 0)
[2016/09/14 11:32:24] :Better location found: Location: id=0 time=5828182416 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:24] :Location age 1.120436
[2016/09/14 11:32:24] :LocationManager didUpdateLocations (operationMode: 0)
[2016/09/14 11:32:23] :LocationManager switchMode 0
[2016/09/14 11:32:23] :CDVBackgroundGeoLocation paused
[2016/09/14 11:32:21] :LocationManager queue Location: id=0 time=5827111616 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Better location found: Location: id=0 time=5827111616 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Location age 0.010347
[2016/09/14 11:32:21] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:32:21] :LocationManager queue Location: id=0 time=5780291392 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Better location found: Location: id=0 time=5780291392 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Location age 0.011527
[2016/09/14 11:32:21] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:32:21] :CDVBackgroundGeolocation onLocationChanged
[2016/09/14 11:32:21] :LocationManager#sync Location: id=-5764607523034234861 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :LocationManager queue Location: id=0 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Better location found: Location: id=0 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current
[2016/09/14 11:32:21] :Location age 0.018994
[2016/09/14 11:32:21] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:27:44] :CDVBackgroundGeolocation onError
[2016/09/14 11:27:44] :LocationManager didFailWithError: Error Domain=kCLErrorDomain Code=0 "(null)"
[2016/09/14 11:27:42] :Location age 12.378579
[2016/09/14 11:27:42] :LocationManager didUpdateLocations (operationMode: 1)
[2016/09/14 11:27:42] :LocationManager switchMode 1
[2016/09/14 11:27:42] :LocationManager will start: 0
[2016/09/14 11:27:37] :LocationManager switchMode 1
[2016/09/14 11:27:37] :CDVBackgroundGeoLocation resumed
[2016/09/14 11:27:29] :LocationManager switchMode 0
[2016/09/14 11:27:29] :CDVBackgroundGeoLocation paused
[2016/09/14 11:27:20] :LocationManager didChangeAuthorizationStatus 4
[2016/09/14 11:24:43] :LocationManager stop
[2016/09/14 11:24:12] :LocationManager didChangeAuthorizationStatus 0
[2016/09/14 11:24:11] :LocationManager iOS9 detected

kindly tell me if I can do any test to help to fix this issue best regards

I have also tried the commit link to the pull request  (pauseLocationUpdates) but no luck either

2016-09-14 11:27:44.793 Mydelivery Driver[341:47581] Invalid callback id received by sendPluginResult

how do you setup callbacks?

From log, I can see plugin is posting locations to options.url right? You only missing js callbacks?
LocationManager#sync Location: id=-5764607523034234861 time=5827870864 lat=13.69331879317069 lon=100.6210306023086 accu=65 aaccu=10 speed=-1 bear=-1 alt=-0.09017550200223923 type=current

Nothing was received server side, it was a really strange behaviour.
Let me try with the new version

uninstall app before upgrade

I can not reproduce, so closing this one :-)


Implement an ID2D1RenderTarget-backed CGContext

There are wide swaths of code wrapped in #if 0 ... #endif blocks; they will be removed and repaired as part of the ongoing work on this branch.
Issues have been logged for many TODOs, but the rest will be removed as part of the ongoing work on this branch.
Currently broken:

path rendering
shadow
transparency layers
bitmap contexts that are not CALayer contexts
font rendering is left in CGContextCairo.mm and will be moved

This pull request is intended to unblock parallel work on CG/Direct2D.

Many things are marked Interoperable in this pull request that are not. It does not seem like a good time investment to fix them when they're going to keep changing.

@ms-jihua is added to the review. #Closed

@MSFTFox is added to the review. #Closed

@bbowman is added to the review. #Closed

You've been showing us a lot of really awesome stuff in your sample app, will those changes be checked in?

Not yet, but in a future commit.   CGIWICBitmap does the locking when necessary.

Refers to: Frameworks/CoreGraphics/CGBitmapImage.mm:452 in a481d28. [](commit_id = a481d2835e1262037fc015477c9f0552a4fc80ee, deletion_comment = False)

:clock1:

    BYTE* imageData = static_cast<BYTE*>(LockImageData());

This will also go away soon :)

In reply to: 253094039 [](ancestors = 253094039)

Refers to: Frameworks/CoreGraphics/CGBitmapImage.mm:452 in a481d28. [](commit_id = a481d2835e1262037fc015477c9f0552a4fc80ee, deletion_comment = False)

@jaredhms is added to the review. #Closed

@shahmeeresmail is added to the review. #Closed

:shipit:


[Feat]: Allowing generic HLS video URL to play

Version
v1.0.1
Environment that reproduces the issue
Device: OnePlus 8 PRO, OS: Android 12
Use case description
Right now we can play video only with videoID. But the generic video can't be played.
Proposed solution
Allow to play generic HLS url instead of only playing by videoID. We can use the playerUrl of ApiVideoPlayer
import {Button, View} from "react-native";
import ApiVideoPlayer from<EMAIL_ADDRESS>import * as React from "react";

const PlayHLSStream = (props: any) => {
    const player = React.useRef(undefined as ApiVideoPlayer);

    return (
        <View style={{ flex: 1 }}>
            <ApiVideoPlayer
                ref={(r) => (player.current = r)}
                muted={true}
                videoId="vi2G6Qr8ZVE67dWLNymk7qbc"
            />

            <Button
                onPress={() => {
                    player.current.playerUrl = "http://<IP_ADDRESS>:7002/live/abcd.m3u8"
                    player.current.play() }
                }
                title="Play"
            />
            <Button onPress={() => player.current.pause()} title="Pause" />
        </View>
    )
}

export default PlayHLSStream;

Alternative solutions
No response

Hi @tinkalgogoi,
We have not planned that for now. If we decide to do so in the future, we will let you know.
Regards


Bug: the-way cmd + tmux duplicates the input

To reproduce:

run the-way cmd in tmux session
ctrl+v/command+v to insert command

OS: macOS 14.1.1 (23B81)
the-way: 0.19.2
tmux: 3.3a
https://github.com/out-of-cheese-error/the-way/assets/1178208/c87e2dbe-81b8-4922-abbc-83937a862fec

As far as I understand, the project is unmaintained.


Task: Make Rate Limits Configurable

Description
#47 introduces basic token bucket rate limiting, with two parameters:

call_count: the number of calls allowed during one period
call_frequency: the period at which each peer's call count is refreshed

People running LNDK may want to toggle these values to allow more/less onion messages.
Steps to Complete

Add rate_limit_count and rate_limit_period to configure_me config

Notes

The original default values are arbitrarily chosen (10 messages / second), this task could change them if desired (probably increase, once folks have the knobs to lower them)

i would love to take this on if no one is assigned @carlaKC

Have at it!

I'll take this.
I have been looking into #56, but it seemed this should be finished before.


Virtual Scroll: Can't remove or hide an item in virtual scroll without reset virtual scroll

Short description of the problem:
It is not possible to remove or hide a virtual scroll item without refreshing virtual scroll and losing scroll position.
I tried the following solutions:

splice on datasource => reset the virtual scroll, lost scroll position, but item disappears (no blank space)
hiding item, [hidden]='true' => the next item does not go up in the list (so there is a blank space)
display:none; => the next item does not go up in the list (so there is a blank space)

What behavior are you expecting?
To be able to remove or hide an item in the virtual scroll:

Maintain the position of the scroll (thus without refreshing the virtual scroll?)
Visually: The space of the object must be removed.

The goal is to remove / hide an item in the list, without losing the position in the scroll.
Ionic V2 beta 9
Plunker (the virtual scroll has display problem in the plunker, Thank you not to consider):
http://plnkr.co/edit/drNjfw?p=preview
Cordova CLI: 6.2.0
Gulp version:  CLI version 1.2.0
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.9
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
OS:
Node Version: v4.4.5

I guess the "translate3d" on the list item are the source of the problem (eg: transform: translate3d(0px, 230px, 0px);).
Is the solution would be to recalculate the translate3d for each items in the viewport?

Perhaps, a property "hide" on the virtual item to hide it, and recalculate the position of following items in the list (I know it's not easy)

Is there any chance that it will be included in a future release?
If it is not possible, I will have to use an alternative to the virtual scroll.
Thanks for letting me know.

Related to https://github.com/driftyco/ionic/issues/6423

Hello everyone! Thanks for using Ionic! We have been hard at work lately with virtualscroll. The issue here is that when you update the virtualscroll with data after it has already been rendered the measurements that virtual scroll uses to lazily render elements then become wrong. When this happens the virtual scroll has to re-render itself entirely, therefore making it look like it has jumped back to the beginning of the list. We are well aware of this issue and hope to have a solution for it soon. Also, just to keep our issues concise and not have duplicates  I am going to close this one as a duplicate of https://github.com/driftyco/ionic/issues/6423 . You can track the status of this issue over on that issue. Also, feel free to put any findings you may have on that issue. Thanks again everyone!


Template.njk contains inline script tag

We are looking to add a Content Security Policy to our application, but are currently unable to do so without specifying the unsafe-inline policy, due to the inline script tag in template.njk which adds the js-enabled class to the body.
Could this instead be part of the GOVUKFrontend.initAll function to avoid having an inline script?

Found this issue and have added the sha hash to our CSP

Hi Chris,
Thanks for raising this. I'm going to re-open your issue and stick a triage label on it for our team to discuss, as I think we should provide better documentation around this so you don't have to go digging through past issues to find the solution!

To resolve this, we’re going to:

document the recommendation that teams allow the hash of the inline script tag in their CSP under JavaScript in GOV.UK Frontend developer docs
treat any changes to the hash as a breaking change
add a test to GOV.UK Frontend to check that the script tag hasn’t changed and if it does, what to do about it

This approach seems low risk since we’re not introducing any breaking changes, and we don’t expect the script tag to change much, if ever, so the hash should stay fairly static over time.
We could in the future consider supporting nonces if we had evidence that it would be useful to teams.
We also considered publishing the hash in a file in the GOV.UK Frontend npm package but at the moment it isn’t clear how doing so would benefit teams.

Resolved by https://github.com/alphagov/govuk-frontend-docs/pull/70


Make this plugin available in 5.x

This plugin is currently unavailable in logstash 5.x
Are there any known limitations ?

it looks like you can install it with the logstash plugin command, but I am wondering why this plugin isn't included by default. This means a simple deb/rpm upgrade will break existing installations.

funny enough the gelf input plugin is included by default
@jordansissel please advice

Using the plugin install it fails because it detected it from here and the base logstash gem version is too low
Sent from my mobile. Please excuse brevity and/or spelling.

On 10 Dec 2016, at 11:11, runningman84<EMAIL_ADDRESS>wrote:
funny enough the gelf input plugin is included by default
@jordansissel please advice
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

tried again with the latest logstash (5.1.1) and it seems to work just fine
# logstash -V
logstash 5.1.1
# logstash-plugin install logstash-output-gelf
Validating logstash-output-gelf
Installing logstash-output-gelf
Installation successful

I'm not able to install it on v 5.1.1 having the same issue with logstash-core-event-java
C:\logstash\5.1.1\bin>logstash -V
logstash 5.1.1
jruby 1.7.25 (1.9.3p551) 2016-04-13 867cb81 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_65-b17 +jit [Windows 7-amd64]
java 1.8.0_65 (Oracle Corporation)
jvm Java HotSpot(TM) 64-Bit Server VM / 25.65-b01

C:\logstash\5.1.1\bin>logstash-plugin.bat install logstash-output-gelf
Validating logstash-output-gelf
Installing logstash-output-gelf
Error Bundler::InstallError, retrying 1/10
An error occurred while installing logstash-core-event-java (5.1.1), and Bundler cannot continue.
Make sure that `gem install logstash-core-event-java -v '5.1.1'` succeeds before bundling.
WARNING: SSLSocket#session= is not supported


Created Unit Test cases for Parent - Login, Register, ClickBoard

Few file missing -
In shapes, Adapters, and XML please check once
Ignore, version updates that were only done so that it could resolve the errors on my laptop. Only take them if they seem right

it has a conflict


Issues with Energy Equation Module

A lot of these issues come up throughout the modules, so I'm just going to describe them in the context of this one module (at least for now), but you should go over these for all the modules and make the changes where relevant.

[x] In the Exported Access Programs table, the In and Out columns should only include the types of the values, not their names.
[x] Since this module has no state variables, there can't be a transition from any of its module (these should be outputs).
[x] This new output can be specified a lot more compactly: $\text{out} := \langle i \in \mathbb{N}, 0 \leq i < |\text{temp}| ~|~ m_f c_f (\text{temp}[i] - T_\text{init}) \rangle, \text{ where } m_f = \dots$

This may not be exactly right, and you may want to represent it slightly differently, but steps 2 to 5 can for sure be represented in one expression.
I'm also not sure if you need the local function at all; you may just be able to represent $m_f$ and $c_f$ like so, although you might want to double check with @smiths.

[ ] If you decide to keep it, local functions are defined with slightly different notation and should include their type information. (See here for an example).

[x] There are some grammatical/consistency issues with the Description column; I'm not sure if this column is even needed, since this information can be deduced from the expressions themselves.
[x] The next module (the Input Format Module) should start on a new page.

I prefer to keep local function. Also, I prefer to keep description column for better understanding of the error message. I'll try to reduce the grammatical mistakes. 😅