Do not write absolute file paths to file

Fixes #96

Based on all our discussions:
save(filepath=None, recurse=False) (default)
- Save in it's (absolute) original place, or filepath is given (which then mutates)
- filepath can also be set directly beforehand (!)
save(filepath=None, recurse=True)
- Save itself and all its children
- Children are saved relative to parent (can result in weird layout if self is not the original root)
- Absolute paths do not change
- If filepath is given, it mutates the state beforehand
export(folder)
- non mutating move, self contained
- overrules relative/absolute paths
- requires default relative paths
Some thought need to be given to how relative/absolute filepaths work, and when these are mutated.

I have created issue #170 to address the export functionality. Given the size of this issue I believe this should not be done now.
There are some functionality choices which need to be made (@arthurvd), with the chosen approach:

When do we set the internal absolute_filepath?
Given a model with some relative filepath and some previously saved absolute_filepath how do we resolve the relative filepath?

Given the description by @evetion, I believe the best course of action would be to have a private attribute for the last read absolute path. We can then use this path to resolve some of the relative paths. This does however require some choices to be made, both stemming from the fact that we do not know where the models are in the FileModel hierarchy:
When do we synchronise/store the absolute file paths of all the models.
We resolve the absolute filepaths when we first initialise a  FileModel and when we perform a recursive save. We could update the filepath field of all FileModel objects in the hierarchy at these two points. However, it is impossible to know, given the current structure, whether the entry point is a child in the model hierarchy, or the root.
As such this could potentially lead to weird behaviour:
If we are dealing with a FMModel with pathsrelativetoparent set to False, we can no longer assume the paths in a sub model are relative to the direct parent. As such, saving a sub model like the external forcings might result in the forcing files saved in a wrong directory.  Furthermore, if we subsequently store these forcings file, they will also be stored in these wrong locations (as the absolute path was updated during the recursive save of the external forcings file).
How do we resolve the paths stored in the filepath of a (sub)model.
There are two problems regarding resolving the paths stored in the filepath:

How do we resolve a relative path in respect to the absolute path
We cannot save the actual root model with a relative path

Because we do not know whether a model is the root model or a sub model, if a model has a relative path, we need to use the stored absolute path to resolve it. This means that we cannot save a root model with a relative path in regards to the current working directory anymore. As such, it is the users responsibility to have set an absolute path for the root model. This needs to be explicitly documented
If we do encounter a relative path, for example when we save a sub model, we need to resolve it. There are a few options for this:

We always use the stored internal absolute path, ignoring any changes to the filepath in the model
We resolve the relative path by appending it to the parent of the absolute path
We try and find the respective root from which we resolve by verifying if the first parts of the relative path match the last parts of the absolute path

These have respectively the following problems:

Changes to the filepath are ignored, and the user has no way of controlling where we exactly save, unless the filepath is set to some absolute path.
If we have the relative path ./ext/forcings.ext which might be saved at some location D:\model\ext\forcings.ext, calling save on this model would lead to the external forcings file being saved in D:\model\ext\ext\forcings.ext
The previous problem would not occur, however if we were to change the sub folder, e.g. to ./ext_other/forcings.ext, the model would still be saved in the D:\model\ext\ext_other\forcings.ext location.

This requires a functional choice, which needs to be clearly documented.


Implement AddrOf intrinsic

Optimizing out the unnecessary delegate allocation is tracked by https://github.com/dotnet/corert/issues/655

@MichalStrehovsky PTLA
cc @tijoytom

LGTM otherwise!


data race on bolt connection shutdown

Driver version: 5.12.0

Steps to reproduce

Expected behavior
driver does not trigger data races when running under go test -race

Actual behavior

we see regular (>50% of go test -race runs) data races in the neo4j driver connection shutdown code:
=== RUN   TestStartCleanup/with_zero_duration
==================
WARNING: DATA RACE
Read at 0x00c000602680 by goroutine 1848:
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).Close()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:928 +0xe6
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*server).removeIdleOlderThan.func1()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/server.go:192 +0x61

Previous write at 0x00c000602680 by goroutine 1847:
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).setError()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:205 +0x1ba
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).onIoError()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:1138 +0xc4
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).onIoError-fm()
      <autogenerated>:1 +0x64
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*outgoing).send()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/outgoing.go:263 +0x99
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*messageQueue).send()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/message_queue.go:134 +0x1b4
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).Close()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:931 +0x13c
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.closeAndEmptyConnections.func1()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/server.go:222 +0x61

Goroutine 1848 (running) created at:
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*server).removeIdleOlderThan()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/server.go:192 +0x464
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*Pool).removeIdleOlderThanOnServer()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/pool.go:385 +0x157
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*Pool).Return()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/pool.go:411 +0x395
  github.com/neo4j/neo4j-go-driver/v5/neo4j.(*sessionWithContext).Run()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/session_with_context.go:624 +0xca3
  github.com/overmindtech/revlink/revlink.DeleteExpiredEdges()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:152 +0x2f7
  github.com/overmindtech/revlink/revlink.cleanupAll()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:247 +0x479
  github.com/overmindtech/revlink/revlink.StartCleanup.func1()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:221 +0x1b2

Goroutine 1847 (finished) created at:
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.closeAndEmptyConnections()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/server.go:222 +0x1eb
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*server).startClosing()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/server.go:216 +0x32d
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*Pool).deactivate()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/pool.go:505 +0x298
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/pool.(*Pool).OnIoError()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/pool/pool.go:491 +0x5d
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).onIoError()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:1136 +0xa7
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).onIoError-fm()
      <autogenerated>:1 +0x64
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*outgoing).send()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/outgoing.go:263 +0x99
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*messageQueue).send()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/message_queue.go:134 +0x573
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).run()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:568 +0x4c5
  github.com/neo4j/neo4j-go-driver/v5/neo4j/internal/bolt.(*bolt5).Run()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/internal/bolt/bolt5.go:621 +0x2b4
  github.com/neo4j/neo4j-go-driver/v5/neo4j.(*sessionWithContext).Run()
      /home/runner/go/pkg/mod/github.com/neo4j/neo4j-go-driver/v5@v5.12.0/neo4j/session_with_context.go:604 +0x5b3
  github.com/overmindtech/revlink/revlink.DeleteExpiredEdges()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:152 +0x2f7
  github.com/overmindtech/revlink/revlink.cleanupAll()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:247 +0x479
  github.com/overmindtech/revlink/revlink.StartCleanup.func1()
      /home/runner/work/revlink/revlink/revlink/cleanup.go:221 +0x1b2
==================

The issue goes away when downgrading to v5.11.0.

Hi @DavidS-om, thank you. Just confirming that we're aware of some issues with data races (and issues running our unit tests with the -race flag enabled) and it's on our radar.

@StephenCathcart thanks for the message. As I wrote above, for now we've pinned to v5.11.0 and are not experiencing the issue, so it's not a burning issue. It only means that we're stuck on that version until this is fixed as updating completely breaks our internal testing.


Variable rename overlay has two titles and x's

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

go to variables tab in org settings
hover over variable and click rename
click i understand, lets rename

Expected behavior:
Describe what you expected to happen.
Actual behavior:

Environment info:
oss

Overlayception!!


why not add set cookie function on android

I would love to have this function too

would love to have this function too

Me2

would love to have this function too

me too
please add it

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.


SQL Scheduler UI

Summary of changes
👆
Note: this is a first version of the UI, that can for sure be improved. Tests will be done in a future PR.
Checklist

[x] Link to issue this PR refers to: https://github.com/crate/cloud/issues/1608
[x] Relevant changes are reflected in CHANGES.md.
[ ] Added or changed code is covered by tests.
[x] Required Grand Central APIs are already merged.

Many thanks for the review @SStorm. 💪 I should have fixed all the things we talked about. Let me know if you find any problem. 😄


Update python script from upstream and regenerate ps1 script

I've merged the python script with the upstream source and regenerated the ps1 script.

Thank you!


Checking if an element exists in the if statement, still shows ''Object is possibly 'undefined'"

Bug Report
I enabled noUncheckedIndexedAccess  in the tsconfig, but then I encountered some unintuitive behavior.
TypeScript shows an error about the object being possibly undefined, even though there is a check in the if statement.
🕗 Version & Regression Information
Tried every version available on TS Playground above version 4.1 (where the noUncheckedIndexedAccess was first introduced), and the error was the same for each version.
⏯ Playground Link
Playground link with relevant code
💻 Code
interface Key {
  id: number;
  color: string;
}

const state: {
  keys: Key[];
} = {
  keys: [
    { id: 0, color: '#aaaaaa' },
    { id: 1, color: '#bbbbbb' },
    { id: 2, color: '#cccccc' },
    { id: 3, color: '#dddddd' },
    { id: 4, color: '#eeeeee' },
    { id: 5, color: '#ffffff' },
  ],
};

const assignNewColorToKey = (keyId: number, color: string) => {
  const index = state.keys.findIndex((key) => key.id === keyId);
  if (index >= 0 && state.keys && state.keys[index])
    // error here
    state.keys[index].color = color;
};

🙁 Actual behavior
If statement had a check for the property, but still shows as possibly undefined.
🙂 Expected behavior
No undefined error should be thrown, because it was checked in the if statement.

Duplicate of #10530. Type narrowing does not occur for indexed access forms e[k] where k is not a literal.
Just store it in a variable (which IMO is much cleaner anyway).

state.keys[index] isn't narrowed because index is not a literal.  You can work around by first assigning it to a local and narrowing that:
const assignNewColorToKey = (keyId: number, color: string) => {
  const index = state.keys.findIndex((key) => key.id === keyId);
  const key = state.keys?.[index];
  if (index >= 0 && key)
    key.color = color;
};

Oops, got sniped by @MartinJohns 😅

Duplicate of #10530. Type narrowing does not occur for indexed access forms e[k] where k is not a literal.
Just store it in a variable (which IMO is much cleaner anyway).

Thank you for your quick answer!
I will do that, was just confused about the type narrowing.

state.keys[index] isn't narrowed because index is not a literal. You can work around by first assigning it to a local and narrowing that:
const assignNewColorToKey = (keyId: number, color: string) => {
  const index = state.keys.findIndex((key) => key.id === keyId);
  const key = state.keys?.[index];
  if (index >= 0 && key)
    key.color = color;
};

Thank you for the solution! I was confused why it didn't work 😅

btw this isn't directly related to the issue, but unless you actually need the index for something you could skip a step and just use .find().
  const key = state.keys?.find((key) => key.id === keyId);
  if (key) key.color = color;

btw this isn't directly related to the issue, but unless you actually need the index for something you could skip a step and just use .find().
  const key = state.keys?.find((key) => key.id === keyId);
  if (key) key.color = color;

My actual code is more complex, this was just a short version.
Yeah, this would work too and is even more concise 👍

TypeScript should never force you to change your code only because of its own limitations. What if adding that extra code is bad for performance? Or readability?
I'll disable noUncheckedIndexedAccess until this is fixed.

Why are people downvoting @Therealskythe 's comment? This seems quite reasonable to me.

The point of options is to be disabled if you don't like their behavior, so... go ahead and do that? It's basically saying "Why is 'dark blue' paint so dark? It's harder to see objects painted this color. I will get light blue paint until then". Yeah that's why there are multiple colors, so you can choose.

The point of options is to be disabled if you don't like their behavior, so... go ahead and do that? It's basically saying "Why is 'dark blue' paint so dark? It's harder to see objects painted this color. I will get light blue paint until then". Yeah that's why there are multiple colors, so you can choose.

No, it's like your paint brush forcing you to paint in red because it's bad at blue. It's a tool. It should not get in your way and make your result worse.


[YoutubeDL] Display video titles in formats list output (fixes issue #2035)

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[ x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[ x] Searched the bugtracker for similar pull requests
[ x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ x] Improvement
[ ] New extractor
[ ] New feature

Optionally display all video titles in the formats list output, using the standard dash or bracket notation - issue #2035.
Usage as:
$ yt-dlp --show-title -vF https://www.youtube.com/watch?v=9_dgIfz876A
Cheers and thank you!
Parmjit V.

Not needed.

Closing PR.


can't update transaction-atomicity  via configuration file

What did you do?
update transaction-atomicity from table to none
cdc cli changefeed update -c xxx --config cf.toml
[sink]
transaction-atomicity = "none"

What did you expect to see?
changefeed is started with  transaction-atomicity ="none"
What did you see instead?
changefeed is started with  transaction-atomicity ="table"
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
TiCDC version (execute cdc version):
(paste TiCDC version here)
bash-5.1# /cdc version
Release Version: v6.1.2
Git Commit Hash: ae5423d942837e377123b15f9da3fa72d9ca6007
Git Branch: heads/refs/tags/v6.1.2
UTC Build Time: 2022-10-13 15:54:32
Go Version: go version go1.18.5 linux/amd64
Failpoint Build: false

/assign

/severity minor


Multiline literals and enums should have trailing commas after the last item

When writing a multiline literal or enumeration, leave a trailing comma on the last item. When entries are added or removed, this eliminates the need to touch unrelated lines. This in turn makes for cleaner diffs: only the truly relevant lines of code must be changed, and the resulting pull request is easier to review.

When writing a multiline literal or enumeration, leave a trailing comma on the last item. When entries are added or removed, this eliminates the need to touch unrelated lines. This in turn makes for cleaner diffs: only the truly relevant lines of code must be changed, and the resulting pull request is easier to review.

Totally agree that it leads to cleaner diffs, however I do think it’s at a loss to clarity. Specifically, in English, a comma separated list of items doesn’t end with a comma, so this reads unnaturally. Also, someone reading the code later may well think something is unintentionally missing and got removed due to a bad merge. This may seem like a small point, but I do think it warrants a little bit of a harder to read diff.
More generally, since this is not standard in Apple’s sample code, in current NYTimes codebases (to my knowledge), nor in the industry, it would be a large effort to move a lot of developers in this direction, and I’m just not sure it’s worth it. But I’m just some guy on the internet.

I have never liked the practice myself, unless Chris and/or JC wish to come to my defense regarding method braces or == NO tests, in which case I love it.

Specifically, in English, a comma separated list of items doesn’t end with a comma, so this reads unnaturally.

A lot of code doesn't follow English grammatical rules. And we don't write—or compare—English prose with the tools we use to manage our code.*
While I agree that readable, clear code is the ultimate goal goal, the artifacts we deal with in producing that code (diffs, for example) should also be clear; clearer diffs help us produce better code.

Also, someone reading the code later may well think something is unintentionally missing and got removed due to a bad merge …

Not if we accept this style and begin making it commonplace.
And at least in the enum case, a bad merge is likely to result in compilation errors: you will notice if an enumeration case goes missing.

More generally, since this is not standard in Apple’s sample code…

Maybe not particularly common, but much of Apple's sample code is inconsistent enough I don't know that we can say this generally.

…in current NYTimes codebases (to my knowledge)…

This is correct.

…nor in the industry…

Again, I think "the industry" is widespread enough that it's hard to generalize. I have worked on large codebases where this style is common; that's how I picked up on it.

Totally agree that it leads to cleaner diffs, however I do think it’s at a loss to clarity.

I agree with the first part of the sentence :trollface: but for the reasons above I don't think it is any less clear to readers of the code, and I think it can ultimately help result in a cleaner codebase.

I fully realize we're having this discussion, about English prose, on GitHub. I argue that GitHub is not the ideal tool for collaborating on English, though it works decently; and further that in fact we do make concessions to git/GitHub/Markdown when we write and format English text in Markdown, in order to make commits, diffs, and rendering all easier.

I have never liked the practice myself, unless Chris and/or JC wish to come to my defense regarding method braces or == NO tests, in which case I love it.

Gotta love politics.

:+1: @cdzombak

The hanging comma leads to (a) a slightly more succinct diff; (b) one fewer misappropriated "blame" line—by not touching an existing enum line; and (c) a loss in conveying intent to a reader.
Reviewing a PRs happens once and the possible gain when reviewing a commit1..commit2 diff is marginal at best, so (a) does not have a lot of weight. When looking through the blame to see how and when an enum changed, (b) would be helpful, but this happens infrequently. Conveying intent to the reader of code is of utmost importance, so while (c) is minor, it will present itself much more often than a PR or diff/blame reviewing.
@cdzombak I have added this hanging comma many times myself. However, in order to support accepting this style into the guide, a + b >> c. It's not, so I can't.

(b) one fewer misappropriated "blame" line—by not touching an existing enum line;
…
(b) would be helpful, but this happens infrequently.

I hadn't even considered the implications for git blame! I use that heavily, mostly through Xcode's git integration, and it's immensely useful when exploring a codebase to be able to tell when and why a literal or enumeration changed.
Given that I often leave blame view turned on when using Xcode, I argue this isn't exactly infrequent, or that at worst this [in]frequency from programmer to programmer.

(c) a loss in conveying intent to a reader.

While the other arguments here (including my original ones!) are for the most part objective, this is just subjective, and I simply don't buy it; I don't find code written in this style less clear in intent than any other code.

I can't add anything that hasn't already been said, but just wanted to state my support for this PR.
Also, amen to @cdzombak :

A lot of code doesn't follow English grammatical rules. And we don't write—or compare—English prose with the tools we use to manage our code.1
While I agree that readable, clear code is the ultimate goal goal, the artifacts we deal with in producing that code (diffs, for example) should also be clear; clearer diffs help us produce better code.

As of https://github.com/cdzombak/objective-c-style-guide/commit/b34dae4bb1d69f47f4dd1b6aea88a3a164a73174 the proposed guideline now reads:

When writing a multiline literal or enumeration, leave a trailing comma on the last item. When entries are added or removed, this eliminates the need to touch unrelated lines. This eliminates irrelevant git history from the unrelated lines of code, and it makes for cleaner diffs; only the truly relevant lines of code must be changed.

I'll add: I keep arguing for this because it's one of very few guidelines which actually affect how well and quickly I can do my job.
Having a cleaner history in git for each line allows me to be a more effective developer, particularly when exploring and changing an unfamiliar part of a large codebase; even metadata like "was this line changed the same day as this other line" is extremely useful, and Xcode's blame view does a good job surfacing this information. I don't see how this is so controversial, unless I somehow rely on git much more heavily than the average developer.

I don't see how this is so controversial, unless I somehow rely on git much more heavily than the average developer.

It’s a good point, but even as someone who relies on git very heavily, I don’t think this change has enough of a positive impact there to justify it. I’ve never had a problem figuring out enum intention in git history, but where I do often have that problem is in code that I’m reading in the present. I think that this change applied to the code I work on, I’d be often second-guessing what was going on with all the extra commas.
Here are my final arguments against it:

The extra comma is not universally supported. Consider the case of NS_REQUIRES_NIL_TERMINATION  which will throw a compiler error if you try the following:

[[UIAlertView alloc] initWithTitle:title message:message delegate:self cancelButtonTitle:cancelButtonTitle
                                      otherButtonTitles:@"1", @"2",  nil,];

This inconsistency is difficult to explain in the guide and will lead to even more cognitive costs when trying to follow the guide.

The extra comma is non-standard in Objective-C codebases. In a look through popular open source projects on GitHub, Apple sample code, and tutorials, I discovered very few that follow this convention. This is an added cost to teach every new engineer following the guide. I think we should try to limit there where possible as it’s already a lot to keep in your head.

This is a breaking change. Many of the other additions to the style guide that have been made since its 1.0 release were additive, they didn’t throw existing code written with the guide out of compliance. I fear that this change will fracture the existing codebases in compliance, and without a public linter for the guide force people’s code into an essentially deprecated state if they follow the guide. Versioning might help solve this problem, but it’s not in place today.

It’s ugly. I’m generally a fan of arguments for productivity, objectivity, and speed, however the style guide serves many masters, and one of them is aesthetics. This looks gross to an English-speaker.

There is no consensus. Not to say that there always should be, but I think this points to the fact that there may be problems for enforcement.

I’ve never had a problem figuring out enum intention in git history,

My use case is often something like "was X added at the same time as Y?", which isn't really about intention, but this is a subjective point so I will move on.

The extra comma is not universally supported.
…
This inconsistency is difficult to explain in the guide and will lead to even more cognitive costs when trying to follow the guide.

Nothing is universally supported in C/Objective-C. You could make the same argument against the CGRect functions section; accessor functions do not exist for every structure or even every CGGeometry structure, so why must we remember this special case? (Because though it's a special case, it's a special case which provides an objective advantage over the lowest common denominator.)
A subtle change in language can alleviate any difficulty in explanation. It's fairly clear already where this proposal says to use the trailing comma, but in any case we can adapt the rule to "literals and enums when allowed or possible", similar in spirit to this guideline from the GitHub Swift style guide.

The extra comma is non-standard in Objective-C codebases. In a look through popular open source projects on GitHub, Apple sample code, and tutorials, I discovered very few that follow this convention. This is an added cost to teach every new engineer following the guide.

This is true of nearly anything in any style guide. In particular, I challenge you to find a particularly common ground between popular OSS projects, Apple sample code, and tutorials and this style guide's guidelines on naming/image naming or especially on imports.
The relatively small initial cost—a few-minute conversation, at worst—of introducing a new developer to this style does not outweigh the (concrete) advantages for all developers, current and future, which I have outlined.

This is a breaking change. Many of the other additions to the style guide that have been made since its 1.0 release were additive, they didn’t throw existing code written with the guide out of compliance.

This is true of nearly any addition to a style guide; indeed, if a rule didn't throw some existing code out of compliance, what would be the advantage in adding it?
In this particular case, the language can be changed slightly to indicate that this style is preferred and developers should use this style in new or updated code. There is no harm in providing new and updated guidelines for an evolving codebase.
Did the NYT rewrite all existing iOS code to comply with its style guide right away? The entire style guide is not a document which all existing code must comply with, it is instead a standard which new or changed code must comply with.
Further, this style guide did not before specify that this comma should be elided; therefore I disagree that this is truly a "breaking" change; it's more of a clarifying one.
A new rule in a style guide doesn't harm existing code, it provides guidelines for an evolving codebase.

It’s ugly.
…
This looks gross to an English-speaker.

The entirety of the C language looks gross to an English-speaker.
I disagree that "it's ugly", but this is a subjective point, so there's really no use in us arguing about it :heart:

There is no consensus. Not to say that there always should be, but I think this points to the fact that there may be problems for enforcement.

I'll refer you to "tabs vs. spaces" or "dot syntax vs square brackets](https://www.dzombak.com/blog/2015/03/Subjective-C--I-use-property--dot--syntax-liberally.html)".
The goal of a style guide is often to settle, within an organization, an issue where there is no broader consensus. In that spirit, "there is no consensus" is really more of an argument in favor of adding this to the guide.

I agree with every one of Matt's points; I agree with some of Chris's. The proposed change has not been proven necessary.

I challenge you to find a particularly common ground between popular OSS projects...

Nope, the onus is on the one proposing the change. Not that you haven't tried, but this challenge is not allowed. Innocent until proven guilty.

The goal of a style guide is often to settle, within an organization, an issue where there is no broader consensus. In that spirit, "there is no consensus" is really more of an argument in favor of adding this to the guide.

I'm not sure why you assert that "no consensus" logically leads to "mine is best." Maybe I'm reading this wrong.

This pull request contains merge conflicts that must be resolved.

Probably my fault due to that typo thing that was recently merged. Let me know if any questions arise in the merge.

Still pretty skeptical that we should change this one.


Power Platform Landing Zones deployment failure

Steps to reproduce
Deploying Power Platform Landing zones PPLZ-setup RG
Error Message
Object reference not set to an instance of an object. (Code: DeploymentScriptOperationFailed)

Screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@daltondhcp can you please have a look?

@LocDaiLeFromTwoMany - I did some debugging in the backend it indicates that there are no Power Platform licenses in the tenant. Can you confirm that you have that?

@LocDaiLeFromTwoMany - I did some debugging in the backend it indicates that there are no Power Platform licenses in the tenant. Can you confirm that you have that?

@daltondhcp - I'm not sure which licenses you are referencing to. My account has Power Apps pr. user plan. that is maybe not it?

Apologies for the late reply. Per User plan should be sufficient as long as you have enough capacity. Are you able to create new environments manually in Power Platform Admin Center?

@daltondhcp how much capcity is needed? Yes I can create environments manually.

Perfect, that should absolutely be sufficient. Can you please share the log output in text format from the deployment script (couldn't see it all in the screenshot)

Here is the raw error of the deployment.
{   "code": "DeploymentFailed",   "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",   "details": [     {       "code": "DeploymentScriptOperationFailed",       "message": "Object reference not set to an instance of an object."     }   ] }

Perfect, that should absolutely be sufficient. Can you please share the log output in text format from the deployment script (couldn't see it all in the screenshot)

Here is the raw error of the deployment.
{ "code": "DeploymentFailed", "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.", "details": [ { "code": "DeploymentScriptOperationFailed", "message": "Object reference not set to an instance of an object." } ] }

I was more referring to this output from the deploymentscript, including the script execution parameters

Perfect, that should absolutely be sufficient. Can you please share the log output in text format from the deployment script (couldn't see it all in the screenshot)

Here is the raw error of the deployment.
{ "code": "DeploymentFailed", "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.", "details": [ { "code": "DeploymentScriptOperationFailed", "message": "Object reference not set to an instance of an object." } ] }

I was more referring to this output from the deploymentscript, including the script execution parameters

Sorry. Here it is.
-PPGuestMakerSetting yes -PPAppSharingSetting yes -PPEnvCreationSetting yes -PPTrialEnvCreationSetting yes -PPEnvCapacitySetting yes -PPTenantDLP high -PPTenantIsolationSetting none -PPTenantIsolationDomains '' -PPAdminEnvEnablement yes -PPAdminEnvNaming namconadminenv -PPAdminBilling yes -PPAdminRegion europe -PPAdminCoeSetting no -PPAdminDlp yes -PPAdminManagedEnv yes -PPDefaultRenameText Personal -PPDefaultDLP yes -PPDefaultManagedEnv yes -PPDefaultManagedSharing yes -PPCitizen yes -PPCitizenConfiguration null -PPCitizenCount 1 -PPCitizenNaming namconcitizendevenv -PPCitizenDescription desccitizendevenv -PPCitizenLanguage 1030 -PPCitizenCurrency dkk -PPCitizenRegion europe -PPCitizenDlp yes -PPCitizenManagedEnv yes -PPCitizenBilling yes -PPCitizenAlm yes -PPPro yes -PPProConfiguration null -PPProCount 1 -PPProNaming namconprodevenv -PPProDescription descprodevenv -PPProLanguage 1030 -PPProCurrency dkk -PPProRegion europe -PPProDlp yes -PPProManagedEnv yes -PPProBilling yes -PPProAlm yes -PPSelectIndustry none -PPIndustryNaming namconindustryenv -PPIndustryRegion europe -PPIndustryManagedEnv yes -PPIndustryAlm yes -PPIndustryBilling yes

Did you get any additional insights/output below the parameters?
I have tested the same deployment with above parameters in my test environment successfully. Would you mind retry the deployment to ensure it wasn't a temporary issue.

Did you get any additional insights/output below the parameters?
I have tested the same deployment with above parameters in my test environment successfully. Would you mind retry the deployment to ensure it wasn't a temporary issue.

Still the same outcome

Can you also confirm that the User Managed Identity are added as an admin application?

Hi @daltondhcp,
I face the same issue as @LocDaiLeFromTwoMany, running the PowerShell locally with the same inputs works fine, the User Managed Identity is registered as described by the article:

At least I cannot see any more console output within the deployment script, this is the only error message
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
  "details": [
    {
      "code": "DeploymentScriptOperationFailed",
      "message": "Object reference not set to an instance of an object."
    }
  ]
}

I have now been able to reproduce the issue in my environment with certain settings. Will work on creating a fix.

Do you have an ETA for the fix?

We have nailed it down to issues/changes with deploymentScripts execution (as earlier identified), yet to find a solution. As a workaround, you can execute the script manually with the same parameters as mentioned earlier in the thread.

Any update on fix for the issue? Same problem from my tests.


Fix bug that was using base16 for int expressions instead of base10

I took a look at all the code that is using fb.evaluateIntegerExpression and all of it requires base10 and not base16. This probably wasn't found earlier because most times the argument for the function will be less than 10 and there will be no difference between the base10 and base16 value.
id@idmac: ~/chisel
 $ grep -ri IntegerExpression .                                                                                ./commands/FBAccessibilityCommands.py:      accessibilityElementsCount = fb.evaluateIntegerExpression('[%s count]' % accessibilityElements)
./commands/FBFlickerCommands.py:  numViews = fb.evaluateIntegerExpression('[(id)' + subviews + ' count]')
./commands/FBFlickerCommands.py:  numViews = fb.evaluateIntegerExpression('[(id)' + subviews + ' count]')
./commands/FBFlickerCommands.py:  idx = fb.evaluateIntegerExpression('[(id)' + subviews + ' indexOfObject:' + view + ']')
./commands/FBPrintCommands.py:    targetCount = fb.evaluateIntegerExpression('[{targets} count]'.format(targets=targets))
./commands/FBPrintCommands.py:    HTTPHeadersCount = fb.evaluateIntegerExpression('[{} count]'.format(HTTPHeaders))
./commands/FBPrintCommands.py:    if fb.evaluateIntegerExpression('[{} length]'.format(HTTPData)) > 0:
./commands/FBPrintCommands.py:          if fb.evaluateIntegerExpression('[{} respondsToSelector:@selector(base64EncodedStringWithOptions:)]'.format(HTTPData)):
./fblldbbase.py:def evaluateIntegerExpression(expression, printErrors=True):
./fblldbbase.py:  return (int(evaluateIntegerExpression('(BOOL)(' + expression + ')', printErrors)) != 0)
./fblldbviewcontrollerhelpers.py:  numChildViewControllers = fb.evaluateIntegerExpression('(int)[(id)[%s childViewControllers] count]' % (vc))

Thanks for looking into this!

 Would you be interested in switching those to use this fixed evaluateIntegerExpression?

I agree it would be cleaner to replace the int(fb.evaluate*) calls with the new fb.evaluateIntegerExpression method. I'll put a new PR in soon.


Version 2.0 rewrite

The last weeks developing with this wrapper made me feel like communication requires a lot of workarounds. For example, when I'm doing a request with invalid user credentials I'd expect the promise to be rejected instead of being resolved with an error. The same unexpected behaviour is seen when using functions which return an empty payload if they were successful (like I mentioned in #5).
As @jamen already said some code optimizations #9 like would be useful as well.
I feel like implementing this into a new complete 2.0 rewrite would be more effective than using the existing codebase. I have some ideas for the rewrite and I'd like to hear your opinion on this.

Test Coverage as high as possible (goal is 100%). Coveralls + Travis?
Enforcing a consistent code style. Standard?
Interactive API Documentation for the Mojang API. Swagger UI?
ES6 features (Babel) vs. standard node runtime features?

I'd love to hear your opinion and if anybody would be willing to help me.

I'd be willing to help, but I haven't been developing javascript for very long (about two months). I'd love to learn more widely used development conventions and integrations. This could help to that end, since it's not really a terribly complicated task.

I would love to help! I have been developing an Electron-wrapped modpack launcher and naively wrote my own Yggdrasil client. I have a preference for got and xo styling, but I am more interested in following a repo's given guidelines.

@maccelerated Great! I sent an invite.
Just a reminder: I designed this a while back, and my style has changed since then.  I don't plan on maintaining this too heavily, so feel free to change this however once we can reach some consensus.
Here are my opinions:

Test coverage is good, no doubt
I like standard code style, it has influenced how I write JS today
Interactive code sounds interesting, but would be best to put on hold.
I never setup Babel for libraries like this one because it feels like a hassle.

If we are going to release a major version, we should think about the lessons learned from using this library.

As mentioned: Promises aren't resolving/rejecting as expected.
The function interfaces accept a lot of variation on input which might not be necessary.
The functions can be implemented better.
There is possibly more functions that could be implemented.
Can we make this package more known?  Adding links to wikis for example
Should this be designed more suitable for browser?

A better request library
Bundles better

Just some food for thought.  :smile:

My immediate feedback is that test coverage is high priority, standard is a great choice, I vote that npm packages should avoid transpiling unless absolutely necessarily and instead just target a sane Node version, and I'll take a peek at the current promise resolutions on the endpoints to see what makes sense and what doesn't when I have time. I'm always happy to talk things out and thank you for the invite!

Okay, so I went a bit ham.
https://github.com/maccelerated/node-mojang
https://maccelerated.github.io/node-mojang/

@maccelerated Looks awesome! Please open a PR for review.   Also would you want to transfer this to your account (or some org) after PR is settled?

I made an org for some other MC-related stuff I was up to, but it doesn't really matter to me either way. Honestly, it's probably better OSS practice for me to learn how to branch and do PRs on someone else's repo.

Resolved by #13


Couldn't resolve environment subkeys

Couldn't resolve environment['subkeys']
See: https://scons.org/bugs.html
Detail info:

Version of SCons: 3.0.1
Version of Python: 2.7.15
Install SCons: setup.py install
Version of Platform: Windows10 x64, build 1809

env = Environment()
print env['LIBLINKSUFFIX']

>scons

scons: Reading SConscript files ...
$LIBSUFFIX (not a".lib")

I'm not sure what you think this should do.
That code is performing exactly as it should.
If you want the value to be printed, you should probably use
print env.subst("$LIBLINKSUFFIX")
(see manpage for subst)
Please bring your question to the scons users mailing list.
https://pairlist4.pair.net/mailman/listinfo/scons-users

This is good, thanks. But I think it is not correct. Interface is not uniform...(

If you set a value to another value it needs to be evaluated.
(Make does the same)
if you say env['x']='$y'  then when you retrieve x, you get $y.
If you want the end value (which could be y=$z, z=$a,....), then you need to fully evaluate using subst().
If it were not this way how would you ever retrieve "$y" when you didn't want to evaluate it fully.
Do you have another proposed implementation?
Remember it's implemented in Python.

So, this makes sense.

If it were not this way how would you ever retrieve "$y" when you didn't want to evaluate it fully.

May be:
env['x']='$y'
# ($y=z)
env['$x']=z

But, i'm not sure...

Nope. Environment is supposed to be accessable like a dictionary. No mucking with []..


Fix bug in shared mount directory list

The list should only contain directories from shared storage. There is another property local_mount_dir_set to collect the set of local mount directories.
Signed-off-by: Hanwen<EMAIL_ADDRESS>References
This PR fixes a bug in https://github.com/aws/aws-parallelcluster/pull/3981
Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[x] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Shall we add a test case in test_all_validators to catch such issue?


fixed inital value not setting

I changed the initialValue attribute to be computed as this.value || ''

Pull Request Test Coverage Report for Build 70

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 70.297%

Totals

Change from base Build 38:
0.9%

Covered Lines:
48

Relevant Lines:
69

💛  - Coveralls

I found an issued showing up in the debugger console that there is no setter, working on fixing that then will do a new pull request


Add Rocky linux 8 support with cuda 11.6

Hi, after some time I'm working again in this project.
This adds support for Rocky Linux 8, the spiritual successor of CentOS 8,  It uses the same image from Nvidia, but updates the CentOS image to rocky Linux. With this fix, now it can continue to connect and get the binaries to build FFmpeg.
The fix comes from this thread https://gitlab.com/nvidia/container-images/cuda/-/issues/149
I will create as a draft because it just came from the oven and I need to test it before

Hey @mliradelc, let me know, when you're ready!

Thanks for merging, BTW, this docker file is based on the latest cuda (11.6) and is newer than the Ubuntu Dockerfile


Resolve syncing conflicts from live-sync-work to live

Pull request opened by OPS to resolve syncing conflicts from live-sync-work to live.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-Prod/azure-docs-sdk-dotnet, working directory: W:\mi5b-s, target branch: live, target branch commit: 1c9e7902b5f8ac44d15b93ded616ceccbb25471d, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-Prod/azure-docs-sdk-dotnet, working directory: W:\m3fc-s, target branch: live, target branch commit: 1c9e7902b5f8ac44d15b93ded616ceccbb25471d, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

_zip/msdn.4.5.2.zip
:white_check_mark:Succeeded

previewtemp/_zip/msdn.4.5.2.zip
:white_check_mark:Succeeded

previewtemp/breadcrumb/toc.yml
:white_check_mark:Succeeded

previewtemp/docfx.json
:white_check_mark:Succeeded

previewtemp/xml/_filter.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


RuntimeError: CUDA out of memory.

python train.py --base_config korquad/bert_base_multilingual_uncased

2021-04-24 16:30:42,819 (modeling_utils.py:650): [INFO] - loading weights file https://cdn.huggingface.co/bert-base-multilingual-uncased-pytorch_model.bin from cache at /home/yyoo/.claf_cache/b72dd13aa8437628227c4928499f2476a84af4ab7ed75eb1365c5ae9fdbd7638.54b4dad9cc3db9aa8448458b782d11ab07c80dedb951906fd2f684a00ecdb1ee
2021-04-24 16:30:48,149 (modeling_utils.py:741): [INFO] - Weights of BertForQuestionAnswering not initialized from pretrained model: ['qa_outputs.weight', 'qa_outputs.bias']
2021-04-24 16:30:48,149 (modeling_utils.py:747): [INFO] - Weights from pretrained model not used in BertForQuestionAnswering: ['cls.predictions.bias', 'cls.predictions.transform.dense.weight', 'cls.predictions.transform.dense.bias', 'cls.predictions.decoder.weight', 'cls.seq_relationship.weight', 'cls.seq_relationship.bias', 'cls.predictions.transform.LayerNorm.weight', 'cls.predictions.transform.LayerNorm.bias']
2021-04-24 16:30:50,799 (experiment.py:327): [INFO] - use_gpu: True num_gpu: 1, distributed training: False, 16-bits training: False
2021-04-24 16:30:50,866 (trainer.py:356): [INFO] - # Train Mode.
2021-04-24 16:30:51,058 (trainer.py:389): [INFO] -   Start - Batch Loss: 6.31731
Traceback (most recent call last):
  File "train.py", line 10, in <module>
    experiment()
  File "/home/yyoo/src/claf/claf/learn/experiment.py", line 142, in __call__
    self.trainer.train_and_evaluate(train_loader, valid_loader, optimizer)
  File "/home/yyoo/src/claf/claf/learn/trainer.py", line 137, in train_and_evaluate
    eval_and_save_step_count=self.eval_and_save_step_count,
  File "/home/yyoo/src/claf/claf/learn/trainer.py", line 376, in _run_epoch
    output_dict = self.model(**inputs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/src/claf/claf/model/reading_comprehension/bert.py", line 72, in forward
    bert_inputs, token_type_ids=token_type_ids, attention_mask=attention_mask
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 1450, in forward
    inputs_embeds=inputs_embeds,
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 734, in forward
    encoder_attention_mask=encoder_extended_attention_mask,
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 408, in forward
    hidden_states, attention_mask, head_mask[i], encoder_hidden_states, encoder_attention_mask
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 369, in forward
    self_attention_outputs = self.attention(hidden_states, attention_mask, head_mask)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 315, in forward
    hidden_states, attention_mask, head_mask, encoder_hidden_states, encoder_attention_mask
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/yyoo/torch/lib/python3.6/site-packages/transformers/modeling_bert.py", line 236, in forward
    attention_scores = attention_scores / math.sqrt(self.attention_head_size)
RuntimeError: CUDA out of memory. Tried to allocate 144.00 MiB (GPU 0; 11.78 GiB total capacity; 10.23 GiB already allocated; 49.88 MiB free; 10.33 GiB reserved in total by PyTorch)

Use multiple GPUs?
2021-04-24 16:36:52,816 (modeling_utils.py:650): [INFO] - loading weights file https://cdn.huggingface.co/bert-base-multilingual-uncased-pytorch_model.bin from cache at /home/yyoo/.claf_cache/b72dd13aa8437628227c4928499f2476a84af4ab7ed75eb1365c5ae9fdbd7638.54b4dad9cc3db9aa8448458b782d11ab07c80dedb951906fd2f684a00ecdb1ee
2021-04-24 16:36:57,130 (modeling_utils.py:741): [INFO] - Weights of BertForQuestionAnswering not initialized from pretrained model: ['qa_outputs.weight', 'qa_outputs.bias']
2021-04-24 16:36:57,130 (modeling_utils.py:747): [INFO] - Weights from pretrained model not used in BertForQuestionAnswering: ['cls.predictions.bias', 'cls.predictions.transform.dense.weight', 'cls.predictions.transform.dense.bias', 'cls.predictions.decoder.weight', 'cls.seq_relationship.weight', 'cls.seq_relationship.bias', 'cls.predictions.transform.LayerNorm.weight', 'cls.predictions.transform.LayerNorm.bias']
Traceback (most recent call last):
  File "train.py", line 10, in <module>
    experiment()
  File "/home/yyoo/src/claf/claf/learn/experiment.py", line 134, in __call__
    train_loader, valid_loader, optimizer = self.set_train_mode()
  File "/home/yyoo/src/claf/claf/learn/experiment.py", line 220, in set_train_mode
    model = self._create_model(token_makers, helpers=helpers)
  File "/home/yyoo/src/claf/claf/learn/experiment.py", line 307, in _create_model
    model = self._set_gpu_env(model)
  File "/home/yyoo/src/claf/claf/learn/experiment.py", line 317, in _set_gpu_env
    model = torch.nn.DataParallel(model, device_ids=cuda_devices)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 142, in __init__
    _check_balance(self.device_ids)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 23, in _check_balance
    dev_props = _get_devices_properties(device_ids)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/_utils.py", line 459, in _get_devices_properties
    return [_get_device_attr(lambda m: m.get_device_properties(i)) for i in device_ids]
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/_utils.py", line 459, in <listcomp>
    return [_get_device_attr(lambda m: m.get_device_properties(i)) for i in device_ids]
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/_utils.py", line 442, in _get_device_attr
    return get_member(torch.cuda)
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/_utils.py", line 459, in <lambda>
    return [_get_device_attr(lambda m: m.get_device_properties(i)) for i in device_ids]
  File "/home/yyoo/torch/lib/python3.6/site-packages/torch/cuda/__init__.py", line 309, in get_device_properties
    raise AssertionError("Invalid device id")
AssertionError: Invalid device id


keep grid

Is that possible to keep the grid?

Hi @cosmozhang,
could you be a bit more specific?
Cheers!


SYS-1: [ERROR] Package could not be parsed, due to an exception.

The file AT020.ods previously reported POL_1 when validating with profile since it is encrypted via LibreOffice. Without profile, it used to generate XML-3 errors, and this is still the case, but instead of POL_1, it now reports SYS-1 with profile.
AT020.ods
C:\ODF\odf-validator-0.14.0>odf-validator.bat -p C:\Users\maria\Desktop\014test\AT020.ods
APP-1: [INFO] Validating C:\Users\maria\Desktop\014test\AT020.ods.
APP-4: [INFO] Validation report for C:\Users\b340777\Desktop\014test\AT020.ods.
DOC-2: [INFO] package OpenDocument version unknown detected.
XML-3: [ERROR] settings.xml Not a well formed XML document. XML parsing exception at line 1 and column 1: Invalid byte 1 of 1-byte UTF-8 sequence..
DOC-3: [INFO] mimetype OpenDocument MIMETYPE application/vnd.oasis.opendocument.spreadsheet detected
XML-3: [ERROR] manifest.rdf Not a well formed XML document. XML parsing exception at line 1 and column 1: Invalid byte 1 of 1-byte UTF-8 sequence..
XML-3: [ERROR] meta.xml Not a well formed XML document. XML parsing exception at line 1 and column 1: Invalid byte 1 of 1-byte UTF-8 sequence..
PKG-7: [WARNING] Thumbnails\thumbnail.png An OpenDocument Package SHOULD contain a preview image Thumbnails/thumbnail.png.
XML-3: [ERROR] content.xml Not a well formed XML document. XML parsing exception at line 1 and column 1: Invalid byte 1 of 1-byte UTF-8 sequence..
XML-3: [ERROR] styles.xml Not a well formed XML document. XML parsing exception at line 1 and column 1: Invalid byte 2 of 2-byte UTF-8 sequence..
NOT VALID, 5 errors, 1 warnings and 2 info messages.
SYS-1: [ERROR] Package could not be parsed, due to an exception. | Unexpected Exception caught when executing Schematron checks.

This is now correctly reporting POL_1 again along with a new WARNING PKG-10. Without profile, only the warnings are reported.
Without profile
APP-1: [INFO] Validating D:\odsfiler\AT020.ods.
APP-4: [INFO] Validation report for D:\odsfiler\AT020.ods.
DOC-2: [INFO] package OpenDocument version 1.3 detected.
PKG-10: [WARNING] settings.xml Encrypted file entry detected: settings.xml.
DOC-3: [INFO] mimetype OpenDocument MIMETYPE application/vnd.oasis.opendocument.spreadsheet detected
PKG-10: [WARNING] meta.xml Encrypted file entry detected: meta.xml.
PKG-7: [WARNING] Thumbnails\thumbnail.png An OpenDocument Package SHOULD contain a preview image Thumbnails/thumbnail.png.
PKG-10: [WARNING] content.xml Encrypted file entry detected: content.xml.
PKG-10: [WARNING] styles.xml Encrypted file entry detected: styles.xml.
INCOMPLETE encrypted entries are not supported, 0 errors, 5 warnings and 2 info messages.
With profile:
APP-1: [INFO] Validating D:\odsfiler\AT020.ods.
APP-4: [INFO] Validation report for D:\odsfiler\AT020.ods.
DOC-2: [INFO] package OpenDocument version 1.3 detected.
PKG-10: [WARNING] settings.xml Encrypted file entry detected: settings.xml.
DOC-3: [INFO] mimetype OpenDocument MIMETYPE application/vnd.oasis.opendocument.spreadsheet detected
PKG-10: [WARNING] meta.xml Encrypted file entry detected: meta.xml.
PKG-7: [WARNING] Thumbnails\thumbnail.png An OpenDocument Package SHOULD contain a preview image Thumbnails/thumbnail.png.
PKG-10: [WARNING] content.xml Encrypted file entry detected: content.xml.
PKG-10: [WARNING] styles.xml Encrypted file entry detected: styles.xml.
INCOMPLETE encrypted entries are not supported, 0 errors, 5 warnings and 2 info messages.
APP-5: [INFO] DNA ODF Spreadsheets Preservation Specification Profile report for D:\odsfiler\AT020.ods.
POL_1: [ERROR] settings.xml Encryption | The package MUST NOT contain any encrypted entries.
POL_1: [ERROR] manifest.rdf Encryption | The package MUST NOT contain any encrypted entries.
POL_1: [ERROR] meta.xml Encryption | The package MUST NOT contain any encrypted entries.
POL_1: [ERROR] content.xml Encryption | The package MUST NOT contain any encrypted entries.
POL_1: [ERROR] styles.xml Encryption | The package MUST NOT contain any encrypted entries.
INCOMPLETE encrypted entries are not supported, 5 errors, 5 warnings and 2 info messages.


NextJS 15 support

Is your feature request related to a problem? Please describe.
I am using NextJS RC.0 with NextIntl 3.17.2. Everything works as expected so far.
However - due to dependency specifications I get the following error when I try to install things (ex: npx shadcn-ui@latest add avatar):
Command failed with exit code 1: npm install @radix-ui/react-avatar
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR!   peer<EMAIL_ADDRESS>|| ^15.0.0-rc.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/next-firebase-auth-edge
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/next-intl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR!   peer<EMAIL_ADDRESS>|| ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/next-intl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/velinkerkov/.npm/_logs/2024-08-11T08_03_31_829Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/velinkerkov/.npm/_logs/2024-08-11T08_03_31_829Z-debug-0.log

Describe the solution you'd like
Please specify through the dependencies that this package works with NextJS RC.0.
Describe alternatives you've considered
When I am installing packages I use --legacy-peer-deps until this is fixed.

Adding React RC versions to peerDependencies is unfortunately not that straightforward: https://x.com/phry/status/1811070395879149682.
I think for now the best option is to use --legacy-peer-deps and bump the peer dependency version once React 19 stable is out.

I'm going to close this in favor of https://github.com/amannn/next-intl/issues/1075


Revert to ubuntu 21.04 base image

Currently, after upgrading base image to ubuntu 22.04, xfce4 is not working on other host ubuntu versions other than ubuntu 22.04.
This PR downgrades to version 21.04

Now, downgrading to ubuntu21.04 cannot be done easily.
Err:4 http://security.ubuntu.com/ubuntu hirsute-security Release
  404  Not Found [IP: <IP_ADDRESS> 80]
Ign:5 http://archive.ubuntu.com/ubuntu hirsute-backports InRelease
Err:6 http://archive.ubuntu.com/ubuntu hirsute Release
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:7 http://archive.ubuntu.com/ubuntu hirsute-updates Release
  404  Not Found [IP: <IP_ADDRESS> 80]
Err:8 http://archive.ubuntu.com/ubuntu hirsute-backports Release
  404  Not Found [IP: <IP_ADDRESS> 80]

This distribution is end-of-life and rightfully so, the files have been removed from the mirrors. There is no point in using EOL software as a base. The original problem is that a short life cycle distro was ever considered for use in the tests. In Ubuntu's case, LTS releases last at least 5 years, and typically the mirrors are kept alive even though the distro is dead (check http://archive.ubuntu.com/ubuntu/dists/, trusty and xenial (14.04 and 16.04, respectively) are still available (probably because Ubuntu is providing extended paid support on other mirrors and uses the old mirrors as a base); this is not an argument to use either of them, though).
Let's fix this by either downgrading to 20.04 or upgrading to 22.04. Both are LTS releases and will last until 2025 or even 2027, respectively.

Downgrading to ubuntu21.04 is not an option. We will try to find a better solution for this.


MAINT: Upgrade Logbook version

Upgrade Logbook to 0.12.5. This required changing a usage of
logbook.NullHandler() which passed bubble=True, since
NullHandler no longer supports the bubble argument.

:+1: from me assuming we're happy with any downstream implications of this.

I think we need to update our conda recipe for logbook. https://github.com/quantopian/zipline/blob/master/conda/logbook/meta.yaml was generated with conda skeleton

I think we need to update our conda recipe for logbook.

Any idea why the conda recipe has a dependency on six? I don't see six referenced anywhere in the source code of Logbook 0.10.0 or 0.12.5.

Any idea why the conda recipe has a dependency on six?

At least in version 0.10, they specify it as [install_requires] (https://github.com/getlogbook/logbook/blob/2694230b0ce21a8e369b4b6663da78f26289e920/setup.py#L122).

Oh, I see it now. Silly me trying to use "git grep" in a directory that isn't a git repository. That dependency is gone in 0.12.5.
I can easily update the conda recipe, but how do I test that update?


CSV: Set operator-type: non-standalone

This should hide the placement package/bundle in the OpenShift console as we only want the main OpenStack operator to show up there.

/test placement-operator-build-deploy
Test executor was unable to claim a test cluster


Feature/rfc7662 oauth2 token introspection

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

[x] You consent that the copyright of your pull request source code belongs to Authlib's author.

Implementation of RFC7662 (#33).

I'd rather not make any changes in revocation spec. You can add a SUPPORTED_TOKEN_TYPES in IntrospectionEndpoint itself. In this way, people can custom the SUPPORTED_TOKEN_TYPES with a subclass.

This will hold on for a while. I'm planning a lot of things in v0.6. It will get merged when I get things ready.
Thank you.

OK. Anything else I can do?


feat(helm): doc Varnish and trusted_host_pattern

Related: drupalwxt/helm-drupal#54

Thank you so much :D


execution expired (Timeout::Error)

I tried it out and changed 1 scenario to @firebug from @javascript, and I suddenly saw many errors like this (even on other scenarios).
execution expired (Timeout::Error)
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/timeout.rb:64:in `rbuf_fill'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/protocol.rb:134:in `rbuf_fill'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/protocol.rb:116:in `readuntil'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/protocol.rb:126:in `readline'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:2028:in `read_status_line'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:2017:in `read_new'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:1051:in `request'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:1037:in `request'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:543:in `start'
/home/ramon/.rvm/rubies/ree-1.8.7-2011.03/lib/ruby/1.8/net/http.rb:1035:in `request'
./features/step_definitions/web_steps.rb:20:in `/^(?:|I )am on (.+)$/'
features/manage_pages.feature:115:in `Given I have a site "Fancake", and I am the moderator "bob"'

Unfortunately, without any means of reproducing this there's no way I can fix it.
If you can share an app or something that exhibits the problem let me know.


opcode: fix literal string of operator EQ

The literal string of operator EQ should be = instead of ==.

LGTM


fix(curriculum): small fixes in cat painting project

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Fixes small typos and mistakes in the cat painting project. Details:

Step 16: Wrap a property name in code tags
Step 29: Correct class name
Step 31, 33: Missing space
Step 40:  Missing dot before class name
Step 42: left -> right
Step 44: Missing comma
Step 57: Changed NBSP to normal space since Crowdin was giving a warning about it, and added missing period.
Step 61: Missing dot before class name
Step 62: property -> selector
Step 64: left -> right, property -> selector
Step 79:  Missing dot before class name

Hey @sidemt !
It looks like a few of the automated tests are failing.
But it looks like your PR only updates some small typos.
So maybe you can try merging in the latest changes from main to see if that resolves the issue


Bigger files cannot be uploaded.

Hello,
i'm running the latest cryptgeon version on docker.
My docker-compose file:
`version: '3.7'
services:
memcached:
container_name: memcached_cryptgeon
image: memcached:1-alpine
restart: unless-stopped
entrypoint: memcached -m 512M -I 20M
ports:
- 11211:11211
app:
image: cupcakearmy/cryptgeon:latest
depends_on:
- memcached
environment:
SIZE_LIMIT: 10MiB
ports:
- 80:5000
`
When i try to upload files below 10 MByte i get an error that the file couldn't bei uploaded.
File is only 8.9 MByte.

Could you try the 2.0 version with redis?

I did some investigation. So a PDF file of 3,8 MB blows up to 9.58 mb after encryption. This should not be the case. In theory file sizes should stame the same +- some padding.
I would gues this is the issue and would defentely understad why this happens. I'm quite sure this is due of the hex encoding. Will see what we can do.

Thank you for investigating this. I understand only trainstation :-D :-> when i am looking at the rust code.

It's actually all frontend. The files need to be encoded with printable characters.
I was using hex (base16) and switched to base64 now. this is the most efficient for sending it over json afaik.
It leaves an approx 35% encoding overhead. this means that if the server is configured with 4 MiB the client will now show a max file size of 2.96 MiB.


[BUG] Unable to specify arbitrary GPUs using CUDA_VISIBLE_DEVICES

I am trying to run LoRA finetuning with DeepSpeed-Chat. The nature of the finetuning process is that it can be done within 2 to 4 GPUs. So the plan is to partition the compute available and utilise it across experiments. However, I am not able to specify any arbitrary GPU using CUDA_VISIBLE_DEVICES. How to circumvent this error as this is extremely vital to get started. Please share remedies. The error is catalogued below:
I ran: CUDA_VISIBLE_DEVICES=2 ./run_llama2_7b_lora.sh
[2023-09-01 02:53:59,301] [INFO] [real_accelerator.py:158:get_accelerator] Setting ds_accelerator to cuda (auto detect)
[2023-09-01 02:54:00,246] [WARNING] [runner.py:201:fetch_hostfile] Unable to find hostfile, will proceed with training with local resources only.
Detected CUDA_VISIBLE_DEVICES=2: setting --include=localhost:2
Traceback (most recent call last):
File "/.local/bin/deepspeed", line 6, in
main()
File "/.local/lib/python3.8/site-packages/deepspeed/launcher/runner.py", line 428, in main
active_resources = parse_inclusion_exclusion(resource_pool, args.include, args.exclude)
File "/.local/lib/python3.8/site-packages/deepspeed/launcher/runner.py", line 349, in parse_inclusion_exclusion
return parse_resource_filter(active_resources, include_str=inclusion, exclude_str=exclusion)
File "/.local/lib/python3.8/site-packages/deepspeed/launcher/runner.py", line 301, in parse_resource_filter
raise ValueError(f"No slot '{slot}' specified on host '{hostname}'")
ValueError: No slot '2' specified on host 'localhost'

To add on to this comment, a prefix selection of GPUs (0,1 or 0,1,2 or just 0) seems to work, but an arbitrary selection of GPUs say 2,3 does not work.

Hi @vinod-sarvam - this is detailed more on the Getting Started page for Resource Configuration on a single node here.  In short, we recommend using a hostfile for this, not CUDA_VISIBLE_DEVICES

Hi @vinod-sarvam - closing this issue for now assuming you've been able to resolve this.  If not, please reply and we can re-open if you are having any issues, thanks!

1

First you need to reset the CUDA_VISIBLE_DEVICES to 0,1,2,3, I think this is the issue.

First you need to reset the CUDA_VISIBLE_DEVICES to 0,1,2,3, I think this is the issue.

This doesn't actually address the issue, since @vinod-sarvam mentions that prefix selection works, but not arbitrary selection.

https://github.com/microsoft/DeepSpeed/blob/4f9506729fda0e9b178761f58f5316018d77990b/deepspeed/launcher/runner.py#L358
This line erases the device numbering for the active_resources but not for the include string. When slots are subsequently parsed from the include string, they are converted to int. In my estimation, one should check that the number of slots specified in the include string does not exceed the number found in the actitve_resources.

Hi @arnold-jr, we can, though if you have a more full explanation or summary of your issue, would you make a new issue and link this one?  That way it will be fresher in the list of issues to track.


Setting spring.jmx.default-domain To Unique Values For cas-server-webapp and cas-management-webapp For CAS 5

This is not a bug.
cas-server-webapp and cas-management-webapp are deployed on the same server which are both Spring Boot applications in CAS 5.  I know this is not typical when deploying these applications as they usually are on different servers.
This results in the following exception:
... 2016-08-19 17:37:08,442 ERROR [org.springframework.boot.SpringApplication] - <Application startup failed> org.springframework.jmx.export.UnableToRegisterMBeanException: Unable to register MBean [org.springframework.cloud.context.environment.EnvironmentManager@19480877] with key 'environmentManager'; nested exception is javax.management.InstanceAlreadyExistsException: org.springframework.cloud.context.environment:name=environmentManager,type=EnvironmentManager         at org.springframework.jmx.export.MBeanExporter.registerBeanNameOrInstance(MBeanExporter.java:625) ~[spring-context-4.3.2.RELEASE.jar:4.3.2.RELEASE]         at org.springframework.jmx.export.MBeanExporter.registerBeans(MBeanExporter.java:550) ~[spring-context-4.3.2.RELEASE.jar:4.3.2.RELEASE] ...
In src/main/resources/bootstrap.properties in both cas-server-webapp and cas-management-webapp, the spring.jmx.default-domain is not set.
Could I suggest setting this value uniquely for both applications in bootstrap.properties?
Environment details:

CAS server version
Tomcat 8.0.32
Deploy cas-server-webapp and cas-management-webapp on the same server.

Feel free to submit a patch.

Will do.  Thanks!


approvalsPaused

i am facing issue when i debug $model->approvalsPaused
then i got false

![image](https://github.com/ringlesoft/laravel-process-approval/assets/114276193/42a506cf-c53a-468d-9dd6-353510a6f7a6)

if you want to pause approvals for a particular model, define a method pauseApprovals() and return true. By default this is false.
Example:
public function pauseApprovals: bool
{
// TODO write a logic to decide whether to pause approvals
return true;
}

@ringunger and what about this method in Approvable Trait.
    /**
     * Enables pausing the approval process for intermediate actions
     * @return mixed
     */
    public function getApprovalsPausedAttribute(): mixed
    {
        if (method_exists($this, 'pauseApprovals')) {
            return $this->pauseApprovals();
        }
        return false;
    }

I do not see the approvalsPaused  column/attribute being set up anywhere in the package files. Where exactly to set this attribute?

You should define a method pauseApprovals() in your model that
returns true if approvals are paused.
it is not an actual model attribute.
On Thu, Jun 20, 2024 at 8:50 PM @.*** @.***>
wrote:

@ringunger https://github.com/ringunger and what about this method in
Approvable Trait.
/**
 * Enables pausing the approval process for intermediate actions
 * @return mixed
 */
public function getApprovalsPausedAttribute(): mixed
{
    if (method_exists($this, 'pauseApprovals')) {
        return $this->pauseApprovals();
    }
    return false;
}

I do not see the approvalsPaused column/attribute being set up anywhere
in the package files. Where exactly to set this attribute?
—
Reply to this email directly, view it on GitHub
https://github.com/ringlesoft/laravel-process-approval/issues/14#issuecomment-2181226019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2NN3SXFZMIZ3CHDAQCZLZIMI5JAVCNFSM6AAAAABJUNQ4R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGIZDMMBRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Server hangs when initially loading data

This is the log for my server startup. As it shows, after LP loads data, nothing else happens, but the file watcher still works. Version 4.2.87 works normally, but 4.2.89 does not.

I just tested 4.2.89 again on my server, and the hang no longer happens. It may have been related to specific mod/plugin configurations or mods/plugins installed at the time.

Ok, feel free to re-open if it happens again.


(Request) Include the text description in the header of API docs

I used to maintain a similar project for IntelliJ's EmmyLUA plugin here, but have begin using yours full-time as it is far superior to what I was able to accomplish on my own. That being said, there is one small thing that I prefered from my old implementation, and that was that I had function descriptions listed just above the URL lines in the API docs, as you can see here. Having the description in the tooltip can help considerably with autocomplete suggestions and ease of development, at least for me, and right now all we have is a direct link to the wiki page, but not actual in-IDE context.
I don't imagine it would be too difficult to add, as I image whatever engine you use to source the API info from the wiki has access to these descriptions, much in the same way as I had before. Thanks again!

Appreciated! I'd help implement it myself, but I haven't yet cloned your project and dug through your functions. So I wouldn't even know where to begin lol.

 It's ironic


fix: Missing vMix Config Manifest

Adds the vMix Config Manifest details.

Hi Peter,
First of all thanks for your first contribution to Sofie, it's always appreciated!
I'd like to point out a couple of minor things preventing us from merging this. First is that this PR should be targeting the release34 branch of nrkno/tv-automation-server-core. The releaseXX branches can be considered our "develop" branch and we like to only merge stable releases to master. Besides that starting release 33 the playout-gateway is part of the server-core "monorepo" so this repository is only receiving updates for master, release31 and release32 (after which we plan to archive this repo)
Code-wise this PR looks good but the layer mappings should also contain an index field and an inputLayer field as per the interfaces found here: https://github.com/nrkno/tv-automation-state-timeline-resolver/blob/release34/src/types/src/vmix.ts#L17

Morning @baltedewit
Not a problem, I'll close this PR and submit a new one against the correct branch / repo with the missing fields added!


Add asyncapi optimize command

This issue is for https://www.openforce.tech/ participants. If you do not participate in this even please pick up other issue from this repo, there is plenty of help needed 😄

Reason/Context
We need to enable the community to use all AsyncAPI tools in CLI if only possible -> https://github.com/asyncapi/optimizer
Description

add new command asyncapi optimize that uses https://github.com/asyncapi/optimizer and enable users to optimize single AsyncAPI file
user should be able to pass one files to the optimizer asyncapi optimize <context/filepath/url> (getting file from context or filepath or URL is already provided in  CLI, you just use load function)
by default it would optimize the document and print to the terminal, but user should be able to specify to get only the report, with flag --report
by default full optimization is done, but user should be able to specify --rules where user can provide rules that should be applied by optimizer

This issue is for https://www.openforce.tech/ participants. If you do not participate in this even please pick up other issue from this repo, there is plenty of help needed 😄

@KhudaDad414 pinging you so you are aware 😄

Hey @derberg , I am Ashish Tom, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you

@alceil that's great. If you have any problems or questions regarding the tool itself, please do let me know.

Thanks @KhudaDad414

@KhudaDad414 any type of similar command I can refer too?

Hey @KhudaDad414 I have raised a pull request. Could you please review it?


fix extents on overlay_spatial_map

Can you add an offset term? So the user can shift the image around? I think you could just edit the 'x' and 'y' variable definitions like:
   x = elec_pos[:,0] + offset[0]     y = elec_pos[:,1] + offset[1]

yes, it's already in the other pull request #603


Add ability to build different versions of Python

Currently, the version of Python built by Mayflower is hard-coded. We need the ability to pass a version of Python to build.

tackled in 0.6.0


error: Panic if no syslog socket exists.

Hello, I am using the -s option of crucible to get machine readable output during early boot.
This is before the syslog daemon has been started and can not be shifted to a later point.
 It would be nice if there was a flag to toggle between syslog/stderr and one to toggle between machine and human.
Nevertheless I think crashing in this case is a bug that needs fixing for my usecase.
In this case there should probably be no logging done.
I would submit a pull request for my flag proposal but I am not sure how to include this in a backwards compatible way.
I think keeping the -s flag to default to machine readable + syslog and then including another flag to force stderr is probably the best approach.

Which Go version are you compiling Crucible with?

I am using the 2022.05 binary release.
I think the issue should be a missing error check in:
https://github.com/usbarmory/crucible/blob/5e0805300e15bdebb8d50ea8bf1d1e2ac4f9dcb7/cmd/crucible/crucible.go#L334
Syslog.new delegates to:
https://cs.opensource.google/go/go/+/master:src/log/syslog/syslog_unix.go;drc=f229e7031a6efb2f23241b5da000c3b3203081d6;l=17
Which returns an error if the socket does not exist yet.

If logwriter is nil (passed to log.SetOutput) I'd not expect Go to panic, it feels to me that Go log package should do better. Anyway I can avoid setting log output if logwriter is nil.
This commit should fix the issue, please close if confirmed. Thanks!

Thanks I'll try and come back to you later today, looks like the default is logging to stderr so it should work out.
Sadly our toolchain (yocto dunfell release) does not support the version of go needed for crucible.
That is the reason I was using the binary release.
If it is not to much to ask could you do a new release that includes this fix?
Otherwise we have to include a manually build binary without provenance back to the official releases.

So do you consider this fixed or not? If not which behavior would you like to have? I can just bail if -s is set and no logger is available.

The problem is we are logging to stdout and not stderr.
I am using the -s option to get machine readable output, if we log to stdout tho when -s is passed the output is interspersed with the log messages.
In other words, there currently is no way to get machine readable output if syslog is not installed.
I think it would make sense to log to stderr by default in case -s is set and upgrade to syslog if it is available.
Otherwise the -s option is still useless if syslog is not around sadly.

Why can't you redirect stdout to a file of your choice? I don't understand why stderr, instead of stdout, would make things easier for you.

Because we have two streams, the machine readable output and the log.
Currently, if syslog is found all logging goes to syslog and all machine readable output to stdout.
This is perfect since stdout ONLY contains machine readable output, that can be directly parsed.
With the change as is the log and the supposedly machine readable output get "mixed together" in stdout if there is no syslog.
So stdout contains machine readable output AND logging messages in case syslog is not found.
This makes it useless for interpreting the output since now you all of the sudden need to filter out the log messages.
That is why unix utilities usually write output for human consumption to stderr and for machine consumption to stdout.
Sorry that I wasn't clear enough on that part before.
Basically I need logging and machine output on two different streams like it is when syslog is found.
I don't really care about the logging at all, it could be disabled for my usecase. What I do care about is getting a stream of only machine readable output.

Please see if this would work:
diff --git a/cmd/crucible/crucible.go b/cmd/crucible/crucible.go
index eea54e4..e9aae10 100644
--- a/cmd/crucible/crucible.go
+++ b/cmd/crucible/crucible.go
@@ -333,6 +333,8 @@ func main() {
 	if conf.syslog {
 		if logwriter, _ := syslog.New(syslog.LOG_INFO, "crucible"); logwriter != nil {
 			log.SetOutput(logwriter)
+		} else {
+			log.SetOutput(os.Stderr)
 		}
 	} else {
 		log.SetOutput(os.Stdout)

Working with your patch now.
Thank you so much!
It would be great if you could do a release so we could actually use the fix.

New release containing the fix has been created: https://github.com/usbarmory/crucible/releases/tag/v2023.04.12


don't panic on missing schema

It sounds like this is a scenario when the endpoint has no response (right?). For that scenario, we should still include something for the gRPC response as it's required. I'm thinking this case should be setup to use an Empty type, like we already do a few lines below your proposed changes: https://github.com/NYTimes/openapi2proto/blob/eb790836e6efb76313441f0f57fee87894b85485/openapi.go#L348
If you're willing, I would suggest changing this PR to:

Change the responseName to use google.protobuf.Empty when no 'Schema' has been included.
Change the semantic_api test fixture to include this style of empty response and make sure everything works as expected. (no proto object is created and the endpoint definition is using an Empty message)

Actually, now that I think about it, this may be resolved it we just change the 'Schema' attribute here to be a non-pointer: https://github.com/NYTimes/openapi2proto/blob/master/openapi.go#L45
Then, the string will just be considered empty and the Empty type will get used by the process.

that sounds reasonable

This has been resolved in PR #16. If no schema is supplied, a google.protobuf.Empty will be used.


edit selector background color

Can you share screenshots of this change applied for us to verify its working. Thnaks!


Fix warning

Fix warnings...

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


use branch names when querying for CI badges

Despite galactic branching off from rolling, the README file in rolling must display the CI status of the galactic branch, and instructions on how to build the galactic branch.
This PR will be backported into the galactic branch too.

Once merged, should try backporting this to Galactic branch.

@Mergifyio backport galactic


Client Allocation Request for: euid

Client Allocation Questions
Core Information

Name: euid
Website / Social Media: euid, (euid, euid)
Region: Oceania
DataCap Requested: 32 GiB
Addresses to be Notarized: euid
Notary Requested: BingHe Web3.0 Lab

This user’s identity has been verified through filplus.storage


Make ItemId local to the BindgenContext.

See for example #204, where that caused an spurious name change.

Please make a comment here if you intend to work on this issue. Thank you!

We should create a new field in BindgenContext, called last_item_id, and use and increment that instead of the global atomic.

This was blocking stuff, so I just did it in #263


Reconsider transpiling arrow function

I saw previous issue about this (#4), however in v1.2.0 React support was added.
Would you consider transpiling the arrow functions now?

No, but you can use https://github.com/sindresorhus/react-extras, which ships with a transpiled version of this module.


Scroll wheel too slow

Scrolling does not scroll in a direction as much as expected.
Platform: Windows

Mm it's a hard one because on macOS it scrolls about what I expect. Are you using a trackpad or a scroll wheel? I might add an option to the config file to allow for changing how many lines it scrolls by.

I am using a scroll wheel.

@C0ffeeCode You can now set how many lines are scrolled using the configuration option introduced in https://github.com/trimental/inlyne/pull/33 so I'll close this as completed :)


Dev - coal and oil refinery upgrades

Hello! I wanted to introduce myself real quick via pull request. I'm Leastwise, and I'm working on FoxHoleLab https://leastwise.github.io/foxholelab/, which I think shares some DNA with your facility planner! In any case, if you don't mind me working on the facility planner, I'm happy to submit more pull requests as I have time. For this first one, I've added the upgrade data for the coal refinery and petrol refinery.

Sweet thanks! Also your tool looks really neat, I didn't know about it.


Add support for plain HTML pages

These could then be copied verbatim from the _pages directory to the _site directory. We could also use static analysis to parse them so they can be automatically added in navigation and sitemaps, etc.

Stuff like this can also easily be created using build tasks (by copying arbitrary files)


Module not found: Can't resolve 'react-facebook-pixel' in '/Users/XXX/Projects/XXX/src'

When I upgrade react-facebook-pixel to 1.0 in my React project and try to run it, I face the problem.

Please try using<EMAIL_ADDRESS>

I have same trouble.
npm install --save<EMAIL_ADDRESS>not helped.

Please make sure you're importing from same project.
import ReactPixel from '@zsajjad/react-facebook-pixel';

I tried
# npm install --save<EMAIL_ADDRESS>npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@zsajjad%2freact-facebook-pixel - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

it not sound good : (
And if i check official released version https://github.com/zsajjad/react-facebook-pixel/releases there is maximum 1.0.0, not 1.0.1.
After this I tried npm install --save @zsajjad/react-facebook-pixel and same result. Only one what I can install is npm install --save react-facebook-pixel but in this case no one of variants
import ReactPixel from '@zsajjad/react-facebook-pixel';
or
import ReactPixel from 'react-facebook-pixel';
not work : (

I got the above same error

Same issue here

Unable to reproduce at my end, I wish if anyone can share demo repo.

It saw that trouble is in npm repository. If I used yarn with react create aplication, it work.
# npx create-react-app player
# cd player/
# yarn add @zsajjad/react-facebook-pixel // failed
# yarn add react-facebook-pixel // ok, installed it version 1.0.3
# yarn start

in App I used import ReactPixel from 'react-facebook-pixel';

I tried the new version 1.0.3, no problem with the new version.

BTW, I think you misunderstanding "NPM package registry" and" Github package registry"
When using the "Github package registry", npm install --save @zsajjad/react-facebook-pixel it may work, but for most users using the "NPM package registry," it does not work.

Yes i got that now. Apologies for inconvenience caused.

Thank a lot for fixed. I confired that it work.

Confirmed it's fix, thanks :)


Protein group outputting more unique peptides than unique peptides tsv

Need to find example

probably fixed in #958 ; ambiguous peptides are not listed in protein groups now


Fix "Failed linking C shared library mod_md.so"

The cURL variable was declared but not assigned, resulting in a "Failed linking C shared library mod_md.so" error because cURL was not found. This change will automatically find and assign values to cURL variables, fixing the error that cURL cannot be found during HTTPD compilation without having to recompile cURL again as the solution in this error.
And trim trailing spaces.

Thanks for the PR. Admittedly, I am not using cmake and am unable to verify. I am willing to merge that. If you would then care to check the results?

@icing Thanks for the PR. Admittedly, I am not using cmake and am unable to verify. I am willing to merge that. If you would then care to check the results?

Hi, of course! I have been using the modified CMakeLists.txt file as in the commit, I can provide some screenshots that HTTPd has successfully detected the cURL library file and successfully compiled without error below:

P/s: I also tried cURL as static library and of course it didn't have any error.
I have tested and verified the modifications in the CMakeLists.txt file on all recent versions (include latest version), and the tools (cmake, nmake,...) and source code (HTTPd, APR, cURL,...) that I use are all the latest, all compiled successfully without errors.
It works very well, much better than the previous solution I provided which was to have to compile cURL again during HTTPd compilation (as in bugzilla I said).

Submitted as r1909215 in apache subversion (trunk).
I removed the whitespace changes to focus the commit on the relevant lines and making merging this into the 2.4.x branch easier. I will propose this for backport.

Submitted as r1909215 in apache subversion (trunk).
I removed the whitespace changes to focus the commit on the relevant lines and making merging this into the 2.4.x branch easier. I will propose this for backport.

It looks good to me. I am looking forward to these changes in the next release version. As for spaces, I can remove it manually.

I see lines 497 and 798 in the CMakeLists.txt file which still haven't been trim trailing spaces in the release source file.


Added webkit-font-smoothing

Here I've added webkit font smoothing to make it look nicer on Mac's
Before:

After:

Stylesheet changes is done in .less-files, .css is generated

Ah ok, I'll close this and re-open it after changing the less files


Missing library definitions for luxon 0.4.0

Latest library definition for luxon were added in https://github.com/flowtype/flow-typed/pull/1654.

c3b3f3ca5d0f192f6de29bd8e166287b5fbabc5e


Procfile, V3DemoProcfile: add default endpoint of v3 to Procfile remo…

…ve V3DemoProcfile
The flag --experimental-v3demo is already removed so V3DemoProcfile
cannot be used. This commit removes it and adds a default v3 endpoint
to Procfile for easy testing.

Same port can be used for both of http request and gRPC thanks to cmux, so providing dedicated endpoints isn't required? Should I change the default endpoint in etcdctlv3 instead of Procfile?

@xiang90 How do you think about this change and the default endpoint for gRPC? I think simply changing the default endpoint of etcdctlv3 from 2379 to 12379 is fine.

@mitake We cannot do this right now since the proxy does not support v3. You have to start v3 with goreman -f V3DemoProfie start for dev for now.

@xiang90 then only removing the obsolete flag from V3DemoProcfile is acceptable? The file cannot launch etcd processes now.

@mitake Yea. Please do that. Thanks!

@xiang90 removed the flag, PTAL.

lgtm