Windows on ARM build failure

https://productionresultssa3.blob.core.windows.net/actions-results/24237da9-dda5-47bc-a9fd-452cc410eaf3/workflow-job-run-4a13ad0d-0167-5dd3-f236-cf59b2a15bbd/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-04-22T19%3A19%3A06Z&sig=t0nTjE%2BEN1WHJNPU1mXlsbIVHeLWvgY1Cj9B0mycn84%3D&sp=r&spr=https&sr=b&st=2024-04-22T19%3A09%3A01Z&sv=2021-12-02:
2024-04-22T14:03:02.6733491Z ld.lld: error: undefined symbol: ff_dovi_configure
2024-04-22T14:03:02.6734309Z >>> referenced by libavcodec/libsvtav1.o:(eb_enc_init)
2024-04-22T14:03:02.6735068Z >>> referenced by libavcodec/libx265.o:(libx265_encode_init)
2024-04-22T14:03:02.6735587Z
2024-04-22T14:03:02.6735857Z ld.lld: error: undefined symbol: ff_dovi_rpu_generate
2024-04-22T14:03:02.6736845Z >>> referenced by libavcodec/libsvtav1.o:(eb_receive_packet)
2024-04-22T14:03:02.6737638Z >>> referenced by libavcodec/libx265.o:(libx265_encode_frame)
2024-04-22T14:03:02.6798844Z clang: error: linker command failed with exit code 1 (use -v to see invocation)

Upstream issue, just got fixed five minutes ago.


[WIP] Remove amazon-web-services and kinesis folders + settings.gradle cleanup

Fully remove deprecated v1 aws IOs. https://github.com/apache/beam/pull/33416 and https://github.com/apache/beam/pull/33455 removed all dependencies of this.
Fixes https://github.com/apache/beam/issues/33430

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

cc/ @aromanenko-dev @Abacn

Actually, moving back to draft. I missed one more piece which needs to be dealt with first - https://github.com/apache/beam/blob/df0ee4138f10224b2c1368131243cf808c9b99bb/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L2203


Anjali/no state component

Added new optional property in iModelGrid props to override default no state component.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix PUT shorthand doc

Hey there,
I think there is a typo in the current documentation :)

thank you!


Add initial resources for p5.Framebuffer

Addresses https://github.com/processing/p5.js-website/issues/1340 and https://github.com/processing/p5.js-website/issues/1341 but won't close them because some other contributors are going to expand upon these and add more. Mostly I just wanted to make sure we had some resources for p5.Framebuffer on the site to go out with the release of the feature.
Changes

Adds a Learn page with some explanation of framebuffers
Adds a framebuffer example
Updates prism to include glsl syntax highlighting

As a heads up, I don't think we want to merge this in until we update the version of p5 distributed with the website, as the reference links in the Learn page don't all exist yet, and the example depends on new features that will be in the next version of p5. If you want to see a live version of the example in the mean time, I have a p5 editor version here: https://editor.p5js.org/davepagurek/sketches/GoQ9A3fro
Screenshots of the change
Learn page

Example

Thanks Dave. We will merge this PR after the next upcoming p5.js release.


fix: Use amazon alias for worker ami owner instead of owner id

PR o'clock
Description
Use amazon alias for for worker ami owner instead of setting the owner id. Those owner ids are different by region, but the alias remain the same.
Resolves https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1037
Resolves https://github.com/terraform-aws-modules/terraform-aws-eks/issues/480
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/824
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/480
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

@terraform-aws-modules/triage-supporters Someone can help me review this ? I'm not a ninja of AMI filtering, so I would like have your feedback on this change. I don't know why we're using the AWS owner ID instead of alias since the beginning. I probably missed something.

I usually debug this is by running TF_LOG=debug terraform plan and see what kind of API call terraform sends to AWS. Example code should be very small to actually understand the verbose response.

The Amazon EKS node images from the container team are not in the same account as standard images from the EC2 amazon linux team. Although it appears that they both have the amazon ImageOwnerAlias. Maybe in the before times when the module was written this was not true so the account ID had to be specified?
Interesting that account aliases are not a one-to-one mapping to account IDs.
For example grab the, at time of writing, latest image for Amazon Linux 2 AMI (HVM) SSD 64-bit x86 (in us-west-1 it's ami-0bb3fad3c0286ebd5), and query for the OwnerId and ImageOwnerAlias:
aws ec2 describe-images --image-ids ami-0bb3fad3c0286ebd5 --query Images[].[Name,OwnerId,ImageOwnerAlias]
[
    [
        "amzn2-ami-hvm-2.0.20200917.0-x86_64-gp2",
        "137112412989",
        "amazon"
    ]
]

The current EKS 1.17 AMZN2 image in us-west-1 is ami-0c557e2a5ede1bae3:
aws ec2 describe-images --image-ids ami-0c557e2a5ede1bae3 --query Images[].[Name,OwnerId,ImageOwnerAlias]
[
    [
        "amazon-eks-node-1.17-v20201002",
        "602401143452",
        "amazon"
    ]
]

Existing module query:
$ aws ec2 describe-images --owner<PHONE_NUMBER>52 --filter 'Name=name,Values=amazon-eks-node-1.17-v*' --query 'sort_by(Images, &CreationDate)[].[Name,ImageId]' --output text | tail -n1
amazon-eks-node-1.17-v20201002	ami-0c557e2a5ede1bae3

$ aws ec2 describe-images --owner<PHONE_NUMBER>08 --filter 'Name=name,Values=Windows_Server-2019-English-Core-EKS_Optimized-1.17-**' --query 'sort_by(Images, &CreationDate)[].[Name,ImageId]' --output text | tail -n1
Windows_Server-2019-English-Core-EKS_Optimized-1.17-2020.09.09	ami-059dd50aa82b04356

New query:
$ aws ec2 describe-images --owner amazon --filter 'Name=name,Values=amazon-eks-node-1.17-v*' --query 'sort_by(Images, &CreationDate)[].[Name,ImageId]' --output text | tail -n1
amazon-eks-node-1.17-v20201002	ami-0c557e2a5ede1bae3

$ aws ec2 describe-images --owner amazon --filter 'Name=name,Values=Windows_Server-2019-English-Core-EKS_Optimized-1.17-**' --query 'sort_by(Images, &CreationDate)[].[Name,ImageId]' --output text | tail -n1
Windows_Server-2019-English-Core-EKS_Optimized-1.17-2020.09.09	ami-059dd50aa82b04356

Looks good to me.

Thanks @dpiddock.

This doesn't actually resolve #480, because for some reason, the account that owns the EKS AMIs in ap-east-1 has no alias whatsoever:
$ aws ec2 describe-images --region ap-east-1 --image-ids ami-0824aac4c54c763d3 --query 'Images[].Name,OwnerId,ImageOwnerAlias]' --output text
amazon-eks-node-1.18-v20201007<PHONE_NUMBER>65    None

$ aws ec2 describe-images --region ap-east-1 --owner<PHONE_NUMBER>65 --filter 'Name=name,Values=amazon-eks-node-1.18-v*' --query 'Images[].[Name,ImageId]' --output text
amazon-eks-node-1.18-v20201007  ami-0824aac4c54c763d3

$ aws ec2 describe-images --region ap-east-1 --owner amazon --filter 'Name=name,Values=amazon-eks-node-1.18-v*' --query 'Images[].[Name,ImageId]' --output text

$

That being the case, I don't think there's any way to really fix this other than either hard-coding a default list of multiple owner IDs, hard-coding a default mapping between regions and owner ids, or just expecting the module user to figure it out on their own. Or, I guess, bugging Amazon to add an account alias to<PHONE_NUMBER>65.

Hummm... Maybe the right way to fix this is to use the SSM datasource to get the AMI ID. But I don't know how to do that without breaking all the AMI filtering logic in this module.


Save JWT in cookies and allow user to reopen their last generator

I'm sorry but I cannot accept this PR, this is not the purpose of Clic'Attestation, =users may be confused about how the solution actually works if we provide two different ways of saving their data. Plus, cookie setting is ruled by the GDPR and cannot be done without express user content. I hope you understand.


UI Select not showing up the selected element in dropdown (IE 11)

Hi,
I am having issue with the dropdown populated using UI select not able to show the element which had been selected earlier. This issue is only coming in IE11, I tried checking the same with the demo of UI select and unfortunately it has the same issue too.
Below is the screenshot of the issue in IE11 , I had selected "natasha" from dropdownlist and once I try to open it back again it would not show the same in dropdownlist as highlighted.

This is the same issue I am facing in my project, please let me know if there is any solution for the same. Thanks :)

Hi @sumodhnair19,
So I had a look if I can reproduce this issue but unfortunately I cannot.
Here is a demo maybe you can check if it is already solved or if I have a wrong version.
Demo: http://plnkr.co/n9ZlgzUcLIfSKQMx13YB

@sumodhnair19  Any feedback or is this issue closed?

@Jefiozie  I had a change in requirement in the project I was working on so I didn't give much emphasis on it. As I can check in the demos I am not able to reproduce the issue now. It is fixed now. Thanks

what was the resolution, could you please explain?


[release-4.13] create a mechanism to deploy odf using operator-sdk

This is an manual cherry-pick of #394 #412

/cherry-pick release-4.12


Our issue is to do with the alias record sets linked to Azure Public IP Address resources.

Our issue is to do with the alias record sets linked to Azure Public IP Address resources. is this limited to 20 ??
as i am unable to add more than 20 record sets using "Alias record set"
I see 20 as a limit for number of records in a record set so looking for clarification on this document if the limit is on the assignment of these record sets/ records to an IP address actually??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd0a3a26-4d9a-9dde-734d-1ed812852bed
Version Independent ID: 0402dbe1-91b2-2adf-15b6-4b90a5bcda3e
Content: Azure DNS FAQ
Content Source: articles/dns/dns-faq.md
Service: dns
GitHub Login: @vhorne
Microsoft Alias: victorh

@peddabavisriram the limit is 20 records per record set. If you need additional records, you will need to put them in a different record set.

Hello Travis,
As spoke offline on skype:
so its not that he has more than 20 records in a set
its that he has more than 20 records pointing to single resource using alias records.
Will be waiting for an update.

i have got no update from Quota team on the exact ask of cx, if we will be able to increase the number of alias records pointing a single public ip form 20, as cx see the limit as 20, but what we have been said from quota team is that we wont be able to increase number of records in a record set from 20.

@peddabavisriram We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Improve tfidf

Docstring now includes formula/explaination.
Normalization disabled (the option "normalization=None" was "hidden" in the sklearn code, so that turned out to be an easy fix).
Representation Series is already being handled (although output is still like before, using representation_series_to_flat_series).
Function representation_series_to_flat_series added.
Unit tests are changed accordingly, also one with the explicit calculation using the formula.

Nice! 🎉
Review:

Is said that max_features has default values 300 but is None.
lowercase=False not necessary as is already tokenized
We should probably mention in the docstring that in contraposition to scikit-learn TfidfVectorizer (add a link), tfidf do not normalize the ouput (we will later add under "See Also" .norm())
If you want to go further, you might want to unit-test max_features, min_df and max_df 👍

Thanks, fixed the issues (not without some git trouble :face_with_head_bandage:).

If you want to go further, you might want to unit-test max_features, min_df and max_df +1

This lead to finding some other bugs in the functions, so thanks! Testing really does work :neckbeard:

Thanks, fixed the issues (not without some git trouble 🤕).

I see; take it as a learning experience ... when working with Git, something suuper useful is to have a software to deal with this kind of troubles; I love and use Fork: it's fast and friendly. Check it out!

This lead to finding some other bugs in the functions, so thanks! Testing really does work

That's great! I'm also learning the importance of always testing! What were the issues and how did you find them? I'm sure I can learn something :)
Review:
Everything seems great! The only part I'm not 100% convinced is the representation_series_to_flat_series  function (but it's the hardest part), especially:

Would be better if we avoid the reindex as well as having to pass the flattened index as argument
What is called "missing values" are tfidf values for term that are not present in the document. The values, in this case, should rather be 0.

For you to know, I will test this part later today or tomorrow.

What were the issues and how did you find them? I'm sure I can learn something :)

For example, using the min_df parameter, I noticed that the documents for which no token was selected as a feature, they completely disappeared. So to be able to continue using the index, I had to change some stuff (see below).

Would be better if we avoid the reindex as well as having to pass the flattened index as argument

For the representation_series_to_flat_series, the function is meant to handle all Representation Series, not just the tfidf one, and in general I believe that we cannot recover the original Index from a Sparse Representation Series. For example, if we have a Pandas Series with documents doc1, doc2, doc3, doc4 in the index, if the tfidf (or another function later on) does not calculate any tfidf scores for doc3 (e.g. because all the words in doc3 are below the min_df threshold), the Sparse Pandas Series will just leave doc3 out completely. So to be sure to recover all documents, we need to pass the original index of s. That is what I noticed through testing with min_df. If no documents are "lost" in the Sparse Representation, we have no problem. But if it can be the case that we calculate no features for some documents, they would be lost instead of NaN without the reindex.

What is called "missing values" are tfidf values for term that are not present in the document. The values, in this case, should rather be 0.

Yes, when  representation_series_to_flat_series is called in tfidf, it's called with fill_missing_values=0.0 to do this. But if there's a document where the actual value is nan before calling tfidf, it will stay which I think makes sense.

I love and use Fork: it's fast and friendly. Check it out!

Thanks, I'll have a look!

Thank you for pointing these details out; now it definitely makes more sense to me; sorry!


Add LICENSE

Need to finalize between :

Apache 2.0
MIT

Added with commit b1c1e53d59fd6d93401c0400a745e224072724c7 and 02809e58a262d6786c3a3f08ed83d9bcf705ba81
❯ reuse lint
# SUMMARY

* Bad licenses:
* Deprecated licenses:
* Licenses without file extension:
* Missing licenses:
* Unused licenses:
* Used licenses: MIT
* Read errors: 0
* Files with copyright information: 71 / 71
* Files with license information: 71 / 71

Congratulations! Your project is compliant with version 3.0 of the REUSE Specification :-)


Connection to chirpstack

Guys, do you know how to connect your virtual-lorawan-device to chirpstack?
I tried this one config:

[packet_forwarder.default]
host = "gateway bridge ip:1700"
#host = "localhost:1700"
mac = "f69e8a9ca4a0236f"

But got this line: [2022-05-23T14:53:16Z WARN  virtual_lorawan_device::virtual_device] one      No Join Accept Received

I've done it before, yes. Did you see the connection on CS? You have to make sure the regions and EUIs match what you have on the CS LNS part.

But gateway status is Never seen despite mac = GWID

@lthiery , http://<IP_ADDRESS>:9898/ give me this:
# HELP join_fail join fail counter
# TYPE join_fail counter
join_fail{server="prod"} 149

Right, so that's just telling you that Joins are failing which is 100% expected if you're not getting the data to show up on CS yet.
Maybe try reverseing the MAC bytes for GWID? Maybe there's an endianness disagreement between the utility and CS. I last connected them over a year ago, so that might've been a thing I did to solve it.

@lthiery , no, it doesn't work

@lthiery , I use your release and also the same problem on Ubuntu:
root@ip:/home/repositories/virtual-lorawan# ./virtual-lorawan-device
Error: Config(configuration file "./settings/default.toml" not found)
root@ip-172-31-1-117:/home/repositories/virtual-lorawan# ./virtual-lorawan-device
[2022-05-23T18:39:10Z INFO  virtual_lorawan_device::metrics] Prometheus Server listening on http://<IP_ADDRESS>:9898
[2022-05-23T18:39:10Z INFO  virtual_lorawan_device] Creating packet forwarder default connecting to <IP_ADDRESS>:1700 from <IP_ADDRESS>:0
[2022-05-23T18:39:10Z INFO  virtual_lorawan_device::virtual_device::udp_radio] Transmit tmst: 77117
[2022-05-23T18:39:16Z WARN  virtual_lorawan_device::virtual_device] one      No Join Accept Received
[2022-05-23T18:39:16Z INFO  virtual_lorawan_device::virtual_device::udp_radio] Transmit tmst: 6178620
[2022-05-23T18:39:22Z WARN  virtual_lorawan_device::virtual_device] one      No Join Accept Received
[2022-05-23T18:39:22Z INFO  virtual_lorawan_device::virtual_device::udp_radio] Transmit tmst: 12280415
[2022-05-23T18:39:28Z WARN  virtual_lorawan_device::virtual_device] one      No Join Accept Received
[2022-05-23T18:39:28Z INFO  virtual_lorawan_device::virtual_device::udp_radio] Transmit tmst: 18381603

Can you check on the CS system and confirm that the UDP packets are making it into the OS? You could use pcap or something.

@lthiery , here is the log from tcpdump -n udp port 1700:
ubuntu@ip:~$ sudo tcpdump -n udp port 1700
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on veth52727cb, link-type EN10MB (Ethernet), capture size 262144 bytes
20:06:10.254889 IP <IP_ADDRESS>.43616 > <IP_ADDRESS>.1700: RADIUS, Access-Accept (2), id: 0x41 length: 290
20:06:10.255731 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.43616:  [|radius]
20:06:11.996320 IP <IP_ADDRESS>.46561 > <IP_ADDRESS>.1700: RADIUS, Access-Accept (2), id: 0x92 length: 111
20:06:11.996908 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.46561:  [|radius]
20:06:12.903849 IP <IP_ADDRESS>.58527 > <IP_ADDRESS>.1700:  [|radius]
20:06:12.904279 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.58527:  [|radius]
20:06:13.232615 IP <IP_ADDRESS>.58527 > <IP_ADDRESS>.1700: RADIUS, Access-Accept (2), id: 0xd6 length: 202
20:06:13.233581 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.58527:  [|radius]
20:06:13.864790 IP <IP_ADDRESS>.60802 > <IP_ADDRESS>.1700:  [|radius]
20:06:13.865037 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.60802:  [|radius]
20:06:13.933467 IP <IP_ADDRESS>.39236 > <IP_ADDRESS>.1700:  [|radius]
20:06:13.933705 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.39236:  [|radius]
20:06:19.358886 IP <IP_ADDRESS>.58527 > <IP_ADDRESS>.1700: RADIUS, Access-Accept (2), id: 0x15 length: 202
20:06:19.359644 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.58527:  [|radius]
20:06:22.916166 IP <IP_ADDRESS>.58527 > <IP_ADDRESS>.1700:  [|radius]
20:06:22.916562 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.58527:  [|radius]
20:06:23.958658 IP <IP_ADDRESS>.39236 > <IP_ADDRESS>.1700:  [|radius]
20:06:23.959050 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.39236:  [|radius]
20:06:23.964946 IP <IP_ADDRESS>.60802 > <IP_ADDRESS>.1700:  [|radius]
20:06:23.965177 IP <IP_ADDRESS>.1700 > <IP_ADDRESS>.60802:  [|radius]

my ip is <IP_ADDRESS>

Sure does look like it's making it to the server... so it's gotta be something else.
Have you checked that the region is properly set? That's the only other gotcha that comes to mind from when I set it up.

yes, I did:

default_server = "prod"
default_packet_forwarder = "default"
# if any explicit packet forwarders are defined in settings.toml,
# this packet forwarder is pruned from the map
[packet_forwarder.default]
host = "chirp-gateway-bridge:1700"
#host = "<IP_ADDRESS>:0"
#mac = "f69e8a9ca4a0236f"
mac = "0807060504030201"
#mac = "f607ef85003ed77e"

[device.one]
region = "EU868"
[device.one.credentials]
dev_eui = "3ed43bef1857ef4b"
app_eui = "35BEED137AC3344B"
app_key = "49660c28e41609415025366051b12982"

I meant on Chirpstack, but I assume you've configured the gateway or end-device to be the right thing there too.
I wish there was a debug view on Chirstpack to understand what it's doing with the packet...

Oh, that's the other thing! Did you check the endianness of the DevEui/AppEui? There's some MSB/LSB conflict somewhere along the way I remember.

@lthiery , you were right, the problem was in Gateway ID - it should be LSB in chirp. Big thanks ;) you are a great man!!!

@lthiery , you were right, the problem was in Gateway ID - it should be LSB in chirp. Big thanks ;) you are a great man!!!

Glad it worked out!

@sergorl i actually had an old commit where i flip it back so its directly compatible with CS. Just a heads up so you don't spend too much time scratching your head next release
https://github.com/helium/virtual-lorawan-device/commit/a4e97db32e5b71649f45eed4289f7e15b49d1953


Roll engine e3687f70c7ec..36aa0ed526fa (6 commits)

https://github.com/flutter/engine/compare/e3687f70c7ec...36aa0ed526fa
git log e3687f70c7ec..36aa0ed526fa --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15<EMAIL_ADDRESS>Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029)
2018-08-15<EMAIL_ADDRESS>Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028)
2018-08-15<EMAIL_ADDRESS>Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026)
2018-08-15<EMAIL_ADDRESS>Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15<EMAIL_ADDRESS>Update docker image tag and README (flutter/engine#5995)
2018-08-15<EMAIL_ADDRESS>Add message encoding/decoding utility to FML. (flutter/engine#6017)
The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://flutter-engine-flutter-roll.skia.org

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


Rebase prow-staging from master

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ericvn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: linsun, ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @linsun @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This should use the newer prow image (Golang 1.12.5 and Bazel 0.26.0 based) as it's on the prow-staging branch.

@ericvn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test istio-unit-tests-master

prow/e2e-simpleTests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@ericvn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5c1f917439a49f53bba8c6104fd2ec00a7866c4a
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Close for now since we did get a test kicked off in this branch with the new prow image and e2e-simpleTest passed.


[feature] Add logseq parser

Logseq allows users to build their own knowledge base,  so support logseq parser is very useful,  enhance its query ability

I will submit a pr


Add unix_timestamp() and to_unix_timestamp() Spark functions

Summary:
Adding unix_timestamp() and to_unix_timestamp() Spark functions to
Velox since they are used by many pipelines. They are aliases, except that
unix_timestamp() has an overload without parameters that returns the current
epoch.
Differential Revision: D44810400

@pedroerp Thanks. We would need to figure out how to register these functions in Presto-on-Spark. Currently, it registers only Presto functions. It looks like we'll need to register a subset of Spark functions as well.

Yeah, from the Velox side it should be easy enough to register these functions under a "spark." namespace/schema, but we need to discuss the best way to get them registered in the Java analyzer.


Syntax Error in viralverify.py

Running the viralverify.py script, I found this syntax Error
File "./viralverify.py", line 173
    open (f"{res_path}_virus.fasta", "a").close()
                                  ^
SyntaxError: invalid syntax

These the packages in my environment:
packages in environment at ~/miniconda2/envs/viralverify:

Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
ca-certificates           2021.4.13            h06a4308_1
certifi                   2020.12.5        py39h06a4308_0
hmmer                     3.3.2                he1b5a44_0    bioconda
ld_impl_linux-64          2.33.1               h53a641e_7
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.1.0                hdf63c60_0
libstdcxx-ng              9.1.0                hdf63c60_0
ncurses                   6.2                  he6710b0_1
openssl                   1.1.1k               h27cfd23_0
pip                       21.1.1           py39h06a4308_0
prodigal                  2.6.3                h516909a_2    bioconda
python                    3.9.5                hdb3f193_3
readline                  8.1                  h27cfd23_0
setuptools                52.0.0           py39h06a4308_0
sqlite                    3.35.4               hdfb4753_0
tk                        8.6.10               hbc83047_0
tzdata                    2020f                h52ac0ba_0
wheel                     0.36.2             pyhd3eb1b0_0
xz                        5.2.5                h7b6447c_0
zlib                      1.2.11               h7b6447c_3

Hello!
Based on miniconda2 in your path, I suspect that you are using Python2.x. In the viralVerify code there are some features that appeared only in Python3, such as f-strings.

Hello! Thanks for answering so quick :)
If you check the environment packages, we see the python version 3.9.5.
But, to test, I changed to miniconda3, and I still have the same error
# packages in environment at ~/miniconda3/envs/viralverify:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
ca-certificates           2021.4.13            h06a4308_1
certifi                   2020.12.5        py39h06a4308_0
hmmer                     3.3.2                he1b5a44_0    bioconda
ld_impl_linux-64          2.33.1               h53a641e_7
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.1.0                hdf63c60_0
libstdcxx-ng              9.1.0                hdf63c60_0
ncurses                   6.2                  he6710b0_1
openssl                   1.1.1k               h27cfd23_0
pip                       21.1.1           py39h06a4308_0
prodigal                  2.6.3                h516909a_2    bioconda
python                    3.9.5                hdb3f193_3
readline                  8.1                  h27cfd23_0
setuptools                52.0.0           py39h06a4308_0
sqlite                    3.35.4               hdfb4753_0
tk                        8.6.10               hbc83047_0
tzdata                    2020f                h52ac0ba_0
wheel                     0.36.2             pyhd3eb1b0_0
xz                        5.2.5                h7b6447c_0
zlib                      1.2.11               h7b6447c_3

Well, maybe the problem was in shebang string - it was just updated it to #!/usr/bin/env python3, in order to work properly with environments, probably it will work now, please update and check.


Random crashes when opening a project

Godot version
4.2 031aa99
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>3) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
When opening any project on the current master I'm randomly getting this crash:
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.2.dev.custom_build (031aa99d313ceec7cdb8263957d22cae10de0b95)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] mtx_do_lock (D:\a\_work\1\s\src\vctools\crt\github\stl\src\mutex.cpp:91)
[1] std::_Mutex_base::lock (C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\mutex:50)
[2] std::unique_lock<std::recursive_mutex>::unique_lock<std::recursive_mutex> (C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\mutex:134)
[3] MutexLock<MutexImpl<std::recursive_mutex> >::MutexLock<MutexImpl<std::recursive_mutex> > (C:\godot_source\core\os\mutex.h:122)
[4] ResourceImporterTexture::update_imports (C:\godot_source\editor\import\resource_importer_texture.cpp:93)
[5] EditorNode::_notification (C:\godot_source\editor\editor_node.cpp:584)
[6] EditorNode::_notificationv (C:\godot_source\editor\editor_node.h:118)
[7] Object::notification (C:\godot_source\core\object\object.cpp:800)
[8] SceneTree::_process_group (C:\godot_source\scene\main\scene_tree.cpp:951)
[9] SceneTree::_process (C:\godot_source\scene\main\scene_tree.cpp:1028)
[10] SceneTree::process (C:\godot_source\scene\main\scene_tree.cpp:510)
[11] Main::iteration (C:\godot_source\main\main.cpp:3434)
[12] OS_Windows::run (C:\godot_source\platform\windows\os_windows.cpp:1479)
[13] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:182)
[14] _main (C:\godot_source\platform\windows\godot_windows.cpp:204)
[15] main (C:\godot_source\platform\windows\godot_windows.cpp:218)
[16] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:232)
[17] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[18] <couldn't map PC to fn name>

It happens quite often actually, like once in 3 or 4 runs.
Steps to reproduce

Open a project

Minimal reproduction project
Doesn't seem project-specific.

Can confirm the crash on Linux. My workaround is to delete the .godot directory.
I seem to be able to cause the crash by

Accessing a project with a Godot-build-A
Accessing the same project with a different Godot-build-B

Step 2 seems to cause the following crash reliably.
Godot Engine v4.2.dev.custom_build.031aa99d3 - https://godotengine.org
Vulkan API 1.3.224 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2070
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.dev.custom_build (031aa99d313ceec7cdb8263957d22cae10de0b95)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x3bfd0) [0x7f27db35cfd0] (??:0)
[2] /lib/x86_64-linux-gnu/libc.so.6(pthread_mutex_lock+0) [0x7f27db3ad1c0] (??:0)
[3] ./bin/godot.linuxbsd.editor.dev.x86_64.llvm(+0x534ca43) [0x55571ae5ba43] (/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/gthr-default.h:749)
[4] ./bin/godot.linuxbsd.editor.dev.x86_64.llvm(+0x534ca15) [0x55571ae5ba15] (/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/gthr-default.h:811)
[5] std::recursive_mutex::lock() (/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/mutex:108)
[6] std::unique_lock<std::recursive_mutex>::lock() (/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_lock.h:139)
[7] std::unique_lock<std::recursive_mutex>::unique_lock(std::recursive_mutex&) (/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_lock.h:69)
[8] ResourceImporterTexture::update_imports() (/srv/docker/data/godot-compile/godot/./core/os/mutex.h:122)
[9] EditorNode::_notification(int) (/srv/docker/data/godot-compile/godot/editor/editor_node.cpp:582)
[10] EditorNode::_notificationv(int, bool) (/srv/docker/data/godot-compile/godot/editor/editor_node.h:118)
[11] Object::notification(int, bool) (/srv/docker/data/godot-compile/godot/core/object/object.cpp:798)
[12] SceneTree::_process_group(SceneTree::ProcessGroup*, bool) (/srv/docker/data/godot-compile/godot/scene/main/scene_tree.cpp:948)
[13] SceneTree::_process(bool) (/srv/docker/data/godot-compile/godot/scene/main/scene_tree.cpp:1027)
[14] SceneTree::process(double) (/srv/docker/data/godot-compile/godot/scene/main/scene_tree.cpp:508)
[15] Main::iteration() (/srv/docker/data/godot-compile/godot/main/main.cpp:3434)
[16] OS_LinuxBSD::run() (/srv/docker/data/godot-compile/godot/platform/linuxbsd/os_linuxbsd.cpp:912)
[17] ./bin/godot.linuxbsd.editor.dev.x86_64.llvm(main+0x1fe) [0x55571ae452ee] (/srv/docker/data/godot-compile/godot/platform/linuxbsd/godot_linuxbsd.cpp:74)
[18] /lib/x86_64-linux-gnu/libc.so.6(+0x271ca) [0x7f27db3481ca] (??:0)
[19] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85) [0x7f27db348285] (??:0)
[20] ./bin/godot.linuxbsd.editor.dev.x86_64.llvm(_start+0x21) [0x55571ae45021] (??:?)
-- END OF BACKTRACE --
================================================================

If deleting .godot would be sufficient then the issue is temporary. Unfortunately I suddenly can't reproduce it reliably enough to confirm it.

I had the same crash as kobewi on Windows everytime I build from master and start a project for the first time. PR https://github.com/godotengine/godot/pull/79981 fixed it.

If deleting .godot would be sufficient then the issue is temporary. Unfortunately I suddenly can't reproduce it reliably enough to confirm it.

i crash everyday ……


Fixup condor submit dag

The condor_submit_dag wrapper never really worked; it now actually adds
all the jobsub variables to the dagman submission, etc; for what that's worth.
Now works generally, and also on AL9.
Refactored "render_files" out of submit_support to prevent cyclic dependency.
A whole bunch of files added for testing, mainly files from a --dataset submission
with a few tweaks (to pass a fresh $SAM_PROJECT...)

Would you be able to fix some of the pre-commit checks?  Especially the mypy errors?

Ack!  Sorry, I need to get pre-commit setup on my AL9 node...


Convolution should never break the browser

When I enter,
normal(5,2) * normal(5,2)
And have "Downsample To" as blank, it crashes. This shouldn't happen.

Leaving that field blank currently sets the sampleCount to 10000 (see this line in DistBuilder.re):
~recommendedLength=options.downsampleTo |> E.O.default(10000),

This seems to be the downfall of convolution, and ultimately also sampling. I think we really have to come up with a reasonable strategy for how many sample points to use depending on the situation.
One thing I think would be REALLY impressive, some day in the future, would be a sample count that increases progressively (both for rendering and sampling) until some sort of equilibrium is reached. Ideally offloaded to webworkers. Sort of like what the Cycles engine does in Blender (video). (That would probably also require switching to non-SVG rendering, but apparently d3+canvas is an option nowadays, and https://d3fc.io even supports WebGL.)


Fix issue that OpenAPI specification had errors when validating it against Swagger/OpenAPI schema and Swagger/OpenAPI spec

HAPI Fhir OpenAPI specification has errors when validating it against Swagger/OpenAPI schema and Swagger/OpenAPI spec (https://apitools.dev/swagger-parser/online/).
With this commit, validation is passing.

I've marked for approval, but I do note that several OpenAPI unit tests are failing so this probably needs a bit of cleanup before it can be merged. Thanks!

I see. The problem was that there was already a different swagger version in the root pom.
I have consolidated them. At least locally the ServerDstu3Test that was failing before is now passing.

It seems like the tests are passing now.


[MERGE PENDING] Port periodogram, welch and csd from CuSignal to cupyx.signal

See https://github.com/cupy/cupy/issues/7403
Depends on https://github.com/cupy/cupy/pull/7563 to ensure that the files do not get merge conflicts
Depends on https://github.com/cupy/cupy/pull/7536 to implement csd
Depends on https://github.com/cupy/cupy/pull/7568 to implement spectral_analysis, it depends on get_window
This port implies Python-only functions and therefore can be copied 1:1 from the original CuSignal implementation.

/test mini

/test mini

/test full

/test full

/test full

Thanks, @andfoy!


[EXCLUSIVE~NEW] Lily Phillips 101 Challenge Video on Social Media X Lily Phillips 101 Guy Challenge Video Trending Now

49 seconds ago
L𝚎aked Video Lily Phillips 101 Challenge Guy Video Original Video Viral Video L𝚎aked on X Twitter Telegram
[-wATCH-]— Lily Phillips 101 Challenge Guy Video Video Original Video Link Lily Phillips 101 Challenge Guy Video Video Viral On Social Media X Trending Now
[-wATCH-]— Lily Phillips 101 Challenge Guy Video ʟᴇᴀᴋᴇᴅ Video ᴠɪʀᴀʟ On Social Media ˣ ᵀʷⁱᵗᵗᵉʳ
[-wATCH-]— Lily Phillips 101 Challenge Guy Video ʟᴇᴀᴋᴇᴅ Video ᴠɪʀᴀʟ On Social Media ˣ ᵀʷⁱᵗᵗᵉʳ
[-wATCH-]— Lily Phillips 101 Challenge Guy Video Video Original Video Link Lily Phillips 101 Challenge Guy Video Video Viral On Social Media X Trending Now
Lily Phillips 101 Challenge Guy Video Original Video video took the internet by storm and amazed viewers on various social media platforms. Lily Phillips 101 Challenge Guy Video, a young and talented digital creator, recently became famous thanks to this interesting video.

BOL Entertainmen Muskan Viral Video Tutorial Original Video video took the internet by storm and amazed viewers on various social media platforms. Tutorial, a young and talented digital creator, recently became famous thanks to this interesting video.

BOL Entertainmen Muskan Viral Video Tutorial Original Video video took the internet by storm and amazed viewers on various social media platforms. Tutorial, a young and talented digital creator, recently became famous thanks to this interesting video.


Can't edit or make my own complex modifiers, and i need to replace ctrl+left click to just left click

Does anybody have a file for this action or can anyone make one? Karabiner has no options to create your own complex modifiers.

complex modifications have to be coded in a JSON file - I suggest you add one from an internet source (via "add rule" on complex modifications there is an option to 'import more rules from the internet') and see if there's one already there, and then check the docs as to how to code it.

@DarkArachnid I've opened a pull request to the complex modifications website that disables Ctrl + Left Click, it's here.

Same problem here. I think this complex modification I want to import https://superuser.com/questions/703162/shift-insert-to-paste-in-mac-os-x now the question is - where do I paste that JSON?

@llamerr Save the JSON under any file name to ~/.config/karabiner/assets/complex_modifications/, when you go to add a complex modification it should show up.


docs: Add new content-formats to readme

As mentioned in #261 this PR adds the remaining supported content-formats from #248 to the readme. I am not entirely sure about the format. Maybe the list could also be replaced by a table?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 90.016%

Files with Coverage Reduction
New Missed Lines
%

lib/cache.js
2
95.45%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1166

Relevant Lines:
1259

💛  - Coveralls


Unexpected behaviour for test generation

I tried to generate test via this plugin for the next class:
@Service
@Observed
class CustomerServiceImpl(
    private val smthGraphQLClient: SmthGraphQLClient,
) : CustomerService {

    @Throws(ExternalServiceException::class)
    override fun getCustomerData(
        customerGuid: UUID,
        dataFieldNameList: List<String>,
        delimiterForJsonField: String
    ): Map<String, Any> =
        dataFieldNameList.asIterable()
            .map { convertToGraphQlFriendlyField(it, delimiterForJsonField) }
            .toList()
            .runCatching { smthGraphQLClient.getCustomerDataByGuid(customerGuid, this) }
            .onFailure { ex -> throw ExternalServiceException(ex.message) }
            .getOrThrow()

    /**
     * Modifying field name with smth delimiter to graphQL friendly syntax
     *
     * @sample [fieldNameWithDelimiter]="customer.flag.reason" and [delimiter]=".".
     * In this case result will be "{customer{flag{reason}}}"
     */
    private fun convertToGraphQlFriendlyField(fieldNameWithDelimiter: String, delimiter: String): String {
        val parts = fieldNameWithDelimiter.split(delimiter)
        val output = StringBuilder()

        for ((index, part) in parts.withIndex()) {
            output.append(part)
            if (index < parts.size - 1) {
                output.append("{")
            } else {
                repeat(parts.size - 1) {
                    output.append("}")
                }
            }
        }
        return output.toString()
    }
}

and got the generated test:
internal class CustomerServiceImplTest {
    @Test
    fun getCustomerDataTest() {
        val obj = CustomerServiceImpl()

        val expected = Map<String, Any>()
        val actual = obj.getCustomerData()

        Assertions.assertEquals(expected, actual)
    }
}

May be it is not supported yet, but I am just leaving the trace about this problem

@FrozenMorozen, could you tell me what you expected in this case?
I see one problem with an unhandled throw-catch case. Is that what you meant?

yeah, I just thought that generated tests prepare test-mthods for few cases and yes catch is one of them

I read README again and realised that "catch" cases don't support. Close current issue, please, if you don't have any plans about "catch" cases


fix: add lock to registering instrumented drivers

Fixes
panic: sql: Register called twice for driver instrumented-sql-driver-sqlite3 [recovered]
        panic: sql: Register called twice for driver instrumented-sql-driver-sqlite3

goroutine 15 [running]:
testing.tRunner.func1.2({0x1837d40, 0xc000473b70})
        /usr/lib/go/src/testing/testing.go:1389 +0x366
testing.tRunner.func1()
        /usr/lib/go/src/testing/testing.go:1392 +0x5d2
panic({0x1837d40, 0xc000473b70})
        /usr/lib/go/src/runtime/panic.go:844 +0x258
database/sql.Register({0x1a43574, 0x1f}, {0x1de6f60?, 0xc00046fb00})
        /usr/lib/go/src/database/sql/sql.go:51 +0x1d4
github.com/gobuffalo/pop/v6.instrumentDriver(0xc0002e63c0, {0x1a1f3bd, 0x7})
        /home/patrik/git/go/pkg/mod/github.com/gobuffalo/pop/v6@v6.0.1/connection_instrumented.go:68 +0x3e5
github.com/gobuffalo/pop/v6.openPotentiallyInstrumentedConnection({0x1df80b0, 0xc00000f7b8}, {0xc000182780, 0x5b})
        /home/patrik/git/go/pkg/mod/github.com/gobuffalo/pop/v6@v6.0.1/connection_instrumented.go:81 +0x9a
github.com/gobuffalo/pop/v6.(*Connection).Open(0xc000455500)
        /home/patrik/git/go/pkg/mod/github.com/gobuffalo/pop/v6@v6.0.1/connection.go:112 +0x11a

This problem occurred during parallel tests.
The race condition happened because the reading of the drivers and the registration of the not-found driver can have some delay, during which another go routine could already have registered the driver. Because the registration is happening as a side-effect, this cannot be fixed by the client.

How could we test for such a race condition? :thinking:

Good question. Not sure, maybe -race helps? Maybe running parallel tests?

Hm but I also did not get the panic all the time before the fix, only on some occasions. I guess the only way is to inject some waiting behavior that we could then control in the test. I will try to come up with something in the next days.

Got it. Lets give it a shot, I don't think that's a huge blocker for merging this change but want to at least try this so we leave this covered for any future change.

I tried for a bit yesterday and could not come up with any useful test, if you maybe have a proposal? My approach involved channels and stopping execution at the critical point in two go-routines, but as the lock prevented me from getting to that point I could only make it flaky without the lock, or a dead-lock with the lock.

By the way, pop's test workflow already has -race option so the issue could be one that cannot be detected within pop. Plus, the error message sql: Register called twice for driver instrumented-sql-driver-sqlite3 tell us the function should be called just once (maybe per driver?), so I guess locking the function call could be helpful if we have some code to prevent the second call but in my rough looking at the patch, I am not sure this locking could help the situation.
If the issue itself is not clear, the approach for fixing the issue also will not be clear. So I hope we can clarify the issue first before patching it. Actually, I am not familiar enough with pop nowadays but please let me take a look at the situation before moving forward. (Also, it could be fine if you give some more idea on the issue and solution)

I think the new test failure is because we cannot re-register the instrumented driver with different options... Would you like to have that test or not? I think I will have to make it part of the already existing test to work.

I don't think adding a channel to the function just for testing is a good thing. If the logic is good enough but is hard to test, it could be fine without a test.
I just wonder, in the first place, if we can avoid this situation (calling this call twice from goroutines even though it looks like a kind of initialization).
By the way, I think your previous version (w/o a test) could be acceptable. (I think logically fine)

I just wonder, in the first place, if we can avoid this situation (calling this call twice from goroutines even though it looks like a kind of initialization).

Unfortunately not. The sql.RegisterDriver is meant to be called in an init func, so it is a side-effect of importing a driver. There is no atomic way to check whether a driver was already registered.

So @paganotoni, do you want to keep the test or not? I would just remove the commit again and we can merge once that is decided.

First, the test with an additional channel argument (just for testing) should not be added.
By the way, the only meaningful place that calls the function openPotentiallyInstrumentedConnection() is the following code (the rest of the calls are from utility functions like CreateDB()):
https://github.com/gobuffalo/pop/blob/d146f1bbdc191ecc0a3862400e07712244aa0563/connection.go#L103-L113
So it means the Connection.Open() was called twice which is somewhat odd to me. Connection.Open() is only called from pop.Connect(env) at least within the pop library and that is the preferred usage. I wonder if the issue was basically caused by the usage of pop which is not the same as its original design. However, once the Connection.Open() is exposed as a public function, we cannot force users not to use them so I agree we need to fix this.
However, even though we prevented the second call of sql.Register() with the lock, still the code flows to the following lines,
https://github.com/gobuffalo/pop/blob/d146f1bbdc191ecc0a3862400e07712244aa0563/connection_instrumented.go#L86-L91
and the function openPotentiallyInstrumentedConnection() will call sql.Open() and the rest of code once again for the same connection. So IMO, the situation we need to prevent is calling Connection.Open() twice. Maybe, we need to investigate some more about the situation to make the code solid.
(What I wondered from my previous comment is not about Register but why the function Connection.Open() is called twice. I don't think this issue is related to the init since the code register the driver with a custom name and it could not conflict with the original driver name.)

The point is, we test our persister against all supported databases (postgres, cockroach, mysql, sqlite-in-memory, sqlite-file):
https://github.com/ory/keto/blob/6b409141ec00f20ab3d5c5cdd2dd03f696751d1b/internal/persistence/sql/relationtuples_test.go#L41-L51
This of course means that we create a new connection per database. As the tests run parallel, it can happen that two Connection.Open calls happen at the same time. However, the underlying connection is not the same, but instead we open four connections to different databases at the same time.

First, the test with an additional channel argument (just for testing) should not be added.

Ok sure, I'll remove it.

For documentation purposes, I will keep the test on this branch: https://github.com/zepatrik/pop/commits/fix/registering-driver-2

We don't lock per driver or connection here, but the lock is a global variable. Therefore it will ensure no goroutine reads the list of drivers while another adds to the list of drivers. I searched the whole codebase and this is the only usage of sql.Register and sql.Drivers.
Changing the driver name would also fix it, as that would mean we don't create a conflict anymore.

the options of the connection that successfully registered its driver will be used for the other connection which calls the instrumentDriver() later even though they could have different instrumented driver options

Correct, I did not bother about that yet. But definitely a valid point.


chore(build): notify about version differences for eslint-plugin-esl

Closes: #2361

Maintainers note: change should be visible in release notes so consider fix or MINOR VERSION final commit message parts

:tada: This PR is included in version 4.17.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0-beta.20 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CloudFormation delete fails because of the VPC cannot be removed

I tried to deploy it on us-west-2 and it failed because of the Quota for the ml.g5.12xlarge.
After I increased the quota, I tried to deploy it again but apparently the CloudFormation fails because LogicalID "SharedVPCprivateSubnet1Subnet5A4C2616"
"The subnet 'subnet-***' has dependencies and cannot be deleted. (Service: Ec2, Status Code: 400, Request ID: ***)"
The deploy config has the FalconLite, Bedrock endpoint and the all three RAG options. As embeddings model: "intfloat/multilingual-e5-large"

The solution was to delete the subnet manually, then the CloudFormation could be deleted. g
The cdk deploy hence worked


Both vault reports as leader

Describe the bug
After upgrading both the operator and my cluster to 0.3.15, I noticed that both Vault started to report to be the leader, although as I confirmed on CLI only one of them is the leader. This was working correctly in the previous version I used (banzaicloud/vault-operator:0.3.6 and banzaicloud/bank-vaults:0.3.4)
To Reproduce
Steps to reproduce the behavior:

Create an HA Vault with multiple members
Check Prometheus metrics

Expected behavior
Only the actual leader reports as the leader.
Screenshots

What you see there is the by-design result of the Prometheus time series database. The exporter reports vault_sys_leader with value 1 if the member is a leader, otherwise it don't report anything. It means that choosing proper time range is essential (or for example Grafana single stat / current value) because prometheus will show the last valid scrape data. That means you get different results for a 1 hour span and for the latest values (about scrape time range). You can change time range at the Graph tab on prometheus. If you want to get your hands dirty with prometheus and Grafana may I suggest you to read our blogs regarding these topics https://banzaicloud.github.io/tags/monitoring/
P.S: We will update the metrics exporter to report 0 for non-leader members as well so this won't be an issue with late release

Hi @tarokkk
Thanks for taking a look at this, although I don't think this is a Prometheus issue as both scraping targets are reporting vault_sys_leader 1
/ # curl -s http://<IP_ADDRESS>:9091/metrics | grep vault_sys_leader
# HELP vault_sys_leader Is the Vault node the leader.
# TYPE vault_sys_leader gauge
vault_sys_leader 1

/ # curl -s http://<IP_ADDRESS>:9091/metrics | grep vault_sys_leader
# HELP vault_sys_leader Is the Vault node the leader.
# TYPE vault_sys_leader gauge
vault_sys_leader 1

Actually as I see you have the conversion of boolean to float here https://github.com/banzaicloud/bank-vaults/blob/743cb0b63278a76207745a9f72f221f21e7fbf47/cmd/bank-vaults/metrics.go#L83 and it's being used, so I don't really get why it's not zero as should be.

I have reported the issue, https://github.com/hashicorp/vault/issues/5863
The workaround fix for this is incoming soon.

Not a bug on the Vault side, sorry.

The fix is final now, I found that another operation was changing the address of Vault inside the client which reports the metrics, that caused the confusion, sorry for that @jefferai @cu12 !

@cu12 the fix has been released in https://github.com/banzaicloud/bank-vaults/releases/tag/0.3.17

Yay! Thanks, testing it already :) Will come back with the results.


MODE-1398 Added new connector for Infinispan 5.x

Added a new connector that uses Infinispan 5.x caches for storage. The existing Infinispan 4.x connector is still usable and unchanged. Basically users would choose between the two. Note that Infinispan 5.1.1.Final is likely to be used by JBoss AS 7.1.0.Final.
All unit and integration tests pass.

Awaiting review before merging into the 'master' (2.x) branch.

Apart from the minor things mentioned above, the code seems fine (the only real change in the ISPN 5.1.1 API which affects ModeShape, is the introduction of the BasicCache and BasicCacheManager interfaces, which is reflected in the change)

I'll make the suggested changes and give it another run. Thanks, Horia.

Merged into the 'master' branch only. (Connectors are not be used in the '3.x' branch, so merging there is not appropriate.)


fix(test/drivers): fixed s390x Werror related failures for drivers tests

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Extracted from #2064 .
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/milestone 0.18.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


StaticStrings.jl

I originally started a package called NStrings.jl, but then this became StaticStrings.jl:
https://github.com/mkitti/StaticStrings.jl
Now it occurred to me that we may have a name collision.
Could we check if our goals are compatible here?

To be clear, we should be able to make your "StackString" compatible with StaticStrings.jl. They are both NTuple based.
In particular, it maps to the CStaticString type in StaticStrings.jl.


QUESTION: How do I use this thing, in simplest terms for a total noob?

Prerequisites

[ ] Did you read FAQ section?
[ ] Did you test with the latest releases or commit ?

Description
I don't know anything about coding but when I run windows command inside the folder, and try to use the commands like "-s b" for batch download or even "-h" for help I get errors. Can someone explain to a simpleton how to run this program? Thank you so much in advance
P.S. trying to batch download from my bookmarks page!

This tutorial assumes that you have done the following:

You have the latest version of Python installed. (3.8.3 as of this post)
You cloned the repository instead of downloading a release.
You use Google Chrome as your browser of choice.
You are also logged into pixiv.net on said browser.

What you want to do is open up a command prompt in the PixivUtil2-master folder, and then run pip install -r requirements.txt. This will install all of the prerequisites for PixivUtil2 to run. Once that finishes, you can now run python PixivUtil2.py to start the program. It will ask for your Pixiv username+password, and then it will fail on a reCAPTCHA error.
Now, open up config.ini in your text editor (please, no word processors.) and navigate to Line 60. Now go to pixiv.net on your browser, then click on the lock icon to the left of the browser. Now click on the Cookies menu, shown here:

Now open up pixiv.net, Cookies, then click on PHPSESSID. Double click on the "Content" value, and press CTRL+C on your keyboard to copy that value.

Now paste that value into Line 60 of config.ini, where it asks for a cookie. You can also configure various parts of the program, like where it should download the images, or if it should save metadata in JSON format, etc. Once you are finished, save the file and re-run python PixivUtil2.py in your command prompt. When it asks for a username and password, just press Enter twice. It will then try to login using the saved cookie you gave it earlier.
If all went well, you should now be able to use PixivUtil2! You can now use it however you need it do, be it downloading all of the artists that you follow, or downloading specific images or artists.


Gordon Bell citation

We should cite in a prominent place on the README and readthedocs that Xiao's paper for the engine was a Gordon Bell finalist.  @XiaoWang-Github is there a preferred way to reference that?

How about
Xiao Wang, Amit Sabne, Putt Sakdhnagool, Sherman J Kisner, Charles A Bouman, and Samuel P Midkiff. Massively parallel 3d image reconstruction. In Proceedings of the International Conference for High Performance Computing, Networking, Storage and Analysis, SC ‘17. 2017. doi:10.1145/3126908.3126911. (Selected as a finalist for 2017 ACM Gordon Bell Prize)
I am open to suggestions. What do you think?


[Bug]: Checkbox can't work with array v-model

Reproduction
I don't think it's required.
Describe the bug
This works because form.remember is boolean:
<Checkbox id="remember" v-model:checked="form.remember" />
This is not working and I tried 10 different combinations (form.tags is an empty array),
and tags is simple key:value object:
<template v-for="(value, key) in tags">

        <Checkbox :id="`tag-${key}`" v-model:checked="form.tags" :value="key" />
        <Label :for="`tag-${key}`" class="cursor-pointer select-none">{{ value }}

</template>

I tried v-model="form.tags" and some other (desperate) solutions, none worked.
I see there is an example using Form (vee-validate); I don't want to use this if I don't have too.
I am using Inertia.js useForm.
So I ended up creating my own checkbox component, just to see if it works, and it does (with the same code above), which works with booleans and arrays:

<template>
  <input
    type="checkbox"
    v-model="proxyChecked"
    :class="
      cn(
        'peer h-4 w-4 shrink-0 rounded-sm border border-primary shadow focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50 data-[state=checked]:bg-primary data-[state=checked]:text-primary-foreground',
        props.class
      )
    "
  />
</template>

So it's bug somewhere with radix-vue probably, or if it's not, how to achieve this?
System Info
System:
    OS: macOS 14.5
    CPU: (12) arm64 Apple M2 Max
    Memory: 1.61 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.3 - ~/.nvm/versions/node/v21.7.3/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v21.7.3/bin/npm
    pnpm: 8.9.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 126.0.6478.183
    Safari: 17.5
  npmPackages:
    @vueuse/core: ^10.11.0 => 10.11.0
    radix-vue: ^1.9.1 => 1.9.1
    vue: ^3.4.0 => 3.4.31

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

I used this with the checkbox component, but I find it ugly solution, and would be great to support multicheck via v-model directly:
<Checkbox
    :id="`tag-${key}`"
    :value="key"
    @update:checked="(isChecked) => isChecked ? form.tags.push(key) : form.tags.splice(form.tags.indexOf(key), 1)" />

The radix-vue checkbox already has the same props and emits, whether you want to use vee-validate or inertiajs useForm it should work with booleans and arrays
It may be better to create a minimal reproduction

I see there is an example using Form (vee-validate)

This example in shadcn-vue might help you, Checkbox with array, even if you don't want to use vee-validate
https://github.com/radix-vue/shadcn-vue/blob/dev/apps/www/src/examples/forms/components/DisplayForm.vue#L90C15-L97C17
https://www.shadcn-vue.com/examples/forms/display.html

Closing for now will reopen after reproduction

There is no need for reproduction, this <Checkbox id="tags" v-model:checked="form.tags" /> should work with booleans and arrays, but it's not as I represented with my custom component, but it works only with boolean.
Only way to make it work with array is this code, which is just dirty looking:
<Checkbox
    :id="`tag-${key}`"
    :value="key"
    :checked="form.tags.includes(key)"
    @update:checked="(isChecked) => isChecked ? form.tags.push(key) : form.tags.splice(form.tags.indexOf(key), 1)" />

If you want I can create PR to implement such behaviour into your current component, using radix-vue

Make a Vue Playground with Stackblitz please, see if we could help
With reproduction, we can check it ourselves to see if it is really a bug or not
https://stackblitz.com/edit/inertia-sails-vue-nkt3qm?file=package.json
Just fork this link and delete additional files and make it minimal and send it here


feat: changes to support gcp-nuke variant

This implements a series of changes that allows for the gcp-nuke variant to be completed and follow the same patterns as aws-nuke and azure-nuke before it. Due to how the google golang sdk is written a few additional features needed to be added to allow for proper teardown of clients, renaming of tags to labels, and for filtering to be able to access settings.

:tada: This pull request is included in version 0.15.0 :tada:
The release is available on GitHub release :rocket:


3/n call stream callback only if it exists

3/n call stream callback only if it exists
Comprehensive Test plan:
stream false, true, unset, with streaming options
https://github.com/lastmile-ai/aiconfig/assets/141073967/15f0bf39-fa0e-4b60-b7f0-6c3d69167f2e

Stack created with Sapling. Best reviewed with ReviewStack.

-> #453
#452

What is this test plan supposed to be showing?


Support Svelte v4

Currently Svelte is listed as a peerDependency with version ^3.0.0. It would be nice to start testing with Svelte 4 (beta) to check if there's any breaking changes. If all works, maybe v4 can be added to the list of supported peerDependencies.

Hey @bartveneman that's a good idea. I'm a little short on the free time recently, you fancy to test it and create PR? :)

I'll give it a try 👍


Warning: .then() only accepts functions but was passed: [object Null], [object Null]

Hi
I use angular with bluebird for promises. Decorating default angular's $q: $provide.decorator("$q", function(){...});
When i call the service Upload.upload() then a warning is issued in the console:
Warning: .then() only accepts functions but was passed: [object Null], [object Null]
    at Promise.ngFileUpload.service.promise.progress (webpack:///./src/main/webapp/bower_components/ng-file-upload/ng-file-upload.js?:92:15)
    at uploadFile (webpack:///./src/main/webapp/app/scripts/orm/lib/ui/field/objects/objects.js?:277:12)
    at Scope.angular.module.controller.$scope.upload (webpack:///./src/main/webapp/app/scripts/orm/lib/ui/field/objects/objects.js?:258:13)
    at Object.eval [as fn] (webpack:///./src/main/webapp/app/scripts/orm/lib/ui/field/objects/objects.js?:324:16)
    at Scope.$get.Scope.$digest (webpack:///./src/main/webapp/bower_components/angular/dist/angular.js?./~/exports-loader?window.angular:14537:29)
    at Scope.$get.Scope.$apply (webpack:///./src/main/webapp/bower_components/angular/dist/angular.js?./~/exports-loader?window.angular:14800:24)
    at eval (webpack:///./src/main/webapp/bower_components/angular/dist/angular.js?./~/exports-loader?window.angular:16537:36)
    at completeOutstandingRequest (webpack:///./src/main/webapp/bower_components/angular/dist/angular.js?./~/exports-loader?window.angular:5153:10)
    at eval (webpack:///./src/main/webapp/bower_components/angular/dist/angular.js?./~/exports-loader?window.angular:5541:7)

Everything is normal or not?
ngFileUpload version 5.0.6

That line passes null to then function
promise.then(null, null, function (update) {
        fn(update);
      });

You could ask on the bluebird issues why it doesn't accept null.

Seems like a bug with bluebird. The angular official docs mentions passing null to the then() function so it should be fine to pass null to then() function.
catch(errorCallback) – shorthand for promise.then(null, errorCallback)

@danialfarid thanks for the reply
I found the answer from the developer bluebird:

The warning is ok and expected as it's the Promises/A+ test suite testing behavior when .then is incorrectly called with non function values. In practice this warning helps people new to promises quickly see where they made a mistake.

Sounds like there should be some way to disable this warning.

@Rush BLUEBIRD_WARNINGS = 0 https://github.com/petkaantonov/bluebird/blob/aefda6abbda2e7f146b51c18daaa45dc0f17d89b/src/debuggability.js#L21


Add default env for script run

What this PR does / why we need it:
Added default env value for the deployment information (such as deployment id, application id...)
Current values are below.

Name
Description
Example

SR_DEPLOYMENT_ID
The deployment id
877625fc-196a-40f9-b6a9-99decd5494a0

SR_APPLICATION_ID
The application id
8d7609e0-9ff6-4dc7-a5ac-39660768606a

SR_APPLICATION_NAME
The application name
example

SR_TRIGGERED_AT
The timestamp when the deployment is triggered
1719571113

SR_TRIGGERED_COMMIT_HASH
The commit hash that triggered the deployment
2bf969a3dad043aaf8ae6419943255e49377da0d

SR_REPOSITORY_URL
The repository url configured in the piped config
git@github.com:org/repo.git, https://github.com/org/repo

SR_CONTEXT_RAW
The json encoded string of above values
{"deploymentID":"877625fc-196a-40f9-b6a9-99decd5494a0","applicationID":"8d7609e0-9ff6-4dc7-a5ac-39660768606a","applicationName":"example","triggeredAt":1719571113,"triggeredCommitHash":"2bf969a3dad043aaf8ae6419943255e49377da0d","repositoryURL":"git@github.com:org/repo.git","labels":{"env":"example","team":"product"}}

SR_LABEL_XXX
The label attached to the deployment. The env name depends on the label name. For example, if a deployment has the labels env:prd and team:server, SR_LABEL_ENV and SR_LABEL_TEAM are registered.
prd, server

example of app.pipecd.yaml
apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
  name: script-run-like-jenkins
  labels:
    env: example
    team: product
  pipeline:
    stages:
      - name: K8S_CANARY_ROLLOUT
        with:
          replicas: 10%
      - name: SCRIPT_RUN
        with:
          run: |
            echo $SR_DEPLOYMENT_ID
            echo $SR_APPLICATION_ID
            echo $SR_APPLICATION_NAME
            echo $SR_TRIGGERED_AT
            echo $SR_TRIGGERED_COMMIT_HASH
            echo $SR_REPOSITORY_URL
            echo $SR_RAW
            echo $
          env:
            REPOSITORY_URL: "https://github.com/pipecd/pipecd"
          onRollback: |
            echo $SR_DEPLOYMENT_ID
            echo $SR_APPLICATION_ID
            echo $SR_APPLICATION_NAME
            echo $SR_TRIGGERED_AT
            echo $SR_TRIGGERED_COMMIT_HASH
            echo $SR_REPOSITORY_URL
            echo $SR_RAW
...

Which issue(s) this PR fixes:
Fixes #4814
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

oops, I forgot to add the Summary value. will try to add it 🙏
https://github.com/pipe-cd/pipecd/issues/4814#issuecomment-2060583328

Added Summary value on 701bffa


javascript promise second .then call not working

I'm using the native javascript promises for a small lightning app that I'm working on. My first .then() promise call works however my second never gets called. I haven't seen much talk or documentation concerning promises.
Are native promises ready for use in lightning components?
Other details:

app is running inside of a lightning app
Using Chrome 54

({
    doInit: function(component, event, helper){
       var action1 = component.get("c.getAllSprintWork");
       var action2 = component.get("c.getWorkItems");
        var appEvent = $A.get("e.c:workItemsLoaded")
        var serverSideAction = function(action, component){

            return new Promise(function(resolve, reject){
                action.setCallback(this, function(response) {
                    var state = response.getState();
                    if (component.isValid() && state === "SUCCESS") {
                        resolve({component: component, data: response.getReturnValue()})
                    } else if (component.isValid() && state === "ERROR"){
                        reject(new Error(response.getError()));
                    }
                })
                    $A.enqueueAction(action)
            })
        }
        serverSideAction(action1, component)
        .then(function(response){
            console.log("response from action1", response)
            response.component.set('v.workItems', response.data);
            return serverSideAction(action2, component)
        })
        .then(function(response){
            console.log("response from action2", response);
            response.component.set("v.loggedInUserInfo", response.data);
            return serverSideAction(action2, component);
        })
})

We just added doc for promises. Here's a link to the Lightning Components Developer Guide (Promises work similarly in open source and Lightning components). See https://developer.salesforce.com/docs/atlas.en-us.lightning.meta/lightning/js_promises.htm
Try wrapping your function(response) with $A.getCallback():
$A.getCallback(function(response) ... )
From the doc:
Promises execute their resolve and reject functions asynchronously so the code is outside the Lightning event loop and normal rendering lifecycle. If the resolve or reject code makes any calls to the Lightning Component framework, such as setting a component attribute, use $A.getCallback() to wrap the code.


the app one click minner is not minning properly

My hash rate is .240 doge per day and since yesterday I didn't get but .400000 dogie please assist

Can you elaborate?

I mine for the whole day and i only get 1/6 of the expected hash rate that was the issue , but for now i am supposed to mine the 1 doge in 4 days and 6 hours but it takes much time than that can you please advice

You may have too low of hash rate and having difficulty finding shares.  There isn't anything I can do.

then the expected earning per day is not accurate means that I can't depend on it

That would be on the pool for giving you too high difficulty of shares.  Sorry, this is not a problem with the OCM.


Assign Multiple variables the same value

Hi, In some of the js source file I felt it was better to group assign the same value in a much cleaner way. In this way the variables that are assigned the same values are grouped together, And it is easier to find out which variables are assigned the same value.

Please don't open this kind of PRs.

This kind of changes is not something we are interested in, sorry. You can test it locally before opening any PR with npm t.

Can you give me suggestions in order to contribute to open source project like bootstrap. Which also interests you to the changes I make to the source code?

Hi @aditya1906,
We have a lot of issues marked as js so feel free to tackle some of them: https://github.com/twbs/bootstrap/labels/js


feat(proxy): initial support

Provide an a index based access to running query/mutate/subscribe with support for nested keys and keys with different operations e.g.

client.version.query();
client.sendMsg.mutate("Hello using proxy");
client.pings.subscribe([], {
    onData(msg) { console.log(msg) }
})

[x] client: don't break current api
[ ] hooks: don't break current api
[ ] types: Always pass an array of arguments? even when it's empty??

Does it make sense to turn snake_case keys into camelCase? It feels weird to me to introduce a different notation in the Rust project so I created my own proxy (POC) that also converts those. E.g. 'controller.sign_in' -> 'controller.signIn'. It's a bit tricky to not convert the final method calls so requires a few more checks.


Fight scene messages

Attack messages and win/loss messages pop on screen. So when the user doesn't have the debug window they can see what is happening.
Examples:
"[Opponent] used [move name]"
"[Player] used "[move name]"
"[Opponent] is knocked out, [Player] wins"
"[Player] is knocked out, game over"

The text box displays information about each attack performed. Upon victory/loss the appropriate text should appear in the middle of the screen. The player should be able to click a button to advance to the bracket/main menu. We could also have the game automatically advance after a few seconds.


Move test_with_libdparse.d into separate submodule

This allows other projects using the same dependency testing logic.
The new test_with_package.d file was first copied over as-is and then extended to support running both min & max in one step (for simpler development purposes) and to provide arguments as non-environment variables too. So the CI should run on this first to test if everything still works too.

this being a submodule is not a problem for dub as this is solely for development and testing purposes, not for the library users.


About THUMOS14 in this repo

I have seen many different types of THUMOS14 in temporal action localization such as .json and .csv. Now I am making a new data set for temporal action localization, could you tell me if there any other method using the same type of data as yours? Thinks!

To build on Chenlin's answer, we store video features in npz (numpy arrays) and video annotations in json format. Our json file follows the annotation format of ActivityNet-1.3. To adapt our features, you can write a dataloader to parse the json file and load the features, similar to our dataloader in this repo.

Let me know if this issue is still open. Otherwise, I will mark it as resolved.

Not yet. Think you for reply!

Can you illustrate more about your questions?

Can you illustrate more about your questions?

I am trying to test many TAL models with my own data set. I have made my data set's label as your THUMOS14 label format and run your model successfully. However, other TAL models(such as CMCS) have other input format and label format(such as this). I don't know how to generate these files of my data set, so I tried to find some methods which can run with your THUMOS14 labels directly. Now I now that you use ActivityNet format, so I am trying to find some methods which can used on ActivityNet.

The json file following ActivityNet format simply records the action annotations in the videos. You can write some Python code to convert another format into the json format and vice versa. Or you can re-write the dataloader to allow our code to interface with another format.

I am closing this issue as the discussion seems irrelevant to the current repo. Send us an email if an offline discussion is needed.


Add all skills to the character sheet

The spreadsheet should also calculate the number of dice to roll for each skill.

Resolved via: ee64b9eb822868f6a8976b0018d7072680d64a57


JSON snippet not listed until new line added

VSCode Version: 1.29.1
OS Version: Windows 10

Steps to Reproduce:

Preferences: Configure User Snippets
Select json
Make a JSON snippet whose prefix is "log".
Save the snippet.
Open a JSON file (any filename).
Type {}
Move the cursor between the braces.
Press Ctrl-Space:  only "$schema" is listed as a suggestion.
Press Enter.
Press Ctrl-Space:  "$schema" and the "log" snippet are listed as suggestions.

{
	"Log": {
		"prefix": "log",
		"body": [
			"\"log\": \"$1\""
		],
		"description": "Add a \"log\" property."
	}
}

Expected
The "log" snippet should have been listed in step 8.

Does this issue occur when all extensions are disabled?: Yes/No Yes

/duplicate of #60704


Update project structure

This PR updates the project structure to use the latest typings generator.
The definitions describe the version 1.2.0 of vinyl (last version of the 1.x major version), the documentation was updated.
Note: this PR removes the unit tests since they are no longer compatible with vinyl. file.stat is no longer declared.
Reference: https://github.com/types/npm-vinyl/pull/2#issuecomment-254422414

Why are you removing all tests?
Does this PR remove stat? Because I would like to keep this PR to only contain style changes. The diff is already large enough.

The tests were removed because the typings-generator uses blue-tape while vinyl (and the previous version) used mocha.
I'll submit an other PR with just the directory structure update.


Ugly hack to get ActiveAdmin to play nicely with CanCan

After some heartburn trying to find a more correct solution, I went ahead and disabled CanCan authorization altogether for admin within routes.rb
RightBonus::Application.routes.draw do
  ActiveAdmin.routes(self)
  devise_for :superadmin, ActiveAdmin::Devise.config

  ActiveAdmin::ResourceController.class_eval do
    skip_authorization_check
  end

  #...

CanCan is common enough that there should be a better way to get it to play nicely. Without this hack, you get a lot of
CanCan::AuthorizationNotPerformed (This action failed the check_authorization because it does not authorize_resource. Add skip_authorization_check to bypass this check.):

Ideas?

Your above code still produces the same error for me.
I have a hunch that maybe this is related to the order in which the gems are being loaded, as no matter what I try or where I try it (hacked together some code in active_admin itself for the action_items.rb file), I get controller.can? is not defined.
Can you post what order you have your gems loaded? New to Rails, but just a thought that I'm going to look more into.

gem 'rails', '3.1.0'
gem 'activeadmin'
...
gem "cancan"

Remember to reload the server after making any changes to the initializers:
In config/initializers/active_admin.rb I have:
config.before_filter :current_ability
config.authentication_method = :authenticate_admin_user!
config.current_user_method = :current_admin_user

gem 'rails', '3.0.9'
gem 'rake', "0.9.2"
gem 'activeadmin', :git => 'git://github.com/gregbell/active_admin.git'
gem 'cancan', :git => 'git://github.com/ryanb/cancan.git'

In config/initalizers/active_admin.rb
  config.before_filter :current_ability
  config.authentication_method = :authenticate_admin_user!
  config.current_user_method = :current_admin_user

I tried moving the CanCan gem higher up in the Gemfile & re-running Bunlder, restarting the server, etc - all still with the undefined can? method error.
I'm not sure what else to try, other than upgrading to Rails 3.1 (don't want to fiddle with right now) or creating a new project from scratch and trying to get this all in place, but that's still a good investment of time.  Appreciate all your help, any other thoughts?
Using the code you posted a few lines above, I get an error that can? isn't defined for ActiveAdmin::DSL, but every other way I've tried just executing the method on the controller context itself, and I get Admin::UsersController:Class doesn't define can?.

Does this work for you?
ActiveAdmin.register ActiveAdmin do

  controller.authorize_resource

  if controller.current_ability.can?( :change_password, resource )
    action_item :only => [:show, :edit] do
      link_to "Change Password", change_password_app_admin_user_path( resource )
    end
  end
end

Nope, get undefined method 'current_ability' for App::AdminUsersController:Class error.
app/controllers/application_controller.rb
class ApplicationController < ActionController::Base

  protect_from_forgery

  def current_user
    current_admin_user
  end

  def current_ability
    @current_ability ||= Ability.new(current_user)
  end

  before_filter :set_timezone
  def set_timezone
    Time.zone = current_admin_user.time_zone if current_admin_user and !current_admin_user.time_zone.blank?
  end

  rescue_from CanCan::AccessDenied do |exception|
    redirect_to root_url, :alert => exception.message
  end

end

You've seen config/initializers/active_admin.rb & my Gemfile
Trying the exact code you have above, with the exception of changing the first line to:
ActiveAdmin.register AdminUser do

@doabit, I added some updates and added the link to the wiki home. Others can contribute and maybe load some stuff that worked for them (with some explanations): https://github.com/gregbell/active_admin/wiki

Thanks for posting the wiki, but that doesn't cover the issue that I was discussing with CanCan here.
I want to conditionally show a action_item and, as such, need access to the current_ability or can? instance methods defined on the ApplicationController class.
The problem is that ActiveAdmin::DSL.controller returns a Class object, not the instance of the controller itself.  If I define current_ability on ApplicationController as a class method, it does in fact get found, but I still can't use CanCan b/c that's all defined as instance methods.
class ApplicationController < ActionController::Base
  def self.current_ability
    @ability ||= Ability.new(nil) #can't use current_admin_user(), as that is an instance method
  end
end

This will in fact work without binding errors, but is logically broken (as it doesn't use the current user session at all)
ActiveAdmin.register Post do
  if controller.current_ability.can?( :index, Post)
    action_item :testing, :only => :index do
      Rails.logger.info ":testing"
    end
  end
end

Is there a way to get the actual controller instance being used from the DSL, instead of an instance of a Class object, describing the class of the controller?

Ok - I looked through someone else's posting of a quick hack to wrap the ActiveAdmin::Resource::ActionItems module code in conditionals, and hit me that I could re-use this for my purposes inside the ActiveAdmin.register block, I just needed to move the conditional statement inside the function call from outside, as the reference to controller is different per that context.
Example:
ActiveAdmin.register Post do
  action_item :only => [:edit, :show] do
    if controller.current_ability.can?( :change_password, resource )
      link_to "Change Password", change_password_app_admin_user_path( resource )
    end
  end
end

Yes,that can work well. I use
  action_item :only => [:show] do
    if can?(:top,resource)
      link_to "Change Password", top_admin_post_path(resource)
    end
  end

What about the scope_to method?  Cancan seems to work fine with the menu and action_items but I can't similarly tame the scope_to method.
scope_to :current_user, :association_method => :space_bookings unless proc{ can?(:manage, :all) }
I'd like to use the scope_to on everyone except admins... and have tried every variation I can think of.
scope_to :current_user, :association_method => :space_bookings unless proc{ current_user.admin? }
etc.
Any ideas?

I've noticed an issue with my Initializer when the resource's name has been changed using the :as option to ActiveAdmin.register. This can be fixed by changing the line:
load_and_authorize_resource

to:
load_and_authorize_resource :class => #{config.resource_class}

in the initlaizer

@GutenYe I can't get this to work -- the load_resource portion causes this error:
undefined method `num_pages' for #ActiveRecord::Relation:0x007fbb6896f908
@DMajrekar where is this supposed to go? I'm getting the following erorr when I tried placing it in a few places (/lib, initializers)
/Users/jd/.rvm/gems/ruby-1.9.3-p0/gems/activeadmin-0.3.4/lib/active_admin/namespace.rb:176:in `eval': uninitialized constant ActiveAdmin::BaseController (NameError)

@DMajrekar but apparently just dropping it in an initializer works fine /if/ I reference your fork! good enough for now, I suppose :)

@jmonster The correct place for the file in in config/initializers.  You'll need to use the HEAD of active_admin rather than the gem as there has been a change to the ResourceController inheritance chain. FYI, my Gemfile has the following
gem 'activeadmin',                  '~> 0.3.2', :git => 'git://github.com/gregbell/active_admin.git', :ref => 'HEAD'

@ches What use case are you thinking of when skipping authorisation? If you're using my patch above, authorisation is only be included inside ActiveAdmin controllers so I'm unsure of why you'd need to place anything like this at the ApplicationController level.

@ches I can see what you mean. So far, I've only needed an all or nothing approach so the initialiser works well as a fire and forget type thing.
Seeing as all of the ActiveAdmin controllers inherit from ActiveAdmin::BaseController, would a proc checking the inheritance process work:
check_authorization :unless => proc { |controller| controller.kind_of?(ActiveAdmin::BaseController) }

I guess you should be able to place this in a method as well, and then use the method name as a symbol in place of the proc.
I've not tested it, but it might do what you need.
NB: This would apply to the current master of ActiveAdmin as the BaseController is still un-released functionality

@DMajrekar I don't believe that your approach works because the :unless and :if options for check_authorization only support a method name as a symbol.
The following does work however:
check_authorization :unless => admin_controller?

def admin_controller?
   self.kind_of?(ActiveAdmin::BaseController)
end

@travisp That makes sense

I'm closing this issue for now. It appears that there is plenty of documentation in the wiki for using CanCan with Active Admin. I've also added a new feature (unscheduled) for an authorization layer abstraction with a CanCan adapter.


CASA: Fix import

Apparently CASA's namespace has changed since we wrote their IO tools.

Coverage decreased (-0.02%) to 75.47% when pulling 222188ab6cb0f0b2a1dc1056a0e914ef64177c81 on keflavich:casa_io_fix into bf6673933bb6bd01e6bef55f083b7c364dbf289c on radio-astro-tools:master.

I'm looking forward to the day we can have CASA CI tests.


Select statement - another way

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

@adeelnazir13236 thanx for the pr :balloon:


TASK: Declare Neos 8 compatibility

Seems to be enough, declaring compatibility :)

Hah, somehow I overlooked this and now merged #13 – but I credited you for v2.2.0, too. 😉


Workflow plugin integration

The plugin should implement SimpleBuildStep to allow being called from the workflow-plugin https://github.com/jenkinsci/workflow-plugin

I do not actively develop this plugin. I will maintain pull requests and releases from now on. Please feel free to contribute this feature!

If you would like to be invited to https://jenkins-slack-plugin.slack.com/ for testing then just ask.

I started working on this: https://github.com/Jeff-Symphony/slack-plugin/commit/48238222c8091ad7f5fce3e76098c3ea67f9a070
The integration itself works, but I'm having trouble getting Jenkins' global Slack settings, which means the user would have to set them specifically when adding the workflow step.
I'm open to help on this.

Any luck getting this to work ?

See merged PR #167

I'm having trouble getting 2.0 to work because of a Dependency workflow-step-api (1.11) doesn't exist error when installing the plugin on a clean install. Not sure if anyone else has reported it. Getting it while trying to troubleshoot #188. Looks like the workflow plugin was maybe replaced by pipeline?

Seems to be working correctly with the downloaded 2.0 release, but not if I build it locally. Odd. Please let me know if you know why.

@OwensCode What are the specific errors you are getting when you build locally?
The workflow(now pipeline, but the package names didn't change) dependencies start here:
https://github.com/jenkinsci/slack-plugin/blob/master/pom.xml#L113

@kmadel When I build the Slack plugin locally and try to install it by uploading the .hpi file through the Advanced tab in the Plugin Manager in Jenkins I get this error:

SEVERE: Failed to install slack
java.io.IOException: Failed to dynamically deploy this plugin
at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1383)
at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1161)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:110)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Failed to install slack plugin
at hudson.PluginManager.dynamicLoad(PluginManager.java:508)
at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1379)
... 5 more
Caused by: java.io.IOException: Dependency workflow-step-api (1.11) doesn't exist
at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:533)
at hudson.PluginManager.dynamicLoad(PluginManager.java:498)
... 6 more

This is on docker using jenkinsci/jenkins-1.652. If I manually install the workflow/pipeline plugins beforehand, then it works fine. I wonder if Jenkins does not automatically download and install dependencies when you install the plugin from a local file uploaded.
Let me know if I can provide any more info.

I build and installed the plugin on latest Jenkins 2.6 and it worked. In my case those dependency plugins were already installed.

I had no issues after installing the plugin however the pipeline snippet generator doesn't produce anything good to work with...

Has anyone gotten the plugin to work in a post-build way via a pipeline script?
Sending a slack message from the Jenkinsfile is nice but I'm trying to get it to fire off notifications as post-build actions.
https://jenkins.io/doc/pipeline/steps/workflow-basic-steps/#code-step-code-general-build-step

@NitroPye did you ever figure this out? I'd like the same.

@paralin I ended up wrapping everything in a massive try/catch and then rolled that into a groovy function for other Jenkinsfiles to use. It looks something like this (this ons is called standardDockerBuild:
def call(body) {
  def config = [:]
  body.resolveStrategy = Closure.DELEGATE_FIRST
  body.delegate = config
  body()

  node('docker') {
    try {
      // build steps go here
    } catch(e) {
      currentBuild.result = 'FAILURE'
      throw e
    } finally {
      stage('Post Build') {
        if (config.slackChannel) {
          def color = 'good'
          def message = 'Build Succeeded'
          if (currentBuild.result == 'FAILURE') {
            color = 'danger'
            message = 'Build Failed'
          }
          slackSend channel: config.slackChannel, color: color, message: message + " - ${cleanJobName} #${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)"
        }
      }
    }
  }
}

Then we use this function like this:
standardDockerBuild {
  slackChannel = '#notifications'
}

I know this is probably a bit more than you asked for but you could in theory use the try/catch/finally method in a standard Jenkinsfile. I found it so clunky that I moved it all out into a central place so our team doesn't have to re-implement this logic 125 times.

@NitroPye Neat. Thanks so much for sharing. You put the function into a common Pipeline script that every pipeline can access in your Jenkins config right?

@paralin Yep thats exactly what we did. Its a bit more complex as we have options for buildScript lintingScript, etc but so far its working great across our team.

@NitroPye Would it be possible to make what you've done a wrapper, so:
standardDockerBuild ("#notifications") {
  # Custom build steps here
}

@paralin that seems like it could work. I'm super unfamiliar with Groovyscript. What we ended up doing for the buildScripts is actually more like this
standardDockerBuild {
  slackChannel = '#notifications'
  buildScript = '''
cd /usr/src/app
npm run build
'''

And inside the common pipeline:
sh config.buildScript

I like the idea of a wrapper you are proposing better, not sure how to do it though. It could be super simple but I've written like 4 lines of Groovy and or Java my entire career 😂

can't see an issue here? looks resolved ages ago


fix(supports.focus-in-hidden-iframe): append element instead of document write

covers #126

The tests are failing for this branch, but pass when kicked off locally. No idea what's wrong here… I pushed pr-128-browserstack (only containing your commit) to see if that does anything different…

It appears that you need to close the document before you can safely access document.body, as fc44bd3 shows. Do you want to update your PR (please squash the commits) or should I handle this?

I've tried creating a Chrome App that runs the tests from node_modules/intern/client.html?config=test/browser, but could not make it actually load and execute the tests. It would be great if this were possible, as we'd otherwise go from issue to issue once they're observed - which may not be the case for features that you simply aren't using.

Hi Rodney, sorry I'm having a tough time getting a clean rebase. Feel free to close this request and run with fc44bd3 .

merged as 7d18260 - thanks!