Add JSPM (package manager) compatibility

JSPM is a new package manager and dependency loader.
Added the jspm property to package.json which allows jspm to properly install DataTables and its dependencies.
The DataTablesSrc repository does not have a package.json file, therefore the reason for contributing to this repo.
Also, jspm installs the latest released zip from Github, so this change would have to be merged and released in order for jspm to install DataTables.
I've also submitted a pull-request to jspm/registry that would add DataTables to the jspm registry.

Hi,
Thanks for this. I've just been looking through the JSPM package.json docs and I'm not sure the changes in the override jspm option in the updated JSON are needed are they? JSPM supports files, main and dependencies so isn't the existing file already good to go?
I wonder if we could ask @guybedford for his thought's? (Hi again Guy :-) ).

That was my initial understanding as well. But from my experience JSPM does not install the declared dependencies unless the registry property is specified. From looking at package.json specs , registry doesn't seem to be a package.json property, therefore the need to include it inside a jspm override.
Additionally, a shim property (also not part of package.json) is also required in order for JSPM to load the dependencies in the correct order.
@guybedford I too like to hear your thoughts/insights on this.

@DataTables hi Allan, great to work on this again!

You can include the registry: jspm property at the base-level which will allow jspm to read the dependencies, but jspm doesn't support dependency ranges, so it is advisable to use jquery: * or the semver range like we have in a special jspm dependencies object like we have here.
The directories.lib will make other requires easier as the user only needs to do require('datatables/js/...') if there were other requires. Although it doesn't seem there are so this isn't too critical.
The shim config is certainly needed though to set the jQuery dependency.

I'd advise adding a CSS shim like we do for bootstrap (https://github.com/jspm/registry/blob/master/package-overrides/github/twbs/bootstrap%403.1.0.json) as this allow a single require to get everything to work in the browser.

Hi Guy, thanks for your thoughts on this.

jspm doesn't support dependency ranges

My package.json file uses "jquery": ">=1.7" as a dependency. Are you saying that won't work? The problem for me with jquery:* is that is isn't true - I know that DataTables requires 1.7 or greater.

The shim config is certainly needed though to set the jQuery dependency.

Do you have any docs or code you could link me to that show that. I don't quite get that I'm afraid since jquery is already in the dependencies list? (probably being a total muppet!)

@DataTables I would still suggest jquery: '*' here. I know it is not ideal, but this is entirely due to jQuerys bending of semver. I don't think any users would have reason to install jQuery less than 1.7 in jspm anyway.
jquery needs to be duplicated in the shim and dependencies list, because dependencies is the list of package dependencies to be downloaded at install time, while the shim is like doing a require - it shows that that specific module is dependent on something. For example, a package could have modules that depend on different dependencies.
Let me know if that makes sense, the best examples to look at are other overrides in the registry like https://github.com/jspm/registry/blob/master/package-overrides/github/lightbox2/lightbox2%402.7.1.json.

What is jQuery's bending of semver? The >=1.7.0 that I use I thought was valid semver.

For example, a package could have modules that depend on different dependencies.

I'm totally confused now - sorry, I'm being really thick I'm sure and it might be the terminology that is tripping me up. A module is in a package? And a package is what the package.json file describes - which in this case is my DataTables project? So it could provide multiple modules, each with their own dependency that you can include individually? That's okay, but DataTables doesn't have that, it only has one module and one global dependency. I'm afraid I just don't get what the shim is doing that can't be obtained from the existing information? (sorry - its Friday and I've got a cold so feeling very woolly!)

@DataTables jspm currently doesn't support arbitrary version ranges. This may change over time, but trying to encourage a reduced set of version constraints (basically thinking in terms of locking just major or minor version).

Adding a shim dependency for dep, is the equivalent for a global module of having require('dep') in the code. That is you need the require statement and the package dependency for things to resolve correctly so that dep is installed (from dependencies) and then required (by shim when loading the module).

Okay - I think I get that now. So the shim is to save jspm from needing to look over the code referred to in the package.json file to find any require()'s?
So should I add the following to my package.json file to have it work with jspm:
"jspm": {
	"dependencies": {
		"jquery": "*"
	},
	"registry": "jspm",
	"shim": {
		"js/jquery.dataTables": {
			"deps": ["jquery", "media/css/jquery.dataTables.css!"],
			"exports": "$"
		}
	}
}

Lines 2-4: Override jQuery version to any for JSPM (retaining it at the top level)
Line 5: Set registry to jspm. Presumably this can be done in the jspm object to keep everything specific to JSPM in the jspm object?
Line 7: Is this the correct name? Is it the package name? I've based that off the Bootstrap example
Line 8: require jquery and the DataTables CSS (is jquery required here, even although it is in the dependencies list? The path is relative to the JS file? Or the package file?
Line 9: Is this needed? The documentation says "exports is detected automatically by the SystemJS loader as any globals written by the script. In most cases this detection will work out correctly."

Thanks!

Sorry for the delay here. Yes - shim is basically requires for globals.
The above looks perfect for jspm configuration. To clarify your questions:

The registry is mandatory because we allow registry: npm as well which gets different treatment.
The js/jquery.dataTables path will only be correct if that is the same as the file path within the package without the .js extension. You may need to set a directories.lib="media" option in the package.json so that it takes the package to be the "media" folder, then these paths work out.
The CSS require needs to be relative to the file itself, as if we were doing a require inside that file - `../css/jquery.dataTables.css!'
When using CSS requires, it's important to add the CSS plugin as a dependency as it is not in core jspm (yet) ("css": "^0.1.5" will do).
You do need the exports as SystemJS won't detect that the jQuery global was intended as the export for data tables. It only diffs the window object.

Hope that helps.

Super - thanks for the reply!
So I've added the config from above (slightly modified for the paths and to add the css include) into my package.json file. What do you think?

Nice, looks great to me! Note that css should be in the dependencies object and not at the base level.

What a muppet - doh. Fixed now :-)
Is there anything else needed from me here now? When I get a little bit more time I'll make sure that all of my extensions for DataTables will also operate with JSPM.

Nice, jspm install datatables@master seems to be working great.

Whoohoo! This must be the longest time a package has been waiting on its author to get it ready for JSPM ever.... (shamefaced)

Haha, yes almost two years! Yours was actually the first or second package I ever configured for jspm and used in demos.

Not sure why I didn't close this issue at the time.
Looks like DataTables is still installing okay with jspm :-). Closing now.


check-style: support to run from any directory

Added support to run the script from any directory inside the project, instead of working only if ran from the base directory.
If ran from the base directory, it will behave the same as current master. If ran from an inner directory A, it will capture only files inside A recursively.
If you guys prefer, we can change the second behavior to be the same as the first (instead of adding --recursive flag to cmd_diff, we can add a prefix to the paths added to diff_list).
Signed-off-by: Bruno Melo<EMAIL_ADDRESS>

I agree with you that if we run check-style in the directory A it should only capture files in A.
I tested check-style without any arguments and it looks ok to me, but if I use "-b origin/master" it is failing when running in inner directories. Can you check that?

Hmm, which failure do you get, @otaviobp?
I've done some tests (inner directory and base directory; with and without -b origin/master; with and without modified files not complying with uncrustify.schema) and it seems it works:

Inner dir + no files to check:

bruno@lain ~/soletta/tools $ ./check-style.py
Working directory is clean, checking commit changes for (HEAD~1)
No source files (*.[ch]) changed for: HEAD~1

bruno@lain ~/soletta/tools $ ./check-style.py -b origin/master
Working directory is clean, checking commit changes for (origin/master..HEAD)
No source files (*.[ch]) changed for: origin/master..HEAD

Base dir + no files to check:

bruno@lain ~/soletta $ ./tools/check-style.py
Working directory is clean, checking commit changes for (HEAD~1)
No source files (*.[ch]) changed for: HEAD~1

bruno@lain ~/soletta $ ./tools/check-style.py -b origin/master
Working directory is clean, checking commit changes for (origin/master..HEAD)
No source files (*.[ch]) changed for: origin/master..HEAD

Inner dir + files to check:

bruno@lain ~/soletta/src/samples/coap $ ../../../tools/check-style.py
Changes for (HEAD~1) marked to be checked, but the git tree is dirty -- checking these files instead
--- lwm2m-client.c
+++ lwm2m-client.c.uncrustify
@@ -61,7 +61,8 @@
 };

 static char *
-generate_new_coord(void){
+generate_new_coord(void)
+{
     char *p;
     int r;
     double v = ((double)rand() / (double)RAND_MAX);

bruno@lain ~/soletta/src/samples/coap $ ../../../tools/check-style.py -b origin/master
Changes for (origin/master..HEAD) marked to be checked, but the git tree is dirty -- checking these files instead
--- lwm2m-client.c
+++ lwm2m-client.c.uncrustify
@@ -61,7 +61,8 @@
 };

 static char *
-generate_new_coord(void){
+generate_new_coord(void)
+{
     char *p;
     int r;
     double v = ((double)rand() / (double)RAND_MAX);

Base dir + files to check:

bruno@lain ~/soletta $ tools/check-style.py
Changes for (HEAD~1) marked to be checked, but the git tree is dirty -- checking these files instead
--- src/samples/coap/lwm2m-client.c
+++ src/samples/coap/lwm2m-client.c.uncrustify
@@ -61,7 +61,8 @@
 };

 static char *
-generate_new_coord(void){
+generate_new_coord(void)
+{
     char *p;
     int r;
     double v = ((double)rand() / (double)RAND_MAX);

bruno@lain ~/soletta $ tools/check-style.py -b origin/master
Changes for (origin/master..HEAD) marked to be checked, but the git tree is dirty -- checking these files instead
--- src/samples/coap/lwm2m-client.c
+++ src/samples/coap/lwm2m-client.c.uncrustify
@@ -61,7 +61,8 @@
 };

 static char *
-generate_new_coord(void){
+generate_new_coord(void)
+{
     char *p;
     int r;
     double v = ((double)rand() / (double)RAND_MAX);

At another inner dir which doesn't contain the modified file's dir, nothing is captured as expected:

bruno@lain ~/soletta/src/samples/common $ ../../../tools/check-style.py
Working directory is clean, checking commit changes for (HEAD~1)
No source files (*.[ch]) changed for: HEAD~1

bruno@lain ~/soletta/src/samples/common $ ../../../tools/check-style.py -b origin/master
Working directory is clean, checking commit changes for (origin/master..HEAD)
No source files (*.[ch]) changed for: origin/master..HEAD

It looks like it is failing when we have something committed in the repository.
Steps to reproduce

Edited src/lib/comms/sol-lwm2m.c adding an indentation error.
Create a commit with my changes
Run:
$ ./tools/check-style.py -b origin/master

`Working directory is clean, checking commit changes for (origin/master..HEAD)
--- src/lib/comms/sol-lwm2m.c
+++ src/lib/comms/sol-lwm2m.c.uncrustify
@@ -3923,7 +3923,7 @@
SOL_NULL_CHECK(paths, -EINVAL);
 for (i = 0; paths[i]; i++) {

       bool r_bool;

   bool r_bool;
   uint16_t j, k;
   struct obj_ctx *obj_ctx;
   struct obj_instance *obj_instance;

--- src/modules/flow/form/form.c
+++ src/modules/flow/form/form.c.uncrustify
@@ -1520,7 +1520,7 @@
struct integer_custom_data *mdata = data;
const struct sol_flow_node_type_form_int_custom_options *opts =
(const struct sol_flow_node_type_form_int_custom_options *)options,

*def_opts;

   *def_opts;

def_opts = node->type->default_options;

@@ -2104,7 +2104,7 @@
struct string_data *mdata = data;
const struct sol_flow_node_type_form_string_options *opts =
(const struct sol_flow_node_type_form_string_options *)options,

*def_opts;

   *def_opts;

def_opts = node->type->default_options;

--- src/modules/flow/robotics/robotics.c
+++ src/modules/flow/robotics/robotics.c.uncrustify
@@ -38,9 +38,9 @@
enum switches {
SW_ALL_OFF = 0,
SW_S1 = 1 << 0,

   SW_S2 = 1 << 1,

   SW_S3 = 1 << 2,

   SW_S4 = 1 << 3

SW_S2 = 1 << 1,
SW_S3 = 1 << 2,
SW_S4 = 1 << 3
};

struct hbridge_data {
`

Note that there are errors in other files, that are not expected.

Could you please retest? I had forgotten to add --recursive to the command called at check_commits.

working fine now. Merging


Plus action is not working

when clicking on '+' action on bottom left of the screen, no prompt is opening

Same here, os is macOS big sur 11.6...
vs code version is
Version: 1.60.2 (Universal)
Commit: 7f6ab5485bbc008386c4386d08766667e155244e
Date: 2021-09-22T11:59:27.195Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0

apt install gnome-keyring
This helped for me. But sometimes clicking on + sign do nothing, restarting vs code hellps.

I'm also clicking on the + button and nothing happens.
Version: 1.62.3
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T08:14:33.711Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin arm64 21.1.0

Just restart your VS Code -> it helps in 99% of cases


Wrong loading for media_thumb documentation example

https://github.com/sveetch/django-smart-media/blob/d31a9553c1925b608c19f6d97a2a04d1108c0e25/smart_media/templatetags/smart_image.py#L49
Should be smart_image instead.
Or change the template tag to smart_media instead ? (seems more accurate)

Fixed docstring in 0.2.2-pre.2, did not renamed tag library.


Integration with MongoDB

see original PR #254. There are four mainly differences:

Using Testcontainer and MongoDB Atlas Local Deployment to test
Create collection and index when the MongoDBEmbeddingStore initialize, rather than create when adding new embedding at the first time.
Optimize BsonUtils, which is replaced by org.bson.Document to create index mapping.
Rename langchain4j-mongodb to langchain4j-mongodb-atlas

Local deployment tests are all passed, but cloud tests are not tested yet because I encounter some network problem when communicating with MongoDB Atlas. (But I think it doesn't matter, because local deployment is the same as cloud, the purpose of local deployment is to development and test)

@Martin7-1 if this module can be used for local MongoDB as well, maybe we should remove "-atlas" part from the name? Now it assumes that only atlas can be used...

I think it can't be used for local MongoDB. LangChain python version also named it as mongodb-atlas(see LangChain doc). The local IT uses atlas local deployment (still not vanilla MongoDB, local atlas depolyment aims just for development and test scenario, and it's not recommended in product)

Ok, got it, thanks for explanation!

I am not sure what is the exact reason, but both tests fail for me at the moment.
E.g. MongoDbEmbeddingStoreLocalIT:
com.mongodb.MongoCommandException: Command failed with error 8 (UnknownError): '"indexes[0].definition.mappings.fields.text.type" must be one of [autocomplete, boolean, date, dateFacet, document, embeddedDocuments, geo, knnVector, number, numberFacet, objectId, sortableDateBetaV1, sortableNumberBetaV1, sortableStringBetaV1, string, stringFacet, token]' on server localhost:52237. The full response is {"ok": 0.0, "errmsg": ""indexes[0].definition.mappings.fields.text.type" must be one of [autocomplete, boolean, date, dateFacet, document, embeddedDocuments, geo, knnVector, number, numberFacet, objectId, sortableDateBetaV1, sortableNumberBetaV1, sortableStringBetaV1, string, stringFacet, token]", "code": 8, "codeName": "UnknownError", "$clusterTime": {"clusterTime": {"$timestamp": {"t":<PHONE_NUMBER>, "i": 1}}, "signature": {"hash": {"$binary": {"base64": "eNUE2tp0aXe1rUDNF5POEY4KJO0=", "subType": "00"}}, "keyId":<PHONE_NUMBER>818761730}}, "operationTime": {"$timestamp": {"t":<PHONE_NUMBER>, "i": 1}}}

I am not sure what is the exact reason, but both tests fail for me at the moment. E.g. MongoDbEmbeddingStoreLocalIT: com.mongodb.MongoCommandException: Command failed with error 8 (UnknownError): '"indexes[0].definition.mappings.fields.text.type" must be one of [autocomplete, boolean, date, dateFacet, document, embeddedDocuments, geo, knnVector, number, numberFacet, objectId, sortableDateBetaV1, sortableNumberBetaV1, sortableStringBetaV1, string, stringFacet, token]' on server localhost:52237. The full response is {"ok": 0.0, "errmsg": ""indexes[0].definition.mappings.fields.text.type" must be one of [autocomplete, boolean, date, dateFacet, document, embeddedDocuments, geo, knnVector, number, numberFacet, objectId, sortableDateBetaV1, sortableNumberBetaV1, sortableStringBetaV1, string, stringFacet, token]", "code": 8, "codeName": "UnknownError", "$clusterTime": {"clusterTime": {"$timestamp": {"t":<PHONE_NUMBER>, "i": 1}}, "signature": {"hash": {"$binary": {"base64": "eNUE2tp0aXe1rUDNF5POEY4KJO0=", "subType": "00"}}, "keyId":<PHONE_NUMBER>818761730}}, "operationTime": {"$timestamp": {"t":<PHONE_NUMBER>, "i": 1}}}

I haven't finished it yet, fix will be done in this week. Currently I am confused with the difference between Atlas Search and Atlas Vector Search. Maybe I need a little time, this PR may not be able to merge before this release.

@langchain4j Hi, all tests are passed three times in my local and cloud.

Please ensure your Atlas Search index are created as follow:
{
  "mappings": {
    "dynamic": false,
    "fields": {
      "embedding": {
        "dimensions": 384,
        "similarity": "cosine",
        "type": "knnVector"
      },
      "metadata": {
        "dynamic": false,
        "fields": {
          "test-key": {
            "type": "token"
          }
        },
        "type": "document"
      }
    }
  }
}

As for the question you mentioned about 'PlanExecutor error during aggregation :: caused by :: cannot query index while in state INITIAL_SYNC', I don't have any local replications, so I can't locate where this went wrong. But maybe you can see this to figure out what's wrong in your local environment.

@Martin7-1 thank you, MongoDbEmbeddingStoreCloudIT finally works after I created an index manually with the config you provided. I was also confused between "Atlas Search" and "Atlas Vector Search", so what is the right one? Your index config json should ideally be added to MongoDbEmbeddingStore javadoc with explanations how to create an index. The last link in the javadoc also suggests to create Atlas Vector Search index which is even more confusing :D

@Martin7-1 thank you, MongoDbEmbeddingStoreCloudIT finally works after I created an index manually with the config you provided. I was also confused between "Atlas Search" and "Atlas Vector Search", so what is the right one? Your index config json should ideally be added to MongoDbEmbeddingStore javadoc with explanations how to create an index. The last link in the javadoc also suggests to create Atlas Vector Search index which is even more confusing :D

Currently our implementation use "Atlas Search" as our index, the difference between them is:

Atlas Vector Search allows searching through data based on semantic meaning captured in vectors, whereas Atlas Search allows for keyword search (i.e., based on the actual text and any defined synonym mappings)

I am not sure which one is correct because they seems all work fine. Choosing Atlas Search as our implementation is because the former PR use this way so I continue with it.


Update libraries to support multiple MessageStatus filters when getting messages

Currently, filtering by message status when listing attempted messages is constrained to filtering by just one status (eg "MessageStatus.Success"). However, it would be useful to filter by multiple statuses, particularly for statuses like MessageStatus.Pending and MessageStatus.Sending. This PR updates our libraries to support that behavior.

We're well past the point where we can just ship breaking changes like this.


Make unit test more reliable, fix resulting failure

This unit test was not catching a defect on Mac/Linux because of the way that the compiler can optionally optimize out write operations that occur in the destructor.  Change the test to make use of a static member instead so as to avoid this.

[ ] Fixes #791

Ok, this test seems to pass on Mac, but fails on Windows.  Something is screwy here.

This passes on Linux, too.

I just rebased to 18f49072c7f7781fc9694b72595c97a26bfdf0a4, which ensures this PR is building #774.  Still it passes.  I am going to try something else.

I still get the same error on Windows. In fact, outer(&OuterType::sig) += [this] {...} is not called on Mac and Linux because outer is already destroyed and not autowired any more. That's why this test passes on Mac and Linux.

Good insight.  Let me see if I can make this test more reliable.

Looks great!!


merge from konsum-frontend-svelte

package.json

chore(deps): add ^10.2.0 remove ^10.1.0 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 1.31.17 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.31.17
GitHub release

Your semantic-release bot :package::rocket:


Set up Travis for 0.1.0

The current tool is broken in a couple of ways, so, after #772 is closed, lets get a travis setup rolling with known good font families - perhaps Cousine to start - so that we can prevent regressions; which at the most simple means continuing to pass known good fonts.
Perhaps this is the moment to leave the old codebase on a branch and move 0.1.0 to master.

The old codebase is tagged 0.0.15
I just merged the 0.1.0 branch into master.

@felipesanches sounds good. https://travis-ci.org/googlefonts/fontbakery is passing so closing


Open news.ycombinator.com links inside the app

There are submissions that link to each other.
Example

It will be ideal if accessing that link will open it using the app the instead of the web view.

This is very reasonable and I agree it should be a priority, will try to look at it in not too long.

FYI, this already works when you set Harmonic as the default URL handler for Hacker News links.

True, but you have to manually add the url. It would be a nice addition if the app does it automatically.
For anyone looking how to do it.
Android 13:

settings > apps > harmonic
open by default
add link > select news url or manually enter

I did not know this was a thing even but I agree it is an unfortunate workaround, I'll hopefully get this done soon to make things nicer :)


BUG - Using File Upload with a large file generates a large notification

Description
When uploading a file using the file selector visual element on a large file (bigger than 10Mb), Taipy will create a very long success notification with file_name,file_name,file_name,file_name,file_name,file_name,file_name Uploaded successfully Here is an example with a 200Mb dataset:

How to reproduce
Use this example Taipy app:
from taipy.gui import Gui

content = ""

page = """
<|{content}|file_selector|>
"""

Gui(page).run()

and upload this example 8Mb dataset:
example_data.csv
This will result in the notification issue:

Expected behavior
The notification should only display the file name once
Runtime environment

Taipy version: 3.1.0
OS: Windows
Browser: Chrome

Hi there, can someone look at my PR on this issue?

Hello @Satoshi-Sh, thank you for your contribution.
Next time, please follow the guide in the Contribution page before engaging an issue so we can better manage the PRs. It should save you a lot of waiting time.
For the meantime, I will assign this issue to you, and request a suitable maintainer to review your PR. Thank you for your collaboration.


"Completely" -- except for things that make it complete

URL for relevant page?
https://docs.influxdata.com/kapacitor/v1.3/guides/template_tasks/
What products and version are you using?
Kapacitor 1.3
Where did you look before opening the issue?
Kapacitor documentation
The use of the work "completely" at the end of this paragraph is incorrect:

Notice how everything about the task is a var except for the structure of the task pipeline itself. This allows you to customize the usage of the template completely.

If this allowed you to customize the template completely, there wouldn't be an exception for anything.  According to the first sentence, you can't customize the structure of the pipeline, so you can't customize the template completely.
I'd suggest replacing completely with substantially, or some other impressive word. It is good functionality; I'm not knocking that.  Just looking for precision in the documentation.

Fair enough.  Changed to: This allows substantial flexibility in customization of the template.


Instalation process - "Stop and Back" -> ReflectionException

Steps:

Go through the first three steps of Web-based Installer with valid data
Go to step 4, and start install
If there will be ~68% of installation process, click "Stop and Back"
Then go to step 4 and start install again

Results:
ReflectionException
https://puu.sh/wpbgX/a413375083.png
The same issue is during instalation on Ubuntu 16, but alredy at the first installation without making "stop and back".

@dawid-g Fixed by updating libraryversion. https://github.com/antaresproject/two_factor_auth/commit/6ff0b31d921d6713660cdcec23027e05108ccbd6


CB-10706: (windows) fix ENCODING_ERR for applicationDirectory

Platforms affected
windows
What does this PR do?
add support to reading files from application directory
What testing has been done on this change?
without testing
Checklist

[+] ICLA has been signed and submitted to<EMAIL_ADDRESS>[+] Reported an issue in the JIRA database
[+] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[+] Added automated test coverage as appropriate for this change.

Cordova CI Build has completed successfully.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

I have used this and confirms it fixes the issues with my windows application.


JupyterHub OIDC authentication method

This commit provides a Python class called RucioAuthenticator extended from JupyterHubs GenericOAuthenticator to fetch the access token from the auth_state of the user, request a new refresh token, and place it into the spawners environment for the extension to access. It also provides the rest of the helm config for the setup.
ref #20

@bari12 I've drafted a brief guide on how our setup is configured. It should be simple to understand. I plan to create a more detailed guide for the Rucio documentation later on.
Also, could you add @egazzarr and @garciagenrique to this repo?

Hi @goseind
I added @egazzarr and @garciagenrique to the rucio-dev team. For me the doc looks good (Might need some adaption later on once we change some of the token things) - Can you have a look on the failing tests please.
Thanks!

Looks fine to me, thanks @goseind for this feature !

Looks good to me too! Thanks everyone. I'll merge it like this. The failing tests in #22 still need to be fixed, but since this is more doc related anyway, it shouldn't really matter.


Kernel unittest expectations need rebase after dartformatting

After CL https://codereview.chromium.org/2747113004, the kernel unit tests fail because they have
some expectation files specifying line numbers in the kernel source.  Please run the scripts to
create new baselines for these tests.
The first error of this type, from the builder pkg-linux-release-be, is:
FAILED: none-vm-checked release_x64 pkg/kernel/test/baseline_strong_mode_test
Expected: Pass
Actual: RuntimeError
CommandOutput[vm]:
stdout:
00:00 +0: external.dart
[error] dynamic is not a subtype of dart.async::_BroadcastSubscription (dart:async/broadcast_stream_controller.dart:327:9)
[error] dynamic is not a subtype of dart.async::_BroadcastSubscription (dart:async/broadcast_stream_controller.dart:334:9)
00:12 +1: covariant_generic.dart
00:14 +2: store_load.dart
00:15 +3: arithmetic.dart
00:16 +4: redirecting_factory.dart
00:17 +5: DeltaBlue.dart
00:18 +6: fallthrough.dart
00:19 +7: escape.dart
00:20 +8: unused_methods.dart
00:21 +9: static_setter.dart
00:21 +10: uninitialized_fields.dart
00:22 +11: null_aware.dart
00:23 +12: named_parameters.dart
00:24 +13: optional.dart
00:25 +13 -1: optional.dart
Output of optional.dart changed for strong-mode.

Fixed by ad7d04f76aefb1b031d08a2e8b7646f7875245f5


restrict topics to 20

Context

If we want a quick and dirty way of restricting themes as config PR will take a bit more time.
Changes proposed in this pull request

Guidance to review

Link to JIRA ticket

Things to check

[X] I have added any new ENV vars in all deployed environments and updated the .env.example and .env.test files in the repo

If the topics look ok in pre-prod - then this should be merged and run on prod.


Missing dependency_chain when an error occurs outside a Preprocessor

This change addresses the issue raised in https://github.com/still-ex/still/issues/153
When you define a custom preprocessor chain, if you don't alias a module, the module won't be found, and Elixir will throw an error. This error is hidden in the console while it should have appeared on the page.
Unfortunately, for errors that happened outside a preprocessor are caught in Still.Compiler.Incremental.Node and transformed into a %PreprocessorError, the dependency_chain was missing, and the error overlay could not generate a proper id for the error, therefore never showing the error to the user.
On top of that, if you start the dev server with an empty project, and the error happens in your index.html, you also never get to see the error, you only see that the page doesn't exist. Changing the router to render the dev layout when index.html doesn't exist solves that.

@frm bump


All route param types are broken

What version of Elysia.JS is running?
1.0.10
What platform is your computer?
Linux 6.1.60 x86_64 unknown
What steps can reproduce the bug?
app.get('/', async ({params}) => await test(params), {
    params: t.Object({test: t.String()})
});

params has type never.
What is the expected behavior?
No response
What do you see instead?
No response
Additional information
This issue has been persistent for approximately two weeks. I've tried versions from 0.8.0 to the latest with no success.

I don't know what happened, but everything fixed itself after two weeks of issues. I did not make any changes. Closing this issue.


When consuming Alibaba Cloud PolarDB, there is one more column than the fields in the table.

CREATE TABLE test1 (
id bigint(20) NOT NULL COMMENT '主键ID',
bill_type tinyint(2) NOT NULL DEFAULT '1' COMMENT '',
collect_no varchar(32) NOT NULL DEFAULT '' COMMENT '',
create_time timestamp NULL DEFAULT NULL COMMENT '',
PRIMARY KEY (id) USING BTREE,
KEY f_idx_bgt ((cast(create_time as date)))
) ENGINE=InnoDB
KEY f_idx_bgt ((cast(create_time as date)))
After testing, this index is recognized as a column
I used 1.7 and 1.8

com.zendesk
mysql-binlog-connector-java
0.29.1

I use this to subscribe to binlog and the columns that appear are normal.

UpdateRowsEventData: UpdateRowsEventData{tableId=11071, includedColumnsBeforeUpdate={0, 1, 2, 3}, includedColumns={0, 1, 2, 3}, rows=[

{before=[21, 2, 2211, null], after=[21, 2, 22111, null]}
]}

This is subscribed by go-mysql

duplicated with https://github.com/go-mysql-org/go-mysql/issues/882


Upgrade Pydantic to v2

Test report:
============================================================================================================= short test summary info =============================================================================================================
FAILED tests/resolver/test_rarity_sniffer.py::TestRaritySnifferResolver::test_get_all_ranks_no_contract - requests.exceptions.ConnectionError: HTTPSConnectionPool(host='raritysniffer.com', port=443): Max retries exceeded with url: /api/index.php?query=fetch&collection=0x123&taskId=any&norm=true&partial=false&traitCount=true (Caused by NewConn...
============================================================================================== 1 failed, 61 passed, 9 skipped, 3 warnings in 12.66s ===============================================================================================

raritysniffer.com domain is not active any more and we need to remove all RaritySnifferResolver related code - out of scope of this PR.

closing in favor of #134


documentation for new Liquid filter for running a Rhai script

adding documentation for feature #855

Already in the book: https://cargo-generate.github.io/cargo-generate/templates/index.html#additional-liquid-filters

but maybe we should move the text on the liquid filters to its own chapter under templates - like we have one for the Rhai extensions?

I totally missed it.

but maybe we should move the text on the liquid filters to its own chapter under templates - like we have one for the Rhai extensions?

I guess that would improve the docs structure, since for placeholders we have [5.1. Builtin Placeholders](https://cargo-generate.github.io/cargo-generate/templates/builtin_placeholders.html) so having a section for filters makes total sense.
Very good idea.


Internal server error for GH auth

Linking a GitHub account reseults in 500:
500: io.ktor.serialization.JsonConvertException: Illegal input: Unexpected JSON token at offset 868: Unexpected 'null' value instead of string literal at path: $.name
JSON input: ....."site_admin":false,"name":null,"company":null,"blog":"","loc.....

Hi @tbeu, thank you for the report. I didn't know that GitHub profiles without a name exist. The issue should now be fixed, can you please try it again? Thank you!

Confirmed. Thanks. I have more one one GH account and need to select which one to use.


OpenVPN: Client Specific Overrides with Topology P2P in split mode

Important notices
Not working   OpenVPN: Client Specific Overrides with Topology P2P in split mode
Describe the bug
I noticed that the gui config not create file for user

To Reproduce

Expected behavior
Create files

Describe alternatives you considered
Reset OPNSense to default config and new implementation
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
OPNsense 23.7.5-amd64
FreeBSD 13.2-RELEASE-p3
OpenSSL 1.1.1w 11 Sep 2023

Hello Guys,
I update new version opnsense
OPNsense 23.7.6-amd64
FreeBSD 13.2-RELEASE-p3
OpenSSL 1.1.1w 11 Sep 2023
and afther reboot, the system create file CSC but error IP for Topology P2P .
And i change the csc for other ip not change afther reboot system

Regards.
Humberto Valencia Toxqui


typo issue in HttpClientPluginConfiguration of prefix define for httpClientProperties

Describe the bug
see title
Environment

Soul version(s): [e.g. 2.2.1]

Fix the typo issue
@ConfigurationProperties(prefix = "soul.httpclinet")  -> fixed to "soul.httpclient"

如果你有空的话 能不能参考这个流程https://dromara.org/website/en-us/docs/soul/contributor.html 提一个pr解决这个问题呢


Item Qualities (modifiers) fail to display when clicked from actor sheet or chat window

(SWFFG 1.6, Foundry 0.8.8)
Steps to reproduce:

Create an item quality (i.e. "itemmodifier" type item)
Add quality to existing weapon/armor, or to a newly created weapon/armor
Drag the item onto an actor
Click the weapon/armor (on the gear/equipment tab of the actor sheet), then click on the quality
OR Roll the weapon (or right click-> send to chat) then click the item quality from the chat card

When doing 4 (clicking item quality from character sheet), the following appears inthe console:
 common.js:12 Starwars FFG |  Error loading Read-Only Journal Item ReferenceError: ENTITY_PERMISSIONS is not defined
     at Function.displayOwnedItemItemModifiersAsJournal (embeddeditem-helpers.js:147)
     at async HTMLLIElement.<anonymous> (actor-sheet-ffg.js:416)
 warn @ common.js:12
When doing 5 (clicking the item quality from the chat card), the following error appears in the console:
common.js:12 Starwars FFG |  Error loading Read-Only Journal Item TypeError: Cannot read property 'items' of undefined
at Function.displayOwnedItemItemModifiersAsJournal (embeddeditem-helpers.js:122)
at async HTMLLIElement.<anonymous> (swffg-main.js:497)
warn @ common.js:12
Either way, a yellow warning is created at the top of the screen, stating "The item or quality has been removed or can not be found."
Same results with weapons and armor.
Clicking item quality from the item sheet (whether opened from the sidebar Items tab or when clicking the "edit item" button from the actor sheet) opens the itemmodifier as it should.

Above pull request fixes the first error. The second has an undefined modifierId in the function displayOwnedItemItemModifiersAsJournal() in the embeddeditems-helpers.js file.

I believe this is a similar issue. I fill in my Weapon's Special's section, but I cannot modify the Qualities or Attachments sections. No clickable buttons. Here is a GIF to show what I'm looking at (recorded with Peek).

I am using v1.6. I am also using FoundryVTT v0.8.8.

The qualities and attachments are drag and drop items. Drag an item modifier/attachment onto the weapon and it should appear.

So, the specials that are normally attached to a weapon are now defined as "qualities", correct? Then Item Attachments are those defined in the Genesys optional rules?

That is correct. The special notes section is used for any other notes you want to appear when using the weapon but aren't necessarily a "Quality".

Maybe that's a different issue. I still didn't see the Special section appearing in the expandable view only when doing the edit view. I think I am good for now. Thank you very much!

So I've been experiencing this same issue, but with different error messages.
Forge: v9.280
SWFFG: 1.72
The preconditions are the same; a created item, with qualities added, and then clicking a weapon quality from the actor sheet/chat causes an error. Except this time the error is "item is undefined". Using the debugger, I tracked it down (through the actor sheet line) to line 435 of actor-sheet-ffg.js. Specifically, when it tries to pull the modifierId, it's not there to pull.
Now, that happens with a freshly created item. It does not happen with pre-made imported items from the OggDude importer. Ex. I put the AJ-23 Concussive Rifle on the actor, and was able to open it's weapon qualities from the actor sheet & chat just fine.
When I exported the created item, and the Conc Rifle to compare their JSON files, I found a small difference in the itemmodifiers section. Specifically, all their itemmodifiers had "_id" fields, but only the Conc Rifle's modifiers had an "id" field. When I checked in the debugger, sure enough, line 435 "let modifierId = li.dataset.modifierId;" was pulling the "id" field, not the "_id" field.
I can see this issue is old, so apologies if I should have made a new issue, but the results are the same, even if the cause is a bit different from the original issue. Let me know if I can provide more details.

Most of these cases have been fixed as part of the v10 migration, but I see that it still happens for rolling items. I'll see if I can put together a fix for it.


fixed memory leak from opt return

Fixes #1510
and a few other things along the way.
Now uses .detach to track metrics instead of .item() which keeps speed fast but decreases memory.

Hello @williamFalcon! Thanks for updating this PR.

In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 142:23: E702 multiple statements on one line (semicolon)


Fix TagSelect and MultiSelect stylesheet

@s4nji I have an idea.
We should move all our custom styles (related to select boxed .Select) to one separate file, lets say select.scss and put it into styles folder, include it in the index.scss and that's it.
select.scss:
.j-select {
    font-size: $hf-font-size-base;
    .Select-option.is-focused {
        background-color: $hf-color-snot-green;
    }
    .Select-control {
        .Select-value {
            line-height: $hf-height-input;
        }
    }
    &.Select--multi {
        .Select-multi-value-wrapper {
            margin-bottom: ceil($hf-gutter/2);
        }
        .Select-value {
            background-color: $hellofresh-color;
            border: none;
            border-radius: $hf-border-radius;
            margin-top: ceil($hf-gutter/2);
            color: $hf-color-white;
            line-height: $hf-line-height;

            &-icon {
                float: right;
            }

            &-icon, &-label {
                font-size: $hf-font-size-base;
                line-height: $hf-line-height;
                padding: 2px 5px;
            }
        }
        .Select-input {
            height: 33px;
            padding-top: 5px;
            box-sizing: border-box;

            & > input {
                padding: initial;
                height: 100%;
            }
        }
        .Select-option.is-focused {
            background-color: $hf-color-snot-green;
        }
    }
}

After that, we need to change all .j-tags-select and .j-multiselect classes to j-select.
What do you think?

and sadly, but we need & > input in order to rewrite internal library styles...

I've made a PR (https://github.com/JedWatson/react-select/pull/2066) to react-select, so hopefully, we won't need to use > input selector

@s4nji  awesome! 👍


Skyline/work/20231026 reporter ion improvements

When determining the "best" peak for determining retention time, some fragment types should not be considered - for example, reporter ions like TMT.
In this example, the relatively abundant TMT signal pulls Skyline's RT calculation away from the actual peptide fragments peak:

but with this change only the peptide fragments are used for RT determination

I don't think classes like "IFoundPeak", "IPeakFinder", "ChromKey", or "ChromTransition" should know anything about the "ParticipatesInScoring" flag.
That is, the only things that need to know that a particular transition is non-scoring are things that already have the TransitionDocNode, such as "ChromData"

Thanks for looking at this. I'll have a look at the impact of your suggestion.

@nickshulman That reduces the changes considerably, thanks. This makes it much easier to see the uses of "area" vs "scorable area", I'd appreciate it if you could inspect those.

You raise good questions - @brendanx67 was hoping to avoid UI complexity, initially at least.

I don't think TransitionGroupChromInfo needs to have separate "Area" and "AreaScoring". If we didn't need to worry about backward compatibility, there would only be "Area" and it should exclude non-scoring peak areas.

I was nervous about changing the meaning of Area.


Sourcing zgen binds Alt-/

The following lines in zgen.zsh re-bind Alt-/
ZGEN_AUTOLOAD_COMPINIT=${ZGEN_AUTOLOAD_COMPINIT:-true}
if $ZGEN_AUTOLOAD_COMPINIT; then
    autoload -U compinit
    compinit -d "${ZGEN_DIR}/zcompdump"
fi

Specifically it's "compinit" that does that. Either compinit needs to be stopped from doing this, or the bindkey should be saved and then restored, after doing compinit

Hey,
I approved the PR that changed compinit handling. Please let me know if this problem persits.


Supported Model / Compatibility with USB-Accelerator

Hey,
I read that TensorFlow Lite only supports the SSD models from the Zoo 2 model, for example the SSD MobileNet V2 FPNLite 640x640. My question would be do you have a tutorial to convert it to a TFLite model and can it be run with the hardware accelerator (USB stick) from Google Coral?

It is certainly possible to convert a model trained with the OD API to Tensorflow Lite. You can find an example in my Tensorflow-Lite-Object-Detection-with-the-Tensorflow-Object-Detection-API Repository. There is also an official example.
If you're not limited to the OD-API, I can also recommend using the TFLITE Model Maker.

@TannerGilbert did you have a repo for doing this on tensorflow 1?

@TannerGilbert do you agree?


[UI] - Casl initialized in meshery UI

Notes for Reviewers
This PR fixes #7382
Signed commits

[x] Yes, I signed my commits.

@nebula-aac will you become familiar with our use of this framework? It will be pervasively used. Here is the permissions framework design spec.


Please provide d.ts type definition file

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x] Chrome version XX
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: X.Y.Z

## Current behavior

Currently msal is not very typescript friendly because a d.ts file is not available.
[PR 79](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/79) should at least have generated the d.ts file, but it is no longer doing so.

## Expected behavior

The following command should install types:
`npm install --save-dev @types/msal
`
## Minimal reproduction of the problem with instructions

@wisercoder As you noted, msal should ship with its own type definition files (as opposed to from the @types org). If those do not appear to be working, I think that would be a bug. Can you provide more info on what you are or are not seeing (e.g. intellisense not working, etc)? Thanks!

@jasonnutter turns out this is working as you described. My bad.


Tested the welcome bot for the Hackfest

Follow-up to #12 , needs testing
Links

Link 1

Screenshots
Please add screenshots if relevant.
If they are already linked from the pull request, no need to duplicate

did not work, need another contributor who have not created an issue yet


RFC 1005 does not respect XDG Base Directory Specification

XDG Base Directory Specification: https://specifications.freedesktop.org/basedir-spec/basedir-spec-0.6.html
~/.edgedb/projects folder structure is mentioned multiple times in RFC 1005: https://github.com/edgedb/rfcs/blob/master/text/1005-edgedb-project.rst
This is an inconvenience for me and many other Linux desktop users, there are too many apps that think they're special and should have a folder in home directory.
~/.edgedb should be a last resort folder in case $XDG_CONFIG_HOME is not defined.
This should be relatively easy to implement: checking additional set of env variables before writing/reading config files. I suggest making changes to RFC and implementations before 1.0.
related: https://github.com/edgedb/edgedb-cli/issues/308

We've switched to XDG-conforming layout on Linux in Beta 3: https://www.edgedb.com/blog/edgedb-beta-3-ross#if-you-have-an-older-version-installed


Configuration#9: Step#1: alpha_S=0.4, matter: q_0=1 | matterlbt: q_0=2.5: matterlbt02

run the simulation with the above config by jetscape,
transfer the final state hadron to the related directory named as config-XX-final-state-hadrons
after doing step1 on all 12 simulations go to step 2 for the configurationX

config-09-singularity-runner-matterlbt-02-output-4056652.out
[Info] 3735MB  JetScape finished after 100000 events!
[Info] Finished!
CPU time: 35499.734375 seconds.
Real time: 35829.000000 seconds.
[Info] 3735MB   clean up the loaded hydro event ...

port to Excel for overleaf


"Block Editor" to "Blockflow" for consistency

The name's pretty great so why not use it

I made the change intentionally, but you're right.


"Simplenote" has been used

Simplenote is a great app for Android, iOS, macOS, Windows.
Maybe you have a more creative name for your awesome app.

Thank you for your suggestion.I know this app and used to use it.Therefore, I use this name.But my rubbish work has no correlation with it, and won't use in business.So I won't change it(unless you moved me ).just for fun.


Avoid using globals for JSON RPC.

In this change JSON RPC related global variables were moved into a dedicated structure. It makes design flexible and testable. In addition tests are reworked to create a new JSON RPC structure per test. It makes the tests hermetic and allows to run them in parallel.
@glimchb I believe that with this patch our tests are fully isolated and we won't see unexpected unit test failures which were observed lately. Also gochecknoglobals  can be added into CI

please split into several commits, try to avoid mixing logical functionality in the same commit looks like
* JSONRPC struct to remove globals is one

* Main flags restructure is second

* and re-writing testing infra  is third commit

split

the code looks ok, take me time to go over all the changes... one thing that jumps out is that you change Call interface, which will lead to changes to all the bridge implementations that we have now...

Do the other bridges always use the latest version from this SPDK bridge? Is it a right approach? Should they always point to a specific version and updated only on demand?🤔
I provided the Call() as well as test functions for backward compatibility and marked them as deprecated since they use a global instance. Ran marvell and nvidia unit tests on the local machine successfully. However, the main procedures there should be updated to inject a json rpc instance. To reduce any further disruptions in other bridges, I also converted JSONRPC to an interface and provided methods to create frontend, backend and middleend Servers. All new changes are split to commits, so please have a look

Do the other bridges always use the latest version from this SPDK bridge?

no. they always point to a specific version. and we have renovate bot to propose update PRs

Do the other bridges always use the latest version from this SPDK bridge?

no. they always point to a specific version. and we have renovate bot to propose update PRs

so if that bot creates a PR to update opi-spdk-bridge version, I think, I can modify main functions of other bridges directly in those PRs to leverage JSONRPC interface instead of the default global server.Call.

so if that bot creates a PR to update opi-spdk-bridge version, I think, I can modify main functions of other bridges directly in those PRs to leverage JSONRPC interface instead of the default global server.Call.

yes, I like this approach better

so if that bot creates a PR to update opi-spdk-bridge version, I think, I can modify main functions of other bridges directly in those PRs to leverage JSONRPC interface instead of the default global server.Call.

yes, I like this approach better

The code in the patch is updated to provide a default global JSONRPC with the servers created by means of NewServer(). This should provide the required backward compatibility. The plan is the following:

Merge the updates to use NewServer() for other bridges:
https://github.com/opiproject/opi-intel-bridge/pull/8
https://github.com/opiproject/opi-marvell-bridge/pull/144
https://github.com/opiproject/opi-nvidia-bridge/pull/127
An update for AMD is not prepared since I am not allowed to create a fork
Merge this patch
Update other bridges to use JSONRPC injection
Remove the rest of global variables from opi-spdk-bridge

The plan is the following:

Merge the updates to use NewServer() for other bridges:
Update opi spdk bridge package opi-intel-bridge#8
Use NewServer to create opi-spdk server instances. opi-marvell-bridge#144
Use NewServer to create opi-spdk server instances. opi-nvidia-bridge#127

merged


Change Matrix to Slack for user-facing channels

Have changed the links to point towards user-facing single-cell channels

great! can you also put it in the footer in this pr please? next to the matrix link, should be _includes/footer.html or so

I'm really sorry, I don't understand - in that same FAQ, or in the index.md page, or in the tutorial page? I was looking for anything that said '_includes/footer.html' so that I could copy that format but couldn't find it.

Thanks for sorting me out. Now I know!
Wow I didn't know that about Slack and the 400-limit!


Re-factor PDFViewerApplication._initializeAutoPrint slightly (PR 16779 follow-up)

After the src/core/-changes in PR #16779 the PDFDocumentProxy.getJSActions method should no longer be able to return empty entries, which means that we can simplify the "JavaScript support is not enabled"-warning in the viewer.
Furthermore, utilizing modern JavaScript, we can also simplify how auto-printing is triggered in the viewer.

/botio integrationtest

/botio-linux preview

/botio-linux integrationtest


Add optional param to useRootNavigator when showSearch

I added the optional parameter useRootNavigator to choose which navigator it push to.
issue 61288
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hi @chunhtai
can you help me review this PR?

Hi @tbm98 thanks for submitting this PR. Can you add a test to make sure we don't accidentally break it?

I am a little bit oppose the idea of adding this flag, developer can get the navigator context they want to display the search and pass it into the context. It is more declarative and we should encourage the developer to do that if they have more than one navigator.

most have only two use cases.
first case: I only manage a single navigator and I don't care which navigator showSearch will push SearchPage to, it always shows the whole screen.
case two (mostly): I will use a PageView, and each Page will manage its own navigator. all operations are on a Page and it is very rare for this Page to showSearch to another Page's navigator.
this is exactly the same with showDialog function

Hi @chunhtai.
I just added a test to make sure the code works properly.
What do you think about the point I mentioned in the comment above?

This PR is causing a Google internal test to fail.

Hi @tbm98 This is unfortunate, It seems like we have to default it to false. Would you open an other pr to do that?

Yes. I will submit another PR to fix it @chunhtai :D


tlock-go: encryption in the future wraps to round 1

Linking PR: https://github.com/drand/tlock/pull/36


Export unstable_data()

The change in this PR exports the new unstable_data function of Remix v2.11.0 from @remix-run/server-runtime so that it is available to import from @vercel/remix.

Thank you!


KNX interface startup issue

This error is related to the fact that the knx component does not stop correctly. Usually, could be triggered by a restart which takes place before the knx component has been completely setup.
In this scenario the knx instance does not disconnect from the knx/IP interface.
This results in an error at the next startup because the IP interface can only handle one connection.
It can be solved with hard-resetting the knx bus power supply.
Home Assistant version:
0.46.0
Component:
knx
Error:
[homeassistant.setup] Setting up knx
[homeassistant.components.knx] Res = False
[homeassistant.setup] Setup of domain knx took 0.1 seconds.
[homeassistant.setup] Setup failed for knx: Component failed to initialize.

it takes place only when the following trace is NOT present when restarting HA:
2017-06-26 15:07:18 DEBUG (Thread-1) [root] knx Disconnecting KNX/IP tunnel...


Improve testing for HTTP proxy client

The HTTP proxy client receives requests from HTTP in JSON format and forwards the requests through the native C++ chogori client. Currently it only supports a static collection and schemas with begin txn, read, write, and end txn support. First we should improve the testing of the existing functionality.

Python test script: test/integration/test_http.py
Runner test script: test/integration/test_http_client.sh
HTTP proxy client implementation: src/k2/cmd/httpclient/http_client.cpp
C++ native client implementation: src/k2/module/k23si/client/k23si_client.h

Tests to add:

Read/Write/End with a bad txn id.
Read/write with a bad schemaName
Write with a bad schemaVersion
Read a non-existent key
Using two txns, a write-after-read conflict
Read/write with a field specified that is not part of the schema
Read/write with a field where the value type does not match the schema

@jfunston The issue is fixed.


how to verify websocket connectivity?

https://docs.botframework.com/en-us/restapi/directline3/
in directline3 docs websocket section writed:

"Clients may send their own empty messages to verify connectivity. The Direct Line service will ignore these."

but how to verify websocket connectivity ?  when websocket.send('')  no message geted

Hi @oblank, sending a blank message does not return a response, but it does require a successful TCP exchange to take place between your client and the service.
The Web Socket implementation in your browser/client should generate a socket error if the TCP packet was not acknowledged.

Note: Please only submit Bot Builder SDK bugs here. If you have general questions or implementation issues, please submit a question on Stack Overflow at http://stackoverflow.com/questions/tagged/botframework


Refactor Policies

Make this store policy objects internally, and contain all policy behaviours.

Implemented in 3d09135069a170b12734ccaf6d1cd124f607e664. Closing.


Use U+002d instead of U+2013

This PR is change to use common ASCII characters.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[-] Added tests.
[x] Updated documentation.
[-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Should we only allow merging and disable squash and rebase in this repo, @bquorning ?

Fine by me (it’s my preferred setting anyway) – I’ve change the settings.


Current Build - Developing for Dynamics 365 Business Central Link Broken

The link to "Current Build - Developing for Dynamics 365 Business Central" link (https://partner.microsoft.com/en-us/dashboard/collaborate/packages/4756) appears to be broken. Following the link just takes me to the dashboard.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 936119a1-4f7e-ed69-f72e-44e41464f964
Version Independent ID: c30741c6-9408-775a-5ce0-3f6986445447
Content: Testing your Extension - Business Central
Content Source: dev-itpro/compliance/apptest-testingyourextension.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: rweigel

Thanks for your feedback. I have updated the doc to instead say that you need to log into Collaborate, then under packages find the Current Build - Developing for Dynamics 365 Business Central link. Topic will be updated with the next refresh. Thanks!


App id input looks a bit strange

The first input in the New Application Modal looks a bit strange before entering an app id.
Environment: Win7 IE11

I can reproduce this rendering quirk in IE11, but if anything this seems like an IE11 bug to me:

basically as soon as the mouse is moved, the blinking cursor restores its actual position. Maybe we could hack some IE-specific solution together (trigger a repaint when the transition is completed, disable the transition, etc.) but I'm not too keen on doing that.

I get the very same quirk rendering in Microsoft Edge. It seems to be an issue with transitions.

My hunch is we should wait for the transition before focusing the input field.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2686. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Business intelligence solution

The branch used to send the pull request is an old branch. Run a ‘git pull’ and create a new branch for the changes and send your pull request again.


[FR]: Register the prebuilt toolchains for proto_library

What is the current behavior?
Currently this repository registers toolchains that look like this (an example from bazel cquery '@toolchains_protoc_hub//:linux_x86_64_toolchain' --output build):
toolchain(
  name = "linux_x86_64_toolchain",
  toolchain_type = "@@rules_proto~//proto:toolchain_type",
  exec_compatible_with = ["@platforms//os:linux", "@platforms//cpu:x86_64"],
  toolchain = "@@toolchains_protoc~~protoc~toolchains_protoc_hub.linux_x86_64//:prebuilt_protoc_toolchain",
)

However the proto_library rule that we are supposed to use (going forwards?) from https://github.com/protocolbuffers/protobuf/blob/main/bazel/private/bazel_proto_library_rule.bzl uses the toolchain name @com_google_protobuf//bazel/private:proto_toolchain_type source.
This means that if you want to use proto_library, the protoc will still be built from source, while in reality with toolchains_protoc it could use the prebuilt version.
Describe the feature
This feature request is quite simple, we should generate additional toolchain definitions that are identical to the existing ones, but have an additional name of @com_google_protobuf//bazel/private:proto_toolchain_type. I can make the PR if you agree with this feature. I made a proof of concept where I wrote out some toolchains to validate the idea and it seems to work:
https://github.com/Andrius-B/protoc_toolchains_for_proto_library/blob/main/MODULE.bazel#L17-L35
I would like to note that since the rules were moved from rules_proto to protobuf a lot of documentation is out of date so I might be wrong about which proto_library we're meant to be using in the future and that might invalidate this feature request

Yes this stuff was broken by upstream, I had a design disagreement with them but they're the upstream so it's always a losing battle. We'll just abandon this effort for now, sadly.


Force rebuild all packages in CI

qt5-tools regression on linux due to automatically picked up external dependency to some XML library in one of the qt5-ports. qt is really annoying with this automatically picked up dependencies.

It will take some time to fix all of these regressions 😞

@vicroms Don't worry, some of them are expected.

Check port failures on Linux:

Port
Failures

google-cloud-cpp
conflict with google-cloud-cpp-common

libmesh
conflict with boost-algorithm

mmx
conflict with jsonnet

nanovg
conflict with stb

otl
File does not have expected hash:   File path: [   /ci/myagent/_work/2/s/downloads/temp/otlv4_h2-4.0.447.zip ]   Expected hash: [<PHONE_NUMBER>2a327a7d9154f6e817c0166ed254cfe3b9d043762179e96180a70d3ba4b3762e5ef1ebdb18492e3425467c9ddad3a2c68aa93bb7d51d54e9712008   ]   Actual hash: [   03616606ffb903e43af2e8fec0cd6ecd22380b711966145ca7fe5f1ccde151dcaff044ce7c81389e4055cdab72d019cc301d023a6e179492d1df8b5f2787f4d9   ]

xmsh
Failed to download file. The source https://github.com/libxmsh/xmsh/archive/v0.4.1.tar.gz   doesn’t exist. Need update.   -- Downloading https://github.com/libxmsh/xmsh/archive/v0.4.1.tar.gz...   Failed. Status: 22;"HTTP response code said error"

rapidstring
Failed to download file. Cannot access the https://github.com/boyerjohn/rapidstring   -- Downloading   https://github.com/boyerjohn/rapidstring/archive/ee433955c1e9cacfaecbf53c0a13318ab5825bd4.tar.gz...   Failed. Status: 22;"HTTP response code said error"

tinyfiledialogs
Failed to download file. The source URL https://git.code.sf.net/p/tinyfiledialogs/code   could not access.

cppkafka
Build failures

qt5-tools
Build failures

quickfix
Build failures

Xalan-c
Build failures

Ports failures on windows:

Port
Triplets
Failures

google-cloud-cpp
x64-windows   x86-windows   x64-windows-static
conflict with google-cloud-cpp-common

ogre
x64-windows    x86-windows   x64-windows-static
Conflict with ogre-next

mmx
x64-windows   x86-windows   x64-windows-static   x64-uwp   arm64-windows   arm-uwp
conflict with jsonnet

nanovg
x64-windows   x86-windows   x64-windows-static   arm64-windows
conflict with stb

otl
x64-windows   x64-windows-static   x64-uwp   arm64-windows   arm-uwp
File does not have expected hash:   File path: [   /ci/myagent/_work/2/s/downloads/temp/otlv4_h2-4.0.447.zip ]   Expected hash:    [<PHONE_NUMBER>2a327a7d9154f6e817c0166ed254cfe3b9d043762179e96180a70d3ba4b3762e5ef1ebdb   18492e3425467c9ddad3a2c68aa93bb7d51d54e9712008 ]   Actual hash:    [   03616606ffb903e43af2e8fec0cd6ecd22380b711966145ca7fe5f1ccde151dcaff044ce7c81389e4055cd   ab72d019cc301d023a6e179492d1df8b5f2787f4d9 ]

parmetis
x64-windows   x86-windows   x64-windows-static
Failed to download file  Downloading http://glaros.dtc.umn.edu/gkhome/fetch/sw/parmetis/parmetis-4.0.3.tar.gz...    Failed. Status:   6;"Couldn't resolve host name"

rapidstring
x64-windows   x86-windows   x64-windows-static
Failed to download file. Cannot access the https://github.com/boyerjohn/rapidstring   -- Downloading https://github.com/boyerjohn/rapidstring/archive/ee433955c1e9cacfaecbf53c0a13318ab5825bd4.tar.gz...      Failed. Status: 22;"HTTP response code said   error"

cnl
x64-windows-static
Failed to download file.    Downloading   https://github.com/johnmcfarlane/cnl/archive/48428242e72b8239cb14c963e40f724929d54df7.tar.gz...      Failed. Status: 22;"HTTP response code said   error"

tiff
X64-uwp
-- Downloading   http://download.osgeo.org/libtiff/tiff-4.0.10.tar.gz... Failed. Status:   7;"Couldn't connect to server"

tinyfiledialogs
x64-windows   x86-windows
Failed to download file. The source URL https://git.code.sf.net/p/tinyfiledialogs/code   could not access.

libfabric
x64-windows
Build failures

pangomm
x64-windows
Build failures

quickfix
x64-windows   x86-windows   x64-windows-static   x64-uwp   arm64-windows   arm-uwp
Build failures

tesseract
x64-windows   x86-windows   x64-windows-static
Build failures

gsoap
x86-windows   arm-uwp
Build failures

libxslt
arm64-windows
Build failures

qhull
arm-uwp
Build failures

Exist PRs to address above issue:
otl: https://github.com/microsoft/vcpkg/issues/8794
xmsh: https://github.com/microsoft/vcpkg/pull/7155

I have removed the failing tombstones and will rerun the tests, hopefully this will reduce the number of regressions

/azp run

4 ports failed totally on windows In latest CI results:
3 ports failed to download the source file:
rapidstring: the source has gone, I can not find the new address instead.
parmetis: http://glaros.dtc.umn.edu/ seems down, I can't access it.
tinyfiledialogs: failed get source from https://git.code.sf.net/p/tinyfiledialogs/code, also failed to download from https://sourceforge.net/projects/tinyfiledialogs/
1 ports libxslt failed with arm64-windows, I can't repro this issue with vs2017 and vs2019 on windows locally, failures:
libxml2.lib(libxml2.dll) : fatal error LNK1112: module machine type 'ARM64' conflicts with target machine type 'ARM'

rapidstring seems to have disappeared from the face of the earth (the author deleted their GitHub repo and with it all existing forks); so we should probably delete the port as well.
I've updated the current commit ID for tinyfiledialogs, the failure is unexepected as I'm still able to browse their repo at the previous commit but vcpkg is not able to get the sources.
I'm not sure what to do about parmetis, as the top-level domain is still alive and kicking (belongs to the Unniversity of Minessota), it might come back it might not... for the time being I'll just disable that port in our CI.
I'll take a look at libxslt, it has failed consistently on our CI machines so it is not a false negative.

quickfix fails when double-conversion is installed, this is due to it using an embedded dependency of double-conversion.

/azp run

Current regression port:
Linux:

qt5-tools

OSX:

llvm
xmsh

Windows(arm64-windows):

libxslt

@vicroms
OTL maintainers has the very bad habit of updating zip overwriting previous one. Hash was failing because it was updated to .448 in the meantime, so you can refer to that version now since you updated hash in 2a32220852e5eada6e17eb33d2cd1b740a87744f

@cenit thanks for the heads-up, I changed the CONTROL version.

/azp run

I can't reproduce the arm64-windows error on my machine, it seems that everything is fine.

And I can't repro x64-linux error on the machine. libEGL.so/libicui18n.a/libicuuc.a/libicudata.a does not exist on my machine, but qt5-tools has been successfully built.
@Neumann-A I think qt5 automatically activates some options, what do you think?

@JackBoosY: Yeah I fear we must be explicit about all the qt options and make them a feature (#8213) or the default. qt-imageformats for example has 4 options and at least 3 can make problems in vcpkg from which two are explicitly set (tiff, webp) and jasper is missing. Those options can be discovered by looking for a config_help.txt or by searching for a number of configure.json in the source tree. But without #8269 solved I fear that static builds might be difficult to link correctly due to all the possible options in building dependent libraries.
The other question is how can we make features which are only available on certain platforms. Qt has a lot of options which only apply to Unix or Windows. So having target dependent features would be nice to have (like target dependent Build-Depends)
I already have a small number of qt fixes in different PRs to silent CI:
libpq fix
https://github.com/microsoft/vcpkg/pull/8551/commits/e4a55093dd01f79afa70355e259f5cb99f051f5a
qt-imageformat (jasper fix)
https://github.com/microsoft/vcpkg/pull/8566/commits/db518863bdf000b04b54b1d909232028e47a2999
https://github.com/microsoft/vcpkg/pull/8566/commits/f1e3e10f3b141d74547798146ca149eac42b3c67
https://github.com/microsoft/vcpkg/pull/8566/commits/d0f191708e02eb3f10049b9b0335cfadf5f3803e
https://github.com/microsoft/vcpkg/pull/8566/commits/c1be2ac36bcbe69604fc2d9b3c421e59e0e6ba5c
The current errors seen in qt5-tools are probably due to the following options in qt5-base:
  -icu ................. Enable ICU support [auto]
  -opengles3 ........... Enable OpenGL ES 3.x support instead of ES 2.x [auto]
  -egl ................. Enable EGL support [auto]

To make static builds work you need to probably pass ICU_LIBS and EGL_LIBS with the correct libraries.
but there are a few more options which should be checked like:
  -doubleconversion .... Select used double conversion library [system/qt/no]
                         No implies use of sscanf_l and snprintf_l (imprecise).
  -glib ................ Enable Glib support [no; auto on Unix]

(basically everything which is auto in the config_help.txt should be checked.)
You can always check the config--err.log to see which options have been enabled.

/azp run

Thanks @Neumann-A  for the very informative comment about Qt's regressions, I agree that the ports need a lot more work in order to get rid of as much auto-configured options as possible.
There are PRs open to introduce qualifiers for default features, (e.g.: Default-Features: feat-a(windows&!uwp) feat-b(!windows) feat-c). But they're blocked by the current state of CI 😞
With the purpose of unblocking CI ASAP, I decided to only add the missing dependencies to Qt and handle further changes in a PR later.

Some good news, looks like the download servers for metis and parmetis are back, so I've reenabled them in CI.

/azp run

/azp run

I see failures on Mac OS during the build step but there aren't any corresponding log files

/azp run

/azp run

@vicroms
OTL maintainers has the very bad habit of updating zip overwriting previous one. Hash was failing because it was updated to .448 in the meantime, so you can refer to that version now since you updated hash in 2a32220

In the meantime OTL has been updated again.
Since 2019-11-15 it is at version 4.0.449
New sha512:
055bc52233553738fbdc52a1c5885fad72f3f7bfa9df7bd5880ab47dd656439d00ff8870b1c9a807dc32e205921abbf0ca34bd2bc29aed257fd822685fee8c9e

@vicroms
OTL maintainers has the very bad habit of updating zip overwriting previous one. Hash was failing because it was updated to .448 in the meantime, so you can refer to that version now since you updated hash in 2a32220

In the meantime OTL has been updated again.
Since 2019-11-15 it is at version 4.0.449
New sha512:
055bc52233553738fbdc52a1c5885fad72f3f7bfa9df7bd5880ab47dd656439d00ff8870b1c9a807dc32e205921abbf0ca34bd2bc29aed257fd822685fee8c9e

https://sourceforge.net/p/otl/discussion/208859/thread/fdb9d3bacc/

In the meantime OTL has been updated again.

@c72578  Thanks for the heads-up!

https://sourceforge.net/p/otl/discussion/208859/thread/fdb9d3bacc/

@cenit Thank you very mcuh for taking the time to report this upstream! I read the thread and I'm glad that the maintainers were so quick to address this.

qt-base requires fontconfig on linux due to automatic detection. Add FONTCONFIG_LIBS and also pass expat and libiconv libraries in that variable. Missing symbols seem to be due to expat. Alternativly disable fontconfig for now via -no-fontconfig

qt5-tools: library libxml2 is not linked.

@JackBoosY It is expat not libxml2. libxml2 uses different symbols. (see https://github.com/microsoft/vcpkg/pull/8912#issuecomment-554796750) https://www.xml.com/pub/a/1999/09/expat/reference.html

/azp run

/azp run

/azp run

(otl is "broken" on master, you might already know that...)

@JackBoosY you just broke @vicroms PR in the same way the master is broken.... @vicroms original otl's portfile was ok

@cenit Ops...I thought this port has been updated.

@JackBoosY I think the google-cloud-cpp issues should be resolved now (see #8986 ) please let me know if I can help in any way.

/azp run

rapidstring seems to have disappeared from the face of the earth (the author deleted their GitHub repo and with it all existing forks); so we should probably delete the port as well.

I have a clone of that repository, if you want (only latest commit). But not being the original library author, I think it might not be the best idea to point to my repository...
https://github.com/cenit/rapidstring

As CI has been restored, this full rebuild is no longer necessary, I'll separate fixes made in here into their own PRs.
Thanks to everyone that helped with solving the flakiness in our ports!


Errors when building with TypeScript - No overload matches this call

Hi! 👋
I kept getting some errors (No overload matches this call. / Type 'ObjectPlugin<any[]>' is not assignable to type 'Plugin') when building my application with TypeScript
It seems that Vue excepts the plugin to be the type ObjectPlugin but i18nVue is type Plugin
I'm not that strong in TypeScript, so I don't have a clear idea if it's on purpose or anything, but I managed to fix it by casting the plugin as an ObjectPlugin
My fix:
.use(<ObjectPlugin>i18nVue, {
  resolve: async (lang: string) => {
    const langs = import.meta.glob('../../lang/*.json');
    return <Promise<LanguageJsonFileInterface>>await langs[`../../lang/${lang}.json`]()
  }
})

Error output from the build command:
bun run build
$ vue-tsc && vite build
resources/js/app.ts:39:12 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(plugin: Plugin<[{ resolve: (lang: string) => Promise<unknown>; }]>, options_0: { resolve: (lang: string) => Promise<unknown>; }): App<Element>', gave the following error.
    Argument of type 'Plugin' is not assignable to parameter of type 'Plugin<[{ resolve: (lang: string) => Promise<unknown>; }]>'.
      Type 'ObjectPlugin<any[]>' is not assignable to type 'Plugin<[{ resolve: (lang: string) => Promise<unknown>; }]>'.
        Type 'ObjectPlugin<any[]>' is not assignable to type 'FunctionPlugin<[{ resolve: (lang: string) => Promise<unknown>; }]>'.
          Type 'ObjectPlugin<any[]>' is not assignable to type '(app: App<any>, options_0: { resolve: (lang: string) => Promise<unknown>; }) => any'.
            Type 'ObjectPlugin<any[]>' provides no match for the signature '(app: App<any>, options_0: { resolve: (lang: string) => Promise<unknown>; }): any'.
  Overload 2 of 2, '(plugin: Plugin<{ resolve: (lang: string) => Promise<unknown>; }>, options: { resolve: (lang: string) => Promise<unknown>; }): App<Element>', gave the following error.
    Argument of type 'Plugin' is not assignable to parameter of type 'Plugin<{ resolve: (lang: string) => Promise<unknown>; }>'.
      Type 'ObjectPlugin<any[]>' is not assignable to type 'Plugin<{ resolve: (lang: string) => Promise<unknown>; }>'.
        Type 'ObjectPlugin<any[]>' is not assignable to type 'FunctionPlugin<{ resolve: (lang: string) => Promise<unknown>; }>'.
          Type 'ObjectPlugin<any[]>' is not assignable to type '(app: App<any>, options: { resolve: (lang: string) => Promise<unknown>; }) => any'.
            Type 'ObjectPlugin<any[]>' provides no match for the signature '(app: App<any>, options: { resolve: (lang: string) => Promise<unknown>; }): any'.

39       .use(i18nVue, {
              ~~~~~~~

Found 1 error in resources/js/app.ts:39

Thanks for this one, if anyone wants to make a PR for this one I appreciate it!

My fix:
import { i18nVue } from "laravel-vue-i18n"
import {ObjectPlugin} from "vue"

...
.use(i18nVue as unknown as ObjectPlugin, {
        resolve: async (lang: string) => {
          const langFiles = import.meta.glob('../../../lang/*.json');
          return await langFiles[`../../../lang/${lang}.json`]()
        }
      })
.mount(el)


Use & and | for conjunction and disjunction of search strings instead of , and checkbox

Also, add the filter boxes to the table and let column width be decided by the browser.

Filter boxes are now located in the header of the table and can contain logical expressions with & and |. The mobile version is not searchable at the moment because the header is not displayed in this version.

Seems to work fine. Opened a new issue #17 for the mobile version.


3.2.1

Description

Launch of version 3.2.1 of the plugin - this is pretty much just a version number rev with updated dependencies...
Motivation and Context

Get our plugin running on SDK version 6 [#101]
How Has This Been Tested?

iPhone 6s running iOS 10.1
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have read the CONTRIBUTING document.

@dsgriffin can you take a look for me?


Tyop.

So much for feature complete...

Lol, thankfully there are good people like you out there

It would really amuse me dead if this receive more contribution than real projects


Lowercase 'Command' and 'Args' when describing "containers" specs.

They must be lowercase in json and yaml, which is the most common
user-visible interface.
Partially addresses #1555.

This change is

Thanks!
LGTM
cc @steveperry-53 @pmorie


Question about doing a delay/wait

What is your question?
I'm not sure how to do delay/wait in the psych engine luascript. My introduction to lua was roblox and in that you simply do wait(number of seconds) but i tried that and it didn't work. Does anybody know how to do a delay?

you use the timer function in the wiki

ok thanks


Renamig a file on github.dev does not keep file mode/permission

Does this issue occur when all extensions are disabled?: No Test for without extension

VS Code Version: github.dev at 2021-11-11 (JST/UTC)
OS Version: Chrome on iPad OS 15.0 (Mozilla/5.0 (iPad; CPU OS 15_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/96.0.4664.36 Mobile/15E148 Safari/604.1)

The VSCode drops executable file mode/permission on renaming a file on github.dev.
Steps to Reproduce:

open github.dev editor for a repository which has a executable file
rename the executable file
commit
now the executable mode/permission have been lost.

Example commit: https://github.com/anatawa12/ffmpeg-build/commit/7fd980dad3f3da144b6cfd7b026068544f39cce4. the commit drops executable flag of build.sh which is renamed to configure.sh.

The root cause is that we represent a rename operation as a delete and add, and we don't propagate the mode info from the deleted file into the added file when committing. We currently only track the mode for GitHub, not Azure Repos, so we should probably delegate the rename operation back to the specific provider (GitHub provider vs Azure Repos provider).

For DVCS files, this is terrible because it loses track of the file origination.
Also, there's no way to get or set file modes in github.dev, so it's even more unhelpful.

For DVCS files, this is terrible because it loses track of the file origination.

Could you please clarify what the above means? In my testing, a renamed file committed via github.dev correctly shows up as having been renamed without changes:

Hm, the executable permission being lost might be a bug in the createCommitOnBranch GraphQL API, which we switched to in Feb 2022. Commits created with that API are supposed to behave the same as any file operation on github.com, and I verified that the mode is preserved when doing a file rename on github.com:

There's no way to either duplicate a new file as a modified copy of an
original one or chmod it.
On Fri, Jan 20, 2023 at 1:37 PM Joyce Er @.***> wrote:

For DVCS files, this is terrible because it loses track of the file
origination.
Could you please clarify what the above means? In my testing, a renamed
file committed via github.dev correctly shows up as having been renamed
without changes:
[image: image]
https://user-images.githubusercontent.com/30305945/213790177-fb44aa77-3be2-407a-833f-2b31efbcdaee.png
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-remote-repositories-github/issues/84#issuecomment-1398845257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABWYMGG763VFKRDOHOP47DWTLSQTANCNFSM5HZXKFCQ
.
You are receiving this because you commented.Message ID:
@.***
com>

Renames committed through github.dev not preserving the file mode appears to be due to a bug in the createCommitOnBranch API, therefore labeling as upstream and will provide updates on this issue when the API issue is resolved.


Release 2.3.1

Codecov Report

Merging #476 (8d0eb74) into master (b592092) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   97.21%   97.21%
=======================================
  Files          55       55
  Lines        4027     4027
=======================================
  Hits         3915     3915
  Misses        112      112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b592092...8d0eb74. Read the comment docs.


Let the CI deploy releases to npm automatically

Just like we had it with Circle CI before, this makes running npm publish locally unnecessary.
Read more here.

I can't verify that the tokens are correct, but I'm sure you know what you're doing @leo 👍


Keep getting login blocked (https://web.facebook.com/checkpoint/block/)

Hi there, I found your tool and I able to use to deleted some data
> Wed 08 Sep 2021 02:54:41 PM +08
robbi@debian: pts/1: /home/robbi/RM-RF
└─ $ ./deleter-linux --rateLimit 5000
Waiting 5000 ms before search and delete requests.
Logged in with user: XX XX (profile ID: XXXXXXX)
? Which years 2021
? Which months Jan
?    Elements found:       200
Deleting elements from 2021:
200 / 200 [------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 1 p/s 4m25s
Group Reactions: 1 deleted
Likes and Reactions: 4 deleted
Search History: 195 deleted
Total: 200 deleted

It my trial run and I want to delete by per month.. but when I try for second round, It doesnt work anymore. I keep getting blocked and asked to change password everytime I execute.
I try deleting the cookies and still get same thing.. it has been two day.
> Thu 09 Sep 2021 03:31:04 PM +08
robbi@debian: pts/2: /home/robbi/RM-RF
└─ $ ./deleter-linux --rateLimit 10000
Waiting 10000 ms before search and delete requests.
? Please type your email<EMAIL_ADDRESS>? Please type your password *********************
Attempting Login...
panic: Failed to login

goroutine 1 [running]:
main.newFbLogin(0xc00018aea0, 0xc000182008)
        /Users/marcel/pr/facebook-delete/deleter.go:118 +0xde
main.main()
        /Users/marcel/pr/facebook-delete/deleter.go:522 +0x1f3

I wonder and guesss, it maybe cause by user agent signature by this tool
This is my browser user agent
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

When I use web browser (after change new pass and each time before I exec the tool), I able to use fb. So after 1h-3h, I come back and use the tool.. my account will be blocked and need to change pass again.
Let me know if I need to add more information

I don't know how facebook detects this. For me, it always worked fine. User agent could definitely be something that's related. Maybe we could set a user agent in our client


SEP-10 v3.0 Changes (from the SDF)

SEP-10 3.0
TL;DR
Implement the changes described in the SEP-10 v3.0 PR by November 13th. It adds a check for the correct homeDomain value in the SEP-10 challenge transaction. homeDomain is the domain hosting the SEP-1 stellar.toml containing a WEB_AUTH_ENDPOINT and SIGNING_KEY.
The SEP-10 v3.0 PR is not merged, but the only changes still in discussion relate to phrasing. No more functional changes will be introduced.
Background & Description
Thank you for implementing SEP-10 v2.1, this removed the possibility of unexpected SEP-10 client-anchor incompatibility. Now that Anchors have been given time to update, Wallets can soon expect the Anchors they interact with to have a v2.1 challenge. This means their challenge transactions include the home domain that hosts the SEP-1 stellar.toml that has the WEB_AUTH_ENDPOINT used to obtain the JWT.
The next step is for SDK's to release changes supporting SEP-10 v3.0, which adds the check for the expected homeDomain back to SEP-10. Wallets should upgrade only when their partner anchors have upgraded to v2.1. This should be the case for all anchors by the time your v3.0 change is released.
Deadline
The SDF asks all SDK's to release new versions including SEP-10 v3.0 support by November 13th. On Monday November 16th the SDF will announce to the ecosystem SDK support for SEP-10 v3.0.

@jakeurban @rice2000 @leighmcculloch


Invoking SendAsync with reflection is broken

Hello
i have the following code. it has been working so far including v2.0 beta 5.
i started getting error of ambiguous match found because you have created overloaded method of SendAsync with cancelation token. could you tell me how to fix the following code
var requestInterface = requestType.GetInterface("IAsyncRequest`1");
var sendMethod = mediator.GetType().GetMethod("SendAsync");
var method = sendMethod.MakeGenericMethod(requestInterface.GetGenericArguments());
var task=  (Task)method.Invoke(mediator, new[] {instance});
await task;
return task.GetType().GetProperty("Result").GetValue(task);

a blind (non-tested) hint:
passing the parameters on the GetMethod doesn't do the trick?
var sendMethod = mediator.GetType().GetMethod("SendAsync", typeof(IAsyncRequest<>));

@kappy It doesn't support open generics :cry:
@lcamlibel Since you already have a closed generic type (from GetInterface), try passing requestInterface to the GetMethod call :smile:

I tried both
var sendMethod = mediator.GetType().GetMethod("SendAsync", new [] { requestInterface })

and
var sendMethod = mediator.GetType().GetMethod("SendAsync", new[] { typeof(IAsyncRequest<>) });

both return null.. I think there is some limitation on the generics using reflection.
This worked for me:
        var parameterTypes = new[] {typeof (IAsyncRequest<>)};
        var sendMethod = (from m in mediator.GetType().GetMethods()
            where m.Name == "SendAsync"
            where parameterTypes.SequenceEqual(m.GetParameters().Select(p => p.ParameterType.GetGenericTypeDefinition()))
            select m).SingleOrDefault();

based on Jon Skeet comment on http://stackoverflow.com/a/269992/4634243

thanks guys
On Fri, Aug 7, 2015 at 4:32 AM, Joao Matos Silva<EMAIL_ADDRESS>wrote:

I tried both
var sendMethod = mediator.GetType().GetMethod("SendAsync", new [] { requestInterface })
and
var sendMethod = mediator.GetType().GetMethod("SendAsync", new[] { typeof(IAsyncRequest<>) });
both return null.. I think there is some limitation on the generics using
reflection.
This worked for me:
    var parameterTypes = new[] {typeof (IAsyncRequest<>)};
    var sendMethod = (from m in mediator.GetType().GetMethods()
        where m.Name == "SendAsync"
        where parameterTypes.SequenceEqual(m.GetParameters().Select(p => p.ParameterType.GetGenericTypeDefinition()))
        select m).SingleOrDefault();

based on Jon Skeet comment on http://stackoverflow.com/a/269992/4634243
—
Reply to this email directly or view it on GitHub
https://github.com/jbogard/MediatR/issues/48#issuecomment-128641269.


How to turn off animation in ParallaxLayer?

Hi! I'd like to turn off the animation of some ParallayLayer. How to achieve this? If you gave me some instructions I'd be happy to create a PR too. Lots of thanks.
Update:
What I have tried is to add an extra prop to the ParallayLayer called config and passed something like: { tension: 0, friction: 0, precision: 0, delay: 0, duration: 0 }.
This has made the layer fixed but is a bit glitchy...

could you try duration: 0.000001 ? i believe that if duration is falsy it will take spring friction/tension instead. I probably have to check against it being undefined though to support duration: 0


Current code not working

After running git pull on my local copy (updating it with the code on GitHub) it doesn't run anymore. I'm looking into want is wrong and hopefully will start a PR soon.
Just in case your curious, this is the error.

{'user_theme': 'choco', 'user_name': 'CoolScratcher123', 'pinned_subforums': []}
<IP_ADDRESS> - - [27/Jul/2023 08:16:18] "GET / HTTP/1.1" 500 -
Traceback (most recent call last):
File "/usr/lib/python3.11/site-packages/flask/app.py", line 2552, in call
return self.wsgi_app(environ, start_response)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/app.py", line 2532, in wsgi_app
response = self.handle_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/app.py", line 2529, in wsgi_app
response = self.full_dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/app.py", line 1825, in full_dispatch_request
rv = self.handle_user_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/app.py", line 1823, in full_dispatch_request
rv = self.dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/app.py", line 1799, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/sky/Documents/Code/Snazzle/main.py", line 136, in index
return stream_template('index.html')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/templating.py", line 197, in stream_template
return _stream(app, template, context)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/flask/templating.py", line 165, in _stream
app.update_template_context(context)
File "/usr/lib/python3.11/site-packages/flask/app.py", line 997, in update_template_context
context.update(func())
^^^^^^^
File "/home/sky/Documents/Code/Snazzle/main.py", line 121, in context
theme=user_data['theme'],

the bottom issue can be fixed by changing it to theme=user_data['theme], try that first

Lol, I was just typing that was the issue. Yeah. That did fix it. I'm now going to try and fix a issue where the themes won't change. I think this is because of the big forum changes.

fixed issue in latest commit

That commit doesn't fix it. It seems like the user_theme thing is never being changed in the first place.

oh it fixed the issue with the errors, ima make a new issue for the actual themes

Oh okay. That did fix that issue.

That commit doesn't fix it. It seems like the user_theme thing is never being changed in the first place.

It gets changed when you GET /settings?theme=<theme>


Issue connecting to server due to buffer

When trying to connect to a Minecraft server hosted on a local network, I get the following error:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/ext/tasks/__init__.py", line 239, in _loop
    await self.coro(*args, **kwargs)
  File "/Users/calebpierce/Documents/Documents/Python Projects/pythonProject/led.py", line 169, in player_count
    await rcon_client.connect()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiomcrcon/client.py", line 58, in connect
    await self._send_msg(MessageType.LOGIN, self.password)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiomcrcon/client.py", line 79, in _send_msg
    in_len = struct.unpack("<i", (await self._reader.read(4)))[0]
struct.error: unpack requires a buffer of 4 bytes

The port is correct, the hostname is correct and there is nothing wrong with password.
This is using the code provided in the example:
rcon_client = Client(host_name, rcon_port, rcon_password)
try:
    await rcon_client.connect()
except aiomcrcon.RCONConnectionError:
    print("An error occurred whilst connecting to the server...")
    return
except aiomcrcon.IncorrectPasswordError:
    print("The provided password was incorrect...")
    return

try:
    response = await rcon_client.send_cmd('/stop')
except aiomcrcon.ClientNotConnectedError:
    print("The client was not connected to the server for some reason?")
    return

print(response)

await rcon_client.close()

I have released v3.2.1 which should address this, please let me know if it does or if you have any future issues

Closing due to lack of response


Error when running roslaunch kimera_semantics_ros kimera_semantics.launch play_bag:=true

Hi,
When I run roslaunch kimera_semantics_ros kimera_semantics.launch play_bag:=true I get these errors:

And the result in rviz is like this:

Can you try this #61 and see if it solves the issue?

Great! It solved the issue. Thank you!


[Ready for Review]Feature Google Drive oauth

 Purpose
Currently latest version of OSF has a generic code written for all the addons. But Addons are still using the legacy code. This PR updates Google Drive Addon to use this code.
 Changes
No changes towards Front-end. Back-end gets rid of specific node & user configuration files for Google Drive.
 Side Effects
Any dependencies on node/user configurations files specific to google drive might be affected.

Let's make sure this in aligned with any work on OAuth + add-ons done by @samchrisinger -- Thanks!

Other than the two new comments, and the one left over (delete googledrive_node_settings.mako), this looks good to me.

@kushG Is this bug: https://trello.com/c/qdTeWCLQ/49-google-drive-folderpicker-shows-spaces-as-20-and-slashes-as-2 addressed in this PR?

Yes @sloria this is addressed in this PR

@lbanner - This PR looks like it's ready to be merged, and is at moderate risk of becoming out of date as changes to the Google Drive addon in particular will impact it.
Could you provide some direction as to when this should be merged into develop and deployed to staging?

QA impact here? If not significant, then @sloria .... this, like others being brought up-to-date, should merge when you make call on go-ahead. We have 0.38.0 upcoming soon, then 0.39.0. TY

QA will need to test the Google Drive addon functionality fairly thoroughly. If they're already going through those cards, then this is a gimme. Otherwise, I'd say it's a matter of having the capacity to get it through QA.
Code rot here should be minimal, so long as nothing else in the Google Drive is changed before we merge this in. If things are changed, then the merge could easily get complex.

Who is supporting this PR now? Whoever is assigned to this--please bring this up to date with develop. @lbanner @GaryKriebel Once that is done, could you do a functional review of this?

OK @sloria ... @lyndsysimon can you undertake this as noted above ^^ ? Thanks.

Ping @lbanner and @GaryKriebel for processing of this PR. Should we close or have someone pick this up?

I would think we would want someone to pick this up.   Still unaddressed issues, yes?

In testing a Google Drive fix, I ran across the issue documented in https://github.com/CenterForOpenScience/osf.io/issues/3336. I think that this issue needs to be resolved in some way, if not by way of this specific PR @GaryKriebel @sloria

Still the case @sloria that this PR brings GD Oauth up-to-date with other add-ons? Or has other add-on refactors (i.e. Sam's in user settings) made this obsolete? And/or will Saman's work in Project Settings make this obsolete?

Closing in favor of https://github.com/CenterForOpenScience/osf.io/pull/4261.