columnflow setup for slurm cluster

Dear Columnflow Developers,
I am trying to run the hh2bbtautau analysis using a slurm scheduler that connects to a cluster at my institute.  When running tasks with the --workflow slurm parameter set, I run into this error: sbatch: error: invalid partition specified: cms-uhh. The corresponding job script contains the following line causing this:
#SBATCH --partition=cms-uhh

I cannot find where this parameter is set in columnflow. This partition is clearly uhh-specific and I'd have to change it but I cannot find where. Any pointer would be appreciated.

Thanks for raising this issue @JohanWulff ! The remote workflows are managed by law, so I'm tagging @riga as well. Have you checked your law installation as well when you looked for the uhh specific line?

Ah very good! The code actually looks like you can overwrite this by setting the appropiate environment variables, see https://github.com/columnflow/columnflow/blob/c8516a5cccf23475830e998165ce7a478f35f2ef/setup.sh#L326-L328. The one you are after would be CF_SLURM_PARTITION.
You can add this to your shell script in .setups/YOURSETUPNAME.sh so it will always be source automatically when you source your analysis setup script. Can you try this?

thanks @pkausw -- the overriding of the variable works in principle. I'm stuck with a slurm-related submit error but that doesn't have anything to do with columnflow anymore. Looking at the default of cf_slurm_flavor which is maxwell, I was also under the impression I'd have to change this since I obv. don't have access to maxwell from my institute. Changing that causes law to complain though, saying that my choice of cf_slurm_flavor is not a valid choice from {maxwell}. Is this desired? This happens because the possible choices for this parameter are defined in columnflow/columnflow/tasks/framework/remote.py as: ("maxwell")

Hm, that is indeed a shame :/ What happens if you add your choice of slurm flavor to the list? I'm not entirely sure how law will react to this of course, but might be worth trying nonetheless

Hi @JohanWulff , are there any updated regarding this? Were you able to resolve the issue?
If yes, we might want to think about remove the choices for this particular parameter or at least ammend the list of supported options. It would be very interesting what you added to the choices to move on with this!

Not yet sorry. I'll try to understand how the submission is handled here at our scheduler to be able to test it properly and close this issue soon.

Hi @JohanWulff , it's been a while - any updates regarding this issue?

Hi @pkausw
sorry for taking so long on this.. i wasn't really working on this the past weeks. What makes it hard for me to see if this works in principle is the fact that i cannot get the slurm submission via columnflow to work but it seems like just passing a different CF_SLURM_PARTITION doesn't do it.
Feel free to close this issue because at this point it's about understanding how the submission at our local cluster works more than anything.

Hi @pkausw and all,
Reopening this issue:
I was trying to use slurm in my institute cluster too, and unfortunately, it is not working. Can you or anyone please let me know what are the things that one should modify in order to use slurm? The problem I am getting is the following:
ERROR: luigi-interface - Luigi unexpected framework error while scheduling cf.SelectEvents(effective_workflow=slurm, branch=-1, analysis=httcp.config.analysis_httcp.analysis_httcp, version=debug, config=run3_2022_preEE_nano_cp_tau_v12_limited, shift=nominal, local_shift=nominal, dataset=dy_lep_m50_madgraph, calibrators=main, selector=main, workflow=slurm)
Traceback (most recent call last):
  File "/opt/cms/ui5_data1/gsaha/data/software/venvs/cf_dev_9b04c75c/lib/python3.9/site-packages/luigi/worker.py", line 806, in add
    for next in self._add(item, is_complete):
  File "/opt/cms/ui5_data1/gsaha/data/software/venvs/cf_dev_9b04c75c/lib/python3.9/site-packages/luigi/worker.py", line 918, in _add
    resources=task.process_resources(),
  File "/home/gsaha/Work/ColumnflowAnalyses/CPinHToTauTau/modules/columnflow/modules/law/law/workflow/remote.py", line 1561, in process_resources
    resources = self.workflow_proxy.process_resources()
  File "/home/gsaha/Work/ColumnflowAnalyses/CPinHToTauTau/modules/columnflow/modules/law/law/workflow/remote.py", line 544, in process_resources
    get_job_resources = self._get_task_attribute("job_resources")
  File "/home/gsaha/Work/ColumnflowAnalyses/CPinHToTauTau/modules/columnflow/modules/law/law/workflow/base.py", line 101, in _get_task_attribute
    raise AttributeError("'{!r}' object has none of the requested attribute(s) {}".format(
AttributeError: 'SlurmWorkflowProxy(task=cf.SelectEvents_httcp_config_ana__1__2c58004c15)' object has none of the requested attribute(s) slurm_job_resources
INFO: luigi-interface - Worker Worker(salt=8313690224, workers=1, host=sbgui5.in2p3.fr, username=gsaha, pid=493053) was stopped. Shutting down Keep-Alive thread
ERROR: luigi-interface - Uncaught exception in luigi

Any suggestion would be very helpful
Thank you very much
Best,
Gourab

Hi again,
I have added a hook like HTCondor in law/contrib/slurm/workflow.py, and this error is gone :)
However, a different issue is there now, which is related to sbatch: error: Batch job submission failed: Invalid account or account/partition combination specified
I have already changed the partition name, but there are multiple partition, and I do not want to specify any name there. Is it possible?
But, I think I have to change this default maxwell flavor as well. Is there any possibility that law or columnflow can choose that automatically?
Thanks :)

Hi @gsaha009 ,
glad to hear that you were able to make progress with this. Regarding the partition: Looking at the corresponding law implementation, it should be enough to simply set the partition to None (either via the law config or with a more manual implementation, e.g. in the __init__ function).
Regarding automated resolution of the flavor: This is a good proposition. This mechanism for e.g. htcondor works via a naming scheme of the hosts that use a specific flavor. So it would require additional knowledge about your cluster that we don't have - but we're happy to work with you on a PR to implement this. In the meanwhile, we recommend to define the flavor in the law.cfg file.
Cheers,
Philip

Hi @pkausw
I have found the partition name I am using in our cluster, and this problem is fixed now. But, there is new problem now.
I can send the jobs to our slurm cluster now, but because of the following reason, the jobs are getting failed.
-- setup -------------------------------------------------------------------------------------------

-- bootstrap file
run bootstrap file 'remote_bootstrap_b4f052643c.sh'

source repository setup ...
the CPinHToTauTau analysis was already succesfully setup
re-running the setup requires a new shell
setup failed with code 1 # HERE IT IS
bootstrap file failed (exit code 1), stop job

-- stageout ----------------------------------------------------------------------------------------

-- stageout file
stageout file empty, skip

I see the source setup lines in the bootstrap file twice.
The job was failed at this level before showing remote_bootstrap_b4f052643c.sh: line 147: aklog: command not found
It was written optional, so I commented that line, and the error message went away, and even if I comment out the next one, the same error persists.
Let me know if you have any idea.
Thanks again
Gourab

Hi @gsaha009 ,
this issue arises because some clusters are set up such that they forward your local environment variables to remote jobs. When you run source setup.sh YOUR_SETUP, we create a local variable ${YOUR_ANALYSIS_SHORTHAND}_SETUP to denote whether the setup has already been run successfully before. It seems like your cluster is setup such that this flag is forwarded, which is why your remote job thinks that it's already setup - which is probably not exactly true.
There are two ways to fix this behavior:

Disable the forwarding of your (custom) environment variables if possible. This would be the recommended way to fix the behavior since we also manipulate some (python) path environment variables, and doing so multiple times can have unforseen effects.
Add the cf_pre_setup_command to the [analysis] section of your law config like this

[analysis]
# define some custom commands before the remote job calls `source setup.sh YOUR_SETUP_NAME`.
# note that you need to replace `{YOUR_ANALYSIS_SHORTHAND}` with your analysis short hand
cf_pre_setup_command: "export {YOUR_ANALYSIS_SHORTHAND}_SETUP=0;"

Either of these should do the trick, let us know if you have issues remaining.
Cheers,
Philip


Fix javadoc error in Context

As per @tomhillgreyridge's comment in #1766:

This seems fairly straightforward, but I can't find any mention of ASYNC_EXECUTOR_KEY in the GitHub repository other than that location. Is it defined elsewhere?

@mjh316 thank you! This key has actually been deleted, it's an outdated reference to how things worked in Javalin 4.

Gotcha - so, for the two sentences that mention it, should I delete the part about ASYNC_EXECUTOR_KEY?

Yes, it's not currently possible to configure this, so just leave that part out :)


⚠ SkipTheTrailers has degraded performance

In 691bb23, SkipTheTrailers ($STT) experienced degraded performance:

HTTP code: 200
Response time: 4908 ms

Resolved: SkipTheTrailers performance has improved in 63754ad.


Fix CVE-2021-28092

https://nvd.nist.gov/vuln/detail/CVE-2021-28092

Thank you for the contribution.
The packages in the Angular CLI repo are automatically updated on a daily basis by renovate.
The Angular CLI also disables CSS svgo optimizations in code which allows the CLI to avoid this vulnerability.


Fix bug with getting services on compile time

Fixes https://github.com/borNfreee/tactician-domain-events-bundle/issues/11.

Thank you for creating this PR. I can't reproduce this issue with Symfony 3.4.12 and the latest tag of this bundle.
Do you have a public repo with reproducible error? Or what versions do you use?

The main requirement to reproduce this bug is having a dependency on Symfony Serializer in one of event subscribers. Also:

it should be a subscriber and not listener (since only subscribers are instantiated on compiler pass);
dependency may be "indirect" - that was my case: my subscriber depended on a service, which depended on Serializer.
Unfortunately I don't have a public issue with a demonstration now.
A quick way to check that would be just calling$container->get('serializer') in the compiler pass itself (I used this to check if it is the real reason).

Also getting services from container during compiler pass is a bad practice as stated here: https://symfony.com/doc/current/service_container/definitions.html#constructor-arguments.
It may definitely work sometimes... but I'd prefer not to rely on it :)


Replace assignments in invariants

Closes #1663. As discussed in #1663, the model checker fails when an invariant contains assignments, e.g., UNCHANGED x. The bugfix is very simple: All assignments x' := e are replaced back to x' = e in the invariant candidates.
Instead of implementing a yet another class similar to Prime and Deprime, I have refactored ReplaceFixed to accept a partial function, which produces a replacement, if the function is defined on its argument. To disambiguate three versions of apply, I have renamed them to whenEqualsTo, whenMatches, and withFun. This refactoring touched a lot of files, but the changes are syntactic.

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[x] Documentation added for any new functionality
[x] Entry added to UNRELEASED.md for any new functionality

Codecov Report

Merging #1664 (919e659) into unstable (df647a9) will increase coverage by 0.02%.
The diff coverage is 82.14%.

@@             Coverage Diff              @@
##           unstable    #1664      +/-   ##
============================================
+ Coverage     74.96%   74.99%   +0.02%
============================================
  Files           358      356       -2
  Lines         11612    11597      -15
  Branches        541      552      +11
============================================
- Hits           8705     8697       -8
+ Misses         2907     2900       -7

Impacted Files
Coverage Δ

...lache/tla/assignments/passes/PrimingPassImpl.scala
0.00% <0.00%> (ø)

...tla/bmcmt/passes/ReTLAToVMTTranspilePassImpl.scala
0.00% <0.00%> (ø)

.../at/forsyte/apalache/tla/imp/OpDefTranslator.scala
100.00% <ø> (ø)

.../scala/at/forsyte/apalache/tla/pp/Normalizer.scala
76.59% <0.00%> (ø)

...la/at/forsyte/apalache/tla/bmcmt/VCGenerator.scala
69.09% <80.00%> (-0.73%)
:arrow_down:

...t/forsyte/apalache/tla/bmcmt/SeqModelChecker.scala
90.56% <100.00%> (ø)

...tla/bmcmt/trex/ConstrainedTransitionExecutor.scala
97.05% <100.00%> (ø)

.../forsyte/apalache/tla/pp/ConstAndDefRewriter.scala
81.25% <100.00%> (ø)

...ala/at/forsyte/apalache/tla/pp/ExprOptimizer.scala
90.12% <100.00%> (ø)

...ain/scala/at/forsyte/apalache/tla/pp/Inliner.scala
92.06% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df647a9...919e659. Read the comment docs.


Incorrect comment in Containers.createIfNotExists()

The content of the comment in the method is the same as that described in Databases.createIfNotExists(), and it does not match the content of Containers.createIfNotExists(), so it was corrected.

Thank you!


Ignore comments that are not following the template

Every comment which is not following the following template should be ignored:
**[Título](URL)**
Rápida descrição
*Categoria*

Today we have a lot of unnecessary, because these items are categorized as "Outros".

Fixed in PR #27
If not following template, in the weekly.js (with applyMarkdown function) converts this.
With this, resolves Outline error (another issue) and prepare to copy in the Header Markdown option.
All in one! =)


Ensure that error messages are descriptive

Error messages should be as descriptive as the error messages in the JavaScript SDK: https://github.com/momentohq/client-sdk-javascript/blob/main/packages/core/src/errors/errors.ts

I haven't looked over the code for the errors in the Rust SDK yet but I would take this description a step further and say that we should try to make sure that the errors are modeled as closely as possible to the ones in the other SDKs. So we should make sure the list of error types in the enum / class hierarchy matches, make sure the messages are consistent, make sure we have properties for the errorCode / innerError, etc.


add VolumeGroupSnapshotClass for CephFS and RBD

Testing creation of VolumeGroupSnapshotClass and related functionalities:

CSI-drivers require VolumeGroupSnapshotClass for VolumeGroupSnapshot creation.

NAME                                             DRIVER                                  DELETIONPOLICY   AGE
ocs-storagecluster-cephfsplugin-groupsnapclass   openshift-storage.cephfs.csi.ceph.com   Delete           50m
ocs-storagecluster-rbdplugin-groupsnapclass      openshift-storage.rbd.csi.ceph.com      Delete           50m

Description of ocs-storagecluster-cephfsplugin-groupsnapclass:

Name:             ocs-storagecluster-cephfsplugin-groupsnapclass
Namespace:
Labels:           <none>
Annotations:      <none>
API Version:      groupsnapshot.storage.k8s.io/v1alpha1
Deletion Policy:  Delete
Driver:           openshift-storage.cephfs.csi.ceph.com
Kind:             VolumeGroupSnapshotClass
Metadata:
  Creation Timestamp:  2024-10-23T08:18:54Z
  Generation:          1
  Resource Version:    77802
  UID:                 bd8437f3-4c7c-4307-9826-14d026ce343a
Parameters:
  Cluster ID:                                             openshift-storage
  csi.storage.k8s.io/group-snapshotter-secret-name:       rook-csi-cephfs-provisioner
  csi.storage.k8s.io/group-snapshotter-secret-namespace:  openshift-storage
  Fs Name:                                                ocs-storagecluster-cephfilesystem
Events:                                                   <none>

On creating VolumeGroupSnapshot:

NAME                     READYTOUSE   VOLUMEGROUPSNAPSHOTCLASS                         VOLUMEGROUPSNAPSHOTCONTENT                              CREATIONTIME   AGE
cephfs-groupsnapshot01   true         ocs-storagecluster-cephfsplugin-groupsnapclass   groupsnapcontent-e5a91abd-52ae-4dac-a6d2-6ad1a3f4f524   7m47s          37m

Restoring CephFS volumegroupsnapshot to a new PVC (cephfs-pvc-01-restore here):

NAME                          STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                  VOLUMEATTRIBUTESCLASS   AGE
cephfs-pvc-01                 Bound    pvc-29d36e86-62bc-4b24-b7e2-359b6a522c6b   1Gi        RWO            ocs-storagecluster-cephfs     <unset>                 56m
cephfs-pvc-01-restore         Bound    pvc-58173f95-bf0c-456d-9636-71e39783a16f   1Gi        RWX            ocs-storagecluster-cephfs     <unset>                 9s

Creating a pod to utilise the new PVC

NAME                   READY   STATUS    RESTARTS   AGE
csi-cephfs-vgsc-test   1/1     Running   0          113s

The API is not available in Beta yet.

See kubernetes-csi/external-snapshotter#1150 for the BETA status PR.

we might need to have a VGSC CRD check as ocs-operator 4.18 needs to run on OCP 4.16 without any problem for EUS to EUS upgrade? @iamniting @Nikhil-Ladha  thoughts?

we might need to have a VGSC CRD check as ocs-operator 4.18 needs to run on OCP 4.16 without any problem for EUS to EUS upgrade? @iamniting @Nikhil-Ladha thoughts?

Yep, as going forward the plan will be updgrade ODF first, it is advisable to have these checks in place for new changes.
We can make use of the availCRD check that have been recently implemented to check for the CRD, before trying to create the SC.

we might need to have a VGSC CRD check as ocs-operator 4.18 needs to run on OCP 4.16 without any problem for EUS to EUS upgrade? @iamniting @Nikhil-Ladha thoughts?

Yep, as going forward the plan will be updgrade ODF first, it is advisable to have these checks in place for new changes. We can make use of the availCRD check that have been recently implemented to check for the CRD, before trying to create the SC.

I agree we should have such checks, But let's not use availCrds If we are not watching the resource. Otherwise, our controller may restart. Lets have a plain check.

I have added a plain check for VGSC CRD as well. Please do review it. @Madhu-1 @iamniting @Nikhil-Ladha


Refactor code formatting and improve user interface comments

Description
This PR adds comprehensive documentation for all functions in all 10 Python files within the project. This includes detailed docstrings that describe the purpose, parameters, return values, and any exceptions raised by each function. This effort aims to improve code readability, maintainability, and ease of use for all contributors and users.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots (if appropriate)
Additional Notes
These documentation updates are part of my contribution to the GirlScript Summer of Code (GSSoC). Kindly assign this PR a level 2 and grant me the corresponding points. Thank you!

updated the branch

updated branch

@DiptiSanap I have completed my tasks for this pull request and it is ready for review and merging. Could you please assign the 'gssoc' tag and the appropriate level to it? I propose that it be classified as 'level 3'. Thank you.


feat: Don't  enable login button until and unless correct format of email is entered

fixes #522

Message updated

why is login branch added to fossasia's open event repo? this has been told you many times! Please make sure this never happens again

@dreadpool2 delete that branch too

@simarsingh24 Branch deleted

@dreadpool2 Please use smaller commit messages.
You can use the description to describe what's happening in the PR

@nikit19 Tried to shorten the message as much as possible


Update fstab.yaml

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--{repo}--{owner}.hlx.page/
After: https://--{repo}--{owner}.hlx.page/

this looks like a PR that was opened by mistake.


error with inline SVG in NextJS

🐛 Bug Report

Server Error
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.

To Reproduce
Newly created NextJS project
import Star from "./star.svg"

const Example = () => (
  <div>
    <Star />
 </div>
)

Are you using a turbo pack? If yes, try running the project without it

Yes.
Thank you, I’ll try it later.


Add UART5 to STM32F446Xe SoC

Add uart5 to stm32f446Xe SoC. @erwango Please take a look. It is almost copy & paste from stm32f405 and works / compiles fine for me. Thererfore it should be very simple one.

@MaureenHelm @nashif Please merge


Whisper large v3 turbo support

Any possibility of adding support for https://huggingface.co/openai/whisper-large-v3-turbo

Buzz already supports Turbo models. The "Huggingface" Whisper type in Buzz is running on the transformers engine, that supports the turbo models. To run it on Windows with GPU support you will need to wait for 1.2.0 release or get the latest development version from here https://github.com/chidiwilliams/buzz/actions/workflows/ci.yml?query=branch%3Amain
To see the download link you need to log into the Github.
Then select Huggingface whisper type and in the Huggingface model ID input box search for "openai" or "turbo" or paste "openai/whisper-large-v3-turbo"


Input for the algos

Have we figured out what is the needed input for the algos?

Yes, every algorithm takes in a column of target labels, followed by a column containing a vector of features, which may be indexed by label using ':'.


Package Comparison and Overlap Analysis

Until now, GOKb lacks a tool for package comparison/overlap analysis.
Functionality from LAS:eR could be adopted.

As mentionned by @darupp, a similar functionality needs to be implemented in LAS:eR as well. Since only a very few users can access the LAS:eR issues, progresses documented in the LAS:eR issue will be documented here as well.
To work completely, the LAS:eR issue should be described in short here as well (unfortunately, referencing the LAS:eR issue does not make any sense as it is not accessible by most GOKb users):
For subscription issue entitlements and packages, it is desired to create a view which compares (for the moment) exactly two objects. A side-by-side view of the TIPPs/issue entitlements should be generated which shows the differences between two (subscription) packages.
State of LAS:eR issue as of April 15th: on hold

In LAS:eR, the title comparison function has been implemented by @Moetez16 for a subscription holding; the method created there may be interesting for the GOKb.

I did some work on the comparison logic on branch feature-package-compare already. We may also want a dedicated view for this, and might consider the handling of very big Packages a bit more.


Does not support uploading datastore with PDFs[BUG]

Describe the bug
PromptFlow will throw an error if you point to an azure DataStore that contains structured data (such as PDFs). Instead for structured data, you have to manually upload the files instead of pointing to a DataStore
How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

Go to Data in the AML workspace
Create a new Data connection
Create from Azure Storage
Create a new Datastore
Create the datastore from uploaded PDFs in Azure Blob Storage
Store Path leave as default (/)
An error will be thrown

Expected behavior
A data asset should be able to be created from structured data such as PDFs
Screenshots

hi Anthony, this is an issue related to AzureML studio data asset. Could you please file OCV or raise the question in AzureML internal Teams channel?


install error

When I make in /src, I met error like this:
/home/fanl/eesen/src/netbin/train-ctc.cc:89: undefined reference to eesen::CuDevice::SelectGpuId(std::string)' /home/fanl/eesen/src/netbin/train-ctc.cc:90: undefined reference to eesen::CuDevice::DisableCaching()'
/home/fanl/eesen/src/netbin/train-ctc.cc:174: undefined reference to eesen::CuDevice::PrintProfile()' train-ctc.o: In function eesen::CuDevice::Instantiate()':
/home/fanl/eesen/src/netbin/../gpucompute/cuda-device.h:46: undefined reference to eesen::CuDevice::global_device_' collect2: error: ld returned 1 exit status make[1]: *** [train-ctc] Error 1 make[1]: Leaving directory /home/fanl/eesen/src/netbin'
make: *** [netbin] Error 2
Does anyone have an idea about this

Although it should build either way, I'm wondering if this has to do with how the code was configured;

Are you building with or without CUDA GPU support?
If with, do you have a valid CUDA library installed?
What arguments were given when you ran configure?

Because the particular errors are definitely CUDA related.
The particular install instructions that matter, from https://github.com/srvk/eesen/blob/master/INSTALL are: (and of course, you need to replace '/path/to/cuda_library' with the actual path of YOUR CUDA library installation, for example /usr/local/cuda8.0)

   > cd src
   > ./configure --shared --cudatk-dir=/path/to/cuda_library
   > make depend
   > make

   EESEN can be built without CUDA (for decoding only, for example)
by omitting the cudatk-dir argument and specifying --use-cuda=no

@riebling thanks for reply
actually when I enter ./configure --shared --cudatk-dir=/path/to/cuda_library I got the following. It seems OK with CUDA
Validating presence of ATLAS libs in /usr/lib
Using library /usr/lib/liblapack.so as ATLAS's CLAPACK library.
Using CUDA toolkit /usr/local/cuda (nvcc compiler and runtime libraries)
Static=[false] Speex library not found: You can still build Kaldi without Speex.
Successfully configured for Linux [dynamic libraries] with ATLASLIBS =/usr/lib/liblapack.so /usr/lib/libcblas.so /usr/lib/libatlas.so /usr/lib/libf77blas.so

I'm working on eesen and get the same problem as @fanlamda  when installing.
Have anyone met this problem and known how to get it work?

Not sure if this is an eesen-specific thing. Have you seen other code that shows this error?
In any case, it would be helpful to have more information about what OS you are using, what software is installed, etc - I don't recall anyone else having this problem.

Not sure either; have we tried building against Cuda 9.0 yet? Thus far we've been sticking to 8.0, but 9 is the new default, and may have differences like the missing PrintProfile(0


Build system3

Hi,
This is is version with some minor corrections and the conflict fixed.

Hi Gabriel,
thanks for the contribution. Let me merge it, such that we can continue.
Regards
Frank


Add params keyword case with get method for spec helpers test

This is a 🙋♂ feature or enhancement.

[x] I've added tests (if it's a bug, feature or enhancement)
[ ] ~I've adjusted the documentation (if it's a feature or enhancement)~

This is compatibility behavior then I think no need to document

[x] The test suite passes (run bundle exec rspec to verify this)

Summary
Spec helper method get in rails accepts params keyword value as query parameter.
This PR adds it behavior for compatibility.
Rails test: https://github.com/rails/rails/blob/master/actionpack/test/controller/integration_test.rb#L442
Context
n/a
How to Test
Please see first commit test result. Then check second commit fixes it.
Version Changes
This is behavior changes. Is version up needed ?

@bigwheel do you mind having a look at the merge conflicts?

@bigwheel do you mind having a look at the merge conflicts?

Handled in #522
Actually merged this branch in that branch and resolved conflicts in there. Guessing that's why github didnt detect. This is done. Thanks!

Handled in #522
Actually merged this branch in that branch and resolved conflicts in there. Guessing that's why github didnt detect. This is done. Thanks!


Publish "latest" / "master" or "daily" helm charts to helm chart repository

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Currently only official releases have helm charts published:
istio/gateway [rss]

Recently there was a change that affected both the application, as well as the helm charts ( https://github.com/istio/istio/pull/37947 ).  We can pull/test those changes to the application by updating the docker tag references using the values [image.hub=gcr.io/istio-testing and image.tag=latest.  We cannot simply update the "version" for the helm release to use latest in a similar way and that would be a convenient way to use the latest versions of the helm charts and test these changes before the next major release.
As example, this https://github.com/istio/istio/issues/38217#issuecomment-1086049901 issue/resolution could be mitigated if we had convenient access to latest helm chart
Edit:  Perhaps the frequency of commits is too high and so a "daily" build would be more appropriate..
Describe alternatives you've considered
Currently the only method to get latest helm chart is to clone the istio/istio repo locally, and use a local reference for the helm chart source.  Using local reference for helm chart is not ideal because with the local path reference it's not easily reproducible on colleagues workstations or CI/CD systems.
Affected product area (please put an X in all that apply)
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[X] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

closed as https://github.com/istio/istio/issues/38217#issuecomment-1092094929


Handle Video play as a promise

This PR fixes a bug with the Video component, where play should be handled as a promise.
Fixes #458
How to test

QA checklist

[ ] No errors logged to console.
[ ] Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
[ ] Component is accessible at mobile-size viewport.
[ ] Component is accessible at tablet-size viewport.
[ ] Component is accessible at laptop-size viewport.
[ ] Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

[ ] Chrome, no errors logged to console.
[ ] Firefox, no errors logged to console.
[ ] Safari, no errors logged to console.
[ ] Edge, no errors logged to console.
[ ] Mobile Safari, no errors logged to console.
[ ] Android Chrome, no errors logged to console.

Before merge

[ ] Add entry to CHANGELOG.md to describe changes.
[ ] If updating dependencies or creating a release, run npx browserslist@latest --update-db to update the browser data and commit any changes to package-lock.json.

A little stuck here! I'm having a hard time reproducing the bug to prove that this PR will fix it.

Tried a few more attempts to reproduce, but no luck. I do feel confident that the solution will work based on the guidance from these resources that affirm that .play() returns a promise:

https://developers.google.com/web/updates/2017/06/play-request-was-interrupted#support
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/play


 The system should be able to save and retrieve user data, recognize users with a certain level of accuracy, and provide a user-friendly experience for adding new faces.

Added scripts for capturing face images (face_capture.py), training the model (train_model.py), and recognizing faces (recognize_faces.py).
Integrated a JSON-based system for mapping user IDs to names, allowing easy retrieval of user data during recognition.
Provided a structured directory to store captured images, trained models, and user data.
Ensured the system is easy to set up and run, with detailed instructions and requirements.

Changes proposed in this Pull Request :

1. Added face_capture.py script for capturing face images and saving them with a unique ID.
2. Implemented train_model.py to train an LBPH model using the captured images.
3. Developed recognize_faces.py for real-time face recognition using the trained model.
4. Updated README.md with detailed instructions for setup, training, and usage.
5. Added names.json to store user data for mapping IDs to names.
6. Provided support for storing captured images in the images/ directory and saving the trained model as trainer.yml.
7. Included error handling for scenarios like missing user data or invalid input during image capture.

Nice 1


[ISSUE #2495] Add mongodb connector producer

Fixes #2495.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Hi @mroccyen Currently, the project is separating the Connector and Storage components. You can wait to see the module format of Storage and then modify this portion to become part of the Storage module. This may require modifying the module and package names.  @xwm1992


EAA: add design doc

I have added verdictd's design doc.
https://github.com/alibaba/inclavare-containers/blob/master/verdictd/docs/design/design.md


CICD

It would be great to be able to further toggle Mac tests as:
testscripts tests
projects tests

We currently don't split out these tests at all anywhere. we use testcripts infra to run examples, txt testscripts, and testscript examples.
Did you mean testscripts vs non-tescripts (golang stuff)? (in this yaml we refer to them as project-tests-only vs project-tests-off, we may want to come up with better names)
by default we run both in parallel.


feat(sbb-form-field): add negative appearance

Codecov Report

Merging #1976 (efd7ef5) into master (ab917b0) will decrease coverage by 17.29%.
Report is 1643 commits behind head on master.
The diff coverage is 30.07%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff             @@
##           master    #1976       +/-   ##
===========================================
- Coverage   54.85%   37.56%   -17.29%
===========================================
  Files          49      280      +231
  Lines        1659    10229     +8570
  Branches      406     2227     +1821
===========================================
+ Hits          910     3843     +2933
- Misses        671     6146     +5475
- Partials       78      240      +162

Files Changed
Coverage Δ

...components/sbb-accordion/sbb-accordion.stories.tsx
0.00% <0.00%> (ø)

...ents/sbb-action-group/sbb-action-group.stories.tsx
0.00% <0.00%> (ø)

...onents/sbb-alert-group/sbb-alert-group.stories.tsx
0.00% <0.00%> (ø)

src/components/sbb-alert/sbb-alert.stories.tsx
0.00% <0.00%> (ø)

...onents/sbb-autocomplete/sbb-autocomplete.events.ts
100.00% <ø> (ø)

...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx
0.00% <0.00%> (ø)

...-breadcrumb-group/sbb-breadcrumb-group.stories.tsx
0.00% <0.00%> (ø)

...mponents/sbb-breadcrumb/sbb-breadcrumb.stories.tsx
0.00% <0.00%> (ø)

src/components/sbb-button/sbb-button.stories.tsx
0.00% <0.00%> (ø)

src/components/sbb-calendar/sbb-calendar.events.ts
0.00% <0.00%> (ø)

... and 56 more

... and 230 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Regarding Typescript

I came across this repo after looking around for React Native editors that both renders as well as allows for editing marked up content. My project may have a web version where i intend to use DraftJS so ideally was looking for a DraftJS compatible library for RN if available. While compatibility may not really be a problem, DraftJS seems to be built well so i was primarily looking for uniformity across the web and native platforms. I did try this package and found that it does work well for my limited usecase on the native platform.
Do you have any plans to make this package Typescript ready? My project uses Typescript so did get the expected errors when i attempted using the library.
I can create a PR if you want since i seem to get the basics going locally by introducing the definition file and the relevant entry in package.json

@arunmenon1975 thanks for your interest in this project. You can create a PR with the typescript definition files, we'll take this forward

PR at https://github.com/DaniAkash/react-native-draftjs/pull/14
This is very basic. Please edit as necessary.

Thanks a lot @arunmenon1975 will ensure to add this on the next release.


[Bug]: [Python] BatchElements and ToList website examples are broken

What happened?
https://beam.apache.org/documentation/transforms/python/aggregation/batchelements/
https://beam.apache.org/documentation/transforms/python/aggregation/tolist/
These were introduced by https://github.com/apache/beam/pull/30788
I checked in Beam Playground with print(beam.__version__) and it looks like it's' running 2.56 which is when these examples were added. I'm not sure if maybe there's an extra step somewhere to update some database of examples used for the website?
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[X] Component: Beam examples
[X] Component: Beam playground
[ ] Component: Beam katas
[X] Component: Website
[ ] Component: Infrastructure
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

@damccorm You helped me with the original PR. Any idea what's missing here?

I think I already fixed broken examples here: https://github.com/apache/beam/pull/31647.
I guess there is need to update website

Also came across this issue; to my knowledge, the website is are being updated regularly, most likely additional changes  are necessary

@Amar3tto For example,  fixes in https://github.com/apache/beam/pull/31778 point to currently working examples

Also came across this issue; to my knowledge, the website is are being updated regularly, most likely additional changes are necessary

The website uses beam 2.56.0 which doesn't have transforms with the correct names

I don't think the problem is with the website, it is with the playground itself. If you click through to playground, the same problem exists - https://play.beam.apache.org/?path=SDK_PYTHON_ToList&sdk=python

There was a issue in inline yaml for prod playground deploy. That is fixed and is running 2.59 now

The version has been updated, but the examples are still broken. We are working on it.

Thanks for the update!

Looks like all examples are fixed

Confirmed they look good. Thanks for the fix!!

Thanks all!


Confused about the implementation of figure-5-3 in Blackjack.py

In the 218th line of Blackjack.py
_, reward, trajectory = play(behaviorPolicy, initialState, initialAction)

Here the initialAction is set to be a random action. In the implementation of play function, if initialAction is not None, the policyPlayerFn will not be used. This means that the behaviorPolicy will not work. Does it have any special meaning here?

Ah, the behaviorPolicy will work after the first round.


Issues with convex mesh. assert(maxDotProduct >= decimal(0.0)) fails.

I have been attempting to make a convex mesh shape, both using full faces and triangle faces, with this error occurring with both of them. It occurs when another rigid-body collides with the convex mesh shape. The convex mesh shape's rigid-body is static.
Here is the code:
reactphysics3d::Transform TempTransform(reactphysics3d::Transform(reactphysics3d::Vector3(0.0f,0.0f,0.0f),reactphysics3d::Quaternion(0.0f,0.0f,0.0f,1.0f)));
//reactphysics3d::Transform TempTransform(DFEPhysicsTransform::DFETransformToRPT(*LevelMeshes[i]->MeshTransform));

reactphysics3d::PolygonVertexArray::PolygonFace* PolygonFaces = new reactphysics3d::PolygonVertexArray::PolygonFace[TempPhysicsMesh->GetTriangleCount()];
reactphysics3d::PolygonVertexArray::PolygonFace* Face = PolygonFaces;

for (int i = 0; i < TempPhysicsMesh->GetTriangleCount(); i++)
{
	Face->indexBase = i * 3;
	Face->nbVertices = 3;
	Face++;
}

// FaceVertices contains all the vertices loaded from a .obj file (non-triangulated).
// AltVertexIndices, contains the indices for the mesh (triangulated).

reactphysics3d::PolygonVertexArray* PolygonVertexArray = new reactphysics3d::PolygonVertexArray(TempPhysicsMesh->GetVerticesCount(), &(TempPhysicsMesh->FaceVertices[0]), 3 * sizeof(float), &(TempPhysicsMesh->AltVertexIndices[0]), sizeof(unsigned int), TempPhysicsMesh->GetTriangleCount(), PolygonFaces, reactphysics3d::PolygonVertexArray::VertexDataType::VERTEX_FLOAT_TYPE,reactphysics3d::PolygonVertexArray::IndexDataType::INDEX_INTEGER_TYPE);
reactphysics3d::PolyhedronMesh* PolyhedronMesh = SystemGlobalVars->GlobalPhysicsCommon->createPolyhedronMesh(PolygonVertexArray);
TempPhysicsMesh->SetupPhysicsMesh(TempTransform,RPCS_ConvexMeshShape,DFECollisionShapeParams::SetConvexMeshShapeData(PolyhedronMesh, DFEPhysicsTransform::GlmVec3ToVector3(std::get<glm::vec3>(ConvU::DecodeVector(6, 3, TempEntityData[j].second)))), TempDataItems[3].DecodeInt(), DFEPOCM_ALL, SystemGlobalVars->GlobalPhysicsWorld, SystemGlobalVars->GlobalPhysicsCommon);

I have also tried using pre-triangulated .obj files, but get the same result. I use Blender to export models.
These vertices and indices work perfectly with the concave shape, so I do not understand what is going wrong.
Here is the code for the concave mesh.

reactphysics3d::Transform TempTransform(DFEPhysicsTransform::DFETransformToRPT(*LevelMeshes[i]->MeshTransform));

for (int i = 0, Counter = 0; i < TempPhysicsMesh->FaceVertices.size(); i++)
{
	if (Counter == 3)
	{
		Counter = 0;
	}
	TempPhysicsMesh->FaceVertices[i] -= TempPhysicsMesh->GetFinalWorldPos()[Counter];
	Counter++;
} // Simply converts the vertices from world space to local space. I have found that doing this with the convex mesh shape, means that it won't be in the correct position.

//reactphysics3d::TriangleVertexArray* triangleArray = new reactphysics3d::TriangleVertexArray(TempPhysicsMesh->GetVerticesCount(),&(TempPhysicsMesh->Vertices[0]),5 * sizeof(float), &(TempPhysicsMesh->VertexNormals[0]),3 * sizeof(float),TempPhysicsMesh->GetTriangleCount(), &(TempPhysicsMesh->Indices[0]),3 * sizeof(int), reactphysics3d::TriangleVertexArray::VertexDataType::VERTEX_FLOAT_TYPE, reactphysics3d::TriangleVertexArray::NormalDataType::NORMAL_FLOAT_TYPE, reactphysics3d::TriangleVertexArray::IndexDataType::INDEX_INTEGER_TYPE);
reactphysics3d::TriangleVertexArray* triangleArray = new reactphysics3d::TriangleVertexArray(TempPhysicsMesh->GetVerticesCount(), &(TempPhysicsMesh->FaceVertices[0]), 3 * sizeof(float), TempPhysicsMesh->GetTriangleCount(), &(TempPhysicsMesh->AltVertexIndices[0]), 3 * sizeof(unsigned int), reactphysics3d::TriangleVertexArray::VertexDataType::VERTEX_FLOAT_TYPE, reactphysics3d::TriangleVertexArray::IndexDataType::INDEX_INTEGER_TYPE);
reactphysics3d::TriangleMesh* triangleMesh = SystemGlobalVars->GlobalPhysicsCommon->createTriangleMesh();
triangleMesh->addSubpart(triangleArray);

TempPhysicsMesh->SetupPhysicsMesh(TempTransform, RPCS_ConcaveMeshShape, DFECollisionShapeParams::SetConcaveMeshShapeData(triangleMesh, DFEPhysicsTransform::GlmVec3ToVector3(std::get<glm::vec3>(ConvU::DecodeVector(6, 3, TempEntityData[j].second)))), TempDataItems[3].DecodeInt(), DFEPOCM_ALL, SystemGlobalVars->GlobalPhysicsWorld, SystemGlobalVars->GlobalPhysicsCommon);

I have made some modifications to the library, however, these are all related to user data, and not anything else. I do use an event listener, but I have also tried disabling that and it still doesn't work. All other collision shapes work perfectly though, and I have enjoyed using the library with my game engine.
Thanks for your help.
The algorithm I use to get the triangulated indices:
for (int i = 0,IndexOffset = 0; i < FaceSizes.size(); i++)
{ // FaceSizes contains the sizes of each face of the mesh.
 // The VertexIndices are the ones directly from the .obj file, so they are adjusted to be zero based.
	for (int j = 0; j < (FaceSizes[i] - 2); j++)
	{
		AltVertexIndices.push_back((VertexIndices[IndexOffset]) - 1);
		AltVertexIndices.push_back((VertexIndices[IndexOffset + 1 + j]) - 1);
		AltVertexIndices.push_back((VertexIndices[IndexOffset + 2 + j]) - 1);
	}
	IndexOffset += FaceSizes[i];
}

The vertices of the cube:
-10.502, -1, 1,
-10.502, 1, 1,
-10.502, -1, -1,
-10.502, 1, -1,
-8.50205, -1, 1,
-8.50205, 1, 1,
-8.50205, -1, -1,
-8.50205, 1, -1,
The indices of the cube:
1, 2, 0,
3, 6, 2,
7, 4, 6,
5, 0, 4,
6, 0, 2,
3, 5, 7,
1, 3, 2,
3, 7, 6,
Image of what occures:

When the disabling the assertion, and using whole faces rather than triangulated ones, the collision seems to work perfectly.

Thanks for taking the time to report this.
Can I ask you to compile the ReactPhysics3D library in Debug mode and post here a complete stack trace when the assert occurs ?

Unfortunately I can no longer reproduce the error; the assertion no longer fails. If it does fail again though, I will make sure to post the complete stack trace here.

Ok thanks !

I have been attempting to make a convex mesh shape, both using full faces and triangle faces, with this error occurring with both of them. It occurs when another rigid-body collides with the convex mesh shape. The convex mesh shape's rigid-body is static.

The asssertion you mention can happen for several reasons, the dot product of the vectors:

is zero if the vectors are perpendicular, or if one of the vectors or both of them are zero.
is negative if the angle between the vectors is obtuse (90, 180)

are you sure your vectors are not below these conditions?, if so, the assertion is expected to throw.

I think the issue was due to the vertex normal's being calculated incorrectly.
I know with the concave mesh shape, that I have to specify my own vertex normal's during creation, otherwise a different assertion fails (I think is was due to an angle being above or below a threshold).
With my own vertex normal's however, the concave mesh shape works perfectly; even thought at lower update rates, the rigid bodies do fall through it sometimes. It is complex terrain though, which it is not meant to be used for.
When it comes to the convex mesh shape, I passed in different vertices and indices at creation, which were in a slightly different order, and it worked fine. I don't know if the library expects them to be in a specific way; they were set up so the faces would be on the outside.

When it comes to the convex mesh shape, I passed in different vertices and indices at creation, which were in a slightly different order, and it worked fine. I don't know if the library expects them to be in a specific way; they were set up so the faces would be on the outside.

You can find some information here in the user manual that explains how to create a ConvexMeshShape.
Can I close this issue or is there still something wrong ?

Indeed. There is no longer any issues. Thank you for your help.

You are welcome.


ILAMB Benchmark / CMIP6 over Australia Region only

Once we have #24 done, it would be good to have the same thing run over Australia only.

Would be good to test Australian datasets on that one:
https://geonetwork.nci.org.au/geonetwork/srv/eng/catalog.search#/metadata/f6087_5319_9836_7368
Available on gdata:
/g/data/zv2/agcd/v2


fwupd: drop removed dell option

Description of changes
cc @vcunat
follow up to #259376
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I verified it fixes the build and it seems safe enough.
However I suspect that more related cleanups could be done later, e.g. probably removal of the smbios dependency, at a glance from https://github.com/fwupd/fwupd/commit/c01f7adfb3db56bcbe517eda8820c20480d1f2f1


Animated flower

Description
a flower made using html , css .
Screenshots
No response
Additional information
No response

@AyushSingh22 please assign


Display list of aliases

I've tested this one out after merging Kabir's alias parser support #177 and Joycelyn's set alias #176.
After reviewing this, the other two prs can be closed and merge this instead
close #175

Coverage decreased (-9.03%) to 70.712% when pulling 2a9648b68174613d05a905806947421f96c170d8 on display-list-of-aliases into 8d18122022b41dde8470e28db9e40c7d14f72de1 on master.

Merging with decreased coverage


OSD-26937: Removing Pete Brown from reviewers

Closes OSD-26937

/lgtm
/approve

/retest

/retest

/hold
would like to just kill this repo, we do not use it, see rbac-permissions-operator
let's get rid of this thing and stop maintaining it.


updateItem with undefined quantity resets quantity to 1

Looks like either this was never working or maybe Shopify recently changed how the /change endpoint works and it now requires quantity to be passed?
If you try calling:
CartJS.updateItem(1,undefined);
when you have more than one item in the first line item it will reset the quantity to 1.  Based on the documentation I would expect this to leave the quantity unchanged.

Hi @jamespeerless - can you point to where the documentation indicates expected behaviour for an undefined call? In any case, this may not be an issue with Cart.js but with the Shopify API.

Yeah I assume it's a change with the Shopify API but here's the snippet from updateItem documentation I was following:
Setting quantity to 0 will remove the item from the cart. Leaving quantity as undefined will leave the quantity of the item as-is.

Can you check the actual Ajax API call that's being made when you trigger updateItem? If quantity is undefined there, it's definitely a problem on Shopify's end.


Change Event.time => Event.start_datetime (required) and Event.end_datetime (optional)

Instead of just Event.time, can we put Event.start_datetime and Event.end_datetime into the actual schema for Event (with end_datetime Optional), rather than relegating end to some arbitrary field in the metadata?
A lot of labeling functions will depend on having an end_datetime, so it seems a bit confusing to hide this in metadata.

I would be opposed mainly because this is a significant increase in complexity of the schema (two timestamps vs one) that is rarely used.
End timestamps are only really valid for visits and prescriptions, and even then they are primarily just for labeling.
I think end timestamps in the metadata makes sense given the context with which they are used.


Investigate moving from yarn back to npm

When we first moved to Yarn, it was mostly a performance move. Nowadays npm has mostly caught up and Yarn went a completely different direction. We're sitting on Yarn v1, mostly abandoned by the project leads. We should investigate the possibility of moving back to npm.

I'm currently hitting this on Windows and it's blocking me: https://stackoverflow.com/questions/66893199/hanging-stuck-reifyprettier-timing-reifynodenode-modules-nrwl-workspace-comp

Glad to see this change! The yarn v1 was rarely used now, back to NPM is good for new contributors and the health of the vscode's future.
And I'm inquisitive if there is a play to drop the gulp? The latest version of gulp is v4.0.2
on May 7, 2019. It's abandoned and it needs to write many build scripts, which is inconvenient compare to modern bundlers.

Hey @joaomoreno how is this going?
As a contributor its annoying having to install yarn v1 just for this project, when most other repo's don't need it.
Is that npm bug still a problem? How can we repoduce it to see if its still causing the issue?

I'm curious to know whether using pnpm has been considered. I've been a pretty happy user of it. The space savings with links is quite good. Some starter info can be found at https://pnpm.io/motivation. Also, sorry if I've already asked this elsewhere. My brain thinks it vivdly remembers having brought this up, but can't remember where or when, and my attempt to search for previous comments of mine mentioning pnpm haven't turned that up.

I'm curious to know whether using pnpm has been considered. I've been a pretty happy user of it. The space savings with links is quite good. Some starter info can be found at https://pnpm.io/motivation. Also, sorry if I've already asked this elsewhere. My brain thinks it vivdly remembers having brought this up, but can't remember where or when, and my attempt to search for previous comments of mine mentioning pnpm haven't turned that up.

Seconded, if work is to be done to migrate should pnpm not be considered?

This milestone we have resumed exploration on this issue, https://github.com/microsoft/vscode/tree/robo/yarn_2_npm tracks this effort and we have our first unreleased insiders build from it 🚀 . There were some breaking changes and/or differences that require documenting as follows,

Peer dependencies
Unlike yarn 1.x, npm starting with v7 installs peer dependencies by default. We have a couple of conflicting peer dependencies that required the use of --legacy-peer-deps flag. If we pursue further down the npm path it would be good to eventually remove this flag so that we can use flags like --prefer-dedupe that reduces duplication in the bundle.
a) xterm and its addons - We rely on beta versions of the @xterm/xterm package while the addons have a peer dependency on stable versions. @Tyriar
b) typescript and ts-node - Same as xterm our workspace relies on dev version of typescript that does not satisfy the peer dependency of ts-node @mjbvz
c) @microsoft/applicationinsights-* and tslib - Telemetry package has peer dependency on tslib: "*" that conflicts with tslib from root. @lramos15

.npmrc
We have 3 different .yarnrc today,
a) .yarnrc - In the project root, that configures Electron related settings for building native node modules of the client
b) remote/.yarnrc - Configures remote server specific Node.js settings
c) build/.yarnrc - Configures build related packages to use system installation of Node.js
We start installation from project root via yarn and using a postinstall script we navigate sub folders like build/, remote, extensions/ to perform module installation in each of them relying on the .yarnrc files described above. With npm we still maintain .npmrc for each of those folders so that a developer can do things like,

> cd remote
> npm ci -> will use the .npmrc from `remote/.npmrc`

However when running npm ci from project root only the configuration from root will take effect, we workaround this by relying on the priority order of npm configurations and setting env variables in the postinstall script for each of those sub directories. Npm has a workspace feature, should check if it can used to improve this installation flow.

Private registry auth
We use custom feed for our product builds and setup authentication with --location=project which yarn 1.x applies to all sub folders even in the postinstall step however npm does not. We can workaround this by generating the auth settings for the global .npmrc configuration.

vsce
vscode-vsce package helps with generating the file list that needs to be used for extension bundling, it relies on the package manager of choice to also go through the dependency tree. When switching from vsce.packageManager.Yarn -> vsce.packageManager.Npm the extension bundle size doubled due to node_modules being included when they were not with yarn. Investigating this a bit more, there seems to be a bug with the vsce package where the dependency logic is different with yarn vs npm specifically the part about checking PackedDependencies. Packed dependencies are dependencies declared in package.json which are also declared as externals in webpack configs. A quick static check confirms there are no external dependencies that requires packing today, so as a workaround I have switched the package manager to use vsce.packageManager.None which results in the same bundle tree with npm as it was with yarn. We should have this addressed in vsce eventually. @jrieken who originally added this support in https://github.com/microsoft/vscode-vsce/pull/282, can you confirm if adding similar support to getNpmDependencies  the way to go forward ?

c) @microsoft/applicationinsights-* and tslib - Telemetry package has peer dependency on tslib: "*" that conflicts with tslib from root. @lramos15
This can be ignored, the package doesn't even really use Tslib except for super old backwards compatibility which does not apply to our case. See internal issue

a) xterm and its addons - We rely on beta versions of the @xterm/xterm package while the addons have a peer dependency on stable versions. @Tyriar

@deepak1556 to fix this would I need to specify the beta version of @xterm/xterm in beta addon releases?

@Tyriar yeah that would help. Just to note, comparator operators on prerelease tags strictly match on the [major, minor, patch] tuple https://docs.npmjs.com/cli/v6/using-npm/semver#prerelease-tags so you might need to declare more ranges on your peer deps depending on how your prereleases satisfy. But looking at the xterm releases this might not be an issue.
^5.4.0-beta : >=5.4.0-beta <6.0.0 only matches beta.x within 5.4.0, 5.4.1-beta.x or 5.5.0-beta.x will not satisfy

@lramos15 thanks I will create a separate issue to track that. Given that issue is open for a while I think we need to contribute to removing that peer dependency if it is of serving no value today in upstream. We cannot ignore it, we can only workaround it by using the --legacy-peer-deps flags which I am doing today. The goal here is to eventually get rid of this flag.

We will need to update packages but should be fixed via https://github.com/microsoft/ApplicationInsights-JS/pull/2397

Rollout Plan
09/05 JST morning - Flip the pipeline to disallow dependency changes from incoming PR
09/05 - 09/06 - Remind team to avoid merging PR that has dependency changes
09/05 EOD PST - Update and run unreleased insiders build from robo/yarn_2_npm branch
09/06 JST morning - Merge PRs in vscode, vscode-distro and vscode-build-tools
09/06 JST morning - Run insiders from main
09/06 JST morning - Send post merge announcement

The xterm peerDependency problem should be fixed with https://github.com/microsoft/vscode/pull/227313


Add support to reset a store

In certain use-cases I want to reset my store to a certain state
example:
const store = makeStore<T>({});

store.set({hello: "world"});

...

store.set({}); // does not modify the store
store.set(Object.keys(store.state).reduce((r,c) => {...r, [c]: undefined}, {})) // actually resets but is cumbersome

idea:
store.set({}, {overwrite: true});

I'd be willing to create a PR if you think this a feature that should exist in statery

Thanks for submitting the issue, and I agree that it would be a good feature to have! For the upcoming 0.6 release, I have started adding options to set (forceNotify in this case), and I'd be happy to change the API for that to take an options object.
If you're willing to tackle that and submit a PR, go ahead! Otherwise I would probably just take care of it some time over the next couple of weeks, as part of the work to push 0.6 out of the door.

Now that I check in the sources, maybe it's better to create a different method.
The interface is Partial<T>, however for an overwrite we should use T.
I still favour the options object - because it makes it more flexible in the future. However my suggestion is probably not working

That's fine. I will think about a reset (analogous to set), or something similar.
As an alternative userland workaround/solution, consider writing a function that returns the desired initial state:
const initialState = (): YourStateType => ({ foo: "bar", count: 0, stuff: undefined })

And then just using that to update the store using the normal set method:
store.set(initialState())

It will not remove properties outside of your type that were added for some reason, of course.


I'm confused about some lines of code in the 'infer_cam.py'

Could you explain why the code need flip operation in the lines 64 through 66? Several papers hava also used this operation.
                       if i % 2 == 1:                             cam = np.flip(cam, axis=-1)                         return cam

I'm confused, too.

That's for test time data augmentation.
Take a look at the dataloader, some images were flipped, it simply flips it back.


GradleV2 fails with JaCoCo codecoverage enabled and multiproject

Task name: GradleV2
Description: Fix wrong usage of readonly property
Documentation changes required: N
Added unit tests: N
Attached related issue: https://github.com/microsoft/azure-pipelines-tasks/issues/14130
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

@gnegnegne thanks for doing this and heads up! I already applied similar fix in https://github.com/microsoft/azure-pipelines-tasks/pull/14137 to common package and going to consume it for Gradle task also.

Let me close this since we already have these changes in another PR,  please feel free to track progress regarding this here.


update actions

@m4sterbunny happy to be overriden on this but think with the md lint it might be good to block the build? I can go through each repo and bring em compliant and long term it'll get to be practice?

Perhaps we give everyone a soft landing and revisit making it fail build in say 6 months?

Hi @m4sterbunny the md lint is working fine, spelling with vale throws a couple of errors that Im not sure of - you able to have a looksee please when you can. This should be good to merge after that I reckon (or with the spelling issues?)


Update for Factorio 0.16

This is  basically a QOL mod for my now. Requirement lolol. Just checking if this project is still worked on?

Yes, please. I tried to modify the info.json (sometimes it works with old mods), but it doesn't work :(

Yes, it will. I don't know if @Anoyomouse is actively working on any mods these days, but when I get home (currently out of town) I should be able to give updating the mod a go. It'll be a good time to take care of the research rebalances that were requested, too.
@olitologie Can you be more specific about what doesn't work? I can do some research into the issues while I'm still traveling, and be more prepared to hit the ground running when I return.

@dgw Ofcourse. I changed the file and folder name from Warehousing v15_0.0.14.zip to Warehousing v16_0.0.14.zip and in the info.json from
"name": "Warehousing v15", "factorio_version": "0.15",
to
"name": "Warehousing v16", "factorio_version": "0.16",
In most cases it works back in the days when I updated from .14 to .15.
The error from log:
 0.617 Error ModManager.cpp:1023: Error while loading entity prototype "warehouse-basic" (container): Key "icon_size" not found in property tree at ROOT.container.warehouse-basic Modifications: Warehousing Mod

Oh, I remember reading something about that property being required in more places now. I'll add icon_size to the list of things that definitely need to be updated, thanks!

Awesome thanks guys.

@dgw I'm not in lua coding but I could fixed the problem by adding 'icon_size = 32,' to the 'entity.lua'
(also change the file path > version in path name) but got a new error:
'''
0.906 Mods to disable:Fehler beim Laden der Mods: Error while loading entity prototype "warehouse-requester" (logistic-container): A requester-type chest with zero request slots makes no sense.
Modifications: Warehousing Mod
'''
Hope it helps, I am in the Factorio API doc now. Maybe I find something helpfull :)

@olitologie Yep, I started prepping a changeset earlier that adds the icon_size to all definitions in entity.lua and item.lua. I'm guessing you haven't run across any item errors yet because of the file loading order (and because Factorio bails out after the first error, I think).
When I get back to my laptop later tonight, I'll go over the logistic warehouse types looking for issues like the one you reported, then maybe put up a test build since I can't test 0.16 right now on the machine I brought along. I want to expedite this process, though, so if you have time around when I'll be back on (approximately 5 hours from now) we might connect on IRC or something to iterate faster.

@olitologie @CoreyJ87 Can one of you test<EMAIL_ADDRESS>when you get a chance and see if I missed anything? I think it's all set for 0.16, but I can't actually try it in a game until next week.

@dgw I tested the basic and large warehouse and technologie. Works pretty well, thank you a lot. I will also test the logistic warehouses, but i have a new savegame and i need a little bit time to grow my base :)

Thanks so much! I was trying to fix this on my own until I ran into the logistic slot problem and hit a wall. Wiki was telling me to use num_logistic_slots instead of logistic_slots_count.

Sounds good enough for me if the test branch works for both of you.
@Anoyomouse, incoming 0.16-compatible release for upload to the mod portal…as soon as I remember what I did to package the last one, haha.

Jsut to close off this properly, the update has been pushed to the mod portal and is now available for all!


Updated Blueprints to Set/Get from 'ui_properties'.

No visual changes, only a change in how certain Blueprint GUI fields set/get their values.
GUI no longer calls APIs for 'bundle' creation/update or 'service_template' tagging.
CFUX-98 - SSUI 4.2: Blueprint API Change
@serenamarie125 , @chriskacerguis , @jeff-phillips-18

@dtaylor113 can you resolve the conflicts?

All conflicts and issues resolved.

@chriskacerguis This did not make it into Euwe branch. Please label euwe/yes or euwe/no, as appropriate.


Add more examples to notebook

Mainly adds a regression task to the Basic_Usage notebook. I moved the "custom callbacks" section to an Advanced_Usage notebook, where we should put all the stuff that involves custom classes etc.
During the task, I discovered a bug in NeuralNetRegressor, which is fixed now.
This addresses phantom issue #77

changed the custom callback
add example on how to access callback parameters
changed optim to optimizer for upcoming change

@ottonemo Please review again.


OCPBUGS-36684: Disable cluster-olm-operator

This is to allow for merging to occur.

/approve

/lgtm


docs/feature: How to deploy

I wanna use cmmc for managing my eks auth but I did not find any information explaining how to deploy it on a kubernetes cluster.
Is there any guide I can follow?
Thanks

In lieu of docs being available.

All of the deployment configuration currently lives in config/.
You can deploy a cmmc in your cluster using kustomize

images:
  name: controller
  newName: cashapp/cmmc
  newTag: v0.0.1

resources:
- config/crd
- config/rbac
- config/manager

@stanistan thanks a lot!
It should be
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: cmmc-system
namePrefix: cmmc-

images:
-  name: controller
    newName: cashapp/cmmc
    newTag: v0.0.1

resources:
- path/to/config/crd
- path/to/config/rbac
- path/to/config/manager

but then works fine!

Added these notes to https://cashapp.github.io/cmmc/usage/


CI Build changes

Description
Adds the project and script changes to allow for daily CI builds
Type of change

Build changes

Platforms tested on

[x] WPF .NET 8
[x] WPF Framework
[x] WinUI
[x] MAUI WinUI
[x] MAUI Android
[ ] MAUI iOS
[ ] MAUI MacCatalyst

Checklist

[x] Self-review of changes
[x] All changes work as expected on all affected platforms
[x] There are no warnings related to changes
[ ] Code is commented and follows .NET conventions and standards
[ ] Codemaid and XAML styler extensions have been run on every changed file
[x] No unrelated changes have been made to any other code or project files
[ ] Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@dotMorten can you cherry-pick the commits specific for this PR into a new branch based off updated main? There are old v.next commits which are not present in our main branch due our PR bringing v.next into main at program increment 3, 2023. Although the files changed look good, I'd prefer to keep our commit history as is.

No need to clean up commit history, everything will be squashed and merge in the end.


why there is no sampler info in reflection information

on the example page i tried a shader with sampler but there is no sampler info in the reflection  information.
here is the shader:
struct VertexOutput {
@builtin(position) Position: vec4,
@location(0) attr_var_UV: vec2
}
@binding(1) @group(1) var color: texture_2d;
@binding(0) @group(1) var tex_sprite: sampler;
@fragment
fn fragment(fragData: VertexOutput) -> @location(0) vec4f {
var _33: vec4 = textureSample(color, tex_sprite, fragData.attr_var_UV);
var _34: f32 = _33.x;
var _41: f32 = _33.y;
var _48: f32 = _33.z;
var _57: vec3 = vec3(pow((_34 + 0.054999999701976776123046875) * 0.947867333889007568359375, 2.400000095367431640625), _41, _48) * _33.w;
return vec4(_57.x, _57.y, _57.z, _33.w);
}
and the reflection info
TIME: 1.2000000476837158ms
Entry Points
fragment: fragment
Inputs
Position: vec4 location: position
attr_var_UV: vec2 location: 0
Uniforms
color: texture_2d
Buffer Size: 0
Bind Group: 1
Bind Index: 1
Members:
I wonder if there should be the sampler info or not?

To provide a public answer to this:

The example is quite simplistic, I figured people are primarily interested in uniform buffer layouts.
The shader you posted does have an error, texture_2d needs to have a sampler type, as in texture_2d.

I updated the example to list textures and samplers. I also have it catch errors and print the error if it fails to parse the shader. In this case it now tells you "Expected '<' for sampler type. Line 6. Found: ';'."

thanks a lot!


split OnApplicationQuit from NetMan into NC and NS

At that point we can probably just remove it and do this:
Application.quitting += Shutdown;


Re-run properly on every PR commit?

The GitHub Action is rerunning on every commit. But the original comment does not change, nor are any new code suggestions made when there are new commits even if they have significant changes. Can we make it so that it will update the comment / properly re-run the review when there are new commits in the PR?

My workflow file:
name: "🕵 PR Agent"
on:
  pull_request:
  issue_comment:
jobs:
  pr_agent_job:
    runs-on: ubuntu-latest
    permissions:
      issues: write
      pull-requests: write
      contents: write
    name: Run PR Agent # On PRs and comments
    steps:
      - name: PR Agent action step
        id: pragent
        uses: Codium-ai/pr-agent@main
        env:
          OPENAI_KEY: ${{ secrets.OPENAI_INTERNAL_API_KEY_CODIUMAI_PR_AGENT }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          PR_CODE_SUGGESTIONS.NUM_CODE_SUGGESTIONS: 5
          PR_REVIEWER.INLINE_CODE_COMMENTS: true
          PR_REVIEWER.ASK_AND_REFLECT: true

Hi @georgeseifada
We tried at the beginning to run PR-Agent review feature after every commit, and it was highly annoying.
It fills your PR discussion page with endless reviews. It can also be expensive - sometimes there are continues commits per PR.
While it is possible to implement it (not supported currently), i personally advise against it.
My recommendation - Just add a comment with \review when you want a fresh look on the PR.
There is also the \review -i feature, that reviews only the incremental changes, since the last review

@mrT23 that makes sense. I'll try the \review for now. Thanks for the quick response!
One suggestion: If you use this GHA for sticky comments, then you can have it just update the same comment :)

Sticky comments is a good suggestion in general, for the review and maybe for other features. we will look into that :-)


Automated cherry pick of #3802: feat(notify): Add interface contacts/users for Notify

Cherry pick of #3802 on release/2.12.
#3802: feat(notify): Add interface contacts/users for Notify

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@780d502). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #3803   +/-   ##
==============================================
  Coverage                ?   6.93%
==============================================
  Files                   ?     500
  Lines                   ?   84343
  Branches                ?       0
==============================================
  Hits                    ?    5846
  Misses                  ?   78003
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.93% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780d502...0218b6c. Read the comment docs.


Another memory error

Hi,
I managed to integrate JIRAlert with jira instance and it is working as expected. However I'm getting the below error:
2018/05/04 13:27:19 http: panic serving <IP_ADDRESS>:41092: runtime error: invalid memory address or nil pointer dereference
goroutine 364 [running]:
net/http.(*conn).serve.func1(0xc4200e2e60)
/usr/lib/go-1.10/src/net/http/server.go:1726 +0xd0
panic(0x837720, 0xb4ac30)
/usr/lib/go-1.10/src/runtime/panic.go:505 +0x229
github.com/free/jiralert.(*Receiver).Notify(0xc42040cde0, 0xc42009acc0, 0xc42040cde0, 0x0, 0x0)
/home/alin/go/src/github.com/free/jiralert/notify.go:56 +0xfc5
main.main.func1(0x9176e0, 0xc420246380, 0xc4201cb000)
/home/alin/go/src/github.com/free/jiralert/cmd/jiralert/main.go:86 +0x386
net/http.HandlerFunc.ServeHTTP(0xc420152f40, 0x9176e0, 0xc420246380, 0xc4201cb000)
/usr/lib/go-1.10/src/net/http/server.go:1947 +0x44
net/http.(*ServeMux).ServeHTTP(0xb5ab80, 0x9176e0, 0xc420246380, 0xc4201cb000)
/usr/lib/go-1.10/src/net/http/server.go:2337 +0x130
net/http.serverHandler.ServeHTTP(0xc4200add40, 0x9176e0, 0xc420246380, 0xc4201cb000)
/usr/lib/go-1.10/src/net/http/server.go:2694 +0xbc
net/http.(*conn).serve(0xc4200e2e60, 0x917c20, 0xc4200bad00)
/usr/lib/go-1.10/src/net/http/server.go:1830 +0x651
created by net/http.(*Server).Serve
/usr/lib/go-1.10/src/net/http/server.go:2795 +0x27b

Hi
We are experiencing the same issue mentioned above. Here's the stack trace:
I0516 16:31:54.206682       1 main.go:44] Starting JIRAlert version 0.5 I0516 16:31:54.213295       1 main.go:110] Listening on :9097 ^[[A^[[B2018/05/16 16:34:31 http: panic serving x.x.x.x.:56692: runtime error: invalid memory address or nil pointer dereference goroutine 19 [running]: net/http.(*conn).serve.func1(0xc420242000) 	/usr/lib/go-1.10/src/net/http/server.go:1726 +0xd0 panic(0x837720, 0xb4ac30) 	/usr/lib/go-1.10/src/runtime/panic.go:505 +0x229 github.com/free/jiralert.(*Receiver).Notify(0xc42014e1a0, 0xc42014c120, 0xc42014e1a0, 0x0, 0x0) 	/home/alin/go/src/github.com/free/jiralert/notify.go:56 +0xfc5 main.main.func1(0x9176e0, 0xc42025c000, 0xc420250000) 	/home/alin/go/src/github.com/free/jiralert/cmd/jiralert/main.go:86 +0x386 net/http.HandlerFunc.ServeHTTP(0xc420135d40, 0x9176e0, 0xc42025c000, 0xc420250000) 	/usr/lib/go-1.10/src/net/http/server.go:1947 +0x44 net/http.(*ServeMux).ServeHTTP(0xb5ab80, 0x9176e0, 0xc42025c000, 0xc420250000) 	/usr/lib/go-1.10/src/net/http/server.go:2337 +0x130 net/http.serverHandler.ServeHTTP(0xc42009dee0, 0x9176e0, 0xc42025c000, 0xc420250000) 	/usr/lib/go-1.10/src/net/http/server.go:2694 +0xbc net/http.(*conn).serve(0xc420242000, 0x917c20, 0xc420248040) 	/usr/lib/go-1.10/src/net/http/server.go:1830 +0x651 created by net/http.(*Server).Serve 	/usr/lib/go-1.10/src/net/http/server.go:2795 +0x27b

Hmm... Looks like an issue was already created, but has no resolution. Not sure whether that's to be expected from a newly created issue, and why I didn't run into it while testing. (Is there such a thing as a default resolution and if you don't set it then it's empty?)
Could any of you guys please double-check how your issue looks like? (In terms of does it have a resolution/state?) The offending line of code is https://github.com/free/jiralert/blob/0.5/notify.go#L56

Hi @free, thank you for your quick answer. I can indeed reproduce this error for issues that have status Done but no immediate resolution (unresolved)
https://gyazo.com/69ddfc689e3ce520ad88267b883b0d86

[Didn't want to close this, GitHub must have thought "Attempt to fix" is the same as "fix". Reopening]
I've added a issue.Fields.Resolution != nil check to the offending line. Let me know if that does anything for you guys.

Issue no more happening


Feature Request: We should be able to work with case insensitive file names of Changelog.yaml

We want to keep it CHANGELOG.yaml. We could do a CLI param for file name or the project path could itself include the file name to be extracted out.

Hello @shamasis !
I find the idea in general good. If the CLI param is not there, then the defauld Changelog.yaml will be used.
But honestly because of too many project that we have, currently we cannot afford to maintain even a line of code in our github projects. So feel free to create a pull request and I'll try to merge it as soon as possible :). That would be really awesome!
Thank you for your suggestion and interest in yankee!


Add Keycloak OIDC provider

Much of the grunt work is generic OIDC
https://github.com/rancher/rancher/pull/31572 needs to merge, otherwise visiting auth providers page will error only an issue the other way around (other PR merges before this one)

Also fixed

store's principalId was not updated after user enables any auth provider
Colour of InfoBox title in dark mode
Issue where some kind of errors when enabling provider were shown as an empty box (exceptionToErrorsArray is now used, which also uses a better catch all stringify)
An issue where enabling and disabling a provider in the same visit meant lost defaults
An issue where Auth / Groups would not display (async part had been removed)
Resource instance validation would show all fields as invalid once one field had failed

Spoke with Neil, this is good to merge


Improve the 'drag 'n drop' feature to up 'n down selected text

The 'drag and drop' feature is one of the most requested requests by most popular IDE's users in this decade, such as Sublime Text and Atom. You have placed it as part of the configuration, and it is 'false' by default (that will already depend on each user, however, I would prefer it to be enabled by default).
However, they lacked to complement this functionality with this one: to allow, when the user select a text, by pressing ctrl + up / ctrl + down, he/she can respectively, up/down the text (as do the previously mentioned Sublime Text and Atom).
If you consider that this functionality is present, but not active, you can either make it active in a future minor update and, in contrast, close this request. Very thanks.

VSCode Version: 1.10.2/Confirmation 8076a19fdcab7e1fc1707952d652f0bb6c6db331
OS Version: Zorin OS 12 (Ubuntu-based 16.04)

You can move the selected lines up and down with Alt + Up/Down.

@chrmarti already provided the answer.


Adding support from "style" blocks and "hat": "cap"

The PatchManager now loads both the default top-left path and the
hat patch into memory, since they can both be in use in the same workspace..
Added a test block to the DevTest toolbox and workspace.

This change is

Reviewed 8 of 8 files at r1.
Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.

blocklylib-vertical/src/main/java/com/google/blockly/android/ui/vertical/InputView.java, line 86 at r1 (raw file):

        }
        mHasMeasuredFieldsAndInput = false;
        BlockGroup connectedBlockGroup = getConnectedBlockGroup();

Why did this become a block group?

Comments from Reviewable

Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.

blocklylib-vertical/src/main/java/com/google/blockly/android/ui/vertical/InputView.java, line 86 at r1 (raw file):
Previously, rachel-fenichel (Rachel Fenichel) wrote…
Why did this become a block group?

The only use of the previous block was to pass it into the PatchManager's helper function. But now that hats are per-block and specific to the BlockView implementation, I pass in a view. However, there was a case where the input did not have a block, so it was easier to pass in the whole group, offloading a lot of ugly null check and similar logic to the helper function.

Comments from Reviewable

Review status: 7 of 8 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Resolves #659


Override label "Table of Contents"

Is there a way to override the label "Table of Contents" ? I write in french language and need to override this label to suit this language.
I tried to use parameter :lang: fr but it doesn't update the label "Table of Contents"

I added :toc-title: Sommaire and the label "Table of Contents" has been replaced by "Sommaire".
So it's ok !

:+1:
Asciidoctor doesn't yet support loading a language file so that this is automatic. That's planned as part of https://github.com/asciidoctor/asciidoctor/issues/1129.


Add CI checks and setup

d
d
d
d
f
ignore
sd
dfdf
dfdf
dfdf
Delete src/max/pycache directory
asa
df
df
df
qw
q
sd
qwq
qwq
w
w
w

Sorry for the noise! Was trying to open it on my fork...


Register table styling

Changes proposed in this pull request
Update styling of table headers and horizontal scroll
Guidance to review
View register page
After

With horizontal scroll improvement

Fields with cardinality n don't have their headers styled like the others. I know these cannot be sorted but we are displaying non friendly name vs friendly name for others.

A register with cardinality n fields -

Ready for approval @michaelabenyohai ;-)


Add developer docs

Description
This PR adds developer documentation, mostly directions for satisfying the linters that run in CI.
@umesh-timalsina, @daico007, @justinGilmer - could you let me know if anything glaring is missing, anything that would have been useful to know a few days ago? An exhaustive review is not necessary, as this is a living document that I hope sees regular updates.
Checklist

[ ] Add tests
[ ] Lint
[ ] Update docstrings

May be it is standard practice, but it might have been nice to know mypy is configured via setup.cfg.

Good point, thanks. Feel free to comment other issues in the future or file PRs directly against this file


Compile expr in config

Summary
Looks like expr is used mostly via expr.Eval. While it is a valid usage, precompiling expressions on config save/update can detect a lot of errors.
Consider using expr.Compile. One of the expr features is type checker:
out, err := expr.Compile(`name + age`)
// err: invalid operation + (mismatched types string and int)
// | name + age
// | .....^

Type checker can infer types from Argo env variables, so there is no need to redefine types for expr.
Use Cases
Detecting errors in expression of configuration save/update.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

This would be a great validation step to add to the operator and CLI, thanks for the suggestion!
Related to the goals of #10017 as well


Contains tests

Cobol.groovy script has been modified to build cobol testcases independently of the flag "runzTests".
The code performance was improved with respect to the previous pull request.

@dennis-behm Does the last commit reflect your idea?

@jbyibm, this fixes #81


[Feature]: App pusher can specify a particular buildpack from the available list

Blockers/Dependencies
This will address bug #1784
Background
As a app developer
I want to specify building using a particular buildpack from the ones available
So that I can address problems where the wrong buildpack is selected for the build.
The list of available buildpack is retrieved using the cf buildpacks command:
$ cf buildpacks
Getting buildpacks as cf-admin...

position   name                         stack                         enabled   locked   filename
1          paketo-buildpacks/java       io.buildpacks.stacks.bionic   true      false<EMAIL_ADDRESS>2          paketo-buildpacks/go         io.buildpacks.stacks.bionic   true      false<EMAIL_ADDRESS>3          paketo-buildpacks/nodejs     io.buildpacks.stacks.bionic   true      false<EMAIL_ADDRESS>4          paketo-buildpacks/ruby       io.buildpacks.stacks.bionic   true      false<EMAIL_ADDRESS>5          paketo-buildpacks/procfile   io.buildpacks.stacks.bionic   true      false<EMAIL_ADDRESS>
There are instances where the presence of a certain file may confuse the automatic buildpack selection. The app developer can fix this themselves by specifying the -b or --buildpack option for cf push.
It is also possible to specify buildpacks in an app manifest using the (deprecated) buildpack field, or the buildpacks list field. This should be supported in the same way as using the cf push --buildpack option.
Note: this feature will allow selecting an existing buildpack only; custom buildpacks specified by a git URL are out of scope.
Acceptance Criteria
GIVEN a buildpack exists with the name 'repo/my-buildpack'
WHEN I cf push my app using the option -b repo/my-buildpack or --buildpack repo/my-buildpack
THEN I see the app was built using the buildpack specified
GIVEN a buildpack exists with the name 'repo/my-buildpack'
WHEN I cf push my app using a manifest with buildpack set to 'repo/my-buildpack' or buildpacks set to a list of ['repo/my-buildpack']
THEN I see the app was built using the buildpack specified
GIVEN buildpacks exists with names 'repo/my-buildpack', 'repo/another-buildpack'
AND 'repo/another-buildpack' will not build my app by 'repo/my-buildpack' will
WHEN I cf push my app using a manifest with buildpacks set to a list of ['repo/another-buildpack', 'repo/my-buildpack']
THEN I see the app was built trying the buildpacks specified
Dev Notes
When the kpack-image-builder reconciles a BuildWorkload resource with non-empty buildpacks list, it should:

Check the specified buildpacks exist in the default ClusterStore. If not, set a failed status on the BuildWorkload with an appropriate error message
Compute a hash of the buildpacks list to use as a Builder name. Ordering is important.
Compute the OCI image tag for the Builder. This should reuse the repository prefix used for droplets, appending 'builders-' and the builder name. Ensure the OCI repository is created if necessary using the same mechanism as for droplets.
If a Builder already exists in the CF Space's namespace with the computed name, use it. Otherwise create a new kpack Builder with the computed name, reusing the serviceAccountRef, stack, and store from the default ClusterBuilder. The order field should contain the list of buildpack IDs in the formatorder:
  - group:
    - id: buildpack-1
  - group:
    - id: buildpack-2

Set the BuildWorkload as an owner on the newly created or already existing Builder, so that it will be garbage collected when all BuildWorkload references have been deleted.
Use the Builder name on the kpack Image created by the reconciler. The initialisation phase of the reconciler will exit at this point, and the build process should process normally after that. It will wait for the Builder to be ready if necessary.

The normal use case for this feature is:

User does a cf push using the default ClusterBuilder buildpack order, but the wrong buildpack is detected.
User specifies the correct buildpack using -b option to cf push.

Step 1 results in a failed kpack.Build on the kpack.Image associated with the CFApp. Step 2 modifies the kpack.Image to point to a new Builder with just the desired buildpack in it, but kpack Image reconciler logic says this should not trigger a new Build because the lastBuild status is failed: https://github.com/pivotal/kpack/blob/9081a1861d6551e86110653f80259c9a17c2b28f/pkg/reconciler/image/build_required.go#L108.
I've raised an issue with kpack here: https://github.com/pivotal/kpack/issues/1198. I think we need to block this feature on that.


Bindings generation

@TerrorJack 👋
Was curious, were these bindings manually written or generated? And if generated, what tool did you use?
https://github.com/TerrorJack/direct-rocksdb/blob/master/src/Database/RocksDB/Internals.hs

@dmjio Hi, they were mostly generated from a Python script I wrote last year. I manually run gcc -E on the header first, strip some useless parts from the gigantic output (usually related to standard library), then use pycparser in my script to process that header and generate the foreign import declarations.

@TerrorJack do you happen to have that python script anywhere?


Adding support for external authentication / access token generation

I am using passport (node authentication middleware) for my user authentication with an additional Instagram authentication module. As this means I'm managing the authentication and access token externally, I wanted a way to initialize Instajam with an existing token and just use the functional endpoints.

Seems legit, @kevinterrobang. If you could address the one comment above I'll merge this.

How did that get there?! Removed the stray newline from the source and from the non-minified distribution file.

Thanks!


Support K8sApp by pipectl init in simplest way

What this PR does / why we need it:
Support generating the simplest app.pipecd.yaml for K8sApp by pipectl init
, selecting Kustomize or Helm.
Which issue(s) this PR fixes:
Fixes #4753
Does this PR introduce a user-facing change?: no

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

/review

@ffjlabo
Thank you so much! I fixed all above.

@khanhtc1202 Would you check this?  (not in a hurry)