Improve kubernetes scrape config example

Use the following annotations:

prometheus.io/scrape
prometheus.io/port
prometheus.io/path
prometheus.io/scheme
prometheus.io/param-

Signed-off-by: Sylvain Rabot<EMAIL_ADDRESS>

We purposefully removed these, as users were taking them to be The way to do things rather than merely an example of something you could do. @bwplotka

Intended or not I think those became standard and I don’t see how it improves the user experience to replace them by a placeholder especially given that most of helm charts use those (https://github.com/helm/charts/search?utf8=✓&q=prometheus.io%2Fscrape&type=).
I think a config example working out of the box and compatible with most deployments and helm charts out there has more value for the users.
I’m glad I had theses when I started, god only knows what kind of messed up config I would have end up with otherwise.

On 11 Jun 2019, at 17:25, Brian Brazil<EMAIL_ADDRESS>wrote:
We purposefully removed these, as users were taking them to be The way to do things rather than merely an example of something you could do. @bwplotka
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @sylr :wave: (: Feel free to use those, but I don't think Prometheus should keep this as an example and we already talked about this multiple times.
Essentially it gives false impression that prometheus.io is somehow magically used by prometheus, whereas it's not until you use it in relabelling on your own. This created much more confusion in the past. We also did not remove any examples. You have the example how you do annotation based scrape choice it if you want, we just moved prometheus.io to example.io to explicitly show that you can put in label name whatever you want and that user is responsible for handling this in relabelling. (:
We are defintely happy to discuss potential improvement in examples and docs, but we agreed to not confuse users with hardcoded prometheus.io.

I think a config example working out of the box and compatible with most deployments and helm charts out there has more value for the users.

Personally I think it's not. If this is now a standard I would advice to revisit it as it does not support multiple containers.
You can find overview of your options here: https://docs.google.com/document/d/1S6O1czHtjR2DGfK2zeZDLr88wxyLRXB2JpH5g7YM1J8/edit?usp=sharing

Hi @bwplotka I understand your stance, however I still feel giving a turnkey configuration is something that new users would appreciate.
I believe that the less time you spend getting things running the more you'll appreciate a software. Also I think it's easier to understand things when you have a working example.
The prometheus.io/... annotations is enough for 95% of kubernetes deployments out there. We could warn that the example would not work in a scenario where pods have several containers exposing metrics.

Hi @bwplotka, if Prometheus doesn't not encourage any sort of convention (or even standard) around prometheus.io/... annotations, than I agree that they should not be in the examples. However, you can find the annotations all over the internet. As such, I was expecting to find some documentation about them in the Prometheus docs. I think the docs would greatly benefit from mentioning them. Even if it is just to say that their use is discouraged.


Videos Won't Play On Linux Even With VLC Installed

Describe your bug here.
When A Lua File Try's To Load A Video (.mp4 or .webm) It Will Result In The Terminal Saying "Segmentation fault (core dumped)" Even After I Intalled VLC
Command Prompt/Terminal logs (if existing)
Segmentation fault (core dumped)

Are you modding a build from source or with Lua?
Lua
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
None

The VLC stuff that is currently used only works for windows (currently)

i saw code for VLC support on linux

i saw code for VLC support in FNF-PsychEngine/git/source/vlc/cpp/lib/linux

As I've said. It only works with Windows. This issue has been discussed multiple times. It is a known bug.

ok

I Made A Commit That Will Fix This Problem So No More Complaining From Me


[Request] Remember monitor position

It always launch at primary monitor. Would be great to remember window size (fullscreen, custom size) and monitor position.
portable v5.8

Did you try the latest non-portable version? It should remember the position per-PC either way.

i don't know what changed, same v5.8 now remember position and size.

So the issue is resolved?


Hopefully fix renovate for non-major versions & out of work hours frequency

Ideas came from https://www.augmentedmind.de/2023/07/30/renovate-bot-cheat-sheet
Found this setting 🤞

Ideas came from https://www.augmentedmind.de/2023/07/30/renovate-bot-cheat-sheet

Encouraging... #161

Presumably the actual merging happens out of work hours

🤞

Nothing happened 😢

Noticed a lot of branches are there

logs


Change the application name

Is there any way to change the application name from "Last.fm" to "Last.fm (Music)" or something? Like which lines of code? I can't seem to find it.

no not currently, you'd have to compile the application yourself to make those changes since it's hardcoded. but yeah since i'm almost done with a rewrite of this application which will be much more faster, i'll have the changes done in there and i'll ping you when i release it.


functional levels

please clarify the domain and forest functional level requirements for Server 2019

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86e4b814-7c4a-0895-2eea-667e3870053f
Version Independent ID: 740cea70-5958-4560-617f-d9f55e7dc78d
Content: Windows Server 2016 Functional Levels
Content Source: WindowsServerDocs/identity/ad-ds/active-directory-functional-levels.md
Product: windows-server-threshold
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@DSPatrick Windows Server, version 1809 is Windows Server 2019. There is no new functional level.

I meant the minimum requirements for introducing the first 2019 domain controller. For 2016 minimum DFL needs to be 2003. I have heard but cannot confirm for 2019 minimum DFL needs to be 2008?

The minimum DFL/FFL requirements for introducing the first domain controller (2016 or 2019) is always a hot topic in forums discussions so it would be great to have this clearly presented in this document.

@DSPatrick I spoke to the PG this morning and they are saying 2008R2 to introduce Windows Server 2019 DCs.

Thanks for confirming. Can we add the info for 2016 and 2019 to this document?

@DSPatrick I am submitting a PR to our private repo to update this topic and add the schema change to https://docs.microsoft.com/windows-server/identity/ad-ds/deploy/schema-updates

it-server/pullrequest/13112

#please-close

Thanks a lot for doing


bootstrap4 GlossaryTermsController

Rename controller and associated files, etc.: Glossary... => GlossaryTerms...
(Conforms to Rails default and other changes from master to bootstrap-4.)
Turn tests green

I have more to do before this is ready for review.

Coverage increased (+0.1%) to 84.833% when pulling d0fc19d640934a34ea2ab92af710df3bedeacd8b on 173824647-jdc-bootstrap4-GlossaryTermsController into 0b588217d95942db8b598a6b867f59bbba643b67 on bootstrap-4.

It would be great to get this PR, but

Merger should not happen until PR #614 is merged (with conflicts resolved).
Otherwise Travis CI would break because of conflicts between master and bootstrap-4.
I'm out of pocket for the remainder of 2020-07-20 through -24. So Sat 7/25 is the earliest time I can respond to comments. If someone wants to merge this in the mean time, great.

Joe -
Glossary tests controller is almost green, EXCEPT for one test that's missing language tags. I don't understand what it's looking for.
 FAIL["test_show_links_to_destroy", #<Minitest::Reporters::Suite:0x00005566b69bbe10 @name="GlossaryTermsControllerTest">, 5.9361734359990805]  test_show_links_to_destroy#GlossaryTermsControllerTest (5.94s)         Language tag(s) are missing..         --- expected         +++ actual         @@ -1 +1 @@         -[]         +[:destroy_glossary_term, :destroy_glossary_term, :destroy_glossary_term, :destroy_glossary_term, :destroy_glossary_term]         test/test_helper.rb:133:inteardown'
`
However, the "destroy_glossary_term" link should now be available in the view, in the navbar, if the user is an admin.
I'm going to go ahead and merge this now because the changes I've made in navbar (that should allow many more tests to pass with links that formerly appeared in tabsets) need to be applied throughout the views.
Note that i've refined the object_link_helper methods so that they work with namespaced objects like name_descriptions, too. Whew!!!

Thanks for all the improvements, cleanup, and merger!
As of the merger commit, GlossaryTermsControllerTest is completely green for me locally, and in both of the Travis CI builds. So I also don't understand the failure you get in https://github.com/MushroomObserver/mushroom-observer/pull/611#issuecomment-663808938

PS: And viewed manually in dev mode, it behaves properly. There's a destroy link when viewing a glossary term in admin mode, but no link when not in admin mode.

Hi @JoeCohen - welcome back! Hope you had a good trip.


Fix duplicated arguments in the stub

Resolves #6
Changes:

Used OrderedDict instead of list in Translation DTO
Added simple tests for stub generation
Some code refactor by sourcery.ai
Some type hints fix
Add extra dependencies for stub generation

Too shitty commits & code.


Pull release-2.15 branch to master.

Merging commits as it is, so ignoring DCO check. Not sure why it fails though as the failing commit passed DCO check: https://github.com/prometheus/prometheus/pull/6509


Fix typos and add missing russian translations

I added some missing russian translations (not all) and fixed typos in existing translations.

Q
A

Bug fix?
no

New feature?
no

Needs wipe?
no

Fixed issues
-

Description:
Added missing russian translations and fixed typos in stringtable.xml
Successfully tested on:

[x] Local MP

Many thanks for the update on the russian localization. Really great and highly appreciated.
If we're starting to work on a next update of the old framework (due to a new DLC or too much discovered bugs/reports for the current version), we'll move this correction in. 👍


Promote the new tx submit impl

add result reporting to the new tx submit API and add stubs in the CLI.
remove the old TxSubmit
rename the TxSubmitChairman to TxSubmit

This does not yet cover nice rendering of the tx submit failures, but at least the basic plumbing is in place and we've retired the old impl.

bors merge


OL native Geodesic circle type

Is your feature request related to a problem? Please describe.
Creating and using geodesic circles is too difficult in open layers. It's probably not such an uncommon use case and it would be very handy to have this easily used with the OL Interactions without having to write custom geometry/style functions.
Describe the solution you'd like
Create an OL native GeodesicCircle type which can be used like this:
const circle = new GeodesicCircle(radius, coordinate, number_of_sides)
...
circle.radius()
circle.center()
...

Looks for me like the existing Polygon.circular-function: https://github.com/openlayers/openlayers/blob/v6.8.1/src/ol/geom/Polygon.js#L426

Kind of but not really. Unless I am mistaken, this function just builds a polygon with n sides. It's just a representation of a circle so if you try to resize, only the point which you grab is moved. The rest of the "circle" stays put. Moreover, as this is just a polygon, there is no radius or centre coordinate attached to this circular polygon.
Check out this example:
https://openlayers.org/en/latest/examples/draw-and-modify-geodesic.html
There's quite a bit involved with getting the radius, rescaling and dragging. Ideally, this functionality would be wrapped up inside the GeodesicCircle class.


PostfixExpression grammar rule

This PR implements one of the grammar changes from 38ba4ea308a7f9534dd9d976d0de0e08329d0b94.
Several tests are failing, but there is no point in trying to fix that.
They are testing language features that are still miles away from being finished, so I propose we simply disable them for now.

See also the discussion starting in https://github.com/Minres/CoreDSL/pull/12#issuecomment-989617358.
This is the first part in a PR series to break up the mega-changeset that #12 has evolved to.


Cmd-[ shortcut incorrectly uses Ctrl-[ on a Mac

On a Mac, shortcuts that use Ctrl on other systems are expected to Cmd. This is the case for Ctrl+K, Ctrl+., and Ctrl+S.
However, the unexpected behavior is observed for Ctrl-[ and Cmd-[ on a Mac.
Ctrl-[ seems to have the functionality described in the documentation. Cmd-[ seems to have no effect in the desktop app. In the web app, it seems to have some kind of navigational functionality, but I'm not entirely sure what the behavior is.
The behavior that would be consistent with user docs and other shortcuts would be for Ctlr-[ to do nothing, and Cmd-[ to have the documented behavior.

So looking at https://github.com/zulip/zulip-desktop/issues/489 and #9525, as well as the PR fix for those https://github.com/zulip/zulip/commit/5a5ca12f6f2f9b87c89db63823b49bb4a1215f79, and based on the feedback from @timabbott here https://github.com/zulip/zulip/pull/32142#issuecomment-2445530588, this is likely an error in the documentation for this keyboard shortcut and not in the code.
Started a CZO documentation discussion here: https://chat.zulip.org/#narrow/channel/19-documentation/topic/documenting.20the.20Ctrl.20.2B.20.5B.20keyboard.20shortcut/near/1972559


is it possible to have multiple services filtered by spec.rules.path

Describe the bug
Instead of target by port
rules:
    - port:

we target host/path without using external web server (nginx)
rules:
    - path: /cdn
       backend:
        service:
          name: cdn-service
    - path: /api
       backend:
        service:
          name: api-service

Hi @ceddybi,
The OnionService CRD is used to render a torrc file so that the tor daemon can route onion requests to the proper hidden service "backend". As the tor daemon only cares about routing, and does not interpret the protocol running ontop, so it won't be able to interpret the path (https://manpages.debian.org/testing/tor/torrc.5.en.html#HIDDEN_SERVICE_OPTIONS). To implement this feature we'd have to implement a reverse proxy (either from scratch or embedding an existing one; like the one you mention, nginx).
I would like to avoid that due to a number of reasons:

Increase dependencies of the project
Increase operator footprint
May put in question this project's ingress-class neutrality

You can achieve such behavior following the ingress example: https://github.com/bugfest/tor-controller/blob/d0f977fda6baa18df2c3294ce9f72a6412960794/hack/sample/full-example.yaml#L55-L62 - please try this method and let me know if that'd solve your case.
Additional note
If you don't want to expose the service to the public IP space of your cluster so can deploy your ingress controller so that it uses clusterip: e.g. for nginx ingress controller you could set controller.service.type to clusterip: https://github.com/kubernetes/ingress-nginx/blob/6107346590f1f7e64749e0977deb4f639e145a17/charts/ingress-nginx/README.md?plain=1#L432
br/BF

thank you @bugfest, i ended up using multiple backends using different ports,
the problem was, having multiple services/domains, e.g one for cdn, api and another for frontend (3 in total), made the site very slow.
but with all 3 backends on one domain using different ports worked.


Warn on collection activation when the resultant pipeline name is in use by another collection.

Given the current need for the operator to manage unique pipeline names for each active collection, the operator should at least issue a warning or give an error status for collections activated that result in pipeline names that are in use by another collection.

@stephenkinder Can you say more about which specific cases you'd like to see an error generated for?  It's difficult for the operator to know when there is a conflict (at least currently) because on a collection re-activation, the pipeline is going to already be there, but we don't know that it's there because this collection activated it previously.  Are you concerned about cases where the name mangling generates the same name twice?  Or something else?

Just the simple case that the java-microprofile and node.js collection have the same pipeline name.  If we have a limitation that collections must have unique resultant pipeline names, then we need to fail the activation of a pipeline that already exists and bound to another collection.
The default collections use the new Kabanero symbolic substitution for collectionId, but the enterprise architect may make a mistake in his collection curation.
The collection build may not be able to determine if there is a conflict during build time, the operator is the only one seeing the real resultant pipeline names in this given cluster.
It is not an error to reactative the same pipeline for a collection reactivation; it is only a conflict if there are two active collections that have the same pipeline name.

I think the way we have to solve this problem, is to annotate the collection artifacts (what we read and apply out of the pipeline zip) with the sha256 of the pipeline zip.  Then subsequent activation, either for a different version of the same collection, or a different collection, if that artifact already exists, but the sha256 in the annotation does not match the sha256 of the pipeline we are currently activating, then we issue an error or a warning.
Consider this situation - Champ is using version 0.2.5 and 0.2.10 of java-microprofile collection.  These two versions use different pipeline zips, but the artifacts within use the same name (ie CollectionId-build-task).  When we create the java-microprofile-build-task for version 0.2.5, we should annotate it kabanero.io/sha256: a7f983a5b321.... with the sha256 of the pipeline zip.  Then when we activate version 0.2.10 we'll see that there is already a java-microprofile-build-task created, so we'll compare the annotated sha256 with the sha256 of the pipeline zip for version 0.2.10.  They will be different, so we issue a warning, and then, ????  I guess today we apply it anyway.  This issue says warn, so lets continue to go with that for now.  We can change the behavior to fail later if we need to.
I think a manifestival transform can probably be used to apply the annotation with the sha256 in it.

We've added support to use the pipeline digest as a fill-in for pipeline names.  We also support multiple stacks using the same pipelines (affectionately referred to as "the operator learned to count").  I believe that this fulfills this requirement.  Please re-open the issue if you don't agree.


Local Vault Going into a Corrupted State

          I tried it out and it worked! The only problem I'm finding now is that my vault keeps getting corrupted like in this issue: https://github.com/quexten/goldwarden/issues/38. The vault purge and log in step fixed it, but I had to do it 2 or 3 times.

Originally posted by @Anthony-Fiddes in https://github.com/quexten/goldwarden/issues/37#issuecomment-1880800037

Not entirely sure what causes this. I noticed some sync errors, but these shouldn't cause permanent corruption of the configuration. Let me know if you have any relevant logs, or reproducible steps for this issue.


amplify api add-graphql-datasource fails when using schema subdirectory

Describe the bug
amplify api add-graphql-datasource fails when you have put your schema(s) in the schema subdirectory, so there is no schema.graphql in the API directory.
? Select the database to use as the datasource: TESTDB
GraphQLError: Syntax Error: Unexpected <EOF>
    at syntaxError (/usr/lib/node_modules/@aws-amplify/cli/node_modules/graphql/error/syntaxError.js:24:10)
    at unexpected (/usr/lib/node_modules/@aws-amplify/cli/node_modules/graphql/language/parser.js:1322:33)
    at parseDefinition (/usr/lib/node_modules/@aws-amplify/cli/node_modules/graphql/language/parser.js:152:9)
    at parseDocument (/usr/lib/node_modules/@aws-amplify/cli/node_modules/graphql/language/parser.js:110:22)
    at Object.parse (/usr/lib/node_modules/@aws-amplify/cli/node_modules/graphql/language/parser.js:38:10)
    at datasourceSelectionPrompt.then.then.then.graphqlSchemaContext (/usr/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-api/commands/api/add-graphql-datasource.js:111:46)
    at process._tickCallback (internal/process/next_tick.js:68:7)
There was an error adding the datasource

Amplify CLI Version
4.7.0
To Reproduce
Create a schema subdirectory, move schema.graphql in there and rename it to demo.graphql for example.
Expected behavior
If there is no schema.graphql directory, create new schema in the subdirectory.
Desktop

OS: Ubuntu 19.10
Node Version: 10.18.0

+1
but for me does not working with even the schema.graphql in the default folder.
any workaround?

+1
per https://github.com/aws-amplify/amplify-cli/issues/3536
Any ETA?


R: fix some modules with configure-shebang-error

xml2: fix configure script
rversion, devtools: mark as unbroken
dependency R-curl was fixed in 513e31185bb15a8c2b52149b1f1c2b3fe1740745

cc @peti


Improve aesthetic appearance of the timer

A basic style has been added with 12b0c3a now I have to implement the dark and light mode


Make text areas configurable

Names of text areas which should have snippets available can now be configured via plugin_Snippets_textarea_names configuration option (default: "bugnote_text"), i.e. "bugnote_text, steps_to_reproduce". It makes including other fields easier than hard-coding each new field into code like proposed in issue 3

This is fixed in 31f5fc0f5a7c692d1130ed63efe4f5acfb5bf528 (for Mantis 1.2.x) and 08af232a173c5c9b55d2c5eda5421aa394304ac1 (for 1.3.x)


[Bug]: “OpenAdapt.app” cannot be opened because the developer cannot be verified.

Describe the bug

To Reproduce
Download and open from https://openadapt.ai/ on MacOS

Workaround:

Scroll down:

Authorize:

Click Open:

Click Allow:


Add new news apis

Added currents api to available list, it has 1,000 free request everyday so I suppose it fits the criteria?
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[ ] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks!


Interpolated Strings : include different data sample code doesn't workt

I copy and paste your sample code from this link and run it, but it doesn't work. Perhaps the sample is outdated?
Here are the error messages :
(16,18): error CS1519: Invalid token '(' in class, struct, or interface member declaration
(16,19): error CS1031: Type expected
(16,19): error CS8124: Tuple must contain at least two elements.
(16,19): error CS1026: ) expected
(16,19): error CS1519: Invalid token '$"On {date}, the price of {item} was {price} per {unit}."' in class, struct, or interface member declaration
(12,1): error CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code
(13,1): error CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code
(14,1): error CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code
(15,1): error CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code

I had This problem I but it's now FIXED

have the same problem toooooooo

+1

This is now fixed.


predict returns wrong number of predictions in R implementation with sparse data

Environment info
Operating System: Ubuntu 16.04
Compiler: gcc
Package used (python/R/jvm/C++): R
xgboost version used: 0.4.3
If you are using R package, please provide

The R sessionInfo()

R version 3.2.5 (2016-04-14)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 16.04.1 LTS

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8     LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8       LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats4    parallel  stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
 [1] xgboost_0.4-3        Saturn_<IP_ADDRESS>00    dtplyr_0.0.1         reshape2_1.4.1       dplyr_<IP_ADDRESS>00     GenomicRanges_1.22.4 GenomeInfoDb_1.6.3   IRanges_2.4.8        S4Vectors_0.8.11     BiocGenerics_0.16.1  nvimcom_0.9-21       devtools_1.11.1      setwidth_1.0-4
[14] colorout_1.1-1

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.6                       lattice_0.20-33                   Rsamtools_1.22.0                  Biostrings_2.38.4                 assertthat_0.1                    glmnet_2.0-5                      digest_0.6.9                      foreach_1.4.3
 [9] R6_2.1.2                          plyr_1.8.4                        futile.options_1.0.0              ggplot2_2.1.0                     zlibbioc_1.16.0                   lazyeval_0.2.0                    rstudioapi_0.5                    data.table_1.9.7
[17] Matrix_1.2-5                      rmarkdown_0.9.6                   BiocParallel_1.4.3                readr_<IP_ADDRESS>00                  stringr_1.0.0                     RCurl_1.95-4.8                    munsell_0.4.3                     rtracklayer_1.30.4
[25] htmltools_0.3.5                   SummarizedExperiment_1.0.2        tibble_1.1                        roxygen2_5.0.1                    codetools_0.2-14                  XML_3.98-1.4                      BSgenome.Hsapiens.UCSC.hg19_1.4.0 crayon_1.3.2
[33] withr_1.0.1                       GenomicAlignments_1.6.3           bitops_1.0-6                      grid_3.2.5                        gtable_0.2.0                      DBI_0.4-1                         magrittr_1.5                      Romulus_1.0.1
[41] scales_0.4.0                      docopt_0.4.5                      stringi_1.1.1                     XVector_0.10.0                    ggthemes_3.0.3                    testthat_1.0.2                    futile.logger_1.4.1               PRROC_1.1
[49] functional_0.6                    lambda.r_1.1.7                    iterators_1.0.8                   tools_3.2.5                       BSgenome_1.38.0                   Biobase_2.30.0                    colorspace_1.2-6                  memoise_1.0.0
[57] prg_0.5.1

Steps to reproduce
Extract model and data from attached zip file.
model <- xgb.load('model_file.xgb')
data <- readRDS('bug-features.rds')
predictions <- predict(model, data)
stopifnot(length(predictions) == nrow(data))

What have you tried?

predict(model, as.matrix(data)) works as expected
predict(model, xgb.DMatrix(data)) fails in same way

bug.zip

This actually seems to be a bug in xgb.DMatrix as the following code shows:
data.dm <- xgb.DMatrix(data)
stopifnot(nrow(data.dm) == nrow(data))

I followed this down to the C API and there does not seem any way to tell XGDMatrixCreateFromCSC what the desired dimensions of the matrix are. Is this by design? From a user of the R package's perspective the behaviour seems very odd that if final rows in your sparse matrix are all 0 then you get fewer predictions. For the moment I'm working around it with:
#'
#' Create a xgb.DMatrix from a dgCMatrix working around bug in
#' xgboost where zero rows at end of dgCMatrix are ignored.
#'
DMatrix.from.dgC <- function(dgC) {
  if (0 == dgC[nrow(dgC), 1]) {
    dgC[nrow(dgC), 1] <- .Machine$double.eps
  }
  xgb.DMatrix(dgC)
}

The package xgboost seems to be outdated. Can you test it on the latest version 0.6-0?

0.4-3 is the latest version from CRAN. In any case there is the same behaviour on 0.6-0.

The 0s in the sparse matrix are treated as NA in xgboost. After as.matrix(data) they are numerical 0s again. Usually we don't make prediction with an "entirely NA" data point.

Usually xgboost does make predictions with entirely NA data points as that's what it does when the rows are in the middle of the matrix, it just ignores those type of rows if they are at the end (but not at the beginning). That is inconsistent from a user's perspective. My data matrix has many rows just with zeros (or as you say NAs), some of them are used to predict but any at the end are not. Additionally I get a different result depending on the class of the object I pass into the predict argument. If I pass a dense R array I get all the predictions, if I pass a dgCMatrix or a xgb.DMatrix I'm missing the ones at the end. Even if this confusing behaviour is by design then it isn't easy to find in the documentation.

It makes sense to me. You are welcome to open an PR for this issue. I will have time for the fix maybe in the next week.

I wanted to give it a go but then when I saw the change might be to the API of the underlying C library I was a bit wary as it would affect all the language bindings on top. If the only changes needed were in the R package I would have given it a go.

I don't think a change in the R pacakge can do that. Your fix above is not the correct one since it changes an NA value into a small number, but sometimes the NA values are not equivalent to 0.
@tqchen Can we have your opinion on this? In short,  xgboost tends to ignore the all-NA rows at the end of the input sparse matrix but not the all-NA rows in the middle,  and we want to fix it.

My "fix" above isn't really a fix, just a way for me to get my code working when it is hard to predict how many predictions I will receive from xgboost. AFAICT the C API function XGDMatrixCreateFromCSC doesn't receive enough information to make more than an educated guess about the dimensions of the matrix it should return. This is perhaps why it drops trailing rows of zeros. It would need an additional argument to do know the dimensions. Having said that I'm not 100% sure about the sparse matrix representation being used so I could easily be wrong.

In recent months, there were many reports because of this bug (which, in essence, is that automatic guessing of sparse data num_row or num_col for DMatrix is not working for CSC or CSR formats when there are empty rows or empty columns at the end), and there were some workarounds proposed and some ideas for how to possibly fix it. A proper fix would clearly require some API changes, so it would be very nice to get if not a solution but at least some direction for a feasible approach from the core developers, and to create a task for someone to pick up. My idea was to add an optional argument to XGDMatrixCreateFromCSR and to XGDMatrixCreateFromCSC which would allow to override the guessed num_col or num_row. But I am not fully confident right now whether that would be a reasonable way to do it, or whether any more serious redesign might be needed.
Here are some possible workaround options:

From xgboost tree model's perspective, sparse data is equivalent to dense data with missing values. So you can convert sparse matrix to a dense one with with sparse values replaced with NA's (that can blow up your memory).
For predictions with CSC, append a dummy row with at least one value to the end, then just discard the last predicted value.
Append a dummy column with some constant value to the end of all your data (including the training set). That should generally work for both, CSC and CSR cases.

Modifying the C API might affect the other interfaces, especially when adding a new argument. And it is a problem for all interfaces (including C++ command line). That's why I think @tqchen is the one to make decision.
The workaround options are all valid, but each of them brings some problems.

The sparse to dense one, as stated, "blow up your memory".
Adding a dummy row with one value to the end has no memory issue, but I would rather treat it as a dirty hack since we need to maintain the interface carefully to make sure it is consistent in every corner.
Appending a dummy column does not affect the algorithm, it does not affect most of our implementation either. The problem is it reduces the sparsity and slightly slow down the training process. The advantage is the ease of implementation and maintainance of it. On the interface level, I personally think it is the one to go with.

I agree with @khotilov on providing additional information to C API, we can add a new function called XGDMatrixCreateFromCSRV2 that add additional information, and move the API toward this before we removed the old ones completely.
PR will be more than welcomed

https://github.com/dmlc/xgboost/issues/1583


Build nginx image failed in <IP_ADDRESS>,a new deployed environment [REPLACEMENT ISSUE]

The original issue
Id: 1187
Title: Build nginx image failed in <IP_ADDRESS>,a new deployed environment

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @guyingyan on Nov 8, 2019, 07:49
not deploy env issue

In GitLab by @sokril on Nov 8, 2019, 08:20
closed

In GitLab by @sokril on Nov 8, 2019, 08:20
assigned to @cuiaq123


Saving notebook does not auto-select file type

Testing #9768

Thanks. Should be a dupe of https://github.com/microsoft/vscode/issues/147657


Works in other language shouldn't appear in Tibetan.

Can we use the language of the work for the default title? Right now we have multiple works of the same text with the same title in Tibetan like here.
For example this Work is actually in mongolian but appear in Tibetan.
Another option would be to merge all instances of the same work together regardless of the language. What can be done to improve that?

Moved to https://github.com/buda-base/public-digital-library/issues/602

Yes, I agree. For this work it's actually doable because we have a Mongolian title. Unfortunately this is not always possible because the data is sometimes not there... but yes, I'll fix that case (in a few weeks)


Date picker is not allowing selections in KYC flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Join sendMoney and ExpensifyWallet betas
Open new Expensify app with a non-upgraded wallet
Tap/click global create
Tap Send Money
Complete onfido step
Attempt to enter birthdate

Expected Result:
Each part of the date should be selectable
Actual Result:
It's not possible to select dates, as it automatically scrolls off any selection.
Workaround:
No workaround
Platform:

iOS

Reproducible in staging?: Yes
Reproducible in production?: Yes
Notes/Photos/Videos:
https://user-images.githubusercontent.com/22508290/157306043-baae74fa-262c-4ac4-b3c7-e4fdabcb76cb.MP4
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646440679229889
View all open jobs on GitHub

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Moving along. Headsup that, if this can be worked on by a contributor, they'll need to be added to sendMoney and ExpensifyWallet betas

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Applying the External label. I think a contributor can access these features by just overriding the canUseAllBetas function locally.

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Job posted in Upwork -
Interna posting: https://www.upwork.com/ab/applicants/1503218660296941568/job-details
External posting: https://www.upwork.com/jobs/~015f76f91911d63c57

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Current assignee @marcochavezf is eligible for the Exported assigner, not assigning anyone new.

I am not sure how to perform the actions listed because I never get the onfido step. canUseAllBetas() is returning true.

And also if the user is entering birthdate, then he shouldn't be able to select future dates in the first place. However in the video the user only sees future dates.

Thanks, @wahaj-47. I agree steps are not clear. I think we need this https://github.com/Expensify/App/issues/8045#issuecomment-1062416328.
Can I and @wahaj-47 have access to these?

I am not sure how to perform the actions listed because I never get the onfido step. canUseAllBetas() is returning true.
Oh then for this case seems betas should be enabled from backend

Thanks, @wahaj-47. I agree steps are not clear. I think we need this #8045 (comment).
Can I and @wahaj-47 have access to these?
Sure, which are the emails that you guys use for testing?

<EMAIL_ADDRESS>

wahajhssn+test AT gmail.com

Thanks, both added

@wahaj-47 can you provide screenshots or video of what you're seeing?

We also just changed the order of the KYC flow so that onfido is later on. I updated the OP to reflect the new order.

Raised the price to $500

https://user-images.githubusercontent.com/8758774/159443412-1cd1bb39-6842-40ea-9b1e-b9a9130ee190.mov
@kevinksullivan Here you go

I was not able to open this page either. What is the component name?

Sorry, the testing steps were not clear enough @parasharrajat @wahaj-47 . You need to complete the flow by entering a recipient and then tapping Pay with expensify. So you will continue from here and then start to enter information.

Price increase

Don't get the Pay with expensify option either.

https://user-images.githubusercontent.com/8758774/160585962-30b193ad-0b34-4ef1-9849-7e7763b0870b.mov
Managed to get to the 'Additional info' screen and the date picker seems to be working fine.

Still running into the problem on iOS on version 1.1.46-2.
https://user-images.githubusercontent.com/22508290/160696782-32ea0266-b307-44ff-a4a7-c93f5ef662e6.MP4
@wahaj-47 is it possible to change your default currency and test? I agree we are likely not showing you Pay with Expensify because your currency is non-USD

I meant to ask about the iOS Os version.

@kevinksullivan Yes I managed to change the currency and got the Pay with Expensify option.
Here is the screen recording I did where the date picker is working.
https://github.com/Expensify/App/issues/8045#issuecomment-1081670387

iOS OS version is 15.3.21 . If I am alone in this I will close for now, update iOS and see if this changes.


Fix incorrect trailing field offset test

This test started failing in a recent nightly toolchain roll under -Zrandomize-layout. The problem is that #[repr(packed)] does not imply that field ordering in the packed struct remains in lexical order. Switching the layout of the tested struct to #[repr(C, packed)] fixes this.
Local repro (WSL):
$ RUSTFLAGS="--cfg __INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS -Dwarnings -Zrandomize-layout -Zlayout-seed=1" cargo +nightly-2024-05-30 test --package zerocopy --features __internal_use_only_features_that_work_on_stable -- --skip ui

fyi @joshlf

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.71%. Comparing base (b37ad68) to head (dc3f05f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   87.71%   87.71%
=======================================
  Files          15       15
  Lines        5138     5138
=======================================
  Hits         4507     4507
  Misses        631      631

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Fixes #1367


Add a Separate Copyright Policy Page

Hello @anuragverma108 ,
To comply with legal standards and protect the intellectual property rights associated with the content on Skill Wise, I propose the addition of a dedicated Copyright Policy page. This page should outline the platform's policies on copyright infringement, guidelines for content usage, and procedures for reporting violations. This will ensure transparency for users and contributors, reinforcing the platform’s commitment to respecting and safeguarding creators' rights.
Kindly assign me this issue under Hacktoberfest 2024

Assigned!


Lower debounce

Lowering the debounce time will feel like the app is much responsive.
See #156

Coverage remained the same at 89.189% when pulling 8ce3b2801c5e1d8844c0536d5498049ca484f527 on Magellol:lower-debounce into 97c98f9ae52dffb25c15a49ae97092aa645a5331 on vutran:develop.

Set the branch up to date 👍

Coverage remained the same at 89.189% when pulling bcd9ff9147914953c634a36d3db5053166708590 on Magellol:lower-debounce into 775b550651cb3df6a8405e0445b88251a22afe2a on vutran:develop.

I'm good for a merge here. let's go


Send SMS in Dutch when the user has chosen NL as language

This issue is imported from pivotal

https://github.com/OpenConext/OpenConext-myconext/commit/b96d2de70df2cd818f4ec8a60ef42b471b85075e (Okke Harsta - Sep 8, 2022)


Content entity

This PR extracts the logic for dealing with textual vs binary content into a proper content entity.
All kinds of content, including textual content, have a filename, containing the absolute path to the file that contains the content. This is necessary in order for some filters to work: for example, the Sass filter uses it to find items.
This also cleans some related stuff:

Legacy mtime handling (it’s just an attribute, and it should be treated as such).

raw_filename is now part of the content, rather than being part of the item.

Layouts can now theoretically be binary. I don’t think this is particularly useful, but there’s no reason why they shouldn’t be able to. (The filesystem data source still prevents binary layouts from being generated though.)

It might be possible to extend the kinds of content to more than just textual and binary content at some point. For example, parsed XML DOM, or Kramdown internal representation. This seems useful, although probably with only marginal benefits. Out of scope, in any case.

[x] Allow #new_item to specify the full path
[ ] Add tests for content
[ ] Enforce absolute filename

Documentation changes:

#new_item argument :filename
#create argument :filename

My attempt at not refactoring too much before the final 4.0 release isn’t really working out well, but I hope it’s for the better :)


[OpenCLML] Reactor and introduce on chip memory and memory planner

Introduced thread context with CLMLWorkspace.
Organized the code as runtime, utils and memory planners Introcuded recording queue support and on chip memory support. On chip memory allocation planner to acommodate multiple tensors at a time. DDR memory planner introduced to reuse the underlaying memory across multiple tensor descriptors.
Dense layer support refactored to use GEMM.
CLML binary operators doesn't support broadcasting. Hence introduced an explicite broadcast op as a work around.
clml SDK codegen is enhanced accordingly.

Is it necessary to add new tests for memory planner?

We definitely need few test cases. Let me find a way of exposing the plan to verify externally.

Probably you can take a look at the OpenCL tests: https://github.com/apache/tvm/blob/main/tests/cpp-runtime/opencl/opencl_texture_pool_test.cc

@echuraev have you ever built gtests (opencl-cpptest bin) for Android ?

@echuraev have you ever built gtests (opencl-cpptest bin) for Android ?

Yes, I did it. As far as I remember it won't print test results on the host machine, you have to take a look at the log file of tvm_rpc or it is necessary to extend the current implementation. I suppose that the same tests for hexagon can transfer test output through RPC to host.
You can build opencl-cpptest by the following commands:
$ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=${ANDROID_NDK}/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DANDROID_NATIVE_API_LEVEL=android-23 -DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON -DANDROID_STL=c++_static -DUSE_OPENCL=ON -DUSE_CPP_RPC=ON -DUSE_HEXAGON_SDK=OFF -DUSE_OPENCL_GTEST=/path/to/googletests ..

$ make -j8 opencl-cpptest


[Snyk] Upgrade @sentry/react from 7.69.0 to 7.75.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @sentry/react from 7.69.0 to 7.75.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 12 versions ahead of your current version.
The recommended version was released 22 days ago, on 2023-10-25.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (623ea38) 99.74% compared to head (0a1d657) 99.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files         573      573
  Lines        9504     9504
  Branches     2076     2076
=======================================
  Hits         9480     9480
  Misses         22       22
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Language & Internationalization

People outside the United States speak other languages. Sometimes they even write in another script. It happens.
One thing JSON feeds lose without the XML ecosystem is XML's great support for i18n. When processing an JSON feed for end users, language information is somewhat important: for assistive technologies (e.g. pronounciation), for display (directionality of text, other advanced layout), maybe just for filtering multilingual feeds.
item.content_html in theory could carry its own html:lang or xml:lang attribute. But title, description, item.title, item.content_text, item.summary, item.attachment.title and maybe item.tags[] don't have language labeling.
Proposal:

a new key named language (optional, string) which contains a BCP 47 language tag.
the key should be used top-level, item-level, maybe attachment-level and maybe in extensions. Which would put a new, small limit on extensions.
Like for xml:lang and html:lang child elements should inherit their parents language definition unless they define their own.
I would make top-level language required, because I can't think of an feed example which doesn't have some form of human language somewhere. Even commits or server logs or other technical stuff often has language in it.

Also: I never got into the details of the Bidi algorithm. But html:dir and xml:dir exist and seem to fill a need which sometimes seem to be reasonable.

👍 And as I mentioned in #41, hreflang for links would also be interesting in regards to this.
In a multi-lingual world where feeds are not just long articles, but also short micro-blog notes, it could also be interesting to support multiple languages within the content itself, so that one could write the same feed item in both Swedish and English at once. This is something we've discussed in the Microformats world: https://github.com/microformats/microformats2-parsing/issues/3 As this format and the JSON-representation (JF2) of Microformats 2 is very similar, one could take some inspiration from there and maybe even work towards closing the gap between the two.

Not sure why this bug description says "outside the United States". According to the latest (2015) data from the US Census Bureau, over 62 million US residents of age 5 and over, 21% of the total, speak a language other than English at home.
https://factfinder.census.gov/faces/tableservices/jsf/pages/productview.xhtml?pid=ACS_15_5YR_DP02&src=pt

Until an official standard drops, I do this at root and items-level:
"_language": {
  "about": "https://github.com/brentsimmons/JSONFeed/issues/40",
  "language": "en"
}

Hopefully, someday this will be like:
"language": "en"

+1 for this.
RSS had this for the top level , so i suggest to also add this as optional to the top level as well as on the item level. If only given at the top level and omitted at the item level, items should inherit the language from the top level.
Example:
{
	"version": "https://jsonfeed.org/version/1",
	"language": "de",
	"title": "My Example Feed",
	"home_page_url": "https://example.org/",
	"feed_url": "https://example.org/feed.json",
	"items": [
		{
			"id": "2",
			"content_text": "This is a second item.",
			"url": "https://example.org/second-item"
		},
		{
			"id": "1",
			"content_html": "
Hello, world!
",
			"url": "https://example.org/initial-post",
			"language": "en",
		}
	]
}

Rereading a year later: My proposal has of course a deficit: What happens when for example item.title is in french and item.text_content in english? What should item.language be?
XML of course solves this by allowing xml:lang on every element.
JSON-LD solves this in multiple ways, the easiest seem to be value objects, resulting in language-tagges strings.

Thanks y'all. I'm going to close this because I think there has been more discussion in #62.


Light Mode

Add the ability to toggle to light mode (or customise the theme in accordance with the rest of HA).
In order to implement this, we just need to pass 'light' vs 'dark' into here through some ui button or an environment variable that can also be passed through addon parameters.
https://github.com/asosnovsky/Shortumation/blob/main/webapp/src/components/Page/index.tsx#L18-L22

This is done in v0.7


[Not4review] Run antrea policy e2e test on Win

Signed-off-by: wgrayson<EMAIL_ADDRESS>

/test-windows-e2e

/test-windows-e2e


Change default ip for dev server from <IP_ADDRESS> to *

This provides support for ipv6 with wrangler dev
Fixes #3732
Author has addressed the following:

Tests

[ ] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[x] Included
[ ] Not necessary because:

Associated docs

[ ] Issue(s)/PR(s):
[ ] Not necessary because:

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@Cherry After discussing with the team we thought it would be best to remove the ipv6 addresses from the printout
That will require a change in miniflare so this PR is blocked until that is released


Update manage-creation-of-groups.md

Changed  value to $true in step 2
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/13040

@JohanFreelancer9 Please copy review

@MikePlumleyMSFT Please merge this PR. Thanks


fix(linter) fix false positive for erasing-op in 0/0 case

Current dependencies on/for this PR:

main

PR #2009   👈

This stack of pull requests is managed by Graphite.


Develop branch doesn't work

Please check latest version of develop

It seems like it stopped to work after the last commits from Saturday. I've got a version from the end of the Friday and it's fine. From the message from @szafran89 it seems like it maybe somehow connected to
https://github.com/DivanteLtd/vue-storefront/commit/1f569054b73d9412e934fe25985c41e70026b66b
I'm not sure if mixins shouldn't have been a array (in this commit it's an object)

My fault, mixins should be an Array.


Remove requirement for unique gateway in route table

It's an incorrect assumption that there's only one network behind a gateway. It must for example be possible to route several networks through VPN gateway.

If you remove this validation and have a route table with multiple gateways, does puppet resource ec2_vpc_routetable report the correct gateways, or does it only report a single gateway? If puppet can't understand multiple gateways somewhere else in the module then this failure could be just to safeguard against other more obscure failures or non-idempotent puppet runs.
Thanks!

@zvymazal Would you mind coming back to address the question here please?

Hi @zleswomp, I believe it behaves correctly with multiple gateways because that's how we used it, but unfortunately I'm not working on that project anymore and cannot confirm on 100%.

This seems like a good change.  I don't know how to validate it though.

This may have been taken care of with my PR #505


MH-13643: Update to Paella 6.1.4

@miesgre, 6.1.5 has been released. Do you want to upgrade Paella straight to the new version? Or do you want to stay with 6.1.4? Also, is it really necessary to push the upgrade to our legacy version? Does it fix something important? Otherwise, I would tend to send the upgrade to 7.x. But I'm not very familiar with Paellas releases, so it may make sense?

@lkiesow I updated the PR with paella 6.1.5.
Paella 6.1.4 fixes some problems with the audio that is played.
We detected a bug in our opencast installation (https://opencast.jira.com/browse/MH-13644). To fix it, paella need to be fixed and also the opencast adapter.
We split it in two PR: One to update the paella (#979) and another to fix the opencast adapter (#980)
Paella 6.1.5 solves some problems with the "es.upv.paella.breaksPlugin" plugin and it is not urgent as I think we are the only ones using that plugin.
If you have tracks with and without audio, I recommend you to apply this PR and also (#980). If all your tracks have audio, it is not urgent to upgrade.


Stabilize Alternative Registries

This includes a few minor changes besides stabilizing:

cargo search won't display crates.io search URL for extra results for non-crates.io registries.
Document using environment variables for API tokens.
Explicit section in config.md for documenting the credentials file.

Closes rust-lang/rust#44931
Closes rust-lang/crates-io-cargo-teams#21
Closes #6589
Closes #4688

@bors: r+

:pushpin: Commit 902885c392c419e823099b1eb7a4c5f5f4385dc1 has been approved by alexcrichton

:hourglass: Testing commit 902885c392c419e823099b1eb7a4c5f5f4385dc1 with merge 2e4cfc2b7d43328b207879228a2ca7d427d188bb...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 2e4cfc2b7d43328b207879228a2ca7d427d188bb to master...

this seems great. So can I use rust with artifactory now?

For artifactory support, please vote for the feature request here: https://www.jfrog.com/jira/browse/RTFACT-13469

yeah ! ;-)


modules: Kconfig.simplelink: Remove POSIX_API from being selected

PR #18780 introduces a way to decouple pthread support from the general
CONFIG_POSIX_API global switch. This commit modifies the build of
SimpleLink components to take advantage of it, since SimpleLink
libraries only require pthread (and sem) support, not entire POSIX.
This fixes the build errors in the http_get sample introduced
by the merge of #18736.
Signed-off-by: Vincent Wan<EMAIL_ADDRESS>

Note that this PR is contingent on #18780 having been merged first, and should not be merged on its own.

Closing this as the change has been grouped into #18780.


Cloud workstations - add links to core filer verification doc

Adds links to cache policy documentation in the Avere Configuration Guide in the TF cloud workstation examples

I think the changes from June are because I need to rebase. But they're already in so it's not relevant.

I resolved the conflicts but now there's a failed check. I don't know if that's important since this is just a doc file.


Added Win 2K8R2 prerequisite of .NET Framework 3.5.1

Only Win 2K8R2 requires .NET Framework 3.5.1 installed that is not normally always installed on all servers.

Hi @animetauren, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@rayne-wiselman - Could you review this update proposed in the public repo by @animetauren - thanks. Note that the scope/type of contribution means this should be pulled over to the private repo for validation and staging if you decide it should be merged.
You can use this command from your private local branch to pull the content of this PR over:
git pull https://github.com/animetauren/azure-content.git patch-10

@animetauren @rayne-wiselman Henry, thanks for the contribution. I'll merge this now.


The status at the end of the PeopleList & RoomsList is displayed abnormally.

There is a bug #175
When there is no cache for the first time (I deleted the .local/share/robrix dir), the number of People and Rooms is displayed as zero.

Only at the first time.
They two status can be displayed normally when the dir (.local/share/robrix)  exists matrix caches.

sorry, can you clarify or provide a screenshot? I assume you're talking about the status label in the RoomsList?

No need to look at this, I have closed my pr, excuse me : ), I will close this issue later : )

I'm unable to reproduce this; feel free to re-open when you can demonstrate the problem.

I'm unable to reproduce this; feel free to re-open when you can demonstrate the problem.

That's ok, please reopen this: )

Sorry I missed your comment! I'll re-open this.

Can you kindly provide different instructions on how to reproduce this? The presence of the app data directory does not seem to have any affect here.
Perhaps this is a Makepad problem on a particular platform? Which platform do you experience this on? I can't seem to repro it on macOS at least.

ok so i was able to reproduce this but not based on the conditions you shared above. Interesting!
So far it just seems to occur randomly, but it should be easy to diagnose.

I am looking at this.


Prevent non-docs stages when a PR only modifies docs/

This is an intermediate fix for #8673.
It modifies Jenkinsfile to prevent non-doc related stages from running when only modifying in docs/.
The idea is to save some CI cycles and speed up the process of augmenting docs.
@areusch @comaniac @tqchen

Thanks, @mikepapadim. I agree that it is important to save the CI time.
However, tutorials may be changed even though the codes in docs/ are not changed. For example, when we change the printer(files in src/ and include) may still change the document. These changes are not often happened but they do exist.

@mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:

whenever a change only modifies docs/, we skip all build, unit test, integration test steps

as @Hzfengsy said, we shouldn't ever skip these nodes:

Sanity Check (this should already be correct in the patch now)
BUILD: GPU
docs: GPU

i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when changeset "docs/**" doesn't match). i'm not entirely sure how to do this.

@mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:

whenever a change only modifies docs/, we skip all build, unit test, integration test steps

as @Hzfengsy said, we shouldn't ever skip these nodes:

Sanity Check (this should already be correct in the patch now)
BUILD: GPU
docs: GPU

i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when changeset "docs/**" doesn't match). i'm not entirely sure how to do this.

Yes, right now the changeset condition is in the stage scope, I will have another look on how to make use of it in node scope.


Remove analyzer warnings

Fixes issue #47

There are other warnings in the code also @guyluz11. Have you checked @JSmurf ?


mixed mode CPU + GPU

We are considering an implementation of Convolution Neural Network in which some layers will run on CPU while other layers will run on GPU
As I understand, for running on CPU we need to build the ComputeLibrary with neon=1 and opencl=0, while for GPU we have to set neon=0 and opencl=1 - is this right ?
If so, we would need to build 2 different copies of ComputeLibrary, with those 2 different settings; will it then be possible to link those 2 copies together with our code ? Or would we expect double or conflicting definitions ?

No, you can build a single library with both neon=1 and opencl=1. You can then use the NE* functions to execute code on the CPU and the CL* functions to run on the GPU.
To share Tensors between CPU and GPU they need to be CLTensors and when they are used with Neon functions they have to be mapped (and unmapped).

Thanks !


docker conbee1 "not connected" after update

Hello I pulled the latest image for my marthoc/deconz for the first time in a while.
My phoscon app is now 2.05.71 from nov 17th 2019 but after the update my conbee1 is now listed as not connected.
I start the container with the following command:
docker run -d --name=deconz --net=host --restart=always -v /opt/docker/deconz:/root/.local/share/dresden-elektronik/deCONZ  --device=/dev/serial/by-id/usb-FTDI_FT230X_Basic_UART_DM01DVB5-if00-port0 -e DECONZ_VNC_MODE=1 -e DECONZ_WEB_PORT=8080 marthoc/deconz
And when I list /dev/serial/by-id i see that very same device right there.
Any suggestion what to try?
Thanks in advance.

Can you try --device=/dev/ttyUSB0
According to the setup guide

by default ConBee = /dev/ttyUSB0, Conbee II = /dev/ttyACM0, RaspBee = /dev/ttyAMA0 or /dev/ttyS0

This should work, and I know many others have set up their device mapping with the by serial id.

In some case, for example on synology, the mount point of USB change (especially if there is more than one usb device)
And on Synology udev deamon not work by default, i have make PR for add this feature for my synology https://github.com/marthoc/docker-deconz/pull/197

Closing this given the age of the issue, please open a new issue if this is still relevant.


[Feature]: Update save flow of datasource config

Save datasource config

Add all the variable names to the datasource dynamic binding list
Need to add any relevant notifications on save actions

Not a duplicate, has different functionality


Enable passing WebSocket handler instances.

Added a Spark.webSocket() method which accepts a handler instance
instead of a class. See issue #367.

This is a quickly hacked up change I made and very briefly tested. Definitely needs to be reviewed by someone "in the know" and properly tested.

Looks good. Will review it more thoroughly ASAP.

This would be really awesome to have! I'm currently running into this issue.

I've looked a bit more into the code. The whole WebSocketCreatorFactory and WebSocketCreator thing does seem like unnecessary complexity, but since the latter is required by Jetty, there isn't that much to be achieved by refactoring. Also, my changes don't change thread safety of the web socket handlers: they are instantiated beforehand (at ignite before the changes and immediately after my changes) and the same instance serves all requests to the path.

Hi,
I encount the same issue. I need to have interaction with other collaborator of my WebSocket instance which need to get arguments in it.
Thanks for your help.

It looks like this didn't get merged? (not seeing it in spark-core:2.5). Why not?
It would be really useful to specify the instance of the websocket handler instead of the class (in my case, this instance is injected by Guice so I want to pass my own instance instead of Spark calling newInstance() on the class.

I drew the conclusion that contributions are not welcome after my PR was in limbo for four months or something to that effect. Closed the PR.

That's unfortunate :-(


[Fabric] - Bug/Issue

Describe the issue
I just downloaded the newest version of NetheritePlus (1.4.4. for Fabric) because it said I needed the latest one. Upon starting the game it crashed immediately. I'm using Fabric 0.11.3 for 1.16.5. And I was using NetheritePlus in my own private Modpack, which has ~130 more mods.
crash-2021-05-21_21.44.19-client.txt
To Reproduce
Maybe adding the same mods as me, maybe there are some compatibility issues...
Expected behavior
The game to start like normal.
Screenshots

Thanks for the help!
-mariokirby1703

try without optifine


New Linter: yamllint

Hello!
I added support for yamllint. You can find it in here: https://github.com/aslafy-z/reviewdog-yamllint-action.

Cool! Do you want to move the repo under reviewdog org and/or release the action?

I'm okay to move it under reviewdog org!

I invited you to reviewdog org, so please feel free to move the repo. (I'm actually either is fine. You can maintain it under your account too.)
Probably you should not use "fork" because github cannot fork the same original repo more than once.
e.g. If a user forked reviewdog/action-eslint before, the user cannot fork aslafy-z/reviewdog-yamllint-action as different repo because they already forked the original one.

Also, can you clean it up a bit more? e.g. Screenshot still uses eslint.


KEB - support bulk Kyma upgrade

Description
Next iteration for Kyma upgrades by KEB. Besides main bulk upgrade feature, KEB will get some additional small improvements, see AC.
Reason
Operators will be able to upgrade all Runtimes in easy way.
AC

findings from MVP implementation

fix current database design how we store runtimeOperations. Right now we are forced to fetch all operations for given orchestration. When we will want to implement paging or filtering that will be big issue.
renew processing orchestration when KEB restarts
persist every change on operation immediately (not at the end, when we can lose data when KEB restarts)
process only one Orchestration at time
refactor RuntimeOperation and UpgradeKymaOperation to somehow create only one object

implement bulk upgrade, include#target "all"

add swagger console into root KEB URL

improve swagger details. Describe all values (fixed ones) of statuses etc.

implement /orchestration/id/operation/id which will have additional information, like overrides etc

encrypt all data persisted by KEB ( including overrides (input for upgrade)).
maybe whole KEB DB data should be encrypted
encrypt existing data

parallel strategy implementation

support time windows for upgrade (Check if we for sure should use gardener maintenance window)

GET /runtimes - extend upgrading field with upgradeHistory list (every item has own createdAt)

put infomration about orchestration id (to find deatils about given upgrade)

adjust documentation with all new features (new scopes like runtimes:read, /runtimes endpoint too)

/orchestration endpoint (a list of orchestrations) does not return runtime operations which is available in /orchestration/id endpoint

test bulk upgrade with few real clusters

Linki

previous MPV Story - https://github.com/kyma-project/control-plane/issues/118

Next iteration

filtering options for example: succeded etc
ability to cancel pending orchestration

consider cancel in progress orchestrations (with strategy still check all in progress operations)

update orchestration (probably we should never support that)
check how often gardener has maintanence windows (is that up to customer? I guess not)

Hi @PK85 @piotrmiskiewicz ,
Swagger UI might not be needed as we are about to start developing an SKR CLI for operators, which will be our primary tool for interacting with the exposed API

Proposed example of an entry in /runtimes endpoint:
{
      "instanceID": "7690d256-7278-433a-a0e1-69eba2291ea9",
      "runtimeID": "95e75083-9178-4600-8dc9-05e8c16ecb2c",
      "globalAccountID": "3e64ebae-38b5-46a0-b1ed-9ccee153a0ae",
      "subAccountID": "39ba9a66-2c1a-4fe4-a28e-6e5db434084e",
      "subAccountRegion": "cf-eu10",
      "shootName": "c-3b71f0c",
      "serviceClassID": "47c9dcbf-ff30-448e-ab36-d3bad66ba281",
      "serviceClassName": "kymaruntime",
      "servicePlanID": "4deee563-e5ec-4731-b9b1-53b42d855f0c",
      "servicePlanName": "azure",
      "status": {
        "createdAt": "2020-09-10T15:30:46.681994Z",
        "modifiedAt": "2020-09-10T16:15:47.541435Z",
        "provisioning": {
          "state": "succeeded",
          "description": "Operation created : Operation succeeded"
        },
       "deprovisioning": {
          "state": "succeeded",
          "description": "Operation created : Operation succeeded"
        },
        "upgradingKyma": [
           {
              "state": "succeeded",
              "description": "Operation created : dry run succeeded"
               "createdAt":"2020-09-10T16:15:37.541435Z"
               "orchestrationID: "4faa67aa-5d65-4097-b0e4-084e2b94be0e"
           },
          {
              "state": "succeeded",
              "description": "Operation created : dry run succeeded",
              "createdAt":"2020-09-10T16:15:47.541435Z",
              "orchestrationID: "3bbcd349-6c8b-440e-9d4c-d86d1d52d894"
           }
        ]
      }
    }

Yes, filter out dryruns

Idea:
"upgradingKyma": {

           "data": [{
              "state": "succeeded",
              "description": "Operation created : dry run succeeded",
               "createdAt":"2020-09-10T16:15:37.541435Z",
               "orchestrationID": "4faa67aa-5d65-4097-b0e4-084e2b94be0e",
               "operationID": "5ac1846a-22fa-4d89-9ab1-bb4a0ed08510"
           },
          {
              "state": "succeeded",
              "description": "Operation created : dry run succeeded",
              "createdAt":"2020-09-10T16:15:47.541435Z",
              "orchestrationID": "3bbcd349-6c8b-440e-9d4c-d86d1d52d894",
              "operationID": "e80507bb-07b7-45bc-9005-939f999d09d0"
           }
],
 "count": 0,
  "totalCount": 0
        }


Update typescript definition

The compiler was complaining:
xxx/node_modules/dayjs/index.d.ts(73,3): error TS7010: 'isSame', which lacks return-type annotation, implicitly has an 'any' return type.
xxx/node_modules/dayjs/index.d.ts(75,3): error TS7010: 'isAfter', which lacks return-type annotation, implicitly has an 'any' return type.

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #120   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         196    196
  Branches       32     32
=====================================
  Hits          196    196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986f117...29f7fe8. Read the comment docs.


torch_geometric installation

Great work!
Trying to reproduce your results, and having some difficulty installing torch_geometric with torch1.4 and cuda10.1
Could you share your environment yml file or setup.py with the package versions?
Thanks :)

Thanks for your interest in our paper.
It seems that the latest version of torch_geometric is not compatible with torch1.4 and cuda10.1, but you can use torch 1.8.2 and cuda 11.1, which support the latest version of torch_geometric.
If you are interested in our environment.yml file, you can download it here


speed up mouse move

improves or even fixes #23
I’m not sure if this is a good approach or even works as intended, but it dramatically increases responsiveness for me. Also it probably leaks all those MouseEvents because I can’t C++.
I call the idea “Sith threads”:

Two there should be; no more, no less. One to embody power, the other to crave it

One thread is running, the other queued. If the mouse is moved, the queued one is replaced by a new one. Once the running one is finished it will replace itself with the queued one.
This has an advantage over the “don’t run if last run is less than 100ms in the past” approach commonly used to “debounce” javascript, because this way after stopping the mouse, the correct update (the one triggered by the last event) will happen.

your fix is still laggier than mine. let’s combine them.
should i do another PR or will you include it?

Is it?  I'm not seeing any lag at all on Windows 10 or Ubuntu.

for me it still needs some fractions of a second after stopping the mouse until the statusbar arrives at its destination.
heavy mouse movement makes that half a second or so, which is annoying.


GSoC 2020 Idea: Interactive tutorial for GraphQL query syntax

I have an idea for a project that is more related to GraphiQL: an interactive tutorial for writing queries
Something like that https://dev.to/methodcoder/graphql-crash-course-in-10-pics-3b04
But as an interactive GraphiQL based tutorial with some challenges where you need to write some queries yourself.
It would be a good app to test plugin APIs and also useful for people who just want to quickly learn graphql syntax.
I have almost zero knowledge of the front-end side so I can’t realistically mentor it :disappointed: so I post it here in case anyone wants to adopt it.
CC: @acao @orta

great idea! GraphiQL 1.0.0 stable will support compositions like this as a goal

Yeah, this is a cool interactive way to learn

@acao @orta Do you want to adopt this idea as mentors?
I can help with brainstorming but have zero knowledge of front-end so I can't review code.

I can help with the code reviews if that's what is needed.
./Tanay
On Thu, 6 Feb, 2020, 12:43 PM Ivan Goncharov<EMAIL_ADDRESS>wrote:

@acao https://github.com/acao @orta https://github.com/orta Do you
want to adopt this idea as mentors?
I can help with brainstorming but have zero knowledge of front-end so I
can't review code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/graphql/foundation/issues/10?email_source=notifications&email_token=ACN6LH2IR7LQBQCWLOR5QA3RBO2BPA5CNFSM4KQFHDT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6FQKY#issuecomment-582768683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACN6LH64JGVSPO4KURDIBY3RBO2BPANCNFSM4KQFHDTQ
.

Hii @IvanGoncharov that's a great idea.  I would add love to add something to it. Should we make something like AWS API Gateway, It would help the users to get more insight into graphQL. I would love to help you in frontend as well as backend support.


busybox: add logger for runit

Currently all runit services just spam the tty on boot, and logs aren't stored anywhere. I use the following script to enable logging on my server:
#!/usr/bin/env sh

LOG_BASE="${1:-/var/log/sv}"

# /etc/sv/$sv_name/log
sv_name="$(basename "$(realpath "$PWD/..")")"
logdir="$LOG_BASE/$sv_name"

mkdir -p "$logdir"
exec svlogd -tt "$logdir"

Enabled per-package with another script:
#!/usr/bin/env sh

set -eu

SV="$1"

SVBASE="/etc/sv"
RUNBASE="/run/runit"
LOGDIR="$SVBASE/$SV/log"

[ ! "$SV" ] && exit 1
[ -d "$SVBASE/$SV" ] || exit 1

mkdir -p "$LOGDIR"
ln -sf "$SVBASE/logger" "$LOGDIR/run"
ln -sf "$RUNBASE/supervise.$SV-logger" "$LOGDIR/supervise"

Should we include something like this in the default busybox package or is it better suited for community?
ping @illiliti @ioraff

I think something like this should be included in the busybox package

It's good idea and I agree with ioraff. However, we need to sort out realpath usage first.

https://codeberg.org/kiss-community/repo/issues/82


pretrained weights ?

Dear @hcw-00 ,
I want to test your great work. Can you provide the pretrained weights ?

Hi. It will takes just few minutes to train a category. But if you need plz tell me which categories you need. not all.

Hello. Thank you for your interest.
It would take around 10min. to train a category.
But if you tell me I can upload some pretrained weights. not all.
Just tell me which categories you need.
Thanks.
and don't forget to click star button :-)
2021년 5월 28일 (금) 오후 5:43, trungpham2606 @.***>님이 작성:

Dear @hcw-00 https://github.com/hcw-00 ,
I want to test your great work. Can you provide the pretrained weights ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hcw-00/STPM_anomaly_detection/issues/6, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJOPRDNA3DZK5OEYNT4ISUDTP5JSLANCNFSM45WCMCBQ
.

I uploaded on weights directory.


Crash when backspacing link and adjacent text

Steps to reproduce

Select a whole link and some adjacent text on the end
Ensure there is text either side of the selection
Press backspace
Crash

Failing test
#[test]
fn backspace_link_and_adjacent_text() {
    let mut model =
        cm("before{linkadjacent}| after");
    model.backspace();
    assert_eq!(restore_whitespace(&tx(&model)), "before| after");
}

Crash log
thread 'tests::test_deleting::backspace_link_and_adjacent_text' panicked at 'Adjacent text nodes found! handle: DomHandle { path: Some([0]) }

├>"before"
└>" after"
', crates/wysiwyg/src/dom/dom_invariants.rs:98:25

Screen recording
Tested on Android sample app based on main@d9dd8f6.
crash-link.webm

I did a git bisect and found that it is an old bug introduced in one of the following:
05080fb6 (refs/bisect/bad) Prevent crash when merging text nodes (#366)
128110ae (refs/bisect/skip-128110ae46840501eec8db59ef95d21b7af352fb) Merge adjacent text nodes in do_replace_text_in (#362)
51ca6c9e (refs/bisect/skip-51ca6c9e8edb1f83066a2643b8d03d16dd9ed630) Join any adjacent text nodes we create in remove_and_keep_children (#361)
bfa7eb2e (refs/bisect/skip-bfa7eb2ea3ccefc62425b6b6bf1fdeff747dd531) Assert invariants test deleting (#360)
c9b8a36b (refs/bisect/skip-c9b8a36b201408a080de5ed3add82ada4c2113b6) Ensure replace_text does not leave empty text nodes (#359)


Disable location based settings when location permission is denied

Closing this because the manual calibration handles this with fallbacks


[EPIC] Improved Externalized / Spilling / Out of core Hash Aggregation

This is a collection of items to improve external (spilling) aggregation
Background

Abstract—Analytical database systems offer high-performance in-memory aggregation. If there are many unique groups, temporary query intermediates may not fit RAM, requiring the use of external storage. However, switching from an in-memory to an external algorithm can degrade performance sharply

Robust External Hash Aggregation
in the Solid State Age (DuckDB external aggregation paper))

DataFusion has supported memory limited / spilling hash aggregation since @kazuyukitanimura added it last year in https://github.com/apache/datafusion/pull/7400.
We can likely improve this feature and @2010YOUY01 is considering working on it
Tasks the solution you'd like

[ ] https://github.com/apache/datafusion/pull/13090

@2010YOUY01  says in https://github.com/apache/datafusion/pull/13090#issuecomment-2437436375

Really nice paper, we can implement the same benchmark and compare in the future 😄 They implemented a unified buffer pool for both table data cache and operator (like aggregation) intermediate results, to easily support spilling in various operators. I think they didn't mention any optimization specific to the spilling part of aggregation, and just use simple LRU policy in the buffer pool. Maybe there are some spilling and merging specific optimizations we can explore (all of memory-limited aggregate/SortMergeJoin/Sort can benefit from)

DF doesn't have a buffer pool in the traditional sense, and the way arrow-rs allocates memory directly from the system allocator makes it quite hard to implement. However, I think the fact that we have arrow-rs and the arrow IPC offers lots of opportunity.

Also, are you interested in improving DataFusion's external aggregation capabilities? I think it is a non trivial gap at the moment and would be great to improve (and I would be interested in helping do so).
if you are, I can start organizing the work into some tickets to see if we can get some others to check it out too

Yes, I'm start to look at related components now. Perhaps we can start with making memory-limited SQL queries more stable (e.g. more tests, make sure TPCH-SF1000 is able to run on laptop correctly), and later optimize.

I think starting with stability and then optimizing is a great idea 💯
Note that one challenge of TPCH specifically is that it contains many joins and is largely focused on that, so in order to run TPCH-SF1000 we would also need to implement spilling joins
Another potential option would be to work on running clickbench with a very small memory (100MB)?
Or maybe we could figure out another large dataset 🤔

Note that one challenge of TPCH specifically is that it contains many joins and is largely focused on that, so in order to run TPCH-SF1000 we would also need to implement spilling joins

Maybe @comphead 's work to get SMJ working in  https://github.com/apache/datafusion/pull/13111 will help this (e.g. we could always use SMJ for the large TPCH queries 🤔 )

Another potential option would be to work on running clickbench with a very small memory (100MB)?

This is a good idea, we should get clickbench work under memory constraints before TPCH


Using uninitialized "skipcache" variable

The Nginx log contains frequent entries like the following at a Beach instance with FastCGI cache enabled:
 [warn] 55#55: *29 using uninitialized "skipcache" variable, client: … server: , request: "GET …

Fails with
nginx: [emerg] unknown directive "else" in /opt/flownative/nginx/etc/sites-enabled/site.conf:54


[e2e]: gradle workflow_dispatch main project-at-repo-root slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/12355352787
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Dec 16 15:05:55 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/12375631823
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Dec 17 15:06:30 UTC 2024
Tests are passing now. Closing this issue.


Update generated and support byte arrays in image2tensor

You can now convert image bytes to tensors directly without having to load from a file.
I also updated the generated code for WebAssembly/wasi-nn#36, but if testing locally keep in mind that branch name needs to be updated in the generation script.

Superceded by #88.


Interpolate placeholders in table keys

This change adds placeholders support for table keys. This functionality is useful when there is needed to parameterize table data key names in scenario outline.

I'll release this soon.


This version of the Android Support plugin for IntelliJ IDEA (or Android Studio) cannot open this project, please retry with version 4.2 or newer.

Current Android Studio is 4.0 stable channel.  I have also tried in Canary Channel but when i check for updates it doesn't shows latest one.

Just try to downgrade your gradle version in the buildSrc/build.gradle.kts to at least 4.0.0 and  sync the project.
That should solve the issue


Remove Val::Undefined

Objective
Val::Undefined is unnecessary and very confusing.
Currently, it's used to represent a lot of different things in Bevy depending on the context.
The details, as I understand them:

CSS  doesn't have "undefined" values. Only auto.

Undefined is Val's default variant.

UiRect defaults to Val::Undefined

The Size defaults were changed to Val::Auto in #7475

For the width and height of size in Style, Val::Undefined is equivalent to Val::Px(0.) and Val::Percent(0.)
(except with text nodes because the implementation is incomplete. With a complete implementation, they would be equivalent).

For the width and height of min_size and max_size, Val::Undefined is equivalent to Val::Auto. This behaviour is different from size because otherwise when Val::Undefined was the Size default every node would have been constrained to a zero size by default.

When UiRect is used to represent positions, Val::Undefined is equivalent to Val::Auto. Positions are either specified explicitly by the user or determined automatically by Taffy. There are no undefined positions.

When UiRect is used to represent margins, Val::Undefined is equivalent to Val::Px(0.) and Val::Percent(0.). This difference from positions is because a position of zero still represents a position, a margin of zero is not a margin at all.

When UiRect is used to represent padding or borders, both Val::Undefined and Val::Auto are the same as Val::Px(0.) (no padding or borders). Unlike with margins, there is no concept of auto borders or padding.

The Taffy equivalent Dimension::Undefined has been removed in Taffy 3 without problems.
related issues: #7120, #5513
Solution
Remove the Undefined variant of Val.
Change the UiRect default values to Val::Px(0) (no margin/border/padding).
Remove the position field from Style, and replace it with separate left, right, top and bottom fields.
Set the default value for left, right, top and bottom on Style to Val::Auto.

Changelog

Removed the Undefined variant of the Val enum.
Changed UiRect::default() to set all fields to Val::Px(0.).
Added left, right, top and bottom fields to Style with default values of Val::Auto.
Updated the UI examples to reflect new changes.

Migration Guide

Val::Undefined has been removed. Bevy UI's behaviour with default values should remain the same.
The default values of UiRect's fields have been changed to Val::Px(0.).
Style's position field has been removed. Its left, right, top and bottom fields have been added to Style directly.
For the size, margin, border, and padding fields of Style, Val::Undefined should be replaced with Val::Px(0.).
For the min_size, max_size, left, right, top and bottom fields of Style, Val::Undefined should be replaced with  Val::Auto

I am on board with removing Val::Undefined in favor of more explicit constructors. I need to review this PR in more detail though. Note that Cart previously expressed opposition to the Inset name, so we should consider avoiding that here.

I am on board with removing Val::Undefined in favor of more explicit constructors. I need to review this PR in more detail though. Note that Cart previously expressed opposition to the Inset name, so we should consider avoiding that here.

np, changed it to Position. I really didn't want to include changes to Style in this PR at all, but the requirement for different defaults made it unavoidable.

I really didn't want to include changes to Style at all, but the requirement for different defaults made it unavoidable.

When I made the equivalent changes to Taffy I just removed the default values for the individual field structs (what in bevy would be UiRect, Val, etc) entirely in favour of just having a default implementation on Style. Although we did add style helpers at the same time. IMO:
position: UiRect { top: px(0.), left: px(0.), bottom: px(10.), right: px(15.) },

is much nicer than:
position: Position(UiRect {
   bottom: Val::Px(10.),
   right: Val::Px(15.),
   ..Default::default()  // left and top set to Px(0.), not Auto
}),

It would also be possible to make the style helpers accept integers which would give you the even nicer:
position: UiRect { top: px(0), left: px(0), bottom: px(10), right: px(15) },

Oh, that's got me thinking.. unlike all the other fields like margin or size, you almost never want to set all four position values and I've always felt it's kind of annoying having them grouped together when you normally only ever set two of the fields.
Instead, we could just have the 'left, right, up, and down, fields on Style`, and then like you say there's no problem with the default implementations.
Like I think
Style {
    left: Val::Px(10.),
    top: Val::Px(15.),
    ..Default::default()
}

is a lot more ergnomic than:
Style {
    position: Position {
        left: Val::Px(10.),
        top: Val::Px(15.),
        ..Default::default()
    },
    ..Default::default()
}

Indeed. I think my ultimate endgame is to have a builder for Style so you can do something like:
Style::new()
    .left(Val::Px(10.))
    .top(Val::Px(15.))

At which point the internal representation doesn't matter.

and you could even combine the variant helper functions into the interface, like:
Style::new()
.left(10.)   // instead of `Val::Px(10.)` as its more common
.top_percent(15.);

Or even have the chained builder functions take an impl Into argument, and implement Into for f32 into Val::Px

Yeah, that one would be ideal. It would be great if you could also do thing like .left(10.percent())

Would there be any drawbacks to just including Val::Px and Val::Percent in the prelude?

Would there be any drawbacks to just adding Val::Px and Val::Percent to the prelude?

May be a bit unclear / implicit. I think it's likely worth it: I import them for my UI projects regularly. And Option/Result use the same pattern.

Some of the doc comments need to be rewritten for this, I haven't worked on them yet because there might still be more changes to be made that would need to be reflected in the documentation.
I've only made the minimum changes to the examples (except ui.rs) to keep them working as before. I've made sure that each one still functions identically to main, but there are a lot and they all required changes, so it's possible I missed something.
With /examples/ui/ui.rs I made significant changes, and this is where to look to what impact this has. With this PR, the changes from my two Size PRs and improving my understanding of where the Style properties can be elided, I was able to eliminate about 20% of the styling code for this example.

Appreciate the clarifications. A lot of my knowledge comes from working backwards from Bevy UI to CSS, so I have a lot of gaps.
Agree with you that an Option<Val> seems like the right approach if some sort of undefined values are needed in the future.

A lot of my knowledge comes from working backwards from Bevy UI to CSS, so I have a lot of gaps.

I would recommend MDN as a reference e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/width

I think UiRect having a default of zero is confusing conceptually, but this is more because of the name: It doesn't represent a rectangle, but more a border around a rectangle. Anyway, this is kind of a naming issue separate from this PR.

Frame seems like the best idea for a renaming, if we go that way. Geometrically it communicates the right concept.
My proposal is #7710 which replaces UiRect with separate Margin, Padding and Border structs generated with a macro.
The other option is builder methods on Style, nicoburns just put in a PR #7881 implementing some. I don't dislike that idea either and both #7710 and #7881 could coexist. But I think builder methods might be controversial and end up blocked a long time.

I've little understanding of Bevy internals, but as long as UiRect is used for margin, border, padding it should be fine (?). I have a hunch that if it was used for position, the default 0px would give problems with absolute positioning.

Margins need to be separated from borders and padding too. There's no sensible way for padding and border values to be inferred by the layout algorithm, so it makes no sense for them to have an Auto variant.
The problem for positions is that 0px is still a valid position, whereas for a margin (or the others) a 0px value represents that margin not being present at all.

There's no sensible way for padding and border values to be inferred by the layout algorithm, so it makes no sense for them to have an Auto variant.

There actually is a sensible interpretation of "auto" padding. Which would be that the auto padding of a container takes up a share of the same space that the auto margins of it's children do. I am considering adding opt-in support for this to Taffy, because it is similar to way in which morphorm layout works. But CSS does not allow this, so it may well not make sense to enable such support in Bevy.
In any case, this wouldn't be the default value for padding, so the problem would remain that the default for margin/padding/border needs to be 0px while the default for inset (aka position) needs to be auto.

Could this PR cause issues when defining the size via flex grow/shrink/basis in conjunction with height: 100%? In this case, what would be the value of width? Auto?
I'm saying this because width/height are joined in size: Size. Maybe it makes sense to split size?

In this case, what would be the value of width? Auto?

Yes, it should be auto. Which is it's default value in CSS (see https://developer.mozilla.org/en-US/docs/Web/CSS/width).

I'm relieved to see this gone. Good work, and excellent reviews.


Localize collectible behavior

Right now, there is a collectibleBehavior section in the gameplay.json file. The idea is simple - to remove that section and make different acceleration and speeds possible with each collectible.

Implemented: https://github.com/jakubg1/OpenSMCE/commit/c6e0867c0ae157e9df8823ccfebf65ad56c5d40c


Link previews and styled components

Summary
This is a multi-function PR.

It is a demo of styled components
it is a re-write of open-graph attachments
it adds bootstrap-4 (namespaced by prepending bs4- to classes)

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Has UI changes

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0a5d3bec7aed2419a.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0a5d3bec7aed2419a

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0e70bdf3d22af8b04.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0e70bdf3d22af8b04

I don't understand why spinmint isn't working. If you can get it working, try adding some links that generate open graph previews.
Ex.

Twitter : https://twitter.com/elonmusk/status/960992715579125760
https://cloudingo.com/pricing/
Zoom - https://zoom.us/j/688620921
Github - https://github.com/mattermost/mattermost-webapp/pull/770

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0500859414071ae69.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0500859414071ae69

@stephenkiers Not too sure on how to use styled components for now, but after some research, I think styled components are the way to go. However, I can't comment much on the code for now.
I see that you included bootstrap v4, however I still do not see that in affect on the spinmint.

@asaadmahmood I included bootstrap4, but I name spaced all the classes with .bs4- so that the bootstrap 3 stuff is unaffected. We can go through and update the old bootstrap files. When done we can remove all the namespacing.
But this way we can use both in the same app. I will document this somewhere else. :)

@stephenkiers Before we merge, I'd like to know, why are the links preview taking the css from the main file instead of styles being applied directly in the html?
Did we not remove those styles from the css?


fix: Add ARM64 to excluded architectures

Description
There was problem building iOS app. I was related with added arm64 target architecture. So for now excluding arm64 from architectures is temporary solution. Resolved in coop with @hosek.
I have tested my changes on:
ReNative project directly:

[x] ios simulator
[x] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

New project:

[ ] ios simulator
[ ] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

Existing Project created with previous version of renative:

[x] ios simulator
[x] ios device
[ ] android simulator
[ ] android device
[ ] web browser
[ ] web -e next browser
[ ] tvos simulator
[ ] tvos device
[ ] androidtv simulator
[ ] androidtv device
[ ] androidwear simulator
[ ] androidwear device
[ ] tizen simulator
[ ] tizen device
[ ] tizenmobile simulator
[ ] tizenwatch device
[ ] webos simulator
[ ] webos device
[ ] macos
[ ] windows
[ ] chromecast device

@pchalupa will merge to develop
Additionally I will open another PR to make this properly configurable via renative.json

@pchalupa will merge to develop
Additionally I will open another PR to make this properly configurable via renative.json