Formatting of navigation sidebar

Hi,
The headers in the navigation sidebar are expanded instead of hidden, so all subheaders are visible on page load, and the subheaders are formatted differently compared to UBC CLF.

Thanks @stephan-koenig I'll look into fixing this styling shortly, glad to see you are trying it out!

Thanks, @joelpittet!

@stephan-koenig I was thinking of taking the styles from this UBC site, it's not the CLF one as I think it's a bit nicer. Thoughts before I do that?
https://finance.ubc.ca/payroll/your-pay
Or the one we use for CS:
https://www.cs.ubc.ca/students/undergrad/careers
Preferences?

I think I like the first one better: https://finance.ubc.ca/payroll/your-pay
@rloftus, what do you think?

I agree, the first one is better @stephan-koenig

Ok it's not 100% there yet but there is some progress.

[ ] Need to potentially collapse trees that are not active: @stephan-koenig Is what you're aiming for? This can be tricky because of the static nature of the way the menus are produced but probably not impossible.
[ ] Maybe more important the sub menu should probably not show the top level menu items but rather only the child pages?

0.3.0 of the theme has the new style, use bundle update to see

Ok it's not 100% there yet but there is some progress.

Looks already very neat! Thanks!

[ ]  Need to potentially collapse trees that are not active: @stephan-koenig Is what you're aiming for? This can be tricky because of the static nature of the way the menus are produced but probably not impossible.

I imagined that the navigation is interactive, i.e., clicking on the top level would reveal the child pages for any menu item. But yes, ideally, all submenus except the current one should be collapsed.

[ ]  Maybe more important the sub menu should probably not show the top level menu items but rather only the child pages?

I think it is better if the top level is shown so people know, e.g. if they are looking at the "Student Info" or "Faculty Info."
What do you think, @rloftus or @cheeren?

@stephan-koenig generally in the CLF the side menu shows the secondary menu items (if they exist) and the primary menu items are shown across the top. Are you proposing an alternative to that?
Regarding the interactivity, I was thinking the sub menu in the side menu would expand if you're on that "branch" (parent or child menu items), and siblings that have sub menu items would be collapsed by default but clicking the arrow would expand them, clicking the text would go to that page. That pattern is on the CS external website https://www.cs.ubc.ca/students/undergrad/careers

I must have misunderstood. The behaviour as you describe it sounds excellent!

Ok great, I'll try to sneak some time in on Friday to push this a bit further


Add DTS "soc-label" support

I believe this PR should be closed as it was superseded by the DT_<COMPAT>_<ALIAS>_<PROP> defines.

@galak , can we close this one?


Using ListView with RefreshControl inside Container, breaks navigation

react-native, react and native-base version
"native-base": "^2.3.1",
"react": "16.0.0-alpha.12",
"react-native": "https://github.com/expo/react-native/archive/sdk-20.0.0.tar.gz",
"react-navigation": "^1.0.0-beta.12"

Expected behaviour
Navigates to another page with all its content
Actual behaviour
Navigates to another page, but only the header is changed, the content is still stuck on the page with the ListView/RefreshControl
Steps to reproduce (code snippet or screenshot)
App with TabNavigator.
First page is:
  <Container>
    <Header>
      <Body>
        <Title>Page 1</Title>
      </Body>
    </Header>
    <View style={{flex: 1}}>
      <ListView style={{backgroundColor: 'red'}} dataSource={new ListView.DataSource({rowHasChanged: (r1, r2) => r1 !== r2})}
        renderRow={() => <View/>}
        refreshControl={<RefreshControl refreshing={true}/>}
        />
    </View>
  </Container>

Second page can be anything.
Is the bug present in both ios and android or in any one of them?
Only tested on Android 7.0.
Any other additional info which would help us debug the issue quicker.
If the View is changed to Content, the RefreshControl won't work at all (without warning). This is explained in https://github.com/GeekyAnts/NativeBase/issues/269#issuecomment-277402981 but it's still confusing because there is no warning at all. However this is not the focus of this bug report.
If set to refreshing={true} during the page mounting, then after sometime it sets refreshing=false (from state change), then behavior is broken as reported.
If set to refreshing={false}, then behavior is normal.
If set to refreshing={true} after the page has finished mounting, then user trigger the refreshing and then refreshing=false again, then behavior is normal.
If Container is changed to View then behavior is also normal.
My hunch is that it is a bug with Container, because I don't use List or any other native-base, except for Header/Body/Title.
Related to #269, #257, #348, #69.
Bug in action: Notice that both the Header Title and tab is on "Explore", but the content is still showing from the first Home tab. The Explore page should be just empty white screen.

Workaround
setTimeout() (with or without timer-mixin) works wonders:
componentDidMount() {
  // buggy:
  //this._onRefresh.bind(this);
  // buggy:
  //InteractionManager.runAfterInteractions(this._onRefresh.bind(this));
  // works:
  setTimeout(this._onRefresh.bind(this), 500);
}

async _onRefresh() {
  this.setState({refreshing: true})
  console.debug('Fetching posts...')
  try {
    let response = await fetch(...)
    this.setState({refreshing: false});
  } catch (error) {
    console.error('Error fetching posts', error)
    this.setState({refreshing: false})
    alert('Error: ' + error)
  }
}

@ceefour  Tried your code. Couldn't find any issue. Attaching a gif.

I tried again with Expo 22 (previous with Expo 20), thus updated react etc. Even in native-base 2.3.1 the problem is now gone:
  "dependencies": {
    "@expo/samples": "^2.0.2",
    "@expo/vector-icons": "^5.2.0",
    "apollo-client": "^1.9.3",
    "color": "^2.0.0",
    "expo": "^22.0.0",
    "graphql-tag": "^2.5.0",
    "native-base": "^2.3.1",
    "react": "16.0.0-beta.5",
    "react-apollo": "^1.4.16",
    "react-native": "https://github.com/expo/react-native/archive/sdk-22.0.1.tar.gz",
    "react-navigation": "^1.0.0-beta.19"
  },
  "devDependencies": {
    "jest-expo": "^22.0.0"
  }

So I assumed that something in the newer dependencies has fixed this problem. Now I cannot reproduce this problem either with native-base 2.3.1 nor 2.3.3.
Thank you!


Add Dota 2 VideoGameProvider

All data was taken from open sources (like dota2.fandom.com).
There was already a dota.todo.yml concept, I changed the data and added the data in the afternoon, added a couple more methods to the new provider itself

I was going to suggest something like:
    @Test
    void dota2Quote() {
        // Given / When
        String quote = dota2.heroQuote(dota2.hero());
        // Then
        assertThat(quote).isNotEmpty();
    }

but it seems there aren't quotes for every hero. I guess you could make a list of those that do have quotes and then randomly pick from that Set for the test.

Also, in the future, when quotes are added for all heroes from the game itself, we should get rid of “availableHeroes” in Dota2Test itself and change the dota2HeroQuote test method to take heroes from dota2.hero().

@bodiam how sticky (or not) do you want to be about the codecov stuff?

@kingthorin  not very, it was more indicative than anything else. I'm not sure why it breaks the build these days when the coverage goes down a bit, that wasn't intended.

Thanks. Merging as-is 🙂


Added ReactJs Counter App

In this project, I have created a simple counter app using react js. In this app, there are three buttons that perform a specific task.
like, increase the counter, decreasing the counter, and reset the counter.

Thanks for reviewing🤩🤩


IPT resource version number is not monotonic

This is a report against an IPT instance running version 2.1.1-r4640, if this issue is no longer present in later IPT versions, feel free to close.
iDigBio is observing a case where an IPT instance published a resource several times (for example, creating up to version 6). They then rolled the resource back to an older version (version 4). When they subsequently went to publish a new version, IPT called it version 5. This obviously invalidates the previous version 5, and breaks the chain to the old version 6, but there is no additional metadata to indicate that this happened.
iDigBio doesn't rely on this version number incrementing properly for our versioning, but others might and it is worth looking at seeing if there are other numbering paradigms that could provide this property. Perhaps a rollback could cause the next publish event to create a new major version?

Thank you for reporting this issue. Can you please explain how exactly they "rolled the resource back to an older version?" Thanks.

Basically:
http://collections.mnhn.fr/ipt/resource.do?r=mnhn-p&v=22, published 2015-12-10 (dated as last seen by iDigBio)
http://collections.mnhn.fr/ipt/resource.do?r=mnhn-p&v=21, published 2016-04-18 (not archived, but metadata indicates an original pub date of 2015-12-10)
http://collections.mnhn.fr/ipt/resource.do?r=mnhn-p&v=20, published 2016-04-20 (last seen dated, 2015-06-05)
http://collections.mnhn.fr/ipt/resource.do?r=mnhn-p&v=19, published 2016-04-19 (not archived, but metadata indicates an original pub date of 2015-06-05)
http://collections.mnhn.fr/ipt/resource.do?r=mnhn-p&v=18, published 2014-12-14
This has changed since this morning, but yesterday the "latest version" (as displayed by IPT) of mnhn-p was v18. This morning it was observed to be v19. and now its v20. If this rollback functionality isn't actually built into IPT, then this might be caused my manual editing of the filesystem, in which case you can close this bug.
If you'd like to view iDigBio's archived datasets, they are available at https://s.idigbio.org/idigbio-datasets-prod/
Our dataset history for this recordset is:

id
url
etag
modified

20738144
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
626a870516ee97d27ef59ee76c1de911
2016-04-20 12:23:59.299175

20574469
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
01756e7fd05187ef80ee2c427fd4c8aa
2016-04-19 05:22:38.042744

20470710
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
2602f4626fcbd127140e6416e1c37bb4
2016-04-18 05:23:31.705763

20470683
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
f4e01c164351d5bf941ed6386932ed9a
2016-04-18 04:23:15.368296

12829138
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
e4a114ed431ca20d7a4c31eee83259e3
2015-12-10 10:31:35.788432

9839877
http://api.idigbio.org/v1/recordsets/616857b7-f952-44ef-9b6f-576dc1e65b51
e6089637329b4dd0fda8eda85f73a136
2015-07-15 11:16:07.249611

Thanks Alex. Rollbacks aren't supported therefore this problem sounds like it is due to manual editing of the filesystem, which isn't condoned by the way ;)
I'd like to encourage you to upgrade this IPT to the latest version 2.3.2. You'll notice the IPT moves to a new versioning policy that supports major and minor versioning. Note the IPT must be configured with a DataCite or EZID account to assign DOIs to datasets corresponding with bumping major version numbers.
Another change you'll notice during publication, is that the publisher is encouraged to enter a detailed summary of what has changed since the last publication. The change summary helps users track changes to the dataset over time. Here's an example of how it gets shown on the dataset homepage.


Update README.md

Humm the documentation of pyscreeze just mentions that scrot needs to be installed. Do you have that installed?
https://github.com/asweigart/pyscreeze


Consistent fact CLI (Unable to get file fact via cli)

Describe the bug
I seem to be unable to get some facts via the cli. Specifically, I have been unable to use file, directory, and link. This might be operator error, but I am finding the cli usage to be very confusing (I think more specific examples in the documentation would help).
To Reproduce
I have tried the following permutations:
❯ pyinfra ---- fact file --path "/Users/----/.bashrc"
Usage: pyinfra [OPTIONS] INVENTORY OPERATIONS...
Try 'pyinfra --help' for help.

Error: no such option: --path

❯ pyinfra ---- fact file path="/Users/----/.bashrc"
--> Loading config...
--> pyinfra error: No fact: path=/Users/----/.bashrc

❯ pyinfra ---- fact file "/Users/----/.bashrc"
--> Loading config...
--> pyinfra error: No fact: /Users/----/.bashrc

❯ pyinfra ---- fact.file "/Users/----/.bashrc"
--> Loading config...
--> pyinfra error: No such module: fact

❯ pyinfra ---- fact file
--> Loading config...
--> Loading inventory...

--> Connecting to hosts...
    [----] Connected

--> Gathering facts...
--> An unexpected internal exception occurred:

  File "/Users/----/.virtualenvs/05-hz-pyinfra-d0Faa_8y-py3.9/lib/python3.9/site-packages/pyinfra/api/facts.py", line 123, in _make_command
    return command_attribute(**host_args)
TypeError: command() missing 1 required positional argument: 'path'

--> The full traceback has been written to pyinfra-debug.log
--> If this is unexpected please consider submitting a bug report on GitHub, for more information run `pyinfra --support`.

The output from the final one pyinfra <host> fact file seems to imply that this should be possible, and the way that other facts work, such as pyinfra <host> fact hostname also seems to indicate this should work.
Expected behavior
I would expect all facts to be valid both inside of deploys as well as on the cli.
As a side note, I feel like it is a bit confusing that the way to call facts vs operations is different on the cli (e.g. pyinfra <host> fact <fact name> vs pyinfra <host> <operation category>.<operation> <args, kwargs, etc>).

In this specific case the correct (and confusing) CLI would be pyinfra --- fact file:/path/to/fle. I agree that this is totally inconsistent with direct operation calls and in need of change! https://github.com/Fizzadar/pyinfra/issues/491 defines the change of facts to use explicit imports, based on that a better CLI might be:
pyinfra --- fact files.File path=/path/to/file

However - there is a limitation here in that each CLI call can only retrieve one fact - the same limitation applies to executing operations. This is also still not 100% consistent with the operation version (fact files.File ... vs files.file ...).

This has now been released in v1.4!


[BUG]Module crash when used over IIS but not on IIS Express

Library name and version
Azure.Identity 1.6.1
Describe the bug
I using the module Azure.Security.KeyVault.Secrets need Azure.Identity All working great when hosted under IIS Express. But when I host the project on IIS Local the module crash.

Azure CLI authentication failed due to an unknown error. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/azclicredential/troubleshoot 'az' is not recognized as an internal command
or external, an executable program or a batch file.

Expected behavior
Retreive Secret Value from KeyVault
Actual behavior
Exception was thrown
Reproduction Steps
Add address in Web.Config
Host on IIS (not IIS Express)
WebAppKeyVault.zip
Environment
Windows 11 Enterprise 21H2
IIS 10,0,22000.856
Visual Studio 2022 Enterprise 4.8.04161

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'KeyVault:0.57001436,Azure.Identity:0.42401743,Extensions:0.0012364188'

Hi @FranckSix.  Thank you for reaching out and we regret that you're experiencing difficulties.  It would be helpful if you could provide more context around how your application is using the KeyVault client - a code snippet would be appreciated, as would a full stack trace.
From the available information, this would seem to be an exception from Azure.Identity, likely due to DefaultAzureCredential attempting to authorize with the Azure CLI credential, as described in this example of authentication flow.
We would suggest testing by configuring the types of auth that DefaultAzureCredential uses by passing a [DefaultAzureCredentialOptions] instance that removes Azure CLI credential.   Alternatively, you may want to consider selecting just the type of authentication that your application should use and passing the specific Azure.Identity credential type for that scenario.

At this point, I think the question that we want to answer is "what credential type do we want to use in IIS?"    Thus far, it seems that DefaultAzureCredential is following its documented flow for credential types, and that many are not supported in the host environment.
The latest exception that you're seeing is due to the [Environment Variables] used by DefaultAzureCredential via EnvironmentCredential have not been defined.   More information can be found here.

Hi @jsquire,
I think I put my finger on it. Under IISExpress we seem to run under the local account authenticated on Windows. So because I have access to Azure, the authentication works. But under IIS, is the user associated with the Pool is used. Forcibly this account does not have access to Azure and the authentication fails.
I would have to create a token that would allow me to connect via the application. A bit like the identity managed by the Azure App. Is it possible ?
Also I get a timeout with managed authentication when my application is deployed under Azure. Is there something that can cause this behavior?
Thanks!

I would have to create a token that would allow me to connect via the application. A bit like the identity managed by the Azure App. Is it possible ?

I'd recommend taking a look at the ClientSecretCredential which allows you to create an application -specific identity in AAD.

Also I get a timeout with managed authentication when my application is deployed under Azure. Is there something that can cause this behavior?

Most often, this happens when running in a host environment that doesn't have a managed identity endpoint.   Without a stack trace and deeper understanding of your host, that's as much as I can speculate.


Milestone snapshots

Use Read/Write model snapshots for milestones instead of a projection.
When querying the milestones, only query for events for the milestones which are not reached.
Over time this should result in 0 queries or projection overhead.
Acceptance criteria

[x] A snapshot table
[x] Snapshot interface easy to use to other aggregates
[ ] Milestone snapshot

We still need to projection for the pushed and internal analytics uses. Therefore this issue is replaced by https://github.com/zitadel/zitadel/issues/8800


Dcerpc logging/v3

Why is this failing on 4.1 and 5.0? Do we need any updates there?

Why is this failing on 4.1 and 5.0? Do we need any updates there?

Yeah I think dcerpc never had logging before. I should add version check in test.yaml. Thanks.

Does this depend on a Suricata PR ?

Replaced with #296


Using @Embed in archetype descriptions

It would be a good idea to use @Embed in archetype descriptions in journals, due to the fact that they mainly consist of feat descriptions.
This will make future updating of the feat descriptions easier, as well as the work of the translators.

That is the plan, someone just has to do it, and data entry on archetype and class journals is frozen at the moment for War of Immortals entry.

Good to know. All that is left is to wait.

Closing to consolidate - will track this issue via #17070


Added optional autoCloseDelay to garage-door-opener , but it auto close as before

i have added autoCloseDelay into my configuration file , but when i run "homebridge" on raspberry  and open garage in home app on IOS , the garage still auto close when i open just now.

autoCloseDelay is designed to auto send the close command when it's set. Perhaps you need 2.5.10


.scss files don't re-compile with ember server

Right now, the only way to re-compile compass files with ember-cli-compass-compiler seems to be to run the command ember build.
However they should automatically re-compile if an ember server is running and a sass file is changed.

It looks like it is actually auto-compiling, but at odd intervals. Sometimes it takes a good minute to realize a file has changed, whereas javascript files are instant.

compass is slow compared to javascript compilation.

@quaertym Cheers, I'm just surprised at how much slower it is. Build process without Sass seems to be 1/10th of what it is with.


Laravel 5.0 - no validation error messages

I have this installed and mostly working on Laravel 5.0. What I seem to be missing is any of the error messages. Where are they supposed to be displayed?
I would expect messages when validation rules fail, foreign integrity constraints are invalidated, unique keys are abused, strings are too long etc. But I get nothing. The "saving" message lasts a fraction of a second longer, and the listing does not refresh to show the updated record, but that is all.

Looking in Firebug, the messages are coming back to the browser. So saving a record that violates a unique validation rule returns this from the AJAX POST:
{"success":false,"errors":"The code has already been taken."}

Okay, some error messages are appearing at the bottom of the form on the RHS, for a couple of seconds, before disappearing. I'll have to change that - it's just not practical as you only see the message as it is disappearing.
When integrity constraints are violated, for example trying to remove a master record without removing the detail records first, the AJAX result to the delete is a HTML page containing the error message. The exception is not caught and converted to a JSON message. Any handler that returns AJAX should be able to catch ALL unhandled exceptions to ensure it returns only AJAX.

This is something I am intending to take care of soon


Fix: README tutorial link

Link to Carbon React tutorial migrated when a Vue tutorial was added
Changelog
Changed

updated README

closing as this is a duplicate of #2542


[Minor] Adjusted styles for IE11 support.

buttons wouldn't align to the right side on IE11
input fields wouldn't respect the line height on IE11

Created new version 0.4.4 for these changes


Add mem_payload_width to bp_proc_params and fix CCE microcode to avoid deadlock in sync

This contains two changes:

Add mem_payload_width_p to bp_proc_params struct that defines the size of payload field in the CCE-MEM interface to hold the CCE's MSHR. This keeps the payload size and contents opaque. The CCE casts the bits into the MSHR format used internally.

A small fix to CCE microcode to avoid deadlock during startup/sync. Previously, the LCE Response buffer could fill up if the number of LCEs was greater than the number of way groups managed by each CCE. This results in deadlock during the sync routine between the CCEs and LCEs. The CCE will now wait for the sync ack after each sync command. This adds some latency to the sync sequence at startup (only time it happens), but avoids having to double or quadruple the size of the LCE Response buffer at each CCE. The buffer is instead sized for the maximum number of response messages that could arrive during normal operation (i.e., after startup/sync)

Looks good to me.  Once I debug and merge in the new uncached I/O stuff I'll approve this.  There shouldn't be a conflict between these ucode changes and the ones for uncached stuff, right?


Database persistence for Authz policy

Acceptance criteria
Implement an Adapter that will read/write auth policy to a database. It should be possible to enable and configure this adapter through the app-config.
Who will have access:
Put an x in the boxes that apply

[X ] Authenticated user
[ ] Unauthenticated user/Guest
[ X] System Admin only

UI/UX
All configurations should be done through app-config.
Api documentation/information
OpenAPI link if needed

Draft: https://github.com/PatAKnight/backstage-plugins/pull/1

Pr was moved https://github.com/janus-idp/backstage-plugins/pull/544

I re-created pr https://github.com/janus-idp/backstage-plugins/pull/605


Default cursor for buttons

Shouldn't all buttons (dc-btn) have a cursor: pointer; by default?
Otherwise the property will likely need to be overridden in the projects using it

@dami-gg I suppose that using cursor: default is a design decision. @xonic  @gabrielhl Can you give me your opinion about that?

It's all about affordance. Form elements like buttons, select boxes, radio buttons, checkboxes, etc. all have strong affordances, users can tell they are interactive.
On the other hand, elements with low affordance, such as links are supported by the changing cursor to clearly communicate they are interactive.
Check out the Microsoft dev guidelines for reference

Good to know. So we keep it like this. Thanks for the clarification


Break indirect dependency on contrib for windows.

This fixes the tf-master-win-bzl build breakage.

PTAL, updated the changes as we discussed.

Ping!
This fix is ready to go in.


ImportError: cannot import name 'export_saved_model'

This error is showing while installing !pip install tensorflow-gpu==2.0.0-alpha0.
How can i resolve it, please help me out...
I have tried out this stackoverflow solution, but it did not working:-
https://stackoverflow.com/questions/60879608/tensorflow-raised-error-importerror-cannot-import-name-export-saved-model

This seems like an issue with Tensorflow and not DotProduct?

yes brother, but any solution?
I have tried to install "pip install tensorflow-gpu==2.0.0.beta1" this version instead but still come up with same error.
code was working perfectly but this specific error started to come since tensorflow updated its version.

I haven't tested the repo in a while.


please guide for download the program

Expected Behavior

Actual Behavior

Your FULL config.json (remove your username, password, gmapkey and any other private info)

Output when issue occurred

Steps to Reproduce

Other Information
OS:

Branch:

Git Commit:

Python Version:

Any other relevant files/configs (eg: path files)

Short Description

Possible solution

How it would help others

please help to download the program i download the zip but there is no luncher to start the program

Read.
https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/docs/installation.md

closing. for "helpdesk" issues step by to discord.


[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page

HELD for https://github.com/Expensify/Expensify/issues/311912
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

click on FAB icon and select new chat
enter email and create a new chat
click on FAB icon and select assign a task
Enter title and click on Next button
click on assignee and search for user with whom you created new chat
6.select that user

Expected Result:
Assignee does not show on Confirm task page
Actual Result:
Assignee should show on Confirm task page
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/3c32ed9e-91e2-447c-be42-e48ef4e22251
https://github.com/Expensify/App/assets/43996225/e0d52b04-d0ba-4b5f-8624-615a19ef6956
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692595469205799
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182f226dc34b9a020
Upwork Job ID:<PHONE_NUMBER>851416064
Last Price Increase: 2023-08-22
Automatic offers:

gadhiyamanan | Reporter | 26281429

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Assignee does not show on Confirm task page
What is the root cause of that problem?
This happened after #23773 in which we've updated the way we fetch the user details to display.
Here https://github.com/Expensify/App/blob/d38c06cc71ce90f0a890ddd6a208d849d0b13be3/src/libs/actions/Task.js#L719-L721 we're checking in the personalDetails.
Although we've initiated a chat with the User A, but User B haven't responded which is resulting personalDetails for the User B as undefined.
And here https://github.com/Expensify/App/blob/d38c06cc71ce90f0a890ddd6a208d849d0b13be3/src/libs/actions/Task.js#L721 we're returning an empty details which is causing the issue not to display anything in the Confirm task page.
What changes do you think we should make in order to solve the problem?
Since we can't do anything about the user details not available we can return with the details we have.
We can do default details instead of returning empty details which is causing the issues.
if (!details) {
    return {
        icons: [{name: assignee, type: CONST.ICON_TYPE_AVATAR, source: UserUtils.getAvatar('', assigneeAccountID)}],
        displayName: assignee,
        subtitle: assignee,
    };
}

assignee is passed form NewTaskPage which is props.task.assignee

The PR which caused the issue (maybe not) is have an issue with showing title for user icons, so we can follow the same approach we're following here to get the icon.
https://github.com/Expensify/App/blob/c5fc369015af5311c4c1207203d7d09c0010744d/src/libs/OptionsListUtils.js#L836-L845

What alternative solutions did you explore? (Optional)
NA
Result
https://github.com/Expensify/App/assets/59088937/b116143f-c00f-440a-8120-23fa0d889314

Proposal
Please re-state the problem that we are trying to solve in this issue.
Assignee does not show on Confirm task page
What is the root cause of that problem?
When assignong a task to an assignee, we will check if chatReport with this assignee is existed or not
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/libs/actions/Task.js#L654-L673
If it does not exist, we will create an optimistic chat report and add this assignee to PERSONAL_DETAILS_LIST (on ONYX)
Then when displaying the assignee field we will get information from PERSONAL_DETAILS_LIST based on assigneeAccountID
But in this case, because we init the chat with this user before. So the condition check !chatReport is false
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/libs/actions/Task.js#L654
and this user will be not added to PERSONAL_DETAILS_LIST. So It displayed empty when displaying the assignee field
What changes do you think we should make in order to solve the problem?
when assigning new assignee we also should check if chat report exist and this assignee is not in PERSONAL_DETAILS_LIST, we will add this user to PERSONAL_DETAILS_LIST like here
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/libs/actions/Task.js#L666-L672
What alternative solutions did you explore? (Optional)
When create new chat with new user, we also add this user to PERSONAL_DETAILS_LIST like here
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/libs/actions/Task.js#L666-L672

Proposal
Please re-state the problem that we are trying to solve in this issue
After selecting an assignee, it still shows Assignee on Confirm task page
What is the root cause of that problem?
Here in this Menu option, there is no check that if an assignee is already chosen then don't show the Assignee option
https://github.com/Expensify/App/blob/main/src/pages/tasks/NewTaskPage.js#L168-#L175
         <MenuItem
                            label={assignee.displayName ? props.translate('task.assignee') : ''}
                            title={assignee.displayName || ''}
                            description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
                            icon={assignee.icons}
                            onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
                            shouldShowRightIcon
                        />

What changes do you think we should make in order to solve the problem?
We can add a simple condition here that if we have already chosen assignee then don't show this assignee option
      !props.task.assignee &&   <MenuItem
                            label={assignee.displayName ? props.translate('task.assignee') : ''}
                            title={assignee.displayName || ''}
                            description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
                            icon={assignee.icons}
                            onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
                            shouldShowRightIcon
                        />

What alternative solutions did you explore? (Optional)
Supporting videos
Before:
Screencast from 23-08-23 01:17:32 AM IST.webm
After:
Screencast from 23-08-23 01:16:24 AM IST.webm

@rushatgabhane When clicking a new user in the search page, we only call navigateToAndOpenReport and don't have any logic to create optimistic personalDetails. Only when this user send a message, the personalDetail will be responsed from BE and added to ONYX.

@DylanDylann Can you please make a PR, thanks for review @rushatgabhane

@rushatgabhane @mountiny The PR is ready for review https://github.com/Expensify/App/pull/25756
I can't run the auto workflow of PR. Anyone help me run all workflows

Bump @rushatgabhane @mountiny ^^^

We are still discussing if this solution is actually desired, its lower priority with the deadlines next week

I believe this is help on internal PR to make this change possible

Not overdue

Any update @mountiny? TIA!

No, this is very low priority at the moment

No worries — thank you!

Not overdue 👍

Heading OoO until Oct. 25, so reassigning BZ to keep an eye on this while I'm gone 👍

@CortneyOfstad Welcome back! Assigning back to you; no change

Perfect — thanks @conorpendergrast!

@mountiny Any updates — TIA!

No not really this is very low priority cc @thienlnam would you actually be interested in taking this one over as you got more context in the Tasks area so the fix might be quicker for you

Didn't read the entire thread but do you have a summary of the problem? Something with the personal details not showing up for a new user?

It seems to be basically unable ot select the assignee in the new task flow when you just created a new chat with someone. I am double checking if we are even fixing these now

Ah yeah, I've seen this problem before - I believe it lies in that when you create optimistic personal details for someone you don't actually store the email as part of it until they respond to you
So when you select this user in the new task flow, it generates a new optimistic personal details for this person since it doesn't link to the existing contact but then when the task is created it pulls the existing user.
Anyways, it's not that simple to fix and I'd say not worth our time right now so we should just close this - thoughts?

I have discussed this with Jason and I am going to create a project to collect these and close it, we are not going to focus on the task fixes right now

Added it to the project and we will come back to this once we are ready to refocus on this feature

@mountiny @CortneyOfstad Are we eligible for compensation for our effort? Contributors are already assigned and started on the PR. It's just due to the decision changes and the solution becomes outdated.
Some other similar cases where compensation is made 100% thought PR is closed
https://github.com/Expensify/App/issues/27108#issuecomment-1771000123
https://github.com/Expensify/App/issues/26470#issuecomment-1775949241

I am sorry but in this case given the circumstances I would err on a side of no payout but rather just first dibs for you once we get back to this. We are going to fix this eventually but closing only to keep plate clener, otherwise we could put this on hold. Its added to a project in Todo category. This would require backend changes and external only work was not sufficient so I think full compensation at this point would not be appropriate either


403 link served on torch index url

🐛 Bug
Hi 👋
pip install torch torchmetrics~=1.0.0 --extra-index-url https://download.pytorch.org/whl/cu118

Will attempt to download torchmetrics 1.0.3 from the torch index:
https://download.pytorch.org/whl/torchmetrics
The link hosted there will respond with 403 forbidden.
Could you remove that link?
Many thanks!

Hello, I think the the problem is using --extra-index-url so you shall use --find-links so your command will be:
apt update && \
apt install python3.7 python3-pip -y && \
pip3 install --upgrade pip && \
python3.7 -m pip install pytorch-lightning \
	--find-links=https://download.pytorch.org/whl/cu113/

Hi @Borda, torch deprecated --find-links, also the official installation page now references --index-url / --extra-index-url.
--find-links still works if you point to a html page that contains <a> html tags pointing directly to wheels, so that would be
pip install torch torchvision \
  --find-links https://download.pytorch.org/whl/cu113/torch/ \
  --find-links https://download.pytorch.org/whl/cu113/torchvision/

Since they now host a PyPI index, installation options for end users have become more flexible. See for instance discussions at https://github.com/ray-project/ray/pull/26072/

The culprit link hosted on the torch index is https://download.pytorch.org/whl/torchmetrics-1.0.3-py3-none-any.whl
which will be preferred over torchmetrics 1.0.3 hosted on official PyPI, regardless wether the torch index is specified under --index-url or --extra-index-url.

Do you have the capability to get that link removed from the torch index?

Do you have the capability to get that link removed from the torch index?

We do not have any power over this index, please follow on official PyTorch issue... :(

OK:) done, ty for the quick reply


Add better test suit and php-cs-fixer

What I've updated:

Added PHP-CS-Fixer
Added phpunit to require-dev
Added license and author info to all files
Added contribution guidelines
Added abstract test case class
Updated the Travis config
Updated syntax to better match PSR-2
Updated php version to 5.5.9
Update tests to be namespaced

This closes #35

:+1:


Deletes file creation date

To reproduce, clone the repo, run the script on the included test data. For notes put into folders, the creation date is nuked.
For others reading this, if you only need folder grouping, and you have a not-huge amount of tags. Bear lets you export notes by tag, one by one: https://bear.app/faq/Import & export/Export your tags/
It can be done fairly quickly with: click tag then cmd + shift + s then enter for each tag. (Remember untagged notes the same way.)
And then, if needed, the script can be run on each folder. Since now no new folders will be created.

Thanks @coding-camel! This makes sense, I opted to create a new folder instead of modifying the Bear archive.
That being said I will play a bit with the code and see if I can maintain the same file metadata. :)

@bernardoamc Thats nice, I would also be okay with just adding a warning to the readme.

We can do both! I will update the README while I investigate and if I figure out how to keep the file metadata I can remove the warning. 👍

I've added it to the https://github.com/bernardoamc/obsidian_bear#caveats section for now.


Deploy script Fails: An error occurred (ParameterNotFound) when calling the GetParameter operation

The deploy script fails and gives me the following error
An error occurred (ParameterNotFound) when calling the GetParameter operation:

I think it's from this line. It's not getting theAPP_ID.
APP_ID=$(sed -e 's/^"//' -e 's/"$//' <<<"$(aws ssm get-parameter --profile $PROFILE --region "$REGION" --name /Querypal/Amplify/AppID --query "Parameter.Value")")
I don't have an ssm parameter with the name /Querypal/Amplify/AppID .
Also mention the right scopes for the github token in the documentation.

@thealpha93, thanks for pointing this out. I'll into this shortly.

@thealpha93, thanks for pointing this out. I'll into this shortly.

@thealpha93, fix committed, please pull the latest changes and try again

@thealpha93, fix committed, please pull the latest changes and try again

@OElesin Thanks. I think it's almost working now. Got past that error. But still the app backend fails the build in cloudformation I guess. I'll look more into it and start a new issue if the issue persists

@OElesin Thanks. I think it's almost working now. Got past that error. But still the app backend fails the build in cloudformation I guess. I'll look more into it and start a new issue if the issue persists

@thealpha93, great. Please report the new issue and let me look into it. All look good from here by the way!

@thealpha93, great. Please report the new issue and let me look into it. All look good from here by the way!


[Furyctl Next] only use sudo if necessary

Furyctl Next uses sudo to setup the openvpn connection, but without doing any prior checks.
It shall use sudo only when needed, for example, if the user is not root.

As discussed on https://github.com/sighupio/furyctl/pull/131#discussion_r1061333838 , we should also add the command with or without sudo to kill the OpenVPN process after cluster deletion.


fix: several serialization fixes with new tests

this addresses the issues raised in #88 and extends the test suite to match json conversions to ttl using the prov web service.

Coverage increased (+0.2%) to 90.495% when pulling e480c62f2ed4dc1a4d1db4da8293afad163ba9e0 on satra:fix/atTime into 4d2c236f291240f8cf212b73c532b2ee48fd3b24 on trungdong:master.

@trungdong - it would be good to merge this and then cut a new release.

Thank you very much for this, @satra.
I'll try to get a new release out this coming week.


Installation fails

I use ember-cli v0.2.3 and when I run the command ember install ember-cli-chart I get the following error message:
The `ember generate` command requires an entity name to be specified. For more details, use `ember help`.

This seems to be a problem with ember-cli -- https://github.com/ember-cli/ember-cli/issues/3831
Supposedly the addon installs even with that error. Is that true @dthul ?

I had to issue ember g ember-cli-chart to get it to work, otherwise it complained about a missing component.

Yeah that generator adds Chartjs through bower.

ember install:addon ember-cli-chart seems to work with ember cli 0.2.0

With the latest ember-cli (0.2.7) ember install ember-cli-chart seems to work; the addon and blueprint run properly. With older versions of ember-cli it's probably safer to use ember install:addon ember-cli-chart.


app crashes as soon as image is selected

App will crash as soon as image is selected.

Facing the same issue? You were able to fix it? If yes please share the method..


Short JSON topics as an array edit

The single-string form works, unless that's changed recently. Should we not publicly document it?
If we always want to show an array, can you also change the tags param description to just say "Array of strings"?

Had a customer report it didn't work without an array in the short format.
I'll talk to Reuben about it from a higher level though should it always
demand an array or how we want to move forward with that.  Thanks Matt.
On Thu, Feb 16, 2017 at 8:28 AM, Matt Meshulam<EMAIL_ADDRESS>wrote:

The single-string form works, unless that's changed recently. Should we
not publicly document it?
If we always want to show an array, can you also change the tags param
description to just say "Array of strings"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hologram-io/docs/pull/11#issuecomment-280344427, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5g-KOes3uOnxL9Hp8Z3t9hlKaJvExBks5rdF0BgaJpZM4MCgtE
.

Looks like this was resolved via a fix in the CSR.  There was a regression in the code.


Add a flag to skip Schema prefix when rendering root types

Changes
This PR adds another cli flag --root-types-no-prefix which complements --root-types.
If set it will render root types without Schema prefix.
Checklist

[x] Unit tests updated
[x] docs/ updated (if necessary)
[x] pnpm run update:examples run (only applicable for openapi-typescript)

Hey @drwpow thanks for review, I will add tests and update the PR with requested changes some time next week.

@drwpow I will add another test which tests when there is a parameter with the same name. I added a test case for the new flag.

That's awesome, thanks @drwpow!


LDAP connection pooling fixes

Tickets:

https://github.com/rancher/rancher/issues/8270
https://github.com/rancher/rancher/issues/8513

LGTM @cjellick @ibuildthecloud can you review/merge. I dont have merge rights.


Callout boxes

1. Info callout (yellow)

Callout name TBC
Purpose
This callout style should be used on important, non-mandatory advice for clients that doesn’t have any serious or legal implications. There might be other implications.
Design

The component does not require a heading, however the content design stylesheet has new guidelines on this
Background is a percentage opacity of the border colour

2. Important Callout (red)

Purpose
The warning callout should be used for any important snippet of text that has serious and/or legal implications if the client does not follow the advice
Markup

ImportantHeading of callout goes here if

The important label must always be visible
There must always be a heading
Content designers are not required to add additional heading text however content designer stylesheet has new guidelines on this

Design
Background is a percentage opacity of the border colour
3. Example or quote (grey)

This is a different content type in the content model to the important and info callouts
Purpose
This style is when an example needs to be displayed. Also use it for quotes.
Markup

ExampleHeading of callout goes here if
  OR

QuoteHeading of callout goes here if

The label must always be visible
There must always be a heading
Heading can be set to either example or quote
Content designers are not required to add additional heading text

@panosvoudouris from the last design system meeting but we reviewed actions and haven't looked at this yet:
How can we handle headings so that the callout box headings are numbered correctly in the page.
ie. If the callout box is before any other content, the heading is H2 (nested correctly after H1 title) or if the callout box is in a section, the heading is H3.

@panosvoudouris could we add margin-bottom 1rem to all the callouts?


Warning on latest scala 2.13 for case classes containing collections

Auto-application to () is deprecated. Supply the empty argument list () explicitly to invoke method result,
[error] or remove the empty argument list from its definition (Java-defined methods are exempt).
[error] In Scala 3, an unapplied method like this will be eta-expanded into a function.
[error]   implicit val containsCollectionCodec = caseCodecIdx[ContainsCollection];
case class ContainsCollection(c: List[String])
implicit val containsCollectionCodec = caseCodecIdx[ContainsCollection]

@annotation.nowarn implicit val containsCollectionCodec = caseCodecIdx[ContainsCollection]
allows bypassing the issue if you use -Xfatal-warnings


Webpack Vendor Problem

After I add the dependency of ngx-uploader to webpack.config.vendor.js and after I run webpack --config webpack.config.vendor.js on the command line to update the vendor bundle I got this error:

ERROR in ./~/ngx-uploader/index.ts
Module not found: Error: Can't resolve './src/ngx-uploader/module/ngx-uploader.module' in '/Users/.../node_modules/ngx-uploader'
 @ ./~/ngx-uploader/index.ts 1:0-62
 @ dll vendor

ERROR in ./~/ngx-uploader/index.ts
Module not found: Error: Can't resolve './src/ngx-uploader/classes/ngx-uploader.class' in '/Users/.../node_modules/ngx-uploader'
 @ ./~/ngx-uploader/index.ts 2:0-62
 @ dll vendor

ERROR in ./~/ngx-uploader/index.ts
Module not found: Error: Can't resolve './src/ngx-uploader/directives/ng-file-select.directive' in '/Users/.../node_modules/ngx-uploader'
 @ ./~/ngx-uploader/index.ts 3:0-71
 @ dll vendor

ERROR in ./~/ngx-uploader/index.ts
Module not found: Error: Can't resolve './src/ngx-uploader/directives/ng-file-drop.directive' in '/Users/.../node_modules/ngx-uploader'
 @ ./~/ngx-uploader/index.ts 4:0-69
 @ dll vendor

But the directory ngx-uploader and the files  existing in the node modules

Similarly when trying to build with ionic-app-script, it errors with
[10:08:53]  Error: ./~/ngx-uploader/index.ts Module build failed: Error: ENOENT: no such file or directory, open
            '/home/g/prozeo-mvp/node_modules/ngx-uploader/index.js' at Error (native) @
            ./src/app/components/feed-components/post-component.module.ts 15:0-48 @ ./src/app/app.module.ts @
            ./src/app/main.ts
Error: ./~/ngx-uploader/index.ts
Module build failed: Error: ENOENT: no such file or directory, open '/home/g/prozeo-mvp/node_modules/ngx-uploader/index.js'
    at Error (native)
 @ ./src/app/components/feed-components/post-component.module.ts 15:0-48
 @ ./src/app/app.module.ts
 @ ./src/app/main.ts
    at BuildError.Error (native)
    at new BuildError (/home/g/prozeo-mvp/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
    at callback (/home/g/prozeo-mvp/node_modules/@ionic/app-scripts/dist/webpack.js:119:28)
    at /home/g/prozeo-mvp/node_modules/webpack/lib/Compiler.js:256:15
    at Compiler.emitRecords (/home/g/prozeo-mvp/node_modules/webpack/lib/Compiler.js:351:37)
    at /home/g/prozeo-mvp/node_modules/webpack/lib/Compiler.js:249:12
    at /home/g/prozeo-mvp/node_modules/webpack/lib/Compiler.js:344:11
    at next (/home/g/prozeo-mvp/node_modules/tapable/lib/Tapable.js:154:11)
    at Compiler.compiler.plugin (/home/g/prozeo-mvp/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
    at Compiler.applyPluginsAsyncSeries1 (/home/g/prozeo-mvp/node_modules/tapable/lib/Tapable.js:158:13)

guys can you check with 3.0.2 please, I missed some files with the publish to npm. thanks

3.0.3 seems to work fine. Thanks!

Yes I confirm Igleim it works fine. Thank you very much!

no problem.


Filament crashes if you place the camera at {0, 0, -20} in a simple scene with a single model

Describe the bug
Filament crashes when the camera is placed at {0, 0, -20}
To Reproduce
Steps to reproduce the behavior:

Create a simple scene with a single model
Position the camera at {0, 0, -20}

Expected behavior
The camera can be placed anywhere in the scene.


Is it possible to refer to variables defined in "strict" in mapping.json in nested objects?

💬 Question
UI Kitten and Eva version

Package
Version

@eva-design/eva
"^2.1.1"

@ui-kitten/components
"^5.1.1

 "strict" {
 "cell-medium": 1.5
}

"variantGroups": {
            "type": {
              "a": {
                "cellStyles": {
                  "position": {
                    "size": "cell-medium",
                    "alignment": "flex-start",
                    "textStyle": "bold"
                  },
                  "name": {
                    "size":  "cell-medium"
                    "alignment": "baseline",
                    "textStyle": "regular",
                    "paddingLeft": 5,
                    "paddingRight": 5
                  },
}

It returns this error: JSON value 'table-cell-medium' of type NSString cannot be converted to NSNumber, so cell-medium is interpreted as literal string; if I try to use cell-medium as value in a not nested object it works.

Ok, so I've mapped the code flow and found a solution but I'm asking here if anyone has an idea on how implement it without overwriting the source code.
In<EMAIL_ADDRESS>I've modified function withStrictTokens in this way:
unction withStrictTokens(mapping, theme) {

    return Object.keys(mapping).reduce((acc, next) => {
        let currentToken = mapping[next];
        /* MAPPING
          iconMarginHorizontal: 10,
          borderColor: 'transparent',
          backgroundColor: 'color-basic-transparent-200',
          textColor: 'text-primary-color',
          iconTintColor: 'text-primary-color',
          minWidth: 'size-medium',
        */

        /* NEXT
        iconTintColor
        */

        /* theme
        è l'oggetto con le variabili definite in "strict" in mapping.json
        */

        if(isObject(mapping[next])) {
          let o = mapping[next];
          let k = Object.keys(o).reduce((acc, next) => {
            const currentToken = o[next];
            const nextToken = common_1.isNil(theme[currentToken]) ? currentToken : theme[currentToken];
            return Object.assign(Object.assign({}, acc), { [next]: nextToken });
          }, {})
          currentToken = k
        }
        const nextToken = common_1.isNil(theme[currentToken]) ? currentToken : theme[currentToken];
        return Object.assign(Object.assign({}, acc), { [next]: nextToken });
    }, {});
}

@aminta are you trying to create mapping for your custom component? I think current mapping implementation was not designed to be used with nested objects. if you check UI Kitten components, each component which is compound extracts style object for each sub-component from flat object with no nested structures. having nested structures inside mappings may be a nice thing to have, but it will increase complexity for validation and for style generator. not sure if we're going to work on it for nearest release.


Corrected URL

Corrected URL and anchor text

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Unclear whether AVA uses ChatGPT

While the plugin claims to use ChatGPT, the codebase seems to suggest that it uses text-davinci-003 instead.  It would be really useful if the communication was just a bit clearer, so that we know what we're using.

@rizerphe hey, apologies for the confusion
we cannot open source the text generation api as of now but it uses chatgpt, ignoring what the client is sending.


SMTP Notifications not working. "Self Signed Certificate" error

I get this error no matter the deployment. unraid with postfix as smtp server and ubuntu using exchange as smtp, both in different sites keep giving me this error. I can't setup SMTP notifications. Any idea how to get around it? Both sites have certificates.

Implemented, ignore tls error will be available in the next version.
https://github.com/louislam/uptime-kuma/commit/dd283423ab230862e2e3ee2514265c063b34e349


Introduce configurable bbs client timeouts

A short explanation of the proposed change:
Make the timeouts used by diego bbs client configurable.

An explanation of the use cases your change solves:
We noticed that the hardcoded values of 10s is not enough in environments with more than 100,000 apps. This PR allows a configuration that can be adjusted to the specific environment.

Links to any other associated PRs
https://github.com/cloudfoundry/capi-release/pull/110

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the master branch

[x] I have run all the unit tests using bundle exec rake

[x] I have run CF Acceptance Tests

@petergtz it looks like there are some unit test failures with the most recent commit. I think you'll need to add the new config properties to the test config fixture here:
https://github.com/cloudfoundry/cloud_controller_ng/blob/bda08a42825cf302b85072f4f6e5a6b4b7b39877/config/cloud_controller.yml#L247-L251
You'll also need to add the config to this schema: https://github.com/cloudfoundry/cloud_controller_ng/blob/master/lib/cloud_controller/config_schemas/deployment_updater_schema.rb#L47
Thanks!


Refactor and simplify SeqState n k

Issue number
ADP-1308
Overview
Previous work in epic ADP-1043 introduced delta encodings, DBVars, and an embedding of the wallet state and its delta encodings into a database table. It's time to integrate these tools with the wallet code. To facilitate code review, the integration proceeds in a sequence of refactorings that do not change functionality and pass all unit tests.
In this step, we continue refactoring the address discovery state. Here, we refactor and simplify the SeqState n k type to use the new abstract data type Pool addr ix, which aids with BIP-44 style address discovery.
Details

The testing module PoolSpec now also provides a shrinker shrinkPool for use in the old testing module Cardano.Wallet.Primitive.AddressDiscovery.SequentialSpec.
The property tests pertaining to the address discovery aspects of SeqState are superseded by the more general unit tests in Cardano.Wallet.Address.PoolSpec.

Comments

Merge PR ##3068 before this one, because this pull request is based on the branch of the former.

bors merge


Not in the package.json. Found in: /.history/Gruntfile_20170419193103.js

Not sure why do I get this error for some modules

@jitendravyas it shouldn't check .history folder. Isn't there a config to ignore that?
If not, you can just delete this folder or ignore this error by now.


Mac app doesn't load window after application start.

I went to the releases, downloaded v0.1, put into Applications folder and opened app (named electron-quick-start).
No window opens, program does not show up in dock, however, process for electron-quick-start shows up in Activity Monitor.
Expected behavior: Program opens, window appears for me to use. (and rename app to something other than electron-quick-start 😄).
Great program! I am going to find this really handy! Can't wait to use.

@levibostian,  I forget to say it is tray app :)  Please check Menubar! octocat smile to you!

Rename is important thing. Thank you :)

check this
Please tell me when you find a problem or additional features!

Awesome. The rename is nice, thanks.
Is it possible when the app is first loaded the menu bar app could expand to indicate that it is running? Without knowing it's a menu bar app, I did not realize I had it installed until you mentioned it in here.

OK I'll do this next release :)


For SLDSAccordian in base case, a panel once toggled open cannot be closed

Thank you for filing an issue!
Please review the frequently asked questions such as:

Why do my icons not show up in IE11?
Why aren't my ES6 imports, icons, styles, or fonts working in Create React App?

Please include in your issue:
For SLDSAccordian in the base case, a panel once toggled open cannot be closed by again clicking on the toggle.

If you are working on the problem. Issues may be closed within 30 days if no one is assigned. Maintainers work on this project 20-30 hours per week and have their own prioritized backlog.
How to duplicate a bug. Line numbers or code to paste into the documentation site examples is helpful.
If you are a Salesforce employee. You should also create a duplicate work item in your internal ticket system and link to this issue.
If you plan to work on a new component. Please propose props after reviewing at newly written components and docs/codebase-overview.md.

For Salesforce platform questions, please visit https://success.salesforce.com, https://partners.salesforce.com, or https://salesforce.stackexchange.com
This project uses SLDS markup, but you should submit HTML/CSS issues to https://github.com/salesforce-ux/design-system.

@interactivellama Can you please review this issue


feat(consensus): tx envelope tx hash

Description
Adds a helper method to the OpTxEnvelope to return the inner transaction hash.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#324 👈
main

This comment was automatically generated by st.


The template of the remote component is not compiled

Version
3.0.4
Reproduction link
https://github.com/efoxTeam/emp/tree/vue3-template-no-compiled
Steps to reproduce
When I use the introduction of remote components through EMP of base module federation , the remote component template of Vue3 is not compiled.

git clone https://github.com/efoxTeam/emp.git
git checkout  vue3-template-no-compiled
yarn
yarn lerna bootstrap
cd ./projects && yarn dev:vue
cd projects/element-plus && yarn dev

http://localhost:8006/

What is expected?
The remote component template of Vue3 is compiled.
What is actually happening?
The remote component template of Vue3 is not compiled.

https://github.com/efoxTeam/emp/issues/18

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.
This should help you https://v3.vuejs.org/guide/installation.html#explanation-of-different-builds
FYI: https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro

But no resolve my problem


tree: clientset: remove unused and unsupported code

remove autogenerated clientset. No record of it being used since 4.12 at least, perhaps earlier. It was introduced and never really got traction, so high time to get rid of it
Fixes: #809

/hold
before to move forward, let's check the backward compatibility concerns, because this is a published package

/hold cancel
we figured out the backward compatibility concerns and we can move on with this change, let's just never backport it for any reason


How can we debug Python or C# Azure IoT Module in VS Code

Hello Team ,
We are trying to debug Azure IoT Edge module in VS Code, we have installed all required prerequisites but it shows below exception.
Error
Connect ECONNREFUSED <IP_ADDRESS>:15678

Can you please help us to resolve this issue ASAP ?
or if you have any link or document which can help us to demo how to debug the this IoT Edge module in VS code please share the same.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4cdb69f-46f8-26c2-0518-b3816ed287ec
Version Independent ID: fd679e7b-0da6-0d67-9ed5-ce4b19636f6e
Content: Tutorial - Develop module for Linux devices using Azure IoT Edge
Content Source: articles/iot-edge/tutorial-develop-for-linux.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@abhijitkakade914 Thanks for your feedback! We will investigate and update as appropriate.

@abhijitkakade914 Thanks for reaching out to us!. Could you please confirm on below point to better assist you in this matter.

What is the system architecture, target OS , host OS you have ?
Could you please confirm the exact document you have followed for developing and debug IoT Edge module in VS code?
Please also confirm if this error is with both languages Python & C# ?

@abhijitkakade914 Just checking back, Could you please conform on the below ask, so that we look into the issue.

What is the system architecture, target OS , host OS you have ?
Could you please confirm the exact document you have followed for developing and debug IoT Edge module in VS code?
Please also confirm if this error is with both languages Python & C# ?

@abhijitkakade914 Just checking back! Please let us know if you need further help.

Hello @abhijitkakade914 ,Since we didn't received any response, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
For any further technical questions you can also make use of Microsoft's Q&A forum where a large number of community members collaborate to help each other on similar technical challenges.


`GLIBC_2.32' not found

The new image mcronce/oci-registry:v0.3.19 fails to start with the following error;
/usr/local/bin/oci-registry: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /usr/local/bin/oci-registry)
/usr/local/bin/oci-registry: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /usr/local/bin/oci-registry)
/usr/local/bin/oci-registry: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /usr/local/bin/oci-registry)

A fix for this went up yesterday - using the same tag, v0.3.19

Leaving this open as a reminder to create an automated test in CI that at least makes sure the container starts - my manual test was with the wrong image


ProductUpgrader: only write newest version available

When an upgrade is available, GVFS will download the update in the
background, and git commands will periodically check for the existence
of the downloaded package in a well known directory to advertise that an
update is available.
However, this downloaded update is not used for the actual update.
This changes the logic to write out a file in a well known location
containing the version of the latest available update, and avoid
downloading the actual update.
While this change stands on its own, it will be even more applicable
with the NuGet Upgrader, which will still use GitHub releases to check
for available updates, but will download the actual update from another
location.

Functional tests for Upgrade reminder messaging has to be updated to use the new highestAvailableVersion file.

@jamill I just noticed this PR is into master, should it be into the feature branch so that we can test all of the upgrader changes together?

@jamill I just noticed this PR is into master

That was intentional - but I should have called it out. As this change stands on its own, I targeted master. I don't mind targeting the feature branch, but my thought was this keeps the feature branch smaller... On the flip side, it could introduce churn in the feature branch as it will need to absorb these changes, but I felt this was the easier path overall.
I can target either branch if people prefer otherwise.


Release 1.5

Update SDK to support GraphLab Create 1.5.
Break ABI compatibility to earlier versions.

@ylow  Please review

@znation Thanks, your feedback is addressed with the new commit.


Rocky image failing due to 404 on lustre-client

If you find a similar existing issue, please comment on that issue instead of creating a new one.
If you are submitting a feature request, please start a discussion instead of creating an issue.
Describe the bug
I am unable to either create a new image using Packer or use an init script that installs a dependency due to this error related to lustre. I am not sure why this is happening, I get the same error with any package
[jcastellanos@red-l4spotnodegrou-2 custom_scripts]$ sudo yum install nano
Lustre Client                                                                                2.4 kB/s | 855  B     00:00
Errors during downloading metadata for repository 'lustre-client':
  - Status code: 404 for https://downloads.whamcloud.com/public/lustre/latest-release/el8.9/client/repodata/repomd.xml (IP: <IP_ADDRESS>)
Error: Failed to download metadata for repo 'lustre-client': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

this start happening over the weekend
A clear and concise description of what the bug is.
yum install any package produces the same behaiviour
Steps to reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
What happened instead.
Version (ghpc --version)
ghpc version v1.31.1
Blueprint
If applicable, attach or paste the blueprint YAML used to produce the bug.

Expanded Blueprint
If applicable, please attach or paste the expanded blueprint. The expanded blueprint can be obtained by running ghpc expand your-blueprint.yaml.
Disregard if the bug occurs when running ghpc expand ... as well.

Output and logs

Screenshots
If applicable, add screenshots to help explain your problem.
Execution environment

OS: [macOS, ubuntu, ...]
Shell (To find this, run ps -p $$): [bash, zsh, ...]
go version:

Additional context
Add any other context about the problem here.

@javierbq could you please attach a blueprint to your issue report? It helps us confirm the details of our response.
That said, I believe you are attempting to use a Slurm image based on Rocky Linux 8. The upstream Whamcloud/DDN repositories for Lustre have reorganized around Rocky 8.10 while the current images remain based on 8.9. We are working on updates to resolve this. It will probably include a new Slurm image based upon Rocky 8.10, though we will announce details when ready.
The pattern we recommend is to:

Disable the lustre-client repo
Upgrade your base OS to Rocky 8.10
Modify the lustre-client URL to point to 8.10 packages
Upgrade remaining packages (lustre)

A solution that would work in automated environments, by prepending this runner to your startup scripts:
settings:
  runners:
  - type: shell
    destination: upgrade_os_lustre.sh
    content: |
      #!/bin/bash
      dnf upgrade --disablerepo=lustre-client -y
      sed -i 's,el8.9,el8.10,' /etc/yum.repos.d/lustre-client.repo
      dnf upgrade -y
   ... # add remaining runners from your blueprint

thamks @tpdownes. I figured out the same. I was able to work over the problem by deleting lustre from the yum repo.

@tpdownes would it make sense to lock to specific Lustre version instead of going with whatever 'latest-release' is to prevent something like this from happening in the future?
https://github.com/GoogleCloudPlatform/slurm-gcp/blob/47416536624dc9fe99ca731a8bc2d927fabbf409/ansible/roles/lustre/vars/redhat-8.yml#L15

There is a fundamental issue here in that, if you pick a specific Lustre release, Whamcloud does not support updating the minor version of RedHat OS itself. e.g., look at:
https://downloads.whamcloud.com/public/lustre/lustre-2.15.1/
I think I may be able to work around this with something like:
https://downloads.whamcloud.com/public/lustre/latest-release/el$releasever/client

but, we would to override the default value of $releasever from 8 to 8.10... etc.
The good news is that 8.10 is the final release of Rocky 8, so we may be able to get away with hard-coding 8.10. 8.10 will be under support through 2029.

Update:

all future updates will use a URL with 8.10; because no new releases of Rocky 8 are planned, we believe this change will last as long as Whamcloud provides Lustre support on Rocky 8
we pushed a minor update to the latest Rocky 8 images for the "v5" and "v6" Slurm-GCP solutions that correct the URL to use a previous release (2.15.4):

https://downloads.whamcloud.com/public/lustre/lustre-2.15.4/
Users should be aware that upgrading from 8.9 to 8.10 appears to bring in a kernel that is not compatible with luste-2.15.4 DKMS modules. In my testing, the DKMS system re-compiled the lustre modules for the new kernel, but the modules failed to load. I found it necessary to update the yum repo configuration in /etc/yum.repos.d/lustre-client.repo to the latest-release or 2.15.5 modules:
https://downloads.whamcloud.com/public/lustre/latest-release/


Message System

Create a way for administrators to disseminate a message out to all users.
Additional functionality for polling for messages would be a good idea.

Message system will be moved to the next schedule release.

Basic message system implemented. Top down model allowing Administrator and Supervisors to send messages to their assigned staff accounts.


Block folding at the end of method definition results in cut whitelines

Check for existing issues

[X] Completed

Describe the feature
Currently when folding the block (python) at the end of method definiton (at colon) it will disregard follow up whitespaces (PEP-8 formatting requirement). The block folding should respect the inserted/formatted whitelines.
If applicable, add mockups / screenshots to help present your vision of the feature
Currently the folded code presents itself such as:

It would be more elegant to work with if it presented itself such as:

or

I've ran into this before.  I'm to elevate this to the team.

FYI: the behavior kind of improved, so I much appreciate it, however, there is still a bit of clunkiness, such as, now we have

At least a line of space would make it more visible, such as:

At to finish it, would be nice to have an option at least via CMD+SHIFT+P such as Fold all blocks with extra plus to be able to fold on different levels, such as K+0, K+1, K+n, depending on function nesting.
And to extend it more, what would come handy is to have ability to fold all Docstrings... CMD+SHIFT+P -> Fold Docstrings would suffice.


Add An Extension for Windows Sandbox

Suggested new feature or improvement
A Dev Environments extension that can launch Windows Sandbox.
Scenario
Launch and store configurations for Windows Sandbox.
Additional details
No response

It seems the commits have been reverted. This issue needs to be reopened.


"Pathways" proposal

Background
ScholarSphere is a general purpose repository that allows users to deposit all types of research materials -- data, instructional materials, articles, etc. This flexibility has been important to the repository's growth but it also comes with some downsides. All content types in ScholarSphere are treated pretty much the same way: they share a common deposit process and the same validation rules apply across the board. A one-size-fits-all approach makes it difficult to tailor the application for specific, important categories such as open access journal articles and FAIR datasets. This proposal would address the problem by introducing a new abstraction (the pathway) that encapsulates details relating to submission, validation, and (potentially) access. This proposal would not completely replace the existing general-purpose deposit process; it would permit additional customized processes tailored to particular use cases.
Defining Pathways
The functionality that pathways should provide becomes more clear by considering two use cases: OA versions of published journal articles (postprints) and curated research data & code (FAIR data).
Example 1: OA Journal Articles
With the implementation of Penn State's Open Access Policy, open access versions of published journal articles (postprints) are an increasingly important category of new submissions to ScholarSphere. Most postprints are now deposited to ScholarSphere through the new Researcher Metadata Database integration, which significantly simplifies the deposit process by taking advantage of article metadata aggregated in RMDB and presenting users with a customized UI. In essence, the RMDB integration constitutes a unique pathway for depositing OA versions of journal articles. ScholarSphere itself, however, doesn't treat these submissions any differently than it would a self-published report or a dateset. A more complete pathway for depositing and accessing OA versions of journal articles to ScholarSphere might include the following:

Journal name & publisher are required metadata fields (instead of optional)
Publisher DOI is heavily emphasized / strongly recommended
DOI minting is disabled (publisher DOI should be used, if available)
"Penn State Only" option is disabled
Works are indexed by services like Unpaywall.
Ability to scope searches to "OA Journal Articles"
Message/badge on work page stating that the article was deposited as part of Penn State's Open Access Policy.

The functionality above would significantly improve the accessibility and user experience of OA articles on ScholarSphere. However, this logic is not appropriate for all works on ScholarSphere --- for example, datasets and student work should not be indexed by Unpaywall. A dedicated pathway for OA journal articles would support this kind of application logic.
Example 2: FAIR Data
Research data is another important category or work on ScholarSphere. Funders and journals increasingly require researchers to deposit datasets (i.e., supplementary materials for published articles) on repositories that enforce FAIR principles. FAIR datasets must have DOIs, good metadata, and complete documentation; typically, they must go through a data curation process involving some revision by the depositor. These are optional rather than required features for datasets deposited on ScholarSphere, which has lead to some confusion (from users and journal reviewers) as to whether ScholarSphere actually complies with the FAIR principles. ScholarSphere's commitment to the FAIR principles would be more explicit through a pathway with the following features:

Work type should be either "Dataset" or "Software"
Requires DOI minted by ScholarSphere
Penn State Only Access is disabled
A "README" file is required
Publishing is not possible without curatorial review
Message/badge on work page stating that the data supports FAIR principles, went through curatorial review.

Requirements
From the preceding examples, the requirements for implementing pathways are more clear. Pathways should allow:

customized deposit process/form
customization of required metadata
customization of pre-publication validation
customized work view page
per-pathway "feeds" (i.e., for third-party indexing)

Pathways are closely related to 'work types',  but they involve more complexity because they determine how a work is deposited and the rules that new submissions are validated against. In addition, pathways are independent of work types in the sense that a pathway may permit any number of work types.
User Experience of Pathways
ScholarSphere users would primarily interact with pathways during the submission process. At deposit, they would be given a choice: use one of the available pathways ("ScholarShere-OA", "ScholarSphere-FAIR Data") or use the current, general-purpose deposit form. Using one of the pathways should generally provide a more user friendly experience and result in higher-quality submissions. The general-purpose deposit form is available for other kinds of content and/or "advanced" use cases.
Pathways may also affect how people find and access materials. For example the basic search interface might include options to scope the search to "All of ScholarSphere", "Journal Articles", "Research Data."

I would love to see this happen. Tailoring ScholarSphere's approach to deposits of postprints under the OA policy will improve the user experience and increase access.
Minor point: Unpaywall excludes non-CrossRef DOIs, so it's probably not necessary (at least not for that reason) to limit what's available via OAI-PMH. (see #183)

This looks great and I also would love to see this happen! For the FAIR data deposits, it seems like it would definitely help with supporting compliance with funder data sharing mandates and improving the quality of the data deposited to ScholarSphere. I am curious if it would make sense to facilitate project based/manuscript based deposits that include multiple work types or work type at a file or folder level. Have you had any feedback on this from researchers?

[ ] #1460
[ ] #1461
[ ] #1462
[ ] #1463


Run Database locally instead of MongoDB

One major issue with using a service like Mongo DB is using a third party to store student credential information which possesses a security concern for the institution involved
A preferred solution would be to be able to run the database locally instead of connecting to a "cloud" based database
.

Atlas, MongoDB’s fully managed service, is recommended in the README for ease of use. You raise a valid concern about third-party storage and student information. Luckily you can self-host the data storage using MongoDB Community Edition.
The README has needed an overhaul for a while. The next release should include the following steps for those wishing to self-host the database.

Install MongoDB Community Edition
Start the server mongod
Enter the shell mongosh
Within the mongo shell, create a database named eyra use eyra
Still inside mongo shell... create a database user db.createUser({ user: “admin”, pwd: “password”, roles:[“readWrite”,”dbAdmin”] })
Navigate to the directory where Eyra is installed. Connect Eyra to MongoDB node setup.js mongodb://admin:password@localhost:27017/eyra


ReadNextAsync with ORDER BY query loads all items at once

Describe the bug
FeedIterator.ReadNextAsync() reads all data for queries with ORDER BY.
NOTE:
All queries in our application are single partition queries (Partition key is specified).
To Reproduce
Here is small repro.
https://gist.github.com/KristianJakubik/8d90c3b97e385c461df012acbc14a2f8
Expected behavior
I expected, that ReadNextAsync() would return small portion of data. The same portion as it does when I call query without ORDER BY.
For query which should return in total 1000 items, first call to ReadNextAsync() returns only 100 items.
Actual behavior
For query which should return in total 1000 items, first call to ReadNextAsync() returns all 1000 items.
Environment summary
SDK Version: 3.6.0, 3.7.0 preview 2
OS Version: Windows
Additional context
This is pretty serious bug for us. It directly impact our customers. Order by queries are not bearable for our Cosmos Db anymore, they drain so much RUs and take so much time to execute, when one ReadNextAsync load whole query at once and does not divide it in smaller chunks
(continuation token is useless) as it used to be in v2 sdk.
We have designed our application, that our client works with continuation token from cosmos sdk and therefore client decides when it wants to load additional data (lazy approach). This way the load on our database was easily maintainable, with new v3 sdk this is not possible.

@KristianJakubik can you set the MaxItemCount?

@j82w
This is not feasible solution for us. The client already sets how much data is able to process by setting MaxItemCount property. So this property is in use already 😄. For some cases client can process much more data, than current Cosmos DB instance is scaled for. When this occurs, client uses continuation token to load another batch after processing current one. This worked like a charm until ORDER BY queries came into play. And now we can't process data by batches, however we have to wait when whole query is executed, which leads to 429s and query which takes 40sec to execute 😄. That's why we relied on this behavior.
We have different cosmos instances and one instance can be scaled to 1 000RUs another can be up to 40 000RUs. If we specified one general constant for all of them, one cosmos db can be overheated and others won't be fully utilized up to their defined scale.
I have tried to make it as abstracted as possible. I hope it helped a little bit to understand more of our use case and that fix of this bug is really important for us.

@KristianJakubik can you set the MaxItemCount?

We have already released hot-fix with specified universal upper bound for MaxItemCount value, but this solution is really not scalable for our application and we hope it is temporarily, otherwise we can't use v3 sdk.
@j82w
Please can you let me know, if this bug has any priority and if you have any plan solving this in near future?

If you don't set a MaxItemCount then you are relying on undefined behavior. The service is going to change and optimize the payload based on user feedback and performance testing results. Based on some quick testing the service is returning 1000 items in a single page request, and is not draining the entire query. On your original post you only want the service to return a 100 items per a ReadNextAsync then you need to set QueryRequestOptions.MaxItemCount to 100. Just to clarify MaxItemCount is not a overall query max it is the max per a page from Cosmos DB. If you want a query to drain more for some containers than other then you need to change the value. It's not possible for the service or the SDK to determine how much load your configuration can handle.

@j82w
It seems to me that we don't understand each others reasoning. Anyway I need some time to create the more descriptive repro, should be ready by the end of this week. Could you please keep this issue open until that time.

@KristianJakubik that would be great if you have a more descriptive repo. Sorry I'm not understanding the problem.

It's not possible for the service or the SDK to determine how much load your configuration can handle.

Yes, I fully agree. Neither client nor service nor SDK can decide what is the optimal limit. Although in my opinion It should be decided by cosmos db instance, what is its upper limit, how much data it can deliver regarding its RUs configuration.
I've updated the gist with set MaxItemCount property and I've used Fiddler as http proxy.

SQL
# items returned by ReadNextAsync
MaxItemCount
total # items in container
# http requests in one ReadNextAsync
# items return in one http call
total RU cost

without order by
207
1200
1500
1
207
140.75

order by
1200
1200
1500
6
206
854.31

without order by
100
null
1500
1
207
69.46

order by
1000
null
1500
5
206
712.32

without order by
207
-1
1500
1
207
140.75

order by
1500
-1
1500
8
206
1038.03

I did three measurements against cosmos instance scaled up to 400 RUs, 2 000 RUs, 10 000 RUs. Surprisingly the result for all three of them was the same and it seems, that the response from each http request is maximum of 4.2MB. My previous assumption was that this size would vary based on container's scale.
Expected behavior:
I would expect, that ORDER BY queries would return from ReadNextAsync() the same number of items as does for quieries without ORDER BY clause. And one call to ReadNextAsync() would represent one call to cosmos instance, the same way it does in non ORDER BY queries.
@j82w
I hope we are now more on the same page 😃. If you have any more questions, want more detailed explanation, more detailed data from measurements or anything, please feel free to ask.

@bchong95 can you take a look?

@KristianJakubik thanks for the information. I have a question for you. Can you elaborate a bit more what are your concerns about setting the MaxItemCount to 100? It seems like a suitable approach for me, because setting the MaxItemCount is the way we indicate to SDK the upper bound of the data it should target to retrieve. Without setting this value essentially means letting the SDK decide this on its own. Different queries are executed with different default behavior. In fact, as j82w mentioned, the SDK or the service doesn't know what is the behavior that you expect,, which varies by scenarios. Some other users may prefer the SDK to return more results in one page. Therefore, it seems reasonable to set MaxItemCount to achieve a specific behavior.

So if I set MaxItemCount to that 100, is it guaranteed to fetch the 100 documents in a single request? That doesn't feasible. And if it actually really weren't, is there a way to stop the query after the first request? How low MaxItemCount would I have to set, other than dropping the order by clause?

@khdang thank you for helping me to figure out the issue and for joining to this conversation.
I'm not exactly concerned about the number of retrieved items, I'm definitely more concerned about the amount of underlying http requests from the sdk to the cosmos instance.
You can see in second row of my table, that when I specified MaxItemCount to 1200 the sdk did 6 http requests for retrieving data and returns exactly 1200 items. And yes, on our production enviroment this behavior usually leads to 429 responses, unnecessarily long running queries and RU's starvation.

MaxItemCount is the way we indicate to SDK the upper bound of the data it should target to retrieve.

I don't think for queries with ORDER BY  this is true. In my experience the sdk handles MaxItemCount property as exact number of items it should retrieve, definitely not UPPER BOUND.
@khdang

If MaxItemCount was handled as UPPER BOUND restriction, why would the sdk load additional data with more http requests?
Why wouldn't be the count of items returned by ReadNextAsyncsufficient, when they absolutely fulfill your condition: number of items <= MaxItemCount?
Why there are so many useless http requests then?
(please look at the first and second row of the table)

Looks like the customer confirmed that this has been fixed a few years ago:


Commit conventions

Description
We would like to document the commit conventions of this project in a new documentation/commit-conventions.md file.
Checklist

[ ] Document the commit conventions of this project.
[ ] Update the Unreleased section in the changelog.

Resources

Convetional Commits.
Conventional Commits: A Better Way, article by Michael Collins in Neudesic Innovation.

Resolving this issue is not essential for now.

Done by this commit 99e467c2204ae0a56242475605805a3b58f8b80a.


app start failed

followed the https://github.com/abetlen/ggml-python/tree/main/examples/replit example ,got the following error.
please tell me how to deal with it?
(base) [test@rockytest replit]$  MODEL=/data/ggml-python/examples/replit/replit-code-v1-3b-q4_0.bin uvicorn app:app --reload --host <IP_ADDRESS> INFO:     Will watch for changes in these directories: ['/data/ggml-python/examples/replit'] INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit) INFO:     Started reloader process [61255] using StatReload Process SpawnProcess-1: Traceback (most recent call last):   File "/home/test/miniconda3/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap     self.run()   File "/home/test/miniconda3/lib/python3.10/multiprocessing/process.py", line 108, in run     self._target(*self._args, **self._kwargs)   File "/home/test/miniconda3/lib/python3.10/site-packages/uvicorn/_subprocess.py", line 76, in subprocess_started     target(sockets=sockets)   File "/home/test/miniconda3/lib/python3.10/site-packages/uvicorn/server.py", line 61, in run     return asyncio.run(self.serve(sockets=sockets))   File "/home/test/miniconda3/lib/python3.10/asyncio/runners.py", line 44, in run     return loop.run_until_complete(main)   File "/home/test/miniconda3/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete     return future.result()   File "/home/test/miniconda3/lib/python3.10/site-packages/uvicorn/server.py", line 68, in serve     config.load()   File "/home/test/miniconda3/lib/python3.10/site-packages/uvicorn/config.py", line 473, in load     self.loaded_app = import_from_string(self.app)   File "/home/test/miniconda3/lib/python3.10/site-packages/uvicorn/importer.py", line 21, in import_from_string     module = importlib.import_module(module_str)   File "/home/test/miniconda3/lib/python3.10/importlib/__init__.py", line 126, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 1050, in _gcd_import   File "<frozen importlib._bootstrap>", line 1027, in _find_and_load   File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 688, in _load_unlocked   File "<frozen importlib._bootstrap_external>", line 883, in exec_module   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed   File "/data/ggml-python/examples/replit/app.py", line 533, in <module>     settings = Settings()  # type: ignore   File "pydantic/env_settings.py", line 39, in pydantic.env_settings.BaseSettings.__init__   File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__ pydantic.error_wrappers.ValidationError: 1 validation error for Settings model_file   field required (type=value_error.missing)

You need to provide Settings with the path to your ggml model inside app.py at the following line: https://github.com/abetlen/ggml-python/blob/c4cb698cd2068addafe0b2b4fd3c63b49061f5c8/examples/replit/app.py#L533