Rails 5.2 support, drop Rails 4.2 support.

Based on https://github.com/mbleigh/acts-as-taggable-on/pull/872 with extra changes on top
I've also dropped Rails 4.2 support, as it requires lots of hacking around in the code - dirty implementation changed a lot since then.
Also, currently this branch uses master versions of many rspec gems. Once Rails 5.2 and Rspec 3.8 are released, this PR can be safely merged.
In the meanwhile, feel free to use my fork. We use it in prod, so far so good.

@Erowlin I've incorporated your valuable feedback :) I've also updated PR description, dropped Rails 4.2 support and fixed tests. They still somehow failed in same combinations, I will try re-triggering to see what happens.

@Fodoj Thanks! Really saved our butts with this PR.

I noticed that there's also another PR for a similar fix: https://github.com/mbleigh/acts-as-taggable-on/pull/862
Any relationship between these two branches?
Anyway, I'd love to see this get merged!

@lunaru yes, I used code from 862 in this PR, forgot to mention it

@Fodoj Shouldn't the old version also be tracked?
Example:
i.label_list
=> ["foo", "bar", "low priority"]
i.label_list = "foo"
=> "foo"
i.changes
=> {"label_list"=>[nil, ["foo"]]}

I would expect the old array to display as the first value in i.changes array.

🎉 very happy to see this close to the finish line

Is this fully blocked on Rspec 3.8?

👍 I'm having issues with rails 5.2 and the current gem release so I hope this gets merged soon

@Fodoj Any thoughts on my comment above? I think this is at least worth addressing before merging. The changeset always being nil -> [foo, bar] isn't correct.
The reason this isn't working is because the model's attribute is not being initialized with the current list.

 I'm very excited to see this merged!

@PhilCoggins which Rails version do you use? There are tests for this behavior and from what I can see tracking works fine, for example:
taggable = TaggableModel.create(tag_list: 'awesome, epic')
#=> #<TaggableModel:0x000056219f1b3200 id: 2, name: nil, type: nil>
taggable.tag_list = 'foo'
#=> "foo"
taggable changes
#=> {"tag_list"=>[["awesome", "epic"], ["foo"]]}

See also spec/acts_as_taggable_on/taggable/dirty_spec.rb
Basically, them gem already had pretty good test coverage around dirty changes, so I relied on them to tell me if behaviour is the same.

@Fodoj Yes, if the model is initialized with the label list, then it works properly. But what about when I instantiate an already existing record?
i = Issue.create(label_list: "foo, bar")
i.label_list = "baz"
i.changes
=> {"label_list"=>[["foo", "bar"], ["baz"]]} # Good
i = Issue.find(i.id)
i.label_list = "baz"
i.changes
=> {"label_list"=>[nil, ["baz"]]} # Bad

Using Rails 5.1.4, FWIW.

Got it now, let me fix it :)

@PhilCoggins should be fixed now, though let's wait for Travis to confirm. I've added a spec as a proof that it's fixed: https://github.com/mbleigh/acts-as-taggable-on/pull/887/commits/7b4911aa6b84d6bdf4663aa067a5f617a5ee8014.

@Fodoj I just tested on my end, works great! Thank you for addressing this 💯 .

Hi @Fodoj, it looks to me like all of the Rspec commits since 3.7 are just edits to the README. Are you sure we can’t just use Rspec 3.7 instead of the master branch?
Then we wouldn’t have to wait to merge. :)

@brchristian you are absolutely right! Not sure now why did I even use edge versions in the first place. I guess nothing stops @Erowlin from merging this PR now :-)

When this PR is going to be merged? I can't wait.

Hey, i just reviewed the code, i have no merge rights on this repository, otherwise it would’ve been merged for a long time ;)

Would @seuros be the person to talk to here? Seems like a few folks (myself included) are waiting on this for Rails 5.2 compatibility.

if that's won't be merged in next couple of weeks, I will just rename it to acts-as-taggable-on-next and publish it on rubygems so people can install it easily. Agree?

This gem should be handled and administrated by the Ruby and Rails community in order to keep it always up-to-date and improved!

Hello, I'm really confused as to how to implement this fix in my rails app. If anyone can point me in the right direction that'll be really awesome. Thanks in anticipation.

Hi @patrickoramah until this PR gets merged, you can use the branch where the PR is coming from in your Gemfile, like so:
gem 'acts-as-taggable-on', github: 'Fodoj/acts-as-taggable-on', branch: 'rails-5.2'

@seuros shot myself in a leg, but now it's fine, single beautiful commit with all the changes. Also added changes you've requested.

@Fodoj Thank you. Do you know why Postgresql build started to fail after  the rebase ?

@seuros it started to fail because master branch is failing https://github.com/mbleigh/acts-as-taggable-on/commits/master

I pushed more fixes. I actually assumed that after 3.5 months someone familiar with the code base already reviewed it, but seems like it's not the case?..

I am not very familiar with the acts-as-taggable codebase unfortunately.

I assume as @seuros has permissions to merge to master, he is familiar. Let's wait for his final go and merge then.
Added new line back also.

Any idea when this will be available as a version? I'm still only able to get version 5.0.0 which doesn't seem to include this fix ...

@Fodoj i'm trying to work on "fixing" the PR that supposedly breaks the build. looking at the Travis report: https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/339031800#L657 it seems to be a gem/config issue that i cannot replicate nor see how my changes could possibly have affected.
Specified 'postgresql' for database adapter, but the gem is not loaded. Add gem 'pg' to your Gemfile (and ensure its version is at the minimum required by ActiveRecord).
i cannot get travis to retry my fork because the PR was closed.


Can I write contracts with only C?

I see that all the examples of contracts are written with C++? Is EOSIO supporting to write contracts with only C? Is there any examples of contracts that written with only C?

C++ is the only language we use and support for EOSIO smart contracts.


refactor(structures): rename create* functions

Please describe the changes this PR makes and why it should be merged:

Renamed create* structure functions to create*Struct.
Renamed the createServer function to createGuild.

Closes #453
Status

[ ] Code changes have been tested against the Discord API, or there are no code changes

Semantic versioning classification:

[x] This PR changes the library's interface (methods or parameters added)

[x] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Can you also rename createGuildRole to createRole?
Add this at the end of the body of the issue:
Closes #453

Can you also rename createGuildRole to createRole?
Add this at the end of the body of the issue:
Closes #453

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: itohatweb:x: aynteeYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: itohatweb:x: aynteeYou have signed the CLA already but the status is still pending? Let us recheck it.


cannot install moffee with pipx

errors as shown in figure

Your python version maybe too low. Currently miffed requires python >= 3.12. I will lower the python version requirement and package again.


fix(datepicker): unknown prop on div tag

Fixes Issue 997 and Issue 998.
This is a Fix for v5
My project has not migrated to React 16.4 so we cannot use your v6. Please merge to v5.
To reproduce with v5 and React 15.x:

The console error does not occur in Storybook (maybe because that uses React 16) but you can still observe the props added to the <div> tag with the React dev-tools.
Start with an app that is successfully using DatePicker component with version "^5.44.0",`
Add a locale prop to DatePicker such as locale: {'fr'} OR a minDate or maxDate prop. All break v5 withe React 15.4.
See error in console
DatePicker will not initialize and will not respond to input.
Console error will appear as in first screenshot
Using React dev-tools to inspect the children of DatePicker will reveal that there is a plain <div> element that is being passed a locale prop, just as the error states.

Hi @DmitriWolf thank you for jumping in to fix this issue! AFAICT the {...other} stuff is for giving consumer more control of attributes in div.bx--date-picker. Therefore the fix should be eliminating only the offending props. Also, if we are making a fix to v5 such change should be done in master, too. Thanks!

Thank you, @asudoh.
I updated the code to leave other. Instead I assigned consts to all the rest of the props we expect (from looking at propTypes).

@asudoh
Thank you for the approval.
Please merge and manually make another v5 release so we can use the updated code.
I will work on making these updates on the current master branch for v6 version.

Hi @DmitriWolf this project takes two reviewers’ approval before getting a PR merged. Also - Could you please make the same PR against master, too? Thanks!

@asudoh I believe this does not require that as this is a merge into a Branch, not into master.
On this PR I see this:

While on the PR to merge into master I see this:

Hi @DmitriWolf though this repo does not seem to have enabled “two reviewers” system rule (somehow), Carbon core takes “two reviewers” rule as the team. Thank you for your patience and understanding!

This PR is included in version 5.52.2


List of our favorite LA meetups

Add your  #favorite/your LA meetup + link + description here
Here I'm defining meetup as somewhere where you bring your laptop and actually code. Not talks.

LA Software Workshops: multilingual, full-stack application workshops / some beginner, some intermediate/advanced / Downtown LA, weeknights and weekends - run by 8th Light consultancy in downtown http://www.meetup.com/LA-Software-Workshops/

Ruby & Rails - East

Learn to Code LA: Beginner Ruby South Pas Study Group http://www.meetup.com/LearnToCodeLA/events/231125799/
Learn to Code LA: Monday Nights / Front End Project workshop nights at Tom n Toms in Little Tokyo
http://www.meetup.com/LearnToCodeLA/events/231402097/
LA Eastside Ruby: Problem Sets @ Panera Bakery in Glendale - longest running Ruby meetup in LA ever?! <3 http://www.meetup.com/LA-Eastside-Ruby-Rails-Study-Group/events/230709907/

CSS

http://www.meetup.com/CSS-LA/

It's a seemingly comprehensive list. Thanks for going to the trouble to make it :) You've failed to miss anything I would have added.

One-off events:

Rails Girls LA
Django Girls

General - Long Beach

Code & Coffee: Casual hack morning; open office space; helpful, welcoming folks!
http://www.codeandcoffeelb.org/

code and coffee changed their meetup page http://www.meetup.com/code-and-coffee-Long-beach/


Pyrealsense2 Runtime Error: No Decive Connected

Required Info

Camera Model
{ D435i }

Firmware Version
<IP_ADDRESS>

Operating System & Version
{Ubuntu 22.04

Kernel Version (Linux Only)
5.15.136-tegra

Platform
Jetson Orin nano

SDK Version
2.55.1 }

Language
Python }

Issue Description
Hi.
I want to connect the camera through pyrealsense and so far I have been unsuccesful. Basically, I get pipe.start() RuntimeError: No device connected everytime I run a Python file. I also tried running the examples from wrappers/python/examples and all of them get stuck in the "No device connected" error. Realsense-viewer works fine, rs-ennumerate-devices always detects the camera, but running the examples from the SKD is inconsistent. Hello-Realsense does not work unless I downgrade the FW to <IP_ADDRESS>. However, other examples such as RS-distance properly detect the camera with the recent FW and run with no issues. The fact that some examples work makes me think this is not a hardware issue.
I followed the Jetson Hacks tutorial for installing Librealsense from source using ./buildLibrealsense.sh -j 2.
Any advice will be greatly appreciated, thanks in advanced.

Hi @desq28  Is the camera detected if you launch your Python script in sudo admin permissions mode?  For example:
sudo python3 test.py

Hi Marty.
I tried using a brief example from the align depth to color example.
import pyrealsense2 as rs

pipeline = rs.pipeline()

config = rs.config()
config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 30)
config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30)

profile = pipeline.start(config)

I still get the same error     profile = pipeline.start(config), RuntimeError: No device connected
I did the build process trying with the master branch and the development branch from Librealsense (after uninstalling previous build), using the following command, but I still get stuck with the RuntimeError. Realsense-viewer still correctly detects the camera.
mkdir build cd build cmake ../ -DFORCE_RSUSB_BACKEND=ON -DBUILD_PYTHON_BINDINGS:bool=true -DPYTHON_EXECUTABLE=/usr/bin/python3 -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true -DBUILD_WITH_CUDA:bool=true make -j2 sudo make install
I will attempt to downgrade back to Jetpack 5.1.3 and check if the library works, but I would appreciate your help to get it running in JP 6.0.
Thanks!

Hey @MartyG-RealSense. Couldn't figure it out, so I installed the development branch of Librealsense and then tried running examples such as align-depth2color.py or opencv-viewer_example.py and, indeed, it works and the camera is detected. I can't believe the solution was so simple. Why do I need to use sudo? Did I miss any steps which grant permissions?
Thanks for your help.
I followed this commands to install, just in case it helps anyone.
cd librealsense
mkdir build
cd build
cmake ../ -DFORCE_RSUSB_BACKEND=ON -DBUILD_PYTHON_BINDINGS:bool=true -DPYTHON_EXECUTABLE=/usr/bin/python3 -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true -DBUILD_WITH_CUDA:bool=true
make -j2
sudo make install

You are very welcome. I'm pleased to hear that you achieved a solution.  Thanks very much for sharing the details of it!
When performing a build of librealsense from the source code folder, the udev rules that handle device access permissions are installed by running the ./scripts/setup_udev_rules.sh udev permissions script in the root directory of the source code folder (the same directory that the mkdir build command is used in).
If there is a problem with device access that is caused by a problem with the udev rules (such as them being missing) then sudo admin power can be used to run a program.

Hi @MartyG-RealSense.
Just checked and the file 99-realsense-libusb.rules is indeed located at /etc/udev/rules.d/. Do you have any other ideas about what may be causing issues with the permissions? Also, marking this as closed since main issue was solved.
Thanks!


Can dashboard load no collections ?

I customized the dashboard template without problem, but I felt that the collections are still loaded by default. So what is the magic line to disable them, ex.

        app.dashboard().template('<dashboard-page></dashboard-page>');
        app.dashboard(xxxx);

thanks.

ok, thanks for the doc,

	        app.dashboard(nga.dashboard().template('<dashboard-page></dashboard-page>'));


Add python-lsp-ruff to docs

Thank you for this package!
Just one thing that I think should be added to docs and mentioned in the extension itself: python-lsp-ruff seems to be a required dependency. Without it the linter was not showing any results from ruff.
https://github.com/python-lsp/python-lsp-ruff

The python ruff, which is mentioned as a requirement in the readme file (pip install ruff) suffices for pulsar-linter-ruff to work.
When installing the python package python-lsp-ruff (python-lsp-ruff) (which depends on ruff), pulsar's built-in linter package kicks in and lints using ruff too, even if pulsar-linter-ruff is disabled.
I have just disabled pulsar-linter-ruff, because it requires the user to manually specify the severity levels of the different ruff rules, of which there are hundreds.
python-lsp-ruff and pulsar's built-in linter do this automatically.

It's strange that I have not found this issue earlier 🙁 emedit is correct. The only python package needed is just a ruff. A manually assign of each rule to severity class is a pain-in-ass, but I cannot find any clue from ruff docs how to assign them automaticly.


adding JustWatch showcase

Merged. Thanks for the PR! Please feel free to close the it and delete the branch.


[Leadspace] type='left' is not working properly

Detailed description

The leadspaces on ibm.com/partners, ibm.com/partners/build and ibm.com/partners/start aren't rendering. The problem seems to be only happening with leadspace type=‘left’ and type='right'. When the ‘centered’ is used, for example, it works normally.

Is this a feature request (new component, new icon), a bug, or a general
issue? It's a bug.

Is this issue related to a specific component?

What did you expect to happen? What happened instead? What would you like to
see changed?

What browser are you working in?

What version of Carbon for IBM.com are you using?

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code

Notes

Hi @sarovisk, can I know what version of @carbon/ibmdotcom-web-components you guys are using? We are starting to phase out the left and small type attributes. We do have the size attribute if that is something that would help. You can go here and checkout the Docs tab up top for code implementation examples: https://ibmdotcom-web-components-staging.mybluemix.net/?path=/docs/components-lead-space--tall-with-no-image
CC: @andysherman2121 @DragosRistici

Could you also share more of the code? The screenshot doesn't show the entire implementation of the leadspace

Hi @annawen1! I'm asking @amanda-ibm for help. She is the developer and she may have much more information than me. 😃

oh great! I actually got the link to the partners pages github repo and dug around. It looks like the change in the leadspace height in the custom scss file caused the leadspace to not show up.

Upgrading to our latest @carbon/ibmdotcom-web-components version (currently the latest is v1.3.1) also solves the issue. We've had some fixes to the leadspace recently so I would highly recommend to upgrade. You may run into issues with imports when upgrading but I believe adding this should resolve that issue. Please let me know if this helps!
https://github.com/carbon-design-system/carbon-for-ibm-dotcom-web-components-test/blob/master/config/webpack.config-helper.js#L163-L166

Good, thanks, Anna! :)

@sarovisk  @amanda-ibm  Please follow Anna's advise.  We are closing this issue.


[feature] order lookup results

We should order results, either default by ASN, or allow users to specify orders.

resolved in #38


Chinese characters shows up as boxes in the generated pdf

Hi,
I am using this module to transform html to pdf on the fly in my website. What i observed is whenever there are Chinese characters in my html, it transforms to boxes in pdf. Is this you are aware of?
Here is the snippet
var options = {format: 'Letter'};
    options.border = {
      "top": "30px",
      "right": "30px",
      "bottom": "30px",
      "left": "30px"
    };

pdf.create(html, options).toStream(function (err, stream) {
//TODO:Handle err
res.setHeader('Content-Type', 'application/pdf');
res.setHeader('Content-disposition', 'attachment; filename="'+ 'Document - '+result.docId + '.pdf"');
stream.pipe(res);
});

This either has something to do with some missing fonts or with the unicode
problem that phantomjs has.
On Jun 10, 2015, at 10:43 AM, sripaulgit<EMAIL_ADDRESS>wrote:
Hi,
I am using this module to transform html to pdf on the fly in my website.
What i observed is whenever there are Chinese characters in my html, it
transforms to boxes in pdf. Is this you are aware of?
—
Reply to this email directly or view it on GitHub
https://github.com/marcbachmann/node-html-pdf/issues/39.

This problem occurs when the html doesn't contain a charset and falls back
to iso8859-1. This is fixed in phantomjs 2 and thus will be fixed in here
soon.
I knew of the problem where emojis aren't rendered. Thanks for reporting.
Maybe I should write some FAQs 😀
On Jun 10, 2015, at 10:43 AM, sripaulgit<EMAIL_ADDRESS>wrote:
Hi,
I am using this module to transform html to pdf on the fly in my website.
What i observed is whenever there are Chinese characters in my html, it
transforms to boxes in pdf. Is this you are aware of?
—
Reply to this email directly or view it on GitHub
https://github.com/marcbachmann/node-html-pdf/issues/39.

I installed the fonts and it worked :smile:  Thanks!

hehe :smile: Good to know.

@sripaulgit Which fonts on Ubuntu?

@sripaulgit Which fonts on CentOS?


API part is ok

API part is ok, please see if there is a problem.
I'll continue my review on spec.md.

I'll send a new PR after all is done.


Big space between  and  in Header component (NativeBase ^2.1.3)

I have used this code:
<Header>           <Left>             <Button transparent onPress={() => this.voltar()}>               <Icon name="arrow-back"/>             </Button>           </Left>           <Body>             <Title>Title</Title>           </Body>         </Header>
Result:

You also need to include <Right /> inside the Header

Thanks for reply @shivrajkumar,
I've made 3 new tests and I got this result:

@shivrajkumar and so NativeBase Header doesn't follow Material UI guidelines, yep?
https://material.io/guidelines/layout/structure.html#structure-app-bar
It will be all the same if you write Header correctly with Left, Body and Right components. Title will be far from Left icon.


Support REPL auto indentation

As title described, I think we can check pry's implementation about this.

I'm writing test for REPL.
Unfortunately, readline package contains no tests, I wonder why. I'm wondering how to feed inputs to stdin and retrieve the result from stdout.

@hachi8833 I have tried sending input to stdin and failed, that's why the old REPL start function use channel to receive value instead of using stdin directly.

Changing to external testing tool like miniTest might be required for RELP.

Why this would help?

I'm unsure around that for now. Let me see...


Simplify build script by making the "u menace" a non-issue

Problem
Currently, the openjdk build forests have "u"s at the end of some forests, but not others.
We currently forsee a future where "u"s will be added to forests at intervals, and we will need to continue modifying the build scripts each time.
We'll also need to tweak the build scripts whenever a new java version is released, even when there is no difference between building (e.g.) 9 and 10.
Solution
This issue proposes to fix that problem by making the user able to build any Java, regardless of "u" suffix or version number, by simply changing the jdk version string argument to the makejdk-any-platform.sh script.
Solution Breakdown
This requires us to make the following changes to the adopt build system:

Rename the AdoptOpenJDK/openjdk-jdk8u repository to AdoptOpenJDK/openjdk-jdk8 and stop adding "u"s to adopt build repositories in the future.

Recode the build scripts in AdoptOpenJDK/openjdk-build to allow the user to pass a "u" in or not, without breaking any functionality of version-string validation (Partly covered in PR https://github.com/AdoptOpenJDK/openjdk-build/pull/187 , but we need to change the adoptopenjdk REPOSITORY to use the OPENJDK_CORE_VERSION instead of OPENJDK_FOREST_NAME).

Recode the build scripts in AdoptOpenJDK/openjdk-build to use regular expression validation of the version strings (e.g. jdk[1-9]+[0-9]*u? ) instead of the current validation by comparison with a list of constants.

Recode any other version-9-specific stuff to use greater-thans instead of equals. e.g. replace "if VERSION == jdk9" with "if VERSION_INT >= 9".

Couple of comments.
Your 1. presupposes that no one will ever want to build jdkN as soon as there is a jdkNu? Is that definitely the case?
One comment I had from #187 post merge was to quibble a bit about the name OPENJDK_FOREST_NAME. Maybe we can discuss that as part of this issue as well? I've reproduced a slightly edited version of the comment below:

I'm going to quibble a bit on the choice of OPENJDK_FOREST_NAME, just because in JDK10 the "forest" has actually been collapsed. I don't think that name is 100% accurate either. I would suggest something like OPENJDK_REPO_NAME or some other accurate description of what that name actually is.

Hi mstoodle,
-- Your 1. presupposes...
Yes. That is my assumption.
-- One comment I had...
Sure, we can discuss that. We should mention both variable names, if we're getting into this.
e.g. if -version=jdk8u
OPENJDK_FOREST_NAME = jdk8u
OPENJDK_CORE_VERSION = jdk8

This is now resolved as all things are pretty much u and we've refactored the scripts as well.


Github shows only three first paragraphs of README.md in mobile version

Github shows only three first paragraphs of README.md in mobile version:

Many people are browsing idly on phones and would be good if they found useful information without clicking 'View all of README.md'.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27344772-github-shows-only-three-first-paragraphs-of-readme-md-in-mobile-version?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github).

Done.


Proposal TerminalExitStatus.reason

This PR fixes https://github.com/microsoft/vscode/issues/130231
Implements API proposal TerminalExitStatus.reason to address issue #130231
Added Shutdown(main motivation for #130231) and Unknown(i.e. any other reasons) reasons
Side note, after working on this, I would say that firing vscode.window.onDidCloseTerminal on shutdown is more of a bug than a feature, if some extension terminal logic is required to execute on shutdown then using context.subscriptions would be preferred I think but changing onDidCloseTerminal behavior would be a breaking change :thinking:
cc @Tyriar

@Tyriar Does proposed change make sense to you? We would really appreciate such API like stable though to unblock our customers. 🙏

@Tyriar thank you! Is API sync internal or we can follow it somehow as well?

@akosyakov it is internal and we will post a summary after that happens

Discussed at the API sync and we think the shape looks good. Just the one question above

I forgot to ask this, but how long does it take for a proposal API to become stable? I just realized that even if this is merged we won't be able to use it in our extension :sweat_smile:

Discussed at the API sync and we think the shape looks good. Just the one question above

@Tyriar @meganrogge Thank you a lot 🙏  Is it good to land?


Fix persistent installation link in README

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I fixed the persistent start install link in the README because the current link is broken.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[x] No need to
[ ] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@victoria-miltcheva thanks!


KAFKA-7366: Make topic configs segment.bytes and segment.ms to take effect immediately

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@junrao Please take a look, whenever you get a chance


Cosmos emulator test is failing for python

Python CI is failing in emulator test step with below error.
def test_client_request_timeout_when_connection_retry_configuration_specified(self):
    connection_policy = documents.ConnectionPolicy()
    # making timeout 0 ms to make sure it will throw
    connection_policy.RequestTimeout =  0.000000000001
    connection_policy.ConnectionRetryConfiguration = Retry(
                                                        total=3,
                                                        read=3,
                                                        connect=3,
                                                        backoff_factor=0.3,
                                                        status_forcelist=(500, 502, 504)
                                                    )
    with self.assertRaises(AzureError):
        # client does a getDatabaseAccount on initialization, which will time out

      cosmos_client.CosmosClient(CRUDTests.host, CRUDTests.masterKey, "Session", connection_policy=connection_policy)

E           AssertionError: AzureError not raised

Pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=358538&view=logs&j=5e2a8706-dc0d-5636-9430-7c9afc053d1a&t=f047e247-ba2a-5214-d4cb-a7703e2be0bf&l=903

Closing, feels deprecated, @praveenkuttappan if you disagree please re-open and add more labels for triage. Thanks!


Metamagic Master & Magic Lineage backgrounds not working for certain spells?

expected behavior: spell selected during character creation would make said spell have it's level raised by fewer levels when applying metamagic feats
encountered behavior: some spells posses extra "copies" within it's selector(possibly NPC versions?) which seem to not work with the backgrounds, these copies dont seem to be present in the selector for Spell Perfection

Connected to #296. Should work now.


Interaction: Gather

The tool should be able to gather nodes together.
This relies on being able to select a group of nodes, likely with #18. We would then perform movements on these nodes to move them to adjacent levels. There's multiple ways we could do this, but we will likely have to make arbitrary choices at some point.
It also might be a wanted feature to also gather the associated text with the selected subgraph. This could be quite difficult as we have no mechanism to modify the text at the moment. We could either try to regenerate the specific part of the text or just try to reorder bind statements, but either of these requires creating new text.

This could possibly be easier with the extensions we have made to thunks, but this does not seem necessary at the moment


Ensure rename tests don’t fail if running with a sourcekitd that doesn’t support rename yet

Just another case of making sure that sourcekit-lsp’s tests don’t fail after checking out the repo and running its tests using eg. Xcode 15.1 without an open source toolchain snapshot.

@swift-ci Please test


Invalid directory /Volumes/node_modules/Dimensions

bcoiueufrgwzffebbarleytkoipx/Build/Products/Debug-iphonesimulator/AwesomeProject.app/main.jsbundle --assets-dest /Users/Apple/Library/Developer/Xcode/DerivedData/AwesomeProject-bcoiueufrgwzffebbarleytkoipx/Build/Products/Debug-iphonesimulator/AwesomeProject.app
bundle: Created ReactPackager
uncaught error Error: UnableToResolveError: Unable to resolve module Dimensions from /Volumes/DataSource/reactnative/AwesomeProject/node_modules/react-native-swiper/dist/index.js: Invalid directory /Volumes/node_modules/Dimensions
at ResolutionRequest.js:351:15
at tryCallOne (/Volumes/DataSource/reactnative/AwesomeProject/node_modules/promise/lib/core.js:37:12)
at /Volumes/DataSource/reactnative/AwesomeProject/node_modules/promise/lib/core.js:103:15
at flush (/Volumes/DataSource/reactnative/AwesomeProject/node_modules/asap/raw.js:50:29)
at doNTCallback0 (node.js:430:9)
at process._tickCallback (node.js:359:13)
See logs /var/folders/jt/gyd40qnn3gz6rc1dptzjqyfm0000gn/T/react-packager.log
at SocketClient._handleMessage (SocketClient.js:139:23)
at BunserBuf. (SocketClient.js:53:42)
at emitOne (events.js:77:13)
at BunserBuf.emit (events.js:169:7)
at BunserBuf.process (/Volumes/DataSource/reactnative/AwesomeProject/node_modules/bser/index.js:289:10)
at /Volumes/DataSource/reactnative/AwesomeProject/node_modules/bser/index.js:244:12
at doNTCallback0 (node.js:430:9)
at process._tickCallback (node.js:359:13)
Command /bin/sh failed with exit code 1

Had the same issue with Dimensions. Check out my comment at the end of this thread:
https://github.com/facebook/react-native/issues/3817

fixed v1.4.0 thanks @alubling


Bug 1802868: bump(github.com/mtrmac/gpgme): v0.1.2

/assign @gabemontero

/cherrypick release-4.4

/hold
https://github.com/openshift/cluster-openshift-controller-manager-operator/pull/140 may have broken our timeout logic in the disruptive build tests.

/hold cancel
https://github.com/openshift/origin/pull/24582 should fix the build suite.
/retest


stridedpointer_preserve no longer in VectorizationBase

In the latest codebase, https://github.com/JuliaSIMD/TriangularSolve.jl/blob/50b01ecb2b49c91137a1922c8875dcc995ceefc8/src/TriangularSolve.jl#L4 the module imports stridedpointer_preserve from VectorizationBase, which does not seem to include this function anymore.  Instead, it looks like it should be imported either directly from LayoutPointers or from LoopVectorization
I tried the latter approach and got an error
[ Info: Precompiling TriangularSolve [d5829a12-d9aa-46ab-831f-fb7c9ab06edf]
ERROR: LoadError: MethodError: no method matching (LayoutPointers.StridedPointer{Float64, 2, 1, 0, (1, 2), X, O} where {X, O})(::Ptr{Float64}, ::Tuple{Static.StaticInt{8}, Static.StaticInt{96}}, ::Tuple{Static.StaticInt{0}, Static.StaticInt{0}})

Thanks for the issue and reminder to fix this.
Tests passed locally with https://github.com/JuliaSIMD/TriangularSolve.jl/commit/7ccf7606689392a1dc13ebba7ff4e8ef150be099, so I'll tag a new release once they pass.


Logging via format string no longer works, advice please

@Download in version one, I could write a positional string formatter.
log.debug('setting return-url: %s', uri);

Now, it seems the default is to use template strings (presumably kurly);
log.debug(`setting return-url: ${uri}`);

With my old format, I now get

I can't quite grok how to swap back to the original format. Is is possible?
Cheers
ps I have been sitting on this change for quite a while and only now trying to address it.

@toddb Sorry for the late response.
Ulog v1 did not support formatters. The formatting syntax you were using is actually console native. Because ulog did not do any formatting of it's own, you could use the positional formatters and they just worked.
Ulog v2 supports colored / formatted output. This uses (abuses) some features of the console. One of which is to rely on positional formatters for the colors and on Function.apply to not disturb the call stack. To support formats this way actually messes with the positional formats.
Please try to set colors and align off and to not use any formats. My guess is you will get the old behavior back. I think that if you use a dynamic format, you will also get the old behavior. But using colors / align / a static format (that does not mess up the callstack) probably messes up positional formatting.... Please do some testing with these settings and let me know what you found.


add additional management plane rules

Looking at the other management plane entry in this file I've added @michaeljqzq to the /**/arm-*/ expression.

@Azure/azure-sdk-eng


Disable linting in init_options

Great project, really liking it so far! Is there a way to disable linting from the lspconfig init_options? I am using another plugin for linting.

I have forgotten to set it. Now you can set it in
.neocmakelint.toml
command_upcase = "ignore"enable_external_cmake_lint = false

Thanks for the quick reply. Can I do it from the init options? I would rather not create another config file in my project just to disable linting for this LSP, which other devs on my project do not use.

If you can help pr it for me, I will feel very happy 😊, or I will finish it this night

do the newest commit solve your problem?

Yes, that works perfectly! Thank you!

new version published, now fixed


Issue 178: create tests for user endpoints

Closes https://github.com/Grommash9/tg_chat_mate/issues/178

Looks very good, i will test it locally and approve, thanks!


spatio-temporal replication fork reg

PMID:17304223
abnormal spatio-temporal regulation of replication fork localization
normal spatio-temporal regulation of replication fork localization
defs to use "cellular process phenotype in which the spatio-temporal pattern of localization of replication forks into nuclear foci is (ab)normal. Normally, replication forks appear organized into foci outside the nucleolus in early S phase. As S phase progresses, the number of foci first increases, then decreases, and the remaining foci concentrate within the nucleolus or at the nucleolar periphery. The last replication foci remaining at the end of S phase are one or two large spots at the nucleolar border."
synonyms to use
spatio-temporal replication fork organization
replication foci dynamics
replication focus organization

abnormal spatio-temporal regulation of replication fork localization FYPO:0005465
normal spatio-temporal regulation of replication fork localization FYPO:0005166

edit file: 0f31f3a61c883d585f37ba6c581eb9e68c90b270
release: 109afb1825736d79a9dc5a7f6b323a4e71e23744


[zh-cn] use code to replace codenew shortcode

Help localizations swap to the new code shortcode, on their own timetable

{{% codenew %}} shortcode is replaced by {{% code %}}.
Part of https://github.com/kubernetes/website/issues/42203
For example:
{{% code language="yaml" file="application/deployment-scale.yaml" %}}

see more details for https://kubernetes.io//docs/contribute/style/hugo-shortcodes/#source-code-files
To avoid conflicts, please assign some tasks to yourself from the list of tasks provided.
Please leave a comment when assigning yourself a task to let me know what section you are working on, and make sure you have pulled the latest main branch.

[ ] task-1

0       1       content/en/releases/patch-releases.md
2       2       content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
2       2       content/en/docs/tasks/run-application/run-single-instance-stateful-application.md
3       3       content/en/docs/tasks/run-application/run-replicated-stateful-application.md
2       2       content/en/docs/tasks/run-application/configure-pdb.md
3       3       content/en/docs/tasks/run-application/run-stateless-application-deployment.md
3       3       content/en/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch.md
5       5       content/en/docs/tasks/manage-kubernetes-objects/declarative-config.md
4       4       content/en/docs/tasks/network/validate-dual-stack.md

[ ] task-2

1       1       content/en/docs/tasks/network/customize-hosts-file-for-pods.md
1       1       content/en/docs/tasks/configure-pod-container/user-namespaces.md
4       4       content/en/docs/tasks/configure-pod-container/quality-service-pod.md
1       1       content/en/docs/tasks/configure-pod-container/configure-projected-volume-storage.md
1       1       content/en/docs/tasks/configure-pod-container/configure-service-account.md
1       1       content/en/docs/tasks/configure-pod-container/pull-image-private-registry.md
1       1       content/en/docs/tasks/configure-pod-container/configure-volume-storage.md
4       4       content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md
3       3       content/en/docs/tasks/configure-pod-container/assign-memory-resource.md
1       1       content/en/docs/tasks/configure-pod-container/attach-handler-lifecycle-event.md
9       9       content/en/docs/tasks/configure-pod-container/configure-pod-configmap.md

[ ] task-3

1       1       content/en/docs/tasks/configure-pod-container/resize-container-resources.md
2       2       content/en/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity.md
2       2       content/en/docs/tasks/configure-pod-container/assign-cpu-resource.md
4       4       content/en/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes.md
1       1       content/en/docs/tasks/configure-pod-container/configure-pod-initialization.md
2       2       content/en/docs/tasks/configure-pod-container/extended-resource.md
4       4       content/en/docs/tasks/configure-pod-container/security-context.md
2       2       content/en/docs/tasks/configure-pod-container/assign-pods-nodes.md
2       2       content/en/docs/tasks/configure-pod-container/configure-runasusername.md
1       1       content/en/docs/tasks/configure-pod-container/share-process-namespace.md

[ ] task-4

5       5       content/en/docs/tasks/administer-cluster/manage-resources/memory-constraint-namespace.md
4       4       content/en/docs/tasks/administer-cluster/manage-resources/cpu-default-namespace.md
3       3       content/en/docs/tasks/administer-cluster/manage-resources/quota-memory-cpu-namespace.md
2       2       content/en/docs/tasks/administer-cluster/manage-resources/quota-pod-namespace.md
5       5       content/en/docs/tasks/administer-cluster/manage-resources/cpu-constraint-namespace.md
4       4       content/en/docs/tasks/administer-cluster/manage-resources/memory-default-namespace.md
3       3       content/en/docs/tasks/administer-cluster/namespaces-walkthrough.md
1       1       content/en/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
3       3       content/en/docs/tasks/administer-cluster/quota-api-object.md
1       1       content/en/docs/tasks/administer-cluster/declare-network-policy.md
1       1       content/en/docs/tasks/administer-cluster/dns-debugging-resolution.md
1       1       content/en/docs/tasks/administer-cluster/running-cloud-controller.md

[ ] task-5

1       1       content/en/docs/tasks/access-application-cluster/ingress-minikube.md
1       1       content/en/docs/tasks/access-application-cluster/service-access-application-cluster.md
5       5       content/en/docs/tasks/access-application-cluster/connecting-frontend-backend.md
1       1       content/en/docs/tasks/access-application-cluster/communicate-containers-same-pod-shared-volume.md
1       1       content/en/docs/tasks/tls/managing-tls-in-a-cluster.md
5       5       content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md
4       4       content/en/docs/tasks/extend-kubernetes/setup-konnectivity.md

[ ] task-6

1       1       content/en/docs/tasks/job/automated-tasks-with-cron-jobs.md
3       3       content/en/docs/tasks/job/pod-failure-policy.md
2       2       content/en/docs/tasks/job/coarse-parallel-processing-work-queue.md
2       2       content/en/docs/tasks/job/fine-parallel-processing-work-queue.md
2       2       content/en/docs/tasks/job/indexed-parallel-processing-static.md
1       1       content/en/docs/tasks/job/parallel-processing-expansion.md

[ ] task-7

1       1       content/en/docs/tasks/inject-data-application/define-command-argument-container.md
5       5       content/en/docs/tasks/inject-data-application/distribute-credentials-secure.md
1       1       content/en/docs/tasks/inject-data-application/define-environment-variable-container.md
2       2       content/en/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information.md
1       1       content/en/docs/tasks/inject-data-application/define-interdependent-environment-variables.md
2       2       content/en/docs/tasks/inject-data-application/environment-variable-expose-pod-information.md

[ ] task-8

1       1       content/en/docs/tasks/manage-daemon/pods-some-nodes.md
2       2       content/en/docs/tasks/manage-daemon/update-daemon-set.md
1       1       content/en/docs/tasks/debug/debug-application/debug-running-pod.md
1       1       content/en/docs/tasks/debug/debug-application/get-shell-running-container.md
1       1       content/en/docs/tasks/debug/debug-application/determine-reason-pod-failure.md
1       1       content/en/docs/tasks/debug/debug-cluster/audit.md
2       2       content/en/docs/tasks/debug/debug-cluster/monitor-node-health.md
3       3       content/en/docs/tasks/debug/debug-cluster/resource-metrics-pipeline.md
2       8       content/en/docs/contribute/style/write-new-topic.md
8       6       content/en/docs/contribute/style/hugo-shortcodes/index.md

[ ] task-9

1       1       content/en/docs/concepts/configuration/configmap.md
50      50      content/en/docs/concepts/security/rbac-good-practices.md
3       3       content/en/docs/concepts/scheduling-eviction/assign-pod-node.md
2       2       content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md
1       1       content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md
3       3       content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md
3       3       content/en/docs/concepts/storage/projected-volumes.md

[ ] task-10

7       7       content/en/docs/concepts/services-networking/network-policies.md
1       0       content/en/docs/concepts/services-networking/ingress-controllers.md
5       5       content/en/docs/concepts/services-networking/dual-stack.md
10      10      content/en/docs/concepts/services-networking/ingress.md
1       1       content/en/docs/concepts/services-networking/dns-pod-service.md

[ ] task-11

2       2       content/en/docs/concepts/workloads/pods/_index.md
1       1       content/en/docs/concepts/workloads/controllers/cron-jobs.md
1       1       content/en/docs/concepts/workloads/controllers/daemonset.md
1       5       content/en/docs/concepts/workloads/controllers/deployment.md
3       3       content/en/docs/concepts/workloads/controllers/replicaset.md
2       2       content/en/docs/concepts/workloads/controllers/job.md
5       2       content/en/docs/concepts/workloads/controllers/replicationcontroller.md

[ ] task-12

18      0       content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
1       1       content/en/docs/concepts/overview/working-with-objects/_index.md
3       3       content/en/docs/concepts/policy/limit-range.md
1       1       content/en/docs/concepts/policy/resource-quotas.md
2       2       content/en/docs/tutorials/configuration/configure-redis-using-configmap.md
1       0       content/en/docs/tutorials/hello-minikube.md
1       1       content/en/docs/tutorials/security/apparmor.md
8       8       content/en/docs/tutorials/security/seccomp.md

[ ] task-13

2       2       content/en/docs/tutorials/stateful-application/basic-stateful-set.md
2       2       content/en/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md
2       2       content/en/docs/tutorials/stateful-application/cassandra.md
1       1       content/en/docs/tutorials/stateful-application/zookeeper.md
1       1       content/en/docs/tutorials/services/pods-and-endpoint-termination-flow.md
4       4       content/en/docs/tutorials/services/connect-applications-service.md
6       6       content/en/docs/tutorials/stateless-application/guestbook.md
1       1       content/en/docs/tutorials/stateless-application/expose-external-ip-address.md
1       1       content/en/docs/test.md

[ ] task-14

0       2       content/en/docs/reference/kubernetes-api/common-definitions/node-selector-requirement.md
13      13      content/en/docs/reference/labels-annotations-taints/_index.md
1       1       content/en/docs/reference/config-api/kubelet-config.v1beta1.md
1       1       content/en/docs/reference/config-api/apiserver-webhookadmission.v1.md
1       3       content/en/docs/reference/config-api/kubelet-config.v1alpha1.md
1       1       content/en/docs/reference/config-api/apiserver-config.v1.md
1       1       content/en/docs/reference/access-authn-authz/service-accounts-admin.md
3       3       content/en/docs/reference/access-authn-authz/validating-admission-policy.md
1       1       content/en/docs/reference/access-authn-authz/rbac.md
3       3       content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
2       2       content/en/docs/reference/using-api/server-side-apply.md

[ ] task-15

1       1       content/en/blog/_posts/2019-04-26-latest-on-localization.md
1       0       content/en/blog/_posts/2022-02-17-updated-dockershim-faq.md
1       0       content/en/blog/_posts/2022-05-13-grpc-probes-in-beta.md
10      3       content/en/blog/_posts/2017-11-00-Autoscaling-In-Kubernetes.md
1       1       content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md
1       1       content/en/blog/_posts/2022-03-15-meet-our-contributors-APAC-AU-NZ-region-02.md
5       3       content/en/blog/_posts/2022-08-31-cgroupv2-ga.md
1       1       content/en/blog/_posts/2018-06-28-Airflow-Kubernetes-Operator.md
2       3       content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
3       3       content/en/blog/_posts/2023-05-15-kubernetes-1-27-updates-on-speeding-up-pod-startup.md
1       1       content/en/blog/_posts/2022-08-04-kubernetes-1.25-deprecations-and-removals.md

Tip
To understand what are the contents to be synced, run this for example:
./scripts/lsync.sh  content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md

/language zh

/triage accepted

/help

/close


Masthead component?

Hi! It's really great that you guys have open-sourced this framework - I already love it for tiny projects where Bootstrap is overkill. However, it seems to be missing one thing - a navbar.
But wait - when I go to websites built with primer, there is a navbar! (This even includes your website!) Why is the .masthead component missing from Primer? Or, if it's a third-party component, where do I get it?

We won't add everything that's included on GitHub, especially some of the more GitHubby components like our headers. I'm not opposed to adding something down the line, but we won't add anything that's just like our own for the time being.

Sorry, when I said "your website" I meant the Primer docs :smiley:. I just noticed that this particular "masthead" crops up a lot, that's all. How are they included in the docs anyway?

Oh! Apologies.
The Primer docs have all their CSS within the docs directory in this repo.  For the time being, Primer will be only comprised of components we actively use on GitHub.com and the like. At least in the main repo. We've not yet worked out a strategy of any kind for additional repos for custom components.


react-color is largest dependency in my project

from webpack-bundle-size-analyzer:
react-color: 685.36 kB (30.4%)
  lodash: 401.81 kB (58.6%)
    <self>: 401.81 kB (100%)
  material-colors: 4.51 kB (0.659%)
    <self>: 4.51 kB (100%)
  reactcss: 3.71 kB (0.541%)
    <self>: 3.71 kB (100%)
  merge: 2.8 kB (0.409%)
    <self>: 2.8 kB (100%)
  <self>: 272.52 kB (39.8%)

react itself clocked in at 628kB (27.8%).
I recommend switching to modularized lodash:  https://www.npmjs.com/browse/keyword/lodash-modularized

This is a duplicate of https://github.com/casesandberg/react-color/issues/59 that I treid to fix but it seems I didnt do it correctly. I will dig into this so that you can import just the color picker you want to use.

@casesandberg, no this is a completely separate issue.   #59 won't help very much, because it still includes all of lodash.  switching out lodash for lodash-modularized will immediately cut ~66% of the cut for a few minutes of effort.

Oh, I see what you are saying. I will make sure to get that in today!

This has been done in https://github.com/casesandberg/react-color/pull/73 and you can grab it from npm at<EMAIL_ADDRESS>


participate in Hacktoberfest

By participating in Hacktoberfest, you'll not only gain hands-on experience with Git and GitHub but also become part of a global community of developers. Your contributions here can be the first step towards a rewarding journey in open source coding.

Hi, let me work on this issue, I will fix it :)


update userId in notes on login and NotePostDispatch

1. Why is this change necessary?
With https://github.com/shopware/shopware/commit/bf254f2b1a080bc8014860efd413d0092d069a66 notes without userId will be deleted. Unless the userId will not be updated, the Clearing will unwanted delete to many notes. We have to update userID, so used notes won't be deleted.
2. What does this change do, exactly?
add updateUserID in NotePostDispatch and on Login
3. Describe each step to reproduce the issue or behaviour.

don't login in Shop (on default you'll check you're not loggedin in checkout latest :-) )
add product to note
login
you will your note, but...
(without this change) userId will stay 0, so it will be deleted
(with this change) userId was updated to yours, so it won't be deleted

4. Please link to the relevant issues (if any).
https://github.com/shopware/shopware/pull/1628
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

All the boss wants :-)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23740
Please use this issue to track the state of your pull request.

Hey,
Sorry for the late response :see_no_evil: .
I have discussed your Change with our internal QA. We decided that only on login the notes should be migrated and removed from cookie. So its only associated to the user account.
We want to prevent cases like

Customer fills product in note
Customer logins (getting migrated)
Logout
Login in another account, but you see notes from customer 1 and can manage them

Thanks for your Contribution! :blue_heart:


Fix property itemID

Coverage remained the same at 94.46% when pulling 60c2f13871e8180b21b1d65e7030d6cf4088b400 on cody:master into 598ab384aa7b73d9da67d5c89ae3ac2878cca538 on yannickcr:master.

Thanks.


Added new article

https://mixi-developers.mixi.co.jp/argocd-with-helm-fee954d1003c

Could you convert it to title case?


BETS/wstETH pool not returning bptPrice

BETS/wstETH pool on mainnet is apparently not returning a bptPrice. Was working before apparently.

Fwd: Hi team, I wasn't able to get an answer from Discord, perhaps you could help,
We're facing the issue Error fetching token prices from coingecko with status 400 when fetching the SDK method balancer.pools.bptPrice(pool), is there a way to fix?

The bptPrice function is fetching 88 tokens at the same time, the max allowed by coingecko is 10

The bptPrice function is fetching 88 tokens at the same time, the max allowed by coingecko is 10

Is there a way to fetch only one?

Yeah, but to find this bpt price, our flow is fetching prices for 88 tokens, so I separated our coingecko requests into chunks of 10, because now they have paid plan and free plan, and the free plan can fetch only 10 tokens per request :/
Info: https://www.coingecko.com/en/api/pricing
{
	"timestamp": "2023-11-28T20:54:17.207+00:00",
	"error_code": 10012,
	"status": {
		"error_message": "Number of contract addresses in the request exceeds the allowed limit (10 addresses). Please note that to ensure fair usage and prevent abuse, the allowed limit may be adjusted periodically. To enjoy higher allowed limit, please subscribe to Demo plan or a paid plan at https://www.coingecko.com/en/api/pricing"
	}
}

so I separated our coingecko requests into chunks of 10

Thanks for your answer @lgahdl!
Is it published so that we could update the package?

@RomualdH - it's published on the new beta package here

@RomualdH - in case you're using the SDK instead of the SOR directly, you can find the change here

@RomualdH - in case you're using the SDK instead of the SOR directly, you can find the change here

Hi @brunoguerios, seems now the error is Error fetching token prices from coingecko with status 429
My snippet is:
price = await balancer.pools.bptPrice(
  await balancer.pools.find('0x26cc136e9b8fd65466f193a8e5710661ed9a98270002000000000000000005ad')
)

Thanks for reporting @RomualdH - I created a new issue so we can keep track of it. We'll get to it as soon as possible.

Hi @RomualdH, the coingecko API reduced their rate limit to 5 instead of 30 requests per minute today, I added a new config to add coingecko API Key, if you have a paid plan you will be able to initialize the SDK with your coingecko API Key:
const balancerSDK = new BalancerSDK({
  network: 1,
  rpcUrl: 'https://rpc.ankr.com/eth',
  coingecko: {
    coingeckoApiKey: 'CG-ViHyrfvtLz2WSCJzm59TfGow',
    tokensPerPriceRequest: 30
  },
})

if you have a paid plan

Hi @lgahdl, is there a way to calculate the bpt price based on its underlaying tokens?

Hi @lgahdl, is there a way to calculate the bpt price based on its underlaying tokens?

@RomualdH - if you look at the implementation within the SDK you'll see that it uses the underlying token prices to calculate the bptPrice. Is that what you mean?

Hi @lgahdl, is there a way to calculate the bpt price based on its underlaying tokens?

@RomualdH - if you look at the implementation within the SDK you'll see that it uses the underlying token prices to calculate the bptPrice. Is that what you mean?

Yes, but why do we need the price feed from CG if we have the weight of each token in the pool? That wouldn't be enough to calculate the price?

Yes, but why do we need the price feed from CG if we have the weight of each token in the pool? That wouldn't be enough to calculate the price?

No, it's not enough. Price in the end means USD value. You need each token USD value + weight to calculate the bptPrice.

No, it's not enough. Price in the end means USD value. You need each token USD value + weight to calculate the bptPrice.

Can't I calculate wstETH price from it's wstETH/USDC pool, and then BETS price from wstETH/BETS pool based on the number of tokens weight (8020)?
Or maybe do a swap simulation from the BPT to USDC to know the price?

Can't I calculate wstETH price from it's wstETH/USDC pool, and then BETS price from wstETH/BETS pool based on the number of tokens weight (8020)? Or maybe do a swap simulation from the BPT to USDC to know the price?

You sure can 👍
The USD value approach is the one that we use and is suited for a more generalized solution.
If you're interested in a single specific BPT price, you can use any of those options you mentioned.
Please keep in mind that they are estimates based on the pools you're querying. If these pools happen to be out of balance compared to the current market price, the estimates will be off.
Although I believe estimates should be quite good as long as the pools you're querying have deep liquidity.

Do you have a snippet to help me calculate it please?

I managed to do it with APIs and this formula (BETS.balance * BETSPrice + wstETH.balance * wstETHPrice) / pool.totalShares.


Use GUI for showing transcribed text

Check out the functionality in utilities.py and gui.py . The Listener class can be used to turn text spoken into a microphone into a string. The QtWindow class can be used to visualize text. Write python code that opens the window, starts transcription and then updates the label in the window regularily with what has been transcribed. Similar code is already in the two ipynb files. Modifying the two .py files is also possible.
git-bob think about this and make a proposal how to achieve this.

That looks great! git-bob implement this into a main.py file


EC2 remote shutdown

Building KG2 often finishes or crashes at odd times when I am unable to check on it for a few hours, leading to unnecessary run time on the instance that is charged per hour. This is not ideal.
I want to implement a remote shut down process as part of Snakemake so that when the build shuts down for any reason, it sends a shut down signal so we don't waste so much time on the server.
AWS CLI has a command stop-instances that I believe is what I'm looking for.
So it might look like:
aws ec2 stop-instances --instance-id <value>
I'm not sure how to incorporate it. Should it go in Snakefile-finish or its own rule? Elsewhere? I'll run some tests to figure that part out.

I think this can be done without modifying Snakemake. If your Bash command to run the build is CMD1, then inside your screen session:
CMD1; aws ec2 stop-instances --instance-id i-03e415099e4be5409

I once tried to set up something to email me when the Snakefile finished. It didn't work great, since anytime you are emailing from AWS, it goes to spam (and also, setting up the mail tools was more manual that we want). However, through this process, I learned how to make things happen on error (or success). Here is how to do it:
https://github.com/RTXteam/RTX-KG2/blob/fab3a329882164cf945a70255968989bfbad492d/Snakefile#L162-L165
We can add this to the end of Snakefile-finish, so that it is at the end of the Snakefile, as desired.

Thank you @ecwood. @acevedol do you think you could try that?


fail to use jpa

Hi, everyone.
My proect is relied on springboot and i try to use jpa to connect to db.
public interface ChapterDao extends CrudRepository<Chapter, Long> {     List<Chapter> findAll(); }
i delare a private var in my crawler which extends WebCrawler
@Autowired     private ChapterDao chapterDao;
and i try to usechapterDao.save()to save data that i get from websites,but there are something wrong,chapterDao is always null,and i don't know why.
Do you have an idea what's the problem?

Hello, without reading the code is hard to help you. Are you sure your crawler is in the Spring context path? Did you annotated your class with @Configuration (or @Service) ?

For Spring integration you need to implement:
 public interface WebCrawlerFactory<T extends WebCrawler> {
        T newInstance() throws Exception;
    }

and then let Spring create the WebCrawler instances. Otherwise the injection will not work properly.
However, we need more code fragments to help you properly...

Thanks for rzo1's resolution.I implement WebCrawlerFactory and send chapterDao as an argument and it works!


Fixing /hostfs and adding debugging block to storage-init

This is obviously a cleanup, but at the very bottom of this PR you will find "one weird trick" that may just save you a lot of debugging time. If you uncomment that block you can create a new content for any of the EVE's services containers under /persist/services/ and it will be used instead of the one in rootfs.
This is, obviously, a lifesaver when you debugging a lot of pillar code since you can simply create /persist/services/pillar and keep updating it to your heart's content without rebuilding rootfs or anything silly like that.

Good idea @eriknordmark -- updated DEBUGGING.md doc.


v10 Conversion

Have not fully tested everything about, but get the module support for Foundry v10.

You're right, it should now be:
    "relationships": {
        "systems": [
            {
                "id": "dnd5e",
                "type": "system",
                "manifest": "https://raw.githubusercontent.com/foundryvtt/dnd5e/master/system.json": {
                    "minimum": "2.0.0"
                }
            }
        ]
    },

Would love to test this, my players only use the OGL sheet and would be fine testing changes just to use the new foundry version.

Many thanks

hi, were the fixes here functional, or it ended up as buggy?


Exception in server loop

Hey sorry if this isn't the right place but I need help. Trying to set up just a basic server for myself so I can get some plugins going, but the server crashes every time. Crash log here: http://pastebin.com/rULg7MLM
Any help at all would be appreciated, thanks!

The crash report mentions being unable to find interface that was renamed quite some time ago. Make sure you have the latest version (build 666 at the moment).

The exception is because he is using VoxelSniper which is not updated for the event changes yet.


ISPN-15064 Hot Rod Client flaky tests on CI

https://issues.redhat.com/browse/ISPN-15064

Allowing retry of operation on the same channel;
Concurrency fixes in some tests;

Opening as a draft to let CI run. There might still have some flaky because of the timeout configuration.

So, I thought at first that GracefulShutdownRestartIT was failing because the cache needed to send the join request. I added a loop to getOrCreate on each server, making sure the cache is ready at the end. But randomly, I get:
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 12:35:14,526 ERROR [o.i.s.h.BaseRequestProcessor] ISPN005003: Exception reported org.infinispan.commons.CacheConfigurationException: ISPN000436: Cache 'CD85FF8441D91270E3C522DF38D58B61A28927F2' has been requested, but no matching cache configuration exists
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.configuration.ConfigurationManager.getConfiguration(ConfigurationManager.java:61)
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.manager.DefaultCacheManager.wireAndStartCache(DefaultCacheManager.java:684)
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.manager.DefaultCacheManager.createCache(DefaultCacheManager.java:674)
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.manager.DefaultCacheManager.internalGetCache(DefaultCacheManager.java:563)
09:35:14,528 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:526)
09:35:14,529 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.manager.DefaultCacheManagerAdmin.getOrCreateCache(DefaultCacheManagerAdmin.java:49)
09:35:14,529 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.server.tasks.admin.CacheGetOrCreateTask.execute(CacheGetOrCreateTask.java:47)
09:35:14,529 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.server.tasks.admin.CacheGetOrCreateTask.execute(CacheGetOrCreateTask.java:25)
09:35:14,529 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.server.core.admin.AdminServerTask.execute(AdminServerTask.java:57)
09:35:14,529 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.server.core.admin.AdminOperationsHandler.lambda$runTask$0(AdminOperationsHandler.java:50)
09:35:14,530 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.security.Security.doAs(Security.java:105)
09:35:14,530 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.infinispan.server.core.admin.AdminOperationsHandler.lambda$runTask$1(AdminOperationsHandler.java:50)
09:35:14,530 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
09:35:14,530 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
09:35:14,530 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
09:35:14,531 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
09:35:14,531 INFO  [o.i.CONTAINER] [o.i.s.r.GracefulShutdownRestartIT#1]STDOUT: 	at java.base/java.lang.Thread.run(Thread.java:833)

When this happens, the cache is not registered. And the tests fail with the missing members. I'll look further into this.


SARS-CoV-2-Queries API not working

https://grlc.io/api-git/egonw/SARS-CoV-2-Queries/subdir/grlc API is not working https://github.com/egonw/SARS-CoV-2-Queries/tree/master/grlc
Reported by @egonw

After first inspection, it looks like this repo works fine, it just takes a while to load, so at some point it times out. Increasing the gunicorn timeout "fixes" the issue, but it feels more like masking the issue and not really addressing it.

It looks like the bottle neck is fetching the files in the repo. In terms of size, it is not too much, but because https://github.com/egonw/SARS-CoV-2-Queries/tree/master/grlc contains 50+ files, grlc issues 50+ requests to GitHub (via PyGithub) which takes a while, and the request from the browser to grlc.io times out.
One way to optimise this is to cache the GitHub requests (using requests-cache). The first time the https://grlc.io/api-git/egonw/SARS-CoV-2-Queries/subdir/grlc is called, it will still time out. But calling it a second time will load the API properly. We could keep the repo cached for a reasonable amount of time (30 days?) and any subsequent calls in that time period would not time out.
What do you think @egonw? Would that work for you?


Wrong heatmap of Swin-Transformer

My code:
`if name == 'main':
""" python swinT_example.py -image-path <path_to_image>
Example usage of using cam-methods on a SwinTransformers network.
"""
label_map_path = '../../imagenet1000_clsidx_to_labels.txt'
with open(label_map_path, 'r') as file:
    label = eval(file.read())
args = get_args()
methods = \
    {"gradcam": GradCAM,
     "scorecam": ScoreCAM,
     "gradcam++": GradCAMPlusPlus,
     "ablationcam": AblationCAM,
     "xgradcam": XGradCAM,
     "eigencam": EigenCAM,
     "eigengradcam": EigenGradCAM}

if args.method not in list(methods.keys()):
    raise Exception(f"method should be one of {list(methods.keys())}")

model = timm.create_model('swin_tiny_patch4_window7_224',
                          pretrained=True
                          )
model.eval()

if args.use_cuda:
    model = model.cuda()

target_layer = model.layers[-1].blocks[-2].norm1

if args.method not in methods:
    raise Exception(f"Method {args.method} not implemented")

cam = methods[args.method](model=model,
                           target_layer=target_layer,
                           use_cuda=args.use_cuda,
                           reshape_transform=reshape_transform)

rgb_img = cv2.imread(args.image_path, 1)[:, :, ::-1]
rgb_img = cv2.resize(rgb_img, (224, 224))
rgb_img = np.float32(rgb_img) / 255
input_tensor = preprocess_image(rgb_img, mean=[0.485, 0.456, 0.406],
                                         std=[0.229, 0.224, 0.225])

# If None, returns the map for the highest scoring category.
# Otherwise, targets the requested category.
target_category = None

# AblationCAM and ScoreCAM have batched implementations.
# You can override the internal batch size for faster computation.
cam.batch_size = 32
print(input_tensor.shape)
grayscale_cam = cam(input_tensor=input_tensor,
                    target_category=target_category,
                    eigen_smooth=args.eigen_smooth,
                    aug_smooth=args.aug_smooth)
input_tensor = input_tensor.cuda()
output = model(input_tensor)
output = nn.Softmax(dim=1)(output)
sorted,ind = torch.sort(output)
res_ind = ind[0][-1].item()
# Here grayscale_cam has only one image in the batch
grayscale_cam = grayscale_cam[0, :]

cam_image = show_cam_on_image(rgb_img, grayscale_cam)
print(label[res_ind])
cv2.imwrite(f'{args.method}_cam_swin.jpg', cam_image)`

My heatmap:

Is there something wrong with my code?

Can you please try with --method scorecam or --method ablationcam and post the results?
Grad-cam seems to give bad results for the swin-transformer.
The result is very sensitive to the target_layer choice.
For the swin_base_patch4_window7_224 model,
This target_layer seems to give reasonable results, give it a try:
target_layer = model.layers[-1].blocks[-1].norm2

Closing the issue for now, please re-open if the suggestion above doesn't help.


Feature/rc smarti dataset

Summary
Skript to generate requests and send messages to them via Rocket.Chat rest-api
How to use
described in the README.md file
Requirements
The Rocket.Chat Rest-API endpoint for creating requests was broken. The following fix has to be merged first:
https://github.com/assistify/Rocket.Chat/pull/202

@ja-fra how about merging this? Any concerns?


Run on Windows

First tests on running the action with windows-latest were done in https://github.com/TheSnakePit/setup-mamba/pull/3.
Here is an example of a failed run: https://github.com/TheSnakePit/setup-mamba/runs/741565038
With the following output:
Run mamba install -y -c conda-forge python
  mamba install -y -c conda-forge python
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
Traceback (most recent call last):
  File "C:\Miniconda\Scripts\mamba-script.py", line 6, in <module>
    from mamba.mamba import main
  File "C:\Miniconda\lib\site-packages\mamba\mamba.py", line 53, in <module>
    import mamba.mamba_api as api
ImportError: DLL load failed: The specified module could not be found.
##[error]Process completed with exit code 1.

Something is pretty badly broken if you're getting DLL errors! 😬

I don't know much about the GitHub Actions runners. Have the shells been initialised for conda? Are you running the commands from the activated environment where mamba is installed.
I see it's running the latest and greatest pwsh 7. I haven't used that yet so I don't even know if conda works with that shell.

https://github.blog/changelog/2019-10-17-github-actions-default-shell-on-windows-runners-is-changing-to-powershell/
https://github.community/t/windows-is-using-powershell-core-instead-of-powershell-as-documented/16741

If you're not using any powershell features I'd try using shell: cmd, otherwise shell: powershell will get you the old-fangled powershell which might work better with conda

Closing in favor of https://github.com/mamba-org/setup-micromamba


How to use sats-connect to send btc?

Hello, how to use sats-connect to send btc,
There is no sendBtcTransaction method in the BitcoinProvider injected by Xverce wallet

Hi @liulise
Apologies for the extremely late response.
If it helps, please see the example repo, specifically the send btc component here: https://github.com/secretkeylabs/sats-connect-example/blob/main/src/components/sendBitcoin.tsx
If you need further assistance, please reopen the issue.


Serving on different ports

Hi @chemoish, what's the reason for serving client content on one port and the server-related bits on another?

@fetimo, I am not entirely sure if you need to manage them separately, BUT both the client and the server have different needs. Those needs surface in the webpack configuration, which cannot entirely be shared.
You can give it a try, I remember I had issues leveraging webpack-dev-middleware separately, but I don't recall exactly why. I tried to follow the existing documentation (article, starter kits, main repos, etc.) out there and simplified the webpack configuration where I could.
webpack is hella confusing—second is HMR and its brokenness—third is isomorphic + local CSS


UserProperty fails when multiple claims of the same type (permissions)

When configuring UserPropertyBag ClaimMapping:
UserPropertyBag.ClaimMapping.Add("Permission", new[] { BaleaClaims.Permission });

and create a new policy like this:
"policies": [
  {
    "name": "MultiplePermissions",
    "content": "policy MultiplePermissions begin\r\n rule A (PERMIT) begin\r\n Subject.Permission = \"internalproducts.read\" OR Subject.Permission = \"internalproducts.readandwrite\" \r\n end \r\n end"
  }
]

The policy is not satisficed because returns the first claim value of the permissions and maybe it's not the correct value.

I don't remember well, but, can you use CONTAINS on BAL language

You are right @unaizorrilla


Implement token overwriting

Part 1 (method implementation) is complete, part 2 (using it in the code) can be done quickly.

Fixes #35


Minted NFTs using -d True end up having an unassigned owner id

Hi have been playing with the tool, and I had a few observations/questions:
-Based on my testing, it looks like the only way to get it working with the chia client is using this branch (gw.bulk_mint_nfts) https://github.com/Chia-Network/chia-blockchain/blob/gw.bulk_mint_nfts/chia/rpc/wallet_rpc_api.py#L155
(which has the nft_mint_bulk wallet API). Is that correct? or is there another more up to date branch?
-I did a test using that branch, and it works, I minted several ones however the end up with an 'Unassigned' owner did (e.g. https://mintgarden.io/nfts/nft1g326nj04ajcaau3a2fwwuzf5mpwctr4r4xja7rdjt7psrzawwhxqxh24yf) . Even though I followed these steps:

chia-nft-minting-tool % chianft create-mint-spend-bundles -w 3 -d True -a xch1p4xht2staxxqzspraqmkpfppqk0xaaq27ezdz3yjc0mzf0wgp3aqtd8qwg -r 600 metadata-1.csv output-1.pkl
chia-nft-minting-tool % chianft submit-spend-bundles -m 1000000 output-1.pkl

(the -d True indicates use did)  and I put logs in the code and saw it that the spend bundle was using a coin associated with my did:chia:1gysj9pt28wzyf5fg97afysmyeaz5zuxnlsj8c0uqtr8t2tvskrpsyjdj9f
Thoughts?
cc: @geoffwalmsley

Thanks for the report.

When we release the beta later this week, it will be pointing to main and not an older branch

This minting tool uses a new technique to establish the minter. In the case of this tool all NFT coins are children of the DID coin. The marketplaces need to be updated to support this convention.

Hope this answers your questions.

Hi,
Testing the minting to a DID and seeing the same issue where in the Chia client app the NFTs are not assigned to a DID.
The commands ran:
chia keys generate;

chia wallet did create -n bulk_mint_DI -m 0.0000001

chia wallet nft create -f<PHONE_NUMBER> -di did:chia:1cpv5x5hl4627p4n7thn3l3qu389u2yc06mf3h33m2sc4ycjmmawqq9tzxk -n "NFT Wallet for bulk minting"

python factory_metadata.py 3

chianft create-mint-spend-bundles -w 3 -a txch1dakenrvcg2sg90ullfv236euyt02457t52e5jv7m9gry9d255yaq24cjqw -r 300 -d True metadata.csv output.pkl

chianft submit-spend-bundles -m 100000 -o 100 output.pkl```

Screenshot 1 shows the output for the commands including a modified tool to show that it does indeed include the `did_coin_dict`. However,

However, they are not showing up in the DID:

A new non-DID wallet is created and the NFTs are unassigned:

Visible here as unassigned:

Ignore above comment. Someone in the community pointed out that the Chia Wallet client doesn't set the DID after the mint.
However, one can verify the NFTs were minted by the DID via:
chia rpc wallet nft_get_nfts '{"wallet_id": 4}'
if you used -d True you should see each NFT have "minter_did": "0x6f55a0bd81edaeb513383e7fcecafa56874e7e596b682988fc8e7dde3a85f7e5",
if you left the default or -d False (no DID) then you should see:
"minter_did": null,


BUG: modin can't share categories between multiple frames when pandas can

Modin version checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest released version of Modin.

[X] I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example
import pandas

df = pandas.DataFrame(
    {
        "a": ["a", "a", "b", "c", "c", "d", "b"],
        "b": [0, 0, 0, 1, 1, 1, 1]
    }
)

cat_df = df.astype({"a": "category"})

fi = cat_df.loc[df.b == 0]
se = cat_df.loc[df.b == 1]

print(fi.dtypes["a"].categories.equals(se.dtypes["a"].categories)) # True

print(fi["a"].cat.codes) # [0, 0, 1]
print(se["a"].cat.codes) # [2, 2, 3, 1] <-- shares categories with 'fi', thus codes start from 1

from modin.test.storage_formats.pandas.test_internals import construct_modin_df_by_scheme

df = construct_modin_df_by_scheme(df, {"row_lengths": [2, 2, 2, 1], "column_widths": [2]})
cat_df = df.astype({"a": "category"})

fi = cat_df.loc[df.b == 0]
se = cat_df.loc[df.b == 1]
print(fi.dtypes["a"].categories.equals(se.dtypes["a"].categories)) # False

print(fi["a"].cat.codes) # [0, 0, 1]
print(se["a"].cat.codes) # [1, 1, 2, 0] <-- have independent categories, thus codes start from 0

Issue Description
Pandas do share categorical values between offspring frames thus making it possible to treat their codes as comparable to each other.
In modin, a categorical frame often doesn't even have defined categorical values at all as the .dtypes are often unknown so each partition has its own categorical values. One of the consequences of this is that when building a full-axis column partition we lose categorical types at the result because there's just no full-axis table for categories and was found more beneficial to discard categories at all rather than building categories for the whole column (#2513).
Although we still can ask for a full-axis function to re-build categories on demand (however it still doesn't allows us to share them between multiple frames):
https://github.com/modin-project/modin/blob/bb0950d06ce4bbdd87433ded82d118d803ed47a0/modin/core/storage_formats/pandas/query_compiler.py#L3451-L3453
Expected Behavior
We apparently would like to have a sharable full-axis categorical object between all partitions and an ability to share it with other frames.
Error Logs

There is no error logs, so putting here a plain output of the reproducer

True
0    0
1    0
2    1
dtype: int8
3    2
4    2
5    3
6    1
dtype: int8
False
0    0
1    0
2    1
dtype: int8
3    1
4    1
5    2
6    0
dtype: int8

Installed Versions

Replace this line with the output of pd.show_versions()

https://github.com/pandas-dev/pandas/issues/51362 might be related to this.

Apparently casting to categories using full-axis function fixes everything:
diff --git a/modin/core/dataframe/pandas/dataframe/dataframe.py b/modin/core/dataframe/pandas/dataframe/dataframe.py
index 30925e40..1e38bde6 100644
--- a/modin/core/dataframe/pandas/dataframe/dataframe.py
+++ b/modin/core/dataframe/pandas/dataframe/dataframe.py
@@ -1201,6 +1201,7 @@ class PandasDataframe(ClassLogger):
         columns = col_dtypes.keys()
         # Create Series for the updated dtypes
         new_dtypes = self.dtypes.copy()
+        full_axis_cast = False
         for i, column in enumerate(columns):
             dtype = col_dtypes[column]
             if (
@@ -1220,6 +1221,7 @@ class PandasDataframe(ClassLogger):
                 # We cannot infer without computing the dtype if
                 elif isinstance(new_dtype, str) and new_dtype == "category":
                     new_dtypes = None
+                    full_axis_cast = True
                     break
                 else:
                     new_dtypes[column] = new_dtype
@@ -1228,9 +1230,15 @@ class PandasDataframe(ClassLogger):
             """Compute new partition frame with dtypes updated."""
             return df.astype({k: v for k, v in col_dtypes.items() if k in df})

-        new_frame = self._partition_mgr_cls.map_partitions(
-            self._partitions, astype_builder
-        )
+        if full_axis_cast:
+            new_frame = self._partition_mgr_cls.map_axis_partitions(
+                0, self._partitions, astype_builder, keep_partitioning=True
+            )
+        else:
+            new_frame = self._partition_mgr_cls.map_partitions(
+                self._partitions, astype_builder
+            )
+
         return self.__constructor__(
             new_frame,
             self._index_cache,

This happens because now each partition will have the whole categorical values, meaning that pd.concat will not discard categorical dtypes when building a full-axis column partition.

But:

The cast itself becomes more expensive as it's now performed in a full-axis function
Each partition is now obliged to store the whole encoding table, which can cause severe memory issues (the same as we're fixing with multiindex right now #5632)

@dchigarev Is it possible that modin will give incorrect results, while working with category data due to this problem (during join or groupby)?

not sure about join and groupby (maybe there are cases where it could be broken, however, simple scenarios should work fine) but we already had a case with the .map() function that was affected by this malfunction:
example
import pandas
from modin.test.storage_formats.pandas.test_internals import construct_modin_df_by_scheme

def run_scenario(df):
    print(f"\n== running scenario with {type(df)=} ==")

    cat_df = df.astype({"a": "category"})

    # in pandas 'fi' and 'se' would still share the same categorical values,
    # when with modin they will now completely independent
    fi = cat_df.loc[df.b == 0]
    se = cat_df.loc[df.b == 1]

    fi["a"] = fi["a"].cat.codes
    se["a"] = se["a"].cat.codes

    print(fi["a"]) # pandas: [0, 0, 1] | modin: [0, 0, 1]
    print(se["a"]) # pandas: [2, 2, 3, 1] | modin: [1, 1, 2, 0]

    se_groupby = se.groupby("a").sum().squeeze(axis=1)

    print(fi["a"].map(se_groupby)) # pandas: [nan, nan, 1.0] | modin: [1, 1, 2]

pandas_df = pandas.DataFrame(
    {
        "a": ["a", "a", "b", "c", "c", "d", "b"],
        "b": [0, 0, 0, 1, 1, 1, 1]
    }
)
modin_df = construct_modin_df_by_scheme(pandas_df, {"row_lengths": [2, 2, 2, 1], "column_widths": [2]})

run_scenario(pandas_df)
run_scenario(modin_df)


Bug setting Solve Inside when material is a frequency dependent dielectric

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
When creating a 3D object in HFSS, the function that determines whether to set "Solve Inside" does not work when a Dielectric material uses a frequency dependent Bulk Conductivity.  If the string "Freq" is in the Bulk Conductivity expression, it always assumes it is a Conductor instead of a Dielectric
Steps To Reproduce
Create a dielectric material with frequency dependence
Call a function from PYAEDT that makes a 3D object (like create_box) and assign the material to be a frequency dependent dielectric
Note that Solve Inside will be False
The Relative Permittivity may also need to be checked when Bulk Conductivity has a frequency dependent expression.
Which Operating System are you using?
Windows
Which Python version are you using?
3.8
Installed packages
aiohttp==3.8.3
aiosignal==1.2.0
altgraph==0.17.3
appdirs==1.4.4
async-timeout==4.0.2
attrs==22.1.0
cachetools==5.3.0
cffi==1.15.1
charset-normalizer==2.1.1
clr-loader==0.2.3
contourpy==1.0.5
cycler==0.11.0
et-xmlfile==1.1.0
fonttools==4.37.3
frozenlist==1.3.1
idna==3.4
imageio==2.22.0
kiwisolver==1.4.4
matplotlib==3.6.0
multidict==6.0.2
numpy==1.23.3
openpyxl==3.0.10
packaging==21.3
pandas==1.5.1
pefile==2023.2.7
Pillow==9.2.0
plumbum==1.7.2
psutil==5.9.2
py2exe==<IP_ADDRESS>
pyaedt==0.6.76
pycparser==2.21
pyinstaller==5.10.1
pyinstaller-hooks-contrib==2023.2
pyparsing==3.0.9
python-dateutil==2.8.2
pythonnet==3.0.1
pytz==2022.2.1
pyvista==0.36.1
pywin32==304
pywin32-ctypes==0.2.0
rpyc==5.3.1
scooby==0.6.0
six==1.16.0
vtk==9.1.0
wslink==1.8.2
yarl==1.8.1

Hi @adamgregory81 ,
Please share the snippet code to reproduce the issue.
Regards,
Samuel

The main issues is in modeler.advanced_cad.stackup_3d.py in the method duplicate_parameterize_material().  Conductors are not properly identified.
This should be addressed in this branch.

Should be resolved in PR #3566 .


Allow cinderbackup to report ready with 0 replicas

Right now the cinder-backup resource gets created with default 0 replicas. With this cinder never reaches ready state without cinder-backup being configured. This change allows cinder-backup to also report Ready state if instance.Spec.Replicas == 0.

@Akrog @fmount @fultonj wondering if it is expected that cinder-backup is always configured or if we want to have cinder-backup to report back that its Ready with set 0 replicas


Detect terminated EmberConnections in ember client prior to attempting a request

Fixes the reproducer in https://github.com/http4s/http4s/issues/4935#issuecomment-1435333053, and hopefully will allow us to close that issue once and for all 🙏
EmberConnection now pro-actively starts the next read from a socket, upon completing a request/response.
In a normal situation, this read will hang until the next request has been sent, at which point it will become the head of the response.
However, in the situation that the server decides to end the connection (probably while the socket is sitting idle in the connection pool), this read will terminate early with EOF. By capturing this, we are able to find out if the socket is still alive prior to starting a request. This allows us to avoid making a dud request (that we may not be able to retry) on a dead socket.

Codecov Report

Merging #6980 (37f9e15) into series/0.23 (9aa02ab) will increase coverage by 0.04%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@               Coverage Diff               @@
##           series/0.23    #6980      +/-   ##
===============================================
+ Coverage        71.22%   71.27%   +0.04%
===============================================
  Files              339      339
  Lines            10388    10406      +18
  Branches          1145     1112      -33
===============================================
+ Hits              7399     7417      +18
  Misses            2989     2989

Impacted Files
Coverage Δ

...a/org/http4s/ember/client/EmberClientBuilder.scala
73.39% <100.00%> (+0.49%)
:arrow_up:

...cala/org/http4s/ember/client/EmberConnection.scala
100.00% <100.00%> (ø)

...g/http4s/ember/client/internal/ClientHelpers.scala
87.71% <100.00%> (+5.26%)
:arrow_up:

.../src/main/scala/org/http4s/ember/core/Parser.scala
87.75% <100.00%> (-0.44%)
:arrow_down:

...ed/src/main/scala/org/http4s/ember/core/Util.scala
50.00% <100.00%> (+12.85%)
:arrow_up:

...c/main/scala/org/http4s/client/DefaultClient.scala
74.00% <0.00%> (-6.00%)
:arrow_down:

...ore/shared/src/main/scala/org/http4s/Charset.scala
95.23% <0.00%> (-4.77%)
:arrow_down:

core/shared/src/main/scala/org/http4s/MimeDB.scala
97.64% <0.00%> (ø)

core/shared/src/main/scala/org/http4s/Uri.scala
89.41% <0.00%> (+0.22%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Got some feedback from @ChristopherDavenport.

We need some sort of docs around the connection state.
Our goal should be making it make sense to someone who doesnt know the problem we are solving.
Because with knowledge of the problem it becomes clear, but the next person might not have that.

Will work on that this week.


Assessment1 IPL

IPL stats and fixture calculated.

Metric
Value

alert_status
:white_check_mark: OK

bugs
1

code_smells
15

reliability_rating
E (at least 1 Blocker Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


[UI, Home Screen, iOS and Android] Inconsistent Home header

Confusing header between "0 of 5 Days" and "1 of 5 days". I am not sure how the counter works for each. Either display no header or the day of the week (e.g. Monday)

I removed the header title (the "1 of 5 Days") and kept the "X of 5 Days" one.


Add default host key verification strategy for slaves

fixes:

@ton31337 can you review?

doesn’t work?


Cannot find package

I tried installing with every command suggestion, without being connected to a VPN, and I got this same error every time:
npm ERR! code E404 npm ERR! 404 Not Found - GET https://registry.npmjs.org/next/-/next-13.5.0.tgz - Not found npm ERR! 404 npm ERR! 404  'next@https://registry.npmjs.org/next/-/next-13.5.0.tgz' is not in this registry. npm ERR! 404 npm ERR! 404 Note that you can also install from a npm ERR! 404 tarball, folder, http url, or git url.

@ethan-grzeda our apologies. There was an issue with publishing version 13.5.0. 13.5.1 has since been released and should work for you.


Integrating Mongodb Atlas Realm

Hi,
could you please advice how to integrate Realm library into flexn/create ? I installed the latest stable version of flexn-io/create with the demo app template, and included the realm library, but its generating errors.
Here is the code:
import React from 'react';
import Realm from 'realm';
//import * as Realm from "realm-web";

import { App, Debugger } from '@flexn/create';
import { LogBox } from 'react-native';
import { ThemeProvider } from '../config';
import Navigation from '../navigation';

const realmApp = new Realm.App({ id: my-app-id });

LogBox.ignoreAllLogs();

const MyApp = () => (

    <ThemeProvider>
        <App style={{ flex: 1 }}>
            <Navigation />
            <Debugger />
        </App>
    </ThemeProvider>

);

export default MyApp;

This is the error message i get.

I also tried adding it at the plugin file but no success:
 "plugins": {
        "realm": {
            "version": "0.1.0",
            "android": {
              "package": "io.realm.react",
              "path": "node_modules/realm/android"
            }

        }

    },

@saimirg thanks for reporting this, did you try to remove Realm and test? did the issue not occur again?

@pauliusguzas yes, it runs fine when removing realm.
I think integrating react/realm will be a great benefit as it will minimize the need of a backend.

@saimirg thanks, please wrire down versions of rnv, node, create, os, renative.json and package.json, this will be checked

@pauliusguzas Please find details below:

 🚀  BUNDLER STARTED | 9/1/2023, 11:32:18 AM                                 │ │  $ rnv run                                                                   │ ├──────────────────────────────────────────────────────────────────────────────┤ │  ReNative Version: 0.37.3                                                    │ │  Project Name ($package.name): rnvrealmtest                                  │ │  Project Version ($package.version): 0.1.0                                   │ │  Workspace ($.workspaceID): rnv                                              │ │  Platform (-p): androidtv                                                    │ │  Engine ($.platforms.androidtv.engine): engine-rn-tvos                       │ │  Template<EMAIL_ADDRESS>                            │ │  App Config (-c): app                                                        │ │  Build Scheme (-s): debug                                                    │ │  Target (-t): Android_TV_720p_API_22                                         │ │  Supported Platforms: android, androidtv, firetv, androidwear,               │ │  ios, web, macos, tvos, tizen, webos                                         │ │  Env Info: darwin | x64 | node v16.16.0                                      │ │  Executed Time: 0h:0m:39s:976ms

@pauliusguzas is it possible to use realm as local database ?
What other local database would you recommend using ?


MeteoSwiss stations

Add the four solar radiation monitoring stations operated by MeteoSwiss
Network description:

The SACRaM (Swiss Alpine Climate Radiation Monitoring) network was initiated with the objective of ensuring long-term radiation monitoring for climate science research. The SACRaM network comprises four stations: Two are located in the Swiss Alps (at the Jungfraujoch and in Davos), while the other two are situated at lower altitudes in Payerne and Locarno-Monti. The station in Payerne is also part of the international Baseline Surface Radiation Network (BSRN), the global baseline monitoring network for monitoring radiation fluxes at the Earth's surface.

Information provided by Laurent Vuilleumier from MeteoSwiss:

The coordinates of the high accuracy radiation monitoring stations are the following:
name: 'Davos'
symbol: 'dav'
latitude: 46.8130
longitude: 9.8440
altitude: 1610
period: GHI (pyranometer): 01.01.1995 (many data missing in 1995), DNI (pyrheliometer on sun-tracker): 01.08.2000, Diffuse (pyranometer with sun-tracker-driven shading): 01.10.2003
name: 'Jungfraujoch'
symbol: 'jun'
latitude: 46.5500
longitude: 7.9900
altitude: 3582
period: GHI (pyranometer): 01.01.1996, DNI (pyrheliometer on sun-tracker): 01.07.1996, no diffuse (too harsh meteorological conditions)
name: 'Locarno-Monti'
symbol: 'otl'
latitude: 46.1800
longitude: 8.7830
altitude: 366
period: GHI (pyranometer): 01.01.1996 (many data missing in 1996), DNI (pyrheliometer on sun-tracker): 01.12.2000, Diffuse (pyranometer with sun-tracker driven shading): 01.05.2001
name: 'Payerne'
symbol: 'pay'
latitude: 46.8120
longitude: 6.9420
altitude: 491
period: GHI (pyranometer): 01.11.1992, DNI (pyrheliometer on sun-tracker): 01.11.1992, Diffuse (pyranometer with shading device on equatorial mount): 01.11.1993, (pyranometer with sun-tracker driven shading added ~2004)
note: (for Payerne: radiometers at 2m above ground are at 46.8123 N, 6.9422 E, the 30m mast with platforms at 10m and 30m is at 46.8125 N, 6.9420E)

N.B.: Concerning when they started, it is a little complex, because parameters have been added one after the others at most of these stations.


All of lodash required

Unfortunately this even breaks lodash-babel-plugin.
May I ask to provide an ESM build and using lodash-es?

#949