Change TODO directive detection to work with multiple pound signs on the same line

Should fix #4549.
Basically, the initial implementation of flake8-todos hinged on a regex anchoring the # in a Python comment to the start of a line. If no TODO tags were found just after that #, the line would not throw a diagnostic.
In the case of something like # noqa: A003 # TODO: something, the TODO is actually demarcated by a second #. As such, we need to check the characters after each # in the comment in order to find Directives.

@MichaReiser PR updated!
I reviewed some of the violations yesterday, but finished looking at them today. The only one that looks slightly wonky is this one, where MissingSpaceAfterColon is thrown in a URL when there's no colon after the author block. It's technically correct, since the first colon after the author block isn't followed by a colon, but obviously incorrect in spirit. This could also occur outside of URLs: # TODO (evanrittenhouse) fruits:apple, banana, cranberry.
The line causing the bug is here, where we split_once() after the author block is concluded. I'm thinking that, for a fix, we could check the first non-whitespace character after the author block's closing ). That character has to a be colon in a valid TODO. We could then treat that byte offset as we do the current split_once() call results. What do you think?

@evanrittenhouse thanks for the explanation. To double check. Do you mean this line https://github.com/bokeh/bokeh/blob/f4c7a9787f0fd93db6987cfbb46409098ddb3107/tests/integration/widgets/test_daterange_slider.py#L169 ?

The line causing the issue is here, where we split_once() after the author block is concluded. I'm thinking that, for a fix, we could check the first non-whitespace character after the author block's closing )

That makes sense. Trimming the leading whitespace and then testing the character should give us better results.

Hmm. So I copied one of the files that changed according to the ecosystem check (credentials.py) locally to see if I could reproduce the issues. The ecosystem checks report that the TD003 diagnostics on lines 77 and 84 are both gone. When I run cargo run -p ruff_cli -- test.py --select ALL, they both show up.
@MichaReiser do you have any idea what could be happening?

@evanrittenhouse the results from the ecosystem check seem correct.
On Add test for colons that don't terminate the tag/author block.
cargo run --bin ruff -- check --no-cache ~/Downloads/credentials.py --select TD
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/ruff check --no-cache /home/micha/Downloads/credentials.py --select TD`
/home/micha/Downloads/credentials.py:77:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
/home/micha/Downloads/credentials.py:77:7: TD003 Missing issue link on the line following this TODO
/home/micha/Downloads/credentials.py:77:7: TD004 Missing colon in TODO
/home/micha/Downloads/credentials.py:77:7: TD005 Missing issue description after `TODO`
/home/micha/Downloads/credentials.py:84:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
/home/micha/Downloads/credentials.py:84:7: TD003 Missing issue link on the line following this TODO
/home/micha/Downloads/credentials.py:84:7: TD004 Missing colon in TODO
/home/micha/Downloads/credentials.py:84:7: TD005 Missing issue description after `TODO`
Found 8 errors.

On the latest commit
cargo run --bin ruff -- check --no-cache ~/Downloads/credentials.py --select TD
   Compiling ruff v0.0.269 (/home/micha/astral/ruff/crates/ruff)
   Compiling ruff_cli v0.0.269 (/home/micha/astral/ruff/crates/ruff_cli)
    Finished dev [unoptimized + debuginfo] target(s) in 6.78s
     Running `target/debug/ruff check --no-cache /home/micha/Downloads/credentials.py --select TD`
/home/micha/Downloads/credentials.py:77:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
/home/micha/Downloads/credentials.py:77:7: TD003 Missing issue link on the line following this TODO
/home/micha/Downloads/credentials.py:77:7: TD004 Missing colon in TODO
/home/micha/Downloads/credentials.py:84:7: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...`
/home/micha/Downloads/credentials.py:84:7: TD003 Missing issue link on the line following this TODO
/home/micha/Downloads/credentials.py:84:7: TD004 Missing colon in TODO
Found 6 errors.

You can see that the diagnostics for TD005 are missing. I think this is correct because there's a description.

@MichaReiser Thanks for the suggestions!


[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

不过前端我是真不懂，扫了扫代码也没看出来最后 docker 镜像里那个 all.xxx.mjs 是哪些文件拼出来的，里面的内容具体咋生成的，所以我也不知道应该改哪。。。
https://github.com/ddiu8081/chatgpt-demo/commit/8e5b4973b75d11bb80b641cb9afcea64e92000f5
看这个 commit，docker-env-replace.sh 一开始就是这么写的，你可以试试把这里改成 ({}).SITE_PASSWORD 看是不是就好了

Try creating a .env file first and then modify the docker-compose.yml if using docker-compose.
version: '3'

services:
  chatgpt-demo:
    image: ddiu8081/chatgpt-demo:latest
    container_name: chatgpt-demo
    restart: always
    ports:
      - '3000:3000'
    volumes:
      - .env:/usr/src/.env

Run docker compose build . then run docker compose up -d.

@Xyfuture @Apache9 Try creating a .env file first and then modify the docker-compose.yml if using docker-compose.
version: '3'

services:
  chatgpt-demo:
    image: ddiu8081/chatgpt-demo:latest
    container_name: chatgpt-demo
    restart: always
    ports:
      - '3000:3000'
    volumes:
      - .env:/usr/src/.env

Run docker compose build . then run docker compose up -d.

I just pulled ddiu8081/chatgpt-demo:latest and started it with the command from the README page.
docker run --name=chatgpt-demo -e OPENAI_API_KEY=YOUR_OPEN_API_KEY -e SITE_PASSWORD=MY_PASSWORD -p 3000:3000 -d ddiu8081/chatgpt-demo:latest

And found it did not work, and then I used docker exec to login to the container, it showed that the sitePassword and realPassword in all.xxx.mjs were still not replaced. Will dig more later when I have time.
Thanks.

OK, I use docker run -it ddiu/chatgpt-demo:latest /bin/sh to start a container, and then modified docker-env-replace.sh with sed -i "s/process.env.SITE_PASSWORD/({}).SITE_PASSWORD/g " docker-env-replace.sh, and then commit the image with docker commit --change='CMD ["/bin/sh", "docker-entrypoint.sh"]' <container_sha256> chatgpt:v1.0, and finally start the new docker image with command
docker run --name=chatgpt-demo -e OPENAI_API_KEY=YOUR_OPEN_API_KEY -e SITE_PASSWORD=MY_PASSWORD -p 3000:3000 -d chatgpt:v1.0

I can see the login page now.
No sure this is the problem for docker image on dockerhub or it is a bug of the docker-env-replace.sh script, as I do not build the docker image from the Dockerfile by my own...
Thanks.


[GLUTEN-4263][VL] Fix Compression type 2 not supported in static build

This fixes error "Compression type 2 not supported" when spilling kicks in, in static build mode.
https://github.com/apache/incubator-gluten/issues/4263

Thank you for the fix


x/time/rate: Limiter allows more than configured

What version of Go are you using (go version)?

go version go1.16.2 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOOS="darwin"
GOROOT="/usr/local/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/tn/rljgjtgs4wg_mpjh961rmdyc0000gn/T/go-build3419748436=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

package main

import (
	"fmt"
	"golang.org/x/time/rate"
	"sync/atomic"
	"time"
)

func main() {
	var succCount, failCount int64
	limit := rate.Every(100 * time.Millisecond)
	burst := 1
	limiter := rate.NewLimiter(limit, burst)
	start := time.Now()
	for i := 0; i < 5000; i++ {
		go func() {
			for {
				if limiter.Allow() {
					atomic.AddInt64(&succCount, 1)
				} else {
					atomic.AddInt64(&failCount, 1)
				}
			}
		}()
	}
	time.Sleep(2 * time.Second)
	elapsed := time.Since(start)
	fmt.Println("elapsed=", elapsed, "succCount=", atomic.LoadInt64(&succCount), "failCount=", atomic.LoadInt64(&failCount))
}

What did you expect to see?
succCount should almost be 20 but it could get a number beyond 10000
What did you see instead?
elapsed= 2.01049986s succCount= 25629 failCount 6806127

@Morainy You might want to read the documentation for Allow(). It just says whether there is room. You want to use Wait() and you will get your expected behavior.

Guys, this is a real issue and the fix is roughly mentioned in #23145:
--- a/rate/rate.go
+++ b/rate/rate.go
@@ -320,7 +320,7 @@ func (lim *Limiter) reserveN(now time.Time, n int, maxFutureReserve time.Duratio
 		}
 	}

-	now, last, tokens := lim.advance(now)
+	now, _, tokens := lim.advance(now)

 	// Calculate the remaining number of tokens resulting from the request.
 	tokens -= float64(n)
@@ -350,8 +350,6 @@ func (lim *Limiter) reserveN(now time.Time, n int, maxFutureReserve time.Duratio
 		lim.last = now
 		lim.tokens = tokens
 		lim.lastEvent = r.timeToAct
-	} else {
-		lim.last = last
 	}

 	lim.mu.Unlock()

(Now the second return value of (*Limiter).advance is not used anywhere, it can be removed; and the first return value is just the same value as the argument, it can be removed too.)
lim.last should not be updated alone. The comment about this field in rate/rate.go#L60 clearly says last is the last time the limiter's tokens field was updated.
This is the output after applied the fix:
elapsed= 2.0010308s succCount= 20 failCount= 7280081

When Allow is called, time.Now is immediately called before the limiter acquires its lock. So when the limiter holds the lock, the time returned by the time.Now call could be a bit outdated. Technically, this already seems wrong to me. You have to be in the hope that it won't get too racy.

@fraenkel I believe that the documentation for AllowN is incomplete. It doesn't say anywhere that if you call AllowN two or more times without waiting only the first call will return true.
// AllowN reports whether n events may happen at time now.
// Use this method if you intend to drop / skip events that exceed the rate limit.
// Otherwise use Reserve or Wait.

package main

import (
	"fmt"
	"golang.org/x/time/rate"
	"time"
)

func main() {
	limit := rate.Every(100 * time.Millisecond)
	burst := 1
	limiter := rate.NewLimiter(limit, burst)
	for i := 0; i < 5; i++ {
		fmt.Println(limiter.Allow())
	}
	// Output:
	// true
	// false
	// false
	// false
	// false
}

@b97tsk  why couldn't this fix be merged into main?

It could be a security issue, you know, if the package is used to mitigate DoS attacks or web scraping, it simply won't work.

As a glance, logic you're trying to remove may be related to handling time shift backward (which, you know, may happens).

I can confirm this is an issue. The lowest failCount I could get where succCount is greater than 21 was 1587868: elapsed= 2.0143099s succCount= 21 failCount= 1587868. Unless you expect to rate limit hundreds of thousands of requests per second using a single Limiter, I believe you should be fine. I still hope this issue gets fixed though.

Relevant issue: #52584
And two PRs  pending for review:

golang/time#17
golang/time#22

Duplicate of #23145


Builtin pattern verifiers

Sort and symbol verification are implemented in master. This PR adds pattern verification and parsing, to decode builtin domain values. The actual implementation of the builtin functions will follow in another pull request.
@u-- : This should be what you need to get started on MAP.
Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

I'm still wondering if the new error handling thing is a step forward or not. I guess we'll just have to see how the code evolves.

@virgil-serbanuta
Could you explain what you mean? There is nothing new going on with error handling in this PR.


[BUG]: Unable to locate package libicu74

What happened?
We are using VMSS with Ubuntu 22.04 as the base image in Azure with Azure DevOps. As part of agent provisioning the azure pipelines agent is installed.
Inspecting the logs I can see:
E: Unable to locate package libicu74
during the Install Dependencies stage.
Versions
3.244.1
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[ ] Microsoft Hosted
[X] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Ubuntu 22.04
Version controll system
Git
Relevant log output
Azure Pipelines Extension failed with message: The Extension failed to execute: Pipeline script execution failed with exit code 100. 2024-09-22 11:33:57 version 15 2024-09-22 11:33:57 Url is
[---redacted---]
2024-09-22 11:33:57 Pool is [---redacted---] 2024-09-22 11:33:57 RunArgs is --once 2024-09-22 11:33:57 Directory is /agent 2024-09-22 11:33:57 [---redacted---] account already exists 2024-09-22 11:33:57 Zipfile is /agent/vsts-agent-linux-x64-3.244.1.tar.gz 2024-09-22 11:33:57 Installing dependencies ++ id -u + user_id=0 + '[' 0 -ne 0 ']' + '[' -e /etc/os-release ']' + filepath=/etc/os-release + '[' -e /etc/os-release ']' + echo '--------OS Information--------' + cat /etc/os-release + echo ------------------------------ + '[' -e /etc/debian_version ']' + echo 'The current OS is Debian based' + echo '--------Debian Version--------' + cat /etc/debian_version + echo ------------------------------ + command -v apt + '[' 0 -eq 0 ']' + apt update WARNING: apt does not have a stable CLI interface. Use with caution in scripts. + apt install -y libkrb5-3 zlib1g debsums WARNING: apt does not have a stable CLI interface. Use with caution in scripts. + apt install -y liblttng-ust1 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. + '[' 0 -ne 0 ']' ++ wget -qO-
http://security.ubuntu.com/ubuntu/pool/main/o/openssl/
++ grep -oP '(libssl1.1_1.1.1f.*?_amd64.deb)' ++ head -1 + package=libssl1.1_1.1.1f-1ubuntu2.23_amd64.deb + apt install -y libssl3 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. + '[' 0 -ne 0 ']' + apt install -y libicu74 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. E: Unable to locate package libicu74 + apt install -y libicu70 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. + '[' 0 -ne 0 ']' + echo ----------------------------- + echo ' Finish Install Dependencies' + echo ----------------------------- 2024-09-22 11:34:03 Dependencies installation succeeded 2024-09-22 11:34:03 Configuring build agent 2024-09-22 11:34:03 Configuring agent 2024-09-22 11:34:03 The application to execute does not exist: '/agent/bin/Agent.Listener.dll'. 2024-09-22 11:34:03 Build agent configuration failed

@angaaruriakhil, thank you for bringing this to our attention.
I found a similar issue #4485. It was noted there that your user may encounter difficulties working with source files.

The option is to add your user to the AzDevOps group, but if it does not help, I'll recommend you create a ticket in the extension repository because the problem seems not to be related to the agent itself.

I suggest creating a ticket in the extension repository, which will ensure the right team members are alerted to address this issue.

Hi, we are using the default AzDevOps user, not custom.
I thought about putting the issue here since I could see some changes to do with the aforementioned package in this repo in the most recent release.
If you still think that is the more appropriate place then I can put an issue in there.

@angaaruriakhil , yes, you are right.
There was an update to libicu74 for Ubuntu 24 in #4973 but based on your logs, the dependencies were still installed successfully
2024-09-22 11:34:03 Dependencies installation succeeded

And then I see that an issue arises where the start VMSS script fails to locate Agent.Listener.dll
2024-09-22 11:34:03 Configuring agent
2024-09-22 11:34:03 The application to execute does not exist: '/agent/bin/Agent.Listener.dll'.
2024-09-22 11:34:03 Build agent configuration failed

Thanks @ivanduplenskikh , I put in issue https://github.com/microsoft/vsts-azurevm-extension/issues/244 to that repo.

I'm closing this issue, but please don't hesitate to reopen it if you have further questions.


FIX: Deprecations

Let's see if the CIs are happy.
If they are I'll push another commit with [circle full].

you could not resist to remove all these lines :)

Yes I let you do all the hard work then I do the fun part :)

;)

thx @larsoner


broken pip requirements

it seems that the bzr==2.5b4 requirement in requirements/pip.txt is not valid. I commented it out and ran:
pip install bzr=2.6
http://read-the-docs.readthedocs.org/en/latest/install.html?highlight=install?highlight=install
this was on windows 7, python 2.7.10, pip 6.1.1

Hi, thanks for the report. I was able to reproduce locally in a fresh virtualenv:
gregor@myra ~ % mkvirtualenv --python=/usr/bin/python2.7 tmp
Running virtualenv with interpreter /usr/bin/python2.7
New python executable in tmp/bin/python2.7
Also creating executable in tmp/bin/python
Installing setuptools, pip, wheel...done.

(tmp) gregor@myra ~ % pip install bzr==2.5b4
Collecting bzr==2.5b4
  Could not find a version that satisfies the requirement bzr==2.5b4 (from versions: 2.6.0)
  Some externally hosted files were ignored as access to them may be unreliable (use --allow-external bzr to allow).
No matching distribution found for bzr==2.5b4

1 (tmp) gregor@myra ~ % pip install bzr==2.5b4 --allow-external bzr                                                                                :(
Collecting bzr==2.5b4
  Could not find a version that satisfies the requirement bzr==2.5b4 (from versions: 2.6.0)
  Some insecure and unverifiable files were ignored (use --allow-unverified bzr to allow).
No matching distribution found for bzr==2.5b4

1 (tmp) gregor@myra ~ % pip install bzr==2.5b4 --allow-external bzr --allow-unverified bzr                                                                                :(
Collecting bzr==2.5b4
  bzr is potentially insecure and unverifiable.
  Using cached https://launchpad.net/bzr/2.5/2.5b4/+download/bzr-2.5b4.tar.gz
Building wheels for collected packages: bzr
  Running setup.py bdist_wheel for bzr
  Stored in directory: /home/gregor/.cache/pip/wheels/0b/20/62/53308ef6b5481e7df83bcc08eb5f1eb7c54518fbcf1509aaf7
Successfully built bzr
Installing collected packages: bzr
Successfully installed bzr-2.5b4
pip install bzr==2.5b4 --allow-external bzr --allow-unverified bzr  17.88s user 0.67s system 74% cpu 24.779 total

It only works when running --allow-unverified which is not really ideal.

Actually this is expected as these flags were listed in the requirements/pip.txt file. However IMO we should get rid of them. I created #1377 for this.

Thanks. I redid the tutorial on a different computer and didn't get the
same error again. I must have been doing something wrong...
On 06/25/2015 03:07 AM, Gregor Müllegger wrote:

Hi, thanks for the report. I was able to reproduce locally in a fresh
virtualenv:
|gregor@myra ~ % mkvirtualenv --python=/usr/bin/python2.7 tmp
Running virtualenv with interpreter /usr/bin/python2.7
New python executable in tmp/bin/python2.7
Also creating executable in tmp/bin/python
Installing setuptools, pip, wheel...done.
(tmp) gregor@myra ~ % pip install bzr==2.5b4
Collecting bzr==2.5b4
Could not find a version that satisfies the requirement bzr==2.5b4 (from versions: 2.6.0)
Some externally hosted files were ignored as access to them may be unreliable (use --allow-external bzr to allow).
No matching distribution found for bzr==2.5b4
1 (tmp) gregor@myra ~ % pip install bzr==2.5b4 --allow-external bzr                                                                                :(
Collecting bzr==2.5b4
Could not find a version that satisfies the requirement bzr==2.5b4 (from versions: 2.6.0)
Some insecure and unverifiable files were ignored (use --allow-unverified bzr to allow).
No matching distribution found for bzr==2.5b4
1 (tmp) gregor@myra ~ % pip install bzr==2.5b4 --allow-external bzr --allow-unverified bzr                                                                                :(
Collecting bzr==2.5b4
bzr is potentially insecure and unverifiable.
Using cached https://launchpad.net/bzr/2.5/2.5b4/+download/bzr-2.5b4.tar.gz
Building wheels for collected packages: bzr
Running setup.py bdist_wheel for bzr
Stored in directory: /home/gregor/.cache/pip/wheels/0b/20/62/53308ef6b5481e7df83bcc08eb5f1eb7c54518fbcf1509aaf7
Successfully built bzr
Installing collected packages: bzr
Successfully installed bzr-2.5b4
pip install bzr==2.5b4 --allow-external bzr --allow-unverified bzr  17.88s user 0.67s system 74% cpu 24.779 total
|
It only works when running |--allow-unverified| which is not really ideal.
—
Reply to this email directly or view it on GitHub
https://github.com/rtfd/readthedocs.org/issues/1369#issuecomment-115197169.

Cool ok. I will close the issue here then. We can track the update of bzr in the #1377 then.


Test dev branch against avs 0.9.1-SNAPSHOT

Had to make some more changes in here to support AVS 0.9.1 so requesting reviews to merge.

Looks like not all the necessary changes were made for VEC-256 and VEC-241.
Had to...

regenerate proto code
add apply_defaults in a few places
fix incorrect indexParallel and reIndexParallel proto field usage

I'll add a apply_defaults test in another PR


federation

We ought to figure something out about federation so that we can have some resilience to network and host issues.

[ ] investigate existing IRC federation protocols
[ ] figure out something better?

Are we sure we need this at all? What will this solve?

Netsplits are pretty common in IRC networks with lots of traffic. Internet routing issues, DDOS, hardware failures, these are all things that happen.
Realistically, what has happened to our small IRC network running ergonomadic is that we didn't pay attention to AWS' restart alerts and we suddenly lost our only host. It would be nice if we could ignore AWS's restart alerts and not have to care, if we had 2 or more hosts running.

I think this can be solved with better distributed protocol between serers
and things like RobustIRC => https://robustirc.net/
This is also something that clients like IRCCloud (https://www.irccloud.com/)
solve really well too from a client perspective.
I'm okay if we want to support all the IRCv3 features -- but this would be
a lot of work
James Mills / prologic
E<EMAIL_ADDRESS>W: prologic.shortcircuit.net.au
On Tue, Jul 25, 2017 at 1:26 PM, Edmund Huber<EMAIL_ADDRESS>wrote:

Netsplits are pretty common in IRC networks with lots of traffic. Internet
routing issues, DDOS, hardware failures, these are all things that happen.
Realistically, what has happened to our small IRC network running
ergonomadic is that we didn't pay attention to AWS' restart alerts and we
suddenly lost our only host. It would be nice if we could ignore AWS's
restart alerts and not have to care, if we had 2 or more hosts running.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/edmund-huber/ergonomadic/issues/2#issuecomment-317861847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOv-ibDo32EQ5d11TqPyuJbNWzprrZ2ks5sRk-JgaJpZM4Dgz2A
.


cross platform: Implement _mul128

See https://github.com/Microsoft/ChakraCore/issues/217

Is there a problem with CI ?

Is down for maintenance I believe

@dotnet-bot test this please


owners: adding charles

@goaway @junr03 as discussed on slack this will be for cronvoy and test changes - for anything affecting E-M we'll continue to get Lyft sign-off


[NIFI-12727] Detect theme based on OS setting, allow user override

NIFI-12727
Detect theme from OS settings. Add user override option persisted in local storage.

Will review...


Removal of unused an wrongly designed organization gallery

Description:
Removal of unused an wrongly designed organization gallery. Organization member can upload images for organization, but they are never used outside it's profile and it is so wrongly implemented, that it will be better without it and if we will want it, we will create it from scrach in better shape than that one removed.
New imports / dependencies:

N/A

Unit Tests:

N/A

Codecov Report

Merging #668 into master will increase coverage by 0.66%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
+ Coverage    91.1%   91.77%   +0.66%
==========================================
  Files          87       88       +1
  Lines        2708     2661      -47
  Branches        4        4
==========================================
- Hits         2467     2442      -25
+ Misses        235      213      -22
  Partials        6        6

Impacted Files
Coverage Δ

backend/apps/volontulo/views/__init__.py
63.54% <ø> (+7.6%)
:arrow_up:

backend/apps/volontulo/models.py
78.06% <ø> (+0.87%)
:arrow_up:

backend/apps/volontulo/forms.py
98.64% <ø> (-0.22%)
:arrow_down:

...ps/volontulo/migrations/0009_auto_20170925_2217.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac6de3...c42a366. Read the comment docs.


.WebP images are not animating on IOS devices

Bug
When running the app on WEB or Android the animated .webP images are working pretty smooth, but not on IOS (no animation).
Solution proposal
Since .gif files were working pretty smooth on IOS before, as a solution I propose bringing them back, compress them on Gif Compressor, and import them only for IOS.

Resolved by #91


Integrate commit message validation also into testing step

Note: Will need to take care of special cases such as commits generated by @greenkeeperio (see also: https://github.com/greenkeeperio/greenkeeper/issues/153).

Opening as there are still some issues that need to be fixed.


Fix occasional invalid UTF-8 byte sequences

A big PDF file we were parsing had some UTF-8 glyphs that caused the code to crash in the following code example:
reader = PDF::Reader.new(file_path)
reader.pages.each do |reader_page|
        puts reader_page.text
end

After rootling through the gem it seems that occasionally the to_utf8 function still gives invalid encodings. This pull request just does a belt-and-braces check to the utf8_chars before continuing.

I agree that this is likely to avoid some exceptions, but I'm concerned it might mask an underlying issue suggested by:

it seems that occasionally the to_utf8 function still gives invalid encodings

I expect a method called to_utf8 to always return a utf8 encoded string and it's curious that it seems to not be the case for the PDF you have.
Are you able to explore a bit further? Alternatively, I'd be happy to examine the PDF if it's one you're open to sharing,

I'm going to close this due to inactivity, but please feel free to re-open if new information becomes available.
Thanks for contributing!

Still happening. I've attached a PDF file and a script that triggers the error.
PDF::Reader.new(File.open('sample_error.pdf')).pages.first.text
# ArgumentError: invalid byte sequence in UTF-8
# from .../ruby-2.4.5/gems/pdf-reader-2.2.0/lib/pdf/reader/page_layout.rb:50:in `strip'

sample_error.pdf
This is what the rows variable looks like in PDF::Reader::PageLayout#interesting_rows
 [" Introduction                          Methods                     Results                      Conclusions                   ",
 "                                                                                ",
 "                                                                                ",
 "                                                                                ",
 " Developing the index                                                                                ",
 "                                                                                ",
 "                                                                                ",
 "                                                                                ",
 "             • Variables                     Variables:                                                                       ",
 "             • Membership categories                                                                                ",
 " Define      • Membership function           1. S/D ratio                                                                     ",
 "                                                                                ",
 "                                             2. SAR                                                                           ",
 "                                                                                ",
 "                                             3. Distance                                                                      ",
 "             • Weights                                                                                ",
 " Assign                                                                                +                               ",
 "                                             4. Water scarcity                  SAR =      \xED\xED\xA0\xB5\xED\xB1\x83\xED\xA0\xB5\xED\xB1\x83\xED\xA0\xB5\xED\xB1\x83\xED\xA0\xB5\xED\xB1\x83 \xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3",
 "                                                                              S/D centro2d of grid cell to\x80\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\x96\xED\xA0\xB5\xED\xB1\x96 \xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3\xED\xA0\xB5\xED\xB1\xA3",
 "                                                                                nearest cultivated                          ",
 "             • Result of membership                                           DrillingInfo:                                   ",
 "              function                                                        • O&G wellsrainfall                             ",
 "Evaluate                                                                        • 1981-2010 Database:                         ",
 "                                                                              • • Rainfall percentile                         ",
 "                                                                              • • Lat/long (NLCD):                            ",
 "                                                                              • • Na, Ca, Mged crops                          ",
 "                                                                              • 118,307 wells                                 ",
 "                                                                                • 14,516 wells                   8            ",
 "                                                                                "]

@sebastianiorga we have been running with this pull request tweak since 2017 without any problem :)

Thanks for the sample PDF @sebastianiorga. I tracked down the root cause of the invalid encodings, and there's a fix on master (#294).


UPF Interface |UERANSIM Curl Problem

I can use uesimtun0 to ping but I can not use it to curl the free5GC webserver, which is running in another container. I also tried without uesimtun0 interface. It is able to curl the free5GC webserver.

Thanks in advance!

Hi @minziran
When you say

I can use uesimtun0 to ping

Do you mean that you can ping <IP_ADDRESS> using uesimtun0 as a source interface ?
This should not happen since your management network <IP_ADDRESS>/24 won't be reachable from the uesimtun0 interface/network.
Thus, curling <IP_ADDRESS>:5000 won't work also. What you are experiencing is a totally normal behavior. Nevertheless, if you still want to reach your management network for some reason from your UE, I think you should tweak your forwarding rules at the UPF level.
Cheers,

Thank you for your help!  I meant I can use uesimtun0 to ping google. I try to ping <IP_ADDRESS>. It failed. I do want to reach my management network from my UE side.  Is there any way can help to tweak my forwarding rules, such as using iptables, update UPF configuration or update uerouting files?

Did you tried something like iptables -t nat -A POSTROUTING -s [UE_subnet]/24 -o [UPF_mgmt_iface] -j SNAT --to <IP_ADDRESS>-<IP_ADDRESS> in the UPF ?
This should add a NATing rule to UE packets which have as a destination the management network.

UPF_mgmt_iface
Currently, I tried the following commands in the upfs.
#!/bin/sh

### UPF IPtables forwarding rules configuration

iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE
iptables -I FORWARD 1 -j ACCEPT

Thanks!  I will try the new command.

Did you tried something like iptables -t nat -A POSTROUTING -s [UE_subnet]/24 -o [UPF_mgmt_iface] -j SNAT --to <IP_ADDRESS>-<IP_ADDRESS> in the UPF ?
This should add a NATing rule to UE packets which have as a destination the management network.

I deployed all the components(like app, web ui) in docker-compose in a private network. I have updated the upf  container configuration files as followed:
#!/bin/sh
### UPF IPtables forwarding rules configuration

iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE
iptables -I FORWARD 1 -j ACCEPT
iptables -t nat -A POSTROUTING -s <IP_ADDRESS>/24 -o eth0 -j SNAT --to <IP_ADDRESS>-<IP_ADDRESS>

And I try to ping, curl and traceroute. Curl and traceroute still failed. The result is like:
root@78ec12b7a188:/# curl --interface uesimtun0 <IP_ADDRESS>:8081
^C
root@78ec12b7a188:/# curl --interface uesimtun0 mendix:8081
^C
root@78ec12b7a188:/# curl --interface uesimtun0 webui:5001
curl: (7) Failed to connect to webui port 5001: Connection refused
root@78ec12b7a188:/# traceroute --interface=uesimtun0 <IP_ADDRESS> -p8081
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  2.327 ms  2.280 ms  2.241 ms
 2  mendix.free5gc-compose_privnet (<IP_ADDRESS>)  2.531 ms  2.496 ms  2.455 ms
root@78ec12b7a188:/# ping -I uesimtun0 mendix
PING mendix (<IP_ADDRESS>) from <IP_ADDRESS> uesimtun0: 56(84) bytes of data.
64 bytes from mendix.free5gc-compose_privnet (<IP_ADDRESS>): icmp_seq=1 ttl=63 time=1.36 ms
64 bytes from mendix.free5gc-compose_privnet (<IP_ADDRESS>): icmp_seq=2 ttl=63 time=1.55 ms
^C
--- mendix ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 1.359/1.456/1.554/0.097 ms
root@78ec12b7a188:/# ping -I uesimtun0 webui
PING webui (<IP_ADDRESS>) from <IP_ADDRESS> uesimtun0: 56(84) bytes of data.
64 bytes from webui.free5gc-compose_privnet (<IP_ADDRESS>): icmp_seq=1 ttl=63 time=1.38 ms
64 bytes from webui.free5gc-compose_privnet (<IP_ADDRESS>): icmp_seq=2 ttl=63 time=1.75 ms
^C
--- webui ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 1.379/1.565/1.751/0.186 ms
root@78ec12b7a188:/# curl --interface uesimtun0 <IP_ADDRESS>:5001
curl: (7) Failed to connect to <IP_ADDRESS> port 5001: Connection refused
root@78ec12b7a188:/# curl --interface uesimtun0 <IP_ADDRESS>:5000
^C
root@78ec12b7a188:/# traceroute --interface=uesimtun0 <IP_ADDRESS> -p8081
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  2.494 ms  2.442 ms  2.575 ms
 2  mendix.free5gc-compose_privnet (<IP_ADDRESS>)  2.632 ms  2.598 ms  2.629 ms
root@78ec12b7a188:/# traceroute --interface=uesimtun0 <IP_ADDRESS> -p5001
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  2.128 ms  2.115 ms  2.140 ms
 2  webui.free5gc-compose_privnet (<IP_ADDRESS>)  2.473 ms  2.430 ms  2.375 ms
root@78ec12b7a188:/# traceroute --interface=uesimtun0 <IP_ADDRESS> -p5001
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  3.007 ms  2.945 ms  2.892 ms
 2  webui.free5gc-compose_privnet (<IP_ADDRESS>)  2.850 ms  2.873 ms  2.914 ms
root@78ec12b7a188:/# ^C
root@78ec12b7a188:/# curl --interface uesimtun0 <IP_ADDRESS>:5001
curl: (7) Failed to connect to <IP_ADDRESS> port 5001: Connection refused
root@78ec12b7a188:/# curl --interface uesimtun0 <IP_ADDRESS>:8081
^C
root@78ec12b7a188:/# curl --interface uesimtun0 google.com
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<TITLE>301 Moved</TITLE>

301 Moved

The document has moved
here.

Try to execute the last iptables command first (order matters)

Try to execute the last iptables command first (order matters)

I put the last command at the first place. Then, I try to ping google.com it failed.
Did I use the correct command?
Thank you very much for your help!
The output is like:
root@1c1303ed825a:/# traceroute --interface=uesimtun0 mendix -p8081
traceroute to mendix (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  2.360 ms  2.306 ms  2.261 ms
 2  * * *
 3  * * *
 4  * * *
 5  * * *
 6  * * *
 7  * * *
 8  * * *
 9  * * *
10  * * *
11  * * *
12  * * *
13  * * *
14  * * *
15  * * *
16  * * *
17  * * *^C
root@1c1303ed825a:/# traceroute --interface=uesimtun0 google.com
traceroute to google.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  upf2.free5gc-compose_privnet (<IP_ADDRESS>)  2.177 ms  2.148 ms  2.176 ms
 2  * * *
 3  * * *
 4  * * *
 5  * * *
 6  * * *
 7  * * *
 8  * * *
 9  * * *
10  * * *
11  * * *
12  * * *
13  * * *
14  * * *
15  * * *
16  * * *
17  * * *
18  * * *
19  * * *
20  * * *
21  * * *
22  * * *
23  *^C
root@1c1303ed825a:/# ping -I uesimtun0 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) from <IP_ADDRESS> uesimtun0: 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
4 packets transmitted, 0 received, 100% packet loss, time 3077ms

root@1c1303ed825a:/# ^C
root@1c1303ed825a:/# ^C
root@1c1303ed825a:/#

Hi @minziran, any update on this issue?


rio.(Multi)Slider Add Range Selection Capability to rio.(Multi)Slider Component

It would be beneficial to have the ability to select a range in a Slider. I'm uncertain whether this functionality should be integrated into the existing rio.Slider() or if it should be implemented as a separate component, considering SliderChangeEvent and so on.
Result:

Use Case:
This feature is particularly useful in scenarios where a range of values needs to be selected, such as filtering data within a certain range, setting a range of dates, or adjusting parameters that work within a specified interval. By allowing range selection, the MultiSlider component can cater to a broader range of applications and user needs.
Related Issue:
#45

This could either be implemented as a new component, or by adding a second value to rio.Component. If we go with the second route we just gotta make sure the names of the values don't end up being confusing.


Rollbar-Log4J Additional Docs

internal: https://app.intercom.io/a/apps/rlisg82q/inbox/inbox/849049/conversations/17224559673
Could we verify this, so the docs can be updated properly?
When setting up rollbar-log4j java integration in a project which builds a fat-jar, additional configuration is needed, which is not mentioned in the docs or example. As rollbar-log4j contains additional .dat files, these must to be concatenated with the other log4j files.
This can be achieved using this gradle lib https://github.com/TheBoegl/shadow-log4j-transformer
This is the maven equivalent: https://github.com/edwgiz/maven-shaded-log4j-transformer (however, I only used the gradle solution so far)
This issue contains additional information, the logged error, as well as the links to the libraries https://issues.apache.org/jira/browse/LOG4J2-954 Might be worth adding this to the rollbar doc, as the logged error is a little misleading.

Hey there. I initially submitted this issue via the official communication channels. Just wanted to let you know that, if you have any questions or need any help, please feel free to ping me.

Hi Steve,
Thanks for reporting this! I updated the documentation so it reflects the solutions you commented here. You can check them here https://docs.rollbar.com/docs/log4j2


DEFAULT collect_metrics to false

🐛 Describe the bug
Hello,
I am currently working on a project using EmbedChain with RAG. I noticed that metrics are being sent to EmbedChain by default. For clarity and in the interest of user privacy, might I suggest changing the default setting to "NO"? This would enhance trust and transparency for users of the platform.
Thank you for considering this feedback.
Best regards,
Simo

Hi @firetix, thank you for bringing this up. We appreciate your feedback. The telemetry is on by default to improve the experience of the platform. If we disable it, then it is quite likely that we won't get any data to see the usage pattern and hence won't be able to improve the package and the platform.
We will, although, make it more obvious to let users know that the telemetry is on and show instructions on how to disable it in the logs itself whenever someone is creating an app.
Thank you for your understanding.

Created an issue for the same here: https://github.com/embedchain/embedchain/issues/894

I appreciate your perspective on the matter. However, I'd like to emphasize that many prominent organizations may be hesitant to adopt this library due to its default behavior. Ensuring user privacy and trust is paramount, and any perceived breach of this could deter potential users. I strongly recommend reconsidering this approach.

Hello @firetix,
Thank you for your response. I completely agree that privacy and trust are paramount, and we highly value the security and privacy of our users. We are committed to being transparent about the anonymous data we collect, enabling users to disable it before transitioning to the production phase with Embedchain.
As an open-source project, it is imperative for us to have anonymous telemetry enabled by default to enhance the project effectively. It's worth noting that many popular open-source projects follow a similar approach with telemetry enabled by default.
For further insights on the topic of anonymous telemetry in open-source projects, I recommend reading the informative blog post by Posthog: https://posthog.com/blog/open-source-telemetry-ethical
Thank you for your understanding.

We will be forced to recreate metrics instead of using this library, just because we cannot afford to use the library with out-out telemetry. Sorry.


No examples will work

Current behaviour
Using the code template from TopBarTextExample doesnt show any views.
Expected behaviour
Upon clicking a tab header, show the respective view.
Code sample
import * as React from 'react';
import { StyleSheet, Dimensions, View } from 'react-native';
import { TabViewAnimated, TabBar, SceneMap } from 'react-native-tab-view';
import SimplePage from './SimplePage';

const Albums = () => <View style={[ styles.container, { backgroundColor: '#ff4081' } ]}></View>;
const Contacts = () => <View style={[ styles.container, { backgroundColor: '#ff4081' } ]}></View>;
const Article = () => <View style={[ styles.container, { backgroundColor: '#ff4081' } ]}></View>;
const Chat = () => <View style={[ styles.container, { backgroundColor: '#ff4081' } ]}></View>;

// type State = NavigationState<
//   Route<{
//     key: string,
//     title: string,
//   }>
// >;

const initialLayout = {
  height: 0,
  width: Dimensions.get('window').width,
};

export default class TopBarTextExample extends React.Component {
    static title = 'Scrollable top bar';
    static backgroundColor = '#3f51b5';
    static appbarElevation = 0;

    state = {
      index: 1,
      routes: [
        { key: 'article', title: 'Article' },
        { key: 'contacts', title: 'Contacts' },
        { key: 'albums', title: 'Albums' },
        { key: 'chat', title: 'Chat' },
      ],
    };

    _handleIndexChange = index =>
      this.setState({
        index,
      });

    _renderHeader = props => (
      <TabBar
        {...props}
        scrollEnabled
        indicatorStyle={styles.indicator}
        style={styles.tabbar}
        tabStyle={styles.tab}
        labelStyle={styles.label}
      />
    );

    _renderScene = SceneMap({
      albums: Albums,
      contacts: Contacts,
      article: Article,
      chat: Chat,
    });

    render() {
      return (
        <TabViewAnimated
          style={[styles.container, this.props.style]}
          navigationState={this.state}
          renderScene={this._renderScene}
          renderHeader={this._renderHeader}
          onIndexChange={this._handleIndexChange}
          initialLayout={initialLayout}
        />
      );
    }
  }

  const styles = StyleSheet.create({
    container: {
      flex: 1,
    },
    tabbar: {
      backgroundColor: '#3f51b5',
    },
    tab: {
      width: 120,
    },
    indicator: {
      backgroundColor: '#ffeb3b',
    },
    label: {
      color: '#fff',
      fontWeight: '400',
    },
  });

Screenshots (if applicable)

What have you tried
I've tried practically ALL of the examples and all have the same issue i've described.
https://github.com/react-native-community/react-native-tab-view/tree/master/example
Your Environment

software
version

android
8.0.0

react-native
0.55.3

react-native-tab-view
0.0.77

node
8.9.4

yarn
1.3.2

Downgrading version to 0.074 solved my issues!
Closing this!

I think is needed to reopen this issue because the problem was not solved in v1.0.0

Can you provide an example on snack.expo.io?

Hey, I just released a new alpha 2.0.0-alpha.0 of the library. It's rewritten using react-native-gesture-handler and react-native-reanimated addresses a many platform specific bugs and performance problems. The documentation is updated as well.
Please try the new version and see if it addresses your issue. If not, please open a new issue following the issue template.

Please reopen this issue, as it doesn't address the solution for it


Update Node 12 actions and set-output to prevent warning

Could you please update set-output and used actions jwalton/gh-find-current-pr, marocchino/sticky-pull-request-comment to prevent GitHub warnings.
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jwalton/gh-find-current-pr, marocchino/sticky-pull-request-comment

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Thank you!

@academo Thank you for fixing.


file not found should not quit

[10:32:46] Using gulpfile ~/Projects/liao/gulpfile.js
[10:32:46] Starting 'web:develop'...
[10:32:46] Starting 'web:pre-target-check'...
[10:32:46] Finished 'web:pre-target-check' after 96 μs
[10:32:46] Starting 'web:build:clean'...
delete: /dist
[10:32:46] Finished 'web:build:clean' after 25 ms
[10:32:46] Starting 'web:bundle'...
[10:33:15] Finished 'web:bundle' after 29 s
[10:33:15] Starting 'web:copy-assets'...
[10:33:15] Starting 'web:watch'...
[10:33:15] Starting 'web:local-serve'...
[10:33:15] Finished 'web:local-serve' after 106 ms
[10:33:15] Server started http://<IP_ADDRESS>:8000
[10:33:15] Finished 'web:copy-assets' after 170 ms
2016-04-06 10:33:41		3285645 bytes written (26.32 seconds)
[10:33:42] Finished 'web:watch' after 27 s
[10:33:42] Finished 'web:develop' after 55 s
events.js:154
      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, open 'index.html'
    at Error (native)

Sounds like you have an error in your gulp file. Can you show the contents of 'web:develop'?

can not because the build process because index.html does not exist catch
issue line https://github.com/AveVlad/gulp-connect/blob/master/src/index.coffee#L128

@justinmchase

It should only fallback through to that code if you have the fallback option set, try unsetting that or setting it to a file that actually exists.
var gulp = require('gulp'),
  connect = require('gulp-connect');

gulp.task('connect', function() {
  connect.server({
    root: 'app',
    livereload: true,
    fallback: 'index.html' // <- set this to a valid path or remove
  });
});


Class 'App' not found in EloquentJoinBuilder.php:193 when using standone Eloquent

When using Eloquent without Laravel, an error is thrown because the App class doesn't exist.
As a quick work around I created a dummy class with the version.
 $relatedKey = ((float) \App::version() < 5.8) ? $relatedRelation->getQualifiedForeignKey() :
......
 $ownerKey = ((float) \App::version() < 5.8) ? $relatedRelation->getOwnerKey() : $relatedRelation->getOwnerKeyName();

You could use method exists instead of the Laravel version.

I created global class in my helpers.php as workaround
class App {
	public static function version() {
		return 5;
	}
}

I'm using this to avoid the use of version check
use Illuminate\Database\Eloquent\Relations\Relation;

public function getKeyFromRelation(Relation $relation, string $keyName)
{
    $getQualifiedKeyMethod = 'getQualified'.ucfirst($keyName).'Name';

    if (method_exists($relation, $getQualifiedKeyMethod)) {
        return last(explode('.', $relation->$getQualifiedKeyMethod()));
    }

    $getKeyMethod = 'get'.ucfirst($keyName);

    if (method_exists($relation, $getKeyMethod)) {
        return $relation->$getKeyMethod();
    }

    // relatedKey is protected before 5.7 in BelongsToMany
    $reflection = new \ReflectionClass($relation);
    $property = $reflection->getProperty($keyName);
    $property->setAccessible(true);

    return $property->getValue($relation);
}

Usage:
$obj->getKeyFromRelation($relation, 'ownerKey');

My first thought was also opportunity of checking method_exists, but such solution requires to modify sources. Maybe someone can fork and make a pull request for that.

@NesCafe62 Unfortunately I never tested this package outside laravel (only with eloquent).
Does anyone know how to get eloquent version inside eloquent code ?

I think the only way is to check for method existance.


Fixed Error Handling to use intended Bootstrap Elements

The help-block should also be used for error-handling, since all text elements be colored red anyway and the help-block is intended to be placed under a text input unlike text-warning.

For reference: http://getbootstrap.com/css/#forms-example


Fix incorrectly removing two characters by auto brace

In some situations when there were no braces auto brace still removed two
characters.  This has been fixed by adding a test that a brace is found.
This should fix #52139.

Thank you!


Run workers without (root) login shell option

We currently run a login shell which will use source to load the evm environment.
Instead, this directly loads the environment directly and does not rely upon a bash login shell.
We are making this change to get away from relying upon root's bashrc configuration and
eventually run these are a non-root user.
I would have liked to have used EnvironmentFile instead of sourcing the script
but that change was non-trivial
This is a continuation of #20983
I will add User= and make all of these in one sweeping change to the other 22 repos.

@kbrock what from /etc/default/evm would be hard to extract?
Looking at https://github.com/ManageIQ/manageiq-appliance/tree/master/LINK/etc/default it seems like it'd be
# from /etc/default/evm
RAILS_ENV=production
APPLIANCE=true
HOME=/root # Maybe we don't need this if we're not using `bash -l`?
EXECJS_RUNTIME='Node'
MALLOC_ARENA_MAX=1
KEY_ROOT=/var/www/miq/vmdb/certs
LANGUAGE=en_US.UTF-8
LANG=en_US.UTF-8
LC_CTYPE=en_US.UTF-8

# from /etc/default/evm_ruby
RUBY_GC_HEAP_GROWTH_MAX_SLOTS=300000 # default: no limit
RUBY_GC_HEAP_INIT_SLOTS=600000 # default: 10000
RUBY_GC_HEAP_GROWTH_FACTOR=1.25 # default 1.8

# from /etc/default/evm_postgres
APPLIANCE_PG_CTL=/usr/bin/pg_ctl
APPLIANCE_PG_MOUNT_POINT=/var/lib/pgsql
APPLIANCE_PG_DATA=${APPLIANCE_PG_MOUNT_POINT}/data
APPLIANCE_PG_SERVICE=postgresql
APPLIANCE_PG_PACKAGE_NAME=postgresql-server

But I could be missing something.  I don't see evm_production anywhere maybe that's where the complexity is?

https://github.com/ManageIQ/manageiq-appliance/pull/309#issuecomment-808486153

@kbrock @agrare Can this be merged ahead of moving to a properties file?  It feels like this is pretty self-contained and progresses forward, so I'd be good with merging, but this might require changing all of the units in all of the plugins too

Yes we could do that, @kbrock how much benefit is there in making this change without also running as non-root?  I was under the impression the reason for this was so that we could run these as non-root so just this change might not be beneficial

@agrare @Fryguy this runs fine as root, and is required to run files as non-root
We are also thinking about modifying these service files to set the properties file, User, Group, and potentially umask. While they are separate, I'm unsure that we want to push through 4 service updates across 17(?) repos. It is cleaner to keep these PRs separate.
I was thinking about putting these in core to make sure this seemed to work, then focus on rolling out to the other repos. but maybe just changing these values in a VM is a good enough testing strategy.

It's up to you and the level of effort.  If you think it's easier to just go straight to a properties file, then we should probably close this PR.


chore: dependency cleanup

What does this PR do?
remove cli-ux in favor of its equivalent from oclif/core
remove [seemingly] unused npm dependencies
What issues does this PR fix or reference?

make sure the Flags import is coming from sf-plugins-core instead of oclif/core

seemed fine.  I left one that was importing oclif command, too.

replace CliUx.ux with the corresponding methods on SfCommand, e.g. CliUx.ux.action.start/stop => this.spinner.start/stop, CliUx.ux.table => this.table

their UT didn't like that (even just the spinners) so I reverted that


Translate Everything Into English

All PlanetDescription() are translated from Indonesian to English with no problem. Enhancement are closed.


Nearby/PW is inconsistent

[EDIT] - I closed this issue since I was testing with bad variables (beacon was advertising too rarely among other things). I even managed to register and see URL attachments to EID beacons. My last point still stands though.
I spent some time trying to get Nearby Notifications to work for an EID beacon (if that's not possible, my apologies - beacon is registered and visible in Beacon Tools). I never managed to, so I tried the simples possible case instead - a single Estimote physical beacon, configured as an Eddystone URL pointing to https://www.wikipedia.org
Nexus 5: Android 5.1 / GPS 9.4.52:

BT on / Location on / Chrome PW on
extremely complicated to manage to show a notification; sometimes it shows after screen is turned off and on, most times nothing happens; it seems that when the screen is turned on after a longer sleep period, the probability of any notification to appear is close to zero.
Physical Web app shows the beacon, at the same time Nearby says that no links are around. The beacon is standing 30 cm away.

Nexus 6: Android N / GPS 9.4.52:

BT on / Location on / Chrome PW on
also buggy; notification appears after screen off/on with 50% probability, and its not even the Nearby notification, its the Physical Web app's one...

There are nice potential ground-breaking ideas for PW, but there needs to be more obvious ways to bring things up to the user, or at least make it an option based on all sorts of criteria (example: URL domain vs any installed apps or registered service workers - they would likely imply user agrees to be "annoyed"?). Absolutely nobody will randomly turn on their phone desperately looking for a hidden notification, except us developers :)

Adrian, don't be shy about this! If you feel you have a case where things aren't showing up, please don't be shy about posting another issue.


Added Name : Yahya Khan

Thank you for letting me contribute to this amazing community!

@schmelto changes done as requested !


Select a proper license file for the project

Perfectly fine with this change. I'm going to merge the pull-request and close the task.


LeaderCount value of StoreStatus type of The Store recommends not set auto-hide.

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
When I am execting rolling_update for tikv-server, but ansible can not find leader_count with PD's metadata.so that executed failed.

TiDB-Ansible Error
ERROR MESSAGE SUMMARY **************************************************************************************************************************************
[tikv146_20172]: Ansible FAILED! => playbook: rolling_update.yml; TASK: check tikv's leader count; message: {"msg": "The conditional check '(store_info.json.status.leader_count is defined and store_info.json.status.leader_count|int < 1) or store_info.json.status.leader_count is not defined' failed. The error was: error while evaluating conditional ((store_info.json.status.leader_count is defined and store_info.json.status.leader_count|int < 1) or store_info.json.status.leader_count is not defined): 'dict object' has no attribute 'json'"}

What did you expect to see?

LeaderCount value of StoreStatus type of The Store recommends not set auto-hide when Leader_count is zero.

What did you see instead?

When I retry rolling_update for this tikv-server of tikv146_20172, that success.

What version of PD are you using (pd-server -V)?

v3.0.5

Good idea.


Hello, when i use subsetMaf() function, an error was present 'Can not cast an empty data.table'

Hello, when when i use subsetMaf() function to extract special samples ,an  an error was present  that is:
'Error in dcast.data.table(data = vc, formula = Tumor_Sample_Barcode ~  :  Can not cast an empty data.table'
the detailed questions was below:
the code is
maf_1_high <- subsetMaf(maf=maf_1, tsb = c('TCGA-AG-A002'), isTCGA = TRUE)

when i use 'getSampleSummary(maf_1) ` to get the sample summary, the first sample is 'TCGA-AG-A002-01A-01W-A00K-09 '
the sample is really exist, but i can't extract it.
class(maf_1)
[1] "MAF"
attr(,"package")
[1] "maftools"

sessionInfo()
R version 4.0.0 (2020-04-24)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18362)

Matrix products: default

locale:
[1] LC_COLLATE=Chinese (Simplified)_China.936
[2] LC_CTYPE=Chinese (Simplified)_China.936
[3] LC_MONETARY=Chinese (Simplified)_China.936
[4] LC_NUMERIC=C
[5] LC_TIME=Chinese (Simplified)_China.936

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods
[7] base

other attached packages:
[1] TCGAbiolinks_2.16.1 maftools_2.4.10     data.table_1.12.8

I have been engaged for 2 days for this problem,Looking forward to your reply. Thank you very much!

Hi,
Setting isTCGA = TRUE will truncate the barcode to first 12 characters. That means your maf should also be generated with isTCGA = TRUE while reading with read.maf. This seems to be not the case here since your maf has the full length barcode.
Could you try with full barcode name as in below and it should work.
maf_1_high <- subsetMaf(maf=maf_1, tsb = c('TCGA-AG-A002-01A-01W-A00K-09'))

Thank you very much!, it really works. According your instruction, when i use read.maf() function to read data, the parameter isTCGA = FALSE changed to True, then i can use this code
maf_1_high <- subsetMaf(maf=maf_1, tsb = c('TCGA-AG-A002'), isTCGA = TRUE).
But when i use only the 12 characters, may be there will be duplicate sample names, because the sample from different parts of the same patient wil be given the same same barcode.
Will it affect data import and the subsequent data analysis?

By the way, when i use coOncoplot() to plot the different mutation in two groups, the default genes number is 5, how to display the top 10  different mutation genes. thank you.

Yes, it will affect the downstream analysis.
isTCGA exists to speed up some processes where annotations are usually available with 12 characters whereas barcodes in MAF are not. I suggest not to use isTCGA argument.
Also there is no top argument for coOncoplot. Use genes instead.


Correct utilitySelectors RegEx typo

Correct the regex given to utilitySelectors to double escape the period, fixes #7

Thanks!

👍🏼👍🏼👍🏼


Distributed scenarios?

From reading the article, It seems to assume the services are on the same machine (particularly the usage of file system for the data protection storage).
Could this document elaborate on the best practice when those services aren't on the same machine?
I'm aware of IAuthenticationSessionStore in OWIN Cookie middleware and ASP.NET Core's ITicketStore that can be used. The latter can utilize IDistributedCache and the built in implementations for it, But i can't see any known implementations for those scenarios for OWIN.
The other part would be where and how to store the data protection keys in a distributed manner.
Advice appreciated :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99307104-c0d7-3e82-f0b2-af61dcfe072a
Version Independent ID: 315c02cb-54c4-e386-da85-6e4311ca10c2
Content: Share authentication cookies among ASP.NET apps
Content Source: aspnetcore/security/cookie-sharing.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

This seems to be explained in the Data Protection part of the documentation; Perhaps add a section refering to that?

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.


getting "Task was cancelled" error after 4 or 5 minutes of runtime

Hey ,
I am getting this error while running the program on intellij after 4 or 5 minutes of run.
Exception in thread "main" java.util.concurrent.CancellationException: Task was cancelled.
at com.google.common.util.concurrent.AbstractFuture.cancellationExceptionWithCause(AbstractFuture.java:1543)
at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:586)
at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:463)
at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:99)
at com.google.common.util.concurrent.ForwardingFuture.get(ForwardingFuture.java:73)
at com.google.api.gax.longrunning.OperationFutureImpl.get(OperationFutureImpl.java:131)
at org.example.Importbuild.main(Importbuild.java:86)
I have defined following parameters of 120 minutes timeout units , although build will be still working in GCP platform which can be seen in build history but in intellij error appears in 4 or 5 minutes.
Build response = cloudBuildClient.createBuildAsync(request).get(120, TimeUnit.MINUTES)
What can be the reason of this?

@rajatg717 Sorry for late response. Do you still see this is a problem?

Please recreate an issue if this is still a problem.


[Code app]: Add Application log option to context menu

EPAM AI DIAL chat version
0.20.0
How to reproduce
Need to add Application log option to context menu for deployed code apps:

for published and deployed apps for admin user
for deployed app for creator user

Actual result
now there is no option in context menu, on the application view only

Expected result
Application log should be added to context menu, when it is applicable
Confidential information

[X] I confirm that do not share any confidential information

verified on staging successfully


commit_version_bump- fatal: Not a git repository (or any of the parent directories): .git

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the [Contribution Guidelines]
(https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)

Issue Description
Whenever I try to do a git related action, it fails. And not 100% why..
If I use the action git_branch, the result appears to be null.
Though if I do ``sh 'git branch'` it shows my branches.
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

`### Captured Output
Command Used: gittest
Output/Log

Successfully loaded Appfile at path '/Users/simon/Development/mobile/MyApp-ios/Appfile'
- app_identifier: 'xxxx'
- apple_id: 'xxxx'
-------
DEBUG [2017-01-28 13:18:02.51]: Checking if there are any plugins that should be loaded...
INFO [2017-01-28 13:18:02.55]: -------------------------------------------------
INFO [2017-01-28 13:18:02.55]: --- Step: Verifying required fastlane version ---
INFO [2017-01-28 13:18:02.55]: -------------------------------------------------
INFO [2017-01-28 13:18:02.55]: Your fastlane version 2.12.0 matches the minimum requirement of 1.109.0  ✅
INFO [2017-01-28 13:18:02.56]: ------------------------------
INFO [2017-01-28 13:18:02.56]: --- Step: default_platform ---
INFO [2017-01-28 13:18:02.56]: ------------------------------
INFO [2017-01-28 13:18:02.56]: Driving the lane 'gittest' 🚀
INFO [2017-01-28 13:18:02.56]: -------------------------------------------
INFO [2017-01-28 13:18:02.56]: --- Step: git rev-parse --show-toplevel ---
INFO [2017-01-28 13:18:02.56]: -------------------------------------------
INFO [2017-01-28 13:18:02.56]: $ git rev-parse --show-toplevel
INFO [2017-01-28 13:18:02.59]: ▸ /Users/simon/Development/mobile/MyApp-ios
INFO [2017-01-28 13:18:02.59]: ------------------------
INFO [2017-01-28 13:18:02.59]: --- Step: git branch ---
INFO [2017-01-28 13:18:02.59]: ------------------------
INFO [2017-01-28 13:18:02.59]: $ git branch
INFO [2017-01-28 13:18:02.60]: ▸ * dev
INFO [2017-01-28 13:18:02.60]: ▸ dev-fastlane
INFO [2017-01-28 13:18:02.60]: ▸ master
INFO [2017-01-28 13:18:02.61]: ------------------------
INFO [2017-01-28 13:18:02.61]: --- Step: git_branch ---
INFO [2017-01-28 13:18:02.61]: ------------------------
INFO [2017-01-28 13:18:02.63]: ---------------------------------
INFO [2017-01-28 13:18:02.63]: --- Step: commit_version_bump ---
INFO [2017-01-28 13:18:02.63]: ---------------------------------
INFO [2017-01-28 13:18:02.63]: $ git rev-parse --show-toplevel
INFO [2017-01-28 13:18:02.63]: ▸ fatal: Not a git repository (or any of the parent directories): .git
WARN [2017-01-28 13:18:02.64]: Lane Context:
INFO [2017-01-28 13:18:02.64]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>nil, :LANE_NAME=>"gittest"}
ERROR [2017-01-28 13:18:02.64]: Exit status of command 'git rev-parse --show-toplevel' was 128 instead of 0.
fatal: Not a git repository (or any of the parent directories): .git

INFO [2017-01-28 13:18:02.64]: Successfully generated documentation at path '/Users/simon/Development/mobile/MyApp-ios/README.md'

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | git rev-parse --show-toplevel       | 0           |
| 4    | git branch                          | 0           |
| 5    | git_branch                          | 0           |
| 💥   | commit_version_bump                 | 0           |
+------+-------------------------------------+-------------+

ERROR [2017-01-28 13:18:02.65]: fastlane finished with errors

✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.2

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.2 (16C67)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./Fastfile`
# More documentation about how to customize your build
# can be found here:
# https://docs.fastlane.tools
fastlane_version "1.109.0"

# This value helps us track success metrics for Fastfiles
# we automatically generate. Feel free to remove this line
# once you get things running smoothly!
generated_fastfile_id "6a52f69f-53d8-40db-b16d-2c779582c8cf"

default_platform :ios

# Fastfile actions accept additional configuration, but
# don't worry, fastlane will prompt you for required
# info which you can add here later

lane :gittest do
	sh 'git rev-parse --show-toplevel'
	sh 'git branch'
	git_branch
	commit_version_bump(
	  message: "Version Bump - 1"
	)

  	push_to_git_remote(
	  remote: "github",         # optional, default: "origin"
	  local_branch: "dev",  # optional, aliased by "branch", default: "master"
	  remote_branch: "dev" # optional, default is set to local_branch
	)
end

`./Appfile`
# The Appfile can be used to specify information that's used across all fastlane
# tools, like your username or the app's bundle identifier.
#
# For more details, check out the documentation at:
# https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

 app_identifier "xxxxx" # the bundle identifier of your app
 apple_id "xxxxx" # Your Apple ID

fastlane gems

Gem
Version
Update-Status

fastlane
2.12.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

CFPropertyList
2.3.4

activesupport
<IP_ADDRESS>

addressable
2.5.0

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.13.7

claide
1.0.1

colored
1.2

commander
4.4.3

domain_name
0.5.20161129

dotenv
2.1.2

excon
0.54.0

faraday
0.11.0

faraday-cookie_jar
0.0.6

faraday_middleware
0.11.0

fastimage
2.0.1

gh_inspector
1.0.3

google-api-client
0.9.22

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

i18n
0.7.0

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
2.9.0

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.4.3

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
2.3.0

retriable
2.1.0

rouge
1.11.1

rubygems-update
2.5.2

rubyzip
1.2.0

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

thread_safe
0.3.5

tzinfo
1.2.2

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.3

word_wrap
1.0.0

xcodeproj
1.4.2

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

generated on: 2017-01-28
`
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
(Same as output above)

hmmm - for whatever reason it does not seem to be a git repo.
can you try running this
git rev-parse --show-toplevel

and see what the output is?

hi @hjanuschka ,
So i ran git rev-parse --show-toplevel as part of my script and you can see it log out my current directory where my project is in. Its also the same directory that my .git folder is sitting.
So git rev-parse --show-toplevel outputs
/Users/simon/Development/mobile/MyApp-ios
And my git folder is sitting at
/Users/simon/Development/mobile/MyApp-ios/.git
Im relatively new to the Git stuff, but my project is currently being synced to a GitHub repo and I can run git commands normally in that directory without issue. So I think based on that it must be the right 'git repo' type that its supposed to be expecting?

I would have a wild guess that it's some kind of permission issues, maybe.
If you ls -lha, what would the .git entry look like?
for me it's along these lines:
drwxr-xr-x  18 grebenma  staff   612B  3 Feb 21:22 .git

Hey there, i think the problem can be your fastlane folder reference please check if this is inside of your project like this "../MyApp-ios/fastlane"

@mgrebenets i get
drwxr-xr-x  17 simon  staff   578B Feb  1 11:03 .git
@caiobiodere
I don't have a fastlane folder in my project directory... 🤔

The missing fastlane directory must the be issue.
If you have fastlane gem installed on the system, the fastlane command may run, but will then fail since it can't find integration for this particular project.
Did you run fastlane init? How did you setup fastlane for your project?
Is the name of fastlane directory fastlane or .fastlane?
Maybe it's .fastlane and you didn't copy it while moving files, cause it's hidden...
In any case, setting up fastlane integration should help.

@simonarcher
Interesting, I am running in this very same issue right now - on TeamCity.
Was just setting up a new fastlane CI for existing project...

On another note, I am getting this directory when running bundle install && bundle update command even before running any of the Fastlane commands...

Hey @simonarcher
So I found the issue with my setup.
In my case all worked fine on my dev laptop, but failed on TeamCity.
The reason was the VCS checkout settings:
by default it uses "on the server" checkout mode

So I would assume it does checkout on server and then on the agent there is no .git directory.
That's why by bundle commands failed, because in my gepspec file I had git ls-files command.
For me the fix was to use the "Automatically on agent" option and all steps ran OK after that.
So in your case, it does seem very very similar.
Are your running it in CI environment too?


Update domains.json

Hi. I would like to configure our custom domain for our documentation, I have already configured it on our side. Looking forward to it!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

🎉  domain added! It may take a few minutes for everything to work properly


automatic logout from web interface - make "plugin read interval" changeable?

Hey,
I have another Issue I want to report:
Whenever I try to access the speedport's web interface, I'm automatically logged out after a few seconds.
I assume that this happens every time the HACS plugin logs itself in in order to read the router's parameters.
Maybe it might help to add an option to set the "plugin read interval" (e. g. to every five or ten minutes) manually and / or to pause reading in order to be able to manually change router settings?
Thanks and best regards,
David

Just thought about this problem again.
In the past, I used the script provided by aaronk6 (see here and here) that reads the router's encrypted JSON file, decrypts it and provides a decrypted version of the JSON file.
Maybe it's possible to combine this way of reading the router's values with your plugin?

Hey, that is a good idea. I introduced a configurable option, with which you can set for how many minutes the integration will not try to log in after an external login is registered. Try it out in v0.3.2 :slightly_smiling_face:
My integration uses the same decryption logic like aaronk6 (without knowing it :sweat_smile:) and reads in the same json data. The status.json is not the problem, but some data like the ip  addresses are not included and require other json files for which a login is needed.
btw the sensors that can be read from the status.json are not affected from the new pause

Another idea is create a binary sensor / toggle sensor to temporarily switch off the entire login from HA to the speedport.
If you want to go to the Speeport.ip UI and do things directly on the router, you could simply set the toggle so that logins from HA no longer happen.

Hey @MelleD, thanks for your feedback. But I think with the new configuration feature this is not really a problem anymore. If you really want to work for several hours in your router web interface and the logout every x minutes bothers you, you can disable the integration temporarily 😄

Hey @MelleD, thanks for your feedback. But I think with the new configuration feature this is not really a problem anymore. If you really want to work for several hours in your router web interface and the logout every x minutes bothers you, you can disable the integration temporarily 😄

I will test it and give feedback. I do a lot of things with a Overview Dashboard with the button template card and there would be toggle very easy and transparent :), but I will try the next version ;)

e.g.

Ignore the icon, is currently missing, but here I could just a new button/toggle or just if I click on the main card.

Thanks for your hard work! 🙂
Installed v0.3.2, no problems so far. Can't test thoroughly though as I'm on travel atm.
Toggling a switch is a nice idea, deactivating the integration is also okay.
Maybe mentioning this in README is a good idea ;)


Update IFCA to support LAGO project

This will be configured, but we still miss the credentials for LAGO, so data will not be published until we add them


Bluebird remove map mapSeries

Trying to find where unhandledRejection occurs, currently set WIP

So it was from manual transactions, rewrite using callback-style

Fantastic work, thank you!


Network Map

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
a simple network map in which you can put devices with icons and that shows you in color if it is down
✔ Solution
this is an example of a program (the dude), something similar but with the style of interface that the program has now

❓ Alternatives
No response
📝 Additional Context
No response

I am going to classify this as out of scope/ https://github.com/louislam/uptime-kuma/labels/wontfix.
We are a simple uptime management software => You can model your relationships via groups, but I don't think that adding a network map is something that we can do while sticking to our core UX.
(If you have different ideas or examples we can talk about them)


[Accessibility] python repl content is not parsable in the a11y terminal buffer when Powershell is used

CC @meganrogge

Note: the following issue is not found with cmd Command Prompt terminal profile. I suspect there is something that has to do with integrated shell.

Reproducible Steps

Load NVDA.

Run Terminal: Create New Terminal (With Profile).

Choose terminal-powershell

In Powershell, type python to open python repl.

Type the following in python shell and hit enter:

1+2

See if you can read ipython content in a11y terminal buffer.

Current Behavior
No terminal content available for this session. Run some commands to create content.

Expected Behavior
python content should be accessible in the terminal buffer.
System Info
Version: 1.76.0-insider (system setup)
Commit: 96a795cc0b1cd62f9ff66c347637f917c6dde3da
Date: 2023-02-17T22:22:55.538Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

This one's tricky because we don't trap the output of sub-shells ATM. Perhaps we should have a setting that lets the user decide whether or not we show the full contents of the buffer vs the shell integration contents

Yes, having that user setting would minimize this confusion.

As we've discussed the other way to work around this is by disabling shell integration. Perhaps we should just present the whole buffer when a screen reader is detected?
Do you think it would be useful to have cwd, the command, and output via shell integration or should we just provide the whole buffer @jooyoungseo ?
there's also the idea of using symbols / an outline view eventually #174079

@meganrogge -- Yes, the whole output would be preferred. I have detailed some more ideas about the terminal symbol providers in my response to #174079.

We are planning to present all of the contents of the terminal buffer going forward, so this won't be an issue


Added basic GitHub usage README.

Adapted from https://github.com/Azure/DASH/blob/main/doc-github-rules.md which I co-authored with MSFT.
Per Slack thread: https://opi-project.slack.com/archives/C033E418VCK/p1649275592758869
Feel free to use in other dbluff/OPI repos.

@seroyer That is a good suggestion, thanks. How about if I move the "I want to Contribute" section and doc-github-rules.md to https://github.com/opiproject/opithen point to those from various sub-projects, starting withopi-poc`, let it bake a while, then follow-up with subsequent PRs to other projects?

I submitted https://github.com/opiproject/opi/pull/3 to contain the doc and this PR was modified to link to that project. Hold off on this until the other PR is done and relative links can be tested.

@chrispsommers can we get this updated and closed out?  Thanks

@seroyer I'll do it soon, I was out of town last week. Thanks for reminder.

OK, I've caught this up, sorry for the delay.

@chrispsommers You need to sign all commits before we can merge them, can you amend your commit with the DCO and then force push back here? Thanks!


Add cargo binstall metadata

Right now cargo binstall cannot find the pre-compiled difftastic assets:
~
❯ cargo binstall difftastic
 INFO resolve: Resolving package: 'difftastic'
 WARN resolve: The package will be installed from source (with cargo)
Do you wish to continue? yes/[no]
? no
 WARN Installation cancelled

~ took 18s
❯ cargo binstall difftastic --pkg-url="{ repo }/releases/download/{ version }/difft-{ target }.{ archive-format }"
 INFO resolve: Resolving package: 'difftastic'
 WARN resolve: The package will be downloaded from github.com
 INFO resolve: This will install the following binaries:
 INFO resolve:   - difft (difft -> /home/michel/.cargo/bin/difft-v0.38.0)
 INFO resolve: And create (or update) the following symlinks:
 INFO resolve:   - difft (/home/michel/.cargo/bin/difft -> difft-v0.38.0)
Do you wish to continue? yes/[no]
? yes
 INFO install: Installing binaries...
 INFO Done in 9.277840305s

Adding this pkg-url override to Cargo.toml allows binstall to find the pre-compiled archives:
~
❯ cargo binstall --manifest-path ~/src/github/Wilfred/difftastic/Cargo.toml difftastic
 INFO resolve: Resolving package: 'difftastic'
 INFO resolve: difftastic v0.38.0 is already installed, use --force to override
 INFO Done in 5.327886ms

~
❯ cargo binstall --manifest-path ~/src/github/Wilfred/difftastic/Cargo.toml difftastic --force
 INFO resolve: Resolving package: 'difftastic'
 WARN resolve: The package will be downloaded from github.com
 INFO resolve: This will install the following binaries:
 INFO resolve:   - difft (difft -> /home/michel/.cargo/bin/difft-v0.38.0)
 INFO resolve: And create (or update) the following symlinks:
 INFO resolve:   - difft (/home/michel/.cargo/bin/difft -> difft-v0.38.0)
Do you wish to continue? yes/[no]
? yes
 INFO install: Installing binaries...
 INFO Done in 5.484314255s

Signed-off-by: Michel Alexandre Salim<EMAIL_ADDRESS>

Thanks.


Trying to get distinct document attribute values from a large collection fails

Hi,
I'm trying to retrieve the equivalent of a SELECT DISTINCT from a large (> 4,000,000) collection of documents via arangosh. So far I've tried two approaches:

using COLLECT
using the UNIQUE function

Sample queries used.
stmt = db._createStatement({"query":"FOR u IN user COLLECT level = u.level1 INSERT {\"group\": level} IN foo"} );
cursor = stmt.execute();

(Insert distinct values of a document attribute in to another collection)
stmt = db._createStatement({"query":"FOR foo IN UNIQUE((FOR u IN user RETURN u.level1)) RETURN {\"group\":foo}"} );
cursor = stmt.execute();

In both cases arangosh fails after a while with a 2001 timeout error. On some occasions (couldn't identify a pattern here) arangod crashes as well. I've tried tweaking the request and server timeouts to no avail. I used both Windows and Ubuntu on a reasonably specced machine (8gig RAM).
I'm fairly new to ArangoDB, so it's probably me doing something wrong. Could you please advise?
Edit: I found the critical point to be around 2m documents by experimenting with a LIMIT-clause. Obviously, I've been able to work around the issue and I appreciate that this kind of query is not necessarily a sweet spot for a document store..

Revisiting this one with ArangoDB 2.4.2 and 2.5/devel:
The query with the COLLECT clause needs to process all documents from the collection in sorted order, with user.level1 being the sort criterion. If there is a sorted (skiplist) index present on this attribute, the sort will be optimized away and the COLLECT will process the documents in already sorted index order. This will be far better than fetching all documents, then sorting them, and then creating the distinct result set.
I just tried the query on a collection with 4M documents and 90 distinct numeric values in level1. The query took about 4 seconds with a skiplist index and about 25 seconds without. But clearly the execution times will vary when using different value type (e.g. strings), a different data distribution etc.
The query containing the UNIQUE() function call will definitely have to read all documents to extract their level1 values, and then do a sort on these values in order to make them unique. It took around 9 seconds with my test data.
I guess you initially ran the queries on an ArangoDB 2.2, so I retried it with that version for a comparison:
The COLLECT version of the query did not finish after 3.5 minutes, so I stopped it.
The version with UNIQUE() finished in around 20 seconds with my test data.
So it looks like 2.4/2.5 have improved when compared with 2.2, though I would still like it to be faster for these queries.

Update for 2.6:
the COLLECT version of the query takes about 3.5 seconds in 2.6 with the test data, with or without an index. The UNIQUE version takes about 8 seconds.
So for the COLLECT version without an index we have:

2.2: 3.5 minutes
2.4: 25 seconds
2.5: 25 seconds
2.6. 3.5 seconds

And for the UNIQUE version:

2.2: 20 seconds
2.4: 9 seconds
2.5: 9 seconds
2.6: 8 seconds

Seems it got a lot better when compared to the original execution times, so I'll be closing this issue now.

Cheers... impressive numbers and thanks for following up.

It was about time to get this done.


[Create New Issue]:

Description
Description
Domain
Frontend Dev HTML, CSS, JS
Type of Contribution
Video
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign


Error: WordPress files seem to already be present here.

When I run npm run setup I get this error:
Error: WordPress files seem to already be present here.

@ellipticaldoor Interesting... I will take a look tonight. @amphrony do you know anything about this?

@sloansparger Yes.
@ellipticaldoor Remove directory, rebuild, and try again
rm -r wordpress/ mkdir wordpress/
Then run npm run setup again.

@ellipticaldoor I fixed the error you were seeing, you can follow what @amphrony said or just reclone the repo


Fix typos

remove redundant or reformat javadoc for clean(some can be ingored). fix typos, such as: a non-zero, a long, a utf-8, an array ,an html, an xa connection, an XAResource, an X-Powered-By, an OutputStream, an rpc, an XByteBuffer, an ArrayList, an abstract, an internal...

i will make other changes in spare time @markt-asf


Add ROI drawing widget for manual curation

This PR adds the ROI widget for manual curation and drawing masks for neuromodulator imaging. This PR is intended to start a development branch with updates for the widget

Testing complete. A new PR to main will be opened


Integrate travis CI for phpunit tests

Need to add Travis CI to run phpunit tests

I can add Travis ci configuration file if you want, but you then have to authorize it with Travis.

@narendravaghela Yes, I can authorize it with Travis. But you may need to look at the tests first in order to identify what are the constraints when using Travis.
These phpunit tests require migrating and seeding to be done initially to a database. Tests refer the database tables later. Will that be possible with Travis?

Let me check it on my fork first. We can do the database stuff with Travis, but that requires little bit time and efforts.

@narendravaghela I see. Let me know what you think.

@IMS94
I have generated PR. You can see the output of CI on my fork here - https://travis-ci.org/narendravaghela/chr247.com


Does Protractor + Appium works for Native or Hybrid apps

Was able to develop and execute Protractor successfully for web apps on desktop as well as Android. but faced issues with Native / Hybrid apps (based on PhoneGap).
Configuartion file:-
conf_mobile.js
exports.config = {
seleniumAddress: 'http://localhost:4723/wd/hub',
specs: ['example_spec_mobile.js'],
// Reference: https://github.com/appium/sample-code/blob/master/sample-code/examples/node/helpers/caps.js
capabilities: {
browserName: '',
'appium-version': '1.0',
platformName: 'Android',
platformVersion: '4.4.2',
deviceName: 'Android Emulator',
app: 'path to APK file'
},
allScriptsTimeout: 60000
};
Specification File:-
describe('homepage', function() {
it('validate service url', function() {
element(by.id('com.test.testApp:id/clearable_edit')).sendKeys('URL to type in text field');
element(by.id('com.test.testApp:id/serviceUrlButton')).click();
});
});
Error logs:-
D:\nodejs\node_modules\protractor\example>protractor conf_mobile.js
Using the selenium server at http://localhost:4723/wd/hub
[launcher] Running 1 instances of WebDriver
D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\atoms\error.js:113
var template = new Error(this.message);
^
UnknownError: Not yet implemented. Please help us: http://appium.io/get-involved.html
at new bot.Error (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\atoms\error.js:113:18)
at Object.bot.response.checkResponse (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\atoms\response.js:106:9)
at D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\webdriver.js:362:20
at D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\goog\base.js:1582:15
at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:
1654:20)
at notify (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:465:12)
at notifyAll (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:442:7)
at resolve (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:420:7)
at [object Object].fulfill (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:535:5)
at D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\promise.js:1520:10
==== async task ====
WebDriver.manage().timeouts().setScriptTimeout(60000)
at webdriver.WebDriver.schedule (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\webdriver.js:345:15)
at webdriver.WebDriver.Timeouts.setScriptTimeout (D:\nodejs\node_modules\protractor\node_modules\selenium-webdriver\lib\webdriver\webdriver.js:1301:23)
at Runner.createBrowser (D:\nodejs\node_modules\protractor\lib\runner.js:180:30)
at D:\nodejs\node_modules\protractor\lib\runner.js:259:24
at _fulfilled (D:\nodejs\node_modules\protractor\node_modules\q\q.js:797:54)
at self.promiseDispatch.done (D:\nodejs\node_modules\protractor\node_modules\q\q.js:826:30)
at Promise.promise.promiseDispatch (D:\nodejs\node_modules\protractor\node_modules\q\q.js:759:13)
at D:\nodejs\node_modules\protractor\node_modules\q\q.js:525:49
at flush (D:\nodejs\node_modules\protractor\node_modules\q\q.js:108:17)
[launcher] Process exited with error code 1

Any update, as we need to take the decision on what choice of language / tool to use. With Java Client libraries it is do able to automate Native Apps (Selenium WebDriver + TestNG + Appium), but does seems to be working with protractor.

Nope, as said, it is not yet implemented. We have a team TODO for this.

Thanks for your response.
Can you also let us know what is the ETA to bring in support for Native / Hybrid apps?

Testability for hybrid apps running in WebViews is somehow critical and - at least for me - a show-stopper, if not possible. So it is good to read that there is a team TODO for this. Unfortunately an existing TODO does not mean that it will be implemented soon - that's why i would be very happy if a rough statement about the plans on implementing this appears :)

See https://github.com/angular/protractor/issues/1940

Hi juliemr..may i know when is the release date for using protractor for hybrid apps runs in webview..in our project we need to finalize the tool.

Please your help:
http://stackoverflow.com/questions/30480452/cant-run-test-script-by-appium-on-node-js

@idaneliz Please have a look on you'r question at stackoverflow.

@nainighai how did you setup to be able to test against Android using protractor? can you please share what you've done?
Thanks

hi all,
when ever you are trying to run an apk file directly in to the device and run the test cases through protractor , check that apk you generated should be either in dev or debug stage not in release.
Was facing the same issue and  resolved it by changing it to either dev or debug stage./
Hope this works.

Hi,
I am trying to run Protractor tests by launching a Hybrid app on a mobile emulator. My app is getting launched but then it is getting closed with the error message: 'WebDriverError: No such context found'.
I have already included autoWebview: 'true' in my conf.js file
Any solution on this would be really helpful.

@ssudhanshu
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow
(use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!

Thanks @wswebcreation

@wswebcreation  is protractor still not supporting for Native App automation?

@babusurendra
True, no native support

Hi,
I am trying to run Protractor tests by launching a Hybrid app on a mobile emulator. My app is getting launched but then it is getting closed with the error message: 'ERROR - Unable to start a WebDriver session.'
Any solution on this would be really helpful.

@wswebcreation, Please let me know if it is possible to test Hybrid mobile app (not a web app) using Protractor + Appium.

Hi @kommuswamy
It is possible, only when your hybrid app starts with a Webview. The error you describe is a configuration error. SO or Google can help you with that.

Hi @kommuswamy
I was also facing the same issue. Generally, that WebDriver session issue comes when you have a WebView in your app and you have not switched to it. Hybrid apps contain WebViews. You need to switch to them in order to work on it.
Try adding below lines to your config file:
autoWebview: 'true',
autoWebviewTimeout: '10000',

Hi @ssudhanshu, I am facing same error which you mentioned above "No such context found." after adding the autoWebview: 'true', in my conf.js file.
did you file any request in StackOverflow or gitter?

Hi @kommuswamy
That means like mine, you have multiple contexts in your app like Native & WebView or multiple WebViews. You need to switch to the particular WebView where your elements are present. To switch to a particular WebView, you need to install wd and wd-bridge. You can use npm to install those. Once you install wd and wd-bridge. Add the below changes in your config and spec file.
I tried this approach and the error of no such context found was resolved.
Config file :
onPrepare: function () {
wdBridge.initFromProtractor(exports.config);
}
Spec file :
wdBrowser.contexts().then(function (ctxs) {
//console.log(ctxs);      //This will give you list of all webviews in your app.
return wdBrowser.context(ctxs[index]);      //'index' of your required WebView
})

Hi @ssudhanshu ,
I am unable to resolve this by using the above solution, please can you provide the sample config file which you are used?

HI @wswebcreation, my app start with two contexts native and webview. is it possible to automate with the protractor?


[BigFix] keep dround consistent with round

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6393
Problem Summary(Required) ：

Let dround acts the same as round

run starrocks_fe_unittest

[FE PR Coverage check]
:heart_eyes: pass : 5 / 5 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
5
5
100.00%


chore(main): release 3.8.2

:robot: I have created a release beep boop
3.8.2 (2024-08-06)
Bug Fixes

use correct home folder for user (76466fd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/moraroy/NonSteamLaunchers-On-Steam-Deck/releases/tag/v3.8.2 :sunflower: