Error: Cannot find module next/link imported from @flowershow/core/index.js. Did you mean to import next/link.js?

After creating @flowershow/core package and using it as a dependency of the @flowershow/template package, the following error shows up when running E2E tests or creating new Flowershow sites with our CLI:
Uncaught Error: Cannot find module '/home/ola/Projects/lifeitself/my-site/.flowershow/node_modules/next/link' imported from<EMAIL_ADDRESS>Did you mean to import next/link.js?
    at new NodeError (node:internal/errors:387:5)
    at finalizeResolution (node:internal/modules/esm/resolve:330:11)
    at moduleResolve (node:internal/modules/esm/resolve:907:10)
    at defaultResolve (node:internal/modules/esm/resolve:1115:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:837:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
    at link (node:internal/modules/esm/module_job:75:36)

The error doesn't occur when serving the template with pnpm nx serve template though.

@khalilcodes here is the reference page of the rollup executor we're using in the core package: https://nx.dev/packages/web/executors/rollup
Atm it's using a default rollup config returned by this function:
https://github.com/nrwl/nx/blob/master/packages/react/plugins/bundle-rollup.ts
You can also create your own config or extend the default one. This article may help you if you want to do this: https://antonball.medium.com/extending-rollup-configuration-for-nx-a568cec16bf4

Last thing I tried was generating both cjm and esm (https://github.com/flowershow/flowershow/commit/1db5cbbb5f66c6acddfa387861eb575f7b636850) but it didn't have any effect.

Where is next/link getting imported? Is there a temporary workaround eg importing next/link in template?
First step here would be to remove things until this starts working. Then rebuild from a working state.
Btw these issues would show up with eg Pliny so perhaps we could examine how they build to have this work.

Where is next/link getting imported? Is there a temporary workaround eg importing next/link in template?
First step here would be to remove things until this starts working. Then rebuild from a working state.
Btw these issues would show up with eg Pliny so perhaps we could examine how they build to have this work.

I have submitted a question on Stack Overflow: https://stackoverflow.com/questions/74900445/error-cannot-find-module-node-modules-next-link-imported-from-did-you
And I've also asked a question on Next.js's discord channel: https://discord.com/channels/752553802359505017/1055551199807549440/1055551199807549440

Until this is solved I'll revert the version on main to the working version before the monorepo refactor and I'll move what we have on main atm to dev branch.

I faced this issue today trying to run npx flowershow@latest export (or build). Was the rollback pushed to npm or should this issue not be there to begin with?
Environment:

flowershow
OS
Node
npm

latest (@0.1.2)
Windows 10 22H2
v18.12.0
8.19.2

@aabounegm the rollback has been pushed to our main branch (this is where the CLI get's the Flowershow template from) ~ a week ago. Please let me know if it works for you now.

@rufuspollock
I've managed to get past that error by explicitly specifying file extensions in any imports from next/link, next/router, and next/head in the Flowershow core package.
I'm not sure why (I may lack some basic knowledge about module resolution here) but it seems Next can only handle imports without file extensions for import statements used directly in the Next.js project, e.g. in our template, but not when such import statements are used in a dependency of this project.
Originally, with import statements without .js extensions, this was the resulting index.js file of the bundled core package:
...
import 'react/jsx-runtime';
import 'react';
import 'next/link'; <-- no extension; caused the above error
import 'next-themes';
import 'next/dynamic';  <-- no extension; caused the above error
import '@headlessui/react';
import 'next/router';  <-- no extension; caused the above error
import 'next/head';  <-- no extension; caused the above error
import 'mdx-mermaid/lib/Mermaid';
import 'clsx';

After adding file extensions to any imports from next/XXX files, the above file looks like this:
...
import 'react/jsx-runtime';
import 'react';
import 'next/link.js'; <-- no error now
import 'next-themes';
import 'next/dynamic.js';  <-- no error now
import '@headlessui/react';
import 'next/router.js';  <-- no error now
import 'next/head.js';  <-- <-- no error now
import 'mdx-mermaid/lib/Mermaid';
import 'clsx';

What's interesting is that only imports from next package caused these errors. Why? Because all the other packages have exports field specified in their package.json files, e.g. in react's package.json:
  "exports": {
    ".": {
    ...
      "default": "./index.js"
    },
    ...
    "./jsx-runtime": "./jsx-runtime.js",
    ...
  },

... which enables resolving both imports from react (the default export filed) and from react/jsx-runtime.

@rufuspollock this is solved, but now I'm working on this error, but this should be much easier to solve :)

Ok i think this is solved as well.

@olayway Thanks for the response, I indeed noticed the rollback happened after I wrote my comment above. The build is now failing for a different reason, but I think it deserves a separate issue.
Also, you are absolutely right about the module resolution strategy. ESM necessitates the use of file extension (Check Node.js ESM docs), except for packages that define the exports field. In other words, adding .js is not just a workaround, but the right solution.

"we can only import files from next package without using file extensions for import statements used directly in the Next.js project, ..., but not when such import statements are used in a dependency of this project"

I'm not totally sure about the specifics in this case (haven't used Next.js), but it depends on the bundler configuration. Most likely, Next configures Webpack (the default bundler when using the next CLI) to handle CommonJS imports by default, but you would need to explicitly add CommonJS support to your Rollup configuration (using @rollup/plugin-commonjs) when using Next.js as a dependency since it is shipped as a CommonJS module.

@aabounegm thank you so much for your input! I really appreciate it 🤗


Feature: Improve arrow

The arrow is pretty ugly. It's a boring triangle. Looking to replace it with a nicer looking arrow

Could use a new arrow head defiition, @alanhogan? 🙏

arrowhead.svg:
<svg xmlns="http://www.w3.org/2000/svg" width="82" height="77" viewBox="0 0 82 77">
  <polygon fill-rule="evenodd" points="20.5 38.5 2.5 -2.5 79.5 38.5 2.5 79.5" transform="rotate(-90 41 38.5)"/>
</svg>

I think we can still do a little better by making the line in the arrow gradually narrow. So that'll be one more svg 😄

Digging this

<svg xmlns="http://www.w3.org/2000/svg" width="26" height="78" viewBox="0 0 26 78">
  <path fill-rule="evenodd" d="M21,70 L26,0 L0,0 L4.99625706,69.9475988 C4.99745391,69.9650475 4.99870125,69.982511 5,70 C5.37717014,75.0789931 8.581722,78 13,78 C17.418278,78 20.6640625,75.2675781 21,70 Z"/>
</svg>

^ candidate arrow tail. actually it might be tricky as it includes a rounded end which will probably look dumb stretched. hold on

Tail end:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="8" viewBox="0 0 26 8">
  <path fill-rule="evenodd" d="M21,70 L26,0 L0,0 L4.99625706,69.9475988 C4.99745391,69.9650475 4.99870125,69.982511 5,70 C5.37717014,75.0789931 8.581722,78 13,78 C17.418278,78 20.6640625,75.2675781 21,70 Z" transform="translate(0 -70)"/>
</svg>

Tail mid:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="70" viewBox="0 0 26 70">
  <path fill-rule="evenodd" d="M21,70 L26,0 L0,0 L4.99625706,69.9475988 C4.99745391,69.9650475 4.99870125,69.982511 5,70 C5.37717014,75.0789931 8.581722,78 13,78 C17.418278,78 20.6640625,75.2675781 21,70 Z"/>
</svg>

that might be a better approach. Can also easily do a tapering tail with no roundedness at all
i have more ideals so hang on
But what I just gave you looks like this:

But why be straight when you can gently curve? I like this also because the joint between the end and arrow body is essentially purely vertical, which means it should scale to extremes without disjointedness.
Tail mid:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="70" viewBox="0 0 26 70">
  <path fill-rule="evenodd" d="M4.21329638e-14,-2.66453526e-15 L26,-2.66453526e-15 C21,38 21,60 21,70 L5,70 C5,60 5,38 4.21329638e-14,-2.66453526e-15 Z M13,78 C8.581722,78 5,75 5,70 L21,70 C21,75 17.418278,78 13,78 Z"/>
</svg>

Tail end:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="8" viewBox="0 0 26 8">
  <path fill-rule="evenodd" d="M4.21329638e-14,-2.66453526e-15 L26,-2.66453526e-15 C21,38 21,60 21,70 L5,70 C5,60 5,38 4.21329638e-14,-2.66453526e-15 Z M13,78 C8.581722,78 5,75 5,70 L21,70 C21,75 17.418278,78 13,78 Z" transform="translate(0 -70)"/>
</svg>

You can also just use Tail Mid without Tail End. Whichever you/we prefer. I’m not entirely sure how we will feel about the rounded end on the tail.

i am realizing those exports suck as they both include the entire tail shape but just cut it to a different view-box. fixing…

Okay. Here please find proper exports. And the arrowhead has a little less of a gap in the middle, to reduce the chance of a gap showing during reassembly.
Arrowhead:
<svg xmlns="http://www.w3.org/2000/svg" width="82" height="77" viewBox="0 0 82 77">
  <polygon fill-rule="evenodd" points="16.361 29.676 2.5 -2.5 79.5 38.5 2.5 79.5 16.361 48.49" transform="rotate(-90 41 38.5)"/>
</svg>

Tail mid:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="70" viewBox="0 0 26 70">
  <path fill-rule="evenodd" d="M4.21329638e-14,-2.66453526e-15 L26,-2.66453526e-15 C21,38 21,60 21,70 L5,70 C5,60 5,38 4.21329638e-14,-2.66453526e-15 Z"/>
</svg>

Tail end:
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="8" viewBox="0 0 26 8">
  <path fill-rule="evenodd" d="M13,8 C17.418278,8 21,5 21,0 L5,0 C5,5 8.581722,8 13,8 Z"/>
</svg>

(I kept the viewboxes for the tail mid & end the same width so that you can scale them at the same ratio to get perfectly contiguous resulting shapes.)

Let's track any changes to the arrow from here on out in a new issue thread (if there needs to be any adjustments!). I'd say with #68 , this is closed


Plumb build metadata into C++ compilations. [phab:D1371]

Created by zarko at 2017-02-24 18:03:54:
Addresses #1754. Ensure that when it is known, the build target name and rule
type are plumbed down into the compilation units generated by the C++
extractor.  Also, remove the cache-defeating signature hash from the unit.
An attempt to fix the cmake extractor test.

shahms commented inline (context lost during migration) at 2017-02-24 18:09:37:
nit: static is doubly unnecessary here (global const variables are static implicitly as are entities in an anonymous namespace).

shahms accepted this revision at 2017-02-24 18:09:37

zarko wrote at 2017-02-24 18:19:03:
r

zarko wrote at 2017-02-24 18:20:30:

Fix test

zarko wrote at 2017-02-24 18:23:00:

no statics.

zarko closed via commit 062f418a1f81f32b428f7bd0d31e95f88b93ac6e at 2017-02-24 18:23:48


indicator_1-2-1

I don’t think so. In the yml file, that web link is under DATA COMP and
appears in the middle of the file. I’m u sure how to make sure it uploads
properly.
On Tue, Aug 13, 2024 at 3:50 PM Tyler Burton @.***>
wrote:

@.**** commented on this pull request.
In meta/1-2-1.yml
https://github.com/GSA/sdg-data-usa-staging/pull/27#discussion_r1715842516
:

+date_of_national_source_publication: September 2022
+periodicity: Annual
+scheduled_update_by_national_source: ''
+date_metadata_updated: July 2023
+disaggregation_geography: ''
+disaggregation_categories: 'Sex, Age'
+international_and_national_references: ''
+time_period: 2000 - 2022
+scheduled_update_by_SDG_team: ''
+source_organisation_1: ''
+source_agency_staff_name_1: ''
+source_agency_survey_dataset_1: ''
+source_notes_1: ''
+source_title_1: ''
+source_url_1: >

https://www2.census.gov/programs-surveys/cps/tables/time-series/historical-poverty-people/hstpov2.xlsx

is the spacing here correct?
—
Reply to this email directly, view it on GitHub
https://github.com/GSA/sdg-data-usa-staging/pull/27#pullrequestreview-2236439578,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJIVFKV43G46DP6IU7UM2U3ZRJPRXAVCNFSM6AAAAABMO4HBPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZWGQZTSNJXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't see any other examples of DATA_COMP in the repo, and all source_url_1 are single http strings...
See here: https://github.com/GSA/sdg-data-usa-staging/blob/main/meta/13-3-2.md?plain=1#L23
@brockfanning are you aware of what format we want here?
Can we add a new source_url_3 and print each URL individually?

@btylerburton You're right that that field is not going to render as expected there. But feel free to merge this. We can work with the data provider to get it closer to what they want.
@bishopkws I'll follow up about possible approaches afterwards.


Poor throughput (bytes/s) and connection issues on new install Rpi B+ (no issues on older installation)

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[X] The issue I am reporting can be is directly related to the pivpn installer script.
[X] The issue I am reporting isn't a duplicate (see [FAQs]

Poor throughput and connection issues. Not an isp issue (350mb/20mb). Decided to wipe and rebuilt my rpi b+ today after wanting to relocate it and use ethernet instead of wifi. new install of raspian buster, fully updated and having issues with really poor speeds and connection dropouts. CPU utilisation is practically 0 when checking with TOP
Have you searched for similar issues and solutions?
yes, all which mentioned connection issues

Console output of      curl -L install.pivpn.io | bash
pi@raspberrypi:~ $ curl -L https://install.pivpn.io | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   178  100   178    0     0    227      0 --:--:-- --:--:-- --:--:--   227
100 58458  100 58458    0     0  58051      0  0:00:01  0:00:01 --:--:-- 58051
:::
::: sudo will be used for the install.
::: Verifying free disk space...
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: Your system is up to date! Continuing with PiVPN installation...
::: Static IP already configured.
::: Using User: pi
:::
::: Checking for existing base files...
:::    Checking /etc/.pivpn is a repo...:::    Cloning https://github.com/pivpn/                                 pivpn.git into /etc/.pivpn... done!
:::
::: Stopping OpenVPN service... done.
:::
::: Installing scripts to /opt/pivpn... done.
::: Using protocol: udp
set_var EASYRSA_ALGO       ec
set_var EASYRSA_CURVE      prime256v1
::: Building CA...
read EC key
writing EC key
Can't load /etc/openvpn/easy-rsa/pki/.rnd into RNG
3070009360:error:2406F079:random number generator:RAND_load_file:Cannot open fil                                 e:../crypto/rand/randfile.c:98:Filename=/etc/openvpn/easy-rsa/pki/.rnd

::: CA Complete.

Note: using Easy-RSA configuration from: ./vars

Using SSL: openssl OpenSSL 1.1.1c  28 May 2019
Generating an EC private key
writing new private key to '/etc/openvpn/easy-rsa/pki/private/raspberrypi_3868dc                                 9b-b776-4570-be9c-3aa3ae1a4489.key.3lchxSWRy7'
-----
Using configuration from /etc/openvpn/easy-rsa/pki/safessl-easyrsa.cnf
Check that the request matches the signature
Signature ok
The Subject's Distinguished Name is as follows
commonName            :ASN.1 12:'raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a448                                 9'
Certificate is to be certified until Sep  6 21:16:04 2029 GMT (3650 days)

Write out database with 1 new entries
Data Base Updated

Note: using Easy-RSA configuration from: ./vars

Using SSL: openssl OpenSSL 1.1.1c  28 May 2019
Using configuration from /etc/openvpn/easy-rsa/pki/safessl-easyrsa.cnf

An updated CRL has been created.
CRL file: /etc/openvpn/easy-rsa/pki/crl.pem

net.ipv4.ip_forward = 1
run-parts: executing /usr/share/netfilter-persistent/plugins.d/15-ip4tables save
run-parts: executing /usr/share/netfilter-persistent/plugins.d/25-ip6tables save
cp: cannot stat '/tmp/OLD_UFW': No such file or directory
::: Using CloudFlare servers.
sleep 0.1
::: Install Complete...
::: Restarting services...
Synchronizing state of openvpn.service with SysV service script with /lib/system                                 d/systemd-sysv-install.
Executing: /lib/systemd/systemd-sysv-install enable openvpn
::: Flushing writes to disk...
::: done.

Console output of      pivpn add or pivpn add nopass
pi@raspberrypi:~ $ pivpn debug
::: Generating Debug Output
::::            PiVPN debug              ::::
=============================================
::::            Latest commit            ::::
commit d0c10db6ec391961b7201fb564055c1176ca73e3
Author: 4s3ti<EMAIL_ADDRESS>Date:   Tue Sep 3 10:09:48 2019 +0200

    install.sh: apt-get with , uninstall.sh: added var PKG_MANAGER and replaced apt-get with
=============================================
::::        Installation settings        ::::
/etc/pivpn/DET_PLATFORM -> Raspbian
/etc/pivpn/FORWARD_CHAIN_EDITED -> 0
/etc/pivpn/HELP_SHOWN ->
/etc/pivpn/INPUT_CHAIN_EDITED -> 0
/etc/pivpn/INSTALL_PORT -> 1194
/etc/pivpn/INSTALL_PROTO -> udp
/etc/pivpn/INSTALL_USER -> pi
/etc/pivpn/NO_UFW -> 1
/etc/pivpn/pivpnINTERFACE -> eth0
/etc/pivpn/TWO_POINT_FOUR ->
=============================================
::::    setupVars file shown below       ::::
INSTALL_USER=pi
UNATTUPG=unattended-upgrades
pivpnInterface=eth0
IPv4dns=
IPv4addr=<IP_ADDRESS>
IPv4gw=<IP_ADDRESS>
pivpnProto=udp
PORT=1194
ENCRYPT=256
APPLY_TWO_POINT_FOUR=true
DOWNLOAD_DH_PARAM=false
PUBLICDNS=REMOTE
OVPNDNS1=<IP_ADDRESS>
OVPNDNS2=<IP_ADDRESS>
=============================================
::::  Server configuration shown below   ::::
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a4489.crt
key /etc/openvpn/easy-rsa/pki/private/raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a4489.key
dh none
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
# Set your primary domain name server address for clients
push "dhcp-option DNS <IP_ADDRESS>"
push "dhcp-option DNS <IP_ADDRESS>"
# Prevent DNS leaks on Windows
push "block-outside-dns"
# Override the Client default gateway by using <IP_ADDRESS>/1 and
# <IP_ADDRESS>/1 rather than <IP_ADDRESS>/0. This has the benefit of
# overriding but not wiping out the original default gateway.
push "redirect-gateway def1"
client-to-client
keepalive 1800 3600
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user nobody
group nogroup
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 3
#DuplicateCNs allow access control on a less-granular, per user basis.
#Remove # if you will manage access by user instead of device.
#duplicate-cn
# Generated for use by PiVPN.io
=============================================
::::  Client template file shown below   ::::
client
dev tun
proto udp
remote REMOTE 1194
resolv-retry infinite
nobind
persist-key
persist-tun
remote-cert-tls server
tls-version-min 1.2
verify-x509-name raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a4489 name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3
=============================================
::::    Recursive list of files in       ::::
::: /etc/openvpn/easy-rsa/pki shows below :::
/etc/openvpn/easy-rsa/pki/:
alex-android.ovpn
ca.crt
crl.pem
Default.txt
ecparams
extensions.temp
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
openssl-easyrsa.cnf
private
renewed
revoked
safessl-easyrsa.cnf
serial
serial.old
ta.key

/etc/openvpn/easy-rsa/pki/ecparams:
prime256v1.pem

/etc/openvpn/easy-rsa/pki/issued:
XXXX-android.crt
raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a4489.crt

/etc/openvpn/easy-rsa/pki/private:
alex-android.key
ca.key
raspberrypi_3868dc9b-b776-4570-be9c-3aa3ae1a4489.key

/etc/openvpn/easy-rsa/pki/renewed:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/renewed/private_by_serial:

/etc/openvpn/easy-rsa/pki/renewed/reqs_by_serial:

/etc/openvpn/easy-rsa/pki/revoked:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/revoked/private_by_serial:

/etc/openvpn/easy-rsa/pki/revoked/reqs_by_serial:
=============================================
::::            Self check               ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] OpenVPN is running
:: [OK] OpenVPN is enabled (it will automatically start on reboot)
:: [OK] OpenVPN is listening on port 1194/udp
=============================================
::::      Snippet of the server log      ::::
Sep  9 22:26:37 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:26:37 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:56720
Sep  9 22:26:38 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:26:38 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:56720
Sep  9 22:26:39 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:26:39 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:56720
Sep  9 22:26:40 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:26:40 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:56720
Sep  9 22:26:44 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:26:44 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:63510
Sep  9 22:27:14 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:27:14 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:50589
Sep  9 22:29:14 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:29:14 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:59641
Sep  9 22:29:15 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:29:15 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:59641
Sep  9 22:29:16 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:29:16 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:59641
Sep  9 22:30:17 raspberrypi ovpn-server[315]: tls-crypt unwrap error: packet authentication failed
Sep  9 22:30:17 raspberrypi ovpn-server[315]: TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:55989
=============================================
::::            Debug complete           ::::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.txt

Console output of      pivpn debug
  Output Here

Was a fresh install of raspian buster today. uninstalled pivpn, rebooted and reinstalled with further issues. tried android and ios devices, same poor throughput and above errors.
  which?

16days no comms, closing.
@marshalexander99 feel free to reopen if you still need assistance


Import failure

I am trying to run the following import on my Kaggle notebook, but I am getting the following error.
import selfeeg
import selfeeg.augmentation as aug
import selfeeg.dataloading as dl

Traceback (most recent call last):

  File /opt/conda/lib/python3.10/site-packages/IPython/core/interactiveshell.py:3553 in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  Cell In[3], line 9
    import selfeeg

  File /opt/conda/lib/python3.10/site-packages/selfeeg/__init__.py:2
    from . import dataloading

  File /opt/conda/lib/python3.10/site-packages/selfeeg/dataloading/__init__.py:1
    from .load import (GetEEGPartitionNumber, GetEEGSplitTable, GetEEGSplitTableKfold,

  File /opt/conda/lib/python3.10/site-packages/selfeeg/dataloading/load.py:1550
    sample=self.currEEG[*first_dims_idx,:,-self.Nsample:]
                        ^
SyntaxError: invalid syntax

I don't know but I think this is an issue regarding the package code base.

Hi, @adejumoridwan.
The issue you are encountering is related to a syntax I used to get a specific partition from 3D (or higher dimensional) tensors, which was added only in Python 3.11 (my fault, I forgot that colab and kaggle still run Python 3.10, sorry). The issue was solved during the JOSS Journal peer-review with the following PR https://github.com/MedMaxLab/selfEEG/pull/4 .
Unfortunately, I'm waiting the Journal's review to be done before uploading a new version with this and other corrections on PyPI and Anaconda. There's only one reviewer left, so I believe it won't take much time. Until then, can you try to install directly from git with the command and see if you are still encountering the error?
!pip install git+https://github.com/MedMaxLab/selfEEG

Just to double check, If you run
import selfeeg.dataloading as dl
dl.EEGDataset.__getitem__??

You can check if the line of interest has the correction
sample = self.currEEG[(*first_dims_idx, slice(None), slice(start, end))]

Let me know if this solves your problem

Hi @fedepup, thanks for your help. It works.


mistaken spelling.

At line of 105 in the file misc/lv_area.c，there is a mistaken spelling 'her'. Actually，it needs to be 'here'.

Hi,
because this issue is opened, I want to add just other misspelling. in the same file (misc/lv_area.c) should be function:
bool lv_area_union(lv_area_t * res_p, const lv_area_t * a1_p, const lv_area_t * a2_p)
    /* Get the smaller area from 'a1_p' and 'a2_p' */
    res_p->x1 = LV_MATH_MAX(a1_p->x1, a2_p->x1);
    res_p->y1 = LV_MATH_MAX(a1_p->y1, a2_p->y1);
    res_p->x2 = LV_MATH_MIN(a1_p->x2, a2_p->x2);
    res_p->y2 = LV_MATH_MIN(a1_p->y2, a2_p->y2);

    /*If x1 or y1 greater then x2 or y2 then the areas union is empty*/
    bool union_ok = true;
    if((res_p->x1 > res_p->x2) ||
       (res_p->y1 > res_p->y2))
    {
        union_ok = false;
    }

    return union_ok;
}

renamed to lv_area_intersection?

Hi,
@yuanzhaoming  I fixed it in the beta branch. Please, keep reporting these typos or create pull requests to the beta branch.
@BesitzeRuf lv_area_union? How did I think that? It seems I had problems with the definitions... Alaso fixed in beta.
Thank you, guys!

Hi,
I have been reading your code these days，your code enlightened me.
In the file (lv_misc/lv_task.c) of beta version,I think there is a misspelling variable 'task_interruper'.
Should it be 'task_interrupter'?

Thank you, fixed!

As there wasn't activity here for a while I close this issue.
If you find new typos, please reopen this issue!


Add the privacy policy to the menu

Fixes

Fixes #650 by @zackkrida
Description

Adds a link to WP.org's privacy policy to the menu.
Testing Instructions

Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida did you mean to remove openverse.pot?

Fixed, thanks @sarayourfriend! I conflated it with the various .json files we don't want to track.

Can we set a min-width for the menu popover? It looks too narrow.

A 200px width like the mockup in Views page looks good to me.

@panchovm sure, I made a PR for that here: https://github.com/WordPress/openverse-frontend/pull/658


Bug 35308671 JCS-13865

Address issue where default CIDR range of /24 was causing false validation errors.

Address issue where default CIDR range of /24 was causing false validation errors.


AttributeError: 'AutoModelForCausalLMWithValueHead' object has no attribute 'get_parameter'

run example.py get this error and python==3.8.15 transformers==4.20.1

hey @zi0wu
Can you share with us the script you are using?
Also, anything blocking on your side to not use transformers>=4.26 ?

I solved this problem with the latest transformer. Thanks

Thanks a lot!


typeof player.socialID doesn't return a bigint, but a number

alt.log(typeof player.socialID)

Returns a number, when it should return a bigint

Fixed in https://github.com/altmp/altv-js-module-v2/commit/b79807b10e481de1ab1066138e8a3ea5d14e7dd3 - will be available with next NPM release

Fixed in b79807b - will be available with next NPM version

@xLuxy In case the information is useful, I saw that you had also changed the type of hwidHash, but typeof hwidHash did return bigint!

Fixed @FlorianV85, kinda feel like it should be number | bigint because sometimes it might be numeric i think.


Handle pre-<IP_ADDRESS> missing metadata

Fixes #411
Handled missing metadata in pipx upgrade, pipx upgrade-all and pipx list, which were the only cases I could find that could fail with stack trace error upon empty venv.package_metadata.
Warning message for upgrade of package with missing metadata:

Warning message for package with missing metadata during list:

Oops, let me add a changelog entry...

Changelog looks good


IMPROVE: Dropdowns double icons

To have a nicer UI please remove the currently selected Chain/Token from the dropdown to not have it displayed twice.

This is not needed if #604 is implemented

Closing , dropdown has been changed to a separate screen


Optimize SwissTournament.sol storage structs

Optimize the main storage structs of SwissTournament.sol to increase efficiency. Decreases the playNextMatch function from 132882 to 72747 gas. Theres still room for more optimization within the mappings and such but these were just the easiest ones I saw. This limits the some of the vars to uint64 or uint16 but thats still way more numbers that you'd ever need in practice. LMK whatchu think

slicc work @0xFloop!
Can you also commit changes for .gas-report.txt with:
forge clean && forge test --gas-report > .gas-report.txt

Initially I also thought about reducing storage sizes around playerIds, but figured uint256 might play nicer with hashing an address into a uint256 playerId. Honestly max uint64 (1.8e19) should be large enough to avoid collisions, so integrators might be able to get away with generating playerIds with
uint64 playerId = uint64(
      uint256(keccak256(abi.encodePacked(address(0xdeadbeef))))
);

or integrators can just manage a monotonic id heh


Update xml dependency to 6.0.1

It would be nice if we could update the xml dependency to 6.0.1.
Is there a reason not to do it?
I would love to contribute and create a PR for this.

merged

Did you also publish a new version to pub?

yes, version 2.2.0 - https://pub.dev/packages/gpx


include coil info parameter

we need to add coil info parameter(s) for protocol compliance checks.
Getting info on this is not easy and varies across vendors unfortunately (see here), but for siemens, it seems to be at 0x0051, 0x100F, so it should be easy for us to add.

some example codes/variations for coil string:
32 ch: HEA; HEP
64 ch: HC1-7; HC1-7; NC1,2
20 ch: HE1-4
relevant BIDS meta data tag: ReceiveCoilActiveElements

Added DICOM tag in config file

looks like we need to properly decode the coil string in dicom header, and implement the equality condition in a more detailed manner (beyond simple string match)
it would be ideal to make it work for all body organs, not just brain:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6175221/table/jmri26187-tbl-0001/?report=objectonly


Template or render function not defined.

I installed the component as described in the doc
and used it this way inside a component:
import VueDateTimePicker from 'vue-datetime-picker'

export default {
    name: "interaction-details",
    components: {
        VueDateTimePicker
    }
}

HTML:
<vue-date-time-picker/>
But I am getting an error "Template or render function not defined"
I tried using the component at global level as well but still the same error.
Can someone help me if I am doing something wrong here?

I have the same problem.

Me too.

Mee too :(

Getting the same error here.

me too

I think this library is not for vue 2.*.

Anybody resolved this issue?

As AkilLis mentioned, this component doesn't seem to work with Vue.js 2.x and it also seems as it is not supported by the developer anymore. I am using "vue-bootstrap-datetimepicker" (https://github.com/ankurk91/vue-bootstrap-datetimepicker) instead. Works perfectly fine for me :)


Summary Bug Fixes

#1497
Changelog:

Fixed the issue with the assertions not recognizing that all checkboxes were checked when signing a compliance report or exclusion report
Fixed summary page not loading Line 28 after switching

 Compliance Report | Summary page fixes and optimization |5|

Please refer to #1500

 Compliance Report | Summary page fixes and optimization |5|


Added Logo for the website

Added a suitable logo for the website  that corresponds to diabetes prediction app.

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@BamaCharanChhandogi  kindly review the PR

@BamaCharanChhandogi  ok I respect ur decision but if u want i can replace it with the below logo as it is already present in your website but in the footer section.

so please tell

You can add this logo. And can you change the site name?
❇ You can add PreDiaBet and remove Diabetes Prediction App.

@BamaCharanChhandogi
Updated the changes as per ur request . Kindly review it once and let me know

I forgot to mention, can you revert the package.json file? I think you changed it by mistake.


MWPW-136317 Enable dropZone for all verbs

Resolves
https://jira.corp.adobe.com/browse/MWPW-136317
Enabling Dropzone for all verbs to get the feedback. DO NOT MERGE.
Before:
https://stage--dc--adobecom.hlx.live/acrobat/online/pdf-to-word
After:
https://mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/pdf-to-word

Codecov Report

Merging #377 (4d62dcb) into stage (e73513d) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##            stage     #377      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.01%
==========================================
  Files          25       25
  Lines        2927     2925       -2
==========================================
- Hits         2731     2729       -2
  Misses        196      196

Files Changed
Coverage Δ

.../blocks/dc-converter-widget/dc-converter-widget.js
76.79% <84.21%> (-0.12%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closing this PR. Opened a new PR with new requirement/updates.


Return the correct auxiliary values for top/bottom

When top() or bottom() were used and selected auxiliary values, they
would return the wrong values that would be equal to the last point
selected. This is because the aggregators saved the memory address of
the auxiliary fields instead of copying them over. Since the same
auxiliary fields memory location is used for every value returned by the
storage engine, this resulted in the values being incorrect because they
were overwritten with incorrect values.
This fixes that so the auxiliary fields are copied out when they are
saved rather than only the memory location.
Fixes #9197.

During a run of megacheck the following issues were discovered:

During a run of megacheck the following issues were discovered:

Maybe that explains why megacheck has been failing. Fixed.

During a run of megacheck the following issues were discovered:


Fixing some bugs

Fixes the common "write after end" bug which was caused due to a race condition, and error with getting per cpu usage.

Can you update the change log as well?


Application Enhancement Request - Item Attributes

Hello,
It would be very useful if you could extend current option filed Type for item attributes with new value - Date.
Current choices are:

We have that on 2 places: "Item Attributes".Type and "Item Attribute Value Selection"."Attribute Type".
Date option is particularly important and useful for all HR related master tables.
Also, is it possible to remove word Item from text constants, or replace it with placeholder?
We have it in 4 tables:
Item Attribute:

Item Attribute Value:

Item Attribute Value Selection:

Filter Item Attributes Buffer:

These changes would make Item Attributes extendable for all other master tables.
Thanks,
Radovan

Thank you for opening this issue! I have forwarded the request to the application team.

Hi,
Is this request accepted by application team, and if yes, when we can expect it?

Hi @atoader ,
Any new on this?
Thanks,
Radovan


corrected case of independent dimension

support of larger than one independent dimension
Signed-off-by: Tobias Cord-Landwehr<EMAIL_ADDRESS>

Great contribution. Can you add/ change a test case which verifies that your solution is indeed correct?

The modified test now avoids the case with an independent dimension size of one. The previous version only allowed this independent dimension size due to fixed dimensions in the gaussian distribution.

Ok. Perfect. Thank you for your contribution.


Calling getByUsernameOrLastName throws org.grails.orm.hibernate.exceptions.GrailsQueryException: Invalid query

When calling the method getByUsernameOrLastName, the method thows GrailsQueryException because the query starts with a space
 StringBuilder hql = new StringBuilder(" FROM User user WHERE user.enabled = true AND (user.username LIKE :username ")
                .append(" OR user.person.lastName LIKE :lastName) ")

I suppose it's a GORM 5.x bug but it's important to resolve

The Gorm issue was https://github.com/grails/grails-data-mapping/issues/645


Fix param names in documentation

Hi,
Great library, I've just started using it in a project with great results.
As I was reading the documentation I saw a couple of param names in the docs did not match those in the code so this just updates the documentation in a few places.
Hopefully any wording changes I've made describe the intention OK.

Hmm, merged this, but just realized that one of the changes you made is incorrect. it refers to permitted_attributes_for_{action}, and not action. So defining, e.g. permitted_attributes_for_update would make that method be called rather than permitted_attributes.

Yes, good point - should be something like "if the method is defined".

Would you like me to create a new PR to change that line? I could also do any other docs changes you had in mind.


Move project config to pyproject.toml

Requirements split into main, desktop and tests
All project configuration moved from setup.py to pyproject.toml

It has consequences for my fastpypi package -> I will try to incorporate it so it is compatible with my releases


Accept Red cluster does not work in ves5.1.1-15

Ran sgadmin with -arc option, but this version was unable to parse the flag. Got below error:
Search Guard Admin v5
ERR: Parsing failed.  Reason: Unrecognized option: -arc
usage: sgadmin.sh [-cd ] [-cn ] [-dci] [-dg]
[-dra] [-ec ] [-ep ] [-era] [-esa] [-f ]
[-ff] [-h ] [-i ] [-icl] -ks  [-ksalias
] [-kspass ] [-kst ] [-nhnv] [-nrhn] [-p
] [-r] [-rl] [-sniff] [-t ] -ts  [-tsalias
] [-tspass ] [-tst ] [-us ]
The changelog suggests that this flag is supported since v14.
Debugging:
Checked the code in the branches. Branch 5.1.1 has -arc option in com.floragunn.searchguard.tools.SearchGuardAdmin.java while branch es-5.1.1 branch is missing this option.

Right, we need to improve the docs and possibly versioning here. According to our EOL policy, v14 was not available for 5.1.1. v15, however, was a security release and was thus released for all versions. Will introduce a better semantic versioning.

Sorry, just to clarify, will -arc flag be included for Elasticsearch v5.1.1?

no, you need to upgrade to 5.3.3 or later. Pls. refer to our EOL Policy https://github.com/floragunncom/search-guard-docs/blob/master/eol.md


Updated final pester output and PesterConfiguration Object

Final Pester result was showing blank because of attribute name change from Pester4 to 5. Fixed it.
Changed the way Pester Configuration object is created. All values now lie in single hashtable which looks cleaner and easy to troubleshoot. Lesser code and slightly more readable.

:white_check_mark: Build MarkdownPS 1.0.27 completed (commit https://github.com/Sarafian/MarkdownPS/commit/7229d0988b by @belibug)

AppVeyor workflow is broken, it failed, but it still marked build as complete.

:white_check_mark: Build MarkdownPS 1.0.28 completed (commit https://github.com/Sarafian/MarkdownPS/commit/51e8d5a7b7 by @belibug)

Don't agree with the proposed changes. Most of it just spaces and formatting but it's fine.
Looking at the New-PesterConfiguration doc, there are two examples.
I prefer the pre-existing one (example 1) because the object is typed and then during edit it is easier. Maybe it's my background from strong typed languages that makes me biased, but anything the IDE can you for you is always appreciated and prefered. I also don't see but again, it's a matter of perspective.

All values now lie in single hashtable which looks cleaner and easy to troubleshoot. Lesser code and slightly more readable.

Anyhow, I will reject these changes mostly because of opinion because functionally there is no difference.
You mentioned that something about a tag but I don't get it to be honest. Was there an issue already? Maybe there is something here to get.

Okay, I understand. On its own it doesnt add value, so its fine to keep it as is.
The bug about not showing final value,
The last section of code , The correct properties are as below
 ## Emphasis on "CommandsAnalyzedCount"
        Expression = { $_.CodeCoverage.CommandsAnalyzedCount }
    }, @{
        Name       = 'FilesAnalyzed'
        Expression = { $_.CodeCoverage.FilesAnalyzedCount }
    }, @{
        Name       = 'CommandsExecuted'
        Expression = { $_.CodeCoverage.CommandsAnalyzedCount }
    }, @{
        Name       = 'CommandsMissed'
        Expression = { $_.CodeCoverage.CommandsMissedCount }
    }

The old properties which are not valid anymore
    $pesterResult|Select-Object @{
        Name="CommandsAnalyzed"
        Expression={$_.CodeCoverage.NumberOfCommandsAnalyzed}
    },@{
        Name="FilesAnalyzed"
        Expression={$_.CodeCoverage.NumberOfFilesAnalyzed}
    },@{
        Name="CommandsExecuted"
        Expression={$_.CodeCoverage.NumberOfCommandsExecuted}
    },@{
        Name="CommandsMissed"
        Expression={$_.CodeCoverage.NumberOfCommandsMissed}
    }

I can do the pull request and submit new code you can correct it on your end. Let me know.

I did an export
PS /workspaces/MarkdownPS> $result

Containers            : {[+] /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCharacterStyle.Tests.ps1, [+] /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCode.Tests.ps1, [+] /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDHeader.Tests.ps1, [+] /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDImage.Tests.ps1…}
Result                : Passed
FailedCount           : 0
FailedBlocksCount     : 0
FailedContainersCount : 0
PassedCount           : 85
SkippedCount          : 0
NotRunCount           : 0
TotalCount            : 85
Duration              : 00:00:02.3384645
Executed              : True
ExecutedAt            : 5/31/2024 3:20:13 PM
Version               : 5.5.0
PSVersion             : 7.2.19
PSBoundParameters     : {[Configuration, PesterConfiguration]}
Plugins               :
PluginConfiguration   :
PluginData            :
Configuration         : PesterConfiguration
DiscoveryDuration     : 00:00:00.0528029
UserDuration          : 00:00:01.3186756
FrameworkDuration     : 00:00:00.9669860
Failed                : {}
FailedBlocks          : {}
FailedContainers      : {}
Passed                : {[+] -Style Bold, [+] -Style Italic, [+] -Style StrikeThrough, [+] -Style out of range…}
Skipped               : {}
NotRun                : {}
Tests                 : {[+] -Style Bold, [+] -Style Italic, [+] -Style StrikeThrough, [+] -Style out of range…}
CodeCoverage          : 92.09% / 75%

PS /workspaces/MarkdownPS> $result.CodeCoverage

CoveragePercent       : 92.090395480226
CoveragePercentTarget : 75
CoverageReport        : Covered 92.09% / 75%. 177 analyzed Commands in 13 Files.
                         Missed commands:

                        File                                      Class Function               Line Command
                        ----                                      ----- --------               ---- -------
                        Modules/Import-MarkdownPS.ps1                                             1 Import-Module "$PSScriptRoot\MarkdownPS\MarkdownPS.psm1" -Force
                        Modules/MarkdownPS/MarkdownPS.psm1                                       23 $public  = @( Get-ChildItem -Path $PSScriptRoot\Public\*.ps1 -Exclude @("*.Tests.ps1"))
                        Modules/MarkdownPS/MarkdownPS.psm1                                       23 Get-ChildItem -Path $PSScriptRoot\Public\*.ps1 -Exclude @("*.Tests.ps1")
                        Modules/MarkdownPS/MarkdownPS.psm1                                       23 "*.Tests.ps1"
                        Modules/MarkdownPS/MarkdownPS.psm1                                       25 $private=@()
                        Modules/MarkdownPS/MarkdownPS.psm1                                       27 @($public + $private)
                        Modules/MarkdownPS/MarkdownPS.psm1                                       27 $public + $private
                        Modules/MarkdownPS/MarkdownPS.psm1                                       29 . $import.FullName
                        Modules/MarkdownPS/MarkdownPS.psm1                                       32 Export-ModuleMember -Function $public.BaseName
                        Modules/MarkdownPS/Public/New-MDCode.ps1        New-MDCode               72 $i++
                        Modules/MarkdownPS/Public/New-MDCode.ps1        New-MDCode               74 $prefix+=">"
                        Modules/MarkdownPS/Public/New-MDImage.ps1       New-MDImage             139 $Source+="?style=$Style"
                        Tests/Cmdlets-Helpers/Get-RandomValue.ps1       global:Get-RandomValue   18 10000 + (Get-Random -Maximum 100)
                        Tests/Cmdlets-Helpers/Get-RandomValue.ps1       global:Get-RandomValue   18 Get-Random -Maximum 100

CommandsAnalyzedCount : 177
CommandsExecutedCount : 163
CommandsMissedCount   : 14
FilesAnalyzedCount    : 13
CommandsMissed<EMAIL_ADDRESS>Line=1; StartLine=1; EndLine=1; StartColumn=1; EndColumn=64; Class=; Function=; Command=Import-Module "$PSScriptRoot\MarkdownPS\MarkdownPS.psm1" -Force; HitCount=0}, @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/MarkdownPS.psm1; Line=23; StartLine=23; EndLine=23; StartColumn=12; EndColumn=88; Class=; Function=;
                        Command=$public  = @( Get-ChildItem -Path $PSScriptRoot\Public\*.ps1 -Exclude @("*.Tests.ps1")); HitCount=0}, @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/MarkdownPS.psm1; Line=23; StartLine=23; EndLine=23; StartColumn=15; EndColumn=87; Class=; Function=; Command=Get-ChildItem -Path $PSScriptRoot\Public\*.ps1 -Exclude @("*.Tests.ps1"); HitCount=0},
                        @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/MarkdownPS.psm1; Line=23; StartLine=23; EndLine=23; StartColumn=73; EndColumn=86; Class=; Function=; Command="*.Tests.ps1"; HitCount=0}…}
CommandsExecuted<EMAIL_ADDRESS>Line=64; StartLine=64; EndLine=64; StartColumn=17; EndColumn=23; Class=; Function=New-MDCharacterStyle; Command=$Style; HitCount=1}, @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCharacterStyle.ps1; Line=66; StartLine=66; EndLine=66; StartColumn=31; EndColumn=35; Class=;
                        Function=New-MDCharacterStyle; Command=$surround="**"; HitCount=1}, @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCharacterStyle.ps1; Line=67; StartLine=67; EndLine=67; StartColumn=33; EndColumn=36; Class=; Function=New-MDCharacterStyle; Command=$surround="*"; HitCount=1}, @{File=/workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCharacterStyle.ps1; Line=68;
                        StartLine=68; EndLine=68; StartColumn=40; EndColumn=44; Class=; Function=New-MDCharacterStyle; Command=$surround="~~"; HitCount=1}…}
FilesAnalyzed         : {/workspaces/MarkdownPS/Src/Modules/Import-MarkdownPS.ps1, /workspaces/MarkdownPS/Src/Modules/MarkdownPS/MarkdownPS.psm1, /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCharacterStyle.ps1, /workspaces/MarkdownPS/Src/Modules/MarkdownPS/Public/New-MDCode.ps1…}

Something have changed. Kind of my point about preference to typed code.
The CodeCoverage is currently not triggered so even if we fix this only the console output will be. But now that the codecoverage is stable, I want to look into this from the template repository and explore what might be possible with appveyor on this topic.
I'll leave this issue for the export of the structure for convienience
Please don't waste time on this.


Update MySQL and JDBC query BBEs with the latest Query API update.

Description:
$subject.
related issue: #1445

@lahirusamith please check


Spinning Circle (Will not load Certain Artist)

When I click on Chase & Status (Artist) it loads the artist and shows their songs etc. .If I back out (go to Listen Now) and click Chase & Status again all I get is a spinning circle. I noticed that it only happens to this Artist. It will not work again unless I quit the app and re launch and then the same occurrence again and again.

That sounds like a Google Play Music bug, can you check if the same thing happens in a browser

Yeah your right. Sorry completely forgot to check the browser (that's how good your app is :P) .

No problem, maybe try raising it with Google support, they might be interested :)


Fix: Unsubscribe Button: Not Margined

So I saw this issue with Unsubscribe buttons in the stream settings where the sidebar was overlapping the buttons.

Fixed this issue here: #26834
In-progress PR: #26835
CZO discussion

i want  to work on this issue

@zulipbot claim

Closing as fixed in #27128.

Reopening as https://github.com/zulip/zulip/pull/27128 got rid of the outer scrollbar, on the inner one, which still overlaps the buttons.

@zulipbot claim

opened a pr #27893, that fixes this issue #26835, which is marked for review, thus abandoning this issue.
@zulipbot abandon

@zulipbot claim

@zulipbot abandon


Update to Python3

Update to Python3, fix various bugs and honor ssl_verify variable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Russell Myers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix some missed code in merge

Fix some missed code caused by merge issue

How is this different from https://github.com/linkedin/feathr/pull/600?

Thanks @YihuiGuo ! I've verified the fix on my end.


Tooltip position is outside of the map area

I  am trying to show tooltip on click or touch event within map area of the image.
The tooltip appears outside of the image. Below the sample I am using.

<map name="planetmap">
  <area shape="rect" coords="0,0,82,126" >
  <area shape="circle" coords="90,58,3" >
    <area shape="circle" coords="124,58,8" >
</map>

That's not how you write an image map. Please fix your html and tell me if your issue still occurs.

You can see how it's done in our demo http://iamceege.github.io/tooltipster/demo/

Sorry, it was our mistake. After I have looked at your js code I realize that you handle already the map areas. So, I fixed the issue this way and it works perfectly by removing the span.

<map name="planetmap">
 <area class="tooltip" title="Rectangle" shape="rect" coords="0,0,82,126">
  <area class="tooltip" title="Circle Mercury" shape="circle" coords="90,58,3">
 <area class="tooltip" title="Circle Venus" shape="circle" coords="124,58,8">
</map>

No problem. FYI, self-closing tags like area should be written like this: <area ... />.


feat(jsvalue) Add JsValue.ptr to retrieve internal idx value

I'm trying to solve https://github.com/rustwasm/wasm-bindgen/issues/2231, and the first immediate step is to make JsValue.idx visible to the world. There is nothing particularly dangerous to allow that.

Personally I have always wanted to avoid this in wasm-bindgen if possible. This is a low-level implementation detail which is extremely hard to get right.
That being said it's been a long time since I originally felt that. I don't really mind that much any more, although I continue to feel that using this is highly likely to get yourself shot in the foot.
If this is added, though, then I think it should be done "officially". For example if there's a getter there should also be a constructor. There should ideally be more than a sentence of documentation about what the index is and how to use it. Additionally I think it would be good to mention this in the book about perhaps the design rationale behind the indices and how things work today.

Closing in favor of #3088.


Unimplemented component:

Description
After enabling the new Architecture for my React Native App, the Modal shows following message inside the component

n
Version
0.68.0
Output of npx react-native info
System:
OS: macOS 12.3.1
CPU: (8) arm64 Apple M1
Memory: 427.50 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 17.8.0 - /opt/homebrew/bin/node
Yarn: 1.22.17 - /opt/homebrew/bin/yarn
npm: 8.5.5 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK:
API Levels: 28, 29, 30, 31, 32
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 32.0.0, 32.1.0
System Images: android-31 | Google APIs ARM 64 v8a, android-31 | Google Play ARM 64 v8a, android-32 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8193401
Xcode: 13.3/13E113 - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.68.0 => 0.68.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
We can see the message by simply importing Modal from react-native.
Snack, code example, screenshot, or link to a repository
No response

I am getting this message on iOS but not on android.
@cortinico , can you please telll what might be the issue?
I also upgraded to React Native 0.68.1

I facing the same issue dude: https://github.com/facebook/react-native/issues/33668
Hope someone can help. After the 0.68.1 launching, the support/engagement disappeared.

Hi @nikhil-kumar-160, thanks for raising the issue.
The component you are trying to use has not been migrated to Fabric. Therefore, it's not compatible with the New Architecture.
Could you prepare a small repo with a reproducer and share it with us?

👁

Okay @cipolleschi, I'll try to update a repo link for the same.

@cipolleschi, One More Thing, It works perfectly on android. The issue is only on iOS

any updates?

I recently tried RN 0.69.1 and the issue still persists

hi @nikhil-kumar-160, I found a temporary solution, hope it helps you.

find "RCTFabricComponentsPlugins.h" in react native, and add this code
Class<RCTComponentViewProtocol> RCTModalHostViewCls(void) __attribute__((used));

find "RCTFabricComponentsPlugins.mm", and add this code
{"ModalHostView", RCTModalHostViewCls}
to the end of sFabricComponentsClassMap

Class<RCTComponentViewProtocol> RCTFabricComponentsProvider(const char *name) {
  static std::unordered_map<std::string, Class (*)(void)> sFabricComponentsClassMap = {
    {"SafeAreaView", RCTSafeAreaViewCls},
    {"ScrollView", RCTScrollViewCls},
    {"PullToRefreshView", RCTPullToRefreshViewCls},
    {"ActivityIndicatorView", RCTActivityIndicatorViewCls},
    {"Slider", RCTSliderCls},
    {"Switch", RCTSwitchCls},
    {"UnimplementedNativeView", RCTUnimplementedNativeViewCls},
    {"Paragraph", RCTParagraphCls},
    {"TextInput", RCTTextInputCls},
    {"InputAccessoryView", RCTInputAccessoryCls},
    {"View", RCTViewCls},
    {"Image", RCTImageCls},
    {"ModalHostView", RCTModalHostViewCls},
  };

  auto p = sFabricComponentsClassMap.find(name);
  if (p != sFabricComponentsClassMap.end()) {
    auto classFunc = p->second;
    return classFunc();
  }
  return RCTThirdPartyFabricComponentsProvider(name);
}

this will enable ModalHostView for Fabric

hi @nikhil-kumar-160, I found a temporary solution, hope it helps you.

Thanks so much Milker.  This temporary fix works great, and I'm wondering how you figured it out?  I'm updating an app that has several "Unimplemented Components" and I'm wondering if I may be able to use this approach for any other quick-fixes.

@EvilGeniusTechnologies There are other "Unimplemented Components" you mentioned, which I encountered as well, it seems that many libraries don't support Fabric yet, so it will take time.
The above solution is a special case, because Modal is a built-in component of ReactNative, and ReactNative implements Fabric for it, but I don’t know why it is not used, and there may be some problems, so the above solution is only temporary.
At present, in most cases, the problem is that there is no component that does not implement Fabric. If you want to solve it in advance, you need to refer to the official documentation to implement Fabric for the component.

Hey guys, wondering if this has been released already ?
The issue still happens on RN 0.70.4 on iOS with the new architecture on a bare bones project.
Pushed a reproductible demo here https://github.com/Clonescody/rn-modal-error-new-arch

same issue here!

@imWildCat @Clonescody, thanks for reporting this.
The PR has been included in 0.71, which we are about to release in the next few weeks. After 0.71 release, the error should be gone.

@imWildCat @Clonescody, thanks for reporting this. The PR has been included in 0.71, which we are about to release in the next few weeks. After 0.71 release, the error should be gone.

Is this PR in the RC3 or RC4 versions? I'm still seeing this error on both.


one hammer trigger another hammer

when i use react-hammerjs to build a single page web application, I found that when I wrote Hammer with props 'onTap' and and another Hammer  behind. The second Hammer tirggered when I clicked the first Hammer , How can I prevent it, Thanks for every advice.

And they are not parent and son. totally different part. Just shown by different condition, so i think it's not about bubble up

Besides, component A with Hammer, component B Input with onFocus behind would be activated by tap top Hammer component.

How do you use it?  I created multiple instances. None of them affect each other

How do you use it? ~ I created multiple instances. None of them affect each other


Remove cookie for shopOrigin and accessToken

For https://github.com/Shopify/app-bridge/issues/1742
To be shipped with: https://github.com/Shopify/shopify-dev/pull/4722
Remove the use of cookies to keep track of shopOrigin and get it from URL query params instead.
During the oauth flow, don't read accessToken from a cookie. Instead, read it from ctx.state.shopify, which is passed from @shopify/koa-shopify-auth.
Also, update getSubscriptionUrl.js so that code samples for handling app billing can work without using 3rd-party cookies.
Changes here need to be reflected in the tutorial as well: https://shopify.dev/tutorials/build-a-shopify-app-with-node-and-react/charge-a-fee-using-the-billing-api

Hi could we get this merged please? Im running into problems related to this.
I'm trying to use the next.js tutorial project and actually use next.js APIs - namely making web request to an endpoint within api/pages - but I cannot do that in the current state. I've made an app prefix like so:
	server.use(
		createShopifyAuth({
		apiKey: SHOPIFY_API_KEY,
		prefix: "/shopifyapp",

However that doesn't seem to work (i've also added the /shopifyapp to my app URL manually), as well as updating my verify request handler. Is there an example of a shopify app running next.js that actually uses next.js endpoints?

Namely an example of an app the prefixes the shopify app and then can send calls to an /api route. Cheers

One point though: I noticed that when I went to perform OAuth for the first time, I got an error about the shop param being missing in the URL.
Adding that param fixed everything, so it doesn't really cause any problems, but I wonder if the tutorial needs to be updated to account for that. Alternatively, would it be possible to fill that from the .env file?

Hmm, interesting! From my understanding, OAuth callback includes the shop param. I'll take a closer look. I think it would be possible to fill that from .env, but that would make the app hardcoded to a particular shop?

Namely an example of an app the prefixes the shopify app and then can send calls to an /api route. Cheers

Hi @Steven4294, unfortunately shopify-koa-auth used by this project doesn't support the scenario you described. There are a few examples in the works. In the meantime, a very helpful partner has created this excellent example as a reference: https://github.com/ctrlaltdylan/shopify-session-tokens-nextjs It shows how to make authenticated fetch calls to your app's back-end and verify the call.

I'm facing a problem. As far as I understand, there is no check in code if shop is already subscribed to app and have webhooks and scripttag already registered?! If I install ma app from dev store, everything works as expected, I get past bill process and redirected to start page. Problem is if I open same dev shop on another browser, go to apps and try to get into installed app I get to subscribe page again where I have to approve subscription again. Bigger problem is that it try to register webhooks again, which is rejected, but successfully register scripttag every time which result in doubling my widget as many times as I change browser or clear cache. How to check and bypass webhook and scripttag as well as need to approve subscription again?

Hmm, interesting! From my understanding, OAuth callback includes the shop param. I'll take a closer look. I think it would be possible to fill that from .env, but that would make the app hardcoded to a particular shop?

That's very true, we definitely don't want to tie the app to a single shop. The URL that lacked the shop param wasn't the OAuth callback, but rather the app expected the initial URL to contain one - so when I tried to open https://<my_app_url> it failed, but https://<my_app_url>?shop=<shop_url> worked just fine.

Hmm, interesting! From my understanding, OAuth callback includes the shop param. I'll take a closer look. I think it would be possible to fill that from .env, but that would make the app hardcoded to a particular shop?

That's very true, we definitely don't want to tie the app to a single shop. The URL that lacked the shop param wasn't the OAuth callback, but rather the app expected the initial URL to contain one - so when I tried to open https://<my_app_url> it failed, but https://<my_app_url>?shop=<shop_url> worked just fine.

Hmm, interesting! From my understanding, OAuth callback includes the shop param. I'll take a closer look. I think it would be possible to fill that from .env, but that would make the app hardcoded to a particular shop?

That's very true, we definitely don't want to tie the app to a single shop. The URL that lacked the shop param wasn't the OAuth callback, but rather the app expected the initial URL to contain one - so when I tried to open https://<my_app_url> it failed, but https://<my_app_url>?shop=<shop_url> worked just fine.

Could we handle this in a similar way as the rails app gem? If no shop domain is supplied, display an "install" page to accept a shop domain:

Hmm, interesting! From my understanding, OAuth callback includes the shop param. I'll take a closer look. I think it would be possible to fill that from .env, but that would make the app hardcoded to a particular shop?

That's very true, we definitely don't want to tie the app to a single shop. The URL that lacked the shop param wasn't the OAuth callback, but rather the app expected the initial URL to contain one - so when I tried to open https://<my_app_url> it failed, but https://<my_app_url>?shop=<shop_url> worked just fine.

Could we handle this in a similar way as the rails app gem? If no shop domain is supplied, display an "install" page to accept a shop domain:

I'm facing a problem. As far as I understand, there is no check in code if shop is already subscribed to app and have webhooks and scripttag already registered?! If I install ma app from dev store, everything works as expected, I get past bill process and redirected to start page. Problem is if I open same dev shop on another browser, go to apps and try to get into installed app I get to subscribe page again where I have to approve subscription again. Bigger problem is that it try to register webhooks again, which is rejected, but successfully register scripttag every time which result in doubling my widget as many times as I change browser or clear cache. How to check and bypass webhook and scripttag as well as need to approve subscription again?

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

I'm facing a problem. As far as I understand, there is no check in code if shop is already subscribed to app and have webhooks and scripttag already registered?! If I install ma app from dev store, everything works as expected, I get past bill process and redirected to start page. Problem is if I open same dev shop on another browser, go to apps and try to get into installed app I get to subscribe page again where I have to approve subscription again. Bigger problem is that it try to register webhooks again, which is rejected, but successfully register scripttag every time which result in doubling my widget as many times as I change browser or clear cache. How to check and bypass webhook and scripttag as well as need to approve subscription again?

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

Well, webhooks are not big issue, as it wont register again, I get following in console:
Failed to register webhook {
data: {
webhookSubscriptionCreate: { userErrors: [Array], webhookSubscription: null }
},
extensions: {
cost: {
requestedQueryCost: 10,
actualQueryCost: 10,
throttleStatus: [Object]
}
}
}
[
{
field: [ 'webhookSubscription', 'callbackUrl' ],
message: 'Address for this topic has already been taken'
}
]
Biggest issue is that it register ScriptTag every time, which we use to inject a widget to product page, and every time it register new ScriptTag it doubles the widget on product page. Not to mention that it require to subscribe to payment again even though shop  it's already subscribed to app.
Yes it is in development phase, we have finished app but are afraid to launch it as it seems to be big issue.

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

Well, webhooks are not big issue, as it wont register again, I get following in console:
Failed to register webhook {
data: {
webhookSubscriptionCreate: { userErrors: [Array], webhookSubscription: null }
},
extensions: {
cost: {
requestedQueryCost: 10,
actualQueryCost: 10,
throttleStatus: [Object]
}
}
}
[
{
field: [ 'webhookSubscription', 'callbackUrl' ],
message: 'Address for this topic has already been taken'
}
]
Biggest issue is that it register ScriptTag every time, which we use to inject a widget to product page, and every time it register new ScriptTag it doubles the widget on product page. Not to mention that it require to subscribe to payment again even though shop  it's already subscribed to app.
Yes it is in development phase, we have finished app but are afraid to launch it as it seems to be big issue.

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

Well, webhooks are not big issue, as it wont register again, I get following in console:
Failed to register webhook {
data: {
webhookSubscriptionCreate: { userErrors: [Array], webhookSubscription: null }
},
extensions: {
cost: {
requestedQueryCost: 10,
actualQueryCost: 10,
throttleStatus: [Object]
}
}
}
[
{
field: [ 'webhookSubscription', 'callbackUrl' ],
message: 'Address for this topic has already been taken'
}
]
Biggest issue is that it register ScriptTag every time, which we use to inject a widget to product page, and every time it register new ScriptTag it doubles the widget on product page. Not to mention that it require to subscribe to payment again even though shop it's already subscribed to app.
Yes it is in development phase, we have finished app but are afraid to launch it as it seems to be big issue.

Thanks for walking me through the issue you're having. That scenario does sound problematic, but I don't have a good recommendation to offer at this time. @paulomarg do you know if there's already a recommendation for this? If not, where might be a good place to track it? Along with @Steven4294's use case with Next.js. I'd be happy to look into it sometime if we don't currently have a recommended approach.

Hi @Smart387doo, I think I encountered a similar issue before, unfortunately, I don't think there's a way to list all subscribed webhooks to verify exactly what went wrong. Is this something that you're encountering during development? If so, all webhooks for an app are removed when you delete the app. From my understanding, the webhook subscription create returns an ID when successfully created for the first time. Would you be able to track that on your end, and use the ID to confirm its existence? https://shopify.dev/docs/admin-api/graphql/reference/events/webhooksubscription

Well, webhooks are not big issue, as it wont register again, I get following in console:
Failed to register webhook {
data: {
webhookSubscriptionCreate: { userErrors: [Array], webhookSubscription: null }
},
extensions: {
cost: {
requestedQueryCost: 10,
actualQueryCost: 10,
throttleStatus: [Object]
}
}
}
[
{
field: [ 'webhookSubscription', 'callbackUrl' ],
message: 'Address for this topic has already been taken'
}
]
Biggest issue is that it register ScriptTag every time, which we use to inject a widget to product page, and every time it register new ScriptTag it doubles the widget on product page. Not to mention that it require to subscribe to payment again even though shop it's already subscribed to app.
Yes it is in development phase, we have finished app but are afraid to launch it as it seems to be big issue.

Thanks for walking me through the issue you're having. That scenario does sound problematic, but I don't have a good recommendation to offer at this time. @paulomarg do you know if there's already a recommendation for this? If not, where might be a good place to track it? Along with @Steven4294's use case with Next.js. I'd be happy to look into it sometime if we don't currently have a recommended approach.

The way we usually handle this is be keeping track of what has already been registered for a shop in your app - that way you can fully avoid the requests to Shopify, which avoids the issue and speeds things up by not making unnecessary requests. Is that something you could do in your app?

The way we usually handle this is be keeping track of what has already been registered for a shop in your app - that way you can fully avoid the requests to Shopify, which avoids the issue and speeds things up by not making unnecessary requests. Is that something you could do in your app?

The way we usually handle this is be keeping track of what has already been registered for a shop in your app - that way you can fully avoid the requests to Shopify, which avoids the issue and speeds things up by not making unnecessary requests. Is that something you could do in your app?

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

The way we usually handle this is be keeping track of what has already been registered for a shop in your app - that way you can fully avoid the requests to Shopify, which avoids the issue and speeds things up by not making unnecessary requests. Is that something you could do in your app?

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

Unfortunately we don't have any examples in Typescript, but it might help to check out how the shopify_app Ruby gem handles Webhooks and Script Tags.
What that does is essentially to load the configuration for which webhooks / script tags are used by the app, and registers the ones that are missing when an OAuth is completed (so if you add more of them later, they will also be added). Once your app has successfully registered the webhook / script tag, you can store that Shopify knows about it, so you don't need to do it again.
You shouldn't need to store this information for each shop, as webhooks / script tags apply to your app as a whole. Sorry if my previous message was a bit unclear on that regard. The callbacks will contain which shop is currently running it.
If you don't want to store this information in your db, you might be able to fetch webhooks and script tags using the GraphQL API too, to check if you need to register anything:
{
  webhookSubscriptions(first: 10) {
    edges {
      node {
        topic
      }
    }
  },
  scriptTags(first: 10) {
    edges {
      node {
        src
      }
    }
  }
}

Hope this helps!

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

Unfortunately we don't have any examples in Typescript, but it might help to check out how the shopify_app Ruby gem handles Webhooks and Script Tags.
What that does is essentially to load the configuration for which webhooks / script tags are used by the app, and registers the ones that are missing when an OAuth is completed (so if you add more of them later, they will also be added). Once your app has successfully registered the webhook / script tag, you can store that Shopify knows about it, so you don't need to do it again.
You shouldn't need to store this information for each shop, as webhooks / script tags apply to your app as a whole. Sorry if my previous message was a bit unclear on that regard. The callbacks will contain which shop is currently running it.
If you don't want to store this information in your db, you might be able to fetch webhooks and script tags using the GraphQL API too, to check if you need to register anything:
{
  webhookSubscriptions(first: 10) {
    edges {
      node {
        topic
      }
    }
  },
  scriptTags(first: 10) {
    edges {
      node {
        src
      }
    }
  }
}

Hope this helps!

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

Unfortunately we don't have any examples in Typescript, but it might help to check out how the shopify_app Ruby gem handles Webhooks and Script Tags.
What that does is essentially to load the configuration for which webhooks / script tags are used by the app, and registers the ones that are missing when an OAuth is completed (so if you add more of them later, they will also be added). Once your app has successfully registered the webhook / script tag, you can store that Shopify knows about it, so you don't need to do it again.
You shouldn't need to store this information for each shop, as webhooks / script tags apply to your app as a whole. Sorry if my previous message was a bit unclear on that regard. The callbacks will contain which shop is currently running it.
If you don't want to store this information in your db, you might be able to fetch webhooks and script tags using the GraphQL API too, to check if you need to register anything:
{
  webhookSubscriptions(first: 10) {
    edges {
      node {
        topic
      }
    }
  },
  scriptTags(first: 10) {
    edges {
      node {
        src
      }
    }
  }
}

Hope this helps!

It helps for sure, we can for sure use this and check, already implemented and it works as it should, but problem I'm facing now is how to check if shop already have an active recurring subscription and avoid to call getSubscriptionUrl which tries to create new subscription every time. I tried to look at ruby code, but I can't see anything that can help?
I did look at https://shopify.dev/docs/admin-api/graphql/reference/billing/appsubscription, but can't seem to get luck, nor examples from https://shopify.dev/tutorials/bill-for-your-app-using-graphql-admin-api#example-queries works.

How exactly you handle this? Save for every shop state of webhooks and scripttag to db? Do you have some example code available? Thank you in advance.

Unfortunately we don't have any examples in Typescript, but it might help to check out how the shopify_app Ruby gem handles Webhooks and Script Tags.
What that does is essentially to load the configuration for which webhooks / script tags are used by the app, and registers the ones that are missing when an OAuth is completed (so if you add more of them later, they will also be added). Once your app has successfully registered the webhook / script tag, you can store that Shopify knows about it, so you don't need to do it again.
You shouldn't need to store this information for each shop, as webhooks / script tags apply to your app as a whole. Sorry if my previous message was a bit unclear on that regard. The callbacks will contain which shop is currently running it.
If you don't want to store this information in your db, you might be able to fetch webhooks and script tags using the GraphQL API too, to check if you need to register anything:
{
  webhookSubscriptions(first: 10) {
    edges {
      node {
        topic
      }
    }
  },
  scriptTags(first: 10) {
    edges {
      node {
        src
      }
    }
  }
}

Hope this helps!

It helps for sure, we can for sure use this and check, already implemented and it works as it should, but problem I'm facing now is how to check if shop already have an active recurring subscription and avoid to call getSubscriptionUrl which tries to create new subscription every time. I tried to look at ruby code, but I can't see anything that can help?
I did look at https://shopify.dev/docs/admin-api/graphql/reference/billing/appsubscription, but can't seem to get luck, nor examples from https://shopify.dev/tutorials/bill-for-your-app-using-graphql-admin-api#example-queries works.

Yes, getSubscriptionUrl will always trigger a mutation that adds a subscription. It seems that the example queries page is outdated, I will raise that internally to get it fixed.
You could maybe try looking for active subscriptions like so:
{
  currentAppInstallation {
    activeSubscriptions {
      createdAt
    }
  }
}

I believe that query should tell you whether or not the current shop currently has a subscription to your app.
@hannachen sorry if we took over your PR with this discussion! @Smart387doo if this doesn't solve your issue, would you mind opening a new issue in https://github.com/Shopify/shopify-app-node so we can discuss this without getting in the way of the PR?

Yes, getSubscriptionUrl will always trigger a mutation that adds a subscription. It seems that the example queries page is outdated, I will raise that internally to get it fixed.
You could maybe try looking for active subscriptions like so:
{
  currentAppInstallation {
    activeSubscriptions {
      createdAt
    }
  }
}

I believe that query should tell you whether or not the current shop currently has a subscription to your app.
@hannachen sorry if we took over your PR with this discussion! @Smart387doo if this doesn't solve your issue, would you mind opening a new issue in https://github.com/Shopify/shopify-app-node so we can discuss this without getting in the way of the PR?

Yes, getSubscriptionUrl will always trigger a mutation that adds a subscription. It seems that the example queries page is outdated, I will raise that internally to get it fixed.
You could maybe try looking for active subscriptions like so:
{
  currentAppInstallation {
    activeSubscriptions {
      createdAt
    }
  }
}

I believe that query should tell you whether or not the current shop currently has a subscription to your app.
@hannachen sorry if we took over your PR with this discussion! @Smart387doo if this doesn't solve your issue, would you mind opening a new issue in https://github.com/Shopify/shopify-app-node so we can discuss this without getting in the way of the PR?

Sorry if I overflood this thread, will stop it, just want to give feedback.
Not sure if I do something wrong, but I tested many graphql queries, but not able to get if shop have active subscription. This one like other ones gives undefined, there is response but no payload as expected.
Thank you for help, will try to ask in another thread, I just can't believe that it should be so complicated or unclear how to gather such important information.

Yes, getSubscriptionUrl will always trigger a mutation that adds a subscription. It seems that the example queries page is outdated, I will raise that internally to get it fixed.
You could maybe try looking for active subscriptions like so:
{
  currentAppInstallation {
    activeSubscriptions {
      createdAt
    }
  }
}

I believe that query should tell you whether or not the current shop currently has a subscription to your app.
@hannachen sorry if we took over your PR with this discussion! @Smart387doo if this doesn't solve your issue, would you mind opening a new issue in https://github.com/Shopify/shopify-app-node so we can discuss this without getting in the way of the PR?

Sorry if I overflood this thread, will stop it, just want to give feedback.
Not sure if I do something wrong, but I tested many graphql queries, but not able to get if shop have active subscription. This one like other ones gives undefined, there is response but no payload as expected.
Thank you for help, will try to ask in another thread, I just can't believe that it should be so complicated or unclear how to gather such important information.

Just a quick update: we've fixed the example queries docs page, so that query might be what you're looking for now.
Thank you for pointing out that the query was not working!

Just a quick update: we've fixed the example queries docs page, so that query might be what you're looking for now.
Thank you for pointing out that the query was not working!


suggest "declare class" when reserved word "class" is found unexpectedly

I keep forgetting "declare" in "declare class" in declaration files. Maybe the error message could help me remember?

Suggestion is properly displayed when declaring modules. https://flow.org/try/#0CYUwxgNghgTiAEBbA9sArhBByALiAzjlvAN4BQ88oksCN++8AKgTqQL5mdnXRxKoM2PIQC0AMygBLCMXKV6jFoQ5cgA
If you want it in .flow files it won't be possible, because they could be for source files when using https://github.com/Macil/flow-copy-source

Suggestion is properly displayed when declaring modules. https://flow.org/try/#0CYUwxgNghgTiAEBbA9sArhBByALiAzjlvAN4BQ88oksCN++8AKgTqQL5mdnXRxKoM2PIQC0AMygBLCMXKV6jFoQ5cgA
If you want it in .flow files it won't be possible, because they could be for source files when using https://github.com/Macil/flow-copy-source


404 error when getting track/album/playlist/artist data

Describe the bug
Hi, a lot of users started reporting to me that they are getting 404 errors.
The url to the song is valid, We've tried clearing the cache but it didn't help.
Sometimes it works sometimes it doesn't seems pretty random.
This started happening few days ago.
Your code
SpotifyClient from here: https://github.com/spotDL/spotify-downloader/blob/master/spotdl/search/spotify_client.py
and then
# Initialize spotify client
SpotifyClient.init(
	client_id="working_id",
    client_secret="working_secret",
    user_auth=False,
)

spotify_client = SpotifyClient()

data = spotify_client.track(spotify_url)

Expected behavior
We always get the data.
Output
HTTP Error for GET to https://api.spotify.com/v1/tracks/5aeMTTkvye4ERaMni9k399 with Params: {'market': None} returned 404 due to None
http status: 404, code:-1 - https://api.spotify.com/v1/tracks/5aeMTTkvye4ERaMni9k399:
 None, reason: None

Environment:

OS: Windows, Linux
Python version: from 3.7 to 3.10
spotipy version: 2.19
your IDE (if using any)

Additional context
https://github.com/plamere/spotipy/issues/794 might be the same issue

I am getting the same errors in (what appears) random moments, and it started just recently. Using same code, same fast network. I am checking with Spotify API console just after the error occurs with same token and get data for the requested artist, album, track.
My observation is that 1/20 of the requests returns HTTP Error and next run of the code returns proper data.
Spotify's API status is not reporting any issues: https://status.spotify.dev/

It looks like this is an issue on the Spotify side rather than the spotipy Python library.
These seem related:

https://community.spotify.com/t5/Spotify-for-Developers/Getting-playlist-items-randomly-fails-with-404-Not-Found/m-p/5356441
https://community.spotify.com/t5/Spotify-for-Developers/Intermittent-404s-Getting-Playlist-Tracks-via-API/m-p/5356770?search-action-id=299899195113&search-result-uid=5356770
https://community.spotify.com/t5/Spotify-for-Developers/Add-Items-to-Playlist-404-Errors/m-p/5332623

If anyone is up to create a new issue in Spotify for Developers gathering all the data, then we can all upvote it. Title could be something like "Getting 404 instead of 429/5xx"
In the meantime, I suggest you deal with retrying 404s in your code where you know it shouldn't fail. I know, it's just very bad that it returns 404 instead of 5xx or 429.


Update IUCN resources

IUCN Red List
IUCN Structured Data

A certain list of manual steps should be followed for IUCN resources to be re-harvested.
First, download the csv export file (in this format export-?????.csv.zip) from IUCN using this:
URL:      http://www.iucnredlist.org/users/sign_in
Login<EMAIL_ADDRESS>Password: jijamali
Then among the available downloads in "My Downloads",
I created this saved search: “For EOL Resources 211 and 737” - Exported on 24 August 2016
When re-harvesting, before downloading you need to click button [Refresh Exported Data], this usually takes half-day to finish. After which you'll receive an email confirmation: "IUCN Red List: Export complete".
This same export is used by both IUCN resources (IDs 211, 737).
http://eol.org/content_partners/10/resources/737
http://eol.org/content_partners/10/resources/211
Then I uploaded it to a web accessible folder which the connector uses at the moment. This case I’m using my public DropBox folder:
https://dl.dropboxusercontent.com/u/7597512/IUCN/export-?????.csv.zip
I will now put these steps in the connector. So we won’t forget.

Thanks, Eli! I didn't realize how manual this one was. Bob is discussing future content sharing with IUCN right now, so there will probably be revisions sometime in the Fall.

Hi @jhammock , the steps was this many since I've created a new export download for our 2 IUCN resources. Next we need to re-harvest,

I will just click that button [Refresh Exported Data] and the export file will be updated from their server in a couple of hours.
Then we just set the our resource to re-harvest in eol.org. That means our connector will point to their server for the export file and not on my Dropbox folder. I think this is possible since the export file will just be refreshed and it actual filename will not change.

*So the actual manual thing only here is the clicking of the button [Refresh Exported Data], since we've created the export once already.

Hi @jhammock ,
We can now add to harvest queue the two IUCN resources:
IUCN Red List (id = 211)
IUCN Structured Data (id = 737)
Thanks @JRice for merging/applying latest code.


Add suit options

Not a real use case for this right now, but figured I would offer it up as a 'jersey' option. This PR adds in 2 new jerseys, 'suit' and 'suit2'.  I thought maybe a suit would make sense if you ever include owners, coaches, GMs, or whatever. Or perhaps it would look good on free agents or retired players.
I added logic to remove a player's headband, facemask, glasses, etc if they're wearing a suit. With the first suit option, the player's tie will be solid in the team's primary color. Suit2 has primary color tie, with white and secondary color stripes.
Below are examples for both, tested in my local editor.html yarn run.  Please note - when testing this I got a javascript error stating 'variable faces does not exist' on line 787 of editor.html, but upon re-starting yarn the error disappeared. Not sure if that is a real issue.

This is really cool, thanks!
I will probably not merge this until I have a use for it in BBGM (which I probably should at some point, would be fun to have a GM character you can make for yourself, or maybe a coach). Cause until then it's just increasing the file size.


chore(main): release 4.5.5

:robot: I have created a release beep boop
4.5.5 (2024-10-16)
Bug Fixes

cicd: trigger and scp fixes (d445772)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v4.5.5
:sunflower:


scroll area isn't working correctly

Scroll doesn't work if you drag it with the mouse.
I don’t know if the author of the mod added such a function at all, but I would like it to work
Video not as useful because mouse clicks are not visible, but I'll be glad if it helps
https://github.com/LGatodu47/ScreenshotViewer/assets/91954858/ab9c9e8c-2d4c-4721-b784-2d6985aa2414

Hi,
To be honest, the reason you can't drag to scroll is simply because I was lazy when I designed this scrollbar (it was also the first time I tried designing one by myself). I'm currently working on the next version of the mod and I'll try to get this implemented.

Fixed in Screenshot Viewer 1.2.0!


Updating a SWC in Animate doesnt propagate

I may be doing something wrong, i'm not sure, but this is my process:
In Animate, i compile a swc of assets - bitmaps, sprites, etc (no code).
Each of these symbols has a linkage name.
However, when I add a new symbol and export the SWC, as3mxml doesnt detect it with intellisense, and even worse, the new asset isn't even merged in to my app when I build it!  I feel like there must be a cached version somewhere?
At any rate, my workaround has been to shut down vscode and relaunch it - this works without fail every time
So my question is :  is this a bug, or am i missing a step here to keep all my work in sync?  Its not a huge deal but if there's something i can be doing better here i'd like to know!
thanks!

Never mind.   I wasn't referencing the assets in my app so they werent being merged.   /facepalm


Small error in Example

Hi, how are you?
While making the addon for construct 3 I found a small error in the example code:
All occurrences of addEventListener onMRecAd... should start in uppercase: OnMRecAd...
Example:
window.addEventListener('onMRecAdLoadedEvent'
Must be changed to:
window.addEventListener('OnMRecAdLoadedEvent'

Appreciate it @eltonnobrega, I've fixed it in the latest commit.


Does NVIDIA GeForce GTX 1050 adequate to install carla #5929

Hi dear,
I have 2 questions :
I have a NVIDIA GeForce GTX 1050 which has 4 GB GPU is it adequate to install carla?
visual studio 2019 does not suport Windows 8.1 SDK so I install Windows 10 SDK, is it compatible to build Carla?

CARLA version: 0.9.13
Platform/OS: windows 10
Problem you have experienced:
What you expected to happen: I want to run "make package" successfully .
I would appreciate if anyone could help me

Yes, it is possible to build carla with an GTX 1050 TI. But later if you ran the simulator you get very slow response. Even if you run the simulator in off-screen rendering mode the performance will be not optimal, but in the worse case you can use such a setup to render off-screen data into images.
The problem is more the "low" RAM than the speed of the GPU. So it is better to use at least a 6 GB RAM Card or better a 8 GB card, e.g. a GTX 1070 is fine.

thank you jokolaco,
I have a new problem as follow:
-[Package]: Building package...
Exception calling "Write" with "3" argument(s): "Exception of type 'System.OutOfMemoryException' was thrown."
At
C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\Microsoft.PowerShell.Archive\Microsoft.PowerShell.Archive.psm1:820
char:29

...                     $destStream.Write($buffer, 0, $numberOfBytesRead)

                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : OutOfMemoryException

I would be appreciate if you help me to solve this.

Sorry, i don´t use windows.
But as mentioned in the feedback you need more RAM or diskspace.
Please read the docs!