New Partner Agency Invitations: Some spelling hiccups, etc.

1. When you add a new partner agency to Diaper Base, you enter their name and email here:

After you hit "save", the new partner agency AUTOMATICALLY receives an email invite to create PartnerBase account in order to complete an on-boarding questionnaire. My thoughts: There should be a warning to the user, or some kind of checkbox/confirmation asking whether the diaper bank wants to send the new partner agency the PartnerBase questionnaire right away. I had NO idea it was happening. Maybe TWO buttons? A "SAVE" button, as well as a "SAVE & SEND INVITATION TO PARTNER AGENCY" button? There are plenty of reasons why the user might want to create the account, but not send them the invite until a later time.
2. Now, about the email itself: This is the view from the inbox. Can we remove: "This is a preheader text. Some clients will show this as a preview..." and change it to be something else? Maybe the first sentence in the body of the email?

3. This is the body of the email. I circled a couple spelling errors. The yellow highlighted portion is my question: Can the partner organization ALREADY submit their diaper requests through PartnerBase? If not, maybe it shouldn't state this yet?

Thank you, amazing volunteers!!!!

I'm going to break this into two issues and close this one --
thanks for reporting these!

https://github.com/rubyforgood/diaper/issues/713

https://github.com/rubyforgood/partner/issues/80


serialize / deserialize GameType and GameParameters

addresses #234

Very nice implementation, thanks!
I have now imported it.. should get merged in the next update.
I made a few cosmetic changes, only one real change is replacing regex with absl::StrReplaceAll, as regex is an unapproved C++ header (hence against our style guide).
Thanks again, this is a great addition, and kudos on the timely submission!


Cant use toHaveHeaders for single header + value verification

Steps to reproduce
const response: APIResponse = await request.post(https://reqres.in/api/users, {
data:
{
"name": "morpheus",
"job": "leader"
},
failOnStatusCode: true,
});
await expect(response).toHaveHeaders({'Connection': 'close'});
Actual result
fails with

Expected  -  1

Received  + 14
Object {

"Connection": "close",

"access-control-allow-origin": "*",
"cf-cache-status": "DYNAMIC", .... }

Expected result
toHaveHeaders can be used to verify part of headers object, not all object.
or to add new matcher that will verify part of the headers object.

Hey @qa-senpai,
Thank you for reporting the issue. You can use the toHaveHeaderName method. For instance:
// Asserts that the response's headers contains the header 'Connection' with value 'close'
await expect(response).toHaveHeaderName('Connection', 'close');

Don't forget to give a star for the project.

'Connection', 'close'

What am I doing wrong?
Property 'toHaveHeaderName' does not exist on type 'MakeMatchers<void, APIResponse

"odottaa": "^1.1.18"

Sorry, my bad. It should be toHaveHeader
// Asserts that the response's headers contains the header 'Connection' with value 'close'
await expect(response).toHaveHeader('Connection', 'close');

Sorry, my bad. It should be toHaveHeader
// Asserts that the response's headers contains the header 'Connection' with value 'close'
await expect(response).toHaveHeader('Connection', 'close');

but If want verify more then one header + value (but not all) ,
e.g
{
'Connection': 'close',
"access-control-allow-origin": "*",
"cf-cache-status": "DYNAMIC"
}

For this case, you can use toHaveHeaders. It should work. I've just verified it.
import { test, expect } from '@playwright/test';

test('verify toHaveHeaders', async ({ request }) => {
  const response = await request.get('/');
  console.log(response.headers());

  /**
   * {
      'content-type': 'text/html',
      location: 'http://localhost:3000/',
      date: 'Fri, 01 Dec 2023 15:24:36 GMT',
      connection: 'close',
      'content-length': '22
   * }
   *
   */
  await expect(response).toHaveHeaders({ connection: 'close', 'content-length': '22' });
});

OMG, it really works... I think problem was that I use uper case in header name... :(
Thank you :)


Retrieve calculated values

At the moment, if any of your cells contain a formula, using 'getData' or 'download' returns the formula expression in that cell.
Is there any way to retrieve the whole table with the current calculated values instead?
Cheers
Lance

You can get the value from one cell, but not the entire table since it would block the portability of the data. To get a individual cell, the easiest way:
$('yourtable').find('#0-0').text(); // for Colum A1
$('yourtable').find('#1-0').text(); // for Colum B1
$('yourtable').find('#2-0').text(); // for Colum C1
$('yourtable').find('#0-1').text(); // for Colum A2
$('yourtable').find('#0-2').text(); // for Colum A3
etc...
I am going to leave the issue open to discuss a possibility to incorporate the full export with the values only.

I am not sure if I understood your last comments. Could you test that on the new version v2.0.0 if you can explain your problem with examples will be great.


The 'Save album titles' checkbox

What's the plan with it ? Looking at DA ripper, it's absolutely not referenced and other files, not just rippers, make unclear references.
DA folders are ripped with the folder owner's name, whether it's gallery, favs or scraps, and the folder's ID. Instead of this kinda name it'd be better if the folder's complete name was used instead. I can help with that.

What's the plan with it ? Looking at DA ripper, it's absolutely not referenced

AFAIK it was never implemented in the DA ripper.

and other files, not just rippers, make unclear references.

Ripme in a nutshell. Someone really needs to get on documenting everything.

can i take a stab at this?

@taligregor Sure


Test script has incorrect API methods

Pat (via email) pointed out the test module uses API methods from pre-v1.

No more test script..


Please update add TTS and alloow user to change temperature and top p to get better responses

Please update add TTS and alloow user to change temperature and top p to get better responses

Updates

Latest master has TTS

Discussion

Planning to add temperature and top p settings in near futute


Update py3patch.py

Remove deprecated HTMLParser.HTMLParser.unescape and replace it with html.unescape making it safer and working on Python 3.9.

@poyynt @orakaro Hey, random bystander here, just noticed from perusing the issues in this repo -- some folks aren't able to run the app because they're using 3.9.5 and would benefit from this PR getting in

Agree with @smai-f, I've tried installing it all ways and I guess I'll have to do it with python2 and virtualenv, but there's a lot of users that might just give up on the first try :/
Thanks for this great project, though! :)


what is the alpha value of the caffe-mobilenet

tensorflow-mobilenet has four alpha value,(1, 0.75, 0.5, 0.25)
https://github.com/tensorflow/models/blob/master/research/slim/nets/mobilenet_v1.md
what is the alpha value of the pretained caffe-mobilenet?
Thanks!

From the top accuracy , I guess it is 1 .
thanks!

yes, it is 1.0


Tailwind template

Add a template that demonstrates how to build own components using hooks and style them using Tailwind (possibly using TW v4?).

any news？
thanks


Optimized the method GetCustomAttribute

The method GetCustomAttribute worked with a collection, although there is an implementation for a single call.
It also allowed fixed double-casting.

Nice refactoring, as always! :rocket:


[BUG]: colossalai check error

🐛 Describe the bug
pytorch 1.9+cuda11.1+Nvidia A30 GPU
after install successfully, run colossalai check -i show the error below.
Traceback (most recent call last):
  File "/home/liuzixi01/.conda/envs/torch-cuda11/bin/colossalai", line 5, in <module>
    from colossalai.cli import cli
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/__init__.py", line 1, in <module>
    from .initialize import (initialize, launch, launch_from_openmpi,
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/initialize.py", line 23, in <module>
    from colossalai.engine.schedule import NonPipelineSchedule, PipelineSchedule, InterleavedPipelineSchedule, get_tensor_shape
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/engine/__init__.py", line 1, in <module>
    from ._base_engine import Engine
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/engine/_base_engine.py", line 11, in <module>
    from colossalai.engine.schedule import BaseSchedule, NonPipelineSchedule, PipelineSchedule, InterleavedPipelineSchedule
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/engine/schedule/__init__.py", line 2, in <module>
    from ._pipeline_schedule import PipelineSchedule, InterleavedPipelineSchedule, get_tensor_shape
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/engine/schedule/_pipeline_schedule.py", line 9, in <module>
    from colossalai.amp.naive_amp import NaiveAMPModel
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/amp/__init__.py", line 9, in <module>
    from .torch_amp import convert_to_torch_amp
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/amp/torch_amp/__init__.py", line 5, in <module>
    from .torch_amp import TorchAMPOptimizer, TorchAMPModel, TorchAMPLoss
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/amp/torch_amp/torch_amp.py", line 12, in <module>
    from colossalai.nn.optimizer import ColossalaiOptimizer
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/nn/__init__.py", line 1, in <module>
    from .layer import *
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/nn/layer/__init__.py", line 7, in <module>
    from .moe import *
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/nn/layer/moe/__init__.py", line 1, in <module>
    from .experts import Experts, FFNExperts, TPExperts
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/nn/layer/moe/experts.py", line 8, in <module>
    from colossalai.zero.init_ctx import no_shard_zero_decrator
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/__init__.py", line 6, in <module>
    from colossalai.zero.sharded_model.sharded_model_v2 import ShardedModelV2
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/sharded_model/__init__.py", line 1, in <module>
    from .sharded_model_v2 import ShardedModelV2
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/sharded_model/sharded_model_v2.py", line 12, in <module>
    from colossalai.zero.utils import ZeroHook
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/utils/__init__.py", line 1, in <module>
    from .zero_hook import ZeroHook
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/utils/zero_hook.py", line 10, in <module>
    from colossalai.zero.shard_utils import BaseShardStrategy
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/shard_utils/__init__.py", line 1, in <module>
    from .base_shard_strategy import BaseShardStrategy
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/shard_utils/base_shard_strategy.py", line 5, in <module>
    from colossalai.zero.sharded_param.sharded_tensor import ShardedTensor
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/sharded_param/__init__.py", line 1, in <module>
    from colossalai.zero.sharded_param.sharded_tensor import ShardedTensor
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/zero/sharded_param/sharded_tensor.py", line 2, in <module>
    from colossalai.gemini.stateful_tensor import StatefulTensor, TensorState
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/gemini/__init__.py", line 1, in <module>
    from .stateful_tensor_mgr import StatefulTensorMgr
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/gemini/stateful_tensor_mgr.py", line 7, in <module>
    from colossalai.gemini.tensor_placement_policy import TensorPlacementPolicy
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/gemini/tensor_placement_policy.py", line 10, in <module>
    from colossalai.gemini.memory_tracer import MemStatsCollector
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/gemini/memory_tracer/__init__.py", line 3, in <module>
    from .memstats_collector import MemStatsCollector
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/gemini/memory_tracer/memstats_collector.py", line 5, in <module>
    from colossalai.tensor import ChunkManager
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/tensor/__init__.py", line 3, in <module>
    from .colo_tensor import ColoTensor
  File "/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/colossalai/tensor/colo_tensor.py", line 9, in <module>
    from torch.overrides import get_default_nowrap_functions
ImportError: cannot import name 'get_default_nowrap_functions' from 'torch.overrides' (/home/liuzixi01/.conda/envs/torch-cuda11/lib/python3.8/site-packages/torch/overrides.py)

Environment
pytorch 1.9 + cuda 11.1

I think this is a version mismatch issue. Can you try it with torch 1.10 or 1.11?

pytorch 1.8+cuda11.1+Nvidia RTX 3090, I have encountered the same error.

@wohaocaiji @zixiliuUSC I think the import error has been fixed in the latest main branch.


Default to DEFAULT_SCALE_VALUE when the zoom parameter, from PDFViewerApplication.store, isn't found in PDFViewerApplication.setInitialView

Currently the code uses PDFViewer.currentScale, which can be problematic since by default that will return 1. In PDFLinkService.setHash numeric zoom values are divided by 100, which can thus lead to an incorrect document scale being set.
Obviously we could fix this by multiplying the zoom parameter in PDFViewerApplication.setInitialView by 100, but it's simpler and seems more logical to just use DEFAULT_SCALE_VALUE instead.
@timvandermeij Would you mind reviewing this?
I stumbled upon this issue when opening the PDF file in issue #6243 in a new tab (by middle-clicking, or using the context-menu and choosing "Open Link in New Tab").

/botio-linux preview

Funny, I cannot reproduce it with that file, but I have seen several files the last few days that started at zoom value 1%, making them tiny. I couldn't find a pattern to reproduce it and wanted to file an issue for it, but forgot. Thankfully you have found the cause! I will take a look soon.

Actually, this is a regression from PR #6192, and I think I understand why it broke.
The current PR isn't really a complete solution, it just "hides" part of the issue.
Note: the piece of code that this patch changes is still wrong, and should be fixed, but it's not enough to make the regression go away on its own.
@timvandermeij It's up to you if you want to take this PR now, or if you prefer that I simply include this change in another PR that actually fixes the issue. (I need to do some more testing, but I should be able to submit the "real" solution tomorrow.)

Let's close this and wait for the complete solution. I have opened #6253 to track the issue.


use tmp_upath from dvc-objects

https://github.com/iterative/dvc-objects/blob/main/tests/conftest.py

Closed by #6


python38Packages.langcodes: 2.1.0 -> 3.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.langcodes is: "A toolkit for working with and comparing the standardized codes for languages, such as ‘en’ for English or ‘es’ for Spanish"
meta.homepage for python38Packages.langcodes is: "https://github.com/LuminosoInsight/langcodes"
meta.changelog for python38Packages.langcodes is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.1.0 with grep in /nix/store/488zcgv45kgnisxibj8h1zkkaxbpflds-python3.8-langcodes-3.1.0

directory tree listing: https://gist.github.com/f29313a09265c562b0c32afc1c69b8c4

du listing: https://gist.github.com/8b080351c86b0ffd4af6149371305e34

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.langcodes
python38Packages.wordfreq
python39Packages.langcodes
python39Packages.wordfreq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/488zcgv45kgnisxibj8h1zkkaxbpflds-python3.8-langcodes-3.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.langcodes https://github.com/r-ryantm/nixpkgs/archive/13e02c41566ee47d30d68053846ce3c32c55def3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/488zcgv45kgnisxibj8h1zkkaxbpflds-python3.8-langcodes-3.1.0
ls -la /nix/store/488zcgv45kgnisxibj8h1zkkaxbpflds-python3.8-langcodes-3.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

python38Packages.wordfreq
python39Packages.langcodes
python39Packages.wordfreq

1 package built:

python38Packages.langcodes

Maintainer pings
cc @ixxie for testing.

technically not new failures, but should be addressed:
3 packages failed to build:
python38Packages.wordfreq python39Packages.langcodes python39Packages.wordfreq

1 package built:
python38Packages.langcodes

This should be good fixed https://github.com/NixOS/nixpkgs/pull/112993 and https://github.com/NixOS/nixpkgs/pull/115932 are merged.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115783 run on x86_64-linux 1

2 packages failed to build and are new build failures:

python38Packages.wordfreq: log was empty
python39Packages.wordfreq: log was empty

2 packages built:

python38Packages.langcodes
python39Packages.langcodes

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.langcodes:

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.051s’
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md


Must-gather: Update OWNERS file

Add rajatsing as reviwers and
remove ashishranjan738.
Signed-off-by: crombus<EMAIL_ADDRESS>

@crombus  - What I was saying is that you may be misinterpreting the effect of putting someone into the "reviewers" list: If you put him in the reviewers list, then his "/lgtm" will be authoritative and will lead to get patches merged. At least that is my understanding.
And we usually add folks to both lists.
@jarrpa  to keep me honest

@crombus  - What I was saying is that you may be misinterpreting the effect of putting someone into the "reviewers" list: If you put him in the reviewers list, then his "/lgtm" will be authoritative and will lead to get patches merged. At least that is my understanding.
And we usually add folks to both lists.
@jarrpa  to keep me honest

Michael is right, you want him under approvers not reviewers to prevent /LGTM access. But I think this is entirely unnecessary, you could just add him to both with the understanding he shouldn't LGTM anything just yet.

Michael is right, you want him under approvers not reviewers to prevent /LGTM access. But I think this is entirely unnecessary, you could just add him to both with the understanding he shouldn't LGTM anything just yet.

Understood and updated.

Understood and updated.

/test ocs-operator-ci

/test ocs-operator-ci


add code of conduct file

#34 add code of conduct file.

Good Work!!
If you think any more improvements can be made, feel free to go for it.
Keep up the great work, and happy contributing!


Fixed typescript error from resolving unspecified in exports map .ts file

Should fix: #450

Since @paul-sachs confirmed this is working - undrafted

Sorry for the close & reopen, the CI seemingly got stuck


Use another license.

There seems to be some problems with Unlicense because it is not a "no warranty" license. Maybe we should change it.

No longer an issue, just need to find the new license for the https://github.com/mafagafogigante/algorithms repository.


"Execute script" on multiple databases

Sometimes it is useful for a user to execute the same script on multiple databases at once.
I suggest to not disallow doing it for a user (as it is now):
https://github.com/user-attachments/assets/34095550-b337-454e-a438-739de9bf23d3
Ideally, scripts could be started simultaneously in different threads on different databases or sequentially (add some form where user can set it somehow).

Thank you for the idea.
It's a duplicate of #34071
You can vote for the mentioned issue with 👍 under the issue description to promote it to a higher priority.


Script classes should be properly destroyed

During early development stages class destructors was turned off, now since most of leaks should be fixed D classes should be disposed properly, otherwise fields with NodePath and other reference types are leaked.
This could be a problem for example when spawning lots of bullets and can potentially lead to OOM exception.

This is now planned for next release.
It may potentially unveil some hidden bugs related to memory ownership in script classes (currently since destructors are never called it simply leaks memory and other resources such as open files).
This will allow to start unifying structs/classes differences in our codebase that should lessen the burden of maintaining two versions.


fix(deps): update terraform terraform-ibm-modules/cos/ibm to v8.3.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
minor
8.2.12 -> 8.3.0

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.3.0
Compare Source
Features

add support to scope resource keys to 'None' role (#626) (49cd08a)

v8.2.14
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.13.1 (#630) (078cc08)

v8.2.13
Compare Source
Bug Fixes

deps: update terraform-module (#627) (122e15f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.9.8 :tada:
The release is available on:

GitHub release
v1.9.8

Your semantic-release bot :package::rocket:


Show save dialog when no state server

Addresses #552 by showing the save dialog when the user attempts the save-state-getjson shortcut when there is no state server for the session. Also fixes a bug where if you request to copy the raw url via the save-state-getraw shortcut without a state server in the session, neuroglancer does not and tells the user there is no state server.

lgtm


add CSS Gradients

add CSS Gradients similar to background images!
then
//remove the background images

Can I work on it?

Hi @nishathapa We have already got the PR!
you may work the fonts! and make it look good!


Always return sdpMid & sdpMLineIndex if value is null

Description
sdpMid & sdpMLineIndex ToJSON description : (https://w3c.github.io/webrtc-pc/#dom-rtcicecandidate-tojson)
I thought ICECandidateInit should return sdpMid & sdpMLineIndex if value is null.
I'm doing some stuffs using react-native-webrtc, I suffered issue in this line.
So I thought sdpMind & sdpMLineIndex should not be null, therefore I request PR.
Thanks!

In my candidate
candidate: "candidate:3460887983 1 udp<PHONE_NUMBER> <IP_ADDRESS> 50367 typ host generation 0 ufrag 8kI+ network-id 1 network-cost 10"
It dosen't have mid.
So it's sdpMid, sdpMLineIndex value should be zero or null?
Integer value should not be zero... I'm so confused by this...
sdpMLineIndex says it can be nullable.
It means zero? or null?

Thanks @DevRockstarZ
This looks right to me. The w3c docs seem to imply the key should always exist.

@Sean-Der I also changed usernamefragment it also should be default to null.
I changed readme.md also because I added my last name!
Thanks for your comment!

Merged 6d3633e58923227e00e96ed80ae46e6fa25a39cc !
Thanks for all these great commits and using Pion :) love to see this stuff fixed

I'm running into an error with this change:
Failed to execute 'addIceCandidate' on 'RTCPeerConnection': Candidate missing values for both sdpMid and sdpMLineIndex

MDN has this note:
Note: Attempting to add a candidate (using addIceCandidate()) that has a value of null for either sdpMid or sdpMLineIndex will throw a TypeError exception.

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateInit/sdpMLineIndex
So im not sure the key should exist with a null value


Use kpt's new config packaging and rendering workflows for day0 and dayN user journeys

Now that we have a functional build for kpt, we should validate the packaging and rendering workflows through some of the customer journeys that involves day0 and dayN scenarios.

/cc @mortent @mikebz

moving to M3 so we can define what we need to cover here.


cyclonedds: 0.1.0-1 in 'eloquent/distribution.yaml' [bloom]

Increasing version of package(s) in repository cyclonedds to 0.1.0-1:

upstream repository: https://github.com/eclipse-cyclonedds/cyclonedds.git
release repository: https://github.com/ros2-gbp/cyclonedds-release.git
distro file: eloquent/distribution.yaml
bloom version: 0.8.0
previous version for package: null

See the Dashing PR #22117 for what needs to be updated to pass CI.


Add lsp-command-map to SPC-c-l

The default lsp-mode bindings are bound to s-l which is impractical
for anyone using keybindings in their window manager. This makes all the
default lsp bindings available on SPC-c-l.

Sorry, this is broken - I'm not sure how to add a lazily loaded command map.

(map!
      (;;:feature that will be lazy loaded
        :leader
        (:prefix-map ("c" . "Feature")
          :desc "Some name"                "l" #'func1
          :desc "Some name2"              "m" #'func2)))

(use-package! some-package
  :bind (:map package-map
          ("<left>" . #'do-something1)
          ("<right>" . #'do-something2)))

Depending on the case, both should allow lazy loading

Replacement at https://github.com/hlissner/doom-emacs/pull/2952


Release Notes for .NET SDK 1.12.2

@mimig1 @arramac : Please review and sign-off. If it looks good, feel free to add the sign-off tag so that it gets merged in 10am build. This was released last Friday so wanted it to be live asap.
@mimig1 Feel free to edit and merge as I may not be online before 10am.

@rnagpal,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

#sign-off

@rnagpal : Thanks for your contribution to the Azure documentation! The author, @rnagpal, has been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It�s easy to access the private repo version of your articles in GitHub. Just add �pr to the URL, as follows:
Public repo URL: https://github.com/Azure/azure-content/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Azure/azure-content-pr/blob/master/articles/azure-portal-overview.md
We've closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions.


Fixed possible stack overflow in parser

For changelog. Remove if this is non-significant change.
Category (leave one):

Bug Fix

Short description (up to few sentences):
Fixed the possibility of a fabricated query to cause server crash due to stack overflow in SQL parser.

TODO:
perl -e 'print "SELECT 1" . ("+1" x 10000) ' | curl 'http://localhost:8123/' -d @-

We also have known stack overflows in:

condition for row-level security involving a subquery on the same table;
Merge table over another Merge tables that will make a loop;
Distributed table with local shard that points to the same Distributed table;
hierarchical dictionaries with a loop.

Everything is solved except:

hierarchical dictionaries with a loop.


RE 3 205 crash

Version
3.0.2 (848906a)
Seed
R730-54JY-ZTHH0HMA9Y600N49K490ZZZZZZZZZZZZF2Z
Scenario
RE 3 (Jill)
Player Character
Carlos (RE3R)
What happened?
Entering Room 205 crashes. Debug save attached.
It would also be nice to request features or enhancements to your mod! I think having the option of starting with the side pack already would be a great QoL.
01_2023-05-24 05^04.23.zip

It would also be nice to request features or enhancements to your mod! I think having the option of starting with the side pack already would be a great QoL.

You can use the discussions feature on GitHub to raise enhancement requests.


performance

Everything built properly but it runs very slow.   Is this your experience also?

You mean the building process is slow?
The build performance depends on the amount of memory and the number of CPU cores.
To compile the ros1 bridge, It takes about 1 GB of memory per CPU core.    So, if your system has only 4GB of memory, but 100 CPU cores, it will still use only 4 CPU cores for the compilation.

sorry I meant actually running the bridge (compile time not an issue).   I know not your code, but was just curious if you see very slow run time performance?  I have an Image message topic from ros1 at 15 hz, and barely gets to ros2 at 2hz

I see.  You can try using the original ros1 bridge code.  Modify Dockerfile line 222:
Replace:
git clone https://github.com/smith-doug/ros1_bridge.git;
with
git clone https://github.com/ros2/ros1_bridge.git;
And the rebuild the docker image.

Closing this issue due to inactivity.

Closing this issue due to inactivity.


Collection of small changes resulting from final removal of plasmapy_sphinx from plasmapy

fix typos
copy over CSS changes

TL;DR We can NOT have the version flyout in the sidebar for our theme at the moment.  It will have to live on the page like any theme that is not sphinx_rtd_theme.
@namurphy I think I have all the last changes needed from the migration from plasmapy.  However, I've discovered an "issue" that is too big of a rabbit hole to try to "fix" at this time.  This rabbit hole is associated with the version flyout menu.
As you're probably aware of, the flyout menu is generated in the sidebar when using sphinx_rtd_theme but gets placed on the bottom-right corner of the page when not using sphinx_rtd_theme.  sphinx_rtd_theme does this using some JS magic and I found hack to make it work for our theme, but this hack does not work if we have RTD's (Beta) Addons enabled, which we do for plasmapy.
I tried implementing Addon's tag readthedocs-embed-flyout to inject the flyout, but this is poorly documented and does not appear to do anything during my prototyping.
Question: Do we want to live with the flyout location and continue with implementing plasmapy_theme into plasmapy?  I think we should at least deploy plasmapy_sphinx as is.

@namurphy I think I have all the last changes needed from the migration from plasmapy. However, I've discovered an "issue" that is too big of a rabbit hole to try to "fix" at this time. This rabbit hole is associated with the version flyout menu.

Another Sphinx rabbit hole with a dragon in it... 🐰 🕳 🐉

Question: Do we want to live with the flyout location and continue with implementing plasmapy_theme into plasmapy? I think we should at least deploy plasmapy_sphinx as is.

This is preserving the status quo, I think?  I agree we should deploy plasmapy_sphinx as is, and save the fixes to this problem for later.

Also I'm planning on doing a release tomorrow or Wednesday (the deadline for including the newest version in the Python in Heliophysics Community summer school).  Would it be okay to merge the full removal of plasmapy_sphinx after I do that release?  I'm thinking it'd be safer to delay it in case this change causes any more Sphinx rabbit dragon holes... (or maybe Sphinx rabbit hole dragons?)

Yes, go ahead and release plasmapy without the removal of plasmapy_sphinx.

Question: Do we want to live with the flyout location and continue with implementing plasmapy_theme into plasmapy? I think we should at least deploy plasmapy_sphinx as is.

This is preserving the status quo, I think? I agree we should deploy plasmapy_sphinx as is, and save the fixes to this problem for later.

Yes and no.  Yes, this is how the flyout has behaved for non-sphinx_rtd_theme's since the beginning of time. No, we have been using sphinx_rtd_theme in plasmapy, so our flyout will change locations when we implement plasmapy_theme.


episode_rewards in the RL demo

A quick question. When I'm using the code to do some preliminary RL experiment, I found these in the main.py.
            # FIXME: works only for environments with sparse rewards
            for idx, eps_done in enumerate(done):
                if eps_done:
                    episode_rewards.append(reward[idx])

Does this only used to collect episode reward to show statistics and have nothing to do with the training part?
Does the FIXME means it intends to collect the accumulated reward of the whole episode just ended but currently it assume the reward at last step is the accumulated reward?
Thanks!

This only affect success rate statistics

Great, thanks! Close this now.


simple-index reading code never freshens

It looks like there's a bug in is_index_filename -- should be checking for empty string, not None.

Fixed by https://github.com/python-packaging/honesty/commit/041ecca6fa539417ad0aca3da3ba02025037d473


Can the “app” in the resource path not be mandatory?

Is there any reasons to set the "app" in the resource path mandatory?

@chenjiangshuo if you're using the bootstrap, you need to use the app folder that will contain your html/css/js files. But if you do not wish to use the bootstrap which is totally possible, you don't need to add an app folder.
Does that answer your question?

@asticode Okay, I got it. Thanks

@asticode phew! It took me hours to debug this and end up here! 😃
May I suggest posting this requirement conspicuously in the readme?  As a newcomer, it is not at all obvious!
Many thanks for this wonderful project!
Bien à vous,
Louis

@lthibault you're right, I've updated the README. Feel free to submit a PR if you feel the explanation is still not clear enough

Great, thanks!


Update dist & support objects which do not have Object as prototype

Updating dist and then adding support and tests for objects which do not have Object as their prototype (Express.js res.locals to name one)..

Thanks for the clean PR! Released as v3.1.3.

Thanks for the prompt reply. Glad to help.


[Scheduled Maintenance] Site and bot down for Maintenance

Additional context
working on audio playback and also server updates

and back


Use IAsyncEnumerable for HTTP requests/responses

ASP.NET Core 6.0 supports returning IAsyncEnumerable<T> in an OkObjectResult. The enumerable values are returned to the caller via server streaming (HTTP/2+) or chunking (HTTP 1.1). Given that most adapter feature methods return IAsyncEnumerable<T> it makes sense to stream these back via HTTP rather than buffering the values on the server-side and sending them back as a unary response.
At the client-side, JsonSerializer supports deserializing an IAsyncEnumerable<T> from a stream via its DeserializeAsyncEnumerable method, so this also removes the need for buffering and deserializing the entire response in one go.

Still to do:

Configuration changes (requires new controller + client + proxy feature impl)
Tag value subscriptions
Topic-based event message subscriptions

Last two items use bidirectional streaming to allow subscription changes - need to consider if a mechanism for making changes is required at server side, or if client should just make one call per tag/topic and cancel when the tag/topic is removed from the subscription at the proxy side.

Long-running streams such as snapshot subscriptions are not really viable due to the way that System.Text.Json buffers and deserializes bytes when deserializing to an IAsyncEnumerable (details).

Ultimately, a sensible way to resolve the streaming issue is to allow the HTTP proxy to use the SignalR client specifically for subscriptions.


Override ShooterGameMode DefaultGame.ini Value doesn't propogate to ./Saved/Config/Game.ini or ./Game//Config/Game.ini

Been trying to figure out the overrides for Game.ini and doesn't seem to be propegating to the config files when you launch the server. I am not sure if I understand how this should work. But this has been my guess so far.
Below is the global json and the specific server i've done the override to. Both ..\Saved\Config\WindowsServer\Game.ini and ..\Saved\22\Config\WindowsServer\Game.ini are empty even after multiple restarts of the server.
{
  "BaseServerArgs": "",
  "gridSize": 1400000.0,
  "MetaWorldURL": "",
  "WorldFriendlyName": "NOT COMPLETE JSON SERVER",
  "WorldAtlasId": "123456777",
  "AuthListURL": "",
  "WorldAtlasPassword": "",
  "ModIDs": "",
  "MapImageURL": "",
  "totalGridsX": 5,
  "totalGridsY": 5,
  "bUseUTCTime": true,
  "columnUTCOffset": 0.0,
  "Day0": "2019-02-21 01:00:00",
  "globalTransitionMinZ": 0.0,
  "AdditionalCmdLineParams": "",
  "OverrideShooterGameModeDefaultGameIni": {
    "PerLevelStatsMultiplier_Player[0]": "3",
    "PerLevelStatsMultiplier_Player[1] ": "3",
    "PerLevelStatsMultiplier_Player[7] ": "3",
    "PerLevelStatsMultiplier_Player[10] ": "3",
    "PerLevelStatsMultiplier_Player[11] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[0] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[1] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[3] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[4] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[7] ": "3",
    "PerLevelStatsMultiplier_DinoTamed[8] ": "3",
    "XPMultiplier": "2",
    "HarvestAmountMultiplier": "3",
    "TamingSpeedMultiplier": "2",
    "KillXPMultiplier": "1",
    "HarvestXPMultiplier": "1",
    "CraftXPMultiplier": "1",
    "GenericXPMultiplier": "1",
    "SpecialXPMultiplier": "1",
    "PlayerDefaultNoDiscoveriesMaxLevelUps": "125"
  },
  "globalGameplaySetup": "(QuestEntries=((QuestID=0,CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Icon_PowerStonesQuest_Complete.Icon_PowerStonesQuest_Complete',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Icon_PowerStonesQuest_Uncomplete.Icon_PowerStonesQuest_Uncomplete',QuestName=\"Voyage of Power\",QuestDescription=\"Journey across the ATLAS to hunt for the Power Stones, and then bring them to the Center Maw!\",UnlockFeatNames=(\"Dance10\"),QuestPointsOfInterest=((PointOfInterestID=0,PointOfInterestName=\"Power Stone 1\",UnlockFeatNames=(\"Dance1\"),WorldMapPosition=(X=0.765714,Y=0.963333),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon.Item_InfinityGem_Icon',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=1,PointOfInterestName=\"Power Stone 2\",UnlockFeatNames=(\"Dance2\"),WorldMapPosition=(X=0.555714,Y=0.232857),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon2.Item_InfinityGem_Icon2',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=2,PointOfInterestName=\"Power Stone 3\",UnlockFeatNames=(\"Dance3\"),WorldMapPosition=(X=0.021746,Y=0.227069),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon3.Item_InfinityGem_Icon3',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=3,PointOfInterestName=\"Power Stone 4\",UnlockFeatNames=(\"Dance4\"),WorldMapPosition=(X=0.953886,Y=0.464009),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon4.Item_InfinityGem_Icon4',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=4,PointOfInterestName=\"Power Stone 5\",UnlockFeatNames=(\"Dance5\"),WorldMapPosition=(X=0.770000,Y=0.569524),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon5.Item_InfinityGem_Icon5',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=5,PointOfInterestName=\"Power Stone 6\",UnlockFeatNames=(\"Dance6\"),WorldMapPosition=(X=0.230265,Y=0.551268),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon6.Item_InfinityGem_Icon6',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=6,PointOfInterestName=\"Power Stone 7\",UnlockFeatNames=(\"Dance7\"),WorldMapPosition=(X=0.965238,Y=0.752857),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon7.Item_InfinityGem_Icon7',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=7,PointOfInterestName=\"Power Stone 8\",UnlockFeatNames=(\"Dance8\"),WorldMapPosition=(X=0.510617,Y=0.768677),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon8.Item_InfinityGem_Icon8',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/Item_InfinityGem_Icon10.Item_InfinityGem_Icon10'),(PointOfInterestID=8,PointOfInterestName=\"Power Stone 9 - Ghost Ship Route\",UnlockFeatNames=(\"Dance9\"),WorldMapPosition=(X=0.266455,Y=0.943280),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/HUD_GhostShip_Icon_Complete.HUD_GhostShip_Icon_Complete',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/HUD_GhostShip_Icon.HUD_GhostShip_Icon'),(PointOfInterestID=9,PointOfInterestName=\"Bring all 9 Power Stones to Center Maw\",WorldMapPosition=(X=0.503693,Y=0.508595),CompletedIcon=Texture2D'/Game/Atlas/UI/Icons/HUD_BossLocation_Icon_Complete.HUD_BossLocation_Icon_Complete',UncompletedIcon=Texture2D'/Game/Atlas/UI/Icons/HUD_BossLocation_Icon.HUD_BossLocation_Icon')))))",
  "coordsScaling": 0.00015,
  "showServerInfo": false,
  "showDiscoZoneInfo": true,
  "showShipPathsInfo": false,
  "showIslandNames": false,
  "alphaBackground": true,
  "showBackground": true,
  "showForeground": true,
  "backgroundImgPath": "./WaterTiles/instinctworld-autoscaling.png",
  "discoZonesImagePath": "Resources/discoZoneBox.png",
  "servers": [
      {
      "gridX": 2,
      "gridY": 2,
      "MachineIdTag": "DADSARMY22C3",
      "ip": "<IP_ADDRESS>",
      "name": "Tropical Freeport",
      "port": 0,
      "gamePort": 12000,
      "seamlessDataPort": 27000,
      "isHomeServer": true,
      "AdditionalCmdLineParams": "",
      "OverrideShooterGameModeDefaultGameIni": {
        "bDontUseClaimFlags": "1",
        "NoClaimFlagPeriodDecayMultiplier": "4",
        "bClampHomeServer": "false"
      },
      "floorZDist": 0,
      "utcOffset": 0,
      "transitionMinZ": 0,
      "GlobalBiomeSeamlessServerGridPreOffsetValues": "(BiomeZoneName=\"Tropical At Land\",PreOffsetMaxDistanceFromShore=100000.000000,PreOffsetTemperatureMultiplier=1.350000,PreOffsetTemperatureMultiplierMaxDistanceFromShore=1.200000,PreOffsetTemperatureAdditionMaxDistanceFromShore=2.000000,PreOffsetTemperatureAddition=6.000000,PreOffsetTemperatureExponent=1.000000,PreOffsetTemperatureExponentMaxDistanceFromShore=1.000000,BiomeZoneNameAltDistanceName=\"Tropical Open Water\",BiomeZoneNameAltDistanceAmount=0.000000)",
      "GlobalBiomeSeamlessServerGridPreOffsetValuesOceanWater": "(BiomeZoneName=\"Tropical Ocean Water\",PreOffsetMaxDistanceFromShore=17500.000000,PreOffsetTemperatureMultiplier=1.400000,PreOffsetTemperatureMultiplierMaxDistanceFromShore=1.250000,PreOffsetTemperatureAdditionMaxDistanceFromShore=-25.000000,PreOffsetTemperatureAddition=3.000000,PreOffsetTemperatureExponent=1.000000,PreOffsetTemperatureExponentMaxDistanceFromShore=1.000000,BiomeZoneNameAltDistanceName=\"Tropical Deep Ocean\",BiomeZoneNameAltDistanceAmount=0.500000)",
      "OceanDinoDepthEntriesOverride": "",
      "oceanFloatsamCratesOverride": "",
      "treasureMapLootTablesOverride": "",
      "oceanEpicSpawnEntriesOverrideTemplateName": "",
      "NPCShipSpawnEntriesOverrideTemplateName": "",
      "regionOverrides": "(SoundOverrides=(NavalCombatMusicDay=SoundWave'/Game/Atlas/Music/ATL_SeaCombatJungleDay_v1.ATL_SeaCombatJungleDay_v1',NavalCombatMusicNight=SoundWave'/Game/Atlas/Music/ATL_SeaCombatJungleNight_v1.ATL_SeaCombatJungleNight_v1',CombatMusicDay=SoundWave'/Game/Atlas/Music/ATL_LandCombatJungleDay_v1.ATL_LandCombatJungleDay_v1',CombatMusicNight=SoundWave'/Game/Atlas/Music/ATL_LandCombatJungleNight_v1.ATL_LandCombatJungleNight_v1',CombatMusicDay_Heavy=SoundWave'/Game/Atlas/Music/ATL_LandCombatJungleDay_v1.ATL_LandCombatJungleDay_v1',CombatMusicNight_Heavy=SoundWave'/Game/Atlas/Music/ATL_LandCombatJungleNight_v1.ATL_LandCombatJungleNight_v1',Sound_TransitionToMorning=SoundWave'/Game/Atlas/Stingers/ATL_Sting_JungleMorning.ATL_Sting_JungleMorning',Sound_TransitionToMidDay=SoundWave'/Game/Atlas/Stingers/ATL_Sting_JungleNoon.ATL_Sting_JungleNoon',Sound_TransitionToNight=SoundWave'/Game/Atlas/Stingers/ATL_Sting_JungleNight.ATL_Sting_JungleNight',Sound_SetSail=SoundWave'/Game/Atlas/Stingers/ATL_Sting_JungleSetSail.ATL_Sting_JungleSetSail',Sound_Respawn=None,Sound_CreateNewCharacter=None),bDisableClaimFlags=False)",
      "waterColorR": 0.12,
      "waterColorG": 0.63,
      "waterColorB": 0.7,
      "skyStyleIndex": 4,
      "ServerCustomDatas1": ",NPCShipDifficultyMult,NPCShipDifficultyLerp,NPCShipNumMult,FloatsamQualityMultiplier,TreasureBottlesEnabled,DisableClaimFlags,ChanceForCold,",
      "ServerCustomDatas2": ",1.0,0.5,0.5,1.4,0.0,1.0,0,",
      "ClientCustomDatas1": ",OceanDepthFadeExponent,",
      "ClientCustomDatas2": ",-0.6,",
	  }
  ]

This is how I have been thinking it works:
Level 1: ShooterGame/Config/DefaultGame.ini, DefaultGameUserSettings.ini
Level 2: ShooterGame/Saved/Config/WindowsServer/Game.ini, GameUserSettings.ini    (Comes from json)
Level 3: ShooterGame/Saved/<gridXY>/Condig/WindowsServer/Game.ini, GameUserSettings.ini (Comes from json)

ServerGrid.json global OverrideShooterGameModeDefaultGameIni will write its config to Level 2.
ServerGrid.json server specific OverrideShooterGameModeDefaultGameIni will write its config to Level 3.

level 3 prioritized over level 2, level 2 prioritized over level 1.

because the second portion of code you are trying to import is not supported in that location of the Json player overrides like engram points are changed in the server override section of that clusters map partition, majority of the default ini will not acknowledge specific ini overrides.

because the second portion of code you are trying to import is not supported in that location of the Json player overrides like engram points are changed in the server override section of that clusters map partition, majority of the default ini will not acknowledge specific ini overrides.

Is there any information on what is permitted where? Like my second comment states they should all be overridden by being written to the Saved folder configs right?

well the editors code is Json and C# so you have to place the correct code in the correct area when you open the server grid editor open that grids section open in the server override section for the grid you want to adjust and place the code override in the left box and the value in the right. if you are changing engrams for server wide then just leave the code in the game.ini as is for

"OverrideShooterGameModeDefaultGameIni":
"PerLevelStatsMultiplier_Player[0]": "3",
"PerLevelStatsMultiplier_Player[1] ": "3",
"PerLevelStatsMultiplier_Player[7] ": "3",
"PerLevelStatsMultiplier_Player[10] ": "3",
"PerLevelStatsMultiplier_Player[11] ": "3",
"PerLevelStatsMultiplier_DinoTamed[0] ": "3",
"PerLevelStatsMultiplier_DinoTamed[1] ": "3",
"PerLevelStatsMultiplier_DinoTamed[3] ": "3",
"PerLevelStatsMultiplier_DinoTamed[4] ": "3",
"PerLevelStatsMultiplier_DinoTamed[7] ": "3",
"PerLevelStatsMultiplier_DinoTamed[8] ": "3",
"XPMultiplier": "2",
"HarvestAmountMultiplier": "3",
"TamingSpeedMultiplier": "2",
"KillXPMultiplier": "1",
"HarvestXPMultiplier": "1",
"CraftXPMultiplier": "1",
"GenericXPMultiplier": "1",
"SpecialXPMultiplier": "1",
"PlayerDefaultNoDiscoveriesMaxLevelUps": "125"

Otherwise have the changed values in that specific grid and the game will default to the grids code when different. So for my server I set it to PVE but then had the override for PVP in the map grid so freeport is not contested and the cardinal directions are my lawless for a 3x3. though I have flags enabled in the defaultgame.ini the FP and lawless are set to not allow claimflags and when in game the warning pops up for cannot place flag in freeport or lawless

if your using a 3rd party hosting they tend to inject into the Jason and can sometimes overright the Jason variables

This one should end up in ./Saved/Config/WindowsServer as far as I know.

This one should go to /Saved//Config/WindowsServer

I am not using any third party. Have a simple batch script to start the servers.
timeout 5
taskkill /F /im ShooterGameServer.exe
timeout 5
C:\atlas\steamcmd.exe +runscript atlas.txt
timeout 2
echo.
set atlaspath="C:\atlas\steamapps\common\ATLAS Dedicated Server\ShooterGame\Binaries\Win64"
echo Starting ATLASSERVER.exe
cd /d %atlaspath%

timeout 10
start ShooterGameServer.exe Ocean?ServerX=0?ServerY=0?AltSaveDirectoryName=00?RCONPort=16060?RCONEnabled=True?MaxPlayers=55?ReservedPlayerSlots=5?ServerAdmin<password>=<password>?QueryPort=10060?Port=12060?SeamlessIP=<Host IP> -log -server -culture=en
timeout 10
...
...
...
timeout 10
start ShooterGameServer.exe Ocean?ServerX=4?ServerY=4?AltSaveDirectoryName=44?RCONPort=16120?RCONEnabled=True?MaxPlayers=55?ReservedPlayerSlots=5?ServerAdmin<password>=<password>?QueryPort=10120?Port=12120?SeamlessIP=<Host IP> -log -server -culture=en
exit

try moving your overrides to the defaultgame.ini file for engram points itself where there other overrides that where not working?

I am aware that I can move them and manually add them to the files. This issue is however for the possibility to make it work as advertised in the application.
As far as I understand the program and how the *.ini files inherit from each other and which take priority the way it should work.

Yeah the default.ini seems to take priority sometimes on some code and not others still trying to get a response from dev team on an issue with a power stone island the map file seems to be outdated and missing the cave for the 2nd powerstone and was left unfinished in the editor release

https://discord.gg/nUPzNUn come to this discord, let's not clutter this issue with posts that aren't related.
** DELETE THIS COMMENT **

Is there a way to add all quest lines/logs to the json file

Is there a way to add all quest lines/logs to the json file

No
On Tue, Jan 26, 2021 at 4:40 PM smallville11278<EMAIL_ADDRESS>wrote:

Is there a way to add all quest lines/logs to the json file
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GrapeshotGames/ServerGridEditor/issues/70#issuecomment-767870138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPE4Q7SK2QJNTYQNVQV3YLS347LNANCNFSM4GZY6YFA
.

No
On Tue, Jan 26, 2021 at 4:40 PM smallville11278<EMAIL_ADDRESS>wrote:

Is there a way to add all quest lines/logs to the json file
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GrapeshotGames/ServerGridEditor/issues/70#issuecomment-767870138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPE4Q7SK2QJNTYQNVQV3YLS347LNANCNFSM4GZY6YFA
.


Easier way of toggling on/off the extension?

Thanks again for the great extension. I feel like stepped thinking is really the future of AI, so may as well start now. I've used this for a few days now and the only thing I really think is needed is a way to toggle it easier, or an option to selectively decide when to fire off a stepped-thinking prompt.
Stepped-thinking currently hijacks the /trigger message system, so the only way to disable it is to go into the menu and toggle off the checkbox (let me know if I've overlooked another method).
Stepped-thinking probably isn't needed for literally every msg, and because it slows down prompt ingestion speed (about 2x by my estimates), there's a few times I just don't want to do stepped-thinking. For example, a char's plans or thinking aren't going to change dramatically every message, so I'd rather try stepped-thinking maybe every other message or so.

I am glad you like the extension! I plan to implement the "On-Click" mode to address this issue as soon as I finish working on the swipes. For now, I would recommend you this workaround to create a QR button for thoughts generation: https://github.com/cierru/st-stepped-thinking/wiki/Creating-a-button-to-generate-thoughts-on-demand


linter status doesn't update until save

After running a build, my linter status bar doesn't update with the results until I save the buffer. Is this an issue on build-tools-cpp or with Linter?

Awesome, thanks for the quick response!
As of 2.0.6 it seems to update if the build fails, but if the build succeeds the errors and highlighting disappear but the status bar at the bottom still shows there are issues. Maybe this is a bug with Linter partially updating?

I ran a few tests and it appears that there are issues on both sides. It'll be fixed with the next update (v3.0.0).

I changed almost everything related to error highlighting and the bug magically disappeared. I don't know how (maybe Linter had bugs too) but I can't reproduce the issue so I guess it's fixed (?)


policy: drop client side validation of policies

Both cilium policy import and cilium policy validate use client side validation of policies - meaning they both run r.Sanitize() without being able to properly check cilium-agent's configuration flags. This can result in being unable to validate/import policy that uses a field (like fromNodes, toNodes) which is not enabled by default.
This can also be a problem when we do ./check-examples.sh in documentation.
Let's fix this by not doing any client side validation and rely only on the server side validation.
policy: drop client side validation of policies in policy import/validate command

I ran into this problem when in this PR https://github.com/cilium/cilium/pull/31188.
Related slack thread: https://cilium.slack.com/archives/C2B917YHE/p1709720825271219

oh, just noticed the failed Check generated documentation which runs only the docs-builder image which doesn't seem to be a full agent :(

now wondering if it makes sense in a long-term to do examples validation.. (if there are more examples of policies that are behind a flag)..?

Marking as draft while a solution is found. When it's ready for a fresh look, click the "Ready for review" botton at the bottom of the page.

/test

hitting this: https://github.com/cilium/cilium/issues/32715

/ci-runtime


Custom views: Left padding of the tree items is large

Issue Type: Bug
Since the change to the new tree, the left padding of the root nodes is quite large:

//cc @alexr00
VS Code version: Code - Insiders 1.37.0-insider (9296aaa2201b638e2b1dc71a9b9fe38c5ab2e904, 2019-07-09T05:26:27.407Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (17.89GB free)

Process Argv

Screen Reader
no

VM
0%

Well this is strange. I'm seeing the opposite, with 12px on the old tree and 8px on the new tree. I went back to the commit your on and saw the same 8px.

Hrm, with the old I'm seeing 12px total, but with the new tree, the row is padded by 20px and then the twistie is another 8px.

And that is with today's insiders.
Version: 1.37.0-insider (user setup)
Commit: 360e4e4dfa989135f28edc0d6f7e42df33cddf87
Date: 2019-07-10T05:26:12.322Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Somewhat related, I also noticed that workbench.tree.indent doesn't affect the custom trees (nor the SCM ones)

Something strange is happening here. I see the workbench.tree.indent setting affect custom trees correctly. Can you share your user and workbench settings?

Nevermind, this was my confusion -- the workbench.tree.indent doesn't affect the root nodes -- only children. All is fine, sorry :)

Are you still seeing the extra padding to the left of the root node?

Yes - the DOM/CSS looks the same in today's as yesterday's

Can you share your user and workbench settings? I still can't reproduce this.

@alexr00 I did more digging into this, and this only happens for views that are contributed into the scm sidebar -- explorer and custom activities are fine. I see this behavior with GitLens and GitHub PRs (but only when the views are in the scm sidebar)

@alexr00 Do you need any more info on this?

No, I can repro in the scm viewlet, thanks for tracking it to there!


Cannot type date in transaction form

This is most likely caused by us attempting to parse the date for every keystroke.

Fixed in #185.


Spring Cloud AWS SQS - some messages do not get acknowledged

Type: Bug
Component:
SQS
Describe the bug
JDK:17
spring-cloud-aws-dependencies : 3.1.0
org.springframework.boot: 3.2.2
When using BatchingAcknowledgementProcessor some messages do not get acknowledged and end up in a dead letter queue even if the processing went without any errors. Looking at the trace logs it seems that there is some race condition between purging acksBuffer  and adding new items to it:
Jan 24, 2024 @ 20:09:37.170 Received message ${messageId} to ack in io.awspring.cloud.sqs.sqsListenerEndpointContainer#2-0.
Jan 24, 2024 @ 20:09:37.170 Removing groups [default] from buffer in io.awspring.cloud.sqs.sqsListenerEndpointContainer#2-0
Sample
    @Bean
    fun defaultSqsListenerContainerFactory(sqsAsyncClient: SqsAsyncClient): SqsMessageListenerContainerFactory<Any> {
        return SqsMessageListenerContainerFactory.builder<Any>()
            .configure { options -> options
                .acknowledgementMode(AcknowledgementMode.MANUAL)
            }
            .sqsAsyncClient(sqsAsyncClient)
            .build()
    }

  @SqsListener(queueNames = "queue-name")
    fun process(
        sqsMessage: SqsMessage,
        acknowledgement: Acknowledgement
    ) {
        process()
       acknowledgment.acknowledge()
    }

Thanks for reporting @anna-kr.
This is a duplicate of https://github.com/awspring/spring-cloud-aws/issues/925 so I'll close this one.
Just to make sure I understand correctly your use-case - is your queue configured to send messages to DLQ after first attempt?
Thanks.

Duplicate of https://github.com/awspring/spring-cloud-aws/issues/925.

I am not sure whether this is a duplicate as the issue does not happen during graceful shutdown. I have also observed the problem during graceful shutdown, but was able to mitigate it with delaying batch processor shutdown. Yes, the queue is configured to send messages to DLQ after first attempt.

Oh, I see, my mistake, I'll reopen then.
Can you share more details on your investigation if you have any?
Thanks.

I haven't done more investigation then what was put into description - basically that messages ending up in DLQ coincide in time with logs about purging acksBuffer. It would seem that one thread is adding a message to acksBuffer while the other purges the buffer content.

Hi @anna-kr, you were right, and there was indeed a missing part of synchronization in acknowledgement buffer access that made it possible for messages to be removed while the other thread was adding them.
I wasn't able to reproduce the issue with my tests, even testing with a few million messages and 1000 threads, but that's what racing conditions look like anyway.
If you'd like to review the PR, I should keep it open for a few days:
https://github.com/awspring/spring-cloud-aws/pull/1038
Thanks.

could you tell me when this fix is likely to be released 🙏 ?

Hi @anna-kr - not sure - I still have to go through the issue about waiting on acknowledgements on shutdown and haven't found the time yet.
But hopefully soon!


testcase for #1612

Codecov Report

Merging #1615 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1615   +/-   ##
=========================================
  Coverage     81.35%   81.35%
  Complexity     6096     6096
=========================================
  Files           136      136
  Lines         22611    22611
  Branches       5194     5194
=========================================
  Hits          18396    18396
  Misses         2943     2943
  Partials       1272     1272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd2ae7...c819040. Read the comment docs.


Add Customized license

add customized license
see details below
manually test by myself
code review with https://github.com/codecombat/codecombat-server/pull/180
when admin grant new licenses

when teacher see his/her licenses

when teacher is going to apply licenses

when license is applied

another detail

@nwinter @AndrewJakubowicz  now the typeDescription function display like this:
in chinese

in english

@codeluggage this is a good point. actually i don't understand this code well enough either. but i find if we want to assign a uncoverd course to both a customized-license student and a full-license student, both of assignment will failed. I think i should take a detail look into these codes.

@codeluggage okay. i have to say about the TeacherClassView.coffee:assignCourse current logic have some differece with before.
now things change to this:
if we find the students' prepaid doesn't contains the course we want to assign. we will find out all available license teacher has (include full-license, starter-license, customized-license) to see if we can replace the license for these students. if the teacher has enough licenses, then everything goes on.   // these part doesn't change much, only add the customized-license to see if this license can handle the new course;
but if the teacher doesn't have enough licenses. things changed:
>>>>>>origin one
if the course is a starter-license-course, we will sometimes advise the teacher to purchase more starter-license, or full-license.
if the course is not a starter-license-course, we will advise the teacher to purchase more full-license.
it is a clear logic
<<<<<<now
if the course is a starter-license-course, we will sometimes advise the teacher to purchase more starter-license, or full-license.
if the course is not a starter-license-course, we will advise the teacher to purchase more full-license.
yes, nothing about our advise has changed. we will not advise the teacher to purchase more customized-license because this will be complicated
>>>>>>> end
what will be a little confusing is, if teacher has enough customized license, students will be auto assigned correct customized license, but if not, teacher will be only advised purchasing full license (skip the customized license here).
am i clear ? can this logic be accepted ? all issues are about how we show purchase advise to teacher. nothing break our website.


Missing languages and editors legend

First, thanks for making this software, it's great!
Sorry if this is duplicate or if this is not the place to ask the question, feel free to delete if that is so.
I seem to be missing the legend that tells me what color is what IDE and Languages in the pie graphs.

It was there the first days I used the application, but now it is gone.
Is it because of the fact that it registered too many languages/file extensions?
Thanks in advance!

The legend is disabled with many languages, because it doesn't fit on the screen.

And how can i remove some of my languages?

You could rename them with Custom Rules:
https://wakatime.com/settings/rules

Thanks for the answer, I managed to get it back after adding some of rules. You can consider the Issue solved.

Ok, thanks for circling back!


Cant autocraft with redstone bucket

Issue description:
The system does not recognize a Redstone bucket
What happens:
If I want to make any recipe with a Redstone Bucket for auto crafting, he says the bucket is missing. But with a waterbucket everything works. I didnt test any further fluids.
What you expected to happen:
That i can autocraft with redstone buckets
Steps to reproduce:

Create a recipe which use a redstone bucket
Insert a redstone bucket into the system
Try to craft the recipe
Wonder why the system tells you there is a redstone bucket missing

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>36
Refined Storage: 1.6.15

Does this issue occur on a server? yes

Disable Oredict on the recipe that uses the bucket.

Unbelievable i didnt try this on my own. Thanks for helping. But this is still a bug isnt it? Or is this intended?

Known bug. Duplicate of #2122


New @formname directive attribute emits code in the wrong place

We discovered an issue where @formname emits the AddNamedEvent call in an incorrect place, leading to forms being broken in current RTM builds. It's likely this is due to the original spec for @formname not giving details about this.
Repro
<form @formname="myform" class="nice">
<EMAIL_ADDRESS></form>

Expected compiler output (simplified):
__builder.OpenElement(5, "form");
string __formName = RuntimeHelpers.TypeCheck<string>("myform");
__builder.AddAttribute(6, "class", "nice");
__builder.AddNamedEvent("onsubmit", __formName);
__builder.OpenElement(7, "p");
__builder.AddContent(8, DateTime.Now);
__builder.CloseElement();
__builder.CloseElement();

Actual compiler output (simplified):
__builder.OpenElement(5, "form");
string __formName = RuntimeHelpers.TypeCheck<string>("myform");
__builder.AddAttribute(6, "class", "nice");
__builder.OpenElement(7, "p");
__builder.AddContent(8, DateTime.Now);
__builder.CloseElement();
__builder.AddNamedEvent("onsubmit", __formName);
__builder.CloseElement();

That is, the AddNamedEvent call must appear after the element's attributes, but before its children. Or you could think of it that named events are a special form of attribute and must be emitted at the end of the attribute list.
It's essential not to emit them after child content, because the runtime is building a flat list of rendertree frames (imagine it's writing to successive indices in a Span<RenderTreeFrame>), and once it's started appending children, it can't go back and insert further attributes/namedevents for the parent (there's no more space).
This probably also explains many or all of the test failures in https://github.com/dotnet/aspnetcore/pull/50734 that are currently blocking the dotnet/aspnetcore repo from accepting SDK updates,

@mkArtakMSFT this came up in discussion today -- in what circumstances will form posts not hit this. Sounds like there's not a workaround per-se but perhaps there's value in identifying when forms will work, if you're willing to modify the content. Is there anything useful we can share about that, eg., and maybe edit the RC2 blog post to add that info?
Of course 4 weeks from now this won't matter any more.
cc @danroth27 @DamianEdwards

@mkArtakMSFT this came up in discussion today -- in what circumstances will form posts not hit this. Sounds like there's not a workaround per-se but perhaps there's value in identifying when forms will work, if you're willing to modify the content. Is there anything useful we can share about that, eg., and maybe edit the RC2 blog post to add that info?
Of course 4 weeks from now this won't matter any more.
cc @danroth27 @DamianEdwards

After some further discussion we do have a workaround and are updating the blog post to recommend it for time-being.
For customers who will stumble upon this issue using EditForm instead of form will avoid the issue.

@mkArtakMSFT Possible this is causing this issue though https://github.com/dotnet/aspnetcore/issues/51302#issue-1938612540 ?

Thanks all for your patience while we got a workaround for this issue ready to go. We've published a toolset razor compiler package that can be installed to fix the build from the command line. Add this reference to the csproj of your project:
<PackageReference Include="Microsoft.Net.Compilers.Razor.Toolset" Version="7.0.0-preview.23512.5">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

Make sure to remove this package after you upgrade to the next version of .NET 8: it's only needed for RC2 due to our fixes for this issue not quite making the final build.


Fix issue where table header text overlaps with cell text

Fixes #436.

Before
After

I can make it even more opaque, if you prefer.

Awesome!


DatabaseOpener custom parameters

I want to use MoorIsolate, I need to distinguish the path of the database.
But MoorIsolate.spawn(DatabaseOpener opener), DatabaseOpener doesn't take parameters
Is there any solution?

That's a bit more complicated unfortunately. The approach is documented here. Basically, you'll

create your own isolate entrypoint taking the path as a parameter
inside that entrypoint, use MoorIsolate.inCurrent
spawn a new Isolate with that entrypoint, which effective creates a background MoorIsolate
send the MoorIsolate instance through a SendPort, so that you can use it in the main isolate

That's a bit more complicated unfortunately. The approach is documented here. Basically, you'll

create your own isolate entrypoint taking the path as a parameter
inside that entrypoint, use MoorIsolate.inCurrent
spawn a new Isolate with that entrypoint, which effective creates a background MoorIsolate
send the MoorIsolate instance through a SendPort, so that you can use it in the main isolate


Remove no longer revelant files from scripts directory

From a quick review, the following files in the scripts directory can/should be removed:
https://github.com/bigdatagenomics/adam/blob/master/scripts/create-thirdparty-repo.sh
https://github.com/bigdatagenomics/adam/blob/master/scripts/contextutil-converter.sh
https://github.com/bigdatagenomics/adam/blob/master/scripts/adam-console.sh
https://github.com/bigdatagenomics/adam/blob/master/scripts/scala-console.scala
https://github.com/bigdatagenomics/adam/blob/master/scripts/jenkins-test

jenkins-test is used by @AmplabJenkins, all the others look good to remove.

Some of the references might need to be updated then (Spark 1.1.0, Hadoop 2.3), e.g.
https://github.com/bigdatagenomics/adam/blob/master/scripts/jenkins-test#L30
https://github.com/bigdatagenomics/adam/blob/master/scripts/jenkins-test#L34

+1 to that.

@fnothaft I checked the ADAM Jenkins configuration and I don't see jenkins-test being used. It's just a mvn clean package. Where is it used?

@massie jenkins-test runs in an execute shell stage after the mvn clean package.

Aha! I missed it inside the if (2.10) clause at the end. Does that mean that we only run the jerkins-test for 2.10 and not 2.11?

Correct; Spark does not provide pre-built packages for Scala 2.11 (they do provide maven artifacts for 2.11 though).

Closed by #724


New Detection: Suspicious Browser Extension/General Analysis

We should perform some type of basic checks across installed browser extensions to hunt for known-suspicious items or just perform a general review of installed extensions with associated metadata, hashes, etc.

I am implementing this with general logic examining the following 3 items:

Risky Permissions in an Extension Manifest per Chrome's own documentation for High Risk Permissions
Risky domain access in Host Permissions
(TODO) - General JS analysis looking for high-risk terms/logic


Display static code metrics in Html Format

Can we export static code metrics results in html format. Or do we have plan to upgrade metrics.exe version to create html report along with xml file. Secondly do we have plan for keeping history of results with subsequent changes in the codebase.

@eraj2587 There are no planned work items for this. Feel to create an issue here: https://github.com/dotnet/roslyn-analyzers/issues/new.


jackson-databind False Negative

False negative on library
<dependency>
    <groupId>com.fasterxml.jackson.core</groupId>
    <artifactId>jackson-databind</artifactId>
    <version>2.9.2</version>
</dependency>

the CVE-2018-5968 affect  version 2.8.11 and 2.9.x through 2.9.3

Same false negative issue with databind mircofix <IP_ADDRESS>
<suppress>
    <!-- databind micro fix <IP_ADDRESS> is the official fix for the CVEs -->
    <notes><![CDATA[
      file name: jackson-databind-<IP_ADDRESS>.jar
      ]]></notes>
    <cve>CVE-2017-17485</cve>
    <cve>CVE-2018-5968</cve>
</suppress>

It seems that the CVE has not been associated with the CPE's for 2.9.x: link

This may also be due to the data in the XML data feeds as opposed to the JSON data feeds. See https://github.com/jeremylong/DependencyCheck/issues/1088.
Thanks for the report and I'll try to get to this soon.

This was resolved with 6.x


qb: custom tags

@WillMcDGSK  please review.

There are some .debug updates to support python 3.8.15 upgrade
Some minor comments to functions
Support of providing custom tags in the query builder - this might be useful in the future for data provider (e.g. if querying ACAT class, but tagging it as ACAT1/2)

@paltusplintus I have reverted the changes from Shannon's branch but have kept the updates to logging

closing as it is irrelevant, will redo the tagging functionality later


ADD branches cleanup script

Issue: -we sometimes leave merged branches around-
What I did
I added a script to remove them
How to test
Run script:
./scripts/clean-merged-branches.sh

Will list the branches
Run script:
./scripts/clean-merged-branches.sh -f

Will remove listed branches from remote

tried to test it. always get no merged branches detected

Yeah, because i already removed all the merged branches using this 😃

Great script, Norbert!
I noticed that it missed the branch remotes/origin/Gongreg/master, but we can remove it manually :)
I added two test/* branches (one is merged to another) and it missed them as well, but I can detect them by git branch -a --merged so not sure how to handle such cases

It doesn't work if the origin is named other than origin (in my case  it's upstream). I think I can rename though

I changed "Run with '-f' if you're sure" to "Press 'y' if you're sure"


Create a Patreon or Gratipay page for Mail for Good ?

We can send all the donations we get to FreeCodeCamp directly

@QuincyLarson and @AndrewGHC  your thoughts ?

@karuppiah7890 We could add a link to the donate page, though I don't think this is super high priority at this point.

Ah, okay. True :+1:


Procedural macros for generating MrbFile impls of Rust functions and types

Implement an attribute proc-macro based generator for MrbFile impls to allow arbitrary Rust functions and types to be loaded into an interpreter.
See https://github.com/PyO3/pyo3 for inspiration.

Rust functions should be passed an Mrb and either native Rust types or a Value.


Support reindex

Other clients for ElasticSearch supports reindexing entire index as described here: http://www.elasticsearch.org/blog/changing-mapping-with-zero-downtime/#_reindexing_your_data
It would be cool to support this flow in NEST as well.

I have a parent child index and calling reindex with object type throws a no documents exist in index exception: client.Reindex(...) -> exception
I have to reindex each type one after another; the problem becomes that if index already exist cannot use reindex() to insert other documents into it -> exception is thrown again.
Has anyone else found this behaviour?

In my opinion, the NEST implementation has too many requirements and assumptions.

You must create a new index during the reindex (can't just set it up yourself and then call re-index)
You must setup all the settings and mappings during the reindex (you can't use your method of choice for these things, and the fluent interface is not as easy as alternative methods)
The from-index must have documents

The current implementation may work for some, but for those who are looking for another way:
http://stackoverflow.com/a/34867857/2284031


std.typecons: Unittest isn't safe

It takes the address of local variables.

How did it compile before ?

Taking the address is @safe, as long as you don't escape it under -dip1000. @ibuclaw my guess is that you and the @ldc-developers didn't see this file: https://github.com/dlang/phobos/blob/0ac79f5a8214333dc58ec9774f386efda9de3fe3/dip1000.mak#L49

@ibuclaw the reason for this mess is that we can't fix everything preventing the use of -dip1000 all at once in phobos, so we decided to go with incremental approach until all modules compile. After we're done, we'll switch to all in.
Side note: this approach is not -dip1000 specific - most large scale language changes would need to follow the same incremental tactic. So in the future we need to better collaborate on such initiatives.

@wilzbach then get the library building entirely with dip1000 then.
This file is completely unworkable.
https://github.com/dlang/phobos/blob/0ac79f5a8214333dc58ec9774f386efda9de3fe3/dip1000.mak
If I read the makefile right, you're building release library without dip1000 anyway, so it's not a security issue.

@wilzbach as mentioned before, we care about the public symbols' safety, not about some random code snippets in our unittests. We use unittest to guarantee the safety our public symbols, but in this case the safety aspect of the test in question had nothing to do with the public symbol.


Not working for galleries on 500px

Galleries is the new way 500px has for curated content by the users. The old favourites have been converted now to galleries.
The URL looks like this: https://500px.com/johnstonandjohnston/galleries/favorites
ripme returns the following message: "Expected 500px gallery formats: /stories/### /stories /favorites / Got:https://500px.com/johnstonandjohnston/galleries/favorites"

The format of the link given as input is different, hence it does not match. Not a surprise.
The links to the photo pages themselves are in the usual format (https*://500px.com/photo/< ID >/< TITLE >
So this should work with some adjustment.
But the gallery you linked here apparently has 10051 photos.
This could get interesting...

If I'm not mistaken, changing line 89 would fix the favorites
p = Pattern.compile("^.*500px.com/([a-zA-Z0-9\-_]+)/__galleries/__favorites/?$");
adding galleries to the URL that's trying to recognize. But other galleries wouldn't work.

You know, if you refer directly to the source code, or to parts of it, like a single line, you can just do this:
https://github.com/4pr0n/ripme/blob/master/src/main/java/com/rarchives/ripme/ripper/rippers/FivehundredpxRipper.java#L89
Makes it a lot easier and faster to find.
Here are some example links:
https://500px.com/getesmart86/galleries/d-s
https://500px.com/chrissyone/galleries/luxembourg
https://500px.com/angmel/galleries/female-beauty
https://500px.com/alexandersavov/galleries/need-for-mirrors-l-33-high-roll
https://500px.com/alisterbenn/galleries/best-of-2015
https://500px.com/thebrianwilson/galleries/star-wars
Officially curated galleries:
https://500px.com/500px/galleries/road-trip
https://500px.com/500px/galleries/minimalism
https://500px.com/500px/galleries/slow-living
https://500px.com/500px/galleries/conceptual
So the URL format is:
https://500px.com/<USERNAME>/galleries/<GALLERYNAME>
I think that line can be changed, and the whole block, respectively, because this old url format is not working anymore, the "favorites" feature has been replaced by the galleries as it seems.
If I go here:
http://500px.com/tsyganov/favorites
I am automatically redirected here:
https://500px.com/tsyganov/galleries

So 500px changed their API but didn't change their API version.
I added support for /galleries (all galleries) and /galleries/XXX (subgalleries).
The "all galleries" URL is really slow since it has to fetch all photos from all galleries. Plus the ripper doesn't actually start the downloads until it knows all the URLs to fetch (and it finds the URLs via web requests with sleep()s), so it's, uh, slow.
But it should work. I found a small gallery to test on here: https://500px.com/getesmart86/galleries/olga
Issue should auto-close once the change is pushed & the new version is available.


Add instruction opcode constants, and a wrapper class for instructions

which knows how to debug-print instructions in disassembly style.
Compared to the gist I posted, I cleaned the macros up a little bit, changed some names to be more descriptive, and added slightly more comments :)

I've only skimmed it so far, will look into it more later; but this looks fantastic. Thanks! I'll most likely merge this on my next stream.

Now that appveyor is set up correctly, could you rebase this onto the current master?

Done! I also rebased it on top of my two smaller pull requests, since they both had conflicts with this branch.

Ah, ok. I'll merge this one and close the others then on the next stream. I'll leave them open for now in case there's any further discussion.

Added some tests, to give Travis/AppVeyor something to do :)

Hey, so I've been thinking about some of these contributions, and I've written kindof a braindump here. Would love to hear your thoughts on it: https://gist.github.com/yupferris/f8eeb712bdb068891ecd

Thanks again for this, I'm going to close it tho due to what we discussed :)


Forward port Molecule v1 shell dependency manager

Forward ported Molecule's v1 shell dependency manager to v1,
which mostly turned into a rewrite due to the differences between
v1 and v2, but :shussh: who is really looking at this message
anyway.
Fixes: #1182

I do 😬

LOL. 😄 👍


Use vscode privilege escalation mechanism for Admin Tabs?

Description of the new feature/enhancement
The idea of having 'admin' tabs has been discussed before, allowing users to quickly open a shell as administrator without having to launch a second Terminal window
It has generally concluded that OS limits within Windows make admin tabs in Terminal not a possibility.
However I'd like someone who knows more than me about this to check out vscode, when editing a file that doesn't have write permission

Would it be possible to use something like vscode's privilege escalation mechanism for Admin Tabs?
Thanks! 🙂

As discussed at length, we're not going to be mixing elevated and non elevated tabs in the same window. Just because it's something that might be possible, doesn't mean it's something that we should do.

Hi @zadjii-msft I appreciate the response! I mentioned those limits in the comment you're responding to (in heading 2 no less)! but I can clarify my question as a response to your comments you linked to:

If we start an elevated connection and host it in a non-elevated window, we've suddenly created a conduit through that security boundary

Given that vscode is a non elevated window that does privileged actions if the user allows it via UAC:

is vscode secure (in which case can terminal do the same?)
is vscode insecure (in which case we should probably raise an issue with vscode)?

I honestly don't know. I'll summon our resident vscode expert @Tyriar to weigh in on the matter. I'd presume that since VsCode is asking for elevation of a single action (the saving of a file), it's not granting the entire process the ability to drive arbitrary commandline executables. It's merely attempting to write that singular file. Presumably, they're launching another separate process that's running elevated, and that process performs the write, so that actions on the main window (unelevated) can't be used to drive the elevated process.

We use this node module to elevate processes https://github.com/jorangreef/sudo-prompt

As discussed at length, we're not going to be mixing elevated and non elevated tabs in the same window.

This is actually something that I'd like Windows users to be able to do in VS Code, since you shouldn't be launching code as admin. Maybe one day...


This commit adds generation of internal configuration file

This commit adds a generation of the internal configuration file to be ssl_enable and server_tunnig idempotent and behave correctly after state switching within multiple role runs. Currently tunning variable overwrites values in /var/lib/pgsql/data/postgresql.conf and it isn't possible to recover the default setting in the subsequent runs with switched-off tunning.
Now /var/lib/pgsql/data/postgresql.conf is not modified. Instead of modification, there is the internal configuration file for the system role.

[citest]

[citest]

[citest]

So the main config file is /var/lib/pgsql/data/pg_hba.conf - this contains the default configuration. You are changing it so that the last line is to include the system roles configuration file. Doing it this way will
* keep all of the configuration parameters set by the role in a single location

* configuration parameters set in system-roles-internal.conf will override those set in pg_hba.conf

* we can simply remove this file to revert settings to the system defaults

Is this correct so far? If so
I think that the role should completely erase and rebuild system-roles-internal.conf every time - that is, the role owns the entire contents of the file, and the user must provide the entire contents of the file every time. Then, managing the contents of the file can be done with a single template task, and the role will provide a template for the file in the templates/ directory e.g. maybe templates/system-roles-internal.conf.j2

Yes, you are right, just a small note, we discuss  /var/lib/pgsql/data/postgresql.conf but it's just for clarification.
I've changed it to a template-based solution.


Fix for snap build

Created a custom version of CTranslate2 wheel that has libctranslate2.so with stripped execstack flags. Local validation of the snap passes and it works as with the default CTranslate2 wheel file. Build notes of the custom CTranslate wheel are here. https://github.com/raivisdejus/CTranslate2-no-execstack/
For snap build to fit GitHub actions environment limits I am switching to CPU torch in the snap. That is a version that will work for every user, for users with GPUs will attempt to install GPU specific torch in a later PR.
Also removed locales-all from snap as it is not needed and takes a lot of space in snap.
Also restoring previously disabled whisper types on Linux.
This PR also includes fix for macOS build from https://github.com/chidiwilliams/buzz/pull/751

Will merge cleaned up version of this PR via https://github.com/chidiwilliams/buzz/pull/757


Some question about object detection

How is the target detection tag get in the data set obtained?

Trainig: Its obtained during rendering after calculating max.
Testing: YOLO.


cmd/update-operator: Mark manage-agent deprecated

We've updates the example manifests to always set manage-agent to false, per design discussions in #98 and #76.
Change manage-agent to default to false and show a warning when set to true since this is not the way we want to go going forward. Tectonic has a corresponding change to explicitly request the old behavior until a migration plan is ready. https://github.com/coreos/tectonic-installer/pull/1250
W0629 18:35:46.145820       1 main.go:43] use of -manage-agent=true is deprecated and will be removed in the future
I0629 18:35:46.148454       1 main.go:51] /bin/update-operator running
I0629 18:35:46.180891       1 leaderelection.go:179] attempting to acquire leader lease...

See quay.io/dghubble/container-linux-update-operator:ff0a970f751825fc4c89cee3a441ba22813067dc

@dghubble PR needs a rebase.

Rebased, smaller now.

I guess I will call out, this means Tectonic users running old CLUO who wish to update need to get the update payload which adds the flag to ensure Tectonic continues to use the deprecated mode. Users who just bump the CLUO version by hand without adding the flag will change the behavior. I suppose this is true for any Tectonic upgrade payloads though.


policy: Increment PolicyImportErrors metric more consistently

[ upstream commit c12350e50952be2ea9328ccce39b3ea334258b18 ]
Move the increments of PolicyImportErrors metric higher up in the
call stack to cover all API error conditions. Also increment
PolicyImportErrors metric from k8s policy watcher on errors.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>Added missing policy import error metrics in policy import error paths.

$ for pr in 15820; do contrib/backporting/set-labels.py $pr done 1.8; done

test-backport-1.8


Add installation instructions for installation from releases

There should be a section in the readme on how to install the binaries for windows and Linux from the releases.

Linux installation should be done via brew to ensure easy upgrades

I can work on this. can you assign it to me?


Overwrite option and MaxLength attribute in property

In my case, I spend a lot of time making changes after creating an entity by adding new properties.
For this reason I had to add this option to my fork:
add entity [/path/file.yaml] true
With this, I can overwrite the changes. In order for this to work well, in the future I need to add my personal code in partial.
It is also a lot of code that I have to write to limit the size of the text fields, I have added this option:
Entities:

Name: GeoZipCode
Features:

Type: AddRecord
Properties:
Name: AdminCode1
Type: string
MaxLength: 250   <-
CanFilter: true
CanSort: true

Sorry I'm just getting to properly look at this. Thanks for the idea!
It seems like the motivator here is to add new properties? I used to have functionality that did that without overriding the whole file, but it didn't really seem to save any dev time; it did add maintenance overhead though and was a motivator to remove it at the time. I'm considering some flows where it might more more useful though so maybe it'll make a comeback.
With this particular implementation though, I'm hesitant to bring it in as it would completely eliminate the ability to maintain any post scaffolding updates. Maybe you've added some custom helper methods, updated props to value objects, etc. This would force you to just use the boilerplate when it's not meant to be the end, just the start. Given that, I don't think this PR is a good fit for the lib but if it's working well for you're workflow in your fork that's great to hear!
With that said, adding the option for a max length would be reasonable. Personally I'm not a huge fan of using the db to enforce business rules as that should really be a domain responsibility, but that's personal preference and wouldn't add much maintenance overhead so if you'd like to submit something around that I think that's great.
Regardless, thanks again for taking the time to contribute and working to improve the tool for other devs.