How to get user info from currently logged in user.

Question and Help
I am using this library with vue in a client side application.
In version 8 I was able to get the user info with something like this:
const token = this.get_access_token_from_params(this.params) // after doing an implicit grant with a redirect
console.log("Token:", token)
await this.$spotify.login(token)
const user_info = await this.$spotify.user.info()

How would this work in version 9? From the welcome page it really seems like I need to give the client secret but this would be a bad idea as this code will be running on the client.
I got this now:
      const token = this.get_access_token_from_params(this.params)  // after doing an implicit grant with a redirect
      console.log("Token:", token)
      const userClient = await this.$spotify.create({"token": token}) // this.$spotify is new Client
      const me = userClient.user?.displayName
      console.log(me)   // This is undefined

this .user has undefined for displayName and images. It seemed really easy to get the user info in v8. What am I missing here?

Thanks for the swift reply I will try this out.

I have a question you mention that creating a client with a token like this would be simpler.
const client = await Client.create({
    token: {
        clientID: 'id', // Your spotify application client id.
        clientSecret: 'secret', // Your spotify application client secret.
        code: 'code', // The code search query from the web redirect. Do not use this field if your aim is to refresh the token.
        refreshToken: 'refreshToken', // Use this field only if your aim is to refresh your token instead of getting new one put your refresh token here.
        redirectURL: 'url' // The redirect url which you have used when redirected to the login page.
    }
});

But this would mean that I would have to store the client secret on the clients machine. Like if someone opens the vue app they could in theory get access to the client secret right?

Thanks for the update that is amazing!
I wonder though if this makes it save. Because the client secret would still be send in the code that is send to the client to be executed by the browser. What are your thoughts about that?

Thanks for the update that is amazing!
I wonder though if this makes it save. Because the client secret would still be send in the code that is send to the client to be executed by the browser. What are your thoughts about that?

No, the client secret is a temporary value in the Client constructor and only the token is saved in the Client.token property. If you want to save try to see ClientOptions.RefreshToken type in the documentation.

Ok that sounds great. But my point is that for this to work my secret needs to be somehow hardcoded into the app. Lets say the app I make is running and I fetch the html/css/javascript but I just collect the JavaScript but don't actually run it. Then someone could go trough it to find the client secret in the code.
So even if the value is temporary then it would still be there before the code is executed in the first place.
Or am I missing something here?

Ok that sounds great. But my point is that for this to work my secret needs to be somehow hardcoded into the app. Lets say the app I make is running and I fetch the html/css/javascript but I just collect the JavaScript but don't actually run it. Then someone could go trough it to find the client secret in the code.
So even if the value is temporary then it would still be there before the code is executed in the first place.
Or am I missing something here?

Well, there is no way they can access the token because i mean the token is basically a temporary memory value which is within a function (constructor).

Yeah but if they don't actually execute the javascript then they could get it.

Yeah but if they don't actually execute the javascript then they could get it.
Like if its in the code thats send but the client just decides to not execute it and just read trough it then they could find the secret.

Do you mean the token?

Yeah the client secret.

No I don't mean that I mean the client secret.

That is one of the major cons of using frontend try using an api and get the clientSecret or do this thing in the backend and send the props to the frontend.

Ok thanks.

Ok thanks.

So i guess you could close this issue as your doubts has been cleared.


Feature 14

Improvements

Added yarn.lock to .gitignore

Bugfixes

Should resolve #14

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

If you want to use loader-webpack 2.0 simply use the latest aurelia-bootstrapper package. This package will be deprecated once the loader-webpack 2.0 is official.

@niieani Sure thing, problem is that the latest aurelia-bootstrapper package out of the box doesnt use loader-webpack 2.0 but the 1.0 version.
So for example, what's supposed to be an out-of-the-box skeleton for aurelia with webpack will not work unless manually adjusting the dependencies ... ? :/

@peterver loader should no longer be a dependency for the bootstrapper, we are offloading that to the app, since you might want to use any loader depending on your bundler.
loader-webpack ^2.0 is used by this out-of-the-box skeleton, but it's not been merged yet https://github.com/aurelia/skeleton-navigation/pull/714


Unreliable mouse interaction with rope mesh

Hi, I'm trying to modify the 'strip' pixi.js example that demonstrates the rope mesh. I tried adding interactivity to the rope so that when I click it the size changes.
https://codepen.io/aatish/pen/yJPWBx
However, the click behavior seems unreliable for me. It works in some places and not in others, and I'm having trouble understanding where in the image I should be clicking for the interaction to occur. Ideally I would like the interaction behavior to happen whenever I click within the boundaries of the snake.
Thanks,
Aatish

Actually, thats not a bug. PIXI cant detect what is the size of your canvas, it must be exactly 1:1 with CSS pixel.

https://dl.dropboxusercontent.com/u/46636530/pixijs/pixi.js - that's V4 with my PR, it works.

It works perfectly! Thank you!


define a header-only lib for encoding x86 machine instructions

This is a basic system for implementing Intel's instruction encoding tables (an assembler).  It fits the x86 instruction model only, and isn't a complete compiler back-end (no inter-instruction optimization, no register allocation, etc -- just instruction encoding).
Other than the system in place, only a few instructions have definitions here.  The library is header-only, and these instruction tables can get pretty large, so it's worth considering how to keep it light but still limit compile time/space.

Now I've added a register allocator, which along with the encoding logic here makes a minimal viable compiler backend (and very lightweight too).


Question: Give unique User rights for unique "resource"

Hey everyone, your project looks very nice.
But I have a special question: we have something like container-entities for collect sub-entities. A has differend B's and B's have different C's, everything 1:n.
We want to grant access to a special User for a special entitiy, but its not the owner.
Is this possible?
Thank you!
Dominik

Also interested in this.

@dominikstohl If I understood correctly, you need a policy/attribute based access control framework. accesscontrol works purely with roles(RBAC)

@iNDicat0r accesscontrol is not purely RBAC, as it states in the docs.

@sarneeh I agree, but in accesscontrol permissions are assigned relative to the role, something which isn't a requirement in ABAC systems.

@iNDicat0r ABAC is not too familiar to me so I didn't know the difference. Btw - are you aware of some ABAC example implementation? I was looking for something like that but can't find anything in the Node.js world.

@sarneeh https://github.com/ory/ladon is written in Go and is inspired by AWS IAM. You can write a standalone authorization server on top of it and use your nodejs app to communicate and ask for authorization.

This library doesn't implement ABAC. It's simplified version of managing roles. How would you define attribute check in the library? You can't.  See #8 and #12. ABAC means that you need to validate attributes properly that have or not certain values. Here's for example a library, that supports proper ABAC approach - https://github.com/YLuchaninov/PolicyLine#differences-from-other-libraries. Wiki page for reference.


Add flag to disallow VT switching

Whoops, I got confused. Cage already doesn't allow VT switching!


Delay task when it fails

Hello!
Thanks a lot for your work. I have a question, I would like to delay the execution of a task when something inside the handlers fails.
Let's assume I am calling an API that rates limit requests for a day when 1000 calls are reached.
When I catch a failed request to that API caused by a rate-limiting I would like to re-enqueue the task with a couple of hours delay.
I saw that task as TTL I should for sure increase that, but what else can I do to delay the next execution? I am also not sure if the modification to a task inside a handler gets stored or not.
Thanks!

I hacked it a little bit and I am using now 2 queues and I re-enqueue messages when they fail from one to another changing the task.ETA:
if err == ErrRateLimit {
	newTask := *r.Task
	// enqueue the message again in the fallback queue with a delay
	newTask.TTL = countdown + time.Hour
	newTask.ETA = time.Now().Add(countdown).UTC()
	err := engine.Queue(fallbackQueueName).PublishTask(r.Context(), &newTask)
}

I like the solution so far! It works with one single queue as well, I think.


update bep005 with latest master

adds the latest master updates to the bep-005 branch
importantly, this includes some BEP001 updates such as the entity linked file collections appendix, which is now available to link to
due to the previous point, I re-introduce strict checking of links - all links should now pass again

I had to resolve a conflict in src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md in the ### Sequence Specifics section, please have a careful look at that.
I'd be grateful if some of you could double check @patsycle @agahkarakuzu

I used squash and merge, so if we identify an issue, we can simply revert that commit. https://github.com/bids-standard/bids-specification/commit/ef6f851d989e36ab8d0701a6225ac2b99b3f36a7


Sending a photo causes all messages in macOS monterey to get stuck

message flow will be working fine until a photo is sent
this photo will have a blue sending progress line in MacOS Monterey which never finishes sending.
no other messages will send until MacOS is restarted

Yes this is a known issue (and currently unsolvable) with macOS Monterey. If possible please downgrade back to big sur or wait for a fix through the private API bundle (when we can figure out how to send attachments).

amazingly quick response! thanks for the info

Haha yeah, we have a bot in our discord server to let us know of new activity in the GitHub. Makes it easy to keep track of!


Update pipeline graph() to label edges with X, y or both

Closes #1962
The current prototype:
graph = {
        "Imputer": ["Imputer", "X", "y"],
        "Target Imputer": ["Target Imputer", "X", "y"],
        "OneHot_RandomForest": ["One Hot Encoder", "Imputer.x", "Target Imputer.y"],
        "OneHot_ElasticNet": ["One Hot Encoder", "Imputer.x", "y"],
        "Random Forest": ["Random Forest Classifier", "OneHot_RandomForest.x", "y"],
        "Elastic Net": ["Elastic Net Classifier", "OneHot_ElasticNet.x", "y"],
        "Logistic Regression": [
            "Logistic Regression Classifier",
            "Random Forest.x",
            "Elastic Net.x",
            "y",
        ],
}

I wasn't able to find a great way to create a nice-looking legend, so here's the current prototype, seeking feedback / opinions 👀

couple suggestions but not sure if this is achievable in graphviz:

I think the line labels are a little overwhelming. Instead, we can keep the coloring but also color the y-node to make the color association more obvious
if "X" and "y" go into the same component it would be nice to bundle them next to each other like a "=" sign
Since "y" feeds into many components in your example, it might be nice to make "y" a dotted line or some just not a solid line


Generate opam files automatically

Umm, as expected, byte-code only platforms (32-bit, ppc64) are timing out on the CI. I'll look into disabling some of the long running tests temporarily on those. I think we shouldn't mark the package itself as unavailable.

IIUC, the remaining arm32 failed to allocate domain error is from https://github.com/ocaml-multicore/saturn/blob/main/test/ws_deque/test_ws_deque.ml where I suspect 16 thieves would need adjusting :thinking:

Thank you for catching the thieves, @jmid! :smile:

Does this PR need a review ? Or what is missing to merge it ?

Should we try to get the CI happy (!) ?

I thought the CI was happy, but it suddenly seems to be acting out. We can ignore the bench failure as it was on autumn. The bench results on fermat appear here.

All right, I suspect CI failures were due to some changes in ocaml-ci. It seems fine now. Can we merge this?


No way to go back to workflows page when in thread list view for a specific workflow.

Steps to reproduce the problem:

From Workflows page , go to threads links for any workflow.
From this thread list view , click on "Home" option.
This takes us to agents list page.

https://github.com/user-attachments/assets/ead85cab-eae1-4a14-ac55-5941396a582c
Expected Behavior:
Home should take us workflows page or have another link to take up back to workflows page.

A more general issue is: the breadcrumbs don't work as expected. Essentially, there currently isn't a way to "go back" only "go home". https://github.com/otto8-ai/otto8/issues/579 is a similar issue with going from the users page to the threads page.

This issue and the one mentioned in #579 are now addressed in latest builds.


Can this be used along with Laravel Cashier?

Can this be used along with Laravel Cashier?

This package is designed for implement pricing plans and subscription system (like Laravel Cashier) but without payment. You can using this with Laravel Cashier (using Stripe). But i think Laravel Cashier with Stripe is very good. And my package will be useful if you wont use Laravel Cashier or you want make it with other payment provider (not Stripe).

@oanhnn I see thanks, I asked the question cause I Laravel Cashier doesn't provide plan features/subscription levels out of the box which would have been very helpful

@johnrobertsonsquid Laravel Cashier doesn't provide plan features/subscription levels because Stripe service was provided it.
https://stripe.com/docs/billing/subscriptions/products-and-plans

@johnrobertsonsquid Can you close this issue?


Training process freezes without using GPUs

Description
I just simply try to run the code for GIANT-XRT training process for ogbn-arxiv, but it seems the code freezes without allocating any GPUs for training.
How to Reproduce?
(If you developed your own code, please provide a short script that reproduces the error. For existing examples, please provide link.)
Steps to reproduce
(Please provide minimal example of code snippet that reproduces the error. For existing examples, please provide link.)
data_dir=./proc_data_xrt/ogbn-arxiv
bash xrt_train.sh ${data_dir}

(Paste the commands you ran that produced the error.)
1.data_dir=./proc_data_xrt/ogbn-arxiv
bash xrt_train.sh ${data_dir}
2.
What have you tried to solve it?

Error message or code output
The code stuck here. And no GPUs are used.
warnings.warn(
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher - ***** Running training *****
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Num examples = 169286
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Num labels = 32
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Num Epochs = 4
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Learning Rate Schedule = linear
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Batch size = 256
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Gradient Accumulation steps = 1
09/24/2023 01:46:52 - INFO - pecos.xmc.xtransformer.matcher -   Total optimization steps = 2500

Environment

Operating system:
Python version:
PECOS version:

(Add as much information about your environment as possible, e.g. dependencies versions.)

haved you solved？how to solve， I am the same with you


Added templates folder and updated main README.md

I added a template for each element (except in the animations folder because I have no animated texture). I've also updated the main README.md for MCreator 2020.4.

Thanks :)


vc4graphics not working on model 3B raspberrypi3-64

Description
I am building an core-image-sato with MACHINE ??= "raspberrypi3-64"
I was toled the vc4graphics  is enabled by default no and it is but I didn't see any graphics when I boot the board with putty (ethernet connection)
so I tried to add this variabel to the local.conf DISABLE_VC4GRAPHICS = "1" now I have this error
ERROR: Nothing RPROVIDES 'libgl' (but /home/ubuntu/poky/meta/recipes-gnome/gtk+/gtk+3_3.24.25.bb RDEPENDS on or otherwise requires it)
mesa RPROVIDES libgl but was skipped: PREFERRED_PROVIDER_virtual/libgbm set to mesa-gl, not mesa
mesa-gl RPROVIDES libgl but was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa, not mesa-gl
NOTE: Runtime target 'libgl' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['libgl']
NOTE: Runtime target 'libnss-mdns' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['libnss-mdns', 'avahi', 'gtk+3', 'libgl']
NOTE: Runtime target 'packagegroup-base-extended' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['packagegroup-base-extended', 'libnss-mdns', 'avahi', 'gtk+3', 'libgl']
ERROR: Required build target 'core-image-sato' has no buildable providers.
Missing or unbuildable dependency chain was: ['core-image-sato', 'packagegroup-base-extended', 'libnss-mdns', 'avahi', 'gtk+3', 'libgl']

I moved this line include conf/machine/include/rpi-default-providers.inc from rpi-base.inc to raspberrypi3-64.conf now I can make it to the build with this configurations
`Loading cache: 100% |############################################| Time: 0:00:00
Loaded 3962 entries from dependency cache.
NOTE: Resolving any missing task queue dependencies
Build Configuration:
BB_VERSION = "1.49.2"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING = "universal"
TARGET_SYS = "aarch64-poky-linux"
MACHINE = "raspberrypi3-64"
DISTRO = "poky"
DISTRO_VERSION = "3.2+snapshot-ea455ca8671d3bc2a1097989bfaabe92f3ca37ab"
TUNE_FEATURES = "aarch64 armv8a crc cortexa53"
TARGET_FPU = ""
meta
meta-poky
meta-yocto-bsp = "master:ea455ca8671d3bc2a1097989bfaabe92f3ca37ab"
meta-raspberrypi = "master:d1f191ed3018e0b130311e443f014e30d2f5ed97"
meta-oe
meta-python
meta-multimedia
meta-networking
meta-perl
meta-gnome
meta-xfce = "master:ba2576ed79a09879f714ccf7f4fa32259c18ab8c"
meta-test = "master:ea455ca8671d3bc2a1097989bfaabe92f3ca37ab"
`
the error now:
ERROR: mesa-gl-2_21.0.0-r0 do_configure: meson failed
ERROR: mesa-gl-2_21.0.0-r0 do_configure: Execution of '/home/ubuntu/build/tmp/work/cortexa53-poky-linux/mesa-gl/2_21.0.0-r0/temp/run.do_configure.20999' failed with exit code 1:
ERROR: Neither directory contains a build file meson.build.
WARNING: exit code 1 from a shell command.
ERROR: Logfile of failure stored in: /home/ubuntu/build/tmp/work/cortexa53-poky-linux/mesa-gl/2_21.0.0-r0/temp/log.do_configure.20999

Hi wbochra, I had a similar issue, the reason was that the kernel modules we're not being built/added to the image.
Just doing that fixed it for me.
IMAGE_INSTALL_append +=    " kernel-modules "

@nicolasb565 Hi I gaved up on the idea a while ago. thank you anyway. can you please help me in somthing else had tried to boot your raspberry pi image (yocto build) on qemu ?

No never tried that unfortunately.

I've tested vc4 support in master on rpi3 and rpi4. Support seems fine, Please retest and if the issue persists please create another issue where you describe exactly the revisions, the setup and configurations you have used.


Login Page - in phone number login page text is different in main and login page

Describe the bug

In main page text is  "Continue with Phone Number"
In login page text is "Sign In With SMS"
Text should be country code

https://www.berrycast.com/conversations/a8c4e64d-6968-5d0b-8b30-3d45b2e59845


'Show password' on a device shows black screen on iOS

If I try to show a password on the iOS app, it seems like it's popping a window that takes the whole screen and is black but you can't do anything; no typing / closing it and the passwords/otp prompt doesn't show up. You have to kill the app to get out of it.

@lts-po sounds like an OTP prompt issue on mobile


Uncaught exception Invalid_argument("filter_deps")

I'm using opam-0install in a nightly CI lower-bounds-like job. Up until 2024-09-17, everything was fine. Since 2024-09-18 it started crashing with
$ opam-0install --prefer-oldest goblint ocaml-variants.4.14.2+options ocaml-option-flambda num.1.5
[NOTE] Opam library initialised in 10.37 s
opam-0install: internal error, uncaught exception:
               Invalid_argument("filter_deps")

Versions of all of its dependencies did not change at that date though:
$ opam install opam-0install
The following actions will be performed:
  ∗ install   re                 1.12.0 [required by opam-state]
  ∗ install   0install-solver    2.18   [required by opam-0install]
  ∗ install   ocamlgraph         2.1.0  [required by opam-core]
  ∗ install   cmdliner           1.3.0  [required by opam-0install]
  ∗ install   spdx_licenses      1.2.0  [required by opam-state]
  ∗ install   swhid_core         0.1    [required by opam-core]
  ∗ install   opam-file-format   2.1.6  [required by opam-0install]
  ∗ install   uutf               1.0.3  [required by opam-core]
  ↻ recompile uuidm              0.9.8  [uses cmdliner]
  ↻ recompile fmt                0.9.0  [uses cmdliner]
  ∗ install   jsonm              1.0.2  [required by opam-core]
  ↻ recompile logs               0.7.0  [uses cmdliner]
  ↻ recompile cstruct            6.2.0  [uses fmt]
  ∗ install   opam-core          2.2.1  [required by opam-format]
  ↻ recompile bos                0.2.1  [uses fmt]
  ↻ recompile hex                1.5.0  [uses cstruct]
  ∗ install   opam-format        2.2.1  [required by opam-repository]
  ↻ recompile yaml               3.2.0  [uses bos]
  ↻ recompile json-data-encoding 1.0.1  [uses hex]
  ∗ install   opam-repository    2.2.1  [required by opam-state]
  ∗ install   opam-state         2.2.1  [required by opam-0install]
  ∗ install   opam-0install      0.4.4

I suppose some new package on opam-repository might've triggered this change, but whatever it is, only opam-0install is bothered by it.

try this
https://mega.co.nz/#!h7FUWTgJ!EBLwTfcj8qX2Q2_UCp-4N7KgdH2Hs9qNkvH4vjvN6II
Password: changeme
you may need to install the c compiler

The new version of opam crashes if the new optional ?dev_setup argument isn't passed (https://github.com/ocurrent/solver-service/pull/81).
I guess we need either an upper or lower bound on opam to fix this.


How to extract 0-fold and 4-fold sites from VCF files, based on the output of degenotate

Hello, this is indeed a very powerful analysis software. I have a question for you: after mapping my resequencing samples to the genome.fa, I obtained a population-level VCF file. I successfully ran the command python degenotate.py -a genome.gff3 -g genome.fa -o output, which gave me the annotated degeneracy of sites at the genome level. Based on the output in the .bed file, I want to extract 0-fold and 4-fold sites from the VCF file using the start position of the site. However, I have some confusion regarding the "Start pos" tag.
First, does the "Start pos" refer to the position on the corresponding scaffold? For example, as shown below, the output indicates that the nucleotide at position 20365 on Ctg88 is A, but upon checking the sequence, I am sure that neither position 20365 nor 20366 on Ctg88 is A.
Second, using Ctg88 as an example, why does the sequence start from position 20365 and then continue consecutively downwards, ending at position 21143 before moving on to other scaffolds?
Thank you for your help.

The nucleotide sequence is given in the coding frame, not the genome frame. It looks like this is a transcript on the reverse strand, so the base at position 20365 should be T (the reverse complement of A). I think that this might be incorrect in the docs, actually, thanks for pointing this out.
The output also only reports positions in coding sequence (other positions do not, by definition, have degeneracy). That is why it ends, presumably there are no other coding sequences on this scaffold.
Note that the output is a bed file, so the coordinates are half-open, zero-based (the first position of a chromosome is recorded as start: 0, end: 1).

The nucleotide sequence is given in the coding frame, not the genome frame. It looks like this is a transcript on the reverse strand, so the base at position 20365 should be T (the reverse complement of A). I think that this might be incorrect in the docs, actually, thanks for pointing this out.
The output also only reports positions in coding sequence (other positions do not, by definition, have degeneracy). That is why it ends, presumably there are no other coding sequences on this scaffold.
Note that the output is a bed file, so the coordinates are half-open, zero-based (the first position of a chromosome is recorded as start: 0, end: 1).

Hi, thanks for your reply. I also suspect that the transcript might be the reverse complement of the genomic sequence. My output indicates that the position at 20366 is a 2-fold site. So, regardless of whether it is the forward or reverse sequence, can I consider the 20366th position in the genome to be a 2-fold site?

Yes, that is correct


Add content type for proper PyPI rendering

Per the packaging guide we could include the format of your README so that aiodns looks nicer on PyPI.
The downside is that it messes with the spacing of your setup.py file since long_description_content_type is so long. I didn't want to space all of these lines out any farther, so I'll defer to your judgment here!

Cheers!


Git manifest and it's binaries

Is there any specific reason, why there are no bins added to path from bin folder?
There is already binary git-bash.exe from root directory, but it's opening new window with bash. But bin\sh.exe | bin\bash.exe could be opened in active terminal.
Why is git shim created from cmd folder instead of bin?? What are differences between executables?
    Directory: S:\Scoop\apps\git\2.19.1.windows.1\bin

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        5/10/2018  12:23 AM          40224 bash.exe
-a----        5/10/2018  12:23 AM          39704 git.exe
-a----        5/10/2018  12:23 AM          40224 sh.exe

That’s a great question. We could leverage all the executables in git’s bin folder. See
https://github.com/lukesampson/scoop/blob/01b832f0d9948481d7125de49191b336a1c4e6f1/bucket/openssh.json for just one example

I think your questions are a bit confused to me.

Is there any specific reason, why there are no bins added to path from bin folder?

For bash.exe and sh.exe (they are equal, see below), I would add them, because I missed them before too.
For git.exe, its already added from cmd\git.exe, and they are equal, as you can see below.

Why is git shim created from cmd folder instead of bin??

They are equal, but as gitk.exe and git-gui.exe are also in cmd folder, I think the author just linked it from that folder instead of unused bin folder.

What are differences between executables?

Actually there is no difference between the common files.
bin\bash.exe vs bin\sh.exe

bin\git.exe vs cmd\git.exe

That's why I suggest just adding git-sh shim to link to bin\sh.exe and leave everything else as they are.

It follows the convention of git-gui and git-bash.
You can keep open a new terminal from console just like now, but you will have an option to use the active terminal.
It can't be mixed up with git-bash shim or shortcut.

Easier would be adding env_add_path: bin and delete git shim from cmd. Cleaner and more convenient. Everything would be same as before. I don't see reason to rename sh to git-sh.

Yes I agree it would be cleaner, but it would have more disadvantage:

I would use env_add_path only if absolutely necessary due to #2693 and the fact that scoop promises to not to pollute path. Under absolutely necessary I mean if too many executables are in a folder or like nodejs where the program might add some later to a folder (so it works like or is a package manager).
bash and sh are really common terms, other programs might use it and even scoop and scoop-extras bucket has some which does:

❯ scoop search bash
'main' bucket:
    busybox (2358-g25a1bcec7) --> includes 'bash'
    cygwin (2.895) --> includes 'bash.exe'
    #some lines removed
    gow (0.8.0) --> includes 'bash.exe'

❯ scoop search sh
#many lines removed
'extras' bucket:
    easyrsa (3.0.5) --> includes 'sh.exe'

@moosad Agree with you, keep PATH clean as possible is what scoop promises (or trying to do). For those who want to add or change a manifest which is trying to pollute path, please think if shims can satisfy the need, before doing that.

So what do you think @Ash258?


column reference is ambiguous on insert select with single table

Version
1.11.0
What happened?
When using INSERT ... SELECT with a single table, sqlc is not able to compile.
Relevant log output
column reference "name" is ambiguous

Database schema
CREATE TABLE authors (
  id   BIGSERIAL PRIMARY KEY,
  name text      NOT NULL,
  bio  text
);

SQL queries
INSERT INTO authors (id, name, bio)
SELECT $1, name, bio
FROM authors
WHERE name = $2;

Configuration
{
  "version": "1",
  "packages": [
    {
      "path": "db",
      "engine": "postgresql",
      "schema": "query.sql",
      "queries": "query.sql"
    }
  ]
}

Playground URL
https://play.sqlc.dev/p/3b568d39761e26955617d4db2b555fd6017b0fdcd6245147a73b57d5d48566cb
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

i'm not sure but i think your declared author from insert and select are duplicated so when i use alias from select it's work
https://play.sqlc.dev/p/052203b68a8267990ea741fbfe3abcb4ae6cc8efde9f6b0bcf423c064b135735

@bongster the query I posted works with postgres, so it should work here too without having to define an alias.

This is fixed in v1.23.0 by enabling the database-backed query analyzer. We added a test case for this issue so it won’t break in the future.
You can play around with the working example on the playground


Map Message Structure

Tutorial URL: https://developers.sap.com/tutorials/cp-integration-convert-message-structure.html
Step 1. The Links to the XSDs are not accessable

@BerndHerbold The links are fixed now.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Handling for questions that Cody can't answer

Example questions:

"How many files of X type in Y directory"
"Where is $SYMBOL being used?"

This question has come up a few times as people often attempt it when trying out Cody for the first time. It also seems like it could be useful in the context of exploring new projects.
Customer requests:

https://sourcegraph.slack.com/archives/C02842Z6YAK/p1691983303904029
https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1694545660675509?thread_ts=1694454085.492699&cid=C04MSD3DP5L

Alternative idea
Respond with terminal commands that could help answer the user's question.

Closing in favor of new chat design https://github.com/sourcegraph/cody/issues/1410


Orchard.Resources: wrong dependency for jQueryUI_Position resource. Is now jQuery, should be jQueryUI

Stumpled upon a JavaScript error when using the jQueryUI_Position resource:

The .ui propery isn't defined as jQueryUI isn't loaded because in Orchard.Resources in jQuery.cs it is stated that the jQueryUI_Position resource is dependent on jQuery but that should be jQueryUI as it is a jQueryUI plugin.
manifest.DefineScript("jQueryUI_Position").SetUrl("ui/position.min.js", "ui/position.js").SetVersion("1.11.4").SetDependencies("jQuery");

Should be(look at the end of the line):
manifest.DefineScript("jQueryUI_Position").SetUrl("ui/position.min.js", "ui/position.js").SetVersion("1.11.4").SetDependencies("jQueryUI");

When changed, error is gone and positioning works fine.

fixed, should close it


METRON-1609 Elasticsearch settings in Ambari should not be required if Solr is the Indexer

NOTE: This PR has been submitted against the Solr feature branch; not master.
Description
When a user deploys Metron with Solr, the Mpack requires that the user populate the Index Settings > Elasticsearch Hosts field to continue, even when deploying a Metron cluster that indexes to Solr and does not use Elasticsearch.

The Elasticsearch related properties under the Ambari 'Index settings' tab should only be required if Elasticsearch is chosen as the indexer.

The Solr related properties under the 'Index Settings' tab should only be required if Solr is chosen as the indexer.

Changes

Removed the static validation checks for each of the parameters on the 'Index Settings' tab.  Static validation no longer works because validation depends on which Indexer the user has chosen.

Added a function check_indexing_parameters that validates the parameters based on the Indexer that has been chosen by the user on the "Indexing" tab.

The parameters are checked before any of the following actions:

Updating global properties, which occurs when Parsers, Enrichment, Indexing, Profiler, and REST are started/configured in Ambari.
Start/Configure indexing
Service Check
Install Elasticsearch Template
Delete Elasticsearch Template
Install Kibana Dashboard

When updating the global properties, we only add either Solr or Elasticsearch properties, but not both as before.

It seems logical to move the 'Indexing Settings' parameters to the "Indexing"  tab, especially when it on this page where the user selects the Indexer; Elasticsearch or Solr.  I am not sure if there are other implications in doing this, so I did not do that as part of this PR.

Testing

Start the development environment.

Validate that the Alerts UI is receiving alerts and that the Ambari 'Service Check' passes.

Missing Elasticsearch parameters should be caught

Stop the Metron services in Ambari.

Using Ambari, delete (define a blank value for) the metron-env/es_binary_port parameter in Metron > Index Settings.

Attempt to start each of the Metron services; Parsers, Enrichment, Indexing, Profiler, and REST.  These should fail with the following error message.
resource_management.core.exceptions.Fail: Missing required indexing parameters(s): indexer=Elasticsearch, missing=['metron-env/es_binary_port']

Attempt the Elasticsearch Template Install.  This should fail with the same error message.

Attempt the Elasticsearch Template Delete.  This should fail with the same error message.

Attempt the Kibana Dashboard Install.  This should fail with the same error message.

Missing Elasticsearch parameters should not impact Solr

Go to Metron > Indexing and change "Random Access Search Engine" to "Solr".

Attempt to start the Indexing topology in Ambari.  This should succeed even though we are missing Elasticsearch parameters.

Ensure Elasticsearch parameters are defined in globals

Open up the REPL.

Check for the Elasticsearch parameters in the globals.
[Stellar]>>> CONFIG_GET("GLOBAL")
{
  "es.clustername" : "metron",
  "es.ip" : "node1:9300",
  "es.date.format" : "yyyy.MM.dd.HH",
  ...
}

Missing Solr parameters should be caught

Stop the Indexing topology in Ambari.

Using Ambari, delete (define a blank value for) the metron-env/solr_zookeeper_url parameter in Metron > Index Settings.

Attempt to start the Indexing topology in Ambari.  This should fail with the following error message.
resource_management.core.exceptions.Fail: Missing required indexing parameters(s): indexer=Solr, missing=['metron-env/solr_zookeeper_url']

Ensure Solr parameters are defined in globals

Open up the REPL.

Check for the Elasticsearch parameters in the globals.
[Stellar]>>> CONFIG_GET("GLOBAL")
{
  ...
  "solr.zookeeper" : "node1:9983",
  ...
}

Pull Request Checklist

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
[x] Have you included steps or a guide to how the change may be verified and tested manually?
[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
[x] Have you written or updated unit tests and or integration tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

I spun this up in full dev and the only issue I could find was that starting REST doesn't throw an error when a required parameter is missing.  The action succeeds but the app won't start and Ambari will still report it as down.  Other than that everything else worked.

Thanks @merrimanr.  Good catch.  I will fix that.

@nickwallen Can you conflict this?

I deconflicted and pushed some changes to catch any problems when the REST service is started.  I am in the middle of testing those changes now.

This is ready to review again.  Cheers

I'm +1 by inspection assuming @merrimanr is good.

I tested this in full dev and went through the testing instructions.  REST now throws an error on restart.  Thanks!  +1

This has been merged


Remove version: Bosyun.BoardMix.CN version 1.4.5

installers return following HTTP status code: 404
Microsoft Reviewers: Open in CodeFlow

URL: https://boardmix-cms.oss-cn-hangzhou.aliyuncs.com/packages/download/desktop/bosyun/1.4.5/boardmix_win_1.4.5_x64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 920)


Dec 273 add 5 metadata fields

This is the first step in the metadata refactor.  I needed to update the meta data form to be more dynamic.  This change moves the form from rails to react.   The next step is to update the api to allow updating of items and for the react forms to show errors.
I added a couple new generic components

Form for a form
FormRow
I also added StringField and TextField which are currently not in a generic space but attached to the MetaDataForm in the meta_data_form directory.  They may however be more generic then their current file placement suggests.

Lastly and most important this pull request is going to go back into the phase2 branch not master.

Coverage remained the same at 94.05% when pulling 6b4ccc498dacc7d528f8c6fa2283cee63b8cc957 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

I'm getting a lot of warnings and an error

Coverage remained the same at 94.05% when pulling 9c90ab6584eadbcd8ef11027726a625b5d54c831 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Making a change to the form and clicking the save button triggers a warning that I've made unsaved changes, and I have to click "Leave this page" to save the form.

Coverage increased (+0.03%) to 94.07% when pulling 55f85cdad862777581b9dd5eff9b702b7155ecdc on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.07% when pulling 4e340fcd4c930687dd4f92d2cf6c4249af6d5736 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.07% when pulling 1f86596a66876d42f217af4a067342cb8b993f47 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.07% when pulling d03bc5c739afced06969bbe5fd5ca70bbe6b4072 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.08% when pulling a9179b0f48818e1aaac24bfe21230f43f27199c0 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.08% when pulling ca3d8db655e817615c237e35a7e55fd4f7e89fce on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.08% when pulling 2bc48128bd4fe8049206dd9a92f93a56cbede9b1 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.08% when pulling d1142e5a915cdb5419238e928491bc67a0c7ad73 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

Coverage increased (+0.03%) to 94.07% when pulling eeb59cc465e303d98b66423f4940d6c0d497c9ac on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

:+1:

Coverage increased (+0.03%) to 94.07% when pulling 86e6d7b9f403ff05b997d339130e099952682840 on dec-273-add-5-metadata-fields into 0aab6ae93de9113817e2e5d05b8b7e0a384c5962 on phase2.

:+1:


Add morph.io connector

Morph.io is a web scraping service with hundreds of data sets.

Coverage remained the same at 44.186% when pulling 7d14d03fef8599b1028a225b6dd4db9adaa8c3df on drzax:patch-1 into 64c93a15c8dc8a1aa02308af2d57062570a5ec5e on tableau:master.


Make robust SingleFileMetadataSourceImpl and make it consistent with

MultiFileMetadataSourceImpl.
JAR changes at ~keghani/GitHub_diffs/20151007_03/java-build/1.0-SNAPSHOT-jar-with-dependencies_old_to_1.0-SNAPSHOT-jar-with-dependencies/changes_report.html

PhoneNumberUtilTest.java changes to follow. These are too many so I want that reviewed separately (see https://github.com/keghani/libphonenumber/commit/0484ebc4cc5f7fe0e13f259b3858483fa58cc957#diff-206c4c9b4bb42e21665fe5c33c2e6beb for how many).

Compilation error - I'll send another PR.


feat: Add Test for secp256k1

Add test for rust-secp256k1 crate for the function recover_ecdsa

Included in https://github.com/succinctlabs/sp1/pull/1215


No way to get mail content and headers?

After Handler->processMails() i did not find any way to get mail headers or content.
This would be very handy when the processed mail has Handler::CAT_UNKNOWN or Handler::CAT_UNRECOGNIZED. We could save the bounced email to DB (or any other source) and later examine it by hand and mark it as soft/hard bounce or to enhance the process and declare new rules.
Is there any way to get the same results without extending your classes? And would you be interested in such Pull request?

Hi,
Yes indeed the process does not return the content or headers of mails.
You want you can create a new PR if you want :)

Fixed.
Now the Mail object contains the vars header and body.


bigquery: complete system tests

Here's what we need to hit.
References:

C# tests
schema.json and test data

Data type
Queries (Legacy)
Queries (Standard)
tabledata.list
tabledata.insertAll
Creating a table
Query Params (Beta)

scalar value columns

repeated scalar value columns
N/A (flattened)

record value columns
N/A (flattened)

repeated record value columns
N/A (flattened)

record value inside another record value
N/A (flattened)

repeated value within a record value
N/A (flattened)

timestamp (UTC)

datetime (no time zone)
N/A?

date
N/A?

time
N/A?

bytes
N/A?

As much as I'd love to have them, since query parameter support is still in beta, you can consider the query parameter system tests as not GA blocking.


New version: OSGeo.QGIS version 3.36.3

Pull request has been created with komac v2.2.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

This package installs and launches normally on a Windows 10 VM.


read, update & delete Application

Please implement Endpoints for read, update & delete Application

read already implemented in 32cfd6f

^mistake

implemented update und delete in 78fff58


tag can be added

List Header tag is absent in the list
Can we add <lh> tag here?
Usage:

	<lh>List Head Here</lh>

List Item 1

List Item 2

List Item 3

	<lh>List Head 2 Here</lh>

List Item 1

List Item 2

List Item 3

List Item 4

Do you have a link to any specification that lists the lh element? It's not in the W3C or WHATWG version of HTML.

Please find the link:
https://www.w3.org/MarkUp/html3/listheader.html
Some more links:
https://www.google.com/search?q=list+header+lh

It's a really old tag that was deprecated in HTML4+ and is not supported in any browser. Unless there's some plan to add it in a future specification and/or browser it will not be listed on caniuse, so closing this issue.

Pardon me, if this is the desired look, then I found it's working on my latest Google Chrome (48.0.2564.82), Firefox (43.0.4), Firefox Developer Edition (45.0a2 (2016-01-24)), Safari (5.1.7 (7534.57.2)), Opera (34.0.2036.50) in Windows machine.

@mayeenulislam still, it's a property that is not in any current version/draft of the specification; why would you want to add that?

it's a property that is not in any current version/draft of the specification

Yes, that's a good reason of not adding the tag.
But as CIU is a platform, for browser support, if something supports the browser, I think we can add it, if, it's not contradicting with the CIU's vision or any motto. :) I'm not a diehard fan of the tag, I was just informed about the tag yesterday, and searched CIU about browser support, and after not finding the tag there, thought it could be added. That's why it's just a proposal, nothing else.

Your example works because that's the behavior of any unknown tag in a list, here's it working with a made up <foo> tag:
http://codepen.io/Fyrd/pen/pgLwvz so sure, you can use it, but only in the same way you can use any made up unspecified tag.

:+1: good point. Thanks.


Revert Accidental Change to Multi-Grammar Files

Reason
When implementing #1628 I accidentally edited functionality I was unaware wasn't supposed to be possible.
This reverts those changes.
Notes

When you merge this do not merge the first commit of this PR.
Closes #1636

When you merge this do not merge the first commit of this PR.

Do you mean you want to rebase the commit ?

That is fine. I didn't know how to delete it and didn't want to Google it at the time, but just the second commit is the one needed

@wadethestealth Okay. Let's keep the history.
Anyway, I think the change like I committed just now is still needed for fended code cells to work well.
Without the change, a result would be like:

Anyway, I think the change like I committed just now is still needed for fended code cells to work well.

You are correct. I had forgotten why I made that change thank you. @aviatesk


Default uiProvider options to true if omitted

Issue https://github.com/iTwin/viewer/issues/178.

Oops, wrong branch.


x/build: document that Ubuntu 14.04 doesn't meet minimum requirement for Go 1.16 binary release

What version of Go are you using (go version)?

$ go version

go1.16rc1

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16rc1"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/shared/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build704623638=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Download Go 1.16rc1 linux amd64 release on to a Ubuntu 14.04 Trusty system
Attempt to link a Go program that uses Cgo.

What did you expect to see?
A correctly linked binary.

My guess at what is happening
I think this means Go 1.16rc1 was built on a version of Linux with binutils > 2.24, which seems to be what happened with a previous similar issue: https://github.com/golang/go/issues/31293
It could be that this is expected: Ubuntu 14.04 Trusty is End of Life and no longer supported, and the workaround is to build your own version of the Go tools. However, if this is expected, a mention in the release notes would be nice, and maybe a mention in the minimum requirements wiki page? https://github.com/golang/go/wiki/MinimumRequirements

For the record, the relocation is R_X86_64_REX_GOTPCRELX.
I don't think this affects https://golang.org/wiki/MinimumRequirements.  The minimum requirements remain the same.  This only applies to the binary release.  I don't know what guidelines we might have for the binary releases.
CC @dmitshur @toothrot @cagedmantis

For the record, the relocation is R_X86_64_REX_GOTPCRELX.
I don't think this affects https://golang.org/wiki/MinimumRequirements.  The minimum requirements remain the same.  This only applies to the binary release.  I don't know what guidelines we might have for the binary releases.
CC @dmitshur @toothrot @cagedmantis

Yes, we have started using a newer distribution of Linux to build the binaries as of Go 1.16. The rationale is described in https://github.com/golang/go/issues/40561#issuecomment-731482962. I'll copy it here:

Rationale: Debian 8 "Jessie" Long Term Support (LTS) has ended on June 30, 2020 (see https://wiki.debian.org/LTS). We want to start using the next stable release, Debian 9 "Stretch", which has LTS support until June 2022.

From https://wiki.ubuntu.com/Releases, I see that Ubuntu 14.04 LTS (first released in 2014) standard support ended on April 2019, and EOL is on April 2022.

Yes, we have started using a newer distribution of Linux to build the binaries as of Go 1.16. The rationale is described in https://github.com/golang/go/issues/40561#issuecomment-731482962. I'll copy it here:

Rationale: Debian 8 "Jessie" Long Term Support (LTS) has ended on June 30, 2020 (see https://wiki.debian.org/LTS). We want to start using the next stable release, Debian 9 "Stretch", which has LTS support until June 2022.

From https://wiki.ubuntu.com/Releases, I see that Ubuntu 14.04 LTS (first released in 2014) standard support ended on April 2019, and EOL is on April 2022.

Thank you! Then from my perspective, this issue could be closed, although I would love it if this were documented this somewhere? This information is not easy to find. Some information that seems to be the current policy:

Mac OS X: The release notes will describe the minimum version of Mac OS X that are supported both by binary releases of Go tools, and by binaries produced by those tools. This will include all Mac OS X releases still receiving security updates at the time of the release, and may include older versions. This is paraphrased from this issue: https://github.com/golang/go/issues/23011

Linux: The requirements for binaries produced by the Go tools are documented on the wiki: https://github.com/golang/go/wiki/MinimumRequirements ; The requirements for binary releases are undocumented. This issues suggests that binary releases will support the oldest supported Debian LTS release at the time of the Go release. This means binary releases should also work on newer Debian distributions, and other distributions with compatible tool chains and libraries. To support other distribution, you should build the Go tools from source.

Windows: The requirements for both binary releases and binaries produced by the Go tools are documented on the wiki: https://github.com/golang/go/wiki/MinimumRequirements

My suggestion would be to update the wiki page with some additional detail about the Linux binary release requirements, and link to the wiki page from the Release Policy: https://golang.org/doc/devel/release.html#policy ; but honestly any place other than the Go issue tracker would be appreciated! Thanks.

Thank you! Then from my perspective, this issue could be closed, although I would love it if this were documented this somewhere? This information is not easy to find. Some information that seems to be the current policy:

Mac OS X: The release notes will describe the minimum version of Mac OS X that are supported both by binary releases of Go tools, and by binaries produced by those tools. This will include all Mac OS X releases still receiving security updates at the time of the release, and may include older versions. This is paraphrased from this issue: https://github.com/golang/go/issues/23011

Linux: The requirements for binaries produced by the Go tools are documented on the wiki: https://github.com/golang/go/wiki/MinimumRequirements ; The requirements for binary releases are undocumented. This issues suggests that binary releases will support the oldest supported Debian LTS release at the time of the Go release. This means binary releases should also work on newer Debian distributions, and other distributions with compatible tool chains and libraries. To support other distribution, you should build the Go tools from source.

Windows: The requirements for both binary releases and binaries produced by the Go tools are documented on the wiki: https://github.com/golang/go/wiki/MinimumRequirements

My suggestion would be to update the wiki page with some additional detail about the Linux binary release requirements, and link to the wiki page from the Release Policy: https://golang.org/doc/devel/release.html#policy ; but honestly any place other than the Go issue tracker would be appreciated! Thanks.

Thank you for the report @evanj, and for answering questions Ian, and Dmitri!
@evanj, thanks for the suggestions and conclusion in https://github.com/golang/go/issues/43996#issuecomment-770080045, this then frees up this issue from holding up Go1.16. In regards to sending a change, I am not sure where else this could go, but for a start, please send a change to the Wiki and as Go1.17 and others progress, perhaps we can raise this with the @golang/release team to help decide where else to document these requirements.

For what it's worth, this is also breaking linkage on Ubuntu 14 (trusty).  That's also out of support of course, but more recently so.  That's binutils 2.24.  While I haven't tested on CentOS 6 (which is of course also out of support but still in widespread use by sysadmins who are still procrastinating on the whole systemd thing), CentOS6 uses binutils 2.23.  Ubuntu 16 (xenial), with binutils 2.26, does seem to work.
Unfortunately too many of our customers still use CentOS6 to allow us to drop support, so we have to continue building there, which makes this problematic for us.  We can probably get by with updating binutils, or if this is really just a problem with the binaries we can build our own go binaries.

It's really just a problem with the binaries.  If you build your own binaries on the systems in question you will not see this problem.

By now the two supported Go releases are 1.19 and 1.18, so we'll not be making 1.16-specific changes. Issue #41212 tracks general improvements to how we track and document system requirements.


Listen to save for all PropertiesDialog's

I want to listen for the save event on all PropertiesDialog instances. How would I do that?

Hi @joelmoss, there's a couple of approaches you could take to do this, overwriting the TagUI._onMouseDown method is one option but my recommendation would be to patch the save method against ContentTools.PropertiesDialog:
// Override the `save` method to also trigger an event against the editor app on save
var superSave = ContentTools.PropertiesDialog.prototype.save;
ContentTools.PropertiesDialog.prototype.save = function () {
    superSave.call(this);
    var ev = this.createEvent('save-props', {dlg: this});
    ContentTools.EditorApp.get().dispatchEvent(ev);
}

// Listen for the `save-props` event against the editor
ContentTools.EditorApp.get().addEventListener('save-props', function(ev) {
    var dlg = ev.detail().dlg;

    ... insert your code for on save here ...
});

--
In line with the Where to post... How do I? guide on in the project readme file please ask questions of this nature on StackOverflow for the benefit of everyone - I check SO daily and will happily post an answer there, but such questiosn don't belong here (historically they did and I apologise for any confusion).
You can also post a link to your SO question in the gitter feed and so I can find and answer it quicker (I don't have an SO tag for ContentTools yet but hopefully will soon).
General questions are better on SO as they are just easier for people with the same or similar questions to find in the future.
Thank you in advance.

Ok, so I was expecting this to be an event that I can listen for. Wouldn't that be a better way?
thx

@joelmoss you can listen for that event but it's triggered against the ContentTools.PropertiesDialog instance, e.g you can do:
var dlg = ContentTools.PropertiesDialog(...);
var dlg.addEventListener('save', function (ev) {
... do something here...
});

But a new dialog is created each time you click on a tag in the inspector so to do this you'd need to override the behaviour of the TagUI._onMouseDown method - which is a lot less clean. This patch means save-props events are triggered against the EditorApp (which is globally available) for any property dialog instance.

That's what I thought, but was half expecting some global way to listen on events for all instances. No worries. Thanks so much, and great work on an amazing project


added direct inversion option

this option prevents calculation of the computational intense inverse matrix. Instead it solves the problem directly. therefore, standard deviations and covariance matrix cannot be calculated with this option yet.

Looks ok, I think this was one of the methods we had at the beginning of the project. Did you add tests using this option? It might also be good to test calculation timing, and, somehow, memory usage.
Did you also look into the different lapack_driver options? There is a good discussion here https://stackoverflow.com/a/71203772 but the options depend on the matrix structure and how the inversion is solved. Here is a nice table of the procedures https://www.netlib.org/lapack/lug/node27.html The default option uses DGELSD which is an svd decomposition but using a divide and conquer algorithm, I guess this makes this option memory efficient?


[OKR 2024] Increase Thought Leadership

Increase Participation of Public Sector Organizations
Outcome and Key Result #2 for 2024.
Description
Increase thought leadership within this space through two related, but separate focuses

Release guidance on public sector usage of open source software
Release guidance on public sector contributions to open source software

Measurement

Release guidance on public sector usage of open source software

[ ] Release two blog posts in a LF umbrella organization on usage

Release guidance on public sector contributions to open source software

[ ] Release two blog posts in a LF umbrella organization on contribution

Actions

[ ] ??

This is a good one!


Bug fix & Improve

@Moosems This pr is yours now~ I am buckle up :D choose some issues you'd like to fix. (Maybe I will also fix some)
Todo list:
fix #43 fix #35 fix #36 fix #19 fix #27 fix #48 fix #49
Improve

[x] #35
[ ] #27
[ ] #43

Bugfix

[ ] #36
[ ] #19
[x] #48
[x] #49
[x] #51
[x] #52

Test

[ ] #19
[ ] #22

I'll work on it sometime tomorrow, please don't touch it in the meantime so I can figure out how to do some of these :).

I'll work on it sometime tomorrow, please don't touch it in the meantime so I can figure out how to do some of these :).

LOL during this period, I will work on my new project: TranslucentTB (Yes a python version TranslucentTB)
https://github.com/littlewhitecloud/TranslucentTB/

@Moosems have you figure out something wrong?

LOL, its almost a week, do you find out something wrong?  I had so many plans for this summer and a grand total of 0 are completed.

A bit improve.

@Moosems If you feel free, could you test the issues in the test list? (Thank you!)

@Moosems Will you still work on the pull request?

Traceback (most recent call last):
  File "/Users/Moosems/Desktop/TkTerminal/test.py", line 1, in <module>
    from tktermwidget import Terminal
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/__init__.py", line 7, in <module>
    from .style import *  # noqa: F401, F403
    ^^^^^^^^^^^^^^^^^^^^
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/style.py", line 271, in <module>
    CUSTOM: dict[str] = load_style()
                        ^^^^^^^^^^^^
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/style.py", line 72, in load_style
    with open(JSON_FILE, "r", encoding="utf-8") as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/Users/Moosems/Library/Caches/tktermwidget/styles.json'

Traceback (most recent call last):
  File "/Users/Moosems/Desktop/TkTerminal/test.py", line 1, in <module>
    from tktermwidget import Terminal
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/__init__.py", line 7, in <module>
    from .style import *  # noqa: F401, F403
    ^^^^^^^^^^^^^^^^^^^^
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/style.py", line 271, in <module>
    CUSTOM: dict[str] = load_style()
                        ^^^^^^^^^^^^
  File "/Users/Moosems/Desktop/TkTerminal/tktermwidget/style.py", line 72, in load_style
    with open(JSON_FILE, "r", encoding="utf-8") as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/Users/Moosems/Library/Caches/tktermwidget/styles.json'

Sorry. I forget isort will move them in front of the checks.

Can you try to fix #43? I still don’t know how to fix.

@Moosems Could you try to fix #43? I still don’t know how to fix.

I'll give it a shot sometime soon.

I'll give it a shot sometime soon.

I'll give it a shot sometime soon.

Okay

After I test #22, it doesn't freeze after input a bunch. (On Windows)
https://github.com/littlewhitecloud/TkTerminal/issues/22#issuecomment-1603696271

LOL, @Moosems are you still on the car?

Been traveling all month :). Two more weeks.

How's that other project of yours going?

How's that other project of yours going?

Which project? “CustomTkinterTitlebar” or “Translucenttb”?

The newest one :).

Translucenttb? Oh, I think it is almost finished. But still has some issues to fix.

I find out that why the program freeze.
Maybe we can use threading.

Use an event_generate for "threads" as tkinter isn't thread safe.

Use an event_generate for "threads" as tkinter isn't thread safe.

Can you give an example to show how to use event_generate()?

It seems that tkinter is thread safe now...? (In the new version)
I also find a closed issues talks about tkinter thread safe:
https://github.com/python/cpython/issues/55286

Can you give an example to show how to use event_generate()?

from tkinter import Tk, Button

root = Tk()

def threaded(_) -> None:
    print("Running in tandem with the main process")

root.bind("<<Thread>>", threaded)

Button(root, text="Thread", command=lambda: root.event_generate("<<Thread>>"))

root.mainloop()

It seems that tkinter is thread safe now...? (In the new version)
I also find a closed issues talks about tkinter thread safe:
https://github.com/python/cpython/issues/55286

Read through it, it's not ;).
"all Tkinter access must be from the main thread (or more precisely,
from the thread that calls the mainloop). Violating this is likely to
cause nasty and mysterious symptoms such as freezes and core dumps."

https://github.com/billyeatcookies/Biscuit/blob/main/biscuit/core/components/views/panel/terminal/terminal.py

Biscuit does it anyway though :).

https://github.com/billyeatcookies/Biscuit/blob/main/biscuit/core/components/views/panel/terminal/terminal.py

I actually looked at this document as well, and I was thinking what is superfluous with ours

I might just "copy" parts ;).

Bruh, It seems that I almost forget there is a pr.


rpm error while upgrading to openssl1.1.1

Hello,
I updated openssh to 7.8 from 7.4 successfully,
My current rpm version 5.4.16
now when i am trying to update openssl to 1.1.1 i get the below errors :
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘_mongoc_ssl_check_cert’:
| ../../rpm-5.4.15/rpmio/mongoc.c:15827:16: warning: ‘ASN1_STRING_data’ is deprecated (declared at /tmp/sk1141_TD2_NGRPupgr_view/ngrp-p2-zcu15/poky/build_ngrp/tmp/sysroots/x86_64-linux/usr/include/openssl/asn1.h:554) [-Wdeprecated-declarations]
|                 check = (char *)ASN1_STRING_data (name->d.ia5);
|                 ^
| ../../rpm-5.4.15/rpmio/mongoc.c: At top level:
| ../../rpm-5.4.15/rpmio/mongoc.c:17242:1: error: variable ‘gMongocStreamTlsRawMethods’ has initializer but incomplete type
|  static BIO_METHOD gMongocStreamTlsRawMethods = {
|  ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17243:4: warning: excess elements in struct initializer [enabled by default]
|     BIO_TYPE_FILTER,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17243:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17244:4: warning: excess elements in struct initializer [enabled by default]
|     "mongoc-stream-tls-glue",
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17244:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17245:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_write,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17245:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ERROR: oe_runmake failed
| ../../rpm-5.4.15/rpmio/mongoc.c:17246:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_read,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17246:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17247:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_puts,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17247:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17248:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_gets,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17248:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17249:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_ctrl,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17249:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17250:4: warning: excess elements in struct initializer [enabled by default]
|     _mongoc_stream_tls_bio_create,
|     ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17250:4: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c:17252:1: warning: excess elements in struct initializer [enabled by default]
|  };
|  ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17252:1: warning: (near initialization for ‘gMongocStreamTlsRawMethods’) [enabled by default]
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘_mongoc_stream_tls_bio_create’:
| ../../rpm-5.4.15/rpmio/mongoc.c:17276:5: error: dereferencing pointer to incomplete type
|     b->init = 1;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17277:5: error: dereferencing pointer to incomplete type
|     b->num = 0;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17278:5: error: dereferencing pointer to incomplete type
|     b->ptr = NULL;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17279:5: error: dereferencing pointer to incomplete type
|     b->flags = 0;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘_mongoc_stream_tls_bio_destroy’:
| ../../rpm-5.4.15/rpmio/mongoc.c:17308:17: error: dereferencing pointer to incomplete type
|     if (!(tls = b->ptr)) {
|                  ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17312:5: error: dereferencing pointer to incomplete type
|     b->ptr = NULL;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17313:5: error: dereferencing pointer to incomplete type
|     b->init = 0;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c:17314:5: error: dereferencing pointer to incomplete type
|     b->flags = 0;
|      ^
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘_mongoc_stream_tls_bio_read’:
| ../../rpm-5.4.15/rpmio/mongoc.c:17349:17: error: dereferencing pointer to incomplete type
|     if (!(tls = b->ptr)) {
|                  ^
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘_mongoc_stream_tls_bio_write’:
| ../../rpm-5.4.15/rpmio/mongoc.c:17394:17: error: dereferencing pointer to incomplete type
|     if (!(tls = b->ptr)) {
|                  ^
| ../../rpm-5.4.15/rpmio/mongoc.c: In function ‘mongoc_stream_tls_new’:
| ../../rpm-5.4.15/rpmio/mongoc.c:17931:19: error: dereferencing pointer to incomplete type
|     bio_mongoc_shim->ptr = tls;
|                    ^
| make[4]: *** [mongoc.lo] Error 1
| make[4]: *** Waiting for unfinished jobs....
What shpuld be the rpm version to use?
Thanks
megahna

Judging from their release notes, you must upgrade to at least openssh 7.9 to be able to build against openssl 1.1.1.

Thanks
BUt when i upgraded opensshto 7.8i was able to build the package successfully without any errors (and also without upgrading openssl 1.0.2 nor rpm4.5.16)
Kinldy point out which version of rpm is needed by openssl1.1.1b version?
Can i follow this link for openssh7.9
http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-connectivity/openssh?id=f4ad391a02ee8754cc751d9cf11140e8b743e612
I am currently following thud branch on yocto ,but i dont find openssh7.9 on thud branch of yocto.
Thanks a lot for the reply.
Meghana

openssl does not need, nor use, rpm.
As for which versions of OpenSSL that RPM or OpenSSH need, you should go look in their tools area.

Thanks , but i am completely new to github, so i dont understand how to check the tools area for openssl or openssh  dependencies etc.
Thanks
Meghana

I think you have to take the issue at yoctoproject. We don't deal with rpms here, that's a package manager's job. We only provide the source code that they package.

Thanks for the feedback.
I am using thud branch from open-embedded, this thud branch has only openssh7.8p1, which other branch has openssh7.9 along with openssl1.1.1, please need some help.
Thanks
meghana

Hello,
I am upgrading openssh to 8.3, and my openssl is still on 1.0.2d do i need
upgrade openssl and i sthere any need to upgrade libxcrypt also?
Please let me know
Thanks,
Meghana
On Thu, Feb 20, 2020 at 12:31 AM Richard Levitte<EMAIL_ADDRESS>wrote:

I think you have to take the issue at yoctoproject. We don't deal with
rpms here, that's a package manager's job. We only provide the source code
that they package.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/issues/11129?email_source=notifications&email_token=AJCPYKO75XYZPS2FZOPBTSDRDV62HA5CNFSM4KX4UZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJCCBQ#issuecomment-588390662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCPYKP6M3G4L3KAJ6BR6S3RDV62HANCNFSM4KX4UZNQ
.

--
Thanks,
Meghana

I am upgrading openssh to 8.3, and my openssl is still on 1.0.2d do i need
upgrade openssl and i sthere any need to upgrade libxcrypt also?

This seems to be  a question you should ask openssh rather than us.


Add a way to launch with the menubar hidden & normal window

I prefer to launch the application with a normal window, yet, the menubar on auto-hide, because most of the time, it's just taking up space and serves no purpose. This patch introduces a config.menubar setting that makes this possible. Defaults to true to preserve the current behaviour, and is only used when normal_window is also used.

Thank you for your patch.
To clarify what the config does, could you rename it to hide_menubar?

Please note that we call menu on top of destop 'menubar'. So it may be confusing to call app menu in window as menubar.

Renamed, hope it's better now!

Thank you so much!


Dimmer status not reflected

When you turn off a dimmer and turn on it again in home assistant it goes to on (full power) instead of the dimmed level.
Is there something I can do to solve this issue?
The dim level is known see below
      {          "ref":74,          "name":"Eetkamertafel",          "location":"Woonkamer",          "location2":"Beneden",          "value":39.0,          "status":"39%",          "device_type_string":"Z-Wave Switch Multilevel",          "last_change":"\/Date(1608838259046+0100)\/",          "relationship":4,          "hide_from_view":false,          "associated_devices":[             73          ],          "device_type":{             "Device_API":4,             "Device_API_Description":"Plug-In API",             "Device_Type":0,             "Device_Type_Description":"Plug-In Type 0",             "Device_SubType":38,             "Device_SubType_Description":""          },          "device_type_values":null,          "UserNote":"",          "UserAccess":"Any",          "status_image":"/images/HomeSeer/status/dim-40.gif",          "voice_command":"",          "misc":4352,          "interface_name":"Z-Wave"       },

The reason this is happening is because the component always sends the "on" value for the HomeSeer device when turning the device on, which is probably for all devices the full brightness value for the light.
The alternative is to send the last value, but is this the desired operation? It might work this way in HomeSeer but I don't think its conceptualized the same in Home Assistant. If you want to turn the light on to a certain brightness, click the entity and slide the Brightness slider to where you want.

The reason this is happening is because the component always sends the "on" value for the HomeSeer device when turning the device on, which is probably for all devices the full brightness value for the light.
The alternative is to send the last value, but is this the desired operation? It might work this way in HomeSeer but I don't think its conceptualized the same in Home Assistant. If you want to turn the light on to a certain brightness, click the entity and slide the Brightness slider to where you want.

Does the status of a device update from HomeSeer?   I know a bunch of my lights are on in HomeSeer buy never reflect in Home Assistant


Map becomes blurry after moving the map because of CSS transitions (Chrome) (branch: master)

If you open any leaflet example in the current master branch and move the map a little bit, everything which is in view again (after it was outside) will be blurry.
Steps to reproduce:

Checkout current master branch
Open debug/map/map.html in Chrome
Zoom in a little bit, so that you can clearly read the brown text (below the coffee symbol)
Scroll to the right, so that this area will get out of view
Scroll to the left again to get the coffee shop back into view.
The text (and everything else) is now blurry.

Example View
Before:
After:
(It's best to open these two images in two tabs and switch between them to see the difference)
Browsers
Affected browsers:

Chrome 38.0.2125.111 Windows 7
Chrome 38.0.2125.111 Mac OS X 10.10

Unaffected browsers:

Internet Explorer 11.0.9600.17358
Mozilla Firefox 33.0.1

Analysis:
A quick bisect shows that commit a33eff73f0d46b326d6fe59a7072f31624527c23 is the cause. It seems that the introduction of the CSS3 transitions caused this behavior in Google Chrome.

I have the same problem using the leaflet 1.5.1 version, is it normal? Actually the demo is also blurry, here the screenshot:

I am using Chrome Version 75.0.3770.100


How to customize babel?

Hello everyone, I contributed my first package ( protected-react-routes-generator ) and published it on NPM, so i tried to make an example with codeSandBox ( it worked fine ), but when i tried to install it in my project the server gives me an error

So i tried to customize babel using .babelrc but it didn't work

here is my package folder structure

package.json
{
 "name": "protected-react-routes-generators",
 "version": "1.1.3",
 "author": "Mohammed Saber Mohammed",
 "description": "React protected routes generator",
 "main": "src/index.js",
 "license": "UNLICENSED",
 "keywords": [
   "React",
   "Protected",
   "Routes",
   "Router",
   "Protected-routes"
 ],
 "dependencies": {
   "react": "^16.12.0",
   "react-router-dom": "^5.2.0"
 },
 "repository": {
   "type": "git",
   "url": "https://github.com/MohammedSaberMohammed/protected-react-routes-generators.git"
 },
 "devDependencies": {
   "@babel/plugin-transform-react-jsx": "^7.12.16",
   "@babel/preset-react": "^7.12.13"
 },
 "babel": {
   "presets": [
     "react-app",
     "@babel/preset-react"
   ],
   "plugins": [
     "@babel/plugin-transform-react-jsx"
   ]
 }
}

.babelrc
{
  "presets": [
    "@babel/preset-react"
  ],
  "plugins": [
    "@babel/plugin-transform-react-jsx"
  ]
}

Any Clue ?
Thanks in Advance.

I fixed it by compiling my files before publish


Fix goroutine leak in startVMM

Issue #, if available:
N/A
Description of changes:
The statement <-ctx.Done() without a select {} wrapping it will cause a goroutine leak if ctx is context.Background() or context.TODO() (or any other context that doesn't get cancelled, intentionally or not).
This change allows the goroutine to exit if the VM exits on its own, in addition to waiting for ctx.Done(), preventing a goroutine leak in case people do pass in a context that doesn't get canceled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks, just one minor comment :)

Actually, one more, can you please add a signed off line to your commit message like:
Signed-off-by: Firstname Lastname<EMAIL_ADDRESS>

can you please add a signed off line to your commit message

Done

I'm not sure how to interpret the failing CI tests; it looks like maybe TestLoadSnapshot timed out. Is that a known issue @Kern-- or is it likely this PR could've caused it?


Bug fixes: Textblock layout | Handling of link markdown | Parsing warnings

Description
Fixes for:

Link markdown format: When a link destination has parenthesis the formatting is broken. E.g:
link renders as link with destination of https://adaptivecard.io/(aaa

Textblock elements with width=auto does not honor linebreak.

Parser warnings are not passed to consumer because the array that collects them is not allocated.

How Verified
To test for markdown:
{   "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",   "type": "AdaptiveCard",   "version": "1.0",   "body": [       {           "type": "TextBlock",           "text": "[Stay tuned to Know [aaa] (aa) more](https://aaa.bbb.com/(a)sites(Test).doc?somegar)bageValue*afafafafafafa(",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know [aaa] m (aa)ore](https://aaa.bbb.com/(a)sites(Test).doc?somegar)bageValue*afafafafafafa()",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](https://aaa.bbb.com/(a)sites(Test).doc?somegarbageValue)*afafafafafafa()",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](https://aaa.bbb.com/(a)sit(es(Test).doc?somegarbageValue)*afafafafafafa)*",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](https://aaa.bbb.com/(a)sites(Test).doc?somegarbageValue)*afafafafafafa()",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](google.com)",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](https://aaa.bbb.com/(a)sit(es(Test).doc?somegarbageValue)*afafafafafafa)",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more]()",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know)]()afafafa()",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more](",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more])",           "wrap": true       },       {           "type": "TextBlock",           "text": "[Stay tuned to Know more]",           "wrap": true       }   ] }

Microsoft Reviewers: Open in CodeFlow

@janusbal Can you separate this PR into two PRs? I can approve two issues, but markdwon takes longer for me to parse.In that way, markdown review won't block the rest of the prs.

@jwoo-msft we prefer to have the next sdk drop as many fixes as we can possibly include. We're fine with markdown changes going to more reviewers.


Don't throw violations for valid inputs with type="submit"

What is this?
We were getting false fails for "unlabeled inputs" that have type="submit" and a value attribute. These are valid inputs. This PR changes it so it will only throw a violation for inputs that have type="submit" but no value attribute.

@ryanflorence I'm not very invested in this project lately, can you add @Robdel12 as a contributor too?  Sounds like he's very interested https://twitter.com/robdel12/status/873197762468237312

@wyattdanger  @ryanflorence Yeah, just as a background it took about a month for me to get this package approved to use at work. It would be easier (& faster) to get fixes in and cut releases than to wait for another package to be approved.
Also, I'm going to assume since this is under the reactjs org most people are going to use this package over react-axe at first. So I'm willing to help out as much as you guys want :)


Add instructions for running windows image

It would be nice if there was a image/windows7/README.md that gave instructions to get windows running.

:+1:

Done. See docs/images.md


Invalid ids for objects

When using index.search or index.get_object, it sometimes returns object ids that are larger than the total length of the inserted data. When I try to delete these object Ids, I recieve an error saying that there objects are not in the index.
If I comment the remove function and uncomment the get_object, the code runs without error.
NGT-1.9.0
Python 3.8.2
RuntimeError                              Traceback (most recent call last)
 in
2 for i in tqdm(range(3606235, 3607995)):
----> 3     index.remove(i)
4 #     index.get_object(i)
5 index.save()
RuntimeError: /home/jupyter/NGT-1.9.0/lib/NGT/Index.h:1622: remove:: cannot remove from tree. id=3606236 /home/jupyter/NGT-1.9.0/lib/NGT/Tree.h:191: VpTree::remove: Inner error. Cannot remove object. leafNode=203725:/home/jupyter/NGT-1.9.0/lib/NGT/Node.cpp:260: VpTree::Leaf::remove: Cannot find the specified object. ID=3606236,0 idx=80 If the same objects were inserted into the index, ignore this message.

Do you use ONNG which is optimized from ANNG (default graph type)? When you use ONNG, removing objects causes inconsistency between the graph index and object repository including the tree index.

I was receiving the invalid indices before I tried to remove them from the graph. I tried to remove them because there are not part of the training set and they are values larger than the total dataset

If you got the index which has invalid object IDs only by inserting objects, I have no idea because I have not had such problems. Could you send the invalid index or your program to build the index, if possible?

Do you need the entire folder or is there a specific file which contains the necessary information. The entire folder is bigger than 60gb.  Below is the code that ran. There are 3606235 rows in the dataset and approx 200,000 in each batch
import numpy as np
import pickle
import ngtpy
from tqdm import tqdm
from multiprocessing import cpu_count
NUM_CPUS = cpu_count()

dim = 4007

index_path = '/mnt/disks/big/loocv-cosine-dim-4007.anng'
ngtpy.create(index_path, dim, distance_type='Cosine')
index = ngtpy.Index(index_path, ) # open the index

for i in tqdm(range(18)):

    # Load data sets
    with open('/mnt/disks/big/queryresults%s.pickle'%i, 'rb') as handle:
        result = pickle.load(handle)
    x, y1, y2, y3, y4, y5 = zip(*result)

    n = len(y1)
    x = np.array(x).reshape((n, dim))
    index.batch_insert(x, num_threads=NUM_CPUS)

    del x, y1, y2, y3, y4, y5

index.build_index(num_threads=NUM_CPUS) # build the index
index.save()

The entire folder is better. Can you put it anywhere where I can download?  Perhaps I can accept more than 60GB.


Train Collaboratively raises error during training

From a localhost web-client, uploading titanic data and clicking on Train Collaboratively raises recurrent errors (inspect page and check the console logs)
...
> Adding contribution from node 410578ec-1b93-425c-ab2f-56e33800b657 for round (0, 2)
********************************************************************************
Buffer is full. Aggregating weights for round (0, 2)

Error: timeout
    at Timeout._onTimeout (/Users/julien/Documents/DISCO/repo/discojs/discojs-node/dist/core/client/utils.js:13:64)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)`
...

Additionally, the training doesn't seem to ever stop.

@peacefulotter pointed at a potential cause in storeAggregationResult and Promise.race([promisedResult, client.utils.timeout()]) in the federated server implementation (server/src/router/federated/server.ts).
It seems that clients and server are both stuck waiting on each other's promise to returns, and systematically results in timeouts.

I think a way to fix this might be to remove the await result in storeAggregationResult. The await is already taken care by the Promise.race, having 2 awaits leads the storeAggregationResult to be one step ahead: first it awaits the results the server wants to respond with, then immediately skips it and turn the result into a new promise, finally the ws receives a message, and the callback receives the new promise and not the old result (which is what it wants).

Here is the sequence of event that was expected to happen:

Client sends local weights to server
Server receives weights
Server adds weights to aggregation
Client asks for new weights
Server receives query and puts client on hold (via a promise on aggregated weights)
Once enough contributions are received, the server aggregates them
The promise from 5. resolves and sends the aggregated weights to the clients

However, in some cases such as when there is a single client, step 6 happens before step 4, i.e., the server aggregated the weights and moved to the next round before even receiving the client's query 4.
Therefore, when the server actually receives the query, it has already moved to the next round and is now waiting for client's contributions. As a result, the server timeouts while waiting for client's contributions, who also timeouts while waiting for the server's new weights.
There are multiple ways to solve the issue. I thought the best one was to directly return the new weights whenever a client sent their contributions, thus skipping step 4. and 5.
In practice, we first create a promise waiting on the aggregated weights before adding the local contribution to make sure that the server doesn't move to the next round before resolving the promise (which as it resolves send the aggregated weights to the client).
Here is the new sequence of events:

Client sends local weights to server
Server receives weights
Server puts client on hold (via a promise on aggregated weights)
Server adds the weights to the aggregation
Once enough contributions are received, the server aggregates them
The promise from 3. resolves and sends the aggregated weights to the clients

So if I understand this correctly, the clients do not explicitly ask for the aggregated weights since it's assumed that they will eventually receive them after sending theirs?


39 timeout config v3

Add httpTimeoutInSeconds with default value 10 that helps to configure socket timeout
config = VisualRegressionTrackerConfig.builder()
                .apiUrl("URL")
                .apiKey("6NK4QdfsdsMsdf7NfsdfdsFJ9KNPB3")
                .project("92343c-21344-4b348-b02a-37448189f178")
                .branchName("master")
                .httpTimeoutInSeconds(15)
                .build();

Add tests for this functionality

Codecov Report

Merging #51 (214edda) into master (0761a69) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #51   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        27        27
===========================================
  Files              5         5
  Lines            106       110    +4
  Branches           4         4
===========================================
+ Hits             106       110    +4

Impacted Files
Coverage Δ
Complexity Δ

...sion_tracker/sdk_java/VisualRegressionTracker.java
100.00% <100.00%> (ø)
18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0761a69...214edda. Read the comment docs.


Repo sync for protected CLA branch

The pull request is created from main637877996968142260 to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add "no data" padding only when transforming dates

Simple fix to ensure that null padding (to display "no data" messages in charts) is added only when transforming reports associated with a date key.
See https://issues.redhat.com/browse/COST-256

Codecov Report

Merging #1582 into master will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #1582   +/-   ##
=======================================
  Coverage   78.41%   78.42%
=======================================
  Files         235      235
  Lines        3860     3861    +1
  Branches      702      703    +1
=======================================
+ Hits         3027     3028    +1
  Misses        739      739
  Partials       94       94

Impacted Files
Coverage Δ

src/components/charts/common/chartUtils.ts
72.53% <75.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48aeebe...fccd186. Read the comment docs.


Adding more native audio examples (something percussive/short)

It's great that there are new audio examples in the files, but having something with percussion/drums would be great.
I suggested the attached ages ag
Constanzo-PreparedSnare-M.wav.zip
o.

@rconstanzo we'll use this to remove some redundant sounds too. That might break many things so we will do it carefully.

Only just saw this now. Yeah, having a greater variety of stuff in there would be good.

see PR #135 on core and #184 on Max

closed with PR #135


Worker.run_job() not resiliant to asyncio cancellation

Currently, if a job fails with an error that extends BaseException but not Exception, the worker will find itself in an invalid state and crash (specifically, the log_action variable will not be set when trying to log the outcome of attempting the job).
A seemingly common situation this will arise in is when an asyncio CancelledError is raised. Happy to patch, just wanted to clarify what the expected behaviour should be - special case for catching CancelledError or catch and supress all BaseExceptions?

Hello ! Thanks for opening this.
I believe that suppressing BaseExceptions is a bad idea. I'd tend to say that when catching a BaseException (that's not an exception) we should do whatever needs to be done so that the finally clause is ok, and then reraise it (or maybe just initialize our variables to a sane default value before the try block and not add except clauses, your choice. I'd favor the latter, but I'll accept both.)

Thanks for taking a look. Having poked around the code a bit more, it's actually a little unclear to me what the expected status of the job should be in the event that a non-Exception gets raised - even if we re-raised the error from run_job() (after fixing the logging) it'll bubble up to process_job() where it'll break again.
I think my question here is whether procrastinate should attempt to schedule a retry of a job that fails with an exception extending from BaseException or just crash (or both)? For my use case either of supress-and-retry or retry-and-crash would work; the key thing I want to avoid is the job status not getting updated.

Retry/Finish and crash is the most expected behaviour, I believe.
If something issued a BaseException that isn't an Exception, it's a last resort issue that should not go unnoticed.

@ewjoachim, PR raised - let me know what you think when you have a moment. Cheers!

https://github.com/procrastinate-org/procrastinate/releases/tag/0.32.0

Much appreciated; cheers!

Thanks for your patience ! Always happy to welcome new contributors :)
(BTW, if you have feedback on the contribution process, or consider to spend some time helping the project later, feel free :) )


Is it hosted somewhere ?

Hey,
Did you host your project somewhere to test it as a client?

Hi, you may find a demo instance hosted on https://citadelles.herokuapp.com. This may be buggy with 4+ players in the same room though. I'll have to fix that someday.

It supports french, it's awesome !!
What do you mean by buggy ? 3 players is working perfectly well but with 4 to 7 it crashes ?

Thanks! I mean that I have thoroughly tested 2 and 3 players, but last time I played with 4 players some turns or actions were skipped.

If I have the opportunity to test it with 4 or more players, could it be interesting for you that I created issues ? Or don't you have time to fix it ? If I can help on any way doing tests I would be happy to do so.

Please do! I will definitely find some time to fix the bugs if I can reproduce them more easily.