Build: initial pass to support static archives on Windows

Introduce a SPM controlled build rule for building static libraries.
This is the intended way to use llbuild to drive the generation of
static libraries.  We would previously rely on the static default
rule intended for testing to generate the static libraries.  Not only
did this tool not properly support Windows, it would actually cause
problems on macOS due to the use of ar for the creation of the library
over the preferred tool - libtool.  We now locally determine the
correct rule and generate the command.
This is incomplete support for Windows and in fact regresses
functionality.  We no longer honour AR as an environment variable on
Windows and thus cannot switch the implementation of the librarian.  We
now drive the archiving through lld-link unconditionally while we
should prefer link unless otherwise requested.  This is covered as
an issue in #5719.

@swift-ci please smoke test

@swift-ci please smoke test

Approach looks good in general, but had a question about checking the name of the executable.
Also, should we mark as Draft while it's being iterated on?

Thanks for this work BTW!  Having SwiftPM take more control over the forming of the archiving command makes sense to me.

One more thought, for the future:  I know it's beyond the limited scope of this PR, but these changes remind me that at some point the generation of the actual command lines should be factored so that BuildPlan can be focused on the semantics without all the details.  One approach might be to have a protocol for each of the conceptual tools based on what they do ("archiver", etc), and then concrete types implementing that protocol to construct the actual command lines somewhere separately from the BuildPlan logic.  Again, just thoughts for the future since I'm seeing this code again, and not something to do for this PR.

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test macOS platform

@swift-ci please test

@swift-ci please smoke test

One more thought, for the future: I know it's beyond the limited scope of this PR, but these changes remind me that at some point the generation of the actual command lines should be factored so that BuildPlan can be focused on the semantics without all the details. One approach might be to have a protocol for each of the conceptual tools based on what they do ("archiver", etc), and then concrete types for the various implementations of that protocol to construct the actual command lines (separately from the BuildPlan logic). Again, just thoughts for the future since I'm seeing this code again, and not something to do for this PR. Would also make testing of the command line generation a bit simpler.

FYI, I filed https://github.com/apple/swift-package-manager/issues/5729 to track refactoring BuildPlan.swift someday.  Feel free to add ideas — it is certainly beyond the scope of this PR, I'm just reflecting that this PR would have been a bit cleaner if there were more separation of concerns in the code.

@compnerd, do you think we can get this into 5.7 before the release? I applied it to the last 5.7 source snapshot before building it for Android AArch64: it works well and allowed me to remove the llbuild hack I'm using for 5.6 to do the same.


Move the Approve button to the notification channel set in appsettings.json + minor change regarding the Waiting For Approval message

Apologies for this mess. I forgot about this PR when I made changes to my fork. This PR is still to be reviewed and merged.


Document how Ecto.Adapter.Queryable should be implemented

The documentation of Ecto.Adapter.Queryable is unclear of what is expected by the callbacks.
Especially if we have datastores for which only some types of queries make sense (like for instance simple key-value stores that only expose get and insert), it is not clear how this should be done using the given behaviour callbacks.

It is a module to handle queries. If you can process a full Ecto.Query,
then we cannot so much for you. I.E it wouldn’t fit a simple key value
store.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

:thinking: So if I would want to e.g. expose/allow only Repo.get when people use my Ecto adapter, how would one go about it?

Use before_compile to generate a custom function inside the repo. The
functionality you want to expose is not part of Ecto default.
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I see. For posterity: All calls that are done directly on a Repo are injected using before_compile. Ecto itself injects get/get_by/all/stream/etc... iff the adapter implements Ecto.Queryable.
This means that you can instead manually create your own implementations of (some of) these functions.

@Qqwy Ecto.Schema.Loader is private API. You can probably use Repo.load though.


validator fails due to bad environment variables

Noted elsewhere, but lacked a tracking ticket
core@core-01 ~ $ rocket/bin/rkt version
rkt version 0.5.1
appc version 0.5.1
core@core-01 ~ $ sudo rocket/bin/rkt --insecure-skip-verify run --volume database,kind=host,source=/tmp  https://github.com/appc/spec/releases/download/v0.5.1/ace-validator-main.aci     https://github.com/appc/spec/releases/download/v0.5.1/ace-validator-sidekick.aci
rkt: fetching image from https://github.com/appc/spec/releases/download/v0.5.1/ace-validator-main.aci
rkt: warning: signature verification has been disabled
Downloading ACI: [========================                     ] 1.13 MB/2.06 MB
rkt: fetching image from https://github.com/appc/spec/releases/download/v0.5.1/ace-validator-sidekick.aci
rkt: warning: signature verification has been disabled
Downloading ACI: [================                             ] 755 KB/2.06 MB
prestart OK
main FAIL
==> PATH not set appropriately (need "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin")
==> environment variable "SHELL" not set as expected (need "/bin/sh")
==> environment variable "HOME" not set as expected (need "/root")
==> environment variable "USER" not set as expected (need "root")
==> environment variable "LOGNAME" not set as expected (need "root")
==> Get http://<IP_ADDRESS>:80/acMetadata/v1/pod/manifest: net/http: request canceled while waiting for connection
sidekick OK
poststop OK
Sending SIGTERM to remaining processes...
Sending SIGKILL to remaining processes...
Unmounting file systems.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/pts.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/shm.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/sys.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/proc.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/console.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/tty.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/urandom.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/random.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/full.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/zero.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/dev/null.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/pts.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/shm.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/sys.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/proc.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/console.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/tty.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/urandom.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/random.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/full.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/zero.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/dev/null.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/db.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/db.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs/db.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs/db.
Unmounting /proc/sys/kernel/random/boot_id.
Unmounting /opt/stage2/sha512-3ab70b05b72133592ca5d9034981f854/rootfs.
Unmounting /opt/stage2/sha512-3930490f1ec99cfc49f2b19d6cec3d1f/rootfs.
All filesystems unmounted.
Halting system.

Appears to have been introduced by https://github.com/coreos/rocket/commit/310b3e1d7fd1d31331b922460f9f1cc7ca12f248

somewhat related, appc/spec#273


Owncloud 8.2

Managed to decrypt files encrypted with owncoud 8.2, specifically:
$OC_Version = array(8,2,0,12);
$OC_VersionString = '8.2.0';
$OC_Edition = '';
$OC_Channel = 'stable';
$OC_VersionCanBeUpgradedFrom = array(8,1);
$OC_Build = '2015-10-19T13:24:39+00:00 8ee2009de36e01a9866404f07722892f84c16e3e';
You might want to think about making the path to the data folder an optional parameter, though.

BTW thanks, you saved my files after mysql crapped out on me.

Glade to see it's working and it worked for you :)
I'll try to add the optional parameter for file path ASAP. If you want to send me a pull request, you're welcome too.

I added getopt(), you may give a try if you want ;-)


Bug in getData

Instead of
if ((self.Image && img instanceof self.Image)
            || (self.HTMLImageElement && img instanceof self.HTMLImageElement)
            && !img.complete)

it should be
if (((self.Image && img instanceof self.Image)
            || (self.HTMLImageElement && img instanceof self.HTMLImageElement))
            && !img.complete)

Seriously this bug impacts a lot

It actually makes such an impact in my project that I can't even use exif.js. (Well, I can now after reading the fix here).

This has been a known issue for 2 months now, with multiple PRs to fix. Not sure where the maintainer is?

My app quit working silently. This apparently fixed it. I'm not sure what changed as I haven't updated the plugin since I created the app.
Anyway, thanks.


Enchanted Book? Question

If I want to make a custom recipe for feather falling or riptide or any enchantment, how do I need to write the code in a .json file? I have two problems that say that the code doesn't work.
Example:
....
}
},
"result": {
"item": "minecraft:enchanted_book",
"count": 1
"StoredEnchantments:[{id:featherfalling,lvl:1s}]"
}
}
Have tried making it a bit simple but I get the error codes
Expected comma
Colon Expected
Don't know why they are occurring, help would be much appreciated

hi @RealCottonCandyPimp
you forgot a comma here "count": 1
I advise you to use a site like https://jsonformatter.curiousconcept.com/ to check your files

Thanks and thanks for letting me know about that website


Multiple selection of columns or rows

Hello, thanks for your great calendar library, I have tried it and something that could be improved a lot is the possibility of selecting a range of hours vertically and a range of dates horizontally

@aldabil21 Do you have any idea how this feature can be implemented?

Whats onthe top of my mind initially, I would replace the onClick of the Cell to open the editor, with a compination of pointerDown, pointerEnter and pointerUp , on pointerUp, I would calculate the selected cells time range.
Sorry I haven't been able to dig into this so far

Hi there! First of all @aldabil21 thanks for this amazing calendar library, this feature is really helpful, most of calendar libraries have this feature, so I really hope this one can be develop very soon! Thanks @javargasm for submitting it.

@aldabil21 I have not been able to make this feature even with your recommendations


Archiving IOS build is taking a lot of time after enabling hermes and MetroSerializer

What happened?
I am trying to archive the IOS build with hermes enabled, but it is taking a lot of time i.e. (~15-20x) times the time taken to build when hermes is disabled. I have tried this on multiple RN versions like 0.68.0, 0.71.8.
Even a simple RN app is taking almost 1 hour 15 minutes to archive the IOS build with hermes enabled and using esbuild bundler.
I am able to archive the build properly (i.e. without any effect on build time) in the following scenarios -

After disabling hermes and using the @rnx-kit packages such as
a. @rnx-kit/babel-preset-metro-react-native
b. @rnx-kit/metro-config
c. @rnx-kit/metro-serializer-esbuild
After using the default babel and metro config (which is shipped by default with RN project)

The esbuild is able to generate the JS bundle successfully in every scenario but the following step is causing issue.
Showing Recent Issues

/Users/AwesomeProject/ios/Pods/hermes-engine/destroot/bin/hermesc -emit-binary -O -out /Users/Library/Developer/Xcode/DerivedData/AwesomeProject-gfqsdgqywjohyjfoxkrvubakbthd/Build/Intermediates.noindex/ArchiveIntermediates/AwesomeProject/BuildProductsPath/Release-iphoneos/AwesomeProject.app/main.jsbundle /Users/Library/Developer/Xcode/DerivedData/AwesomeProject-gfqsdgqywjohyjfoxkrvubakbthd/Build/Intermediates.noindex/ArchiveIntermediates/AwesomeProject/BuildProductsPath/Release-iphoneos/main.jsbundle

Here is the metro and babel config which I am using.

package.json

I can't figure out why this is happening. Please let me know if I am missing some config here.
Affected Package
@rnx-kit/metro-serializer-esbuild, @rnx-kit/metro-config, @rnx-kit/babel-preset-metro-react-native
Version
0.1.23, 1.3.6, 1.1.4
Which platforms are you seeing this issue on?

[ ] Android
[X] iOS
[ ] macOS
[ ] Windows

System Information
% npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 13.3.1
    CPU: (8) x64 Apple M1
    Memory: 73.29 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 14.21.3 - ~/.nvm/versions/node/v14.21.3/bin/node
    Yarn: Not Found
    npm: 6.14.18 - ~/.nvm/versions/node/v14.21.3/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.0 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.1 AI-221.6008.13.2211.9619390
    Xcode: 14.3/14E222b - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.18 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.8 => 0.71.8
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to Reproduce

Install the above mentioned libs.
Change the babel.config.js and metro.config.js, as described in above mentioned screenshot.
Try to archive the IOS build.
The build process will take a lot of time in the following step (after successfully generating the JS bundle)

/Users/AwesomeProject/ios/Pods/hermes-engine/destroot/bin/hermesc -emit-binary -O -out /Users/Library/Developer/Xcode/DerivedData/AwesomeProject-gfqsdgqywjohyjfoxkrvubakbthd/Build/Intermediates.noindex/ArchiveIntermediates/AwesomeProject/BuildProductsPath/Release-iphoneos/AwesomeProject.app/main.jsbundle /Users/Library/Developer/Xcode/DerivedData/AwesomeProject-gfqsdgqywjohyjfoxkrvubakbthd/Build/Intermediates.noindex/ArchiveIntermediates/AwesomeProject/BuildProductsPath/Release-iphoneos/main.jsbundle

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @amanmoar277, I wonder if this is also related to https://github.com/microsoft/rnx-kit/issues/2416 and https://github.com/microsoft/rnx-kit/issues/2419. Can you try adding -w to the hermesc command and see if that helps? I suspect it has something to do with the warnings that are output by the compiler.

What you also can try to do is setting minifyWhitespace: false. This tells esbuild to not remove whitespaces, which will create shorter lines for Hermes to output:
const { makeMetroConfig } = require("@rnx-kit/metro-config");
const { MetroSerializer, esbuildTransformerConfig } = require("@rnx-kit/metro-serializer-esbuild");

module.exports = makeMetroConfig({
  serializer: {
    customSerializer: MetroSerializer([], {
      minify: true,
      minifyWhitespace: false,
      minifyIdentifiers: true,
      minifySyntax: true,
    }),
  },
  transformer: esbuildTransformerConfig,
});

Documentation: https://github.com/microsoft/rnx-kit/tree/main/packages/metro-serializer-esbuild#minifywhitespace

For fix and workaround, see https://github.com/microsoft/rnx-kit/issues/2416#issuecomment-1558774451.


python311Packages.pywemo: 0.9.2 -> 1.0.0

Changelog: https://github.com/pywemo/pywemo/releases/tag/1.0.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 238437 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.wemo
python310Packages.pywemo
python310Packages.pywemo.dist
python311Packages.pywemo
python311Packages.pywemo.dist


Update home page

Section 1
Office 365 image with message "how to get 162% ROI by switching to Office 365".
Section 2
Office 365 experts are everywhere. 10 tips to picking a pro.
(scripting, training)
Section 3
From IM, to bookings, to planner. Office 365 will do more than cut your IT costs in half. How to keep up and get the most from Office 365. (Talk about how to learn about the latest tools, but you need to know some aren't ready even though they're available.)
Section 4
Latest Posts: Cards showing the latest 3 posts.
Section 5
Reach Out: form with email, name, and message fields.

Section 1 & 3 are complete. I'm thinking about skipping section 2. I need to add images and a description to a post before I can add the Blog section. Lastly I need to add a table for Reach Out section.


doc(examples): fix header + adaptation + tweaks on material demo

This PR fixes the header, and adapt the style of each demo to fit the new fixed header.

awesome :)


Test: new terminal API adoption

Complexity: 2

[x] Linux @isidorn
[x] macOS @sandy081
[ ] Windows @egamma

The terminal added additional API to listen to the terminal output. The pros of this API are: no ANSI escape characters and lines are reported unwrapped as they are send from the underlying program.
Ansi escape character doesn't show up in problems

install eslint module (not the extension)
create a .eslintrc.json file
create a JS file that contains errors and warning covered by eslint
run eslint from a terminal and ensure that the errors correctly show up and are colored.
create the following task

		{
			"label": "ESLint",
			"type": "shell",
			"command": "./node_modules/.bin/eslint app.js",
			"windows": {
				"command": ".\\node_modules\\.bin\\eslint app.js"
			},
			"problemMatcher": "$eslint-stylish"
		}

run that task
ensure that all problems are capture correctly and that the messages don't contain wired characters in the problem view (e.g no ANSI control characters make it into the message).

Long lines

size the VS Code window small so that the output of a task gets wrapped. You can also make an error that produces a long message
run the task that captures the error (can be ESLint, TS, ....)
ensure that the error is captured correctly and that the whole message is available in the problems view.

Verified that problems are captured when the terminal has to wrap the lines onto multiple lines.


Device aware cache

Description
Activation cache now keeps tensors on the device of the respective layer.
If device is specified, run_with_cache will move all tensors to that device.
Addresses #246 #217 #248 #249 #202
The model now also respects the specific device you send it to (e.g. "cuda:1" vs "cuda")
See test_multi_gpu.py::test_cache_device for example use.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

Thanks Slava! I will get on a service with GPU's tonight and run the tests that aren't part of the CI before merging :)

Review checklist:

[x] https://github.com/neelnanda-io/TransformerLens/issues/246  (does what proposal suggests)
[x] https://github.com/neelnanda-io/TransformerLens/issues/217  (solves cache is not set to model device)
[x] https://github.com/neelnanda-io/TransformerLens/issues/248  (unit test does not fail on gpu)
[x] https://github.com/neelnanda-io/TransformerLens/issues/249  (fixes fails to load model on specific gpu)
[x] https://github.com/neelnanda-io/TransformerLens/issues/202 (early issue with this now fixed)

Thanks Slava! All good! Really appreciate the contribution! Sorry for the delay.


fix: add feature "selectedToTop"

Looking forward for your answer :)

Still seems like you use lodash. I'll try to implement the pluck method myself

I have already done it,  var selected contains all ids, I just forgot to replace it

Can you commit that? then I can merge this PR

Done

I'm going to add documentation and then release it

Okey. Thank you, waitinf for release:)


Publish Github releases with static Linux binaries

Hi, thanks for the awesome tool!
I'd like to use this in a CI build. The build would go faster and use fewer resources if I were able to download a statically-linked Linux executable from the Github releases, rather than use cargo install. It's actually pretty easy to set up Github Actions to automatically create draft releases with attached static binaries whenever you push a git tag. An example CI setup from one of my own projects is available here: https://github.com/langston-barrett/mdlynx/blob/main/.github/workflows/release.yml
Feel free to close this issue if this doesn't appeal to you or sounds like too much work, I just figured I'd share my use-case and the above link in case it's helpful!

i'm happy to accept a PR for this


Upload Object failed while using GCS as a backend

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:
When I tried to upload an object to the bucket which using GCS as the backend, I got error as below:

What you expected to happen:
I can put an object to the bucket successfully.
How to reproduce it (as minimally and precisely as possible):
Just register a GCS backend, and use it to create a bucket, and then upload an object to the bucket, you will get this error.
Anything else we need to know?:
Muiltipart-upload is still not work for GCS, it is traced by .
Environment:

Gelato(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

It's fixed in PR#850


Implement dynamic text overlay for resource generation

This PR:

Adds the class TextBoxDrawer to extract text field information from an AI-exported SVG file, and dynamically render text within those fields on a PNG image which has been exported without the text field layer.
Utilises this functionality in the barcode checksum poster resource.

Tests and documentation will be added before merging, but I'd like to get your thoughts after an initial pass before that if possible :)

Unit testing and documentation has been added

Adding @saranglove as a reviewer to review documentation of the process on the Illustrator end.


O11Y-2363: Widen http on 0.14.x line

O11Y-2363

Widen the http dependency range on the 0.14.x release line as well so that consumers who are on 0.14.x can resolve to http 0.13.x
Note this merge is targeting the 0.14.x branch, where a 0.14.4 release will be created from.

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Public API Changes
No changes to the public API found for commit 7062fa8920a12c0463dff49678b4a1eac1f17878
Showing results for 7062fa8920a12c0463dff49678b4a1eac1f17878

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

QA+1 CI Passes @Workiva/release-management-p


Page refresh on success

After installing the plugin we now see a new behaviour: Upon successfully submitting a form with success, we see a short success message before the page loads. Is this expected and/or how can we stop this from happening?
Craft <IP_ADDRESS>
Plugin 4.2.2
Contact Form 2.5.1
Contact form extensions 1.3.2

@Lorangd Not sure what you mean. Could you post your contact form template and if you are using AJAX to submit?

I have the same issue on a new website I'm working on. If I disable Recaptcha, the issue goes away. Weird because I use the same plugin with the same code on several other sites withotu any problem.


Jahnavikagopal-pr.md

https://github.com/Ramsey99/Admin_Dashboard/pull/38 level 1
https://github.com/iamrahulmahato/master-web-development/pull/1736?notification_referrer_id=NT_kwDOBzVGf7UxMzA0NzczMzAzNToxMjA5MzE5Njc#event-14925275979   level 3
https://github.com/mdazfar2/Ezyshop/pull/555#issuecomment-2429470056 closed by the PA so cannot give points
https://github.com/multiverseweb/Dataverse/pull/325#issuecomment-2466145108 level 2

@AKSHITHA-CHILUKA thank you so much


Add pluggable backend

If Kong runs with other NOSQL backend, for instance, LevelDB, MongoDB and Cayley, it would be great!

We are planning to add support to SQL first #331, as Cassandra is already a NoSQL database. But pull requests for other implementations are welcomed :)

If we want to create a pull request for other implementations, do you have suggestions on how to get started?  What would you like to see?


Enable eslint-plugin-react forbid span

Hey, I just made a Pull Request!
Enable the eslint-plugin-react for non-test files and forbid <span> tag in favor of MUI's <Typography component='span'>.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

This seems to need updating some inline snapshots.

Didn't know the PR auto closes if stale for too long...

I think that once it's marked stale, you get 5 more days before it closes:
https://github.com/backstage/backstage/blob/0b41cdfbc005aa9a439918c7919ce7dce1d0a2ab/.github/workflows/automate_stale.yml#L28


[Issue] AZURE_CREDENTIALS not set in new Github workflow, login fails

[X] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
Whatever's in mcr.microsoft.com/azure-dev-cli-apps:latest
Output from az version
N/A
Describe the bug
I updated my Github workflow to use the new login scheme, re-ran azd pipeline config locally on the very latest azd (azd version 0.5.0-beta.3), and pushed the Github secrets.
Unfortunately, the azd provision stage is ending in:
ERROR: loading environment: initializing environment: reading subscription id: no default response for prompt 'Please select an Azure Subscription to use:'

You can see the full output here, I even added --debug flag to help:
https://github.com/pamelafox/msdocs-django-postgresql-sample-app-azd/actions/runs/3925438619/jobs/6710359802
To Reproduce

git clone https://github.com/pamelafox/msdocs-django-postgresql-sample-app-azd/
Run azd pipeline config
Watch results of Github action

Expected behavior
I expected a successful deploy. I ported a very similar repo today as well (https://github.com/pamelafox/msdocs-flask-postgresql-sample-app-azd), and its workflows are fine, which is why I'm really flummoxed by this issue.

Update: I looked through the azd code and have a better understanding of the issue. I was getting an error on azd provision in this repo because my repo had an old AZURE_CREDENTIALS secret that didn't match the other env variables. Once I delete that secret, I get an earlier error on the login stage:
Run $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
  $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
  Write-Host "::add-mask::$($info.clientSecret)"

  azd login `
    --client-id "$($info.clientId)" `
    --client-secret "$($info.clientSecret)" `
    --tenant-id "$($info.tenantId)"
  shell: pwsh -command ". '{0}'"
  env:
    AZURE_CREDENTIALS:
Warning: Can't add secret mask for empty string in ##[add-mask] command.
Error: flag needs an argument: --tenant-id

That's because there is no AZURE_CREDENTIALS secret, and that's because Github pipeline config defaults to FCIS:
https://github.com/Azure/azure-dev/pull/1086
Is there guidance on how to update workflow for fcis? The latest release notes recommend an incompatible login flow:
- name: Log in with Azure
  run: |
    $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
    Write-Host "::add-mask::$($info.clientSecret)"

    azd login `
      --client-id "$($info.clientId)" `
      --client-secret "$($info.clientSecret)" `
      --tenant-id "$($info.tenantId)"
  shell: pwsh
  env:
    AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}

@wbreza can you take a look and update release notes as needed?

Updated release notes with instructions on the required updates for your github workflow depending whether you are using Client Credentials or Federated Credentials


Top level section header ignored in text/reST package description, not in text/markdown

When using text/reST for the package description in the METADATA package dist-info file, the top level section header is omitted in the rendered page, however it is included when the description is in text/markdown format.
This can be easily verified running python -m readme_renderer README.rst vs python -m readme_renderer README.rst.
Is this intentional? Looking at the docutils configuration used in readme_renderer it looks so. However, why are markdown and reST threated differently?

This issue is better reported over at https://github.com/pypa/readme_renderer
The basic answer is that the RST behavior is intentional, and the markdown behavior needs some work to make it on par with the RST behavior.

Closing in favor of https://github.com/pypa/readme_renderer/issues/260.


[v1.4.1] Webpack with CORS

When the fetched URL exposes the CORS header 'Access-Control-Allow-Origin': '*', the request fails.

A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.

Webpack is using this lib as a http module https://github.com/substack/http-browserify. And for some reason, the lib set by default xhr.withCredentials to true.
Adding withCredentials: false on params given to http module solves the issue  https://github.com/BigstickCarpet/json-schema-ref-parser/blob/v1.4.1/lib/read.js#L176
var req = protocol.get(
  {
    hostname: u.hostname,
    port: u.port,
    path: u.path,
    auth: u.auth,
    withCredentials: false,
  },
  onResponse
);

I created a branch on my fork https://github.com/zallek/json-schema-ref-parser/tree/bugfix/cors-webpack
commit: https://github.com/zallek/json-schema-ref-parser/commit/32c11792a79cd8e3e8a7b6b0e318894c2f155b2e
But I can't create PR for your repo because I need a target branch based on v1.4.1 tag.

This issue is fixed in newer versions of the library.  Please upgrade to the latest version, which includes many critical bug fixes, as well as many new features.


changelog: Prepare for 0.0.2 release

This is just my first stab at the changelog notes.. I wasn't sure what tone to use, and what resolution the changes should be described in. I basically generated the changes by doing git log v0.0.1...
Looking for feedback from @luise @kayousterhout @ejj in particular.

@luise addressed your comments

Overall this looks good (sorry for the slow review).  One thing I noticed in Spark's changelog is that they explicitly separate API changes (one section) from performance / stability fixes (in another section).  I think it would be good to do this, so that users can easily skin the top API changes part to see what potentially non-backward-compatible changes occurred (seems especially important as we do some major changes in the beginning).
Also, should we be updating this as new bugs are fixed (e.g., have a "future release" section that we keep up to date)?

I'm not sure what we'd consider API changes. I definitely think we should make breaking changes obvious.
It would be nice to have some sort of sections to make the changelog more readable. E.g. client, network, cloud providers.
I think updating the changelog as we go will make the contribution process difficult. I'm imagining people submitting PRs, and us having to go through a back and forth telling contributors to update the changelog. I don't feel strongly though.
Anyways, I'm going to merge this as is now because I want to get the release out, and we can refine the changelog format in the next release.

Oh yeah that's a good point re: contribution process.  I agree that it's better to trade some additional work for whoever does the release for an easier process for contributors.

FWIW, RE change log.  I think we internally should do it, but we shouldn't gate contributions on it.  I.E. if some community member submits a PR, we could submit another PR on top of it that fixes up the change log.


Refactoring

The blacklist checker had errors because the dependencies changed.
I decided to integrate govendor to prevent this issue in the future.
I also decided to remove different log level as it is kind of an overkill for such a small application to have seperate log levels.

I updated it and tested it on several servers with different /etc/resolv.conf files... (which was the problem originally)

Facing some compiling problems... will investigate further


Actuator endpoints are forbidden

First I'd like to thank the developers for this awesome project.
I'm using Acrarium's docker image f43nd1r/acrarium:latest in Kubernetes and I passed Actuator's properties as Environment variable to enable it, however when I visit /actuator/health I get HTTP Status 403 – Forbidden
This is how I passed actuator properties to Acrarium container:
containers:
     - name: acrarium-container
       image: f43nd1r/acrarium:latest
       imagePullPolicy: Always
       ports:
          - containerPort: 8080
       env:
         - name: SPRING_APPLICATION_JSON
           value: '{ "management": { "endpoints": { "enabled-by-default": true }, "endpoint": { "health": { "show-details": "always", "probes": { "enabled": true } } }, "health": { "livenessState": { "enabled": true }, "readinessState": { "enabled": true } } } }'

please permit actuator endpoints in your security configuration so we can profit from Actuator.
Thanks.

Thanks! But what if i wanted I to give actuator endpoints to Kubernetes for liveness and readiness probe ?

Then you'll need to provide kubernetes with the credentials to a user account. You can create one with just the API permission.

Can you please provide an example on how to pass these credentials to the acrarium container ?

Not sure what you need. This?
curl -u username:password https://server:8080/actuator/health

My Acrarium deployment is like this:
containers:
        - name: acrarium-container
          image: f43nd1r/acrarium:latest
          imagePullPolicy: Always
          ports:
            - containerPort: 8080
          env:

             # mysql env properties here...

            - name: SPRING_APPLICATION_JSON
              value: '{ "management": { "endpoints": { "enabled-by-default": true }, "endpoint": { "health": { "show-details": "always", "probes": { "enabled": true } } }, "health": { "livenessState": { "enabled": true }, "readinessState": { "enabled": true } } } }'

      livenessProbe:
            httpGet:
              path: /actuator/health/liveness
              port: 8080
            initialDelaySeconds: 30
            periodSeconds: 30
            failureThreshold: 3

          readinessProbe:
            httpGet:
               path: /actuator/health/readiness
               port: 8080
            initialDelaySeconds: 15
            periodSeconds: 30
            failureThreshold: 3

I really don't know how to pass the authentication to the container.

I have no experience with Kubernetes, but I'll redirect you to a hopefully helpful stackoverflow post: https://stackoverflow.com/questions/33484942/how-to-use-basic-authentication-in-a-http-liveness-probe-in-kubernetes

Thank you @F43nd1r for your help! I really appreciate it.


darling: fix build with ffmpeg_7

add patch from upstream commit:
https://www.github.com/darlinghq/darling/pull/1537
https://www.github.com/darlinghq/darling/commit/9655d5598c87dcb22c54a83cc7741b77cb47a1b0

Fixes build of darling (fails since 2024-10-13):
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.darling.x86_64-linux
https://hydra.nixos.org/build/274829843
Error log:
[11721/25908] Building CXX object src/CoreAudio/AudioToolbox/CMakeFiles/AudioToolbox.dir/AudioConverterImpl.cpp.o
FAILED: src/CoreAudio/AudioToolbox/CMakeFiles/AudioToolbox.dir/AudioConverterImpl.cpp.o
/nix/store/3h5kbycdgc66c6p5927233wavdfirdbg-cc-wrapper-bypass/bin/clang++ -DAudioToolbox_EXPORTS -DDARLING -DDARWIN -DENABLE_PULSEAUDIO -DHAVE_AV_FRAME_ALLOC=1 -DPLATFORM_MacOSX -DTARGET_OS_MAC=1 -D_DARWIN_C_SOURCE -D_LIBC_NO_FEATURE_VERIFICATION -D_POSIX_C_SOURCE -D__APPLE__ -D__DYNAMIC__ -D__MACH__ -I/build/source/build/src/CoreAudio/AudioToolbox -I/build/source/src/external/libcxx/include -I/build/source/build/src/include -I/build/source/src/include -I/build/source/basic-headers -I/build/source/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include -I/build/source/build/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include -I/build/source/framework-include -I/build/source/framework-private-include -I/build/source/src/external/lkm/include -I/build/source/src/libDiagnosticMessagesClient/include -I/build/source/src/libMobileGestalt/include -I/build/source/src/lib/include -I/build/source/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/libxml2 -I/build/source/build/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/libxml2 -I/nix/store/bakyrc1qx6imk38276zpf4b4hlzpqi62-ffmpeg-7.0.2-dev/include -I/nix/store/apr4nzqrfv9bidsswxgmzhghsj4fn9i0-pulseaudio-17.0-dev/include -I/build/source/src/startup/mldr/elfcalls -I/build/source/src/CoreAudio/AudioToolbox/../include -I/build/source/src/CoreAudio/AudioToolbox/../include/AudioToolbox -isystem /nix/store/qb1x0mipbcvnkr40xwiwp24gg8lffrc0-clang-wrapper-18.1.8/resource-root/include -Wno-nullability-completeness -Wno-deprecated-declarations -Wno-availability -Wno-expansion-to-defined -Wno-elaborated-enum-base -Wno-undef-prefix -mmacosx-version-min=11.0 -std=c++17 -fPIC   -target x86_64-apple-darwin20  -B /build/source/build/src/external/cctools-port/cctools/misc/ -arch x86_64 -B /build/source/build/src/external/cctools-port/cctools/misc/ -arch x86_64 -MD -MT src/CoreAudio/AudioToolbox/CMakeFiles/AudioToolbox.dir/AudioConverterImpl.cpp.o -MF src/CoreAudio/AudioToolbox/CMakeFiles/AudioToolbox.dir/AudioConverterImpl.cpp.o.d -o src/CoreAudio/AudioToolbox/CMakeFiles/AudioToolbox.dir/AudioConverterImpl.cpp.o -c /build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:103:8: error: no member named 'channels' in 'AVCodecContext'
  103 |                 cIn->channels = inSourceFormat->mChannelsPerFrame;
      |                 ~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:106:52: error: no member named 'channels' in 'AVCodecContext'
  106 |                 std::cout << "Converting from PCM with " << cIn->channels << " channels at " << cIn->sample_rate << " Hz\n";
      |                                                             ~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:134:13: error: no member named 'channels' in 'AVCodecContext'
  134 |         m_encoder->channels = m_destinationFormat.mChannelsPerFrame;
      |         ~~~~~~~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:136:13: error: no member named 'channel_layout' in 'AVCodecContext'
  136 |         m_encoder->channel_layout = CAChannelCountToLayout(m_destinationFormat.mChannelsPerFrame);
      |         ~~~~~~~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:164:16: error: no member named 'channel_layout' in 'AVFrame'
  164 |         m_audioFrame->channel_layout = m_encoder->channel_layout;
      |         ~~~~~~~~~~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:164:44: error: no member named 'channel_layout' in 'AVCodecContext'
  164 |         m_audioFrame->channel_layout = m_encoder->channel_layout;
      |                                        ~~~~~~~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:167:78: error: no member named 'channels' in 'AVCodecContext'
  167 |         int audioSampleBuffer_size = av_samples_get_buffer_size(nullptr, m_encoder->channels, m_audioFrame->nb_samples, m_encoder->sample_fmt, 0);
      |                                                                          ~~~~~~~~~  ^
/build/source/src/CoreAudio/AudioToolbox/AudioConverterImpl.cpp:177:66: error: no member named 'channels' in 'AVCodecContext'
  177 |         if (int err = avcodec_fill_audio_frame(m_audioFrame, m_encoder->channels, m_encoder->sample_fmt,
      |                                                              ~~~~~~~~~  ^

build fails since default ffmpeg got updated to ffmpeg_7 in https://github.com/NixOS/nixpkgs/pull/337855

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

(And sorry for not catching more of them; it was a hell of a staging cycle.)


Custom merge hook for a module - to be executed on assembly.

Every time I build the full project (or another assembly method), I would like to make sure that building it with a subproject "sites" an action is executed

ok, it will be added a special hook for performing any action (like adding extra from() call) when building assembly, but configured at merged project side

ui.apps/build.gradle.kts
    tasks {
        packageCompose {
            dependsOn(":app:aem:ui.frontend:webpack")
            mergePackageProject(":app:aem:core")
        }
    }

core/build.gradle.kts
tasks {
    packageCompose {
        merging { assembly ->
            assembly.vaultDefinition.property("test", "alalala")

            // other example
            assembly.from(file("extra-dir-only-in-ui.apps-but-located-in-core"))
        }
    }
}

now package being merged could customize assembly; in other words, composing could be controlled for itself and separately (extras) for merged assemblies
to be released in 11.0.0
@ub1k24


Laravel translation

Adding ability to hold current locale json translation with inertia response, later in vue adapter we can also add translation function like next:
  __(key, replace = {}) {             var translation = this.$page.props.language[key]                 ? this.$page.props.language[key]                 : key             Object.keys(replace).forEach(function (key) {                 translation = translation.replace(':' + key, replace[key])             });             return translation         }
That give us translation like normal in blade component ex:
{{__("Hi")}}

No plans for this sorry.


Uninitialized variable in motion controller

target_angle (motion_controller.cpp:151) is not initialized when created, and the no_face path through the switch does not set it to a value. We know it won't be used when using no_face, but the compiler is not convinced and errors out.
This got flagged while I was doing a clean build on a new computer and repro'd with a clean build on my other computer. I have no idea why CI is not catching it. Probably worth figuring that out.

This did not repro on my native linux machine. The other two machines I did see it on were in WSL.
Seems like this is somehow a WSL-specific issue??


SkyShadowHero's pull

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

I use this amazing domain for my blog.
Link to Website

skyshadowhero.github.io

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request


Bug invalid or unknown key: performance_insights_enabled

Using v1.29.0 I now get the following error
Error: module.db_instance.aws_db_instance.this: : invalid or unknown key: performance_insights_enabled

Reverting back to version 1.28.0 makes it work again. I'm using terraform v0.11.14
I didn't specify anything extra, compared to my v1.28 usage, so somehow the default value performance_insights_enabled didn't kick in properly.

It must be related to aws provider version you are using, make sure it is atleast 2.8.0 version or make it to latest.
https://github.com/terraform-providers/terraform-provider-aws/pull/6453
provider "aws" {
  version = ">= 2.19.0"
}

Yes indeed my aws provider is specified lower than that.
My version is like this:
provider "aws" {
  region = "eu-west-1"
  profile = "my-profile-name"
  version = "~> 1.54.0"
}

Updating it to 2.19.0 fixes the issue. Is the minimum aws provider version specified in the docs somewhere? That might be a welcome addition ;)

Currently, there is no easy way to track which release of this module has specific version requirements. This will, hopefully, become easier and will require less manual archeological work in the upcoming releases of Terraform registry.
Closing for now, because the issue has been solved.


Warning in logs

Found this in logs, might need fixing:

2024-10-30 22:27:44.900 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration london_tfl with title: 490G00013869 and entry_id: 01JBFRNFCY3X6C66N20HXHP1DK, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

Ah, yeah. Noticed this a while ago and forgot about it. Will try to tackle when I get some free time, which has not been in abundance recently.

Decided to just tackle it now. Was a lot more trivial than I expected. Will get a new version committed, but you can safely ignore the warning for now.


[BUG]: Dreambooth inference

🐛 Describe the bug
我这边用4块k80跑dreambooth的inference.py
环境按照requirements进行安装。运行后错误如下：

Environment
torch 1.12
cuda：11.3
nvcc: 11.3
宿主环境，未用docker

We are trying to reproduce this issue to see what goes wrong.

Are you undervolting and/or overclocking your GPU? In my experience if your clock/voltage settings are not 100% stable you sometimes get random CUDA errors like these.
See similar issues here:
https://github.com/pytorch/pytorch/issues/21819#issue-456511677


Cleaned up CSS, added meta description tag

A strange bootstrap bug was causing the query label to disappear.
I also added a meta description tag, which should mildly help with SEO.
Demo live at https://varunnsrivastava.github.io/SemanticFinder/.

It turns out that the bootstrap bug is not actually being fixed on the github site deployment of the PR (though it is working with local builds via npm run start). So this issue will have to be revisited.


[evergreen-travis] Update .travis.yml node versions

This is an automated PR, by the evergreen-travis project.
It helps you to keep the versions of node in your travis CI configuration up to date with new releases.

If you do not want to receive these PRs then remove your repository from our repository list

Coverage remained the same at 100.0% when pulling dbbf6dfe42df2e97d33914a60231803a3a514d63 on evergreen-travis:evergreen-travis-1479398770772 into 59512c229cdf66b325a87f56c150bde5e7306467 on Kikobeats:master.


squid:S1989 - Exceptions should not be thrown from servlet methods

This pull request is focused on resolving occurrences of Sonar rule
squid:S1989 - Exceptions should not be thrown from servlet methods.
This pull request removes 60 minutes of technical debt.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1989
Please let me know if you have any questions.
George Kankava

Coverage remained the same at 93.055% when pulling 53b41089d0d006521472916384a83086cc714804 on DevFactory:release/exceptions-should-not-be-thrown-from-servlet-methods-fix-1 into 039180740ff91ff7b7dcbcf475bff2e16aa034a4 on clun:master.


Neo cli start consensus

start consensus from --start-consensus option

@purplesoft-io You can move the options for --start-consensu into UnlockWallet section in config.json too.
Please merge #152 first.


Cleaning and compression of raw html

Dear authors, I would like to ask how I can utilize part of your work to clean and compress a raw html file to get a new compressed html file. By reading the official website, I tried to use the python library functions you provide to do this, and I wonder if this should be the idea?
Another question is: if those python libraries are utilized, would this involve the selection of candidates, that is, keeping the content corresponding to the candidate? Wouldn't that require artificially setting the candidate in advance?
One of my ideal effects would be to input the html file, then process it through, and the output would be the html file after the operation, so if I need to set the candidate ahead of time wouldn't I be missing automation?
Looking forward and thank you for your insights and replies!

I would like to ask how I can utilize part of your work to clean and compress a raw html file to get a new compressed html file.

Although you may find the library useful for cleaning html files, it is not the primary goal of this library; rather, our goal is to process the html files so they can be ingested by LLM models for predicting web actions.

if those python libraries are utilized, would this involve the selection of candidates, that is, keeping the content corresponding to the candidate? Wouldn't that require artificially setting the candidate in advance?

You can use the DMR retriever to dynamically find relevant candidate, given a context (action history similar to those of weblinx). See this example for concreteness: https://github.com/McGill-NLP/webllama/blob/main/examples/complete/run_all.py

One of my ideal effects would be to input the html file, then process it through, and the output would be the html file after the operation, so if I need to set the candidate ahead of time wouldn't I be missing automation?

If I understand your question correctly: you can use the DMR model as part of your automation pipeline, so you can get candidates automatically given raw html, bounding boxe coordinates and action/dialogue history.


⚠ Mobitopup has degraded performance

In b936952, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5920 ms

Resolved: Mobitopup performance has improved in 3aba8ca.


Sending POST http request for Job.build(Map<String, String> params, boolean crumbFlag) with crumbFlag=true raised java.lang.IllegalArgumentException: Name may not be null

Hi, I am quiet new to Jenkins client API. I'm trying to use the Job.build method to kick off a parameterized job with crumb flag set to true.
However, it threw this exception:
java.lang.IllegalArgumentException: Name may not be null
	at org.apache.http.util.Args.notNull(Args.java:54)
	at org.apache.http.message.BasicHeader.<init>(BasicHeader.java:61)
	at com.offbytwo.jenkins.client.JenkinsHttpClient.post(JenkinsHttpClient.java:233)
	at com.offbytwo.jenkins.model.Job.build(Job.java:151)

Inspecting further in JenkinsHttpClient.java, it looks like the issue is with crumb issuer path:
Crumb crumb = getQuietly("/crumbIssuer", Crumb.class);

Shouldn't this be crumbIssuer/api/xml or crumbIssuer/api/json??
I can't turn off CSRF in this Jenkins instance, so that's not an option. How can I workaround or fix this issue?

@mw32 Could you post your code that you are using to build the job. I have unchecked the CSRF option in Jenkins server /configureSecurity. I am using below code  to create a job by passing config.xml -
HttpClientBuilder builder = HttpClientBuilder.create();
		JenkinsHttpClient client = new JenkinsHttpClient(uri, builder, "XXX", "XXX");
		JenkinsServer jenkins = new JenkinsServer(client);
		String sourceXML = readFile("src/main/resources/config.xml");
		System.out.println(String.format("Installed Jenkins Version >> %s", jenkins.getVersion().getLiteralVersion()));//works and gives correct result
		jenkins.createJob("test-nov1", sourceXML);

I am using createJob() Method to create job in Jenkins but getting 403 error even though passing correct username and password or token. Moreover, what I found is that, when I hit through user name and password/token, it is logged in as anonymous user than actual user that is passed as parameter. Hence throwing 403 error as unauthorized.
Please help me out if you have some thing on this.
Thanks

@kumarshorav11 - It's a very simple build call:
def runBuild(jobName: String) = {
  val server: JenkinsServer = new JenkinsServer(jenkinsURI, jenkinsConfig.user, jenkinsConfig.password)
    val details = server.getJobs.get(jobName).details
    val queue = details.build(true)
    queue
  }

This seems to be OK as far as credentials go, but the problem is as stated above, it looks like it's attempting to get the crumb from the wrong crumbIssuer path.

@mw32 Thank U so much for your quick answer. Yes, my password is correct as per WebUI. I am using same password that I have used for jenkins web ui to log in.


Exception Error when running from first time 7th Heaven (canary <IP_ADDRESS>)

I have decided to do a clean install of FF7 and FFNx+7th (canaries). I'm using Windows 10 x64, as Admin.
After downloading canary <IP_ADDRESS> of 7H, I unzip the file to C:\Games\7th Heaven. When I try to run it, I get an exception error.
I have installed Final Fantasy VII, PC '98 spanish version on C:\Games\Final Fantasy VII before unpacking 7H to the previous mentioned folder.
I leave the applog of 7H. It seems that does not create the theme.xml, settings.xml, catalog.xml, library.xml or version.xml files in 7thWorkshop folder.
applog.txt

I'll fix this once #36 is merged.

@julianxhokaxhiu do you know how this is possible?

@julianxhokaxhiu do you know how this is possible?

Where there's no installation path set ( fresh install, no ff7 detected ) then this might happen. I have an idea how to fix this as we have a unique class in the entire codebase now to handle the FFNx Configuration, so I don't need to initialize a global Sys object to hold the path to the FFNx.toml file.

I don't know if this will help, but you can get the FF7.EXE path from registry when PC98 version is installed, and I think this works for any PC98 localized version.

The detection uses the registry as part of its detection but I don't think it's the copy from the WOW6432 node, however, I'm not even sure how that key got installed there FF7 predates 64Bit windows by quite some time, so might be some windows trickery happening on entry of that record that might not be happening on 7th heaven due to it being compiled as x86_32 (the 32 bit on 64-bit assembly type), will need looking into. might be the detection needs another key path to check for the game.

AFAIK, from W8.1 I think, when installing old Windows apps (WinXP, 2000, etc...) 32bits, the registry data that the installers put in Windows, do it in WOW6432Node entry. So, it is normal it is in this entry.

apply patch 1.02 Spanish ok, EU disk installer i had when this released, asked you to select a language, what copy of the disks do you have? maybe different versions of the disk installer at play here...

The detection system uses the registry as part of its detection but I don't think it's the copy from the WOW6432 node, however, I'm not even sure how that key got installed there FF7 predates 64Bit windows by quite some time, so might be some windows trickery happening on entry of that record that might not be happening on 7th heaven due to it being compiled as x86_32 (the 32 bit on 64-bit assembly type), will need looking into. might be the detection needs another key path to check for the game.

That's exactly the case. I remember I had this patched in 7th 1.5 long time ago, but probably the patch never mad its place on this version. This might be the real solution to this issue. I'll look into it this evening.

apply patch 1.02 Spanish ok, EU disk installer (from the UK) i had when this released, asked you to select a language, what copy of the disks do you have? maybe different versions of the disk installer at play here...

No, no, spanish PC98 retail disk does not asks for any language. It installs directly (with spanish installer). Even it has a problem (if you have installed a previous version of FF7 PC98), that it gives an Error 432 the installer. You must delete from Windows directory the files IsUn040a.exe and IsUninst.exe (if not you can not install/reinstall it):

FYI, even the auto-converter works well. ;)

Registry keys detection works fine and nothing has to be done. The crash is completely unrelated and it was introduced by #33 when I mistakenly thought I could use one property on init. This has now been fixed in #37.


[SPARK-12813][SQL] Eliminate serialization for back to back operations

The goal of this PR is to eliminate unnecessary translations when there are back-to-back MapPartitions operations.  In order to achieve this I also made the following simplifications:

Operators no longer have hold encoders, instead they have only the expressions that they need.  The benefits here are twofold: the expressions are visible to transformations so go through the normal resolution/binding process.  now that they are visible we can change them on a case by case basis.
Operators no longer have type parameters.  Since the engine is responsible for its own type checking, having the types visible to the complier was an unnecessary complication.  We still leverage the scala compiler in the companion factory when constructing a new operator, but after this the types are discarded.

Deferred to a follow up PR:

Remove as much of the resolution/binding from Dataset/GroupedDataset as possible. We should still eagerly check resolution and throw an error though in the case of mismatches for an as operation.
Eliminate serializations in more cases by adding more cases to EliminateSerialization

/cc @cloud-fan

Test build #49353 has started for PR 10747 at commit 4615c96.

Test build #49353 has finished for PR 10747 at commit 4615c96.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait ObjectOperator extends LogicalPlan
case class MapPartitions(
case class AppendColumns(
case class MapGroups(
case class CoGroup(
trait ObjectOperator extends SparkPlan
case class MapPartitions(
case class AppendColumns(
case class MapGroups(
case class CoGroup(

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49353/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49356/
Test FAILed.

test this please

Test build #49360 has started for PR 10747 at commit ee7f3c6.

Test build #49360 has finished for PR 10747 at commit ee7f3c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49360/
Test PASSed.

Test build #49404 has started for PR 10747 at commit ecde6e5.

Test build #49404 has finished for PR 10747 at commit ecde6e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49404/
Test PASSed.

Merged build finished. Test PASSed.

Test build #49417 has started for PR 10747 at commit c34aacf.

Test build #49417 has finished for PR 10747 at commit c34aacf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49417/
Test PASSed.

LGTM

Thanks for reviewing!  Merging to master.


fix service restart

fixes #230

@imikushin I have updated all of the Godeps, including the latest rancher-compose.  For now if you need to change rancher-compose code put in a PR to rancherio/rancher-compose repo in the refactor branch.  By next wednesday it will be master and a bit less confusing.


Support for archive mode

This adds support for a 3rd option for creating mocks after reflect and source-mode: the archive mode. Archive mode lets you load archive files to create mocks. This can come in handy for writing Bazel rules that produce intermediary archive files and automatically codegen mocks in Bazel environments.

Given the amount of code added in the form of InterfaceFromGoTypesType do you think it makes sense to add some type of test that reads from a checked in archive?

Yes, that's a good suggestion. Will make that change.


Availability of background datasets

Hi @romainsacchi, thanks a lot for your work.
I am wondering where to find the datasets referenced in background_systems.py, namely

S_concentration_fuel.csv
biofuel_share.csv
electricity_mixes.csv
region_mapping.csv
cumulative_electricity_losses.csv

Also, are there other required data files that I am missing here, but are required to run carculator_bus?
Thank you

Hi @selimyoussry,
carculator_bus depends on [carculator_utils](https://github.com/romainsacchi/carculator_utils).
You should be able to find all the files you need here: https://github.com/romainsacchi/carculator_utils/tree/master/carculator_utils/data
When you pip install carculator_bus, it should therefore install carculator_utils. So, in principle, all the needed files are there. If not, let me know.


pythonPackages.pytz: 2020.04 -> 2020.05

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/rebase-staging

/rebase-staging

Let's just add it to the next python-staging. @FRidh

Let's just add it to the next python-staging. @FRidh

@jonringer ping

@jonringer ping


Docs > Fix bundle class name

Otherwise I get an error:
Attempted to load class "GraphqliteBundle" from namespace "TheCodingMachine\GraphQLite\Bundle".
Did you forget a "use" statement for "TheCodingMachine\Graphqlite\Bundle\GraphqliteBundle"?

Closing as it doesn't seem to get merged anyway ;)

It's still a valid typo fix


Set limit on attachments

This PR is to fix 160675.  When a single attachment is larger than 150mb on chrome or firefox it causes the browser to crash when the files are added, This PR fixes that by adding a threshold property that will be true if file size is over 150mb.  Right now the only cue to user is an alert that tells them one of the attached files is too large.

All your concerns have been addressed - should be good to go.

Replaced by https://github.com/webex/react-widgets/pull/1114 so bug can be closed.


Multiple issues with tests

Tests won't work out of the box because they are expecting a setup of self.phantom in the test. Probably need to add some documentation to set that up, because many of these tests are integration ones as they need to connect to a running SOAR instance.
Line 27 : There is use of open() outside of a "with" block which raises warnings of the type "ResourceWarning: unclosed file"
Line 71 : of test_PhantomClient.py: soarsdk.Exceptions.ContainerNotInitialized should be soarsdk.exceptions
Line 252 : test_modify_container_label needs to set self.container.id to something
The following two functions are missing from PhantomClient:

There is an error with 'PhantomClient' object has no attribute 'get_cronjob_count'
There is an error with 'PhantomClient' object has no attribute 'get_playbook_count'

The following function is missing from PhantomClientTests

There is an error with 'PhantomClientTests' object has no attribute 'get_sample_playbook'

Hi, thanks for letting me know. I've been inactive for the past few months due to health issues. Take a look at #9


Get error in the initialization regex

When I ran src/scripts/rte/da/eval_da.py, it shows that "Did not use initialization regex that was passed: .*token_embedder_tokens\._projection.*weight". And my allennlp version is 0.2.3. So how to solve this error?

And I use the pre-trained model.


[3.x] Improve add item type UI in theme editor

3.x version of #50631 which is hard to cherry-pick since the theme editor implementation is a bit different.

Thanks!


(iOS) Crash on navigating back

When navigating to a new component and then returning back to a page with a Pager component on, the app crashes with this log:
src/ios/pager.js:79:29: JS ERROR TypeError: null is not an object (evaluating 'this._ios.view')

See demo branch here:
https://github.com/ddfreiling/nativescript-pager/commits/demo-ng-test

Same problem here

Fixed


Optimize isnan (2-5x faster)

Which issue does this PR close?

Closes #.
Rationale for this change

Apply same idea from https://github.com/apache/datafusion/pull/12881 to isnan.
What changes are included in this PR?

Add bench for is_nan
Optimize implementation

Are these changes tested?

Yes, with existing tests.
Are there any user-facing changes?
Yes, faster is_nan function.
isnan f32 array: 1024   time:   [794.46 ns 795.95 ns 797.51 ns]
                        change: [-60.752% -60.453% -60.230%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

isnan f64 array: 1024   time:   [694.70 ns 698.25 ns 702.33 ns]
                        change: [-66.246% -66.029% -65.767%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  6 (6.00%) high mild
  4 (4.00%) high severe

isnan f32 array: 4096   time:   [2.5207 µs 2.5282 µs 2.5358 µs]
                        change: [-64.245% -64.126% -64.015%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

isnan f64 array: 4096   time:   [2.0779 µs 2.0812 µs 2.0847 µs]
                        change: [-74.140% -74.042% -73.950%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

isnan f32 array: 8192   time:   [4.9547 µs 4.9730 µs 4.9971 µs]
                        change: [-74.219% -74.059% -73.933%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) high mild
  2 (2.00%) high severe

isnan f64 array: 8192   time:   [4.0478 µs 4.0562 µs 4.0652 µs]
                        change: [-82.993% -82.947% -82.900%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

Thanks @simonvandel and @jonahgao  -- I merged this PR up to resolve a conflict


Unable to connect from inside azure container instance.

We have a simulator solution, which is an IoT device that sends JSON data to IoT hub in some interval, it using the python3 and azure-iot-device library

whatever our codebase is is running fine locally in windows, MAC and Ubuntu

whenever it's being deployed to azure container and running from the azure container instance, in the log the bellow error is coming

Starting initialization of Client . . .
ConnectOperation: completing with error UnauthorizedError('Connection Refused: not authorised.')
ConnectionLockStage(ConnectOperation): op failed.  Unblocking queue with error: UnauthorizedError('Connection Refused: not authorised.')
ConnectOperation: completing with error UnauthorizedError('Connection Refused: not authorised.')
Callback completed with error UnauthorizedError('Connection Refused: not authorised.')
NoneType: None
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/azure/iot/device/iothub/sync_clients.py", line 32, in handle_result
    return callback.wait_for_completion()
  File "/usr/local/lib/python3.7/site-packages/azure/iot/device/common/evented_callback.py", line 70, in wait_for_completion
    raise self.exception
azure.iot.device.common.transport_exceptions.UnauthorizedError: UnauthorizedError('Connection Refused: not authorised.')
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "./main.py", line 279, in <module>
    redbird_init()
  File "./main.py", line 271, in redbird_init
    device_one = main(config["sample_device_1"])
  File "./main.py", line 41, in __init__
    self.iothub.iothubclient_init()
  File "/app/SendEvent.py", line 31, in iothubclient_init
    self.iothubdeviceClient.connect()
  File "/usr/local/lib/python3.7/site-packages/azure/iot/device/patch_documentation.py", line 14, in connect
    return super(IoTHubDeviceClient, self).connect()
  File "/usr/local/lib/python3.7/site-packages/azure/iot/device/iothub/sync_clients.py", line 116, in connect
    handle_result(callback)
  File "/usr/local/lib/python3.7/site-packages/azure/iot/device/iothub/sync_clients.py", line 38, in handle_result
    raise exceptions.CredentialError(message="Credentials invalid, could not connect", cause=e)
azure.iot.device.exceptions.CredentialError: CredentialError('Credentials invalid, could not connect') caused by UnauthorizedError('Connection Refused: not authorised.')

it coming while connecting to the client, but the same problem is not coming using the same connection string when running locally.
The content of the docker file is -->
FROM python:alpine3.7
COPY . /app
WORKDIR /app
RUN pip install -r requirements.txt
EXPOSE 5000
CMD python ./main.py

requirements.txt  contains  azure-iot-device
AB#7723492

@arnabhetc, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

How was this solved any update on this? Facing same issue here.


update setAskFor on TXLOCKVOTE

We should update setAskFor when we receive IS vote we asked node for via inv.

utACK


Excel Like cumulative_filtering [feature request]

Currently cumulative_filtering is correctly limiting the select list of other columns, while it doesn't correctly limit the current column self.
Not only it prevents multiselect with cumultative_filtering:true but also becomes very confusing to excel users.
Can this feature be upgraded in a way that cumulative_filtering is applied to rest of columns but not to self.
Thank you

I had the same problem with it. This happens when you use ajax.
I solved this to add condition in
'if (!columnObj.select_type_options || !columnObj.select_type_options.ajax) {'
if ((!columnObj.select_type_options || !columnObj.select_type_options.ajax) && $filter_selector[0].selectedIndex<0)

@tynort ,
Besides cumulative filtering, I couldn't make it work with JS object isntead of DOM, which prevented me from using deferRender. So I just wrote my own function that supports "excel like" cumulative filtering with deferRender and bootstrap-select for beautiful multiple selects.

@klukiyan can you elaborate / give an example to your original comment? because in the showcase it does allow selecting from the same column http://yadcf-showcase.appspot.com/cumulative_filtering.html

@vedmack interesting. Some ~5 months ago when I started using yadcf, I guess there was another example, or something was different. On this particular example it seems to work well.
Maybe it's because of select2 and multi-select. I was using single select without select2 extension and with cumulative_filtering on each column was impacting not only other columns, but also self. So to select something from a column, users had to firstly click the [x] to deselect current selection in the column

@klukiyan That showcase page wasn't touch for much more than ~5 months, in case that you have a specific example which does not work please post it here


kratix update dependencies

Context
Add a command to include dependencies in the promise. Can look at worker-resource-builder for inspirations.
Ensure that:

It works if the promise was created with --split (if still available)
It should include the dependencies into the spec.dependencies of the promise; not as a workflow

Design
$> kratix update dependencies local-dir/
added your dependencies to your promise.yaml

Tasks

[ ] Implement
[ ] Doc

@catmo-syntasso Just checking in with you on whether we would like to provide a --dependencies flag for kratix init promise so people can add their dependencies at the time of bootstrapping?


Problem on streaming video from http://www.konserthusetplay.se

Hi,
I have a problem on streaming video from http://www.konserthusetplay.se
like this:
http://www.konserthusetplay.se/?m=IyQcMOEpmKqT91SVT5OP8Q
Although I can find a link inside its webpage, but it's a low quality video.
http://level3cdn.screen9.com/M/V/I/y/IyQcMOEpmKqT91SVT5OP8Q_medium_h264m.mp4?token=07fd4ae9b4ba13f37a79b"
I can choose 1080p option in the embedded player, but I cannot find the link.
Please add http://www.konserthusetplay.se into your list of supported sites,

konserthusetplay will be supported in the next version.


Status 404

Getting an error for few days:
Failed to get user profile for user: [uguraydogdu]. Caused by: com.elminster.retrieve.web.exception.WebRetrieveException: Exception on retrieve URL: [https://my.playstation.com/playstation/psn/profile/public/userData?onlineId=uguraydogdu&_=1447430642197]. Status fails. Status = 404] with root cause
com.elminster.retrieve.exception.ServiceException:

Any ideas how to fix?

Hi jnbn,
This error is caused by the URL change of playstation public trophy. I'll work on it.
Regards,
Jinglei

Adapted URLs and request params to correspond with PSN public trophies.

Thanks ;)


Validation tweaks for none of the above

Adding 'none of the above' option means that the rules for the dependent question on that page need to be a bit smarter.
Also pulls in latest content with the 'none of the above' option.

Content changes: https://github.com/alphagov/digitalmarketplace-ssp-content/compare/aa1b1c41b8c6872c852ed6d6f38c4e26fefc6ed1...3351a71d67e482a51bda3933ae9e6e1c120dac00

:+1:


bbl-translate fails to #include babble when compiled on macOS

I'm trying to build babble on mac (https://github.com/anderslanglands/babble/pull/10 branch). I'm compiling with the homebrew-installed llvm and zig cc as a compiler as it uses its own toolchain and avoids some of the problems I've been having with native/homebrew clang. The full build script is
CC=zig-cc CXX=zig-c++ cmake -S . -B build -G Ninja -DCMAKE_INSTALL_PREFIX=install -DLLVM_DIR=/usr/local/Cellar/llvm/17.0.6_1/lib/cmake/llvm/ && cmake --build build
(zig-cc and zig-c++ are just files installed in ~/.local/bin containing zig c++ $@ etc.).
I'm getting this issue with the tests where bbl-translate is run:
[13/31] Linking CXX static library test/stdfunction/libstdfunction-bind-dummy.a
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: test/stdfunction/libstdfunction-bind-dummy.a(bind.cpp.o) has no symbols
[16/31] Generating smartptr-c.cpp
FAILED: test/smartptr/smartptr-c.cpp /Users/ashley/babble/build/test/smartptr/smartptr-c.cpp
cd /Users/ashley/babble/build/test/smartptr && /Users/ashley/babble/build/bbl/bbl-translate /Users/ashley/babble/test/smartptr/bind.cpp -- -std=c++17 -fsyntax-only -fno-spell-checking -I/usr/local/opt/llvm/lib/clang/17/include -I/Users/ashley/babble/bbl/include -I/Users/ashley/babble/test/smartptr -- smartptr -o /Users/ashley/babble/build/test/smartptr
/Users/ashley/babble/test/smartptr/bind.cpp:1:10: fatal error: cannot open file '/Users/ashley/babble/test/smartptr/babble': No such file or directory
    1 | #include "babble"
      |          ^
[2024-01-30 16:13:10.335] [info] [cpp_context.cpp:2872] ASTs built in 1.0951439109999999s
[2024-01-30 16:13:10.340] [error] [api_cpp_context.cpp:45] /Users/ashley/babble/bbl/src/cpp_context.cpp:2885 compilation generated 3045 errors. Cannot continue
[2024-01-30 16:13:10.341] [error] [bbl-translate.cpp:491] extraction failed after 1.1113919739999998s

I don't really know what to make of it.

Assuming that babble is indeed in Users/ashley/babble/bbl/include, what happens if you change
#include "babble"

to
#include <babble>

in the smartptr bindfile?

Changing to
#include <babble>

results in a different but similar error message:
/Users/ashley/babble/build/bbl/bbl-translate /Users/ashley/babble/test/stdfunction/bind.cpp -- -std=c++17 -fsyntax-only -fno-spell-checking -I/usr/local/opt /llvm/lib/clang/17/include -I/Users/ashley/babble/bbl/include -I/Users/ashley/babble/test/stdfunction -- stdfunction -o /Users/ashley/babble/build/test/stdfunction
/Users/ashley/babble/test/stdfunction/bind.cpp:1:10: fatal error: cannot open file '/usr/local/opt/llvm/lib/clang/17/include/babble': No such file or directory
    1 | #include <babble>
      |          ^

If I remove the first include from the bbl-translate invocation (-I/usr/local/opt/llvm/lib/clang/17/include) then I get a different error:
/Users/ashley/babble/build/bbl/bbl-translate /Users/ashley/babble/test/stdfunction/bind.cpp -- -std=c++17 -fsyntax-only -fno-spell-checking  -I/Users/ashley/babble/bbl/include -I/Users/ashley/babble/test/stdfunction -- stdfunction -o /Users/ashley/babble/build/test/stdfunction
/Users/ashley/babble/bbl/include/babble:4:10: fatal error: cannot open file '/Users/ashley/babble/bbl/include/type_traits': No such file or directory
I get the same error if I just reorder the includes to this:
/Users/ashley/babble/build/bbl/bbl-translate /Users/ashley/babble/test/stdfunction/bind.cpp -- -std=c++17 -fsyntax-only -fno-spell-checking -I/Users/ashley/babble/bbl/include -I/usr/local/opt/llvm/lib/clang/17/include -I/Users/ashley/babble/test/stdfunction -- stdfunction -o /Users/ashley/babble/build/test/stdfunction
It seems like only the first -I flag is being registered for whatever reason.

The <type_traits> error I know the cause and can hopefully provide a fix
soon.
On Fri, 2 Feb 2024 at 00:04, Ashley @.***> wrote:

Actually even with
/Users/ashley/babble/build/bbl/bbl-translate
/Users/ashley/babble/test/stdfunction/bind.cpp -- -std=c++17 -fsyntax-only
-fno-spell-checking -I/Users/ashley/babble/bbl/include ...
I still get
/Users/ashley/babble/test/stdfunction/bind.cpp:1:10: fatal error: cannot
open file '/Users/ashley/babble/test/stdfunction/babble': No such file or
directory
so I'm not really sure my hypothesis holds up. Something is definitely
funky with how the -I flags are handled though.
—
Reply to this email directly, view it on GitHub
https://github.com/anderslanglands/babble/issues/11#issuecomment-1923281071,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYQXICKPG3AA2FAGWJJ53YRSMXPAVCNFSM6AAAAABCQQH3KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRTGI4DCMBXGE
.
You are receiving this because you commented.Message ID:
@.***>

Just following up on this, the type_traits error should now be fixed


Add market authority for creating open orders accounts

Separate PR from https://github.com/project-serum/serum-dex/pull/150 for easier review. These changes omit the added prune instruction for easier review. See the summary in the original PR for details.

Closing in favor of https://github.com/project-serum/serum-dex/pull/156.


DOCS-3906 Chaos faults audit for Kubernetes faults (node and pod)

Add environment variables, manifests, fix typo/grammar

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://655f299401df1a63ff2f21fc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65696451c5b8504b0f48ffd4--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://656965d4c5b8504c6548fc52--harness-developer.netlify.app


Runtime Error if $ in cell when generating plot on it

Describe the bug
The Runner crashes in it's python execution when you have a $ in a cell of a column you're plotting.
To Reproduce

Download this csv: https://www.kaggle.com/datasets/shivamb/netflix-shows
Load into SDS pipeline
do .plotScatterplot("cast", "date_added"); or similar on it (just has to be cast column somewhere in any plot) and click "show image"

Expected behavior
To show correct plot and handle $ as part of cell text.
Screenshots (optional)

Additional Context (optional)
No response

@lars-reimann Hope this is the right location.

@lars-reimann Hope this is the right location to post this.

Sure, and I can always transfer the issue elsewhere if it's not. Thanks for reporting.


split CAPI CR alerts on a CR base

as many alerts are flavor-specific (e.g. the CAPI alerts), we didn't run
the defined tests as we only set the provider for templating the charts.
If a provider doesn't have test-files, the test doesn't fail anymore.
Towards: https://github.com/giantswarm/roadmap/issues/2376
The referenced opsrecipe requires https://github.com/giantswarm/giantswarm/pull/27061 and https://github.com/giantswarm/opsctl/pull/1694 to get merged
This PR ...
Checklist

[x] Update CHANGELOG.md
[x] Add Unit tests
[ ] Follow Alert structure
[ ] Consider creating a dashboard (guidelines) (if it does not exist already) to help oncallers monitor the status of the issue.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).

@bavarianbidi can you split this PR in smaller ones? I feel like you are solving multiple things and this makes this a bit too big to review

@bavarianbidi can you split this PR in smaller ones? I feel like you are solving multiple things and this makes this a bit too big to review

@QuentinBisson, i already splitted on a commit base:

commit 1 - fixes the whenever introduced broken tests
commit 2 - split the one global capi-CR rules based on a subresource base

but if you need it on a PR base i will do that

I think the changes make sense. I would think smaller PRs would help find the source of the change but let's not take weeks to get this merged :)


Reach out to NYC Human Rights form people for usability advice

Description
Definition of done

[ ]
[ ]
[ ]

Attachments
title

Meeting in person Wednesday for design IRL and will follow up.
Will also make a call for volunteer user interview participants at the same event,

Monday @ 2:30 EST - folks welcome to attend!

Notes here
https://docs.google.com/document/d/1eMFdWOnlLUHJBt1dUx9BnWepz4Azm9yLdp7woFLWlTs/edit#


[SPEC] Disparity on facet name: DataQualityMetricsInputDatasetFacet

Problem
According to the spec definition of DataQualityMetricsInputDatasetFacet : https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/DataQualityMetricsInputDatasetFacet.json, the name of the property is defined as dataQualityMetrics here: https://github.com/OpenLineage/OpenLineage/blob/ab26286e57d386b31eb9a12096b318e44596f6e5/spec/facets/DataQualityMetricsInputDatasetFacet.json#L65.
However, in the examples shown here: https://openlineage.io/docs/client/python/#full-example-source-code, the name is defined as dataQuality, not dataQualityMetrics
# generates input dataset
def inputDataset(dataset, dq):
    input_facets = {
        "dataQuality": dq,
    }
    return InputDataset(dataset.namespace, dataset.name, dataset.facets, input_facets)

Either the spec definition is not correct, or example is not correct.
However, when tested with Marquez, looks like dataQuality is the correct one.
Solution

Clarify whether the name of the above facet is dataQuality or dataQualityMetrics.
Fix either the example or spec file accordingly, to remove the confusion/error.

I think we corrected it at some point to give Marquez and other consumers chance to move to proper value:
https://github.com/OpenLineage/OpenLineage/blob/ab26286e57d386b31eb9a12096b318e44596f6e5/integration/airflow/openlineage/airflow/extractors/sql_check_extractors.py#L143
but we haven't followed up on that.

I think we corrected it at some point to give Marquez and other consumers chance to move to proper value:
https://github.com/OpenLineage/OpenLineage/blob/ab26286e57d386b31eb9a12096b318e44596f6e5/integration/airflow/openlineage/airflow/extractors/sql_check_extractors.py#L143
but we haven't followed up on that.

So, is the dataQualityMetrics the correct value?

@howardyoo yes, given that our naming scheme is name of facet + type of object it's attachable to + "Facet".
dataQuality would be good name for DataQualityInputDatasetFacet, not DataQualityMetricsInputDatasetFacet.


feat: added timers for defrag powerups

Closes momentum-mod/game/issues/1848
Closes momentum-mod/game/issues/1727

Checks

[x] I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
[x] I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
[x] My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
[x] My branch is functionally complete; the only changes to be done will be those potentially requested in code review
[ ] All changes requested in review have been fixuped into my original commits.

I'm happy with Mac's stuff but seeing as I rewrote half of it with him and this PR now has a commit of my own, def needs a review from someone else - Peen if you can check it out that'd be great. Also I have a PR on red for getting the ShouldDraw stuff for hud panels working with my thing.


Move up service routing to Http{1,2}RequestDecoder

If a service does not support a streaming request, we don't need to create a stream request using DefaultStreamMessage is more expensive than a fixed size request using FixedStreamMessage. We need more information on the service to create an optimized HTTP request. We don't know the service when initiating the request. Currently, we only utilize HTTP headers which only tells whether a request has a body.
https://github.com/line/armeria/blob/2920a1ddc2188f150a0d8b77de1d4e2e409997cf/core/src/main/java/com/linecorp/armeria/server/Http2RequestDecoder.java#L136-L145
On the other hand, a service could provide various information for a request such as input type and out type.
A service for a request is chosen in the HttpServerHandler
https://github.com/line/armeria/blob/2920a1ddc2188f150a0d8b77de1d4e2e409997cf/core/src/main/java/com/linecorp/armeria/server/HttpServerHandler.java#L352-L358
It is after the creation of a request. If we can move the routing that finds the corresponding service to Http{1,2}RequestDecoder, we can create optimized HTTP requests using FixedDecodedHttpRequest that get the best out of FixedStreamMessage.

Handled by #3956


Unable to run real device — Pactswift

Hi,
We are importing the pactswift for our project and we are not able to create the pact contract file in pacts folder.
Whereas the pact contract file is created while running on the simulator but not creating the file when we running on the real device.  Below is the error we are getting,
failed - Mock Server Error: Failed to write Pact contract to file.
failed - Mock Server Error: Failed to write Pact contract to file.

That is the expected behaviour.
The framework is limited to write to the disk of the device it is running on, which in your case would be the iOS devices disk and not you mac.
I'm just about to release a version that would write an info message into the console when running on a device.

This is now live with version v0.12.1. When running on a physical device the writing of the pact contract file will be skipped, will not fail the tests and will debug console will print something like this:
Test Suite 'Selected tests' started at 2022-06-01 11:19:12.646
Test Suite 'AnimalClientTests.xctest' started at 2022-06-01 11:19:12.647
Test Suite 'AnimalClientTests' started at 2022-06-01 11:19:12.648
Test Case '-[AnimalClientTests.AnimalClientTests testGetsAnimals]' started.
[INFO]: Running on an iOS device. Writing Pact interaction into a contract skipped.
Test Case '-[AnimalClientTests.AnimalClientTests testGetsAnimals]' passed (0.505 seconds).
Test Suite 'AnimalClientTests' passed at 2022-06-01 11:19:13.154.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.505 (0.506) seconds
Test Suite 'AnimalClientTests.xctest' passed at 2022-06-01 11:19:13.154.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.505 (0.507) seconds
Test Suite 'Selected tests' passed at 2022-06-01 11:19:13.155.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.505 (0.508) seconds


[1958] Setup new course confirmation page

Context
New course confirmation page
Changes proposed in this pull request

Setup confirmation page

Guidance to review
👷

 [M] Add new course confirmation page


I want to run at 30 minutes per hour. Is that right

0 */30 */1 * *

Hello!
I think the answer would be */30 */1 * * *
When building cron's, I highly recommend you to check on https://crontab.guru


Dependencies handling in cmake config

When installing dlib, I see that the exported cmake config has dependencies with hardcoded paths imprinted. This causes any other environment setting to keep the dependencies at the same place.
In my case, I have  a docker where I install dlib with cudnn at /usr/libx86_64-linux-gnu.
On the system I want my dlib to deploy to, I have cudnn at /opt/cudnn-7.
Usually cmake allows to abstract from this path-hardcoded dependency by letting dlibConfig.cmake find cudnn a second time (when find_package(dlib ...) is called).
Is there a reason why this flexibility is not implemented? (besides the comfort of not explicitely declaring the dependencies a second time)

DLib looks here                                          SET(CMAKE_PREFIX_PATH "${CMAKE_PREFIX_PATH} ${PREBUILT}/cuda/")

CUDNN is not part of or distributed with dlib, so the CUDNN would need to be found again on the system where it is being imported, right?

Exactly.
I understand that dlib so far assumes that it will be always at the path where cmake found it at configuration time of dlib compilation/installation. In my case that is /usr/lib/x86_64-linux-gnu/libcudnn.so. Shipping all libraries/headers/cmakeConfigs to another system, cudnn needs to be found at a different place, but dlib.cmake is assuming thtat libcudnn.so is at /usr/lib/x86_64-linux-gnu/libcudnn.so. At least it is hardcoded in my ${CMAKE_INSTALL_PREFIX}/lib/cmake/dlib/dlib.cmake.
It most likely is a small issue for most people, since they install and use dlib at the same system. I wanted to package it and came across that problem.
Is it an issue you are aware of or even have decided to do it that way? (out of curiosity)

Yeah so the problem is that these are full paths rather than just the name of the library file so you can resolve it on the other end.
I suppose the main issue is there is no FindCUDNN or FindMKL.

I think this is generally how cmake installs work. If you want to propose a change then submit a PR. Note that it must work on all platforms and not break any existing use cases.

I think I know now why CMake works that way. Using the cmake2 way of setting variables (in the Find* files causes the hardcoded paths. I'm gonna try in the new year to submit a PR where the Find* files are defining target and properties. This I reckon should help to erase the hardcoded paths from the Config*.


Cannot find module sax @ VSTS build agent

The build agent for my Visual Studio Team Services tenant seems to have a cache problem or something like that. I switched to version 6.2.1-dev locally after which I got a compile error. Cleaned out the cache as suggested in the error message solved this, but after pushing the code to my repo, the same error now pops up in the online build. As there is no "Clean cache" button there, I'm left wondering what I need to do to fix this?
Error is as follows:

<EMAIL_ADDRESS>already installed.
Adding support plugin.
module.js:341
throw err;
^
Error: Cannot find module 'sax'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:20:19)
at Object. (C:\cordova\node_modules_cordova\lib\npm_cache\cordova-android\5.2.0-nightly.2<IP_ADDRESS>d62196\package\node_modules\elementtree\lib\parsers\sax.js:3:11)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
{ [Error: cmd: Command failed with exit code 1] code: 1 }

The VSTS Cordova support is in a separate repo, could you please open this issue on https://github.com/Microsoft/vsts-cordova-tasks

Ah ok, sorry about that!