[Feat]: create a pull request template

What feature?

create a file .github/PULL_REQUEST_TEMPLATE.md file
add the contents below (we can tweak some details)

-- contents --

Closes

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots
Add screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can I work on this?

Can I work on this?

Yeah sure!

Yes. Go ahead.
On Tue, 9 May 2023 at 21:28, Arindam Majumder @.***>
wrote:

Can I work on this?
—
Reply to this email directly, view it on GitHub
https://github.com/ExhibitHQ/ExhibitHQ/issues/19#issuecomment-1540455259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A33BEJ3FBWPPPRDRDMCKZSLXFJSSFANCNFSM6AAAAAAX3BPPOM
.
You are receiving this because you authored the thread.Message ID:
@.***>

@Arindam200 any updates?


Automated Package Upgrade

:tada: This PR is included in version 25.3.476 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


improvement Support rewrite by materialized view when join has other join conjuncts

Proposed changes
Support rewrite by materialized view when join has other join conjuncts
Such as mv def is
            select l_orderkey, o_orderdate
            from
            lineitem
            inner join
            orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate
            inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

The query can be rewtritten by mv sucessfully when has not equal conjuncts in join
 l_shipdate <= o_orderdate and ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;
            select l_orderkey, o_orderdate
            from
            lineitem
            inner join
            orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate
            inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


[Feature][Config UI] Error Messages and Warnings in Blueprint creation

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
I have observed a few cases where a user either forgets or doesn't know to add a connection while creating blueprint. For instance "Next Step" button is disabled and the user doesn't know why. (Slack thread)
Description
We can add user friendly error messaging or communicate effectively on config UI itself as shown in the image below

Related issues
Nope
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks @JoshuaPoddoku , can you take a look? @yumengwang03

Hey @Startrekzky , there were quite a few I noticed earlier, especially the user groups who are new to DevLake, beginners and who may miss reading docs.
Here is a recent slack thread for reference

Hey @Startrekzky , there were quite a few I noticed earlier, especially the user groups who are new to DevLake, beginners and who may miss reading docs.
Here is a recent slack thread for reference

This a valid potential improvement, but it's probably not at high priority at the moment. We have added more help information, including links to docs, in v0.16's config UI. Let's see how that works first. Is that OK?

I completely agree. We can try including links to docs that should help at the moment!


fix(Group/PosPart): fix multiplicative version

These lemmas were incorrectly stated with the multiplicative version, and so had two identical forms, both additive. This PR restores the multiplicative version, and also generalises.

Ha ha you do indeed seem to be right! Maybe to_additive should emit a warning if it didn't actually do anything?
bors merge


Web extension support

VSCode has a web version. A typical use case for this is github.dev, accessed by pressing the . hotkey in any repo. AGLint supports the browser environment, however, project scanning should be solved with another API, since it is not possible to use Node.js specific API in the browser environment. In the package.json file, we should specify a browser entry point in addition to main.
References:

Documentation: https://code.visualstudio.com/api/extension-guides/web-extensions
Sample: https://github.com/microsoft/vscode-extension-samples/tree/main/lsp-web-extension-sample
Testing: https://github.com/microsoft/vscode-test-web

Currently, the extension cannot be used on github.dev, so we need at least a blank browser entry point to make the syntax highlighter work again.


make vent clog event only affect single station vents

About the PR

Closes #9229
Media

For demonstration purposes all vents are affected (commented part of the code)

Changelog

:cl:

tweak: vent clog event now only affects single station vents (no more foam in nukie ship)

May as well tweak APC events, but better approach would be creating new class for station local events. Because right now station events are announced globally even if it doesn't affect every grid (unless you override methods).

I would rather this be a bool in StationEventRuleConfiguration that gets handled on StationEventSystem or something than special casing events like this

The reason why you would want to have a separate class for this is that you need to store chosen station somewhere (in field).

I would rather this be a bool in StationEventRuleConfiguration that gets handled on StationEventSystem or something than special casing events like this

This is correct behavior already, I don't think it needs the bool.


Change Email to be not required on the Applicants page

Oops See issue-309 pull request.  Waiting for peer review


We aren't  spam. Lets not be treated like it.

Reading materials:
http://programmers.stackexchange.com/questions/130762/why-does-email-sent-from-my-site-end-up-in-spam-folders
https://sendgrid.com/blog/10-tips-to-keep-email-out-of-the-spam-folder/

@sirtastic :
Some of these we can do. I think the highest priority is a Reverse PTR record. See my comments on that below. The only one that might be worth doing for which you should need my participation would be changing the body of the email. Let me know if you want to do that, and I'll create the file.
Responding to that programmer thread:

This item, the first thing they suggest, is what I suggested earlier: come up with an email body that won't set off spam flags. We're not using spammy text in the email, though, so this may make no difference.
There's not much we can do to make 'confirmation' emails individualized.
If you want, give me the smtp credentials and I'll use them. But a reverse ptr record should satisfy any mailbox that would cough over this matter. Still, I'm no email expert. May be worth asking Brad, Steve Wood, or Peter (if Peter's still around at all).
Already in effect.
Already in effect.
Reverse PTR record sounds like a good idea. Please contact 1and1 and get them to set it up or provide instructions. (My web search reveals no 1and1 instructions for this.)
Way overboard. Find me someone else in our space that does this. (Find me anybody that does this.)
We can do it, but as they say, it shouldn't have any effect these days.

Responding to the '10 Tips' page:

Done
See first item in previous list.
Done
Done. And we aren't actually marketing
This may be worth trying before addressing item 1 of the previous list. But it's something you dont' need me to perform. (It's not a good automated solution and appears to not even be a possible automated solution.)
It's possible but unlikely that our server is blacklisted. Again, this is a check for which you don't need me.
Done
Done
Done
These items fall effectively under the penultimate item in the previous list.

I've make a point of deleting others' login credentials, so I am at present unable to get into 1and1, but I don't think you'll need me for any of these except perhaps the last one (and some help on the first one). And to me, the last one doesn't look worth doing.
Assigning back to you for at least the time being.


Switching to ES6/Babel produces errors in JS console

When switching to ES6/Babel mode, there is an error in browser JavaScript console:
Steps to reproduce:

Navigate to https://jsbin.com/ .
Open JavaScript console (in Google Chrome it's Ctrl+Shift+j).
Note that there are no JS errors at this stage.
Open JavaScript pane in JS Bin.
From dropdown, select ES6/Babel.
Observe a JS error in the browser JavaScript console:

Uncaught TypeError: e.editor.lintStop is not a function
    at Object.h.set (jsbin-4.1.1.min.js:29)
    at HTMLAnchorElement.<anonymous> (jsbin-4.1.1.min.js:29)
    at HTMLAnchorElement.dispatch (jquery-1.11.0.min.js:3)
    at HTMLAnchorElement.r.handle (jquery-1.11.0.min.js:3)

Firefox also has the same error.

Can you retest in v5? (To switch see the latest blog post jsbin.com/blog)

@remy How do you switch to Babel mode? Can't find the menu item (Ctrl + Shift + P), or in the help ( https://jsbin.com/help/ ).

Docs haven't been written for v5 yet - still alpha mode, but it's where I'm putting development efforts in (since it's just me).

Did you get anywhere with this?

No. Ctrl-Shift-p in Firefox opens up a new private window...

@valera-rozuvan are you on a Mac or PC (so I can replicate and fix)?

Do you use any tools like VS Code that have command pallettes? If so, can
you share what key combination they use to trigger?
On Tue, 24 Apr 2018, 08:23 Valera Rozuvan<EMAIL_ADDRESS>wrote:

I use primarily Linux. Firefox for Linux has Ctrl-Shift-p mapped to new
private window. I also checked on Windows, and there too we have such
behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jsbin/jsbin/issues/3230#issuecomment-383830219, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAA1hB0O4lIXBVveQJ-3CqIEkIJj97NUks5trtLqgaJpZM4TJi4M
.

Sublime Text also uses this key combination to open it's command palette: http://docs.sublimetext.info/en/latest/extensibility/command_palette.html .

Some interesting observation:

Google Chrome uses Ctrl-Shift-n to open a new private window
Mozilla Firefox uses Ctrl-Shift-p to open a new private window

And some more:

Mozilla Firefox calls them Private Windows
Google Chrome calls them Incognito Windows

Poop.
I wonder how alt+shift+p would work as an alternative…
I wanted to replicate the muscle memory some developers (myself included) would have for palettes - and I've had experience with running into existing key-combos…

up

This is still happening


Confirm resolution to runtime warning: "atexit() called, but EXIT_RUNTIME is not set […]"

Confirm necessary solution to runtime warning: "atexit() called, but EXIT_RUNTIME is not set, so atexits() will not be called. set EXIT_RUNTIME to 1 (see the FAQ)"
https://kripken.github.io/emscripten-site/docs/getting_started/FAQ.html#what-does-exiting-the-runtime-mean-why-don-t-atexit-s-run

This is fine, since we want to keep the runtime running and don't have need of an exit call


broken upgrade process with mixed java/scala projects

I'm upgrading the the latest  bazel + latest rules_scala and believe I've found a or have unknowingly been depending on a behavior that's since been deemed a bug and since removed support wise
I'll try to outline my case below
We currently have a scala library rule which previously depended on a source jar containing generated java sources, some paths to individual java sources, with dependencies on a scala library ( using mixed java/scala ) and a java import which was essentially an alias to a collection of vendored jars.
scala_library(
    name = "label-foo",
    srcs = [":source-jar-containing-java"] + [
        "src/main/java/com/path/to/Foo.java"
    ],
    javacopts = JAVAC_OPTS_NO_WARN,
    scalac_jvm_flags = JVM_FLAGS,
    deps = [
        "//scala-library-label",
        "//java-import-label",
    ],
)

when inspecting the bazel-bin/{package}/{label-foo}.jar with unzip -l I was surprised to find only a manifest file with no class files. I hypothesized that maybe there was a change that required at least some scala files so I though in a dummy scala source into the srcsattr list and rerun the ùnzip -l`to my suprise the only class file listed was for the scala source. Did something change where you can no longer provide java sources as srcs for scala_library rules? My next step is doing to see if I can finagle bazel a bit to make this a java_library but am not sure if I can then have a scala_library as a dependency.
This is kind of time sensitive.  If this was a known change and there's a commit I can point to just before that commit, that'd work as well.

We have tests for mixed targets, but they generate a separate output. We delegate to bazel's java support and let it compile the java, then we emit multiple jars in those cases.
How are you depending on this target? Can you repro with a test?
https://github.com/bazelbuild/rules_scala/blob/master/scala/private/rule_impls.bzl#L434
It should be named with _java.jar:
https://github.com/bazelbuild/rules_scala/blob/master/scala/private/rule_impls.bzl#L330

update porting this to a java_library was as simple as removing the scalac_jvm_flags options. its new to me that java rules can now depend on scala libraries. However this seemed to generate slightly different class files as what once compiled no longer compiles.
aside also seeing a number of these types of errors
DEBUG: .../external/io_bazel_rules_scala/scala/private/common.bzl:51:7: ignored dependency, has no JavaInfo: <target @meetuplib//:org_spire_math_spire_macros>

I can't immediately recall by the scala macros in spire needed to be placed in a filegroup in the past. This seems now to be an error as a input for scala rules
filegroup(
    name = "org_spire_math_spire_macros",
    srcs = ["xxx/spire-macros_2.11-0.9.0.jar"],
    visibility = ["//visibility:public"],
)

How are you depending on this target?

It is a little complicated in this case. The output of the scala_rule was depended on as a java which was consumed by in internal rule we have which outputs another jar out. That jar was included as in the deps list of another scala_library. I think that's illegal now because of the JavaInfo requirement.
there's a comment in the scala rules code about using java_import so im now re-exporting the jar ouput via java_import as an indirection to satisfy the scala rules
# this allows me to depend on the jar output
java_import(
    name = "foo-label",
    jars = [":previous-foo-label"]
)

It'd take some time to whittle down a test case I can post here but for now I'll post what I learn

I think the difference in compiled classes with java_library and scala_library had to do with some generic type parameter variance.
a short but hopefully not too abstract example is an error that came out of a scala_library rule that depends on the ( now ) java_library mentioned above
 found   : com.foo.ClassThatExtendsGuavaFunctionMentionedBelow
 required: com.google.common.base.Function[com.foo.In,com.bar.Out]
      .fetch[Out](In.methodThatReturnsClassThatExtendsGuavaFunctionMentionedBelow)

when previously ran though scala_library, the classfiles generated supported subclasses of guava functions as valid inputs to this generic function. when ran through java_library, the classfiles generated seem to not support subclasses of guava functions.

you need to use scala_import for those kinds of targets now.
Java has been able to depend on scala rules output for a while.
I don't see why our changes could give static errors like that. We still pass the java code to the scala compiler, we just invoke javac differently.

https://github.com/bazelbuild/rules_scala/blob/master/scala/scala_import.bzl#L119
there is the scala_import rule.

I think in many of these cases I was depending a bit too much on impl details and perhaps the older way scala rules interfaces with javac. Thanks for your help and quick responses on these @johnynek

The good news is the internal details are more abstracted and there are more contracts now (JavaInfo provider, for instance).

I'll try bumping don't to 0.15.2 for now

error prone still seems active with bazel 0.15.2 but this may save my some other surprises of compiling for java 9 and running on java 8

that is the one I was referring to. Error prone is active since we moved to using java rules under the hood (which was many months ago).
To use java 8 on 16 and above you need:
--java_toolchain --host_java_toolchain use bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath8.jar"], and source_version = "8", target_version = "8",
--host_javabase --javabase point to a java_runtime of jdk 8
You should be able to find more details on the bazel issue tracker

thanks @ittaiz this is very helpful. we're going to try to make a smaller leap that's still a leap from 0.6.1 to 0.15.2 for now. It may be worth mentioning some of this on your readme, or linking to the bazel docs for java on how these rules interact with java. This seems very notable for many companies. On a positive note, this is giving us a good kick in the pants. We should really be thinking about moving to java 9 anyway. Java 10 and 11 are already on the way!

I know, the docs on this are bazel related and are unfortunately in
somewhat of a disarray.
Btw, java 11 was released a few days ago.
Though Bazel isn't 11 ready.
On Wed, Sep 26, 2018 at 6:18 PM doug tangren<EMAIL_ADDRESS>wrote:

thanks @ittaiz https://github.com/ittaiz this is very helpful. we're
going to try to make a smaller leap that's still a leap from 0.6.1 to
0.15.2 for now. It may be worth mentioning some of this on your readme, or
linking to the bazel docs for java on how these rules interact with java.
This seems very notable for many companies. On a positive note, this is
giving us a good kick in the pants. We should really be thinking about
moving to java 9 anyway. Java 10 and 11 are already on the way!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-424753781,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF1AqrBPEItNvKmzL5KPrXbTNIxCYks5ue5qpgaJpZM4W5yhX
.

that's kind of my indicator of how far behind we are :)

did anything interesting change with scala test integration with scala_test rules
I got our build working but now I'm hitting an running error .
*** RUN ABORTED *** (1 second, 568 milliseconds)
  java.lang.IncompatibleClassChangeError: Found interface org.scalacheck.Test$Parameters, but class was expected
  at org.scalatest.prop.Configuration$class.getParams(Configuration.scala:444)
  at com.meetup.base.statsd.StatsTest.getParams(StatsTest.scala:15)
  at org.scalatest.prop.GeneratorDrivenPropertyChecks$class.forAll(GeneratorDrivenPropertyChecks.scala:1135)
  at com.meetup.base.statsd.StatsTest.forAll(StatsTest.scala:15)

this is likely do to a version the scalacheck we have on our classpath, scalacheck_2.11-1.11.5.jar but I wanted to check so that I could line up versions

spotted. I think we'd previously been depending on https://mvnrepository.com/artifact/org.scalatest/scalatest_2.11/2.2.0 which has an optional dependency on scalacheck 1.11.3.
the new version in scala rules https://mvnrepository.com/artifact/org.scalatest/scalatest_2.12/3.0.5 has an optional dependency on 1.13.5. fun
I've got some test dep version upgrades to sort though :)

Quick heads up. The version of scala test scala rules is pinned ( 3.0.5 ) to may be problematic for those using scalatest's scalacheck integration -- https://github.com/scalatest/scalatest/issues/1012#issuecomment-424925878
This is more of an open issue for scalatest but given the current circumstances what are the options over overriding the scalatest version scala rules uses. It seems some of the folks affected but this have had more luck with<EMAIL_ADDRESS>+<EMAIL_ADDRESS>https://github.com/scalatest/scalatest/issues/1012#issuecomment-261385950

you can select your own versions of those dependencies by implementing your own:
https://github.com/bazelbuild/rules_scala/blob/master/scala/scala.bzl#L278
or by setting up a bind to:
io_bazel_rules_scala/dependency/scalatest/scalatest
it would be nice for this to be easier to configure.

Ohhh that's interesting so this wires up to native maven jars. I can see I'd have to somehow rebind to this name https://github.com/bazelbuild/rules_scala/blob/master/scala/scala.bzl#L333. At the end of the day in a day in the life of a bazel build, everything is just a label anyway. So I could try that.
An alternate approach I was thinking which we're kind of already doing was using a named java_imports for test deps like Scalacheck ( we just have ivy vendor jars in local gitignored dirs so we can share between sbt/bazel ) and just add that label in the scala_test rules list of deps. What I'm unsure about there is how to opt out of the provided scala test jar that's prewired in. If I'm not sure how well that'd gell with the built in test runner.
I agree. It'd be great to just override a default arg of something like scala_repositories with a new version/Sha/label or whatever to "bring your own" alt version of the defaults.
Aside. Thank you both for your quick feedback on this. Im trying to help jump start a new team to revamp our bazel setup before I go off on a long sabbaitcal. A parting gift if you will :)

What both @johnynek and I want (but don’t have the time to do) is move all
external dependencies required to be part of specific toolchains so you cN
either declare the default toolchain we build or configure your own with
your own versions.
If you can help with adding a toolchain for scala_test that can be awesome
:)
On Thu, 27 Sep 2018 at 7:05 doug tangren<EMAIL_ADDRESS>wrote:

Ohhh that's interesting so this wires up to native maven jars. I can see
I'd have to somehow rebind to this name
https://github.com/bazelbuild/rules_scala/blob/master/scala/scala.bzl#L333.
At the end of the day in a day in the life of a bazel build, everything is
just a label anyway. So I could try that.
An alternate approach I was thinking which we're kind of already doing was
using a named java_imports for test deps like Scalacheck ( we just have ivy
vendor jars in local gitignored dirs so we can share between sbt/bazel )
and just add that label in the scala_test rules list of deps. What I'm
unsure about there is how to opt out of the provided scala test jar that's
prewired in. If I'm not sure how well that'd gell with the built in test
runner.
I agree. It'd be great to just override a default arg of something like
scala_repositories with a new version/Sha/label or whatever to "bring your
own" alt version of the defaults.
Aside. Thank you both for your quick feedback on this. Im trying to help
jump start a new team to revamp our bazel setup before I go off on a long
sabbaitcal. A parting gift if you will :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-424951805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFwJ1c2EVTWK53fRNJsQ9EH6NDjbCks5ufE6YgaJpZM4W5yhX
.

@johnynek When you suggest "implementing your own," do you mean copying and pasting that method into one's local build and tweaking the relevant library versions? Colleague of @softprops here.

yeah....
It's not perfect, but controlling your versions with a .bzl file and function you call is not terrible.
So, you'd put a file in your repo with a copy-paste of that function, then you would tweak the versions as needed.
We use bazel-deps: https://github.com/johnynek/bazel-deps at stripe, so we just use bind to point the version we set up in bazel-deps. That has been easy for us (and we don't actually copy that function into our repo since the version set gets ignored).

Hi there, another colleague of @softprops here.
We've tried setting the version of scalacheck and scalactic back in time to the versions we previously relied on, while using bazel 0.15.2 and rules_scala @ a594886. Right now that change is not ready to submit publicly, although I expect we'll prepare something in the form of a toolchain once we get this all working.
That seems to mostly build (and run tests) alright, except now we're encountering another strange issue with building mixed scala/java sources within the same scala_library call. In bazel-bin/<module>/<module>.jar, we see .class files for the corresponding Scala sources, but not for the corresponding Java sources, even though both scala and java sources are explicitly included in the srcs glob. However, we do see all the relevant Java .class files in bazel-bin/<module>/<module>_java-hjar.jar. Our scala_library rule is something like this:
scala_library(
    name = "base",
    srcs = glob(
        [
            "src/main/scala/**/*.scala",
            "src/main/java/**/*.java",
        ],
    ),
    # ...
)

In our codebase, there are scala files that depend on java files, and java files that depend on scala files, so creating a separate scala_library and java_library for each language doesn't seem feasible at this point.
We were also able to reproduce this behavior by observing it in a (non-failing) test from rules_scala that I don't recall right now, but we'll follow up with that tomorrow. In bazel 0.6.x, we see the expected mixture of Scala- and Java-based .class files in the final .jar. I'm wondering if this is intended behavior or a bug.
Either way, how do we include the Java-based .class files along with the Scala ones in the final .jar file?

@exchgr see this comment: https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-424565857
There is no contract that the sources wind up in the same jar. A rule can have multiple outputs.
What is causing a requirement that all sources wind up in the same jar?
The deploy jar target should have that and bazel run should work. Those are the contracts.

Additionally what you can do is have small genrule that takes both jars,
unpacks them and packs them together if it’s a hard requirement (which I
agree with Oscar it shouldn’t be)
On Tue, 16 Oct 2018 at 2:37 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

@exchgr https://github.com/exchgr see this comment: #619 (comment)
https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-424565857
There is no contract that the sources wind up in the same jar. A rule can
have multiple outputs.
What is causing a requirement that all sources wind up in the same jar?
The deploy jar target should have that and bazel run should work. Those
are the contracts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-430050524,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF8OOuBbEqZDaM7W99KuomgnhRyWaks5ulRw1gaJpZM4W5yhX
.

Thanks for the responses. Sorry if I was unclear. There's no requirement on our part that these classes are in the same jar. But we also aren't seeing the <module>_java.jar at this point. Right now, I see these:

<module>.jar - containing only Scala classes
<module>_java-hjar.jar - containing only Java header classes

It doesn't particularly matter where the full Java classes land in the output, but I don't see them at all.

Strange. Can you checkout rules scala and see if you can see the java file
there for any of the targets?
On Tue, 16 Oct 2018 at 18:35 Elle Mundy<EMAIL_ADDRESS>wrote:

Thanks for the responses. Sorry if I was unclear. There's no requirement
on our part that these classes are in the same jar. But we also aren't
seeing the _java.jar at this point. Right now, I see these:

.jar - containing only Scala classes
_java-hjar.jar - containing only Java header classes

It doesn't particularly matter where the full Java classes land in the
output, but I don't see them at all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/619#issuecomment-430285760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFwrap1L19VZg1ga2AxvWB_rLPXWnks5ulfzagaJpZM4W5yhX
.

It looks like the java jars for the targets in rules_scala tests actually did show up correctly. But I did some digging in our bazel project and found there's something that prevents those java jars from getting built. Somewhere down the line, we're relying on ctx.files.artifacts to stage our jars. But that only includes the jars that don't have the _java suffix. It relies on the default outputs. It looks like the default outputs don't include the _java.jar files. I'll open a PR with what works for me.

Here's a preliminary PR, notably omitting tests https://github.com/bazelbuild/rules_scala/pull/629


oneof support for some pointer types.

Thank you for the good library.
Now I need to set oneof for a pointer type.
(It cannot be non-ptr because it is necessary to distinguish between nil and 0)
I think this feature is in demand by users other than me, so I will create a PR.
In this PR, we becomes to be able to use other tags other than oneof at the same time on pointer types.

I fixed CI failed by another PR
https://github.com/bxcodec/faker/pull/163

I fix the CI here #167


Right-click desktop doesn't show icons

Why is there no icon on my desktop when I right click?

Is it because the icon pack is not installed?

Have you moved the /usr directory? If so can you please give me the output of the following command?
ls /usr/share/jgmenu

Have you moved the /usr directory? If so can you please give me the output of the following command?
ls /usr/share/jgmenu

Have you moved the /usr directory? If so can you please give me the output of the following command?
ls /usr/share/jgmenu

Thanks, I found .config/jgmenu in the repository and moved it to my /usr/share/, after that the desktop icons were resolved. However, right-clicking the desktop will not follow the mouse and will only appear in the lower left corner.

What version are you using? The bspwm, fvwm or the worm one?

What version are you using? The bspwm, fvwm or the worm one?

Bspwm

Ah okay


Linear search in cpp

Implemented linear search in cpp.

Done. Can you please review now?

Great work. Merging now.


Error adding aws s3 cloud storage of video files

I have created bucket in aws s3, uploaded one folder with one video file.
Created manifest.jsonl file using below command
python create.py video_file
here is my manifest file
{"version":"1.1"}
{"type":"video"}
{"properties":{"name":"jnjtest2/jnj_2dogs.mp4","resolution":[1920,1080],"length":648}}
{"number":0,"pts":0,"checksum":"541636d94b497edba901aa635eb36c33"}
{"number":25,"pts":25000,"checksum":"adab91e6e828d945f0ccf9f7c4236487"}
{"number":50,"pts":50000,"checksum":"22181e76361a369cddd078da5e9183fc"}
{"number":75,"pts":75000,"checksum":"ece2f33d7eb66ee552be5090b786af98"}
{"number":100,"pts":100000,"checksum":"909009a8236f6cf1137cf05c1aa7326f"}
{"number":125,"pts":125000,"checksum":"d704612eb9cc925c0173afd18921cd61"}
{"number":150,"pts":150000,"checksum":"abab248aadf2f9b5cb67c43435234f39"}
{"number":175,"pts":175000,"checksum":"0f4aaf4e5d5e963bd052a665a354f3d8"}
{"number":200,"pts":200000,"checksum":"f4a68187597d0f7fd3ec53a387614422"}
{"number":225,"pts":225000,"checksum":"eb7274b2294b4a59c605be3711948f2b"}
{"number":250,"pts":250000,"checksum":"f9efd4b122c10abbb65d5e9e1117046d"}
{"number":275,"pts":275000,"checksum":"c27c7678adc1fccdd5b8644e07942917"}
{"number":300,"pts":300000,"checksum":"67ceb3654e5a6af2e4729fec0fb78294"}
{"number":325,"pts":325000,"checksum":"f3c6c3fe226a0950e2ac90cc8420895d"}
{"number":350,"pts":350000,"checksum":"7e49da4d09693c1a462f305b3c4089cc"}
{"number":375,"pts":375000,"checksum":"af05ce6720c9b096b16db1452194dacb"}
{"number":400,"pts":400000,"checksum":"a900dce06d8bb092c9943ac035c1c3af"}
{"number":425,"pts":425000,"checksum":"aa3e70c93daca011f65a3d8191bf847e"}
{"number":450,"pts":450000,"checksum":"d3410f1457ecb654d7867b3272cc8f45"}
{"number":475,"pts":475000,"checksum":"22e33a2892d288117ac10def4184cafa"}
{"number":500,"pts":500000,"checksum":"94ad4e1db7fc8fa4a427ad3714269719"}
{"number":525,"pts":525000,"checksum":"06e57659e327d90511378bb789b36f8c"}
{"number":550,"pts":550000,"checksum":"ab6769f4b7cb03571cc439eaa936a352"}
{"number":575,"pts":575000,"checksum":"a5df4e47b89dae5cd43cb6e0d23b367d"}
{"number":600,"pts":600000,"checksum":"01c020e4f76ed8ac3a1bcd744e504dbe"}
{"number":625,"pts":625000,"checksum":"e4b541da216cf8be1e5a48d11f133a35"}
I added this cloud storage in cvat.
When I try to create a task using this I am getting below error
Could not fetch content for cloud storage #3
Error: Request failed with status code 400. "Invalid 'manifest2.jsonl file structure': 'extension' is required, but not found"

Hi @prasadn1985 , only datasets with images on a cloud storage are supported in the current implementation.


remove typing and typing_extensions deps

Codecov Report

Merging #335 (c733a96) into main (a2ddc2f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   80.26%   80.25%   -0.01%
==========================================
  Files          18       18
  Lines        2554     2553       -1
  Branches      450      450
==========================================
- Hits         2050     2049       -1
  Misses        350      350
  Partials      154      154

Files
Coverage Δ

src/ansys/pyensight/core/listobj.py
75.64% <100.00%> (-0.31%)
:arrow_down:


Need to explain how to reconfigure a Self-Hosted IR installation

After you have it installed, it would be good to make it clear how to reconfigure it.
For example:

If I regenerated the key I was using, how do I update it on my Self-Hosted IR installation? or
If I wanted to remove that Integration Runtime and I want to reuse the VM/Node on another IR, how do I do it?

I figured out that we just need to use dmgcmd.exe -Key [AuthenticationKey] and then restart the service, but I found it myself. It should be documented.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32785d15-8202-6e44-f1d2-420ef0600f3f
Version Independent ID: 3af5fa49-7bd4-18ce-f8dc-aa4a2b8c6478
Content: Create a self-hosted integration runtime in Azure Data Factory
Content Source: articles/data-factory/create-self-hosted-integration-runtime.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

Thank you for your question/comment @ricardoserradas .  We will review the document and get back to you.

I understand your first point, and including in documentation makes sense to me.
However I am having trouble with your second point.  Could you please clarify, @ricardoserradas ?
  An Integration Runtime allows Data Factory to access the local data sources.  How is one IR different from another?

Hi Martin.
Thank you for considering my feedback. Sure, let me try to clarify the scenario.
Imagine that I have a VM and I configure the Self-Hosted IR on it, pointing to a IR called MyFirstIR.
Time goes by and, for some reason, I need to use this VM on a different IR, called MySecondIR.
It would be nice to have instructions on how we should proceed to point this VM's Self-Hosted IR to MySecondIR.
Let me know if you need more information from me.

P.S.: I'd love to contribute to the doc by adding a suggestion for these instructions if these days were not so crazy. If things go calmer and this is still open, I will be more than happy to contribute.

@ricardoserradas  , would a shared IR be more useful than redirecting the IR?

@nabhishek , what do you think about adding mention of dmgcmd.exe to the doc?  People do regenerate their keys.

@ricardoserradas , I have assigned this issue to author @nabhishek .

@ricardoserradas , would a shared IR be more useful than redirecting the IR?

I acknowledge the possibility but I also understand that the user may not understand that he/she could work this around by sharing the IR. I'm trying to help addressing the actual reconfiguration of the IR.

@nabhishek , what do you think about adding mention of dmgcmd.exe to the doc? People do regenerate their keys.

Yes, that would be great. Reassigning the key would actually reassign the host to the IR that owns the key. Perfect.
Thanks for all the help, Martin!

@ricardoserradas, Thanks a lot the dmgcmd.exe -Key [AuthenticationKey]  dit the job. Thsi is clearly missing from the documentation.

hey folks. I've just tried to reconfigure my existing Self-hosted node with a new AuthenticationKey, instead of uninstalling the whole app and install it manually. Works great. Small issue though. When I use option with NodeName it doesn't work and giving a name is "Node_1" always. How to grant the required name to the node?

The command-line's are documented here.
Though you can reconfigure SHIR using the above command-lines, it is suggested to do a clean uninstall/install. This would wipe out all other configurations/ customizations/ encrypted credentials.

#please-close

It's a shame that the documentation was not updated after this issue.
I've wasted days until I found the same solution

Hi not much familiar with SHIR but, what will be the impact to the connected data store if I uninstall SHIR? Let's say if there are activities scheduled, how does it affect the existing pipeline? Do we have a doc for this?

There should be an option in GUI to edit the key

There should be an option in GUI to edit the key

Agreed!


Ledger no longer working with latest upgrade

Error - Cannot read properties of undefined (reading 'send')
Using Ledger Nano X.
latest Chrome Browser
Windows 11
Terra Station Extension
Trying to send LUNC from one wallet to another.

@jagmot Our team has opened a ticket for you based on your question. You need to speak with The live support chat agent to get answers.
Chat with a live chat agent using ticket ID 67KO147 by clicking the link below
You can reach our support team via Ledger Support
Note; Click on the live chat icon at the bottom corner of the page to initiate the chat.

Be very careful, that is a scam link and phishing attempt.

I tried again today and it worked. So I will go ahead and close this issue.


Search (ctrl+f) works only in view field in CodeMirror

No such problem in textarea. But CodeMirror is default.
Possible to fix?

@oleedd
This would require adding the search addon for CodeMirror.
https://codemirror.net/doc/manual.html#addons
Not too hard to fix, just needs someone with time to do it.

It would be very nice)

It is probably a javascript search.
Possible to make the standard browser search work as it works in the textarea?

It is probably a javascript search in the addon.
CodeMirror is very strange. It rewrites strings according to the view field and deletes lower/higher strings from the html. The search does't work because all strings don't exist in the html at the same time. There seems to be some limit for the number of strings.
Moreover, such behavior requires certain computing power, which don't justify the goal - CPU loads up to 50% (i5) during scrolling.
Possible to fix this rewriting and remove these useless calculations to make the standard browser search work as it works in the textarea?

It is probably a javascript search in the addon.
CodeMirror is very strange. It rewrites strings according to the view field and deletes lower/higher strings from the html. The search does't work because all strings don't exist in the html at the same time. There seems to be some limit for the number of strings.
Moreover, such behavior requires certain computing power, what doesn't justify the goal - CPU loads up to 60% (i5) during scrolling.
Possible to fix this rewriting and remove these useless calculations to make the standard browser search work as it works in the textarea?


Error "Remote host method get_BufferSize is not implemented" when running on build agent

When running automatic build on teamcity agent (runned as service, without console) i got error:
Executing: & "sc.exe" delete "DocumentFileProcessorService" Error: System.Management.Automation.RemoteException: Remote host method get_BufferSize is not implemented.    at System.Management.Automation.Runspaces.AsyncResult.EndInvoke()    at System.Management.Automation.PowerShell.CoreInvokeRemoteHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)    at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)    at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)    at System.Management.Automation.RemotePipeline.Invoke(IEnumerable input)    at Cake.Powershell.PowershellRunner.Invoke(String script, PowershellSettings settings)    at Cake.Services.ServiceManager.Uninstall(String name, String computer)    at Submission#0.UninstallService(String name, String computer)    at Submission#0.UninstallDFPService()    at Submission#0.PublishDFPServiceToZos()    at Submission#0.<.ctor>b__512_7()    at Cake.Core.ActionTask.Execute(ICakeContext context)    at Cake.Core.DefaultExecutionStrategy.Execute(CakeTask task, ICakeContext context)    at Cake.Core.CakeEngine.ExecuteTask(ICakeContext context, IExecutionStrategy strategy, Stopwatch stopWatch, CakeTask task, CakeReport report)    at Cake.Core.CakeEngine.RunTarget(ICakeContext context, IExecutionStrategy strategy, String target)    at Cake.Scripting.BuildScriptHost.RunTarget(String target)    at Submission#0..ctor(Object[] submissionArray, Object& submissionResult)    at Submission#0.<Factory>(Object[] submissionArray)    at Microsoft.CodeAnalysis.Scripting.ScriptExecutionState.RunSubmission(Func2 submissionRunner)    at Microsoft.CodeAnalysis.Scripting.Script.Run(Object globals)    at Microsoft.CodeAnalysis.Scripting.Script.Run(Object globals)    at Cake.Scripting.Roslyn.Nightly.DefaultRoslynNightlyScriptSession.Execute(Script script)    at Cake.Core.Scripting.ScriptRunner.Run(IScriptHost host, FilePath scriptPath, IDictionary2 arguments)    at Cake.Commands.BuildCommand.Execute(CakeOptions options)    at Cake.CakeApplication.Run(CakeOptions options)    at Cake.Program.Main()
Is there a way to pass settings to Cake.Powershell as in :
method get_BufferSize is not implemented ?

Course 😄, it will be fixed in v0.2.9 👍


[Enhancement] Add a retry mechanism to the unit test pipeline

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
Introduce a retry mechanism in the unit test pipeline to automatically retry failed unit tests a limited number of times, reducing manual intervention and improving the reliability of CI builds
Motivation

Currently, the unit test pipeline occasionally fails due to intermittent test issues, leading to unnecessary build failures. These failures require manual retries, which can be time-consuming and inefficient. This enhancement would contribute to smoother CI/CD operations, benefiting both the project and the community by increasing build reliability and reducing manual workload.
This task is part of the RocketMQ community's assignments under the OSPP activity, as detailed in the OSPP2024

Describe the Solution You'd Like
The solution involves implementing a retry logic within the CI pipeline that triggers a limited number of retries when a unit test fails. The retry mechanism would only be activated under specific conditions, such as test failures, to prevent unnecessary re-runs. This can be achieved by utilizing conditional steps in the workflow file to rerun the tests if a failure is detected.
Describe Alternatives You've Considered

Manual Retries: Continue with the current process where developers manually trigger retries, but this is inefficient and prone to delays.
Test Flakiness Detection: Implement a mechanism to identify and fix flaky tests; however, this is a longer-term solution that requires additional resources.

Additional Context
No response

link #8262


fix: save object when useAutoIncrement is disabled

Description
Fixes: #7040
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

@michalsn Thank you!


[FLINK-19822][table-planner] Remove redundant shuffle for streaming

What is the purpose of the change
Shuffle is one of the most heavy operation, and many shuffle operations is redundant, because the input operators have provide the required shuffle. Blink batch planner has supported removing redundant shuffle through planner rules, Blink streaming planner could also leverage similar approach to remove redundant shuffle. Different batch, stream operators require the shuffle keys and the state keys must be exactly the same, otherwise the state may be not correct. In this pr, we only support Join and regular Aggregate, other operators will be supported  in the future.
Brief change log

Do some code cleanup for BatchExecCalcBase and BatchExecCorrelateBase
Introduce join condition equal transfer rules to simplify join condition
Remove redundant shuffle for StreamExecJoin And StreamExecGroupAggregate

Verifying this change
This change added tests and can be verified as follows:

The existing tests could cover the first two commits, e.g. batch.sql.RemoveShuffleTest, stream.sql.join.JoinReorderTest
Added new test that validates the result of third commit, e.g. stream.sql.RemoveShuffleTest, RemoveShuffleITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@godfreyhe Why was this never merged? It seems like good improvement. Maybe you can give us some background.


Add more notifiers

Currently, fikkie is able to send notifications using the following applications:

Slack
Telegram
Discord
Good-old e-mail

It would be awesome to add notifiers for a chat app you're missing. Please let me know if there are any, or better, send a PR! :heart:

Hey @nootr what about Microsoft teams?

Hi, @DipayanP007! Great idea!
I don't have a lot of experience with Microsoft Teams bots, so if you'd like, you could implement it and create a PR. Otherwise, I will try to do that later this week. :)

Hi @nootr I can give it a try

But i will need some docs on how to configure it to current chat apps so that I can test it out

I've written some docs on configuration for the other chat apps: https://nootr.github.io/fikkie/notifiers
To test fikkie, I normally let it SSH to localhost. If you want, I could write some docs on how to setup a dev environment.
Please let me know if you've got any questions.

@DipayanP007, I wrote a small guide on how you could set up a development environment: https://nootr.github.io/fikkie/development


Add disabled undo & redo buttons for when there is nothing to undo/redo

When there is nothing to undo, the undo button grays out. When there is nothing to redo, the redo button grays out.
The buttons are updated correctly when creating a new file or when going to a different tab.
This is only a visual change. Hovering over the buttons still shows a hint, and clicking on them still makes them do their thing.
Note: this does not behave as expected when the user zooms in/out. For some reason, zooming in/out marks a project as "dirty", which enables the undo button as a result. I've decided to ignore this because zooming in/out shouldn't mark a project as "dirty" in the first place (please correct me if I'm wrong)
Also, I know this project is currently being updated to Godot 4: I don't mind waiting and rewriting the PR after that's done.
(This is kinda my first PR, sorry if I screwed something up)

Hello, sorry for the late reply. I finally ported Lorien to Godot 4. I'd like to merge your change, so if you're still interested feel free to update the PR :)

Nice! Working on it asap.


Added filtering functionality to MultiSelect and SelectDropDown (+variants) + css fixes for scrollbar

Some of the components that this rolls out to might be used in ways I can't predict well in this PR. I made the code easy enough that we can account for this, but someone with more understanding of the different pages selects are used might want to chime in. Tests are passing at least.

Summary

Added MultiSeach component, which enables search-based filtering in multi element list components (resolves #1815)
Rolled out said component into various select based views
Fixed issue reported on Discord related to scroll-bar not appearing correctly on Chrome browsers

minor

Updated build file to not enforce minification during development builds
Minor type updates, Noticed that the cn helper wasn't accounting for the boolean states, so I corrected this.

Change Type
Please delete any irrelevant options.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Translation update

Testing
In various views that use Select lists with more than 10 items, a search bar appears.
Test Configuration:
Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines (I think so?)
[x] I have performed a self-review of my own code
[x] I have commented in any complex areas of my code
[x] My changes do not introduce new warnings
[x] Local unit tests pass with my changes (npm run test passes in the client directory)

Thank you for your work on this!
I think when elements exceed 10 is great and along the lines what I was envisioning. Another approach could be % of viewport the items take but this is fine.
for styling, I would make the search icon slightly smaller but I'm happy to merge as-is and adjust later.
Just curious, when did you find the need to make minification options explicit? I wasn't experiencing difficulties with minified code in dev, or does that just avoid minification altogether in dev mode? I suppose the code was still being minified but sourcemapped in dev mode.

Hey @danny-avila, I think it would be safe to remove this. I was experiencing issues in react dev tools, but it was because I accidentally used the static build proxy that's provided by the api on port:3080.
The better solution in this case would to be to disable the static proxy on the backend when dev mode is enabled - which is not what I ended up doing. I'll amend the PR to make sure that config file gets reverted.

@danny-avila - just updated and removed those vite changes 👍🏻

Thanks, going to test this today.

Made some edits on this, closing in favor of https://github.com/danny-avila/LibreChat/pull/2138


Implementing LON topology

Motivation
I was wondering about other 3D topologies, I'm mainly interested in 'lon'.
What should be done?
Steps for the realization of the task:
What will be obtained?
Is there any deadline?
Any other thing?

@KStrutynski I've starting working in the implementation of the LON net.


Move jupyter/nb2kg to jupyter_server and archive repo

The jupyter/nb2kg repository houses the NB2KG server extension used to configure a Notebook server to communicate with a Gateway server (running either Jupyter Kernel Gateway or Jupyter Enterprise Gateway).  This server extension has been obsolete since its functionality was introduced into the gateway package of Notebook versions >= 6.0 and all Jupyter Server versions.
I would like to propose two changes relative to this repository:

Since the two related Gateway projects are already in the Jupyter Server organization, I think it makes sense to also have the nb2kg repository in that same organization and propose it be moved into jupyter_server/nb2kg.
Because this repository is essentially obsolete, yet continues to get dependabot alerts that it needs its dependency on notebook to be >= 6.4.12, where it should not be used anyway, I think it best that the repository be archived.

I will hold off on any changes until we've decided if zero, one, or both of these changes should be made.

I think if we're just going to archive it we should leave it in the jupyter org so it is more discoverable if someone was previously using it.

That makes sense.

Per today's Jupyter Server/Kernels team meeting  we felt (within the meeting) that archiving jupyter/nb2kg in-place is probably the best step moving forward (in line with @blink1073's suggestion).  I've been asked to poll @jupyter-server/jupyter-server-council regarding the repository's archival.  In the meantime, I've commented on an existing issue in the nb2kg repo (which is 2+ years old) indicating the (new) desire to archive the repository.
Polling
Polling is open to all members of the Jupyter Server Council.  Anyone is free to comment.
Using the built-in emojis, please indicate approval to archive the nb2kg repository within the jupyter organization using :+1: and its disapproval using :-1:.  If you'd like to further discuss its future, please feel free to comment separately.
Thank you.

Sorry, this should have been closed with the previous comment.


readme.md: "import JSONJoy" should be "import JSONJoy-Swift" ?

No, it is JSONJoy on purpose. The repository name is JSONJoy-Swift because I have an objective-c version that was created first and has the same name. The productName in the framework is JSONJoy as to not add the unneeded -Swift part.


Use transparent functors in placeholder expressions.

Fixes and adds regression tests for #1178 & #1229.

Is the plan to bring #1186 back after this is merged in?

That commit was only reverted on a staging branch for an upcoming release, which is only taking critical bugfixes right now.
#1186 is still in main and this patch fixes the related regressions by making the placeholder implementation more robust.

Rebased on master, started DVS CL 28862936.

Confirmed that this change doesn't significantly impact compile times.
Restarted DVS on same CL after refactoring the new static assert in actor.

@dkolsen-pgi can you review this when you get a chance? It addresses your issue with thrust::find, #1229.

rebased and addressed review feedback.


When i added Arabic Movie it;'s name show as "???????????" (Arabic Error)

Issue description
Arabic fonts is missing or something wrong
when i added Arabic Movie it;'s name show as "???????????"
refer: ScreenShot
thank you!

change name to english


Add support for shadow in proxy

Pull Request Test Coverage Report for Build 2056

8 of 71 (11.27%)  changed or added relevant lines in 6 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.09%) to 58.942%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java
0
2
0.0%

sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java
0
4
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java
0
15
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java
0
21
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java
0
21
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java
1
0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java
2
1.54%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java
2
1.61%

Totals

Change from base Build 1037:
-0.09%

Covered Lines:
12119

Relevant Lines:
20561

💛  - Coveralls


Location services are not enabled on device

Hi,
I use xamarin forms and the location is not enabled on the device.
Then I get the exception. But how can I provide a solution to show the prompt to enable location service?
I did not find the method in the library.
What are the solutions available?
Thanks,

You will just have to prompt the user to turn on their location settings and open the settings on the device.

Is there a code to open the settings? I wanted to show the prompt dialog like in maps on Android. Enable location? Would you have a sample to do this? Thanks


can't see spire(respec) preset

The spire(respec) is just inexistant on my perky even tho i need it was there some time ago. I cleared my cache+cookies and tried using it on firefox but
i still have the same issue.

It’s hidden on purpose, to help prevent people mistakingly using it. This respec removes almost all income perks to scrounge up slightly more damage and health, so doing an entire run with it is very much not recommended. Get to z200 normally, farm for all the gear you want, and then respec (that’s why the preset is called “Spire respec”).


Add in Web.config merge for IIS Presets

🔗 Linked issue
Resolves https://github.com/unjs/nitro/issues/1628
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
@pi0 Adding additional functionality to https://github.com/unjs/nitro/pull/1436 in order to prevent breaking changes for those already integrated with IIS
Additional notes:

I will be adding in another PR, the functionality to generate the environment variables from runtimeConfigs.

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

Thanks for the PR. Before i can make a review, can you please revert additional changes from PR? 🙏🏼


Machine linux-35 lost external connection Android device.

Machine linux-35 lost external connection Android device.

External connection has been restored by rebooting machine.


Small clean ups to factory caching

I was reading the factory caching code and noticed some small issues and ways to simplify. This just cleans up a bit.

I'll be back in a few days to review this - just a little cautious as there's a lot of subtlety to the factory cache.


Bump codecov to v3

Codecov Report

Merging #63 (0f01815) into master (0166bb3) will decrease coverage by 4.33%.
The diff coverage is 91.56%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   98.55%   94.21%   -4.34%
==========================================
  Files           3        5       +2
  Lines          69      121      +52
  Branches       12       28      +16
==========================================
+ Hits           68      114      +46
- Misses          1        7       +6

Flag
Coverage Δ

unittests
94.21% <91.56%> (-4.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/use-infinite-subscription.ts
77.41% <77.41%> (ø)

src/subscription-storage.ts
100.00% <100.00%> (+7.14%)
:arrow_up:

src/use-observable-query-fn.ts
100.00% <100.00%> (ø)

src/use-subscription.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[shape] add

Coverage decreased (-0.4%) to 30.489% when pulling 03ff3a00b933712f5ea7af441e7f6fac3932af8e on harry-lineradial into 4b7a83a315a98afad302ec7979e2cf2e4e759f69 on master.

Coverage decreased (-1.6%) to 29.336% when pulling c0eda0811265cea9d5e46175394c31f94d990fa6 on harry-lineradial into 4b7a83a315a98afad302ec7979e2cf2e4e759f69 on master.

Fixes #51

Coverage decreased (-2.2%) to 28.752% when pulling 30cea681b6a59847c48ae2f8b50644bd70f42cb4 on harry-lineradial into 4b7a83a315a98afad302ec7979e2cf2e4e759f69 on master.

Coverage decreased (-2.2%) to 28.752% when pulling 7970ca6f382ff06d9e66eba2b1f47420b3f13fc0 on harry-lineradial into 4b7a83a315a98afad302ec7979e2cf2e4e759f69 on master.


[Doc] Broken link in "Introduction"

The link to the standard itself is wrong/old (resulting in 404):
http://www.dicomstandard.org/dicomweb/
(I guess it should be: https://www.dicomstandard.org/current/ )
Found on:
https://dicomweb-client.readthedocs.io/en/latest/introduction.html

Thank you for reporting the issue @Zaelot. It appears the location of the website has changed. It is now located at https://www.dicomstandard.org/using/dicomweb.


fixing #7590 by delaying div shrink after mouse up

Uses a timeout to delay shrinking of divs, if another mousedown event occurs, it resets the timer. This fixes double click and right click highlighting on webkit browsers. This logic only applies when the enhanced text selection is turned on.
Fixes #7590.

/botio-linux preview

/botio-linux preview

Hi @timvandermeij, anything else needed here?

I think it only needs to be tested in Chrome and other browsers. We will probably get to that soon though. In terms of code it looks good to me.

hey @timvandermeij, any update on this PR?

I'm sorry for the late response here. The last few days have been rather busy and I forgot about reviewing this. I'll probably be able to review this later this week. I'll assign it to myself so it's in my review queue and create a new preview to get things going. Thanks for reminding me!

/botio-linux preview

no worries @timvandermeij, thanks!

Thank you for fixing this!

@jeremypress @timvandermeij
Thanks for fixing this. However this brakes stuff in our app related to normal selection (click and drag). We rely on using Range.getClientRects to calculate selection boundaries and with the timeout we get wrong values there.
Because this fix is for double-clicking, I found following solves my problem and keeps the fix:
diff --git a/web/text_layer_builder.js b/web/text_layer_builder.js
index 0a03a42..19cefe1 100644
--- a/web/text_layer_builder.js
+++ b/web/text_layer_builder.js
@@ -363,7 +363,7 @@ var TextLayerBuilder = (function TextLayerBuilderClosure() {
           expandDivsTimer = setTimeout(function() {
             self.textLayerRenderTask.expandTextDivs(false);
             expandDivsTimer = null;
-          }, EXPAND_DIVS_TIMEOUT);
+          }, getSelection().isCollapsed ? EXPAND_DIVS_TIMEOUT : 0);
 //#else
 //        self.textLayerRenderTask.expandTextDivs(false);
 //#endif

Would you mind me sending a pull request for this?

This patch is already a hack to fix a browser specific issue, but was deemed acceptable since double-clicking on words probably is a somewhat common operation.
However adding yet another hack on top of it (as https://github.com/mozilla/pdf.js/pull/7618#issuecomment-251116837 suggests) to deal with a use-case that doesn't really apply to the default viewer, but rather only to a custom deployment of it, does not seem wanted to me. (Note that it's mentioned in multiple places that the default viewer isn't intended to be used as-is, but rather built upon in custom implementations.)
Hence a modification such as the mentioned in https://github.com/mozilla/pdf.js/pull/7618#issuecomment-251116837 seems to me to belong in custom implementation, rather than the default PDF.js viewer.

I agree with the above. It's fine for a custom deployment, but not for the default viewer.


Adapt DH to use with KEYMGMT

The biggest part in this was to move the key->param builder from EVP
to the DH ASN.1 method, and to implement the KEYMGMT support in the
provider DH.

Now that #9312 has been merged, it's time to take this out of WIP

Needs a rebase

Rebase done

Rebased, again

Rebased.  Only an adjustment of util/libcrypto.num needed, so I count your approval still.  Just want to see that the CIs agree, then I'll merge.

Reconfirm assuming CIs pass.

An empty line at the end of util/libcrypto.num got the builds to belly up...

Ok!  Time to merge

Merged.
8b84b075ff065554c0cdd1086950f1a8614d93a4 Adapt DH to use with KEYMGMT


chore(docs): site list responses, with latest audit (#112)

Fixes #112

:tada: This PR is included in version 1.17.2 :tada:
The release is available on:

v1.17.2
GitHub release

Your semantic-release bot :package::rocket:


fix flaky k8s event tests  with new fakerecorder

Changes
This commits fixes flaky k8s event test, https://github.com/tektoncd/pipeline/pull/5748. The tests are flaky
because we have a timer eventsFromChannel and it may lead to some
events are not collected and cause errors.

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/test tekton-pipeline-unit-tests

/kind flake

@Yongxuanzhang we're still seeing this flake quite consistently, I think we should prioritize this fix! thanks for working on it!


[Feature Suggestion] Double-click the layer name to load image (in the Which bounding tile to display UI)

Is it possible to add the ability to just double-click the layer name in the "Which bounding tile to display..." UI dialog?
It would be a bit faster and more efficient with less mousing around.

.
Thanks,
David

Hi David,
Thank you for your suggestion.
It's a great idea that is now implemented with 0.0.29


Ingestion: Databricks profiler not working when  Use Unity Catalog enabled

Affected module
Does it impact the UI, backend or Ingestion Framework?

It seems like relates to ingestion Framework

Describe the bug
A clear and concise description of what the bug is.

Databricks profiler not working when enabled Use Unity Catalog.  After disabling it, it works as expected. here is stacktrace.

--------------------------------------------------------------------------------
[2023-08-16, 12:00:13 KST] {taskinstance.py:1377} INFO - Starting attempt 1 of 1
[2023-08-16, 12:00:13 KST] {taskinstance.py:1378} INFO -
--------------------------------------------------------------------------------
[2023-08-16, 12:00:14 KST] {taskinstance.py:1397} INFO - Executing <Task(PythonOperator): profiler_task> on 2023-08-15 03:00:00+00:00
[2023-08-16, 12:00:14 KST] {standard_task_runner.py:52} INFO - Started process 111 to run task
[2023-08-16, 12:00:14 KST] {standard_task_runner.py:79} INFO - Running: ['airflow', 'tasks', 'run', 'databricks_profiler_IExXS4Tl', 'profiler_task', 'scheduled__2023-08-15T03:00:00+00:00', '--job-id', '187', '--raw', '--subdir', 'DAGS_FOLDER/databricks_profiler_IExXS4Tl.py', '--cfg-path', '/tmp/tmp1035sahv', '--error-file', '/tmp/tmpgfbidpwv']
[2023-08-16, 12:00:14 KST] {standard_task_runner.py:80} INFO - Job 187: Subtask profiler_task
[2023-08-16, 12:00:14 KST] {task_command.py:371} INFO - Running <TaskInstance: databricks_profiler_IExXS4Tl.profiler_task scheduled__2023-08-15T03:00:00+00:00 [running]> on host databricksprofileriexxs4tlprof-3282af2414ec45609b1768e3ef16d9c1
[2023-08-16, 12:00:15 KST] {logging_mixin.py:115} WARNING - /home/airflow/.local/lib/python3.9/site-packages/airflow/models/renderedtifields.py:249 SAWarning: Coercing Subquery object into a select() for use in IN(); please pass a select() construct explicitly
[2023-08-16, 12:00:15 KST] {taskinstance.py:1589} INFO - Exporting the following env vars:
AIRFLOW_CTX_DAG_OWNER=admin
AIRFLOW_CTX_DAG_ID=databricks_profiler_IExXS4Tl
AIRFLOW_CTX_TASK_ID=profiler_task
AIRFLOW_CTX_EXECUTION_DATE=2023-08-15T03:00:00+00:00
AIRFLOW_CTX_TRY_NUMBER=1
AIRFLOW_CTX_DAG_RUN_ID=scheduled__2023-08-15T03:00:00+00:00
[2023-08-16, 12:00:17 KST] {test_connections.py:215} INFO - Test connection results:
[2023-08-16, 12:00:17 KST] {test_connections.py:216} INFO - failed=[] success=["'CheckAccess': Pass", "'GetDatabases': Pass", "'GetSchemas': Pass", "'GetTables': Pass", "'GetViews': Pass", "'GetQueries': Pass"] warning=[]
[2023-08-16, 12:00:17 KST] {workflow.py:128} INFO - Starting profiler for service databricks:databricks
[2023-08-16, 12:00:18 KST] {taskinstance.py:1909} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 171, in execute
    return_value = self.execute_callable()
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 189, in execute_callable
    return self.python_callable(*self.op_args, **self.op_kwargs)
  File "/home/airflow/.local/lib/python3.9/site-packages/openmetadata_managed_apis/workflows/ingestion/profiler.py", line 49, in profiler_workflow
    workflow.execute()
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/api/workflow.py", line 326, in execute
    raise err
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/api/workflow.py", line 317, in execute
    profile = self.run_profiler(entity, profiler_source)
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/api/workflow.py", line 269, in run_profiler
    profiler_runner: Profiler = profiler_source.get_profiler_runner(
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/source/base_profiler_source.py", line 205, in get_profiler_runner
    profiler_interface = self.create_profiler_interface(
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/source/base_profiler_source.py", line 185, in create_profiler_interface
    ] = ProfilerProtocol.create(
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/interface/profiler_protocol.py", line 99, in create
    return cls.subclasses[_profiler_type](
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/profiler/interface/sqlalchemy/profiler_interface.py", line 109, in __init__
    self.set_catalog(self.session)
  File "/home/airflow/.local/lib/python3.9/site-packages/metadata/mixins/sqalchemy/sqa_mixin.py", line 94, in set_catalog
    bind.execute(
AttributeError: 'WorkspaceClient' object has no attribute 'execute'

To Reproduce

Create Databricks Connection with Use unity catalog enabled.
Add profiler Ingestion.
View logs in open-metdata airflow tasks

Screenshots or steps to reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: Running in k8s env, using offical openmetadata helm chart
Python version: 3.9.12
OpenMetadata version: 1.1.0
OpenMetadata Ingestion package version: I don't know which version of used in docker images. i've used openmetadata/ingestion:1.1.0 image

Additional context
Add any other context about the problem here.

IMHO, the below line should be fixed.

https://github.com/open-metadata/OpenMetadata/blob/9e6e00caf9c90dd2a1de6f53311058f0fd7445a1/ingestion/src/metadata/ingestion/source/database/databricks/connection.py#L57-L61

closing this ticket as duplicate of #12947


Image Signing

Added a tools page to describe image signing per https://github.ibm.com/gsi-labs/industry-cloud-planning/issues/143
In conjunction with https://github.com/IBM/ibm-garage-tekton-tasks/pull/127

Replaced by #444 after switch to mkdocs format


Cannot save bcolz data from csv.gz, blaze.Data, or pandas.DataFrame

Have a data shape that uses string, int64, float64, and datetime.
Cannot covert a test.csv.gz file to .bcolz from different different sources:
*  csv.gz file
*  .csv.gz file loaded into a blaze.Data
*  .csv.gz file loaded into a pandas.DataFrame
Have test script and data to reproduce errors.

@ltransom see #181, #186, #253. bcolz has terrible support for object dtypes. can you try with a fixed length string dshape in your string column?

This should be fixed by https://github.com/Blosc/bcolz/pull/244

Can you give it a go and if it works close the issue?

Two of the three test scenarios pass now:
odo(.csv.gz, .bcolz)  - works
odo(pandas.DataFrame, .bcolz) - works
odo(blaze.Data, .bcolz) - still fails
ValueError: could not broadcast input array from shape (99999) into shape (3)
The data shape:
ds_fixed = dshape("var * { TradeTime: datetime,
Symbol: string[10, 'A'],
Price: float64,
Shares: int64,
Exchange: string[2, 'A'],
Sales: string[5, 'A'],
Sequence: int64,
Bid: float64,
Ask: float64,
BSize: int64,
ASize: int64
}")

@ltransom awesome! thanks for trying this out .... checking out the last case in a bit

@ltransom how did you construct the blaze.Data object?

from odo import odo, drop
from blaze import dshape, Data, Symbol, compute, resource
import pandas as pd
import os
from shutil import rmtree
TEST_PATH = "../../nobackup/test/"
TEST_BASE = "test"
TEST_NAME = TEST_PATH + TEST_BASE
ds_fixed = dshape("var * { TradeTime: datetime,
Symbol: string[10, 'A'],
Price: float64,
Shares: int64,
Exchange: string[2, 'A'],
Sales: string[5, 'A'],
Sequence: int64,
Bid: float64,
Ask: float64,
BSize: int64,
ASize: int64
}")
def test_bcolz_data():
src_name = TEST_NAME + ".csv.gz"
tgt_name = TEST_NAME + ".bcolz"
if os.path.exists(tgt_name):
# drop(tgt_name)
rmtree(tgt_name)
bdf = Data(src_name)
odo(bdf, tgt_name, dshape=ds_fixed)
assert compute(Symbol('trades', ds_fixed).nrows, resource(tgt_name)) == 99999

Using the same test data file I sent you.

@ltransom I just tried this against bcolz master and everything works. You'll have to install bcolz master. You can either clone and install from source or use pip install git+git://github.com/Blosc/bcolz (requires Cython [conda install cython -y]).


[WIP] Refactor template

What happened
Insight
Describe in details how to test the changes. Referenced documentation are welcome as well.
Proof Of Work
Show us the implementation: screenshots, gif, etc.

I'm closing this PR as its last push was several months before the last release 5.0.0 ;-)
Feel free to reopen it any time if needed 🙌


[Accessibility][Screen Reader-New Trigger] : In scan mode, the state is not announced by the screen reader at New Trigger dialog.

User Experience
The AT user might gets confused as state is not announced by the narrator.
Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here
Repro Steps:

Open the above mentioned URL in EDGE.
Select 'Design Flow' from left navigation.
Now, navigate to 'New Trigger' button available in the filter dialog pane and activate it..
Navigate the dialog in scan mode and observe the issue in "No intent configured for this dialog" dropdown.

Actual Result:
Screen reader doesn’t read the state i.e. disabled after the text while announcing in the scan mode.
Ex- Narrator narrates "No intent configured for this dialog" as a plane text
As per narrator narration it appears like plain text.
Expected:
The narrator should announce the state as the drop down is disabled.
Ex- It should be announced as "No intent configured for this dialog" disabled text.
Observation:
Same issue observed with NVDA.
MAS Guideline: MAS4.2.2
Attachment:
State should be announced for the diabled field.zip

We have changed the UI. The issue does not exist anymore.

As checked in the latest version, the UI has been updated. Due to which this issue doesn't appear to be valid any more. So closing the bug.


Add non-streaming download option

Related issues and pull requests
Fixes https://github.com/stac-utils/stac-asset/issues/202
Checklist

[ ] Add tests
[x] Add docs
[x] Update CHANGELOG

Codecov Report
Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (b675034) to head (7bfcab7).

Files
Patch %
Lines

src/stac_asset/http_client.py
0.00%
6 Missing :warning:

src/stac_asset/s3_client.py
0.00%
5 Missing :warning:

src/stac_asset/filesystem_client.py
60.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   85.03%   84.33%   -0.70%
==========================================
  Files          16       16
  Lines        1049     1060      +11
==========================================
+ Hits          892      894       +2
- Misses        157      166       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @drnextgis! Released in https://github.com/stac-utils/stac-asset/releases/tag/v0.4.3


Error 503: Service Unavailable - after commit 6666fa0

After updating to the latest commits and trying to set php to run 5.6 I'm getting a 503 Error: Service Unavailable when trying to browse to the site.
Here is my config.yml
---
# `vagrant_box` can also be set to geerlingguy/centos6, geerlingguy/centos7,
# geerlingguy/ubuntu1404, geerlingguy/ubuntu1204, parallels/ubuntu-14.04, etc.
vagrant_box: geerlingguy/ubuntu1404
vagrant_user: vagrant
vagrant_synced_folder_default_type: nfs

# If you need to run multiple instances of Drupal VM, set a unique hostname,
# machine name, and IP address for each instance.
vagrant_hostname: drupalvm.dev
vagrant_machine_name: drupalvm
vagrant_ip: <IP_ADDRESS>

# Allow Drupal VM to be accessed via a public network interface on your host.
# Vagrant boxes are insecure by default, so be careful. You've been warned!
# See: https://docs.vagrantup.com/v2/networking/public_network.html
vagrant_public_ip: ""

# A list of synced folders, with the keys 'local_path', 'destination', and
# a 'type' of [nfs|rsync|smb] (leave empty for slow native shares). See
# http://docs.drupalvm.com/en/latest/extras/syncing-folders/ for more info.
vagrant_synced_folders:
  # The first synced folder will be used for the default Drupal installation, if
  # build_makefile: is 'true'.
  - local_path: ../
    destination: /var/www/drupalvm
    type: nfs
    create: true

# Memory and CPU to use for this VM.
vagrant_memory: 1024
vagrant_cpus: 2

# The web server software to use. Can be either 'apache' or 'nginx'.
drupalvm_webserver: apache

# Set this to false if you are using a different site deployment strategy and
# would like to configure 'vagrant_synced_folders' and 'apache_vhosts' manually.
build_makefile: false
drush_makefile_path: ../../drupal.make.yml

# Set this to false if you don't need to install drupal (using the drupal_*
# settings below), but instead copy down a database (e.g. using drush sql-sync).
install_site: false

# Settings for building a Drupal site from a makefile (if 'build_makefile:'
# is 'true').
drupal_major_version: 8
drupal_core_path: "/var/www/drupalvm/docroot"
drupal_domain: "{{ vagrant_hostname }}"
drupal_site_name: "DrupalVM"
drupal_install_profile: standard
drupal_enable_modules: [ 'devel' ]
drupal_account_name: admin
drupal_account_pass: admin
drupal_mysql_user: drupal
drupal_mysql_password: drupal
drupal_mysql_database: drupal

# Additional arguments or options to pass to `drush site-install`.
drupal_site_install_extra_args: []

# Cron jobs are added to the root user's crontab. Keys include name (required),
# minute, hour, day, weekday, month, job (required), and state.
drupalvm_cron_jobs: []
  # - {
  #   name: "Drupal Cron",
  #   minute: "*/30",
  #   job: "drush -r {{ drupal_core_path }} core-cron"
  # }

# Drupal VM automatically creates a drush alias file in your ~/.drush folder if
# this variable is 'true'.
configure_local_drush_aliases: true

# Apache VirtualHosts. Add one for each site you are running inside the VM. For
# multisite deployments, you can point multiple servernames at one documentroot.
# View the geerlingguy.apache Ansible Role README for more options.
apache_vhosts:
  - servername: "{{ drupal_domain }}"
    documentroot: "{{ drupal_core_path }}"
    extra_parameters: |
          ProxyPassMatch ^/(.*\.php(/.*)?)$ "fcgi://<IP_ADDRESS>:9000{{ drupal_core_path }}"

  - servername: "adminer.{{ vagrant_hostname }}"
    documentroot: "{{ adminer_install_dir }}"
    extra_parameters: |
          ProxyPassMatch ^/(.*\.php(/.*)?)$ "fcgi://<IP_ADDRESS>:9000{{ adminer_install_dir }}"

  - servername: "xhprof.{{ vagrant_hostname }}"
    documentroot: "{{ php_xhprof_html_dir }}"
    extra_parameters: |
          ProxyPassMatch ^/(.*\.php(/.*)?)$ "fcgi://<IP_ADDRESS>:9000{{ php_xhprof_html_dir }}"

  - servername: "pimpmylog.{{ vagrant_hostname }}"
    documentroot: "{{ pimpmylog_install_dir }}"
    extra_parameters: |
          ProxyPassMatch ^/(.*\.php(/.*)?)$ "fcgi://<IP_ADDRESS>:9000{{ pimpmylog_install_dir }}"

  - servername: "{{ vagrant_ip }}"
    serveralias: "dashboard.{{ vagrant_hostname }}"
    documentroot: "{{ dashboard_install_dir }}"

apache_remove_default_vhost: true
apache_mods_enabled:
  - expires.load
  - ssl.load
  - rewrite.load
  - proxy.load
  - proxy_fcgi.load

# Nginx hosts. Each site will get a server entry using the configuration defined
# here. Set the 'is_php' property for document roots that contain PHP apps like
# Drupal.
nginx_hosts:
  - server_name: "{{ drupal_domain }}"
    root: "{{ drupal_core_path }}"
    is_php: true

  - server_name: "adminer.{{ vagrant_hostname }}"
    root: "{{ adminer_install_dir }}"
    is_php: true

  - server_name: "xhprof.{{ vagrant_hostname }}"
    root: "{{ php_xhprof_html_dir }}"
    is_php: true

  - server_name: "pimpmylog.{{ vagrant_hostname }}"
    root: "{{ pimpmylog_install_dir }}"
    is_php: true

  - server_name: "{{ vagrant_ip }} dashboard.{{ vagrant_hostname }}"
    root: "{{ dashboard_install_dir }}"

nginx_remove_default_vhost: true
nginx_ppa_use: true

# MySQL Databases and users. If build_makefile: is true, first database will
# be used for the makefile-built site.
mysql_databases:
  - name: "{{ drupal_mysql_database }}"
    encoding: utf8
    collation: utf8_general_ci

mysql_users:
  - name: "{{ drupal_mysql_user }}"
    host: "%"
    password: "{{ drupal_mysql_password }}"
    priv: "{{ drupal_mysql_database }}.*:ALL"

# Comment out any extra utilities you don't want to install. If you don't want
# to install *any* extras, make set this value to an empty set, e.g. `[]`.
installed_extras:
  - adminer
  # - blackfire
  - drupalconsole
  - mailhog
  # - memcached
  # - newrelic
  # - nodejs
  - pimpmylog
  # - redis
  # - ruby
  # - selenium
  # - solr
  - varnish
  # - xdebug
  - xhprof

# Add any extra apt or yum packages you would like installed.
extra_packages:
  - sqlite

# `nodejs` must be in installed_extras for this to work. Valid examples: "0.10",
# "0.12", "4.x", "5.x".
nodejs_version: "0.12"
nodejs_npm_global_packages: []
nodejs_install_npm_user: "{{ drupalvm_user }}"

# `ruby` must be in installed_extras for this to work.
ruby_install_gems_user: "{{ drupalvm_user }}"
ruby_install_gems: []

# You can configure almost anything else on the server in the rest of this file.
extra_security_enabled: false

drush_version: "master"
drush_keep_updated: true
drush_composer_cli_options: "--prefer-dist --no-interaction"

firewall_allowed_tcp_ports:
  - "22"
  - "25"
  - "80"
  - "81"
  - "443"
  - "4444"
  - "8025"
  - "8080"
  - "8443"
  - "8983"
firewall_log_dropped_packets: false

# PHP Configuration. Currently-supported versions: 5.6, 7.0.
# To use 5.6, see: http://docs.drupalvm.com/en/latest/other/php-56/

php_version: "5.6"
php_packages:
  - php5
  - php5-mcrypt
  - php5-cli
  - php5-common
  - php5-curl
  - php5-dev
  - php5-fpm
  - php5-gd
  - php5-sqlite
  - php-pear
  - libpcre3-dev
php_conf_paths:
  - /etc/php5/fpm
  - /etc/php5/apache2
  - /etc/php5/cli
php_extension_conf_paths:
  - /etc/php5/fpm/conf.d
  - /etc/php5/apache2/conf.d
  - /etc/php5/cli/conf.d
php_fpm_daemon: php5-fpm
php_fpm_conf_path: "/etc/php5/fpm"
php_mysql_package: php5-mysql
php_memcached_package: php5-memcached

xhprof_download_url: https://github.com/phacility/xhprof/archive/master.tar.gz
xhprof_download_folder_name: xhprof-master

php_memory_limit: "192M"
php_display_errors: "On"
php_display_startup_errors: "On"
php_realpath_cache_size: "1024K"
php_sendmail_path: "/usr/sbin/ssmtp -t"
php_opcache_enabled_in_ini: true
php_opcache_memory_consumption: "192"
php_opcache_max_accelerated_files: 4096
php_max_input_vars: "4000"

# Drupal VM defaults to using PHP-FPM with either Apache or Nginx. If you wish
# to instead use Apache + mod_php with an Ubuntu base box, make sure you add
# libapache2-mod-php7.0 to `extra_packages` elsewhere in this config file.
php_enable_php_fpm: true
php_fpm_listen: "<IP_ADDRESS>:9000"

composer_path: /usr/bin/composer
composer_home_path: "/home/{{ drupalvm_user }}/.composer"
composer_home_owner: "{{ drupalvm_user }}"
composer_home_group: "{{ drupalvm_user }}"
# composer_global_packages:
#   - { name: phpunit/phpunit, release: '@stable' }

# Run specified scripts before or after VM is provisioned. Path is relative to
# the `provisioning/playbook.yml` file.
pre_provision_scripts: []
post_provision_scripts: []
  # - "../examples/scripts/configure-solr.sh"

# MySQL Configuration.
mysql_root_password: root
mysql_slow_query_log_enabled: true
mysql_slow_query_time: 2
mysql_wait_timeout: 300
adminer_install_filename: index.php

# Varnish Configuration.
varnish_listen_port: "81"
varnish_default_vcl_template_path: templates/drupalvm.vcl.j2
varnish_default_backend_host: "<IP_ADDRESS>"
varnish_default_backend_port: "80"

# Pimp my Log settings.
pimpmylog_install_dir: /usr/share/php/pimpmylog
pimpmylog_grant_all_privs: true

# XDebug configuration. XDebug is disabled by default for better performance.
php_xdebug_default_enable: 0
php_xdebug_coverage_enable: 0
php_xdebug_cli_enable: 1
php_xdebug_remote_enable: 1
php_xdebug_remote_connect_back: 1
# Use PHPSTORM for PHPStorm, sublime.xdebug for Sublime Text.
php_xdebug_idekey: PHPSTORM
php_xdebug_max_nesting_level: 256

# Solr Configuration (if enabled above).
solr_version: "4.10.4"
solr_xms: "64M"
solr_xmx: "128M"

# Selenium configuration.
selenium_version: 2.46.0

# Other configuration.
dashboard_install_dir: /var/www/dashboard
known_hosts_path: ~/.ssh/known_hosts

Update: I think it's related to this PR
https://github.com/geerlingguy/drupal-vm/pull/636

Yup, my vagrant reload --provisions just completed and I can now access my VM as expected.

Fixed via PR mentioned above (#636).


release: 0.18.2

Latest patch release containing the improvements since 0.18.1.
Closes #2970
@adamreichold I ran cargo semver-checks against this by hand. The semver "violations" were the same as #2984. While both were to #[doc(hidden)] types not in the public API, it was easy to revert the TryFromPyCell removal so I added a commit here to do that (410840513ae7bf408b99802b4b9825438dc31fce).
There are a few PRs in flight which may be nice to include if they merge in time; I'll aim to rebase and push this on Tuesday next week.

With apologies my family fell ill again; I'll seek to rebase this at the weekend and push next Tuesday instead.

Finally rebased, I'll make every effort to push this tomorrow evening as-is unless someone gives me a reason not to!

Release is live!


Provide caller with information on raised exception after retry

As far as I can tell, when retryhandler.MaxAttemptsDecorator reaches its maximum number of attempts, the retryable exception is returned to the caller. I just spent about 3 hours tracing through boto3 and botocore and writing test code to reproduce a RequestLimitExceeded error, only to find that botocore was properly retrying and the only thing I can think of is that the request limit was really exceeded (even after 5 exponential backoff retries).
It would be very useful in cases like this if the retry handler either (a) wrapped the actual exception in a (e.g.) MaxRetriesExceeded exception, to make it clear that the request was retried and perhaps include the number of retries and maybe the sleep duration, or (b) at least fire an event with this information.
While I do really appreciate that the retry logic is so transparent, this also makes it a bit opaque for debugging, as there's really no way I can find to confirm (especially programmatically in the caller) that the request was, in fact, retried and all retries failed.
Thanks,
Jason Antman
(this came up when investigating this issue.)

Thanks for the feedback.  The only thing we'll need to keep in mind is we'll need to do this in a way that's backwards compatible.  Otherwise, I think being able to communicate this information somehow would be useful.

@jamesls I was just thinking about this, could we just add it to the ResponseMetadata?

@JordonPhillips I think that would work.

@jamesls @JordonPhillips I've got a simple implementation of this as https://github.com/boto/botocore/pull/965 - coverage stayed the same, though it appears that most of Endpoint isn't covered. I don't really have any experience with unittest, so I didn't attempt to rectify that.
The implementation may be a bit naive, so I'm certainly open to changing/reworking it as needed.


Openbox does not work together with KDE

Describe the bug
Openbox supports sessions with both KDE and Openbox. However, enabling both does not work. There is no session that combines them both: http://openbox.org/wiki/Help:Using_Openbox_in_KDE
Steps To Reproduce
Steps to reproduce the behavior:
desktopManager.plasma5.enable = true;
desktopManager.plasma5.supportDDC = true;
displayManager.gdm.enable = true;
windowManager.openbox.enable = true;

Expected behavior
Gdm provides a session name "KDE/Openbox" or similar.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
The system does contain a binary/script called openbox-kde-session as mentioned in the wiki post.
Notify maintainers

plasma5: @K900
gdm: @jtojnar (last contributor that was fairly active)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.06 MiB download, 0.30 MiB unpacked):
  /nix/store/51zlypw5hnf1b9lg56vlgfwla5zq1s9w-bash-interactive-5.1-p16-dev
copying path '/nix/store/51zlypw5hnf1b9lg56vlgfwla5zq1s9w-bash-interactive-5.1-p16-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.60, NixOS, 22.05 (Quokka), 22.05.20220821.23534df`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(me): `"nixos-21.05.4470.3b422991781, nixos-unstable-21.11pre323695.9aeeb7574fb"`
 - channels(root): `"nixos-21.11.334587.e6377ff3554, nixos-unstable-22.05pre338911.03ec468b140"`
 - nixpkgs: `/nix/store/mrf1rcmvfwsgdcrcvgg06mfz12im6inf-source`

I don't think those options work like that? Maybe we can add an Openbox+KDE session separately?
(not actually the plasma maintainer btw)

I don't think they are supposed to work in that way as well. But intuitively, that was the first thing that made sense to try out. It seems that the sessions exists in Arch: https://wiki.archlinux.org/title/KDE#KDE/Openbox_session. At least Gdm does not show it to me.


Doesnt work on 22.7.0.dev0

Versión: 0.4.0
Sentry Version: 22.7.0.dev0
I install & setup Legacy Integration with specific token & chatid but when i try to do a test it doesnt send message.

This repo is abandoned.
Use this fork: https://github.com/vortland/sentry-telegram

I see that test message works but only recieve sentry error via email. Telegram Notifications Python3 its enabled on my sentry project but dont send errors.

It's worked from https://github.com/FarazFe/sentry-telegram
Sentry sent an error to telegram when event is captured

It's worked from https://github.com/FarazFe/sentry-telegram Sentry sent an error to telegram when event is captured

Have Sentry 22.10.0. Same error. Test message works, but real errors are ignored. Could anyone fix it?

Seems for different sentry versions it is enough to just perform the following steps:
pip install sentry-telegram  (or any other updated pip package)
docker-compose restart web worker cron sentry-cleanup
For us, however, worked the "true" way of plugins installations and only then all alerts started working correctly: (not only the test notification)

place the archive of the plugin inside the requirements.txt file inside the sentry docker directory, e.g:
.../sentry/sentry/requirements.txt:
https://github.com/FarazFe/sentry-telegram/archive/refs/tags/0.5.0.zip

Advice taken from here.

Execute steps from official sentry docs and rebuild all containers in docker-compose:

"""
sentry/enhance-image.sh—To install plugins and their dependencies or make other modifications to the Sentry base image, copy sentry/enhance-image.example.sh to sentry/enhance-image.sh and add necessary steps there. For example, you can use apt-get to install dependencies and use pip to install plugins. After making modifications to sentry/enhance-image.sh, run ./install.sh again to apply them.
"""

Proceed with plugin configuration as stated inside this repo.
After that notifications should be sent correctly. Don't forget to use updated forks of the plugin depending on your sentry version.

Sentry version: Sentry 24.1.0.dev0
I try add this repo into file sentry/enhance-image.sh:
#!/bin/bash

pip install sentry-telegram-notification

And i was use Test Plugin in LEGACY INTEGRATIONS successfully, it sent my telegram channel. But when i create error 500 in backend, it didn't send notification to telegram channel, but sentry still receive this error.

I recommend using webhooks, because this plugin is not actively maintained.

Hello guys, I rewrite a new one plugin :)
tested on Sentry 24.2.0 & 24.3.0
https://github.com/tianci-sh/sentry-telegram


Observability Pack fetch workflow

Description
Adds a workflow and associated script to pull down and commit Observability Packs to the main branch.
I did not add any unit tests, since there is minimal logic to actually test. If anyone sees anything that's worth breaking out and testing please let me know.
Closes #1356

@zstix Sorry to request your review again! I addressed your comments and resolved any merge conflicts


Remove default policy

There is no need to create it anymore
This PR depends on #621 , only the last commit is relevant, the rest will be rebased away

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-27 of 65 (58.46%)  changed or added relevant lines in 4 files are covered.
18 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.6%) to 26.478%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/sriovoperatorconfig_controller.go
13
15
86.67%

controllers/helper.go
22
26
84.62%

pkg/daemon/daemon.go
0
4
0.0%

controllers/sriovnetworknodepolicy_controller.go
3
20
15.0%

Files with Coverage Reduction
New Missed Lines
%

controllers/sriovoperatorconfig_controller.go
1
59.66%

controllers/sriovibnetwork_controller.go
2
68.94%

controllers/sriovnetworknodepolicy_controller.go
2
21.51%

api/v1/helper.go
6
42.16%

controllers/helper.go
7
64.97%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
2970

Relevant Lines:
11217

💛  - Coveralls

Related to: #592


Add test for line anchor attributes with code fences

Fixes https://github.com/gohugoio/hugo/issues/9385.

I don't understand that failure. I will need help with this PR.
This is passing for me locally:
go test -v -run="TestConvertAttributes" ./...


RAPIDS + Dask-ML sample notebooks

getting this:
Exception: "TypeError('Implicit conversion to a host NumPy array via array is not allowed, To explicitly construct a GPU matrix, consider using .to_cupy()\nTo explicitly construct a host matrix, consider using .to_numpy().')"
after running cell: mode = "gpu-random" model_rf = RandomForestClassifier()
Any ideas?
mode = "gpu-random" with timed("XGB-" + mode):
& mode = "gpu-grid" with timed("XGB-" + mode):
works great.

Could you let us know which notebook you're having trouble with and which versions of RAPIDS you're running? Thanks :)

Ok great, I'm going to transfer this issue over to our deployment docs repo where that notebook lives.
We are about to do some testing of these notebooks ahead of the 23.12 release, so I'll ensure this one is high priority.


Dashboard can not access from remote host.

I tried that command and access from remote.
e.g. dashboard server IP is <IP_ADDRESS> and my local PC IP is <IP_ADDRESS>
optuna dashboard --storage "sqlite:///example.db" --study "example-study"

It can not be access to http://<IP_ADDRESS>:5006 from "<IP_ADDRESS>"
I got that error log .
[E 2018-12-06 15:10:05,468] Refusing websocket connection from Origin 'http://<IP_ADDRESS>:5006';                       use --allow-websocket-origin=<IP_ADDRESS>:5006 to permit this; currently we allow origins {'localhost:5006'}

However, we can not set that option, this PR fixed the problem.

@sile
I modified it, could you please you check this?

@sile
Thank you for reviewing.
I will wait for it.

@toshihikoyanase
I implemented test of dashboard with allow-websocket-origin.

@toshihikoyanase
I implemented test of dashboard with allow-websocket-origin.

It looks good to me. Thank you!
BTW, would you give me your opinion about the type hint serve()?

@toshihikoyanase Oops, I missed it, I fixed it!