Release notes for 1.23.x

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd3843663d78295bac0308--harness-developer.netlify.app

@krishi0408 I made some changes, please review them!

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd3d4d9b30732cb38fe137--harness-developer.netlify.app

@krishi0408 I added some suggestions to add Zendesk ticket reference numbers. We want to be sure we include these for all applicable RNs. Customers search release notes to see if their items are resolved in the release. Also, there were some items included that were not on the RN list for 1.23.x. Let me know if you have questions.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd63f492a9330ca4b4b3c5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd648265175a0ad0d50df9--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd65063dab330e56de93e7--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd682b0d204c0f43d2ac4a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd68680fe8110cd96d63d9--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd68b90d204c1005d2ad73--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bd6a843c6c5910e3c65658--harness-developer.netlify.app

@krishi0408 I added some suggestions to add Zendesk ticket reference numbers. We want to be sure we include these for all applicable RNs. Customers search release notes to see if their items are resolved in the release. Also, there were some items included that were not on the RN list for 1.23.x. Let me know if you have questions.

Thanks @brian-f-harness , I guess they might have changed to No after I made the PR. Thanks for headsup


🚀 Feature Request: Hyperdrive should have default ports for schemes (i.e 5432 for postgres)

Describe the solution

Good catch, yes. We should fix to avoid needing to specify it for Postgres and just default to 5432 in those cases.

Originally posted by @elithrar in https://github.com/cloudflare/cloudflare-docs/pull/10980#discussion_r1340579722

hi @elithrar , can your team take a look at this?

It looks like this was solved today by @a-robinson in https://github.com/cloudflare/workers-sdk/pull/4069


[Bug]: ol is one page behind

Bug Description
Hi! Amazing work on Shimmering, I'm wildly impressed :)
ol seems to be one note behind. Say I'm on File A and I run ol. But if I then open File B and run ol I get the links from File A.
I think it might have to do with active path not updating in .obsidian but I'm not sure.
function readFile (path, encoding) {
		if (!encoding) encoding = $.NSUTF8StringEncoding;
		const fm = $.NSFileManager.defaultManager;
		const data = fm.contentsAtPath(path);
		const str = $.NSString.alloc.initWithDataEncoding(data, encoding);
		return ObjC.unwrap(str);
	}

	const vaultPath = $.getenv("vault_path").replace(/^~/, app.pathTo("home folder"));
	const activeFile = JSON.parse(readFile(vaultPath + "/.obsidian/workspace"))
		.lastOpenFiles[0];

	return activeFile;

Relevant Screenshot
I'm currently on this page (as in, its open in Obsidian, being edited) but ol is looking at the last page (debugging log below)

To Reproduce
No response
Debugging Log
{"items":[{"title":"⬅ 🕑 2022-W29","match":"recent  2022 W29 2022-W29 ","subtitle":"▸ Weekly","type":"file:skipcheck","quicklookurl"...

Workflow Configuration

Version & System Information
-------------------------------
Metadata JSONs: 3/3
Metadata String Length: 4948599
-------------------------------
INSTALLED VERSION
macOS: 12.4
Alfred: 4.6.4

Obsidian: 0.15.6
This Workflow: 2.26.8
Advanced URI Plugin: 1.23.0
Metadata Extractor: 1.0.2
-------------------------------
LATEST VERSION
Obsidian: 0.15.6 (Insider: 0.15.6)
This Workflow: 2.26.8
Advanced URI Plugin: 1.23.0
Metadata Extractor: 1.0.2
-------------------------------

Make sure you have done the following

[X] I have updated to the latest version of this workflow.
[X] I have read the Troubleshooting Documentation.
[X] If the o... main search does not work, I have tried rerunning osetup and it still does not work.

yeah, it seems with the newer Obsidian versions, the workspace file only contains the last files opened, not the current file. I switched the method of retrieving the active file in the latest release, this should work now.


util/log: report log flushes and TLS rotations on the ops channels

PR: https://github.com/cockroachdb/cockroach/pull/59345
From release notes:

The notification that SIGHUP was received, and that log files are flushed to disk as a result, is now sent to the OPS logging channel. [#59345][#59345] {% comment %}doc{% endcomment %}

@mikeCRL, @taroface, not sure who this goes to.

I can take this as SIGHUP feels related to deployments.

Closed by #10273.


For dockstore write API prototype, create command-line client

Feature Request
Desired behaviour
Two utilities

input is a Dockerfile and CWL file(s), it will talk to the API and return the github repo, quay.io repo, and version numbers that were built (if successful)

client add  --Dockerfile Dockerfile --cwl-file Dockstore.cwl --cwl-secondary-file imported.cwl --version 2.0 > test.json

(last two parameters are optional)

Talk to Dockstore, do a refresh and publish the tools listed from the first utility

client publish --tool test.json

Configuration can store endpoint information (which write API are you talking to and which Dockstore instance)

I believe that this is complete


[Liniting] Updated to biome v1.9

Description
Ignored rules:

useSemanticElements: We have lots of cases where the native elements don't stack up to custom implementations. Some examples for changes they want: role combobox -> <select>, role status -> <output>. Best to ignore for now, but wold be a good idea in the future to do a collective walgrough and check if we can change some things.

Remaining changes are updates recommended by Biome, like not needed React.Fragments, duplicate border and border-color and unknown media queries
@HalvorHaugan Could you test the page https://aksel.nav.no/god-praksis/artikler/slik-gjor-du-en-lavterskel-brukertest-av-tekst with some different image sizes while toggling translateZ and image-rendering CSS on the <img> element? I notice not difference in image quality on Mac, but might be a chrome on windows only thing.

Component Checklist 📝

[x] JSDoc
[x] Examples
[x] Documentation
[x] Storybook
[x] Style mappings (@navikt/core/css/config/_mappings.js)
[x] Component tokens (@navikt/core/css/tokens.json)
[x] CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
[x] Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
[x] New component? CSS import (@navikt/core/css/index.css)
[x] Breaking change? Update migration guide. Consider codemod.
[x] Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: :sparkles: Add feature xyz.")

Could you test the page https://aksel.nav.no/god-praksis/artikler/slik-gjor-du-en-lavterskel-brukertest-av-tekst with some different image sizes while toggling translateZ and image-rendering CSS on the  element? I notice not difference in image quality on Mac, but might be a chrome on windows only thing.

Did not notice any difference on Windows, tested Chrome and FF. But image-rendering had an effect in Safari 18 (tested in BrowserStack). I think the images looks worse with this CSS property. There are probably some edge cases where some images would look better (examples), but afaics it's a bad idea to apply it to all images in general.

useSemanticElements: We have lots of cases where the native elements don't stack up to custom implementations. Some examples for changes they want: role combobox -> , role status -> . Best to ignore for now, but wold be a good idea in the future to do a collective walgrough and check if we can change some things.

Maybe create an issue for this, so that we don't forget?

Maybe create an issue for this, so that we don't forget?

https://github.com/navikt/team-aksel/issues/646


Support Samsung SmartSense Multi

Support the contact attribute of the slightly older Samsung SmartThings
range, "SmartSense Multi".

https://support.smartthings.com/hc/article_attachments/360001713846/SmartThings_Multipurpose_Sensor_1_Left_LQ.png

Thanks, if you could fix the linting issues I can merge this.


UnhandledPromiseRejectionWarning: Error: Page crashed!

Hello everyone,
I am trying to get this up and running. I modified the export.js file according to the file, that was pushed into Pull request (to make this program compatible with bbb 2.3), but I get this error. I am JS noob so maybe this is some easy to fix bug, but I am not able to figure it out. Thank you for any future help.
node export.js "https://bbb04.felk.cvut.cz/playback/presentation/2.3/0393a4ac2c9cab3db1483fbf3efc5d7af2398dd8-1621340701572?meetingId=0393a4ac2c9cab3db1483fbf3efc5d7af2398dd8-1621340701572" test.webm 100
(node:19775) UnhandledPromiseRejectionWarning: Error: Page crashed!
at Page._onTargetCrashed (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/lib/Page.js:213:24)
at CDPSession.Page.client.on.event (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/lib/Page.js:122:56)
at CDPSession.emit (events.js:198:13)
at CDPSession._onMessage (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/lib/Connection.js:200:12)
at Connection._onMessage (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/lib/Connection.js:112:17)
at WebSocketTransport._ws.addEventListener.event (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
at WebSocket.onMessage (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/node_modules/ws/lib/event-target.js:120:16)
at WebSocket.emit (events.js:198:13)
at Receiver.receiverOnMessage (/mnt/c/Users/kuntl/bbb-recorder/node_modules/puppeteer/node_modules/ws/lib/websocket.js:789:20)
at Receiver.emit (events.js:198:13)
(node:19775) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:19775) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Try latest version


0.10 Final Mac DMG is corrupt

I tried to download and install the 0.10 Final DMG but upon unpacking and attempting to run, OSX reports it is corrupt. The RC version runs without error.

OK. That's a Gatekeeper error, I must have messed up the gitian-specific signing process (it's kind of fiddly).
0.10.1 is about to come out any day now so I don't want to spend time fixing the OS X package for 0.10 Final, only to see it be immediately obsoleted. If the RC works please stick with that and I'll make sure to test the next build I do better to ensure the signatures are correct. Thanks!

I've released 0.10.1 - does that work better for you?


region: host list filter by cdrom_boot

这个 PR 实现什么功能/修复什么问题:
host 支持 cdrom_boot 过滤
是否需要 backport 到之前的 release 分支:

2.12
/cc @swordqiu
/area region

Codecov Report

Merging #3766 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3766      +/-   ##
=========================================
- Coverage    6.94%   6.93%   -0.01%
=========================================
  Files         499     499
  Lines       84217   84194      -23
=========================================
- Hits         5850    5840      -10
+ Misses      77871   77857      -14
- Partials      496     497       +1

Flag
Coverage Δ

#aFlag
6.93% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.34% <0%> (-0.01%)
:arrow_down:

pkg/compute/models/specs.go
0% <0%> (ø)
:arrow_up:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/compute/models/snapshotpolicy.go
2.26% <0%> (-1.52%)
:arrow_down:

pkg/compute/models/snapshotpolicycache.go
4.54% <0%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e281940...cee63c8. Read the comment docs.

/lgtm

/approve


Error：Tf has two or more unconnected trees

Hi,
when I run local_planner_realsense.launch, the terminal shows error below:
[ERROR] [1569999868.063794455]: ODOM: Ex: Could not find a connection between 'local_origin_ned' and 'fcu' because they are not part of the same tree.Tf has two or more unconnected trees.

That's not an avoidance issue but rather a MAVROS one. That's already fixed on MAVROS 0.33.0 release done yesterday, which should be available on the apt sources in the next weeks.

Thanks for reply！


doc: create/update README.mds for examples

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Added missing Readme
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Sorry if too many commits, wanted to finish while started. Some very useful examples were hidden without description.

Codecov Report

Merging #4980 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev    #4980      +/-   ##
=========================================
- Coverage   92.4%   92.36%   -0.05%
=========================================
  Files         74       74
  Lines       2449     2449
  Branches     603      603
=========================================
- Hits        2263     2262       -1
- Misses       166      167       +1
  Partials      20       20

Impacted Files
Coverage Δ

packages/vue-renderer/src/renderer.js
95.1% <0%> (-0.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac6d02...ef1b4a2. Read the comment docs.

Thanks for the effort 🙏

@manniL Thanks for a detailed review and corrections


Did Google play not accept my update because of this package?

I published the application on google play, but then I updated it. The only library I have added as new in this update is the flutter device_info library. Google Play did not accept the updates I posted. I don't understand why. Could it be from the device_info library. Are any permissions required when using the device_info library? The only information I get with the device_info library is the phone brand.The ads in the application are google ads. No ads were received from elsewhere.The mail sent to me;

The package I use: https://pub.dev/packages/device_info

Hi @StatTark
This clearly is not related to the package mentioned. Maybe you are using the information retrieved by the package wrong in one of your Ads implementation?
The rejection is about Google Ads and the way you are using/showing them and not about obtaining the device information.
Closing as this is not an issue with Flutter itself.
Thank you


Prevent hash responses

Reverts the change made to accommodate hash responses as this will not work
with the Attachable trait in govuk_content_models. The upgrade path here is
impractical despite the fix being relatively simple.
Adds GdsApi.config.hash_response_for_requests = false to workaround this problem.

What's the problem with attachable? The plan is to remove the ostruct behaviour entirely so curious to see.

https://github.com/alphagov/govuk_content_models/blob/master/app/traits/attachable.rb#L65 doesn't expect a hash response.
Simple enough to fix until an older codebase like this needs to be updated several major versions of content models, gds-sso dependencies, mongoid major version bumps etc etc, given there's a bright new future for manuals on the horizon this is the practical route to unblocking this https://github.com/alphagov/manuals-publisher/pull/755 which gets rid of a few hexagons.


feat(rule): add image-has-accessible-rule (moved from experimental)

Additional notes
I chose suggest because it is strict to make this a mandatory rule.
For Android, if there is accessibilityLabel, it will be read aloud, so I added an option to not force the presence or absence of accessible.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


./make.sh produces object files of all sources, but g++ ClassSha2.o VirusAnalysis.o has duplicate/undefined functions

~/SubStack $ g++ *.o
ld.lld: error: duplicate symbol: Susuwu::Sha2
>>> defined at ClassSha2.cxx
>>> ClassSha2.o:(Susuwu::Sha2)
>>> defined at VirusAnalysis.cxx
>>> VirusAnalysis.o:(.data+0x0)

ld.lld: error: duplicate symbol: Susuwu::Sha2
>>> defined at ClassSha2.cxx
>>> ClassSha2.o:(Susuwu::Sha2)
>>> defined at ConversationCns.cxx
>>> ConversationCns.o:(.data+0x0)
g++: error: linker command failed with exit code 1 (use -v to see invocation)

ld.lld: error: undefined symbol: main
>>> referenced by crtbegin.c
>>> /data/data/com.termux/files/usr/lib/crtbegin_dynamic.o:(_start_main)
>>> referenced by crtbegin.c
>>> /data/data/com.termux/files/usr/lib/crtbegin_dynamic.o:(_start_main)
~/SubStack $ g++ ClassSha2.o VirusAnalysis.o
ld.lld: error: undefined symbol: Susuwu::Sha2(std::__ndk1::basic_string , std::__ndk1::allocator > const&)
>>> referenced by ClassResultList.cxx
>>> ./cxx/..//ClassResultList.o:(Susuwu::resultListHashesHas(Susuwu::ResultList const&, Susuwu::ResultList&, std::__ndk1::basic_string , std::__ndk1::allocator > const&))
>>> referenced by VirusAnalysis.cxx
>>> ./cxx/..//VirusAnalysis.o:(Susuwu::virusAnalysis(Susuwu::PortableExecutable const&))
>>> referenced by ConversationCns.cxx
>>> ./cxx/..//ConversationCns.o:(Susuwu::questionsResponsesFromXhtml(Susuwu::ResultList&, Susuwu::ResultList&, std::__ndk1::basic_string , std::__ndk1::allocator > const&))
>>> referenced 2 more times
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Hate to rebase, but have a milestone commit which promises that all of this compiles, thus must git blame to locate origins of these errors, and rebase to fix this.
Other than to fix errors which break build, will not do rebases.
This is required to allow to checkout and build all commits since the promise that this compiles.

Once you git pull --rebase
, the last 12 commits should compile; if you have clang++ or g++, just run ./make.sh
For other compilers, you can base the build scripts off of make.sh (which is simple and small).

Welcome to Termux!
~/Substack $ git pull
remote: Enumerating objects: 254, done.
remote: Counting objects: 100% (254/254), done.
remote: Compressing objects: 100% (96/96), done.
remote: Total 254 (delta 169), reused 238 (delta 157), pack-reused 0
Receiving objects: 100% (254/254), 118.80 KiB | 100.00 KiB/s, done.
Resolving deltas: 100% (169/169), done.
From github.com:SwuduSusuwu/SubStack
 + 00ccd9c...cf4b178 trunk      -> origin/trunk  (forced update)
hint: You have divergent branches and need to specify how to reconcile them.
hint: You can do so by running one of the following commands sometime before
hint: your next pull:
hint:
hint:   git config pull.rebase false  # merge
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
fatal: Need to specify how to reconcile divergent branches.
~/Substack $ git pull --rebase
Successfully rebased and updated refs/heads/trunk.
~/Substack $ git lol
* cf4b178 (HEAD -> trunk, origin/trunk, origin/HEAD) @cxx/ClassResultList.cxx maxOfSizes -> listMaxSize
* 40d3d17 @cxx/ClassResultList.hxx +`listOfSubstrHasMatch()`
* b21d2a8 `listFind -> listFindValue/listFindSubstr``listHas
* bde5f91 @cxx/ClassResultList.hxx @`smallestUniqueSubstr()`
* 9329602 @cxx/Macros.hxx +`NOEXCEPT` +`NORETURN`
* 7755ce9 @cxx/ClassResultList.hxx `decltype()`->`typename`
* b11a597 @cxx/ClassPortableExecutable Redo typedefs to this
* 66f4b0c @cxx/*.hxx `global -> static global` +cxx/main.cxx
* 7dd27e0 @cxx/ClassSha2.cxx Use `c/rfc6234/sha.h` to hash.
* 603afa8 @cxx/*.cxx Reduce comments @README.md "Docu...
* 8c56b7b @README.md Contracts +cxx/Macros.hxx Miscellaneous
* 49c5654 +posts/CnsCompress.md compresses 2000x (vs x264)
* 762de36 `posts/*.txt` -> `posts/*.md`, for web browsers
* 15bc69c +c/rfc6234/{hkdf,hmac,sha1,sha224-256,sha384-512,
* a6f7632 @cxx/VirusAnalysis.* Compute straceDump intersects
* 7c32439 @cxx/VirusAnalysis.* std::vector<VirusAnalysisFun>
* 3048c53 @cxx/* Various syntax fixes, +required functions
* 8a2fbbc @c++/*.c++ -> cxx/*.cxx, @c++/*.hpp -> cxx/*.hxx,
* e1d4d7b @c++/ClassCns.c++ Documentation of HSOM & apxr_run
* 846d5aa +/c/ For those who can't include C++
* 3b0dfd3 @c++/ClassCns.hpp +cnsModeBool +cnsModeVectorBool
* 7979e66 @c++/ClassCns* Fixes. Partial implementations.
* c7b23aa @c++/* Licenses at top of all sources ("Apache 2"/
* d817312 +README.md (licenses, purposes, conventions,
* b09ea61 +LICENSE (Apache 2.0, allows all uses)
* f9bd5dc +FUNDING.yml " https://www.deviantart.com/swudususuwu#donation_pool "
* 51d6b60 @c++/* Whitespace fixes (trailing whitespace=tabs)
* e177a86 `c++/*.h -> c++/*.hpp`, fixes "g++: warning: ...
* ddd31e9 @c++/* Syntax fixes, "#include" fixes
~/Substack $

To use git bisect, previous commits must compile to executables.


HTTP2 (thanks to switch from requests to httpx)

Codecov Report

Merging #392 (ece59a9) into main (64c4fed) will decrease coverage by 0.73%.
The diff coverage is 55.17%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   81.52%   80.78%   -0.74%
==========================================
  Files          62       62
  Lines        2381     2389       +8
==========================================
- Hits         1941     1930      -11
- Misses        440      459      +19

Impacted Files
Coverage Δ

gitlabform/core.py
60.00% <9.09%> (-6.24%)
:arrow_down:

gitlabform/gitlab/core.py
90.97% <83.33%> (-2.92%)
:arrow_down:

gitlabform/processors/util/branch_protector.py
73.50% <0.00%> (-1.71%)
:arrow_down:

...tlabform/processors/multiple_entities_processor.py
94.28% <0.00%> (-1.43%)
:arrow_down:

I expected that for this use case switching from HTTP1 to HTTP2 might not give performance improvements but I was hoping that I was wrong and that's where this PR comes from.
Unfortunately I was not wrong and the real-life performance for Egnyte's 1001 repos in 5 groups managed with this app the processing time with HTTP2 is practically the same as for HTTP1.
But it was still an interesting experiment that made me learn that:

switching from requests to httpx is very easy,
...but there are some things that httpx doesn't have built-in, in particular retries - it's not a blocker, you can use f.e. tenacity to implement it on your own, but it requires some extra work.


fix getting remote IP address on proxy

Fix problem with getting IP in environment behind proxy.
See http://stackoverflow.com/questions/4581789/how-do-i-get-user-ip-address-in-django

Sorry, this change is insecure. It allows anyone to insert an X-Forwarded-For header into the HTTP request, and spoof the IP this way. The only systems which are protected this way, are sites that are already behind a proxy.
Since many other packages are also affected by the REMOTE_ADDR/X_FORWARDED_FOR difference (e.g. sentry/raven), I recommend using the https://pypi.python.org/pypi/WsgiUnproxy middleware instead. This solves the issue in a secure way, consistently for all your packages.


When importing csv file line breaks are lost

Hello!
In the prepared jiraone csv files there are all line breaks (in fields such as Description).
But when loading the file into a new jira, the line breaks are lost and the field becomes single-line. Because of this, the formatting is lost.
I would like to know if this is possibly affected by some settings when preparing the export file in jiraone or something else?
Thanks!
If I manually return all line breaks, then the formatting returns. But this is very labor-intensive if there are thousands of tasks.

Are you importing between a Jira DC and Jira Cloud? One of the issues I'm aware of that would cause this, is the difference between Markup and Markdown. I believe DC uses a variant of Markup while Cloud uses Markdown but I would require additional context here about the type of Jira environment to expand on that issue.

Import from Jira Server 8 to Jira Data Center 10.
In both versions, the formatting of descriptions and comments is exactly the same (I think, Markup).
But the problem is definitely not in the markup.
Below is a simple example, without using Markup, only simple text with line breaks.
I noticed that not only line breaks are lost, but also tabs and multiple spaces.
Perhaps some kind of CDATA analogue is needed for such fields in the csv file?

I wanted to add - I analyzed my old json import files, with which the problem did not occur.
There, "\n" is used as a line break.
Below is an example:
            {
                "summary": "Bug with code",
                "issueType": "Bug",
                "comments": [],
                "attachments": [],
                "created": "2023-01-27T19:33:39.000+0300",
                "description": "Line1\nLine 2\nLine 2\nLine 4\n",
                "reporter": "user.name",
                "assignee": "user.name",
                "priority": "High",
                "updated": "2023-01-27T19:33:54.000+0300",
                "key": "TEST-982",
                "status": "In Progress"
            },

@princenyeche  I've tested both workaround and can confirm that the first option works:

don't hit 'Map Value'. Newlines import fine if you do not select 'Map Value' for that field.

But there is one problem. This only works if there are no extra line breaks in the csv file.
Now in csv jiraone adds additional line break after each line. If I delete them manually, everything is imported perfectly:

Is it possible to export csv with jiraone without extra line breaks?
This solves the problem completely.

@princenyeche
I finally found the reason - an extra CR is added during export
Perhaps this can be resolved by the export configuration?

@princenyeche
I was able to fix this by editing the code in reporting.py

As described here:

The official csv documentation recommends opening the file with newline='' on all platforms to disable universal newlines translation

@kalupator The script actually has this solved by default. SLOC 7897 - 7904 is the condition that is used (as shown in your image). So there was no actual need to edit the code and add additional conditions, as that would cause more problems when performing attachment transfers. You have to look into how you call the arguments for the extraction you're performing which triggers the extra CRs on window devices.

@princenyeche

You have to look into how you call the arguments for the extraction you're performing which triggers the extra CRs on window devices.

Can you clarify what arguments you are talking about?
My code is extremely simple:
from jiraone import LOGIN, issue_export
import json

file = "config-jira.json"
config = json.load(open(file))
LOGIN.api = False
LOGIN(**config)
jql = "project in (TEST) order by created ASC"
issue_export(jql=jql, extension="csv", allow_media=True)

But additional CRs still appear (they disappeared only after adding the line highlighted in red on my screenshot).

Hmm, that's strange as you should only get to that point in the code if your system is not Windows and you want to open a non-text file.
This portion of the code
else open(
            file,
            mode,
            encoding=encoding,
            errors=errors,
        )

Should only be reached if you are not on Windows or if you're on Windows and the mode argument is file. Your script is basic enough, so probably did you modify the file_writer mark value in the export_issues function to set the mark = file?

@princenyeche
I output the values of the variables (system and mark) and got the following result:
Defaulting to comma as CSV separator.
Downloading issue export in CSV format.
<Response [200]>  ::downloading issues at page: 0 of 0
system = Windows
mark = file
system = Windows
mark = many
Processing. Current progress: 100%
Reconstructing file headers
system = Windows
mark = many
Applying updated data into the CSV file
system = Windows
mark = many
Export Completed.File located at c:\temp\jira_imp\jira4-py\EXPORT\final_file.csv
The default CSV separator is a comma for the delimit argument, no action taken.

I didn't quite understand what exactly I could have changed? I didn't correct the source code in any other way.

That first one from line is expected, so you shouldn't be changing that. It doesn't affect how the file should work because the content being received is actually in bytes. I think for most of it, the export based on the output you've shown did you still get the CRs added or was it not there?
If it's still there based on current ver 0.8.6 can you try something, can you change this line at your end for mode = "wb+" leave mark = "file" and let me know if its works and removes any CRs

@princenyeche
When setting the mode = "wb+", an error occurs:
Traceback (most recent call last):
  File "C:\temp\jira_imp\jira4-py\script-jira4.py", line 12, in <module>
    issue_export(jql=jql, extension="csv", allow_media=True)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python\Python313\Lib\site-packages\jiraone\reporting.py", line 4093, in export_issues
    download_csv() if not merge_files else config.update(
    ~~~~~~~~~~~~^^
  File "C:\Program Files\Python\Python313\Lib\site-packages\jiraone\reporting.py", line 4076, in download_csv
    file_writer(
    ~~~~~~~~~~~^
        folder,
        ^^^^^^^
    ...<6 lines>...
        mode="wb+",
        ^^^^^^^^^^^
    )
    ^
  File "C:\Program Files\Python\Python313\Lib\site-packages\jiraone\reporting.py", line 7917, in file_writer
    else open(
         ~~~~^
        file,
        ^^^^^
    ...<2 lines>...
        errors=errors,
        ^^^^^^^^^^^^^^
    )
    ^
ValueError: binary mode doesn't take an encoding argument

That validates that's not the issue. This is the closest similarity I've seen about this issue JRACLOUD-67140. For the most part, most people who use jiraone and on Windows haven't brought up this problem, so I'm guessing this is that edge occurrence. The workaround which you used shouldn't be the case though as what it does is remove the \r lines which by default it should do for Windows devices as it rewrites the entire cells into a new file. Maybe it could be a localized issue, have you tried on different Windows devices to see if the same problem occurs?

But am I right in thinking that I shouldn't be in this block of code?
https://github.com/princenyeche/jiraone/blob/main/src/jiraone/reporting.py#L7914C1-L7919C10
But for some reason it is executed (that's why adding newline="" in this block helps me).

The problem here is that it's defaulting to that line when using mark = file which means the CR is added there in the first instance of the file when it is extracted from Jira (that is expected). Afterwards, mark is != file again.
<Response [200]>  ::downloading issues at page: 0 of 0
system = Windows
mark = file

This brings me to the second factor, which is the constant rewrites that are happening, if CR is added at the first instance when the file is created, this should have been resolved midflight during rewrites which don't happen in your case whereas other Windows user it works. While adding that line helps you, it might cause other issues which is unknown to me. Anyway, if it works for you then I have no complaints.

I'm already interested in getting to the bottom of the truth.
What's interesting is that if I open the file in a standard Windows notepad and just save file (ctrl+s), all the extra CRs disappear.


Implement Job Service based master stress tools

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9357/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9358/
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9361/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9368/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9412/
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9470/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9511/
Test FAILed.

Jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9512/
Test FAILed.

alluxio-bot, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9514/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9516/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9517/
Test PASSed.

LGTM

alluxio-bot, merge this please


Cannot import NLTK

After a Python 3.4 upgrade:
ppp@Hydrogen:~$ python3
Python 3.4.2 (default, Nov 13 2014, 07:01:52)
[GCC 4.9.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import nltk
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/__init__.py", line 117, in <module>
    from nltk.align import *
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/align/__init__.py", line 15, in <module>
    from nltk.align.ibm1 import IBMModel1
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/align/ibm1.py", line 18, in <module>
    from nltk.corpus import comtrans
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/corpus/__init__.py", line 64, in <module>
    from nltk.tokenize import RegexpTokenizer
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/tokenize/__init__.py", line 65, in <module>
    from nltk.tokenize.regexp   import (RegexpTokenizer, WhitespaceTokenizer,
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/tokenize/regexp.py", line 201, in <module>
    blankline_tokenize = BlanklineTokenizer().tokenize
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/tokenize/regexp.py", line 172, in __init__
    RegexpTokenizer.__init__(self, r'\s*\n\s*\n\s*', gaps=True)
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/tokenize/regexp.py", line 119, in __init__
    self._regexp = compile_regexp_to_noncapturing(pattern, flags)
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/internals.py", line 54, in compile_regexp_to_noncapturing
    return sre_compile.compile(convert_regexp_to_noncapturing_parsed(sre_parse.parse(pattern)), flags=flags)
  File "/home/ppp/.local/lib/python3.4/site-packages/nltk/internals.py", line 50, in convert_regexp_to_noncapturing_parsed
    parsed_pattern.pattern.groups = 1
AttributeError: can't set attribute

Got in on 3.5.0

This repros again on python 3.5.0
@stevenbird, would you like me to open a new issue on this, or reactivate this one?
File "/server/utils/cache.py", line 3, in
from nltk.tokenize import sent_tokenize
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/init.py", line 117, in
from nltk.align import *
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/align/init.py", line 15, in
from nltk.align.ibm1 import IBMModel1
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/align/ibm1.py", line 18, in
from nltk.corpus import comtrans
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/corpus/init.py", line 64, in
from nltk.tokenize import RegexpTokenizer
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/tokenize/init.py", line 65, in
from nltk.tokenize.regexp   import (RegexpTokenizer, WhitespaceTokenizer,
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/tokenize/regexp.py", line 201, in
blankline_tokenize = BlanklineTokenizer().tokenize
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/tokenize/regexp.py", line 172, in init
RegexpTokenizer.init(self, r'\s*\n\s*\n\s*', gaps=True)
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/tokenize/regexp.py", line 119, in init
self._regexp = compile_regexp_to_noncapturing(pattern, flags)
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/internals.py", line 54, in compile_regexp_to_noncapturing
return sre_compile.compile(convert_regexp_to_noncapturing_parsed(sre_parse.parse(pattern)), flags=flags)
File "/opt/envs/worker/lib/python3.5/site-packages/nltk/internals.py", line 50, in convert_regexp_to_noncapturing_parsed
parsed_pattern.pattern.groups = 1

The 3.5.0 source has group set via a property. An ideal fix here would not muck around with the guts of the pattern object. I will take a quick look.
   self.subpatterns = [None]  # group 0
        self.lookbehindgroups = None
    @property
    def groups(self):
        return len(self.subpatterns)

Sorry, I see this is referenced in https://github.com/nltk/nltk/issues/1106 for python 3.5


Included Admin.SpecialLevels in blacklist

This also loads and overrides admin levels

Not something that should load from the datastore, one less entry point for malicious users to give themselves admin


Update README.md

client.on('message', message => {
if (message.content === '/private') {
message.author.send('HOLA, soy CryptoBot, en que puedo ayudarte?');
}
});

I don't think I understand your suggestion, you can already interact with the bot privately via private message. You just have to open a conversation with the bot.


Update Config “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for benevolent-pika-f5fbe0 processing.

Name
Link

🔨 Latest commit
c06cf3d271a3a49036205e6753fdbad39ce0e8d8

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-pika-f5fbe0/deploys/62e2dfe304880d0008ff2b36


Application will not start even with HOME variable set

From @a1g3 on June 14, 2018 1:30
Steps to reproduce
I am aware that this issue has been seen before, but I have my home directory set to the correct location. Whenever I try to run my application(via dotnet [Path to Application]), it will not start and I receive the error below. I ran echo $HOME and it gives me the correct location /home/ubuntu.
Expected  behavior
The application should run.
Actual behavior
Application startup exception: System.ArgumentNullException: Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2)
   at Vulnerabilities.io.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env) in /home/ubuntu/test/Vulnerabilities.io/Vulnerabilities.io/Startup.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
crit: Microsoft.AspNetCore.Hosting.Internal.WebHost[6]
      Application startup exception
System.ArgumentNullException: Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2)
   at Vulnerabilities.io.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env) in /home/ubuntu/test/Vulnerabilities.io/Vulnerabilities.io/Startup.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()

Unhandled Exception: System.ArgumentNullException: Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2)
   at Vulnerabilities.io.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env) in /home/ubuntu/test/Vulnerabilities.io/Vulnerabilities.io/Startup.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.StartAsync(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token, String shutdownMessage)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)
   at Vulnerabilities.io.Program.Main(String[] args) in /home/ubuntu/test/Vulnerabilities.io/Vulnerabilities.io/Program.cs:line 11
Aborted (core dumped)

Environment data
dotnet --info output:
 OS Name:     ubuntu
 OS Version:  18.04
 OS Platform: Linux
 RID:         ubuntu.18.04-x64
 Base Path:   /usr/share/dotnet/sdk/2.1.300/

Host (useful for support):
  Version: 2.1.0
  Commit:  caa7b7e2ba

.NET Core SDKs installed:
  2.1.300 [/usr/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Copied from original issue: dotnet/cli#9487

That stack trace is in your own startup code. What are you doing there?

This was due to incorrect file permissions. Thank you for your help!

This can be closed


"Added" column on problems page

As I user, I'd like to be able to see when problems were added on the problems page so I can see the newest problems that have been added.

Do you still want this? I can make this happen in a snap.

I don't see any reason to limit it to logged-in users


Mark js-sys as optional for identity_core

Description of change
In #1397 my intention was to make the js-sys dependency mutually exclusive with the feature custom_time. As it turns out, it's not that simple and mixing target specific dependencies with feature specific dependencies does not actually work. See here and here.
So this removes the broken feature reference in the dependency declaration and instead marks it as optional. Also, the feature custom_time takes precedence over js-sys so these do not actually conflict and one could enable both.
Type of change
Add an x to the boxes that are relevant to your changes.

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] Enhancement (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Fix

How the change has been tested
Existing tests
Change checklist
Add an x to the boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@itsyaasir: Sorry to bother you again, but I made a mistake in #1397 and this PR fixes it.

@itsyaasir: Yes, the optional is required, otherwise you cannot compile to wasm32-unknown-unknwon without it (breaking compatibility with the ICP platform).
But we should be able to enable it by default (still gated by the target). Would that be an option?

@itsyaasir: I made it a default feature.

@itsyaasir: Yes, my bad. I got confused about the default switches. Fixed now.


Set ExperimentalFeatures.enableModelExperimental to true

in preparation for #10346, we wanted to enable ModelExperimental by default early in the month so there's time to catch any bugs we may have missed.
That said, there are a few known issues (see #10346) so in a few sandcastles we explicitly set the flag to false:

BIM model that needs to be updated to not use techniques:

Apps/Sandcastle/gallery/3D Tiles BIM.html
Apps/Sandcastle/gallery/3D Tiles Clipping Planes.html
Apps/Sandcastle/gallery/Ambient Occlusion.html
Apps/Sandcastle/gallery/MSAA.html
Apps/Sandcastle/gallery/Polylines on 3D Tiles.html

getNode needs to be implemented:

Apps/Sandcastle/gallery/CZML Model - Node Transformations.html
Apps/Sandcastle/gallery/Time Dynamic Wheels.html

Point cloud styling is not yet supported

Apps/Sandcastle/gallery/3D Tiles Point Cloud Styling.html
Apps/Sandcastle/gallery/Montreal Point Cloud.html

Classification model needs to be updated to use GltfLoader

Apps/Sandcastle/gallery/3D Tiles Photogrammetry * Classification.html

All other 3D Tiles sandcastles should work fine.
@j9liu could you review?

Thanks for the pull request @ptrgags!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Today we're looking into the test failures. Some of them are due to test code that is only used for the old Model and will be removed soon, so in some cases setting the flag to false is the simplest way to address them.

[x] ModelVisualizer

Action: Disable ModelExperimental since getNode() is not implemented (@j9liu will be implementing this soon)
getNode() not defined
Computes bounding sphere (cannot set properties of loadfail)

[ ] B3dmParser

Action: Investigate
expected undefined to be defined

[ ] Batched3DModel3DTileContent

Action: Disable ModelExperimental since this is the old Model?

[ ] Cesium3DTileBatchTable

Action: Investigate
batch table hierarchy not working correctly
byte lengths not the same

[ ] Cesium3DTileset

Action: Evaluate on case-by-case basis
animates instance gives same matrix
animates batched tileset gives same matrix
statistics not the same
debugColorizeTiles renders wrong color
apply style renders wrong color
backface commands not the same

[ ] Implicit3DTileContent

Action: investigate
multiple contents instead of b3dm content?

[x] Instanced3DModel3DTileContent

Action: Disable ModelExperimental

[x] PointCloud3DTileContent

Action: Disable ModelExperimental

To fix some of the tests in Cesium3DTileset without skipping them entirely, I opened #10532

One of the unit tests requires a longer fix, so I opened #10535 to handle it later

I opened #10536  for the two statistics-related tests in Cesium3DTilesetSpec, we'll visit it later

@ptrgags and I cross-checked each other's changes, and Travis is finally passing, so I'll go ahead and merge. Thanks @ptrgags !


Add artifact metadata for pom (name, url, description)

Artifacts can have tons of metadata in their pom files. Not all of them have to be supported by this project but supporting the most common ones would be great!
javaArtifact {
    artifactId = 'gitversioner'
    license {
        name = 'The Apache License, Version 2.0'
        url = 'http://www.apache.org/licenses/LICENSE-2.0.txt'
    }

    // new properties
    name = "Git Versioner gradle plugin"
    description = "Create versions based on the git history"
    url = "https://github.com/passsy/gradle-gitVersioner-plugin"
}

Alternatively on could forward the MavenPom object to users and they can call even more methods on it.

Closed in favor of the better solution #67


chore: bootstrap releases for path: .

Configuring release-please for path: .

This was done manually.


[ENH] enable default get_fitted_params for forecasters and delegated estimators

This PR enables a default implementation of get_fitted_params for forecasters and delegated estimators:

for forecasting, BaseForecaster accidentally overrode the recently introduced default implementation of get_fitted_params. The abstract method has been removed from BaseForecaster now, which should enable the default in all forecasters. (all other estimator types were unaffected)
for delegators, _get_fitted_params now delegates to the delegate's get_fitted_params, in line with all other delegation defaults.

Also see https://github.com/alan-turing-institute/sktime/issues/1497.
This should solve #1497 for all compositors that are delegates.

Note to self: works, but the BaseForecaster override masked a bug where vectorization and the default interact.
In case of vectorization, components may remain uninitialized/unfitted, and the vectorized components do not get returned via get_fitted_params.


instructions on how to build and run this?

I am not familiar on how to build and run an ncurses programme.  Can you provide help in the readme?

i need it too

if using ubuntu:
sudo apt-get install libncurses5-dev
sudo apt install cmake-curses-gui
go to downloaded directory and type
ccmake CMakeLists.txt
then press [c] and the [g]
then type make

thanks @luizhdinizf that worked for me.


Left join colums not reset

https://github.com/zendframework/zend-db/blob/748f065ab8e64ab66213182a671513e9499957bc/src/Sql/Select.php#L426

case self::COLUMNS:
    $this->columns = array();
    foreach ($this->joins as &$join){
        $join['columns'] = [];
    }
break;

@hemengze
The entire joins property is reset:
https://github.com/zendframework/zend-db/blob/748f065ab8e64ab66213182a671513e9499957bc/src/Sql/Select.php#L428-L430

when work with paginator, sql like this:
select count(*), b.id, b.created_at from A as a inner join B as b on A.bid = b.id limit 1;

@hemengze

when work with paginator, sql like this:

Sorry, I don't understand. Please describe your problem with full sentence. This will help.
Thanks!
Maybe you mean this cloning:
https://github.com/zendframework/zend-paginator/blob/master/src/Adapter/DbSelect.php#L142-L145

@froschdesign thank you.
When I'm join a table with columns, reset the columns, the join columns still exists
$select = (new (Select))->join('B b', 'a.bid = b.id', 'id, created_at');
$select->reset(Select::COLUMNS);
$select->reset(Select::LIMIT);
$select->reset(Select::OFFSET);
$select->reset(Select::ORDER);

the columns  b.id, b.created_at already exists

In select::reset() i see no code for key Select::COLUMNS.
I guess for now there is no functionality to reset columns;

I think that now $select->reset(Select::COLUMNS); is resetting only columns for from table and that makes sense.
May be add additional Select::JOIN_COLUMNS and add functionality to reset columns in join tables.
That will help to resolve that problem.
For now you can only reset whole Select::JOINS.

can something like this solve this problem?
public static function getCountSelect(Select $originalSelect, $fieldCountCriteria="id" )
{
$select = clone $originalSelect;
$select->reset(Select::COLUMNS);
$select->reset(Select::LIMIT);
$select->reset(Select::OFFSET);
$select->reset(Select::ORDER);
/** @var Join $joins */
$joins = $select->joins->getJoins();
	$select->reset(Select::JOINS);
	foreach ($joins as $key => $join) {
		//re add join without cols
		$type = $join["type"];
		$select->join($join["name"], $join["on"], [], $type);
	}

	$select->columns(["total" => new Expression("count(distinct($fieldCountCriteria))")]);

	return $select;
}

It will re-init the joins without any column set.
It seems working for my situation... try at your own risk :smiley:


feat(plugin-history-sync): add history queue context

URL navigations not managed in history sync plugin can be ignored when those are executed right after the stackflow actions.
This PR provides a solution about the issue by exposing enqueue function as a hook so that navigations could be inserted into the queue together.

enqueue function cannot be exported as a module since history object is not determined at the module load.
But renaming the function enqueue into requestHistoryTick seems like a great idea 👍


WIP - do not merge - MACRO py test

hi folks, I'm trying to do an open PR clean up. what's the status of this one? should it stay open?

Closing in favor of #223


Disable testMetrics test case

Purpose
$subject
https://github.com/ballerina-platform/ballerina-lang/issues/18372 is created to track this.
Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18368 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18368   +/-   ##
=======================================
  Coverage   14.86%   14.86%
=======================================
  Files          48       48
  Lines        1265     1265
  Branches      201      201
=======================================
  Hits          188      188
  Misses       1063     1063
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f60b73...e2a38b4. Read the comment docs.


encounter error

Hi, thank you so much for your code. But it encounter some error when implemented on my terminal. here is the error description follows
  File "E:/Detection/swin/swin_transformer.py", line 117, in forward     dots += self.pos_embedding[self.relative_indices[:, :, 0], self.relative_indices[:, :, 1]] IndexError: tensors used as indices must be long, byte or bool tensors
Your response will be highly apprecitaed.

Hi, this error has already occured for some in the past #7 #2 , I asumme it occurs for certain numpy/torch versions but you can fix it by replacing the line by [self.relative_indices[:, :, 0].type(torch.long), self.relative_indices[:, :, 1].type(torch.long)].

Nice , solve my problem.hhh


Microsoft.Midi.GmDls does not support ARM64

The title says it all. Compiling to target ARM64 results in the following error message:
error MSB3779: The processor architecture of the project being built "ARM64" is not supported by the referenced SDK "Microsoft.Midi.GmDls, Version=10.0.17134.0".

Um, the sample doesn't support ARM64 as a target. I'm assuming you modified the sample and added ARM64? Well, that's not really an issue with the sample any more. You modified it to add something that it doesn't support.


:6:30: warning: missing terminating '"' character [-Winvalid-pp-token]

Hi, I'm the maintainer of MyPaint in MacPorts, finally getting around to updating to version 2.
When I build MyPaint 2.0.1 with mypaint-brushes 2.0.2 installed, I get lots of warnings like this:
In file included from <built-in>:371:
<command line>:6:30: warning: missing terminating '"' character [-Winvalid-pp-token]
#define MYPAINT_BRUSHES_DIR \"/opt/local/share/mypaint-data/2.0/brushes\"
                             ^

I think this is happening because pkgconfig.pc.in contains this line:
Cflags: -DMYPAINT_BRUSHES_DIR="\"${brushesdir}\""

which causes pkg-config to print the following output:
$ pkg-config --cflags mypaint-brushes-2.0
-DMYPAINT_BRUSHES_DIR=\"/opt/local/share/mypaint-data/2.0/brushes\"

Why is pkgconfig.pc.in programmed to do this? Why not:
Cflags: -DMYPAINT_BRUSHES_DIR="${brushesdir}"

Then pkg-config has much more sensible output:
$ pkg-config --cflags mypaint-brushes-2.0
-DMYPAINT_BRUSHES_DIR=/opt/local/share/mypaint-data/2.0/brushes

When I make that change the warnings go away and MyPaint still builds fine. It seems logical to me that MYPAINT_BRUSHES_DIR should be set to the path to the brushes directory and that that value should not have enclosing quotation marks and certainly should not have backslashes before those quotation marks.
But GIMP also uses mypaint-brushes (still version 1 at this time) and if I make the above change then GIMP fails to build because it is expecting the value to be quoted. In my opinion that's a mistake in GIMP that should be fixed in GIMP by quoting the value using preprocessor macros when needed. They already define a QUOTE macro elsewhere to do this. The following patch to GIMP works for me:
--- app/config/gimpcoreconfig.c.orig	2020-06-02 22:16:25.000000000 -0500
+++ app/config/gimpcoreconfig.c	2020-06-02 22:16:26.000000000 -0500
@@ -51,6 +51,9 @@
 #include "gimp-intl.h"

+#define _QUOTE(x) #x
+#define QUOTE(x) _QUOTE(x)
+
 #define GIMP_DEFAULT_BRUSH         "2. Hardness 050"
 #define GIMP_DEFAULT_DYNAMICS      "Dynamics Off"
 #define GIMP_DEFAULT_PATTERN       "Pine"
@@ -314,7 +317,7 @@
                                       "share", "mypaint-data",
                                       "1.0", "brushes", NULL);
 #else
-  mypaint_brushes = g_strdup (MYPAINT_BRUSHES_DIR);
+  mypaint_brushes = g_strdup (QUOTE(MYPAINT_BRUSHES_DIR));
 #endif

   path = g_build_path (G_SEARCHPATH_SEPARATOR_S,
--- app/core/gimpdata.c.orig	2020-02-23 12:21:08.000000000 -0600
+++ app/core/gimpdata.c	2020-06-02 21:38:28.000000000 -0500
@@ -36,6 +36,9 @@
 #include "gimp-intl.h"

+#define _QUOTE(x) #x
+#define QUOTE(x) _QUOTE(x)
+
 enum
 {
   DIRTY,
@@ -457,10 +460,10 @@
           identifier = g_filename_to_utf8 (tmp, -1, NULL, NULL, NULL);
           g_free (tmp);
         }
-      else if (g_str_has_prefix (path, MYPAINT_BRUSHES_DIR))
+      else if (g_str_has_prefix (path, QUOTE(MYPAINT_BRUSHES_DIR)))
         {
           tmp = g_strconcat ("${mypaint_brushes_dir}",
-                             path + strlen (MYPAINT_BRUSHES_DIR),
+                             path + strlen (QUOTE(MYPAINT_BRUSHES_DIR)),
                              NULL);
           identifier = g_filename_to_utf8 (tmp, -1, NULL, NULL, NULL);
           g_free (tmp);

@Jehan Opinions on this?


Error: no Auth Provider found for name "azure"

Getting this error when using this plugin against cluster using Azure Auth

Getting same for gcp:
Error: no Auth Provider found for name "gcp"


error[E0277]: the trait bound iced_wgpu::renderer::Renderer: iced_native::widget::image::Renderer is not satisfied

Hi,
I'm trying to compile the "svg" example using the newest release. With the "0.1.0-beta" release, it works as expected. With the new release, however, I run into the following error:

error[E0277]: the trait bound iced_wgpu::renderer::Renderer: iced_native::widget::svg::Renderer is not satisfied

with the explanation

the trait iced_native::widget::svg::Renderer is not implemented for iced_wgpu::renderer:: Renderer

I hope we can work this out. Please tell me if more information is needed :)

How are you exactly compiling it? cargo run --package svg works for me.
If you copied the example into your own project, you may need to enable the svg feature (I should document this!).

Ah, yes. Enabling the svg feature did the trick. Thanks for the quick help!

New guy here, how exactly did you enable this?
I tried:
`[features]
svg = ["iced_wgpu/svg"]
[dependencies]
iced = "0.2"
iced_wgpu = "0.3"
`

New guy here, how exactly did you enable this?
I tried:
`[features]
svg = ["iced_wgpu/svg"]
[dependencies]
iced = "0.2"
iced_wgpu = "0.3"
`

The example directories contain TOML files that you can use as a reference. But for SVG, it should be something like this:
iced = { version = "0.2.0", features = ["svg"] }
I hope that helps :)

The example directories contain TOML files that you can use as a reference. But for SVG, it should be something like this:
iced = { version = "0.2.0", features = ["svg"] }
I hope that helps :)

Yeah, that did the trick. Found that it also worked when compiling and running with:
cargo run --features "svg"
But your solution is way better, kinda new to rust. Thanks alot for the help and fast reply.

Yeah, that did the trick. Found that it also worked when compiling and running with:
cargo run --features "svg"
But your solution is way better, kinda new to rust. Thanks alot for the help and fast reply.


Do we need versions of Glob.Match that work with UTF-8 strings?

The two overloads of Glob.Match currently take in ReadOnlySpan<char>, meaning that the text must be in UTF-16 format. Do we need to support matching directly against UTF-8?

I think this would be a good thing to support and we could open an issue to do so.
At the moment, because System.Text.Json doesn't give us a way to get at the UTF8 bytes the first usecase I have in mind couldn't use them, though.

Now that we have a (fairly) efficient way of getting at the UTF8 text - this issue now becomes "a good idea".


[dv/foundry] Calculations for ROM ECC in foundry database

The foundry ROM fails due to the following addition in PR #9245:
DV_CHECK_FATAL((this.width < bits_per_subword) || (this.width % bits_per_subword == 0),
"With multiple subwords, mem width must be a multiple of the ECC width")
cc: @tjaychen

huh... this is odd. I didn't think ROM would have this issue.

Fixed via PR in the close source database.


Addding new Safeguards

Adding new safeguards to Draft repo

opened a new PR - https://github.com/Azure/draft/pull/364


System Design Document (SDD)

SOTTP_SDD_v0_2.docx

Reviewed the document, Incorporated the  Architectural diagrams that were created and updated by Kevin into SDD.  It is working document.

Sprint 4 SDD
•	General updates to Sections 1 & 2
•	Added figure to Section 4.4
•	Removed architecture and design elements that have not been finalized
SDD_SOTTP.docx

Performed technical edit and checked back into SharePoint.

Sprint 5 SDD
Updated diagrams and added content globally
SDD_SOTTP.docx

Sprint 6 SDD
Updated Table 9 and 57
Updated Figure 7
Updated sections 4.4, <IP_ADDRESS>.4, <IP_ADDRESS>.33, 6.5
SDD_SOTTP.docx

Sprint 7 SDD
Performed technical edit
Updated Figure 7
SDD_SOTTP.docx

Sprint 8 SDD
Performed technical edit
Updated <IP_ADDRESS>.1, <IP_ADDRESS>.17, <IP_ADDRESS>.18, 6.2.12, 6.5
Added <IP_ADDRESS>.2.
Updated Tables 32, 35-40
Updated Figure 8
Added Figures 9-11
SDD_SOTTP.docx

Sprint 9 SDD
No updates
SDD_SOTTP.docx

Sprint 10 SDD
Technical Edit
SDD_SOTTP.docx

Sprint 11 SDD
No Updates
SDD_SOTTP.docx

Sprint 12 SDD
No Updates
SDD_SOTTP.docx

Sprint 13 SDD
No Updates
SDD_SOTTP.docx

Sprint 14 SDD
No Updates
SDD_SOTTP.docx

Sprint 15 SDD
Updated Figure 5 & Figure 9
Moved Section 6.5 content to Section 9 (Appendix A)
Updated sections, 3.3.3, 4.4 & <IP_ADDRESS>.33
SDD_SOTTP.docx

Sprint 16 SDD
No Updates
SDD_SOTTP.docx

Update to SDD
SDD_SOTTP.docx
10/21/2016


Upgrade to v3.90.0 of the Google Beta Terraform Provider

Fixes: #674

the release failed -> https://github.com/pulumi/pulumi-gcp/actions/runs/1409058200

@stack72 ping :)

@stack72 ping :)


Second run

So, I know that finishok button is bugged right now, but if you move the mouse, the bot continues like normal. Except, when it starts the loop again, it gets stuck in the level selection menu. I have selected level 5 heroic in Barrens, but after the first run, bot gets stuck in the loop, just looking for "fir" and "ser" buttons and clicking them nonstop, resulting in an infinite loop. Relaunching the bot makes it continue like normal. This is on 1920x1080 res.
Edit: Looks like the problem is that the bot can't select the level that is already selected. The log says it can't find the level button, level 5 in my case.

Hi,
I had the same problem with some levels. It's related to the image used which show too much thing.
When the level is already selected, the blue halo isn't find on the picture.
It's easy to get it right :

take a screenshot (with the level selected) and cut only the upper part with the boss and the level and replace the original image (ex: files/1920x1080/level/5.png) (/!\ don't take the blue line or the bot won't recognize it when it's not already selected)
Deopster is little busy (my commit take too much time to be commit) => you can use my fork if you want. /!\ there is less tests because I'm using Linux (can't test on windows) but for what is not plaform specific (like your bug), it should work

Or You can use the branch "ForDeveloppement" (from the actual repo) which is newer (I put a lot of code which is not in "main")
My fork : https://github.com/Efemache/Mercenaries-Hearthstone-game-bot ('ill create a new branch like "improvement" for next commits)
I'll be back on this repo when Deopster will be available.

Better support for The Barrens and Felwood (normal and heroic) added :
https://github.com/Efemache/Mercenaries-Hearthstone-game-bot/tree/improve2

So, I tried your version, but it seems to be stuck on prize selection. When I look at cmd window, it seems to fail to find "presents" in UI_ellements. Granted, I'm trying Level 5 heroic from barrens, and only "presents" picture has 4 presents in them, so it probably fails because of that. I could try farming default level 27 felwood, but the bot is definitely not ready to for high-level bounties, because 1. The logic behind it lacks, often resulting in bad decisions, which results in a loss. 2. Most of the time, bot can't use moves (usually it's the middle one, in my case Samuro).
All I'm saying, that the bot is still not ready.

Hi,
I use the bot at level 27 (with only 3 heroes at level 30) and it beats the boss most of the time.
But you're right, the bot is not ready for each Heroes. It doesn't have any logic except "turn 1, do this; turn 2, do this" for some heroes and for others it's only "use the first button". And I think we are far far far away from this point.
There is a lot of bugs (i'm trying to solve them and each day I find new ones). So I'm trying to solve these bugs before to go for new features.
I'll try to look at this bug you're talking. The "present" image isn't needed.

Hi, I use the bot at level 27 (with only 3 heroes at level 30) and it beats the boss most of the time. But you're right, the bot is not ready for each Heroes. It doesn't have any logic except "turn 1, do this; turn 2, do this" for some heroes and for others it's only "use the first button". And I think we are far far far away from this point.
There is a lot of bugs (i'm trying to solve them and each day I find new ones). So I'm trying to solve these bugs before to go for new features.
I'll try to look at this bug you're talking. The "present" image isn't needed.

Honestly, even just working bot without logic and just using 1 button would be fine to farm low level bounties for coins.

Hello,
That's fine now : https://github.com/Efemache/Mercenaries-Hearthstone-game-bot/tree/improve2
I did a lot of tests with Barrens/heroic/level5 and Felwood/normal/level27 and it's working.
I changed a lot of code (not related to your bug) so I couldn't test everything (like Boon, Mysterious Encounter, group creation,...) but for rewards, battle, treasure, level selection, ... everything is fine.
With the previous code, bot was getting stuck a lot of time on the "road" (battle / encounter selection). With my 5-6 runs with this new code, I had 0 problem.
ps : I support only 1920x1080 and English language (for now)

Tried it again. Now it did choose all the rewards, but after that, it went to the main menu and kept looking for back button and pressing it, resulting in loop.

Tried it again. Now it did choose all the rewards, but after that, it went to the main menu and kept looking for back button and pressing it, resulting in loop.

Hi,
Yes I saw it and it's already fixed in a new version.

ok, I think it works now. The remaining problem I have is, sometimes bot doesn't use on of my heroes (I run Xyrella, Samuro and Cariele). I think it's because it tries to use second ability, but Samuro has that ability on cooldown.

ok, I think it works now. The remaining problem I have is, sometimes bot doesn't use on of my heroes (I run Xyrella, Samuro and Cariele). I think it's because it tries to use second ability, but Samuro has that ability on cooldown.

It's weird, the bot only uses 2 (or 3) abilities for 3 heroes.
For the other ones, it only uses the first ability. So for Samuro, it should use the first one.
I remember, I already saw the bot to doesn't use one of my hero.
It's from the previous code. I didn't touch this part for now (I already had a lot of things to make it work for full run and loop)
I only worked on two bugs :

one where the bot was clicking between two enemies so it didn't attack with any hero
another one where it wasn't clicking on "ready" button
I know that sometimes, even if there are enemies, the bot don't "detect" them and write "Battle error,please write what happend on github issue"

You can open a new bug; We'll see if somebody can look at it.
I already changed a lot of code and made it easier (to read and modify), so I would like to work on this part for now.
I'll look into battle code latter.

Looks like I still can't get consistent second runs. I have two thing happening:

The bot is either going back to main menu (reason unknown)
The bot is works well until it goes to boss selection, but it gets stuck, because it keeps searching for "Botwork" party name, instead of choosing the boss.

Looks like I still can't get consistent second runs. I have two thing happening:

The bot is either going back to main menu (reason unknown)
The bot is works well until it goes to boss selection, but it gets stuck, because it keeps searching for "Botwork" party name, instead of choosing the boss.

Hi,
Yes I just found this one this morning.
I thing it's related to "tempo" (time.sleep()).
If I bring a quick patch, we'll find another one. I need more time to test / change how the bot is waiting and how long.

I pushed a quick/dirty patch but not tested.
I'll do better later.

A new version is available.
I tested it with 3 runs and it works well. I added new features, more information here :
https://github.com/Deopster/Mercenaries-Hearthstone-game-bot/issues/40#issuecomment-976008622

I'll test it today, thanks.

Sometimes the second run don't start and I know why. When the "mercenaries menu" (where you can choose to see tasks, go to battle, see your mercenaries, etc...) is loaded, it takes some seconds before to be clickable.
I think you can add after line 954 a time.sleep(3) (or more if you want). It should be someting like this :
waitForItOrPass(chekers[21], 6) # chekers 21: 'menu'
time.sleep(3)
travelToLevel()
Try different values (3, 4, 5, 6 ...).
I'll change the code so the bot can resume wherever it is.

@asakurato since you are the only one to ask / answer :) , do you need the feature to (auto) create group ?
I think it's unnecessary, so maybe I'll delete this from a future version to make the file smaller and delete unwanted/unnecessary code.

Hi,
I decide to start a "new" project  : https://github.com/Efemache/Mercenaries-Farm-bot
I continued with my fork and I decided to create a new project because :

I'm the only one to dev
Because working with the previous code, I can see we are not working on the same thing. The "previous" bot (the one in this repo) only to level up your heroes to 30 and create groups to do it. My purpose is to create a group to win some coins and to achieve the campfire tasks (because I haven't the time to do it each day)
Feel free to use it or to use the one on this repo.

fixed here : https://github.com/Efemache/Mercenaries-Farm-bot

That's what I would like, I guess we continue there.


Update zio, zio-test, zio-test-magnolia, ... to 2.0.0

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-magnolia
dev.zio:zio-test-sbt

from 2.0.0-RC6 to 2.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #257.


Don't Mark Conditional Preprocessor Line as Inactive

Currently, clangd will mark all lines that's skipped by the clang preprocessor as inactive, including those #elif and alike. Although technically it's correct from the perspective of the preprocessor, it's less readable since all conditional directives are "hidden" among all other codes.
They should instead be treated as normal code.
A workaround could be: https://github.com/llvm/llvm-project/compare/main...daiyousei-qz:avoid-mark-conditional-preprocessor-line-inactive
which presents the following syntax highlighting:

However, the changes above feel more like a workaround instead of a fix to me. Probably, the change should be made to the PPCallback::SourceRangeSkipped. But I'm afraid changing behavior of that could be destructive to other tools and the current model is technically correct from the compiler's perspective.
Limitation of the change above:

Macros in directives that are not taken doesn't get correct semantic token info as displayed in the example above
The following code will crash the clangd in clangd::toSemanticTokens "assert(Tok.R.end.line == Tok.R.start.line);"

#ifdef \
test
#endif

Update:
Crash doesn't seem to be related to the change above, maybe it's related to https://github.com/clangd/clangd/issues/1145

If I understand correctly, this is the same as #773, and may be fixed by the patch at https://reviews.llvm.org/D125863

Wow, I'm happy this is being worked on. Though the current patch at https://reviews.llvm.org/D125863 seems to only work with the terminating PP while the workaround above attempts to filter all conditional directive lines as active codes. But it's like embedding a little parser into the clangd codebase which could be a burden to maintain (I doubt new conditional preprocessor will be introduced in the future though except two in C++23).

Ah, you mean you would like a preprocessor directive in the middle of an inactive block to be colored as if it were active, as well?

Exactly. Personally, I think this is more intuitive to see the structure of preprocessors. This is also what cpptools does.

Anyway, closing this as a dup since this is being worked on.

Duplicate of https://github.com/clangd/clangd/issues/773


Need to upgrade postgreSQL to 9.4.9 (or later version) due to security issues

There are 2 vulnerability issues requiring to upgrade postgreSQL to 9.4.9 or later version:
https://exchange.xforce.ibmcloud.com/vulnerabilities/116075
https://exchange.xforce.ibmcloud.com/vulnerabilities/116082
Thanks.

Possible to give a due date? Our security team asked me for it. Thanks.

Story: https://www.pivotaltracker.com/story/show/130847907

Fixed in v257.15 bosh release.


ViewPropTypes from react-native undefined, causing TypeError on the 'style' prop

Issue summary
react-native-multi-select.js is failing to compile with TypeError: Cannot read property 'style' of undefined. The error appears to be for any reference made to ViewPropTypes. I have run 'yarn outdated' to check my node module versions and dependencies; nothing wrong stood out for me.
My app is built/run using "react-app-rewired start" with a few customize-cra rules in the config-overrides.js.
Any help/idea would be appreciated.
Library versions
react: ^17.0.1
react-native: 0.63.3
react-native-multiple-select: ^0.5.6
Steps to Reproduce
This error shows up for "import MultiSelect from 'react-native-multiple-select'" line in my code when "react-app-rewired start" is run.
Expected Behavior
I expected ViewPropTypes.style from react-native to not cause any problems, and the multiple select list would show up in my app.
Actual Behavior

Commenting out all the lines that reference ViewPropTypes.style bypasses the compilation issue, but obviously that's not desirable. For example, these lines:
In react-native-multi-select.js
   styleDropdownMenu: ViewPropTypes.style,
    styleDropdownMenuSubsection: ViewPropTypes.style,
    styleInputGroup: ViewPropTypes.style,
    styleItemsContainer: ViewPropTypes.style,

@sajidrocks are you using a Typescript version?

@sajidrocks are you using a Typescript version?

@AugustoAleGon , thanks for looking into it. No, I am not using a Typescript version.

Ok. Let me take a look. Can you post a snippet of the code?

Ok. Let me take a look. Can you post a snippet of the code?

Please see below. FYI - the MultiSelect component is embedded inside a react-hook-form Controller, which is not even reached since the import triggers compilation, which fails with the error  //import MultiSelect from 'react-native-multiple-select';
<View style={lstyles.localities}>     <Text style={lstyles.localitiesLabel}>Preferred Work Localities</Text>     <Controller         name="localities"         control={control}         rules={{required: true}}         defaultValue=""         render={({onChange, onBlur, value}) => (             <MultiSelect                 items={localitiesRefData}                 uniqueKey="id"                 onSelectedItemsChange={this.onSelectedItemsChange}                 ref={(component) => {this.multiSelect = component}}                 selectedItems={localities}                 selectText="Select Localities"                 searchInputPlaceholderText="Search localities..."                 displayKey="name"             />             )}     />     {errors.localities && (         <Text style={lstyles.fieldsInvalidErrMsg}>Required</Text>     )} </View>

Can you please remove the node_modules folder and run yarn ?
I am testing right now with the latest RN version and all is looking good.

I see what the problem is. Trying just to wrap the component around a View

Following your suggestions, I removed the node_modules folder and ran yarn, first with a View wrapping the component and then without the View but I am afraid to say, in both of these cases, it made no difference for me. Same error. Thanks so much for continuing to look into it.

I see what the problem is. Trying just to wrap the component around a View

Any progress on this? Is there any temporary solution other than commenting propTypes?


Create harvest doctor to validate customer environments

Similar to brew doctor and support bundle. Collect information, validate, and present to customer.
Compress and offer to share.
Ideas:

validate yaml
verify harvest is or is not running
verify that Prometheus is or is not reachable
verify permissions
verify credentials
hit the Prometheus endpoint(s) and show results
check versions of Prometheus, Grafana, InfluxDB, OS, and embedded release/commit/build date
validate /var/run/harvest permissions

Extract what's reasonable from Troubleshooting Harvest automate and/or include

[ ] Update documentation

Validated harvest doctor and it works great and nice feature. Observed below issue.
bin/harvest doctor --print
Observation , it prints all information and redacted most of the sensitive information except for poller username. It marked username key as redacted instead of actual username value. [It might have happened due to auth_style: password, password was one of the sensitive key we are checking for redacted]
root@scspa2385980005 harvest-21.06.0801-nightly_linux_amd64]# bin/harvest doctor --print
Exporters:
prometheus1:
exporter: Prometheus
addr: -REDACTED-
port: 12992
prometheus2:
exporter: Prometheus
addr: -REDACTED-
port: 12991
prometheus4:
exporter: Prometheus
addr: -REDACTED-
port: 12994
Defaults:
collectors:
- Zapi
- ZapiPerf
use_insecure_tls: true
Pollers:
umeng_aff300:
datacenter: umeng_aff300
addr: -REDACTED-
auth_style: password
-REDACTED-: admin
password: -REDACTED-
exporters:
- prometheus1
Note : rename the file yml.
harvest.txt

Verified the issue using below build and everything works as expected.
[root@scspa2398581002 harvest]# ./bin/harvest -v
harvest version 21.06.1121-nightly (commit 1524ebb) (build date 2021-06-11T21:11:15+0530) linux/amd64
[root@scspa2398581002 harvest]# ./bin/harvest doctor --print
Exporters:
prometheus1:
exporter: Prometheus
addr: -REDACTED-
port: 16992
prometheus2:
exporter: Prometheus
addr: -REDACTED-
port: 16991
prometheus4:
exporter: Prometheus
addr: -REDACTED-
port: 16994
Defaults:
collectors:
- Zapi
- ZapiPerf
use_insecure_tls: true
Pollers:
umeng_aff300_lr22:
datacenter: umeng_aff300_lr22
addr: -REDACTED-
auth_style: password
username: -REDACTED-
password: -REDACTED-
exporters:
- prometheus1
F2240-127-26_lr22:
datacenter: F2240-127-26_lr22
addr: -REDACTED-
auth_style: password
username: -REDACTED-
password: -REDACTED-
exporters:
- prometheus2
fas8060-39-239-241_lr22:
datacenter: fas8060-39-239-241_lr22
addr: -REDACTED-
auth_style: password
username: -REDACTED-
password: -REDACTED-
exporters:
- prometheus4
Tools:
grafana_api_token: -REDACTED-
[root@scspa2398581002 harvest]#


Fix bug in OptionsManager, and make otions update when change VM

@mareklibra Please review https://github.com/oVirt/ovirt-web-ui/issues/260

Fixes: https://github.com/oVirt/ovirt-web-ui/issues/260


Click to home (Component Logo) returns end user to original tranche state

original state = tranche selected before input and simulation

send back to original state of the selected tranche.
currently when you click home you go to default USDC tranche.


WIP: Update to 3.4.4

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This is a copy of @dhirschfeld's https://github.com/conda-forge/podman-feedstock/pull/13 (https://github.com/conda-forge/podman-feedstock/pull/13/commits/4fc896ca3a07f91272d0d3397a3bd92013624853) with these additions:

Podman 3.4.4
Modified the go-licenses path
Updated the tests to take account of the changed output from podman ... info

I've managed to get this building in a container quay.io/condaforge/linux-anvil-cos7-x86_64:latest with command conda build -c conda-forge -m .ci_support/linux_64_.yaml recipe/, however this still fails at the testing stage:

[ ] Podman requires conmon >= 2.0.30 (I think), the conda-forge version 2.0.21 is too old

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conmon 2.0.31 PR here: https://github.com/conda-forge/conmon-feedstock/pull/10

@conda-forge-admin, please rerender

The --help and --version tests seemed to work but something else seemed to go wrong:
time="2022-01-18T22:54:25Z" level=debug msg="Using OCI runtime \"$PREFIX/bin/runc\""
time="2022-01-18T22:54:25Z" level=info msg="Found CNI network podman (type=bridge) at $PREFIX/etc/cni/net.d/87-podman.conflist"
time="2022-01-18T22:54:25Z" level=debug msg="Default CNI network name podman is unchangeable"
time="2022-01-18T22:54:25Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
cannot clone: Operation not permitted
Error: cannot re-exec process
Tests failed for podman-3.4.4-h9f03be5_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken

The build is run in docker, and I think we've hit https://github.com/containers/podman/issues/10802

Maybe also add :
azure: {store_build_artifacts: true}
So the built artifacts can be tested manually?
https://github.com/conda-forge/jupyterlab-feedstock/blob/master/conda-forge.yml#L6

The build script can read additional options set in an env-var
https://github.com/conda-forge/podman-feedstock/blob/1f2c62fbe3b4263da8d5f7aa75011bef2ab49c42/.scripts/run_docker_build.sh#L67-L68
Adding --cap-add SYS_ADMIN might work? I'll test locally when I get time.

@bollwyvl thanks for the suggestion, I've added it.
@conda-forge-admin, please rerender

Adding --cap-add SYS_ADMIN might work? I'll test locally when I get time

Maybe? Sounds like it might not be an option though :/

I'd be ok with not running the test. If we can get it to work great, but if not, we'll pick up any breakage if we're using it regularly and can publish a new build if required.

--cap-add doesn't exist in docker build, but it does exist in docker run (which is used to build this podman package).

@conda-forge-admin, please rerender

Green!

Thanks @manics for getting this one over the line - great work!
Hopefully someone from @conda-forge/core will be able to merge shortly...

Thank you @beckermr !


Android: Problems streaming video from windows file share to third party app using NanoHTTPD

I'am trying to use NanoHTTP to pass an JCIFS SmbFileInputStream to another app. (Just like ES File Explorer or RootExplorer forwards these files) I've used the  serveFile from SimpleWebServer.java as an example for this. When I return the video file from local storage using FileInputStream the stream to the third party app works perfectly. But when I replace the FileInputStream with my SmbFileInputStream the stream pauses after about 30 seconds and then again and again in 5 second steps. The stream pauses every time when the garbage collector is working. 1 second after I see the following log in logcat the stream pauses:
GC_FOR_ALLOC freed 14773K, 23% free 52598K/68176K, paused 41ms, total 41ms
I've also tested what happens if I play the stream in a video view directly in my application and in this case the video stream can be played until the end without any pauses. I'am running NanoHTTP inside a foreground Service. I don't know what else I could do to tell Android not to pause the stream from my service when an external app is open. How can I solve this problem? Or is the problem maybe something completeley different?

I think I found a solution for my problem. I've integrated the LargeReadWrite2015.patch from here into my jcifs code: http://jcifs.samba.org/src/patches/LargeReadWrite2015.patch
This speeds up the transfer rate and now my video plays fine.


Add a "Update image" button in the summary tab

Add a "Update image" button in the summary tab above the "Take another picture" button and rename the "Take another picture" button to "Take extra photos of the packaging"
The "Update image" should replace the front image for the current language.

I can implement this, if it's still open

Yes, it is
Some pointers:
https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/develop/app/src/main/res/layout/fragment_summary_product.xml
https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/develop/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/product/summary/SummaryProductFragment.java
Fell free to join the Slack at https://slack.openfoodfacts.org in the #android and #android-alerts channels

Ok, I will go ahead and start implementing it


Fixed relative import to the core package

Found that issue by trying to publish this package to my own scope so I could test my #480 PR on my own project.
Seems to me like a good change nonetheless..
Thanks ahead!

Thanks @davidyaha !


fix: announce when a config file is invalid and exit with a non-zero code

When looking into some other config stuff I realised the current loading logic just assumes that an error is because a config doesn't exist and silently falls back to the default one, when really it could be that there is a config but it's invalid

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.67%. Comparing base (f8953ff) to head (0c66681).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   67.83%   68.67%   +0.83%
==========================================
  Files         174      174
  Lines       16769    13084    -3685
==========================================
- Hits        11375     8985    -2390
+ Misses       4765     3469    -1296
- Partials      629      630       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add article about the new FAF changes in Openshift

The FAF and the database for FAF now run in two different containers.
Signed-off-by: Martin Kutlak<EMAIL_ADDRESS>

Would be nice to write there which version of FAF and postgres-semver you used in case, that somebody will try this in a long time. I'll release new FAF today and also create postgres-semver project.
But I cannot decide what version should I put to the postgres-semver image. Should I start from 1.0 ? Or should I match with FAF (1.2.2)? Ideas @mkutlak @xsuchy ?

Version of postgresql?

Version of postgresql?

No, of the postgresql-semver image we are gonna release.  It may happen in the future, that we make some changes, that won't be compatible with older version and if someone will find this article, so he/she knows, that with which version if works.

Oh sorry, I meant tag the image by the version of postgresql.

I don't think that is a good idea. We may need to release a new image with the same postgresql image version. Maybe .0 or something similiar would be possible

@marusak I've added the versions to the article and changed the date.


Beta: Waypoint: Ditch Custom CSS for Bootstrap - missing test

Challenge http://beta.freecodecamp.com/challenges/waypoint-ditch-custom-css-for-bootstrap
I noticed there is no test for the instruction to "Then Delete the p element that contains a dead link."
Probably be good to have one.

Closing as stale


throw an error when connect to server

my lt version is 1.8.1,and node version is v0.10.41
localtunnel-server version is v0.8.0,and node version is v0.10.41
then
ubuntu@myserver:~/localtunnel-server/server$ ./bin/server --port 2333
  localtunnel server listening on port: 2333 +0ms

when i connect to the server
[www@localhost ~]$ lt --host http://tunnel.mydomain.com:2333 --port 8000

/home/www/.nvm/v0.11.8/lib/node_modules/localtunnel/bin/client:48
        throw err;
              ^
Error: localtunnel server returned an error, please try again
    at Request._callback (/home/www/.nvm/v0.11.8/lib/node_modules/localtunnel/lib/Tunnel.js:53:27)
    at Request.self.callback (/home/www/.nvm/v0.11.8/lib/node_modules/localtunnel/node_modules/request/request.js:198:22)
    at Request.EventEmitter.emit (events.js:106:17)
    at Request.<anonymous> (/home/www/.nvm/v0.11.8/lib/node_modules/localtunnel/node_modules/request/request.js:1082:10)
    at Request.EventEmitter.emit (events.js:125:20)
    at IncomingMessage.<anonymous> (/home/www/.nvm/v0.11.8/lib/node_modules/localtunnel/node_modules/request/request.js:1009:12)
    at IncomingMessage.EventEmitter.emit (events.js:125:20)
    at _stream_readable.js:896:16
    at process._tickCallback (node.js:311:11)

and the server side output:
  localtunnel-server request /?new +10s

anyone can help?

i found the reason,seems like this issue:https://github.com/localtunnel/server/issues/31


Pagination in leaderboard

As of now the leaderboard loads the scores of all people that ever played ladder.
This takes quite a while and is slower than the classic client.
I propose we do it like in the classic client and show only 50 entries per page (or make the number configurable).

I used pagination back in time, here's why I removed it:

The leaderboard loads all active players, that's way less than all players.
The 1v1 leaderboard data response from the API right now is 779KiB - basically nothing
I'm in the school now, at my notebook (aka. slow notebook, slow internet). It takes me <2s to load the leaderboard.
Pagination requires server-roundtrips
Pagination doesn't allow instant-searches (w/o server roundtrips)
Pagination is bad UX design
If the current implementation gets too slow, there are two steps to take first: Caching on API side, loading it in background in the client


Unchecking "Show Non-Video Participants" while in voice chat causes crash

Unchecking the top option here causes crashing.

It only happens when this plugin is enabled, disabling it stops it from crashing.
From console:

Above is as soon as I uncheck the box. Using version 1.3.1

v1.3.2 released with this fix, let me know if the issue is fixed or not.

This fixed my issue thank you for the quick response!


Fixes crash when adding point requiring buffer resize

Fixes error thrown when adding points to graph layer by adding refresh blocker, as suggested here.
Type of change

[X] Bug-fix (non-breaking change which fixes an issue)

How has this been tested?
I have included a test that fails without the fix and passes with the fix. the test adds points to a graph layer
Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works
[] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

LGTM!