Performance issue: [Violation] 'focus' handler took 603ms

The Problem
In a table with 20 lines of 15 inputs (300 inputs), it takes half a second to just pass from one text input focused to another, and up to 3 to open a dropdown. Chrome devtools warn about 'focus' and 'blur' events taking half a second, although I am ignoring them using the ignore prop of Control components, so it is unexpected.
Edit: The problem simplifies itself to: "Why is there a "rrf/batch" (blur + change) action sent when only focusing an input, even when the value does not change, and how can I disable this behavior"?

This is what React is doing during one of these "events":

From this I am not able to see if the performance impact is due a bug with the event handlers or a React tree reconciliation problem. Since I never change the input values, I don't understand why there should be rendering anyway.
Is it known/expected/a misuse of react-redux-form?
N.B. Performance with a big number of inputs is a problem that has apparently been studied and solved in redux-form, see https://github.com/erikras/redux-form/issues/529. As far as I know the idea is to decouple the form model from the form values.
Steps to Reproduce
My inputs are all of one of these forms:
<Control.text model={modelName} updateOn="blur" ignore={['focus']} />
<Control.input model={modelName} type="number" updateOn="blur" ignore={['focus']} />
<Control.input model={modelName} type="date" updateOn="change" ignore={['focus', 'blur']} />
<Control.checkbox model={modelName} updateOn="change" ignore={['focus', 'blur']} />
<Control.select model={modelName} updateOn="change" ignore={['focus', 'blur']} >
    {options}
 </Control.select>

put in a standard HTML table, itself in a  connected to Redux.
Note that I make text fields update only onBlur, and try to ignore focus and blur events for the others. I have only PureComponents, disabled react-logger, and followed all performance advice I could find. Yet it remains extremely slow.
Reproducible Code Example
(I will spend a couple hours writing and example only if the description above suggests a bug and not a misuse.)

Is this still an issue? You closed the ticket

I wanted to open a more precise one when I really figure it out. I think this is the problem:

I want to re-render the whole form only if a value changes;
Inputs update the store on blur (updateOn="blur"), otherwise the performance is awful;
Even if you don't change the value, the onBlur event still triggers (clicking inside one text field, then inside another);
When the onBlur triggers, even if the value did not change (still ""), it re-renders the form. React-logger says there is "-- no diff --" when the "rrf/batch" (blur + change) event is fired, yet the whole thing re-renders. I don't understand this.

Even if you don't change the value, the onBlur event still triggers (clicking inside one text field, then inside another);

This is expected behavior - we can't make a restrictive assumption on this.

When the onBlur triggers, even if the value did not change (still ""), it re-renders the form.

This could be because the field state is changing touched: false to touched: true, but I'll investigate why it rerenders if you can provide me a code example.

I wrote a minimal example and the form does not re-render. Performance is great even with 600 inputs. I could find my mistake that caused the re-render. My bad. Good job with this library.

@jdelafon That's awesome to hear! Maybe you were on an older version? I know that we've made a ton of performance improvements in the last few minor versions.

Latest version. My component is still very slow but I figured out that it was because of the dropdown inputs. If I replace them by text inputs it becomes much faster, and apparently most of the time is spent in DOM reconciliation (if it makes any sense), so nothing I can really do about it.
What bothers me in this is that something like Excel is able to deal with way many more inputs without any lag, so why can't we do something similar with React? It is not even close. Or maybe I just suck.

@jdelafon It's because of the way React works - since it's a tree model, any update in state will cause all of the child components to ask whether or not they should update.
What React is smart at is knowing when not to update (and this is tweakable in shouldComponentUpdate).
What React is not smart at is knowing when not to ask when to update. Calling sCU for every single child element, even if it returns false for 99% of them, can be very slow. You're still calling a function 600+ times (in this case).
With the way React works, it's definitely not easy to say "I'm only going to update this one component - all you other components, don't even bother asking if you should update."
A functional/reactive paradigm is what spreadsheets, like Excel, would use. Every cell explicitly knows what other cell/entity to subscribe to, and knows that whenever that thing that it's subscribed to emits an event, it will update. No other cell in the spreadsheet will even blink an eye. It's push-based, not pull-based.

Very interesting, thanks! I am reading about RxJS now, it may be the answer.


BUG - Search results seems duplicated

Related Feature
Feature request: issue number
Description
A clear description of what the bug is.
Steps to Reproduce
Steps to reproduce the behavior:

Launch Guided Asnwers
Search for SAP Fiori tools

Expected results
Trees are noot duplicated
Actual results
Trees are duplicated
Screenshots

Version/Components/Environment
Add any other context about the problem here
OS:

[ ] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

When I'm accessing the API directly I do not see duplicate entries:
https://ga.support.sap.com/dtp/api/v5/trees/"SAP Fiori tools"?product=&component=&responseSize=18&offset=0
{
  "resultSize": 3,
  "trees": [
    {
      "SCORE": 0.94,
      "TREE_ID": 3046,
      "TITLE": "SAP Fiori tools",
      "DESCRIPTION": "This is a troubleshooting guide to solve the issues while using SAP Fiori tools",
      "AVAILABILITY": "PUBLIC",
      "FIRST_NODE_ID": 45995,
      "PRODUCT": "SAP Fiori tools",
      "COMPONENT": "CA-UX-IDE"
    },
    {
      "SCORE": 0.82,
      "TREE_ID": 3337,
      "TITLE": "SAP Fiori tools - Application Preview",
      "DESCRIPTION": "This is a troubleshooting guide to solve the issues related to application preview while using SAP Fiori tools",
      "AVAILABILITY": "PUBLIC",
      "FIRST_NODE_ID": 52881,
      "PRODUCT": "SAP Fiori tools",
      "COMPONENT": "CA-UX-IDE"
    },
    {
      "SCORE": 0.36,
      "TREE_ID": 3348,
      "TITLE": "Configuration of SAP Fiori Application",
      "DESCRIPTION": "Maintaining and Adding annotations",
      "AVAILABILITY": "PUBLIC",
      "FIRST_NODE_ID": 53055,
      "PRODUCT": "SAP Fiori tools",
      "COMPONENT": "CA-UX-IDE"
    }
  ],
  "productFilters": [
    {
      "PRODUCT": "SAP Fiori tools",
      "COUNT": 3
    }
  ],
  "componentFilters": [
    {
      "COMPONENT": "CA-UX-IDE",
      "COUNT": 3
    }
  ]
}

Ok, I think I found the issue. Prepared PR https://github.com/SAP/guided-answers-extension/pull/537


Make better use of request library

The getURL helper was duplicating built-in functionality of request so I removed it in favor of the library.

spinner.stop()  was referenced in the if and else branches so I consolidated them.

@fearphage Thank you for this PR. 💯 I'll review it as soon as possible.


EE-1193: Update wasmi to 0.7

Ref: https://casperlabs.atlassian.net/browse/EE-1193

Updates wasmi to 0.7
pwasm-utils to 0.16
Fixes transfer benchmark
Fixes typos in code that were present in wasmi 0.6 and which were also propagated to our code (comparision vs comparsion)
Explicit default wasm module of a gas function

Benchmark results against dev (with 67d8b2370cc4d62d5b8cc619a4f750fbcfc1c69c commit cherry picked)
https://gist.github.com/mpapierski/65a9949fdd8da4ea20e16d678e5fd769

As far as I can see, there are no performance degradation nor improvements. Do we know what has changed and whether we can make use of that?

As far as I can see, there are no performance degradation nor improvements. Do we know what has changed and whether we can make use of that?

I haven't inspected changes manually but the performance report gives me impression not much changed in the interpreter. I think all the relevant changes in wasmi are already reflected in this PR.

bors r+

bors r+


commands/.../scorecard: optionally use only a CSV manifest when deployed with OLM

Description of the change: added olm-deployed flag to directs the scorecard command to only use the CSV at csv-path for manifest data.
Motivation for the change: OLM-deployed operators may only have a CSV and CRD's available on disk, ex. automation-broker. The scorecard cannot assume that a deploy dir with SDK-generated contents will be available.

Can you also please update the cli-reference-guide and the CHANGELOG for the olm-deployed flag.


Checking for existence of identifier or Type

This implies that each frame maintains a dictionary of its local identifiers, and that there is a mechanism for accessing globals, in the same and other files (see #38 ).
Each entry should know:
The name
File
(Possibly) capabilities:

Constant
Variable  (because constants are used only in expressions)
Procedure (and therefore callable)
Function (not callable)

This should be used to advise (assuming an entry is valid):

Auto-completion options
When field is exited, if identifier does not exist, with option to create it
If identifier is of the wrong kind for context required by frame
Attempting to define an identifier that already exists.

There should be an equivalent global capability for user-defined types (Enums and Classes).

Superseded by other tickets


fix clippy warning and upgrade to edition 2021

Should I add cargo clippy -- -D warnings to CI?

https://github.com/alexcrichton/cmake-rs/issues/127#issuecomment-1055547244


Invitation to me this community

Github Username: Dragon1207
Please invite me to this community. Thanks

Hey @Dragon1207  !!
Welcome to openAOD! I have sent an invite to join our organization. We also recommend joining our Discord server : https://discord.gg/wZ83xSJSsN. If you have any questions regarding contributing or anything else feel free to write here or ping me on Discord. Cheers. Have a great day ahead of you!


Windows IDEA WSL support

Hi,
JetBrains team released WSL support in 2021.1 (see https://www.jetbrains.com/help/idea/how-to-use-wsl-development-environment-in-product.html )
While it is still has issue with symlinks: https://youtrack.jetbrains.com/issue/IDEA-253253
other parts of wsl interoperability works like a charm: one could open and work on project stored in linux (through wsl) from windows version of IntelliJ IDEA, and even integrated idea-terminal opens linux shell console instead of powershel.
But even in such smooth integration working with Bazel projects is hard, because:

It is not possible to choose & launch Bazel linux binary from Windows version of IntelliJ (because process executes in windows runtime) (see https://github.com/bazelbuild/intellij/issues/3098)
there are difference in file paths, produced from linux version of Bazel and wsl provided paths from windows. Every file is prefixed with \\wsl$\<distro-name> and has windows file separator (\ instead of /), e.g. /home/<user>/project/WORKSPACE will be accessible from \\wsl$\<distro-name>\home\<user>\project\WORKSPACE.
due to p2 IntelliJ bazel plugin could not determine project paths and dependencies (see https://github.com/bazelbuild/intellij/issues/3063)
and last some Bazel commands are not correctly escaped, like one fixed in https://github.com/bazelbuild/intellij/pull/2976

In order to fix these issues without rewriting a lot of parts of Bazel IntelliJ plugin (I understand that it is hardly be accepted by your team) I wrote a small go program https://github.com/dpoluyanov/bazel-wsl, which acts as Bazel binary for IntelliJ Bazel plugin and translates all passed commands to wsl default linux distro (through wsl command), so every call from plugin to bazel, like bazel info ... will be translated to wsl bazel info ..., with some patching around file paths and rewriting build event output once it is produced by linux bazel.
It could be some step toward to https://github.com/bazelbuild/intellij/issues/113 with caveat that it is not pure windows native build, but just an ability to work with bazel from Windows machines via transparent WSL backed linux VM.
There is one issue with jdeps resolution that I'd found:
https://github.com/bazelbuild/intellij/blob/master/base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java#L105
It is some workaround (which I couldn't find reason for) in resolving path to SourceArtifact through checking linux-specific file separator and because JdepsFileReader adds target to map only if it is instance of OutputArtifact (which SourceArtifact is not extends) currently in case of working via wsl plugin resolves jdeps file into SourceArtifact (jdep file has prefix bazel-out\k8-fastbuild\...) and skips its loading.
I've created a small path to change this behaviour and would like to ask: if it could be accepted into upstream repository in some way or there is another change which could be proposed in order to correctly find & load jdeps files in case of working from windows via WSL?
Index: base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java b/base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java
--- a/base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java	(revision 75c37dc96bdd4a9a4f8a74d4b50aa1fc4de51902)
+++ b/base/src/com/google/idea/blaze/base/sync/workspace/ArtifactLocationDecoderImpl.java	(date<PHONE_NUMBER>850)
@@ -101,9 +101,17 @@
    */
   private BlazeArtifact outputArtifactFromExecRoot(ArtifactLocation location) {
     // exec-root-relative path of the form 'blaze-out/mnemonic/genfiles/path'
+    // or blaze-out\mnemonic\genfiles\path
+    char separator;
+    if(blazeInfo.getExecutionRoot().getPath().startsWith("\\\\wsl")) {
+      separator = '\\';
+    } else {
+      separator = '/';
+    }
+
     String execRootPath = location.getExecutionRootRelativePath();
-    int ix1 = execRootPath.indexOf('/');
-    int ix2 = execRootPath.indexOf('/', ix1 + 1);
+    int ix1 = execRootPath.indexOf(separator);
+    int ix2 = execRootPath.indexOf(separator, ix1 + 1);
     if (ix2 == -1) {
       return new SourceArtifact(decode(location));
     }

It also could help with https://github.com/bazelbuild/intellij/issues/3063 and https://github.com/bazelbuild/intellij/issues/3098 in some way

What's the current state of this? I was also trying to use Bazel in Clion for a project inside my WSL documents but I'm getting the following error:

We've ended up with building our own copy of plugin from with small wrapper program around bazel

any news regarding this?

We've ended up with building our own copy of plugin for IntelliJ with small wrapper program around bazel

@dpoluyanov any chance you could open source this?

I've opensourced it there https://github.com/dpoluyanov/bazel-wsl

Hello @dpoluyanov,
First of all thank you very much for sharing your solution. 👍
I'd like to know if after having your bazel setup if you also found this kind of issues when syncinc your project in IDEA?

This is a common problem for our bazel-wsl setups and we have two consequent steps to mitigate this issue:

First of all, we create separate windows.bazelproject with enabled shard_sync and reduced value for target_shard_size to 300 (1000 by default), see https://ij.bazel.build/docs/project-views.html#target_shard_size.
So our windows.bazelproject looks like:

import baze.bazelproject # common settings for all projects

shard_sync: true
target_shard_size: 300

Second step is to set LongPathsEnabled to 1 in HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled
Look at https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later for .reg file

Thank you very much! It worked on my side 🎉

@dpoluyanov Thank you! Have starred your project.


Implement processes as Idempotent Message Receivers

A process should track the ids of all received messages and ignore duplicates.
If the process receives a message out of order, for example data-processed before log message, then this should not lead to errors. If the log message is an error, the process should check if version of the message is lower or greater than the version of the data-processed message an react accordingly, for example irgnore the error or reopen the task and close it with a success state depending on what message is newer (has higher version).

TaskListEntry is already adjusted. Maybe this is enough, otherwise we should consider implementing the suggested improvment.


test: add test for custom covariance and noisy average

Fixes

Fixes #13
Description
I added a basic test for the custom covariance, mainly the setup the basic test workflow. Happy to have some feedback to improve it!
We miss GH action to test all of this, but so far it passes locally 👼

Definition of Done

[x] I followed the Arkhn Code Book (I swear!).
[x] I have written tests for the code I added or updated.
[ ] I have updated the documentation according to my changes.
[ ] I have updated the deployment configuration if needed.

@naudinlo what edge cases would you consider for example?

@naudinlo I've added tests for handling empty values, but it is not very satisfactory (see comments in code).
However, I'd be in favor to merge the code as is and open an issue for future work, to be able to add the test structure to the project today
Sounds good to you?


__dirname not defined

Hi there!
I am having issues launching a browser in a local testing environment. It appears there is a problem with the executablePath function, and I am struggling to piece together where the hiccup is happening. The below set up follows this packages readme very closely :)
Do additional steps need to be taken for local set up?
Sorry if this is quite basic, and thanks in advance!!
Code:
import chromium from "@sparticuz/chromium";
import type { Browser, Page } from "puppeteer-core";
import puppeteer from "puppeteer-core";

import { IS_LOCAL } from "../utils/constants";

let browser: undefined | Browser;

export async function getBrowser(): Promise<Browser> {
  console.log({ IS_LOCAL });

  try {
    if (IS_LOCAL) {
      // handle local set up
    }

    const newBrowser = await puppeteer.launch({
      args: chromium.args,
      defaultViewport: chromium.defaultViewport,
      executablePath: await chromium.executablePath,
      headless: chromium.headless,
      ignoreHTTPSErrors: true,
    });

    browser = newBrowser as unknown as Browser;

    return browser;
  } catch (err) {
    console.error("Error getting browser instance");
    console.log(err);

    throw err;
  }
}

Output:
{ IS_LOCAL: 'true' }
02:53:24.545
Error getting browser instance
ReferenceError: __dirname is not defined
    at Function.get executablePath [as executablePath]

Package.json
    "puppeteer-core": "^18.2.1",
     "@sparticuz/chromium": "^108.0.1",

This is probably because this package is commonjs.
Try this: https://bobbyhadz.com/blog/javascript-dirname-is-not-defined-in-es-module-scope


What is spark mmx version

Hi
I'm using spark but I can't build nor using this extension because I can't find any info on a spark mmx version please help
I'm using spark 1.6.1 bundle with ec2 script
I'm using imply 1.3.0 based on druid <IP_ADDRESS>
Thanks

Sorry, this went unnoticed. we have our own spark we use at https://github.com/metamx/spark . Right now https://github.com/metamx/spark/tree/v1.5.2-mmx4 is in use.
I'm working on fixing things so that spark2.0 will work with this.

Spark 1.6.x should work out of the box though.

Thanks I'll try now with 1.6.2 waiting for spark 2.0


Google maps markers with custom icons look big on iOS

When using custom icons on the markers (32 x 32 pixel size, png format) the icons look big on iOS, but very small on Android devices.

MarkerOptions(                                           position: LatLng(               ..             ),             icon: BitmapDescriptor.fromAsset(crumb.marker),

@arnoraps could you show me how did you add multiple markers on map?

`  void _onMapCreated(GoogleMapController controller) {
setState(() { mapController = controller; });
for(var i = 0; i < array.length; i++) {
  var item = array[i];
  if (item!=null && item.gps!=null) {
    controller.addMarker(
      MarkerOptions(
        position: LatLng(
          item.gps.lat,
          item.gps.lon,
        ),
        icon: BitmapDescriptor.fromAsset(item.marker),
      ),
    );
  }
}

}`

@arnoraps  thank you so much
@zoechi same issue on ios, icon is too big. android is good.

why there is no option to control marker icon size?

is there any updates on this?

can i insert custom widget like icon ? for aggregation point i need to write the number of pin into icon of marker....
thank you

@arnoraps thanks

HI, is this issue resolved now?

I have had another look at this, it hasn't been fixed.
To get iOS to work properly and use the @2x and @3x images, you need to add the image variants to the pubspec.yaml file, so you need:
assets:
  - assets/images/icon.png
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>
otherwise the files don't get copied to the iOS build folder.
Then something like the following code will return the correct filename to use for the icon.
iconFile() {
  if (Platform.isAndroid) {
    double mq = MediaQuery.of(context).devicePixelRatio;
    String dirName = ''; // default for 1.0x
    if (mq > 1.5 && mq < 2.5) {
      dirName = "2.0x/";
    } else if (mq >= 2.5) {
      dirName = "3.0x/";
    }
    return 'assets/images/' + dirName + 'icon.png';
  }
  // this is for iOS
  return 'assets/images/icon.png';
}

The small icons are blown up on iOS and look fuzzy/pixelated

any update on this, having the same issue!

@juanjoserodrigolazaro
Using "add reaction" on the initial comment would increase priority while +1 comments are rather pointless and cause lots of people to get notified for no reason.
To get notified yourself use the [Subscribe] button to the top right instead.

It looks like flutter/plugins#815 might provide an acceptable workaround for this issue

guys Is it possible when you click in marker go to another page ?

There is OnTap method which you can use

It looks like flutter/plugins#815 might provide an acceptable workaround for this issue

For me, the icons are still much bigger and fuzzy, where the Android ones are fine.

It looks like flutter/plugins#815 might provide an acceptable workaround for this issue

I tried it and I don't see any difference.
@arnoraps, did you find a fix yet?

Based on @gtupak's comment it looks like there may still be work to do here to get the icons on iOS to look as expected. I am not actively working on it right now, so unassigning myself. If anyone wants to open a PR for a fix, I'm happy to review that.
/cc @iskakaushik

@gtupak , can you try version 0.5.7 and use BitmapDescriptor.fromAssetImage and let me know if that solves this?

Wow, great work, guys, the icons are FINALLY not pixelated. Big cheers! 🙌

Fantastic! The icons are now scaled correctly on both iOS and Android.

https://github.com/flutter/plugins/pull/1478/files fixes this issue.

شادی باشه

Wow, such a great update finally I am waiting for this PR and polyline PR for about 3 months now finally they both available thanks so much.

So BitmapDescriptor.fromAssetImage returns a Future ... so do you need to then use a FutureBuilder to render the Markers? How do I complete the Future to give to the Marker icon property?

Guys and gals, does this allow for a custom widget to be used as a marker?

@workerbee22 check that example. They store the final marker icon value into state.
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/marker_icons.dart

Would be nice if we could just have a widget for many reasons.. anyhow new bug.
BitmapDescriptor.fromAssetImage ignores the image size as well. Example loading:
 BitmapDescriptor.fromAssetImage(
            ImageConfiguration(size: Size(60, 60)), 'assets/meetup_active.png')
        .then((onValue) {
      setState(() {
        markerIcon = onValue;
      });
    });

Custom image Size is not working in 0.5.13.

Does not work for me with single asset images (no 2.0, 3.0, etc).
I would expect this to 'just work' and scale marker icons automatically - like it does on Android.

I is not working also in 0.5.16

@iskakaushik  can this issue be re-opened please? As stated before the size parameter is ignored.

@GregorySech This is the intended behavior. The size parameter in the ImageConfiguration is ignored. We only use ImageConfiguration to resolve to the image of the correct dpi scaled resolution, 2x, 3x etc.
I have created a new issue to address this: https://github.com/flutter/flutter/issues/34657, these add a thumbs-up to it. It will help us prioritize.

@GregorySech This is the intended behavior. The size parameter in the ImageConfiguration is ignored. We only use ImageConfiguration to resolve to the image of the correct dpi scaled resolution, 2x, 3x etc.
I have created a new issue to address this: #34657, these add a thumbs-up to it. It will help us prioritize.

You need to remove this though. Replace it with a Widget. The whole ImageConfiguration just feels unnecessary and not well thought-out.

@ollydixon , there is an issue that tracks it https://github.com/flutter/flutter/issues/24213. It's an involved change as it requires us to synchronously keep the marker positions and the google map state in sync. If you look at the way we currently communicate with the platforms it's through out platform channels api, which doesn't yet allow synchronous communication.
We added support for markers to be created from:

raw image bytes
network images
asset images

I agree that these don't solve all the use-cases but the marker-widget issue is not part of our roadmap as it requires some additional work to be unblocked.

@iskakaushik wouldn't that just be widgets with coordinates, google maps API gives you all the points with lat and long? The bullet points you listed could easily be loaded from special marker widgets. It's how they do it on the React Google maps implementation; you really have no excuse sorry. One of the main philosophies of Flutter is 'everything is a widget' you're breaking it with this strange API; should be no.1 on your roadmap; you are losing customers to Flutter MapBox which is far superior at the moment.

Simple way to solve this problem by using that
BitmapDescriptor get deliveryIcon {
bool isIOS = Theme.of(context).platform == TargetPlatform.iOS;
if (isIOS)
return BitmapDescriptor.fromAsset('assets/icons/orange_pin.png');
else
return BitmapDescriptor.fromAsset(
'assets/icons/3.0x/orange_pin.png');
}

@ollydixon GoogleMaps aren't a typical flutter widget - they're actually an embedded Android / iOS view (ala React-Native). It's unlikely to have Widget icons before a major refactor.

The plugin relies on Flutter's new mechanism for embedding Android and iOS views. As that mechanism is currently in a developers preview, this plugin should also be considered a developers preview. ~GoogleMaps on pub.dev

@oodavid thanks for the info, you could still use a stack-view in this circumstance though. As long as you have the markers meta info. Just an idea though. :-)

I upgraded to Flutter 1.7 and now this issue is back. Using google_maps_flutter 0.5.19+2 with Flutter 1.7.8+hotfix.3 from stable channel. BitmapDescriptor.fromAssetImage() is using the 1.0x asset for devices with higher resolution so the marker images are tiny.

@timeuser may I suggest using using https://github.com/mapbox/flutter-mapbox-gl it's much better. Uses widgets, customizable maps and it's cheaper.

I upgraded to Flutter 1.7 and now this issue is back. Using google_maps_flutter 0.5.19+2 with Flutter 1.7.8+hotfix.3 from stable channel. BitmapDescriptor.fromAssetImage() is using the 1.0x asset for devices with higher resolution so the marker images are tiny.

https://github.com/flutter/plugins/pull/1821

i am using Flutter 1.5.4 and google_maps_flutter 0.5.19+2. Still load 1.0x asset

@timeuser  is right this issue is back again please suggest us what to do??

Why it's so complicated to change the marker icon? The goals of use Flutter should be to make apps development easier, right?
Are you talking serious about doing all this code just to change the icon?
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/marker_icons.dart

Why it's so complicated to change the marker icon? The goals of use Flutter should be to make apps development easier, right?
Are you talking serious about doing all this code just to change the icon?
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/marker_icons.dart

I agree. I proposed a contextless, sync version of  BitmapDescriptor.fromAssetImage but they ignored me.

The React native implmentation has markers as components. Example:
<MapView
  region={this.state.region}
  onRegionChange={this.onRegionChange}
>
  {this.state.markers.map(marker => (
    <Marker
      coordinate={marker.latlng}
      title={marker.title}
      description={marker.description}
    />
  ))}
</MapView>

I'm sorry contributers this is one of the worst ports of Google Maps I've ever seen...
@duzenko BitmapDescriptor.fromAssetImage shouldn't even exist in the first place.

Try this, It's work for me.
https://stackoverflow.com/questions/53633404/how-to-change-the-icon-size-of-google-map-marker-in-flutter

Why it's so complicated to change the marker icon? The goals of use Flutter should be to make apps development easier, right?
Are you talking serious about doing all this code just to change the icon?
https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/marker_icons.dart

I tried this cumbersome method but it still does not work consistently for android and ios. Drawing your own canvas seems to work but if the marker gets to complicated, it's not very easy to draw it since you cannot import a path from a svg. ..Sigh.

Not really a great fix, but this solved it for me.
In the google_maps_flutter plugin, update the file lib/src/bitmap.dart like this :
static Future<BitmapDescriptor> fromAssetImage(...) {
    ...
    return BitmapDescriptor._(<dynamic>[
      'fromAssetImage',
      assetBundleImageKey.name,
      4.0, // <= Replace 'assetBundleImageKey.scale' by '4.0' on line 76
    ]);
}

Icon markers are no longer are too big or blurry on iOS. You might want to add a check for Platform.isIOS to only apply the fix for iOS.
I hope it helps !

Not really a great fix, but this solved it for me.
In the google_maps_flutter plugin, update the file lib/src/bitmap.dart like this :
static Future<BitmapDescriptor> fromAssetImage(...) {
    ...
    return BitmapDescriptor._(<dynamic>[
      'fromAssetImage',
      assetBundleImageKey.name,
      4.0, // <= Replace 'assetBundleImageKey.scale' by '4.0' on line 76
    ]);
}

Icon markers are no longer are too big or blurry on iOS. You might want to add a check for Platform.isIOS to only apply the fix for iOS.
I hope it helps !

I do not recommend modifying the library code directly, as it would only work on your personal installation of the plugin. If you try to clean cache / reinstall plugins for some reason, or even build the project on another PC or with a CI tool, it won't work anymore (of course). So take this path only if you really know what you are doing

Why is this issue closed ? I Still have this issue. On iOS the icons are tiny.

Why is this issue closed ? I Still have this issue. On iOS the icons are tiny.

https://github.com/flutter/plugins/pull/1821

Why is this issue closed ? I Still have this issue. On iOS the icons are tiny.

What is the status of this issue? This should be priorities and not thrown to the bottom of the stack.. it's 1.5 year since this ticket was opened.


Iterator for Poller

While switching EventLoop to iterator instead of indexing, I spotted a
potencial problem: io_process expects list of events not to change during it's
execution, but self is passed as &mut to the handler, making it possible (at
least in theory) to break it. After switch to an iterator, this issue is caught
by borrow checker actually. I switched the code to collect()ing all events into
a Vec as a workaround for now and looking forward to better ideas.

Sorry for the delay. I ended up merging this at abbe04d3f1d9d51cf49a27a7b958dc385c066d1a


Update Navlink traversal

when user clicks on Navlinks there should be an active color on tabs but here it is "Add your Journal" is always active

here you can see we are on home page but active tab is diiferent mean home is not green

Yes @Vishesh-Tripathi let me assign it to you ! please make sure to follow the theme of the application !

sure


TensorFlow is 1.3-7 times slower than Theano for small models

I created a small benchmark (https://github.com/wjaskowski/tensorflow-vs-theano-benchmark) which shows that, depending on the model architecture, Tensorflow is 1.3-7 times slower than Theano depending on the model architecture. The question is whether this effect is due to a design decision or a performance bug, which may be solved in the future?
Related: https://github.com/fchollet/keras/issues/4287 , #5422

@zhangyaobit, please take a look.

One first thing I'd check is that for convolution if NCHW (faster) format or NHWC format is used. To find out the causes of performance discrepancies, you will need to profile Tensorflow and Theano and compare the two in terms of where the time is spent. For TensorFlow, you can use Timeline (http://stackoverflow.com/questions/36123740/is-there-a-way-of-determining-how-much-gpu-memory-is-in-use-by-tensorflow/37931964#37931964) to find out the time breakdown for all nodes/operations in a TensorFlow graph.

I use tf.contrib.layers.convolution2d(input,...), where input is [batch_size, height, width, channels] according to the documentation. Do you suggest that this is wrong, and I should use [batch_size, channels, height, width]?
The code for tensorflow is dead simple:
def create_tf(image_shape, output_dim, layers_conf):
    from tensorflow.contrib import layers

    x = tf.placeholder(tf.float32, shape=[None, image_shape[0], image_shape[1], 1], name="input")
    t = tf.placeholder(tf.float32, shape=[None, output_dim], name="target")

    net = x
    for num_filters in layers_conf[:-1]:
        net = layers.conv2d(net, num_outputs=num_filters, kernel_size=3, stride=3, activation_fn=tf.nn.relu,
                weights_initializer=layers.xavier_initializer_conv2d(), biases_initializer=tf.constant_initializer(0.1))
    net = layers.flatten(net)
    net = layers.fully_connected(net, num_outputs=layers_conf[-1], activation_fn=tf.nn.relu, weights_initializer=layers.xavier_initializer(),
            biases_initializer=tf.constant_initializer(0.1))
    y = layers.fully_connected(net, num_outputs=output_dim, activation_fn=None, weights_initializer=layers.xavier_initializer(),
            biases_initializer=tf.constant_initializer(0.1))
    mean_square_error = 0.5*tf.reduce_mean((y - t)**2)
    optimizer = tf.train.RMSPropOptimizer(learning_rate).minimize(loss=mean_square_error)

    def backprop(x_batch, y_batch):
        optimizer.run({x: x_batch, t: y_batch})

    def fwd_pass(x_batch):
        return y.eval({x: x_batch})

    return fwd_pass, backprop

I am willing to profile it I this could help you. I would not spend time on it, however, if you acknowledge that such performance gap is expected. So is this expected or not?

NHWC is not wrong. I'm just saying it might be a slower option than NCHW. You can try HCHW by adding data_format="NCHW" to layers.conv2d, and change the shape accordingly, and also make sure other ops can accept this format.
The kind of slow down (1.3-7x) is common when it comes to comparing NCHW and NHWC, and might be the reason why it is slower than Theano.
While we are working on hiding this kind of manual tuning from users (e.g. selecting a better data_format for a op and a device), users are still expected to spend time to understand and tune the code to extract the best performance, and the first basic step towards that is profiling.

Btw. TF is ca. 3 times slower than Theano also where the model involves only dense layers (no convolutions).

Could you post the code and the Timeline profiling results?

HCHW did not help. The benchmark code is here: https://github.com/wjaskowski/tensorflow-vs-theano-benchmark. Here are the Timeline results:
1. 128x128 images, 3 conv layers 32 filters each + 128 neurons

timeline-128 128 32 32 32 128.txt
2. 32x32 images, 4 conv layers 32 filters each + 512 neurons

timeline-32 32 32 32 32 512.txt

@wjaskowski, could you make sure you exclude the first few iterations from the benchmark? This is how convnet-benchmark does it.
https://github.com/soumith/convnet-benchmarks/blob/master/tensorflow/benchmark_alexnet.py#L139
In the first round, TensorFlow does autotuning to find out the best algorithm, so it might have more overhead. Following up rounds should not have them. For convnet benchmarks, important things are:

NCHW format
Excluding first few rounds, typically 10.
Make sure your session run didn't fetch anything unnecessarily.

@zheng-xq:

I exclude the first 50 rounds (https://github.com/wjaskowski/tensorflow-vs-theano-benchmark/blob/master/benchmark.py#L74).
I have checked that NCHW improves the results only slightly (as a margin note, I find it strange that you recommend NCHW while NHWC is the default one).
I cannot imagine what unnecessary could I possibly fetch in this simple example.

Looks like your Timeline is a profiling run that tries multiple conv2d implementations to find the best one, rather than a later run that uses the previously found best implementation.
It might be that somehow the benchmark is not written in a standard way, and as a result it is always running the profiling runs.
As you see, each conv layers actually invoked multiple runs:

After this is fixed, you can try NCHW again. Because I'm thinking your previous comparison might be between  NCHW and NHWC in the profiling mode, rather than in the regular mode.

@wjaskowski there's a fixed per-run overhead in TensorFlow which is higher than in Theano, and when your session.run only takes 1.6ms, this overhead is significant. One source of overhead is "crossing TensorFlow/Python" boundary which happens in TF that has C++ runtime, but not Theano which has Python runtime. For your TF experiment, every 1.6ms you release GIL, copy data from Python runtime to C++ TensorFlow runtime, then copy the result back and reacquire GIL. For an op that does no memory transfers and sees no graph modifications , each eval call will add 0.2ms overhead.
TF has been optimized for cases when session run call takes 20ms-2000ms, so these tiny run call scenarios didn't get as much attention, however there are some tricks you can do. For instance to remove the extra Python->TF copy, you can keep the data in tensorflow runtime using variables or queues. To eliminate extra TF->Python copies, you can keep data in tensorflow runtime by doing sess.run(optimizer_node.op) instead of sess.run(optimizer_node) in your loop

I run the benchmark and found out your profiling results is fine, which is an actually a regular run, instead of a profiling run, which I thought earlier it is.
This now indeed looks like a TensorFlow internal issue; the CPU overhead seems high for smaller shapes (32x32) and we will investigate that. We will also look at the performance for NCHW format.

@yaroslavvb I see. Indeed, my first profiling results shows the overhead of fetching the data. When I removed it, TF/TH time ratio decreased to 2-2.5. I also confirm that when the model is larger (e.g. 512 filters, the difference between TH and TF shrinks. E.g., for "128x128 + conv[512,512,256,128] + 512") I got a ratio of 1.5 for forward pass and 0.85 for backprop (i.e. TF is actually faster).
But still, it would be nice to make TF also quick for smaller models. In reinforcement learning, I cannot afford huge models. It is also not so easy to prefetch data to TF since the data are generated on-the-fly (but maybe with the queues?).

@yaroslavvb @wjaskowski +1 regarding the fact that one can't dismiss poor performance for small models just because no one cares about MNIST and CIFAR-10 (and their corresponding small convnets) anymore. The state-of-the-art RL models are rather small and so the importance of adequate performance for small models is still an issue to address for current research and production use cases.

I did more CPU profiling and found that the majority of the CPU overhead is actually from the host code inside the conv op, rather than from the executor. The CPU time is distributed across pre- and post- processing steps such as padding and filter transform, as well as in the cuDNN kernel invocation. There doesn't seem to be a single "performance bug" that could be fixed here, but the overall CPU side of the implementation of conv could be improved.
Conv actually internally converts NHWC to NCHW, so using NCHW directly would avoid the conversion. However, for small models, as the performance is bottlenecked by the CPU code, using NCHW makes little performance difference.
I marked the issue as contribution welcome for interested people to take a deeper look.

@benoitsteiner, here is an interesting example the performance of NCHW and NHWC is about the same, as the CPU is the bottleneck.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

I am using Tensorflow 1.3 and it is %25 slower than MatConvNet, an alternative deep learning library for Matlab. I can fit more batches of data(2x) into GPU in the "MatConvNet" implementation and i think this is one of the most important factor in the performance difference.
In tensorflow implementation, queue runners, multi tower gpu implementation and all best practices are used for getting the best performance.
Tried many different scenarios to improve results such as using different data formats, NHWC and NCHW, allow_growth etc..
I expect Tensorflow is way much faster according to the cumbersome "Matlab" architecture. Currently, TF with python, consumes much more memory and uses GPU less efficient than Matlab alternative. This is very interesting.
Training Data : 2165x5x5x145
Model :
conv2d([1x1, 1200])
relu
conv2d([3x3, 600])
relu
conv2d([5x5, 300])
relu
fc
This issue should be reopened as TF performs worse many other libraries out there regardless of their platforms

There are many cases when TensorFlow is slower than something another framework. Sometimes it's due to user error, sometimes not. A self-contained benchmark would be needed to troubleshoot this correctly.
BTW, queue runners don't have great performance, tf.data should be better

@yaroslavvb if you think the tf.data should close the %25 performance gap between other frameworks, i can try it. But how could you explain the 2x batch size difference between two frameworks ? Is there any hints, data pinning or something like that ?
My comparison is not between top-competitors(Caffe, Caffe2, CNTK, Theano etc..) of the arena. This is a Matlab based third party library not backed by an large scale company or community. Also Matlab is another computation platform which is heavier and slower according other native or managed platforms. I think this issue should be considered more seriously and any inspection regarding such a critical performance issue should not be handled case case but on the overall implementation of the TF library.

@aligokalppeker I do not find it surprising that TensorFlow code may run slower than Matlab for a particular example, TensorFlow gives a lot more opportunities for the user shooting themselves in the foot

@yaroslavvb I think, the your latest comment has been written with no development experience/knowledge on Matlab(or you write such a meaningless thing intentionaly). With such a perspective, decline on TF's performance and quality will continue. This bug is an evidence of such a bad progress; https://github.com/tensorflow/tensorflow/issues/14107
At least they accepted the problem in the bug, they did not bury their heads in to the sand...

"Low-performance" is a bit of over-simplification. Improvements in TensorFlow performance translates directly to datacenter cost savings, so Google spends significant resources in this area. What's happening is that some kinds of computations  are optimized, while others, especially ones small enough to run in Matlab, are not. I think eventually, most computations will be possible to do without incurring high performance/human cost, but what can help in getting there faster is providing self-contained benchmarks that demonstrate the problem.


Add suite of performance tests for Google 3D Photorealistic tiles

Includes 6 locations:

Center Pompidou, Paris, France
Chrysler Building, NYC
Guggenheim Museum, Bilbao, Spain
Zabriskie Point, Death Valley National Park, California
Tokyo Tower, Tokyo, Japan
Googleplex (Google Headquarters)

Matches similar CesiumJS performance test for Google Tiles.

Thanks for the pull request @csciguy8!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.


Tilemap / Tilesset suggestions

Tilemap Usage: SHIFT Selection and META+D should be available as Icons, else nobody knows that this optin exists
Tileset creation: Would be nice if it would be possible to import an Tilemap without having to creat every tile by hand
Tilemap: Would be nice if it would arrange the tiles in that left bar like I arranged them during the creation of the tilemap - also with multiple columns

I also would like the ability to have multiple columns when working with a tile map as using over 250 tiles can be time consuming.
In terms of tile map creation and importing, I have employed gdscript to help me with that.

Closing as duplicate of #843, I'll add a comment there with the contents of OP.


Fix server icon in sign up flow not responding to dark mode

Fixes a bug where an icon didn't respond to dark mode and thus was near impossible to see
Before:

After:

Never fails. Gratzi mozzy


Flutter - material support onLongPress on BottomNavigationBar

the solution out there is adding a gesture detector inside the bar items. this is not clean, and i suggest long press for bottom navigations are valid and adopted ux. so material's BottomNavigationBar should have onLongPress interface provided to developers.
https://stackoverflow.com/questions/56387160/long-press-on-bottomnavigationbaritem

Hi @softmarshmallow ,
There's an open PR that talks about adding tooltip on navigation bar items and mentions that a tooltip will be displayed onLongPress, so I guess onLongPress gesture may well be added along with it.
Do you think your request is similar to this PR ?
Thanks.

only if, that PR is on general purpose for supporting longpress. if it's design is just to add tooltip, then i'll have to request a new PR. I haven't seen detail codes for it, if it provides developer interface right in for longpress slot, then yes. it will do the job.


CSS minification error

Version
2.6.11
Reproduction link
https://github.com/Oluwa-Seun/weatherapp
Steps to reproduce
no steps to reproduce
What is expected?
build complete
What is actually happening?
Cannot read property 'length' of undefined. File: css/app.f76b1c79.css

im new to vuejs so im still trying to understand its enviroment.

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


Gh 856 rest api execute single operation

Codecov Report

Merging #865 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #865      +/-   ##
=============================================
- Coverage      63.41%   63.41%   -0.01%
  Complexity       871      871
=============================================
  Files            440      440
  Lines          12650    12652       +2
  Branches        1476     1476
=============================================
+ Hits            8022     8023       +1
- Misses          4037     4038       +1
  Partials         591      591

Impacted Files
Coverage Δ
Complexity Δ

...a/uk/gov/gchq/gaffer/operation/OperationChain.java
77.58% <ø> (ø)
9 <0> (ø)
:arrow_down:

...n/java/uk/gov/gchq/gaffer/operation/Operation.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...gov/gchq/gaffer/rest/service/OperationService.java
64.44% <0%> (-1.47%)
0 <0> (ø)

.../gov/gchq/gaffer/rest/service/ExamplesService.java
60.51% <0%> (-0.32%)
0 <0> (ø)

...gaffer/rest/service/GraphConfigurationService.java
90.16% <0%> (+1.63%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ee811...4d5c4c2. Read the comment docs.

Could some integration tests be added? This would probably involve adding some utility methods to the RestApiTestUtil class and then adding some new tests to the OperationTestIT class.


'com.pedro.rtpstreamer' has stopped error

Hi there, currently I am working on using your code to create a rtsp stream client to be run in a robot with camera equipped. However, while I am able to open the app in the robot, whenever i press Custom RTSP button to do the streaming of camera feed to rtsp URL, the app crashes, with a error message saying that com.pedro.rtpstreamer has stopped. What can i do in this case? Would like your input on that issue, thank you!

I can't help you like this. I need:

logcat error
If you modified the code I will need code related to the crash


Broken link in documentation

Those links are broken, they show https://litmus.com/unavailable

https://litmus.com/pub/de912ba
https://litmus.com/pub/23497a4
https://litmus.com/pub/2e0aaa0

404
The test results you’re looking for cannot be found
This link may be out of date, expired, or removed by the person who originally shared it.
Litmus is a leading email testing and analytics tool. Check out the homepage for more details."

Same here. I was hoping to look at the demos, sad story.

Sorry about that. It looks like Litmus expired the links at some point. I just regenerated them.
Please excuse the broken Litmus thumbnails, which have the white container background missing in many cases. I've verified by hand that the template works as intended. And if you click on Litmus' larger version, it is fine. I've been told the thumbnail generator may be taking screenshots prematurely…

Single Column
https://litmus.com/pub/f6f088c

Two Columns
https://litmus.com/pub/884c2a3

Three Columns
https://litmus.com/pub/eae4ebf

Awesome, thanks!


New version: VirtusLab.ScalaCLI version v1.0.2

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111913&drop=dogfoodAlpha

@microsoft-github-policy-service agree company="VirtusLab"

Hi @Trenly I have updated the ScalaCLI manifest, by applying your suggestion from code review.

/AzurePipelines run

@wingetbot waivers Add Validation-Executable-Error

Hi @Trenly @stephengillie Do you have time to review this again? Is there a possibility of merging it soon?

@wingetbot run

@wingetbot run


Wasm: align generic context handling in exception catch and filter blocks

Currently Wasm catch funclets get the generic context passed and filter funclets do not get it at all.  To be consistent with the other backends, Wasm should store the generic context in a local in the main funclet, as per comment at https://github.com/dotnet/corert/pull/8125#issuecomment-622962485

Closed via #8149


React.Children.map function signature

Currently documented as: React.Children.map(children, function[(thisArg)])
What's this function[(thisArg)] <--
I don't spend a ton of time in javascript, but I can't find anything that indicates this is what's meant to go here.
The actual signature seems more like:
React.Children.map(children, function, thisArg)

Can you confirm this is still an issue?.

The documentation look ok to me now.

Me too. Since there has been no activity for a long while, let's close the issue for now and re-open it if needed.


Sort more

Sort client by name
Sort issue by status of issue count 0 for incomplete and 1 for complete

Codecov Report

Merging #126 (1291fe6) into master (3420559) will decrease coverage by 0.71%.
The diff coverage is 1.85%.

@@             Coverage Diff              @@
##             master     #126      +/-   ##
============================================
- Coverage     38.80%   38.08%   -0.72%
  Complexity      425      425
============================================
  Files           135      136       +1
  Lines          2608     2657      +49
  Branches        307      313       +6
============================================
  Hits           1012     1012
- Misses         1450     1499      +49
  Partials        146      146

Impacted Files
Coverage Δ

...dress/logic/commands/client/SortClientCommand.java
0.00% <0.00%> (ø)

...address/logic/commands/issue/MarkIssueCommand.java
0.00% <ø> (ø)

...address/logic/commands/issue/SortIssueCommand.java
0.00% <ø> (ø)

...dress/logic/commands/issue/UnmarkIssueCommand.java
0.00% <ø> (ø)

...ess/logic/commands/project/SortProjectCommand.java
0.00% <ø> (ø)

...seedu/address/logic/parser/IssueCommandParser.java
0.00% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
45.45% <0.00%> (-2.42%)
:arrow_down:

...edu/address/logic/parser/ProjectCommandParser.java
26.37% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
37.16% <0.00%> (-3.61%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Refactor SEO tests by removing InlineSnapshot testing

WHY are these changes introduced?
In the lead up to release, I added a lot of tests using toMatchInlineSnapshot. This was helpful for driving the development of features and getting a lot of test coverage in quickly.
However, I don't feel snapshot tests are the right approach. They just end up looking like a mess of text. Failures are hard to understand. Test intentions are hard to understand. I think developers will find themselves updating these snapshots out of either frustration or unintentional clumsiness.
WHAT is this pull request doing?
This PR removes the inline snapshots from the SEO tests and replaces them with more specific assertions directly on the array values we expect to exist.
HOW to test your changes?
Passing CI should be enough.
Post-merge steps

Checklist

[ ] I've read the Contributing Guidelines
[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've added a changeset if this PR contains user-facing or noteworthy changes
[ ] I've added tests to cover my changes

IMHO I would have kept the snapshots since the tests could be painful to change if we move a bit the structure.

Yeah, I think this is part of the problem with snapshots, they are easy and quick. You press a key and all your tests pass.
If you change the structure, you should expect your tests will need to be updated. I think expect.arrayContaining strikes a nicer balance where the outer structure is free to change, but your assertion is still specific and readable.
@Shopify/hydrogen should we form a consensus on this before merging?


Wrong tile generation

Hi,
I'm having issues with some PNGs, it looks like the tile extraction has some problem
:point_right: Download project files: issue2.zip
main.c
#include <genesis.h>

#include "../res/bg.h"

int main(bool hardReset) {
    VDP_setScreenWidth320();
    VDP_setScreenHeight224();
    VDP_setPlaneSize(64, 32, TRUE);

    VDP_drawImageEx(BG_B, &resBgSea, TILE_ATTR_FULL(PAL1, 0, 0, 0, TILE_USERINDEX), 0, 0, FALSE, FALSE);
    VDP_setPalette(PAL1, resBgSea.palette->data);

    while (TRUE) {
        SYS_doVBlankProcess();
    }

    return 0;
}

Source image

Nothing special with this file, just an indexed PNG exported by GIMP
Result

VDP

I'd assume the issue is the bit depth, which GIMP seems to have exported as 2 bits. Opening the picture through Aseprite and exporting it as an indexed png (8-bit depth) made it so that the image loads correctly with SGDK.

Yep, forcing the image to 8bpp solves the issue, so there must be something wrong in the PNG bitstream reading when the samples are stored at 2bpp

yes I've had this problem previously!

It turns out that the PNG file; if it is 4 colors, but it is exported by GIMP and it is not fully compatible, only partially with Rescom.
If the PNG is opened for example with Aseprite and the PNG is saved is 4 colors, again if it works perfectly with Rescom.

Did a bit of digging and it turns out the ImageUtil.java file has a typo specifically on the function that converts 2bpp to 8bpp that rescomp calls.
static byte[] convert2bppTo8bpp(byte[] data)
{
    final byte[] result = new byte[data.length * 4];

    for (int i = 0; i < data.length; i++)
    {
        result[(i * 4) + 0] = (byte) ((data[i] >> 6) & 0x03);
        result[(i * 4) + 1] = (byte) ((data[i] >> 4) & 0x03);
        result[(i * 4) + 2] = (byte) ((data[i] >> 3) & 0x03); <- Should shift by 2 instead of 3
        result[(i * 4) + 3] = (byte) ((data[i] >> 0) & 0x03);
    }

    return result;
}

Adjusting it and re-exporting the rescomp jar fixed the issue.

Did a bit of digging and it turns out the ImageUtil.java file has a typo specifically on the function that converts 2bpp to 8bpp that rescomp calls.
static byte[] convert2bppTo8bpp(byte[] data)
{
    final byte[] result = new byte[data.length * 4];

    for (int i = 0; i < data.length; i++)
    {
        result[(i * 4) + 0] = (byte) ((data[i] >> 6) & 0x03);
        result[(i * 4) + 1] = (byte) ((data[i] >> 4) & 0x03);
        result[(i * 4) + 2] = (byte) ((data[i] >> 3) & 0x03); <- Should shift by 2 instead of 3
        result[(i * 4) + 3] = (byte) ((data[i] >> 0) & 0x03);
    }

    return result;
}

Adjusting it and re-exporting the rescomp jar fixed the issue.

good catch!

Indeed good catch ! Just fixed :) Thanks for pointing it 👍


Update unmute-it.yml

Hey @ellenschwartau,
ich hab deinen Change mal als Pull Request überführt :)
Danke!

Ah nice, danke!

Von: Andy Grunwald @.>
Gesendet: Wednesday, January 25, 2023 10:22:22 PM
An: EngineeringKiosk/GermanTechPodcasts @.>
Cc: Ellen @.>; Mention @.>
Betreff: Re: [EngineeringKiosk/GermanTechPodcasts] Update unmute-it.yml (PR #225)
Merged #225https://github.com/EngineeringKiosk/GermanTechPodcasts/pull/225 into main.
—
Reply to this email directly, view it on GitHubhttps://github.com/EngineeringKiosk/GermanTechPodcasts/pull/225#event-8358815714, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLLTR6OTRFMLAMY3AON5C3WUGKQ5ANCNFSM6AAAAAAUGZTLTE.
You are receiving this because you were mentioned.Message ID: @.***>


Added SparkVM bytecode language

This Pull request adds SparkVM Bytecode language which ends in .spvm or .spc
Checklist:

[ ] I am adding a new extension to a language.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[x] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar: [URL to grammar repo]

[x] I have added a color

Hex value: #00f8fc
Rationale: It was randomly chosen also I like aqua

[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: [URL to grammar repo]
New: [URL to grammar repo]

[ ] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

This appears to be a very new project with very little use which is a very long way from meeting our usage requirements. I doubt this will be met anytime soon so I'm closing this PR. Feel free to submit a new PR once usage has increased.


Patch release needed

Hi @thysultan
Could you release a new patch version that includes fix https://github.com/thysultan/stylis.js/commit/7fa14f99eb8e4c6f7f298e9fc47eef95b72f7740. It has been a while since this PR was merged and it would be great if the author of @emotion could fix the regression in his project but we need a version bump. Thank you :)

Done! 4.0.7 published

Done! 4.0.7 published


[PowerToys Run] A way easy to update powertoys run's Environment

📝 Provide a description of the new feature
I want that get a easy way to updating powertoys's Environment when I added or changed a key-value in system env.
I am a VS coder user, when I add a new tool's path or other in envrionment. I need restart VS coder reinject env, so I closed the VS Code, popup 'Powertoys Run', and  key in 'code'. You known the new vs code environment by the PowerToys last, and terminal not found.
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
---I expected the proposed feature like key in PT Run a cmd as 'reload env' or 'restart app' or I need do nothing where it works. :smiley:
If you'd like to see this feature implemented, add a 👍 reaction to this post.

Tracked with #6367


change SteamApps to steamapps for windows

Trying to improve windows compatibility, I assume you don't use windows (which honestly I understand) so the crate doesn't currently work on windows unfortunately, there is also another issue that I will raise soon, but unfortunately that one is more complicated and annoying and I don't have a simple solution to it.
PS: thanks for making this crate, it's exactly what I was looking for in terms of ease of use and I hope you continue to maintain it.

Oh, in that case it must just be #2, I stumbled into this while looking into that so I assumed this would also be an issue, my bad.


Remove Apifox.Apifox 2.5.1 to Ruihu.Apifox 2.5.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: http://cdn.apifox.com/download/2.5.1/Apifox-2.5.1.exe
Status Code: 200
(Automated message - build 869)

URL: http://cdn.apifox.com/download/2.5.1/Apifox-2.5.1.exe
Status Code: 200
(Automated message - build 869)


Add: hook-scripts.

Signed-off-by: DTadrzak<EMAIL_ADDRESS>

@Quentin-M

Should we push these commits to #142 (compute_deployment branch) directly instead?

Thanks! It looks pretty good. It seems that they all share a lot of code, I wonder if we could make that one script and have a command to select which behavior it should have. It would help us keep the number of templates / number of config maps / code to maintain low.

Cherry-picked into #142


[Bug]: landing page issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Landing page messes up
https://github.com/user-attachments/assets/f02146c7-e303-4bd7-b20b-31338c2d056c
Add Screenshots
Please add hactoberfest and GSSoC24 tag. You can assign me for this issue.
What browsers are you seeing the problem on?
Chrome
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

#199


Add chained interceptors

Exactly the same as those in grpc-go, to the point I've copied some of their code. Put it in a separate source file to be clear on the license (Apache for that code, ours is MIT)

@rhysavos good now? :)


Disable Catalog Build and Run

Changes
Temporarily disabling the catalog build and run test.
This will unblock contributions that currently fail due to failures
running opm index add.
Stop-gap until we fully fix #57
/kind cleanup
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE

/lgtm

/approve
Self-approving

@SaschaSchwarze0 I've added the issue to our next milestone. Yes, we should fix for our next release.


Getting into an infinite redirect loop when integrated with Azure AD

I am getting into a very interesting state when I try to integrate with Azure AD in an ASP.NET 5 application. I have it working locally but when I deploy to azure web sites, it goes into an infinite redirect loop. It is a single instance Azure Web App and running on DNX 1.0.0-beta4-11532.
I am looking at the azure web app logs and it seem this (roughly, not the whole log):

GET / -  302 0 0 1309 800 16293
POST / - 302 0 0 1240 4950 62
GET / - 302 0 0 1309 912 64
POST / - 302 0 0 1240 4950 15

My guess is that this has something to do with data protection but not sure.
Startup class:
public partial class Startup
{
    private readonly IConfiguration _configuration;
    private readonly IHostingEnvironment _env;

    public Startup(IHostingEnvironment env)
    {
        if (env == null)
        {
            throw new ArgumentNullException("env");
        }

        _env = env;
        _configuration = new Configuration()
<EMAIL_ADDRESS><EMAIL_ADDRESS>            .AddEnvironmentVariables("Confidence_");
    }

    // For more information on how to configure your application, visit http://go.microsoft.com/fwlink/?LinkID=398940
    public IServiceProvider ConfigureServices(IServiceCollection services)
    {
        services.AddDataProtection();
        services.Configure<AppOptions>(options =>
        {
            options.ServeCdnContent = Convert.ToBoolean(_configuration.Get("App:ServeCdnContent"));
            options.CdnServerBaseUrl = _configuration.Get("App:CdnServerBaseUrl");
            options.GenerateLowercaseUrls = Convert.ToBoolean(_configuration.Get("App:GenerateLowercaseUrls"));
            options.EnableBundlingAndMinification = Convert.ToBoolean(_configuration.Get("App:EnableBundlingAndMinification"));
            options.LatestCommitSha = _configuration.Get("git:sha");
        });

        services.Configure<AppMongoOptions>(options =>
        {
            options.DatabaseName = _configuration.Get("Mongo:AppDatabaseName");
            options.ConnectionString = _configuration.Get("Mongo:AppConnectionString");
        });

        services.Configure<ExternalAuthenticationOptions>(options =>
        {
            options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
        });

        services.AddMvc();
        services.AddCaching();
        services.AddSession();

        IContainer container = CreateAutofacContainer(services);

        return container.Resolve<IServiceProvider>();
    }

    public void Configure(IApplicationBuilder app)
    {
        // Add the following to the request pipeline only in development environment.
        if (string.Equals(_env.EnvironmentName, "Development", StringComparison.OrdinalIgnoreCase) == false)
        {
            // Add Error handling middleware which catches all application specific errors and
            // send the request to the following path or controller action.
            app.UseErrorHandler("/Home/Error");
        }

        ConfigureAuth(app);

        app.UseStaticFiles();
        app.UseMvc(routes =>
        {
            routes.MapRoute("areaRoute", "{area:exists}/{controller}/{action}");
            routes.MapRoute("defaultRoute", "{controller=Home}/{action=Index}");

            routes.MapRoute(
                "controllerRoute",
                "{controller}",
                new { controller = "Home" });
        });
    }

    private IContainer CreateAutofacContainer(IServiceCollection services)
    {
        var builder = new ContainerBuilder();
        AutofacRegistration.Populate(builder, services);
        builder.RegisterAssemblyModules(Assembly.GetExecutingAssembly());

        return builder.Build();
    }
}

public partial class Startup
{
    private static string Authority = string.Empty;
    private static string ClientId = string.Empty;
    private static string AppKey = string.Empty;
    private static string GraphResourceId = string.Empty;

    public void ConfigureAuth(IApplicationBuilder app)
    {
        Authority = string.Format(_configuration.Get("AzureAd:AadInstance"), _configuration.Get("AzureAd:Tenant"));
        ClientId = _configuration.Get("AzureAd:ClientId");
        AppKey = _configuration.Get("AzureAd:AppKey");
        GraphResourceId = _configuration.Get("AzureAd:GraphResourceId");

        // Configure the Session Middleware, Used for Storing Tokens
        app.UseSession();

        // Configure OpenId Connect Authentication Middleware
        app.UseCookieAuthentication(options =>
        {
            options.SessionStore = new MemoryCacheSessionStore();
            options.AutomaticAuthentication = true;
        });

        app.UseOpenIdConnectAuthentication(options =>
        {
            options.AutomaticAuthentication = true;
            options.ClientId = _configuration.Get("AzureAd:ClientId");
            options.Authority = Authority;
            options.PostLogoutRedirectUri = _configuration.Get("AzureAd:PostLogoutRedirectUri");
            options.Notifications = new OpenIdConnectAuthenticationNotifications
            {
                AuthenticationFailed = OnAuthenticationFailed
            };
        });
    }

    private Task OnAuthenticationFailed(AuthenticationFailedNotification<OpenIdConnectMessage, OpenIdConnectAuthenticationOptions> notification)
    {
        notification.HandleResponse();
        notification.Response.Redirect("/Home/Error?message=" + notification.Exception.Message);
        return Task.FromResult(0);
    }
}

project.json file:
{
    "webroot": "wwwroot",
    "version": "1.0.0-*",
    "dependencies": {
        "Confidence.Domain": "",
        "Kestrel": "1.0.0-beta4-*",
        "Microsoft.AspNet.Server.IIS": "1.0.0-beta4-*",
        "Microsoft.AspNet.Mvc": "6.0.0-beta4-*",
        "Microsoft.AspNet.Diagnostics": "1.0.0-beta4-*",
        "Microsoft.AspNet.StaticFiles": "1.0.0-beta4-*",
        "Microsoft.AspNet.Hosting": "1.0.0-beta4-*",
        "Microsoft.AspNet.Server.WebListener": "1.0.0-beta4-*",
        "Microsoft.Framework.ConfigurationModel.Json": "1.0.0-beta4-*",
        "Microsoft.Framework.Caching.Memory": "1.0.0-beta4-*",
        "Microsoft.AspNet.Session": "1.0.0-beta4-*",
        "Microsoft.AspNet.Authentication.Cookies": "1.0.0-beta4-*",
        "Microsoft.AspNet.Authentication.OpenIdConnect":  "1.0.0-beta4-*",
        "Microsoft.IdentityModel.Clients.ActiveDirectory": "3.1.203031538-alpha"
    },
    "frameworks": {
        "dnx451": {
            "dependencies": {
                "MongoDB.Driver": "2.0.0",
                "Microsoft.Framework.DependencyInjection.Autofac":  "1.0.0-beta4-*"
            }
        }
    },
    "commands": {
        "web": "Microsoft.AspNet.Hosting --server Microsoft.AspNet.Server.WebListener --server.urls http://localhost:5005 --server.urls https://localhost:44300",
        "kestrel": "Microsoft.AspNet.Hosting --server Kestrel --server.urls http://localhost:5005"
    },
    "publishExclude": [
        "node_modules",
        "bower_components",
        "**.kproj",
        "**.user",
        "**.vspscc"
    ],
    "exclude": [
        "wwwroot",
        "node_modules",
        "bower_components"
    ],
    "scripts": {
        "postrestore": [ "npm install", "bower install" ],
        "prepare": [ "gulp clean", "gulp" ]
    }
}

We just added some logging that may help. Can you turn on logging and show what is going on?

Does the latest work on the runtime I am on: 1.0.0-beta4-11532?

It's checked into the dev branch, I can build and run against that.

Cool, thx for this! I will give this a go shorthly.

@brentschmaltz I figured out what was going wrong and didn't have try logging (but logging is always good! :smile:)
I was only getting into this redirect loop when I visited the application without HTTPS. I am guessing it has something to do with cookie and its secure flag. I could be mistaking.
I forced HTTPS on my application through an IIS URL Rewrite rule an the problem is solved. I would say this is not a problem on OpenId Connect middleware but could be something that can be documented. Thanks for the help!

@tugberkugurlu that's one of the the most reasons for the redirect loop (also with the katana middleware)

I'm late to this party, but thought I'd add for anyone else who happens along that this isn't an ASP 5 issue. The same thing happens with the current shipping version of MVC.

I had the same problem and my solution was this:
            // (...)
            app.UseCookieAuthentication(new CookieAuthenticationOptions
            {
                AuthenticationScheme = "cookies",
                AutomaticAuthenticate = true,
                CookieName = "AuthenticationCookie",
                // if this is "always" we get a infinite loop when authentication on HTTP (HTTPS is fine)
                CookieSecure = CookieSecurePolicy.SameAsRequest
            });

Thanks @tugberkugurlu you saved my day! I would never have though the problem would be on this line!!

That said, authenticating over HTTP is a terrible idea...

yes @Tratcher .
I forgot to mention that HTTP is "runs on my machine". I'm still setting up the authentication code.

I am also having this issue when trying to access an MVC app written in the full .net framework 4.6 on azure websites (XXX.azurewebsites.net) with Azure AD auth. I published a web forms app instead and it works just fine. :(

How would you set CookieSecure = CookieSecurePolicy.SameAsReq in case of JWT?
app.UseJwtBearerAuthentication(new JwtBearerOptions()
            {
                Authority = ientityServerUrl,
                Audience = ientityServerUrl,

                AutomaticAuthenticate = true,
                AutomaticChallenge = true,
                RequireHttpsMetadata = false,

                TokenValidationParameters = new TokenValidationParameters()
                {
                    ClockSkew = TimeSpan.Zero,
                },
            });

@kuncevic None of this applies to JWT.
Your ConfigureCookieAuthentication is adding a duplicate cookie handler. The original is added via UseIdentity, so if you want to configure it you do this: https://github.com/aspnet/Identity/blob/rel/1.1.2/samples/IdentitySample.Mvc/Startup.cs#L52

I've mdified my Web.config with this, and all is good now:
<system.webServer>
      <rewrite>
     <rules>
       <rule name="Redirect to https">
         <match url="(.*)"/>
         <conditions>
           <add input="{HTTPS}" pattern="Off"/>
         </conditions>
         <action type="Redirect" url="https://{HTTP_HOST}/{R:1}"/>
       </rule>
     </rules>
   </rewrite>
 </system.webServer>

@lukastheiler That did it for me! Thank you!

This problem is infuriating. I am using Visual studio 2017 and have deployed the changes above to an azure website. After deployment everyone can login fine. The next day, visit the same site and the redirect keeps happening. I have checked to ensure the changes were deployed using websitename.csm.azurewebsites.net and the correct config and azure AD settings are present.

It's pretty strange for the behavior to change like that. Can you share a Fiddler trace?

@TheMasterPrawn were you able to resolve your problem?  I have a similar problem

I implemented the web.config as above. I had the same problem, so I implemented the change detailed in http://katanaproject.codeplex.com/wikipage?title=System.Web response cookie integration issues&referringTitle=Documentation to manage cookies. The app has been working fine for a few months now with no complaints.

Thanks for replying @TheMasterPrawn.  My problem turned out to be that I had the authentication cookie set to SameSite = SameSiteMode.Strict, I changed it Lax and all is good.  And, my problem occurred with Chrome.

##Solved by using Never option for CookieSecureOption##
app.UseCookieAuthentication(new CookieAuthenticationOptions()
            {
                CookieSecure = CookieSecureOption.Never
            })

That's concerning. You've downgraded your security. Were you able to capture a Fiddler trace of the issue?

Hi Chris.
we have since Migrated the app to Okta.
regards,
Rob

From: Chris Ross<EMAIL_ADDRESS>Sent: 03 May 2018 12:57
To: aspnet/Security
Cc: Rob Allen; Mention
Subject: Re: [aspnet/Security] Getting into an infinite redirect loop when integrated with Azure AD (#219)
That's concerning. You've downgraded your security. Were you able to capture a Fiddler trace of the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FSecurity%2Fissues%2F219%23issuecomment-386270913&data=02|01||f8188005022d4caec12408d5b0ed05e2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636609454395526199&sdata=ZqQueZ04%2BXxdt8XoJPSfiQro0uhHAQf8Y60XnIJPWus%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHfB3_2R0vme1l5CJSRB6RAB8CwneV6Bks5tuvCegaJpZM4ECoA0&data=02|01||f8188005022d4caec12408d5b0ed05e2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636609454395526199&sdata=A9SfevYKqCpe7Hj46KgQtFKfKKcGqRp43EHa%2BMkddaA%3D&reserved=0.


The link to the Zup Open Source Forum in the README.md file appears to be broken

What happened:
The link to the Zup Open Source Forum in the README.md file appears to be broken. When clicking on the link, I am not redirected to the forum.
What you expected to happen:
I expected to be redirected to the Zup Open Source Forum when clicking on the link.
How to reproduce it (as minimally and precisely as possible):

Open the README.md file
Navigate to the sentence "If you have any questions or ideas, let's chat in our Zup Open Source Forum."
Click on the link to the forum

Anything else we need to know?:
Here is the snippet with the issue:
If you have any questions or ideas, let's chat in our Zup Open Source Forum.
You can find this in the README.md file in this repository.
Environment:

Horusec version (use horusec version): Not applicable
Operating System: Not applicable
Network plugin / Tool and version (if this is a network-related / tool bug): Not applicable
Others: Not applicable

I think the forum is down :/


Content view not working in table action

Following the instructions in the documentation, I tried to create a simple view

Sale No.

And it didn't work, and when I tried to pass 'record' it didn't work either... This happens in Tables\Actions\Html2MediaAction, do you have any recommendations on what can be done? The current code is below:
Html2MediaAction::make('print')
      ->content(
          fn ($record) => view('invoice')
      )

https://github.com/user-attachments/assets/3309aa0a-6f5a-457a-8ab3-2c061c4b735b
My project is already underway, I put it in and did exactly the same as the demonstration, I can send you what is generated in DevTools but no error or warning is displayed.

@torgodly  I discovered the problem! When "darkmode" is active and in dark mode, the letters and other information do not work... I still haven't found a way to solve the "problem" itself, but I believe this is a point to be observed!

Sure, I can test it! I will run it and review it, as I advised about darkmode, I took the opportunity and opened a new issue so as not to fall into limbo, I will test it in other browsers and see if the problem persists.

I discovered the problem! When "darkmode" is active and in dark mode, the letters and other information do not work... I still haven't found a way to solve the "problem" itself, but I believe this is a point to be observed!

Thanks so much for catching that! It looks like dark mode styles are indeed causing the issue with rendering. I’ve found a solution and will be working on a patch to fix this as soon as possible. Really appreciate your patience and for bringing this to my attention!


Can't delete product or un-feature them on my homepage.

When I try to delete a product, it raises an error saying :"Cannot delete record because of dependent order_items"

This is normally if you have a product which has been ordered

Okay but I shipped it and I don't wish to feature it on my website anymore ;).

I don't know how @adamcooke or @andretanguy does it. I would guess you could just set the item as 0 stock to hide it from the shop?

That's what I thought too but it doesn't seem to work

So any of you guys can help me on that? As a reminder, I can delete a product from my catalog if it's not ordered but I can't delete it if it has been ordered and even if it's shipped. Do you have a way to set the orders to 0 or a method for me to delete a product from the catalog?

I could probably add soft delete
On Mon, 29 Jun 2015 at 16:45 Marc Debnicki<EMAIL_ADDRESS>wrote:

So any of you guys can help me on that? As a reminder, I can delete a
product from my catalog if it's not ordered but I can't delete it if it has
been ordered and even if it's shipped. Do you have a way to set the orders
to 0 or a method for me to delete a product from the catalog?
—
Reply to this email directly or view it on GitHub
https://github.com/tryshoppe/shoppe/issues/216#issuecomment-116737915.

That'd be great ;)

FYI - we hide any products from the frontend where it's out of stock (stock level == 0). This is because we don't want to deal with product backordering, but i'm sure there is a more elegant way to achieve this.
You could consider using acts_as_deleted or similar to avoid destroying the product if you're no longer going to sell it, but that might be way too overkill considering the vision of Shoppe.
From a data perspective, even if the product has been shipped, there is a sales record with a link to that product. I'll have to check on how @adamcooke has this setup, but my preference would be to consider something like:

Add a flag to each product (e.g. on_sale)
In your products_controller.rb, when listing all products in a category, include only those products where on_sale == true
In the Shoppe backend, have a separate table for 'products not on sale' that sits underneath the existing 'products' table.


protocol fee not applied to resolved Q_purchased_asset AMM state

Single Swap Verification
Q-1 state (result of r2 purchase) does not account for the fee

I do not believe this is a bug, I believe the test was not accounting for the Lerna that is minted to the asset j pool when the asset fee is added back to the pool.
I will copy the notebook and check in a version with a corrected test illustrating the correct math.

@matttyb80 In b8096b60a7d00975f464398fb1ddd4f4fac71d23 I checked in a slightly modified version of your sheet, which I fixed with the correct hub token/Lerna accounting for the second pool. The Lerna fee is correctly decreasing how much Lerna gets traded into pool 2, and this is all being accounted for all the way through the asset being traded out of the pool.
Then, the asset fee is applied and the fee amount is added back to the pool, and Lerna is minted to maintain the price. This minting is where the extra Lerna was coming from, and it is correct. You will find that the amount you were seeing was not actually exactly the same as if the fee_HDX had been zero, but was very close since fee_HDX and fee_assets were identical and low.
Note that the test doesn't quite pass in my notebook either, but the values match to 9 decimals which probably indicates that it's correct... I usually use pytest.approx in the hypothesis tests due to this type of rounding error.
Let us know if this doesn't look correct to you, or if there's some inconsistency between this explanation and the specs.

I continued the verification test in the notebook to include the lerna. I did this concurrently, so I had just posted an update to the  above notebook Single Swap + Lerna without seeing this.
There is still some difference in the Q-1 amount (6 tokens) between computed and expected. Will look to see if this is rounding or fee or order of resolution.

I believe "new_Q_1" depends on the incorrectly calculated delta_qj so applying my fix from SingleSwap_Colin will probably fix it.

@matttyb80 can this be closed?

yes, this is now resolved


Installation issues.

While following the instructions on docker from source I came across a few problems.

On the line docker build -t "pash/18.04" . I need to add the -f flag with the path to the Dockerfile (./docker/ubuntu/Dockerfile)
There is no /pash in the docker container, there however is /opt/pash
pa.sh does not run in the container as it cannot find pexpect. The workaround I used is to remove the usr/local/lib/python3.6/dist-packages folders from python_pkgs and place their content in the python_pkgs folder.
Before the previous step and after, running pa.sh gives the following error:

Error: Maximum retries: 100 exceeded when waiting for daemon to bind to socket!

I made two pull requests for the doc changes. I will not touch the folder structure as I'm unsure as to how to do that properly (without messing other parts up).

Hey @valuta1995 . Thank you for your feedback and your PRs. Could you try signing your commits with:
git commit -s -m 'git message' to pass the DCO test?
You may find additional information here for the #435 PR

I used the editor on github, which does not play well with DCO, so I made a new request through cli.

Hi @valuta1995! Thanks a lot for letting us know of these issues. Me and @dkarnikis will try to debug maximum retry error as soon as possible. We are drowning in work though so it might take a few days!

This PR #439 should address the maximum retries issue. We will try to automatically fix the python_pkg issue in the next few days but for now you should be good to go.

To quickly verify I installed netcat-openbsd (sudo apt install netcat-openbsd) manually in the container. This worked. Thank you for your help!

#440 Should fix the python_pkg issue. Could you verify if it works for you as well?


Upgrade jetty to 9.3.14.v20161028

Coverage remained the same at 82.325% when pulling cf1ffa412cb157f1ebe4b1a948864874b2cb5ad4 on tjcutajar:upgrade_to_jetty_9.3.14.v20161028 into 7696a91c311daa2153aaf48456684638e3af82fa on dropwizard:master.

Thanks!

Coverage remained the same at 82.325% when pulling cf1ffa412cb157f1ebe4b1a948864874b2cb5ad4 on tjcutajar:upgrade_to_jetty_9.3.14.v20161028 into 7696a91c311daa2153aaf48456684638e3af82fa on dropwizard:master.


fix: refactor get page

fix: refactor get page using the newly included GraphQL type with GraphQlQueryResponseData

I might be missing something here, but is this primarily reformatting? I don't spot any logic/wider structural changes.
Happy to approve (after #2), just want to check I've understood it correctly.

Yeah some formatting - but that's around where I induced the missing GraphQL type (GraphQlQueryResponseData) which sorted out a bunch of warnings.

I see you've updated this PR from a draft to ready for review. Leaving this comment to flag I'm assuming this means 'ready for review pending #2, which is in a draft status' and thus I'm gonna wait on that one.
Please let me know if I'm incorrect here! :)

Hey sorry @domdomegg I've become super busy all of the sudden! This PR can be merged at any time if you're happy with it, it doesn't actually depend on #2 which I might even cancel and start fresh at some point.


Old Gazebo Plugins package

Just curious why it was deprecated

The name of the package was changed to a less generic one. As a result, the new package is now available as a debian package for kinetic, melodic, and noetic.


Stores news in a database

I see you have written code for database usage, but on download news articles you save it to text files. Is there a reason you havent yet implemented the code for sqlite db you wrote ?

The latest commit stores the news and headlines in a database using sql.


⚠ Bofrost.fr has degraded performance

In bf7283b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1197 ms

Resolved: Bofrost.fr performance has improved in 6bd8510 after 6 minutes.


Phaser.Text.fixedWidth/fixedHeight behaviour

Would it be possible to add some scaling options on Phaser.Text objects if fixedWidth and/or fixedHeight is set to control how the text should behave in relation to these values?
I'm currently using this in my own class that extends Phaser.Text:
if (this.displayWidth> this.maxWidth){
    this.displayWidth = this.maxWidth;
    this.scaleY = this.scaleX;
}

Which would shrink the text to make it always fit in a specified width. But it would be nice if I could do something like this:
const text = scene.add.text(0, 0, "Hello world", {
    fixedWidth: 100,
    scaleMode: Phaser.Types.blahblah.SCALEDOWN
});

Thank you for opening this feature request (all those months ago!). As the development of Phaser 4 has now started I am tidying-up the repo and closing off old issues that won't be directly fixed or implemented in Phaser 3 by me. I would still consider community PRs that address this issue, however, and have left the GitHub tags intact so others can track them if they wish to get involved. However, I'm afraid this is no longer a feature that will be added to v3.


Unable to sync data properly on older versions of iOS such as 14.8.

First of all, thank you for your work. As the title suggests, the plugin cannot run on older systems such as iOS 14.8. I have jailbroken my phone and am unable to update the system. Can you help solve this problem?
Abstract
Unable to sync ios with self hosted couchdb, even though sync works for linux and macos.
Expected behaviour
remote database gets installed to iphone
Actually happened
The connection to the database seems to be fine. Connection check results in success.
OneShot sync begins, but no files appear to be pulled.
"Looking for the point last synchronized point message" gets logged, nothing happens after that.
When clicking replication button, message shows that replication is already in progress
Reproducing procedure
Press fetch and replace local db button on ios.
Plug-in log

Plug-in log
2023/ 11/30 上午7：37:01->loading plugin
2023/11/30 上午7：37:01->Self-hosted Live
Sync 70. 21.2 0.21.2
2023/11/30 上午7：37:01->waiting for read
Y...
**2023/11/30 上午7：37:01->CompileError:Web
Assembly . Module doesn't parse at byte 9
0: references are not enabled, in funct
ion at index 3**
2023/11/30 上午7：37:01->0pening Database
2023/11/30 上午7：37:01->Database is now
ready.
2023/11/30 上午7：37:01->Initialize and C
hecking database files
2023/11/30 上午7：37:01->Checking deleted
files
2023/11/30 上午7:37:01->Updating databas
e by new files
2023/11/30 上午7:37:01->UPDATE DATABASE

Maybe the problem is here : CompileError:Web Assembly . Module doesn't parse at byte 90:references are not enabled, in function at index 3
Same as #335 ，But I can't upgrade my system due to jailbreaking.

1.The application is deployed on QNAP NAS, with Nginx (https) used as a reverse proxy and FRP mapping done through a VPS on the public network.
2. Here is the verbose version

Thank you for opening the issue! I understood the situation!
Possibly we can use some native function for fallback implementation, If we sacrifice a bit of performance.
Fortunately, we have added a configuration for hash algorithm, recently. We can add a native one too.
Would you mind if I ask you to try the next version, please?

Sad , I'm considering using Syncthing for synchronization, but the user experience of Syncthing on the iOS platform is not that great.

same error，I think it's hard to get a fix.

I am also using syncthing, there is a gui version called mobius sync. It works with filza. All you need to do is create a soft link to the obsidian database in the documents  of mobius sync.

Sad , I'm considering using Syncthing for synchronization, but the user experience of Syncthing on the iOS platform is not that great.

same error，I think it's hard to get a fix.

I am also using syncthing, there is a gui version called mobius sync. It works with filza. All you need to do is create a soft link to the obsidian database in the documents of mobius sync.

Thank you, I have switched to the new version of the iOS app, which now supports selecting shared directories from other apps without the need for soft link. (The only issue is that it cannot sync in the background, but it's running well otherwise. It's just a minor problem.)

Hi! It is a relief to know that everyone is not in fatal trouble.
However, I am not sure why the fallback implementation does not work well.
I know that you are not having so much trouble while using other solutions, but would you please enable the verbose log and let me see the log? And, if the verbose log is enabled and no such errors are shown, actually it may take some time, especially in the first replication.

@xtpcool Oh, I found a bit of interesting output in the logs. Your Self-hosted LiveSync seems to suspend database reflection.
While rebuilding, Suspend database reflection and Suspend file watching are disabled automatically.
If your (re)building procedure has failed, These configurations might be kept disabled unintendedly.
Would you please disable them like below, and try again?

哦，我在日志中发现了一些有趣的输出。您的自托管 LiveSync 似乎暂停了数据库反射。在重建时，并自动禁用。如果（重新）生成过程失败，则这些配置可能会无意中保持禁用状态。请您像下面这样禁用它们，然后重试吗？Suspend database reflection``Suspend file watching

I have tried it and there was no other response. Below is the log with verbose mode enabled. The last few lines show that there was no log output after syncing a few files.


Add Japanese translations for general strings

This issue is to add Japanese translations for the existing strings found in https://github.com/devadvance/terminalcheatsheet/blob/staging/_data/translations.yml
Use ja (the locale code for Japanese) as the key for the strings. Please comment on this issue before starting work so people are informed that you are working on it.

Hi, I would like to translate the Japanese text. Can you assign this to me? Thanks!


Sending a message

Prerequisites

[X] I checked the documentation and found no answer to my problem
[X] I checked the existing issues and made sure there are no similar bug reports

Category
Bug (unexpected behavior)
Expected Behavior
During an on_query response from the agent, the agent should be able to send a message to another agent before returning from the query.
Observed Behavior
When trying to send a message to another agent, the output says "Outgoing Message '<class (class name)>' is not a valid replyto received message: model: 67cef9c4eca7f098383d7edefe3670815ba8b11d05b25c550d85a66a2cd0f31c"
To Reproduce
https://fetch.ai/docs/examples/intermediate/react_example
Follow these steps except within the on_query handler add a "variable = await send(new_agent_address, message)" which tries to send a message to another agent's on_message handler.
Version
0.15.1
Environment Details (Optional)
requirements.txt very similar to that on https://fetch.ai/docs/examples/intermediate/react_example

Failure Logs (Optional)
Outgoing message '<class 'protocols.query.QueryTableRequest'>' is not a valid replyto received message: model:67cef9c4eca7f098383d7edefe3670815ba8b11d05b25c550d85a66a2cd0f31c

Additional Information (Optional)
No response

This sounds like the second incoming message is not getting a fresh context for some reason, and instead contains the first message as the one being replied to. What do you think @Archento?

If you read the output carefully you'll see that indeed the message you're trying to send is not part of the replies set that this handler has registered.
"Outgoing Message '<class (class name)>' is not a valid reply to received message: model: 67cef9c4eca7f098383d7edefe3670815ba8b11d05b25c550d85a66a2cd0f31c"
If you want to send a message from within a message handler to another agent (either on_message or on_query) please make sure that either:

the replies parameter in the handler definition includes your desired message, or
you omit the replies parameter to bypass outgoing message validation.

Example from the docs:
@NewsAgent.on_query(model=NewsRequest, replies={NewsResponse})  # <-- "replies" parameter
async def query_handler(ctx: Context, sender: str, msg: NewsRequest):
    ...