[Feature Request] Translation in Anki cards

Currently, Game2Text allows you to push the sentence to an Anki card, with the "Sentence" Value, see Screenshot below.
It would be useful, if also the translation as returned by a Translation service could be included as well, which would fit the "Sentence - English" field of my Anki Card layout.
Technically I hear it to be counter productive to learning when you have an automatic translation and I don't use auto translations either, but it seems a bit of an oversight to not supply that information, considering that Game2Text produces it.
(Of course this information is returned asynchronously at a later time and services like Deepl block free users during peak times, so I imagine this is a bit of a headache to implement)

bump


Move and Clone elements from the same list

Hello,
I have 3 List. Client is supposed to drag elements from list A to B and C. Would it be possible to clone elements when user drag from list A to B, BUT move it (remove from A) when user drags from A to C?
I was trying to always clone elements, and remove it manually from list A if needed, but after upgrading to React 15 it throws an error.
Best Regards,

You can try the following configurations. It works from my side.
List A:

Set pull to true instead of 'clone'

<Sortable
    options={{
        group: {
            name: 'sortable-group',
            pull: true,
            put: false
        }
    }}
>
// Render List Items A
</Sortable>

List B:

Update listItemsB

<Sortable
    options={{
        group: {
            name: 'sortable-group',
            pull: false,
            put: true
        }
        onChange={(items) => {
            this.setState({ listItemsB: items })
        }}
    }}
>
// Render List Items B
</Sortable>

List C:

Use lodash's difference method to return an array of filtered items
Update listItemsA and listItemsC

<Sortable
    options={{
        group: {
            name: 'sortable-group',
            pull: false,
            put: true
        }
        onChange={(items) => {
            this.setState({
                listItemsA: _.difference(this.state.listItemsA, items),
                listItemsC: items
            });
        }}
    }}
>
// Render List Items C
</Sortable>


Create iit.txt

Istituto Italiano di Tecnologia - public research institution

@joaobimbo Could you please give us a link to a page on the official institute website where an IT-related long-term (>1 year) course is offered by the institute?

@joaobimbo You might miss my previous comment. Please reply.

Hi,
https://iit.it/institute-header/facts-and-figures
On the bottom there's the percentage of phd students (it's a 3-year programme in Italy). There are, among others, programmes in robotics, computer vision and machine learning.

@joaobimbo Thank you for the clarification! Pull request merged.


Updates to GitHub Enterprise Agreement - Spring 2019

This update to the Enterprise Agreement includes a few changes for clarification, including changes to the following sections:

Section A

Definitions
Termination

Section B

Definitions
Enterprise Server Software License Grant
Enterprise Server Software License Restrictions
Subscription License Assignment
Delivery

Section C

Corporate Requirements

These changes will take effect on May 1, 2019.

These changes will take effect on May 1, 2019.

took effect - merging a bit late 😉


Increasing Coverage V0.5

Coverage increased (+0.3%) to 88.554% when pulling e67de5c110153eb87d6ac46c66621a5b847f931c on joelleejh:v0.5 into 49719afaa589f2ebf34586bddcec48ebae06f175 on CS2103JAN2017-T11-B1:V0.5.

Coverage increased (+0.3%) to 88.554% when pulling e67de5c110153eb87d6ac46c66621a5b847f931c on joelleejh:v0.5 into 49719afaa589f2ebf34586bddcec48ebae06f175 on CS2103JAN2017-T11-B1:V0.5.

Coverage increased (+0.3%) to 88.55% when pulling 00ee93986e2e9f1db7b7597230f5ff3de39640bd on joelleejh:v0.5 into 49719afaa589f2ebf34586bddcec48ebae06f175 on CS2103JAN2017-T11-B1:V0.5.


fix(controller)!: do not attempt to infer desired revision when not specified

Fixes #2952 #2968
When determining whether an Application sync has completed successfully and again when assessing Application health as a factor in Stage health, the argocd-update step (as did legacy promotion mechanisms before it) often takes revision information into account. i.e. It often requires ApplicationSources to be observably synced to a specific revision (commit ID or chart version).
Until now, when the desired revision for a given ApplicationSource has not been explicitly specified, the argocd-update step has attempted to infer the desired revision by examining the Promotion's FreightCollection. If it found an artifact matching an ApplicationSource's repoURL field (and chart field, when applicable), that revision of the artifact was presumed to be the one that ApplicationSource should be observably synced to.
This behavior has repeatedly tripped up users for a variety of reasons, the most prominent involving a scenario wherein multiple Stages use promotion processes that update the head of a single, common branch, which is tracked by multiple Applications. When a Promotion to one such Stage pushes a new commit, deemed its "desired revision," any Application that tracks that branch (and subsequently syncs) will no longer observably be synced to its own "desired revision." A Stage's health checks count this apparent mis-sync as a health problem.
In other scenarios, this behavior has also been implicated in causing the argocd-update step to enter an infinite series of retries for what appear to be failed attempts to sync an Application.
This PR simply eliminates the behavior whereby the argocd-update step attempts to infer desired revision when none is specified. This essentially relegates the step's desiredRevision field (and the deprecated desiredCommitFromStep field) to the status of an "advanced" feature for use in scenarios not prone to the difficulties highlighted above.
This is a breaking change insofar as it changes behavior, although it will not actually break anything as it relaxes success criteria. Most users will notice nothing different. It is only users who like the more thorough health checks who may wish to now begin explicitly specifying desired revisions, which is something easily accomplished using v1.1's new EL support.
This change will be prominently mentioned in the v1.1.0 release notes.

This needs a codegen rerun, but otherwise looks good to me.

Actually looks like codegen verification just timed out in CI... context deadline exceeded.
Kicked it and it ran to completion.


Add Logspout functionality for out-of-the-box Docker logging

(Rebased and squashed changes from #110)
Add direct link to baked configurations, for debugging purposes.
Separate Logspout service into its own yml
Standardize Markdown formatting for program names
Do not auto-create indexes
Remove comments & UDP input

Please note I didn't amend anything; merely rebased and squashed; solving a couple of conflicts...
I'll fix some of these; but I just needed to make this work for my own needs; feel free to bring this into a branch and continue from there...

Sure I understand that, and appreciate you're sharing your work here. PRs must work for everyone without breaking the core function of the project in order to be mergeable though. I'm hoping we can use this as a base to come up with a nice solution.

Nice, thanks for the rebase! And apologies for the radio silence. I figured the example was out there, via a PR, but I'd be revisiting whenever bumped by someone on my side or yours.
Let me know if/when you want some movement here and I'll put in a bit of time. Hopefully I get a request to do a bit of work here soon. :)

I can clean that bit out and make it persistent on my side; either should be fine if it helps this move along too ;)

@joaquincasares would be great if you could pick up the comments; specially since the original code is yours anyway... I'm not claiming ownership! 😄

Thanks for all the work and comments!
@dm Yeah, feel free to finish patching this up and getting this into master. I merely wanted to provide a great starting point for those interested in a Docker-ELK stack that includes Logspout.
Sorry for the silence! Friday's schedule was a bit different followed by a busy weekend. :)

I definitely want to merge this after the minor issues mentioned before have been addressed.
The only thing that really bothers me is the complexity of the logspout image. I'm not too familiar with it so I'm not in a good position to propose something better, but I believe we can tackle this later in some way.

I pushed quite a lot of changes today in order to adopt the discussed directory structure and add the requested changes.
@deviantony @dm and @joaquincasares you should git reset --hard your local repo in order to pick up the changes.
I'd say the branch is clean enough to be merged now, let's wait for Anthony's approval.

@deviantony yeah we definitely should, I just added a short paragraph about it ✍

Did you just created the extensions/README.md file? I was thinking about a section inside the main README.md listing available extensions (somehow equivalent to the branch features listed at the beginning of the README).

We made it 👏  Thanks a lot everybody!

Great, thanks for this all!
@antoineco @deviantony and @joaquincasares
I'll bring these changes to my fork as well, but keep my work-specific changes on a separate branch there for the time being - hope to consolidate it in the future and keep some contributions going.
Cheers,
Dan :)


Allowing Part thumbnail (image) update via API

Added PartThumbsUpdate API view to allow Parts thumbnails to be updated directly from the API

I've also enabled this feature in inventree-python: https://github.com/inventree/inventree-python/pull/33

I assume you have tested this (via the Python API)?

@SchrodingersGat Correct, both manually (Django Rest Framework API page) and programmatically. I'm able to upload part images (jpeg format) directly downloaded from the internet, it works great 😄
Now that I think about it, I'm don't think I have tried any other format like PNG or BMP, but I don't think that changes much to the code. I can give those other formats a shot, and maybe protect against someone uploading something other than a picture?

@SchrodingersGat So alright, you did well in making me wonder about other types of files and it was indeed triggering a Django error. To avoid this, I added a custom validation method to the thumbnail serializer (PartThumbSerializerUpdate) which allows the API view to raise an error and not crash Django, yay! :smiley:
The validation method is based on the Django REST Framework API doc, specifically this section: https://www.django-rest-framework.org/api-guide/serializers/#field-level-validation

Ok, this seems pretty nice! Thanks for this addition :)


MAGPIE Appears to Hang for certain programs with certain possible edits

When using the QuixBugs benchmark programs and running MAGPIE in the genetic_programming mode, the program hangs and gets stuck in certain cases (certain programs and possible edits and pop_size).
This was observed when running the Levenshtein bug, with a pop_size greater than 30, with the SrcmlNumericSetting mode.
The program would consistently hang at the same point at the same step.
This was fixed by changing the pop_size to be less than the step within the generation at which the program hangs.
Example - Run MAGPIE on the Levenshtein and Quicksort bugs. When the possible_edits are the defaults - the programs run and do not hang.
For Levensetein adding SrcmlNumericSetting to the list of possible edits (4 total) does not affect the program running - and if the bug is found and patched, it terminates normally. However, if the 3 possible edits for Levenshtein are replaced with SrcmlNumericSetting (1 total), the program hangs at step 0-30. This appears to be consistent across platforms.
For Quicksort adding SrcmlComparisonOperatorSetting to the list of possible edits (4 total) also seems to function as expected, finding the bug and replacing the >. However if the 3 possible edits are replaced with SrcmlComparisonOperatorSetting (1 total), the program hangs at step 0-12.
I hope that you can reproduce the behaviour from the test zips below, they should be placed in a folder called tests, at the same level as MAGPIE. I apologise if the behaviour is expected and I was simply misusing the tool.
Many thanks
[
levenshtein.zip
quicksort.zip
](url)

I see.
Looking at LEVENSHTEIN.java, there is a single comparison operator.
When SrcmlComparisonOperatorSetting is used alone,there are only 6 different variants possible (the original using "==", and the 5 mutants obtained by using "<", ">", "<=", ">=", and "!=").
Whilst local search is able to just ignore the issue and just quickly burn finish thanks to the caching mechanism, the current implementation of GP makes use of a dictionary and endlessly loops because there just isn't enough distinct variants to fill the initial population.
I'll make sure this gets fixed in the next version; in the meantime when using GP make sure to choose a pop_size that is not larger than the entire search space of possible edits.

Note: my guess is that the fix will likely look like
index abbeb22..800df28 100644
--- a/magpie/algos/genetic_programming.py
+++ b/magpie/algos/genetic_programming.py
@@ -60,10 +60,12 @@ class GeneticProgramming(magpie.core.BasicAlgorithm):
             # initial pop
             pop = {}
             local_best_fitness = None
-            while len(pop) < self.config['pop_size']:
+            tries = magpie.settings.edit_retries
+            while tries and len(pop) < self.config['pop_size']:
                 sol = magpie.core.Patch()
                 self.mutate(sol)
                 if sol in pop:
+                    tries -= 1
                     continue
                 variant = magpie.core.Variant(self.software, sol)
                 run = self.evaluate_variant(variant)
@@ -108,10 +110,12 @@ class GeneticProgramming(magpie.core.BasicAlgorithm):
                     self.mutate(parent)
                     offsprings.append(parent)
                 # regrow
-                while len(offsprings) < self.config['pop_size']:
+                tries = magpie.settings.edit_retries
+                while tries and len(offsprings) < self.config['pop_size']:
                     sol = magpie.core.Patch()
                     self.mutate(sol)
                     if sol in pop:
+                        tries -= 1
                         continue
                     offsprings.append(sol)
                 # replace

but I really don't want to presume what could happen with inconsistent population sizes.

Thanks very much for taking a look, I'm glad that the issue can be fixed for the next cohort!


Is it possible to render opaque meshes in front of all others with the MRTK shader?

Describe the problem
Hello,
I would like to be able to render some GameObjects in front of all others like if they would have a later render queue. GameObjects are using the MRTK standard shader in opaque mode.
Describe alternatives you've considered
I have considered to use a second camera, however this may be quite unecessary complex in my case if there is a simpler solution with the shader.
Thank you.

Usually you do this by altering the Queue value of the shader. If you want to render infront of all put something like 3001 (3000 being the default transparency queue value). For a better explanation look here:
Rendering Order - Queue Tag

Hello, I am sorry if I have not replied earlier.
However I am asking for Opaque materials, the render queue only works for transparent ones.

@benjamincoven try render queue and on the material with the MRTK standard shader, set ZTest to always. You may have to change rendering mode from opaque to custom to access the ZTest property. Let me know if that works for you

Yes, it works! I still have to change the render queue to avoid color issues.
Thank you very much.


Why required: [] generates an error

{
    ...
    "components": {
        "schemas": {
            "ABC": {
                "required": [],
                 ...
             },
             ...
        }
    }
}

this generates an error:
components -> schemas -> ABC -> required
  ensure this value has at least 1 items (type=value_error.list.min_items; limit_value=1)

"required": null do not generates an error
expected:

required not set
required = null
required = []

are the same and not generates an error

Sure sounds like a bug 🐛. Thanks for reporting!

I don't think this is a bug.   The parser in the IDE I use (JetBrains PyCharm) also spits out an error saying the required field needs at least one item.
If you don't have any required fields, don't add required.
This ticket can be closed, imo.

The OpenAPI spec section on the Schema object says:

The Schema Object allows the definition of input and output data types. These types can be objects, but also primitives and arrays. This object is a superset of the JSON Schema Specification Draft 2020-12.
For more information about the properties, see JSON Schema Core and JSON Schema Validation.

The JSON Schema Validation spec says of the required property:

The value of this keyword MUST be an array. Elements of this array, if any, MUST be strings, and MUST be unique.
An object instance is valid against this keyword if every item in the array is the name of a property in the instance.
Omitting this keyword has the same behavior as an empty array.

... which makes pretty clear that specifying an empty array for required is supported by JSON Schema, and thus by OpenAPI, and thus should be supported by this tool's model of OpenAPI.


Authentication plugins - Whitelabel error page is shown when user does not exist

Describe the bug
When external authentication plugins (such as Shibboleth) are being used, a new ePerson is automatically created for each external account.
If the automatic creation is disabled, when an user logs in with an external provider then the "whitelabel error page" is shown. An error message should be shown instead.
To Reproduce

Set authentication-shibboleth.autoregister = false in authentication-shibboleth.cfg
Log in using an external account that doesn't have an associated ePerson

Expected behavior
An error message should be shown informing the user that the account does not exist.
Documentation
https://wiki.lyrasis.org/display/DSDOC7x/Authentication+Plugins#AuthenticationPlugins-ShibbolethAuthentication

@tdonohue  we can start to work on that. Right now it is still unclear how to solve the issue so the estimation needs to be refined after further investigation but this would take more than 40 hours

@abollini : Came across this ticket previously assigned to 4Science.  Should this remain assigned to you for 7.5, or should I unassign?


User Can Style Textbox Fill

[ ] change color
[ ] change border radius
[ ] change padding
[ ] add a drop shadow

merged with #1525


Add support for adding multiple files on asset

It might be useful for some use cases to allow users to add more than one file when publishing an asset

this is part of the new form https://github.com/oceanprotocol/market/issues/862


[Snyk] Security upgrade electron from 15.5.7 to 29.4.3

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 14 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

doc/js_tutorials/js_assets/webnn-electron/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Use After Free SNYK-JS-ELECTRON-7411376
  726

Use After Free SNYK-JS-ELECTRON-7411377
  726

Use After Free SNYK-JS-ELECTRON-7411378
  726

Heap-based Buffer Overflow SNYK-JS-ELECTRON-7411379
  726

Out-of-Bounds Write SNYK-JS-ELECTRON-7411381
  726

Use After Free SNYK-JS-ELECTRON-7411382
  726

Type Confusion SNYK-JS-ELECTRON-7411383
  726

Use After Free SNYK-JS-ELECTRON-7411386
  726

Use After Free SNYK-JS-ELECTRON-7411387
  726

Out-of-bounds Read SNYK-JS-ELECTRON-7411389
  726

Use After Free SNYK-JS-ELECTRON-7411388
  721

Heap-based Buffer Overflow SNYK-JS-ELECTRON-7411384
  651

Heap-based Buffer Overflow SNYK-JS-ELECTRON-7411385
  651

Type Confusion SNYK-JS-ELECTRON-7411390
  551

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use After Free
🦉 Type Confusion

Checkmarx One – Scan Summary & Details – c153bce2-f9de-4495-ac57-4ccb9a674f73
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Buffer_Overflow_Unbounded_Format
/apps/createsamples/utility.cpp: 1258
Attack Vector

Buffer_Overflow_Unbounded_Format
/modules/calib3d/test/test_cameracalibration.cpp: 331
Attack Vector

Buffer_Overflow_Wrong_Buffer_Size
/3rdparty/zlib/gzread.c: 35
Attack Vector

Buffer_Overflow_Wrong_Buffer_Size
/samples/cpp/asift.cpp: 31
Attack Vector

CVE-2024-5493
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5494
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5495
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5496
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5497
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5498
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-5499
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-6290
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-6291
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-6292
Npm-electron-29.4.3
Vulnerable Package

CVE-2024-6293
Npm-electron-29.4.3
Vulnerable Package

Improper_Null_Termination
/3rdparty/ittnotify/src/ittnotify/ittnotify_static.c: 992
Attack Vector

Improper_Null_Termination
/3rdparty/ittnotify/src/ittnotify/ittnotify_static.c: 843
Attack Vector

Process_Control
/3rdparty/ittnotify/src/ittnotify/ittnotify_static.c: 87
Attack Vector

Resource_Injection
/samples/cpp/calibration.cpp: 350
Attack Vector

Resource_Injection
/samples/cpp/calibration.cpp: 350
Attack Vector

Resource_Injection
/samples/dnn/classification.cpp: 45
Attack Vector

Resource_Injection
/samples/cpp/calibration.cpp: 350
Attack Vector

Resource_Injection
/samples/cpp/calibration.cpp: 350
Attack Vector

Resource_Injection
/samples/dnn/classification.cpp: 45
Attack Vector

Resource_Injection
/samples/gpu/hog.cpp: 130
Attack Vector

Divide_By_Zero
/3rdparty/libwebp/src/enc/webp_enc.c: 268
Attack Vector

Divide_By_Zero
/modules/core/src/cuda_gpu_mat.cpp: 230
Attack Vector

Divide_By_Zero
/modules/core/src/cuda_gpu_mat.cpp: 222
Attack Vector

Divide_By_Zero
/samples/dnn/person_reid.cpp: 74
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/crop_and_resize_layer.cpp: 78
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/crop_and_resize_layer.cpp: 78
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/crop_and_resize_layer.cpp: 78
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/crop_and_resize_layer.cpp: 78
Attack Vector

Divide_By_Zero
/modules/imgproc/src/pyramids.cpp: 1046
Attack Vector

Divide_By_Zero
/modules/imgproc/src/pyramids.cpp: 1046
Attack Vector

Divide_By_Zero
/modules/features2d/src/kaze/nldiffusion_functions.cpp: 235
Attack Vector

Divide_By_Zero
/modules/dnn/test/test_halide_layers.cpp: 202
Attack Vector

Divide_By_Zero
/modules/dnn/test/test_halide_layers.cpp: 109
Attack Vector

Divide_By_Zero
/modules/calib3d/src/calibration.cpp: 4349
Attack Vector

Divide_By_Zero
/modules/calib3d/src/calibration.cpp: 4349
Attack Vector

Divide_By_Zero
/modules/calib3d/src/fundam.cpp: 248
Attack Vector

Divide_By_Zero
/modules/ml/src/boost.cpp: 116
Attack Vector

Divide_By_Zero
/samples/cpp/tutorial_code/calib3d/camera_calibration/camera_calibration.cpp: 515
Attack Vector

Divide_By_Zero
/modules/stitching/src/stitcher.cpp: 442
Attack Vector

Divide_By_Zero
/modules/stitching/src/stitcher.cpp: 255
Attack Vector

Divide_By_Zero
/modules/stitching/src/stitcher.cpp: 595
Attack Vector

Divide_By_Zero
/modules/stitching/include/opencv2/stitching/detail/warpers_inl.hpp: 765
Attack Vector

Divide_By_Zero
/modules/stitching/include/opencv2/stitching/detail/warpers_inl.hpp: 764
Attack Vector

Divide_By_Zero
/modules/stitching/include/opencv2/stitching/detail/warpers_inl.hpp: 240
Attack Vector

Divide_By_Zero
/modules/stitching/include/opencv2/stitching/detail/warpers_inl.hpp: 239
Attack Vector

Divide_By_Zero
/modules/objdetect/src/qrcode.cpp: 1615
Attack Vector

Divide_By_Zero
/modules/ml/src/kdtree.cpp: 214
Attack Vector

Divide_By_Zero
/modules/imgproc/src/lsd.cpp: 581
Attack Vector

Divide_By_Zero
/modules/imgproc/src/histogram.cpp: 2222
Attack Vector

Divide_By_Zero
/modules/imgproc/src/histogram.cpp: 2297
Attack Vector

Divide_By_Zero
/modules/imgproc/perf/perf_resize.cpp: 189
Attack Vector

Divide_By_Zero
/modules/imgproc/perf/perf_resize.cpp: 189
Attack Vector

Divide_By_Zero
/modules/imgproc/perf/perf_resize.cpp: 186
Attack Vector

Divide_By_Zero
/modules/imgproc/perf/perf_resize.cpp: 185
Attack Vector

Divide_By_Zero
/modules/gapi/test/common/gapi_video_tests_common.hpp: 40
Attack Vector

Divide_By_Zero
/modules/gapi/test/common/gapi_video_tests_common.hpp: 39
Attack Vector

Divide_By_Zero
/modules/gapi/samples/pipeline_modeling_tool/pipeline_builder.hpp: 103
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/lsh_table.h: 378
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/lsh_table.h: 377
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/dist.h: 869
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/dist.h: 839
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/dist.h: 716
Attack Vector

Divide_By_Zero
/modules/flann/include/opencv2/flann/dist.h: 686
Attack Vector

Divide_By_Zero
/modules/features2d/src/sift.dispatch.cpp: 234
Attack Vector

Divide_By_Zero
/modules/features2d/src/sift.dispatch.cpp: 374
Attack Vector

Divide_By_Zero
/modules/features2d/src/evaluation.cpp: 447
Attack Vector

Divide_By_Zero
/modules/dnn/src/ocl4dnn/src/math_functions.cpp: 499
Attack Vector

Divide_By_Zero
/modules/dnn/src/ocl4dnn/src/math_functions.cpp: 498
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/slice_layer.cpp: 274
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/reshape_layer.cpp: 152
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/reduce_layer.cpp: 234
Attack Vector

Divide_By_Zero
/modules/dnn/src/layers/elementwise_layers.cpp: 133
Attack Vector

Divide_By_Zero
/modules/dnn/src/int8layers/reduce_layer.cpp: 119
Attack Vector

Divide_By_Zero
/modules/dnn/src/int8layers/elementwise_layers.cpp: 110
Attack Vector

Divide_By_Zero
/modules/dnn/src/cuda4dnn/primitives/scale_shift.hpp: 127
Attack Vector

Divide_By_Zero
/modules/dnn/src/cuda4dnn/primitives/inner_product.hpp: 63
Attack Vector

Divide_By_Zero
/modules/dnn/src/cuda4dnn/primitives/inner_product.hpp: 60
Attack Vector

Divide_By_Zero
/modules/core/src/umatrix.cpp: 1128
Attack Vector

Divide_By_Zero
/modules/core/src/umatrix.cpp: 915
Attack Vector

Divide_By_Zero
/modules/core/src/umatrix.cpp: 909
Attack Vector

Divide_By_Zero
/modules/core/src/split.dispatch.cpp: 141
Attack Vector

Divide_By_Zero
/modules/core/src/persistence.cpp: 2537
Attack Vector

Divide_By_Zero
/modules/core/src/persistence.cpp: 1055
Attack Vector

Divide_By_Zero
/modules/core/src/merge.dispatch.cpp: 168
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_transform.cpp: 324
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 253
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 226
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 221
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 215
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 204
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_iterator.cpp: 195
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_expressions.cpp: 927
Attack Vector

Divide_By_Zero
/modules/core/src/matrix_expressions.cpp: 897
Attack Vector

Divide_By_Zero
/modules/core/src/datastructs.cpp: 400
Attack Vector

Divide_By_Zero
/modules/core/src/cuda_gpu_mat.cpp: 231
Attack Vector

Divide_By_Zero
/modules/core/src/cuda_gpu_mat.cpp: 223
Attack Vector

Divide_By_Zero
/modules/core/src/channels.cpp: 147
Attack Vector

Divide_By_Zero
/modules/core/src/arithm.cpp: 1244
Attack Vector

Divide_By_Zero
/modules/core/src/arithm.cpp: 724
Attack Vector

Divide_By_Zero
/modules/core/src/arithm.cpp: 223
Attack Vector

Divide_By_Zero
/modules/core/src/arithm.cpp: 1760
Attack Vector

Divide_By_Zero
/modules/core/include/opencv2/core/utility.hpp: 507
Attack Vector

Divide_By_Zero
/modules/core/include/opencv2/core/utility.hpp: 502
Attack Vector

Divide_By_Zero
/modules/core/include/opencv2/core/utility.hpp: 490

More results are available on AST platform


work with phantomjs

fix for crypto-browserify/crypto-browserify#143

yeah there was a typo in it was why it was failing

I'm going to add a travis badge and then sqash this

rebased

currently this does cause an extra copy, but feross/buffer#83 handles that

ok so that pull didn't make sense on buffer so updated this to avoid the extra copy

LGTM

@dcousens fixed the nits

Great work @calvinmetcalf :+1:

published

This patch broke randombytes in real, non-phantom browsers.


Program freezes when running in parallel

Hello,
I am able to run the example script without specifying -t, but when I try to run it with -t=4, the program freezes after the read extraction is complete (I allocated 4 cores when running the script, so that shouldn't be an issue). Are there maybe any additional dependencies for running TRUST4 in parallel? I'm running on an HPC cluster, so these are the modules that I have loaded:
gcc/6.2.0 zlib/1.2.11 bzip2/1.0.6 xz/5.2.2 perl/5.24.0 python/3.6.0 samtools/1.9 glibc/2.14
Thanks!
J-B

The executables were compiled under gcc/7.3.0, maybe the pthread library needs that version. Could you please show me the output on the screen from run-trust4?

This is the stderr when I run with multiple threads:
[Thu Feb 27 20:47:16 2020] TRUST4 begins. [Thu Feb 27 20:47:17 2020] SYSTEM CALL: /scratch/jbreynier/programs/TRUST4/TRUST4/bam-extractor -b example/example.bam -t 2 -f hg38_bcrtcr.fa -o ../TRUST4_test/test_toassemble  [Thu Feb 27 20:47:17 2020] Start to extract candidate reads from bam file. [Thu Feb 27 20:47:18 2020] Finish obtaining the candidate read ids. [Thu Feb 27 20:47:18 2020] Finish extracting reads.
The samtools and glibc programs on the HPC cluster are dependent on gcc/6.2.0 so I'll ask my HPC administrator if that can be modified. I'll give it a try and get back to you.

Could you please also list all TRUST4 dependencies, in case I need other programs to be installed?

I think there is no other dependency. Could you please check whether ../TRUST4_test/test_toassemble_1.fq, ../TRUST4_test/test_toassemble_2.fq were generated and ended with read id "seq23.2_IGHV3-7401_IGHJ501_TGTGCAAGCATTTGAATATAGCAGCTCGTCATTGTGATAACTCTGGTTCGACCCCTGG-2"
Another way is to run TRUST4 without the wrapper. Just to make sure it is not the operating system issue.
./bam-extractor -b example/example.bam -t 2 -f hg38_bcrtcr.fa -o ../TRUST4_test/test_toassemble
./trust4  -o ../TRUST4_test/test_toassemble -f hg38_bcrtcr.fa -t 2 -1 ../TRUST4_test/test_toassemble_1.fq -2 ../TRUST4_test/test_toassemble_2.fq
./annotator -f human_IMGT+C.fa -a  ../TRUST4_test/test_final.out -r  ../TRUST4_test/test_assembled_reads.fa -t 2 -o  ../TRUST4_test/test >  ../TRUST4_test/test_annot.fa
perl ./trust-simplerep.pl  ../TRUST4_test/test_cdr3.out >  ../TRUST4_test/test_report.tsv
Thanks.

Yes, the two fastq files do end with that read id.
I tried running it without the wrapper, but same issue persists (the program freezes after read extraction). I'll contact my HPC administrator to see if the samtools/glibc/perl modules can be installed with gcc/7.3.0.
In the meantime, would it be possible to get the original files, and recompile them myself? It might be possible to recompile with gcc/6.2.0.

I just compiled TRUST4 under gcc/6.2.0. You can download the executables at https://github.com/liulab-dfci/TRUST4/releases and replace the old executables with them. Please let me know whether this works. Thanks.

I tried running without the wrapper and without indicating the number of threads, and that script also doesn't work. I get the following error output (with the gcc/6.2.0 compiled executables):
[Mon Mar  2 22:10:09 2020] Start to extract candidate reads from bam file.
[Mon Mar  2 22:10:09 2020] Finish obtaining the candidate read ids.
[Mon Mar  2 22:10:09 2020] Finish extracting reads.
[Mon Mar  2 22:10:10 2020] Found 394 reads.
[Mon Mar  2 22:10:10 2020] Finish sorting the reads.
[Mon Mar  2 22:10:10 2020] Finish rough annotations.
[Mon Mar  2 22:10:10 2020] Assembled 389 reads.
[Mon Mar  2 22:10:10 2020] Try to rescue 0 reads for assembly.
[Mon Mar  2 22:10:10 2020] Rescued 0 reads.
/var/spool/torque/mom_priv/jobs/20780452.cri16sc001.SC: line 82: 175164 Segmentation fault      ./trust4 -o ../TRUST4_test/test_toassemble -f hg38_bcrtcr.fa -1 ../TRUST_test/test_toassemble_1.fq -2 ../TRUST_test/test_toassemble_2.fq
Need to use -a to specify the assembly file.
readline() on closed filehandle FP1 at ./trust-simplerep.pl line 295.
readline() on closed filehandle FP1 at ./trust-simplerep.pl line 315.
With the gcc/7.3.0 executables, I get the same exact output without the segmentation fault error. In both cases, the final results are empty. Is there maybe an error in the list of commands you sent me?
The zipped directory doesn't contain the run-trust4 executable compiled with gcc/6.2.0. Could you please add that file so I can see if it works? Thank you!

run-trust4 is just a perl wrapper, so it does not change. I tried this on several systems and they all work fine. Which linux version are you using?
If you have valgrind on your system, can you run
"valgrind ./trust4 -o ../TRUST4_test/test -f hg38_bcrtcr.fa -1 ../TRUST_test/test_toassemble_1.fq -2 ../TRUST_test/test_toassemble_2.fq" and share the output with me?
Thanks.

I figured out why the list of commands without the wrapper weren't producing any results (even with -t 1): in the list of commands, you wrote ./trust4 -o ../TRUST4_test/test_toassemble -f hg38_bcrtcr.fa -t 2 -1 ../TRUST4_test/test_toassemble_1.fq -2 ../TRUST4_test/test_toassemble_2.fq, but it should have been  -o ../TRUST4_test/test.
This is the Linux version on the HPC cluster:
Linux cri16in001 2.6.32-573.12.1.el6.x86_64 #1 SMP Mon Nov 23 12:55:32 EST 2015 x86_64 x86_64 x86_64 GNU/Linux
I ran all the individual scripts with valgrind, and this is the error log that I got:
error_log_valgrind.txt
I also noticed that all of the programs seem to be working and producing the results when run with -t > 1, but they can't seem to be able to exit.

I think for now I'll stick to the non-parallelized version to run my analysis, but let me know if you have any insight as to why the parallel version might not be working for me. Thanks!

I just uploaded a Singularity container (similar to Docker but does not require root permission) at https://github.com/liulab-dfci/TRUST4/releases and update the instruction in the README. Could you please give it a try if interested?


chore: flagd constructor refactoring

A follow-up of #286

This PR
Is a refactoring for flagd provider constructor. Current constructors are difficult to maintain and with more options, we run into complexity of breaking the construction contract. Plus, mix & match of args becomes difficult (reason for #286 to have a simple constructor to get feature done)
This PR introduces a builder. The builder builds argument options with built-in default derivations (instead of relying on nulls constructor args).
Example,
FlagdProvider flagdProvider =
        new FlagdProvider(FlagdOptions.builder()
                            .host("localhost")
                            .port(8023)
                            .openTelemetry(openTelemetry).build());

Along with the changes, I am deprecating old constructors. We shall aim to keep them as @Deprecated for next release. And then, we shall remove them from the release after.
Follow-up efforts - unit tests and improvements on testing

Thanks for the refactoring @Kavindu-Dodan  👍 I've created https://github.com/open-feature/java-sdk-contrib/issues/295 to track the removal of the deprecated methods

Thanks for the refactoring @Kavindu-Dodan 👍 I've created #295 to track the removal of the deprecated methods

This is great :) thank you .!

@toddbaert  as agreed [1] , I added (and formatted) the readme in this PR  [2]
[1] - https://github.com/open-feature/java-sdk-contrib/pull/286#issuecomment-1522337078
[2] - https://github.com/open-feature/java-sdk-contrib/blob/f5db2818ce4c269d36b3a6ff61a10e6bb962c708/providers/flagd/README.md#opentelemetry-support


[Feature] Support source control based configuration of apps

Describe the solution you'd like
Ability to use check an AppCenter.json or .yml file in to our source control that could be used to configure an app in AppCenter as soon as you connect a repository.
The main use case we have for this is to share environment variables between App Center apps (e.g. Android and iOS builds of same application) or at the account level. Examples of variables could be NuGet keys or other common api keys.
One solution would be to support Secure Variables like other CI platforms. This would allow encrypted values to be committed in the source code in this configuration file and decrypted in app center.
It would also speed up configuring apps where you have a lot of apps with similar build pipelines within an organization. Plus all the benefits of having changes to AppCenter configuration stored in source control.
Describe alternatives you've considered
Other CI platforms support .yml based configuration files such as AppVeyor. This allows you to use secure environment variables and check them in to source control.
https://www.appveyor.com/docs/build-configuration/#secure-variables

Thanks @dlbroadfoot for the request! @nrajpurkar would you mind taking a look please?


Improved default remote behaviour & validation for fetch/pull

This fixes #660 and also improves a few other areas:

Default remote is now either the tracked remote, or "origin" or any other single remote defined. If all of these fail there's a better error message now.
User-supplied remotes are now validated to avoid ambiguous fail cases
General tidy up to make it clearer what each of these git package functions are intended to do

:metal: I want to experiment with throwing this "default remote" info in git lfs env too.


Jump to production feature request

Hi, thanks for this plugin! The error highlighting is great, it's helped me catch typos. One thing that would also be super helpful is jumping to a production, like control/command click to jump to source. If find the time and motivation I'd also love to try adding that feature to this plugin.

Hi @AndrewRayCode, thanks for the suggestion but there is actually a fork of this extension that already does that. you can find it here. Peggy is the successor of peg.js and until now they are compatible. I think it would be good to migrate to peggy, which has active development now. The extensions has great features like find usages, goto definition, error highlighting, and even completion.


PSR-6 cache adapter with (at least) BotFramework

When using https://github.com/php-cache/redis-adapter via newly introduced Psr6Cache the following problem is triggered:
Invalid key: "conversation-29:160NysSVYcvoosHxDgqTzepm0A6sSUDje5CbXVE84UZw-29:160NysSVYcvoosHxDgqTzepm0A6sSUDje5CbXVE84UZw". The key contains one or more characters reserved for future extension: {}()/\@:

@Art4 @mpociot would it be an option to use sha1(key) instead?

Yes, that would be an option.
I was thinking about removing or replacing the reserved characters, but that could lead to key collisions (foo:bar and foobar would result in the same key).
We can not be sure what keys would be given, so using a hash would be the safest way.

Fixed :)


Make readme prettier

Codecov Report

Merging #129 (3192123) into main (9b76f6f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        20
  Lines          609       609
  Branches        50        50
=========================================
  Hits           609       609

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b76f6f...3192123. Read the comment docs.


New version: PawsomeTracker v1.0.4

Registering package: PawsomeTracker
Repository: https://github.com/yakir12/PawsomeTracker.jl
Created by: @yakir12
Version: v1.0.4
Commit: ec4e74e4680dbadb94c4a71e9d627ec930b02736
Git reference: HEAD

Stop

[noblock]


std::bad_alloc

This error occurs when I synchronize. How to solve it?
2018-08-09T07:21:22.037 thread-0   producer_plugin.cpp:331       on_incoming_block    ] Received block adaceec950230d1e... #10209388 @ 2018-08-09T07:19:23.500 signed by helloeoscnbp [trxs: 254, lib: 10209272, conf: 0, latency: 118537 ms]
terminate called after throwing an instance of 'std::bad_alloc'
terminate called recursively
  what():  std::bad_alloc

The RAM of your machine is not enough to run nodes, or your chain-state-db-size-mb in config.ini had a misconfig.

RAM of server is 16GB, and What size is the best configuration of chain-state-db-size-mb?
I tried to config chain-state-db-size-mb as the following size, and this error occurs either.

8192
16384
40960

In addition, the nodeos version is based on mainnet-1.1.3.

It depends on the chain you’re connecting to and it depends on nodeos options. e.g. if you’re connecting to a main net and you used “—filteron *”, then it effectively needs an unbounded amount. If you’re connecting to a main net and aren’t using any extra plugins, then 64 GB will work today, but won’t work long term.

Looks like there's not enough RAM in your machine? What's your machine config?

RAM of server is 16GB, and what size is the best configuration of chain-state-db-size-mb?
I tried to config chain-state-db-size-mb as the following size, and this error occurs either.
8192
16384
40960
In addition, the nodeos version is based on mainnet-1.1.3.

I also expect this issue to be resolved.

Can you provide your config.ini and details about OS and machine setup?

We disable eosio::bnet_plugin, and everything goes well.

Version

OS version: Ubuntu 16.04.4 LTS
nodeos version: mainnet-1.1.4

Config file click here.
Of course, I remove some sensitive configuration and disable eosio::bnet_plugin.
Thanks.

If you have avoided this problem because you have modified some settings of config.ini, maybe it is not a solution.Maybe hiding other big problems.

Try to disable the history plugin which is probably the RAM killer.


Add DeployInfrastructure task on updates

What this PR does / why we need it:
This PR makes the shoot admission plugin add the deployInfrastructure task if it detects InfrastructureConfig updates.
Which issue(s) this PR fixes:
Fixes #1653
Special notes for your reviewer:
Release note:

Gardener now triggers infrastructure related changes on shoots immediately, instead of only during the maintenance time window.

gardener updates the Infrastructure resource successfully when there is a change in the infrastructureConfig. Can't we just use the GenerationChanged() predicate in the infrastructure controller and reconcile when old.metadata.generation != new.metadata.generation?

Can't we just use the GenerationChanged() predicate in the infrastructure controller and reconcile when old.metadata.generation != new.metadata.generation

Makes sense.

gardener updates the Infrastructure resource successfully when there is a change in the infrastructureConfig. Can't we just use the GenerationChanged() predicate in the infrastructure controller and reconcile when old.metadata.generation != new.metadata.generation?

Yes, I was thinking about this. It'd need some further rework of the extension's predicates. Let me come up with something that makes the overall reconciliation logic between g/g and g/gext a bit better/easier.

Yes, I was thinking about this. It'd need some further rework of the extension's predicates. Let me come up with something that makes the overall reconciliation logic between g/g and g/gext a bit better/easier.

Thank you!

I would vote for the solution implemented here. The reason is that Gardener controls when to reconcile what. The infrastructure controller just implemented the contract like any other controller.

As discussed, on the one hand we want to restrict the reconciliation of extension resources to reduce cloud API calls, mass rolling updates, mass attach and detach operation, etc..
This becomes important when:

Extension controllers restart
Extension controllers are updated

On the other side, we do want to reconcile when:

Shoots' specs change
Shoots are enqueued

Additionally, we want to only reconcile the infrastructure when:

Infra specs change
Shoots are enqueued during maintenance time window

After all we decided that Gardener/Gardenlet is the component which has the knowledge of the above use cases and the power to decide which extension resource should reconcile (by adding the annotation gardener.cloud/operation: "reconcile"). It's finally the contract every extension controller should comply with.

Hmm, a comment which is not related to this PR - in pkg plugin/pkg/shoot/validator/admission.go, ValidateShoot we do some mutations next to the validation. Is it ok/expected?

It is expected, but we should maybe consider refactoring the admission plugins after 1.0.0 release.


Safari doesn't deal properly with detune

Getting quite a lot of this error: TypeError: undefined is not an object (evaluating 'source.detune.value = e.args.detune') when running in Safari (9.2).

Interesting. Must be an audioparam issue or something. On it.

Fixed in latest


bug: [1.2.0] back animation, back view is still

Type: bug
Platform: desktop browser
I'm testing 1.2.0-nightly-1823
On 1.1.1 when back button is hit then the active view slides away to the right until it goes off the viewport entirely and in the meantime the back view slides in from left with a fraction of the speed current view goes away - a parallax effect can be seen.
On 1.2.0 the back view is still - it's on its final position right from the beginning of the back transition.

Greetings @jrencz!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Thanks, can repro w/ overflow scrolling. Will fix for 1.2.1

I applied this commit onto my copy but it didn't help.
I'll try to provide a screencast later


Add error code for startup timeout

This lets consumers react to a timeout that happened during test
startup.

I think some of these error codes are derived from internal error codes used by Apple's Frameworks.  Regardless it doesn't look like their value is at-all significant to the logic of the test, so there's harm in adding another one.


Faster parsing of dates. Fixes #117

Fixes the format for ISO dates and tries using it before DatatypeConverter. This improves the parsing time by 30 to 40%.
Before (average over 10 iterations in msec)
Average for http://www.foxnews.com/sitemap.xml?idx=26 => 684
Average for http://push.abs-cbn.com/sitemap/2015/ => 238
Average for https://www.novinky.cz/sitemap/sitemap_articles_5.xml => 972
After
Average for http://www.foxnews.com/sitemap.xml?idx=26 => 481
Average for http://push.abs-cbn.com/sitemap/2015/ => 141
Average for https://www.novinky.cz/sitemap/sitemap_articles_5.xml => 657
I also tried java.time (in Java 8) but there was no benefit from it
 return Date.from(java.time.ZonedDateTime.parse(date).toInstant());
Average for http://www.foxnews.com/sitemap.xml?idx=26 => 646
Average for http://push.abs-cbn.com/sitemap/2015/ => 197
Average for https://www.novinky.cz/sitemap/sitemap_articles_5.xml => 1281

Will merge soon unless someone objects
@crawler-commons/owners


Error calling NSPAnalyser

Hi
Im having an error when using dependency check plugin in jenkins (4.0.0)
[DependencyCheck] Message: Failed to read results from the Node Security Project (NspAnalyzer); the analyzer is being disabled and may result in false negatives.
[DependencyCheck] org.owasp.dependencycheck.analyzer.exception.AnalysisException: Failed to read results from the Node Security Project (NspAnalyzer); the analyzer is being disabled and may result in false negatives.
[DependencyCheck] 	at org.owasp.dependencycheck.analyzer.NspAnalyzer.analyzeDependency(NspAnalyzer.java:225)
[DependencyCheck] 	at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:136)
I am reading that NSP analyser is deprecated
https://github.com/jeremylong/DependencyCheck/blob/8c6ca08daa7caf1df5d4bd6da4798cbddd46c755/core/src/main/resources/META-INF/services/org.owasp.dependencycheck.analyzer.Analyzer
But apparently this is still an option in the jenkins plugin
I assume the solution is to untick that option in jenkins configuration, but, should this option not be removed?
Thanks

I have no idea where that's coming from, but NSP was removed from the Jenkins plugin awhile ago. There is no option to configure it and the constants in org.owasp.dependencycheck.utils.Settings that the Jenkins plugin relies on, doesn't have NSP as an option.

Jenkins plugin v5.0.0 no longer has analyzer configuration. Closing.


oneOf is not evaluated correctly

oneOf: (XOR) Must be valid against exactly one of the subschemas

ref
I'm still refactoring json-fuzz-generator into json_schemer-fuzz, and I am getting an error in the tests for oneOf:
(byebug) schema
{"$schema"=>"http://json-schema.org/draft-04/schema#", "oneOf"=>[{"properties"=>{"a"=>{"type"=>"string"}}, "required"=>["a"]}, {"properties"=>{"b"=>{"type"=>"integer"}}}]}
(byebug) schemer.valid?({"a" => "hoge"})
false

Here is the schema blown out:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "oneOf": [
    {
      "properties": {
        "a": {
          "type": "string"
        }
      },
      "required": [
        "a"
      ]
    },
    {
      "properties": {
        "b": {
          "type": "integer"
        }
      }
    }
  ]
}

{ "a": "hoge" } should be valid!

Of note -

{ "b": 34 } is valid, so it is half working!  With the same schema:

(byebug) schemer.valid?({"b" => 34})
true

Digging into this a bit more, and oddly, the other side of the oneOf is also not valid:
(byebug) schema
{"$schema"=>"http://json-schema.org/draft-04/schema#", "oneOf"=>[{"properties"=>{"a"=>{"type"=>"string"}}, "required"=>["a"]}, {"properties"=>{"b"=>{"type"=>"integer"}}}]}
(byebug) schemer.valid?({"a" => "hoge"})
false

Looking at this quickly, I think { "a": "hoge" } is valid for both oneOf schemas (meaning the oneOf is invalid) because the second schema doesn't specify anything as required (or have any other requirements for properties other than b).

I think @davishmcclurg is correct. { "a": "hoge" } should be valid with a anyOf or allOf, but should fail with oneOf.

Wonderful!  Thanks for correcting my thinking!  I'll update the tests.

I want to make sure I understand this.
The "b" side matches the {"a": "hoge"} as valid because

By default any additional properties are allowed.

And thus it would match literally anything provided that was a valid schema?  So in reality it makes no difference what the "b" schema is, so long as it is not restrictive with required` or the like, anything will match it?
I guess I answered my own question.  Thanks!
>> JSONSchemer.schema({ "properties": { "b": { "type": "integer" } } }).valid?({"lulz": [1, "what"]})
=> true

Yes that's right. If I remember correctly, properties doesn't even require the instance to be an object (you'd need "type": "object" for that).

The best way to describe this is the lack of constraints provided in each schema.
Either one is basically wide open to any schema unless the properties defined are given in the instance data, then those properties would be constrained by the defining assertions. String/required or integer.
One interesting behavior you may not expect with oneOf is without declaring a type for the schema, it remains unconstrained to any other type of valid JSON Schema schema type.
Thus, these are all failing schemas because they pass both schemas
[ { "BBB": true}]

111

{
  "a": "test",
  "c": "blah"
}

true

[]

null

And so on...
If you wanted to constrain this oneOf you can define to as such
{
  "oneOf": [
   { "type": "object",
        "properties": {
          "a": { "type": "string"}
        }, "additionalProperties": false
   },
   {
      "type": "object",
      "properties": {
          "b": { "type": "integer" }
       }, "additionalProperties": false
   }
}

Then you can only pass with
{ "a": "test"}

Or
{"b": 123}


No matching outgoing channel

Although there is a channel, this error message appears:
[lncli] rpc error: code = Unknown desc = no matching outgoing channel available for node 2 (pubkey)
On 1ml.com or amboss.space the channel is listed.

try to lower the amount you're sending and rebuild. Sometimes a channel will have a crazy high fee that will cause routing to fail; that's what's happening to me right now

This is definitely no igniter issue, I was able to build the route with my own script and it worked just fine (https://github.com/ziggie1984/miscellanous/blob/e83fbf689f7ca06d256d65e0f5330b10496470b2/igniter2_0.js)
I think the problem lies in the BuildRoute grpc call

Thanks guys, closing this issue...


Allow use of debug printing while UART printing is enabled

Currently you can only set either UARTPRINTF or DEBUGPRINTF. The case where UART is still needed to communicate with a peripheral but the developer wants to use debug printing is not accounted for at all: The entire debug printing function is not compiled at all if DEBUGPRINTF isn't set requiring the user to copy the entire function into their own codebase.
Would be great if there were separate functions for UART and DEBUG printing that aren't tightly coupled in into stdio. Stdio could then simply interface with those functions.

I don't understand, if you just use the debug printing with FUNCONF_USE_DEBUGPRINTF, it printf's over the programming interface.  You are free to configure the UART to do whatever you wish at that point.

My idea was that then I (the user) wouldn't be able to use the routines provided by ch32v003fun anymore and would have to copy them into their own code.
Now the obvious solution for me has been to just use an external UART library instead that has more functionality.


Unable to compile with under OCaml 4.07 / MSVC2017 64

Error given:
File "type.ml", line 8, characters 2-3:
Error: Syntax error
Compiles under 4.06

use jbuilder with package, or directly ocamlc, both give the same error.
I don't have opam, since I think it doesn't work under windows with msvc and without cygwin(my requirement)

It could be due to this: https://github.com/mjambon/cppo/pull/52, i.e. for ocaml >= 4.07 you need cppo >= 1.6.1. You can check that with cppo -version.

This DO work. Thank you. cppo -version helps me out
In fact I found an old version cppo under my cygwin/usr/local/bin, which overrides the recent version I built under OCaml/bin


Test of: Replace psa-attestation/lib/mbed-crypto with mbedtls from rust-psa-crypto.

This is #346 with some additional tests on top.

This was a hacked together test of #346, which is now merged, so I'm going to close the PR now to declutter things a bit.
I hope that we will have a proper test of the psa-crypto functionality before too long.


Handle quotes and extra whitespaces in version regexps

Closes #18
It's really common to use quotes when defining environment variables with ENV in Dockerfile e.g. ENV POETRY_VERSION="1.1.4".
The first commit simply adds the possibility to run test workflow on workflow_dispatch event, so it's easy to run test workflow whenever we want.
The second commit adds supports for quotes (", ') and optional whitespace (so now it will work correctly with plugin-name:1.2.3 or plugin = 1.2.3).

@skarzi I just created pull request #21. This pull requests contains some features I neede for my new github-action. I already created the changes before I saw you already added the ' and " syntax support. Sorry for that.

Thank you @skarzi and @rickstaa for your work! and sorry for the late response.
Yes. Let's merge this p-r and then merge #21.

Hi, @skarzi! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨
We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.
Thanks again!


Add proxy support to app ui and console-api

Signed-off-by: Feng Xiang<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/14073
https://github.com/open-cluster-management/backlog/issues/14015

Added proxy info to app ui and console-api deployment resource if they are passed in the chart values
Also update chart version to 2.4

Made sure the connection error doesn't appear anymore in a proxy env:

/lgtm

@KevinFCormier can you review this again? Looks like it's not picking up the /lgtm label for some reason.

Had to do the GitHub approve. You can merge now.


Fixing Readme.md formatting

@anuruddhal Is this pull request still valid? If so can you please fix the merge conflicts?
Thanks

@imesh I have now resolved the merge conflicts. Can you please merge the PR.
Thanks

Thanks @anuruddhal! This is now merged to master branch.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #439 (05f9825) into main (5edd660) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Create a JMS Sink Kamelet

@orpiske I'm assigning those to you, since you're working on them.

@oscerd sure thing, thanks!

This is done.


Cannot get library's document: sketch gets stuck

I'm running the following code via the sketch dev tools:
  const libraries = require('sketch/dom').getLibraries();
  const library = libraries[0]; // this array is not empty!

  console.log(library.getDocument());

It simply gets stuck and I have to restart sketch.
My goal is to update a sketch library from another sketch document that is consuming the library. I cannot have this result by using the reference, so I was trying to access the library document directly :D.
Why it gets stuck? Bonus point: it would be possible to update the library from another document?
Thx!

not a bug, the getDocument method is actually working. The problem was the console.log with a huge document, with a smaller one it's fine


Use JoinableQueue

task_done would be useful should someone force quit the subprocess as it's working on something


[CI] Refactor of tvm.testing.requires_* annotations

This PR has two main goals.

Improve the pytest messages when unit tests are skipped.  When investigating the bug in https://github.com/apache/tvm/pull/11294, reporting the reason why a test is skipped (disabled in config.cmake, disabled in TVM_TEST_TARGETS, or no device available).
Distinguish between tests that only require compile-time support from tests that require a physical device.  The existing @tvm.testing.requires_* decorators maintain the same semantics, skipping a test unless both compile-time and run-time support are present.  This adds an optional argument to indicate that the test does not require a physical device (e.g. to require cuda library support without requiring a cuda-capable GPU: @requires_cuda(support_required="compile-only")

@mehrdadh I expect this to conflict with these changes in PR#11294.  Between the two, your PR takes priority, as it is solving an immediate issue.  If all goes well, I don't expect the conflict to be difficult to resolve, as the corresponding change after this refactor would be to replace target_kind_hardware="hexagon" with run_time_check=lambda: "ANDROID_SERIAL_NUMBER" in os.environ in the definition of requires_hexagon, and to replace requires_hexagon_toolchain with requires_hexagon(support_required="compile-only").


Added JSX.Element as return type to formatter

According to the original documentation, any formatter should return a string or a Element.

I also added hover to the BootstrapTableProps.


Remove user roles for Host Discover and Add

Removes related user roles for discovering and adding Hosts.
Related PRs:
https://github.com/ManageIQ/manageiq-ui-classic/pull/5963
https://github.com/ManageIQ/manageiq/pull/19107
@miq-bot add_labels bug, ui, cleanup
https://bugzilla.redhat.com/show_bug.cgi?id=1733294

@bmclaughlin also need to remove product features for those two buttons

@miq-bot add_label wip

@miq-bot remove_label wip

cc @agrare


Fixes trigger creation issues

This PR uses the latest Halcyon SetupTools source to fix an issue where creating a Halcyon database under a schema name other than "InWorldz" would break economy trigger creation

Don't merge yet. I'm going to toss in one more change

Ok this is ready

Looks good, tested, confirmed changes.


feat(cardano-services): add sql script for Provider Server db-sync indexes

Context
Deployment needs to source application-specific indexes
Proposed Solution
Add sql script

Closing this as we're currently focused on setting up typeorm services instead of improving the setup of db-sync


Delay keyDown filter type

I get data from server and ng2-smart-table filters is very fast in typing search. I want after 1 second of keyDown in filterbox, table send filters query to server.
How do this?

i 'm not able to filtering data from ng2-smart-table
i'm using server as well , so if you want can you tell me what should i do to filtering data

`` source: LocalDataSource = new LocalDataSource();
//source :ServerDataSource ;
constructor(http:Http,
private ligneService:LigneService,
private service: GenieTablesService,)
{
this.source = new ServerDataSource(http, {
endPoint: 'http://localhost:3000/api/lignes',
pagerLimitKey: "_limit",
pagerPageKey: "_page",
sortDirKey: "_order",
sortFieldKey: "_sort",
//dataKey: 'data',
totalKey: 'x_total_count'
});
}

please mail to me your code.
<EMAIL_ADDRESS>

Was there ever a solution to this?

I have migrated to ngx-datatable. This is best solution for table in angular framework.


feat(join): add join operator

Description:
Implements join operator as described in ReactiveX docs
This implementation was created by @luisgabriel. At some moment he closed pr - https://github.com/ReactiveX/rxjs/pull/1371 - claiming code is not working for some reason.
I took his commits and rebased them to current master. I also fixed (quite trivial as it turned out) error. Now all tests pass.
If there is any work that needs to be done on this operator, let me know - I will be more than happy to help.
Related issue (if exists):
Closes #1341

Coverage increased (+0.02%) to 97.692% when pulling 45eedc22308cd9bf52b04b9669b835873aa49529 on Podlas29:join into 5f93f819f96a1fa0c6c287de9c2a766d5eec6348 on ReactiveX:master.

Appreciate for creating PR. As same as other operators in pending for release schedules, I assume this implementation also falls back same category - let me label as same as other one for now.
@blesh and other commiter's are currently trying to organize ergonomics of adding / removing new operator, or having breaking changes over releases and it'll be documented soon enough (I hope so) will have better clarity when working on some changes.
/cc'ed @blesh for visibility.

join is/has been on my radar for a while. This is going to require more debate and discussion. I think join should be added, but it's one where we need to very clearly define the use cases up front. Because it's not a very commonly used operator.

Oh. I was not aware that will be recurring issue.
Are there any issues that will be worth working on then? I was going to move from oldest to newest issues with label 'pr welcome', but maybe focusing for example on bugs and/or documentation issues would be best? Any recommendations?

Yeah, I agree with @blesh here. I had some trouble in figuring out use cases for this operator. However, the implementation is pretty close to RxJS 4.
Nevertheless, thanks @Podlas29 for putting some eyes on it and fixing the errors.

@blesh @luisgabriel join is really a great operator. I typically think in sequences, but other people think in tables. Here's a side-by-side of a tap gesture (mouse down + up within 250ms and 5px radius) between mergeMap and join:
const button = document.getElementById('tap_me');
const ups = Observable.fromEvent(button, 'mouseup');
const downs = Observable.fromEvent(button, 'mousedown');

function joinTap(downs, ups, radius = 5/*px*/, timeout = 250/*ms*/) {
  return downs.join(ups,
    (down) => Observable.timer(timeout),
    (up) => Observable.of(up),
    getDistanceBetweenEvents
  )
  .filter(within(radius));
}

function mergeTap(downs, ups, radius = 5/*px*/, timeout = 250/*ms*/) {
  return downs.switchMap(
    (down) => ups.timeoutWith(timeout, Observable.empty()),
    getDistanceBetweenEvents
  )
  .filter(within(radius));
}

function getDistanceBetweenEvents(down, up) {
  return Math.pow(up.pageX - down.pageX, 2) +
         Math.pow(up.pageY - down.pageY, 2);
}
function within(radius) {
  return ([distance]) => {
    return radius * radius >= distance;
  }
}

Well, I think it's really important for join that we have solid examples and solid example-like unit tests (even if they're using marbles).

I'd also like to remind the many requirements that need to pass before adding an operator:

[x] Add the operator to Rx
[x] It must have a -spec.ts tests file covering the canonical corner cases, with marble diagram tests
[ ] Write a asDiagram test case too, for PNG diagram generation purposes
[ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image
[ ] The operator should be listed in doc/operators.md in a category of operators
[ ] It should also be inserted in the operator decision tree file doc/decision-tree-widget/tree.yml
[x] You may need to update MIGRATION.md if the operator differs from the corresponding one in RxJS v4

Coverage increased (+0.02%) to 97.692% when pulling 24ff604555e43bba4bddb1d92350242800c1a8a2 on Podlas29:join into 5f93f819f96a1fa0c6c287de9c2a766d5eec6348 on ReactiveX:master.

@staltz Hi, I added most things you requested. I guess the only thing that pr lacks right now are good yet simple examples in docs.
@trxcllnt would you mind if I used some variation of your example in docs?

Great. Thanks

@Podlas29 of course please do

@trxcllnt if join is being added, where do we stand on groupJoin?

@mattpodwysocki I'm all for it! Been wanting both of these since day 1. Also been wanting the join patterns, but less priority since they can be done with zips.

@trxcllnt ok, I can get started on groupJoin.  As for the Reactive Joins, you can certainly do a lot with just zip, but it's a little bit more nuanced than that obviously, especially when making a reactive rules engine or even simple things like ray tracers much like JoCaml
const source = Observable.join(
    source1.and(source2).thenDo((fst, snd) => Observable.of(compute(fst, snd))),
    source3.and(source4).and(source5).thenDo((fst, snd, trd) => Observable.of(compute(fst, snd, trd))),
  source6.and(source7).thenDo((fst, snd) => Observable.of(compute(fst, snd)))
);

Coverage increased (+0.02%) to 97.72% when pulling 85e9b5e1b652905ec71c9c016a485ff0e26c768f on Podlas29:join into a77821b61e174d361fcd695f5c916baa79e3bd9f on ReactiveX:master.

This looks good... @trxcllnt can you confirm that this change is good for the next minor version?

... once that's done, we can remove the "don't merge" label and add it for the next minor version, I think.

Just commenting that I think "join" is an important operator and would like to see this included. It looks as though it is close to done/ready.

What needs to be done to merge this? I am quite eager to use it and am willing to do the leg work myself. (I also formerly was a member of the rx3 c# team at MSFT so I know my way around the programming model ok)

I'm going to close this PR... but I'm going to come back to it as a reference at some point if we decide to implement join.
<3 @mpodlasin thank you for your PRs and your help.


Support script execution for Alexa

Description:
Add script component support to Alexa smart home API
Checklist:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Hi @micbase,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Cool, I will change to PowerController, and maybe submit another PR for scene component support.

@balloob After digging into PowerController, I think maybe SceneController is a better fit for script component, because there is no turn off operation for script, only activate, and for SceneController you can specify if an endpoint can be deactivated or not. What do you think?

@balloob Please review the change

Awesome, thanks! 🐬  🌮


Install pip with IronPython

Hi,
I want to install projects using pip. I did the following:

opened python environment
installed pip from there
I got the following message
Failed to upgrade pip, which is probably because of IronPython. Leaving the earlier version.
----- Successfully installed pip -----
(I am using IronPython 2.7.5)
searched a module six
pressed install of the module from the list
I got the following
ImportError: No module named pip
----- Failed to install 'six' -----
What went wrong ?
Thanks,
Ilan

I found the problem It was because the directory was write protected
I released it and successfully installed pip (It had no errors and I saw it in the site-packeges directory)
I tried to install a module but It wrote the following error:
`AttributeError: 'module' object has no attribute '_getframe'
I know that this is because I have to operate iron python with the -X:FullFrames flag
My question is where I have to put it I tried to put it in the following locations:
In the project configuration > debug
In tools > options > Python Tools > interactive windows > interpreter options
but it did not work
Can you help?
Thanks
Ilan

As much as I'd like six to just remove the dependency on _getframe, it seems we'll have to add some magic for running pip with -X:Frames in IronPython.
Luckily, we can do that fairly easily now that package management is per-environment.


Write out a companion README style Markdown file for every processed table

It could include:

[ ] The raw table ID
[ ] A URL leading to the Census Reporter page about the table
[ ] A humanized version of the metadata found in the file name
[ ] A URL leading to the raw data file

How about using the data package scheme?


Javascript generation from website not working for me.

I first found out about this service and tried the example but it seems it forgets to add the https to the path.
When i copy-paste the text from the website it won't work.
This is the current basic example it lets me copy from the site.
<link rel="stylesheet" type="text/css" href="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.css" />
<script src="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.js"></script>
<script>
window.addEventListener("load", function(){
window.cookieconsent.initialise({
  "palette": {
    "popup": {
      "background": "#000"
    },
    "button": {
      "background": "#f1d600"
    }
  }
})});
</script>

//cdnjs.cloudflare.com should be https://cdnjs.cloudflare.com in both accounts.
Unless i'm mistaken.

But wouldn't it be better if the example copy and paste work for mosr cases? Cause i'm not just talking about what protocol it uses. I'm more talking about when people copy and paste the example code then in some situations you need to add the https manually for the example to work.
Maybe a note for this at the page where you are able to copy and paste the code?

The example code does work. The browser will automatically add the prefix for you.

Din't work for me and still isn't with the normal copy and paste from website.

It's not best practice anymore to use protocol-relative URL (https://www.paulirish.com/2010/the-protocol-relative-url/)

Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset.
Allowing the snippet to request over HTTP opens the door for attacks like the recent Github Man-on-the-side attack. It’s always safe to request HTTPS assets even if your site is on HTTP, however the reverse is not true.

That however is true @nebrot, especially as CDNJS just 301's these days anyway.


Chocolatey install/update removes ALL older SDK versions

When installing/updating the chocolatey package, ALL older SDK versions are uninstalled.
This includes versions like 2.2.205 which are still required on some machines due to global.json files not rolling up from 2.2.2xx to 2.2.4xx. This is causing a breaking change on install. I understand net core 3 does something similar, but that should only be for versions covered in the same "version" like 2.2.205 install would uninstall all other 2.2.20x versions, not a 2.2.10x version though.
Please note the discussion in the comments section at https://chocolatey.org/packages/dotnetcore-sdk/

Agreed. This is not a good thing. It is normal to require multiple versions of .NET Core SDK to be installed.

When looking into this I found out the chocolateybeforemodify of current installed package is executed and that version is the only variable available. This makes it impossible to inspect the differences between the current and the target version number.
It seems to me that chocolatey is not very well suited to the stupid versioning scheme that is used by Microsoft. Probably the best we could do is deploy separate packages matching the Visual Studio version that it is used for. But I'm not sure if we can use virtual packages for that and how side-by-side packages works for dependencies.

Frankly it'd be better to simply not uninstall at all than have the current behavior.  I think that's a serious option: it's a mess to leave behind all those files, but that's probably better than breaking stuff.  And as @riezebosch points out, there's no simple way to detect what can go and what needs to stay.
Another alternative would be to have multiple choco packages, one for each conceptually major version, but that's a pain too, and breaks the upgrade workflow.

To be honest, multiple packages may be a better option as in reality, upgrading .NET Core SDKs doesn't really make sense outside of the patch version incrementing.
So 2.2.200 should upgrade to 2.2.201, but shouldn't upgrade to 2.3.100 - that should install side-by-side

To be honest, multiple packages may be a better option as in reality, upgrading .NET Core SDKs doesn't really make sense outside of the patch version incrementing.
So 2.2.200 should upgrade to 2.2.201, but shouldn't upgrade to 2.3.100 - that should install side-by-side

What would be cool is virtual package with an exact version match for that.

Frankly it'd be better to simply not uninstall at all than have the current behavior. I think that's a serious option: it's a mess to leave behind all those files, but that's probably better than breaking stuff. And as @riezebosch points out, there's no simple way to detect what can go and what needs to stay.
Another alternative would be to have multiple choco packages, one for each conceptually major version, but that's a pain too, and breaks the upgrade workflow.

Maybe I can uninstall only from that package range because of course, you don't need to know the target version for that. Only uninstall packages in current range instead of all.

As a consumer of packages that makes sense - but I'm not sure how you'd want to implement that, because their numbering scheme isn't semver or anything.  Each conceptually major version would need some kind implementation to match all packages in its conceptually major range, and that concept may be tricky enough to cause annoying bugs not to mention be a lot of work to implement.
And even then, you'd be making choco upgrade less useful, because you wouldn't even be able to detect that a new major version is out nor have any way of knowing that new major version's package name.
I mean I'd love to see that as a user!  But... I'd be happy with simply not having build machines break on choco upgrade, and the rest is gravy.

If you did go to separate packages, then possibly the existing dotnetcore-sdk ones could become virtual ones that pointed to actual separate ones (for people who wanted to keep using dotnetcore-sdk)
As it is now, I need to remember to use the -m flag when installing new versions of dotnetcore-sdk so they all live side by side.
If they were separate packages, then the semver would probably work as expected..
eg. given a package named dotnetcore-sdk-2.2.30x, you could have versions 2.2.300, 2.2.301, 2.2.302 etc.

Until Microsoft decides to bowl over the versioning scheme once again or they move over to a single update channel on 3.0 ¯_(ツ)_/¯

This should probably resolve part of the problem: https://github.com/dotnetcore-chocolatey/dotnetcore-chocolateypackages/commit/c7f979683129678140e7f9f9e7bc543f50c9b6ff


I would like a target for the previous cursor position

I often use my cursor position as a lightweight memory for where I have been working in a document. I would like a way to use the previous cursor position as a target for working with long documents. This ideally could work with ordinals as well: I.e. "second previous cursor", etc.

See also:

https://github.com/cursorless-dev/cursorless/issues/191
https://github.com/cursorless-dev/cursorless/issues/190


Shrinkwrap does not match package.json

This causes dependent projects not able to use shrinkwrap

I haven't been able to reproduce this issue at all. Are you installing from npm or from another source? The latest version on npm is 2.4.8 which targets<EMAIL_ADDRESS>in both the package.json and npm-shrinkwrap.json.

I've released a new version<EMAIL_ADDRESS>which has an updated shrinkwrap and the new functionality you contributed.


Sroute new

new sroute command
As described in #2209  and #2349, in the design that involves multiple voltage domains, there is no routes from standard cell to another voltage domain that is generated by pdngen. We addressed this issue with the pull request using the original detail router. However, as described in #3071 and #3067. There are some problems when using the existed detail router for special route, in order to adress those problems, we proposed a new router seperated from the original one.
Proposed Command:
All of these commands should be called before global route.
add_sroute_inst: [net] [inst] [iterm] [hDX] [hDY] [vDX] [vDY]
[net] is for finding the net of the inner power ring.
[inst] [iterm] are for fining the pins.
[hDX] [hDY] [vDX] [vDY] indicated the width and length of each wire in power ring for the function to find it.
This command collect all the pins that are suppose to get connected with the power domain.
add_sroute_connection: [net] [outerNet] [layer] [stripDY] [cut_pitch_x] [cut_pitch_y] [techvias] [max_rows] [max_columns] [ongrid] [hDX] [hDY] [vDX] [vDY] [metalWidths] [metalspaces]
[net] is for finding the inner net where the power ring exists.
[outerNet] is for finding the net where instances that need get connected exist.
[layer] is for finding vertical stripe within power ring (DRC checks).
[stripDY] indicated the width of vertical stripe.
[cut_pitch_x] [cut_pitch_y] specify the via pitch.
[techvias] include all the vias that are using for connection.
[max_rows] [max_columns] are indicated the max row count and max column count for multi-cut via array.
[ongrid] include all the layers that are using for connection.
[metalWidths] indicate the width for each metal layer.
[metalspaces] indicate the spacing for each metal layer.
This command creates custom connections from all the collected pins(using add_sroute_inst) to the power ring before global route.
temp sense generator exmaple 1:

exmaple 2:

Please address the CI issues so this review can move forward.

Please address the CI issues so this review can move forward.

Thanks for the notice, it's addressed

Please use clang-format to fix

Please include unit tests (eg examples 1 & 2)

Please clang-format and attend to clang-tidy warnings

Please fix "sroute_test (tcl) FAIL"

Thanks, it's fixed.

The sroute doesn't connect to the pins:

The sroute doesn't connect to the pins:

unit test updated

Is this ready for review or are there more updates to come?

Is this ready for review or are there more updates to come?

I just fixed the last clang-tidy comment, it's ready for review now.

You still need to run clang-format on the code:

You still need to run clang-format on the code:

it's fixed. can run clang-tidy check now.

@Wen-Tian-Pineapple, thanks for addressing my comments.
@maliberty, I think this PR would be good to do "Squash and merge" when ready.

Thanks.

@maliberty somehow the docs check failed, can you rerun the check maybe? thanks!


Unexpected Close when Add repository in set up local machine window

Dev Home version
0.1201.442.0
Windows build number
10.0.26058.1400
Other software
No response
Steps to reproduce the bug
Machine Configuration --> Setup local machine --> + Add repository
Expected result
Open up a window that shows my repos.
Actual result
Unexpectedly close.
Included System Information
No response
Included Extensions Information
No response

/dupe #2485
Hello.  This issue is fixed in #2524 and should be in the next DevHome release.


General thread attributes - Java's Thread.currentThread().getId() is deprecated

Thread.currentThread().getId() is deprecated since java 19. There is a Thread.currentThread().threadId() instead.
Originally posted by @johantiden in https://github.com/open-telemetry/opentelemetry-specification/pull/789#discussion_r1736010637

This would need to be updated in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#general-thread-attributes.

To reiterate:
Thread.currentThread().getId() has been deprecated in favor of Thread.currentThread().threadId(), which is more secure since it can't be overridden.
https://bugs.openjdk.org/browse/JDK-8017617?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel
We should change the example docs to reflect the latest Java LTS version.


Fix an issue about "make check-onnx-backend-dynamic"

Currently "make check-onnx-backend-dynamic" does not test dynamic cases but tests static cases, because "test/backend/common.py" sets the "TEST_IMPORTER_FORCE_DYNAMIC" environment variable, but "test/backend/variables.py" does not process it.
This PR fixes test/backend/common.py to set the IMPORTER_FORCE_DYNAMIC (instead of "TEST_IMPORTER_FORCE_DYNAMIC") environment variable, which is directly processed in the onnx-mlir and onnx-mlir-opt.
This PR disables the following 32 backend tests to pass the Jenkins tests temporally.
We may need to fix the found issues, or may need to change the test conditions, or may confirm/disable them.
I am happy if you kindly look at these tests, resolve them, and report the results at Issue #2639.
=================================== FAILURES ===================================
____________ OnnxBackendNodeModelTest.test_instancenorm_epsilon_cpu ____________
E               subprocess.CalledProcessError: Command '['/workdir/onnx-mlir/build/Debug/bin/onnx-mlir', '-O0', '--constants-to-file-total-threshold=2', '--EmitJNI', '/workdir/onnx-mlir/build/test/backend/Debug/check-onnx-backend-dynamic-jni/test_instancenorm_epsilon/test_instancenorm_epsilon.onnx', '-o=/workdir/onnx-mlir/build/test/backend/Debug/check-onnx-backend-dynamic-jni/test_instancenorm_epsilon/test_instancenorm_epsilon']' returned non-zero exit status 13.
...
/usr/lib/python3.10/subprocess.py:526: CalledProcessError
----------------------------- Captured stderr call -----------------------------
error: failed to materialize conversion for result #0 of operation 'onnx.InstanceNormalization' that remained live after conversion

test_instancenorm_epsilon_cpu
test_instancenorm_example_cpu
test_gathernd_example_float32_cpu
test_gathernd_example_int32_batch_dim1_cpu
test_gathernd_example_int32_cpu
test_castlike_DOUBLE_to_FLOAT_cpu
test_castlike_FLOAT_to_DOUBLE_cpu
test_convtranspose_3d_cpu
test_convtranspose_cpu
test_constant_pad_cpu
test_convtranspose_pad_cpu
test_convtranspose_kernel_shape_cpu
test_convtranspose_output_shape_cpu
test_einsum_transpose_cpu
test_einsum_inner_prod_cpu
test_depthtospace_example_cpu
test_convtranspose_1d_cpu
test_convtranspose_dilations_cpu
test_convtranspose_autopad_same_cpu
test_convtranspose_pads_cpu
test_einsum_batch_diagonal_cpu
test_depthtospace_crd_mode_example_cpu
test_einsum_batch_matmul_cpu
test_einsum_sum_cpu
test_edge_pad_cpu
test_onnxmlir_top_k_float16_cpu                # Test condition fixed. K should be a1D tensor, cannot be dynamic.
test_onnxmlir_top_k_smallest_float16_cpu  # Test condition fixed. K should be a1D tensor, cannot be dynamic
test_reflect_pad_cpu
test_spacetodepth_example_cpu
test_top_k_smallest_cpu                             # Test condition fixed. K should be a1D tensor, cannot be dynamic
test_top_k_cpu                                           # Test condition fixed. K should be a1D tensor, cannot be dynamic
test_top_k_negative_axis_cpu                     # Test condition fixed. K should be a1D tensor, cannot be dynamic

This PR covers and closes PR#2617.

LGTM, I assume that you will continue to look at some of these; please also create an issue on this to track progress. Thanks
@AlexandreEichenberger Thanks for the confirmation. I continue to look at this issue at Issue #2639 .

Jenkins Linux s390x Build #14333 [push] Fix an issue about make ... started at 22:33

Jenkins Linux ppc64le Build #13328 [push] Fix an issue about make ... started at 22:42

Jenkins Linux amd64 Build #14303 [push] Fix an issue about make ... started at 21:34

Jenkins Linux amd64 Build #14303 [push] Fix an issue about make ... passed after 1 hr 7 min

Jenkins Linux s390x Build #14333 [push] Fix an issue about make ... passed after 1 hr 26 min

Jenkins Linux ppc64le Build #13328 [push] Fix an issue about make ... aborted after 1 hr 48 min