A 'declare' modifier cannot be used in an already ambient context.

Important：Please file the issue follow the template, or we won't be able to help you to solve the problem.

0. Report Issue Guide

Please run the following command and check whether the problem has been fixed：
rm -rf package-lock.json
rm -rf node_modules
npm install

Please search in FAQ List first, and make sure your problem has not been solved before.

Please search in the issue first, and make sure your problem had not been reported before

1. Versions

What is your wechaty version?

Answer: 0.60.5

Which puppet are you using for wechaty? (puppeteer/padlocal/service...)

Answer: wechaty-puppet-wechat

What is your wechaty-puppet-XXX（padchat/puppeteer/） version?

Answer: ^0.28.1

What is your node version? (run node --version)

Answer: v15.14.0

What os are you using

Answer:
2. Describe the bug

Give a clear and concise description of what the bug is.

3. To Reproduce

This part is very important: if you can not provide any reproduce steps, then the problem will be very hard to be recognized.

How to create a Minimal, Reproducible Example
Steps to reproduce the behavior:

run '...'
...
...

4. Expected behavior

Give a clear and concise description of what you expected to happen.

5. Actual behavior

If applicable, add screenshots to help explain your problem. But do not paste log screenshots here.

6. Full Output Logs

Set env WECHATY_LOG=silly in order to set log level to silly, then we can get the full log (If you dosen't set log env, log level is info as default, we cannot get the full log)

We need full log instead of log screenshot or log fragments!

Show Logs

node_modules/wechaty/src/io-peer/json-rpc-peer.d.ts:17:3 - error TS1038: A 'declare' modifier cannot be used in an already ambient context.

17   declare module 'json-rpc-peer' {
     ~~~~~~~

node_modules/wechaty/src/io-peer/json-rpc-peer.d.ts:66:5 - error TS2666: Exports and export assignments are not permitted in module augmentations.

66     export default Peer
       ~~~~~~

Found 2 errors.

error Command failed with exit code 2.

7. Additional context

Add any other context about the problem here.

According to https://stackoverflow.com/a/17190172/1123955, we try to remove the declare and please let me know if your issue solved.

tks

You are welcome!


Combined network changes

Combined merge for the following PRs:
IP by offset
https://github.com/amplifylitco/asiaq/pull/43
NAT for AWS
https://github.com/amplifylitco/asiaq/pull/30
Dynamic IP ranges for VPC
https://github.com/amplifylitco/asiaq/pull/42

👍


MH: assignment-1 done in the notebook

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Answering question 3 - added a new function missing_num that identifies missing numbers in a given range [0, n]. Refactored the existing code for better readability and efficiency.
What did you learn from the changes you have made?
Using a boolean list to track presence effectively identifies multiple missing numbers. It also reinforced the importance of handling edge cases, like empty lists or no missing numbers.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, I considered using set operations to find the difference between the complete range and the input list. However, I decided to stick with the boolean list approach for its clarity and straightforwardness.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The main challenge was ensuring the solution correctly handles multiple missing numbers and edge cases in the most efficient way
I tested the function with various input scenarios, including:

Lists with a single missing number
Lists with multiple missing numbers
Empty lists
Lists with no missing numbers

Example test cases were included in the code to demonstrate expected outputs.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[x] I can confirm that my changes are working as intended

A1 complete


Protein only

Hey David,
I am only interested in the protein channels but I would still like to center on the centroid of a ligand (or pseudo-ligand).

I have a working example where I throw away the final 14 channels but this seems like wasted calculation
I have also tried using the NullIndexTyper() for the ligand and while this does only calculate protein channels, it removes the ability to calculate the centroid (and therefore the voxels end up in the wrong place) – a fix for this could be to read the ligand file separately using rdkit and transform using gmaker.forward but I bet the library allows a smarter way!

What should my approach be here? Many thanks again

Sorry for the long delay...
The center calculation only considers typed atoms, which is why the NullTyper won't work.  You will need to construct grids directly from the receptor coordinate set rather than the full example.  For example, assuming ex is an Example with a protein and ligand:
gmaker.forward(ex.coord_sets[1].center(), ex.coord_sets[0], mgridout)

Hey @dkoes thanks for the reply, I don't quite understand even with the above setup I am seeing a zero center, your explanation makes sense but I don't get the solution. Here's some more concrete code
examples = molgrid.ExampleDataset(
    molgrid.defaultGninaReceptorTyper,
    molgrid.defaultGninaLigandTyper,
#     molgrid.NullIndexTyper(),
    data_root=example_data_root,
)
examples.populate(os.path.join(POCKR_REPO_ROOT, 'pockr/tests/test_data/simple_test.types'))

gmaker = molgrid.GridMaker(resolution=1.0, dimension=23, binary=False,
    radius_type_indexed=False, radius_scale=1.5, gaussian_radius_multiple=1.0)
shape = gmaker.grid_dimensions(examples.num_types())

example = examples[0]
coords = example.coord_sets[-1].coords.tonumpy()
center = example.coord_sets[-1].center()
print('the coordinates are empty?: ', not len(coords))
print('the center is calcualted as: ', list(center))

grid = molgrid.MGrid4f(*shape)
gmaker.forward(
    center,
    example.coord_sets[0],
    grid.cpu(),
#     random_translation=0,  # also it seems you cannot use these flags while specifying a center?
#     random_rotation=False,
)
features = np.array([grid.tonumpy()])
features.shape

output using the default typers:
the coordinates are empty?:  False
the center is calcualted as:  [48.474369049072266, 63.45606994628906, -6.453033924102783]
(1, 28, 24, 24, 24)

output using the null typer
the coordinates are empty?:  True
the center is calcualted as:  [0.0, 0.0, 0.0]
(1, 14, 24, 24, 24)

thanks in advance

Thanks a lot @dkoes. Works great! 🙏


Non-admin user should not be able move a folder to a folder where they are not container administrator

Folder creation/move permissions to be cleaned-up
Description

Non-admin user should not be able to create a folder at the root level (configurable solution - turned OFF by default), they can create a folder only in the folders where they are container administrator.

Non-admin user should not be able move a folder to a folder where they are not container administrator (this probably should not be configurable - and is a bug that was not fixed)

Steps to reproduce

Login as non-administrator
Click on create folder, and user can create a folder in the root location.
Move created folder into a subfolder where user is not a container administrator.

Expected behavior
Non-admin user shall not be able to create a folder at the root level or move a folder into a folder where they are not container administrator.
Environment
Please complete the following information:

Mauro Version [7.0.0 / 5.0.0]

@jamesrwelch @olliefreeman This is a continuation of our discussion on permissions. We can have Gail work on this.
@jamesrwelch Based on our previous discussions

creation of the root folder should be configurable in order to make it useful to other Mauro projects. And by default, we should keep the existing behavior, but we could turn it off for us. Correct?
User should never be able to move a folder to a folder where he/she is not a container administrator. I think Ollie confirmed it was a bug. Please confirm.

so theres an open feature request about the configurable creation ability #245
this should have been fixed...i will look at this after the release

@olliefreeman / @jamesrwelch  we have @GBishop-PHSA already working on this? We can contribute the changes once they are done.
Is anyone else working on this already?

i've assigned the feature request to @GBishop-PHSA, i'm going to test the actual bug referenced in this ticket, where a user can move a folder to another folder when they arent a CA for the folder

I am therefore closing, as the original "1" point is already covered in the existing linked feature request ticket

@olliefreeman The issue we're having with moving folders into folders that the user doesn't have permission for, is that:

the UI was calling the Update Folder endpoint [PUT api/folders/${folderId}]
the Folder Interceptor doesn't have access to the destinationFolderId from the Update body of the request
the interceptor always returned True and passed the request to the Folder Controller because the destinationFolderId is set to null.

To fix the issue, I updated the mdm-ui to call the changeFolder endpoint [PUT
api/folders/${folderId}/folder/${destinationFolderId}]
If a folder is moved to the root, using the changeFolder endpoint would set destinationFolderId would be passed in the path as null. I needed to add another endpoint to mdm-core to handle a changeFolder to the root  [PUT
api/folders/${folderId}/folder/]
Most of the fix for part 1 is in mdm-ui and mdm-resources, and then the additional endpoint definition in mdm-core. Do I need to open a ticket for the other 2 repositories?

@olliefreeman  I wanted to verify that the new config to enable/disable limiting users from adding/moving folders to root is following naming convention.
I currently have it named: security.restrict.root.folder and it's a Boolean type.

@GBishop-PHSA wrt the folder moving...i remember now i identified that the UI was using the wrong endpoint, can you just make sure you're code is up to date with the latest develop branch for resources and UI because i could have sworn that particular issue was resolved in the latest release

@olliefreeman Why is this tagged as "not a bug"? Allowing users to create folders where they are not supposed should be prevented. I guess creating the root folder/classifier may be considered as supported functionality, but not that you can move things into the folder where you are not permitted to change the content.

@olliefreeman I stand corrected. I have been retesting all the permissions on a new release 7.1.0/5.1.0 and see that you cannot move a folder into a parent folder (unless you are container administrator on a parent folder).


This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version.

          This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version.

This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Originally posted by @JefriReynaldi in https://github.com/vim/vim/issues/14262#issuecomment-2015366258

Sorry, I don't follow. About what component are you talking?

seems invalid, closing

These are bot spams; Github is plagued by those (some repos more than others). Best you can do is close these quickly and block the accounts for good measure; then the bots will move on to other targets. (No one knows what they are supposed to gain from this. Nature, in her infinite wisdom, is presumably working on it.)

AD, leading you to check its AD. that's its purpose, including this reply then you were into its list.
that would hurt people who just wish to get good bandwidth/entering which (s)he like sites,
wish some xxx mgr kept wisdom which to attack just those crazy, but kept general people access.

Thanks, I have now in addition blocked that bot from the vim organization.


Error installing on Docker [ERROR [21/21] RUN groupadd -g  appuser]

Hello,
I'm trying to install this on a Ubuntu 22.04 server VM with docker, everything is up to date, After I make a folder, clone the repo, edit the docker-compose.yml file to change the port and fired up docker compuse up -d , I get this message:

@0xRenegade could you find a solution to the problem?

Hello, I'm trying to install this on a Ubuntu 22.04 server VM with docker, everything is up to date, After I make a folder, clone the repo, edit the docker-compose.yml file to change the port and fired up docker compuse up -d , I get this message:

Hi. Did you follow the instructions on the README for specifying the user and group in the build options?
https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/tree/master/docker#readme

Hello, I'm trying to install this on a Ubuntu 22.04 server VM with docker, everything is up to date, After I make a folder, clone the repo, edit the docker-compose.yml file to change the port and fired up docker compuse up -d , I get this message:

Hi. Did you follow the instructions on the README for specifying the user and group in the build options?
https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/tree/master/docker#readme

I did read it, and looked information about it but I'm not sure I can do it the right way. Can you give me a hand with it?

The readme describes it just as you need it to be: the error is happening
because PGID and PUID aren't defined, which you need to pass them in as
arguments when running the build command. For example, PUID=1000 PGID=1000
would probably work just fine.
On Fri, Oct 28, 2022 at 10:12 PM 0x7c0sys @.***> wrote:

Hello, I'm trying to install this on a Ubuntu 22.04 server VM with docker,
everything is up to date, After I make a folder, clone the repo, edit the
docker-compose.yml file to change the port and fired up docker compuse up
-d , I get this message:
[image: mRemoteNG_TM3XFSqcxh]
https://user-images.githubusercontent.com/67028277/197859730-2594d110-59fc-4c51-bcd8-83e6e1c50240.png
Hi. Did you follow the instructions on the README for specifying the user
and group in the build options?
https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/tree/master/docker#readme
I did read it, and looked information about it but I'm not sure I can do
it the right way. Can you give me a hand with it?
—
Reply to this email directly, view it on GitHub
https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/issues/48#issuecomment-1295703906,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANWDOB3UBLKNQLYYAE6YOBDWFSI2NANCNFSM6AAAAAAROINQBE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for your reply, I re-did everytihing again as follows:
Cloned the repo, cd into the repo folder and inside of that folder, then mkdir -p ./data/mariadb ./data/app/config ./data/app/saved_qrcode, then sudo PUID="$(id -u)" PGID="$(id -g)" docker-compose up --build -d everything went OK then PUID="1000" PGID="1000" docker-compose up --build -d and it went OK
Only thing I had to do was type sudo before building the image and using docker-compose up, didn't need to edit the docker-compose.yml to add the PGID or PUID,  I assume that was OK too.
But now when I try to access from locally, say <IP_ADDRESS>:8080/install   I get this Forbidden You don't have permission to access this resource. Apache/2.4.38 (Debian) Server at <IP_ADDRESS> Port 8080
If I type <IP_ADDRESS>:8080/install/setup.php like the documentation says I just get a blank page.

The readme describes it just as you need it to be: the error is happening because PGID and PUID aren't defined, which you need to pass them in as arguments when running the build command. For example, PUID=1000 PGID=1000 would probably work just fine.
…
On Fri, Oct 28, 2022 at 10:12 PM 0x7c0sys @.> wrote: Hello, I'm trying to install this on a Ubuntu 22.04 server VM with docker, everything is up to date, After I make a folder, clone the repo, edit the docker-compose.yml file to change the port and fired up docker compuse up -d , I get this message: [image: mRemoteNG_TM3XFSqcxh] https://user-images.githubusercontent.com/67028277/197859730-2594d110-59fc-4c51-bcd8-83e6e1c50240.png Hi. Did you follow the instructions on the README for specifying the user and group in the build options? https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/tree/master/docker#readme I did read it, and looked information about it but I'm not sure I can do it the right way. Can you give me a hand with it? — Reply to this email directly, view it on GitHub <#48 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANWDOB3UBLKNQLYYAE6YOBDWFSI2NANCNFSM6AAAAAAROINQBE . You are receiving this because you were mentioned.Message ID: @.>

Thanks for your reply, I re-did everytihing again as follows:
Cloned the repo, cd into the repo folder and inside of that folder, then mkdir -p ./data/mariadb ./data/app/config ./data/app/saved_qrcode, then sudo PUID="$(id -u)" PGID="$(id -g)" docker-compose up --build -d everything went OK then PUID="1000" PGID="1000" docker-compose up --build -d and it went OK
Only thing I had to do was type sudo before building the image and using docker-compose up, didn't need to edit the docker-compose.yml to add the PGID or PUID, I assume that was OK too.
But now when I try to access from locally, say <IP_ADDRESS>:8080/install I get this Forbidden You don't have permission to access this resource. Apache/2.4.38 (Debian) Server at <IP_ADDRESS> Port 8080
If I type <IP_ADDRESS>:8080/install/setup.php like the documentation says I just get a blank page.
edit: @0xRenegade forgot to reply

You mentioned you're running the docker commands inside a VM on your local machine? Placing it inside a VM would probably make the docker network stuff more confusing, which I couldn't really help you with (I'm not an expert, I just read guides lol).

You mentioned you're running the docker commands inside a VM on your local machine? Placing it inside a VM would probably make the docker network stuff more confusing, which I couldn't really help you with (I'm not an expert, I just read guides lol).

Hey man thanks for your reply.
That shouldn't be an issue, I host a few services from another machine with Docker.
What's odd is that I don't see any Apache server installed in Docker, just the mariaDB.
How did you install it, with or without docker?

You mentioned you're running the docker commands inside a VM on your local machine? Placing it inside a VM would probably make the docker network stuff more confusing, which I couldn't really help you with (I'm not an expert, I just read guides lol).

Hey man thanks for your reply. That shouldn't be an issue, I host a few services from another machine with Docker. What's odd is that I don't see any Apache server installed in Docker, just the mariaDB.
How did you install it, with or without docker?

You'll find the webserver is inside the 'qrcode' container, while the database is inside the 'mariadb' container.
This can be referenced via docker-compose.yml - https://github.com/giandonatoinverso/PHP-Dynamic-Qr-code/blob/master/docker/docker-compose.yml

Hey, I get the same error with user Permission is there any solution?
Thanks a lot!

just released 2.0 version


Bring back "Users may choose interface language"

Description of problem
In previous versions of DNN (8.x.x and under if I am not mistaken), there were 2 cultures ThreadCulture and UICulture.
One was used to handle the content language and the other for the interface language.
One use case for having two languages would be an English admin asked to do something on a Chinese site but the admin does not speak Chinese.

We currently have a setting for "Users can choose interface language" but it does nothing.
At some point (I don't understand the why) but it was decided that ThreadCulture and UICulture would always be the same, which I think was a bad decision.

Description of solution
I think we should bring back that feature, static localization would use a fallback system and go from:

Site language => User Profile locale => Language picker in the Persona Bar (only if "users can choose interface language is on, using personalization I guess).

That would then make the static localization be in that language which will cover all labels and buttons and the PersonaBar leaving the actual module contents in the site language.
Description of alternatives considered
Learn all the languages of a given site :)
Additional context
This would technically be a breaking change and needs to happen only on a major release.
Also we need to do good testing and really call attention to this breaking change in the release notes for 3rd party developers.

I do plan on tackling this for the next major release


fix: dataset options date format

This PR address a silent bug, introduced in the sidebar redesign. PATCH updates were being done everytime the sidebar was closed.

Good catch!


Hide CPU info and encode settings with --quiet

Coverage decreased (-0.3%) to 83.312% when pulling 4c53fe6c45cc331eaeae9d3cf1bb51afe12db616 on shssoichiro:hide-encode-start-quiet into 0c066cbba2637ba0587a8685f7796be5e24a44a5 on xiph:master.

I squashed it out, so no worries there.


Download files directly on website

I believe that Fontsource can do more than just serve NPM packages with the new directory. Ideally, I want to serve as a modern replacement for google-webfonts-helper, which is an amazing tool but has decayed from lack of maintenance.
One feature that could be included on the Fontsource website is the ability to download all the font files and CSS in a zip format. This could be done very easily using JSDelivr as the file host and shouldn't require much custom logic.
UI-wise, it could be similar to the NPM icon button found at the top right corner of each preview.

I would be able to add this to the website if there were a source to download the zip file from. I was thinking we could just add a zip file to the root of each package with a filename of [fontID].zip; e.g. packages/roboto/roboto.zip.

Actually it might not be good for us to add to the NPM package size. It wouldn't be useful to regular NPM users who'd need to download much more. I think we might even hit NPM package size limits for our biggest fonts.
I'd also have concerns abusing JSDelivr's CDN when some of our packages already exceed their size limitations (which JSDelivr has kindly removed for us under fair use).
I was thinking we could host it on our API server instead... which is under development. We should hopefully see the first iteration of it deployed within the next month (without the zip download function)?

I've also updated this issue as an API issue, now that the initial API is officially out.
It would make sense to make the download endpoint first before addressing the website:
GET api.fontsource.org/v1/fonts/:id/download - Which should return a ZIP file.


Could not find any nvml.h during building from source in docker

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.16.1
Custom code
Yes
OS platform and distribution
linux ubutun 20.04
Mobile device
linux ubutun 20.04
Python version
3.11
Bazel version
7.1.1
GCC/compiler version
11.4.0
CUDA/cuDNN version
12.3
GPU model and memory
3090 24G
Current behavior?
I try to build the tensorflow from source code. So I download the docker image and build. However it error during the run ./configure
Standalone code to reproduce the issue
$ git clone https://github.com/tensorflow/tensorflow.git
$ docker pull tensorflow/tensorflow:lastest-gpu
$ docker run --gpus all -it -w /tensorflow -v $PWD:/mnt -e HOST_PERMS="$(id -u):$(id -g)" \
    tensorflow/tensorflow:lastest-gpu bash

# within the container
$ cd mnt/tensorflow
$ ./configure

Relevant log output

root@27cd49d821ca:/mnt/tensorflow# nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Wed_Nov_22_10:17:15_PST_2023
Cuda compilation tools, release 12.3, V12.3.107
Build cuda_12.3.r12.3/compiler.33567101_0

root@27cd49d821ca:/mnt/tensorflow# ./configure
WARNING: current bazel installation is not a release version.
Please specify the location of python. [Default is /usr/bin/python3]:

Found possible Python library paths:
  /usr/lib/python3/dist-packages
  /usr/local/lib/python3.11/dist-packages
Please input the desired Python library path to use.  Default is [/usr/lib/python3/dist-packages]
/usr/local/lib/python3.11/dist-packages
Do you wish to build TensorFlow with ROCm support? [y/N]: N
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]: Y
CUDA support will be enabled for TensorFlow.

Do you wish to build TensorFlow with TensorRT support? [y/N]: N
No TensorRT support will be enabled for TensorFlow.

Could not find any nvml.h in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
        'targets/x86_64-linux/include'
of:
        '/lib/x86_64-linux-gnu'
        '/usr'
        '/usr/local/cuda'
        '/usr/local/cuda/lib64/stubs'
        '/usr/local/cuda/targets/x86_64-linux/lib'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 11]: 12.3

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 2]:

Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:

Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]:

Could not find any nvml.h in any subdirectory:
        ''
        'include'
        'include/cuda'
        'include/*-linux-gnu'
        'extras/CUPTI/include'
        'include/cuda/CUPTI'
        'local/cuda/extras/CUPTI/include'
        'targets/x86_64-linux/include'
of:
        '/lib/x86_64-linux-gnu'
        '/usr'
        '/usr/local/cuda'
        '/usr/local/cuda-12.3'
        '/usr/local/cuda/lib64/stubs'
        '/usr/local/cuda/targets/x86_64-linux/lib'

Asking for detailed CUDA configuration...

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 11]:

@YuMJie,
The latest tensorflow stable v2.16.1 will be compatible with Clang 17.0.6, Bazel 6.5.0, cuDNN8.9 and CUDA 12.3. COuld you please try to follow the same while installing. The nvml.h header file is part of the NVIDIA Management Library (NVML)  which allows programmatic interaction with NVIDIA GPUs.  NVML typically comes bundled with the NVIDIA display driver. Check if you have the latest drivers installed from the official NVIDIA website.
https://github.com/openxla/xla/issues/6923
Thank you!

I found why did not find the nvml.h: If I run git pull  in the dir tensorflow_src  and run building ,it will occur this error. However ,  directly running the build will not have this error .


Failsafe for age gate screen

For https://github.com/project-vagabond/covid-green-app/issues/512
I used the Android split screen feature to simulate small devices. Goals are:

In all reasonable, foreseeable scenarios (including a partially-sighted Russian non-English speaker using the smallest known device we support), show the full app logo, readable text, pressable button and DOH logo, as nicely spaced as possible
In any possible unreasonable, unforeseeable scenarios (e.g. a fad for small square phones breaks out in October or there's some case we missed in testing), ensure that it degrades gracefully and the text and button are prioritised.

I've simulated that using the Android split screen feature. This is in Russian (longest text) at maximum enlarged font size in increasingly unreasonable scenarios:

This is it at normal font size:

It was a bit tight with both the maximum text size increase and the maximum Android "Screen Zoom" applied:

So I've lowered the maximum text size a but further. It still comes out larger than a lot of the maximum-enlarged text in the app:

Latest commit centres things a little more nicely when everything isn't enlarged

Tested on IOS 1st & 2nd gen SE, 8, 8 plus, 11, 11 pro max & XR
Tested initial install, restarting the app and deleting and reinstalling the app
Tested all of the above with largest text size for ios.
Only issue was on 1st gen SE with largest text size, but it's pretty minor

Looks great.
Also tested VoiceOver (iOS), Voice Access (Android) and TalkBack(Android). No problem.
Great job!


Fix duplicate '?' in query part of URI

Upon playing around with version 6 of the API I noticed that it threw errors despite everything being setup correctly when trying to set the volume.
I'm not entirely sure why it happens, all I know is that it has something to do with System.UriBuilder.
It produces an additional ? despite there already being one there, and from reading the sources for UriBuilder it should already check for that, hence why I'm not entirely sure why it happens.
Nevertheless, this is a quick fix to go around the issue.

Hi,
Yes, that's related to #461 but sadly your fix won't work on all framework Versions. In detail, .net core is not affected by the bug and thus the fix would remove all question marks. Could you check if none exists at the end and only add it then? 👍

Ah, that explains it. The bug is quite apparent when checking the source for .NET framework 😉
Your suggestion sounds like it'd work for both cases so I'll go ahead and push that.

Just checked and as far as I can see .NET Core does in fact check if ? already exists, if it doesn't it adds it, where as .NET Framework always adds it if length > 0
With that said, I'm pretty sure that the changes I made should work on both Core and Framework, provided that I'm not missing something still?

Sounds good, will merge and release beta.4 afterwards, thanks for your help 👍🍻

Looks good, 3 requests via .NET Framework 4.6.1 and .NET Core each:

Neat!


Usage Metrics Report Direct Access

It looks like the Usage Metrics report can actually be shared via Direct Access to a user without workspace access using File>Manage Permissions. Our documentation mentions this as a limitation - Sharing is disabled for the usage metrics report. To give people read access to the report, you first need to give them access to the workspace.
Another observation is that the user given the direct access can see Usage Metrics of multiple reports. It's visible in the Filter pane and user can make multiple selection.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f16f558c-a397-7d10-b953-6c8972df9478
Version Independent ID: ffc58ae8-f232-f6d8-f0ea-e4d6001e0e3d
Content: Monitor usage metrics in the new workspace experience (preview) - Power BI
Content Source: powerbi-docs/collaborate-share/service-modern-usage-metrics.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comments and feedback, @rjagdon .
I've assigned this issue to the doc author to review.

Hi, @rjagdon -- thanks so much for your comments! We're working on the update.


Remove toggle to display the spatial map in popup

I have made the map container to be displayed only if the viz type is spatial scatterplot (because it has a fixed height), I have added this part in the HTML_viz operator PR #1142 and it was tested.
However, because it was tested using a udf operator, the entire workflow was not progressive, I realized this has issues if the visualization is progressive.
For now, I am reverting the change, and will work on fixing it later

@sadeemsaleh this is a fix to a bug, so I changed the label to fix instead. It's better if we keep a bug issue about it.


Pasting images

Currently there's no support for pasting images. Trix has this.
Anything I can do to help implement it?

I have an issue open about it here:
#97
If you feel comfortable, feel free to dive in and make a PR. If not, I'll see if I can work on something this weekend.
https://github.com/basecamp/trix/blob/3f22606970e74b78ae1fd7d5204530039ae1b93b/src/trix/controllers/level_2_input_controller.js#L39
The level_2 is probably what we want to support. IIRC the level_0 implementation is for legacy browsers.


Can't set escaper to DummyEscaper

I'm trying to use the DummyEscaper to maintain HTML through an invocation of ruby-handlebars and it seems like this isn't properly included in the gem to be used. Or I'm doing something horribly wrong. I'm trying to set it like this:
hbs.set_escaper(Handlebars::Escapers::DummyEscaper)
To no avail. Am I doing this wrong?

It seems you are right, the DummyEscaper is missing here: https://github.com/SmartBear/ruby-handlebars/blob/2a8ce9ef584f2c34cd5714a4ed36711c2dd9d58a/lib/ruby-handlebars.rb#L5-L8
You can manually include it in your code with:
require 'ruby-handlebars/escapers/dummy_escaper'


Channel nodes have gain < 1 even with volume set to 0 dB

Describe the bug
Using multiple new Channel() or new Channel(0) nodes in series results in very quiet volume.  These nodes don't have unity gain when set to volume of 0 dB.
In my application I'm using Channel.send and Channel.receive all over the place, which is amazing and simplifies my life so much!
However, I started to notice that the more Channel nodes I added, the quieter the sound got...
To Reproduce
Open this JSFiddle and drag the slider to chain multiple channels together, observe the volume meter get quieter the more channels you add: https://jsfiddle.net/micahscopes/qbatvkj1/181/
Expected behavior
I should be able to chain together dozens of new Channel(0) nodes and the source volume will be preserved.
What I've tried
I tried initializing the Channel objects with new Channel(4) and that seemed to roughly preserve the volume.  So the Channel nodes are doing something like -4 dB by default, even when they're set at a volume of 0 dB.
I also looked at the code for Channel and saw that there's some basic unit conversion.  Maybe the bug is in the unit conversion code?

This seems like the same problem as #609
The issue is that Safari has not implemented the StereoPannerNode natively which means that we can't use that browser's native channel mapping and it has to be passed in explicitly for any node that uses the StereoPannerNode under the hood (like Channel and Panner, PanVol).

Shouldn't Channel nodes be stereo by default?

If we set it to either stereo or mono by default, it is going to be wrong some percentage of the time. The only solution for now is to wait until Safari implements this node type.

That makes sense.  For now I just made myself a little wrapper:
import { Channel as ToneChannel } from 'tone';

export class Channel extends ToneChannel {
  constructor(...args) {
    const opts = { channelCount: 2 };
    if (args[0]) {
      opts.volume = args[0];
    }
    if (args[1]) {
      opts.pan = args[1];
    }
    if (args[2]) {
      opts.channelCount = args[2];
    }
    super(opts);
  }
}


version 1.0.0

Version 1.0.0
The version 1.0.0 needs:
Two tabs:

Home
Edit

Tab - Home

Show language state by year
The year should be constrolled with a scrollbar, which can be autoplayed, paused, etc.

Tab - Edit

Edit polygons of the map
Should they be saved in the database or/and file?

I want to save "Complete" polygons into version control, because the EF Core part is made as Code First Approach.
So i shouldn't save into database at all, but only to the file
If someone wants to fork this he might want to save these into database?

Other matters

How data model should look like?

Also, all unnecessary template files from Vue should be deleted. I have keep saving them only because i reuse their code.
It's a worth of consideration to add unit tests into to the project.

First version:
Version 1.0.0
The version 1.0.0 needs:
Two tabs:

Home
Edit

Tab - Home

Show language state by year
The year should be constrolled with a scrollbar, which can be autoplayed, paused, etc.

Tab - Edit

Edit polygons of the map
Should they be saved in the database or/and file?

I want to save "Complete" polygons into version control, because the EF Core part is made as Code First Approach.
So i shouldn't save into database at all, but only to the file
If someone wants to fork this he might want to save these into database?

Other matters

How data model should look like?
Also, all unnecessary template files from Vue should be deleted. I have keep saving them only because i reuse their code.


Not working for YAML schema's.

I did as instructed adding a YAML mediaTypePlugin:
import { validate, addMediaTypePlugin } from '@hyperjump/json-schema/openapi-3-0'
import { pathToFileURL } from 'node:url'
import { join } from 'node:path'
import { load } from 'js-yaml'

const is31 = RegExp.prototype.test.bind(/^3\.1\.\d+(-.+)?$/)
const is30 = RegExp.prototype.test.bind(/^3\.0\.\d+(-.+)?$/)

addMediaTypePlugin("application/yaml", {
  parse: async (response, contentTypeParameters) => {
    const doc = load(await response.text());

    let defaultDialect;
    const version = doc.openapi || contentTypeParameters.version;

    if (!version) {
      throw Error("Invalid OpenAPI document. Add the 'openapi' field and try again.");
    } else if (is30(version)) {
      defaultDialect = "https://spec.openapis.org/oas/3.0/schema";
    } else if (is31(version)) {
      if (!("jsonSchemaDialect" in doc) || doc.jsonSchemaDialect === "https://spec.openapis.org/oas/3.1/dialect/base") {
        defaultDialect = "https://spec.openapis.org/oas/3.1/schema-base";
      } else {
        defaultDialect = `https://spec.openapis.org/oas/3.1/schema-${encodeURIComponent(doc.jsonSchemaDialect)}`;
      }
    } else {
      throw Error(`Encountered unsupported OpenAPI version '${version}' in ${response.url}`);
    }

    return [doc, defaultDialect];
  },
  matcher: (path) => /\.ya*ml$/.test(path)
});

const validSchema = await validate(pathToFileURL(join('doc', 'openapi_spec.yaml')))

But it always fails with

/node_modules/@hyperjump/json-schema/lib/schema.js:26
throw Error(Encountered unknown dialect '${dialectId}');

Also, manually navigating to all the default dialects are Github 404's..
When the defaultDialect is hardcoded to undefined as in the README example, it always throws. No idea why it even tries querying https://json-schema.org/validation
node_modules/@hyperjump/json-schema/lib/schema.js:172
      throw Error(`Failed to retrieve ${id} (${response.status} ${response.statusText})`);
            ^

Error: Failed to retrieve https://json-schema.org/validation (404 Not Found)
    at get (file:///C:/Users/johndoe/project/node_modules/@hyperjump/json-schema/lib/schema.js:172:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Module.get (file:///C:/Users/johndoe/project/node_modules/@hyperjump/json-schema/lib/schema.js:180:7)
    at async compile (file:///C:/Users/johndoe/project/node_modules/@hyperjump/json-schema/lib/core.js:27:18)
    at async validate (file:///C:/Users/johndoe/project/node_modules/@hyperjump/json-schema/lib/core.js:20:20)
    at async file:///C:/Users/johndoe/project/test.js:36:21

There was misconfiguration for OpenAPI 3.0. I just released v1.5.1 to fix the problem. When you update, the error should go away.
However, the next error you'll get is an InvalidSchemaError because you aren't quite using the API correctly. There are two things you can do and what you're doing is somewhere in the middle.
If you're just trying to validate the OpenAPI document, you want something like this,
const openapi = load(readFileSync("doc/openapi_spec.yaml", "utf8"))
const output = await validate("https://spec.openapis.org/oas/3.0/schema", openapi)
console.log(output.valid)

If you want a validator function for a schema in the OpenAPI document, you need to point to the schema you want.
const validateFoo = await validate(pathToFileURL("doc/openapi_spec.yaml") + "#/components/schemas/foo")
const output = validateFoo(42)
console.log(output.valid);

The second example will also validate your whole OpenAPI document and throw an InvalidSchemaError if there's a problem. So, you don't need to validate the OpenAPI document separately if you are using this feature.

Thanks, what I wanted to do was case 2: create a validator for a response in #/components/responses/ResponseType.
I missed the part of the code snippet in the README where it shows the JSON schema ref being used within the validate method (but I saw it now)


[Autocomplete] slow with huge number of items (1mio)

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
We have a huge autocomplete (1mio items).
Performance is slow even though we have both used virtualization and a limit on filter options.  It looks like an internal algo is going over the whole list even though only a few items are eventually going to be visible.
You can check performance on the virtualization demo changed with a larger amount of items and a limit size
https://codesandbox.io/s/virtualize-demo-material-ui-forked-ri9fo4?file=/demo.tsx
Expected behavior 🤔
Faster :-)
Steps to reproduce 🕹
No response
Context 🔦
No response
Your environment 🌎
Order ID 💳
#19458

1 million items is a pretty extreme use case.
I suppose there is a space for optimization in Autocomplete's code. We're happy to accept contributions from the community to improve it.

Not sure if this is still relevant or possible when you have such a large amount but for handling extensive datasets, consider implementing an infinite scroll to load items progressively as users scroll down. This approach, especially useful with the Autocomplete component, minimizes lag by initially displaying a set number of items (e.g., 100 or 200) and loading more upon reaching the list's end. Such a strategy is crucial for datasets reaching up to 1 million entries but may require adjustments for optimal performance.
Moreover, integrating pagination in database queries can enhance performance by reducing the initial load of items. This method needs precise execution to ensure seamless access to items not loaded in the initial query as users navigate further.
To optimize data retrieval and management further, utilize the React cache mechanism provided by next/cache in Next.js. This method efficiently manages large datasets by caching data, like law titles, to decrease load times and enhance user experience. Below is an example of how to integrate caching with the retrieval of law titles using Redis:
import { unstable_cache as cache } from 'next/cache';
import { Redis } from '@upstash/redis';

const redis = new Redis({
  url: 'YOUR_REDIS_URL',
  token: 'YOUR_REDIS_TOKEN'
});

async function getLawTitles(): Promise<string[]> {
  return await redis.zrange('keyname', 0, -1);
}

const getCacheData= cache(
  async () => await getRedisData(),
  ['data'],
  { tags: ['data'], revalidate: 3600 }
);


Background / Map

Add a visually pleasing background.

not super pleasing as of yet, but okay for testing. Unfortunately this has become a side scroller for now :) ...


Refactor calendars: optimize inheritance and scope

Proposed change

The optimizations:

Create custom calandar base class for Buddhist, Chinese, Hindu, and Islamic calendars
Move show_estimated into calendars

Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.926% (+5.0e-05%) from 99.926% when pulling 4e5f5cafb83010e41d03b9d64e2f96c254adeebc on arkid15r:refactor-custom-calendars into 06924e95e52f0fa8881467e11bcb9615a5fe2868 on dr-prodigy:beta.


Deployment of album-viewer fails

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Fork repository
Add Azure credentials + resource group to secrets
Run Github Action to deploy resources + application
Deployment is successful, but in the azure portal under "Revision Management" in the container app, you can see that the deployment is still provisioning and it fails after a few minutes.

Any log messages given by the failure

Expected/desired behavior

Application is healthy and reachable by the àlbum-viewer FQDN.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful
The deployment of the àlbum-viewer container app fails. Liveness as well as readiness probes fail.

Thanks! We'll be in touch soon.

Hi @Freshchris01 thank you for the report.  Most of the time when you see this HTTP probe fail it's because AZD deploy had an issue, and only the NGINX container placeholder is deployed.  After that the probes fail.
I just did a major update and improvement of the deploy files in /infra, so azd up should be good to go.  Could you please verify?  In the future please @ me.  I'm now a maintainer of this.


Using snap package storage explorer have installed on linux system.

Storage Explorer Version:
Build Number:
Platform/OS:
Architecture:
Regression From:
Bug Description

Steps to Reproduce

Expected Experience

Actual Experience

Additional Context

But still no clue to connect from linux box? anyways?

@

Storage Explorer Version:
Build Number:
Platform/OS:
Architecture:
Regression From:
Bug Description
Steps to Reproduce
Expected Experience
Actual Experience
Additional Context

@prasannakalan can you elaborate on what you're asking? We're a bit confused right now.

Closing due to lack of response. Please open a new issue if you're still having problems.


Stripe Payments Rejected: Indian based Merchants

This is with regard to the Freshdesk ticket: https://opencollective.freshdesk.com/a/tickets/32659
It seems that trying to make a payment with an Indian based card gets rejected with the following error on Stripe;

It appears that you are creating a token using a Customer object that contains a card payment source to be shared with a IN-based connected account. As part of our continued investment in India and to meet local data storage requirements, we no longer allow cloning card payment source into or out of India, so we had to reject your request. For more information, please visit https://stripe.com/india-data-storage-faq

We need to investigate more on this and potentially support these cards. 🤔

ping @znarf : Not sure if we should investigate more or prioritize this.

It's a complex one. Let's just answer this to Fiscal Hosts and Independent Collectives based in India.
And send them to other Fiscal Hosts like OSC if they want to accept credit card payments.

It seems that trying to make a payment with an Indian based card

@SudharakaP Here you don't seem to get it right, the credit card doesn't matter, it's the Stripe account being based in India.
Let's just answer this to Fiscal Hosts and Independent Collectives based in India that it's not working for them at the moment due to a Stripe limitation with our setup.
And send them to other Fiscal Hosts like OSC if they want to accept credit card payments.

Thanks for the explanation. I've updated them about this.


Background colour not behaving same as support cards

The support library CardViews use following code to set the default background:

ColorStateList backgroundColor;
if (a.hasValue(R.styleable.CardView_cardBackgroundColor)) {
    backgroundColor = a.getColorStateList(R.styleable.CardView_cardBackgroundColor);
} else {
    // There isn't one set, so we'll compute one based on the theme
    final TypedArray aa = getContext().obtainStyledAttributes(COLOR_BACKGROUND_ATTR);
    final int themeColorBackground = aa.getColor(0, 0);
    aa.recycle();

    // If the theme colorBackground is light, use our own light color, otherwise dark
    final float[] hsv = new float[3];
    Color.colorToHSV(themeColorBackground, hsv);
    backgroundColor = ColorStateList.valueOf(hsv[2] > 0.5f
    ? getResources().getColor(R.color.cardview_light_background)
    : getResources().getColor(R.color.cardview_dark_background));
}

Perhaps it would be nice if the OptionRoundCardview did this as well? I use this library in an app where we are currently implementing a night mode, and adding this code would make the OptionRoundCardview adjust automatically to light and dark themes.

yes, add DayNight mode, upgrade 1.1.0, but not enough test.
'com.github.captain-miao:optroundcardview:1.1.0'


Custom Node styles should be respected when rendered

Describe the Bug
I have set a width and height on my custom node.
When the node is rendered, it renders larger than the dimensions I specified
Your Example Website or App
https://codesandbox.io/s/agitated-pasteur-zuhrf?file=/src/examples/Example1/CustomNode1/index.tsx
Steps to Reproduce the Bug or Issue

Render a custom node, add dimensions to it. For example:

const CustomNode1: React.FC<NodeProps> = ({ data, isConnectable }) => {
  return (
    <>

CustomNode1

    </>
  );
};

After rendering it is rendered in the svg canvas, inspect the element via browser devtools:

Expected behavior

As a user, when I specify the dimensions of my Custom Element, it should be rendered in the dimensions I specified:

Proposed Solution(s)
Add the following CSS rule in the core react-flow library. This would be scoped to anything inside of .react-flow:
/* Use a better box model (opinionated).*/
*,
::before,
::after {
	box-sizing: border-box;
}

A pro of adding this to the core library:

respects specified dimension of nodes out the box
it's only scoped to the .react-flow namespace
css reset/normalization is pretty standard & it's baked most modern JS/CSS libraries. For example:

material UI react has a reset (73k+stars on github)
AntD React (76k stars on github)

Alternative Solution(s) Considered

a user can add the CSS snippet about to their own project

pros: not part of core
cons: adds burden on user, when it might make sense to add this into core for a better experience out of the box

OR a user can add normalize.css or modern-normalize.css to their project

modern CSS resets add automatically add box-sizing: border-box; to all elements since its a best practice nowadays

Platform

OS: MacOS
Browser: Chrome
Version: Latest ( 96.0.xx)

Thanks for the report! In React Flow v10 #1555 we added  box-sizing: border-box; to the .react-flow__node. Do you think this is enough or would you add it to all children?

Hey @moklick - I haven't tried v10 yet. I'll try it out sometime this week.
Are there docs for version 10 yet or is the description of #1551 sufficient enough you feel for migrating?

The description of #1555 is all we have for now ;) And it should be sufficient.

I will close this, since it's solved in v10. W


useRowState cellState is calling cell column ID

From the last update I mention that state of the cellState have changed and now it depending on the cell.column.id, meaning that it will narrow down the object and put the value as is, when originally it was based on the object it self and then per cell I could select the option I wanted. Is there will be an option just narrow down to the object as it was before row.state.cellState but not row.state.cellState[cell.column.id]
Regarding to this line:
row.cells.forEach(cell => {
        cell.state = row.state.cellState || {}

        cell.setState = updater => {
          return setCellState(row.id, cell.column.id, updater)
        }
 })

that was changed to
row.cells.forEach(cell => {
      if (!row.state.cellState) {
        row.state.cellState = {}
      }

      cell.state =
        typeof row.state.cellState[cell.column.id] !== 'undefined'
          ? row.state.cellState[cell.column.id]
          : initialCellStateAccessor(row.original)

      cell.setState = updater => {
        return instance.setCellState(row.id, cell.column.id, updater)
      }
    })

I'm not entirely sure what you're asking. The API changed to keep state located in a safe place whereas before it was easily clobbered and not very centrally located on the row.
More info please?

@tannerlinsley By default cell gets initial state of object which also expect to have a column ID as a cell state:
For example row state is {cellState: { fooBar: "baz" }} in this case it will give a cell a state of "baz", as I remember originally cell state would get entire state of the given property of { fooBar: "baz" }.
I am just wondering why it was changes, and if will be changed later to control your own state shape without calling a row.state.cellState[cell.column.id] as initial state of the cell

I believe it was changed to both give more control and to also be more in line with the cells having their own space in the row state:
row.state = {
  ...customRowState,
  cellState: {
    [column.id]: ...
  }
}

I guess if it helps, you can think of it more like cellState(s) plural, where each cell in the row is referenced by its corresponding column ID.

If this does end up being a bug, we can fix it post release. Thanks!


Does not support lower Android versions ?

Does not support lower Android versions ?
Android 5.x error

@wangyajundev I’m not sure I understand the question. Are you saying an old version of Chrome on Android 5.x doesn’t understand ES Modules?


Print the usage for errors

fixes: #59

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign
/cc @bpradipt @bkhadars

/lgtm


Add initial spec

This Pull Request adds an initial Specification to CDI.
/cc @mrunalp
Signed-off-by: Renaud Gaubert<EMAIL_ADDRESS>

Ping :)

Merging for now, we can open followup pull requests


Changing inactive title buttons in customChrome.css doesn't work

I've managed to change the inactive title buttons (close/minimize/maximize) to be 'always on' (ie. never disappearing to grey) in the actual titlebutton-dark.css file, but if I try and copy the same code to my custom Chrome file, the icons disappear entirely. I've tried appending !important to the end of the url no-repeat, but it still doesn't show in my customChrome. Any insight would be much appreciated.

TLDR; Check the background url in customChrome to point to the file.
CSS has Specificity, meaning that even when using !important, the browser will still apply the most relevant CSS deceleration to an element, which in turn, determines the property value to apply to the element. (good visual example)
Could you share the code you're using in the customChrome and your modification in the titlebutton-dark.css?
The likely issue is that the background URL for the icon is pointing to a file that doesn't exist.
e.g. background: url("../titlebuttons... points up a folder from where that CSS file is, then into the titlebuttons folder to find the image.

Check to see where the titlebuttons folder is from your customChrome file and correctly link it.


if statement suppresses error for ignoring return value

fn foo() -> %void {}
fn main() {
    foo(); // error: return value ignored
    if (true) foo(); // no complaint
}

This mistake is made in elf.zig:236
I have a suspicion this will be solved by the code changes required by #287.

to follow up the issue in elf.zig mentioned above, it appears that io.InStream.close not longer returns an error, so that's fine.
but i did fix a bunch of other cases where this problem was happening, mostly by assigning to _.


Add support for receiving spec constnat parameters as JSON.

Currently the only ways to initialize constants are

specify a cinit arg and define an operator in the spec
supply a TLC config
create an instance and use overrides

None of these will work well for RPC calls as is: as they ether require manipulating the AST of a model or we'd need to extend RPC calls to be able to also take an encoding of a TLC config file.
Instead, we should make this configurable from a SourceOption, and support a simple JSON format, which could then be used for injecting a constant init operator into the spec.

Also related, determining whether cinit is missing should happen earlier, see #1274.


The step 3 says that pact to rescue is not convinced

The consumer fail in step 2 because it does not follow the API that the provider gives instead consumer tests the API response based on its imagination.
Detail: The provider responses with "validate" but the consumer test "date". So how can the consumer would not fail when connect to the real provider?
So I'm not quite sold. Could anyone help to clear my doubts? Thank you very much!

So how can the consumer would not fail when connect to the real provider?

It would fail, this is the point 😄 .
This workshop is about illuminating a typical parallel development flow, where multiple teams are pushing to move quickly and have to make assumptions about how they interact as they go, or just simply make honest mistakes.
Pact enables this fast-paced, collaborative development workflow because it ensures both teams are in lock-step during this phase of development and avoids the "integration phase" of projects where all of these problems take ages to sort out.
Later on, when the code is in production, Pact supports continuous delivery and safety, by ensuring that neither party can make a change without ensuring that the change is supported by all parties.
I'm going to close this, because it's really a discussion about pact, not the workshop itself.

@mefellows
Thank you for your clarification.


chore: remove Status showBullet option

What does it do?
Remove the showBullet option from the Status component. It was a leftover from the CMS v4 designs that is not in use anymore. This v2 RC is our chance to get rid of it (see the comment that was in the code)
Why is it needed?
Cleaning up dead code

@remidej all good, this option is not relevant anymore in v5 :)

Let me check. @HichamELBSI is this okay for the cloud team? I searched your code and it looks like you always pass showBullet={false}. So it won't impact your UI but it means you'll have to remove that prop when upgrading to the latest DS RC

Unfortunately this is used in several places in the Cloud. Do we really need to remove this prop 🤔


how to handle challenge_required

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/story.py", line 189, in user_stories
    return self.user_stories_gql(user_id, amount)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/story.py", line 137, in user_stories_gql
    user = self.users_stories_gql([user_id])[0]
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/story.py", line 107, in users_stories_gql
    res = self.public_graphql_request(
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/public.py", line 197, in public_graphql_request
    body_json = self.public_request(
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/public.py", line 59, in public_request
    return self._send_public_request(url, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/public.py", line 119, in _send_public_request
    return response.json() if return_json else response.text
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3/dist-packages/simplejson/__init__.py", line 518, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 173, in _send_private_request
    response.raise_for_status()
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/feed/user/42792406/story/?supported_capabilities_new=%5B%7B%22name%22%3A+%22SUPPORTED_SDK_VERSIONS%22%2C+%22value%22%3A+%2269.0%2C70.0%2C71.0%2C72.0%2C73.0%2C74.0%2C75.0%2C76.0%2C77.0%2C78.0%2C79.0%2C80.0%2C81.0%2C82.0%2C83.0%2C84.0%2C85.0%2C86.0%2C87.0%2C88.0%2C89.0%2C90.0%2C91.0%2C92.0%2C93.0%2C94.0%2C95.0%2C96.0%2C97.0%2C98.0%2C99.0%2C100.0%2C101.0%2C102.0%2C103.0%2C104.0%22%7D%2C+%7B%22name%22%3A+%22FACE_TRACKER_VERSION%22%2C+%22value%22%3A+%2214%22%7D%2C+%7B%22name%22%3A+%22segmentation%22%2C+%22value%22%3A+%22segmentation_enabled%22%7D%2C+%7B%22name%22%3A+%22COMPRESSION%22%2C+%22value%22%3A+%22ETC2_COMPRESSION%22%7D%2C+%7B%22name%22%3A+%22world_tracker%22%2C+%22value%22%3A+%22world_tracker_enabled%22%7D%2C+%7B%22name%22%3A+%22gyroscope%22%2C+%22value%22%3A+%22gyroscope_enabled%22%7D%5D

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 293, in private_request
    self._send_private_request(endpoint, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 203, in _send_private_request
    raise ChallengeRequired(**last_json)
instagrapi.exceptions.ChallengeRequired: challenge_required

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 293, in private_request
    self._send_private_request(endpoint, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 203, in _send_private_request
    raise ChallengeRequired(**last_json)
instagrapi.exceptions.ChallengeRequired: challenge_required

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 173, in _send_private_request
    response.raise_for_status()
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/feed/user/42792406/story/?supported_capabilities_new=%5B%7B%22name%22%3A+%22SUPPORTED_SDK_VERSIONS%22%2C+%22value%22%3A+%2269.0%2C70.0%2C71.0%2C72.0%2C73.0%2C74.0%2C75.0%2C76.0%2C77.0%2C78.0%2C79.0%2C80.0%2C81.0%2C82.0%2C83.0%2C84.0%2C85.0%2C86.0%2C87.0%2C88.0%2C89.0%2C90.0%2C91.0%2C92.0%2C93.0%2C94.0%2C95.0%2C96.0%2C97.0%2C98.0%2C99.0%2C100.0%2C101.0%2C102.0%2C103.0%2C104.0%22%7D%2C+%7B%22name%22%3A+%22FACE_TRACKER_VERSION%22%2C+%22value%22%3A+%2214%22%7D%2C+%7B%22name%22%3A+%22segmentation%22%2C+%22value%22%3A+%22segmentation_enabled%22%7D%2C+%7B%22name%22%3A+%22COMPRESSION%22%2C+%22value%22%3A+%22ETC2_COMPRESSION%22%7D%2C+%7B%22name%22%3A+%22world_tracker%22%2C+%22value%22%3A+%22world_tracker_enabled%22%7D%2C+%7B%22name%22%3A+%22gyroscope%22%2C+%22value%22%3A+%22gyroscope_enabled%22%7D%5D

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "insta_main.py", line 175, in <module>
    print("Just tried to look for new post, but nothing new!")
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 388, in __get_result
    raise self._exception
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/vb_monitor/instagram-vanguard/src/Story.py", line 33, in newer_media
    newest_media = api.user_stories(account.pk)[-1]
  File "/vb_monitor/instagram-vanguard/src/MultiClient.py", line 50, in user_stories
    return self.select_api().user_stories(user_id)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/story.py", line 195, in user_stories
    return self.user_stories_v1(user_id, amount)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/story.py", line 162, in user_stories_v1
    reel = self.private_request(f"feed/user/{user_id}/story/", params=params)[
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 310, in private_request
    return self._send_private_request(endpoint, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/instagrapi/mixins/private.py", line 203, in _send_private_request
    raise ChallengeRequired(**last_json)
instagrapi.exceptions.ChallengeRequired: challenge_required

How can I handle this error? I tried your example "challenge_resolvers.py" but I can't make it to work either.
Thanks in advance

Related #22


Data processing

Could you please add some details to the README.md which data are being sent to RAILS_AUTOSCALE_URL(https://railsautoscale.com/api/...) when installing the gem and how these data are processed or stored?

Absolutely! I should get to this in the next few days. In the meantime, check out the Reporter spec for an example of the data that's sent to Rails Autoscale.

All right. Thanks.

Hey @jekuno, I updated the README with details about what data is being collected. LMK if you have any other questions/concerns about it.


confusion_matrix.py can not visaulize the results of stuff of the  panoptic segmentation

@YQisme Sorry, there is no support for now.


Devs want deep link support in Widgets SDK

glia://widgets/settings - should route to the settings page.

MOB 2551

!squash


PIPELINE_CSS and PIPELINE_JS in app settings.

Is there any way to add configurations to PIPELINE_CSS and PIPELINE_JS from Django apps?
I have some reusable Django apps I use across my projects and some of them use Django Pipeline. To properly configure them, I end up copying the PIPELINE_CSS and PIPELINE_JS into all the projects setting files. That however I feel does not follow the DRY principle so I wonder if there is any way of including the Pipeline settings directly within the apps so that I don't have to copy the configs.
If there is no existing way to do it, is there any way of incorporating this functionality into Pipeline. Not sure how that should be implemented though.

I've been using this as a workaround. https://github.com/whatisjasongoldstein/django-pipeline-helpers

cool. didnt know about it. I got tired of installing from my fork which is pretty outdated at this point.

seems like there is no need for this PR due to https://github.com/whatisjasongoldstein/django-pipeline-helpers and no interest in merging so closing.


Unable to run circuits on quantum device or on simulators

Describe the bug
I try to run the bell state circuit on the quantum simulator and the rigetti device. Both of them give me the error "'Braket' object has no attribute 'get_device'"
To reproduce
I tried the code below with both pip version and the github version. The errors were the same for both.
import boto3
from braket.circuits import Circuit
from braket.aws import AwsDevice

aws_account_id = boto3.client("sts").get_caller_identity()["Account"]

simulator = "arn:aws:braket:::device/quantum-simulator/amazon/sv1"
# local_simulator = LocalSimulator()
rigetti = "arn:aws:braket:::device/qpu/rigetti/Aspen-8"

device = AwsDevice(simulator)
s3_folder = (f"amazon-braket-output-{aws_account_id}", "RIGETTI")

bell = Circuit().h(0).cnot(0, 1)
task = device.run(bell, s3_folder)
print(task.result().measurement_counts)

Expected behavior
This should run the code on the respective simulators or devices.
Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.

System information
A description of your system. Please provide:

Amazon Braket Python SDK version: amazon-braket-sdk-1.1.3.dev0
Amazon Braket Python Schemas version: amazon-braket-schemas-1.0.2.post1
Amazon Braket Python Default Simulator version: amazon-braket-default-simulator-1.0.0.post2
Python version: 3.7.3

Additional context
Add any other context about the problem here.

Turns out this is a duplicate issue and that running the following command fixes it.
brew uninstall awscli
rm -rf ~/.aws/models/aqx
rm -rf ~/.aws/models/braket
brew install awscli
aws braket help


channelRead is triggered w/ autoRead = false

Expected behavior
No channelRead is triggered on the inbound handler if autoRead is off, and the outbound handler does no read() request.
Actual behavior
After connecting to a server socket, one read seems to happen regardless of the autoRead option:
  .childChannelOption(ChannelOptions.autoRead, value: false)

Subsequent input is not reported (just the first stuff entered in nc).
Steps to reproduce
I have no minimal reproduce setup yet. Lazy.
SwiftNIO version/commit hash
1.1
Swift & OS version (output of swift --version && uname -a)
4.0.3 , macOS

@helje5 thats clearly a bug... let me look into it


Switch to Amplitude main branch

This PR switches to the Amplitude main branch which should always be the case in our master branch and was not done with #4866.

Thanks. Please add the followup instructions to the PR. What do we have to do now?

Nothing, simple merge of this PR. On Amplitude I have already merged two days ago.


hoursDisabled and minutesDisabled bug in IE (method indexof)

this code show error in IE
if ( hoursDisabled.indexOf(i) !== -1) continue;
show has no this method.
could be this?
if (minutesDisabled.indexOf && minutesDisabled.indexOf(i) !== -1) continue;
if (hoursDisabled.indexOf && hoursDisabled.indexOf(i) !== -1) continue;

I have the same problem

+1
Issue is specific for IE8

So IE9+ supports indexOf?

@AuspeXeu just wondered if the solution I proposed in https://github.com/smalot/bootstrap-datetimepicker/issues/330#issuecomment-56265961 would not have been more suitable here; to use the function already provided by jquery rather than adding the indexof code?


Merge master branch to prTesting1_201907091218 branch

Docs Build status updates of commit a6e2bc3:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit a6e2bc3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Moisture or a moisturizer is needed in any ventilator system.

Moisture is a necessity in any ventilation system, because it is important that the lung tissue is not dried out. This issue is usually handled by hardware in the system that adds moisture, or special inline filters or devices. Are there plans to manage moisture in the system?

Could an off-the-shelf nebuliser be teed into the flow path?  They are cheap(ish) at about £50 and already designed / approved for the job.
For example:
https://www.philips.co.uk/c-p/HH1340_00/innospire-essence-compressor-nebulizer-system

You do not want to have to rely on nebulization for humidification.
COVID and other respiratory pathogen illnesses require hospitals to limit the amount of aerosol produced and in contact with the patient.
A heater water device is most desirable especially for secretion clearance, HME (Heated Moisture Exchanger) is suitable for keeping the internal respiratory tract humidified.  HME are usually a filterpaper device in the breathing circuit close to the ET tube.

@Col68 congratulations on your progress.
I believe you are telling us you are close to finishing a PAPR (Positive Air Pressure Respirator).
For the purposes of clairty,  using a "nebulizer" for humidity is not ideal for ventilator purposes.
A medical nebulizer will create excess vapor that is only useful for short periods of time (medication delivery).  Patients with ARDS and COVID do not need excess vapor entering their respiratory tract as it will consolidate into macro water droplets hindering their already "wet" lung from the immune response.  Additionally, it could create a contact vapor hazard in the room where healthcare workers are.  The healthcare workers will absolutly need a PAPR with respiratory droplet grade filtering in such a situation.


Allow cargo rustc -- ... for crates with both libs and binaries without needing to "filter"

At the moment you can't run cargo with specific rustc arguments, like cargo rustc -- -Z no-trans on a crate that contains both a library and a binary. Cargo responds that you should filter the target by using --lib or --bin
extra arguments to rustc can only be passed to one target, consider filtering
the package by passing e.g. --lib or --bin NAME to specify a single target

Why does this limitation exist?
When creating binary crates I often tend to write the core logic in a library in the same crate. This limitation prevents me from running cargo-check on my crates using the linter-rust plugin in Atom for example.
A better way to handle this is would be to have the same behavior as cargo build

cargo build builds everything, whereas cargo rustc only builds one target. If you have multiple targets, you need to disambiguate with extra flags.

Yes, that's what I consider the issue. Why can't the default behavior not be "build everything" instead of fail?

Right, but that's precisely what cargo rustc is not. It is chartered as building one and only one target.

Could you give a compelling reason behind this limitation? :)
The only reason I can see currently for not implementing this is because it would make Cargo more complex. But as cargo build already has the necessary implementation, I figure it should not be that hard to adapt it for this.
As I see it currently it wouldn't break anything to expand cargo rustc to build everything. For crates with one target it would still build that one target, and for crates with multiple targets there would finally be a way to pass custom arguments to rustc for the whole crate.
And this could be useful for better cargo integration in other tools (build tools, IDEs, ...)

Cargo doesn't know what's getting passed to the compiler, so it has no idea if the compiler actually generates an appropriate output. As a result it can't know whether the binary in this case can actually depend on the library because the library may not be generated with a special set of flags.

Ok, now I see. Thanks for the reply :)
I guess I will have to wait for a native cargo check implementation that builds the whole crate to benefit from the shorter "compile" times then. :wink:

Ok, in that case I'll close in favor of that, thanks for the report though!


Mac kext: Fix for potential vnode_put() race in VirtualizationRoot_RegisterProviderForPath

Previously, VirtualizationRoot_RegisterProviderForPath() called vnode_mount() on a vnode that was not guaranteed to have a strong reference on it after the lock was dropped. This patch changes InsertVirtualizationRoot_Locked so it calls vnode_get() on the vnode in the case of an active provider rather than leaving the outer function to deal with it, and VirtualizationRoot_RegisterProviderForPath() now always retains the iocount until after disabling the auth cache, subsequently always dropping it with vnode_put().
Due to the change, InsertVirtualizationRoot_Locked() now also pairs nicely with ActiveProvider_Disconnect(), which tidies up some unit tests a little.
Notes:

This change builds on #1200, this PR is only about the final commit.
This fix first appeared in #500 but as that still has not been merged and #1200 resurfaced the issue, I've submitted it in isolation.

No changes in the latest push, just rebased on latest master to keep the branch fresh while awaiting further review.

I've rebased this branch on master and fixed the conflicts, no changes otherwise.


No pull request was selected to checkout, please try again

I tried checking out the top PR by opening the workspace, right clicking the top and selecting checkout:

I was in pr/jerch/4115 at the time which was a PR I recently merged. On checkout, nothing happened and I saw this error:

A PR does exist for the top one definitely does exist. Is it talking about the PR I just merged recently? If so it shouldn't have been trying to check that out.
Trying to check it out again resulted in a different error (which made sense):

Log
[Info] C:\Users\Daniel\.ssh\config: ENOENT: no such file or directory, open 'C:\Users\Daniel\.ssh\config'
[Info] Looking for git repository
[Info] Found 0 repositories during activation
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Registering git provider
[Info] Repository file:///c%3A/Github/Tyriar/xterm.js has been opened
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] Cannot updates repositories as git is uninitialized
[Info] Review> Queuing additional validate state
[Info] Repo state for file:///c%3A/Github/Tyriar/xterm.js changed.
[Info] Repo file:///c%3A/Github/Tyriar/xterm.js has already been setup.
[Info] Review> Validating state...
[Info] Cannot updates repositories as git is uninitialized
[Info] Git initialization state changed: state=initialized
[Info] Review> Queuing additional validate state
[Info] Review> current branch pr/jerch/4115 is associated with pull request #4115
[Info] Review> Resolving pull request
[Info] Review> no matching pull request metadata found for current branch pr/jerch/4115
[Info] Review> Fetching pull request data
[Info] PullRequestTree> Adding PR #4115 to tree
[Info] Review> register comments provider
[Info] Review> display pull request status bar indicator and refresh pull request tree view.
[Info] Review> using focus mode = false.
[Info] Review> state validation silent = true.
[Info] Review> PR show should show = false.
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Trying to use globalState for mentionable users.
[Info] Using globalState mentionable users for 1.
[Info] Review> current branch pr/jerch/4115 is associated with pull request #4115
[Info] Review> Resolving pull request
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch pr/jerch/4115
[Info] Trying to use globalState for mentionable users.
[Info] Using globalState mentionable users for 1.
[Info] Review> current branch pr/jerch/4115 is associated with pull request #4115
[Info] Review> Resolving pull request
[Info] PullRequestGitHelper> associate pr/jerch/4115 with Pull Request #4115
[Info] Review> no matching pull request metadata found for current branch pr/jerch/4115
[Info] Review> Fetching pull request data
[Info] PullRequestTree> Adding PR #4115 to tree
[Info] Review> register comments provider
[Info] Review> display pull request status bar indicator and refresh pull request tree view.
[Info] Review> using focus mode = false.
[Info] Review> state validation silent = true.
[Info] Review> PR show should show = false.
[Info] PullRequestGitHelper> associate pr/jerch/4115 with Pull Request #4115
[Info] Unexpectedly received undefined when picking a PR.
[Info] Review> switch to Pull Request #4291 - start
[Info] Review> checkout failed #{"message":"Failed to execute git","stdout":"","stderr":"error: Your local changes to the following files would be overwritten by checkout:\n\tsrc/common/buffer/Buffer.ts\nPlease commit your changes or stash them before you switch branches.\nAborting\n","exitCode":1,"gitErrorCode":"DirtyWorkTree","gitCommand":"checkout","gitArgs":["checkout","-q","pr/jerch/4291"],"gitTreeish":"pr/jerch/4291"}
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] Review> Queuing additional validate state
[Info] Found GitHub remote
[Info] Trying to use globalState for mentionable users.
[Info] Using globalState mentionable users for 1.
[Info] Review> current branch pr/jerch/4115 is associated with pull request #4115
[Info] Review> Resolving pull request
[Info] Review> no matching pull request metadata found for current branch pr/jerch/4115
[Info] PullRequestGitHelper> associate pr/jerch/4115 with Pull Request #4115
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Trying to use globalState for mentionable users.
[Info] Using globalState mentionable users for 1.
[Info] Review> current branch pr/jerch/4115 is associated with pull request #4115
[Info] Review> Resolving pull request
[Info] Review> no matching pull request metadata found for current branch pr/jerch/4115
[Info] PullRequestGitHelper> associate pr/jerch/4115 with Pull Request #4115

This error can happen when the tree is in the process of refreshing at the time the command was run.

Closing in favor of the upstream issue: https://github.com/microsoft/vscode/issues/153982


Cant iterate over Array.prototype.entries inside for of loop

I have a problem to iterate inside for of loop over array.entries(). Compiled version of code trys to get length property of array.entries but this property is undefined, coz array.entries returns Iterator which has not length property.
Code
const a: any = [1, 2, 3];

for (const x of a.entries()) {
    console.log(x)
}

Expected behavior:
Code will iterate over a.entries and call console.log()
How it works in babel: Babel Playground
Actual behavior:
Nothing happens, coz no iteration.
Playground Link: Playground

This is working as intended.  If you want full iterable semantics in downlevel emit, turn on the downlevel iteration compiler flag:  https://www.typescriptlang.org/docs/handbook/compiler-options.html

It is ok that my code wont works properly by default and i should use flags for it. I thought that when i set target as ES5 it will compile working code by default.

I believe this has been discussed before, but I couldn't find much in search.  In #https://github.com/microsoft/TypeScript/issues/34572 @DanielRosenwasser states "We have opinionated defaults for downlevel iteration." as a side comment but doesn't elaborate further.


Clean up the un-necessary split for IN/NOT_IN predicates

The values for IN/NOT_IN predicates are already individual values, no need to split
Also remove the dedup logic in compiling phase because it is done in optimizer

LGTM

Codecov Report

Merging #4924 into master will decrease coverage by 0.08%.
The diff coverage is 58.97%.

@@             Coverage Diff              @@
##             master    #4924      +/-   ##
============================================
- Coverage     56.54%   56.46%   -0.09%
  Complexity       53       53
============================================
  Files          1177     1177
  Lines         62894    62857      -37
  Branches       9231     9222       -9
============================================
- Hits          35566    35491      -75
- Misses        24688    24738      +50
+ Partials       2640     2628      -12

Impacted Files
Coverage Δ
Complexity Δ

...pache/pinot/common/utils/request/RequestUtils.java
85.23% <ø> (-0.1%)
0 <0> (ø)

...n/java/org/apache/pinot/core/common/Predicate.java
81.81% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ache/pinot/tools/scan/query/InPredicateFilter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...e/pinot/tools/scan/query/NotInPredicateFilter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rEqualitiesToInClauseFilterQueryTreeOptimizer.java
95.65% <100%> (+2.31%)
0 <0> (ø)
:arrow_down:

...e/pinot/core/common/predicate/BaseInPredicate.java
100% <100%> (+42.85%)
0 <0> (ø)
:arrow_down:

...he/pinot/common/utils/request/FilterQueryTree.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...l/parsers/pql2/ast/RegexpLikePredicateAstNode.java
55.17% <75%> (-6.99%)
0 <0> (ø)

...pinot/pql/parsers/pql2/ast/InPredicateAstNode.java
41.53% <80.95%> (-0.93%)
0 <0> (ø)

...er/validation/BrokerResourceValidationManager.java
25% <0%> (-56.25%)
0% <0%> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaa78d...c86163c. Read the comment docs.


ARM OSX Migrator v2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This "fixes" the outstanding issue with the PyPy builds too (by going back to the last version of meson that worked), pending a proper fix. That should allow the other bot-generated PRs to pass once this goes in.
I've also added myself as a maintainer, since apparently I've been motivated enough by dependencies to contribute to this multiple times, so better to make it official. :grin:

Thanks for your work on this and for volunteering to help!


Patch Rails to fix security vulnerability

Bump Rails gem to 4.1.11 to fix
https://groups.google.com/forum/#!msg/rubyonrails-security/bahr2JLnxvk/x4EocXnHPp8J

Needs to be 4.1.11

Sorted now @boffbowsh :-)


[Feature Request] Autoscroll to last edited position

This would involve diffing the output HTML and adding some sort of tag with an id, I guess. I wonder how this would affect performance and how bullet proof it's going to be. For instance if the markdown file contains HTML and the last change involves changing an HTML tag then simply inserting another tag will break things. Happy to discuss or even better review a PR.

Don't know much about HTML rendering but maybe navigate to the closest tag before the first diff in the output HTML? Or even better if there is some way/api to get an (approximate) mapping from rendered HTML vertical position to HTML source line?


Add unit testing

RD started as a POC but, as it moves to be a real project it needs testing. A framework needs to be added for testing.

Goals for this round:

Manipulate the widgets
Verify emitting on fields happens (with wrapped.emitted, etc.)
Look into selenium/UI-like full-app testing

Goals for this round:

Manipulate the widgets
Verify emitting on fields happens (with wrapped.emitted, etc.)
Look into selenium/UI-like full-app testing

Closed in 8c92884


Remove lockfiles from npm packages

Otherwise we will need to push out an update any time we need to update sub-dependencies

bumped hugo-bin version in package.json


Make SIMIO a standalone Python package

As part of the JOSS review, I appreciate the code is designed to serve as executable functions inside CASA, and I know this would be a bit of a larger effort, but I think it would be highly beneficial if the code were also available as a standalone Python package (on PyPI and thus installable by pip).
The only major addition to the code's core routines would be a method to interface with measurement sets; you could model this after existing packages (or just make them dependencies and import them) such as uvplot and visread. This would also allow users to use the code with modular CASA (e.g., as is done with PRIISM).
This would also allow you to easily integrate things like tests for the code's core routines, automating processes such as the manual tests described in the docs. This would better address the JOSS review guideline Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?.
As a bit of a bigger change (though one that I think would be very useful for users of SIMIO and for code contributors!), this is just a suggestion.
https://github.com/openjournals/joss-reviews/issues/4942

Hi Jeff, thanks for the suggestion.
I have been thinking a lot about this, and at least for this version I would prefer to keep it as an executable. The initial inspiration for the code structure was the hydro-code FARGO 3D, where you work inside the FARGO folder and you can save your setups individually. My thought was to have something similar to FARGO, where you would only need to download SIMIO, and then save the templates and projects individually in a self-contained folder.
I think since the last CASA 6.X versions, CASA tasks can also be called from the python terminal (example), and so a future SIMIO package could be fully integrated in python, but for the current SIMIO I would prefer to keep the folder structure, if possible.

Ok, I appreciate you thinking about this. I think ultimately it would benefit users and maintainers of SIMIO if the package is fully self-contained, but the design choice is yours. I added a suggestion about making the nature of SIMIO a bit more clear in the paper in my comment in #3. I'm happy to close this issue otherwise.


OCPBUGS-25547: PTP metrics still includes metrics for old config after deleting a ptpconfig

fix metrics clean up for GM

/jira-refresh

/test e2e-aws

/test e2e-aws


DartAnalyzer doesn't terminate for Object extends Object under some conditions

$ dartanalyzer --version
dartanalyzer version 1.22.0

$ dartanalyzer test.dart doesn't terminate for:
class Object extends Object { }

class A extends Object { }

class B extends A implements D {
  static E() { }
}

I'm requesting that this bug be treated as a priority. If it doesn't occur in others usages of the tooling, such as Analysis server, please reprioritise accordingly.

https://codereview.chromium.org/2708773002/


Added support for building both an amd64 and arm64 cuda docker image.

Currently amd64 cuda docker images are being built. This adds support to build and push both architectures.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jonatanklosko thank you for opening up a separate PR. I'll close this PR now.


Button to thank the uploader, in Media Details

Unless the user is the uploader.
The code to thank the person who uploaded an image has been implemented already, in Peer Review, it can be reused.
The button could be similar to the Copy Wikitext button, and placed directly below it:

@nicolas-raoul would you be able to paste the link of the PR where this thank author logic is coded?

@srishti-R Sorry not sure about the PR, but the code is called by this button in "Review":

Hi @nicolas-raoul ,I see this issue is still open ,May I work on this?

@awanishyadav967 This one is fixed, sorry for the delay in merging! Would you mind choosing another? :-)


Re-export ambient_authority.

According to docs, this function should be exported.

The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   80.51%   80.51%
=======================================
  Files          78       78
  Lines        6298     6298
=======================================
  Hits         5071     5071
  Misses       1227     1227

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

You are right about this, thanks a lot for the PR @Berrysoft !


Update the examples

ISO Rice (17301-1) 2023 contains a more complex Table 1 and we recently received the following guidelines from ISO:

@ronaldtse should we update the example we use on the website (https://www.metanorma.org/author/topics/blocks/tables/#table-example-1) to contain all these elements?

Yes, @anermina can you help do this? Thanks.


not working any more

bot is not talking any more everybody miss them please bring bot back

bot restarted!


typo "authoruty"

in the section "Option 3: Create a new client secret" it says authoruty instead of authority once.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 11aaa091-1108-52f6-0066-0f4e939aeef4
Version Independent ID: dbc7e37e-87a7-c124-3e4c-47aa060e6cf3
Content: Register a Microsoft Entra app and create a service principal - Microsoft identity platform
Content Source: docs/identity-platform/howto-create-service-principal-portal.md
Service: identity-platform
GitHub Login: @cilwerner
Microsoft Alias: cwerner

#assign @cilwerner

@polarfoxDev
Thank you for bringing this to our attention.
I've resolved the issue and the changes should be live shortly.

#please-close


Button.

Hello alex, how to add button into unfoldable details? Thank you alex

Hi, can't see any problems actually, just put your button into details layout. Checked in sample app and it worked just fine.

Thanks alex for your response, I will try it again.


api: Remove unnecessary API key details.

Fixes #1.
For create-user and google-calendar, the examples did not specify a --api-key argument - I have assumed this to be a mistake and proceeded by removing the single --user options, along with adding the note for the requirement of a .zuliprc file.
The twitter bot man is fixed in #89.

@timabbott updated. Also fixes one faulty example argument for the irc integration.

Nice, merged, thanks for cleaning this up @derAnfaenger!


[NEW]: How crypto giant Binance built ties to a Russian FSB-linked agency

Date
2022-04-23
Description
Russian intelligence agencies received from Binance, the largest crypto exchange in the world, information about users who made large transfers to the Anti-Corruption Foundation (FBK, an organization recognized as extremist and banned in Russia) Alexei Navalny. According to Reuters, Rosfinmonitoring employees agreed on this in April 2021 with the head of Binance for Eastern Europe and Russia, Gleb Kostarev.
Financial intelligence required the exchange to provide customer data, including names and addresses, “to help fight crime.” According to Reuters sources, Kostarev admitted to his partners that he had no choice. The company said that the Russian authorities never contacted Binance about Navalny.
Links
https://www.reuters.com/technology/how-crypto-giant-binance-built-ties-russian-fsb-linked-agency-2022-04-22/
Agreement

[X] I irrevocably agree to release my contribution under the CC-BY 3.0 License

Attribution name
No response
Personal link
No response

Thank you! https://web3isgoinggreat.com/?id=binance-gave-putin-regime-information-on-users-who-donated-to-opposition-leader-alexei-navalny


Set transaction name with :uri option substitutes last '/' with '#'

Description
I am setting a transaction name with the :uri option. The transaction name is constructed and set like so
tx_name = "#{method} #{uri}"
NewRelic::Agent.set_transaction_name(tx_name, category: :uri)

Expected Behavior
With the given values
method="GET"
uri="/feature/v1/users"

I am expecting the transaction name to result in
GET /feature/v1/users

Bug
Due to some server side processing the resulting transaction name looks like so
GET /feature/v1#users

If given the option :uri I do not expect any altering of the transaction name. The replacement with # alters the semantic of the URI, as the # would indicate a URI fragment.

Environment
NewRelic agent 6.15.0
JRuby <IP_ADDRESS>

Thanks for bringing this to our attention. We appreciate it.
I was able to replicate this behavior that you described by following your steps, and can confirm that is what the UI is showing. I ran our audit logs while I tested this, and I was able to confirm that the agent itself is sending this data correctly (as GET /feature/v1/users) to the new relic servers. Unfortunately, any transformations happening on the server side are not something the agent is able to control.
I would recommend that you file exactly what was written to Explorer’s hub (https://discuss.newrelic.com/).
If you are an enterprise customer,  please file a ticket with Technical support (https://support.newrelic.com/).
Since this issue is not a bug within the agent code, I’ll be closing this issue.