[firebase_database]: When listening to '.info/connected' and display turns off, the connection state value flaps between true and false

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Database
Which platforms are affected?
iOS
Description
When listening to '.info/connected' and display turns off while the app is still in foreground, the connection state value flaps between true and false and is eventually true even though the client has disconnected from the server.
I know the client has disconnected because I'm creating a database entry at the first startup of the app and registering an onDisconnect() callback, which removes this entry from the database when the app disconnects.
So when I turn off the display, the database entry gets removed but the value of the local listener is eventually true.
This way I cannot reliably handle the connection state. Is that a bug? Do you have any suggestions to deal with this behavior?
Reproducing the issue
Just use the sample from https://firebase.google.com/docs/firestore/solutions/presence
Stream<DatabaseEvent> deviceConnectionStatus() {
    try {
      return _firebaseDatabase.ref('.info/connected').onValue;
    } catch (e) {
      debugPrint(e.toString());
      return Stream.error(e);
    }
}

deviceConnectionStatus().listen((event) {
    final isConnected = event.snapshot.value as bool?;
    debugPrint('isConnected: $isConnected');

    if (isConnected == null) return;

    if (isConnected) {
      debugPrint('ONLINE');
      // Logic
    } else {
      debugPrint('OFFLINE');
      // Logic
    }
});

Firebase Core version
3.5.0
Flutter Version
3.24.3
Relevant Log Output
Log output from debugLogs from above code sample:
flutter: isConnected: false
flutter: OFFLINE
flutter: isConnected: true
flutter: ONLINE
flutter: isConnected: false
flutter: OFFLINE
flutter: isConnected: true
flutter: ONLINE

$ flutter doctor -v
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.0 24A335 darwin-arm64, locale en-US)
    • Flutter version 3.24.3 on channel stable at /Users/chris/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (2 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/chris/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (4 available)
    • Chris’s iPhone (mobile)         • 00008130-000970383EE0001C • ios            • iOS 18.0 22A3354
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 15.0 24A335 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 15.0 24A335 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 129.0.6668.60

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.5.3
Flutter SDK 3.24.3
cirqles 0.4.0+20

dependencies:
- async 2.11.0 [collection meta]
- badges 3.1.2 [flutter]
- cached_network_image 3.4.1 [cached_network_image_platform_interface cached_network_image_web flutter flutter_cache_manager octo_image]
- cloud_firestore 5.4.2 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 5.1.2 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- cupertino_icons 1.0.8
- firebase_analytics 11.3.2 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 5.3.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 3.5.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 4.1.2 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_database 11.1.3 [firebase_core firebase_core_platform_interface firebase_database_platform_interface firebase_database_web flutter]
- firebase_messaging 15.1.2 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_storage 12.3.1 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_app_badge_control 0.0.1 [flutter plugin_platform_interface]
- flutter_cache_manager 3.4.1 [clock collection file flutter http path path_provider rxdart sqflite uuid]
- flutter_linkify 6.0.0 [flutter linkify]
- flutter_local_notifications 17.2.3 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_map 7.0.2 [async collection dart_earcut flutter http latlong2 logger meta polylabel proj4dart vector_math]
- flutter_native_splash 2.4.1 [args flutter flutter_web_plugins html image meta path universal_io xml yaml ansicolor]
- font_awesome_flutter 10.7.0 [flutter]
- geocoding 3.0.0 [flutter geocoding_platform_interface geocoding_android geocoding_ios]
- geolocator 13.0.1 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web geolocator_windows]
- hive 2.2.3 [meta crypto]
- hive_flutter 1.1.0 [flutter hive path_provider path]
- html 0.15.4 [csslib source_span]
- http 1.2.2 [async http_parser meta web]
- image 4.2.0 [archive meta xml]
- image_cropper 8.0.2 [flutter image_cropper_platform_interface image_cropper_for_web]
- image_picker 1.1.2 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_linux image_picker_macos image_picker_platform_interface image_picker_windows]
- intl 0.19.0 [clock meta path]
- latlong2 0.9.1 [intl]
- provider 6.1.2 [collection flutter nested]
- rxdart 0.28.0
- shimmer 3.0.0 [flutter]
- smooth_page_indicator 1.2.0+3 [flutter]
- timeago 3.7.0 [intl]
- transparent_image 2.0.1
- url_launcher 6.3.0 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 4.5.0 [crypto sprintf meta fixnum]

dev dependencies:
- build_runner 2.4.12 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_lints 5.0.0 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]
- hive_generator 2.0.1 [build source_gen hive analyzer source_helper]

dependency overrides:
- build_runner 2.4.12 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_app_badge_control 0.0.1 [flutter plugin_platform_interface]
- font_awesome_flutter 10.7.0 [flutter]
- hive_generator 2.0.1 [build source_gen hive analyzer source_helper]

transitive dependencies:
- _fe_analyzer_shared 72.0.0 [meta]
- _flutterfire_internals 1.3.43 [collection firebase_core firebase_core_platform_interface flutter meta]
- _macros 0.3.2
- analyzer 6.7.0 [_fe_analyzer_shared collection convert crypto glob macros meta package_config path pub_semver source_span watcher yaml]
- ansicolor 2.0.3
- archive 3.6.1 [crypto path]
- args 2.5.0
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.1 [analyzer async convert crypto glob logging meta package_config path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 4.0.2 [built_collection built_value crypto http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.4.2 [analyzer async build collection convert crypto graphs logging package_config path pool pub_semver stream_transform yaml]
- build_runner_core 7.3.2 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta package_config path pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.9.2 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 4.1.1 [flutter flutter_cache_manager]
- cached_network_image_web 1.3.1 [cached_network_image_platform_interface flutter flutter_cache_manager web]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- clock 1.1.1
- cloud_firestore_platform_interface 6.4.2 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 4.3.1 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins]
- cloud_functions_platform_interface 5.5.36 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.10.1 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- code_builder 4.10.0 [built_collection built_value collection matcher meta]
- collection 1.18.0
- convert 3.1.1 [typed_data]
- cross_file 0.3.4+2 [meta web]
- crypto 3.0.5 [typed_data]
- csslib 1.0.0 [source_span]
- dart_earcut 1.1.0
- dart_style 2.3.7 [analyzer args collection package_config path pub_semver source_span]
- dbus 0.7.10 [args ffi meta xml]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.3
- file 7.0.0 [meta path]
- file_selector_linux 0.9.2+1 [cross_file file_selector_platform_interface flutter]
- file_selector_macos 0.9.4+1 [cross_file file_selector_platform_interface flutter]
- file_selector_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- file_selector_windows 0.9.3+2 [cross_file file_selector_platform_interface flutter]
- firebase_analytics_platform_interface 4.2.4 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.10+1 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- firebase_auth_platform_interface 7.4.6 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.13.1 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser meta web]
- firebase_core_platform_interface 5.3.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.18.1 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- firebase_crashlytics_platform_interface 3.6.43 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_platform_interface 0.2.5+43 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_web 0.2.6+1 [collection firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plugins]
- firebase_messaging_platform_interface 4.5.45 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.9.1 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins meta web]
- firebase_storage_platform_interface 5.1.30 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.10.1 [_flutterfire_internals async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http meta web]
- fixnum 1.1.0
- flutter_local_notifications_linux 4.0.1 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories]
- flutter_local_notifications_platform_interface 7.2.0 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.22 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- frontend_server_client 4.0.0 [async path]
- geocoding_android 3.3.1 [flutter geocoding_platform_interface]
- geocoding_ios 3.0.1 [flutter geocoding_platform_interface]
- geocoding_platform_interface 3.2.0 [flutter meta plugin_platform_interface]
- geolocator_android 4.6.1 [flutter geolocator_platform_interface meta uuid]
- geolocator_apple 2.3.7 [flutter geolocator_platform_interface]
- geolocator_platform_interface 4.2.4 [flutter plugin_platform_interface vector_math meta]
- geolocator_web 4.1.1 [flutter flutter_web_plugins geolocator_platform_interface web]
- geolocator_windows 0.2.3 [flutter geolocator_platform_interface]
- glob 2.1.2 [async collection file path string_scanner]
- graphs 2.3.2 [collection]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image_cropper_for_web 6.0.2 [flutter flutter_web_plugins image_cropper_platform_interface web]
- image_cropper_platform_interface 7.0.0 [flutter plugin_platform_interface http]
- image_picker_android 0.8.12+13 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 3.0.5 [flutter flutter_web_plugins image_picker_platform_interface mime web]
- image_picker_ios 0.8.12 [flutter image_picker_platform_interface]
- image_picker_linux 0.2.1+1 [file_selector_linux file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_macos 0.2.1+1 [file_selector_macos file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_platform_interface 2.10.0 [cross_file flutter http plugin_platform_interface]
- image_picker_windows 0.2.1+1 [file_selector_platform_interface file_selector_windows flutter image_picker_platform_interface]
- io 1.0.4 [meta path string_scanner]
- js 0.7.1
- json_annotation 4.9.0 [meta]
- leak_tracker 10.0.5 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 3.0.5 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 3.0.1 [leak_tracker matcher meta]
- linkify 5.0.0
- lints 5.0.0
- lists 1.0.1 [meta]
- logger 2.4.0
- logging 1.2.0
- macros 0.1.2-main.4 [_macros]
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.11.1 [collection]
- meta 1.15.0
- mgrs_dart 2.0.0 [unicode]
- mime 1.0.6
- nested 1.0.0 [flutter]
- octo_image 2.1.0 [flutter]
- package_config 2.1.0 [path]
- path 1.9.0
- path_provider 2.1.4 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.2.10 [flutter path_provider_platform_interface]
- path_provider_foundation 2.4.0 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.2 [flutter platform plugin_platform_interface]
- path_provider_windows 2.3.0 [ffi flutter path path_provider_platform_interface]
- petitparser 6.0.2 [meta]
- platform 3.1.5
- plugin_platform_interface 2.1.8 [meta]
- polylabel 1.0.1 [collection]
- pool 1.5.1 [async stack_trace]
- proj4dart 2.1.0 [mgrs_dart wkt_parser meta]
- pub_semver 2.1.4 [collection meta]
- pubspec_parse 1.3.0 [checked_yaml collection json_annotation pub_semver yaml]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 2.0.0 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.5.0 [analyzer async build dart_style glob path source_span yaml]
- source_helper 1.3.4 [analyzer collection source_gen]
- source_span 1.10.0 [collection path term_glyph]
- sprintf 7.0.0
- sqflite 2.3.3+1 [flutter sqflite_common path]
- sqflite_common 2.5.4+3 [synchronized path meta]
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- synchronized 3.3.0+2
- term_glyph 1.2.1
- test_api 0.7.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- timezone 0.9.4 [path]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.2 [collection]
- unicode 0.3.1 [lists]
- universal_io 2.2.2 [collection meta typed_data]
- url_launcher_android 6.3.10 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.3.1 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.2.0 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.2.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.3.2 [flutter plugin_platform_interface]
- url_launcher_web 2.3.3 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.2 [flutter url_launcher_platform_interface]
- vector_math 2.1.4
- vm_service 14.2.5
- watcher 1.1.0 [async path]
- web 1.1.0
- web_socket 0.1.6 [web]
- web_socket_channel 3.0.1 [async crypto stream_channel web web_socket]
- wkt_parser 2.0.0
- xdg_directories 1.0.4 [meta path]
- xml 6.5.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Additional context and comments
No response

Hi @justChris , thanks for submitting this report. I am able to reproduce this issue. We will investigate further and provide feedback. Thanks!

Hi @justChris , I’ve tested this issue with the latest version of firebase_database but wasn’t able to reproduce it. Could you update to the latest version and give it another try?

Hi @justChris , thanks for submitting this report. I am able to reproduce this issue. We will investigate further and provide feedback. Thanks!

@SelaseKay here you said you could reproduce the issue. Did you then update the package which fixed the issue?

Correct. I could reproduce this issue initially on an older version.  Updating the packages seems to resolve the issue on my end.

@SelaseKay I have tested it and the flapping as well as the wrong eventual connection state is gone.
Now the listener does not fire at all when the display turns off. Also the Database entry does not get removed immediately when display turns off. It seems iOS does not immediately cut the connection anymore when display turns off.
I have the feeling it works more like android does now.
I still have to test how it is behaving now when display turns off and then the internet connection is lost on the device.
I assume the database entry gets removed like expected, but I have to check how the local listener behaves.
I will give feedback.

@SelaseKay I have tested it now and it seems to be working as expected finally.
When I turn off the display, the listener does not fire at all and the Database Entry does not get removed as I described before.
When I set my device to airplane mode then, the listener fires immediately as expected (log output below) and the Database entry gets removed after a while, when the onDisconnect callback fires.
Log Output:
flutter: isConnected: false
flutter: OFFLINE

Now everything seems to be working as expected and this issue can be closed. Thank you @SelaseKay for your professional and kind support.

After a little more testing, I noticed that the listener's behavior differs from debug to release mode. I added a small debug box in my app to demonstrate that.
In debug mode on initial app start the listeners fires false and again true. When I turn off the display, the listener does not fire again neither it does when the display turns back on.

In release mode on initial app start the listeners fires false and again true as well as in debug mode. When I turn off the display, the listener does not fire as well as in debug mode.

But when I turn the display back on, the listener fires false and then true.

Anyways this seems to be correct and I can work with this behavior. I just wanted to share this information with you.

I let this debug box in place for a while and used and tested my app. I noticed that sometimes there is still a flapping when I turn the display back on. This seems to happen randomly. When the flapping happens it fires false, true, false, true.

Since I create a database entry and register a onDisconnect callback every time the isConnected value is true this flapping left me a zombie entry, which will never be deleted.
So this is unfortunately still not reliable. Somehow I have to debounce this flapping myself.
Just wanted to let you know in case you want to reproduce this behavior @SelaseKay

I suspect this behaviour could be coming from the native sdk which I believe is intended. For more clarification, it would be best to raise this on firebase-ios-sdk.

I will do that, thank you.

This issue will be further investigated in https://github.com/firebase/firebase-ios-sdk/issues/13877


Problem with idx

Hi! I have trouble with inputModelIndex. In my array index is choosing wrong. I solved this by comparasion unique fields, but this is not good way. Thanks.
P.S. Sorry for my english.

@ubcent ,
I'm not sure I understand the problem. Perhaps you can replicate it in JsFiddler or Plunker.
But if you're happy with the solution, then I guess it's OK.

Hi,
First of all thanks for this great directive )
I cannot create Plunker for this right now, but I think I'm having a similar problem.
I guess the problem is in this snippet (when we have a grouping feature enabled):
// we refresh input model as well
inputModelIndex = $scope.filteredModel[ j ][ $scope.indexProperty ];
$scope.inputModel[ inputModelIndex ][ $scope.tickProperty ] = true;
We're getting entry index from filteredModel but it is not correct index for inputModel.
In my case, i'm getting the tickProperty = true added for wrong elements in inputModel (e.g. my group elements) which should not happen.
My initial inputModel (As you see, my first group is empty in this case):
[
{
"name": "Group1",
"group": true
},
{
"group": false
},
{
"name": "Group2",
"group": true
},
{
"name": "Entry1",
"type": "t1",
"selected": false
},
{
"name": "Entry2",
"type": "t2",
"selected": false
},
{
"group": false
}
]
After clicking on group element, instead of adding "selected": true for Entry1 and Entry2, the logic changes the first end of group and beginning of Group2.
I was able to brute force this like that but i guess there's got to be a better solution:
// we refresh input model as well
inputModelIndex = $scope.filteredModel[ j ][ $scope.indexProperty ];
$scope.inputModel.forEach(function(entry){
if (entry[$scope.indexProperty] === inputModelIndex){
entry[ $scope.tickProperty ] = true;
}
})
Hope this helps

I think the root cause is how index is calculated in $scope.prepareIndex function:
All the cases using indexProperty are treating it as the index of inputModel items, but its value is actually calculated from filteredModel.
When inputModel is updated WHILE search is not empty, the index of filteredModel items will not be the same the the ones in inputModel, which will cause this problem: when I use group selection and select some items, some other items will be selected mistakenly.


[ISSUE-2730] Add the number of unseq merge times in TsFile name.

Description
Hi all :
I have submitted a pr for ISSUE-2730, please take a look.
This issue about add the number of unseq merge times in TsFile name.
The modules involved are as follows:
   1、server/engine/merge
   2、server/engine/storagegroup
Content1 ...
Content2 ...
Content3 ...

This PR has:

[ ] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

have a EROR, need deal..
Error:  Failures:
Error:    MergeTaskTest.mergeWithDeletionTest:401 expected:<70> but was:<50>


Porting to Gtk3

There is a package from the gtk2hs project for gtk3. Is there intention of porting or are technical reason for not doing it?

I am interested in porting.  I haven't looked in to what would be required yet, but I can't imagine any technical reasons not to.  The biggest pain would probably be with gtk-traymanager, though I suspect that wouldn't be too difficult.

Any news on this one? gentoo-haskell has dev-haskell/gtk masked in favor of dev-haskell/gtk3

It hasn't been a high priority for me, so I haven't looked in to it yet.


ComponentEvent API

It might be more useful to use { type, value } instead of { type, event }. Some events send back a ReactEvent while others send raw values or other object types (e.g. React Native's TextInput onChangeText responds with a string value of the input).
This would be a breaking change, though, so would require a major version increment.

7c3d28bbd064cd4d30868e95958f42ddd683d036


Broken Link

Describe the bug
The link to "illusion of choice" is broken. This link exists in the 2nd paragraph of the "Introduction to Ethics" page.
To Reproduce
Steps to reproduce the behavior:

Go to '02 - Ethics'
Click on 'illusion of free choice' in the 2nd paragraph
Scroll down to '....'
The website returns a "Page Not Found"

Expected behavior
The link should navigate to the article.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

thanks for the advice 517


Bump bosh-aws-cpi release to 44.

What
In this PR we are raising the version of bosh_aws_cpi that includes a fix for max retries for calls to AWS.
bosh-aws-cpi-release v 44 exposes AWS SDK retry option (max_retries) with default of 2
Reference Changelog
This PR should be merged before https://github.com/alphagov/paas-cf/pull/107
How to test
Use bosh-init container do deploy microbosh and check whether you are getting any 'Rate limit exceeded' errors. You need to modify concourse/pipelines/create-microbosh.yml and add #112411703-bump-bosh-aws-cpi-release tag to the bosh-init contaier. For instance:
image: docker:///governmentpaas/bosh-init#112411703-bump-bosh-aws-cpi-release
Who can test
Anyone but @actionjack or @combor

Tested by modifying the pipelines in alphagov/paas-cf#107:
gsed -ri 's|(governmentpaas/bosh-init)|\1#112411703-bump-bosh-aws-cpi-release|' concourse/pipelines/*

Confirmed that cached CPI was used:
Started installing CPI
  Compiling package 'ruby_aws_cpi/a5b66d011ce1b31642ff148ea2c9097af65ff78c'... Finished (00:00:00)
  Compiling package 'bosh_aws_cpi/42af924166054d90b6e4a15a9df0be93c0e5e413'... Finished (00:00:00)
  Installing packages... Finished (00:00:04)
  Rendering job templates... Finished (00:00:01)
  Installing job 'aws_cpi'... Finished (00:00:00)
Finished installing CPI (00:00:06)

I'll leave a note in the other PR about how this will affect people with existing Deployer Concourse machines.


FacetFilter select dialog footer ok button needs margins

OpenUI5 version: 1.71.14
Browser/version (+device/version): any
Any other tested browsers/devices(OK/FAIL): no
URL (minimal example if possible):
https://openui5nightly.hana.ondemand.com/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterSimple
Steps to reproduce the problem:
You have to use chrome ui5 inspector to set
showPopoverOKButton: true
on FacetFilter to see the button in the footer.
What is the expected result?
The button should follow Fiori 3 Design Guidelines adding some margins around.
What happens instead?
The button is shown without padding.
Since we are using the longterm maintenance version 1.71.x it would be great getting this fix into it.
Maybe if there is an release date for a new longterm maint version, please let me know. I would like to upgrade using the new button types.
Regards Holger
Any other information? (attach screenshot if possible)

Hello @hschaefer123 ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Diana

Hello @hschaefer123,
Thank you for sharing this finding.
The issue is fixed for the latest version of UI5 and
the fix will be available for UI5 version 1.79 around 18th of June.
The fix isn't eligible for downport according to the downporting guides,
since the issue doesn't affect any interaction and it is only visual.
Best Regards,
Boyan


Cannot create a new folder in Workspace

Hi,
I am having an issue where I cannot create a folder in the Workspace in the develop branch. It has been a while that I was able to create a folder. Interestingly, I can still create a subfolder under an already existing folder.
In the meantime, my workaround is, I created a folder inside an already existing folder then drag it to the Workspace. Now I have a new folder on the Workspace.
Thanks

@obgeneralao Which version of Xerte Toolkits are you using? Any error messages in the php log on or in the browser's console?

Hi
I am on develop branch.
Attached is the debug file when I created a new folder.
debug.log

I cannot reproduce on my install of develop.
It would be good to see the php error log, which you can normally find in the apache2 error log.

This what I got in apache2/logs/error_log. The timestamp is consistent with the debug.log file.
[Thu Jun 24 06:21:38.700329 2021] [mpm_prefork:notice] [pid 1643] AH00169: caught SIGTERM, shutting down
[Thu Jun 24 06:21:52.743577 2021] [ssl:warn] [pid 19867] AH01882: Init: this version of mod_ssl was compiled against a newer library (OpenSSL 1.1.1j  16 Feb 2021, version currently loaded is OpenSSL 1.1.1i  8 Dec 2020) - may result in undefined or erroneous behavior
[Thu Jun 24 06:21:52.770590 2021] [ssl:warn] [pid 19868] AH01882: Init: this version of mod_ssl was compiled against a newer library (OpenSSL 1.1.1j  16 Feb 2021, version currently loaded is OpenSSL 1.1.1i  8 Dec 2020) - may result in undefined or erroneous behavior
[Thu Jun 24 06:21:52.802623 2021] [mpm_prefork:notice] [pid 19868] AH00163: Apache/2.4.46 (Unix) OpenSSL/1.1.1i PHP/7.3.27 configured -- resuming normal operations
[Thu Jun 24 06:21:52.802655 2021] [core:notice] [pid 19868] AH00094: Command line: '/opt/lampstack-7.3.27-2/apache2/bin/httpd.bin -f /opt/lampstack-7.3.27-2/apache2/conf/httpd.conf'
[Thu Jun 24 06:21:54.055867 2021] [php7:warn] [pid 19877] [client <IP_ADDRESS>:31966] PHP Warning:  Invalid argument supplied for foreach() in /opt/lampstack-7.3.27-2/apps/xerte/htdocs/xerteonlinetoolkits/website_code/php/display_library.php on line 728, referer: https://my.olibgen.com/xerte/
[Thu Jun 24 06:21:56.144133 2021] [php7:warn] [pid 19877] [client <IP_ADDRESS>:31966] PHP Warning:  Invalid argument supplied for foreach() in /opt/lampstack-7.3.27-2/apps/xerte/htdocs/xerteonlinetoolkits/website_code/php/display_library.php on line 728, referer: https://my.olibgen.com/xerte/
[Thu Jun 24 06:24:18.235082 2021] [mpm_prefork:notice] [pid 19868] AH00169: caught SIGTERM, shutting down

Ok. So that does not explain anything. Are you using the latest develop? I still cannot reproduce.

Ok, I probably fixed this in d5b2b0046a10d4b5c79e7e733afcbeb1bfc9885c. Could you please verify?

Still do not understand why I could not reproduce, but it was definitely a bug.

Hi,
This is very interesting. I still could not create new folders in Workspace using Google Chrome and Edge even updating the develop branch. However, I successfully created the folder in Workspace with IE 11.

Caching?

There. It is working now in all 3 browsers. Thank you very much.


Revisit date picker

The date picker is still annoying to work with - typing dates often does not work because the calendar widget overlays the input field (Chrome, full screen), and selecting years is cumbersome. Arguably, we want widgets which are convenient for historical dates, while most calendar widgets are designed for picking dates close to the current date.

agreed, i don't think having a calendar widget is really appropriate here.
As a side note, modern browsers generally have a built-in calendar widget with <input type="date">. If that improves compatibility, it's a minimal change.
I would welcome a redesign!
One issue that I have with the calendar is that you often use a rough filter on dates, where you only care about the exact date (e.g "after 1980"), but now you always have to select a specific day anyway.


Expose PlutusDataEnum to WASM

Fix the issue mentioned in Discord.

This looks like it's necessary because the type definition gets exported as part of the JSON type definition of PlutusData


Fixes #4217 Adds notifications

Created a class to define notification-objects, which should notify other persons editing the same motion.
Added functions to send notifications, listen to them and unsubscribing them.
Added a warning-function to the base-view.ts, which raises the snack bar with the given message and has no duration.

Fixes #4217

Removed unnecessary lines of code.
Fixed merge.

Can you tell me your steps, how I can reproduce this

Tested: Can't see any notifications. Get a TypeError in motion-detail:
 TypeError: Cannot read property 'open' of undefined

Can you tell me your steps, how I could reproduce this error?

Can you tell me your steps, how I could reproduce this error?

Open the edit view of a motion  -> TypeError.
2nd Test with two admins A and B:

A opens motion 1 and start editing.
B (private tab) opens motion 1 too and click on "edit".
=> no notification dialog that A/B already edit the motion!

Can you tell me your steps, how I could reproduce this error?

Open the edit view of a motion -> TypeError.
2nd Test with two admins A and B:

A opens motion 1 and start editing.
B (private tab) opens motion 1 too and click on "edit".
=> no notification dialog that A/B already edit the motion!

Please test again.
Now this behaviour should be fixed.

Retested your current branch:
There is still a TypeError if I go to edit motion view:
MotionDetailComponent.html:1 ERROR TypeError: Cannot read property 'open' of undefined
    at MotionDetailComponent.push../src/app/site/motions/components/motion-detail/motion-detail.component.ts.MotionDetailComponent.setEditMode (motion-detail.component.ts:963)
...

I get no notification dialog.

@emanuelschuetze THis error happens, if you try to tedit the motion while you have the mobile view. I'll create a fix for that.

cleaned up some code
transfer short names over notify
show the names of currently editing users

@FinnStutzenstein I would advise to create the required service in another PR
please review again

also @emanuelschuetze


Preview: Scene preview looks empty

Describe the bug
When previewing a scene, all scene entities are missing, This seems to happen more often in scene layouts bigger than 6x6 parcels.
Tested on v0.6.0
To Reproduce

Create a new scene
Set the layout size to 8x8 parcels
Add some elements such as floor tiles or asset packs entities
Click "Preview"
Notice that when the explorer finishes loading, you are navigating an empty scene

Expected behavior
All scene entities should be present in the previewed scene.
Screenshots
Actual scene vs. previewed scene

The E@ is not liking big scenes (7x7 or bigger) that have 50 or more entities in their main.crdt file.
I continue debugging.


Update README.md

bors r+

bors r-

bors r+

bors r+

bors r+

bors r+
Dilum Aluthge
Web: https://aluthge.com
Email<EMAIL_ADDRESS>On Apr 10, 2019, 06:23 -0400, bors[bot]<EMAIL_ADDRESS>wrote:

Build failed
• continuous-integration/travis-ci/push
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.


react-native-config:compileReleaseJavaWithJavac Failed

I have followed everything on the instruction but when I tried to run it. It gives me this error
:react-native-config:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
android/src/main/java/com/lugg/ReactNativeConfig/ReactNativeConfigPackage.java:13: error: ReactNativeConfigPackage is not abstract and does not override abstract method createJSModules() in ReactPackage
public class ReactNativeConfigPackage implements ReactPackage {
^
Can anyone please help me how to resolve this? thanks

Guessing this is related to react-native 0.47.0 and their breaking chance w/ createJSModules?

I have the same problem:
here is my package.json fragment:
"dependencies": {
"react-native": "0.44.2",
......
"react-native-config": "^0.6.0"
}

Same problem here.
"react-native": "^0.46.4"
"react-native-config": "^0.6.0"

it's now working for me with:
react-native: 0.45.1,
and "react-native-config": "^0.5.0"
I checkout old version of because 0.6.0 cause problem with react-native: 0.45.1.

I checkout the older version and its working fine. I use the 0.5.0 as what @mamdouh-mowesolutions  stated

This seems to be due to an breaking change in react-native 0.47. This was fixed in #137 for version 0.6.0 of react-native-config.
My understanding is you need to update in lock set react-native 0.47 with 0.6 of this package. This is true for a lot of packages with 0.47 of react.
Basically use:
react-native: "<0.47",
react-native-config: "<0.6.0"

or
react-native: ">=0.47",
react-native-config: ">=0.6.0"


Mention *|latest|newest redirects to latest

Addresses issue #361. I don't know whether in a .hbs file " needs to be escaped ", or * should be encoded %2A.

Great, can you please add same mention to README.md as well?

Closing in favor of https://github.com/rust-lang/docs.rs/pull/578


How to hide notification when download complete

[Question] I make many group download request.. so the notification really disturbing when download complete.. can i hide notification when download complete.. or just show one notification for all group request to show complete message.. and show retry if download  #failed? i have read the sample app but not find this

@arifaizin I am currently working on fixes a few things with the fetch notification manager. Once I complete the updates I will let you know.

@maulik9898  This issue is now fixed in new Fetch version 3.0.10/Androidx 3.1.4. If you need more customization. You can try this code.
    private Fetch fetch;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_download_list);
        setUpViews();
        final FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(this)
                .setDownloadConcurrentLimit(4)
                .setHttpDownloader(new OkHttpDownloader(Downloader.FileDownloaderType.PARALLEL))
                .setNamespace(FETCH_NAMESPACE)
                .setNotificationManager(new DefaultFetchNotificationManager(this) {
                    @NotNull
                    @Override
                    public Fetch getFetchInstanceForNamespace(@NotNull String namespace) {
                        return fetch;
                    }

                    @Override
                    public boolean shouldCancelNotification(@NotNull DownloadNotification downloadNotification) {
                        if (downloadNotification.getStatus() == Status.CANCELLED) {
                            return true;
                        } else {
                            return super.shouldCancelNotification(downloadNotification);
                        }
                    }
                })
                .build();
        fetch = Fetch.Impl.getInstance(fetchConfiguration);
    }

Note the shouldCancelNotification method.

sir when i click on pause in notification click then notification dispear


log4j 2.12.1 in ELK 7.6.1

Hi folks, this project uses ELK 7.6.1 which is vulnerable to the recent "log4shell" exploit by virtue of including log4j < 2.15.0. Elastic have stated that the vulnerability can be mitigated by upgrading to ELK 7.8+ (https://discuss.elastic.co/t/apache-log4j2-remote-code-execution-rce-vulnerability-cve-2021-44228-esa-2021-31/291476). Are there any plans to update the release?

Hi Team,
Actually any plan to upgrade this release for log4j2 vulnerability.
We are having customer waiting for ELK deployment

+1

is the any plans to update ELK stack to 7.16.x ?
@axelaris


pull request for e2e test at 02/03/2017 20:45:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support for @xstate/fsm

Hi,
I'm planning to use @xstate/fsm in my project to get the bundle size down a bit, but I'm not able to use this addon when I replace the imports.
  // import { useMachine } from '@xstate/svelte'; // this works
  // import { createMachine } from 'xstate'; // this works
  import { useMachine } from '@xstate/svelte/lib/fsm'; // this doesn't work
  import { createMachine } from '@xstate/fsm'; // this doesn't work

(I'm using svelte too, but I don't think that makes a difference)
I'm just getting a message in "xState inspector" that says:

Waiting for connection...

Hey, thanks for the report. I didn't test with fsm packages. They must use a different interpreter than the main xstate packages.
Not sure when I can get time to figure that out, if you want to have a go and send an PR the part that "turns on" the inspector is in this file src/preset/withXstateInspector.ts L24 an L38.

Hey,
I tried to google a bit, and it seems that fsm isn't supported by the vizualizer.
But I found a workaround where the config for fsm is passed into normal xstate – created only for the purpose of using it with the vizualizer.


Support any combination of row/column counts for LCD displays

Fixes #85
Instead of copying the single line to a buffer, print directly from the char buffer containing the complete message via ->write().
Tested with a 20x4 LCD, but will work with any combination of columns and rows.

@elral nice fix - we should think of checking whether we have reached the end of the string to not go beyond it if the string was shorter. Just in case. What do you think?

@MobiFlight-Admin yes, good idea. I will change the pull request accordingly.

Does writing single characters slow down the LCD update?
Just asking as a code check.
Thanks for the fix

No, it does not slow down. Print() does the same, writing single characters.
And doing it this way you don't need to copy the memory area.
In the end it is slightly faster.


fix/reset-form-on-passenger-select

Please review before merging.

:tada: This PR is included in version 1.63.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Directions don't list MobileCoreServices.framework as a requirement

I added this project as a submodule and checked out the latest tag (1.7). Then, I added OnePasswordExtension.h, OnePasswordExtension.m and 1Password.xcassets.
When I try to build, I see the following error:
Undefined symbols for architecture x86_64:
  "_kUTTypePropertyList", referenced from:
      -[OnePasswordExtension processExtensionItem:completion:] in OnePasswordExtension.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I worked around this by adding MobileCoreServices.framework to my Link Binary with Libraries build phase. I'm targeting iOS 7.1 and with an iOS 9.2 base SDK.
Please document that MobileCoreServices.framework is a required framework.

Hi @hborders,
Thanks for taking the time to write in and for integrating 1Password into your app.
This is already documented in the "Projects supporting iOS 7.1 and earlier" section of the README.
I am therefore closing this issue as invalid. Please let us know if this helps :wink:
All the Best!

The directions list WebKit.framework as a required framework. I was already including that. I see nothing about MobileCoreServices.framework.

@hborders, I just changed the deployment target to 7.1 for ACME, our sample app, and I got a compile error about the WebKit.framework, but not about MobileCoreServices.framework. Which version of Xcode are you using?

Version 7.2 (7C68)

Thanks for the quick follow up @hborders :+1:
I tested ACME with iOS 7.1 as the Deployment Target and iOS 9.2 (latest) as the Base SDK as seen in this screenshot.

And it all works great! So I submitted PR #296 which should address your documentation issue.
Thanks so much!


Invalid memory access in 3.5.0 development version

In the merge/StatTag branch, I missed a check  in CharacterVector.cs that's causing a crash when you have a coerced/ALTREP object.

Per commit this should be addressed.


Added new profile to index.html

@Eduard0x6F   thnx for contributing , try this year aswell with updated repo and make sure to follow me and star this repo so that you don't miss updates regarding the new changes and issues during Hacktoberfest 2020.


Update the data_schema.sql

💡 Summary
Pull the latest schema and insert into the repo at src/pe_reports/data/data_schema.sql

@aloftus23 ,
Im assuming pull the schema from the staging DB and update staging and create PR to develop branches? We also need to update the db_query.py at src/pe_reports/data/db_query.py?


config.yaml does not work as documented for new installation

Environmental Info:
K3s Version:
k3s version v1.18.9+k3s1 (630bebf9)
Node(s) CPU architecture, OS, and Version:

Cluster Configuration:
Linux v22019048243487761 4.15.0-106-generic 107-Ubuntu SMP Thu Jun 4 11:27:52 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux (master)
Describe the bug:
Installation options provided by config.yaml  are not used for a new installation.
Steps To Reproduce:

Start with k3s not being installed
Create file /etc/rancher/k3s/config.yaml user-readable with the following content:

write-kubeconfig-mode: "0644"
node-name: mymaster

Install k3s by executing $ curl -sfL https://get.k3s.io | sh -

Expected behavior:

The file /etc/rancher/k3s/k3s.yaml is created with mode 0644
The node is named mymaster

Actual behavior:
Neither the custom node name, nor the provided mode to /etc/rancher/k3s/k3s.yaml are set
Additional context / logs:
Documentation:

By default, values present in a YAML file located at /etc/rancher/k3s/config.yaml will be used on install.

@thewilli config.yaml file support was added in k3s v1.19. In k3s v1.18 or before we will have to pass the flags in the command line.

@davidnuzik we should probably update the docs to mention that this is a 1.19 feature.

thanks for clarifying

Closing this issue because the minimum required version was documented.

@catherineluse imho the documentation should as well contain the information how an agent configuration would look like, i.e. especially how the installation script distinguish between server and agent installation if only the config file was present.
As of now, the latest version installs a server even for a config.yaml with only token and server keys present. This might be a bug, missing configuration or of course just a misunderstanding by me :wink:

So we should have an example Rancher agent installation command here as well?

So we should have an example Rancher agent installation command here as well?

@catherineluse yes, either a full example for an agent installation or the installer modified in a way it works as expected (at least I would have expected it), i.e. the installation is of type agent iff the K3S_URL  parameter is provided via environment variable or config.yaml

@thewilli a couple things

The installer does not manage config.yaml. Anything you provide via INSTALL_K3S_EXEC or as args to the script itself will still be set via flags in the systemd unit or openrc init script. This includes determining if k3s should be server or agent.
k3s server or k3s agent are commands, everything after that are flags. The config file only supports setting flags. You cannot set server or agent via config.yaml.
config.yaml is intended to be either an alternative to or alongside setting flags via install.sh. For example, you could pre-populate config.yaml with common options you want set on all your nodes, and then do curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC=server sh - or curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC=agent sh -

@brandond

[..] nor does it inspect its contents to determine if you want a server or agent

Exactly, and I find this some kind of inconsistent. If INSTALL_K3S_EXEC is not set, it determines whether I wanted to install a server or agent by checking if the K3S_URL aka --server flag. But it does only check the environmental way of providing this flag, not the config file one.

For example, you could pre-populate config.yaml with common options you want set on all your nodes

I do like the config file approach for automated deployments. Having a single command for the actual installation alongside a dynamically generated configuration file process makes it less complex and easier to test.

Parsing a YAML file is much more complicated than just checking args or environment variables - at this point I think we'll probably just make sure we document that the install script does not examine files on disk, just arguments and environment variables provided to the script itself.

Hey folks, what about flags without value, like --cluster-init? Would  cluster-init: work as a YAML key? I would assume yes, please correct me if I am wrong.

Those are treated as bools: you should set the value to true or false.

Thank you for the clarification! Please update the docs to make this clearer.


about the latency, seems need 100ms+ on 3090

150ms average, is that normal? I changed everything into GPU.

using r50 version

We spend about 140ms per image on 4 Tesla V100. We find that the inference time using multiple GPUs is relatively stable. Moreover, the depth of transformer has a great influence on inference time.


Clear Filters

Is your feature request related to a problem? Please describe.
A way to clear the filters without exiting and re-entering the view animals --> this allows the user to stay on the same page and refresh any previous filters
Describe the solution you'd like
An addition to the filters tab that simply allows the user to clear all the current filters

Implemented but pushed straight to main as it didn't feel like a bug fix or a new feature


Upgrade dom4j from 1.6.1 to 2.1.1

Do NOT merge, Just for CI result.
https://issues.jboss.org/browse/WFLY-11000

@soul2zimate can you file the appropriate issue for this?

I have created https://issues.jboss.org/browse/WFLY-11000

@soul2zimate Are we going ahead with this? If not, please close. If we are, can you squash the commits and add the Jira id to the message?

Although the CI passed, I believe this needs more discussion. Close for the moment.


Allow VS Code completion directly from the project folder

When working on FlxAnimate, it wasn't possible to do work directly from the project folder due to VS Code not being able to recognize imports or get the Haxe completion server working. This (atleast in my case) requires you to copy the flxanimate folder to a seperate HaxeFlixel project to get proper completion and to be able to make changes to the source code.
This PR makes it possible to do work directly from the project folder by pointing the VS Code Lime extension's project file to use the Project.xml of the sample project.
So now you can simply do haxelib dev flxanimate . (assuming the cwd is the root of the repository) and then do work directly from that folder

Ok this might be actual peak


Move hashmap from os to hashmap

Move the hashmap related files into their own directory

@nashif - moved out of lib/os, as you requested, but only got to this after merge, unfortunately. Can you also ack?


naming and metadata keys in derivatives

cc/ @bids-standard/derivatives
this is an offshoot of #301
at the bids derivatives meeting one thought was the following:
Consider storing all metadata in the json file, bring them to the filename as
needed only for filesystem disambiguation, but not processing. This means
that filename globbing is not a recommended pattern outside of the base
filename. Indexing and reading for processing will require reading the full
metadata dictionary.

so while we may be able to solve the current state with some tweaks of keywords, there is a more fundamental problem of categorization/parameterization.  what if i run a pipeline that compares spm/fsl/afni models like the work from @nicholst? or one that compares os environments? or essentially any parametric/algorithmic/environment mixture.
is there some expected consensus that:

these are out of scope and cannot be stored as bids derivatives?
any parameterization should be stored as separate derivative datasets?

if not, could the above principle work?
The principle could dissociate the creation of keys (knowledge) from the current use of keys as glob patterns and address disambiguation in a systematic manner.

@effigies will this be closed upon merging #265? If yes, could you please update the PR description of #265 to include this as an auto-close syntax?

No, this hasn't been directly addressed in #265. I don't think it was necessary to invoke, and I don't think moving toward it in the future will break compatibility with the principles established in #265.


SendCarCan Task

Implementation of Sending Messages over CAN using proper RTOS synchronization, targeted for the STFM microcontroller board

The good news is that the two tasks and the driver that are associated with this branch are fully validated. The bad news is that I'm going to go through and remove the CarState code from our CAN module (will not break SendCarCAN and ReadCarCAN) but will break the mainline version of UpdateVelocity until it gets its rewrite. Since we are rewriting that thread regardless, I see no issues in doing this. @ClarkPoon feel free to correct me if you feel this is a bad approach.

hotfix_RTOS_SencCarCAN branch may need to be merged into this one for this comment to be fully correct

Need to merge master into this and add OS error assertions everywhere there's an os function call

Things that need to get done to finish this package:

Merge in Hotfix_SendCarCan branch
Merge in master
add OS error assertions everywhere
address clark's comments regarding the fault counter on readCarCAN

Remaining TODO list:

Add OS error assertions into the driver layer
Re-write ReadCarCAN using One-shot timers and handle array precharge and fault correctly (I'm doing this first)
Ensure car state code is fully removed from CAN package (I think this is done, but one more sweep is needed.)


Add Linode to "Other Providers" Column

I noticed Digital Ocean was the only provider listed in this column in a number of rows so I added Linode where they have a comparable product:  Compute | Block Storage | Object Storage

We generally don't accept PRs about other providers from representatives of those providers; down that path lies "this project becoming an advertising hot zone."

I get this. But for the record, I don't work in marketing and no one at the company told me to do this, I found your guide when trying to learn more about how we stacked up against AWS and thought this would help people.


Dark theme breaks

In mobile version of the website while scrolling down the dark theme breaks , and will show the light theme instead.

I cannot reproduce it. Feel free to reopen with some examples


Tensorflow Import Error: DLL load failed....

### Describe the problem
I installed tensorflow 2.3.1 (pip install) and get the following error when I try to import it. I'm using windows 10, 64 bit. Python 3.8.3 (default, Jul  2 2020, 17:30:36) [MSC v.1916 64 bit (AMD64)]

code:
import tensorflow as tf
print(tf.__version__)

###Error  log:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
~\anaconda3-new\lib\site-packages\tensorflow\python\pywrap_tensorflow.py in <module>
     63   try:
---> 64     from tensorflow.python._pywrap_tensorflow_internal import *
     65   # This try catch logic is because there is no bazel equivalent for py_extension.

ImportError: DLL load failed while importing _pywrap_tensorflow_internal: The specified module could not be found.

During handling of the above exception, another exception occurred:

ImportError                               Traceback (most recent call last)
<ipython-input-12-f83c6d50081b> in <module>
----> 1 import tensorflow as tf
      2 print(tf.__version__)

~\anaconda3-new\lib\site-packages\tensorflow\__init__.py in <module>
     39 import sys as _sys
     40
---> 41 from tensorflow.python.tools import module_util as _module_util
     42 from tensorflow.python.util.lazy_loader import LazyLoader as _LazyLoader
     43

~\anaconda3-new\lib\site-packages\tensorflow\python\__init__.py in <module>
     38 # pylint: disable=wildcard-import,g-bad-import-order,g-import-not-at-top
     39
---> 40 from tensorflow.python.eager import context
     41
     42 # pylint: enable=wildcard-import

~\anaconda3-new\lib\site-packages\tensorflow\python\eager\context.py in <module>
     33 from tensorflow.core.protobuf import config_pb2
     34 from tensorflow.core.protobuf import rewriter_config_pb2
---> 35 from tensorflow.python import pywrap_tfe
     36 from tensorflow.python import tf2
     37 from tensorflow.python.client import pywrap_tf_session

~\anaconda3-new\lib\site-packages\tensorflow\python\pywrap_tfe.py in <module>
     26
     27 # pylint: disable=invalid-import-order,g-bad-import-order, wildcard-import, unused-import
---> 28 from tensorflow.python import pywrap_tensorflow
     29 from tensorflow.python._pywrap_tfe import *

~\anaconda3-new\lib\site-packages\tensorflow\python\pywrap_tensorflow.py in <module>
     81 for some common reasons and solutions.  Include the entire stack trace
     82 above this error message when asking for help.""" % traceback.format_exc()
---> 83   raise ImportError(msg)
     84
     85 # pylint: enable=wildcard-import,g-import-not-at-top,unused-import,line-too-long

ImportError: Traceback (most recent call last):
  File "C:\Users\Obichi\anaconda3-new\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 64, in <module>
    from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: The specified module could not be found.

Failed to load the native TensorFlow runtime.

@jackmosh
Could you please refer to the comments in these issues to verify your python/cpu compatibility and system/hardware requirements and let us know: #43479 #43192

If you are using pyinstaller refer to: #43259, #42367

I am running Python 3.8.3 (default, Jul  2 2020, 17:30:36) [MSC v.1916 64 bit (AMD64)] on jupyter notebook - Anaconda 3
NVIDIA CUDA 10.1.222  driver
Please let me know if you need more info. Thanks.

@jackmosh
Could you please refer to the comments in these issues to verify your python/cpu compatibility and system/hardware requirements and let us know: #43479 #43192

If you are using pyinstaller refer to: #43259, #42367

I am running Python 3.8.3 (default, Jul 2 2020, 17:30:36) [MSC v.1916 64 bit (AMD64)] on jupyter notebook - Anaconda 3
NVIDIA CUDA 10.1.222 driver
Please let me know if you need more info. Thanks.

@jackmosh
Please refer to the issues shared to see if there are any compatibility issues due to which you are facing this issue.


PYIC-841: Refactor form to match prototype

Proposed changes
What changed
Where we need to add additional css and labels which are outside the typical form template we cannot rely on the yml template to set the form for us as dynamically
I have moved the text for the form in the defaults.yml as we no longer require the feilds.yml, this will also help with future internationalisation
Why did it change
Before I didnt have a good enough understanding of the hmpo-form-wizard / app / components and did not realise it is flexible. This now looks identical to the prototype and does exactly what it needs to do. We now understand how to work around this dependencies
Issue tracking

[PYIC-841](https://govukverify.atlassian.net/browse/PYIC-841

Checklists
Environment variables or secrets

[x] No environment variables or secrets were added or changed


Filters get set for all annotators. Bug or Feature?

Describe the bug
When setting any kind of filters my co-annotators get set the same filters. Is this indended design that filters are shared between annotators or is this a bug?
To Reproduce
Steps to reproduce the behavior:

Go to Data Manager of the Project and set any filter.
Use a second device and log in with a different account.
In Data Manager and the labeling tool, the filters set in step 1 are also set for the second user.

Expected behavior
I would expect everyone to be able to set their own custom filters.
Environment (please complete the following information):

OS: Linux
Label Studio Version:

label-studio==1.10.1
label-studio-converter==0.0.57
label-studio-tools==0.0.3

Additional context
The annotation works perfectly, and we all get our annotations as expected, so it's not linked to us all using the same account or something like that.
Love the tool otherwise! :)

Data manager tabs are shared by designed. We are thinking about new approaches here when users have their private tabs and they can make them public. So, it's expected behavior.


sign_in process is unclear

Hi,
I'm implementing a token system to allow a user to validate its account. Basically, all it does it send a mail with a link to a welcome page, where my user can set his password.
On form submission,

the new password is set (works fine)
user gets signed in (seems to be working)
he gets redirected to his profile page (doesn't work)

Code is pretty straightforward :
    puts sign_in :user, @user
    redirect_to<EMAIL_ADDRESS>
For some reason, the redirection occurs, but my user gets signed out in the process (instead of getting to the profile page, Pundit raises an error, saying that I have no current_user)
Did I miss something ?

I'm not sure if it is a Devise issue.
Could you please provide more information?
Like for example:

Rails version
Devise version
Steps to reproduce the error

Will be even more helpful if you provide a sample application or a test case that reproduces the error.
Best

I'm closing this issue. Feel free to reopen when you have more information in how to reproduce the problem. You can create Devise test case or provide a sample application that reproduces the error.


Implicit type conversion checking causes unrelated parser errors

Godot version:
Godot 3.1 master
Issue description:
Seems like #26562 has broken my project completely, do I have to do explicit type conversion now? Parser spams errors like this:

But it doesn't even seem like it's related to type conversion, for instance I'm using godot-logger and the above error pops up at these lines which seems to be unrelated:
https://github.com/KOBUGE-Games/godot-logger/blob/856fb070ec08d2c523abba2f05a8f30f1ce8b086/logger.gd#L402-L403
I do have lots of other instances of this in my project, so maybe it's interfering with something else.

I encountered a similiar problem:
self.target_node.global_position.x = 0.0
self.target_node.global_position.y = 0.0

will result in the following error:

Assigned value type (int) does not match variable type (float)

#26572 reported similar issue with range() which is present in logger.gd snippet above but with Vector3.

I guess now we will be needing Vector2 overloads for Vector2(int, int) and range overloads for range(int, int, int).
Just out of curiosity does this work?
Vector2(float(value), float(value))


No longer build on schedule

asdf-vm/actions/plugin-test version 1.1.0
add support for universal arch in MacOS
MacOS build passes and tests pass as well

Thanks @missingcharacter

Love to help 😃


Is this project still active?

Is this project still active? It seems like a good idea but no recent activity.
-Thanks

It is active...;-)


Accessibility: added aria-hidden=true to navigation.

This PR attempts to fix the a11y issue described here: https://github.com/WordPress/gutenberg/issues/15330

(replacement for #1643, unless that one can be reopened)

This change shouldn't need to be made.

@backwardok is it ok to close this PR, then?

I am asking this in context of this comment from @ljharb


Don't working push notification in browser (don't fire "push" event in SW)

Expected Behaviour
Push notification is working, "notification" event is fired
Actual Behaviour
Don't working push notification in browser.
I use Firebase for push notification, server worker load, but push event don't fire when message received.
pushServiceURL is default.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Version 54.0.2840.99 m (64-bit)
Cordova CLI version and cordova platform version
"cordova": "6.4.0",
"browser" : "4.1.0"

Plugin version
"phonegap-plugin-push": "1.8.4"

Sample Code that illustrates the problem
this.push = PushNotification.init({
            android: {
                senderID: "XXXXXXXXXXX"
            },
            ios: {
                alert: "true",
                badge: "true",
                sound: "true"
            },
            browser: {},
            windows: {}
        })

@MrMeison I'll have to take a look at it. The browser code was written to work with our push service for testing not a generic FCM instance. Can you give the instructions at: http://phonegap.com/blog/2016/07/26/phonegap-plugin-push-1-8-0/ a try to see if it works for you?

Hey, I'm having this issue, too. In fact, on the browser the initial registration callback never returns either. Would really love to be able to hook this up to the same Google FCM as my Android app. Any advice?
Thanks!

Generic push to the browser will be a feature of the 3.0.0 release. No timeframe.

@macdonst thanks for your clarification. Can u tell me if in the browser registration_id for this plugin will generate a key that can be used on FCM as well?
I'm kind lost of understanding what is this browser support, because when i try to run on a normal browser i receive tha warnings saying that is not cordova or plugin not installed


AP-4288: Add IRSA service account to deployment

What
Add IRSA service account to deployment
Link to story
Switch to using IRSA policy for s3 bucket access.
Following instructions from cloud-platform to
provide IAM role permissions to web and worker container pods.
Checklist
Before you ask people to review this PR:

Tests and linters should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

I have confirmed this works without the long lived credentials - can upload a file and generate a result file