Use local checkout for pangeo-forge-runner call

In this action, we have an actions/checkout step, so the action is running in a locally-checked-out copy of the feedstock repo. This makes fetching the repo over https redundant (and unnecessarily costly). So instead of:
https://github.com/pangeo-forge/deploy-recipe-action/blob/dd3d04555b0b00eaed4c7fd8c79daba1d0cf6a95/action/deploy_recipe.py#L46-L47
https://github.com/pangeo-forge/deploy-recipe-action/blob/dd3d04555b0b00eaed4c7fd8c79daba1d0cf6a95/action/deploy_recipe.py#L93-L94
I think we can save networking time and just do:
"--repo=."

Yay

Noting this also means we do not need to pass a --ref arg, as AFAICT it is not used for local checkout, xref:

https://github.com/pangeo-forge/pangeo-forge-runner/blob/750f5105fbc2a6e08b53dfeb3ef491e1da605ed6/pangeo_forge_runner/commands/base.py#L64-L65


I did not get the confirm mail

Subject: I did not get the confirm mail
Description:
[redacted] I registered with this mail but no mail so far
Results:
confirmation mail did not come
Backend version: develop-1f3cd769
Frontend version: develop-1f3cd769
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0
Page: https://couchers.org/signup
User:

I emailed this user asking if it's in their spam


⚠ Bofrost.de has degraded performance

In 698d256, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 947 ms

Resolved: Bofrost.de performance has improved in 222de3b.


LuckPerms problem

hello I have a problem with luckperms because my players can't connect to the server if they want to connect I write something like this:
[LuckPerms] Another plugin has cancelled the connection for fa042274-c242-3df8-85f6-9dad62ab7ed1 - szlafroczek690. No permissions data will be loaded.
and on the player's side something like this:
do you believe this is an issue? contact us  with your  analyze ID:ofW8fg

Another plugin has cancelled the connection for fa042274-c242-3df8-85f6-9dad62ab7ed1

It tells you what the issue is.
Another plugin on your server is blocking their connection before LP handles it.

@lucko, can you please add option to turn off this message? We have our custom disconnection logger and this message is useless for us and just fills the server log with unnecessary information every time. Thanks!

@lucko, can you please add option to turn off this message? We have our custom disconnection plugin/logger and this message is useless for us and just fills the server log with unnecessary information every time. I can open a new issue if needed. Thanks!

this should be done! when im getting bot attack, these logs on console are lagging the server. please ..

+1

Please open a new issue with the suggestion of turning the message off instead of bumping a closed issue.


Findbugs failing on Travis (spanning several builds)

Findbugs is failing the build due to a public non-final field in Panels.

Various attempts to ignore it have failed so I've wrapped it in a getter/setter structure to appease it.
Ready for review and close (assuming Travis is OK).

Travis has passed this build.

Checked Travis build is passing. Smoke tested MBHD ok.
Closing


Make own-move box flash for a moment after save

Add 'true' argument to the trigger in MoveFormView.onSubmitSuccess. Cascades down to LunchMoveView where, if present, causes LunchMoveView.recentSaveAlert to occur, which causes the .move box to flash indicating that you had just edited your lunch move.

Ah, ok.

:shipit: :shipit: :shipit:


Build exhaustive list of PPD options from all publicly-available PPDs

In issues #230, #226, and #195 we see problems related to the mismatch between the PPD and CDD style of printer declaration. PPD files directly declare UI elements as opaque choices not meant to be machine readable. CDD is completely machine readable.
For cups-connector, we need a good set of mappings and heuristics to properly infer CDD values from PPD options. There are some already, but this is incomplete.
We should:

Collect an exhaustive set of PPD files. This can come from foomatic and other places. For HPLIP, PPD files are generated on demand, so we'll need to generate them all from the models file. We want the largest possible set of known standard PPD files.
Index all the options in all of the PPD files.
Build a comprehensive mapping from PPD to CDD. This is already partially done in cups/translate-ppd.go but it is not complete.
Keep this mapping in a simple, easily-updated format.

For extra credit, try to boil the ocean and standardize PPD UI options.

In the ideal world PPD developers should have followed Adobe PPD specs, at least for basic stuff like ColorModel and Duplex.
http://partners.adobe.com/public/developer/en/ps/5003.PPD_Spec_v4.3.pdf
http://partners.adobe.com/public/developer/en/ps/5645.PPD_Update.pdf

It looks like CUPS itself has a mapping already, which we do use indirectly through IPP attributes:
https://github.com/apple/cups/blob/master/cups/ppd-cache.c
It might still be a good idea to do this, but may not be as dire as I thought.


Multiple arrays are not handled in dynamic type tests

Here is an example:
const x: mixed = {a: [], b: []} ;
const a = [];
const b = [];

if (x && x.a && Array.isArray(x.a) && x.b && Array.isArray(x.b)) {
    x.a.forEach((ai: mixed) => {});
    x.b.forEach((bi: mixed) => {});
}

In this case, the first array is fine, but the second one is not. If only one array existed, this would not cause an issue.
The error given is property 'b' Property cannot be accessed on mixed
If an extra check is put around the second array, then it will work:
const x: mixed = {a: [], b: []} ;
const a = [];
const b = [];

if (x && x.a && Array.isArray(x.a) && x.b && Array.isArray(x.b)) {
    x.a.forEach((ai: mixed) => {});
    if (x.b && Array.isArray(x.b)) {
       x.b.forEach((bi: mixed) => {});
    }
}

This will be because as far as Flow knows Array.prototype.forEach could have acccess to the object referenced by x and assign something besides an array to x.b, invalidating the check that x.b is an array.
When doing type tests, pull the value you want to test into a local variable and test that. Since the variable is local, Flow knows calling other functions wont change it and the check will stick.

Makes sense - tested it and this does work.
    const x: mixed = {a: [], b: []} ;

    const aa = [];
    const bb = [];

    if (x && x.a && Array.isArray(x.a) && x.b && Array.isArray(x.b)) {
        const a = x.a;
        const b = x.b;
        a.forEach((ai: mixed) => {aa.push(ai)});
        b.forEach((bi: mixed) => {bb.push(bi)});
    }

However, it fails when I try to use object destructuring:
    if (x && x.a && Array.isArray(x.a) && x.b && Array.isArray(x.b)) {
        const {a, b} = x;
        a.forEach((ai: mixed) => {aa.push(ai)});
        b.forEach((bi: mixed) => {bb.push(bi)});
    }

The error given is property 'a' Property cannot be accessed on mixed. Is there a similar reason for this?

Will close this and put the other in a top level issue.


[Suggestion] macOS Installer Support

i don't think has been asked before. have you thought about adding the ability to burn macOS Installers with etcher?

Hey @KevinAT, I'm not sure I understand this correctly; are you referring to the setup image that installs the operating system itself?

@jhermsmeier yes, exactly those - like the windows os installer just the mac one.
under OSX/macOS they are displayed as "Install OS X %cat_or_mountain_name%.app" and treated like normal executables. it's possible to burn them to dvds/usb drives/etc but from what i know in recent versions apple made it more difficult to burn them, as in requiring the app/image to be modified to be bootable. osx tools like Install Disk Creator and DiskMaker X 6 are able to create install mediums from the OSX Installer app files, but i think they modify them a bit in the background, and i'm not sure if those modifications would be easy to port to other OSs like linux. porting it to windows might not work at all, since ntfs doesn't seem to be able to handle the macOS installer files.
though i don't know much about this and am just speculating from what i heard/read. anyways it would be great if i could create bootable macOS installer drives in the future from my linux distro without having to use macOS myself.

Okay – you can already do that, nothing complicated like preprocessing or modification necessary, as Etcher already supports the Apple Disk Image format.
Step 1: Download Mac OS Whatever

Step 2: Navigate into .app's package contents

Step 3: Find the InstallESD.dmg disk image
NOTE: It might be named differently for different Mac OS versions, but whatever has a .dmg extension in there and is ~4-6GB in size is what you're looking for.

Step 4: Flash it with Etcher

Step 5: Done. That's it. That's all. 🎉

porting it to windows might not work at all, since ntfs doesn't seem to be able to handle the macOS installer files.

The host operating system doesn't matter, Mac OS' .apps are just glorified folders, which are treated differently by Mac OS, but you can just copy them to any other file system / storage device – so you should be able to do all this on any OS you like (apart from the downloading Mac OS from the App Store part, obviously).

@KevinAT I'm going to close this for now, but do let us know if everything worked, or if not – what didn't!

@jhermsmeier really it's that simple? thanks a lot! i knew that there was that one big file that holds the osx image, but i didnt think etcher would be able to handle it if i just pulled it out of the app folder.
though i seem to have a few problems:
tried it on Win7-64 with both a sierra and a lion file:
etcher gets till the end of the process but then shows an error popup that always reappears when closed - had to force close the application.

and on macOS-Sierra with a sierra and a lion file:
doesn't even start the burning process and shows this popup straight away.

i could also try it on linux, but only when i get home.
it for sure isn't a problem with the files. i'm at work right now and copied the files from our file server, so they are definitely fine. and btw with the ntfs file issue before i meant that when trying to copy the whole macos installer.app file/folder over to an ntfs (windows) system it complains about the filename of CodeResources and OSInstallerCompatibility being wrong or too long. but since you said you only need the dmg file this shouldn't be a problem anyways.
also if etcher already knows where the ESD file would lie, why not make it possible to just select the "Install macOS xyz.app"-file/folder instead of making the user navigate all the way inside? i'm sure i can't be the only one who thought burning osx images wasn't possible because you couldn't select them with etcher. :)

@KevinAT I believe the DMG support in Etcher was enhanced / fixed after the release of Etcher 1.0.0, so could you try the latest snapshot build?
https://resin-nightly-downloads.s3.amazonaws.com/etcher/2017-07-07/1.0.0%2Bfdceaad/Etcher-1.0.0%2Bfdceaad-darwin-x64.dmg

@lurch tried it with that one - after asking for my user password it gives me an "Unmount failed - Error: Unmount failed"-error and after clicking ok, it gives me an Attention screen with the text "Oops, seems something went wrong." with the option to retry.
btw for the osx lion dmg it shows me something about it not being a bootable image and not having a partition table, is that supposed to be like that? doesn't complain about the sierra dmg not being bootable tho.
i think i'll reinstall my macos sierra system, to make sure the issue isn't on my end for some reason, and then try again.

@jhermsmeier added all the DMG support, so I'll let him answer those questions...

i think i'll reinstall my macos sierra system, to make sure the issue isn't on my end for some reason, and then try again.

No need for such drastic measures – I'm seeing the same errors with our current nightly builds as well, and am currently debugging this. I'll let you know once I figure out what's happening here, and sorry for the mess!

btw for the osx lion dmg it shows me something about it not being a bootable image and not having a partition table, is that supposed to be like that? doesn't complain about the sierra dmg not being bootable tho.

That warning can be safely ignored – Apple disk images sometimes have a padding at the start, and the partition table is further back, or they use an Apple Partition Map, which isn't read by Etcher (yet).

I found the bug that was causing this, fixed it in the udif module, and updated it in https://github.com/resin-io/etcher/issues/1586.
I'm also running into "flash state percentage > 100" errors again with this, working on fixing that as well now.

@jhermsmeier

No need for such drastic measures – I'm seeing the same errors with our current nightly builds as well, and am currently debugging this. I'll let you know once I figure out what's happening here, and sorry for the mess!

it's just a machine for testing stuff and when i occasionally need a mac, so reinstalling it wouldn't be a big issue.
okay thx for your effort!

That warning can be safely ignored – Apple disk images sometimes have a padding at the start, and the partition table is further back, or they use an Apple Partition Map, which isn't read by Etcher (yet).

good to know.


feat(shopify-checkout): support non GIDs for variantIds

WHY are these changes introduced?
Story LS-1478
WHAT is this pull request doing?

Adds a utility method for turning variantIds into valid shopify GIDs. This lets shopify checkout support v2 which currently strips off the gid:// text before the id.
Uses that utility method in cartItemsToCheckoutItems.ts to convert each line item's variant Id to a gid if it wasn't already one.

How to Test

Pull this PR locally
Run npm run test:ci

Note it'd probably be good to test this in an example project too to make sure that it works. Will update with instructions once I've gotten them.

The coverage report shows a slip in coverage, due to packages/shopify-checkout/src/utils/transformVariantIdToGid.ts:

So the issue here is that it's got both node specific & browser specific code, and I'm not sure of a way to test both in this instance. It looks like it's testing the browser code, which is the one we mostly want tested, but I'm not sure how to make it test the node-specific code here.

The coverage report shows a slip in coverage, due to packages/shopify-checkout/src/utils/transformVariantIdToGid.ts:

So the issue here is that it's got both node specific & browser specific code, and I'm not sure of a way to test both in this instance. It looks like it's testing the browser code, which is the one we mostly want tested, but I'm not sure how to make it test the node-specific code here.

@mdarrik I'd recommend checking out packages/shopify-checkout/src/client/client-node.spec.ts for inspiration.

@NWRichmond  I did look there. But I don't see anything there that would really make a difference? Unless test-node is a jest convenience to switch into the node environment, I'm not sure how to have window === undefined in the tests.

@NWRichmond I did look there. But I don't see anything there that would really make a difference? Unless test-node is a jest convenience to switch into the node environment, I'm not sure how to have window === undefined in the tests.

@mdarrik I had to refresh my memory, but the @jest-environment node docblock is the key here.
https://github.com/getnacelle/nacelle-js/blob/c952536750bd302247ce7c5f41984c7fceb17f9a/packages/shopify-checkout/src/client/client-node.spec.ts#L1-L3

Ah cool. That should be easy enough.

@NWRichmond added separate browser/node tests. Ended up with 100% coverage for the new file now.


Fix Cannot get rid of error message when X button is pressed

Details

Fixed Issues

$https://github.com/Expensify/App/issues/11454
Tests

Login to NewDot.
Go to any conversation.
Try to send unsupported attachment (For E.g: .heic , .tiff)
Notice Upload Attachment error
Try to dismiss error by press X icon
Ensure it works.

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/26106822/193630519-506c9c0e-8713-478e-bb07-3844f1f850d9.mp4
Mobile Web - Chrome

https://user-images.githubusercontent.com/26106822/193630477-b3b85de9-e094-4e14-b1d3-d6ff19e8987f.mp4
Mobile Web - Safari

https://user-images.githubusercontent.com/26106822/193630450-d80e6f19-4281-4788-94dc-0a061d085c20.mp4
Desktop

https://user-images.githubusercontent.com/26106822/193630295-2a5886f4-4d32-4b31-bd09-a2165712ed10.mp4
iOS

You couldn't select files in iOS 16 simulators. I think it's a known bug which is report here.
https://user-images.githubusercontent.com/26106822/193630357-677aea9b-ead4-4426-80d1-d0f44493e588.mp4
Android

https://user-images.githubusercontent.com/26106822/193630413-20ae688e-7d70-44a1-ba44-0a4ca22f9b79.mp4

@Justicea83 .tiff file supports for me 🤣

And for .heic it gives an error beforehand.

Share a screenshot of your upload of a .tiff file 😂

If you look at the screenshot I have shared in the second comment it does list .tiff as valid type. Also, I think the error that we see is not just related to file type being wrong but could also be if someting goes bad in the backend, no?

This PR is supposed to fix the close button not working, so I'll share a file you can test with on slack since it won't be uploaded here.

Ok cool, I can see it now. Thanks

Tests were passing, not emergency merge.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@techievivek not really:

Error: PR Reviewer Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Oops, my bad, @flodnv. I forgot I was the sole reviewer of the PR. I have updated the checklist. But I have only tested on macOS Chrome.

🚀 Deployed to staging by @techievivek in version: 1.2.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.2.12-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


methods to clear cached classes after reload! is called

This appears to correct the root cause of #717 and possibly https://github.com/neo4jrb/devise-neo4j/issues/16. It uses the before_remove_const method fired by ActiveSupport's reload! to wipe cached references to classes. It's possible others are still lurking but this will be a start.

Any news on when this PR might get released on Rubygems?  Right now, using reload! in the console isn't working with the current version (5.0.14) and it looks like it's due to this not yet being released.

We definitely want to release a 5.1 soon.  I've been producing some screencasts for the gems and the latest screencasts require some features in master, so those will need to be made publicly accessible.

To give a clearer answer: I expect we'll at least do an RC that'll be in the next week or two, one way or another.

Ah, gotcha, so this is going out as a point release and not a patch.  Thank you for the work, I'll watch for the RC!

Ah, right.  I'm not sure if @subvertallchris planned to do a patch (I know he's been busy with work lately), but obviously it will go out with a point release ;)  Thanks for the patience

I think a patch release would be a good idea. A few people are locked to master because they need what it provides, I think it would help them out. I'll take care of it when I have a few minutes today and will post here when it's done.

:+1: Thank you!

Just released 5.0.15 with this. Let us know if you have any trouble.

@subvertallchris: CHANGELOG? ;)

It works great - thanks!  :tada:


MLHR-1685: Update cached query result for processed queries after new data is added/modified.

can be done efficiently, closing this pull request will open again.


Tree: Huffman Decoding | C++ #713

Pull Request Template
What have you Changed(must)
Added a new code for Tree: Huffman Decoding | C++ #713
Issue no.(must) - #713
Pr will be closed and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will marked as spam.
[x] My file is in proper folder.
[x] I am following clean code and Documentation.
[x] I have added title and what program will do first in the file.

README - How to Contribute

@div-bargali Can you please assign "hacktoberfest-accepted" label to this. Thanks!


make requirement installation better

dont know if this was worth a pr but yeah, this allows you to expand on the requirements easily

why? i don't think it's worth ig just unneccesary

why? i don't think it's worth ig just unneccesary
also do for builder pls if we do

i don't think it's needed

i will do the class stuff with files for vmdetect today ok?

makes adding and removing requirements a lot easier

nah i don't think so adding requirements with the old technique was just adding && python -m pip install [new requirement]

but nvm if you want to merge i will

why do you hate automation lmao and what about removing requirements you'll have to find it in a string of like 200 characters once we scale up and add more reqs

tbh its a really good idea thanks suvan


HIVE-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

What changes were proposed in this pull request?
Use alter_partition, alter_partitions when EnvironmentContext is null.
Why are the changes needed?
HIVE-12730 uses alter_partition_with_environment_context and alter_partitions_with_environment_context instead of alter_partition and alter_partitions when the EnvironmentContext is null.
This causes the client version to be greater than 2.1 to connect to server<2.1, and this error will occur.
Caused by: org.apache.thrift.TApplicationException: Invalid method name: 'alter_partitions_with_environment_context'
	at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
	at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
	at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
	at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)

Does this PR introduce any user-facing change?
No.
How was this patch tested?
exist UT

@sunchao  Help review when you have time. Thanks.

Thanks @cxzl25 ! this is a good catch and it LGTM. Could you open another one for branch-3.1 as well? Ideally we should also fix this in master but seems the code path has changed a lot there.

Submitted a PR (https://github.com/apache/hive/pull/2623) on branch3.1 .
master branch: HIVE-19820 uses alter_partitions_req instead of alter_partitions .

Merged to branch-2.3 Thanks @cxzl25 !


Support Swift enum type

I changed enum type declaration code for use in Swift.

Pushed to CocoaPods as 2.2.10


conf: update copyright

Signed-off-by: Matthew Croughan<EMAIL_ADDRESS>

Docs for f786b3c3f7dcf22e5cfb292c55942260f9a0ce8d are browesable at: https://ci.foundries.io/projects/fio-docs/builds/796/docs/artifacts/html/index.html


pruning remote repositories

This is probably a long shot, at least in my understanding it does not fit to current model, but might be interesting and helpful for some.
In my environment, multiple clients upload their backups to two sftp storages, but they do not prune, check or copy anything. There is one "control" machine which prunes, checks and copies everything to another cloud storage. This control machine have only one repository, but manages about 20 (some with different retention policies) on the storages.
Right now duplicacy-util requires a local config file in order to do manipulations on a given repository. What would help me is to have a local config file with refers to a repository existing at a given machine but contains pruning instructions for repositories on a remote storage, something like
repository: /local/one

storage:
    1:
        name: b2

prune:
    1:
        storage: b2
        remote_repo_1: "0:365 30:180 7:30 1:7"
        remote_repo_2: "0:180 7:30 1:7"
        remote_repo_3: "0:1440 30:30 1:7"
...

I don't fully understand your use case. Duplicacy only has the concept of backing up a single repository at a time (the one that you have issued cd to, although it could be a repository with many links to other repositories). But ultimately, it doesn't much matter: In the end, duplicacy sees it as one repository with many files.
In your example above, how are you driving duplicacy itself? How is it that you are pruning a single storage, against a single repository, with multiple sets of rules? If I understood the set of commands that you were running duplicacy with, I might better understand your use case.
Please clarify, thanks.

I have several machines, and every machine usually has several backups (repositories), sometimes with different retention policies. All the machines and repositories use the same storage (a remote sftp server). On this storage there are 60 repositories with a total of 1200+ snapshots right now. I have found that pruning operation takes a lot of time (because for pruning duplicacy must get information about every snapshot from every repository on the storage). On an unstable connection (e.g., working on a laptop from a train) the backup still works fine, as it usually takes less than a minute, while pruning will never succeed because of connetion outage. So I configured all my machines to only do backups. I have one machine in the same local network as the sftp server I use, and I delegated all the pruning and checking work to this machine.
Here is the example. On this “control” machine I have, let say, repository A configured to use storage sftp_storage. On the same storage, there are repositories B, C and D from my other machines
For a pruning routine I run duplicacy from the control machine:
duplicacy -prune -storage sftp_storage -id A -keep 1:7
duplicacy -prune -storage sftp_storage -id B -keep 0:30
duplicacy -prune -storage sftp_storage -id C -keep 1:30
etc

I’d like to use your nice utility to get notifications about this pruning (and also checking) jobs, but as it is now, your tool needs a presence of a local repository. My request was to add an option to pass additional pruning parameters (repository names) in order to manage them all while still having only one local repo on the control machine. And I think it could be in principle realized with -quote as you proposed for #21
And I just understood that the solution to my problem would be to create empty repositories B, C and D on my control machine and use them for pruning. For 60 repos that is not a very elegant way, but it will work.

If I understand your request properly, then -quote would work perfectly. You wouldn't need to create any empty repositories that don't already exist, you'd just need to modify your control file to pass appropriate -id parameters (since this is what you're doing now).
Note that duplicacy-util doesn't actually need a real repository to be set up. It needs a location to cd to (at the top of the file), and this can literally be any existing directory. After that, it just reads the control file and generates duplicacy commands (and keeps logs and sends email, etc, but that's not relevant here).
How would -quote not be perfect for this? Or more specifically, why is it not an elegant solution for sixty repositories?
I'd still like to fully understand your use case. If it turns out that -quote will solve it, that's great, and gives me something to go on for priority of that. But if -quote is "not a very elegant solution", I'd like to understand why. Thanks.

Sorry for being not very clear, -quote is indeed a much more elegant solution than 60 repos. I have closed the issue because I realized that my "wish" is in principle feasible with the current version of duplicacy-util (although feasible through creating 60 configs to read out, which is not elegant).
In general I think -quote might be handy in many cases for ones who run duplicacy with some unusual parameters and I can only welcome your decision to give it more priority.

Got it, thanks for the clarification. I'll see about getting to -quote sooner rather than later.

Dear @jeffaco, thanks for the very fast implementation of the -quote feature. It works like charm for checking (#21)! For pruning, there is still an issue: duplicacy-util runs prune with -all key.
Here is an example: I have repository A with a normal retention policy(0:365 30:180 7:30 1:7) and repository B which I want to prune with a special, short retention policy. My config to run duplicacy-util now is
...
prune:
    1:
        storage: sftp_storage
        keep: "0:7"
        all: false
        quote: "-id B"

When duplicacy-util executes duplicacy, it run is as duplicacy prune -all -storage sftp_storage -keep 0:7 -id B and this prunes all repositories on storage with 0:7 policy! This can be easily fixed by #24.


Cant create default archetype

When doing the tutorial for setup with maven, it seems that its using snapshot version that no longer exists under the repo and this causes the step to fail:
http://www.citrusframework.org/reference/html/index.html#setup-using-maven
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:29.502s
[INFO] Finished at: Tue Feb 16 13:05:01 CET 2016
[INFO] Final Memory: 13M/193M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:2.4:generate (default-cli) on project standalone-pom: The desired archetype does not exist (com.consol.citrus.mvn:citrus-quickstart-soap:2.5-SNAPSHOT) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Fixed archetype-catalog on http://citrusframework.org/archetype-catalog.xml to use 2.5 final version. Thank you very much for pointing to this issue

yw mate :)


Create an example that uses wait()

I had to read the source to figure out how to make my calls synchronous. Would be nice to have a good example that gets this use pattern down.
(Also: why isn't there a version of map that is completely synchronous?)

https://github.com/pywren/examples/blob/master/hello_world/hello_world.ipynb @Vaishaal does this  look like what you were thinking?

@ericmjonas i'm worried that is too complex - one round of future waits + one round of future.result. Given we'd like non-CS users, would it make sense to have map_sync() that does this internally ? Or will that give up something basic ?
P.S: If we go down this route, I'd also consider changing map to be synchronous and map_async to return futures

@shivaram I'm ok with this complexity, the interface I'm trying to roughly approximate is https://docs.python.org/3/library/concurrent.futures.html. I'd much rather have a get_all_results which calls the blocking wait and gets the results.

Ah I see - got it. So the wait is supposed to be similar to the Python's wait ?
@Vaishaal what are your thoughts about get_all_results

That's the hope. I mean, I know we can't perfectly reproduce that interface -- for example, at the moment we can't cancel jobs, and in general I think it's a bit dangerous to try and duplicated shared-memory-concurrency APIs for distributed systems (the failure probabilities are radically different) but -- it's also a pretty stable interface and one that's known by a lot of people. Plus it feels "pythonic".

I also thought making map() synchronous and another map_async is more natural. Of course, this is probably because I'm much more familiar with the typical threadpool interface than concurrent.futures.

One major edge of concurrent.futures seems to be fine-grained access over each call. You can check their status, blocking to return result, cancel them individually, etc. The question seems: 1) if they are useful; 2) if we can support them in a meaningful way, e.g., can we cancel invocations?

I think its good to have the option to do things like that in the future. Also the async feature can let us compose or do lazy execution etc. So I think building on top of futures API is useful but at the same time having a sync API that works out of the box for users has its own attraction
BTW @ericmjonas one thing is we could make it look like a one-liner in our examples, README etc.
results = get_all_results(map(...)) ?

We could make it look like a one-liner, but I think that's hiding some real underlying complexity. I think target users are familiar with job invocation systems like PBS or condor so the idea of job handles that you wait on isn't all that foreign.
I'd much rather add simplemap in the future and leave things the way they are right now -- we have a lot of code written, I've not heard that this is a point of pain from users yet,  and we're trying to get a release out the door.


Enable game button not working

Hi. I've just got the billiards table in my world. But when I go into the world it doesn't let me press the enable game button at all.
Not sure what I've done wrong!
Any help is appreciated.
Thanks

@rozm1993 how did you fix this?  Running into the same issue


Implement Shamir's Secret Sharing

You could also look at implementing Shamir's so that you can create more parts but don't need all of them. Might be a fun project.
Could probably just import this library and use the split method if you want to be lazy about it :P
https://github.com/hashicorp/vault/blob/master/shamir/shamir.go

Adding to @kiwivogel and repeating my comment from HN here:
This tool is pretty unsafe and should not be used.
It is simply splitting the key in multiple pieces, thus for every piece you have, you gain additional information about the key, allowing for exponentially easier brute-forcing of the remaining key.
Example: Assume someone creates 3 horcruxes and you can get your hands on 2 of them. This gives you 85 bits of the full 128 bit key, thus you only need to brute force 43 bits for the rest. Of course you don't have the full data anyways, but you still learn about 2/3 of it.
An additional already existing tool is ssss which uses Shamir's Secret Sharing. http://point-at-infinity.org/ssss/ - or you use what's implemented by hashicorp.

@simonerni what are your thoughts on having n separate keys when creating n horcruxes?

@simonerni I've switched to using n full keys and it didn't have much of a performance cost for large files so I'm happy with that solution. As for Samir's secret sharing, I'll give that a look

I've just downloaded ssss and given it a try. It only works for max 128 character secrets (unless I'm mistaken), whereas the purpose of my program is to encrypt whole files of arbitrary size. You could do a two-step where you use ssss to obtain the secret then another program to encrypt the original file but my plan was to make the program super easy to use for myself in 20 years time (which also means no dependencies, but ssss uses GnuPG)
I like the look of Hashicorp's approach, but the interface for those functions requires you have all the bytes you need in memory, which will cause issues for large files. Having said that, I could just change my approach to only do horcrux-y stuff regarding the key, and then use the key to encrypt the same file n times. Issue there being that each of the horcruxes will roughly be the same size as the original file, but I can't think of any way around that if I want to allow for horcrux thresholds (i.e. only requiring 3 out of 5 horcruxes).
I'll see what I can do

@kiwivogel I've adapted the code (i.e. copied) from where you linked, and it works like a charm :) I believe I've done my due diligence by the mozilla MPL license (i.e. linking to the original code). Let me know if there's anything here I haven't addressed :)

@simonerni what are your thoughts on having n separate keys when creating n horcruxes?

I assume in this scheme, each shard i is encrypted with it's key k_i. If you then store the encrypted shard e_i and k_i together, the original shard i is trivially recovered by simply decrypting e_i with k_i again, so you could argue that in this scheme, no encryption is applied at all and the data has only been encoded in a convoluted way.

but I can't think of any way around that if I want to allow for horcrux thresholds (i.e. only requiring 3 out of 5 horcruxes).

There are erasure codes which allow you to do exactly this. Popular example are the reed solomon codes, with lots of implementations and even hardware acceleration in certain Intel processors.

Proper way to do this is create a master key and then split/distribute that using shamir's I guess.


Changed the directory structure.

Moved managed_vms -> appengine/flexible and app_engine to appengine/standard

Now we're using appengine

Thank you :) LGTM!  Please do a search in the docs in google3/googledata/devsite/site-cloud to make sure we're not referencing specific github paths here?  Guessing @bshaffer would know what specifically to look for.

Yeah I'll take care of it

We will need to update our jenkins config as well

already done :)


VSCode powershell plugin fails to return to proper indent

Steps to reproduce

Set VSCode to use the powershell Pipeline indent setting to 'After Each pipeline' (The default is "None")
Use multiple pipeline commands on a single line.
Format Document

Expected behavior
function foo {
    $a = $b |
        Select-Object a | Select-Object a
    $a
}

Actual behavior
function foo {
    $a = $b |
        Select-Object a | Select-Object a
$a
}

Environment data
Latest VSCode, using Powershell-Preview extension

Are you using "editor.autoIndent": "full" ? Maybe it's a related bug.
If you use alt+up/down it breaks indentation when that is set. I had to switch to advanced to fix that
"[powershell]": {
    "editor.autoIndent": "advanced"
}

I cannot reproduce this with the latest available version but I am aware that something like this was fixed in one of the recent versions. Can you please clarify the version of the extension specifically and report what the output of (Get-Command Invoke-ScriptAnalyzer).Module.Version in the integrated PowerShell terminal is please?


Allow specifying the target to run the test with

Some context first: we are building a blockchain on substrate, and have a monorepo with a bunch of crates. Some crates are intended to be built in both std and no_std modes, but the issue is that when building in no_std mode, wasm target is assumed. Crates have an std flag, which enables std mode in dependencies, and when it's absent - the dependent crates also disable std mode (and switch to assuming wasm).
The problem is we can't test no_std mode with cargo hack.
It would be great if we could use a presence of a certain feature in the features set under test to use a different compile target (in our case - wasm32-unknown-unknown).
An example.
Let us have a crate with features std = ["dep1/std", "dep2/std"], feat1 = ["std", "codec"], feat2 = ["some-non-std-feature"].
We'd like to test in the following way:

default-features = false
features: [std]
target: native (since std is explicitly enabled)
default-features = false
features: [feat1]
target: native (since std is implicitly enabled via feat1)
default-features = false
features: [feat2]
target: WASM (since std is effectively not enabled)
default-features = false
features: []
target: WASM (since std is effectively not enabled)

We could specify all this manually somehow if we had just one or two crates, but we have way too much of them, and the logic to determine the target is so simple, yet tricky, so I thought it would be a good fit for cargo-hack.
I'm sure if cargo-hack offers this functionality other projects will pick it up as well.

Do you mean you need an option to process the following two lines in one line?
cargo hack check --each-feature
cargo hack check --each-feature --skip std --target wasm32-unknown-unknown

Those two lines are not going to cut it. What they don't handle is:

We don't need all crates to be tested under wasm32-unknown-unknown - some of them simply don't support no_std. yet, some of them work in both std and no_std mode. When we work at no_std mode, we always work in wasm.
When we test in the std mode, the tests still choose feat2, which is only supposed to work in no_std mode; we have to list all such features in the command, which works but is messy and hard to maintain: cargo hack check --feature-powerset --no-dev-deps --exclude-no-default-features --skip runtime-benchmarks --skip try-runtime ....

Overall, I think baking in the logic to derive target from a feature is kind of overly specific, but I've figured that each crate can have some instructions on how it should be tested by cargo-hack in it's Cargo.toml metadata.
What if we add some extra information there?

Thanks for the explanation. If I understand correctly, what this feature request is asking for is something like:

A way to specify options such as --exclude and --skip per-crate (optionally per-target).
The package.metadata in Cargo.toml seems to be a reasonable choice, since it can get as json via cargo-metadata.
Something like the following:
# Default options if no per-target option is specified.
[package.metadata.cargo-hack]
skip = ["feat1"]
exclude = false # If true, same as `--exclude crate_name`

# Options when built for specific target (wasm32-unknown-unknown, in this case)
[package.metadata.cargo-hack.target.wasm32-unknown-unknown]
skip = ["std"]

And the following is the feature that I initially thought this feature request to be asking for.

A way to handle multiple targets in one command.
For this, cargo already has two unsettling features.

multitarget
per-package-target

Implementing an ability that emulates multitarget is okay, but this ability does not seem to be a blocker to meet this feature request.

Thanks for the explanation. If I understand correctly, what this feature request is asking for is something like:

Yep. something like this.
I tried to implement it manually with some scripting, but it ended up non-trivial with bash and cargo metadata.
One thing to note is a difficulty with how substrate projects manage std/no_std switching. We only have a flag for std, which is also the default, but can be turned off with --no-default-features; one problem I encountered was that no_std environment only works in wasm target - i.e. there are some compile-time assertions on pointer sizes etc, so it's not possible to test/check no_std with native target.
This means we need to check some featured only with wasm target, some only with non-wasm; and some with both. The presence of the std feature in the selected features is a solid indicator of whether wasm or non-wasm target should be used.
Can we actually detect whether the std feature is active with a particular feature set to pick the target? This will greatly reduce the amount of manually entered info that we'd have to keep in the Cargo.toml metadata.

Some extra context of our case
We have, by in large, three kinds of crates:

builds with std and some non-wasm target (the usual rust);
builds both without std for wasm target, and with std for non-wasm target (usually, the non-wasm variant builds second, and embeds the wasm variant, wrapping it with the host/wasm glue code); these typically can also run tests in std mode.

What would be nice is to run the checks on the individual crates in the no_std mode, as we've been hit by a lack of said tests a couple of time already.


only half appears

when it falls down, only half of it comes and wont let me connect

me too!!

Same here. The bot is not loading or something is wrong. Tested on Chrome and Opera.
Screenshot: http://prntscr.com/e1gife

Refer to README

GOSH SAME

Bot has been discontinued. Please read readme.
On Sat, Mar 25, 2017 at 5:52 AM, capeboi<EMAIL_ADDRESS>wrote:

GOSH SAME
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Apostolique/Agar.io-bot/issues/638#issuecomment-289191221,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARhKUEpkviVuGpA8vxe8nb45pIiagk1kks5rpKulgaJpZM4LSW81
.

Or, refer to issue #616 for why this bot is no longer getting updated.
Closing issue.


RBAC only looks at extensions/ingresses

This version of the traefik chart is not compatible with the latest definition of the Ingress resource.
Right now, permissions are only granted on extensions/ingress. For this to work with newer ingress definitions, we  need to update the the ingress operations in RBAC to support networking.k8s.io/ingresses.

There's probably a code-change associated with this too. Possibly a client version upgrade.

Hello @mjpitz,
thanks a lot for your interest.
I tried to reproduce your request, but I sadly can't.
I tested with the helm chart and the following definitions
apiVersion: apps/v1
kind: Deployment
metadata:
  name: whoami-http
  labels:
    app: whoami-http
spec:
  replicas: 2
  selector:
    matchLabels:
      app: whoami-http
  template:
    metadata:
      labels:
        app: whoami-http
    spec:
      containers:
      - name: whoami
        image: containous/whoami
        ports:
        - containerPort: 80
---
apiVersion: v1
kind: Service
metadata:
  name: whoami-http
spec:
  selector:
    app: whoami-http
  ports:
    - protocol: TCP
      port: 80
      targetPort: 80
---
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: whoami-http
spec:
  rules:
  - host: webapp.docker.localhost
    http:
      paths:
      - path:
        backend:
          serviceName: whoami-http
          servicePort: 80

and Traefik is perfectly fine with the Ingress through the networking API Group. Maybe there's some mapping inside k8s for that?
Please let me know if you have a configuration which errors out :-)

This was resolved with 9.3.0 :) @SantoDE  @mjpitz


Multipart file uploads can not be completed

Hello, this implementation works for the uploads < 5MB very well. However, if I try to upload a file > 5MB, it can't complete the upload procedure.

I meant 5MB, maybe it depends on my browser or the permissions on my S3 Bucket. I tested with Google Chrome on Ubuntu.

Hey @bilgincan, I've run a test again in my Google Chrome on OSX with a 10GB file and it uploaded correctly.
Can you test again and this time, open the Google Chrome Developer tools and look into the messages that show in the console. Check if you see any error messages there when you upload. It seems to be a browser problem.

Hi @koiker, I get this error when I try to upload larger files (meaning > 5MB) "SuchUpload: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed."
In the development tool I see that, the data is being uploaded in multiparts with PUT request. However at the end, there is POST request to complete the upload. As a result of this POST request, I get the following message with the code 400:
MalformedXMLThe XML you provided was not well-formed or did not validate against our published schemaYJ3X48K026B2NSETYTsbG5rP41jd8z8AMDFlP4FPuI7sTbnEs2w6eeOUz3X/5W1PRh4A43Vt60bgZDdTRV+O5sCp8Sc=
Then after that, DELETE request "AbortMultipartUploaded" is sent. And finally, the GET request "ListParts" is made and as a result it returns 404 not found, so the multipart upload cant be completed. This time I hosted app on Mac with M1 and I used the Google Chrome browser.
Furthermore, I have to say, I didnt create a new Amplify project for this code. I'm using an existing Amplify configuration, with the following code:
Amplify.configure({
Auth: {
identityPoolId: identityPoolId, //REQUIRED - Amazon Cognito Identity Pool ID
region: region, // REQUIRED - Amazon Cognito Region
userPoolId: userPoolId, //OPTIONAL - Amazon Cognito User Pool ID
userPoolWebClientId: userPoolWebClientId, //OPTIONAL - Amazon Cognito Web Client ID
},
Storage: {
AWSS3: {
bucket: bucketName, //REQUIRED -  Amazon S3 bucket
region: region, //OPTIONAL -  Amazon service region
},
},
});

Thanks for the information @bilgincan , it looks like a problem with Amplify or SDK. Searching I found some other users having similar issues as yours. It's seems to be a CORS issue. Some users solved that adding an Etag configuration seems to fix the issue.
Would you mind test this fix in your solution?
https://github.com/aws-amplify/amplify-js/issues/61#issuecomment-445436658


How to re-program RN2483 with your board layout?

Hi kiu,
Thanks for sharing this project.
I have gotten your PCB design fabricated, then I soldered on the components you listed in your BoM and loaded the firmware you provided onto the MCU... And it works great.
[Note: I actually have the RN2903 instead of the RN2483 - but they both work and are programmed very similarly].
I am currently trying to re-program the RN2903 soldered onto my PCB using the LoRaDevUtility (Microchip documentation) and the RN UART pins you have provided.
However, I believe that due to the way you have set out your board, it is very difficult to do this. I could initially see the RN2903 in the LoRaDevUtility (see screenshot #1), but had to continuously hold down SW1 to keep the UART connection "alive".
I then tried to update the firmware on the RN2903 but I accidentaly "bricked" the chip currently on my board because the UART connection disconnected while the firmware was updating. Now whenever I try to upload firmware onto the RN2903 now, it keeps disconnecting and does not allow me to upload any firmware (see screenshot #2).
I am more than happy to grab another RN2903 and try again, but I'm hoping that you could provide some advice before I continue.
Do you have any recommendations about how I can re-program the RN2903/RN2483 using your board layout? Have you tried uploading different firmware onto the RN2483 yourself?
Since you manufactured so many boards, I am curious whether if you've thought about how you would update the firmware on the RN2483 on these boards (without taking it off?).
Thanks,
Kevin
Screenshot #1 - initially, can see RN2903 in LoRaDevUtility:

Screenshot #2 - cannot stay connected to RN2903 and upload firmware. Continuously disconnecting like below (I am using COM4 as my UART serial port):

Hi Kevin,
I have to admit, I didn't think much about how to upgrade the firmware of the RN module. Or at least not in an user friendly way.
I would probably flash the AVR with a new config disabling the RX/TX pins, so they won't interfere with the RN module. Then upload the the RN firmware as you did.
If the RN module leaves bootloader mode, you could try to send the "eraseFW" command.
Hit me up on https://www.thethingsnetwork.org/community/toowoomba/post/join-us-on-slack (user: kiu).

For the record.
Flashing a NOP version of lofence with RX/TX pins disabled (Atmel Start Config) and issuing a single RESET does the trick.
int main(void) { 	atmel_start_init(); 	_delay_ms(100); 	RN_RESET_set_level(false); 	_delay_ms(100); 	RN_RESET_set_level(true); 	_delay_ms(100); 	while (1) { 	} }

I was struggling a little to do the firmware upgrade. Mostly because I am not familiar with Atmel Start. So let me document what I did in case someone else stumbles upon this thread.

Comment out the content of the int main(void) function and replace it with the contents of the main function as posted above.
Open src/driver_init.c and comment out the lines USART_0_initialization(); and USART_1_initialization();.
Upload to LoFence board.

Because I could not find the Microchip firmware upgrade tool from an official source, and the one I did find didn't want to work, I looked for a different way to flash the firmware. I ended up using https://github.com/SodaqMoja/RN2483FirmwareUpdater
Luckily I had a Sodaq Explorer at hand to do the update, but I had to change the firmware to program the external RN2483 and not the onboard one on the Explorer. In RN2483FirmwareUpdater.ino on line 17 I replaced Serial2 with Serial. Serial is the UART on pin 0 and pin 1.
Connection between the Explorer and LoFence is as follows:

Explorer
LoFence J4

3.3V
pin 1 (3.3v)

D1 (TX)
pin 2 (RX)

D0 (RX)
pin 3 (TX)

GND
pin 4 (GND)


Reawesome: Added full test coverage and slight functionality updates to readTimeSeries and readEstimatedTimeSeries.

Coverage increased (+0.7%) to 92.713% when pulling 76e833d65d61004b2bf6bb5eabb79873e9dc26f8 on zmoore-usgs:reawesome/utils-fetch into 3e3e424188f0c0fb388c70a3363ed1732329858f on USGS-R:master.

Coverage increased (+0.7%) to 92.713% when pulling 76e833d65d61004b2bf6bb5eabb79873e9dc26f8 on zmoore-usgs:reawesome/utils-fetch into 3e3e424188f0c0fb388c70a3363ed1732329858f on USGS-R:master.


[Feature](inverted index) add parser_mode properties for inverted index parser

Proposed changes
We add parser mode for inverted index, usage like this:
CREATE TABLE `inverted` (
  `FIELD0` text NULL,
  `FIELD1` text NULL,
  `FIELD2` text NULL,
  `FIELD3` text NULL,
  INDEX idx_name1 (`FIELD0`) USING INVERTED PROPERTIES("parser" = "chinese", "parser_mode" = "fine_grained") COMMENT '',
  INDEX idx_name2 (`FIELD1`) USING INVERTED PROPERTIES("parser" = "chinese", "parser_mode" = "coarse_grained") COMMENT ''
) ENGINE=OLAP
);

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


add close button to error dialog.

We've got the X and you can use escape to close the window...no real need to lose the vertical space..


Factory not crafting chips

When I try to craft a machine, sometimes it will not try to craft the chips required.
For example, crafting T4 mixer:

Then I tried crafting the chips, and it didn't have the materials to.

You only have 1T2/T3/T4 dust, and 483 T1 dust. I would expect it to tell you that you lack dust if you try to craft a T4 mixer.

This was after I tried to craft. All the components are crafted except the advanced chips. The script worked fine until it reached the chips, it seems to not even factor them into the cost of the machine. When I tried to craft the chips, it said there were not enough materials for them. I have no idea why it didn't tell me beforehand.

Do you have the Chemical Lumps exotic skill? The script assumes you do, if you don't then uptiering will be much more expensive than it expects, so what it thinks is enough resources won't be.

I'm going to assume that was it.


New org: billing sharing from external org now requires addition of directory id - as GCP default organization policy - domain restricted sharing

Issue: adding billing account administrator outside the domain now fails on the new auto-applied org policies

see Domain Restricted Sharing - List element

https://console.cloud.google.com/iam-admin/orgpolicies/iam-allowedPolicyMemberDomains

fix:
see
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/gh766-script/solutions/setup.sh#L229
DIRECTORY_CUSTOMER_ID=$(gcloud organizations list --filter="${DIRECTORY_CUSTOMER_ID}" '--format=value(DIRECTORY_CUSTOMER_ID)')

michael@cloudshell:~ (clouddeploy-ol)$ echo $DIRECTORY_CUSTOMER_ID
C,,,,,x

see

or all


Cleaner Code/Improvments to best pratice

Changes to code

Removed Schema File Not Needed
Added Base.css as a export and removed apply base styles injectscript
Removed transformer since tailwind plugin defaults to lightning css

You should consider this change since it improves the code base significantly.

Closing or for now.


swagger UI always sends JSON

Regardless of what I add to the trails metadata for my endpoints, swagger always try to send contents as application/json:

@elbrujohalcon If you want to send anything to a given endpoint, you must set consumes to  [""] (a list with an empty string) in the trails metadata for the given endpoint.
Example:
, consumes => [""]

Thanks @harenson


cilium-health: Fix logging initialization

Allow to set up log driver and log driver options for cilium-health
process.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

This change is

@aanm PTAL

test-me-please

Build failure :
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5346
Appears related. cilium-health failed to start, and thus the CI tests failed:
cilium-health-ep                           never          34s ago      7       Endpoint failed to run: stat /var/run/cilium/state/health-endpoint.pid: no such file or directory

test-me-please

test-me-please


the KeyError on forgotten hook arguments is non-descriptive

instead there should be a clear error on what arguments are missing

example pytest-dev/pytest#1034


Generate access methods

This MR is based on https://github.com/Kofituo/rifgen/pull/1, only the last commit is added and I didn't want to rebase it.
It adds a new attribute macro #[generate_access_methods] that can be added to a struct. This macro automatically generates a constructor (new(...) -> Self), setters and getters, which are later treated like these methods have a #[generate_interface] macro set.
This feature is very handy if you operate on simple (possibly generated)  structs that just hold some data and don't have any special logic attached (like POJO in java).

Thanks for new proc macro

Sorry for the late merge.


Jupyter Labs

Have you considered building a version of Eve as a plugin for Jupyter Labs?

This isn't currently on our roadmap. What is your goal in using Eve this way?

Someone has integrated/is integrating Eve into Hyperdev https://github.com/jonbjornn/eve-hyperdev which I guess is sort of similar (having used neither). Sandstorm would be another potentially interesting environment for Eve.

Closing this due to inactivity. Feel free to reopen it with thoughts on what the integration would look like if this still effects you.


Instrument BoxPainter descendants.

We are not instrumenting BoxPainter itself, because its constructor is const.

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

There is no tests because the instrumented classes are private.
In future we will have lint that will remind to instrument disposables.

Agreed to postpone this till macro implementation.


vainfo errors inspite of reboot

$ vainfo
libva info: VA-API version 0.39.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/intel/mediasdk/lib64/iHD_drv_video.so
libva error: /opt/intel/mediasdk/lib64/iHD_drv_video.so has no function __vaDriverInit_0_32
libva info: va_openDriver() returns -1
vaInitialize failed with error code -1 (unknown libva error),exit
Due to unavoidable reasons, I am using Ubuntu 16.04 instead of 18.04. Would this cause this driver error?

Can you provide a bit more information about your environment, please?
How have you installed libva? Have you installed it via "gst-video-analytics/scripts/build_install_libva.sh" from this repo? The version "VA-API version 0.39.0" looks wrong. Looks like you have a legacy environment.
How have you installed MediaSDK? Have you installed it via "gst-video-analytics/scripts/install_dependencies.sh"?
Can you call the following command, please?
$> strings /opt/intel/mediasdk/lib64/iHD_drv_video.so | grep vaDriverInit

Hi @subashp !
First of all, please note, that VA-API and iHD driver are needed only if you want to use gstreamer vaapi elements. It means that the issue you reported doesn't block you from, for instance, running pipelines with software decode. Just go thru the rest of GSG and try to run samples.
Second, if you're really sure you want to test vaapi-based pipelines, please follow @brmarkus advices. I would also suggest you to install Media SDK 2018Q2.2 (https://github.com/Intel-Media-SDK/MediaSDK/releases/download/MediaSDK-2018-Q2.2/MediaStack.tar.gz) instead of 19.1.0 version (this may be related to your Ubuntu 16 installation)


Consider rename annotation in original variable

Fixes #557
Needs a test, we can use https://gist.github.com/vvp/ff9dff52864bb761df31e7a7bcea940e

@ericglau Can you merge and release this fix?


{Core} Hotfix: Fix inifite extension install loop

Description

This PR consolidates changes in https://github.com/Azure/azure-cli/pull/17474 and also has the changes to only allow prefix match for help commands during dynamic extension install to resolve #17696.
Testing Guide

az account -s sub_id set: not trigger extension install
az devops --organization org project list: not trigger extension install
az devops: not trigger extension install
az devops -h: trigger extension install
az devops project list --organization org: trigger extension install
az devops project list: trigger extension install
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

I thought of a better place to trigger extension installation rather than argparse._check_value. argparse._check_value is alrady too deep.
How about we check whether the command is in the command_table or command_group_table after they are full-loaded:
https://github.com/Azure/azure-cli/blob/1ca05dbabbe0f2f403436c66eb301cdf3c1f15be/src/azure-cli-core/azure/cli/core/__init__.py#L452-L460
This will be very easy with the extraction of extension installation logic from  _check_value (https://github.com/Azure/azure-cli/pull/17474).

As for the behavior of argparse, it is expected that -s is skipped during parsing and marked as unrecognized later.
We can repro with
import argparse

# create the top-level parser
parser = argparse.ArgumentParser(prog='PROG')
subparsers = parser.add_subparsers(help='sub-command help')

# create the parser for the "a" command
parser_a = subparsers.add_parser('a', help='a help')
parser_a.add_argument('--bar', type=int, help='bar help')

print(parser.parse_args('--bar a'.split()))

usage: PROG [-h] {a} ...
PROG: error: unrecognized arguments: --bar

So checking whether the command is valid is much easier than altering the behavior of argparse.

I thought of a better place to trigger extension installation rather than argparse._check_value. argparse._check_value is alrady too deep.
How about we check whether the command is in the command_table or command_group_table after they are full-loaded:
https://github.com/Azure/azure-cli/blob/1ca05dbabbe0f2f403436c66eb301cdf3c1f15be/src/azure-cli-core/azure/cli/core/__init__.py#L452-L460
This will be very easy with the extraction of extension installation logic from _check_value (#17474).

Thanks for the suggestion. I will check long-term solutions later.


Release 1.1.0

Hi @muenzpraeger ,
Was curious if you could document an example of adding a route to the backend and possibly even debugging (In Visual Studio Code) with the standard express server?
Jordan


Custom tag names for routes.

Route tags/namespaces at the moment are generated by what is provided in handlers. Might there be a way to specify renames for these tags so that they can be more clear? For example
	tags(
		(paths = [route::admin::user], name = "Admin", description = "Admin endpoints."),
	),

on openapi for example?

The #[openapi(...)] is unable to access the tags attribute of the path operation. Instead at the moment what can be done is to define custom tag along with the path operation.
#[utoipa::path(
  tag = "Admin",
...
)]

Is there a way to sort which order the tags are placed in?

No they will be organized alphabethical order according to the path. Paths with same tag will be grouped together. The paths will be placed to BTreeMap which will contain order by itself. And also there is no way to sort them in UI. That would require additional JavaScript from the end user but there is no way to provide such unfortunately.

Closing due inactivity.


Close connection before retrying

Closes the connection in the pool before retrying it with different dial options.

Coverage remained the same at 73.931% when pulling 8d29bbb79386cadc7320fe470a9e60356faff478 on fix/allow-insecure-fallback into 870c477cad68d8bc0d690cab9edf72e8fe6e674d on develop.


Event: Support on_mouse_drag

We should support this event for all window types.
Method description from pyglet:

The mouse was moved with one or more mouse buttons pressed. This event will continue to be fired even if the mouse leaves the window, so long as the drag buttons are continuously held down.

We need to explore how this event is handled in all window libraries and if the on_mouse_motion function is also triggered during mouse drag. We could simplify this by checking mouse button states during mouse motion and simply send the event to a generic mouse drag method.

Now supported for all window types.


NIFI-2829: Fixed PutSQL time unit test.

The unit test for DATE type used GMT timezone, that causes an assertion error in timezones such as EST (-5).
We need to use local timezone instead of GMT, as Derby and PutSQL uses local timezone.
The unit test failed before as follows:

Unit test code, passed: '2002-02-02 GMT'
PutSQL code convertedi it to local: '2002-02-01 EST', and stored as '2002-02-01' in Derby database without timezone info
Unit test code SELECT the inserted value, passed a GMT calender, then got epoch timestamp, which was '2002-01-31'

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@joewitt The test you marked with '@Ignore' used GMT, but PutSQL and Derby database (used in unit test) treat date without timezone, i.e. local time. This caused the assertion error.
I've changed the unit test from using GMT to local timezone. Confirmed the test passes with various timezone, including UTC, GMT, JST, PST, EST ... etc.
Thanks for reporting the unit test failure. I believe it works fine now. Would you review this PR?

Thanks for the detail explanation.
Indeed using local time zone is more reasonable.
Didn’t notice the date will be transform into local time zone once with value format.
Just want to point out that I first try the approach you mentioned (use local time zone) will encounter problem with Time type.
My time zone is UTC+8, which cause time string “01:01:01” in Time type will become negative long value.
This reasonable because Time type only consider time without epoch so it will be negative if it’s earlier than “08:00:00”.
However this will not pass the LONG_PATTERN in PutSQL and thus consider a negative long value to be in format "HH:mm:ss.SSS” instead of long.
This will encounter error while parsing for sure : java.text.ParseException: Unparseable date: “-28739000”.
If I try your commit with changing the timeStr to “01:01:01" in testUsingDateTimeValuesWithFormatAttribute will encounter negative long parsing problem which mentioned above.
Don’t know if you will encounter similar problem with negative long value in Time type, too?
I've try your commit together with LONG_PATTERN that also match negative long value ("^-?\d{1,19}$”) today and everything works fine now.
Thanks for any response.

@yjhyjhyjh0 Thank you very much to point that out. As you mentioned, for timezones ahead of UTC can have negative epoch values time, and we should support those are valid long values.
I've updated PutSQL LONG_PATTERN to accept negative values, and also removed the use of 'GMT' from TestPutSQL completely. It works with various timezones, UTC, GMT, JST, PST and EST. @joewitt Please check when you have time.

Reviewing...

+1, LGTM.  Verified the three cases in the unit test, and tested with a negative long.  Merging...


[feature] group HTTP requests to reduce battery consumption

can HTTP/2 help with this? Do you still maintain the tool?
I'm building a Telehealth and need my idb to sync data like (eRX, diagnosis(icd10 and stuff), lab requests and referrals from Doctor Workstation with other clinical tools to my RDS backend

basically request multiplexing from HTTP/2.
@darrachequesne

Do you still maintain the tool?

Yes I do :+1:

can HTTP/2 help with this?

I'm not sure this is related.
Currently, the write requests are sent as soon as possible, while the read requests are sent on a periodic basis. This totally works, but delaying the write requests to be sent with the read requests could reduce the battery consumption for mobile devices.


Does SkyAPM-nodejs support to use in Opentracing way?

Hi! We are planning to add tracing to a nodejs project. Due to some reasons, we cannot use the below way to instrument our code.
require("skyapm-nodejs").start({ serviceName: "test", });
So we are wondering if SkyAPM-nodejs supports to use in Opentracing way? Just like below:
// Replace this line with the tracer implementation of your choice.
const tracer = new opentracing.Tracer();  //any method we can new a SkyAPM-nodejs tracer ?

const span = tracer.startSpan('http_request');
const opts = {
    host : 'example.com',
    method: 'GET',
    port : '80',
    path: '/',
};
http.request(opts, res => {
    res.setEncoding('utf8');
    res.on('error', err => {
        // assuming no retries, mark the span as failed
        span.setTag(opentracing.Tags.ERROR, true);
        span.log({'event': 'error', 'error.object': err, 'message': err.message, 'stack': err.stack});
        span.finish();
    });
    res.on('data', chunk => {
        span.log({'event': 'data_received', 'chunk_length': chunk.length});
    });
    res.on('end', () => {
        span.log({'event': 'request_end'});
        span.finish();
    });
}).end();

Thank you!

I don't think we have an opentracing way in NodeJS agent, can you talk about why you cannot use the auto instrumentation way?

Thanks for your reply!

OpenTracing is not active anymore, don't follow that project. They all move into OpenTelemetry, which is less stable than OT. But to be honest, both OpenTracing and OpenTelemetry are not very high value, comparing to auto instrumentation.


Change logical definitons for children of 'signaling receptor activity'

These use 'has input', which is wrong WRT GO-CAM modeling guidelines.
We need to use either 'has small molecule activator activity' for small molecules, such  that the logical definition would be:
signaling receptor activity
and 'has small molecule activator' some chemical enttiy
However for protein-activated receptors, such as insulin receptor, I dont know which RO relation we can use (or maybe we need to create one?)
from OLS:

@cmungall @thomaspd @ukemi @vanaukenk Any suggestions?
Thanks, Pascale

Options:

Create a new parent for ‘has small molecule regulator’ (+ activator/inhibitor children), 'has regulator'/'activator'/'inhibitor'
Rename ‘has small molecule regulator’ & children to 'has regulator'/'activator'/'inhibitor'
'
Impacted terms:

'BMP receptor activity'
'C-C motif chemokine 2 receptor activity'
'GPI-linked ephrin receptor activity'
'ICAM-3 receptor activity'
'activin receptor activity'
'activin receptor activity, type I'
'activin receptor activity, type II'
'apelin receptor activity'
'apolipoprotein A-I receptor activity'
'boss receptor activity'
'brain-derived neurotrophic factor receptor activity'
'cell adhesion receptor activity'
'cholecystokinin receptor activity'
'ciliary neurotrophic factor receptor activity'
'ephrin receptor activity'
'epidermal growth factor receptor activity'
'erythropoietin receptor activity'
'fibroblast growth factor receptor activity'
'galanin receptor activity'
'gastrin receptor activity'
'glial cell-derived neurotrophic factor receptor activity'
'granulocyte colony-stimulating factor receptor activity'
'granulocyte macrophage colony-stimulating factor receptor activity'
'growth hormone secretagogue receptor activity'
'growth hormone-releasing hormone receptor activity'
'hepatocyte growth factor receptor activity'
'insulin receptor activity'
'insulin-like growth factor receptor activity'
'interleukin-1 receptor activity'
'interleukin-1, type I, activating receptor activity'
'interleukin-1, type II, blocking receptor activity'
'interleukin-10 receptor activity'
'interleukin-11 receptor activity'
'interleukin-13 receptor activity'
'interleukin-15 receptor activity'
'interleukin-16 receptor activity'
'interleukin-17 receptor activity'
'interleukin-17A receptor activity'
'interleukin-18 receptor activity'
'interleukin-19 receptor activity'
'interleukin-2 receptor activity'
'interleukin-20 receptor activity'
'interleukin-21 receptor activity'
'interleukin-22 receptor activity'
'interleukin-24 receptor activity'
'interleukin-25 receptor activity'
'interleukin-26 receptor activity'
'interleukin-27 receptor activity'
'interleukin-3 receptor activity'
'interleukin-33 receptor activity'
'interleukin-4 receptor activity'
'interleukin-5 receptor activity'
'interleukin-6 receptor activity'
'interleukin-7 receptor activity'
'interleukin-8 receptor activity'
'interleukin-9 receptor activity'
'leukemia inhibitory factor receptor activity'
'macrophage colony-stimulating factor receptor activity'
'neuropeptide Y receptor activity'
'oncostatin-M receptor activity'
'orexin receptor activity'
'pancreatic polypeptide receptor activity'
'parathyroid hormone receptor activity'
'peptide YY receptor activity'
'pituitary adenylate cyclase-activating polypeptide receptor activity'
'placental growth factor receptor activity'
'platelet-derived growth factor alpha-receptor activity'
'platelet-derived growth factor beta-receptor activity'
'platelet-derived growth factor receptor activity'
'prolactin receptor activity'
'protein tyrosine kinase collagen receptor activity'
'secretin receptor activity'
'semaphorin receptor activity'
'stem cell factor receptor activity'
'transforming growth factor beta receptor activity'
'transforming growth factor beta receptor activity, type I'
'transforming growth factor beta receptor activity, type II'
'transforming growth factor beta receptor activity, type III'
'transmembrane histidine kinase cytokinin receptor activity'
'transmembrane receptor histidine kinase activity'
'transmembrane receptor protein kinase activity'
'transmembrane receptor protein phosphatase activity'
'transmembrane receptor protein serine/threonine kinase activity'
'transmembrane receptor protein tyrosine kinase activity'
'transmembrane receptor protein tyrosine phosphatase activity'
'transmembrane-ephrin receptor activity'
'urokinase plasminogen activator receptor activity'
'vascular endothelial growth factor receptor activity'

My observations are: 1) there aren't too many impacted terms, and 2) not all of the terms listed above would be addressed by the proposed solution (e.g. 'transmembrane receptor protein kinase activity'). Logical definitions based on PRO or some other way to group proteins into classes seems overly complicated for handling this number of terms, which we could handle, at least for the time being, by just asserting them to be children of signaling receptor activity (which is probably already the case, so job done :) ).
As an added consideration, I'm concerned that having a new relation, which would be equivalent to a property chain that involves a directly_regulates relation, could potentially lead to incorrect inferences, since GO-CAM uses those in many contexts, not just for receptor ligands.


[Feature Request] Add directional hint option to ISuggestOptions

Context

[X] This issue is not a bug report. (please use a different template for reporting a bug)
[X] This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description
The problem
In some cases, it can be a bit confusing to users when the suggestions widget jumps up and down as they are typing. This will often happen when you have a suggestion list shown close to the bottom of the screen. In this case, if the initial suggestions are very long the suggestions will display above the cursor and as you refine the search the suggestion list will move below the cursor.
The recommendation
It would be nice if we had a way to give some sort of hint to the editor on where we would like to display this suggestion menu. I understand that in some cases this moving might need to happen but it would at least be nice to specify a preference when there is enough space above and below the cursor. I imagine as an end-user I could signal this intent via the existing ISuggestOptions.
I would imagine we could add a new property similar to this.
directionHint: 'top' | 'bottom';

Implementation challenges
I have spent a bit of time looking into this to find a workaround for my own needs. In doing so I have become somewhat familiar with the problem. To fix this it would appear that changes to both monaco-editor and vscode would have to occur. In vscode, it would appear that somehow this directional hint would have to trickle down to the suggestWidget's layout function.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!

Maybe it makes sense to request this feature for VS Code (it would be available in the monaco editor as well then).


ENYO-2136: NewPanels: Panel disappears when tapping the left side of …

…the first panel

This will prevent the hiding of the panels when tapping in the area not occupied by the panels (i.e. in AlwaysViewingPanelsWithVideoSample) and has no effect on the new panel implementation.

@alischuk  - the jira associated with this PR has been fixed. Should this PR be closed out? thanks.

Closing out as jira has been fixed with another PR.


Avoidable NaN-values for angle{x,y,z}

Consider changing these three expressions to:
anglex = atan2(Gxm, sqrt(Gym^2 + Gzm^2)) / (pi/180)

to deal with the edge case that Gym == Gzm == 0, yet Gxm != 0, in which case the result should be sign(Gxm) * 90

Thanks, will I incorporate this and your suggestion in issue #326 in upcoming release, which currently lives in this branch: https://github.com/wadpac/GGIR/tree/release2.1-0
Note that I have recently moved essential parts of g.getmetric to g.applymetrics and listed g.getmetric for depicration. In this way all raw data metrics are calculated in one place and in a way that no calculation are unnecessarily done twice.
I will try to clarify this better in the function documentation.

Thanks!

I am now looking at this. R can handle tan(1/0) but gives an error message when I do atan(1,0).
So, this may be a Python specific feature of the atan function.


Meeting 2019-02-18

Agenda

best practises
haproxy release
control_groups

https://sous-chefs.org/best-practices/

Best Practices
Sous-Chefs Best practises has been released. Noting common supported platforms, recommended patterns for Sous-Chefs cookbooks.
HAProxy 6.3.0 has been released

Add haproxy_cache resource for caching small objects with HAProxy version >=1.8
Expand integration test coverage to all stable and LTS HAProxy versions
Documentation - clarify extra_options hash string => array option
Documentation - Clarify the supported platforms

Control Groups
Control groups is currently in need of a rewrite, but we need use cases to develop a good set of interfaces for the custom resources.

Added to #52


Putting bad data in the draw pattern field causes Xenon to hang

This is due to an uncaught exception being thrown on the FX thread

java.lang.IllegalArgumentException: dash lengths all zero


fix: SVG import

Changes:

Update webpack file-loader to look for all specified file formats in the tree instead of previously restricted node_modules and fonts folders. This way we can import SVG files anywhere in the project as a file path string
Create a basic SvgIcon img component to take attribute src={file_path}
Update package.json and package-lock.json with "@material-ui/lab": "^4.0.0-alpha.61",, otherwise make build-for-server-dev would complain about package.json and package-lock.json are not in sync
Remove publicPath: ".." in client/configuration/webpack/webpack.config.prod.js, since we no longer host our own font files, and we need relative path to load static files like SVG

{
        test: /\.(jpg|png|gif|eot|svg|ttf|woff|woff2|otf)$/i,
        loader: "file-loader",
        options: {
          name: "static/assets/[name]-[contenthash].[ext]",
          publicPath: "..", // <--- this is no longer needed
        },
      },

Proof that it still works:

QA:

Run make build-for-server-dev && make start-server and check out http://localhost:5005/d/pbmc3k.cxg/. The SVG icon should work so is the rest of the app!
Run make start-frontend and check out http://localhost:3000/d/pbmc3k.cxg. Everything should work there too 👌

Ah some new lint errors from the minor TS version upgrade in the lock file I think. Will take a look now!

OK lint fixed! Turned out that package-lock.json was not having the right ts type version or something, so I did a rm -rf node_modules && rm package-lock.json && npm i and that seemed to work!


Fresh install: Syntax error in strings.py

I'm trying to do an offline install for floss. I downloaded all the dependencies via pip download. After running python setup.py install the installation passes fine, but when I try to run floss via the cmdline I receive the error:
  File "/usr/local/bin/floss", line 11, in <module>
    load_entry_point('floss==1.6.1', 'console_scripts', 'floss')()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 480, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2693, in load_entry_point
    return ep.load()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2324, in load
    return self.resolve()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2330, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python2.7/dist-packages/floss-1.6.1-py2.7.egg/floss/main.py", line 21, in <module>
    import floss.strings as strings
  File "/usr/local/lib/python2.7/dist-packages/floss-1.6.1-py2.7.egg/floss/strings.py", line 6
    ASCII_BYTE = rb"!\"#\$%&\'\(\)\*\+,-\./0123456789:;<=>\?@ABCDEFGHIJKLMNOPQRSTUVWXYZ\[\]\^_`abcdefghijklmnopqrstuvwxyz\{\|\}\\\~\t"

SyntaxError : invalid syntax

Running on Ubuntu GNU/Linux, python2 2.7.17

Sorry for the issue. This should be fixed now.

Sorry for the issue. This should be fixed now.

No worries - Figured I should bring that to your attention.
Cheers!

No worries - Figured I should bring that to your attention.
Cheers!


Remove beta banner from error page

Changes
Removes the beta banner from the error page as per issue #176
How to test

Check out the branch
Cause an error
Verify the beta banner is not visible on the error page Verify title does not appear in top bar (the black thing)
???
Profit!!!!!

Who can test
Anybody except @weapdiv-david

Actually it looks weird and the skip-link is missing, Adding it back in but without the title.

@hamishtaplin @weapdiv-david Is this ok to merge now?

@dhilton @weapdiv-david Yes


Blog -app: Controllers

Blog -app: Controllers
In this PR I  created for each URL:

A route.
An action in the correct controller.
A view file.

Thank you very much @Whoistolu!


Update README.md

to test prow jenkins e2e on 3.11

/test e2e

The 3.11 e2e tests was more successful than the 3.10 one, in that all the images built.
The test pod invocation failed:
2018/09/20 18:30:55 Running pod e2e-gcp
Activated service account credentials for<EMAIL_ADDRESS>/bin/bash: -c: line 7: syntax error near unexpected token `<'
2018/09/20 18:31:40 Container setup in pod e2e-gcp failed, exit code 2, reason Error

I believe this could be due to discrepancy between the master and openshift-3.11 entries I saw in the presubmit file.
I'll craft an openshift/release PR in a bit (in the middle of some operator changes at the moment) and retry this.

/test e2e

hmmm 3.11 now has the same gpg key failure as 3.10
I'll ask about a couple of things on forum-testplatform today after getting through some other items

/retest

passing e2e with 3.11 branch !!!
@bparees fyi for future reference


Duplicating Slideshow

Hi Mehedi,
I'm using your website template and I want to customize it so that it shows two galleries. One after the other. However, when I cloned the HTML element for the gallery using clone() it doesn't repeat the CSS or JavaScript for the respected HTML.  How can I repeat the element and call the CSS and JavaScript so that I can repeat the slideshow?
Thanks,
James

Hello @profWolfe
We are sorry, we didn't notice your issue. hope you have solved your issue. I am closing it now. if you are stuck with other things, let me know. I am here to help you. thanks


Use printf instead of echo -n in Makefile to avoid portability issues

As described in the title.
I've recently been having issues when regenerating CharonVersion.ml through echo -n on MacOS, where the echo version used does not seem to recognize the -n option, leading to printing it in the file and hence to syntax errors.
Following this StackOverflow post, this PR replaces the echo -n call by printf, which apparently has more consistent behavior across platforms.

@Nadrieril the CI failure is dubious. It seems to be failing because of the PR which adds the Unsolved trait instance.

I reran the CI, I think this hit just between the merge of the PRs related to Unsolved on the Charon and Aeneas sides.


CIV-6294 Moved FieldShowCondition to CaseEventToComplexTypes

CIV-6294 Moved FieldShowCondition to CaseEventToComplexTypes to make the fields visible on check your answers page
Before creating a pull request make sure that:

[ x] commit messages are meaningful and follow good commit message guidelines
[x ] README and other documentation has been updated / added (if needed)
[ x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-6294
Change description
Moved FieldShowCondition from complexTypes to CaseEventToComplexTypes to make the caseFields visible in check your answers page
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x ] No

Closing this pull request as the changes are a part of below pull request
https://github.com/hmcts/civil-general-apps-ccd-definition/pull/436