Upgrade to Tailwind v3

I have upgraded tailwindcss@latest postcss@latest autoprefixer@latest @tailwindcss/forms@latest using Yarn, the guide says to use npm but I think it should work the same.
The only additional step we had to take for our project was to remove mode: "jit" from the tailwind.config.js file. I went through the whole project to search for any instances of breaking changes but we were not using any of these features in v2.
All in all it was a pretty easy upgrade especially with the nice guide that Tailwind released.
I wasn't sure if you just wanted to merge the dependabot PR or I should make one, but the bot one doesn't include the autoprefixer@latest upgrade which was recommended in the guide. It also doesn't include the update to the tailwind config file.
It will be good to be on the latest release though, I am becoming a big fan of Tailwind!
Closes #491

Is storybook still working properly? I believe I added jit mode to support modern stuff in Storybook.

I have never actually tried out storybook before, I tried running it by doing yarn storybook with and without the mode: "jit" and I couldn't get it running either time. So there must be something else wrong, here is my ouput:
yarn run v1.22.15
$ start-storybook -p 6006
info @storybook/react v6.4.9
info
info => Loading presets
info => Using PostCSS preset with<EMAIL_ADDRESS>info => Using default Webpack5 setup
<i> [webpack-dev-middleware] wait until bundle finished
10% building 0/1 entries 0/0 dependencies 0/0 modules
info => Using cached manager
99% done plugins webpack-hot-middlewarewebpack built preview f2fb055661772743d9af in 5355ms
ModuleBuildError: Module build failed (from ./node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js):
Error: /home/mk/Desktop/CODE/dark-merged/.storybook/preview.js-generated-config-entry.js: 'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
    at enableFeature (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/features.js:51:13)
    at PluginPass.pre (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/index.js:78:35)
    at transformFile (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:94:27)
    at transformFile.next (<anonymous>)
    at run (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:33:12)
    at run.next (<anonymous>)
    at Function.transform (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transform.js:25:41)
    at transform.next (<anonymous>)
    at step (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:261:32)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:273:13
    at async.call.result.err.err (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:223:11)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:189:28
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/gensync-utils/async.js:73:7
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:113:33
    at step (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:287:14)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:273:13
    at processResult (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:701:19)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:807:5
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js:59:103
ModuleBuildError: Module build failed (from ./node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js):
Error: /home/mk/Desktop/CODE/dark-merged/generated-stories-entry.js: 'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
    at enableFeature (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/features.js:51:13)
    at PluginPass.pre (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/index.js:78:35)
    at transformFile (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:94:27)
    at transformFile.next (<anonymous>)
    at run (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:33:12)
    at run.next (<anonymous>)
    at Function.transform (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transform.js:25:41)
    at transform.next (<anonymous>)
    at step (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:261:32)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:273:13
    at async.call.result.err.err (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:223:11)
    at processResult (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:701:19)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:807:5
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js:59:103
ModuleBuildError: Module build failed (from ./node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js):
Error: /home/mk/Desktop/CODE/dark-merged/storybook-init-framework-entry.js: 'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
    at enableFeature (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/features.js:51:13)
    at PluginPass.pre (/home/mk/Desktop/CODE/dark-merged/node_modules/@babel/helper-create-class-features-plugin/lib/index.js:78:35)
    at transformFile (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:94:27)
    at transformFile.next (<anonymous>)
    at run (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transformation/index.js:33:12)
    at run.next (<anonymous>)
    at Function.transform (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/@babel/core/lib/transform.js:25:41)
    at transform.next (<anonymous>)
    at step (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:261:32)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:273:13
    at async.call.result.err.err (/home/mk/Desktop/CODE/dark-merged/node_modules/gensync/index.js:223:11)
    at processResult (/home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:701:19)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:807:5
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/home/mk/Desktop/CODE/dark-merged/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /home/mk/Desktop/CODE/dark-merged/node_modules/@storybook/builder-webpack5/node_modules/babel-loader/lib/index.js:59:103

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It referencing babel in the output, I am on the latest master branch, is storybook currently working for you? Maybe I am missing a step?
And yes focus-visible is working, there was no mention of breaking changes for this class.

Configure content sources
Since Tailwind no longer uses PurgeCSS under the hood, we’ve renamed the purge option to content to better reflect what it’s for:

Automatic transforms and filters
In Tailwind CSS v3.0, transform and filter utilities like scale-50 and brightness-75 will automatically take effect without needing to add the transform, filter, or backdrop-filter classes

flex-grow/shrink
We’ve added grow-* and shrink-* as aliases for flex-grow-* and flex-shrink-*:
The old class names will always work but you’re encouraged to update to the new ones.

I checked that everything was good in the upgrade guide, were you just posting these to let me know or did I miss something? @dylancom

I mentioned those as they advice code changes, but haven't been done yet.

Remove dark mode configuration The dark mode feature is now enabled using the media strategy by default, so you can remove this key entirely from your tailwind.config.js file, unless you’re using the class strategy.

This one we do not want to remove because we are utilizing the class strategy for our dark mode.

Configure content sources Since Tailwind no longer uses PurgeCSS under the hood, we’ve renamed the purge option to content to better reflect what it’s for:

It looks like I missed this one somehow.. but I have updated it to say content now. Thanks!

Automatic transforms and filters In Tailwind CSS v3.0, transform and filter utilities like scale-50 and brightness-75 will automatically take effect without needing to add the transform, filter, or backdrop-filter classes

For this one I searched the whole project for any instances of the transform filter or backdrop-filter classes but couldn't find any, so I think we are good here?

flex-grow/shrink We’ve added grow-* and shrink-* as aliases for flex-grow-* and flex-shrink-*: The old class names will always work but you’re encouraged to update to the new ones.

I did a search for these as well back when I did this PR and thought there was nothing, now I see there were some flex-shrink classes used so I have switched those to shrink now.
Thanks for reviewing this @dylancom

The class strategy refers to manually activating class="dark" on the html tag. We rely on the prefered color scheme right?
https://tailwindcss.com/docs/dark-mode#toggling-dark-mode-manually
We have different places where "transform" is used, in combo with opacity, rotation, scaling

So you are right about the dark mode. When I initially read it I thought they meant the dark: classes on the elements themselves. I have updated that now and also removed all the instances of the transform class. Sorry for not catching these things myself, I think the reason is that I've been busy trying to do 2 jobs, but soon I will have left my fiat job to focus on bitcoin dev full-time so I will be able to work on this with no distractions.


Fix the MFA policy

https://twitter.com/0xdabbad00/status/1068525426920710150

It's fixed in Github!

Re-open this ticket and please contact the AWS security team regarding my tweet. There are security issues that need to be fixed in 3 places in this repo.

Looks like this has been resolved now in https://github.com/awsdocs/iam-user-guide/commit/f774f911164e539d336fbb47bf2f5f9634a36a90#diff-a01f9dbfc67cae4336ef8df70427f02f


AttributeError: [E046] Can't retrieve unregistered extension attribute 'sentiment'. Did you forget to call the set_extension method?

hi,looks like it works for space3 now, thank you.
however getting the above error
#1 - looks like spacytextblob pipeline is registered
#2 - this is my code
nlp = spacy.load("en_core_web_sm")
nlp.add_pipe("spacytextblob")

not this is NOT the last pipe
doc = nlp(summaryOfenquiry)
def analyseSentiment(app,doc):
app.logger('Assessments:', doc._.sentiment.assessments)
return 1
what have i missed?

I had a similar error with doc._.sentiment.subjectivity and had to update to doc._.subjectivity.

that did it, thank you

Thank you for providing the fix @jcarlen. Apologies there was an issue in the documentation. It has now been updated in #10 and #11.


Another IP output and URL filter

Hello everyone.
Please tell me how to implement this idea:
you need to create two OpenVPN-servers using the script from @angristan. Next, do you need to combine these two OpenVPN-servers so that the user connects to one IP-address and leaves the Internet with a different IP-address?
How to implement this please tell me.

Is it mandatory to use two OpenVPN-servers, or can you just use another server to access the Internet?
All that matters to me is that the user accesses the Internet with a different IP-address, not the same as the OpenVPN-server. Are there any other options to do this?

Can I put several OpenVPN-servers on the Internet through one server with a different IP-address?
And how can you prevent users from visiting certain sites? Please tell me what kind of utility for this or can it be implemented in OpenVPN?

Hello, this is unrelated to this script, please find appropriate OpenVPN forums or similar to ask for help. We already overflowing with issues, so no hard feelings but I will close this.

the user connects to one IP-address and leaves the Internet with a different IP-address?

Install a proxy server on the entry IP and OpenVPN on the exit IP and use the http-proxy option in the ovpn file. See https://openvpn.net/community-resources/connecting-to-an-openvpn-server-via-an-http-proxy/

And how can you prevent users from visiting certain sites?

Install Pihole and set the OpenVPN server to use it as DNS server so that connected clients use it. It's the easiest solution but with some knowledge it can be bypassed.

Hello, this is unrelated to this script, please find appropriate OpenVPN forums or similar to ask for help. We already overflowing with issues, so no hard feelings but I will close this.

OK well. It's okay, I understand

the user connects to one IP-address and leaves the Internet with a different IP-address?

Install a proxy server on the entry IP and OpenVPN on the exit IP and use the http-proxy option in the ovpn file. See https://openvpn.net/community-resources/connecting-to-an-openvpn-server-via-an-http-proxy/

And how can you prevent users from visiting certain sites?

Install Pihole and set the OpenVPN server to use it as DNS server so that connected clients use it. It's the easiest solution but with some knowledge it can be bypassed.

Thank you, I will read the information about the proxy.
Yes, PiHole, this is what I needed.


Typescript file: Unable to resolve module ./routers/SwitchActions

Hi, I am having this error:
error: bundling failed: Error: Unable to resolve module `./routers/SwitchActions` from<EMAIL_ADDRESS>The module `./routers/SwitchActions` could not be found from
<EMAIL_ADDRESS>Indeed, none of these files exist:

  * `/Users/macbook/projects/planning-center-app/node_modules/@react-navigation/core/src/routers/SwitchActions(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json)`

Apparently, the bundler cannot load .ts files, and I am seeing that SwitchActions.ts is the only file that has the extension .ts, and the bundler cannot find it, does that have a reason to be typescript? I cannot get it working with this react-navigation v3

<EMAIL_ADDRESS><EMAIL_ADDRESS>

In addition to this, basically the bundler cannot load all .ts files, same with KeyGenerator.ts and /views/getChildRouter.ts

What bundler are you using? Metro loads .ts files fine.

if you have a rn-cli.config.js file, update config with 'ts'
example:
module.exports = {
  resolver: {
    sourceExts: [
      'js',
      'json',
      'jsx',
      'png',
      'ts',
    ],
  },
}

Thanks guys, I solved it by updating react-native from 0.55.4 up to 0.57.0 with all the new babel dependencies and all, following this changelog, it was a pain in the butt, but it's working now. I don't know if it really works out of the box with<EMAIL_ADDRESS>as the docs say or if @Piwaii  solutions works because I don't have a rn-cli.config.js file, but thanks for the help, I'll let you know if I am having troubles again

@satya164 Only 0.57+ support ts by default


Solid 1.6 spread/deproxification behaviour breaking solid-dnd drag handlers

Describe the bug
The changes in Solid 1.6 handling of spread/deproxification break previously working assignement of event listeners to elements in solid-dnd.
This code now fails to update the element with the appropriate event listeners once they are defined:
const Draggable = () => {
  const draggable = createDraggable(1);
  return (

Draggable

  // <--- this no longer works as before
        ✪

  );
};

draggable.dragActivators looks like
dragActivators: {
  enumerable: true,
  get: () => {
    return draggableActivators(id, true);
  },
},

What complicates things is that the activators depend on sensors being registered elsewhere, which is why this has to be reactive. This worked fine in Solid 1.5.x.
Your Example Website or App
https://github.com/thisbeyond/solid-dnd-site
Steps to Reproduce the Bug or Issue

Clone https://github.com/thisbeyond/solid-dnd-site
Install all dependencies with npm install (ensuring you have<EMAIL_ADDRESS>Run with npm run dev
Try the fine grained / drag handle example. Note it does not work (no drag behaviour).
Downgrade solid-js to 1.5.7 and note the same example now works.

Expected behavior
The drag activators should update reactively as sensors are registered.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

https://playground.solidjs.com/?hash=-985355670&version=1.5.7

✪ DIV

https://playground.solidjs.com/?hash=-1779828763&version=1.6.1

✪ DIV

@LiQuidProQuo f is a function.. and should be called as such. The fact it worked before was unintentional.
@martinpengellyphillips clear your package.lock and get your babel-preset-solid version to 1.6. And the example works again.

@ryansolid thanks - confirming that fixes the issue after I force installed 1.6.1 of babel-preset-solid.
Any idea why babel-preset-solid 1.6.x series is not installed by default (even after removing the package lock file)? Is there anything I can do as solid-dnd owner to help folks avoid hitting this issue themselves?


Make ECDSA_size() use consistent asn1 encoder.

ECDSA signature lengths are calculated using i2d_ECDSA_SIG().
i2d_ECDSA_SIG() was changed in a previous PR to use a custom ASN1 encoder (using WPACKET)
so that the normal ASN1 encoder does not need to be pulled into the provider boundary.
For consistency ECDSA_size() has been changed to also use i2d_ECDSA_SIG() - this can now
be used directly inside the FIPS provider.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

(There's a typo "ECDA_size()" in the commit message)

Updated the commit to remove the typo..

ping

rebased with no new changes to the code.

Thanks romen. Merged to master.


Payments api

Pending!!
Not in US. I CAN'T apply for beta program.

According to #59
@sbasi5576

Thanks. Also we know that you are overseas. But is there a way for you publish the interface to payments API? We can test it in the US.

I didn't get App to testing payments API.
If I make it only following documents, I can't check API working good or not.
Is any idea how can I request payment API?

Based on the facebook documentation it is just another button type.  https://developers.facebook.com/docs/messenger-platform/complete-guide/payments
To test the actual payments you need a real world app and go through facebook's approval process.

so you mean make a buy button Payment will be working?

Here is the full description of the buy button:
https://developers.facebook.com/docs/messenger-platform/send-api-reference/buy-button
It has dependency on the Receipt Template.
https://developers.facebook.com/docs/messenger-platform/send-api-reference/receipt-template
Another options facebook has is that they use javascript API:
https://developers.facebook.com/docs/messenger-platform/complete-guide/payments#webview_payments
Essentially, clicking on a Buy button - either for the Button or the Javascript API - facebook sends a tokenized credit card (a credit card number that has been converted into a short lived token for that transaction).  That token can be used with Paypal, Stripe or another payment processor to process the payment.
Since you are overseas and if you are having trouble accessing these documents the links above, please ping me and I can email these to you.

I can get those documents, but I can't request beta.
It's a big problem for develop library, because I can't confirm the method is working or not.


Is there anyway can I solve the images issues printing out on pos system via flutter?

I'm not able to print out my images on receipt paper
final Uint8List imgBytes = data.buffer.asUint8List();
var image = decodeImage(imgBytes);
printer.image(image,align: PosAlign.center);```

were you able to print pictures?

Yes I did, but I used flutter blue and esc_pos_utills

Hello,
I can print images with the following code:
import 'package:image/image.dart' as img;
import 'package:esc_pos_printer/esc_pos_printer.dart';
import 'package:esc_pos_utils/esc_pos_utils.dart';
...
final NetworkPrinter manager = NetworkPrinter(paperSize, profile);

Future<void> image(Uint8List bytes, {align = PosAlign.center}) {
   final img.Image image = img.decodeImage(bytes)!;
   final img.Image resized = img.copyResize(image, width: 558);
   this.manager.image(resized, align: align);
}

In my opinion, https://github.com/kechankrisna/pos printer manager is preferable.
Packge is dependent on this package, and for larger images, it is managed.

thanks for the help guys, i got it here

Thanks a lot. needed to add this line for resizing the image.
final img.Image resized = img.copyResize(image, width: 558);

the rest was the same as the package suggested.


Update screenshots

Update screenshots to reflect changes done in https://github.com/vaadin/vaadin-date-picker/commit/4252fef69b05e77fd030aba3114aa5869809523d.
Connects to vaadin/components-team-tasks#121

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io


Add CPU & memory checks and stubs

The goal of the PR is to enable local running of the workflow, including basic checks of workflow logic using stubs.
Closes #290
Closes #151 (though docs are needed here)
To do this, I added stub: blocks to all current processes, with the exception of the cell type classification process, which is not currently in the main workflow.
Unfortunately, adding stubs is insufficient for allowing local running, as the memory and cpu requirements are still used for the stub. So to fix that, I added some very simple functions inspired by nf-core to modify our memory and cpu settings, checking new params for the max memory and cpu and returning the lesser of the two values.
So to run locally, you can now do something like:
nextflow main.nf -profile ccdl -stub --max_cpus 2 --max_memory 2.GB

I put this parameter in the process_base.config file, as that is where they are used, but it might make sense to move it to the main nextflow.config file to make it easier to users to find and set for their own configuration. On the other hand, we encourage people to make their own config file, and any value they put there will override anyway, so it may be more a documentation question. Opinions welcome.
If this is working for others, I will update the docs to include these parameters (and that you can run with less RAM, though performance may be affected and no guarantees for something like Cell Ranger).
I expect to leave the -stub functionality undocumented, except perhaps in development instructions, as I don't think that is something we should expect end users to use.
One other thing I noticed while doing this (since I was hitting almost every process) was that we have some inconsistency in the number of spaces for indentation; I might want to fix that in this PR, but I didn't want too many modified lines for the review!

I added some docs about the new parameters as well as a few places that I ran into little mistakes. This should be ready for another review!


Bug: Markdown > Preview: Open Markdown Links setting not respected

VSCode Version: 1.37.1
OS Version: Windows 10, build 18362.356

Description:
VS Code does not appear to respect the Markdown > Preview: Open Markdown Links setting.  The expected behavior for this setting is described here.  In my case, both options (inPreview and inEditor) yield the same behavior, described below.
A MWE is attached: LinkTest.zip
Steps to Reproduce:

Open markdown file.
Open preview to the side.
Click link in preview of markdown file.
Result:

New editor tab with the linked file opens in the same group/panel as the preview tab.

Additional tests:

[x] Tested using the latest insiders build: same result
[x] Tested without any extensions: same result

That's an old VS Code version. Does this reproduce in the latest VS Code insiders build with all extensions disabled?

@mjbvz

That's an old VS Code version.

I just updated to the newest version and I get the same behavior.

Can you check if the reproduce in the latest VS Code insiders build with all extensions disabled?

Yeah, I mentioned in the initial post that I reproduced the issue in the latest insiders build.  I did this with no extensions installed.

Does not repo for me on insiders on windows:

Please provide more detailed repo steps

@mjbvz
Ok, I've done a ton more testing because it has been really difficult to come up with a consistent picture of what is happening.  Luckily, I think I've narrowed it down to the key problem.
It appears to arise in one specific circumstance: having spaces in the absolute file path of the file to which the markdown link refers.  And let me emphasize that this includes, but is not restricted to, markdown links that have spaces in the relative path specified in the markdown file.  That means that even if your current folder (and all subfolders) in VS Code are space-free, if it is stored on a path that contains spaces, preview links will not open properly.  (As an aside, I am aware that spaces in markdown links must be URL encoded [i.e., replaced with %20] to work at all and I have encoded them as such in all my tests.)
Here is a new test case to illustrate this:
LinkTest.zip
And here is an example of how this looks for me:

Thanks for the investigation. Can you please test this once VS Code 1.40 insiders is available later this week. I believe the issue may have been fixed by 36aa903d5a98ba5cf1d46b84c0a8fb3c2106bd8a as I can't reproduce the problem with VS Code 1.40 but can with VS Code 1.39

@mjbvz
I just tested with Insiders build 1.40, and I also no longer observe the issue with links containing spaces.  What is the typical timeframe for fixes in the Insiders build making their way into the mainline build?

1.40 should be out in the first or second week of November, see #82194


Support for Non-String Vertex/Edge IDs with Property Graph Data

Describe the bug
At present, any use of non-String vertex IDs appears in the UI as [object Object].

In the query response, the GraphSON response object contains the following:
...
{
    "@type":"g:Vertex",
    "@value":{
        "id":{
            "@type":"g:Int64",
            "@value":2306
        },
        "label":"airport"
   }
}
...

With using string-based IDs, the following is returned:
...
{
    "@type":"g:Vertex",
    "@value":{
        "id":"2306",
        "label":"airport"
   }
}
...

The extra type field gets returned for non-string IDs, causing the values to not be serialized properly back to the UI.
To Reproduce
Steps to reproduce the behavior:
Using Gremlin Server and TinkerGraph (with a vertexIdManager=ANY), create two vertices:
g.addV('airport').property(id,'2306')
and
g.addV('airport').property(id,2306)
Expected behavior
The ID should appear as the same value regardless of data type used.
Desktop (please complete the following information):

OS: MacOS
Browser: Firefox
Version: 102.7.0esr

Additional context
Add any other context about the problem here.

Adding a note here that a Gremlin Server also allows for an ID to be a UUID. The PR #60 appears to handle integer IDs, but what about if the ID is a UUID? In the graph-explorer project we recently ran into this and had to make some changes for the UUID ID type.


Accessibility bug: buttons are spamming aria-pressed but they are not toggle buttons

Steps to Reproduce
This is probably a bug in react-native-web, but that's no excuse.

Go to https://bsky.app/
Find any <button>
It will have aria-pressed="false"
Clicking it (mouse down / keyboard hold down) will switch it to aria-pressed="true"
Releasing will switch it back to aria-pressed="false"

This one is easy. It's wrong.
From https://w3c.github.io/aria/#aria-pressed and https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-pressed

Adding aria-pressed to an element with a role of button turns the button into a toggle button. The aria-pressed attribute is only relevant for toggle buttons. It represents the button's current "pressed" state.

These are not toggle buttons.

[ ] aria-pressed is not added to buttons that are not toggle buttons

Attachments
Relevant html
<button aria-pressed="false" role="button" tabindex="0"></button>

What platform(s) does this occur on?
Web (Desktop), Web (Mobile)
Device Info
Not Relevant
What version of the app are you using?
Web
Additional Information
The problem here is that people may have turned on options that announce something when the button becomes "toggled-on". You don't want that.

I would like to get my feet wet contributing to OSS and don't mind contributing this one liner if its okay with the Bsky team.

These accessibility improvements looks a lot of sense.

@PaulACoroneos the bug is probably this line of code (it should be removed):
https://github.com/bluesky-social/social-app/blob/5f7caf30105569fe02cda2b029d3e6cb1e4e4780/src/components/Button.tsx#L461

@PaulACoroneos the bug is probably this line of code (it should be removed):
https://github.com/bluesky-social/social-app/blob/5f7caf30105569fe02cda2b029d3e6cb1e4e4780/src/components/Button.tsx#L461

Yep thus me mentioning 1 liner 😊.


Add support for CRM/Tickets API endpoints

Hello,
This PR adds support for the CRM/Tickets endpoints:
https://developers.hubspot.com/docs/api/crm/tickets
There are issues with the way properties are handled with tickets that makes this a little difficult and I'm not sure how we want to support this in the long term.

Ticket properties can be pretty dynamic, the examples in the hubspot API documentation only show a few possible values but there are many and custom properties are also allowed.  Therefore, I've left the properties object as map[string]interface{} but I've defined custom objects for basically everything else.

For example, you can have a property defined by hubspot Date entered 'Closed (Careers)' if you had a pipeline called "Careers" - and they will define a property for each pipeline type like that.

When retrieving a ticket, there can be top-level dynamic attributes that are based on other objects as specified in your request query parameters.  I'm not sure how to deal with that, at the moment, my code does not support these at all the only way I can see this working is if we made the entire object return as a map[string]interface{} or had some sort of secondary un-Marshaling that would allow the user to alternately access everything as a map[string]interface{}

There does not seem to be a native "catch-all" mechanism in encoding/json

Other than that, this PR should be pretty clean.

@sblackstone
Thank you for creating a PR and sorry for the late reply.
I understand that the Ticket API is difficult to define dynamically, but I don't have a clear solution at the moment.
I would like you to consider the response policy, so could you wait a little longer?

There is an error in CI, so it would be helpful if you could fix it.

Sorry @sblackstone
Thank you for the notifying me.
But I don't have any good suggestions for improvement. If you don't mind, why don't you release it as a BETA and try to improve it later?
It would be helpful if you could fix the lint and unit tests :)

Sorry @sblackstone Thank you for the notifying me.
But I don't have any good suggestions for improvement. If you don't mind, why don't you release it as a BETA and try to improve it later? It would be helpful if you could fix the lint and unit tests :)

Sounds good..  I've been using this code in production for about 2 months now  so it should be good other than the design issues from above...

Tests are fixed and did make lint

@sblackstone
We released v0.6.0!
Thank's your contribution and sorry for the late reply.

Thanks!  I was just about to warn you that I have another feature coming soon[tm] (CRM Exports) which is just two functions.


Cost of use

Would it be possible to outline how pricing works for this visual, and if there are no costs for using it, whether this could be explicitly stated? This is also relevant for the Power Apps pages

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 551e3e82-bdac-49cd-1355-b416facb020b
Version Independent ID: c5699332-f895-c582-15ab-c952cfc0460c
Content: Getting started with the Azure Maps Power BI visual
Content Source: articles/azure-maps/power-bi-visual-getting-started.md
Service: azure-maps
GitHub Login: @anastasia-ms
Microsoft Alias: v-stharr

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

............................

Hello @OwenTheAnalyst Thanks for your patience on this query.
As the services are still in the preview version, it's too early to comment on this particular pricing model.
Get started with Azure Maps Power BI visual (Preview)
We suggest following this article or the Azure pricing calculator for further updates on this product.

I hope this helps with your query, please let us know if you need further help in this matter or we are good to close this case?
Note: You may want to reopen any closed issue in the future, we would be happy to assist you for sure!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Encode Doubles as half-floats when possible

This is a quick sketch of what would be needed to support this proposed change to the spec. It's not quite as trivial as I expected, but it's not too bad either. The only interesting new code is borrowed from this Stack Overflow answer, which the author has put into the public domain.
We can probably remove the special cases for negative zero and the NaNs and infinities now, and definitely should before merging this PR. I've just thrown put this branch together as a quick proof-of-concept to show roughly what the proposed change would require.
As a side note, we should probably change the intBitsToFloat16 in our current code to use that side of the conversion from the same Stack Overflow answer, instead of a version of the code that cbor-java uses, which comes from this other Stack Overflow answer that doesn't seem quite as trustworthy.
This will obviously need a lot more testing, but it won't be too hard to test fairly comprehensively (we might as well enumerate all possible half-float values in our tests).
Update: rebased on branch from #48, so all tests pass now. Note that one normalization test (UnsaturatedBuiltins) is currently failing on this branch, but that's only because we haven't changed our implementation to reflect this other new spec change yet. The relevant acceptance tests are passing.

Sorry, this isn't actually ready for review.

Okay, I think this is ready. I've added the following tests:

Arbitrary doubles round-trip through the binary encoding.
The binary encoding agrees with cbor-java (which I've added as a test dependency).
Integers with absolute values less than 2,048 round-trip (and 4,096 if even).
All non-NaN 16-bit floats round-trip through Float.

There are other things we could do but this seems reasonable to me.


Error: error creating cloudflare pages project

Confirmation

[X] This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
[X] I have searched the issue tracker and my issue isn't already found.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.10.0
on darwin_arm64

provider registry.terraform.io/cloudflare/cloudflare v4.47.0

Your version of Terraform is out of date! The latest version
is 1.10.1. You can update by downloading from https://www.terraform.io/downloads.html
Affected resource(s)
cloudflare_pages_project
Terraform configuration files
resource "cloudflare_pages_project" "from_terraform" {
  account_id        = var.account_id
  name              = "from-terraform"
  production_branch = "main"
  build_config {
    build_caching       = false
    build_command       = "hugo build"
    destination_dir     = "public"
  }
  deployment_configs {
    preview {
      always_use_latest_compatibility_date = false
      compatibility_date                   = "2024-12-06"
      compatibility_flags                  = []
      d1_databases                         = {}
      durable_object_namespaces            = {}
      environment_variables = {
        HUGO_VERSION = "0.139.0"
      }
      fail_open     = true
      kv_namespaces = {}
      r2_buckets    = {}
      secrets       = null # sensitive
      usage_model   = "standard"
    }
    production {
      always_use_latest_compatibility_date = false
      compatibility_date                   = "2024-12-06"
      compatibility_flags                  = []
      d1_databases                         = {}
      durable_object_namespaces            = {}
      environment_variables = {
        HUGO_VERSION = "0.139.0"
      }
      fail_open     = true
      kv_namespaces = {}
      r2_buckets    = {}
      secrets       = null # sensitive
      usage_model   = "standard"
    }
  }
  source {
    type = "github"
    config {
      deployments_enabled           = true
      owner                         = "hkford"
      pr_comments_enabled           = true
      preview_branch_excludes       = []
      preview_branch_includes       = ["*"]
      preview_deployment_setting    = "all"
      production_branch             = "main"
      production_deployment_enabled = true
      repo_name                     = "my-repo"
    }
  }
}

Link to debug output
https://gist.github.com/hkford/ac852955a3abef09030faf38639266ef
Panic output
No response
Expected output
Successfully create Cloudflare Pages project
Actual output
Could not create Cloudflare Pages project
Steps to reproduce
terraform apply
Additional factoids
I created a Cloudflare Pages project from console and imported it into the Terraform configuration file using terraform import.
References
No response

TF_LOG=DEBUG output

@hkford fyi there may be an issue creating projects with Account Owned Tokens. While we fix that, in the meantime you may be able to create your project using API Token Auth.

I'm using API Token and encountered this issue.

@hkford there was an issue with creating Pages projects using API Tokens that are owned by an account (as opposed to owned by a User). That issue has been fixed, so please let me know if you encounter any other issues!

@hkford there was an issue with creating Pages projects using API Tokens that are owned by an account (as opposed to owned by a User). That issue has been fixed, so please let us know if you encounter any other issues!

I confirmed I could successfully create Pages projects using API Tokens. Close the issue.


Integrate conda-store-ui docs with Storybook plugin

We have the conda-store-ui docs created in Storybook here: https://conda-incubator.github.io/conda-store-ui/?path=/story/welcome--page
While we can move the narrative docs directly, Storybook autogenerates the component docs. We need a way to include without duplication in the new docusaurus docs.

Originally, we were going to use the Storybook Docusaurus addon plugin, but looking into it further, it actually does the opposite. It allows us to use Docusaurus components in Storybook - which is not what we want.
Ref: https://github.com/facebook/docusaurus/discussions/7713
As per the discussion linked above, the best course of action is to use an iframe


SD Card not working

I have tried both on Max 8 and also directly through code simple sd card examples and seems sd card is not working at all. Tried on the Daisy Patch and Daisy Init() no messages just simply doesn't work at all, not sure where to look or how to debug even, cheers.

I'm sorry for the delay in response. Were you able to get this to work?
If not, I would suggest reformatting the SD card.
Also, you may be able to find a forum post that may have a solution.
For example, reformatting the SD card as MSDOS Fat16 was a solution to this user.
https://forum.electro-smith.com/t/oopsy-dev-branch-sd-card-drumloop-wav-example/1676/3
Let us know if you got this working!


Related: #2.
UPD: at this point I'm still in doubt on how to do that.
Currently, I am considering changing an "error queue" to "information queue" and running output ports in a duplex mode. After working a bit on #10, I am thinking that I want to know about MIDI port disconnection events fast enough. Queues sound a bit like an awkward way to handle that, but I don't know any alternatives.

I've read ALSA's seq API and other sources, so now I'm sure there's no "perfect way" to unify queue errors with "normal errors".
At some point later, I might make a "common queue" mechanism to unify input thread errors with errors returned by current API functions, but it feels like a premature optimisation currently.


Mongoose Array field with enum elements are not shown in new/edit dropdown menu?

It doesn't show drop down menu for an array type. Is there any option that I'm missing?

can you paste your schema?
in the meanwhile, you can try to force enums by adding availableValues to property options
resource: Resource,
options: {
  identifiers: {
    availableValues: [{name: 'xxx', value: 'zzz'}, ...]
  }
}

Thank you.
Here is the schema :
var roleSchema = new Schema({
...
identifiers : {type : [String], enum : permissionArray, required : true},
})
Also does admin bro supports new temporary collection from multiple collections?

@wojtek-krysiak  Thanks for the help. I added availableValues: [{label: 'xxx', value: 'zzz'}, ...] and values are displaying  in the drop down menu.
Now I'm having issue with array of objects. Values are not displayed in a object only keys are displayed as shown in the image.

Schema for this field is :
tiers :[{
                "starting_unit" : Number,
                "ending_unit" : Number,
                "price" : Number
 }]

which version admin-bro and admin-bro-mongoose do you use? asking because we had an error (fixed already) when "0" has been presented as an empty value.

package and it's versions :-1:
"admin-bro": "^1.5.2",
"admin-bro-expressjs": "^0.4.0",
"admin-bro-mongoose": "^0.3.1",

please upgrade to the latest and let me know if that helped:
"admin-bro": "1.6.0",
"admin-bro-expressjs": "^0.4.0",
"admin-bro-mongoose": "^v0.4.0", (why I added this `v` to the version???? - will change that in the next release btw)

Yeah, It worked Thanks for the help :+1:

@wojtek-krysiak  While saving Array of objects, values are returns in the following format
tiers.0.ending_unit:"15"
tiers.0.price:"1111"
tiers.0.starting_unit:"1"
tiers.1.ending_unit:"1000"
tiers.1.price:"2222"
tiers.1.starting_unit:"16"

Is this expected format?

yes. you can use unflatten to merge them back:
import { unflatten } from 'flat'

 const tiersObject = unflatten(tiers)

Thanks :+1:


Paymentsheet has dark space on the bottom

Describe the bug
See following screenshots:
Screen when iOS is light

Screen when iOS on phone  is set to dark appearance

To Reproduce
Steps to reproduce the behavior:

Init payment sheet with style LightTheme.
Present the payment sheet
Observe the black bar

Expected behavior
Should show the white bar according to the theme
Tested on:
iPhoneX
iOS15
Version of library: 0.2.3

Has this been solved?

0.35.0

Reproduced in reverse order
dark stripe payment sheet and white home bar


unable to access 'https://github.com/Epodonios/ProxyCollector.git/': The requested URL returned error: 403 Error: Process completed with exit code 128

unable to access 'https://github.com/Epodonios/ProxyCollector.git/': The requested URL returned error: 403
Error: Process completed with exit code 128

go to your repo setting
in actions tab
General>Workflow permissions
put it on Read and write permissions and check Allow GitHub Actions to create and approve pull requests

Thank u sir🤍


[ORC-542] env template first iteration

Configuring CLI to scan for envTemplates in artifact definitions, and hydrate them in the bundle (application) template.


[Bug] Enable login button on username and password auto fill

Summary
Enable login button on username and password auto fill
Motivation
When user reaches https://app.appsmith.com/ and if the user has cached their username and password in their browser/gmail account etc. then the username and password input fields will appear auto filled. In this case user does not have to place their cursor into these text input fields. In this case the login button stays disabled unless the user clicks into one of the input text fields.
Additional Context

@sumitsum this seems to now be working. Can you verify?


Org environments module tests

To run tests manually, create a venv, install requirements, and launch pytest:
virtualenv -p python3 /some/path/venv
. /some/path/venv/activate
pip install tests/requirements.txt
pytest

This initial version should now be complete, with a cloud build config. Let's try to trigger it...


Add TTC streetcar network +  Tramway de Québec

Addition of the TTC streetcar network:

Routes

501
503
504
505
506
509
510
511
512

Loops

Bingham Loop
Charlotte Loop
College Loop
Coxwell Loop
Distillery Loop
Dufferin Gate Loop
Earlscourt Loop
Exhibition Loop
Fleet Loop
Gunns Loop
High Park Loop
Humber Loop
Kipling Loop
Long Branch Loop
McCaul Loop
Neville Park Loop
Oakwood Loop
Queens Quay Loop
Sunnyside Loop
Wolseley Loop
Woodbine Loop

MSFs

Hillcrest Complex
Roncesvalles Carhouse
Russell Carhouse
Leslie Barns

Connector Tracks

Adelaide
Bathurst Connector
Bay
Church
Coxwell
Dufferin
McCaul
Ossington
Parliament
Richmond
Shaw
Victoria
York

ION track fix north of Allen station
Added the proposed alignment for the Tramway de Québec / Quebec City Tramway.

I honestly didn't realize just how many connectors and loops there are (woops) so I think we can combine all of the connector tracks into a single file, and all of the loops into a single file. Also, can you move all of the streetcar-related files into a streetcar subdirectory under data/toronto?

streetcarLoops.json and streetcarConnectors.json have been created in the data/toronto/streetcar subdirectory.

Here's what I've been trying so far (thinner lines and different stop label styling):

The new layer styling look great! Greatly helps differentiate the streetcar infrastructure in the city.

For any loop that is always used in service (e.g. Gunns loop, or High Park loop) I think we can omit the extra line geometry, but keep the labels for the loop.


[WIP] Create global variable for version of Patternfly

This was added in support of https://github.com/ManageIQ/ui-components/pull/249 which deals with different elements based on patternfly version in UI-components repo.
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1539862

I am leaving this in WIP state until https://github.com/ManageIQ/ui-components/pull/249 gets merged and we can bump the ui-components version in the package.json file.

Screenshot of what multiselect looks like when this variable is set properly

cc @simaishi
before this pr gets merged, https://github.com/ManageIQ/ui-components/pull/249 needs to make it in, and we'll need to bump the sui version of ui -omponents

The ui-components change was released as<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Feel free to upgrade to either (the difference is just a few recent gaprindashvili/no PRs), but note that only 1.0.* can be backported to gaprindashvili.

Gaprindashvili backport details:
$ git log -1
commit 7119a75a8d23f87b313dffc8285b418fc5b23642
Author: Martin Hradil<EMAIL_ADDRESS>Date:   Fri Feb 9 13:18:13 2018 +0100

    Merge pull request #1379 from chalettu/multiselect

    Create global variable for version of Patternfly
    (cherry picked from commit<PHONE_NUMBER>fb02ab978fea1061924d1c1f5cc741)

    https://bugzilla.redhat.com/show_bug.cgi?id=1544039


Push package failed in linux docker when package's icon path contains ''

Describe the bug
Pushing a package icon path with '\' to baget linux container,  will cause System.IO.FileNotFoundException.
fail: BaGet.Core.PackageIndexingService[0]
      Uploaded package is invalid
System.IO.FileNotFoundException: icons\mailkit-50.png
   at NuGet.Packaging.ZipArchiveExtensions.LookupEntry(ZipArchive zipArchive, String path)
   at NuGet.Packaging.ZipArchiveExtensions.OpenFile(ZipArchive zipArchive, String path)
   at NuGet.Packaging.PackageArchiveReader.GetStream(String path)
   at NuGet.Packaging.PackageReaderBase.GetStreamAsync(String path, CancellationToken cancellationToken)
   at BaGet.Core.PackageArchiveReaderExtensions.GetIconAsync(PackageArchiveReader package, CancellationToken cancellationToken) in /src/BaGet.Core/Extensions/PackageArchiveReaderExtensions.cs:line 54
   at BaGet.Core.PackageIndexingService.IndexAsync(Stream packageStream, CancellationToken cancellationToken) in /src/BaGet.Core/Indexing/PackageIndexingService.cs:line 61

To Reproduce
Steps to reproduce the behavior:

Using latest BaGet image DIGEST '3fcb1e9f22c7'
Push MailKit-2.4.1 to BaGet.
See error

Additional context
After some digging, I found something interesting.
According to PackageArchiveReader:
https://github.com/loic-sharma/BaGet/blob/bd440199ba16f62bdb0c157c69b6479f3e2aa9f9/src/BaGet.Core/Extensions/PackageArchiveReaderExtensions.cs#L50-L55
And Nuget.Packaging:
https://github.com/NuGet/NuGet.Client/blob/e59333e773bbc4fed97e5534fe88e25332ca04b0/src/NuGet.Core/NuGet.Packaging/PackageArchiveReader.cs#L140-L150
        public override Stream GetStream(string path)
        {
            Stream stream = null;
            path = path.Replace(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
            if (!string.IsNullOrEmpty(path))
            {
                stream = _zipArchive.OpenFile(path);
            }

            return stream;
        }

package.NuspecReader.GetIcon() return icon path in nuspec, it could be window-style or linux-style. When it's windows-style, and BaGet is running in linux,             path = path.Replace(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar); will not replace '\' to '/'.
I'm not sure it is a BaGet bug or a Nuget.Packaging bug, any thoughts?

hi
i see your point:
I have created a test that should execute exact this code areas with the same package and I'm hosting the test on linux/ubuntu (github actions)
https://github.com/mssforks/BaGet/tree/issue/513
BUT i cannot reproduce the exception.
Maybe just solved in one of the dependencies ?
@loic-sharma
Maybe we should compile and test the entire codebase on a Linux based OS (additionally to the current full build on windows).
Can you setup this in Azure Pipelines ?

@WernerMairl Thanks for reply~😃
Did you try upload this MailKit 2.4.1 package to BaGet? Because only this package's icon path contains '\', which cause the problem.

yes, you can give a look to my fork (link in my last post)
the test project contains the package as as resx and the nupkg is added to BaGet

Hi, could you try again with the latest docker image? This should be fixed by https://github.com/loic-sharma/BaGet/pull/517. I'll update the GitHub release and nuget.org packages soon.

Tested OK on latest docker image.

Still happening on me. Using the latest image (docker pull loicsharma/baget:0.4.0-preview2).
Stack trace:
 fail: BaGet.Core.PackageIndexingService[0]
       Uploaded package is invalid
 System.IO.FileNotFoundException: docs\README.md
    at NuGet.Packaging.ZipArchiveExtensions.LookupEntry(ZipArchive zipArchive, String path)
    at NuGet.Packaging.ZipArchiveExtensions.OpenFile(ZipArchive zipArchive, String path)
    at NuGet.Packaging.PackageArchiveReader.GetStream(String path)
    at NuGet.Packaging.PackageReaderBase.GetStreamAsync(String path, CancellationToken cancellationToken)
    at BaGet.Core.PackageArchiveReaderExtensions.GetReadmeAsync(PackageArchiveReader package, CancellationToken cancellationToken) in /src/BaGet.Core/Extensions/PackageArchiveReaderExtensions.cs:line 32
    at BaGet.Core.PackageIndexingService.IndexAsync(Stream packageStream, CancellationToken cancellationToken) in /src/BaGet.Core/Indexing/PackageIndexingService.cs:line 56


Medical Image Seg Benchmarking

Hi!
Have you tested the method on any medical seg datasets? Thank you.

@c-liangyu
Not yet. I'm full of the unfair comparison and un-released codes in medical UDA scenery.


README request

This would probably be obvious if I studied it for a while, but it is not at first glance and I suspect that applies to others also:
I request that the readme file contain a section explaining how this is different from (and presumably much better than) the typescript support already in SystemJS. What kinds of problems might I have, that might lead me to pick this up instead of the built-in support?

Thanks for raising this, I've add a paragraph under 'Overview' which hopefully clarifies things a bit more, please let me know if you think I should add anything else.

Thank you, that is very helpful!


Installing in Fedora 24

Hi everybody,
First, congratulations for the job, it's a awesome project.
Second,
I'm trying to install it in Fedora but when I run "install.sh" , said that "lsb_release" doesn't exist.
(I appreciate you answer me because I want to do my final project of my university degree using your library).
Cheers.

If it was better that I develop in Ubuntu, said me, (to switch to Ubuntu before I start with my project :D )

@TheTelematic Did you try:
yum install redhat-lsb

On a side note, we have a similar issue with OpenSUSE and are working to change our scripts to use /etc/os-release as seen here

It works!
Thank you very much :D
(PS: Awesome, the test consumes only 252KB)


bad run result with demo walking rosbag data

I just tested using the Garden dataset. The results are consistent. Are you using the correct configuration mentioned in the README?


.Net 5.0/3.1 support

Hello @AArnott,
I use your CodeGeneration.Roslyn, however requirement for .net core sdk 2.1 is a little bit outdated.
Any releases for .net 5.0?
#229 >> Source Generators will make this project redundant indeed
Hmm..., indeed?
Source Generators from MS are too raw:

external third party references is not solved yet
intellisense does not work

I am not interested in maintaining this any more at this point. Source Generators do it better (it can generate code in the IDE even before the source files are saved), and will progress and fix their bugs much faster than this repo would and achieve a better integration with user flows than this repo could.
FWIW, my experience with source generators isn't perfect, but I don't see the errors you do. I have a source generator that has third party dependencies, and I see intellisense working.


[WIP] filezilla: 3.31.0 -> 3.40.0, libfilezilla: 0.13.0 -> 0.15.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The filezilla project has migrated their source away from sourceforge, so the source is now pulled from their subversion repo. This also required some additional preparation with the auto*-tools.
The download link to their current source code uses some changing hash and timestamp, so it's probably unreliable.
Important: I've only verified these changes against release-18.09 and it's working for me.
Building against master and the new release-19.03 branch results in SIGSEGV when starting filezilla, which I believe is due to some incompatible mixing of the building and running gtk libraries, with similar output as observed in #56832

@pSub @jokogr Would you be able to check if this works on master or release-19.03?

@tokudan this is not working for me, I'm getting assertion failures, e.g.:

./src/gtk/bitmap.cpp(982): assert "IsOk()" failed in GetSubBitmap(): invalid bitmap

If I untick "Show this dialog" and click "Continue", the main window seems OK, but try clicking the Session Manager: it would segfault.

Ok, good to know that it's breaking somewhere else as well.
On release-18.09 with these patches, it seems to be working fine.
I probably won't be able to work on master or release-19.03 till it's matured a bit, so I'll leave this for now and will come back later in a couple of weeks. If someone wants to pick it up in the meantime, feel free.

@tokudan I could push my changes here or start a new PR, let me know if it is OK to edit your PR commits.
The changes simplify things quite, but FileZilla still segfaults. I forgot to add the last message I see once it segfaults:

/nix/store/h6f31s0hlf8kp10ji4pgfxblh59cy97v-wxwidgets-3.0.4/include/wx-3.0/wx/object.h(160): assert "wxDynamicCast(ptr, T)" failed in wxCheckCast(): wxStaticCast() used incorrectly

@jokogr I don't mind if you hijack this PR, I wont get to work on 19.03 or master soon.
If you use this PR or create a new one is up to you, I'm fine with both.

OK, my commits are mostly cleaning things up:

Switched back to fetchurl
For these source files there is no need for autoreconf
Move some dependencies to nativeBuildInputs or remove them totally
Add configure flag --disable-autoupdatecheck to FileZilla
Set enableParallelBuilding to true
Get gtk through wxGTK30

Unfortunately it has still assertion failures and it segfaults whenever Session Manager pops up.
A quick FileZilla code finds wxStaticCast in src/dbus/wxdbusconnection.h, not sure if it is related to the segfault.

cc @peterhoeg in case he has the solution already

Filezilla 3.42.1 is already on master, let's close this :)


README: minor adjustments, link catmapping

wrap lines in more natural places, to aid with readability of the code;
change some commas to semicolons, to avoid run-on sentences;
add link to the catmapping file;
split note about documentation into a separate paragraph.

Thanks

Thank you for making this :) it's a nice bot.


npm run build with prerender

$ grep -i welcome index.html

Would be nice if this tool would facilitate a pre-render IIUC.
Would be good at least to learn how to do it the canonical way.

What does prerender mean? I don't quite understand.
If you mean server rendering, there are no plans to support it in this tool n

I’m not sure what you meant exactly so I’ll close, but feel free to elaborate.
Thanks!

Yes, I mean "server rendering" which I think some people refer to is a "isomorphic" app? I think this is generally pretty crucial feature to a Website that intend to load fast and by picked up by crawlers.
I even went so far as an silly example: https://jsfiddle.net/dfumm9p9/

I believe README explicitly mentions this. We don't intend to support server rendering with this tool for numerous reasons (mostly that it imposes a lot more configuration and decisions than we are willing to support at this point). This tool is not the way to create React apps, it's just one possible way. You might be better served by tools listed as "alternatives" in README.


sphinx 'output_dir' is only used in cross-references

This is probably incorrect. Did I miss this in a rename?

Now sure what this was about. I see it used.


[WIP] Rancher K8s v1.28.2 Update

Issue:

https://github.com/rancher/rancher/issues/43109

Problem

To support Kubernetes 1.28 we need to bump all the k8s libraries to 1.28.

Solution

Bumping all Kubernetes libraries to 1.28.
Update wrangler dependencies to wrangler/v2 across the code base.
Update gnostic dependencies to gnostic-models across the code base.

Testing

1.28 RKE2, RKE1 and k3s clusters with forked dependencies.

Example nginx deployment on 1.28 RKE2, RKE1 and k3s clusters with forked dependencies.

Update from 1.27.6 to 1.28.2 on RKE2, RKE1 and k3s clusters with forked dependencies.

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

Rebase with release/v2.8

Rebased with release/v2.8 to inculcate blocking changes from https://github.com/rancher/rancher/pull/42406/commits

needs to be rebased

Merging this PR and will open follow-up PR to bump CATTLE_ETCD_VERSION.


Please update package on www.nuget.org

Hi, the nuget package www.nuget.org is still 0.4.1. I will appreciate it a lot if you can update the package. Thx.

Hi,
0.5.0 is available on nuget:
https://www.nuget.org/packages/GOEddie.SQLCover/0.5.0
ed


fix typo on query

I don't think this works the way it was intended.
thanks @yrudman
@miq-bot assign @kbrock
🍒
part of https://bugzilla.redhat.com/show_bug.cgi?id=1777041

@miq-bot add_label bug

thanks @d-m-u (I introduced that bug 4 years ago?)


Support the parameters configured in the task can be accessed through pipeline Output Variables

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
--No
Describe the solution you'd like to see
A clear and concise description of the new feature.
--Using the Build tools Task provided by "jfrog-azure-devops-extension", support the parameters configured in the task can be accessed through pipeline Output Variables
Expectation： All variables under "inputs:" can be referenced by other tasks.
For example:
artifactoryResolverService: "JFrog Artifactory V2" in task "JFrogMaven@1"

Can be referenced in the task "CmdLine@2" by using $(jfrog_maven_task.artifactoryResolverService),which outputs "JFrog Artifactory V2"

Describe alternatives you've considered
If applicable, a clear and concise description of any alternative solutions or features you've considered.
--No
Additional context
Add any other context or screenshots about the feature request here.
--No

We are doing deep integration of jfrog-azure-devops-extension and Azure DevOps, which is important to us.


Transparency of rod background color is applied to rod color in bar chart.

Hi, I'm attempting to use a semi-transparent rod background color to create a subtle bar background an so the horizontal lines show through. But what I'm finding is that the alpha of the rod background is overriding the alpha of the rod, so it becomes transparent as well.
I was expecting to be able to have an opaque rod with a semi-transparent background. Is this is bug or am I missing something?

Hi there.
I checked and it is working correctly.
Open bar_chart_sample1.dart.
change line 115 to colors: [Colors.red],.
change line 120 to colors: [Colors.red.withOpacity(0.2)],
And this is what you get:

hmmm. Ok. let me try again.

Ok, it's something to do with gradients. I changes my code to use Colors.red like your example and it worked as you sia.d But when I changed it too [Colors.red, Colors.yellow] it went transparent like this:

This is probably something to do with my poor understanding of colors in material design or something (it hurts my head trying to follow the docs).


⚠ Fetchers has degraded performance

In de81f1f, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 342 ms

Resolved: Fetchers performance has improved in de5c6e4.


Perf optimizations for JRuby ext.

Use RubyString.cat(byte[]) rather than concat(newString(new String(data)))
Use byte[] instead of String for current header
Pre-allocate control symbols and compare directly
Initialize empty strings with 10 byte buffer
Use respondsTo() instead of respond_to_p
Wrap incoming content directly rather than making a copy

More could be done; the changes above largely reduce allocation
rates, and remaining allocations are heavy in byte[] and ByteList.
The fetchData method in particular is creating many throwaway byte[]
that could potentially be copied directly from the ByteBuffer into
a target string.
Numbers are improved nicely with this set of fixes, though.
Before (modified bench/thin.rb to skip thin and loop):
Rehearsal ------------------------------------------------
http-parser:   1.635000   0.000000   1.635000 (  1.635000)
--------------------------------------- total: 1.635000sec

                   user     system      total        real
http-parser:   0.702000   0.000000   0.702000 (  0.702000)
Rehearsal ------------------------------------------------
http-parser:   0.662000   0.000000   0.662000 (  0.661000)
--------------------------------------- total: 0.662000sec

                   user     system      total        real
http-parser:   0.659000   0.000000   0.659000 (  0.659000)

After:
Rehearsal ------------------------------------------------
http-parser:   1.395000   0.000000   1.395000 (  1.395000)
--------------------------------------- total: 1.395000sec

                   user     system      total        real
http-parser:   0.552000   0.000000   0.552000 (  0.552000)
Rehearsal ------------------------------------------------
http-parser:   0.509000   0.000000   0.509000 (  0.510000)
--------------------------------------- total: 0.509000sec

                   user     system      total        real
http-parser:   0.511000   0.000000   0.511000 (  0.511000)

More numbers, because that's what I do.
Ruby 1.9.3:
Rehearsal ------------------------------------------------
http-parser:   0.580000   0.000000   0.580000 (  0.581969)
--------------------------------------- total: 0.580000sec

                   user     system      total        real
http-parser:   0.600000   0.000000   0.600000 (  0.598812)

JRuby master on Java 7u2 (previous were on Java 6u29)
Rehearsal ------------------------------------------------
http-parser:   1.564000   0.000000   1.564000 (  1.565000)
--------------------------------------- total: 1.564000sec

                   user     system      total        real
http-parser:   0.538000   0.000000   0.538000 (  0.538000)
Rehearsal ------------------------------------------------
http-parser:   0.578000   0.000000   0.578000 (  0.579000)
--------------------------------------- total: 0.578000sec

                   user     system      total        real
http-parser:   0.492000   0.000000   0.492000 (  0.492000)

Force-pushed the fixed version.

Thanks, looks great.


Generalize subproc exec

Why are the changes needed?
The previous subproc_execute was too restrictive and wouldn't allow additional kwargs to subprocess.run.
What changes were proposed in this pull request?
This adds the option to pass arbitrary kwargs, with sensible defaults that can be overridden. Tests were also added.
How was this patch tested?
2 new unit tests

Rebasing after a merge pulled in and signed off a bunch of other commits.... closing to do this properly.


Out of date guide

Today i logged in and noticed that the SSIS package execution changed allot. The document above isn't up to date with that.
https://imgur.com/a/1FLoK2m

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 311ed7bd-e869-3e77-4601-235149e54c03
Version Independent ID: 7f767d44-195c-d869-ab43-606feb470447
Content: Run SSIS package with Execute SSIS Package Activity - Azure
Content Source: articles/data-factory/how-to-invoke-ssis-package-ssis-activity.md
Service: data-factory
GitHub Login: @swinarko
Microsoft Alias: sawinark

Thank you for your feedback, we will update the doc soon.

#please-close


intel_adsp: Do not use xtensa hal with xcc-clang

Do not us XTENSA_HAL when building with xt-clang.
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

A short note "why" would be nice. The definitions of HAL need to come from somewhere. Plus typo "s/do not us/do not use/".

It is the same with xcc, it comes from cadence toolchain. Will add this information on commit message though.

v2:

Fix typo on commit message and add more information about the change.

v3:

Move position independent flags to a compiler property to avoid conditionals in the CMakeList file


Cookies as a server (get all including defined externally)

I was looking into a way to get all cookies, even those defined externally such as web_auth in a login page.
I think that there is a solution in the universal-cookie package:
https://www.npmjs.com/package/universal-cookie
Server Example:
const cookies = new Cookies(req.headers.cookie);
so could be possible to have an additional version for server?
at this moment I see only this option available in extra_streamlit_components/CookieManager/frontend/src/CookieManager.jsx:
const cookies = new Cookies()

The package doesn't have server support as the CookieManager is a frontend component which communicates back to the server. Not the other way around.


add _apt user back in to /etc/passwd so apt operations do not exit wi…

Hi,
The /etc/passwd files in the ddev web image overwrites the _apt user (and various others)
https://github.com/drud/ddev/blob/master/containers/ddev-webserver/files/etc/passwd
This appears to be causing various odd issues such as when trying to add additional packages to the container once booted since there is no sandbox _apt user and the OS cannot create any more users
To Reproduce
ddev start
ddev . sudo apt-get update
response:
W: No sandbox user '_apt' on the system, can not drop privileges
Version and configuration information:
# ddev version
dba   	drud/phpmyadmin:v1.3.0
router	drud/ddev-router:v1.3.0
commit	v1.3.0
domain	ddev.local
cli   	v1.3.0
web   	drud/ddev-webserver:v1.3.0
db    	drud/ddev-dbserver:v1.3.0

This PR adds back the _apt user
Thanks

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ENH: optimize: Improve least_squares with Default diag=None for LM Method

Reference issue
This PR addresses the issue described in #19459 - "BUG: optimize.least_squares giving poor result compared to optimize.leastsq and optimize.curve_fit".
What does this implement/fix?
This enhancement modifies the behavior of optimize.least_squares when used with the method='lm' (Levenberg-Marquardt algorithm). Previously, unless x_scale was set to 'jac', the default behavior was to use diag=1.0 for scaling, leading to suboptimal fits in certain scenarios. This change proposes to set the default value of x_scale='jac' when method=='lm', aligning the behavior more closely with that of optimize.leastsq and optimize.curve_fit. This results in improved optimization performance and robustness.
Summary of Changes
Set default x_scale='jac' for least_squares with method='lm'.
Additional information

Can you add a unit test demonstrating that the change performs as intended?

Can you add a unit test demonstrating that the change performs as intended?

Updated the unit test and committed the change. Please review the PR and let me know.

I cannot find how to remove my review here unfortunately. Will take a closer look in some time.

Thanks for the email and suggested changes, I did them accordingly and committed them. Please let me know if you need any further updates from me :)

Hi @Roshan-DSBA , if you do the following the doc build check should work:
git fetch --all
git merge upstream/main
git push

Hi @Roshan-Velpula , if you do the following the doc build check should work:
git fetch --all
git merge upstream/main
git push

Hi, Thank you for the message! Pushed the changes and doc build check worked. :)

Hello @lucascolley is there any interest in updating this PR?  I am interested in revisiting it since it would solve an important issue in my view.

Hey @CarrascoCesar ! This isn't my area of expertise, but perhaps you could respond to @dschmitz89's comment above about the purpose of the test?

Hello @dschmitz89 would there be interest in revisiting the PR and creating a simpler test that checks for improved behavior when x_scale is not defined and least_squares defaults to parameter scaling?

@CarrascoCesar : sorry, looking again I think I misunserstood your test. My new interpretation is: you are comparing the new against the old default and the new default has to result in better convergence indicated by a smaller number of function evaluations. Is that correct? In that sense, the test is actually very helpful.
Reading again the complete PR description, it seems that the overall goal is to get the same behaviour as leastsq if least_squares uses Levenberg Marquardt. Currently this is not the case due to different default arguments. WIth this change, we should get the same results. How about we update the test so that we show that we get the same results for least_squares(method=lm) and leastsq? This would make the purpose more explicit.

Hello @dschmitz89, I agree, comparing least_square to leastsq in the test addresses the original issue more directly. I'll work on it to include your recommendation and see if I can come up with a simpler test problem.

Hello @lucascolley, this will be my first time modifying somebody else's PR.  What is the process to checkout the commit for me to make changes and then post?

Hello @lucascolley, this will be my first time modifying somebody else's PR. What is the process to checkout the commit for me to make changes and then post?

hey @CarrascoCesar , personally, I would use GitHub's CLI tool gh and do the following:

Make sure you are in the directory of your clone of this repo
gh checkout 19700 (to checkout this PR)
git checkout -b LM-changes (to make a new branch matching this PR)
Make your changes and commit as usual
Open a new PR from your branch

If you don't want to use gh, you can do the same by adding @Roshan-Velpula's fork as a remote.
If @Roshan-Velpula were active and collaborating, you could instead make a PR to their fork, and the changes could stay in this PR. But no harm in just opening a new PR here!


Make users aware of risks when implementing autoComplete

Hello guys, thank you for your contribution, however I suggest you make the users aware that they have to work on protecting their search form from XFS & XSS attacks... e.g.
Goto your own example form https://tarekraafat.github.io/autoComplete.js/demo/ and search literally for:
hi
then search literally for:

Malicious users may find autoComplete a source of vulnerable clients or victims for attacking others or right on them.
My suggestion is to make users aware of such risks before they go into production. To check their code for Cross-Frame Scripting and Cross-Site Scripting vulnerabilities...
I am not saying you are super wrong, no, your contribution is beautiful, yet there are less experienced users out there probably implementing your code.
Cheers.

Just for reference (and in case anyone has better tips on how I should be doing it), here's how I currently sanitize the query for use in the HTML:
import DOMPurify from "dompurify"

function init() {
    DOMPurify.setConfig({ ALLOWED_TAGS: [] }) // No allowed tags
}

var s = dt => String(DOMPurify.sanitize(String(dt))).trim()

new autoComplete({
	resultsList: {
		element: (element, data) => {
			const { query, matches } = data
			if (
				matches.length === 0
			) {
				const result = document.createElement("p")
				result.innerHTML = `<span class="fa fa-exclamation-triangle"></span>Found no results for "${s(query)}".`
				element.append(result)
			}
		},
	},
})

https://github.com/cure53/DOMPurify

Just for reference (and in case anyone has better tips on how I should be doing it), here's how I currently sanitize the query for use in the HTML:
import DOMPurify from "dompurify"

function init() {
    DOMPurify.setConfig({ ALLOWED_TAGS: [] }) // No allowed tags
}

var s = dt => String(DOMPurify.sanitize(String(dt))).trim()

new autoComplete({
	resultsList: {
		element: (element, data) => {
			const { query, matches } = data
			if (
				matches.length === 0
			) {
				const result = document.createElement("p")
				result.innerHTML = `<span class="fa fa-exclamation-triangle"></span>Found no results for "${s(query)}".`
				element.append(result)
			}
		},
	},
})

https://github.com/cure53/DOMPurify

Anyway I would avoid any output that may contain the query, e.g.
-Found no results for "${s(query)}".
Found no results.
Best practices consider (but not limited to) filtering input on arrival, just the way you are doing it, then encoding the output returned, implementing a content security policy (CSP), and prevent other dangling markup attacks. I suggest you dig much deeper into it.
Good luck!

Hello @needlag,
I totally agree with you on your point of spreading awareness of the possible risks.
That's why I have added to the library's docs under the Usage section a security alert on this specific risk along with some recommendations, and please feel free to check it out and share your feedback on it if you'd like to.
Thank you for raising such a critical point, and have a nice day! :)

Hey @folknor,
Why don't you use the query API instead of the resultsList?

Why don't you use the query API instead of the resultsList?

Do you mean like this?
var s = dt => String(DOMPurify.sanitize(String(dt))).trim()
...
query: q => {
	return s(q)
},

I was investigating it now because of your comment and I think I found a bug in start.js:
export default async function (ctx, q) {
  // Get "input" query value
  let queryVal = q || getQuery(ctx.input);
  queryVal = ctx.query ? query(queryVal) : queryVal;

Last line there should be queryVal = ctx.query ? ctx.query(queryVal) : queryVal;. The bug was introduced now in 10.2.2: https://github.com/TarekRaafat/autoComplete.js/commit/485fd7d398207d0c0da41dbc3e3cb39057f62a1e#diff-d51bf424857227bf919f175f26f72008021098c66d58de2682b0787f8fe5f4d7L16

Could be worth mentioning https://github.com/sindresorhus/escape-goat in the docs as well.

@folknor, good catch as usual!
I've fixed it and publishing it now, and I've added escape-goat to the references as well.
Thanks man, and have a nice day! :)


Different icon for reset button in toolbar

Maybe it is easily possible to use an icon which is more clear. Currently I looks like a symbol for recycling.

Maybe #702 helps here. Or upgrade to newer fontawesome icons.

I don't know what the reset button is. No longer present?


Seems odd to put a Dict[str,Any] into a string

https://github.com/HandyHat/ha-hildebrandglow-dcc/blob/0b58ab9974f02edc2781d32a83fb9c8d6b567244/custom_components/hildebrandglow_dcc/glow.py#L96-L104

This code has been scrapped as of v1.0.0.


Incomplete code sample causes CCE in BlangNodeTransformer

Description:
Consider the bellow sample
public function main() {
     [{}]
}

Causes CCE in BlangNodeTransformer

Fixed with #33374


fix: ci grammar tests using lower python3 versions on macos

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

fix: ci grammar tests using lower python3 versions

2. What is the scope of this PR (e.g. component or file name):

.github/workflows/macos_test.yaml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
471 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-17.5%) to 70.328%

Files with Coverage Reduction
New Missed Lines
%

compiler_base/error/src/diagnostic/components.rs
6
0.0%

compiler_base/error/src/errors.rs
8
0.0%

compiler_base/session/src/lib.rs
26
58.06%

compiler_base/error/src/diagnostic/mod.rs
27
0.0%

compiler_base/error/src/diagnostic/style.rs
41
0.0%

compiler_base/error/src/diagnostic/diagnostic_message.rs
74
0.0%

compiler_base/error/src/emitter.rs
119
0.0%

compiler_base/error/src/diagnostic/diagnostic_handler.rs
170
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-17.5%

Covered Lines:
39217

Relevant Lines:
55763

💛  - Coveralls


⚠ Samsung has degraded performance

In a3fb4af, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2586 ms

Resolved: Samsung performance has improved in 19c2dc8.


IE11 svg with symbol

How to display IE11 svg with symbol, as I  see in your it demo it does not work also:

Seems like IE doesn't support using symbols via external references. I'll add a workaround at some point.

95c7a2f6096eb529971ad69dd8d4a5f736a81d2b


Form Input inventory

Goal: have in inventory of at most input line uses cases.
The form inputs Current cases we have now:
https://techne.yaas.io/components/Form-Elements.html

Normal
Password
Textarea

Form inputs for v2.0 and their usage

Standard:  for Text entry; names, identifiers, etc.
Number: for Numeric information only; prices, amounts, etc.
Password: Info hidden by default.
Units: display units; prices with currencies, etc.
Icon: display an icon to the left or right; search boxes, clear input button, etc.
Limited: is limited to N amount of characters with an indicator of how many characters left.
Read only: only to display information in the context of a form.
Action: display also a button (preferably with icon); add items to a list.

@denisewildner @jeannewalters
Do we have other uses cases?
Note: This issue is only to collect the different types. UX and Visuals will be treated in separate issues.

I created an Invision board to collect examples of existing UIs — and added a Forms section. We should gather examples from EC as well. https://sapse.invisionapp.com/d/main#/projects/boards/5484242

Not posting is products screenshots is, of course a must, but links to protected wiki pages it will be fine. We can also avoid that and only post small screenshots of individual elements.

With the Elements created on #735 and the types on https://github.com/SAP/techne/issues/733#issuecomment-309372007 and looking at the uses cases from https://github.com/SAP/techne/issues/733#issuecomment-309551829
Inputs types with standardised elements

This is done

@joseegm

Reopening this to keep it in context
@LeoT7508
Action and Action + Icon: Since the Icon + Action have a accent color, I think we can give the Action and the Action + Icon the same color to keep it consistent
Read only: is missing the border.

@joseegm
The colors aren't completely flushed out here. I made them black as placeholder. But in theory yes they will probably be a grey shade or the action blue from the color palette.
Jeanne and Irla are still having UX talks about how the fields should look. They were supposed to talk today to finalize.


V2.0 Category scale has weird label rotation

Add lots of data to the line chart. Note that labels rotate in weird ways and never fully 90 degrees.

Fixed in 48be4edbdd


(Feature) Search tokens

Relates to https://github.com/poanetwork/metamask-extension/issues/113
Relates to https://github.com/poanetwork/metamask-extension/issues/134
The first step of tokens management support in NW.
The ability to search tokens by name, symbol, contract address. The tokens are from Mainnet only, as for now.
Search screen:

Confirm screen:

@dennis00010011b could ypu please update e2e tests to support this feature?

@vbaranov
Add tokens-Search:
button 'Next' always active if it was once activated

@vbaranov
Add tokens-Search-Add token:
app is cropped in full screen mode

@vbaranov

The tokens are from Mainnet only, as for now.

Mainnet’s tokens is searchable with any provider

@vbaranov
Long tokens name isn't fully displayed  and there is no option to spread it out

@vbaranov
Main screen: list of added tokens is not scrollable

@vbaranov
Add token dialog: typo, should be this token if one token in the list

@vbaranov
Add token dialog: it would be helpful to have option to delete some token/tokens from the list before addition

@dennis00010011b

app is cropped in full screen mode

Fixed

Mainnet’s tokens is searchable with any provider

I've hidden search tab for networks, other than Mainnet

Long tokens name isn't fully displayed and there is no option to spread it out

Tooltip is added, if a token has long name

Add token dialog: typo, should be this token if one token in the list

It is not a typo, but now text in the dialog depends on the number of tokens

Main screen: list of added tokens has no scrollbar
After scrolling down the main menu is invisible

and

Add token dialog: it would be helpful to have option to delete some token/tokens from the list before addition

Please create feature requests. I suggest to do it in a separate PRs.

@vbaranov
Confirm list is cleared if user goes back from confirm screen to main screen.
It can be done by clicking  'Cancel' on search screen or close and open wallet.  Is it intentional behavior?

yes, @dennis00010011b this is intentional: pending tokens are cleared on cancel or unmounting of view.
In frames of this issue, we also need to fix integration tests. I've added related issue ☝. Please take a look.

Hi @fvictorio @patitonar - finally, it is ready for review

Can the "searchResults" label be changed to "Search results:"?

And maybe "Would you like to add this token?" should be "Would you like to add these tokens?".

Can the "searchResults" label be changed to "Search results:"?

Just removed the text. It takes some space but has no great meaning.

And maybe "Would you like to add this token?" should be "Would you like to add these tokens?".

If there are multiple instances of tokens are chosen, you'll see "Would you like to add these tokens?"

These files seem to have been added by mistake:

Yes, removed them from PR.
Thank you @fvictorio @patitonar for valuable comments. They were processed. I returned back this PR to reviewal stage.


Force HQ.

Hey @doxxx just wanted to know if it feasible of you and you are willing to add the ability to force HQ using the comfort zone + observe spam.
It should be a net cp gain over the long run but this can take over 200~ steps.
More info here : http://forum.square-enix.com/ffxiv/threads/328243-Observe-now-7-CP-!!
Edit: the blog link in the beta site is wrong btw

Smells like an exploit.


Add support for r5d instance types

What
Edit: I reworded the issue to focus only on the r5d instance types and not all the missing ones.
We (GOV.UK PaaS) would like to use the new r5d instance types with instance storage (which also use NVMe).
We forked the repository and added the r5d instance types to the instance storage mapping (INSTANCE_TYPE_DISK_MAPPING) in block_device_manager.rb.
In the cloud configuration we simply used use_instance_storage: true.
When running the bosh deploy we get timeout errors:
Task 38317 | 12:36:37 | Creating missing vms: diego-cell/dd227f39-a519-4fec-b8f0-0229e3a2731e (0) (00:11:00)
                     L Error: Timed out pinging to e86db793-3efc-458f-8ad4-d2ec462482bb after 600 seconds

I also tried to add the r5d instances to the requires_nvme_device function, but got the same timeout.
Versions
bosh: 268.4.0
bosh-cli: 5.2.1
aws-cpi: v73

We've made changes to support r5d instances here and there were some bosh-agent changes that happened just before it.


Tests, CI and docs

added tests in browser as well

@GregTheGreek we can realease after we merge this PR and we would probably wan't to integrate this into bls

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Simplify use of converters with standard XSD date/time types.

Add converter for java.time.Month and textifying converters. Add description of what official XSD date/time type correctly maps with which converter.

2.1.0 has just been released on the Maven Central Repository.


fix: pinned datasets to <3.0.0

This PR pins datasets version to be less than 3.0.0 to avoid datasets.tasks errors.
This solves #1465
Checklist

[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

I think it's better to make changes to v2.0.0 branch

I think this is good. However as @Samoed argues I would move this PR to v2.0.0 (causes a lot of conflict so would just redo it from scratch)

I made #1471 for that. Feel free to close or merge this one if you want.

Thanks I have merged both


AttributeError: 'MAICLearner' object has no attribute 'supervised_loss_with_mixer'

I get a error information when I try to run this code.
Traceback (most recent calls WITHOUT Sacred internals):
File "src/main.py", line 35, in my_main
run(_run, config, _log)
File "/home/liyurui/projects/MAIC/src/run.py", line 64, in run
run_sequential(args=args, logger=logger)
File "/home/liyurui/projects/MAIC/src/run.py", line 258, in run_sequential
learner.train(episode_sample, runner.t_env, episode)
File "/home/liyurui/projects/MAIC/src/learners/maic_learner.py", line 60, in train
mixer=self.target_mixer if self.supervised_loss_with_mixer else None,
AttributeError: 'MAICLearner' object has no attribute 'supervised_loss_with_mixer'

Hello. Thanks for your feedback. That was due to some redundant code from version control issues. We have updated the corresponding code. You may need to pull this repo and rerun the experiment. Feel free to reply us if you encounter other problems.

Thanks for replying during the holidays!


Setting the skin option is not shown in the README.md

In the README.md there is no explaining how to set the skin option:
https://github.com/xzegga/angular2-knob#options
Like in the original ng-knob:
skin | object | { type: 'simple', width: 10, color: 'rgba(255,0,0,.5)', spaceWidth: 5 } | Type: simple or tron

Sorry, currently the me option is not supported

Is it going to be supported soon? Why not support it in the first place?
Should I create a new PR with code updates to support this?


ability to register functions to run before saving to database

Ok so I know there's the 'saving' event that fires off before the save happens.
However, I want to be able to have several asynchronous functions run before the save actually runs. Think preprocessing on models. One example would be using bcrypt to generate a  salt and hash for a model before saving since I don't store the password on the database. Currently, the way I've done this is to overide save.
save: function() {
    return Promise.all([
      this.buildSalt()
    ])
    .bind(this)
    .then(function() {
      return db.Model.prototype.save.call(this);
    });
  },

I'd like to instead have an attribute 'beforeSave'(I'm not picky about what to call it) of functions or strings resolvable to the current instance's methods that would return promises where all of them must resolve before the save runs.
var User = db.Model.extend({
  beforeSave: [
    'buildSalt'
  ],
})

anotther idea I had for more fine grained control would be a function that
itself would return a promise that must resolve before save executes. This might be
more flexible.
the default could then be as simple as
var User = db.Model.extend({
  beforeSave: function() {
    return Promise.resolve();
  },
})

then the example above could be as simple as
var User = db.Model.extend({
  beforeSave: function() {
    return Promise.all([
      this.buildSalt()
    ]);
  },
  buildSalt: function() {
    if (this.get('password')) { return this.generatePasswordHash(); }
    return Promise.resolve().bind(this);
  },
  //generates a promise which is resolved when the user's salt is generated
  getSalt: function() {
    return this.generateSalt().bind(this).then(function(salt) {
      this.set('salt', this.get('salt') || salt);
      return this.get('salt');
    });
  },
  //returns a promise for the salt
  generateSalt: function() {
    return bcrypt.genSaltAsync(8);
  },
  //returns a promise for the password hash
  generatePasswordHash: function() {
    return this.getSalt()
      .bind(this)
      .then(function(salt) {
        return bcrypt.hashAsync(this.get('password'), salt, null);
      })
      .then(function(hash) {
        this.set('password_hash', hash);
        this.unset('password');
        return this;
      });
  },

})

I'd be happy to implement this and submit a pull request if you guys there is enough interest.

Wow, thats cool!  Is that mentioned in the relevant section of the docs?  It's an extremely common use case.


File name pattern regex filter not working

I have a file parameter on which I want to apply a regex pattern so that only file names with a certain set of chars is allowed.
For example, I only want file names like this to be allowed through:
filename.csv
fileName.csv
FileName.csv
FILENAME.CSV
file-name.csv
file_name.csv
file-name123.csv
file_name123.csv
In other words, I want file name to have ONLY: alphanumeric with dash, underscore and dot, mixed cases, (NO SPACES)
The following pattern allows everything, even file names with spaces and should not.
parameters:
- name: file
  type: file
  in: formData
  description: Select the Catalog file to upload
  required: true
  format: file
  pattern: '[\w._-]+'

The following pattern doesn't allow anything through...
parameters:
- name: file
  type: file
  in: formData
  description: Select the Catalog file to upload
  required: true
  format: file
  pattern: '^[a-zA-Z0-9._-]+$'

Looked through Docs and saw nothing helpful for this.
Am I missing something?
Thanks!

Are digits allowed only at the end of the filename or at any place?
The dot may scour anywhere or only just before the suffix?
The suffix may have any length?
An example for filenames allowing your specified characters with digits at any place and a suffix of any length. Only the '.' just preceding the suffix is allowed:
^[a-zA-Z0-9_-]+.[a-zA-Z0-9_-]+$

pattern is a json schema keyword, and therefore needs to be under the schema property in your specification.

@karenetheridge this is OpenAPI 2.0, where non-body parameters don't use schema.

@ANTGOMEZ the pattern applies to the parameter value, which is this case is the file contents, not its name. The specification currently has no way to limit the file names for file uploads.
Related: #2458.


onDisconnected not called after killing the gatt server

I am only starting with BLE and I might be missing something here. I am looking for a way to consistently detect disconnects even if the connection was not closed gracefully.
As per title, I am not getting any kind of indication when killing the server. The callback is not getting called, isConnected always returns true.

@jnorkus i dont see how you expect it work if you kill the GATT server. why would you do that ? killing the app and killing the GATT server are very different. killing the app might happen but you don't care cause your app is killed... killing GATT should not happen and would mean (not 100% sure) needing to restart the app for the ble plugin state machine to restart

@farfromrefug By killing the GATT server I'm simulating a loss of connection. In real life that could be e.g. out of range.

@jnorkus no you are not it is very different. loss of connection is handled by the GATT server. without the GATT server you can't be notified. out or range === manually turning off your device without it sending any notif.
be aware connection loss notification in those cases can take sometimes up to a minute or so

Thanks @farfromrefug I think I understand the issue now. The BLE connection is not terminated in case the GATT server is shut down, that effectively means it's still connected. Turning off BT on the server peripheral works fine and the onDisconnect callback is called.